MLIR Textual PassPipeline Error on VMFB load (Unet512 & VAE)

I've successfully recreated this issue on multiple, unrelated models. This issue does not seem to break model generation, and images are created as normal, but it may have an affect on image generation time (i.e. it/s), as can be seen by the generation logs below.
Found device AMD Radeon RX 7900 XTX. Using target triple rdna3-7900-windows.
Tuned models are currently not supported for this setting.
saving euler_scale_model_input_1_512_512_vulkan_fp16_torch_linalg.mlir to C:\Users\nelso\AppData\Local\Temp
No vmfb found. Compiling and saving to D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\euler_scale_model_input_1_512_512_vulkan_fp16.vmfb
Configuring for device:vulkan://00000000-5500-0000-0000-000000000000
Using target triple -iree-vulkan-target-triple=rdna3-7900-windows from command line args
Saved vmfb in D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\euler_scale_model_input_1_512_512_vulkan_fp16.vmfb.
WARNING: [Loader Message] Code 0 : windows_read_data_files_in_registry: Registry lookup failed to get layer manifest files.
Loading module D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\euler_scale_model_input_1_512_512_vulkan_fp16.vmfb...
        Compiling Vulkan shaders. This may take a few minutes.
saving euler_step_1_512_512_vulkan_fp16_torch_linalg.mlir to C:\Users\nelso\AppData\Local\Temp
No vmfb found. Compiling and saving to D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\euler_step_1_512_512_vulkan_fp16.vmfb
Configuring for device:vulkan://00000000-5500-0000-0000-000000000000
Using target triple -iree-vulkan-target-triple=rdna3-7900-windows from command line args
Saved vmfb in D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\euler_step_1_512_512_vulkan_fp16.vmfb.
Loading module D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\euler_step_1_512_512_vulkan_fp16.vmfb...
        Compiling Vulkan shaders. This may take a few minutes.
use_tuned? sharkify: False
_1_64_512_512_fp16_rockymixRecreated_v2
Diffusers' checkpoint will be identified here :  D:/Stable/stable-diffusion-shark/apps/stable_diffusion/web/models/diffusers/rockymixRecreated_v2
Loading diffusers' pipeline from original stable diffusion checkpoint
`text_config_dict` is provided which will be used to initialize `CLIPTextConfig`. The value `text_config["id2label"]` will be overriden.
`text_config_dict` is provided which will be used to initialize `CLIPTextConfig`. The value `text_config["bos_token_id"]` will be overriden.
`text_config_dict` is provided which will be used to initialize `CLIPTextConfig`. The value `text_config["eos_token_id"]` will be overriden.
D:\Stable\stable-diffusion-shark\shark.venv\Lib\site-packages\transformers\models\clip\feature_extraction_clip.py:28: FutureWarning: The class CLIPFeatureExtractor is deprecated and will be removed in version 5 of Transformers. Please use CLIPImageProcessor instead.
  warnings.warn(
Loading complete
Diffusers' checkpoint will be identified here :  D:/Stable/stable-diffusion-shark/apps/stable_diffusion/web/models/vae/diffusers/BerrysMix.vae
Loading diffusers' pipeline from original stable diffusion checkpoint
Processing standalone Vae checkpoint
mat1 and mat2 shapes cannot be multiplied (128x1024 and 768x320)
Retrying with a different base model configuration
D:\Stable\stable-diffusion-shark\shark.venv\Lib\site-packages\torch\fx\node.py:263: UserWarning: Trying to prepend a node to itself. This behavior has no effect on the graph.
  warnings.warn("Trying to prepend a node to itself. This behavior has no effect on the graph.")
saving unet_1_64_512_512_fp16_rockymixRecreated_v2_vulkan_torch_linalg.mlir to .
No vmfb found. Compiling and saving to D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb
Configuring for device:vulkan://00000000-5500-0000-0000-000000000000
Using target triple -iree-vulkan-target-triple=rdna3-7900-windows from command line args
Saved vmfb in D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb.
Loading module D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb...
        Compiling Vulkan shaders. This may take a few minutes.
::: Detailed report (took longer than 2.5s):
  +1.0027885437011719ms: get_iree_runtime_config
  +1.0027885437011719ms: mmap D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb
  +1.0027885437011719ms: ireert.SystemContext created
  +11395.0035572052ms: module initialized
saving clip_1_64_512_512_fp16_rockymixRecreated_v2_vulkan_torch_linalg.mlir to .
No vmfb found. Compiling and saving to D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\clip_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb
Configuring for device:vulkan://00000000-5500-0000-0000-000000000000
Using target triple -iree-vulkan-target-triple=rdna3-7900-windows from command line args
Saved vmfb in D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\clip_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb.
Loading module D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\clip_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb...
        Compiling Vulkan shaders. This may take a few minutes.
saving unet512_1_64_512_512_fp16_rockymixRecreated_v2_vulkan_torch_linalg.mlir to .
No vmfb found. Compiling and saving to D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet512_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb
Configuring for device:vulkan://00000000-5500-0000-0000-000000000000
Using target triple -iree-vulkan-target-triple=rdna3-7900-windows from command line args
Saved vmfb in D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet512_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb.
Loading module D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet512_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb...
        Compiling Vulkan shaders. This may take a few minutes.
::: Detailed report (took longer than 2.5s):
  +0.0ms: get_iree_runtime_config
  +1.0077953338623047ms: mmap D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\unet512_1_64_512_512_fp16_rockymixRecreated_v2_vulkan.vmfb
  +1.0077953338623047ms: ireert.SystemContext created
  +3854.9232482910156ms: module initialized
MLIR Textual PassPipeline Parser:1:11: error: 'iree-flow-detach-elementwise-from-named-ops' does not refer to a registered pass or pass pipeline
func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32})
          ^
ERROR: mismatched parenthesis in pass pipeline `builtin.module(func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32}))`
MLIR Textual PassPipeline Parser:1:11: error: 'iree-flow-detach-elementwise-from-named-ops' does not refer to a registered pass or pass pipeline
func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32})
          ^
ERROR: mismatched parenthesis in pass pipeline `builtin.module(func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32}))`
30it [00:09,  3.28it/s]
saving vae_1_64_512_512_fp16_rockymixRecreated_v2BerrysMix.vae_vulkan_torch_linalg.mlir to .
No vmfb found. Compiling and saving to D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\vae_1_64_512_512_fp16_rockymixRecreated_v2BerrysMix.vae_vulkan.vmfb
Configuring for device:vulkan://00000000-5500-0000-0000-000000000000
Using target triple -iree-vulkan-target-triple=rdna3-7900-windows from command line args
Saved vmfb in D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\vae_1_64_512_512_fp16_rockymixRecreated_v2BerrysMix.vae_vulkan.vmfb.
Loading module D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\vae_1_64_512_512_fp16_rockymixRecreated_v2BerrysMix.vae_vulkan.vmfb...
        Compiling Vulkan shaders. This may take a few minutes.
::: Detailed report (took longer than 2.5s):
  +0.0ms: get_iree_runtime_config
  +0.0ms: mmap D:\Stable\stable-diffusion-shark\apps\stable_diffusion\web\vae_1_64_512_512_fp16_rockymixRecreated_v2BerrysMix.vae_vulkan.vmfb
  +0.0ms: ireert.SystemContext created
  +9483.099699020386ms: module initialized
MLIR Textual PassPipeline Parser:1:11: error: 'iree-flow-detach-elementwise-from-named-ops' does not refer to a registered pass or pass pipeline
func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32},iree-linalg-ext-convert-conv2d-to-winograd)
          ^
ERROR: mismatched parenthesis in pass pipeline `builtin.module(func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32},iree-linalg-ext-convert-conv2d-to-winograd))`
30it [00:09,  3.27it/s]
30it [00:09,  3.25it/s]
30it [00:09,  3.23it/s]
30it [00:09,  3.33it/s]
30it [00:09,  3.30it/s]
30it [00:08,  3.34it/s]
30it [00:08,  3.37it/s]
30it [00:08,  3.38it/s]

Software / Hardware Information

Windows 11 22H2
RX 7900 XTX
Adrenalin 23.9.3
Vulkan 2.0.283
SHARK v4797bb8

Also seeing this issue.
Loading module C:\Users\ean\SHARK\unet_1_64_512_512_fp16_tuned_stable-diffusion-2-1-base_vulkan.vmfb...
        Compiling Vulkan shaders. This may take a few minutes.
::: Detailed report (took longer than 2.5s):
  +1.0018348693847656ms: get_iree_runtime_config
  +1.0018348693847656ms: mmap C:\Users\ean\SHARK\unet_1_64_512_512_fp16_tuned_stable-diffusion-2-1-base_vulkan.vmfb
  +1.0018348693847656ms: ireert.SystemContext created
  +10027.31704711914ms: module initialized
MLIR Textual PassPipeline Parser:1:11: error: 'iree-flow-detach-elementwise-from-named-ops' does not refer to a registered pass or pass pipeline
func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32},iree-linalg-ext-convert-conv2d-to-winograd)
          ^
ERROR: mismatched parenthesis in pass pipeline `builtin.module(func.func(iree-flow-detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32},iree-linalg-ext-convert-conv2d-to-winograd))`
50it [00:12,  4.15it/s]

Similar setup, 7900xtx, win11, adrenalin <IP_ADDRESS>
seen on latest exe (996)
Something is gutting performance here, I usually see >20it/s
I can find out what happened to the flag here but would be (pleasantly) surprised if that fixes everything...

Also got this and the performance regression.

993 is the first nightly I see this issue on.

I think this commit in SRT (presumably taken from upstream) might be the culprit https://github.com/nod-ai/SRT/commit/b7fd66860adf5a2fcd6b61c7cbbbe64f33474cd7
Commit message mentions both Convert1X1FilterConv2DToMatmul, DetachElementwiseFromNamedOps. Commenting those out removes the error and gets most of the performance back.

Checking 825b36c, will report back with issues or close if good.

@one-lithe-rune
New, seemingly related issue off fresh install (cleared caches & regenerated venv) off this commit.
MLIR Textual PassPipeline Parser:1:61: error: 'iree-global-opt-detach-convert-1x1-filter-conv2d-to-matmul' does not refer to a registered pass or pass pipeline
func.func(iree-global-opt-detach-elementwise-from-named-ops,iree-global-opt-detach-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32})
                                                            ^
ERROR: mismatched parenthesis in pass pipeline `builtin.module(func.func(iree-global-opt-detach-elementwise-from-named-ops,iree-global-opt-detach-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32}))`
MLIR Textual PassPipeline Parser:1:61: error: 'iree-global-opt-detach-convert-1x1-filter-conv2d-to-matmul' does not refer to a registered pass or pass pipeline
func.func(iree-global-opt-detach-elementwise-from-named-ops,iree-global-opt-detach-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32})
                                                            ^
ERROR: mismatched parenthesis in pass pipeline `builtin.module(func.func(iree-global-opt-detach-elementwise-from-named-ops,iree-global-opt-detach-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=32}))`

Error occurs on Unet512 only, VAE error is gone.
Performance has not increased or decreased.

Resolved with 0361db4


docs: Add KMS aliases handling to IAM permissions

PR o'clock
Description
Useful when you assign an alias to a KMS key.
Checklist

[ ] CI tests are passing
[ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

Thanks @ahamez for your contribution.


[tests] Add a README.md to Aspire.EndToEnd.Tests

Microsoft Reviewers: Open in CodeFlow

this looks obsolete now @radical ?

this looks obsolete now @radical ?

Yes. I was keeping it open to get to the problems that @eerhardt had. I have opened https://github.com/dotnet/aspire/issues/4784 to track that.


Implement cubemap probe grid, cubemap caching, and fix a few bugs

Replace the hashtable with a new Grid struct which acts as a wrapper around a region of memory accessable with 3 coordinates.
This fixes several issues:

Cubemap probes are selected regardless of how far away the closest one is
Both the nearest and second nearest cubemaps are always selected
Performance is much better now while selecting the cubemap probes at all times, access time is low and pretty much constant, with a few extra operations for interpolation. The code supports sampling up to 8 grid points, but I didn't wanna bother with adding a lot of extra GLSL code to support that, so it still uses 2 cubemaps.

Implemented cubemap caching on disks. This saves the cubemaps themselves along with a file containing the grid, cubemap probe list and version + parts of BSP header + cubemap size and spacing in homePath/reflectionCubemaps/mapName/, and loads them from disk if available and the settings match.
Added an r_autoBuildCubeMaps cvar for it:
0: off
1: cache on disk
2: always rebuild on map load
Also fixed static reflections with material system and a few minor bugs.
Additionally fixed the issue that result in the engine looking for images in the format of name.ext.ext, which was obviously failing.
r_showCubeProbes is now a 0-2 range cvar:
0: off
1: show cubemap grid
2: show only unique cubemaps

I just did a bit of testing. My impressions:

It could use more interpolation. The discontinuous cubemap changes are pretty noticeable.
plat23 has way too much specularity on its textures. When you walk around in the outside area, the impression at some places is that the whole map is just randomly blinking. (I guess it's still choosing only one cubemap for all surfaces in the view.)
The r_gamma setting gets baked into the cubemaps. I suppose they ought to be rendered without any screen-space effects.
It's annoying that r_autoBuildCubeMaps builds them even if reflection mapping is disabled via cvars. I was confused for a while that nothing was happening even though cubemaps were built; turns out r_specularMapping was disabled.

This Parpax tank looks cool although it shows the discontinuousness problem.
parpax-reflection.webm

It could use more interpolation. The discontinuous cubemap changes are pretty noticeable.

I agree, I've tried adjusting the formula for interpolation and the results seemed to be smoother, so I'll take another look at it.

plat23 has way too much specularity on its textures. When you walk around in the outside area, the impression at some places is that the whole map is just randomly blinking.

That'd be an asset issue then I suppose, though the blinking may be improved with better interpolation etc.

(I guess it's still choosing only one cubemap for all surfaces in the view.)

It is, yeah (well, 2 cubemaps to be specific). The problem with assigning a cubemap to each surface is that:

It would look wrong on large surfaces that have multiple cubemaps near them
It would break batching
As I've said elsewhere, I believe that selecting one or more cubemaps per tile with the tiled renderer would fix this issue. After the rewrite in #1333 it would be easy to reserve some memory in each tile for a cubemap/cubemaps.

This would probably require using an array texture as having hundreds of sampler uniforms is not gonna work, and storing the cubemap ID in the tile, which would also be its layer in the texture. I have some code that adds support for array textures (only for 2D ones there, but it can be extended to cubemaps) in https://github.com/VReaperV/Daemon/tree/material-clusters, but it has some bugs still and would need to be ported over the newer commits, so that will have to wait until after 0.55 is released. The cubemap grid would then be uploaded as a 3D texture and accessed in lighttile_fp. The code there already knows the (minimum?) depth at each fragment, so getting the grid position from that would be trivial.
Then cubemap selection would be based on where a fragment is spatially and would work properly in most cases (other than perhaps where there's a large depth discontinuity within one tile).
This would, of course, not work without the tiled renderer, but even then I believe it can be brought to an acceptable quality.

The r_gamma setting gets baked into the cubemaps. I suppose they ought to be rendered without any screen-space effects.

I think so too. The problem I ran into is that overbright settings are "baked" into the shaders (the shader struct that is) at map loading time, so it would probably require doing a vid_restart twice (some extra shader code under a define can be done easily though). r_gamma can be changed to 1.0 for the duration of cubemap rendering easily though.

It's annoying that r_autoBuildCubeMaps builds them even if reflection mapping is disabled via cvars. I was confused for a while that nothing was happening even though cubemaps were built; turns out r_specularMapping was disabled.

I'll recheck the cvar combinations to make sure it's not built when it's unusable. I don't like how reflections require a combination of cvars to be enabled (and one disabled) to work, but I don't know a solution for that right now. I can add a warn or something in console if r_reflectionMapping is enabled but the other required cvars are not, but it would be easy to miss. I did add it in the description of the setting in https://github.com/Unvanquished/Unvanquished/pull/3110 at least (this should be done for some other graphics settings too...). Maybe adding a popup after the map is loaded if such a combination of cvars is detected, with options to auto-adjust settings, close, or never show again, would work.

The r_gamma setting gets baked into the cubemaps. I suppose they ought to be rendered without any screen-space effects.

I made it set r_gamma to 1.0 when building cubemaps now. cameraEffects shader still has to be used for overbright.

I can add a warn or something in console if r_reflectionMapping is enabled but the other required cvars are not, but it would be easy to miss.

I've done this now. It will also not build cubemaps anymore if some cvar is missing. I don't like the fact the warn is quite high up in the console, but that can be improved in the future. There are other cvar combinations that require this, so some generalised solution would be better, but it's out of scope here.

Also fixed a shader macro conflict with material system.

It could use more interpolation. The discontinuous cubemap changes are pretty noticeable.

So this is apparently not an issue with interpolation, but an issue of cubemap placement. Right now they just placed in empty BSP leafs with a distance check for nearby cubemaps, but that doesn't mean that they properly encompass an area.
I've changed the default r_cubeProbeSpacing to 256 now, which helps somewhat, but a proper fix would require a bunch more work and wouldn't fit into this pr.

Notably, with the change to r_cubeProbeSpacing there's no longer any issue with the tank on parpax.

Additionally fixed the issue that was resulting in the engine looking for images in the format of name.ext.ext, which was obviously failing.

@VReaperV This is wanted. A q3 shader can contain image path without ext. So for example image.blend.jpg can be written as image.blend, meaning the ext split will provide image and blend but we need to look for image.blend.ext so image.ext1.ext2, see: 15815d42ec5c006b7bb254f12fc827fb66fafec1.

Additionally fixed the issue that was resulting in the engine looking for images in the format of name.ext.ext, which was obviously failing.

@VReaperV This is wanted. A q3 shader can contain image path without ext. So for example image.blend.jpg can be written as image.blend, meaning the ext split will provide image as basename and blend as ext but we need to look for image.blend.ext so image.ext1.ext2, see: 15815d4.

I don't think it's the same issue. In this case engine was looking for image.ktx.ktx and failing because of that, that makes 0 sense.

Additionally fixed the issue that was resulting in the engine looking for images in the format of name.ext.ext, which was obviously failing.

@VReaperV This is wanted. A q3 shader can contain image path without ext. So for example image.blend.jpg can be written as image.blend, meaning the ext split will provide image as basename and blend as ext but we need to look for image.blend.ext so image.ext1.ext2, see: 15815d4.

In fact, I don't even think I changed the code you linked, since I changed R_FindCubeImage() rather than R_LoadImage().


Allow recipes from subdirectories

package tools need to get the recipe from the correct path
This allows building bincrafters/conan-flex#4 on my machine

Codecov Report

Merging #21 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #21      +/-   ##
=========================================
+ Coverage   98.63%   98.7%   +0.07%
=========================================
  Files           8       8
  Lines         146     155       +9
=========================================
+ Hits          144     153       +9
  Misses          2       2

Impacted Files
Coverage Δ

bincrafters/build_shared.py
98.24% <100%> (+0.11%)
:arrow_up:

bincrafters/build_template_boost_default.py
100% <100%> (ø)
:arrow_up:

bincrafters/build_template_default.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbb900...5c88db9. Read the comment docs.

Is it not possible only using tools.chdir, instead of passing the recipe path?

The flex pr has 2 sub directories containing the recipes with the common code in the main directory.
When using docker, it needs to mount the main directory instead of only the sub directory.
(mounting only the sub directory would hide the main directory in the docker instance)

@uilianries WDYT, should we merge this one?
BTW, CI seems to be stuck for unknown reason

Seems weird, but I think it's an event error, since Travis is green:
https://travis-ci.com/bincrafters/bincrafters-package-tools/builds/105447388
I think it's okay, since CPT is up-to-date in our CI.


NPE Attempt to invoke interface method 'void com.mixpanel.android.mpmetrics.MixpanelAPI$People.append(java.lang.String, java.lang.Object)' on a null object reference

We have NPE
https://gist.github.com/miroslavign/b4002219496ff824cf2501e6323551c5
How could we resolve this, or get more information about a crash?

Just to add, we are using version 4.9.2

Hi @miroslavign! You need to make sure you are identifying the user on the SDK in order to be able to track people data. Are you calling mYourMixpanelInstance.getPeople().identify(aUserId) ?

I am attaching the screenshots from prefs, where you could check the data. For one user (Nikola)
it is not crashing, and for the other user (Manav) it is. As you can see, both are identified, am I right ?
Anything else from prefs or logs I could catch to help resolving this one ?

Tnx, as both you and Joey from support suggested, in parallel to providing identify
to mixpanel instance:
mixpanel.identify(userId);
we should provide the same to People object:
......
mixpanel.getPeople().set("name", userName);
mixpanel.getPeople().identify(userId);    <-- THIS one did the job
.......
Tnx for help in clearing this out.

Glad it worked!


[Feature]: Possibility to use another icons font

I'm submitting a

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request

Description
My proposal is to add the possibility to use another icon set, for example material icons.
My motivation is: I want to implement ngx-editor on a Material Angular based application, but I really don't want to clog my application with another font package if I don't really need it.
I'm willing to help on development of this feature if necessary.
Version Information
not relevant
Browser
not relevant

Nice one. So Material Projects can use that too. Without FA

Material misses few icons I guess or Did I miss the following

Ordered List
Paragraph
Eraser
Horizontal line
Quote
Unlink

So, this won't be a viable option.
Proposal
Since all components are capable of working individually. Alternatively, What I can do is I can expose the API's for toolbar and Message component. You can disable the default toolbar and design your own and then you can interact with the Editor.
Hope that will work 😕
What do You think?

Ordered list format_list_numbered
Paragraph ~didn't found~
Eraser ~didn't found~
Horizontal line ~didn't found~
Quote format_quote
Unlink ~didn't found~

Yeah, unfortunately the font misses many icons.
I think that exposing API for toolbar might solve the issue, but is a "reinvent the wheel" job...
Maybe we can solve it by embedding a fork of font-awesome (or any other) containing only necessary icons, so we:

Avoid needing of import font-awesome on entire project
Make the component lighter since it will load a smaller font.

I'm not sure if it's possible to embed fonts on angular components, but I think so!

but is a "reinvent the wheel" job...

I won` t be I guess. It is already there. I just have to export the component (I guess). Let me try that.
Also, I won't be able to work on this for long. I mat not be able to find time, since we are planning of a new project.

Alright, thanks!

@iget-master . What about using SVG's https://www.flaticon.com/packs/font-awesome

My only care is about overhead. Loading an entire icon font for using 10~15 icons is overhead.
Even loading 10~15 icons pack is overhead if we already use another icon font, but of course that's better then an entire icon font.
I'll think about some way to solve it...

@iget-master. If this package https://github.com/FortAwesome/angular-fontawesome gets ready I have no need for font dependency. I may be able to ship icons that are only needed along with this editor.
It is not yet production ready.

closing this now. I will work on backlogs when I get some time.


implement todo list

In this project, I implemented the following:

Add a task to the list
edit task
remove task
clear completed task

Hello Sonia.
The majority of the functions that are in your JS files are very clear and easy to read, you've respected the DRY Principle by not having any duplicate code making your code very well structured and and easily maintained well done

Great use of ES6 Modules


[fix] [doc] fix multiple apis in the automatically generated documentation use the same anchor point

Motivation
Now that site admin-rest-api is automatically generated through swagger, each API in the site has its own link that we can walk through, the generated rule of API-link is https://pulsar.apache.org/admin-rest-api/#operation/{operationId}, we call the suffix #operation/{operationId} of link anchor.
Since the {operationId}'s default value is the method name of the endpoint class, and there has the same method name in the multi endpoint-classes, such as Namespaces.setDispatchRate and PersistentTopics.setDispatchRate, so these both APIs will generate the same link: https://pulsar.apache.org/admin-rest-api/#operation/setDispatchRate.
Modifications
In the update to version 3.1.8 of swagger-maven-plugin, there are another ways to set operationId: The Operation Id Format. see https://github.com/kongchen/swagger-maven-plugin/blob/e4cf3af6ed4a4987b2269a05b7037549bc4a5511/src/main/java/com/github/kongchen/swagger/docgen/reader/AbstractReader.java#L535-L540. So we can generate operationId using the specified rule {className}_{methodName}.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[x] Anything that affects deployment

Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

https://github.com/poorbarcode/pulsar/pull/51

Hi @dave2wave

These look like actual API changes. Please explain.

Already changed the plain to only modify Swagger annotations. please take a look again

@tisonkun  What do you think about this PR? I am not familiar with swagger, but I know you have worked on this part recently.

I agree that it's not a breaking change for end-users but only affects the doc experience.
Some related works previous:

https://github.com/apache/pulsar/pull/19025
https://github.com/apache/pulsar/pull/19065

And I agree that a nickname alias can be a better solution. I can approve this move but I appreciate seeing the discussion on the mailing list continue for a while (days or after the lunar new year holiday).
cc @tuteng

Now we aggregate rest api into a single file. I think it might be better to split them. This is also good for us to generate other language admin clients. I am trying to work on it.

@tisonkun @tuteng @heesung-sn
Please take a look, thanks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

Codecov Report

Merging #19193 (e414067) into master (af1360f) will increase coverage by 35.91%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #19193       +/-   ##
=============================================
+ Coverage     26.40%   62.31%   +35.91%
+ Complexity     6427     3503     -2924
=============================================
  Files          1597     1848      +251
  Lines        123682   135866    +12184
  Branches      13511    14952     +1441
=============================================
+ Hits          32658    84665    +52007
+ Misses        86336    43466    -42870
- Partials       4688     7735     +3047

Flag
Coverage Δ

inttests
24.53% <ø> (-0.05%)
:arrow_down:

systests
25.28% <ø> (?)

unittests
59.54% <ø> (+42.14%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...in/java/org/apache/pulsar/common/api/AuthData.java
71.42% <0.00%> (ø)

.../apache/pulsar/broker/namespace/LookupOptions.java
87.50% <0.00%> (ø)

.../apache/pulsar/common/naming/SystemTopicNames.java
55.55% <0.00%> (ø)

...apache/pulsar/common/util/SafeCollectionUtils.java
0.00% <0.00%> (ø)

...pache/pulsar/common/configuration/BindAddress.java
22.22% <0.00%> (ø)

...r/client/admin/internal/data/AuthPoliciesImpl.java
65.21% <0.00%> (ø)

...sar/common/policies/data/impl/BundlesDataImpl.java
92.30% <0.00%> (ø)

...ar/common/policies/data/InactiveTopicPolicies.java
83.33% <0.00%> (ø)

...r/authentication/AuthenticationProviderAthenz.java
69.64% <0.00%> (ø)

...r/io/hdfs3/sink/text/HdfsAbstractTextFileSink.java
80.00% <0.00%> (ø)

... and 1354 more

Hi @tisonkun

Please take a look at the OWASP failure. Although it seems unrelated to this patch, we should fix it later.

I have pushed a https://github.com/apache/pulsar/pull/19764 to fix it, so I am merging the current PR now.


Yarn PnP Compatability

Fixes https://github.com/yarnpkg/berry/issues/3123, fixes https://github.com/vuejs/language-tools/issues/918. 🥳

🤔 Should this be fixed in https://github.com/volarjs/volar.js?

Hmm. I see what you mean. Let me work on a PR on that front, then. Feel free to close this one.

Did https://github.com/vuejs/language-tools/pull/3788 fix this?

Did #3788 fix this? It closed the linked issue.

Yes, this PR makes everything based on the original tsserver.


Add support for Aqara smart wall switch H1 EU (no neutral, single rocker)

Device model
lumi.switch.l1aeu1
Device name
Aqara smart wall switch H1 EU (no neutral, single rocker)
Does the device require a MiCloud connection?
Do not know
Anything special about the device?
It currently doesn't work at all with the plugin. In my Mi Home I can start the pairing process, but at some point it says that is not compatible with my gateway (lumi.gateway.mgl03 ).

It might be that it is a micloud only device. Did you try to specify your MiCloud credentials and set the forceMiCloud property to true?

I can’t because I don’t have its token or IP address.

Sorry, i do not understand how you are even trying to connect it if you are missing the ip address or token...


MSSQL Common language runtime (CLR) types get wrongly parsed

I want to use the geography clr type from mssql https://learn.microsoft.com/en-us/sql/t-sql/spatial-geography/spatial-types-geography?view=sql-server-ver16
But it interprets the :: as a cast and turns
GEOGRAPHY::Point([latitude], [longitude], 4326) AS geopoint_new,
into
CAST([GEOGRAPHY] AS Point(LATITUDE, LONGITUDE, 4326)) AS [geopoint_new],
I'm using that to get the geospatial distance between two points. Otherwise I have to roll up my own geospatial calculation in sql.

cc @VaggelisD


python311Packages.torchmetrics: 1.3.2 -> 1.4.0

Description of changes
Changelog: https://github.com/Lightning-AI/torchmetrics/releases/tag/v1.4.0
cc @SomeoneSerge
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 309553 run on x86_64-linux 1

6 packages marked as broken and skipped:

piper-train
piper-train.dist
python311Packages.elegy
python311Packages.elegy.dist
python311Packages.treex
python311Packages.treex.dist

4 packages failed to build:

python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

10 packages built:

python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on x86_64-linux 1

14 packages marked as broken and skipped:

piper-train
piper-train.dist
python311Packages.elegy
python311Packages.elegy.dist
python311Packages.treex
python311Packages.treex.dist
python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

10 packages failed to build:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist

4 packages built:

python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on aarch64-linux 1

10 packages marked as broken and skipped:

piper-train
piper-train.dist
python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

14 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on aarch64-darwin 1

8 packages marked as broken and skipped:

python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

2 packages failed to build:

python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist

12 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on x86_64-darwin 1

8 packages marked as broken and skipped:

python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

14 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on aarch64-linux 1

10 packages marked as broken and skipped:

piper-train
piper-train.dist
python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

14 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on x86_64-darwin 1

8 packages marked as broken and skipped:

python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

14 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on aarch64-linux 1

10 packages marked as broken and skipped:

piper-train
piper-train.dist
python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

14 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on x86_64-linux 1

14 packages marked as broken and skipped:

piper-train
piper-train.dist
python311Packages.elegy
python311Packages.elegy.dist
python311Packages.treex
python311Packages.treex.dist
python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

14 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist

Result of nixpkgs-review pr 309553 run on aarch64-darwin 1

8 packages marked as broken and skipped:

python312Packages.lightning-utilities
python312Packages.lightning-utilities.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
python312Packages.rising
python312Packages.rising.dist
python312Packages.torchmetrics
python312Packages.torchmetrics.dist

2 packages failed to build:

python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist

12 packages built:

python311Packages.lightning-utilities
python311Packages.lightning-utilities.dist
python311Packages.pretty-errors
python311Packages.pretty-errors.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python311Packages.rising
python311Packages.rising.dist
python311Packages.torchmetrics
python311Packages.torchmetrics.dist
python312Packages.pretty-errors
python312Packages.pretty-errors.dist


Adding multi node IT

Description
adding multi node IT
Issues Resolved
resolves #354
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CI is not running, is there a syntax error? I believe run shouldn't be tabbed in.

@amitgalitz I see the multi node tests are failing with TimeoutException, do we have any idea about it?

I see the multi node tests are failing with TimeoutException, do we have any idea about it?

Yeah let's get the single node tests passing consistently and see if it fixes these, if so merge away.

Yeah let's get the single node tests passing consistently and see if it fixes these, if so merge away.

Still fails with the same exception. Do we have to add a TimeoutSuite for the integ tests?

Still fails with the same exception. Do we have to add a TimeoutSuite for the integ tests?

Looks to me like tests are running before the cluster is up and connected.

getting lots of time out exceptions locally now too, I didn't see this before, so trying out a few different commits locally to see if I can locate any big differences

Seems removing the wipreAllIndices method resolved most of the issues we're seeing. All but 1 multi-node test passed
1> [2024-01-12T04:01:49,541][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionAgentFrameworkWorkflow] before test
  1> [2024-01-12T04:01:49,544][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionAgentFrameworkWorkflow] initializing REST clients against [http://[::1]:36829, http://<IP_ADDRESS>:41505,/ http://[::1]:46719, http://<IP_ADDRESS>:41221,/ http://[::1]:41357, http://<IP_ADDRESS>:46585]/
  1> [2024-01-12T04:02:27,917][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionAgentFrameworkWorkflow] after test
  1> [2024-01-12T04:02:27,922][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testSearchWorkflows] before test
  1> [2024-01-12T04:02:28,156][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testSearchWorkflows] after test
  1> [2024-01-12T04:02:28,160][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionLocalModelWorkflow] before test
  1> [2024-01-12T04:06:41,908][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionLocalModelWorkflow] after test
  1> [2024-01-12T04:06:41,913][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionRemoteModelWorkflow] before test
  1> [2024-01-12T04:11:16,175][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionRemoteModelWorkflow] after test

Tests with failures:
 - org.opensearch.flowframework.rest.FlowFrameworkRestApiIT.testCreateAndProvisionRemoteModelWorkflow

5 tests completed, 1 failed

closing for #416


TP-LINK TL-WN722N: The device does not support Access Point mode

Hello! I'm trying to use Wifi-Connect with Balena, a Raspberry Pi CM4, and a TL-WN722N as recommended by the Readme here.
However, I'm getting the following D-Bus error when Wifi Connect tries to start an access point:
Can anyone advise on why that might be?
 wifi-connect  [network_manager::dbus_api:ERROR] org.freedesktop.NetworkManager::AddAndActivateConnection method call failed on /org/freedesktop/NetworkManager
 wifi-connect  Error: Creating the captive portal failed
 wifi-connect    caused by: D-Bus failure: org.freedesktop.NetworkManager::AddAndActivateConnection method call failed on /org/freedesktop/NetworkManager
 wifi-connect    caused by: "the device does not support Access Point mode"

Closing the loop here, I've had good success with the Panda Wireless modules which seem to play nicely with Network manager.


NTR: vesicle assembly

Figure 1 in PMID:25898166 shows that knock down of PICALM Q13492 in cultured cells results in an increase in size of clathrin-coated vesicles and in reduced ability to 'close' the vesicles being formed.
I would like to capture this using a new term 'vesicle maturation', which could be defined as:
"A process that is carried out at the cellular level, which results in the assembly and arrangement of constituent parts of a vesicle. Vesicle maturation begins with membrane bending (GO:0097753) and ends with vesicle scission (GO:0099050)."

GO:0016050 vesicle organization

NTR vesicle maturation

GO:0016188 synaptic vesicle maturation

I also wonder whether the definition of 'GO:0016188 synaptic vesicle maturation' should be updated to include initial and final step as well?
Please use refs: GOC:aruk and GOC:bc.
This is related to #13906.
Thanks,
Barbara

Isn't this also  just a phenotypic consequence of a  a pathological defect in GO:0048268 clathrin coat assembly?  (i.e problems recruiting clathrin). It seems like a phenotype rather than a real process of maturation?

But isn't 'GO:0048268 clathrin coat assembly' a part of the broader process of 'vesicle maturation'?

That might be sensible if the process of vesicle formation is broken down  and there are specific maturation stapes after coat assembly. That I am not sure about.
This term
synaptic vesicle maturation
Ontology | Biological Process
Definition | Steps required to form an initiated synaptic vesicle into a fully formed and transmissible synaptic vesicle.
is not very enlightening about which parts of the process are considered to be maturation, so it's unclear. Do you know which steps ?

synaptic vesicle assembly has one descendant
GO:0097401 synaptic vesicle lumen acidification
classed as maturation.

hm... I've just tried to google 'vesicle maturation' and it seems that biologists do not generally use this phrase. So now that I'm thinking about this, and looking at the definition, which I suggested ("A process that is carried out at the cellular level, which results in the assembly and arrangement of constituent parts of a vesicle. Vesicle maturation begins with membrane bending (GO:0097753) and ends with vesicle scission (GO:0099050)."), I suppose what I actually meant to request was 'vesicle assembly', so that it would only refer to the structural aspects of a vesicle.
On second thought I suppose it would be impossible to define an endpoint for 'maturation' as vesicles are not constant structures, but they transition gradually from one into another, as their pH and other characteristics change. E.g. a 'very mature' late endosome would probably be biochemically indistinguishable from an 'early maturating' lysosome...
Perhaps in case of the 'synaptic vesicle maturation', it is a bit easier to justify the existence of this term (although the definition certainly requires more detail), as it represents only one vesicle 'type', which gradually becomes more and more acidic, and so 'mature' (?). Whereas for the 'default' vesicles, the less acidic endosome eventually 'becomes' the more acidic 'lysosome', so the process of lumen acidification results in generation of different vesicle 'types' (even though the mechanism is virtually the same as for changing an 'immature synaptic vesicle' into a 'mature synaptic vesicle').

I agree with you. I think it would be difficult to define a beginning and end of maturation, unless the steps it refers to are know.
It might be worth asking @dosumis about the placement of
GO:0097401 synaptic vesicle lumen acidification
under "synaptic vesicle maturation"
The use of "maturation" here seems too vague.
v

Hi @hdrabkin please disregard my earlier request for the 'vesicle maturation' term.
I have just discussed this with @RLovering and I wish to change my new term request.
I am now requesting a new term 'vesicle assembly':

GO:0016050 vesicle organization

NTR vesicle assembly

Suggested definition: "A process that is carried out at the cellular level, which results in the arrangement of constituent parts of a vesicle. Vesicle assembly begins with membrane bending (GO:0097753) and ends with vesicle scission (GO:0099050)."
Suggested synonyms:
vesicle formation
vesicle biosynthesis
Please use refs: GOC:aruk and GOC:bc.
Thanks,
Barbara

Please see also #13915.

Isn't endocytosis a type of vesicle assembly by this definition?  What about membrane budding?  (Looking at these two again, I think endocytosis should be at type of 'vesicle budding', rather than having it as a part).

Also looks like 'vesicle scission' should be part of membrane budding.

Yes, I think it makes sense for 'vesicle scission' to be a part of 'membrane budding'.

Wrt to endocytosis, the process will indeed begin with 'vesicle assembly', but not all newly assembled vesicles will be endocytic vesicles.

NTRs added

Thank you @hdrabkin
Although I am now not convinced about the second one now: 'NTR2 vesicle fusion involved in vesicle assembly' because @dosumis clarified (in #13915) that 'fusion' should only be used for two membranes getting joined together, whereas in this case it would be one membrane 'closing/sealing up'. So perhaps let's put NTR2 on hold for now, as @dosumis suggested this process of membrane closing up does in fact happen during 'vesicle scission (GO:0099050)' #13915, so it is this latter term that probably needs modifying?

What do we really mean by vesicle assembly though. Its odd after all of the work in cerevisie that such a term has not been requested before....
I would say that a vesicle is formed as a result of a set of processes (vesicle formation might be better than assembly, although some parts are assembly).
For example terms like
O:0099049 clathrin coat assembly involved in endocytosis
are defined as
The process that results in the assembly of clathrin triskelia into a clathrin cage during endocytosis. Clathrin is recruited to the plasma membrane via interaction with scaffolding proteins that bridge between clathtin and cell surface receptors. Clathrin coat formation is concomittant with coated pit formation leading to endocytic vesicle formation.
Perhaps it is just  vesicle  formation  is worked out in quite mechanistic detail so nobody though to add an explicit parent?
but there are  also lots of existing terms related to these processes, for example most of the terms under
GO:0006901 vesicle coating

It's too late, as I have already added the term. So it would need to be obsoleted.

I'm with Val on this.  Sorry for not being clearer before.  If vesicles are always formed by budding from membranes, budding includes invagination, and scission and we have various terms for budding, then why do we need terms for vesicle assembly? What additional processes come under assembly that are true for all types of vesicles?

Now that I've looked at the term 'GO:0006900 membrane budding' more closely I see that it has the synonyms 'vesicle formation/assembly/biosynthesis', and the definition does in fact say that it results in vesicle formation.
But is it accurate to say that membrane budding is synonymous with vesicle formation/assembly?
( @ValWood , @RLovering and I discussed 'assembly' vs. 'formation', and having looked at existing terms decided that the two have been used interchangeably in GO, but with 'assembly' typically being used as the primary term).
Membrane budding needs to occur in order for a vesicle to form, but the scission also needs to occur, so ultimately I think both would form a part of the broader process of membrane formation/assembly. That is, unless, a 'vesicle' is defined as a structure, which can exist while being attached to another membrane (which would be the case before scission occurs). However, the definition of 'GO:0031982 vesicle', which states that is is 'Any small, fluid-filled, spherical organelle enclosed by membrane,' suggests that it is a 'vesicle' only after scission has occurred, or else it could not be spherical, or enclosed by membrane. Or unless 'vesicle scission' becomes a child of 'membrane budding' as @dosumis suggested above, and which I originally agreed with, but upon reflection I do not think this is a good solution.
Having said that, I now see that I can use the (more specific) term 'GO:0006900 membrane budding' to capture what PICALM is shown to do in PMID:25898166. Thank you for your helpful comments.
Still, the definition of 'membrane budding' needs to be updated. And I suppose it should also be a child of 'GO:0097753 membrane bending'?
Wrt to the NTR, it is probably worth having the parent 'vesicle assembly' (or 'vesicle formation' - I think either one would work as the primary term), which would encompass membrane bending, budding and vesicle scission. And as @ValWood pointed out, more specific terms, such as 'GO:0099049 clathrin coat assembly involved in endocytosis', should probably also then become child terms of 'vesicle formation'. (The current overall parent term 'GO:0016050 vesicle organization' covers both: assembly as well as disassembly).
Going back to 'vesicle formation/assembly' @hdrabkin perhaps the definition, which I suggested, could be updated not to include the word 'fusion' as @dosumis explained, but e.g. 'closure' instead: "A process that is carried out at the cellular level, which results in the arrangement of constituent parts of a vesicle. Vesicle assembly begins with membrane bending (GO:0097753) and ends with closure of the vesicle during vesicle scission (GO:0099050)"?

Ok, I can I obsolete the NTR2 vesicle fusion involved in vesicle assembly, leaving NTR1? Since I just made it yesterday, I don't think I need to go through the standard emails, etc.,

I can I obsolete the NTR2 vesicle fusion involved in vesicle assembly
That should definitely go.

I'm still not really clear why budding (with scission as a part) is not sufficient.
If you really want a new parent class, then think you should look at subclasses of 'membrane budding' and think about whether we need new terms there too.   Also, assembly feels like a very odd choice of name in this case as it brings to mind a process where various components are brought together to make a structure de novo.  'vesicle formation' would be better.

I also think the current terms worked...

Perhaps if you rename 'membrane budding' to  'vesicle budding from membrane' the ontology would be clearer.  Lots of coating terms are already a part of membrane budding.   If membrane budding ('vesicle budding from membrane') remains the general class covering vesicle formation, there should probably be some mention of coating in the def (where coating of a membrane is necessary to invagination, this is considered part of the process of budding'.
At the risk of confusing matters, here's a relevant monster ticket
https://github.com/geneontology/go-ontology/issues/12403#issuecomment-235905631
(Almost everything on this one done, but couple of remaining issues)

I would like to see 'membrane budding' renamed to 'vesicle budding from membrane'. There is at least one other occurance of membrane budding which does not result in vesicle formation and that is the formation of enveloped viruses. Also looking at the other terms in the ontology associated with this term, this term stands out as the exception without the word 'vesicle'.
Although looking at the ontology I wonder why there is the child term: GO:1902591 single-organism membrane budding, it has no annotations and I wonder if this is really needed?

Is there any reason why  the parent "organelle organization" cannot go under
"single-organism process" then a lot of intermediate terms could be removed. Is there an example of organelle organization that is multi organism?
Similary vesicle-mediated transport (single organism process?)
Probably lots of others where the entire branch can go under single-organism process and remove all of the specific single-organism terms that have sprung up.
Otherwise nearly every term  in these branches would need a single-organism version?
It seems like a "high-level" ontology issue....

@hdrabkin please go ahead with the obsoletions, and if you could also change the name 'membrane budding' to 'vesicle budding from membrane', this will be very helpful.
Thank you!

Done, done, and done.

Thank you!

I think some of these processes are really MF terms.
https://github.com/geneontology/go-ontology/issues/13024#issuecomment-316634820
These should just be
"MF membrane bending" involved_in  "BP vesicle assembly"
this gets rid of  unnecessary proliferation
membrane bending involved in x vesicle assembly.
I think the same can be said of scission (its performed by a GTPase), and there is a precedent for specific GTPases for membrane scission steps.
GO:1990606 membrane scission GTPase motor activity
Maybe these changes should not be made until  a model of the known molecular functions  for the pathway are aligned in order. There is no point to put processes representing molecular function in the process ontology.

Is this ticket now done?
@ValWood  - good points about organelle organization and whether bending is MF (not sure I'm convinced), but seem like business for other tickets.

Yep its a tricky one. It seems to be a single activity, but may require more than one gene product. One for the future....

I am with @ValWood on the MF! At least PICALM Q13492 certainly seems to be bending the membrane on its own, as shown in PMID:25898166. Anyhow, this is a topic for other tickets indeed. I'll close this one now.
Thanks for all your comments,
Barbara

Maybe this is a good topic for the meeting Weds afternoon session? How to distinguish a "Molecular Function" from a "Biological Process".
Increasingly  this blurry distinction seems to hinder us,  and causes a lot of duplication in the ontology, and a lot of work generally for ontology editors and curators, and a lot of annotation inconsistency, so it would be useful to address.
We have:
a)  Single step functions described as processes, like membrane bending activity, glucose sensing, MF "protein anchor" vs  BP "cortical protein anchoring"  scission,  etc. etc. as well as the obvious single step molecular function  relationships between  protein modifier MFs and the BP corollary.
b) Many "MF involved in BP" terms in the BP ontology.
This is clearly unsustainable to include everything precomposed here (personally would need to submit 1000's of  new terms, so we have been doing this with MF part_of B extensions to mirror Noctua modelling) . Is it useful to retain precomposed  MF involved in BP terms in  the MF ontology? ( they are unsustainable, confusing for newer curators and community curators and they make the annotation look inconsistent).
So maybe the objective primarily would be "Distinguishing MF from BP". I have never seen any substantial ontology guidelines for this (other than the vague multi-step vs. single step, but this gets confusing  when multiple genes are involved in an activity or it isn't a canonical function...
Ontology editors appear to add requests for  terms into the BP ontology that sometimes seem like MF's  but if there was a checklist for the curator to follow along the lines:
Do you know the molecular activity of this protein: Y/N
If "Y" Does "MF part_of BP extension capture the contribution of the MF to the process: Y/N
If "Y" Do not request a BP term
I think maybe this could be a big bang-for-buck discussion
@thomaspd @ukemi  @pgaudet @hattrill
A lot of the tickets appear to relate directly or indirectly to this issue.

I agree that we could do with clarifying what constitutes a MF - if we move to a more function-centric view we will need to fill holes in MF or we will struggle. Many potential MFs are sequestered in BP....membrane bending, for example.....and sometimes there is either a lack of mechanistic knowledge (with small GTPases we rarely, if ever, capture the business end of things, we can only capture the function that turns them on or off).
Perhaps a Wednesday workshop would be good idea - get people to really think about the issue.


Not possible to reset invalid number

When resetting a timepicker with invalid number, the value does not change and it is not possible to set it as null (only in library)!
https://plnkr.co/edit/vaqiKjdKTQr8o9qoy8ek?p=preview
Type: a valid time number then reset value, result: the reset works.
Type invalid time number for example: 99, result: the reset does not works
Angular: 1.5
UIBS: 2.5.0

#https://github.com/angular-ui/bootstrap/issues/6240


Code restructure

The current codebase is not very maintainable - the majority of the code sits inside video.ino, which is nearly 2000 lines long.
The codebase also has little separation of concerns - the code that handles the interpretation of (most of the) VDU commands is intermingled with code that calls fab-gl/vdp-gl, often directly without calling intermediate functions.  This makes experimenting with adopting other video libraries hard and impractical.

The audio enhancements were done in a way that added some structure to the audio side of the codebase.  Further improvements there can still be done.
The video side, and VDP/MOS communications protocol handling code was left untouched.

Closed via #12

Code restructure is now complete and merged in


New command builder push [url]

this should post a json or possibly a yaml file with all relevant build info to a specified url.
In the setting we need to enable a flag auto-push. This flag would automatically push build metadata after every build attempt.
once this is configured it should be enabled by default to true. However once it has manually been set to false it will manually need to be set back to true.

any more info on this?

@stephanelpaul  I think this is been worked on and might be dev complete but it needs to be reviewed & tested. @KatieHarris2397 can you verify this story?

I want to ensure that this also allows for a post to push/post the artifact generated to an external location.


Windows Calculator does not work on gnu/linux

Describe the bug
When I try to run the calculator on gnu/linux it does not work.
Steps To Reproduce

open a terminal
compile source code somehow
chmod +x ./build/calculator.exe
./build/calculator.exe
Error: bash: ./calculator.exe: cannot execute binary file: Exec format error

Expected behavior

Screenshots

Device and Application Information (please complete the following information):

OS Build: Fedora 29
Architecture: x86_64
Application Version: 10.1812.10048.0

Additional context
i dont use arch btw

Duplicate of #113

ok, this is epic

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

Closing since this is a duplicate of #113.

https://github.com/Microsoft/calculator/issues/109
https://github.com/Microsoft/calculator/issues/113
https://github.com/Microsoft/calculator/issues/130

How about using Wine?

Lol, why you trying to directly execute PE executible on Linux?! :rofl:
Otherwise, use Wine to run Windows EXEs on Linux or Mac.

This is a bug in execve() system call. Please report it to the corresponding open-source project.

I see your problem. You need to use gentoo.

Omg.... Idiots.

Have you tried sudo yum install windows?

does windows subsystem for linux in installed?

omg...
apt get install mind
very fat troll

@mcooley That issue is not related since the bug occurs when I try to run the binary already compiled in gnu/linux and not when I compile it.
I demand that this issue be reopened.

Stop panic! We will made it and we will rock you! Just need some time.

@MicrosoftIssueBot You should know that GitHub notifications do that already, you useless bot.

@m3k4itr41n This isn't rocket science, however -
There are three major operating systems in today's time -

Windows
MacOS
Linux

Programs do not just work across the three out-of-the-box. They have to be cross-compiled/recompiled etc.
By default, .exe files are meant only for Windows. Some can be run, however, on linux via using a compatibility layer called wine. Since this application is open sourced, some developer could try and figure out how to compile it for linux. As of now it doesn't work on linux.

It's highly unlikely this will be able to compile on GNU/Linux without something like Winelib.

This app has a dependency on UWP, Windows 10, and WinUI - so is not currently compatible with Linux.


Docs/git details

This document is a clear explanation made by the four members of the front-end team on the procedures and troubles we faced in doing GitHub steps. This document will be a great help for the future frontend team students to refer. We will upload a folder with the screenshots we got as part of this in a separate pull request.
Fixes # (issue)
Type of change

[ ] Documentation (update or new)

How Has This Been Tested?
Passed the github checks
Testing Checklist:

[ ] Tested in latest Chrome
[ ] Tested in latest Safari
[ ] Tested in latest Firefox

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have requested a review from ... on the Pull Request

 GitHub documentation

Closing PR, no review.


Use retryablehttp client

Use retryablehttp to make HTTP requests against the Katapult Core API. It's potentially not needed, but should help ensure the provider is more reliable in the event of any network glitches or the like.

Closed in favor of supporting retryablehttp in the Katapult API client library: https://github.com/krystal/go-katapult/issues/60

Ignore my previous comment closing this issue, I've changed my mind after thinking about implications it would have for the client library. So I'm favoring keeping the client library simple, and having the terraform provider configure retryablehttp for it's purposes and passing in a custom *http.Client to the *katapult.Client.
PR is #32.

Resolved by #32.


Remove title Padding from Hero Section  #FIXED

Issue #26 📐

I M Hamza Nadeem have worked for #26

Guidelines 🔐
I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

[x] Contribution Guidelines
[x] Code of Conduct

Issue to be closed 🛅

My pull request closes #26

Screenshots 📷
Here are the pictures of changes that I have made 🔽

I changed px-10 to px-3 on line 17 of Hero.jsx file

Hey @mhamzanadeem
Great to see your enthusiasm towards contributing towards Memories, make sure to star this project 🌟🌟 and follow me 🚀 for more such opportunities.


(optional) Bypass of GDPR / cookies popups

The Playwright v1.42.0 release adds a handy endpoint to automatically click on it when it pops up. Problem is that it will depends based on the website.
But we can probably gradually add an automation for all the common GDPR frameworks, as each of them will be identical across websites.

ongoing fixes: https://github.com/Lookyloo/PlaywrightCapture/commit/26348f7bf5f28f7d6c6a6d48cb41fe77ed99f6f5


feat: move dialyzer to a separate github workflow

Closes #3

Summary by CodeRabbit

Chores

Updated GitHub Actions workflows to improve static analysis processes.
Added .gitignore rules to exclude Dialyzer PLT files.
Introduced a new GitHub Actions workflow specifically for running Dialyzer analysis.

New Features

Configured Dialyzer settings within the project for enhanced type checking and error detection.

@coderabbitai review


add keepCurrent option to Navigator.present()

Add keepCurrent option to Navigator.present(), to keep current screen below the new one to be pushed (to use the new like a modal with transparency, for instance).

@Igor1201 another way to think about this would be to allow screens (ie, the screen you are presenting in this example) to declare themselves as transparent in initialConfig. This aligns more closely with the way Android works, and also i think makes this the responsibility of the screen rather than the responsibility of the .present() caller.
What do you think?

It makes sense!
The problem on Android is we can't call detach on ScreenCoordinator or the current screen would disappear. Should we expose a getter for renderedConfig on ReactNativeFragment.java to read the transparent property or directly call coordinator.getInitialConfigForModuleName on ScreenCoordinator?

@Igor1201 I think it's reasonable for us to require that people put it in the initialConfig as it shouldn't be dynamically changed.  As a result, i think using coordinator.getInitialConfigForModuleName should work.
One thing to consider: we already have a screenColor config option. Maybe we continue using that and let people set it to 'transparent'.

@lelandrichardson I'm not sure about using screenColor=transparent because one could use translucent backgrounds like rgba(127, 127, 127, 0.5)

s/transparent/translucent/?

Yeah i guess we can just check the alpha channel of the color and if it's not opaque, then we keep both activities visible

well they don't necessarily have to specify the color in the config, just that it's translucent. Transparent vs translucent is just semantics for the API

but since we already have the screenColor config option, I think it makes more sense to just use that so there are not 2 sources of truth

Closing this PR and moving discussion to https://github.com/airbnb/native-navigation/pull/69


Centralize Calling OpenROAD + Automatic Reproducibles

All OpenROAD scripts are now called with run_openroad_script, a variant of try_catch, upon detecting a failure, will automatically invoke ./scripts/or_issue.py and create a reproducible within the run directory.
Also tweaks to how yosys is invoked.

Awesome!


Production webpack configs

This adds two webpack config files for creating unminified and minified versions of the Candela library for distribution.

We might want to cook up and document a procedure for publishing NPM releases as part of this PR as well. We could create a 0.3.0 release to test that out. Let me know what you think @jeffbaumes

LGTM. The only thing I want to capture here is that we should also test these build products to ensure they work as expected from the point of view of an external product using them. +1 to documenting the release process.

+1 to testing as well.
I will open new issues for testing the dist products, and for documenting the release process.


HDDS-11526. hdds.datanode.metadata.rocksdb.cache.size default value description is wrong

What changes were proposed in this pull request?
The default value of property hdds.datanode.metadata.rocksdb.cache.size in ozone-default.xml is corrected to 1GB as per the actual default value used in the code.
What is the link to the Apache JIRA
HDDS-11526
How was this patch tested?
Tested using TestKeyValueContainer#testContainerRocksDB.

Thanks @sarvekshayr for the patch.


Query multiple tables

Implementations in this project

I created a table named owners with the following columns:

id: integer (set it as autoincremented PRIMARY KEY)
full_name: string
age: integer

I created a table named species with the following columns:

id: integer (set it as autoincremented PRIMARY KEY)
name: string

I modified the animals' table:

I Made sure that id is set as autoincremented PRIMARY KEY
I removed column species
I added column species_id which is a foreign key referencing species table
I added column owner_id which is a foreign key referencing the owners' table

I inserted the following data into the owners' table:

Sam Smith 34 years old.
Jennifer Orwell 19 years old.
Bob 45 years old.
Melody Pond 77 years old.
Dean Winchester 14 years old.
Jodie Whittaker 38 years old.

I inserted the following data into the species table:

Pokemon
Digimon

I modified my inserted animals so it includes the species_id value:

If the name ends in "mon" it will be Digimon
All other animals are Pokemon

I modified your inserted animals to include owner information (owner_id):

Sam Smith owns Agumon.
Jennifer Orwell owns Gabumon and Pikachu.
Bob owns Devimon and Plantmon.
Melody Pond owns Charmander, Squirtle, and Blossom.
Dean Winchester owns Angemon and Boarmon.

I wrote queries using the JOIN command to answer the following questions:

What animals belong to Melody Pond?
List of all animals that are pokemon (their type is Pokemon).
List all owners and their animals, remember to include those that don't own any animal.

@addod19 @souad988 Added future feature as required by the reviewers and updated readme file .


create changelog to track changes compared to vanilla

Probably in markdown format
No concrete numbers, instead percentages and descriptions of the changes
Content:
General changes
Gameplay Mechanics changes
Afflictions
Perk changes
Weapon changes
Zed changes

931f4c1


Rails 6 Beta testing

Closing in favor of https://github.com/codetriage/codetriage/pull/1101/commits


Add policy that will allow additional certificate OID for enumeration

I am trying to find someone in Microsoft that can update a policy that would allow an additional certificate OID for enumeration.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 132e8bfa-12ba-2ae0-7745-545bcfd909f1
Version Independent ID: 984c17f4-04a4-bf30-3a9e-3af49209f0bb
Content: Certificate Requirements and Enumeration (Windows) - Windows security
Content Source: windows/security/identity-protection/smart-cards/smart-card-certificate-requirements-and-enumeration.md
Product: m365-security
GitHub Login: @Dansimp
Microsoft Alias: dansimp

Thanks @jamesburkecissp for taking the time to share this with the Windows documentation team. I’m sorry that you’re having problems, and I want to make sure it gets to the right people that can help. There are a couple of options available to provide the best level of support for this issue:

Post to Windows on Q&A. These are moderated by community members who are very experienced, knowledgeable, and helpful.
Use Microsoft Support to search for the issue, or open a case with professional support.
Contact your Microsoft Unified Support team, such as a Customer Engineer or Customer Success Account Manager.

I'm closing this issue as there's nothing actionable for docs at this time.

Aaron,
This issue is probably something that needs to be brought up to Microsoft Support or Microsoft Unified Support Team.
I have an technical white paper that explains the issue, but I don’t have a contact to share the paper with and discuss the issue.
James
James Burke, CISSP, CSEIP (ICAM PACS) - SynchroCyber Corporation – A HUBZone Company
<EMAIL_ADDRESS>|<PHONE_NUMBER>tel:703.862.5500 (m)<PHONE_NUMBER> (f)
17959 Dumfries Shopping Plaza, Suite 2B, Dumfries VA 22026
[signature_3184080142]https://www.synchrocyber.com/[Graphical user interface, text, application  Description automatically generated with medium confidence]
Cyber Security | Identity and Access Management | HSPD-12 / PIV / Smart Cards / Authentication
The information transmitted in this e-mail is intended solely for specified receiver(s) and may contain confidential and/or privileged material.  Any review, retransmission, dissemination or other use of the information contained in this email by persons or entities other than the intended recipient is unauthorized and prohibited. If you have received this email in error, please contact the sender by return e-mail and delete the material from any computer immediately. -
From: Aaron Czechowski @.>
Reply-To: MicrosoftDocs/windows-itpro-docs @.>
Date: Friday, July 29, 2022 at 11:40 AM
To: MicrosoftDocs/windows-itpro-docs @.>
Cc: @." @.>, Mention @.>
Subject: Re: [MicrosoftDocs/windows-itpro-docs] Add policy that will allow additional certificate OID for enumeration (Issue #10739)
Thanks @jamesburkecissphttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jamesburkecissp&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=h6G80RQ-puXFt15yxX-b-3LgVg4YbIPQwA9uEoG-wU8&m=bGPD39cEWnvtUZEM2J7BBL1U0NgojT7uJS6Un8JR0KQ&s=5ED85JvgffMi-mV8ygkGdJQFhyvx1U-ef-rO3TNMliM&e= for taking the time to share this with the Windows documentation team. I’m sorry that you’re having problems, and I want to make sure it gets to the right people that can help. There are a couple of options available to provide the best level of support for this issue:

Post to Windows on Q&Ahttps://urldefense.proofpoint.com/v2/url?u=https-3A__docs.microsoft.com_answers_products_windows&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=h6G80RQ-puXFt15yxX-b-3LgVg4YbIPQwA9uEoG-wU8&m=bGPD39cEWnvtUZEM2J7BBL1U0NgojT7uJS6Un8JR0KQ&s=2i73QqDJ1iB7T5tUQtiSASgQ2dBIVbF42JfIE3Yg074&e=. These are moderated by community members who are very experienced, knowledgeable, and helpful.
Use Microsoft Supporthttps://urldefense.proofpoint.com/v2/url?u=https-3A__support.microsoft.com_windows&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=h6G80RQ-puXFt15yxX-b-3LgVg4YbIPQwA9uEoG-wU8&m=bGPD39cEWnvtUZEM2J7BBL1U0NgojT7uJS6Un8JR0KQ&s=u6nPO2AZh2vzxWAOCScRs5CHMpuEuXQPjnSi_dw-U0s&e= to search for the issue, or open a case with professional support.
Contact your Microsoft Unified Support team, such as a Customer Engineer or Customer Success Account Manager.

I'm closing this issue as there's nothing actionable for docs at this time.
—
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_windows-2Ditpro-2Ddocs_issues_10739-23issuecomment-2D1199564161&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=h6G80RQ-puXFt15yxX-b-3LgVg4YbIPQwA9uEoG-wU8&m=bGPD39cEWnvtUZEM2J7BBL1U0NgojT7uJS6Un8JR0KQ&s=0URv1DWr0GnY7QuSlRmcMeLsKuuqnYW4CxZvjqFEcUE&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AG6NKDW5ROEXMXC737KNKR3VWP3MPANCNFSM55ASCRDA&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=h6G80RQ-puXFt15yxX-b-3LgVg4YbIPQwA9uEoG-wU8&m=bGPD39cEWnvtUZEM2J7BBL1U0NgojT7uJS6Un8JR0KQ&s=mgZxOLdbW6zRAUFrwQ3onfH_q5UsOQKeFeYwL4tk-J4&e=.
You are receiving this because you were mentioned.Message ID: @.***>


Broken link in the documentation - Introduction to Extensions

Actual Behaviour
In the documentation (https://www.adobe.io/project-firefly/docs/guides/extensions/), the link for “Creating your First Project Firefly Application”(https://www.adobe.io/project-firefly/docs/first_app.md) is broken. Here's what we get after clicking on that link -

Expected Behaviour
Probably the correct link is https://www.adobe.io/project-firefly/docs/getting_started/first_app/.
Reproduce Scenario (including but not limited to)
Steps to Reproduce

Go to https://www.adobe.io/project-firefly/docs/guides/extensions/
Click on “Creating your First Project Firefly Application” link

Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem

cc: @icaraps @meryllblanchet

@sgera Thanks for reporting the broken link ! The fix is being deployed https://github.com/AdobeDocs/project-firefly/runs/3200199866?check_suite_focus=true.


block scrolling behind an open popover

Change tabs to spaces (as god intended!)
set overflow hidden and block scroll events while popover is open

One thing I was trying to get working was allowing you to scroll the page and closing the popover when you do. I added 'scroll touchmove mousewheel' to the document function at the bottom, but the problem is that the popover anchor was remaining active so you couldn't reopen it without first clicking the body

Can you use the .blur() method on the anchor?


Add template validation tests

[x] test if cookiecutter successfully runs
[x] validate ISA-tab
[x] iterate over all choice variables and validate each resulting template

Not covered: Interdependencies between choice variable.
partially fixes #2
depends on #9 & #10

Rebased to current main.


Drop Targets: Outline of the selected element visible even if not a target

Bug Description

When drop targets are displayed on a Page with a note that drop targets have blue outline around them, the selected element displays the blue outline regardless of being a drop target or not.
Expected Behaviour

Only drop targets should have blue outline when dragging.
Steps to Reproduce

Add a Text block.
Select the Text block.
Start dragging an Image from the Media Library onto the Page.
See the blue outline around the Text (which is not a drop target).

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

@jauyong Would be good to confirm this with UX.

This is alright because the background is always a drop target but we can recycle this issue to implement drop targets on the background element (needs to constantly keep one empty element as the background)

This is alright because the background is always a drop target but we can recycle this issue to implement drop targets on the background element (needs to constantly keep one empty element as the background)

Note that this issue is about the selected element having a blue outline even if it's not a target, not related to background :)

As mentioned in https://github.com/google/web-stories-wp/pull/687#issuecomment-602480118 then this still needs looking into.
When a Text element is selected and media is dragged from the Media Library, the Text element has blue line around it due to selection. Should the selection be hidden while dragging?
cc @pbakaus @samitron7

Hey @miina the blue box is part of the selection UI so as a user I wouldn't expect it to disappear with drop targets because that would make me think I lost my selection (this is especially true in the case of a text element which does not support drop targets) so this is expected behavior.

When testing with one image and one Text box, I did find having the blue outline (even though selection) around the Text box unexpected. E.g. if an Image is first selected, I'd also expect it to show just the drop target blue outline around the image, not the selection -- it's more consistent this way. However, might be just me then.
Will close this for now then assuming it's expected to mix selection + drop target outline.


Add fair2.X to openscm-runner

The motivation
Add fair2.X (currently v2.1.3) to openscm-runner
The proposed solution
Add a fair or fair2 adapter. This will be trickier than adding a new SCM, since fair already exists at v1.6.2.
There are two options I see, both with pros and cons.

Add a new fair2 adapter alongside fair. Advantages: does not break backward compatibility, existing workflows that rely on fair will still work, and both model versions available for comparison. Disadvantage: not sure if easy (or possible) to include two versions of the same module as dependencies.
Update the existing fair adapter to point to the newest version of fair. Advantages: can be more easily updated, cleaner namespace. Disadvantage: backward incompatibility, will break many existing workflows including the IPCC assessment. Mitigation: pin versions of openscm-runner in projects, though requires communication.

My preferred solution is the second one.
Alternatives
Bypass openscm-runner altogether in workflows. However, several projects use it as a module, and it would be nice to have continually updated calibrations and versions.

There is also option 3: make your FaIR adapter flexible. Basically, you would want some logic in your adapter (and we can talk about how exactly if you want to go to this route) so that the user just asks for FaIR, but what they receive back depends on which FaIR version is installed (if FaIR 1.6.2 is installed, they get back the current adapter, if FaIR 2+ is installed, they get back the FaIR2 adapter). That would mean that maintain a single interface (at least from the high-level user's view) but you can support both versions in the same openscm-runner release.
For what it's worth, we may do option 3 with MAGICC8 (although maybe not, as MAGICC8 will probably look and feel completely different from MAGICC7).

Disadvantage: not sure if easy (or possible) to include two versions of the same module as dependencies.

I mean you obviously can't have two versions of FaIR installed at once, but you can just make the dependency pin something like "fair >=1.6.2" (so users can install 2+ if they want) or maybe even more specific where you list compatible versions e.g. "fair == 1.6.2, 2.0.3, 2.1.2" (I'm not sure if you need that or it is supported by pip, but maybe it is...)

Something like this could work
version = fair.__version__
logger.info(f'running with installed fair v{version}')
if version[:3]=='1.6':
    # do current adapter
elif version[:3]=='2.1':
    # do new version
else:
    raise SomeException(f'version {version} of fair not currently supported. Please consider updating your environment')

Ye exactly

I prefer my original option 2 since keeping two versions is causing me bookkeeping headaches and it's difficult to test that the old version doesn't break - or at least I'm not smart enough to figure this out in poetry - while developing the new.

Ye you'll probably need two virtual environments going at once for that parallel development to work, or add tox or something.


Mailing list “Subscribe” button is off-center

Style the newsletter sign section such that the “subscribe” button is centered.

Fixed.


Tracer is not working with AA-Benchmark repo

Tried to trace tests for AA-Benchmarks repo with no success.
Steps to reproduce:
clone above repo
cp env.sample .env

pnpm i hardhat-tracer

\\ hardhat.config.ts
import "hardhat-tracer";

then
npx hardhat test --vvv

and no traces shown.
Can you please advise why can that happen?
I tried debug logs for tracer, and what I see is something like that:
  hardhat-tracer:wrapper wrapped request hardhat_setCode +0ms
  hardhat-tracer:wrapper shouldPrint=false, tracer.enabled: true, tracer.ignoreNext=false, tracer.printNext=false +0ms

with shouldPrint=false everywhere.

Thanks for reporting this issue. I had a quick look and based on the debug logs it appears that eth_sendTransaction or eth_sendRawTransaction was not used to confirm a transaction on the hardhat network when tests were running. Though I don't see why. I am trying to figure that out. Any ideas?
The way hardhat tracer works is when your tx executes on the hardhat network's EDR, it watches the runtime and notes down relevant the opcodes and then it is used to print the trace tree. It turns on the recorder when RPC like eth_sendTransaction is being used.

Thank you for your reply!

Any ideas?

No ideas so far. Doesn't look like repo is anyhow altering hardhat network. I'll let you know if I find something


ere

@LABAYKALS  could you describe what's the issue is it?

Evet, her şey yolunda.
BhΔ∇Δt @.***>, 16 Şub 2024 Cum, 19:27 tarihinde şunu
yazdı:

@LABAYKALS https://github.com/LABAYKALS could you describe what's the
issue is it?
—
Reply to this email directly, view it on GitHub
https://github.com/AKABharat/Snake-Water-Gun-Game/issues/1#issuecomment-1948809447,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDDWB3SHAUUZXB3ACJQBL4TYT6CFPAVCNFSM6AAAAABDDPVY36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBYHAYDSNBUG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@LABAYKALS ok.


[camera] Stable release for null safety.

Stable NNBD release for the camera package.
With this PR I also migrated the example App to sound null safe. Note that I didn't update the dev-dependency on mockito: ^5.0.0-nullsafety.7 since the stable version causes a conflict with the current flutter_driver dependency. I have marked the dependency in the pubspec.yaml with a # TODO(mvanbeusekom) comment to remind me to remove it when the conflict is resolved.
Conflict details:
Because mockito >=5.0.0 depends on analyzer ^1.0.0 which depends on crypto ^3.0.0, mockito >=5.0.0 requires crypto ^3.0.0.
And because every version of flutter_driver from sdk depends on crypto 2.1.5, mockito >=5.0.0 is incompatible with flutter_driver from sdk.
So, because camera depends on both flutter_driver any from sdk and mockito ^5.0.0, version solving failed.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I signed the CLA.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan thanks for the feedback. I have gone through all your comments and made the necessary adjustments.
Could you have another look please?


Add name property to drives

The name property is equal to the device path in macOS and GNU/Linux,
but its equal to the list of volumes with file-systems on Windows, for
user-friendliness purposes.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

This is something we were manually adding to the result of drivelist on Etcher, and its tied to https://github.com/resin-io/etcher/pull/1630

Might be nice if the README could show an example of a disk on Windows with multiple drive-letters per disk? (otherwise the fact that this .name property might contain a comma-separated list is entirely unclear)
And I wonder if calling it something like .display_name would make it clearer that this property is just for display purposes, and you shouldn't really use it for anything else? (given that it has different meanings on different platforms)

Might be nice if the README could show an example of a disk on Windows with multiple drive-letters per disk? (otherwise the fact that this .name property might contain a comma-separated list is entirely unclear)

Sounds good. I'll do it in a second.

And I wonder if calling it something like .display_name would make it clearer that this property is just for display purposes, and you shouldn't really use it for anything else? (given that it has different meanings on different platforms)

Fair enough, lets go for it!