make install fails when executing setupsh

Hi,
I switched to the devel-branch in order to get some fixes. Unfortunately after a successful build sudo make install fails with the following information:

-- Installing missing sysrepo modules...
su: failed to execute zsh: Datei oder Verzeichnis nicht gefunden
/home/umberto/Development/netopeer2/scripts//setup.sh: Line 82: -l: Command not found.
/home/umberto/Development/netopeer2/scripts//setup.sh: Line 51: : Command not found
CMake Error at cmake_install.cmake:81 (message):
   scripts/setup.sh failed: 127

make: *** [Makefile:74: install] Fehler 1

A brief investigation from my side revealed a problem in all of the 3 scripts (setup.sh, merge_hostkey.sh and merge_config.sh) when trying to initialize the SYSREPOCFG variable. This error is reproducible on my Raspberry Pi 4 and on my LinUX-machine running a 64-Bit Debian based distro (LMDE 4). Any hints?
cmake and make  completed successfully. No missing library or any other issue.
Cheers,
Umberto

It is a continuous effort of several people already to make these scripts portable and obviously it seems like an impossible task. But in this case I am not sure what to do. The problem is with SYSREPOCTL variable (but it does not matter as they are initialized the same way) but I do not know what exactly. You can try executing the right side of this line and this line and post the output.

Hi Michal,
both lines lead to a valid variable:
[umberto@venere]/home/umberto/Development/netopeer2> SYSREPOCTL=`su -c 'which sysrepoctl' -l $USER`                        [git][netopeer2/.][devel]
[umberto@venere]/home/umberto/Development/netopeer2> echo $SYSREPOCTL                                                      [git][netopeer2/.][devel]
/usr/local/bin/sysrepoctl
[umberto@venere]/home/umberto/Development/netopeer2> SYSREPOCTL=`which sysrepoctl`                                         [git][netopeer2/.][devel]
[umberto@venere]/home/umberto/Development/netopeer2> echo $SYSREPOCTL                                                      [git][netopeer2/.][devel]
/usr/local/bin/sysrepoctl
[umberto@venere]/home/umberto/Development/netopeer2>                                                                       [git][netopeer2/.][devel]

This is fine.
I think, that when executing the shell-script through cmake, the environment is somehow different.
-- Installing missing sysrepo modules...
su: failed to execute zsh: Datei oder Verzeichnis nicht gefunden
1 SYSREPOCTL :
NP2_MODULE_DIR:  /usr/local/share/yang/modules/netopeer2
NP2_MODULE_PERMS:  600
MODDIR:  /usr/local/share/yang/modules/netopeer2
PERMS:  600
OWNER:  umberto
GROUP:  umberto
USER:  root
PATH:  /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
/home/umberto/Development/netopeer2/scripts/setup.sh: Zeile 95: -l: Kommando nicht gefunden.
/home/umberto/Development/netopeer2/scripts/setup.sh: Zeile 64: : Kommando nicht gefunden.
CMake Error at cmake_install.cmake:81 (message):
   scripts/setup.sh failed: 127

make: *** [Makefile:74: install] Fehler 1

As you can see, it is not possible to set SYSREPOCTL correctly. (empty string).
I did the following and was successful:
[umberto@venere]/home/umberto/Development/netopeer2/build> export NP2_MODULE_DIR=/usr/local/share/yang/modules/netopeer2                              [git][netopeer2/build][develU]
[umberto@venere]/home/umberto/Development/netopeer2/build> export NP2_MODULE_PERMS=600                                                                [git][netopeer2/build][develU]
[umberto@venere]/home/umberto/Development/netopeer2/build> ../scripts/setup.sh                                                                        [git][netopeer2/build][develU]
2 SYSREPOCTL: /usr/local/bin/sysrepoctl
NP2_MODULE_DIR:  /usr/local/share/yang/modules/netopeer2
NP2_MODULE_PERMS:  600
MODDIR:  /usr/local/share/yang/modules/netopeer2
PERMS:  600
OWNER:
GROUP:
USER:  umberto
PATH:  /Users/umberto/anaconda3/bin:/Users/umberto/anaconda3/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/sbin:/usr/sbin:/sbin:/home/umberto/bin:/home/umberto/.cabal/bin:/home/umberto:/home/umberto/bin:/home/umberto/bin/node/bin:/home/umberto/anaconda3/bin:/Applications/ARM/bin:/home/umberto/bin:/home/umberto/.cabal/bin:/home/umberto:/home/umberto/bin:/home/umberto/bin/node/bin:/home/umberto/anaconda3/bin:/Applications/ARM/bin
[umberto@venere]/home/umberto/Development/netopeer2/build>                                                                                [git][netopeer2/build][develU]
[umberto@venere]/home/umberto/Development/netopeer2/build> echo $?                                                                                [git][netopeer2/build][develU]
0

As you can see even as a standard user the script executes successfully. same applies to the other 2 scripts merge_hostkey.sh and merge_config.sh.
Anyway, this is not straight forward in terms of sudo make install. I tried another solution which seems to be more elegant and does not require the which commands. I added 2 extra lines in cmake_install.cmake which are:
set(ENV{SYSREPOCTL_EXECUTABLE} "/usr/local/bin/sysrepoctl")
set(ENV{SYSREPOCFG_EXECUTABLE} "/usr/local/bin/sysrepocfg")

This works. You would need to generate these in CMakeLists.txt  somewhere around line 230.
Does this help you?
Best Reards,
Umberto

Does this help you?

Sadly, no. The point of using which is to handle situations when you have installed sysrepo into some custom path (but it is included in PATH). The idea was so that the user must define the exact path only in case the binaries are installed in some completely unknown path, in which case it is really the only safe solution.

Okay, but these scripts are called only when installing, i.e. sudo make install, aren't they? So you have the exact location of installation, even if the user chooses a non-default one.
Best regards,
Umberto

Well, yes, the location of netopeer2 installation, not of sysrepo and that is what is needed here.

Oh yes, you are right. I got confused.
Thank you for your replies.
Shall we keep the issue open or is this covered in a more appropriate one? If so, feel free to close this one.
Regards

You are the first one with this exact issue, to my knowledge. Whether this stays open I do not care much, but it would be great if a solution was found. The su trick is meant to handle situations when $USER and root environments differ so the user environment is used to learn the path to sysrepoctl. I still do not know why it does not work for you.

Hi Michal,
that topic keeps me thinking about it.
Once more here is another solution to retrieve the sysrepo* binaries via cmake:
 find_program(SYSREPOCTLPATH NAMES sysrepoctl)
 find_program(SYSREPOCFGPATH NAMES sysrepocfg)
 message(STATUS "sysrepoctl is ${SYSREPOCTLPATH}")
 message(STATUS "sysrepocfg is ${SYSREPOCFGPATH}")
 set(ENV{SYSREPOCTL_EXECUTABLE} "${SYSREPOCTLPATH}")
 set(ENV{SYSREPOCFG_EXECUTABLE} "${SYSREPOCFGPATH}")

What do you think? Some plausibility checks would be needed of course and it would have to introduced in the main CMakeLists.txt.
I uninstalled and cleaned everything, pulled everything from the devel-branches (libyang, sysrepo, libnetconf2 and netopeer2) to make sure there is nothing else interfering but had the same problem. So, I came up with that idea.
Regards,
umbertino

Yes, this is one of the possible solutions but it is not suitable for all use-cases of the scripts. They are also used when installing netopeer2 from packages and in that case this will not help you. My idea would be for you to learn what exactly is causing the changes in your environment for make install. Based on that information it can be decided whether it can be fixed.

Thanks for your feedback. Going to investigate my environment more deeply.

Hi,
after my last weeks vacation I recaptured this issue.
I found out, that there were some stale artefacts (wrong libyang library) installed which conflicted. I properly cleaned my system (Raspi4) and went step by step through the installations: libyang, sysrepo, libnetconf and then netopeer2. It works now.
A hint to you main developers: The shell scripts in netopeer2 (setup.sh, merge_*.sh) seem to have CRLF which makes them not executable. Changed them to LF and it was fine.
Thanks for your help.
Regards,
Umberto

I have checked the scripts and could find no CR (0D) even when I printed them in hex so I must assume you have opened and saved them with an editor that did this change (on Windows).


On the git version being used in the docker.

We do not set or install a git version on the docker. It might be good if we do this, to be able to choose a version and to be sure in which version we are running git commands.

Why would you need a specific version of git?

I don't really need a specific git version. But few months ago I run the docker with a newer git version compared to the one that is currently taken (I don't remember which is the version, but it's a little bit old...I need to check it again), and I got some different results. In that time, I didn't search for the root cause, i.e. which git command changed the behaviour, but my point is that there was a difference between the versions. I opened this issue having in mind that maybe we could take a newer version, or at least to make explicity in the docker file which version we are using now.
Currently we do not have too much git commands in Repairnator (that we call directly), but one day when issue https://github.com/Spirals-Team/repairnator/issues/361 is fixed, it might be better for us to look closer to the git version we use.

We rely on tagged docker images, so the Git version should not change if we use the same base docker image everywhere.
Now I follow you on the need to know the git version for Debugging purpose. What thing we can easily do is to print the Git version in first lines of the log.

We rely on tagged docker images, so the Git version should not change if we use the same base docker image everywhere.

I agree. Just to make sure that I didn't pass the wrong idea: when I run the docker with a different git version was because I forced it to happen, i.e. I do not claim that the git version change by itself.

Now I follow you on the need to know the git version for Debugging purpose. What thing we can easily do is to print the Git version in first lines of the log.

Good, I would like that a lot. Again, I do not need a specific git version (at least I never had a reason for it so far), and making explicit for us to see which git version we are using will be peaceful to me.


Add Close button for closing Chat

Is your feature request related to a problem? Please describe.
User can close the chat only by clicking in the shaded area. He/She should have an Close icon at top right or top left corner of the chat box to close it.
Describe the solution you'd like
I would like to add the close icon button to close the chat box.
Motivation
This feature is for better user experience and user friendly.
Are you willing to contribute to this issue? [Yes/No]
Yes
Please assign me this issue under GSSoC 21'

Hi @AmeyaJain-25 , First of all, thank you so much for taking out the time to create this issue.
Oh Yeah, we totally forgot that 😅.
Definitely 🙌, Please go forward to work on this issue. We are assigning this Issue to you 👍
And last but not least,
Keep Contributing 🙏🔥

Is your feature request related to a problem? Please describe.
User can close the chat only by clicking in the shaded area. He/She should have an Close icon at top right or top left corner of the chat box to close it.
Describe the solution you'd like
I would like to add the close icon button to close the chat box.
Motivation
This feature is for better user experience and user friendly.
Are you willing to contribute to this issue? [Yes/No]
Yes
Please assign me this issue under GSSoC 21'

Hi @AmeyaJain-25, it would be great if you do the same for the Participants list also 🚀

Yes Sure, I'll do it for the Participants list too

Yes Sure, I'll do it for the Participants list too

Wonderful 🙌


Add JQ to container

For parsing output when JQ isn't available on the host system (i.e.
non-CoreOS: jenkins slaves).
Maybe this is crazy and I should just add JQ to the slaves; trying to
avoid the first step on that slippery slope.

Comparing to https://github.com/thepwagner/docker-awscli/blob/master/Dockerfile#L3 ; maybe groff too?
$ docker run --rm pebbletech/docker-aws-cli aws help

Could not find executable named "groff"

~0; jq and groff are output formatters, where this should just provide the right output (leaving formatting to other systems, if formatting is required at all).
However, I'd be +1 if there's a strong usecase for having builtin jq and groff here, one that is not "because it's prettier" (lame example)

groff is also ~0 from me: if you need help output you shouldn't be using this container.
jq is to avoid adding jq to https://github.com/pebble/vz-jenkins-slave/blob/master/jenkins-slave.yml#L37 ; retaining the "docker-only" purity to keep builds entirely containerized.
"everybody wins" alternative is making a docker-jq container, but adding it here was obviously cheaper+easier.
docker run --rm pebbletech/docker-aws-cli sh -c "aws cloudformation describe-stacks --stack-name Foo | jq -r '.Stacks[0].Outputs[] | select(.OutputKey==\"AsgName\") | .OutputValue'"
vs
docker run --rm pebbletech/docker-aws-cli aws cloudformation describe-stacks --stack-name Foo | docker run --rm pebbletech/jq -r '.Stacks[0].Outputs[] | select(.OutputKey==\"AsgName\") | .OutputValue'
Really I just want AsgName so I took the shortest path :P

+1; solid argument plus hardly any overhead


[stable/grafana] update grafana to 7.1.1

What this PR does / why we need it:
This PR updates the grafana appversion to the current stable release.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign
/ok-to-test

/lgtm

/retest

/retest


Add JustList: {DZIRE TOKEN}

"symbol":"DZR",
"address":"TEZdC6tv9LqN5DabUTmpiPTnYx5jLGtq2E",
"chainId":1,
"decimals":6,
"name":"DZIRE TOKEN",
https://github.com/justswaporg/justlists/blob/main/example.justlists.ts

Thanks for reaching out.
You did not submit your information in the correct format.Please resubmit.

Sorry, your issue will be closed as  you have not resubmitted your information in the correct format for more than a week.


[BEAM-3826] Tweak Go integration test driver

Rename parameter as per design doc feedback

Run Go PostCommit

R: @jasonkuster

@herohde I assume this PR is not actually referencing BEAM-386, Java Dataflow runner to support Read.Bounded in streaming mode. ;) Can you update PR title to correct JIRA? I will merge after that.

Done. Thanks @jasonkuster !

@jasonkuster Do you have a moment to merge?


EZ-Wifibroadcast: "The RC implementation is missing important security features"

Which important security features would that be?

Maybe seeul8er refers to this:

The RC implementation is missing a check wether the data arrived correctly on the drone. Only eight channels are supported. (source: http://wolfgangchristl.de/dronebridge/)

Was "The RC implementation is missing important security features" before (source google cache)

Changed it like 3min ago :) Wanted to make things more clearly.
I removed it because the dramatic look of "security" when all that's missing is a CRC check of the data. At least I couldn't find one.
Don't get me wrong. It's not like the drone is going to fall out of the sky because of that, but it still is a little weakness of the protocol.
I really appreciate the newer OSD and Kernel patches. It's not really a different direction we are going, just a different way of doing things.

"the RC implementation is missing a check wether the data arrived correctly on the drone.

There is no "data arrived check", because:
a) It's only supported by the MSP protocol (not because it makes sense though, simply because the MSP protocol simply acknowledges every message it gets). The MultiWii guys realized years ago that it's pointless (see below) to generate ACKs for R/C messages and removed it, see here: http://www.multiwii.com/forum/viewtopic.php?f=8&t=6231)
The inav guys also eventually realized this, see here:  https://github.com/iNavFlight/inav/pull/2762
b) It's pointless, just wastes CPU cycles and just adds a lot of complexity, and room for error and bugs:
Ask yourself: How do you determine that a message was lost? You wait for the ACK, right? For how long do you wait? Considering, that EZ-Wifibroadcast R/C allows for about 150Hz or so, you only have 7.5ms after the next message arrives. Since Linux (and especially the Pi with it's underlying firmware) is not a realtime system, it can well be, that your code in userspace (i.e. after the scheduling inside the flightcontrol, after the buffers in the flightcontrol, after the transmission over the serial wire, after the serialport FIFO buffer on the Raspberry, after the Raspberry firmware and it's non-realtime scheduling, after the Linux kernel and it's non-realtime scheduling, after your code reaches the part where it checks for the ACK) simply gets the ACK too late, and you wrongly detect that the message did not arive.
The next question would be: What do you do with that knowledge? Re-send the message? Pointless, as it will be outdated soon anyway, the next message comes only a few milliseconds later. There's no point in sending stick-positions "from the past" to the flightcontrol. Warn the user? Well, could be an option, but if R/C is lost, the user will notice very quickly anyway. The only error that could be detected that way is intermittent message loss on the serial line, but only when using MSP and a flightcontrol with a MSP implementation that actually sends MSP ACKs.

when all that's missing is a CRC check of the data. At least I couldn't find one.

You obviously overlooked the 802.11 FCS. This is basic knowledge.
The only places where a CRC check makes sense is on a transmission path that can lead to corrupted data. That would be:

The serial line, which is protected by the R/C protocol CRC implementation already
The wifi transmission, which is protected by the 802.11 FCS (32bit CRC) generated by the wifi card already.

So the extra one-byte CRC inside your protocol is completely pointless and actually makes things worse because it increases the frame length and thus the probability of packetloss. It's also wasting CPU cycles for the computation.

The FCS check (fcsfail) should be disabled since we have forward error correction.

This has really nothing to do with the forward error correction in Wifibroadcast, the FEC doesn't really "protect" against frames with wrong FCS. Actually, Befinitivs idea was to let packets with bitflips go through (in cases when all FEC packets have been "used-up" already).

You could argue now that disabling it will only make sense on the VideoRX since all the data sent to the UAV is generally not protected by FEC in DroneBridge (Not so sure about your WBC stuff). And you would be right. I did not check what the current setting is and because of that I may remove that statement from the website and apologize for the formulation. It still is a weakness of the implementation but not if the system is configured the default way.

Befinitivs idea behind letting frames with failed FCS check through was to get as much data as possible through without losing too much. I.e. "don't drop a 8000 bit frame just because there is only 1 bit flipped". This is, in theory, indeed a good idea.
However, the problem with disabled FCS check in practice was (I have done extensive testing ...):
a) Sometimes, something inside the kernel or wifi card (never analyzed where exactly it happens) "hangs" when too many packets with bitflips are received, leading to no data reception anymore at all until reboot
b) Sometimes, something inside the h264 decoding pipeline hangs, leading to a frozen video until hello_video.bin is restarted
So I argue that it is very dangerous to disable the FCS check as it may lead to complete communication loss or video freeze.
This is why in my images, frames with wrong FCS get dropped (and also the code inside the rx program regarding this is commented out/disabled to save some CPU cycles, as there is no need to check for that when frames with failed FCS already get dropped before they reach the rx program).

It still is a weakness of the implementation but not if the system is configured the default way.

No, it's not a weakness of the implementation, let me repeat, it was a deliberate choice, since an additional CRC done in software:
a) Adds another byte to the payload, increasing packetloss both on the R/C and videolink, because the probability of a collision goes up the larger the frames get (I have done extensive testing on that ...)
b) The frames are already perfectly protected by the 4-byte 802.11 CRC, and the Pi0 is not that fast, saving CPU cycles is always a good idea, even if it may not be that much


Correct grammar of message when there are no cubes

Proposed changes
Grammar fix on message when there are no cubes.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Pull Request Test Coverage Report for Build 6437

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.009%) to 28.042%

Files with Coverage Reduction
New Missed Lines
%

core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java
9
60.0%

Totals

Change from base Build 6416:
-0.009%

Covered Lines:
26248

Relevant Lines:
93602

💛  - Coveralls

Thank you @AndrewLane


OpenX: Update Documentation to be similar with adapter readme

code released with 1.17

@jimee02 - please fix the conflicts. There was a global set of changes across all bidders that standardized the parameter tables.

@bretg, i've updated the commit.


Possible parking issue with "Parking Roads" assets

Details
Using LABS 10.21.1 STABLE 10.20 <-- that's the problem

leaderofthemonkeys (Paradox):
i've been having problems recently w parking, cars just won't park in parking spaces, no matter what i do they won't use them
on street-parking is a-ok
but my parking lots remaiuin empty (yes, parking ai is on)
it's super late, about to go to sleep, so not sure what you want to analyze this

Later:

i investigated a bit more, seems like it's only badi_dea's parking spaces
https://steamcommunity.com/sharedfiles/filedetails/?id=1293869603

Logs
output_log.txt 239,000+ lines!!! by far biggest log file I've ever seen
TMPE.log
Save game
QuickSave20190709233553843.zip
Note: Looking at the log file, lotm has 64GB RAM, so I suspect you'll need massive page file to load that savegame. There are truly insane numbers of workshop assets.
Mods
Bold lines are potentially broken / outdated mods (unlikely to be cause of the issue above, but flagging them up anyway).
Note: Roads United Core+ breaks toll booths; there are some mods that require it (highlighted bold) which should be disabled or removed.

UnlimitedMoney
UnlimitedOilAndOre
UnlimitedSoil
UnlockAll
DaylightClassic (locally installed for some reason)
MoveIt (locally installed for some reason)
PropUnlimitor (locally installed for some reason; also I suspect this is a broken mod)
812125426 - NExt2
724382534 - One way train tracks
1530376523 - Railway replacer
1552053911 - TrailerVariation Loader
1546357276 - Industries Vehicle Converter
1386697922 - Garbage Bin Controller
814498849 - Improved Content Manager
1637106958 - Lock Forestry
1603398633 - Flag Params
820157360 - Spawn Points Fix
633547552 - Roads United Core 2.0
1586027591 - TinySegments 2.0 (can break traffic lights etc)
1585691173 - HDRI Haven Cubemap Pack
1536223783 - Hide Selectors
1540147921 - Grid be Gone
837112310 - Roads United: Europe (requires Road United Core+ mod)
685719710 - More Shortcuts
954067599 - PropRotating Params
1369729955 - Customize It!
769744928 - Pollution, Death, Garbage and Crime Remover Mod
1147015481 - No Crosswalks - Remove Crosswalks/Crossings - Including Road Assets (issues reported with Industries DLC)
1117087491 - Remove Road Props
1412844620 - Realistic Walking Speed
1394468624 - Advanced Stop Selection (ex MTSE)
1388613752 - Tree Movement Control
780720853 - Vehicle Effects 1.8.1
1349895184 - Tree LOD Fix
1324539315 - Land Ships
531738447 - CSL Show More Limits
553501635 - Sub-Buildings Enabler (DEPRECATED)
734025380 - Configure Outside Connections' Limits
785528371 - Cinematic Camera Extended
952542692 - Airport Road Light Remover
949504539 - SingleTrainTrackAI
932490392 - Track My Time
595017353 - More Flags ( + flags replacer )
932192868 - Road Options (Road Colors Changer ++) (possible conflict with No Crosswalks mod)
775021554 - Theme Mixer
922939393 - Transparency LODs Fix
911295408 - Prop Scaling 0.3 [Experimental ALPHA]
917543381 - No Problem Notifications
910440715 - Plant Scaling
903347963 - Transparent Selectors
883332136 - Any Road Outside Connections
881291183 - Ploppable Asphalt +
895061550 - Theme Decals
794268416 - Steamy - More Steam controls
427258853 - Crossings
497033453 - Unlimited Outside Connections (Beta)
445589127 - Precision Engineering
572888650 - Remove Need For Power Lines
576997275 - Remove Need For Pipes
821539759 - Disable Zone Check (unmaintained)
406102887 - Super Demand
552324460 - No Fires
621002682 - No Questions Asked
515489008 - Extra Train Station Tracks ( ETST )
541673195 - Resident Travel Rebalance v1.1 (not compatible with WG Citizen Lifecycle Rebalance mod below...)
654707599 - Citizen Lifecycle Rebalance v2.6
512314255 - More Network Stuff
426163185 - Realistic Population and Consumption Mod v8.4.0
409069482 - Fill The Houses
781767563 - Extended InfoPanel
793346248 - Decal Hover Area
438449058 - Building Eyedropper Tool
768213484 - Subtle Bulldozing, Dragging and More
442167376 - Advanced Vehicle Options (AVO) (old version, doesn't properly categorise Industries vehicles)
472128528 - Larger Footprints (Snowfall) (marked as game breaking in workshop)
611254368 - Environment Changer (+ Improved Theme Selection )
707497031 - Tram Station Track
465127441 - Airport Roads
774449380 - Catenary Replacer
1094334744 - Procedural Objects
1591584836 - HDRI 2K Cubemap Pack
1721492498 - Cargo Hold Fix
1747800340 - Building Theme: University City Districts
928128676 - Improved Public Transport 2
934994075 - Service Vehicle Selector 2
576327847 - 81 Tiles (Fixed for 1.2+)
412149127 - Font Selector
1591417160 - Hide It!
583429740 - Traffic Manager: President Edition [STABLE]

v10.20 doesn't include any of the parking fixes

1789133988 - Route Shields for PO
586012417 - Ploppable RICO
815103125 - Extra Vehicle Effects (Plugin for Vehicle Effects Mod)
455403039 - Unlimited Trees Mod v1.12
912484109 - Flood Damage Control [BETA]
763684437 - Roads United: North America PLUS (requires Roads United Core+ mod)
848896702 - Roads United: US Edition - Reworked (requires Roads United Core+ mod)
973512634 - Sort Mod Settings
1776052533 - Stops & Stations
1758376843 - Network Skins 2 (Beta)
1565201461 - Roads United: US Reworked 2018 (requires Roads United Core+ mod)
1771841274 - HDRI Haven Cubemap Pack 2
812713438 - Dynamic Resolution (Fixed for 1.9!)
552309905 - No Abandonment
412146081 - PostProcessFX v1.9.0
1680642819 - Ultimate Level Of Detail (ULOD)
1372431101 - Painter
1183931915 - Cubemap Replacer
458519223 - Unlock All + Wonders & Landmarks
924884948 - Plop the Growables
878991312 - Prop it Up! 1.4.4
793176674 - Sharp Textures
791221322 - Prop Precision
787611845 - Prop Snapping
694512541 - Prop Line Tool [PLT] (vAlpha)
650436109 - Quay Anarchy
465318661 - Toggleable Whiteness
689937287 - Surface Painter
1562650024 - Rebalanced Industries
1274199764 - Network Tiling
1209581656 - Relight
812107110 - Less Steam
762520291 - Shadow Strength Adjuster
672248733 - Ultimate Eyecandy v1.5.2
593588108 - Prop & Tree Anarchy
564141599 - No Seagulls
530771650 - Prefab Hook (Mod Dependency)
406354745 - Speed Slider [v2]
1658679290 - Forest Brush v1.2.5
1645781000 - Elektrix's Road Tools 2.0
898480258 - Camera Positions Utility
837734529 - Find It!
802066100 - Fine Road Anarchy
767233815 - Decal Prop Fix
651322972 - Fine Road Tool
523824395 - Clouds & Fog Toggler
502750307 - Extra Landscaping Tools
833779378 - Loading Screen Mod [Test]
1597852915 - More Advanced Toolbar (bit buggy & laggy)

Suggest: Resize It! mod by Keallu instead

845665815 - CSL Map View
450877484 - Mod Tools

Will update lotm about issue then close ticket.

Needs to switch to LABS version which has the parking fixes.

She was apparently using LABS when the issue occurred, but had switched to STABLE in hopes it would fix issue. Suggested to 'Clear Traffic' after switching back LABS as workshop users have stated that solves any remaining parking issues they had.

Reopening - the issue still persists with LABS 10.21.1
It's specifically the badi_dea assets, which , apparently use a custom AI (and thus likely not picked up by TM:PE parking AI):

100% sure i'm using labs, cleared traffic, still no dice
but since it doesn't effect any other parking i'm guessing more and more that it is just those parking lots.
badi_dea said "mine are using dummy AI, maybe a mod is altering the behavior of that AI?"
it worked before, but when i switched to labs for the first time it's been broken ever since
even if i move back to stable

aubergine18Yesterday at 12:47
Badi_Dea Which AI does your parking lot road parking assets use?
Badi_DeaYesterday at 16:11
I believe it was dummy AI - have you been talking to LOTM?

Tagging #280 , @479

Found an older issue relating to Parking Lot Roads - apparently the problem started after Campus update: #352

Another report, this time re: LABS:

t1a2l:
I have tmpe labs, i build a big parking near my zoo but no one use it...
parking roads

Also, the problem is also present on v11 ALPHA too. Maybe not as bad, but cars certainly avoid the parking lot roads.

Roads United Core has been flagged as potential cause of this issue (unconfirmed).

@aubergine10 still valid issue?

I'm not noticing any issues in-game with this, although I never really encountered the problem even when users were reporting it.


[ISSUE #54]Add filtering function when querying message consumption.

What is the purpose of the change
#54
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Does it work well in pagination

Currently all subscribers are displayed on the same page without pagination

Let's put another task to finish it, just tag it. Thanks.


[WIP] examples: Remove diskspace cleanup workaround (again)

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

i think we can just do this but it leaves a margin of 1G so i will hold off for now


Heat processes gone from countries with sub-region specific heat mixes

As the title says...

fixed in commit f025adb20ba8d0f6887d302bb01aa6d798661953


Location icon for use in ACE.

Another icon for Ace... location...
cc: @russelldocking

@russelldocking merge away


chore(master): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2022-06-18)
Features

include glob support (2d7cf6b)

This PR was generated with Release Please. See documentation.

Codecov Report

Merging #185 (db4500b) into master (2d7cf6b) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #185   +/-   ##
======================================
  Coverage    0.09%   0.09%
======================================
  Files          13      13
  Lines        1080    1080
======================================
  Hits            1       1
  Misses       1079    1079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7cf6b...db4500b. Read the comment docs.


No emails   from boxbilling

What happened?
Hello
A strange situation. After configuring the email in the system, the test email arrives fine, but any other email are not sent. In cpanel exim mainlog there is no trace of trying to send a message for example - payment reminder or welcome email after registration
BoxBilling Version
v4.22-beta.1.5
What version of PHP are you running?
Something unsupported
Additional Notes
php 7.4

Just to confirm, cron jobs are configured and running correctly?


multi-language support

It would be great if there is a way we could support multi-language support like Chinese support.

@koettert please check internal if modern UI supports multi languages


Notebook ipynb localization

An analyst can edit/run their project notebook directly from Saturn, such that they avoid configuration, authentication, and billing makework
Click a notebook, and it automatically gets sent to the cluster for your workspace's project.
We should also localize a config file with some info about which workspace this ipynb came from
see the work CH has done for AoU:
https://docs.google.com/document/d/1GbaL1otgswBEOqfte8JO8uQDG_vSEG4a-qcKMEdufLI/edit?ts=5a9f0881#heading=h.vswboj30ycb7

@rtitle @calbach @blrubenstein Can you comment on how this is being handled for All of Us?

Existing APIs should cover this.

We can manually place an ipynb in /notebooks of the workspace bucket (using gsutil). This then is about displaying the contents of that dir as cards, and providing the interaction to click on a card and have it open on (what ought to be a single) cluster.
Right now we're allowing multiple clusters per user per project. In the future this will be a single cluster. I'm happy for now while things are multiple to just take the head of a list

From @zarsky-broad : localize all ipynb files in workspace when you view that tab (have a little check when something is available to open). Then user clicks and it opens instantly.

Will eventually use https://github.com/DataBiosphere/leonardo/issues/306


Strings.

Add simple usage of strings and ASCII characters.

String variables and literals
Appending strings
Character at index of string
Printing strings

Reopened until appending to strings and character access is implemented.


Not able use the mouse clicks(left) to navigate through the phone

I have watched few yt tutorials and downloaded the scrcpy software and now I have issues with navigating through the mobile phone using my mouse's left click. This issue as I have traced is mostly because the phone is on a different resolution than the software is reading
INFO: Renderer: direct3d
INFO: Texture: 1080x2336
INFO: Texture: 888x1920
I need help in rectifying this issue
Device info:
OPPO F11 PRO - 2019

Run scrcpy -m1920. See #1645

Run scrcpy -m1920. See #1645

Where do i run it, I am very new to it.

https://github.com/Genymobile/scrcpy/blob/master/doc/windows.md#run

https://github.com/Genymobile/scrcpy/blob/master/doc/windows.md#run

Thank you very much, I have read you'r comments previously and it is really impresive.

Every time when I open, the issue is repeating. Any solution?

Scrcpy does not store any state, it is configures by the arguments you pass every time. If you want to always pass the same arguments, create a script (as explained at the end of https://github.com/Genymobile/scrcpy/blob/master/doc/windows.md#run)


Addressing PR #453 review comments

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

@ttuegel is this what you were suggesting?

These have been merged as part of rolling back the rollback PR


Use typographic apostrophe in contractions

We generally do this, but here are a few we missed... (I did a search across the codebase for all the contractions I could think of).

It broke a linter and a test, who’ve thought it? 🤦


CSV read error (header processing)

Describe the bug
Snapshot detail grid does not work well.
Beside this, there's been some problems related to CSV reading.
To Reproduce
Steps to reproduce the behavior:

Click any snapshot. (I believe anyone who tests this issue already has at least one valid snapshot.)
See error.

Expected behavior
The grid should be shown properly.
Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser: Chrome
Version: 68.0.3440.106

Additional context
https://github.com/metatron-app/metatron-discovery/pull/1542 probably produced this bug. (by myself)

1st integrated test passed.


requests.exceptions.SSLError

Hi,
When I execute the script, I enter my password and then I've got an SSl error:
python ExportLists.py playlists

Logging into google music...
<EMAIL_ADDRESS>password:
Traceback (most recent call last):
File "ExportLists.py", line 17, in
api = open_api()
File "/home/vmadmin/dev/gmusic-playlist-master/gmusic-playlist-master/common.py", line 162, in open_api
if not api.login(username, password, Mobileclient.FROM_MAC_ADDRESS):
File "/usr/local/lib/python2.7/dist-packages/gmusicapi-7.0.0.dev0-py2.7.egg/gmusicapi/clients/mobileclient.py", line 64, in login
if not self.session.login(email, password, android_id):
File "/usr/local/lib/python2.7/dist-packages/gmusicapi-7.0.0.dev0-py2.7.egg/gmusicapi/session.py", line 170, in login
res = gpsoauth.perform_master_login(email, password, android_id)
File "/usr/local/lib/python2.7/dist-packages/gpsoauth-0.0.4-py2.7.egg/gpsoauth/init.py", line 66, in perform_master_login
return _perform_auth_request(data)
File "/usr/local/lib/python2.7/dist-packages/gpsoauth-0.0.4-py2.7.egg/gpsoauth/init.py", line 22, in _perform_auth_request
headers={'User-Agent': useragent})
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 107, in post
return request('post', url, data=data, json=json, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 53, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 468, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 576, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 447, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: bad handshake: Error([('SSL routines', 'SSL3_GET_SERVER_CERTIFICATE', 'certificate verify failed')],)

make sure your python certificates are up to date and haven't been overriden up by other installs.  http://stackoverflow.com/questions/27835619/ssl-certificate-verify-failed-error
python is an annoying beast to try and setup.  there is a javascript version of this script you can also try.

Thank you.
I totally agree with you, I will try this. You save me thanks ;)


Raising events for a parallel state causes no transition to occur in initial state.

Bug or feature request?
Bug
Description:
I'm on xstate 3.3.2, given this code:
const {
  Machine,
  actions: { raise }
} = require("xstate");

const t = (state, event) => {
  state = testMachine.transition(state, event);
  console.log(`[${event}]: ${JSON.stringify(state.value)}`);
  return state;
};

const testMachine = Machine({
  strict: true,
  parallel: true,
  states: {
    OUTER1: {
      initial: "C",
      states: {
        A: {
          onEntry: [raise("TURN_OFF")],
          on: {
            EVENT_OUTER1_B: "B",
            EVENT_OUTER1_C: "C"
          }
        },
        B: {
          onEntry: [raise("TURN_ON")],
          on: {
            EVENT_OUTER1_A: "A",
            EVENT_OUTER1_C: "C"
          }
        },
        C: {
          onEntry: [raise("CLEAR")],
          on: {
            EVENT_OUTER1_A: "A",
            EVENT_OUTER1_B: "B"
          }
        }
      }
    },
    OUTER2: {
      parallel: true,
      states: {
        INNER1: {
          initial: "ON",
          states: {
            OFF: {
              on: {
                TURN_ON: "ON"
              }
            },
            ON: {
              on: {
                CLEAR: "OFF"
              }
            }
          }
        },
        INNER2: {
          initial: "OFF",
          states: {
            OFF: {
              on: {
                TURN_ON: "ON"
              }
            },
            ON: {
              on: {
                TURN_OFF: "OFF"
              }
            }
          }
        }
      }
    }
  }
});

let state = testMachine.initialState;
console.log(`INITIAL: ${JSON.stringify(state.value)}`);
state = t(state, "EVENT_OUTER1_B");
state = t(state, "EVENT_OUTER1_A");
state = t(state, "EVENT_OUTER1_C");

(Bug) Expected result:
INITIAL: {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[EVENT_OUTER1_B]: {"OUTER1":"B","OUTER2":{"INNER1":"ON","INNER2":"ON"}}
[EVENT_OUTER1_A]: {"OUTER1":"A","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[EVENT_OUTER1_C]: {"OUTER1":"C","OUTER2":{"INNER1":"OFF","INNER2":"OFF"}}

(Bug) Actual result:
The OUTER1 state sticks on C. However the events raised by the onEntry are fired off, as shown by the OUTER2 state.
After EVENT_OUTER1_C, the OUTER2 state is mismatched from the expected result due to the C state not having the EVENT_OUTER1_C event.
INITIAL: {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[EVENT_OUTER1_B]: {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"ON"}}
[EVENT_OUTER1_A]: {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[EVENT_OUTER1_C]: {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}

Commenting out either the INNER1 or INNER2 state stops the OUTER1 state from sticking on C.
Alternatively, commenting out B's onEntry also has the same effect for the OUTER1 state.
Link to reproduction or proof-of-concept:
CodePen Debugger

Great catch!
Just to explain the statechart quickly to @davidkpiano:

OUTER1 and OUTER2 are two regions.
OUTER1 has A B and C, that have events to go to any of those three (e.g. A defines EVENT_OUTER1_B to go to B.
OUTER2 is itself a parallel state (directly nested in another parallel state, although I tried moving it to a substate of another region but it didn't change the behaviour)
OUTER2 has two regions INNER1 and INNER2, each with substates ON and OFF
ON and OFF are controlled via raised events from the onEntry of the A B C states

So controlling the machine using OUTER_A; _B and _C the bug seems to be observing some side effects of entering B (Entering B raises TURN_ON which should cause both OFF states to go to ON) but without actually entering B itself.
Removing the raised events causes the normal state transitions to happen.

Shouldn't the initial state be OUTER1: C, INNER1: OFF, INNER2: OFF?  The initial state of OUTER1.C should be raising the CLEAR event, which should cause INNER1.ON to go to INNER1.OFF.  Maybe a separate bug.

There is some strange things going on.  It seems to be stuck in the initial state of the substate somehow.  If I change OUTER1's initial state to A, then it 'sticks' to A instead of C.

Good point on 1, I was too focussed on the sticking to see that!
Codepen debugger
I found another interesting case with this particular machine.
So with that definition above, but with OUTER1.B's onEntry commented out (to prevent the OUTER1 state from sticking)
const {
  Machine,
  actions: { raise }
} = require("xstate");

const t = (state, event) => {
  state = testMachine.transition(state, event);
  console.log(`[${event}]: ${JSON.stringify(state.value)}`);
  return state;
};

const testMachine = Machine({
  strict: true,
  parallel: true,
  states: {
    OUTER1: {
      initial: "C",
      states: {
        A: {
          onEntry: [raise("TURN_OFF")],
          on: {
            EVENT_OUTER1_B: "B",
            EVENT_OUTER1_C: "C"
          }
        },
        B: {
          // onEntry: [raise("TURN_ON")],
          on: {
            EVENT_OUTER1_A: "A",
            EVENT_OUTER1_C: "C"
          }
        },
        C: {
          onEntry: [raise("CLEAR")],
          on: {
            EVENT_OUTER1_A: "A",
            EVENT_OUTER1_B: "B"
          }
        }
      }
    },
    OUTER2: {
      parallel: true,
      states: {
        INNER1: {
          initial: "ON",
          states: {
            OFF: {
              on: {
                TURN_ON: "ON"
              }
            },
            ON: {
              on: {
                CLEAR: "OFF"
              }
            }
          }
        },
        INNER2: {
          initial: "OFF",
          states: {
            OFF: {
              on: {
                TURN_ON: "ON"
              }
            },
            ON: {
              on: {
                TURN_OFF: "OFF"
              }
            }
          }
        }
      }
    }
  }
});

If we were to perform these transitions:
let state = testMachine.initialState;
console.log(`INITIAL: ${JSON.stringify(state.value)}`);
state = t(state, "EVENT_OUTER1_B");
state = t(state, "TURN_ON");
state = t(state, "EVENT_OUTER1_A");
state = t(state, "EVENT_OUTER1_C");

What happens is the OUTER1 state transitions to B on EVENT_OUTER1_B, but goes back to C on the TURN_ON event.
Expected result
                                        // INNER1: OFF from point 1.
INITIAL:          {"OUTER1":"C","OUTER2":{"INNER1":"OFF","INNER2":"OFF"}}
[EVENT_OUTER1_B]: {"OUTER1":"B","OUTER2":{"INNER1":"OFF","INNER2":"OFF"}}
[TURN_ON]:        {"OUTER1":"B","OUTER2":{"INNER1":"ON","INNER2":"ON"}}
[EVENT_OUTER1_A]: {"OUTER1":"A","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[EVENT_OUTER1_C]: {"OUTER1":"C","OUTER2":{"INNER1":"OFF","INNER2":"OFF"}}

Actual result
INITIAL:          {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[EVENT_OUTER1_B]: {"OUTER1":"B","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[TURN_ON]:        {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"ON"}}
[EVENT_OUTER1_A]: {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}
[EVENT_OUTER1_C]: {"OUTER1":"C","OUTER2":{"INNER1":"ON","INNER2":"OFF"}}

I'm not sure if this would be classed as a separate bug..

Can you do me a favor and turn this into a PR containing the failing test case? (Should be just a matter of copy-pasting this into the correct test file, probably parallel.test.ts)


make git config oh-my-zsh.hide-status work with the agnoster theme

Hide the git prompt when the oh-my-zsh.hide-status git config option is set.

Thanks @marten-seemann Just tried this and it works great!

Thanks @marten-seemann Switched to your pr and it worked!

I don't think there's any other solution for this problem. It also looks like this has been tested by a couple of people.
@robbyrussell is there anything I can do to get this merged?

Thanks and pardon the delay!

Wow, finally, thanks so much!


Remove deprecated R11s driver methods

Remove deprecated methods (createDocumentService and createDocumentService2) from r11s driver api.
Closes #5206

Looks like the build failed due to fetchTool needing createDocumentService. Will see if I can switch that over to DocumentServiceFactory without too much effort

@jatgarg Just do double check whether we are using these somewhere?

Yes, 1 place due to which the build failed. But @znewton is switching to factory for creating it. Sounds good.


Potential issue: Logged in user token deleted upon linking social account

I'm working on adding OAuth2 support to an app, and I noticed upon using $auth.link(), the token for the logged in user is getting deleted from local storage.  I'm using version 0.10.1 since it's the version bundled with the seed project I've been working from.
Is deletion of the token from local storage the intended behavior?  If not, has it been solved in a later version?

The decision to save the provider-tokens in the same field always confused me as well.


[CLIPPER-129] Update RPC benchmark to use event-based RPC service

This also cleans up the benchmark to make it a little cleaner and easier to use.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/74/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/75/
Test PASSed.

@Corey-Zumar addressed your comments and tested it with the Python Noop container.
Sorry for polluting the PR a bit with whitespace changes, I guess I still haven't fully worked out the format checker in the CI script.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/80/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/84/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/85/
Test PASSed.

@Corey-Zumar Fixed formatting so the checks all pass. Merge this when you get a chance.


Concurrency usage of statsd client

@alexcesaro Is the client concurrency safe ?
c, _ := New()
go c.Increment("foo.counter")
go c.Increment("haha.counter")
Is this allowed ?

going through the code, seems like it supports concurrency as it acquired locks and releases lock


Confidence level difference between .mlmodel and .model

@gustavla @TobyRoseman
I have trained and created .model and .mlmodel file
Predict sample image using .model file
import turicreate as tc
#load image
test = tc.SFrame({'image': [tc.Image('test.jpg')]})
#load the model
model = tc.load_model('mymodel.model')
test['predictions'] = model.predict(test)
print(test['predictions'])
Result : [[{'confidence': 0.5855070428502438, 'type': 'rectangle', 'coordinates': {'y':<PHONE_NUMBER>422659, 'x':<PHONE_NUMBER>469142, 'width':<PHONE_NUMBER>451022, 'height':<PHONE_NUMBER>9652575}, 'label': 'test'}]]
Import coreml model in iOS app and pass the frame, i am getting confidence level as 0.84
Why different confidence score between .model and .mlmodel
Any help appreciated !!!

Take a look at the docstrings for export_coreml(...). This might be relevant:

The instances are not sorted by confidence, so the first one will generally not have the highest confidence (unlike in predict). Also unlike the predict function, the instances have not undergone what is called non-maximum suppression, which means there could be several instances close in location and size that have all discovered the same object instance.

@TobyRoseman  Thanks for your response ! Is there any possible ways to match both .model and .mlmodel confidence level to check accuracy ?

The defaults should probably be the same both for predict and export_coreml such that the predictions come out the same using defaults in Turi Create and using the exported model in CoreML. Tagging as a bug to make sure this is addressed.

The default confidence levels for predict and export_coreml are the same: 0.25
Hmm, you should be able to use CoreMLTools to load the exported model and perform inference on it, in a controlled Python environment on your Mac, before trying to deploy to iOS. If you sort both the Turi output and the CoreML output by confidence, it would be interesting to see the results.
Note that in general, the results might not be precisely the same, since different NN inference engines are being used in each code path.

@nickjong  Thanks for your response !
Predict same image using .model and .mlmodel file
model -> confidence: 0.58
.mlmodel ->confidence 0.84
COnfidence level are different ? Please explain why confidence score is different for both models

@nickjong @znation @TobyRoseman  any updates ?

Hmm, some difference is to be expected depending on how the image is resized and otherwise converted into the raw NN input, but I am surprised that the difference is this high. Would you be able to share the saved .model  and the image you're using for testing? (If not, we can try to repro on our end, but it might be helpful to ensure we're looking at the same things.)


PHPCS: ruleset tweak

For this repo, we use a separate package for linting code, so there is no need to have the Generic.PHP.Syntax sniff running when doing a PHPCS scan (the sniff is included in the WordPress-Extra ruleset).
An analysis of the performance of a sniff run on this repo revealed that this was the slowest sniff by far. As excluding it will not have any QA impact, let's make CS runs on the code in this repo faster.

While probably not fully representative, on my machine on develop, a CS run on this repo takes nearly 5 minutes, while with this change, it takes about 8 seconds... (and that's without the cache active as that would influence the results otherwise)
I used the following command to test: phpcs --report-source --no-cache

Weird that the results om my machine are so different, but thanks for merging this anyway. As I said - we already lint in a different way, so it's not as if this changes any safeguards for the repo.


Inconsistent Behaviour in http server : Big Integers are getting converted to float before storing thus losing their precision

Steps to reproduce
Trying to set math.MinInt64
curl --location --request GET 'localhost:8082/set' \
--header 'Content-Type: application/json' \
--data '{
    "key" : "a",
    "value" : -9223372036854775808
}'

curl --location --request GET 'localhost:8082/get' \
--header 'Content-Type: application/json' \
--data '{
    "key" : "a"
}'

The result of get operation is
Expected output
{
    "status": "success",
    "data": -9223372036854775808
}

Observed output
{
    "status": "success",
    "data": "-9223372036854776000"
}

On further investigation, I observed that its happening while unmarshalling the request body in the http handler.

In ParseHTTPRequest in redisCmdAdapter.go : we are converting the request body to map[string]interface{}
Since the value type is interface{} golang considers the numbers as float which has precision limits upto 15 digits and thus converts it to scientific notation -9.223372036854776e+18 before storing in the DB

Is this one being worked on? For the solution, should we try converting to string and
use big.Int -> func (z *Int) SetString(s string, base int) (*Int, bool)
bigIntVal := new(big.Int)
if strValue, ok := value.(string); ok {
  bigInt, success := bigIntVal.SetString(strValue, 10)
  if !success {
    return errors.New("Error: Failed to convert string to big.Int")
  }
}

@pg30 Raised a PR for the fix here: https://github.com/DiceDB/dice/pull/1227
Please do have a look.


Looking for Google Summer of Code GSOC students

Hi all,
Repairnator is part of Google Summer of Code, as a subproject of the CASTOR Software Research Centre.
If you'd like to be a Repairnator contributor as part of GSOC, drop a comment in this issue.
--Martin

Hi @monperrus!
I'm Krishna, a sophomore from IIIT Delhi pursing BTech in Computer Science with Applied Mathematics.
I have taken courses focused on Data Structures, Algorithms and OOPs concepts in Java.
I really like this project and would love to contribute to it. However, I'm relatively new to open source communities. It would be really helpful if you could guide me with which topics do I need to learn or where should I get started so that I can understand this project better and eventually contribute to it.
Thank you!

Hi @monperrus .
I'm Yashraj, a learning enthusiast from Cv Raman Global University, Bhubaneshwar pursuing B.Tech in Computer Science. I am a Competitive Java Programmer and a Web Developer too. I have learned the concepts of Java on OOPs and I also practice Data Structures and Algorithms using Java.
I really like this project and would certainly devote my time to contribute to it. I have also contributed to open source communities before in 2020. I would like you to please guide me through the topics that I could learn, by which I can contribute to your project and get started on it.
Sir, you can too look at my coding profiles mentioned below :
Codechef
Leetcode
GeeksForGeeks


Add a CI/CD pipleline

build on all PRs to main
build, push and deploy to AWS on all code changes in main
restrict PRs to main be merge only if the build workflow passes

Thank you <3


Can you please clarify this document for SharePoint 2013? SP2013 does not support to configure TLS for outgoing email. The document will mislead our customers.

[Enter feedback here]
Can you please clarify this document for SharePoint 2013? SP2013 does not support to configure TLS for outgoing email. The document will mislead our customers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 281f143b-b1d6-582a-25a7-d803518181a4
Version Independent ID: 8f82c931-36a6-d4a2-822c-3dce64beb25a
Content: Configure outgoing email for a SharePoint Server farm
Content Source: SharePoint/SharePointServer/administration/outgoing-email-configuration.md
Product: sharepoint-server-itpro
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@Jiankui2018  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @Jiankui2018, thank you for your feedback.
This article doesn't have instructions to configure TLS on the IIS SMTP server. You don't need to configure it on SP2013. Sorry but maybe I misunderstood you.

Hi @dariomws, I think the concern is that this article discusses the "Use TLS connection encryption" setting in a couple of different places.  However, TLS connection encryption was first introduced in SharePoint Server 2016.  Older versions of SharePoint don't have this feature.
Maybe we should add a note about this to the top of the article, just like this note we added about SMTP authentication:

The SMTP authentication feature is only available in SharePoint Server 2019.

@TroyStarr agree I think a note is a good idea. Thank you!
Only 2019? What about 2016?

Yes, that's what I would like to see. Thanks all.


SynchronizedObservableCollection.Insert(int, T) ArgumentOurOfRangeException fix

@fjch1997 can you provide more details on the issue you are trying to solve? If possible an example to reproduce would also be helpful.
Unless I'm missing something the change you submitted simply moves the code from the CheckIndex(int index) method inline to 'Insert(int index, T item)' so I'm not sure how the behavior would be different.

Sure. I thought it was too obvious (guess it's just to me) that I didn't take the time to explain anything.
Let's say you do this.
var collection = SynchronizedObservableCollection<string>();
//collection.Count is 0.
//Then try this.
collection.Insert(0, "blah");//ArgumentOutOfRangeException is raised.

CheckIndex(int) then do an evaluation of (index < 0 || index >= _items.Count)
In the above case (Count == 0). This is true. and CheckIndex(int) raises an ArgumentOutOfRangeException.
By changing
(index < 0 || index >= _items.Count)

to
(index < 0 || index > _items.Count)

(Notice the removed "=")
The exception is no longer raised when trying to append an object to the end of the collection. This is the correct behavor of ICollection.Insert(int, T)

Thanks again for writing this excellent SynchronizedObservableCollection.
I was using the ConcurrentObservableCollection from Swordfish.NET.Collections (which is the #1 google search result)
But it didn't working very well. It's fine when we do the debugging and testing. But our clients are reporting some strange behaviors and crashes. We looked into it's source code but found that it's just over-complicated and that makes it error prone.

Makes perfect sense. At first glance I didn't notice the removed "=" but looking at the source for both Collection<T> and ObservableCollection<T> I have confirmed this is the correct behavior and I'm not sure how I introduced this issue since most of the code was copied from the original.
Glad to hear the SynchronizedObservableCollection has been useful to you :)


Tesseract merge?

How about merging with http://tesseract.gg?

Seems legit.
Imo it should be merged (maybe as big step for the second final release), but i'd rather like to use it as a prototype and reuse @eihrul's changes on tesseract instead of merging it forcefully.
Would be a shitload of work, but maybe we can bring it to work in parallel to the old lightmap system.
We should at least keep that in mind designing the next mapformat (i.e. light entities of different versions)..
I think a lot of nice stuff already can be adopted now. E.g. multiplayer undo and multiplayer vslots, #114.
And the various code cleanups ofc also could help.

We have been asked several times about merging Tesseract and in particular the rendering subsystem. There are other improvements as well, but I'll focus on this topic.
The most important technology introduced in Tesseract is deferred shading which solves the problem of having performance issues with many lights. Whereas the Cube 2 engine calculates lightmaps in beforehand which can take hours on a complex map, Tesseract does it in realtime (which means at least 60 fps).
I think it IS a huge task and we are currently working on other huge tasks (HTML5 rendering engine, new entity system, new particle system, new map format, improved content packaging). Although I would like to see deferred shading in Inexor, we should wait until we finished the current work.

Agree, agree, and agree.

I agree that it sounds a lot more sophisticated and stable when we merge features of Tesseract step-by-step over time.

Some features like the one mentioned by @a-teammate can be merged step by step, but I think merging the deferred shading rendering is one monolithic block of work.
Also, I think we wouldn't merge the deferred shading 1:1 (new entity system = new lights, new map format, ambient occlusion, mixing light maps and deferred shading).

I like how people think its like turning on a switch, tesseract code is immensely different from cube 2:sauerbraten and therefore way different from inexor. There is about 4000+ lines of code that tesseract adds to the project, not counting all the code changes. Its not like an external library that can be just replaced.
@a-teammate
IDK if you can use lightmaps with the realtime lights, Tho the concept sounds interesting, using light baking, to control static lights to improve improving, Tho I dont think the old light map code can actually work as a bake map.

Closed in favor of #310.


Single output

Why using CLI (reading settings from .reffiter file) I get two outputs?
One in outputFolder specified in settings file, but with name from that file name (i.e. test.refitter -> test.g.cs) and another one named Ouput.cs in directory from which I ran the command?
Please, add outputFileName to .reffiter settings so that only one output is produced.

@bielik01 thanks for taking the time to report this
The .g.cs output file was a remnant of the initial source generator implementation. In the original implementation, which didn't work, the output file was never persisted to disk (the normal behavior for source generators). Unfortunately, source generators ran independently of each other and the Refit source generator didn't know that Refitter generated a Refit interface
I'll fix this by adding the outputFileName that you suggest

@all-contributors please add @bielik01 for bugs

Thanks a lot! I try to keep files in the project to minimum 😅

@bielik01 Do you use the Refitter.SourceGenerator package reference? This does some MSBuild magic that automagically includes any .refitter file as AdditionalFiles which allows the Refitter source generator to discover it upon build time, generating the .g.cs file. There wouldn't be a need to use the CLI tool if you're already using the source generator

Thanks a lot! I try to keep files in the project to minimum 😅

Perfectly understandable, I do the same. No code is better and faster than no code :)

Yeah, I just noticed what that package does, it's pure magic! But even then, I kinda want it to have name specified by me 😂

I'll try to implement this tonight

@bielik01 This is implemented but not thoroughly tested yet. I'm taking a week few days off for the autumn break to spend some time with the family


feat(database): implement order-independent equality for Reverts

Closed #1813

hi @Rjected please help me review it, thank!

hi @Rjected @rakita please help me review, thank

Hi @rakita can you merge this PR?


Stocks not working correctly

After inserting a stock, it doesn't return after reloading the panel.
Looks to be a discrepancy between the idmc column on insert and query.
On insert the following logic is used:
idmc = state.getMagicCard().getId()

and on query the following is used:
idmc == IDGenerator.generate(mc)

Looking at the Mysql dao, it looks like using IDGenerate is what is intended here?

Hi,
Thanks a lot for your feedback .. i was alone testing my app :)
IDGenerate allow me to have a "unique" id for cards (especially when you use other providers with their own ids).
Daos must use this function and never save "mc.getID".

fixed ebd7809


ScrollView fires "onLayout" and "onContentSizeChange" all the time

Description
I add onLayout and onContentSizeChange two prop in ScrollView to get content size and viewHeight so that I can scroll to bottom properly in my section.
I want to stop calling onLayout and onContentSizeChange fires continuously, and also want to stop rerendering if any values haven't changed.
The scroll is working fine, but onLayout and onContentSizeChange fires continuously, even if the values haven't changed.
Reproduction Steps and Sample Code
I add below screen shot code:

Now the console log in which shows onLayout funbction call continuously.

Solution
I need to stop calling all time onLayout function in scrollview if any values not changed.
Additional Information

React Native version: [0.40]
Platform: [both]
Development Operating System: [ macOS, Linux]

Please check on latest react native version, this one is very old.

0.45.1 is the latest stable. If this is reproducible in 0.45.1, please open a new issue and make sure to follow the template.

I can't use new react native version for now because of many library support. We will do it later task may be after few months. Please tell us for now that can we fix this issue in this current version or not.

@MSSPL-PiyaleeMaiti create a new empty project a try if you can reproduce this issue on new RN version, you don't your whole app to do this.

@radko93   It may fix bug it's a live version and we need a quick fix. We know as it may surely fix the issue after using the new version. So can you provide some quick solution for now.
As we are focusing to new version upgradation later.

@MSSPL-PiyaleeMaiti  i want to find the scroll down action and hit the services to get some data to display,(like in whats app, while scrolling down i have to display the previous messages ) and my code is
render() {
return (
<ScrollView  ref='scrollView'
onContentSizeChange={(w, h) => this.contentHeight = h}
onLayout={ev => this.scrollViewHeight = ev.nativeEvent.layout.height} >
{this.renderList()}

)}
scrollToBottom(animated = true) // i am calling this method from  componentDidUpdate()
{
const scrollHeight = this.contentHeight - this.scrollViewHeight;
if (scrollHeight > 0) {
const scrollResponder = this.refs.scrollView.getScrollResponder();
scrollResponder.scrollResponderScrollTo({x: 0, scrollHeight, animated});
}
}
My Issues is : I am not able to listen the ScrollDown action
Please help me to solve this..


Error while running waternet - no module named config

Hi @treigerm,
whenever I'm running waternet in docker, I'm getting below error:
Traceback (most recent call last):
  File "waterNet.py", line 7, in <module>
    from waterNet.config import DATASETS, OUTPUT_DIR, TRAIN_DATA_DIR, LABELS_DIR
  File "/home/rohankar/Projects/tomtom/concept-dev/WaterNet/waterNet.py", line 7, in <module>
    from waterNet.config import DATASETS, OUTPUT_DIR, TRAIN_DATA_DIR, LABELS_DIR
ImportError: No module named config

Can you help?

I think the problem was that I forgot the init.py file in the waterNet module. Now that I've uploaded one can you try it again and see if it works?

It worked! thanks for help, I'm python and ML noob. :)


using actual currency from settings for product entry

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Issue - User can switch between EUR and SEEDS, but on entry, it's stored as "FIAT"
This doesn't make sense we need to store entries as the actual currency they were entered in.
Also need to show items with the correct currency
✅ Checklist

[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
We are getting list of currencies from the exchange rate provider - so we should not be storing a new list inside the app. We should simply use the String ID for each currency.
🙈 Screenshots
Above - before
Below - after

👯♀ Paired with
me myself and I

Hi Nick, I was testing your recent commits and I found some bugs when Adding and removing products to be displayed. if an user try to delete a product it goes to negative instead of disappearing. Also when they click on a product to be added it wont take you to the receive screen and product is also added with a quantity of 0.

Hi Nick, I was testing your recent commits and I found some bugs when Adding and removing products to be displayed. if an user try to delete a product it goes to negative instead of disappearing. Also when they click on a product to be added it wont take you to the receive screen and product is also added with a quantity of 0.

I also notice that even after reloading products added to receive will still show but with 0 quantity.

I also notice that even after reloading products added to receive will still show but with 0 quantity.

I am not sure this receive + products feature is ready for users.
The UI is so ugly it makes me throw up and the are so many bugs that i dont even know where to start.
I think we should have jason design this feature and we should put some work on it.

I am not sure this receive + products feature is ready for users.
The UI is so ugly it makes me throw up and the are so many bugs that i dont even know where to start.
I think we should have jason design this feature and we should put some work on it.

Will try to fix this up today

Will try to fix this up today

I saw those bugs too will check

On Jan 15, 2021, at 10:05 AM, gguij004<EMAIL_ADDRESS>wrote:

Hi Nick, I was testing your recent commits and I found some bugs when Adding and removing products to be displayed. if an user try to delete a product it goes to negative instead of disappearing. Also when they click on a product to be added it wont take you to the receive screen and product is also added with a quantity of 0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I saw those bugs too will check

On Jan 15, 2021, at 10:05 AM, gguij004<EMAIL_ADDRESS>wrote:

Hi Nick, I was testing your recent commits and I found some bugs when Adding and removing products to be displayed. if an user try to delete a product it goes to negative instead of disappearing. Also when they click on a product to be added it wont take you to the receive screen and product is also added with a quantity of 0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

merge conflicts

merge conflicts

Hi, Nick I really idea and the way you displayed a receipt for the products, however this pr whats initially for using actual currency from settings for the products entry and now it has a lot of changes making it a little hard to test and debug. I tested the UI and will add some screenshots about the bugs I found. I am more than happy on helping fixing those.

Hi, Nick I really idea and the way you displayed a receipt for the products, however this pr whats initially for using actual currency from settings for the products entry and now it has a lot of changes making it a little hard to test and debug. I tested the UI and will add some screenshots about the bugs I found. I am more than happy on helping fixing those.

.Receive page do not have the  "Receive"  on the top as a feedback for the user anymore,
.When user do not have products yet two "Next" button shows but is not clear what they do.
.Is not clear that the edit icon is for the products

.Receive page do not have the  "Receive"  on the top as a feedback for the user anymore,
.When user do not have products yet two "Next" button shows but is not clear what they do.
.Is not clear that the edit icon is for the products

.The seeds button move out of the context when there is an error
.Please see screenshot for a bad state bug

.The seeds button move out of the context when there is an error
.Please see screenshot for a bad state bug

.Need some feedback for the user when they enter a non digit

.Need some feedback for the user when they enter a non digit

. All products are being created with 0 as price.

. All products are being created with 0 as price.

. Bad state (key), I try creating a product with the right name and price but it still give me an error.

. Bad state (key), I try creating a product with the right name and price but it still give me an error.

I think the transfer validation instead of the receive was use in here.

I think the transfer validation instead of the receive was use in here.

Mother of changes.

Is this PR for using actual currency or rewriting the entire app :)

Mother of changes.

Is this PR for using actual currency or rewriting the entire app :)

I refactored all the merchant screens and code

On Jan 19, 2021, at 5:32 AM, Gerardo Guijarro<EMAIL_ADDRESS>wrote:

Mother of changes.
Is this PR for using actual currency or rewriting the entire app :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I refactored all the merchant screens and code

On Jan 19, 2021, at 5:32 AM, Gerardo Guijarro<EMAIL_ADDRESS>wrote:

Mother of changes.
Is this PR for using actual currency or rewriting the entire app :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Lol

On Jan 19, 2021, at 5:32 AM, Gerardo Guijarro<EMAIL_ADDRESS>wrote:

Mother of changes.
Is this PR for using actual currency or rewriting the entire app :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Lol

On Jan 19, 2021, at 5:32 AM, Gerardo Guijarro<EMAIL_ADDRESS>wrote:

Mother of changes.
Is this PR for using actual currency or rewriting the entire app :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

.The seeds button move out of the context when there is an error
.Please see screenshot for a bad state bug

Yes I have seen this - should be fixed.
Although I don't think anything that was already a bug before should stop this commit. Maybe just removing the yellow outline is a fix - seems like that's just off
I remember looking into this and it was kinda complicated to fix (more than it appears)

.The seeds button move out of the context when there is an error
.Please see screenshot for a bad state bug

Yes I have seen this - should be fixed.
Although I don't think anything that was already a bug before should stop this commit. Maybe just removing the yellow outline is a fix - seems like that's just off
I remember looking into this and it was kinda complicated to fix (more than it appears)

@gguij004 Sorry for the bugs, since this PR turned into a fulll refactor I should have set it back to draft mode
I found and fixed most of those errors along the way, with the exception of the title and the error condition yellow box thing.
I will fix those.

@gguij004 Sorry for the bugs, since this PR turned into a fulll refactor I should have set it back to draft mode
I found and fixed most of those errors along the way, with the exception of the title and the error condition yellow box thing.
I will fix those.

@gguij004  fixed the error condition layout

@gguij004  fixed the error condition layout

@gguij004

@gguij004

.Need some feedback for the user when they enter a non digit

Disagree - the user sees a number pad, unless they copy / paste in something, they won't be able to enter a non number
Good enough for now. No errors really happen from this.

.Need some feedback for the user when they enter a non digit

Disagree - the user sees a number pad, unless they copy / paste in something, they won't be able to enter a non number
Good enough for now. No errors really happen from this.

Hi Nick, I found some bugs after review your latest commit. Please watch this video not sure why a weird black screen shows when navigating to the receive page.
https://user-images.githubusercontent.com/51983923/105118237-04641d00-5a9c-11eb-94fe-8994c010831f.mov

Hi Nick, I found some bugs after review your latest commit. Please watch this video not sure why a weird black screen shows when navigating to the receive page.
https://user-images.githubusercontent.com/51983923/105118237-04641d00-5a9c-11eb-94fe-8994c010831f.mov

I think product should have a label like before? like "Price" not sure if we are taking the label out.

I think product should have a label like before? like "Price" not sure if we are taking the label out.

"Receive" is not displayed in the middle for all devices

"Receive" is not displayed in the middle for all devices

For the Receipt feature, I notice that the amount is displayed but we allow users to create products with seeds or fiat, and this information is not being displayed on the receipt. For Example is 27 price from tequila 27 seeds or USD?

For the Receipt feature, I notice that the amount is displayed but we allow users to create products with seeds or fiat, and this information is not being displayed on the receipt. For Example is 27 price from tequila 27 seeds or USD?

Overflow on receipt

Overflow on receipt

I think is better to have the seed/Fiat button as a suffixIcon using a MainTextField, we had it like this before to avoid the button going out of the text layout.

I think is better to have the seed/Fiat button as a suffixIcon using a MainTextField, we had it like this before to avoid the button going out of the text layout.

For the Receipt feature, I notice that the amount is displayed but we allow users to create products with seeds or fiat, and this information is not being displayed on the receipt. For Example is 27 price from tequila 27 seeds or USD?

Good point it should either show both prices or only the Seeds price on the line items

For the Receipt feature, I notice that the amount is displayed but we allow users to create products with seeds or fiat, and this information is not being displayed on the receipt. For Example is 27 price from tequila 27 seeds or USD?

Good point it should either show both prices or only the Seeds price on the line items

I also notice that when creating a product with 0 price it does't display the 0 price on top is just blank .

I think something else went wrong there - needs steps to reproduce
Zero works fine for me

I also notice that when creating a product with 0 price it does't display the 0 price on top is just blank .

I think something else went wrong there - needs steps to reproduce
Zero works fine for me

Hi Nick, I found some bugs after review your latest commit. There is an error when creating products, if USD value is selected and price set to 1, when adding it created a product with 41,7061 USD instead of 1 USD.
I also notice that when creating a product with 0 price it does't display the 0 price on top is just blank .

Yes product entry and editing was basically broken, storing state from previous edits in the widget... sigh
I fixed these.
This would cause many weird bugs when editing or adding new products.
Fix was to do this different and get rid of global state.
So for all bugs adding new product and editing existing, please retry.

Hi Nick, I found some bugs after review your latest commit. There is an error when creating products, if USD value is selected and price set to 1, when adding it created a product with 41,7061 USD instead of 1 USD.
I also notice that when creating a product with 0 price it does't display the 0 price on top is just blank .

Yes product entry and editing was basically broken, storing state from previous edits in the widget... sigh
I fixed these.
This would cause many weird bugs when editing or adding new products.
Fix was to do this different and get rid of global state.
So for all bugs adding new product and editing existing, please retry.

For the Receipt feature, I notice that the amount is displayed but we allow users to create products with seeds or fiat, and this information is not being displayed on the receipt. For Example is 27 price from tequila 27 seeds or USD?

Good point it should either show both prices or only the Seeds price on the line items

All items are in SEEDS
I guess we could make that more obvious but it's not a bug per se. The price displayed is always the price converted to SEEDS.
I don't want to spend too much time on this UX since we will redesign the whole thing anyway.

For the Receipt feature, I notice that the amount is displayed but we allow users to create products with seeds or fiat, and this information is not being displayed on the receipt. For Example is 27 price from tequila 27 seeds or USD?

Good point it should either show both prices or only the Seeds price on the line items

All items are in SEEDS
I guess we could make that more obvious but it's not a bug per se. The price displayed is always the price converted to SEEDS.
I don't want to spend too much time on this UX since we will redesign the whole thing anyway.

@gguijarro-c-chwy lost the bet, there were some bugs in editing and adding new products, which I had not tested properly, wrongly assumed that that was initially working when it actually wasn't. Messy.
@gguij004 Fixed product entry bug, others aren't bugs and we want to ship this as a sort of alpha feature anyway.

@gguijarro-c-chwy lost the bet, there were some bugs in editing and adding new products, which I had not tested properly, wrongly assumed that that was initially working when it actually wasn't. Messy.
@gguij004 Fixed product entry bug, others aren't bugs and we want to ship this as a sort of alpha feature anyway.

Can't get overflow to happen
![image](https://user-image@gguij004 ithubusercontent.com/65412/105316174-7a32ca80-5bfb-11eb-9fbe-fd9fb26c3dfd.jpeg)
@gguij004

Can't get overflow to happen
![image](https://user-image@gguij004 ithubusercontent.com/65412/105316174-7a32ca80-5bfb-11eb-9fbe-fd9fb26c3dfd.jpeg)
@gguij004

"Receive" is not displayed in the middle for all devices

It does not need to be. For IOs devices is usually centered and for android devices is closer to the back arrow

"Receive" is not displayed in the middle for all devices

It does not need to be. For IOs devices is usually centered and for android devices is closer to the back arrow

Bugs

Fixed

Bugs

Fixed

Maybe "edit Products " instead of "edit" by itself?

Maybe "edit Products " instead of "edit" by itself?

I think product should have a label like before? like "Price" not sure if we are taking the label out.

we dont need label?

I think product should have a label like before? like "Price" not sure if we are taking the label out.

we dont need label?

We allow users to create negative products.
not sure what will happen on this example.
Maybe we can let then create negative products to use as discounts,
but if the total in receipt is negative they should not be able to click next, Please advise. Thanks

We allow users to create negative products.
not sure what will happen on this example.
Maybe we can let then create negative products to use as discounts,
but if the total in receipt is negative they should not be able to click next, Please advise. Thanks

We allow users to create negative products.
not sure what will happen on this example.
Maybe we can let then create negative products to use as discounts,
but if the total in receipt is negative they should not be able to click next, Please advise. Thanks

Yeah, this is no bueno.

We allow users to create negative products.
not sure what will happen on this example.
Maybe we can let then create negative products to use as discounts,
but if the total in receipt is negative they should not be able to click next, Please advise. Thanks

Yeah, this is no bueno.

Negative is no good yes...

Negative is no good yes...

Maybe "edit Products " instead of "edit" by itself?

No... edit is standard. Also would be too long for a button.

Maybe "edit Products " instead of "edit" by itself?

No... edit is standard. Also would be too long for a button.

I think product should have a label like before? like "Price" not sure if we are taking the label out.
w

we dont need label?

Added hint text ... please consider this is an alpha feature we just want to enable people to start using it
There will be a redesign

I think product should have a label like before? like "Price" not sure if we are taking the label out.
w

we dont need label?

Added hint text ... please consider this is an alpha feature we just want to enable people to start using it
There will be a redesign

weird, this did not happen on previous commits, please double check validation

Fixed

weird, this did not happen on previous commits, please double check validation

Fixed

Small devices - changed layout
We can either remove the image, or make the text smaller

Small devices - changed layout
We can either remove the image, or make the text smaller

Fixed negative entry - not allowed
This happened because I refactored the amount field to be dual currency, to only have 1 implementation, and to be used everywhere, in transfer and also in entry here.
So overall - my bad for not testing it properly, but not wasted time to get this right.
Thanks for finding all these!

Fixed negative entry - not allowed
This happened because I refactored the amount field to be dual currency, to only have 1 implementation, and to be used everywhere, in transfer and also in entry here.
So overall - my bad for not testing it properly, but not wasted time to get this right.
Thanks for finding all these!

still broken for small device. not sure if we should looking into it since we are going to redesign feature.

still broken for small device. not sure if we should looking into it since we are going to redesign feature.

bug on validation

Fixed

bug on validation

Fixed

still broken for small device. not sure if we should looking into it since we are going to redesign feature.

Ok then, no pix on small devices ;)
Fixed

still broken for small device. not sure if we should looking into it since we are going to redesign feature.

Ok then, no pix on small devices ;)
Fixed

Ummm whoa that's not a scroll view! Well - thanks!

Ummm whoa that's not a scroll view! Well - thanks!


Preserve case of file during auto indent

First and foremost, thanks for the awesome extension, man! Auto-import saves me 5-10 headaches a day. 😉
Anywho.
Believe it or not, require.js has a bug where it treats "myFile" and "myfile" as two separate imports. Crazy? Yes. Terrible? Yes. BUT, we deal with it! 😉
It would be really nice if the auto imports from TypeScript Hero would preserve the casing of the file, rather than lowercasing them! Then I wouldn't run into this terrible require.js bug. 😛

Hey @johnfn
Thanks for your words!
That's a pretty strange behaviour.. do you use namespaces in files? or does auto organize cause the lowerspace filenames?
Cheers

My mistake - I think this was a bug in VSCode rather than your plugin!


Should some functions be moved to processing

Should adjust_fcst_for_crps and crps_cdf_brier_decomposition be moved into processing.cdf?
Alternatively, should they be removed from the probability namespace?
Not sure, just asking.

Probably yes move adjust_fcst_for_crps to scores.processing.cdf
No keep crps_cdf_brier_decomposition - it's returning a bunch of Brier scores

After looking at the implementation and the other things it references, adjust_fcst_for_crps is fine where it is. Closing this issue, we can reconsider later if it's a problem.

Reopening as I think adjust_fcst_for_crps should be moved. The reasoning is that it's a preprocessing tool like the other tools in scores.processing.cdf rather than a score.
I'll try and do the work to move this.

Actually after looking into this further, it's not clear cut where this should go. For this reason I'll just err on the side of just keeping it where it is for now and we can focus on other things


Processing Images Using pose_world_landmarks in MediaPipe to Extract 3D Coordinates and Map Them to Unity

I am currently working on a project where I need to process images to extract 3D coordinates of a human pose using MediaPipe's pose_world_landmarks function. I would appreciate guidance on the following:
Is it possible to extract the 3D coordinates from images using pose_world_landmarks in MediaPipe? If so, could you please provide any examples or references on how to do this?
Once the 3D coordinates are extracted, what is the recommended method to map these coordinates to Unity for further use? Are there any specific transformations or tools I should be aware of when integrating this data into Unity?

Hi @Omaryehya21,
MediaPipe does not offer any official support/library/module for mapping the pose landmarks to Unity as such. However,
there are plugin from the community is quite up-to-date which might help in this context But We don't have a plan to support Unity yet and does not provide support in how to use them.
Thank you!!

Hi @kuaashish,
I greatly appreciate you taking the time to share this information. I am aware of the existing plugin; however, I have decided not to utilize it, as my project is focused on mobile devices. To ensure optimal performance and minimize the computational load on these devices, I am implementing MediaPipe on a server instead.

Hi @Omaryehya21,
Thank you for providing additional details. Currently, we do not have plans to support Unity in the near future. Due to limited bandwidth, we believe we may not be able to assist with this at the moment. However, Please allow us some time to confirm with our team, and we will let you know if there is anything further we can assist with.


Fix: #1083. Enable customizing the ZALLY_API_URL via docker-compose.

This PR
Simplifies running zally on a docker machine and/or for development purposes
enabling the following command
ZALLY_API_URL=http://<IP_ADDRESS>:8000 docker-compose up

Note
The basic workflow remains unchanged.

👍

:+1:


Should we add heat delivered by P2H in industry to the respective final demand charts?

I've created a scenario with a lot of excess electricity and converted most of it to heat in industry, but haven't done anything about the industrial sectors themselves. This leads to the changes in the final demand of the sector shown below. Although the calculation is entirely correct, the chart feels counterintuitive. So the question is if we should show the electricity used for P2H like we do for P2G in the fertilizers industry. The only problem with doing this is that this electricity is not considered final demand (I guess).
How do you feel about this, @AlexanderWirtz , @ChaelKruip , @DorinevanderVlies and @MichielDenHaan ?

The only problem with doing this is that this electricity is not considered final demand (I guess).

That is indeed why we did not add the electricity used for P2H to this chart.
Although it can also be argued that the electricity does reach the industries and is used there, so in some way it can be considered as final demand.

If the electricity is used to create heat, how is that not final demand? Or is this heat fed into a heat network? The chart seems to show both a decrease in gas use (which would imply final demand) and in heat use (which is itself final demand, but the electricity used to produce it is not.
My point is that electric heaters in homes are final demand, so why is this not the case in industry.

My point is that electric heaters in homes are final demand, so why is this not the case in industry.

A similar issue runs for electric heaters in households that are powered with excess electricity options: https://github.com/quintel/etmodel/issues/2528. They are currently not counted as final demand. Is that correct @ChaelKruip ?
I remember @ChaelKruip and me had a discussion about this chart and that we decided that energy used by P2H technologies should not be shown in this chart as it is not final demand. @ChaelKruip do you remember why we decided this is not final demand?

@ChaelKruip do you remember why we decided this is not final demand?

I think there were several reasons (some of which already mentioned above):

We don't show electricity for P2H in households (but we could I suppose)
I don't know if the heat for Industry will be made 'inside the sector' so if we should count the heat or the electricity used to create the heat as final demand
Technically, it is a bit tricky because the P2H nodes have no electricity demand (that is all taken care of inside Merit):
.
@antw is it difficult/desirable to add the input carrier and demand for P2H, P2P and P2G nodes?

This issue was brought up by one of our clients. My gut feeling would be to show the electricity as final demand. We should do this as well then for P2H in households, P2P etc. Notifying @AlexanderWirtz, @ChaelKruip, @marliekeverweij.

is it difficult/desirable to add the input carrier and demand for P2H, P2P and P2G nodes?

I think this has been fixed already, all flexibility options are now connected to the energy_production_excess_electricity node. So it should be relatively straightforward to include use of excess electricity in the industry demand charts.

I think it's a good idea to show the excess electricity used for P2H as final demand. However, I think we should then be consistent in all final demand charts, so for example also show electricity used for P2H in the final demand mekko. As the final demand mekko shows all energy in the final-demand-nodes it will be kind of ugly to separately add P2H-electricity.

My gut feeling would be to show the electricity as final demand. We should do this as well then for P2H in households, P2P etc. Notifying @AlexanderWirtz, @ChaelKruip, @marliekeverweij.

Do we count hydrogen produced by dedicated offshore wind to be primary? I would suggest to be consistent with the choice made there... So, if we do, count the heat as primary carrier (and also final carrier).

No electricity is primary for dedicated wind/solar PV

No electricity is primary for dedicated wind/solar PV

I think we should count the electricity as final then. @AlexanderWirtz probably has a more authoritative opinion on this though...

I think we should count the electricity as final then. @AlexanderWirtz probably has a more authoritative opinion on this though...

I am not sure it is more authoritative.  Of course, the heat might be generated by the energy sector (some kind of joint venture who owns the heater for P2H) and brought to industrial clients, but it seems more likely that plants invest in electric heaters. In that case, it is final demand in my book.

Closing this as we have a new one :0 https://github.com/quintel/etsource/issues/2494


Flatshading is hacky & can only be decided per-scene rather than per-face

Currently the exporter considers flatshading on a per-scene basis

How about (for now) a per-mesh property for flat/smoothshading? It's better than nothing.

Every polygon has a use_smooth attribute. We should split if this is false and there are shared vertices with differing normals


Create placeholders for sai implementation

Renamed dataplane service because it conflicts with c++ generated code
Create standalone dataplane
From go start gRPC server
From c++ translate sai calls and make gRPC requests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.467%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4115

Relevant Lines:
6191

💛  - Coveralls