Cursor pointer of checkbox not updated in Safari

Version 1.4.10

Test Environment

Mac OS, Safari
Current Behavior

In Safari, when you add checkbox (Task) in WYSIWYG mode, when you move the cursor to the checkbox, the pointer is not changed to "hand" icon. But in Chrome, it will changed to "hand" icon when point to the checkbox
Expected Behavior
Same as Chrome that show "hand" icon when mouse over checkbox.

The task needs to change the cursor style of the CSS pseudo-element.

https://github.com/nhn/tui.editor/blob/11f8ebd6243e214306cccf305fe1c938816c7e05/src/css/tui-editor-contents.css#L239

AS-IS
.tui-editor-contents .task-list-item:before { ... }

TO-BE
.tui-editor-contents .task-list-item { ... }


Inline workers not working in a worker

Expected Behavior / Situation
I have a library that creates an "inline" worker. Normally the library is used from the Window (main browser thread) scope, and things work fine, but now I want to use it from a worker scope. I'd expect the worker that uses the library to create a second "child" inline worker.
Actual Behavior / Situation
An error gets thrown, no child worker gets created. The error is caused by references to window in this file.
Modification Proposal
Replace uses of window in src/runtime/inline.js with self. I've checked that this fixes behaviour for me, but don't know what'd else you might need in terms of testing/validation. Happy to make a PR myself if it would help get this done and released more quickly, but it could slow things down if there are hoops to jump through that I'm not familiar with.

What is webpack version?

The library that creates an inline-worker was built with webpack version 4.41.2 when I saw the issue.
Could building it with a different version help? (Fixing my issue by upgrading deps, or by providing some build-time configuration to make those window references resolve to something else would definitely be fine for me.)

Could building it with a different version help? (Fixing my issue by upgrading deps, or by providing some build-time configuration to make those window references resolve to something else would definitely be fine for me.)

Do you use webpack? Or you try to import library that will be bundled by webpack?

My application imports the library bundled by webpack from inside a worker. The library is built by running webpack. The library uses worker-loader, and it creates inline workers.
I can change either or both of them. I would like to continue using inline workers inside the library if possible.

Yep, let's fix it, just notice - webpack v5 does not require worker-loader

Ah, maybe I should try to build my library with webpack 5, but I think it'd be a bigger job :-).
Should I make a find/replace PR, or would you prefer to fix and release?

Feel free to send a fix and I will publish patch release

Just do (self || window)

Oof, I'm not great at using github -- I ran into a push permission error. I put a patch in a gist you can apply with git am <patch-file> if it helps.

@MatthewSteel You need fork this repo send a PR to fork, when return to this repo and go to PR and send a PR

(Let me know if I've done this wrong. Can make whatever changes needed. Looks like code coverage checks are failing, which I guess could be fixed by inlining the expression everywhere? Dunno.)

Thanks for shepherding this through!

Oh, one more question: This change fixed our issue at an older version, but we have a separate but related issue while upgrading to the latest version: I think the changed externals behaviour might have caused problems for inline workers. I think the blob URLs need to include all of their transitive dependencies.
I'm not 100% sure that's the right diagnosis, and I'm even less sure what the right remedy would be. In the meantime I think the simplest thing for my team to do is to apply the patch from this issue to a private fork before the externals change.

Can you clarify?

My library uses the "externals" webpack configuration so its package deps aren't included in the built bundle -- they're provided by my application.
For non-inline workers, I guess the application's webpack process "links" the generated .worker.js files to their dependencies, but for inline workers I think the linking process doesn't work -- the application's webpack doesn't know how to include the dependencies in the string/blob worker source.
One workaround on my side could be to not mark these deps as externals. But I think a better solution is to ignore "externals" for inline workers.

Hard to understand, maybe you can provide simple reproducible test repo, so I will undestand what do you want achieve


Link to announcement blog post in v1.0.0 on github points to localhost:4000

[x] I'm reporting a bug, not asking for help
[ ] I've looked at the documentation to make sure the behaviour is documented and expected
[ ] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

The release text for v1.0.0 that says 'Read the announcement blog post' links to http://localhost:4000/2016/09/27/leaflet-1.0-final.html
I expect it should point to: http://leafletjs.com/2016/09/27/leaflet-1.0-final.html

Seems like @mourner wrote the release notes a bit too quick. Should be fixed now.


CloudFormation wizard give error

Followed the Readme steps and while creating the stack using US West (Oregon) LaunchStack, it failed with error  "Resource creation cancelled".
Possible Root cause gives below information:
"Properties validation failed for resource BestsellersApiRequestOPTIONS with message: #/AuthorizationType: #: only 1 subschema matches out of 2 #/AuthorizationType: failed validation constraint for keyword [enum]"
What is the reason of this error?

Closing issue as related PR was merged.  Thank you for the contribution!


Bad Actor Management

As the popularity of this tool will continue to increase alongside vtubers/YTlive, more people will begin to abuse and spam commonly used chat filters.
Can you add onclick functionality to each "vc-message-item" so that users can add chatters to whitelists/blacklists on the fly? Would also be great to enable sharing functionality so that well respected community translators can be easily added to user whitelists.

I can see your concerns about spam. I will consider something for that, but I hope it won't have to come to that. Let's try reporting them with Youtube's  built-in system first.
If it's not enough, then perhaps I will add a whitelist function. Whitelisting is easier for people as they just need to pick a finite number of people instead of unlimited number of spammer. It's also easier to vet a whitelist if sharing.
For sharing, I would rather not have to maintain a server for this. For now I can see a solution using Github + Netlify. Adding people to the whitelist would go through an issue or merge request, with a vetting process like providing a timestamped stream where we can see the translation.  Then everything is deployed to CDN thanks to Netlify. Netlify also has some serverless form feature which I could try.
Everything considered, this is a rather large feature to implement. Priority for this feature will depend on the evolution of the communities.

Oh yeah, in hindsight, I can definitely see how a blacklist can grow out of control in size.
With regard to using the Youtube reporting system, the spam could be negligible compared to the chat speed, but overwhelming when compared to translator/filtered speed. It would require the user stopping chat and manually scrolling through tens of messages to find and report the offender.
What would be involved in writing a script to stop scrolling and jump to the specific timestamp of the offending spam message? (presumably using onclick)

What would be involved in writing a script to stop scrolling and jump to the specific timestamp of the offending spam message? (presumably using onclick)

It should be possible, and the user better be fast otherwise the message will get erased from Youtube chat. It does feel like a needed feature.


Persist history

Keeps the last 100 history entries in localStorage
https://github.com/user-attachments/assets/62e54987-0684-4f7b-bb0d-bdcad3470a14

Thanks!

np!


Zookeeper setup is failing with Ansible 2.0

After the upgrade to Ansible 2.0, all references to ansible_ssh_host were replaced with ansible_host.  Unfortunately, inside of hostvars[host] the key is still called ansible_ssh_host.  I've filed a bug with Ansible (https://github.com/ansible/ansible/issues/15286).
Currently, when installing the master version of Apollo using Ansible <IP_ADDRESS>, you will run into this error:
TASK [zookeeper : Create zookeeper config files] *******************************
failed: [apollo-mesos-master-1] => (item={u'dest': u'/etc/zookeeper/conf/zoo.cfg', u'src': u'zoo.cfg.j2'}) => {"failed": true, "item": {"dest": "/etc/zookeeper/conf/zoo.cfg", "src": "zoo.cfg.j2"}, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'ansible_host'"}

I'm surprised not more people have run into this issue.  By the way, I am running Ansible from OS X 10.11.4.

@joe1chen i havent seen this issue and im running the same setup, strange but thanks once again.

Closing this out since it seems like an issue with ansible on localhost.


Creating a secret from an ES fails silently, if namespace+name is too long

Describe the bug
Creating a ExternalSecret whose resulting secret has a label reconcile.external-secrets.io/created-by which value is longer than 63 characters fails silently. Status is set to SecretSynced and ready is set to true, though the secret is not created:
Secret "external-secret-name-with-44-chars-xxxxxxxx" is invalid: metadata.labels: Invalid value: "namespace-with-24-chars_external-secret-name-with-44-chars-xxxxxxxx": must be no more than 63 characters

To Reproduce
Steps to reproduce the behavior:

Create ExternalSecret with name external-secret-name-with-44-chars-xxxxxxxx in namespace namespace-with-24-chars
Status is set to SecretSynced and ready is set to true
Secret is not created

Expected behavior
Status is set to SecretSyncedError and ready is set to false, appropriate error message is emitted
Screenshots
n/a
Additional context
ESO version: 0.9.3
I know that we're not using the newest version, but the code that seems to be responsible did not change between the versions:
https://github.com/external-secrets/external-secrets/blob/c5d647bae1d3bbebb2f0d9c1ab1e3e3cbe869875/pkg/controllers/externalsecret/externalsecret_controller.go#L291-L294

Was already reported in #2616 and fixed in #2645. So my statement

but the code that seems to be responsible did not change between the versions

is nonsense. Sorry for the noise.


AWS secrets don't seem to be used for ACME validation

I'm trying to get voyager to get a certificate from let's encrypt.  I've created a secret containing AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY and I've created a voyager certificate TPR referencing that secret.
The voyager operator logs show it failing to make the call to route 53, and the error message indicates it is using the identity provided to the EC2 host the pod is running on, rather than the expected identity associated with the access key mentioned above.
I0922 22:03:44.692800       1 controller.go:225] trying to retrive acmeUser data
I0922 22:03:44.696485       1 controller.go:252] ACMEUserInfo data found is secretacme-jenkins2-cert
I0922 22:03:44.764078       1 logs.go:19] [INFO][jenkins2.x.io] acme: Obtaining bundled SAN certificate
I0922 22:03:45.309837       1 logs.go:19] [INFO][jenkins2.x.io] AuthURL: https://acme-v01.api.letsencrypt.org/acme/authz/xxx...
I0922 22:03:45.309869       1 logs.go:19] [INFO][jenkins2.x.io] acme: Could not find solver for: tls-sni-01
I0922 22:03:45.309877       1 logs.go:19] [INFO][jenkins2.x.io] acme: Could not find solver for: http-01
I0922 22:03:45.309884       1 logs.go:19] [INFO][jenkins2.x.io] acme: Trying to solve DNS-01
I0922 22:03:45.685164       1 controller.go:183] Error occurred for jenkins2.x.io, reason Error presenting token: Failed to determine Route 53 hosted zone ID: AccessDenied: User: arn:aws:sts::111111111111:assumed-role/kube24-Nodepool1-U5VAGNWC1MHX-IAMRoleWorker-EG19YHC6EJ7S/i-01d5e28d360712cfc is not authorized to perform: route53:ListHostedZonesByName
        status code: 403, request id: e72fd92f-9fe1-11e7-a9be-2bd1577fb68c

#506 should fix this issue.


Fixes for microphone example on Windows

These changes should resolve #6.
They include:

a port of https://github.com/hathach/tinyusb/pull/1058

bumping CFG_TUD_AUDIO_EP_SZ_IN by one, as per the comment in: https://github.com/hathach/tinyusb/blob/2eaf99e0aa9c10d62dd8d0a4e765f5941bfeaf98/examples/device/audio_4_channel_mic/src/tusb_config.h#L104

// 48 Samples (48 kHz) x 2 Bytes/Sample x CFG_TUD_AUDIO_N_CHANNELS_TX Channels
// - the Windows driver always needs an extra sample per channel of space more, otherwise it complains... found by trial and error

So far, I've tested on a Windows 10 VM and macOS - they seem ok.  @iovsiann it would be great if you can test these changes on Windows and Linux and report your feedback.

@sandeepmistry,
I have checked it, it works both on my Windows laptop (Skype, Audacity) and Ubuntu desktop (Audacity).
Many thanks for the fix!

@iovsiann awesome, thank you for trying the change and the feedback!
I'll go ahead and merge these changes now.


New version: Catsxp.Catsxp version <IP_ADDRESS>

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

/azp run


Open MTP suddenly extremely slow in transfering files (Was very fast before)(MacM1)

Prerequisites
If the following boxes are not ALL checked, your issue is likely to be closed.

[x ] Using yarn
[x ] Using node 10.x
[x ] Using an up-to-date master branch
[x ] Using latest version of devtools. See wiki for howto update
[x ] For issue in production release, devtools output of DEBUG_PROD=true yarn build && yarn start
[ x] Tried solutions mentioned in #400

Describe the bug
Like in title, 2020 mac m1 air. Downloaded openMTP and was working great for weeks.. Today transfering some mp3s and it is slower than passing them via bluetooth. I tried several different cables, and cannot think of any reason why. It just became painfully slow.. Freezing after 9min transfering 350mb of mp3s
Expected behaviour
Was a lot faster befoew
Current Behavior
Its insanely slow
Possible Solution
Not obligatory, but suggest a fix/reason for the bug or ideas how to implement the addition or change.
Steps to Reproduce (for bugs)
Provide a link to a live example or an unambiguous set of steps to reproduce this bug. Include code to reproduce, if relevant

Context
How has this issue affected you? What are you trying to accomplish?
Did you make any changes to the codes after cloning it?
Providing context helps us come up with a solution that is most useful in the real world.
Your Environment
Latest Mac OS

Node version :
Version or Branch used :
Operating System and version [e.g. macOS 10.14 mojave]:
App Version [e.g. OpenMTP-v1.0]:
Link to your project :

Attachments
Include if relevant,

Open your Terminal and run the following code:

zip -r -X ~/Desktop/OpenMTP-log.zip "$HOME/Library/Application Support/io.ganeshrvel.openmtp/logs/"

Attach the file OpenMTP-log.zip found in your Desktop folder here.

Or

Open the App,
Click on Help > Report Bugs.
Generate and send us the bugs report.

Screenshots
If applicable, add screenshots to help explain your problem.

What is the OpenMTP version you are facing this issue?

The M1 support is still in it's alpha stage and i am working on it.
You can find the alpha version of m1 here.
https://github.com/ganeshrvel/openmtp/issues/244#issuecomment-1050234082

i just downloaded the newest version myself and copying 7000 files from my pixel 5 to my mac was fast, very fast, but now i am trying to copy them back and it is INCREDIBLY slow. this will take days? what is happening?

This project hasn't been updated in a year. The file transfer is not working right.
I just figured I would use the terminal with adb and it works so fast!
If anyone is reading this, to copy a folder to your android from a mac and PRESERVE DATES (which is so important when copying images or your gallery will be screwed up), turn on ADB (in developer options, "USB debugging") then open the terminal on your mac and type this:
cd
then
./adb push -p
for me it was like this line:
./adb push -p /Users/HOME/Android/Phone\ Backup/com.whatsapp/WhatsApp/Media /sdcard/Android/media/com.whatsapp/WhatsApp/Media

Folks,
I am reading your comments. My work has been keeping me busy and now I am looking for a new one. The apple silicone support is almost there, I need to figure out a few things. Let me assure you that the project isn't dead and hopefully there will be a new pre-release pretty soon.
Regards

Folks, I am trying to figure this issue out. I will make the beta release for Apple silicone soon and hopefully this should get sorted as well.

What OpenMTP, Android and macOS are you people on?
Please download these OpenMTP versions and let me know whether the file transfer speed is slow on all of them
a) OpenMTP-3.1.0.dmg
b) OpenMTP-3.0.0.dmg
c) OpenMTP-2.4.4.dmg
d) Apple Silicone: OpenMTP.app.zip

Also please note MTP protocol in itself is a crappy implementation. The file transfer speed tends to get slower after a period of phone usage.

@landry314 I am aware of the Dates and the other metadata preservation issue. I am looking into it as well.

the date problem is also in android file manager which is why i need to use push for most folders. quite surprised google coded mtp so badly.

Arrived to this thread via Google, was really surprised just like @landry314 when I had quite fast speed of loading of my photos from my S23 Ultra to my M1 Pro Mac, but when I'm trying to load something back, it's incredibly slow, so 10 months passed passed and this still wasn't fixed as it seems? :(
It took Open MTP almost two minutes to transfer 8 Mb worth of photos to my Android... I just can't understand why would it load it with a speed like that...

And what about metadata preservation? It's the main reason I'm trying to transfer some photos from my old iPhone to correctly transfer dates from exif's.

this app is slow and deletes metadata. there are other better ones or just use push and pull commands in terminal with adb

this app is slow and deletes metadata. there are other better ones or just use push and pull commands in terminal with adb

this app is slow and deletes metadata. there are other better ones or just use push and pull commands in terminal with adb

Which do you use?

@landry314 which apps are you talking about in your comment?
@ganeshrvel is it really still not fixed after months and months?... :)

honestly, all the apps dont work right.
i just use adb push and pull now. it is fast and with the right flags it preserves dates...
in a terminal...
cd to YOUR platform-tools directory
./adb push 'SOURCE FOLDER ON COMPUTER' 'DESTINATION FOLDER ON ANDROID'
to use pull dont forget the -a flag to preserve dates.
./adb pull -a 'SOURCE FOLDER ON ANDROID' 'DESTINATION FOLDER ON COMPUTER'

thanks! But as I understand, adb push (and I need to transfer photos from Mac to Android) do not preserve metadata, there is no -a flag for adb push. Did you figure out the way to preserve dates when moving data TO Android, not from it? :)

Hello everyone,
I'm planning a lightweight and modern rewrite of the app in the near future. This will be a complete GUI app overhaul from the ground up. In the meantime, I'll attempt to find a solution for this issue.

thanks! But as I understand, adb push (and I need to transfer photos from Mac to Android) do not preserve metadata, there is no -a flag for adb push. Did you figure out the way to preserve dates when moving data TO Android, not from it? :)

i just read online to use this:
adb push --sync
anyone have luck?


Adds allowFontScaling to TextField and it's FloatingLabel

Font scaling is when the user changes the global device font size/scale. Standard for Text and TextInput are true (they will scale the font size according to the device setting). This pull request adds an option to disable it on TextFields (automatically does it on it's FloatingLabel too) .

Thank you for the PR!


acpi: parse the FADT system description table

Summary
Parse and build a structure with the info in the FADT found in the RSDT. See section 5.2.9 in ACPI and the relevant OSDev wiki page FADT.

I could start looking at this

I'll tackle this.


BUG: Broken references silently failing using client.batch (v4)

It is great that references can be added to objects created within the same batch.
However, failed references should be listed in client.batch.failed_references.
repro:
import weaviate
import weaviate.classes as wvc
import weaviate.util
from tqdm import tqdm
from weaviate.util import generate_uuid5

print("Weaviate version:", weaviate.__version__)

with weaviate.connect_to_local() as client:
  print(client.get_meta())

  client.collections.delete(["A", "B"])
  client.collections.create("A")
  client.collections.create("B")

  a_collection = client.collections.get("A")
  b_collection = client.collections.get("B")

  a_collection.config.add_property(wvc.config.Property(name="a_name", data_type=wvc.config.DataType.TEXT))
  a_collection.config.add_reference(wvc.config.ReferenceProperty(name="b_ref", target_collection="B"))

  b_collection.config.add_property(wvc.config.Property(name="b_name", data_type=wvc.config.DataType.TEXT))
  b_collection.config.add_reference(wvc.config.ReferenceProperty(name="a_ref", target_collection="A"))

  print({
    "A": a_collection.aggregate.over_all(),
    "B": b_collection.aggregate.over_all()
  })
  print("-" * 80)

client.close()

with  weaviate.connect_to_local() as client:
  with client.batch.dynamic() as batch:
      for i in tqdm(range(5000)):
        a_uuid = generate_uuid5(str(i), "A")
        b_uuid = generate_uuid5(str(i), "B")
        inexistent_uuid = generate_uuid5(str(i), "inexistent")

        batch.add_object(properties={"a_name": "test"}, collection="A", uuid=a_uuid)
        batch.add_object(properties={"b_name": "test"}, collection="B", uuid=b_uuid)

        batch.add_reference(from_uuid=b_uuid, from_collection="B" ,from_property="a_ref", to=a_uuid)
        batch.add_reference(from_uuid=a_uuid, from_collection="A" ,from_property="b_ref", to=inexistent_uuid)

  print(">>> Done inserting objects")
  if client.batch.failed_objects:
    print("Failed objects:", client.batch.failed_objects[:10])
  else:
    print("No failed objects")

  if client.batch.failed_references:
    print("Failed references:", client.batch.failed_references[:10])
  else:
    print("No failed references")

# double check all B objects have a reference to an A object
with weaviate.connect_to_local() as client:
  b_collection = client.collections.get("B")
  for b_obj in b_collection.iterator(return_references=[wvc.query.QueryReference(link_on="a_ref")]):
    assert len(b_obj.references) == 1
  print(">>> All B objects have a reference to an A object")

  a_collection = client.collections.get("A")
  for a_obj in a_collection.iterator(return_references=[wvc.query.QueryReference(link_on="b_ref")]):
    assert len(a_obj.references) == 0
  print(">>> All A objects have no references")

with weaviate.connect_to_local() as client:
  a_collection = client.collections.get("A")
  b_collection = client.collections.get("B")
  print("-" * 80)
  print({
    "A": a_collection.aggregate.over_all(),
    "B": b_collection.aggregate.over_all()
  })

Output:
Weaviate version: 4.5.5
{'hostname': 'http://<IP_ADDRESS>:8080/', 'modules': {}, 'version': '1.23.7'}
{'A': AggregateReturn(properties={}, total_count=0), 'B': AggregateReturn(properties={}, total_count=0)}
--------------------------------------------------------------------------------
100%|██████████| 5000/5000 [00:01<00:00, 2547.51it/s]
>>> Done inserting objects
No failed objects
No failed references
>>> All B objects have a reference to an A object
>>> All A objects have no references
--------------------------------------------------------------------------------
{'A': AggregateReturn(properties={}, total_count=5000), 'B': AggregateReturn(properties={}, total_count=5000)}

Hi @glesperance, this one is actually a quirk of Weaviate's core logic when it comes to adding references. The design decision was made that adding a reference (edge) to/from an object (node) that doesn't exist is not an actual error but instead simply fails
If you feel this is unexpected behaviour and that the references should error if referring to non-existent objects then I encourage you to open a PR on the Weaviate core repo!

Will close this as there is nothing we can do on the client side, but please open an issue in the weaviate repo if you expect a different behaviour
we gurantee that references to objects that have been added to the batch before the reference are properly resolved. So if you do
with collection.batch.whatever() as batch:
   batch.add_object(uuid1)
   batch.add_object(uuid2)
   batch.add_reference(from=uuid1, to=uuid2)

the reference will only be added after both objects have been succesfully ingested by weaviate


ValueError: Cannot feed value of shape (8, 218) for Tensor u'input_1:0', which has shape '(100, 218)'

My train data is 150808X218 and test data 41016X218.Both are formatted as numpy.ndarray
I am running this script https://github.com/fchollet/keras/blob/master/examples/variational_autoencoder.py. Notice that the train and test is 60000 and 10000 in this script. batch_size = 100
However, when running my own data,
vae.fit(x_train,
shuffle=True,
epochs=epochs,
batch_size=batch_size,
validation_data=(x_test, x_test))
complains
ValueError: Cannot feed value of shape (8, 218) for Tensor u'input_1:0', which has shape '(100, 218)'
I think it is because 150808= 1508 * 100 + 8
When I changing batch size to a prime factor of 150808 such as 2693, it would complain the test data as 2693 is not a factor of 41016.
I tried batch size = 8 and it worked. Given my data size can vary for different datasets, any fix to this bug? Thanks!

any insights?

In my view, you have to feed data size in multiple of batch_size. As you have different datasets with different values you can make one function which returns a value which divides dataset evenly and supply that value as batch_size.


[benchmark] update device information print message

Change-Id: Ibc47727ebc3dd729a0031362867430efd83f330e
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1184 (4e54f92) into master (53246c5) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1184      +/-   ##
============================================
- Coverage     70.23%   70.19%   -0.04%
+ Complexity     4968     4966       -2
============================================
  Files           476      476
  Lines         21952    21953       +1
  Branches       2318     2319       +1
============================================
- Hits          15418    15410       -8
- Misses         5327     5335       +8
- Partials       1207     1208       +1

Impacted Files
Coverage Δ

.../main/java/ai/djl/benchmark/AbstractBenchmark.java
91.07% <100.00%> (+0.05%)
:arrow_up:

api/src/main/java/ai/djl/repository/Artifact.java
86.17% <0.00%> (-3.26%)
:arrow_down:

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
:arrow_down:

api/src/main/java/ai/djl/util/Platform.java
42.30% <0.00%> (-1.93%)
:arrow_down:

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
40.00% <0.00%> (-1.18%)
:arrow_down:

...ain/java/ai/djl/tensorflow/engine/TfNDManager.java
87.50% <0.00%> (-0.79%)
:arrow_down:

.../djl/training/listener/MemoryTrainingListener.java
76.62% <0.00%> (ø)

...rc/main/java/ai/djl/paddlepaddle/jni/LibUtils.java
48.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53246c5...4e54f92. Read the comment docs.


Add min size option in lbg_input_password()

Add an option to force password to put at least n characters

Was done in commit 93eef4361b4200969f225e324bc2defa7d103480


Refactor contrib/broker/k8s to grpc --> tiller

Currently the helm reifier execs to the helm binary to get the job done. @martinmaly and I discussed a bit and agreed it wasn't ideal. Tiller uses GRPC, so that presents an easy(ish), low-friction option for improving that integration.

And I'm not at all volunteering @arschles for this, but he has implemented this previously in Steward. We've since removed our helm reifier entirely, but whoever takes this issue on might consider tapping @arschles for some insight or even a link to relevant commits in case it spares anyone from re-inventing the wheel.

Happy to point to commits & the relevant bits in the helm repo. May be able to take this on at some point.

It would be great if there was also some version leniency. As things are now, the helm client in the k8s broker must perfectly match version of the tiller running in the cluster. This will become an adoption obstacle in that catalog + k8s broker can only run in clusters where customers happens to have just the right version of tiller.
I do hope that the gRPC access to Tiller would get us some flexibility that helm client doesn't allow.

Closing, as the helm reifier is now largely removed from this repository


setContext not working?

Describe the bug
I've built a synthesizer web app and I'd like to adjust latency (to avoid unwanted audio crackling).
I'm trying to do this by following the example in the documentation here:
https://tonejs.github.io/docs/14.8.36/Context#latencyHint
But the second line: "Tone.setContext(context);" appears to have no effect.
This block of code:
const context = new Tone.Context({
latencyHint : 0.01
})
Tone.setContext(context);
console.log(Tone.context.latencyHint);
Logs the default value "Interactive" to the console (instead of the 10ms value I was aiming for). I tried a larger latency value to make sure, but it is not applied to the audio.
To Reproduce
My complete code is at: https://codepen.io/cz-chrome/pen/PoyPBML, this bit is on line 40-44 of the JS page.
Expected behavior
I would expect this code to change the context to the new context I created and therefore the value of 'latencyHint' to be updated to the one set in the new context.
What I've tried
I've tried many things to get rid of the audio crackling (it's very intermittent now). Adding a bit of latency seemed like a good idea, If there is another way of doing this I would be interested in that as well but based on the documentation this seemed to me to be the 'proper' way.
Additional context
The app I built is mostly working very well. The audio crackling that I still get is intermittent and doesn't happen on all devices. I also tried a lot of things that may reduce CPU load like reducing polyphony, removing effects, scheduling note ons with transport, et cetera. None of these things have had any effect. Also the crackling is not happening on some slower/older devices I tried but it is happening on my new and pretty fast pixel phone. The crackling/distortion I do still get sounds similar to what happens in a DAW with the buffer size set too small, (happening even when CPU load is not very high), that's what got me thinking about adding some latency.

Couple things, first off Tone.context will always refer to Tone's original default context that it creates when the library initializes (pretty sure it's an undocumented property for internal use). Tone.getContext() returns the most recently set context. You can also access the context of individual Tone audio nodes via their context property e.g. voice1.context.
Secondly, you're setting your new context after you create your audio nodes. This means all of your synths are being created using the original default context, which is why they reflect that default latencyHint. Setting a new context doesn't automatically change all previously created nodes. You would need to instantiate all of your Tone.js objects after setting the new context, then they will use the context with the desired latencyHint.
I'm not sure how well numeric latencyHint values are obeyed across browsers/platforms though so it might be best to stick with the string values. Within Tone.js you can also tweak the lookAhead.

Thanks! I was able to reduce the crackling by adjusting context.lookAhead. I'm still trying to wrap my head around the concepts behind these contexts, but your reply definitely helps. I guess this is not a bug then so will close the issue. I do feel that the documentation I referenced (https://tonejs.github.io/docs/14.8.36/Context#latencyHint) is rather confusing in this regard, but that may well be due to my lack of understanding.
By the way, although I was able to reduce the crackling quite a bit by setting a 12ms lookAhead, it doesn't eliminate it entirely. If you have any other suggestions on how I could improve the performance, that would be highly appreciated!

Web audio supports using multiple contexts at once, for example to output to multiple devices simultaneously, or use a mix of online and offline contexts, and Tone.js supports use of multiple contexts, but it's up to the dev to manage this. latencyHint and sampleRate are the best variables to tweak for performance so I would encourage experimentation there, just make sure your Tone.js objects are instantiated using your new context not the default one. Lowering the sampleRate can do wonders for performance at the expense of quality, though it's not supported in all platforms.


Turn off Auto Rename but plugin still auto-renames all pasted images

as in the title. The plugin renamed all pasted images even though I have turned the Auto rename feature off.

@nhan000
Sorry, recently too busy, really do not have time, I need to wait for the completion of the project in hand, in order to fix the bug

#6
Hi I tried to fix the issue.
@musug please try to compile, I only made the changes directly in the main.js of the installed plugin.
Best regards

#6 嗨，我试图解决这个问题。 @musug请尝试编译，我只直接在已安装插件的主.js中进行了更改。 此致敬意

#6 Hi I tried to fix the issue. @musug please try to compile, I only made the changes directly in the main.js of the installed plugin. Best regards
Thank you for your modification. A new version has been released to fix the bug


network-manager: use ping/ping6 from the nix store

Things done:

[X] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

More
Fixes issue #14103 and #14155
NM upstream has a hardcoded path to /usr/bin/ping. One alternative is to replace that with a link to the suid wrapper for ping/ping6, but that breaks !NixOS. @abbradar excellent suggestion was to use the unwrapped version from the nix store as networkmanager runs as root anyway.
This patch changes:

ping/ping6 are now used from the nix store
we no longer try to make substitutions on a missing file
we use file from the nix store instead of /usr/bin/file in the configure script

I've noticed from Travis, that this triggers a MASSIVE rebuild exercise, which takes too long for Travis to complete. Am I doing something wrong?

A separate PR makes sense to me

You can make a separate PR which we can merge simultaneously with this to ease Hydra load.

Should we use ping instead of hardcoding it? If I understand correctly ping won't work without setuid since it uses port under 1024?

I think using ping will require patching more (i.e. using other exec call which uses environment); I like this options less (more invasive), although this is possible.
ping indeed wouldn't work as non-root because it uses raw packets AFAIR, but the idea is that network-manager already runs and exec's ping as root, and so ping would have root rights.

Going to merge this in few days if noone beats me -- we should also port this to stable, I think.

@abbradar you probably also want #14421 to avoid 2 massive rebuilds instead of 1.


Allow tests running concurrently

The PR allows tests running concurrently and fixes some issued during concurrent running

Codecov Report

Merging #267 (e51eedf) into master (18d5dfc) will decrease coverage by 0.39%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
- Coverage     94.37%   93.97%   -0.40%
+ Complexity     1883     1877       -6
============================================
  Files           195      195
  Lines          3819     3819
  Branches        391      391
============================================
- Hits           3604     3589      -15
- Misses          115      130      +15
  Partials        100      100

Impacted Files
Coverage Δ

src/main/java/net/datafaker/Hearthstone.java
83.33% <0.00%> (-16.67%)
:arrow_down:

src/main/java/net/datafaker/service/FakerIDN.java
63.63% <0.00%> (-9.10%)
:arrow_down:

src/main/java/net/datafaker/Lorem.java
83.33% <0.00%> (-6.25%)
:arrow_down:

src/main/java/net/datafaker/Barcode.java
92.30% <0.00%> (-5.13%)
:arrow_down:

src/main/java/net/datafaker/Commerce.java
92.00% <0.00%> (-4.00%)
:arrow_down:

...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java
92.59% <0.00%> (-3.71%)
:arrow_down:

src/main/java/net/datafaker/Code.java
95.40% <0.00%> (-2.30%)
:arrow_down:

.../java/net/datafaker/service/FakeValuesService.java
87.72% <0.00%> (-0.41%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[v2.1.4] ErrorException array_reverse() by migrate:refresh ...

After #85 & upgrade to 'v2.1.4'
php artisan module:migrate:refresh

[ErrorException]
array_reverse() expects parameter 1 to be array, object given

Sorry about that - I need to strap down and write unit tests to keep these issues from popping up.
v2.1.5 contains the patch for this issue~


Teach serializer functions to write to persistent storage

The serializer functions under tiled/structures/*.py create an in-memory buffer and return (or, after https://github.com/bluesky/tiled/issues/70, maybe yield) bytes. For async transcoding, they need to learn how to (optionally) write to persistent storage instead. Here is one way we could do this:
def serialize_csv(df, metadata):
    ...

becomes
def serialize_csv(df, metadata, file=None):
    if file is None:
        # current behavior, returns bytes for an immediate HTTP response
    else:
        # writes bytes into file, potentially in chunks
        # so that the entire dataset is never in RAM at once
        file.write(...)

As a performance optimization, the file should also be allowed to be a filepath because some writers (like h5py) can go faster if they can pass a filepath down to the C layer rather than working with a buffer in the Python layer. I have a gut feeling we should also accept writeable buffers for file but I am having trouble specifically articulating why.
However, #70 complicates this because the serializers are allowed to sometimes be generators. Let's wait on #70 and revisit.

To finish putting my thoughts on paper here:
Making these serializer functions play two different roles (return/yield bytes vs write bytes into file) is not my favorite thing. An alternative is to grow two registries: one for in-memory serializers and one for persistent serializers. At first, I don't love that either, for its extra conceptual complexity and the likelihood of code duplication between the two types of serializer. But, as I sit with it, I think it may be the lesser evil. Better to have two separate functions with well-defined input and return values than to have one functions with behavior that is hard to immediately follow or reason about.

Elaborating on the above:
def serialize_csv_sync(df, metadata):
   ...
   yield chunk_of_bytes

def serialize_csv_async(df, metadata, file):
    ...
    file.write(...)
    # return None

serialization_registry.register("array", "text/csv", serialize_csv_sync, serialize_csv_async)

The tiled server is implementing a feature that each serialize method will need to be able to handle in order for Tiled to work. Making file an optional parameter in this case feel awkward. Completely separate serialize methods (serailize_csv_memory and serialize_csv_file) would be clearer to those implementing these methods but require more code, since in a great many cases these methods would do a lot of the same thing.
On the whole I think I prefer separate methods.
I like the register method in https://github.com/bluesky/tiled/issues/128#issuecomment-961398197... It really tells the implementer that they have to implement both to be compliant.

Another point we should consider in this API design:

What about formats like Zarr and TileDB that span multiple files? This is another reason, along with performance optimization for h5py, that file should maybe be filepath.
What about blob storage someday?


One column per line for GROUP BY clauses

Hi @Matts966 !
Thank you so much for the previous change on formatting rules for WHERE and ON (issue #6).
That change has also introduced new formatting for GROUP BY clauses. All GROUP BY columns seem to be on a single line.
Is it possible to revert the GROUP BY formatting so that there is one column per line, like the example below ?
よろしくお願いします。
SELECT
  *
FROM
  foo.bar_tab1
LEFT JOIN
  foo.bar_tab2
ON
  foo.bar_tab1.id = foo.bar_tab2.id
WHERE
  col1 = 'abc'
  AND col2 > 10
  AND col3 IS NOT NULL
GROUP BY
  1,
  x,
  y,
  z;

Hi! Thank you for your conrtibution!
@dogan-sky
How about automatically sorting columns and formatting column words per line, column numbers in a line.
from
SELECT
  *
GROUP BY
  x, y, z, 1, 2;

to
SELECT
  *
GROUP BY
  1, 2,
  x,
  y,
  z;

That sounds good, thanks @Matts966 :)


machine wide installation of user created .net core package

Issue Title
Machine wide installation of user created .net core package
General
I have a package which I want to deploy once on a machine and let more than one application to use it at run time. Its more of a traditional .NET fullframework application  GAC deployment approach. I want to see if there are any support for such scenario with .NET Core.
Thanks
Vishwa

There currently is not any good support for this. It is something that we're exploring for .NET Core 3.0. I'm going to move this to the right repo where the people working on that problem will see it.

Issue moved to dotnet/core-setup #4525 via ZenHub


Overwork Form.Checkbox

Description
At the moment, I see two problems with this checkbox
A) The text is going to the right. I know your API provides the possibilities to add the text to the left (I think that would be the label) but that is very counter intuitive with the checkbox itself as in all other applications, the text next to a checkbox goes to the right. And it just doesn't make any sense to put the same text on both sides or a semantically same text. You also don't want to put anything wordy on the right, as that is what the "info" attribute is for.
B) The checkbox looks ridiculously small to fit to the font size.

I suggest adding the possibility to add a new full sized component as a toggle switch. It fixes both problems. Text normally goes to the left (look at any menu in the iOS settings) and you don't have to fit the size against the "label" font size but you can fit it against the font size of the Form.Label, Form.Dropdown or the placeholder text in Form.TextInput.

Who will benefit from this feature?
Everyone working with booleans in forms. I suggest marking the checkbox as deprecated instead of just straight replacing the underlying rendering as the new component wouldn't be a "checkbox" and it would lake the right aligned text (and at the moment everyone is probably using it and needs to move it to the left aligned text).
Marking it as deprecated ensures everyone stays inline with the global styling guidelines. Porting the code is very easy and probably won't introduce any bugs (provided no one makes a typo)
Anything else?
No response

As with every other Form item, the title goes on the left indeed.
We found that this format works well as part of our Forms.
You could maybe have a look at some of our preference screens to find some inspiration:

It is very unlikely that we will deprecate it.


Allow for 'Current' or something similar for cv.sections.experience.0.end_date

I did not see a good way to indicate I'm still employed?  I've always used, "Current," but other synonyms could work, too.

There are two ways:

Either not providing end_date.
Or setting end_date to present.

Then the output will be "present".
However, if you would like to use "current" instead of "present" you could append this to your YAML file:
locale_catalog:
  present: current

See the locale_catalog field's documentation for details.
Also make sure to use JSON Schema to find out available options, as described here.


add id_conflict_policy to client::WorkflowOptions

What was changed

Added the WorkflowOptions::id_conflict_policy property.
Why?

I have a need to use this feature of temporal when (unofficially) using the Rust client library.
Checklist

Closes
No issue

How was this tested:

Tested this locally (i.e. used this feature from code on my machine).
Happy to add automated tests if you think there should be some... If you're open to this change and think so, could point me to a reasonable place to add a test and/or another similar test to follow?

Any docs updates needed?

Don't think so.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Many thanks @Sushisource :)


Which direction (pluralize, or singularize?) is easier, or less ambiguous?

I'm going to use the pluralize module to convert a big list of words - all singular, or all plural - into a list that contains both the singular & the plural of each.
Am I better to start from a list of singular words or plural words?

Should be fine either way, I wouldn't really be able to answer it because if one was performing worse I'd look at fixing it. For consistency sakes, I'd probably start with singular anyway and go to a plural. Remember that this module is only a light-weight modules for working with English using RegExps. If you want complete plural support (less chance of issues) you might want to use a dictionary.

Ok, thanks for the response.


Portfolio Accessibility

🆗 Check all of the items listed in the article Easy Checks – A First Review of Web Accessibility (which you already read in the previous lesson).
🆗 Determine if your Portfolio needs any changes.
🆗 Make changes in a separate branch and open a new pull request.
🆗 Prepare a report listing all points that you have checked, and the result of your evaluation.
🆗 Your report should include Page Titles, Image Text, Text Headings, Color Contrast, Rezise, Interaction, Moving Content, Multimedia, and Basic structure of the page.
🆗 Each point on the list needs to include the result of your evaluation.

invalid


http3: share http3 status between conn pool grid and alternate protocols cache

Commit Message: Right now h3 status are tracked by each grid, thus does not persist at the end of the grid life time. This PR moves h3 status tracker's ownership from the grid to the corresponding alternate protocols cache entry so that it can out live the grid. The cache may not have the entry when the grid tries to access the h3 status tracker. In that case, the cache will create a new tracker (and a new cache entry if there is none) for the given origin.
Additional Description: Added a public interface Http3StatusTracker
Risk Level: low, conn pool grid and alternate protocols cache only
Testing: existing tests pass
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #18715

/assign @alyssawilk

I think Ryan can merge this without second pass.  @RyanTheOptimist did you want me to take a look?

I think Ryan can merge this without second pass. @RyanTheOptimist did you want me to take a look?

Oh, right. Good point. At this point I just assume that all of Dan's PRs involve complicated 0-RTT plumbing everywhere :)
I'll merge.


[BottomSheetModal] [BottomSheetFlatList] Persist last scroll position on the flatlist when reopening the bottom sheet modal again

Hi,
I have a bottom sheet modal which renders a flatlist inside. A user presses an item on the flatlist and the bottom sheet closes. When the bottom sheet is opened again, the flatlist starts from the top. That is the scroll position is reset. I'd like it to persist such that when a user selects something from the bottom of the flatlist, it remains in the scroll position the next time too.
I tried the props scrollsToTop={false} but it isn't working.
<BottomSheetModal
      ref={bottomSheetModalRef}
      snapPoints={snapPoints}
      handleIndicatorStyle={{ display: 'none' }}
      backdropComponent={CustomBackdrop}>
      <BottomSheetFlatList
        data={SESSIONS}
        renderItem={renderItem}
        scrollsToTop={false}
      />
    </BottomSheetModal>

Oops wrong repository. My bad!


Add decimal digits to datatype description?

https://github.com/music-encoding/music-encoding/blob/425a49bbfdac18e85744a76cb3b5d6d41607e8e3/source/modules/MEI.xml#L3105-L3120
Shouldn't the description of these decimal datatypes also include the decimal digits? But if so, how many?
E.g. between 0 and 100.00 resp. between -100.00 and 100.00

Per the regex, any number of decimal digits is acceptable.  To my mind, that's implied by the phrase "decimal number:"
However, there is a problem with the description of data.PERCENT.LIMITED.SIGNED, which should read 'Decimal number between -100 and 100, followed by a percent sign "%".'  It's probably also a good idea to drop "positive" in the description of data.PERCENT.LIMITED so that it reads "'Decimal number between 0 and 100, followed by a percent sign "%".'

@pe-ro 2 : @bwbohl 1 ;-)

"Positive" has to be removed from the description


Ability to have the entity name and related data member key different

I have a model and a one-to-one relationship to another model like the example below:
`
export default class Member extends Model {
static entity = "members";
static fields() {
    return {
        id: this.attr(null),
        username: this.string(""),
        email: this.string(""),
        url: this.string(""),
        isCoach: this.boolean(false),
        preferences: this.hasOne(MemberPreferences, "memberId")
    };
}

}
export default class MemberPreferences extends Model {
static entity = "memberPreferences";
static fields() {
    return {
        memberId: this.attr(null),
        locale: this.string(""),
        measurementSystem: this.string("")
    };
}

}
`
The issue i am facing is that the relationship does not work (upon inserting a new object for example) unless i name the 'preferences' key from 'Member' to 'memberPreferences' - as the entity name of the second object.
This works perfectly:
export default class Member extends Model {
    static entity = "members";

    static fields() {
        return {
            id: this.attr(null),
            username: this.string(""),
            email: this.string(""),
            url: this.string(""),
            isCoach: this.boolean(false),
            memberPreferences: this.hasOne(MemberPreferences, "memberId")
        };
    }
}

export default class MemberPreferences extends Model {
    static entity = "memberPreferences";

    static fields() {
        return {
            memberId: this.attr(null),
            locale: this.string(""),
            measurementSystem: this.string("")
        };
    }
}

Is this a requirement? I don't see it stated anywhere?
My understanding is that once we define the relationship - even if the data key name is different vuex-orm would figure it out?
Or am i getting it wrong?

Nevermind that! I've just figured it out :) I am not querying the data properly!
Another final comment - is there a way to fetch the object data - including all related ones (for example i have a model with several one-to-one relationships) - without asking for each relationship (with 'with')?

Hello @miraclebg,
You can use withAll or withAllRecursive (see https://vuex-orm.github.io/vuex-orm/guide/relationships/retrieving-relationships.html#load-all-relations).
Don't hesitate to join us on the Slack Channel if you have any questions!

Thank you so much! Adding it now!


attribute value - customErrorMessages

How can I access the attribute value in customErrorMessages ?

I want this too.
Also I want custom placeholders in message. See laravel's Validator::replacer() as example.
Best regards

When creating custom rules, there is already support for custom error message.  Are you looking for something different?
Validator.register('telephone',(value, requirement, attribute) => {
  return value.match(/^\d{3}-\d{3}-\d{4}$/);
},
'The :attribute phone number is not in the format XXX-XXX-XXXX.'
);

This issue is stale because it has been open 30 days with no activity.


Add Evaluate Selection option to Script Editor

Closes #24074

(the last one is a joke, nothing happens if there is an error)

Does it work with UndoRedo?

Does it work with UndoRedo?

Yes, it uses insert_text_at_cursor() in the end.

Does it support evaluating multiple lines at once?
Such a good replacement for Python shell to calculate stuff!

Does it support evaluating multiple lines at once?

No, it only evaluates first line when multiple are selected. Maybe I could do that with split()...

Thanks!


Branch 0.5.2

OAuthClient error handling fixes

Coverage decreased (-0.2%) to 99.762% when pulling ae49ae56303c07dae61a28393b7e5ebd9376a689 on branch-0.5.2 into 246fc112258e0beaa372bde914321336397a095f on master.


Add basic linters

Pull request
Adds basic linters to the CI, the key change is to the github workflow. Now unless the code and notebooks are correctly formatted, the CI will fail.
Please confirm that this pull request has done the following:

[x] Tests added (N/A)
[x] Documentation added (where applicable)  (N/A)
[x] Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
[x] Description in CHANGELOG.rst added

Adding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following:
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

@Rlamboll ping

Sorry, on my to-do list for tomorrow.


secureboot + tpm2?

are it possible to enable secure boot and tpm2? to update w11 on arm

Duplicate of #3082


string.Empty response is not documented

There is no documentation to explain what an empty string response means.
Is it the same as for showaddappointmentasync?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a3ec88d-5578-52e8-957d-d8adcad1586c
Version Independent ID: 11cf9865-6b5f-7b9e-4dc4-0a0d413bcace
Content: AppointmentManager.ShowEditNewAppointmentAsync(Appointment) Method (Windows.ApplicationModel.Appointments) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.ApplicationModel.Appointments/AppointmentManager.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @mikben
Microsoft Alias: mikben

Hi Matt @mrlacey. Thanks for submitting your feedback and we apologize for the very late response. I see that updates have not been made since the creation of this Issue, so I went ahead and created an internal work item resolve this doc bug. I found the spec for this API and the string.Empty response does indicate the same result as the other API. I'm updating the wording on this page to match the other, and the changes should be merged and live later today.
Though the Issue will be marked as Closed, we will monitor any replies that come afterwards so treat this like an open Issue. Many thanks!


Delete adium-beta.rb

https://github.com/caskroom/homebrew-cask/pull/38016

@reitermarkus Isn’t this version vulnerable as well? From the linked article in the other post, I see nothing saying it‘s fixed in the beta.


Add support for termsrv 10.0.17134.1

termsrv.zip
RDPconf indicates it is not supported.

Thank you!

Same issue.

Hi,
I also have the same issue with 10.0.17134.1
Any word on a fix yet?
Thanks

Temporally fix by replace termsrv.dll with the version 16299.15

Cool.
Next question.... Does anyone have a copy of termsrv.dll that is version 16299.15?
I don't as this is a fresh install of Win10Pro
Thanks.

@Everglase
termsrv.zip

Thanks @Jerry981028
I will give it a shot.

Exact same problem since upgrading to Windows 10 1803 17134.1.  Replaced termsrv.dll with the one that was in the Windows.old directory and that "Solved" the problem for you.   Here is the newest termsrv.dll (version 10.0.17134.1 dated 4/11/2018
termsrv.zip

How can I replace the file Windows won't let me.?

@quicken2k
check here:
https://github.com/stascorp/rdpwrap/issues/442#issuecomment-379121357

This is also broken for me, got the new Windows 1803 update on my HTPC yesterday, patcher not working any more.
I couldn't (easily) replace the termserv.dll file.     I see some people recommending fixes above (thank you) but I can just wait.   What kind of turnaround would we expect from the devs? A few days or weeks?

Bi  k3
On Wed., 2 May 2018, 4:24 pm cuureel<EMAIL_ADDRESS>wrote:

@tvcat https://github.com/tvcat
16299 will cause the live account cannot logon for windows store.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stascorp/rdpwrap/issues/456#issuecomment-385876631,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AlEfrYsyoA0GyN7AYv0WpHz18ADUpIe6ks5tuVEpgaJpZM4TlRO8
.

@cuureel
What you mean by live account. I can logon to Windows Store.

@Everglase  replacing the old termsrv.dll worked for me.thanks

Although downgrading termsrv.dll fixes the problem for now, it's quite the hack. 1803 has been out for a couple of days already, and still no support for the new version. When can we expect a version of RDP Wrapper that works with 1803???

@TanMan1217
The developer owe you nothing.
You can pay to Microsoft or ThinStuff or just shut up and wait.

@TanMan1217
I share your frustration. But please keep the conversation polite. Nobody is getting paid to do this job. It’s all our curiosity and willing ness to help out.
Thanks

Yeah, it's frustrating but just be calm, patient.

My biggest frustration is actually at M$. Brand new iso download from them and bam, rdpwrap doesn't work :D Though they are just doing their job too.

IMO there is nothing to frustrate about.
It's not that hard to fix by replacing the DLL at all and it work perfectly fine.
And how much did you save from using this?

@tvcat, my issue is that we have to install a downlevel version of termsrv.dll to get this working. The reason is that Microsoft updated it again for 1803, and although we can never know why they changed it, most of their documented changes have been security related. It is therefore reasonable to assume that the changes they made to termsrv.dll are, at least partially, security related. Therefore, installing the downlevel version could potentially expose our systems to malware.
My comment above was neither rude nor demanding. I apologize if it came across that way. All I was asking for was an idea about whether this was being worked on, and if so, whether there was an anticipated release date. It required none of the snarkiness I received.
RDP Wrapper is the most elegant of the concurrent RDP packages, and that's why I use it. But if it's not going to continue being updated, I'll have to find a different solution.

It's free and it's not written by many people.    You need to relax, there's nothing you can do about it unfortunately.
I don't want to downgrade the DLL either, mostly because it's fidgety.  You SHOULD be angry at Microsoft, why do they keep needing to 'mess with files' between updates? They never did this anywhere near as much with Windows 7.    Messing with the DLL like 3 times (if I recall) in 10 years.   Windows 10? It's many times already
This is open source (isn't it?) so if the lead dev drops it, someone else can pick it up.

@TanMan1217
If your concern is on security then too bad you have the security risk from the start you use RDPWrap.
I'm not saying that RDPWrap is having security risk but when you do something it is not suppose to, there maybe security risk.
It's just common sense.
And the only and best solution is pay Microsoft.

@jaxjexjox
You should not angry at Microsoft. Your Windows license is not including the RDP service.

I should be angry at Microsoft because they're patching a file that doesn't need patching.  I'm 99.9% positive it's simply to break this functionality.
It was almost NEVER messed with under Windows 7.

@tvcat
I replaced termsvr.dll of 17134 with the modified one of 16299 (The security rights have been set same as the original one). The RdpConf showed "fully supported", and The RDP works well. But I found there is something wrong with the add account function with email account.

The add account windows will crash after it shows.
The microsoft store cannot be logon. An error message showed.
All applications from microsoft store cannot be launched. An error message showed "File System Error (-2147219196)".
After I executed the command "SFC /scannow", all above problems were solved, but the termsvr.dll was also recovered by the one of 17134. If I replace it with 16299, all above problems will appear again.

@jaxjexjox
Is your Windows license come RDP feature?
If it's not then you are cheating on Microsoft and they have the all the rights to disable your cheat.
Windows 10 Pro come with RDP but no concurrent, it's not that expensive.
If you need concurrent then you need server license and terminal service license and client license IINM.

@cuureel
I can confirm this on Windows 10 Home 17134.1 after testing and i found the fix.
You need the same version of rfxvmt.dll (16299.15)

stop termservice.
replace with rfxvmt.dll (16299.15).
Restart

What about the 32 bits version ?

@tvcat
Thank you for the solution, but your solution can only solve the logon problem of ms store.
For the problem of failure to launch ms store apps, I found another solution.
Get-AppXPackage -AllUsers | Foreach {Add-AppxPackage -DisableDevelopmentMode -Register "$($_.InstallLocation)\AppXManifest.xml"}
After executed the above command, all apps launched successfully.
Thanks again.

@cuureel
I can install and launch any MS Store App without running any command.
However I have never login or install any app before replace the termsrv.dll and rfxvmt.dll.
Is the app that failed to launch installed before the Windows 17134.1 update?
If no then i think it's not related to RDP service.

same problem. april 2018 update break my RDPWrap :(

i can use RDPwrap whit old versión termsrv.dll thank u so much!  amazing program.

There is a reason why Microsoft released a new version ... especially RDP Protocol is extremely great for hackers to get into your system ... not a good advice to use old version of termsrv.dll

@FoGBaV
You can copy to the ini yourself.
Latest version of the installer can use local ini, read the readme

thanks @macchrome
This is dirt simple to update yourself ini file wise, presuming RDP was working fine before the Windows 10 1803 update.  I didn't want to wait for the next official rdpwrap update. And I didn't want to overwrite the latest termsrv.dll with a deprecated version.  This was my solution, for x64 only.

Go to C:\Program Files\RDP Wrapper and make a backup copy of rdpwrap.ini (optional step)
Right click on original rdpwrap.ini and click Properties, and then the Security tab, and edit the permissions to full control as necessary so you can edit the ini file (optional step)
Open rdpwrap.ini up in an text editor, notepad is fine
Under label [Main], change the value for Updated to some newer date say Updated=2018-04-30 (optional step)
Search for and copy/paste label section [10.0.17063.1000] to just below as a new section (make sure you leave a blank line in between),  change the copied label value to [10.0.17134.1] instead, and then delete all lines underneath with "x86" in them since we don't have these values from IDA yet.  Make sure you leave a blank line below what was copied and where the [SLInit] label begins
Update the values for the remaining x64 lines to what macchrome posted above (note the updated value edit for SLInitOffset.x64=22E6C)
Now search for and copy/paste label section [10.0.17063.1000-SLInit] to just below as a new section (make sure you leave a blank line in between), change the copied label value to [10.0.17134.1-SLInit], and then delete all lines with "x86" in them.  Leave a blank line below what was copied and the end of the ini file.   The previous x64 values from 10.0.17063.1000 are ok as-is.
Save the ini file, restart the PC, and then rerun RDPConf.exe to check your work.  If you followed the above steps, it's all green now.

RDP functionality works fine again for me with these steps.  I tested using RDP for MacOS v8.0.43 as the client into Windows 10 as the server with no problems.

@drshock
Good one and thanks for sharing.
However you don't have to change the ini file permission.
Just open elevated cmd and copy the ini file for backup then "notepad " to edit and save.
After that you don't have to restart Windows too, just run "RDPWInst -r" in the RDP installation folder.

Is it possible to post the rdpwrapper.ini with the fixes above .. i only get "not listening" ... Thanks !

@FoGBaV
You copy the wrong offset, see the edited value by @macchrome

Works perfect - thank you ... missed something in the great instructions from drshock ...8)
If someone likes to try out the moddiefied ini file ...  : https://ufile.io/yzn0f
Greetings and many thanks !

@FoGBaV
I used your modified ini file but i still have the listening state not working under Win 10 Home. I tried both with rfxvmt.dll 16299.15 and 17134.1 in System32 and SysWOW64 folders but still the same results.

@graphixillusion
That's mean you are doing something wrong or FoGBaV uploaded the wrong ini file.
All the info is just above you, not that hard to check yourself.

@drshock Thank you for your support.
followed your instruction and it does works now.

I don't know why the @FoGBaV ini doesn't work: i checked and compared it several time and the values are correct but with it i always got listener not working. Adding manually the new data to the original ini worked flawless.

thanks drshock for your detailed instructions. I am back to all green now, using the patched termsrv.dll and all looks good, but I still cannot connect from external computers using rdp. it never initiates the connection. checking it with rdpconfi looks good and rdpcheck opens the connections properly, but externally it still does not work. I opened the port in the firewall, and even turned off the firewall to test, and still no dice. any suggestions what else might be blocking the rdp connection?

I actually figured it out just now. the pc had previously had a static ip with port forwarding set in the router. upon reinstall of the pc, with the upgrade to 1803, I had forgotten to reset the static ip. Just did that now and it works. Thanks everyone, especially drshock and macchrome

Ok, This is interesting. I load the new ini file from @FoGBaV and it comes up fully supported which is good. But "Service State: Stopped" and "Listener State: Not Listening"
Restarting does not fix it. I go into services.msc and try to start the service manually and it says "access is denied"...
Uninstall RDPWrap and I can start the RDP service. Reinstall and the service stops and again I can't start it....
Does anyone have any ideas?

The ini file from FoGBaV is OK for all my 64 bit Windows. I had only to load it with  WordPad (Unix text format) and save it (Windows text format).
Has anyone the 32 bits adresses to complete the 32 bits part ?

[10.0.17134.1]
LocalOnlyPatch.x86=1
LocalOnlyOffset.x86=AD738
LocalOnlyCode.x86=jmpshort
SingleUserPatch.x86=1
SingleUserOffset.x86=36B0C
SingleUserCode.x86=nop
DefPolicyPatch.x86=1
DefPolicyOffset.x86=33569
DefPolicyCode.x86=CDefPolicy_Query_eax_ecx
SLInitHook.x86=1
SLInitOffset.x86=474AD
SLInitFunc.x86=New_CSLQuery_Initialize
[10.0.17134.5-SLInit]
bInitialized.x86      =CBF38
bServerSku.x86        =CBF3C
lMaxUserSessions.x86  =CBF40
bAppServerAllowed.x86 =CBF44
bRemoteConnAllowed.x86=CBF48
bMultimonAllowed.x86  =CBF4C
ulMaxDebugSessions.x86=CBF50
bFUSEnabled.x86       =CBF54
========
Purely experimental! Only single sessions work. Tested under Windows Pro Virtual Machine.

Hmm, I've updated as per the details above, and have 3 greens, fully supported and it's not working. I've not been able to log in remotely (different and same users) to the user already logged in.
Weird. Thoughts.

Thanks to Macchrome, I place your code in the ini file of a 32 bits Windows 10 Home with its original "termsrv.dll" (the W10 April 2018 termsrv.dll) and I can now log to this PC.
I'll test realy this configuration later.

Exactly the same as Everglase has:
TermService cannot be started (access denied error)

By RDP, I am writing here from an "April 2018" (Windows 10 64 bits) . This is the conf log:

Hi SamuFr
where have you got the 10.0.17134.1 version ? is it originally of 1803 win10 ?

I use the original "termsrv.dll" (10.0.17134.1) from Windows 10 April 2018 (Windows 10 version 1803).
Installs are french; the only differences could be with "C:\Windows\System32\fr-FR\termsrv.dll.mui"

Thanks @macchrome, @SamuFr, and all.
rdpwrap.ini previously posted by @SamuFr
https://github.com/stascorp/rdpwrap/files/1985682/rdpwrap.ini.TXT
(delete the TXT extension to get the "rdpwrap.ini' file)
My install procedures
After installation, stop TermService (and linked services) copy rdpwrap.ini to Program Files\RDPWrap
and start again TermService. (RDPWrap works now with termsrv 10.0.17134.1)
Tested in Windows 10 Pro.
The problem  is you cant do that in remote mode. You can use
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager]
"PendingFileRenameOperations"
to rename rdpwrap.ini after restart
Greetings!!

Well I wish I understood all this, but I don't.  I am trying to recover the rdpwrapper functionality by just using the modified rdpwrap.ini file, without success.  Some say that the termsrv file which came with build 17134 needs to be modified, and some say it doesn't.  In the past, binarymaster has discovered and fixed the obstructions introduced by a Msft upgrade so that we just have to re-install rdpwrapper.  I hope that happens this time too.  Thanks in advance, binarymaster!

Samu,
i have got this working but only with the oldest version, when i try the 10.0.17134.1 its shows not supported ( see attached).

Hi @Julien-nl
Follow the procedure above. This work for me.

Greetings!!

@mOrfiUs  Can you please share your rdpwrap.ini file ?
Cannot seem to write the ini file proply.
if you share your ini file would point me to the right directions.

Success!  I finally understand what to do!  mOrfiUs got it right!  I was putting the rdpwrap.ini file in the folder with the install and update files, and it needs to be put in the "Program Files" folder!   May I re-state the obvious:

Copy the modified rdpwrap.ini.TXT file to C:\Program Files\RDP Wrapper
STOP the service named "Remote Desktop Services".
Navigate to C:\Program Files\RDP Wrapper and rename the rdpwrap.ini file to something like "rdpwrap17063.ini"
Rename the rdpwrap.ini.TXT file to "rdpwrap.ini"
Restart the Remote Desktop Services  service.
Then you can run RDPConf.exe and you should see the desired green results.  Thanks, everybody!

Next questions:  what process normally puts the rdpwrap.ini file in the "Program Files\RDP Wrapper" folder?  Can/will that process be amended to put the modified rdpwrap.ini file there instead?  That would make these special installation tasks unnecessary.

what process normally puts the rdpwrap.ini file in the "Program Files\RDP Wrapper" folder?

Installer (RDPWInst.exe).

Then I guess the newly modified rdpwrap.ini file will soon be put in the place where the installer can find it so that all that is needed to satisfy the 1803 builds will be to  perform an install and/or an update.

Shouldn't the new rdpwrap.ini be merged to this repo or isn't it ready yet?

How i do it only over Remote and without restart

Get a programm too unlock locked files.

(thanks @macchrome, @SamuFr, @mOrfiUs and all for sharing this.)

Replace the rdpwrap.ini with the from @mOrfiUs

folder: C:\Program Files\RDP Wrapper

Go to Taskmanager or open services directly and RESTART  the service that called "Remote Desktop Services" or "TermService".

DONT close this service, if you do that you cant connect again !!!

Finish

You will lose the connection too your Server, and you just need too wait until the Service get started again then you can reconnect and test it.

I have Windows 10 Enterprise v1803.
The text file does have the utility show Fully Supported, but when I try to RDP, it still asks to disconnect the current logged in user.
This was working in Windows 10 Enterprise v1709.

Hi all. hi @Julien-nl . The ini file is the same uploaded by @SamuFr .
My procedure isn't the Holy Bible. Just my experience based in previous post.
## You can't copy new ini file because is in use by TermServ. If you are in remote mode and Stop TermServ, you loss connection. You need copy the ini file at restart by using "PendingFileRenameOperations" or another method.
I hope this solve your problem.
RDPWrap, at this moment (AFAIK) is the only way to use multi accounts without paid or migrate to server 2012.
Greetings!!

@mOrfiUs, for some reason Chrome considers rdpwrap.ini.TXT file to be malicious. Of course I know it isn't. But I don't understand why don't we make a new release instead of this workaround?

@Julien-nl I'm glad it works for you.
There are too many posts and seems has been created a bit of confusion. As far as my knowledge goes about rdpwrap  (thanks @stascorp for your wonderful soft),
it is not necessary to patch termsrv.dll.
That's this program does, without the need to change system files. Just with ini file.
It seems that you have done the same task twice.
The problem is that @stascorp (thanks again) has not yet updated its repository to work properly "update.bat".
@teo-tsirpanis  of course it is malicious, but it is only malicious for MS.
For us, the program users, it is cool!!
Just answer yes when chrome ask you.
Greetings!!

I think there is still something wrong ... i have everything "green" as stated above ... but when i try to RPC into the remote System it asks to log out the user logged into the PC locally ...

@FoGBaV have you replaced the ini file and restarted the PC ?
i've got it working the only issue i have is the printers redirect are not working over the RDP

@mOrfiUs has got it right as far as I'm concerned, works a treat.
Thanks

Got a way to fix the problem Everglase and I had:
TermService cannot be started with "access denied" error if RDPWrap is installed
TermService can be started if RDPWrap is uninstalled.
To start wrapped service:

add "Service" user to "Administrators" group
or more correctly
grant "Service" user read and execute access on "C:\Program Files\RDP Wrapper" folder.

@macchrome I'm with Windows 10 home 10.0.17134.48.. used the patched termsrv.dll file and the 10.16??? rfxvmt.dll file and the rdpwrap.ini file, but the listener is still off.. is this because i'm with the home version? any workaround?

@FormadorLar
I do not know the procedure for using RDP Wrapper with Windows 10 Home. You are using RDP Wrapper so it is not necessary to use a patched termsrv.dll: RDP Wrapper dynamically patches the required code and policies in memory.
Re-install the original termsrv.dll and the necessary files.  Uninstall RDPWrap; reinstall it using the  install.bat from a "trusted installer" prompt. I don't know if Windows 10 Home natively ships with termsrv.dll; but it should be owned by "trusted installer". A reboot of the machine might be necessary.
I've tested RDPWrap (amended rdpwrap.ini) using Windows 10 Pro 32 bit and it funcntions correctly.
SKUs that natively support Terminal Services can use  a patched termsrv.dll - but it is important to preserve the original ownership of the file.
I've been lurking on this forum. Yes the thread is (too) long, but all the information to attain a correctly functioning RDPWrap is here. People who expect to be spoon fed will be disappointed.
As an aside, Windows 1803 is basically (essentially) garbage; there is no compelling reason to update: infact, 1803 makes the case for LTSB.

Last days, I was very busy and didnt read new messages.
I am very surprised you need to stop rdp service for changing "termsrv.dll" and "rdpwrap.ini" files:

after I had taken ownership of "Windir%\system32\termsrv.dll and replaced administrators's rights by total control, I only renamed it to termsrv.dl.old and copied the right one as "termsrv.dll" and rebooted to use the right one.
I had only deleted the old "%ProgramFiles%\RDP Wrapper\rdpwrap.ini" and replaced it by the new one and rebooted to use the new one.
I did all of these operations from an other PC in the target PC by rdp mode.
(all my procedure is described 6 days ago)

Last days, I was very busy and didnt read new messages.
I am very surprised you need to stop rdp service for changing "termsrv.dll" and "rdpwrap.ini" files:

after I had taken ownership of "Windir%\system32\termsrv.dll and replaced administrators's rights by total control, I only renamed it to termsrv.dl.old and copied the right one as "termsrv.dll",
I had only deleted the old "%ProgramFiles%\RDP Wrapper\rdpwrap.ini" and replaced it by the new one,
I had rebooted the PC to use the new files.
I did all of these operations from an other PC in the target PC, in rdp mode.
(my procedure is described on

Had the update of 1803 and went able to get it working with thise method:

Freshly installed new windows 10 update open command prompt in administrator mode then enter this command: net stop TermService

Go to Windows.old\System32 and locate your old version of termsrv.dll the 10.0.16299.15 was mine but i think this is the same for you all.
Just keep in mind that this dll is related to your windows's language and version. termsrv.dll english will not work in windows french version. termsrv.dll Home version will not work in Pro version.

Go to Windows\System32 then right click termsrv.dll and go to properties context menu > security tab.

Click Advanced button then Edit Owner (with the little shield). In new window click Advanced then Search and select your actual session user, select it and validate your setting with OK.

come back to properties context menu > security tab > Advanced, select your username then add total control to this file. then Validate with OK.

replace termsrv.dll with the old one (who has the correct owner and rights).

Return to command prompt administrator mode then type: net start TermService

Run RDPWrap install.bat and Voila !!! That works no need to restart your system.

Hope that helps

I kept my mouth shut, because some people were complaining only hours after the patch for 1803.
However, it's now been over a week or two, several people have posted fixes in this thread, surely it's time for the main application to now be updated?

@macchrome perfect! The mistake i was making was related to an older version of rfxvmt.dll... As soon i restored it to the original version (windows 10 version1803), only thing i had to do is "net stop termservice", replace the ini file and... voilá! Up and Running! Thankx.

I found the simplest way (and it even works over a remote session) was to

download the @SamuFr  .ini file and remove the .TXT from the end

copy it to the C:\Program Files\RDP Wrapper directory.  Even with remote desktop running and termsrv.dll not stopped, it will allow you to copy the new .ini over the old .ini if you are an administrator.

at this point RDPConf will report everything is good, but I still couldn't get a second session to work.  I then tried restarting the TermService service and it didn't stop/start it.  So I just did a restart of the machine and then logged on and everything was working after that .  This is on Win 10 Pro 64 bit.

No need for the old termsrv.dll, no need to stop any service (unless you are not doing this over a remote desktop session). It is literally as simple as download the file, remove the .TXT, copy the file over the old one and reboot.
Thanks @macchrome and @SamuFr

Why nobody shared x86 (32-bit) DLL yet? :confused:

Here it is. Thank You
termsrv.dll 32 bit Ver. 10.0.17134.1
termsrv.zip

with new rdpwrapper.ini from update everything works again ... !
Thank you sooooo much !

Hi,
I can log in to remote session through RDPCheck.exe with no problem, but when i try to do this through windows Remote Session tool, or through clicking on computer name on the network and then selecting connect remote session it fails with error "Your computer could not connect to another console session on the remote computer because you already have a console session in progress."
Any hints as to why this happens?

A question: exept trying and retrying update.bat, how to know there is a new update ?

Read the installer source code to get an idea.

"Your computer could not connect to another console session on the remote computer because you already have a console session in progress."

Are you connecting from the same PC? Use <IP_ADDRESS> address then. If this wouldn't work, I have no idea.

After applying the fix, we can access multiple sessions remotely, but we cannot get printer redirection to work. Any ideas?

I use the new ini file and can connect remotely with multiple users. Unfortunately, I can connect to the same user multiple times and each time, new session is created. it should be if i connect using the same user that is being used, the user is logged out and i can resume the session. instead, new session is created each time. it is as if, im logging with different user each time. anybody know a fix?

@sokolik74 same problem as me. check this:
https://github.com/stascorp/rdpwrap/issues/422#issuecomment-389843513

Is there a fix to the problem where login will create new session? Can we use old teamsrv file and use old rdpwrap? Im not interested in the new enhancement by microsoft. the old one that works is fine with me.

@syaifulnizamyahya for now i haven't found any fix yet. Let's wait and see...


Install libxml2-dev on RBE executors

This is needed to build lld (at least as currently configured).

I again suspect you think we shouldn't merge this on Friday afternoon, although it should be fully exercised by presubmit. Could you merge while I'm away next week?

Android build is broken at HEAD and not possible affected by this change

Will be fixed with https://github.com/google/iree/pull/6679 (that build is the only one that runs benchmarks and shows breakages there)

Will be fixed with #6679 (that build is the only one that runs benchmarks and shows breakages there)

Sure but this only affects Bazel builds and that build only uses CMake


Feature idva5 535/ localisation what is your role

[-Add localisation and change of structure]

CI: No security warnings found


PhpStorm 10.0.2 Migrations tab

Have an error on "Migrations" tab:
class com.yiistorm.elements.MigrationsToolWindow$1$1 overrides final method cancel.()V

+1

+1

+1


Add Tabby terminal emulator

Project description
From their Github repo:

Tabby is a highly configurable terminal emulator, SSH and serial client for Windows, macOS and Linux

Metadata

Homepage URL: https://github.com/Eugeny/tabby
Source URL: https://github.com/Eugeny/tabby
License: MIT
Platforms: linux, darwin

+1

+51


Question about 'Sample_20_test_Human36M_smpl'

Thank you for your excellent work.
'Sample_20_test_Human36M_smpl' is required in the project but only 'Sample_64_test_Human36M_protocol_2' found in the given link. Also the given file doesn't include the keys like 'h36m_joints' or 'smpl_joints'.
Thanks again.

Sorry for my mistake. I uploaded the wrong testing file. I have fixed this problem and you can find the correct file now.
Thanks for pointing it out!

Thank you for so rapid reply. Uh, the test annotation file of MPI-INF-3DHP is also missing. So could you provide it, too?

Hi, I have updated the link for MPI-INF-3DHP dataset. Now you can download the test annotation file.

Thanks! Here's my last question, probably. The function 'forward_gt_theta' is missing in the model 'Simple3DPoseBaseSMPL'.

Hi, the function 'forward_gt_theta' is deprecated. We use this function only for ablation study. You can just ignore it.

For the evaluation of 3DPW, the code in the project tries to recover the mesh of body with the ground truth of shape and theta and then regress to the joint positions. This operation in your code need the function 'forward_gt_theta'.

Hi, this bug has fixed now. b8cfeeb7df2d7c8024865751cc17664a8272557b
I hope it works.

Thanks and best regards!

You're welcome😊


Fix buildUrl annotation in kokoro job

@markdroth

I have noticed that when using loadtest_config.py, the generated configurations is like:
apiVersion: e2etest.grpc.io/v1
kind: LoadTest
metadata:
  annotations:
    ci_buildNumber: 0823
    ci_buildUrl: https://source.cloud.google.com/results/invocations/de75ab7c-6b94-440f-8df2-1979f5668e43
    ci_gitActualCommit: ''
    ci_gitCommit: wanlin_test
    ci_jobName: wanlin_test
    pool: workers-8core-ci
    scenario: ruby_protobuf_sync_streaming_ping_pong
    uniquifier:<PHONE_NUMBER>5106-workers-8core-ci

Note the ci_buildNumber is just the number, if we use kubectl apply -f  the ci_buildNumber requires string format, i.e. "0823", but it runs okay if we use runner to apply this LoadTest configuration.


Create tests

Create a test that uses the functions together:

[ ] extract array of words from string (headline)
[ ] remove stopwords from array of words
[ ] create ngrams from array of words (without stopwords)
[ ] find keywords from combination of 1: array of words w/o stopwords and array of words from string (bodytext)

Don't need to do excessive testing, this happens in each module. Here it's only to show that they can work well together.


ip6tables: add -w parameter to solve xtables lock

There is a lock on xtables when the service starts, so the service
fails. Adding the waiting (-w) parameter when executing will let the
service wait for the lock to be removed.
Signed-off-by: Hilmar Magnusson<EMAIL_ADDRESS>

Here is the output from BISDN Linux running on agema-ag7648:
ERROR: problem running iptables: Another app is currently holding the xtables lock. Perhaps you want to use the -w option?


Binding on SegmentedButton

After having some issue with binding on segmented button I found an old issue on SCN https://scn.sap.com/thread/3612473 and a related jsbin http://jsbin.com/rujij/2/edit?html,js,output which is showing the same issue as I am having.
Despite different elements in the model all the segmented buttons are displaying as the first button despite, in the jsbin, other elements being displayed in the description.
This may interest @dennisseah as he wrote the jsbin.
Thanks as always.

Hi njames,
what exactly is the problem you are having? I had a look at the sample, but for me everything looks fine. It would be very helpful if can describe the steps to reproduce the problem and describe the problem a little bit more.
Thanks!

I was expecting the buttons to be bound to the button in the description column which was what I was attempting but it seems like there is no binding in the pastebin example.
Also when clicking in this pastebin several rows loose their selection after clicking other rows.
Have changed my control to radio buttons now and they are binding nicely. Only pursue this if you think there is an issue.
N


Cargo install fails "because it has no binaries"

$ cargo install --git https://github.com/rustformers/llm llm
    Updating git repository `https://github.com/rustformers/llm`
error: there is nothing to install in `llm v0.1.0 (https://github.com/rustformers/llm#d33ed843)`, because it has no binaries
`cargo install` is only for installing programs, and can't be used with libraries.
To use a library crate, add it as a dependency to a Cargo project with `cargo add`.

this was attempted on commit d33ed8434b296081081edf42c635c8ee873a6134 (made 14 hours ago as of writing: 2023-05-02T00:29:15Z )

Thanks for spotting this! Fixed now - should have been llm-cli 🤦


chore: fix missing changelog

Changelog environment variable is empty when releasing

Trying this now with dry run publish


Regenerate tool YAMLs plus lock files for sections A-F of usegalaxy.org (again)

This should also get non-version updates (galaxyproject/galaxy#8815).

I feel like I'm playing whack-a-mole here. Now Galaxy is being OOM-killed.

@galaxybot deploy this


double

I really liked your post, I see you blog in built in jekyll, I you do have lot of R posts in markdown, have a look at the jekyll() function in the servr package, I also use this http://qua.st/

Thanks for the edit. Yes, I do use jekyll and R markdown. I'll have to check our `servr', anything that makes it easier is great.


fix explanation about secrets in .Environment.Values

Just fixed it myself ;-)

https://github.com/roboll/helmfile/issues/1111


Compatibility Issue with adslib.so on 64-bit Raspberry Pi OS

This suggests that the adslib.so library included with pyads is compiled for a 32-bit architecture, whereas my system is based on a 64-bit architecture (aarch64), leading to an incompatibility issue.
SError: /usr/local/lib/python3.11/dist-packages/pyads/adslib.so: wrong ELF class: ELFCLASS32
Expected Behavior
it could be nice to have pyads to be compatible with 64-bit rpi Linux systems, when installing from pip isntall
Steps to Reproduce
Install pyads version 3.3.9 on a Raspberry Pi running a 64-bit Linux OS and Python 3.11.2.
Attempt to import pyads in a Python script or interactive session.
The import fails with the aforementioned OSError.
Possible Solutions
pip package for 64-bit version of adslib.so for aarch64 systems.
Work around
To build it from source, but i am looking forward for an "off the shelf solution" if it is possible :)

Possibly linked to #363

also linked to #22 #36 #147 #365, closing as duplicate of #365

ahh great...i'll follow the other issue then ..thx :)


bool is true or false

Wystąpił wyjątek: CLR/System.InvalidOperationException
Wystąpił nieobsługiwany wyjątek typu „System.InvalidOperationException” w Microsoft.Extensions.Configuration.Binder.dll: > 'Failed to convert configuration value at 'hostBuilder:reloadConfigOnChange' to type 'System.Boolean'.'
Znaleziono wewnętrzne wyjątki. Zobacz $exception w oknie zmiennych, aby uzyskać więcej szczegółów.
Najbardziej wewnętrzny wyjątek 	 System.FormatException : String '1' was not recognized as a valid Boolean.

Hello @yecril71pl ... Numbers are accepted in string values for at least some of these (I'll check all of them given the error that you hit for reloadConfigOnChange). For example, detailedErrors ...
https://github.com/dotnet/aspnetcore/blob/a450cb69b5e4549f5515cdb057a68771f56cefd7/src/Hosting/Hosting/test/WebHostConfigurationsTests.cs#L47-L56
However, doc churn seems to have introduced a problem in the way these acceptable values are described since I worked on this topic a few years ago. true/1 or false/0 are the acceptable values, but updates don't seem to have kept up with that logic/approach in the descriptions. I've opened #23984 to address this. Thanks for pointing it out.


[BEAM-1466] JSON utils extension

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @dhalperi

Coverage decreased (-0.01%) to 69.7% when pulling 3713f407e49a5c754c54d0da17138065441eb8b7 on aviemzur:json-utils into 5fe11a2fc496dabf8450923e7aa232bdb7800747 on apache:master.

Coverage remained the same at 69.71% when pulling 4a64dfe6d7db468764eafda5e5f3b224c0ca6983 on aviemzur:json-utils into 5fe11a2fc496dabf8450923e7aa232bdb7800747 on apache:master.

Coverage increased (+0.003%) to 69.714% when pulling 17dd718f3d83516db9a6756552cd7424e8f2aa4e on aviemzur:json-utils into 5fe11a2fc496dabf8450923e7aa232bdb7800747 on apache:master.

Maybe @eljefe6a would be a good reviewer for this? Jesse seems like the type of person who understand this at a very low level.

@jbonofre Was looking at this too. I'll take a look.

I'll agree with @aviemzur that the "file where each line is a JSON record" would be easily supported by TextIO.Read + JsonParse  / JsonFormat + TextIO.Write. I think that is a very common format for storing JSON.
I also acknowledge @eljefe6a's point that this would not be a good fit were there newlines inside the JSON records, as is also very common. That would require more thought / "JsonIO". I would probably go ahead and ship this and think about JsonIO later. (It would be good to have a few motivating examples, too!, to inform the design of JsonIO.)

Hi guys,
I'm a bit surprised to see this PR without a comment in the data format extension discussion.
As reminder, we started a discussion to provide an extension to deal with different data format: JSON, XML, ... and provide PTransforms to convert from one format to another (format converters).
I started a PoC about this here:
https://github.com/jbonofre/beam/tree/DATAFORMAT
and the discussion on the dev mailing list.
IMHO, all about data format converters should be in a data format module.

Hi JB,
I don't think a single "Dataformat" module is necessarily all that useful.
For one, it would likely have lots of dependencies.
To enable many contributors and forward progress, IMO I am leaning towards
taking small improvements in PR without worrying too hard about long-term
structure -- especially as extensions.
For Dataformat -- I guess I had forgotten about it, sorry. I couldn't find
an active JIRA, or an active PR, for DATA_FORMAT. Your POC hasn't been
touched in 3 months.
Dan
On Thu, Feb 16, 2017 at 11:18 PM, Jean-Baptiste Onofré <
<EMAIL_ADDRESS>wrote:

Hi guys,
I'm a bit surprised to see this PR without a comment in the data format
extension discussion.
As reminder, we started a discussion to provide an extension to deal with
different data format: JSON, XML, ... and provide PTransforms to convert
from one format to another (format converters).
I started a PoC about this here:
https://github.com/jbonofre/beam/tree/DATAFORMAT
and the discussion on the dev mailing list.
IMHO, all about data format converters should be in a data format module.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/1983#issuecomment-280573576, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgIT_LB3LOhpjQFHkDUIOv5sb8V-d95ks5rdUm8gaJpZM4L-PTW
.

So, you propose to create one module per data format.
My branch was waiting for more discussion/traction on the mailing list.
I'm OK with the proposal: one module per format.
I will update the Jira (I created a Jira about the data format extension), and I will create the PR for XML data format (with JAXB).

I think JB's module is a good idea.
I agree with Dan that if a user just wants JSON for example, they don't want to be bombarded with a lot of other dependencies they don't use.
There is a solution though, JB's module can be a supermodule of individual formats modules, and there can also be a formats-all module which has dependencies for all of them, for convenience (If a user doesn't care about the unnecessary dependencies), or a user can just add a dependency for a specific module.
Then, the JSON module can just be moved under this supermodule when it is introduced in the future.

I agree with Dan and Aviem comments about dependencies and the way of moving format.
The number of data format is not so large, so that's why I thought about a "gather" data format module first (and it's what we discussed on the mailing list).
However, to speed up contribution, let's start with one module per format.

CC: @jbonofre

Rebased and made changes to address review comments.

Coverage increased (+0.01%) to 69.176% when pulling d4d7173a592da6e91cd27b9c60951fb17c76c174 on aviemzur:json-utils into 4e5a762ef36336eeecb568f12c9f3b41fa683a97 on apache:master.

Coverage remained the same at 69.163% when pulling d4d7173a592da6e91cd27b9c60951fb17c76c174 on aviemzur:json-utils into 4e5a762ef36336eeecb568f12c9f3b41fa683a97 on apache:master.

ping @jbonofre @eljefe6a

Let me do a new round. Thanks !

It looks good to me. As I'm just CC on this PR, Dan will do the "formal" approval.

After addressing the JavaDoc, LGTM.

Thanks for the reviews!
Can someone merge this?

I will merge (final round).