test: only close SSH session if context is canceled

If an SSH has Run called on it, and Run returns, there is no need to close=
the session because calling Run implicitly closes it. If we call Close on a
session for which Run has already completed, we riddle the logs for test runs
with errors like the following:
"failed to close session" error=EOF

So, only try to close the session in the case that session.Run is still
ongoing (e.g., when a context associated with running the command is canceled /
has reached its timeout).
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

Coverage decreased (-0.02%) to 44.242% when pulling 5db3a6daa4d07f4b31f8812f060e23fc28bd8c36 on pr/ianvernon/change-close-session-usage into 8822c1d650f0ab68c8ad448e579e89e8b8df52c1 on master.

There are no EOF errors in the logs from the test now with this added.
$ grep -r "EOF" /Users/ianvernon/Downloads/test_results-15
$


Add toHaveSomeMembers matcher

What
toHaveSomeMembers matcher

Why
https://github.com/mattphillips/jest-extended/issues/23

Notes
Housekeeping

[x] Unit tests
[x] Documentation is up to date
[x] No additional lint warnings
[x] Add yourself to contributors list (yarn contributor)

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #73   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          23     25    +2
  Lines         101    111   +10
  Branches       13     15    +2
=====================================
+ Hits          101    111   +10

Impacted Files
Coverage Δ

src/matchers/toHaveSomeMembers/predicate.js
100% <100%> (ø)

src/matchers/toHaveSomeMembers/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2c2b5...9f7a2ef. Read the comment docs.

Thanks @cactorium good job!


Implement AWS::Events::Rule

Adds support for Rules.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I had an idea for refactoring, but I don't want to implement it unless someone else thinks it's a good idea.
I could change this method:
https://github.com/Disciple153/aws-cloudformation-resource-providers-events/blob/9dce08313a05295943f5bdfacc02114974cc4b3d/aws-events-rule/src/main/java/software/amazon/events/rule/Translator.java#L89-L117
To look like this by overloading the add() methods:
static PutTargetsRequest translateToPutTargetsRequest(final ResourceModel model) {
  CompositeId compositeId = new CompositeId(model);

  ArrayList<Target> targets = new ArrayList<Target>();

  for (software.amazon.events.rule.Target target : model.getTargets()) {
    Target.Builder targetBuilder = Target.builder();

    add(targetBuilder, target.getBatchParameters());
    add(targetBuilder, target.getDeadLetterConfig());
    add(targetBuilder, target.getEcsParameters());
    add(targetBuilder, target.getHttpParameters());
    add(targetBuilder, target.getInputTransformer());
    add(targetBuilder, target.getKinesisParameters());
    add(targetBuilder, target.getRedshiftDataParameters());
    add(targetBuilder, target.getRetryPolicy());
    add(targetBuilder, target.getRunCommandParameters());
    add(targetBuilder, target.getSqsParameters());
    add(targetBuilder, target.getSageMakerPipelineParameters());

    targets.add(targetBuilder
            .arn(target.getArn())
            .id(target.getId())
            .input(target.getInput())
            .inputPath(target.getInputPath())
            .roleArn(target.getRoleArn())
            .build()
    );
  }

  return PutTargetsRequest.builder()
          .eventBusName(compositeId.eventBusName)
          .rule(compositeId.ruleName)
          .targets(targets)
          .build();
}

I think this looks more readable and usable, but I am concerned that finding the appropriate method may be too difficult (without using find implementation).


Add Multiple Providers per Facility

WHY?
Our app is limited to one provider per facility at the moment and that is not reflective of how our facilities actually work. We'd like to allow facilities to have multiple providers so that in a follow-on story we can select the proper provider or orderer of the test on each test card.
AS A user of SimpleReport
I WANT the ability to add multiple providers to my facility
SO THAT I can eventually specify the correct test orderer on each test in SR
GIVEN I am on the 'manage facilities' section of the application for a specific facility
WHEN I scroll down to the 'ordering provider' section
THEN I have the ability to add multiple providers

do ordering providers 'float' between facilities. Should they be recorded at the org or facility level?

@lg-king @vz3 do we have any background context/research on this story?

No, I suspect this originated from support requests


Checksums files update main 3f6dda3163faa55f42d1826f44bbc0ae88c9a316

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rebase of: https://github.com/aws/eks-anywhere-build-tooling/pull/2244


gpg: cannot open tty `/dev/tty'

I am trying to run this inside a docker image. I am getting the following message
gpg: cannot open tty '/dev/tty': No such device or address

You need to run it in batch mode


Wrong type used for price amounts

Payment uses float to store the amount, which is a rather unfortunate choice. How about using amount in cents as integer, or string or proper money object, because even integers are vulnerable to e.g. overflowing (in theory, that is)?
Btw GoPay docs says to send amounts in cents, but this package seems to expect crowns, which is not really documented. I was surprised when the gateway asked for 50k when I just wanted five hundred 😄

Well, I agree. 😃
Could you prepare PR with some changes?

Sure. What do you think would be the best approach? To kill both birds with one stone, I'd go for amount in cents as integer, but that would obviously be a huge BC break 😟 string, on the other hand, would require some math library, because the item price is multiplied by its quantity at some point

This got me too. I would stick to the documentation = cents, integer. Differences make for surprises. But yes, BC is an issue => no simple solution.

Personally I would like to have a Money object. We can prepare it for v2.0. Could you do that guys? @jiripudil @BayerMeister ?

I could look into it and remove all occurrences of * 100 multiplications and rounding. I'm not feeling like adding a custom Money object while there are solutions like https://github.com/moneyphp/money, but adding a new dependency doesn't seem to be a fit either.

I think we can include moneyphp?

Should I keep it in style without return type hints and with annotations?


Test StateEvent Timestamp for Splinter 0.5 support

StateEvent timestamps were updated, but the new version should be backwards-compatible. We should test to ensure that nothing goes wrong with StateEvent handling with Splinter 0.5

This issue has been split into separate tasks around testing Grid with Splinter 0.5, here: https://github.com/hyperledger/grid/issues/731, and here: https://github.com/hyperledger/grid/issues/938


Nested slider is not working in loop mode

Check that this is really a bug

[X] I confirm

Reproduction link
https://stackblitz.com/edit/vue-j4w3xb?file=src/components/VueSlider.vue
Bug description
Nested slider is not working in loop mode. It seems like nested slider completely turns off if you use loop mode on main slider.
Expected Behavior
Nested slider is fully working in loop mode. You can swipe it, use navigation and etc.
Actual Behavior
No response
Swiper version
9.2.4
Platform/Target and Browser Versions
macOS Chrome 112.0.5615.137
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Look for issues on your side https://codesandbox.io/p/sandbox/swiper-default-forked-6pemeo

I've checked your example and there is an issue so. Try to click on navigation in looped nested slider. It's not working. And yet I can't use init="true" attribute on sliders, 'cause there will be a hydration error if you use SSR. So I initialize swiper in mounted hook only and looped slides still not working


Vulnerability roundup 83: aspell-<IP_ADDRESS>: 1 advisory

search, files

[x] CVE-2019-20433 CVSSv3=9.1 (nixos-19.09)

Scanned versions: nixos-19.09: c49da6435f3. May contain false positives.

See also: #73616

The upstream advisory mentions the fix could break some apps, so I suggest a proper version bump on stable. http://aspell.net/buffer-overread-ucs.txt

@ckauhaus this issue is still valid

Oops sorry

CVE-2019-20433: Fixed at version 0.60.8 (nixos-19.09, nixos-20.03, nixos-unstable).


Curl scripts that point to published packages on PyPI

@burtbiel, @johanste, @tjprescott, @yugangw-msft
The scripts allow curl installation from the packages published on PyPI.
The scripts I'm adding are similar to the ones here, https://github.com/Azure/azure-cli/tree/master/scripts/install, except that I've removed the ability to point to a private pypi server.

Is there any way to factor out the common code between these two?

If we move some shared code to another file, it'll be another script that has to be downloaded during the install process which wouldn't be ideal.

:shipit:


Inomurko/latest tag+develop

Codecov Report

Merging #33 (b5101e6) into develop (1c1b03f) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head b5101e6 differs from pull request most recent head 082a195. Consider uploading reports for the commit 082a195 to get more accurate results

@@           Coverage Diff            @@
##           develop      #33   +/-   ##
========================================
  Coverage    80.55%   80.55%
========================================
  Files           49       49
  Lines         1934     1934
  Branches       311      311
========================================
  Hits          1558     1558
  Misses         376      376

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1b03f...082a195. Read the comment docs.

Looks good to me!

CONTAINER ID   IMAGE                              COMMAND                  CREATED         STATUS         PORTS                                                                     NAMES
8f7ebbc1ea7c   omgx/batch-submitter:latest        "./batches.sh"           4 minutes ago   Up 4 minutes                                                                             integration_batch_submitter_1
0925ff2e09ca   omgx/data-transport-layer:latest   "./dtl.sh"               4 minutes ago   Up 4 minutes   <IP_ADDRESS>:7878->7878/tcp, :::7878->7878/tcp                                 integration_dtl_1
da50cd215b00   omgx/wallet_deployer               "./scripts/wait-for-…"      4 minutes ago   Up 4 minutes   <IP_ADDRESS>:9545->8545/tcp, :::9545->8545/tcp

Looks good to me - an alternative design could have been a second deployer, i.e. /packages/omgx/contracts, where contracts contains, tests, and deploys the omgx contracts, and tests those contracts, rather than a wallet-specific second deployer. But this works, too.

Yep, that was the initial plan, but the message Relayer fast was still in flight when this work started.
we can easily consolidate in the subsequent PR.


Porous media inquiry

Dear lettucers,
Would it be feasible to run a single-phase flow through a porous medium using the current implementation?
Something like this:
https://github.com/je-santos/MPLBM-UT/tree/master/examples/singlephase_and_tortuosity_DRPcarbonate
Thanks a lot for this project, it's pretty sweet

:-) Thanks
Yes, that's certainly feasible. I've added a prototypical notebook to a new porous branch: https://github.com/lettucecfd/lettuce/blob/porous/examples/porous_medium.ipynb

Thank you very much for the fast turn-around. This looks great!

No problem.
You probably have to worry a bit about defining the units correctly. I am not super familiar with porous media - so what I've put into the notebook is pretty ad hoc to just get a minimal example to run.
We usually define Ma and Re. In an incompressible setting, Ma is a purely numerical parameter. But you need to probably define your lattice unit system from the pressure drop.
If you happen to work out a more sophisticated version of this flow, please share - I'd be happy to merge a version with consistent units, permeability computation, etc. into our master branch :-)

I am happy to provide an example to the community. I'm wondering, in your experience, what would be the maximum domain size that lettuce could work on in a standard GPU (let's say 24 Gb)?

2D or 3D?

I am mainly interested in 3D flows. But it would be useful to know the
limitations of both.
On Fri, Dec 3, 2021 at 8:11 AM Andreas Krämer @.***>
wrote:

2D or 3D?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lettucecfd/lettuce/issues/97#issuecomment-985597726,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKBKSO2VAPHJXTBYD6JR3TTUPDMY5ANCNFSM5JIMC35A
.

--
Javier E. Santos
Graduate Research Assistant and Digital Rock Curator
The University of Texas at Austin
GoogleScholar
https://scholar.google.com/citations?user=NxRn0-IAAAAJ&hl=en&authuser=1 |
ResearchGate https://www.researchgate.net/profile/Javier-E-Santos |
LinkedIn https://www.linkedin.com/in/je-santos | GitHub
https://github.com/je-santos

I am not entirely sure but in 3D it's quite limited (we have a prototypical MPI implementation though that's not part of the main branch, yet).
In 2D I can do resolutions of ~5000x10000 in double precision on my 24GB card.
@McBs do you know the exact limitations in 3D?

Hey,
running a basic flow (D3Q27) without any reporter or boundary masks I can run
~220³ in single precision
~170³ in double precision
on my RTX2070S (8GB)

This is pretty good.
Do you run into any problems when simulating on single precision?
I'm guessing that half precision won't work, but I can try.
Thanks a lot to both of you for your responses. This is very helpful.

 In my experience, single precision is not very reliable either. But I've mostly looked at high-Re flows.

Sorry, I didn't see your messages yesterday. My house stuff was single precision 360 * 240 * 180 on one V100 (I think 16 GB) but using the KBC collision model, which currently uses a lot more RAM than BGK


Sample Images in Demo do not Load when using VPN

When connected to VPN, sample images from placehold.it do not load. Suggested to load these locally

Fixed inadvertently in #50, images are no longer previewed on blog page with new UI layout

Fixed inadvertently in #50, images are no longer previewed on blog page with new UI layout


Updated DynmapWebChatEvent with stuff for new event system

Hey I've written a dynmap plugin to connect dynmap's webchat with CraftIRC.  With the new event system, some additions to DynmapWebChatEvent were necessary for my plugin to work.  I followed this guide:
http://wiki.bukkit.org/Introduction_to_the_New_Event_System
Near the bottom it explains how to create custom events properly, so I just updated the webchat event according to what the guide said.

This looks good - I will not be pulling it for at least a week or so, as we are not yet breaking support for 1.0.x (1.1-R1 is just too new to assume everyone has moved to it).  I expect do expect our 0.31 release to be 1.1-R1 specific

0.33 has this now - thanks!


Add Popout Component

This pull request includes significant updates to the frontend/src directory, focusing on enhancing the App component and its associated tests, adding new components, and updating styles. The most important changes include the restructuring of the App component, the introduction of the PopOut component, and the addition of Tailwind CSS for styling.
Restructuring and enhancement of the App component:

frontend/src/App.js: Refactored the App component to use new child components (PopOut, GetInTouch, ExpandedFooter, and Footer) and removed the default content. The App component is now exported directly.

Updates to tests:

frontend/src/App.test.js: Updated tests to mock the new child components and added new test cases to verify the layout structure and rendering order of the components.

Addition of new components:

frontend/src/components/popout/PopOut.jsx: Added the PopOut component, which includes a styled div with text and a button.

Styling updates:

frontend/src/index.css: Integrated Tailwind CSS by importing its base, components, and utilities. Updated the root and body styles to use the default font family and ensure full height and width.

Multiple reviews requested over course of over a month.  Bypassing protections and merging this in without review atp.


Comparison to the fallible_collections crate

Hi,
I've been loosely following the vec_fallible_allocation RFC and saw you closed the RFC and published this crate.
I've previously encountered (but not used) the fallible_collections crate.
Would it be possible to add a section to the Readme comparing this crate with the fallible_collections crate (well, probably only the Vec portion of it). The exposed API seems to be quite similar, so I'm wondering what the main differences are.

Great idea!
I'll change the readme with more details, but to summarize: this crate is specifically designed for situations where #[cfg(no_global_oom_handling)] is enabled: other crates like fallible_collections won't work in those environments as they call methods like push in their implementations, which don't exist when that cfg is enabled.


Clean-up work after VTR upgrade

Is your feature request related to a problem? Please describe.
As described in #747 , there are some unfinished tasks in the PR, but it is blocking the PR to be merged.
However, they are mainly some clean-up work:

[ ] Upgrade docker support for Ubuntu 20.04 or latest image. Prefer 20.04 as it is a current Long-Term Support version. Ubuntu 18.04 is no longer supported (no maintainance) on github-hosted machines.
[ ] Apply code format on CI to

[ ] C/C++ codes except submodules
[ ] XML codes
[ ] Python codes

[ ] Enable debug build on CI
[ ] Enable no-warning build on CI
[ ] Clean-up regression test errors in VTR feature branch
[ ] Set up dependabot for vtr submodule

Describe the solution you'd like
Finish the clean-up work in a few follow-up PRs.

Consider to use an online configurator to visualize the clang-format file
https://zed0.co.uk/clang-format-configurator/

XML Formatting Considerations
Principles

Consider to use xmllint as suggested by @ganeshgore
Code formatting only applied to architecture files and related input files for OpenFPGA flows, excluding all the submodules, e.g., vtr-verilog-to-routing etc.
Code formatting can be automatically done by calling a make target using the top-level makefile, e.g., make format_xml
Code formatting check is forced on CI. Any PR to be merged to master branch should pass this test. No exception is allowed

What format to choose

@tangxifan prefer the following style

Set Indent width and tab width to be 2
Never allow tabs
Comments should be wrapped with a fixed number of characters each line

Python Formatting Considerations
Principles

Consider to use pylint
Code formatting only applied to architecture files and related input files for OpenFPGA flows, excluding all the submodules, e.g., vtr-verilog-to-routing etc.
Code formatting can be automatically done by calling a make target using the top-level makefile, e.g., make format_py
Code formatting check is forced on CI. Any PR to be merged to master branch should pass this test. No exception is allowed

What format to choose

@tangxifan prefer the following style

Set Indent width and tab width to be 2
Never allow tabs
Comments should be wrapped with a fixed number of characters each line

@ganeshgore Please suggest the python code format from your point of view.


metadata: wikipedia.py: Now returns empty dict in case error occurs

Update: Added .travis.yml file in the dev branch

@manu-chroma Sorry, this PR fell between the cracks.
I see that the build is failing for this. Do you still want me to accept this?

@kylepjohnson this branch didn't have a .travis.yaml file initially. (Reason for initial build fail)
Now, the tests because of which the build is failing are for a different feature and not this one.
Here's a snippet from the build log.
Traceback (most recent call last):
  File "/home/travis/build/cltk/cltk_api/tests.py", line 102, in test_pos_latin_ngram123
    self.assertEqual(response.status, '200 OK')
AssertionError: '500 INTERNAL SERVER ERROR' != '200 OK'
- 500 INTERNAL SERVER ERROR
+ 200 OK

I think it's safe to merge this PR. :smile:

Ok, thanks for this. Please keep an eye on the build and make any necessary fixes should this not go right :)

https://travis-ci.org/cltk/cltk_api/builds/120478780

@kylepjohnson https://github.com/cltk/cltk_api/blob/feature/expose_cltk_core/tests.py#L84
This test is failing.
I'll try running tests locally and see if I can fix it.


Release: 0.8.0

This issue template is used to track the rollout of a new KEDA HTTP add-on version.
For the full release process, we recommend reading this document.
Required items

[x] https://github.com/kedacore/http-add-on/pull/961
[x] https://github.com/kedacore/http-add-on/issues/968
[x] https://github.com/kedacore/http-add-on/issues/958
[x] https://github.com/kedacore/http-add-on/issues/910
[ ] https://github.com/kedacore/http-add-on/pull/991

Nice to have

[ ] https://github.com/kedacore/http-add-on/issues/907

Timeline
We aim to release this release in the week of (pending yet)
Progress

[ ] Add the new version to GitHub Bug report template
[ ] Create KEDA release
[ ] Prepare & ship Helm chart
[ ] Publish on Artifact Hub (repo)
[ ] Provide update in Slack
[ ] Tweet about new release

Hey @JorTurFer, will  initialCooldownPeriod  be added to the HTTPScaledObject crd ?

Hey @JorTurFer, will initialCooldownPeriod be added to the HTTPScaledObject crd ?

I didn't have it in mind as now you can use your external managed ScaledObject where you have the full control about the config attached to an HTTPScaledObject.
Is it something that you would need? If yes, are you willing to open a PR supporting it? I plan to cut the release this week, but it can be included in the next one if the feature is not available before the release

Thank you, was unaware of this. will checkout the link to the doc. If it does not solve things, will open a PR surely.

Thank you, was unaware of this. will checkout the link to the doc. If it does not solve things, will open a PR surely.

This feature will be released with v0.8.0. To check what is and what isn't part of the specific version CRD, I suggest checking the ref folder: https://github.com/kedacore/http-add-on/tree/main/docs/ref. That section is the only versioned information that we have yet

HTTP Add-on v0.8.0 is out! :shipit: 🚀


Make it possible to tell SSR (and prerendering) when a page is ready

Describe the problem
When using {await ...}-blocks in templates while server side rendering or pre-rendering, the resulting page will contain the intermediate "Loading..." content that gets rendered while the promise is resolving.
This makes it impossible to generate correct (finished) pre-rendered content that contains {await ...}-blocks and makes SSRed pages contain unresolved content.
Describe the proposed solution
Routify solved it like this.
I can't really see a better way of dealing with it, except perhaps a load function for components (with a default implementation that returns a resolved promise) that can inform the page about when it's ready.
Alternatives considered
Don't use {await ...} in templates and instead load all your data in +page.js.  This becomes particularly difficult (unfeasible) when your {await ...}-blocks are in components.
Importance
would make my life easier
Additional Information
Discussion leading up to this issue

$ready sounds pretty cool but i wonder why you can´t use load in +page.js?

$ready sounds pretty cool but i wonder why you can´t use load in +page.js?

This would mostly be a problem when awaiting content on components not pages.

This needs support inside Svelte chore. We would need to be able to have a streaming/async SSR render method, and we would need to be able to tell Svelte that it should await a promise before resolving the rendering.

Going to close this as it's ultimately a Svelte issue (rather than SvelteKit) that may or may not get addressed — giving components the power to delay rendering is a decision we would need to take very carefully, as it is often a footgun — coordinating async work in load is less convenient in the moment but will typically yield better outcomes. Remains to be seen if we rethink our stance on this for future Svelte versions.
For posterity, the workaround in the Discord conversation was to make creative use of transformPageChunk

Not really something I have had problems with, but what about pre-rendered pages? It is now not possible to render correct (finished) pre-rendered pages with {await...}-blocks in them.

This is a Svelte-core issue which we plan to look at to skip the pending block and resolve directly to the then or catch block, if possible

Alright, thanks!
Is this anything I can read about somewhere? (maybe I can help push it forward or something)


Project Liger (New CMS) requires a second DB to allow for their preview/publish model.

Why are we not using RDS?
Also, why are is two db needed like this?

Discussed with developer, opted for singular RDS cluster


orienteer-graph deletes vertex when removing link edge

orienteer-graph deletes vertex when removing link edge but must removed only edge.

All works fine


[fix] update path resolution to npm

Hi, I liked this module and would like to utilize this in some of my codebases, sending PR to enhance couple of behavior.

resolve root path via app-root-path, provides platform compatible path
: Usually for Windows user who runs different shells will have issues by determining root via git can returns shell-specific path like \c\apps\myapp.... instead, introduced app-root-path (https://github.com/inxilpro/node-app-root-path) to resolve root path to application.

fixes npm-which invocation to correctly resolves npm
one thing I noticed is this module calls npm-which with name of linter as npmWhich(linter,...) which causes npm-which fails all time since npm-which expects file to lookup (npm, in this case). Updated to lookup npm, leave fallback to default binPath as-is.

Thanks for the PR! I didn't know about app-root-path. Nice!
Regarding the npmWhich change: with this change it won't work without having all tasks set explicitly in scripts section. I think for most users this is an overkill. See also #17. I'm writing tests now that will cover all the edge cases.
Would you mind splitting the PR to 2. I would merge the app-root one right now.

I think for most users this is an overkill. See also #17. I'm writing tests now that will cover all the edge cases.

: that makes sense. Let me separate PR and dig npm-which bit more. It'd be great to have coverage to ensure no regressions.

I've amended this PR for including app-root-path only as suggested.

Awesome! I'll review and merge soon.


Update to<EMAIL_ADDRESS>

The blueprinted files that changed upstream have already been overridden, so the only change is for package.json.

:+1:


[v2 cherrypicking] Undeploy error

What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

Merging this PR since it is a Cherrypick to v2.

Please use the /cherrypick plugin to create PR. Mainly because manual merging is a bad idea, IMO.
All you need to do on the original PR is make this comment - /cherrypick v2. Don't put in code blocks.

See https://github.com/redhat-developer/odo/pull/5315#issuecomment-1016087780 for reference.

@valaparthvi please also link the related PR that went into master so we have a record that it was merged into both branches.

Please use the /cherrypick plugin to create PR. Mainly because manual merging is a bad idea, IMO.
All you need to do on the original PR is make this comment - /cherrypick v2. Don't put in code blocks.

Idk why, but I remember someone mentioned that cherry-picking with /cherrypick was not working, which is why I manually created this PR and merged it.

Idk why, but I remember someone mentioned that cherry-picking with /cherrypick was not working, which is why I manually created this PR and merged it.

https://kubernetes.slack.com/archives/C01D6L2NUAG/p1642491094015100?
I opened https://github.com/openshift/release/pull/25382 afterwards to sort it out.


Window title updates with opened file name only after window resize

VSCode Version: any recent stable/insiders
OS Version: Windows 7 64bit

Steps to Reproduce:

Open any file
The window title will remain unchanged until you resize or min-max the window

Reproduces without extensions: Yes/No

I can not reproduce this.
On what OS are you?
Can you also reproduce with latest vscode insiders https://code.visualstudio.com/insiders/

There are many reported issues around the title not being up to date but I never found out what the cause of this is. Very likely an electron issue though if resizing fixes it.

@isidorn , I have updated the issue comment

@mtsh1000 please answer my other question, can you reproduce with latest vscode insiders

Yes

This is indeed electron bug https://github.com/electron/electron/issues/10897

@mtsh1000 Can you please file this one against electron then please?

https://github.com/Microsoft/vscode/issues/31536


 It was a rebasing spagetti nigthmare as I decided to start from the apizr branch instead of the main one. It gives that over commiting git log, but actually brings no other changes than the Dynamic Querystring Parameters feature implementation, plus some specific Apizr code adjustments.
I think I really need holidays :)
That said, the main change here to reach our goal as discussed into #417 is about the ParameterExtractor.
When the threshold is set to 2 or more, it now returns the filtered parameters to be added to the method, plus the query params types to be created under interfaces.
It works with or without Apizr as it has no dependency with it.
It comes with many new tests to cover it and an updated documentation.
It's once again a big fat fish to descover, understand and test before merging.
Again, sorry about my git rebase marmelade gift ^^

here are most of your suggestions implemented.
But about the #nullable enable directive, I'm quite confused.
First of all, my query wrappers are generated into the same namespace as the interfaces so the #nullable enable directive added by RefitGenerator should apply when it's there.
IMHO, the problem comes from the ? suffixing optional types and depending on openapi definition, where the #nullable enable directive depends on settings.OptionalParameters to true.
It means that we could have code with ? symbol because of openapi def, but no #nullable enable directive because of settings.OptionalParameters set to false.
This is exactly what I get if I run refitter CLI from its latest stable public version with a command like:
refitter https://petstore3.swagger.io/api/v3/openapi.yaml

Again I'm a bit tired the day before my holidays, so I could missunderstand something here.
In my opinion, we should add #nullable enable directive only based on ? check in code, and not on OptionalParameters which is here to reorder et set default value to parameters.
Or maybe, allways add #nullable enable directive from RefitGenerator, no matter of any condition.

Or maybe, allways add #nullable enable directive from RefitGenerator, no matter of any condition.

You have a point @JeremyBP, and with that in mind, I think that always adding #nullable enable would be the ideal solution

Here is our nullable enable 👼
That said, I think I'm done with query feature.
If not, today is my last day at the office so the last chance to change things, otherwise feel free to adjust what needs to be when you're back 👍

Thanks for this awesome contribution @JeremyBP
Enjoy your well-deserved summer holiday!


Make challenge composition granularly configurable

This PR adds INSTALL_* variables for almost every piece of a container, allowing us to enable and disable them granularly. The inspiration was angr-management not shipping for and the kernel not compiling under ubuntu 23.04.

Migration note: this changes INSTALL_IDA=True to INSTALL_IDA=yes, because these variables need to go into intermediate docker targets, and those can't have uppercase names. The problem is, if not updated manually in config.env, every previous installation of the dojo will fail to build the challenge container until INSTALL_IDA is updated. We can mitigate this somewhat by moving to INSTALL_IDA_FREE and deprecating INSTALL_IDA: then the failure mode would just be a missing IDA instead of a build failure. Thoughts?

Okay, so the TLDR:

the PR works
the CI challenge is set to challenge-mini (because otherwise, due to the overlay bug, the CI runs out of disk space)
non-mini challenge configurations would have failed on CI for the same reason before this change

I think we should merge this, because it's a big changeset to maintain. The layering bug affects us anyways, so there's no regression.

Looks good to me, are we ready to merge?


lib does not exist

The tests are not runnable, lib is not found.
https://github.com/nervosnetwork/ckb-sdk-js/blob/develop/packages/ckb-sdk-address/__tests__/ckb-sdk-address.test.js#L1
const Address = require('../lib').default

please build this module by tsc first, after that the lib will be generated in the ckb-sdk-address.

BTW, this module depends on ckb-sdk-utils module, so it's better to build them all by npm run tsc at the root dir.

Yes, I got the lib module, thanks!

If I run the tsc in the root, I got errors:
$ npm run tsc                           ✹ ✭develop ‹system›

> ckb-sdk-js@ tsc /Users/nervos/testnet/ckb-sdk-js
> lerna run tsc

lerna notice cli v3.14.1
lerna info Executing command in 5 packages: "npm run tsc"
lerna ERR! npm run tsc exited 2 in '@nervosnetwork/ckb-sdk-utils'
lerna ERR! npm run tsc stdout:

><EMAIL_ADDRESS>tsc /Users/nervos/testnet/ckb-sdk-js/packages/ckb-sdk-utils
> tsc

error TS2688: Cannot find type definition file for '@nervosnetwork/ckb-types'.

lerna ERR! npm run tsc stderr:
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>tsc: `tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>tsc script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

If I run the tsc in the root, I got errors:
$ npm run tsc                           ✹ ✭develop ‹system›

> ckb-sdk-js@ tsc /Users/nervos/testnet/ckb-sdk-js
> lerna run tsc

lerna notice cli v3.14.1
lerna info Executing command in 5 packages: "npm run tsc"
lerna ERR! npm run tsc exited 2 in '@nervosnetwork/ckb-sdk-utils'
lerna ERR! npm run tsc stdout:

><EMAIL_ADDRESS>tsc /Users/nervos/testnet/ckb-sdk-js/packages/ckb-sdk-utils
> tsc

error TS2688: Cannot find type definition file for '@nervosnetwork/ckb-types'.

lerna ERR! npm run tsc stderr:
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>tsc: `tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>tsc script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

Sorry for that, this project uses lerna for packages management, which need to be bootstrapped by the following steps.
$ yarn install # to install the lerna package in this project, could be skipped if the lerna has been installed globally
$ lerna bootstrap # install the depedencies and link the packages in the project
$ npm run tsc # build packages with tsc command

Let's add the detail bootstrap description to the doc. @Keith-CY

Success after run lerna bootstrap

Let's add the detail bootstrap description to the doc. @Keith-CY

Sure


Merge python-app.yml and tests.yml?

We could merge those files and add cron schedule to python-app.yml to maintain one instead of two files. @mathdugre

Yes, I totally agree that we can merge those.
Eventually, we might want to separate the linting in a different action to only run on push and include more linting via pre-commit. Similar to livingpark-utils' linting. What do you think @yohanchatelain ?


Build error when multiDexEnabled true

Steps to Reproduce
Enable multiDex in android/app/build.gradle (multiDexEnabled true)
then
react-native run-android
Expected Behavior
No build errors
Actual Behavior
FAILURE: Build failed with an exception.
What went wrong: Execution failed for task ':app:transformClassesWithMultidexlistForDebug'.
com.android.build.api.transform.TransformException: Error while generating the main dex list:
Error while merging dex archives: Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.
Program type already present: co.apptailor.googlesignin.BuildConfig
or sometimes:
Program type already present: co.apptailor.googlesignin.PendingAuthRecovery
Environment
Please provide

react-native version 0.61.2
@react-native-community/google-signin version 3.0.1
Gradle 5.5
googlePlayServicesAuthVersion = "16.0.1"

Hi there! Sorry you're having an issue. As the issue template explains, we require that you provide a runnable example (please try reproducing the bug with our example app) that reproduces the bug in a github repository. Please try to minimize the superfluous code and focus only on reproducing the bug.
please create a new issue with this and we'll be happy to review it!


Feature Request: Allow additional query types for variables

Is your feature request related to a problem? Please describe.
It would be nice to be able to have an ability to query host list with hosts that have specific application
Describe the solution you'd like
Allow {$group}{*}{$application} query for variables.
This query type should pass applicationids to hosts.get method
Describe alternatives you've considered
None, passing applicationids is the easiest to implement

It would be very useful to also be able to find groups that interject multiple groups. For example, I have a group for all hosts on a site which it may have switches, those switches are also in the switches group. Well with something like this I would be able to show only the sites that have switches in them. I guess that this also would be possible if we could filter groups which contain host that match a regex.


[TEST: Suggested formatting improvements]: for README.md for better readability

This PR suggests formatting improvements for the file.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/what-are-tabs.md
91
3
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


ptrace: attach to all threads

Address #762 on Linux. The issue should not be closed as the problem still requires investigation on Windows.

I'd be glad to receive some feedback on the error handling. There are lots of situations when smth can go wrong during attach or detach. I tried to limit the consequences for the process we attach to without making the code too complex.

We could make things more stable with this approach described on SO:

Call SIGSTOP on pid, this should stop the whole process group
Wait until pid is stopped (what parameters to pass to waitpid)?
Read threads from /proc/pid/task: they are all stopped so the view is consistent
Attach to every tid. If it fails something is wrong and we should dispose early and throw

Then on Dispose we do:

Detach from every tid we attached to
Call SIGCONT on pid
Wait until pid is started again

However in my tests when I SIGSTOP the test program from another terminal window, it goes to jobs as Stopped. Then the SIGCONT doesn't wake it up until I use fg in the original window where I ran the program... The stopped state is reported in htop. So I'm cautious to risk the app being hanged this way.

@leculver could you please give some feedback on the PR?

Sorry I have been out sick for the last week, but I did not set a github away message.  I will take a look on Monday.  Either way I probably need to do some testing here.


Support Thrift custom protocol

To add a new Thrift protocol, user is expected to

add a new SerializationFormat
declare another SerializationFormatProvider via SPI that exposes it
declare another ThriftProtocolFactoryProvider via SPI that links it to a TProtocolFactory

I realize that classes that are not internal should stay binary compatible. Restoring what can be

Build failure was caused by npm
Caused by: org.gradle.process.internal.ExecException: Process 'command '/appveyor/projects/armeria/site/.gradle/npm/npm-v6.14.5/bin/npm'' finished with non-zero exit value 1

Can it be ignored?

Can it be ignored?

Sorry about it. Yeah we can ignore that. 😄

Thank you all reviewers. Anything else you'd rather see fixed before merge?

I would have shared it with you 2 monthes ago ;) We are using custom thrift protocols (2 different ones, actually) in our flagship backend application


chore: Update test, build, and watch to use node scripts

Migrate the test and build scripts to node for maintainability and functionality.
Testing instructions
Updated build

npm run build: Builds all components (pfe-sass is pre-built first separately), does not build storybook
npm run build pfe-card: Builds pfe-card only (pfe-sass is built first), does not build storybook
npm run build pfe-card pfe-sass: Builds pfe-card only (pfe-sass is built first), does not build storybook
npm run build pfe-sass: Builds only pfe-sass, does not build storybook
npm run build -- --storybook or npm run build -- -s: Builds all components and the storybook instance
npm run build -- --help: Lists out all the commands available
npm run build foo: Throws an error: No component directory found for: foo
npm run build card: Builds pfe-card
npm run build foo card: Throws error on foo but builds pfe-card.

Updated tests

npm test: Builds and tests all components
npm test pfe-card: Tests pfe-card only (runs the build first)
npm test pfe-card pfe-band: Tests pfe-card and pfe-band (runs the build first)
npm test -- --nobuild or npm test -- -nb: Tests all components but does not build first
npm test -- --help: Lists out all the commands available

Updated watch

npm run watch: Watch all components (pfe-sass is pre-built first separately), does not build storybook
npm run watch pfe-card: Watch pfe-card only (pfe-sass is built first), does not build storybook
npm run watch pfe-card pfe-sass: Watch pfe-card only (pfe-sass is built first), does not build storybook
npm run watch pfe-sass: Watch only pfe-sass, does not build storybook
npm run watch -- --build or npm run watch -- -b: Build & then watch all components
npm run watch -- --storybook or npm run watch -- -s: Watch all components and the storybook instance
npm run watch -- --help: Lists out all the commands available

Ready-for-merge Checklist
Check off items as they are completed.  Feel free to delete items if they are not applicable.

[x] Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
[x] Tests have been updated to cover these changes.
[x] Repository compiles and tests pass.
[x] Changelog updated (not needed for documentation updates).
[x] Documentation (README.md, WHY.md, etc.) updated or added.
[ ] Link to the demo recording:

Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the<EMAIL_ADDRESS>mailing list!

@zhawkins Updated based on code review feedback!


Compilation error in file lib/types/date.ex

Generated timex app
==> timex_ecto
Compiling 8 files (.ex)
== Compilation error in file lib/types/date.ex ==
** (CompileError) lib/types/date.ex:58: Ecto.Date.struct/0 is undefined, cannot expand struct Ecto.Date
lib/types/date.ex:58: (module)
could not compile dependency :timex_ecto, "mix compile" failed. You can recompile this dependency with "mix deps.compile timex_ecto", update it with "mix deps.update timex_ecto" or clean it with "mix deps.clean timex_ecto"

Same error in another file

== Compilation error in file lib/types/timestamptz.ex ==
** (CompileError) lib/types/timestamptz.ex:5: module Timex is not loaded and could not be found
    (elixir) expanding macro: Kernel.use/1
    lib/types/timestamptz.ex:5: Timex.Ecto.TimestampWithTimezone (module)

Cannot reproduce with the latest version and Elixir 1.9. The latter error appears to be due to Timex not being loaded at all for some reason.


Abstract active layer evaluation away from the Widget Filter

As it is, the WidgetFilter is very bloated.
This pull requests adds no new functionality, but instead abstracts the layer evaluation logic away from the WidgetFilter.
This allows developers to override the default functionality for retrieving/ evaluating layers during a request, without the need to override the entire widget filter.
This would be useful in the following cases:

To create an implementation that logged to Glimpse
To create an implementation that took the layer rules from a cache (a major performance gain on a site with several layers)
To create an implementation that would evaluate each layer only once per request, no matter how many times the call the get the active layers was made (for example to create an output cache key etc...)

Work Item: https://github.com/OrchardCMS/Orchard/issues/5356

+1

:+1: X :100:

I like the change

Question- if the call to GetActiveLayerIds is called multiple times during a single request, would it be acceptable to assume that the same Layer IDs would be returned each time?
If so, I should probably update this PR to ensure that the evaluation logic can only be executed once per request.
The only examples I could think of where this would not be the case would be if someone had wrote an IRuleProvider that would only return true the first time it was executed per request, or an implementation that would differ based on the value of a small measure of time (eg ticks etc...).
Would it be acceptable to make this proposed change to the PR given the caveat above?


Release candidate for DockerHub monitoring and UI iteration 1

Prepare release candidate for testing by staking + update documentation

When tackling this issue we need to perform the following:
Documentation:

Read and update the existing README.md so that it includes mentioning dockerhub and the UI
Read and update the UI documentation to confirm that it is up to date
Include DockerHub monitoring in the Design_and_features.md alerting section and architecture design image. It is best to read the entire docs to make sure that it still makes sense.

Deploy:
When the above is ready we should ask the staking team for a vm so that we run a release candidate for them to review.

We also need to make sure to update PANIC UI to be in-line with the latest UI Kit version since there will be breaking changes with the new release.

@Cherrett Another thing we need to check is the API and UI security vulnerabilities which can be solved via npm audit fix.


Leading space in short label not shown

See attached xml file from Slovene DAB ensemble R1.
Some services have a leading space in the short label, but this is not shown.
2023-09-12_005137_10D.zip
FICDecoder: EId 0x9200: ensemble label 'SLO DAB+ R1' ('SLO R1')
FICDecoder: SId 0x9203: programme service label 'ARS' ('ARS')
FICDecoder: SId 0x9201: programme service label 'PRVI' ('PRVI')
FICDecoder: SId 0x9202: programme service label 'VAL 202' (' 202')
FICDecoder: SId 0x933A: programme service label 'Radio Si' ('Radio Si')
FICDecoder: SId 0x9414: programme service label 'Center Slo' ('Center S')
FICDecoder: SId 0x9516: programme service label 'Rock Radio Slo' ('Rock S')
FICDecoder: SId 0x932F: programme service label 'Radio Ognjisce' ('Ognjisce')
FICDecoder: SId 0x9442: programme service label 'Radio 1 DAB' (' 1 DAB')
FICDecoder: SId 0x9459: programme service label 'Radio 1 80-a' ('Ra 1 80')
FICDecoder: SId 0x9415: programme service label 'Radio City' (' City')
FICDecoder: SId 0x9440: programme service label 'Radio Student' ('Student')
FICDecoder: SId 0x9463: programme service label 'Radio Salomon' (' Salomon')
FICDecoder: SId 0x9449: programme service label 'Radio Veseljak' ('Veseljak')
FICDecoder: SId 0x942B: programme service label 'Radio Net FM' ('Net FM')
FICDecoder: SId 0x9462: programme service label 'Ekspres Slo' ('Eksp Slo')
FICDecoder: SId 0x941C: programme service label 'Radio Aktual' (' Aktual')

Other tools (here: dablin_gtk) show that, on the other hand.

Yes, I am trimming both service name and short name. Honestly I do not like that they are trying to get prominent position in service list by starting service/short name with space. Since most of the information is displayed using html technology keeping space at the beginning of short name will probably have no visible impact. Is it important to show that show name starts with space?

In Ensemble Information window it makes sense not to trim it, as you already quote it. Plan is to export this to FMLIST or similar.

This is what is actually transmitted for VAL 202 service:
	0x9202	'VAL 202         ' [ '1E00' ]   PTY: 09  (static) | charset 0x00 | NumComponents 1
		AudioComponent (primary), SCIdS: 0, Label: 'VAL 202         ' ['1E00'], ASCTy: 0x3F,
			SubChId: 1, Language: 38, StartCU: 96, NumCU: 102, EEP 3-A, Datarate: 136kbps, NumUserApps: 1
				UserApp 1/1: UAType: 0x2 [0C3C], X-PAD data: Type=12, DG=0, DSCTy=0x3C, Label: ''

1E00 is bitfield that means ' 202'
So why to keep leading space and remove trailing space? I am not sure about this issue.

They have changed the labels, btw.
The leading space is now only for 4 services.
Nov 10 21:33:44 FICDecoder: EId 0x9200: ensemble label 'SLO DAB+ R1' ('SLO R1')
Nov 10 21:33:44 FICDecoder: SId 0x9203: programme service label 'ARS' ('ARS')
Nov 10 21:33:44 FICDecoder: SId 0x9201: programme service label 'PRVI' ('PRVI')
Nov 10 21:33:44 FICDecoder: SId 0x9202: programme service label 'VAL 202' ('VAL 202')
Nov 10 21:33:44 FICDecoder: SId 0x933A: programme service label 'Radio Si' ('Radio Si')
Nov 10 21:33:44 FICDecoder: SId 0x9414: programme service label 'Center Slo' ('Center S')
Nov 10 21:33:44 FICDecoder: SId 0x9516: programme service label 'Rock Radio Slo' ('Rock S')
Nov 10 21:33:45 FICDecoder: SId 0x932F: programme service label 'Radio Ognjisce' ('Ognjisce')
Nov 10 21:33:45 FICDecoder: SId 0x9442: programme service label 'Radio 1 DAB' (' 1 DAB')
Nov 10 21:33:45 FICDecoder: SId 0x9459: programme service label 'Radio 1 80-a' ('Ra 1 80')
Nov 10 21:33:45 FICDecoder: SId 0x9415: programme service label 'Radio City' (' City')
Nov 10 21:33:45 FICDecoder: SId 0x9440: programme service label 'Radio Student' ('Student')
Nov 10 21:33:45 FICDecoder: SId 0x9463: programme service label 'Radio Salomon' (' Salomon')
Nov 10 21:33:45 FICDecoder: SId 0x9449: programme service label 'Radio Veseljak' ('Veseljak')
Nov 10 21:33:45 FICDecoder: SId 0x942B: programme service label 'Radio Net FM' ('Net FM')
Nov 10 21:33:45 FICDecoder: SId 0x9462: programme service label 'Ekspres Slo' ('Eksp Slo')
Nov 10 21:33:45 FICDecoder: SId 0x941C: programme service label 'Radio Aktual' (' Aktual')

The question is valid. I have tried to remove trimming but it will not help in ensemble view. I would have remove formatting and  display it in fixed font to visualise all spaces as they are (eg. trailing spaces in service label)

This is how it looks like when service labels are not trimmed and <pre> tag is used, I do not like it :-(

If this is HTML, why not replace each space with  ?

This is exactly what I do not want to do.

BTW
If the leading space is in the long label, then you see it in AbracaDABra.
https://www.rundfunkforum.de/download/file.php?id=18102&mode=view

Well, that surprises me too :-D
But looking at the related commit, it seem that I have changed the implementation in the way that I am removint trailing spaces not leading. But it does not look good in the service list to be honest :-(


%2F if specified in path is getting double encoded as %252F iresspective of  setting RestAssured.urlEncodingEnabled=false

From<EMAIL_ADDRESS>on June 27, 2012 09:20:47
What steps will reproduce the problem? RestAssured.urlEncodingEnabled=false
given().pathParam("pageUrl", "Product%2F1756%2FMilk-Bone-Flavor-Snacks-Biscuits-for-Dogs").
get("/findItem;pageUrl={pageUrl}")
OR
get("/findItem;pageUrl=Product%2F1756%2FMilk-Bone-Flavor-Snacks-Biscuits-for-Dogs;sortby=true;test=abc123")
The server is receiving the pageURl as "Product%252F1756%252FMilk-Bone-Flavor-Snacks-Biscuits-for-Dogs" .
you can clearly see %2F is getting double encoded as %252F.
if you use any of the above methods you can see when the pageUrl parameter passed to the server is double encoded. There is no way to pass a matrixparam to a rest service which contains "/" . if possible add support for matrixparam as well, so that  we will be able to test rest services which takes multiple matrixparam as input. What is the expected output? What do you see instead? i should have seen pageUrl=Product%2F1756%2FMilk-Bone-Flavor-Snacks-Biscuits-for-Dogs at the server. Bu i see its coming as Product%252F1756%252FMilk-Bone-Flavor-Snacks-Biscuits-for-Dogs What version of the product are you using? On what operating system? 1.6.2 on Windows 7 Please provide any additional information below.
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=181

From<EMAIL_ADDRESS>on June 28, 2012 07:06:46
Was already reported: https://code.google.com/p/rest-assured/issues/detail?id=175 However, that ticket has status "Fixed" although the problem was only partly resolved.

From<EMAIL_ADDRESS>on June 29, 2012 00:50:33
The issue still persist . Any workarounds ?

From<EMAIL_ADDRESS>on August 16, 2012 03:57:06
You can try if using
given().urlEncodingEnabled(false).pathParam(...)
works.

From<EMAIL_ADDRESS>on September 03, 2012 02:26:17
No, in 1.6.2 that does not help.

From<EMAIL_ADDRESS>on September 03, 2012 02:28:04
Ok thanks for trying.
Status: Accepted

From<EMAIL_ADDRESS>on September 07, 2012 09:13:21
I tried with both 1.6.1 and 1.6.2
When I turn urlEscapeEnabled(false) RA allows me to pass query string values that are already escaped in and the items are NOT double escaped:
given().urlEncodingEnabled(false)
.get("/rest/api/2.0.alpha1/search?foo%20=%20BAM%20AND%20issuetype%20=%20Bug")
GET /rest/api/2.0.alpha1/search?foo%20=%20BAM%20AND%20issuetype%20=%20Bug HTTP/1.1
However if the escaping occurs in the actual path, double escaping occurs
given().urlEncodingEnabled(false)
.get("/rest/api/2.0.alpha1/search/foo%20=%20BAM%20AND%20issuetype%20=%20Bug")
GET /rest/api/2.0.alpha1/search/foo%2520=%2520BAM%2520AND%2520issuetype%2520=%2520Bug HTTP/1.1
I have some fancy URIs that I want to test with, but can't figure out how to NOT get double escaping (thus failing my tests).  For instance I have some URI path segments that have the ?
I believe 188 is a subset of this problem.  Either I need to escape the full path myself (urlEncodingEnabled(false) working) or some more characters need to be better encoded.  Or both. Below is my list:
These get encoded correctly
"dot .", "EURO \u20ac", "PARA \u00a7", "colon :",
"asterisk *", "parens ()", "curly {}", "angle <>", "square []", "percent %", "and &",
"comma ,", "hash #", "plus +", "tilde ~"
and the ones that are not escaped correctly
"qmark ?" // bug 188 "backslash \",
"slash /",
"semicolon ;",
"quotes "'",
"surrogate pair \ud800\udc00"
Any quick workarounds?

From<EMAIL_ADDRESS>on September 20, 2012 09:03:01
also got bitten by this issue (1.6.2 also).
hopefully, the resource I was testing was just a GET resource, so I used java.net.URL and hamcrest matchers as a workaround:
URL url = new URL(RestAssured.baseURI + ":" + RestAssured.port + "/api/agents/probeUrl/" + URLEncoder.encode("funky://characters&to&*escape", "UTF-8"));
InputStream openStream = url.openStream();
String result = new java.util.Scanner(openStream).useDelimiter("\A").next();
String expectedContent = "{"agentId":"embedded","available":true";
assertThat(result, containsString(expectedContent));

From<EMAIL_ADDRESS>on October 11, 2012 00:06:25
Status: Fixed

From<EMAIL_ADDRESS>on October 25, 2012 02:19:08
Can you describe the work around?
When I try to send this URL with the code shown below I get a 404 because the %2F, is rest assured decoding the %2F somewhere?
http://localhost:8097/something/ceec6bdd-3734-41f3-b13d-ab722a45eee6/QumrSExq2yLcuISsau2%2Fj0BIdwuQATk4wUCCTBHzO5k%3D/integrationTestGame/WIzIgbLkEEgMp9cixKmC23FvqzYOhEVUFnmzpkWC3jo%3D
given().urlEncodingEnabled(false).get(url).asString();

From<EMAIL_ADDRESS>on November 03, 2012 21:57:45
Does it work if you're not using rest assured?

From<EMAIL_ADDRESS>on October 30, 2013 06:59:57
Looks like the original reporter dropped out, but I can vouch that we're still seeing this bug in 1.8.1. I ran some tests and checked what the server ended up receiving in each case.
String val = "yes/no";
String encoded = URLEncoder.encode(val, "UTF-8");
// Case 1: val is encoded
given().queryParam("val", val).get(" https://example.com/foo"); // /foo?val=yes%2Fno
// Case 2: val is not encoded
given().urlEncodingEnabled(false).queryParam("val", val).get(" https://example.com/foo"); // /foo?val=yes/no
// Case 3: val is encoded
given().pathParam("val", val).get(" https://example.com/foo?val={val}"); // /foo?val=yes%2Fno
// Case 4: val is not encoded
given().pathParam("val", val).get(" https://example.com/foo/{val}/something"); // /foo/yes/no/something
// Case 5: "encoded" is encoded (so now it's double-encoded)
given().pathParam("encoded", encoded).get(" https://example.com/foo/{encoded}/something"); // /foo/yes%252Fno/something
// Case 6: val is not encoded
given().urlEncodingEnabled(false).pathParam("val", val).get(" https://example.com/foo/{val}/something"); // /foo/yes/no/something
// Case 7: encoded has been un-encoded
given().urlEncodingEnabled(false).pathParam("encoded", encoded).get(" https://example.com/foo/{encoded}/something"); // /foo/yes/no/something
Cases 1-3 work as I would expect.
Case 4 seems inconsistent with case 3, but maybe that's intentional. However, if case 4 is correct, then I would not expect the double-encoding in case 5.
Case 6 seems correct, but then case 7 is baffling; why does the value get un-encoded?
In the end, I seem to be able to send requests that are either double-encoded or not encoded at all, but never just properly encoded.

From<EMAIL_ADDRESS>on October 30, 2013 07:02:58
Thanks for your thorough investigation. I've broken my hand and have a really hard time to write and code right now so please help out!
Status: Accepted

From<EMAIL_ADDRESS>on October 31, 2013 10:28:16
I'm also experiencing John's Case 7; my "%2F"s are getting decoded to "/".

From<EMAIL_ADDRESS>on October 31, 2013 10:48:18
I poked through the code yesterday but couldn't find anything obvious. Unfortunately, I was unable to get Groovy debugging working well enough to really track things down and eventually had to move on to other work. If I get a chance to dig further I'll post any findings, or maybe the test cases will be of use to someone else.

From<EMAIL_ADDRESS>on November 15, 2013 01:24:06
I don't think it's valid to have a "/" in the "resource path" (e.g. yes/no before the ?) before the query parameters even though you encode it. From my understanding severs decode everything specified after the host (e.g. https:://example/foo). So if "yes/no" would be properly URL encoded by REST Assured it still wouldn't work on the server side.

From<EMAIL_ADDRESS>on November 15, 2013 01:25:17
What I mean by "wouldn't work on the server side" is that if the server expects a path parameter called "yes/no".

From<EMAIL_ADDRESS>on November 15, 2013 07:36:35
We're using Jersey on the server side and it does work if things are properly encoded by the client. Eg. given
@Path("/foo/{val}/something")
public void doGet(@PathParam("val") String val)
the value of "val" will be "foo/bar" if the slash was encoded as %2F by the client.
I did a quick search and it appears that some servers disable support for this (eg. Apache: http://stackoverflow.com/questions/3235219/urlencoded-forward-slash-is-breaking-url ), but it's not strictly "wrong" as far as I can tell.
That said, in the most recent version of our API we've eliminated the need to ever do this, but we still need to maintain tests for the old version until we can actually remove support for it.

From<EMAIL_ADDRESS>on November 15, 2013 09:06:27
Thanks for sharing. I'm working on a fix for this, lots of changes though but hopefully I'll be able to get it right sometime next week.

From<EMAIL_ADDRESS>on November 18, 2013 06:41:19
I've implemented a new snapshot release in which I've tried to fix all URL encoding issues. Please try it out by depending on version 1.8.2-SNAPSHOT after having added the following maven repo:
<repositories>
<repository>
<id>sonatype
<url> https://oss.sonatype.org/content/repositories/snapshots/ <snapshots />
</repository>
</repositories>
It would be great if you can try out asap since I really want to make a new release.

From<EMAIL_ADDRESS>on November 18, 2013 09:25:02
hello Johan,
I run several tests with 1.8.2-SNAPSHOT, nothing changed for me : https://gist.github.com/anthonydahanne/7531730

From<EMAIL_ADDRESS>on November 18, 2013 12:52:00
Thanks a lot for trying it out so soon. There seem to be several (new) issues that you've discovered that my tests doesn't find. I'll try to look into them soon.

From<EMAIL_ADDRESS>on November 19, 2013 04:45:54
@Anthony: I've looked into the code that you provided and these are my findings:

I believe this to be correct since the URL is more or less invalid if you disable URL encoding in this case?
This is probably correct because there's no way for REST Assured to know how to URL encode the path: "http://localhost/agents/probeUrl/https://localhost:9888 How should RA know that it only should url encode stuff after "http://localhost/agents/probeUrl/ ? If you use named or unnamed path parameters then it'll work, for example given().pathParam("x", "https://localhost:9888").when().get("/agents/probeUrl/{x}"); .
I cannot reproduce this. I've checked both the REST Assured logs and tried caught the request with Wireshark and RA is not doing double URL encoding as far as I can tell.
Again I've checked with Wireshark and RA does indeed send the request (and does double URL encoding). I've added test cases as well (see the last four tests in URLEncodingITest)

Please let me know if you still think there's something wrong.

From<EMAIL_ADDRESS>on November 19, 2013 04:57:24
Actually regarding (1) I think that it ought to be possible to specify URL's with "://" in the path (besides the scheme). I'll fix this but it's actually another issue.

From<EMAIL_ADDRESS>on November 19, 2013 06:53:59
@Johan,
thanks a lot for investigating.

yeah this is expected behavior
I did not try with .pathParam() ; I just tested it, it works (I updated the gist at https://gist.github.com/anthonydahanne/7531730 3) that is weird, if I have time I'll create a standalone maven project to reproduce the issue
4 ) ok, that sounds expected anyway.

all in all, I like the pathParam solution; as you said, it makes sense to extract the part of the url that needs encoding into a path param, so that RA knows what needs to be encoded.
thanks a lot for your help, now I can get rid of HttpClient in my tests :-)

From<EMAIL_ADDRESS>on November 19, 2013 09:59:02
You can also use unnamed path parameters like this: .. .get("/agents/probeUrl/{x}", "https://localhost:9888");
I'll consider this issue fixed now. If anyone find any further issues please let me know asap.
Thanks for your patience and help!
Status: Fixed

Another workaround  ... See
https://stackoverflow.com/questions/55019246/restassured-disable-url-encoding-not-working-correctly/57610677#57610677


[Date Picker] The indicator representing 'today' is incorrect.

Description
The indicator representing 'today' is being displayed on the wrong date. That incorrect indicator continues to remain even when displaying months other than the current one.
Link to Reproduction (or Detailed Explanation)
https://ark-ui.com/docs/components/date-picker
Steps to Reproduce
Go to https://ark-ui.com/docs/components/date-picker
Ark UI Version
Doc page's version
Framework

[ ] React
[ ] Solid
[ ] Vue

Browser
No response
Additional Information
No response

Hi @uniunitaro!
I recognize in the doc demo that the indicator (-) beneath the number in the calendar view defaults to the previous day. This, however is not reproduceable when viewing it through storybook in the repo.
Can you confirm this is working as expected in a minimal reproduction? (Stackblitz, CodeSandbox)

Hi @uniunitaro!
I recognize in the doc demo that the indicator (-) beneath the number in the calendar view defaults to the previous day, so that button is also rendering data-today. This, however is not reproduceable when viewing it through storybook in the repo. (Also is placed on the correct date when spinning up the website locally)
Can you confirm this is working as expected in a minimal reproduction? (Stackblitz, CodeSandbox)

I found this issue too, I'm not sure if we have a CSS for data-today in Storybook, but I've seen this in HTML

@Omikorin there is styling for data-today in SB so I could confirm visually that it is working in there

@uniunitaro
I could not reproduce this issue. I guess this maybe an issue with Astro / Vercel and some caching.


Feat/add linter ci check #2

This branch contains the linter for the rust-sdk project.

In order to run properly the lint_commits needs a GitHub token! It can be removed in case you think it is not necessary.

I tried running some of the checks locally using act:
[linter/Rust - lint_cargo_fmt_check] ⭐ Run Main Run lint cargo_fmt_check
[linter/Rust - lint_cargo_fmt_check]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1.sh] user= workdir=
| cargo fmt --all -- --check
| `cargo metadata` exited with an error: error: could not find `Cargo.toml` in `/git/github.com/cdevents/sdk-rust` or any parent directory
|
| This utility formats all bin and lib files of the current crate using rustfmt.
|
| Usage: cargo fmt [OPTIONS] [-- <rustfmt_options>...]

We have a cargo.toml in the root directory, but no Cargo.toml... I wonder if it's case sensitive

I tried running some of the checks locally using act:
fmt:
[linter/Rust - lint_cargo_fmt_check] ⭐ Run Main Run lint cargo_fmt_check
[linter/Rust - lint_cargo_fmt_check]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1.sh] user= workdir=
| cargo fmt --all -- --check
| `cargo metadata` exited with an error: error: could not find `Cargo.toml` in `/git/github.com/cdevents/sdk-rust` or any parent directory
|
| This utility formats all bin and lib files of the current crate using rustfmt.
|
| Usage: cargo fmt [OPTIONS] [-- <rustfmt_options>...]

We have a cargo.toml in the root directory, but no Cargo.toml... I wonder if it's case sensitive. Clippy fails with a similar error.
deny:
| cargo deny --all-features \
| 	check licenses advisories\
| 	--config=tools/cargo-deny/deny.toml
| error: no such subcommand: `deny`
|
| 	Did you mean `bench`?
| make: *** [Makefile:35: lint_cargo_deny] Error 101

This failure could be due to my runner image I'm using, but we'll need to check if that component is installed on the GitHub runner image.
dprint:
[linter/Rust - lint_cargo_toml_files]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1.sh] user= workdir=
| dprint check --config tools/dprint/dprint.json
| make: dprint: No such file or directory
| make: *** [Makefile:43: lint_cargo_toml_files] Error 127

Similar - it could be my local image, but we'll need to check.

the edition 2024 sounds not to be stable for the moment I will put the edition 2021 back and we will change it in the future.

I removed the requirements for signed commits for now from the main branch, so we can merge this, but please do sign future commits.


Bug in generating timestamp for table

The timestamp values in the table viz is unix epoch time. I was debugging in my dev environment and found the place where the values is coming from:
In viz.py https://github.com/airbnb/caravel/blob/master/caravel/viz.py#L235
payload[data] generated is https://github.com/airbnb/caravel/blob/master/caravel/viz.py#L248
{'records': [{'timestamp': Timestamp('2016-04-05 00:00:00'), u'sum__spend_usd': X, u'utc_time': u'20160405'}, {'timestamp': Timestamp('2016-04-06 00:00:00'), u'sum__spend_usd': X, u'utc_time': u'20160406'}, {'timestamp': Timestamp('2016-04-07 00:00:00'), u'sum__spend_usd': X, u'utc_time': u'20160407'}, {'timestamp': Timestamp('2016-04-08 00:00:00'), u'sum__spend_usd': X, u'utc_time': u'20160408'}], 'columns': ['timestamp', u'utc_time', u'sum__spend_usd']}
Next step is to create dumps(payload) and it generates: https://github.com/airbnb/caravel/blob/master/caravel/viz.py#L261
"data":{"records":[{"timestamp":1459814400000,"sum__spend_usd":X},{"timestamp":1459900800000,"sum__spend_usd":X},{"timestamp":1459987200000,"sum__spend_usd":X}],"columns":["timestamp","sum__spend_usd"]}
This conversion from Timestamp('2016-04-05 00:00:00') to unix time in the payload is the bug. On further debugging when I removed the following line from the code - the unix timestamp went away:
https://github.com/airbnb/caravel/blob/master/caravel/viz.py#L147
Any idea whats happening here?

looks like an issue with pandas converting ISO format here?

My dataframe for timestamp looks like this: (df.timestamp)
1    2016-04-06T00:00:00.000Z
2    2016-04-07T00:00:00.000Z
3    2016-04-08T00:00:00.000Z
4    2016-04-09T00:00:00.000Z
5    2016-04-10T00:00:00.000Z
6    2016-04-11T00:00:00.000Z

@mistercrunch I have fixed this bug in local. I feel this is kinda hack. Ill send you a PR and you can review if its a good solution.
Here is what I did:
replaced https://github.com/airbnb/caravel/blob/master/caravel/viz.py#L147 with
df.timestamp = df.timestamp.apply(lambda d: datetime.fromtimestamp(mktime(d.timetuple())).strftime('%m-%d'))

reference http://partiallyattended.com/2011/10/13/managing-unix-time-in-python/

^ after bug fix in local

Ok I found the problem on comparing with Panoramix 0.7.0 (viz.py)
Panoramix 0.7.0
def get_json_data(self):
df = self.get_df()
return json.dumps(
dict(
records=df.to_dict(orient="records"),
columns=list(df.columns),
),
default=utils.json_iso_dttm_ser,
)
Caravel 0.8.6
def get_data(self):
df = self.get_df()
return dict(
records=df.to_dict(orient="records"),
columns=list(df.columns),
)


[Game Crash] Crash on song end

Describe how it crashed by giving us those informations:

What you were doing before it crashed and what action made the game to crash.
Upload the crashinfo.txt (GameFolder/crashinfo.txt)
Upload the info.txt and log.txt (GameFolder/Logs)

Explain how we can reproduce the error

Start the game
Pick any song
Finish the song
Game crashed

Sreenshots/Videos
If possible, take screenshots or record the crash happening.
Additional information
Could not find any crashinfo.txt file:
pi@raspberrypi:~ $ find . -iname "crashinfo.txt"
pi@raspberrypi:~ $

log.txt
info.txt

Hiya!
Which raspberry pi model is this running on?
Are you playing via headphones, or HDMI?
You also need to swap your VideoRenderers=glad to VideoRenderers=opengl as it's more stable on the pi, and i see you are on a MESA build that is under 21 (You will get much more performance on 20+ as it adds better support)
Let me know and we can try to resolve your issues.

It's a Raspberry Pi 4B and I'm playing via HDMI:
pi@raspberrypi:~ $ uname -a
Linux raspberrypi 5.10.17-v8+ #1421 SMP PREEMPT Thu May 27 14:01:37 BST 2021 aarch64 GNU/Linux
pi@raspberrypi:~ $ cat /sys/firmware/devicetree/base/model
Raspberry Pi 4 Model B Rev 1.2

Setting VideoRenderers=opengl in Save/Preferences.ini indeed fixed the crash (but setting it through "Experimental Settings" did not, it seemed to have decided to fall back to GLAD anyway.
I have attached the logs of the attempt where I set it using the Experimental Settings menu, given that the fallback behaviour may be an error. Just in case it may help.
info.txt
log.txt
Anyway, I can play now, so I'm happy, thank you! Should I close this issue or do you want to leave it open? If there is any way I can help provide more info to make the game behave better (maybe just error instead of crash or whatever) I'll happily do so.

Thanks for letting me know!
GLAD shouldn't be set on the Raspberry Pi, so it is indeed a bug you have spotted. I will leave this open so it reminds me to fix this, and so folks who search for the problem can find it.
Thanks again for taking the time to report this!

This is confirmed fixed in 4.9.9, we've changed the way the initialisation happens, so it shouldn't break again.


The registerHook function does not get unregistered automatically on unmount

Describe the bug
When you have 2 different persistent layouts, and you add a registerHook to each one, when you navigate between them the registerHook for both will run. It appears the registerHook does not gets unregistered on component unMounted cycle.
Reproduction

Steps to reproduce
No response
System information
"hybridly": "0.0.1-alpha.16"

Used package manager
pnpm
Logs
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Hybridly issue and not an issue related to something else (Vite, Vue...). For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

To fix this, we would have to create a registerHook function in the vue package with the exact same signature. This function would call the original registerHook from core, and call its unregister function in an onUnmounted call only if we are in a component's lifecycle (eg. getCurrentInstance returns something).


Consider a different structure than lists for RArray

Appending is slow for large Ruby arrays.

Done in https://github.com/filib/ruby-marshal/commit/5b52d413e16c37ef74a7277bcb04f520cbca1ec8


Item duplication!

**- MC 1.12.2

Forge <IP_ADDRESS>38

Architecturecraft-1.12-3.98**

Taking an item out of the Sawbench result slot using number key shortcuts gives you the item but doesn't remove it from the sawbench. Holding shift and clicking the duped items stacks them back into the result slot of the sawbench( which also shouldn't be possible? ), then while still holding shift and numkey transfering that slot back out of the sawbench moves the created stack but again leaves a "new" result item in the result slot, without ever consuming the input item.

Confirmed, working on mine too

Any estimate if / when this will be fixed?

Any estimate if / when this will be fixed?


Gemfile.lock: restore missing platform

Bundler locally didn't reject it so seems like something's odd with Dependabot. Will investigate soon, but restore for now as unf_ext has nothing to do with it.
https://github.com/Homebrew/brew/pull/16225#pullrequestreview-1735842152

Makes sense, thanks @Bo98.


No PYVER in Dockerfile.client

As it is explained in Build Using Dockerfile, to build a client with different Python version you can optionally add --build-arg “PYVER=<ver>” . However, Dockerfile.client does not contain ARG PYVER.

We updated the Dockerfile.client and the client build files so that the wheel file generated doesn't target to specified Python version. Thus ARG PYVER is dropped. What's more, you can now specify the Ubuntu version (16.04 / 18.04) you want to build the client container on by specifying --build-arg "UBUNTU_VERSION=<ver>".
The doc update is done in a later commit, which causes the misalignment.

Is there a way to specify the version of python then? When I build client from r19.05, all of the dependencies install under python2.7.
This causes python3 ensemble_image_client.py qa/images/mug.jpg to throw a dependency error when python ensemble_image_client.py qa/images/mug.jpg works just fine.
Maybe I need something else to run under python3?

You must have both python2 and python3 on your system. Did you install the wheel with pip or pip3?

@nadiia-pyvovar as far as I know if you build client from Dockerfile.client, it will install the .whl to python2.7 with RUN pip install --upgrade install/python/tensorrtserver-*.whl numpy pillow command. Since the .whl that is built is independent of the Python version, you can modify Dockerfile.client and add pip3 and install using pip3. It should be something like:
RUN apt install python3-pip && pip3 install --upgrade install/python/tensorrtserver-*.whl numpy pillow


Add advertisingSid property to ScanResult and RxBleInternalScanResult

Is your feature request related to a problem? Please describe.
com.polidea.rxandroidble2.scan.ScanResult does not contain an information about advertising sid which is needed for supporting Bluetooth Auracast feature (https://www.bluetooth.com/wp-content/uploads/Files/Specification/HTML/24670-BASS-html5/out/en/index-en.html#UUID-2a17a3a2-36f9-8cb4-0877-3b56055a7955). It means that there is no option to retrieve this information from the rxandroidble library.
Describe the solution you'd like
com.polidea.rxandroidble2.scan.ScanResult and com.polidea.rxandroidble2.internal.scan.RxBleInternalScanResult classes can be extended with advertisingSid property. This value can be retrieved using android.bluetooth.le.ScanResult.getAdvertisingSid method (https://developer.android.com/reference/kotlin/android/bluetooth/le/ScanResult#getadvertisingsid) and propagated in com.polidea.rxandroidble2.internal.scan.InternalScanResultCreator.
I can volunteer and submit a PR soon.

Hey, sorry for a long pause, got a busy time at work. Feel free to open a PR 👍

I'll open a PR soon.

I have one request, when adding tests please use JUnit – I've started migrating to it from Spock as it's not supported for Android anymore.


Adds read more cap to 'about more' artwork descriptions

Closes #201

Congrats on the first PR Luc! 👏  🎉  Weclome!

@craigspaeth It’s actually already his second https://github.com/artsy/force/pull/630. I was going to keep that a surprise for the announcement email ;)

          1 Warning

:warning:
Please assign someone to your PR

  Generated by :no_entry_sign: danger

Guess the CI fail was a phase of the :moon: bug 😞
Code and visual result look good to me 👍 🎉

Thanks @craigspaeth!


Filter fields from parent

Hi!
Currently all fields from the parent span are added to the child span. This means you can get a lot of not so useful fields when running this with the actix middleware, personally I would only like to have the request id (no need to repeat the ip, path, user agent, etc.).
So I think a filtering system could be good, I am just unsure how to make it flexible enough. Like different filters for different parent span. Though we could also start with just a basic filter. Happy to help on the implementation
Thanks :)

Just checking again to see if someone could look into my PR.
Thanks!


Find out a fast and efficient type_id for Pr47 dynamic type casting.

https://github.com/rust-lang/rust/issues/41875
Since the type_id does not work with types that are non 'static, we must have our own way to get type_id of types.

After looking around there's no workaround for our circumstance.

Pr47 will stop its development indefinitely, until someone shout out loudly "Rust team is fing b*" under that rfc.


[v2] Notifications: Some graphic inconsistencies compared to version 1.6.5

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 2.0.0 beta 7

Graphic inconsistencies of Notifications concern the position of the closing button and the right padding of the text.
Some occur in vertical orientation, others in horizontal orientation.
For example, this occurs in "Default notification"
Version 2.0.0 beta 7:

Version 1.6.5:

I've tested that adding the following CSS rules in the Inspector Web of Safari improves the situation:
.ios .notifications li.notification-item .item-inner { 	width: 100%; }
.ios .notifications .item-text { 	padding-right: 15px; }

This notifications is just a quick port from v1, they will be reworked later

And there is a task for that https://github.com/framework7io/Framework7/issues/1583


fix: Fix params rendering

Close: #2

:tada: This PR is included in version 4.0.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adding cluster linking metrics

Description
Follow up of #1410
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

@wadhwa1 Here you have :)
Thanks for your help

please resolve the merge conflicts for us to be able to merge


BAE Systems

Adds details for the BAE systems event.
Current awaiting details from them and background image :+1:

Updated with event details - ready to go :raised_hands:

Not entirely sure what happened as the commit with all the changes in was already added to the PR :thinking:

@Alex-CD ping

Pong.


TEB mode-coupling matrices

NaMaster can compute mode-coupling matrices for spin0-spin0, 0-2 and 2-2 correlations, which gives it a lot of flexibility to only compute whatever you need for a given problem. This can be a slight annoyance if you want to compute all the mode-coupling matrix elements for a (spin0,spin2) pair (including TT, TE, TB, etc.), since some wigner-3j symbols need to be computed twice.
Although this is not a huge problem (only up to a factor 2 in computational time with respect to the current setup for MCMs), it could be easily solved by passing an is_teb flag when creating an NmtWorkspace object that computes all elements on the fly.

Solved by #29


SUSE Linux build error

I try to build this project following build.md, but this failed as:
[20/3905] Building CXX object contrib/v8-cmake/CMakeFiles/v8_base_without_compiler.dir/v8/src/builtins/setup-builtins-internal.cc.o
FAILED: contrib/v8-cmake/CMakeFiles/v8_base_without_compiler.dir/v8/src/builtins/setup-builtins-internal.cc.o
/usr/bin/ccache /usr/bin/clang++ --target=x86_64-linux-gnu --sysroot=/home/shylock/Workspace/proton/cmake/linux/../../contrib/sysroot/linux-x86_64/x86_64-linux-gnu/libc -DHAS_RESERVED_IDENTIFIER -DSTD_EXCEPTION_HAS_STACK_TRACE=1 -DV8_CONCURRENT_MARKING -DV8_HAVE_TARGET_OS -DV8_TARGET_ARCH_X64 -DV8_TARGET_OS_LINUX -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -I/home/shylock/Workspace/proton/contrib/v8-cmake/v8/include -I/home/shylock/Workspace/proton/build/contrib/v8-cmake/generated -I/home/shylock/Workspace/proton/contrib/v8-cmake/v8 -I/home/shylock/Workspace/proton/contrib/v8-cmake/v8/third_party/zlib -I/home/shylock/Workspace/proton/build/contrib/v8-cmake -I/home/shylock/Workspace/proton/base/glibc-compatibility/memcpy -isystem /home/shylock/Workspace/proton/contrib/llvm-project/libcxx/include -isystem /home/shylock/Workspace/proton/contrib/llvm-project/libcxxabi/include -isystem /home/shylock/Workspace/proton/contrib/libunwind/include --gcc-toolchain=/home/shylock/Workspace/proton/cmake/linux/../../contrib/sysroot/linux-x86_64 -fdiagnostics-color=always -Xclang -fuse-ctor-homing -Wno-enum-constexpr-conversion -fsized-deallocation  -gdwarf-aranges -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt -fasynchronous-unwind-tables -ffile-prefix-map=/home/shylock/Workspace/proton=. -falign-functions=32 -mbranches-within-32B-boundaries   -Wall -Wno-unused-command-line-argument  -fdiagnostics-absolute-paths -fstrict-vtable-pointers -w -O2 -g -DNDEBUG -O3 -g -gdwarf-4  -fno-pie -std=gnu++23   -D OS_LINUX -DV8_ENABLE_WEBASSEMBLY -DV8_ADVANCED_BIGINT_ALGORITHMS -DV8_ENABLE_WASM_SIMD256_REVEC -fno-exceptions -Wno-invalid-offsetof -Wno-deprecated-non-prototype -Werror -nostdinc++ -MD -MT contrib/v8-cmake/CMakeFiles/v8_base_without_compiler.dir/v8/src/builtins/setup-builtins-internal.cc.o -MF contrib/v8-cmake/CMakeFiles/v8_base_without_compiler.dir/v8/src/builtins/setup-builtins-internal.cc.o.d -o contrib/v8-cmake/CMakeFiles/v8_base_without_compiler.dir/v8/src/builtins/setup-builtins-internal.cc.o -c /home/shylock/Workspace/proton/contrib/v8-cmake/v8/src/builtins/setup-builtins-internal.cc
[29/3905] Building CXX object contrib/v8-cmake/CMakeFiles/v8_base_without_compiler.dir/v8/src/extensions/externalize-string-extension.cc.o
ninja: build stopped: subcommand failed.

The build command for one object failed, but this don't display the compile error message, and as I known, ninja will display command, stdout and stderr by default when command failed.

Thank you for attempting to build Proton. To better assist you, could you please provide us with more details about your compilation environment? This information will help us identify the root cause of the problem and provide a more accurate solution.
What's your CPU Architecture, ARM or x86?
What is the version of your operating system?
Did you use Docker or bare-metal (host machine) for building Proton?
If using bare-metal, could you please provide the CMake options you used.
These details will greatly assist us in replicating and diagnosing the compilation issue.

thanks for the reply. the OpenSuse we do not fully test I guess.
Building proton really costs time(hahaha), but installing the env/dependency is more complex.
would you like to use docker build? this shall not affected by the env.
Regarding your problem about Ninja does not display the msg, I have no idea.
but months ago I built the proton and also hit the same issue with v8 and Ninja failed without any useful log.
I will take a look this build error.

Hi @Shylock-Hg , you closed the ticket. Does it mean you have successfully built the project?

Let me reopen this ticket then, and add SUSE Linux in the title.  Our dev team and CI are not SUSE Linux, so the build process on SUSE is not verified and could be improved. We will take a look later. In the meanwhile, if you find anything can be improved, feel free to send us a PR

this is expected, we still support and test on clang16, upgrade to clang17 will be deferred to China new year.
I recalled using clang17 compile proton just needed to solve some warnings. but proton default turn  warn-as-error
@Shylock-Hg we are welcome for new PR to fix the warning on clang17 if you have time on this trial.
tips: check clickhouse current code line if you are not sure how to fix it.

@Shylock-Hg  check clickhouse current code line if you are not sure how to fix it.

Can you detail this?

The warning is because a higher version clang compiler will enable more kinds of warn checks. and clickhouse has migrated to clang-17, proton still in clang-16. and the proton is fork from clickhouse. if the warning is hard to fix, we can search the code line to check how the clickhouse solves the warning.
about the above post warning, I assume below maybe fix it?
ClickHouse/ClickHouse@5a44dc2#diff-64e557fae616787dd9a2b9993b0d273ef80cea55fa1febacd3d99dfc9a21d476R20-R24

Ok, I will follow this to rename shadowed variables.

this is not urgent, do not worry if you have no time to handle this task.


Deployment to Google App Engine

@chintanjosh here is the link

Front end looks great guys, good job :+1:
I know its static as of now but still whenever you are deploying something keep in mind not to keep the filler text. Keep a proper description up there. Other wise the site looks great.


Opening sentence of Importer Overview should be improved

The opening sentence at https://vulnerablecode.readthedocs.io/en/latest/reference_importer_overview.html#importer-overview
is difficult to understand and reads:
Importers are responsible to scrape vulnerability data from various data sources without creating a complete relational model between vulnerabilites, their fixes and store them in a structured fashion.
I would like to suggest something like:
Importers are responsible for scraping vulnerability data such as vulnerabilities and their fixes and for storing the scraped information in a structured fashion. The structured data created by the importer then provides input to an importer which is responsible for creating a relational model for vulnerabilities, affected packages and fixed packages.
And perhaps a link to the improver section would be good here, but maybe not necessary.

Thanks @DennisClark -- I've made your changes and a few additional minor edits.

Done and closing.


User imported Scenes are not Viewable

If a user imports a scene the scene ends up being owned by the "machine" user. This means that users cannot view the scene unless they are part of the root organization.
I'm not sure what the correct solution is for this. The workflow right now is the following:

User uploads imagery, creates an upload job
Airflow task is kicked off to create scenes
Airflow user owns created scenes

One solution would be to allow users in the "root" organization the ability to set created_by, but no other users. Nevertheless, we need to ensure that the correct organization is set for the created scene as well.

Yeah, my initial reaction was that allowing root users to sudo, as it were, might solve the problem, but it seems like that would add a lot of API complexity and potentially open us up to problems if we make a mistake and somehow give client users access to that capability in some form as well.
Another option would be to split the concepts of creator and owner such that created_by is always set automatically but that the owner of an object could transfer ownership to another user. We'd have to think through the implications of this since we don't want users to be able to, say, cause other users to be billed more by transferring large Scenes to them.
A third way would be for the user to delegate their credentials to the Airflow task in some fashion, such that the Airflow task performs all interactions with the API via a token that identifies it to the API as the user, or as acting on behalf of the user. This has the benefit that we would never be able to accidentally leak information because the Airflow tasks run at a higher privilege level than users do, but it might be significantly more complex to implement.

Yeah, my initial reaction was that allowing root users to sudo, as it were, might solve the problem, but it seems like that would add a lot of API complexity and potentially open us up to problems if we make a mistake and somehow give client users access to that capability in some form as well.

I agree that it would add some extra complexity to the API objects since all of our Create objects do not allow setting created_by. We would probably have to add custom decoders/encoders or something.

Another option would be to split the concepts of creator and owner such that created_by is always set automatically but that the owner of an object could transfer ownership to another user. We'd have to think through the implications of this since we don't want users to be able to, say, cause other users to be billed more by transferring large Scenes to them.

I kind of like this option, but it would be a big API change. We could defer transferring ownership until a later date until we want to deal with that complexity. I think there would be a few tasks that fall out from this:

Write a migration to set owner from existing created_by and require for all creations
Restrict setting owner to user creating object except in cases where the user is a member of the root organization (e.g. machine user)
Update frontend code to use new API
Update API specs to use new field
Update any authorization and user visibility filters to use new field

A third way would be for the user to delegate their credentials to the Airflow task in some fashion, such that the Airflow task performs all interactions with the API via a token that identifies it to the API as the user, or as acting on behalf of the user. This has the benefit that we would never be able to accidentally leak information because the Airflow tasks run at a higher privilege level than users do, but it might be significantly more complex to implement.

I'm not sure this is as bad as it sounds. The API client uses the application's secret to generate a JWT that is used for API calls. I am a little hesitant to do too much work here though until we decide if we want to switch to using scala for these airflow tasks.

@ddohler -- thinking about this a little more, I'm leaning towards the second option because it is more explicit. What do you think?

I'm not exactly sure whether you meant the second of the two good options (delegating user credentials) or the second overall (splitting created_by / owner), but I realized it doesn't matter much -- both approaches have some side benefits beyond solving our immediate problem (better dogfooding and clearer API construction, respectively), and they're not mutually exclusive, so we can do whichever one gives us the most bang for the buck right now and queue up the other for a later enhancement.

Closed by https://github.com/azavea/raster-foundry/pull/1580