Adds gesture zooming for iOS and Android

Fixes issue https://github.com/mozilla/pdf.js/issues/2582

Closing since there is no progress here and the code cannot be merged in the current state. The tracking issue will remain open (and this PR is linked to it) so this can be revisited later on.


Remove gh-pages from REPO

gh-pages mistakenly added, need to be removed

#2 Sytem.out.println( -> issue solved)


feat: Glides terminal departure accuracy report

Summary of changes
Asana ticket: 🚃 Build External Glides Terminal Departure Accuracy Report
I simplified some existing logic shared between the two reports by converting child stop IDs to parent stop IDs early on--this makes it much easier to compare predictions with vehicle positions.
The two reports are identical up until the last code cell in the "Main procedure" section.

Has this been demoed for @fsaid90? If not I think getting his sign-off would be valuable.

When trying to run the terminal departure accuracy report, the "load data into memory step" is failing for me with the error:
** (FunctionClauseError) no function clause matching in Stream.with_index/2

    The following arguments were given to Stream.with_index/2:

        # 1
        ["2024/07/18/2024-07-18T08:00", "2024/07/18/2024-07-18T08:05", "2024/07/18/2024-07-18T08:10",
         "2024/07/18/2024-07-18T08:15", "2024/07/18/2024-07-18T08:20", "2024/07/18/2024-07-18T08:25",
         "2024/07/18/2024-07-18T08:30", "2024/07/18/2024-07-18T08:35", "2024/07/18/2024-07-18T08:40",
         "2024/07/18/2024-07-18T08:45", "2024/07/18/2024-07-18T08:50", "2024/07/18/2024-07-18T08:55",
         "2024/07/18/2024-07-18T09:00", "2024/07/18/2024-07-18T09:05", "2024/07/18/2024-07-18T09:10",
         "2024/07/18/2024-07-18T09:15", "2024/07/18/2024-07-18T09:20", "2024/07/18/2024-07-18T09:25",
         "2024/07/18/2024-07-18T09:30", "2024/07/18/2024-07-18T09:35", "2024/07/18/2024-07-18T09:40",
         "2024/07/18/2024-07-18T09:45", "2024/07/18/2024-07-18T09:50", "2024/07/18/2024-07-18T09:55",
         "2024/07/18/2024-07-18T10:00", "2024/07/18/2024-07-18T10:05", "2024/07/18/2024-07-18T10:10",
         "2024/07/18/2024-07-18T10:15", "2024/07/18/2024-07-18T10:20", "2024/07/18/2024-07-18T10:25",
         "2024/07/18/2024-07-18T10:30", "2024/07/18/2024-07-18T10:35", "2024/07/18/2024-07-18T10:40",
         "2024/07/18/2024-07-18T10:45", "2024/07/18/2024-07-18T10:50", "2024/07/18/2024-07-18T10:55",
         "2024/07/18/2024-07-18T11:00", "2024/07/18/2024-07-18T11:05", "2024/07/18/2024-07-18T11:10",
         "2024/07/18/2024-07-18T11:15", "2024/07/18/2024-07-18T11:20", "2024/07/18/2024-07-18T11:25",
         "2024/07/18/2024-07-18T11:30", "2024/07/18/2024-07-18T11:35", "2024/07/18/2024-07-18T11:40",
         "2024/07/18/2024-07-18T11:45", "2024/07/18/2024-07-18T11:50", "2024/07/18/2024-07-18T11:55",
         "2024/07/18/2024-07-18T12:00", "2024/07/18/2024-07-18T12:05", ...]

        # 2
        #Function<16.1179136/2 in TransitData.GlidesReport.Loader.populate_table/4>

    Attempted function clauses (showing 1 out of 1):

        def with_index(enum, offset) when is_integer(offset)

    (elixir 1.15.7) lib/stream.ex:1158: Stream.with_index/2
    (transit_data 0.1.0) lib/transit_data/glides_report/loader.ex:79: TransitData.GlidesReport.Loader.populate_table/4
    (elixir 1.15.7) lib/enum.ex:1693: Enum."-map/2-lists^map/1-1-"/2
    (transit_data 0.1.0) lib/transit_data/glides_report/loader.ex:54: TransitData.GlidesReport.Loader.load_data/5
    #cell:7int34xdv56vyehy:2: (file)
    ```

When trying to run the terminal departure accuracy report, the "load data into memory step" is failing for me with the error:

Sorry, nevermind, updating Livebook resolved this.

This has @fsaid90's approval now, so I'm going to merge it and move on to the final task related to these reports.
Aside:
If I have time during the next task, I'd like to make some additional tweaks to speed up the load-from-disk code. I think collecting all data for a minute in one file will help—right now each file from S3 that has relevant data is saved 1:1 on disk.
Loading data from S3 is already about as fast as it can get. It takes about a half hour if you analyze all data from a service day, because that necessarily means downloading all available data. Even after filtering down to just the files that contain data relevant to Glides terminals, that's almost 60,000 files or ~33 relevant files per sec.


Quicksilver trigger triggers wrong application

I've set a number of triggers to open applications, or to bring them in focus if they are already open. Among these are:
Control-Command-T: iTerm
Control-Command-/: Todoist
If both iTerm and Todoist are open, then pressing Control-Command-T cycles between bringing iTerm into focus and bringing Todoist into focus. The expected behavior is that only iTerm is brought into focus. If Todoist is not open, then Control-Command-T works as expected: only iTerm is brought into focus. In particular, the trigger will not open Todoist; it will only incorrectly focus is if it is already open.
I've seen similar behavior on an other MacBook, where I bound Control-Command-E to Aquamacs. If Evernote happened to be open, this trigger would alternate between focusing Aquamacs and Evernote (wich had a different trigger).
Since Control-Command-T incorrectly focuses Todoist, and Control-Command-E incorrectly focuses Evernote, it looks like some matching based on the first character of the application name is (incorrectly) going on.
To make sure the special character in the trigger for Todoist wasn't the issue, I set the trigger for Todoist to Control-Command-G. The same behavior was still observed: Control-Command-T alternated between focusing iTerm and Todoist. Quitting and restarting Quicksilver made no difference.
2019 MacBook Pro MacOs 11.6.2, Quicksilver 1.6.1

Assuming it doesn’t contain any sensitive information, can you attach a copy of ~/Library/Application Support/Quicksilver/Triggers.plist?

Triggers.plist.zip

@rwvo -- I can't replicate this problem; just set two triggers, one each for Due.app and Terminal.app, tried with both Activate as well as Open, both reliably foreground the expected application regardless of the number or order of activation. Are you still seeing this behavior?
Is it possible that there is a conflict between some other system setting (i.e. something in System Preferences -> Keyboard -> Shortcuts -> Services), or perhaps iTerm or Todoist is registering itself as handling one of those shortcuts globally?

To make sure the special character in the trigger for Todoist wasn't the issue, I set the trigger for Todoist to Control-Command-G. The same behavior was still observed: Control-Command-T alternated between focusing iTerm and Todoist. Quitting and restarting Quicksilver made no difference.

This makes me think that Todoist might be trying to grab Ctrl-T.
Looks like this is the case: https://todoist.com/help/articles/keyboard-shortcuts

Action
Shortcut

Show/hide Todoist
CMD (⌘) + CTRL + T

I'm going to go ahead and close this issue -- if you can replicate the problem with Todoist using something other than ⌘ Ctrl T please let me know and I'll re-open.

This is why I have so few keyboard triggers. It’s nearly impossible to find something that isn’t already used by any app.

@n8henrie Thanks for correctly identifying the issue. Once I disabled the Todoist shortcut, behavior was as expected. Same for Aquamacs and Evernote: my Quicksilver trigger for Aquamacs was also a built-in shortcut in Evernote, giving the same undesirable cycling between the two applications. Disabling the shortcut in Evernote made the trigger work as expected too.


Shallow Checkout with --depth 1 not working as documented

When using the plugin with "clone_flags": "--depth 1", as shown in the readme, I get the following error:
Checking out repository
  | 2024-07-09 20:26:02 UTC | 0
  | 2024-07-09 20:26:02 UTC | :::: local clone location = '.'
  | 2024-07-09 20:26:02 UTC | :::: checkout ref = 'alpha'
  | 2024-07-09 20:26:02 UTC | :::: git remote url = 'redacted'
  | 2024-07-09 20:26:02 UTC | :::: ssh key path = ''
  | 2024-07-09 20:26:02 UTC | :::: clone flags = ' --depth 1 '
  | 2024-07-09 20:26:02 UTC | Cloning redacted
  | 2024-07-09 20:26:02 UTC | error: unknown option `depth 1'

This is going to look a little strange since I'm generating the pipeline definition in Python, but my plugin config looks like this:
plugins=[{
    'hasura/smooth-checkout#v4.4.1': {
        'build_checkout_path': from_branch_checkout_path,
        'repos': [{
            'config': [{
                'url': os.environ.get('BUILDKITE_REPO'),
                'ref': from_branch,
                'clone_flags': '--depth 1'
            }]
        },]

The only thing that looks off to me is the spacing around --depth 1 in the pipeline logs, but that might be a display artifact.

thanks for raising the issue. can you try the following instead?
...
'clone_flags': ['--depth', '1']
...


🐛 BUG:1

Which Cloudflare product(s) does this pertain to?
D1
What version(s) of the tool(s) are you using?
1
What version of Node are you using?
1
What operating system and version are you using?
10
Describe the Bug
Observed behavior
Please describe.
Expected behavior
Please describe.
Steps to reproduce
Please provide the following:

A minimal working subset of your worker code
A minimal working subset of your wrangler.toml
Commands used to start your local dev server, including custom env and cli args
Steps to be performed in the browser, curl commands, or a test we can run that reliably fails (at least a percent of the time)

A git repo we can clone and run a test suite on, or which has a README with step-by-step instructions, is even better. In this case, please use the field below to provide a link to the minimal repro.
Please provide a link to a minimal reproduction
51s Run cd Rin/ bun install v1.1.36 (ededc168) Resolving dependencies Resolved, downloaded and extracted [122] +<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>1101 packages installed [47.78s] Blocked 10 postinstalls. Run bun pm untrusted for details. Failed to create D1 "rin"  ⛅ wrangler 3.69.1 (update available 3.88.0) --------------------------------------------- ✘ [ERROR] A request to the Cloudflare API (/accounts/***/d1/database) failed.   DUPLICATE_DATABASE_ERROR [code: 7500]      If you think this is a bug, please open an issue at: https://github.com/cloudflare/workers-sdk/issues/new/choose ---------------------------- Error: Process completed with exit code 1.
Please provide any relevant error logs
1

Hi, this looks like you've tried to run wrangler d1 create with a database name that you've already used. If you try a different name, can you create a d1 database?


feature: configured ESLint/Prettier/Husky setup

Description
Fixes #263
I previously raised a similar PR #332, but this is the latest and better version of the issue.
This PR integrates Husky, Prettier, and ESLint with the repository. This will test staged files against the config before every commit.
The existing files are yet to be fixed. I believe in creating a different branch and collaboratively resolving those errors/warnings for doing it.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

I see this build time error

Hey @joshi-kaushal i would like to get this PR in. A long-time one. Could you please resolve the conflict and fix the build error? Then it will be ready for merge.

Hi @koustov
I can not see the preview or error log for this build. Where can I see those?

@Sachin-chaurasiya here

kaushal)

Nice! Can we put dates also on these tasks by when we can tentatively complete them?


Clarify release notes re: aggregation plugins

@bot-gradle test and merge

OK, I've already triggered a build for you.


File open dialog ignores defaultPath

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version:
1.93.0
4849ca9bdf9666755eb463db297b69e5385090e3
x64
OS Version:
Ubuntu 22.04.4 LTS
Steps to Reproduce:

Open some file
Ctrl+O when this file is open in the editor

Expected result: Directory containing this file is opened, it worked like this before
Actual result: "Recent files" are opened
I tried to run $ code --disable-extensions --verbose --log trace and got this
[main 2024-09-10T22:52:46.352Z] [DialogMainService]: request to acquire file dialog lock {
  title: 'Open File',
  buttonLabel: undefined,
  filters: undefined,
  defaultPath: '/home/vladimir/curb',
  properties: [ 'multiSelections', 'openFile', 'createDirectory' ]
}
[main 2024-09-10T22:52:46.353Z] [DialogMainService]: new file dialog lock created {
  title: 'Open File',
  buttonLabel: undefined,
  filters: undefined,
  defaultPath: '/home/vladimir/curb',
  properties: [ 'multiSelections', 'openFile', 'createDirectory' ]
}

so, defaultPath is set, but file dialog still points to "Recent files"

UPD: This screenshot was made before I updated VS Code, but the problem remains after the update
I inspected window type with devilspie2
print("1", get_application_name(), "2", get_window_role(), "3", get_window_name(), "4", get_window_type())
--- It prints
-- 1	xdg-desktop-portal-gnome	2		3	Open File	4	WINDOW_TYPE_DIALOG

I tested FileChooserDialog via ruby bindings and it works
require 'gtk3'

dialog = Gtk::FileChooserDialog.new(:title => 'Gtk::FileChooser sample',
                                    :action => :open,
                                    :buttons => [[Gtk::Stock::OPEN, :accept],
                                                 [Gtk::Stock::CANCEL, :cancel]])
dialog.set_current_folder("/home/vladimir/curb")
dialog.run
```ruby
require 'gtk3'

dialog = Gtk::FileChooserDialog.new(:title => 'Gtk::FileChooser sample',
                                    :action => :open,
                                    :buttons => [[Gtk::Stock::OPEN, :accept],
                                                 [Gtk::Stock::CANCEL, :cancel]])
dialog.set_current_folder("/home/vladimir/curb")
dialog.run

It works, but it's not the same dialog as used by code, chrome, telegram. Sublime text and slack use it, though.

This is tracked in https://github.com/microsoft/vscode/issues/213780
Issue will be fixed with newer runtime updates this month, relevant upstream fix https://github.com/electron/electron/pull/43570


assigning a  video to specific playlist

Hi ,
the package is awesome .
I'm wondering if the package supports assigning a  video to specific playlist  ?
thank you

+1

+1

Hi guys,
Thanks for your interest. Currently there is no way to assign a video to a specific playlist, however if someone has the time to submit a PR I will happily review.


Check if value is numeric before converting to int

Fixes

Fixes an issue we've seen in production.
Description

We don't have tests for this yet, but I was able to check locally that a search which was previously erroring out is now returning results.
Testing Instructions

just up, then access this URL: http://localhost:8000/v1/images/?page=NaN&shouldPersistMedia=true&q=wolf
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

LGTM. We should add a unit test for this too though.

Agree, I'll make an issue after this is deployed.


Metaevent filter has no docs

(This issue was originally filed by @choffee at https://github.com/elastic/logstash-contrib/issues/97)

Could somebody add a short explanation of what the metaevent filter does to the docs.

:+1:


Clean up Swift code

I noticed that some files had trailing whitespace. To avoid noise elsewhere, I ran swiftlint --fix on the project to help modernize Swift (NSMakeRect → NSRect.init, remove semicolons, ...)
This is all very optional and we can just as well discard this PR, @onekiloparsec, if you don't like the effect of this

swiftlint is good.


Windows: Undefined path resolution behaviour for project (and it parts) located within directory junction links

Expected Behavior
Use of nyc --all mocha should collect coverage data for src directory only, once for each file (tested or not doesn't matter).
Observed Behavior
Instead, with junction links as part of project path, coverage data collected for:

each tested file (as should be);
each file in src folder (results in duplicates of already listed tested files with 0% coverage);
each file in test folder (which is plain wrong, as test folder not in coverage interest paths by default).

Everything referred to as junctions was made like this cmd: mklink /j junction D:\junction
D:\junction is junction origin (real folder), C:\junction is junction link.
Note, that including/excluding coverage paths for nyc do nothing at all, --all flag becomes useless as consequence.
Temporary solutions

Move project or it parts within junction links to non-junction structure;
Access project folder through junction origins (cannot be achieved for part of project).

Bonus Points! Code (or Repository) that Reproduces Issue
Sample structure and contents in gist suffice to serve the case (nevertheless, reproduced same stuff on several of other projects).
Assuming project structure of:
folder or junction
+-- src
| +-- a.js
| `-- b.js
`-- test
  `-- a.js

If nyc --all mocha used in plain folder, everything works as expected:
PS C:\folder> npm run cover

><EMAIL_ADDRESS>cover C:\folder
> nyc --all mocha

  dummy a test
    √ should be

  1 passing (9ms)

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |       50 |      100 |       50 |       50 |                |
 a.js     |      100 |      100 |      100 |      100 |                |
 b.js     |        0 |      100 |        0 |        0 |            1,2 |
----------|----------|----------|----------|----------|----------------|

If nyc --all mocha used on directory path within junction link:
PS C:\junction> npm run cover

><EMAIL_ADDRESS>cover C:\junction
> nyc --all mocha

  dummy a test
    √ should be

  1 passing (20ms)

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |    63.64 |      100 |       60 |    63.64 |                |
 src      |    33.33 |      100 |    33.33 |    33.33 |                |
  a.js    |        0 |      100 |        0 |        0 |            1,2 |
  a.js    |      100 |      100 |      100 |      100 |                |
  b.js    |        0 |      100 |        0 |        0 |            1,2 |
 test     |      100 |      100 |      100 |      100 |                |
  a.js    |      100 |      100 |      100 |      100 |                |
----------|----------|----------|----------|----------|----------------|

If nyc --all mocha used in junction origin (source of junction on D volume):
PS D:\junction> npm run cover

><EMAIL_ADDRESS>cover D:\junction
> nyc --all mocha

  dummy a test
    √ should be

  1 passing (19ms)

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |       50 |      100 |       50 |       50 |                |
 a.js     |      100 |      100 |      100 |      100 |                |
 b.js     |        0 |      100 |        0 |        0 |            1,2 |
----------|----------|----------|----------|----------|----------------|

The most interesting case -- if nyc --all mocha used in project with src as junction link:
C:\folder>npm run cover

><EMAIL_ADDRESS>cover C:\folder
> nyc --all mocha

  dummy a test
    √ should be

  1 passing (13ms)

--------------|----------|----------|----------|----------|----------------|
File          |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
--------------|----------|----------|----------|----------|----------------|
All files     |    33.33 |      100 |    33.33 |    33.33 |                |
 folder/src   |        0 |      100 |        0 |        0 |                |
  a.js        |        0 |      100 |        0 |        0 |            1,2 |
  b.js        |        0 |      100 |        0 |        0 |            1,2 |
 junction/src |      100 |      100 |      100 |      100 |                |
  a.js        |      100 |      100 |      100 |      100 |                |
--------------|----------|----------|----------|----------|----------------|

Note that cases of project path and src junction links differs greatly.
Forensic Information
Operating System: Windows 10 ver.1607
Environment Information:
Output located at same gist

@ChantOfAnAnt thank you for the bug report; I think the underlying issue will be in this library here:
https://github.com/istanbuljs/istanbuljs/tree/master/packages/test-exclude
would you mind reopening an issue there? would also greatly appreciate any help you can provide digging into things -- we should be able to add a few new failing test cases to test-exclude.

@bcoe thanks for investigating! As advised, will reopen this as issue on test-exclude in spare time.


Refactors rate_limit plugin with YAML configurations

Besides majorly refactoring a lot of the global plugin code, this PR makes the following changes:

YAML configuration
Reloadable configurations (even as a global)
SNI aliases (one rate limiter can apply to many SNIs)
The IP reputation objects are now shareable for many SNIs. This means an attacker can circumvent the reputation by spreading the DDoS traffic across many SNIs.

I can review this when it is ready

I can review this when it is ready

Great! Almost there :). The refactoring focuses entirely on the global plugin only, leaving the remap plugin as-is. One hope with this refactoring and change to a reloadable YAML configuration is that we can add more features and rate limiting rules more easily.

@zwoop let me know when it is ready to review. It looks like it is but I am not sure if you are having more changes in your mind.

[approve ci autest]

[approve ci]

I updated this to use the updated version of the registration API.


Updates items for GA 2022.4

Signed-off-by: natemyersibm<EMAIL_ADDRESS>

Per collaboration on GA 4 updates. Thank you!


1.20.4 Support

any plans? :)

undecided.
lots of changes to 1.20.4 code and hardly any interest in that version

well, now that 1.20.5 is out, it might be a good idea to catch up. :D

thanks for the info! when creating a modpack, its very important to consider the authors update policy. this helps us decide whether to include their work or not. so i appreciate your honesty.


undefined method `cattr_accessor' for TrixEditorHelper:Module (NoMethodError)

This appears when initializing the rails app.
As far as I known cattr_accessor is a method of a Class? It seems a module should not have this method, because it defines a class variable.
My rails version is 3.2.22, maybe a little different to other using rails 4.
thanks

Thanks for reporting this! Would you be able to provide a sample app or the backtrace to where the error is occurring? Thanks!

Ran into this just now, cattr_accessor is not defined for Module in rails 4.0.2 and lower, for compatibility you need to use mattr_accessor instead.

Would you be willing to submit a PR to fix this, @mateomurphy or @CicholGricenchos?

sure, will do it in a bit

Solved by #11.


Update concept-certificate-based-authentication-limitations.md

Spelling mistake: OCSP

@gaubert-ms : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Try cuda always_inline

This PR tries out always using always_inline for all CUDA kernel launches, since this can reduce function call overhead.

Superseded by #2833.


refactor(Subscription): split 'Subscription' class into class and interface

This will cause BREAKING CHANGE if we accept this proposal.
@blesh @trxcllnt how about do you think?

Motivation
At now, Subscription used as a implementation class or as an interface in Action, Subject, and others.
However, we cannot use a class which has a private member as an interface. This prevents a some refactoring internally (e.g. #1389) and It confuses us (and users) to use a class as an interface.
Detailed Change

Split Subscription class into CompositeSubscription class and Subscription interface.

I don't see what do we gain with this...

This seems like a good reason to pressure TS to ignore private fields when using a class as an interface...

@trxcllnt does compiler supports it already? (I assume not yet)

So to be clear, this just renamed Subscription to CompositeSubscription and then created a Subscription interface?

The truth is that we failed in OOP 101 throughout our code base here. For the more part, all functions should accept interfaces, not classes.
I could see use for an ISubscription and an ISubscriptionList or something that both match the Subscription implementation
In fact, our subscriptions should all really be returning ISubscription, and methods that want the add and remove functionality should really accept ISubscriptionList. This gives us flexibility to change our architecture later.
interaface ISubscription {
  unsubscribe(): void;
}

interface ISubscriptionList extends ISubscription {
  add(sub: ISubscription);
  remove(sub: ISubscription);
}

@blesh

So to be clear, this just renamed Subscription to CompositeSubscription and then created a Subscription interface?
https://github.com/ReactiveX/rxjs/pull/1521#issuecomment-200554236

Yes. I intended so.

I could see use for an ISubscription and an ISubscriptionList or something that both match the Subscription implementation

Okay. I'll make the new patch for this. BTW, Do we add I-prefix to them? TypeScript's naming convention does not recommend I-prefix for an interface.
https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines#names

BTW, Do we add I-prefix to them?

: and also most of our codebases doesn't uses I-prefix for its interfaces, I'd +1 to avoid if possible to consistent. Unfortunately I can't suggest good names.. :(

How about Subscriptional? (I'm not sure my english naming sense...)

Unsubscribable or Disposable (interface)
Subscription (class implementing the interface above)
Just a suggestion...

Unsubscribable or Disposable (interface)

I feel:

Disposable need dispose() & isDisposed as tier 1 (primary) member.
Unsubscribable might be good, but I don't have any concrete confidence that we can choose it as a pair of Subscribable<T>...

I'd like to wait @trxcllnt and @blesh 's opinions.
Thank you for your advice, @staltz.

@saneyuki I dug into this a bit yesterday.
as I see it, there are really three things:
interface AnonymousSubscription {
  unsubscribe(): void;
}

interface ISubscription extends AnonymousSubscription {
  unsubscribe(): void;
  add(sub: AnonymousSubscription | Function | void);
  remove(sub: RxSubscription);
  isUnsubscribed: boolean;
}

class Subscription implements ISubscription {
  // stuff
}

AnonymousSubscription would match the interface defined by the es-observable spec. This is a type we would accept from methods that want a Subscription... however we should be returning ISubscription everywhere.
In fact, while digging into this, I found a lot of security issues that concerned me, and you may even want to hold off on these changes, as I think there might be a larger refactor around subscription and subscribers coming down the pipe.

Also: I don't really want to support legacy .dispose() interfaces. I think it will encourage some bad practices.

Security issues? :hushed:

@staltz https://github.com/ReactiveX/rxjs/issues/1532
Since the Observer and Subscription have merged into one "Subscriber", and we're returning the Subscriber directly from subscribe, it's the subscriber. You can push values into it and/or otherwise use it like an Observer or something.
It's worth discussing and discussing soon.

@blesh Should I close this pull request and hand over to you as #1533? Or Should I modify changesets in this just as what you suggested in #1533?

@saneyuki the changes in #1533 are approximately what I'd like to land in the repo. I can tell you've put a lot of thought and work into this, and I want to give credit where credit is due. But I do need to get this change in relatively quickly so I can continue with what I'm working on. This is preparation for what I figure might be a larger refactor next week to resolve #1532 and #1466.
You can copy over my commits and keep them in this PR if you like. (I know contributors' commit counts are important to people). Or we can close this and I can just merge the other PR. I'll leave it up to you.  Just let me know fast ;)

@blesh
Okay. Thank you for your explain.
Could I take this pull request again?  I'd like to try to shape the patch. If I will have not finish until March 29. AM9:00 (UTC+8),  then please close this pull request.

@saneyuki .... I'm sorry, but I'm in a bit of a hurry to get those changes in today so I can start working on refactoring Subjects and @trxcllnt can get to work fixing ConnectableObservable. If you literally want to copy the commits over to your PR so you can have your name on them, I'm totally cool with that, but it needs to be done in the next hour so I can get to work on the changes I need to complete.

@saneyuki sorry, but given the time constraints, I had to merge my other PR in favor of this one so I could move on. I greatly appreciate the effort you put in, and I really hope you're not too disappointed. I'll try to find a way to make it up to you. ;)

@blesh
No problem! and Thank you for waiting me .
BTW, I found some questions about #1533, thus I may open a new issue/pull request.

Please remove I prefix from ISubscription. This makes naming style inconsistent.


Regression with Option[Record] results in 1.0.0-RC6

I experienced a regression in the latest 1.0.0-RC6. I don't yet have a fully tested self contained example though.
But I think it boils down to this code:
case class Foo(a: Int, b: String)
case class Bar(c: Int, d: Option[String])

sql"SELECT a, b, c, d FROM foo LEFT JOIN bar ON a = c".query[(Foo, Option[Bar])]

With these records in the DB:
| a | b     |
-------------
| 1 | 'abc' |

| c | d    |
------------
| 1 | NULL |

I used to get (Foo(1, "abc"), Some(Bar(1, None))) as the result of that query, and now I get (Foo(1, "abc"), None).

Thanks for the report. I believe this is a long running issue in doobie and should be fixed by #2136.
See the changes I made for the test scenario "Read should read correct columns for instances with Option (None)" in ReadSuite.scala
I'll add more tests to verify that left joining a table with not-null and null columns are handled correctly.

I believe in RC5 the behaviour works for your case but not in the general case.

Up until 1.0.0-RC5 I didn't notice issues with it. But I also haven't used that feature prolifically.


WHEN I click the button to generate a password

THEN I am presented with a series of prompts for password criteria

done


Update usage section to tap proper repo

Thanks, but not needed. https://github.com/neovim/homebrew-neovim/pull/99


Compliance Report B | EER Column |3|

Task:
This card is to create the functionality needed for the EER column for each fuel reported under Schedule B - Part 3 Fuel Supply.
Non-editable:
The fuel supplier user should not be able to edit this column
Energy Effectiveness Ratio (EER):
This column should be auto-populated based on:

The fuel selected within the Fuel Type column, created in Card 1386.
The fuel class (gasoline or diesel) chosen within the Fuel Class column, created in Card 1387.

In addition,

This column will draw values from the EER table, created in Card 890.
TFRS will also need to ensure that it is pulling the EER value that is/was effective during that compliance year (since the branch can update these values over time). https://trello.com/c/Vrl3yBzC/1395-compliance-report-b-eer-column-3

 Compliance Report B | EER Column |3|


Icons not rendering on production build when mounting

Environment
Nuxt project info:

Operating System: Linux
Node Version:     v20.15.1
Nuxt Version:     3.13.2
CLI Version:      3.13.2
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      experimental, runtimeConfig, build, devtools, nitro, routeRules, plugins, modules, eslint, pinia, site, delayHydration, i18n, icon, app, content, svgo, sitemap, googleFonts, image, mdc, htmlValidator, compatibilityDate
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
Github to reproduction: https://github.com/hoachnt/hoachnt-web
Describe the bug
I don't know what problem is. I try to fix this bug 2 months and think that problem is in nuxt. And yep I saw in the official website of nuxt has same problem
Additional context
No response
Logs
No response

Hello :wave: can you provide a minimal reproduction please  ?

Hello 👋 can you provide a minimal reproduction please ?

Reproduction link

Hello 👋 can you provide a minimal reproduction please ?

Reproduction link. But u need to build project and run preview to see sometimes icons are just not rendring. I can't provide u a minimal reproduction, cause it works in minimal project reproduction

let's track in https://github.com/nuxt/icon/issues/259

let's track in nuxt/icon#259

Oh yeah, Thanks


SOLR-16991: Fix bug: Concurrent requests failing JWT Auth intermittently

https://issues.apache.org/jira/browse/SOLR-16991
Description
There's an intermittent failure in JWT authentication, with a roughly 20% failure rate (depends on the network latency). Upon investigating, I identified a race condition due to simultaneous HTTP requests within the authentication process.
Here's the chain of events:

The user initiates the OAuth/IdProvider authentication process. Once completed, they are redirected back to Solr.

LoginController is then activated to handle the response from the IdProvider.

LoginController calls "resetMenu" method which triggers requests to the "admin/info/system" and "admin/cores" endpoints. These requests are bound to fail as the auth.header hasn't been set yet.

The authentication process continues with the processing of the IdProvider's response. If successful, the auth.header is set.

The response from step 3 is received and returns a 401 error, causing the auth.header to be unset in app.js.

This results in the session being terminated and the entire authentication process failing.

This race condition, where requests are made before setting the authentication header and their subsequent failure clears an already set header, leads to the observed intermittent authentication issues.
Is the "resetMenu" call necessary ? My inclination is that this is useless because why would you need to reset the menu in the middle of an authentication process? All we need is either show or hide the menu depending on the existence or not of an active  user session. The menu would be reset after the user is authenticated.
Solution
Replaced the call to resetMenu with a call to a newly added method showHideMenu and it worked nicely.
$scope.showHideMenu = function() {
    $scope.http401 = sessionStorage.getItem("http401");
  };

Tests
Local and remote tests.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Hi @janhoy
Would you please review this?

Tip: Start he PR subject with "SOLR-16991: ", then the jira number will occur in auto generated commit message and show up as a jira comment

I have updated the CHANGES.txt file.

I cannot see CHANGES.txt in this PR?

I have updated the CHANGES.txt file.

I cannot see CHANGES.txt in this PR?

It's there now.


language translator added

🛠 Fixes Issue
Closes #1120
👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots
Consists of a sample by translating to bengali language

@S-ishita

Try to add the button on the navbar only.

@SauravMukherjee44 due to space congestion it is getting in next line,as shown in image below.If this looks fine to you i shall make a commit

This looks weird, Adjust it on the same line. You can decrease the width of the other elements.


Test version of release candidate docs.

Create Docs PR with a Github Action for building release artifacts.
Based largely on the existing build_release_candidate.sh script, but with the following changes:

No longer quarantine each doc generator into it's own clone.
Leverage available steps for checking out code instead.

TODO: Consolidate further into step oriented workflow eg. for working directories and similar.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Closing in favour of branch on repo for iteration purposes.
https://github.com/apache/beam/pull/28136


react-router not work with React 16.0.0

react-v16.0.0
react-router-v1.0.2
It's baseRouters.js

Updating to react-router v3.2.0 will solve the issue.

@StorytellerCZ I have resolved it.thx.It's right

Don't forget to close the issue :smile:


spruce up the Team explorer

Closes #3704.

I want to use the whole width for the Teams table so we can show more columns.

I want something like the GitHub issue browser. I prefer their interface, with filters and sorts tailored to their specific dataset, to a clumsy generic table sort/filter interface.

Along with that, a presentation that isn't strictly tabular.

... which is nevertheless information dense.

From https://github.com/gratipay/gratipay.com/issues/3704#issuecomment-136409310:

A list of "trending" (most active) Teams would be another way to do it, "Activity" would need to be defined.

Could be a sort, perhaps the default sort, the I think it's going to be out of scope for this PR since defining and implementing Activity will be a fair chunk of work.

Failing tests already!? :(

sigh

:+1: :+1:


2.0.0 indentation compatibility issue with karma "dots" reporter

Not sure if this is an issue here, or simply an interoperability issue with the way the karma "dots" reporter is implemented, but it appears that after upgrading from 1.0.1 to 2.0.0, I'm seeing the indentation whitespace interspersed between the dots coming from the karma "dots" reporter.
Before:

After:

Got a chance to look into this further. This is happening because grunt-concurrent uses pad-stdio to statically define a left padding on stdout, regardless of whether the message being outputted contains a linebreak or not. The solution isn't straightforward however, as simply looking for a trailing newline before inserting padding isn't enough (in the case of the dots reporter, you'd end up with a line of dots, followed by padding, followed by a final dot and newline). Trying to reverse the logic and rpad when a trailing newline is encountered doesn't quite solve it either, as the first line will be missing the indentation.
Possible paths to take:

concede defeat and switch to a different reporter
add an option to grunt-concurrent to disable/specify the padding
try to come up with a solution via rpad, etc. and newline inspection
other???

Thoughts?

I guess it would be possible to pipe the child process through pad-stream, which handles newlines, instead of using pad-stdio.

Great suggestion, totally worked. I started up a PR, but I feel like I might be missing something with regard to when logConcurrentOutput is false. Should it still pad in that case? I've got a wip branch up if you have a sec to take a look: https://github.com/sindresorhus/grunt-concurrent/compare/master...jimf:fix-newline-padding-wip. Thanks!

Should it still pad in that case?

Yes.

I've got a wip branch up if you have a sec to take a look: master...jimf:fix-newline-padding-wip. Thanks!

Just do a PR. Easier to review ;)


Additional Asteroids

Adds the capability for additional asteroid models for regular asteroids (Increased from 2 to 4), Helium3, and tech rocks (Both increased to 2 from 1)
Imported from trac ticket #92,  created by Andon on 06-21-2010 at 00:20, last modified: 04-30-2012 at 23:15

r561, needs testing
Trac comment by Imago on 06-21-2010 at 03:39

crashes frequently on brawl - looks like OOB asteroid type.
reverted in r605 pending more developer testing
Trac comment by Imago on 06-30-2010 at 22:07

this appears to be working but we need new unique art to seal the deal
Trac comment by Imago on 06-28-2010 at 10:35

Seems like there are issues with hitboxes:
http://www.freeallegiance.org/forums/index.php?showtopic=66104
Solutions:

Fix asteroids (model).
Remove new asteroids (code & model).
Replace new asteroid models with working copies of current asteroids (model).

Trac comment by pkk on 04-29-2012 at 15:37

r664
Trac comment by Imago on 07-06-2010 at 00:12

Models were just bad copies (Milkshape import/export) of old asteroids. No new textures were created.
Only keeping bgrnd55 as "new" he3 rock with [1054].
If someone creates new models, it shouldn't be a problem to add them.
Trac comment by pkk on 04-30-2012 at 23:15


fest: support parsing nested comments

PR Type
Enhancement, Tests

Description

Enhanced the comment parsing logic to support nested comments and multiple comments in a line.
Introduced new line modes ('original', 'stripped', 'compact') for parsing, allowing more flexible handling of comments and whitespace.
Added comprehensive tests to verify the correct parsing of nested comments and multiple comments in a line.
Refactored code to improve clarity and maintainability, including renaming variables and updating test descriptions.

Changes walkthrough 📝
Relevant filesTests

index.test.jsAdd tests for nested and multiple comments parsing

src/tests/index.test.js
Added tests for parsing nested comments and multiple comments in a line.  Renamed variables for clarity.  Updated test descriptions for better understanding.

+65/-47

Enhancement

index.jsEnhance comment parsing with nested support and line modes

src/index.js
Introduced new line modes: 'original', 'stripped', and 'compact'.  Refactored comment stripping logic to handle nested comments.  Added default options for parsing functions.  Improved handling of options in parsing functions.

+79/-48

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

/review

/improve

/improve

/improve


Integration of GitHub Copilot

Is your feature request related to a problem? Please describe.
I've been using Azure Data Studio extensively for my work, and I'm impressed with the tool's capabilities. However, I've recently started using the GitHub Copilot extension for code completion and suggestions in other editors, and I find it to be a valuable addition to my workflow. I'm always frustrated when I switch back to Azure Data Studio and the GitHub Copilot extension is not available there, especially since Azure Data Studio is built on the foundation of Visual Studio, which supports the Copilot extension.
Describe the solution or feature you'd like
I would like to see the GitHub Copilot extension integrated into Azure Data Studio. This will provide users with the benefits of AI-powered code completion and suggestions, streamlining the development process and improving productivity. Given that Azure Data Studio is based on Visual Studio, I believe implementing this feature should be feasible and would greatly enhance the user experience.
Describe alternatives you've considered
I've considered using a different editor that already supports the GitHub Copilot extension, such as Visual Studio Code or JetBrains IDEs. However, I prefer to use Azure Data Studio for my specific workflow, and I believe many other users would also benefit from having GitHub Copilot integrated into the tool.
Additional context
The addition of GitHub Copilot to Azure Data Studio would align with the ongoing trend of AI-assisted code completion and bring this powerful feature to a wider audience. It would make Azure Data Studio an even more versatile and efficient tool for developers who are already using or considering using GitHub Copilot in their development process.

@LeonTheProfessional8 for what it's worth, you can download the Copilot extension VSIX from the VS Code marketplace and install it directly in ADS insider build using the "Install from VSIX" command.  We do plan to better support in the future.

@LeonTheProfessional8 or others interested in this integration - can you share a bit on:

which database types do you use in ADS? eg mssql, pgsql, mysql, etc
what kind of code do you find you write the most or takes the most time? eg select queries, where statements, creating objects

@LeonTheProfessional8 for what it's worth, you can download the Copilot extension VSIX from the VS Code marketplace and install it directly in ADS insider build using the "Install from VSIX" command. We do plan to better support in the future.

Thank you for your suggestion. I was able to successfully install the GitHub Copilot extension in Azure Data Studio - Insider version, but only by using an older version of the Copilot VSIX file. This is because the latest VSIX version is only compatible with VS Code 1.70.0 and above. When I tried to install the latest GitHub Copilot version in Azure Data Studio - Insider, I received the following error:
"The extension "github.copilot" cannot be installed because it is not compatible with VS Code 1.70.0."
I managed to resolve this issue by installing an older version of GitHub Copilot (Version 1.65.7705), which I found on https://www.vsixhub.com/vsix/63883/.
It might be necessary to update the VS Code version in Azure Data Studio so that the latest Copilot version 1.85.75 can also be supported.

@LeonTheProfessional8 or others interested in this integration - can you share a bit on:

which database types do you use in ADS? eg mssql, pgsql, mysql, etc
what kind of code do you find you write the most or takes the most time? eg select queries, where statements, creating objects

Thank you for your response. I exclusively use mssql and find that GitHub Copilot helps me with auto-completing various SQL commands, whether they are simple SELECT, UPDATE, INSERT, CREATE statements, or more complex procedures and transactions. However, Copilot is not yet 100% accurate with the context of the database and often suggests columns that might make sense in the context of the command but do not exist in the database. So far, it has been most helpful for me in generating boilerplate code or when I wanted to use new commands.
I would like to see Copilot improve in the future by at least being aware of the tables and their corresponding columns with their data types and generating SQL commands based on this information.

@LeonTheProfessional8 for what it's worth, you can download the Copilot extension VSIX from the VS Code marketplace and install it directly in ADS insider build using the "Install from VSIX" command. We do plan to better support in the future.

Thank you for your suggestion. I was able to successfully install the GitHub Copilot extension in Azure Data Studio - Insider version, but only by using an older version of the Copilot VSIX file. This is because the latest VSIX version is only compatible with VS Code 1.70.0 and above. When I tried to install the latest GitHub Copilot version in Azure Data Studio - Insider, I received the following error:
"The extension "github.copilot" cannot be installed because it is not compatible with VS Code 1.70.0."
I managed to resolve this issue by installing an older version of GitHub Copilot (Version 1.65.7705), which I found on https://www.vsixhub.com/vsix/63883/.
It might be necessary to update the VS Code version in Azure Data Studio so that the latest Copilot version 1.85.75 can also be supported.

That's very strange. What version is your insiders on/at?  When you open the "About Azure Data Studio insiders" menu the dialog should list the version, date, and VS Code version among other things.

@LeonTheProfessional8 for what it's worth, you can download the Copilot extension VSIX from the VS Code marketplace and install it directly in ADS insider build using the "Install from VSIX" command. We do plan to better support in the future.

Thank you for your suggestion. I was able to successfully install the GitHub Copilot extension in Azure Data Studio - Insider version, but only by using an older version of the Copilot VSIX file. This is because the latest VSIX version is only compatible with VS Code 1.70.0 and above. When I tried to install the latest GitHub Copilot version in Azure Data Studio - Insider, I received the following error:
"The extension "github.copilot" cannot be installed because it is not compatible with VS Code 1.70.0."
I managed to resolve this issue by installing an older version of GitHub Copilot (Version 1.65.7705), which I found on https://www.vsixhub.com/vsix/63883/.
It might be necessary to update the VS Code version in Azure Data Studio so that the latest Copilot version 1.85.75 can also be supported.

That's very strange. What version is your insiders on/at? When you open the "About Azure Data Studio insiders" menu the dialog should list the version, date, and VS Code version among other things.

Version: 1.44.0-insider
Date: 2023-05-05
Electron: 19.1.8

@LeonTheProfessional8 it looks like Copilot recently bumped the required vscode shell version.  We are going to publish this version of Copilot to the marketplace for our May release.  It has been tested with ADS https://sqlopsextensions.blob.core.windows.net/extensions/copilot/1.83.41/GitHub.copilot-1.83.41.vsix.

@LeonTheProfessional8 it looks like Copilot recently bumped the required vscode shell version. We are going to publish this version of Copilot to the marketplace for our May release. It has been tested with ADS https://sqlopsextensions.blob.core.windows.net/extensions/copilot/1.83.41/GitHub.copilot-1.83.41.vsix.

Thank you for the update. I am pleased to confirm that the provided version of Copilot is working smoothly with the Azure Data Studio Insider version. I appreciate your team's effort in addressing this issue and look forward to the official release in May. Thanks again for your support and continuous improvement of the tool.


Fix the sliding window problem in linux occur due to reparenting of the window due to decoration.

Another solution without delay was discussed in the following PR: #75709
The caveat for this solution is that if the window manager decides to reparent the reparented window for decorations (which rarely happens in the most popular window managers), it will not work.
Fixes: #75292

Thanks!
PS. Please try to be a bit more succinct with the commit messages in the future. You could leave the title as "Fix the sliding window problem on the Linux platform" and put the rest in the commit message body as a further clarification.

@YuriSizov  Thanks for the suggestion, I will keep that in my mind.


Bug 1847540: resolve only default channels

Non deterministic behavior was introduced where, in some cases, the
dependency resolver would select a channel entry from the registry
that was not part of the default channel and create a subscription
on that channel. This bugfix updates the registry client's filter
function to ignore non default channel entries.

@benluddy @ecordell @dinhxuanvu addressed everyone's comments.
Also, at this point I think I give up. I haven't been able to reproduce any of the failures in the e2e tests, so my guess is they're just flaky. I updated the subscription e2e test to explicitly check that we're creating a sub with the default channel.

/retest

/retest

/retest

/retest

/test e2e-aws-console-olm

/test e2e-aws-console-olm

/test e2e-aws-olm

/retest

/retest

/retest

/cherry-pick release-4.5

/cherry-pick release-4.4


update: updated notation sign command based on spec

This PR updates notation sign command based on the sign_spec.
Signed-off-by: Patrick Zheng<EMAIL_ADDRESS>

Codecov Report

Merging #417 (5495058) into main (f747031) will decrease coverage by 0.32%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   34.60%   34.28%   -0.33%
==========================================
  Files          23       23
  Lines        1254     1222      -32
==========================================
- Hits          434      419      -15
+ Misses        809      792      -17
  Partials       11       11

Impacted Files
Coverage Δ

cmd/notation/main.go
0.00% <0.00%> (ø)

cmd/notation/manifest.go
0.00% <0.00%> (ø)

internal/cmd/flags.go
52.74% <ø> (ø)

cmd/notation/sign.go
35.18% <80.00%> (-1.76%)
:arrow_down:

cmd/notation/common.go
55.55% <0.00%> (-44.45%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


setting deprecation warning on may crash Atom

When deprecation warning is on , the console window may be swamped with depwarn messages
which causes Atom to hang.
On windows
Steps to reproduce:

set deprecation warning in julia client
set Boot mode to server
re-launch Atom
in the console window type something like a=5 to get it warmed up
type Base. and hit Tab to get a completion .... crash!

One cause of this is fixed by https://github.com/JunoLab/CodeTools.jl/commit/04cd5aded8c3b7a2f45e4559b2e889428375f071, the other by at least mitigated by https://github.com/JunoLab/atom-julia-client/commit/945f9391d1fda2d81f5defb5cda0cc5fe47458fb.


put correct name on status dashboard page

@dlangston Hey, can you also change the plotting Tab name to "Plotting" from "Data Catalog"

@DanielJMaher sure


Add credentials to the job engine Job specification

Here we want to mount the credentials directory to the job Pod so that we can launch kubectl command from within the job engine container(s).

@konstan , this pull request is now ready for review.


Added TvOSScribble by @dcordero

Project URL

https://github.com/dcordero/TvOSScribble
Description

Handwriting numbers recognizer for Siri Remote
Why it should be included to awesome-ios (optional)
Makes it easy for making gestures for numbers instead of typing in the virtual Apple TV keyboard
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 2 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

1807
301
https://github.com/Lab111/Hedwig redirects tohttps://github.com/dereklimbus/hedwig

2071
301
https://github.com/lab111/pivot-slider redirects tohttps://github.com/dereklimbus/pivot-slider

  Generated by :no_entry_sign: Danger

thx!!


Nodes outputting Processes don't work

As well as functions and constant values, nodes can output Processes (nengo.processes.Process derived things). First problem occurs in builder https://github.com/project-rig/nengo_spinnaker/blob/master/nengo_spinnaker/builder/ensemble.py#L35 which can be simply fixed with a not isinstance(connection.pre_obj.output, Process) test (is that the best way?) but it then falls over in https://github.com/project-rig/nengo_spinnaker/blob/master/nengo_spinnaker/operators/value_source.py#L73 where I'm a little sketchy as to what's going on. The following example reproduces:
import nengo
import nengo_spinnaker
import numpy as np
import matplotlib.pyplot as plt

from nengo.processes import WhiteSignal

model = nengo.Network()
with model:
    inp = nengo.Node(WhiteSignal(60, high=5), size_out=2)
    pre = nengo.Ensemble(60, dimensions=2)
    nengo.Connection(inp, pre)

    pre_p = nengo.Probe(pre, synapse=0.01)

nengo_spinnaker.add_spinnaker_params(model.config)
model.config[inp].function_of_time = True

sim = nengo_spinnaker.SpiNNakerSimulator(model)
sim.run(10.0)

Actually, further consideration - have attempted fix in https://github.com/project-rig/nengo_spinnaker/tree/processes example seems to now crash the board...

Fixed by #5, thank you @neworderofjamie.

WhiteNoise init has changed and it's not working again, as you can see by the two plots attached. The value output by it tends to be stable for about  5-8 seconds, then outputs a different value.
Note changing scale to False has no effect on output.
class WhiteNoise(Process):
     def __init__(self, dist=None, scale=True):

import numpy as np
import matplotlib.pyplot as plt
%matplotlib inline

import nengo

from nengo.utils.functions import piecewise

__author__ = 'bogdanp'

import numpy as np
import nengo
from nengo.processes import WhiteNoise
import nengo_spinnaker

model = nengo.Network()
with model:
    # Input
    inp = nengo.Node(WhiteNoise(scale=True))
    pre = nengo.Ensemble(60, dimensions=1)
    nengo.Connection(inp, pre)

    pre_p = nengo.Probe(pre, synapse = 0.1)

nengo_spinnaker.add_spinnaker_params(model.config)
model.config[inp].function_of_time = True

sim = nengo_spinnaker.Simulator(model)

with sim:
    sim.run(5)

plt.figure(figsize=(12, 8))
plt.subplot(2, 1, 1)
plt.plot(sim.trange(), sim.data[pre_p].T[0], c='b', label='Pre')
plt.ylabel("Dimension 1")
plt.legend(loc='best')

<matplotlib.legend.Legend at 0x7f26d5a31d50>

sim_host = nengo.Simulator(model)
sim_host.run(5)

Simulation finished in 0:00:01.

plt.figure(figsize=(12, 8))
plt.subplot(2, 1, 1)
plt.plot(sim_host.trange(), sim_host.data[pre_p].T[0], c='b', label='Pre')
plt.ylabel("Dimension 1")
plt.legend(loc='best')

<matplotlib.legend.Legend at 0x7f26d5104690>


Add support for anomalous data to DataSet.to_reciprocalgrid()

DataSet.to_reciprocalgrid() does not currently enable data to differ between Friedel halves of reciprocal space. This functionality would be useful for things like generating maps from underlying anomalous data. As far as API, this could be implemented with an anomalous=True|False argument. However, it may involve a decision such as how to specify the anomalous columns labels.
Internally, if such a function were called with a two-column anomalous DataSet, it would be possible to implement this method using a call to stack_anomalous() in the place of expand_anomalous(). Implicit in this is that the (+)/(-)-suffixed columns would be renamed to drop the Friedel specifications.

Hey Jack, I am wondering what is the current situation of the issue (Maybe this is not an issue anymore)?
If I have one-column anomalous data (similar to that after calling stack_anomalous), is there anything wrong if I call to_reciprocal_grid?

If I understand correctly, say I have a stacked one-column anomalous data, the only difference would be I have to skip the line p1 = p1.expand_anomalous()  in to_reciprocal_grid function?

Yes -- this is currently unsupported because of the line you mentioned. If one-column anomalous data is provided, it should be sufficient to just skip the call the p1.expand_anomalous(), but I haven't actually tested that.
For 2-column anomalous data, a few more changes will be needed because a call to stack_anomalous() will be needed. We would also need to make some API decisions about how the two columns are specified (e.g. tuple of column labels)

Yes, that makes sense.
How about taking another argument like anomalous=False? And when set to True, whether to callstack_anomalous or skip that line can be determined by the number of columns in the key?
I am happy to create a PR for this if you think above is a good way.

I think we can make the interface work intuitively without the need for anomalous=[True|False]. I think the following should work, but let me know if you think I'm missing something:

If key is a single string, we check whether all HKLs are in the + ASU. If they are, we call p1.expand_anomalous(). If the HKLs are in +/- ASU we skip the call to p1.expand_anomalous(). This should support non-anomalous data, or single-column anomalous.
If the key is a pair of strings, we assume that we are operating in two-column anomalous mode. We call stack_anomalous(), and then treat it as one-column anomalous data as above.

Implicitly, there are two checks that will automatically happen:

stack_anomalous() will confirm that the two columns have the same dtype for us when operating in two-column mode.
expand_to_p1() will ensure that we are operating on a merged DataSet. This function only makes sense for merged data with unique Miller indices, because otherwise the order of the data will matter (the last entry for each Miller index will overwrite the preceding entries in the reciprocal grid).


Remove alloc dependency

This crate would ideally not require a memory allocator.

Something like heapless or arrayvec should be used if necessary but should be avoided. If used array sizes should all be easily changeable as constants or generics (unless they should not be changeable by users of the library).

commit acf2dc2b51d162e26fbb6211a049b4c5a44c4b41 resolved this.


chore: cache PluginProxy

What does it do?
Caches PluginProxy so it does not create a new PluginProxy on every new getAllPlugins() or getPluginByName(), which would set up listeners every time and create a memory leak.

Not sure if directly a result of this PR, but I'm nano and grid-ui are getting out of sync while testing this branch. e.g. toggle geth on from nano, toggle off from grid-ui:


Homebrew download failure (most v1.4.2 url paths contain a typo)

Homebrew installation fails due to a bad download address.
This link gives a 404, and is used by Homebrew:
https://github.com/Hyde46/hoard/releases/download/v1.4.2/hoard_v1.4.2_x86_64-apple-darwin.zip
This link works, and comes from clicking on 'versions' in the github page:
https://github.com/Hyde46/hoard/releases/download/v1.4.2/hoard_v.1.4.2_x86_64-apple-darwin.zip

The live addresses appear to use a v.#.#.# style vs a v#.#.# style.
(the live address style above is used for all the existing links except the amd.deb file)
Looking at a few past releases the current style seems to be the outlier:
"v.1.4.2"

"v1.4.1"

"v1.4.0"

Not especially necessary, but brew response to current install attempt:
Input:
brew tap Hyde46/hoard
brew install hoard

Output:

Error: hoard: Failed to download resource "hoard"
Failure while executing; /usr/bin/env /opt/homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.1.7-16-g59cc141\ \(Macintosh\;\ arm64\ Mac\ OS\ X\ 13.5.1\)\ curl/8.1.2 --header Accept-Language:\ en --retry 3 --fail --location --silent --head --request GET https://github.com/Hyde46/hoard/releases/download/v1.4.2/hoard_v1.4.2_x86_64-apple-darwin.zip exited with 22. Here's the output:
curl: (22) The requested URL returned error: 404
HTTP/2 404
server: GitHub.com
...

Thanks for pointing this out! I need to be more carful with version tagging..
I fixed the release and removed the bad versioning. Using brew to install it should work again


opsgenie_teams with 'opsgenie_teams_args' overwrites the configured value once it's parsed

Similar to a situation described in this discussion: https://github.com/jertel/elastalert2/discussions/534 the following line of code: https://github.com/jertel/elastalert2/blob/master/elastalert/alerters/opsgenie.py#L72 parses args, and then overwrites self.teams. Next time the alert triggers, args are no longer parsed and instead, the result of first parsing is used.
For example, the following rule config:
opsgenie_teams:
-  \"2nd Line Support\"
- \"{owning_team}\"
opsgenie_teams_args:
  owning_team: owning_team

will mean that the first alert will correctly evaluate the owning team from a field in the match (let's say Infrastructure), but each subsequent alert execution will have the self.teams set to:

2nd Line Support
Infrastructure

and will no longer be evaluated
I think the following fixes it:
https://github.com/jertel/elastalert2/pull/1539/files
There's potentially a similar issue with recipients.

fixed in #1539


dev: refactor txpool rpc tests

Describe the enhancement request

Currently, in the tx pool rpc tests, there are quite a few duplications in the construction of the tests. This can be observed in the following file:
https://github.com/kkrt-labs/kakarot-rpc/blob/main/tests/tests/txpool_api.rs
To avoid this repetition and improve the maintainability of the test suite, we propose to refactor the test content by introducing test utilities. These utilities can be built at the beginning of the file and then reused across different tests, leading to cleaner and more concise test code.
Proposed Changes

Create Test Utilities:

Develop reusable functions and structures that encapsulate common setup and teardown logic for the tx pool tests.
Place these utilities at the beginning of the txpool_api.rs file for easy access.

Refactor Existing Tests:

Replace repetitive code in the current tests with calls to the new test utilities.
Ensure that each test remains clear and focused on its specific logic, leveraging the utilities for shared setup.

Related https://github.com/kkrt-labs/kakarot-rpc/pull/1105#discussion_r1611080943

Hey, can you assign me this issue?

I'm working on this issue. And I'm getting a linker error with clang. I had deal with this kind of errors months ago, they are really anoying.
This is the error:
error: linking with `clang` failed: exit status: 254
= note: clang: error: unable to execute command: Killed
          clang: error: linker command failed due to signal (use -v to see invocation)

And this is my config.toml:
# [target.x86_64-unknown-linux-gnu]
# linker = "x86_64-linux-gnu-gcc"

# [target.aarch64-unknown-linux-gnu]
# linker = "aarch64-linux-gnu-gcc"
# /usr/bin/mold
[target.x86_64-unknown-linux-gnu]
linker = "clang"
rustflags = ["-C", "link-arg=-fuse-ld=lld"]

Right now I'm using mold, because i had the same problem when i was setting up the cairo native project and madara project. And using mold, fixed the issue, but with kakarot-rpc it seems that is not working this solution :(
I'm getting the error because I'm trying to see if the test that i was modifying is working properly.

mmmm I am not familiar with this issue, what is the command you are running?

@greged93
I'm using WSL Ubuntu. And when I run cargo build I'm getting that error. I know that error is because WSL while compiling is running out of memory, I have dealt with this in Cairo Native and Madara. And in those projects what I did to fix it, I added this:

I tried to do the same for this project, and is not working :(


Evaluate use of AutoREST generated code for KeyVault

We are not going to do this for the first release.


Support cuDNN 8.3.0

Description
Tasks

[x] Read Release Notes (cuTENSOR / cuSPARSELt / cuDNN / NCCL).
[x] Update FlexCI configuration to test the version.

[x] Fix .pfnci/matirx.yaml #6108
[x] Backport. #6150

[x] Update the library installer.

[x] Fix cupyx/tools/install_library.py. #6108
[x] Backport. #6150

[x] Documentation

[x] Update Requirements section in Installation Guide #6108
[x] Backport. #6150

[x] Implement new features using the version, if any.

Additional Information
No response

Close this issue and open #6168.


Setting className has no effect.

scope.chartConfig = {
options: {
chart: { type: 'line' },
xAxis: { type: 'datetime' }
},
title: { text: 'Weather Forecast' },
className: 'MY-SPECIAL-DESIGN'
};

Try move it into the options? Create a jsfiddle and I could have a look

chart: { type: 'line', className: 'MY-SPECIAL-DESIGN' },


Dynamic and SemiDynamic schemas

Same as https://github.com/zio/zio-schema/pull/205 but for the ZIO 2 branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 6 committers have signed the CLA.:white_check_mark: googley42:white_check_mark: fokot:white_check_mark: thinkharderdev:white_check_mark: vigoo:white_check_mark: TobiasPfeifer:x: Ivan GrebenikIvan Grebenik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


'Variable type field must be a TensorType.' error when running cell2location

Hi,
I've followed the tutorial, however I'm stack during the last part of 2/3. When I run the code above, I get an error.
os.environ["THEANO_FLAGS"] = 'device=cpu,floatX=float32,openmp=True,force_device=True'
r = cell2location.run_cell2location(

      # Single cell reference signatures as pd.DataFrame
      # (could also be data as anndata object for estimating signatures
      #  as cluster average expression - `sc_data=adata_snrna_raw`)
      sc_data=inf_aver,
      # Spatial data as anndata object
      sp_data=adata_vis,

      # the column in sc_data.obs that gives cluster idenitity of each cell
      summ_sc_data_args={'cluster_col': "TaxonomyRank4",
                         # select marker genes of cell types by specificity of their expression signatures
                         'selection': "cluster_specificity",
                         # specificity cutoff (1 = max, 0 = min)
                         'selection_specificity': 0.5
                        },

      train_args={'use_raw': True, # By default uses raw slots in both of the input datasets.
                  'n_iter': 40000, # Increase the number of iterations if needed (see QC below)

                  # Whe analysing the data that contains multiple experiments,
                  # cell2location automatically enters the mode which pools information across experiments
                  'sample_name_col': 'sample'}, # Column in sp_data.obs with experiment ID (see above)

      export_args={'path': data_dir + 'cell2location_model/'
                  }

)

And the error what I get is:
### Summarising single cell clusters ###
### Creating model ### - time 0.0 min
Traceback (most recent call last):
  File "run_cell2location.py", line 191, in <module>
    export_args={'path': data_dir + 'cell2location_model/'
  File "/home/tsztank/miniconda3/envs/cellpymc/lib/python3.7/site-packages/cell2location/run_c2l.py", line 345, in run_cell2location
    **model_kwargs)
  File "/home/tsztank/miniconda3/envs/cellpymc/lib/python3.7/site-packages/cell2location/models/LocationModelLinearDependentWMultiExperiment.py", line 278, in __init__
    total_size=self.X_data.shape)
  File "/home/tsztank/miniconda3/envs/cellpymc/lib/python3.7/site-packages/pymc3/distributions/distribution.py", line 83, in __new__
    return model.Var(name, dist, data, total_size, dims=dims)
  File "/home/tsztank/miniconda3/envs/cellpymc/lib/python3.7/site-packages/pymc3/model.py", line 1117, in Var
    model=self,
  File "/home/tsztank/miniconda3/envs/cellpymc/lib/python3.7/site-packages/pymc3/model.py", line 1737, in __init__
    data = as_tensor(data, name, model, distribution)
  File "/home/tsztank/miniconda3/envs/cellpymc/lib/python3.7/site-packages/pymc3/model.py", line 1691, in as_tensor
    data = tt.as_tensor_variable(data, name=name)
  File "/home/tsztank/miniconda3/envs/cellpymc/lib/python3.7/site-packages/theano/tensor/basic.py", line 158, in as_tensor_variable
    "Variable type field must be a TensorType.", x, x.type)
theano.tensor.var.AsTensorError: ('Variable type field must be a TensorType.', SparseVariable{csr,int16}, Sparse[int16, csr])

Hi @sztankatt
Thanks for using cell2location!

We generally recommend using GPU unless you have a small spatial dataset with e.g. < 100 locations / multi-cell samples (for example @AlexanderAivazidis recently added a notebook showing how to analyse Nanostring WTA data https://github.com/BayraktarLab/cell2location/blob/master/docs/notebooks/cell2loation_for_NanostringWTA.ipynb). Training for the data in the tutorial notebook (2 sections of mouse brain Visium) is going to take >100 hours on CPU but just 25 minutes on GPU. We are working on porting cell2location to numpyro (https://github.com/vitkl/cell2location_numpyro) and pyro that have better CPU performance (hours for demo notebook) but there will always be substantial speedup from using the GPU.

With regard to the error you are getting,
A) If you can share just a few (e.g. 10) observations from your adata_vis and a subset of inf_aver this will help reproduce the error (e.g. by email vitalii.kleshchevnikov@sanger.ac.uk).
B) Could you please print out the type of objects type(inf_aver), type(adata_vis.raw.X)
C) Could you tell which cell2location version you are using (e.g. latest github / singularity container)?

Hi,
I am trying to run through th whole tutorial of cell2location on the data provided by the tutorial before trying it on my own data. I however, encounter problems when arriving at running the actual model. when running:
sc.settings.set_figure_params(dpi = 100, color_map = 'viridis', dpi_save = 100,
                              vector_friendly = True, format = 'pdf',
                              facecolor='white')

r = cell2location.run_cell2location(

      # Single cell reference signatures as pd.DataFrame
      # (could also be data as anndata object for estimating signatures
      #  as cluster average expression - `sc_data=adata_snrna_raw`)
      sc_data=inf_aver,
      # Spatial data as anndata object
      sp_data=adata_vis,

      # the column in sc_data.obs that gives cluster idenitity of each cell
      summ_sc_data_args={'cluster_col': "annotation_1",
                         # select marker genes of cell types by specificity of their expression signatures
                         'selection': "cluster_specificity",
                         # specificity cutoff (1 = max, 0 = min)
                         'selection_specificity': 0.07
                        },

      train_args={'use_raw': True, # By default uses raw slots in both of the input datasets.
                  'n_iter': 40000, # Increase the number of iterations if needed (see QC below)

                  # Whe analysing the data that contains multiple experiments,
                  # cell2location automatically enters the mode which pools information across experiments
                  'sample_name_col': 'sample'}, # Column in sp_data.obs with experiment ID (see above)

      export_args={'path': results_folder, # path where to save results
                   'run_name_suffix': '' # optinal suffix to modify the name the run
                  },

      model_kwargs={ # Prior on the number of cells, cell types and co-located groups

                    'cell_number_prior': {
                        # - N - the expected number of cells per location:
                        'cells_per_spot': 8,
                        # - A - the expected number of cell types per location:
                        'factors_per_spot': 9,
                        # - Y - the expected number of co-located cell type groups per location
                        'combs_per_spot': 5
                    },

                     # Prior beliefs on the sensitivity of spatial technology:
                    'gene_level_prior':{
                        # Prior on the mean
                        'mean': 1/2,
                        # Prior on standard deviation,
                        # a good choice of this value should be at least 2 times lower that the mean
                        'sd': 1/4
                    }
      }
)

I encounter following error, the same type as mentioned above:
---------------------------------------------------------------------------
AsTensorError                             Traceback (most recent call last)
<ipython-input-28-5578f54fa95f> in <module>
     49                         # Prior on standard deviation,
     50                         # a good choice of this value should be at least 2 times lower that the mean
---> 51                         'sd': 1/4
     52                     }
     53       }

/srv/scratch/lottep/anaconda3/envs/cellpymc2/lib/python3.7/site-packages/cell2location/run_c2l.py in run_cell2location(sc_data, sp_data, model_name, verbose, show_locations, return_all, summ_sc_data_args, train_args, model_kwargs, posterior_args, export_args)
    343                 fact_names=fact_names,
    344                 sample_id=sp_data.obs[train_args['sample_name_col']],
--> 345                 **model_kwargs)
    346
    347     ####### Print run name #######

/srv/scratch/lottep/anaconda3/envs/cellpymc2/lib/python3.7/site-packages/cell2location/models/LocationModelLinearDependentWMultiExperiment.py in __init__(self, cell_state_mat, X_data, n_comb, data_type, n_iter, learning_rate, total_grad_norm_constraint, verbose, var_names, var_names_read, obs_names, fact_names, sample_id, gene_level_prior, gene_level_var_prior, cell_number_prior, cell_number_var_prior, phi_hyp_prior, spot_fact_mean_var_ratio, exper_gene_level_mean_var_ratio)
    276                                                                      1 / tt.pow(self.gene_E, 2)),
    277                                                    observed=self.x_data,
--> 278                                                    total_size=self.X_data.shape)
    279
    280             # =====================Compute nUMI from each factor in spots  ======================= #

/srv/scratch/lottep/anaconda3/envs/cellpymc2/lib/python3.7/site-packages/pymc3/distributions/distribution.py in __new__(cls, name, *args, **kwargs)
     81         else:
     82             dist = cls.dist(*args, **kwargs)
---> 83         return model.Var(name, dist, data, total_size, dims=dims)
     84
     85     def __getnewargs__(self):

/srv/scratch/lottep/anaconda3/envs/cellpymc2/lib/python3.7/site-packages/pymc3/model.py in Var(self, name, dist, data, total_size, dims)
   1115                     distribution=dist,
   1116                     total_size=total_size,
-> 1117                     model=self,
   1118                 )
   1119             self.observed_RVs.append(var)

/srv/scratch/lottep/anaconda3/envs/cellpymc2/lib/python3.7/site-packages/pymc3/model.py in __init__(self, type, owner, index, name, data, distribution, total_size, model)
   1735
   1736         if distribution is not None:
-> 1737             data = as_tensor(data, name, model, distribution)
   1738
   1739             self.missing_values = data.missing_values

/srv/scratch/lottep/anaconda3/envs/cellpymc2/lib/python3.7/site-packages/pymc3/model.py in as_tensor(data, name, model, distribution)
   1689         return data
   1690     else:
-> 1691         data = tt.as_tensor_variable(data, name=name)
   1692         data.missing_values = None
   1693         return data

/srv/scratch/lottep/anaconda3/envs/cellpymc2/lib/python3.7/site-packages/theano/tensor/basic.py in as_tensor_variable(x, name, ndim)
    156         if not isinstance(x.type, TensorType):
    157             raise AsTensorError(
--> 158                 "Variable type field must be a TensorType.", x, x.type)
    159
    160         if ndim is None:

AsTensorError: ('Variable type field must be a TensorType.', SparseVariable{csr,int16}, Sparse[int16, csr])

I run the model on an 'old' titan X GPU, as newer GPU's don't support theano anymore.
I installed the package yesterday, based on the environment.yml file provided, and then using the github as mentioned by you.
However, I encountered a problem with the arviz package. When loading the package in python, I received following error:
module 'arviz' has no attribute 'geweke'
For this reason, I installed arviz version 0.10.0 instead of 0.11.2. This made it possible to load the package into python.
If necessary, I can send more information, but I just followed all provided steps.

I did exactly the same as @lopollar, and I am getting the same error as he is.
I also tried to take only one sample for the spatial data and erased the 'sample_name_col': 'sample'.
At first I got an error that 'LocationModelLinearDependentW' is not defined in  cell2location.models. I added it to the models  init.py and then received the same error (AsTensorError) again.
So it is probably not specific to the model and please also check the case for one sample.

Dear @vitkl
A) I'll send the data as you ask
B)
print(type(adata_vis.raw.X))
print(type(inf_aver))```
results in

<class 'scipy.sparse.csr.csr_matrix'>
<class 'pandas.core.frame.DataFrame'>

Hi @lopollar @sztankatt  @onahman!
thanks for using cell2location! Is using docker/singularity container an option for you? We recommend using the containers to avoid version incompatibility issues such as that you are facing now.
Pymc3 and related packages (arviz, theano from pymc3 developers) have undergone major changes recently and , unfortunately, I was not able to adapt cell2location to those changes just yet, sorry. I will likely do that within the next 2-3 weeks.
@lopollar thanks for pointing out the arviz version issue! Also:

as newer GPU's don't support theano anymore

This is not true - I use Tesla V100 / P100 all the time. The issue might be in the latest drivers rather than hardware. Using the containers we provide should help with this issue.
@onahman Sorry for this issue. Using the containers should resolve it. I also just introduced changes that should address it in https://github.com/BayraktarLab/cell2location/commit/d4c4e7f0407af6c9c19a64334e094dafcfe3114e .

@vitkl Thank you for the fast reply!
Is it possible to create a conda / virtual env with the compatible versions?
I am reluctant to move to a docker.. I don't know how it affects performance, but I assume it does and I am not sure how long it will take to set up the GPU in there.

@onahman It should be possible but it will take some trial and error which I cannot do this week. If you decide to do that would be great if you can contribute back.
On performance, 1) the container will not affect training speed; 2) the accuracy of cell2location was tested using driver versions in the container (e.g. CUDA 10.2) - but I would not expect substantial difference with new drivers.
On setting up GPU, I am actually not an expert on setting up this (central institute IT setup singularity for us). Maybe @yozhikoff can help?

@sztankatt I can confirm that your issue is also because of incompatible dependency versions. Cell2location works on your data with our singularity container. Is it possible for you to use the container?
Also, just as a side note, since you are using a technology with a different spatial resolution, I would recommend adjusting these prior accordingly:
'cell_number_prior': {
                        # - N - the expected number of cells per location (1 cell for 10um locations):
                        'cells_per_spot': 8,
                        # - A - the expected number of cell types per location (also 1 for 10um locations):
                        'factors_per_spot': 9,
                        # - Y - the expected number of co-located cell type groups per location (also 1 for 10um locations)
                        'combs_per_spot': 5
                    },

                     # Prior beliefs on the sensitivity of spatial technology (you need to compare the total count per location to snRNA-seq):
                    'gene_level_prior':{
                        # Prior on the mean
                        'mean': 1/2,
                        # Prior on standard deviation,
                        # a good choice of this value should be at least 2 times lower that the mean
                        'sd': 1/4
                    }

Also, if you want to use cell2location plotting (such as automatic plotting for all cell type in cell2location.run_cell2location) or general scanpy plotting - you need to add

adata.obsm['spatial'] slot with X and Y coordinates;
sp_data.uns['spatial'] = {'wt_1': 'random letters', 'wt_2': 'random letters', ... for other samples}
use cell2location.run_cell2location(export_args={'img_key': None}) option

@onahman Setting GPU shouldn't be too hard, we have a short guide about it here. The only potential issue is that it does require root access, is it a problem for you?

@yozhikoff No, I have root access. I will check out the guide.
Thank you!

Hi @lopollar @sztankatt @onahman @yozhikoff !
This error was due to a bug in  cell2location.run_cell2location which failed to recognise the sparse matrix of all possible types and did not covert them to dense np.array. Sorry about this.
Now fixed in https://github.com/BayraktarLab/cell2location/commit/4e260ca3c5e657d3e6c97f5e98c761f5faed8d42

@vitkl thank you!


error backtrace

5910 0x400D4AFB:0x3FFC5930
E (58641) task_wdt: Print CPU 1 backtrace
Backtrace: 0x400825D5:0x3FFB1A60 0x4008392D:0x3FFB1A80 0x4000BFED:0x3FFC36F0 0x4008BB87:0x3FFC3700 0x4008A672:0x3FFC3720 0x4013085E:0x3FFC3760 0x40131A21:0x3FFC3790 0x40131AC9:0x3FFC37B0 0x40132211:0x3FFC37D0
I (63705) MAIN: mqtt_connected_event > MQTT connected
E (79044) MQTT_CLIENT: mqtt_message_receive: transport_read() error: errno=128
E (79045) MQTT_CLIENT: mqtt_process_receive: mqtt_message_receive() returned -1
I (94070) MAIN: mqtt_connected_event > MQTT connected
E (109355) MQTT_CLIENT: mqtt_message_receive: transport_read() error: errno=128
E (109356) MQTT_CLIENT: mqtt_process_receive: mqtt_message_receive() returned -1
I (124720) MAIN: mqtt_connected_event > MQTT connected
E (139885) MQTT_CLIENT: mqtt_message_receive: transport_read() error: errno=128
E (139886) MQTT_CLIENT: mqtt_process_receive: mqtt_message_receive() returned -1
E (147290) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (147290) task_wdt:  - IDLE1 (CPU 1)
E (147290) task_wdt: Tasks currently running:
E (147290) task_wdt: CPU 0: IDLE0
E (147290) task_wdt: CPU 1: loopTask
E (147290) task_wdt: Print CPU 0 (current core) backtrace
Backtrace: 0x4014C1FA:0x3FFB1460 0x4008392D:0x3FFB1480 0x401F361B:0x3FFC04B0 0x4014C8F5:0x3FFC04D0 0x4008AC4C:0x3FFC04F0
E (147290) task_wdt: Print CPU 1 backtrace
Backtrace: 0x400825D5:0x3FFB1A60 0x4008392D:0x3FFB1A80 0x4000BFED:0x3FFC36F0 0x4008CB5F:0x3FFC3700 0x4008A770:0x3FFC3720 0x4013085E:0x3FFC3760 0x40131A21:0x3FFC3790 0x40131AC9:0x3FFC37B0 0x40132211:0x3FFC37D0
I (154922) MAIN: mqtt_connected_event > MQTT connected
E (160129) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (160129) task_wdt:  - IDLE1 (CPU 1)
E (160129) task_wdt: Tasks currently running:
E (160129) task_wdt: CPU 0: IDLE0
E (160129) task_wdt: CPU 1: loopTask
E (160129) task_wdt: Print CPU 0 (current core) backtrace
Backtrace: 0x4014C1FA:0x3FFB1460 0x4008392D:0x3FFB1480 0x401F361B:0x3FFC04B0 0x4014C8F5:0x3FFC04D0 0x4008AC4C:0x3FFC04F0
E (160129) task_wdt: Print CPU 1 backtrace
Backtrace: 0x400825D5:0x3FFB1A60 0x4008392D:0x3FFB1A80 0x4000BFED:0x3FFC36F0 0x4008CB5F:0x3FFC3700 0x4008A770:0x3FFC3720 0x401

MQTT looks to be struggling maintaining a connection and is consuming cpu cycles. This could either be a bad board or just spotty WiFi connection which could be derived from a bad chip.


Search Result List Story

Component in question:

UnorderedList

Description of issue:

It would be great to show an example of UnorderedList being used to show a list of search result items, showing if/when pagination appears.

SearchResultItem should not be a DS element.  It's a DS Heading, Link and Card element.  It should be implemented on the consumer end.
At a high level, List (currently UnorderedList) is a wrapper element.  There should not be elements for specific lists of specific things - rather, those things should exist as stories (or examples) under the List` element

Updated the ticket description accordingly, will make a new ticket for retiring SearchResultItem

https://nypl.github.io/nypl-design-system/storybook/storybook-static/react/index.html?path=/story/unorderedlist--search-results-list this is already done

@hokei Thanks Crystal, music to my ears. Sorry for the Github email spam


convert code bloc examples to rich-codex where possible

Similar to how it is done here https://github.com/nf-core/nf-co.re/blob/518d3d5e8edb2a5a85da1f1e1d920a3e1940818f/.github/rich-codex.yml (which are then manually embed in the markdown files)

hi! Would like to help with this, but would need some help to get more context :)

Rich-codex is my side project tool for automating screenshots of the terminal: https://ewels.github.io/rich-codex/
So the suggestion is to look for places in the website that have code blocks and convert them to screenshots instead, for example as done here. Then they look nicer ✨


panic in readCollectionSize

Please answer these questions before submitting your issue. Thanks!
What version of Scylla or Cassandra are you using?
ScyllaDB 2018.1.10
What version of Gocql are you using?
<EMAIL_ADDRESS>What did you do?
Scanned a struct with many fields, not sure whether any particular field type triggered this.
What did you expect to see?
No panic.
What did you see instead?
panic: runtime error: index out of range

goroutine 78088437 [running]:
github.com/gocql/gocql.readCollectionSize(...)
    /go/pkg/mod/github.com/scylladb/gocql@v1.0.0/marshal.go:1405
github.com/gocql/gocql.unmarshalList(0xfb2ac0, 0xc003a01900, 0xc008a012d5, 0x2, 0x2f, 0xcf7860, 0xc00632a748, 0x918641, 0x4)
    /go/pkg/mod/github.com/scylladb/gocql@v1.0.0/marshal.go:1443 +0xd39
github.com/gocql/gocql.Unmarshal(0xfb2ac0, 0xc003a01900, 0xc008a012d5, 0x2, 0x2f, 0xcf7860, 0xc00632a748, 0xc0073f7130, 0x2)
    /go/pkg/mod/github.com/scylladb/gocql@v1.0.0/marshal.go:152 +0xa3b
github.com/gocql/gocql.scanColumn(0xc008a012d5, 0x2, 0x2f, 0xc001845617, 0x7, 0xc001845630, 0x7, 0xc001845640, 0xc, 0xfb2ac0, ...)
    /go/pkg/mod/github.com/scylladb/gocql@v1.0.0/session.go:1295 +0x291
github.com/gocql/gocql.(*Iter).Scan(0xc00250a360, 0xc00aa406c0, 0x23, 0x23, 0x23)
    /go/pkg/mod/github.com/scylladb/gocql@v1.0.0/session.go:1395 +0x2e6
github.com/scylladb/gocqlx.(*Iterx).StructScan(0xc00183f8c0, 0xdf7280, 0xc00632a600, 0xe78060)
    /go/pkg/mod/github.com/scylladb/gocqlx@v1.2.1/iterx.go:242 +0x1bb
github.com/scylladb/gocqlx.(*Iterx).scanAny(0xc00183f8c0, 0xdf7280, 0xc00632a600, 0xc00183f800, 0xc00250a360)
    /go/pkg/mod/github.com/scylladb/gocqlx@v1.2.1/iterx.go:105 +0x232
github.com/scylladb/gocqlx.(*Iterx).Get(0xc00183f8c0, 0xdf7280, 0xc00632a600, 0xc001714c74, 0xc001714c74)
    /go/pkg/mod/github.com/scylladb/gocqlx@v1.2.1/iterx.go:66 +0x48
github.com/scylladb/gocqlx.(*Queryx).Get(0xc00081b5c0, 0xdf7280, 0xc00632a600, 0xc00081b5c0, 0x40750b)
    /go/pkg/mod/github.com/scylladb/gocqlx@v1.2.1/queryx.go:212 +0x75

The panic appears to be caused by incalid range checks when using protocol version greater than version 2 as in this case readCollectionSize consumes 4 bytes, but the callers of readCollectionSize always check only for 2 bytes.

Possible fix for the panic is at #9

This was fixed in https://github.com/gocql/gocql/pull/1271


Norminette doesnt recognise a missing tab, moulinette sees it as norm error.

Describe the bug
I sent these problems to moulinette;
git@vogsphere.42vienna.com:vogsphere/intra-uuid-d85c9e6b-eecf-44ad-93db-d3512fca2489-4928074-pmosser
ex02 and ex03 were marked as norm errors. Norminette didnt see a problem with them.
Erroneous code

Additional infos

OS: Ubuntu 22.04.2 LTS
python --version:
norminette -v: 3.3.51

Additional context

Hello, please do not provide a link to the vogsphere.
And can you provide a snippet of code with text instead of pictures?
Thank you

12
13 #include <unistd.h>
14
15 void    ft_print_reverse_alphabet(void)
16 {
17     char    letter;
18
19     letter = 'z';
20     while (letter >= 'a')
21     {
22         write (1, &letter, 1);
23     letter--;
24     }
25 }
~
this is the code and norminette didn't recognise there was a missing tab before letter, exact same in the other exercise. I have deleted the vog link.


Add events to Generic Switch XML

--- I'll add regen when ready to merge.
Generic switch XML missing event definitions, this adds them.
Tested with full regen. No code using these.

@jonsmirl it looks like zap updates are needed (or restyle diff)

fast track: xml  changes only

@jonsmirl it looks like zap updates are needed (or restyle diff)

Yes, it need regen before committing. But if I keep regening as top of tree changes I trigger a large amount of pointless CI jobs.


F# support broken 😥 (I am sorry)

if (Path.GetExtension(ProjectFile.Path).Equals(".fsproj", StringComparison.OrdinalIgnoreCase)                  && effectiveGlobalProperties.ContainsKey(MsBuildProperties.SkipCompilerExecution))              {                  // We can't skip the compiler for design-time builds in F# (it causes strange errors regarding file copying)                  effectiveGlobalProperties.Remove(MsBuildProperties.SkipCompilerExecution);              }
Got added after I deleted it to fast while working on F#. This however leads to extra BuildMessageEventArgs being triggered since the full compiling diagnostic/logging is triggered.
Because there is no TaskCommandLineEventArgs for F# I created a big if statement to serve as a check.
This if statement missed something, I did not know of this since I tested without the extra logging from SkipCompilerExecution.
in short: F# support (sourcefiles and references) is broken, I already made a fix :) check PRs
What does the fix do?
-add extra check if _fscArguments already contains data, since only the first BuildMessageEventArgs  to pass my checks contains the data we want.
How debugging went:
I printed all BuildMessageEventArgs senders and messages.
With SkipCompilerExecution I would expect 1 event. There are however multiple, all from the Fsc process, this leads to _fscArguments being overridden with the new data. In this example that would be: ["","The command exited with code 1."]
No worries, fix is available :)

Sorry it took so long to get back to this! I'm merging it in now, thanks a lot for staying on top of the F# support.

Merged and prepping for release


WIP: Managing AWS Credentials on CI/CD

@spara , please take a look at https://github.com/pulumi/docs/pull/2613/commits/1c6c92323ff03f18d9b5076c623e342a0a0ebe79. I pulled the post locally and tried to polish up the very first section (just covering the creation of the IAM User and Group).
That should be a reasonable (if not small) first post in the series. I'll start work on the second post right now, which will cover:

Provide the IAM User’s credentials to your CI/CD system
Automating IAM credential rotation using Pulumi

And then, the last part would be:

Assuming IAM Roles for performing updates
Securing sensitive data using Pulumi
Comparison with using hosted sercret managers

Does that sound like a plan to you?