Tabs JavaScript not removing 'active' class from nav-pills nav-stacked

Expected Behaviour:
When activating a nav-link, the active state gets removed and added to the now active nav-link. Therefore, the active state gets removed and added to the active item. Additionally the content transitions between the current and now active.
Problem:
The active class is not being removed from nav-link. Thus each item can only be navigated to once.
Codepen ( UPDATED ) :
http://codepen.io/anon/pen/ALRGqj?js-preprocessor=none
I hope the syntax is correct since there is no example in the docs:

  Active
  Link
  Link
  Disabled

...

bbb

ccc

edit: May be related to #20039 , but tabs work, pills (stacked) dont

Hi @p-h-i-l!
You appear to have posted a live example (http://codepen.io/anon/pen/ALRGqj.html), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 13, column 3 thru column 75: An element with role=tab must be contained in, or owned by, an element with role=tablist.
line 14, column 3 thru column 65: An element with role=tab must be contained in, or owned by, an element with role=tablist.
line 15, column 3 thru column 71: An element with role=tab must be contained in, or owned by, an element with role=tablist.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Possible duplicate of #19374.

Dupe of #18566 and #19374.


Syntax checking does not work in WSL 2

Describe the bug
The syntax checker does not worker under WSL 2. If we write some invalid code and then save, nothing happens. After some debugging, I found where the issue was located : https://github.com/crystal-lang-tools/vscode-crystal-lang/blob/master/src/crystalUtils.ts#L78
In WSL 2, for my case, document was /mnt///me/my_user/some_dir/some_file.cr instead of /home/my_user/some_dir/some_file.cr. Hence, I replaced the line 78 with return document.replace('/mnt///me', '/home');.
It is probably not a reliable way to fix this and some stuff should be refactored to handle WSL 1 and 2 correctly (or only WSL 2, since it's the new recommended WSL version which behaves differently with the filesystem).
If needed, I may create a PR based on your advices about how to fix it well  ;)
Desktop (please complete the following information):

OS: Windows 10
Crystal version: 1.0
This plugin version: 0.8.2

If you can, please let me know if this is still reproducible on v0.9.0


Provide Feedback During DeID CLI process

Would be useful to have some sort of TQDM type output at the folder and/or file level.  I was de-identifying about 170 images (400 GB) and it seems to be chugging along, but I have no simple way to figure out if it's working or crashed.  Using some linux tricks I can tell it's working ( du -ch  / etc..) but for a less technical user, they wouldn't have any way to figure out what's going on.

Currently there's a click progress bar (implemented in #164) being used by the main redaction loop that apparently logs progress to a file, not the command line. This change was called "quick and dirty" in that PR so I'd like to talk with @marySalvi about what parts of that (if any) are still needed and what exactly its doing, and then perhaps update logging to be more friendly for CLI users. That should be possible next week.


[5.0] Suggest adding illuminate/events to use observers with Eloquent (when using Capsule).

Solves issue such as #7339
Signed-off-by: crynobone<EMAIL_ADDRESS>

:+1:


➕ [RESOURCE] - Data Structures and Algorithms

Idea Contribution

[X] I have read all the resource request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Where do you want to add the resource? Specify the category and section.
I want to add a books section in the Data Structures and Algorithms category and provide links to useful books in this subject.
Provide the URLs of the resources you are adding
Books for Data Structures
In C,
https://oceanofpdf.com/authors/ellis-horowitz/pdf-fundamentals-of-data-structures-in-c-download/
In C++,
https://oceanofpdf.com/authors/adam-drozdek/pdf-data-structures-and-algorithms-in-c-download/
https://oceanofpdf.com/authors/elliot-b-koffman/pdf-objects-abstraction-data-structures-and-design-using-c-download/
In Python,
https://oceanofpdf.com/authors/kent-d-lee/pdf-epub-data-structures-and-algorithms-with-python-download-67294200644/
Books for Algorithms
https://oceanofpdf.com/authors/thomas-h-cormen/pdf-introduction-to-algorithms-by-thomas-h-cormen-download/
https://oceanofpdf.com/authors/charles-e-leiserson/pdf-epub-introduction-to-algorithms-download/
Any alternative approaches/features
No response
Additional Context
No response
Code of Conduct

[X] I follow the CONTRIBUTING GUIDELINE of this project.

Could you please assign this issue to me?


Visualization documentation

[x] documentation on JSON config files
[x] Data generation (including source, description of the process and output format)

Done in commit 1a0529b


offset-in-proxy

@therealprof
Can you tests this change. It adds offset into proxy structure according #115 and can reduce code size in some cases.
It's interesting how debug builds react on this.

r? @Emilgardis
(rust_highfive has picked a reviewer for you, use r? to override)

r? @therealprof

Sure, I'll give it a shot.

Increases code size on dev builds usually by around 10 percent, no change on release builds.

So we have to wait const generics for third part from https://github.com/rust-embedded/svd2rust/pull/331#issue-300628516

Have you tried factoring the bits function into a generic bits function, à la:
fn bits_u32 (self, value: u32, field: u32, mask: u32, offset: usize) -> u32 {
    value &= !(mask << offset);
    value |= ((field as u32) & mask) << offset;
    value
}

and calling that instead?

I don't see how this can help.

Well, we're trying to find a solution for two different problems:

For dev builds we need to have the least amount of code because it won't be optimised away under any circumstance; huge amounts of could and also repetitive code are very bad here
For release builds we're interested in having code which the compiler can properly optimise; repetitive code doesn't matter but if we get rid of it it must be done in a way that the compiler can still see how to get rid of it again

I agree with the goals.  It is easy to implement generic code for readers as they don't have feedback with registers, but it’s harder for writers.
Field writers produce register writers and have different offsets.


Update server to http2

Update Express to use http2.

See #95

Notice: I just realized that spdy cause an issue in with latest nodejs!
There is a deadlock until express5 will come out and we can move to official http2.
See:
https://github.com/tamasszoke/mern-boilerplate/issues/1#issuecomment-483208472

This should be solved now.

Still issue with actual node version.
Fix is comming:

https://github.com/spdy-http2/handle-thing/issues/6#issuecomment-587397067
https://github.com/spdy-http2/handle-thing/pull/13

It seems

spdy-http2/handle-thing#6 (comment)
spdy-http2/handle-thing#13
fix is merged so we need to check with newer node version how it behaves..

I will close it. I updated mm docker file the master to lts node and the dev to nodejs13.


Front page Facebook share uses incorrect image

Clicking the facebook share button the front page, shows a facebook share preview with an incorrect image (not GAMR-related)

This should be good now...
If there are still problems it will probably be that the config for socialAssets is messed up for prod.
if that seems to be the case check this file
https://github.com/eCitizen/gamr-web/blob/master/config.json

@jwalsh Can you have a look at this? I deployed to dev, but no image showed up.

again, what is relevant here is that the prod configuration is correct
(this line: https://github.com/eCitizen/gamr-web/blob/master/config.json#L7)
so my guess is that it needs to be changed to projectgamr.com (or whatever the final domain is) and then it will only work in prod

ok. Tried to deploy to prod but prod went down. @jwalsh Could you have a look at prod?

I had some local changes in the configuration file that created a merge
conflict.  All changes are now in production.
On Mon, Oct 19, 2015 at 11:54 AM, DarkSymmetry<EMAIL_ADDRESS>wrote:

ok. Tried to deploy to prod but prod went down. @jwalsh
https://github.com/jwalsh Could you have a look at prod?
—
Reply to this email directly or view it on GitHub
https://github.com/HumanDynamics/MassScaleSocialSystems/issues/93#issuecomment-149256572
.


Fix GAT interpretability demo for new StellarGraph order changes

This does a small change to node-link-importance-demo-gat.ipynb to get it working again after the switch to the new StellarGraph class. In particular, the change to the new StellarGraph changed the order in which nodes appear. so:

the code that was (effectively) G.nodes()[7] was no longer selecting the node with ID 1109199
the code that was translating between IDs and indices was sometimes doing it via the Gnx (the NetworkX graph) and sometimes via G/graph_nodes (the StellarGraph) which gave different results.

This switches 1 to starting with the actual node ID of interest, and 2 to always using a single list (graph_nodes or nodes as appropriate).
The code is quite poor in many ways here (all of the .index calls are O(n)), but in the interests of getting this fixed as soon as possible (and thus unblocking getting it on CI, which is also likely to be somewhat fiddly, and so can be follow-up work), this tries to keep the changes here minimal and not make any improvements.
See: #868

Codecov Report

Merging #880 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #880   +/-   ##
=======================================
  Coverage     82.3%   82.3%
=======================================
  Files           45      45
  Lines         4901    4901
=======================================
  Hits          4032    4032
  Misses         869     869

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50bb3e2...2998c89. Read the comment docs.

The work to get this notebook running on CI is likely to be a little intricate/fiddly, because it's quite slow at the moment.

(I've started this at https://github.com/stellargraph/stellargraph/pull/881, but more work than that seems to be needed...)


Implement worker manager

In the ockamd demo code, there is only one worker and its address isn't really relevant. We need to implement a worker manager to manage workers and route messages to workers appropriately. This should look very similar to TcpManager or ChannelManager.


Add Ctrl+K Ctrl+D support to skip last selection

Support Ctrl+K Ctrl+D according to Sublime Text behavior

The way I understand Ctrl-K Ctrl-D, it doesn't require you to keep global state that way -- just deselect the primary selection, and add a new selection after it. Is there something I'm missing?


missing error info in evaluateExpression

currently, evaluateExpression throws a "constant" error here if the query failed, where the gnokey cli returns the actual go error
this is a pain for dev where you have to run a modified client or the cli to know the actual error message

+1


Add Redfish provider logger

In order to keep the main log clean of Redfish provider messages, we
added new log file and associated logger that can be used by the
Redfish provider.

@miq-bot assign @gtanzillo
/cc @gberginc @matejart


Handle unlimited ulimit

Handle the ulimit value in the CLI when it's unlimited and not a numeric value.

This sets/influences the values for; worker_rlimit_nofile and worker_connections.
should they be removed and left to the user to optimize (directly nginx config)?

It seems like by default worker_rlimit_nofile sets the value of the ulimit, so we can avoid setting it explicitly. But worker_connections by default is 512 and that definitely needs to be increased.

What is the proper value then?
imo 2 options;

we retain current behaviour, but explicitly need to set a number when its "unlimited"
only retain worker_connections and make it configurable in the config file


unicode is not supported in ResourceGroupOperations

ResourceGroupOperationsImpl
if (Pattern.matches("^[-\w._]+$", resourceGroupName) == false) {
throw new IllegalArgumentException("resourceGroupName");
}
'w' indicates only ascii codes and you may have to involve the code pages of non-ascii in regex if you'd like to search them.
The code example involves the most of Unicode characters:
boolean valid = Pattern.matches("^[\u0080-\u9FFF_\uFB00-\uFFFDh\w._]+$", "表ポあA中Œé鷗停B逍Üßàùªñ");

👍  Thanks for the feedback.
I didn't even know unicode characters are allowed!

ppl working with resource group name in East-Asia and West-Euro sometimes:)

@jianghaolu is this issue still relevant?

@ChenTanyi could you help take a look to see whether this issue is still existing?

I did not find ResourceGroupOperations, maybe it had been changed.
And I test it successful to create a resource group with UTF-8 characters.
I think it has been fixed.


templates location

When using handlebar templates, it's clear from the documentation where to put the templates during development.
However, it is unclear how to run a binary that uses templates in production (not using cargo).
Currently, the templates are found at ${CARGO_MANIFEST_DIR}/templates, which works well when using cargo run because Cargo sets $CARGO_MANIFEST_DIR. It doesn't work well in production because people usually don't have this Cargo-specific variable set.
We should figure where to find the templates when a binary is run outside of a cargo environment. I suggest we have a sequence of fallbacks, like

${TOWER_WEB_TEMPLATE_DIR} or other (suggested by @carllerche)
${CARGO_MANIFEST_DIR}/templates
A templates folder under the current working directory

The first one found would be the one that tower-web uses.
Also note that we probably want to default to something sensible, but not try to give too much flexibility. An application author can still use Handlebars::new_with_registry to get exactly the functionality they want.
1. ${TOWER_WEB_TEMPLATE_DIR}
What's the best name for this variable?
Would we want this variable to point to the templates directory itself? Or a folder in which templates can be found? The first makes a lot of sense on its own, but the second would be more consistent with ${CARGO_MANIFEST_DIR}/templates and ${PWD}/templates.
E.g., if I have my index template at /opt/awesome-web-app/templates/index.hbs, should I set

TOWER_WEB_TEMPLATE_DIR=/opt/awesome-web-app or
TOWER_WEB_TEMPLATE_DIR=/opt/awesome-web-app/templates?

2. ${CARGO_MANIFEST_DIR}/templates
This is already what we're using. Nothing needs to change here.
3. templates under current working directory
I suggest this because it was one of the first things I tried when trying to get this to work. Maybe other people might also make this assumption?
Also, when running in production, it's usually pretty easy to make systemd/upstart/sysv run an application in a given working directory, so it would be pretty easy for the person deploying the application to be able to get this right.

https://github.com/carllerche/tower-web/issues/127#issuecomment-429175374 is asking a similar question.

@bryanburgers Thanks for this. I commented on the PR.
I think you picked the right defaults. My only thought is, if TOWER_WEB_TEMPLATE_DIR is provided but the dir does not exist, that should result in a panic.

CLosed by #139


filters: update iOS interface to take explicit filter name

Description: This avoids generics and some additional complexity on the Kotlin side. Ultimately, we may move to a solution that removes the need to specify a name entirely.
Risk Level: Low
Testing: Local and CI
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

This looks fine to me, though looking over it with fresh eyes I'm wondering if it'd make sense to simply generate a random string for each registered filter factory and use that, rather than putting that burden on the caller (if we expect each factory to be uniquely identifiable). What do you think?
It's also worth noting that consumers could theoretically return different Filter types between invocations of the filter factory's closure, so we should take that into consideration as well

Yep, that was actually the suggestion I made in standup Friday. Actually, I think a String with an incremented value would be even better, since it will avoid the chance of a random collision. It won't work here, because we need dynamic configuration to land first though.

What I can do, is make that part of the dynamic configuration task.


[HUDI-568] Improve unit test coverage

What is the purpose of the pull request
Improve code coverage for the following classes

HoodieTableMetaClient
RocksDBDAO
HoodieRealtimeFileSplit

Brief change log
Added new tests for functions missing coverage
Verify this pull request
Added tests in the following files

TestRocksDBManager.java
TesthoodieTableMetaClient.java
TestHoodieRealtimeFileSplit.java

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #1473 into master will increase coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1473      +/-   ##
============================================
+ Coverage     67.64%   68.05%   +0.40%
  Complexity      261      261
============================================
  Files           348      348
  Lines         16672    16670       -2
  Branches       1694     1694
============================================
+ Hits          11278    11344      +66
+ Misses         4653     4586      -67
+ Partials        741      740       -1

Impacted Files
Coverage Δ
Complexity Δ

...apache/hudi/common/util/collection/RocksDBDAO.java
74.86% <ø> (+17.40%)
0.00 <0.00> (ø)

...pache/hudi/common/table/HoodieTableMetaClient.java
83.76% <0.00%> (+7.14%)
0.00% <0.00%> (ø%)

.../hudi/hadoop/realtime/HoodieRealtimeFileSplit.java
100.00% <0.00%> (+73.52%)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b3194...5d45687. Read the comment docs.


Musixmatch token persistence

Hi, @skuill! I really like your repository, as it provides an extensive and reliable way to retrieve texts from different sources simultaneously. Great job!
As a maintainer of MusixmatchClientLib, I'm always interested in how the library is used, and want to point out some nuances of its usage in your project. It's a suggestion, so feel free to just close the issue tho.
In your code, MusixmatchClient is initialized using new instance of MusixmatchToken, which is completely fine for generating "Desktop" context token (ref: code). However, users might stumble upon rate limits from Musixmatch API, as there's a major cooldown on token generation endpoint. After multiple tests I determined, that tokens with "Desktop" context don't expire automatically at all, so it's worth saving it somewhere on the client side and reusing it when creating a new MusixmatchToken instance (by passing it directly into the MusixmatchToken constructor: new MusixmatchToken(yourSavedToken)). I'm not sure if you save it, but looks like the token's generated every time the MusixmatchClient GetMusixmatchClient() is called.
According to the comments to the referenced method, library works as expected, as it's not designed to be used with official mxm API. I'll walk along the token generation pipeline from the official Musixmatch application to make it clear (hope this doesn't add too much to the issue).
Once one starts the official application, a new token is generated *and saved (the algorithm of token generation is already reverse-engineered, it's what the constructor of MusixmatchToken does). This token is able to do pretty much everything you need (it can fetch lyrics, fetch synced lyrics and search for songs). As the app receives token, it attempts to authenticate the user by giving them an external OAuth link (you can generate a similar link using musixmatchTokenInstance.GetAuthUrl()), that allows user to upload and sync lyrics, but requires Musixmatch account to operate.
Hope it helps debugging failed MusixmatchProvider tests (if they do fail).
Have a wonderful day!
Eimaen

Hello @Eimaen!
Thank you very much for describing in detail the problem of using the token. Thanks also for the awesome library ;)
I will add at least MemoryCache so that I don't have to request token generation from the GetMusixmatchClient method (ref: code).
I have another question. Are there any errors or cases when I need to regenerate the token? Maybe some exception is thrown during the authentication stage? Or we can forget about this case and reuse the generated token when launching the application?

Are there any errors or cases when I need to regenerate the token?

If you're reusing saved token, there's no auth at all. To check if the token is still valid, you can try searching for song (client.SongSearch). If MusixmatchRequestException is thrown, and its StatusCode property == StatusCode.AuthFailed (401), your token's invalid and needs to be regenerated. However, my tokens never expired so far :)

@Eimaen thanks for the explanation!
Added some changes to the pull request: #11
Could I ask for a review if you have time and possibility? I will add this changes to the master soon.

Sure, glad to help!

@Eimaen thank you so much for a help! Closed, published new library version 1.3.2.


Virtualscroll not working properly  > 3.10.x

I'm trying to achieve a list of cards using virtualscrolling as follow:
<ion-list [virtualScroll]="posts" approxItemHeight="200px">

    <ion-item *virtualItem="let post">
      <ion-card>
        <ion-img width="150" height="150" src="/assets/images/1.png"></ion-img>
        <ion-card-content>
          <ion-card-title>
            Nine Inch Nails Live
          </ion-card-title>
          <p>
            The most popular industrial group ever, and largely responsible for bringing the music to a mass audience.
          </p>
        </ion-card-content>
      </ion-card>
    </ion-item>

  </ion-list>

the result is :
https://i.imgur.com/xMJOOrW.png
it doesn't show the images , but when I scroll , then it shows them then hide theme immediately
ionic info:

    @ionic/cli-utils  : 1.10.2
    ionic (Ionic CLI) : 3.10.3

global packages:

    Cordova CLI : 7.0.1

local packages:

    @ionic/app-scripts : 2.1.4
    Cordova Platforms  : android 6
    Ionic Framework    : ionic-ang

System:

    Android SDK Tools : 25.2.3
    Node              : v6.11.0
    npm               : 3.10.10
    OS                : Windows 7

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having? Thanks for using Ionic!

I am going to close this for now since it has been quite a while without a response. If you are still having this issue, please provide a sample application demonstrating your issue via GitHub that we can use to help resolve and test this issue. I will be happy to reopen the issue.

@kensodemann  I'm sorry, I didn't get notification , that you have replied to my post , here is an online example : https://stackblitz.com/edit/ionic-4vdp9u

OK, thx. I will have a look.

@kensodemann thnx alot , I will be waiting, hopefully you find what's wrong!

@kensodemann @AbanoubNassem Could this be related to #13099, with a possible fix being #13101?


fix iothub device update by bumping api version to 2022-10-01

Did you generate this via autorust, or hand edit? I think it's great that you're upgrading to the GA version, but OpenAPI definitions can change between preview and release (I see it all the time since I'm on the review board). I see you dropped some endpoints so maybe that is the case, but I wanted to double check.

It is hand edited. I just tried to fix the current incompatibility with current main. There are two issues:

const API_VERSION: &str = "2021-06-01-preview"; isn't supported anymore
endpoint changed


Grammar Inconsistences

Is the title supposed use is if Tables is plural? I noticed a lot of "is vs are" grammar inconsistences in all of the articles for the Delta Live Tables section when referring to them.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7b1198cd-3ebf-0833-4995-4f9e25f7ad8a
Version Independent ID: 7b1198cd-3ebf-0833-4995-4f9e25f7ad8a
Content: What is Delta Live Tables? - Azure Databricks
Content Source: databricks/delta-live-tables/index.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@nicklamos27
Thanks for your feedback! We will investigate and update as appropriate.


how to set the collector.backend_service in cluster mode

Question

What do you want to know?
After we setup a cluster of 3 collector backend by using consul, how to set  the collector.backend_service field in agent configuration. it should be set to the value of consul's hostPort list(<IP_ADDRESS>:8500,<IP_ADDRESS>:8500,<IP_ADDRESS>:8500) or collector backend's list(<IP_ADDRESS>:11800,<IP_ADDRESS>:11800,<IP_ADDRESS>:11800) or any other?

hi,how can I put a backend address list in agent? set the agent.config "collector.backend_service"?,use xxx.x.x.1:11800,xxx.x.x.2:11800 replace the default value?


[BUG] minor: center the name of the network for L2 network

if possible, center (vertically) L2 networks (other networks have their CIDR shown, 2 rows, centered fine vertically, but L2 network doesn't have the CIDR, so single row, and not centered vertically)

same for other fields - if possible:

@andrijapanicsb @DaanHoogland can you review/test and close against master?

@rhtyd (cc @andrijapanicsb ) i have not found this issue but from the description it isn't clear where (via what path) to look, so bouncing a bit to @andrijapanicsb


feat!: cosmwasm an optional integration to app

Description
added cosmwasm feature as an optional features for app
// to build cosmwasm feature into app
$ EXPERIMENTAL=true make build

closes: #802

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #1547 (c1f6f1f) into main (de91aa1) will decrease coverage by 0.19%.
The diff coverage is 3.70%.

@@            Coverage Diff             @@
##             main    #1547      +/-   ##
==========================================
- Coverage   51.79%   51.59%   -0.20%
==========================================
  Files          71       71
  Lines        6897     6923      +26
==========================================
  Hits         3572     3572
- Misses       3056     3081      +25
- Partials      269      270       +1

Impacted Files
Coverage Δ

ante/ante.go
32.14% <3.70%> (-27.86%)
:arrow_down:

See this commit as an alternative idea to reduce copied functions: 009f87d
What do you think?

See this commit as an alternative idea to reduce copied functions: 009f87d What do you think?

I think it is better to keep old functions only, because we already passing one build flag for experimental config , so no need for new flag again and for we will keep experimental features everything into experimenatal_appconfig  only.

I think it is better to keep old functions only, because we already passing one build flag for experimental config , so no need for new flag again.

There is no need for a new flag. Where did you get an impression that we need a new flag?

We will keep experimental features everything into experimenatal_appconfig only.

On the other hand, the code is a bit more bloated (harder to follow).

@robert-zaremba  Please can you review again


Variable explorer and mime test fixes for tests

For #7369
Make variable explorer tests more deterministic
Fix a missing constant in the mime test

Codecov Report

Merging #7740 into master will decrease coverage by 0.75%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7740      +/-   ##
==========================================
- Coverage   58.81%   58.05%   -0.76%
==========================================
  Files         496      496
  Lines       22115    21755     -360
  Branches     3558     3553       -5
==========================================
- Hits        13006    12630     -376
- Misses       8297     8305       +8
- Partials      812      820       +8

Impacted Files
Coverage Δ

...ience/interactive-common/interactiveWindowTypes.ts
100% <100%> (ø)
:arrow_up:

...nt/datascience/jupyter/invalidNotebookFileError.ts
0% <0%> (-75%)
:arrow_down:

.../client/datascience/jupyter/jupyterConnectError.ts
0% <0%> (-66.67%)
:arrow_down:

...science/jupyter/jupyterKernelPromiseFailedError.ts
0% <0%> (-50%)
:arrow_down:

...ent/datascience/jupyter/jupyterWaitForIdleError.ts
0% <0%> (-50%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-23.53%)
:arrow_down:

src/client/language/characters.ts
12% <0%> (-21.34%)
:arrow_down:

src/client/testing/codeLenses/main.ts
60% <0%> (-17.78%)
:arrow_down:

src/client/datascience/cellFactory.ts
72.34% <0%> (-17.32%)
:arrow_down:

src/client/common/platform/pathUtils.ts
66.66% <0%> (-5.56%)
:arrow_down:

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6346723...18278e0. Read the comment docs.


Dead link: nuget package description

https://www.nuget.org/packages/BeatPulse/
"BeatPulse is a health check library for ASP.NET Core Applications.For more information see http://github.com/Xabaril/CheckPulse"
Wrong/Dead link

Thanks for reporting the wrong link. @unaizorrilla can you change it?

done on 1d59d93be26814e59b6186a79fe3d0f9f50c7642 commit.


Client Sketch example is undocumented

The sketch example is undocumented. Evaluate whether this should be documented, and if not, whether it should be removed.

we should probably remove it

The sketch is now deleted, so this can be closed


[question] deformation network

Thanks for open sourcing your great work!
Could you explain a bit why the deformation network does not require any regularization? e.g. small delta.

Hi, a regularization loss is added to suppress deformation for background points in hypernerf real scenes. In synthetic scenes, it is easy to model structures so this loss is omitted.
https://github.com/hustvl/TiNeuVox/blob/381f931df135b02f6c92e94594defbdc1f9b0afc/run.py#L451-L453

thanks for your explaination


Add nUnit tests and their supporting UWP app

Hi @jonstoneman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@jonstoneman, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Hi @jonstoneman, thank you for contributing to the much needed unit testing for the API surface we have. As we have discussed on separate thread, would you create a different pull request that re-categorized the test cases per API endpoint as we have on https://github.com/Microsoft/WinAppDriver/tree/master/Tests/W3CWebDriver?

Closing this PR.  We can re-evaluate again at a later date when Jon or others have bandwidth to do the porting required.


Lighting

Hello
I'm having problems with lighting at the moment - with my cube having the same colour on all sides.  I'm using 32-bit RGB graphics.
This is my shade code
vec3x colour = ambient_colour * i.colour;
for (int i = 0; i < 1; ++i) {
vec3x ldir = normalize(lights[i].pos - wpos);
fixed16_t ndotl = max(X(0.0f), dot(wnor, ldir));
colour += lights[i].colour * ndotl;
}
colour *= material_colour;
for (int i = 0; i < 3; ++i)
colour[i] = min(X(1.0f), colour[i]);
	out.varyings[0] = colour.x.intValue<<8;
	out.varyings[1] = colour.y.intValue<<8;
	out.varyings[2] = colour.z.intValue<<8;

and this is the single fragment code :
int r = min(max(0, fd.varyings[0] >> 16),255);// >> 2;
int g = min(max(0, fd.varyings[1] >> 16), 255);// >> 3;
int b = min(max(0, fd.varyings[2] >> 16), 255);// >> 2;
SDL_SetRenderDrawColor(m_mainRenderer, r,g,b, SDL_ALPHA_OPAQUE);
SDL_RenderDrawPoint(m_mainRenderer, x, y);
The only thing I can think of that causes it is the normals, but it does the same with a plane too.

I can't spot a mistake in the code, maybe the problem is the input values like position and normal. Take a look at the cow example, it does lighting, maybe you can adapt it to your needs.
Also, using expensive functions like SDL_SetRenderDrawColor and SDL_RenderDrawPoint in the fragment shader will probably cause a massive slowdown.

Silly me - I forgot that, whilst UV coordinates were being set, I wasn't actually calculating the normals properly.
I do need, at some point to get direct access to the SDL2 renderer position (or to a surface - haven't decided which yet), but it would certainly help with the speed (although its not bad at the moment).


Youtube Player fullScreen button does not work when its played in WebView

If I load a Youtube iFrame in this WebView, the fullscreen button does not make the video fullScreen
This only happens in Android.
On iOS FullScreen button makes the Video fullscreen and also supports screen rotation
Source Code:
val webViewState = rememberWebViewStateWithHTMLData(embed.html)
val navigator = rememberWebViewNavigator()
val bgColor = MaterialTheme.colorScheme.surface
DisposableEffect(Unit) {
    webViewState.webSettings.apply {
        isJavaScriptEnabled = true
        supportZoom = false
        backgroundColor = bgColor
        iOSWebSettings.apply {
            showVerticalScrollIndicator = false
            showHorizontalScrollIndicator = false
            scrollEnabled = false
        }
        androidWebSettings.apply {
            safeBrowsingEnabled = true
        }
    }
    onDispose { }
}
WebView(
    state = webViewState,
    modifier = modifier.height(400.dp),
    navigator = navigator,
    captureBackPresses = false
)

Maybe these methods of the WebChromeClient needs to be overriden
override fun onShowCustomView(view: View, callback: CustomViewCallback) {
  super.onShowCustomView(view, callback)
}

override fun onHideCustomView() {
  super.onHideCustomView()
}

@Vaibhav2002 Thanks for your feedback! Yes, this requires us to override the onShowCustomView and handle the full-screen logic inside. This further requires us to support the customWebChromeClient. However, I am sorry that we are not planning to provide this feature currently since it can be complex to implement it in the multiplatform context.
You are welcome to submit a PR for it or directly fork this lib and define your own logic in it.


Reboot when there are no fillers (as opposed to no creeps at all)

This adds a simple filter against the creep find statement which checks for creeps with names that start with filler. This way if the room is filled with other creeps but has no fillers it will still spawn the emergency fillers rather than waiting.

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

dragoonreas
✔

anisoptera
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Importing Animated GLTF from Houdini Fails in Blender Versions Newer Than 3.2.2

Describe the bug
When attempting to import an animated GLTF file exported from Houdini into Blender, the import fails in any version newer than 3.2.2.
I've encountered an issue where newer versions of Blender are unable to import packed animated geometry from GLTF files. This functionality works as expected in Blender 3.2.2, but fails in subsequent versions.
To Reproduce
Steps to reproduce the behavior:

Export an animated GLTF file from Houdini.
Open Blender (version newer than 3.2.2).
Attempt to import the exported GLTF file.
Observe the failure/error.

Expected behavior
The animated GLTF file should import successfully without errors, as it does in Blender version 3.2.2
Screenshots

.blend file/ .gltf
Bubbles_sim_GLTF.zip
Version

OS: Windows
Issue observed in Blender versions newer than 3.2.2

Additional context

The same GLTF files import correctly in Blender 3.2.2.

Thank you for looking into this issue. I hope this information helps in diagnosing and resolving the problem.

Hello,
Seems the glTF file generated by Houdini is not a valid glTF file.
You can check this here: https://github.khronos.org/glTF-Validator/

Custom attribute _numnonpacked uses a non valid type
Some animations have negative time frame

Hello @julienduroure !
It looks like any glTF animation exported with Houdini glTF exporter fails the check with the validator.
Houdini glTF exporter is built in (https://www.sidefx.com/docs/houdini/nodes/out/gltf.html)
The file plays correctly with windows 3D viewer, online glTF viewers and in Blender, untill version 3.2.2.

Only way i found to forward this simulations to blender > 3.2.2,  is to re-export the glTF or glb from blender 3.2.2

Thanks for your reply!

I will add checks to avoid any crash during import

Thanks a lot @julienduroure !!


Watch the filesystem and rebuild files when they change in dev mode.

Coverage remained the same at 87.398% when pulling f54c4d46b7514de3e4e8a1c6b8e02a4474506b27 on mossop/watchfs into b374a4ce16f4c8a5138700b3d422e48899d07959 on master.

r+


Support Terraform's .tf file format

Hi, I'd like to request that terraform's  file formats get supported:
  - Type: *.tf
  - Icon Name: terraform
  - Sample original Icon: SVG can be found (here)[https://www.terraform.io/]
  - Extensions: *.tf *.tf.json

Cheers!

Already supported via terraform extensions. Find one at the marketplace.


Wemo Mini

Has anyone tried this with the new wemo mini. I'm assuming this will still work? If it does work, have you ran into any issues

From my testing, the pull request above adds support for the Wemo Mini.


Page not rendering correctly

Hi! I've installed pufferpanel manually, but now the pages aren't rendering correctly. Can anyone help me please??

Please make a topic on our support forums for assistance. (also please provide more information that you have, we can't help you unless you explain hat is wrong)


[WIP] PT#145848583 filter service by tag

https://www.pivotaltracker.com/story/show/145848583
Ok this is making a comeback!
Now before anyone says "hey that /manage/ prefix on all of the category values looks ugly and redundant" please be aware that in addition to managed tags we can also expect to see /user for user added tags. SOO we left in in as a means to identify the unique tags.
a gif to show ya its workin latest gif in the comments

🌮 💃
ps: coverage drops a bit... :-/ working to up it

For your review @serenamarie125
/cc @Loicavenel

This is looking good @AllenBW
Curious on how it behaves if you set managed days to mon and then environment to tue
Are you replacing it?  Or adding another ( essentially ANDing )

so right now we are anding everything, but the api endpoint doesn't so much like that, will only return results for a single... so maybe rather than anding within an identical category we should replace 🤔

@allenbw I recommend using the replace for now.  We can get feedback and
update later if necessary!
On Sat, Aug 19, 2017 at 8:41 AM Allen Wight<EMAIL_ADDRESS>wrote:

so right now we are anding everything, but the api endpoint doesn't so
much like that, will only return results for a single... so maybe rather
than anding within an identical category we should replace 🤔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq-ui-service/pull/873#issuecomment-323520843,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL7NU3e9923-36jXgFcR9tanrNn3WRdYks5sZtfigaJpZM4O5cIX
.

--
SERENA CHECHILE DOYLE
UX Strategist, unified Management experience & Openshift
UXD Team | Westford Office
<EMAIL_ADDRESS>|<PHONE_NUMBER>
IRC serena | SKYPE serenamarie125 | TWITTER @serenamarie125
https://red.ht/sig TRIED. TESTED. TRUSTED. https://redhat.com/trusted

@AllenBW looks much better, can we do something about /Managed/ and get the description instead?  API limit?

Gotta refer to the comment I made above @Loicavenel

Now before anyone says "hey that /manage/ prefix on all of the category values looks ugly and redundant" please be aware that in addition to managed tags we can also expect to see /user for user added tags. SOO we left in in as a means to identify the unique tags.

When you say "do something"  what are you thinking?  I can probably make it more natural, but again, it represents a category of tabs :-/

@serenamarie125 @Loicavenel  ok so how about this for formatting (of tag category) will not break when we see user vs managed tags...

@serenamarie125 still working on getting category replace working, proving to be a bit of a 🐻 at the moment

@AllenBW could you do something to boost code coverage?

@AllenBW I still don't understand why we have "Managed"?
Also, are you showing Category name or description?

@Loicavenel managed is a baked in tag, comes with miq.  Users can also create tags, these show up as user. Category name is being shown, filter aliases aren't yet possible with pf-ang.

@AllenBW Ok, I do understand for Managed versus User but not showing the Description is going to be challenging.. for example, you are going to show "cc" and not "Cost Center" this will be very confusing, I think that is the same for Tags...

@Loicavenel ah yeah ang-pf doesn't support aliases (filtering on a value different than what is displayed), and /manage/cc/001 etc is what the api needs for us to correctly display the desired results.  Is this a no go without displaying the description ie alias support? Please advise on how to proceed.

@AllenBW So, there are 2 issues:  you don't get the information from the API? and ang-pf does not support alias?

@Loicavenel one issue, we do get the information from the api, looks like this displayName: "Cost Center: Cost Center"  we do not have the ability to display Cost Center, an alias for the query value /managed/cc/001.  Can totally do this work, just means filter by tag will be held up a bit.

@AllenBW We should show the "description" and not the "name", the SUI should be easy of use. I prefer to don't release the feature without it.

@Loicavenel okie dokie, will put this back in WIP then.

@AllenBW thanks for the flexibility

@Loicavenel heeeeey could ya checkout the functionality in the gif on this linked pr closer to what you're looking for in terms of functionality?

so the above gif is contingent on https://github.com/patternfly/angular-patternfly/pull/584 making it in, as soon as it does, will update version of pf-ang and we'll it'll work!

@chriskacerguis @Loicavenel @serenamarie125 Okie dokie, alias support is here!  check it out in the above comment, hoping this is gooood enough to go... Will up code coverage in a followup pr  🙇♀

@AllenBW Great, the drop down look good but the filter selected is still using the old display...

@Loicavene good point, it also shows up in the results below, gonna dig a little deeper and address each of those locations

Ok sooooo have a new pr out in patternfly, gonna do the thing from yesterday, update this pr to work with the new code, and will update it when the ang-pf makes it in https://github.com/patternfly/angular-patternfly/pull/589

@Loicavenel @serenamarie125 @chriskacerguis lets try this again....  hoping this is good enough to get in, alias values are the only value user ever sees

Perfect Thanks

Ping @serenamarie125 and @Loicavenel, your thoughts / approval would be appreciated :)

Last video looks good for me.

Added ux/approved for @serenamarie125

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1502306


Add a link to Mailjet adapter repo

Hello,
As it is stated in #230 , I created a separate repo for the Mailjet adapter.

Thanks so much @Moxide!

You're welcome ;-)


Allow pushing changes from a BriefcaseDb opened readonly

Use BriefcaseDb.executeWriteable and make that function open the ServerBasedLocks lock control.

@ImVeryLost Are there any other internal apis in use by iTS that you know of? I don't think that should be necessary/allowed.

@ImVeryLost Are there any other internal apis in use by iTS that you know of? I don't think that should be necessary/allowed.

@kabentley there is an aggregate issue for such usages - https://github.com/iTwin/itwinjs-backlog/issues/1062
Most violations come from nested dependencies


Plugin on Synology

Hi I want to use your plugin on synology but somehow it is not working.
The following I have in domoticz log:
2020-11-23 14:09:04.554 Error: (SolarEdge_ModbusTCP) failed to load 'plugin.py', Python Path used was '/usr/local/domoticz/var/plugins/domoticz-solaredge-modbustcp-plugin/:/var/packages/py3k/target/usr/local/lib/python38.zip:/var/packages/py3k/target/usr/local/lib/python3.8:/var/packages/py3k/target/usr/local/lib/python3.8/lib-dynload:/var/packages/py3k/target/usr/local/lib/python3.8/site-packages'.
2020-11-23 14:09:04.555 Error: (SolarEdge) Module Import failed, exception: 'ModuleNotFoundError'
2020-11-23 14:09:04.555 Error: (SolarEdge) Module Import failed: ' Name: solaredge_modbus'
2020-11-23 14:09:04.555 Error: (SolarEdge) Error Line details not available.
2020-11-23 14:10:12.300 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:10:26.351 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:10:40.387 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:10:54.422 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:11:08.457 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:11:22.495 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:11:36.534 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:11:50.583 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:12:04.619 Error: SolarEdge hardware (7) thread seems to have ended unexpectedly
2020-11-23 14:12:11.980 Error: (SolarEdge_ModbusTCP) failed to load 'plugin.py', Python Path used was '/usr/local/domoticz/var/plugins/domoticz-solaredge-modbustcp-plugin/:/var/packages/py3k/target/usr/local/lib/python38.zip:/var/packages/py3k/target/usr/local/lib/python3.8:/var/packages/py3k/target/usr/local/lib/python3.8/lib-dynload:/var/packages/py3k/target/usr/local/lib/python3.8/site-packages'.
2020-11-23 14:12:11.980 Error: (SolarEdge) Module Import failed, exception: 'ModuleNotFoundError'
2020-11-23 14:12:11.980 Error: (SolarEdge) Module Import failed: ' Name: solaredge_modbus'
2020-11-23 14:12:11.980 Error: (SolarEdge) Error Line details not available.
2020-11-23 14:13:14.800 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:13:28.846 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:13:42.878 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:14:10.946 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:14:24.982 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:14:39.017 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:14:53.067 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:15:07.162 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:15:21.194 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:15:35.229 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:15:49.266 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:16:03.307 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:16:17.345 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:16:31.402 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:16:45.440 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:16:59.478 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly
2020-11-23 14:17:13.515 Error: SolarEdge hardware (6) thread seems to have ended unexpectedly

Hi To0wnn,
The plugin uses the solaredge_modbus library (https://github.com/nmakel/solaredge_modbus) to communicate with the inverter. Looking at your log, that library is not installed.
On Ubuntu, I would do the following to install that library:
cd domoticz/plugins/domoticz-solaredge-modbustcp-plugin
sudo pip3 install -r requirements.txt

But I have no idea how/if that would work on a Synology NAS.

I already did but somehow it is not working
Requirement already satisfied: solaredge_modbus==0.6.2 in<EMAIL_ADDRESS>(from -r requirements.txt (line 1)) (0.6.2)
Requirement already satisfied: pymodbus>=2.3.0 in<EMAIL_ADDRESS>(from solaredge_modbus==0.6.2->-r requirements.txt (line 1)) (2.4.0)
Requirement already satisfied: pyserial>=3.4 in<EMAIL_ADDRESS>(from pymodbus>=2.3.0->solaredge_modbus==0.6.2->-r requirements.txt (line 1)) (3.5)
Requirement already satisfied: six>=1.15.0 in<EMAIL_ADDRESS>(from pymodbus>=2.3.0->solaredge_modbus==0.6.2->-r requirements.txt (line 1)) (1.15.0)

I download solaredge_modbus separately and run example.py it works

Looking at your initial log entries, the Domotociz runtime is using the following paths to search for the modules:
/usr/local/domoticz/var/plugins/domoticz-solaredge-modbustcp-plugin/
/var/packages/py3k/target/usr/local/lib/python38.zip
/var/packages/py3k/target/usr/local/lib/python3.8
/var/packages/py3k/target/usr/local/lib/python3.8/lib-dynload
/var/packages/py3k/target/usr/local/lib/python3.8/site-packages

Looking at your last message, the libraries are installed in:
<EMAIL_ADDRESS>
You could try to move these 4 .egg files into one of the folders that Domoticz is using....

Actually the same path all .egg files are standing in the same folder

As I don't have a Synology NAS available to test this, I did a search in the Domoticz forum:
https://domoticz.com/forum/search.php?keywords=synology+ModuleNotFoundError
Got 5 hits, but this topic looks interesting:
https://domoticz.com/forum/viewtopic.php?f=6&t=34232
I think this is not an issue with this plugin, but its an issue running any plugin on a Synology NAS.
Please have a look at the Domoticz forum.


scc: 2.11.0 -> 2.12.0

Motivation for this change
https://github.com/boyter/scc/releases/tag/v2.12.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 86384 1

1 package built:
- scc


[release-1.6] Stop using buildx for docker.save

This is an automated cherry-pick of #24790

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.6
b7074aa933b0ef97cf12f9c3d0da4fbb6d525d47
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Support Python 3.11

Now that Pastastore supports python 3.11 (https://github.com/pastas/pastastore/pull/93), HydroPandas should be fine as well.

The current issue fail on py311-ubunti seems to be with Linux installation. Maybe you can shed some light on this @dbrakenhoff ?
× python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [27 lines of output]
      Package hdf5 was not found in the pkg-config search path.
      Perhaps you should add the directory containing `hdf5.pc'
      to the PKG_CONFIG_PATH environment variable
      No package 'hdf5' found
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-6xopw9h7/netcdf4_61f6788baf8d4d23a17[72](https://github.com/ArtesiaWater/hydropandas/actions/runs/5597983180/jobs/10237044158?pr=128#step:5:73)c10ae8c3459/setup.py", line 419, in <module>
          _populate_hdf5_info(dirstosearch, inc_dirs, libs, lib_dirs)
        File "/tmp/pip-install-6xopw9h7/netcdf4_61f6788baf8d4d23a1[77](https://github.com/ArtesiaWater/hydropandas/actions/runs/5597983180/jobs/10237044158?pr=128#step:5:78)2c10ae8c3459/setup.py", line 360, in _populate_hdf5_info
Error:           raise ValueError('did not find HDF5 headers')
      ValueError: did not find HDF5 headers
      reading from setup.cfg...

          HDF5_DIR environment variable not set, checking some standard locations ..
      checking /home/runner/include ...
      hdf5 headers not found in /home/runner/include
      checking /usr/local/include ...
      hdf5 headers not found in /usr/local/include
      checking /sw/include ...
      hdf5 headers not found in /sw/include
      checking /opt/include ...
      hdf5 headers not found in /opt/include
      checking /opt/local/include ...
      hdf5 headers not found in /opt/local/include
      checking /usr/include ...
      hdf5 headers not found in /usr/include
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

I can reproduce the issue locally. It has to do with the netCDF4 package being pinned at 1.5.8. Removing this version requirement I can install the package, but it was put there for a reason so we should check why that was.

Some flake issue is now causing the test to stop. Leaving that fix to you @martinvonk :)

My specialty, thank you :)


RFC Add elemental to the installer recipe

This module is the defacto way to add content to pages these days. It should be added to the installer recipe, either directly or as part of recipe-cms.
Note that it wouldn't make any sense to include this in the recipe without adding some default config - so we would need to agree on what the appropriate default config would be. I've listed two options here - if anyone can think of a different option I'll happily add it to this description for discussion.
Possible options:
Add a new page type
I don't personally like this option but I can see arguments for it.

We would need to add a new class for this page type
If we don't update the simple theme to output $ElementalArea we would need a separate template file for this page type explicitly - which would likely be deleted in all projects because it won't go with the markup for the rest of their bespoke theme
This means there are at least two files projects need to amend or remove to change the defaults
This would not automatically add elemental blocks anywhere they're not wanted

But it also presents a more confusing editing experience by default, where the default pages have hardcoded WYSIWYG field and only this one special page type has elemental blocks

Apply ElementalPageExtension to Page or SiteTree by default
This is my preferred option.

It gives a yml file with a (very basic) example of setting config for elemental blocks

Because this is in a recipe, the yml is added to the project, so developers can alter or remove it to their heart's content
New projects are more likely to update this file than create a new one if starting from scratch
New projects which have some boilerplate already set up will only have to delete this one yml file to remove to completely override the defaults

Gives all the benefits of elemental out of the box on first dev/build (i.e. sane defaults)
We would need some way to convert the default content into elements (there's already a task that does this, we just need to make that task run automatically after the first default records creation or something)

This is really the only complicated part, but honestly it's something that would be beneficial for this module anyway.

We can use the ignored_classes config array to explicitly not apply this to redirector and virtual pages
We would need to update the simple theme to include $ElementalArea (which imo is something we should do anyway)

I very strongly disagree with this.
a) it presumes that every site uses elemental, which is very much not the case
b) there are so many flaws and issues with elemental that it simply can't be pushed as a defacto standard

This module is the defacto way to add content to pages these days

No it's not. At all.

Even though we used Elemental for nearly all our site builds and built quite a complex and rich boilerplate around it with what we commonly needed, I also think it should NOT be the default.
I would support making it as easy as possible to install and provide sane defaults like what is described in the RFC, but having it opt-in, not opt-out.
It reminds me of the CWP recipe where it was initially thought everyone would want the defaults like news page, events holders, footer holder page types etc., but they hardly ever worked for the majority of the projects our clients wanted, so it was more about having a way how to remove/hide all that and keep the bare minimum required.

I use elemental a lot but also have doubts it would be a good default. "elemental friction" like #945, #738, inline editing is hardly usable cos of to many things & fields that do not work, moving blocks is not possible out of the box, virtual-element cannot be used for form-elements, handling around versioning & archive -> restoring an element is an exercise in pain cos probable it has no title but you cannot make title a required field, anchor-linking is also not well supported, etc. The elemental experience ATM has too many rough edges to be a default.

Sounds like we're not ready for this one yet. Closing.


fix: Router with redirect in server mode

Description
I try to use redirect into Router but when I try to use it I got always an exception.
Steps To Reproduce
Simply add a redirect to a base app created with Jaspr-CLI, like this:
  @override
  Iterable<Component> build(BuildContext context) sync* {
    yield div(classes: 'main', [
      const Header(),
      Router(
        routes: [
          Route(
              path: '/',
              title: 'Home',
              builder: (context, state) => const Home()),
          Route(
              path: '/about',
              title: 'About',
              builder: (context, state) => const About()),
        ],
        redirect: (context, state) => "/",
      ),
    ]);
  }

With this I try to redirect all to home page and I got this when I try to navigate into /about path:
[SERVER] [ERROR] ERROR - 2024-04-06 01:04:59.690111
[SERVER] [ERROR]
[SERVER] [ERROR] GET /about
[SERVER] [ERROR] Error thrown by handler.
[SERVER] [ERROR] UnimplementedError: Routing unavailable on the server
[SERVER] [ERROR] package:jaspr_router/src/platform/platform_server.dart 24:5  HistoryManagerImpl.replace
[SERVER] [ERROR] package:jaspr_router/src/router.dart 102:41                  RouterState.initRoutes.<fn>

Oh I see, that error should only come when trying to do Router.push() from the server, but not for resirects

This is now fixed on main. Will be part of the next release.


[stable/kibana] add Monotek to Owners; Chart -> 1.0

Signed-off-by: Casey Kuhlman<EMAIL_ADDRESS>What this PR does / why we need it:
Bumps chart to 1.0 based on number of inputs and traffic; my interpretation is that it is safe to consider it production worthy chart.
Special notes for your reviewer:
Adds @monotek to Owners (pending his approval) as to add resilience to the review process given that a single owner for a heavily trafficked chart is sub-optimal.
Checklist

[x] DCO signed
[x] Chart Version bumped

/assign @monotek

/assign @davidkarlsen

Approval: https://github.com/helm/charts/pull/9351#issuecomment-439796613

/assign @unguiculus

/ok-to-test
/assign
/lgtm

Thanks @davidkarlsen!


Allow env vars to be used instead of editing sh files

To make this more automated without people needing to edit the files, read settings from environment variables and then default to what's in the file. That will allow people to set env vars, clone this repo and just run it.

I like it - I will add that next time I am fiddling with this stuff - if any one would like to send a PR feel free


fastcdr: init at 1.1.1

Description of changes
https://github.com/eProsima/Fast-CDR/
eProsima Fast CDR is a C++ library that provides two serialization mechanisms. One is the standard CDR serialization mechanism, while the other is a faster implementation that modifies the standard.
This pkg in other distros: https://repology.org/project/fastcdr/versions
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2654

@AndersonTorres, maybe you can give it another try?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1133


Server-side Pagination: Pods list not updated after resource deleted

Setup

Rancher version: v2.9-head
Rancher UI Extensions:
Browser type & version:

Describe the bug
Pods list is not updated after the resource is deleted until Refresh button is clicked.

To Reproduce

go to Global settings > feature flags > enable ui-sql-cache
go to Global settings > performance > enable `Server-sdie Pagination'
go to cluster dash
click Pods in side nav
create a Pod
delete the Pod
notice pod is not removed from list

Result
Pods list is not updated after the resource is deleted.
Expected Result
Pods list is updated after the resource is deleted.

Screenshots
https://github.com/user-attachments/assets/c60f5709-369f-4b55-b2e1-74185d1264d3

Additional context
Similarly, after the newly created pod resource is populated on the list, the status and other columns are not updated.

Similar to https://github.com/rancher/dashboard/issues/11498#issuecomment-2242470252

/backport v2.10.1

@richard-cox I think there's actually two situations for this issue:

In 2.11 and onward I believe this one will be resolved with https://github.com/rancher/dashboard/issues/12734
Prior to 2.11 in backports without the new change event ( I'm assuming the change event is only available in 2.11, correct me if I'm wrong) we have an issue and I think it can only be resolved via polling. If we update the resources immediately after we initiate the deletion of the resource we enter a terminating state and the resource will still be present. We could manually remove the items from the list but I think this is a bad idea.

Is there any concern with doing poling from the pods page?
Do we want to do the backport if we have to poll?

Example of manual refresh immediately after deleting:

I'd agree, any changes like deleting a resource should result in a request to re-paginate the list which should be covered by #12734.
I think we can drop backports for these bugs (i've tidied up the backlog). Pre 2.11 is only for trial / non-production environments and we might be cutting it close for 2.11 changes.


feat: Add exports.types to package.json

This allows TypeScript to correctly resolve type imports when using Node's module resolution with:

"moduleResolution": "NodeNext", or
"moduleResolution": "Node16"

Refs:

Typescript docs
Node docs

Closing this awaiting further feedback in https://github.com/ProseMirror/prosemirror-view/pull/131


Similar css js render issue for Netlify Host

First of all your theme is amazing and i have learnt a lot from it.
Trying to play around with it by making a blog. Everything seems to be perfect running local until I serve it to Netlify. Obviously your pipeline is a bit different from what I have been blogging on another 2 years old blog. I have spent hours trying to figure out the problem yet I have to surrender to it coming to seek your help.
I am not sure there are steps i have been missing. Originally I was wondering it was just a problem of relative link. I tried to change the baseURL from "/" to a domain. It seems doesn't work and I have no clues whether i need to change something on the partial/head.html on the href for the min.js and min.css.
Here is the website https://www.nipponhashi.com and I can see the from the console returning .min.js file missing as the href is pointing to dist/blahblahblah.
Did I miss something so that I cannot generate the html properly with a whole link https://www.nipponhashi.com/dist/blah for it?
I am looking forward to seeing your reply soon.

Hi,
Thanks for trying it out!
The URLs seem to be correct with the latest updates. Maybe check if hugo (instead of hugo serve) did build the site correctly? Other than that maybe it has something to do with your Netlify build. Able to post them here?
Other than that as long as you have those files in static/dist (https://github.com/puresyntax71/hugo-theme-chunky-poster/tree/master/static/dist), I think it should've worked.

I will come back in a bit and tell you the result later tonight . Thanks for quick reply!

Building sites … WARN 2020/05/02 19:48:28 Markup type mmark is deprecated and will be removed in a future release. See https://gohugo.io//content-management/formats/#list-of-content-formats
               | EN

-------------------+-----
Pages            | 51
Paginator pages  |  0
Non-page files   | 10
Static files     | 12
Processed images |  6
Aliases          |  5
Sitemaps         |  1
Cleaned          |  0
when I build hugo. I tried yarn build and hugo build as well. No error.
Here is netlify deploy after pushing to GitHub
7:51:15 PM: Build ready to start
7:51:17 PM: build-image version: 2dbd444fcdce00cf06325060a8238d5ae3e86774
7:51:17 PM: build-image tag: v3.3.7
7:51:17 PM: buildbot version: d305548225ac57bb00eb5a596b0b8674e76a4681
7:51:17 PM: Fetching cached dependencies
7:51:17 PM: Starting to download cache of 155.5MB
7:51:18 PM: Finished downloading cache in 873.099903ms
7:51:18 PM: Starting to extract cache
7:51:25 PM: Finished extracting cache in 6.95279431s
7:51:25 PM: Finished fetching cache in 7.892523998s
7:51:25 PM: Starting to prepare the repo for build
7:51:26 PM: Preparing Git Reference refs/heads/master
7:51:27 PM: Found Netlify configuration file netlify.toml in site root
7:51:27 PM: Found Netlify configuration file(s). Overriding site configuration
7:51:27 PM: Starting build script
7:51:27 PM: Installing dependencies
7:51:27 PM: Started restoring cached node version
7:51:31 PM: Finished restoring cached node version
7:51:31 PM: Attempting node version '8.17.0' from .nvmrc
7:51:32 PM: v8.17.0 is already installed.
7:51:33 PM: Now using node v8.17.0 (npm v6.13.4)
7:51:33 PM: Attempting ruby version 2.6.2, read from environment
7:51:35 PM: Using ruby version 2.6.2
7:51:35 PM: Using PHP version 5.6
7:51:35 PM: Started restoring cached node modules
7:51:35 PM: Finished restoring cached node modules
7:51:35 PM: Started restoring cached yarn cache
7:51:35 PM: Finished restoring cached yarn cache
7:51:36 PM: Installing NPM modules using Yarn version 1.12.1
7:51:36 PM: yarn install v1.12.1
7:51:36 PM: warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
7:51:36 PM: [1/4] Resolving packages...
7:51:37 PM: success Already up-to-date.
7:51:37 PM: Done in 0.90s.
7:51:37 PM: NPM modules installed using Yarn
7:51:38 PM: Started restoring cached go cache
7:51:38 PM: Finished restoring cached go cache
7:51:38 PM: unset GOOS;
7:51:38 PM: unset GOARCH;
7:51:38 PM: export GOROOT='/opt/buildhome/.gimme/versions/go1.12.linux.amd64';
7:51:38 PM: export PATH="/opt/buildhome/.gimme/versions/go1.12.linux.amd64/bin:${PATH}";
7:51:38 PM: go version >&2;
7:51:38 PM: export GIMME_ENV='/opt/buildhome/.gimme/env/go1.12.linux.amd64.env';
7:51:38 PM: go version go1.12 linux/amd64
7:51:38 PM: Installing missing commands
7:51:38 PM: Verify run directory
7:51:38 PM: Executing user command: npm run build
7:51:38 PM: ><EMAIL_ADDRESS>prebuild /opt/build/repo
7:51:38 PM: > rimraf dist
7:51:38 PM: ><EMAIL_ADDRESS>build /opt/build/repo
7:51:38 PM: > npm run build:webpack && npm run build:hugo
7:51:38 PM: ><EMAIL_ADDRESS>build:webpack /opt/build/repo
7:51:38 PM: > cross-env NODE_ENV=production webpack --config webpack.prod.js
7:51:42 PM: Hash: 14d63f78a92f0c205631
7:51:42 PM: Version: webpack 4.42.1
7:51:42 PM: Time: 2243ms
7:51:42 PM: Built at: 2020-05-02 11:51:42
7:51:42 PM:          Asset       Size  Chunks                         Chunk Names
7:51:42 PM:    fonts/.keep    0 bytes          [emitted]
7:51:42 PM: main.14d63.css  505 bytes       0  [emitted] [immutable]  main
7:51:42 PM:  main.14d63.js   3.68 KiB       0  [emitted] [immutable]  main
7:51:42 PM: Entrypoint main = main.14d63.css main.14d63.js
7:51:42 PM: [0] ./src/index.js 122 bytes {0} [built]
7:51:42 PM: [1] ./src/css/main.css 714 bytes {0} [built]
7:51:42 PM: [3] ./node_modules/mini-css-extract-plugin/dist/loader.js!./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/src!./node_modules/sass-loader/dist/cjs.js!./src/css/main.css 39 bytes {0} [built]
7:51:42 PM:     + 2 hidden modules
7:51:42 PM: Child mini-css-extract-plugin node_modules/css-loader/dist/cjs.js!node_modules/postcss-loader/src/index.js!node_modules/sass-loader/dist/cjs.js!src/css/main.css:
7:51:42 PM:     Entrypoint mini-css-extract-plugin = *
7:51:42 PM:     [0] ./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/src!./node_modules/sass-loader/dist/cjs.js!./src/css/main.css 888 bytes {0} [built]
7:51:42 PM:         + 1 hidden module
7:51:43 PM: ><EMAIL_ADDRESS>build:hugo /opt/build/repo
7:51:43 PM: > hugo -d ../dist -s site -v
7:51:43 PM: INFO 2020/05/02 11:51:43 Using config file:
7:51:43 PM: Building sites …
7:51:43 PM: INFO 2020/05/02 11:51:43 syncing static files to /opt/build/repo/dist/
7:51:43 PM: WARN 2020/05/02 11:51:43 Markup type mmark is deprecated and will be removed in a future release. See https://gohugo.io//content-management/formats/#list-of-content-formats
7:51:43 PM:                   |
7:51:43 PM:  EN
7:51:43 PM: -
7:51:43 PM: ------------------+
7:51:43 PM: -----
7:51:43 PM: Pages
7:51:43 PM: |
7:51:43 PM: 51
7:51:43 PM: Paginator pages
7:51:43 PM: |
7:51:43 PM:  0
7:51:43 PM: Non-page files
7:51:43 PM: |
7:51:43 PM: 10
7:51:43 PM: Static files
7:51:43 PM: |
7:51:43 PM:  7
7:51:43 PM: Processed images |  6
7:51:43 PM: Aliases          |  5
7:51:43 PM:   Sitemaps         |
7:51:43 PM:  1
7:51:43 PM:   Cleaned          |  0
7:51:43 PM: Total in 115 ms
7:51:43 PM: Skipping functions preparation step: no functions directory set
7:51:43 PM: Caching artifacts
7:51:43 PM: Started saving node modules
7:51:43 PM: Finished saving node modules
7:51:43 PM: Started saving yarn cache
7:51:43 PM: Finished saving yarn cache
7:51:43 PM: Started saving pip cache
7:51:43 PM: Finished saving pip cache
7:51:43 PM: Started saving emacs cask dependencies
7:51:43 PM: Finished saving emacs cask dependencies
7:51:43 PM: Started saving maven dependencies
7:51:43 PM: Finished saving maven dependencies
7:51:43 PM: Started saving boot dependencies
7:51:43 PM: Finished saving boot dependencies
7:51:43 PM: Started saving go dependencies
7:51:43 PM: Finished saving go dependencies
7:51:43 PM: Build script success
7:51:43 PM: Starting to deploy site from 'dist'
7:51:43 PM: Creating deploy tree
7:51:43 PM: Creating deploy upload records
7:51:43 PM: 0 new files to upload
7:51:43 PM: 0 new functions to upload
7:51:43 PM: Starting post processing
7:51:44 PM: Post processing done
7:51:44 PM: Site is live
7:52:12 PM: Finished processing build request in 54.695220775s
No luck at all. Tried both "/" and domain again.
No error.
I am wondering if we need to modify your theme on head.html for the css and js to something like

or as a relativeURL?
My previous projects was using the same deployment and the other pipeline and theme could even deploy with just "/", which was a depreciated casper 2 theme.
For your info, I started with boilerplate. Cloned your theme and deleted your .git so as I tried not to use submodule. Everything was fine including modifying bootstraps etc on hugo serve.
I am not sure if I messed up something but I definitely didn't touch the css and js URL on head.html. I added partials for google adsense and probably that's the main modification on head.html inside your theme layout partials.
Do you have any suggestions? Should I try to start from scratch again?

I used npm install for the beginning of the project as usual. copied some of your example site contents for reference. Changed the front matters of markdown. Modified the config file.

Sorry for all the troubles. Highly appreciated

Oh that does seem interesting. I haven't tried this kind of build yet though. I think not using victor-hugo and just using a simple deployment process would be easiest.
Although if you want to use the boilerplate (but without customizations on the theme), perhaps you can try this:
(assuming site directory contains all hugo files):

Clone the theme inside site/themes. I think just a simple git clone and deleting the .git directory would do.
Replace build from package.json with "build": "npm run build:hugo".

I don't think you would really need webpack here at the moment since you won't be building the assets. If that's the case, I guess there might need more changes since boilerplate has a different process.
Hope that helps.

Guess I'll be closing this one. Feel free to re-open again.


LoadIconMetric and LoadIconWithScaleDown not working properly with *.ico files

It looks like LoadIconMetric and LoadIconWithScaleDown are not working properly with *.ico files from the disk.
This code is not working:
HICON h;
HRESULT r = LoadIconWithScaleDown(nullptr, L"c:\\test.ico", GetSystemMetrics(SM_CXICON), GetSystemMetrics(SM_CYICON), &h);

(but works if cx/cy is not SM_CXICON/SM_CYICON)
Also this is not working:
HICON h;
HRESULT r = LoadIconMetric(nullptr, L"c:\\test.ico", LIM_LARGE, &h);

But this works:
HICON h;
HRESULT r = LoadIconMetric(nullptr, L"c:\\test.ico", LIM_SMALL, &h);

I think it is easier just to remove mention of *.ico from the docs.
Was also reported a while ago here:
http://rsdn.org/forum/winapi/3976498.all

@oldnewthing can you please elaborate here?

I am not the subject matter expert for this topic.

@jwmsft any news on this topic?

@DJm00n, thanks for the reminder, and for this update.


Unable to remove image with ANIM flag

The problem is in the description. The command I use to get the image is
/yamipa give MikChan test.gif 1 4 2 REMO,ANIM

If I place it, it is impossible to remove it unless you use the command /yamipa remove.

Hello @wtlgo,
That's the intended behavior. You're overwriting the default "give" command flags, so effectively the only flag your image item has is "ANIM" (animatable) because it's the last one you pass.
You don't need to pass any flags to the command, just use it like this:
/yamipa give MikChan test.gif 1 4 2

Please, read the documentation regarding flags.


fix: fix label type

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.222%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
212

Relevant Lines:
225

💛  - Coveralls


add:joel

added new profile

@usrj03l Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


Apply sandbox image config

Based on https://github.com/kubernetes-incubator/cri-containerd/pull/41 and https://github.com/kubernetes-incubator/cri-containerd/pull/46.
This PR let sandbox container use pause image and applies image config.
 Will rebase the PR and previous PRs soon.

This PR passes sandbox and image CRI validation test:
Running Suite: E2ECRI Suite
===========================
Random Seed:<PHONE_NUMBER> - Will randomize all specs
Will run 3 of 36 specs

SSSSSSSS
------------------------------
[k8s.io] PodSandbox runtime should support basic operations on PodSandbox
  runtime should support removing PodSandbox [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:77
[BeforeEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:39
[It] runtime should support removing PodSandbox [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:77
STEP: run PodSandbox
STEP: stop PodSandbox
STEP: Stop PodSandbox for podID: 866db5b0e01ad81f9ba6452c3dfddb704999a7e5ef8e6112ae15e95b017fea4a
May 24 21:03:23.405: INFO: Stopped PodSandbox "866db5b0e01ad81f9ba6452c3dfddb704999a7e5ef8e6112ae15e95b017fea4a"

STEP: test remove PodSandbox
STEP: Remove PodSandbox for podID: 866db5b0e01ad81f9ba6452c3dfddb704999a7e5ef8e6112ae15e95b017fea4a
May 24 21:03:23.406: INFO: Removed PodSandbox "866db5b0e01ad81f9ba6452c3dfddb704999a7e5ef8e6112ae15e95b017fea4a"

STEP: List PodSandbox for podID: 866db5b0e01ad81f9ba6452c3dfddb704999a7e5ef8e6112ae15e95b017fea4a
STEP: List PodSandbox.
May 24 21:03:23.407: INFO: List PodSandbox succeed
[AfterEach] runtime should support basic operations on PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:49
STEP: stop PodSandbox
E0524 21:03:23.407719   29060 remote_runtime.go:109] StopPodSandbox "866db5b0e01ad81f9ba6452c3dfddb704999a7e5ef8e6112ae15e95b017fea4a" from runtime service failed: rpc error: code = 2 desc = an error occurred when try to find sandbox "866db5b0e01ad81f9ba6452c3dfddb704999a7e5ef8e6112ae15e95b017fea4a": does not exist
STEP: delete PodSandbox
[AfterEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSSSSSSSSSSSSS
------------------------------
[k8s.io] PodSandbox runtime should support basic operations on PodSandbox
  runtime should support stopping PodSandbox [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:66
[BeforeEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:39
[It] runtime should support stopping PodSandbox [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:66
STEP: run PodSandbox
STEP: test stop PodSandbox
STEP: Stop PodSandbox for podID: 0cb6f01e0c9e647e3d9759a211b6072578a8a7adc9f389365af06751929cc57f
May 24 21:03:23.797: INFO: Stopped PodSandbox "0cb6f01e0c9e647e3d9759a211b6072578a8a7adc9f389365af06751929cc57f"

STEP: Get PodSandbox status for podID: 0cb6f01e0c9e647e3d9759a211b6072578a8a7adc9f389365af06751929cc57f
[AfterEach] runtime should support basic operations on PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:49
STEP: stop PodSandbox
STEP: delete PodSandbox
[AfterEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSSSSSS
------------------------------
[k8s.io] PodSandbox runtime should support basic operations on PodSandbox
  runtime should support running PodSandbox [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:58
[BeforeEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:39
[It] runtime should support running PodSandbox [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:58
STEP: test run a default PodSandbox
STEP: Get PodSandbox status for podID: 33881cd78a6f5116a4509a72591de046790978dd947c8579734efee1bc50f068
STEP: test list PodSandbox
STEP: List PodSandbox for podID: 33881cd78a6f5116a4509a72591de046790978dd947c8579734efee1bc50f068
STEP: List PodSandbox.
May 24 21:03:24.052: INFO: List PodSandbox succeed
[AfterEach] runtime should support basic operations on PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/pod.go:49
STEP: stop PodSandbox
STEP: delete PodSandbox
[AfterEach] [k8s.io] PodSandbox
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•
Ran 3 of 36 Specs in 1.954 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 33 Skipped PASS

Running Suite: E2ECRI Suite
===========================
Random Seed:<PHONE_NUMBER> - Will randomize all specs
Will run 6 of 36 specs

SSSSSSS
------------------------------
[k8s.io] Image Manager
  listImage should get exactly 3 image in the result list [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:103
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] listImage should get exactly 3 image in the result list [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:103
STEP: Pull image : busybox:1-uclibc
STEP: Pull image : busybox:1-musl
STEP: Pull image : busybox:1-glibc
STEP: Remove image : busybox:1-uclibc
STEP: Remove image : busybox:1-musl
STEP: Remove image : busybox:1-glibc
[AfterEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSS
------------------------------
[k8s.io] Image Manager
  image status get image fields should not be empty [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:71
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] image status get image fields should not be empty [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:71
STEP: Pull image : busybox:1.26.2
STEP: Get image status
STEP: Remove image : busybox:1.26.2
[AfterEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSS
------------------------------
[k8s.io] Image Manager
  listImage should get exactly 3 repoTags in the result image [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:137
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] listImage should get exactly 3 repoTags in the result image [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:137
STEP: Pull image : busybox:1.26.2-uclibc
STEP: Pull image : busybox:1-uclibc
STEP: Pull image : busybox:1
STEP: Remove image : busybox:1.26.2-uclibc
STEP: Remove image : busybox:1-uclibc
STEP: Remove image : busybox:1
[AfterEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSSSSSS
------------------------------
[k8s.io] Image Manager
  public image without tag should be pulled and removed [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:56
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] public image without tag should be pulled and removed [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:56
STEP: Pull image : busybox:latest
STEP: Check image list to make sure pulling image success : busybox:latest
STEP: Get image status
STEP: Remove image : busybox:latest
STEP: Remove image : busybox:latest
STEP: Check image list empty
STEP: Get image status
[AfterEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSS
------------------------------
[k8s.io] Image Manager
  public image with tag should be pulled and removed [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:52
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] public image with tag should be pulled and removed [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:52
STEP: Pull image : busybox:1.26.2
STEP: Check image list to make sure pulling image success : busybox:1.26.2
STEP: Get image status
STEP: Remove image : busybox:1.26.2
STEP: Remove image : busybox:1.26.2
STEP: Check image list empty
STEP: Get image status
[AfterEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•
------------------------------
[k8s.io] Image Manager
  public image with digest should be pulled and removed [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:60
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] public image with digest should be pulled and removed [Conformance]
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:60
STEP: Pull image : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Check image list to make sure pulling image success : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Get image status
STEP: Remove image : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Remove image : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Check image list empty
STEP: Get image status
[AfterEach] [k8s.io] Image Manager
  /home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•
Ran 6 of 36 Specs in 9.367 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 30 Skipped PASS

@mikebrow @yujuhong PR rebased.

@yujuhong Updated localResolve to return image metadata instead so as to simplify the code more and in the meantime address the comment.

Close and reopen to trigger the test.

LGTM

Apply LGTM based on https://github.com/kubernetes-incubator/cri-containerd/pull/48#issuecomment-305048082


replace lesshint with stylelint

New CSS linter which is much more powerful than the previous one. Configuration is default but I had to remove a few rules that were throwing too many or weird errors.
More importantly, the linter will exit non-zero on errors so now our build will fail if the CSS linter fails which should eliminate linter errors being introduced without notice.
I fixed all issues that came up, mostly duplicate selectors.

Codecov Report

Merging #7305 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7305      +/-   ##
==========================================
- Coverage   41.23%   41.23%   -0.01%
==========================================
  Files         464      464
  Lines       62832    62841       +9
==========================================
+ Hits        25909    25911       +2
- Misses      33531    33540       +9
+ Partials     3392     3390       -2

Impacted Files
Coverage Δ

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

routers/repo/http.go
35.32% <0%> (-1.59%)
:arrow_down:

routers/repo/view.go
42.23% <0%> (-1.02%)
:arrow_down:

models/update.go
46.66% <0%> (-0.28%)
:arrow_down:

models/git_blame.go

modules/git/blame.go
78.26% <0%> (ø)

models/repo.go
48.71% <0%> (+0.08%)
:arrow_up:

modules/git/command.go
94.04% <0%> (+0.22%)
:arrow_up:

models/repo_list.go
73.09% <0%> (+1.01%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161e12e...5ecd8a0. Read the comment docs.

conflicted

rebased


foxitreader: mark insecure

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Actually I'm not sure whether these affect the Linux version. Its versioning seems to be completely different from the Windows one.

This package could also be removed, since it's sio outdated and no more updated.

Agreed, let's drop it.


Level per XP

Hello !
I just wanted to know how do I set a maximum xp for each level?
for example 100 XP for 1 Level

Changing that via the library isn't supported because that's not something MEE6 does. It is possible though. You'd have to go into levels_xp_needed.py and change all values in the LEVELS_AND_XP dictionary and set a maximum xp for each level to what you'd like that way. IIRC, there's nothing hard coded when it comes to LEVELS_AND_XP, so changing the values in that dictionary shouldn't cause any issues.


question

how do i get this  updated opencv to work with  python  3.8?

@JamesCaywood could you please elaborate the issue you are facing like what is the problem you are facing and which IDE are you using.
openCV works best with "jupyiter notebook" and even "google colab"

Please use forum.opencv.org for questions.


Create Weekly Project Status.md

Signed-off-by: wlchurch<EMAIL_ADDRESS>

Easier for github instead of the docx file
https://github.com/openmainframeproject-internship/resources/blob/master/forms/Weekly Project Status.docx