Queue worker remembers singleton between jobs

Laravel Version: 7.14.1
PHP Version: 7.4.6
Database Driver & Version: MySql 5.7.3

Description:
Queue workers remember singletons between jobs.
Steps To Reproduce:
Some class with state:
class Foo
{
    private $now;

    public function get()
    {
        if (! $this->now) {
            $this->now = now()->toDateTimeString();
        }

        return $this->now;
    }
}

AppServiceProvider:
public function register()
{
    $this->app->singleton(Foo::class);
}

Queued job:
class SomeJob implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

    public function handle()
    {
        $foo = app(Foo::class);

        info($foo->get());
    }
}

Dispatch the job multiple times:
Route::get('/', function () {
    SomeJob::dispatch();
});

Running a queue worker using artisan queue:work will always log the same value:

I've experienced this bug both using the database and redis queue drivers.

That's not a bug. That's how daemon queue workers work. If you want to have a non-daemon listener that reboots the framework on each job use queue:listen.


Fix creation of instance ID

Fixes #86

Also tried to build a job in the jenkins UI and got failures, but I don't think they're related.

The customer who reported the issue has provided some additional information here: https://github.com/jenkinsci/google-compute-engine-plugin/issues/85

Code looks good so far and I pass all integration tests except Windows. Currently looking into why that is.

are these seperate from the ci.jenkins tests? cause they are green now


No configurable recipes

Before 1.7.* the mod included recipe sets that could be turned on and off through the config (GregTech, IndustrialCraft, Thermal Expansion, Universal Electricity (now Resonant Engine), and vanilla).

Assuming you already saw https://github.com/QMXTech/MachineMusePowersuits/issues/17 and https://github.com/QMXTech/MachineMusePowersuits/issues/19?
Yeah, GregTech, IndustrialCraft2, ThermalExpansion and vanilla recipes will all be automatically placed and handled in <IP_ADDRESS>-QMX depending on config settings and mod presence. Also I have planned support for EnderIO and Mekanism. Universal Electricity/Resonant Engine/Resonant Induction/Electrodynamics recipes will be reintroduced when @Calclavia gets it together and releases a (somewhat) stable build.

That's great! I look forward to the update. I actually closed the issue as I was going to put it up on Bugzilla instead but if it's good here then great.

Yeah, I would've said under normal circumstances to put this in Bugzilla, but... Actually forgot one label that says it all.... ^_^

Released


Find a way to wire dynverAssertVersion into deliver/publish.

Remember to consider all variants, eg. deliverLocal, publishLocal, publishM2, even publishSigned if possible.

See https://github.com/sbt/sbt-unique-version/blob/62636aecfd53d665485c2f537064789b3ff0002d/src/main/scala/sbtuniqueversion/Plugin.scala#L33-L51


[Mentions v2] Return reportName and reportID for mentionedReportIDs when requesting report data

When we fetch new data for a report we might be getting reportActions that contain room mentions that we don't have the matching name for in the FE, so we need to start sending the reportNames and reportIDs when the user request the reportActions of a report. This behavior is described here.

All PRs are in production.


Sprite image filesize larger than sum of individual files

When I run the task my sprite sheet is 1.1mb but the directory where I keep my sprites is 684K. Is there some configuration I am missing? Thanks for your support.
sprite: {
      all: {
        engines: 'canvassmith',
        src: 'src/img/sprites/*.{png,jpg}',
        dest: 'src/img/spritesheet.png',
        destCss: 'src/app/styles/sprites.scss'
      }
}

Based on your src, it looks like there are some JPGs into your spritesheet. JPG is a lossy image format and usually compresses better. Since the output is PNG which is a lossless format, the size is increasing.
If you take out the JPGs (e.g. put them in a separate spritesheet) and the size is still unsatisfactory, consider adding another grunt task to perform image optimization:
https://www.npmjs.com/package/grunt-contrib-imagemin
https://www.npmjs.com/package/grunt-imageoptim

great thanks for the info! I'll do that


Add verbose override fields

@Raynos

lgtm. #shipit.

Added you as collaborator
Added you as npm owner
Published v6.0.0


msgid duplicates behaviour

If I got duplicate msgid's on my po the po.parse does not throw any exceptions...
For example:
# it.po
msgid "apple"
msgstr "mela"

msgid "apple"
msgstr "melania"

Compiles to:
it.compiled.po
msgid ""
msgstr "Content-Type: text/plain;\n"

msgid "apple"
msgstr "melania"

Keeping only the last msgid...

Seems like a correct behavior to me

Can you explain why? Thanks in advance.


How to use IntPtr to reference ClaimsIdentity

Hello,
Thanks for the great examples here.  This has been enormously helpful.  I do have 1 concern in my code that is not clear how this should be handled from any of the examples.  In my IAuthenticationExtension2 I set the identity to a ClaimsPrincipal, complete with roles.  However, in the IAuthorizationExtension we only get passed in the username.
I've done something which I'm quite certain is creating a Memory Leak - I'm using GCHandle to get a reference to the ClaimsIdentity as an IntPtr and returning that for the out.  This allows me to access it in the Authorization, so I can check for Roles the user is in to verify Permissions and Check Access.
However, as I'm creating a new reference every time and never cleaning those up and GC will not touch those.  Is there something I'm missing or should do differently?  Guess I'm a bit stumped about how to properly share those details between the 2 different interfaces.

@rposener  wow, it looks like i am going to follow your code, i am looking to use my Identity Server V3 STS and it looks like you are doing much the same thing .....   if you have any tips or details please share them!

@figuerres - we've been running that code internally for a little while and haven't run into issues yet.  I can't say it's 100% cleanest code - the somewhat arbitrary cleanupTimer (as opposed to a session End event or something) and the static list of Identities are probably not ideal.  But it is working well from our use so far.  Can't say we've put into a larger environment yet - if you find other spots for improvement would love to see what you come up with so we can all benefit until MS offers a better solution.
Cheers.

@rposener thanks for the info.
i am going  over where i took the MS sample code and started trying to work out how to do this,
then  found your code.
so i am patching in some of your code to my code to see if i get it to work.
it looks like sometime today or tomorrow i can start to test my version.
i have taken some calls you had in your pe utility and moved them to the OIDC class so that my app helper only has the get roles and validate  bits.
when i get the first tests working then i can start to see how it all works out.
when i started to look at this i was seeing all the id server sample code using the startup.cs to add support but with SSRS we can't do that, you appear to have dealt with that  which is great.


DS-4292  Fix Browse pagination with starts-with

Currently, if you're browsing by Author, select a starts-with link and then click the next page, it brings you to the 2nd page of all results rather than the 2nd page of those _starts_with results.
This fix adds the starts-with parameter to getControlParameters() so that pagination forward and backwards work with starts-with

@KingKrimmson this has a conflict that makes me think this issue was already fixed (along with fixing some other starts by issues) in #1730 - if that is not the case, please let me know and we can look at rebasing/resolving?

I couldn't replicate so I suggest we close @kshepherd

I couldn't replicate so I suggest we close @kshepherd

We have found this bug on our live. You can see it here:
https://edoc.hu-berlin.de/browse?rpp=20&sort_by=-1&type=author&etal=-1&starts_with=P&order=ASC
I didnt test this fix, but i can confirm its still existing. The fix #1730 is applied so i assume it must be still there.

@ssolim I just tested on the link, and other starts-with browsing on your site and it looks ok to me.. clicking next page does keep me within that browse scope, not the full browse results. Am I doing something wrong with testing?

Yeah you are right. I mixed this up. My fault!!!
https://jira.lyrasis.org/browse/DS-3996
This is what is i meant and what you can see at the link. I am sorry for the confusion. Somehow i thought this is related.
But this seems also fixed to me. Sorry for the confusion.


Pre-EOC Xp Drops & Orbs

https://streamable.com/8jqur
I think this will be a perfect addition to go along with the HD menu interface and cursors.
Would love to see this implemented, Pre-EOC was the most fun time for me :)

If I'm not mistaken they will not work on XP drops since RuneScape already implements those.
RuneLite XP Drops: The vanilla client already has XP drops that can be repositioned/recolored

That's for a custom XP drop system like other clients have. RSHD/RS3 XP drops would be an enhancement of the current vanilla one.

I was a huge fan of the Runeloader XP Drops.  https://github.com/runelite/runelite/issues/2323


Multiline strings + print seem to trip the obfuscation

Source code:
func _ready():
	print("""===== Game name =====
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⡟⣛⡉⢹⢛⣛⢻⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⡟⣫⡆⠀⣿⣷⣬⣼⡿⢸⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣷⡘⢿⣾⡿⠿⠿⠛⢃⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣌⠫⠶⠿⠟⣋⣼⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⡏⠉⠏⠩⣭⣭⠉⠘⠉⠻⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⡇⠠⠤⠴⢯⣭⢤⠤⢄⢰⣿⣿⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⠋⠀⠀⠶⠬⢼⣸⣇⢠⠬⠼⠌⠀⠀⢹⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⡆⠀⠀⠀⠀⠙⠙⠛⠉⠀⠀⠀⠀⠠⣾⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⠏⠀⢀⣮⣅⣛⠻⠇⠿⢛⣃⣩⣴⠃⠀⠈⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣧⡀⠀⠘⢿⣿⠿⠟⠻⠟⣛⠻⢿⠿⠀⠀⣼⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⢀⠀⠀⠲⠈⣭⣭⢩⣭⡴⠐⠀⠀⡌⣿⣿⣿⣿⣿⣿⣿
⣿⣿⣿⣿⠇⣾⣷⣦⣀⠀⠀⠈⠀⠀⠀⣠⣴⣿⣿⡸⣿⣿⣿⣿⣿⣿
⣿⣿⣿⡏⣼⣿⣿⣿⣿⣿⣶⣤⣀⣴⣿⣿⣿⣿⣿⣧⢹⣿⣿⣿⣿⣿
⣿⣿⣿⣶⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣶⣿⣿⣿⣿⣿
⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿
Some more text, not sure if that's what trips it""")

Output:

Sorry for the title error, a 2AM error lol. Awesome project by the way! :)

Thank you!
I'm currently rewriting most of the obfuscator, which should improve stability a lot and also properly handles the above code.
If things go well, I might be able to release the update within a couple days.

sounds good :) My game is a multiplayer competitive shooter, and even with authoritative server model people will find exploits in the codebase due to how open Godot is. Your project is God's work, thank you

sounds good :) My game is a multiplayer competitive shooter, and even with authoritative server model people will find exploits in the codebase due to how open Godot is. Your project is God's work, thank you

Yea, a multiplayer game I've been working on is the reason for the existence of this addon haha.

Off topic, but @cherriesandmochi , your GH account is so weird... signed up in 2013, but had 0 contributions over the course of 10 years straight 💀

Off topic, but @cherriesandmochi , your GH account is so weird... signed up in 2013, but had 0 contributions over the course of 10 years straight 💀

Lmao, I don't remember why I signed up 11 years ago, I started using git(hub) about 3-4 years ago, around the time I got into Godot. And well, all the projects I made since then are private, expect this one.
Iirc the reason for signing up was that you had to be signed in to download repos as zip file?

Fixed by 7faaac7.
Thanks for the bug report! It still messes up the source map, but at least the obfuscation works properly now. Might open a new issue for that, but even though it should be pretty trivial to fix, it's low priority for me right now.

Great, thanks!


Fix timeout for offer invoice requests

Previously we triggered a timeout check with
coroutineScope {
    launch {
	delay(cmd.fetchInvoiceTimeout)
	input.send(CheckInvoiceRequestTimeout(pathId, cmd))
    }
}

However this blocks the current function which means the message is sent only after it has timed out. Instead we introduce delayed commands which are only processed when their time comes without blocking other peer commands. In addition to CheckInvoiceRequestTimeout, we also make CheckPaymentsTimeout a delayed command.

This is a dangerous change that has several potential drawbacks and subtle bugs (mostly around disconnections and management of the input channel and flushing of messages). I'm very wary of the way you're trying to achieve that. If we go that route, we'll need a thorough review from @dpad85 and @pm47 as well, and e2e tests in a version of Phoenix that uses this code.

However this blocks the current function which means the message is sent only after it has timed out.

Can you detail that more? When a "normal" dispatcher is used, I don't see how this would end up blocking anything. Are you hitting this issue in tests, or in a real app?
If you're hitting this issue in unit tests, it's potentially a problem with the dispatcher (tests use a single-threaded dispatcher that doesn't play well with launching coroutines).
I think we should test this with integration in a real app to see if the timeout works or not (which will need @dpad85 to create a phoenix build using the current master branch of lightning-kmp), and a "hacky" payment recipient that ignores the invoice request (probably a tweaked eclair testnet node).

Replaced by https://github.com/ACINQ/lightning-kmp/pull/645


weave hide complains when weave isn't running

$ weave hide <IP_ADDRESS>/24
weave container is not present. Have you launched it?
$ echo $?
1

This got broken by #563.

We should add a smoke test for weave expose/hide when weave isn't running.


[Bug Report] Input with icon - icon blocking focusing the field

Element UI version
2.4.6
OS/Browsers version
Chrome 68.0.3440.106
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/mmx38qxw/4839/
Steps to reproduce
Using input with an icon (search icon)
Clicking on the search icon - does not focus the input
What is Expected?
The input field should be focused
What is actually happening?
Nothing

This is intentional, events of prefix / suffix icon should be handled on user side.
https://jsfiddle.net/mmx38qxw/4841/


Nexmo::Error

If we don't have status = 0, can we put the status variable in the Error class so we don't have to parse it from the error message when an exception is thrown.

@kazmin I can understand it would be awkward to get the status out of the error message, the error messages aren't meant to be parsed. I think it might be better to remove the status check from #send_message, then that would be more flexible as you could check the status code directly.
Unfortunately that's not backwards compatible behaviour so might have to wait. If that approach fits your immediate needs better you could always monkey patch it in, something like this:
class Nexmo::Client
  def send_message(params)
    post('/sms/json', params)
  end
end

any estimate ?

Hi, please check this
https://github.com/timcraft/nexmo/pull/40
I have similar problem, when message fail to send, i can do anything, it just raise an error.
Well, i try to fix that when message fail to send, it's not rase an error.

@ekyfauzi Planned change for the next major version is to simplify #send_message, as per the above example. Recommended workaround in the meantime is to implement that yourself--options include monkey-patching, subclassing, or adding a new method with a different name.

Implemented in 85f8529, you can now check for the status directly in the response object. No more awkward parsing of exception messages.


Fix for IOS new archtecture compatibility

This feels like a naive approach to a potential fix another option might be to use standard js for the NativeRNShake file
56

@Doko-Demo-Doa Can you please take a look

@TaylorOno Hello, thank your for your effort. I have the problem when installing your fork (via yarn add), that the lib folder is not generated

Sorry for the late response. Merged and released.


docs: fix PHPDoc types in Filter class.

Description
See #6310
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

I don't change the return type in run() function in Filters.php and two functions of FilterInterface.php because I have a question as below.
Is there any possibility that these methods will return a type other than object|null|void ?

I think the filter return values need to remain mixed because the docs specify they can return any non-empty value to short circuit.
https://codeigniter4.github.io/CodeIgniter4/incoming/filters.html#creating-a-filter

Ok I got it. Thanks you @MGatner !
But I have some idea as below.
If they can return any non-empty value, can we put all the return type object|resource|array|string|int|float|bool|null on their param/return type?

I don't think a filter returns resource.

Personally, I would like to reduce the number of allowed types like the following.
I think for stopping filters only non-empty string is sufficient. But it is a breaking change.
--- a/system/Filters/FilterInterface.php
+++ b/system/Filters/FilterInterface.php
@@ -31,7 +31,7 @@ interface FilterInterface
      *
      * @param array|null $arguments
      *
-     * @return mixed
+     * @return RequestInterface|ResponseInterface|string|void
      */
     public function before(RequestInterface $request, $arguments = null);

@@ -43,7 +43,7 @@ interface FilterInterface
      *
      * @param array|null $arguments
      *
-     * @return mixed
+     * @return ResponseInterface|void
      */
     public function after(RequestInterface $request, ResponseInterface $response, $arguments = null);
 }

I think for stopping filters only non-empty string is sufficient. But it is a breaking change.

I changed the PHPDoc return type first, then I will open another PR to handle this.

@kenjis I want to check what will need to be change in Filter class if we want to stopping filters only non-empty string.

If we change the code, It is a breaking change.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#breaking-changes
So I think it is better to make non-empty values except string deprecated (stating that in the user guide).
Then in the next or next next minor versions we permit only non-empty string.

Then in the next or next next minor versions we permit only non-empty string.

I am willing to help with this BC feature in the future!

So I think it is better to make non-empty values except string deprecated (stating that in the user guide).

So do I need to modify the user guide in this PR? Or need to another PR to handle this pre-work.
And I wonder if there is anything else that needs to be modified in this PR.

I agree with the future change to only allow non-empty strings, but I don't know if the team would agree to that.
@codeigniter4/core-team Any comment?

@kenjis @michalsn @MGatner I have been change the return type mixed in FilterInterface.

I agree with the future change to only allow non-empty strings.

I will open the other PR to handle this.

If we want to introduce these return-type changes, can we do it once, without breaking it down into further releases?

I don't think this is a good choice because there are still a lot of mixed in this library core.
If we want to do it once, then that pull request will be too complex to handle, manage and review.

@michalsn Changing the return type means changing the if condition:
https://github.com/codeigniter4/CodeIgniter4/blob/729634c3561e1d8d0742f0e691c810ced8ce6a67/system/Filters/Filters.php#L187-L192
This is a breaking change.

@kenjis If we want to change the return type, we can't avoid a breaking change.
I would just target this to 4.4 and that's it.
Adding a note to the user guide first and then changing it in the future gives us nothing. Developers who already have built their apps most likely won't see the note. They will notice it when we introduce a change into the code - hopefully reading the release notes.
The real question is if other developers take advantage of the current implementation. Because for me, that's the only real problem.

The real question is if other developers take advantage of the current implementation. Because for me, that's the only real problem.

I don't know. But it is documented as non-empty value, some devs may be using true or something. I don't think many devs actually use this feature.
It is possible that this change could actually break existing applications. So I don't strongly advocate making the change.
However, I don't think there is a need to allow any non-empty value. We don't even use the return value itself, so if we want to stop later filters, I think one type value for it is sufficient.

So... Is there a consensus here?
@michalsn @kenjis
Or can we have a notice for user guide first and change return type to non-empty string in 4.4?
I think have a notice in user guide may not let the developers who have been implemented to make changes, but it can prevent future devs who need this method from defining other types.

The current changes seem fine.
I don't see a good reason to change the return signature for FilterInterface and introduce a BC break for that reason.
I'm okay with adding a note to the user guide to return only non-empty strings.

This PR is okay.


⚠ Bofrost.at has degraded performance

In 040b6c8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1659 ms

Resolved: Bofrost.at performance has improved in 8a26914.


How to get the required data points from CST microwave studio?

I have simulated a breast phantom with two antennas (one transmitter and one receiver) in CST microwave studio and now I want to plot the breast tumor images in Matlab using this toolbox. But I can't figure out how can I extract all the data like antenna location, channel name, scan1, and scan2. Can someone please help me by providing any suggestions? I will be really grateful for any of your help.

You will need the antenna locations in a reference frame, if there are X m between the antennas, you can use:
locations = [0, 0, 0; 0, X, 0];
for example.
The channel names depend on the transmit and receiving antennas used for each channel:
names = [1, 1; 1, 2; 2, 1; 2, 2];
implies that you are using the S11, S12, S21 and S22 signals.
Scan1 should be the signals with the object you are imaging, you will typically need a reference scan without the object for calibration in scan2.


unicode: SimpleFold panics if r is negative

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
go version devel +2d33f62 Sun Aug 14 10:06:51 2016 +0900 darwin/amd64

What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hiro/.go"
GORACE=""
GOROOT="/Users/hiro/work/go"
GOTOOLDIR="/Users/hiro/work/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/wq/dwn8hs0x7njbzty9f68y61700000gn/T/go-build329740802=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
https://play.golang.org/p/Tj8rqp7o13 (playground doesn't panic)

What did you expect to see?
no panics.

What did you see instead?
panics.

This error doesn't exist before 1.7 (e607abbfd6e0550c13f4fa7b666d033eb9b14759)

I think for your repro you meant to include something like this https://play.golang.org/p/EqumNpoEJT or inlined
package main

import (
	"fmt"
	"unicode"
)

func main() {
	r := unicode.SimpleFold(-1)
	fmt.Printf("r: %v\n", r)
}

instead of unicode.SimpleFold('a')
I can confirm that it panics on tip 31ad583. This is a regression from Go1.6. /cc @bradfitz, @broady, @quentinmit on how this is going to affect the Go1.7 release.

What's the use case for passing negative values to this function?
Is there real-world code that does this?

What's the use case for passing negative values to this function?

I don't know the answer for this, perhaps @hirochachacha could chime in on their usage that might have led them to catching this bug.
Maybe we could also ask @campoy for help querying the Github corpus in BigQuery as was done here https://github.com/golang/go/issues/14595#issuecomment-235651095?
However:
Searching in the stdlib for users of SimpleFold, there are 29 uses of it across 11 unique files
$ git grep -E 'unicode\.SimpleFold\(' * | cut -d":" -f1 | sort | uniq | wc -l
      11

$ git grep -nE 'unicode\.SimpleFold\(' *
src/bytes/bytes.go:712:		r := unicode.SimpleFold(sr)
src/bytes/bytes.go:714:			r = unicode.SimpleFold(r)
src/cmd/doc/pkg.go:640:		r1 := unicode.SimpleFold(r)
src/cmd/go/main.go:763:			r = unicode.SimpleFold(r0)
src/regexp/onepass.go:387:				for r1 := unicode.SimpleFold(r0); r1 != r0; r1 = unicode.SimpleFold(r1) {
src/regexp/onepass.go:411:				for r1 := unicode.SimpleFold(r0); r1 != r0; r1 = unicode.SimpleFold(r1) {
src/regexp/syntax/compile.go:271:	if len(r) != 1 || unicode.SimpleFold(r[0]) == r[0] {
src/regexp/syntax/parse.go:119:		unicode.SimpleFold(re.Rune[0]) == re.Rune[2] &&
src/regexp/syntax/parse.go:120:		unicode.SimpleFold(re.Rune[2]) == re.Rune[0] ||
src/regexp/syntax/parse.go:123:			unicode.SimpleFold(re.Rune[0]) == re.Rune[1] &&
src/regexp/syntax/parse.go:124:			unicode.SimpleFold(re.Rune[1]) == re.Rune[0] {
src/regexp/syntax/parse.go:199:	for r = unicode.SimpleFold(r); r != r0; r = unicode.SimpleFold(r) {
src/regexp/syntax/parse.go:1724:		f := unicode.SimpleFold(c)
src/regexp/syntax/parse.go:1727:			f = unicode.SimpleFold(f)
src/regexp/syntax/parse_test.go:335:					if unicode.SimpleFold(r) != r {
src/regexp/syntax/parse_test.go:409:	c := unicode.SimpleFold(r)
src/regexp/syntax/parse_test.go:414:		c = unicode.SimpleFold(c)
src/regexp/syntax/parse_test.go:422:		if unicode.SimpleFold(i) == i {
src/regexp/syntax/prog.go:213:			for r1 := unicode.SimpleFold(r0); r1 != r0; r1 = unicode.SimpleFold(r1) {
src/strings/strings.go:712:		r := unicode.SimpleFold(sr)
src/strings/strings.go:714:			r = unicode.SimpleFold(r)
src/unicode/example_test.go:117:	fmt.Printf("%#U\n", unicode.SimpleFold('A'))      // 'a'
src/unicode/example_test.go:118:	fmt.Printf("%#U\n", unicode.SimpleFold('a'))      // 'A'
src/unicode/example_test.go:119:	fmt.Printf("%#U\n", unicode.SimpleFold('K'))      // 'k'
src/unicode/example_test.go:120:	fmt.Printf("%#U\n", unicode.SimpleFold('k'))      // '\u212A' (Kelvin symbol, K)
src/unicode/example_test.go:121:	fmt.Printf("%#U\n", unicode.SimpleFold('\u212A')) // 'K'
src/unicode/example_test.go:122:	fmt.Printf("%#U\n", unicode.SimpleFold('1'))      // '1'
src/unicode/maketables.go:1320:			if g := unicode.SimpleFold(i); g != f {
src/unicode/maketables.go:1321:				fmt.Fprintf(os.Stderr, "unicode.SimpleFold(%#U) = %#U, want %#U\n", i, g, f)

SELECT repo_name, content
FROM (
  SELECT id, content
  FROM [campoy-github:go_files.contents]
  WHERE REGEXP_MATCH(content, r'unicode.SimpleFold\([^)]*-')
) as contents JOIN [campoy-github:go_files.files] as files
ON contents.id = files.id

Zero results. It's much more difficult to determine if a call to SimpleFold refers to a variable pointing to a negative value.

Thank you for the search and breakdown @broady.
I've commented on @hirochachacha's CL https://go-review.googlesource.com/#/c/27033. The bug was that a negative index was being passed in to the precomputed Folds table(thereby causing the index out of bounds panic) look up due to new condition
if int(r) < len(asciiFold) {
   return rune(asciiFold[r])
}

that should be us first checking if negative
if r >= 0 && int(r) < len(asciiFold) {
   return rune(asciiFold[r])
}

and this way only the precomputed values will benefit from this cache hit, other values(negative values included) will take the same code path as they were before that change/preGo1.7.
If we deem that the CL needs to go out ASAP since a new release is coming up, perhaps anyone of us can spin up/take over it and give the credit to @hirochachacha for the find/patch?

I think panic is ok. There shouldn't be any guarantee when SimpleFold is
passed an invalid rune. Actually, according to its docs, it cannot return
anything for negative input.

There is no equivalent code points, so the first clause doesn't apply.
The smallest rune >= 0 clause also doesn't apply because r itself < 0.

Therefore, the only logical result is to panic.

I think it's OK to either panic or to return the argument for 1.6 compatibility.  I don't think this needs to be changed for 1.7.

Actually, I don't have real usages, sorry. Perhaps as a sentinel value?
I've found this because I saw
https://github.com/golang/go/blob/31ad583ab24263f9dbcb5cbcce849eed64e74040/src/unicode/graphic.go#L37-#L38
So I assumed unicode package API accepts negative rune.

Aside: I suspect that that code can be made much more obvious in 1.8. I have an as yet unmailed compiler CL to do the unsigned comparison trick more generally, and the SSA backend should handle the bounds checks elimination.

@josharian Maybe you mean #16697?

@minux Even if panic is OK, I think it should be done by intention, not by accident.
For example:
if r < 0 {
  panic("negative rune is disallowed")
}

So, I can understand that panic is intentional.
And how do you think about other functions like unicode.IsGraphic?

@hirochachacha, yes, an explicit panic would be better if we decide to make these panic.
It's just not worth delaying Go 1.7.

It's just not worth delaying Go 1.7.

I have no objection.


Enhancement: Use small header layout in User module

This PR

[x] configures the User module to use the layout with the small header, leaving more actual room on the page

See http://modules.zendframework.com/user
Before

After

@localheinz thanks, merged!

Thank you, @Ocramius!


Feat/pool id in amm arb

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Adds pool_id to amm_arb strategy.
To be tested with https://github.com/hummingbot/gateway/pull/280
Tests performed by the developer:

Manual test with Gateway

Tips for QA testing:

Test with https://github.com/hummingbot/gateway/pull/280

@vic-en Should it be optional?

thanks @vic-en
@nikspz please test with Balancer and Uniswap on Arbitrum:
Expected behavior:

User can get price and execute swaps using poolId on Balancer
User can get price and execute swaps using poolId on Uniswap
User can get price and execute swaps using trading pair with no poolId on Uniswap

If these cases pass, this PR should be ready to merge

thanks @vic-en
@nikspz please test with Balancer and Uniswap on Arbitrum:
Expected behavior:
* User can get price and execute swaps using `poolId` on Balancer

* User can get price and execute swaps using `poolId` on Uniswap

* User can get price and execute swaps using trading pair with no `poolId` on Uniswap

If these cases pass, this PR should be ready to merge

@fengtality Uniswap on Gateway wouldn't acknowledge the poolId. Only Balancer will ack it. Core files for all other connectors will need to modified to make use of poolId when it's supplied. Otherwise, they'll always default to using their smart routers.

That being said, I can update Uniswap to acknowledge the poolId with it's present in my Balancer pr on Gateway this weekend.
It's not a big deal for me.
Other connectors will be left as it.

@fengtality Let me know if you want me to deprecate the useRouter on Uniswap. It'll almost a duplicate feature

@nikspz @fengtality
Update has been made on Gateway balancer pr on Uniswap to make it acknowledge poolId - https://github.com/hummingbot/gateway/pull/280/commits/00ec98534f7b250cc44a7af3b27178298497502d

thanks for adding poolId to Uniswap, @vic-en!
I'll review the useRouter status and get back to you soon

Test performed:

Cloned and installed PR7018 + gwPR280 ✅

Failed to get price using poolId on Balancer using 0x848a7ff84cf73d2534c3dac6ab381e177a1cff24 address ❌

Changed poolId to 0x848a7ff84cf73d2534c3dac6ab381e177a1cff240001000000000000000004bb

Able to get price using poolId on Balancer using 0x848a7ff84cf73d2534c3dac6ab381e177a1cff240001000000000000000004bb address ✅

Failed to execute swap using amm_arb strategy ❌ (0x848a7ff84cf73d2534c3dac6ab381e177a1cff240001000000000000000004bb pool)

https://arbiscan.io/address/0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843
Fail with error 'BAL#507'

Manually executed BUY with curl successfully ✅

https://arbiscan.io/tx/0x0af437418c987da4065ce7ec1295f7d5b4771d92b315b5e42afaf5abfc25d3f6

second tx to sell failed ❌
https://arbiscan.io/tx/0xe6f5d7789038b5481130157fc5df524fb71baaf1cc0b09c7015365c83f95825c

approved in Client, WETH and USDC, ✅
https://arbiscan.io/tx/0x2035115874025f3ce3800aa0fb5329f8ce63ab78f243244ec72322003cea92ed
https://arbiscan.io/tx/0xc269fc7b3d9a2b92eec29d0bf6ded90e93f5bb4764a354d89989a2acc91274be

tried sell request on curl again, failed ❌
https://arbiscan.io/tx/0x0a6d3f2a019b78512c20ae5cb0d1efeed0e1700b5e38f8f34ea0e407a95b747d

@nikspz Seems only sells failed. I'll get back soon.

@nikspz This is ready to test again. Update gateway with the latest branch.


Add more detailed log for bad codefix request

Trying to get more details on #32856 because I think it’s a bad client request

I see this has been merged, but has it gone out in a release?
I'm getting a similar error on sentry within the Monaco packages.
However, I have not been able to repro. The error also doesn't tell me much to understand what's going wrong.


Added setItem for PlayerInventory

Implements the function for setting a specific slot of a player's inventory.
Part of https://github.com/customrealms/core/issues/22

Tested it and it's pretty simple so no surprise that it works, thank you!


Setting Host header does not work when using HTTPS URIs with rustls-tls feature

Hi there,
I recently encountered an issue that seems to be related to the one discussed in this GitHub issue: https://github.com/seanmonstar/reqwest/issues/1536. While the solution presented in the thread works as expected for HTTP requests, I found that it doesn't work for HTTPS requests with rustls-tls feature enabled.
Here's an example code snippet that demonstrates the issue:
// in Cargo.toml
reqwest = {version = "0.11", default-features = false, features = ["rustls-tls"]}

// code
reqwest::Client::new()
    .get("https://httpbin.org/headers")
    .header(reqwest::header::HOST, "yolo")

The JSON response I get looks like this:
{
  "headers": {
    "Accept": "*/*",
    "Host": "httpbin.org",
    "X-Amzn-Trace-Id": "Root=1-641acc99-21abb63517c39e9758cf3997"
  }
}

As you can see, the Host header is not being set correctly, and the value of "yolo" is being overridden by the default value of "httpbin.org".

Is it that the header isn't sent? Or maybe httpbin  sees it from the SNI part of the TLS handshake.
You could inspect with the connection_verbose option.

Thank you for your quick response.
I captured the request, and you are correct - the host was not sent.

 It used HTTP/2, and that protocol does not use the host header.

That's new to me😯, I will build the client with the only_http1 option. Thank you!


Fix range of Y axis in time-series charts

Users should be able to fix the range of the Y axis in time-series charts, e.g., to exclude outliers.
See also #284

I investigated how to implement zooming into Y axis using recharts with least effort:
The most obvious implementation is to let users zoom into the time-series chart using an arbitrary zoom rectangle as we know it from plotly and many other libraries. The solution provided at recharts-square-zoom-implementation doesn't work, as it does not take into account the actual scaling from chart component coordinates into the X/Y domains used for displaying the data. Unfortunately, recharts does not have any API to know the current transformation (= offset and resolution vectors in X/Y units).
Here are some recharts issues regarding the lacking feature:

https://github.com/recharts/recharts/issues/710
https://github.com/recharts/recharts/issues/365#issuecomment-1160972071
https://github.com/recharts/recharts/pull/4036

See #217


How much money did you spend on this?

Total cost of all paid appz = ?

I actually don't know but it's probably quite a lot. For me though most purchases I have made paid the money back in time by either saving my time or making my workflow a lot more nicer and thus made me happier as a result.
Plus the cool thing with most software is that I can keep it afterwards. There is also a lot of open source software that I use in the list.


[snapshot] Add missing newer iPhone & iPad models to Generated Snapshot Reports

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ ] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context
I noticed running snapshot with only the iPhone 14 selected that the generated screenshots file was blank. I worked out the list of supported devices for the report is hardcoded, so have updated the list of devices.
Description
Added missing recent iPhone simulator names to the definitions used to output generated HTML files
Updated to match the Xcode Version 14.3 simulator names.

Updated the PR to add the missing iPad names as well as the originally added iPhone names

Thanks for the PR, @kylehowells - I believe this is addressed now as part of https://github.com/fastlane/fastlane/pull/21554 so I'm closing this PR. Apologies for not getting to it sooner.

@getaaron thanks for the reply. I checked the new PR and it looks like the newer PR still misses some of the older iPhones and iPads this PR was adding support for, as it was mostly just adding the new devices for this year.
I'll double check those older phones are still in Xcode 15 and update the PR/create a new one.
I originally created this PR not because I wanted to test new phones that weren't supported, but because I was trying to setup screenshot testing on older phones we mostly ignore and won't notice UI issues with, and found they weren't added on here at all.


Fix#10542: Add sample data mask functionality

Describe your changes:
Fixes #10542
I have added a Rule Operator called ViewPIISampleData associated with the Table resource that allows us to create rules to mask in the Sample Data the columns tagged with PII.Sensitive. In case of columns with children, if any of the children is tagged with PII.Sensitive the parent column display in the Sample Data will be masked.
For this schema:

This is how it looks like when the user is the owner:

When the user is not the owner or it is not specified:

Type of change:

[x] New feature

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My PR title is Fixes <issue-number>: <short explanation>
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
[x] The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion or decision-making process is reflected in the issue.
[ ] I have updated the documentation.
[x] I have added tests around the new logic.

@nahuelverdugo this is bit more nuanced.
Examples users may want to mask the PII.Sensitive data only in such cases only columns which are tagged as PII should be masked
Second use case would be , a user who has permission to view PII data i.e his role / policy has the permissions to look at PII data. In this case even though the column is PII tagged we should show the data

@nahuelverdugo this is bit more nuanced. Examples users may want to mask the PII.Sensitive data only in such cases only columns which are tagged as PII should be masked Second use case would be , a user who has permission to view PII data i.e his role / policy has the permissions to look at PII data. In this case even though the column is PII tagged we should show the data

@harshach in this PR we give the possibility to create rules for policies.
I have added this one for the Organization:
  {
      "name": "OrganizationPolicy-ViewPIISampleData-Rule",
      "description" : "Deny seeing column sample data for table columns tagged with PII.Sensitive.",
      "resources" : ["table"],
      "operations": ["ViewPIISampleData"],
      "effect": "deny",
      "condition": "!isOwner()"
    }

If the user is the owner (or part of the owner team), it will be able to see the columns tagged with PII.Sensitive. Otherwise, the column value will be shown masked.
Am I missing something?

I am closing this PR since the approach must be different.


How can I use GPU acceleration？

My GPU is nvidia-RTX3090. I have already installed Cuda, and there is also a compilation package for Cuda when using install.sh. And  also enabled on the command line to enable_GPU, but when I render, the speed is still very slow, and the program in nvidia-smi does not occupy graphics memory.

Currently, enable_GPU only support CUDA acceleration for terrain, so there will only be active GPU usage during the terrain generation steps. However, we have been noticing an issue with terrain generation recently, such as in #53. Use nvidia-smi when specifically when running fineterrain to verify whether the GPU is properly accelerating terrain. If not, please post the generation logs so we can debug. It would also be helpful if you could check whether that the generated outputs have terrain. Thanks!

ok，i got it

Actually the render part of the code enabled GPUs, regardless of whether enable_gpu flag is passed.
# render/render.py
def enable_gpu(engine_name = 'CYCLES'):
    # from: https://github.com/DLR-RM/BlenderProc/blob/main/blenderproc/python/utility/Initializer.py
    compute_device_type = None
    prefs = bpy.context.preferences.addons['cycles'].preferences
    # Use cycles
    bpy.context.scene.render.engine = engine_name
    bpy.context.scene.cycles.device = 'GPU'

    preferences = bpy.context.preferences.addons['cycles'].preferences
    for device_type in preferences.get_device_types(bpy.context):
        preferences.get_devices_for_type(device_type[0])

    for gpu_type in ['OPTIX', 'CUDA']:#, 'METAL']:
        found = False
        for device in preferences.devices:
            if device.type == gpu_type and (compute_device_type is None or compute_device_type == gpu_type):
                bpy.context.preferences.addons['cycles'].preferences.compute_device_type = gpu_type
                logger.info('Device {} of type {} found and used.'.format(device.name, device.type))
                found = True
                break
        if found:
            break

    # make sure that all visible GPUs are used
    for device in prefs.devices:
            device. Use = True

    return prefs.devices

def render_image(
    camera_id,
    min_samples,
    num_samples,
    time_limit,
    frames_folder,
    adaptive_threshold,
    exposure,
    passes_to_save,
    flat_shading,
    use_dof=False,
    dof_aperture_fstop=2.8,
    motion_blur=False,
    motion_blur_shutter=0.5,
    render_resolution_override=None,
    excludes=[],
):
    tic = time.time()

    camera_rig_id, subcam_id = camera_id

    for exclude in excludes:
        bpy.data.objects[exclude].hide_render = True

    with Timer(f"Enable GPU"):
        devices = enable_gpu()

If I use tools/manage_datagen_jobs.py to generate images, GPU/CUDA is not being used in rendering step.
However, if I manually execute render step as listed inrun_pipeline.sh, e.g.
nice -n 20 $BLENDER --background -y -noaudio --python generate.py -- --input_folder outputs/seaice6/0/fine_0_0_0048_0 --output_folder outputs/seaice6/0/frames_0_0_0048_0 --seed 0 --task render --task_uniqname short_0_0_0048_0 -g arctic intermediate -p render.render_image_func=@full/render_image LOG_DIR='outputs/seaice6/0/logs' execute_tasks.frame_range=[48,48] execute_tasks.camera_id=[0,0] execute_tasks.resample_idx=0

blender will use GPU and rendering is significantly faster (25 min on GTX 1070  vs. 4 hours on Intel i7 6700 3.4G)
I don't know why tools/manage_datagen_jobs.py is not working for GPUs. What is difference between running tools/manage_datagen_jobs.py and execute commands in run_pipeline.sh?

Just starting with this project but one thing I've noticed - was researching why I am getting "skipping cuda" and found that
the top install.sh script has for build terrain:
if [ -f "/usr/local/cuda/bin/nvcc" ]; then
USE_CUDA=1 bash install_terrain.sh
else
USE_CUDA=0 bash install_terrain.sh
fi
and I'm using Ubuntu 22.04 LTS, nvidia driver 530.41.03    CUDA Version: 12.1  with the package nvidia-cuda-toolkit
that installs /usr/bin/nvcc
That package is not in the docker image so installing it now and will fix that in the script and test.

My GPU is nvidia-RTX3090. I have already installed Cuda, and there is also a compilation package for Cuda when using install.sh. And also enabled on the command line to enable_GPU, but when I render, the speed is still very slow, and the program in nvidia-smi does not occupy graphics memory.

I also have the same problem,how can i solved it.

My GPU is nvidia-RTX3090. I have already installed Cuda, and there is also a compilation package for Cuda when using install.sh. And also enabled on the command line to enable_GPU, but when I render, the speed is still very slow, and the program in nvidia-smi does not occupy graphics memory.

I also have the same problem,how can i solved it.

Perhaps this is not a problem. In some stages, the program will use GPU acceleration, in other stage，the program is not。

You should expect to see GPU usage briefly during the fine_terrain stage, and for a decent duration during any rendering stage. 0 GPU usage during coarse/populate stages is expected and typical. Confusion RE LocalScheduleHandler.use_gpu will be cleared up via PR


TPMmodulePinout.md: Initial commit

docs/data/instrument.patch file should be deleted.
Also what about snake_case file naming convention? I thought we've been talking about it some time ago.

Commits about pinouts are in the main branch so this MR could be closed.


Remove cupy_stdint.h

Visual Studio 2012 and later supports stdint.h. So, I want to remove cupy_stdint.h
dlpack.pyx uses stdint.h directly. Maybe almost users acceptable this PR.

Jenkins CI test failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins CI test (for commit
596886d56a8c172afbc9699f224cd6aa106150ad) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM!

I confirmed Windows build pass with this PR.


RestClient::Resource timeout exception?

Hi, for unavoidable reasons, we are still using older version of restclient(1.7.3).
I have to add a timeout feature for my rest calls which is doing a GET.
This is the code roughly:
begin
resource = RestClient::Resource.new(url, :timeout => 3)
response = resource.get
rescue => e
Rails.logger.error "Exception in method xyz"
end
From what I have understood so far restclient(1.7.3) when times out raises RestClient::RequestTimeout. This should be caught in my general resque. Is that correct? Please clarify.

Yes, in rest-client 1.7.x you can pass :open_timeout to set a timeout on connecting and :timeout to set a timeout on reads.
Both will cause RestClient::RequestTimeout to be raised. This inherits from the main response/exception class, RestClient::ExceptionWithResponse.
The confusing part in rest-client 1.7.x is that this same exception will also be raised if a server returns a HTTP 408 "Request Timeout" response. The only way to tell the difference is to examine .response (nil versus response string object) or .message on the exception object.
http://httpbin.org/delay/5 also provides a decent way to test your timeout behavior.
http://httpbin.org/


Corrupted MSF when I dump disc without /c2 with /be raw mode in BW-16D1HT

Describe the bug
Thanks to the last fix, the /be command in DIC started working, but when I use it and do not use the /c2 command at the same time, practically all sectors in the dump are damaged, including those where DIC normally does not report any error. Among other things, the MSF, synchronization, etc. are damaged, and the scm file is not created. According to my observations, the problem appears only when the BW-16D1HT drive is used
Log file
LPM2000 (ASUS).zip

Sorry, more fixed.
DiscImageCreator_test.zip

Thanks. Well, it's almost good, there's still some improvement to be made
LPM2000 (ASUS).zip

Some changed.
DiscImageCreator_test.zip

Still bugged
LPM2000 (ASUS).zip

Which point is the bug? It seems that LBA 340 ... 347 are intentional or real error.
LBA[000340, 0x00154]: Track[01]: Invalid sync. Skip descrambling
========== LBA[000340, 0x00154]: Main Channel ==========
       +0 +1 +2 +3 +4 +5 +6 +7  +8 +9 +A +B +C +D +E +F
0000 : 00 FF FF FF 7F FF FF FF  FF FF FF 00 FF 13 40 62   ..............@b

The synchronization of 8 sectors is broken (see the file ending in .img_eccedc.txt)

Yes, it's not the app problem.

So what causes this error? When I dump the disc with the /c2 option, there are no C2 errors on sectors with broken sync, also when I dump this disc on Plextor without /c2, there are no broken sync errors

I'm not sure but one thing I can say is ASUS can't dump these sectors if it's not the cause of the disc.

APPROX. So I leave it as it is and close the ticket. Thanks again for your help


looklook run on the postgresql

Install and set up the database for use by the looklook. user can install either PostgreSQL or MySQL

这个合并这么多历史提交


Did not update last message userID when receive message

I found that QMService did not update lastMessageUserID when receive/send message, only update last message text.
Please check.

Hi tranngoclinh88,
Please provide us full logs with this issue

Related issue
https://github.com/QuickBlox/quickblox-ios-sdk/issues/342

tranngoclinh88, thank you for the report!
I was able to reproduce the issue, you can apply git diff or merge from feature/QMSERVICES-13 git branch.
This branch will be merged into develop branch and then will be merged in master in the next release.
Thanks!


Add "broccoli-plugin" keyword to package.json

I use http://broccoliplugins.com/ to fine plugins, so I didn't immediately stumble upon your plugin. Adding the broccoli-plugin keyword (and probably doing a publish) will get cause this plugin to be listed.

Thanks! Publish under version 1.0.1


Make sure dataflowOss is added to metaData.overlays

Fix a bug in joern-parse where dataflowOss wasn't added to metaData.overlays.

yess!


[HOLD Needs Repro] Keystrokes aren't being quickly recognized when typing immediately after opening a chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699896354633069
Action Performed:

Go to any report
Go to a different report with a lot of chats and immediately start typing quickly.  (I navigate via cmd+k)

Expected Result:
All the keystrokes entered show up quickly and consistently in the compose box
Actual Result:
There is a delay in the keystrokes showing (which gets better after a few seconds)
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/8aecfaff-5674-4886-b051-90b622595f58

View all open jobs on GitHub

https://github.com/Expensify/App/assets/59587260/6ef97bc5-d7c2-4b25-941d-bc110d98a3d4
I wasn't able to reproduce :( @mallenexpensify what version are you using?

I wasn't able to reproduce either @kadiealexander , at least not consistently.  I unassigned you, assigned me, and put on hold, pending reproduction steps. I'll keep trying to break it :)
Im' on Version 1.3.99-0 , Desktop.  Also tested Chrome and wasn't able to repro. Thx

Just updated to latest version on desktop and unable to reproduce so, closing.


maven: update pom.xml version numbers to release <IP_ADDRESS>-SNAPSHOT

Post <IP_ADDRESS> release/tag, the next version should be set to <IP_ADDRESS>-SNAPSHOT.  Once this PR is tested and gets merged, the merger should do this after checking that all <IP_ADDRESS> commits are merged on master: git checkout master && git merge -X ours origin/4.11
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):
How Has This Been Tested?

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
Testing
[x] I have added tests to cover my changes.
[x] All relevant new and existing integration tests have passed.
 I'll keep you posted as I make progress.

The only changes are in the version string, no need to any regression test given packaging and travis have passed.

Ping @PaulAngus @wido @DaanHoogland @GabrielBrascher @borisstoyanov

Dupes https://github.com/apache/cloudstack/pull/2728/files so closing


add body parameters

Hi is there a method for adding body parameters?

All parameters are added to the body by default, unless required to be in the URL as the HTTP spec defines (GET, DELETE, HEAD, etc). If you want JSON in the body you can use the JSONRequestSerializer.

Oh sweet, do you have an example of that?

Ok got it thanks!


[BUG] Security saml-example is using docker-compose file pointed to 1.0.1

What is the bug?
When demonstrating for users how to setup saml for their clusters an example docker compose file is offered to streamline configuration.  This file contains hardcoded references to the 1.0.1 release version of OpenSearch, which is not supported, instead this sample file should use the latest version(s) of OpenSearch/Dashboards.
How can one reproduce the bug?
See https://github.com/opensearch-project/documentation-website/blob/main/assets/examples/saml-example.zip its hardcoded to a specific version and hasn't been updated since it was added.
What is the expected behavior?
As newer versions of OpenSearch become available the sample file should be updated.  Note, a latest docker version identifier could be used.
Note; this file should also be stored as plaintext instead of a binary and dynamically assembled on website push - feel free to make another issue.
Do you have any additional context?
From the docker-compose.yml file within that zip:
version: '3'
services:
  opensearch-saml-node1:
    image: opensearchproject/opensearch:1.0.1
    container_name: opensearch-saml-node1
    environment:
      - cluster.name=opensearch-saml-cluster
      - node.name=opensearch-saml-node1
      - discovery.seed_hosts=opensearch-saml-node1,opensearch-saml-node2
      - cluster.initial_master_nodes=opensearch-saml-node1,opensearch-saml-node2
      - bootstrap.memory_lock=true # along with the memlock settings below, disables swapping
      - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" # minimum and maximum Java heap size, recommend setting both to 50% of system RAM

@. Change the Naarcha-AWS  what exactly is needed to be done here? Update the current version of openseacrh version in the file or to use a docker identifier?
Would like to work on this if it is not assigned to anyone else.

Since the example is inaccurate, we should update the example to use latest, rezip the files, and add a disclaimer to update latest to the user's desired OpenSearch version.
@cwillum: Can you take this on?


time() on the client is not guaranteed to be synced to the server

Naive use of time() to determine the seconds since some server milestone (sent by the server) will result in unexpected results, especially when the client has taken a significant amount of time to load (e.g. 75 seconds between the first time time() was set and when the client loads).
We should aim to synchronise these to the greatest extent, so that it works as expected.

Hm, it looks like the time is already synchronised by the server on each sim tick. It looks like what we saw was due to the initial sync. I'll close this unless it becomes more obvious an issue later.


Fixed typos and made shapes.py conform more to PEP8.

This commit makes the following tweaks:

Fixing typos.
Removing a bare try, except clause (I'm not sure what the purpose of it is and it just makes it harder to debug.)
Removing redundant parenthesis as suggested by caffeine pills on discord.
Adding spaces after commas in a tuple (PEP8).

class BorderedRectangle(_ShapeBase) is missing a description of the parameter border.

Ok, I've added some descriptions for the border and border_color parameters of the BorderedRectangle class.

class Star(_ShapeBase):
    def __init__(self, x, y, outer_radius, inner_radius, num_spikes, rotation=0,
                 color=(255, 255, 255), batch=None, group=None) -> None:
        """Create a star.

I'm not sure whether we should keep this return value annotation since it is inconsistant with the rest of the classes.


Compilation Error dependOnInheritedWidgetOfExactType is not defined for the class BuildContext

Error coming from plugin
Compiler message:
file:///C:/flutter/.pub-cache/hosted/pub.dartlang.org/groovin_widgets-1.4.5/lib/groovin_list_tile.dart:100:17: Error: The method 'dependOnInheritedWidgetOfExactType' isn't defined for the class 'BuildContext'.
 - 'BuildContext' is from 'package:flutter/src/widgets/framework.dart' ('file:///C:/flutter/packages/flutter/lib/src/widgets/framework.dart').
Try correcting the name to the name of an existing method, or defining a method named 'dependOnInheritedWidgetOfExactType'.
        context.dependOnInheritedWidgetOfExactType<ListTileTheme>();
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compiler failed on C:\Users\Ashish\Desktop\rpstuff\android_app\cps_controller\lib\main.dart

FAILURE: Build failed with an exception.

* Where:
Script 'C:\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 665

* What went wrong:
Execution failed for task ':app:compileflutterBuildDebugArm64'.
> Process 'command 'C:\flutter\bin\flutter.bat'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 9s
Finished with error: Gradle task assembleDebug failed with exit code 1

Also getting this error only when building on iOS. Works fine for android builds

Hey guys. Will address this now. Thanks.

This is strange - the usage of dependOnInheritedWidgetOfExactType<ListTileTheme>() is the same as in the Flutter source code. Basically, GroovinListTile is a modified version of a regular ListTile, it just changes some minor things in order to be used within GroovinExpansionTile. I have no idea why this bug exists. Are you guys still experiencing it? Can you send me reproducible code so I can do some further investigation please?

Following steps helped me overcoming the issue:

switching to master branch of flutter.
changing groovin_widgets to version ^1.5.0+1


Assignment to invalid subscript range

fixed by moving the 'source' line above ZSH_HIGHLIGHT[...]
Here is the full error:
/home/dtch/.zshrc:94: ZSH_HIGHLIGHT_STYLES: assignment to invalid subscript range
Here is the syntax portion of the .zshrc
# zsh Syntax Highlighting

ZSH_HIGHLIGHT_HIGHLIGHTER=(main)

#ZSH_HIGHLIGHT_STYLES[command]='fg=yellow,bold'
ZSH_HIGHLIGHT_STYLES[alias]='fg=cyan'

source /usr/share/zsh/plugins/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh

And the entire .zshrc

@dtch You ever figure this one out? I know this is 2 years old, but I'm having a hard time finding the right documentation to show me how to override a single color attribute without modifying the files installed by homebrew. Long shot. /sigh

@dtch- You unbelievable cretin! Do you know how ill mannered, nasty, cruel, abhorrent and totally against all we stand for as a species to just close something and walk off having solved the problem without telling anyone how they did it?
How selfish can you be?


*: improve retry logic and defaults

The current default of 0 Steps is causing instant exit. This PR sets the default and minimum to 1.
/cc @wking @abhinavdahiya

I'd have expected a zero default with "retry forever" semantics.  Does that seem feasible?

I'd have expected a zero default with "retry forever" semantics. Does that seem feasible?

@wking yes that makes sense to me updated.
@abhinavdahiya OK, now we retry forever by default thoughts?

bah thats not right... resolving.

OK I think that is sane

Carried in #27.


[Feature Request] Add in Favorited Games

Add in an ability to favorite a game to pin it to the top of the games list.

I saw you forked the project @aflyingpumpkin is this something you're interested in adding?
I saw you started working on ProtonDB integration, awesome thanks. Happy to help you troubleshoot if you open a PR, maybe async problems?


some of the ref access_keys were generating as the same

@twinge
made it a lot more aggressive to not have any duplicates.  Seem
important otherwise people could just change their id by one and with
the same access_key they can access someone else's ref
I added these to the string the key is built off:
1 - milliseconds to the generate time
2 - the largest id in the reference sheets table
3 - a nonce on at the class level (in case generate_access_key happens
to get called multiple times before a save happens that would
incremement the largest id in the table)

@twinge how's this?

why make it a module? are you going to use it in multiple places?

Yeah, I said in the commit.. I'm using it in some enclosing apps,
specifically the cap uses an access key for the pre-interview form
On 26 Jun 2015 20:17, "Josh Starcher"<EMAIL_ADDRESS>wrote:

why make it a module? are you going to use it in multiple places?
—
Reply to this email directly or view it on GitHub
https://github.com/CruGlobal/qe/pull/28#issuecomment-115923531.

Sorry for missing that. :+1:


Struggling with error Found com.google.android.gms:play-services-location:+, but version 9.0.0 is needed for the google-services-plugin

I'm struggling along with this error
        Found com.google.android.gms:play-services-location:+, but version 9.0.0
        is needed for the google-services plugin

I tried running ionic cordova build android --stacktrace --debug --log but it doesnt give me any more information on the offending plugin.
My understanding is that theirs a version clash with my plugin dependencies but this was the last plugin I installed https://github.com/cowbell/cordova-plugin-geofence/ and it says
<framework src="com.google.android.gms:play-services-location:+" />

in its plugin.xml and my gradle.build for my project has this compile block
dependencies {
    compile fileTree(dir: 'libs', include: '*.jar')
    // SUB-PROJECT DEPENDENCIES START
    debugCompile(project(path: "CordovaLib", configuration: "debug"))
    releaseCompile(project(path: "CordovaLib", configuration: "release"))
    compile "com.android.support:support-v4:25.+"
    compile "com.android.support:appcompat-v7:25.+"
    compile "com.squareup.okhttp3:okhttp:3+"
    compile "com.android.support:support-v4:24.1.1+"
    compile "com.google.firebase:firebase-core:+"
    compile "com.google.firebase:firebase-messaging:+"
    compile "com.google.android.gms:play-services-location:+"
    // SUB-PROJECT DEPENDENCIES END
}

I've done a search across the plugins and I only see these mentions in 2 plugins
cordova-plugin-fcm
        <framework src="com.google.firebase:firebase-core:+" />
        <framework src="com.google.firebase:firebase-messaging:+" />

cordova-plugin-geofence
<framework src="com.google.android.gms:play-services-location:+" />

Am I thinking about this incorrectly? I'm not a Java/Android developer so this part of it is all new to me

I was having this exact issue!  I resolved it by sigh adding another plugin.
someone made a package to resolve this exact conflict: https://github.com/dpa99c/cordova-android-play-services-gradle-release
Adding this plugin resolved my issue

Thanks, I'll give it a shot.
I've already spent quite a bit of time on this but the plugin you mentioned may also resolve the issues we had trying to setup up the Firebase Analytics plugin which resulted in similar errors.


fixed build error due to libSM and libuuid

added a uuid flag to link libraries to fix issue #2452

Thanks for the PR and for taking the time to look into this.
I don't think there is a problem in the build system. The problem is actually using precompiled libs built on Fedora on Ubuntu.
I think that the fix is correct for your specific case, but we should not do this change for everyone.
Instead, we have a cmake variable that you can use: APPLESEED_LINK_EXTRA_LIBRARIES.
You can add -DAPPLESEED_LINK_EXTRA_LIBRARIES=-luuid in your cmake command line and that should probably fix the issue for your build.


Error: Repository orchestrator-server doesn't exists

Installation information

jumpscale version: master
operating system: Ubuntu 16.04

Detailed description
When trying to do 'ays repo destroy' to do a reset, it gives the error 'Error while destroying repository: Repository orchestrator-server doesn't exists'. Suddenly the orchestrator-server repo is gone and a reinstall is needed to get it fixed.
Steps to reproduce
Relevant stacktraces
When trying to restart ays:
ERROR - can't load repo at /optvar/cockpit_repos/orchestrator-server/: ERROR: error:Expected object or value
\could not parse:
path:/optvar/cockpit_repos/orchestrator-server/services/configuration!main/data.json
((type:input.error)
Traceback (most recent call last):
 File "/opt/code/github/jumpscale/core9/JumpScale9/data/serializers/SerializerBase.py", line 13, in load
   r = self.loads(b)
 File "/opt/code/github/jumpscale/core9/JumpScale9/data/serializers/SerializerUJson.py", line 16, in loads
   return json.loads(s)
ValueError: Expected object or value

There seems to be an error in the service data of "configuration!main"
This will cause this repo to be unloadable in the Ays server. Did you
manually change anything?
On Jul 27, 2017 16:18, "jvwilder"<EMAIL_ADDRESS>wrote:
Installation information

jumpscale version: master
operating system: Ubuntu 16.04

Detailed description
When trying to do 'ays repo destroy' to do a reset, it gives the error
'Error while destroying repository: Repository orchestrator-server doesn't
exists'. Suddenly the orchestrator-server repo is gone and a reinstall is
needed to get it fixed.
Steps to reproduce Relevant stacktraces
When trying to restart ays:
ERROR - can't load repo at /optvar/cockpit_repos/orchestrator-server/:
ERROR: error:Expected object or value
\could not parse:
path:/optvar/cockpit_repos/orchestrator-server/services/configuration!main/data.json
((type:input.error)
Traceback (most recent call last):
File "/opt/code/github/jumpscale/core9/JumpScale9/data/serializers/SerializerBase.py",
line 13, in load
r = self.loads(b)
File "/opt/code/github/jumpscale/core9/JumpScale9/data/serializers/SerializerUJson.py",
line 16, in loads
return json.loads(s)
ValueError: Expected object or value
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/ays9/issues/129, or mute the thread
https://github.com/notifications/unsubscribe-auth/AICRIngTpooObb9iJrS94HZFvDve00ptks5sSJwhgaJpZM4OlWWh
.

I did not change anything, but the 'data.json' file was empty when I checked.


Does BFS cannot traverse all vertices？

Does BFS cannot traverse all vertices？
while(!Frontier.isEmpty()){ //loop until frontier is empty
vertexSubset output = edgeMap(GA, Frontier, BFS_F(Parents));
Frontier.del();
Frontier = output; //set new frontier
}

you may close this issue too. thanks


WebSocket connect error is not forwarded

Opening as requested in #41
Currently due to lack of WebException support in netstandard13 in case of connect error, a generic 400 error is returned instead of forwarding original response.
In full .NET Framework following code could be used to extract the original response
var res = (ex.InnerException as WebException)?.Response;

This issue was moved to aspnet/Home#2494


Port from Caporal to Commander

Caporal appears to be dead upstream (mattallty/Caporal.js#243), and pins an insecure version of lodash (mattallty/Caporal.js#212, mattallty/Caporal.js#224, mattallty/Caporal.js#239). Commander is actively maintained, has no dependencies, and is much faster as a bonus.  It’s missing Caporal’s colored logging feature, but that’s easy to reimplement.

@andersk the pr looks great!
Would you mind updating from latest so we can confirm passing tests?
I had to make a minor update for pnpm@7 to work as expected.
Thanks again!

Sure, rebased. (You’ll need to re-approve the GitHub Actions workflow.)

@andersk Awesome stuff!
I'll release this as a major release [just to be safe] tomorrow.


As a user, I want to see the available options for a subcommand and the default values for each

I'm going to close this and the associated epic as too vague. This issue should be revisted in the future with more refined spec.


[Bug] Clarify Node.js and Go versions

Describe the bug
It is not clear which Node.js and Go versions are suitable for running this project.

The main README specifies Node.js 12.x, but the prereq page from the docs site specifies 10.15.x.
There is no mention of any Go version anywhere.

In addition, it's not clear which operating systems/architectures this is supposed to work on (aside from amd64 linux). How about macos with Intel or ARM?
To Reproduce
Expected behavior
There should be at least one example of a working node.js version in a package.json. There should also be at least one documented version of Go that results in a successful installation.
Versions (please complete the following information):
v3.2.0

If it helps, I managed to run the full installation using:

M1 Macbook, macOS Big Sur v11.0
Node.js 12.22.1
Go 1.16.5

Hi,
Sorry to hear that you found issues with the docs.

The recommended Node.js version is 12.x
The recommended Go version is 1.13.7+ from the s3-synchronizer README

We'll update the docs to make those versions consistent across the different pages


[SDL 0173] Read Generic Network Signal Data

Proposal: Read Generic Network Signal Data

This proposal is to make vehicle data APIs (GetVehicleData/SubscribeVehicleData/UnsubscribeVehicleData/OnVehicleData) more flexible to allow additional new vehicle data items, while maintaining the security access via policies.

Review: https://github.com/smartdevicelink/sdl_evolution/issues/502
Steering Committee Decision:

The Steering Committee voted to accept this proposal with revisions. The author is to add a statement explaining how old core implementations using this method can be updated to expose new standardized vehicle data items. Additionally, the author is to add the three revisions noted in this comment.

The proposal .md was updated on March 11, 2019 to include the agreed upon revisions.

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal SDL 0173 Revisions - Read-Generic-Network-Signal-data.  Please reference issue and proposal markdown file for more details.

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal SDL 0173 Revisions - Read Generic Network Signal Data Clarification. Please reference issue and proposal markdown file for more details.


Consider links needed between the A to Z and other parts of the style guide

What
Review/list links needed between the A to Z and other parts of the content style guide.
Why
When we user tested the content style guide with content designers, we found that we need more linking between different parts of the service manual, in particular between the A to Z and other parts of the content style guide.
Next steps

[ ] Add links between the A to Z and other parts of the style guide #866

Done.


feat: add clear method to useSet hook

Description
Add clear method to useSet so that a user could clear the values in a set created with some initial values
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[ ] Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

any update on this?

Can we please merge this?


Need strategy for client and server upgrades

Eventually, we will have different released versions of Jadeite. We will need a strategy for how to manage this.
Brain dump of some issues to handle:

How to handle Jadeite-Rowan services api changes?
New api's?
Deprecated api's?
Possibly create a "minimum Rowan version" in Jadeite - ie you can't login unless you have this version of Rowan.

This will need to involve all the pieces of Edelweiss so assigning @dalehenrich and @LisaAlmarode for discussion.

Additional data point - The informal plan has been to separate RowanServices packages into their own project so they can be loaded independently of Rowan.

I think this has been resolved with the services and version notifications, and this bug isn't of value any more.

One part of the solution/toolset could involve loading multiple versions of RowanClientServices into in image (on demand or explicitly) and Jadeite could pick the latest version that is available … this topic is worth discussing when all three of us are in office?


Replaces UnbalancedDataset with imbalanced-learn in README

This PR replaces some UnbalancedDataset with imbalanced-learn in README.
Addresses #98

Merged in 0.1.X and master branch


add sstr to readme

Have a nice day.

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   74.94%   74.94%
=======================================
  Files          10       10
  Lines         455      455
=======================================
  Hits          341      341
  Misses        114      114

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c19e81...01add1a. Read the comment docs.

Thanks for creating this PR.


refactor media controller controlled_resources

media controller is for the Medium polymorphic resource. The controller has to interpret the nested routes to determine the correct Media scopes based on linked_id, linked_type lookups. Please note, this long running PR had master merged and extracted common behaviour for both media / translations controllers.
This PR ensures the polymorphic (media / translations) controllers correctly link resources to the polymorphic scope (e.g. find all translations for project 1, where i can update project 1).
This PR also ensures the before_filter ordering tests the etag precondition on the correct resources not the polymorphic link resources.
Finally I added in a test to ensure we don't erroneously destroy the parent resources by mistake, i think by luck we never hit this before but it will now 500 if this happens. This is a new feature but should safegaurd against any controller attempting to delete resources types it doesn't not control.
~This will be some ground work for #2435 and I may extract this to a shared module if the pattern fits for the translations polymorphic resource authorization.~ I have extracted this to a shared controller module and included this in translations after merging from master. It cleans up the controller code quite nicely though one has to understand the included module code.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

I've tried understanding this, but I don't seem to be able to. Maybe you could talk me and @zwolf through it sometime?

@marten @zwolf happy to provide a drive by of the code and glean any places I can refactor to make it more obvious. Did you want to provide some inline questions or maybe just as we go through it?

@marten I know you've reviewed / approved this PR before but i merged master and refactored common polymorphic controller behaviour building on your previous comments. The new implementation is much cleaner without hacking instance vars and carefully plotting callback timing.
Most of this is the same as before but I would appreciate you looking at it again and I apologise for the size of this PR.


Add a basic admin interface (Fix issue #10)

Here is a basic admin interface implementation.
Any comments is welcome.
Access admin through http://my-isso.installation.com/admin
Set password in section [general] with the key admin_password = mylongpasswordwontgetbroken
Jinja2 is a new dependency for templating admin interface.

Thank you for this! I've tested it, works fine and interface is OK.
Some things I'd like to see in the future:

Possibility to group comments by thread. At least indicate thread for each comment.
Not only Delete but also Edit button

I am really glad that Isso now has a decent administration panel! Now the only feature I miss in Isso is an email notification of the commenters.

@pozitron57 Better add your wishlist to #10

I rebased on the last master and added some of the suggestions of @pozitron57.

List of suggestions by @pozitron57 and their status on this PR:

[ ] Fix error 500: At right of the panel I see Pages: 0 ». Clicking the link » gives a page of Internal Server Error
[ ] Possibility to group comments by thread
[ ] Indicate thread for each comment
[ ] Not only Delete but also Edit button
[ ] Possibility to revert changes
[ ] Show email of the commenter
[ ] Make everything editable — email, time, name, website, etc.
[ ] Possibility to reply to the comment
[ ] Show avatars

@pozitron57 what did you meant by "Possibility to revert changes"?

@blatinier, imagine that user have deleted comment. And then realized that actually he didn't want to delete it. With the current implementation it is not possible to revert this action — comment is gone. In gmail, for example, when you delete the message, you will have a tooltip: «The conversation has been moved to the Bin.  Undo». Clicking on Undo will restore the message. It would be great one will have this Undo button after deleting/editing the comment in the admin panel.
By the way, I have one more suggestion: for each comment add a link to the page where the comment is posted.

Editable email, author, website and message.
Things you cannot edit: Thread, time and votes.

I added the link to the thread, which will allow to go answer if the administrator wants to. Having done this, I don't see the real benefit of deplucating the reply mechanism in the admin interface. So I won't do it unless someone convince me it makes a real difference.

Nice work! Forgive me if I'm missing something, but I had to make the following modifications to get it to work:
https://github.com/blatinier/isso/compare/issue-10/admin-interface...jtanx:issue-10/admin-interface?expand=1

Nop you're right. If make a PR on my fork I'd be glad to merge

@posativ Any suggestion on what's mandatory for merging this?
All proposed features are not implemented but most important ones are and it could benefit a lot to users having a real administrative space.

Just rebased on master, to allow some people interested in the admin interface to be up to date regarding master.

If I installed using pip install isso, how could I try your changes?

@hamoid sorry for the late answer.
You should install another version of isso using my repository. You clone it, go inside the folder and run pip install .
However using virtualenv is not an option if you want to try my version without messing with the current one you have running. And you should be careful to the used ports, so that they don't overlap.
If it seems like too much trouble, try to get @posativ to merge this, but he seems quite busy and do not spend so much time around here from what I saw lately. And given the size of the PR I get that it should be reviewed thouroughly.


pull from master aws

Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the CONTRIBUTING doc
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
[ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e3c4a597cf617dbcd412878ff6487a0986154b97
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e3c4a597cf617dbcd412878ff6487a0986154b97
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e3c4a597cf617dbcd412878ff6487a0986154b97
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 57556a73511fd200b457e56e5a606d01214ffbda
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 57556a73511fd200b457e56e5a606d01214ffbda
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 57556a73511fd200b457e56e5a606d01214ffbda
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: da17b29a9e654c8273bb53338ced63b2284e31c9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: da17b29a9e654c8273bb53338ced63b2284e31c9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: da17b29a9e654c8273bb53338ced63b2284e31c9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6a782d959050449afe9508710286a2fa117da06d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6a782d959050449afe9508710286a2fa117da06d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6a782d959050449afe9508710286a2fa117da06d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b32821e21ccb51fd7ae5c3d91b1cb6dccd701372
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b32821e21ccb51fd7ae5c3d91b1cb6dccd701372
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f7a57c2b02adb61e0e4ba89965a3a235a382bcc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f7a57c2b02adb61e0e4ba89965a3a235a382bcc6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9b437be692e54ae9b2761a1bb774b405d88213b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9b437be692e54ae9b2761a1bb774b405d88213b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9b437be692e54ae9b2761a1bb774b405d88213b8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 36a1ed4f6488ea467747041d4ab3865b0f00931f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 36a1ed4f6488ea467747041d4ab3865b0f00931f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 36a1ed4f6488ea467747041d4ab3865b0f00931f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 36a1ed4f6488ea467747041d4ab3865b0f00931f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 36a1ed4f6488ea467747041d4ab3865b0f00931f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 36a1ed4f6488ea467747041d4ab3865b0f00931f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 36a1ed4f6488ea467747041d4ab3865b0f00931f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID:<PHONE_NUMBER>589db6747c764460b0975565af5a1a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID:<PHONE_NUMBER>589db6747c764460b0975565af5a1a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID:<PHONE_NUMBER>589db6747c764460b0975565af5a1a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID:<PHONE_NUMBER>589db6747c764460b0975565af5a1a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID:<PHONE_NUMBER>589db6747c764460b0975565af5a1a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID:<PHONE_NUMBER>589db6747c764460b0975565af5a1a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID:<PHONE_NUMBER>589db6747c764460b0975565af5a1a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: aa5468540300a8347f1d496541893c30f980ab9e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: aa5468540300a8347f1d496541893c30f980ab9e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: aa5468540300a8347f1d496541893c30f980ab9e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: aa5468540300a8347f1d496541893c30f980ab9e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: aa5468540300a8347f1d496541893c30f980ab9e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: aa5468540300a8347f1d496541893c30f980ab9e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: aa5468540300a8347f1d496541893c30f980ab9e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


React intl grpby AWS details

issue: https://issues.redhat.com/browse/COST-1372

Codecov Report

Merging #2111 (1d70dcf) into react-intl_changeover (3ba2124) will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           react-intl_changeover    #2111   +/-   ##
======================================================
  Coverage                  70.37%   70.37%
======================================================
  Files                        410      410
  Lines                       7506     7506
  Branches                    1457     1457
======================================================
  Hits                        5282     5282
  Misses                      2192     2192
  Partials                      32       32

Impacted Files
Coverage Δ

src/locales/messages.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e753b...1d70dcf. Read the comment docs.


HOW to re adjust  symbol

Hi femtotrader...
I try this replicator on MT4. It seems okey and great.
Wanna ask u.... How to re adjust the name of symbol. Due to there is different symbol for different broker.
For example on IC Market, Gold symbol is XAUUSD but... On FX Primus is XAUUSD-
For micro account. The symbol always add by micro. I.e. GBPUSDmicro, CHFJPYmicro and so on..
In which part we can modify the symbol?  Thanks...

I don't use this code since many years.
You should store instruments mapping in a hash map like http://www.lordy.co.nf/mql4/
in the slave code
Feel free to submit PR.


Add MySQL Connector to requirements.txt

MySQL connector missing from requirements.txt

Added mysql-connector-python to requirements.txt. See 6f828207f4d982d582f0d899c2bce6d58c428c6f


Problems with climate

Hello, after restarting HomeAssistant i have lost ability to use climate component.

Don't know why it tried to change to direct mode, i never used direct mode on my pump..
And it's happening everytime HA is restarted, and climate component is failing.
Tried to downgrade integration, issues are in all versions till 7.2. It's seams something changed in HomeAssistant, before everything worked.

Hello,
thanks for the report.
The warning is "expected" because we don't know what how heatpump is working at HA startup so we apply the direct mode by default and later change it to the correct value based on the message sent by HeishaMon.
Two solutions for this:

we could not log this as a warning, especially for the change triggered at initialization which is purely a way to have an consistent internal state
it is also possible to store the state in HA between restarts and re-read it at startup but the code to do this is a bit more involved.

That being said, I don't see yet if this is related to your first issue which is more serious. I need to investigate (which version of HA do you have?)

Here is mine HA version:
Home Assistant 2022.11.2
Supervisor 2022.10.2
Operating System 9.3
Frontend 20221108.0 - latest
I think i am on latest version.
Warning i understand why it happening, but climate components would not start anymore.. it seams that HA after reboot remembers devices, and on intialize it tires to recreate them.. or maybe they are created and updated in same time. My heishamon MQTT retransmission  set to 5 sec.

While trying to reproduce I stumbled upon https://github.com/kamaradclimber/heishamon-homeassistant/pull/48 which is probably very close to your issue. I'll try to reproduce yours specifically.

Thanks, it seams problem solved. After update, climate components start to work.


Custom Recorder should prevails over others

It's not possible to use an extended/modified/custom MultiStreamRecorder because algorithm applies standard MultiStreamRecorder over configured in config

Looks good to me. ping @muaz-khan


Normalisation, accuracy violin plots, and inherently multi-class classifiers

Things I've done:

I had a go at normalising the features, but the accuracy went down. It looks like normalisation is not needed for this dataset.
I managed to make a violin plot of the posterior balanced accuracy, which looks pretty cool!
I did a bit of cleaning up and moved reusable code to separate script files (still need to write proper documentation though).
I trained some inherently multi-class classifiers: the results look pretty much the same.

There is a concept called technical debt. You should spend some time writing documentation and reorganising before implementing more features.