Attempt to fix unwanted position update

The function position_changed? returns true even if the position remains the same. This because the corresponding method on the positioned object (@positioned.position_changed?) returns true due to the following code in positioning.rb and, in particular the first line of the redefined method:
          redefine_method(:"#{column}=") do |position|
            send :"#{column}_will_change!"
            super(position)
          end

Probably, my change could be moved to the above method but, since I don't really understand the reason behind that will_change!, I think that this version is less risky.

Hi @multiscan, thanks for this :)
The reason we signal that the position column has changed even if it's value hasn't is due to scope change detection. You could imaging that if you changed the scope of an item and also sent along its desired position but the position just happened to be the same as the items position in the previous scope, then we wouldn't detect the position change and instead the item would be put at the end of the new scope.
send :"#{column}_will_change!" will only be called if you explicitly set a position as part of the parameters sent to update() so the solution might be to not send that parameter if you're not changing it.
I'm certainly open to looking at this further with you if you think I've missed something. It's one of the uglier parts of this gem for sure. I did try hard to avoid it (since we do it in acts_as_list too) but unfortunately I couldn't think of another way around it. Rails dirty checking literally won't signal that an attribute was touched if its value wasn't changed.

Hello @brendon and thank you very much for your quick reply.
Your explaination makes me understand better. I dug deeper into the problem that made me start this MR and indeed found that the problem was not in the code but in my usage: in my seed files I was assigning position 0 to the first element. Then, when I was updating another element of the list, the update_position method was called. And, due to the fact that position_changed? is always true (at least for integer positions), the move_out_of_the_way method were called which were trying to temporarily assignposition=0. At that point, the database were refusing the record complaining that the value 0 for position were already taken.  This again, is due to the fact that my seed data were wrongly presuming that the position could start from 0.
Now that I have fixed my seed data and, I no longer have issues with your original gem.
Therefore I think I will close my useless MR.
Sorry for the waste of time.
Best,
giova

Don't apologise @multiscan! I'm glad you were able to get to the root of the problem :) That was a tricky one for sure.
ActsAsList does allow you to start from 0 so I can understand the confusion. Unfortunately we can only guard against that at the Active Record layer and it sounds like you were outside of that.
All the best! And be in touch if you need any assistance in the future :)


[RS-1564] Doc for anomaly detection reinstatement

We are recreating some anomaly detection function within the Runtime Security architecture.  Initially only the DGA detection algorithm.  As the design doc, for how we are choosing to present this:
Overall, our Calico Cloud documentation will continue to present “Anomaly Detection” (aka “Detect and alert on anomalies”) and “Container Threat Detection” as distinct features.  There is no anticipated need for the user to know that we now do these within the same architecture.  That also means that the UI control for “Enable Container Threat Detection” will continue to be accurate and valid.
More specifically, in the Calico Cloud docs, the previous page about anomaly detection “Detect and alert on anomalies” will be restored, with the following changes.

Material about configuration will be removed, as configuration is now unnecessary.

Material about specific algorithms - only DGA, in the first release - will be incorporated into this page, instead of in a linked reference page (previously https://docs.tigera.io/calico-cloud/reference/anomaly-detection).

Page will be generally reviewed and revised to ensure correctness for the new implementation.

The user will see security events for DNS lookups for algorithm-generated domain names, if such lookups are occurring in their cluster.  In the previous AD architecture this would have been subject to the existence of a GlobalAlert resource with type: AnomalyDetection and detector: dga, but now it will be unconditional.

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

@bmckercher123 FYI I have made this change a lot smaller and simpler after prompting from @ctauchen and agreement from @peterkellydev .  Please see Chris's comment above at https://github.com/tigera/docs/pull/1248#issuecomment-1900154802 and my summary of the change of direction in the message of this commit.


AttributeError: 'Query' object has no attribute '_join_entities'

Hi @cs91chris,
First of all, thank you for this awesome project!
I am getting the above error, when I try to run a request against any of the model endpoints,
import os
import pyodbc
from dotenv import load_dotenv

from flask import Flask

from flask_autocrud import AutoCrud, Model
from flask_sqlalchemy import SQLAlchemy

load_dotenv()

app = Flask(__name__)
app.config['SQLALCHEMY_DATABASE_URI'] = f"{os.environ.get('DB_CONN_STR')}?driver={pyodbc.drivers()[-1]}"
app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False
app.config['AUTOCRUD_METADATA_ENABLED'] = True
app.config['AUTOCRUD_DATABASE_SCHEMA'] = os.environ.get('DB_TABLE_SCHEMA')

db = SQLAlchemy(app)

with app.app_context():
    AutoCrud(app, db)

if __name__ == '__main__':
    app.run(debug=True)

When I run a requests against the /resources endpoint I see all of the tables in my schema though.
Am I doing something wrong here?
Note: My SQLAlchemy version is 2.0.6.

Hi @MinuraPunchihewa, thanks and sorry for the late response. This repo is old and not maintened too, but I am sure that it is not compatible with sqlalchemy 2 for the breaking changes that ships with it.


CMake syntax highlighting bug

This particular file troubled ecode's syntax highlighter engine:
https://github.com/cnjinhao/nana/blob/a9398c1a4a855218b6b02bcf86969b38f6a892b7/build/cmake/compilers.cmake
Github highlights it correctly, ecode will consider this line as a comment:
if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang") #  AND NOT MINGW??

https://github.com/cnjinhao/nana/blob/a9398c1a4a855218b6b02bcf86969b38f6a892b7/build/cmake/compilers.cmake#L15

Fixed.


Split ld into a separate package

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

This is needed for the python package.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Table 5050 Contact - CalculatedName available for TableExtension

Hi Al-team,
I would like to call the function CalculatedName from a extension object. Can you customize it?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Error: Got unexpected extra arguments (                           )

When I try to run the following input:
songbird multinomial
  --input-biom /projects/qiita_data/BIOM/73084/otu_table.redist.species.biom
  --metadata-file /home/vjcantu/maz1/songbird/YooMeta2.txt
  --formula “genotype+activated”
  --epochs 20000
  --batch-size 10
  --differential-prior 1
  --learning-rate 0.001
  --min-feature-count 5
  --num-random-test-examples 10
  --summary-dir /home/vjcantu/maz1/songbird/
I get the following error:
Usage: songbird multinomial [OPTIONS]
Try "songbird multinomial --help" for help.
Error: Got unexpected extra arguments (                    )
Any tips on how to get around would be appreciated.

Hmm. Probably has to do with spacing. Can you trim down the number of
parameters for debugging ? You should be able to run with just input /
output specified.
On Fri, Jun 7, 2019, 1:10 AM vjcantu<EMAIL_ADDRESS>wrote:

When I try to run the following input:
songbird multinomial
--input-biom
/projects/qiita_data/BIOM/73084/otu_table.redist.species.biom
--metadata-file /home/vjcantu/maz1/songbird/YooMeta2.txt
--formula “genotype+activated”
--epochs 20000
--batch-size 10
--differential-prior 1
--learning-rate 0.001
--min-feature-count 5
--num-random-test-examples 10
--summary-dir /home/vjcantu/maz1/songbird/
I get the following error:
Usage: songbird multinomial [OPTIONS]
Try "songbird multinomial --help" for help.
Error: Got unexpected extra arguments (                    )
Any tips on how to get around would be appreciated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/songbird/issues/57?email_source=notifications&email_token=AA75VXJBGZZRBCVMRQU7J73PZGKNXA5CNFSM4HVL3QY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYEN6NA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA75VXLBLET7C35BPAGRRXTPZGKNXANCNFSM4HVL3QYQ
.

@mortonjt: @vjcantu and I got around this today -- retyping the command in bash, but outside of Barnacle, and then scp-ing the command up to Barnacle as a shell script worked. Likely a weird sort of character/spacing error.

Nice!
On Sat, Jun 8, 2019, 12:52 AM Marcus Fedarko<EMAIL_ADDRESS>wrote:

@mortonjt https://github.com/mortonjt: @vjcantu
https://github.com/vjcantu and I got around this today -- retyping the
command in bash, but outside of Barnacle, and then scp-ing the command up
to Barnacle as a shell script worked. Likely a weird sort of
character/spacing error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/songbird/issues/57?email_source=notifications&email_token=AA75VXOZX3HJ57U36AZBTG3PZLRDBA5CNFSM4HVL3QY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHFZBY#issuecomment-500063367,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA75VXIM5TDEIGWDBL4ED7TPZLRDBANCNFSM4HVL3QYQ
.

@vjcantu I'm going to close this issue.  If this pops up again, feel free to reopen.


Update status with error  when a new version of collection is not activated due to error condition

I updated Kabanero CR to a new release of collection. It seems like that one of the collections has some errors in the customization of pipelines. So all of the collections were activated to new release except the one which had issues. This behavior is correct. But it would  be nice to display the error in collection status or some other place which indicates there is a problem with new collections.
Collection which had issue activating new version:
spec:
  desiredState: active
  name: java-microprofile
  repositoryUrl: >-
    https://github.com/mtamboli/collections/releases/download/v0.3.6/kabanero-index.yaml
  version: 0.2.19
status:
  activeLocation: >-
    https://github.com/mtamboli/collections/releases/download/v0.3.5/kabanero-index.yaml
  activePipelines:

Collection which got activated to the new version correctly:
spec:
  desiredState: active
  name: java-spring-boot2
  repositoryUrl: >-
    https://github.com/mtamboli/collections/releases/download/v0.3.6/kabanero-index.yaml
  version: 0.3.16
status:
  activeLocation: >-
    https://github.com/mtamboli/collections/releases/download/v0.3.6/kabanero-index.yaml
  activePipelines:

Had to look at the operator log to know there was an error:
Header names:  ./,./build-push-deploy-pipeline.yaml,./._deploy-task.yaml,./deploy-task.yaml,./image-retag-push-task.yaml,./manifest.yaml,./._test-task.yaml,./test-task.yaml,./._image-scan-task.yaml,./image-scan-task.yaml,./._test-build-push-deploy-pipeline.yaml,./test-build-push-deploy-pipeline.yaml,./._build-push-task.yaml,./build-push-task.yaml
{"level":"error","ts":1574274128.83154,"logger":"kubebuilder.controller","msg":"Reconciler error","controller":"collection-controller","request":"kabanero/java-microprofile","error":"File ./._deploy-task.yaml was found in the archive, but not in the manifest.yaml","stacktrace":"github.com/kabanero-io/kabanero-operator/vendor/github.com/go-logr/zapr.(*zapLogger).Error\n\tsrc/github.com/kabanero-io/kabanero-operator/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/kabanero-io/kabanero-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsrc/github.com/kabanero-io/kabanero-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:217\ngithub.com/kabanero-io/kabanero-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1\n\tsrc/github.com/kabanero-io/kabanero-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158\ngithub.com/kabanero-io/kabanero-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\tsrc/github.com/kabanero-io/kabanero-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\ngithub.com/kabanero-io/kabanero-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\tsrc/github.com/kabanero-io/kabanero-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134\ngithub.com/kabanero-io/kabanero-operator/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\tsrc/github.com/kabanero-io/kabanero-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88"}

I configured CLI to see the status update in this case.
@davco01a  I think this is not correct. It should somehow show that the latest version in Git is not active. Problem could be because version of collection hub is updated but actual collection is same?
./kabanero list

Kabanero Instance Collections	Version	Status
-----------------------------	-------	------
java-ee				0.1.1	active
java-microprofile		0.2.19	active
java-spring-boot2		0.3.16	active
nodejs				0.2.6	active
nodejs-express			0.2.8	active
nodejs-loopback			0.1.6	active

GitHub Curated Collections	Version
--------------------------	-------
java-ee				0.1.1
java-microprofile		0.2.19
java-spring-boot2		0.3.16
nodejs				0.2.6
nodejs-express			0.2.8
nodejs-loopback			0.1.6

./kabanero sync
kabanero instance collections is already synchronized with the github curated collections

From the operator perspective, the issue here is that there are files like ._deploy-task.yaml in one of the pipeline zips in the java-microprofile collection (note the leading dot and underscore characters).  These files do not have entries in the manifest.yaml (should have a SHA256 in there), and also, they are not valid yaml files, they look like binary data.  The operator should somehow put the error from the log ("File ./._deploy-task.yaml was found in the archive, but not in the manifest.yaml") into the collection status, so the user can see what is wrong without going to the kabanero-operator log.
A second issue should be opened to resolve the CLI output.  I am not sure if the collection version is the same (old/new), but it would be nice if the CLI could show somehow that there is a problem.  We may need to brainstorm about how to do this - from the operator's perspective, there is a valid version of the java-microprofile collection active... and therefore the CLI may be showing the right thing.  But then again, there is a (newer?) version of the collection that is not active yet, and will probably replace the currently active version.

Opened CLI issue: https://github.com/kabanero-io/kabanero-command-line/issues/141

A second issue should be opened to resolve the CLI output. I am not sure if the collection version is the same (old/new), but it would be nice if the CLI could show somehow that there is a problem. We may need to brainstorm about how to do this - from the operator's perspective, there is a valid version of the java-microprofile collection active... and therefore the CLI may be showing the right thing. But then again, there is a (newer?) version of the collection that is not active yet, and will probably replace the currently active version.

updated kabanero-io/kabanero-command-line#141

The collection Object in the example at the top for the one that has an issue does not show the subfield status under Status, e.g.:
should be:
status:
  activeLocation: >-
    https://github.com/mtamboli/collections/releases/download/v0.3.5/kabanero-index.yaml
  activePipelines:
  status: inactive

RE:
``
@davco01a I think this is not correct. It should somehow show that the latest version in Git is not active. Problem could be because version of collection hub is updated but actual collection is same?

The CLI Service basis whether something is active or not based on `status->status` if the operator hasn't made that current we cannot reflect it in the CLI

Please try again at 0.4.0

Fixing the problem with the error message not displaying on the Kabanero CR instance for v.0.5.0.

The operator is fixed in master and should be included in Kabanero release 0.5.0.  The CLI issue is still open.  I am closing the operator issue (this issue).


feat: a couple of UI improvements

switch a couple of Font Awesome icons to their Material Design equivalents
center icons in FloatingButton
use the system font stack for the list views from and subject
calmer color for list view card border bottom and from
adjust header height
add Spinner component and use it for "Loading mail…" and "Fetching message details…" loading messages
a couple minor icon whitespace/margin and positioning fixes

Ah dang, gimme a sec…


Mushroom Way Randomized Chest Refills when Re-entering

Emulator: Snes9x Snes9x v1.59.2 for Windows.
Flags (paste flag string if available): Ks R7k Cspjl -palette Tc4k M2 Sb4 Edfsa! Bmc Qsba! X3 -noexp P1 Nbm Gsmke -fakeout D1s
Description of problem: The chest in Mushroom Way which usually contains a healing mushroom can be randomized and resets back to full when you re-enter the area. I don't know if this behaviour is normal for the base game, but you can get as many of whatever appears in there in the randomizer as you want.

This is fixed in the most recent update.


Mrc-5475 Update Permissions

This PR updates permissions as per discussions with Rich and Emma previously. The following is done

Removed packet.push and added outpack.read and outpack.write ... These will secure the endpoints /outpack
updated UI add permission so only if permission is packet.read then can add scope

Testing
login with super user and create a new basic user.

go to user manage and update permissions on basic user... see that scope is disabled and only is enabled if permission is packet.read. Also when switching to something not packet.read , the scope is global
With basic users bearer token and no permissions  hit the endpoint http://localhost:8080/outpack/ GET and POST. You should get 401

Tiny subjective comment on the UI, not related to this ticket. The scope radios are still quite prominent (although disabled) when a global permission is selected. I think it might be better to either remove the radios entirely, or fade them more (the text is still black when disabled) to avoid confusion.

Good idea fully agree. Have made it fade more. chose that over fully removing to avoid CLS


explosm.net enhancer writes additional src into body

This is on master with content grabber enabled

IMHO it's intentionally: c7085c4a533990f39eec139e6bfa70a885fbcd78.
If you don't agree with the change, feel free to add the author of the mention commit to this issue and discuss about the reason for this change.


Visualizer shader code doesn't seem to support #includes

Description
We have complex code to pack and unpack our GBuffer data, and it would be very useful to include the packing code from our engine directly.
However, the visualizers don't seem to support #includes.
For example, If I add this line in the visualizer HLSL file:
#include "C:\Users\name\AppData\Roaming\qrenderdoc\GBufferAccess.hlsl"
I get the following error:
// Can't find file C:\Users\name\AppData\Roaming\qrenderdoc\GBufferAccess.hlsl
Even though I know the file exists.
Steps to reproduce
Add an #include preprocessor instruction in a visualizer shader, inside RenderDoc's visualizer editor, the click "Refresh".
RenderDoc will remove the #include code and replace it with the error in a comment.
Environment

RenderDoc version: 1.13
Operating System: Windows 10 20H2
Graphics API: DirectX
NVIDIA GeForce GTX 1070, driver <IP_ADDRESS>71

That commit adds include handling for custom visualisation shaders. I also set it up so that #include <foo> system includes will search the places where custom visualisation shaders are searched for. This might not be useful if the shader you're writing is next to the include, but could be useful if you have e.g a custom shader stored in your local directory and want to reference a project/shared directory for utilities like this.

Well that was quick!
Thanks for the update! :-)


Fixed #117, Typo in AddressAliasTransaction and MosaicAliasTransactio…

Issue: #117
Fixed typo in AddressAliasTransaction and MosaicAliasTransaction create method's doc

Pull Request Test Coverage Report for Build 323

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.711%

Totals

Change from base Build 320:
0.0%

Covered Lines:
1504

Relevant Lines:
1773

💛  - Coveralls

Pull Request Test Coverage Report for Build 323

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.711%

Totals

Change from base Build 320:
0.0%

Covered Lines:
1504

Relevant Lines:
1773

💛  - Coveralls

Pull Request Test Coverage Report for Build 323

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.711%

Totals

Change from base Build 320:
0.0%

Covered Lines:
1504

Relevant Lines:
1773

💛  - Coveralls

duplicates of https://github.com/nemtech/nem2-sdk-typescript-javascript/pull/116
and https://github.com/nemtech/nem2-sdk-typescript-javascript/pull/115#pullrequestreview-225441541
?

duplicates of #116
and #115 (review)
?

didn't see that one, but this one has fixed more doc issues I think.


[KYUUBI #5035] Spark engine session page display session end time and duration

Why are the changes needed?
close #5035
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[x] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Any screenshots for comparing the changes?

Any screenshots for comparing the changes?
ok，like this

Codecov Report

Merging #5038 (c68fd65) into master (e36d5d3) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #5038   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         563     563
  Lines       31176   31188   +12
  Branches     4070    4072    +2
======================================
- Misses      31176   31188   +12

Impacted Files
Coverage Δ

.../scala/org/apache/spark/ui/EngineSessionPage.scala
0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

How about changed to separated lines for connection details and the statistics.

          User {sessionStat.username},
          IP {sessionStat.ip},
          Server {sessionStat.serverIp},

 ++

          Session created at {formatDate(sessionStat.startTime)},
          if (sessionStat.endTime > 0) {
          s"""
             | ended at ${formatDate(sessionStat.endTime)},
             | after ${formatDuration(sessionStat.duration)}.
             |""".stripMargin
        }
          Total run {sessionStat.totalOperations} SQL

 ++

Would you like to update the screenshots in the description? And I think this PR is good to go.  @lsm1

Would you like to update the screenshots in the description? And I think this PR is good to go. @lsm1

ok，done

Thanks, merged to master.


Not possible to access some of the palette on iOS

microbit.org-ticket: 1251
Using the new PXT editor, which I assume is the recommended editor to use in conjunction with the iPhone/iPad micro:bit app, it's not possible to scroll the block list in the mobile safari browser, so those block menu items that don't fit on screen can't be used. This is probably an issue with the iOS browser, since I've used other web interfaces that are AJAX based that have panes that can't be scrolled, but it does present a real problem for iPhone users in this case.

This looks like a duplicate of https://github.com/Microsoft/pxt/issues/1828

Yes duplicate of #1828

So, 1828 is a P2, and 1909 is a P1??
Does it make sense to close one of these down and work through the issue on a single ticket do you think??

Yes please, this issue is already closed from our end.


Bugfix in audio mixer + added Master Channel

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix: Handling of audio channels data
Feature: Add support for Master Channel

Breaking change: I renamed the setAudioChannelXX methods to setAudioMixerInputXXX so that they will better harmonize with the other audio commands (Input, Master, Monitor (not implemented yet) etc..)

Note: I never got the followFadeToBlack to work (ref: https://github.com/LibAtem/LibAtem/blob/master/LibAtem/Commands/Audio/AudioMixerMasterSetCommand.cs).
But the master level work at least (tested on a Television Studio)

I've confirmed that this PR works with my Atem Television Studio HD. I had to push a small fix to the master command as that didn't set the flag on the master command, instead it always set it to 1, causing it to write gain every time instead of the appropriate properties. Now that this is fixed fadeToBlack works as well.


feat(#17): Add Code Quality Protection

Add code quality protection: qulice, jtcop, jacoco
Closes: #17.

History:

feat(#17): add javadocs, package-info, jacoco, qulice
feat(#17): fix all the qulice suggestions
feat(#17): add tests for RandomJavaClass
feat(#17): set 80% jacoco limits

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here


Tutorials in Linux ARM64 k8s fail

Expected Behavior

There are multiple issues with the tutorials:

Running through the tutorials with the proper packages and programs installed should yield a successful run. However, there is an issue present when running tests in kubernetes that rely on a redis statestore (explained more below)
The pub-sub tutorial requires dotnet to be installed but the README does not list it as required,
The tutorials do not wait for dapr to fully initialize and continue on when a "HEALTHY" status of "False" is present on dapr

Actual Behavior

A failed run occurs when running any of the tutorials that require a redis statestore due to the fact that redis is not started when dapr is deployed to a kubernetes cluster.
Steps to Reproduce the Problem
Problem 1: Redis not being deployed in the cluster

Install the required programs listed in the various README files from the tutorials.
Start docker sudo dockerd
Create a cluster (minikube was used in the discovery of this issue and the following command was used: minikube start)
Initialize dapr in the cluster: dapr init -k --runtime-version 1.9.0-rc.3
Run a tutorial that requires redis. For this example the "hello-kubernetes" tutorial was used cd quickstarts/tutorials/hello-kubernetes; make validate
Observe the failure

Problem 3: False status for "HEALTHY" on dapr

Start docker sudo dockerd
Create a cluster (minikube was used in the discovery of this issue and the following command was used: minikube start)
Initialize dapr in the cluster: dapr init -k --runtime-version 1.9.0-rc.3
Immediately start one of the tutorials and notice that the "HEALTHY" status is "False" yet the "Step: Check dapr status" still passes

Here's a link on how to setup redis: https://docs.dapr.io/getting-started/tutorials/configure-state-pubsub/#step-1-create-a-redis-store

@RyanLettieri Will you pick up this issue?

We should have a valid automation for ARM64 too.

Per #791 I'd like to understand who needs this and why.  It's a fairly heavy lift, and I've seen no hard asks. @artursouza @msfussell

@artursouza - Can we close this issue?

Has this been fixed? M1 Mac has ARM64 architecture, so this is a way to make sure QuickStarts work on those.

We actually test Mac M1/apple silicon as a part of quickstarts release.  This particular test has never in my knowledge helped us find issues for Mac's ARM.  Also this goes steps further to be a linux arm + k8s scenario.  I just don't see this as a priority.  if you'd like to contribute it, that's cool.

Close this?
dapr init -k --dev installs bitnami/redis - https://github.com/dapr/cli/pull/1333
and arm64 was added to bitnami/redis - https://github.com/bitnami/charts/issues/7305


Remote SSH from different clients "bricks" the target device

Does this issue occur when all extensions are disabled?: Yes/No

Client (number 2):
Version: 1.90.0-insider (user setup)
Commit: 816c6f7d7bc4da9796cd19ac6b122b6e26f50d7f
Date: 2024-05-03T17:55:38.086Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.22631
Target:
ubuntu 22 VM running under the latest proxmox
Steps to Reproduce:

Happily use remote SSH from laptop to a local ubuntu box, allow the laptop to fall asleep when put on the charger
Switch to desktop and Remote SSH into the same target - get ssh errors
Order of devices doesn't seem to matter, and a clean shutdown of vscode before swapping might not reproduce this? I need to gather more evidence on the latter

OK I know (think?) this one isn't fully vscode's fault, but it has to be the first place to start the investigation I suppose, and I assume there would be the right set of experts to tell me what logs/where to begin this investigation. Tackling a seemingly random set of device hangs, I think I've narrowed it down to my VSCode + RemoteSSH + multiclient workflow.
Symptoms:
Got error from ssh: spawn C:\WINDOWS\System32\Wbem\ssh.exe ENOENT
And yes, even a regular ping of this target after this responds with "Destination host unreachable", making it pretty difficult to get logs out during the "bricked" state. A hard power recycle gets everything back into a good state.
I am unable (probably due to ignorance) to reproduce this with bare ssh, probably because something the Remote SSH extension actually does is what triggers it vs the connection itself.
Any thoughts or starting points?

Please share the full log from the Remote-SSH output channel
Are you saying that when the remote is in this state, you are not able to connect with ssh from the terminal?
Is it possible that you have some extension or another process running on the remote which ends up using a lot of CPU/memory?
You might try this again with the latest VS Code Insiders because we may have also fixed some connection-related issues here, but not sure whether it would be related to what you see.

Are you saying that when the remote is in this state, you are not able to connect with ssh from the terminal?

Even more than that, it doesn't respond to ping! (which is why I'm not exactly sure what logs to give you as I would assume they need to be on disk somewhere after the hard device reboot) I could be mistaken but I don't believe the actual output window survives a vscode restart?

Is it possible that you have some extension or another process running on the remote which ends up using a lot of CPU/memory?

 I do recall running close to disk space limits due to docker, in case there is some drive-full-disaster-mode. However, given that at the time I could repro with just a couple client session switches, it doesn't seem to be the same scenario
Feel free to close out this issue as I personally am unblocked (buy just buying a dedicated server, so almost the entire VM -> CPU stack is different now), but thought I'd bring attention to this failure mode.
An actionable outcome might be some documentation or tooling to fetch relevant log files for the remote extension that are on the target device disk?

Thanks for the followup. I was looking for logs from the client when you fail to connect, but those don't seem to be helpful if you can't ssh/ping outside of vscode at all.
I can't think of any logs from the remote that would help- seems most likely that you were just running really close to resource limits


typofix - https://github.com/vlajos/misspell_fixer

@k8s-bot ok to test

Assigned to someone who can spell. @davidopp

LGTM


[WIP] Add IItemList with DefaultItemListImpl

This allows giving the ModelAdapter on initialization a different item list implementation to store and handle the items.

@eygraber well if the abstraction of the list will do some kind of sorting async and have some sort of callback after a while this implementation also needs to know about the FastAdapter and the previous item count. (in case there are many adapters) otherwise you can not properly notify the RV.Adapter about changes in the dataset


alert_handler_reverse_ping_in_deep_sleep_test.c has an interrupt handler that hangs

In #16822 I debugged a hanging interrupt handler:
Rather than triggering a test failure, the external interrupt handler in alert_handler_reverse_ping_in_deep_sleep_test.c doesn't claim the interrupt before returning so the test hangs.

Hi @drewmacrae, where is the test hanging? The test will probably take hours to run in Verilator. It currently takes 3h to run in VCS. It takes this long because the timeout parameter we are testing is hardcoded in the RTL.

I hit this on the CW310, I wrote #16903 to help debug the test. While the test was only intended to fail on some firings of the interrupt handler, it only recorded that the interrupt had occurred, so the interrupt handler was never exited and if it fired, would never be reported or allow the test to complete as a pass or a failure.

So this passed with bitstream from 482b20d350cb5b6e1243fc4a9334abb480050acb and 6ac47369d86ae7d2a207c92d3500c23197d04961 for the git hash. Are we still seeing failures? (for the CW310)

I was able to reproduce the failure. Pending fix in https://github.com/lowRISC/opentitan/pull/18205.


string representation of floats larger than 2^53 differs from other engines

Hello,
The following code behaves incorrectly (inconsistent with the standard and other engines).
ch version <IP_ADDRESS>
var nonArray=({
    length:4,
    0:42,
    2:37,
    0xf7da5000:undefined,
    0x8000000000000800:0
});
Array.prototype.sort.call(nonArray);

print(JSON.stringify(nonArray));
print("BT_FLAG");

The output is:
{"0":37,"1":42,"length":4,"9223372036854777000":0}
BT_FLAG
However, other engines' output are:
{"0":37,"1":42,"length":4,"9223372036854778000":0}
BT_FLAG
BT group
2018.6.25

Minimum repro:
print(0x8000000000000800);

Possibly a duplicate of this issue https://github.com/Microsoft/ChakraCore/issues/149


Adds experimental support for Cassandra 3

This adds the schema declaration and profile needed for Cassandra 3.
Note that Cassandra 3.9+ is needed. This means we can't use Datastax
repository anymore as they are still at the 3.0.x level. Also, the main
Apache repository doesn't have 3.9 either. This should wait until the
actual dist is released.
See https://github.com/openzipkin/zipkin/pull/1252

note: eventually, this should be patched to add tracing support, since that was one of the motivations for later versions of cassandra

finally out.

Thanks @adriancole
You're a bit quick for me.


Some of the most concerning issues

1.Will MZ be supported in the future?
2. Is there a quick test sample? It is easy to quickly know whether it is working properly.
3.Backing up raw files doesn't include backing up assets like images, right? Can the mod be manually set to use the pictures in the original file directly?

I have no plans to officially support it.
Not really, but making one should be simple enough.
It does back up assets and restores them once the mod is disabled. Don't understand the second question though.

I've already used it for mz (not fully functionally tested yet) and recommend you support it quickly as it's very simple.

Compared with MV, MZ does not have a WWW folder in the root directory after the game is packaged.
The bug mainly comes from the method of building the mod list, which fails in MZ, and the text window prompting to restart after opening the mod.

If you've made the changes to make it work, would you mind opening a PR, or sending me the modified files, once tested? I'd be more than happy to have the mod loader support MZ officially, and you'd be credited of course.

I have not modified any code snippets about www. My way to bypass this problem and test directly is to use MV to deploy the MZ project.
In MZ's system. json, the screen resolution parameter is added.

https://drive.google.com/file/d/1-2EQRLLBSJjDfKR8Xu3z5jllWMNNpSuX/view?usp=drive_link I have not modified any code snippets about "WWW" My way to bypass this problem and test directly is to use MV to deploy the MZ project. Compared to mv,in MZ's system. json, the screen resolution parameter is added.This is the change in the data structure updated by the rm publisher for mz.This is just my insignificant reminder. What I mainly want to know now is whether support for mz has been included in the plan?

Sorry for the late reply, had some things to take care of. Seems simple enough to add support for MZ, so I'll add it to the list of possible improvements. I can't promise a date or anything, but I'll keep it in mind.

I noticed that your original intention was to write a MOD framework for the nfsw game, and I noticed another interesting plug-in that allows the game to have chapter selections, which means that with your framework, modders can create new adventures.
MZ:https://github.com/snailbaron/rpg-maker-plugins/blob/main/SNBR_CustomMenu.js
MV:https://ltngames.itch.io/fenixenginemv-chapter-select
I didn't test the chapter selection for the MV.


docs: clarify table_schema

There must be an input dataframe column for every desired output table column.
The types given in table_schema must be BigQuery types (strings).

[x] closes #382
[x] tests added / passed
[x] passes nox -s blacken lint

@jimfulton Was there anything else you wanted to do for this PR? I've been using my admin privileges to merge these until we can get Kokoro setup and running.


⚠ SpeakUpConference.com has degraded performance

In 0c57c4f, SpeakUpConference.com (https://www.speakupconference.com) experienced degraded performance:

HTTP code: 200
Response time: 7931 ms

Resolved: SpeakUpConference.com performance has improved in 5f2cda8 after 11 minutes.


Support for Axios 1.3.0

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
The issue appears when the axios 1.2.3+ is explicitly installed in the project. Then, code like this isn't working:
import { HttpService } from '@nestjs/axios';
import { Injectable } from '@nestjs/common';
import { AxiosInstance } from 'axios';

@Injectable()
export class MyService {
  private http: AxiosInstance;

  constructor(private readonly httpService: HttpService) {
    this.http = httpService.axiosRef;
  }
}

The reason is that typings and structure for AxiosInstance starting from 1.2.3 and higher is different from what goes with @nestjs/axios right now.
Describe the solution you'd like
The internal dependency for Axios is 1.3.0
Teachability, documentation, adoption, migration strategy
No response
What is the motivation / use case for changing the behavior?
Typically you grab instances from Axios directly - not from sub-dependences of install packages (@nestjs/axios in this case).

this is be solved (sorta) by PR #659
but yeah, if we could make it work with axios@^1 it would be better for DX

I'm going to move axios to peerDependencies


Support environments with slash ('/') in their name

Description

Support for environments with a slash in their name, such as the Seals environments is added.
For this the name of Huggingface repositories is cleared of any slashes and the get_latest_run_id function is modified since it implicitly assumed, that the log path contains no sub-folders.
Motivation and Context

[x] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Checklist:

[x] I've read the CONTRIBUTION guide (required)
[ ] I have updated the changelog accordingly (required).
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.
[ ] I have reformatted the code using make format (required)
[ ] I have checked the codestyle using make check-codestyle and make lint (required)
[ ] I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

How should we proceed with testing this bugfix? By default the zoo does not support any seals envs.

Why not just replace the slash everywhere (but at the env creation)?
(btw, same would have to be done for load from hub)

Because that would require more changes? I see the point though. I will make a sketch and see how much effort it actually is.

Note: right now environments with slash in their name cause an extra layer in the folder hierarchy of trained models.
For example this is how a log folder looks with a normal CartPole-v1 model and a seals/CartPole-v0 model:
.
└── ppo
    ├── CartPole-v1_1
    │   ├── CartPole-v1
    │   │   ├── args.yml
    │   │   └── config.yml
    │   └── CartPole-v1.zip
    └── seals
        └── CartPole-v0_1
            └── seals
                ├── CartPole-v0
                │   ├── args.yml
                │   └── config.yml
                └── CartPole-v0.zip

This folder hierarchy is also mirrored to the huggingface model uploads.
If users want to download the models from huggingface, they need to replace the slash with the dash in the repo id but not in the file path. Example:
load_from_hub("ernestumorga/ppo-Pendulum-v1", "ppo-Pendulum-v1.zip")
load_from_hub("ernestumorga/ppo-seals-CartPole-v0", "ppo-seals/CartPole-v0.zip")

This is especially annoying, when repo id and file name is to be inferred from the environment name.
Therefore @araffin and @ernestum decided in a private discussion to introduce a helper class, that automatically converts between the "normalized" (without slash) name of an environment and the actual environment id.
The environment id (with slash) is to be used for creating the environment.
The normalized name is used when creating file paths and huggingface repo ids.
This class will be placed in the https://github.com/huggingface/huggingface_sb3 so you can use it in your project.
Example usage:
import argparse

import gym
import seals
from huggingface_sb3 import load_from_hub
from stable_baselines3 import PPO

class EnvironmentName(str):
    def __new__(cls, gym_id: str):
        n = super().__new__(cls, gym_id.replace("/", "-"))
        n._gym_id = gym_id
        return n

    @property
    def gym_id(self):
        return self._gym_id

if __name__ == '__main__':
    parser = argparse.ArgumentParser()
    parser.add_argument("--env-name", type=EnvironmentName, default="seals/CartPole-v0")
    args = parser.parse_args()

    print(args.env_name)
    print(args.env_name.gym_id)

    PPO.load(load_from_hub(f"ernestumorga/ppo-{args.env_name}", f"ppo-{args.env_name}.zip"))

    env = gym.make(args.env_name.gym_id)

I implemented the above mentioned changes. I also had to mostly reimplement the get_{hf}_trained_models utility.
Would you have a look again @araffin?
As you see, test_enjoy::test_trained_agents fails for the Pendulum-v0 environments.
This is due to a bug in the trained algorithms submodule.
The pendulum models are stored in a folder named Pendulum-v1_1 but when you look into the metadata, it shows that it actually was trained with Pendulum-v0 (metadata can be either found in 0.monitor.csv or in config.yml).
Why the tests pass for python v3.8 and v3.9 and not for v3.7? I have no idea!

I think the PR is ready for merging. Unclear why some of the tests still fail. @araffin do you have a hint for me?

I think the PR is ready for merging. Unclear why some of the tests still fail. @araffin do you have a hint for me?

Looking at the tests, you are somehow trying to download https://huggingface.co/sb3/sac-Pendulum-v0, but it doesn't exist.
That's what I meant by updating the pre-trained agents, currently I think there are some inconsistencies between env_id reported and the one used to train them.

@ernestum I did all the fixes normally, should be able to merge soon ;)
Please test it on your side too.

I did test it. We cam merge :tada:


Optimization: remove array_replace_recursive calls in setConfig in module

Instead of using array_replace_recursive to set all the defaults every time the module loads should switch the code to use the Module::getSetting() and related functions ie. getRegistrationSetting()
So in the controller you would use
$this->module->getSocialSetting('enabled');

This way the defaults are only loaded when needed.
Or we could remove the getSocialSettings and variable from the module and make components out of all the settings and attach them to the user component.
Yii::$app->user->social->enabled;

This way components and defaults are only set when needed.

Sure go ahead. I have pushed updates for social auth.

Sure go ahead. I have pushed updates for social auth in #40.
Thinking ahead... this now needs some test cases (codeception or similar) for ensuring changes do not break.

The social auth is broke right now.

Okay never mind I see you changed it.

Yes social auth has been redone by me. It should work - need to add all the Auth clients (have done for Google, Facebook and Twitter).
Following needs to be noted and done:

Removing array_replace_recursive would adversely impact many code areas including defaults that are used in views, widgets as well. Need to be really careful in doing this.
Testing is important from here. Would suggest if you can help build test cases in a new folder tests to test each of these. I can help add to the same as well.


V4L grabber

Add a frame grabber based on Video For Linux (V4L)

Got my hands on a Fushicai easycap device to feed my sources through to Hyperion on my Pi2 with OSMC, and I'm at a loss on how to fix one dangling issue, which was glossed over in this discussion and I'm looking for some help.  The brightness of black areas on the LEDs are much higher when using the v4l2 grabber device than it is when using the framegrabber and kodi/xbmc.  The screen grabs I get all appear to be balanced brightness wise, black's register at black using the eye dropper in Photoshop for instance. Even if I feed a solid black screen I get a pretty bright (maybe 20%) always on LED glow, the same black screen through Kodi comes out black.  Is there anything specifically I should be adjusting in my config to fix this?

RaspberryPi 2, Linux osmc 4.1.3-2-osmc, easycap fushicai usbtv007, ws2801, HDMI2AV.
Lights work great while playing a video from within OSMC. Nada when trying to capture HDMI externally. I've searched the web far and wide, watched greatscott numerous times, and I just can't get a decent (as in even close,) screen capture. All I get is black/grey with a few green lines. I've rebuilt my SD image three times on three different cards. Same results, three times.
Currently, I'm trying to debug my screen capture. Should the HDMI out of the pi show the OSMC GUI or what's being captured on the easycap? (I'm seeing the OSMC interface.)
Most of the support on this seems to point to an old raspbmc build. Has anyone got it working with my setup? Thanks in advance for any support on getting past this. I want to solve this and move on to new projects. :)

ok, got it working. for some reason, i needed to do this, hyperion-v4l2 --width 720 --height 576 --screenshot, before I could use, hyperion-v4l2  --screenshot. The latter would just hang until I did the former then both would work. go figure. The only (current) issue I have is that crop doesn't work for me no matter what the setting. The screen cap stays the same. It's not a huge deal, but I prefer when commands do what they're advertised to do. It's probably something I'm doing wrong.
Advice to those struggling. Simplify. I finally broke it up all into pieces and verified them one at a time. I validated my easycap while hooked to a mac, then plugged an old playstation which only had composite out into the cap. I tweaked things at each step and finally arrived at a working ambilight. frustrating, yes, but well worth the struggle. Thanks Hyperion dev team. Very cool code.

@tvdzwan can be closed?

yes, thanks!

On Feb 27, 2016, at 6:25 PM, tpmodding<EMAIL_ADDRESS>wrote:
@tvdzwan https://github.com/tvdzwan can be closed?
—
Reply to this email directly or view it on GitHub https://github.com/tvdzwan/hyperion/issues/12#issuecomment-189766151.

I'm just reporting, that there is still an issue with the screenshot-function. In my case the STK1160 / SAA7113 will not produce a screenshot but just hangs on, doing nothin. Tried several combinations of width/height and PAL/NTSC. The HDMI2AV-Converter seems to work, when i connect it to my TV.
Beeing a newbe to linux i'm just guessing that V4L2 itself became faulty within a recent update or somethin like that.
gmesg tells me this:
stk1160: cannot alloc 196608 bytes for tx[10] buffer
http://easycapexpertti.mybisi.com/pages/drivers
is offering updates, but i was not able to install them.
mplayer gave me some green rubbish when running via SSH....
and when startet via XRDP, it simply killed the session.
i sat the whole evening at this, trying to get it working but its 04:21 now and i'm tired as hell. i think, i just order a utv007 at lightberry.eu as its obviously known to be working, so consider this just FYI.
If anybody wants i can share my so-far-maybe-useless-experience though...

stk1160 is not recommended, as it throws more errors than just your reported.
You could try with Raspbian wheezy, jessie don´t like it

it is more a firmware problem than a problem with hyperion...
@bimsarck uses a own patch (hope i am right) which works very nice with stk
you can look here for his "solution" but its german
http://www.forum-raspberrypi.de/Thread-hyperion-openelec-mit-automatisierter-ambilight-quellenumschaltung-milhouse-31-10-15-2

@brindosch : thats not completely correct.
I own a STK1160 and a Fushicai grabber and on jessie the fushicai is really unstable while the STK runs for more then 4 month now without one single problem (no freeze, no stop, no problem at all).

That´s interesting, maybe mixed revisions?

@tpmodding thank you, i'll have a look.


system clock problem on NRF52 boards

I'm running a multi-sensor application on the pca20020 (Thingy:52), with a periodic display of data to UART.  I've driven the display both in a loop with a k_sleep, and with a k_timer.  In both cases, the display stops after eight and a half minutes.  This happens to correspond to the 24-bit wraparound of a Nordic RTC running at 32 KiHz (8:32:00) .  Which is suspicious.
Display of the sensor data, driven by interrupts, continues.
May be related to #9904 and/or PR #10556.

More information that may be relevant:

An application that has just the periodic display code gets past 8:32:00 with no difficulties.
In the failing application there are sensor triggers at 1 Hz, 7 Hz, and 10 Hz, all using work queues, all producing UART output, so there's a lot of interruption going on.
Letting the application run I get periodic additional output (which displays system uptime as HH:MM:SS.mmm) that indicates the system clock is not advancing at a constant rate: I get output that's supposed to be every 10 s anywhere from a couple minutes to over an hour between each timestamp.

I have been trying to get OpenThread working on an nRF52840 dongle in the last days (I actually have a few pending patches to submit for it), and I have encountered this issue. Basically the network stops working after some time, but a few things like USB, and shell keep running. The other hand a simple thread toggling a led like in the blinky sample also stops executing at the same time the network stops working.
I have first thought the problem was more or less random, but I have just checked the logs, and they always stop around 8:32:00.
I guess PR #11627 might be (at least partially) a workaround for the same issue.

I don't think #11627 is due to the same issue, though there may be another clock issue that causes it (I'm not at all convinced k_busy_wait() being wildly inaccurate is isolated to Nordic hardware; that's just what I use).  Before reporting I tried reverting that patch and there was no change.  There's no direct evidence that the system clock is running at the wrong rate, just that it doesn't handle overflow of the underlying timer correctly.
(NB: Original report and comment edited to replace 8:32:00 with 8:32.000: the problem does not occur eight hours in, but eight minutes in.)

Yes, in confirm that in my case, the problem happens in around 8 minutes, not 8 hours.

In my case CONFIG_TICKLESS_KERNEL=n is enough to get the network working more than 8 minutes and 32 seconds. I have a board still answering to ping after more than 25 minutes.


MINOR: Update documentation for 0.10.1 release

LGTM

We want this in trunk too, right? Also, seems like this was merged, so the PR should be closed (non-trunk PRs are not closed automatically).

Shall we close this?

Is this still valid? If not could you close this PR?


Upgrade nix to 0.25

Upgrade to the latest nix version 0.25.
I've opened a similar PR for serialport: https://github.com/serialport/serialport-rs/pull/67.
Therefore we should update our serialport version here as soon as serialport merges and releases the nix update to avoid multiple nix versions in projects using mio-serial.

fyi: the serialport-rs PR was merged (https://github.com/serialport/serialport-rs/commit/536e1a51ae72c4ce07672e2cb295f7a366080d21).
Any feedback on this PR?

I'll try to find time this week for a tokio-serial, and mio-serial release. Thanks for the PR, sorry for the slow response.

I'll try to find time this week for a tokio-serial, and mio-serial release. Thanks for the PR, sorry for the slow response.

Great. Thanks. No problem, just wanted to give a friendly reminder :wink:


Not every prop of LanguageEngagement is captured in a changeset

When a user creates a changeset on a Project with an existing language engagement and edits date fields, the date field edits are not applied to the changeset and are instead applied directly to the engagement.
Probably should double check other props to make sure that they're captured, too.

I think the problem is around here  somewhere. ChangesetId is never set or identified.


About finetune model

Thanks for your excellent eork!I have a problem with finetuning the model("first stage.pt").When I train with the vanilla SVD model,I can get the following 2 model weights."mp_rank_00_model_states.pt" has the same size as "first stage.pt",but I cannot get the "zero_pp_rank_0_mp_rank_00_optim_states.pt" matching the "first stage.pt".
Therefore,if I want to finetune the model with more datasets,I replace "first stage.pt" with "mp_rank_00_model_states.pt",but how to get the "zero_pp_rank_0_mp_rank_00_optim_states.pt"?

I solve it.Just the first weight is OK.

I solve it.Just the first weight is OK.

Hi, so if I fine-tuned the model, which one should I use for inference? or continue fituning? Thank you!

I solve it.Just the first weight is OK.

Hi, so if I fine-tuned the model, which one should I use for inference? or continue fituning? Thank you!

Based on my experience, it's the first one.

I also have managed it. Thanks for your reply!
---- Replied Message ----
| From | wenqiang @.> |
| Date | 11/28/2024 15:30 |
| To | yanghb22-fdu/Hi3D-Official @.> |
| Cc | 2hiTee @.>,
Comment @.> |
| Subject | Re: [yanghb22-fdu/Hi3D-Official] About finetune model (Issue #21) |
I solve it.Just the first weight is OK.
Hi, so if I fine-tuned the model, which one should I use for inference? or continue fituning? Thank you!
Based on my experience, it's the first one.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


Implement more rigorous testing

We should implement functional and unit testing for Mayday.

Unit Testing

[ ] Invalid command parsing
[ ] Symbolic link naming

Functional

[ ] File does not exist
[ ] File isn't readable
[ ] Permissions are wrong

As we progress in adding features (Object storage upload, etc) we should strive for 100% test coverage.

#27 begins a little bit of this, mainly by updating the go requirement, updating to vendoring, that kind of thing, as well as adding a single test (mostly so I know how to write go tests).
Can you explain more about what we're looking for the tests to do? For instance, for "symbolic link naming", is that just making sure that if I say to run "tar -xzf foo.tar.gz" and make a link called "foo", that the link foo is made to mayday_commands/tar_-xzf_foo.tar.gz ?

Ok, I rewrote Mayday. See #29. It's a heck of a lot more testable, but there are certain aspects I'm not sure of.


Fixes Todo NodeJs API Lint issues

Resolves #1913
A recent change caused linting issues on the NPM build script that is called within the azd package step.  This change resolves the lint issues and allows azd to package the app without any issues.

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/1915
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/1915

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks
Remote: azure-samples-staging
Branch: pr/1915
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/1915

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/1915
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/1915

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/1915
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/1915

View Changes | Compare Changes

Project: todo-nodejs-mongo-terraform
Remote: azure-samples-staging
Branch: pr/1915
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/1915

View Changes | Compare Changes


board: arm: google_kukui: Add a sample for kukui

It is useful to use kukui with a shell to test out its features., Add a
sample for this.
Signed-off-by: Simon Glass<EMAIL_ADDRESS>

Is it WIP? Where is the essential thing that this sample produces for this board? Which board would not work with it?

Is it WIP? Where is the essential thing that this sample produces for this board? Which board would not work with it?
And why not just use samples/subsys/shell/shell_module?

It is WIP but it is a start. With this it is possible to try things out as development continues. I was told not to add shell support to a board.
The shell_module example does not enable shells for all commands though.

The shell_module example does not enable shells for all commands though.

Is this something we could fix by having a boards/google_kukui.conf in that sample?

Possibly. This is intended to be an EC (Embedded Controller for laptop/tablet) implementation. I am happy to put it anywhere that suits since we can always move it later.

Possibly. This is intended to be an EC (Embedded Controller for laptop/tablet) implementation. I am happy to put it anywhere that suits since we can always move it later.

I see, so this is a bit more than a sample, you intend to have a full implementation of an EC in-tree. I am not opposed to this, but would like to hear other opinions.
BTW, this is a new sample so it cannot go in before 2.3.0 is tagged unless you label it as TSC and bring it to the TSC meeting.

I am not sure about 'full implementation' right now, or where exactly it might end up. But definitely I think adding the drivers and seeing where we end up.
There is no urgency with this so it can wait until after the release.

Can I get another look at this one please?


SIGHUP signal will clear vanguards

We need to watch the SIGNAL event for the RELOAD signal, and reapply vanguards on the event of it. Otherwise, when Tor gets HUP signals, we'll lose vanguards.

Does vanguards continue to work in the background when we close terminal?

Does vanguards continue to work in the background when we close terminal?

No. Your two options are to use a systemd service, like the debian/testing package does: https://salsa.debian.org/pkg-privacy-team/vanguards/blob/master/debian/vanguards.service
or use --oneshot_vanguards from an hourly cron script (which only provides you with the path selection defenses, not the dropped cell ones).

No. Your two options are to use a systemd service, like the debian/testing package does: https://salsa.debian.org/pkg-privacy-team/vanguards/blob/master/debian/vanguards.service

Thanks for this.  How can I use this with vanguards?

No. Your two options are to use a systemd service, like the debian/testing package does: https://salsa.debian.org/pkg-privacy-team/vanguards/blob/master/debian/vanguards.service

Thanks for this. How can I use this with vanguards?

There are vanguards packages in debian/testing which should become the new debian/stable very soon. They should also be available in debian/backports very shortly (for debian 9.0 users).
This issue is fixed in vanguards 0.3.1. If you have packaging issues, file another ticket.


Accept runtime config in either JSON or TOML

Many environments have better JSON tooling than TOML. To ease integration, accept either format for runtime config.
This chooses the format as follows:

If the extension is .toml, parse as TOML
If the extension is .json, parse as JSON
If the first non-whitespace character is {, parse as JSON (never valid TOML)
Otherwise, parse as TOML (compatible with current behavior)

GitHub mobile is too easy to fat-finger, sorry!
(Yay I am excited to purge a bunch of SpinKube code at some point)


Change build tags.

Change build tags currently used to separate tests from
unit,!integration to only unit

@a-urth Was this done as part of #380 ?

No, it was only partially done since anyway i needed to fix errors in some test files.
Its still to be done for all of the files.


Feature/atrayano/#169 add datalake

This PR adds a DataLake implementation in GEOS. It is zero-diff when the DataLake feature is not exercised (default), otherwise expect non-zero differences

https://github.com/GEOS-ESM/GEOSgcm_GridComp/issues/169#issuecomment-1069339597

@atrayano, @sdrabenh,
You may find following instructions to generate a mask for the Great Lakes and Caspian sea and (binary) SST and Sea Ice concentration helpful.
Steps to generate a lake mask and data for a given date
In the following example, date is set to: 2022/01/01

Set modules: source GEOSgcm/@env/g5_modules

Generate an input file input.txt

One can find gen_input.csh at:GEOSgcm/src/Shared/@GMAO_Shared/GEOS_Util/pre/NSIDC-OSTIA_SST-ICE_blend/

Change year 2020 to 2022, i.e., line:
https://github.com/GEOS-ESM/GMAO_Shared/blob/5b864daa4e41df596e4b385cd61da57e0f69f97b/GEOS_Util/pre/NSIDC-OSTIA_SST-ICE_blend/gen_input.csh#L65
to:set reynolds_data_loc = '/gpfsm/dnb42/projects/p17/production/GEOS5odas-5.00/RC/OBS/REYN/2022/'

Use gen_input.csh 2022 1 1 OSTIA. Attached is the generated input.txt if you do not run gen_input.csh

Generate data and lake mask:
GEOSgcm/install/bin/lake_sst_sic_EIGTHdeg.x input.txt

All goes okay, you should get:
Data over Great Lakes and Caspian Sea
Processing SST and ICE data from: 20220101...To... 20220102
...Finished!

and three binary files: mask.bin, Ostia_ice_20220101.bin  Ostia_sst_20220101.bin

Note that these three binary files are of the same size, each contains a two-dimensional field (mask, sst or sea ice concentration),
at a regular 1/8-deg (lat-lon) grid (date-line edge, pole edge). One can use plot_bcs.py to plot:
plot_bcs.py -data_path /discover/nobackup/sakella/TMP/nn -year 2022 -month 1 -day 1

input.txt

@atrayano just checking on your timetable for generating the new raster/tile files reverting the lakes to lakes? Obviously I can't test anything further until that happens.

Scott,
Thanks for your e-mail (this was a perfect reminder!).
I am planning to generate these files myself and test the PR myself first, before I pass it to you for further testing. Hopefully this won’t take too long, and I’ll be ready sometime this week…
Atanas
From: Scott Rabenhorst @.>
Reply-To: GEOS-ESM/GEOSgcm_GridComp @.>
Date: Tuesday, March 22, 2022 at 11:01 AM
To: GEOS-ESM/GEOSgcm_GridComp @.>
Cc: "Trayanov, Atanas L. (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC]" @.>, Mention @.***>
Subject: [EXTERNAL] Re: [GEOS-ESM/GEOSgcm_GridComp] Feature/atrayano/#169 add datalake (PR #557)
@atrayanohttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fatrayano&data=04|01|Atanas.L.Trayanov%40nasa.gov|a65724589752482fbf0808da0c14d079|7005d45845be48ae8140d43da96dd17b|0|0|637835580778986921|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=n69pL3Uq6Cd676pEWF57WmjdkI1YWkBNMqT4sE7V2JA%3D&reserved=0 just checking on your timetable for generating the new raster/tile files reverting the lakes to lakes? Obviously I can't test anything further until that happens.
—
Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F557%23issuecomment-1075292645&data=04|01|Atanas.L.Trayanov%40nasa.gov|a65724589752482fbf0808da0c14d079|7005d45845be48ae8140d43da96dd17b|0|0|637835580778986921|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ajz%2BtEdIBeQaSEEqnAWmnaexpx7Vb7tG5DNZ4AiUBZg%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL6ZCVL2U5VEVAXTXDF5IDLVBHODTANCNFSM5PVCEP4Q&data=04|01|Atanas.L.Trayanov%40nasa.gov|a65724589752482fbf0808da0c14d079|7005d45845be48ae8140d43da96dd17b|0|0|637835580778986921|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Nr%2BxACefGyO5ckzYHZlVZSm%2FKjR0Az%2FizuZ1lupOSQM%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Scott, Thanks for your e-mail (this was a perfect reminder!). I am planning to generate these files myself and test the PR myself first, before I pass it to you for further testing. Hopefully this won’t take too long, and I’ll be ready sometime this week… Atanas

Great, thanks. I just wanted to have a general idea of the timing. Sounds good.

@sdrabenh, @atrayano please see above for TICE that needs to be handles just as SST.

@sanAkel The changes you requested have been committed and pushed. Could you, pease, review them. I tested them with c12, and generating data for Scott to test them with c180 and c30

@sanAkel The changes you requested have been committed and pushed. Could you, pease, review them. I tested them with c12, and generating data for Scott to test them with c180 and c360

Thanks @atrayano, will take a look at it later.
As for @sdrabenh's testing, you are referring to test with coupled or uncoupled model configuration? Latter may need that raster/tile file that reverts Great Lakes and Caspain to being lakes again.

This up to him. He indicated desire to test both, but for now he has asked me for 2 different resolutions ( c180 and c360) uncoupled

This is up to him. He indicated desire to test both, but for now he has asked me for 2 different resolutions ( c180 and c360) uncoupled. Of course, my new tile file reflects the reverted "new" lakes

Thanks @atrayano. @sanAkel these are for the uncoupled tests just to test if everything is behaving as expected and within roundoff. However, when we meet this week I'd like to discuss what you recommend for a coupled test.

Pinging @sanAkel to review the PR

@tclune, @atrayano I just looked at this PR with @sdrabenh.
The code seems to have many bugs and superfluous logic.
We recommend this PR be closed, code be cleanly rewritten for our consideration.
Thank you.


getting image color profile

Hi.
After processing RAW image with any of ColorSpace values how can I save image data with icc profile? Somehow RAW data has been converted so it would be nice to have such color profile data available to save into let's say JPEG file otherwise images are being displayed incorrectly.

rawpy only outputs RGB pixel data. How you save that data to a file is out of scope for rawpy at this point. To include the icc profile you'd have to find a library or tool that can write EXIF metadata to a JPEG file for example. Might be worth asking this question in the libraw forums.


fix of not re enabling "Use Freestyle instead" checkbox

It seems like it was originally meant to disable the controls when the use Freestyle instead checkbox is checked.
This pull request proposes the following changes:

fix of not re enabling "Use Freestyle instead" checkbox

Known issues/To do:

wrong status at startup

What? AppVeyor? Why do you not want to build my pr?

Closed because AppVeyor does not want to build it.


Check for changes in .docx source files and only convert modified files to save time

Check for file changes with st_mtime and st_size and additionally with md5 hash (hashlib).

Great idea! Any ideas on where to save those hashes? Create dotfiles?

Typical structure as stated here:
some_file.ext
some_file.ext.md5

Or maybe a json file with filename (key): md5-hash (value) to remove the amount of files in the document folder


Prepare v1.5.0 release notes

See https://gist.github.com/dmcgowan/dc3cacd6f1c6fbb5ae69d7d0e392cc35
Pending clearing the 1.5 milestone

I commented in rc.2 to mention significant changes in windows. I would like to mention it again.

Implement windowsDiff.Compare to allow outputting OCI images
Commit writable WCOW layers as read-only parent layers

It is worth to mention it in release note.

#### Project Organization
* **Merge containerd/cri codebased into containerd/containerd** [#4593](https://github.com/containerd/containerd/pull/4593)

s/codebased/codebase/

Updated

Since https://github.com/containerd/containerd/pull/5203 has been merged, this feature should be highlighted 😂

Updated to rc.3 to include feature merge, we can do final not long after


Add rough analysis on 1.1p

I am adding a couple of notebooks to show a rough LSS analysis.

Addressed in #162


refactor: have fixed number of args for RqOperator

following @aljazerzen advice in #3883 here is the follow up PR

make the number of arguments fixed. This is hard to do, since we want arrays to have a variable number of arguments and because we don't have array in the RQ. Here I would suggest:
   * to add `rq::ExprKind::Array`, https://github.com/prql/PRQL/blob/main/prqlc/prql-compiler/src/ir/rq/expr.rs#L20,
   * lower `pl::ExprKind::Array` into `rq::ExprKind::Array` here: https://github.com/prql/PRQL/blob/main/prqlc/prql-compiler/src/semantic/lowering.rs#L886
   * unpack the `rq::ExprKind::Array` in the `process_in_values` function,
   * in any other place in SQL backend, reject the `rq::ExprKind::Array` saying "unsupported feature"

   This is a bit of work, so I'm fine with merging this PR with a comment saying "TODO: instead of unpacking the array, compile it to rq::ExprKind::Array".

2 questions:

is it the right approach?
if yes what should I do with the failing test? Should I change infer_complexity_expr to return a Result in order to propagate a clean Err(Error::new(Reason::Unexpected ...)) upstream?

This test now fails
#[test]
fn array_instead_of_tuple() {
    // Particularly given this used to be our syntax, this could be clearer
    // (though we do say so in the message, which is friendly!)
    assert_display_snapshot!(compile(r###"
    from e=employees
    select [e.first_name, e.last_name]
    "###).unwrap_err(), @r###"
    Error:
       ╭─[:3:12]
       │
     3 │     select [e.first_name, e.last_name]
       │            ─────────────┬─────────────
       │                         ╰─────────────── unexpected `[this.e.first_name, this.e.last_name]`
       │
       │ Help: this is probably a 'bad type' error (we are working on that)
    ───╯
    "###);
}

since we now panic!
---- bad_error_messages::array_instead_of_tuple stdout ----
thread 'bad_error_messages::array_instead_of_tuple' panicked at 'unsupported expr kind: array', prqlc/prql-compiler/src/sql/srq/anchor.rs:570:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Yes it is

infer_complexity is trying to figure out to to materialize an array (i.e. can it appear in a GROUP BY? Can it appear in WHERE?).
In this PR, we have no plans to compile to actual SQL arrays (since they vary between dialects a lot), but just use them as a container when using std.array_contains.
This means that infer_complexity is inconsequential: we can just return the highest complexity, since this is the safest option.

Last question on the whole "filter on list of values"
Should I add an example in web/book/src/reference/stdlib/transforms/filter.md ?
I feel like it's as important as the filtering in range

Docs would be great, yes. I don't see std.in as only to be used with filtering, but to compute a boolean in general. So I would make a new page under stdlib/ and maybe link to it from filter.md.

Ok. Should I do that in this PR?

I've given you write access to this repo, merge when you think it's done.
(you might have to accept it via email)


connection failure results in segfault and cryptic error message

I'm getting the following error on the Raspberry Pi 3 with the new 0.2.0 release. After I say "Ok Google", it shows ON_CONVERSATION_TURN_STARTED. Then a few seconds after I make the query, the error shows.
(env) pi@raspberrypi:~ $ google-assistant-demo
ON_MUTED_CHANGED:
  {'is_muted': False}
ON_START_FINISHED

ON_CONVERSATION_TURN_STARTED
[2433:2444:ERROR:speech_processing_task.cc(340)] S3 connection has timed out: No data from S3
ON_ASSISTANT_ERROR:
  {'is_fatal': False}
[2433:2444:ERROR:assistant_output_handler.cc(589)] Failed with a general speech recognition error
ON_RESPONDING_STARTED:
  {'is_error_response': True}
Segmentation fault

Can you confirm that your Raspberry Pi is connected to internet, are you able to ping and curl embeddedassistant.googleapis.com ?

@proppy I got it working connecting the Raspberry Pi directly to my router with Ethernet cable or WiFi network.
I always ssh to my Raspberry Pi through a shared network on my laptop with DHCP server and so. I could install packages and also could ping and curl normally as you said but the the assistant didn't work though.

Glad you got it working.
Keeping the issue open because of the:

Segmentation fault
Cryptic error message
missleading ON_RESPONDING_STARTED event.

This is related to not having the API enabled or loosing access to it. Enabling the Google assistant api on google apis website, solves the problem.
(error code could be more explicit)


Fix slowdown on open/close tabs when the user has many profiles

Summary of the Pull Request
Just deleting an unnecessary call to _UpdateCommandsForPalette
Note: This only fixes slowdown when opening/closing a tab, but not upon first startup (we still need to call _UpdateCommandsForPalette there
References
Fixes the slowdown described in #7820 for opening and closing tabs, but doesn't improve startup time dramatically.
Validation Steps Performed
Tested with ~100 profiles in my settings file

@PankajBhojwani - will the command palette be still updated if I have it open in the tab-switch mode and create a new tab? I guess the answer is yes, but just checking.

@PankajBhojwani - will the command palette be still updated if I have it open in the tab-switch mode and create a new tab? I guess the answer is yes, but just checking.

@Don-Vito Yep, this function call was actually entirely a vestigial remnant from an earlier prototype. The tab switcher mode for the command palette uses a totally different mechanism for populating the list of tabs.

I'd suggest that you remove the Closes verbiage in the PR body, as it doesn't fully address the issue and we don't want it closed.
We need to figure our how to improve startup time.

@msftbot merge this in 4 minutes

@zadjii-msft , @PankajBhojwani  - this did regressed. Once if you had the split pane open on the tab switcher and you were added the new tab it was added to the list of the commands immediately. Now it will will be updated only on the next opening of the tab switcher.

@Don-Vito that could have also been due to #7952

@DHowett - it is certainly is. I already verified it (while merging https://github.com/microsoft/terminal/pull/7977). Sorry @PankajBhojwani :smile:

So, generally we consider the switcher to be “ephemeral”; it shouldn’t be onscreen while tabs are changing, but it shouldn’t be dangerous if it is. So long as it doesn’t crash, i’m okay with an n-1 state snapshot being on display.

So, generally we consider the switcher to be “ephemeral”; it shouldn’t be onscreen while tabs are changing, but it shouldn’t be dangerous if it is. So long as it doesn’t crash, i’m okay with an n-1 state snapshot being on display.

@DHowett - in "command palette highlighting" I worked really hard to change the highlighted text if the command name is changed in the background (e.g. when new tab is open). Can I remove it?


Concerns about the Challenge Question Connector in IS v7.0.0

Describe the issue:

The documentation [1] for the Challenge Question Connector (which had been created since IS v7.0.0 no longer includes it out of the box) does not contain comprehensive steps that someone should follow like in official documentation in previous versions of WSO2 Identity Server.
After the last step in [1], the user cannot actually navigate to the new Console and configure properties related to this connector, nor is the user shown the challenge question option when trying out the recovery flows. Instead, they have to add the following deployment.toml configuration to enable the old carbon management console (ideally these configurations should be available via the new console).
[server]
hide_menu_items = []

The user has to then login to the old carbon management console and navigate to the Resident Identity Provider > Account Management > Account recovery and then enable the "Security question based password recovery" option.
Additionally, if the user wants to force the user to answer challenge questions on login, they need to enable the "_Enable forced security questions" option. These details and steps are missing from the documentation [1]. Ideally, this information should be included to prevent any confusion regarding this feature now that it is only available as a connector.
Furthermore, it was noted that compilation errors occur in the add-security-questions.jsp page in the authenticationendpoint web app in WSO2 Identity Server v7.0.0 due to incorrect imports after moving the challenge question feature out as a connector.
<%@ page import="org.wso2.carbon.identity.recovery.model.ChallengeQuestion" %> needs to be changed to <%@ page import="org.wso2.carbon.identity.challenge.questions.recovery.model.ChallengeQuestion" %> and <%@ page import="org.wso2.carbon.identity.recovery.ui.IdentityManagementAdminClient" %> needs to change to <%@ page import="org.wso2.carbon.identity.challenge.questions.ui.IdentityManagementAdminClient" %>.
The above should also be fixed accordingly in addition to the documentation concerns.
[1] - https://github.com/wso2-extensions/identity-challenge-questions/blob/main/docs/config.md

Optional Fields
Related issues:

Suggested labels:

@asha15 Can you please validate this?

@asha15 Can you please validate this?

Sure, will check this.

Hi @sanjulamadurapperuma
The connector documentation only contains the steps [1] related to how to configure the challenge questions      connector with Identity server since it’s out of the box. As you mentioned it doesn't contain the documentations related to challenge questions feature. As an improvement we can move the challenge questions related documentation into the connector’s repository.
Since the challenge questions feature is deprecated, it was decided to support challenge questions configuration only  in the Carbon Console. If a user wants to enable this feature, they must configure it from the Carbon Console as expected. A separate issue has been created to remove the challenge questions configuration from the management console and move it to the React console in a later release [2].
If a user want to use the challenge questions feature, they should add the connector and the related configuration, following the same steps they followed in previous Identity Server versions to use the challenge questions feature.
When the connector effort was completed, the configuration to enable the resident IDP was:
[resident_identity_provider]
enable = "true"

However this configuration was later updated. We will revise the documentation to reflect the updated configuration and clarify that the connector is only supported in the Carbon Console.

Furthermore, it was noted that compilation errors occur in the add-security-questions.jsp page in the authenticationendpoint web app in WSO2 Identity Server v7.0.0 due to incorrect imports after moving the challenge question feature out as a connector.
<%@ page import="org.wso2.carbon.identity.recovery.model.ChallengeQuestion" %> needs to be changed to <%@ page import="org.wso2.carbon.identity.challenge.questions.recovery.model.ChallengeQuestion" %> and <%@ page import="org.wso2.carbon.identity.recovery.ui.IdentityManagementAdminClient" %> needs to change to <%@ page import="org.wso2.carbon.identity.challenge.questions.ui.IdentityManagementAdminClient" %>.

Your concern is valid, and the class names should be updated. Will work on the fixes.
[1] https://github.com/wso2-extensions/identity-challenge-questions/blob/main/docs/config.md
[2] https://github.com/wso2/product-is/issues/19638
Thank you!

Fixed with: https://github.com/wso2-extensions/identity-challenge-questions/pull/10, https://github.com/wso2/identity-apps/pull/6498


Auto-correct does not cache

The first time I run bundle exec rubocop is slower than the sub-sequent ones because of the awesome caching feature.
When using the auto-correct flag -a, it seems to never cache and every single run takes on average the same amount of time.
Expected behavior
Caching should also work when auto-correcting files.
Actual behavior
Every run takes consistently the same amount of time.
Steps to reproduce the problem
➤ time bundle exec rubocop -a
Inspecting 269 files
.............................................................................................................................................................................................................................................................................

269 files inspected, no offenses detected
       10.30 real         9.93 user         0.29 sys
➤ time bundle exec rubocop -a
Inspecting 269 files
.............................................................................................................................................................................................................................................................................

269 files inspected, no offenses detected
       10.18 real         9.80 user         0.29 sys
➤ time bundle exec rubocop -a
Inspecting 269 files
.............................................................................................................................................................................................................................................................................

269 files inspected, no offenses detected
       10.16 real         9.77 user         0.31 sys

Compare to:
➤ time bundle exec rubocop
Inspecting 269 files
.............................................................................................................................................................................................................................................................................

269 files inspected, no offenses detected
       10.99 real        10.54 user         0.40 sys
➤ time bundle exec rubocop
Inspecting 269 files
.............................................................................................................................................................................................................................................................................

269 files inspected, no offenses detected
        1.31 real         1.04 user         0.25 sys

RuboCop version
➤ bundle exec rubocop -V
0.49.1 (using Parser <IP_ADDRESS>, running on ruby 2.3.5 x86_64-darwin16)

Is that a reasonable request? Thanks for the awesome project! ❤

It seems good to me. But we must refactor the code for auto-correction to implement this feature.
First, we should add auto_correct to NON_CHANGING.
diff --git a/lib/rubocop/result_cache.rb b/lib/rubocop/result_cache.rb
index bd5bb85e..01c240ef 100644
--- a/lib/rubocop/result_cache.rb
+++ b/lib/rubocop/result_cache.rb
@@ -7,7 +7,7 @@ require 'etc'
 module RuboCop
   # Provides functionality for caching rubocop runs.
   class ResultCache
-    NON_CHANGING = %i[color format formatters out debug fail_level
+    NON_CHANGING = %i[color format formatters out debug fail_level auto_correct
                       cache fail_fast stdin parallel].freeze

     # Remove old files so that the cache doesn't grow too big. When the
diff --git a/lib/rubocop/runner.rb b/lib/rubocop/runner.rb
index fc405261..46506c7c 100644
--- a/lib/rubocop/runner.rb
+++ b/lib/rubocop/runner.rb
@@ -175,8 +175,6 @@ module RuboCop
         # cops related to calculating the Max parameters for Metrics cops. We
         # need to do that processing and can not use caching.
         !@options[:auto_gen_config] &&
-        # Auto-correction needs a full run. It can not use cached results.
-        !@options[:auto_correct] &&
         # We can't cache results from code which is piped in to stdin
         !@options[:stdin]
     end

But it does not work well from we just changing them.
For example
$ cat test.rb
p "a"

$ rubocop
Inspecting 1 file
C

Offenses:

test.rb:1:3: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
p "a"
  ^^^

1 file inspected, 1 offense detected

# It does not execute auto-correction!
$ rubocop -a
Inspecting 1 file
C

Offenses:

test.rb:1:3: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
p "a"
  ^^^

1 file inspected, 1 offense detected

Thanks, @pocke for the initial work on this!


Fixed input styling within tables

Fixed styling issue were inputs were squished when in a table.

Can you confirm that this also fixes all the other instances of the squished inputs? And preserves the styling for the CSTG domain names table

Can you confirm that this also fixes all the other instances of the squished inputs? And preserves the styling for the CSTG domain names table

Yes. I added some extra styling to preserve the CTSG styling. The issues seen in other places was caused by this styling on the table.


Get Things Done can't handle multiple lines

The text overflows out of the container.

Adding a PR to solve this.

Fixed in https://github.com/llaske/sugarizer/pull/742


Use chapter data in navigation

REDMINE-17300

Coverage remained the same at 99.012% when pulling cf91a18d9fe56ffe5efac6a23cef8ba2face1d53 on DanielKuhn:use-chapter-data-in-navigation into d9cd3101c5672e3c4b5758f213760045a07ff834 on codevise:master.