ShadingType 1 is unsupported

test.pdf
Configuration:

Web browser and its version: Firefox 77.0.1 (64-Bit)
Operating system and its version: Windows 10 Pro v.1909
PDF.js version: 2.5.95
Is a browser extension: No, built in to Firefox as standart PDF-viewer

Steps to reproduce the problem:

create the pdf by saving the following html code to a file and printing the output to a pdf enabling background graphics:

<!DOCTYPE html>

<html>

<head>
    <style>
        body {

            background: repeating-linear-gradient(44deg,
                    HSLA(174, 41%, 46%, 0.5),
                    HSLA(174, 41%, 46%, 0.5) 10px,
                    HSLA(174, 37%, 34%, 0.5) 10px,
                    HSLA(174, 37%, 34%, 0.5) 20px);
            height: 100vh;
            width: 100vw;
        }

    </style>
</head>

<body>
</body>

</html>

(should result in a similar file to this one)
test.pdf
2. compare to opening it with chrome-based browsers
Expected behavior: (viewed in Vivaldi Browser --> Chrome-based)

Resulted behavior: (viewed in Firefox)

console:

Looks, for all intents and purposes, like a duplicate of issue #5046 (based on the actual errors/PDF structure).

Looks, for all intents and purposes, like a duplicate of issue #5046 (based on the actual errors/PDF structure).

I've seen this issue before posting mine, but I was convinced, that this is something different.
The issue you mentioned gives the error Warning: Error: Unknown PatternType: 1, while mine is Warning: FormatError: Unsupported ShadingType: 1.
Nevertheless, even if it is related, the other issue was opened 16 years ago, pretty upsetting that this error still exists.
Why is that?

The issue you mentioned gives the error Warning: Error: Unknown PatternType: 1, while mine is Warning: FormatError: Unsupported ShadingType: 1.

The error messages has been updates since issue #5046 was opened, which should explain the differences.

the other issue was opened 16 years ago,

Note that it's opened in 2014, so rather six years ago.

Please note that it's common-place in all bug trackers to close duplicates, regardless if the original issue is resolved or not, in order to ensure that relevant discussion happens in one place.
Doing so does not constitute any judgement of the importance of the issue itself, it's simply done to keep the number of open issues more manageable.

[...] pretty upsetting that this error still exists.
Why is that?

Please keep in mind that this is an open-source project, with most people contributing in their spare time. (And the feature in question here may not be entirely straightforward to implement, and isn't that commonly used either.)

Closing since this is in fact a duplicate.


astropy's isiterable cannot be imported by lenstromy with astropy == 6.1.3

Lenstromy imports the function isiterable from astropy in lenstronomy.Cosmo.cosmo_interp.py.
This import fails when astropy version > 5, the solution is commented out in the last version on github.
I suggest requiring astropy <= 5 in requirements.txt

Closing based on #43.


grad of grad fails when ravelling is involved

Consider the following toy function:
def fun(d):
    a, b = d['a'], d['b']
    return a + 2 * b

Suppose that for compatibility reasons we are interested in working with ravelled arguments. We then set some values for d and define an equivalent function that takes as input ravelled arguments:
d = dict(a=1., b=2.)
rav_d, unravel = ravel_pytree(d)
rav_fun = lambda r: fun(unravel(r))

Let's check function value and gradient:
rav_fun(rav_d), grad(rav_fun)(rav_d)
>>> (DeviceArray(5., dtype=float32), DeviceArray([1., 2.], dtype=float32))

All good so far. If we now want to compute an element-wise gradient of the gradient function (i.e. the diagonal of the Hessian), generally we could do as follows:
vmap(grad(grad(rav_fun)))(rav_d)

If there was no ravelling involved, this would work just fine. However, in this case we get the error
>>> IndexError: tuple index out of range
Why is this the case? For functions without ravelling it does appear to work.
To reproduce the previous code, import the following:
from jax import vmap, grad
from jax.flatten_util import ravel_pytree

The issue is that grad only works for scalar-valued functions, but grad(rav_fun) is a vector-valued function.
If you want gradients of vector-valued functions, you could use vmap(grad(f)) or jacobian(f), depending on what flavor of vector gradient you're interested in.

Thanks for the reply. I am try to obtain second-order derivatives, specifically the diagonal of the Jacobian of some real-valued function, without computing nor storing the full Hessian matrix.
Any simple way to do this?

Funny, I just answered a very similar question on StackOverflow this morning: https://stackoverflow.com/q/70956578
Do you mean the diagonal of the Hessian? The Jacobian is a first-order gradient.
But no, I don't believe there is any general way to compute only the diagonal terms of a hessian or jacobian. The issue is that each entry of the diagonal depends on every value of the input, so it cannot be expressed as a straightforward vmap. For any particular function, it's possible to construct a function that will compute the diagonal elements directly.

You can compute the diagonal of the hessian using the first strategy I mentioned: vmap of grad. For example:
import jax.numpy as jnp
from jax import vmap, hessian, grad

def f(x):
  return jnp.dot(x, jnp.sin(x))

x = jnp.arange(3.0)

print(jnp.diagonal(hessian(f)(x)))
# [ 2.         0.2391336 -2.6508884]
print(vmap(grad(grad(f)))(x))
# [ 2.         0.2391336 -2.6508884]

vmap(grad(grad(f)) is exactly what I was doing in my original example, right? :)
This indeed does work for normal functions, but when I have unravel in between something goes wrong. Let me tweak a little your example to show this.
def f(c):
    a, b = c.values()
    return np.dot(a, np.sin(b))

c = dict(a=1., b=2.)
rav_c, unravel = ravel_pytree(c)
rav_f = lambda r: f(unravel(r))
vmap(grad(grad(rav_f)))(rav_c)

This gives the following error:
IndexError: tuple index out of range

I don't see why it does not work here.

Ah, thanks for the clarification.
I think it does not work here exactly because you've ravelled the pytree, and so your function no longer returns a scalar (or a pytree of scalars), so grad is not a valid transform.
Can you say more about what your expected output is? It's not clear to me from your code what exactly you are trying to compute (I think my mental interpreter raises the same error that JAX does 😁 )

Given a function f:\mathbb{R}^n \to \mathbb{R}, I'm trying to compute \text{diag}(\nabla^2 f), that is the diagonal of its Hessian matrix.
However, I define f(x) = g(unravel(x)), where g:\mathcal{X} \to \mathbb{R} is some original function that takes as input any pytree.
Since x\in\mathbb{R}^n and f(x)\in\mathbb{R}, I would expect \text{diag}(\nabla^2 f)\in\mathbb{R}^n. In principle, I don't see why this should not work?
I'm going through all of this ravelling business because when I implement algorithms that involve algebraic operations, in principle these should know nothing about pytrees; they should take arrays in inputs and spit out arrays in output.
Hence, even if I have available a function g which takes a pytree as input (e.g. a neural network, where inputs are the model parameters), I need to transform this into a function f in order to use it in combination with these algebraic algorithms.
I find the ravelling/unravelling actually the main difficulty using JAX. Perhaps you have indications here?

So it sounds like what you're looking for is this:
jnp.diagonal(jacobian(grad(rav_f))(rav_c))

but without computing the full Jacobian?
If so, I'm not aware of any general way to do this. But given a particular function, you could probably find a way to construct the calculation you need (see the stackoverflow question linked above for one example).

My first inclination is that it may be easier to do if you avoid the raveling, since the main problem here is that you're trying to construct gradients with respect to elements of arrays. But I haven't tried that.

So it sounds like what you're looking for is this:
jnp.diagonal(jacobian(grad(rav_f))(rav_c))

but without computing the full Jacobian?

Exactly, I would like to avoid full Jacobian and Hessian computation. If no ravelling is involved, you showed above that something like vmap(grad(grad(f)))(x) does the job. I would expect this to work also when ravelling is involved.
About the motivation, I'm not sure if I'm touching familiar ground here, but you could think of MCMC, or variational inference, or Laplace approximation, and so on. All of these algorithms involve algebraic operations over model parameters. If for model we take a neural network, its parameters are expressed as dictionaries. If I want, say MCMC to work in this case, I have two choices: (a) I tree-map all algebraic operations in MCMC, so that no ravelling is needed; (b) I leave the MCMC algorithm as it is, but pass functions that take ravelled parameters as inputs.
While (a) is viable, (b) is less intrusive. In general, I would prefer taking a (b) approach.

I think taking the diagonal of the jacobian will probably be your best bet.

(xref similar issues with similar outcomes: #1563 #3022 #3801)

I see. Thanks a lot!

I think there's no further action for us to take here; closing. Feel free to reopen if there's something further for us to look into!


Does not work with IISExpress

Doesn't work with IISExpress, only web:
SocketException: An existing connection was forcibly closed by the remote host.
IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host.
System.Net.Sockets.NetworkStream.EndRead(IAsyncResult asyncResult)
WebException: The underlying connection was closed: An unexpected error occurred on a receive.
System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
HttpRequestException: An error occurred while sending the request.
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)

It did work in IISExpress a week or two ago (we made it work at the MVP summit hackathon). Looks like one of the dependencies has changed. I'll look into it.

After updating everything to ASP.NET 5 RC1, it's working fine with IIS Express as far as I can tell. If you still get any issues after fetching the latest version of this repo and running it with ASP.NET 5 RC1 installed, please let me know.

Yeah, it seems to be working now... thanks!

I am now having this issue as well. I have ASP.NET 5 RC1 Update 1 installed. It happens with IISExpress and web.


Assignment does Not Cause Type Widening

TypeScript Version:  2.3.2
Modified from a question from a StackOverflow thread. Not sure if this is a bug.
Code
let id: string = ")";

function myFunc() {
  id = "("; /*1*/
};

if (id !== '(')
  throw "Expected '(' in prototype";
// id is narrowed to "("

myFunc();

// id is still "(",

// now id and ')' does not have same type, this causes type error
if (id !== ')')
  throw "Expected ')' in prototype";

Expected behavior:
(1) should widen the type of id back to string, so the second if should typecheck.
Actual behavior:
id still have the literal type '('

See discussion in #9998.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Update bridge (#87)

removed the old SM model code
added support for newer implementation of SM model
updated SM model code to to be compatible with the latest torchtext version.
@tuzhucheng @Impavidity please review

LGTM


chore(ts): Converting MainPreset.js to MainPreset.ts

SUMMARY

Was just taking a look at this, and figured... why not?
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TESTING INSTRUCTIONS

TS runs, linting passes, product seems to work. CI should be convincing enough.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

I don't know why the E2E tests aren't passing here... it totally works when I try it manually.


Move strict directive to top

It's useless if not on top.

LGTM -- Currently running the tests on my machine whilst I look into the CI issues.
Thanks for the pull request!

Sorry, it was a bold PR. I edited without testing.

That's perfectly fine with me. You have prompted me to look into the CI issues :-)
Thanks again for ensuring we have strict usage throughout our codebase.

This has been addressed in the es6 update branch.  Needed doing, so thanks for suggesting it, but we will probably just wait on #643


safekeeper: check for non-consecutive writes in safekeeper.rs

wal_storage.rs already checks this, but since this is a quite legit scenario check it at safekeeper.rs (consensus level) as well.
ref https://github.com/neondatabase/neon/issues/8212

There was an idea to try to differ when these conditions are 'expected' and not, but I don't see a useful way to do this. It is normal to see this in case of reconnections. Something different is hard to imagine and likely means serious bug, like wal truncation repeatedly truncating not at the point where streaming later starts; then we won't be able to write anything at all and also notice the problem.


Fix issue with save and sign out

What is the context of this PR?
Quick PR to update to the latest design system version.
Currently using keyboard 'Enter' will sign you out. This fixes that. Also part of recently merged: #2277
How to review

Ensure Save and sign out button is a link.
Ensure Enter key doesn't submit the form.

DO NOT UPDATE BRANCH
Using to deploy a bug fix.

Works for me
This branch can be updated now? Looks as though you've tagged it?

Yup

 Save and complete later not working on mobile

 Save and complete later not working on mobile


[WIP][doc] installing silx in a virtualenv

This is a PR to add a  documentation page for installing silx in a virtualenv, for users with no sudo privileges.
It addresses #378
The section about PyQt is still work in progress. We probably need to create our own PyQt manylinux wheels for python 2.7 and python 3.4.
Regarding the rest of the paragraphs, do we need more details?

manylinux PyQt4 wheels would also be useful for travis.... Issue #176

LGTM


Allow FieldArray to be impure

I am trying to implement some interface that is similar to http://redux-form.com/6.4.3/examples/selectingFormValues/ but fields should be wrapped into FieldArray.
Currently, this is not possible, because shouldComponentUpdate prevents all further updates, even they are possible. See added test, it didn't passed before, but currently it passes.

Doesn't this change make the what's shown in the UI different from what's stored in the redux store?

Current coverage is 100% (diff: 100%)

Merging #2465 into master will not change coverage

@@           master   #2465   diff @@
=====================================
  Files          65      65
  Lines        1322    1321     -1
  Methods         0       0
  Messages        0       0
  Branches        0       0
=====================================
- Hits         1322    1321     -1
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update d3f5146...d646dfb

@huan086 it will do exactly the opposite. I have provided a use-case where form state is out of sync with the store. My fixed resolves this problem.

@just-boris Could you write tests for Field and Fields as well? I suspect they should not shouldComponentUpdate as well

This concerns me a bit, since a great deal of effort went into minimizing unneeded renders. But the tests are checking for excessive renders, so if they are passing, I guess it's okay.
I would like to second @huan086's request for additional tests.

@huan086, did you mean that you also want me to modify the Field component? I believe, that it could be done as a separate Pull-request.
@erikras not sure, what should I add to Field test suite, as I did not change anything there.

FieldArray, Field and Fields all have the same shouldComponentUpdate. I'm having a confusion now as to how anyone of them would ever get updated since they always receive the same props, thus would stop further rendering. (the actual state gets sneak through via context, which don't trigger an update I think)
I'm thinking of a test which have 2 text input fields mirror each other. See if it passes. Suspect it fails like your FieldArray test.
If it passes, could someone enlighten me on how ConnectedField and ConnectedFields gets updated without the Field and Fields updating?

I have created an example with two fields with the same name. Everything works fine, though.
http://www.webpackbin.com/E1tZnnHvG
FieldArray is more special than other components because it gives you an access to field values via fields.get(index), which doesn't work correctly now. Field and Fields do not have this object, so they don't have the problem.

Looks like fields.get isn't a good idea, since react-redux won't know that you are dependent on certain values. So far, what I've needed is to look at specific properties of each element in the array (most commonly the id). Maybe the API should be changed to the following?
<FieldArray mapProps={['id', 'other']} component={TheArray} />
and on the receiving side
const TheArray = ({ fields, values }) => { /* values contains [ { id: 'the id', other: 'the other property' }, ... ] */ }

@just-boris does this PR fix this issue?

@mqklin Yes, seems related.

@just-boris Can you look into these test errors? Something must have changed in master since you originally submitted this. I went to test it to merge and it won't build. 😢
Apologies for letting the dust collect on this. I'd like to merge it asap once I can confirm that it works fine.

Any word on this PR? This is an urgent issue within our organization

I wrote a test case here using @just-boris's webpackbin setup
https://www.webpackbin.com/bins/-KgoQMIyvxdJb7Pvh0eu

Fixed the build.
It failed, because some of recently added tests used wrong value. Actually it never worked, but just was not visible, because redering have been cancelled in shouldComponentUpdate

Published in v6.6.2.

I've just updated from 6.5.0 to 6.6.2, and I think this PR broke meta.error passing. Now my fields get meta.error as 'undefined' (in v6.5.0 it was OK).
Code (just for an example):
<form>
  <FieldArray name="some-name component={SomeComponent}/>
</form>
...
@reduxForm({validate})
class SomeComponent extends Component {
  render() {
    return (
      <Field component={Input} />
    );
  }
}
...
const Input = (props) => {
  console.log(props.meta.error); // undefined here, but in 6.5.0 was error text
};

@just-boris do you have this problem as well?


Use centralized fetching errors

We've spread around FETCH_FAILED errors in quite a few places, and
that gives somewhat crude error records, as there's no way to tell if
the error was unavailable algorithms or some other error at such high
levels.
As an alternative, we take recording of these kinds of errors down to
the fetching functions, which are in a much better place to tell what
kind of error it was, thereby relieving the higher level calls from
having to guess.

Ping?

Needs rebase to run the CI.

Done

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

It is a little bit awkward to see similar code structure duplicated for store, encoder, and decoder constructs but I approve anyway.

It's possible that we could abstract that further internally, but I don't see a reason to go crazy with that...  we already have a few layers.

It is a little bit awkward to see similar code structure duplicated for store, encoder, and decoder constructs but I approve anyway.

It's possible that we could abstract that further internally, but I don't see a reason to go crazy with that...  we already have a few layers.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged
d6d42cda5fbc05aeaadf8c760db60e9089e3609b Use centralized fetching errors
5a2d0ef36f4c130758a9d5e84f93004458e3ce60 Clean away extraneous library specific FETCH_FAILED reason codes

Merged
d6d42cda5fbc05aeaadf8c760db60e9089e3609b Use centralized fetching errors
5a2d0ef36f4c130758a9d5e84f93004458e3ce60 Clean away extraneous library specific FETCH_FAILED reason codes


Just made it more responsive

@Satyam-a-Developer issue number and problem description please ?

@Satyam-a-Developer issue number and problem description please ?

Issue in the responsiveness of the website #186
Improving UI at Sign-in/up Section on Homepage and global font #146


Difference between GNU/Linux and Fedora?

What's the difference here? Isn't Fedora a Linux distribution and therefore also GNU/Linux?
Because it appears to me like saying n% Windows and n% Windows 10.

I mean it depends what's the preferred granularity here. But I guess OS details (=how many of the Windows clients have Windows 10/8/7/…) could appear after a click on Windows (or hovering over it).
The same could probably happen for GNU/Linux. Fedora would be a part of it. Wouldn't it? :thinking:

@alexanderadam These are all from the user-agent parser. Those Linux distros that we are not sure about, is put into the GNU/Linux category.
So some Fedora and Ubuntu (had seen some Ubuntu) are separated as standalone while others, both different distros and different versions of the same distro are put into GNU/Linux when we are not 100% sure what exact distro it is.
But I do like the idea of maybe showing versions when hovering or similar. Will consider it!


Jitterbug crashing after force close

Steps to reproduce:

Sign with iOS App Signer and paid developer account with network extension entitlements
Pair with vpn tunnel loopback to device
Force close Jitterbug and reopen
Click on either the support files or pairings tabs and app crashes
Jitterbug-2021-06-10-151227.txt

Oh this is iOS 15. Yeah, I never tested on it and it seems like the crash is in SwiftUI.

@jawshoeadan does this still happen on the latest iOS 15 beta? I can't reproduce it.


sponsors

patformatic

waiting for "the native web" one
cc @cirpo @fgandellini

message from golo

Hey there,
sorry for being late, I was on the road the last days.
So, now, here we go…
Please find our logo attached to this mail as SVG, with a transparent background as you asked for, one time with a bright, and one time with a dark font – depending on whether you want to put it to a light or a dark background.
We've intentionally didn’t cut them, since we didn’t know which paddings you may need or want.
The link is https://www.thenativeweb.io/
Is there anything else you need?
Cheers,
Golo
--
golo roden | cto and managing director
the native web gmbh
paul-ehrlich-straße 7 | 79106 freiburg im breisgau | germany
<EMAIL_ADDRESS>| https://www.thenativeweb.io/
registry court | freiburg im breisgau | germany
commercial register | hrb 709303
managing directors | susanna roden, golo roden, stefan brandys

@cirpo  / @fgandellini are we waiting for other logos, or we can go on with these for now?

@magnum I think we can go with this for now! 👍

any content for the sponsors section?
levels of sponsorship for paltformatic and the native web?
do we need to show some empty boxes for available sposorships and/or link the to contact email or similar
@fgandellini @roberto-contessi i who can take charge of this? i can work on it between today and tomorrow (tuesday) then i have to get back on it by the end of this week or in the weekend...
cc @cirpo @piccoloaiutante

@magnum  Hi, i can do it tomorrow!

@roberto-contessi thank you for the support
i changed some few things and merged

@magnum @roberto-contessi @fgandellini FYI I've added the sponsors logos to figma as well (Page sponsors) https://www.figma.com/file/lUekznwtGCqHDvasC1vrnp/Nodejsconf?type=design&node-id=203-165&t=SX00IBe3qoH9sfP5-0

thank you @cirpo
guys do you think it's better to update the platformatic logo with the one with the name as text too?

Yes @magnum, better updating it so that we show the company name. I can work on it tomorrow.

Thank you @fgandellini


launch.json

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

No information here, please tell us what needs our attention next time


Fix bug where .backup files written into old directories can cause the archive process to warn

Actually changed this to info since it has never caused any issues - still, it should be fixed.  From the code:
# If the dir is not empty check if the files are in the manifest
# If they are, then error - there has been some issue
# If not, they are new - continue processing without error - they'll be picked up on the next run

Fixed in 882f068 by doing away with subdirs when doing async archiving.


Updated example models based on ver.1.9.4

A suggestion to replace our custom AtomicDouble with standard AtomicReference (from java.util.concurrent.atomic)
(our one was a partial recreation of Guava's AtomicDouble, as the library was removed from later AL versions)
minor update to model descriptions
some upcasing fixes in model names
model resources cleanup (removed unused files + fixed reference to resource in 'Python from Experiment Screen' model)
gitignored some model output files

Thanks for this, it all looks great!


Replace csv file regex with os basepath

Description

Related Issues

Checklist

[ ] Is this code covered by new or existing unit tests or integration tests?
[ ] Did you run make unit-testing and make integration-testing successfully?
[ ] Do new classes, functions, methods and parameters all have docstrings?
[ ] Were existing docstrings updated, if necessary?
[ ] Was external documentation updated, if necessary?

Additional Notes or Comments

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (34830a7) 80.33% compared to head (114928d) 75.73%.
Report is 1435 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
- Coverage   80.33%   75.73%   -4.61%
==========================================
  Files          95      123      +28
  Lines        6602     8950    +2348
==========================================
+ Hits         5304     6778    +1474
- Misses       1298     2172     +874

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Gtr/openapi 3

adds vendor extensions, i.e. properties that start with x- such as x-logo. See: https://swagger.io/docs/specification/openapi-extensions/. Usage: extension :'x-tagGroups' do .. end
adds a test for vendor extensions
minor version bump 2.1.0 -> 2.2.1

Thanks for initiating the upgrade of this gem to OAS3! 🙂

@swiknaba apologies for the delay. The notification got lost in the abyss. Thank you very much for your contribution!


update contributors

@all-contributors please add @thwtt @SAGIRI-kawaii for the digital shadow.

https://github.com/all-contributors please add @thwtt @SAGIRI-kawaii for the digital shadow.

https://github.com/all-contributors please add @SAGIRI-kawaii for the digital shadow.

@all-contributors please add @thwtt  for the digital shadow.

https://github.com/all-contributors please add @thwtt @SAGIRI-kawaii @wanchaofan2000 @sonic160  for code.

https://github.com/all-contributors please add @thwtt for code

@all-contributors
please add @thwtt for code.
please add @SAGIRI-kawaii  for code.

@all-contributors
add @X1M1C1 for code
add @KillianMcCourt for code


Onboarding tasks for Arsenios

Tasks

Welcome to the HCA DCP! We are pleased to introduce you to the data wrangling team. Before beginning to work by yourself, you'll be asked to complete a set of tasks and meetings. These will guide you through both the general and specifics of your role, and it will help us make sure you understand how we work in the team. Your introductory tasks are:

[x] Read the onboarding document.

[x] Add yourself to the table of wranglers via a PR

[x] Move this ticket from "to do" to "in progress" Pipeline in ZenHub.
[x] Create an issue for each general task and link it to this epic.
[x] Clone all the basic repos to your computer (look at the onboarding document for more information)
[x] Locate all the documents regarding SOPs. You don't need to read them for now, but make sure to know where they are (Via notes, bookmarking, etc)

General tasks

These are more wrangling-specific tasks. They will provide you with the basic knowledge necessary to perform your future tasks in the team. These include:

Watch HCA Metadata Standard 101 video (slides).
Familiarise yourself with the projects and Standard Operating Procedures (SOPs) inside the hca-ebi-wrangler-central repository
Read up on FAIR Data Principles

The FAIR Guiding Principles for scientific data management and stewardship (Wilkinson 2016)
A design framework and exemplar metrics for FAIRness (Wilkinson 2018)
Quick summary of FAIR Data Principles
Also related: Uniform resolution of compact identifiers for biomedical data (Wimalaratne 2018)

Add or update tickets in wrangling or metadata-schema repo to reflect work being done.

Specific role tasks
These tasks will give you an insight on your role, and provide you with the appropriate tools to proceed in your job. As your first dataset, you have been assigned to wrangle the publication Transcriptional changes in the mammary gland during lactation revealed by single cell sequencing of cells from human milk. To familiarise yourself to the wrangling process, your tasks regarding this dataset are:

[x] Create a ticket in this repository using the Published project tracker template
[x] Read the paper and gather the following information:

[x] Type of tissue: primary, cell line, organoid?
[x] Technology used for library preparation: 10x, smart-seq2?
[x] Developmental stage of the donors: Adult, fetal, embryos?

[x] Generate a spreadsheet template from the project page in ingest. Try to use the information gathered from the previous point to generate it.
[x] Create a google drive folder inside the brokering folder and store the spreadsheet there
[x] Read through the paper and try to fill the spreadsheet with the available information. Use the spreadsheet quick guide to guide you through the process.
[x] Once completed, post in the ticket that the dataset is ready for secondary review and tag @idazucchi .
[ ] When secondary review is completed, you will have a meeting with @idazucchi  to go through the corrections/queries
[ ] Follow the rest of the items in the ticket you created to finish the submission

Onboard Meetings
These meetings will help you understand some aspects of the work here, as well as our work policy and important details about what technologies we use. They will be short (around 30 minutes) and you should try to get at least one per day. You will be expected to book the meeting with the person that is supposed to give it.

Introduction to the DCP - @gabsie
AIT organisation; team days, overall routine - @gabsie
Introduction to agile: The manifesto and basic concepts. Technical Lead (TL), Product Owner (PO), sprint, tickets and story points. Zenhub walk-through and standup format -  @amnonkhen
Computational environments: DCP's Github workflow, recommended software (PyCharm, sublime, google sync, notes, postman). @ESapenaVentura
Developmental environments: Development, Staging, Production. @amnonkhen
Metadata repository 1: Entities structure: core, type and module. Graphs as a tool to represent a project. @ESapenaVentura
Metadata repository 2: Introduction to JSON, schema evolution and versioning. @ESapenaVentura
Overview of metadata schema updates - @ESapenaVentura
Technologies: 10x, SMART-Seq2, Imaging transcriptomics, CITE-Seq, ATAC-Seq, 10x Visium TBD
Intro to wrangling for downstream portals @Wkt8
Wrangling repository: Tools, tickets, MarkDown documents and processes. Graph validator. @ESapenaVentura
The spreadsheets and the contributor form. General tour and how to generate one. @ESapenaVentura
Linked knowledge: Quick introduction to ontologies. TBD
Components: DCP and organisation. @gabsie
Ingest component: Overview of ingest infrastructure.  Dev TBD

Acceptance criteria

[ ] Finish all the tasks outlined.
[ ] Close this issue.

Graph valid and ready for secondary review @idazucchi .

Meetings done:
[ ] Introduction to the DCP - @gabsie
[ ] AIT organisation; team days, overall routine - @gabsie
[ ] Introduction to agile: The manifesto and basic concepts. Technical Lead (TL), Product Owner (PO), sprint, tickets and story points. Zenhub walk-through and standup format - @amnonkhen
[ ] Computational environments: DCP's Github workflow, recommended software (PyCharm, sublime, google sync, notes, postman). @ESapenaVentura
[ ] Developmental environments: Development, Staging, Production. @amnonkhen
[ ] Metadata repository 1: Entities structure: core, type and module. Graphs as a tool to represent a project. @ESapenaVentura
[ ] Metadata repository 2: Introduction to JSON, schema evolution and versioning. @ESapenaVentura
[ ] Overview of metadata schema updates - @ESapenaVentura
[ ] Technologies: 10x, SMART-Seq2, Imaging transcriptomics, CITE-Seq, ATAC-Seq, 10x Visium TBD
[ ] Intro to wrangling for downstream portals @Wkt8
[ ] Wrangling repository: Tools, tickets, MarkDown documents and processes. Graph validator. @ESapenaVentura
[ ] The spreadsheets and the contributor form. General tour and how to generate one. @ESapenaVentura
[ ] Linked knowledge: Quick introduction to ontologies. TBD
[ ] Components: DCP and organisation. @gabsie
[ ] Ingest component: Overview of ingest infrastructure. Dev TBD


Fix issue #106

Hello,
I tested this comment fix, and it seems to work, so here is the PR.
Context
Some context about issue #106: an error occurs within sigmake while processing pattern files that provide invalid function length, with "invalid" meaning that the function length should be an hexadecimal number with either 8 or 4 digits. In the current code of idb2pat, function sizes were calculated to at least 4 digits, but not forced to 8 digits if the number exceeds 4 digits. Analyzing any function which size exceeds 0xFFFF would result in an invalid pattern file.
The fix
Changed the %04X format to %08X format. This should not have any impact on the signature generation.
Testing the PR
The following shows what I did to test this PR.
Create a simple C program such as:
#include<stdio.h>
#include <stdlib.h>

int call_h(){
    int x = 2;
    int y = 4;
    puts("Hello");
    return x * 4 - 2;
}

void main(){
    printf("%x\n", call_h());
}

Compile it:
gcc -m32 a.c -o a32.out
gcc a.c -o a.out

Then:

create pat signatures with idb2pat
create a valid signature with sigmake
stripp the executables and load them in IDA to check that the signature applies correctly.

I also tried on serde_derive_internals executable from Rust's serde crate, which has a proc_macro function that was exceeding 0xFFFF bytes, and it works perfectly.

Also seems to be related to #107 and #59


listItemIndent value of "1" is still replaced by tabs.

Hello, I read the documentation and have set the remark.format rules listItemIndent option to "1" in my settings.json. When I tell VSCode to do the remark formatting, it is still adding the 3 spaces instead. My other options (like setext: true) are correctly followed.
Relevant portion:
"remark.format": {
        "rules": {
            "setext": true,
            "listItemIndent ": "1",
            "rule": "*"
        }
    },

Same here, any advice @mrmlnc?

Found the problem, listItemIndent is indeed respected, but when you use IntelliSense to create the setting it adds an extra space at the end of the JSON key, making Remark not recognize it.
I created #19 to fix that. In the meantime, just delete the extra space in your config.


GramFuzzer import error

Hi I am getting following error:
python test.py
Traceback (most recent call last):
File "test.py", line 25, in
from test import test_pjf_factory
File "/root/fuzzer/PyJFuzz/test/test_pjf_factory.py", line 24, in
from pyjfuzz.core.pjf_configuration import PJFConfiguration
File "/root/fuzzer/PyJFuzz/pyjfuzz/core/pjf_configuration.py", line 32, in
from .pjf_grammar import generate_json
File "/root/fuzzer/PyJFuzz/pyjfuzz/core/pjf_grammar.py", line 25, in
from gramfuzz import GramFuzzer
ImportError: cannot import name GramFuzzer

I fixed it by manually installing the latest copy of gramfuzz ==1.2.1

Thanks for the hint, but it did not help me:
$ sudo pip install gramfuzz==1.2.1
...
Successfully installed gramfuzz-1.2.1

Still same output...
$ python test.py
Traceback (most recent call last):
  File "test.py", line 25, in <module>
    from test import test_pjf_factory
  File "/data/work/tools/PyJFuzz/test/test_pjf_factory.py", line 24, in <module>
    from pyjfuzz.core.pjf_configuration import PJFConfiguration
  File "/data/work/tools/PyJFuzz/pyjfuzz/core/pjf_configuration.py", line 32, in <module>
    from .pjf_grammar import generate_json
  File "/data/work/tools/PyJFuzz/pyjfuzz/core/pjf_grammar.py", line 25, in <module>
    from gramfuzz import GramFuzzer
ImportError: cannot import name GramFuzzer

Any other idea?

What I did is:
Change in pjf_grammar.py
from gramfuzz import GramFuzzer
to
from gramfuzz import *
Looks like it works now...


Converted to Typescript and added ability to start in OPEN or CLOSED state

Thanks for your contribution!
I'm currently updating all my markdown-it plugins to a new build/testing system, so I had to manually add the open/closed functionality instead of merging your pull request. I hope that's OK for you.
I also changed the syntax:

I kept +++ for closed state to keep it compatible with the previous version of the plugin
For open state, I changed the markup to ++> as >>> is already used in GitLab Flavored Markdown and I want to reduce syntax conflicts

👍🏻


Need a schema for config.yaml

payu needs a schema for config.yaml so we can build tools that can parse the files correctly.

Notes
https://json-schema-everywhere.github.io/yaml
https://developers.redhat.com/blog/2020/11/25/how-to-configure-yaml-schema-to-make-editing-files-easier


[HUDI-4549]  Remove avro from hudi-hive-sync-bundle and hudi-aws-bundle

Change Logs

Remove Avro shading from hudi-hive-sync-bundle and hudi-aws-bundle
We cannot shade avro in hudi-spark-bundle or hudi-utilities-bundle because we use certain SparkConf APIs that expect unshaded Avro classes. If we shade Avro in hudi-hive-sync-bundle without shading in hudi-spark or hudi-utilities bundle then it can lead to conflict (NoMethodFoundError) as mentioned in HUDI-4549.

Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Tested hive sync locally and on EMR with changing the order of jars in the launch command.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@codope i tested running hive sync tool and glue sync tool alone from both bundles in emr env. worked fine.

@codope i tested running hive sync tool and glue sync tool alone from both bundles in emr env. worked fine.

Sounds good. I'll land it then. The failing test is flaky and there is already a ticket to fix it HUDI-4327.


redis.lock, redis.lock.Lock not thread safety

The documentation mentioned Pipline is not thread safety, and redis.lock.Lock using redis.transaction(pipline).
So redis.lock.Lock is not thread safety, am I right?

Lock objects are thread safe when not using them with pipelines.
Once you mix in pipelines there is no guarantee about thread safety.

thanks. It's good to know the lock is thread safety
I have a issue when using redis.lock under multi thread context, I have to think clear for every single line code.

Don't know what issue you are having, but I reported one here #601 which is a fd leak from the uuid c-library.


postpone all overdue tasks?

one feature I'd find useful would be the ability to postpone all overdue tasks with a click or two. Maybe I could specify a timeframe -- e.g., from 3 days in the future to 20 days in the future -- and the overdue items could be randomly assigned to days in that range? A bonus would be if recurring tasks would not be postponed past their next occurring date.

Hi there, thanks for reaching out!
My initial thought is that this would not suit Autodoist. I am a bit biased, since I'm following the GTD approach, but it's good practice to 1) create tasks that you can actually achieve, 2) plan them when you can actually do them, and 3) have weekly reviews to tidy up whatever tool you are using to manage your tasks. From the looks of it, creating a feature to clean up (too) many overdue tasks and putting them at a random dates would violates all three of these aspects. Changing your workflow and habits could prove to be a much greater help in the long run, than a feature that solves the effects.
Out of interest and to get a better understanding of this, could you give me a bit more information on your current workflow and what creates this situation?

I hear you, @Hoffelhas! My whole workflow has a lot of parts, but one thing it involves is many repeating tasks that don't have to happen on any given day, but do have to happen eventually -- doing laundry, reducing my email backlog, etc. It's great to have those recur, because I might not think to do them otherwise. But if they don't all get done, then they start to collect as overdue items.  I really want to just be able to click once to postpone all of them. I think that's part of a healthy overall workflow!


Navbar items now close on blur

Related Issue

Fixes #399
Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[x] I have commented on the linked issue
[x] I was assigned the linked issue (not required)
[x] I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

[ ] My change adds new text and requires a change to translations.
[ ] My change requires a change to the documentation.
[ ] I have submitted a PR to the documentation repo.
[ ] I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
[ ] This change depends O-FISH Realm repository changes (explain below)

Optional: Add any explanations here

Needed to wrap the menu into the div with the onMouseLeave events so they had expected behaviour.
New to open source so happy to get feedback want to be a positive contributor while participating in Hacktoberfest

Optional: Add any relevant screenshots here

Code looks great and I tested the functionality - looks great!
Congratulations! 🎉 🙌 🎆 ㊗
This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

Thank you so much 🎉!
Already got assigned and ready to start the next one 💪


[Admin.Orders] The sort in asc/desc order buttons are not functional

Environment: Windows 10, Google Chrome 101
Reproducible: always
Build found: 05.05.2022
Preconditions
Go to https://ita-social-projects.github.io/GreenCityClient/#/
Sign in as admin
Steps to reproduce
1.Click the 'UBS-admin' button in pop-up window
2.Click the 'Orders' button
3.Click the arrow in the any field
4.Take a look if the information is sorted in descending/ascending order
Actual result
The sort in asc/desc order buttons are not functional
Expected result
By clicking on the sorting button the information is sorted in descending/ascending order

duplicate of https://github.com/ita-social-projects/GreenCity/issues/4065


Add settle time as property of Signal to be referenced in set method

Currently settle time only exists as an attribute in Positioners and not Signals. However, Signal.set() uses this as a keyword argument, which obscures it from bps.mv or other plans. This adds settle_time as a property of Signal, that can be overridden in the call to set(). It keeps the defaults as None, and should maintain backward compatibility with existing devices.

We also need a test of this.  We have a couple example of using time.monotonic() to run timing tests to make sure things are really sleeping when we expect.

Is there a described protocol for developing and running pytest? I'm running the bash scripts that get run in GHA and hoping those will create the containers needed to pass pytest on master.

Tu run tests locally, consider using https://github.com/nektos/act which runs the tests in a local VM (docker?) as they would run in GHA.

Note to self: this needs to be included in #1063

Coming back to this, even using act, I end up with a few failed tests on the master branch.
I'll work from this basis as I build the tests for this, and ensure coverage doesn't decrease.
| ---------- coverage: platform linux, python 3.8.14-final-0 -----------
| Name                                           Stmts   Miss  Cover
| ------------------------------------------------------------------
| ophyd/__init__.py                                 64     22    66%
| ophyd/__main__.py                                  9      0   100%
| ophyd/_caproto_shim.py                            81     81     0%
| ophyd/_dispatch.py                               116      6    95%
| ophyd/_dummy_shim.py                              36     36     0%
| ophyd/_pyepics_shim.py                            96      7    93%
| ophyd/_version.py                                  2      2     0%
| ophyd/areadetector/__init__.py                     9      0   100%
| ophyd/areadetector/base.py                       228      1    99%
| ophyd/areadetector/cam.py                       1102      5    99%
| ophyd/areadetector/common_plugins.py              89      0   100%
| ophyd/areadetector/detectors.py                  110      9    92%
| ophyd/areadetector/docs.py                         1      0   100%
| ophyd/areadetector/filestore_mixins.py           255    103    60%
| ophyd/areadetector/paths.py                       49      7    86%
| ophyd/areadetector/plugins.py                   1126     56    95%
| ophyd/areadetector/trigger_mixins.py             116     52    55%
| ophyd/areadetector/util.py                        87     72    17%
| ophyd/callbacks.py                                37     37     0%
| ophyd/device.py                                  680     66    90%
| ophyd/docs/__init__.py                             3      0   100%
| ophyd/docs/templates/__init__.py                   3      0   100%
| ophyd/docs/templates/autosummary/__init__.py       0      0   100%
| ophyd/docs/utils.py                               68     14    79%
| ophyd/epics_motor.py                             153     21    86%
| ophyd/flyers.py                                  210    109    48%
| ophyd/log.py                                      97     24    75%
| ophyd/mca.py                                     248     16    94%
| ophyd/mixins.py                                   67      7    90%
| ophyd/ophydobj.py                                230     10    96%
| ophyd/positioner.py                              146      6    96%
| ophyd/pseudopos.py                               381     47    88%
| ophyd/pv_positioner.py                           193     17    91%
| ophyd/quadem.py                                   82      0   100%
| ophyd/scaler.py                                   88     26    70%
| ophyd/signal.py                                  774     45    94%
| ophyd/sim.py                                     743    146    80%
| ophyd/status.py                                  287     23    92%
| ophyd/tests/__init__.py                            1      0   100%
| ophyd/tests/config.py                              7      0   100%
| ophyd/tests/conftest.py                           93      5    95%
| ophyd/tests/fake_motor_ioc.py                     33      0   100%
| ophyd/tests/mca_ioc.py                           118      0   100%
| ophyd/tests/scaler_ioc.py                        154      0   100%
| ophyd/tests/signal_ioc.py                         27      0   100%
| ophyd/tests/test_areadetector.py                 421     91    78%
| ophyd/tests/test_bluesky_protocols.py             66     10    85%
| ophyd/tests/test_device.py                       475      6    99%
| ophyd/tests/test_docs.py                          14      0   100%
| ophyd/tests/test_epicsmotor.py                   206      5    98%
| ophyd/tests/test_flyers.py                       123     66    46%
| ophyd/tests/test_hints.py                         35      0   100%
| ophyd/tests/test_issue944.py                      29      0   100%
| ophyd/tests/test_kind.py                         292      0   100%
| ophyd/tests/test_log.py                           44      0   100%
| ophyd/tests/test_main.py                           6      0   100%
| ophyd/tests/test_mca.py                          104      0   100%
| ophyd/tests/test_ophydobj.py                     131      0   100%
| ophyd/tests/test_positioner.py                    69      0   100%
| ophyd/tests/test_pseudopos.py                    262     78    70%
| ophyd/tests/test_pvpositioner.py                 216      2    99%
| ophyd/tests/test_quadem.py                        60      1    98%
| ophyd/tests/test_scaler.py                        84      7    92%
| ophyd/tests/test_signal.py                       442      0   100%
| ophyd/tests/test_signalpositioner.py              54      0   100%
| ophyd/tests/test_sim.py                          225      1    99%
| ophyd/tests/test_status.py                       307      1    99%
| ophyd/tests/test_timeout.py                       26      0   100%
| ophyd/tests/test_timestamps.py                    61      0   100%
| ophyd/tests/test_units.py                         46      0   100%
| ophyd/tests/test_utils.py                         76      0   100%
| ophyd/tests/test_versioning.py                    23      0   100%
| ophyd/units.py                                    73     24    67%
| ophyd/utils/__init__.py                           82     23    72%
| ophyd/utils/epics_pvs.py                         171      4    98%
| ophyd/utils/errors.py                             28      0   100%
| ophyd/utils/paths.py                              26      1    96%
| ophyd/utils/startup.py                             8      3    62%
| ophyd/v2/__init__.py                               0      0   100%
| ------------------------------------------------------------------
| TOTAL                                          12784   1401    89%
| Coverage XML written to file cov.xml
|
| =========================== short test summary info ============================
| FAILED ophyd/tests/test_areadetector.py::test_fstiff_plugin[pyepics-None-/tmp/ophyd_AD_test/data1/%Y/%m/%d-None-False0]
| FAILED ophyd/tests/test_areadetector.py::test_fstiff_plugin[pyepics-None-/tmp/ophyd_AD_test/data1/%Y/%m/%d-None-False1]
| FAILED ophyd/tests/test_areadetector.py::test_fstiff_plugin[pyepics-/tmp/ophyd_AD_test/data1-%Y/%m/%d-None-False]
| FAILED ophyd/tests/test_areadetector.py::test_fstiff_plugin[pyepics-/tmp/ophyd_AD_test/data1-/tmp/ophyd_AD_test/data1/%Y/%m/%d-%Y/%m/%d-False]
| FAILED ophyd/tests/test_areadetector.py::test_fstiff_plugin[pyepics-/-/tmp/ophyd_AD_test/data1/%Y/%m/%d-None-False]
| FAILED ophyd/tests/test_areadetector.py::test_fshdf_plugin[pyepics-None-/tmp/ophyd_AD_test/data1/%Y/%m/%d-None-False0]
| FAILED ophyd/tests/test_areadetector.py::test_fshdf_plugin[pyepics-None-/tmp/ophyd_AD_test/data1/%Y/%m/%d-None-False1]
| FAILED ophyd/tests/test_areadetector.py::test_fshdf_plugin[pyepics-/tmp/ophyd_AD_test/data1-%Y/%m/%d-None-False]
| FAILED ophyd/tests/test_areadetector.py::test_fshdf_plugin[pyepics-/tmp/ophyd_AD_test/data1-/tmp/ophyd_AD_test/data1/%Y/%m/%d-%Y/%m/%d-False]
| FAILED ophyd/tests/test_areadetector.py::test_fshdf_plugin[pyepics-/-/tmp/ophyd_AD_test/data1/%Y/%m/%d-None-False]
| FAILED ophyd/tests/test_flyers.py::test_monitor_flyer[pyepics-True] - Failed:...
| FAILED ophyd/tests/test_flyers.py::test_monitor_flyer[pyepics-False] - Failed...
| FAILED ophyd/tests/test_pseudopos.py::test_multi_sequential[pyepics] - Failed...
| FAILED ophyd/tests/test_pseudopos.py::test_multi_concurrent[pyepics] - Failed...
| FAILED ophyd/tests/test_pseudopos.py::test_single_pseudo[pyepics] - Failed: T...
| = 15 failed, 1745 passed, 124 skipped, 1885 deselected, 1 xfailed in 468.75s (0:07:48) =
[Code CI/test-1]   ❌  Failure - Main Test with pytest
[Code CI/test-1] exitcode '1': failure
[Code CI/test-1] 🏁  Job failed

It looks like something on CI got faster and we are no longer actually going through re-try loop 🤦🏻 .

Can you rebase to get rid of the merge commit?

This approved PR languishes.  Can it be merged?


Fixes for the "Basics of machine learning" tutorial

Fix datatype of library files. The sklearn_svm_classifier only supports tabular files.
Add tool ids to hands-on sections.
Fix accessibility of a link.
Misc small fixes/improvements.

@hexylena If this is not taken care automatically (and you are able to), it would be good to also fix the datasets' datatype (from tsv to tabular) on the EU data library: https://usegalaxy.eu/libraries/folders/F6c313b15da419682/page/1

I changed the datatype. Thanks for pointing it out @nsoranzo

Thanks @bgruening ! One more thing that would be useful is to hide 2 old versions of the "Support vector machines (SVMs) for classification" tool, which come up when searching for e.g. svms. The versions to hide would be:

toolshed.g2.bx.psu.edu/repos/bgruening/svm_classifier/svm_classifier/0.9
https://usegalaxy.eu/tool_runner?tool_id=svm_classifier (locally installed?)

Thanks!

Thanks @nsoranzo. This should now be fixed. Sorry it took that long.


Follow up tickets from additional reviews

Grouping requests into one ticket to reference here

@mickmister fix for MM-51250 https://github.com/mattermost/mattermost-plugin-azure-devops/pull/147

@mickmister fix for [MM-51247] https://github.com/mattermost/mattermost-plugin-azure-devops/pull/149

@mickmister fix for [MM-51253][MM-51275] https://github.com/mattermost/mattermost-plugin-azure-devops/pull/148

@mickmister fir for [MI-51272]


Add support for F1->F12 keys

Hi !
I just bind the F1 to F12 keys.
More keys are available but these ones missed for me.

For ranges, we probably want to map whole sections, see the area just below that range:
// Add letters
for( ko in 0...26)
	keycode_map[Key.A + ko] = ImGuiKey.A + ko;

These should be contiguous, you can map the whole range in with a quick two liner instead of building a giant monolithic array that might need changed when imgui changes their indices (again)

It’s ok for me.
I will propose a commit with this change.

After checking. There is an issue.
In ImGuiDrawable.hx, I can easily map F keys like letters but in ImGui.hx, letters are map with
class ImGuiKeyStringExtender {
	static inline public function imKey(s:String): Int {
		var v = 546 + (s.charCodeAt(0) - 'A'.code);
		return v;
	}
}

And I don't think I can extends this function with the same logic because of s.charCodeAt(0).
F Keys are two characters keys and have not associate characters. I don't say we can extends imKey function but that could set more complexity than this pull request.
I could just update ImGuiDrawable.hx, but I feel it's better to keep parallels implementations.
What do you think about it ?

Good catch!
In that case maybe it makes more sense to just accept your original PR and use ImGuiKey here.
I'm not sure what your use case is here, but if the PR currently works then I can accept it as-is.


Rocket Unturned Version: <IP_ADDRESS> Build: #971 Problem Please help!!!!!

You guy made a mistake for the unturned version on you website it says <IP_ADDRESS> but the right version is <IP_ADDRESS> not <IP_ADDRESS> becasue alot of people aree having isuses with this problem even i am alot of my friends cant join my server they told me that it said this server is running a different version of the game !!!! please help

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36690052-rocket-unturned-version-4-9-8-0-build-971-problem-please-help?utm_campaign=plugin&utm_content=tracker%2F10719061&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F10719061&utm_medium=issues&utm_source=github).

https://rocketmod.net/get-rocket


Creating names.txt

We added names to the project repository in names.txt that are listed as Keegan Ballantyne and Yurou Li

We added names to the project repository in names.txt that are listed as Keegan Ballantyne and Yurou Li


fix: handle missing pnpapi

I'm using a global installation of typescript-language-server that uses PnP, but working on a project that uses Yarn with nodeLinker: node-modules and a local TypeScript installation. In this case, process.versions.pnp is set, but findPnpApi will return null for project files.
 I assume that's unrelated to this, but will check.

Test results look the same before and after this change.

I wasn't watching this repo and therefore missed this PR so sorry about that.
Due to the conflict I've cherry picked your changes to https://github.com/merceyz/TypeScript/commit/599a59147ff88c44d815e870cefbd6c33a8bc161.
I'll include this change in the next compat patch update in Yarn, thanks for the fix.


Vue TSC enums being reduced to never, Webstorm/VSCode not picking up these errors

Vue TSC enums being reduced to never, Webstorm/VSCode not picking up these errors
cms:typecheck:   The intersection 'typeof MutationTypeEnum & { readonly [x: number]: string; readonly CREATED: MutationTypeEnum.CREATED; readonly UPDATED: MutationTypeEnum.UPDATED; readonly DELETED: MutationTypeEnum.DELETED; }' was reduced to 'never' because property 'CREATED' has conflicting types in some constituents.
cms:typecheck: ../../node_modules/lib/src/components/Features/casefiles/edit/activities/ActivityItem/ActivityItem.vue(51,36): error TS2322: Type '(InternalHydraItem & HydraTimeBased & { '@type': "Activity"; id: number; createdBy: UserHydraItem; type?: ActivityTypeEnum | undefined; caseFile: string; mutationType?: MutationTypeEnum | undefined; } & ActivityCreated) | (InternalHydraItem & ... 2 more ... & ActivityCaseFileUpdated) | (InternalHydraItem & ... 2 mor...' is not assignable to type 'InternalHydraItem & HydraTimeBased & { '@type': "Activity"; id: number; createdBy: UserHydraItem; type?: ActivityTypeEnum | undefined; caseFile: string; mutationType?: MutationTypeEnum | undefined; } & ActivityCaseFileUpdated'.
cms:typecheck: ../../node_modules/lib/src/components/Features/casefiles/edit/activities/ActivityItem/ActivityItem.vue(60,47): error TS2339: Property 'PAYMENT' does not exist on type 'never'.

We are running:
"vue-tsc": "^1.8.25"
"vite": "^5.0.10",
"typescript": "^5.2.2",
"vue": "^3.4.0",

Is there a way to fix this? We tried many many things but at the end we ended up just replacing value's of enums with their actual values.
Example enum:
export enum MutationTypeEnum {
  CREATED = 1,
  UPDATED = 2,
  DELETED = 3,
}

As the image above shows we needed to replace all ENUM values with the actual values because we kept getting errors

I can't reproduce. Could you please create a minimal reproduction?

Closing this one as many things have changed since 2.x. Feel free to create a new issue with a minimal reproduction if you're still having issues, thanks!


Write bird conf file manually, could it be automatically?

Calico uses confd to generate bird conf, but romana needs user to write bird conf manually.  This would be hard for someone else.

What do you mean 'user'? There is a bird template that gets configured automatically. Have you installed the 'route publisher' add-on?  This will install Bird and reload the configuration automatically.
The user can configure bird specifically to their requirements, but it will be automatically loaded.

@mdianjun Send an email to<EMAIL_ADDRESS>to get an invite to our slack channel. There are others there that can help you through the configuration details.


defer close DialResp channel to avoid dangling go routines

We need this because in case of timeout, channel will still be created and goroutine will be dangling around

@adubkov toughts?

@adubkov thoughts?


[1162] Remove the support_user_reinstate_offer feature flag

Context
Removing the support_user_reinstate_offer feature flag as its been active in production since May 2021.
The Data migration will be merged after this PR, in #8991.
Changes proposed in this pull request
See commits.
Link to Trello card
https://trello.com/c/7e89k5ST/1162-apply-remove-the-supportuserreinstateoffer-feature-flag
Things to check

[x] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[x] API release notes have been updated if necessary
[x] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[x] Required environment variables have been updated added to the Azure KeyVault

 Apply: Remove the support_user_reinstate_offer feature flag


Prime Number Enhanced

Do the checklist before submitting the PR:

[yes ] Have you read the guidelines mentioned in CONTRIBUTING.md?
[yes ] Have you squashed your commits?

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0)
A: v10.14.0
Q: Mention the Issue Number! (e.g. Fixed #8)
A: fixed #97

Give additional information regarding the PR below:
Improved the isPrime functions. It has a less iterations now. And it is more efficient.

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          56     56
  Lines         694    702    +8
=====================================
+ Hits          694    702    +8

Impacted Files
Coverage Δ

src/prime/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7360f40...47c9f42. Read the comment docs.

What files do I need to include?

@baibhabmondal please read the contribution guidelines again

I read the guidelines, I am not getting which files to include. I have overwritten the isPrime function, therefore, the readme.md is already contains isPrime. I am assuming that you're telling me to update Readme.md.


add dhcp project to build tooling

Issue #, if available:
Description of changes:
Add dhcp relay project. We need to build this project to support dhcp relay on the tinkerbell provider.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherry-pick release-0.20


/__t/jq/jq: Permission denied after downloading jq

Found a bug? Maybe our Slack Community can help.

Describe the Bug
When using the cloudposse/github-action-matrix-outputs-read@main action in a python:3 container on ubuntu-latest, the "jq" command is downloaded and its directory put into the path. However, the downloaded "jq" command is not permitted to be executed:
Run cloudposse/github-action-matrix-outputs-read@main
Run<EMAIL_ADDRESS>Run _jq_bin="$(which jq)"

Run $GITHUB_ACTION_PATH/scripts/unixish.sh
Prep
Downloading jq
  Src: https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux64
  Dst: /__w/_temp/jq-linux64
  --2023-10-15 21:00:27--  https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux64
  Resolving github.com (github.com)... <IP_ADDRESS>
  Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
  HTTP request sent, awaiting response... 301 Moved Permanently
  Location: https://github.com/jqlang/jq/releases/download/jq-1.6/jq-linux64 [following]
  --2023-10-15 21:00:27--  https://github.com/jqlang/jq/releases/download/jq-1.6/jq-linux64
  Reusing existing connection to github.com:443.
  HTTP request sent, awaiting response... 302 Found
  Location: https://objects.githubusercontent.com/github-production-release-asset-2e65be/5101141/6387d980-de1f-11e8-8d3e-4455415aa408?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20231015%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20231015T210023Z&X-Amz-Expires=300&X-Amz-Signature=6feb6195b9d110d4be0799f76e2e381c3173210eb93ced457bced0c1becc4ec2&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=5101141&response-content-disposition=attachment%3B%20filename%3Djq-linux64&response-content-type=application%2Foctet-stream [following]
  --2023-10-15 21:00:27--  https://objects.githubusercontent.com/github-production-release-asset-2e65be/5101141/6387d980-de1f-11e8-8d3e-4455415aa408?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20231015%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20231015T210023Z&X-Amz-Expires=300&X-Amz-Signature=6feb6195b9d110d4be0799f76e2e381c3173210eb93ced457bced0c1becc4ec2&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=5101141&response-content-disposition=attachment%3B%20filename%3Djq-linux64&response-content-type=application%2Foctet-stream
  Resolving objects.githubusercontent.com (objects.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
  Connecting to objects.githubusercontent.com (objects.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
  HTTP request sent, awaiting response... 200 OK
  Length: 3953824 (3.8M) [application/octet-stream]
  Saving to: ‘STDOUT’

       0K .......... .......... .......... .......... ..........  1% 9.07M 0s
      50K .......... .......... .......... .......... ..........  2% 9.28M 0s
     100K .......... .......... .......... .......... ..........  3% 75.9M 0s
     150K .......... .......... .......... .......... ..........  5% 41.0M 0s
     200K .......... .......... .......... .......... ..........  6% 14.5M 0s
starting download of artifact b97240eeb61bde8798445c3a1bee6ce1ab22afcdb2fc76162da088223e1f2fb1 : 6/11
Total number of files that will be downloaded: 1
starting download of artifact bfff4df7b9028ee660e7b58d64a9e6b10f77db2c7b136d419e5df897df2e577f : 7/11
Total number of files that will be downloaded: 1
starting download of artifact cd1fe3bb761ae833292c2ffc43117ae307fec08076ec5f4764071241902c1726 : 8/11
Total number of files that will be downloaded: 1
starting download of artifact d94c503bd1e3f5e13259eabf003eb8ec08a3d285fbfa520128ba25809855ea01 : 9/11
Total number of files that will be downloaded: 1
starting download of artifact ede039370d9719a6075054aa7f1d59e045d95db94ce982ac465d4cba7f398089 : 10/11
Total number of files that will be downloaded: 1
starting download of artifact f40a56632f833d2da570d3235db180dabc016e16dbb3e78ece200e490f7ae4b6 : 11/11
Total number of files that will be downloaded: 1
There were 11 artifacts downloaded
Artifact 013000256a173246685c48be3f081ed3cbb445c0399923b7c83cf0194ff8e553 was downloaded to /__w/nocaselist/nocaselist/013000256a173246685c48be3f081ed3cbb445c0399923b7c83cf0194ff8e553
Artifact 2bec8f88a51209dc0ef1ac6d01ce91f55b6d5c6c6ae39a2d509447488fc5f751 was downloaded to /__w/nocaselist/nocaselist/2bec8f88a51209dc0ef1ac6d01ce91f55b6d5c6c6ae39a2d509447488fc5f751
Artifact 71693cde4d349afe8d34a65b224c0b3be347dd524454a165ca9856f4c1046608 was downloaded to /__w/nocaselist/nocaselist/71693cde4d349afe8d34a65b224c0b3be347dd524454a165ca9856f4c1046608
Artifact 7677faf9c369236615efced6887231f50d9587c1b88c8f4de10bd7cd73c7f262 was downloaded to /__w/nocaselist/nocaselist/7677faf9c369236615efced6887231f50d9587c1b88c8f4de10bd7cd73c7f262
Artifact b6fcbca332cc00feb9f1a806d48c21b5f8410f4640ef3e1ef0d4e3e41bc21ecb was downloaded to /__w/nocaselist/nocaselist/b6fcbca332cc00feb9f1a806d48c21b5f8410f4640ef3e1ef0d4e3e41bc21ecb
Artifact b97240eeb61bde8798445c3a1bee6ce1ab22afcdb2fc76162da088223e1f2fb1 was downloaded to /__w/nocaselist/nocaselist/b97240eeb61bde8798445c3a1bee6ce1ab22afcdb2fc76162da088223e1f2fb1
Artifact bfff4df7b9028ee660e7b58d64a9e6b10f77db2c7b136d419e5df897df2e577f was downloaded to /__w/nocaselist/nocaselist/bfff4df7b9028ee660e7b58d64a9e6b10f77db2c7b136d419e5df897df2e577f
Artifact cd1fe3bb761ae833292c2ffc43117ae307fec08076ec5f4764071241902c1726 was downloaded to /__w/nocaselist/nocaselist/cd1fe3bb761ae833292c2ffc43117ae307fec08076ec5f4764071241902c1726
Artifact d94c503bd1e3f5e13259eabf003eb8ec08a3d285fbfa520128ba25809855ea01 was downloaded to /__w/nocaselist/nocaselist/d94c503bd1e3f5e13259eabf003eb8ec08a3d285fbfa520128ba25809855ea01
Artifact ede039370d9719a6075054aa7f1d59e045d95db94ce982ac465d4cba7f398089 was downloaded to /__w/nocaselist/nocaselist/ede039370d9719a6075054aa7f1d59e045d95db94ce982ac465d4cba7f398089
Artifact f40a56632f833d2da570d3235db180dabc016e16dbb3e78ece200e490f7ae4b6 was downloaded to /__w/nocaselist/nocaselist/f40a56632f833d2da570d3235db180dabc016e16dbb3e78ece200e490f7ae4b6
Artifact download has finished successfully
Run result="$(find . -name write_status -maxdepth 2 -exec cat {} \; | jq -c --slurp 'map(to_entries | map(.key as $matrix_key | .value | map_values({($matrix_key): .}))) | flatten | reduce .[] as $item ({}; . * $item)' )"
  result="$(find . -name write_status -maxdepth 2 -exec cat {} \; | jq -c --slurp 'map(to_entries | map(.key as $matrix_key | .value | map_values({($matrix_key): .}))) | flatten | reduce .[] as $item ({}; . * $item)' )"
  echo "result=${result}" >> $GITHUB_OUTPUT
  shell: bash --noprofile --norc -e -o pipefail {0}
/__w/_temp/13f6c6b9-4728-437e-bb29-2563cc40925d.sh: line 1: /__t/jq/jq: Permission denied
Error: Process completed with exit code 126.

Expected Behavior
The action should work.
Steps to Reproduce
Steps to reproduce the behavior:

Use the action in a python:3 container on ubuntu-latest

Screenshots
None, but the error can be seen here: https://github.com/pywbem/nocaselist/actions/runs/6526422703/job/17720181634
Environment (please complete the following information):
Anything that will help us triage the bug will help. Here are some ideas:

OS: ubuntu-latest of Github Actions, in python:3 container

Additional Context
None

@andy-maier, thanks for the bug report.
I'll pay attention next week.


Can't edit person

I lost the access(?) to edit a person. I.e. for some of the Instructor Training Trainees I wanted to add a note that they will be late with checkout because of whatever reason they emailed me about but when I click "Edit" on the person I get 403 Forbidden. I used to be able to edit (I think I'm an admin).

@apawlik please check now. As a workaround, I've given you superuser status.
This bug affects all people who don't have superuser status. This is because of this line. The permission name should be workshops.change_person, not workshops.edit_person.


Support to auto correct a lint

FIXME: broke monkey patch at lib/scss_lint/sass/tree.rb

the intention was not the current API, so the change was quite small to achieve the apply behaviour

change the monkey path to be less intrusive and all tests pass now

Hey @brauliobo,
There's a lot going on in this pull request without much documentation. From what I see, you are trying to do four separate things:

Replace scss-lint's monkey patching of Node#children with a separate linter_children call
Add support for automatically fixing lints? (the --apply flag name isn't very descriptive here. Other tools usually use the name --auto-correct)
Split MergeableSelector into separate linters (Why? An explanation of the purpose for this would be useful, as it introduces a backwards incompatibility with developers who configure MergeableSelector)
Add a new GroupableSelector linter (again, with no documentation--please add documentation to the linter README)

Please split these out into separate pull requests with clear descriptions of the problems they are trying to solve. This allows us to merge them individually without holding up the whole set due to problems/concerns with one of them.
Furthermore, you've probably noticed that the lint checks are not passing. Please ensure all RuboCop-related warnings are addressed before submitting a pull request. Thanks!

@sds, nice, gonna follow your advices, hope I can find some time soon.

@sds applied your suggestions
The first two suggestions is the this PR, as the Sass::Tree fix is core dependency for auto correcting
Just created the #535 and #536 for the last two.
Still there is Rubocop issues, sorry for this, I'm quite not used to it, will get used to it and fix the issues.

fixed rubocop warnings

Hey @brauliobo, thanks for the pull request. Really appreciate the effort to add support for something that I know a lot of users are looking for.
Sadly, I'm concerned with the general approach here. Relying on to_scss is not a viable option, as it will re-serialize the entire source code tree. As I've already explained in https://github.com/brigade/scss-lint/issues/343#issuecomment-70279869, other projects (such as rubocop) benefit from a better parse tree which can actually be changed at runtime and re-serialized without touching the rest of the source code. We don't have that flexibility with the sass gem here, so any solution will need to implement that from scratch (a huge undertaking, IMO).

Closing due to lack of response. Feel free to reopen if you can come up with a new approach!


[keyvault-keys] coverting tests to a package

@KarishmaGhiya I'm curious about why we want to do this! I think I've heard some of it, but I'd like to be on the same page. Please let me know if we can talk, or if you don't mind writing something down.


Add more Rhino activities and update SDK

Can we pretty please hold off on this one while we merge in https://github.com/specklesystems/speckle-sharp-connectors/pull/117?
There are some heavy updates in there that might make our life difficult!


ingress/gatewayapi: move construction of translators into hive cells

Currently, the "translators" that transform the internal ingress model (used by Gateway API & Ingress Controller) into respective Kubernetes resources (CiliumEnvoyConfig, core.Service & core.Endpoints) is constructed in the respective Ingress- or Gateway API reconcilers.
This clutters up all the intermediate "constructors" as there required configuration has to be passed down to their point of construction. This gets worse with every upcoming feature that needs some configuration.
Therefore, this PR moves the construction of the translators in the respective cells (ingress / gateway api) and passes the instances down to the reconcilers.
Please review the individual commits.

/test

/test

/ci-ipsec-upgrade


Windows pascal macro strikes again

I am very sorry to report that in my transition to V2 I am hitting the pascal macro as reported in #459.
My embedded SDK has a "units.hpp" header where I include the mp-units code, and the only includes are:
#include <mp-units/systems/si.h>
#include <mp-units/systems/iec80000.h>
#include <cnl/fixed_point.h>

I get the macro error in the header systems/include/mp-units/systems/si/unit_symbols.h
https://github.com/mpusz/mp-units/blob/77625d63cb105d7f7b50e058cff07411054db1d8/src/systems/include/mp-units/systems/si/unit_symbols.h#L321-L345
Compiler: clang-cl-18
platform: Windows 10

Related:

https://github.com/aurora-opensource/au/issues/284

#undef pascal seems to be the fix to do, in user code.
Though, from this search, it seems it might already be done? https://github.com/search?q=repo%3Ampusz%2Fmp-units+pascal&type=code

Though, from this search, it seems it might already be done? https://github.com/search?q=repo%3Ampusz%2Fmp-units+pascal&type=code

#undef pascal is in the header src/systems/include/mp-units/systems/si/units.h as a fix for #459.
But the header src/systems/include/mp-units/systems/si/unit_symbols.h also uses the name pascal and so also needs the same fix applied around the block of pascal unit symbols.
As a workaround I am un-defining pascal before including the mp-units headers, but since the fix was done in the library for the one instance it seems like the other should also be addressed in the library.


Fix: Wrong translation of paid in LHN after deleting last message

Details

The paid message in LHN is not translated correctly after deleting the last message. This PR fixes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/23380
PROPOSAL: https://github.com/Expensify/App/issues/23380#issuecomment-1649137325
Tests

Login with account A and B on different devices
On A, change language to Spanish
On B, request money to A
On A, click green button to pay
Verify that in LHN, paid text is in Spanish (i.e. pagó {amount} de otra forma)
Send a message to B
Delete that message
Verify that in LHN, paid text is in Spanish (i.e. pagó {amount} de otra forma)

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Login with account A and B on different devices
On A, change language to Spanish
On B, request money to A
Click green button to pay
On A, verify that in LHN, paid text is in Spanish (i.e. pagó {amount} de otra forma)
Send a message to B
Delete that message
Verify that in LHN, paid text is in Spanish (i.e. pagó {amount} de otra forma)

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/113963320/f8616e0e-42eb-4b59-b84e-7a02ba37da46

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/b5bc378e-8adc-4e64-8fdc-cc2c299decee

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/7c25c0e1-eb41-45a3-b27a-d6b0ccc15e5f

Desktop

https://github.com/Expensify/App/assets/113963320/aa48c399-d42b-4782-a0bd-8c5c27b19f1c

iOS

https://github.com/Expensify/App/assets/113963320/46dd67ee-9692-4647-af15-b575421872a7

Android

https://github.com/Expensify/App/assets/113963320/d7f69755-3a75-4c70-97bc-7e6f4d2adb86

There still some paid translations issues but this is inside chat report view, I think that will be another issue.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.48-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.49-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Question: How to get SolidColorBrush based on current ActualTheme in code?

Application.Current.Resources["ThemeBrush"] as SolidColorBrush always return ThemeBrush in Light theme.

What does the resource dictionary you defined "ThemeBrush" in look like?  I would expect this code to work.


Error in saving a model with fk value instead of related model.

You should be able to pass the underlying value, so course = await Course.objects.create(department=1) should work.
What happens in your case?

I see this error:
AttributeError: 'int' object has no attribute 'get'
post_info = {
    "title": "My post",
    "link": 1
}

self.post = await Post.objects.create(**post_info)

# Models
class Post(ormar.Model):
    id: int = ormar.Integer(primary_key=True)
    title: str = ormar.String(max_length=500)
    link: PageLink = ormar.ForeignKey(PageLink, related_name='posts', ondelete="CASCADE")

    class Meta(BaseMeta):
        tablename = 'posts'

class PageLink(ormar.Model):
    id: int = ormar.Integer(primary_key=True)
    value: str = ormar.String(max_length=2048)
    country: str = ormar.String(max_length=1000)

    def __str__(self):
        return f'{self.id}'

    class Meta(BaseMeta):
        tablename = 'pagelinks'

Stack:
  File ".../venv/lib/python3.9/site-packages/ormar/queryset/queryset.py", line 1018, in create
    new_kwargs = self.model.prepare_model_to_save(new_kwargs)
  File ".../venv/lib/python3.9/site-packages/ormar/models/mixins/save_mixin.py", line 40, in prepare_model_to_save
    new_kwargs = cls.substitute_models_with_pks(new_kwargs)
  File ".../venv/lib/python3.9/site-packages/ormar/models/mixins/save_mixin.py", line 130, in substitute_models_with_pks
    model_dict[field] = field_value.get(target_pkname)
AttributeError: 'int' object has no attribute 'get'

Originally posted by @Bilyalov in https://github.com/collerek/ormar/discussions/262#discussioncomment-1004065

Fixed by #280


Unable to set the ECMAScript language compatibility

When the extension is enabled, it very proactively tries to parse all the projects in the VSCode workspace. If the projects use a newer ECMAScript for JavaScript with for example import-commands, they are all marked as having syntax errors. After digging a bit I found that there is a configuration parameter that could be set as the server starts up (for example --js.ecmascript-version=2019) but I didn't find any way to set it. Did I miss something or is there another way to enable the compatibility?

closed by:
https://github.com/microsoft/vscode/issues/167505


feat(rust): Improve output of secure-channel list command

WIP -- fixes https://github.com/build-trust/ockam/issues/3391
Sample output:
ockam secure-channel list --at n3`

Secure Channels

    Secure Channel:
      • From: /node/n3
      •   To: /ip4/<IP_ADDRESS>/tcp/49501/service/api
      •   At: /service/55169a0c6d559137bb62165c65058304

    Secure Channel:
      • From: /node/n3
      •   To: /ip4/<IP_ADDRESS>/tcp/49509/service/api
      •   At: /service/b35f21a3935ddd5e4e92f0e29dee3547

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

@sanjayts the changes in this PR look great and ready to merge. Thank you for spending time on this!
We can merge after this one last step:

[ ] Accept the Ockam Contributor License Agreement by adding your Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

@mrinalwadhwa Awesome, thanks for taking your time to review this. I've created a new PR to accept the CLA. https://github.com/build-trust/ockam-contributors/pull/110

@sanjayts ah looks like there are some small clippy warning, could you fix those please before we merge https://github.com/build-trust/ockam/actions/runs/3099168825/jobs/5017984208

@mrinalwadhwa Done!

@sanjayts Thank you for an awesome first contribution 🥳 🎈

@mrinalwadhwa Thank you -- it has been a pleasant experience contributing so I would say you have done a great job with fostering a great open source culture for Ockam! :)


2d shapes demo Annulus not found

Bevy version
0.13.1
0.13.2
Relevant system information
2024-05-10T21:00:50.169484Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M3 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
2024-05-10T21:00:50.323233Z  INFO bevy_winit::system: Creating new window "App" (0v1)
2024-05-10T21:00:50.347980Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "MacOS 14.1 ", kernel: "23.1.0", cpu: "Apple M3 Pro", core_count: "12", memory: "36.0 GiB" }

cargo 1.78.0 (54d8815d0 2024-03-26)

What you did
I copied the examples from 2d shapes, added bevy as a dependency, and then tried to run cargo build and cargo run
The following occurred
error[E0433]: failed to resolve: use of undeclared type `Annulus`
  --> src/main.rs:32:33
   |
32 |         Mesh2dHandle(meshes.add(Annulus::new(25.0, 50.0))),
   |                                 ^^^^^^^ use of undeclared type `Annulus`

What went wrong
To "fix" the issue, to get the example to build I had to remove the Annulus from the example code. I could not find a working version or feature that included the shape. am I missing something?
Additional information
[package]
name = "candlehopper"
version = "0.1.0"
edition = "2021"

# Enable a small amount of optimization in debug mode
[profile.dev]
opt-level = 1

# Enable high optimizations for dependencies (incl. Bevy), but not for our code:
[profile.dev.package."*"]
opt-level = 3

[workspace]
resolver = "2" # Important! wgpu/Bevy needs this!

[dependencies]
bevy = "0.13.1"
bevy_pancam = "0.11.0"
kd-tree = "0.5.3"
rand = "0.8.5"
typenum = "1.17.0"

The Annulus shape (2d ring) was added since 0.13 pr however the examples on main are updated with all changes. Annulus will be in 0.14, if you want to see examples from previous versions you can go to that branch and check it out there, for example the 0.13 shapes.

@13ros27 @alice-i-cecile Thank you for the info! Is there somewhere I can look to find information like that in the future? I'm just getting started with Bevy and was pulling my hair out for a moment trying to figure out what I was doing wrong. It seems a little strange to me to integrate unreleased features into the examples.
My hot take:  that kind of thing is for sure likely to lead to un-needed issues getting created (like this one), and trip up newcomers (me). It's not at all obvious that I should have to go to previous versions to find a stable example to start from (or if it is, please educate me).
Thank you again!

Unfortunately this is largely a limitation of how Github works. The "default branch that contributors see and make PRs to" does not reflect the latest release. I've experimented elsewhere with a dev branch and it resulted in significant other confusion :(
We've attempted to make the warning as prominent as we can (see https://github.com/bevyengine/bevy/tree/main/examples#examples) and have even created our own examples outside of Github at https://bevyengine.org/examples/. On Github, looking at the latest tag resolves this as well.

That makes sense -- In the future I'll make sure to look at the latest tag for examples, that's good advice. Thank you for the patience with my liberal application of hot take. 😹
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Alice Cecile @.>
Sent: Sunday, May 12, 2024 12:12:02 PM
To: bevyengine/bevy @.>
Cc: Parker Jones @.>; Author @.>
Subject: [Ext] Re: [bevyengine/bevy] 2d shapes demo Annulus not found (Issue #13324)
Unfortunately this is largely a limitation of how Github works. The "default branch that contributors see and make PRs to" does not reflect the latest release. I've experimented elsewhere with a dev branch and it resulted in significant other confusion :(
We've attempted to make the warning as prominent as we can (see https://github.com/bevyengine/bevy/tree/main/examples#examples) and have even created our own examples outside of Github at https://bevyengine.org/examples/. On Github, looking at the latest tag resolves this as well.
—
Reply to this email directly, view it on GitHubhttps://github.com/bevyengine/bevy/issues/13324#issuecomment-2106302640, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABMV2MM6UOMUNJB2QCBLZBTZB6IFFAVCNFSM6AAAAABHRIHRUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGMYDENRUGA.
You are receiving this because you authored the thread.Message ID: @.***>


restruction of the hair

Hi,Yufeng!This is groundbreaking work, but I have a question: how do you reconstruct parts of the flame model that are not included in the reconstruction process, including the hair?Can you get back to me if you are free?
best wish

hi,
IMavatar's geometry is not limited by the FLAME model. We only leverage FLAME's deformation scheme (blendshape + LBS). Therefore, as long as the hair does not have non-rigid deformation that cannot be explained by the head transformation, the method will work fine.


Date format not working on mobile

Hi Lesilent,
The datepicker works great when in full browser mode, but when you run the same code on a mobile device (or even the emulator in Edge: i.e. select the 3-dots Setting and More to display the menu and then select More Tools | Developer Tools | and click the Toggle Device Emulation), it looks like the default browser date picker appears instead of the datepicker-bs4.
You can see this also happening on your demo page. Make sure that when you run the emulation mode, you need to refresh the page to reset the control to display the issue (if you just toggle the emulator option on, it will display the mask and datepicker-bs4 correctly).
Anyway, I've been using the datepicker-bs4 for a while in development and just noticed this since I'm finally to the point of production ready. Is this something with the browser/bootstrap or the datepicker-bs4 needs to be tweaked?
Tks... :)

This was due to the minScreenWidth option that has a default of 576 pixels. That means any screen widths less than that would use the browser's native date picker instead. I've removed this option from the new version, so it should work on a mobile device now.


词性标注，哪里有介绍它们代表的是什么词性？['VBZ', 'DT', 'DT', 'NN', 'IN', 'NN', 'NN', '.']]

[auto-reply] Thanks for your comment. However, the essential information is required. Please carefully fill out the form then reopen it.


Ceph OSD stats checks fail to get metrics

The ceph osd check fails to get metrics because the string passed in is incorrect.

Needs a kilo backport

Ahh sorry missed you'd already done it @byronmccollum - I'll close off my branch and I've +2'd your kilo backport.

Cheers

The backport got pulled in by master-kilo sync PR https://github.com/rcbops/rpc-openstack/pull/718. Closing backport PR and this issue


Can't find mongo cxx legacy driver 1.10+

Execuse, where can I download the "mongo cxx legacy driver 1.10+"?
The latest version of "legacy" I find is 1.1.2.

I would believe the 1.1.2 version will also work, as long as it is on the legacy API.
Dong

From: lifeng10 @.>
Sent: Monday, September 11, 2023 9:46 AM
To: InitialDLab/SEAL-ORAM @.>
Cc: Subscribed @.***>
Subject: [InitialDLab/SEAL-ORAM] Can't find mongo cxx legacy driver 1.10+ (Issue #4)
Execuse, where can I download the "mongo cxx legacy driver 1.10+"?
The latest version of "legacy" is 1.1.2.
—
Reply to this email directly, view it on GitHubhttps://github.com/InitialDLab/SEAL-ORAM/issues/4, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAF3QJWA3LFDX6P2BXQUH4DXZ4IZRANCNFSM6AAAAAA4TLTCMA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>