International language support

Hi @saadq, great project! :smile:
I found that some letters, for example ČĆŽŠĐčćžšđ, are not displayed properly.
Regards,
Herman

And can't display Chinese for now.

Hey @mintisan could you provide a couple of example input characters so that I can test that out as well?

+1
Hope It can support CJK

@saadq Here are some characters you can use.
Traditional Chinese: 國際語言支持
Simplified Chinese: 国际语言支持
I'm not sure how people display Chinese character with pdflatex. I use xelatex but it's not compatible with microtype, which is used in this project.

Yea

and how about i18n?

Hey all, I've been working on the resume generator's second version for awhile now. The new version will hopefully have multilanguage support and I will be planning to add i18n to allow the site to work in different languages and such. Looking forward to sharing the new version with you all very soon!

From what I understand, in template2, template4, template6. we only need to add
\usepackage{xeCJK}
\setCJKmainfont{Source Han Sans}

in their index.js to support Unicode.

Related is just displaying generic unicode characters. I was trying to add stars next to skills and ran into display issues e.g. Git ★★★★☆


afterUpdate event triggered first, then afterCreat when a db row is created with many to many fields

Sails version: 0.12.7
Node version:  6.9.2
NPM version: 3.10.9
Operating system: ubuntu 16.4 LTS

I have two models User and Tag
In User Model, the association is like:
tags: {
        collection: 'tag',
	via: 'users',
	dominant: true
}

When I hit the /user with data
{
"key1": "value1",

"tags": [1, 2, 3]
}

I got the afterUpdate event first and afterCreate event later.
which breaks some of my application logic.

+1

any comments @particlebanana @mikermcneil

@aptro you get the afterUpdate and afterCreate lifecycle callbacks triggering on the User model?
The afterUpdate from the Tag model will be triggered because it's updating a tag record and setting the foreign key. Unless this is a many-to-many association.

@particlebanana yes for the user model  I got the afterUpdate first and then the afterCreate callback.


Super expression must either be null or a function, not undefined

Hello!
Trying to plug this component in, but it gives an error: Uncaught TypeError: Super expression must either be null or a function, not undefined.
Tried to add constructor(props) { super(props); } but no success.
I'm using React v0.14.3, React-Leaflet v0.9.0

Maybe, we should inherit from a different base component?

+1

Probably my problem is that this library is using React-leaflet 0.8 and I'm using v0.10 which doesn't have PopupContainer as @romanenko mentioned.

+1

This should be fixed in version 0.1.8


Phreshistant app added, PhreshPlayer app icon fix.

@Phreshhh This PR seems to be causing some conflicts; can you please merge master into your fork and resolve the conflicts? Otherwise, everything else looks good. 👍

Closing via #561


Create JPA extension

Feature description
Many projects out there are in need for creating JPA entities in tests. This is usually the case for database integration tests where entity objects need to be created and persisted. It can also be the case in business layer unit tests that require entity instances for mocking repository methods.
It would be great if we could use Instancio to create entity instances that can optionally be persisted later on.
Order order = Instancio.of(Order.class)
    .withSettings(Settings.create().set(JpaKeys.METAMODEL, metamodel))
    .create();

entityGraphPersister.persist(order);

Changes made in the core library to support the extension. Details in #528.

Hey @armandino, I've added a comment to the PR 2 weeks ago. Looks like you haven't seen it, could you take a look? 😄

Hi @Mobe91! I saw your comment, but haven't had much time to investigate. I'll look into it soon :)

For anyone looking for a way to use Instancio with JPA, check this out.


Added phpdoc return types to Unit::to() and Unit::nearest()

This change improves the IDE autocompletion features with this project.

phpdoc's are actually far from complete as you might have noticed, would you maybe have time to take a look at more of them?

Yes, I will take a closer look at this in the next days.

@pimlie Thanks to @JoshuaBehrens there are now a lot more phpdocs throughout the project. Will this be sufficient?

@jkrzefski @JoshuaBehrens Many thanks to both of you for all your work on this!


FunctionDataFetch throws InvocationException.cause property when available

This allows thrown GraphQLException instances to be handled by
graph-java as it would if thrown directly by a DataFetcher lambda.

I'm working on a prototype for an API gateway, a snippet of my login resolve is as follows
        val body = /* Usernam and password json object*/
        client.post(/* port */, /* domain */, /* path */)
            .putHeader("Accept", "application/json")
            .putHeader("Content-Type", "application/json")
            .sendJsonObject(body, {ar -> tokenFuture.complete(ar); })

        val response = tokenFuture.get()
        val result = response.result()

        if (result.statusCode() != 200) {
            throw GraphQLException("Username and password combination failed.")
        }

When Implementing directly with Graphql-Java's DataFetchers the error messages would appear as expected.
{
  "data": null,
  "errors": [
    {
      "message": "Exception while fetching data (/login) : Username and password combination failed.",
      "locations": [
        {
          "line": 6,
          "column": 3
        }
      ],
      "path": [
        "login"
      ]
    }
  ]
}

However, when Implemented using this library  it would get null for the exception details.
{
  "data": null,
  "errors": [
    {
      "message": "Exception while fetching data (/login) : null",
      "locations": [
        {
          "line": 6,
          "column": 3
        }
      ],
      "path": [
        "login"
      ]
    }
  ]
}

Update:
I've added tests, and remove changes to the async branch. The message is already included in the ExecutionException that is thrown by that branch. And I didn't want to add another layer of synchronization just to clean up the error messages.

This seems like a good add to me.
I added this in the example to debug and you are correct. It does show up as null. I think we can forward these exceptions.
fun throwsIfTrue(throwException: Boolean): String {
        if (throwException) {
            throw MyException("Passed in a true value")
        }

        return "Hello!"
    }

@smyrick I've added tests and updated the description.

@smyrick Are there any other changes you'd like to see?


HUD is not appearing

Hi,
I got this error from logs:
I/flutter (29162): Another exception was thrown: BoxConstraints forces an infinite height.
I/flutter (29162): Another exception was thrown: RenderBox was not laid out: RenderConstrainedBox#5e18e relayoutBoundary=up15 NEEDS-PAINT
I/flutter (29162): Another exception was thrown: RenderBox was not laid out: RenderSemanticsAnnotations#32bdb relayoutBoundary=up14 NEEDS-PAINT
I/flutter (29162): Another exception was thrown: RenderBox was not laid out: RenderPointerListener#980e2 relayoutBoundary=up13 NEEDS-PAINT
I/flutter (29162): Another exception was thrown: RenderBox was not laid out: RenderSemanticsGestureHandler#24ed8 relayoutBoundary=up12 NEEDS-PAINT
I/flutter (29162): Another exception was thrown: RenderBox was not laid out: RenderExcludeSemantics#76cbb relayoutBoundary=up11 NEEDS-PAINT
I/flutter (29162): Another exception was thrown: RenderBox was not laid out: RenderBlockSemantics#56409 relayoutBoundary=up10 NEEDS-PAINT
I/flutter (29162): Another exception was thrown: RenderBox was not laid out: RenderOpacity#6bd88 relayoutBoundary=up9 NEEDS-PAINT

This may be a problem with layout of your screen. If !inAsyncCall, modal_progress_hud does nothing:
https://github.com/mmcc007/modal_progress_hud/blob/8ab3fa868611c934a6688be153cd08b3f521def8/lib/modal_progress_hud.dart#L49
To verify this, you could try removing modal_progress_hud and confirm your screen layout is working.


[FLINK-19626][table-planner-blink] Introduce multi-input operator construction algorithm

What is the purpose of the change
As multiple input exec nodes have been introduced, we're going to construct multiple input operators by a new construction algorithm. This PR introduces such algorithm.
Multiple input optimization is currently not use by default and is only used for tests as its operator is not ready. We'll change this once the multiple input operator is ready.
Brief change log

Introduce multi-input operator construction algorithm

Verifying this change
This change added tests and can be verified as follows: Run the newly added tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Azure passed in https://dev.azure.com/tsreaper96/Flink/_build/results?buildId=100&view=results


Error with MirroredStrategy

Hello! Please help!
I have problem with using Mirrored Strategy on tensorflow-rocm. When I try use it I get next error:
WARNING:tensorflow:Using temporary folder as model directory: /tmp/tmpszzzlis4
INFO:tensorflow:Using config: {'_save_checkpoints_steps': None, '_device_fn': None, '_is_chief': True, '_train_distribute': <tensorflow.contrib.distribute.python.mirrored_strategy.MirroredStrategy object at 0x7ff9da20a470>, '_save_checkpoints_secs': 600, '_keep_checkpoint_every_n_hours': 10000, '_model_dir': '/tmp/tmpszzzlis4', '_num_ps_replicas': 0, '_cluster_spec': <tensorflow.python.training.server_lib.ClusterSpec object at 0x7ff9da20a3c8>, '_tf_random_seed': None, '_session_config': None, '_global_id_in_cluster': 0, '_keep_checkpoint_max': 5, '_evaluation_master': '', '_service': None, '_task_type': 'worker', '_master': '', '_num_worker_replicas': 1, '_save_summary_steps': 100, '_log_step_count_steps': 100, '_task_id': 0}
INFO:tensorflow:Device is available but not used by distribute strategy: /device:CPU:0
INFO:tensorflow:Device is available but not used by distribute strategy: /device:XLA_CPU:0
INFO:tensorflow:Configured nccl all-reduce.
INFO:tensorflow:Calling model_fn.
INFO:tensorflow:Calling model_fn.
INFO:tensorflow:batch_all_reduce invoked for batches size = 2 with algorithm = nccl and num_packs = 1
INFO:tensorflow:Done calling model_fn.
INFO:tensorflow:Done calling model_fn.
INFO:tensorflow:Create CheckpointSaverHook.
INFO:tensorflow:Graph was finalized.

---------------------------------------------------------------------------
InvalidArgumentError                      Traceback (most recent call last)
~/.conda/envs/py35/lib/python3.5/site-packages/tensorflow/python/client/session.py in _do_call(self, fn, *args)
   1321     try:
-> 1322       return fn(*args)
   1323     except errors.OpError as e:

~/.conda/envs/py35/lib/python3.5/site-packages/tensorflow/python/client/session.py in _run_fn(feed_dict, fetch_list, target_list, options, run_metadata)
   1304       # Ensure any changes to the graph are reflected in the runtime.
-> 1305       self._extend_graph()
   1306       return self._call_tf_sessionrun(

~/.conda/envs/py35/lib/python3.5/site-packages/tensorflow/python/client/session.py in _extend_graph(self)
   1339       with self._graph._lock:  # pylint: disable=protected-access
-> 1340         tf_session.ExtendSession(self._session)
   1341     else:

InvalidArgumentError: No OpKernel was registered to support Op 'NcclAllReduce' with these attrs.  Registered devices: [CPU,GPU,XLA_CPU], Registered kernels:
  <no registered kernels>

	 [[Node: NcclAllReduce_1 = NcclAllReduce[T=DT_FLOAT, num_devices=2, reduction="sum", shared_name="c0", _device="/device:GPU:1"](split_1)]]

But before It I had
2019-01-14 13:32:47.678855: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1562] Adding visible gpu devices: 0, 1
2019-01-14 13:32:47.681763: I tensorflow/core/common_runtime/gpu/gpu_device.cc:989] Device interconnect StreamExecutor with strength 1 edge matrix:
2019-01-14 13:32:47.681978: I tensorflow/core/common_runtime/gpu/gpu_device.cc:995]      0 1
2019-01-14 13:32:47.682131: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1008] 0:   N N
2019-01-14 13:32:47.682457: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1008] 1:   N N
2019-01-14 13:32:47.682841: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1124] Created TensorFlow device (/device:GPU:0 with 3540 MB memory) -> physical GPU (device: 0, name: Ellesmere [Radeon RX 470/480], pci bus id: 0000:01:00.0)
2019-01-14 13:32:47.683324: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1124] Created TensorFlow device (/device:GPU:1 with 3540 MB memory) -> physical GPU (device: 1, name: Ellesmere [Radeon RX 470/480], pci bus id: 0000:02:00.0)
2019-01-14 13:32:48.417036: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1562] Adding visible gpu devices: 0, 1
2019-01-14 13:32:48.417420: I tensorflow/core/common_runtime/gpu/gpu_device.cc:989] Device interconnect StreamExecutor with strength 1 edge matrix:
2019-01-14 13:32:48.417511: I tensorflow/core/common_runtime/gpu/gpu_device.cc:995]      0 1
2019-01-14 13:32:48.417561: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1008] 0:   N N
2019-01-14 13:32:48.417589: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1008] 1:   N N
2019-01-14 13:32:48.417691: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1124] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 3540 MB memory) -> physical GPU (device: 0, name: Ellesmere [Radeon RX 470/480], pci bus id: 0000:01:00.0)
2019-01-14 13:32:48.417891: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1124] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:1 with 3540 MB memory) -> physical GPU (device: 1, name: Ellesmere [Radeon RX 470/480], pci bus id: 0000:02:00.0)

Early I have same error when I try use Conv2, but now this error fixed. May be purge mivisionx helped, I don't know.
cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS"

sudo dpkg -l | grep linux-headers | grep ii | awk '{print $3}'
4.15.0-29.31
4.15.0-29.31
4.15.0-43.46
4.15.0-43.46
4.18.0-13.14~18.04.1
4.18.0-13.14~18.04.1
4.20.0-rc6-18.12.13.amdgpu.ubuntu-3
<IP_ADDRESS>.45

dmesg | grep kfd
[    2.530090] kfd kfd: Allocated 3969056 bytes on gart
[    2.530200] kfd kfd: added device 1002:67df
[    3.728838] kfd kfd: Allocated 3969056 bytes on gart
[    3.729021] kfd kfd: added device 1002:67df

dmesg | grep amd
[    0.000000] Linux version 4.20.0-rc6-18.12.13.amdgpu.ubuntu (martin@Main-PC) (gcc version 8.2.0 (Ubuntu 8.2.0-7ubuntu1)) #3 SMP Thu Dec 13 08:21:34 CET 2018 ()
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-4.20.0-rc6-18.12.13.amdgpu.ubuntu root=UUID=de3fa24f-c974-4d46-8e3e-2fd1b16c8037 ro quiet splash vt.handoff=1
[    0.032478] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-4.20.0-rc6-18.12.13.amdgpu.ubuntu root=UUID=de3fa24f-c974-4d46-8e3e-2fd1b16c8037 ro quiet splash vt.handoff=1
[    1.007090] usb usb1: Manufacturer: Linux 4.20.0-rc6-18.12.13.amdgpu.ubuntu xhci-hcd
[    1.009076] usb usb2: Manufacturer: Linux 4.20.0-rc6-18.12.13.amdgpu.ubuntu xhci-hcd
[    1.065442] usb usb3: Manufacturer: Linux 4.20.0-rc6-18.12.13.amdgpu.ubuntu xhci-hcd
[    1.065735] usb usb4: Manufacturer: Linux 4.20.0-rc6-18.12.13.amdgpu.ubuntu xhci-hcd
[    1.067414] pcie_mp2_amd: AMD(R) PCI-E MP2 Communication Driver Version: 1.0
[    1.338311] [drm] amdgpu kernel modesetting enabled.
[    1.338564] amdgpu 0000:01:00.0: enabling device (0000 -> 0003)
[    1.340251] amdgpu 0000:01:00.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=none:owns=none
[    2.341698] amdgpu 0000:01:00.0: VRAM: 4096M 0x000000F400000000 - 0x000000F4FFFFFFFF (4096M used)
[    2.341699] amdgpu 0000:01:00.0: GART: 256M 0x000000FF00000000 - 0x000000FF0FFFFFFF
[    2.341790] [drm] amdgpu: 4096M of VRAM memory ready
[    2.341791] [drm] amdgpu: 2860M of GTT memory ready.
[    2.533827] [drm] Initialized amdgpu 3.27.0 20150101 for 0000:01:00.0 on minor 1
[    2.533887] amdgpu 0000:02:00.0: enabling device (0000 -> 0003)
[    3.537911] amdgpu 0000:02:00.0: VRAM: 4096M 0x000000F400000000 - 0x000000F4FFFFFFFF (4096M used)
[    3.537913] amdgpu 0000:02:00.0: GART: 256M 0x000000FF00000000 - 0x000000FF0FFFFFFF
[    3.539349] [drm] amdgpu: 4096M of VRAM memory ready
[    3.539351] [drm] amdgpu: 2860M of GTT memory ready.
[    3.732449] [drm] Initialized amdgpu 3.27.0 20150101 for 0000:02:00.0 on minor 2

Thanks

@mnvmld  if you install from pypl, you'll go for the latest TF public release, at the time being, it's r1.12-rocm.
It looks like your issue might be resolved in our development branch.
Can you try to rebuild tensorflow using the develop-upstream branch? Instructions are here:
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/develop-upstream/rocm_docs/tensorflow-build-from-source.md
I'll close the ticket, for now, feel free to reopen it if you still see issues there.

@mnvmld if you install from pypl, you'll go for the latest TF public release, at the time being, it's r1.12-rocm.
It looks like your issue might be resolved in our development branch.
Can you try to rebuild tensorflow using the develop-upstream branch? Instructions are here:
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/develop-upstream/rocm_docs/tensorflow-build-from-source.md
I'll close the ticket, for now, feel free to reopen it if you still see issues there.

Thanks. I reinstalled tensorflow-rocm from githab. Pypl gave me only version 0.8... Now I have v1.12. Problem is resolved.


[RFC] Add AVX512VNNI support for TVM

As title says.

It appears that the CI test is not using LLVM 8.0 or higher version, thus not support AVX512 VNNI instructions.

Perhaps a good time to update the CI infra to keep up with LLVM mainline, see steps in https://docs.tvm.ai/contribute/pull_request.html#ci-environment

Because we need the test case to work for all environments, please add a feature detection step to skip the test if VNNI is not yet available.

@jianyuh can you add a pre-condition to the test cases so it skips the test when LLVM8 is not enabled? You can use https://github.com/dmlc/tvm/blob/9bfdc55c572e03f6cfac6994a9e75f8fd9252850/python/tvm/intrin.py#L193 to lookup the intrinsic to see if it is available.

@tqchen Will update this soon (sorry for being busy with some other things recently).

My PR was based on the previous version of TVM. Not sure what are the recent changes for TVM.

http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3388/6/pipeline/
Not sure why “llvm.x86.avx512.pmaddubs.w.512“ (AVX512 instruction, not VNNI instruction) is not recognized as an LLVM intrinsic.

http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3388/7/pipeline
When I use tensorize routine and pass in “dot_16x1x16_int8_int8_int32” function (the original AVX512 implementation for uint8 x int8 multiplication), it reports “TVMError: Check failed: type_code_ == kNodeHandle (10 vs. 8) : expected NodeHandle but get FunctionHandle“ error.

Any insights about what might be wrong here? Thanks for advance!

I will update the CI to add LLVM8 this week.
Hi @tqchen, is there any update on the LLVM8 front? We are also looking into this and have similar test issue.

http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3388/6/pipeline/
Not sure why “llvm.x86.avx512.pmaddubs.w.512“ (AVX512 instruction, not VNNI instruction) is not recognized as an LLVM intrinsic.

This is happening because the LLVM version is 6.0 in CI as Tianqi mentioned. You can skip the test by perform the intrinsic lookup as shown in the above post.

@jianyuh can you look into the CI error?

I am not sure if tensorize is a good way to suport VNNI:

VNNI is not true tensorization, though reduction dimension is introduced. It still operates on 1-D inputs. Due to the design of tensorization interface, you need to provide the declared intrin the shape of tensors offloaded, but essentially they are 1-D.

Another thing I am worrying about is imperfect tiling. Since tensorize cuts off the whole loop body down, without being aware of the loop body replaced. Thus, it is hard to extend this to imperfect tiling case.

@tqchen : Will take a look soon. Let me know if this PR becomes the blockers for other things.
The current failure is shown as the following:

http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3388/7/pipeline
When I use tensorize routine and pass in “dot_16x1x16_int8_int8_int32” function (the original AVX512 implementation for uint8 x int8 multiplication), it reports “TVMError: Check failed: type_code_ == kNodeHandle (10 vs. 8) : expected NodeHandle but get FunctionHandle“ error.

Sorry I am not familiar with TVM code base. Do you have any insights about what are NodeHandle/FunctionHandle here?

It could due to wrong types of arguments being passed to the tensor intrinsic. The corresponding function requires a NodeRef subtype but instead get a PackedFunc

I can run the correct result locally. Also updated the summary part for this PR to report the performance results.
However, I had the same issue as https://github.com/dmlc/tvm/issues/3598 for the OSS compilation error (http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3388/11/pipeline).

TVMError: Check failed: is_one(e.region[i]->extent): Tensorize tensor_intrin: Input dimension mismatch with tensor intrin  expected shape=[16, 4], given region=[range(min=((j.outer16)/16), ext=(((((j.outer16) + 15)/16) + 1) - j.outer)), range(min=(((((k.outer.outer4) + k.outer.inner)4)/4)16), ext=((((((((k.outer.outer16) + (k.outer.inner4)) + 3)/4)16) + 16) - (k.outer.inner16)) - (k.outer.outer64))), range(min=0, ext=4)]
Any temporary workaround for that? cc @tqchen , @anijain2305 .

I am not sure if tensorize is a good way to suport VNNI:

VNNI is not true tensorization, though reduction dimension is introduced. It still operates on 1-D inputs. Due to the design of tensorization interface, you need to provide the declared intrin the shape of tensors offloaded, but essentially they are 1-D.
Another thing I am worrying about is imperfect tiling. Since tensorize cuts off the whole loop body down, without being aware of the loop body replaced. Thus, it is hard to extend this to imperfect tiling case.

@were : You are right. I report the current performance of the implementation in this PR in the summary. Not sure how to overcome the limitation of TVM. cc @tqchen @anijain2305

Similar to @anijain2305 's PR (https://github.com/dmlc/tvm/pull/3516), currently we disable the AVX512 VNNI test in this PR.
Posted the question on tensorize failure in https://discuss.tvm.ai/t/workaround-for-tensorize-failure/3577.

@FrozenGene @tqchen @anijain2305  @llyfacebook @were Ping for review.

If we have time, we could investigate why we couldn't achieve 252GFlops even more. Only 73% hardware efficiency means we have much work could dive.

@jianyuh please act on the review comments @were please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

If we have time, we could investigate why we couldn't achieve 252GFlops even more. Only 73% hardware efficiency means we have much work could dive.

252 Gops/s is a reasonable number as this is ~90% hardware efficiency. Currently FBGEMM and MKL-DNN can reach this number. For the current PR, the reason is that we didn't fully utilize the accumulation in vpdpbusd instruction, and we get 205.6 Gops/s (73% efficiency).

@jianyuh please act on the review comments @were please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

@jianyuh please act on the review comments @were please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

I addressed the comments by @FrozenGene . For @were 's comment, I took a try but somehow I got lower performance. I think it might be related to various TVM code pieces, so it might take more efforts to address. I will take a look when I have time, but it might be slow. Maybe it is better to first ship this PR and add another PR later for optimizing the performance.

Thanks @jianyuh @were @FrozenGene this PR is now merged

Hi @jianyuh  I am getting following error when I try to run my benchmark. It gives following error,
LLVM ERROR: Cannot select: 0x23809ef0: v16i32 = X86ISD::VPDPBUSD 0x210a09a8, 0x210a02c0, 0x19eb81b0
  0x210a09a8: v16i32 = BUILD_VECTOR Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
  0x210a02c0: v16i32 = X86ISD::VBROADCAST 0x1da48690
    0x1da48690: i32,ch = load<(load 4 from %ir.scevgep54, !tbaa !553)> 0x21cfaeb8, 0x23879d70, undef:i64
      0x23879d70: i64 = add 0x19eb83b8, Constant:i64<-224>
        0x19eb83b8: i64 = add 0x1da47da0, 0x19eb8218
          0x1da47da0: i64,ch = CopyFromReg 0x21cfaeb8, Register:i64 %50
            0x23879b68: i64 = Register %50
          0x19eb8218: i64,ch = CopyFromReg 0x21cfaeb8, Register:i64 %52
            0x1da47a60: i64 = Register %52
        0x1da478c0: i64 = Constant<-224>
      0x2254ed88: i64 = undef
  0x19eb81b0: v16i32,ch = load<(load 64 from %ir.lsr.iv35, !tbaa !556)> 0x21cfaeb8, 0x2387a1e8, undef:i64
    0x2387a1e8: i64,ch = CopyFromReg 0x21cfaeb8, Register:i64 %51
      0x2254e6a0: i64 = Register %51
    0x2254ed88: i64 = undef
In function: __tvm_parallel_lambda.85

Was wondering if you ever saw this. Let me know. I will try to debug on my end.

Hi @jianyuh I am getting following error when I try to run my benchmark. It gives following error,
LLVM ERROR: Cannot select: 0x23809ef0: v16i32 = X86ISD::VPDPBUSD 0x210a09a8, 0x210a02c0, 0x19eb81b0
  0x210a09a8: v16i32 = BUILD_VECTOR Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>, Constant:i32<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
    0x23809a10: i32 = Constant<0>
  0x210a02c0: v16i32 = X86ISD::VBROADCAST 0x1da48690
    0x1da48690: i32,ch = load<(load 4 from %ir.scevgep54, !tbaa !553)> 0x21cfaeb8, 0x23879d70, undef:i64
      0x23879d70: i64 = add 0x19eb83b8, Constant:i64<-224>
        0x19eb83b8: i64 = add 0x1da47da0, 0x19eb8218
          0x1da47da0: i64,ch = CopyFromReg 0x21cfaeb8, Register:i64 %50
            0x23879b68: i64 = Register %50
          0x19eb8218: i64,ch = CopyFromReg 0x21cfaeb8, Register:i64 %52
            0x1da47a60: i64 = Register %52
        0x1da478c0: i64 = Constant<-224>
      0x2254ed88: i64 = undef
  0x19eb81b0: v16i32,ch = load<(load 64 from %ir.lsr.iv35, !tbaa !556)> 0x21cfaeb8, 0x2387a1e8, undef:i64
    0x2387a1e8: i64,ch = CopyFromReg 0x21cfaeb8, Register:i64 %51
      0x2254e6a0: i64 = Register %51
    0x2254ed88: i64 = undef
In function: __tvm_parallel_lambda.85

Was wondering if you ever saw this. Let me know. I will try to debug on my end.

I haven't seen such errors. Previously I had one issue (https://discuss.tvm.ai/t/workaround-for-tensorize-failure/3577) with your previous observation (https://github.com/dmlc/tvm/issues/3598). I rebased on top of a previous version of TVM (the version https://github.com/dmlc/tvm/pull/3081 is based, which is released in April 2019), and it worked fine.


appbundle java.lang.UnsatisfiedLinkError

Hello,
My app is crashing on some devices with the following errors:
java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.thatappdev.ninjavpn-1i05C_s4br4zSKxX8CQi1g==/base.apk", zip couldn't find "libflutter.so"
Full log uploaded to google drive:
https://drive.google.com/file/d/1vVZNItrajyMZQxlsYYkmqVuaE2MdBxQs/view?usp=sharing
I have tried multiple solutions mentioned by people, such as adding ndk abifilters etc but that didn't solve the issue and I'm lost.
I hope you could kindly help me, thank you.
Update: I referred to another solution with --no-shrink , that doesn't solve the issue.

Hi @andyyyyyyyyyyyyyyyy
can you please provide your flutter doctor -v ,
your flutter build appbundle --verbose
and your pubspec.yaml
or if possible a reproducible minimal code sample.
Thank you

Hi @andyyyyyyyyyyyyyyyy
can you please provide your flutter doctor -v ,
your flutter build appbundle --verbose
and your pubspec.yaml
or if possible a reproducible minimal code sample.
Thank you

Hi @iapicca  ,
flutter doctor -v :
$ flutter doctor -v
[√] Flutter (Channel master, v1.15.4-pre.169, on Microsoft Windows [Version 10.0.18363.720], locale en-SG)
    • Flutter version 1.15.4-pre.169 at D:\flutter
    • Framework revision 492fb6381e (5 weeks ago), 2020-02-25 22:29:16 -0500
    • Engine revision 888a62cf22
    • Dart version 2.8.0 (build 2.8.0-dev.10.0 73f6d15665)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\Andy\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 44.0.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] VS Code (version 1.43.2)
    • VS Code at C:\Users\Andy\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.8.1

[√] Connected device (2 available)
    • Chrome     • chrome     • web-javascript • Google Chrome 80.0.3987.149
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

flutter build appbundle --verbose

https://drive.google.com/file/d/123jfG1EWKgaAB4euMfJjFLD-A0s7QXV0/view?usp=sharing

pubspecl.yaml

name: ninjavpn
description: A new Flutter project.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.1.0+4045

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  flutter_vpn: ^0.7.0
  font_awesome_flutter: 8.4.0
  country_icons: 1.1.1
  provider: 3.2.0
  loading_overlay: 0.2.0

  cloud_firestore: 0.13.4+1
  intro_slider: ^2.2.9
  firebase_auth: ^0.15.5+2
  shared_preferences: ^0.5.6+3

  package_info: ^0.4.0+16

  firebase_admob: 0.9.2+1
  rate_my_app: ^0.6.0+2

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.3

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_launcher_icons: ^0.7.4

flutter_icons:
  android: true
  ios: true
  image_path: "dev_assets/icon.png"
  adaptive_icon_background: "#03A9F4"
  adaptive_icon_foreground: "dev_assets/icon_adaptive.png"

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:
  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
    - lib/assets/images/
  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.
  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages
  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  # fonts:
  #   - family: Schyler
  #     fonts:
  #       - asset: fonts/Schyler-Regular.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages


Use ResponseError on FailedLockToken type

The FailedLockToken type exposes ErrorCode/ErrorDescription properties. We should use ResponseError here instead to provide a consistent experience across the SDK.
This is something that we will address after the initial beta release of the namespace functionality.

We ended up creating a package specific error, which is the pattern in Go.


[CT-1133] [Bug] Not all jinja target attributes are available from profiles.yml

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
I am currently trying to access target.query_tag based on the currently set value in my profiles.yml but it does not appear in the target object when I log it out during parsing.
profiles.yml
config:
    send_anonymous_usage_stats: False
    use_colors: True

integration_tests:
  outputs:

    bigquery:
      type: bigquery
      method: service-account
      keyfile: "{{ env_var('BIGQUERY_SERVICE_KEY_PATH') }}"
      project: "{{ env_var('BIGQUERY_TEST_DATABASE') }}"
      schema: "{{ env_var('TEST_SCHEMA') }}"
      location: us
      threads: 4

    snowflake:
      type: snowflake
      account: "{{ env_var('SNOWFLAKE_ACCOUNT_ID') }}"
      user: "{{ env_var('SNOWFLAKE_USERNAME') }}"
      password: "{{ env_var('SNOWFLAKE_PASSWORD') }}"
      role: "{{ env_var('SNOWFLAKE_ROLE') }}"
      warehouse: "{{ env_var('SNOWFLAKE_WAREHOUSE') }}"
      database: "{{ env_var('SNOWFLAKE_TEST_DATABASE') }}"
      schema: "{{ env_var('TEST_SCHEMA') }}"
      threads: 4
      client_session_keep_alive: False
      query_tag: dbt_integration_tests
      connect_retries: 0
      connect_timeout: 10
      retry_on_database_errors: False
      retry_all: False

log output of target object from dbt parse -t snowflake
{
    'account': 'XXXXXX',
    'user': 'XXXXXX',
    'database': 'XXXXXX',
    'schema': 'XXXXXX',
    'warehouse': 'XXXXXX',
    'role': 'ACCOUNTADMIN',
    'client_session_keep_alive': False,
    'type': 'snowflake',
    'threads': 4,
    'name': 'snowflake',
    'target_name': 'snowflake',
    'profile_name': 'integration_tests',
    'config': {
        'send_anonymous_usage_stats': False,
        'use_colors': True
    }
}

Expected Behavior
I would expect the target object to contain all properties defined in profiles.yml
Steps To Reproduce
Using snowflake target and profiles.yml with query_tag defined, try to access target.query_tag
Relevant log output
No response
Environment
- OS:macOS 12.3
- Python: 3.8.11
- dbt: 1.2.1
- dbt-snowflake: 1.2.0

Which database adapter are you using with dbt?
snowflake
Additional Context
No response

@rjh336 I'm assuming this feature would ease the implementation of dbt_model_usage (view on GitHub)
somehow?

@rjh336 I'm assuming this feature would ease the implementation of dbt_model_usage (view on GitHub)
somehow?

Yep that was the idea

Hi @jtcohen6, I've decided to try to tackle this as my very first OSS PR!
Would you mind taking a look at it?

I've decided to try to tackle this as my very first OSS PR!

That's AWESOME @Surbias !! We'll have someone take a look your PR.

@rjh336 thanks for opening this issue, closing due to being covered by pr #517


Manually running command to create a movie fails on Ubuntu 21.

A user reported that when he used the movie wizard and had it output the command to create the movie, that when he did so the movie encoding failed. This was with VisIt 3.2.1 on Ubuntu 21. I was able to replicate the behavior. When I manually ran the encoder on the generated images, it worked, so somehow the VisIt script is failing and not the movie encoder.
The details are described in https://github.com/visit-dav/visit/discussions/17167.

I investigated the problem and there are 2 issues here. The first is that there is an issue with getting the correct python environment set up in the script that runs mpeg2encode. This was fixed in https://github.com/visit-dav/visit/pull/16985. Once this is fixed the movie gets generated, but VisIt reports that the movie generation failed. I will soon submit a pull request that will fix the erroneous error message.


Add RU translate

Add fully and correct translate airbnb/css on Russian language

Hi, thanks for the contribution! Instead of creating a new fork, would it be possible to improve the Russian translation we currently link to? @Nekorsis

@lencioni i think i can do that, i just need a couple of days.
And what should we do with @rtplv translation ?

I think ideally @rtplv would open a PR on @Nekorsis translation with improvements.

@lencioni , consider the fact that the @Nekorsis repository has not been updated for more than two years. And after the last update, PR were ignored by him. I would not want to make a PR to an abandoned repository.

@lencioni , is it a dead repository? :)


Crash running mbed new

Following the instructions at https://docs.mbed.com/docs/mbed-os-handbook/en/5.1/dev_tools/cli/, installed the mbed command line tools via pip.
Running mbed new mbed-blinky results in the following error:

Traceback (most recent call last):
  File "/usr/local/bin/mbed", line 9, in
    load_entry_point('mbed-cli==0.9.10', 'console_scripts', 'mbed')()
  File "/usr/local/lib/python3.4/site-packages/setuptools-15.2-py3.4.egg/pkg_resources/__init__.py", line 552, in load_entry_point
  File "/usr/local/lib/python3.4/site-packages/setuptools-15.2-py3.4.egg/pkg_resources/__init__.py", line 2672, in load_entry_point
  File "/usr/local/lib/python3.4/site-packages/setuptools-15.2-py3.4.egg/pkg_resources/__init__.py", line 2345, in load
  File "/usr/local/lib/python3.4/site-packages/setuptools-15.2-py3.4.egg/pkg_resources/__init__.py", line 2351, in resolve
  File "/usr/local/lib/python3.4/site-packages/mbed/mbed.py", line 989
    sorted_scms = sorted(sorted_scms, key=lambda (m, _): not m)
                                                 ^
SyntaxError: invalid syntax

Environment is Mac OS X El Capitan, 10.11.6. Python version is 2.7.9 installed via Homebrew, Python 3 version is 3.7.9, again installed via Homebrew. Let me know if you need any more details.

@Sentimentron I think it's using your Python 3 installation, however mbed CLI only works with Python 2 as described here: https://github.com/ARMmbed/mbed-cli#requirements
Can you set your default Python installation to Python 2? By that I mean please be sure that the command python uses Python 2 instead of Python 3.

Ah, OK after some investigation, I found out that the pip command on my system comes from Python 3, rather than Python 2. It installs fine with Python 3's pip, but doesn't actually run. I now have a different issue about linking with OpenSSL with Python 2.


Support JsonStringEnumConverter

It would be nice if the transpilation from C# Enums to TypeScript Enums supported the [JsonConverter(typeof(JsonStringEnumConverter))] Attribute from the System.Text.Json.Serialization namespace.
This could be specified as an option flag to be opt-in.
An  example could be
[JsonConverter(typeof(JsonStringEnumConverter))]
[TranspilationSource]
public enum SomeEnum
{
    SomeValue,
    SomeOtherValue
}

which at the moment is transpiled to
/** Transpiled from SomeNamespace */
export enum SomeEnum {
    SomeValue = 0,
    SomeOtherValue = 1,
}

The corresponding JsonSerialized value being used in a SignalR hub will use the string values of the enum value, hence a mismatch between the types.
Meaning a C# object like
public class SomeClass {
  public SomeEnum MyEnum {get;set;} = SomeEnum.SomeValue
}

will be serialized to by the SignalR hub
{
 "MyEnum": "SomeValue"
}

This makes the enum behave wrong when being transpiled.
A solution could be to have Tapper generate something like the following
/** Transpiled from SomeNamespace */
export enum SomeEnum {
    SomeValue = "someValue", // or "SomeValue"
    SomeOtherValue = "someOtherValue", // or "SomeOtherValue"
}

It is a good idea to support some attributes in System.Text.Json.

[JsonPropertyName]
[JsonIgnore]
[JsonConverter(typeof(JsonStringEnumConverter))]

I noticed that it is a bad idea to change the behavior depending on whether the JsonConverter attribute is annotated. This is because there are cases where the JsonSerializerOptions are registered instead of the type definition.

Look up attributes in System.Text.Json using flags such as --use-json-attribute.
target: [JsonPropertyName] / [JsonIgnore]
tapper --project xxx --output yyy --use-json-attribute

Change the value of an enum with a option such as --enum-value.
target: JsonStringEnumConverter.
tapper --project xxx --output yyy --enum-value default (underlying-type, integer)
tapper --project xxx --output yyy --enum-value name
tapper --project xxx --output yyy --enum-value nameAsCamel

These are still in the idea stage (not yet finalized).

Also what about the possibility to export enum as type?
like:
type Statuses = "Paid" | "NotPaid";

Would be really great @Vulthil @nenoNaninu to have enum as names!

I released v1.7, which added the feature to transpile enum to string enum and string union.
For more details, please see docs.


Not working on version 4.2 beta

My friend who is on the beta told me that this unlocker is currently not working on the 4.2 beta versionwith an error that says "outdated fps patern", the unlocker always worked on the previous betas. Just a heads up that once 4.2 officially comes out this unlocked will probably not work and need an update.

beta has compiler changes that are not present in 4.2 live version, no update is needed for 4.2 live

beta has compiler changes that are not present in 4.2 live version, no update is needed for 4.2 live

VSync auto-disable does not work from my testing on the live version. Looks to need a signature update.


Redirect to original URL after login

What issues does this PR close?
### Checklist
- [x] The PR title is short and expressive.
- [x] I have updated the CHANGELOG.md. See [changelog_update.md](https://github.com/sovity/authority-portal/tree/main/docs/dev/changelog_updates.md) for more information.
- [ ] I have updated the Deployment Migration Notes Section in the CHANGELOG.md for any configuration / external API changes.
- [x] I have performed a **self-review**

closed in favor of https://github.com/sovity/authority-portal/pull/247


TrueNAS Integration Missing data[Bug]

Describe the issue
When I (re)Install the TrueNAS integration then I see the datasets and the Pools. Not even 1 minute later the datsets and pools don't show anymore
How to reproduce the issue
Steps to reproduce the behavior:

(re)Install the TrueNAS integration
Open TrueNAS Datasets in Integration (all datasets are there => see screenshot)
Wait +- 1 minute
Open TrueNAS Datasets in Integration (all datasets are gone => see screenshot)
Open

Expected behavior
I expected that the datasets should remain, same for the Pools.
Screenshots
Uploaded
Software versions
All fields in this sections are required.

Home Assistant version:
TrueNAS integration version:
TrueNAS version: <!-- TrueNAS-12.0-U8.1
TrueNAS_Integration_After_1minute.pdf
TrueNAS_Integration_After_Install.pdf

Traceback/Error logs
Nothing in errorlogs
Additional context
Reinstalled HACS, jail, HA, Integration. Same problem again and again

This is related to removal of non-existant datasets. Can you install master and run integration in debug mode? I have added debug messages for this.

I got the same problem.
I reinstalled 1.2.1
Rebooted
Then after everything disapear, I did reload the home assistant integration.
log truenas.txt

Probably not the same issue. I dont see anything disapearing. Can you open new issue and go into more detail?

Well I saw that my datasets where missing. So I went and installed the 1.2.0 version to see if the bug was still there.
After the reboot, I went in the integration and saw all the datasets. Less than a minute later they all disapeared.
So I came here to write a bug report, but this issue was already filled.
So I took @psleutel How to reproduce and did it while reinstalling the version 1.2.1.
Again, I got the same result as @psleutel.
I don't see how this is a different issue and I don't want to duplicate it.

ah ok, you said that everything disappeared. if its just datasets, install master and run debug again. it contains additional debug information I will need to see.

Sorry for the confusion here.
Not sure if it's how to do it.
I deleted the trunas folder under custom_components in my config.
Then downloaded the master branch zip, took the truenas folder under custom_components and pasted it in my config.
Rebooted.
Waited until the dataset disappeared.
Reload the integration.
Waited again until the dataset disappeared.
Hope this one will help.
log.truenas.txt

You can select master in HACS version selection, no need to do it manually.
I think I foudn the issue, can you test master again? No need for debugs if it works.

I've installed the master in HACS and did then the integration.
Datasets ar initially there but dissapear again after about 1 minute.
Sorry for this

Hi @tomaae
After the previous I got the message from HACS to upgrade TrueNAS integration towards Version 1.2.1 and believe it or not, now it works and the datasets don't dissapear anymore. Maybe something others can try aswell and see if this works for them aswell

that should not be possible, certainly not with 1.2.1
I suspect there is something messed up with HACS and files are not updated properly. you most likely ended up with master, at least partly.
I would recommend removing integration, then all its files manually and install it again via HACS.

I installed Master, rebooted and waited 10 minutes.
It seems to be working. The datasets are still there.
Thank you!

perfect, will release it in few minutes.


Update propertyvalue::createinspectabel to note that it's now optional

This method can basically be ignored. It's a no-op and leftovers from the early winrt days. Updating documentation to make it clearer how this API behaves.

Thanks, Ben!

This is now published.


Detect package.json's scripts.start as startup cmd

@lostintangent
In response to comments on https://github.com/Azure-App-Service/node/issues/10 and https://github.com/Azure-App-Service/node/pull/12, adding support for detecting presence of scripts.start and using it if no appCommandLine is provided.

Also referencing https://github.com/Azure-App-Service/kudu/issues/20.


nixos/tor: add HiddenServiceVersion option

Motivation for this change
Allows to easily use v3 Hidden Services which "features many improvements over the legacy system". Due to the torrc syntax that seems difficult to do without adding a hidden service version option to the module.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

type = types.addCheck (types.nullOr types.int) (x: x == 2 || x == 3);

I think it should be

type = types.nullOr (types.addCheck types.int (x: x == 2 || x == 3));

(Btw, grepping shows nixos/modules/services/misc/rippled.nix does a similar wrong thing. I fixed that one myself and added the patch to the queue.)
Also, after reading https://github.com/NixOS/nixpkgs/pull/50849#pullrequestreview-176969593 I'm now also a bit torn on whenever the default should be left to tor via nulls, via isDefined or at all. But I'd say it's fine as it is.

Good catch. I fixed that. Actually I found the construction in rippled.nix and then didn't think about it.

LGTM.


Possible to limit options for output?

Can't seem to figure this out after tweaking. This obviously isn't an issue, but this is a smaller project without a forum.
I'd like to prevent output from including, svg, eot, and the css files. I'm looking for the more modern stack of just ttf, woff, and woff2.
Even better - the ability to append a string to each filename. I believe this is already part of fontgen, but I'm wondering how to get it done with Gulp.
Cheers.

Treating this as a forum question…
fwiw woff2 support at this point is pretty weak - no IE, no Edge<14, no Safari, no iOS Safari - that's more the stack of the future than it is the modern stack.
Here's how to do what you're after without specific support from fontfacegen. Not as elegant maybe, but not too bad:
Append strings to the filenames is with gulp-rename. e.g.
...
.pipe(rename({
    basename += "-rdwatters"
})
...

Clear out the unneeded files with del (see also the demo recipe) - in its own task, you could do
gulp.task('fonts:generate', function() {
    ...
        .pipe(fontgen(...))
        ...
});
gulp.task('fonts:generate-and-cull', ['fonts:generate'], function() {
    del(['yourpath/*.{svg,eot,css}'])
});

or put it in the same task as fontgen, using gulp-filter and gulp-clean:
gulp.task('fonts', () => {
    // prepare filter
    const unneededFontsFilter = filter(['*.{svg,eot,css}'], {restore: true});

    return gulp.src(["yoursourcefont"])
        // do your fontgen stuff
        .pipe(fontgen(...))
        // filter the stream down to just the files you want to delete
        .pipe(unneededFontsFilter)
        // delete them
        .pipe(clean())
        // bring back the files you filtered out
        .pipe(unneededFontsFilter.restore)
        // could add rename stuff here
        // ...
        .pipe(gulp.dest('yourdestinationpath'));
});


pull request for e2e test at 01/26/2017 10:45:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Adding docs for client state interface

Description

closes: #1851
This PR adds information about what each of the client state interface methods should be doing
excluding:

updates
upgrades
proposal updates
genesis metadata

Commit Message / Changelog Entry
docs: added documentation for client state methods.

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

@crodriguezvega thanks for taking a look!

But wondering as well if it would be worth for some of the functions to have some pseudocode to guide the reader on what the implementation should do

It would be great to have some code to work with, but I'm not sure what assumptions we can make about the implementation of the implementor. Currently the solomachine and tm light clients are very different, I'm not sure what more we could do besides give a broad outline and then also link to some implementations.


[CI, Test] Add debug macOS editor build with sanitizers.

clang on macOS seems to detect different issues than GCC on Linux.

If we could confirm that Clang on Linux finds the same issues, it would be better than adding another macOS runner. We're already always waiting for macOS runners as GitHub Actions gives us a lot less capacity for concurrent builds there (only 5 macOS concurrent runs, vs 20 for other platforms). https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits


Terminate all agents simultaneously at e2e tests

Subject of the issue
The agents are terminating independently from each other in the e2e tests. This might cause issues when the test depends on Tendermint since the majority of the nodes might not be feasible for the rest of the agents to end their rounds successfully.
Steps to reproduce
Run any e2e test and observe the logs for the terminating message:
AEA 'agent_name' interrupted!

Expected behaviour
The agents should terminate simultaneously.
Actual behaviour
The agents terminate immediately after they succeed, independently.

@Adamantios Is this still an issue?

No, this is not yet an issue. Closing this.


[WIP] Working on directory listing

Simple implementation works, but navigation is still scuffed.

I need to only call the directory index listing if no index.html file is present


Open STATS_FILE as unicode

Fixes the issue where a trace/error message contains unicode characters.
For example:
UnicodeDecodeError at /h/doc/files/all
'ascii' codec can't decode byte 0xc4 in position 2815: ordinal not in range(128)

@MarZab Thanks. Would be great if you could add a simple test case to make sure unicode support does not break in future.

Can this fix be released please? It is a frustrating bug, especially when using ESLint.

Released 0.6.0


when tabs do not exceed the screen width, distribute the width of the tab evenly.

when I add two or three super-tabs, and the tabs width do not exceed the screen width, I want to make all tab's width equal. but the actual situation is the right will leave a large blank.

i solved it, i removed scrollTabs.

I want to do that auto, not added or removed attribute scrollTabs.

You can achieve this by not using the scrollTabs attribute.

It's not possible to do this automatically. You have to choose whether you want the tabs to be scroll-able or not.


Update paths for jss v10

have you tried running it locally? does it all work?

No, not yet. Will test it this evening or tomorrow evening
On 27. Aug 2018, 11:15 +0200, Oleg Isonen<EMAIL_ADDRESS>wrote:

have you tried running it locally? does it all work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

It works now, though we will have to limit the version to v10 and above.

What happens if you run it locally and select v9 and lower?

I get 404 for the plugins etc. The pages which were also before in the main repo are fine.


fix StartedAt and FinishedAt of the container status

Signed-off-by: Iceber Gu<EMAIL_ADDRESS>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Finished time is always 1754-08-31T06:49:24.128654848+08:05 in the run and create states, because FinishedAt is -6795364578871345152
[root@iceber-3 ~]# crictl inspect 587444fc34ec9
{
  "status": {
    "id": "587444fc34ec9846c163d0c74bbf985ac73662817a89e16b7328b955a03ef902",
    "metadata": {
      "attempt": 6,
      "name": "dx-arch-stolon-sentinel"
    },
    "state": "CONTAINER_RUNNING",
    "createdAt": "2021-03-01T16:45:23.390180141+08:00",
    "startedAt": "2021-03-01T16:45:23.544299436+08:00",
    "finishedAt": "1754-08-31T06:49:24.128654848+08:05",
    "exitCode": 0,

Which issue(s) this PR fixes:
Special notes for your reviewer:
Fixed output in the running state:
[root@iceber-3 ~]# ./crictl inspect 587444fc34ec9
{
  "status": {
    "id": "587444fc34ec9846c163d0c74bbf985ac73662817a89e16b7328b955a03ef902",
    "metadata": {
      "attempt": 6,
      "name": "dx-arch-stolon-sentinel"
    },
    "state": "CONTAINER_RUNNING",
    "createdAt": "2021-03-01T16:45:23.390180141+08:00",
    "startedAt": "2021-03-01T16:45:23.544299436+08:00",
    "finishedAt": "",
    "exitCode": 0,

Does this PR introduce a user-facing change?

Which container runtime did you use for the tests? I did a local test with CRI-O (master) and the resulting dates for a created container were:
"startedAt": "1970-01-01T01:00:00+01:00",
"finishedAt": "1970-01-01T01:00:00+01:00",

I think we're good to move forward with that change. We could say that it's a breaking change but I would not expect someone to rely on the date parsing output if the container state does not match.

I did the tests with the dockershim.
You get the 1970-01-01T01:00:00+01:00 because the started and finished timestamp is 0 (zero value)
https://github.com/cri-o/cri-o/blob/6ee8d68771c24a045aef1f5372eae377928a3530/server/container_status.go#L68-L84
You can use --debug to see the returned data

And kubernetes sometimes ignores startedAt and finishedAt when dealing with CRI container status, as seen here

And kubernetes sometimes ignores startedAt and finishedAt when dealing with CRI container status, as seen here
I'm thinking about whether to show "" or 0001-01-01T00:00:00Z(time.Time{}.Format(time.RFC3339Nano)) for empty startedAt and finishedAt
0001-01-01T00:00:00Z has the advantage that it can be parsed by time.Parse without returning errors. And result.IsZero() is true

In that case it would't be a "breaking change". I like that. :+1:

@saschagrunert  update to show 0001-01-01T00:00:00Z.
PTAL, Thanks

/hold cancel
the CI failures are not related to this change, I'll follow-up on those.


Should we allow text/JSON file upload?

Before we integrate w/ GPT-4, maybe we could generate a JSON representation that is equivalent to uploading a form. Maybe w/ labels as an optional add-in.

The idea is that there may be many ways to create a JSON representation of the field names + labels, including an LLM, so allowing this kind of upload frees up more ways to interact with the Weaver. Including perhaps w/ the Python-only API.


IBM-Swift/Kitura#836 Catch and log errors in socket.acceptClientConne…

Description

Deprecate listen methods with error handling callbacks
Add replacement methods that propagate up server errors and use lifecycleListener for error callbacks
Catch and log errors in socket.acceptClientConnection() without stopping listen()
Refactor so server exit does not rely on error being thrown
Refactor so lifecycleListener.performStopCallbacks() is always called when server stops
Add and update tests for above changes
Make the above changes for both HTTPServer and FastCGIServer

Motivation and Context

How Has This Been Tested?

Checklist:

[ ] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

…ction without stopping listen

@shmuelk @ianpartridge Could you please review these changes?


Allow containers to be connected to networks before it is started

docker version: Docker version 1.9.0-dev, build 4816626
docker into:
Containers: 13
Images: 9
Server Version: 1.9.0-dev
Storage Driver: devicemapper
 Pool Name: docker-253:0-33662528-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 107.4 GB
 Backing Filesystem: xfs
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 2.595 GB
 Data Space Total: 107.4 GB
 Data Space Available: 10.87 GB
 Metadata Space Used: 2.691 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.145 GB
 Udev Sync Supported: false
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.82-git (2013-10-04)
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.10.0-229.14.1.el7.x86_64
Operating System: CentOS Linux 7 (Core)
CPUs: 2
Total Memory: 1.797 GiB
Name: ccompute1.rmb938.com
ID: IAQS:6E74:7NGG:5JOG:JXFM:26VD:IAQV:FZNU:E23J:QUAA:NI4O:DI3S

uname -a Linux ccompute1.rmb938.com 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Sep 15 15:05:51 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
Currently when creating (not running) a container you can assign it to a network. Either multiple --net= should be allowed when creating the container OR allowing docker network attach without the container being started.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@rmb938
It looks like https://github.com/docker/docker/issues/17750 which came in later got more attention and https://github.com/docker/docker/pull/17796 was opened to support multiple networks binding for docker create and docker run.
If you agree #17796 is a valid fix for your reported issue, we can update the PR description so that this issue will be closed when/if #17796 gets merged.

@aboch Yes #17796 does seem like a valid fix.

Thanks @rmb938
@coolljt0725 Can you please update your PR description to also include this issue. Thanks.

@aboch  sorry, very busy these these days. I'll update my PR on this weekend.

@aboch @coolljt0725 @rmb938 I'll close this issue as a duplicate of https://github.com/docker/docker/issues/17750, and add a mention in https://github.com/docker/docker/pull/17796


Broken link in docs to geolocation

React Native version:

Steps To Reproduce

Open docs -> JavaScript Environment -> Polyfills -> navigator.geolocation
You will be redirected to broken geolocation link

Describe what you expected to happen:
simply change href attribute in the a tag
Snack, code example, or link to a repository:
wrong: navigator.geolocation
good: navigator.geolocation

I'll try to find a place where 'href' should be changed, then I'll create PR.

@cpojer thanks :)


Add IS-10 support

NMOS Authorization
This is based on the OAuth 2.0 recommendation, it is used for protecting the NMOS APIs, which allows NMOS Node and Registry to give limited access to the third-party application. Third-party applications including Broadcast Controller, which queries Registry via the AMWA IS-04 for the NMOS Nodes information and issues the IS-05 connection on Nodes. NMOS Nodes also act as the third party for the Registry to perform the AMWA IS-04 node registration.
General idea of how it works
A client such as Broadcast Controller provides credentials to the Authorization Server. The required access token(s) is then granted to the Controller for accessing the protected APIs on the Resource(s) Server, such as the NMOS Node. The Resource Server will verify the access token for the level of the access right. If all goes well, the protected API is accessible.
The access token is time-limited, it must be refreshed before it expired. It is recommended to attempt a refresh at least 15 seconds before the expiry or the half-life of the access token.
To speed up the token validation process, the Resource(s) Server periodically fetches the Authorization Server's public keys, typically once every hour. The public keys allow the Resource(s) Server to perform local token validation without bombarding the Authorization Server on every API access validation.
A similar idea is also applied to how NMOS Node performs node registration, Registry obtains the public keys from the Authorization Server, and the Node obtains the registration access token from the Authorization Server. Once the Node obtains the token, it embeds it into the registration request for node registration, and registry heartbeat.
Authorization Server Metadata
Clients, such as NMOS Broadcast Controller, Registry and Node must obtain the location of the Authorization API endpoints via the DNS-SD Authorization Server discovery. The Authorization Server has a well-known endpoint for returning the server metadata information. Details are shown in the client registration sequence diagram.
Client Registration
Clients must be registered to the Authorization Server before using the OAuth 2.0 protocol. Once the client is registered, the Authorization Server will provide it with a client_id for all both public and confidential clients and a client_secret for the confidential client. It is, however, important that the public client which is using the Authorization Code Flow must register one or more redirect URLs for security purposes, which allows Authorization Server to ensure any authorization request is genuine and only the valid redirect URLs are used for returning the authorization code. While using Client Credentials Flow, Private Key JWT can be used for client authentication for extra security.
See the client registration sequence diagram below on how an NMOS Node is registered to the Authorization Server.

Access Token
There are a number of ways to request the access token, it is based on the type of authorization grant. The grant type depends on the location and the nature of the client involved in obtaining the access token. A number of grant types are defined in OAuth 2.0.  NMOS is focused on using the following types, the Authorization Code Grant, the Client Credentials Grant and the Device Code Grant(for the future).
Authorization Code Grant
This is the most recommended type, it should be used if the client has a web browser, such as the Broadcast Controller. An Authorization code is returned by the Authorization Server via the client's redirect URI. The client can then exchange it for a time-limited access token, and renew it with the refresh token.
For public clients, there is a potential security risk with an attacker hijacking the Authorization code. To prevent that Proof Key for Code Exchange (PKCE) is used to further secure the Authorization Code Flow.
In step 1, create a high entropy cryptographic random string, code_verifier.
In step 2, convert the code_verifier to code_challenge with the following logic:
code_challenge=BASE64URL-ENCODE(SHA256(ASCII(code_verifier)))

In step 3, includes the code_challege and the hashing method used to generate the code_challenge in the authorization code request.
In step 4, send the code_verifier and the authorization code for exchanging the token. The Authorization Server uses the code_verifier to recreate the matching code_challenge to verify the client.

Client Credentials Grant
This type of authorization is used by clients to obtain the access token without user authorization, such as a hardware NMOS Node which has no web browser supported. To gain extra security the Private Key JWT is used by the NMOS Node as a form of client authentication by the Authorization Server before handing out the token.

Authorization Server Public Keys
The public keys are used by the Resource(s) Server for validating the access token before giving access right to the protected APIs. The client must periodically poll the Authorization Server's public keys, typically once every hour. In the event, that the Authorization Server is no longer available, the last fetched public keys will be kept in use until the Authorization Server connection is restored.
The token validation is done by re-generating the matching token signature by signing the token header and the token payload.

Authorization behaviour

nmos/authorization_behaviour.cpp

The purpose of the authorization behaviour thread is to:

discovery of the Authorization Server
fetch Authorization Server metadata for Authorization Server endpoints and supported features
Authorization client registration
fetch Authorization Server public keys
fetch Bearer token for accessing protected endpoints

Note: The Device Code Authorization Grant is not shown in the diagram
The state machine implemented by the nmos::experimental::authorization_behaviour_thread is shown below:

Missing public keys to validate the access token

nmos/authorization_handlers.cpp
nmos/authorization_behaviour.cpp

If no matching public key is available to validate the incoming access token. The validation handler will trigger the authorization token issuer thread to fetch and cache the public keys from this token's issue, which will then be possible to validate any token issued by this issuer.
The state machine implemented by the nmos::experimental::validate_authorization_handler and the nmos::experimental::authorization_token_issuer_thread are shown below:

OAuth 2.0 Node Registration Example
Following is an overview of how an OAuth 2.0 NMOS Node registers to an OAuth 2.0 enabled NMOS Registry.

We need to work out where "Fatal error: No IPv4/IPv6 address(es) for "nmos-api.local" available" comes from... I wonder if this early error causes the test suite to assume testssl.sh is not available? Obviously later on at least nmos-api.local is working fine...

It's bizarre... both your Windows 2019 runners consistently show this in testoutput:
Fatal error: No IPv4/IPv6 address(es) for "nmos-api.local" available

Whereas on master, that doesn't happen on either Windows 2019 runner.
And on my PR #282, it only happens on the Windows 2022 runner, not the Windows 2019.
It seems repeatable in our respective branches.
How can this be?!?!


WebAdmin: Reload user passwords regularly

It is somewhat misleading that after the webadmin.ini file is changed to add or remove a user, the changes don't reflect till the server is restarted (not to mention webadmin has problems restarting, see #272). We should make periodic updates to the in-memory credentials - or if we can even detect file changes, the better.

I believe that the server no longer overwrites the webadmin.ini file, but a restart is still needed.


Add a script to cancel previously started builds for the same review

Still left to figure out:

How do we get the BuildKite API tokens onto builders?
Is it sufficient to run that script from the first job that runs in the premerge-checks pipeline?

The idea is that when we are about to launch a new build in the premerge-checks pipeline, we figure out the review we're building for and we cancel any build currently scheduled or running for that review.
Fixes #278

Yes, that's an interesting approach. I have initially thought that we need to store some state  to understand what is running but API will be enough. I will modify "service" agents so they will have an api token available in ENV variable an verify that this will really cancel the builds triggered from e.g. diff checks.

Nice, thanks! You'll need to fixup the script to get the API token from the right spot, but I'm sure you saw this already. Thanks!

Sure. I am planning to call this script from the very first step of "diff-checks" (IFAIR that is the only point). Did you have any other places in mind?

I thought we'd call it from the premerge-checks pipeline, since that's the job that actually kicks off other work, but anything's fine by me, and you know the pipelines better than I do.
I didn't think of that, but we should be careful not to cancel our own job, too. I think the script might need to change a bit. Could we use the Phabricator ID instead of just the review number?


Updating to 1.11.2

Lets use this issue to keep track of which mods have updated to 1.11 that we want to have in this pack.
Required Mods

[ ] Base Metals
[x] Baubles
[ ] CraftTweaker
[ ] Custom Ore Gen
[ ] Dungeon Tactics
[x] Enchiridion
[ ] EnderCore
[ ] EnderIO
[ ] Esteemed Innovation
[ ] Immersive Engineering
[x] IvToolkit
[x] JEI
[ ] Modtweaker
[x] PrimalCore
[X] Recurrent Complex
[ ] Rockhounding
[x] Roguelike Dungeons
[ ] Tinker's Construct
[X] Waystones

Mob Challenge

[x] BloodMoon
[ ] EnderZoo
[ ] MobProperties
[ ] Special AI

Hunger/Food Challenges Mods

[x] AppleCore
[x] AppleSkin
[ ] Cooking For Blockheads
[x] Pam's Harvestcraft
[x] Spice of Life

All Others

[x] AbyssalCraft
[x] ActuallyAdditions
[ ] Aroma1997Core
[ ] AromaBackup
[ ] ArsMagica2
[ ] AutoRegLib
[x] Backpack
[ ] Base
[x] BDLib
[x] BetterAchievements
[x] BetterFPS
[x] BiomesOPlenty
[x] BloodMagic
[ ] Boatifull
[ ] Boilerplate
[ ] Botania
[ ] Charset
[ ] Chisel
[ ] CommonCapabilities
[x] Controlling
[x] Cosmetic Armor Reworked
[ ] Crafting Tweaks
[x] Custom Main Menu
[ ] Cyberware
[ ] DaVinci's Vessels
[x] Deep Resonance
[ ] Druidry
[x] ElecCore
[x] Embers
[x] Enderthing
[ ] Engineer's Workshop
[x] Everlasting Abilities
[x] EvilCraft
[ ] Expanded Industry
[ ] Extra Alchemy
[x] Extra Utilities 2
[x] Fast Leaf Decay
[x] FoamFix
[x] Forestry
[ ] Futurepack
[x] Gendustry
[x] Giacomo's Fishing Nets
[ ] Goetia
[ ] Grapple Mod
[x] Grue
[ ] Guide API
[ ] Hard Lib
[ ] Infinity Lib
[x] Integrated Dynamics
[x] Integrated Tunnels
[ ] Inventory Sorter
[ ] Iron Chests
[ ] JEI Bees
[ ] Just Enough Resources
[x] Level Up!
[ ] LibrarianLib
[ ] LibVulpes
[ ] LunatrisCore
[ ] Mantle
[ ] McJtyLib
[ ] MCMultipart
[ ] ModularUtilities
[ ] MoreBees
[ ] MoreOverlays
[x] Morpheus
[ ] MovingWorld
[ ] MTLib
[ ] NashornLib
[ ] Natura
[ ] NaturalPledge
[ ] NetherCore
[ ] NetherEx
[ ] NetherMetals
[ ] NetherPortalFix
[x] NoFOV
[ ] NomadicTents
[ ] Ore Flowers
[x] PersistentBits
[x] Quark
[ ] Railcraft
[ ] Refined Relocation
[x] Refined Storage
[ ] Refraction
[x] Reliquary
[ ] ResourceLoader
[x] RFTools
[x] RFToolsCTRL
[x] Roots
[ ] Runes Of Wizardry
[ ] Signals
[x] SpartanShields
[ ] Stackie
[ ] Surge
[ ] TAIGA
[ ] Tesla
[x] The One Probe
[ ] Tinker's Defense
[ ] Tombstone (or some other gravestone mod)
[ ] TrashSlot
[x] ViesCraft
[ ] WIRED

Can we move dungeon tactics and botania to the required section since they're a big part of the loot in Roguelike Dungeons?

Done.

Also, Botania and Chisel are somewhat required since their blocks are used a lot in the custom dungeons

Customstuff is out for 1.11

There is now Cooking for Blockheads 1.11.2 version.
https://minecraft.curseforge.com/projects/cooking-for-blockheads/files/2381577

Well, we updated. We're done with this one.


[improve] [broker] Do not try to open ML when the topic meta does not exist and do not expect to create a new one. #21995

Motivation
When we call pulsar-admin topics stats <topic name>, Pulsar will try to open a managed ledger even if the topic metadata does not exist.
It costs a lot of resources when there are many requests trying to call pulsar-admin topics stats <topic name> on a deleted partition.
2024-01-30T15:52:17,143+0000 [bookkeeper-ml-scheduler-OrderedScheduler-2-0] ERROR org.apache.pulsar.broker.admin.v2.PersistentTopics -<EMAIL_ADDRESS>Failed to get stats for persistent://xx/xx/xx-partition-0
java.util.concurrent.CompletionException: org.apache.pulsar.broker.web.RestException: Topic partitions were not yet created
        at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
        at java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:687) ~[?:?]
        at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:662) ~[?:?]
        at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:2168) ~[?:?]
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.topicNotFoundReasonAsync(PersistentTopicsBase.java:4519) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$getTopicReferenceAsync$438(PersistentTopicsBase.java:4499) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at java.util.Optional.orElseGet(Optional.java:364) ~[?:?]
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$getTopicReferenceAsync$439(PersistentTopicsBase.java:4499) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150) ~[?:?]
        at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
        at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147) ~[?:?]
        at org.apache.pulsar.broker.service.BrokerService$2.openLedgerFailed(BrokerService.java:1800) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl.lambda$asyncOpen$8(ManagedLedgerFactoryImpl.java:421) ~[io.streamnative-managed-ledger-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at java.util.concurrent.CompletableFuture.uniExceptionally(CompletableFuture.java:990) ~[?:?]
        at java.util.concurrent.CompletableFuture$UniExceptionally.tryFire(CompletableFuture.java:974) ~[?:?]
        at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
        at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2162) ~[?:?]
        at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl$2.initializeFailed(ManagedLedgerFactoryImpl.java:416) ~[io.streamnative-managed-ledger-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl$1.operationFailed(ManagedLedgerImpl.java:458) ~[io.streamnative-managed-ledger-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at org.apache.bookkeeper.mledger.impl.MetaStoreImpl.lambda$getManagedLedgerInfo$3(MetaStoreImpl.java:150) ~[io.streamnative-managed-ledger-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?]
        at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
        at org.apache.bookkeeper.common.util.OrderedExecutor$TimedRunnable.run(OrderedExecutor.java:201) ~[org.apache.bookkeeper-bookkeeper-common-4.16.3.jar:4.16.3]
        at org.apache.bookkeeper.common.util.SingleThreadSafeScheduledExecutorService$SafeRunnable.run(SingleThreadSafeScheduledExecutorService.java:46) ~[org.apache.bookkeeper-bookkeeper-common-4.16.3.jar:4.16.3]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[io.netty-netty-common-4.1.100.Final.jar:4.1.100.Final]
        at java.lang.Thread.run(Thread.java:840) ~[?:?]
Caused by: org.apache.pulsar.broker.web.RestException: Topic partitions were not yet created
        at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$topicNotFoundReasonAsync$442(PersistentTopicsBase.java:4521) ~[io.streamnative-pulsar-broker-<IP_ADDRESS>.jar:<IP_ADDRESS>]
        at java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:684) ~[?:?]
        ... 29 more
2024-01-30T15:52:17,143+0000 [bookkeeper-ml-scheduler-OrderedScheduler-2-0] INFO  org.eclipse.jetty.server.RequestLog - <IP_ADDRESS> - - [30/Jan/2024:15:52:17 +0000] "GET /admin/v2/persistent/xx/xx/xx-partition-0/stats?getPreciseBacklog=true&authoritative=false&subscriptionBacklogSize=true&getEarliestTimeInBacklog=false HTTP/1.1" 404 50 "-" "Pulsar-Java-v2.11.1" 7

Modifications

Do not try to open ML when the topic meta does not exist and do not expect to create a new one.

Behavior changes of TopicEventsListener

Before changes: the listener will receive a Topic Load event when calling pulsar-admin topics stats <topic name> even if the topic was not created.
After changes: the listener will not receive a Topic Load event when calling pulsar-admin topics stats <topic name> if the topic was not created.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: x

@poorbarcode there is a test keeps failing, could you please take a check

Codecov Report
Attention: Patch coverage is 90.32258% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.60%. Comparing base (0b6bd70) to head (cdecb66).
Report is 8 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22004      +/-   ##
============================================
+ Coverage     73.57%   73.60%   +0.02%
+ Complexity    32553    32102     -451
============================================
  Files          1874     1874
  Lines        139252   139351      +99
  Branches      15260    15279      +19
============================================
+ Hits         102461   102574     +113
+ Misses        28866    28854      -12
+ Partials       7925     7923       -2

Flag
Coverage Δ

inttests
24.60% <51.61%> (-0.29%)
:arrow_down:

systests
24.23% <51.61%> (-0.23%)
:arrow_down:

unittests
72.89% <90.32%> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...rg/apache/pulsar/broker/service/BrokerService.java
81.03% <90.32%> (-0.20%)
:arrow_down:

... and 74 files with indirect coverage changes


[Bug] auto-focus on select2 have strange behavior

@jorgetwgroup I am assigning you directly here because I know you are working on this focus part.
So here it is how you can reproduce:

Go to products, add a name an try to save.
It will error because the price on the tab Basic Info is mandatory ✅
you will be redirected back and automatically changed to the tab where the error happen ✅
since the first field is a select2 field, it will open automatically (even if it has no errors) ❌

I can't even see the error field because the selection covers it.

I think the rule should be:

If there are errors, focus on the first field you can find with an error.

What do you think @jorgetwgroup ?

Hi @pxpm @tabacitu should be fixed by PR https://github.com/Laravel-Backpack/CRUD/pull/4612


Property 'selectpicker' does not exist on type 'JQuery'

I have successfully imported bootstrap-select into my project using:
<!-- Latest compiled and minified CSS -->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.12.4/css/bootstrap-select.min.css">

<!-- Latest compiled and minified JavaScript -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.12.4/js/bootstrap-select.min.js"></script>

<!-- (Optional) Latest compiled and minified JavaScript translation files -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.12.4/js/i18n/defaults-*.min.js"></script>

Within the document <head> tag. I was going to see how to modify the checkmarks within the multiple select boxes, and figured I would try to use the
$('.selectpicker').selectpicker('deselectAll');

Method as shown here. Whenever I attempt to use that bit of code, I receive an error:
TS2339: Property 'selectpicker' does not exist on type 'JQuery<HTMLElement>'.

I have even tried installing the types definition using
npm install --save-dev @types/bootstrap-select

But the issue still remains. I'm using the Visual Studio SPA template which uses ASP.NET Core template, Vue.js and Webpack.

Perhaps you should refer directly using the id ?
I have no problem by doing:
$(#selectpicker').selectpicker('deselectAll');
Of course you have to set the id on the picker !

I had the issue with webpack and the modular function that comes with it.
The jQuery version that's been used for bootstrap-select was different than the one i've implemented.
So i needed to overwrite this using imports-loader:
you need to overwrite the "this" within the factory function that is searching for "root['jQuery']".
require("!imports-loader?define=>false,exports=>false,module=>false,this=>{'jQuery': jQuery}!bootstrap-select");
i hope this will help

@InhouseMedia,
Any idea how to do what you describe using the angular-cli.json file of an Angular 2+ project?

@davemvp sorry I don't know. maybe there is a ngx-bootstrap/select package somewhere. haven't found it yet


Adds ESLint extension to Remove Development Container. Closes #2327

Closes #2327

Merged manually. Thank you! 👏


#1978 Tutorial: f, F, t, T, ;, ','

Added tutorial for f, F, t, T, ';', and ',' motions, as discussed in #1978
Please let me know if anything needs to be changed!
Didn't know whether or not to include motions with [count] in the tutorial, or include examples of using these motions with 'd' or 'c'.

I'm wondering if it would be better to use "relative" directions like "next instance of" and "previous instance of" instead of "left" and "right, etc..
A popular Vim cheat sheet describes the command [count]f[character] as "jump to next occurrence of [character]", which seems more elegant and concise than saying left or right.
I think it's also important to mention that f & t (and backwards variants) only work in the line that the cursor is in, if memory serves correctly.

Didn't know whether or not to include motions with [count] in the tutorial, or include examples of using these motions with 'd' or 'c'.

Personally, I think you shouldn't mention [count] at all.  We can add another tutorial specific to counts later where we can show counts associated with multiple operations.
Given that you made this the fourth tutorial (along with all the other "motion" tutorials) you shouldn't mention d or c.  The d and c tutorials come later and you wouldn't want to reference those features before we teach them.

@keforbes thanks for your input, I agree that counts should be introduced in a later tutorial. @glhrmv totally agreed, I was having trouble with wording it in a way that was satisfactory. I'll make those changes and commit soon.

Build looks good! Bringing this in now - thanks for the contribution, @brian-yu !

@bryphe Thanks! I'm looking forward to contributing more to oni in the future 😃

Awesome! 💯


Please release 1.4.1

1.4.0 is current on the puppet forge, but is broken with puppet 4.x. When trying to use it the following errors are generated:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown variable: '::maven_version'. at /etc/puppetlabs/code/environments/infrastructure/modules/maven/manifests/maven.pp:42:6 at ....
Pointing my Puppetfile at this git repo and it installs fine.  It's been almost 2 years since the last release to the forge, and lots of commits in between. It would be nice to have working code from the forge.

Would like 1.4.1 as well here, for profiles and properties support.


fix(auth-plugin-backend): Allow it to skip migrations

Signed-off-by: Daniel Dias Branco Arthaud<EMAIL_ADDRESS>Hey, I just made a Pull Request!
issue associated https://github.com/backstage/backstage/issues/12999
When auth plugin is using database provider it verify if needs to skip migrations
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hey @darthaud, congrats on your first merged PR 🎉 Nice work 👍 Please let me know if we can be helpful in any way.


 Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you validate the sender and know the content is safe. Please forward this email to<EMAIL_ADDRESS>if you believe this email is suspicious.
We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflowhttps://aka.ms/vscodestackoverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new questionhttps://aka.ms/vscodestackoverflowquestion helpful if your question has not already been asked. See also our issue reporting guidelineshttps://aka.ms/vscodeissuereporting.
Happy Coding!
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/232659#issuecomment-2448548678, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BMHTNEF47OIFWNDYNCPMQBTZ6FKRFAVCNFSM6AAAAABQ4374KGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYGU2DQNRXHA.
You are receiving this because you authored the thread.Message ID: @.***>


Make google-cloud-pubsub's Subscriber more unit test-friendly

While building unit tests for the Spring Integration Pub/Sub channel adapters, we needed to simulate the behaviour of a Subscriber receiving a message. The recommended way to do testing in google-cloud-pubsub seems to be to spin up a local emulator, according to these instructions, but the Cloud SDK is prohibitive to follow this approach.
I looked for a way to inject mocks into a Subscriber, but nothing seems to have the desired effect of triggering a received message.

Can you explain why the Cloud SDK is prohibitive to use the local emulator approach?
The alternative way is to create an in-memory Subscriber mock stub using our MockServiceHelper:
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/SubscriptionAdminClientTest.java#L89

I meant "the Cloud SDK dependency is prohibitive", because e.g., we might not control the environment where our unit tests run (e.g., user building our library from their workstation).
The test you showed looks good. However, IIUC, MockServiceHelper depends on MockSubscriber and MockSubscriberImpl, which is code we'll also need and is located within the test folder, so we would need to duplicate this code. Would it make sense to move these classes to the same package as MockServiceHelper?

Actually, maybe not for the same package as MockServiceHelper, since it's not in google-cloud-java, but create a new "testing" package there and make those mocks available.

After looking into this more, I don't think MockServiceHelper isn't of much help for what I want (i.e., to mock a Subscriber). For example, MockSubscriber doesn't inherit from Subscriber, like I thought it did.
This seems to be very close to what we want. However, all this mocking machinery (TestReceiver/startSubscriber/sendMessages/etc.) needs to be extracted to a mocking utility class we can use.

We need to make sure that:

We have an easy way for users of google-cloud-pubsub to create mock implementations of publisher and subscriber
We have the documentation showing how to do that

Maybe (1) is already true, but I haven't taken a good look yet to verify.

Hey, any update on this?

Any update on this feature?

FYI @chingor13


Is there a way to use react components as nodes ?

There is this canvas ability to render html and then use that in SVG using foreign object interface.
https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Drawing_DOM_objects_into_a_canvas
I have something like this in my code, using svg.js:
        const nodeElement = document.createElement('div');
        // nodeElement servers as outlet
        foreignObject.appendChild(nodeElement);
        const props = { ...node, id: key };
        const element = React.createElement(NodeElement, props);
        ReactDOM.render(element, nodeElement, () => {
          foreignObject.draggy((x, y) => {
            const res = {
              x: Math.max(x, 0),
              y: Math.max(y, 0),
            };
            return res;
          });
          const item = { node, element, foreignObject };
          done(null, item);
        });

This helps me render the objects, that sick enough can be redux aware and data aware, which is awesome!
Do you think you could add this type of functionality ? To recognize react components as nodes ? Would be ok even if you need to enforce an interface. This is just a question, what do you think ?

+1

@iongion You can always use react SVG components and call renderToString from react-dom/server but I don’t think we get any fancy stuff that way unfortunately


move search bar

Description
Hello! I noticed the search bar was running into the nav text, so I moved it over a little.
Type of changes

[X ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

The search bar should remain centered. If there's some overlap, let's fine another solution.