kit.paths.base config setting seems like doesnt work

Describe the bug
I tried to set kit.paths.base  option at svelte.config.js, but seems like it has zero affect.
Documentation says that.
base — a root-relative path that must start, but not end with / (e.g. /base-path).
This specifies where your app is served from and allows the app to live on a non-root path

i.e. having svelte.config.js like
{
  kit: {
    target: '#svelte',
    paths: {
      base: '/base',
      assets: '',
    },
  },
};

I'm expecting to access all routes paths like /base/about etc
but getting Not found: /base/about
but /about is working independent of kit.paths.base
I thought it must be something like as https://nextjs.org/docs/api-reference/next.config.js/basepath but or its some other feature or its not working as expected
Reproduction
https://github.com/realadvisor/kit-paths-base-issue
npm init svelte@next my-app
# use defaults

then change config on
/** @type {import('@sveltejs/kit').Config} */
const config = {
  kit: {
    // hydrate the <div id="svelte"> element in src/app.html
    target: '#svelte',
    paths: {
      base: '/base',
      assets: '',
    },
  },
};
export default config;

npm install
npm run dev

open browser at http://localhost:3000/base/about and see 404
Logs
No response
System Info
System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (8) x64 AMD EPYC Processor
    Memory: 3.50 GB / 15.27 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 14.16.0 - ~/.volta/tools/image/node/14.16.0/bin/node
    Yarn: 1.22.10 - ~/.volta/tools/image/yarn/1.22.10/bin/yarn
    npm: 6.14.11 - ~/.volta/tools/image/node/14.16.0/bin/npm
  Browsers:
    Chrome: 91.0.4472.114
  npmPackages:
    @sveltejs/kit: next => 1.0.0-next.142
    svelte: ^3.34.0 => 3.42.1

### Severity

serious, but I can work around it

### Additional Information

workaround is moving routes at build time into subdirectory but that is so so behaviour.

Hmm. It looks like we might not have a test for this. We should probably set the base option in packages/kit/test/apps/options to test it. A PR to fix would be welcome if anyone wants to take a stab at it :smile:

Isn't this the same as #2886? If so this can be closed as this works in the latest version of Sveltekit.

I've verified this locally and it seems to work with the latest version as well. Closing this then.


Unit Test Support

I have been recently playing around with this library and I was really impressed with how it works.  I am looking at starting to introduce this with my company.  I was looking through the TODO list and I noticed that you were looking to improve the unit tests.  I would be willing to help out if you would be willing to accept PRs.  One of the things I saw was that the class rate-limiter.interceptor.ts was a little bit long (specifically the function getRateLimiter).  I was thinking this could be refactored into a series of smaller functions (i.e. one per type (Memory, Redis, etc).  If you think there are other areas that you could use help let me know (I have committed on a couple of open source projects in the past).

These days I focused on some new features instead of unit tests and cd & ci. But the other thing that you are saying about interceptor, yes that's definitely true. I am not the one who started this project, I took this project about 2-3 months ago, and during that time I did my best to make this library better. This month I have been working really hard on some other projects and I couldn't take a look at this project but refactoring the whole project code is also on my workplan.

@ozkanonur Thanks for accepting this PR.  I will create another ticket for some of the refactoring of the rate interceptor.  Thanks again


Important: Project folders disappear

Prerequisites

[Y] Can you reproduce the problem in safe mode?
[Y] Are you running the latest version of Atom?
[Y] Did you check the debugging guide?
[Y] Did you check the FAQs on Discuss?
[Y] Are you reporting to the correct repository?
[Y] Did you perform a cursory search to see if your bug or enhancement is already reported?

OS: Windows 8, 10
Atom: v1.7.4
@mojombo @Caged @schacon @defunkt @benburkert
Description
Project folders disappear
Right from when I've been using v1.0, this has been consistent. When Atom is closed and I open a file with Atom from Windows File Explorer, I opens the file in Atom and replaces my Project Folders, making the file name a Project in the Tree View and then I have to add all my Project Folders again.
I've always wanted to report this issue but I thought it would be fixed sooner.
Some help would be appreciated. Thanks.
Expected behavior: Atom keeps my project folders
Actual behavior: Project folders disappear and filename becomes a folder

I believe you are talking about https://github.com/atom/atom/pull/10862 https://github.com/atom/tree-view/issues/471 which (finally) has a merged PR and according to latest comments should be available starting from Atom 1.8.
I don't know how this will affect the launch story however as I have not tested the PR, maybe there is some other issue that causes you to have to add all the project folders again.

Yeah, you should be able to install the beta to resolve this issue.  Sorry for the inconvenience.


Tree column header has expand/collapse all icon

Closes #2521
See matching toolbox PR
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Am going to merge this now.
We may want to tweak it further visually, but that will be easier to do once we try it out in various applications.  Its currently opt-in, so low risk.


don't fail when no audio tracks

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Fixed tickets
fixes #issuenum

Related issues/PRs
#issuenum

License
MIT

What's in this PR?
Why?
    hls.auto_generate_representations()
  File "/envs/stream3.6/lib/python3.6/site-packages/ffmpeg_streaming/_media.py", line 113, in auto_generate_representations
    self.reps = AutoRep(self.probe.video_size, self.probe.bitrate, self.format, heights, bitrate)
  File "/envs/stream3.6/lib/python3.6/site-packages/ffmpeg_streaming/ffprobe.py", line 81, in bitrate
    audio = int(self.streams().audio().get('bit_rate', 0))
  File "/envs/stream3.6/lib/python3.6/site-packages/ffmpeg_streaming/_media_streams.py", line 29, in audio
    return self._get_stream('audio')
  File "/envs/stream3.6/lib/python3.6/site-packages/ffmpeg_streaming/_media_streams.py", line 61, in _get_stream
    raise ValueError('No ' + str(media) + ' stream found')
ValueError: No audio stream found

To Do

[ ] Create tests

Thank you for the pull request.
I merged the pull request but I just modified the file because it is not a good way to try and catch an exception that we throw it. it is better to handle it using an 'if condition'


Reverse geocoding only returns street and country

Reverse geocoding does not return locality (aka city)

https://best.osoc.be/v1/reverse?point.lon=4.465146&point.lat=51.160042
Does work, it seems like the whos on first dataset is not complete for belgium


Verifying signature is missing

Hi there,
So first things first, great works, so far we base our work on this repo to be able to use the cardano lib through a flutter app (so using the iOS/C wrapper).
But unfortunately even if we can generate signature it seems that the verify function from the cardano-serialization-lib is missing.
We saw some comment on the Android (nothing in the iOS one) version saying that it was a pending thing waiting for something, but it seems it may not be the case anymore? https://github.com/Emurgo/react-native-haskell-shelley/blob/master/rust/src/android/public_key.rs
// TODO: cannot implement yet since Ed25519Signature is missing.
// #[allow(non_snake_case)]
// #[no_mangle]
// pub unsafe extern "C" fn Java_io_emurgo_rnhaskellshelley_Native_publicKeyVerify(

Is there any reason to not have this function available, like a technical impossibility that we did not catch?
Thanks.

Hi @bhoudebert . We are working on adding almost all functions from latest CSL, you can track it on this PR https://github.com/Emurgo/react-native-haskell-shelley/pull/84

done


Implementing brand container, nav bar, and links.

I created the container for the brand logo and nav links connected to other pages. (Html only).

Hi @chykB, @dohoudaniel here.
Thank you for making the very first contribution to this project.
However, there are some changes that need to be made:

Please change the title of the home page to "Algorithmia SE 🌍"
Upload the website logo. It is in the images/website-logo/ directory of the repository.
Link the Bentham font to the home page.
Try linking the CDNs (Iconscout CDN and Google Font CDN) if possible, to implement the icons on the website.

However, please note that you are not to work on this alone.
You and the assigned people in this open issue will be working on it.
Thank you.

Hi @chykB.
Thank you for making edits to your PR.
However, there are some new updates and edits made.
The About Page and Contact Pages are no longer being implemented as seperate HTML pages.
The pages we now have are:

Home Page
Blog Page
Events Page
Projects Page.

Kindly see if you can make these edits in your PR.
Thank you for understanding.


Upload test results to CodeCov

CodeCov now supports uploading test results which allows e.g. flaky test detection and may allow us to remove BuildPulse.

Added the action to the allowlist so CI should run now. I don't see a re-run button so may need a force-push.

Thanks for help @Bo98!


Error after "Warning: No registry pull request was found for this version"

After registering a new package ( https://github.com/Jutho/StridedViews.jl ) it seems TagBot is not able to create the tag, and the action prints out the following warning:
Warning: No registry pull request was found for this version
Error: TagBot experienced an unexpected internal failure

See  https://github.com/Jutho/StridedViews.jl/actions/runs/4260560015/jobs/7413862625#step:3:44
TagBot.yml file was created with the latest version of PkgTemplates.jl .

I get the same error just now.

I also get this error. I updated my TagBot workflow file to the latest version given in the README and also set up new SSH keys, just to be sure, but neither solved the problem

Same here. Does it only happen with new pacakges? Rerun the workflow doesn't help.
Here is the log:
Did not find registry PR
Processing version v0.1.0 (1fd3ed4e3d60f84cd96d0fce9d177949079a1e29)
Generating changelog for version v0.1.0 (1fd3ed4e3d60f84cd96d0fce9d177949079a1e29)
Warning: No registry pull request was found for this version
Creating release v0.1.0 at 1fd3ed4e3d60f84cd96d0fce9d177949079a1e29
Error: TagBot experienced an unexpected internal failure
Traceback (most recent call last):
  File "/root/tagbot/action/__main__.py", line 94, in <module>
    repo.create_release(version, sha)
  File "/root/tagbot/action/repo.py", line 5[45](https://github.com/junyuan-chen/NonlinearSystems.jl/actions/runs/4581529946/jobs/8091119101#step:3:46), in create_release
    self._repo.create_git_release(
  File "/usr/local/lib/python3.8/site-packages/github/Repository.py", line 1059, in create_git_release
    headers, data = self._requester.requestJsonAndCheck(
  File "/usr/local/lib/python3.8/site-packages/github/Requester.py", line 315, in requestJsonAndCheck
    return self.__check(
  File "/usr/local/lib/python3.8/site-packages/github/Requester.py", line 340, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/releases/releases#create-a-release"}

Response (200): {
  "status": "Submitted error report"
}

I get the same error trying to register a new version of an existing package:

the commit: https://github.com/FedericoStra/ConservationLawsParticles.jl/commit/61985c67e696b68da47c226b1caebcd8e080ff9e
the merged registration: https://github.com/JuliaRegistries/General/pull/84967
the failing TagBot run: https://github.com/FedericoStra/ConservationLawsParticles.jl/actions/runs/5186972246/jobs/9348749127

The log:
Did not find registry PR
Processing version v0.8.3 (61985c67e696b68da47c226b1caebcd8e080ff9e)
Generating changelog for version v0.8.3 (61985c67e696b68da47c226b1caebcd8e080ff9e)
Warning: No registry pull request was found for this version
Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Error: TagBot experienced an unexpected internal failure
Traceback (most recent call last):
  File "/root/tagbot/action/__main__.py", line 94, in <module>
    repo.create_release(version, sha)
  File "/root/tagbot/action/repo.py", line [53](https://github.com/FedericoStra/ConservationLawsParticles.jl/actions/runs/5186972246/jobs/9348749127#step:3:54)3, in create_release
    self._git.create_tag(version, sha, log)
  File "/root/tagbot/action/git.py", line 107, in create_tag
    self.command("push", "origin", version)
  File "/root/tagbot/action/git.py", line 71, in command
    raise Abort(f"Git command '{cmd}' failed")
tagbot.action.Abort: Git command 'git -C /tmp/tagbot_repo_o779svb9 push origin v0.8.3' failed

Response (200): {
  "status": "Submitted error report"
}

I get the same.... :(
https://github.com/OceanBioME/OceanBioME.jl/actions/runs/5399088678/jobs/9805758047#step:3:43


Generate javadocs for Azure Tables

Add JavaDocs to be generated so we can move this out of the cosmos additional modules section. It currently is failing nightly builds.
RE: https://github.com/Azure/azure-sdk-for-java/pull/11661

Thanks for picking this up @conniey


Consider making @include apply("") do nothing, rather than producing an error

This is a small convenience thing, but it would be nice if:
.some-class {
    @include apply("");
}

did nothing rather than producing an error.
(In the process I'll describe later on today, I added classes to my HTML, and then added the classes to my CSS, and then started styling the classes. When I added the classes I added empty applys — but apparently you can't do that today. As I said: just a small convenience thing.)

Hey, @michaellenaghan thanks! This is a very easy change so happy to provide some extra convenience 👍
https://github.com/ThinkUniform/uniformcss/releases/tag/1.5.3


Twirl and Dotty

The Twirl plugin adds a library dependency, where we can't add Dotty compatibility.  Commented it for now on the Dotty branch, but we need a way forward.

fixed by #54 and #55


Classification with explainers

Is there a reason that 'aucroc' and 'aucprc' are the only metrics available for evaluate_estimator()?

Hello @marthajoddrell
Thank you for your question!
These are two of the more popular metrics for benchmarking classifiers, with no other particular reason.
Let us know if you want support for some other metrics, and we will try to include them in a future release.
Thanks!

Thank you for the response!
It would be helpful to have other popular metrics such as the actual sensitivity, specificity, etc and possibly also the confusion matrix. The clinical application we are exploring involves basic programming knowledge so it would be helpful if a detailed performance was easy available in the results.

Hello @marthajoddrell
Thank you for the feedback.
We will work and add the metrics you mentioned in the next release.


Bug 1163578

There is a typo in virtualEnv method , it is stating the user to make changes in vagrant machine which is not the case.

Coverage increased (+0.01%) to 91.94% when pulling 6a0354f74aae8458b0bb2a24ebe416b6937d81f2 on pemmasanikrishna:patch-1 into 83d9cbfed9483029da52c76fcc27abd2f1cf5419 on mozilla:master.

@pemmasanikrishna thanks for your contribution, nice catch! r+ :+1:


First pass at /web/events

@petele PTAL

Something funky happened in the build, restarting it.

@PaulKinlan - it (intentionally) went into the next-version branch, which I expect will fail since it's not fully set up yet.

OK it's all staged on devsite and i've added the new hotness to the commit

Updated. @petele PTAL


Add new reports documentation

🚀 Deployed on https://63ebfee459f06b1a85ee0865--cozy-fox-0defec.netlify.app


Always add style element to the head

My first element was a comment and was throwing on this line. I think it's safer to explicitly look for the head tag and add it there, not sure if there are performance implications tough.

s/tough/though/. Sigh.

@pdfjsbot test


Trained Arabic model results are reversed

I've finetuned an Arabic model using the same way reported at tesstrain to train with images, but when I test it it get the results fully reversed
I used this command to start training make training LANG_TYPE=RTL MODEL_NAME=ara_img TESSDATA=/home/shrouk/work/vlens/tesseract/tesstrain/data/finetune_from \ START_MODEL=ara_plusminus_addr_2 TRAIN_TYPE=FineTune
and this command to create the .traineddata file make traineddata MODEL_NAME=ara_img CHECKPOINT_FILES=data/ara_img/checkpoints/ara_img0_1898.checkpoint
Is there anything that I have to do to avoid this?

Hard to tell without sample data which allow for reproducing the problem.


fixed random vector to allow for all possible radian values, utilizin…

The existing logic does not traverse all possible radian values of the domain. This update will allow for that full traversal while also allowing for the offset to smoothly transition through all radians.

Separate from the PR, thank you for sharing this project with the world. It was very helpful in allowing me to create a voronoi shader for my current game. You're awesome.


Policy on requiring links to package source/docs/license?

I've run across a number of packages over the time I've been using Nuget where there is no license, no documentation,  no link to source code, and the project site is a generic top-level site to some company. I don't mean to pick on this particular one, but just as an example: https://www.nuget.org/packages/RealSense.CommandArguments.dll/
I'm filing this to start a discussion and potentially bring up some enhancements to help improve the nuget.org packages feed, as it's getting large and unchecked, I feel this situation will only get worse with time.
I can't find any policy on what is required to publish on nuget.org. At a minimum, it should be necessary to publish a license with all packages, as the default in most (all?) jurisdictions is that with no explicit license, you cannot use code or binaries, period. As such, it seems to me that nuget.org should actually reject publish requests for packages missing licenses.
Another thing that's unclear, is it acceptable to publish non-open code/binary packages on nuget.org?
If not, requiring a link to source code repository should be a minimum requirement. If it is, requiring a link to the place where you can license the code should be required (though perhaps the license link is enough for this).
One way to handle this is to contact the project administrator one-by-one, but this is hugely inefficient, and there's no guarantee the package maintainer will respond or do anything about it anyway. As a casual user that has no intent of using a particular package anyway, seems to be a waste of time. If we had comments it would at least be a low-friction way to call this out, but alas, comments were removed in #55.
So:

Should licenses be required to publish on nuget.org?
Is a non-open license allowed?
Should a link to source code be required?
Can we state and publish an official policy for this on nuget.org?
What is the mechanism that should be used for reporting violations of policy?

Great questions, and we are talking about requirements and validation for
packages to ensure that the package feed is maintained at a high quality
bar.  I think these are good items that we should consider for the
NuGet.org gallery and welcome discussion on them.
On Fri, Sep 18, 2015 at 11:55 AM, Greg MacLellan<EMAIL_ADDRESS>wrote:

I've run across a number of packages over the time I've been using Nuget
where there is no license, no documentation, no link to source code, and
the project site is a generic top-level site to some company. I don't mean
to pick on this particular one, but just as an example:
https://www.nuget.org/packages/RealSense.CommandArguments.dll/
I'm filing this to start a discussion and potentially bring up some
enhancements to help improve the nuget.org packages feed, as it's getting
large and unchecked, I feel this situation will only get worse with time.
I can't find any policy on what is required to publish on nuget.org. At
a minimum, it should be necessary to publish a license with all packages,
as the default in most (all?) jurisdictions is that with no explicit
license, you cannot use code or binaries, period. As such, it seems to me
that nuget.org should actually reject publish requests for packages
missing licenses.
Another thing that's unclear, is it acceptable to publish non-open
code/binary packages on nuget.org http://nuget.org?
If not, requiring a link to source code repository should be a minimum
requirement. If it is, requiring a link to the place where you can license
the code should be required (though perhaps the license link is enough for
this).
One way to handle this is to contact the project administrator one-by-one,
but this is hugely inefficient, and there's no guarantee the package
maintainer will respond or do anything about it anyway. As a casual user
that has no intent of using a particular package anyway, seems to be a
waste of time. If we had comments it would at least be a low-friction way
to call this out, but alas, comments were removed in #55
https://github.com/NuGet/NuGetGallery/issues/55.
So:

Should licenses be required to publish on nuget.org?
Is a non-open license allowed?
Should a link to source code be required?
Can we state and publish an official policy for this on nuget.org?
What is the mechanism that should be used for reporting violations
of policy?

—
Reply to this email directly or view it on GitHub
https://github.com/NuGet/NuGetGallery/issues/2688.

I just ran across another package where the linked license and project URLs doesn't exist anymore, resparking my interest in this.
So in the interest of moving this forward, personally, I'd suggest:

licenseUrl field is required (enforced as part of publish action: nuget.org rejects missing licenses)
License must be OSI-approved.
** In other words: go publish your binary/commerical packages on a custom nuget feed on your own server
projectUrl field is required
The project URL site MUST provide an obvious link to the source code for the package
** Acceptable: Github/Codeplex/Bitbucket/etc URLs, Pages/sites dedicated to this particular package (or the project this package is a part of)
** Not acceptable: Personal or company web page (unless it's largely about the package and has a link directly to the source code)

The "report abuse" page on nuget.org would also need to have a couple additional reasons added ("Inappropriate project site link", "Project site down/missing", "Source code link missing", "Non-OSI license").

bump
With C#'s popularity growing. Its really starting to get silly. There are so many "commerical" packages on nuget where you have to buy a license but theres no clear mention.

Thanks. Totally makes sense. We have added this to our backlog.

My personal thoughts on this are that it's fine for commercial apps to use NuGet under the following conditions.

There is a link to the license.  This might even be some way to extract the license from the NuGet package itself
The package is clearly marked as "commercial".
There is a link to the site.

It's obviously hard to enforce that these links actually do anything, but maybe the site should crawl the links from time to time to ensure the links are responding and mark them as dead if they are not.  (which of course won't catch parking sites, but it's a start).  Check that a) there is a dns record for the site, and b) that the site actually responds.
I do NOT think it's necessary to have an OSI-approved license, since any commercial license will obviously not fit that.  And there are many custom OS licenses that are perfectly fine free licenses, but not specifically OSI approved (for instance the typical "Use this as you will, don't sue me" license.  ie., essentially public domain.
Another important thing is documentation.  There should either be documentation in the package, a link to documentation on the project site (this one actually would hit a lot of Microsoft packages that just point to dot.net or asp.net homepage), or a link to source code such as GitHub repo.
There seem to be a lot of packages that are uploaded to Nuget for personal use, and are not intended to be used by the public at large.  We should discourage this.  It seems like the author is simply trying to avoid paying for their own Nuget server/binary repository.  Of course this is hard to enforce, but having the policies in place is a good start.  Requiring a modicum of information, such as license, project/documentation site, and a general description would help as well, even though we cannot enforce that these fields contain real or sensical information.
While we're at it, why not add a rating system, with possible review/comments, similar to Visual Studio Gallery (which, by the way, has already addressed issues some of these issues).  Number of downloads is a good indicator, but it's not really an indicator of quality (which I understand is highly subjective, but averages out over a large enough sample).
Finally, while I would never suggest that we prune or cull the repository, there should also be a way to add more filtering.  For instance, don't show me packages that haven't been updated in x timeframe.  Or even filter on some of the new fields we're talking about like license or don't contain documentation.

While I'm against banning of commercial packages, I'm all in favour of requiring a license statement. Without any license, the package is practically unusable. And having only a URL pointing to the license is not reliable - the contents behind the URL might change or vanish.
Thus, the licensing information should be contained within the package. There's currently a spec discussed which recommends either SPDX identifiers, or including the license file within the package. See https://github.com/NuGet/Home/wiki/Packaging-License-within-the-nupkg

Sorry for late reply but does the website support this expression for license GPL-3.0?


Breakpoints from all launch configs should be verified in compound config

Same setup as #68670

Put a breakpoint in /server/src/server.ts
It hits
Switch target to client from server
The breakpoint shows as "Unverified"
The breakpoint still hits

This is confusing. All breakpoints from compound config should be verified.
(Sometimes I ran into situations where if I switch from server to client, I'm unable to hit the breakpoints in server any more...But I'm not sure how to repro that.)


Added basic ar_DZ locale provider

This is just djug work fixed.

@FooBarQuaxx can you review the comments given?


Should refunds be permitted on the voting variants?

I think additional restrictions should be placed on the triggering of a refund to somewhat protect project creators / contract owners from being 'reverse rugged' by malicious actors just trying to defund them? I'm not sure but we need to try to cover all the bases on this.

I believe this issue is made irrelevant with the revised-voting branch but can be revisited if necessary.


chore: test merging back main to release

Description of changes

Test commits to test branches only to verify main-release sync
CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Testing merging back the changes from main to release after consuming the out-of-band release commit.


scanning timed out error

when run this command

yara -r juicy_files.txt D:\program_files

facing below error
error scanning D:\program_files\Android\platform-tools\NOTICE.txt: scanning timed out
error scanning D:\program_files\Android\platform-tools\sqlite3.exe: scanning timed out

This happens with YARA rules that are particularly slow. You can either improve the performance of your rules or change the default timeout with the --timeout argument.


[Coinswap] snapshot block number validation added

Fixes # .
Changes proposed in this pull request:

"latest" changed to "typeof snapshot === 'number' ? snapshot : 'latest'"

ChaituVR, shall we manually set a block number on each time we start a new voting?

@PawelGozdz Yep! your proposal selects the snapshot block number when you are creating a proposal, you can also change this block number by adding a snapshot param to proposal create page (maybe to select older blocks)
https://snapshot.org/#/yourspace.eth/create?snapshot=true


PromptOptions validations property is neither typed nor documented

Versions
Package 4.1.5
Node v10.13.0
Windows
Describe the bug
PromptOptions has a validations property on it:

It seems potentially useful for passing some additional validation logic, but it's unclear how to. The property is typed as an object and no docs/samples seem to mention how to use it.
[bug]

This was added as a way of passing through additional validation rules to a custom validator.  For instance you might want to pass a minLength value through to the validator routine.  We could update our samples to show this.

Seems like generics could help here:
export interface PromptOptions<T extends object> {
 // ...
  validations?: T
}

So here's a simple text length validation rule that would take advantage of the validation field:
this.addDialog(new TextPrompt('NamePrompt', async (prompt) => {
     const value = prompt.recognized.value || '';
     const minLength = prompt.options.validations.minLength;
     if (minLength != undefined && value.length < minLength) {
          await prompt.context.sendActivity(`Please enter a value that's at least ${minLength} characters long.`);
          return false;
     } else {
          return true;
     }
});

Then to call it from within a waterfall step you'd use this code:
async (step) => {
     return await step.prompt('NamePrompt', {
          prompt: `What is your name?`,
          validations: {
               minLength: 2
          }
     });
}

@Kaiqb can you please add this to the list of things needed documentation or samples?  Feel free to use the code snippets above.

@Stevenic - can you look at the issue around sendActivities not working within prompt validate?

We have a small amount of documentation about this in the About dialogs topic uner Prompt options and Prompt validation. Without a more comprehensive prompt validations sample, we're blocked on adding a how-to topic about this.


SingleProducerSequencer

@Override
public long next(int n)
{
if (n < 1 || n > bufferSize)
{
throw new IllegalArgumentException("n must be > 0 and < bufferSize");
}
    long nextValue = this.nextValue;

    long nextSequence = nextValue + n;
    long wrapPoint = nextSequence - bufferSize;
    long cachedGatingSequence = this.cachedValue;

    if (wrapPoint > cachedGatingSequence || cachedGatingSequence > nextValue)
    {
        cursor.setVolatile(nextValue);  // StoreLoad fence

        long minSequence;
        while (wrapPoint > (minSequence = Util.getMinimumSequence(gatingSequences, nextValue)))
        {
            LockSupport.parkNanos(1L); // TODO: Use waitStrategy to spin?
        }

        this.cachedValue = minSequence;
    }

    this.nextValue = nextSequence;

    return nextSequence;
}

=======================================================
cachedGatingSequence > nextValue   :What does that mean? Is that redundant
Thank you for your help

We have a method on the RingBuffer called resetTo which can be used to force the ring buffer to a specific value.  It is a method that shouldn't be used, but that check is in place to make sure that it doesn't break publishing.

We have a method on the RingBuffer called resetTo which can be used to force the ring buffer to a specific value.  It is a method that shouldn't be used, but that check is in place to make sure that it doesn't break publishing.

Thank you


Feature: Go To Definition For Tag Helpers (and View Components)

Is your feature request related to a problem? Please describe.
Finding the source of a Tag Helper (or View Component Tag Helper) is very difficult in a Razor view.
For Tag Helpers here is the process I go through to 'go to definition':

I need to hover over the syntax highlighted attribute/element
Look at the namespace/type name
Add a using to the Razor view (if its not already in scope)
Create a C# code block in my Razor view
Type out the name I saw when hovering
F12 that name token

For Tag Helper View Components I do the following:

Hover over the <vc:some-component /> in the Razor View
Create a C# code block
Type out the name that appears in the tooltip
Remove the __Generated__ prefix of the type name
Hope I didn't typo the name and try to import a using statement for it
F12 that name token

Describe the solution you'd like
When I put my cursor on a Tag Helper element/attribute (or View Component) in my Razor view, I can then type F12 and be taken to the definition, either in source code of my project or the type information from an assembly/package.
Applicable Scenarios
Whenever I use Tag Helpers or View Components. So, basically every time I do any server-side HTML rendering with Razor, which is going to be every app I work on.
Describe alternatives you've considered
The alternatives are explained above.
Additional context
There was an issue opened requesting this (https://github.com/dotnet/razor-tooling/issues/5586), but it was closed and marked as a duplicate. Unfortunately, it was incorrectly marked as a duplicate since the "duplicate" was for Blazor.
This seems to be the trend of things in ASP.NET Core. Anything related to Razor is assumed to be in the context of Blazor. Those of us doing server side HTML rendering with Tag Helpers and View Components are "last year's model" and have to wait for features to trickle down 😢.

Visual Studio:
Microsoft Visual Studio Professional 2022 (64-bit) - Current
Version 17.2.2

Tag Helpers that are coming from both external libraries as NuGet packages and within the same project as the Razor file using them.
Here's a screenshot of me hovering over an attribute tag helper (from the same ASP.NET Core 6.0 project). The tooltip works fine, but placing my cursor on the attribute and hitting F12 does nothing.

Again, these are ASP.NET Core Tag Helpers, not Blazor components. Does the Razor tooling treat these the same?


deprecated exist and replace it by existInDOM

Exist is ambiguous and is often confused with Visible, causing flaky tests by design.
Typical example:
alertBox.should(exist); // instead of alertBox.shouldBe(visible);
 // some actions which are okay, if alertBox is visible

Now, if alertBox is just hidden, but exist in DOM (very often the case), it will make test flaky.
The goal of this PR is to make very clear, that this condition is not the same as visible, and thus - reduce the use of it to only cases where it is really necessary (like checking some hidden fields to be present).
alertBox.should(exist) is an example of wrong usage.
Typical usage for exist is for example
 $("input[type=hidden][name=special_discount_field]").should(exist);

I'm also down-vote this changes. exist is quiet obvious.

Sorry, but exist is anything but obvious, I myself got trapped when I was using Selenide the first months.
For now the tests are failing which is bad, I will of course look to fix it.

Still not convincing enough. I'm not sure about this changes.

Exist is ambiguous and is often confused with Visible ...
Maybe, there is a need to provide more descriptive information for the Selenide Conditions (exist, visible etc.) for avoiding it. For instance, create a comparison table of the conditions.

I am not sure that using "DOM" term is a good idea. "DOM" is only applicable for web applications, but Selenide can also test mobile and desktop applications. In Selenide, $(locator).should(exist) means that elements should be findable by given locator. I cannot suggest better name for it than "exists".

@asolntsev @BorisOsipov propose to close this PR, give preference to exist condition and leave it without changes


Swiggy API

🎯 Title and Issue Number
[New API] : Swiggy API #391

Closes #391 <issue_no>

🗒 Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x]  I have gone through rules of when PR will get merged.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have followed proper file structure.
[x] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @sreevidya-16, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

@dinxsh, @Kritika30032002  view this PR and kindly merge into main

@sreevidya-16 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥
Happy Coding! ✨
Will See you soon❣


Improve styling of chrome extension

What happened?
Hello,I m gssoc contributor.
Styling of chrome extension is not good .Search bar is not placed well.Text are not not .
Please assign me this issue to improve styling.

How can we reproduce this bug?
I can make size of search bar and text are responsive
Desktop Information (Optional)
No response
Urgency (Optional)
Medium priority

Wrong Repository!


Link for the preprocessed WIDER dataset

It seems that the link to the WIDER dataset redirects to this repository. Could you kindly update the link?

We have updated the link to the preprocessed  WIDER dataset


Add support for Edgecast / Verizon Digital media WAF

https://www.verizondigitalmedia.com/blog/2014/12/a-waf-for-all-reasons-the-verizon-waf-is-now/

thanks for the request @kkirsche .. can you provide some details as to how it may be detected?
Is the regex for the Server header ECD \(.*?\) an effective way to detect it?

Yes, that will detect that it's part of the distribution network which the WAF is integrated into. Also, anything that applies to ModSecurity has the potential to detect it as the solution is based on ModSecurity (disclosed on https://www.verizondigitalmedia.com/bm-waf-whitepaper/)

In the past, we all the ModSecurity checks resulted in false positives and false negatives; i.e. they were terrible checks. If you can come up with a good check, please do share

Looks correct to me. Just tested it. Thanks for implementing this 👍


Starting a build fails, build container not found

Hi,
I just switched to 0.4.0 after running 0.3.0 for quite some time.
The installation worked fine, but when I try to start a build, the process fails within seconds "with error code 255"
sudo docker logs drone outputs:
 time="2015-10-29T11:12:25Z" level=info msg="preparing container drone_build_2_job_2"
 time="2015-10-29T11:12:25Z" level=error msg="error starting build container. Not found"
 time="2015-10-29T11:12:25Z" level=info msg="preparing container drone_build_2_notify"
 time="2015-10-29T11:12:25Z" level=error msg="Error starting notification container drone_build_2_notify. Not found"
 time="2015-10-29T11:12:25Z" level=error msg="error executing notification step. Not found"

Any idea what's wrong?
Cheers,
David

I was able to fix this by updating to the current docker version - mentioning some minimum requirements in the docs might make sense :)


esptool reset mode

Would be great if we can change the reset mode to be used by esptool, for uploading firmware to esp8266. As we know, esptool supports 2 reset modes now via -cd option: ck and nodemcu.
I check in this file platformio/platformio/builder/scripts/espressif.py, the -cd option is hardcoded to ck. Can I change that via platform.ini, or I should the source code of that espressif.py file?
Anyway, great progress so far! Definitely gonna keep using platformio.
Thanks.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28819308-esptool-reset-mode?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github).

Take a look on http://docs.platformio.org/en/latest/projectconf.html#extra-script
See related https://github.com/platformio/platformio/issues/247#issuecomment-118169728

Do you need a help with http://docs.platformio.org/en/latest/projectconf.html#extra-script ?

It would be great if you could provide an example for adding additional options, as my Python skill is very low. But that extra_script should do it for now.
If it's not too much for asking, the Arduino for esp8266 framework comes with boards.txt file. Is it possible to respect the settings in it? For example:
generic.upload.tool=esptool
generic.upload.speed=115200
generic.upload.resetmethod=ck
generic.upload.maximum_size=434160
generic.upload.maximum_data_size=81920
generic.upload.wait_for_upload_port=true
generic.serial.disableDTR=true
generic.serial.disableRTS=true

Thanks!

Create platformio_extra_script.py in the project near platformio.ini with the content:

from SCons.Script import DefaultEnvironment

env = DefaultEnvironment()

env.Replace(
    MYUPLOADERFLAGS=[
        "-vv",
        "-cd", "nodemcu",
        "-cb", "$UPLOAD_SPEED",
        "-cp", "$UPLOAD_PORT",
        "-ca", "0x00000",
        "-cf", "$SOURCE"
    ],
    UPLOADCMD='$UPLOADER $MYUPLOADERFLAGS',
)

Specify extra_script, for example

[env:esp01]
platform = espressif
framework = arduino
board = esp01
extra_script = platformio_extra_script.py

Did it help you?

Wow... Super helpful! Thanks man!
I'll try tonight. Will confirm the result.

Please re-open this issue if you still need help.

Sorry for late update. I can confirm that your guidance works. Thanks!

@ivankravets  could you explain the meaning of the  platformio_extra_script.py    because  i  don't learn Python.

Hi @andriyadi
Why do you need extra script option?
In two words it's just a python code snippet that can interact with build environment.


fix(plugin): compat issue for config sync

Summary
For 3.2, we added aws_imds_protocol_version for aws_lambda plugin, and aws_imds_protocol_version for zipkin plugin, but we did not add corresponding removed_fields entries.
Checklist
The Pull Request has tests -- N/A, we removed tests to removed_fileds as it does not mean much but causes flakiness.

[x] There's an entry in the CHANGELOG

There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com -- N/A, it's a bug fix
Issue reference
Fix KAG-725

I've manually tested the change and it works with <IP_ADDRESS>.
https://gist.github.com/StarlightIbuki/ee9f47617c165961e5aca2e60a23bf39
Using the compose and config it with new fields, we see the config is synced.

Adding a comment just to confirm that the fix worked fine in my manual tests too.


Commented moves

It is done! Thanks for your collaboration on this!
First I want to comment. Sorry for the really really messed up diff. I tried changing tabs to spaces for you with the [expand command] (http://linux.die.net/man/1/expand) and it jacked up all the spacing.
All that should have shown change in comment.js is I added two lines for $scope.updateUniqComments();
All that should have changed in kifu.js is between lines 123-225.  You'll see our sorting algorithm there. I added logic to ensure that the object keys are always sorted and take out the initial 0 branch paths you prune out as well elsewhere.  I also don't know if updating the kifu object every time I receive a new or deleted comment is the right move. I thought it was the simplest since the CommentControllers $scope.comments only included the current paths comments.  I also thought keeping $scope.kifu.comments up to date wouldn't really be right either since we would be keeping track of all comments it in two controllers.
If you feel otherwise we can change it.  Maybe commentcontroller doesn't keep it's own copy and we always update $scope.kifu.comments.

I (probably) won't get a chance to check this out till this evening, but I just wanted to say thanks! I'm looking forward to checking it out as soon as I can. :)

This is exciting! I have just a couple UI things I want to add to it (deactivate arrows when at the beginning / end of commented move list, for instance, and keyboard nav), but I'll try to get it launched asap. Thanks a ton!

I didn't even think of those! Great ideas!


Tines Webinar Prep: Okta and CloudTrail Rules/Scenario

Background
Two sets of scenarios and rules for the upcoming Panther+Tines webinar!
Changes

Basic Okta rules
Update CloudTrail dedup and alert contexts

Testing

Unit tests + full end-to-end testing with the send_data script (we should fold this functionality into the PAT at some point)

Looks like CI is broken:
ERROR: Cannot install -r requirements.txt (line 16) and aws-lambda-builders==0.6.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested aws-lambda-builders==0.6.0
    aws-sam-cli 0.31.1 depends on aws-lambda-builders==0.5.0

Looks like CI is broken:
ERROR: Cannot install -r requirements.txt (line 16) and aws-lambda-builders==0.6.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested aws-lambda-builders==0.6.0
    aws-sam-cli 0.31.1 depends on aws-lambda-builders==0.5.0

Looks like aws-sam-cli 0.31.1 was released back in Nov 2019, easiest way to resolve the conflicting deps is to upgrade the aws-sam-cli package

@lindsey-w @wey-chiang can one of you pls fix the dependency issue and I'll rebase?


Face detect error

It is not normal facial detection for a re-captured picture of an LCD screen called a "preview picture."

It is assumed that LCD screens are in poor pixel condition compared to normal images.
I should try Gaussian filter on the image

The use of Gaussian filter and bilateral filter resulted in ambiguous.
The above mentioned "preview image" wasn't detected normally, but the face was detected in images that had not previously been found

And I found a new package. It uses the CNN model to detect faces slowly but easily
Pypi : face_recognition
This package works very well. However, since pre-processing takes too much time, it would be use to re-apply only the photos that failed to detect faces while using the existing cv2 cascade method.

It is like chicken-and-egg problem to use deep learning for pre-processing to recognize faces using deep learning.😂

The test was tried in the mentioned.
There was one mistake, but the results were interesting.
First of all, the wrong color model setting for the CNN-classified face led to a blue-faced picture, but this made clear to distinguish visual images that performed Cascade and the images that carried out CNN.

CNN-based facial recognition did not make a false judgment which is classify a face that is not a face.
Therefore, I think not to use the cascade code but only the CNN face recognition.
However, doesn't need to completely erase the cascade code. If multiple faces are detected on the training data it can be used to delete the image using the advantage of having fast speed


androidenv: support aarch64-darwin, include patcher;v4 in the androidsdk

Description of changes

aarch64-darwin support
include patcher;v4 in the android-sdk
update repo.json

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

rebased


fix: secret key stored cleartext in memory

This PR prevents the wallet keyphrase from appearing in cleartext in memory.
TLDR changes:

Encode the keyphrase in memory;
Limit the usage of the decoded keyphrase;

Details
As reported in the Least Authority Security Audit Report in 2021, if an attacker can read/dump the user's browser memory while the extension is open and unlocked, it could steal the keyphrase and take control of the wallet.
The key is referenced in the following places:

Redux store
Redux memoized selectors
OnboardingGate  and AccountGate components. The AccountGate is kept mounted while the wallet is unlocked.

memory dump
1º fix: Encoding the keyphrase in memory
Instead of storing the keyphrase in cleartext, it is stored as Uint8Array. First, the key is encoded as a Base64 string and then converted to a Uint8Array. This approach offers the following benefits:

The secret keyphrase is no longer easily identifiable in memory as a sequence of 24 known English words.
Encoding the keyphrase in Base64 first ensures that the resulting Uint8Array does not directly correspond to ASCII table values (e.g., a in the keyphrase is no longer directly mapped to 97), making it even harder to be found in memory.

Also, don't memoize the decoded keyphrase using RTK createSelector.
2º fix: Limit the usage of the decoded keyphrase
Changed components OnboardingGate  and AccountGate to check if the keyphase exists in memory instead of getting it and storing it in a variable.

Thanks for the PR @adrianocola. I believe we'd need to encode this as a hex, rather than Uint8Array as I get this console error about serialisability

Hey @kyranjamie, thanks for the feedback! I’ve switched to using a hex string instead of a Uint8Array.
While using a Uint8Array would be fine since this state isn’t persisted and doesn’t require serialization, there’s no added benefit in doing so. Using only serializable values is more future-proof and doesn't cause any confusion with that console error.

Thanks for the great work @adrianocola, cloning this PR for CI to run

Merged the clone, thanks again @adrianocola


Pin pyshtools to 4.9.1 in multires generator Dockerfile.

Latest version of pyshtools uses Meson for building and does not build (missing dependencies, bumping ubuntu and adding listed here does not help, may be missing something obvious), thus proposing a quick fix to pin version and make it work again.

Seems like a reasonable fix. Thanks!

For future reference, it appears that libopenblas-dev is needed instead of libblas-dev, as is pkg-config.


Conditional reregistering interests in IoSourceState with mio_unsupported_force_poll_poll poll(2) based on IO operation result

Hello,
I'm playing mio (as dependency of Tokio) on Fuchsia. Since Fuchsia lacks epoll support, I opted to use mio_unsupported_force_poll_poll. Sidenote: The waker implementation via eventfd(2) appears to be functioning correctly on Fuchsia. Building mio for Fuchsia required some minor adjustments, primarily extending cfg gates in various places, such as tcp.rs.
My test setup includes a TCP (IPv6) listener that spawns a task for each connection, echoing data via tokio::io::copy. The client is either socat or a TcpStream in another task. I observed that the initial accept and the first data transaction work fine, but subsequent communication stalls.
The issue appears to be that the interests in the poll implementation are cleared whenever a poll returns revents, as seen here.
I compared the behavior on an x86 Linux system using the same test and analyzed the logs. The difference is that on Linux, the interest of a file descriptor (fd) is cleared and re-registered if the I/O operation returns WouldBlock as shown here.
On Fuchsia, however, the I/O operation returns (in most cases) Ok(..), and the interest is never re-registered, leading to the communication stall. Could this happen on Linux as well?
What's the rationale behind reregistering only on WouldBlock? My assumption is that e.g a read could return Ok(..) and the fd should be reregistered afterwards. I didn't dig into the Linux side yet.
Testwise I removed if let Err(..) condition around the reregistering and successfully smoke tested some example Tokio code and the mio tcp_server example .
I can share the modifications I did to mio. Same for updates on the integration of mio in Fuchsia that enable net and os-poll (+ Tokio features) if needed.
I know that mio_unsupported_force_poll_poll. I know that Fuchsia is unspported. :-)
Any thoughts on this?
Thanks! @flxo

I'm playing mio (as dependency of Tokio) on Fuchsia. Since Fuchsia lacks epoll support, I opted to use mio_unsupported_force_poll_poll. Sidenote: The waker implementation via eventfd(2) appears to be functioning correctly on Fuchsia. Building mio for Fuchsia required some minor adjustments, primarily extending cfg gates in various places, such as tcp.rs.

I ported Mio to Fuchsia in #1811. Hope that makes things a bit easier.

What's the rationale behind reregistering only on WouldBlock? My assumption is that e.g a read could return Ok(..) and the fd should be reregistered afterwards. I didn't dig into the Linux side yet.

Per Mio's documentation in https://docs.rs/mio/latest/mio/struct.Poll.html#readiness-operations. Mio's I/O types need to be "drained", that means calling the I/O method (e.g. read) in a loop until it returns WouldBlock. This is true for all implementations. However, for some implementations the I/O interest is already reregistered within the kernel when e.g. a read a shorter then the buffer. This is however platform specific behaviour that we can't make work across platforms. Hence the requirement for the draining (again the see the linked docs above).
Tokio has done this wrong in the past where it assumed that all Unix implementations had the in-kernel reregister on short read behaviour. In this if you search for espidf, which also uses the poll(2) implementation, you'll find the relevant code. But this is an issue you need to raise with Tokio as technically they are not adhering to Mio's API usage requirements.

I ported Mio to Fuchsia in #1811. Hope that makes things a bit easier.

Thanks for that. I'll prepare a PR to Fuchsia once mio is published with Fuchsia support. I tested basically the same.

What's the rationale behind reregistering only on WouldBlock? My assumption is that e.g a read could return Ok(..) and the fd should be reregistered afterwards. I didn't dig into the Linux side yet.

Per Mio's documentation in https://docs.rs/mio/latest/mio/struct.Poll.html#readiness-operations. Mio's I/O types need to be "drained", that means calling the I/O method (e.g. read) in a loop until it returns WouldBlock. This is true for all implementations. However, for some implementations the I/O interest is already reregistered within the kernel when e.g. a read a shorter then the buffer. This is however platform specific behaviour that we can't make work across platforms. Hence the requirement for the draining (again the see the linked docs above).
Tokio has done this wrong in the past where it assumed that all Unix implementations had the in-kernel reregister on short read behaviour. In this if you search for espidf, which also uses the poll(2) implementation, you'll find the relevant code. But this is an issue you need to raise with Tokio as technically they are not adhering to Mio's API usage requirements.

What do you mean with "in the past"? Should this be "fixed"? My testes are done with Tokio 1.32.1 which is the currently integrated version in Fuchsia. Should be easy to update test wise.
I checked espidf specific code in Tokio and mio and couldn't find anything "reregister" related. Can you please give me a hint?
So - I understand that my workaround just hides the missing reregistration from Tokio.

What do you mean with "in the past"? Should this be "fixed"? My testes are done with Tokio 1.32.1 which is the currently integrated version in Fuchsia. Should be easy to update test wise.

See https://github.com/tokio-rs/tokio/issues/5866 and https://github.com/tokio-rs/tokio/pull/5881.

I checked espidf specific code in Tokio and mio and couldn't find anything "reregister" related. Can you please give me a hint?

I'm not sure if it's still in but the code added in https://github.com/tokio-rs/tokio/pull/5881 would be it.

So - I understand that my workaround just hides the missing reregistration from Tokio.

Pretty much. Tokio incorrectly (for the poll(2) implementation) clear readiness on short reads.

conclusion for me is that I need to set mio_unsupported_force_poll_poll when building Tokio as well. Didn't know that. This needs to be done in the fuchsia build dedicated for Tokio. I just set it for mio.
Nothing left to be done within mio (main with #1811).
Thanks @Thomasdezeeuw

conclusion for me is that I need to set mio_unsupported_force_poll_poll when building Tokio as well.

It shouldn't be needed, but that is being fixes in https://github.com/tokio-rs/tokio/issues/5866, see https://github.com/tokio-rs/tokio/issues/5866#issuecomment-2188178491 and comments after.


No scrolling in Web Interface

When I open for example the Dynamic Settings Editor, I can't access all options, because the list is longer than my screen and there's no scroll bar (scrolling with mouse wheel has no effect). Same for the query window. I can't read my 100 entries, because I see only the top 10.
Affected Version
0.14.2-incubating on Ubuntu 19.04 in Firefox
Description

Configurations in use: The Quickstart Tutorial config
Steps to reproduce the problem:

Start the server (using the Quickstart Config)
Open the Web View
Open the Dynamic Settings Assitant
Try to see all options

The dynamic settings editor scrolling have been fixed and will be released as part of 0.15.0.
The query view has been fixed in master (did not make it for 0.15.0), it has also been made resizable so you can adjust the space between the query part and the results.

Thank you very much for sorting that out. Is a specific release date planned?

0.15.0 release candidate 1 will be probably out early next week. It would be great if you could test and verify that the scrolling issue is indeed fixed there.

Related to https://github.com/apache/incubator-druid/issues/7869.

With  #7871 this issue will be fully fixed in the 0.15.0 release.

This issue was fixed in 0.15 (and is still fixed in 0.16 :-p )


Portia (Vagrant) can`t open page behind a proxy

Hi,
I#m running Portia behind a company proxy using Vagrant (defining theProxy Settings in the Vagrantfile) on Mac OS 10.11.5. While the Portia interface itself starts without any issues (Note: I needed to change the port to 9001 in slyd.conf), I'm not able to open any website within Portia itself. Every requests results in:

Failed loading page (Socket operation timed out)
http://www.google.com
Network error #4

The logs from slyd say:

2016-08-17 17:33:32.339094 [-] "<IP_ADDRESS>" - - [17/Aug/2016:17:33:32 +0000] "GET /projects/Scoutia/spec/items HTTP/1.1" 200 48 "http://localhost:9001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36"
2016-08-17 17:33:32.703776 [-] "<IP_ADDRESS>" - - [17/Aug/2016:17:33:32 +0000] "GET /assets/ZeroClipboard.swf?noCache=1471455214194 HTTP/1.1" 200 6580 "http://localhost:9001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36"
2016-08-17 17:33:40.476439 [HTTPChannel,11,<IP_ADDRESS>] u'Websocket Closed: id=6776-35f6-9e65 t=9.570063482 user=defaultuser command='
2016-08-17 17:35:08.205747 [-] "<IP_ADDRESS>" - - [17/Aug/2016:17:35:07 +0000] "GET /static/empty-frame.html?a96d-aa88-0d95 HTTP/1.1" 200 194 "http://localhost:9001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/601.6.17 (KHTML, like Gecko) Version/9.1.1 Safari/601.6.17"

Any take on this one?

you may need to look at port forwarding.


Error thrown in EventBinding.dispatch() when make dispatcher to stop dispatching events of the type in an event handler

There is a possible minor issue in the Events API of version 3.0.0-beta.7
An error thrown in EventBinding.dispatch() when make dispatcher to stop dispatching events of the type in an event handler.
Uncaught TypeError: Cannot read property 'delete' of undefined
    at EventBinding.dispatch (VM7244 dev.js:32800)
    at EventDispatcher._dispatchHandler (VM7244 dev.js:3122)
    ...

here is an code sample:
this.events.once('EVENT_TYPE_EXAMPLE', (event) => {
  this.events.delete('EVENT_TYPE_EXAMPLE');
});

This should now work as expected.


Revert "solved #14 add entrypoint for dockerfile"

Docker image already has entrypoint inherited from base image. Inherited entry point actually is necessary to enable software collection library and allows ruby framework for 3scale toolbox.

cc @hguerrero


Where directives

Current implementation contains stringWhere directive as proof of concept.

[ ] field parameter
[ ] intWhere
[ ] floatWhere
[ ] booleanWhere
[ ] listWhere
[ ] validate type on which directive is used in normalisation

Also consider renaming directives to some more suitable format

Consider movingthose directives to standalone repository.


Fix: Correctly initialise the selected option based on initial value

Found an issue where when using react-hook-form and pass in an initial value. The selected option will not display in the popover trigger
 label.

thanks <3


Try replacing httptools.parse_url with Rust URL extension

Try replacing httptools.parse_url with Rust extension.
Why?
Because if we removed the HTTP Client implementation (I plan to do so in version 2), then httptools would only be used to parse URLs. It could be replaced by built-in URL parsing, or also as learning opportunity, by a small wrapper over a Rust library that can parse URLs.

I found that build-in urlsplit looks faster than httptools but doesn't provide error checking and doesn't split netloc by userinfo, domain, port as well as urlparse. So, using urlparse seems make all requests slower. And using urlsplit without additional parsers and format checking can bring other side effects.
Here are some measurements:
❯ python -m timeit -u usec -s "import httptools" -- "httptools.parse_url(b'https://user:password@example.com/users?filter=1#a')"
1000000 loops, best of 5: 0.339 usec per loop

❯ python -m timeit -u usec -s "import urllib.parse" -- "urllib.parse.urlsplit(b'https://user:password@example.com/users?filter=1#a')"
5000000 loops, best of 5: 0.0814 usec per loop

❯ python -m timeit -u usec -s "import urllib.parse" -- "urllib.parse.urlparse(b'https://user:password@example.com/users?filter=1#a')"
200000 loops, best of 5: 1.83 usec per loop

In [6]: httptools.parse_url(b'https://user:password@example.com/users?filter=1#a')
Out[6]: <URL schema: b'https', host: b'example.com', port: None, path:
b'/users', query: b'filter=1', fragment: b'a', userinfo: b'user:password'>

In [2]: urllib.parse.urlsplit(b'https://user:password@example.com/users?filter=1#a')
Out[2]: SplitResultBytes(scheme=b'https'<EMAIL_ADDRESS>path=b'/users', query=b'filter=1', fragment=b'a')

In [2]: urllib.parse.urlparse(b'https://user:password@example.com/users?filter=1#a')
Out[2]: ParseResultBytes(scheme=b'https'<EMAIL_ADDRESS>path=b'/users', params=b'', query=b'filter=1', fragment=b'a')

Thanks for the insight on this! By the way, I forgot to write an update here. The information I wrote above is not current anymore.

I was planning to remove the HTTP Client implementation in BlackSheep to have less things to maintain and possibly simplify the server implementation (as Request and Response classes wouldn´t have to be bi-directional anymore), but I changed mind when I measure the performance difference between my HTTP Client implementation and httpx.

https://twitter.com/RobertoPrevato/status/1596212734575747073
https://github.com/RobertoPrevato/temp-httpx-tests
Therefore the HTTP Client is staying in BlackSheep, and httptools won´t be easily replaced since it's used so much in the client. Moreover: I added several improvements lately and corrected bugs. I wrote a crawler recently with it and it works very well.


Feature/swig node

Description of the Change
This PR introduces NPM package called iroha-lib.
It contains an implementation of the shared library for NodeJS, package's build and deploy systems and also a bunch of Iroha fixes, allowing to build iroha-lib on Mac and Linux.
Huge thanks to @haojun, @laSinteZ, and @luckychess for help in implementing of this.

Benefits
This allows build and install Iroha library by NPM, so we can use it in Node.js

Possible Drawbacks
This is a deep pre-alfa version of the lib, so it can contain some errors, however, I didn't find any.

Usage Examples or Tests [optional]
You can watch examples in two places:

shared_model/packages/javascript/example contains example code distributed with NPM package to test it after installing by npm install iroha-lib
2.example/node contains working application and some instructions how to run it. This app use iroha-lib package.

Now example code in both cases is equal, but it uses for different purposes.
Alternate Designs [optional]
I had tried to implement build system using NPM packages like cmake-js or node-cmake, but these technologies seem not very mature yet. Building by such packages allows avoid using node-gyp, so we can seamlessly integrate CMake-based build system of Iroha with iroha-lib package.
It needs additional research I guess.

Related to #939

There are non-related commits, I guess reviewers should take this into consideration OR you should ping them as soon as you resolve the problem

This pr should be rebased onto actual develop.


Test pull request trigger

jenkins retest this please

Can one of the admins verify this patch?

jenkins retest this please


Linter Proposal: LeadingCommentSpace

I would like to propose a linter that's similar to what Rubocop has. It would throw a warning if there is no leading space in comments.
//bad comment
/*bad comment */

// good comment
/* good comment */

Let me know what you think! I would like to also implement this linter if you agree with this =)

Implemented in #825


prevent data races when throttle pokes in RocksDB's internals

Scope & Purpose
Backport of https://github.com/arangodb/arangodb/pull/16438
Prevent data races when throttle pokes in RocksDB's internals.
Performance and correctness impact of this change is yet untested and needs to be proven.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.9: (Please link PR)
[ ] Backport for 3.8: (Please link PR)
[ ] Backport for 3.7: (Please link PR)

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Obsolete.


Don't set SNI by default if hostname is not dNS name; fixes #8083

Don't set SNI by default (i.e. when -servername is not set) in clientHello if hostname is not dNS name
CLA not yet completed, will do asap
Fixes #8083
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Close/reopen to kick CLA bot

Oh...one other point. Please rebase this to remove the "merge" commit. We don't allow merge commits.

Oh...one other point. Please rebase this to remove the "merge" commit. We don't allow merge commits.

Fixed

The command-line is also used for testing.  Using the hostname automatically as the SNI if it looks like a hostname is the requirement.  Enforcing all DNS requirements is not.

Pushed to master and 1.1.1. Thanks!


not working

@prabhat1707 ?

sorry for delay @behbudovusal can u please share the log or scenario so, that I can fix this issue asap by EOD.

@prabhat1707 nothing happen.It worked 1 week ago.Now not working.I log but nothing happen

Mean while I am working can u check keys and other thing related to map
On Fri, 15 May, 2020, 15:46 behbudovusal<EMAIL_ADDRESS>wrote:

@prabhat1707 https://github.com/prabhat1707 nothing happen.It worked 1
week ago.Now not working.I log but nothing happen
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prabhat1707/EasyWayLocation/issues/11#issuecomment-629154621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEPBYKFU5CATJYIBJ5EI4LTRRUJAVANCNFSM4M55YW6A
.

@behbudovusal I just publish one update, please check.


Enhancing Internationalization Support

Summary
There have been several terra-i18n and terra-i18n-plugin requests and issues logged regarding how tranlsaitons are aggregated and loaded into an application. To address these, a major version bump will be needed to support the following are changes:

Only load the specified aggregated-tranlsation locales. Fixes the i18nLoader which always attempts to load the terra-supported locales: https://github.com/cerner/terra-core/issues/855
Fallback to base locale if regional locale is not present: https://github.com/cerner/terra-core/issues/854

Fallback to 'en' if base locale fails to load.

Open up the i18nLoader restriction to terra-supported locales such that non-terra-supported locales will load.
Allow regex serach pattern specification for indicating where translations directories are located: https://github.com/cerner/terra-core/issues/1258
Recursively build the aggregated-translations output directory: https://github.com/cerner/terra-core/issues/1247

Accomplishing These Changes
To resolve the requests and issues outlined above, the proposed change would be to create an aggregate-translations pre-build script which would replace the use of the terra-i18n-plugin. The aggregate-translations script would be ran before startng webpack and would:

Aggregate the translations in the specified translation directories for the specified language locales. This step produces a 1-to-1 output to the terra-i18n-plugin, but will use globbed search patterns to build the aggregated translations instead of recursively searching on a strict pattern or searching within one specified directory.
Create new intlLoader and translationLoader files on each aggregate-translations execution. These files will only contain filer loader information for the specified locales. This fixes https://github.com/cerner/terra-core/issues/855 as with the current behavior, webpack will transpile this file and attempt to access the non-existent locale files and throw errors, even if the file were not currently being loaded.

The aggregate-translations script will have the following options:

-s or --search: the regex pattern to glob search for translations. Multiple patterns can be specified and will be added to the default search patterns.
-l or --locales: The list of locale codes to aggregate on and combine into a single, respective translation file. The default will be the terra-supported locales.
-f or --file-system: the filesytem to use when writing the aggregated translations and loader files
-o or --output: the output location for the aggregated translations and loader files

Then, in the webpack.config.js file, one would only need to add the aggreated-translations output directory path to the resolve.modules list. This cleans up the configuration as follows:
const webpack = require('webpack');
...// other loaders & plugins
-const I18nAggregatorPlugin = require('terra-i18n-plugin');
-const i18nSupportedLocales = require('terra-i18n/lib/i18nSupportedLocales');

module.exports = {
  entry: {
    ... //entries
  },
  module: {
    ... // loaders
  },
  plugins: [
-    new I18nAggregatorPlugin({
-      baseDirectory: __dirname,
-      supportedLocales: i18nSupportedLocales,
-    }),
    ... // other plugins
  ],
  resolve: {
    extensions: ['.js', '.jsx'],
+    // This line would remain the same and provide the aggregated-translations files and loaders as modules to terra-i18n.
    modules: [path.resolve(__dirname, 'aggregated-translations'), 'node_modules'],
  },
  ...
};

Locale Fallback
Locale fallback will be handled as follows:

Load the es-US aggregated-translations file --> if no aggregated-translations file, load es ggregated-translations file --> then load the en aggregated-translations file --> if no file, fail

This fallback approach only supports the fallback of a missing aggreagted-translaiotns file. This does not support fallback for missing translations messages within an aggregated-translations file. If a translations message is missing, the intl message key will display.
With enabling this fallback method, terra-base will always fallback to loading english translations. The https://github.com/cerner/terra-core/issues/1149 issue was logged to allow for the use of terra-base without translations, which overall would be a bad-practice for setting up an application consumers terra component. If https://github.com/cerner/terra-core/issues/1149 remains valid, terra-base will changes to provide a non-intl-provider setup.
Opening Up Locale Restrictions
These updates will not allow non-terra-supported locales to be loaded within an application. For anyone choosing to use non-terra-supported locales, they will be notified that the locale is not supported and will responsiblity for supplying the correct message for the localized terra componnets. Failure to do so will result in the intl message key to display.
Additionally, to use non-terra-supported locales, users are responsible for ensuring intl supports the locale otherwise failure will occur when loading the locale data from intl.

I'd like to have the aggregate-translations cli also be able to be required callable from within code directly to give people greater flexibility in how they want to run the command. For instance i was thinking we could run it at the beginning of our default terra-dev-site webpack config.

+1 on tech design and the major version bump.

With @mjhenkes suggestion, I propose we change the -s, --s CLI flag to be -d, --directories and then provide the aggregateTranslations() setup function. This function would accept an options object as a parameter that would honor the keys:

directories: default to []
fileSystem: default to fs
locales: default to terra-supported locale list
outputPath: default to ./aggregated-translations

This would give the option within the webpack as:

 This would give the option within the webpack as:
const webpack = require('webpack');
...// other loaders & plugins
-const I18nAggregatorPlugin = require('terra-i18n-plugin');
-const i18nSupportedLocales = require('terra-i18n/lib/i18nSupportedLocales');
+const aggregateTranslations = require('terra-i18n').aggregateTranslations;

+aggregateTranslations({
+    locales: ['en', 'es'],
+    directories: [path.resolve(__dirname, 'custom_translations')]
+});

module.exports = {
  entry: {
    ... //entries
  },
  module: {
    ... // loaders
  },
  plugins: [
-    new I18nAggregatorPlugin({
-      baseDirectory: __dirname,
-      supportedLocales: i18nSupportedLocales,
-    }),
    ... // other plugins
  ],
  resolve: {
    extensions: ['.js', '.jsx'],
+    // This line would remain the same and provide the aggregated-translations files and loaders as modules to terra-i18n.
    modules: [path.resolve(__dirname, 'aggregated-translations'), 'node_modules'],
  },
  ...
};

+1

+1 on tech design and the major version bump.

+1 on tech design and major version bump.

Proposal Updates
Initially it was thought a major version bump was necessary to handle the necessary changes needed to only load the specified aggregated-translation locales, #855. After some realization on the undertaking of what a major version bump would entail, more thought was put into how passivity could be maintained while still achieving the proposed changes outlined above:
Resolving Loader Errors:
Above, it was proposed to create the i18n pre-build aggregate-translations script/setup function, which would create the intlLoader and translationsLoader modules that are configured for the locales specified. This would remove the previous build errors that would result in the web pack statically analyzing the i18nLoader file and attempting to resolve the module path for each terra-supported locale.
To maintain passivity and remove the need for a major version bump, a postinstall write-default-loaders script will also be added. This write-default-laoders script will write intlLoader and translationsLoader modules to the node_modules directory of the terra-i18n package.
How this solve maintains passivity:
The current web pack resolver.modules configuration is as follows:
resolve: {
    modules: [path.resolve(__dirname, ‘aggregated_translations’), 'node_modules'],
}

This resolve.modules configuration indicates module resolving occurs in this order:

./aggregated_translations
./node_modules

Here is a clear, high level explanation on node’s algorithm for resolving modules. Given web pack uses the enhanced-resolve function to resolve file paths while building, and it includes the node filesystem, this resolution
algorithm allows us to create these “dynamic” intlLoader and translationsLoader modules to maintain passivity with the i18n changes.
So, take loading the intlLoader module for example, these module algorithms used in web pack/node will resolve from terra-i18n as:

First searches for ./aggregated_translations/intlLoader.js

If using the pre-build step, the module is loaded from here & will only load the specified locales

Searches for terra-18n/node_modules/intlLoader.js

If using the i18n-plugin, the module is loaded from here and will load each terra-supported-locale as perviously loaded


Running predefined unit tests in the SWE-agent docker container

Describe the issue
Hello, thank you so much for the nice work.
For each task instance in the SWE-bench-lite, there are corresponding unit tests (PASS_TO_PASS and FAIL_TO_PASS).
I am trying to run the unit tests in the docker container corresponding to certain task instance like:
# load SWE-Bench Lite dataset
dataset = datasets.load_dataset("...")

# define environment argument
args = EnvironmentArguments(dataset)

# initilaize SWEEnv
env = SWEEnv(args)

# reset task instance 100
obs, info = env.reset(index=100)

# get a pre-defined unit test corresponding to 100th task instance
pass_to_pass_test = dataset[100]['PASS_TO_PASS'][0] # (e.g., "tests/migrations/test_writer.py")
fail_to_pass_test = dataset[100]['FAIL_TO_PASS'][0]

# run the pre-defined unit test in the docker
obs_1, reward, done, info = env.step(f"pytest {pass_to_pass_test}")
obs_2, reward, done, info = env.step(f"pytest {fail_to_pass_test}")

What I expected was: obs_1 does not include any execution error and obs_2 includes error message.
However the issues are:

depending on the task instance, unit testing PASS_TO_PASS unit tests result in error (especially in task related to django library)

It seems like FAIL_TO_PASS unit tests are not present in the docker container for the task instance.

I think issue 2 is natural but issue 1 is strange, as PASS_TO_PASS unit tests have to be run successfully.
Optional: Relevant documentation page
No response

Yes, 2 is natural indeed, because those are mostly the issues that were added in the gold solution PR. Hmm i) shouldn't happen ideally. Could it be that the environment is not set up properly? Do you observe issues with running swe-bench gold validation on the instances from i) ? If yes, please open a bug report over at https://github.com/princeton-nlp/SWE-bench.
But also swe-agent at the moment has diverged a little bit from swe-bench. swe-bench now builds new docker images for every instance, whereas swe-agent is starting from a base-image and then pip/conda installing things on top, which is a bit more brittle. This will be different in swe-agent 1.0.0 where we will get rid of all of the setup stuff and simply use docker images from swe-bench. Hoping to get this out this week or the next

Closing because of inactivity.

Apologize for the late response.
Typical reasons for ground-truth test failure seem to be a environment variable.
Below is an example of the test failure. Although I ran the test after applying the test patch, the test resulted in failure.
I have not tried sweagent-v1.0.0, but I will try it!
Does the sweagent-v1.0.0 currently use swe-bench docker images?
============================= test session starts ==============================
platform linux -- Python 3.11.11, pytest-8.3.4, pluggy-1.5.0
rootdir: /django__django
configfile: pyproject.toml
plugins: cov-6.0.0, timeout-2.3.1
timeout: 30.0s
timeout method: signal
timeout func_only: False
collected 0 items / 1 error
==================================== ERRORS ====================================
_______________ ERROR collecting tests/migrations/test_writer.py _______________
tests/migrations/test_writer.py:31: in
from .models import FoodManager, FoodQuerySet
tests/migrations/models.py:9: in
class ModelWithCustomBase(models.Model, metaclass=CustomModelBase):
django/db/models/base.py:129: in new
app_config = apps.get_containing_app_config(module)
django/apps/registry.py:260: in get_containing_app_config
self.check_apps_ready()
django/apps/registry.py:137: in check_apps_ready
settings.INSTALLED_APPS
django/conf/init.py:84: in getattr
self._setup(name)
django/conf/init.py:64: in _setup
raise ImproperlyConfigured(
E   django.core.exceptions.ImproperlyConfigured: Requested setting INSTALLED_APPS, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.
=========================== short test summary info ============================
ERROR tests/migrations/test_writer.py - django.core.exceptions.ImproperlyConf...
=============================== 1 error in 1.05s ===============================


Add ColorSpace option to H264Encoder

Enables H264Encoder so encode either in YUV420J (the default) or YUV420.

Do you see lighter colors in your encodes with the change?
I think h.264 should be 420 all the time. I remember I changed from 420 to 420J trying to fix the same problem -- video being to dark. Do you mind if don't merge it just yet until I actually investigate the color issues? The problem might be somewhere in the filter stack.

Yes, when I set the colorSpace to yuv420 (instead of the default yuv420j), the colors in the created mp4 file now reflect the colors from my input PNGs.
When I encode using the default yuv420j, the dark-gray colors become black in the movie.

I think h.264 should be 420 all the time

In my code, H264Encoder currently only supports YUV420 and YUV420J as color spaces, and no others. I've included a test case that ensure that.
In my experience, Apple's QuickTime Player only supports formats very close to their standards -- especially in contrast to VLC or similar software. And QT plays my files without problems. FFMPEG allows the creation of H264-movies with YUV422 encoding, which QT refuses to play.


Developer story: I want pages to be automatically populated from metadata

As a developer, I want to create the metadata file and get this automatically translated to its corresponding page. For instance, if I have metadata about a dataset, this should create a new Dataset entry under the folder Datasets.
For this we need to:

[ ] Create a metadata folder under the root
[ ] Create the same subfolders as for the pages structure
[ ] Create a metadata sample for any of the categories=folders
[ ] Implement the code needed to take the metadata and create a new page under the right category


Is this project MIT-license compatible

Hi Michael,
is it possible to add the inputsimulator as part of an open-source-project under M.I.T. license if we link to this project page and name your authorship?
BR,
tom

Hi,
@michaelnoonan  it would be good to get an answer as to what the licence of this project is.
I see there a couple of forks that have added a licence, but (and I am not a lawyer!) that seems legally questionable.
Regards
John Cullen

Hi all. Sorry, I've not paid attention to this library in some time! It's now licensed under MIT.

@michaelnoonan On NuGet you had indicated (in 2013) that it is MS-PL licensed. I'm only mentioning this so that you know where the reference to the MS-PL license originates from in some forks (including mine).

Ah, that makes sense. I do recall the original version being shipped via CodePlex with MS-PL. When the code moved to GitHub, I neglected to set a license, meaning the code here was copyright by default.
I'm happy for this to open up to MIT as a more permissive license as long as you are happy to contribute changes from your fork under MIT. The alternative is we change the license of this repository to MS-PL instead of MIT.

I personally have no problem with any open source license. I think MIT is a better choice overall.

Thanks for sorting this out so quickly guys.


wpvulndb.com api v2 is dead

I believe I'm experiencing something similar. I've been getting the following when I run this command:
`-----------------------------------------------
Checking core vulnerabilities for version 5.3
Error: Couldn't check wpvulndb @ https://wpvulndb.com/api/v2/wordpresses/53 (HTTP code 404)`

Just removed the APIv2 methods. APIv3 is now default and requires the usage of --token on the commandline. It will error if you omit the parameter.

seems reasonable. thanks dude!

Thank you for the quick turn around. I'm now recieving a 401 error when I run with v3 and my token:

Could you try without the brackets? [ ]

Yep, that worked. I guess I was a little confused by the manual. Thank you.


convert javascript object into java abstract class

I want to convert some JavaScript object into a Java object, but with some methods defined by the JavaScript and other methods defined by Java.
This works

interface Test {
  public void doSomething();
}

String javascript = "var thing = { doSomething: () => {/* whatever... */} }";

Context context = Context.create("js");
Value jsBindings = context.getBindings("js");

context.eval("js", javascript);
Value thing = jsBindings.getMember("thing");
Test test = thing.as(Test.class);

But when I try it with an abstract class that has some methods already defined in Java

abstract class Test {
  public abstract void doSomething();

  public void doSomethingElse() {
    someNativeJava();
  }
}

String javascript = "var thing = { doSomething: () => {/* whatever... */} }";

Context context = Context.create("js");
Value jsBindings = context.getBindings("js");

context.eval("js", javascript);
Value thing = jsBindings.getMember("thing");
Test test = thing.as(Test.class);

I get the error

Caused by: com.oracle.truffle.polyglot.PolyglotClassCastException: Cannot
convert '{doSomething: {...}}'(language: JavaScript, type: Object) to Java
type 'Test': Unsupported target type.

Extending (abstract) classes with Value.as is not supported (yet).
I'd suggest to implement an adapter class on Java side, that uses either Value.as(Interface.class) or the Value directly:
class MyTest extends Test
  final Value impl;
  MyTest(Value impl) { this.impl = impl; }
  public void doSomething() {
    impl.invokeMember("doSomething");
  }
}

Also note that you may use Java.extend for that purpose:
var MyTest = Java.extend(Java.type("x.y.Test"));
var thing = new MyTest({doSomething: /*...*/});

Value.as with abstract classes is supported since 20.3.0. Your code works now (but host access has to be allowed, e.g. Context.newBuilder("js").allowHostAccess(HostAccess.ALL).build()).


bugfix: update SafeMap item just call Put, no need call Remove

Signed-off-by: Michael Wan<EMAIL_ADDRESS>Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@allencloud  thanks a lot for your carefully code review, I should pay more attention to code quality :)

Codecov Report

Merging #1175 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
+ Coverage   15.97%   15.97%   +<.01%
==========================================
  Files         176      176
  Lines       10130    10128       -2
==========================================
  Hits         1618     1618
+ Misses       8394     8392       -2
  Partials      118      118

Impacted Files
Coverage Δ

daemon/mgr/container.go
0% <ø> (ø)
:arrow_up:

LGTM


Infra/fairspc 23 GitHub actions ci

NOTE: agreed with Frank that first we need to discuss all together the release strategy and tagging strategy before accepting the approach from the pull request. I will schedule a call on the beginning of January

Two new Github Actions CI workflows were introduced. One is for build services on pull request related events (all jobs for services are run in parallel). Another one is for pushes to 'dev' branch (flow described in the 'build_and_upload_on_push_to_dev.yaml' file)
TravisCI related files are still present: new tickets to be created to introduce workflows for documentation, releases, tags, etc.
Now versions (images' tags) are equal for all images per build and unique (date-time is appended)

PS: all commits will be shrinked into one with proper message on merge

TBD: release strategy + tagging

Agreed with @ewelinagr and @FrankyHollywood :

to hold only the latest version of snapshots (no timestamps needed)
add the release flow triggered on a merge to the release branch: (RELEASE-[version])
commit a minor version increment change once release has been created
create ticket for helm charts


materializecss v1.0

Can not reproduce. Please check the console of the developer tools in your browser.

Possibly related to https://github.com/Dogfalo/materialize/issues/5352

Duplicate of #5352


sixel painting to not destroy existing contents

you'll then see that Contour draws the image on a black background, annihilating the glyphs underneath, unlike other sixel implementations which interpret unspecified pixels as transparent =]. fixing that would be the thing that earned you the most high marks in my book =].

Challenge excepted. 💣 I see what I can do to get it into the next bugfix cycle (release 0.2.1), as that can be seen as a fix too, because that's how xterm is rendering it, right?

Copying my comment from the notcurses discussion, in case you don't see it there:

Note that transparency is dependent on the Background Select parameter (P2) of the sixel escape sequence. The background should only be transparent if P2 is set to 1. Xterm doesn't handle this correctly, so please don't copy their behaviour exactly.

Note that I was wrong about P2 not having any effect when raster attributes are set is wrong. It looks more like it's the other way around, i.e. the dimensions specified in the raster attributes have no effect when P2 is set to 1.
For example, consider an image like this over a background of Es:
echo -e '\ePq"5;1;120;60#1!60T-!60T-!60T-!60T\e\\\n'

The image is 120px high while the raster attribute height is given as 60px, so the half that extends below that point will have the underlying text showing through, despite the fact that P2 is not set to 1.
But if you do set P2 to 1, I suspect the background will not be filled at all, so all the zero pixels in the image will be treated as transparent, and the dimensions specified by the raster attributes are irrelevant.
echo -e '\eP;1q"5;1;120;60#1!60T-!60T-!60T-!60T\e\\\n'

I have to sadly admit I am ignoring the aspect ratio

Not many TEs handle aspect ratio correctly, so if you don't intend to support legacy VT340 and VT240 applications, it's probably not a big deal. Occasionally you may come across old sixel images from the VT240 that depend on AR, because it only supported 2:1, but I don't think it's that common. I just find it useful for test cases, because it's so convenient when you just need to output simple block structures, so I use it all the time.

Note that I was wrong about P2 not having any effect when raster attributes are set. It looks more like it's the other way around, i.e. the dimensions specified in the raster attributes have no effect when P2 is set to 1

this matches my intuition (save that the terminal might use them to optimize something).

I have to sadly admit I am ignoring the aspect ratio (if provided) currently. I take the pixels as is. I am absolutely fine in fixing that. But until now it seemed (!) sufficient for modern apps as that's never set anyways.

fwiw, i never use them, since it doesn't make any sense to me how aspect ratio could be enforced on a pixel (and images don't always include information on their "pixel aspect ratio").

it doesn't make any sense to me how aspect ratio could be enforced on a pixel

Think of it as similar to line doubling. If the AR is 2:1, every scanline in the image is output twice, if it's 3:1 they'll be output three times, etc. Aspect ratios are only ever integer values.

images don't always include information on their "pixel aspect ratio"

If it's not specified, I believe the default is meant to be 2:1, for backwards compatibility with the VT240 (possibly also the VT125).

Think of it as similar to line doubling. If the AR is 2:1, every scanline in the image is output twice, if it's 3:1 they'll be output three times, etc. Aspect ratios are only ever integer values.

ahhh ok so the result isn't necessarily what you specify; this is strictly a blowup. got it. still kinda neat!

If it's not specified, I believe the default is meant to be 2:1, for backwards compatibility with the VT240 (possibly also the VT125).

i meant the source material, i.e. pngs and such.