[$2000] Deep link routing is inconsistent when the app is open

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

1) Magic sign in Success

Create a new account
Kill the app
Tap the magic sign in deep link
After setting a password, you will be taken to the LHN, with the FAB modal opened ✅

2) Magic sign in Failure

Create a new account
Background, but do not kill the app
Tap the magic sign in deep -ink
After setting a password, you should be taken to the LHN, but the FAB will not be shown! ❌

3) Admin chat failure

Sign in to an account without an open workspace
Tap the fab button, and create a workspace
Await the Notification from the support team member
Do not kill the app
Tap this notification
You might be taken to the LHN (known, separate issue)
Swipe right to the chat
It should be the #admins chat, but is often an entirely different chat :x:

Solution
Figure out why the deep-links aren't working as expected while the app is open.
Actual Result :
on signin it navigates to chat screen with concierge
Workaround:
unknown
Platform:

Where is this issue occurring?

Android

Version Number: 1.2.41-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/208468844-5bce9f90-81d5-4b82-a60d-4e0d7a14be21.mp4
https://user-images.githubusercontent.com/43996225/208468927-7bad869a-b8a4-4d09-9ba6-6931ffb1bab0.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671280997504769
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0106e69a3f4a655640
Upwork Job ID:<PHONE_NUMBER>942157824
Last Price Increase: 2023-01-16

On it

Started convo re: repro steps

Commented here. I believe this isn't worth fixing and will cease to be a problem after we rework our app navigation.

Closing as dupe for 9179

Based on our Slack discussion, that might be premature. I'm going to see if I can provide any evidence for my belief that it'll be resolved by our navigation changes.

After a lot of testing, I believe this is a good overview of deep linking:
Magic Sign in deep link

If you kill the app before tapping the magic link, the FAB will always be shown ✅
If you don’t kill the app before tapping the magic link, the FAB will never be shown ❌

Workspace message deep link

If you kill the app before tapping the link, you will always be taken to the LHN, but technically the #admins chat is open. Swiping right will show it ✅ :
If you don’t kill the app before tapping the link, there is no guarantee what will happen. Most of the time the behavior is the same as above, but sometimes you’ll be taken to the LHN, but with the Concierge chat shown when swiping right ❌ ❓

So, I believe there are two main problems here:
A) Because of this known issue, the user is taken to the LHN instead of the specific deep link chat. This is because of our weird navigation hierarchy, where both the LHN and Chat page are at the same level (mirroring web/Desktop). This will cease to be a problem once we implement the navigation improvements because LHN and the Chat pages will be completely separated
B) In addition, deep links do not always work correctly when the app is already open. This should be investigated further.

Nice, thanks Jules. So it's this we focus on here right?

B) In addition, deep links do not always work correctly when the app is already open. This should be investigated further.

Yikes, that one seems like quite the project, right? I'd want to make sure that we also consider whether there are broader improvements, and potentially even a refactor of sorts for consideration.

Yikes, that one seems like quite the project, right?

Yeah I agree, I'd love to take a deep dive into deep linking, but this will have to wait until Manual Requests and Notification polish is done.
I think we can move forward for now by updating the issue to focus on B, and opening it up for external contributors for now. Solving the bug (even temporarily) without a major rework would be a nice outcome.

Deep link routing is inconsistent when the app is open
Problem
Our deep linking is often inconsistent while the app is open. With the app killed, deep link routing is far more consistent.
Steps
1) Magic sign in Success

Create a new account
Kill the app
Tap the magic sign in deep link
After setting a password, you should be taken to the LHN, with the FAB modal opened

2) Magic sign in Failure

Create a new account
Background, but do not kill the app
Tap the magic sign in deep -ink
After setting a password, you should be taken to the LHN, but the FAB will not be shown! :x:

3) Admin chat failure

Sign in to an account without an open workspace
Tap the fab button, and create a workspace
Await the Notification from the support team member
Do not kill the app
Tap this notification
You might be taken to the LHN (known, separate issue) ✅
Swipe right to the chat
It should be the #admins chat

Solution
Figure out why the FAB isn't shown on first login if the magic-sign in deep-link is used while the app is open.

If we all agree with that, we just need to update the steps and make external.

If we all agree with that, we just need to update the steps and make external.

Sounds good, but is the idea that we make it external for a week, because next week it will break WAQ and need to come internal again?

B) In addition, deep links do not always work correctly when the app is already open. This should be investigated further.

Ah, so the whole "click the notification and sign up for a second account to reveal the bug" wasn't necessary, it's just a case of clicking a deep link when the app is already open. Also to confirm, this is still isolated to Android is it?

Great sleuthing on this issue! @trjExpensify I do think we'll see lots of great ideas and proposals from contributors quickly, so I think it's worth a try even despite how old this issue is. Then, @Julesssss I think you're right, let's fix the bug we know and we can come back to this with a more holistic plan/fix longer-term.

@trjExpensify I do think we'll see lots of great ideas and proposals from contributors quickly, so I think it's worth a try even despite how old this issue is.

Cool, I guess we have exactly one week until next Thurs for it to be at the 4 week mark.
@Julesssss - can you confirm on the question above and copy the necessary detail into the OP in the usual bug format?

Okay that's less time than I thought we had, but I still think it's worth a try. I'm OOO for a destination wedding starting next Wednesday, so it'll likely give us 2 weeks of contributor input (maybe we should reassign while I'm off, but I don't mind either way)

Made the Upwork job public, added [$1000] to the title, added Help wanted and removed Internal.

This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

Yeah, I don't see why not. I imagine the debugging/testing alone is above average complexity of the typical issue.

Yeah, let's double it and ping the open-source slack channel for vis.

Perf doing now

Updated Upwork name to reflect the new title of this GH FYI

Hit up expensify-open-source https://expensify.slack.com/archives/C01GTK53T8Q/p1673869289565949

The 2 mentioned issues, although related to deep link, have very different causes.
For the magic link issue,
Proposal
Problem
This magic link issue appears when the user logged out from an account with 1 or more workspaces created and login to a new account via the magic link.
The underlying problem is not from deep link. It originates from the duplicated use of allPolicies variable in src/libs/actions/Welcome.js, which also appears in src/libs/actions/Policy.js. It lacks the onyx clearing logic when the user logout, which cause the inconsistency. When a user logout, the policy still remains, and be passed into the Policy.isAdminOfFreePolicy(allPolicies) function when the user log in with a new account.
Solution
Solution 1: Add the onyx clearing logic for the allPolicies variable in https://github.com/Expensify/App/blob/df900108b413826dd7c4b0e51ab6cf8092223289/src/libs/actions/Welcome.js
In https://github.com/Expensify/App/blob/df900108b413826dd7c4b0e51ab6cf8092223289/src/libs/actions/Welcome.js#L68-L78
const allPolicies = {};
Onyx.connect({
    key: ONYXKEYS.COLLECTION.POLICY,
    callback: (val, key) => {
-        if (!val || !key) {
-            return;
-        }

+       if (!key) {
+            return;
+       }

+        if (val === null || val === undefined) {
+           delete allPolicies[key];
+          return;
+        }

        allPolicies[key] = {...allPolicies[key], ...val};
    },
});

Solution 2: Delete the duplicated allPolicies variable
We will delete the duplicated allPolicies variable in Welcome.js, so that the logic in Welcome.js would use the variable from Policy.js
In https://github.com/Expensify/App/blob/df900108b413826dd7c4b0e51ab6cf8092223289/src/libs/actions/Welcome.js#L68
diff --git a/src/libs/actions/Welcome.js b/src/libs/actions/Welcome.js
index d1130b9450..e3aa61b5ad 100644
--- a/src/libs/actions/Welcome.js
+++ b/src/libs/actions/Welcome.js
@@ -65,7 +65,6 @@ Onyx.connect({
     },
 });

-const allPolicies = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
     callback: (val, key) => {
diff --git a/src/libs/actions/Welcome.js b/src/libs/actions/Welcome.js
index d1130b9450..e3aa61b5ad 100644
--- a/src/libs/actions/Welcome.js
+++ b/src/libs/actions/Welcome.js
@@ -65,7 +65,6 @@ Onyx.connect({
     },
 });

-const allPolicies = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
     callback: (val, key) => {
@@ -73,7 +72,7 @@ Onyx.connect({
             return;
         }

-        allPolicies[key] = {...allPolicies[key], ...val};
+        Policy.allPolicies[key] = {...Policy.allPolicies[key], ...val};
     },
 });

@@ -120,7 +119,7 @@ function show({routes, showCreateMenu}) {

         // If user is not already an admin of a free policy and we are not navigating them to their workspace or creating a new workspace via workspace/new then
         // we will show the create menu.
-        if (!Policy.isAdminOfFreePolicy(allPolicies) && !isDisplayingWorkspaceRoute) {
+        if (!Policy.isAdminOfFreePolicy(Policy.allPolicies) && !isDisplayingWorkspaceRoute) {
             showCreateMenu();
         }
     });

Record
https://drive.google.com/file/d/1WTj7e47D8tcGiaPgQyVKEuBMq5BEIRgS/view?usp=share_link

For the admin chat issue,
Proposal
Problem
The admin chat problem occurs due overlapping navigation inside the app. When the user activate a deep link via a push notification, the MainDrawerNavigator component also call a component update with the last reportID, which is passed via initialParams.
This caused a race condition with the deep link navigation. When the initial params update happens after the deep link navigation finishes, it will render the last chat rather than the chat in the deep link.
Solution
To address the issue, we need to wait for the component to finish rendering with the last report, then trigger the deep link navigation to navigate to the final target. This solution will maintain the consistency of the report item being rendered.
In https://github.com/Expensify/App/blob/a59825caa19d1e3217e8d59db864dbe2f3bd386d/src/libs/actions/Report.js#L80-L81
diff --git a/src/libs/actions/Report.js b/src/libs/actions/Report.js
index efeb44f357..c144f1a630 100644
--- a/src/libs/actions/Report.js
+++ b/src/libs/actions/Report.js
@@ -74,11 +74,17 @@ function subscribeToReportCommentPushNotifications() {
             if (Navigation.getActiveRoute().slice(1, 2) === ROUTES.REPORT && !Navigation.isActiveRoute(`r/${reportID}`)) {
                 Navigation.goBack();
             }
-            Navigation.navigate(ROUTES.getReportRoute(reportID));
+            Navigation.isDrawerReady()
+            .then(() => {
+                Navigation.navigate(ROUTES.getReportRoute(reportID));
+            })
         } else {
             // Navigation container is not yet ready, use deeplinking to open to correct report instead
             Navigation.setDidTapNotification();
-            Linking.openURL(`${CONST.DEEPLINK_BASE_URL}${ROUTES.getReportRoute(reportID)}`);
+            Navigation.isDrawerReady()
+                .then(() => {
+                    Linking.openURL(`${CONST.DEEPLINK_BASE_URL}${ROUTES.getReportRoute(reportID)}`);
+                });
         }
     });
 }

We might also need to check other components that also use deep link navigation, since there is a possible race condition.

For the 3) Admin chat failure issue
Proposal 2
If we want to narrow down the ready check for the ReportScreen only (rather than reusing the Navigation.isDrawerReady, we can create another param for it in Navigation
Here's the code change:
diff --git a/src/libs/Navigation/Navigation.js b/src/libs/Navigation/Navigation.js
index e937e50159..78951c8da3 100644
--- a/src/libs/Navigation/Navigation.js
+++ b/src/libs/Navigation/Navigation.js
@@ -253,6 +253,19 @@ function setIsDrawerReady() {
     resolveDrawerIsReadyPromise();
 }

+let resolveReportScreenReadyPromise;
+const reportScreenIsReadyPromise = new Promise((resolve) => {
+    resolveReportScreenReadyPromise = resolve;
+});
+
+function isReportScreenReady() {
+    return reportScreenIsReadyPromise;
+}
+
+function setIsReportScreenReady() {
+    resolveReportScreenReadyPromise();
+}
+
 export default {
     canNavigate,
     navigate,
@@ -269,6 +282,8 @@ export default {
     isDrawerReady,
     setIsDrawerReady,
     isDrawerRoute,
+    isReportScreenReady,
+    setIsReportScreenReady,
 };

 export {
diff --git a/src/libs/actions/Report.js b/src/libs/actions/Report.js
index efeb44f357..e31f1e4592 100644
--- a/src/libs/actions/Report.js
+++ b/src/libs/actions/Report.js
@@ -74,11 +74,15 @@ function subscribeToReportCommentPushNotifications() {
             if (Navigation.getActiveRoute().slice(1, 2) === ROUTES.REPORT && !Navigation.isActiveRoute(`r/${reportID}`)) {
                 Navigation.goBack();
             }
-            Navigation.navigate(ROUTES.getReportRoute(reportID));
+            Navigation.isReportScreenReady().then(() => {
+                Navigation.navigate(ROUTES.getReportRoute(reportID));
+            });
         } else {
             // Navigation container is not yet ready, use deeplinking to open to correct report instead
             Navigation.setDidTapNotification();
-            Linking.openURL(`${CONST.DEEPLINK_BASE_URL}${ROUTES.getReportRoute(reportID)}`);
+            Navigation.isReportScreenReady().then(() => {
+                Linking.openURL(`${CONST.DEEPLINK_BASE_URL}${ROUTES.getReportRoute(reportID)}`);
+            });
         }
     });
 }
diff --git a/src/pages/home/ReportScreen.js b/src/pages/home/ReportScreen.js
index 5b665c525b..c1f3460c09 100644
--- a/src/pages/home/ReportScreen.js
+++ b/src/pages/home/ReportScreen.js
@@ -124,6 +124,7 @@ class ReportScreen extends React.Component {
         this.fetchReportIfNeeded();
         toggleReportActionComposeView(true);
         this.removeViewportResizeListener = addViewportResizeListener(this.updateViewportOffsetTop);
+        Navigation.setIsReportScreenReady();
     }

     componentDidUpdate(prevProps) {

@rushatgabhane I'm sure you're gone for the day at the moment, but when you come back online, do you mind reviewing these proposals? Thank you!

Also as a heads up, this issue is close to passing the 30 day mark, which means we're going to put extra focus on this issue internally. Let's close the loop on proposals and the next step as soon as we can! Feel free to create a thread in open-source if necessary.

@tienifr for problem 2 (magic link), doesn't the same issue happen when a user with a chat logs out?

@rushatgabhane I’m not sure I understand your question correctly.
But ‘when a user with a chat logs out’, and then we follow the steps mentioned, then the report issue with magic link will happen. It’s because we haven’t cleared the Onyx data of the previous user in case the app is not terminated, only backgrounded. My proposals above will address it

@tienifr for problem 2 (magic link), doesn't the same issue happen when a user with a chat logs out?

That is unlikely. From what I observe, the allPolicies variable does not contain policies that originated from the chat.
In short, the issue only occur when the user log out from an account with policies that satisfy the isAdminOfFreePolicy() function (https://github.com/Expensify/App/blob/67ebf5dabcd0a3fcbb7a1fbc56ffb6c04f84321c/src/libs/actions/Policy.js#L130-L134), which include workspaces but not personal chats.
Regarding what is in the policies, the proposal I've made would also address it.

I have also tested the app in a couple of scenarios to demonstrate the issue. In short, you can follow this instruction to reproduce the problem that I have demonstrated.

Clear all the app data in the device settings, delete app from background (to avoid any leftover data from previous account)
Create a new account, then access with deep link from mail
The FAB modal will be shown as expected
Send a message to a user
Log out of the account
Repeat step 2, the FAB modal will be shown as expected

However, in step 4, if you create a workspace, then repeat step 2, then the FAB modal will not be shown

@rushatgabhane @Julesssss shall we 🟢 @tienifr for the job?

Thanks @rushatgabhane stepping in for @Julesssss Updated the price as the doubling only took place becuase of an engineer being ooo.
@tienifr are you able to submit a PR for this? Thank you very much!

Apologies, missed that the job was 2000 originally, thats the correct price to go with.

@mountiny Great! I am working on a PR right now.

@rushatgabhane @Julesssss @mountiny the PR is ready for review https://github.com/Expensify/App/pull/14588
thanks!

Thanks for moving this forward all, I'm back and will test it today.

PR which fixes this issue caused regression of https://github.com/Expensify/App/issues/11102

Yeah, I don't think it's a regression personally, but I'm taking care of it here.

I wouldn't count this as a regression but is an overlooked case from the initial implementation (a very long time ago). So I checked off the relevant boxes. A regression test would be useful though.

@rushatgabhane @Julesssss @mountiny
Regression Test Proposal
Bug: Deep link routing is inconsistent when the app is open
Proposed Test Steps:

Open the app
Login with an existing account that already has workspace / Login to an existing account then create a workspace
Logout of the account
Register with a new email
Go back to home screen
Perform 1 of the following

Keep the app in background
Kill the app in background

Go to mailbox and click the magic sign-in link to access the set password page. Set a password and proceed
Verify that the FAB modal is opened after signing in
Select New workspace to create a new workspace
Wait for the Notification from the support team member
Perform 1 of the following

Keep the app in background
Kill the app in background

Tap the notification
Verify that the app navigates to the correct channel #admins

Do we :+1: or :-1:

Yep that looks good, thanks. @dylanexpensify, all yours to check off

Looks great! Nice one @tienifr !

Added GH for test! Will begin payments tomorrow!

@tienifr sent offer! @rushatgabhane invited to apply to job!

@dylanexpensify  please send an offer for reporting bonus

@gadhiyamanan sent!
@rushatgabhane offer sent!

@rushatgabhane can you accept offer when you get the chance?
@gadhiyamanan sent offer for reporting!

@dylanexpensify Accepted

All paid out, thanks all!


WIP: Feature/proposer accs

Reminder to myself: Purge CSS before merging

Reminder to myself: Purge CSS before merging

Done.


fix(CI): Remove pause-reconcile annotation before deleting central/secured-cluster

Description

Setting pause-reconcile annotation to true causes problem when deleting central and secured-cluster services in static clusters(ppc64le) before deploying and running tests.
This PR removes the annotation before cleanup of central and secured-cluster is performed.
User-facing documentation
(must be 2 items and both must be checked)

[ ] CHANGELOG is updated
[ ] CHANGELOG update is not needed
[ ] Documentation PR is created and linked above
[ ] Documentation is not needed

Testing

[ ] inspected CI results

Automated testing
(must be at least 1 item and all items must be checked)

[ ] added unit tests
[ ] added e2e tests
[ ] added regression tests
[ ] added compatibility tests
[ ] modified existing tests
[ ] contributed no automated tests

How I validated my change

Change validated by running the change against an ocp 4.16 ppc64le cluster.

/test powervs-4-14-qa-corebpf-e2e-tests

/test powervs-qa-corebpf-e2e-tests
/test powervs-4-14-qa-corebpf-e2e-tests

/test powervs-4-14-qa-corebpf-e2e-tests

/test powervs-4-16-qa-corebpf-e2e-tests

/test powervs-4-16-qa-corebpf-e2e-tests

/test powervs-4-16-qa-corebpf-e2e-tests

@robbycochran Can you review this?

@mclasmeier Any thoughts on this PR? You added some related code here: https://github.com/stackrox/stackrox/pull/9866/files. I'm also wondering if the CRs are ever deleted after your change if namespace is not defined?

@robbycochran Are the changes ok or do you suggest any improvements? Or is it good to merge?

This looks good to me.

@robbycochran Can you approve this?


Add a new Gateways class to handle the locale code of Paypal checkout

Hello Hyyan,
I've just added a new Gateways class to handle the locale code of Paypal checkout. The class hooks on the builtin woocommerce "woocommerce_paypal_args" filter to add an extra argument "locale.x" with the current value of pll locale. In this way the Paypal checkout is on the same language that the current pll language.
Regards

@nicobea thank you very much for your valuable contribution , I'll merge as I can not see any side effects in this PR  :+1:


fix: fix ibm analytics engine api's and tests.

PR summary

Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Test results:
=========
Harshavardhans-MacBook-Pro:ibmanalyticsengineapiv3 harsha$ go test ./... -tags=integration -v
=== RUN   TestIbmAnalyticsEngineApiV3
Running Suite: IbmAnalyticsEngineApiV3 Suite
============================================
Random Seed:<PHONE_NUMBER>
Will run 55 of 55 specs

•••••••••••••••••••••••••••••••••••••••••••••••Service URL: https://api-staging.us-south.ae.cloud.ibm.com
•••applicationResponse application_id : 8e97e66b-c875-4f7f-846f-9517d83971f7
•••••
Ran 55 of 55 Specs in 10.814 seconds
SUCCESS! -- 55 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIbmAnalyticsEngineApiV3 (10.88s)
PASS
ok  	github.com/IBM/ibm-iae-go-sdk/ibmanalyticsengineapiv3	13.035s
Harshavardhans-MacBook-Pro:ibmanalyticsengineapiv3 harsha$

:tada: This PR is included in version 0.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Styling documentation article

We can just extend the existing article with angular specifics.

Added a pull request.


fern init naming (files and folders) changes

Easy to forget to change it, e.g. https://github.com/fern-api/fern-cloud/blob/5d5d8ffd4aacac48f30244e079fd9b5a4939f90b/api/src/api.yml
We should ask for a name instead of default to api
We should not name the API folder api/ and instead ask for a name or default to something good

previous title: Maybe don't start with IMDB stuff in fern init

previous title: Maybe don't start with IMDB stuff in fern init


[Unittests] Added a meta-test for tvm.testing.fixture behavior in case of a broken fixture.

In these cases, the test function should be marked as failing the setup, and should not run.  This is pytest's default behavior, and should work whether or not a fixture is cached.

@areusch


Use docker image to run puppet-lint

Use unibeautify/puppet-lint that provides puppet-lint in docker.

Published to v0.32.0


fs/: Check return of nxsem_wait_uninterruptible.

There are two style complaints. One is described in #652 and the other one I don't really understand what the issue is.
It seems like an indentation for a function. That would be a bug. Maybe it's confused with an indentation that we would do after a preprocessor directive?

Merging with outstanding nxstyle complaints after discussion with the author.


Organizational settings

Changes

+ Added an Organization data source, this will allow folks to query an org
+ Added the Organization resource
+ Added in GraphQL queries for the Org additions to use
~ Updated the provider to utilise the new resource and data source
~ Modified the genqlient file to accept all .graphql files
~ Adjusted the naming of the TeamMemberRole type within the query; looks to have been previously changed manually and caused type errors on re-generation

This closes #226


ImportInliner should inline all imports inside a

 Issue by jakemac53
Originally opened as dart-lang/sdk#20943

This will eliminate any FOUC that might occur due to the inlined elements. As a part of this, we can also change the FOUC warning to only run on entry points.

 Comment by jakemac53

Fixed in dart-lang/sdk@0484237fd2dbb877ddb3203243bc0827d0007aae

Added Fixed label.


xarray does not seem to work with timezone aware indexes

Using the following code, the created index is not a time index but has object type:
import numpy as np
import pandas as pd
import xarray as xr

data = xr.DataArray(np.random.random(5), dims=['time'], coords={'time': pd.date_range("2000-01-01", periods=5).tz_localize('UTC')})
print(data.time)

This can severely limit the practicality of time indexes. It also means that methods such as resample won't work.
Environment:
I use xarray==0.18.2 with ubuntu

I think this a problem with the repr rather than the index:
  ...: print(data.time)
<xarray.DataArray 'time' (time: 5)>
array([946684800000000000,<PHONE_NUMBER>00000000,<PHONE_NUMBER>00000000,
<PHONE_NUMBER>00000000,<PHONE_NUMBER>00000000], dtype=object)
Coordinates:
  * time     (time) object<PHONE_NUMBER>00000000 ...<PHONE_NUMBER>00000000

In [2]: data.indexes['time']
Out[2]:
DatetimeIndex(['2000-01-01 00:00:00+00:00', '2000-01-02 00:00:00+00:00',
               '2000-01-03 00:00:00+00:00', '2000-01-04 00:00:00+00:00',
               '2000-01-05 00:00:00+00:00'],
              dtype='datetime64[ns, UTC]', name='time', freq='D')

But I wouldn't be surprised if there were issues with this sort of index — please post issues if you find them.

For example resample yields the following error:
>>> data.resample(time='1d')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/xarray/core/common.py", line 1173, in resample
    resampler = self._resample_cls(
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/xarray/core/resample.py", line 175, in __init__
    super().__init__(*args, **kwargs)
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/xarray/core/groupby.py", line 348, in __init__
    full_index, first_items = self._get_index_and_items(index, grouper)
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/xarray/core/groupby.py", line 449, in _get_index_and_items
    first_items = s.groupby(grouper).first()
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/pandas/core/series.py", line 1720, in groupby
    return SeriesGroupBy(
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/pandas/core/groupby/groupby.py", line 560, in __init__
    grouper, exclusions, obj = get_grouper(
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/pandas/core/groupby/grouper.py", line 719, in get_grouper
    binner, grouper, obj = key._get_grouper(obj, validate=False)
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/pandas/core/resample.py", line 1484, in _get_grouper
    r = self._get_resampler(obj)
  File "/home/bruno/miniconda3/envs/torch/lib/python3.8/site-packages/pandas/core/resample.py", line 1476, in _get_resampler
    raise TypeError(
TypeError: Only valid with DatetimeIndex, TimedeltaIndex or PeriodIndex, but got an instance of 'Index'

The resample issue is tracked in #1490. In general, (IIUC) we use numpy arrays for the data and those don't support timezones. So it's a mess (https://github.com/pydata/xarray/issues/1490#issuecomment-318183360)


Zoom out on framegrab when new localization selected in gridview on left (issue is with two or more localization on same framegrab)

In gridview, when we click on a localization in gridview on left, the framegrab view should zoom out to full frame (upper right). This should hold true for localizations made on the same frame as well. Attached is an example of localization where I am clicked on one, zoomed in in framegrab view then clicked on next localization in that image and gridview did not zoom out on same framegrab.

Hard to type this issue, I can show if needed.

@kwalz, this was changed in v0.4.2 as I had originally (from v0.3.9) set up the autoranging (zooming in/out to fit the full frame) to be applied when a localization is selected, but there was an issue on the VARS-ML-SE-tasks (item 31, "Gridview jumping to full frame unexpectedly.") that indicated this was unexpected behavior:

Gridview preview window snaps to full frame if you click inside the ROI. This is not the action we would expect.

Since v0.4.2, the image view only autoranges when the image changes. Do we want to revert this change?

Hi Kevin, no to revert :) we definitely want it as it was fixed for localizations from different framegrabs. If it's not possible to have it for different ROI gridview selections then let's set this one aside for the new Gridview replacement and we can brainstorm on ways to achieve this. Perhaps we double click on an ROI in gridview on left and that brings the image back to full size in framegrab view.

@kwalz @kevinsbarnard This is done, correct?

@lonnylundsten This was tabled for the next version of Gridview as well.


Issue fixed #7136

Fixed #7136

@prabhatkumaroc082 Still getting  this issue  screenshot here

@Nikitajoshi39 explained here, no need to adjust the content. vertical alignment is applied to middle.
let me know if any issue with image responsive.

@prabhatkumaroc082
All the input boxes should be in alignment, please take a reference from Here

@Nikitajoshi39 @Sanjaybhattwebkul review the alignment now.

@prabhatkumaroc082
Getting unnecessary space if trying to upload multiple images of 1 product.

Please find the screenshot Here

Please find the screenshot Here

@Sanjaybhattwebkul inline-block is already set, delete icon is also taking some space, it will auto-adjust as per device width.

@prabhatkumaroc082
I am getting the issue in desktop.

@prabhatkumaroc082
Please take a reference for the below Image to improve the variants section of the configurable product.

@prabhatkumaroc082
Please resolved the conflicts.

@Sanjaybhattwebkul review now.

@prabhatkumaroc082
Please improve the add image icon. please take a reference from here

@Sanjaybhattwebkul added camera icon

@prabhatkumaroc082
Please resolved the conflicts.

@prabhatkumaroc082
Still not as accepted, please find the screenshot Here

@Sanjaybhattwebkul
updated assets, review again. here are some screenshots image1,
[image2](https://user-images.githubusercontent.com/50438561/207829999-16fef740-0e92-4079-98de-cbd3b32b416d.png]()

@prabhatkumaroc082
Please do the same for the Add Link section of the downloadable product. Please find the screenshot Here

@Sanjaybhattwebkul please review now the table fields of each page.

Closing this PR as not getting any response from the last 2 months.


unable to resolve dependency tree

This is not supported by the new React Version 17.0.2
Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project

npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-odometerjs
npm ERR!   react-odometerjs@"*" from the root project

Hmm, I think we should change "react": "^16.3.0", to "react": ">= 16.3.0",
I'll try to do it soon, but you can also create Merge Request with that

Fix in v2.1.2


[GraphQL 4] Adding AgentStore for GraphQL

Adds store for processing Agents
:warning: Depends on https://github.com/dcos/dcos-ui/pull/1353

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Closing to reduce repo noise and defer for future. Do not delete branch.


console error displayed when clicking on archived workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

create a workspace
wait for assigning expensify specialist to that workspace
delete a workspace
go to archived workspace

Expected Result:
should not show any console error
Actual Result:
shows console error [Onyx] An error occurred while applying merge for key: report_1355144964678015, Error: TypeError: Cannot convert undefined or null to objectclicking on archived workspace
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Windows / Chrome

Version Number: 1.2.50-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/211107729-15433d41-a6d3-4617-83bf-93878ae906a4.mov
https://user-images.githubusercontent.com/43996225/211107769-282ceea0-bfff-4362-9b77-44182a0b5fd9.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672988003994539
View all open jobs on GitHub

I don't get that specific error when I follow those steps:

Applying the Needs reproduction label to see if anyone else can reproduce this error.

I'll give it a look!

How's it going @yuwenmemon - did you manage to have a look at this yet?

And by today I mean ... today

Sorry. Keep getting new things thrown at me each morning. Will look at this tomorrow I promise!

Not seeing this error anymore in dev or prod. See what happens when you wait! The stuff works itself out 😅
https://user-images.githubusercontent.com/4741899/215212932-be23009f-3484-46f8-8235-76af53584f2b.mp4


NTR: [telomere-nuclear membrane anchor activity]

Please provide as much information as you can:

Suggested term label:

telomere-nuclear membrane anchor activity

Definition (free text)

Binding to the telomeric region and the nuclear inner membrane, in order to establish and maintain the chromosome location and organization.

Reference, in format PMID:#######
[PMID:31635174]
https://www.pombase.org/reference/PMID:19948484

Gene product name and ID to be annotated to this term
pombe bqt3, bqt4

Parent term(s)
is_a  protein-membrane adaptor activity GO:0043495

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?
No

OK I found this,
telomere-nuclear envelope anchor activity (GO:0140473)


Added points to note while using git reset

Using --hard option can be dangerous. Added a warning to mention the same.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Support for CTest to drive test suite

Consider leveraging CTest to drive the test suite, and possible upload test results to the CDash console. Some experimentation with uploading to CDash:
https://github.com/jfpanisset/aswf-sample-project#uploading-ctest-results-to-cdash

Nevermind, looks like CTest is already being used.

As I mentioned in the other issue (https://github.com/darbyjohnston/DJV/issues/155#issuecomment-559893676), DJV does use CTest for running the test suite but it would be nice to get CDash support enabled.


Remove redundant examples from README

This PR removes examples that were added to optax-101.ipynb from README.
Addressing issue #753

Merged, thanks again for this quick contribution!


[ObjC] increase Basic Tests C/C++ MacOS jobs

These tests are slow and can timeout, this diff increase the number of concurrent jobs to 4 and 8, which may help avoid  timeouts.
These parameters are also configured differently in many other tests.
2024-03-10 07:00:56,453 START: run_tests_c_macos_dbg_native
2024-03-10 07:06:44,335 PASSED: run_tests_c_macos_dbg_native [time=347.9sec, retries=0:0]
2024-03-10 07:06:44,335 START: run_tests_c_macos_opt_native
2024-03-10 07:12:54,717 PASSED: run_tests_c_macos_opt_native [time=370.4sec, retries=0:0]
2024-03-10 07:12:54,717 START: run_tests_c++_macos_dbg_native
2024-03-10 09:19:00,785 PASSED: run_tests_c++_macos_dbg_native [time=7566.1sec, retries=0:0]
2024-03-10 09:19:00,788 START: run_tests_c++_macos_opt_native

ERROR: Aborting VM command due to timeout of 14400 seconds

It's hard to say for inner_jobs, run time can vary a log with the same configuration.
The 4 outer jobs should help run c/c++ tests with dbg/opt mode in parallel, which should avoid the CI timeout.

@HannahShiSFB Aha ok thanks for explaining, Hannah! Looking forward to the test timeout disappearing! 😃

@HannahShiSFB Hi Hannah..
Unfortunately this has not worked.. since tests are still timing out..
Example log:
https://btx.cloud.google.com/invocations/4a523df8-c692-4b62-a0c3-0fc04cad1c24/targets/grpc%2Fcore%2Fmaster%2Fmacos%2Fgrpc_basictests_c_cpp;config=default/log
Do you have other ideas of making the test run faster? Or should we disable part of it somehow?
Thanks!

Looks like this is how fast a single box can do, we probably need to separate the opt and dbg tests into two jobs so they run in separate VMs. Can we have Jan help on this?


Add more detail around the set up steps

Changes in this PR
This started out with the intention of documenting testing steps based on Pat's feedback. From working my way through the set up I felt there was enough value to add and get feedback whilst I continue looking at the testing steps.
Release checklist
As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to main we must first
confirm:
Pre merge checklist

[ ] Have all changes to any dependencies been deployed to both preprod and
production in a backwards compatible way? (This includes our API,
infrastructure, third-party integrations and any secrets or environment variables)
[ ] Has a required data migration been included in this change or been done in
advance?

Post merge checklist
Once we've merged we now need to release this through to production before
considering it done.
Find the build-and-deploy job in CircleCI
and work through the following steps:

[ ] Has the product manager asked to provide approval for this feature?

[ ] Has the product manager approved?

[ ] Manually approve release to preprod
[ ] Verify change released to preprod
[ ] Manually approve release to prod
[ ] Verify change released to production

Should a release fail at any step, you as the author should now lead the work to
fix it as soon as possible.

Ha yes I will make that message make sense 🙈


USB/Sata cable not compatible with pi

I spend days on cloning a card to disk. I have read info on git a thousand times and nearly gave up.
I discovered this and that solved my problem. Swapped the not compatible cheap cable with a sata dock and I am up and running! Maybe helpful for somebody :)

Please add this to the documentation. Been working on it for days.


Azure Event Grid Subscriptions - Project NorthStar

Relevant information
Describe what you have done and any details that you think are relevant or that you might want to discuss with us.
Adding Azure Event Grid Subscriptions service to entity definitions as part of Project NorthStar, from the Product Partnerships team.
Checklist

[X] I've read the guidelines and understand the acceptance criteria.
[X] The value of the attribute marked as identifier will be unique and valid.
[X] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

Closing pull request - wrong folder attached. Will redo.


Adjust CI pool for VS15.9.7

GitHub Issue (If applicable): #

PR Type
What kind of change does this PR introduce?

Build

What is the new behavior?
Build using a stable environment, with VS15.9.6
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Merged as part of #621


i18n check-text edge cases

Some cases where the i18n rule with check-text errors, but shouldn't (imo):
<mat-checkbox i18n="@@terms">
  I agree to the
  terms of service
</mat-checkbox>

<ng-container i18n="@@minlength">
  Use at least {{ minLength }} characters
</ng-container>

Thanks for reporting this! Added it to the next release.


Encapsulating more information into HttpError

Closes #33

Codecov Report

Merging #42 into master will decrease coverage by 0.45%.
The diff coverage is 84.21%.

@@            Coverage Diff            @@
##             master   #42      +/-   ##
=========================================
- Coverage     92.45%   92%   -0.46%
- Complexity      192   195       +3
=========================================
  Files            22    22
  Lines           411   425      +14
  Branches         52    52
=========================================
+ Hits            380   391      +11
- Misses           17    20       +3
  Partials         14    14

Impacted Files
Coverage Δ
Complexity Δ

...va/me/alidg/errors/mvc/ErrorsControllerAdvice.java
100% <100%> (ø)
2 <1> (ø)
:arrow_down:

...rc/main/java/me/alidg/errors/WebErrorHandlers.java
100% <100%> (ø)
19 <0> (ø)
:arrow_down:

...rs/adapter/attributes/ReactiveErrorAttributes.java
92.3% <100%> (ø)
2 <0> (ø)
:arrow_down:

...ors/adapter/attributes/ServletErrorAttributes.java
100% <100%> (ø)
4 <0> (ø)
:arrow_down:

src/main/java/me/alidg/errors/HttpError.java
76.66% <66.66%> (-4.29%)
6 <3> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1474415...163bb9c. Read the comment docs.


Object of type 'WSGIRequest' is not JSON serializable

my code:

@background(schedule=60)
def g_trends(request):
	get_trends()
	return HttpResponse('hello')

when i run code in django and i get to my url for that function i get this error:
Object of type 'WSGIRequest' is not JSON serializable
how can i fix it?

my code:

@background(schedule=60)
def g_trends(request):
	get_trends()
	return HttpResponse('hello')

when i run code in django and i get to my url for that function i get this error:
Object of type 'WSGIRequest' is not JSON serializable
how can i fix it?

@yaserrahimi  How did you fix this ?? facing the same .

@Sudheer312 in your views.py, define the function that you will server your response.
def g_trends(request):
    get_trends()
    return JsonResponse({"message":"successfully triggered get_trends"})

And we presume get_trends() is a long running tasks. When defining get_trends():
# start 1 second after the function is called
@background(schedule=1)
def get_trends(request):
    # code goes here

@Sudheer312 in your views.py, define the function that you will server your response.
def g_trends(request):
    get_trends()
    return JsonResponse({"message":"successfully triggered get_trends"})

And we presume get_trends() is a long running tasks. When defining get_trends():
# start 1 second after the function is called
@background(schedule=1)
def get_trends(request):
    # code goes here

It doesn't work for me, what should I do?

anyone got the solution ? i'm still stuck there

Does not work that way.
Pass an ID, slug, name, .. for example and get (query) the instance from the DB.

@Ismael-Safadi are you able to share your codes?

I'm still stuck in this step too.

I'm still stuck in this step too.

@gvarela23 maybe this helps: https://github.com/arteria/django-background-tasks/issues/171

@gvarela23 maybe this helps: https://github.com/arteria/django-background-tasks/issues/171


Validate user auth from Erlang

Overview
PR consist translation to Erlang from AUTH_DB_DOC_VALIDATE_FUNCTION javascript file.
Testing recommendations
I tested throught adding this fun to "_users > _design/_auth" doc. It seems to work :)
Related Issues or Pull Requests

Checklist

[x] Code is written and works correctly;
[ ] Changes are covered by tests;
[ ] Documentation reflects the changes;

This would be a nice one for 2.2.0, if we can swing it, though it's not a trivial change.
We'll need to go the extra mile to add it to _users by default, and presumably remove the pre-existing one.

I don't see where this gets hooked in, but I don't like that the erlang is expressed in a macro. I assume the author is following the existing method we use for JS, but that's done out of necessity. Let's pull that erlang into a proper module please. will review again after.

Hi @abc3, is there any chance of doing what @rnewson says above and putting the Erlang into a proper module rather than as a macro?

Yes, but right now I'm a little bit busy.


测绘后未激活信标，保存退出游戏后建筑还可以测绘出第二个信标，激活第一个信标奔溃

NullReferenceException: Object reference not set to an instance of an object
PackAnything.Beacon.ActiveIt (Worker worker) (at :0)
PackAnything.Beacon.OnCompleteWork (Worker worker) (at :0)
Workable.CompleteWork (Worker worker) (at <76ef63103ae5408a8dbffd2c8c54e743>:0)
Worker.CompleteWork () (at <76ef63103ae5408a8dbffd2c8c54e743>:0)
Worker.Work (System.Single dt) (at <76ef63103ae5408a8dbffd2c8c54e743>:0)
GameStateMachine`4+State+
Build: U50-581979-S

ArgumentException: Item has already been added. Key in dictionary: '143343' Key being added: '143343'
System.Collections.Hashtable.Insert (System.Object key, System.Object nvalue, System.Boolean add) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.Collections.Hashtable.Add (System.Object key, System.Object value) (at <695d1cc93cca45069c528c15c9fdd749>:0)
PackAnything.Beacon.ActiveIt (Worker worker) (at :0)
PackAnything.Beacon.OnCompleteWork (Worker worker) (at :0)
Workable.CompleteWork (Worker worker) (at <76ef63103ae5408a8dbffd2c8c54e743>:0)
Worker.CompleteWork () (at <76ef63103ae5408a8dbffd2c8c54e743>:0)
Worker.Work (System.Single dt) (at <76ef63103ae5408a8dbffd2c8c54e743>:0)
GameStateMachine`4+State+


Installing plugin fails

I'm trying to install the plugin with fastlane 2.19.1 on macOS 10.12.3 with XCode 8.2.1. The installation fails with the following error:
$ fastlane add_plugin instrumented_tests
+---------------------------------------------+---------+-----------------------------+
|                                    Used plugins                                     |
+---------------------------------------------+---------+-----------------------------+
| Plugin                                      | Version | Action                      |
+---------------------------------------------+---------+-----------------------------+
| fastlane-plugin-automated_test_emulator_run | 1.3.2   | automated_test_emulator_run |
+---------------------------------------------+---------+-----------------------------+

[11:51:10]: Plugin 'fastlane-plugin-instrumented_tests' was added to './fastlane/Pluginfile'
[11:51:10]: Make sure to commit your Gemfile, Gemfile.lock and Pluginfile to version control
Installing plugin dependencies...
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /Users/xxx/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/json-2.0.3/ext/json/ext/generator
/Users/xxx/.fastlane/bin/bundle/bin/ruby -r ./siteconf20170303-7561-1yddh4i.rb extconf.rb
creating Makefile

current directory: /Users/xxx/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/json-2.0.3/ext/json/ext/generator
make "DESTDIR=" clean

current directory: /Users/xxx/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/json-2.0.3/ext/json/ext/generator
make "DESTDIR="
compiling generator.c
clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk'
In file included from generator.c:1:
In file included from ./../fbuffer/fbuffer.h:5:
In file included from /Users/xxx/.fastlane/bin/bundle/include/ruby-2.2.0/ruby.h:33:
In file included from /Users/xxx/.fastlane/bin/bundle/include/ruby-2.2.0/ruby/ruby.h:29:
/Users/xxx/.fastlane/bin/bundle/include/ruby-2.2.0/ruby/defines.h:26:10: fatal error: 'stdio.h' file not found
#include <stdio.h>
         ^
1 error generated.
make: *** [generator.o] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/xxx/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/gems/json-2.0.3 for inspection.
Results logged to /Users/xxx/.fastlane/bin/bundle/lib/ruby/gems/2.2.0/extensions/x86_64-darwin-15/2.2.0-static/json-2.0.3/gem_make.out

An error occurred while installing json (2.0.3), and Bundler cannot continue.
Make sure that `gem install json -v '2.0.3'` succeeds before bundling.

I ran gem install json -v '2.0.3' as admin user and successfully installed the gem. Unfortunately it didn't fix the problem. I'm still getting the same error.
$ gem list

*** LOCAL GEMS ***

bigdecimal (1.2.0)
CFPropertyList (2.2.8)
io-console (0.4.2)
json (2.0.3, 1.7.7)
libxml-ruby (2.6.0)
minitest (4.3.2)
nokogiri (1.5.6)
psych (2.0.0)
rake (0.9.6)
rdoc (4.0.0)
sqlite3 (1.3.7)
test-unit (<IP_ADDRESS>)

✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.3

Ruby
2.2.4

Bundler?
false

Git
git version 2.10.1 (Apple Git-78)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.3 (16D32)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
true

Is homebrew
false

Xcode Path
/Applications/Xcode821.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane gems

Gem
Version
Update-Status

fastlane
2.19.1
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-automated_test_emulator_run
1.3.2
✅ Up-To-Date

fastlane-plugin-instrumented_tests
0.1.5
✅ Up-To-Date

Loaded gems

Gem
Version

CFPropertyList
2.3.5

activesupport
<IP_ADDRESS>

addressable
2.5.0

babosa
1.0.2

bigdecimal
1.2.6

bundler
1.14.3

claide
1.0.1

colored
1.2

commander
4.4.3

domain_name
0.5.20161129

dotenv
2.2.0

excon
0.55.0

excon
0.54.0

faraday
0.11.0

faraday-cookie_jar
0.0.6

faraday_middleware
<IP_ADDRESS>

fastimage
2.1.0

fastimage
2.0.1

fastlane-plugin-automated_test_emulator_run
1.3.2

fastlane-plugin-instrumented_tests
0.1.5

gh_inspector
1.0.3

google-api-client
0.9.26

googleauth
0.5.1

highline
1.7.8

http-cookie
1.0.3

httpclient
2.8.3

hurley
0.2

i18n
0.8.1

i18n
0.7.0

io-console
0.4.3

json
1.8.1

jwt
1.5.6

libxml-ruby
2.9.0

little-plugger
1.1.4

logging
2.1.0

memoist
0.15.0

mime-types
3.1

mime-types-data
3.2016.0521

mini_magick
4.5.1

minitest
5.10.1

minitest
5.4.3

multi_json
1.12.1

multi_xml
0.6.0

multipart-post
2.0.0

nanaimo
0.2.3

nokogiri
1.5.6

os
0.9.6

plist
3.2.0

power_assert
0.2.2

psych
2.0.8

public_suffix
2.0.5

rake
10.4.2

rdoc
4.2.0

representable
2.3.0

retriable
2.1.0

rouge
1.11.1

rubygems-update
2.5.2

rubyzip
1.2.1

rubyzip
1.2.0

security
0.1.3

signet
0.7.3

slack-notifier
1.5.1

sqlite3
1.3.13

terminal-notifier
1.7.1

terminal-table
1.7.3

test-unit
3.0.8

thread_safe
0.3.6

thread_safe
0.3.5

tty-screen
0.5.0

tzinfo
1.2.2

uber
0.0.15

unf
0.1.4

unf_ext
<IP_ADDRESS>

unicode-display_width
1.1.3

word_wrap
1.0.0

xcodeproj
1.4.2

xcpretty
0.2.4

xcpretty-travis-formatter
0.0.4

generated on: 2017-03-03

Did anyone ever find a solution to this?


Add classes_ attribute to TSclassifier

Same issue as #85, but for TSclassifier: the classes_ attribute is required for ensemble learning and some other cases.

Codecov Report

Merging #89 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   98.08%   98.08%
=======================================
  Files          18       18
  Lines        1305     1306    +1
=======================================
+ Hits         1280     1281    +1
  Misses         25       25

Impacted Files
Coverage Δ

pyriemann/classification.py
98.14% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab691c...f343025. Read the comment docs.

I would update a test though

Your wish is my command ;)

@mesca can you rebase to fix the merge conflict? thx

You should be able to merge now.

Merge master to this branch to clean the diff and we will merge with squashing

Is it better?

Thx @mesca


Zen doesn't work on iPad in incognito mode

Zen won't load at all on an iPad in incognito mode possibly related to #979 as cookies wouldn't be set

Just had a quick look at this. The same behaviour exists on OS X with Safari's private browsing mode. It seems like private browsing disables local storage, and some angular components (and ourselves) use it without checking if it's available for use.

Display that we don't support incognito mode on Safari should be less worst solution


Specifying default sub-routes and redirecting when there is no activeRouteHandler match

Not sure if I missed something obvious about how to do this, but here's what I'm trying to achieve:
Say there's a User route that has two sub-routes: UserDetails and UserActivity.
The User route draws common UI (name, navigation, etc) and needs to know the userId in order to do so.
So I set them up like this:
<Router.Routes>
  <Router.Route handler={App}>
    <Router.Route name="user" path="user/:userId" handler={User}/>
      <Router.Route name="user-details" path="user/:userId/details" handler={UserDetails} />
      <Router.Route name="user-activity" path="user/:userId/activity" handler={UserActivity}/>
    </Router.Route>
  </Router.Route>
</Router.Routes>

App draws the surrounding UI, User draws the common UI for the current user (name, subnav), and UserDetails and UserActivity draw their specific UI.
The User view doesn't have any 'inner' UI and requires either the UserDetails or UserActivity view to be rendered inside it, but it seems reasonable that a) someone may visit the url /user/1, and b) the default redirect should be encapsulated somewhere.
What I can't work out is how to best ensure that any requests to /user/1 either render the UserDetails handler by default, or automatically redirect to /user/1/details.
I've (sort of) been able to hack it by adding a willTransitionTo static on the User component, like this:
willTransitionTo: function (transition, params) {
  if (transition.path.split('?')[0] === '/user/' + params.userId) {
    transition.redirect('user-details', params);
  }
}

...but that's messy, and breaks the encapsulation of the routes / paths, among other things.
It seems that there are a few additions to the API that could make it cleaner, including:

Add a property to Route that lets you specify a default sub-route handler (these could cascade, and wouldn't cause a redirect)
Add a property / argument / etc. available in willTransitionTo that indicates this is the 'final' matched route; i.e. no child routes will also be rendered

Maybe a nice thing to have available generally would be an array of the matched routes, starting with the upper parent; this would be useful in both willTransitionTo and willTransitionFrom.
Alternatively, I may be going in completely the wrong direction here; If I could get the :userId param into the User route without specifying the path, I could make the path of the user-details route /user/:userId, and that would be fine.

For those coming in 2016, you'd use <Indexredirect>
<Route path="/" component={App}>
  <IndexRedirect to="/welcome" />
  <Route path="welcome" component={Welcome} />
  <Route path="about" component={About} />
</Route>

How does one accomplish this layered rendering in React 4? When doing similar one is told that components are not allowed children (nested routes). When one follows the new scheme and moves
  <IndexRedirect to="/welcome" />
  <Route path="welcome" component={Welcome} />
  <Route path="about" component={About} />

into App I get errors:
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in. Check the render method of `Index`

and
Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in. Check the render method of `Index`.

Thanks for the help!

I assume IndexRedirect is not available now,
what would be the best way to achieve the same; ie.
If I have config like this..
<Route name="user" path="user/:userId" handler={User}>
  <Route name="user-details" path="user/:userId/details" handler={Details}/>
  <Route name="user-activity" path="user/:userId/activity" handler={Activity}/>
</Route>

and want to take user directly to /details url


From May 29 all requests to our Web API will require authentication

On 29th May 2017 the /search /tracks /albums /artists and /users (and related) endpoints will start requiring an access token, bringing them in-line with all other Web API endpoints.
https://developer.spotify.com/news-stories/2017/01/27/removing-unauthenticated-calls-to-the-web-api/

+1

thanks!
When I upgrade this to the new version of Angular I'll change the authentication or all endpoints.

That's great Eduardo! Thank you :D

In order to e.g. authenticate the getAlbum API call, just add
headers: this.getHeaders(),
to
getAlbum(album: string) {
  album = this.getIdFromUri(album);
  return this.api({
    method: 'get',
    headers: this.getHeaders(),
    url: `/albums/${album}`
  }).map(res => res.json());

}


Some modules are dispatched on the CPU or the disk. Make sure you have enough GPU RAM to fit the quantized model.

Some modules are dispatched on the CPU or the disk. Make sure you have enough GPU RAM to fit the quantized model. If you want to dispatch the model on the CPU or the disk while keeping these modules in 32-bit, you need to set load_in_8bit_fp32_cpu_offload=True and pass a custom device_map to from_pretrained. Check https://huggingface.co/docs/transformers/main/en/main_classes/quantization#offload-between-cpu-and-gpu for more details.
how to solve this error, i have 24G gpu, my transformers==4.44.2

The same happens here. Could it be Windows related?


What does string format actually mean?

I note that the doco says certificates are downloaded in string format. Can you please explain what this means precisely? Particularly in regards to the handling of eol and nl whitespace character handling?
Im having to pull my cert from a KV, inject the resulting var into a .pem file, then split the private key and crt content into seperate files so my app can then use the two files to setup its TLS config.
Im spending a lot of time building pipeline yaml  to understand the handling of the TLS data and its formatting.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69ff8e50-4187-3622-1beb-155f006af5f5
Version Independent ID: bc56fa96-bded-95f8-39a4-a9e5242db1bf
Content: Azure Key Vault task - Azure Pipelines
Content Source: docs/pipelines/tasks/deploy/azure-key-vault.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

When Azure Key vault task is used for retrieving a certificate, it is stored as a string, from which the pfx needs to be retrieved.  Please refer to this Azure key vault product documentation for more details.


SPI host Misses last Byte of Segment

After #8620 was fixed another bug shows up - that wasn't there before.
after transmitting the segment 0 of 1 byte correctly - the DUT misses that last byte of segment 1
----| Command Register |----
----| Command: WriteStd
----| Segment Command
----| Length: 0
----| Mode: Standard
----| CSAAT: 1
----| Direction: Bidir
----| DATA |----
----| [ 0] fc |----
Segment 1 (address 32bit)
----| Command Register |----
----| Command: WriteStd
----| Segment Address
----| Length: 3
----| Mode: Standard
----| CSAAT: 1
----| Direction: TxOnly
----| DATA |----
----| [ 0] 4a |----
----| [ 1] e5 |----
----| [ 2] 79 |----
----| [ 3] 28 |----   <------- THIS BYTE IS MISSED
tracking this backwards this seem to be due to a premature clr_i to the prim_packer
which is generated by the cmd_end in the FSM

recreate this checkout:
run:
./util/dvsim/dvsim.py hw/ip/spi_host/dv/spi_host_sim_cfg.hjson -i spi_host_smoke -r 1 -t xcelium --job-prefix="nc run -C ncsim_interactive -Il" -w=shm -s=1

Hi @rasmus-madsen, thank you for pointing this out! I can reproduce the error, but I am wondering in this case, is the last segment data not successfully transmitted? It seems like the data in the first segment (data "cc") is not transmitted, since csb was asserted after tx_data_i was changed. Am I missing something here? Thanks!

Hi @rasmus-madsen, thank you for pointing this out! I can reproduce the error, but I am wondering in this case, is the last segment data not successfully transmitted? It seems like the data in the first segment (data "cc") is not transmitted, since csb was asserted after tx_data_i was changed. Am I missing something here? Or they are not aligned in this way?

Hi @Muqing-Liu
I am not sure if you figured this out - but the CC is transmitted.
the CC you are point in to is from the bus - but the CSB circled in my drawing is related to the spi pins. which is why it comes later.

Besides, I'm wondering what is the use of the data transmitted in the third segment for read command? Thanks!

Since this is legal behavior it it needs to be verified that the DUT handles it correctly


Option for responsive gutters

Added $global-gutter-small var to settings and media-query to allow for
different gutter sizes on mobile and desktop.
Implementation of #764

Thanks for your contribution to Foundation Emails.

I'm using v2.2.0 and adding $global-gutter-small to the settings.scss seems to have no effect on the gutter sizes on small screens when testing in browser, or using litmus. Is this working correctly?

@drball this was merged 6 months ago and is only in the current master branch, there is no release which contains this. You can try npm i foundation/foundation-emails to get the latest changes.

@drball this was merged 6 months ago and is only in the current develop branch, there is no release which contains this. You can try npm i foundation/foundation-emails to get the latest changes.


exclude monitor and git-importer from oss manifest

these are deployments for monorepo mode and do not belong in the OSS/multirepo deployment.
This is already handled in the new make targets, but this fixes the old make target in the meantime.

/lgtm
/approve


MAINT: signal.sosfreqz: rename to freqz_sos

The name sosfreqz is inconsistent with freqz_zpk, lp2lp_zpk, etc.
The function's purpose (freqz) should be the first part of the
name, so that all variants come up during tab completion.
sosfreqz is left as an explanatory alias function for backwards
compatibility.
sosfilt sosfilt_zi sosfiltfilt should also be renamed by the same logic?
(Split off from https://github.com/scipy/scipy/pull/8146 since this depends on https://github.com/scipy/scipy/issues/8319)

I guess not.  sosfilt sosfilt_zi sosfiltfilt could be another PR.

Thanks @endolith.
Over in #8146 @rgommers seemed skeptical of this renaming / deprecation. We should probably wait for more comments.

This still feels wrong to me. The sos* functions are fairly new, and now we want to deprecate them in order to gain a minor amount of naming consistency? Forcing all users to update their code for that doesn't seem right.
I could be convinced to add the new names, but leave the other ones as well as aliases. With perhaps a doc-only statement to prefer the new names over the old ones.

@rgommers Well if they're fairly new then they haven't been used much yet, right?  :)

I could be convinced to add the new names, but leave the other ones as well as aliases. With perhaps a doc-only statement to prefer the new names over the old ones.

This PR does leave the old name as an alias, so when you use it you get a warning but otherwise works the same as it did:
>>> w, h = sosfreqz(sos)
__main__:1: DeprecationWarning: `sosfreqz` is deprecated, use `freqz_sos` instead!

>>> sosfreqz?
Signature: sosfreqz(*args, **kwds)
Docstring: `sosfreqz` is deprecated, use `freqz_sos` instead!
File:      c:\anaconda3\lib\site-packages\numpy\lib\utils.py
Type:      function

This PR does leave the old name as an alias, so when you use it, you get a warning, but otherwise works the same as it did:

That's not quite right. That warning means "we're removing this function in two releases, please update your code". So removing this warning and instead changing the docs of the old names to say "this is an alias of ; this function will remain for backwards compatibility" is what I meant. Let's see first if others agree though.

I don't have a strong feeling either way.

So should https://github.com/scipy/scipy/issues/8319#issuecomment-377967296 be re-opened?

Any updates on this?
I can create the alias to start the deprecation process of the previous name. Or we just leave the old name hidden.

Or we just leave the old name hidden.

Yes I think we should based on the discussions above. Feel free to open a new PR if you want.

closed in favour of gh-21025 - thanks @endolith !


Don't allow non-admins to edit old reservations

Could cheat!
Originally created by Tom Smyth at 2017-04-03 00:37, migrated from redmine-#6181

Status changed from New to Closed

By Tom Smyth at 2018-08-18 20:05

Version set to 6.1

By Tom Smyth at 2018-09-27 20:02


Missing rate limiting

The DNS over TCP tool is missing rate limiting functionality.
Set a default value to e.g. 100K and add an optional command line argument -pps- (packets per second) so a user can define a more strict rate limit.

Rate limiting was added with 82198d6906c3f95138c7ab6070454fed5e8bb18b and is set in the config.yml,
an optional command line argument (-r or --rate) with d998180c28aba40c14b27557f0b575006c0dc802


K8s 101 YT playlist has extra video

Wanted to let you know that there is an extra video in your K8s 101 playlist that I didn't think was intended to be there:
https://www.youtube.com/playlist?list=PL2_OBreMn7FoYmfx27iSwocotjiikS5BD
I have not clicked on it, but it looks to be from this YT user:
https://www.youtube.com/user/questort
Do you know this user?

I have no idea how that happened, but I've removed that video from the playlist. Thanks for letting me know!


docs(useNetworkState): proper hook naming in docs

What is the problem?
Invalid hook name in docs, aslthough it is properly named in code.
Fixes #251
What changes does this PR make to fix the problem?
Checklist

[x] Is there an existing issue for this PR?

#251

:tada: This PR is included in version 10.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix security issue in dependencies

Landed in https://github.com/metarhia/do/commit/1a71890f67d49ce8fec81a4410c507cf2ea435b2


Provide full-stack Docker image for evaluation, personal and development purposes

I would love to have a Docker image that runs up-to-date Plone with Pastanaga UI themed plone-react frontend.
It would not need to be production quality. Just something to evaluate and play with. With your opinionated Plone content type selection.
gatsby-source-plone GSOC could use it to develop tiles support for the plugin.
Anyone could use to play with it locally and publish the results as gatsby-source-plone -powered gatsby-site.
The ugly part would be that it would run multiple processes in container. Would supervisor be suitable to run as the main process and manage the others? (It some container use designed init.) It could expose all ports to ease debugging (plone, supervisor, plone-react’s server).

We already have a demo site running with Pastanaga, plone-react, and plone.restapi. Not sure how @sneridagh actually did it. Maybe that is something that we could use as a starting point. I will add it to the Costa Brava sprint topics.

@datakurre @tisto The current docker image that we use only includes the Plone backend. We can take a look into and add a full fledged docker-compose with two images, the backend and the frontend. Shouldn't be hard :)

I guess, docker-compose mash-up is ok.

@sneridagh Any chance you could release plone-react-image at the end of Costa Brava Sprint? :)

The this time of writing, https://github.com/plone/plone-frontend is the canonical Docker image for Volto.
There is a docker-compose configuration available as reference:
https://github.com/plone/volto/blob/5ca8bba560a485190d0ff8c55e52baf8c5b6ea7c/docker-compose.yml
Also the deployment training:
https://training.plone.org/5/plone-deployment/index.html


drivers: adc: ltc2451: Add ltc2451 resolution to config

Adds resolution to config struct

What is the resolution value used for?

I wasn't entirely sure whether the resolution value was useful enough to be upstreamed, but locally we use it in some calculations so I wondered whether it would be useful for others.