HiFiC modules

Implements the following modules from Mentzer, et al. (2020)

HiFiCDiscriminator
HiFiCEncoder
HiFiCGenerator

@misc{mentzer2020highfidelity,
      title={High-Fidelity Generative Image Compression},
      author={Fabian Mentzer and George Toderici and Michael Tschannen and Eirikur Agustsson},
      year={2020},
      eprint={2006.09965},
      archivePrefix={arXiv},
      primaryClass={eess.IV}
}

Originally implemented in TensorFlow Compression (TFC) by the author (@relational).

I'm not sure how to deal with the MyPy kwargs issue without inlining. @mmuckley Any suggestions?

Hello @0x00b1, I'm not sure it's that easy as **kwargs could have essentially any type. That being said I think I agree with mypy - **kwargs can pass on essentially anything and as such can be a breeding ground for bugs. My suggestion would be to just fully specify all kwargs and let users subclass and extend the models when needed to pass new parameters.
Note that this is primarily due to the code being in the core repository - if it were under projects then I would say we can adopt a soft linting standard and you could just disable mypy for your folder.

@mmuckley Thanks! I love the changes.


adding synonym label matching violations

Finds pairs of classes where one class's label is the same as another's synonym.
Question: Once these are detected, how does one repair this? Which class is "at fault" for duplicated labels/synonyms?

Shouldn't this only be done when the synonym scope is exact? I think it is valid to have the same string for synonyms of other scope.

https://github.com/geneontology/go-ontology/issues/15686

Thanks


Add support for subwoofer gain controls

Adds support for controlling the subwoofer gain using the SoCo.sub_gain property. This property name matches the key from the RenderingControl event payload.
Needs validation testing from a system that contains a subwoofer.

@bachya Thanks for testing, adjusted thresholds based on your feedback. 👍

I'll test (and presumably merge) this later today. Sorry for the delay.

Working perfectly with my Play:1 x 2 + Sub rig. Also behaving as expected when tested against a device without a Sub.
Thanks for your work on this -- it's something I've (selfishly) wanted for a while.
I'll merge as-is, but it would be nice to add a test in a subsequent PR.


Routing fixes

Fixed the issues caused by merging #22 #52 #57 together. The pull requests had to be updated with the router code.
This also adds #65 through #52
resolves #22
resolves #52
resolves #57
resolves #65
I need @c-suh to verify that the latest changes are there and functional. I tested end to end with a dummy excel doi. @c-suh can use her tests to double check everything is working.

@tloubrieu-jpl, I left a review above, but you might want to sign off on my points 1 and 2 as "fine as is"?

Thanks @c-suh , I will create new tickets for your comments so that I can merge now. Thanks

Hi @eddiesarevalo,
Were you able to change the buton label to create a new DOI after one is reserved ?
Thanks,
Thomas

@tloubrieu-jpl I changed the label for the button. I also changed the basename subdiretory to '/dois'

thanks @eddiesarevalo , is the basename subdiretory hardcoded ?
for the production deployment we want to deploy the build application in an apache directory and ideally the application would be agnostic of which apache directory it is deployed in.

@tloubrieu-jpl Try to test this latest commit. It should allow deployment on any sub directory. I have only been able to test locally but you can try it on your server.
Use npm run build to get the built code.

Thanks @eddiesarevalo that works. There is only a minor issue that does not prevent from merging and deploying on pds-gamma. I created a ticket #70


Add infinite scroll and trending options to channel pages and suggest channel page

The Issue
The channel page should use infinite scroll similar to the other main views. We should also add the trending/top/new sorting to channel pages, with the default of new.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Mobile has this, let's catch up!

Also update this URL to something cleaner: https://lbry.tv/$/following/channels/manage

I'm glad this is being worked on, I was about to open an issue myself.  It would be useful to have sort by oldest too, especially if you do end up getting rid of pagination and moving only to infinite scroll.  It's more of a big deal on mobile, but having to scroll forever to watch things chronologically would be a pain in some cases.
Just my 2 cents.


chore: ai fix styles [IDE-579]

Description
Super WIP 🏗 🚧 👷♀
This change goes together with https://github.com/snyk/snyk-intellij-plugin/pull/587
Checklist

[ ] Tests added and all succeed
[ ] Linted
[ ] README.md updated, if user-facing
[ ] License file updated, if new 3rd-party dependency is introduced

Cherry-picked these changes and moved them to https://github.com/snyk/snyk-ls/pull/647


FIX: build system issues

This is correcting the remaining issues with the CONDA_PREFXI vs CONDA_PREFIX typo.
PROJ_NETWORK env variable
add Baltrad notebooks to toc
more environment output for debugging/overview purpose

@DanielMichelson This in combination with #47 should get Baltrad back in business. I'll check the Baltrad notebooks to be absolutely sure.

There are issues with the Python environment. Not sure if they stem from the recent shapely/cartopy problem. I'll investigate locally.

Locally at least the wradlib2baltrad notebook (which breaks currently on CI) works as expected (using repo2docker). I've added a notebook here which prints out some information about the python environment. Maybe there is some hint, what is broken here.

There are issues with the Python environment. Not sure if they stem from the recent shapely/cartopy problem. I'll investigate locally.

wradlib uses GDAL which uses PROJ. PROJ used to have it's transformation database inside the package. That changed a while back. Setting env var PROJ_NETWORK=ON enables PROJ to retrieve needed transformations from network resources.

@DanielMichelson The pyart2baltrad notebooks bear a very ancient nbformat (3.0). This is obviously not detected by the bookbuilder and so these notebooks are not run automatically. They might have to be updated to a more recent version (4.4 would work well).

So, it looks like the environment for the notebook server is not derived from the user profile.
We could use (in theory) some env file with the needed environment variables or find some other means to do. Starting the notebook server from an activated environment would be best, IMHO, to have all activation scripts processed.

The pyart2baltrad notebooks could not be processed because they were missing at the right location. I'll add the necessary copy command.

Got lost in the two different build scenarios. Hope that activating the notebook environment within the book build will work around the current issues.

Note to self: Keep in mind that we have two workflows, one for PR and one for PUSH. :grimacing:

:crossed_fingers: that this works for PULL Requests now. Should work for PUSH (as it worked there before).

I've no explanation for the differences:
This PR:
https://openradarscience.org/erad2022/_preview/48/notebooks/baltrad2wradlib/baltrad2wradlib.html
The latest PUSH to main:
https://openradarscience.org/erad2022/notebooks/baltrad2wradlib/baltrad2wradlib.html
There is obviously some difference in the setup of the book environment. For push the docker container is used directly, for pull request this is done via a docker-run-action. Good chance that via that action the environment is missing some variables. That's unfortunate but we have to live with. If someone has any idea how to track down the root cause, please let me know.
The baltrad issues should be finally cleared with this PR.
@mgrover1 This is ready from my side.

LGTM!

That was a tough ride! Thanks @DanielMichelson for bringing this up.

THANK YOU SOOO MUCH @kmuehlbauer!
Thanks also @mgrover1 for your support, and for accepting the PR!
I am now successfully updating the BALTRAD notebooks! I'll let you know when they are ready.


Replace deprecated code

A new install with Python 3.12 will (unless otherwise instructed) install the latest numpy (2.0.0) and matplotlib (3.9.0) versions. Both remove previously deprecated features that are still used in DYNAMITE and that cause errors.
This PR fixes DYNAMITE by

Replacing numpy.product(...) with equivalent numpy.prod(...). The methods have been equivalent for a while, now one got removed from numpy, see https://numpy.org/doc/stable/numpy_2_0_migration_guide.html.
Replacing matplotlib.cm.get_cmap(...) with matplotlib.colormaps.get_cmap(...). This method has been removed from matplotlib 3.9.0, will be re-added in 3.9.1 just to be removed again two minor releases later. I think it's best to replace it now, see https://github.com/matplotlib/matplotlib/pull/28355.

Tested successfully:

test_nnls.py with all three weight solving options LegacyWeightSolver, NNLS-scipy, and NNLS-cvxopt (Python 3.12.4+numpy 2.0+matplotlib 3.9.0 and Python 3.8.19+numpy 1.24.4+matplotlib 3.7.5)
test_notebooks.sh (Python 3.8.19+numpy 1.24.4+matplotlib 3.7.5)

Tested unsuccessfully (notebook 4 fails because plotbin is not compatible with matplotlib 3.9)

test_notebooks.sh (Python 3.12.4+numpy 2.0+matplotlib 3.9.0)

I sent a change request to the maintainer of plotbin and will update this PR as soon as I get a reply reply.

Many thanks Michele Cappellari for the hyper-quick update of plotbin!
The last commit updates the required plotbin version to 3.1.7 and fixes a related deprecation in plotter.py.
Re-tested successfully with the new plotbin version and both an ‘old’ Python 3.8 and a ‘new’ Python 3.12 setup.

test_nnls.py with all three weight solving options LegacyWeightSolver, NNLS-scipy, and NNLS-cvxopt:

Python 3.12.4+numpy 2.0.0+matplotlib 3.9.0+plotbin 3.1.7
Python 3.8.19+numpy 1.24.4+matplotlib 3.7.5+plotbin 3.1.7

test_notebooks.sh:

Python 3.8.19+numpy 1.24.4+matplotlib 3.7.5+plotbin 3.1.7
Python 3.12.4+numpy 2.0.0+matplotlib 3.9.0+plotbin 3.1.7

Closes #395.
Ready for testing and review...

Merging after testing together with Alina...


oidc-guard fails to start on Apple Silicon M1

Hello, I wanted to test OIDC-Guard locally on my docker-desktop cluster via helm.
I ran into the following error, emitted by the Pod logs:
rosetta error: failed to open elf at /lib64/ld-linux-x86-64.so.2

Any idea what is going on and how to mitigate this?

See this issue, https://github.com/docker/roadmap/issues/384


Add Alauda to vendor list

Add Alauda to vendor list.

/fix:all

@svrnm @cartermp
Task [Links / WARNINGS in build log? (pull_request)] failed, but I don't see a detailed log.
Might it be related to “LastSeen”: “2024-11-12T02:45:52.6256235486Z”?

Might it be related to “LastSeen”: “2024-11-12T02:45:52.6256235486Z”?

Yes:

panic: parsing time ""2024-11-12T02:45:52.6256235486Z"": fractional second out of range

That's a bug with the html test tool, we have reported this issue upstream already:
https://github.com/wjdp/htmltest/issues/237
The only way to fix that is manually updating that timestamp, if you can do it yourself, please go ahead otherwise I can fix it.

wjdp/htmltest#237

Can you help fix it? I'm not quite sure of the correct timestamp format. Thanks!

@svrnm Can you help fix it? I'm not quite sure of the correct timestamp format. Thanks!


Responsive

Merge in after #26 .
Most responsive issues fixed that i could find...if time permits, we need to overhaul the table logic in the search results to just have divs.

This is messing w the footer a little bit (the logo section & text wrapping)

@stevenbursztyn not sure about the logo issues you're seeing, could you post a screencap?

mobile:

(only change on this is mobile b/c it doesn't make sense to keep a huge logo at the bottom as a footer, so i just scale it down)
Also for search, do you want height limited to 200px? i wasn't sure if that was meant  to be put in or not

@abhisuri97 More or less what the footer should look like (as it does now on web):

What the footer looks like in this PR (logo is in a weird position, and i guess text alignment also off but thats an easier fix):

===========
Regarding search, this is what it should still look like:

but it's looking like this instead:

I'm getting a  very weird misalign on the top at desktop size which is why i chose to just align to bottom right
I think i fixed search. issue is  that i've made search responsive so it isn't constrained to a table anymore, so enforcing an image size on it is a bit weird (typically you go by percentage values).


Change startProfileAt to not use enums

this is quite stale closing and we can make it part of the larger effort to end all functions that might have a tag with a trailing optional tag


Add complexity rating to issue template

The Problem/Issue/Bug:
We decided to add a complexity rating to our issue template. Here's a shot at it.
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

Good start and this is where I start overthinking. Seems like we might need to link to our docs and then highlight a 1-5 scale.
5 ~ more than a month
4 ~ more than a week, less than a month
3 ~ more than a day, less than a week
2 ~ more than an hour, less than a day
1 ~ trivial, within an hour
The above more or less catches an order of magnitude, which is all that's really being asked. Alternatively, we could just ask what level of effort on the order of "hours, days, weeks, months
" so there is no need to go to a rating system to interpret.

IMO the process is a separate thing. We don't need to specify the process in the template here.
I would say at this point that anything 3 and above should make us think twice and ask questions about how the resulting work should be structured.

I'm fine with starting with the simpler version for now and revisiting if it comes to the point of inconsistent usage or question of what to rate things. I just always find it handy to get a relative sense of sizing and will probably use the scale I provided in my own noggin.


feat: add network policy

Description
Fixes FL-1609
How to test

Screenshots

Notes for developers and reviewers:

Think to update CHANGELOG.md before merge if needed !

/e2e --tests frontend,substrafl

End to end tests: :hourglass_flowing_sand: STARTING


Borrow integration

Overview
Jira ticket: SAF-11
Borrow integration, calculations and transactions assembling.
Comments
Includes changes from https://github.com/wakeuplabs-io/sovryn-dapp/pull/23 I found a bug there, so will fix that first or try to split the changes to allow for this merge if takes longer. Current contracts deployment fail for borrow action so in demo don't move it through but parameters and methods have been tested in polygon.
Demo
https://github.com/user-attachments/assets/9ecb6aaf-3bd3-4690-addf-ab8a45888de2

Used mentioned component, replaced apy with apr and health factor with collateral ratio
Sorry, pretty awful video jejej
Uploading 2024-08-23 18-43-09.mp4…

Used mentioned component, replaced apy with apr and health factor with collateral ratio
Sorry, pretty awful video jejej
https://github.com/user-attachments/assets/ebccb9c6-98d5-4107-a87f-563209914176


Add Stellar OSS projects and create collection

What is it?
https://airtable.com/appymB1sbp5uidiGe/shrsaWm1IyNZTCEhX/tblpytbu3t73kssiE

@ccerv1 Will do this in a few batches, starting with projects that have shared the link to the Github repo. Amongst the projects that have provided a website but no info on Github, I am finding that the website often includes a reference to Github. Will manually recover the Github link and process such projects in the second batch.

Ready for merge here - https://github.com/opensource-observer/oss-directory/pull/524

@ccerv1 the collection is ready to merge here: https://github.com/opensource-observer/oss-directory/pull/529


[UE4] Crashing Randomly After Updating Plugin

After updating to 4.1.0 Unreal has started crashing when a sound should play, or randomly without known cause. Attached is the engine crash report.
Assertion failed: bSettingsLoaded [File:H:/egg-game/Plugins/SteamAudio/Source/SteamAudio/Private/SteamAudioManager.cpp] [Line: 398]

UE4Editor_Core
UE4Editor_Core
UE4Editor_SteamAudio!SteamAudio::FSteamAudioManager::GetRealTimeSettings() [H:\egg-game\Plugins\SteamAudio\Source\SteamAudio\Private\SteamAudioManager.cpp:398]
UE4Editor_SteamAudio!SteamAudio::FSteamAudioSpatializationPlugin::OnInitSource() [H:\egg-game\Plugins\SteamAudio\Source\SteamAudio\Private\SteamAudioSpatialization.cpp:179]
UE4Editor_AudioMixer
UE4Editor_AudioMixer
UE4Editor_AudioMixer
UE4Editor_AudioMixer
UE4Editor_AudioMixerCore
UE4Editor_AudioMixerCore
UE4Editor_AudioMixerCore
UE4Editor_Core
UE4Editor_Core
kernel32
ntdll

Could you provide a minimal project in which this issue can be reproduced? Alternatively, could you provide us with the minidump from this crash? Thanks!


fix security vulnerability GO-2024-2687

Update golang.org/x/net from v0.17.0 to 0.23.0
Reference: https://go.dev/issue/65051

passes quay security check. Closing.


Daily overview - average Download/Upload/Ping

From https://github.com/henrywhitaker3/Speedtest-Tracker I'm missing the daily average overview I'm getting with my telegram bot:

Would be neat if it were implemented. 24hrs, every hour a test, after 24h average is sent. I can work around it, right now, by just having 1 test every 24hrs and then sent to the telegram channel, but that's not what I need.

Duplicate of #328


How to use the finetuned model?

Thanks to your work, I've been able to use the finetune script on the llama-13b model (and only took 3 hours on a 3090!)
I see the output folder for the finetune has:
adapter_config.json
adapter_model.bin
<bunch of checkpoint folders>
checkpoint-7500

How can I use these output files for inference with text-generation-webui (preferably in 4 bit mode)?
With the alpaca-lora repo (8bit), I used the included export_hf_checkpoint.py script but don't see a similar thing here.

Figure out how to make it work. For others, I used the instructions here: https://github.com/s4rduk4r/alpaca_lora_4bit_readme to setup text-generation webui then changed thecustom_monkey_patch.py to have import server as the last line.
After that, just run python custom_monkey_patch.py and it generated using the finetuned lora.
Thanks for sharing this repo @johnsmith0031 - both the speed of inference and training are incredible.
Now I'm going to see if I can train a 30B model instead of the 13B :)


[stable/dask] bump dask to 1.0.0

What this PR does / why we need it:
bump dask to 1.0.0
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/lgtm


Fix tiflash crash caused by local tunnel

What problem does this PR solve?
Issue Number: close #6615
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @windtalker @SeaRise

/hold

/unhold

/cc @SeaRise @windtalker

/run-all-tests

/run-all-tests

/run-all-tests

/cc @windtalker @SeaRise

/run-all-tests

/cc @SeaRise @windtalker

/merge

/run-all-tests

/run-integration-test

/run-integration-test

/run-integration-test

/run-all-tests

/build

/run-all-tests

/merge

/run-unit-test

/run-unit-test

/run-unit-test


⚠ Roblox Devforum has degraded performance

In 17e24f5, Roblox Devforum (https://devforum.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 4685 ms

Resolved: Roblox Devforum performance has improved in fd5cdfa.


Roll engine 4eaf9ef4271a..572fa5646af7 (1 commits)

https://github.com/flutter/engine/compare/4eaf9ef4271a...572fa5646af7
git log 4eaf9ef4271a..572fa5646af7 --no-merges --oneline
572fa5646 Roll src/third_party/skia 032f2756df64..51c89e41c05b (16 commits) (flutter/engine#6453)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Auto-roller completed checks. About to merge.


Way to operate on folders instead of files?

Hi! First of all, I'm very happy organize exists and and eager to contribute some features that I personally need. if you prefer to keep this project sweet and simple that is fine too of course!
Anyways, here I go with another feature request that I will attempt to build.
Consider the following use case:
# move stale projects to archive
  - subfolders: true
    folders:
      - '~/projects/'
    filters:
      - LastModified:
          days: 90
          mode: older
    actions:
      - Move: /mnt/raid/archive-projects/{relative_path}
    subfolders: true

This technically works but has the following downsides:

Files trickle over depending on their individual LastModified date. The level of annoyance from this depends on the nature of your projects.
Empty folder structure gets left behind. I feel like removing empty folders should definitely be a something organize can do.

Hazel has a feature to match folders specifically (see screenshot below). Another valid value for the Kind field is Music, which switches the list of available filters to ones applicable to music files or any kind as well as generic ones.

Now in the case of organize, I would suggest adding one relatively simple flag to the rule that will make the rule target folders only instead of files only:
# move stale projects to archive
rules:
  - target_folders: true
    folders:
      - '~/projects/'
    filters:
    - LastModified:
        days: 90
        mode: newer
    actions:
      - Move: /mnt/raid/archive-projects/{relative_path}

By adding 3 lines of code https://github.com/mope1/organize/commit/8bcfe3502e984f11d6799da475072d0098d3d9bd the flag can be implemented and it already works with LastModified filter and Move action without further changes.
Now obviously some filters and actions might be more tricky, but imho if you defaulted the filter class to never match folders (or maybe error out if not implemented) when applied to folders, this feature would be quite useful. I could imagine e.g. a filter called Empty that works on both files and folders as well.
UPDATE Turns out i'm less clever than i tought, as modifiying a file does not update the parent directory's DateModified, only the creation of new files. Therefore, more extensive changes would have to be made to the filters.

This is finally built in! Targeting directories


[BUG] The list of possible services is saved to an entry once used.  If the user removes a service, it will still be listed if the user edits the entry later.  Attempting to use the missing service results in an error.

HCL Product Version
12.0 Daily Build
Describe the bug
When a calendar entry is created it will get a confList item that contains a fixed list of online meeting services.  If the user removes or adds any services after the entry is first created then they will see an incorrect list of available meeting services under the Schedule Online Meeting... button.
Error Message
If the user tries to use a service that no longer has a credentials doc:
Problem obtaining auth Token from Online Meeting Credentials
The user does not see any online meeting services that have been added since the entry was created and saved.
To Reproduce
Steps to reproduce the behavior:

Go to Calendar
Click on New
Fill in the Subject
Click on Save and Send Invitations (no need to add any invitees or actually use the meeting service)
Go to the Online Meetings Credentials view
Delete the credentials for any online meeting service
Go back to the Calendar
Open the entry created in step 2
Click on Schedule Online Meeting... and select the service removed in step 6
See error

Expected behavior
The list of services available to the user should not be saved in a static list to the entry.  The list of services should be recreated each time the entry is opened.  That will guarantee that the user only see available meeting services.
In the case of removing the credentials after the meeting services was used to create an online meeting, the Delete  Meeting button should remove the online meeting info even if the credentials are no longer available.  When the updates are sent to invitees they will see there is no longer an online meeting which is better than them seeing a meeting that is no longer usable.
Screenshots

Desktop (please complete the following information):
Win10 Enterprise
Additional context
The fix for this is to remove the confList item from the entry when the entry is saved.  That will cause the list of usable services to be recreated each time the entry is opened.  Removing the confList item requires a change to the core mail template scripts and is not something that DOMI may be able to without some risk.

Resolved with code in pull request #61


Use binary_type in MongoDBStore.getitem for Python 2 only

Previously there were some test failures on Python 2 and referenced in this comment (and later discussion). Turns out on Python 2 a bson.Binary instance is returned, which subclasses bytes, as explained in the docs. So the coercion to bytes i only needed on Python 2 to convert bson.Binary to bytes. Thus we restricts the binary_type call to Python 2. Should avoid a copy on Python 3.
xref: https://github.com/zarr-developers/zarr/pull/372
TODO:

[ ] Add unit tests and/or doctests in docstrings
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions
[ ] New/modified features documented in docs/tutorial.rst
[ ] Changes documented in docs/release.rst
[ ] Docs build locally (e.g., run tox -e docs)
[ ] AppVeyor and Travis CI passes
[ ] Test coverage is 100% (Coveralls passes)

Hello @jakirkham! Thanks for submitting the PR.

In the file zarr/storage.py, following are the PEP8 issues :

Line 4:80: E501 line too long (80 > 79 characters)
Line 8:80: E501 line too long (86 > 79 characters)
Line 9:80: E501 line too long (82 > 79 characters)
Line 10:80: E501 line too long (84 > 79 characters)
Line 11:80: E501 line too long (84 > 79 characters)
Line 12:80: E501 line too long (85 > 79 characters)
Line 13:80: E501 line too long (81 > 79 characters)
Line 14:80: E501 line too long (89 > 79 characters)
Line 43:80: E501 line too long (84 > 79 characters)
Line 44:80: E501 line too long (80 > 79 characters)
Line 102:80: E501 line too long (83 > 79 characters)
Line 125:80: E501 line too long (84 > 79 characters)
Line 151:80: E501 line too long (85 > 79 characters)
Line 152:80: E501 line too long (83 > 79 characters)
Line 164:80: E501 line too long (85 > 79 characters)
Line 210:80: E501 line too long (92 > 79 characters)
Line 281:80: E501 line too long (86 > 79 characters)
Line 308:80: E501 line too long (80 > 79 characters)
Line 317:80: E501 line too long (90 > 79 characters)
Line 326:80: E501 line too long (85 > 79 characters)
Line 327:80: E501 line too long (80 > 79 characters)
Line 377:80: E501 line too long (81 > 79 characters)
Line 380:80: E501 line too long (83 > 79 characters)
Line 382:80: E501 line too long (89 > 79 characters)
Line 406:80: E501 line too long (94 > 79 characters)
Line 467:80: E501 line too long (80 > 79 characters)
Line 673:80: E501 line too long (80 > 79 characters)
Line 705:80: E501 line too long (84 > 79 characters)
Line 706:80: E501 line too long (83 > 79 characters)
Line 754:80: E501 line too long (83 > 79 characters)
Line 765:80: E501 line too long (87 > 79 characters)
Line 922:80: E501 line too long (80 > 79 characters)
Line 937:80: E501 line too long (80 > 79 characters)
Line 1014:80: E501 line too long (85 > 79 characters)
Line 1024:80: E501 line too long (82 > 79 characters)
Line 1025:80: E501 line too long (83 > 79 characters)
Line 1072:80: E501 line too long (80 > 79 characters)
Line 1074:80: E501 line too long (83 > 79 characters)
Line 1085:80: E501 line too long (80 > 79 characters)
Line 1097:80: E501 line too long (80 > 79 characters)
Line 1104:80: E501 line too long (88 > 79 characters)
Line 1108:80: E501 line too long (82 > 79 characters)
Line 1117:80: E501 line too long (88 > 79 characters)
Line 1126:80: E501 line too long (84 > 79 characters)
Line 1127:80: E501 line too long (83 > 79 characters)
Line 1141:80: E501 line too long (87 > 79 characters)
Line 1145:80: E501 line too long (80 > 79 characters)
Line 1159:80: E501 line too long (89 > 79 characters)
Line 1333:80: E501 line too long (85 > 79 characters)
Line 1336:80: E501 line too long (88 > 79 characters)
Line 1346:80: E501 line too long (80 > 79 characters)
Line 1359:80: E501 line too long (80 > 79 characters)
Line 1361:80: E501 line too long (80 > 79 characters)
Line 1365:80: E501 line too long (84 > 79 characters)
Line 1376:80: E501 line too long (80 > 79 characters)
Line 1388:80: E501 line too long (80 > 79 characters)
Line 1390:80: E501 line too long (80 > 79 characters)
Line 1394:80: E501 line too long (82 > 79 characters)
Line 1395:80: E501 line too long (83 > 79 characters)
Line 1418:80: E501 line too long (83 > 79 characters)
Line 1457:80: E501 line too long (83 > 79 characters)
Line 1460:80: E501 line too long (87 > 79 characters)
Line 1527:80: E501 line too long (83 > 79 characters)
Line 1536:80: E501 line too long (87 > 79 characters)
Line 1547:80: E501 line too long (80 > 79 characters)
Line 1560:80: E501 line too long (80 > 79 characters)
Line 1562:80: E501 line too long (80 > 79 characters)
Line 1566:80: E501 line too long (84 > 79 characters)
Line 1572:80: E501 line too long (86 > 79 characters)
Line 1573:80: E501 line too long (90 > 79 characters)
Line 1575:80: E501 line too long (87 > 79 characters)
Line 1576:80: E501 line too long (86 > 79 characters)
Line 1583:80: E501 line too long (89 > 79 characters)
Line 1584:80: E501 line too long (87 > 79 characters)
Line 1591:80: E501 line too long (83 > 79 characters)
Line 1592:80: E501 line too long (84 > 79 characters)
Line 1593:80: E501 line too long (89 > 79 characters)
Line 1597:80: E501 line too long (84 > 79 characters)
Line 1598:80: E501 line too long (87 > 79 characters)
Line 1701:80: E501 line too long (81 > 79 characters)
Line 1702:80: E501 line too long (80 > 79 characters)
Line 1711:80: E501 line too long (87 > 79 characters)
Line 1720:80: E501 line too long (90 > 79 characters)
Line 1727:80: E501 line too long (91 > 79 characters)
Line 1731:80: E501 line too long (91 > 79 characters)
Line 1749:80: E501 line too long (82 > 79 characters)
Line 1750:80: E501 line too long (89 > 79 characters)
Line 1755:80: E501 line too long (82 > 79 characters)
Line 1797:80: E501 line too long (83 > 79 characters)
Line 1813:80: E501 line too long (86 > 79 characters)
Line 1861:80: E501 line too long (86 > 79 characters)
Line 1898:80: E501 line too long (80 > 79 characters)
Line 2110:80: E501 line too long (80 > 79 characters)
Line 2207:80: E501 line too long (80 > 79 characters)
Line 2270:80: E501 line too long (80 > 79 characters)
Line 2284:80: E501 line too long (86 > 79 characters)
Line 2317:80: E501 line too long (85 > 79 characters)

Still seems to be failing. This by the way was why I opened #393.

That's right. Just wanted to see if that was still the case after the dust settled.
After doing a little research, it looks like we can safely constrain this coercion to Python 2 only. Have updated the PR to do that. Should make it easier for us to remember to remove when we do drop Python 2.
Could you please give it another look? :)

yep, this looks right. I agree, this will make it easier to undo when PY2 goes away. Thanks.

Thanks @jhamman :)

Thanks @jakirkham for this, nice to know exactly what's going on :+1:

Of course. 😄
FWIW I think we can get a better handle on this behavior by adding a flag to the ensure_* functions to handle subclasses of the expected type (e.g. bytes in this case). Opened PR ( https://github.com/zarr-developers/numcodecs/pull/173 ) along these lines.


How to get Hummingbot pro?

How to get Hummingbot pro for backtesting?

Hi @chenxiemin, Hummingbot Pro is not going to be be released, at least for now. If you are looking for backtesting, there is a channel in Discord called #backtesting and we are talking about possible solutions for this!


Simple Question - block ID confusion

Hey Devs,
I'm running into a too-many-hostiles error with clearlagg, and I'm trying to use adamantinesheld to locate specific blocks. Problem is that the blockID's for the powered spawner don't work.
Is it something different than "enderio:block_powered_spawner" or "enderio:powered_spawner"?
Thanks!
MC: 1.12.2
eio: 5.0.31

enderio:block_powered_spawner is the correct one.


Feature/1731 case flag coverage

JIRA link (if applicable)
1731 – feature/case-flags-2-1-cui-ra
Change description
Sonar Test Coverage
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

There are code conflicts and 15 new code smells in this PR itself. fixing or breaking?

close for sonar test

for sonar test build update


Adding zstd support

As raised in #48, Zstd  compression support has been added.

Not merging as it doesn't work.


what does make_sequential do when using gptq inference?

I run gptq using auto-gptq, and it calls exllamaV2 kernel.
I find it seems to change the layout of q_weight, but I checked the map and map_iv, the are just mapped to themselves in GPTQ.
And after running the kernel, the weight has no change.
Is that redundant ? Or it's used in other quantization methods?

You're probably looking at models quantized without act-order or without group size.
make_sequential rearranges the rows (i.e. the input features) of the weights tensor to correspond to the activation order used when quantizing that matrix.
This activation order is stored in the .g_idx tensor for each weight matrix. For non-act-order models this index is trivial and redundant, but for act-order models it maps each row of weights to a group. A group defines the grid (scale and zero-point) for weights within it, so it's problematic when neighboring rows don't belong to the same group. This gives the best accuracy with GPTQ, but it also means that to dequantize a column slice of 128 weights, you'll need 128 lookups into the .scales and .qzeros tensors. These lookups don't coalesce and become a severe bottleneck.
Instead, ExLlama pre-applies the act-order permutation to the weights (in make_sequential) so the quantized weights are stored in global memory in the same order in which they were quantized (i.e. the order in which they were grouped together). For a group size 128 model, then, rows 0-127 will all belong to group 0, 128-255 belong to group 1, etc., and the bottleneck goes away.
As long as the input tensor is permuted as well, the matmul output will be the same, since a[:, perm] @ b[perm, :] == a @ b. Applying this permutation in the matmul kernel is very cheap since the inputs tend to be very small, so it's a good tradeoff.

same

Thank you for the detailed explanation!
I need to dive into the code to totally understand it.
BTW,  I'm reading a paper which uses a special method to solve the bank conflict when doing de-quantization. https://arxiv.org/abs/2402.10076
I wonder if you have read it.
I'm very confused why de-quantization introduces bank conflicts.
I profiled the reconstruct_gptq_kernel and find it does introduce a lot of bank conflicts. Confused with that.


FireFox: Addons must be signed by r46

Starting with version 43, FireFox by default requires all addons to be signed before they can be installed. Version 46 will remove the hidden option to disable this requirement.
The Toolkit for YNAB available on the Mozilla Add-ons site is unsigned and as such cannot be installed on FireFox versions greater than 43 without tweaks and not at all on v46+.
Are there plans to begin signing releases of Toolkit?

https://wiki.mozilla.org/Addons/Extension_Signing#Timeline relevant wiki link

Alternatively, is ToolKit on AMO currently in the process of being reviewed by Mozilla?

Yup, it's in the process.
Because it's built with Kango it has to be reviewed by an admin so they're taking a lot longer than I hoped it would. Here's the current queue status:

We submitted version 0.3.1 three weeks and five days ago:

We've updated the version on there every time we do a release and it doesn't affect our place in the queue, so the good news is when they get around to reviewing it at least they'll be reviewing the newest version at least.

@computertechie, did you want to know anything else about this or can I go ahead and close?

Sorry for the delayed response!
Nope, that's perfect, seems like you've got it all handled to get Toolkit signed. I'll just have to wait a bit until the review process finishes to use it :)

Hey @computertechie, we passed full review and are now signed.
https://addons.mozilla.org/en-US/firefox/addon/toolkit-for-ynab/
Enjoy!

Hooray! Thanks much :D


whatsapp:// intent not working

in the normal webview we can try this, but I have no idea about this AdvancedWebView
@Override
public boolean shouldOverrideUrlLoading(WebView wv, String url) {
if(url.startsWith("tel:") || url.startsWith("whatsapp:")) {
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setData(Uri.parse(url));
startActivity(intent);
return true;
}
return false;
}

Thanks!
Your solution, wrapped inside myWebView.setWebViewClient(new WebViewClient() { /* ... */ });, is indeed correct and also applicable with this library.


Crash when board setup changes but board position is not 0

The application requires that board setup is made before any actual moves occur. The UI is therefore built to prevent board setup actions by the user once the board display a board position beyond 0. As a final safeguard against violations of the rule, the class HandleBoardSetupInteractionCommand contains a check that, if it fails, raises an exception that causes the application to crash.
Since the release of version 1.6.0 of the app, a relatively high number of crashes (about 100 crashes from 17 different users in the last 90 days) have been reported that are due to this check. The issue needs to be investigated and fixed.

The only source that triggers the execution of HandleBoardSetupInteractionCommand is the method handleTapFrom: in TapGestureController. The trigger occurs only if the property UiSettingsModel.uiAreaPlayMode has value UIAreaPlayModeBoardSetup. The intention is that the user can activate this mode only if the board position is currently 0, and that the app changes the mode to something else (usually UIAreaPlayModePlay) when the user navigates to a board position beyond 0.
No obvious code defects were found that allow the user to violate the mode condition. Two cases were found, however, where the user can circumvent the condition by making iOS recognize a tap gesture while another tap gesture is already in progress.
Case 1: iPad, possibly also small iPhones (UITypePhonePortraitOnly).

Start a new game and play at least one move.
Go to board position 0
Tap and hold the forward button
While the forward button is tapped, tap on "Game actions"
Once the "Game actions" menu is displayed, release the forward button. The board now changes to board position 1.
From the "Game actions" menu that is still open, select the option "Set up board". This option should not be available! Board setup mode is supposed to be available only when the current board position is 0. The option exists, however, because the menu was generated while board position 0 was still active.
Tap on the board to place a stone. The alert "Future moves will be discarded" is now displayed.
Confirm the alert by tapping "Yes".
The app crashes now.
Note that the same technique cannot be used on a big iPhone (UITypePhone) because there tapping + holding the forward button blocks tapping the "Game actions" button.

Case 2: Small iPhones (UITypePhonePortraitOnly).

Start a new game and play at least one move.
Go to board position 0
Tap on "Game actions", then select the option "Set up board".
Tap and hold the forward button
While the forward button is tapped, tap on the board to place a stone. The alert "Future moves will be discarded" is now displayed.
Once the alert is displayed, release the forward button. The board now changes to board position 1.
Confirm the alert by tapping "Yes".
The app crashes now.

The two cases described in the previous comment require the user to perform quite convoluted actions, so it seems unlikely that these are the causes for all the crashes that occur in the field. It seems more likely that other, simpler ways to provoke the crash exist. However, even if further causes are found, any conclusive solution for the issue requires that the two cases are also handled.
The root cause for the two cases is that iOS allows further gestures while the user is performing a tap+hold gesture on a toolbar button. I currently can't think of a way how to prevent that since the application is not in control of handling toolbar button tap gestures. While it might be possible to somehow hook into iOS' gesture handling on a low level, the approach feels too complicated. A much simpler solution is to remove the cause of the crash.
Decision: No longer raise an exception in HandleBoardSetupInteractionCommand. Instead react either by silently aborting command execution, or by displaying an informative alert.


Factors a lot of code out of correctBiasStored/correctBias.py

This is in preparation for also factoring it out of correctBias/correctBias.py,
eliminating a lot of code duplication between the two modules.
Tested using test data and this outputs the same results as without these changes.

Those changes dramatically simplified the code. Thanks a lot!


PHP: fix pecl extension version

Fixes #10842
Created a template file so that we don't have to update the version string manually.

If you don't expect to template anything other than the version, it might be worth having a separate version.h.

No significant performance differences

Mac failure is #11116
Windows failure is #9542
Linux failure is #11205


[CU-868ahwmf1] Correctly unpublish user models when banned

Task linked: CU-868ahwmf1 [Ticket: 10792] Unpublished models can still be found and used for on-site generation


ZMQ is not properly added to the codebase. Many Errors and missing files.

Describe the issue
Unless the --disable-zmq is added to your configuration command, the code is broken and the following error is given;
In file included from init.cpp:49:0:
zmq/zmqnotificationinterface.h:9:33: fatal error: validationinterface.h: No such file or directory
compilation terminated.

When that include is commented out the following compilation error is given:
make[2]: *** No rule to make target 'libsilk_zmq.a', needed by 'silkd'.  Stop.
After fixing that issue I recieved about 20 more compilation errors related to ZMQ files.
I'm not sure how this made it into master to begin with, but it either needs to be completely reverted or fixed.
Steps to reproduce

Follow the normal build instructions.

What platform are you using (Linux, Windows, Mac)
Ubuntu 16

I've updated the issue with more information.

To fully implement ZMQ properly so it can actually function there are several or more files added and upgrades that should have been completed first after researching bitcoin's development history.

The original PR can be found here: https://github.com/duality-solutions/Sequence/pull/64/commits
I was surprised to see that it passed Travis, but after looking at the Travis output I was even more surprised to see that it somehow did not use the newly changed configure and makefiles. It is very strange.

Thank you for removing ZMQ, I'll rework the branch and fix it


[Bug] Container setScale isn't working properly if it contains matter image object, that is set static

Phaser v3.5.1
setScale affects the static matter image coordinates too, but doesn't apply on body
var config = {
    type: Phaser.AUTO,
    width: 800,
    height: 600,
    backgroundColor: '#1b1464',
    parent: 'phaser-example',
    physics: {
        default: 'matter',
        matter: {
            debug: true
        }
    },
    scene: {
        preload: preload,
        create: create
    }
};

var game = new Phaser.Game(config);

function preload ()
{
    this.load.image('block', 'assets/sprites/block.png');
    this.load.image('platform', 'assets/sprites/platform.png');
}

function create ()
{
    this.container = this.add.container(0, 0)
    const testImage = this.matter.add.image(325, 200, 'block', null, { isStatic: true });
    this.container.setScale(0.5)
    this.container.add(testImage)
    this.matter.add.image(400, 300, 'block');
    this.matter.add.image(450, 50, 'block');
    this.matter.add.image(400, 550, 'platform', null, { isStatic: true });
    this.input.on('pointerdown', () => {
        const scaleValue = this.container.scaleX === 0.5 ? 1 : 0.5
        this.container.setScale(scaleValue)
    })
}

tested in examples

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

There's no support for adding objects that have a Matter or Impact Physics Body to a Container. The Container itself can have a physics body, but not its children. We did consider supporting this but the performance hit of all the additional checks and calculations needed didn't make any sense.
This may be something we revisit in the future but will have to remain a known limitation for now (I did make sure this limitation, and others, are covered in the Container docs)


add ccit.txt

@sw-ashai First stage of verification passed, official domain is ccit.js.cn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@sw-ashai Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Add Sysdig Account IDs

I removed the region differentiation, as I think keeping this simple by just tying to an entity is best.


Gardenlet creates the Seed as early as possible

This is required so that the GCM can see the new Seed to

create the seed namespace
replicate the resources from the garden to the seed namespace

How to categorize this PR?

/kind bug
What this PR does / why we need it:
Gardenlet creates the Seed as early as possible.
Which issue(s) this PR fixes:
Fixes #3816
Special notes for your reviewer:
Release note:

/invite @stoyanr

I can confirm that with this change, the error reported in #3816 is no longer reproducible.


Half Working

Hi.
Im a bit confused. I can get half the entries to work
Entry that do work
!about
!auth
PriceCheck
Time
Entries that dont work
!uptime
!get_webhooks
!new_channel [category id] [channel name]
!add_role [channel name] [role name]
!rem_role [channel name] [role name]
!orphans
!lookup
!altcorp
!remindme [5s/m/h/d text]
Sov
!timers
I dont find any errors in the logs that can explain why some work while others dont. Not sure what im doing wrong :(

https://github.com/pvyParts/allianceauth-discordbot#installation
Have you configured the Admin user and channels properly?
## Settings for Allianceauth-Discordbot
DISCORD_BOT_ADMIN_USER = [140706470856622080] #This UserID is allowed to run any command
# Admin Commands
ADMIN_DISCORD_BOT_CHANNELS = [111, 222, 333]
# Sov Commands
SOV_DISCORD_BOT_CHANNELS = [111, 222, 333]
# Adm Commands
ADM_DISCORD_BOT_CHANNELS = [111, 222, 333]

Yes ive added all those and it still wont run :(


mask_sharp error

Traceback (most recent call last):
File "D:\AI\video-retalking\inference.py", line 345, in
main()
File "D:\AI\video-retalking\inference.py", line 201, in main
pred, _, _ = enhancer.process(img, img, face_enhance=True, possion_blending=False)
File "D:\AI\video-retalking\third_part\GPEN\gpen_face_enhancer.py", line 113, in process
mask_sharp = cv2.GaussianBlur(mask_sharp, (0,0), sigmaX=1, sigmaY=1, borderType = cv2.BORDER_DEFAULT)
UnboundLocalError: local variable 'mask_sharp' referenced before assignment

I have same issue too. After 30 min test I fixed it. You can consider my solution:

Check video file on the face model <= the face of the model in video must display 100% on all frame. <= you can cut the frame on video which not exist model face and try again ;)

I have same issue too. After 30 min test I fixed it. You can consider my solution:

Check video file on the face model <= the face of the model in video must display 100% on all frame. <= you can cut the frame on video which not exist model face and try again ;)

Could you please explain in detail how it was done


No-Reference Quality Assessment.

Question 1:
I'm trying to understand the CR metric. Does it represent the percentage of all enhanced images that are considered high-quality (compared to both high-quality and usable results)?
Question 2:
The other metrics mentioned (Accuracy, Kappa, AUC) seem to relate to a model trained for classifying images as high-quality, usable, or rejected only and there is no relation in enhancement here am I missed something?

Thank you very much for your interest in our work.
(1) Here, CR refers to conversion rate as a separate task. Essentially, we enhance rejected retinal images, then utilize a pre-trained quality classification model (you could directly use the quality label classification model in EyeQ: https://github.com/HzFu/EyeQ/tree/master/MCF_Net) for direct inference to determine how many images are converted to high quality.
(2).  Accuracy, Kappa, and AUC are metrics for another classification task.  we use enhanced images for the DR grading task (DR grading label in eye/eyepieces CSV) to check the lesion-preserving quality. Here, we employ a straightforward ResNet-50 model.

Point 2 presents two options for classifying enhanced images in the context of diabetic retinopathy (DR):
Direct inference: A pre-trained model, originally trained on normal images, can be directly applied to predict DR on enhanced images.
Model retraining: Alternatively, the enhanced images can be used to train a new model specifically for DR classification.
so the results in the paper related to what of them ?

Model retraining

is that based on something?

It's all about training from scratch here; you just have to fix the standard backbone and training configuration for all enhanced models. You can use our latest nn-mobilenet, where eyepacs dataloader and eyeq are the same. (https://github.com/Retinal-Research/NN-MOBILENET)


feat(client): add makeself installer

I forgot to bring this machinery along with the go CLI migration in #4341.

Code LGTM.

lgtm


try {...} else {...} is documented but doesn't work

The language specification (https://elv.sh/ref/language.html#try), section 8.9 (Exception control: Try), item 3, states:

If no exception occurs and else is present, else-block is executed. Example:

~> try { nop } else { echo well }
well

But this does not work. I get:
% try { nop } else { echo well }
Compilation error: try must be followed by a catch block or a finally block
  [tty 8]:1:1: try { nop } else { echo well }

Unfortunate, because this would be a useful feature if it worked.
I am using the latest release, 0.19.2.

The documentation needs clarification. A catch block is always required. Try
try { nop } catch { nop } else { echo well }

OK, thanks! Yes, try-catch-else works.
Interestingly, try-finally-else does not work... but try-else-finally does. I guess finally really wants to be last, which makes sense.

Whether try-finally-else should work is debatable. Personally, I am opposed to allowing the clauses appear in every possible ordering. Why not finally-try-else? As long as the documentation is clear I have no objection to imposing an order on the clauses.


Rubocop 2020-12-05

Fix some RuboCop Lint, Style, Performance and Rails offenses, mostly using autocorrect.
Fix follow-on Codeclimate/Rubocop issues (many of which were new in master, but hidden from Codeclimate by .rubocop_todo.yml)

This is almost all straightforward, with much of it being auto-corrected (and then manually inspected).
I am most concerned with the changes to lib/tasks/jason.rake, in particular the change from if-elsif to case-when. See https://github.com/MushroomObserver/mushroom-observer/pull/719#discussion_r536946826 above.

Please delete jason.rake.  I'm so sorry you wasted time on it.  It's been
ages since I've used that, no idea what it even does. :(
On Sat, Dec 5, 2020 at 10:45 PM Joseph D. Cohen<EMAIL_ADDRESS>wrote:

This is almost all straightforward, with much of it being auto-corrected
(and then manually inspected).
I am most concerned with the changes to lib/tasks/jason.rake, in
particular the change from if-elsif to case-when. See #719 (comment)
https://github.com/MushroomObserver/mushroom-observer/pull/719#discussion_r536946826
above.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/719#issuecomment-739450239,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNPHDIXCF25DQDDZSSLSTL46JANCNFSM4UO5J6LQ
.

Thanks! And not a waste of my time. I learn, or reinforce, something with
each change.
I'll get rid of it.
On Sat, Dec 5, 2020 at 7:55 PM Jason Hollinger<EMAIL_ADDRESS>wrote:

Please delete jason.rake. I'm so sorry you wasted time on it. It's been
ages since I've used that, no idea what it even does. :(
On Sat, Dec 5, 2020 at 10:45 PM Joseph D. Cohen<EMAIL_ADDRESS>wrote:

This is almost all straightforward, with much of it being auto-corrected
(and then manually inspected).
I am most concerned with the changes to lib/tasks/jason.rake, in
particular the change from if-elsif to case-when. See #719 (comment)
<
https://github.com/MushroomObserver/mushroom-observer/pull/719#discussion_r536946826
above.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/MushroomObserver/mushroom-observer/pull/719#issuecomment-739450239
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAYTNNPHDIXCF25DQDDZSSLSTL46JANCNFSM4UO5J6LQ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/719#issuecomment-739450853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFGEEIHI3AGKP2LH5ZTSTL6C7ANCNFSM4UO5J6LQ
.


Simplify digit and letter count handling

Changes in This PR:

Simplify count_digits and count_letters
Use usize instead of i32
Evaluate count_digits and count_letters only if passed explicitly

Thanks for the PR!

Simplify count_digits and count_letters

This is much better!

Use usize instead of i32

Thanks! This made me do some studying, as I'm not very familiar with the best practices of which int type to use and when in rust. I stumbled upon this: https://github.com/rust-lang/book/blob/master/src/ch03-02-data-types.md#integer-types
If I understand correctly, it would imply that i32 or u32 should be used as the "generic number" type, in which case we should maybe do u32 here? Not sure at all what the de facto standard in the FOSS world is though...

Evaluate count_digits and count_letters only if passed explicitly

Here I would actually personally stick to the "no null values" style that is also used by Matcher.startswith, Matcher.contains etc. That is, in the comparisons they do, an empty string actually has a meaning (every string starts with an empty string), so a null value is not required. Similarly, every string contains at least 0 digits, so no null value is required.
If there is a performance hit we can ofc do if self.digits != 0 in the match_() func.

Thanks! This made me do some studying, as I'm not very familiar with the best practices of which int type to use and when in rust. I stumbled upon this: https://github.com/rust-lang/book/blob/master/src/ch03-02-data-types.md#integer-types
If I understand correctly, it would imply that i32 or u32 should be used as the "generic number" type, in which case we should maybe do u32 here? Not sure at all what the de facto standard in the FOSS world is though...

u32 sounds good, didn't know that its also the fastest on amd64 platforms. I think we could even get away with u8 since we only allowed up to a a maximum of 48 digits or letters. I chose usize in the beginning since its the default for collection enumerations.

If there is a performance hit we can ofc do if self.digits != 0 in the match_() func.

I'm personally for the self.digits != 0 check, since we would always count all digits and letters even if not required.
Thanks for reviewing, I pushed the changes

Perfect, thanks!


Set global variable in script that persists "globally"

i.e. the setting of the global variable in a script that will persist across stages.
This doc doesn't seem to mention the ability to do this, whether or not the possibility exists or not, and I really need this ability. If you could suggested workarounds that'd be great.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @juliakm
Microsoft Alias: jukullam

@ryanhagen -- Thanks for your question. It looks like you're working through an issue with your scenario or implementation.  You may find answers here:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@juliakm -- please look into this potential documentation issue.

@ryanhagen  You can set a global variable at the top of a YAML file. Let us know if the example in the variable scopes section doesn't answer your question - https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#variable-scopes.


Pattern: Box styles

Now there are box and links where box is ment to have anything in it. We then need to add some custom CSS to use it.
I think a nice thing would be to apply some default styles in there. Possible default styles:
Value pairs
Might be good for checklists, like SEO checklist or security checklist.
Headline1 - Information
Headline2 - Information
            More information about headline 2
Headline2 - Information

Sections
Might be good for larger more informational purposes.
Headline1
Information

Headline2
Information
More information about headline 2

Headline2
Information

Maybe this can be new elements inherit from infobox.

Added to the develop branch, documentation will follow. Best shown in the system element: https://github.com/distantnative/panel-bar/blob/develop/elements/system/system.php#L24-L60
Options to include in the box key array to use the template:

null: horizontal line
string: text that will be run through kirbytext()
key => value: presented as Key: Value
key => array: like key value, but with the array keys label, url, external


Cannot load "straight to hell" level

The level "Straight to hell" cant load and always says "failed to initiate level structure."

I am using a elevator panel to access the levels

could you post a log as well ? I can't do much with this alone unfortunately

While I was attempting to record an example and then put a log too, but for some odd reason it decided to work..
Idk


Hide file borders on sticky diff box

Before: (1px border left and right when scrolled to a file)

After: (no border)

Layout in the box does not shift with the changes.

make L-G-T-M work


May be logic error?

https://github.com/react-workspaces/create-react-app/blob/6fb31d7c943f3fc57b015b27dc600ada48ec7417/packages/react-scripts/config/yarn-workspaces.js#L115-L116

You're probably right, but I don't see it yet.
Any hints?


Feature Request: Timezone Tags

As a full-remote worker, I have teammates all over the world and I add all of their timezones to Hovrly.
It would be nice to know what people are in what timezones, so, in order to be more generic, maybe it would be nice to be able to add "Tags" to the timezones.
I, personally, would use people's names as such tags, but maybe other people would have more use cases for it.
Anyways, just an idea.

Renaming added in 2.4.4

Thanks, @tarutin !
So I guess tags are not really gonna be a thing? :(
In any case I can make do with renaming. Good job with hovrly, btw! 👏


Safari iOS Exceeded WebGL Texture Size

Thanks for open-sourcing this library. It works perfectly for me on desktop Safari and Chrome. But it doesn't work for me on either browsers for iPhone. On Safari, I get the following error when I try loading the face detector and landmark detectors:
Unhandled Promise Rejection: Error: Requested texture size [6321x16] greater than WebGL maximum on this browser / GPU [4096x4096] in 161.50cc6bac.chunk.js:13429
Would you know how to handle this issue? Thanks.

Actually, I can run the demo api on Ipad Safari, but it's very sluggish. I am wondering why is that so. I am wondering if a surface pro could do better since I want to use it on a tablet.


 Closing this ticket

Sorry for failing to follow up. Turned out, the problem was caused due to an old version of ObjectMapper. Thanks!


no more weird files

Codecov Report

Merging #363 into develop will increase coverage by 0.01%.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           develop     #363      +/-   ##
===========================================
+ Coverage    28.82%   28.83%   +0.01%
===========================================
  Files           57       57
  Lines         6263     6263
  Branches      1448     1450       +2
===========================================
+ Hits          1805     1806       +1
+ Misses        3178     3177       -1
  Partials      1280     1280

Flag
Coverage Δ

#rnvunittests
28.83% <42.85%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

packages/rnv/src/cli/index.js
57.55% <ø> (+0.81%)
:arrow_up:

packages/rnv/src/projectTools/projectParser.js
16.4% <0%> (ø)
:arrow_up:

packages/rnv/src/platformTools/electron/index.js
16.66% <0%> (ø)
:arrow_up:

packages/rnv/src/templateTools/index.js
23.03% <0%> (ø)
:arrow_up:

packages/rnv/src/configTools/configParser.js
45.13% <20%> (ø)
:arrow_up:

packages/rnv/src/pluginTools/index.js
18.64% <25%> (ø)
:arrow_up:

packages/rnv/src/config.js
17.08% <33.33%> (ø)
:arrow_up:

packages/rnv/src/platformTools/index.js
27.35% <33.33%> (-0.68%)
:arrow_down:

packages/rnv/src/projectTools/projectGenerator.js
34% <50%> (ø)
:arrow_up:

packages/rnv/src/deployTools/ftp.js
13.43% <50%> (ø)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3099784...a876f07. Read the comment docs.


Gallery shrine demo WillPopScope in ExpandingBottomSheet doesn't work!

I'd like to track this down. Can you provide a description of what's going wrong: how you're interacting with the demo, what you're seeing, what you expect to see, etc?

Step:

Open Gallery -> click "Studies" -> click "Shrine" -> click "NEXT" ;
Add some product into the cart;
Click the cart (at bottom) to expand the cart;
Click "Back" key(the "back" at Android Navigation bar)

result: the app back to the Studies page
expect: the app just collapse the cart, not leave the product page.

Thanks for explaining the problem. You're right: in this case the system back button should do the same thing as the app's back button (the down-arrow in the upper left-hand corner).

I took a look at this, and it seems the problem might be coming from the fact that the Shrine app is nested inside the Gallery app. Both the gallery and Shrine have their own Navigators. As a result, WillPopScope in Shrine is inside an inner navigator and is ignored.
I got the cart to close properly again by wrapping the MaterialApp in Shrine with a WillPopScope and adding a GlobalKey for the ExpandingBottomSheetState (see here). Does this look like a reasonable solution, or is there a way to do this without wrapping the MaterialApp with a WillPopScope?

Is the problem that the WillPopScope widget's callback unconditionally pops the outermost navigator? Maybe _onWillPop() in expanding_bottom_sheet.dart needs to be changed?

As far as I can tell, the callback isn't called at all.

Still the case in the latest version of gallery


Drop Function when Cascade is Too Destructive

Right now if you make a change to a function, it will drop that function on every single RLS policy that might use it. This is bad. We should revert this change.

I fixed this.


Colour picker: Input/buttons styling incorrect

Bug Description
The focus styles need to be updated for some of the buttons. Some focus styling is getting hidden (the focus styling is a box shadow so there needs to be some extra padding)
Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Hello @barklund I wanna work on this issue

Hey @Ayushsunny, sorry for the long delay in answering and thanks for the interest. You're more than welcome to work on this issue!

Verified in QA


core dumped when using tflite_convert

When I use tflite_convert to get a tflite model, it coredumps everytime.
 Thanks a lot

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

Please use export_tflite_ssd_graph.py as described in this [post](https://medium.com/tensorflow/training-and-serving-a-realtime-mobile-object-detector-in-30-minutes-with-cloud-tpus-b78971cf1193).

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

@huangxiao2008 What detection checkpoint did you start from? What platform did you try the conversion on? Please provide exact reproducible instructions.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Missing AuthenticationStatement with external provider

Hello,
we are using IdentityServer3 with the WS-Federation Plugin as a Claims Provider Trust for AD FS, AD FS acts as the SAML2 IDP for a Shibboleth-SP. Local login with username and password works fine. We've been trying to add an external authentication via AusweisApp2/nPa, but the resulting SAML2 delivered to the Shibboleth-SP is missing an AuthnStatement element and creating a Shibboleth session fails.
After some research I think the reason is that the necessary claims are only added in the SignInResponseGenerator if the AuthenticationMethod is "password", see line 180 in WsFederationPlugin\ResponseHandling\SignInResponseGenerator.cs:
if (validationResult.Subject.GetAuthenticationMethod() == Constants.AuthenticationMethods.Password)
    {

        mappedClaims.Add(new Claim(ClaimTypes.AuthenticationMethod, AuthenticationMethods.Password));
        mappedClaims.Add(AuthenticationInstantClaim.Now);

    }

Arbitrary values for ClaimTypes.AuthenticationMethod seem to trouble either AD FS or shibboleth, I would suggest AuthenticationMethods.Unspecified for anything not password:
if (validationResult.Subject.GetAuthenticationMethod() == Constants.AuthenticationMethods.Password)
{
    mappedClaims.Add(new Claim(ClaimTypes.AuthenticationMethod, AuthenticationMethods.Password));
}
else
{
    mappedClaims.Add(new Claim(ClaimTypes.AuthenticationMethod, AuthenticationMethods.Unspecified));
}
mappedClaims.Add(AuthenticationInstantClaim.Now);

yea that makes sense.
Another approach would be to implement what is proposed here
https://github.com/IdentityServer/IdentityServer3.WsFederation/pull/54
But as a quick fix we could add the "unspecified". Want to send a PR?

PR for a quick fix sent. Was there a specific reason to not create the claims for the AuthnStatement for non-password authentication methods?

merged - will release later.

Thanks!


feat(contrib): graceful shutdown for non-ceph nodes

This introduces the ability to handle the shutdown and cleanup of a nodes etcd member when the node is not running the Deis store components. Right now, if a node isnt a normal control plane node, the process cant happen.
It does so by making use of separate units for etcd and ceph graceful shutdown. This is because the systemd units need to Require different units - the Ceph stuff requires all the store stuff and needs to order itself after it while the etcd unit does not.
In the future, when this no longer experimental, we could remove the need for manual start up and enabling of the units by having etcd and/or the store units Want these units - therefore starting them they activate.
Another change is that these units make use of RefuseManualStop, which should make it significantly harder for someone to accidentally trigger the process.

The unit ordering needs some tweaking before this is ready.

@iancoffey can you modify the issue title to reflect that this is coping with isolated planes specifically WRT to graceful shutdown?

fixes #4554
fixes #4545

Could you change Feature(contrib) to feat(contrib) in the commit message? Otherwise this change won't be included properly in CHANGELOG.md.

@iancoffey Instead of creating 2 different services, could we instead put the deis-store components into a wants directive?

@aj-may I ran into a couple issues when trying to solve this with a single unit, neither of which seemed solvable.
One is that the shutdown unit will still need to have the store components listed in the After, and since they wont exist in a stateless platform or dataplane node, the unit will not execute the ExecStop. This is the behavior I observed, I never found a way to avoid that.
Another issue with a single unit is that once the graceful stop unit is enabled and started, Wants will attempt to start the services listed there, which would not be desirable in a stateless platform.
With two units, the main etcd and store units could Want their cleanup units and start them when they start. That was intended to be part 2 of this, once its been vetted.
It would be great to get your feedback on this approach, thanks much!

@mboersma Did you happen to test this manually with your LGTM? Code looks good, but I haven't had a chance to manually test it.

@carmstrong no, I just did a code review--it still needs a manual test. :hammer:

I tested removing a node from discovery url, booted a new node and the new node didn't add itself to the existing cluster. The steps are

set up a 3-node etcd cluster (node1, node2, node3)
remove node3 using etcdctl member remove
remove node3 from the discovery url using curl -X DELETE
stop node3 from AWS console
start a new one (I didn't use a deis cluster for this test so no autoscaling)

node4 used the discovery url, saw it's not full, but created a new etcd cluster with a new id. https://gist.github.com/crigor/d4d701aa1959cdd1d9fa#file-gistfile1-txt-L31-L34
This results in an error since node1 and nod2 already belong to a different etcd cluster.

@crigor Ive seen that issue as well and it is a bit unexpected. That said, we shouldn't be using the discovery url for adding or replacing nodes anyway - thats long existing a flaw in our provisioning setup. We should only be joining members correctly via the runtime reconfig process - like Deis Pro does. In that light, there is no utility to removing the node from the discovery service - it wont result in anything useful and it shouldn't have any impact on the future of the cluster. Im probably going to remove the discovery service deletion from this PR but would love to hear input if theres any.

@iancoffey +1 for not using discovery url for reconfig.  already got burned on that one.

This is all set to review now.

@iancoffey What's the motivation for changing the root Makefile? Will that break any of the providers?
Also, re: the discovery service, there is an implicit size passed in on creation (see https://github.com/deis/deis/blob/d830adf1e8d323ff37f23300661c543daebc632b/Makefile#L35). I believe this number is used to determine how many nodes should be core members (and the rest remaining as proxies).

I believe this number is used to determine how many nodes should be core members (and the rest remaining as proxies).

This seems to be the case. From https://coreos.com/os/docs/latest/cluster-discovery.html -

Third, if you specified ?size=3 upon discovery URL creation, any other machines that join the cluster in the future will automatically start as etcd proxies.

@carmstrong Good catch, the makefile change was needed when the node was being deleted from the discovery service. It shouldnt have had any negative impact but I removed that change.

That is one major issue with etcd discovery service.  If you start it up with 5 nodes and a size of 5 if you terminate 1 node at a time and allow for a new node to join it will always join as a proxy.  So after gracefully terminating 3 nodes your cluster will degrade and break.

@sstarcher see https://github.com/deis/deis/issues/4645#issuecomment-151955120 for an explanation on that subject.

@bacongobbler so the current solution after a few nodes degrade is to create an entirely new cluster to stop the old cluster from degrading and losing consensus?

Rebased, green, ready for manual testing.

@bacongobbler There was a discrepancy in that graceful-ceph-shutdown is incorrectly named graceful-deis-shutdown in the unit. I fixed that and rebased.

So here's how I tested (I missed the name change from deis to ceph but that's just visual):
$ deisctl install store-admin && deisctl start store-admin
$ vagrant ssh deis-01
$ sudo systemctl enable graceful-etcd-shutdown
$ sudo systemctl install graceful-etcd-shutdown
$ sudo systemctl enable graceful-deis-shutdown
$ sudo systemctl install graceful-deis-shutdown
$ sudo shutdown now

And here's what I end up with:
><> vagrant status
Current machine states:

deis-01                   poweroff (virtualbox)
deis-02                   running (virtualbox)
deis-03                   running (virtualbox)

This environment represents multiple VMs. The VMs are all listed
above with their current state. For more information about a specific
VM, run `vagrant status NAME`.
><> vs deis-02
Last login: Fri Dec  4 19:57:37 2015 from <IP_ADDRESS>
 * *    *   *****    ddddd   eeeeeee iiiiiii   ssss
*   *  * *  *   *     d   d   e    e    i     s    s
 * *  ***** *****     d    d  e         i    s
*****  * *    *       d     d e         i     s
*   * *   *  * *      d     d eee       i      sss
*****  * *  *****     d     d e         i         s
  *   *****  * *      d    d  e         i          s
 * *  *   * *   *     d   d   e    e    i    s    s
***** *****  * *     ddddd   eeeeeee iiiiiii  ssss

Welcome to Deis                 Powered by CoreOS
core@deis-02 ~ $ etcdctl cluster-health
member 48c35a6d2dd5edb4 is healthy: got healthy result from http://<IP_ADDRESS>:2379
member d41d2beaa8bf8eeb is healthy: got healthy result from http://<IP_ADDRESS>:2379
cluster is healthy
core@deis-02 ~ $ docker exec deis-store-admin ceph -s
    cluster 8305ad54-177a-4243-9ef0-2c56051c02f4
     health HEALTH_WARN
            768 pgs degraded
            761 pgs stuck unclean
            768 pgs undersized
            recovery 379/1134 objects degraded (33.422%)
            1/3 in osds are down
            1 mons down, quorum 1,2 deis-02,deis-03
     monmap e3: 3 mons at {deis-01=<IP_ADDRESS>:6789/0,deis-02=<IP_ADDRESS>:6789/0,deis-03=<IP_ADDRESS>:6789/0}
            election epoch 10, quorum 1,2 deis-02,deis-03
     mdsmap e7: 1/1/1 up {0=deis-03=up:active}, 1 up:standby
     osdmap e27: 3 osds: 2 up, 3 in
      pgmap v207: 768 pgs, 12 pools, 471 MB data, 378 objects
            21531 MB used, 23773 MB / 47831 MB avail
            379/1134 objects degraded (33.422%)
                 768 active+undersized+degraded
  client io 1939 B/s wr, 0 op/s

So it looks like etcd removed the node, but not ceph. :(

For what its worth, I tested this twice more and it was successful both times. One reason why @bacongobbler 's test might have failed could have been that ceph wasn't healthy to begin with. Which I tend to see one out of every 3 or 4 installs or so.
Not sure if this is totally tabled at this point, but it does seem to work for me. Maybe I just have the lucky touch!

I tested this again and it seemed to work for me. Since this is hidden behind a feature flag I think it's safe to consider adding to the LTS so users can opt into this and we can figure out why failure cases like this happened earlier.


feat: add history for cost models and set view table for latest models

Reason for this PR.
tl;dr: needed for TAP cost model checks
We currently have an issue where when a cost model just got updated  the indexer-service takes some time to update but in the meantime it errors out due to the model not matching, so we need to have a history in the db so that we can accept both, the new and the old one for a delimited amount of time (eg. ~2min)
This PR includes a breaking change:

CostModels table no longer exists
cost_models table is created, this will contain a history of all past cost models
CostModels table will keep working as a view from cost_models this way other programs that read into CostModels will keep working as they are, this view will contain only the latest model of each deployment thus not breaking anything else

looks good but let's get this in after we tag next release


License?

Hi,
what's the license for this project?
Can you please add one?
Otherwise I cannot use it.
Thanks!

its apache. updated. thanks :+1:

Great! Thank you!


text to appear at 1.0 line spacing

currently line spacing appears as every other line. edit style sheet if possible.

Not sure what you mean by this. Can you specify which page this occurs in please? or maybe post a screenshot.


Update readme.md to show 57 support

added 5.7 in description so users can try this without any doubt.

Duplicate https://github.com/HTMLMin/Laravel-HTMLMin/pull/122

Already updated


Twemoji icon missing in "Drag to rearrange"

Describe the bug
When a twemoji is set as the icon of a note, it is not visible in the rearrange icon of the editor. It does remove the default icon.
To Reproduce
Steps to reproduce the behavior:

Create a note.
Set (any) twemoji as its icon.
Open the file to see the missing icon.

Expected behavior
I expect to see the twemoji as the drag icon. It is a bug as the default "file" icon is removed.
Screenshots
Current behaviour.

Expected behaviour.

Additional context
The problem is here:
https://github.com/FlorianWoelki/obsidian-icon-folder/blob/a1541addf18954f9735281286a2a5e9b01b7d598/src/util.ts#L266-L269
When the icon is a twemoji the function returns an empty string and the icon is completely removed. I have already implemented a quick solution shown in the expected behaviour screenshot. Maybe is not the best one but works. If you are comfortable with me submitting a pull request let me know 😄.

Thanks for reporting!
Feel free to open a Pull Request for that :)


go-chromecast: Add version 0.3.1

go-chromecast is a nice CLI tool written in Golang to manage chromecast eligible devices (e.g. Smart-TVs, STBs, etc.)

[x] I have read the Contributing Guide.

/verify


The most basic hello world fails

iex(2)> url = "https://api.spacex.land/graphql/"
"https://api.spacex.land/graphql/"
iex(3)> GQL.query("query Launches { launches { id } }", url: url)
** (GQL.ConnectionError) %GQL.ConnectionError{reason: :nxdomain}
(gql 0.6.2) lib/gql.ex:123: GQL.query/2
iex:3: (file)
iex(3)>
this is running inside my dev container based on elixir:1.14.2-alpine

You're most basic hello world is using a domain name that doesn't resolve to anything, hence the :nxdomain error. I'll update the README (https://github.com/balexand/gql/issues/30).


1999 - Update repositories and adapt /etc/os-release to versioneer

Add missing /etc/os-release variables to work with versioneer
Fixes #1999
Replaces https://github.com/kairos-io/kairos/pull/2073

I can reproduce this failure locally: https://github.com/kairos-io/kairos/actions/runs/7276077385/job/19825149889?pr=2081
but I don't know what wrong yet.


Tests currently failing after -p change

The tests are now failing on main since the merge of the change of using -p for passwords on login.
@rubensprt FYI, these also fail locally so should be easy to test

Backed out the PR for now.


Numbering Styling Missing

Describe the bug
Numbering stylings are missing and it does not display numbering correctly
Expected behavior
Numbering is broken, so I checked the code and it doesn't have correct css class with them.
Either need the class naming to be correct on styling sheet or html code side
Screenshots

Desktop (please complete the following information):

OS: Mac OS
Browser Chrome

Would recommend to add sample of document.

No example document is provided,  closing.


Finish find command for meet ups

Added the logic for find command for meet ups, also edited and refactored some classes for neater structure

Looks good to me


TS1005 Error

error  in c:....\node_modules\kindred-api\typings\index.d.ts
[tsl] ERROR in c:....\node_modules\kindred-api\typings\index.d.ts(365,27)
TS1005: '(' expected.
I'm running nuxtjs and only accessing the kindred-api library from the backend. I'll fork and raise a PR for the fix

This is from latest NPM build in kindred-api

Ignore this, I'll pull kayn instead of kindred-api. Didn't realise it was it's replacement.

lmk if it's fine

Yeah sorry dude, was using the old kindred-api on npm. Upgraded to kayn now. Can close this


Endash tweaks

⚠ In case it isn't clear, this ticket is for bookmarking, documentation, and discussion. I anticipate cutting it up into multiple PRs for merge. ⚠
Big picture overview
The big thing is that plugins have been refactored to resemble adapter classes, and Booter, AutoRegistrar, et al each have a plugin that manages their integration with Container. The Booter, AutoRegistrar, Importer, and ManualRegistrar core classes have been refactored mostly to tighten up their encapsulation, a side effect of which is to make them container-agnostic (they all work with vanilla Dry::Containers.) Also there have been some nomenclature changes to avoid ambiguity around terms like "component," and some minor behavioral tweaks.
Nomenclature
There is currently an overlap in how terms are used, particularly "component." In general it seems to be meant as "an object registered on the container," but in the context of booting it usually, but not always, means an instance of Bootable registered on the Booter via Container#boot, which can register 0, 1, or more components, the names of which are not necessarily the same as the Bootable's identifier (i.e., there is no 1:1 correspondence between components and components. Read that second "components" with a goofily bad fake accent, like football and futbol.)
It can also mean "an object that will be registered on the container but has not yet been." More abstractly, it could mean "an object of some significance on which your app depends." It's confusing enough on its own, but I think there are also some subtle design consequences throughout the codebase, particularly in the interplay between Component and Bootable outside of the Booter.
I've cut through the Gordian knot by simply giving more specific terms for each use, or by eliminating the equivocation directly, via shifting responsibilities for the objects in question. The final result is that "component" only has its general, abstract meaning, usually just "some part of your app." There is no first-class "component" or Component entity.
Architecture
This has shifted from a mini-monolith (minilith? has anyone coined that yet?) to fully modular and plugin-based. There is already plugin support, of course, but I've made them first-class entities and shifted them to the core of the architecture.
Common, low-level classes

There are a few important low-level common classes. Provider and Identified (previously Bootable and Component, respectively) are more-or-less "dumb" configuration objects, and Loader now handles both requiring files and loading objects. Provider provides, via register, 0 or more components, and just stores the start, stop, init, hooks, config, and the rest of its definition as ivars. It is consumed by the Booter and is pretty much immediately wrapped in a Lifecycle, a combined FSM and provider DSL execution-context, that handles the mechanics of the boot process for an individual provider.
Identified reifies the notion of "some identifier yet to be registered on the container." It is just a decorator for an identifier, basically, with methods for turning it into a path, checking for existence, and applying/checking a namespace. Identifieds are created/consumed by autoregistration and by the Container pre-finalization, and are passed to plugins that have a #missing_key method.
Base

The core class is Base. Base is just Dry::Container plus really basic event hooks/triggers, a PluginsManager, and overridden configure/finalize methods to tie them together. By itself, it's a blank canvas, and incrementally adds functionality to Dry::Container.
Booter, AutoRegistrar, et al.

The Booter, AutoRegistrar, and Importer classes are where most of the magic happens. They've been promoted a rank and have had their encapsulation tightened up. Their core classes depend only on receiving an object with merge and register methods (i.e., a Dry::Container), plus a modicum of configuration they get provided directly.
Plugins

Plugins are first-class entities: they're long-lived objects that are initialized with access to the container, can have events triggered on them (after_configure, finalize, etc), and are responsible for providing any instance(s) of collaborators. They're adapters, essentially, mediating between the container on one hand and the Booter et al. on the other hand.
Plugins are installed directly into a container that descends from Base, via use. The global registry for handling plugin dependencies has been factored out, since the main benefit of such a scheme (implementation independence, dependency inversion, what-have-you) is arguably unrealizable without first-class interfaces, and everything ends up boiling down to a constant in the code anyway. Developers still ultimately need to be aware of a plugin's required registry identifiers and the interface that prerequisite is expected to meet, and then ensure that there is an appropriate plugin also registered, exacting a complexity cost even in the trivial situation where the dependency is built-in, like env. Better just to be aware that you have to use env, too, if you want to use foo.
I'm of a mind that the best design is to put the onus on developers working with plugins to simply be aware of the antecedents and consequences of a plugin. This is by way of saying that plugins should be simple, comprehensible, and easy to reason about, firstly to avoid hard-to-resolve bugs, and secondly to facilitate understanding of how the entire composed system functions. If a plugin requires the env plugin, then that's something the user should know about, understand, and take ownership of. Complex plugin graphs are to be avoided.
The flipside of that is when a complex plugin simply composes other plugins, as a convenience, in which case it can just install those sub-plugins itself. Again, though, this should remain simple enough that the plugin could be de-composed if needed. Composition, as opposed to a dependency, is a situation where indirection like a registry makes some sense, so that the composed plugin could be selectively overriden. IMO, though, it's better to just encourage simple designs and implementations, at the cost of a tiny bit more configuration code in a small minority of use cases.
As a side benefit, a plugin is now mostly just regular old ruby code, with any dependencies required at the top of the file, and a (mostly) PORO instance for encapsulating state and segregating the interface.
Whole enchilada

Practical changes in functionality
Bootables/Providers
The single biggest change in behavior is that Providers' (née Bootable) identifiers aren't assumed, at a low level, to correspond to keys on the Container. Because there isn't any guarantee or even necessarily any reason to believe that a Provider's identifier corresponds to a resolvable key, or vice versa, the Booter plugin is mostly treated as its own separate system.
However, all that said: In order to preserve the desired functionality of automatically booting Providers based on the need for a component they register, I've added a provides API for a Provider to specify what keys it intends to register once started. The Booter also gains #provide? and #provider_for methods, and any unresolved key will be tested against the Booter and any found Provider automatically started.
This works for any key in general, not just root keys. The flipside is that, at least as implemented, the matching provider is only started on an exact key match, so database.users won't start a Provider with the database identifier in Booter, but if it Injects database, then that key will start the :database provider (assuming the provider has provides :database in its definition.)
(edit: I'm writing acceptance tests and am seeing a lot of register_provider(:name) { provides :name }... and this has me thinking that provides maybe should default to the provider identifier, unless it is overridden. The logic would still function on the requirement that a provider knows before boot what keys it intends to register, but we'd shorthand that for the 80% use case where there is a 1:1 between provider name and registered key.
I think this also eliminates the utility of use, since you could just directly use the keys you expect to be there, and if there's a provider for them they'll be started implicitly. Is there a use case where you would want to ensure a provider has been started without caring about its keys or looking one up? I'm not sure one way or the other.
)
load_component implicit/lazy loading
I've just finished adding support to plugins for a missing_key hook, whereby plugins are sequentially given a chance to resolve a key that has been requested but does not yet exist on the component. This replaces the hardcoded logic to check the booter, load paths, importer, and so on. So, Booter::Plugin checks Booter to see if there's a provider that wants to provide that key, AutoRegistrar::Plugin checks to see if the file can be auto-registered, Importer::Plugin checks if the Identified's root key matches an imported container, and so on, until someone returns true or we run out of plugins. The fallback for trying the whole process a second time but with the Identified's namespace prepended to the identifier is still there in the container mixin.
Systems
If an object mixes in Dry::System::Mixin, then it gains a register_provider class method, and will be auto-registered into the Dry::System.systems hash.
Plugins
A plugin subclasses Dry::System::Plugin, which doesn't do much other than add identifier and reader settings to the class. A FooPlugin is installed into a container via Container.use(FooPlugin).
It is initialized with the container it is plugged into. In initialize, it can add settings to the container, extend it with a mixin, and so on.
If FooPlugin.reader (default: true) is not false, then the value (or the FooPlugin.identifier, if reader is true or nil) is automatically transformed into a reader method name. The reader method defined on the Container proxies to FooPlugin#instance.
If a FooPlugin.used class method is defined, then that'll be called as part of registering the plugin, before initialization.
Plugins are initialized at the top of #configure, and the PluginManager maintains the reference for the entire life of the app. They will respond to triggers/events if defined as instance methods, such as #after_configure.
Example: Booter
Booter is a reasonably complex example. First, it saves a reference to its container. Then it mixes in the Container#boot method. Mixins ideally should be kept simple with isolated methods that proxy to collaborators, instead of incorporating complex logic directly.
Finally, it pokes Dry::System to process any auto-registrations.
config.identifier = :booter

def initialize(container, config)
  @container = container

  container.send(:extend, Mixin)

  Dry::System.finalize!
end

It instantiates an actual Booter on demand, initializing it with the container and the registered systems of providers. This method will be hit whenever Container.booter is called.
def instance
  @instance ||= Booter.new(container, Dry::System.systems)
end

It listens for after_configure, which is special-cased to also pass along the final configuration. Then it requires all the boot files. These are not yet started, they're just registered on the Booter in an inert state. They won't get started automatically until finalization.
def after_configure(config)
  boot_path = config.root.join("#{config.system_dir}/boot")

  Dir["#{boot_path.to_s}/**/#{RB_GLOB}"].map do |path|
    require(path)
  end
end

Finally, it listens for finalize and shutdown events.
def finalize
  instance.finalize!
end

def shutdown
  instance.shutdown
end

Minor notes
I moved the pre-existing plugins (updated to the new API, with specs) to their own directory alongside system, alongside system_components. It feels like they should be segregated from the core library somehow, but I'm not really sure the best way to do that, so I just bumped them up a level for now. I don't feel all that strongly about this, but there you have it.
In updating the specs I've removed some where I couldn't immediately tell the utility, either because they were integration tests that appeared to duplicate unit specs, or they seemed to test certain code paths redundantly, or they tested imported code. I'm thinking it might be a good idea to add a third specs directory, whether acceptance or features or whatever, for specs to go that verify documented invariants without necessarily testing specific bits of code, so that if it's important to have specs for, say, Dry::AutoInject behavior as included in Dry::System that is otherwise off-the-shelf from the gem, then those can be kept separate from tests of classes in the repo. A separate suite gets the best of both worlds: the confidence garnered from all-encompassing, general acceptance specs, and also the usability of specs that can be traced directly to implementations.

I'm going to close this, because this so-called "refactor" has taken on a life of its own, at this point. I'm still optimistic that there are things I've been working on that could merge into the original repo, but at the same time I'm in the midst of validating a significant direction change and I want to do that without the continuity constraints.
Sometime this week I'll write up what I've been working on and post to the discussion forum, and if there's any interest we can figure out how what I've been working on can be reconciled with dry-system.
In the mean-time, I'm leaving this branch up and the "original" description of what this PR would have entailed (even though my thinking has changed quite a bit in the last few days) for reference, or if anyone might find anything in it useful... or just for future crow-eating.