Check proofs

Hi All, I received this e-mail this afternoon.  They've asked for a 2 day turn around, which I know is quick, but I'd like to stick to it.  I will make the requested changes.  I think we should submit one unified document so I think this final stage is best managed by you simply replying to this issue with the change you want.  Then I will go through and make all the requested changes by you all and PLOS, annotating them as they ask.  Thanks again all.
Full text
pcbi.1005097_CEtoAU.pdf
Dear Dr. Hart,
Your copyedited manuscript is now ready for review. In order to preserve the LaTeX formatting, it was typeset prior to copyediting, and thus copyediting changes have been marked in the PDF proof, attached to this email. Please take note of the comments addressed to "AU" and answer these queries throughout, and also add any additional changes using the Adobe markup and comment tools as needed. Please return the file to me via attachment to email when you have completed your review. This will be your last chance to make any changes before publication, so please review carefully.
We will need your response within 2 working days if possible.
See the end of this email for the following:

Instructions for reviewing the proof
Recommended checks on the proof

Please let me know if you have any questions or concerns.
All best,
Jennifer Fricker
PLOS Production

Instructions for Mark-up and Return of your Manuscript:
Important: Adobe Acrobat (Pro or Reader) is required for PDF proof markup. Adobe Acrobat Reader is available as a free download: http://get.adobe.com/reader/.

Only Adobe Acrobat Commenting Tools are accepted.
Use these three mark-up types whenever possible (Annotations tools in Comment menu):

Insert new content
Replace existing content
Delete existing content (strikethrough)
Sticky Note (for corrections concerning Figures only and to reply to AU queries)

To request replacement of figures or tables (only in cases of misleading scientific inaccuracies or printer's errors), use the Sticky Note tool to explain what corrections you have made to these objects. When you return your marked-up PDF to me via email, also attach replacement figures or tables as separate files. Note: please ensure that figure specifications remain the same as those in your accepted files.

Recommended Checks
This is the last time you will see your article before publication, so please review the proof carefully.
Please ensure that you review:

Title and running title
Author names and affiliations
Data in text
Data in tables
Figures and figure legends

I just went through the whole text, and don't have any other changes to make. The comments all seem helpful and quick to accept/reply to. Congrats to all; it's actually going to be a done thing!

I also took a quick look.  Nothing too onerous there.
WRT to the comment in the acknowledgements about me!  If we can I'd prefer to change author for me to Jeffrey W. Hollister.  Also we can switch JWH to J. Hollister to match the other names in the acknowledgments.
And this is fantastic that we all got this thing done!
So what is our next paper going to be?  :smile:

Looks good to me! For the broken Toy Story 2 link, I think it originally went to this video, but there are also news stories like this one that might be better to use.

Gah, sorry I missed this. Ted, I assume everything is good and there's nothing more for anyone to do?

@PBarmby All good, the paper is in production with the few edits Jeff and Kara suggested.  Closing because window for edits is closed.


add log page

Codecov Report

Merging #93 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   41.84%   41.31%   -0.54%
==========================================
  Files          17       17
  Lines        1288     1290       +2
==========================================
- Hits          539      533       -6
- Misses        680      687       +7
- Partials       69       70       +1

Flag
Coverage Δ

#unittests
41.31% <ø> (-0.54%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

executor/systemload.go
64.89% <0.00%> (-3.20%)
:arrow_down:

executor/executor.go
39.44% <0.00%> (-2.76%)
:arrow_down:

master/master.go
51.36% <0.00%> (-0.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de9467...c1638f2. Read the comment docs.


Plans to Support MI across AAD Tenants in the Future?

Hello,
My question relates to the following Q/A:
"Can I use a managed identity to access a resource in a different directory/tenant?
No. Managed identities do not currently support cross-directory scenarios."
Do you have any plans to support this in the future (if so, are you able to share a timeline)?
thanks,
Abby

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 278e03fb-2b4e-433f-ce17-206a48640c13
Version Independent ID: 88ca1250-9bdb-3b9f-6082-8f425f7bb2c9
Content: FAQs and known issues with managed identities for Azure resources
Content Source: articles/active-directory/managed-identities-azure-resources/known-issues.md
Service: active-directory
Sub-service: msi
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@amotley Thank you for your query. We will get this checked by the product engineering and update this thread in case there is any plans to make Managed identity cross-tenant compatible.

@amotley  We are still awaiting response from the backend team and will update this thread accordingly once we have an update . Thanks.

@amotley At this point the Managed Identity does not have cross domain capability and we do not have any plans for making it that way as of now . In case it is ever made it would have some privacy compliance and consent implications due to which the resulting solution would be exceedingly complex. We will close this issue now. I would suggest you to provide feedback on the Azure feedback forums so that Product group can prioritize it .
Thank you.

Thank you for the information - appreciate it!


Redis, the right way

Redis should be on its own container, and we to talk to it through the network. (There is almost certainly a redis container we could just use, instead of building it ourself in the the Dockerfile.) We'll need to figure out the management of multiple containers, though.

The obvious choice for managing multiple containers is docker-compose, but it doesn't support pulling layer caches.

Done: #41


remove ipAddress from RunSpec, introduce LegacyIpAddressSupport

Addresses an outstanding TODO: removes ipAddress from PodDefinition and therefore RunSpec

I don't like this or the other change with "Legacy" - please remove them from runSpec and move them to AppDefinition only.


panel drag to view doesn't memorized after restart

Version:
Version: 1.72.0-insider (Universal)
Commit: c4722f1bb292284e0437eb7547808a5788fe6430
Date: 2022-09-02T05:20:22.688Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes

https://user-images.githubusercontent.com/41773861/188167272-8aa5fbfc-cc63-423e-bfda-bc2ab5958324.mov

Seems had been fixed


Pick up organization name in GitHub multi-branch job

What feature do you want to see added?
After https://github.com/jenkinsci/github-branch-source-plugin/pull/527 , Jenkins can use GitHub app credential without organization settings, automatically picking up organization name inside repo.
But this is currently not supported in GitHub checks plugin.
I tried to implement it in https://github.com/jenkinsci/github-checks-plugin/pull/324 but failed, if anyone has similar need , you may pick up the pr and continue the work.
Upstream changes
No response

Hi. I'm facing the same issue as described here. @jglick can you provide some guidance as to how this plugin should be updated to take advantage of https://github.com/jenkinsci/github-branch-source-plugin/pull/527 and publish custom status checks without an owner field hardcoded in the Jenkins GitHub App credential?

You would need to call the API introduced in https://github.com/jenkinsci/credentials-plugin/pull/293, which means somehow identifying the build for which checks are being published.


Empty state placeholders

Everywhere a list of items is shown, show some empty state placeholder if the list is empty (and don't show it while the list is still loading).
It should:

take an ApiRequestStatus and a translation key as input
show an error if the list failed to load (using the api-request-status component)
Show something else if the list loaded but is empty https://material.io/guidelines/patterns/empty-states.html#empty-states-displaying-empty-states

Estimated time 5h

Issue migrated to our-city-app/plugin-mobicage-control-center#22


Failed to create cluster

Hi,
Running hypershift with OCP 4.13.1. With the latest version compiled hypershift  client, when I submit:
hypershift create cluster kubevirt --name $KUBEVIRT_CLUSTER_NAME --node-pool-replicas=2 --memory '8Gi' --pull-secret $PULL_SECRET --release-image=quay.io/openshift-release-dev/ocp-release@sha256:9c92b5ec203ee7f81626cc4e9f02086484056a76548961e5895916f136302b1f
I'm getting:
2023-06-07T16:15:05+03:00       INFO    Applied Kube resource   {"kind": "Namespace", "namespace": "", "name": "clusters"}
2023-06-07T16:15:05+03:00       INFO    Applied Kube resource   {"kind": "Secret", "namespace": "clusters", "name": "kv1-pull-secret"}
2023-06-07T16:15:05+03:00       INFO    Applied Kube resource   {"kind": "", "namespace": "clusters", "name": "kv1"}
2023-06-07T16:15:05+03:00       INFO    Applied Kube resource   {"kind": "Secret", "namespace": "clusters", "name": "kv1-etcd-encryption-key"}
2023-06-07T16:15:05+03:00       ERROR   Failed to create cluster        {"error": "failed to apply object "clusters/kv1": failed to create typed patch object (clusters/kv1; hypershift.openshift.io/v1beta1, Kind=NodePool): .spec.arch: field not declared in schema"}
github.com/spf13/cobra.(*Command).execute
/go/hypershift/vendor/github.com/spf13/cobra/command.go:916
github.com/spf13/cobra.(*Command).ExecuteC
/go/hypershift/vendor/github.com/spf13/cobra/command.go:1044
github.com/spf13/cobra.(*Command).Execute
/go/hypershift/vendor/github.com/spf13/cobra/command.go:968
github.com/spf13/cobra.(*Command).ExecuteContext
/go/hypershift/vendor/github.com/spf13/cobra/command.go:961
main.main
/go/hypershift/main.go:70
runtime.main
/usr/local/go/src/runtime/proc.go:250
Error: failed to apply object "clusters/kv1": failed to create typed patch object (clusters/kv1; hypershift.openshift.io/v1beta1, Kind=NodePool): .spec.arch: field not declared in schema
failed to apply object "clusters/kv1": failed to create typed patch object (clusters/kv1; hypershift.openshift.io/v1beta1, Kind=NodePool): .spec.arch: field not declared in schema
The pods are getting up in the clusters-$KUBEVIRT_CLUSTER_NAME project.
Somehow, followed this guidance getting things up in OpenShift ->  https://cloud.redhat.com/blog/effortlessly-and-efficiently-provision-openshift-clusters-with-openshift-virtualization
Will you please guide m?
Thanks

Just got back to release-4.13 version for hypershift and seems it's working..
fyi.

I had the same issue. As a workaround, I passed --render and saved the manifests to a file, then removed the .spec.arch from NodePool manifest. And it worked.
Hypershift CLI version:
openshift/hypershift: 7b7089020d494a8cdd4d10645df7adcbeef48941. Latest supported OCP: 4.14.0

OpenShift cluster version: 4.13.4

@aabouzaid could you give the steps and commands that you took to make this work please, if you still remember? I'm having a hell of a time hitting this constantly.

@alcamie101 just use the same command and add --render (it's like helm template or kubectl dry-run), then save the output in a file and remove that key (you can also use jq to remove it on the fly).


Action items overlapping with each other

RN 0.39.2

Anyone else facing this issue?

The reason for this seems to be compatibility with the newer RN version. Downgrading resolved it.
Any ideas @mastermoo ?

You can set the spacing prop in ActionButton to say.. 70 or higher, that should fix it for now.
<ActionButton buttonColor="#8BFE6B"  buttonTextColor="#7b2d30" spacing={70}>

is this happening in all versions above 39.2?

With Android<EMAIL_ADDRESS>and<EMAIL_ADDRESS>the ActionButtonItems don't even show up. The overlay is visible, but the action items are not. I tried to check with the inspector, couldn't see if they are rendering.
FYI, the same code was working fine on an earlier version of RN - so most likely it is about some incompatibility with a the new RN version.

https://github.com/mastermoo/react-native-action-button/pull/131
This PR solve this issue. It was the breaking changes in React Native 0.39.0
Here is the link in RN 0.39.0 https://github.com/facebook/react-native/wiki/Breaking-Changes#039

Thanks, will check it out.
Does this fix the iOS overlap bug too for which @rdeift suggested a workaround?

@prithsharma it's an android issue. this bug doesn't affect iOS. Check out v2.0.21. Hope it's fixed now


Write logs to Azure Share

=
NLog version: (4.9.0) (net core project)
Platform: .NET Core 2.2
Current NLog config (xml or C#, if relevant)
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      internalLogLevel="info"
      internalLogFile="\\k8sdiag634.file.core.chinacloudapi.cn\share\AIService\log\internal-nlog.log">

  <!-- the targets to write to -->
  <targets>
    <!-- write logs to file  -->
    <target xsi:type="File" name="allfile" fileName="\\k8sdiag634.file.core.chinacloudapi.cn\share\AIService\log\nlog-all-${shortdate}.log"
            layout="${longdate}|${event-properties:item=EventId.Id}|${uppercase:${level}}|${logger}|${message} ${exception}" />

    <!-- another file log, only own logs. Uses some ASP.NET core renderers -->
    <target xsi:type="File" name="ownFile-web" fileName="\\k8sdiag634.file.core.chinacloudapi.cn\share\AIService\log\nlog-own-${shortdate}.log"
            layout="${longdate}|${event-properties:item=EventId.Id}|${uppercase:${level}}|${logger}|${message} ${exception}|url: ${aspnet-request-url}|action: ${aspnet-mvc-action}" />

    <!-- write to the void aka just remove -->
    <target xsi:type="Null" name="blackhole" />
  </targets>

  <!-- rules to map from logger name to target -->
  <rules>
    <!--All logs, including from Microsoft-->
    <logger name="*" minlevel="Trace" writeTo="allfile" />

    <!--Skip Microsoft logs and so log only own logs-->
    <logger name="Microsoft.*" minlevel="Trace" writeTo="blackhole" final="true" />
    <logger name="*" minlevel="Trace" writeTo="ownFile-web" />
  </rules>
</nlog>

What is the current result?
Unable to write to shared NAS （aliyun can write and also NAS shared storage）
What is the expected result?
How to write？？？
Did you checked the Internal log?
yes   ExMessage: Could not create directory Z:\share\AIService\log or  path to the configuration file above

2020-03-10 14:45:57.1339 Error FileTarget(Name=allfile): Failed write to file 'Z:\test\nlog-all-2020-03-10.log'. Exception: NLog.NLogRuntimeException: Could not create directory Z:\test
at NLog.Internal.FileAppenders.BaseFileAppender.CreateFileStream(Boolean allowFileSharedWriting)
at NLog.Internal.FileAppenders.RetryingMultiProcessFileAppender.Write(Byte[] bytes, Int32 offset, Int32 count)
at NLog.Targets.FileTarget.WriteToFile(String fileName, ArraySegment`1 bytes, Boolean initializedNewFile)
this stack

Well the FilePath resolves into this filename:

Z:\test\nlog-all-2020-03-10.log

And the path Z:\test does not exists, and NLog receives an exception when automatically trying to create the directory. Guess you application does not have enough rights.
Have you considered just using Azure BlobStorage ?

I don't want to write the blob but I write to 'k8sdiag634.file.core.chinacloudapi.cn' nas file storage
Before aliyun (also a cloud service vendor) it was writable
Then I wrote a simple example program. I tried to write the directory and file to 'Z: \ test \ 1.txt' so that it can be written.
I checked the nlog source code's writing path and file code as I wrote, but nlog did not create the path and write to the log
Make me confused

If I want to write to any file system in Azure, such as Blog or File Share or Table, do I need to add the AzureBlobStorage package?

<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      internalLogLevel="info"
      internalLogFile="\\1436f49388-pvv34.cn-beijing.nas.aliyuncs.com\myshare\logs\AI_JD\internal-nlog.log">

  <!-- the targets to write to -->
  <targets>
    <!-- write logs to file  -->
    <target xsi:type="File" name="allfile" fileName="\\1436f49388-pvv34.cn-beijing.nas.aliyuncs.com\myshare\logs\AI_JD\logs\nlog-all-${shortdate}.log"
            layout="${longdate}|${event-properties:item=EventId.Id}|${uppercase:${level}}|${logger}|${message} ${exception}" />

    <!-- another file log, only own logs. Uses some ASP.NET core renderers -->
    <target xsi:type="File" name="ownFile-web" fileName="\\1436f49388-pvv34.cn-beijing.nas.aliyuncs.com\myshare\logs\AI_JD\logs\nlog-own-${shortdate}.log"
            layout="${longdate}|${event-properties:item=EventId.Id}|${uppercase:${level}}|${logger}|${message} ${exception}|url: ${aspnet-request-url}|action: ${aspnet-mvc-action}" />

    <!-- write to the void aka just remove -->
    <target xsi:type="Null" name="blackhole" />
  </targets>

This is a NAS server that successfully writes logs, but it is for the aliyu platform

So NLog is working is one environment, but not in another environment.
Sounds like an environment issue, or invalid configuration for that environment.
Sounds like you should contact the people that are responsible for providing support for this environment, and ask those experts for help about your issue.

goog


Error on fetch for angular2-indexeddb.js

I use this seed for starter project. https://github.com/vyakymenko/angular2-seed-express
but i stuck with configuration of indexdb on production build it get Error on fetch for angular2-indexeddb.js.
i cant understand how to solve this, could u please help me out.....
error:-
[18:45:25] 'build.bundles.app' errored after 2.82 s
[18:45:25] Error on fetch for angular2-indexeddb.js at file:///home/node_modules/angular2-indexeddb.js
Loading dist/tmp_client/app//db-service/db.service.js
Loading dist/tmp_client/app/app.module.js
Loading dist/tmp_client/app/main.js
Error: ENOENT: no such file or directory, open '/home/node_modules/angular2-indexeddb.js'
at Error (native)
[18:45:25] 'build.prod' errored after 33 s
[18:45:25] Error in plugin 'run-sequence(build.bundles.app)'
Message:
Error on fetch for angular2-indexeddb.js at file:///home/node_modules/angular2-indexeddb.js
Loading dist/tmp_client/app/qeasily/framework/db-service/db.service.js
Loading dist/tmp_client/app/app.module.js
Loading dist/tmp_client/app/main.js
ENOENT: no such file or directory, open '/home/node_modules/angular2-indexeddb.js'
Details:
originalErr: Error: ENOENT: no such file or directory, open '/home/node_modules/angular2-indexeddb.js'
Stack:
Error on fetch for angular2-indexeddb.js at file:///home/chetan/node_modules/angular2-indexeddb.js
Loading dist/tmp_client/app/framework/db-service/db.service.js
Loading dist/tmp_client/app/app.module.js
Loading dist/tmp_client/app/main.js
Error: ENOENT: no such file or directory, open '/home/chetan/node_modules/angular2-indexeddb.js'
at Error (native)

Hi @ghatul,
From the error I see in the stack trace you provided your bundler (which is part of your build) tries to get the angular2-indexeddb.js from the node_modules folder. When you install the library it should be under node_modules/angular2-indexeddb and this is why the bundler doesn't find it. Please check the bundler code to see why it tries to fetch the file not from its location.


Use tencent/ncnn master.

The latest master as of today, 2024.03.05, is
https://github.com/Tencent/ncnn/commit/964ed7a56a573c5046cc177a6cd95580ecddcddf
We will update it periodically.


EnableBinding - customise values of @Input and @Output

I wanted to understand if I changed the names for all the bindings in my application e.g
interface MyBindings {
         String CUSTOM_1 = "custom1";

        String CUSTOM_2 = "custom2";

        @Input(CUSTOM_1)
        SubscribableChannel custom1();

        @Input(CUSTOM_2)
        SubscribableChannel custom1();
}

Is it good practice to have all the bindings held in one interface? For example, If I had a component that was acting as a Sink:
@EnableBindings(MyBindings.class)
class MySink {

  @StreamListener(MyBindings. CUSTOM_1)
    public void doSomething(final MyPayload myPayload) {
        ...
        ...
    }
}

If I'm only using one of the bindings i.e CUSTOM_1 in the Sink above, is there any overhead calling `@EnableBindings(MyBindings.class)` ? Does it allocate resources to all the bindings, including the ones you don't need in the component?

@gurpiarbassi next time when asking question please use appropriate Stack Overflow channel. This issue tracker is used and/or monitored for questions.
Also, note that we are moving away from the annotation model you are describing. Find more details here


Create recomputeViewableItems method

Description
Adds recomputeViewableItems method to FlashList. Useful to imperatively trigger viewability calculations.
Reviewers’ hat-rack :tophat:

[ ] Validate that calling the recomputeViewableItems method triggers the onViewableItemsChanged callback.

Checklist

[x] I have added a changelog entry following the Keep a Changelog guidelines.

I sumbited a PR  here


To Do App Review

Hello @MahdiSohaily ,👋🏾
having carefully reviewed your code, we found it excellent and well-organized.
Several highlights include: 🎯

No Linters error.
Good usage of HTML semantic elements.
Good git flow control.

Here are a few tips to improve your code even:

Adding a button to the Task on the mobile version will be more intuitive and user friendly.

Cheers and happy coding! 😎

Thanks, dear @julzedz for your helpful feedback.
I will consider that.


< and > from imported markdown files display as < and >

The gallery does not display angle brackets in code blocks correctly in the package's documentation section comes from importing a markdown README file.
Repro

Edit a package. E.g. https://www.nuget.org/packages/Yarn.MSBuild/1.0.1/Edit
Add this URL to the "Import Readme" => "URL" box: https://raw.githubusercontent.com/natemcmaster/Yarn.MSBuild/v1.0.1/README.md. This file contains this section

**Package Manager Console in Visual Studio**
```
PM> Install-Package Yarn.MSBuild
```

Expected result

Actual result
It displays brackets as > and <

Linking the feature https://github.com/NuGet/NuGetGallery/issues/2280

Thanks!

Still doesn't work in inlined code segments with ` (i.e. `Hamster<T>` => Hamster<T>)
For example: https://www.nuget.org/packages/AsyncUtilities/0.5.0#

Screenshot of the inline code issue:

Hmm.. Looks like we fixed it for the code blocks but not for inline code.

Thanks for reporting this. I've opened a separate issue (#4946) to track this.

@chenriksson  Looks like we were working in parallel ;). I created https://github.com/NuGet/NuGetGallery/issues/4947


Add the composer.json and composer.lock file to the .phar file.

Type: feature
Issue: Resolves #1056
Breaking change: no
This PR adds the composer.json and the composer.lock file used during the creation of the phar.

Working 👌


Clarify helloworld config sockets comment

I found the updated wording to better match what the code does. I was a little worried at first that I had to listen on a socket.

I have read the CLA Document and I hereby sign the CLA.
recheck

I have read the CLA Document and I hereby sign the CLA

recheck


Status Handling

And some other bugfixes. Pretty basic in terms of status state tracking so far, but it should eliminate some common pitfalls with forgetting to set up topics and TF frames and whatnot.

I'm not sure if it makes sense to add the global status check since the icons are typically more visible than rviz visualizer tabs are so it should be easier to tell at a glance anyway. There's also a matter of the rosbridge status widget which does this in its own way and remains so, but that one needs a complete rework at some point.

Added some some critical fixes regarding image to data url fetching, and an experimental pointcloud renderer that's really inefficient but should work:


Flag for changing high pass filter for compcor

What would you like to see added in fMRIPrep?
Hi,
Thank you for all the work you've done on fMRIprep so far!
I was wondering if you could add a flag to set a custom high pass filter prior to the compcor calculations.
I have a task where I would like to use the compcor regressors, but I need a longer high pass filter than the default of 128 sec.
Thank you.
Do you have any interest in helping implement the feature?
Yes, but I would need guidance
Additional information / screenshots
No response

You want to preserve signals <.0078Hz? Could you explain your use case a bit more?

Hi,
I have a nested design, where I am modelling individual decisions that are part of a set of related decisions. I have included an example of a design matrix for one run (participants do 4 runs overall).
Within each trial (6 trials per run), participants make 9 decisions which I expect to influence each other over time. Based on this I think I need to use a high pass filter that won't filter out the increase in the effect of interest over the course of the trial. My understanding is that I need something at least 2x or 3x the longest trial for the high pass filter. So in this case, the longest trial is ~152sec, which is longer than the 128 sec default, so I need a high pass filter that is ~304sec (0.0032 Hz) or ~456sec (0.0022Hz). However, I am open to other suggestions. Thanks!
Brandon

Okay. So I think that you can probably get away with using CompCor components that were constructed with a 128s high-pass cutoff.
The effect of high-pass filtering BOLD series before calculating confounds is so that the confounds will not have low-frequency components in them. Therefore, low-frequency components in your data should not be removed by the confounds we generate. You can now choose to create a different cosine basis with a higher high-pass cutoff, which will simply remove the higher-frequency cosines from your design matrix. All that will happen is that the CompCor components will not contain signals in the 304s-128s band, so you won't be removing that.
I would give it a shot this way. You can also try running a modified version of fMRIPrep where you add a high_pass_cutoff argument to these three nodes:
https://github.com/nipreps/fmriprep/blob/d14b81141303114a465d4364ec3962d88cedd4be/fmriprep/workflows/bold/confounds.py#L285-L328
If you see a significant difference, we can think about adding a flag to tweak this parameter.

OK. I will give that a shot.
Do I still have to also use the cosine functions generated by fmriprep as a regressor in addition to the new high-pass filter?
My understanding is that the cosine functions just apply the high-pass filter to the data, which is why the fmriprep documentation says you should include them if you use compcor. But if I am using a different high-pass filter, via SPM, then theoretically I don't need the cosine functions from fmriprep anymore. Is that accurate? Or is there some other reason to continue to include the cosine functions, even with the SPM high pass filter?

Just a quick secondary note, your regressor actually looks like the signal of interest is high frequency.  The rule of thumb assumes your convolved regressors look like long blocks and yours do not since the different decisions (components of the trial) appear to have some fixation between them.  The concern is whether there's a collinearity between your model (more specifically the contrasts you're interested in) driven by the cosine basis set that is used.  If I'm designing a study or if I've just set up some design matrices for new data, I check the VIF of the contrasts to be sure we are okay, since it is far more complete than looking at pairwise regressor correlations to check for collinearity.  I wrote some code for this here https://github.com/jmumford/vif_contrasts

I don't have a strong argument for not using a different high-pass filter, but instinctively I would stick to a cosine basis (which should be nearly identical no matter who calculates it) to remain orthogonal to the CompCor regressors. Better statisticians than I (cough @jmumford) could probably tell you if there's anything to it or if I'm engaging in cargo cult stats.

Awesome. Sounds like you've got a good direction to go in, so I'm going to close this for now. If it turns out this is necessary for valid analysis, then we can revisit it.


CC56928 Fixed link

Hello, @Rick-Anderson ,
This proposed file change comes from https://github.com/aspnet/Docs.ru-ru/pull/19 .
Line #12
Could you review this contribution and help to merge if agreed?
Many thanks in advance.
When creating a new PR, please do the following and delete this template text:

Reference the issue number if there is one:
Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.

This is present: https://github.com/aspnet/Docs/blob/master/aspnetcore/tutorials/razor-pages/razor-pages-start/snapshot_sample/RazorPagesMovie/Models/MovieContext.cs
It's showing in the topic correctly and is apparently the correct code sample: https://docs.microsoft.com/en-us/aspnet/core/tutorials/razor-pages/model?view=aspnetcore-2.0#add-a-database-context-class

@gosali  @vadim-moskvin
The original code is correct.


Create dark mode option.

Lets create a dark mode toggle switch in the top right corner. It should add dark mode class in the body and based on which the background and text color should switch from light to dark theme.

Hi @jaideepghosh,
Hello, I would to love work on this, can you please assign to me?

Hey @yigitcukuren
I'm assigning this to you. Happy coding 🎉


Add support for dotnet 7

Currently only dotnet 5 and 6 are supported. I would love support for dotnet 7 :).

Npgsql throws an error when setting up the enum mappings:
(ctx.Connection :?> Npgsql.NpgsqlConnection).TypeMapper.MapEnum<ext.mood>("ext.mood") |> ignore

It says it's no longer supported. 😞

v1.1.0 is released with .NET 7 support. 🎉


Again the error of Russian localization

Everything is missing. Just nothing. =)
https://imgur.com/a/Vhsdd

Wut? As in everything is in English instead?

https://imgur.com/a/Vhsdd

Can you give me a bug report please? You can use Swatter or BugSack to capture it.
Side note: Oh man, I had exactly that UI several years ago. Such memories :)

1x BestInSlotRedux\Frames\FramesCore.lua:444: invalid option in format' [C]: in function format'
BestInSlotRedux\Frames\FramesCore.lua:444: in function <BestInSlotRedux\Frames\FramesCore.lua:433>
BestInSlotRedux\Frames\FramesCore.lua:899: in function ShowFrame' BestInSlotRedux\Frames\FramesCore.lua:906: in function ToggleFrame'
BestInSlotRedux\MiniMapLDB.lua:15: in function `OnClick'
...dOns\Bartender4\libs\LibDBIcon-1.0\LibDBIcon-1.0-34.lua:116: in function <...dOns\Bartender4\libs\LibDBIcon-1.0\LibDBIcon-1.0.lua:116>

Locals:
(*temporary) = "Создано %. В настоящее время разрабатывается %s."
(*temporary) = "|cffa330c9Beleria|r @ |cff4954e8Argent Dawn-EU|r"
(*temporary) = "|cfff58cbaAnhility|r @ |cff4954e8Ravencrest-EU|r"

2x BugSack\sack.lua:376: attempt to index local 'eo' (a nil value)
BugSack\sack.lua:376: in function <BugSack\sack.lua:374>
Locals:
eo = nil
(*temporary) =  defined @FrameXML\StaticPopup.lua:3856
(*temporary) = "BugSackSendBugs"
(*temporary) = nil
(*temporary) = "attempt to index local 'eo' (a nil value)"
currentSackContents =  {
1 =  {
}
}
currentErrorIndex = 0
window = BugSackFrame {
0 =
}

(*temporary) = "Создано %. В настоящее время разрабатывается %s."`` is missing an s after the first %. It's a string needed to render the base frame so it crashes the whole addon. I'll fix it immediately and push a new release. You can add it yourself in the locale\ruRU.lua` file if you need the addon to work right now.

You can throw off the finished file ruRU.lua here?

If you open the file, use notepad++ or something so you can see the line number.
Go to line 32 and after the L["Created by %s. Currently developed by %s."] = starts the encoded Russian characters. At the end of the first "sentence" should be a lonely %. Edit it to %s, save the file and start WoW again.

working. Thank you

Gonna push a new release now. Should be up on Curse soon.


Tab completion

See documentation file in this PR for more details

Just follow the instructions and it ran pretty fast on my computer (Mac), but I only see some keys. Is it normal?

I would say yes, it does not show you "all" keys for a given config. For some reason root settings are not there. Perhaps we should evaluate this feature more thoroughly to see whether it is really helps.

It is. I assume you expected to see all root parameters, right? We have no control on tab completion so if it is not providing useful completion - i guess we can reconsider whether we want to have this feature.

Im closing this down, as I dont think we currently benefit enough from tab completion.
Perhaps we can revisit this in the future, when tab completion is more ready from Hydra's side.


async emitOnce

Which @ngneat/elf-* package(s) are relevant/releated to the feature request?
@ngneat/elf
Description
emitOnce(() => ...) currently only supports synchronous actions.
Passing an async function that returns a promise, emitOnce will not wait until the function is resolved.
In our case, we have a fairly complex update method:

update the store synchronously
Do an HTTP call based on the change
Change the store again with the results from the call
Emit changes

Currently, this does not work as the changes are already emitted after step 1, because emitOnce does not await the callback.
Proposed solution
Provide a new emitOnceAsync function that only accepts callbacks that return Promises and awaits them before calling batchInProgress.next(false);
Alternatives considered
Adjust the existing emitOnce function to automatically handle promises internally if a promise is provided.
However this would probably be a breaking change in some apps, however it might be the expected behavior in the first place.
I am willing to provide a PR for both solutions.
Do you want to create a pull request?
Yes

The question is what happens if you update the state again afterwards.

If you'll update the store in any place afterwards it'll not be updated until your async operation is done.

I mean, yeah, that is kinda the whole idea :)

It seems risky to me, but I don't mind to see a PR as long as we mention this in the docs.

Cool, I will try to come up with something in the next few hours.

@NetanelBasal I really do not want to be impatient or annoying, but do you have an idea when you will release this feature? :)


Add new embed mode (Flutter UI output)

This is a continuation of https://github.com/dart-lang/dart-pad/pull/1761 by @tc, which I used as a starting point.
It adds a new embed mode with Flutter UI output only, with a new button "Show code" which hides the UI output and shows the code.
Fixes #1234

Preview
https://user-images.githubusercontent.com/67197047/121809723-3bf77f80-cc5e-11eb-9c11-c22643324659.mp4

@mzdm thanks so much for helping carry this to the finish line :)

@googlebot I consent

Love it

@RedBrogdon @johnpryan any thoughts about this approach?

@RedBrogdon @johnpryan here's diff between embed-flutter.html and embed-flutter_showcase.html files, for easier review https://www.diffchecker.com/5gvkMz4N

This looks great overall, thanks for creating a PR.  Here are some things that we should look at before we merge:

We should keep the toolbar the same, rather than moving buttons into the footer
The toolbar should be use $light-secondary-background-color (#f7f7f7)
the loading indicator is displayed above the Flutter app, maybe it should be moved to the lower section? Normally it is displayed above the toolbar.
The "Show solution" button is displayed above the UI Output when I load this gist - this should probably be displayed when the "Show code" button is pressed
The HTML and CSS tabs are unavailable when I load this gist - we might want to support HTML embeds too.

Thanks for the detailed description and images, that's helpful! I'll address it during upcoming days

@johnpryan

We should keep the toolbar the same, rather than moving buttons into the footer

The goal of this embed mode is to have the output as minimal as possible (for example on 200x200 embed), having controls on both toolbar and footer would make it a little bit cluttered in my opinion. Let me know what you think

The toolbar should be use $light-secondary-background-color (#f7f7f7)

Done

the loading indicator is displayed above the Flutter app, maybe it should be moved to the lower section? Normally it is displayed above the toolbar.

Ye, I noticed too. The tiny line was actually navbar, it's now hidden.

The "Show solution" button is displayed above the UI Output when I load this gist - this should probably be displayed when the "Show code" button is pressed

For some reason, UI output never loads for me in this embed mode (in flutter mode it works). The question maybe is whether it is needed to have there Solution tab, because the editor window is so small that it would be hard to make any edits here.

The HTML and CSS tabs are unavailable when I load this gist - we might want to support HTML embeds too.

As the embed mode suggests (flutter_showcase), it is meant to run Flutter code. flutter embed mode does not also support HTML embeds tabs. Wdyt?

Just FYI I have time like until the 10th of September, since then my time will be heavily limited and I will not have time to keep up with the conflicts... if there are things needed to be addressed, I would appreciate to do it asap 🙏

Any way we could make this truly a UI only output by hiding the toolbar/footer? Thank you for this PR!

@johnpryan any feedback for @mzdm ? it looks like all your comments were addressed for this PR to be merged?

Any way we could make this truly a UI only output by hiding the toolbar/footer? Thank you for this PR!

Interesting idea! I think something like showing the toolbar on hover/ or having some collapse button might be possible but I'm not HTML expert. :D Definitely open to this if this would be desired

I have a use case where I only want to show the output without any code. So maybe we can pass a bool in the url that hides everything except the output UI?

I have a use case where I only want to show the output without any code so having those toolbars is useless to me. Maybe we can somehow pass a bool in the url that hides everything except the output UI?

I see
it would be probably possible by adding a new param handling to https://github.com/dart-lang/dart-pad/blob/master/lib/util/query_params.dart something like toolbar with default to true. But this param would probably only make sense with this embed mode so I'm not sure how open to this would be @DartPad team

Dear God,
Please send someone to review this.
Thank you

Sorry, @mzdm @tc , I'm active here, but the code does need to be reviewed by @johnpryan who has more knowledge here.

closing since I have no time to keep up with the changes. If someone wants to take over, feel free to do in a new PR

Moved: https://github.com/dart-lang/dart-pad/pull/2178


Fix PHP 8.4 deprecation errors

Hi:
Implicitly nullable parameter declarations deprecated in PHP 8.4.
I don't know if it fixed all, but it fixed my tests.

Thanks!


Duplicate Tab not working

Version: 1.0.117
Platform: win32 10.0.18363
Plugins: altair, quick-cmds, save-output, scrollbar, title-control
When i open the ssh session with any server , And when i right click on any tab to duplicate tab it don't show me menu which have active ssh connection. But it shows the menu on an inactive tab

This is fixed in the nightly build.

I'm using 1.0.117, When i change the tab of color e.g to red other than default , it doesn't show menu, But when i revert it back to default it shows menu

Yes - it's fixed in the nightly build, which you can get here: https://ci.appveyor.com/project/Eugeny/terminus/build/artifacts


Train on multiple GPUs

The gpu is the bottleneck now

It looks like the fastai unet isn't compatible with DataParallel:

OK, DDP is working now :slightly_smiling_face:


feat: forest-tool command for measuring RPC completeness and compatibility

Summary of changes

Changes introduced in this pull request:

Add forest-tool api compare command for testing API compatibility.
Document how to add new RPC methods (and how to debug them).
Client-side support for ChainGetMessagesInTipset, StateMinerPower, Discover and Session.

Reference issue to close (if applicable)

Closes #3584
Other information and links

Change checklist

[ ] I have performed a self-review of my own code,
[ ] I have made corresponding changes to the documentation,
[ ] I have added tests that prove my fix is effective or that my feature works (if possible),
[ ] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

This PR is quite minimal. Further improvements are tracked here: https://github.com/ChainSafe/forest/issues/3641


Add Flip module

Adding a Flip module to imitate Expecto.Flip would be a nice-to-have feature.

Hello there @jwosty,
I haven't used used Flip before and looking at the docs, I am not sure I not I get what it is supposed to do 😅 can you briefly explain to me what the expected behavior is? Thanks!

To be honest, I am a little hesitant to supporting more Expecto constructs because I am not be able to properly support the Mocha API which has higher priority for this library

Sure, the Flip module just reorders arguments (nothing more than that) to make it a little nicer to use with the pipe operator. For example:
let actual = 2+2
let expected = 4
actual |> Expect.equal "2+2=4" expected

I've just written pretty much the whole thing for my own project since my tests were already using Flip, and this is what I came up with (you'll see this also references some of my own extension functions, like Fable.Mocha.Expect.sequenceEqual):
module Fable.Mocha.Flip
open Fable.Mocha

module Expect =
    let equal (msg: string) (expected: 'a) (actual: 'a) = Expect.equal actual expected msg
    let notEqual (msg: string) (expected: 'a) (actual: 'a) = Expect.notEqual actual expected msg
    let isTrue (msg: string) (actual: bool) = Expect.isTrue actual msg
    let isFalse (msg: string) (actual: bool) = Expect.isFalse actual msg
    let sequenceEqual (msg: string) (expected: 'a seq) (actual: 'a seq) =
        let actual' = Seq.toArray actual
        let expected' = Seq.toArray expected
        Expect.sequenceEqual actual' expected' msg
    let throws (msg: string) (f: unit -> unit) = Expect.throws f msg
    let throwsT<'TExn> (msg: string) (f: unit -> unit) = Expect.throwsT f msg

Thanks a lot for the explaination @jwosty. Unfortunately, I am afraid that this is one of those details of Expecto that I would rather not include in the library since it is very easy to add from user's point of view (including your workaround). I would like to keep the absolute minimum of support for Expecto's API so that it doesn't conflict with Mocha in the long run. (It is already very complicated to make tests behave well in all runners).

OK, thank you for the perspective. I appreciate it.

Thank you for the kind words and for understanding my reasoning :pray:


CSS-Grid g-row classes

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
I think there should be responsive classes to govern how much vertical space an element should take up within a CSS grid container as an analogue to the already existing g-col-* and g-*-col-* classes.
Motivation and context
I want to configure my styling such that below the md breakpoint I have this layout

and above it I have this

I am not aware of a currently working method that doesn't work via two separate blocks like this:

Red

Green

Blue

Red

Green

Blue

What I would like to be able to do is something akin to this:

Red

Green

Blue

https://github.com/twbs/bootstrap/discussions/35999 scss in Codepen example

Duplicate of #35737.


I-176 : Recalculate the SCOM value for Foo,MethodsWithDiffParamTypes …

…and OverloadMethods, remove puzzle #106
Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

You made a small amount of changes (less than 100 lines, less than 10 files)
You made changes related to only one bug (create separate PRs for separate problems)
You are ready to defend your changes (there will be a code review)
You don't touch what you don't understand
You ran the build locally and it passed

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html
Thank you for your contribution!

@yegor256/z please, pay attention to this pull request

@gauee/z this pull request is too small, just 7 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #265   +/-   ##
=========================================
  Coverage     74.88%   74.88%
  Complexity      173      173
=========================================
  Files            33       33
  Lines          1067     1067
  Branches         82       82
=========================================
  Hits            799      799
  Misses          235      235
  Partials         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7fe411...eb5f74b. Read the comment docs.

#176 is solved.

@rultor merge

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 14min)

@rultor merge

@gauee @paulodamaso The pull request is closed already, so I can't merge it

@rultor merge

@paulodamaso I'm sorry, I don't understand you :( Check this page and try again please

Job gh:yegor256/jpeek#265 is not assigned, can't get performer

This job is not in scope


Latvian keyboard double press letter change

Hey!
The latvian keyboard has a feature, I guess intended for physical keyboards: https://github.com/AnySoftKeyboard/LanguagePack/blob/Latvian/src/main/res/xml/qwerty_physical.xml
So this changes eg. ss so š. The problem is that latvian has many words with for example "ss", or other double letters. So when I am typing those words, eg. "ieeja", I get as result "iēja".
Is there any reason for this physical keyboard config to exist? Shouldn't physical keyboards include other keys which can be used to achieve those special letters?
I am for deleting the physical keyboard config.

Hi, thank you for your report and sorry for the slow response :-(
I understand your question and request, but I'm hesitant to just remove something like that. I guess there is probably a reason why it has been created in the first place and would like to understand that first before removing the file and breaking the workflow for somebody else...
@menny cacn you tell us, why this config exists? Obviously it came from the old SVN sources...

The cause is this: https://github.com/AnySoftKeyboard/LanguagePack/blob/Latvian/src/main/res/xml/qwerty.xml#L23
It seems that in the first request for this keyboard the users ask for this feature to be similar to the physical keyboard.
I'm okay with removing this for the default layout. Maybe creating another layout that has this multi-tap support? idk, you can decide.

Is this change abandoned? Any chance on implementation?


base_info = daemon_get_json("MinerGetBaseInfo", [miner_id, chainhead["result"]["Height"], tipsetkey])  返回None

Lotus has a bug when miner power is 0. Just wait 9Hours after you get a power > 0 and all we work

Thanks


fix/emptyDirs: Throw error for attempts to upload emptyDirs. MAID-2306

r? @krishnaIndia
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Intermittent Ouroboros/ChainDB error when syncing on Testnet

Issue:
Testnet nodes are intermittently crashing while syncing. When testing four nodes they crashed a total of 7 times in under an hour. There were no indications of memory issues in the process explorer while running these nodes. The error was:
cardano-node: ExceptionInLinkedThread "ThreadId 80" (ClosedDBError [("getEnvSTM",SrcLoc {srcLocPackage = "ouroboros-consensus-<IP_ADDRESS>-R0AVfeY78d7fCNQvHwSpA", srcLocModule = "Ouroboros.Storage.ChainDB.Impl", srcLocFile = "src/Ouroboros/Storage/ChainDB/Impl.hs", srcLocStartLine = 169, srcLocStartCol = 34, srcLocEndLine = 169, srcLocEndCol = 64})])
While most of the testing was completed on jlotoski/cardano-node-issue-461 I have also confirmed it occurs on Master.
This is a fatal error that crashes the node. Notably, this does not occur on Staging.
Steps to recreate:

Clone a node (or four, to speed up the process of having one crash as it's seemingly random)
Build with nix-build -A scripts.testnet.node
Run nodes

Thanks! I think I've been investigating similar exceptions in our test suite and am optimistic that I'll be able to address this relatively soon and simply.


brscan5's udev rule contains deprecated key "SYSFS"

Describe the bug
When using the hardware.sane.brscan5 option, the udev rule supplied by the upstream contains the deprecated key "SYSFS".
This cause systemd.udevd.service to fail.
Aug 04 19:57:29 carbon systemd-udevd[2092554]: /nix/store/dknjp9p11iwwjxqywhs8cpy9ss2gj0qs-udev-rules/49-brother-mfp-brscan5-1.0.2-2.rules:17 Invalid key 'SYSFS'.

Steps To Reproduce
Steps to reproduce the behavior:
First set
hardware.sane = {
  enable = true;
  brscan5.enable = true;
};

Then run
sudo systemd status systemd-udevd.service

Expected behavior
brscan5's udev rule shouldn't fail systemd-udevd.service.
Additional context
I did a quick grep on the latest (brscan5-1.3.5-0.amd64.deb) upstream package, the offending "SYSFS" key is still present. Maybe we need to patch this ourselves for now ?
Notify maintainers
@mattchrist

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.43, NixOS, 24.05 (Uakari), 24.05.20240730.cf05eea`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.21.4`
 - nixpkgs: `/nix/store/z3vrsz16ypv60m2pp0gi7x7gpx40gfh1-source`

Add a :+1: reaction to issues you find important.

I don't believe this is causing systemd-udev to fail, but does cause an error message in the logs.
On my system, systemctl status systemd-udevd shows the service is active (running). I do see those errors in the journal as well.

Thank you for your quick reply !
In fact, I noticed that when I run scanimage -L, my scanner isn't detected. However, running the same command with sudo works. I suspect that there might be something wrong with the udev file, I filed the bug report when I saw that it's not recognizing the SYSFS key.
Is it expected for scanimage -L to only work when run as root or is it somehow related to this issue ?
Thanks :)

You probably need the scanner and possibly lp group as stated in the desc for hardware.sane.enable


Update site stats

Update site statistics page:

Add Contributing Users to Site Stats
Display Contribution Users instead of Users
Add Sequences and Sequenced Observation to stats, and display them.

See Pivotal #175685466 for rationale.
Manual Test

Go too observer/show_site_stats
Result:

Delivers https://www.pivotaltracker.com/story/show/175685466.

Looks good to me, although all of the rubocopping does admittedly make it a bit challenging to find substantive changes in the haystack!  This is some extremely old code, and yes, it could undoubtedly be refactored dramatically.  I just don't think it makes the priority cut-off for any of us. :(  These pages are so rarely used.

Looks good to me, although all of the rubocopping does admittedly make it a bit challenging to find substantive changes in the haystack! This is some extremely old code, and yes, it could undoubtedly be refactored dramatically. I just don't think it makes the priority cut-off for any of us. :( These pages are so rarely used.

I appreciate your looking this over and digging through the haystack to find the needles.
It certainly is rarely used. I did it in response to an email thread triggered by an inquiry from Anne Pringle. I wanted to deal with it while it was still fresh in my mind.

Yes exactly, we are probably the most frequent users of that page! :)
On Tue, Nov 17, 2020 at 11:20 PM Joseph D. Cohen<EMAIL_ADDRESS>wrote:

Looks good to me, although all of the rubocopping does admittedly make it
a bit challenging to find substantive changes in the haystack! This is some
extremely old code, and yes, it could undoubtedly be refactored
dramatically. I just don't think it makes the priority cut-off for any of
us. :( These pages are so rarely used.
I appreciate your looking this over and digging through the haystack to
find the needles.
It certainly is rarely used. I did it in response to an email thread
triggered by an inquiry from Anne Pringle. I wanted to deal with it while
it was still fresh in my mind.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/709#issuecomment-729395489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNKCEERAZZAJSMBDVLLSQNDQPANCNFSM4TWJRRCA
.


fix(RefreshControl): fix SnackPlayer

Hi,
I just saw a warning when I opened the snack example, so I fixed it :)

Deploy preview for react-native processing.
Building with commit 10d4021ba51fe77d0ac818ce776bc3aeef751e56
https://app.netlify.com/sites/react-native/deploys/5e94115f14794900061affb9


Converted to CocoaPods Swift framework. Added demo project.

Updated readme with additional info. Updated location services to retain functionality of WhenInUse. Updated to Cocoapods Swift framework. Added example project.

Salaam, I've updated to Swift 2 and also fixed a bug that would avoid a retain cycle crash.

it has been a lot time but thanks @basememara :)


Added LoginView and updated DisplayMatchesView and updated LoginViewModel to fit with the new LoginView .

Great job! Please include Javadocs for each Class/ Interface!


scispacy doesn't mark end of entities correctly

This bug is based on the example here: https://spacy.io/usage/linguistic-features/
With spacy 2.3.5,
# This is what I recall how I installed
pip install -U pip setuptools wheel
pip install spacy==2.3.5
python -m spacy download en_core_web_sm

nlp = spacy.load("en_core_web_sm")
doc = nlp("San Francisco considers banning sidewalk delivery robots")
ents = [(e.text, e.start_char, e.end_char, e.label_) for e in doc.ents]
print(ents) ### Spacy and Scispacy differ on this
ent_san = [doc[0].text, doc[0].ent_iob_, doc[0].ent_type_]
ent_francisco = [doc[1].text, doc[1].ent_iob_, doc[1].ent_type_]
ent_considers = [doc[2].text, doc[2].ent_iob_, doc[2].ent_type_]
print(ent_san)  # ['San', 'B', 'GPE']
print(ent_francisco)  # ['Francisco', 'I', 'GPE']
print(ent_considers)  # ['considers', 'O', ''] ### Spacy and Scispacy differ on this

generates:
[('San Francisco', 0, 13, 'GPE')]
['San', 'B', 'GPE']
['Francisco', 'I', 'GPE']
['considers', 'O', '']

whereas scispacy 0.3.0
# This is what I recall how I installed
pip install scispacy==0.3.0
pip install https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.3.0/en_core_sci_sm-0.3.0.tar.gz

nlp = spacy.load('en_core_sci_sm')
doc = nlp("San Francisco considers banning sidewalk delivery robots")
ents = [(e.text, e.start_char, e.end_char, e.label_) for e in doc.ents]
print(ents) ### Spacy and Scispacy differ on this
ent_san = [doc[0].text, doc[0].ent_iob_, doc[0].ent_type_]
ent_francisco = [doc[1].text, doc[1].ent_iob_, doc[1].ent_type_]
ent_considers = [doc[2].text, doc[2].ent_iob_, doc[2].ent_type_]
print(ent_san)  # ['San', 'B', 'GPE']
print(ent_francisco)  # ['Francisco', 'I', 'GPE']
print(ent_considers)  # ['considers', 'O', ''] ### Spacy and Scispacy differ on this

generates stuff for considers which it shouldn't
[('San Francisco', 0, 13, 'ENTITY'), ('considers', 14, 23, 'ENTITY')]
['San', 'B', 'ENTITY']
['Francisco', 'I', 'ENTITY']
['considers', 'B', 'ENTITY']

also...  I don't. know if scispacy should be more specific for type of Entity for "San Francisco", but clearly marking considers as the beginning of an ENTITY is wrong.

The entity extractor in the core scispacy models is trained on the medmentions dataset (https://github.com/chanzuckerberg/MedMentions). This is a very different dataset from the one that the core spacy models are trained on, and will broadly recognize things that can be linked to UMLS (https://www.nlm.nih.gov/research/umls/index.html). This means it will identify seemingly generic terms likeconsiders. Depending on your use case, we have more specific NER models available (https://www.nlm.nih.gov/research/umls/index.html), or you may want to filter entities based on their UMLS type (type tree is here: https://ai2-s2-scispacy.s3-us-west-2.amazonaws.com/data/umls_semantic_type_tree.tsv)

Depending on your use case, we have more specific NER models available (https://github.com/allenai/scispacy#available-models)

I tried
pip install https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.3.0/en_core_sci_lg-0.3.0.tar.gz
and got worse (but different) results.  considers is no longer an entity but other non-entity words became entities
[('San Francisco', 0, 13, 'ENTITY'), ('banning', 24, 31, 'ENTITY'), ('sidewalk', 32, 40, 'ENTITY'), ('delivery', 41, 49, 'ENTITY')]
And for md model:
pip install https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.3.0/en_core_sci_md-0.3.0.tar.gz
[('San Francisco', 0, 13, 'ENTITY'), ('banning', 24, 31, 'ENTITY'), ('sidewalk', 32, 40, 'ENTITY'), ('delivery', 41, 49, 'ENTITY'), ('robots', 50, 56, 'ENTITY')]
What I was hoping for, was that scispacy would be better at picking out biomedical entities than spacy.

These are the "more specific NER models" I was referring to. They are each trained on a different biomedical corpus, and have different entity types.

As I said, the core models are trained on the medmentions dataset, which takes a broad definition for what is an entity (and there will be both obvious mistakes, and use case specific mistakes, as this is a trained model). Further filtering can be done using the entity linker and its types.
That being said, the core spacy models are not trained to recognize biomedical entities at all. Here is an example difference
In [27]: sm = spacy.load('en_core_web_sm')

In [28]: sci = spacy.load('en_core_sci_sm')

In [29]: sm_doc = sm("Deoxyribonucleic acid is a molecule composed of two polynucleotide chains that coil around each other to form a double helix carrying genetic instructions for the development, functioning, growth and reproduction of all known organi
    ...: sms and many viruses.")

In [30]: sci_doc = sci("Deoxyribonucleic acid is a molecule composed of two polynucleotide chains that coil around each other to form a double helix carrying genetic instructions for the development, functioning, growth and reproduction of all known orga
    ...: nisms and many viruses.")

In [31]: sm_doc.ents
Out[31]: (two,)

In [32]: sci_doc.ents
Out[32]:
(Deoxyribonucleic acid,
 molecule,
 polynucleotide chains,
 coil,
 double helix,
 genetic instructions,
 development,
 functioning,
 growth,
 reproduction,
 organisms,
 viruses)

These are the "more specific NER models" I was referring to. They are each trained on a different biomedical corpus, and have different entity types.

As I said, the core models are trained on the medmentions dataset, which takes a broad definition for what is an entity (and there will be both obvious mistakes, and use case specific mistakes, as this is a trained model). Further filtering can be done using the entity linker and its types.
That being said, the core spacy models are not trained to recognize biomedical entities at all. Here is an example difference
In [27]: sm = spacy.load('en_core_web_sm')

In [28]: sci = spacy.load('en_core_sci_sm')

In [29]: sm_doc = sm("Deoxyribonucleic acid is a molecule composed of two polynucleotide chains that coil around each other to form a double helix carrying genetic instructions for the development, functioning, growth and reproduction of all known organi
    ...: sms and many viruses.")

In [30]: sci_doc = sci("Deoxyribonucleic acid is a molecule composed of two polynucleotide chains that coil around each other to form a double helix carrying genetic instructions for the development, functioning, growth and reproduction of all known orga
    ...: nisms and many viruses.")

In [31]: sm_doc.ents
Out[31]: (two,)

In [32]: sci_doc.ents
Out[32]:
(Deoxyribonucleic acid,
 molecule,
 polynucleotide chains,
 coil,
 double helix,
 genetic instructions,
 development,
 functioning,
 growth,
 reproduction,
 organisms,
 viruses)

Hey @danielkingai2 Can I know how to train my own ner extractor on my own corpus from scratch? Basically, I want to train my own "more specific NER models" with my corpus. How do I proceed.. Any reference links that you can share?

we're using spacy 3's new config system and spacy projects. So our project file lives here and our configs live here. You should be able to follow these as a guide, an basically just run the ner training commands, but with your data.

getting this error  in pycharm whenever i try to download en_ner_bc5cdr_md
✘ No compatible package found for 'en_ner_bc5cdr_md' (spaCy v3.5.3)
python is 3.11


Looking for Interviewees

Hello!
I’m currently working on my bachelor’s thesis in “leader emergence in open source software projects“. For my research I’m looking for interviewees, preferably 2 people per OSS project: one person with some sort of leadership role and one “normal” project member.
The interviews will take place via Skype over the next couple of weeks and last around half an hour.
Feel free to forward this request to anyone who might be interested and do not hesitate to contact me with any questions you might have.
Thank you so much for your help!
Greetings from Munich,
Katy
PS: My e-mail is<EMAIL_ADDRESS>

Hi Katy,
I'm afraid I don't have the time for this. Also, I'm not sure this project would be a good fit - GitHub's contribution graph might help you https://github.com/benpickles/peity/graphs/contributors.
Good luck with the thesis, it sounds interesting.
Ben


Errors out when calling setup without any parameters

Describe the bug
The title.
To Reproduce
Steps to reproduce the behavior:

Put require("flatten").setup() in your config.

Expected behavior
It should just use the default config.
Additional context
Although using something like the opts table or config = true in lazy.nvim is recommended, I think it's better not to throw when there's no config table provided in setup.
NOTE: I'm just gonna open a PR to fix.

Thanks! I definitely should've been doing this, appreciate the fix.


misc: Update MAINTAINERS.yaml

Updates the list of current gem5 Maintainers.
Updates the MAINATAINERS.yaml comments to reflect gem5's contribution policy and maintainer responsibilities since moving to GitHub.
Updates the subsystem maintainers, based on maintainer's stated preferences.
Adds the optional 'expert' field to subsystems.

Generally, I would advocate for removing this file. I think it's a bit embarrassing how much of gem5 is "orphaned" according to this. It's also not really indicative of the current state. Almost anyone submitting improvements to these subsystems will get reviews. Though, the other way to look at it is that if anyone opened an issue in the "orphaned" components, it's likely that no one would be available to answer their question or fix their bug. So, in that sense, I guess they are orphaned.
Anyway, just some thoughts. No action needed.

@powerjg : I'm ok to merge this if you're comfortable giving it an approving review.


Review request for microsoft.support 2024-04-01

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE]
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

 Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

 Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

 Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Please complete PR description, purpose of PR, due diligence sections

      "description": "Enrollment Id associated with the support ticket.",

optional, is it?

Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:2466 in 33f65df. [](commit_id = 33f65df5bcd15bd8efadeaf17c728e6c06149819, deletion_comment = False)

      "description": "Size of each chunk",

in ... bytes??

Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:3027 in 33f65df. [](commit_id = 33f65df5bcd15bd8efadeaf17c728e6c06149819, deletion_comment = False)

      "description": "Size of the file to be uploaded",

in ... bytes??

Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:3032 in 33f65df. [](commit_id = 33f65df5bcd15bd8efadeaf17c728e6c06149819, deletion_comment = False)

}

Why not use the parameter definitions from common-types?
You currently seem to be getting linter errors like these, as a side effect or not doing so. Could you just fix this to use common types?

The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.Support/stable/2024-04-01/support.json#L3067

Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:3073 in 33f65df. [](commit_id = 33f65df5bcd15bd8efadeaf17c728e6c06149819, deletion_comment = False)

      "Checks whether name is available for SupportTicket resource": {

Linter says you have duplicate descriptions
'Checks whether name is available for SupportTicket resource'
This is a sign you need to improve your descriptions

Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:247 in 33f65df. [](commit_id = 33f65df5bcd15bd8efadeaf17c728e6c06149819, deletion_comment = False)

      "Checks whether name is available for SupportTicket resource": {

Linter says you have duplicate descriptions
'Checks whether name is available for SupportTicket resource'
This is a sign you need to improve your descriptions

Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:292 in 33f65df. [](commit_id = 33f65df5bcd15bd8efadeaf17c728e6c06149819, deletion_comment = False)

      "Checks whether name is available for SupportTicket resource": {

You also have a bunch more of these, see LintDiff output.

In reply to:<PHONE_NUMBER>

Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:292 in e344df5. [](commit_id = e344df5ec324be8cb924f8c14489b0c3c6eefc43, deletion_comment = False)

      "description": "Enrollment Id associated with the support ticket.",

optional, is it?
Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:2466 in 33f65df. [](commit_id = 33f65df, deletion_comment = False)

Yes, this is an optional property.

Size of each chunk

Current supported max chunk size is 2.5 mb. Max limit of int32 is 2147 MB which is way larger than the need, so kept it for int32

Please complete PR description, purpose of PR, due diligence sections

Updated

      "description": "Size of each chunk",

in ... bytes??
Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:3027 in 33f65df. [](commit_id = 33f65df, deletion_comment = False)

Updated the description

bytes?

Updated the swagger to use common types.

      "Checks whether name is available for SupportTicket resource": {

You also have a bunch more of these, see LintDiff output.
In reply to:<PHONE_NUMBER>
Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:292 in e344df5. [](commit_id = e344df5, deletion_comment = False)

Taken care of.

      "Checks whether name is available for SupportTicket resource": {

Linter says you have duplicate descriptions 'Checks whether name is available for SupportTicket resource'
This is a sign you need to improve your descriptions
Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:247 in 33f65df. [](commit_id = 33f65df, deletion_comment = False)

Taken care of

      "Checks whether name is available for SupportTicket resource": {

Linter says you have duplicate descriptions 'Checks whether name is available for SupportTicket resource'
This is a sign you need to improve your descriptions
Refers to: specification/support/resource-manager/Microsoft.Support/stable/2024-04-01/support.json:247 in 33f65df. [](commit_id = 33f65df, deletion_comment = False)

Taken care of

/pr RequestMerge


Remove references to "listify_batch"

The function "listify_batch" does not exist in "trl==0.0.3", and it will not be used later in this example

https://github.com/lvwerra/trl/issues/82


[4.1.0] Revamp 4.1.0 what has changed doc

Purpose
Fixes https://github.com/wso2/api-manager/issues/622 in 4.1.0
Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@msm1992 One thing to add to what has changed section, we will have improve the note where we tell custom JWT generator should be in Gateway. We should mention that, If they are using old JWT generator coming from 2.x versions (extending AbstractJWTGenerator), now the same should be added to Gateway not KM node.


Add how to installation

Add installation how-to (especially with respect to git lfs) to the docs.

This looks complete! Thanks @dfhahn!


Disable network activity indicator manager when UIApplication is not available

Fixes #228

Hi, @Narsail, this is great!
Since this fix means that useNetworkActivityIndicator effectively does nothing in the absence of UIApplication, I wonder whether the entire file should be wrapped in the #if instead of just the didSet? Then people won’t use useNetworkActivityIndicator and be confused when it does nothing; instead, a compile error will alert people that it’s not available.
What do you think? Does that make sense?
(I can imagine a future version of this code letting clients register their own hooks “requests are / are not now in progress”, but I’m all in favor of this much simpler fix until that magical future time.)

Good idea. I tried in in your suggested way and it is compiler friendly in my project. Seems to be working.

Looks good to me! Thanks!

You are welcome :)
Sent with GitHawk

Narsail: I’ve discovered that this PR does not in fact test for a Swift symbol named UIApplication, but rather tests for a compiler flag named UIApplication. That means that the #if always excludes this code. Oops!
I’ve reverted the commit on master for now, so that this doesn’t break existing projects. That means you’ll have to either locally reinstate your patch or point back at the previous commit that had it.
It looks like availability conditions to test for application extensions are coming in Swift 4.1, but are not available yet. If anybody knows a way to detect this in 4.0, let me know!

Huh, it looks like even with the new conditions available in Swift 4.1, it’s still not possible to conditionally compile code only if it’s not used in an app extension. Perhaps some hero out there will answer my Stack Overflow question.
I was able to get it working both in apps and in extensions by using this monstrous hack:
extension UIApplication
    {
    static var sharedIfAvailable: UIApplication?
        {
        let sharedApplicationSelector = Selector("shared" + "Application")
        guard UIApplication.responds(to: sharedApplicationSelector) else
            { return nil }
        return UIApplication.perform(sharedApplicationSelector)?.takeUnretainedValue() as? UIApplication
        }
    }

…but this bafflingly returns a UIApplication instance even in an app extension (!), and it’s a nasty enough hack that I’m not comfortable releasing it — at least not without further research.


Add GEC-only annotations

Background
Naively removing fluency edits may result in ungrammatical sentence. In
order to avoid that, annotators validated the whole corpus with the
fluency edits removed. They made edits to ensure that sentences stay
grammatical even after fluency is removed.
This branch contains the results of their work.
Files structure
The commit temporarily adds two folders.
results-gec-only.src contains snippets that were handed to annotators
for the gec-only annotation. These snippets are:

should contain all snippets added in v1 and v2
fluency annotations were removed
have no detailed annotations
have to fixes applied to v1 and v2 since the data collection

results-gec-only.tgt is the result of the annotators' work:

should fix errors introduced by removing fluency annotations
sometimes annotators make edits unrelated to fluency removal (seems like they were fixing random errors along the way)

Future work
These are subtasks for integrating GEC-only into the release:
[ ] Copy detailed annotations here
[ ] Integrate fixes made to the main corpus here
[ ] Backport some edits from GEC-only to the main corpus (where edits are bugfixes and are not related to fluency removal)
[ ] Check for missing snippets and fix it
[ ] Update docs and find a proper place for GEC-only

2022-08-09 Update
This PR is now ready to be merged. It integrates GEC-only annotation.
Files structure
The data files directories has been updated to the following structure:
data
├── gec-fluency
│   ├── test
│   │   ├── annotated
│   │   ├── source
│   │   ├── source-sentences
│   │   ├── source-sentences-tokenized
│   │   ├── target
│   │   ├── target-sentences
│   │   └── target-sentences-tokenized
│   └── train
│       ├── annotated
│       ├── source
│       ├── source-sentences
│       ├── source-sentences-tokenized
│       ├── target
│       ├── target-sentences
│       └── target-sentences-tokenized
└── gec-only
    ├── test
    │   ├── annotated
    │   ├── source
    │   ├── source-sentences
    │   ├── source-sentences-tokenized
    │   ├── target
    │   ├── target-sentences
    │   └── target-sentences-tokenized
    └── train
        ├── annotated
        ├── source
        ├── source-sentences
        ├── source-sentences-tokenized
        ├── target
        ├── target-sentences
        └── target-sentences-tokenized

Python package
ua_gec.Corpus now accepts the annotation_layer parameter that controls which annotations to use (gec-only or gec-fluency)
Stats
Statistics is now computed separately for each annotation layer.


Entry "Røttenest" is undetected

"Røttenest" in page 2387-røtte (rotte).txt is undetected, even though the OCR should be clear enough for regex match. See whats wrong.

Oddly enough this actually was already detected in master, unknown if I actually meant some other entry.


Visual Tree Bloated With ShapeVisual and Container Visual in UWP

Describe the bug
The Visual Studio Visual Tree is bloated with ShapeVisual and Container Visual, everytime I redirect into page.
Steps to reproduce the bug

Create project in WTS with navigation view
Add any Controls? (I just added CommandBar with FontIcons)

Expected behavior
Is this a memory leak, because after few times switching, the memory keep getting increased

Screenshots

Version Info

NuGet package version:
Microsoft.UI.Xaml 2.6.1

Windows app type:

UWP
Win32

Yes

Windows version
Saw the problem?

Insider Build (xxxxx)

21H1 (19043)
Yes

October 2020 Update (19042)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context

@rasyidf Is this a regression - i.e., if you downgrade to WinUI 2.5, does this stop reproing?  Would be useful to know to narrow down where the issue is.  Thanks!

I've using WinUI in my app since v2.2 ish. and the problem occured after updating to WinUI 2.6
and when I'm reverting back to winui 2.5, the problem is not exist anymore.

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Whoa, sorry I've just sent back home after getting treated at hospital, covid things.

There is a known reporting bug in the LiveVisualTree which causes the shape visuals to remain in the live visual tree even after they've been removed from the render tree.  There was a separate memory leak bug in the system associated with these visuals which has been fixed which is likely the cause of the increasing memory you are seeing. Unfortunately this slow leak is an OS level fix.


Minor cleanup of using Minimal API as a Windows Service code /2

@tothalexlaszlo please review

Get rid of nullable warning.
Use standard API.

It's cool 👍

@tothalexlaszlo thanks for the original sample and the review.


Oldtweetdeck suddenly stuck on loading screen

Old tweetdeck was working for me during the day but suddenly after my internet went out and back (in like 2-3 minutes), the site has been stuck in one big loading screen for hours. And now it is showing a new message on the loading screen. Version is the latest.

Still not working on Chrome for me but is working on Opera.


Abstract out schema to not be hardcoded inside the ETL pod

Currently you have to make a new image every time the schema changes because it is hard coded to the etl_pod image. If this link was abstracted to a config file and fed to the etl pod some other way this would be much easier to iterate on, ex:
https://github.com/ACED-IDP/aced_etl_pod/blob/main/etl-job/fhir_import_export.py#L185
Also in the event that an unknown node type is present in the data, the whole ETL pod hangs indefinitely. Should hit some sort of hard error.
Current output behavior:

[2023-12-12 19:05:23,443][   INFO] File _aced-OMOPTEST-20231212-110245_meta.zip downloaded successfully
Archive:  /tmp/087cfb16-dc9f-57dd-bdcd-26a17b2d9be0/_aced-OMOPTEST-20231212-110245_meta.zip
 extracting: /root/studies/OMOPTEST/DocumentReference.ndjson
 extracting: /root/studies/OMOPTEST/Observation.ndjson
 extracting: /root/studies/OMOPTEST/MedicationRequest.ndjson
 extracting: /root/studies/OMOPTEST/MedicationStatement.ndjson
 extracting: /root/studies/OMOPTEST/Patient.ndjson
studies/OMOPTEST/MedicationRequest.ndjson
INFO:iceberg_tools.util:studies/OMOPTEST/MedicationRequest.ndjson
medication_request.yaml not in schemas
INFO:iceberg_tools.data.simplifier:medication_request.yaml not in schemas
INFO:iceberg_tools.util:studies/OMOPTEST/DocumentReference.ndjson
studies/OMOPTEST/DocumentReference.ndjson
studies/OMOPTEST/Patient.ndjson
INFO:iceberg_tools.util:studies/OMOPTEST/Patient.ndjson
studies/OMOPTEST/Observation.ndjson
INFO:iceberg_tools.util:studies/OMOPTEST/Observation.ndjson
studies/OMOPTEST/MedicationStatement.ndjson
INFO:iceberg_tools.util:studies/OMOPTEST/MedicationStatement.ndjson
INFO:iceberg_tools.data.simplifier:medication_statement.yaml not in schemas
medication_statement.yaml not in schemas

@matthewpeterkort  Was this resolved? If all OK, please close issue.

@matthewpeterkort Was this resolved? If all OK, please close issue.

It was addressed here:
https://github.com/ACED-IDP/aced_etl_pod/commit/13b732958d6e8f55dadf20684abb5a01a7b5ecd2
There is an image that has been built for it. This code is not part of main branch.


Header integration

[ ] Add gravatar
[ ] Style optimization

Coverage remained the same at 100.0% when pulling e5bd43f96f903736c27957fb5401dad18269dbe3 on Integration_header into 1ea86f479c224fdf06dc4ab0f47ba17a9588d9eb on master.

That's a good pragmatic approach! I would prefer that you use this app: https://github.com/twaddington/django-gravatar
By using this app, you will be able to handle users with no gravatar account.
⚠ you have to install, configure and integrate the django-gravatar2 package.


Add git_resource extension

This is cool!
I'm a bit concerned about the high-level API - it's heavily parameterized, which is a sign that it doesn't compose well with other APIs.
What do you think of a more composable API like:
path = git_checkout(url)
deployment_from_dir(path)

or even deployment_create (like namespace_create in the namespace extension)
You can still have git_resource. It would just be syntactic sugar over the other public functions, and you could remove some of the customization parameters like yaml and build_callback

@nicks how is the number of (largely optional) parameters here any different than the large number of params defined for functions like docker_build() (16 params), local_resource() (10 params), or k8s_resource() (7 params)? I'm not disagreeing, just trying to clarify/understand.
In any case, I definitely like the idea of exposing things like git_checkout() and deployment_from_dir() etc while still maintaining the high-level git_resource() that glues them all together in a useful way.

Oh boy, talking about how to break up docker_build is like my favorite topic!!
The reason it started out as a single call is because it maps to a single docker API call. But in retrospect, I think it might make sense to separate out how to build the docker context (e.g., ignores) from general build settings that you would want to share among multiple docker builds (like the network).
I also have a long-rime dream of an image_build primitive that lets you set a builder config for different builders that improves on custom_build, such that docker_build was implemented as image_build under-the-hood
but ANYWAY, ya, i think it still makes sense to have a "package it all together" function for the common case, just that exposing some of the helper functions might loosen the config burden a bit

Could this be expanded to enable ways to load tilt extensions from repos other than tilt-extensions ?

@esatterwhite that seems to me like probably something that would need to be done in tilt itself.

@nicks how's this look since the latest commit?

thanks! I'll also add this to the tilt api ref.


Custom text over bar chart.

Hi Daniel,
Hope you are doing good.
Can we show our custom value/Text over every bar in Bar chart ?
Currently : Bar value is shown above bar.
Expected Behavior: Show custom value/text over every bar.
Thanks.

Waiting for positive reply

Use a custom number formatter

I think you didn't get my point.
Data values are something like this : 105,115,120,129,154 etc.
I have type against every data value i.e. Walking,Running,Cycling etc.
I want to draw graph on the bases of values and draw my type over each bar.
I think I have explained much.

I didn't quite understand you.

Well this is what I am looking to achieve.
Thanks.

Still you can use a custom NSNumberFormatter. You will receive the value
that you need - and output a String...
On Fri, May 15, 2015 at 12:51 PM, BurhanMughal<EMAIL_ADDRESS>wrote:

Well this is what I am looking to achieve.
Thanks.
[image: screenshot_2015-05-15-12-37-48]
https://cloud.githubusercontent.com/assets/12183139/7650616/b9b85b3a-fb11-11e4-8bd6-ead385184bcb.png
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/84#issuecomment-102349076
.

I think I can only pass two arrays i.e. xAxis and yAxis containing numbers. How can I pas number and string simultaneously ?

Well you do not pass a String. You said you do not want the value to show,
only a String right?
If so - then you can use a custom NSNumberFormatter - that will return your
custom String per value.
If you want to show both numeric value and a custom String - that's a
different case that we would have to consider.
On Fri, May 15, 2015 at 12:54 PM, BurhanMughal<EMAIL_ADDRESS>wrote:

I think I can only pass two arrays i.e. xAxis and yAxis containing
numbers. How can I pas number and string simultaneously ?
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/84#issuecomment-102350740
.

Sorry I couldn't quite get your idea, If it will return my custom string not value then how the graph will be populated ?
Getting confused.

The charts are populated with real values. The NSNumberFormatter is used to
generate the Strings that are rendered on the chart.
On Fri, May 15, 2015 at 1:10 PM, BurhanMughal<EMAIL_ADDRESS>wrote:

Sorry I couldn't quite get your idea, If it will return my custom string
not value then how the graph will be populated ?
Getting confused.
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/84#issuecomment-102357790
.

You mean to use numberFromString ?

Should I modify ChartViewBase or ChartRenderer ?

Neither. When I say custom NSNumberFormatter, I mean custom
NSNumberFormatter.
On Fri, May 15, 2015 at 1:36 PM, BurhanMughal<EMAIL_ADDRESS>wrote:

Should I modify ChartViewBase or ChartRenderer ?
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/84#issuecomment-102365106
.

I can't understand your idea of using NSNumberFormatter :(

Subclass the damn thing. You should really read some of Apple's
documentation on their APIs.
On Fri, May 15, 2015 at 1:53 PM, BurhanMughal<EMAIL_ADDRESS>wrote:

I can't understand your idea of using NSNumberFormatter :(
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/84#issuecomment-102368355
.

I solved it.. Thanks for your support. I just made changes in swift code and it works fine :) :+1:

That is not the correct approach, as updated to the project will keep coming. There are APIs for almost anything, and standard ways to customize things.

Yes you are right, It will take some time to apply your suggested approach and I can't afford time loss at this moment that's y I did this. Thanks anyway for suggestion I will eventually apply that one.
Regards.

I found ultimately Daniel there are two methods for init the BarDataEntry object one is without data and other one with additional (id) data __nullable parameter. I just populate my custom text in that parameter against each data entry and use it in drawText method in BarChartRenderer :).

Hi BurhanMughal..please send your Applied  code ..i want to show as it is your functionalities..

hello Sir

how to set that blue bubble  on stacked bar chart in Charts


Add License

Please add some sort of license (could be MIT or the free ones like GPL or MPL).
P.S.
Thank you for this. I really appreciate your effort to make MacOS a little better ❤

@alkatraz445 thanks for the issue! I've added a license in 85e37e271e2a5413589af550c75f1ef695229cae


ColourRGB is broken when attempting to run in Android

Android does not have java.awt.color, so calling any method which uses 'fromHS' such as getColourRGB() crashes with java.lang.NoClassDefFoundError

Im not sure if there's a neat solution, or whether this is actually worth fixing or not, but I figure I'd at least document the issue :)

Here's the workaround code Im using on Android:
import android.graphics.Color;

import androidx.core.graphics.ColorUtils;

 public static int getCurrentRGB(Light light) {
        if (light.getHue() != null) {
            light.getProperties();

            int hue = light.getHue();
            int sat = light.getSaturation();

            return fromHS(hue, sat);
        }
    }

public static int fromHS(int hue, int saturation){
    float hueNormalised = (hue/65535f) *360;
    float saturationNormalised = saturation/65535f;
    float hsv[] = {hueNormalised, saturationNormalised, 1f};
    int rgb = Color.HSVToColor(hsv);
    return  rgb;
}

`


[WIP]: MacOS Port

Fixes
Description of the changes:

Before submitting a Pull Request:

[ ] I reviewed CONTRIBUTING.md
[ ] I built my changes locally
[ ] I ran the unit tests
[ ] I ran the functional tests with a device
[ ] I ran the performance tests with a device

I tested changes on:

[ ] Windows
[ ] Linux

@microsoft-github-policy-service agree


Improve y2021 ex12: Use Node structure

Introduce Node<'a> structure in order to avoid recalculation.
Avoid extend method to avoid confusion (https://doc.rust-lang.org/std/iter/trait.Extend.html)
try_extend is not a good alternative truly. Also because try_* commonly returns Result not Option

use try_add_cave (that returns a Result). Use match instead if.


Check the image exists before uploading an attestation to OCI

This seems like a reasonable check before we store attestations in registry

Taking a look at this, is https://github.com/tektoncd/chains/blob/main/pkg/chains/storage/oci/oci.go#L166 not sufficient to verify an image does not exist?

good call! we can close this

opened https://github.com/tektoncd/chains/issues/296 as a related issue


Upgrade to Kubernetes 1.8

Update client-go to 1.8
Update README

See this for changes.

I tested the operator with 1.8.0 and all the resources are created correctly and the desired functionally is working. Not sure what else you meant by Upgrade to Kubernetes 1.8? Maybe we can add in details which versions we support (have been tested) in the README, but other then that not sure if there is anything else we need to do here.

Sorry for not having been clearer. I guess the most important point is upgrading to the version of client-go meant for 1.8. One hasn't come out yet though.
Also, since we're talking about it, I wonder if we can actually say we support '>= 1.7'. Meaning, that at the moment we only test against 1.7, and that's it.
We should figure out what versions we can/want to support, considering that the client-go library is tied to the Kubernetes version.

Also, since we're talking about it, I wonder if we can actually say we support '>= 1.7'. Meaning, that at the moment we only test against 1.7, and that's it.

Yes, good point, I was already thinking of this. Was thinking if maybe we can extend our tests and test against all of 1.7.x that are available. Maybe after merging to master we could have that test. Or something similar. That would be one of ways to ensure we always support the versions.
Can you update the description with more details, that this involves upgrading the client-go library etc. Maybe we can also move it to blocked as it's blocked on the release of  client-go``1.8. Thanks.

I don't know if adding more tests (I suppose you meant integration tests) is the right approach, given how long they take to run already.
Let's see once we have a newer client-go version.

Closing in favour of https://github.com/kinvolk/habitat-operator/issues/137.


App Services: Entry not found in cache.

Does this occur consistently?
Repro steps:

Has to refresh and show the apps in the subscription account
Not able to found the App services

Action: appService.CreateWebApp
Error type: Error
Error Message: Entry not found in cache.
Version: 0.16.5
OS: win32
OS Release: 10.0.18362
Product: Visual Studio Code
Product Version: 1.44.2
Language: en

Call Stack
a.createError extension.js:1:48963
b.<anonymous> extension.js:229:179477
extension.js:229:174092extension.js:229:174092
extension.js:229:46175extension.js:229:46175
extension.js:229:44168extension.js:229:44168
extension.js:229:43790extension.js:229:43790
i.find extension.js:229:78283
extension.js:229:25219extension.js:229:25219

As a workaround you could try reloading your window or signing out and signing back in to your Azure Account using the command palette.
Unfortunately there's not much we can do in this extension, but this is being tracked upstream here: microsoft/vscode-azure-account#53


Deprecate global key mapper

As discussed in #497. This deprecates the +setGlobalKeyMapper: method.
This change needs a bit more consideration & discussion before merging I think, but it's available if we do decide to make the change.

Oke, given thumbs up from @icanzilb and agreement in #497 by @solarplexus6, I'll go ahead and merge this one also.