Remove repeated line

Removed repeated line.

Coverage decreased (-0.005%) to 69.437% when pulling 0f2b817c6d81e4ee3934ca75d54009430082bcea on timifasubaa:quick_fix into c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master.


COMP: No longer delete (= delete) PreFillDirection() function template

Pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2869 commit af32a779c4586304e52ddc27eb81656b949c9eeb ("COMP: Remove unreachable code") "deleted" the PreFillDirection() function template definition, by = delete. This appeared to cause compilation errors on the following sites/builds:
Site: RogueResearch7
Build Name: Mac10.11-AppleClang-rel-x86_64-static
Build Name: Mac10.11-AppleClang-dbg-x86_64-static
As reported by Jon Haitz Legarreta Gorroño (@jhlegarreta) at https://github.com/InsightSoftwareConsortium/ITK/pull/2869#issuecomment-970306179
The error messages included:
/Users/builder/externalModules/IO/NIFTI/test/itkNiftiImageIOTest.cxx:26:1: error: redefinition of 'PreFillDirection'
PreFillDirection<1>()
^
[CTest: warning matched] /Users/builder/externalModules/IO/NIFTI/test/itkNiftiImageIOTest.h:64:1: note: previous definition is here
PreFillDirection<1>();
^

I haven't been able to reproduce these compilation errors so far. But that doesn't mean that the errors are fake, of course  😄
For what it's worth, I tried the following at https://godbolt.org/z/Yccnqnq4z
template <unsigned> struct Y{};

namespace itk
{
template <unsigned N> struct ImageBase
{
  using DirectionType = Y<N>;
};
}

template <unsigned int TDimension>
typename itk::ImageBase<TDimension>::DirectionType
PreFillDirection() = delete;

template <>
itk::ImageBase<1>::DirectionType
PreFillDirection<1>();

template <>
itk::ImageBase<2>::DirectionType
PreFillDirection<2>();

template <>
itk::ImageBase<3>::DirectionType
PreFillDirection<3>();

template <>
itk::ImageBase<4>::DirectionType
PreFillDirection<4>();

template <>
itk::ImageBase<1>::DirectionType PreFillDirection<1>() { return {}; }
template <>
itk::ImageBase<2>::DirectionType PreFillDirection<2>() { return {}; }

int main()
{
    PreFillDirection<1>();
}

Can the exception be exercised in the corresponding test file, please?

@jhlegarreta Thanks for your question. With the force-push that I just did, the function template no longer has a function-body. So now it cannot be called, and it does not throw an exception anymore. Does that answer your question?
Note that PreFillDirection() is not part of the ITK API. It isn't even in the itk namespace! As far as I can see, it's just a little helper function template for a test, itkNiftiImageIOTest3.

@jhlegarreta Thanks for your question. With the force-push that I just did, the function template no longer has a function-body. So now it cannot be called, and it does not throw an exception anymore. Does that answer your question?

Note that PreFillDirection() is not part of the ITK API. It isn't even in the itk namespace! As far as I can see, it's just a little helper function template for a test, itkNiftiImageIOTest3.

Reading the related call, the accompanying explanation, and the use of the direction variable here, I am not that sure whether the behavior proposed is the expected one for the method.

@seanm Can you check whether this fixes the compile error?

The old clang bug is reproducible at https://godbolt.org/z/W58nEWadM (as I wrote before), and the compiler error does indeed disappear when removing = delete, according this pull request  😃
I wonder if it is necessary to still supports such an old compiler version (clang 3.8.1), but for now, this pull request does the job, apparently!

Sorry, just seeing all this now.  Been a hectic few days.

The old clang bug is reproducible at https://godbolt.org/z/W58nEWadM (as I wrote before), and the compiler error does indeed disappear when removing = delete, according this pull request 😃

I could try on the bot if you still want, but sounds unnecessary at this point...

I wonder if it is necessary to still supports such an old compiler version (clang 3.8.1), but for now, this pull request does the job, apparently!

It's not that old, really. :) The Rogue7 bot is running OS X El Capitan, the last update of which was in July 2018. It's running the newest Xcode possible for that version of macOS: Xcode 8.2.1, released December 2016. That Xcode's compiler is AppleClang 8.0.

Thanks for your comment @seanm For the record: The Clang compilation error appears reported by jonathan.sauer, 2013-10-10: Bug 17537 - Explicit specialization of deleted function template not possible It appears fixed by Clang 3.9, as noted by Andrew Somerville, 2017-11-02.

And according to the table here:
https://en.wikipedia.org/wiki/Xcode#Xcode_7.0_-_10.x_(since_Free_On-Device_Development)_2
AppleClang 8.0 is based on open source Clang 3.9 svn, but they probably branched before that bug was fixed.

I was just about to merge this. I guess I can leave it up for another day or two until you figure out whether further modifications are desirable.

I was just about to merge this. I guess I can leave it up for another day or two until you figure out whether further modifications are desirable.

Thanks @dzenanz. As far as I can see, it is sufficient to just remove = delete from the function template, in order to make the old (but not that old) clang compiler happy.
However, it may be nice to still give the suggestion of @Leengit a try, from https://github.com/InsightSoftwareConsortium/ITK/pull/2879#discussion_r751658773 to also remove the declarations of the four explicit specializations. I'll try it out with my next force-push!

/azp run ITK.macOS

@seanm, does this make your compiler happy? 😄

I've confirmed this pacifies the Rogue7 bot.  Thanks all!


Any updates on this?

Hey guys, was wondering if you guys are planning on releasing the paper anytime soon. There have been a lot of abandoned repos as of late, hoping this isn't one of them.

I just read the preprint, and I want to express my gratitude to the authors for providing such a comprehensive explanation of the concepts and methods used. @neuralchen Do you happen to know if there's a planned schedule for releasing the pretrained models and training code?

@okaris could you please share the preprint pdf with me? i don't have access to it and can't pay 19$ IEEE web-sites asks for, I would highly appreciate it, my email is bonlimezak at gmail dot com

hi i wanted to ask ,
what is the status of code release?
i am working on FILM project and this look very interesting..


compilation error on sentinel-terminating extensions

There are many instances of
    extensions: ?[*:0]Extensions,

which isn't valid Zig considering 0 is an integer and Extensions is not. Probably what is more appropiate is ?[*]Extensions

fixed by 652a237


Can't deserialise And

The following elasticsearch JSON query has trouble during deserialisation. However, it works on Elastic server as it is valid syntax. It is similar to https://github.com/elastic/elasticsearch-net/issues/1187. You can use the similar source code to test by changing JSON string input
{
   "size": 5,
   "from": 0,
   "query": {
      "filtered": {
         "query": {
            "query_string": {
               "query": "*"
            }
         },
         "filter": {
            "and": [
               {
                  "range": {
                     "Year": {
                        "gte": "2000-10-10T00:00:00",
                        "lte": "2010-10-10T00:00:00"
                     }
                  }
               },
               {
                  "exists": {
                     "field": "identifier"
                  }
               },
               {
                  "exists": {
                     "field": "dateLastModified"
                  }
               },
               {
                  "exists": {
                     "field": "Year"
                  }
               }
            ]
         }
      }
   }
}

@abibell What do you mean exactly trouble during deserialization?  I tried reproducing this with an almost identical query and it seems fine.  Also tested serialize => deserialize => serialize and that also passes.
See the above test: https://github.com/elastic/elasticsearch-net/blob/develop/src/Tests/Nest.Tests.Integration/Reproduce/Reproduce1304Tests.cs

Hi @gmarz ,
Thanks for quick response.
I found the difference in your test's produced jsonString to reported. In my query there is no filters array within and. I think that is the issue. Is there an ElasticSearch query grammar documentation somewhere so we can make sure our Serialization matches ES?

Hi @abibell sorry for the delayed response.
Yea, that looks like the issue.  Both forms are valid, but NEST favors the filters array form since it's required in order to make use of the _cache param.
Hope that clears things up.


Incompability with docker 20.10 and it's API 1.41

Component
agent
Describe the bug
After #1744 WP requires docker 23.0. Many distros don't provide that yet and hence can't use next later than next-21a2fcbc38.
Many distros will be slow on catching up and will take months/years until docker 23.0 is supported.
I suggest to revert this dependency bump for compatibility.
System Info
-

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

Afaik the bump was related to a CVE report. Is there a patch version for the previous version?

well the next version is going to target latest taged dependencys ... and so require an uptodate docker deamon ...
the v0.15.0 did got a patch that is non breaking ... through I understand you want to have the features of next.
I want to tag the 1.0 release soon but .. well it's done when it's done (https://github.com/woodpecker-ci/woodpecker/milestone/4)

well the next version is going to target latest taged dependencys ... and so require an uptodate docker deamon ...

I can't follow the reasoning here. Just because it's next I don't see why it must depend on docker 23.x?
It's not even about the features of next per so, I think the latest release (even if released or not) should be compatible with the majority of the linux lifecycle and not introduce a dependency which has not yet arrived in the package managers of most distros out there.

Afaik the bump was related to a CVE report. Is there a patch version for the previous version?

#1744 doesn't list any CVE so I can just guess. AFAICS Docker 20.x also get's CVE patches so I'd assume the referenced one was also included as I don't see a reason for docker not to patch the 20.x series for CVEs (https://docs.docker.com/engine/release-notes/20.10/).

I don't see the reason why not to use docker-ce instead that's more up to date version.

As not everyone can control the used repos themselves. In many environments only the managed/built-in repo are allowed by security and no "most recent" ones can installed.
One particular example (out of more) is Suse Enterprise 15.4 which only provides docker and not docker-ce and the former only in version 20.x.
I don't understand the motivation against staying compatible for a project aiming towards serving all users/platforms.

wasn't there also compatibility issues with alpine 3.18 anyway on 20.10?


[Remote Store] Skip upload of segments_N file

Is your feature request related to a problem? Please describe.

Currently, while uploading segments to remote segment store, we upload existing segments_N file as well.
But we don't use the segments_N file in the download flow as we commit SegmentInfosSnapshot that is stored in the form of bytes in remote segment metadata.
In this feature, we propose not to upload the segments_N file.

Not required anymore.


net: ip: Fixed IGMP V2 membership report destination address.

As per RFC 2236 Section 9, the IGMP V2 membership reports should be sent to the group multicast address being reported. Without this fix, when IGMP snooping is enabled on a network a device is not able to receive multicast from certain multicast addresses e.g. 239.255.x.x.
Fixes #52449
Signed-off-by: Chamira Perera<EMAIL_ADDRESS>

@cperera-aud The commit message needs some refactoring, one line is too long:

5: UC4 Line exceeds max length (79>75): "IGMP snooping is enabled on a network a device is not able to receive multicast"

@cperera-aud The commit message needs some refactoring, one line is too long:

5: UC4 Line exceeds max length (79>75): "IGMP snooping is enabled on a network a device is not able to receive multicast"

Thanks @rlubos I've amended the commit message. Apologies if I made any mistakes while updating the PR, this is my first time contributing to Zephyr.

Thanks @rlubos @jukkar @carlescufi for helping to close the loop on this one.


test: correct x-envoy-retry-grpc-on header used in test

Uses the correct header key for grpc retry policy. Not sure what the purpose of this test is given the test seems to pass even without the header (retry decision is mocked out, it doesn't depend on the header), but at least now it's setting the right header.
Risk Level: Low

AFIK it's basically testing that the HCM state machine is happy. the actual retry. The actual headers are checked in retry_state_impl_test.cc

I just looked at this and I agree this test probably doesn't add any value for the actual header since it's using a mock retry state. It's probably worth deleting any duplication of this type of test in this file, since it's possible people kept copy/pasting assuming it was testing something else. :(


Typings?

Interested in typings?
Downstream this would make completions nicer and let users check argcomplete usage for correctness
(I am happy to contribute them, if so.)

Hi, thanks for the note. Yes, type hint contributions are welcome (as long as they are added to the code and not as separate stub files, which are hard to maintain).

Hi, thanks for the note. Yes, type hint contributions are welcome (as long as they are added to the code and not as separate stub files, which are hard to maintain).

Bikeshed: do you have a preference for the way its imported?
via a short namespace (e.g. flask style, 2):
import typing as t

def fn(val; str, items: t.List[str]):
    ...

vs
from typing import List

def fn(val; str, items: List[str]):
    ...

In my libs I ended up picking flask's style: import typing as t.

No preference - feel free to use either style.


Allow generic visualizer widget to render when auth token is not present.

Also, inhibit buttons when no auth token present since they don't do anything useful.

Looks good! This'll hopefully remove some confusion.


Px4flow initial value wrong and does not change in flight

I am using Pixhawk 2 with px4fmu-v2_lpe firmware. I am trying to integrate px4flow with it. When I give the takeoff command from qgroundcontrol (OFFBOARD flight mode), the drone flies away and crashes. I checked the height received using mavros under the topic /mavros/local_position/pose and it was around 0.5 meters.
Here  is the link to the flight data plots.

Looks like the estimator diverged. Can you please try flying with EKF2 with optical flow fusion enabled and some rangefinder connected (https://dev.px4.io/en/tutorials/optical_flow.html)?


eosiocpp crashed when generating abi

VirtualBox:~/work/contract/EOSDACRandom$ eosiocpp -g eosdacrandom.abi eosdacrandom.cpp
1815853ms thread-0   abi_generator.hpp:68          ricardian_contracts  ] Warning, no ricardian clauses found for eosdacrandom

1815853ms thread-0   abi_generator.hpp:75          ricardian_contracts  ] Warning, no ricardian contract found for setsize

1815853ms thread-0   abi_generator.hpp:75          ricardian_contracts  ] Warning, no ricardian contract found for sendseed

1815853ms thread-0   abi_generator.hpp:75          ricardian_contracts  ] Warning, no ricardian contract found for sendhash

1815853ms thread-0   abi_generator.hpp:75          ricardian_contracts  ] Warning, no ricardian contract found for regrequest

/usr/local/bin/eosiocpp: line 69: 15405 Segmentation fault      (core dumped) ${ABIGEN} -extra-arg=-c -extra-arg=--std=c++14 -extra-arg=--target=wasm32 -extra-arg=-nostdinc -extra-arg=-nostdinc++ -extra-arg=-DABIGEN -extra-arg=-I${EOSIO_INSTALL_DIR}/include/libc++/upstream/include -extra-arg=-I${EOSIO_INSTALL_DIR}/include/musl/upstream/include -extra-arg=-I${BOOST_INCLUDE_DIR} -extra-arg=-I${EOSIO_INSTALL_DIR}/include -extra-arg=-I$context_folder -extra-arg=-fparse-all-comments -destination-file=${outname} -verbose=0 -context=$context_folder $1 --

It seems like that vector<tuple> way is not allowed. When it is removed from struct, eosiocpp doesn't crash anymore.
// @abi table geter_info
struct geter_info
{
    name     owner;
    std::vector<std::tuple<uint64_t, uint64_t>> requestinfo;

    uint64_t primary_key() const { return owner; }

    EOSLIB_SERIALIZE( geter_info, (owner) (requestinfo) )
};

Env:

OS: Ubuntu 16.04 x64
commit id: 9766d2f0ae6b5dad3e31323261203f57de38eb87

so how did you solve the issue?

@KennyLiu25775 https://github.com/EOSIO/eos/pull/3749/commits/6bf074868ed5eae79398cbd8555d97fad67904d0


⚠ SceneTime has degraded performance

In 5104b2a, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 6526 ms

Resolved: SceneTime performance has improved in 6077b73 after 7 minutes.


TextInput does not honor iOS text size

TextInput component always renders at the font size specified in the style for the component and does not honor font scaling from the OS (iOS, not sure about Android).  This becomes especially problematic when you have a populate the TextInput with some text and you want to size the TextInput properly from the start (and adjust it as more/less lines are added).
Scenario: You have a user that has set their default font size to be the smallest or largest (Important) in their iPhone's settings.  In your RN app, you have a Text field that onLongPress is going to allow editing.  You want to size the TextInput component to be the same height at the Text component, but now with a cursor to allow for editing.

Just checking that you've tried setting allowFontScaling = true for your TextInput??

@rogchap - Thanks for the feedback.  I just tried allowFontScaling={true} and see the same result.  Below is one of the TextInput components I'm working with.  I'm open to any other suggestions on things to try.
<TextInput style={[styles.textInput, {height: Math.max(30, this.state.height), color: inputTextColor}]}
   onChangeText={this.onChangeText}
   onChange={(event) => {
      this.setState({height: event.nativeEvent.contentSize.height})
   }}
   value={this.state.message}
   autoFocus={this.props.autoFocus}
   blurOnSubmit={false}
   editable={!this.state.pressedSubmit}
   initialHeight={30}
   multiline={true}
   allowFontScaling={true}
   placeholder={this.props.placeholder || 'Message'}/>

+1 notable that I believe this only occurs with multiline={ true }

@facebook-github-bot label Icebox

@facebook-github-bot close

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/textinput-does-not-honor-ios-text-size
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


russound_rnet componet not working due to omission of SUPPORT_TURN_ON option

Home Assistant release: 0.35.2
Python release: 3.5.2
Component/platform: media_player / russound_rnet
Description of problem:
Using the russound_rnet media player component, each zone that is configured does render in the UI but cannot be turned on (there is no on button).  As a result it cannot be used.
Having investigated the code. the russound_rnet.py file is missing the SUPPORT_TURN_ON option in the import on line 12 and on line 28 when defining the SUPPORT_RUSSOUND variable.
I did add this to option to the code locally and then the component behaves as expected (see attached code).
Best regards,
Andreas.
(By the way thanks for adding the russound component.  Its not a mainstream device and its great to have it supported.)
russound_rnet.zip

Have made various code changes to address this issue and working with @laf to test the code and bring it not the main branch.

Have made various code changes to address this issue and working with @laf to test the code and bring it not the main branch.


AMD FLM does not react any more after trying to close the right-click settings window

AMD FLM does not react any more after trying to close the right-click settings window, especially when using "Set Capture Region" and "Save settings to INI". This happens almost every time, it is hard to save the settings to .ini file even.

Found a workaround: dont use the close button, but close the settings window with right-click instead.
Still a bug, would be great if fixed in a future release.


BLE HID device Gamepad button click not recognized on iOS (IDFGH-13018)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2.2
Espressif SoC revision.
ESP32 c3
Operating System used.
macOS
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32-C3-DevKitM-1
Power Supply used.
USB
What is the expected behavior?
When sending gamepad button press, event should be recognised on iOS, in the Switch Input section
What is the actual behavior?
Not respond to any button button
Steps to reproduce.

compile the ble hid device demo under bludroid, modify the demo function to:

esp_hid_ble_gap_adv_init(ESP_HID_APPEARANCE_GAMEPAD, ble_hid_config.device_name);

const unsigned char mediaReportMap[] = {
  0x05, 0x01, // USAGE_PAGE (Generic Desktop)
    0x09, 0x04, // USAGE (Gamepad)
    0xa1, 0x01, // COLLECTION (Application)
    0x85, 0x00,   // Report id 0
    0x05, 0x09, //     USAGE_PAGE (Button)
    0x19, 0x01, //     USAGE_MINIMUM (Button 1)
    0x29, 0x03, //     USAGE_MAXIMUM (Button 3)
    0x15, 0x00, //     LOGICAL_MINIMUM (0)
    0x25, 0x01, //     LOGICAL_MAXIMUM (1)
    0x95, 0x03, //     REPORT_COUNT (3)
    0x75, 0x01, //     REPORT_SIZE (1)
    0x81, 0x02, //     INPUT (Data,Var,Abs)
    // padding
    0x95, 0x01, //     REPORT_COUNT (1)
    0x75, 0x05, //     REPORT_SIZE (5)
    0x81, 0x03, //     Input(Constant, Variable, Absolute, NoWrap, Linear, PreferredState, NoNullPosition, BitField)

    0xc0        // END_COLLECTION
};

void esp_hidd_send_consumer_value(uint8_t key_cmd, bool key_pressed)
{
uint8_t buffer[1] = {0};
if (key_pressed)
{
buffer[0] = 1;
}

esp_err_t res = esp_hidd_dev_input_set(s_ble_hid_param.hid_dev, 0, 0x00, buffer, 1);

return;
}

flash it to board and connect it from the iOS, wait for it to perform button click;

Debug Logs.
Nothing strange. On Android this sample works as expected.
I (90149) HID_DEV_DEMO: Send button
V (90149) BLE_HIDD: HID CONF[0] status: 0x00, len: 0

More Information.
Not working on MacOS either

Did your Mac device recognize the ESP32-C3 as a keyboard device, and none of the keys are responding?

I was trying to build a gamepad no a keyboard.
Yes it was recognized as a gamepad, but none of the button events were recognized by iOS.
After some investigation it appeared, that iOS will only accept events big corp gamepads.
Hence this is not an ESP issue, but rather a requirement from iOS.


鼠标荧光笔

Description of the new feature / enhancement
只开启右键查找就足够了。建议左右键可以分开控制，或者颜色允许为透明。
Scenario when this would be used?
一个键高亮就可以了。看起来很难受。
Supporting information
No response

mouse highlighter
Just turning on right-click search is enough.  It is recommended that the left and right keys can be controlled separately, or the color can be transparent.
A key highlight is enough.  It looks bad.

Sorry, I'm not sure what you mean exactly.


fixed #1155

Added favicon &
Updated title in reactjs branch

should i rise pr again or is this fine?
On Tue, Feb 8, 2022 at 10:40 AM Anush Bhatia @.***>
wrote:

@.**** commented on this pull request.
don't remove the .github folder
—
Reply to this email directly, view it on GitHub
https://github.com/smaranjitghose/awesome-portfolio-websites/pull/1170#pullrequestreview-875525768,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APHTM5SR7FPVV5LHGFWJSBDU2CQVLANCNFSM5NVS3PDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
<smaranjitghose/awesome-portfolio-websites/pull/1170/review/875525768@
github.com>

[image: image.png]
If you look at the left hand side, there's a folder named
".github/workflows", could you please recheck? Also in my repo fork i found
the same!
Thanks & Regards
Sathya priyaa R
On Tue, Feb 8, 2022 at 11:34 PM Anush Bhatia @.***>
wrote:

create a new one and check .gitignore for all the files
—
Reply to this email directly, view it on GitHub
https://github.com/smaranjitghose/awesome-portfolio-websites/pull/1170#issuecomment-1032907505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APHTM5VEXIEA3OQBU6BRKFLU2FLKLANCNFSM5NVS3PDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***
com>

[image: image.png] If you look at the left hand side, there's a folder named ".github/workflows", could you please recheck? Also in my repo fork i found the same! Thanks & Regards Sathya priyaa R
…
On Tue, Feb 8, 2022 at 11:34 PM Anush Bhatia @.> wrote: create a new one and check .gitignore for all the files — Reply to this email directly, view it on GitHub <#1170 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/APHTM5VEXIEA3OQBU6BRKFLU2FLKLANCNFSM5NVS3PDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @. com>

that should be there. do one thing take a fresh clone of the current repo and add these changes there it will solve this problem.

if you still face issue contact me on discord will resolve it.

Sure, will do that.
On Wed, Feb 9, 2022 at 12:57 PM Anush Bhatia @.***>
wrote:

if you still face issue contact me on discord will resolve it.
—
Reply to this email directly, view it on GitHub
https://github.com/smaranjitghose/awesome-portfolio-websites/pull/1170#issuecomment-1033429890,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APHTM5W5YP5IDTCFNBCFD43U2IJNXANCNFSM5NVS3PDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***
com>

done, pls check!
On Thu, Feb 10, 2022 at 1:31 AM Sathya priyaa @.***>
wrote:

Sure, will do that.
On Wed, Feb 9, 2022 at 12:57 PM Anush Bhatia @.***>
wrote:

if you still face issue contact me on discord will resolve it.
—
Reply to this email directly, view it on GitHub
https://github.com/smaranjitghose/awesome-portfolio-websites/pull/1170#issuecomment-1033429890,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APHTM5W5YP5IDTCFNBCFD43U2IJNXANCNFSM5NVS3PDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***
com>


Missing space in generated mnCommand.txt

A space is missing between gradle and --features in generated mnCommand.txt :
mn create-app com-bell-bte-dragoon-api-smdragoon --profile service --lang java --build gradle--features graal-native-image --features management --features asciidoctor --features java-configuration

Thanks a lot for reporting this bug!
Please, check


Unclear role of "mavenOptions" and "goals" fields

I was trying to run "mvn package -DskipTests -Pspark-2.4".
Therefore I tried the following:
trigger:

master

pool:
vmImage: 'Ubuntu-16.04'
steps:

task: Maven@3
inputs:
mavenPomFile: 'pom.xml'
mavenOptions: '-Xmx3072m -DskipTests -Pspark-2.4'
javaHomeOption: 'JDKVersion'
jdkVersionOption: '1.8'
jdkArchitectureOption: 'x64'
publishJUnitResults: false
testResultsFiles: '**/surefire-reports/TEST-*.xml'
goals: 'package'
which failed with:

Unrecognized option: -P
Error: Could not create the Java Virtual Machine.
After some trial and error, I changed to the following, which succeeded.

task: Maven@3
inputs:
mavenPomFile: 'pom.xml'
mavenOptions: '-Xmx3072m'
javaHomeOption: 'JDKVersion'
jdkVersionOption: '1.8'
jdkArchitectureOption: 'x64'
publishJUnitResults: false
testResultsFiles: '**/surefire-reports/TEST-*.xml'
goals: 'package -DskipTests'

This is pretty confusing, as apparently the "mavenOptions" field is not actually for Maven options, but for JVM options. Also apparently any extra maven options need to be put into the goals field, although they are not goals! I wonder if the field names could be made clearer, and the documentation could be expanded to make this easier.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 589e076c-9f67-77df-3204-4f549566f21b
Version Independent ID: 2e51ef13-8fd3-1397-82f0-27c92f1ccee5
Content: Maven build and release task - Azure Pipelines
Content Source: docs/pipelines/tasks/build/maven.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Any news on progress on this issue?
What's the best workaround advised?

@titimoby the workaround I explain works well. It's more that the field names are confusing.

Oh, thanks @algattik  , it actually works well.
I just wanted to be sure that there were no other options or drawback to the goal solution.
It is fine for me now.
But it will be great to have some estimate on a proper solution

I agree with @algattik "mavenOptions" and "goals" fields are confusing.
I would say one way to address the confusion is that the Azure Doc should include worked examples on how to translate worked mvn CLI commands into Maven tasks.
For example, the Azure doc of Maven task should include: if the mvn commands is
export MAVEN_OPTS="-Xmx3072m"
mvn clean package -Dmaven.test.skip=true

what should be the Maven Task equivalent.

-P option is not working, should be supported.
Or what is the workaround, I am stuck, have to use "script" instead of the maven task ??


JDBC batch update performance issue

Driver version
12.8.1.jre11.jar
SQL Server version
Microsoft SQL Server 2016 (SP2-GDR) (KB4583460) - 13.0.5108.50 (X64)
May 20 2022 20:28:29
Copyright (c) Microsoft Corporation
Standard Edition (64-bit) on Windows Server 2012 R2 Datacenter 6.3  (Build 9600: )
Client Operating System
Windows
JAVA/JVM version
java SE 20
Table schema
CREATE TABLE xxx.dbo.Attachment_BlobStatus (Id varchar(18) ,Status varchar(20) );
CREATE NONCLUSTERED INDEX IDX_Id_Attachment_BlobStatus ON dbo.Attachment_ID
Problem description
We have around 200k rows in this table.
Running update statment in the attached sample. Each batch of 2000 recds take 10+ secs.
A clear and concise description of what you expected to happen.
Actual behavior
Output of what you actually see.
Error message/stack trace
Complete error message and stack trace.

Any other details that can be helpful
Add any other context about the problem here.
JDBC trace logs
Provide the JDBC driver trace logs.  Instructions can be found here: https://docs.microsoft.com/sql/connect/jdbc/tracing-driver-operation

How's the performance when you run a SET NOCOUNT ON before your batch calls?
And also, how do older driver versions fair? Could you try 9.4.1, 10.2.3, 11.2.3 and 12.4.2?

Can i attach the source file to this email chain? Github does not allow files other than Images etc.
Also, SETcount off did not help either.
Going back to older versions-may be ok for comparison/debugging purposes. But, we doubt we can do it permanently in production.
Thanks
On Sep 11, 2024, at 1:15 PM, Terry Chow @.***> wrote:

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
External email. Inspect before opening.
Also, can you give me the source code for your issue and any thing else that I might require to recreate the setup on my own environment. Thanks.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/mssql-jdbc/issues/2511#issuecomment-2344251891, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BLG3E567P6AOYN6FQ3MAEELZWB3DHAVCNFSM6AAAAABOBIRHBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUGI2TCOBZGE.
You are receiving this because you authored the thread.Message ID: @.***>

@msenthilnathan-cvlt
You should be able to zip it and upload it to your comment.

AttachmentBlobStatusUpdater.zip
java source file zipped

@msenthilnathan-cvlt
In progress of getting this setup...
But, could you try adding sendStringParametersAsUnicode=false in your connection string. Let me know if there's a performance difference.

Thanks Terry. In my quick test, this seems to had done the trick. Compared to 14 sec response, with this param, response is instantaneous.
Will test some more and incorporate it in our product code and get back.
Can you please share any documentation on this?
Since connection is used for other SQL updates, which may need to send parameters in Unicode - how to use this without such side effects?
Thanks
Senthil
From: Terry Chow @.>
Sent: Thursday, September 12, 2024 6:55 PM
To: microsoft/mssql-jdbc @.>
Cc: Muthusamy Senthilnathan @.>; Mention @.>
Subject: Re: [microsoft/mssql-jdbc] JDBC batch update performance issue (Issue #2511)
You don't often get email from<EMAIL_ADDRESS>Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
External email. Inspect before opening.
@msenthilnathan-cvlthttps://github.com/msenthilnathan-cvlt
In progress of getting this setup...
But, could you try adding sendStringParametersAsUnicode=false in your connection string. Let me know if there's a performance difference.

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/mssql-jdbc/issues/2511#issuecomment-2347377700, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BLG3E5YFDZG5LI27AO77NSDZWILWBAVCNFSM6AAAAABOBIRHBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXGM3TONZQGA.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@msenthilnathan-cvlt
Thanks for the quick test. This confirmed my suspicions. It was a perf impact because of an implicit conversion from varchar to nvarchar.

Can you please share any documentation on this?
Since connection is used for other SQL updates, which may need to send parameters in Unicode - how to use this without such side effects?

For this doc, scroll down to the sendStringParametersAsUnicode section:
https://learn.microsoft.com/en-us/sql/connect/jdbc/setting-the-connection-properties?view=sql-server-ver16
https://learn.microsoft.com/en-us/sql/connect/jdbc/reference/setsendstringparametersasunicode-method-sqlserverdatasource?view=sql-server-ver16
As for safely using this, I'd recommend operating solely on exclusively varchar or nvarchar (for example) with your connections and set sendStringParametersAsUnicode appropriately beforehand. That'd be the best. We default to unicode to prevent accidental data loss as backwards compatibility, since this was the initial behaviour in the driver.

Just adding a bit more details. The perf impact occurred because your table had a column defined as varchar, but since the driver by default sends parameters to server in unicode, there was an implicit conversion going from varchar to nvarchar. This implicit conversion caused the slowness.
So, migrating your columns eg. varchar, char etc... to nvarchar or nchar etc... and using sendStringParametersAsUnicode=true would increase performance also.

Yes, but we know the data stored is only English in this case. There are many other tables also - that are to track internal data that don't need to NVARCHAR. Will that not result in overallocation and also slowness in sorting/comparisons?
Seems, setString() and setNString() should be used depending on the data types; but, its probably too big of a change for our product at this change.  Will explore how to do this - may be only for selected updates/queries.
Appreciate the suggestions !!
From: Terry Chow @.>
Sent: Thursday, September 12, 2024 7:45 PM
To: microsoft/mssql-jdbc @.>
Cc: Muthusamy Senthilnathan @.>; Mention @.>
Subject: Re: [microsoft/mssql-jdbc] JDBC batch update performance issue (Issue #2511)
External email. Inspect before opening.
Just adding a bit more details. The perf impact occurred because your table had a column defined as varchar, but since the driver by default sends parameters to server in unicode, there was an implicit conversion going from varchar to nvarchar. This implicit conversion caused the slowness.
So, migrating your columns eg. varchar, char etc... to nvarchar or nchar etc... and using sendStringParametersAsUnicode=true would increase performance also.

Reply to this email directly, view it on GitHubhttps://github.com/microsoft/mssql-jdbc/issues/2511#issuecomment-2347419806, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BLG3E55GCGQ342P5DYECRV3ZWIRRBAVCNFSM6AAAAABOBIRHBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXGQYTSOBQGY.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Merge vercel/staging into dev

The goal is to catch the dev branch up with vercel/staging. The overarching goal is to have dev, main, vercel/staging, and vercel/prod all in sync so we can establish a proper workflow for making new commits to Xray

Looks good.


Seed Data in Production

We need to add an actual workflow to the database in production in order to get it to actually be able to show/run a workflow.  This probably depends on @dionjwa and I deciding if we are using redis for stuff like this or not.

The seed data should just be one workflow inserted into the workflows hash keyed on its id:
{ id: 0, title: 'VDE' }

@dionjwa This is the seed data issue we just discussed in case you get to it before I do.

@dionjwa If you still have time to make a change here, the id should be a string not a number!  Sorry about that.

This is done and has gone through a few iterations.  Here's where seed data is added: https://github.com/Autodesk/molecular-design-applications/blob/master/server/utils/db_utils.js#L8 and here's the seed data itself https://github.com/Autodesk/molecular-design-applications/blob/master/server/utils/seed_data.js


feat: git Access, AccessMethod, Repositories backed by CTF

What this PR does / why we need it:
This is an extremely early (WIP) draft of implementing ctf archives in directory format tracked via git repositories, ultimately serving me as a playground to get familiar with OCM and also to play around with its feature set. So we do not need to merge this if there is no interest or disagreement on the implementation.
Not only does this allow using git repositories for storing blobs, it also attempts to add git downloader functionality for a generic git access method based on in memory cloning and I plan to add a OCM implementation on it as well.
Currently the implementation is written so that any modification to the CTF in the work directory also triggers a dedicated commit, and any lookup triggers a refres/pull cycle on git.
For testing I use file:// URLs which makes it quite easy to verify E2E in the test suites.
TODO:

[X] Implement Access Credential mapping
[x] Implement OCM Repository mapping to OCI Repository mapping (similar to CTF)
[x] Implement Git Downloader
[x] Make Git Client thread-safe, optionally in-memory and allow more customization (currently hard bount to one target ref that I am creating or syncing against, see tests for examples)
[ ] Expand Git Options

Current Design:
Every CTF Modification should lead to an atomic FS update. We use/abuse this to also trigger an atomic commit in git that allows to track changes made through the Repo implementation atomically.

So this work happens to be implementing this issue https://github.com/open-component-model/ocm-project/issues/239.
I'll assign it to you then.

Hi @jakobmoellerdev, concerning your idea of git backed CTF repositories,  if I understand your approach correctly,
every change will create a new commit. I think this approach misses the need for a semantical bracket for a set of changes.
It is more like creating a commit for every changed line in a source file, which does not look like a good idea.
A useful bracket (which is already supported) could be the open/close of a CTF. The typical workflow is to open a CTF, apply some changes (for example with the ocm add cv command) and then close it again.

Hi @mandelsoft, thanks for taking a look.
I think the semantical equivalent to a git push would be to close the repository. In your description that would be

Open CTF -> Git Clone / Checkout
Apply Changes (e.g. add cv) -> Write/Update Files in CTF, Commit atomically
Close CTF -> Git Push

Of course we can change the flow to

Open CTF -> Git Clone / Checkout
Apply Changes (e.g. add cv) -> Write/Update Files in CTF,
Close CTF -> Git Commit all changes, Git Push

If you are concerned with that. In my view they are equivalent and the atomic commits are much more transparent when a change was made. However Im totally fine with your take as well, it shouldnt be too hard to change.
I think we could change it so that there is one commit that has all the current commit messages in the commit body. Then we will have 1 commit. WDYT?

this is ready for a first pass review. We might change the way the commits are generated (see discussion above) but generally i would still like some input as its my first take on a larger change in this codebase

Just a quick update on this PR: I didnt get around to it yet, but I will probably remove the repo code because its unlikely to be used (as it all started for me to get into the OCM codebase). The AccessMethod etc can stay in and are still valid though.

sap/git-access-test/test.ca on ☁<EMAIL_ADDRESS>❯ l
total 4
drwxr-x--- 3 skarlso staff   96 Dec  6 15:12 blobs/
-rwxr-x--- 1 skarlso staff 1115 Dec  6 15:11 component-descriptor.yaml*
sap/git-access-test/test.ca on ☁<EMAIL_ADDRESS>➜ cd blobs/
git-access-test/test.ca/blobs on ☁<EMAIL_ADDRESS>➜ tar xzf sha256.c3bdcc7317c2afe8a4ef373af21404eece1563db4a51aaab70372455c12c3624
git-access-test/test.ca/blobs on ☁<EMAIL_ADDRESS>➜ cat README
Hello World!
git-access-test/test.ca/blobs on ☁<EMAIL_ADDRESS>

There are a few more tests to do as well.


can't create new react app

Describe the bug
(PS C:\Users..\OneDrive\Skrivbord\fre> npx create-react-app ecom
Creating` a new React app in C:\Users..\OneDrive\Skrivbord\fre\ecom.
Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts with cra-template...
Aborting installation.
Unexpected error. Please report it as a bug:
Error: spawn UNKNOWN
at ChildProcess.spawn (node:internal/child_process:412:11)
at Object.spawn (node:child_process:698:9)
at spawn (C:\Users\baraa\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\cross-spawn\index.js:12:24)
at C:\Users\baraa\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app\createReactApp.js:390:19
at new Promise ()
at install (C:\Users\baraa\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app\createReactApp.js:341:10)
at C:\Users\baraa\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app\createReactApp.js:468:16
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
errno: -4094,
code: 'UNKNOWN',
syscall: 'spawn'
}
Deleting generated file... package.json
Deleting ecom/ from C:\Users\baraa\OneDrive\Skrivbord\fre
Done.
PS C:\Users\baraa\OneDrive\Skrivbord\fre> .)
Did you try recovering your dependencies?

(

npm install -g create-react-app
npm cache clean --force
npm install npm@latest

)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

(Environment Info:
current version of create-react-app: 5.0.0
running from C:\Users\baraa\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app
System:
OS: Windows 10 10.0.22000
CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
Binaries:
Node: 16.13.1
npm: 8.3.0
npmPackages:
react: Not Found
react-dom: Not Found
react-scripts: Not Found
npmGlobalPackages:
create-react-app: Not Found.)
Steps to reproduce

(Write your steps here:)

Expected behavior

(Write what you thought would happen.)
Actual behavior

()
Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

i have same problem... i tried all answers from stackoverflow ( delete npm, npx cache), reinstall node.js, but i still have that problem
`

PS C:\Users\Admin\Desktop\study\portfoliosite> npx create-react-app my-app
Need to install the following packages:
create-react-app
Ok to proceed? (y) y
npm WARN deprecated<EMAIL_ADDRESS>This version of tar is no longer supported, and will not receive security updates. Please upgrade asap.
Creating a new React app in C:\Users\Admin\Desktop\study\portfoliosite\my-app.
Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts with cra-template...
Aborting installation.
Unexpected error. Please report it as a bug:
Error: spawn UNKNOWN
at ChildProcess.spawn (node:internal/child_process:412:11)
at Object.spawn (node:child_process:698:9)
at spawn (C:\Users\Admin\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\cross-spawn\index.js:12:24)
at C:\Users\Admin\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app\createReactApp.js:390:19
at new Promise ()
at install (C:\Users\Admin\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app\createReactApp.js:341:10)
at C:\Users\Admin\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app\createReactApp.js:468:16
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
errno: -4094,
code: 'UNKNOWN',
syscall: 'spawn'
}
Deleting generated file... package.json
Deleting my-app/ from C:\Users\Admin\Desktop\study\portfoliosite
Done.
PS C:\Users\Admin\Desktop\study\portfoliosite>

`

PS C:\Users\Admin\Desktop\study\portfoliosite> node -v
v16.13.1
PS C:\Users\Admin\Desktop\study\portfoliosite> npm -v
8.3.0
PS C:\Users\Admin\Desktop\study\portfoliosite> npx -v
8.3.0

I got this strange message when running:
$ npx create-react-app my-app

Need to install the following packages:
  create-react-app
Ok to proceed? (y) y

You are running `create-react-app` 4.0.3, which is behind the latest release (5.0.0).

We no longer support global installation of Create React App.

Please remove any global installs with one of the following commands:
- npm uninstall -g create-react-app
- yarn global remove create-react-app

The latest instructions for creating a new app can be found here:
https://create-react-app.dev/docs/getting-started/

System:

OS: Manjaro Linux x86_64 - 5.15.12-1-MANJARO
CPU: AMD Ryzen 7 5800H with Radeon Graphics (16) @ 3.200GHz

Binaries:

Node: 16.13.1
npm: 8.3.0

Solved here https://github.com/facebook/create-react-app/issues/11845#issuecomment-1001388428

I get this error as well.

Mac V12.1
Node version 14.x 16.x, and 17.x
npm cache clean --force
sudo npm uninstall -g create-react-app
npx clear-npx-cache

Nothing seems to work.
My work around, add the version.
npx<EMAIL_ADDRESS>app-name

Possible duplicate of https://github.com/facebook/create-react-app/issues/11991.


Will "Nakama" increase the "P2P" network capability?

Will "Nakama" increase the "P2P" network capability?
I think this is a good network capability！
I hope "Nakama" can have this ability!
Use the "Nakama" server as the judge to build a "P2P" network bridge for the client。

Nakama offers extensible subsystems for various aspects of a multiplayer game, such as party system, matches, chats, state storage and realtime RPC.
With custom RPC functions you can implement almost any logic imaginable, which fits request-response model.

Seems this may be a discussion more appropriate for the forum instead.


No "site migration" in SPMT V3(latest public preview)

Can't find "site migration" option in SPMT V3(latest public preview), also "Pages" library isn't showing.

if you try this build https://spmtreleasescus.blob.core.windows.net/betainstall/default.htm
and you create a task for a site and keep the setting as default the full pages, navigation, webpart and structure.
If this doesnt work please reach out to<EMAIL_ADDRESS>Thanks

@fz2019  - thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:  https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@officedocsbot close


feat: add support for multi user approval in suspend. fixes #12108

Fixes #12108
Motivation

This feature adds support for multi approval in the suspend state instead of using the self-declared single-point enum strategy. This allows for better interactivity and fine-grained access to promotions for instance.
I'm publishing this already now as I am looking to catch some early feedback as this is my first time contributing to this project. This is also one of my first larger PRs (in Go) so I appreciate any feedback that you can provide me and I will try to address any comments as quickly and thoroughly as possible.
Modifications

Currently, the state of this PR is as follows:

[x] introduce core including ApproverStatus field, an approve function, and two core test cases.
[x] add ui changes to handle approvals
[x] handle approvals
[ ] use accounts instead of email string

(how do I do this correctly and how do I test it? I tried to use any auth method using the devcontainer but didn't manage to get it working.)

[ ] cli cmds?

Screenshots
Single approval

Multi approval

Verification

[ ] unit tests

[x] single approval
[x] multi approval
[ ] missing approval (not working, could use help if even possible)

[ ] e2e tests

[ ] tbd... (suggestions welcome)

Managed to get the core functionality working and looking pretty decent I think. However, I'm a bit stuck on authentication and linking the approvals to users or groups. Would appreciate some help if anyone is able.


Request: Integrate with IDE options + Workspace Classes

Did you know through the URL you can customise the editor, class and some other stuff?
Would be cool to be able to open a workspace through the raycast extension using these URL options.
You can see some of them here: https://github.com/gitpod-io/website/pull/3377/files
Have a play, maybe it could be integrated somehow? 😍

Hey @loujaybee, Ohh wow! This is amazing and a NEEDED ONE!! We certainly were thinking of adding this, thank you so much for pointing us to this 🧡🧡
This'll definitely be present in the next release along with "user preferences" to set a default IDE type within the raycast extension itself 🚀

@Siddhant-K-code, I tried it with the documentation added in this PR

With showOptions=true
https://gitpod.io/?showOptions=true&useLatest=true&editor=code-desktop&workspaceClass=g1-large#https://github.com/gitpod-io/website

With showOptions=false
https://gitpod.io/?showOptions=false&useLatest=true&editor=code-desktop&workspaceClass=g1-large#https://github.com/gitpod-io/website

But as you could see, both show the same results, I effectively do get to this page...instead we would want to directly get to this page....

Is this the intended behaviour for showOptions or am I missing out on something here 😅?

I really like this suggestion. If the extension could also always remember the options you used[^1], it'd be even more efficient!
[^1]: I imagine this could be implemented as follows: when you open a context, the extension would store the settings used as the default settings for the repository, allowing the user to change it later. When you open another branch with different settings, it would also store it, so that you can have different options even for branches - if the branch config would be the same, it would default to the repository settings and if those are not available, then to the global ones.

Aha, that's exactly what we're going forward with!! The things you suggested put things into picture in an even better way 🚀
This is what I've come up with after your suggestions and ideas!

There'd be a global preference which the user would be asked to choose after login which would be the default preference for all the repositories and their contexts as well

There'd be a preference at a repository level, which they can access by say (CMD + "w") or something similar or directly from the actions menu in Raycast

There'd be a preference at a context level (for individual branches, repos and issues), which users can access and configure by say (CMD + "w") or something similar or directly from the actions menu in Raycast!

The preferences would cascade as you suggested i.e.
a. If preferences are not set at a context level then preferences set at a repository level will be used
b. If preferences are not set at a repository level then preferences set at the global level will be used


How to deal with 3d image

Dear
I want to input a 3d(h×w×z) image. In order to process the segmentation (after using SLIC algorithm), how do I modify the FormFeatureExtraction CLASS、set the SLIC_FEATURES, and get the features.


How to keep the switch fixed

Hello
How to keep the switch fixed on the saved option after opening the software?

Hi, It is not yet possible to do this. I'll fix it in the next
update within a week. Thanks for answer
пн, 10 окт. 2022 г. в 05:14, rohi1386 @.***>:

Hello
How to keep the switch fixed on the saved option after opening the
software?
—
Reply to this email directly, view it on GitHub
https://github.com/chahohbily/slide_switcher/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVS2G4XDLG6OWIRCFUPH3HDWCM7VPANCNFSM6AAAAAARA3XD4E
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


input is broken under xonsh

xonsh is a Python-based alternative shell.  Unfortunately, running rtv under a xonsh session is only minimally usable.  All keypresses are echoed to the screen, overwriting the rtv textual UI.  Some keypresses are not acknowledged until you press return (e.g., movement keys).  Other functionality, such as pressing u to log in, doesn’t work at all.  I have no idea what the underlying issue is, but xonsh uses prompt_toolkit2 if available, falling back to readline, otherwise.  I don’t have these issues running other curses based apps under xonsh, just rtv so far.

Hi, thanks for posting an issue!
I was able to reproduce this with python 3.7.0 and xonsh/0.7.9  and it looks like xonsh simply isn't respecting curses settings. Specifically, curses.noecho() and curses.cbreak() are being set in the rtv initialization, but they're not taking effect for some reason. This is why you're seeing the keypress echos and you have to press the enter key.
I was able to reproduce this with a simple python script which should help narrow down the problem.
#!/usr/bin/env python3
import curses

try:
    stdscr = curses.initscr()
    curses.curs_set(0)
    curses.noecho()
    curses.cbreak()

    # Capture a keystroke and print it at coordinates (5, 5)
    # This works on all terminals except for xonsh
    while True:
        ch = stdscr.getch()
        stdscr.clear()
        stdscr.addch(5, 5, ch, curses.A_REVERSE)
        stdscr.refresh()

finally:
    curses.echo()
    curses.nocbreak()
    curses.endwin()

Yep, test case works.  It must be the Python curses wrapper that is at issue, then?  htop, newsboat, etc. work fine, but your test case, rtv, and my tic-tac-toe program don’t work.

Turns out this is a known issue in xonsh.  The solution as listed there is to add to your .xonshrc:
from xonsh.commands_cache import predict_false
__xonsh_commands_cache__.threadable_predictors['rtv'] = predict_false

(Adding other curses apps in the same way seems to fix them as well, such as newsboat.)


[8.x] Fix preg_quote() add missing delimiter parameter

App\Models\User::query()->updateOrCreate(['email' =><EMAIL_ADDRESS>['/some/evil/slashes/' => ''])

With above code will cause a PHP Warning:  preg_grep(): Unknown modifier warning.
Because preg_quote() needs a optional parameter delimiter to escape the slash.
ref: https://www.php.net/manual/en/function.preg-quote.php

Why would you pass slashes in your column name?

Why would you pass slashes in your column name?

I'm just a little bit disappointed when I accidentally passed some slashes, and got a php warning which says Unknown modifier.

Why would you pass slashes in your column name?

And why we use preg_quote()?
If we are not responsible to validate user input, why we need to "guard attributes"?

I'm just a little bit disappointed when I accidentally passed some slashes, and got a php warning which says Unknown modifier.

Why would you pass slashes in your column name?

And why we use preg_quote()?
If we are not responsible to validate user input, why we need to "guard attributes"?


DBZ-6076: Add support for custom SourceInfoStructMaker for adding new fields to source field

Added support to use custom connector config using custom task.

@adasari Hi, I converted the PR to the draft as I suppose this is just a first step, not the actual implementation. Am I right?

@adasari OK, in this case it would be better to add a new config option that would containe the class name of the custom structmaker and if present then instantiate it and pass the connector config to it.
It would be similar to what we do with topic.naming.strategy.

@jpechane Please review the changes. i will raise PRs to other repos when these changes are ok.

Ping

Added test to postgres connector.

@adasari Applied, thanks a lot!

 jpechane force-pushed the DBZ-6076 branch 2 times, most recently from  28d0430  to  f5b91dd   Compare   June 14, 2023 23:11

@adasari how did you implement writing to this custom SourceInfo field as the connector handles events?

 jpechane force-pushed the DBZ-6076 branch 2 times, most recently from  28d0430  to  f5b91dd   Compare   June 14, 2023 23:11

@adasari how did you implement writing to this custom SourceInfo field as the connector handles events?

By custom SourceInfoStructMaker. Reference implementation is https://github.com/debezium/debezium/blob/7d6b4af1dea3e7b0cb6e9abbc590427952814de6/debezium-connector-postgres/src/test/java/io/debezium/connector/postgresql/CustomPostgresSourceInfoStructMaker.java#L19

Apologies, maybe I misunderstood what you were using this for. To explain a bit more what I would like to do - there's an additional field that shows up in the MySQL binlog data, and I'd like to extract that into the SourceInfo at the time of handling an event. As far as I can tell, there is not a way to do that.
To confirm and say it another way - what you are showing with the reference implementation is how to add a static field to the source info correct?

You can use it to add static field or dynamic field based on other SourceInfo fields. PostgresSourceInfoStructMaker#struct has SourceInfo only.

Apologies, maybe I misunderstood what you were using this for. To explain a bit more what I would like to do - there's an additional field that shows up in the MySQL binlog data, and I'd like to extract that into the SourceInfo at the time of handling an event. As far as I can tell, there is not a way to do that.
To confirm and say it another way - what you are showing with the reference implementation is how to add a static field to the source info correct?

Q:: is bin log data is present in SourceRecord ?
Implementation ideas:

Use custom SourceInfoStructMaker if new field of source info is either static or dynamic based on other source info fields.
Use SMT if it is  new field is already part of SourceRecord
SMT can be overkill if you regenerate the schema. If SMT is a overkill in your case, Go with hybrid approach.
a. Use custom SourceInfoStructMaker to add the field to source info schema and default value (like -1 etc)
b. Use SMT or custom ConnectorTask of doPoll () implementation that fills new field from SourceRecord fields.

Please evaluate all the options and select that is suitable for your use case.


Add escrow payment example

I guess the format tool didn't work XD

@supl Sorry for the formatting issues. I already said last week but when this happens. It is better to just be straight with me and tell me "go fix your formatting!" :) because it will save you a lot of time making all of these review comments.
@feeblefakie I added this problem to the PR guidelines as well.


Upgrade github actions node version

Github actions have started using node 16 and the usage of old version is leading to the following warning:

More information on what needs to be done can be found in this github blog

Github actions have started using node 16 and the usage of old version is leading to the following warning:
More information on what needs to be done can be found in this github blog

Thanks for report

HI @keerthanak-tw. I will love to work on this issue. Can you assign this to me?

HI @keerthanak-tw. I will love to work on this issue. Can you assign this to me?

Sure! go ahead :fire:

this issue is still open

@vczb I have upgraded and the ci workflow passed successfully. Please have a look at PR #69

@vczb I have upgraded and the ci workflow passed successfully. Please have a look at PR #69

Great job! :rocket:


Fix topic owner check while namespace bundles cache invalidate.

Motivation
Currently, when namespace bundles split happens, namespace bundles cache will be invalidated. If producer or consumer try to connect to a topic which belongs to an exists bundle and the broker owned the exists bundle invalidate namespace bundles cache, producer and consumer will always connect failed with error log:
org.apache.pulsar.broker.service.BrokerServiceException$ServiceUnitNotReadyException: Namespace bundle for topic (persistent://platform/im/operationLog.addSession-partition-0) not served by this instance. Please redo the lookup. Request is denied: namespace=platform/im

Following steps can reproduce the problem:

Start a pulsar cluster(>= 2 brokers)
Create a namespace with some bundles(>= 2), bundles need be owned by different broker
Create some topics and do lookup request

Suppose after above steps, you have 2 topic(topic-1 with bundle-1 owned by broker-1 and topic-2 with bundle-2 owned by broker-2)
Now,  split bundle-1 and then create a PulsarClient using service url of broker-1 as pulsar url, then create a consumer with topic-2, ServiceUnitNotReadyException will appear.
I have added a unit test for reproduce this issue on master branch and cover the change of this PR.
Verifying this change
Added unit tests
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

run java8 tests
run integration tests

retest this please

run cpp tests

run java8 tests
run integration tests

run java8 tests


[SE-0365] Fix #64757: Unexpected "Implicit use of 'self' in closure" error in closure nested in result builder

This PR fixes an issue with the implementation of SE-0365, where the following code would unexpectedly emit an error:
@resultBuilder
struct VoidBuilder {
    static func buildBlock() -> Void { }
    static func buildPartialBlock<T>(first: T) -> Void { }
    static func buildPartialBlock<T>(accumulated: Void, next: T) -> Void { }
}

final class EscapingWrapper {
    static func wrapper(_ closure: @escaping () -> Void) {
        closure()
    }
}

final class Sample {
    @VoidBuilder
    var void: Void {
        EscapingWrapper.wrapper { [weak self] in
            guard let self else { return } // Unexpected error: Implicit use of 'self' in closure; use 'self.' to make capture semantics explicit
        }
    }
}

Fixes #64757.
Please review: @xedin

@ahoppen Looks like this is the issue here https://github.com/apple/swift/blob/main/lib/Sema/ConstraintSystem.cpp#L7112. Should this be set only in code completion mode?

Thanks for the review and suggestion @xedin.
In https://github.com/apple/swift/pull/64786/commits/10878e8aba614e0b10c837e8bdd2efc83e87a74a I updated the condition you sent to also include isForCodeCompletion() -- is that about what you had in mind?
The tests seem to pass locally after I made this change.

@calda I haven't look at where this flag gets set but I was hoping that this check you added code be moved there so we end up without this option if solver is not in code completion mode...

Thanks @xedin, that makes sense. I moved the change up to the callsite of the method that configures that option. All the tests pass still with this change.

@ahoppen WDYT?

@swift-ci please test

Sure @xedin, here you go: https://github.com/apple/swift/pull/64786/commits/7c78ad2860dc96d53d1386e3eb83f497c7bc8b2b

@swift-ci Please SourceKit stress test

@swift-ci please test


Calendar icon showing different emoji

Issue:
When trying to use the "calendar" icon, it is replaced by a non-db calendar emoji.
Media:
Here's how I have implemented the calendar icon in my code (and also another icon for comparison)

and here is how it appears:
Calendar:

Multiple Tickets (shows correctly):

Other things I have tried:

Importing DbIcon and using that component instead but there is no difference.
Using scss mixin version of the icon, but copying the example mixin code gives me a syntax error. Phind explanation.

Stackoverflow:
Possibly related but there is so fonts/db-ui in node modules so I don't know how to do this for db-ui icons.

@ma8642 thanks a lot for your request. Does a 404 / not found come up in your network tab in case of trying to display the calendar icon?

No, no 404s and nothing in the network tab about fonts or icons.

@mfranzke No, no 404s and nothing in the network tab about fonts or icons.

Solution: I updated my db-ui version to 0.28.0 in the package.json and now I am able to use the icon!


conhost.exe crash after ERROR_SHARING_VIOLATION exception when using dwShareFlags=0 screen buffers

Environment
Windows build number: 10.0.18362.418
Windows cmd.exe version: 10.0.18362.1
Windows conhost.exe version: 10.0.18362.1

Steps to reproduce
Build this program as C or C++ in Visual Studio, and run it manually from the command line in a cmd.exe window:
#include <stdio.h>
#include <windows.h>

int main(int argc, char** argv) {
	const HANDLE in = GetStdHandle(STD_INPUT_HANDLE);
	const HANDLE out = GetStdHandle(STD_OUTPUT_HANDLE);
	const HANDLE csb = CreateConsoleScreenBuffer(GENERIC_READ | GENERIC_WRITE, 0, NULL, CONSOLE_TEXTMODE_BUFFER, NULL);
	const BOOL success = SetConsoleActiveScreenBuffer(csb);
	char buffer[1];
	DWORD dwRead = 0;
	ReadFile(in, buffer, sizeof(buffer), &dwRead, NULL); // Fails with GetLastError() == ERROR_SHARING_VIOLATION (makes sense)
	const BOOL success2 = SetConsoleActiveScreenBuffer(out);
	return 0;
}

Expected behavior (as on Windows 7)
The program quickly exits (edit: after hitting enter!) and returns the user to the command prompt.
Actual behavior (Windows 10)
The program exits, conhost.exe throws an exception and then crashes, causing the terminal window to close.  An adplus log for conhost.exe is attached, but some excerpts:
ADPlus_log_34e8_2019-10-15_17-25-27-407.log
Initial choking on ERROR_SHARING_VIOLATION
...
0:003> g
onecore\windows\core\console\open\src\server\objectheader.cpp(58)\conhost.exe!00007FF6EAD2B3F3: (caller: 00007FF6EAD5C77C) ReturnHr(1) tid(3300) 80070020 The process cannot access the file because it is being used by another process.
onecore\windows\core\console\open\src\host\readdatacooked.cpp(81)\conhost.exe!00007FF6EAD5C798: (caller: 00007FF6EAD515F1) Exception(1) tid(3300) 80070020 The process cannot access the file because it is being used by another process.

(20b4.3300): C++ EH exception - code e06d7363 (first chance)
FirstChance_eh_CPlusPlusEH
...
Call stack below ---
 # ... : Call Site
00 ... : KERNELBASE!RaiseException+0x69
01 ... : ucrtbase!CxxThrowException+0xad
02 ... : conhost!wil::details::ThrowResultExceptionInternal+0x55
03 ... : conhost!wil::details::ReportFailure+0x220f8
04 ... : conhost!wil::details::ReportFailure_Hr+0x44
05 ... : conhost!wil::details::in1diag3::Throw_Hr+0x26
06 ... : conhost!COOKED_READ_DATA::COOKED_READ_DATA+0x154
07 ... : conhost!std::make_unique<COOKED_READ_DATA,InputBuffer * __ptr64,INPUT_READ_HANDLE_DATA * __ptr64,SCREEN_INFORMATION & __ptr64,__int64,unsigned short * __ptr64,unsigned long const & __ptr64,CommandHistory * __ptr64 const & __ptr64,std::basic_string_view<unsigned short,std::char_traits<unsigned short> > const & __ptr64,0>+0xad
08 ... : conhost!_ReadLineInput+0x101
09 ... : conhost!DoReadConsole+0x14a
0a ... : conhost!ApiRoutines::ReadConsoleAImpl+0x9a
0b ... : conhost!ApiDispatchers::ServerReadConsole+0x3f7
0c ... : conhost!ConsoleIoThread+0x20c9f
0d ... : KERNEL32!BaseThreadInitThunk+0x14
0e ... : ntdll!RtlUserThreadStart+0x21

(20b4.3300): C++ EH exception - code e06d7363 (first chance)
FirstChance_eh_CPlusPlusEH
...
Call stack below ---
 # ... : Call Site
00 ...  : KERNEL32!BaseThreadInitThunk+0x14
10 ... : ntdll!RtlUserThreadStart+0x21

onecore\windows\core\console\open\src\host\stream.cpp(524)\conhost.exe!00007FF6EAD528B2: (caller: 00007FF6EAD519EE) ReturnHr(2) tid(3300) 80070020 The process cannot access the file because it is being used by another process.
onecore\windows\core\console\open\src\host\readdatacooked.cpp(81)\conhost.exe!00007FF6EAD5C798: (caller: 00007FF6EAD515F1) Exception(1) tid(3300) 80070020 The process cannot access the file because it is being used by another process.

Access violation on cleanup
(20b4.3300): Access violation - code c0000005 (first chance)
FirstChance_av_AccessViolation
...
Call stack below ---
 # ... : Call Site
00 ... : conhost!ConsoleObjectHeader::FreeIoHandle+0x4
01 ... : conhost!ConsoleHandleData::_CloseOutputHandle+0x2c
02 ... : conhost!IoDispatchers::ConsoleCloseObject+0x48
03 ... : conhost!ConsoleIoThread+0x248
04 ... : KERNEL32!BaseThreadInitThunk+0x14
05 ... : ntdll!RtlUserThreadStart+0x21
Creating C:\dumps\20191015_172527_Crash_Mode\MINIDUMP_FirstChance_av_AccessViolation_conhost.exe__34e8_2019-10-15_17-25-40-330_20b4.dmp - mini user dump
Dump successfully written

(20b4.3300): Access violation - code c0000005 (!!! second chance !!!)
SecondChance_av_AccessViolation
...
Call stack below ---
 # ... : Call Site
00 ... : conhost!ConsoleObjectHeader::FreeIoHandle+0x4
01 ... : conhost!ConsoleHandleData::_CloseOutputHandle+0x2c
02 ... : conhost!IoDispatchers::ConsoleCloseObject+0x48
03 ... : conhost!ConsoleIoThread+0x248
04 ... : KERNEL32!BaseThreadInitThunk+0x14
05 ... : ntdll!RtlUserThreadStart+0x21
Creating C:\dumps\20191015_172527_Crash_Mode\FULLDUMP_SecondChance_av_AccessViolation_conhost.exe__34e8_2019-10-15_17-25-40-396_20b4.dmp - mini user dump
Dump successfully written

Workarounds

Pass FILE_SHARE_READ | FILE_SHARE_WRITE to CreateConsoleScreenBuffer's second parameter, despite the docs stating that "This parameter can be zero".
Don't read stdin while an unshared screen buffer is active
Use Windows 7

Yeah, that's a crazy one. We throw an exception trying to close an object that was never opened.
Relevant snippets:
https://github.com/microsoft/terminal/blob/01c0736843a0740a688f3772bf87b26cf87aea2e/src/server/ObjectHeader.cpp#L48-L54
https://github.com/microsoft/terminal/blob/01c0736843a0740a688f3772bf87b26cf87aea2e/src/server/ObjectHeader.cpp#L95
Triage ongoing.

@miniksa fyi I've compiled this for you, ping me for the EXE

Welp, it was fine on conhostv1.dll. So it's clearly my fault. Digging.

I found the issues and am now working on a proposed solution.
I introduced this when I refactored the server connection handling in the console host between RS1 (1607) and RS2 (1703).
An additional workaround is to use the legacy console. However, I'm drafting a solution for 20H1.


ETA for v1 and meaning of "alpha" version

Hello J2CL team,
I have a couple of questions related to the following caveats/disclaimers in the documentation page:

J2CL is production ready and actively used by many of Google's products, but the process of adapting workflows and tooling for the open-source version is not yet finalized...

J2CL is not an official Google product and is currently in 'alpha' release for developer preview.

Can you provide an ETA for the release of beta and, more importantly, official v1?

Given the first quote above, can we assume that the "alpha" label only refers to the missing tooling while the quality of the generated JS code can be considered production-ready? That is, if one was able to put together the necessary tooling/build workflow, can one rely on the generated JS code for production purposes?

Thank you.

Given the first quote above, can we assume that the "alpha" label only refers to the missing tooling while the quality of the generated JS code can be considered production-ready? That is, if one was able to put together the necessary tooling/build workflow, can one rely on the generated JS code for production purposes?

Exactly. The code is production ready and battle tested with Google Apps for years. Only open-source tooling is missing some workflows.

Can you provide an ETA for the release of beta and, more importantly, official v1?

At the moment we are only planning to do dated releases (which should start soon) instead of semantic versioning like v1 and make more tools work over time.
Unfortunately I cannot give a timeline for all tools to be ready since our work for open-source tooling on and off

Thank you, Goktug.
If I may, I'd like to ask а couple of follow-ups before closing the issue:

Do you have a plan/roadmap about how to release improvements to the transpiler itself? That is, if we put the tooling to the side, do you plan to have regular releases with improvements in the transpiler?

Is this version of J2CL (ignore the tooling) the same as the one used inside Google? If not, can you give us a rough idea of how the two differ?

Is this version of J2CL (ignore the tooling) the same as the one used inside Google? If not, can you give us a rough idea of how the two differ?

The github repo is updated at the same time as our internal repo. The versions are exactly the same. There are only minor differences  in our integration with internal tooling but those are not related to the transpiler per se.
Tooling on the open source part of our project would definitely benefit from community contributions.

Do you have a plan/roadmap about how to release improvements to the transpiler itself? That is, if we put the tooling to the side, do you plan to have regular releases with improvements in the transpiler?

Like @rluble pointed; all our improvements for released code are in sync and you are getting the improvement at the same time as Google gets.

@gkdn I am currently authoring a framework that integrates with J2CL, thank you for all of your hard work
as you prepare for, and begin to implement, this release timeline, is there any way we could get a wiki page up, or some kind of tracker to see progress/roadmap items?

Added https://github.com/google/j2cl/issues/93


Only clear controller when environment is prod

Only clear controller when environment is prod

What about other envs?

@elfet: in other envs we need to use app_*, profiler toolbar and many thing that we don't have in production env. So we need to make sure the front controller for other envs is existing


GenericFile (now GenericWork) thumbnail_spec.rb

** DO NOT MERGE YET ***
The changes in this PR allow the tests to run but they are all failing to find the thumbnail of the Work.
If I save_and_open the page I see that the HTML structure is correct, but that the path for the image in the src attribute is not. Instead of the expected /downloads/someid?file=thumbnail I am seeing /assets/work-ff055336041c3f7d310ad69109eda4a887b16ec501f35afc0a547c4adb97ee72.png as the src for the thumbnail.
If I run the application the correct value is set in the src attribute (i.e. /downloads/someid?file=thumbnail)
Any ideas?

@hectorcorrea looks like rubocop is yelling.

@cam156 good catch. I've taken care of the Rubocop warnings.


[DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated

When running on webpack 5.1.0 the following deprecation message is shown:
~/MyDev/ljs_app/trunk/desktop/ttr/web $ node --trace-deprecation node_modules/webpack/bin/webpack.js
(node:19838) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
	Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
	Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    at ImageminPlugin._callee2$ (/Users/doberkofler/MyDev/ljs_app/trunk/desktop/ttr/web/node_modules/imagemin-webpack-plugin/dist/index.js:264:48)
    at tryCatch (/Users/doberkofler/MyDev/ljs_app/trunk/desktop/ttr/web/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/Users/doberkofler/MyDev/ljs_app/trunk/desktop/ttr/web/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:296:22)
    at Generator.prototype.<computed> [as next] (/Users/doberkofler/MyDev/ljs_app/trunk/desktop/ttr/web/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:114:21)
    at step (/Users/doberkofler/MyDev/ljs_app/trunk/desktop/ttr/web/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /Users/doberkofler/MyDev/ljs_app/trunk/desktop/ttr/web/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

I was just wondering, if this issue might get fixed or rather not?

It's probably better to change to image-minimizer-webpack-plugin now...

Yep, please migrate on image-minimizer-webpack-plugin


_WD_Cookies() added DELETEALL

using:
Func DemoCookies()
	_WD_Navigate($sSession, "http://google.com")
	Local $sNID = _WD_Cookies($sSession, 'Get', 'NID')
	ConsoleWrite("- Cookie NID : " & $sNID & @CRLF)

	Local $sName = "Testname"
	Local $sValue = "TestValue"

	; create JSON string for cookie
	Local $sCookie = _WD_JsonCookie($sName, $sValue)

	ConsoleWrite("- adding cookie" & @CRLF)
	_WD_Cookies($sSession, 'add', $sCookie)

	ConsoleWrite("- checking cookie" & @CRLF)
	Local $sResult = _WD_Cookies($sSession, 'get', $sName)

	; compare results in console
	ConsoleWrite("- Cookie added    : " & $sCookie & @CRLF)
	ConsoleWrite("- Cookie obtained : " & $sResult & @CRLF)

	; Delete all cookies
	_WD_Cookies($sSession, 'deleteall')

	Local $sAllCookies = _WD_Cookies($sSession, 'getall')
	ClipPut($sAllCookies)
	MsgBox(0, "$sAllCookies", $sAllCookies)

EndFunc   ;==>DemoCookies

I get:
{"value":[]}

btw.
When you merge this PR then I be able to provide extended DemoCookies() here: https://github.com/Danp2/au3WebDriver/pull/194

After rethinking I was able to added this demo here and now.

@mlipok If you test with Firefox, then the results are what I was expecting. Since some people may already be depending on this functionality, I would suggest that we change the existing code to something like
$sResponse = __WD_Delete($_WD_BASE_URL & ":" & $_WD_PORT & "/session/" & $sSession & "/cookie" & ($sOption <> '') ? "/" & $sOption : "")

so that it will work correctly for all browsers.

But for consistency with https://www.w3.org/TR/webdriver/#delete-all-cookies
I will stay also with DELETEALL support in this UDF.


[5.2] Lazy Eager Loading issue in LengthAwarePaginator collection

After upgrading to Laravel 5.2.41, I'm getting Method load does not exist exception while trying to call load() method in LengthAwarePaginator collection.
I found out Eloquent Builder.php paginate() method sets empty array if total count of the result set is zero. So LengthAwarePaginator converts the empty array into \Illuminate\Support\Collection which does not have load() method.
public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $page = null)
    {
        $page = $page ?: Paginator::resolveCurrentPage($pageName);

        $perPage = $perPage ?: $this->model->getPerPage();

        $query = $this->toBase();

        $total = $query->getCountForPagination();

        $results = $total ? $this->forPage($page, $perPage)->get($columns) : [];

        return new LengthAwarePaginator($results, $total, $perPage, $page, [
            'path' => Paginator::resolveCurrentPath(),
            'pageName' => $pageName,
        ]);
    }

Kindly return Eloquent empty collection instead of an empty array, so eager loading won't fail.

Can you give a code example for it?

@srmklive
To explain this scenario, I'm going to use posts and comments relationship.
For example, I have to fetch first 10 posts, but there are no posts in the table.
$posts = Post::paginate(10);

In Eloquent builder paginate() method,
$total = $query->getCountForPagination();

$results = $total ? $this->forPage($page, $perPage)->get($columns) : [];

In this scenario, $total will be zero and $results will be set as an empty array instead of Eloquent collection.
In LengthAwarePaginater, this empty array got converted into support collection.
My code to load comments for these posts using load() method is like below:
$posts->load('comments');

Now load() fails because the given collection is Support collection not an Eloquent collection.

Have you done it like this?
$posts = Post::with('comments')->paginate(10);

What results does the above line gives you?

@srmklive I know with() works to load relations. But in some cases, I have to load relations after obtaining the results

My suggestion would be that you utilize with to load relations. You can simply if the related data is empty or not. This is a better approach in my opinion:
@if (!empty($post->comments))

@endif

@srmklive  By using your way, it defeats the purpose of Eager loading.

@vigneshgurusamy without taking a closer look at the code, I tend to agree with you that it should return an Eloquent collection, not a Base collection. That said, you can always wrap the results in an Eloquent collection yourself.
You can just do $results = new Illuminate\Database\Eloquent\Collection($posts). This will convert it to an Eloquent collection whether it happens to be an array, or another collection.

@themsaid I'm getting this issue after your pull request #14389 merged (v5.2.41). This issue was not there until v5.4.39.
Can you take a look?

@jlem Thanks for the support.
Am I afraid, I can not do that since I need the results as LengthAwarePaginator object with Eloquent collection as a paginator collection.

Well the actual change occured in this PR: https://github.com/laravel/framework/pull/14188
Mine was to fix some issue with it but it looks like the original PR has caused another issue, will submit a fix in a minute.


chore: process tags in stream

The tags only get collected at the end for sorting.

Coverage remained the same at 100.0% when pulling 39fc392d4eb814b5f39b225bcbae1ce4ecd77959 on dinoboff:chore-stream into 6ed75edca43f0ed6b3c0e4b63ebc8c749168003d on ikhemissi:master.

Coverage remained the same at 100.0% when pulling 80c0d745c612b2369bff3b57075ce6c1d11753ff on dinoboff:chore-stream into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

Coverage remained the same at 100.0% when pulling 1c5cce2948b044c079cfb68f893099f030d89844 on dinoboff:chore-stream into e4e0eed105fd09a558f6ffe825ee75c30e4a7a6b on ikhemissi:master.

I didn't find any benefices (same time or peak memory).

Well, thank you very much for the contribution and for benchmarking the performance impact of the PR.
Sorry, I couldn't spare much time this week to do the benchmark myself.
Thanks again @dinoboff


Get-M365DSCComponentsForAuthenticationType

Microsoft PowerToys version
0.85
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
"InvalidOperation: You cannot call a method on a null-valued expression."
✔ Expected Behavior
Indications of the office version and components
❌ Actual Behavior
InvalidOperation: You cannot call a method on a null-valued expression.
Other Software
Windows 22H2 (19045.4957)
Microsoft® Word dla Microsoft 365 MSO (wersja 2409 kompilacji 16.0.18025.20030) 64-bitowa
Power Shell7.4.5

Can you please send a /bugreport so we can see if there's something in the logs?


[Issue]: __hadd(int x, int y) and __rhadd(int x, int y) is wrong

Problem Description
The calculation result of __hadd(int x, int y) and __rhadd(int x, int y)  is inconsistent with NV.
For example, to calculate __hadd(123, -789)，the result on Rocm is 1, but the result on NV is -666.
The following are the descriptions of the __hadd function by Rocm and NV respectively.
Rocm

NV

The functions described are the same, but the calculation results are very different
Operating System
Centos7
CPU
AMD Ryzen 9 5900HX with Radeon Graphics
GPU
AMD Instinct MI100
ROCm Version
ROCm 5.7.0
ROCm Component
clr
Steps to Reproduce
kernel function as follows
__global__ void kernel() {     int x = 123;     int y = -789;     auto res = __hadd(x, y);     printf("res %d\n", res); }
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
Used cuda 11.8 to compare

Hmm strange, thanks for reporting.
Will look into this.

Hmm strange, thanks for reporting. Will look into this.
Please take a look at the following functions, looking forward to your reply.
__hadd
__rhadd
__uhadd
__urhadd

I found a few bugs. Raised a patch internally to fix it.


change sort order button failed to work after updated to Obsidian 1.5.1

SYSTEM INFO:
Obsidian version: v1.5.1
Installer version: v1.4.16
with the following debug information:

it seems the addSorButton function has been updated in the 1.5.1
in 1.4.16, the addSortButton function was definded as the following:

The "Change Sort Order" does not respond to any clicks and not showing any popup window.
All the other controls work but great.
Is there anything I can do to fix the issue?
(I am on Obsidian v1.5.3 now)

Still an issue.


Applications not showing in menu

Hello, i have attempted to load Xored Trainer Launcher by placing it in the 'E' partition under "Apps" subfolder and editing the json file to look for apps in that location "E:\Apps\Xored" however while the log shows that it has queried that folder, it says that it failed.
i should advise that i am doing this on the xemu xbox emulator using the precompiled qcow2 hdd image.
this is my first time opening an issue, please let me know if i should add or remove things in future.

please see config.json file contents below:

{
"settings":
{
"network":
{
"enable": true,
"use_dhcp": true,
"static_ip": "<IP_ADDRESS>",
"static_gateway": "<IP_ADDRESS>",
"static_netmask": "<IP_ADDRESS>"
},
"ftp":
{
"enable": true,
"username": "xbox",
"password": "xbox",
"port": 21
},
"sntp":
{
"enable": true,
"port": 123,
"server": "<IP_ADDRESS>"
},
"mount":
{
"enable_f": false,
"enable_g": false
},
"logging":
{
"enable_overlay": true,
"overlay_duration_frames": 30,
"overlay_bg_alpha_int": 100
},
"homescreen":
{
"show_fps": false,
"show_ip": true
}
},
"menu":
[
{
"label": "Games",
"type": "scan",
"path": "F:\Games\,G:\Games"
},
{
"label": "Applications",
"type": "scan",
"path": "E:\Apps\Xored"
},
{
"label": "Launch DVD",
"type": "launch",
"path": "D:\default.xbe"
},
{
"label": "Settings",
"type": "settings"
},
{
"label": "Reboot",
"type": "reboot"
},
{
"label": "Power off",
"type": "shutdown"
},
{
"label": "Some stupid submenu",
"type": "submenu"
}
]
}

please see below for zip file with json file for testing as needed:
config.json.zip

You want the Path to point to E:\\Apps still, as it checks one level of subdirectories for files named default.xbe.

i have done that and tried again; no change:

{
"settings":
{
"network":
{
"enable": true,
"use_dhcp": true,
"static_ip": "<IP_ADDRESS>",
"static_gateway": "<IP_ADDRESS>",
"static_netmask": "<IP_ADDRESS>"
},
"ftp":
{
"enable": true,
"username": "xbox",
"password": "xbox",
"port": 21
},
"sntp":
{
"enable": true,
"port": 123,
"server": "<IP_ADDRESS>"
},
"mount":
{
"enable_f": false,
"enable_g": false
},
"logging":
{
"enable_overlay": true,
"overlay_duration_frames": 30,
"overlay_bg_alpha_int": 100
},
"homescreen":
{
"show_fps": false,
"show_ip": true
}
},
"menu":
[
{
"label": "Games",
"type": "scan",
"path": "F:\Games\,G:\Games"
},
{
"label": "Applications",
"type": "scan",
"path": "E:\Apps"
},
{
"label": "Launch DVD",
"type": "launch",
"path": "D:\default.xbe"
},
{
"label": "Settings",
"type": "settings"
},
{
"label": "Reboot",
"type": "reboot"
},
{
"label": "Power off",
"type": "shutdown"
},
{
"label": "Some stupid submenu",
"type": "submenu"
}
]
}


Generate TokenSyntax with SwiftSyntaxBuilderGeneration

Based on #485.
This PR ports the currently gyb-generated TokenSyntax to SwiftSyntaxBuilder's DSL as part of the ongoing effort to bootstrap SwiftSyntaxBuilder with SwiftSyntaxBuilderGeneration.

@swift-ci please test


x16-rom: 46 -> 47

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/X16Community/x16-rom/releases.
meta.description for x16-rom is: ROM file for CommanderX16 8-bit computer
meta.homepage for x16-rom is: https://github.com/X16Community/x16-rom
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 47 with grep in /nix/store/wzrsk30s842vw6afkifhjmnwr7cx9j7v-x16-rom-47
found 47 in filename of file in /nix/store/wzrsk30s842vw6afkifhjmnwr7cx9j7v-x16-rom-47

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
x16-rom
x16-run

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wzrsk30s842vw6afkifhjmnwr7cx9j7v-x16-rom-47 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A x16-rom https://github.com/r-ryantm/nixpkgs/archive/cc56d54530eaa0d51c8dd6e461d97b963269fb12.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/cc56d54530eaa0d51c8dd6e461d97b963269fb12#x16-rom

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wzrsk30s842vw6afkifhjmnwr7cx9j7v-x16-rom-47
ls -la /nix/store/wzrsk30s842vw6afkifhjmnwr7cx9j7v-x16-rom-47/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

x16-rom

Maintainer pings
cc @AndersonTorres for testing.

@NixOS/nixpkgs-merge-bot merge


Feat/update readme

This PR is meant to add details about the team behind Million to the website for people checking out the website to notice. Thid was inspired by the Kama UI "team" page
Screencast from 07-10-2023 02:18:09 PM.webm
Status

[ ] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: aidenybai:x: tobySolutionsYou have signed the CLA already but the status is still pending? Let us recheck it.


[Bug]: Loan Calculator form

🐞 Bug Report
📋 Description
Calculator form are not aligned properly
⚙ Steps to Reproduce
Steps to reproduce the behavior:

Go to loan page
Edit CSS

✔ Expected Behavior
It should be aligned properly in a same width.
❌ Actual Behavior
It is not aligned properly every field have different width.
📷 Screenshots

🖥 Environment (if applicable):

OS: (Windows)
Browser: (Chrome)

@skmirajulislam Please assign this issue to me:)

@skmirajulislam ??


component configuration for cloud-platform-live-0

Connects to https://github.com/ministryofjustice/kubernetes-investigations/pull/31

@kerin thanks, that's going to be needed in the future


Corrupt files

Please paste the output of the following command here: sudo edit-chroot -all
E: Couldn't download packages: adduser

#### Please describe your issue:
It says the adduser package is corrupt

#### If known, describe the steps to reproduce the issue:
1. Type: sudo sh ~/Downloads/crouton -t kde
And you're done! It just won't download the adduser package

@TheCheeper,
Please follow the instructions here: 'Common issues and reporting'
Hope this helps,
-DennisL


Reproduce an issue with merging last segment in a period

Hi,
I have a multi period live stream and, at some time shaka was stopping with an INVALID_SEGMENT_INDEX error.
I discovered that the issue was caused by the fact that when segment references are merged at the manifest change, some of the segments are skipped, considered to be duplicates of the previous received segments. This is true in general, but when the period changes, last segment is expanded to end of the period (in MpdUtils.fitSegmentReferences). This updated segment was not merged into the final segment list which was causing a gap.
I added a unit test that reproduce the issue and I also made a fix for it.

@joeyparrish @tdrews
Thanks for feedback.
Done! I hope I didn't miss anything.

Done.
Thank you.
Sorry for so much typos in 5 lines of code :)

No worries!  I'll run it through our buildbot now for one last check before we merge.  Thanks for contributing!


Support backwards navigation when creating resources

Is your feature request related to a problem? Please describe.
It's usual to make mistakes when creating resources. I'd love to see a 'go back' feature.
Describe the solution you'd like
When choosing something from the option list, there could be a 'go back' option. i.e.:
o Create
o Read
o Update
o Delete
o Go Back
Describe alternatives you've considered
A generic 'go back' key. i.e 'Q' or shortcut as 'CMD/CTRL + Q'
Many thanks!

100%, this would be fantastic. I have ctrl+c'd out of so many resource setups I've lost count 😂

Closing as dupe of: https://github.com/aws-amplify/amplify-cli/issues/6367