[BUG] test_dpp_reuse_broadcast_exchange failed

From a recent nightly test run:
[2024-01-03T17:41:18.525Z] FAILED ../../src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[true-5-parquet][DATAGEN_SEED=1704297021, INJECT_OOM, IGNORE_ORDER] - py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback.assertContains.
[2024-01-03T17:41:18.525Z] : java.lang.AssertionError: assertion failed: Could not find DynamicPruningExpression in the Spark plan
[2024-01-03T17:41:18.525Z] AdaptiveSparkPlan isFinalPlan=true
[2024-01-03T17:41:18.525Z] +- == Final Plan ==
[2024-01-03T17:41:18.525Z]    LocalTableScan <empty>, [key#37135, max(value)#37151L]
[2024-01-03T17:41:18.525Z] +- == Initial Plan ==
[2024-01-03T17:41:18.525Z]    Sort [key#37135 ASC NULLS FIRST, max(value)#37151L ASC NULLS FIRST], true, 0
[2024-01-03T17:41:18.525Z]    +- Exchange rangepartitioning(key#37135 ASC NULLS FIRST, max(value)#37151L ASC NULLS FIRST, 4), ENSURE_REQUIREMENTS, [plan_id=109491]
[2024-01-03T17:41:18.525Z]       +- HashAggregate(keys=[key#37135], functions=[max(value#37136L)], output=[key#37135, max(value)#37151L])
[2024-01-03T17:41:18.525Z]          +- Exchange hashpartitioning(key#37135, 4), ENSURE_REQUIREMENTS, [plan_id=109488]
[2024-01-03T17:41:18.525Z]             +- HashAggregate(keys=[key#37135], functions=[partial_max(value#37136L)], output=[key#37135, max#37199L])
[2024-01-03T17:41:18.525Z]                +- Union
[2024-01-03T17:41:18.525Z]                   :- Project [key#37054 AS key#37135, value#37140L AS value#37136L]
[2024-01-03T17:41:18.525Z]                   :  +- BroadcastHashJoin [key#37054], [key#37056], Inner, BuildRight, false
[2024-01-03T17:41:18.526Z]                   :     :- HashAggregate(keys=[key#37054], functions=[sum(value#37053)], output=[key#37054, value#37140L])
[2024-01-03T17:41:18.526Z]                   :     :  +- Exchange hashpartitioning(key#37054, 4), ENSURE_REQUIREMENTS, [plan_id=109473]
[2024-01-03T17:41:18.526Z]                   :     :     +- HashAggregate(keys=[key#37054], functions=[partial_sum(value#37053)], output=[key#37054, sum#37201L])
[2024-01-03T17:41:18.526Z]                   :     :        +- Project [value#37053, key#37054]
[2024-01-03T17:41:18.526Z]                   :     :           +- Filter (isnotnull(value#37053) AND (value#37053 > 0))
[2024-01-03T17:41:18.526Z]                   :     :              +- FileScan parquet spark_catalog.default.tmp_table_gw1_470723338_0[value#37053,key#37054,skey#37055] Batched: true, DataFilters: [isnotnull(value#37053), (value#37053 > 0)], Format: Parquet, Location: InMemoryFileIndex(50 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-git..., PartitionFilters: [isnotnull(key#37054), dynamicpruningexpression(key#37054 IN dynamicpruning#37196)], PushedFilters: [IsNotNull(value), GreaterThan(value,0)], ReadSchema: struct<value:int>
[2024-01-03T17:41:18.526Z]                   :     :                    +- SubqueryAdaptiveBroadcast dynamicpruning#37196, 0, true, Project [key#37056], [key#37056]
[2024-01-03T17:41:18.526Z]                   :     :                       +- AdaptiveSparkPlan isFinalPlan=false
[2024-01-03T17:41:18.526Z]                   :     :                          +- Project [key#37056]
[2024-01-03T17:41:18.526Z]                   :     :                             +- Filter ((((isnotnull(ex_key#37058) AND isnotnull(filter#37060)) AND (ex_key#37058 = 3)) AND (filter#37060 = 1458)) AND isnotnull(key#37056))
[2024-01-03T17:41:18.526Z]                   :     :                                +- FileScan parquet spark_catalog.default.tmp_table_gw1_470723338_1[key#37056,ex_key#37058,filter#37060] Batched: true, DataFilters: [isnotnull(ex_key#37058), isnotnull(filter#37060), (ex_key#37058 = 3), (filter#37060 = 1458), isn..., Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.526Z]                   :     +- BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [plan_id=109476]
[2024-01-03T17:41:18.526Z]                   :        +- Project [key#37056]
[2024-01-03T17:41:18.526Z]                   :           +- Filter ((((isnotnull(ex_key#37058) AND isnotnull(filter#37060)) AND (ex_key#37058 = 3)) AND (filter#37060 = 1458)) AND isnotnull(key#37056))
[2024-01-03T17:41:18.526Z]                   :              +- FileScan parquet spark_catalog.default.tmp_table_gw1_470723338_1[key#37056,ex_key#37058,filter#37060] Batched: true, DataFilters: [isnotnull(ex_key#37058), isnotnull(filter#37060), (ex_key#37058 = 3), (filter#37060 = 1458), isn..., Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.526Z]                   +- Project [key#37184, value#37187L]
[2024-01-03T17:41:18.526Z]                      +- BroadcastHashJoin [key#37184], [key#37188], Inner, BuildRight, false
[2024-01-03T17:41:18.526Z]                         :- HashAggregate(keys=[key#37184], functions=[sum(value#37183)], output=[key#37184, value#37187L])
[2024-01-03T17:41:18.526Z]                         :  +- Exchange hashpartitioning(key#37184, 4), ENSURE_REQUIREMENTS, [plan_id=109479]
[2024-01-03T17:41:18.526Z]                         :     +- HashAggregate(keys=[key#37184], functions=[partial_sum(value#37183)], output=[key#37184, sum#37203L])
[2024-01-03T17:41:18.526Z]                         :        +- Project [value#37183, key#37184]
[2024-01-03T17:41:18.526Z]                         :           +- Filter (isnotnull(value#37183) AND (value#37183 > 0))
[2024-01-03T17:41:18.526Z]                         :              +- FileScan parquet spark_catalog.default.tmp_table_gw1_470723338_0[value#37183,key#37184,skey#37185] Batched: true, DataFilters: [isnotnull(value#37183), (value#37183 > 0)], Format: Parquet, Location: InMemoryFileIndex(50 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-git..., PartitionFilters: [isnotnull(key#37184), dynamicpruningexpression(key#37184 IN dynamicpruning#37197)], PushedFilters: [IsNotNull(value), GreaterThan(value,0)], ReadSchema: struct<value:int>
[2024-01-03T17:41:18.526Z]                         :                    +- SubqueryAdaptiveBroadcast dynamicpruning#37197, 0, true, Project [key#37188], [key#37188]
[2024-01-03T17:41:18.526Z]                         :                       +- AdaptiveSparkPlan isFinalPlan=false
[2024-01-03T17:41:18.526Z]                         :                          +- Project [key#37188]
[2024-01-03T17:41:18.526Z]                         :                             +- Filter ((((isnotnull(ex_key#37190) AND isnotnull(filter#37192)) AND (ex_key#37190 = 3)) AND (filter#37192 = 1458)) AND isnotnull(key#37188))
[2024-01-03T17:41:18.526Z]                         :                                +- FileScan parquet spark_catalog.default.tmp_table_gw1_470723338_1[key#37188,ex_key#37190,filter#37192] Batched: true, DataFilters: [isnotnull(ex_key#37190), isnotnull(filter#37192), (ex_key#37190 = 3), (filter#37192 = 1458), isn..., Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.526Z]                         +- BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [plan_id=109482]
[2024-01-03T17:41:18.526Z]                            +- Project [key#37188]
[2024-01-03T17:41:18.526Z]                               +- Filter ((((isnotnull(ex_key#37190) AND isnotnull(filter#37192)) AND (ex_key#37190 = 3)) AND (filter#37192 = 1458)) AND isnotnull(key#37188))
[2024-01-03T17:41:18.526Z]                                  +- FileScan parquet spark_catalog.default.tmp_table_gw1_470723338_1[key#37188,ex_key#37190,filter#37192] Batched: true, DataFilters: [isnotnull(ex_key#37190), isnotnull(filter#37192), (ex_key#37190 = 3), (filter#37192 = 1458), isn..., Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.526Z]
[2024-01-03T17:41:18.526Z] 	at scala.Predef$.assert(Predef.scala:223)
[2024-01-03T17:41:18.526Z] 	at org.apache.spark.sql.rapids.ShimmedExecutionPlanCaptureCallbackImpl.assertContains(ShimmedExecutionPlanCaptureCallbackImpl.scala:170)
[2024-01-03T17:41:18.526Z] 	at org.apache.spark.sql.rapids.ShimmedExecutionPlanCaptureCallbackImpl.assertContains(ShimmedExecutionPlanCaptureCallbackImpl.scala:175)
[2024-01-03T17:41:18.526Z] 	at org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback$.assertContains(ExecutionPlanCaptureCallback.scala:76)
[2024-01-03T17:41:18.526Z] 	at org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback.assertContains(ExecutionPlanCaptureCallback.scala)
[2024-01-03T17:41:18.526Z] 	at sun.reflect.GeneratedMethodAccessor140.invoke(Unknown Source)
[2024-01-03T17:41:18.526Z] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2024-01-03T17:41:18.526Z] 	at java.lang.reflect.Method.invoke(Method.java:498)
[2024-01-03T17:41:18.526Z] 	at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
[2024-01-03T17:41:18.526Z] 	at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:374)
[2024-01-03T17:41:18.526Z] 	at py4j.Gateway.invoke(Gateway.java:282)
[2024-01-03T17:41:18.526Z] 	at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
[2024-01-03T17:41:18.526Z] 	at py4j.commands.CallCommand.execute(CallCommand.java:79)
[2024-01-03T17:41:18.526Z] 	at py4j.ClientServerConnection.waitForCommands(ClientServerConnection.java:182)
[2024-01-03T17:41:18.526Z] 	at py4j.ClientServerConnection.run(ClientServerConnection.java:106)
[2024-01-03T17:41:18.527Z] 	at java.lang.Thread.run(Thread.java:750)
[2024-01-03T17:41:18.527Z] FAILED ../../src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[true-5-orc][DATAGEN_SEED=1704297021, INJECT_OOM, IGNORE_ORDER] - py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback.assertContains.
[2024-01-03T17:41:18.527Z] : java.lang.AssertionError: assertion failed: Could not find DynamicPruningExpression in the Spark plan
[2024-01-03T17:41:18.527Z] AdaptiveSparkPlan isFinalPlan=true
[2024-01-03T17:41:18.527Z] +- == Final Plan ==
[2024-01-03T17:41:18.527Z]    LocalTableScan <empty>, [key#37628, max(value)#37644L]
[2024-01-03T17:41:18.527Z] +- == Initial Plan ==
[2024-01-03T17:41:18.527Z]    Sort [key#37628 ASC NULLS FIRST, max(value)#37644L ASC NULLS FIRST], true, 0
[2024-01-03T17:41:18.527Z]    +- Exchange rangepartitioning(key#37628 ASC NULLS FIRST, max(value)#37644L ASC NULLS FIRST, 4), ENSURE_REQUIREMENTS, [plan_id=111165]
[2024-01-03T17:41:18.527Z]       +- HashAggregate(keys=[key#37628], functions=[max(value#37629L)], output=[key#37628, max(value)#37644L])
[2024-01-03T17:41:18.527Z]          +- Exchange hashpartitioning(key#37628, 4), ENSURE_REQUIREMENTS, [plan_id=111162]
[2024-01-03T17:41:18.527Z]             +- HashAggregate(keys=[key#37628], functions=[partial_max(value#37629L)], output=[key#37628, max#37692L])
[2024-01-03T17:41:18.527Z]                +- Union
[2024-01-03T17:41:18.527Z]                   :- Project [key#37547 AS key#37628, value#37633L AS value#37629L]
[2024-01-03T17:41:18.527Z]                   :  +- BroadcastHashJoin [key#37547], [key#37549], Inner, BuildRight, false
[2024-01-03T17:41:18.527Z]                   :     :- HashAggregate(keys=[key#37547], functions=[sum(value#37546)], output=[key#37547, value#37633L])
[2024-01-03T17:41:18.527Z]                   :     :  +- Exchange hashpartitioning(key#37547, 4), ENSURE_REQUIREMENTS, [plan_id=111147]
[2024-01-03T17:41:18.527Z]                   :     :     +- HashAggregate(keys=[key#37547], functions=[partial_sum(value#37546)], output=[key#37547, sum#37694L])
[2024-01-03T17:41:18.527Z]                   :     :        +- Project [value#37546, key#37547]
[2024-01-03T17:41:18.527Z]                   :     :           +- Filter (isnotnull(value#37546) AND (value#37546 > 0))
[2024-01-03T17:41:18.527Z]                   :     :              +- FileScan orc spark_catalog.default.tmp_table_gw1_1272856583_0[value#37546,key#37547,skey#37548] Batched: true, DataFilters: [isnotnull(value#37546), (value#37546 > 0)], Format: ORC, Location: InMemoryFileIndex(50 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-git..., PartitionFilters: [isnotnull(key#37547), dynamicpruningexpression(key#37547 IN dynamicpruning#37689)], PushedFilters: [IsNotNull(value), GreaterThan(value,0)], ReadSchema: struct<value:int>
[2024-01-03T17:41:18.527Z]                   :     :                    +- SubqueryAdaptiveBroadcast dynamicpruning#37689, 0, true, Project [key#37549], [key#37549]
[2024-01-03T17:41:18.527Z]                   :     :                       +- AdaptiveSparkPlan isFinalPlan=false
[2024-01-03T17:41:18.527Z]                   :     :                          +- Project [key#37549]
[2024-01-03T17:41:18.527Z]                   :     :                             +- Filter ((((isnotnull(ex_key#37551) AND isnotnull(filter#37553)) AND (ex_key#37551 = 3)) AND (filter#37553 = 1458)) AND isnotnull(key#37549))
[2024-01-03T17:41:18.527Z]                   :     :                                +- FileScan orc spark_catalog.default.tmp_table_gw1_1272856583_1[key#37549,ex_key#37551,filter#37553] Batched: true, DataFilters: [isnotnull(ex_key#37551), isnotnull(filter#37553), (ex_key#37551 = 3), (filter#37553 = 1458), isn..., Format: ORC, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.527Z]                   :     +- BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [plan_id=111150]
[2024-01-03T17:41:18.527Z]                   :        +- Project [key#37549]
[2024-01-03T17:41:18.527Z]                   :           +- Filter ((((isnotnull(ex_key#37551) AND isnotnull(filter#37553)) AND (ex_key#37551 = 3)) AND (filter#37553 = 1458)) AND isnotnull(key#37549))
[2024-01-03T17:41:18.527Z]                   :              +- FileScan orc spark_catalog.default.tmp_table_gw1_1272856583_1[key#37549,ex_key#37551,filter#37553] Batched: true, DataFilters: [isnotnull(ex_key#37551), isnotnull(filter#37553), (ex_key#37551 = 3), (filter#37553 = 1458), isn..., Format: ORC, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.527Z]                   +- Project [key#37677, value#37680L]
[2024-01-03T17:41:18.527Z]                      +- BroadcastHashJoin [key#37677], [key#37681], Inner, BuildRight, false
[2024-01-03T17:41:18.527Z]                         :- HashAggregate(keys=[key#37677], functions=[sum(value#37676)], output=[key#37677, value#37680L])
[2024-01-03T17:41:18.527Z]                         :  +- Exchange hashpartitioning(key#37677, 4), ENSURE_REQUIREMENTS, [plan_id=111153]
[2024-01-03T17:41:18.527Z]                         :     +- HashAggregate(keys=[key#37677], functions=[partial_sum(value#37676)], output=[key#37677, sum#37696L])
[2024-01-03T17:41:18.527Z]                         :        +- Project [value#37676, key#37677]
[2024-01-03T17:41:18.527Z]                         :           +- Filter (isnotnull(value#37676) AND (value#37676 > 0))
[2024-01-03T17:41:18.527Z]                         :              +- FileScan orc spark_catalog.default.tmp_table_gw1_1272856583_0[value#37676,key#37677,skey#37678] Batched: true, DataFilters: [isnotnull(value#37676), (value#37676 > 0)], Format: ORC, Location: InMemoryFileIndex(50 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-git..., PartitionFilters: [isnotnull(key#37677), dynamicpruningexpression(key#37677 IN dynamicpruning#37690)], PushedFilters: [IsNotNull(value), GreaterThan(value,0)], ReadSchema: struct<value:int>
[2024-01-03T17:41:18.527Z]                         :                    +- SubqueryAdaptiveBroadcast dynamicpruning#37690, 0, true, Project [key#37681], [key#37681]
[2024-01-03T17:41:18.527Z]                         :                       +- AdaptiveSparkPlan isFinalPlan=false
[2024-01-03T17:41:18.527Z]                         :                          +- Project [key#37681]
[2024-01-03T17:41:18.527Z]                         :                             +- Filter ((((isnotnull(ex_key#37683) AND isnotnull(filter#37685)) AND (ex_key#37683 = 3)) AND (filter#37685 = 1458)) AND isnotnull(key#37681))
[2024-01-03T17:41:18.527Z]                         :                                +- FileScan orc spark_catalog.default.tmp_table_gw1_1272856583_1[key#37681,ex_key#37683,filter#37685] Batched: true, DataFilters: [isnotnull(ex_key#37683), isnotnull(filter#37685), (ex_key#37683 = 3), (filter#37685 = 1458), isn..., Format: ORC, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.527Z]                         +- BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [plan_id=111156]
[2024-01-03T17:41:18.527Z]                            +- Project [key#37681]
[2024-01-03T17:41:18.527Z]                               +- Filter ((((isnotnull(ex_key#37683) AND isnotnull(filter#37685)) AND (ex_key#37683 = 3)) AND (filter#37685 = 1458)) AND isnotnull(key#37681))
[2024-01-03T17:41:18.527Z]                                  +- FileScan orc spark_catalog.default.tmp_table_gw1_1272856583_1[key#37681,ex_key#37683,filter#37685] Batched: true, DataFilters: [isnotnull(ex_key#37683), isnotnull(filter#37685), (ex_key#37683 = 3), (filter#37685 = 1458), isn..., Format: ORC, Location: InMemoryFileIndex(1 paths)[file:/home/jenkins/agent/workspace/jenkins-rapids_integration-dev-gith..., PartitionFilters: [], PushedFilters: [IsNotNull(ex_key), IsNotNull(filter), EqualTo(ex_key,3), EqualTo(filter,1458), IsNotNull(key)], ReadSchema: struct<key:int,ex_key:int,filter:int>
[2024-01-03T17:41:18.528Z]
[2024-01-03T17:41:18.528Z] 	at scala.Predef$.assert(Predef.scala:223)
[2024-01-03T17:41:18.528Z] 	at org.apache.spark.sql.rapids.ShimmedExecutionPlanCaptureCallbackImpl.assertContains(ShimmedExecutionPlanCaptureCallbackImpl.scala:170)
[2024-01-03T17:41:18.528Z] 	at org.apache.spark.sql.rapids.ShimmedExecutionPlanCaptureCallbackImpl.assertContains(ShimmedExecutionPlanCaptureCallbackImpl.scala:175)
[2024-01-03T17:41:18.528Z] 	at org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback$.assertContains(ExecutionPlanCaptureCallback.scala:76)
[2024-01-03T17:41:18.528Z] 	at org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback.assertContains(ExecutionPlanCaptureCallback.scala)
[2024-01-03T17:41:18.528Z] 	at sun.reflect.GeneratedMethodAccessor140.invoke(Unknown Source)
[2024-01-03T17:41:18.528Z] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2024-01-03T17:41:18.528Z] 	at java.lang.reflect.Method.invoke(Method.java:498)
[2024-01-03T17:41:18.528Z] 	at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
[2024-01-03T17:41:18.528Z] 	at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:374)
[2024-01-03T17:41:18.528Z] 	at py4j.Gateway.invoke(Gateway.java:282)
[2024-01-03T17:41:18.528Z] 	at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
[2024-01-03T17:41:18.528Z] 	at py4j.commands.CallCommand.execute(CallCommand.java:79)
[2024-01-03T17:41:18.528Z] 	at py4j.ClientServerConnection.waitForCommands(ClientServerConnection.java:182)
[2024-01-03T17:41:18.528Z] 	at py4j.ClientServerConnection.run(ClientServerConnection.java:106)
[2024-01-03T17:41:18.528Z] 	at java.lang.Thread.run(Thread.java:750)
[2024-01-03T17:41:18.528Z] = 2 failed, 20760 passed, 933 skipped, 417 xfailed, 388 xpassed, 9504 warnings in 6656.39s (1:50:56) =

From CI, this test failure occurred in Spark 3.5.0

I was able to replicate both failures on Spark 3.2.4, 3.3.3, 3.4.0, and 3.5.0 (all versions of Spark that support AQE + DPP)

Basically by the plan output here, it looks like this is an AQE optimization that is turning the entire plan into a LocalTableScan
E                   py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback.assertContains.
E                   : java.lang.AssertionError: assertion failed: Could not find DynamicPruningExpression in the Spark plan
E                   AdaptiveSparkPlan isFinalPlan=true
E                   +- == Final Plan ==
E                      LocalTableScan <empty>, [key#2006, max(value)#2017L]
E                   +- == Initial Plan ==
E                   +- == Initial Plan ==
E                      Sort [key#2006 ASC NULLS FIRST, max(value)#2017L ASC NULLS FIRST], true, 0
E                      +- Exchange rangepartitioning(key#2006 ASC NULLS FIRST, max(value)#2017L ASC NULLS FIRST, 4), ENSURE_REQUIREMENTS, [plan_id=5302]
E                         +- HashAggregate(keys=[key#2006], functions=[max(value#2007L)], output=[key#2006, max(value)#2017L])
E                            +- Exchange hashpartitioning(key#2006, 4), ENSURE_REQUIREMENTS, [plan_id=5299]
E                               +- HashAggregate(keys=[key#2006], functions=[partial_max(value#2007L)], output=[key#2006, max#2023L])
E                                  +- Union
...

Basically by the plan output here, it looks like this is an AQE optimization that is turning the entire plan into a LocalTableScan

E                   py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.spark.sql.rapids.ExecutionPlanCaptureCallback.assertContains.

E                   : java.lang.AssertionError: assertion failed: Could not find DynamicPruningExpression in the Spark plan

E                   AdaptiveSparkPlan isFinalPlan=true

E                   +- == Final Plan ==

E                      LocalTableScan <empty>, [key#2006, max(value)#2017L]

E                   +- == Initial Plan ==

E                   +- == Initial Plan ==

E                      Sort [key#2006 ASC NULLS FIRST, max(value)#2017L ASC NULLS FIRST], true, 0

E                      +- Exchange rangepartitioning(key#2006 ASC NULLS FIRST, max(value)#2017L ASC NULLS FIRST, 4), ENSURE_REQUIREMENTS, [plan_id=5302]

E                         +- HashAggregate(keys=[key#2006], functions=[max(value#2007L)], output=[key#2006, max(value)#2017L])

E                            +- Exchange hashpartitioning(key#2006, 4), ENSURE_REQUIREMENTS, [plan_id=5299]

E                               +- HashAggregate(keys=[key#2006], functions=[partial_max(value#2007L)], output=[key#2006, max#2023L])

E                                  +- Union

...

I guess it determined via the join that this would return empty

So basically after some debugging, I think one the subqueries returned an empty result, so that was short-circuited by AQE to return a LocalTableScan <empty>. This happens on both the CPU and GPU, but of course this means that the result did not contain a DynamicPruningExpression, so it looks like the solution here is that we need update the test logic to be something like an either/or capture. Either there is a single LocalTableScanExec or the GPU plan needs to contain DynamicPruningExpression.

it looks like the solution here is that we need update the test logic to be something like an either/or capture

I'm not sure that's the best fix.  The point of this test is to check handling of DPP, and the problem here is that the datagen happened to produce inputs that failed to produce a plan requiring DPP.  IMHO a better fix is to update the input data generation to ensure there isn't a degenerate join.  If we want to test handling of degenerate joins as well, that should be a separate test that explicitly sets up inputs to produce a degenerate join.

it looks like the solution here is that we need update the test logic to be something like an either/or capture

I'm not sure that's the best fix. The point of this test is to check handling of DPP, and the problem here is that the datagen happened to produce inputs that failed to produce a plan requiring DPP. IMHO a better fix is to update the input data generation to ensure there isn't a degenerate join. If we want to test handling of degenerate joins as well, that should be a separate test that explicitly sets up inputs to produce a degenerate join.

Makes sense. Will investigate what is producing the empty join

test_dpp_empty_relation already exists, so I think we just need to prevent the degenerate join in this test

Test is now failing again:
FAILED ../../src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[true-5-parquet][DATAGEN_SEED=1707665221, INJECT_OOM, IGNORE_ORDER]

Saw this fail again on Dataproc nightly run.
[2024-02-22T15:41:19.602Z] FAILED ../../src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[true-5-parquet][DATAGEN_SEED=1708615902, IGNORE_ORDER] - py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.s...
[2024-02-22T15:41:19.602Z] FAILED ../../src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[true-5-orc][DATAGEN_SEED=1708615902, IGNORE_ORDER] - py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.s...
[2024-02-22T15:41:19.602Z] = 2 failed, 116 passed, 11 skipped, 26232 deselected, 9 warnings in 557.14s (0:09:17) =

Another failure
[2024-02-29T10:10:57.500Z] FAILED ../../src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[true-5-parquet][DATAGEN_SEED=1709192431, INJECT_OOM, IGNORE_ORDER] - py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.s...

[2024-02-29T10:10:57.500Z] FAILED ../../src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[true-5-orc][DATAGEN_SEED=1709192431, IGNORE_ORDER] - py4j.protocol.Py4JJavaError: An error occurred while calling z:org.apache.s...

Considering this is actually a test issue (the test not being able to avoid an empty LocalTableScan) and not an issue with the plugin, lowering the priority


"Cannot use _sort and _sort_desc at the same time"

Triggered this error while playing with the sort desc checkbox and the apply button that are only visible on this page at mobile screen width:
https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort_desc=pk1
Navigate to that page (with the browser narrow enough to show the box), un-check the box and click Apply:

Also notable: I managed to get to a page with ?_sort_desk=pk1 in the URL three times by clicking around with that button.

This isn't just a mobile display issue.
http://<IP_ADDRESS>:8001/fixtures/compound_three_primary_keys?_sort_desc=pk1 - click "Apply" and each time it adds another ?_sort_desc=pk1 to the URL.

That fixed both bugs.


Create a blog webapp in Django

Do you mind placing that under Python?

Updated. I see, you are creating it for languages specifically.

Yes, I will add subcategories for each language later on

The commit is is ready to land.


Request: "throw an exception"

Do you take requests?
I have not been able to find a translation for "throwing an exception" à la Java. I'm using "at kaste et fejl" for the moment, but I'm not convinced that's quite right, especially since Java distinguishes between exceptions (recoverable) and errors (unrecoverable).

Of course! I should fix the README such that this is much clearer that requests are very welcome. :slightly_smiling_face:

[ ] "throw" -> "kaste"
[ ] "error" -> "fejl"
[ ] "exception" -> ???

Bærbak did on-the-fly the same kind of reasoning, so I feel that confirms it is a reasonable translation.


Merge Branch-DOB-TestSuite Hong Liang with master

closes #137

Codecov Report
Base: 50.40% // Head: 50.84% // Increases project coverage by +0.44% :tada:

Coverage data is based on head (a5b8fc8) compared to base (e9565c3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
+ Coverage     50.40%   50.84%   +0.44%
- Complexity      483      489       +6
============================================
  Files           112      112
  Lines          2238     2238
  Branches        263      263
============================================
+ Hits           1128     1138      +10
+ Misses         1036     1032       -4
+ Partials         74       68       -6

Impacted Files
Coverage Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
62.16% <100.00%> (+5.40%)
:arrow_up:

...eedu/address/logic/commands/EditPersonCommand.java
97.33% <0.00%> (+1.33%)
:arrow_up:

...c/main/java/seedu/address/model/person/Person.java
90.00% <0.00%> (+4.00%)
:arrow_up:

.../java/seedu/address/storage/JsonAdaptedPerson.java
83.05% <0.00%> (+5.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Is iterating over the options possible?

Is it possible to iterate over the non-positional options?
My program works by performing actions, in order, as they are specified on the command line.  So for example I might do something like this:
./example --add newfile.txt --delete existing.txt --rename newfile.txt=existing.txt

If those operations happen in a different order then the program won't work, so I need a way to find out what the first option and its parameter are (and action it), then look at the second option and its parameter, and so on.
boost::program_options offers a std::vector of the options, in the order given on the command line - is there an equivalent here, or some other way to achieve this functionality?

This is currently not possible. It's not something I ever thought of doing. It shouldn't be too hard to add though.

Sounds good!  Without wanting to be annoying, do you know what sort of a timeframe it might take to get implemented?  I'm quite keen to move away from boost::program_options :-)

I have a few improvements to make, with one that is probably backwards incompatible, so I'm thinking of doing a new major version release, which this would be included in. I don't have much time to work on this, so probably a few weeks.

I'm trying to work out the best interface for this. I can't find anywhere in the Boost docs that mentions this feature. Can you give me a link so that I can see how they do it?

Not sure where in the docs as they aren't the easiest to read, but this is my own code that uses this feature:
https://github.com/Malvineous/libgamearchive/blob/master/examples/gamearch.cpp#L425
Essentially it looks like the object that is returned after parsing the command line has begin() and end() functions so it can be iterated over.
It'd be nice if it was compatible with C++11 loops, like this:
https://github.com/Malvineous/libgamearchive/blob/master/examples/gamearch.cpp#L649
Note that each element in the list is an option (starting with - or --) and that option's parameters are kept with it.  So:
example --first --second=beta --third gamma

Means in the loop, item[0].string_key is first, item[1].string_key is second, item[1].value[0] is beta, item[2].value[0] is gamma, etc.
I'm not saying this is the only way to do it, just explaining how Boost does it.  If you had a list of tokens instead (without combining options and their parameters into the same object) then that would work for me, as long as I could "eat" one or more tokens in the middle of the loop, depending on whether the option I'm processing has any parameters or not.

Does this work when you do --first value --second foo --first bar?
As in you get --first with value bar in the third iteration? My problem with that is at the moment container values are parsed transparently into their container, so it would know which argument it is up to but lose which actual value it just parsed.
I'm just thinking about whether to restructure this all or if it seems ok to fit it into the current design.

Yes, that is correct.
You can't use .back() or similar to get the last value parsed?  Sorry I'm not familiar with the architecture.


Support for NodeSelector and Node Taints in cassandra cluster ?

My use of Cassandra is not within a K8s cluster of of its own.  It is in its own NodePool within a GKE cluster.  Able to add toleration to the cass-operator deployment (in the manifest.yaml) but is not able to control the deployment of Cassandra dc to a set of nodes in a Nodepool dedicated to Cassandra.  Try adding toleration definition to cassandra dc yaml file but did not work.
Operator works by adding toleration in cass-operator manifest.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: cass-operator
  namespace: monitoring
spec:
  replicas: 1
  selector:
    matchLabels:
      name: cass-operator
  template:
    metadata:
      labels:
        name: cass-operator
    spec:
      tolerations:
      - key: "dedicated"
        operator: "Equal"
        value: "cassandra"
        effect: "NoSchedule"
      nodeSelector:
        dedicated: cassandra

Adding the following to cassdc-example.yaml did not work
apiVersion: cassandra.datastax.com/v1beta1
kind: CassandraDatacenter
metadata:

  # The datacenter name.
  name: dc1

spec:
  tolerations:
    - key: "dedicated"
      operator: "Equal"
      value: "cortex"
      effect: "NoSchedule"
  #nodeSelector:
  #  dedicated: cassandra
  # The cluster name.
  clusterName: cluster1

  # The number of server nodes.
  size: 3

  # The rack definitions.
  racks:
    - name: rack1
    - name: rack2
    - name: rack3

Hi,
this may help you: https://github.com/datastax/cass-operator/issues/239#issuecomment-689733929

#263 allows full customization, too, although I think #67 is enough for nodeSelector + tolerations on the cassandra pods


How can I change the typeface of the titles?

Append this code!
BottomNavigation.setDefaultTypeface("your typeface");


Fix typos in table.yaml, BodyPartR15.yaml

Changes
Removed extra characters.

Checks
By submitting your pull request for review, you agree to the following:

[x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
[x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
[x] To the best of my knowledge, all proposed changes are accurate.

Thanks @alex-y-z!


Modify regex in clang format

Modify regex in clang format

IndentPPDirectives: AfterHash: current

#if FOO
#  if BAR
#    include <foo>
#  endif
#endif

IndentPPDirectives: BeforeHash: this PR

#if FOO
  #if BAR
    #include <foo>
  #endif
#endif

The current REGEX failed to list an external header with - above system headers. (The example is from tuvx, which I found the failure.)
Current:
#include <tuvx/util/config_yaml.h>

#include <cstring>
#include <fstream>

#include <yaml-cpp/yaml.h>

This PR:
#include <tuvx/util/config_yaml.h>

#include <yaml-cpp/yaml.h>

#include <cstring>
#include <fstream>

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.21%. Comparing base (555be4e) to head (2af8e83).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   92.25%   92.21%   -0.04%
==========================================
  Files          45       45
  Lines        3407     3403       -4
==========================================
- Hits         3143     3138       -5
- Misses        264      265       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@boulderdaze, could you update the description with a few examples of what will change when the format bot runs after this change?

@boulderdaze, could you update the description with a few examples of what will change when the format bot runs after this change?

Yes, that's a good idea. I updated the comments with the examples.

Thank you!


Create Action for generate artifact when a PR arrives

Is your feature request related to a problem? If so, please describe.
If someone wants to collaborate with the plugin, it would be nice to run some Action that generate Artifacts of the change, in order to help other people to test
What feature or improvement would you like to see?
Flowchat diagram Mermaid UML of Action:
flowchart LR

PR --> workflow_pull_request --> build[Generates build of PR]

Additional context
No response

Solved #61 #57


Update dependency repository when relocating

Is your feature request related to a problem? Please describe.
When relocating a Helm Chart with one of more dependencies the repository for said dependencies is not updated to the new location in the parent Chart.yaml. Meaning when installing the newly relocated parent chart it still pulls the original dependencies that contain the original image references.
Describe the solution you'd like
When relocating/unwrapping to a new repository the dependency repository references in Chart.yaml are updated to the new location. Thus, referencing the relocated subcharts that have references to the relocated images.
Describe alternatives you've considered
Besides manual intervention, no other alternatives considered.
Additional context
No response

Hi @PhilKershaw
The references to the sub-charts into the Chart.yaml are used mainly for 'pacakging' a new Helm chart. The scenario that Helm dt took into account is to have all the dependant Helm charts inside the "charts/" folder inside the main one.
When installing the main chart, the the dependant charts installed comes from the local directory "charts/" that have been modified to use the proper registry.
Are you bundling the Helm charts with the 'helm pack' command before running the 'helm dt' tool?

Hi @beltran-rubo
Thanks for sharing the thinking behind the approach. I totally understand and in practice it mostly works out.
Would there be any value in enabling an option to relocate dependency Helm Charts separately and not expecting them to be bundled? This would reduce duplication on the target registry side and possibly other benefits that don’t occur to me right now.
To your question RE running helm pack before dt. As part of a relocation procedure I run helm dep build which pulls the archive files before running helm dt wrap which would pulls down the images. There is a slight issue with this flow in that I have to extract the archives before helm dt wrap will run. It’s not a big issue but could perhaps be a little cleaner.

helm dt relies on the immutability of the images & dependencies so it is able to redistribute and verify the copy was done properly. In that case it requires the subcharts are already part of the chart (and part of the Chart.lock file).

It appears that this does not work if there are multiple layers of dependencies, e.g., chartA depends on chartB depends on chartC - chartC does not get relocated


+++Staking reward issue+++ 1 week, 1,032 MYX staked, 2 MYX received... Possible explanations HERE

Dear Team,
I want to share with you my impression regarding my first staking week with 1,032 MYX: I got 2 MYX approx as rewards...
My computer is turned on nights and days, wallet software runs as administrator and I allowed the software in the W10 firewall tab for private and public network in order to avoid any connecting issue. Everything is synchronized in the wallet, no error message also.
I only see with the minting probability within Minting tab a reward around 0.988% on 30 days!
The 2 following things are a problem from my point of view:
-Refresh of Minting tab not automated:
Mint icon (next to network and lock ones on bottom right) does not reflect the correct number of active minting transactions. This may delay or does not take into consideration all the transactions minting, therefore no/delayed rewards for the missing one. I must restart the wallet after each reward...;
-Every reward makes the transaction splitted:
Your white paper said minimum staking time is 24h, but I do not think the rewarded transaction has to be splitted because after each reward (minimum 24h - depending of the transaction size I assume), the split makes the 1 old mature transaction into 2 new transactions. The latters will need 24h to mature.
MYX stakers lose 1 staking day after each reward, rewards reduce transactions size which decrease the minting probability and at the end get a rate like mine: around 1% instead of 10% a month!
Did you set up the maximum staking time at 24h/after each reward?
Why is a split necessary here except not to reward stakers every day after a transaction is mature but only every 2 days minimum (1 day to mature, 1 day to stake and few more time to get the reward, then split, again 1 day to mature, etc.)?
For my knowledge, as it is for many platforms and desktop wallets, once a transaction is mature, it keeps staking every day and gets recurrent rewards. There are no splits and lost time for being mature again.
Thank you for your honesty, clear answers for the Community and prompt software update if any (as, for me, that is not how it should work).
Regards,
Xatra47

@Xatra47
From what I've experienced with the wallet it is a little hit and miss on updating the Minting page. I've only had minimal disturbances on the refreshing aspect but I know some have had more significant problems.
The best way to rectify the issues is simply to close the wallet and re-open it.
PoS splits transactions, all PoS works this way. If you want to keep them all together you can go to the
Settings menu -> Options -> Display tab -> 'Display coin control features'
With that you can go to 'Send' and select the inputs you want and then send them to yourself, thereby recombining them.
So what you're experiencing is essentially the same as for any other PoS coin reward, when you get a stake the transaction splits in to two.
These are new transactions and take the required 'maturing period' 24 hours before they're eligible to stake again.
The biggest difference is probably that Monyx has what I consider a long period for maturity. Some coins it is 2 hours, some 4, some less.
My advice: There is no need to have your wallet open constantly. Open it from time to time, you will get rewards less often but they will be bigger. You only miss out once a coin has gone beyond 'maximum probability'. If that does happen then you should use the above mentioned technique to re-combine your transactions but I doubt you'd need to as the wallet shows that the reward given increases over 90 days, so as long as you get a stake within 90 days you're receiving all the PoS reward you should.
Hope that helps.
P.S I've started a Discord server for real time community chat! Feel free to join us:
https://discord.gg/EzdxPVj

Hello,
Thank you first for your answer and all the informations shared.
"Settings menu -> Options -> Display tab -> 'Display coin control features'" ->
ticked now!
"long period for maturity. Some coins it is 2 hours, some 4, some less." ->
from what I see and according to the WP, 24 hours minimum. Shorter will be
better but I have not seen a transaction being mature in few hours only.
Do you reach the 0.3% daily approx./10% a month?
I am not registered at Discord, only Telegram and it is not already easy to
follow everything for every platform! 😉
Thanks again,
Have a good staking!
On Fri, Feb 16, 2018 at 9:48 PM, Blitzkitten<EMAIL_ADDRESS>wrote:

@Xatra47 https://github.com/xatra47
From what I've experienced with the wallet it is a little hit and miss on
updating the Minting page. I've only had minimal disturbances on the
refreshing aspect but I know some have had more significant problems.
The best way to rectify the issues is simply to close the wallet and
re-open it.
PoS splits transactions, all PoS works this way. If you want to keep them
all together you can go to the
Settings menu -> Options -> Display tab -> 'Display coin control features'
With that you can go to 'Send' and select the inputs you want and then
send them to yourself, thereby recombining them.
So what you're experiencing is essentially the same as for any other PoS
coin reward, when you get a stake the transaction splits in to two.
These are new transactions and take the required 'maturing period' 24
hours before they're eligible to stake again.
The biggest difference is probably that Monyx has what I consider a long
period for maturity. Some coins it is 2 hours, some 4, some less.
My advice: There is no need to have your wallet open constantly. Open it
from time to time, you will get rewards less often but they will be bigger.
You only miss out once a coin has gone beyond 'maximum probability'. If
that does happen then you should use the above mentioned technique to
re-combine your transactions but I doubt you'd need to as the wallet shows
that the reward given increases over 90 days, so as long as you get a stake
within 90 days you're receiving all the PoS reward you should.
Hope that helps.
P.S I've started a Discord server for real time community chat! Feel free
to join us:
https://discord.gg/EzdxPVj
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/monyxcoin/monyx-coin/issues/216#issuecomment-366354015,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AimIfmCIDdCn5OQtSKhthrRMIA47mGf8ks5tVemNgaJpZM4SIksY
.

@Xatra47
Sorry I wasn't clear on the "Some coins it is 2 hours, some 4, some less."By that I meant other PoS based coins, Whitecoin, Blackcoin, Elite, Stakecoin etc..
MYX is 24 hours.
Without doing the maths on it, I am getting pretty close to the 0.3% daily return, maybe a little under but it should all come out in the long run.

Ok, clear. I hope I'll get that reward level ASAP. Thank you!
On Sat, Feb 17, 2018 at 12:22 AM, Blitzkitten<EMAIL_ADDRESS>wrote:

@Xatra47 https://github.com/xatra47
Sorry I wasn't clear on the "Some coins it is 2 hours, some 4, some
less."By that I meant other PoS based coins, Whitecoin, Blackcoin, Elite,
Stakecoin etc..
MYX is 24 hours.
Without doing the maths on it, I am getting pretty close to the 0.3% daily
return, maybe a little under but it should all come out in the long run.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/monyxcoin/monyx-coin/issues/216#issuecomment-366387248,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AimIflMbWyWYSrrECr-9_oRz_S4TJ7tdks5tVg2qgaJpZM4SIksY
.

@Blitzkitten thanks for the help!
I'll probably put that info in our FAQ.

@monyxcoin
My pleasure! Happy to help out.
If you'd like to join the Discord I've set up to try and get some more real time communication It'd be appreciated.
https://discord.gg/EzdxPVj


mix between TextDocumentIdentfifier and XYZParams

onRenameRequest and onCodeAction params contain a textDocument and extra bits whereas onCodeLens only contains an identifier and leaves it to me to fetch the document. that's inconsistent.

This got addressed in the 2.0 version of the protocol.


Issue new release

Could one one of the project maintainers please issue a new release? I'm specifically hoping to start using #277 since it's been merged. Thanks!

@mdomke  Shall we cut a release now?

I just release version version 3.8.0. Sorry for the late reply!

🎆 Thanks!


change p to named tuple

Purpose
Changes p from a FieldVector to a NamedTuple. Preliminary PR to #292.
To-do
Content
<!---
Review checklist

I have:
- followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
- followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
- followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
- checked that this PR does not duplicate an open PR.

In the Content, I have included
- relevant unit tests, and integration tests,
- appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

----
- [ ] I have read and checked the items on the review checklist.

bors r+


json_encode options vs sending full json with body

Q
A

Bug?
no

New Feature?
no

Version
Specific version or SHA of a commit

Actual Behavior
Hello,
I have a specific json value thats need to be send to a Odata2 server.  Dates must be formatted with slashes like this
date": "/Date(1354665600000)/",
Unfortunatly the  function json_encode in functions.php will add  backslashes like this:
date": "\/Date(1354665600000)\/",
Then my json is invalid for the odata2 server.
In the Guzzle Documentation there is a note on this.

This request option does not support customizing the Content-Type header or any of the options from PHP's json_encode() function. If you need to customize these settings, then you must pass the JSON encoded data into the request yourself using the body request option and you must specify the correct Content-Type header using the headers request option.

Unfortunatly when i try to use the body request option wiht the related content-type header it says, this is deprecated
PHP Fatal error:  Uncaught InvalidArgumentException: Passing in the "body" request option as an array to send a POST request has been deprecated. Please use the "form_params" request option to send a application/x-www-form-urlencoded request, or the "multipart" request option to send a multipart/form-data request.
Expected Behavior
Is the manual wrong that it tells me to use body instead of json? But then why doesnt it throws a deprecated error when i do. I just thought i could produce the Json myself with json_encode($postdata,JSON_UNESCAPED_SLASHES);
Thank you for looking. Be kind i'm new to OOP :)

Passing in the "body" request option as an array to send a POST request has been deprecated

Why don't you just pass your encoded JSON string in the body option?

Hi @sagikazarmark ,
it must have been too late yesterday.. I did not send the string, but still the array.. my mistake ! :(
It does work as documented !
Thanks a lot, success with the project
KR


Fix spec you dummy

I broke a spec in my previous PR. I thought the build was erroneous because I recall fixing the spec locally, but I either didn't push it or those changes got lost. This will actually fix the spec.

Coverage remained the same at 97.941% when pulling 3cbd7a004eed861af45ccc2cfd10f552ec97f77d on spec-fix into abf595788ef6a647ff6665bdfdbc48d900482556 on master.


migration-graph: pass project level excludes to all packages in a project.

Problem

In rehearsal-config.json the exclude property  only a apply to the root package in a project (EmberApp, EmberAddon or Library).
Unable to ignore a directory within a package in workspace.

Use Case

[ ] As a user, when they want to exclude some file extension that's used in my imports like .css, .graphql, .json the config should have a option for excluding just that.
[ ] As a user, when they want to to exclude a directory from within a package, there should be a option for this in the config. (e.g. packages/some-package/test when running rehearsal migrate fro the root, should omit that portion of the graph from the output or graph).

Implementation Details
We can pass these into dependency-cruiser with the following regex format:
\\.css$
\\.graphql$
\\.json$

[ ] Should not pass complexity for regexs to the user. Maybe just have the extension as a suffix.
[ ] Create an API in rehearsal-config that extends the excludes property to be an object:
     exclude = string[] | { paths: string[], extensions: string[] }
We can construct the regex from this array of .css
[ ] Document how to pass file extensions excludes.

Fixed with —ignore flag


Add new graphql to get customer by name

Create new graphql query to get customer by name.

I will merge this in our #239 PR

Added to #239 .. see https://github.com/amazeeio/lagoon/pull/239/commits/c91c422f80f66bbdd1f0d728de17508b2c60ed64
This can be closed now!


error in learn you mongo exercise 3

I'm running from c9.IO, whenever I try to run the selected file with the command "learnyoumongo run file.js" I get the below error.
I tried playing around with the code and I tried it with a blank file, the result is always the same...
/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/mongodb/lib/server.js:235
        process.nextTick(function() { throw err; })
                                      ^

TypeError: Cannot read property 'collection' of undefined
    at Exercise.<anonymous> (/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/exercises/find/exercise.js:37:5)
    at next (/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/workshopper-exercise/exercise.js:260:17)
    at Exercise.end (/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/workshopper-exercise/exercise.js:266:5)
    at Workshopper.end (/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/workshopper/workshopper.js:191:12)
    at Workshopper.done (/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/workshopper/workshopper.js:323:19)
    at Exercise.<anonymous> (/home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/workshopper-exercise/exercise.js:149:14)
    at /home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/workshopper-exercise/exercise.js:136:16
    at /home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/exercises/find/exercise.js:20:21
    at /home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/mongodb/lib/mongo_client.js:269:20
    at /home/ubuntu/.nvm/versions/node/v4.1.1/lib/node_modules/learnyoumongo/node_modules/mongodb/lib/db.js:226:14

Getting the same problem. Seems to be unable to access the collection
I can see the parrots collection in the mongo client though. However. using db.parrots.find() with learnyoumongo being the active db returns absolutely nothing.

strange. Not really sure what the problem is here. As soon as I get some free cycles, I'll take a look and see if I can reproduce

Same problem!

I'm getting the same error.  Can someone follow up?

I faced some issue just run mongod server in another terminal:
mongod --port 27017 --dbpath=./data --nojournal
then execute learnyoumongo run file.js.

I'm getting the same error as well. If I run mongod myself (with options as shown above) I get an error about the server closing the connection.

Yes, mongod must be running for all of the exercises

FWIW I noticed that when installing the npm mongodb package there is an error about the peer dependency<EMAIL_ADDRESS>I tried installing a current version but have not been able to get it to build properly

I have what seems to be the same problem. I resorted to using the "correct solution" but it didn't pass.
Mongodb v2.6.11
Node v4.1.1
Error message:
module.js:338
    throw err;
    ^

Error: Cannot find module 'mongodb'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/home/ubuntu/workspace/ex3of9.js:2:13)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:475:10)

Your submission results compared to the expected:

                 ACTUAL                                 EXPECTED
────────────────────────────────────────────────────────────────────────────────

   ""                                  !=    "[ { _id: 56de07ece7777cf009209332, name: 'Jenny', age: 10 } ]"
                                       !=    ""

────────────────────────────────────────────────────────────────────────────────

✗ Submission results did not match expected!

# FAIL

Your solution to FIND didn't pass. Try again!

Yes, There is problem.
It seems it clears the DB. Because when i debugged directly into the DB using Robomongo. I found no documents in the DB.
Solution to problem insert the data manually and than try it.
Thanks
-Manish

@manishupadhyay
Sure there is the problem with the DB, somehow it's not created.
Actually I have pass the exam 3, with the result.

[ { _id: 5753ba9f84bd376d11a4ebd8, name: 'Jenny', age: 10 } ]

But i've checked on mongo shell using this command
> db
learnyoumongo
> show collections
parrots
system.indexes
> db.parrots.count()
0
> db.system.indexes.count()
1

So actually there is no document in collection parrots?
Where should i check the data?

@ThomastheBicyclist you would need to run npm install mongodb whenever you see that error

@ygautomo The data is inserted and then removed when the process exists, so it will show 0 for the count after the exercise is run. That is by design (if I can even call it that?) :]

@evanlucas Ok. thanks for the response. now i understand how it's works.

i tried the following and it worked with me
delete the database directory and recreate it, (care this will delete every database you have in this directory )
mkdir ./data
mongod --dbpath ./data

hi! i was googling for a hint on why
var collectables = db.collection('<parrots>');
returns
Property 'collection' of object learnyoumongo is not a function
and then i tried testing db.parrots.find() and alas, also got 0.
i have not yet worked out and run a solution file so i don't know why there's no more document in the parrots collection. though i was trying out individual statements/commands if anything would stick so i could compose the successful ones later into a .js file.  i have not succeeded on running anything at all except for the "db.parrots.find()" which returned 0.
i already tried deleting the data folder and rerunning learnyoumongo and mongod.
still 0. what to do?

Was having same issue and this helped:
https://stackoverflow.com/questions/47662220/db-collection-is-not-a-function-when-using-mongoclient-v3-0/47662979
Essentially, the newer version of mongodb has changed how the .connect() method works. It no longer provides a db, but a Client object. You can extract the db from this object by referring to the db by name. For example:
const mongo = require("mongodb").MongoClient;
const url = "mongodb://localhost:27017/learnyoumongo";
const database = "learnyoumongo";
const ageThresh = parseInt(process.argv[2]);

mongo.connect(url, function (err, client) {
    if (err) throw err;
    const col = client.db(database).collection("parrots");
    col.find({
        age: {$gt:ageThresh}
    }).toArray(function (err, docs) {
            if (err) throw err;
            console.log(docs);
        })
    client.close();
});

Note how you close the client now, and not the db


Main.ts: import { MyAppAppComponent, environment } from './app/';  - modules not recognised.

it should be import { MyAppAppComponent, environment } from './app'; without the '/' at the end for ts to import stuff from ./app/index.ts. At least in Webstorm, MyAppAppComponent, environment are red, not recognised.

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

EI Capitan

Versions. Please run ng --version. If there's nothing outputted, please
run in a Terminal:
node --version
And paste the result here.

v6.2.0

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

created by cli, no changes.

The log given by the failure. Normally this include a stack trace and some
more information.

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

This issue is a duplicate from https://github.com/angular/angular-cli/issues/673. It seems to be an issue with webstorm itself, the import is correct.


Add selection method examples

Proposed changes
Add examples for ds.sel(method='') for 'nearest', 'backfill' and 'ffill'.
Not including 'tolerance', as this just results in a KeyError.
Checklist (replace [ ] with [x] to check off)

[ ] Remove any unused Python packages from Load packages
[ ] Remove any unused/empty code cells
[ ] Remove any guidance cells (e.g. General advice)
[X] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
[ ] Include relevant tags in the final notebook cell and re-use tags if possible
[X] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Whoops, meant to "request changes". Can re-review if you make an edit


Make the list view responsive

Make the list view responsive
Wireframe:
Desktop - https://redhat.invisionapp.com/share/6A8T2M2XB#/screens/193330602
Mobile - https://redhat.invisionapp.com/share/KH8SMN9DN#/screens/192528686

@SMahil was this resolved or is there still more work to do on it?

@joshuawilson List view is responsive now. No more work on this issue


[Question] preferred way of styling the component or setting custom zIndex

Hi,
thanks for this component,
just started using it and although base styles work just fine I need to change the z-index of the lightbox for it to be placed above another box that I can't change the z-index of (also might have to tweak other styles as well to match some other styles in my app)
so I was wondering if there was a preferred way of modifying the styles, apart from overriding with important in my own style sheets
thanks for your time

Actually there is not a way to modify the styles at this time. The package uses radium for styling, which is pretty easy to mix custom styles into, so if you're not averse to making a pull request allowing for custom styles injected via props, I can guarantee I'll look at it asap.
For starters, if you wanted to change the z-axis of the modal element (though I'm considering eventually changing this part to the react-modal component), you could add a style attribute to the <modal> tag here: https://github.com/fritz-c/react-image-lightbox/blob/master/src/ReactImageLightbox.js#L950

Thanks,
I'd really like being able to contribute, I'll try if time allows in the next few weeks
anything I should know about building? I'm not so good with npm and build tools
I see you have a release script
how would I run it?
just running gulp in the node_modules/react-image-lightbox directory?
thanks

You'll want to fork the repository, and then clone it to a directory on your computer via
git clone git@github.com:thomasmery/react-image-lightbox.git

and work inside that. You push commits to one of your branches, and create a pull request for that branch from github.
I used the gulp tasks from https://github.com/JedWatson/react-component-gulp-tasks
So everything will be the same as in there, but I think the only command you'll need to know is gulp dev (also mapped to npm start), which starts up a local dev server, and you can see the effects of your changes on the sample page served up. All the build and publishing stuff I'll handle after merging a pull request.

@thomasmery Were you able to get it working for you?

Hi,
sadly I had no time to work on a proper solution and ended up modifying the zIndex in my css.
sorry I did not warn you

No, that's perfectly fine. Sorry for not making it customizable enough. I'll let you know when I make a release that better enables user styles.

As of  release v3.1.0, the reactModalStyle prop can be used to customize the z-index, etc., of the modal holding the lightbox. Thanks for making this suggestion.


Replace update-notifier-common with our own logic

update-notifier-common is no longer available in Debian 8 (Jessie). As such, we update the timestamp file ourselves when running apt-get update.
This pull request is meant as an alternative to #115. Compared to this, my variant is more explicit regarding when to update the timestamp file. This makes the behavior more predictable for chef. However, as we are not as strongly tied to the apt internals, this might lead to more update runs than strictly necessary if apt-get update is performed outside of a chef run.
But at least, we are sure that our own state is always up-to-date following our rules.

This pull request is thus an alternative attempt to fix #80.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@meineerde

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

The build errors are entirely unrelated to this pull requests. Travis merely complains about style issues in code locations not touched by this pull request. These style issues should be handled in another pull request.

@meineerde I definitely like this approach better than mine. I think it's a much saner and cleaner way about it. I just have a couple of comments.
First, I think it would be better if the file resource was just update-success-stamp with an explicit path added. That way all the :notifies lines are shorter and easier to read.
Second, looking through the other resources I the file resource will need a only_if { apt_installed? } guard.

I think it would be better if the file resource was just update-success-stamp with an explicit path added. That way all the :notifies lines are shorter and easier to read.

While it's true that the code would be a bit more compact, it comes at a price. As the resource names are globally defined, we risk name clashes with other file resources with the same name. While this probably doesn't occur frequently given the prevalence of full path names in file resource names, we would still have a better excuse if we used the full name here. I think the advantage of being unambiguous allows us to be a tiny bit more verbose.

Second, looking through the other resources I [think] the file resource will need a only_if { apt_installed? } guard.

I can add this. I just left it out as the default action is :nothing anyway and the file resource is notified only by other resources who already have that guard.

Merged, thanks.


[ci_nmstate] Allow users to directly use the unprovisioned tasks

At the same time, fix a format issue in the Net Env Def that assumes the parent_interface is always present. That's no longer true since we added the new mapper that works in best effort mode.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

/approve


Fix invoking WriteError from rule execution threads

Whenever Helper.SuppressRule encounters any error, it invokes Cmdlet.WriteError. When running script rules, SuppressRule is called from rule execution threads. As such, Cmdlet.WriteError gets called from the rule execution threads. This results in an InvalidOperationException because this method can be called only from within BeginProcessing, ProcessRecord and EndProcessing and only within the main program thread.
Fixes #496

This change is

Reviewed 2 of 2 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Comments from Reviewable


Errors using with xcode 7 and swift 2

Hi there maxine, trying to install the DiscogsAPI cocoapod into a project using Xcode Version 7.0 beta (7A121l)  swift 2, using a podfile containing the following:
platform :ios, '7.1'
pod 'DiscogsAPI'
use_frameworks!
xcodeproj '/path to my actual project.xcodeproj'
Ignoring the warnings (46), I get 29 errors before it gives up, as follows. Would really appreciate any help you could give me!
Command /usr/bin/ditto failed with exit code 1
(null): Directory not found for option '-F/Users/haansplosion/Library/Developer/Xcode/DerivedData/MyApp-gzjulonionecwzdqoybpxhoopwbi/Build/Intermediates/SwiftMigration/MyApp/Products/Debug-iphonesimulator/Pods'
(null): Linker command failed with exit code 1 (use -v to see invocation)
Command /bin/sh failed with exit code 23
MyAppUITests Group
Command /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc failed with exit code 1
Command /usr/bin/ditto failed with exit code 1
(null): Linker command failed with exit code 1 (use -v to see invocation)
MyAppTests Group
(null): Linker command failed with exit code 1 (use -v to see invocation)
Pods-DiscogsAPI Group
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping/RKObjectMapping.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping/RKObjectMapping.h:23:9: Include of non-modular header inside framework module 'RestKit.RKObjectMapping'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping.h:24:9: Include of non-modular header inside framework module 'RestKit.ObjectMapping'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/ObjectMapping.h:21:9: Could not build module 'RestKit'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h:21:9: Include of non-modular header inside framework module 'RestKit.RKHTTPRequestOperation'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h:22:9: Include of non-modular header inside framework module 'RestKit.RKHTTPRequestOperation'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKObjectManager.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Network/RKObjectManager.h:24:9: Include of non-modular header inside framework module 'RestKit.RKObjectManager'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h:134:1: Expected identifier
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h:134:1: Expected '}'
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Vendor/LibComponentLogging/Core/lcl_RK.h:130:31: Expected ';' after enum
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:52:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:53:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:54:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:55:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:56:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:57:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:58:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:59:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:60:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:61:1: Initializer element is not a compile-time constant
/Users/haansplosion/Dropbox/GIT/MyApp/MyApp/Pods/RestKit/Code/Support/lcl_config_components_RK.h:62:1: Initializer element is not a compile-time constant
Too many errors emitted, stopping now

Hi @haansplosion
This is actually a bug on RestKit, a pull request is in progress on there side. By the mean time you can try to set your podfile as:
platform :ios, '8.0'
use_frameworks!
pod 'RestKit', :git => 'https://github.com/RestKit/RestKit.git', :branch => 'seg-clang-modules'
pod 'DiscogsAPI'

xcodeproj '/path to my actual project.xcodeproj'

@maxep Thanks so much for looking into this for me!
Still getting much of the same errors on build though, as per below. (Please note I quickly created another project called DiscogsTest to try your fix)
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/ObjectMapping.h
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/ObjectMapping.h:21:9: Include of non-modular header inside framework module 'RestKit.ObjectMapping'
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/ObjectMapping.h:23:9: Could not build module 'RestKit'
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/ObjectMapping/RKObjectMapping.h
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/ObjectMapping/RKObjectMapping.h:24:9: Include of non-modular header inside framework module 'RestKit.RKObjectMapping'
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h:21:9: Include of non-modular header inside framework module 'RestKit.RKHTTPRequestOperation'
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/Network/RKHTTPRequestOperation.h:22:9: Include of non-modular header inside framework module 'RestKit.RKHTTPRequestOperation'
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/Network/RKObjectManager.h
/Users/haansplosion/Dropbox/GIT/DiscogsTest/DiscogsTest/Pods/RestKit/Code/Network/RKObjectManager.h:25:9: Include of non-modular header inside framework module 'RestKit.RKObjectManager'

platform :ios, '8.0'
use_frameworks!
pod 'RestKit', :git => 'https://github.com/RestKit/RestKit.git', :branch => 'seg-clang-modules'
pod 'DiscogsAPI'
xcodeproj '/Users/Df/Dropbox/GIT/DiscogsTest/DiscogsTest.xcodeproj'

Sorry to bother you @maxep, but did you have any luck looking into this?

Hey! No not yet, I'm a bit busy with regular work. But I will have a look asap.

No problem. Thanks for looking!

Hi @haansplosion
I'm very sorry, I can't find a way to use restkit as a dependency in a swift project... I will keep my head up on cocoapods and restkit, they might come out with upgrades that fixes the issue!

This is actually a problem with use_frameworks! as the dependencies aren't modularized. If you aren't using additional Swift based cocoapods, you can safely remove that and everything will work.

Hey any luck with this? I am facing this issue and I have to use swift based cocoapods along with this. Please let us know if there is any progress regarding this

@kpavankotesh the short answer is "no." At the moment, this cocoapod isn't setup to be a modularized framework which is required for use_framework!. It's just a collection of classes added to your project. I had written up a separate issue that would have addressed this (https://github.com/maxep/DiscogsAPI/issues/5) but it was closed. However, I do think it would be beneficial to make this a true module so I will see if I can get around to it on my branch and then make a PR for @maxep to approve.

Modularized framework should be straightforward with cocoapods but I guess this issue is related to Restkit dependency. I've not found a solution yet, any help will be appreciated :)

I've push a framework branch which includes a framework project and a Swift example. It's Carthage compatible but not with cocoapods yet.
You can find a built fw in the Example-Swift.
Let me know if you find any issue with it. I will then merge it to master and push a release with @nrivard additions.


allow versions of angular js higher than 1.2.26

your bower file explicitly demands version 1.2.26 which causes conflicts

As you can see, this causes unit tests to fail - unit the unit tests pass I can't make this change.


[Feature Request] option to display pages instead of scrolling

Checklist

[X] This issue contains only one feature request. I will open one issue for every feature I want to request.
[X] I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
[X] This feature is merely an UI/UX update.
[X] This feature is not going to conflict with many of the existing features/options.

Is your feature request related to a problem? Please describe.
I prefer "page"-turning to scrolling when I read ebooks, but if this is an option in Myne I can't find it.
Describe the solution you'd like
I would love an option in the Settings menu to switch between displaying in pages and displaying in scrolling format.
How will you/everyone benefit from this feature?
To me, pages are the main advantage all the various DRM/ad-ridden ebook readers have over Myne at the moment. This option would make switching away from those apps much smoother.
Additional context
No response

The thing is, unlike typical ebook readers where each chapter is divided into multiple pages and users navigate between them horizontally, Myne simply divides the book into chapters and navigates through them vertically by scrolling. Therefore, there is no concept of pages here. That's why we have a progress bar at the top of the ebook reader to track the progress of specific chapters, as there are no pages to count in the first place.

Ah, I see. Thank you anyway!


Does not accept object keys

Sub T2()
Dim SD As Object
Dim VD As Dictionary
Dim C As Collection
Dim V As Variant
Dim Ar(1) As Long
Const MSG = "This item's key is a collection"
Set SD = CreateObject("Scripting.Dictionary")
Set VD = New Dictionary
Set C = New Collection
C.Add "First"
C.Add "Second"
SD.Add "Ocelot", "Cat"
SD.Add C, MSG
Debug.Assert SD(C) = MSG
VD.Add "Ocelot", "Cat"
VD.Add C, MSG 'Error 457
End Sub

I should have deleted the declarations of V and Ar; I'd used them to check behaviour with array keys. Neither Scripting.Dictionary nor VBA-Dictionary accept them, but they may not return the same error number when one tries.


[Relax] Fix the parser to avoid treating a list as an integer

When the output tensor is in the form of (10), TVM will crash unexpectedly as follows.
This PR adds a rule to convert the (10) to (10,) to avoid such a crash!
Traceback (most recent call last):
  File "/share_container/optfuzz/res/ut_ut_test/res_executions/14832_test.py", line 9, in <module>
    class Module:
  File "/share_container/optfuzz/res/ut_ut_test/res_executions/14832_test.py", line 11, in Module
    def main(x: R.Tuple(R.Tensor((10,), dtype="float32"), R.Tensor((10,), dtype="float32"))) -> R.Tensor((10), dtype="float32"):
                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/software/tvm/python/tvm/script/parser/relax/entry.py", line 266, in Tensor
    if shape is not None and not isinstance(shape, Var) and len(shape) == 0:
                                                            ^^^^^^^^^^
TypeError: object of type 'int' has no len()

from tvm.script import ir as I
from tvm.script import tir as T
from tvm.script import relax as R

@I.ir_module
class Module:
    @R.function
    def main(x: R.Tuple(R.Tensor((10,), dtype="float32"), R.Tensor((10), dtype="float32"))) -> R.Tensor((10), dtype="float32"):
        cls = Module
        with R.dataflow():
            lv: R.Tensor((10,), dtype="float32") = x[0]
            R.output(lv)
        return lv
mod = Module
mod.show()

cc @tqchen @Hzfengsy @Lunderberg @yongwww

@tvm-bot rerun

Thanks for the contribution!
First, it's not a typical bug. (10) is just an integer rather than a list based on the Python syntax, while [10] and (10, ) are list and tuples. Here, we request a list as input, so the error is expected (based on the current implementation)
Second, it should be a valuable sugar for end users. But please:

consider supporting not only integers but also prim expr, symbolic shapes etc.
please add tests in the parser test file


[ethiopic] Add EthiopicUstr() class

Add EthiopicUstr() class with ustr() base class.

[ ] Add data cleaning methods to eli.EthiopicUstr (string normalisation)

[ ] substitute 2 occurrences of the ethiopic workspace for the fullstop.  ፡፡ → ።
[ ]   ፡- →  ፦

[ ] Convert all syllables to first order equivalent (string normalisation)
[ ] Convert space to workspace

Review https://www.w3.org/International/elreq/#punctuation


console 模式下报错

[error] failed to start connection on <IP_ADDRESS>:1883 - enotconn
13:27:35.004 [error] failed to start connection on <IP_ADDRESS>:1883 - enotconn

no idea.


Fix require_boost_libs libraries argument in CMakeLists.txt

While trying convert the build for newer version of libtorrent v1.1.1, which has additional dependencies on boost_random, I couldn't get cmake-js and boost-lib to build the boost_random library.
Using quotes around the list of the boost libraries fixed the problem.
This patch isn't required for the module to build currently, it seems the default libraries that get built are enough for libtorrent. So this would be a fix for the future.

Thanks!


add basic example to show connected address

Description
Context: If you directly use useAccount / any other hooks on home you get the below error from Next which is not at all helpful and hard to debug

Not so helpful error:

The solution to this is adding "use client" at the beginning of the file (this might be not all obvious for beginners)
This PR adds a default example of showing the connected address (this way we have "use client" at the top of file already and might save some users from pitfalls)
Please feel free to suggest any other place where we could add currently added it below SE-2 text :

Demo Video

https://github.com/scaffold-eth/scaffold-eth-2/assets/80153681/addd844a-378f-443c-be63-46801393b6dd

@technophile-04 I have code in se-2 projects that uses useAccount without adding "use client" and useAccount is working fine. What I'm missing?

@technophile-04 I have code in se-2 projects that uses useAccount without adding "use client" and useAccount is working fine. What I'm missing?

@damianmarti This only happens after migrating to the Next App Router (we did it a couple of weeks ago in https://github.com/scaffold-eth/scaffold-eth-2/pull/535)

@technophile-04 I have code in se-2 projects that uses useAccount without adding "use client" and useAccount is working fine. What I'm missing?

Or you have 'use client' in parent components/page

Tysm all merging it 🙌


Where are the rewards and plots saved, if at all by default ?

I noticed the data is supposed to be stored inside the rlpyt/data/local folder. However I dont see any rewards or plots or checkpoints of networks or anything.

The data are indeed supposed to be saved there. It may be an os issue. Maybe you can search for progress.csv, params.json or debug.log. Make sure you can write to the folder.


[BUG] k3d proxy doesn't expose udp port properly

What did you do

How was the cluster created?

k3d cluster create coredns-crd -p "1053:53/udp@loadbalancer" --k3s-server-arg "--no-deploy=traefik,metrics-server"

What did you do afterwards?

Install coredns with LB service type

What did you expect to happen
dig @localhost -p1053 would reach coredns service inside cluster
Screenshots or terminal output
When exposing udp port, nginx shoudl be explicitly instructed to listen on udp, otherwise tcp is used.
Which OS & Architecture

Linux, Windows, MacOS / amd64, x86, ...?

Which version of k3d

k3d version v4.1.1

Which version of docker
 Version:           20.10.2
 API version:       1.41
 Go version:        go1.13.15
 Git commit:        2291f61
 Built:             Mon Dec 28 16:12:42 2020
 OS/Arch:           darwin/amd64
 Context:           default
 Experimental:      true

Hi @k0da , thanks for opening this issue and especially providing a fix already :+1:


fix(Landing): We should use hydrate() here but got some problems with re-render

Download Button did not re-render with correct os info
Issue:
What I did
How to test

Deploy preview ready!
Built with commit ff2754f84c584bcccd37ded6e30b378089dfcafb
https://deploy-preview-485--mcs-lite-ui.netlify.com

Deploy preview ready!
Built with commit ff2754f84c584bcccd37ded6e30b378089dfcafb
https://deploy-preview-485--mcslite.netlify.com

Deploy preview ready!
Built with commit ff2754f84c584bcccd37ded6e30b378089dfcafb
https://deploy-preview-485--mcs-lite-introduction.netlify.com


Upgrade PyJWT>= 2.8.0 in requirements.txt

Encountered a dependency conflict when attempting to update to PyJWT = 2.8.0
User Story - Business Need

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story
As VA Notify
I want to keep our service up to date
So that we are secure and as free of bugs as possible
Additional Info and Resources

Relevant section of README.md

Engineering Checklist

[ ] Update performed
[ ] Dependabot issues updated
[ ] Any conflicts removed and tickets created
[ ] Passes all tests locally
[ ] Passes userflows and QA Suite testing against Dev
[ ] Any major changes are investigated (compare existing to new version changes)

[ ] Any questionable version changes are removed and a ticket is created

[ ] Tickets created are added to the Epic for tracking purposes

Acceptance Criteria
Repo dependencies are updated and we have no broken functionality. Issues opened by Dependabot are resolved. Tickets created for any updates we could, or should, not do.
QA Considerations

[ ] Check to see if these updates cancel out any Twistlock issues
[ ] QA Regression tests pass after deploying this code.

@justaskdavidb2 I'm confused about the conflict.  PyJWT 2.8 is consistent with the requirements you pasted.  Where is PyJWT[crypto]==2.7?  Did you upgrade that too?


Export command to export selected contacts

Codecov Report
Patch coverage: 17.04% and project coverage change: -2.30 :warning:

Comparison is base (93eb0dc) 66.88% compared to head (f8e1aee) 64.59%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
- Coverage     66.88%   64.59%   -2.30%
- Complexity      495      498       +3
============================================
  Files            92       94       +2
  Lines          1673     1754      +81
  Branches        186      195       +9
============================================
+ Hits           1119     1133      +14
- Misses          487      553      +66
- Partials         67       68       +1

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...va/seedu/address/logic/commands/CommandResult.java
60.00% <ø> (ø)

...va/seedu/address/logic/commands/ExportCommand.java
0.00% <0.00%> (ø)

...java/seedu/address/logic/commands/ViewCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
76.00% <0.00%> (-3.17%)
:arrow_down:

...ain/java/seedu/address/logic/parser/CliSyntax.java
85.71% <ø> (-1.79%)
:arrow_down:

...eedu/address/logic/parser/ExportCommandParser.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/ViewCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...seedu/address/model/person/MatchNamePredicate.java
0.00% <0.00%> (ø)

... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: remove incorrectly tsconfig compilerOptions options

A simple fix for our bakabaka LunaY
Firstly introduced in #1

And there are many CI errors on every commits, are they ok?

And there are many CI errors on every commits, are they ok?

maybe(

Sure, I changed to remove these lines.

Generally we recommend to use Squash and merge instead of Create a merge commit option. You can go to the Settings page of the current repository and unselect Merge commit method.


Initialize $arr_classes to avoid TypeError

Hi, thanks a lot for the project.
While testing it, I noticed that if we just call the menu like that:
wp_nav_menu([
    'theme_location' => 'menu-1',
]);

we get:
NOTICE: PHP message: PHP Warning:  Undefined variable $arr_classes in /var/www/html/wp-content/themes/mad/theme/inc/menuclasses.php on line 95 NOTICE: PHP message: PHP Fatal error:  Uncaught TypeError: array_merge(): Argument #2 must be of type array, null given in /var/www/html/wp-content/themes/mad/theme/inc/menuclasses.php:95
Initializing $arr_classes to an empty array solves it.

Hi! Thanks for submitting this. I actually just refactored everything to include #1 's changes that we made happen in WordPress core. I'll accept the pull request and release a hotfix subversion first and the totally refactored version will be up in a few minutes.

I reverted the changes since they seemed unecessary. Probably coming from a previous version as it was already fixed on my end (line 97 seemed shifted out of place down only one line somehow).


Add compressed and staging options to get_jump_image

Tests run fine on my side. Syntax looks good. I was gonna comment that it's missing docs on the library's readme and then I noticed that it is I who hasn't added any proper documentation lol. I'll merge the PR and add some stuff from my previous changes to the database. Thanks a lot Adit!
============================================== test session starts ===============================================platform linux -- Python 3.10.14, pytest-7.4.4, pluggy-1.4.0
rootdir: /dgx1nas1/storage/data/alan/projects/monorepo/libs/jump_portrait/test
plugins: anyio-4.3.0
collected 28 items

collage_test.py ..                                                                                [  7%]
integration_tests.py ......................                                                                [ 85%]
unit_tests.py ....                                                                                [100%]


Change this label when specifying the location of the report to ‘Please provide the location’.

Change the following label to 'Please provide the location’.

@skrishn
Solution
Add calcite-notice to the create-feature components
Add the required functions, files required to show the messages
While creating new feature Show 'Please provide the location' while specifying location

Dev Checklist

Items
Is required
Status
Comments

Required NLS changes?
Yes

Required Backward compatibility
No

Required 508
No

Need Sanitize?
No

Impact Analysis Report

Impacted Areas
Comments

Have Configuration changes?
No

Have Runtime changes?
Yes

Impact on RTL
Yes

Impacted Component
Create-feature

Impacted Areas
While specifying the location show 'Please provide the location' message

@skrishn
The solution provided above is implementd but the string is used from https://github.com/Esri/solutions-components/issues/547#issuecomment-2335033187
Hence, now we are seeing below message


Error after creating long quest

In your issue, please include:
I created a 4 stage quest, here: https://pastebin.com/SLZQ9FG8
and after saving I tried to reload and got this: https://pastebin.com/sYZ2aVVN

I removed the ore breaking stage and it works. Did I have too much for them to do?

Closing due to lack of Quests/Spigot version. Please follow the issue template.


Use GoReleaser to produce release artifacts

Use go modules instead of dep, as github.com/dhaivat/apt-gcs.

Change the import path in cmd/main.go to match the module.
If the go module doesn't match the import, it brings in the import as a
dependency.

Add goreleaser configuration and Github Actions workflow.
This will produce deb artifacts for the supported linux arches when a
tag is pushed, so long as the tag is prefixed with v and is valid semver.

From now on the CI will use the latest version of Go 1.x.

You can see the result of a release tag push with this configuration here: https://github.com/retailnext/apt-gcs/releases/tag/v0.1.0

Thanks for the PR!


It seems that date selector is not translated

It seems that date selector is not translated (Day Picker is fine)
Screenshot_20220103_072417_com.android.chrome.jpg
(not related to this PR)
Originally posted by @ivan-dalmet in https://github.com/BearStudio/start-ui-web/issues/138#issuecomment-1003893048

Can I be assigned to this issue ?


subctl crashes detecting network on small k3s

$ ./subctl-v0.0.3-linux-amd64 join broker-info.subm

broker-info.subm says broker is at: https://<IP_ADDRESS>:6443
? What is your cluster ID? k3s-ovh-1
There are 1 labeled nodes in the cluster:

k3s-test2

Deploying the submariner operator
Created operator CRDs.
Created operator namespace: submariner-operator
Created operator service account and role
Deployed the operator successfully
The operator is up and running
Discovering network details
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x12019a0]

goroutine 1 [running]:
github.com/submariner-io/submariner-operator/pkg/subctl/cmd.getServiceCIDR(0x0, 0x0, 0x0, 0x1e, 0x0, 0x0, 0x0)
/go/src/github.com/submariner-io/submariner-operator/pkg/subctl/cmd/join.go:192 +0x1c0
github.com/submariner-io/submariner-operator/pkg/subctl/cmd.joinSubmarinerCluster(0xc000499bc0)
/go/src/github.com/submariner-io/submariner-operator/pkg/subctl/cmd/join.go:147 +0x22f
github.com/submariner-io/submariner-operator/pkg/subctl/cmd.glob..func2(0x215d2e0, 0xc000291b80, 0x1, 0x1)
/go/src/github.com/submariner-io/submariner-operator/pkg/subctl/cmd/join.go:85 +0x162
github.com/spf13/cobra.(*Command).execute(0x215d2e0, 0xc000291b60, 0x1, 0x1, 0x215d2e0, 0xc000291b60)
/go/src/github.com/submariner-io/submariner-operator/vendor/github.com/spf13/cobra/command.go:830 +0x2aa
github.com/spf13/cobra.(*Command).ExecuteC(0x215cde0, 0x0, 0x12bb040, 0xc00004c118)
/go/src/github.com/submariner-io/submariner-operator/vendor/github.com/spf13/cobra/command.go:914 +0x2fb
github.com/spf13/cobra.(*Command).Execute(...)
/go/src/github.com/submariner-io/submariner-operator/vendor/github.com/spf13/cobra/command.go:864
github.com/submariner-io/submariner-operator/pkg/subctl/cmd.Execute(...)
/go/src/github.com/submariner-io/submariner-operator/pkg/subctl/cmd/root.go:52
main.main()
/go/src/github.com/submariner-io/submariner-operator/pkg/subctl/main.go:22 +0x2e

I’m guessing this is because ServiceCIDRs is nil in a call to len()!


Add better code check and pre-commit hook

This PR changes how we do code style checks locally. It is the first step towards better code checking on our code spaces and on our Github Actions.

Hi all, let's drop this PR for now and revisit it in the future after we've focused on step one which is getting the precommit hook to be doing all of the things that the GitHub action is doing!

Closing in favour of https://github.com/3rdparty/dev-tools/pull/77


fix(storybook): adding disabled theme fix

Related Ticket(s)
Refs #2733
Description
This is a fix to unset the theme for the story if carbon-theme is disabled. Right now it is setting it in the white theme, or whatever theme was previously set if coming from another component, so this is especially visible for components like the Masthead, Footer, etc.
Changelog
Changed

unsetting theme setting for disabled stories

Closing this in favor of https://github.com/carbon-design-system/ibm-dotcom-library/pull/2735.


Create Share the CTI Page

Overview
The design in Figma is ready to begin building the "Share the CTI" page.
Action Items
Create the "Share the CTI" page using our Material-UI best practices. (Either build the whole page, or build it partially and also create additional GitHub issue(s) to complete it later.)
Link the new page into the site.
Resources/Instructions
https://www.figma.com/file/EFoSuj1b9G4aZ7bN8OX8tf/?node-id=4747%3A20185

progress: building the page
blocks: none
Availability: Medium
ETA: one week

progress: finished building desktop page
blocks: none
Availability: Medium
ETA: one week

@Olivia-Chiong will discuss with design on Tweets to be embedded and also assets/branding kit.

I have made https://github.com/civictechindex/CTI-website-frontend/pull/378

PR is merged this issue can be closed.


stats: add outlier detection stats

Description: adds allow list for outlier detection stats to instrument #1718
Risk Level: low - while the stats tree is somewhat wide, the current config only will emit stats for consecutive 5xx limiting the number of stats emitted.
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

@snowp @goaway I will create the internal changes once this is merged.


requirements.txt encoding error

Fix your requirements.txt file, it got corrupted somehow 👍🏼

File removed as all of the python modules are builtins now