Exploit Detection for CVE-2023-33246 - RocketMQ

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:
Added detection for exploit activity and exploit attempt of RocketMQ unauthenticated arbitrary file write vulnerability which leads to remote code execution (CVE-2023-33246)
POC Reference:
https://github.com/Malayke/CVE-2023-33246_RocketMQ_RCE_EXPLOIT/blob/main/check.py
https://github.com/hheeyywweellccoommee/CVE-2023-33246-rnkku
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Looking forward to feedback and suggestions
cve_2023_33246_output.txt
.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

118c419 added exploit detection for CVE-2023-33246

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Loginsoft-Research
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

118c419 added exploit detection for CVE-2023-33246

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

0f72605 added exploit detection for CVE-2023-33246

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Related to my comment https://github.com/falcosecurity/rules/pull/85#discussion_r1230144247 could I AB test with you to provide me with a test script to simulate the attack in a VM or other instructions so that I can do quick verifications given reviewers are time constrained?
It's something we could debate and possibly add as future contribution requirement, WDYT?

Related to my comment #85 (comment) could I AB test with you to provide me with a test script to simulate the attack in a VM or other instructions so that I can do quick verifications given reviewers are time constrained?
It's something we could debate and possibly add as future contribution requirement, WDYT?

Can you use this container to quickly deploy? will this work for you?
And we are following POC to reproduce the exploit

https://github.com/Malayke/CVE-2023-33246_RocketMQ_RCE_EXPLOIT/blob/main/check.py
https://github.com/hheeyywweellccoommee/CVE-2023-33246-rnkku
rocketmq_exploit.zip

I also shared the scap here, you could use sysdig for analysis and falco to test :)

Few more ideas:
In the proposal for the "rules adoption, management, and maturity framework" we are currently finalizing the details. These new processes will include official rule contribution guidelines, rules criteria, as well as style guides.
I wanted to ask if it would be acceptable to wait until these guidelines are published in the upcoming weeks. This way, we will have a formal process in place for tagging and maintaining application-specific rules.

Meanwhile in response to https://github.com/falcosecurity/rules/pull/85#discussion_r1229081268, I have noticed that there might be a general gap in terms of generic behavioral-based detections for RCE originating from Java apps. I believe that introducing such a rule could provide significant value to the community and be of interest to end users who prioritize behavior-based detections.
Since Falco 0.35, we have exposed proc.aexepath, which was not available before. This enhancement enables us to perform more robust searches for Java in the parent process lineage, considering that Java applications often have a custom name for proc.name.
I am curious to hear your thoughts?
spawned_process and proc.name in (shell_binaries) and proc.aexepath endswith java and not ... [some TEMPLATE macros to exclude known conditions that can be customized by adopters]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/remove-lifecycle rotten
I guess this is still valid. cc @falcosecurity/rules-maintainers


Create generic action system to allow for complex input mechanics

At the moment any input such as a button press is a 1:1 relationship between all SDK controllers and the action it's performing (e.g. grab).
It would be better if actions are generic and can be compound to create complex sequences to initiate an action.
For example.
instead of doing Grip = Grab you could do:
If Trigger on Vive Wand or Grip on Oculus Touch then Grab
Or it could be taken further by having other complex actions such as
If touchpad axis (x/y) changed then provide Vector2
Or it could be if InputX and InputY then provide Vector2 (think of a omnidirectional treadmill input).
A branch with a very early prototype example: https://github.com/thestonefox/VRTK/tree/feat/input-actions

This system could actually handle a lot more stuff. Transform actions that take touchpad axes state and return a bool to turn it into a trigger for whatever we allow triggers to be used.
The API would change to just allow Action<bool> for triggers, button press state is a three-valued enum, so we'd have Action<ButtonState> etc.
Nothing stopping us from transforming hardware treadmill input into triggers etc.

Should look into UniRx's ReactiveProperty.

Scripts that have input:

Interact Grab:

Grab Button

Interact Use:

Use Button

Pointer:

Activation Button
Selection Button

Touchpad Control:

Primary Activation Button
Action Modifier Button
Touchpad axis

Button Control:

Forward Button
Backward Button
Left Button
Right Button

Slingshot Jump

Activation Button

Cancel Button

Move In Place

Engage Button

Step Multiplier

Engage Button

UI Pointer

Activation Button (Hold/Toggle/Always On)

Selection Button (Click on up/down)

Avatar Hand Controller (probably leave this directly tied to buttons)

Panel Menu

Swipes on touchpad

Pointer Direction Indicator

Touchpad axis

Radial Menu

Touchpad touch to activate

Touchpad angle to select

Pasting in some of my Slack messages in here:

Instead of having On action+Off action+Hold setting a generic way would be to have a ToggleAction<bool>. This class would have two "input actions", one to toggle on, one to toggle off.
ToggleAction<bool> is an Action<bool> and thus the grab script just has a public Action<bool>.
That way you could have like
Touchpad Vector2 -> Angle -> Quadrant -> bool
with
Touchpad ButtonState -> Filter -> bool
to have "upper left quadrant on touchpad was pressed" and "touchpad unpressed".
These would then route into ToggleAction as on and off actions.
Boils down to "create another generic Action to hold any state".
Also means no script needs toggle logic for example, people can just chain the actions (and we'd offer a way to share created chains).

And one could argue "I don't want these generic ones to return a bool" so that could just return T2 with resultValue or something.
Nothing is stopping a user from having a state machine in the logic of an Action... So there could be a lot of difficult stuff being available in a generic fashion.

Time was one of the inputs I was thinking about...
If one were to provide a TimeAction that is more of a TimePollAction, i.e. it doesn't fire, instead you only call Get on it, then that would be a way to have different kinds of timing systems...
If actions share the same TimeAction and you change that Action (e.g. slowmotion) it will change all the Actions that use that one.

There are also a number of issues where you need to know if the button is pressed down or the button is released.
E.g. in the pointer, it can do select button pressed on button down, or select button pressed on button up.
So any input action would need to know this information.

I'm wondering if the concept of input actions for generic button presses is the best way of working?
What if SDKs had a button type, which was specific to the SDK. Then there was a proxy class that allowed you to specify which SDK button related to which VRTK button.
Then you would have something like this:
SDK_SteamVR Trigger = VRTK_Button1
SDK_Oculus Grip = VRTK_Button1
Then you just specify on Interact Grab
Grab Button = VRTK_Button1
Maybe you could also do:
SDK_SteamVR Trigger && SDK_SteamVR Grip = VRTK_Button1
or
SDK_SteamVR Trigger || SDK_SteamVR Grip = VRTK_Button1
this wouldn't help with things like where you can say "trigger to pick up" and "grip to drop" but you'd have to manually switch that in code i guess?
Any script that uses an axis, like touchpad axis could have a parameter of where it gets that axis info from maybe? And then a helper script called input axis that defines that?
I'm trying to come up with alternatives as the existing scripts may not work well with previous ideas.

Action chaining:

SDK has button types specific to the SDK (maybe change that to have its own Actions instead, to be more flexible for stuff like "there's no 'untouch' on this specific button/device at all since it only knows about pressed vs. unpressed").
User creates a new Action that fires whenever any of the input Actions connected to it fire. I.e. boolean OR Action.

Then all you need is to set the input Actions to the SDK provided ones and set the "pick up" to the OR Action.

we could do with a prototype of the action system to prove the concept. My way of doing it is going to hit severe restrictions with how current scripts work.

Some use cases:

Interact Grab
Press Trigger to grab object
Release Trigger to drop object
(this would be press and hold trigger to keep grabbing, release to drop)

Release Trigger to grab object
Release Trigger to drop object
(this would be press and release to grab, then press and release again to drop)

Release Trigger to grab object
Release Grip to release object
(this would be press and release to grab, then press and release a different button to drop)

Press Trigger to grab object
Press Grip to release object
(this would mean the trigger button would need to be held down but only drop when the grip is pressed, so this wouldn't make much sense)

Pointer
Press Trigger to activate pointer
Release Trigger to do select action
Release Trigger to deactivate pointer
(this would be on trigger press turn pointer on, on release trigger make a selection and then deactivate pointer)

Press Trigger to activate pointer
Press Grip to do select action
Release Trigger to deactivate pointer
(this would be press and hold trigger to keep pointer on, pressing down on grip would select)

Press Trigger to activate pointer
Release Grip to do select action
Release Trigger to deactivate pointer
(this would be press and hold trigger to keep pointer on, releasing on grip would select)

Release Trigger to activate pointer
2nd Release Trigger to do select action
2nd Release Trigger to deactivate pointer
(this would on first release of trigger turn on pointer, then on second press/release of trigger would do select action and turn off pointer)

Release Trigger to activate pointer
Press Grip to do select action
2nd Release Trigger to deactivate pointer
(this would on first release of trigger turn on pointer, then grip presses would select action, then on 2nd press/release of trigger would turn off pointer)

@bddckr  do you think we can roll the issue https://github.com/thestonefox/VRTK/issues/875 into this one?

@thestonefox Yes I guess that could be handled by the SDKs offering Signals/Actions directly. Once SDKs offer a Signal we probably can connect scripts directly with them, instead of routing through our script alias... Therefore runtime changes would be very easy.


fix: remove buffer() for fetchLocalAudio

This fixes the: "TypeError: response.buffer is not a function" error when using fetchLocalAudio. The file already is a buffer when using fs.readFile, so this was failing:
TypeError: response.buffer is not a function
    at readFile.then.response (/Users/camsloan/Documents/development/personal/audio-stitcher/node_modules/node-crunker/lib/crunker.js:64:20)

Thanks for your contribution @camsloanftc ;)

this fix not publish to npm! i can't pull this fix，so i just fork one to publish for myself。


How to support folder in handler

I use aws lambda in the past but it almost unavailable in China. So I try to use kubeless, but still have some questions, hople you can help me.
In the past my serverless.yml file like this:
  listIndexPicture:
    handler: picture/picture.list
    events:
      - http:
          path: picture/index
          method: get

But it seems that this plugin didn't support folder, I must write like this:
  save-music:
    handler: music.save
    events:
      - http:
          path: /music

If I make a folder named music and move music.js into music then change handler to music/music.save it will 503.
If handler must in root folder I think itn't good for large project, maybe I can divide the project into a lots of small project but every small project may need some common utils just as helper.js, how to manage the common js is a problem for me. Also if I want to deploy the function to server I must goto the folder and run sls deploy then goto other folder  and run command again.
If the handler support folder please let me know, thanks.

Hi @ijustyce,
indeed that is something that is not supported yet. If you are interested in the feature, could you open an issue in https://github.com/kubeless/kubeless/issues ? We would need to implement it there.


Add proper TypeScript build logic

Issue #, if available:
#411
Description of changes:
These changes allow the repo to conform to TypeScript best practices of not committing transpiled code to source control as we were doing before. Now, we have a compile target on the core package which should be run before testing or publishing the package. It transpiles the TypeScript in the source package, and copies the transpiled JavaScript and all other non-TS source files to a dist directory, which will ultimately be tested or vended to customers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request base (aws-v3-support@bcde5c2). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             aws-v3-support     #417   +/-   ##
=================================================
  Coverage                  ?   55.23%
=================================================
  Files                     ?       37
  Lines                     ?     2714
  Branches                  ?        0
=================================================
  Hits                      ?     1499
  Misses                    ?     1215
  Partials                  ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcde5c2...d0d4c7b. Read the comment docs.

@anuraaga this should now actually be ready for review if you wanna take a look :)


Bug report

Current Behavior
This code is my enemy
Steps To Reproduce
No response
Anything else?
No response

no u


keyutils: avoid QA warning about request-key-debug.sh

By removing the file from the staging, we avoid the following warning:
QA Issue: keyutils: Files/directories were installed but not shipped
/usr/share/request-key-debug.sh [installed-vs-shipped]
This looks like a debugging script which is not really needed in
the image, so this looks like the simples solution. Adding it to
the keyutils-dbg pacckage would also work, but only if those
get generated, which is not guaranteed.
This fixes IOTOS-592.

+1

As this is blocking https://github.com/otcshare/meta-iot-os/pull/46 let's merge quickly.


Update nextjs comparison

Add SSG section, clarify SPA-only mode and add links, reorder some content, and expand some subtitles.

:100:


How can we open a ssh in web browser without the form submit

We need to open a web ssh in a browser tab by calling API along with the destination host details from the laravel application.
We dont need the default html form that is associated with the webssh

I have been working on something like this myself. I have a branch with my changes -- somewhat outstanding. The main thing I've found to be problematic is the xsrf token. It's missing, and you don't really want to scrape it, as well as the other csrf checks.
This branch has a hole series of changes in it: https://github.com/klarose/webssh/tree/add-plugins
The main thing I've done in it is allow consumers to plugin a different backend connectivity mechanism (websocket in my case). I've also broken up the startup so you can control how it is run a bit in your own binary.
I added the --allow-cross-origin argument because I have a dynamic set of origins accessing my application, and it's too cumbersome to update the allow list in webssh (I'd have to restart or add some form of API integration), or to do the same with some form of reverse proxy so that it's all hosted together. It's important to note, though, that in my case access to the server is tightly controlled through a detailed auth subsystem in front of it.


Unexpected warnings

When I call serve I get the following warnings which are kinda unexpected but maybe it just show what I can add:
┌ Warning: I found a function block '{{header_col ...}}' but I don't recognise the function name. Ignoring.
└ @ Franklin ~/.julia/packages/Franklin/Qh55d/src/converter/html/functions.jl:23
┌ Warning: I found a function block '{{link_col ...}}' but I don't recognise the function name. Ignoring.
└ @ Franklin ~/.julia/packages/Franklin/Qh55d/src/converter/html/functions.jl:23
┌ Warning: I found a function block '{{link_hover_col ...}}' but I don't recognise the function name. Ignoring.
└ @ Franklin ~/.julia/packages/Franklin/Qh55d/src/converter/html/functions.jl:23
┌ Warning: I found a function block '{{section_bg_col_2 ...}}' but I don't recognise the function name. Ignoring.
└ @ Franklin ~/.julia/packages/Franklin/Qh55d/src/converter/html/functions.jl:23
┌ Warning: I found a function block '{{footer_link_col ...}}' but I don't recognise the function name. Ignoring.
└

Thanks for the heads up


ci(release.yml): fixes rsync readme.md copy

PR Checklist

[ ] Unit Tests have been added for new changes
[ ] All commented code has been removed
[ ] If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

Codecov Report

Merging #45 (9246ab8) into main (86063c5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          496       496
  Branches       100       100
=========================================
  Hits           496       496

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86063c5...9246ab8. Read the comment docs.


Add SingleLineCommentStyleFixer, deprecate HashToSlashCommentFixer

 <?php
-/* a comment */
+// a comment
 $a = 1;

I was thinking to also add this:
 <?php
-/*
- * One liner multilne comment
- */
+// One liner multilne comment
 $a = 1;

WDYT?

 <?php
-/* a comment */
+// a comment
 $a = 1;

vs

MultilineToSingleCommentFixer

where is that multiline ?

There are only two hard things in Computer Science: cache invalidation and naming things.
-- Phil Karlton

/* */ allow a comment to span on multiple lines, // doesn't.
One-liner refers to the actual weight of the comment, multiline comment refers to the comment type used.
Any suggestion is welcome, I'm really bad at naming things.

What about "Converts multi-line comments that have only one line of actual content into single-line comments."?

@julienfalque 👍
And what about the fixer name?

I have no better suggestion for the fixer name for now :)

you have 3 types of comments in php - based on stars, slashes and hashes

So, what would you suggest?
Something like StarToSlashCommentFixer?

maybe one configurable fixer to update all single line comments to one style (which effectively would deprecate hash_to_slash_comment)?

I've renamed the fixer to StarToSlashCommentFixer and now it acts like this:
 <?php
-/* first comment */
+// first comment
 $a = 1;
-/*
- * second comment
- */
+// second comment
 $b = 2;
 /*
  * third
  * comment
  */
 $c = 3;

I would appreciate very much a review on the tests to be sure no case is missing.
@SpacePossum don't know the policy for deprecations here, as of yet the two fixers do (slightly) different things so I would keep them both.

I like @SpacePossum's suggestion. Then the fixer name could be SingleLineCommentStyleFixer or something similar (yes, I find StarToSlashCommentFixer kind of weird 😛).

The idea of merging two similar fixers is good, but it have to be planned.
Now we have:

hash_to_slash_comment that always moves # to //
star_to_slash_comment that sometimes moves /* */ to //

They are orthogonal and can coexists without repeated code.
IMHO we can keep them as they are now.
@keradus WDYT?
In case of deprecaton and merging, what's the correct process to follow?

To deprecate a fixer, you should:

mark it as @deprecated since 2.x [...];
add a trigger_error('...', E_USER_DEPRECATED) call in its constructor;
update its description to mention that it is deprecated (and suggest the new fixer, if any);
mark tests that cover the fixer as @legacy (with assertions on the deprecation notice when relevant).

@julienfalque 👍
I'll start writing the deprecation as soon as @keradus give us a feedback

E_USER_DEPRECATED in fixer constructor is not good idea. welcome to deprecation hell of fixer factory that will automatically register (via instance creation) of all fixers @julienfalque
I do not know for now how much of the code will be similar, yet idea is similar for sure.
If both @SpacePossum and @julienfalque are for unified fixer, I would go that way as well.
also, I would allow to change multiline /*..*/ comments to multiline // as well (with an option), but not /**...*/ docblock comments
currently existing fixer you gonna deprecate shall became proxy fixer in your PR.

also, I would allow to change multiline /*..*/ comments to multiline // as well (with an option), but not /**...*/ docblock comments

DocBlock comments are not part of this Fixer

currently existing fixer you gonna deprecate shall became proxy fixer in your PR.

What happens if someone config both the new fixer and the proxy?
Or better, what should happen?

both of them will be executed, but old fixer will perform no changes

E_USER_DEPRECATED in fixer constructor is not good idea. welcome to deprecation hell of fixer factory that will automatically register (via instance creation) of all fixers

👍 this should be implemented in FixerFactory in a separate PR. @Slamdunk please just add the @deprecated tag and update the description of the deprecated fixer.

So no code-enforced warning like trigger_error? Ok

if you want to, go with separate PR after this one got merged

Pushed changes:

renamed StarToSlashCommentFixer to SingleLineCommentStyleFixer
made it configurable to do HashToSlashCommentFixer job too
changed HashToSlashCommentFixer to be a proxy for SingleLineCommentStyleFixer, with less proprity
signed HashToSlashCommentFixer deprecated, HashToSlashCommentFixerTest legacy
added deprecation description to HashToSlashCommentFixer

Notes
To implement correctly the proxy pattern HashToSlashCommentFixer doesn't extends anymore AbstractFixer and implements directly the interfaces needed.
As such, in order to avoid copy-paste of the trivial code of getName method, I moved it to Utils, seizing the opportunity to add a test to it.

shall became proxy fixer

To implement correctly the proxy pattern ...

Use https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/src/AbstractProxyFixer.php instead

@keradus Didn't see AbstractProxyFixer and I'll use it, but there could be an improvement: setWhitespacesConfig is proxied, I'm going to proxy it too.

please doublecheck if there are currently any proxy fixers that are manually implementing setWhitespacesConfig

Edits done. I've also proxied isRisky and supports that previously were missing.

Feedbacks implemented

I just tried running the new fixer on the project itself and it changed this (in ConfigurationResolver):
-/* @var string[] $availableFixers */
+// @var string[] $availableFixers

IMO the behavior of the fixer is correct because this comment should have been a DocComment instead of a regular C-style comment, this should be fixer manually.
Could this be a bug in phpdoc_to_comment though? Or a conflict between the two fixers?
Anyway can you please add the new fixer to project's .php_cs.dist?

Those comment were introduced ex-novo by @localheinz in https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/393e0cc9c96275aa40ab370cdc0788bb5c69c99d#diff-62b374855f5961454b817b144c531e27R624 (no previous commit) so yes, they are just a missed-DocComment.
Fixer added to .php_cs.dist; those two cases manually moved to DocComments.

@keradus sorry for previous squashes, but I'm used to them because I find they make git blame and history easier to read, even though I agree should not be used in a WIP.
So I would appreciate a squash before merge, or if you prefer or find hurdles, I'll rebase and squash it for you.

my policy:

never squash/ammend in PR
always squash during merging PR (except edge cases with multiple authors...)

we started doing the squashing automatically before github started to offer that ;)

star to asterisk done

star to asterisk done (2)

Thank you @Slamdunk.


fix(firebase): fix style-src csp for invalid format

:tada: This PR is included in version 1.0.0-alpha.17 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


1.0.2 release PR

Codecov Report

Merging #26 (c9984b9) into master (3fc4e8e) will decrease coverage by 2.44%.
The diff coverage is 70.93%.

:exclamation: Current head c9984b9 differs from pull request most recent head a7c9dfb. Consider uploading reports for the commit a7c9dfb to get more accurate results

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   82.38%   79.94%   -2.45%
==========================================
  Files          29       39      +10
  Lines        3520     4557    +1037
==========================================
+ Hits         2900     3643     +743
- Misses        620      914     +294

Impacted Files
Coverage Δ

gsflow/builder/make_json_defaults.py
0.00% <0.00%> (ø)

gsflow/control.py
78.62% <ø> (+2.43%)
:arrow_up:

gsflow/output/discretization.py
89.74% <ø> (ø)

gsflow/output/prms_output.py
90.16% <ø> (-0.32%)
:arrow_down:

gsflow/prms/prms_help.py
94.82% <ø> (ø)

gsflow/record_base.py
71.64% <ø> (+2.98%)
:arrow_up:

gsflow/builder/prms_builder.py
5.71% <5.71%> (ø)

gsflow/param_base.py
55.05% <12.50%> (+6.74%)
:arrow_up:

gsflow/prms/prms_parameter.py
75.84% <12.50%> (-3.68%)
:arrow_down:

gsflow/utils/sfr_renumber.py
72.26% <33.33%> (ø)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc4e8e...a7c9dfb. Read the comment docs.


[CELEBORN-1512] Bump Flink from 1.19.0 to 1.19.1

What changes were proposed in this pull request?
Bump Flink from 1.19.0 to 1.19.1.
Why are the changes needed?
Flink 1.19.1 has been announced to release: Apache Flink 1.19.1 Release Announcement. The profile flink-1.19 could bump Flink from 1.19.0 to 1.19.1.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.

Ping @RexXiong, @pan3793, @cxzl25.


About the processed data

I am currently examining the processed dataset you have shared in your code. In MELD_features_raw1.pkl, I have noted that the second section pertains to speaker information. Each identifier corresponds to a speech segment, and for each segment, there are as many vectors as there are sentences. However, I observed that each vector has a dimension of 9. Could you kindly clarify if the value 9 holds any particular significance? Thank you very much for your assistance.

I am currently examining the processed dataset you have shared in your code. In MELD_features_raw1.pkl, I have noted that the second section pertains to speaker information. Each identifier corresponds to a speech segment, and for each segment, there are as many vectors as there are sentences. However, I observed that each vector has a dimension of 9. Could you kindly clarify if the value 9 holds any particular significance? Thank you very much for your assistance.

In MELD_features_raw1.pkl, the vector information with a dimension of 9 means the mapping for the speaker indices in the current session. The speakers in different sessions are generally not the same, but the maximum number of speakers in each session is <= 9.
In this work, our method only utilizes the sequence information of speakers, without strictly distinguishing which speaker each utterance belongs to. In the processed MELD features, there is no fixed speaker mapping, and different sessions usually have different mappings.
I hope this can explain the meaning of the speaker indices.

我目前正在检查您在代码中共享的已处理数据集。在 MELD_features_raw1.pkl 中，我注意到第二部分与说话人信息有关。每个标识符对应于一个语音段，对于每个段，向量与句子的数量一样多。但是，我观察到每个向量的维度为 9。您能否澄清一下值 9 是否具有任何特殊意义？非常感谢您的帮助。

在 MELD_features_raw1.pkl 中，维度为 9 的向量信息表示当前会话中说话人索引的映射。不同会议的发言者一般不相同，但每场会议的最大发言者人数为 <= 9。
在这项工作中，我们的方法只利用了说话人的序列信息，没有严格区分每个话语属于哪个说话人。在处理后的 MELD 功能中，没有固定的说话人映射，不同的会话通常具有不同的映射。
我希望这可以解释说话人索引的含义。

Thank you very much for your detailed explanation! It has greatly helped me understand the significance of the speaker indices in MELD_features_raw1.pkl. Your assistance is greatly appreciated. Thanks again!

I am currently examining the processed dataset you have shared in your code. In MELD_features_raw1.pkl, I have noted that the second section pertains to speaker information. Each identifier corresponds to a speech segment, and for each segment, there are as many vectors as there are sentences. However, I observed that each vector has a dimension of 9. Could you kindly clarify if the value 9 holds any particular significance? Thank you very much for your assistance.

In MELD_features_raw1.pkl, the vector information with a dimension of 9 means the mapping for the speaker indices in the current session. The speakers in different sessions are generally not the same, but the maximum number of speakers in each session is <= 9.
In this work, our method only utilizes the sequence information of speakers, without strictly distinguishing which speaker each utterance belongs to. In the processed MELD features, there is no fixed speaker mapping, and different sessions usually have different mappings.
I hope this can explain the meaning of the speaker indices.

Thank you very much for your detailed explanation! It has greatly helped me understand the significance of the speaker indices in MELD_features_raw1.pkl. Your assistance is greatly appreciated. Thanks again!


bump version to 1.13.0-rc1

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Victor Vieux<EMAIL_ADDRESS>

Thanks @shibli786 but our workflow is to bump master to the next version (work is already starting on the next version, the moment the release branch is created, see https://github.com/docker/docker/commit/869242662b38244469d5192bb0980f42b3de2901


InvalidCharacterError in /clan/furthest-thing-ly2qlyl0

Error in ClashLeaders
InvalidCharacterError in /clan/furthest-thing-ly2qlyl0
Failed to execute 'setAttribute' on 'Element': 'th9+' is not a valid attribute name.
View on Bugsnag
Stacktrace
(native):13 - Error

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
InvalidCharacterError in /clan/furthest-thing-ly2qlyl0


Note which python this targets

Should note in the README which Python this library targets
/usr/local/lib/python3.7/site-packages/dataclass_property/__init__.py:6: in <module>
    from .internals import dataclass, field_property
E     File "/usr/local/lib/python3.7/site-packages/dataclass_property/internals.py", line 59
E       def dataclass(cls=None, /, *, init=True, repr=True, eq=True, order=False,
E                               ^
E   SyntaxError: invalid syntax

I'm running Python 3.7.9.

I did not intend to make this for for Python 3.8+. Thank you for pointing this out. Version 1.1.1 has the forward slash removed.

Great library by the way! I had just concluded I needed to write something like this myself.. And you have already done it 😅 w

Thanks! I tried getting what I wanted to work with Pydantic, but had some trouble. I made this library as a result, but still wasn't all that happy. In the end I made the 'serial_json' library to do what I wanted. You may want to check out that library.

Interesting. I'm looking to support properties on dataclasses in my jira CLI project:
https://github.com/mafrosis/jira-offline/blob/master/jira_offline/models.py#L219
That project also includes a lightweight dataclass<->JSON serializer based on types - which I wrote to solve my problem before I knew Pydantic was a thing..


Make per-commit packages available

Should ideally work similarly to the way angular/angular does it. These packages wouldn't be on npm, just on GitHub.

Isn't there issue for this already? https://github.com/angular/material2/issues/577

Oh yeah, closing this one then.


fix: ledger signature recovery value

PR-Codex overview
This PR focuses on improving the handling of the v value in signatures for both the wallet-base and ledger modules, ensuring correct parity representation and enhancing test cases for signing transactions.
Detailed summary

Updated v value calculation in wallet-base/src/signing-utils.ts to use BigInt.
Refactored signature v handling in ledger-signer.ts, adding checks for _v values.
Added detailed tests for v=0 and v=1 cases in ledger-wallet.test.ts.
Added logging for USE_PHYSICAL_LEDGER variable in tests.
Enhanced warning checks in tests for ledger app version.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Notes before the weekend

celo-legacy transactions not impacted
celo-modern (eip1559 or cip64) both impacted
traced the issue to<EMAIL_ADDRESS>where changing the code as follow

- v = ecc_parity % 2 == 1 ? "00" : "01";
+ v = ecc_parity % 2 == 0 ? "00" : "01";

seems to solve our issues
However it seems very wrong. Send help!

tested celocli transfer on the f6e0e054ec010e53f0be1538ce5f4920e37a5eea commit. all passing cip64 eip1559 celo legacy with and without a fee token. (on leger x and flex)


Release/1.1.0

Codecov Report

Merging #37 (6b0d02c) into master (8fc1613) will increase coverage by 1.11%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   86.41%   87.52%   +1.11%
==========================================
  Files          12       12
  Lines         427      433       +6
  Branches       79       86       +7
==========================================
+ Hits          369      379      +10
+ Misses         32       31       -1
+ Partials       26       23       -3

Impacted Files
Coverage Δ

...lery/src/lib/components/thumbs/thumbs.component.ts
86.20% <83.33%> (+4.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc1613...6b0d02c. Read the comment docs.


undefined method `to_h' for [["error", "invalid_grant"]]:Array

Poke::API::Errors::LoginFailure: Unable to login to PTC => [undefined method to_h' for [["error", "invalid_grant"]]:Array @ /Users/user/.rbenv/versions/2.0.0-p645/lib/ruby/gems/2.0.0/bundler/gems/poke-api-fd27b2c9834f/lib/poke-api/auth/ptc.rb:65:in fetch_access_token']
from /Users/user/.rbenv/versions/2.0.0-p645/lib/ruby/gems/2.0.0/bundler/gems/poke-api-fd27b2c9834f/lib/poke-api/client.rb:27:in rescue in login' 	from /Users/user/.rbenv/versions/2.0.0-p645/lib/ruby/gems/2.0.0/bundler/gems/poke-api-fd27b2c9834f/lib/poke-api/client.rb:23:in login'

I will look into it, it might be easier to monkey patch the Array class to include to_h.

Should be Hash[array]

I think you will get an issue with key word arguments too as they are not supported by Ruby 2.0

@ipepe - could you use the following snippet at the top of your code for now, I will push this fix with the next release.
class Array
  def to_h
    Hash[self]
  end
end

Sure. Thanks.

This has been fixed now in the latest release 0.2.0


RFC: system-components: include custom strings in blacklist

This change would allow you to include any string as an argument to system, and it would be added to the blacklist even if it doesn't exist as a style key in styled-system.
The benefit of this would be that you could use custom props in your system-components to control styling, without having them passed down to child components.
An example of this would be something like:
import system from "system-components";

const Thing = system(
  {
    p: 4,
    bg: "blue",
    color: "white"
  },
  props => ({
    minHeight: props.tall ? "400px" : "200px"
  }),
  "tall"
);

render(<Thing tall />)

This could already be achieved using clean-element, but this way would be a little simpler, and wouldn't add an extra component to the tree.
Potential downside: Right now string arguments mean something really specific - this change would make the API a little less explicit. Users would have to be careful about their custom prop names, to avoid accidentally adding styled-system props. One possible way around this would be to require users to import the styled-system functions and add them as arguments directly (instead of using their string names), but that would be a breaking change.
Let me know what you think! If it seems like a good idea, I can add a test and update docs.

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #119   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines         190    190
=====================================
  Hits          190    190

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c5640...ca0222e. Read the comment docs.

Yeah, in it's current state my PR is pretty half-baked, I'm just kind of thinking out loud trying to see if there could be a nice way to let me users filter out custom props.
One possible API would be something like:
import system from "system-components";
import { borderRadius, fontSize } from "styled-system";

const Thing = system(
  {
    p: 4,
    bg: "blue",
    color: "white"
  },
  props => ({
    minHeight: props.tall ? "400px" : "200px"
  }),
  // Use styled-system style functions directly (their prop names
  // could be internally added to the blacklist via fn.propTypes)
  borderRadius,
  fontSize,
  // String arguments explicitly mean "just add this to the blacklist"
  "tall"
);

render(<Thing tall />)

That would fix the explicitness issue, and the implementation might even be a little simpler. Would be a breaking change, although it would be possible to support both the current API and this one at the same (gaining backwards compatibility at the cost of explicitness).
Again, just thinking out loud though - thanks for the feedback!

Yeah, I wouldn’t want to remove the use of styled-system key strings, since that’s one of the main reasons for having this module.
Another thought: the first props argument could maybe have a blacklist prop, similar to the is prop...

Oh yeah, I like that idea a lot! I know you can already set a blacklist in that first defaultProps argument, but it currently overwrites the blacklist created internally if you do that. If it merged with it instead of overwriting it, that would be perfect.
I can update this PR if that's something you'd be interested in.

@jxnblk Not sure if you got notified or not, but I updated this PR to support setting a blacklist prop in the first argument.


Tracking issue for input/output pin traits

The input/output pin trait available on the 0.2.x versions have been removed ahead of the 1.0.0 release. See: #357
This issue servers as a tracking issue until we add them back.
An interface should be worked out which allows changing the pin mode while being useful and usable by both generic drivers as well as MCU/OS HAL implementations.
IOPin trait as of the 0.2.7 release:

docs
Source

Relevant issues/PRs:

#29
#151
#269
#340
Your issue here!

Please feel free to participate, highlight your current use cases, problems and provide solutions.

I already mentioned this in the prior IoPin discussion, but it's unclear to me what IoPin is meant to do.
There is two things that could change between an input and an output config:

the read functionality could be enabled/disabled (possible on nrf chips)
the pin could switch between being driven/floating

Should switching an IoPin to "read" disable its output? Or should it just enable input capability?
Further, should pin configs that are already InputPin + OutputPin now implement IoPin<Self, Self>? What would that even mean? For example, let's take the pretty common OpenDrain pin config. It is usually already InputPin + OutputPin.

Should it implement IoPin<Self, Self>?
If it is in its driving state, should changing it to "read" switch its output to the floating state?
Should the read buffer (exists for example on nrf chips) be disabled when switching to "write"?
Should it be possible to do .try_into_input_pin(), followed by .set_high()? (As it would be with all IoPin<Self, Self>)

Another question is: Who decides which pin configuration combinations should form an IoPin? Due to having n^2 possibilities, annotating all of the possible combinations would get out of hand very quickly.

it's certainly tricky to express all this huh! i wonder if the type-based swap read and write types is a little artificial.
could we stack traits into something like IoPin: InputPin + OutputPin + PushPull + OpenDrain + OpenSource + TriState?
no change for folks using InputPin or OutputPin, writing to OutputPin while in TriState would set pulls, and to switch from Output to Input you would need to go via TriState (then reconfigure pulls if required).
alternately we could add a DriveMode trait to enable the swapping, generic over markers for common modes like PushPull, OpenDrain, OpenSource, TriState, which for drivers would look something like: IoPin: InputPin + OutputPin + DriveMode<PushPull> + DriveMode<TriState> (and if we wanted, auto-impl the traits above for convenence).

First I'd like to point out that there are 2 questions here :

Do we want/need a  trait for dynamic type where the mode is not known at compile time (ie a pin with a set_mode method) ?
How to properly define a Input/Output trait which handles the mode at compile time ?

Let's consider only the second question and answer the first one once we get there.
I know that all of you know this but et me state the actors here, and their needs :

The trait implementer, who has a pin that can often fake many modes Input,Output,Alt,Floating,Opendrain ...
they don't want to implement all In x Out IoPin types
they don't want to implement a big IoPin with all sub types inside it
they want to keep the promise that only one mode exist for a given pin at any time
The trait consumer, typically a device diver writer who need a common ground to use on any system
here the common ground is having only one Input and one Output mode for  given IoPin
they also want to store this IoPin permanently
The trait user, who assembles a device and a chip
they want to create a specific iopin with one input and one output mode and give it to the consumer

Translated into code

User need means we want a trait IoPin<In,Out>
Common modes means a where In: InputPin, Out: OutputPin
Not having to implement all cases means we must split the trait trait IoPin<In,Out>: IntoInput<In> + IntoOutput<Out>
Keeping the single mode promise imply implementing ̀ fn into_input(self) -> In` with moving semantics
But being able to store it permanently means we prefer using a fn as_input(&mut self) -> &mut In instead

Implementing as_input is not easy, so we have is an impedance mismatch between what consumer need and what implementer can easily implement.
I think this impedance mismatch should be resolved by the hal, it should provide a trait for the consumer,
another trait for the implementer and glue then together with some code.
Here is my attempt : https://github.com/rust-embedded/embedded-hal/commit/25d4f39b503090e258547d48194508e58edaffa5
There is a conversion trait that everyone can implement (and same for output) and could be useful not only for IoPin
trait TryIntoInputPin<I:InputPin> {
   //...
   fn try_into_input_pin(self) -> Result<I, Self::Error>;
}

There is a, iopin trait that is nice to use
trait IoPin<I:InputPin,O:OutputPin> {
  // ...
  fn as_input_pin(&mut self) -> Result<&I, Self::Error>;
  fn as_output_pin(&mut self, state: PinState) -> Result<&mut O, Self::Error>;
}

And there is an implementation of an IoPin called GenericIoPin if the spare implementer from writing the logic.
The drawback of this implementation is that it is not possible to have an infallible version nor a zero sized version. But you can still write your own.
I don't know if having infallible conversion would allow an infallible GenericIoPin since there is is still an Option::take() and I'm not sure if rust can guarantee that we will always insert back something before returning.


Allow other projections than EPSG:3857

Since v0.13.0, ipyleaflet supports custom projections. xarray-leaflet can take advantage of it, since it can reproject.

An initial support for custom projections was done in #8.

v0.1.9 has initial support for custom projections.


REST API to launch simulation

Purpose
Enable powersimdata to communicate with the reisejl container over http, which along with using a shared volume will eliminate the need for ssh within a container based installation.
What it does
Exposes an api endpoint as an alternative way to invoke call.py . This can be called by powersimdata using only the hostname of the container and the scenario id (see the sample curl command in app.py). Note, we could optionally use this on the server but that's not the primary goal here. The state.py module has some helper classes to keep track of which scenarios have been started during the lifetime of the flask app and provide a convenient way to query them (returning the status plus stdout/stderr). I also added a "failed" status for the execute list if any exception occurs during the process.
Minor details - the docker image will now run flask by default so I updated the readme command to override that with bash. Will add more details to the readme once the necessary support is added to powersimdata. For now, this can be run using either flask run on the command line or docker run -p 5000:5000 reisejl after building the image.
Testing
There are some unit tests for the state classes and I've done some manual testing by setting the values in const.py to my local directory and mocking out the main method with test output. I will do some ongoing tests with the full container setup and update this as needed.
Time to review
60 mins - guessing this will be new for a good chuck of people, so I can provide more details or talk through any parts that are of interest

It looks good. How do you want to coordinate with @ahurli since you both modify the README in your PRs?

It looks good. How do you want to coordinate with @ahurli since you both modify the README in your PRs?

Either way, if the documentation PR is merged first I will rebase and fix any conflicts.

Either way, if the documentation PR is merged first I will rebase and fix any conflicts.


NuGet Dependencies Request > 2.1; however, build then produces different version warnings

I've been working with the Appccelerate state machine component for several months now.
When I downloaded the latest component using NuGet (version 2.7), I saw no errors during the NuGet install. During the build, I received a warning about different versions of dependent assemblies. Most importantly, when I ran my unit tests, I received the following error:
Result Message:	System.IO.FileNotFoundException : Could not load file or assembly 'Appccelerate.Fundamentals, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=917bca444d1f2b4c' or one of its dependencies. The system cannot find the file specified.
When NuGet installed the state machine component, I recall that it requested version 2.1.0 of Appccelerate.Fundamentals.
What can we do to correct this issue? My work around is to install version 2.7 of the Appcelerate dependent packages by hand.
Thanks for all your hard work. You have saved me much work by all your hard work.
Have a great day!

Fixed by setting the correct version of the dependency.


import error

I use the script "redirect_requests.py" and it got an error:
Script load error: Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/libmproxy/script.py", line 99, in load
execfile(self.argv[0], ns, ns)
File "/root/Desktop/redirect.py", line 4, in
from libmproxy.models import HTTPResponse
ImportError: No module named models

You're using mitmproxy 0.13 with the examples from master - please use the examples on the 0.13 branch instead.
Cheers,
Max


{go,bats}: dolt add . for dolt_docs, with updated dolt status and bats tests

@bheni this is ready for review again!


[Keyboard Navigation - Azure Search Services - Search Explorer]: The arrow buttons present under "results" pane are not accessible by keyboard.

User Experience:
If the controls or buttons present on the screen are not accessible by keyboard then it will be an issue for keyboard users to perform the functionality related to the button and will also miss important information regarding that button or control.
Note: Login Credentials must not be provided within the bug.
Repro Steps:

Launch the URL: https://ms.portal.azure.com/#allservices.
Login with valid credentials
Navigate to All Services and search "Search Services."
Select the already created service.
Select "Search Explorer" button. New blade starts appearing.
Turn on Tabstops and navigate to "Results" pane.
Verify the issue.

Actual Result:
The arrow buttons present under "Results" pane are not accessible by keyboard. The keyboard focus moves out of the results pane and move to the title of the page and does not go to arrow buttons present on the left side.
Expected Result:
The arrow buttons present under "Results" pane should be accessible by the keyboard. The keyboard focus should not move out of the results pane but should the arrow buttons present on the left side So that the keyboard user can expand collapse the query results.
Note:
Same issue exists in similar panes throughout the application.
This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information & download this tool at https://aka.ms/AccessibilityInsights.
WCAG Reference Link:
https://www.w3.org/TR/UNDERSTANDING-WCAG20/keyboard-operation.html

#Accessibility;#WCAG2.1.1;#HCL;#HCL-AzureSearch-BM;#A11ySev1;#Benchmark;#Win10-Edge(Chromium);#A11yAuto;#Tabstop;#k4W

From the screenshot, I can guess that this is about the folding indicators. Let's track in https://github.com/microsoft/vscode/issues/43262


More complete support for 'tables' package

What does this PR do?
Bundles libblosc2 with the 'tables' package on Windows, and fixes a fork-bomb caused by a call to the 'cpuinfo' package
Why was it initiated? Any relevant Issues?
https://github.com/Nuitka/Nuitka/issues/2535
PR Checklist

[x] Correct base branch selected? Should be develop branch.
[x] Enabled commit hook or executed ./bin/autoformat-nuitka-source.
[ ] All tests still pass. Check the Developer Manual about Running the Tests. There are GitHub
Actions tests that cover the most important things however, and you are welcome to rely on those,
but they might not cover enough.
[ ] Ideally new features or fixed regressions ought to be covered via new tests.
[ ] Ideally new or changed features have documentation updates.

https://github.com/Nuitka/Nuitka/pull/2940/commits/3a6fcae458d7fb83535d81ceb4b9479805915fdb adds a line I missed from the original PR. Required to prevent 'cpuinfo' fork-bomb.

I pushed a commit, making your tables change apply more broadly. I don't know what test you had, so I am just checking if the DLL is included or not.

I pushed a commit, making your tables change apply more broadly. I don't know what test you had, so I am just checking if the DLL is included or not.

Thank you, much appreciated.


Updated uvisor symbols in linker script

This PR updates uVisor symbols in the gcc linker script for K64F.
Changelog:

more consistent start/end symbols of protected regions for easier future porting
protected SRAM and Flash regions removed -- they are not supported any more
changed some of the names to adapt them to their new functionality

[SRAM] .uvisor.bss contains the uVisor protected .bss, containing

the uVisor stack and .bss
the stacks and contexts of the uVisor-protected secure boxes

[Flash] .uvisor.main contains the code and data for uVisor (in Flash, write-protected)
[Flash] .uvisor.secure contains the write- and read-protected configuration for the secure boxes

the configuration tables (one for each box)
a list of pointers to the configuration tables (for box enumeration at startup)

@meriac This is a PR still inside my fork (upstream is untouched). Let's code review here and then create an official PR into upstream

+1, can be merged


Yes Mjumbe, I placed my plot in the wrong folder. Give me 1 minute!!


[vioscsi] Fix SendSRB notify regression

Related issues:
#756
#623
#907
...
[likely others]
Regression was introduced in #684 between https://github.com/virtio-win/kvm-guest-drivers-windows/commit/7dc052d55057c2a4dc2f64639d2f5ad6de34c4af and https://github.com/virtio-win/kvm-guest-drivers-windows/commit/fdf56ddfb44028b5295d2bdf20a30f5d90b2f13e.
Specifically due to commits https://github.com/virtio-win/kvm-guest-drivers-windows/commit/f1338bb7edd712bb9c3cf9c9b122e60a3f518408 and https://github.com/virtio-win/kvm-guest-drivers-windows/commit/fdf56ddfb44028b5295d2bdf20a30f5d90b2f13e (considered together).
Prior to the regression, we did not issue virtqueue_notify() outside inside spinlock. This behaviour has been restored.
Prior to the regression, we issued virtqueue_kick_prepare() inside spinlock. This behaviour has been restored.
Note: We also do not want to issue virtqueue_notify() for a corrupt or failed buffer so this has been removed where virtqueue_add_buf() does not return SUCCESS. The virtqueue_add_buf() routine will return 0 on SUCCESS or otherwise a negative number, usually -28 (ENOSPC).
Freedom for Windows guests once held captive...! 8^D
cc: @vrozenfe @JonKohler @sb-ntnx @frwbr @foxmox
Related external issues (at least confounded by this regression):
https://bugzilla.proxmox.com/show_bug.cgi?id=4295
https://bugzilla.proxmox.com/show_bug.cgi?id=4295
https://bugzilla.kernel.org/show_bug.cgi?id=199727
...
[likely others]

Note my edit above, lots of distractions atm... 8^d

Prior to the regression, we did not issue virtqueue_notify() outside inside spinlock.

@vrozenfe @JonKohler @sb-ntnx @frwbr @foxmox
All the checks have passed.
If there are no concerns, I'll move this from draft to review in about 12 hours...

Hi, many thanks for opening this targeted PR!
I applied your patch on top of current master (22d0908a28f382d02d8d3a10a0ee0631af480fdf) and ran the reproducer from https://github.com/virtio-win/kvm-guest-drivers-windows/issues/756#issuecomment-2012089151 again (details on setup below). With this patch, I have not seen Reset to device, \Device\RaidPort[...] vioscsi warnings in the event log yet, nor Desc next is 3 messages issued by QEMU on the host. On current master (without this patch), I see both. So this patch looks very promising!
I have one comment:

Regression was introduced in #684 between 7dc052d and fdf56dd. Specifically due to commits f1338bb and fdf56dd (considered together).
Prior to the regression, we did not issue virtqueue_notify() ~outside~ inside spinlock. This behaviour has been restored.

Has been some time since I last looked into the code -- but isn't it the call to virtqueue_kick_prepare (not virtqueue_notify) that is currently (on current master) issued outside the spinlock, and with this patch moves inside the spinlock? If I'm not mistaken, the call to virtqueue_kick_prepare used to be inside the spinlock before commit https://github.com/virtio-win/kvm-guest-drivers-windows/commit/f1338bb7edd712bb9c3cf9c9b122e60a3f518408, which moved it outside the spinlock.

Regards,
Ben

@benyamin-codez
Sorry for delay in response.
And thank you for your work.
All the best,
Vadim.

@vrozenfe
My pleasure Vadim. Happy to help.
This one should bring welcome relief to many once merged and packaged.
Best regards,
Ben


Fixed GPS Sensor and Compass usage for baselines using float32 for GPS & Compass sensors

Motivation and Context
Fixed GPS Sensor and Compass usage for baselines in https://github.com/facebookresearch/habitat-lab/issues/604. Specifically the PR is fixing error:
RuntimeError: expected scalar type Float but found Double

How Has This Been Tested
Added additional tests to avoid issues in future.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

CI is failing because checkpoints are getting overwritten

Closing in favor of https://github.com/facebookresearch/habitat-lab/pull/606 as this branch isn't expected to be rebased on latest master.


Updating Device Registry

What does this PR do?

Storage of newly created device on local/production DB
Addition of description field in request data, removal of  ISP, manufacturer, phone number from the description field stored
Retrieving all devices from the database
Pending work: An endpoint for deploying a device

What JIRA task is related to this PR?
The link to the JIRA board task is here.
How do I test out this PR?
Git clone this repo cd AirQo-api/src/device-registry Then run npm install to get all the necessary dependencies Afterwards run npm run dev or npm run stage to test out the end points using any REST client tool available to you.
Which end points should are ready for testing?

base url: http://localhost:3000/
[GET] [Get All Devices] partial url: /api/v1/devices?limit="number"&skip="number"
[POST]  [create Thing] partial url: api/v1/devices/ts

API documentation is here for more details. Please visit the device-registry sheet.

Just some few conflicts to be taken care of


[BUG] - cardano.node.DnsSubscription:Error Application Exception: ExceededTimeLimit

External
Area
Other
Summary
node not syncing, errors found in console log:
[dell:cardano.node.ChainDB:Info:5] [2020-12-15 22:05:59.07 UTC] Opened db with immutable tip at genesis (origin) and tip genesis (origin)
[dell:cardano.node.ChainDB:Notice:34] [2020-12-15 22:05:59.07 UTC] Chain extended, new tip: d2d90d10993b3eb309f5485a5413cb9c9fe4f088e79b7b4e815dbbe8fcb8e4b7 at slot 0
[dell:cardano.node.DnsSubscription:Notice:62] [2020-12-15 22:05:59.08 UTC] [String "Connection Attempt Start, destination <IP_ADDRESS>:3001",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.DnsSubscription:Notice:63] [2020-12-15 22:05:59.10 UTC] [String "Connection Attempt Start, destination <IP_ADDRESS>:3001",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.DnsSubscription:Notice:64] [2020-12-15 22:05:59.13 UTC] [String "Connection Attempt Start, destination <IP_ADDRESS>:3001",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.DnsSubscription:Notice:63] [2020-12-15 22:05:59.13 UTC] [String "Connection Attempt End, destination <IP_ADDRESS>:3001 outcome: ConnectSuccess",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.DnsSubscription:Notice:65] [2020-12-15 22:05:59.15 UTC] [String "Connection Attempt Start, destination <IP_ADDRESS>:3001",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.DnsSubscription:Notice:64] [2020-12-15 22:05:59.16 UTC] [String "Connection Attempt End, destination <IP_ADDRESS>:3001 outcome: ConnectSuccessLast",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.ErrorPolicy:Notice:54] [2020-12-15 22:05:59.16 UTC] [String "ErrorPolicySuspendConsumer (Just (ConnectionExceptionTrace (SubscriberError {seType = SubscriberParallelConnectionCancelled, seMessage = \"Parallel connection cancelled\", seStack = []}))) 1s",String "ErrorPolicyTrace",String "<IP_ADDRESS>:3001"]
[dell:cardano.node.ErrorPolicy:Notice:54] [2020-12-15 22:05:59.16 UTC] [String "ErrorPolicySuspendConsumer (Just (ConnectionExceptionTrace (SubscriberError {seType = SubscriberParallelConnectionCancelled, seMessage = \"Parallel connection cancelled\", seStack = []}))) 1s",String "ErrorPolicyTrace",String "<IP_ADDRESS>:3001"]
[dell:cardano.node.DnsSubscription:Error:63] [2020-12-15 22:06:09.23 UTC] [String "Application Exception: <IP_ADDRESS>:3001 ExceededTimeLimit (ChainSync (Header (HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (Tip HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (ServerAgency TokNext TokCanAwait)",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.ErrorPolicy:Notice:54] [2020-12-15 22:06:09.23 UTC] [String "ErrorPolicySuspendConsumer (Just (ApplicationExceptionTrace ExceededTimeLimit (ChainSync (Header (HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (Tip HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (ServerAgency TokNext TokCanAwait))) 20s",String "ErrorPolicyTrace",String "<IP_ADDRESS>:3001"]
[dell:cardano.node.DnsSubscription:Error:64] [2020-12-15 22:06:09.26 UTC] [String "Application Exception: <IP_ADDRESS>:3001 ExceededTimeLimit (ChainSync (Header (HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (Tip HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (ServerAgency TokNext TokCanAwait)",String "SubscriptionTrace",String "\"relays-new.cardano-mainnet.iohk.io\""]
[dell:cardano.node.ErrorPolicy:Notice:54] [2020-12-15 22:06:09.26 UTC] [String "ErrorPolicySuspendConsumer (Just (ApplicationExceptionTrace ExceededTimeLimit (ChainSync (Header (HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (Tip HardForkBlock (': * ByronBlock (': * (ShelleyBlock (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Allegra StandardCrypto)) (': * (ShelleyBlock (ShelleyMAEra 'Mary StandardCrypto)) ('[] *))))))) (ServerAgency TokNext TokCanAwait))) 20s",String "ErrorPolicyTrace",String "<IP_ADDRESS>:3001"]

Steps to reproduce
started the node with the following command:
./cardano-node run --topology configs/mainnet-topology.json --database-path storage/ --socket-path storage/node.socket --host-addr <IP_ADDRESS> --port 3001 --config configs/mainnet-config.json --shelley-kes-key kes.skey --shelley-vrf-key vrf.skey --shelley-operational-certificate node.cert

Expected behavior
cardano-cli shelley query tip --mainnet returns with other then this
{
    "blockNo": 0,
    "headerHash": "d2d90d10993b3eb309f5485a5413cb9c9fe4f088e79b7b4e815dbbe8fcb8e4b7",
    "slotNo": 0
}

System info (please complete the following information):

OS: Ubuntu
Version: 18.04
Node version: 1.24.2

Additional context
also not working with earlier versions of node. It worked around 1 week ago.

I faced same issue

Resolved after updating config files from
https://hydra.iohk.io/job/Cardano/cardano-node/cardano-deployment/latest-finished/download/1/index.html

For me the solution was to modify the default topology list. It seems that relays-new.cardano-mainnet.iohk.io does not work. Here you can find a list of relays you can use
this can be closed


JPanel title font isn't changed

Oh sorry i meant JPanel titled border
On Wed 26 Dec, 2018, 20:54 Vincenzo Palazzo<EMAIL_ADDRESS>wrote:

Hello @TheGreat2201 https://github.com/TheGreat2201,
You're referring to the title in the JFrame, right?
Because the JPanel does not have a setTitle () method, so a possible
setting in a JPanel does not depend on the Theme, you can better explain
your problem because I did not understand well, you can post a screen if
you have the possibility
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atarw/material-ui-swing/issues/52#issuecomment-449981140,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AizZZ4BxAxvQSqNPir0n4tkcPaQ66wyBks5u85SwgaJpZM4Zhzbd
.

On 26-Dec-2018 8:54 PM, "Vincenzo Palazzo"<EMAIL_ADDRESS>wrote:
Hello @TheGreat2201 https://github.com/TheGreat2201,
You're referring to the title in the JFrame, right?
Because the JPanel does not have a setTitle () method, so a possible
setting in a JPanel does not depend on the Theme, you can better explain
your problem because I did not understand well, you can post a screen if
you have the possibility
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atarw/material-ui-swing/issues/52#issuecomment-449981140,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AizZZ4BxAxvQSqNPir0n4tkcPaQ66wyBks5u85SwgaJpZM4Zhzbd
.

@vincenzopalazzo
Like this

@TheGreat2201, I understand your problem, we will try to solve the problem as soon as possible.
Thanks for the tip

@vincenzopalazzo Sure. Can you tag me in the next commit which fixes this?

@TheGreat2201 yes

Hello @TheGreat2201,
I tried to fix your problem and now I have run a pull request, I could not find a better solution for now and then I created a Wrapper and encaps the code inside MaterialTitleBorder, you can create your MaterialTitlePane with the following piece of code:
MaterialTitleBorder materialTitleBorder = new MaterialTitleBorder("Test new Title Border component");
Or you can customize your titleBorder with the setFont and setBorder methods.
find the solution already released in this section here pending the answer of @atarw
https://github.com/vincenzopalazzo/material-ui-swing/releases/tag/v<IP_ADDRESS>
I hope to be proved helpful.

Thanks a lot. I'll try this
On Thu 27 Dec, 2018, 02:44 Vincenzo Palazzo<EMAIL_ADDRESS>wrote:

Hello @TheGreat2201 https://github.com/TheGreat2201,
I tried to fix your problem and now I have run a pull request, I could not
find a better solution for now and then I created a Wrapper and encaps the
code inside MaterialTitleBorder, you can create your MaterialTitlePane with
the following piece of code:
MaterialTitleBorder materialTitleBorder = new MaterialTitleBorder("Test
new Title Border component");
Or you can customize your titleBorder with the setFont and setBorder
methods.
find the solution already released in this section here pending the answer
of @atarw https://github.com/atarw
https://github.com/vincenzopalazzo/material-ui-swing/releases/tag/v<IP_ADDRESS>
http://url
I hope to be proved helpful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atarw/material-ui-swing/issues/52#issuecomment-450027292,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AizZZ2EzE-oRCi_Nnyv0JB4ma-2OYX6Pks5u8-bDgaJpZM4Zhzbd
.

There's a better way using UIManager properties that doesn't require you to change your code to use a new border class :) Pushed a fix to the repo, thank you @vincenzopalazzo for your help!!

@atarw There's a better way using UIManager properties that doesn't require you to change your code to use a new border class :) Pushed a fix to the repo, thank you @vincenzopalazzo for your help!!


How to deploy upgradeable contracts in conjunction with @openzeppelin/hardhat-upgrades?

How to deploy upgradeable contracts in conjunction with @openzeppelin/hardhat-upgrades?

Hey, @bentong-chain, @openzeppelin/hardhat-upgrades is a separate plugin and approach to upgrading smart contracts.
You can upgrade contracts using Ignition, see our docs on upgradable contracts.
Are there particular use cases you are interested in for combining the two?

I need a specific use case for combining the two plugins, thanks


openHAB widget gest stuck on one value

How to represent:
Try to change dimmer by hand gesture, then by moving the dimmer in Unity (must by okay), then by changing it on the server (must be okay), but after some time it gets stuck on one value.
Get logging from ADB to fix it

Flickering on one value must have been fixed. Closing the issue until observing it again


How to safely define a selection of dimensions to average across?

The average function will allow averaging across multiple dimensions. But what do we call them?
Here is a suggestion to be discussed:

time - should match our standard parameter name for submitting over time
level - should match our standard parameter name for submitting over level
latitude - allowed (but might not always exist)
longitude - allowed (but might not always exist)
y - if y-axis is not really latitude
x - if x-axis is not really longitude

Main issue: the user doesn't know what the options are - so we need to map them.

@huard : I would be interested to hear your thoughts on this issue. Do you have some similar code where you have made these decisions? Thanks

Time and level are not ambiguous, but I'm not sure about the use case you have in mind for averaging over lat and lon individually. Do mean zonal and meridional means ? Apart from theses, I don't see cases where lat/lon means would be done individually. Most use cases would refer to a spatial mean (bbox or polygon). In fact, zonal/meridional means are special bases of bbox subsetting. And bboxes are always defined as lat/lon, so users should never really have to worry about native x/y coordinates.

@huard: Thanks for your comments on the dimension averaging issue.
I agree that there won't be many use cases for averaging across X and Y dimensions that are not latitude and longitude. I suspect that we will need to adapt our original plan. I had naively thought that we would only have to consider grids as part of the regridding process. However, they come into play in some cases of averaging and subsetting as well. We need a holistic solution.
@cehbrecht and @sol1105 - note the above comments in terms of the regridding workflows.


What is a DAX volume?

In the description of FLTFL_REGISTRATION_SUPPORT_DAX_VOLUME, there should be a link to where DAX volumes are described, and a description of when and why a DAX volume should/would be filtered

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 020480f3-b724-f282-cce8-43d7cde038d2
Version Independent ID: 84eeb4e3-4d88-862c-276e-7496c0f35f9b
Content: _FLT_REGISTRATION (fltkernel.h) - Windows drivers
Content Source: wdk-ddi-src/content/fltkernel/ns-fltkernel-_flt_registration.md
Product: windows-hardware
GitHub Login: @lorihollasch
Microsoft Alias: loriwhip

Hi @briancatlin, thanks for this excellent suggestion. I had hoped to get this done, but other priorities continue to drive this work out. I've filed an internal task for myself to add this information, so am going to close out this issue. In the interim, you can learn more by scanning through a couple of presentations done by Neal Christiansen about persistent memory and DAX:
https://www.flashmemorysummit.com/English/Collaterals/Proceedings/2016/20160810_FR21_Christiansen.pdf
https://www.snia.org/sites/default/files/SDC/2017/presentations/Solid_State_Stor_NVM_PM_NVDIMM/Christiansen_Neal_Update_on_Windows_Persistent_Memory_Support.pdf


(DOCSP-43184) Removed deprecated attributes for Webhook generation an…

DOCSP-43184

In githubactions.go and globals.go:

Removed deprecated attribute (ssl_verify) that prevented onboarder from adding Webhooks to forked repos.

In .goreleaser.yaml:

Added version: 2 header to prevent version error.
Removed deprecated archive attribute and replaced deprecated tap attribute with repository.

Could you also update the file so it passes goreleaser check?


Ffmpeg

This PR includes:

adding a sound class for decoding any type of sound and playing it

Needs:

tests
factory classes
lua bindings
interface class/concept

Codecov Report
Base: 79.87% // Head: 71.54% // Decreases project coverage by -8.33% :warning:

Coverage data is based on head (af8b695) compared to base (72915a1).
Patch coverage: 1.94% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   79.87%   71.54%   -8.33%
==========================================
  Files          48       49       +1
  Lines        1719     1919     +200
==========================================
  Hits         1373     1373
- Misses        346      546     +200

Impacted Files
Coverage Δ

src/drawing/SplashWindow.cpp
0.00% <0.00%> (ø)

src/sounds/FFmpegOpenAlSound.cpp
0.00% <0.00%> (ø)

src/lua/Bootstrapper.cpp
78.72% <50.00%> (ø)

src/resource_managers/FontLoaderImpl.cpp
81.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Deterministic for loops for dictionaries

Note: I was a bit too quick and merged #240 into the wrong branch, and github won't allow me to fix things without a new PR 🤷♂
With Swift 4.2, hashing isn't consistent between runs anymore. A consequence of this is, if we iterate over a dictionary, the output won't always be the same, which will be unexpected for a user.
With this PR we iterate over the sorted keys of a dictionary, ensuring consistent output across runs.

So, small discussion point from #240 is that the current Stencil behaviour was, until now, undefined.
So let's define it then. An important note should be that the behaviour should be consistent, no matter the swift version you compile Stencil with (4 vs 4.2).

When compiled with Swift 4, the output was always in the same order (but unsorted)
When compiled with Swift 4.2, the output is random (and unsorted)
This PR ensures that the output is always in the same order, and to do so, it's sorted (ascending).


maxBackfaceHiddenSlides parameter doesn't work when given less than 10

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/xctr65
Bug description
When updating a swiper based with the new slides getting the Back Face slides even if we provide value to the Param maxBackfaceHiddenSlides to 0 or 1. This doesn't work when the value given for maxBackfaceHiddenSlides is less than 10.
Expected Behavior
Back face should not display when updating the slides in the swiper.
Actual Behavior
No response
Swiper version
9.4.1 also happen with latest 10 and 11 version
Platform/Target and Browser Versions
macOS chrome
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Latest swiper version is 11.x
Your demo link doesn't demonstrate the issue


Update tests files for Jenkins CI. - [closed]

In GitLab by @guyingyan on Apr 24, 2018, 03:30
Merges dev-jenkins-test-update -> dev

In GitLab by @wknet123 on Nov 13, 2019, 10:50
closed


Portrait photos switching to landscape automatically

I have some portrait photos (960w x 1280h) that I'm running thru a Photo Size of 944 width and 400 height. I have upscale, crop, and pre-cached all checked.
The resized photo is rotated 90 degrees counter-clockwise and I don't know why.
This happens with quite a few photos. The stored originals are still the correct orientation, so this is something with the image processor making the decision to do the rotation.

crickets
Really? I'm the only one who's getting this? :-)

Maybe the images are rotated based on EXIF data?
There's a fix for this on the master branch - see https://github.com/jdriscoll/django-photologue/commit/7cad9750cd4ee6c2ee143c5a237da55f9137017e - but it has not been released yet.
Maybe you could try running the master branch of Photologue and see if it fixes your issue?

That would make sense. I think this photo is off an iPhone so it could have some orientation data based on the phone's gyros. I'll try this today!

That did the trick! Thanks

That's great to hear.
I have just released Photologue 3.2 which includes this fix, so I can now close this issue.


A11y_ControlUIupdatebasedonSantoriniOSvisualupdate_MiniControGallery_GenericControls_Keyboard : The "Hello World" text besides Tooltip receives keyboard focus which is incorrect.

GitHubTags: #A11y_ControlUIupdatebasedonSantoriniOSvisualupdate, #A11yMAS, #A11yTCS, #Win10, #DesktopApp, #WindowsUILibrary, #MAS2.1.1, #Keyboard
Environment Details:
Application Name: Control UI update based on Santorini OS visual update
Application Version: <IP_ADDRESS>
Windows Version: Windows10
Screen Reader: Narrator, NVDA 2019.2
Steps to Reproduce:

Launch Mini Control Gallery App from the installer location.
Screen with all generic controls would appear on left side of the screen.
Verify that all the elements of "MiniControlGallery-Generic Controls" are accessible and MAS Compliant.

Actual:
When keyboard users navigate through the screen an inactive element that is "Hello World" text receives keyboard focus which is present besides Tooltip.
Expected:
The "Hello World" text should not receive keyboard focus while navigation since it is not an interactive element.
User Impact:
If an inactive element receives keyboard focus, then the keyboard users will interpret it as an interactive element which will lead to confusion.
Attachment
A11y_ControlUIupdatebasedonSantoriniOSvisualupdate_MiniControGallery_GenericControls_Keyboard  The Hello World text besides Tooltip receives keyboard focus which is incorrect..pptx

Because the purpose of the app is to show visual changes at a glance, the app has very atypical usage of the ToolTip control. In practice, ToolTips aren't used in this way. Because this app does not ship to customers, we won't update this ToolTip behavior.


Add ranking order to set higher priorities over rank

This PR changes how the gem is ranked by default pg_search.rank DESC, followed up by order_within_rank as the tiebreaker. Now, it supports ordering by other fields BEFORE pg_search.rank
In my case, ranking is not the most important to be considered first. For instance, we have options to sort by relevance order (1) AND posted date order (2). The requirement for (2) will respect the posted date order before another matching, similar to partitioning by date and apply ranking inside the partitions.
This option ranking_order somehow is opposite to order_within_rank, please suggest me a proper name.

I need to order using a custom distance function, so this unfortunately isn't flexible enough.
However, I found I can simply use reorder to get rid of the pg_search ranking order and use my own order.

@futuretap I am still unclear on what your use case is, can you please provide me more context, perhaps a SQL query?
The option ranking order may come with a hash or string. If your distance is the below distance_meters
SELECT earth_distance(
  ll_to_earth(37.77492, -122.41942),
  ll_to_earth(40.71278, -74.00595)
) AS distance_meters

Then the option is simply ranking_order: "distance_meters DESC".
In my case, I want to count the tsvector weight as well, so your change reorder must have a way to count #{rank_table_alias}.rank as well if I don't get wrong.

My order is using PostGIS: location <-> 'SRID=4326;POINT(11.0 48.0)'::Geometry and I don't want to use the search rank at all.


⚠ ClamAV has degraded performance

In 2214186, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 221 ms

Resolved: ClamAV performance has improved in 8ae1723.


Fix stale bot

Fixes similar patch than https://github.com/huggingface/accelerate/pull/2052/
cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Please come back stalebot 😭


Error when running for the first time - app-nginx-1    | /bin/ash: illegal option -

FIXED: I will leave this here in case anyone else has this issue.
The problem is that Windows uses \r\n as an end of line, whereas unix only uses \n. So, inside my nginx\docker-entrypoint.sh file, there was a ^M character that led to the error /bin/ash: illegal option
Use a text editor such as Notepad++ at the Windows machine to convert
Go to menu Edit -> EOL Conversion -> Unix (LF)
Save, remove the image from docker desktop and start again.
Once that is done, the docker build works correctly.
--
Hi
Just followed the install.
I'm on Windows 10
I have docker desktop running
I ran make up for the first time and I get this:
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1    | /bin/ash: illegal option -
app-nginx-1   | /bin/ash: illegal option -
app-nginx-1 exited with code 2
That's on repeat
The other containers run e.g. db, redis and backend
Any help please

I found the fix
Open the nginx/docket-entrypoint.sh in notepad++
Menu Edit > EOL > Unix LF
Save


content: add welcome page to readme

Creates a Welcome Page to welcome and instruct new members to the Ockam Team.
Provides guidance on adding oneself to the contribution list, gaining access to Ockam's Github organization and contributing to the website repository.

@CAOakleyII can you rebase and merge to develop

merged in https://github.com/build-trust/ockam-website/pull/689


Why Pyinstaller is classified as Malware ?

Is there any specific reason Pyinstaller is classified as Malware ?

Read the following:
https://github.com/bartblaze/Yara-rules#help-a-generic-rule-is-hitting-my-software


Direct exception delivery problem when Dubbo is upgraded to 3.2.7

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Ask your question here
After Dubbo was upgraded to 3.2.7, spring was also upgraded to 6.0.13. Discover the exception delivery mechanism in the new version. Exceptions thrown at each layer are wrapped with ExecutionException and then passed upward. This causes the previous logic of using spring aspects to capture specified exceptions and return exception content to fail.
For example, for three-layer calls, the result is that the structure captured by the top layer is
java.lang.RuntimeException(
   java.util.concurrent.ExecutionException(
           org.apache.dubbo.rpc.RpcException(
                        java.util.concurrent.ExecutionException(
                                   cn.aradin.sdk.base.exception.CustomizedSdkException: ERRMSG
                        )
          )
   )
)

Similar to this multi-level structure wrapped by ExecutionException. Among them, CustomizedSdkException inherits from RpcException, and can be caught in the uppermost aspect in the old version.
Is there a solution to this?
Ask your question here
Dubbo升级至3.2.7之后，spring也一起升级至6.0.13。发现新版中异常的传递机制，在每一层抛出的异常都使用ExecutionException包装，然后再向上传递。这就导致之前的使用spring切面抓取指定异常并返回异常内容的逻辑失效。
比如对于三层调用，造成的结果就是最上层抓到的结构为
java.lang.RuntimeException(
  java.util.concurrent.ExecutionException(
          org.apache.dubbo.rpc.RpcException(
                       java.util.concurrent.ExecutionException(
                                  cn.aradin.sdk.base.exception.CustomizedSdkException: ERRMSG
                       )
         ）
  ）
)

类似这种被ExecutionException包裹的多级结构。其中CustomizedSdkException继承自RpcException，在旧版中最上层的切面是可以抓到。
这个有办法解决么？

CustomizedSdkException is a checked exception or un-checked exception?

As org.apache.dubbo.rpc.RpcException extends from RuntimeException, the CustomizedSdkException which extends from RpcException should be also a child-exception of RuntimeException. So, an un-checked exception?


Catch calc exception.

Both the calc command and roll do not catch a calculation exception from numexpr. They should at least catch the error and let the user know that there was an issue.

Check for a syntax error added to calc, roll, and roll_sim commands.
Update in commit 30d6d73.


MF-1088 - Remove message payload content type

Signed-off-by: Manuel Imperiale<EMAIL_ADDRESS>Resolves #1088

Codecov Report

Merging #1121 into master will decrease coverage by 0.03%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
- Coverage   76.22%   76.19%   -0.04%
==========================================
  Files          94       94
  Lines        6546     6545       -1
==========================================
- Hits         4990     4987       -3
- Misses       1220     1221       +1
- Partials      336      337       +1

Impacted Files
Coverage Δ

transformers/senml/transformer.go
81.81% <85.71%> (-5.69%)
:arrow_down:

http/api/transport.go
72.61% <100.00%> (-0.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01aa419...f4ccb48. Read the comment docs.


Unique Reference Number

The tool should calculate a unique reference number for each run. This could be some form of 'checksum' based on the contents of the raw data file, data config and analysis config.
This same reference number should be included on both the anonymous and non-anonymous reports in order to link the two reports for traceability.

The following Unique IDs are now generated and given in the anonymous report:

A hash of the file contents of the analysis config xml.
Per dataset:
--An invariant random ID that does not change when changes to the dataset config are made
--A hash of the file contents of the dataset config
a hash of the contents of the time series file
All hashes of file contents ignore white space.
https://github.com/peterdougstuart/PCWG/pull/101


Allow configuring HTML embedding

Currently, the HTML embedder splits a webpage into sections for each paragraph, code block, header etc.
This works pretty great for articles and blog posts, where information is divided as such and each paragraph can be used independently. However, this falls apart for most documentation as it loses the relationship between a paragraph explaining code, and the code it's explaining.
It would be cool if this splitting behavior was configurable. I think the default behavior is fine for most cases, but the added ability of either only splitting on certain tokens, or not splitting at all would also be great options to have.

Yes. It makes sense. But most applications may require splitting as people use it for RAG and the chunky size needs to be moderate. Do you have any ideas in mind for the splitting strategy. One option that I can think of is to convert the webpage to markdown style format and chunk it like any other markdown. Let me know if you have any other alternate option.

Yeah I think the current splitting strategy makes sense and works well for most sites, it's just the few where it doesn't 😅
Something that groups by content under a heading would be ideal for the remaining "some" I think - if we can convert to Markdown to keep the context of Heading, paragraph, code etc then that'd be even better!

Great, I will add some splitting strategy options that can be passed in the function signature.


style: remove extra padding on export modal

Contributes to #
This PR should fix issue https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/2812. There is an extra 24px ($pacing-06) in bottom padding of export modal. PR removes this extra padding.
What did you change?
Remove extra bottom padding in export modal.
How did you test and verify your work?
Tested using local storybook. Screenshot of modal looks like following

@all-contributors add @mgallo25 for code


Set up CI workflow

Closes #6
Changes

Added workflow for running tests
Added yarn build script which removes the dist directory
Added basic test

I created #14 to add tests for the existing methods


Clamp luminance to 0

Related issue: #547
Description
Artifacts were caused by negative texture value (not sure why), but clamping it to 0 fixed it.

still geting artifacts on Android, will debug tommorow


localhost is currently unable to handle this request.

I have downloaded the code from https://github.com/aspnet/Docs/tree/master/aspnetcore/host-and-deploy/windows-service/sample and hosted as windows service.
But when I enter http://localhost:5000 , page is not loading.
What I might be missing?
I have installed using below command
sc create MyService binPath= "c:\svc\aspnetcoreservice.exe"

Does the app run as a console app (dotnet run --console from the project folder at a command prompt)?
You started the service after you created it (sc start MyService)?
Is the app on an IIS server behind a firewall (open port 5000 in the firewall)?

AFAIK the sample and instructions are good. I need more info to diagnose further. Closing now, but we can re-open if needed.


Call __destroy_into_raw everywhere a value is consumed

When using weak references the object needs to be unregistered from the finalization registry when we pass it to a Rust method that takes in the object by value. This wasn't happening, which meant that the finalizer was called despite the object already being freed. For me this manifested as a 'recursive use of an object detected which would lead to unsafe aliasing in rust' exception.

Thanks! Would it be possible to add tests for this?

@alexcrichton I've added a test which creates a bunch of garbage and then calls the GC, but unfortunately this exposed another problem: the classes test does a double borrow which leaves the WasmRefCell in a poisoned state, since the RefMut isn't dropped. I've added a .free() to the test to make it explicit, if you remove the free then the test I added fails instead.
Let me know what's the right way to proceed...

I modified it to catch the b.free() exception so the tests pass at least

While not a great hack around this it seems reasonable enough to me for now, thanks!


Add CreationFailure exit code

Fixes #9531
Status
Not tested
Description
Add a missing exit code to WMExceptions.py
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
NA
External dependencies / deployment changes
NA

@amaltaro Any need to update the defaultMsg here to reflect the new message I put in WMExceptions?
https://github.com/dmwm/WMCore/blob/bd40c3e88055913531c012576f3fff5b2b68af25/src/python/WMComponent/JobCreator/JobCreatorPoller.py#L738

Interesting, I'm curious to know what that condition would be. Could you please try to find where it's supposed to get triggered? Otherwise it makes sense to me to also update that default msg.

@amaltaro I looked around for a case where failedReason would not be set when creating a failed job. No guarantees my search was exhaustive, but 30 mins seemed like enough time to spend tracing where this can be set.
Hence, I updated defaultMsg to reflect the error message from the exception.

Yes, it looks like failedReason is always present on those jobs that failed to be created:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/JobSplitting/JobFactory.py#L139
Erik, please request a review via GH Reviewers once you're happy with your changes.


port number from command line

changes for a port being passed as a command line argument. please review.

Looks good to me, +1.
Ideally we'd have it choose a default, and be overridable, but that's going to require some refactoring of the cli tool.
@gsilvis, @lokI8, @henn, can one of you do a second review?

exception handling for invalid port number committed

changes committed

Okay, this seems to be working. @gsilvis, this does break backwards compatibility, but I'd like to just not worry about it --- it's in a dev tool and I don't want to imply any promises unless we need to. Thoughts? I'm otherwise happy with this, +1

+1, merging. Ian's right that we need optional arguments in the CLI


Use html attribute hidden to hide instead of class

u-toggle-visibility.scss
a suggestion. What do you think ?

I would approach it like that these days.


Rethink design of RunBot

Currently, RunBot uses reflection to start each bot, but this is non-intuitive for newcomers to Symphony and the symphony-java-client, and doesn't promote best practices in their own bots (reflection being generally considered bad practice in Java).

Background: during the Open Innovation Challenge Silicon Valley, one team lost approximately an hour trying to figure out why their main method wasn't taking effect (they'd copied-and-modified the HelloWorldBot).  Turns out that main moved to RunBot, but had been left in HelloWorldBot.  As soon as I discovered that I ripped main out of all of the individual bot (to try to minimise confusion in the future), but there was still some confusion about how RunBot worked, even after we'd figured out that particular problem.

The develop branch is ready for a review on this. TY for raising the issue @pmonks !