Naming is all uppercase with underscores

Template display names should be in title case https://developers.google.com/tag-manager/templates/style

Fixed. Thanks!


Use "PARAMETERS" in the documentation headings.

For consistency.

[x] documentation is added or updated
[ ] tests are added or updated

Merged, thanks.


Couldn't find puppeteer

Hi, I liked your project and it really works. However when I tried to scraping some data, I met few problems. It says that couldn't find the puppeteer-extra module. I checked that I have npm and node but I just can't do the scraping. Could you please tell me how to do that? Thank you so much. My email is<EMAIL_ADDRESS>

I finished it, but I met another problem that when I ran node index.js, I got an error.


Resolve syncing conflicts from repo_sync_working_branch to master

Pull request opened by Docs to resolve syncing conflicts from repo_sync_working_branch to master.

@cxwtool : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

We resolved the merge conflict and will merge the PR.


[e2e]: generic schedule main attestation-name slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2908847268
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Aug 23 04:32:51 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2916435862
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.attestation-name.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Aug 24 04:39:16 UTC 2022
Tests are passing now. Closing this issue.


Cannot get to main interface

I'm currently running Linux Mint 17.3, MATE edition on a white unibody Macbook. I recently installed the webplayer and was able to sign in after completing the captcha challenge. However, the next screen I got to just had the spotify logo on it with a green button saying Log in with Spotify. I click on the the button, and another window seems to open but disappears just as quickly. Nothing else happens. This makes the app unusable.

Duplicate of #67

A new fix for anyone who may want to continue to use my application has been applied in commit b325d4c391f9d1e8749b71c16290433837625173. A new release ASAP.


Please distinguish between "monitoring" and "Shadowing"

[Enter feedback here]
So I had a request from a customer to support session shadowing in AVD.  When I do a search for "AVD session shadowing" the search result comes back with this page.  It leads you to believe that AVD supports session shadowing via Bastion, when in fact we don't.  Perhaps this distinction makes sense to the PG but to our customers, it does not.  Especially when an internet search sends you to this page.
Thanks!  Paul
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d8f8711-29cb-4d2a-54f2-4be097c4b319
Version Independent ID: cf1d18e3-5d83-b982-29a4-4a95a10f78a0
Content: Azure Bastion session monitoring and management
Content Source: articles/bastion/session-monitoring.md
Service: bastion
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

I'm not really sure how the return is getting this article when none of those words are in the article itself. I'm not sure how to fix this and am not seeing the same results. I'm going to close this for now. If you do see it happening regularly, you can comment here and that will trigger another alert for this pr. #please-close


Passed ConsumerFactory to KafkaBinderHealthIndicator

Passed ConsumerFactory into KafkaBinderHealthIndicator to allow full configuration properties to be used when creating a consumer for health checks.
Fixes #79

@barrycommins Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@barrycommins Thank you for signing the Contributor License Agreement!

Thanks a lot for the contribution @barrycommins - we just released 1.2.0.M1/1.1.1.BUILD-SNAPSHOT but looking forward to picking up the fix in the next release - most likely in Feb.

Closed via https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/commit/91bdee65ec7750ab828f3c38be61f508b44cdb6c


Update logging.ts

Thank you for the updates!
To simplify Situations codebase, the mechanism to update translations in run time has been removed but I will create an updated package to github releases as soon as possible and eventually also to Jolla Store.


1.19 support

Prismarine viewer not rendering correctly in 1.19, example: https://cdn.discordapp.com/attachments/947894924496482354/1039960731208138752/image.png

I am having the same issue on a 1.16.5 server

yes I have this error too!

Currently, prismarine-viewer and dependent libraries are not compatible with version 1.19.

set your bots version to 1.18.2 and install viaversion to your server

set your bots version to 1.18.2 and install viaversion to your server

I doubt most people are using bots on their own server xdd

it's not supported, that's why. Please bring support

start with #286

Error: Unknown entity glow_squid

So mc assets has 1.19 now, this needs to be tested and done

done


Added invokemethod() which subs to response topic, restructured folders, and reorganized files

Handle the Future output for invokemethod in Python and Java by registering to completed Future UMessage
Restructured Folders so organization is readable and accurate
Reorganized files to remove unnecessary files and feature files have single responsibility
Added Github action to automatically run .feature files

#6


[office] nuovo/spreadsheet-reader

Nice package for extracting data from a few different types of spreadsheets - https://github.com/nuovo/spreadsheet-reader

There are other libraries that handle this which are already listed, so without a good reason, I'll abstain from merging for now. Regardless, thanks for your contribution.


Allow messages only containing backticks to be created

Fixed Issues
$ https://github.com/Expensify/App/issues/13854
Tests

Create several messages: one with a single backtick, one with two backticks, one with three backticks
Switch to another chat
Switch to the original chat
Verify the backtick messages are still there
Refresh the page
Verify the backtick messages are still there

[ ] Verify that no errors appear in the JS console

Offline tests
Same as the above, but do step 4-6 after coming back online
QA Steps
Same as the above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@tgolen I can't send empty blocks still on slack
https://user-images.githubusercontent.com/85645967/210282860-cd540144-e9a8-44d2-8150-b9345781c044.mov

I think Srikar is going to be OOO now so I can step in and help with the review now.
@Santhosh-Sellavel Thanks for noting that, I think that is more of a feature request at this point though. I think in the PR we should focus on fixing the issue mentioned in the linked GH and then we can potentially improve the markdown logic although that might also fall into some larger project as there is lots of small markdown issues we might have worth refactor in the WAQ spirit.

I think the best path forward, for now, is to allow messages with anything except whitespace, and then if we really want to nail down the case of 3 backticks, we can open a discussion on Slack to discuss that.

I agree with that!
@Santhosh-Sellavel would you be able to follow up with the PR reviewer checklist?

Yeah I'll do it today.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Desktop & Web
https://user-images.githubusercontent.com/85645967/210668170-f229933f-05d8-42ee-8648-e9e4a8d7ca59.mov

Mobile Web - Chrome & Mobile Web - Safari
https://user-images.githubusercontent.com/85645967/210669122-4e727117-2242-4df5-8a1d-20edef97084c.mov

iOS & Android
https://user-images.githubusercontent.com/85645967/210669118-2b8a4623-685c-4de8-ba53-e505409f20b4.mov

LHN Preview is different from the actual message is this expected? @tgolen

The behavior in the LHN is expected. As far as I know, the LHN does not display any formatted text, so it will just show plaintext previews (and it seems to strip some characters). Anyway, I think that's fine, as well as any of those interesting display issues. Thanks for testing!

Cool please assign me this #13854

Done!
On Wed, Jan 4, 2023 at 5:02 PM Santhoshkumar Sellavel <
@.***> wrote:

Cool please assign me this #13854
https://github.com/Expensify/App/issues/13854
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/pull/13941#issuecomment-1371608626, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJMAB4VWDZCBOKOGQ5ALCDWQYMRFANCNFSM6AAAAAATPDROPY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Strange, GH doesn't seem to be linking things properly. The PR is here: https://github.com/Expensify/App/pull/13941

@tgolen Maybe if GH is locked it doesn't allow linking?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @mountiny in version: 1.2.49-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.49-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Provide Content-Type or File Type

It'd be helpful for the Post to also provide this information to be able to differentiate between images and videos without processing/requesting media manually

I am also unable to access _data to handle this myself. @AtoraSuunva this seems like a bug

It's data not _data (whoops my docs are wrong there), though there's no way for me to provide Content-Type since no booru API does that (afaik) and doing a HEAD request for every post to get that header would be wasteful
You can probably rely on file extensions in file urls though, every booru I've seen has been pretty good about using the right extensions and it's roughly what I do in my own project using booru https://github.com/AtoraSuunva/BooruBot/blob/main/src/boorubot/search/searchUtils.ts#L324

It's data not _data (whoops my docs are wrong there)

Ah, I hadn't realized this before, but in order to access @private and @protected properties in typescript you have to use bracket notation (e.g. post["data"]). Maybe this property shouldn't be protected/private if it's essentially just a simple Record<string, any>

You can probably rely on file extensions in file urls though, every booru I've seen has been pretty good about using the right extensions and it's roughly what I do in my own project using booru

Is it possible for booru to provide it's best guess of what the file type would be based on the file url or data received from the APIs? I started to do this on my end, but it feels like important information that this package could provide.
interface Post {
  // ...
  /** the content type as determined by the file url, (e.g. `"image/png"`) */
  contentType: string | null;
}


except option for snapshot check all

Describe the feature
When using the snapshot check strategy with the 'all' option add the ability to exclude specified columns, similar to the the dbt_utils.star() macro.  Add an optional 'except=[]' option to the option set when choosing check_cols='all'.
Describe alternatives you've considered

Option 1:  Implement a macro locally that removes excepted columns from the references relations column list.  The sequence of snapshot processing seems to be different from running a model.  Following the approach of the used in the dbt_utils.star() macro, the column list doesn't appear to be available at the time the check clauses are generated and results in an error due to empty column lists.  This may still be a viable option if there is a way to access the column list of the source relation.
Option 2:  Explicitly list each column in each table, excluding internal processing columns.  This approach carries a risk of defects being introduced due to the large number of fields needing to be entered manually.
Option 3:  Add an additional optional config setting.  In the .../snapshot/strategies.sql code, add a step to exclude columns from the check list based on the optional setting.  Following the approach of the star() macro, name the new field "except".

Additional context
Working example available for a PR if this is a useful addition.
Who will this benefit?
Useful in cases where all business fields in a table should be checked during the snapshot process, except for operational metadata fields, like job execution date.  In our case, we have regular full refresh extracts from a source system with a significant number of generic configuration fields (50 to 100 fields depending on the extract).  We also inject lineage and operations fields into records as part of load, such as load job id and batch id.
I want to snapshot changes based on source system changes, but not daily processing fields.  If the check snapshot strategy is used with the 'all' option, then each daily refresh is identified as an update due to the job processing fields.

hey @datwiz - thanks for opening this issue!
I totally buy what you're describing and agree that an except option would help address this use case. That said, setting check_cols to all is provided for convenience and is not considered a best practice (see here: https://docs.getdbt.com/docs/snapshots#section-check) so I hesitate to add more complications to that particular piece of functionality.
I'm closing this issue out with a wontfix label to indicate that it's not something we'll be able to add support for in dbt. That said, I do totally think this is something you could implement in your own project, no changes to dbt required. You said:

Option 3: Add an additional optional config setting. In the .../snapshot/strategies.sql code, add a step to exclude columns from the check list based on the optional setting. Following the approach of the star() macro, name the new field "except".

You can in fact copy the check strategy macro into your own macro, rename it, and then use your custom strategy in your snapshot definitions. Check out the source code here:
https://github.com/fishtown-analytics/dbt/blob/8cd8705d67627e8f701afb5f5490d553e76f3dfa/core/dbt/include/global_project/macros/materializations/snapshot/strategies.sql#L122-L169
So, you could rename this macro to snapshot_check_except_strategy, then update the macro to accept a config called except. In your snapshot file, you would use the strategy named check_except:
{% snapshot my_snapshot %}

    {{
        config(
          target_schema='snapshots',
          strategy='check_except',
          except=['abc', 'def'],
          unique_key='id',
          check_cols=['status', 'is_cancelled'],
        )
    }}

select ...

I'm closing this one out, but happy to follow up below if you have any questions or thoughts :)

Thanks @drewbanin for the detailed feedback.
Rounding out the close out, after a bit more investigation into source data, I've identified a suitable field to use as an 'updated_at' value and switched to the snapshot timestamp method.  This avoids the need for checking all those sparsely populated generic columns provided by the upstream source..

I have a similar scenario where the except functionality would be ideal. I am dealing with an external data source of over 200 columns. It fails to provide an updated at column (the database was seemingly built in the 90's). The data source has new columns added every so often. I need to dynamically update the check_cols to exclude some of the more trivial columns and false-positive columns (ones that change every day but mean nothing). An except feature would make this seamless.
Your point of it being dangerous is understood, but given how DBT seems to embrace being dynamic-friendly SQL, this allows snapshots to adapt to changing data sources, encouraging more data to be captured even if a new column artificially increases the capture rate. I see this as no riskier than explicitly typed columns in check_cols, given both approaches require a manual intervention to correct.
I tried a workaround attempting to use dbt_utils.get_filtered_columns_in_relation but it fails the pre-execute phase (which seems by design). Attempts to fake it out also dont lead to desired results. Maybe I am missing something?


jQuery is bundled with Browserify even if jQuery object is provided

According documentation you can provide a jQuery object to DataTables require, otherwise it should do its own require. I assume if you provide the object, Browserify shouldn't bundle jQuery but in my tests it does.
{
  "name": "test-datatables",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "browserify": "^13.3.0"
  },
  "dependencies": {
    "datatables.net": "^1.10.13"
  }
}

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <title>Test DataTables and Browserify</title>
</head>
<body>
  <script src="https://code.jquery.com/jquery-3.1.1.min.js"></script>
  <script src="bundle.js"></script>
</body>
</html>

console.log($);
var dt = require( 'datatables.net' )( window, $ );
console.log(dt);

Then when you run
browserify app.js -o bundle.js

the bundle.js includes jQuery. Not sure if this is a bug or I have wrong expectations here. The use case is when jQuery is already included on page for whatever reason, and how to avoid including it twice.

I think what is happening here is that DataTables specifies jQuery as a dependency, so even although you are passing your own jQuery in, browserify is still seeing that dependency and thus including jQuery.
I don't really see a way around that without providing a separate repo that doesn't have that dependency.

Thank you. I've just figured out that this can be avoided by using --external option.
browserify -x jquery app.js -o bundle.js

or for example in Gulp
browserify(props).external('jquery').bundle();

That's useful info - thanks!


Get-ADcomputer or WSUS calls from inside a boxstarter session

Hello,
I'm wondering if anyone knows or has seen problems either doing Get-Adcomputer -prop description or doing a WSUS call like the following:
$wsus = [Microsoft.UpdateServices.Administration.AdminProxy]::getUpdateServer($wsusserver,$False)
When performing a build from a remote call?   The same code runs great when you do a local boxstarter build with the URL/WebApp
I know I can potentially just re-arrange my script and run that code from the initiating machine but I was preferring to have that code successfully logged in the boxstarter log for the server somehow so that it could be reviewed.    Is situations like this a case where you would use Invoke-BoxstarterTask?
Thanks for anyones help/input/suggestions

I'm not 100% certain about Get-Adcomputer but I am certain wsus APIs do not work repotely. Boxstarters Install-WindowsUpdate gets around that by running inside of a scheduled task on remote machines. You could look at using Invoke-FromTask for this.


A few benchmark models

Description of changes:
Related Issues:
Linked Issues:

Issue #

Issues closed by this PR:

Closes #

@wmdi You can directly push these changes to a new eval branch instead of creating a PR to the main branch.

@wmdi You can directly push these changes to a new eval branch instead of creating a PR to the main branch.

Done.


validate macOS Ventura compatibility

Now that macOS Ventura is out of beta, need to validate that this script works as expected from that environment, including reliable update availability reporting and potentially successful update installation. Once that's done, I'll push an updated build removing the Ventura block.

FYI: I was testing this script on Ventura and it doesn't seem to work as intended as on Monterrey

Wondering if there's an ETA for an official release of v6.0?

I've been testing the update in the ventura branch, feel free to try it out and report back!

No issues so far, it works great! For Monterey clients, Ventura is hidden in the list of prompted updates, and it works as expected on Ventura (have tested both Apple Silicon and Intel Macs).
The usual caveats apply but we have trained our users to reboot and manually install updates, should Install or Defer not do so automatically due to the issues around softwareupdated.
Thanks as always for your great work!


Can we support BOTZ for higher versions of openfire?

Currently, it appears that BOTZ is not supported for open fire 4.8.x. Seems like a version compatibility issue with openfire modules and the xmpp server, method signatures etc. Possible to support this?

I'm surprised at the timing of this request. Although it is definitely desired to have compatibility, there has not yet been an Openfire 4.8 release to date.

Trying against openfire 4.7.4 - i am seeing the following:
java.lang.NullPointerException: Cannot invoke "org.jivesoftware.openfire.session.LocalClientSession.setAuthToken(org.jivesoftware.openfire.auth.AuthToken, String)" because "this.localClientSession" is null
	at org.igniterealtime.openfire.botz.BotzConnection.login(BotzConnection.java:375)
	at org.igniterealtime.openfire.botz.BotzConnection.login(BotzConnection.java:284)

It appears from reviewing the code that setAuthToken is supposed to create the client route and  the session. But seems to be failing right at localClientSession = (LocalClientSession)SessionManager.getInstance().getSession(jid);
Any pointers on what i maybe missing?

I think you've uncovered one (of possibly many) bugs in the Botz framework. We've recreated this repository from sources that were very, very old, with next to no testing. Turns out that the Openfire API changed more than we anticipated.
I've provided a provisional fix for this issue in https://github.com/igniterealtime/Botz/pull/5 - care to give that a try?

The fix was tested and works fine.  Able to create a session now and get the chatbot presence and exchange messages. Is there any good way with openfire to show this chatbot automatically under the users contact lists?

Thanks for testing this @krisiye!
What you could do to add a chatbot to everyone's contact list is create a group in Openfire's admin console, and make the bot a member of that group. Then, you can Enable contact list group sharing, to make the group appear on the contact list of every user in the system.

@guusdk  -  it looks like the artifact may have some errors in the pipeline. Possible to get a 1.2 release with the updates? thanks!

@krisiye I fixed up CI in #6 , so our maven repo should have an updated snapshot now.

Thanks! When can we expect a release version?

Given that #4 is pretty much preventing usage, I'm not seeing a reason to delay a new release. I've drafted one in https://github.com/igniterealtime/Botz/pull/7

A release has been published: https://discourse.igniterealtime.org/t/botz-version-1-2-0-release/


base16_spacemacs: add colors for error/warning counts and disable special color and bold for modified state

Purple color is hard to read on dark background and not really needed, since [+] is noticeable enough. No other base16_* theme uses bold attribute for modified state.

please squash

Squashed.

thanks


i2c_shell: drivers: handle missing I2C device argument

Handles the case in which the I2C device is not informed to the I2C shell command interface.
In certain cases, the command fails badly when the I2C device is not informed.
For example, when using an ESP32-based board, calling i2c scan instead of i2c scan I2C_0 from the I2C shell will raise an exception. After that, the shell will not be available again to the user until rebooting the MCU.

@glaubermaroto any plans to update this?

@glaubermaroto any plans to update this?

@galak I've spotted some more points worth to be handled here, so I'm closing this PR for now to assess it and make it part of one single scope.


Resync when new content is received

https://github.com/Fleker/CumulusTV/issues/2#issuecomment-127644831
This mostly just applies to when the app is started, I think, that the app doesn't automatically force a resync which in turn alters the channel line-up.
This requires more investigation.

Now my live channels syncing is much more aggressive.


EmbedMultipleConfs without explicit H : no output and no error message

Hello Rdkit team and thank you for your time,
Bug description :
I'm trying to generate conformers. It fails for some molecules if I don't add the explicit hydrogens.
In these cases, the program doesn't produce any error message.
Example :
from rdkit import Chem
from rdkit.Chem import AllChem
sdf_file_in = "Ajugasterone-C.sdf"
#sdf_file_in = "20-hydroxyecdysone.sdf"
sdf_file_out = "test_out.sdf"
supplier = Chem.SDMolSupplier(sdf_file_in)
f = open(sdf_file_out, "w")
for molecule in supplier :
numberConf=50
param = AllChem.ETKDGv3()
param.useSmallRingTorsions = True
param.randomSeed = 123
param.pruneRmsThresh = 1.25
param.onlyHeavyAtomsForRMS = True
param.numThreads = 0 #use all threads of the computer
#molecule = Chem.AddHs(molecule)

block = Chem.MolToMolBlock(molecule)
name=block[:block.find('\n')]

ids = AllChem.EmbedMultipleConfs(molecule,numConfs=int(numberConf),params=param)

for conf_num in ids:
	block = Chem.MolToMolBlock(molecule, True, conf_num)
	block_without_id = block[block.find('\n'):]
	true_conf_num = conf_num + 1
	id_line=name + "_" + str(true_conf_num)

	f.write(id_line)
	f.write(block_without_id)
	f.write("$$$$\n")

f.close()
20-hydroxyecdysone.sdf.gz
Ajugasterone-C.sdf.gz
If you try, you'll see it works fine for 20-hydroxyecdysone.sdf, but doesn't produce anything for Ajugasterone-C.sdf. (No output, no error message, it merely suggest to add the explicit H, but the program always do that when I don't add them)
If you uncomment "molecule = Chem.AddHs(molecule)", you'll see it works for both.
Expected behavior :
-I expect the program to generate conformers, even without explicit Hydrogens.
-If the program fails, I expect an error message.
Why I don't wan't to add the hydrogens :
-It adds noticeable generation time.
-It messes with the RMS, even though it shouldn't (param.onlyHeavyAtomsForRMS = True), which leads to a different number of conformers generated... but that's a bug for another day.
Configuration :

RDKit version: 2022.03.5
OS: Ubuntu 22.04.1 LTS
Python version :  Python 3.10.6 | packaged by conda-forge | (main, Aug 22 2022, 20:36:39) [GCC 10.4.0] on linux
I'm using conda
How did I installed rdkit : conda install -c conda-forge rdkit

Thank you for investigating the problem,
Florent.

This isn't a bug. Problems should be expected when trying to generate conformers for molecules which don't have hydrogens added (that's why you get the warning message). The presence of the H atoms makes it easier for the code to generate physically reasonable conformers.
The conformer generation code, by design, does not generate error messages when it fails. You can detect failures by looking at the return value: EmbedMultipleConfs() should return an empty list if it cannot generate any conformers and EmbedMolecule() returns a conformer id of -1.


inode: directory and file size limitation

Because inode keeps some list (directory keeps filenames list, regular files keeps blocks list), the inode size can increase to reach some limits.
Default version of 0-db used a fixed hardcoded payload limit of 8 MB, which mean a redis command cannot be larger than 8 MB. Trying to write an inode which is larger than that would fails, and inode would not be saved.
Blocks id are stored in a 32 bits field (0-db sequential key is 32 bits). Amount of blocks are limited to 4 billions, which put a hard filesize limit of 1 PB. This is acceptable.
With 8 MB maximum payload, inode regular file limit would be around 512 GB.

In a first step, a software maximum file size limitation will be implemented to limit unexpected issue.

Directory will be updated to follow a first indirection, which will point to lists separated from the original inodes, which will reduce the root object size and will spread size over multiple list (like ~128).
This should allow directories with millions of entries without exploding inode size.

0-db keys are now using 64 bits and not 32 bits anymore.


fix: disallow broken unique count meteraggregation for features

Overview
Disallowa UNQUE_COUNT for features until it's properly implemented.

Fixes #(issue)
Notes for reviewer

We already have this logic in place here: https://github.com/openmeterio/openmeter/blob/5c19d270be649601d593a5c81e39720fc0ad003f/internal/productcatalog/feature_connector.go#L71-L75


Token auth

Do we have an option to retrieve the Facebook token, in order to proceed with verification on a backend server?

You can use CrossFacebookClient.Current.ActiveToken property for that purpose.


DROOLS-1279: [GSS] Compilation of spreadsheet fails with specific condition

See https://issues.jboss.org/browse/DROOLS-1279
LhsBuilder is re-used when a spreadsheet contain merged columns. It contains state for a specific constraint's FieldType which was being overwritten by second and subsequent merged columns. We need to store the FieldType per column to avoid it being overwritten.

@mariofusco Hi Mario, you're probably the only other person who knows much about this (when I say "knows" I mean has had any reason to look at any of this code in recent years!). Would you mind reviewing please.

@manstis The fix is ok for me. Just note that in case you'll backport this fix to 6.x you will have to avoid the diamond operator that you used in the LhsBuilder constructor.


Replace dicts with maps

but leave it alone where Dialyzer itself returns a dict.
ℹ  I created this draft PR for you, @maco … so we can talk about it inline.

@maco Since I opened this PR… I can only comment on it (i.e. I can't approve)… but, other than the specificity in the record files (that we can leave for later), I think it's mergeable.

@elbrujohalcon I would oppose to merging the PR until we get to benchmark the (possible? expected?) improvements of replacing dicts with maps. Better to end up fine-tuning, if needed, this PR than having to clutter up the PR section with hits of changes for this.
Besides, getting some numbers would be something fancy for a blog post :P


Downloading psql Schema error 404

404：Not Found

@ZihaoTan - could you share where this link is?

wget https://raw.githubusercontent.com/paschmann/rasa-ui/master/resources/dbcreate.sql

Hello @ZihaoTan - I have updated the wiki page to show that this is no longer needed with V3 of Rasa UI. Thanks!

Hi @paschmann ,
Its still not reflecting that in the wiki for me?

(also if I may hijack this for a qucik question - I dont see a docker-compose, was this removed on purpose?  I found some links/issue mentioning it but I get a 404 )

Hi @roynasser - you are correct, I just updated the TOC's for the wiki which it now shows the install reference as deprecated.
Re: Docker Compose - yes, I removed this to simplify the repo, I will review the requirement again.

Got it! thanks!  I can contribute a "minimalist" docker-compose for "quickstart" if you'd like...

Sure - please create a new issue and pull request! Thanks!

@roynasser This would be great 👍

I had some trouble with Rasa-ui (cant seem to "pull" or import my rasa bot into rasa-ui) so I stopped looking into it for now (want to come back to it as soon as I have some time)...
This is what I put together for basic testing... I'll fork and submit a PR soon, but if anyone wants it:
Below is the docker-compose.yml
`
version: '3.0'
services:
rasa:
image: rasa/rasa:latest-full
networks: ['rasa-network']
ports:
- "5005:5005"
volumes:
- "rasadata:/app"
command:
- run
- --enable-api
action_server:
image: rasa/rasa-sdk:latest
networks: ['rasa-network']
ports:
- "5055:5055"
volumes:
- "./rasa-app-data/actions:/app/actions"
duckling:
image: rasa/duckling:latest
networks: ['rasa-network']
ports:
- "8000:8000"
rasa_ui:
build:
context: rasa-ui
networks: ['rasa-network']
ports:
- "5001:5001"
depends_on:
- "rasa"
environment:
rasa_endpoint: "http://rasa:5005"
networks:
rasa-network:
volumes:
rasadata:
driver: local
driver_opts:
type: none
device: $PWD/rasa-app-data
o: bind
`
Run below to get it up...
Getting started:
docker run -ti -v $(pwd)/rasa-app-data:/app rasa/rasa:latest-full init --no-prompt
This will get "sample" data into rasa so it comes up without issue.
docker-compose up
To get the stack up

Added docker-compose file @roynasser - I modified it slightly to keep it simple. Thanks for your help!


Fix neglect-to-remove bug in sinsp automatic threadtable purging logic

Various sinsp logic sets m_tid_to_remove, to record the fact that a thread has been identified as ready-to-be-removed from the threadtable.  And if automatic threadtable purging is configured, sinsp::next() takes care of removing these threads by calling remove_thread(), then clearing m_tid_to_remove.
But remove_thread() may itself set m_tid_to_remove in certain situations. The current sinsp::next() logic loses track of this request; as a result, these threads will languish in the threadtable until the next remove_inactive_threads() interval, default value 20 minutes.
This fix changes the sinsp::next() logic to recognize and handle the case where remove_thread() records a thread for removal.
Signed-off-by: Joseph Pittman<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Fix sinsp automatic threadtable purging logic, which loses track of a thread to remove, in the case where removal of one thread results in the detection of another thread which also needs removal.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

fix: timely removal of terminated threads

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jcpittman144
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval by writing /assign @fededp in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jcpittman144
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: a77a85b02df25bbbda9b9500a9a6e24e689a870a

/milestone 0.10.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, jcpittman144
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Patch 1

Updates to documentation in line with changes to 8x8 services.

@jeevansd
Can you review the proposed changes? Note that the validation warning must be resolved before merging.
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I have added one more commit which should fix the validation warning, not sure how to re-run the checks


Adding images with an alias might add to a folder with the name of the alias, instead of the resolved name

Noticed it with a few, like mb.jegan

Fixed


Connection error use azure embedding

code
`connection = "postgresql+psycopg://YYY:XXXX@localhost/ZZZ"
collection_name = "my_docs"
from langchain_postgres import PGVector
from langchain_postgres.vectorstores import PGVector
vectorstore = PGVector(
embeddings=embeddings,
collection_name=collection_name,
connection=connection,
use_jsonb=True,
)
db = vectorstore.from_texts(    ["communication"], embeddings)`
error info
db = vectorstore.from_texts(    ["communication"], embeddings)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/anaconda3/lib/python3.11/site-packages/langchain_postgres/vectorstores.py", line 975, in from_texts
return cls.__from(
^^^^^^^^^^^
File "/usr/local/anaconda3/lib/python3.11/site-packages/langchain_postgres/vectorstores.py", line 438, in __from
store = cls(
^^^^
File "/usr/local/anaconda3/lib/python3.11/site-packages/langchain_postgres/vectorstores.py", line 295, in init
raise ValueError(
ValueError: connection should be a connection string or an instance of sqlalchemy.engine.Engine
Exception ignored in: <function PGVector.del at 0x7fdf7b19dda0>
Traceback (most recent call last):
File "/usr/local/anaconda3/lib/python3.11/site-packages/langchain_postgres/vectorstores.py", line 326, in del
if isinstance(self._engine, sqlalchemy.engine.Connection):
^^^^^^^^^^^^
AttributeError: 'PGVector' object has no attribute '_engine'

I think it is because it is not detecting correctly the 'connection_string' parameter, try checking and varying it, mostly adding/removing the "+psycopg" part, for me it kinda worked. Got some other error after, but at least not that one any more!

This looks like some tear down race condition. It's triggered on del . You can probably explicitly invoke del on the vectorstore as a work-around for now


Vuejs Examples

Includes THREE vue project each with different use cases of vuejs and setup.

inline-example using inline vuejs cdn link.

vue-cli-example using vue cli command line to create and setup project.

nuxt-js-example using nuxt js framework and command line tool to setup project.

Each of the projects has there own README file on how to run and test projects. Please replace account_token with yours.

Thanks for review @hachibu I have updated the instructions for all project.
Ray Nuxt.js helps to easily create/manage vue js applications with feature like SSR (server side rendering) etc. Vue js customer also tends to use Nuxt.js for projects and here we have bit different way to add wootric sdk. So please if we can not delete this 🤔
And I am using nuxt-js-example folder 😕


Enforce location permission access in policy

[x] requires updated tipoff/locations with HasLocationPermissions trait before merge

Updates policies to include checking users ability to access model's location.

It looks like we need to update the tests so that the Staff role is testing if the Staff user has the Location access.


Make the Event Details page look good on Mobile

Replace existing styling with Flowbite/Tailwind and focus on mobile responsiveness.

This is the file: src/pages/events/[eventId]/index.js

@qad114 The idea for this ticket is to update the file in question with components from https://www.flowbite-react.com/ or tailwind styling. We should completely get rid of the const Styled = { at the top and clean the UI up a lot.
As you are doing this, also make sure it is mobile responsive. On desktop we display the event details in 2 columns, mobile should just be one with everything responsive.


Feature/readme workflow status

Codecov Report

Merging #3 (e78e485) into master (3494b6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   98.93%   98.93%
=======================================
  Files           8        8
  Lines         657      657
  Branches       56       56
=======================================
  Hits          650      650
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3494b6d...bb61d62. Read the comment docs.


clang doesn't really support -static on darwin

On macOS 10.14.1:
$ make
awk -f lib-to-string.awk ldpl_lib.cpp > ldpl_included_lib.cpp
c++ -g -c -Wall -std=gnu++11 -fpermissive -DVERSION='"2.0.7"'   -DSTANDARD=19         -DCOMPILEDATE='"Tue Mar 12 22:23:30 PDT 2019"' ldpl.cpp
c++ -g ldpl.o -o ldpl -static-libgcc -static-libstdc++
clang: error: unsupported option '-static-libgcc'
make: *** [all] Error 1

clang has a -static option, but using it fails with ld: library not found for -lcrt0.o.
From developer.apple.com.

Apple does not support statically linked binaries on Mac OS X. A statically linked binary assumes binary compatibility at the kernel system call interface, and we do not make any guarantees on that front. Rather, we strive to ensure binary compatibility in each dynamically linked system library and framework.

I removed the -static flags and built a binary that works on both my laptop and another mac. Not sure if there's a better flag or way to do it.

Hmm this is a problem. I don't have an intel era mac (I do have an old PPC one, that's why the PPC architecture is supported) so I did not try this with clang but with gcc. The thing is this: if you remove those flags, you will not be able to compile for Windows. If you keep them, you won't be able to compile for mac. I'd rather just add a comment saying something in the lines of "if you are using clang under macOS, remove this line" instead of removing it altogether.
What do you think?

I added a check for Darwin in the Makefile, can you see if it works for you? I tested it on Arch Linux and it built using the flags.

Sorry, I don't see the change. Did you push it? (you can paste it here if you want and I can paste it in my makefile)

It's in the original commit on this PR, if it's not showing up for you I can push a new branch: c7ce1d9225915dc5da87811bf560eb6c393cad9c
Here's the raw diff if you want to test it by hand:
--- a/src/makefile
+++ b/src/makefile
@@ -15,7 +15,9 @@ OBJS = ldpl.o
 SOURCE = ldpl.cpp
 OUT = ldpl
 FLAGS = -g -c -Wall -std=gnu++11 -fpermissive -DVERSION=$(VERSION) -DSTANDARD=$(LDPLSTD) -DCOMPILEDATE='"$(shell date)"'
-LFLAGS = -static-libgcc -static-libstdc++
+ifneq ($(shell uname -s),Darwin)
+	LFLAGS = -static-libgcc -static-libstdc++
+endif

 all: $(OBJS)
 	$(CXX) -g $(OBJS) -o $(OUT) $(LFLAGS)

Yes, sorry, it was like that all along! I didn't see it, sorry. I'll try it right away.

Great! Thank you very much for your contributions!


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 13:00:34 on 2023.04.19
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 0, errors out: 0
Original problem ID: 19765
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=19765

Problem has been resolved in 2m 55s at 13:03:29 on 2023.04.19
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 19765


Everyone, I have completed the reproduction of the colab project

Thank you all!

Helllo! I want to learn the use of this model. Could you share a copy of your colab-reproduced notebook for me to learn, thank you very much for your help.

Helllo! I want to learn the use of this model. Could you share a copy of your colab-reproduced notebook for me to learn, thank you very much for your help. @EdenShadow


⚠ GitLab Server has degraded performance

In 135cba8, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11161 ms

Resolved: GitLab Server performance has improved in 8c25c07.


Simplify release versioning

Changes the release handling to add a make bump target, so nobody needs to manually edit the files to update version numbers. Usage:
make VERSION=5.13.0 bump

It could be fancy and read the version number from the top entry of the changelog, what do you think, @fractalwrench?

I think this makes sense as is - lgtm!


Add stock market tooltip info

Add extra information to each stock's tooltip such as mode and next expected value

Thanks for the contribution!


DateTime elements have seconds precision, replaced by Timestamp

Timestamp elements have milliseconds precision in SQLite, and microsecond precision in SAP HANA and PostgreSQL.
DateTime elements have seconds precision, that was the cause we need to wait a second.
Purpose of PR?:
Fixes #2245
Does this PR introduce a breaking change?
Change to precission of Timestamps
https://cap.cloud.sap/docs/guides/databases-sqlite

https://cap.cloud.sap/docs/guides/databases-sqlite

I don't see how this link (and the conclusions you took from it) are relevant. They describe datatypes in some js library that is unrelated to SQLAlchemy. SQLite does not have a TIMESTAMP type (and neither does it have a DATETIME type, datetimes are canonically stored as either ISO8601 text, a REAL or an INTEGER, more about that here: https://www.sqlite.org/datatype3.html). The DateTime type from SQLAlchemy does the right thing(TM) for SQLite, which is to store them as ISO8601 text, including microseconds (see: https://docs.sqlalchemy.org/en/20/dialects/sqlite.html#sqlalchemy.dialects.sqlite.DATETIME).
BUT: while the DateTime type from SQLAlchemy has microsecond precision for SQLite, I don't think this is always the case for other databases. At least in its docs (https://docs.sqlalchemy.org/en/20/core/type_basics.html#sqlalchemy.types.DateTime) they recommend using dialect specific types if sub-second precision is needed. This would mean that we would have to pick an appropriate datatype for each and every database that we want to support (or maybe just do the ISO8601 text representation everywhere manually). I am not sure yet on if this is worth the effort, or if second precision is fine and sub-second precision is too much effort for too little gain.

SQLite supports several date and time types, including DATE, TIME, DATETIME, and TIMESTAMP. These types represent a combination of date and time or just the date or time separat
And as described DATETIME has in sqlite a precission of 1 Second.
The fix is correct

SQLite supports several date and time types, including DATE, TIME, DATETIME, and TIMESTAMP.

No, it is this:

SQLite does not have a storage class set aside for storing dates and/or times. Instead, the built-in Date And Time Functions of SQLite are capable of storing dates and times as TEXT, REAL, or INTEGER values:
TEXT as ISO8601 strings ("YYYY-MM-DD HH:MM:SS.SSS").
REAL as Julian day numbers, the number of days since noon in Greenwich on November 24, 4714 B.C. according to the proleptic Gregorian calendar.
INTEGER as Unix Time, the number of seconds since 1970-01-01 00:00:00 UTC.

Applications can choose to store dates and times in any of these formats and freely convert between formats using the built-in date and time functions.

(from https://www.sqlite.org/datatype3.html)
SQLAlchemy then introduces a DATETIME type in its SQLite dialect that uses the above described TEXT representation for datetimes. This representation, which is used by SQLAlchemy's DateTime Column type, does include microseconds. You can check that yourself:
import sqlalchemy
import sqlalchemy.orm
import datetime
from sqlalchemy import Column, Integer, DateTime, TIMESTAMP

engine = sqlalchemy.create_engine("sqlite:///demo.db")
Session = sqlalchemy.orm.sessionmaker(bind=engine)
session = Session()
Base = sqlalchemy.orm.declarative_base()

class Record(Base):
    __tablename__ = "records"

    id = Column(Integer, primary_key=True)
    dt = Column(DateTime)
    ts = Column(TIMESTAMP)

Base.metadata.create_all(engine)
now = datetime.datetime.now()
record = Record(dt=now, ts=now)
print(f"{record.id=}, {record.dt=}, {record.ts=}")
session.add(record)
session.commit()

del record

record = session.get(Record, 1)
print(f"{record.id=}, {record.dt=}, {record.ts=}")

Output:
$ python sqlalchemy_datetime_demo.py
record.id=None, record.dt=datetime.datetime(2024, 3, 28, 12, 8, 42, 914199), record.ts=datetime.datetime(2024, 3, 28, 12, 8, 42, 914199)
record.id=1, record.dt=datetime.datetime(2024, 3, 28, 12, 8, 42, 914199), record.ts=datetime.datetime(2024, 3, 28, 12, 8, 42, 914199)

As you can see, DateTime handles microseconds perfectly fine. And due to SQLite's very lax typing TIMESTAMP does more or less the same.
This is what it looks like in the database:
sqlite> select * from records;
1|2024-03-28 12:08:42.914199|2024-03-28 12:08:42.914199

sqlite> select typeof(dt), typeof(ts) from records;
text|text

The data representation is the same and both columns have a type affinity of "text".
The only thing that differs is the actual supplied type name in the schema, but SQLite ignores that apart from determining the type affinity:
sqlite> .schema
CREATE TABLE records (
	id INTEGER NOT NULL,
	dt DATETIME,
	ts TIMESTAMP,
	PRIMARY KEY (id)
);

So for SQLite there is no practical difference between the two.
The thing that I don't know is whether DateTime has sub-second precision on other databases. But then again, I haven't found a definitive source that this is the case for TIMESTAMP either. TIMESTAMP has the disadvantage that it is an "uppercase" datatype (https://docs.sqlalchemy.org/en/20/core/type_basics.html#the-uppercase-datatypes), which is rendered exactly as such in the schema. At least it seems to exist for all database backends, but if it didn't then it would produce an error, for example.

The important part for us is what  it does with ordered_by by the time information. That was only in seconds and not with fractions. Looks like we can keep DateTime. And the other changes seem to fix it.

We are using postgres in production, right? I think we should check how the DateTime type behaves there as well (and in the future extend the CI suite to test against different databases as well).

same idea, https://github.com/Open-MSS/MSS/issues/2311
also now better understanding why the billiger de people mentioned that in their session

I reaaally dislike the fragility of this functionality.
We should use a parsing function which generously accepts well formed strings. Going to a standard such as iso8601 would be preferable.
I never understood the prevalence of strptime.
This seems to solve an immediate issue, so we can defer a robust fix to later.

I do also like a step by step improvement too This is currently a bug fix. The change to iso format is likly an enhancement of the whole.
Let's make that in a new PR.


[Fate] Developer mode & compendium support

Changes / Comments
Made changes/additions to the sheet to support JSON object export of sheet data and import of same, with an eye on supporting compendium features down the line. Should not cause a change to any existing character data.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


[README] Rephrase fix from issue #2553

From the feedback given I've tried correcting the rephrasing. I hope it is correct this time? From the original sentence, it said raylib uses some libraries for managing window/graphics/inputs,  so I had understood that as more than one library was used. Other than the incorrect phrasing, I do believe that my other changes improves the clarity and readability of that sentence.

@minnieqi Thanks for the review but I'm afraid I still prefer the current phrasing. Some parts sound more confusing to me than before:

...avaible in the src/external directory to support loading different file formats.

It sounds weird to me, like referencing the functionality of the libraries to its placement in the directory.
If you think this sentence is not clear enough for most users, I can try to review it, despite nobody has ever complained about it. What is the point of this review? Do you think the sentence sounds confusing? Did you ask several users about it?
I'm closing this change for now. Thanks again for the review.


GPII-1325:  The JSON Schema middleware should itself provide valid output and a link to its schema.

See GPII-1325 for details.

Closing out in favor of:  https://github.com/GPII/gpii-json-schema/pull/5


How to start my task in admin

How to start a scheduled task with the highest permission?
How do I make a scheduled task run without AC power?

// Create definition
TaskDefinition td = TaskService.Instance.NewTask();

// Set the run level to the highest privilege
td.Principal.RunLevel = TaskRunLevel.Highest;

// These settings will ensure it runs even if on battery power
td.Settings.DisallowStartIfOnBatteries = false;
td.Settings.StopIfGoingOnBatteries = false;

It works.
Thank you very much!
@.***
From: David Hall
Date: 2021-11-29 11:13
To: dahall/TaskScheduler
CC: dickxuwen; Author
Subject: Re: [dahall/TaskScheduler] How to start my task in admin (Issue #923)
// Create definition
TaskDefinition td = TaskService.Instance.NewTask();
// Set the run level to the highest privilege
td.Principal.RunLevel = TaskRunLevel.Highest;
// These settings will ensure it runs even if on battery power
td.Settings.DisallowStartIfOnBatteries = false;
td.Settings.StopIfGoingOnBatteries = false;
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Deferred Return types

The type on execute of esri/tasks/QueryTask is of type any. It should be of promise so that you are not forced to use callbacks (personal pref but I much prefer promises). There are many examples where this is the case other than query
I understand that you may not want to create a dependency on the dojo typings, but could an esriDeferred or similar not be included? I believe this is what has been done with esri.color
execute(parameters: Query, callback?: Function, errback?: Function): dojo.promise.Promise
interface Deferred {
    /**
     * The public promise object that clients can add callbacks to.
     */
    promise: promise.Promise<T>;

    /**
     * Checks whether the deferred has been resolved.
     */
    isResolved(): boolean;

    /**
     * Checks whether the deferred has been rejected.
     */
    isRejected(): boolean;

    /**
     * Checks whether the deferred has been resolved or rejected.
     */
    isFulfilled(): boolean;

    /**
     * Checks whether the deferred has been canceled.
     */
    isCanceled(): boolean;

    /**
     * Emit a progress update on the deferred.
     */
    progress(update: any, strict?: boolean): promise.Promise<T>;

    /**
     * Resolve the deferred.
     */
    resolve(value?: T, strict?: boolean): promise.Promise<T>;

    /**
     * Reject the deferred.
     */
    reject(error?: any, strict?: boolean): promise.Promise<T>;

    /**
     * Add new callbacks to the deferred.
     */
    then<U>(callback?: promise.PromiseCallback<T, U>, errback?: promise.PromiseErrback<U>, progback?: promise.PromiseProgback): promise.Promise<U>;

    /**
     * Inform the deferred it may cancel its asynchronous operation.
     */
    cancel(reason?: any, strict?: boolean): any;

    /**
     * Returns `[object Deferred]`.
     */
    toString(): string;
}

It should be of promise so that you are not forced to use callbacks (personal pref but I much prefer promises).

Have you tried to cast to Deferred?

Yes you can cast to type deferred (code below). But I feel that as the API documentation states that these are of type deferred explicitly then it should follow the API documentation
<Deferred<any>>queryTask.execute(query).then((res) => {
           console.log(res);
 });

Fix in 4.x.


fix(#648): Always include .dockerignore and Dockerfile files in tarball if they exist

Fixes #648
I took the liberty to refactor the filesystem access out of the DockerIgnoreFile class into a FileSystem class. This way the DockerIgnoreFile class is testable without having to bother with creating temp files. This way I was able to test the dockerignore specific logic without having to change the IgnoreFile class or its tests. Let me know what you think!

@HofmeisterAn Not sure what causes this, but have a look at the failing test.
If I have the following .dockerignore
**/bin/
**/.dockerignore
**/Dockerfile

It will accept a Dockerfile the in the root but it will deny any Dockerfile in a directory.

I will close this in favor of #708. I've added you as a co-author. Thanks for your contribution.


Request for cloud_run_v2_service & cloud_run_v2_job resource

What resource do you need?
Terraform Resource Name:

cloud_run_v2_service
cloud_run_v2_job

What is your use case?
Deploy cloud-run services and jobs.

Dependent on https://github.com/upbound/provider-gcp/pull/63


[background-img]

Would be good to be able to use background-imgs on the full row. If I add it manually, it is still not 100% as it is limited by the padding on the container-fluid element.

Coming in Beta 1. 💯

Done in the latest update.


Invalid XML security version

Description
Since the introduction of #621 and release 4.5.0 in #613, tools that track security/dependency updates like pyup are flagging the following:
An XML external entity (XXE) injection in PyWPS before 4.5.0 allows an attacker to view files on the application server filesystem by assigning a path to the entity. OWSLib 0.24.1 may also be affected. See CVE-2021-39371.

from:
https://pyup.io/repos/github/crim-ca/weaver/commits/?page=1#a586cb79de278fdc33d6eeee5feb6f6233f60a16
Because XML security specific to that issue was handled in #618, which is tagged after in 4.4.5, the requirement should be injection in PyWPS before 4.4.5, an mark the minimum requirement as 4.4.5 rather than 4.5.0.
I would like to have a revision of the security advisory for the lower version for 2 reasons:

Version 4.5.0 introduces some important changes relative to ogc-api, which are not trivial to guarantee backward compatibility with existing services that did not expect them to be there.
According to whichever decision taken from #590, the 4.5.x branch should be either a development branch until 4.6.x or addition of ogc-api should introduce 5.x releases. Either way, 4.5.0 is not a "ready" release (as shown by tests still failing), and suggesting users to fix the XML security should not be done at the same time as new features integration.

Currently, I am receiving a lot of warnings regarding this security issue, and I cannot directly/safely update to 4.5.0 yet until it is properly validated.

Should be an easy fix by @cehbrecht / @tomkralidis

@fmigneault I have contacted the author of this CVE. The author will update the CVE with minimum version 4.4.5.

@cehbrecht
It looks like a change was pushed, but still incorrect (up to 4.5.5 instead of 4.4.5):
https://nvd.nist.gov/vuln/detail/CVE-2021-39371#VulnChangeHistorySection

Changed
CPE Configuration
OR      cpe:2.3:a:github:owslib:0.24.1::::::: cpe:2.3:a:osgeo:pywps::::::::* versions up to (excluding) 4.5.0
OR      cpe:2.3:a:github:owslib:0.24.1::::::: cpe:2.3:a:osgeo:pywps::::::::* versions up to (excluding) 4.5.5

@fmigneault ... it looks like the CVE is already corrected with version 4.4.5.
The CVE wasn't opened by me. Do you want to add weaver to the same CVE? Or open a new one?
I have no experience with this. Personally I would say it is a bug in lxml that we all run into ...

I see the update to 4.4.5.
This is weird, security automation bots don't seem to pick it up and remain stuck on 4.5.0 for some reason.
Weaver can be added to the same CVE since it heavily depends on pywps and OWSLib. I think lxml will not consider it an issue since they provide an option to fix it.

Weaver can be added to the same CVE since it heavily depends on pywps and OWSLib. I think lxml will not consider it an issue since they provide an option to fix it.

I have contacted the author of the CVE to add weaver.


Removing hack for node 6.9.2 migration

Thanks to our system engineers, we don't need those suffixed shrinkwraps anymore. So, when we need to update our dependencies, we just have to run the previous command:
npm run-script update-internal-deps
That's all!
@CartoDB/frontend @jvillarf @azamorano

Thanks!

Added the .nvmrc file in order to load this version automatically cc @nobuti .

Merging and removing the "hack".

Waiting until @jvillarf and @azamorano gives the 💚  light.

:green_heart: from us!

yay!

Removing hack @CartoDB/frontend!


Difference in how connections are handled for draining listeners from v1.19.1 to v1.20.x,v1.21.x

Title: Difference in how connections are handled for draining listeners from v1.19.1 to v1.20.x,v1.21.x
Description:
I am observing a behavior difference in how HTTP connections are handled while the listener is draining in v1.20+ compared to v1.19.1.
Scenario: Egress listener is removed and is in draining state
In v1.19.1: curl http://foo.bar returns curl: (7) ... connection refused
In v1.21.1: curl http://foo.bar hangs, and returns only after listener drain interval.
See https://github.com/envoyproxy/envoy/issues/20113#issuecomment-1051087984 for more details.
What has changed between these 2 versions to result in a change in behavior for connections during listener drain?
UPDATE:
I can confirm that this issue seems to be introduced by the change https://github.com/envoyproxy/envoy/commit/ba474ac375418d5529a30a9510a8ff5f0a5ada9a
I cannot reproduce this issue with the previous commit https://github.com/envoyproxy/envoy/commit/e0380add8104a83c0ca893d34a46df43b0e02eb2

@snowp @alyssawilk

Could share config or steps to reproduce it?

@daixiang0 please refer to the following:
On v1.19.1:

Remove outbound-listener on client (egress listener)
From the client, curl the destination host service-ee146f3f-5f32-4625-8ed0-9c1fb1b55c13.server:

# curl http://service-ee146f3f-5f32-4625-8ed0-9c1fb1b55c13.server/
curl: (7) Failed to connect to service-ee146f3f-5f32-4625-8ed0-9c1fb1b55c13.server port 80: Connection refused

The outbound-listener is in draining state when the above request is made:
    {
     "name": "outbound-listener",
     "draining_state": {
      "version_info": "1",
      "listener": {
       "@type": "type.googleapis.com/envoy.config.listener.v3.Listener",
       "name": "outbound-listener",

listener_manager.total_filter_chains_draining: 4
listener_manager.total_listeners_draining: 1

Config:
envoy_v1.19.1_dump.txt
Stats:
envoy_v1.19.1_stats.txt
On v1.21.1

Remove outbound-listener on client (egress listener)
From the client, curl the destination host service-5c209bc6-6fbb-448a-a341-c079c4060c96.server, it hangs:

# curl http://service-5c209bc6-6fbb-448a-a341-c079c4060c96.server/
^C

The outbound-listener is in draining state when the above request is made:
    {
     "name": "outbound-listener",
     "draining_state": {
      "version_info": "1",
      "listener": {
       "@type": "type.googleapis.com/envoy.config.listener.v3.Listener",
       "name": "outbound-listener",

listener_manager.total_filter_chains_draining: 4
listener_manager.total_listeners_draining: 1

Config:
envoy_v1.21.1_dump.txt
Stats:
envoy_v1.21.1_stats.txt

Since the listener is updated filter chain by filter chain, it's probably hitting the issue I found and analyzed here

This PR address the minor issue of the below sequence

add listener <IP_ADDRESS>:80. Open fd = {X}
complete an in place update listener, and the old listener is draining filter chain. This draining state last drain_timeout. The new listener create listen fd=Y. Now open fd = {X,Y}.
immediately stop the listener. Open fd = {X}, Closed fd = {Y}.
after the drain_timeout, Closed fd = {X,Y}
The expectation is that
after 3 but before 4, tcp client connect to :80 should see reset()

Actual
tcp client connect to :80 is successful because the old listener fd = X is open. It's a minor issue because envoy doesn't serve the tcp client.

Since the listener is updated filter chain by filter chain, it's probably hitting the issue I found and analyzed here
This PR address the minor issue of the below sequence

1. add listener <IP_ADDRESS>:80. Open fd = {X}
2. complete an in place update listener, and the old listener is draining filter chain. This draining state last drain_timeout. The new listener create listen fd=Y. Now open fd = {X,Y}.
3. immediately stop the listener. Open fd = {X}, Closed fd = {Y}.
4. after the drain_timeout, Closed fd = {X,Y}

The expectation is that
after 3 but before 4, tcp client connect to :80 should see reset()

Actual
tcp client connect to :80 is successful because the old listener fd = X is open. It's a minor issue because envoy doesn't serve the tcp client.

@lambdai thanks for sharing this. Based on https://github.com/envoyproxy/envoy/pull/18677#issuecomment-947906577, it doesn't seem like there is an issue related to the bug you were fixing. Are you certain it's the same issue as this bug? Also note that I do not see this issue in v1.19.1, but consistently hit this when using v1.21.1.

I can't reproduce this issue on 1.21.1 and main branch.
I use a very simple listener as below
 {
   "@type": "type.googleapis.com/envoy.admin.v3.ListenersConfigDump",
   "version_info": "1",
   "dynamic_listeners": [
    {
     "name": "listener_0",
     "active_state": {
      "version_info": "1",
      "listener": {
       "@type": "type.googleapis.com/envoy.config.listener.v3.Listener",
       "name": "listener_0",
       "address": {
        "socket_address": {
         "address": "<IP_ADDRESS>",
         "port_value": 10000
        }
       },
       "filter_chains": [
        {
         "filters": [
          {
           "name": "envoy.filters.network.http_connection_manager",
           "typed_config": {
            "@type": "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager",
            "stat_prefix": "http",
            "rds": {
             "config_source": {
              "api_config_source": {
               "api_type": "GRPC",
               "grpc_services": [
                {
                 "envoy_grpc": {
                  "cluster_name": "xds_cluster"
                 }
                }
               ],
               "set_node_on_first_message_only": true,
               "transport_api_version": "V3"
              },
              "resource_api_version": "V3"
             },
             "route_config_name": "local_route"
            },
            "http_filters": [
             {
              "name": "envoy.filters.http.router"
             }
            ]
           }
          }
         ]
        }
       ]
      },
      "last_updated": "2022-02-27T15:52:02.773Z"
     }
    }
   ]
  },

then I remove the listener_0.
$ curl -v http://<IP_ADDRESS>:10000
*   Trying <IP_ADDRESS>:10000...
* TCP_NODELAY set
* connect to <IP_ADDRESS> port 10000 failed: Connection refused
* Failed to connect to <IP_ADDRESS> port 10000: Connection refused
* Closing connection 0
curl: (7) Failed to connect to <IP_ADDRESS> port 10000: Connection refused

Before reach to the drain time, I connect to the listener port, the connection isn't hang. It is refused directly.
@shashankram not sure I understand you case clearly, let me know if I didn't test the correct case.
config.txt

listener_manager.total_filter_chains_draining: 4
listener_manager.total_listeners_draining: 1

@soulxu could you kindly use the exact build type and image, I noticed you are using a DEBUG build, please use the following in your test:
      "version": {
       "major_number": 1,
       "minor_number": 21,
       "patch": 1
      },
      "metadata": {
       "ssl.version": "BoringSSL",
       "revision.status": "Clean",
       "revision.sha": "af50070ee60866874b0a9383daf9364e884ded22",
       "build.type": "RELEASE"
      }

I am using the envoyproxy/envoy-alpine:v1.21.1@sha256:c2c0b7c136f9daf09c36ef550635eaf5db26465529a1354f725f11390e530879 image from Dockerhub.

@shashankram
I don't believe that issue is fixed. The PR is closed because it's not critical, plus a more elegant patch is desired

@lambdai Are you certain the issue I am seeing (connection hang when listener is draining) is related to the issue you pointed out? Also why is this not seen in v1.19.1? With v1.21.1, I can consistently reproduce this in my internal environment.

This seems like the issue described in https://github.com/envoyproxy/envoy/issues/18616.
@lambdai is this issue not fully addressed in v1.21.1? Is there a workaround for this?

Based on packet captures, I can conclude that the outbound listener on port 15001 does not refuse connections when the listener is in draining state.
client: <IP_ADDRESS>
local envoy: <IP_ADDRESS>:15001
server: <IP_ADDRESS>
Packet capture after HTTP GET:

I can confirm that this issue seems to be introduced by the change https://github.com/envoyproxy/envoy/commit/ba474ac375418d5529a30a9510a8ff5f0a5ada9a (/cc @mattklein123)
I cannot reproduce this issue with the previous commit https://github.com/envoyproxy/envoy/commit/e0380add8104a83c0ca893d34a46df43b0e02eb2

As @lambdai said there is a known issue in the related issue. @lambdai I lost the thread on that since I thought you had fixed it. Should that issue be reopened so we can track it?
In terms of this issue I can't say whether it's the same or not. Can you provide a self contained repro and I can take a look at some point? Thanks.

I tried to reproduce in a standalone environment using filesystem based dynamic configuration. I used the example https://www.envoyproxy.io/docs/envoy/latest/start/quick-start/configuration-dynamic-filesystem and tried removing the listener so it starts to drain. I couldn't reproduce the issue exactly like in my original environment because I don't see the listener_manager.total_filter_chains_draining metric increment in the standalone environment.
As per https://github.com/envoyproxy/envoy/issues/20113#issuecomment-1051087984, when this issue happens, I see the following stats when the listener is removed:
listener_manager.total_filter_chains_draining: 4
listener_manager.total_listeners_draining: 1

While using filesystem based configuration, I see:
listener_manager.total_filter_chains_draining: 0
listener_manager.total_listeners_draining: 1

*Note: CDS and LDS configs for filesystem based configs are taken from https://www.envoyproxy.io/docs/envoy/latest/start/quick-start/configuration-dynamic-filesystem.
@mattklein123 Is there a way I can force the total_filter_chains_draining metric to increment in a standalone environment using the quick-start example?

@mattklein123 I was able to repro this on a standalone environment.
Steps:

Deploy Envoy locally exactly as described in https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/dynamic-configuration-filesystem

Update the lds.yaml to have multiple filter_chains with filter_chain_match:

resources:
- "@type": type.googleapis.com/envoy.config.listener.v3.Listener
  name: listener_0
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 10000
  filter_chains:
  - filter_chain_match:
      destination_port: 10000
    filters:
      name: envoy.filters.network.http_connection_manager
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
        stat_prefix: ingress_http
        http_filters:
        - name: envoy.filters.http.router
        route_config:
          name: local_route
          virtual_hosts:
          - name: local_service
            domains:
            - "*"
            routes:
            - match:
                prefix: "/"
              route:
                cluster: example_proxy_cluster
  - filter_chain_match:
      destination_port: 20000
    filters:
      name: envoy.filters.network.http_connection_manager
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
        stat_prefix: ingress_http
        http_filters:
        - name: envoy.filters.http.router
        route_config:
          name: local_route
          virtual_hosts:
          - name: local_service
            domains:
            - "*"
            routes:
            - match:
                prefix: "/"
              route:
                cluster: example_proxy_cluster

Ensure curl succeeds:
$ curl http://localhost:10000/
Request served by service2

HTTP/1.1 GET /

Host: localhost:10000
User-Agent: curl/7.68.0
Accept: */*
X-Forwarded-Proto: http
X-Request-Id: faeb81a4-2f1f-4022-981f-a5e253826666
X-Envoy-Expected-Rq-Timeout-Ms: 15000

Remove listener_0 by changing lds.yaml to:

resources: []

Confirm curl hangs:

$ curl http://localhost:10000/
^C

OK thanks for taking the time to provide a repro. @lambdai are you interested in looking at this? Otherwise I can try to find time to take a look.

@mattklein123 Sorry I have too many things on my plate this week. I can look early next week

@mattklein123, @lambdai were you able to repro this?

@mattklein123, @lambdai were you able to repro this?

Still blocked on this to be able to update to the latest Envoy version. Please let me know if there is a workaround.

envoyproxy/envoy-alpine:v1.21.1

I got some bandwidth, but I still can't reproduce this yet.
Are you using this image directly https://hub.docker.com/r/envoyproxy/envoy-alpine/tags ?

See https://github.com/envoyproxy/envoy/issues/20113#issuecomment-1055930033 for repro steps.

envoyproxy/envoy-alpine:v1.21.1

I got some bandwidth, but I still can't reproduce this yet.
Are you using this image directly https://hub.docker.com/r/envoyproxy/envoy-alpine/tags ?

See #20113 (comment) for repro steps.

Yes, I try that steps, but I can't reproduce them.
I update the config to remove listener
[2022-03-31 02:35:57.554][1136423][info][upstream] [source/server/lds_api.cc:58] lds: remove listener 'listener_0'
[2022-03-31 02:35:57.554][1136423][debug][config] [source/common/config/filesystem_subscription_impl.cc:88] Filesystem config update accepted for /home/hejiexu/go/src/github/soulxu/envoy-example/current.yaml:

Then the connection will be refused directly.
$ curl -v http://<IP_ADDRESS>:10000
*   Trying <IP_ADDRESS>:10000...
* TCP_NODELAY set
* connect to <IP_ADDRESS> port 10000 failed: Connection refused
* Failed to connect to <IP_ADDRESS> port 10000: Connection refused
* Closing connection 0
curl: (7) Failed to connect to <IP_ADDRESS> port 10000: Connection refused

hmn...I can't reproduce with this image also https://hub.docker.com/layers/envoy-alpine/envoyproxy/envoy-alpine/v1.20-latest/images/sha256-7b35149b22a2a00f3c244853eea071bebde985882088fc9b7e8d0e8d198138b7?context=explore

I can still reproduce this using the latest-dev image exactly as described in https://github.com/envoyproxy/envoy/issues/20113#issuecomment-1055930033
I can confirm that this issue seems to be introduced by the change https://github.com/envoyproxy/envoy/commit/ba474ac375418d5529a30a9510a8ff5f0a5ada9a (/cc @mattklein123)
I cannot reproduce this issue with the previous commit https://github.com/envoyproxy/envoy/commit/e0380add8104a83c0ca893d34a46df43b0e02eb2
@soulxu please confirm you are following the steps exactly as described, and please share the detailed steps you followed. Note that you need to have multiple filter chains on the listener first, and then remove the entire listener to reproduce the issue.

Sorry for the reply late, also thanks for those reproduce steps! I can reproduce now.
Previously I only startup with lds-2.yaml, then remove the listener, it won't reproduce the problem. Now with one more step with lds-1.yaml, it can be reproduce now. I will dig into it.

/assign @soulxu

@soulxu, which release has this fix?

@soulxu, which release has this fix?

Seems like this is available on v1.22.0 and v1.22.2

@soulxu, which release has this fix?

Seems like this is available on v1.22.0 and v1.22.2

you are right, it is on v1.22.0, and greater than 1.22.0


Lake serve has become 50% slower since 3.2.1

cd lake
git checkout v3.2.1
time lake serve </dev/null    # 440ms
git checkout ff619a3397bed8b6474ac12e5cf7f78cf59a34da
time lake serve </dev/null    # 670ms

My local RelWithDebInfo build is even worse at three seconds.

Is this lake serve in particular or just Lake in general (e.g., lake build as well)?

What confuses me here is that there is no significant runtime difference between the v3.2.1 bootstrap CI and the current bootstrap CI. I would think such a performance degradation would effect the build as well.

This issue is rather stale and some major performance improvements have landed (lean4#2444 and lean4#2480), so I am closing this issue.


Update Chiado bootnodes

Changes:

Update chiado bootnodes

Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Testing
Requires testing

[ ] Yes
[x] No

Codecov Report
Base: 84.25% // Head: 84.05% // Decreases project coverage by -0.19% :warning:

Coverage data is based on head (eb81b7f) compared to base (147839f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
- Coverage    84.25%   84.05%   -0.20%
===========================================
  Files           35       35
  Lines         2089     2089
===========================================
- Hits          1760     1756       -4
- Misses         263      266       +3
- Partials        66       67       +1

Flag
Coverage Δ

unittests
84.05% <ø> (-0.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cli/cli_utils.go
88.88% <0.00%> (-1.94%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Flex unit testing support hard-coded with 10.1 version of player

The unit test support is hardcoded with th 10.1 player on the windows platform. This breaks the tests when trying to run them against Flex 4.5.

fixed

Cool we have this fixed, though I am wondering about Flex's future
given the news coming out of Adobe in the last week.
On 13 November 2011 12:23, Yennick Trevels
<EMAIL_ADDRESS>wrote:

fixed

Reply to this email directly or view it on GitHub:
https://github.com/GradleFx/GradleFx/issues/9#issuecomment-2721817

Don't worry about the future of Flex, everything will be allright. Been to
an Adobe usergroup today and Michel chaize from Adobe explained the whole
situation and how it was one big PR fuckup. They will keep supporting Flex
for a whole while because they think html5 is far from ready. They did an
internal study about this and it proved that html5 needs a minimum of 3
years to become good enough for enterprise development. So they still
recommend Flex, and they will be doing it for a long while. They will
release a new blog post this evening which explains the whole situation a
bit better with a whole timeline for the future of Flex.
I got several things fixed and I integrated support for AIR, so this will
be in the next release (somewhere end this week I hope).
Tomorrow I'm going to Devoxx and I'm going to show our plugin to Michael
Chaize because he got interested in it after I talked to him about it at
the usergroup. He said he'll try to promote our plugin, so that's good news
;)
Good stuff ahead.
Greetz
On Tue, Nov 15, 2011 at 9:42 PM, Steven Dick <
<EMAIL_ADDRESS>
wrote:

Cool we have this fixed, though I am wondering about Flex's future
given the news coming out of Adobe in the last week.
On 13 November 2011 12:23, Yennick Trevels
<EMAIL_ADDRESS>wrote:

fixed

Reply to this email directly or view it on GitHub:
https://github.com/GradleFx/GradleFx/issues/9#issuecomment-2721817

Reply to this email directly or view it on GitHub:
https://github.com/GradleFx/GradleFx/issues/9#issuecomment-2750963

Don't worry about the future of Flex, it'll be allright ;)


Feature:  An Implementation of VDR for resolving DIDs against an Indy ledger

This PR contains:

A VDR implementation that relies on the go wrapper for libindy-vdr

To use this extension you will need to have libindy-vdr.so installed.
Signed-off-by: Phil Feairheller<EMAIL_ADDRESS>

Codecov Report

Merging #34 (6e664af) into main (fc5d5e6) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   78.41%   78.69%   +0.27%
==========================================
  Files           4        5       +1
  Lines         468      474       +6
==========================================
+ Hits          367      373       +6
  Misses         58       58
  Partials       43       43

Impacted Files
Coverage Δ

component/vdr/trustbloc/vdr.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5d5e6...6e664af. Read the comment docs.


Added test cases and output

Added 2 test cases and an output as requested

Hi,
You could have updated your previous PR by just adding a new commit


Add DB with data

This PR updates the DB with data

we can't do that, db will be changing every single second :confused:

Wait I didn't get you

wait don't merge it. let me complete a pr first

Merging it now. Approved by @LakshyaKhatri on discord


Fix CursorResourceManager.close

This PR is an alternative to https://github.com/mongodb/mongo-java-driver/pull/1439.
The commit https://github.com/mongodb/mongo-java-driver/pull/1440/commits/b7be8c856f8e500dcc10ca39757c8dccf33769c3 introduces a draft reproducer of the bug reported in JAVA-5516. Then the following commit fixes it. The reproducer is not guaranteed to reproduce the error, but usually does so in just a few attempts on my machine. With the fix I was unable to reproduce the error.
The commit https://github.com/mongodb/mongo-java-driver/pull/1440/commits/510548421e663d391a89557a9940afeacba2dc9c introduces a reproducer that we can actually check into the codebase.
JAVA-5516

@rozza, I replaced the reproducer with a simpler one that is also deterministic. Please take a look.

Thanks for the fix.
Looking forward to get rid of the assertion errors 👍

If it can help anyone, I think this bug would cause conection not to be freed, which could lead to the saturation of the pool. We had this problem using Spring 3.3.4 (WebFlux) fixed in Spring Boot 3.4.0 when limiting find result with Flux.take(n).