Use mark file to allow for deletion operations to continue through restarts

Problem
Currently we delete local files first, so if pageserver restarts after local files deletion then remote deletion is not continued. This can be solved with inversion of these steps.
But even if these steps are inverted when index_part.json is deleted there is no way to distinguish between "this timeline is good, we just didnt upload it to remote" and "this timeline is deleted we should continue with removal of local state". So to solve it we use another mark file. After index part is deleted presence of this mark file indentifies that it was a deletion intention.
Alternative approach that was discussed was to delete all except metadata first, and then delete metadata and index part. In this case we still do not support local only configs making them rather unsafe (deletion in them is already unsafe, but this direction solidifies this direction instead of fixing it). Another downside is that if we crash after local metadata gets removed we may leave dangling index part on the remote which in theory shouldnt be a big deal because the file is small.
It is not a big change to choose another approach at this point.
Summary of changes
Timeline deletion sequence:

Set deleted_at in remote index part.
Create local mark file.
Delete local files except metadata (it is simpler this way, to be able to reuse timeline initialization code that expects metadata)
Delete remote layers
Delete index part
Delete meta, timeline directory.
Delete mark file.

This works for local only configuration without remote storage.
Sequence is resumable from any point.
The problem is that different pieces of this logic are situated quite far apart from each other in code.
The refactoring idea I have is to introduce DeletionStateMachine entity that goes through these states and is located separately in code so you can observe everything in one place. Timeline can store it under deletion mutex.
Options: refactor existing deletion to use it first, then go back to this PR or merge this PR and then refactor it. Opinions?
The refactoring is done and was merged into this patch. Ref: https://github.com/neondatabase/neon/pull/4619
resolves #4453
resolves https://github.com/neondatabase/neon/pull/4552 (the issue was created with async cancellation in mind, but we can still have issues with retries if metadata is deleted among the first by remove_dir_all (which doesnt have any ordering guarantees))
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Existing tests pass. I'd like to extend failpoints and exercise more corner cases. Besides that should be reviewable.
Even without The refactoring idea I have is to introduce DeletionStateMachine entity I'm thinking about moving various utility functions out of Tenant to timeline/delete.rs

not really a showstopper bugfix.

Its not a showstopper bugfix, but rather a bugfix, because it prevents stuff from leaking

I am thinking if this will allow you to test the many new failpoints easier, then go for it right away, if not then it's up to you.

I think its the same. I'll finish what I planned to implement for integration tests, and revisit this

Failpoints and corresponding test helped to find 5 or so bugs

Am I right that the preliminary refactor was https://github.com/neondatabase/neon/pull/4619 ?
Should update the PR description's section on planned refactoring.

@problame Yep, updated the description

Thanks for review!
I see these two comments as immediately actionable from my side:  first, second if you agree with the analysis.

I fixed discussions that looked immediately actionable to me. Everything left either just needs a confirmation or could be worked on in a follow up.
If no objections please approve. Before merging I'll create follow up issues.
I'll be on vacation since tomorrow. I can take a look on the PR and merge it if no objections remain. Dont plan to make any significant changes. Please ping me when ready.

Listing follow ups:
(I'll turn comments into issues before merge)
https://github.com/neondatabase/neon/pull/4552#discussion_r1258368127
https://github.com/neondatabase/neon/issues/4648
https://github.com/neondatabase/neon/pull/4552#discussion_r1253417777

Pushed requested changes. Follow up list is above.

Since we are still lacking a release-in-between and last week was lost for fumbling around the release, let's keep the conflicts resolved until tomorrow.. It seems the github ui is not up to date (yet) with my 03886df. I can help if needed, been part of most of conflicts there :sweat_smile:

Remaining follow up is: https://github.com/neondatabase/neon/issues/4648
Made two small PR's to fix other two comments. Plan to merge this PR (and follow ups) after release on Tuesday to have a full week on staging before next release.


Added Video Link

Want to Congrats Gnomish on its ETHBucharest win...Such a crazy idea deserves applause 👏
Kind of wanted to check the video demo which felt missing here, Guess DoraHacks saved the day!

Closing due to inactivity!


[SPARK-31827][SQL] better error message for the JDK8 bug of stand-alone form

What changes were proposed in this pull request?

If LLL/qqq is used in the datetime pattern string, and the current JDK in use has a bug for the stand-alone form (see https://bugs.openjdk.java.net/browse/JDK-8114833), throw an exception with a clear error message.
Why are the changes needed?

to keep backward compatibility with Spark 2.4
Does this PR introduce any user-facing change?

Yes
Spark 2.4
scala> sql("select date_format('1990-1-1', 'LLL')").show
+---------------------------------------------+
|date_format(CAST(1990-1-1 AS TIMESTAMP), LLL)|
+---------------------------------------------+
|                                          Jan|
+---------------------------------------------+

Spark 3.0 with Java 11
scala> sql("select date_format('1990-1-1', 'LLL')").show
+---------------------------------------------+
|date_format(CAST(1990-1-1 AS TIMESTAMP), LLL)|
+---------------------------------------------+
|                                          Jan|
+---------------------------------------------+

Spark 3.0 with Java 8
// before this PR
+---------------------------------------------+
|date_format(CAST(1990-1-1 AS TIMESTAMP), LLL)|
+---------------------------------------------+
|                                            1|
+---------------------------------------------+
// after this PR
scala> sql("select date_format('1990-1-1', 'LLL')").show
org.apache.spark.SparkUpgradeException

How was this patch tested?

manual test with java 8 and 11

cc @MaxGekk @yaooqinn @bart-samwel @HyukjinKwon

Test build #123132 has started for PR 28646 at commit 9305d3b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27764/
Test PASSed.

Test build #123133 has started for PR 28646 at commit 8cbff72.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27765/
Test PASSed.

Test build #123132 has finished for PR 28646 at commit 9305d3b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123132/
Test PASSed.

Test build #123133 has finished for PR 28646 at commit 8cbff72.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123133/
Test PASSed.

Test build #123169 has started for PR 28646 at commit fcb3e43.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27799/
Test PASSed.

Test build #123169 has finished for PR 28646 at commit fcb3e43.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123169/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27814/
Test PASSed.

Test build #123187 has started for PR 28646 at commit b7cbc8b.

Test build #123187 has finished for PR 28646 at commit b7cbc8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123187/
Test PASSed.

thanks for the review, merging to master/3.0!

Thank you all!


Version 1607 update

The content need to be updated to build 10.0.14393.0 of Windows SDK.
The new SDK introduce support for Shader Model 6.0 as well as HDR format in both Direct3D 12 and DXGI (1.5).
If anyone have some suggestion or any request is free to put them here.

Updated to SDK 1607 (Redstone 1).


Need to update Pom for newer version of Opera

Get some funky dependency issues if you don't update Opera version in the POM

Pull request #9 is addressing this.


@no_type_check support

Summary
This PR adds support for @no_type_check. Specifically, functions annotated with @no_type_check.
The basics are working, but I'm running into cycles when the diagnostics are emitted from the annotated function's signature and I want to get a second opinion on what the best approach.
The current implementation infers the FunctionType and then checks if any decorator in FunctionLiteralType::decorators is the known NoTypeCheck function. This works well, but cycles are more likely because FunctionLiteralType infers the type of the return type and decorators, and any of those could create a cycle.
An alternative is to do something closer to Pyright:
Instead of resolving the entire FunctionLiteralType, iterate over the function's decorators directly and infer each decorator expression. This reduces the possible cycles because it reduces the scope to the decorators only.
Either approach requires a recovery_fn on the called query to return Type::Unknown for the decorator's expression. So I think this PR might
be blocked on fixpoint iteration.
Test Plan
Added tests, some of them panic :)

This PR means that we need to evaluate the types for certain functions eagerly in order to determine if they're

I wouldn't necessarily say we evaluate them eagerly. It's still lazy. It's just that we need to infer the enclosing function's type when we emit a diagnostic. Other than that, yes, that's exactly the reason why
Filtering the diagnostics out at later stages is a possibility but it complicates the tracking of which ignore codes are used, because we may have to mark them as "unused" when filtering out diagnostics. That's why I prefer keeping it in the emit path as it is in this PR. I also think that will get the required functionality for free once we have fixpoint working. The only question is if we're concerned about handling cycles on a function level and, because of that, prefer infering the decorators instead (to have it at the expression level).
A third possibility is that we track more state in the InferContext and have a in_no_type_check field that is one of:

Yes: Set when inferring the function definition and it sees a no_type_check decorator
IfEnclosing: Only in a no_type_check block if the enclosing function is decorated

That might actually be a good solution and might remove the need for some of the "search the child scopes to find the right function" code as well. It doesn't remove the need for fixpoint entirely. We might still run into cycles but it should be very unlikely.


File upload includes WebKitFormBoundary header and footer

I think this is probably me doing something wrong, because I don't recall this always happening to me, but when I follow the example file upload from the readme, the resulting file that is uploaded contains the form data header and footer. Below is some client-side javascript that makes the PUT request to Amazon's S3 ...
function putToDestination (file, signed) {

  let form = new FormData();

  form.append('file', file);

  return fetch(signed.url, {
    body: form,
    method: 'put',
    headers: {
      "Content-Type": "application/octet-stream",
      "Content-Disposition": "attachment"
    }
  });

};

The signed.url is the pre-signed S3 destination URL that I need to make the PUT request to. Uploading a simple text file, and then viewing the content in S3, results in the following ...
------WebKitFormBoundaryaxpyiPgbbPti10Rw
Content-Disposition: form-data; name="file"; filename="pgadmin.log"
Content-Type: application/octet-stream

foo bar baz

------WebKitFormBoundaryaxpyiPgbbPti10Rw--

Any idea why this is happening? I'm technically using fetchival, which is a wrapper around whatwg-fetch, but I distilled this down to an example using directly whatwg-fetch.

A couple things you can try to narrow down the problem:

Use the native Chrome, or Firefox Nightly, implementation of window.fetch without any polyfills.
We use fetch to upload images that are dropped onto github.com issue comment fields. Drag an image onto a comment field and use the browser's network inspector to compare github.com upload requests to S3 with your own.

Happening without any polyfills, so it's definitely just something I'm doing. With that said, I will close this as it's definitely not an issue with anything other than my code somewhere. Also noted that the request github makes to S3, when uploading images, looks quite a bit different than the one I make - notably github uses POST which I did not realize was an option with S3. Also no content disposition specified in the request, from github.

Looks like it was because I was specifying a content type of application/octet-stream, which I intended to be the type of the upload, not for the request. Makes sense!

@ryancole Glad you solved it and followed up!


TF Encrypted POC

Hey @mortendahl , @jvmancuso,
Here is an initial poc (WIP) with keras under the hood.
I think the best starting point is the example in the notebook. It perform the following steps:

Train model in normal Keras
Save the weights in numpy array by doing model.get_weights()
Perform private prediction:

Define the exact same model with syft.keras
model.share() to instantiate the tfe model and load weights. That's where most of the work is happening.
perform private prediction.

I have done set_weights as a first step. Do you guys think we will have time to do load_weights from an h5 or saved_model file?
I haven't done anything with syft.VirtualWorker. Not sure yet how it's going to fit.
I didn't add any docstring. I'd like to first confirm that's the right approach once we have all the moving pieces.
Thanks.

Hey guys,
I gave another stab at it. It should be a bit closer to what we want. I will continue to work on it tonight.
As a starting point you can check the notebook step2_tfe_private_prediction.ipynb.
However I am really not happy how the function _instantiate_tfe_layer is working. The idea is just to extract the keras layer argument and the weights then load everything in the tfe.layer. There must be a better way to do this.
Thanks


App base path works locally, but not as an IIS Sub App

I have an ASP.NET 4 site and my goal is to create a new hosted blazor web assembly app that runs in a subdirectory of the ASP.NET 4 site running as an application.  I've created the blazor app locally and tested it and everything works.  I followed all the instructions in the App base path section.  I even set up the --pathbase command arg, and changed the launch url to app in the launchSettings.json file.  It's working well on my local machine from VS 2022 and from a command prompt.
Then I took the existing site in IIS and add a sub app.  I updated the app pool to use no managed code.  I published the server project within my blazor app and moved it to a directory that is referenced from the IIS sub app.  The blazor webassembly runs well.  The site loads, but none of the server apps (controllers, api endpoints) work.  The source looks like it's referencing app/fetchdata, but the endpoint isn't there.  It's returning a 404 error.  Also, when you load any of the secondary URLs within the app subdirectory (like app/counter) from the browser url it fails.  It works when you navigate from within the app, but not when you link to the page.
I can't find anything on this topic online.  Not sure if you can help, but I'm not sure how to proceed.  Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e07aaa4d-4ad4-778f-f74a-60d8f05d9075
Version Independent ID: c82cf121-831d-75dd-a796-c735aad3b3e9
Content: Host and deploy ASP.NET Core Blazor
Content Source: aspnetcore/blazor/host-and-deploy/index.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @mkerchenski ... I'm not sure that that's a supported scenario. Open this for the product unit at ...
https://github.com/dotnet/aspnetcore/issues
... please add a cc: @guardrex to the bottom of your opening comment so that I can follow the discussion.


Broadcaster 448

Resolves https://github.com/Islandora-CLAW/CLAW/issues/448
See testing instructions at https://github.com/Islandora-CLAW/CLAW/pull/457, since this requires updates to the install process.

Hrm... Travis is getting blocked from Maven central.  I'll have to investigate.

@dannylamb I've seen that happen from time to time. I usually see it as an opportunity to get a cup of tea or coffee. When I return, it's usually better.

@acoburn :+1: You're right.


Where to place processed data that could be used by other projects

Continuation of https://github.com/spine-generic/data-multi-subject/issues/9#issuecomment-664676285
Context:
Some derivatives are based on processed file (not the raw data, already uploaded to github).
Problem:
some projects need these processed files right away (ie without having to re-generate them).
Potential solutions:

we create a derivatives/sct/ folder under this repos.
problem: people downloading this repos will also download these collateral files (which are specific to a project)
we create another repos, dedicated to ivadomed (or other projects), that only includes the derivatives (labels/ sct/) of interest. Will the loader be happy if you point the "raw" data to derivatives/sct?

@jcohenadad : And what about simply renaming derivatives/labels/sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_rms_gmseg-manual.nii.gz by derivatives/labels/sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_gmseg-manual.nii.gz. Am I missing something?

And what about simply renaming derivatives/labels/sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_rms_gmseg-manual.nii.gz by derivatives/labels/sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_gmseg-manual.nii.gz.

because in some sites, anat/sub-tokyoIngenia04_T2star.nii.gz is a 4d data, which needs to be processed before you can use it to train a model. The same applies to other data (e.g., the T1w scan is resampled to 1mm iso, because some sites used an interpolation filter on the scanner)

And what about simply renaming derivatives/labels/sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_rms_gmseg-manual.nii.gz by derivatives/labels/sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_gmseg-manual.nii.gz.

because in some sites, anat/sub-tokyoIngenia04_T2star.nii.gz is a 4d data, which needs to be processed (ie: averaged across t) before you can use it to train a model. The same applies to other data (e.g., the T1w scan is resampled to 1mm iso, because some sites used an interpolation filter on the scanner)

Makes sense :-)
And .. in that case.. what about adding the image sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_rms.nii.gz?

And .. in that case.. what about adding the image sub-tokyoIngenia04/anat/sub-tokyoIngenia04_T2star_rms.nii.gz?

because of this: Derivatives of the raw data (other than products of DICOM to NIfTI conversion) MUST be kept separate from the raw data.

because of this: Derivatives of the raw data (other than products of DICOM to NIfTI conversion) MUST be kept separate from the raw data.

ishh... yes sorry, you ve already said this.. ..!

we create another repos, dedicated to ivadomed (or other projects), that only includes the derivatives (labels/ sct/) of interest.

Sounds like a good option.
I am only wondering how to do the update between the two derivative folders.. !?
Also.. we would need the "averaged" image at some point..  since the loader is expecting a 3D as image... and I now understand we can't have such image in BIDS, according to BIDS Law... except if we change our loader: if image is 4D --> average along last dimension?!

Will the loader be happy if you point the "raw" data to derivatives/sct?

We only give the path to the entire BIDS dataset so not really.. but I imagine we could make it work locally (ie take the images from this repo and the derivatives from the new repo (sct) to create our working repo). We will also need to make this clear in publications.

we create another repos, dedicated to ivadomed (or other projects), that only includes the derivatives (labels/ sct/) of interest.

Sounds like a good option.
I am only wondering how to do the update between the two derivative folders.. !? ie when we push a new GT on this repo.. how to update the new sct repo?

ah! good point. This is another (related) data management problem @kousu @drulex @zougloub
given that the processing doesn't take long (30s/subject), i suggest that in your ivadomed training pipeline, you include a pre-processing script, which will take https://github.com/spine-generic/data-multi-subject as input (we can track the version of the dataset + processing script).

Also.. we would need the "averaged" image at some point.. since the loader is expecting a 3D as image... and I now understand we can't have such image in BIDS, according to BIDS Law... except if we change our loader: if image is 4D --> average along last dimension?!

the solution above would solve it. And no, i would not change the loader for this. The average of the T2*w is one example, there are other examples (e.g. resampling of the T1w scan). But the point is: we should not mix pre-processing with ivadomed's purpose.

Will the loader be happy if you point the "raw" data to derivatives/sct?

We only give the path to the entire BIDS dataset so not really.. but I imagine we could make it work locally (ie take the images from this repo and the derivatives from the new repo (sct) to create our working repo). We will also need to make this clear in publications.

so, it looks like the solution above is the thing to do.  We could also package these pre-processed data, with datalad/git-annex or other fancy tools @kousu @zougloub

It sounds like you've figured it out, but I'll add my thoughts.
You're talking about adding a cache. Caching is a well-studied but tricky issue to get right since there's no universal implementation of it (make has one, bazel has one, docker has one, http:// has one, haskell has one; and none of those apply to online datasets).
So the most reliable thing to do is option 3: don't cache. Write the code that generates the data and check that in, but don't check in the intermediate data products. My rule of thumb is that unless there is a very good (i.e. expensive) reason, don't try to cache. So let me add my vote for that here.
If you do decide you need to cache, and the processed data is small, you could go with option 1 and include it here under derivatives/*; but I would not tie it to a specific project like derivatives/sct; instead give it a more descriptive name like derivatives/time-averaged/.
If you cache and it's large, there are four options on the table

put it in a separate repo (option 2) and
a. include it with git submodule (diagram)
b. leave it out on its own, but make sure to include its provenance in its commit log
put it in the primary repo (option 1), but actually store the content in a separate partial-download location
a. git-annex (aka datalad)
b. git-lfs

If you do cache, you need to deal with cache-invalidation; which would mean writing down the version of both data-multi-subject and the version of the code that processed it in the git log.
It's instructive to see datalad's thoughts on processing: http://handbook.datalad.org/en/latest/basics/101-109-rerun.html. They write down the commandline run. But that only works for them by having a super-repo that includes both the dataset and the code to process it, and refuse to run on an unclean repo, which doesn't really seem to fit our workflow; and the cache will be invalidated, but undetectably so, if, say, the python version underneath your processing scripts changes and makes subtle changes to your outputs.

Thank you for your insights @kousu-1. After giving it some thoughts, it seems like solution 2a is the most elegant / less prone to error. Indeed, caching does require maintenance, and at some point it's inevitable that we will screw things up (e.g., data is updated on repos A, and we don't update on repos B because we don't have time).  Whereas if everything is tracked in the same repos, and people have the choice to only download what they need (this is a key feature here), then it solves all our problem.
So typical scenario:

external user just wants to download the raw data, without the derivatives: datalad blabladownload sub-*
internal student wants to download the derivatives and some of the processed data: datalad blabladownload derivatives/labels; datalad blabladownload derivatives/sct/*_rms*


#159269831 Make features section in homepage visible

What does this PR do?
Makes the features section of the homepage visible to the user immediately after landing on the page. In the previous version, the hero section stretched to fill the height of the viewport thereby making the features section non-visible. This has been corrected to improve the user's experience on the landing page.
Description of Task to be completed

Add the appropriate CSS classes
Update the markup of the homepage (index.html)
Ensure new change is responsive (displays well on smaller devices)

How should this be manually tested?
Review the changed files and see attached screenshots:

What are the relevant pivotal tracker stories?
#159269831

Pull Request Test Coverage Report for Build 43

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 35:
0.0%

Covered Lines:
51

Relevant Lines:
51

💛  - Coveralls


MFC42D.DLL Ordinal vs Name Question

This is my first time posting anything so I am not sure how to mark this as a question.
I have tried everything to get the External Library function name instead of ordinal to show up in an executable designed in Visual Studio 6.0 for over a week now. I have tried to do the analysis on the MFC42D.DLL using the MFC42D.PDB file and create an FIDs file. I have tried to capture the data types and apply them. I have tried creating the .exports file using the Java Script provided. I can make the .exports file match exactly with the name to ordinals in the MFC42D.DEF file. When I do analysis on the exe file there are still functions pointing to MFC42D.DLL::Ordinal1061 instead of the string that I can see right below the 1061 statement. How do I get Ghidra to name the calls in the thunk_functions created in the analysis to have the string instead of the Ordinal?
The Test.exe is an MFC Application created in Visual Studio 6.0 a dialog form I added 1 button.
Here is the Project Setup.

This is what the Exports looks like for the MFC42D.dll when I applied the PDB

This is the Assembly of the CDialog from the MFC42D.dll

This is the Decompiled  version of CDialog

When I tied the External dll to the MFC that I did analysis on this is what the Test.exe imported
notice they are back to ordinal

This is the CDialog from the Test.exe analysis

This is the CDialog from the Test.exe analysis decompiled

Here is where I created the exports file from the Java Script

Here is where you can see 318 should get tied to CDialog

Could you show your import log for test.exe which would help identify what DLL imports were performed and what errors may have occurred when attempting to resolve the import libraries and symbols.

Please look in your .ghidra/ghidra_9.0.1/symbols directory.  If there aren't pre-existing .exports file, then one gets created here during import.  It is possible the .exports file exists here that is overriding your changes.
Also, I believe the .exports file is only applied at import time.  Are you re-importing the file after adding changes to the .exports file?
If this is the case, then a change may be needed to notice that a new .exports file has been added.

Please look in your .ghidra/ghidra_9.0.1/symbols directory. If there aren't pre-existing .exports file, then one gets created here during import. It is possible the .exports file exists here that is overriding your changes.
Also, I believe the .exports file is only applied at import time. Are you re-importing the file after adding changes to the .exports file?
If this is the case, then a change may be needed to notice that a new .exports file has been added.

So just to let you know, your information about the .exports going to my .ghidra/symbols directory on import was the key (on a side note the checkbox on import to create .exports does not appear to do anything, it makes the exports in my ghidra folder either way). It is a little strange that you have to import the executable and let it pull in the Ordinals from MFC42D.dll then open the MFC42D in the editor add the PDB file let it rename everything run the java script that exports the modified .exports file into a folder that is not used for importing my executable. Then I have to open a new project because it remembers the information from the last time if was imported if you don't use a new project. Then put the correct .exports file from the Base\data\symbols folder into the .ghidra\symbols folder. Then re-import the executable and it will finally have the correct names for the classes from the MFC. Thanks for the great tool it is fun to dig into old exe files.


2 fixes for warning explanation docs

How are you finding errors?
Anything else you'd like to see? Are you finding the warnings useful?
Thanks for the PR!

I updated to Node v6 and I guess something changed that it is now surfacing some errors that were previously swallowed and that's how I found the "Warning: a promise was created in a handler but was not returned from it" one. It was a little confusing that the top of the stack wasn't necessarily the source of the error, but other than that the docs are very helpful so it was relatively painless to figure out what was wrong and fix it.

Thanks.


Activity 1: Your First Caption

Using the API, I have just created a file with a random octocat for you to caption. In this activity, we will learn how to make changes to files in our GitHub repository.

[ ] @gusshawstewart
[ ] @mericstam

Hello!

@mericstam

@mericstam hello again!


Property and Interface issues

Try to convert this project:
ToolFramework.zip
The vb project will contain about 500 errors, most of them are due 2 reasons:

The property private filed , which has the same name of the property with small casing. I issued this b4 but it is not fixed till now. The solution is to get the property names and filed names, and ckeck if any property has the same name as a filed with ignoring case cpmparison, and if so, the field must be renamed by adding an _ prefix. This needs tracing the field name in the scope to rename it, and be aware if any function has a param with the same name of the filed, then only Me.[Filed] should be renamed to Me._[Filed].
I also suggest to refactor full properties to auto properties if the field only appers in the standered property def. with no more code. This will iliminate the need to rename the private filed as it should be removed in this case!

The converter translate interface implementauion statement to Inherits statement. The ambiguity of the C# : can be solved by checking if the type is and interface or a class, then the converter should add the implements statement to each function/property  matching a name of Interface members.

@VBAndCs  I am mostly retired, if you want to do the fixes will review and update.

@paul1956
I can't work on the converter now.
By the way, there is a null reference bug while converting this project.
Also, the converter is too slow, as it doesn't use the full processor power. In converting solutions, you should use multi threading to convert 4 or more files simultaneously, to get the most of the processor cores. This should work fine as the conversion happens after compiling the C# project and got Symantec.

@paul1956
And you should review your retiring decision, as Anthony is back and willing to do amazing things for VB .NET and needs the community help.

@VBAndCs I am monitoring Anthony's blog and am traveling 50% of the year WITHOUT internet. I found the crash and am fixing it as its trivial. Tackling the other issues require more dedicated effort then I am able to put in at this time. As for threading the app I specifically don't want more threading because at the moment I only have 1 global symbol table, if that issue was addressed the app could run with more threads.

@VBAndCs
Project conversion crash is fixed in version <IP_ADDRESS>/<IP_ADDRESS>


How to render the face mesh

Thanks for your great work.
 I set the this.GetComponent<MeshFilter>().mesh = _resources.faceMeshTemplate; in Visualizer.cs OnPostRender() function. but it not work. By the way, I found the  _resources.faceMeshTemplate.Vertices are all zero. So which mesh can set UVs and be shown?
I am not very familiar with unity and CG.  The above statement may be not very accurate. Could you please provide some ideas for that task? Thanks!
example about what I want to implement

I found the _resources.faceMeshTemplate.Vertices are all zero

Because it only contains index data. Vertices are given externally.
I'd recommend reading Visualizer.cs and Visualizer.shader in the FaceLandmarkBarracuda project.
https://github.com/keijiro/FaceLandmarkBarracuda

Or use this branch. I'm not sure if it still runs (may be broken due to compatibility issues).
https://github.com/keijiro/FaceMeshBarracuda/tree/landmark-detector

Thanks. I will try it.


next-css doesn't support server side rendering

In this small repo I've illustrated next-css not working with SSR, this is a blocker from my team moving off of https://github.com/traveloka/styled-modules which we're super eager to do.
Great work on Next.js 5.0! Can't wait to fully migrate to it :)
I would mind if Next.js apps had to have a custom _document.js to support this, but I guess thats more of an implementation detail.

Noticed this as well. As a temporary workaround for this, it's possible to disable the ExtractTextPlugin after it's been added by next-css via your next.config.js:
const withCSS = require('@zeit/next-css');
const ExtractTextPlugin = require('extract-text-webpack-plugin')

module.exports = withCSS({
  webpack: (config) => {
    config.plugins = config.plugins.map((p) => {
      if (p instanceof ExtractTextPlugin) {
        p.options.disable = true
      }
      return p
    })

    return config
  },
})

Running into this issue as well

As far as I can tell, there are two issues preventing the extract plugin from working as intended:

The CSS file is extracted to /.next/static/style.css, but static files aren't served from that directory or copied to the output folder when using the extract command. Moving the file to to /static/style.css (relative to the project root) would resolve that issue.
In the SSR/static export environment, you will need a <style> tag that references the CSS file somewhere in your app's <head>. This could be accomplished by adding some code to a custom document component (/pages/_document.js), which may or may not be within the scope of the plugin. For example this would include the appropriate style tag outside the dev environment:

<Head>
  {!this.props.dev && (
    <link rel="stylesheet" href={`${this.props.__NEXT_DATA__.assetPrefix}/static/style.css`} />
  )}
</Head>

@ScottPolhemus https://github.com/zeit/next-plugins/tree/master/packages/next-css#production-usage

Having this issue also. Any CSS file that I import causes the FOUC.

@timneutkens This is great, thanks! Those instructions work well for SSR, so I think the only remaining issue is that the /.next/static directory is not copied to the output folder when running next export.
For anyone following along, this just means you'll need to run cp -r .next/static out/_next after next export for this to work with the static export function currently (replacing out with your output folder if you specified one for export).

Running next build && next start with cssModules enabled – the generated class names do not match the HTML/JS output.

I’ve made a PR for SSR support btw 👍🏻

I seem to be experiencing the same issue as @thomaslindstrom. Any luck with that?

For those that are reading this after version 0.1.0 (when https://github.com/zeit/next-plugins/pull/50 got merged), you no longer need to do what @ScottPolhemus is suggesting with !this.props.dev. After 0.1.0 the style.css file is now also generated in dev mode so you can just put a <link rel='stylesheet' href='/_next/static/style.css' /> in _document.js and you should be good to go in both dev and prod without FOUC. Thanks to @timneutkens for the PR!

Subbing to this. The following doesn't work:
module.exports = withCss(
  withLess({
    cssModules: true,
  })
);

Removing withCss wrapper and it works fine, just I'm trying to pull in some external css from node_modules.

I am experiencing an issue where my external css file doesnt get updated on client side page transitions. It only works flawless on ssr. What could cause this issue? Only way to get it properly working for me at the moment is to prefetch every css file.

@hanford have you had a chance to see if the PR works for you?

@Ehesp Did you get that it working?

On my side I didn't get it working 😕 I ended up with my own withSass Next plugin

How I configure it:
const sassConfig = withSass({
      sassLoaderOptions: {
        includePaths: ['styles', 'node_modules']
          .map(d => path.join(__dirname, d))
          .map(g => glob.sync(g))
          .reduce((a, c) => a.concat(c), [])
      }
    })

Then how I use it in my app

I sill have a specific rule to handle my css files
      config.module.rules.push({
        test: /\.css$/,
        use: ['babel-loader', 'raw-loader', 'postcss-loader']
      })

@Marvin1003 - Did you fix this? I am having same problem with next-sass. Client side transitions are not loading the updated style.css file. I have to reload the whole page in order to update the style.css file.

@prabu-ramaraj sadly no.
I use external styled components now with which i can approach the same.

Just referencing this issue: https://github.com/zeit/next.js/issues/4184

Nearly half a year.. Any updates about this "OMG Maximum" priority issue?

@timneutkens Any clue where to start?

You'll probably want to use https://github.com/zeit/styled-jsx#styles-in-regular-css-files instead of next-css.

I was able to get this working using styled-jsx plugins. This example is for antd, probably similar for others:
.babelrc
{
  "presets": [
    [
      "next/babel",
      {
        "styled-jsx": {
          "plugins": ["styled-jsx-plugin-less"]
        }
      }
    ]
  ]
}

next.config.js
module.exports = {
  webpack: (config, { defaultLoaders }) => {
    config.module.rules.push({
      test: /\.less/,
      use: [
        defaultLoaders.babel,
        {
          loader: require('styled-jsx/webpack').loader,
          options: {
            type: 'global'
          }
        }
      ]
    });

    return config;
  }
};

_document.js
import React from 'react';
import Document, { Html, Head, Main, NextScript } from 'next/document';

import antdCustom from '../antd-custom.less';

class MyDocument extends Document {
  static async getInitialProps(ctx) {
    const initialProps = await Document.getInitialProps(ctx);
    return { ...initialProps };
  }

  render() {
    return (
      <Html>
        <Head>
          <style>{`body { margin: 0 } /* custom! */`}</style>
          <meta
            name="viewport"
            content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no"
          />
          <meta name="apple-mobile-web-app-capable" content="yes" />
          <style>{antdCustom}</style>
        </Head>
        <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    );
  }
}

export default MyDocument;

antd-custom.less
@import 'node_modules/antd/dist/antd.less';

@primary-color: #1890ff;

I'm new to next-css. What  exactly is wrong with server-side rendering and this plugin?

Hi, thanks for creating an issue. We currently recommend using nextjs.org/docs/basic-features/built-in-css-support as the plugins have been deprecated in favor of the built-in support.


Don't store the seqinfo in the metadata

This should be a dedicated field. Otherwise operations on the metadata may inadvertently interfere with the seq_info.

new version should take care of this


⚠ Mobitopup has degraded performance

In 5244306, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 4421 ms

Resolved: Mobitopup performance has improved in 4128715 after 418 days, 2 hours, 42 minutes.


Translated into :jp: language

Hi @jlord,
This is the PR that translate into :jp: completely which was used for the patchworks held in Kobe, Kyoto, Tokyo.
Could you please check it and merge it if you don't see any problems on it?
Thanks.
(Sorry about  #90, which was just a mistaken..., this is the correct one.)

cc @muan

Awesome, this is fantastic!
@dice should this supersede #79?

@jlord absolutely, I'll just close #79

@jlord Fixed the conflicts. :smile:

Oh, fantastic, thanks so, so much!
I'm gonna spend some of the holidays getting back into this and hopefully get it out of a beta state :sparkles:


strange IAM/lambda while creating the cluster

Description
When i create a new EKS cluster i can see this on my EKS log but my Account ID is different.
Anyone know what is this ?
I cannot find anything on the repo or preview issues
time="2023-01-23T14:06:32Z" level=info msg="access granted" arn="arn:aws:iam::xxx1:role/AWSWesleyClusterManagerLambda-NodeManagerRole-13LW3Y484DKRN" client="<IP_ADDRESS>:51358" groups="[]" method=POST path=/authenticate uid="aws-iam-authenticator:xxx1:xxxxxxxxxxxxxxxxxx" username="eks:node-manager"

this is an internal Amazon role used for automation - it is safe to ignore


merge from template-node-app

package.json

chore(deps): add ^12.2.0 remove ^12.1.6 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 6.4.5 :tada:
The release is available on:

npm package (@latest dist-tag)
v6.4.5
GitHub release

Your semantic-release bot :package::rocket:


retention-period: Add archiving expired messages tool by retention pe…

…riod

Add models to store expired messages and expired user messages data after
removing from original Message and UserMessage db tables.
Add django migrations to create tables for archive models.
Add tools for moving expired messages to archive tables.
Add tools for deleting expired messages from Message and UserMessage tables.
Add tests to check archiving and deliting tools.
Add manage command to archive expired messages.

Automated message from Dropbox CLA bot
@kkanahin, it looks like you've already signed the Dropbox CLA. Thanks!

Thanks for working on this @kkanahin!  I did a read through this, and it's looking really good; I posted one comment above on the tests; will review more closely later this week.
To what extent do you have outstanding TODOs for this?  The main things I notice are:

We still need to add the management command code for actually deleting old ArchivedFoo stuff, with support for a retention duration (would just make it a server setting in the zproject/settings.py defaults at 30 days or something; see docs/settings.md for details) of the ArchivedFoo tables.
We need to add ArchivedAttachment support (using Attachment.Messages to track whether the last message touching an attachment has been archived).

It's fine to work on those as added commits on top, though.

@timabbott Your TODO items are correct and will be done in next iteration.

Should we use the Django ORM for the SQL queries here?

Django orm doesn't support moving  from one table to other in one query. It recieves all  data then convert them to list (I mean bulk_create) and insert to the new table. In my  methods it is done in one query withouth python processing.

For this operation, which is probably going to be our single most expensive type of SQL operation that Zulip does, I think it totally makes sense to do it in SQL.

Got it, thanks!

@timabbott please review this pull request. I've added documentation page for retention feature and need your opinion about it. And could you review my answer for attachment test case.
Also I've added front-end part for retention period in admin settings.

The document could use a pass for English grammar, but otherwise looks good; I can get another contributor to tweak that.
I'll review the new code in detail in the next few days, but the one feature that I think this is still missing is a plan / tools for how we would unarchive some messages in the event that we discovered there had been a bug in this logic; it seems likely we'll eventually want to do that, and I'm thinking it might be wise to write the  code+tests for it now rather than when we have incident.

I've fixed English grammar. Regarding restoring tool I will develop it.

PR was updated. I've added restoring tools, console command and documentation part.

Can you rebase this onto master?

@kkanahin can you rebase this on top of master?

sure @timabbott I'm merging

@timabbott, merged.

@timabbott PR has been updated and ready for review.

@kkanahin In commit a7bdc6ad439406f01c5c9d435180af129af9ac2f please correct the spelling of "deleting" in your commit message.
Could you please add "Fixes: 106." to the end of one of your commit messages? (I might be wrong and this might only be a step towards fixing #106 -- let me know if I am.)

@kkanahin I was looking through this in order to improve the documentation, and I'm a little confused and hope you can help me understand something.
In the discussion in #106 @timabbott mentioned that

I'd like to use a model where after the N days the messages are deleted from Message, but added to a new table e.g. ArchivedMessage, and kept there for a week before being deleted finally, so that we have time to catch bugs for data is lost permanently.

Does your implementation do this? I looked at retention.py and I see where the archiving steps use the time delta between the current date and the publication date of the message and compare that against the number of days specified in the retention policy, but I don't think I see where the deletion steps wait the additional week after that. If I missed it, you should probably add some code comments or rename some variables to make them pop out better. Thanks!

@kkanahin I started on an improvement of retention.md in https://github.com/brainwane/zulip/commit/d70f8630769c0588f2ed2a0703110370265a4dc8 but I'm confused about the difference between
delete_expired_messages and delete_expired_user_messages,  and the difference between those kinds of methods and the delete_expired_archived_attachments/delete_expired_archived_data set. Your documentation says "Records are removed from the actual tables when they don't have related objects", but should we be deleting anything from the main tables before moving it to the archived messages/attachments/data tables?
Thanks!

thanks @brainwane for review. I will fix all bugs soon.

@kkanahin I was looking through this in order to improve the documentation, and I'm a little confused and hope you can help me understand something.
In the discussion in #106 @timabbott mentioned that
I'd like to use a model where after the N days the messages are deleted from Message, but added to a new table e.g. ArchivedMessage, and kept there for a week before being deleted finally, so that we have time to catch bugs for data is lost permanently.
Does your implementation do this? I looked at retention.py and I see where the archiving steps use the time delta between the current date and the publication date of the message and compare that against the number of days specified in the retention policy, but I don't think I see where the deletion steps wait the additional week after that. If I missed it, you should probably add some code comments or rename some variables to make them pop out better. Thanks!

@brainwane I've added field "archived_date" to the ArchiveMessage, ArchiveUserMessage and ArchiveAttachment models as well as 'ARCHIVED_DATA_RETENTION_DAYS' configuration parameter to monitor archived messages life cycle.  You can find logic for removing archived messages in 'zerver.lib.retention.delete_expired_archived_data' function . For removing archived attachments I've created function 'zerver.lib.retention.delete_expired_archived_attachments'. I will add explanation comments to them.

@kkanahin I started on an improvement of retention.md in brainwane@d70f863 but I'm confused about the difference between
delete_expired_messages and delete_expired_user_messages, and the difference between those kinds of methods and the delete_expired_archived_attachments/delete_expired_archived_data set. Your documentation says "Records are removed from the actual tables when they don't have related objects", but should we be deleting anything from the main tables before moving it to the archived messages/attachments/data tables?
Thanks!

difference between
delete_expired_messages and delete_expired_user_message
'delete_expired_user_message' - function for removing 'user_messages' (one message can belong to several users and this table is used for saving data about this)
'delete_expired_messages' - function for removing 'messages' from Message table after retention period. These messages can't be removed if one of a related user_messages is actual.

and the difference between those kinds of methods and the delete_expired_archived_attachments/delete_expired_archived_data set

I've moved deleting expired archived attachments to separate function cause it requires more than one action(i.e removing files from storage) and it should be more comfortable to support this part.

Your documentation says "Records are removed from the actual tables when they don't have related objects", but should we be deleting anything from the main tables before moving it to the archived messages/attachments/data tables?

We shouldn't cause it's not safety. we must have a copy of data in archive tables before deleting from main tables. This logic allows avoiding accidental deletion data from main tables and data loss.

@showell or @timabbott I'm planning on doing an edit of retention.md to help improve this PR but I want to get a double-check from you that the architecture of the PR is what we want it to be, so I don't waste time documenting the wrong behavior. Thanks.

@brainwane yep, the architecture is correct and unlikely to change.

@kkanahin can you give this one a rebase?

A few more comments:

The migrations need renumbering
It'd be great if the management commands had a --dry-run option that would just report how many things would be archived/deleted, if that's easy to do without duplicating a lot of code.  I think one will definitely want those options to feel good about deploying this.

Sure @timabbott. Sorry I've noticed your comments just today.

@lonerz @synicalsyntax this loop seems like a bug :)

@timabbot hmmm, I thought I took care of this bug already. Will look into it.

Since @kkanahin mentioned the issue each time for his 8 commits, zulipbot posted 8 comments. @lonerz Are you working on this now or would you like me to open an issue for this?

@synicalsyntax you can open an issue and take care of it.

@kkanahin this is failing tests; it looks like because you didn't add tests to test_realm.py for the new setting; can you fix that?  Also seems to have some mypy errors; didn't look at those though.

@timabbott Yes will do it

@kkanahin I did some performance testing on the queries we're using, and I think unfortunately they're just way too slow to be able to use this at scale in production.
Some things I've confirmed (focusing on the messages query for now):

If we can avoid joining against UserMessage, the query runs fairly fast (e.g. 50ms for a single medium-size realm with 1000 messages/day for a single historical day).
If we do need to join against UserMessage, the query can take a really long time (e.g. > 2 minutes ever after limiting to just 1 day and just 1 medium-size realm), basically because it requires a sequential scan in the query plan (which is likely to be hopeless at scale).

So here's a proposed new architecture that would solve this problem:
(1) We do a loop over realms to shrink the commit sizes to be something manageable.  Later, if we offer per-stream limits, we can probably make this looping over recipient_ids with custom retention policies (and we'll need to do this anyway to handle the variability in retention policy).
(2) Within that loop, we first query all the messages in the expiry time window that were sent by a user in the realm (this will miss cross-realm messages, so we'll need to handle separately, but is at least fast!).  We can either return the "chopping block" messages to Python for further processing (since there shouldn't be that many), or proceed to create ArchivedMessage objects for them.
(3) Then, we created ArchivedUserMessage for any UserMessage entries in the realm that correspond to the new ArchivedMessage rows.  This should be fast since we'll have a fixed list of message IDs that shouldn't be too giant to translate here.
(4) Then, we move any MessageAttachment objects to the archive that go with a now-archived message.
(5) Then, we check if any of the Attachment objects connected to any MessageAttachments that were moved via step (4) now have 0 messages; if so, those Attachment objects get moved to ArchivedAttachment.
This way, we only need to do the really expensive query against Message at the very beginning, and the rest we're just interacting with the subset that we're actually moving.
This misses some cross-realm messages, obviously.  We can handle cross-realm messages to streams pretty easily (just query all messages sent by the cross-realm bots with a recipient that's a stream in the realm); later, we can just create duplicate copies of cross-realm bots in each realm to effectively eliminate this whole issue of cross-realm stream messages.
The same works for single-recipient cross-realm PMs by cross-realm bots.
What remains is cross-realm group PMs, which are rare; I'm OK with the initial implementation ignoring them, and we can work on a specialized solution for that problem once it's resolved.
Does that sound doable @kkanahin?  I realize this involves rewriting a bunch of code, but I think the result will be much more stable in the long term.
If I'm not mistaken, almost all of your tests just call archive_messages and check the state, so hopefully this just requires replacing the queries and not rewriting everything.

If we can have a set of small queries that identifies the message ids that need to be archived, then I would echo the idea of some kind of offline process that just handles them one by one.  Since realms are generally adding messages more quickly than removing messages (due to growth over time), it seems to be the offline process will always be able to keep up.  A refinement would be to run the archiver in "slow hours," although determining what those are could be difficult.

@timabbott so, As I understood, Generally, we are going to split archiving by realm, sure it will increase speed. Maybe my way was wrong and didn't think about speed such as we are going to do it one time per day. Yes @timabbott it's quite doable, we just need to split queries by realm and rewrite some moments. So we can split data by realm on both sides(archive and actual tables).
Thank you, Tim for so detailed review. I got your idea.

Also @kkanahin I cleaned up and merged the setting piece (with the template section inside an "if false" so its inactive) just to avoid merge conflicts with other settings folks are working on.  That should save some potential future rebase pain :).

Also in the interest of minimizing carrying cost for this branch, I went ahead and merged the models and migrations changes, since I think we're pretty happy with those.
I made one small change while merging, though, which is renaming the archived_date fields to archive_timestamp, basically because we're planning to rename pub_date to just timestamp, and I think this will be more symmetric.
So when you next rebase:

You can drop your frontend changes commit entirely
You'll need to deal with the merge conflicts from models.py changes.

Thanks @kkanahin!  I hope this will help make life easier as we continue to get this working just how we want it to :).

@timabbott I've updated this PR. Could you please review it. I went through all commits and split archiving by realm. Had a lot of problems with applying changes for each commit and I hope it is what you need. Also, I've improved all queries.

I've checked queries performance too on more than 100000 rows, and it was good enough about 2 seconds per query. I've used 'hdd' for database.

Cool.  @kkanahin can you do a rebase of this?  I think I'm ready to merge the first several commits once that's done.  I think the merge conflicts result from b2504084ab306c0443b782a0c4e273367917f0ae.

@timabbott, I've rebased this PR.

Now that we've merged the message deletion commit, can you rebase this to integrate with those changes @kkanahin?  Thanks!

@timabbott sure

@timabbott rebased

This PR is mostly complete, but hasn't been integrated due to insufficient time for careful testing.  It wouldn't be hard to pick up.

Closing in favor of the current version https://github.com/zulip/zulip/pull/12356.


Accessing Schema Registry URL using Docker

Any documentation about this?

Can we add the SCHEMA_REGISTRY_URL as docker environment variable?

Closing this.
Used https://hub.docker.com/r/afaltisk/kafdrop.
  ...
  kafdrop:
    image: afaltisk/kafdrop:latest
    restart: always
    depends_on:
      - zookeeper
      - confluent-schema-registry
    environment:
      ZK_HOSTS: zookeeper:2181
      SCHEMA_REGISTRY: http://confluent-schema-registry:8085
      MSG_FORMAT: DEFAULT
      LISTEN: 9000
    ports:
      - 9000:9000
  ...


Error.

What is the output link of /viaversion dump?
1.11 dev latest.
EDIT (by @Matsv): http://hastebin.com/deqafukohi.json
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Nop.
How does this error happen? login? Using an item?
Don't know, maybe a firework.
Is there an error in the console? Use pastebin.com. Is there a kick message?
http://hastebin.com/erufupesuq.md

Could you follow the issue template and use /ViaVersion dump?

http://hastebin.com/deqafukohi.json

And this does not happen using the latest official spigot build?

The latest spigot build or the latest Via Version Stable Build ?

Latest Spigot build, so this one: https://www.spigotmc.org/resources/viaversion.19254/download?version=111056

I'm only using dev version because I want to allow my players to connect on 1.11, but before in 9.9 I hadn't got this error.

I'm unable to reproduce it, could you debug it? Remove plugins until it no longer happens.

I don't know, the error happens only sometimes.

This error is caused by having the wrong version of LibsDisguises:
It fails to make the right datawatcher for a firework disguise?
java.lang.IllegalArgumentException
[20:56:33] [Server thread/WARN]: 	at sun.reflect.GeneratedConstructorAccessor327.newInstance(Unknown Source)
[20:56:33] [Server thread/WARN]: 	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
[20:56:33] [Server thread/WARN]: 	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
[20:56:33] [Server thread/WARN]: 	at com.comphenix.protocol.reflect.accessors.DefaultConstrutorAccessor.invoke(DefaultConstrutorAccessor.java:16)
[20:56:33] [Server thread/WARN]: 	at com.comphenix.protocol.wrappers.WrappedWatchableObject.newHandle(WrappedWatchableObject.java:83)
[20:56:33] [Server thread/WARN]: 	at com.comphenix.protocol.wrappers.WrappedWatchableObject.<init>(WrappedWatchableObject.java:62)
[20:56:33] [Server thread/WARN]: 	at me.libraryaddict.disguise.disguisetypes.FlagWatcher.convert(FlagWatcher.java:112)

Then causes ViaVersion to implode as it's not too sure what the metadata is as it fails to make it.


We are building a RESTful-API based on your datascraper :-)

Thanks for this great project!
In the course of the hackathon "https://wirvsvirushackathon.org/ " we are implementing a RESTful web service that uses the scrapper to provide the data. We have developed a landing page to make it easier for many interested people to implement a scraper or/and use our API
check it out:
https://corona-api-landingpage.netlify.com/

Thank you very much!  We have just created a list of consumers in a google spreadsheet , you're the very first entry.  I'll update the list as others let us know.
Cheers and best wishes from our team to yours.


kubectl logs errors

I have not built my image, just copyed / pasted the "Deploy" section of the readme.
kubectl version

Client Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.2", GitCommit:"528f879e7d3790ea4287687ef0ab3f2a01cc2718", GitTreeState:"clean"}
Server Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.2", GitCommit:"528f879e7d3790ea4287687ef0ab3f2a01cc2718", GitTreeState:"clean"}

Everything ok untill:
kubectl get svc,rc,pods

NAME                      CLUSTER-IP   EXTERNAL-IP        PORT(S)    AGE
elasticsearch             <IP_ADDRESS>                      9200/TCP   20m
elasticsearch-discovery   <IP_ADDRESS>                 9300/TCP   20m
kubernetes                <IP_ADDRESS>                  443/TCP    11d
NAME                      DESIRED      CURRENT            AGE
es-client                 1            1                  18m
es-data                   1            1                  18m
es-master                 1            1                  20m
NAME                      READY        STATUS             RESTARTS   AGE
es-client-yduhr           1/1          Running            0          18m
es-data-950tk             1/1          Running            0          18m
es-master-h0ble           1/1          Running            0          20m
k8s-etcd-<IP_ADDRESS>        0/1          CrashLoopBackOff   9          11d
k8s-master-<IP_ADDRESS>      4/4          Running            2          47m
k8s-proxy-<IP_ADDRESS>       1/1          Running            0          46m

But kubectl logs es-master-h0ble (attached its output) has some errors.
What could I do?
kubectl_logs.txt

This happens because you don't have DNS properly configured on your Kubernetes cluster.


Update Composer dependencies (2020-11-27-00-03)

Visual regression test passed!
View the visual regression test report


All Python files have references to labman schema changed

All Python files have references to labman schema changed to
'labcontrol'. Consideration needs to be given to ensure existing
installations get their schemas renamed to 'labcontrol' before
unittests, etc. are run. Ensure 'labcontrol patch' is run at the right
time for new and existing users.
Test PR + run through Travis - confirm breakage due to populate being unchanged.

This PR touches a lot of files, but for the most part, the changes are simple.

Seems fine

Seems fine

@wasade Want to officially approve it, and merge, then?

Talked to @wasade. Going ahead with merging.


Question: How to troubleshoot ResizeObserver loop limit exceeded

   [2020-03-19T03:25:47.882Z] [INFO] [VIEWER] All ICE candidates have been generated
   [2020-03-19T03:25:47.882Z] [INFO] [VIEWER] Sending SDP offer
   [2020-03-19T03:25:48.678Z] [INFO] [VIEWER] Received SDP answer
   [2020-03-19T03:25:48.711Z] [INFO] [VIEWER] Received ICE candidate
   [2020-03-19T03:25:48.720Z] [INFO] [VIEWER] Received remote track
   [2020-03-19T03:25:48.721Z] [INFO] [VIEWER] Received remote track
   [2020-03-19T03:25:48.932Z] [INFO] [VIEWER] Received ICE candidate
   [2020-03-19T03:25:59.694Z] [ERROR] ResizeObserver loop limit exceeded
   [2020-03-19T03:26:22.587Z] [ERROR] ResizeObserver loop limit exceeded
   [2020-03-19T03:35:48.934Z] [INFO] [VIEWER] Disconnected from signaling channel
   [2020-03-19T05:54:17.626Z] [ERROR] ResizeObserver loop limit exceeded
   [2020-03-19T05:54:41.482Z] [ERROR] ResizeObserver loop limit exceeded
   [2020-03-19T06:16:16.207Z] [ERROR] ResizeObserver loop limit exceeded
   [2020-03-19T06:16:23.646Z] [ERROR] ResizeObserver loop limit exceeded
   [2020-03-19T08:21:50.392Z] [ERROR] ResizeObserver loop limit exceeded
   [2020-03-19T08:22:05.562Z] [ERROR] ResizeObserver loop limit exceeded

Found it this is more probable without trickle ice

@Sean-Der @disa6302 @zhiyua-git @MushMal
Who is the best contact person?

@MixMasterMitch :)

Sorry for the delay in response. Did you resolve this issue?
Where are the ResizeObserver loop limit exceeded errors originating from?

Due to inactivity, I'll close this. Please feel free to reopen it if you need further assistance.


Key sequences not working

The telnet example implies that keys can be chained with .key(['C-c', 'q']) but the function is instead called when either key is pressed.

@chjj I'll close this as I've found that custom sequences can be added easily enough.


Mouse clicks don't work in address bar, tab close etc

On Win 7, I find that after I have a number of tabs open (~25 or so), mouse clicks dont work in a number of areas:

Address bar
Close button
Tool bar.

This only affects the windows with the large number of tabs, any other window with fewer tabs works fine. Keyboard controls are not affected.
Everything works again if I exit and restart.

With the latest changes to the tabbar I've been experiencing problems as well. Visual glitches when closing tabs and moving tabs as well as the inability to type in the address bar after moving tabs. For me, it didn't seem to matter if I had a large number of tabs open or not. I had to download the latest commit on May 7 to restore proper tab functionality.
Currently running Firefox 67.0 on Linux

I should have stated that I'm using the latest version of the chrome folder, and stilll experiencing these issues.

Hi,
I had the same issue with 66.0.5 (64-Bit) on Windows 10.
Previous commit 1a6061b1017f04678aa988d446ca48c5a8029b1d seems to work correctly as stated by @NICHOLAS85

I only tested it on macOS (68) and a quick test on 67. Changes were mostly to resolve issues on 68. I'll do some more thorough testing later today and see if I can fix this...

Firefox is very finicky about its tab transitions. I pushed it too far in an attempt to implement smoother transitions. These changes have been reverted. I think the regression came from 920837888ff33a179ee7f70f78cd845ce39071d8. Please give the latest commit a go and let me know if you still have the problem.
Only way I could reproduce the problem was to drag a tab so I might be able to re-implement my smoother tab transitions if I use a more specific selector. Will do some experimentation and see how it goes.

Latest commit seems to fix all the previously mentioned issues for me. I'll update if anything begins to act strange.

Thanks for testing. I'll close but feel free to comment if you notice any issues and I'll re-open.


Support networks that fork at 0

Fixes https://github.com/input-output-hk/cardano-db-sync/issues/507
With this pr db-sync supports node configuration like
"TestShelleyHardForkAtEpoch": 0
It also supports initial funds and staking in the Shelley Genesis
When the Shelley Genesis file has some important information, like initial distribution, pools and delegations, an artificial Shelley Genesis Block is inserted and artificial Txs, to attach all the information to it. The genesis blocks have some unique characteristics in the db:

Byron Genesis Block has null EpochNo and null PreviousId
Shelley Genesis Block has null EpochNo and non-null PreviousId

In most cases the Shelley Genesis Block will be the next block of the Byron Genesis block. This means the byron genesis block may have two next blocks.
The Shelley Genesis block is not inserted, if it lacks any important information (funds/staking). So this should not affect mainnet.

Previously, if creating a new testnet via scripts/byron-to-alonzo/mkfiles.sh, cardano-db-sync would fail to start up. Once we switched to the branch, cardano-db-sync successful starts up and runs. However, if cardano-db-sync is shut down and then restarted, the following error appears:
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.52 UTC] NetworkMagic: 31415
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.53 UTC] Initial genesis distribution present and correct
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.53 UTC] Total genesis supply of Ada: 10020.000000
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.53 UTC] Validating Genesis distribution
cardano-db-sync-extended_1   | Error: Shelley.validateGenesisDistribution: Expected initial block to have 1 but got 2

Seems like the issue lies here, https://github.com/input-output-hk/cardano-db-sync/blob/1f96fd8f010c7a117a3c622884abcdc550890735/cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Genesis.hs#L164
where expectedTxCount is off. Looking at the byron genesis file, I see:
  "nonAvvmBalances": {
    "5oP9ib6ym3XYb4bdW1gpkqYpzw939QGkd7xUAYemppCiBiMBQtY4jTfnboPBrZfWkh": "5010000000",
    "5oP9ib6ym3XbF24fvvwzCEhPynWgmMM9d9Z5tDvB7msP133Ria6m58umoomWAuByWr": "5010000000"
  },

so I would have expected 2 to be returned.

Previously, if creating a new testnet via scripts/byron-to-alonzo/mkfiles.sh, cardano-db-sync would fail to start up. Once we switched to the branch, cardano-db-sync successful starts up and runs. However, if cardano-db-sync is shut down and then restarted, the following error appears:
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.52 UTC] NetworkMagic: 31415
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.53 UTC] Initial genesis distribution present and correct
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.53 UTC] Total genesis supply of Ada: 10020.000000
cardano-db-sync-extended_1   | [db-sync-node:Info:6] [2021-08-30 20:18:44.53 UTC] Validating Genesis distribution
cardano-db-sync-extended_1   | Error: Shelley.validateGenesisDistribution: Expected initial block to have 1 but got 2

Thank you for pointing this out. There are indeed some remaining issues with this pr.

@kderme Is this going to be addressed:

There are indeed some remaining issues with this pr.

@savaki the error you get comes from the Shelley genesis and the nonAvvmBalances is from the Byron genesis file. Maybe there is a misconfiguration between the two when you restart db-sync?

Cherry picked the "Support networks that fork at 0" commit into #864 .


Add Chocolatey deployment type

This is to create a deployment type to push chocolatey packages to Chocolatey repos. It can take a single file or push all the nupkgs in a directory.

Awesome!  You caught me at lunch, will try to bring this branch back in line with master; might break a few tests, I'll try to clean them up if so.
Cheers!

Let me know if there's anything I can do to assist or if there's any changes I need to make.

Nothing that I could see, love the idea - thanks for the reminder, got caught up with the summit - have some slides due tonight, will try to get to this by Wednesday or so
Cheers!


Field and utility exports

Added most of our field/utility types and exporting it.

This does not have a build and has 0 runtime impact - only types (like type-fest).
This is why the files are only file.d.ts instead of file.ts and running tsc over it


Better APISpec init to allow to modify it before generating spec_json.

This will make it easier for APISpec to be modified by external functions before generating the spec_json (examples: adding webhooks, registering custom components etc).
Checklist:

[x] Run pytest tests and no failed.
[x] Run ruff check flask_openapi3 tests examples and no failed.
[x] Run mypy flask_openapi3 and no failed.
[x] Run mkdocs serve and no failed.

This PR gave me some inspiration.
I don't quite agree with PR #190's approach, self._register_default_error_responses() only refactored part of the functionality.
You can expose self.generate_spec_json() function on top of this PR to implement spec_json refactoring.
self.generate_spec_json() contains all the remaining logic
@property
def api_doc(self) -> Dict:
    if self.spec_json:
        return self.spec_json

+   self.spec_json = self.generate_spec_json()
+   return self.spec_json

The difference is if you want to modify the whole thing or piece by piece.
Both ways would be best IMO.


UI: Element focus visible through layers on top (only About?)

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Latest master as of this issue
Windows 7 x64, NVIDIA GTX 980 Ti
Issue description:
If you open Help -> About, select one of the cells in the popup window and scroll, the focus border is still visible if the element is scrolled out of view. See attached GIF.
Steps to reproduce:
See description above/GIF below
Link to minimal example project:

Duplicate of #9612.


Multiline records

The app will fail if you have multiline records in the CSV file.
For example, I have a lot of records like this:
581455383,666,,1,11,111111111110,String,"REALIZACIJE DO 12h:
KUKURUZ VESTACKI SUV ROD 2015,
100t, cena 16.1;
SOJA ZRNO MERKANTILNA ROD 2015,
200t, cena 41;
CENE SU BEZ PDV-a",2,2015-10-30 13:40:09.811055,2015-10-30 13:40:06,2015-10-30 13:40:11.651163,2015-10-30 13:40:16.427218,51781933,,85450933,1.10,0000033dba1f0@150b8c3328c,DeliveredToTerminal,,,1

Your app reads CSV file line by line and it is unable to detect multiline records.

Looks like I ran into a similar problem 😿
And recommended method for migration to Timescale is not available for me:
https://docs.timescale.com/latest/getting-started/migrating-data#csv-import

This should now be fixed as of the above commit. If you have the ability to test that out and confirm, that'd be fantastic! (The fix is not yet in a released version, so you'd need to install @HEAD to test the prerelease.) Please reopen if you find any issues.


Coordinates config

What do I need to do in the config to get the coordinates? I couldn't find an explanation on this issue.

thank you i found it


AUC columns for journey purpose tables

Eg A1.3.3a  - the journey purpose column cannot easily be looked up, so should include an AUC column as well

Done in linked commit


ADSBHub sometimes key could not work

I had an issue with feeding ADSBhub. First i realise that just removing the container and starting with new env vars doesn't update the image, so please add in the manual :latest as here:
docker run -d -p 8080:8080 -p 8754:8754 \
	--device=/dev/bus/usb:/dev/bus/usb \
.
.
.
	-e "SERVICE_ENABLE_ADSBHUB=true" \
	-e "ADSBHUB_CKEY=MY_ADSBHUB_SHARING_KEY" \
	--tmpfs /run:exec,size=32M \
	--tmpfs /planefinder/log:exec,size=32M \
	--tmpfs /usr/lib/fr24/public_html/data:size=32M \
	thomx/fr24feed-piaware:latest

Next problem was that mine generated key contains that part:
1..........o88{xA94knz$aRSGnjU+{f3;~3J8$WHM).........
2..........o88{xA94knz+{f3;~3J8).........
After checking the real content of env vars with docker exec -it <container_name> env it was as on 2.
So it always good to check if your key contains "$",  just add new station in ADSBhub and delete that one.

Hi, I'll see what we can do to escape special chars, it's always a burden to plays with that kind of issue.
About docker image tag, sorry I won't explain that in the doc, this is very basic docker stuff and you should rather get familiar on how docker tags are working on their doc.

Did you try to pass the environment variable with simple quote?
-e 'ADSBHUB_CKEY=MY_ADSBHUB_SHARING_KEY'
If you don't, bash/zsh etc. will substitute the $xxx with the variable value.

In fact i was tried simple quote few days back, because had space in some env, but now i did just copy/paste, so no.
As i don't want to open another issue is it will be good to mention here my observation on message rate of dump1090 WebUI? Saw more than twice increased rate, after enabling Radarbox, no matter with or without MLAT. Ususally i have 500msg/s in both dump1090 and tar1090, wich is fed by dump1090, but now when i start Radarbox feeding, at same conditions i get 1300mes/s and this is only in dump1090. On tar1090 and graph1090 rate is my normal 500mes/s. What can cause this and what i could do to fix it or diagnose it, as looking on the logs dosn't help me alot on that.

I'm sorry I won't be any help on that.
My one cent, it doubles the rate because there is another connection done by Radarbox or something like that.


Numberless mode

replaces all numbers greater than 1 with "Several"
adds a new experimental setting (default false) for this behavior

A quick audit tells me that shortenNumber is consistently used everywhere I would want to change, so I cut out the middleman and did it there.
Genuinely unsure if this is the best way to load a setting within a non-component context. Will gladly change if needed. Nearly immediately after opening this PR I realized the (likely) correct way. Let me know if I'm still off-base.

In my testing, I've spotted a couple places where some metrics are still visible with this option enabled:

https://github.com/cheeaun/phanpy/blob/main/src/components/account-block.jsx#L196-L204 (shows how many followers an account has)
Some places in the profile page where counts are shown in title attributes:

https://github.com/cheeaun/phanpy/blob/main/src/components/account-info.jsx#L729
https://github.com/cheeaun/phanpy/blob/main/src/components/account-info.jsx#L753
https://github.com/cheeaun/phanpy/blob/main/src/components/account-info.jsx#L770

woo thank you jae. excited for this to merge it literally solves all my problems

Just a note, faving or unfaving a post currently animates in a "1" before hiding it on your deployment.

Used this a bit in my fork and seems to be working fine! 🤩
Text doesn't seem to be updated everywhere like it is when Cloak mode is activated though, I wonder what's the reason for that...

2 notes:

Returning Several from shortenNumber is kinda hacky 😬

i18n gets a little tricky though not entirely impossible
Thinking about this, might as well "cloak" all numbers? (There's Cloak mode in Phanpy which hides text, useful for taking screenshots)

For some reason, the recent commits seems co-authored, became part of this PR, and the changes are not specific to this feature.

Returning Several from shortenNumber is kinda hacky 😬
unbelievably hacky! no question there. the use of "several" is a joke relating back to how we handed numbers on cohost.

Thinking about this, might as well "cloak" all numbers? (There's Cloak mode in Phanpy which hides text, useful for taking screenshots)
this is almost certainly the better way to go. I can look into switching to this

For some reason, the recent commits seems co-authored, became part of this PR, and the changes are not specific to this feature.
git fail on my part; tried to rebase main on and goofed it. will resolve that one


fix typo, default to scss to prevent pleeease error on initial build

Hey @bdadam, after getting started with your static site boilerplate and loving it, I noticed 2 quick cosmetic changes to help another user get running faster:

typo in README (--dev different from dev)
swapped default grunt task from less to sass. pleeease was giving an error, I suppose because less file was empty? I saw you already had content in the scss file so I swapped tasks!

Running "less:main" (less) task
>> 1 stylesheet created.

Running "pleeease:dist" (pleeease) task
>> Error: CSS string or CSS AST data was not provided to pleeease.process()
Warning:  Use --force to continue.

Aborted due to warnings.

Thanks for the awesome repo :)

Hey @emazurek, thanks for your changes and kind words. I am glad you find this boilerplate valuable.
Your PR just reminded me to review this repo and provide some updates. Stay tuned... :)


[docs] Use preload to load google fonts

[✅] I have followed (at least) the PR section of the contributing guide.

https://github.com/mui-org/material-ui/pull/15758 method in this PR doesn't work any more.

Let's take material-ui/examples/nextjs-with-typescript/ as an example.
After npm run build & npm start, test the app in Incognito mode with lighthouse. The report states Eliminate render-blocking resources: /css?family=Roboto:300,400,500,700&display=swap(fonts.googleapis.com)
Then userel="preload" as="font" and run the above process again, this suggestion is gone.
Please check in your machine.
@eps1lon

But this is currently filed under "passed audits" with a summary of "potential savings: 0ms".
Could you download the created report via html and share it?

Some of the impacts of the change can be seen in https://www.webpagetest.org/video/compare.php?tests=191102_5H_8798bd5b971e02a36446f666cae91c53,191102_9X_232fd08cdc671329e253b290171cd7c0 (real device test x1 run)

The official documentation still lists : https://developers.google.com/fonts/docs/getting_started

+1 for following the Google's recommendations

Some of the impacts of the change can be seen in this webpagetest run (it's a real device test, but has only one run warning).

Again this isn't helpful at all. Data that isn't analyzed is meaningless and subject to misinterpretation.

why is the payload different (html and js)
how would you judge a page that has a faster first paint but delayed fonts (seen by the fact the both branches are visually complete at the same time while master is faster at 85% or 95%)
PR doesn't even have time to interactive timing listed
you are comparing to material-ui.com while claiming this is master

@eps1lon Sure, we can go in the analysis of the webpagetest run. But before we go into it, I would like to raise that the custom material font is no longer loaded (so I don't think that we can accept the changes). I could only find two interesting insights:

Not waiting for a custom font increase the time to first meaningful paint to about ~0.9s. This gives an order of magnitude of the value of the change to display=swap, vs the time to interaction round 6s 👌.
We miss the 180 px icons, I will add it in the next batch effort (404).

I have doubt checked, the custom font doesn't load anymore: https://deploy-preview-18151--material-ui.netlify.com/. @ithinco Thank you for spending time on this problem. However, we think that we should stick to Google's recommendation and what https://fonts.google.com/ documents.


can't bundle with Webpack 4

After trying to upgrade from webpack 1 to 4 with babel 7, I can't run my application. I'm getting formatLocal is no a function, when I try to use the package as I used to.
after browsing the source files loaded to chrome, I see that phone-format-exports.js but I feels like webpack can't match phoneformat.js import to phone-format-exports.js file.
Did anyone succeed in running phoneformat.js on modern bundle systems?
Thanks!

I am working on a Meteor project that uses this package on the client and I'm getting a similar error using v1.0.7.
When rolling back to v.1.0.6 it works again.


WIP Local notification

Closes #27
Changes:

[x] Create a local notification channel (in main)
[x] Request permission to send notification (in main)
[x] Set a notification action stream listener (in home)
[x] Create a notification for unfinished torrents whenever the torrent list is updated (in home)
[ ] Add functionality to start / stop torrents from background
[ ] Create a notification for each finished torrent
[ ] Custom dialog box for request permissions

Screenshots:

Isolate might work but it would be a workaround at best. Let's look into some concrete solution.

Alright. I'll try and find a different approach.


Getting User Out of Office Settings

Allow me to preface this issue with the fact that I am not having any trouble retrieving user availability utilizing the example provided from the Wiki. The environment is currently an apache webserver running curl 7.28.1.
I am having some trouble using the EWSType_GetUserOofSettingsRequest the request appears to work properly, however all I am able to get back is:
stdClass Object
(
[ResponseMessage] => stdClass Object
(
[MessageText] => Connection did not succeed. Try again later.
[ResponseCode] => ErrorConnectionFailed
[DescriptiveLinkKey] => 0
[ResponseClass] => Error
)
)
There are no errors on the console and I know that the user currently has an OOF response setup.  Is there anyway to debug this issue further?

This issue is over three years old. If you are still having trouble with the latest version from master, please open a new issue.


Fix panic in verifyOldVolumesInfo

Signed-off-by: Lei Jitang<EMAIL_ADDRESS>Fixes #13435

ping @duglin can you have a look at this?

Looks like volumes refactor breaks something, this fix seems like a work around, not sure if it'll break something. Should ping volumes refactor guys to take a look. @crosbymichael @icecrime @calavera
And we should reference https://github.com/docker/docker/issues/13420
BTW, if you want to move registerMountPoints before verifyOldVolumesInfo, should also get rid of registerMountPoints in setHostConfig.

The reason why this panic happend is that volumes refactor introduce a new parameter MountPoints to container config file and the container created by previous docker didn't have this parameter. So the painic happened when verifyOldVolumesInfo  creates MountPoints for the old volumes.
@hqhq  I think there is no need to get rid of registerMountPoints in setHostConfig because  setHostConfig is to designed to call on container creation, it was called on container start just for backward compatibility.

Thanks for your explain, I didn't look in deep, but I understand it's a backward compatibility problem, if so, maybe @ibuildthecloud 's work around in https://github.com/docker/docker/issues/13435#issuecomment-104982260 is good enough?
Because to me, registerMountPoints in daemon.Registrer and daemon.setHostConfig use exactly the same parameters, seems strange to me, do you know when they'll be different?
And since registerMountPoints deals with hostConfig, it is reasonable to put it in setHostConfig, if we can change the sequence, maybe just put setHostConfig before daemon.Register? Not sure if that'll cause problems, not dig yet.

Update the fix. since verifyOldVolumesInfo is to create MountPoints for the old volumes, so we should only allocate memory for MountPoints when the container is created by previous docker and the volumes is not nil.  I think the problem of  https://github.com/docker/docker/issues/13435#issuecomment-104982260  is it doesn't make sense to allocate memory for each container because not  all the containers has volumes.

Yeah, this makes more sense, thanks.

How much memory does a empty map take?  Seems more straight forward to just always create an empty one, then any code that references MountPoints need not check for nil.  It is public, so initializing on demand seems fragile.

The patch in https://github.com/coolljt0725/docker/blob/fix_panic_in_verifyoldvolumesinfo/daemon/daemon.go#L543 is the right thing to do.

What I think is verifyOldVolumesInfo is just for those containers which was created by previous docker to create MountPoints for the old volumes for the first time load by latest docker.  If the containers are created by the latest docker or those containers created by previous docker has load by the latest docker, https://github.com/coolljt0725/docker/blob/fix_panic_in_verifyoldvolumesinfo/daemon/daemon.go#L168 will initialize container struct.  So I think there is no need to initialize in https://github.com/docker/docker/issues/13435#issuecomment-104982260

@coolljt0725 every line of code that deals with mount points assumes that the structure has been initialized. The change with less impact to accomplish that is to initialize the mount points when the container struct is initialized. Please, make that change, this PR as it is does NOT LGTM.

@calavera I just put in https://github.com/docker/docker/pull/13471 which is just the original patch I had in my comment.

@calavera  I see. Since @ibuildthecloud  has post the PR.I'm going to close this


v0.2 on nuget?

Any chance that could get uploaded, so we don't have to keep the source code in a project?

Uploaded! Sorry for the delay.

Thanks!


Document using ByteBuffer.slice() for wrappedBuffer()

Expand javadoc to note that .slice() should be called to have Slice respect the position and limit.

No longer relevant after the API was changed to wrap the visible portion.


Create HeaderLinkedList.cpp

Fix #6 Fix #97

@iosdev747 See my request on your other pull requests and change this pull request as well.


Add config file for CLI.java

Currently, all information for CLI.java comes from class constants. However, some of it, like the colors, would be nicer to be in a user-changeable config file.

I have recently learned about java.util.Properties. This seems perfect for the CLI's config.


[WIP] Adding contextual (constraint) keyword 'unmanaged'

Summary
I've added the unmanaged keyword under the contextual constraints section in the keywords list. Now I've started to work on the documentation for this keyword. I know it's a constraint on type parameters.
I'm just looking for some examples or helpful links that would help me develop the documentation for this keyword. I'm also wondering how this word relates to 'unsafe' keyword?
Fixes #8673  (if available)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: harisriaz17 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@harisriaz17 the current bits of docs about unmanaged constraint might help you:
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/where-generic-type-constraint
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/generics/constraints-on-type-parameters#unmanaged-constraint

@BillWagner, could you provide some guidance to @harisriaz17 as he begins work on this new topic?

Thanks for volunteering to create this content @harisriaz17 We really appreciate it. In addition to the references @pkulikov provided, the speclet for the feature on the dotnet/csharplang repo provides more details.  The new article should include the following information:

An example of the syntax. Include that unmanaged is incompatible with class and implies struct.
Definition for "unmanaged" types (from the speclet)
A brief justification for the feature (also in the speclet.
Links to generic class & method in the language spec.
links to the where generic constraint page.

So it's been a long while (sorry for the delay) but I'm back to working on this PR. I've added plenty of new content to the documentation of this spec, and I think I'm nearly done, just deciding on the structure of the content.
@BillWagner in reference to your previous comment above, could you elaborate more on points 4 and 5?
In point 4, do you want me to update the unmanaged constraint spec with links to its generic implementation?.
Also with regards to the where generic constraint page in point 5, I'm not sure whether to place a link to it in unmanaged-constraint.md file or in the language spec for unmanaged constraint.......so please elaborate on that.

@harisriaz17
For the generic types and methods link, I'd use this anchor which would translate into ~/_csharplang/spec/types.md#constructed-types.
For the where link, I'd use csharp/language-reference/keywords/where-generic-type-constraint.md
Ping me again if you have further questions.

I'm closing this due to lack of response.  @harisriaz17 If you pick this up again, you can open a new PR or re-open this one.


B Team Arm Modes

switch current "set power" subsystems to using preset modes

This has been merged to main, any follow on work will be done in another issue


Advanced currying implementation

Need to add an option to advanced currying implementation

@vyasriday Can I work on this issue?

Sure @aman-agrwl Please see the currying code available at  https://github.com/vyasriday/JS-Tidbits/blob/master/src/concepts/currying.js before adding new content


Fix gendeps

cc @jzila not sure what changed caused this but ci is breaking, going to merge

@joshblum which CI builds are broken? I don't see any broken builds on master.

@jzila i didn't see anything broken on master either which is why i was confused, initially i saw red here: https://ci.keyba.se/job/client/job/PR-15990/1/execution/node/328/log/

There is definitely something wrong with this PR here--I don't think you should have merged this without letting Jenkins finish first. We might need to debug the script.


may need to warn the users to use positive and negative benchmarks before the actual run of the analysis

At least for now I think you can just make this clear in the readme/ vignette


[Pickup city User profile]  User agreement displays incorrect in the footer

Environment: Windows 11 Pro Version 10.0.22631 Google Chrome Version 124.0.6367.119 (Official Build) (64-bit)
Reproducible: always
Preconditions
Go to the link https://www.pick-up.city/#/ubs.
The User is logged in.
Steps to reproduce

Click on the hamburger menu > "My profile" link.
Look at the footer's list items

Actual result
It is displaying "user.lower-nav-bar.user-agreement" instead of "User agreement"

Expected result
It should displays just "User agreement"

Does not reproduce:


sysctl: error: 'net.ipv6.conf.all.forwarding' is an unknown key

I don't think our enabling of "net.ipv6.conf.all.forwarding" is actually helping anyone with anything ATM: (this is from the boot logs)
sysctl: error: 'net.ipv6.conf.all.forwarding' is an unknown key

I don't think this actually applies anymore. :+1: :innocent:

@tianon actually it does ;(

This is using 1.12.5
Seems to be caused by the ipv6 module not being loaded at the moment sysctl is called.
When logging in to the TTY after startup issuing /etc/rc.d/sysctl (or sysctl -p /etc/sysctl.conf directly) does work, because at that time the ipv6 module is loaded, through the following dependency chain:
br_netfilter -> bridge -> ipv6
br_netfilter actually gets loaded because of the default bridge network included with docker, through libnetwork.
I guess we have 3 options:

Disable IPv6, though that's probably not an option because there will probably be people who use boot2docker with IPv6
Make IPv6 a kernel builtin instead of a module
Add an explicit modprobe ipv6 in bootsync.sh before /etc/rc.d/sysctl gets called
Since forwarding is a global option (see the kernel's docs under conf/all/forwarding) changing it will always apply to all interfaces. So we can set it later by calling /etc/rc.d/sysctl after the docker daemon has started/the bridge network has been created and it's setting will still apply to all interfaces.

The last one seems the most logical one to me, unless there's a specific reason /etc/rc.d/sysctl gets called as the first item in bootsync.sh.
This is the result from a quick test with modprobe ipv6 to the top of bootsync.sh, works as it should :)
(disregard the dhcp.sh not found error, that's caused by a fix for something else, I'll create an issue for it as well.


Obsolete README

The current README suggests using python2.7 interpreter in the virtual enviroment to run roadmap tools (line 50 and a few more below), which is not possible anymore, in fact even python3.5 probably can't be used due to variable annotations which were introduced in python3.6.

fixed in master


Behaviour driven development

(related to #14 and #21 )
It seems like it would be a good idea, but needs some enthusiasm from all parties involved, developers and analysts/stakeholders.
If developers are willing to aid analysts in writing correctly formatted specifications in the dialect of the chosen BDD, and implement these, and equally the analysts are willing to learn and keep to the newly learned BDD dialect, then it could increase our overall efficiency, as well as create clarity to the proceedings.

Speaking for the "analysts" I'm completely in favour and willing to adapt to whatever dialect we choose. I have experience of Cucumber.

Action before closing: add BDD for release 1.


Map Activity retrieves code locations

Map currently displays hardcoded geolocations, not actual locations of codes

The staging branch currently does retrieve QRCode locations. I think this issue should have been closed in the last commit to staging but was left open by mistake.