refactor: table selector on dataset editor

SUMMARY

refactor TableSelector to DatabaseSelector
refactor typescript and use hooks

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #10914 into master will decrease coverage by 4.34%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##           master   #10914      +/-   ##
==========================================
- Coverage   65.88%   61.53%   -4.35%
==========================================
  Files         815      816       +1
  Lines       38337    38406      +69
  Branches     3601     3627      +26
==========================================
- Hits        25257    23633    -1624
- Misses      12978    14587    +1609
- Partials      102      186      +84

Flag
Coverage Δ

#cypress
?

#javascript
61.98% <80.76%> (+0.22%)
:arrow_up:

#python
61.27% <ø> (-0.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...erset-frontend/src/datasource/DatasourceEditor.jsx
64.22% <56.25%> (-8.84%)
:arrow_down:

superset-frontend/src/components/TableSelector.tsx
83.18% <83.18%> (ø)

...erset-frontend/src/components/DatabaseSelector.tsx
86.36% <86.36%> (ø)

...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx
57.57% <100.00%> (ø)

superset-frontend/src/SqlLab/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/setup/setupColors.js
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141ef4a...8c668ee. Read the comment docs.

Oh one thought is that we may need for the virtual dataset name to be editable some place.

I'm getting double scroll bars (overlaying on top of each other) when SQL Queries are long.
@lilykuang @nytai could you get this fixed?
I'd recommend using this CSS trick to let the SQL editor fill remaining vertical space:
https://stackoverflow.com/questions/25098042/fill-remaining-vertical-space-with-css-using-displayflex

@ktmud Nice catch. I will fix this.


Opportunistically use Yajl for json encoding

Replace #to_json with a faster Yajl implementation, when Yajl is present.
Also, this fixes the JSON::GeneratorError error: "source sequence is
illegal/malformed utf-8", which happens when source hashes do not have
correct encoding.  In particular, this affects emsearcy/fluent-plugin-gelf,
which may have strings coming in with improper encoding, becuase fluentd
treats all logs as ASCII-8BIT (see fluent/fluentd#215).
There are other opportunities for performance improvements with Yajl, like
using its stream processing to write to the sockets as it syncronously
encodes and/or compresses, but I've ignored those for now as they would
require architectural changes to gelf-rb.

I can confirm that applying this patch and installing Yajl  fixes the mismatching Encoding issues
So, please merge this patch and release a new gem version for everyone to easily fix!
Thanks

When will this be released? Need it for fluentd

@milgner @tessie ⬆

Any update on getting this released now that it is merged? Thanks.


I want to separate responsibility of Cast from Entity.

The current Entity class has the responsibility of Cast.
But, I would like to separate the responsibilities of Cast from Entity.
That is because Cast is highly likely to be used in various places and Entity and responsibility range are different.
The improvement approach is done in the following procedure.

Create a Caster class.
Implement casting of Entity class in Caster class.
Make the Entity class depend on the Caster class.
Delete cast process of Entity class.

Does CodeIgniter want such a PR?
https://github.com/bcit-ci/CodeIgniter4/blob/b840d0a6d307df4da956561b599e443e467195d6/system/Entity.php

Not sure this is needed. The response can already be served as either JSON or XML. This as a cast was only put in as a convenience to format it when it comes out of the database. And I allowed the PR on that because I've read json encoding is safer than PHP's serialize when it comes to storing stuff in the database.
Almost all of the conversions are simple things that PHP provides the ability do already.

I understand.
Thank you reply.


Load Balancer not creating after deleting

What happened?

I am trying to create a load balancer (ELB) using managed resource. The load balancer got created, but after deleting from the AWS Console, it is not creating again. The READY and SYNCED status remain true in the shell. Similarly, during a service deployment I have a load balancer created, but facing the same issue there also. Deleting the load balancer which got created during the service from the AWS Console is not creating again.
Load Balancer Script
apiVersion: elb.aws.upbound.io/v1beta1 kind: ELB metadata:   name: lb-03042023 spec:   forProvider:     availabilityZones:       - us-east-1b     listener:       - instancePort: 8000         instanceProtocol: http         lbPort: 80         lbProtocol: http     region: us-east-1   providerConfigRef:     name: default

Service Script
apiVersion: v1 kind: Service metadata:   name: nginx-loadbalancer-api spec:   type: LoadBalancer   selector:     app: nginxwebapp   ports:     - protocol: TCP       port: 80       targetPort: 80
How can we reproduce it?

Create a service file or a managed resource file for an ELB.
Apply the file and verify under load balancers if the resource is created.
Delete the same from the Console and wait for some time.
Verify again if the resource is getting created.

What environment did it happen in?

Universal Crossplane Version: v1.1.11
Provider Version: xpkg.upbound.io/upbound/provider-aws:v0.21.0
OS: Linux
Kubernetes Version: v1.24

The issue is reproducible on the latest master, using Load Balancer Script:
apiVersion: elb.aws.upbound.io/v1beta1
kind: ELB
metadata:
  name: examplesvetatesting
spec:
  forProvider:
    availabilityZones:
      - us-west-1b
    listener:
      - instancePort: 8000
        instanceProtocol: http
        lbPort: 80
        lbProtocol: http
    region: us-west-1

output with error:
 - lastTransitionTime: "2023-04-19T20:09:20Z"
    reason: Creating
    status: "False"
    type: Ready
  - lastTransitionTime: "2023-04-19T19:58:33Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2023-04-19T20:10:02Z"
    message: "apply failed: creating ELB Classic Load Balancer (examplesvetatesting):
      ValidationError: Only one of SubnetIds or AvailabilityZones may be specified\n\tstatus
      code: 400, request id: cbc9d9f6-61c3-47d3-841c-6f64cca7d3fd: "
    reason: ApplyFailure
    status: "False"
    type: LastAsyncOperation
  - lastTransitionTime: "2023-04-19T20:10:02Z"
    reason: Finished
    status: "True"
    type: AsyncOperation


React Challenge shouldComponentUpdate

Challenge Name
React Optimize Re-Renders with shouldComponentUpdate
Issue Description
It seems submitted code true but there is a problem in last two tests resulting regular expression errors.
Problem 1 async last part, assert
Problem 2 async last part, assert
Browser Information

Browser Name, Version: Opera 49.0.2725.64
Operating System: Ubuntu 16.04
Mobile, Desktop, or Tablet: Desktop

Your Code
class OnlyEvens extends React.Component {
  constructor(props) {
    super(props);
  }
  shouldComponentUpdate(nextProps, nextState) {
    console.log('Should I update?');
     // change code below this line
    return !(nextProps['value'] % 2);
     // change code above this line
  }
  componentWillReceiveProps(nextProps) {
    console.log('Receiving new props...');
  }
  componentDidUpdate() {
    console.log('Component re-rendered.');
  }
  render() {
    return
{this.props.value}

  }
};

class Controller extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      value: 0
    };
    this.addValue = this.addValue.bind(this);
  }
  addValue() {
    this.setState({
      value: this.state.value + 1
    });
  }
  render() {
    return (

        <button onClick={this.addValue}>Add</button>
        <OnlyEvens value={this.state.value}/>

    );
  }
};

Screenshot

Thanks @SanD94 for raising this issue.
We need the two tests pointed out by @SanD94 fixed. They are currently malformed. This is just a syntax issue.

@Bouncey I think this and the other issues, like you said, should be simple syntax fixes. These were working when we first ported them over, but I think some of Berkeley's syntax changes (or my attempts to fix some of the formatting issues as a result of these changes), are responsible.
This may be the base with any async test that has regexp, so maybe whoever takes on this issue can also run a quick search through the JSON for any async tests that have regexp to hopefully catch any remaining issues.

@no-stack-dub-sack Searching may not be needed because I solved all the challenges for React and found all issues related to async tests.

I'll take a stab at this bug and then will create another issue addressing the tests with async.

It was a very simple bug to fix. Please see my PR above. @SanD94 do the regex errors still persist for async tests in React challenges?

@StephenMayeux I don't know how to test your code unless it is merged with staging branch but it seems to solve this issue. You had better check other similar issues regarding react.js tests ( #16314, #16316) so that all of the problems with tests are solved.

Shall I create different PRs for those other issues, or just wrap them up
into this PR?
sm
On Wed, Dec 27, 2017 at 3:43 PM, Safa Andaç<EMAIL_ADDRESS>wrote:

@StephenMayeux https://github.com/stephenmayeux I don't know how to
test your code unless it is merged with staging branch but it seems to
solve this issue. You had better check other similar issues regarding
react.js tests ( #16314
https://github.com/freeCodeCamp/freeCodeCamp/issues/16314, #16316
https://github.com/freeCodeCamp/freeCodeCamp/issues/16316) so that all
of the problems with tests are solved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/16312#issuecomment-354181696,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM6JOUliEuraWXqdsQ4E5Fk-0-L9R5jXks5tEroKgaJpZM4RL4P9
.

You can wrap them up because of their simplicity.

@StephenMayeux I see what you did now, and I have no idea how this even happened, clearly we didn't write the tests that way, was probably a result of a regex find and replace when the async assertion syntax was updated. But I agree with @SanD94, feel free to wrap these up in one PR.
@SanD94 you can always pull down someone else's branch to test their changes using these instructions found on the PR (they're instructions for merging via the command line, but the first couple of commands are just for checking out and testing:

in this case:
git checkout -b StephenMayeux-fix/16312-React-Challenge-shouldComponentUpdate staging
git pull https://github.com/StephenMayeux/freeCodeCamp.git fix/16312-React-Challenge-shouldComponentUpdate

Also, @SanD94 you said you completed the entire react section, and these are the only problems you found? If so, that's good to know, we have not gone through them since these changes were made and I was wondering if any other problems would turn up. Did you also complete Redux and React-Redux, or just React? Thanks!

@no-stack-dub-sack  I did complete what you all mentioned. However, I didn't check the tests when sending wrong code which would give the expected error. I just know that when sending correct answers, tests accept them. Do we need something for each test to raise error?
By the way, thanks for the information, I'll do it when I have time :)

@SanD94 Sounds good. I'll wrap this one up today. Thank you!


Host: Unknown Message Error: ClientAuthorityMessage

Describe the bug
When host player calls AssignClientAuthority or RemoveClientAuthority on a scene object to change authority to its own NetworkClient.connection it shows the following error after calling OnStopAuthority / OnStartAuthority, respectively:
Unknown message ID 36743 connId:0
UnityEngine.Debug:LogError(Object)
Mirror.NetworkConnection:InvokeHandler(Int32, NetworkReader) (at Assets/Mirror/Runtime/NetworkConnection.cs:324)
Mirror.NetworkConnection:TransportReceive(ArraySegment`1) (at Assets/Mirror/Runtime/NetworkConnection.cs:362)
Mirror.ULocalConnectionToServer:SendBytes(Byte[], Int32) (at Assets/Mirror/Runtime/LocalConnections.cs:43)
Mirror.NetworkConnection:Send(ClientAuthorityMessage, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:243)
Mirror.NetworkIdentity:AssignClientAuthority(NetworkConnection) (at Assets/Mirror/Runtime/NetworkIdentity.cs:1163)
AuthorityTest.SceneObject:OnMouseDown() (at Assets/AuthorityTest/SceneObject.cs:21)
UnityEngine.SendMouseEvents:DoSendMouseEvents(Int32)

Repro project
AuthorityTest.zip
To Reproduce
Steps to reproduce the behavior:

New project, import Mirror and the attached Unity package, restart Unity
Add AuthorityTest scene to Build Settings
Open AuthorityTest scene and play as LAN Host
BUG: Click the cube and see the console errors
Build and Run as LAN Host, Play in editor as LAN Client
Click the cube in the editor client and see there's no error, just the appropriate warnings I added in SceneObject.cs

Expected behavior
Should not have an error.
Screenshots

Desktop (please complete the following information):

OS: Windows
Build target: standalone
Unity version: 2018.4.9
Mirror branch: master

Additional context
Debug logging shows the ClientAuthorityMessage is registered, is not unregistered, and it's only the Host that has this issue...normal clients are fine.  In all cases the authority is correctly assigned / removed as expected.

The bug is in the example.   Instead of this:
 void OnMouseDown()
        {
            NetworkConnection conn = NetworkClient.connection;

            NetworkConnection owner = null;
            if (isServer)
                owner = GetComponent<NetworkIdentity>().clientAuthorityOwner;

            if (!hasAuthority && isClientOnly)
                conn.identity.GetComponent<Player>().CmdAssignClientAuthority(gameObject);
            else if (hasAuthority && isClientOnly)
                CmdRemoveClientAuthority(gameObject);
            else if (isServer && hasAuthority && owner == null)
                GetComponent<NetworkIdentity>().AssignClientAuthority(conn);
            else if (isServer && !hasAuthority && owner == conn)
                GetComponent<NetworkIdentity>().RemoveClientAuthority(conn);
        }

It should be this:
 void OnMouseDown()
        {
            NetworkConnection conn = NetworkClient.connection;

            NetworkConnection owner = null;
            if (isServer)
                owner = GetComponent<NetworkIdentity>().clientAuthorityOwner;

            if (!hasAuthority && isClientOnly)
                conn.identity.GetComponent<Player>().CmdAssignClientAuthority(gameObject);
            else if (hasAuthority && isClientOnly)
                CmdRemoveClientAuthority(gameObject);
            else if (isServer && hasAuthority && owner == null)
                GetComponent<NetworkIdentity>().AssignClientAuthority(NetworkServer.localConnection);
            else if (isServer && !hasAuthority && owner == conn)
                GetComponent<NetworkIdentity>().RemoveClientAuthority(NetworkServer.localConnection);
        }


Youtube Transcript Summarizer using NLP

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : Youtube Transcript Summarizer
:red_circle: Aim :The aim of the YouTube Transcript Summarizer is to provide concise, meaningful summaries by reducing transcript length by 80%, allowing users to quickly grasp the key points of a video.
:red_circle: Dataset : The dataset used would typically be the transcripts of YouTube videos
:red_circle: Approach : The YouTube Transcript Summarizer employs Natural Language Processing (NLP) techniques to provide concise summaries of video transcripts. The process begins with extracting the transcript, followed by preprocessing to clean and tokenize the text. The chosen algorithm then analyzes the content to generate a summary, significantly reducing the original length while retaining essential points. This approach enables users to quickly grasp the core message of a video without sifting through lengthy transcripts.(Transcripts are take with the help of youtube transcript summariser)

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Sindhuja Didugu
GitHub Profile Link : https://github.com/sindhuja184
Email ID<EMAIL_ADDRESS>Participant ID (if applicable):
Approach for this Project :The YouTube Transcript Summarizer employs Natural Language Processing (NLP) techniques to provide concise summaries of video transcripts. The process begins with extracting the transcript, followed by preprocessing to clean and tokenize the text. The chosen algorithm then analyzes the content to generate a summary, significantly reducing the original length while retaining essential points. This approach enables users to quickly grasp the core message of a video without sifting through lengthy transcripts.(Transcripts are take with the help of youtube transcript summariser)
What is your participant role? (Mention the Open Source program) GSSOC ext- Participant

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Can you please assign this issue to me under 𝗚𝗦𝗦𝗼𝗖 '𝟮𝟰 𝗘𝘅𝘁𝗲𝗻𝗱𝗲𝗱, Hacktoberfest-accepted

Can you please assign this issue to me under 𝗚𝗦𝗦𝗼𝗖 '𝟮𝟰 𝗘𝘅𝘁𝗲𝗻𝗱𝗲𝗱, Hacktoberfest-accepted

As this issue is raised by @sindhuja184, this issue can't be assigned to you.

@sindhuja184 can you please elaborate the approach you are planning for this problem statement?

The aim of the project is to summarize the transcripts of the youtube video.

Initially I would extract the transcript of the youtube video with the help of Youtube Transcript API.(Here I would need the video ID of the youtube video).
Then split the text into chunks with each of size some tokens.(Summarization models have a token limit, so spliting is mandatory here.)
Then by using Hugging face transformers I would summarize the text.(I would like to select facebook, bart-large-cnn model).
Then, combine the summaries.

This is the approach I am planning to follow @abhisheks008

Apart from huggingface, any other algorithms you are comfortable with? As the project repository requires at least 3 model implementations for each problem statement.


UNDERTOW-1342 Improve HttpServletRequestImpl#getLocalAddr() to determ…

…ine the IP address from the host name string when destinationAddress is unresolved socket

Rejecting as per JIRA comment.


feat: use Konva object pass through from ImageConfig param

Summary
Allow Pikaso to use an Image instance passed in through Konva.ImageConfig. This is mainly used to give the user more control of the Image instances that they can pass in. Right now Pikaso's ImageDrawer insert function createa its own Konva Image object. This makes it impossible for users to add videos to the canvas.
The original Konva API allows you to pass in image object that can also be a HTML video element to support adding video to canvas. The changes basically passes that ability through.

@zthomas  Thanks for creating this pull request. It totally makes sense and I'm with you to add the feature to ImageDrawer insert function
However I'm not okay with the implementation for two essential reasons:
1- I'm against of using as in TS if it's possible
2- You have to pass an empty string for the first argument editor.shapes.image.insert('', { image: <Object>}) and like to keep the api simple as much as possible
So I made some minor changes in your pull request. with this changes the first parameter will accept a File or Konva.Image or a string and the second one will remain optional.
Also I added three more unit tests.
Please check my commit and let me know if that looks good to you and then I'll merge that.
Cheers.

Thanks. I actually tried a similar approach on my first attempt. It also overloaded the first parameter to accept a Konva.Imagehowever it didn't actually work for me in practice. I doubled checked that I was passing the Konva.Image instance from my application but it didn't pass the check in that function. I suspect the reason might be becuase we are using different constructors (possibly different versions of Konva).
The instanceof checks might not be that robust when in a library context. If there was a way to do duct typing check or something that might be more robust.
I'll run this new update against my codebase and see if it has the same issues.

Thanks. I actually tried a similar approach on my first attempt. It also overloaded the first parameter to accept a Konva.Imagehowever it didn't actually work for me in practice. I doubled checked that I was passing the Konva.Image instance from my application but it didn't pass the check in that function. I suspect the reason might be becuase we are using different constructors (possibly different versions of Konva).
The instanceof checks might not be that robust when in a library context. If there was a way to do duct typing check or something that might be more robust.
I'll run this new update against my codebase and see if it has the same issues.

please check here
https://github.com/pikasojs/pikaso/pull/11/files#diff-1f8f48101abb7d8a5547374efdf6e0069559d969a5db10fd068df000472aa048R29

Yup, I saw that unit test earlier. It will pass the unit test because the way that it's set up it'll be using the same Konva library in the test runner as the library. I just have to check that in my application that it still works. I might be using a different version of Konva depending on how the dependencies are setup.

Yup, I saw that unit test earlier. It will pass the unit test because the way that it's set up it'll be using the same Konva library in the test runner as the library. I just have to check that in my application that it still works. I might be using a different version of Konva depending on how the dependencies are setup.

@zthomas basically it's better to import Konva from Pikaso
import { Konva } from 'pikaso'
or install equal major version of Konva independently for the sake of consistency


ContentDialog background is not properly displayed when exiting compact overlay display mode

Describe the bug
Before displaying a ContentDialog, I'm forcing my application to exit the compact overlay display mode to be sure that I will have enough room to display the dialog. This is working but the ContentDialog background is not properly resized to the window size.
Steps to reproduce the bug
See the attached sample application to see the current behavior: ContentDialogWhenExistingCompactOverlay.zip
The basic steps are:

Enter compact overlay mode

ApplicationView.GetForCurrentView().TryEnterViewModeAsync(ApplicationViewMode.CompactOverlay)

Exit compact overlay and display a content dialog

await ApplicationView.GetForCurrentView().TryEnterViewModeAsync(ApplicationViewMode.Default);
var dialog = new ContentDialog
{
    PrimaryButtonText = "OK",
    Content = "This is the content",
    Title = "Title",
};

await dialog.ShowAsync();

Expected behavior
The application is back in default mode and the ContentDialog is properly displayed (content + background)

Actual behavior
The application is back in default mode but the ContentDialog background is not covering the whole app.
It seems to keep the size of the compact overlay window.

Workarounds
Some workarounds are working like:

Showing the content dialog before changing the display mode

var dialog = new ContentDialog
{
    PrimaryButtonText = "OK",
    Content = "This is the content",
    Title = "Title",
};

var showDialogTask = dialog.ShowAsync();

var applicationView = ApplicationView.GetForCurrentView();
if (applicationView.ViewMode == ApplicationViewMode.CompactOverlay)
{
    await applicationView.TryEnterViewModeAsync(ApplicationViewMode.Default);
}

await showDialogTask;

This works but we see the ContentDialog's background flickering when the application gets its final size.

Monitor the SizeChanged event with some filtering

var applicationView = ApplicationView.GetForCurrentView();
if (applicationView.ViewMode == ApplicationViewMode.CompactOverlay)
{
    var sizeChangeCompletion = new TaskCompletionSource<bool>();
    var currentBounds = Window.Current.Bounds;
    async void OnSizeChanged(object s, WindowSizeChangedEventArgs args)
    {
        var deltaX = Math.Abs(currentBounds.Width - args.Size.Width);
        var deltaY = Math.Abs(currentBounds.Height - args.Size.Height);

        if (deltaX < 2 && deltaY < 2)
        {
            // The size didn't change enough. Give up.
            return;
        }

        // We wait a little to let the layout complete
        await Task.Delay(TimeSpan.FromMilliseconds(100));
        sizeChangeCompletion.TrySetResult(true);
    }

    Window.Current.SizeChanged += OnSizeChanged;

    var resizeCompleteCompletion = new TaskCompletionSource<bool>();
    void CoreWindow_ResizeCompleted(CoreWindow s, object args) => resizeCompleteCompletion.TrySetResult(true);
    Window.Current.CoreWindow.ResizeCompleted += CoreWindow_ResizeCompleted;

    var result = await applicationView.TryEnterViewModeAsync(ApplicationViewMode.Default);
    if (result)
    {
        await Task.WhenAny(resizeCompleteCompletion.Task, sizeChangeCompletion.Task);
    }

    Window.Current.CoreWindow.ResizeCompleted -= CoreWindow_ResizeCompleted;
    Window.Current.SizeChanged -= OnSizeChanged;
}

await ShowDialogAsync();

This works fine but it is "complicated" to write and shouldn't be needed.

Unfortunately we would not be able to fix this until post winui3, so you will be stuck with a work around for a little while.  I'm not sure that this will work but you can try to change the view mode, then wait for exactly 1 rendering tick, using the winrt::Xaml::Media::CompositionTarget::Rendering event, and then create and show the dialog.  If you do this be sure that you un register from the rendering event as keeping a handler attached to this event would cause a large perf hit.  you can see the winui2 project do something similar with this helper https://github.com/microsoft/microsoft-ui-xaml/blob/2390f15356323bf051f253c0fd24e81ed591d82e/dev/dll/SharedHelpers.cpp#L401


look into variable row height

look into variable row height
Would have to have some kinda function/ extra param where you supply a array how high each row is supposed to be
Maybe add a expand function to each row binding index so someone could use detail form
Maybe own param to grid to set grouping row to one height and row to another,m grouping rows look weird if they get to large
Important grid uses default when not supplied with own heights, since this can never be used with virtual scrolling when loading on scroll if anyone makes a datasource for doing that
anyways, this can go wrong is so many ways... and be a pain to implement since I would need to adjust the pinned of left and right, main and groups at the same time, and keep track when calculating top

This is working for setting 1 height for rows and 1 for groups now
To use:'
Set this on vgrid element to make it ask datasource for rowheight state
v-variable-row-height="true"

on datasource you need to add to the configuration the group height and row height else its 25
this.ds = new DataSource(new Selection('multiple'), {
      rowHeight: 50,
      groupHeight: 25
    });

Looks like this is causing issues for #79


Pulling for bluetooth info blocks UI

Pulling for bluetooth adapter status blocks UI if no bluetooth device is present.

The bt-adapter command blocks if no bluetooth devices are present, this was causing the UI to block as well. Now, I checked if there are adapters present before calling bt-adapter.


8 bit support

I tried to open 8 bit DICOM ECG file but the error  Waveform bits store definition is not supported [8] is occurring.

Hello @mdubey82!
Thank you for your interest in dcmjs-ecg. Eight-bit DICOM ECG files are not supported because, simply, I couldn't find any to test! Hence the guard against any other bits value. If you are wiling to anonymize yours and share them, that would be great!

ecg_error_bits_store.zip
Thank you for the reply.Attach is the ECG dataset which is giving the error.

@PantelisGeorgiadis Any update on this.

Sorry @mdubey82, no updates yet... :-(


Broken image: Event Hubs architecture

The "Event Hubs architecture" image is missing from the page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71adf8e4-a51b-d20d-39e1-fd7551bc94b9
Version Independent ID: 3d26fbc0-b6ae-e0ca-089f-e4966c19ef22
Content: Overview of features - Azure Event Hubs - Azure Event Hubs
Content Source: articles/event-hubs/event-hubs-features.md
Service: event-hubs
GitHub Login: @spelluru
Microsoft Alias: spelluru

Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.

Fixed. #please-close


add rqt for Noetic

@dirk-thomas it looks like this one depends on actionlib (@mjcarroll fyi), which depends on common_msgs (@tfoote fyi) https://github.com/ros-visualization/rqt/blob/5549d88d28ae1f0de51823c931aad7265ce1ebe7/rqt_py_common/package.xml#L37 .
@tfoote Is common_msgs compatible with Python 3? If so, mind adding a source entry for it?


Fixing constant name on Exceptions messages

The constant "Window.FEATURE_OVERLAY_ACTION_BAR" written on Exception message doesn't exist. I changed to the correct one: "Window.FEATURE_ACTION_BAR_OVERLAY"

To report bugs or submit patches to Android, please follow the instructions at http://source.android.com/source/contributing.html.  More information on these mirrors (like the fact that issues and pull requests are ignored) is available at http://aosp-mirror.github.io/.


refactor: vault does not pay redeem fee if redeemer == vault

Signed-off-by: Gregory Hill<EMAIL_ADDRESS>

I'm not sure this is the best way to deal with the problem of the vault being unable to leave the system. The problem is, the vault needs to have the interbtc to be able to redeem with itself, which it must first acquire with another vault.

I'm not sure this is the best way to deal with the problem of the vault being unable to leave the system. The problem is, the vault needs to have the interbtc to be able to redeem with itself, which it must first acquire with another vault.

I think the idea is that interBTC can be readily bought from some decentralised exchange for redeeming. This would remove the need for a Vault to rely on Replace to exit the system. Do you have another suggestion?

Alexei and I discussed this and think it's quite straightforward. We could even have our own AMM-style exchange. Ultimately, replace is the protocol for vaults to leave the system. But this change at least prevents "left-over" on redeem.


BUILD FAILED (OS X 10.14.6 using ruby-build 20200224)

Got this error, don't know how to resolve this issue. Please advice any workaround?
Im on MacOS Mojave 10.14.6

rbenv install 2.7.0
Downloading openssl-1.1.1d.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/1e3a91bc1f9dfce01af26026f856e064eab4c8ee0a8f457b5ae30b40b8b711f2
Installing openssl-1.1.1d...
BUILD FAILED (OS X 10.14.6 using ruby-build 20200224)
Inspect or clean up the working tree at /var/folders/sr/pyz9yrtd42sdpvmhjfm1hw7r0000gn/T/ruby-build.20200329125953.61905.Jicvxm
Results logged to /var/folders/sr/pyz9yrtd42sdpvmhjfm1hw7r0000gn/T/ruby-build.20200329125953.61905.log
Last 10 log lines:
_fd_write in bss_fd.o
_fd_puts in bss_fd.o
_sock_write in bss_sock.o
_sock_puts in bss_sock.o
(maybe you meant: _UI_method_get_writer, _RAND_write_file , _PEM_write_bio_PKCS7_stream , _PEM_write_X509_AUX , _PEM_write_PrivateKey , _PEM_write_bio_PrivateKey_traditional , _PEM_write_bio_PrivateKey , _PEM_write_PKCS8_PRIV_KEY_INFO , _PEM_write_bio_PKCS8_PRIV_KEY_INFO , _PEM_write_PKCS8PrivateKey , _PEM_write_bio_PKCS8PrivateKey , _PEM_write_bio , _PEM_X509_INFO_write_bio , _PEM_write_bio_PUBKEY , _PEM_write_DHparams , _PEM_write_EC_PUBKEY , _PEM_write_bio_EC_PUBKEY , _PEM_write_bio_ECPKParameters , _PEM_write_DSA_PUBKEY , _PEM_write_bio_RSA_PUBKEY , _PEM_write_RSAPublicKey , _PEM_write_PKCS7 , _PEM_write_bio_PKCS7 , _PEM_write_X509_CRL , _PEM_write_bio_X509_REQ_NEW , _PEM_write_X509_REQ , _PEM_write_bio_X509 , _PEM_write_PKCS8 , _PEM_write_DHxparams , _PEM_write_DSAparams , _PEM_write_ECPKParameters , _PEM_write_bio_RSAPrivateKey , _UI_method_set_writer , _PEM_write_bio_X509_AUX , _PEM_write_ECPrivateKey , _SMIME_write_CMS , _PEM_write_DSAPrivateKey , _PEM_write_X509 , _PEM_write , _PEM_write_bio_DSAPrivateKey , _PEM_write_bio_X509_CRL , _PEM_write_bio_NETSCAPE_CERT_SEQUENCE , _SMIME_write_PKCS7 , _PEM_ASN1_write , _PEM_ASN1_write_bio , _PEM_write_bio_CMS , _CRYPTO_THREAD_write_lock , _PEM_write_bio_DHxparams , _PEM_write_bio_DSAparams , _PEM_write_RSA_PUBKEY , _TXT_DB_write , _PEM_write_PUBKEY , _BIO_meth_set_write_ex , _BIO_meth_set_write , _BIO_meth_get_write , _PEM_write_bio_DSA_PUBKEY , _BIO_write_ex , _PEM_write_bio_X509_REQ , _PEM_write_bio_Parameters , _PEM_write_bio_ECPrivateKey , _PEM_write_bio_PKCS8 , _PEM_write_X509_REQ_NEW , _PEM_write_bio_DHparams , _BIO_ctrl_get_write_guarantee , _BIO_meth_get_write_ex , _PEM_write_bio_PKCS8PrivateKey_nid , _PEM_write_bio_ASN1_stream , _PEM_write_bio_CMS_stream , _BIO_write , _PEM_write_CMS , _PEM_write_RSAPrivateKey , _PEM_write_NETSCAPE_CERT_SEQUENCE , _PEM_write_PKCS8PrivateKey_nid , _SMIME_write_ASN1 , _PEM_write_bio_RSAPublicKey )
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:756: libcrypto.dylib] Error 1
make[1]: Leaving directory '/private/var/folders/sr/pyz9yrtd42sdpvmhjfm1hw7r0000gn/T/ruby-build.20200329125953.61905.Jicvxm/openssl-1.1.1d'
make: *** [Makefile:174: all] Error 2

Hi, try using openssl from Homebrew!
brew install openssl
RUBY_CONFIGURE_OPTS="--with-openssl-dir=`brew --prefix<EMAIL_ADDRESS>rbenv install 2.7.0

Not working... :(
(I also tried to reinstall openssl)

brew install openssl
Warning<EMAIL_ADDRESS>1.1.1d is already installed and up-to-date
To reinstall 1.1.1d, run brew reinstall<EMAIL_ADDRESS>RUBY_CONFIGURE_OPTS="--with-openssl-dir=brew --prefix<EMAIL_ADDRESS>rbenv install 2.7.0
Downloading ruby-2.7.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.7/ruby-2.7.0.tar.bz2
Installing ruby-2.7.0...
ruby-build: using readline from homebrew
BUILD FAILED (OS X 10.14.6 using ruby-build 20200224)
Inspect or clean up the working tree at /var/folders/sr/pyz9yrtd42sdpvmhjfm1hw7r0000gn/T/ruby-build.20200329130940.68004.r2zFpZ
Results logged to /var/folders/sr/pyz9yrtd42sdpvmhjfm1hw7r0000gn/T/ruby-build.20200329130940.68004.log
Last 10 log lines:
tool/config.guess already exists
tool/config.sub already exists
checking build system type... x86_64-apple-darwin18.7.0
checking host system type... x86_64-apple-darwin18.7.0
checking target system type... x86_64-apple-darwin18.7.0
checking whether the C compiler works... no
configure: error: in /var/folders/sr/pyz9yrtd42sdpvmhjfm1hw7r0000gn/T/ruby-build.20200329130940.68004.r2zFpZ/ruby-2.7.0': configure: error: C compiler cannot create executables See config.log' for more details
make: *** No targets specified and no makefile found.  Stop.

The issue was an incompatibility with the parameters setup by anaconda in .bash_profile

Thank you for sharing the solution!
Cross-referencing: https://github.com/rbenv/ruby-build/issues/1364


Support profession reagents

You can use this addon to get a link to the item you want to craft from a profession window. But it doesn't work for the reagents in the same window.

added in 80205.03


[SPARK-7980] [SQL] Support SQLContext.range(end)

Used previous defined range(start,end) to define range(end)

Can one of the admins verify this patch?

@animeshbaranawal this looks good for Scala/Java, except one minor style issue.
Can you also update to include Python? You can find the file in python/pyspark/sql/context.py.  Thanks.

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #33912 has started for   PR 6553 at commit 9fce115.

Test build #33912 has finished for   PR 6553 at commit 9fce115.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

@rxin
To include the range(end) functioning in python sql context, the only way I could figure out is to re-order the function arguments in range which is not desirable.
Would it be correct to create another function with a different name for the purpose?

It is ok. You can just use start itself, i.e. if there is only one argument, then start means end.


Activation command guide for PowerToys Run

Description of the new feature / enhancement
PowerToys Run is very powerful and customizable, but sometimes I forget what the "direct activation command" is for a specific plugin. This is even more embarrassing when it's a command that I've customized!
It would be great if there were a way to get a quick reminder without having to pull up the settings page. Possible solutions include:

An optional addition to the Run interface
A customizable key that shows a Shortcut-Guide-style overlay while held down when the Run dialog is up (my personal favorite)
A Run-exclusive command that triggers a pop-up
And so much more! :)

Scenario when this would be used?
 It would also allow me to enable more plugins and keep my search results cleaner by not including everything in the global results.
Supporting information
No response

The team is currently working on this here: #12182

Duplicate of #12182

Yes, this is a duplicate. We are currently tracking this work item as part of our overall UI refresh and should be available in the coming releases. Thanks for reporting it!


Can't eval aarch64-linux package on x86_64-linux

Since adding helix's flake to my nixcfg, I'm no longer able to evaluate my aarch64 systems on my x86_64 boxes. This is pretty painful since I rely on evaluating on my main CI machine and then remote building the derivations and copying outputs back.
I'm not sure though, if this is because of a specific Rust dep that is triggering this, or if its an overall symptom of helix's use of nix-cargo-integration.
Any tips?
❯ nix eval --raw --derivation 'github:helix-editor/helix/e267dc#packages.aarch64-linux.helix'
error: a 'aarch64-linux' with features {} is required to build '/nix/store/l4r33m9ys148295f3djjys1hf1vxpvap-crates-io-aho-corasick-0.7.18.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test, recursive-nix}
(use '--show-trace' to show detailed location information)

This is probably because crate2nix uses IFD, at least that's what I think since this happens in eval. I've been trying to switch to using dream2nix only, which has a no-IFD buildRustPackage builder (and soon a crane builder) so it should work much better. There is no granular builder yet (like crate2nix) however so it sadly would be worse for caching (thought the crane builder will remedy this since it can build dependencies separately like naersk).

It would be appreciated if you could try https://github.com/yusdacra/nix-cargo-integration/pull/56 on helix's flake, and in your configuration. It should hopefully "just work".

I can't dig in a ton right now, so I may have made a mistake, but I tried this naively:
    helix.url = "github:helix-editor/helix";
    #helix.inputs.nixpkgs.follows = "nixpkgs";
    nci.url = "github:yusdacra/nix-cargo-integration/feed2c1f7ae104f38c295c210f3a26088ed3cf4f";
    helix.inputs.nixCargoIntegration.follows = "nci";

and got:
error: 'makeOutputs' at /nix/store/dc3gxpiynqd74n2bnka9a3377k81w4s7-source/src/lib.nix:17
9:5 called with unexpected argument 'buildPlatform'

       at /nix/store/csrphcmp29rvd8lnb7ymkaj1313yha41-source/flake.nix:15:5:

           14|   outputs = inputs@{ self, nixCargoIntegration, ... }:
           15|     nixCargoIntegration.lib.makeOutputs {
             |     ^
           16|       root = ./.;
(use '--show-trace' to show detailed location information)

If you remove the buildPlatform attribute, it should try to run at least hopefully. That was removed in that PR, since it just uses dream2nix now.

I've just forked for now, to minimize any weird flake stuff going on:
https://github.com/colemickens/helix/commit/f4a49602be979d52a0823bc4445fac435c1cbd95
But when I eval one of my toplevels, I get error: stack overflow (possible infinite recursion)
Just to check, this is still what I'm using to pull in helix: inputs.helix.outputs.packages.${pkgs.system}.helix

I've bumped to "github:yusdacra/nix-cargo-integration/5c4e36760a232feb572fb5f9b46e8d262dbec42e" and same result.

I've just forked for now, to minimize any weird flake stuff going on:
https://github.com/colemickens/helix/commit/f4a49602be979d52a0823bc4445fac435c1cbd95
But when I eval one of my toplevels, I get error: stack overflow (possible infinite recursion)
Just to check, this is still what I'm using to pull in helix: inputs.helix.outputs.packages.${pkgs.system}.helix

Ugh, infinite recursion errors, that is really annoying. I'll take a look at it soon and try to fix it.

It seems like the issue has to do with either how helix is loading source via ./. or nix-cargo-integration or both. Changing root = ./. to a convoluted call to filterSource got me an error further in.
If you pull the helix commit from my fork you can just build the pkg output directly to get the more useful error. I'm not really sure why it manifests as a stack overflow when its used as part of my system.

I also get a stack overflow error, on your fork. I'm not really sure where this could happen, since there are so many layers, but I'll try looking at nix-cargo-integration first since I suspect some of the recent changes cause this, but we'll see...

I can reproduce the stack overflow with a simple dream2nix flake on helix, so it looks like the bug is in dream2nix most likely, with my builder implementation (or perhaps translator).

I've spent the last 2 weeks working on improving Rust builders over on dream2nix and I think I can now say they actually work pretty well! I have got helix to build using this flake:
{
  description = "A post-modern text editor.";

  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable";
    rust-overlay.url = "github:oxalica/rust-overlay";
    nixCargoIntegration = {
      url = "github:yusdacra/nix-cargo-integration/dream2nix-only";
      inputs.nixpkgs.follows = "nixpkgs";
      inputs.rustOverlay.follows = "rust-overlay";
    };
    helix = {
      url = "https://github.com/helix-editor/helix.git";
      type = "git";
      submodules = true;
      flake = false;
    };
  };

  outputs =
    inputs @ {
      nixCargoIntegration,
      helix,
      ...
    }:
      nixCargoIntegration.lib.makeOutputs {
        root = ./.;
        renameOutputs = { "helix-term" = "helix"; };
        # Set default app to hx (binary is from helix-term release build)
        # Set default package to helix-term release build
        defaultOutputs = {
          app = "hx";
          package = "helix";
        };
        overrides = {
          crateOverrides = common: _: {
            helix-term = prev: {
              buildInputs = (prev.buildInputs or []) ++ [common.cCompiler.cc.lib];
              nativeBuildInputs = (prev.nativeBuildInputs or []) ++ [common.pkgs.makeWrapper];
              preConfigure = ''
                ${prev.preConfigure}
                rm -r helix-syntax/languages
                ln -s ${helix}/helix-syntax/languages helix-syntax/languages
                ln -s "$PWD/helix-syntax/languages" languages
                mkdir -p runtime/grammars
              '';
              postInstall = ''
                ${prev.postInstall}
                mkdir -p $out/lib
                cp -r runtime $out/lib
                wrapProgram "$out/bin/hx" --set HELIX_RUNTIME "$out/lib/runtime"
              '';
            };
          };
        };
      };
}

Note that you will probably need to wait a long time for all the submodules to be fetched, nix doesn't seem to output anything while it's doing that (thought it was stuck a few times, should've used pkgs.fetchFromGitHub...). Hopefully the PR that removes submodules in helix gets merged soon so this no longer needs to be used.

Closing this since it is done.


Game broken

When attempting to access this at https://githubschool.github.io/github-games-zapierre/, I am getting a 404. This could be caused by a couple things:

GitHub pages needs to be enabled on master. You can fix this in the repository settings.
the index.html file is incorrectly named inde.html. We will fix this together in class.

Can you please fix the first bullet @zapierre?

GitHub pages
a. Enabled GitHub pages in settings, by setting it t master rather than disabled.
b. Verified by visiting https://githubschool.github.io/github-games-zapierre/ directly.
c. Declaring a success.
Fix filename issue
a. Do as a group - be social


Issue running Presidio custom Docker image

Hi, I cloned the Presidio repo, and then ran:
docker-compose build
Then I get:
executor failed running [/bin/sh -c pip install pipenv   && pipenv sync]: exit code: 1 ERROR: Service 'presidio-analyzer' failed to build : Build failed
In the details I see a bunch of messages like:
#8 4.289✔ Successfully created virtual environment!  #8 4.349 Virtualenv location: /usr/bin/presidio-analyzer/.venv #8 4.358 Installing dependencies from Pipfile.lock (0db79c)... #8 77.32 An error occurred while installing blis==0.7.5 --hash=sha256:730952f74adb0fa7dde9f1bc11249d5a64f3a3a9cf7dfa23b189a4b767bdf2d0 --hash=sha256:ad4af690c37a5953d3aea660ad89b636bfbb80ca1470995554670ca2143f0cb2 --hash=sha256:2339cb19594134775bda8b86f23a893828fc7e8d63f09ba9a15f30b2b16c966c --hash=sha256:cf11c233ea5c2d30683e7c9641c5dc4cd76ed0f64755ba3321dfb8db39feb316 --hash=sha256:5966ddf3bce84aa7bb09ce4ca059309602fa63280a5d5e5365bb2a294bd5a138 --hash=sha256:65ba723821cc57eb4227eb8dd05c57fff23d97f826d4325b316cd8a63aac8d6a --hash=sha256:8345bd04777557ef385e2f2d1f14a19d53b2ea9ca5fe107a2cdc50d7bafb8eb2 --hash=sha256:9eecfce3d8fce61dede7b0ae0dffa461c22072437b6cde85587db0c1aa75b450 --hash=sha256:31401da283ed42905f0fbf2f8b88ea424c6a911482426f84b5b88c54d382e4d1 --hash=sha256:5023781272e0b2868be2f92017aa6836557990f1ca5ba2af5e9f5a0acf04fd8a --hash=sha256:0c185979f8f528d634f5548b8cd84ab0366d340c27c039ad3937fab186c1c252 --hash=sha256:5812a7c04561ae7332cf730f57d9f82cbd12c5f86a5bfad66ee244e51d06266d --hash=sha256:833e01e9eaff4c01aa6e049bbc1e6acb9eca6ee513d7b35b5bf135d49705ad33 --hash=sha256:0e476931f0d5703a21c77e7f69b8ebdeeea493fc7858a86f627ac2b376a12c8d --hash=sha256:66204a19e38986645940c887498c7b5520efb5bbc6526bf1b8a58f7d3eb37da0 --hash=sha256:d9034dabce4e42e3a1a7b99cc6de430484c8c369e51556ee8d47a53c085de681! Will try again.
This is my Docker version:
docker --version                                                                             Docker version 20.10.10, build b485636
Im also on a Apple silicon MacOS. Is this a known issue?

So upon further investigation, this has to do with the SHA checksums of the dependencies being hardcoded, as they are different for the ARM-based M1 chips. The temporary fix is to regenerate the lock file.
A good long term fix could be to have a separate lock file for ARM architectures. I could create a PR with this lock file, but it would be a good idea to examine how to pick up a different lock file based on detecting the architecture.

Hi @nikhilwadhwa84, having multiple lock files is difficult to maintain. Perhaps a solution would be to optionally lock the requirements within the docker image build?


use rapidfuzz instead of fuzzywuzzy

FuzzyWuzzy is GPLv2 licensed which would force you to licence the whole project under GPLv2.
For this reason this Pullrequest replaces FuzzyWuzzy with  rapidfuzz which is implementing the same algorithm but is based on a version of fuzzywuzzy that was MIT Licensed.
Rapidfuzz is:

Mit licensed so it can be used with the license used by this project
Is faster than FuzzyWuzzy

Edit: I did just see that cheat.sh still has python2 support which would be broken by this PR

@maxbachmann Thank you for this change!


atomicparsley: 20210114.184825.1dbe1be -> 20210124.204813.840499f

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/wez/atomicparsley/releases.
meta.description for atomicparsley is: "A CLI program for reading, parsing and setting metadata into MPEG-4 files"
meta.homepage for atomicparsley is: "https://github.com/wez/atomicparsley"
meta.changelog for atomicparsley is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/6ff976f71695728e156cd645ff8b042e

du listing: https://gist.github.com/162ca4391b0711b0bfddf37f6dce3a07

Rebuild report (if merged into master) (click to expand)

156 total rebuild path(s)

42 package rebuild(s)

42 x86_64-linux rebuild(s)
40 i686-linux rebuild(s)
34 x86_64-darwin rebuild(s)
40 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
atomicparsley
catt
celluloid
curseradio
get_iplayer
haskellPackages.cut-the-crap
jellyfin-mpv-shim
jftui
kodi-cli
lollypop
minitube
mkchromecast
mopidy-youtube
mpc-qt
mps-youtube
mpv
persepolis
plex-media-player
plex-mpv-shim
python37Packages.mpv
python37Packages.pafy
python37Packages.tubeup
python37Packages.youtube-dl
python37Packages.youtube-dl-light
python38Packages.mpv
python38Packages.pafy
python38Packages.tubeup
python38Packages.youtube-dl
python38Packages.youtube-dl-light
python39Packages.mpv
python39Packages.pafy
python39Packages.tubeup
python39Packages.youtube-dl
python39Packages.youtube-dl-light
qimgv
somafm-cli
sublime-music
tartube
tuijam
youtube-dl
youtube-dl-light
ytcc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/r9agsysq1941r608azy8nr3z8x13hsx7-atomicparsley-20210124.204813.840499f \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A atomicparsley https://github.com/r-ryantm/nixpkgs/archive/a7f9ab6ea6aef3e9dac3fc0bf6c96af207d1c7af.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/r9agsysq1941r608azy8nr3z8x13hsx7-atomicparsley-20210124.204813.840499f
ls -la /nix/store/r9agsysq1941r608azy8nr3z8x13hsx7-atomicparsley-20210124.204813.840499f/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

39 packages built:

atomicparsley
catt
celluloid (gnome-mpv)
curseradio
get_iplayer
jellyfin-mpv-shim
jftui
kodi-cli
lollypop
minitube
mkchromecast
mopidy-youtube
mpc-qt
mps-youtube
mpv (mpv-with-scripts)
persepolis
plex-media-player
plex-mpv-shim
python37Packages.mpv
python37Packages.pafy
python37Packages.tubeup
python37Packages.youtube-dl
python37Packages.youtube-dl-light
python38Packages.mpv
python38Packages.pafy
python38Packages.tubeup
youtubeDL (youtube-dl)
youtube-dl-light (python38Packages.youtube-dl-light)
python39Packages.mpv
python39Packages.pafy
python39Packages.tubeup
python39Packages.youtube-dl
python39Packages.youtube-dl-light
qimgv
somafm-cli
sublime-music
tartube
tuijam
ytcc

Maintainer pings
cc @pjones for testing.

+1


Update Jackson libraries to 2.7.2

Update jackson-annotations, jackson-core and jackson-databind to 2.7.2.

I think this might have merge conflicts now due to the Guava change, wanna update it and I'll merge?

Cool, thanks!


Trivial spacing fix in AdoptOpenJDK naming

The project name is "AdoptOpenJDK" without a space.  Fix reference on homepage.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @tellison, could you please sign the CLA so this can be merged

This was fixed in https://github.com/appsody/website/pull/34 thanks for pointing it out


Add "Java If-Else" in JavaHackerrank Section

Add a perfect solution to the given challenge.
Refer:-https://www.hackerrank.com/domains/java

I'll work on this issue.

@DineshBS44  i already made a pull request for this.


Enable Node2 Chrome Debugger on this project

Please update this project to utilise the Node2 debugger using port 9229, rather than the legacy debugger.  According to MS (https://code.visualstudio.com/docs/editor/node-debugging) using versions of Nodejs >6.3 we should be using Node2 rather than Node.  I have tried to do this myself but keep getting connection failures upon starting the debugger within the server instance of VSCode.
Thanks
Danny.
Edit to above:  I don't think this is possible due to the way that the vscode-languageserver code forks the process.  Maybe this needs updating first?

This issue is solved using the information found within https://github.com/Microsoft/vscode-languageserver-node/issues/162


Further property scale

Feature request type
Enhance component
Component name
BrowserViewportService
Is your feature request related to a problem?
I would like to adjust the PageSizeOptions so that no vertical scrollbar is required. This is only possible if I know not only the width and height of the window, but also the scaling of the display.
Describe the solution you'd like
Hi.
Please consider providing not only the width and height of the screen size, but also the scaling of the display. This allows you to calculate the exact space actually available for texts, table rows and other items.
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
Otherwise I need to develop my own browser viewport service.
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @ScarletKuro

Hi.
Do I understand correctly that you just want to get window.devicePixelRatio and that's it? Or some other property like window.visualViewport.scale? Sorry, you need to be more specific.

Otherwise I need to develop my own browser viewport service.

This is not necessary, as you can simply submit a PR. This change should be easy.
Also it wouldn't be really necessary to re-implement the service, since you could just simply call the JS every-time you get the update from the BrowserViewportService.
If you don't have time, but explain me exactly what you want I can implement it as well/

Hi once again. Could you please answer the question? Otherwise, I'll have to close the PR.


High duration loss

Hi @p0p4k, thanks for making this repo!
I am currently trying to train a 44.1kHz English model, but my model is struggling with a rather high duration loss when compared against your TensorBoard logs. It currently looks as follows:

It seems like the other loss terms are correct.
Also, when the generated mel-spectrogram is passed to a vocoder, the audio is very much wrong in pronunciation -- maybe only half right.
My P-Flow config can be found here, and the corresponding HiFi-GAN vocoder config can be found here.
Could you please let me know where I might be wrong? Thanks in advance!

Hi @p0p4k, thanks for making this repo!
I am currently trying to train a 44.1kHz English model, but my model is struggling with a rather high duration loss when compared against your TensorBoard logs. It currently looks as follows:

It seems like the other loss terms are correct.
Also, when the generated mel-spectrogram is passed to a vocoder, the audio is very much wrong in pronunciation -- maybe only half right.
My P-Flow config can be found here, and the corresponding HiFi-GAN vocoder config can be found here.
Could you please let me know where I might be wrong? Thanks in advance!

Hello, Make sure u wrote down "english_cleaners2" in synthesise.py
it has to be like this when u generate english speech
sequence = torch.tensor(intersperse(text_to_sequence(stressed_text, ['english_cleaners2']), 0), dtype=torch.long,

Hi @Oleksandr2505.
Yes I have changed both the training and inference phonemizer to english_cleaners3, so it's definitely not that issue. I've also checked the phonemization output and it is correct.
It's also unrelated to the issue I raised, which is more on the training duration loss, not inference.

Hi @Oleksandr2505.
Yes I have changed both the training and inference phonemizer to english_cleaners3, so it's definitely not that issue. I've also checked the phonemization output and it is correct.
It's also unrelated to the issue I raised, which is more on the training duration loss, not inference.

I am training my model on english 4h 22050kHz dataset, I've recently passed 1000epochs and it sounds good. Maybe you should try switch the vocoder, because at the start I had a huge artifacts, I took vocoder trained on VCTK v1 dataset and it became better. Maybe you should look for another vocoder to match 44 sample rate. You also texted about training duration loss, is it something different from regular loss?
Btw this is my logs.
sample

Yeah, your loss curves look very much like mine.
I'd say I probably don't have an issue with the vocoder, since it's not an issue of artifacts, but pronunciation quality. And yes, the HiFi-GAN I'm using has been trained on 44.1kHz, which isn't a problem.
My main suspect is from my rather high duration losses (~2), versus the TensorBoard graphs posted on the README which can easily be < 1.0 early on, which I thought was the expected trend. It's likely that this affects the pronunciation quality too.
I just wanted to make sure that my 44.1kHz P-Flow config is correct, in case I'm missing something. But thanks for your suggestions nonetheless.

Yea, Actually I see that author got less then 1, but we don't know his exact config. So we can only test and try, I have this parameter very close 1 as well, eventually it can get under it, but can't know on 100%. One more tip, when I was training ukrainian languages and then tried to run english models, I was getting half right and wrong words It was mainly cause of cleaners, but I was changing something in pflow/text in folder like "symbols" and other. So make sure you did not add something another instead of english symbols or numbers. I've fixed in this way.

Yeah, your loss curves look very much like mine.
I'd say I probably don't have an issue with the vocoder, since it's not an issue of artifacts, but pronunciation quality. And yes, the HiFi-GAN I'm using has been trained on 44.1kHz, which isn't a problem.
My main suspect is from my rather high duration losses (~2), versus the TensorBoard graphs posted on the README which can easily be < 1.0 early on, which I thought was the expected trend. It's likely that this affects the pronunciation quality too.
I just wanted to make sure that my 44.1kHz P-Flow config is correct, in case I'm missing something. But thanks for your suggestions nonetheless.

Yea, Actually I see that author got less then 1, but we don't know his exact config. So we can only test and try, I have this parameter very close 1 as well, eventually it can get under it, but can't know on 100%. One more tip, when I was training ukrainian languages and then tried to run english models, I was getting half right and wrong words It was mainly cause of cleaners, but I was changing something in pflow/text in folder like "symbols" and other. So make sure you did not add something another instead of english symbols or numbers. I've fixed in this way.

Yeah, your loss curves look very much like mine.
I'd say I probably don't have an issue with the vocoder, since it's not an issue of artifacts, but pronunciation quality. And yes, the HiFi-GAN I'm using has been trained on 44.1kHz, which isn't a problem.
My main suspect is from my rather high duration losses (~2), versus the TensorBoard graphs posted on the README which can easily be < 1.0 early on, which I thought was the expected trend. It's likely that this affects the pronunciation quality too.
I just wanted to make sure that my 44.1kHz P-Flow config is correct, in case I'm missing something. But thanks for your suggestions nonetheless.

Btw, I would like to know, does your models synthesis the descent sufficient pauses between the sentences or not? I could not find how to control it

@Oleksandr2505 I can't tell, to be honest. The pronunciation isn't good enough to determine the word pauses. But per my experiments with other TTS models (VITS, VITS2), you just have to train with audio that has the long enough pauses that you want.
If you want models with more customizable pauses, I'd recommend something like FastSpeech2 which is more deterministic since it does a more deterministic duration prediction, I think. VITS/VITS2/P-Flow is better for more expressive speech.

@w11wo
thank you for info!

Update: I tried changing many different setups, but found quite an interesting change that finally led to a decent performance.
The duration loss (which contributes to the overall loss), converges to a lower value faster if the model's vocab size is 178, derived from the default LJSpeech + espeak setup. In the logs above where I used gruut as the phonemizer, I used a smaller vocab size of 78 in the model config. Simply increasing the vocab size back to 178 led to a better convergence of the duration loss (for some reason). However, I'm still unable to get a loss of < 1 unlike the one posted in the README.

@patriotyk Yes, I do hear a massive difference in audio output. I think the duration loss values reflect the overall performance of the audio as well, given that the validation loss also decreases with the increased vocab size.
Eventually I could get the duration loss to ~1.0, which is much better than the initial experiments with the smaller vocab size.
The odd thing is why vocab size even impacts the duration loss -- I'm clueless about this.

I have found that configs/model/pflow.yaml contains n_vocab that is equal to 178. I thing it should be 78 in your case and maybe you will get even better duration loss because all 78 symbols are real and you will not have unused symbols.

@patriotyk not really. What I meant by my comments above is that I started with vocab size of 78, which led to the high loss graph as attached at the top of this issue post. It is only by increasing it to 178 that I could achieve a low duration loss of about 1.

Ah yeah. Whenever I changed the symbol list, I also made sure to change the vocab size value in the config. It's weird how an actual symbol size of 78 would benefit by increasing the model config's vocab size.

@w11wo Hi, i just recalled u mentioned about training model using hifigan 44.1khz vocoder, where did you get it or how train it?

Hi @Oleksandr2505. I ended up training a 44.1kHz HiFi-GAN from scratch, which took about 6 days on a 1xH100 GPU. You can find our fork of the HiFi-GAN training code/repo here.


Support for collectors or toSlice/toMap?

Is it possible to convert a stream into a slice or map?

to []interface{} and map[interface{}]interface{}?


Too many redirects on clerk.com (Dashboard AND docs)

Preliminary Checks

[X] I have reviewed the documentation: https://clerk.com/docs

[X] I have searched for existing issues: https://github.com/clerk/javascript/issues

[X] I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)

[X] This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.

Reproduction
https://www.github.com
Publishable key
pk_test_123
Description
Steps to reproduce:

Go to clerk.com docs or to your clerk.com dashboard using Google Chrome
Switch to a completely different tab/website in Chrome, e.g. discord.com, leave this tab open
Switch app, put your computer on stand by, or anything else that puts the clerk.com tab in Chrome to "sleep"
Come back later, open up Chrome, discord.com should be open
Switch to your clerk.com tab

Expected behavior:
clerk.com should NOT display ERR_TOO_MANY_REDIRECTS in Chrome
Actual behavior:
clerk.com displays ERR_TOO_MANY_REDIRECTS in Chrome
Additional info:
Yesterday, I noticed the same but with my own app that is deployed to Vercel but in Chrome 124.0.6367.113 on my Samsung Android phone. Here I don't think I even needed to switch tabs, I just came back a few moments later, opened up Chrome and immediately saw this message. Here's a screenshot - it says: The page does not work. ...dev redirected you too many times. Try deleting your cookies. Button: Reload Page:

I have been using clerk in my app for a couple of months now and I've only seen this error message after I upgraded to Core 2 which I did 3-4 days ago.
Environment
System:
    OS: macOS 14.4.1
    CPU: (8) arm64 Apple M1
    Memory: 100.78 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 10.1.0 - ~/.nvm/versions/node/v20.9.0/bin/npm
    bun: 1.0.13 - ~/.bun/bin/bun
  Browsers:
    Chrome: 124.0.6367.119
    Safari: 17.4.1
  npmPackages:
    @clerk/nextjs: 5.0.6 => 5.0.6
    @floating-ui/react: 0.26.13 => 0.26.13
    @headlessui/react: 2.0.0-alpha.4 => 2.0.0-alpha.4
    @heroicons/react: 2.1.3 => 2.1.3
    @ianvs/prettier-plugin-sort-imports: 4.2.1 => 4.2.1
    @tailwindcss/forms: 0.5.7 => 0.5.7
    @tailwindcss/typography: 0.5.13 => 0.5.13
    @types/node: 20.12.8 => 20.12.8
    @types/react: 18.3.1 => 18.3.1
    @types/react-dom: 18.3.0 => 18.3.0
    @types/react-howler: 5.2.3 => 5.2.3
    @types/react-scroll: 1.8.10 => 1.8.10
    @types/react-timeago: 4.1.7 => 4.1.7
    algoliasearch: 4.23.3 => 4.23.3
    autoprefixer: 10.4.19 => 10.4.19
    clsx: 2.1.1 => 2.1.1
    date-fns: 3.6.0 => 3.6.0
    eslint: 8.57.0 => 8.57.0
    eslint-config-next: 14.2.3 => 14.2.3
    eslint-config-prettier: 9.1.0 => 9.1.0
    justgage: 1.6.1 => 1.6.1
    next: 14.2.3 => 14.2.3
    next-themes: 1.0.0-beta.0 => 1.0.0-beta.0
    postcss: 8.4.38 => 8.4.38
    prettier: 3.2.5 => 3.2.5
    prettier-plugin-tailwindcss: 0.5.14 => 0.5.14
    react: 18.3.1 => 18.3.1
    react-countdown: 2.3.5 => 2.3.5
    react-dom: 18.3.1 => 18.3.1
    react-howler: 5.2.0 => 5.2.0
    react-instantsearch: 7.7.3 => 7.7.3
    react-instantsearch-nextjs: 0.2.2 => 0.2.2
    react-responsive: 10.0.0 => 10.0.0
    react-scroll: 1.9.0 => 1.9.0
    react-toastify: 10.0.5 => 10.0.5
    sass: 1.76.0 => 1.76.0
    swiper: 11.1.1 => 11.1.1
    tailwind-merge: 2.3.0 => 2.3.0
    tailwind-scrollbar: 3.1.0 => 3.1.0
    tailwindcss: 3.4.3 => 3.4.3
    typescript: 5.4.5 => 5.4.5

Closing. Moved conversation to https://discord.com/channels/856971667393609759/1237463588252156015 instead.


Added description for several repositories

Part of https://github.com/artipie/artipie/issues/317
Added description for several repositories

@genryxy thanks

@g4s8 please merge


Question:  Is it possible to replace a character in the regex match

I have a service that lists the current version using a dash on Github and a plus sign in the app.  Trying to figure out how to swap the character in regex and am not having any luck.  Is this even possible?
Here is what I tried.
ReplaceAllString('([0-9.]+\+[0-9a-z]+)', '$1\-$2', $string)

You could make it non-semantic versioning and replace -rc with +rc, so the latest will match the deployed style

ReplaceAllString is failing, but could be related to the semantic_versioning issue?

Yeah, looks like it could be based on it saying $string)semantic_versioning=. Looks like it's defaulted false to "", and missed out the & to separate the 'semantic_versioning' value. Both of these should be fixed in this PR that i'm merging now

Still not working.  I just truncated the version to 1.20.0 on both deployed and latest and called it a day.  :-)


Included link to the supported languages list

@Feday : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@msmimart - I removed the locale from the docs.microsoft.com.

#sign-off


Issue with doodstream

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.05.18 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Kenya
Description
So
the code that decides whether a link is from Doodstream appears to be
https://github.com/yt-dlp/yt-dlp/blob/0b9c08b47bb5e95c21b067044ace4e824d19a9c2/yt_dlp/extractor/doodstream.py#L8-L10
Now with the assumption that Doodstream will always use this format, so far I have found the following that redirect to Doodstream
https://dood.la
https://dood.pm
https://dood.sh
https://dood.to
https://dood.ws
https://dood.one
https://dood.watch
They seem to use them interchangeably
https://dood.la/d/36bclkycxl5n
https://dood.pm/d/36bclkycxl5n
https://dood.sh/d/36bclkycxl5n
https://dood.to/d/36bclkycxl5n
https://dood.ws/d/36bclkycxl5n
https://dood.one/d/36bclkycxl5n
https://dood.watch/d/36bclkycxl5n
There are other domains:
https://dood.tech redirects but it does not appear to generate images anything.
https://dood.legal seems to be internal.
Other strange ones are
https://dood.ooo
https://dood.yt
And a few more that are parked and others that appear to be quite legitimate.
https://dood.do
https://dood.io
https://dood.dog
https://dood.design
These appear to be legitimate and have nothing to do with Doodstream. There are more I have not mentioned.
It is because of this I would like to say I think there is a bug and maybe that was what was going in in #3417 .
Verbose log
So,

I did not do this. I probably should have but I'm hoping the explanation above is sufficient.

Please forgive me.

I have read #3417 again and I think it is something else. Doodstream sits behind Cloudflare.
As we all know, Cloudflare uses magic to decide that you are using a browser or a bot type thing. In the case of a bot type thing you get an immediate 403 and an error page that will not parse.

You didn't even say what your issue is! 😮💨

I have no issue @pukkandan.
I am sorry for wasting your time.
I withdraw my wasting of your time.
Sorry.

This is a bug I saw when I was reading the code

You still don't say what the bug is 🤷
Also, I see now that the example URLs are pirated content 😮💨

You still don't say what the bug is 🤷

Ah that's my brain fart (😮💨) sorry.
Say you try and download one of my links. Take one of the "good" ones:

well in this case it does not work.
I think it is because I am running it off a vhost and the magic from Cloudflare is deciding that I am a bot based on my IP. Using a proper browser even in the vhost works - which suggests they are checking  ... something.
Here is another one

(and now with logs)

See - that one works.
Now the way the Doodstream media ips appear seem to be in a pattern it is typically dood followed by a tld the path e or d and then the id of the media.
My reading of the code suggested that both https://dood.watch and https://dood.to domains will work.
https://github.com/yt-dlp/yt-dlp/blob/415f8d51a8f3565d7a1d4a8188511e7ad68514c7/yt_dlp/extractor/doodstream.py#L8-L10
Now in recent past Doodstream has been using other domain tld's for their media e.g .pm. Now see what happens when we use a .pm

See it uses generic before failing. Not Doodstream - generic.
Now the basic issue is if the URL is changed to another one it will fail. But there are a lot of tlds and when it comes to that not all have been allocated.
The file soa.txt shows the ones that have been allocated. Testing them shows that the ones being used by doodstream may only be limited to
https://dood.la/
https://dood.pm/
https://dood.sh/
https://dood.to/
https://dood.ws/
https://dood.one/
https://dood.watch/
https://dood.legal/
https://dood.tech/
In those it would seem like the .legal and .tech are not really used for media - so maybe ignore them?
I suspect the solution is as simple as just changing the RE. The principle here though suggests that if in the future they use another url - one is back to editing the extractor.
So is it a change to modify the re to add  .la .pm .sh .ws and .one or just to remove the tld as a check? I donno?
But I guess it doesn't matter a PR to delete this extractor may be more appropriate as this is all just piracy?

@pukkandan,
I have changed the sample URLs.
Will do the PR shortly should I also do one that just removes the entire thing?

The same resolution for unwanted 403 applies here as for TikTok (#3776), at least as far as the vanilla UA.

The whole damn point of yt-dlp is to download videos from sites, which, according to the lies of the organized crime (aka pirates aka content mafia), is “piracy”.
yt-dlp literally exists, to circumvent the artificial scarcity and imaginary monopolism schemes of such criminals, especially when they are state-sponsored by rogue regimes that support them.

This is like a VPN going “We’re blocking tianmen-square-trush.org, because China banned it”.
You might as well call the project dead by suicide after schizophrenia.


Example is out of date

examples/anonymous/index.html  use the old auth method.

This is fixed by #66, which should go out next week.

The example is now up-to-date and should work out of the box :) Also, the documentation on the main site has been updated to represent today's 3.0.0 release.


USB: Fix warning in DFU class

Move unused variable to scope where it is used.
Signed-off-by: Filip Kubicz<EMAIL_ADDRESS>

When using USB DFU in a composite device, variable ret is unused.

@finikorg what do you mean? Do you say to keep variable declaration at the top of function block, but enclose it in IS_ENABLED(CONFIG_USB_COMPOSITE_DEVICE)?

@finikorg what do you mean? Do you say to keep variable declaration at the top of function block, but enclose it in IS_ENABLED(CONFIG_USB_COMPOSITE_DEVICE)?

Yes, exactly

@finikorg why not? There are already numerous examples of declaring variables in the middle of the block in Zephyr kernel, but not to look far there is https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/usb/class/hid/core.c#L150 in USB. It's good to keep the variables as local as possible, and Zephyr will not compile with C89 anyway.
But if you prefer to keep it, I can do as you suggest.

Codecov Report

Merging #14699 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14699   +/-   ##
=======================================
  Coverage   51.97%   51.97%
=======================================
  Files         309      309
  Lines       45582    45582
  Branches    10555    10555
=======================================
  Hits        23691    23691
  Misses      17082    17082
  Partials     4809     4809

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f4206...13b965e. Read the comment docs.

I think this is a bad example, some people do not like it
https://github.com/zephyrproject-rtos/zephyr/pull/9691#discussion_r256412908

@finikorg I made changes according to your suggestion.

I think this is a bad example, some people do not like it
#9691 (comment)

I suggest to look at it more differentiated. The first commit was much easier, more readable and and has changed less code, I am for the first suggestion. And, maintainer preferences may vary from subsystem to subsystem ;-).


Fixed 🪝🏗

Fixed Day 2.

@shartf please review.

@Vest Is it safe rust? You are making an .unwrap, it can panic. Errors should be handled!

@shartf, this is the explicit unwrap. The application will not fail, I have checked. The answer is close to 400.

@Vest I have tried ~400 in AoC. Unfortunately, it fails.


Faces in Accel

In accel, we want users to be able to reference cells just by typing in their names, rather than by importing them as dependencies via their path:
(add a1 b2)
We have a few different ideas for this, some of which require more rewriting than others, all of which are blocked on some core shrubbery advancements. Here's the one I like:
imp/accel parses text, a cord of form ':(add a1 j2 f4)', into a [(map face=@tas pith) cord], where cord now has the form ':(add a b c)' and the map looks like {%a: ~[p/our %home %accel t/a ud/1], %b: ~[p/our %home %accel t/j ud/2], %c: ~[p/our %home %accel t/f ud/4]}.
Accel creates the cell with this new formula as the code and the (map face=@tas pith) as the dependencies. imp/accel-cell then slops the vases of these dependencies, giving them their corresponding faces, and runs the code on the new vase.
We'll need to write this code parser either way. Beyond that, this solution requires minimal changes and is blocked only on imps being able to take arbitrary numbers and names of dependencies. @liam-fitzgerald I'm curious if the app/neo rewrite will unblock this.
Alternatively, we could get this working immediately if we allow for merely a stupidly long list of dependencies, as opposed to an arbitrarily long list of dependencies, using a stupidly long ++deps arm in accel-cell. How often do you have more than 26 hand-picked references in one excel formula anyway?
We can use this issue to get our other ideas down on paper too.

"will the re-write allow for arbitrary numbers and names of deps?"

~hastuc-dibtux: "no, I'm of the opinion that this should probably be an overlay namespace. consider a %y overlay where you walk the children and parse the pith and make a name based on that"

imp/accel parses text, a cord of form ':(add a1 j2 f4)', into a [(map face=@tas pith) cord], where cord now has the form ':(add a b c)' and the map looks like {%a: ~[p/our %home %accel t/a ud/1], %b: ~[p/our %home %accel t/j ud/2], %c: ~[p/our %home %accel t/f ud/4]}.
Accel creates the cell with this new formula as the code and the (map face=@tas pith) as the dependencies. imp/accel-cell then slops the vases of these dependencies, giving them their corresponding faces, and runs the code on the new vase.

I'm not sure if needs to be done if you have the computation happening upstream anyway and we assume that all faces of the structure [letter number] are within the spreadsheet (therefore kids of the accel node)
This obviates the need for deps at the level of the top-level accel node for this computation. We can just just the aforementioned (map face=@tas pith) to find the pith that we will be resolving in our kids, and slop the corresponding faces of those piths against our subject inside of a loop.
Then when we have computed our result against that new subject, we envase the new result and place it in the /out kid of the cell that gave us the Hoon.

This is the design that could work, although it wouldn't be easy. Leaving for ~hanfel-dovned's notes as I discussed with him synchronously; for anyone else trying to make sense of it good luck!
accel receives %gift poke
inspect stem;
if source pith is either input or link, recalculate output
if source pith is output, parse all cells to figure out the dependency chain
a1 is (b1 + b2)
b2/output changes
ream all cells, search for reference to b2 (+search-hoon-for-face), recalculate all cells for which the reference exists
b1 latest-message/home/messages/~zod
f1 -> dep(latest-message/home/messages/~zod)
(b1 + f1)
a1 -> b1
b1 -> c1
c1 -> a1
resubscribe loop
deptree (tree face=@tas)
+(is-parent deptree c1 a1)
if true, error

Superseded by #30


[ELF] Implement loading data from ELF

Load segments with PT_LOAD flag into DRAM

@sin-diesel, please, fix CI

@sin-diesel , I can't build project locally with your patch:
build$ cmake ..
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:10 (find_package):
  Could not find a package configuration file provided by "GTest" with any of
  the following names:

    GTestConfig.cmake
    gtest-config.cmake

  Add the installation prefix of "GTest" to CMAKE_PREFIX_PATH or set
  "GTest_DIR" to a directory containing one of the above files.  If "GTest"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!

Please add instruction how we should clone project, you write nothing about submodule in git.
For example:
To clone project use:
git clone --recurse-submodules git@github.com:K3S-prod/risc-v-simulator.git

Or if you already clone project without submodules and want to add them:
git submodule init
git submodule update

I spend some times to understand that


Directories

Fix #237

@jdoliner

@jdoliner comments addressed

Looks good. Merge at will!

Well, resolve merge conflicts first I suppose.


Bump IREE to 8e5f218a1d73c39ccdebb4a1d19225d5329cc6f0

Also bump MLIR-AIR to 8fe05179d83f04cf56965ae55da0f476ec7431ed

I can figure out the reason for the segfault on Monday

I can figure out the reason for the segfault on Monday

Thanks! It might relate to this change in IREE? https://github.com/iree-org/iree/commit/0077358221e3fd2a52d114115ac9b9d17089fc16

The failing tests are on Linux where the XRT-LITE HAL is used but you're fixing/changing the XRT HAL...

The failing tests are on Linux where the XRT-LITE HAL is used but you're fixing/changing the XRT HAL...

There were windows failures as well https://github.com/nod-ai/iree-amd-aie/actions/runs/11749085186/job/32734566694, so the xrt hal changes were a fix for that. Linux failure has not been solved yet.

, which I thought you'll help take a look.

Yup yup


[BUG] Path params not generated

Describe the bug
The following swagger definition does not generate a function argument for the defined path param. The path param is defined as a  Common Parameters for All Methods of a Path which seems to not be supported?
To Reproduce
Swagger:
{
  "openapi": "3.0.0",
  "info": {
    "title": "path-params-demo",
    "version": "1.0"
  },
  "servers": [
    {
      "url": "http://localhost:3000"
    }
  ],
  "paths": {
    "/users/{userId}": {
      "parameters": [
        {
          "schema": {
            "type": "string"
          },
          "name": "userId",
          "in": "path",
          "required": true,
          "description": "user id"
        }
      ],
      "get": {
        "summary": "get user",
        "tags": [],
        "responses": {
          "200": {
            "description": "OK"
          }
        },
        "operationId": "get-users-userId"
      }
    }
  },
  "components": {
    "schemas": {},
    "parameters": {}
  }
}

Generated code:
@override
Future<Response<dynamic>> usersUserIdGet() {
  final $url = '/users/{userId}';
  final $request = Request('GET', $url, client.baseUrl);
  return client.send<dynamic, dynamic>($request);
}

Expected behavior
Expected generated function to take userId as argument
Library version used:
Commit: 63cdc323ceb49c1e928c7ed1b3f58d4052063fc5

Hi @prasmussen , looks like easy fix. Will fix it today

@prasmussen , enjoy 2.1.1+3 version already in pub.dev
Please, let us know in case of any issues

It works now 👍
Thanks a lot for the quick fix :)


Remote server/cluster management

It would be a great feature to be able to remotely manage servers and eliminating the requirement to have mongoctl installed on each cluster node.

+1


add multilabel f1 eval usage

Based on discussion here: https://huggingface.co/spaces/evaluate-metric/f1/discussions/2
and here: https://huggingface.co/spaces/evaluate-metric/f1/discussions/3#62e3b1e72c8797d3196b672d

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Mongo 3.6 : Could not evaluate: Can't connect to any member of replicaset rsmain

Hi,
We are trying to setup the replication using this module but getting following error :
Notice: /Stage[main]/Mongodb::Replset/Mongodb_replset[rsmain]/ensure: created Warning: Can't connect to replicaset member <IP_ADDRESS>:8080. Warning: Can't connect to replicaset member <IP_ADDRESS>:8080. Warning: Can't connect to replicaset member <IP_ADDRESS>:8080. Error: /Stage[main]/Mongodb::Replset/Mongodb_replset[rsmain]: Could not evaluate: Can't connect to any member of replicaset rsmain.
Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 5.3.2
Ruby: 2..0.0
Distribution: Centos 7.4.1708 (Core)
Module version: 2.1.2

How to reproduce (e.g Puppet code you use)

Create three AWS EC2 instances with port 8080 open
Set the replication configuration :
 class { 'mongodb::server': auth            => false, verbose          => true, port             =>  $port, dbpath           => $dbpath, logpath          => $logpath, service_ensure   => stopped, replset          => 'rsmain', replset_config => { 'rsmain' => { ensure  => present, members => ['<IP_ADDRESS>:8080', '<IP_ADDRESS>:8080', '<IP_ADDRESS>:8080']  }  } }
Execute Puppet Apply

What are you seeing
Error: /Stage[main]/Mongodb::Replset/Mongodb_replset[rsmain]: Could not evaluate: Can't connect to any member of replicaset rsmain.
What behaviour did you expect instead
Replication should work
Output log
Please refer to the attached file for debug log
Error_Log.txt
Any additional information you'd like to impart

This issue will probably be fixed with this PR:
https://github.com/voxpupuli/puppet-mongodb/pull/446
I will try to get it merged (lost sight of this for a while)

Thanks @TomRitserveldt .
This issue is now resolved after changing or removing following line :
service_ensure => stopped to service_ensure => running
But I am facing different problems now with replication:

If auth == true, then I am getting following Error  :
Error: Failed to apply catalog: Could not evaluate MongoDB shell command:  load('/root/.mongorc.js'); printjson(db.getMongo().getDBs())

I think, there is already a bug for this  :  https://github.com/voxpupuli/puppet-mongodb/issues/437

If auth == false,
If we do following steps :   a) Set auth == false
b) Setup the replication
c) Enable Authorisation in conf file
d) Restart the Mongo Service

Then the replication is working on the First Node but when you will run the code on Second Node then it's failed when it's trying to fetch the replication info from the first node.
Error : {"operationTime"=>1528300824, "ok"=>0, "errmsg"=>"not authorized on admin to execute command { replSetGetStatus: 1.0, $clusterTime: { clusterTime:<PHONE_NUMBER>, signature: { hash: 0, keyId:<PHONE_NUMBER>095622657 } }, $db: \"admin\" }", "code"=>13, "codeName"=>"Unauthorized", "$clusterTime"=>{"clusterTime"=>1528300824, "signature"=>{"hash"=>0, "keyId"=>"6563998673095622657"}}}
Is there any way to set the replication with the Auth enabled ?

@Dharmender-Singh The error you're getting with auth = false IS related to my PR above, the replica nodes need to run the command to check the db's created with slaveOk().
I haven't tried to setup the cluster with auth enabled as we dont do direct cluster access for users other than the applications(per database) themselves.

Thanks @TomRitserveldt . Will wait for merging your PR..

Hi there, now would be a good time to merge those PS's

btw. it's also valid for clusters with no authentication.
@TomRitserveldt

Just curious what the timefrane on this getting resolved is. I am trying to setup a replicaset with auth set to true and it fails

Hey there, any news about this ?


Problem when start MM

Platform (Hardware/OS):
Reaspberry Pi 2 / Jessie Lite
Node version:
v6.10.3
MagicMirror version:
2.1.1.
Module version:
GIT CLONE
Description of the issue:
1|mm       | TypeError: this.sendSocketNotification is not a function
1|mm       |     at fs.appendFile (/home/pi/MagicMirror/modules/MMM-voice/node_helper.js:311:22)
1|mm       |     at /home/pi/MagicMirror/modules/MMM-voice/node_modules/graceful-fs/graceful-fs.js:43:10
1|mm       |     at FSReqWrap.oncomplete (fs.js:112:15)

This module doesn't use graceful-fs, did you install that manually?

No. I install MMM-voice using dependencies script.

Nothing? Please help me!
Regards,

Nothing?

The new release v1.0.2 should fix that problem #14

It works!


Update s3, sdk-core, sqs to 2.16.53

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.16.26 to 2.16.53.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #167.


Make it possible to use custom networks

Implemented:

[x] Create new custom networks (auto configure)
[x] Manage custom networks
[x] Delete custom networks
[x] Create profile with custom networks
[x] Make it possible to show market data (price etc.) from custom networks

Todo:

[x] German Translations
[x] Better UI
[x] Refactoring
[x] must wif  and bip32 be configurable?

probably not, they are both ledger related!

Optional:

Wait until ark-ts issues are resolved, https://github.com/ArkEcosystem/ark-ts/pull/21

Not really required, since it works without changes

This one is ready for review.
So I just pushed an update which tries to make the method findGoodPeer better (see commit message).
I would recommend reviewing this commit separetly.
Also here are some test IPs (pm me on slack if you need an account with some tokens on it for testing):
PERSONA TEST NET:
http://<IP_ADDRESS>:4101
Nethash: b4e87739ca85f7eabf844a643930573e9a2dd9da291662e74d26962b5c3f0ed9
Blockpool
Market name: BPL   (for price chart, etc.)
Seed: http://<IP_ADDRESS>:9030
Nethash: 7bfb2815effb43592ccdd4fd0f657c082a7b318eed12f6396cc174d8578293c3

@luciorubeens
No I thought we use modals everywhere :P didn't realize we often use pages.
Should I change it?

I'll merge and we'll change when we have the design 👍 Very good!

Thanks just tell me in slack or here when you know it.


Add spreadsheet_template_path

Deprecate get_template_spreadsheet as it's not memory efficent.
We should use send_file Modsulator.spreadsheet_template_path in
modsulator-app-rails

Coverage increased (+0.6%) to 92.216% when pulling 5b4634905468ad4b991d2a0db8af6870a99e9c3b on add_template_spreadsheet_path into 133b1fc4c34842918ab66bccd6461bd16a0968df on master.

Coverage increased (+0.6%) to 92.216% when pulling 5b4634905468ad4b991d2a0db8af6870a99e9c3b on add_template_spreadsheet_path into 133b1fc4c34842918ab66bccd6461bd16a0968df on master.