Update character count on initial page render

Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1532 (d77f1af) into main (b77e8f4) will increase coverage by 0.02%.
The diff coverage is 90.00%.

:exclamation: Current head d77f1af differs from pull request most recent head 06dc99a. Consider uploading reports for the commit 06dc99a to get more accurate results

@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
+ Coverage   71.90%   71.93%   +0.02%
==========================================
  Files         336      336
  Lines        9949     9954       +5
  Branches      725      727       +2
==========================================
+ Hits         7154     7160       +6
+ Misses       2673     2672       -1
  Partials      122      122

Flag
Coverage Δ

metweb
65.26% <90.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...agement/form/EngagementFormTabs/EngagementForm.tsx
76.04% <90.00%> (+1.59%)
:arrow_up:

... and 4 files with indirect coverage changes


[bug] 5.3.0 breaking typescript

🐛 Bug Report

reverting back to 5.2.1 helps.
node.js 13.3.0
yarn
TS 3.8.4

I am still having this issue on 5.3.3 and TypeScript 3.7.5


Per-Project Settings

Is there any way to configure per-project settings? For instance, on some projects, I want to use PSR-1, on others, I want to disable it.

I would also like this feature very much. For example, I use 2 spaces for Drupal and 4 spaces for Laravel.


v0.6.0 - See CHANGELOG for details

See CHANGELOG for details.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

dev_deps.ts
100.00% <100.00%> (ø)

src/Constants.ts
100.00% <100.00%> (ø)

src/Controller.ts
100.00% <100.00%> (ø)

src/ControllerMethodArgs.ts
100.00% <100.00%> (+29.00%)
:arrow_up:

src/Delete.ts
100.00% <100.00%> (ø)

src/Get.ts
100.00% <100.00%> (ø)

src/Patch.ts
100.00% <100.00%> (ø)

src/Post.ts
100.00% <100.00%> (ø)

src/Put.ts
100.00% <100.00%> (ø)

src/useOakServer.ts
100.00% <100.00%> (+2.56%)
:arrow_up:

... and 2 more


1550 pl bundle fix

Fixes #1550  .
Description
Add download dataset steps to make the notebook more reproducible.
Checks

[x] Avoid including large-size files in the PR.
[x] Clean up long text outputs from code cells in the notebook.
[x] For security purposes, please check the contents and remove any sensitive info such as user names and private key.
[x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
[ ] Notebook runs automatically ./runner.sh -t <path to .ipynb file>

We had a temporary fix here https://github.com/Project-MONAI/tutorials/pull/1551 for the notebook issue. The tests have issues with running training in a %%bash cell (ie. in subprocesses) that we need to figure out. This download cell definitely helps but we need to sort CI issues before we can run this and the other bundle notebooks automatically.


feat(pricing): add currency api

Based on the Exchange Rate API, I added support for multi-currency to my-idlers
Their free plan introduction can be found at https://www.exchangerate-api.com/docs/free
A week cache for the currency rate I think we wouldn't trigger their rate limit
To obey their ToS, I added an Attribution to the home page, but I am not sure should we add the Attribution to all the pages with the price field

Nice

I added an Attribution to the home page, but I am not sure should we add the Attribution to all the pages with the price field
Just the homepage should be fine


Converted register folder to kotlin

Related Issue

fixes #

Changes Made

(state your changes)
converted all register files to kotlin.

Checklist

[x] Modifies original code
[ ] Added comments
[x] Checked the code for problems

Screenshots

hey @ishir21 thanks for this, we definitely needed it. Give me some time I will check this soon, as there are many files review will take time :)


PWX-22447: added sharedv4-svc test for PX offline too long on the client node

What this PR does / why we need it:
C54778: Verify an offline client (using NFS mountpoint) after restart can access
the NFS mountpoint even if the server has moved to another node.
Which issue(s) this PR fixes (optional)
PWX-22447
Special notes for your reviewer:

Merging this now. Comments addressed in the follow-up PR.


Update num_enum crate to 0.6.1

This is also applicable to android-activity.
This is causing duplicates on the syn dependency.

@kchibisov how quickly do you want to resolve this? num_enum is used in our public API so that requires another breaking change... and I'd like to cram in a few more breaking changes if we have to do a semver-breaking release bump anyway.

@kchibisov looking at https://github.com/rust-mobile/android-activity/pull/108 0.7 just dropped... do you want that for winit or not?

You can pick latest, I don't really care.


[Bug]: winget upgrade return version unknown

Brief description of your issue
I installed the packages : MEGAsync   - Mega.MEGASync <IP_ADDRESS>   and GOG GALAXY GOG.Galaxy   <IP_ADDRESS>a.
When i run the command : winget upgrade I face the issue with text :
PS C:\Users> winget upgrade
Name          Id             Version    Available    Source
MEGAsync      Mega.MEGASync  Unknown    <IP_ADDRESS>       winget
GOG GALAXY    GOG.Galaxy     Unknown    <IP_ADDRESS>a    winget
2 upgrades available.
Steps to reproduce
winget upgrade
Expected behavior
To upgrade the packages
Actual behavior
Cannot upgrade the packages.
Environment
winget --info
Windows Package Manager v1.1.12986
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.348
Package: Microsoft.DesktopAppInstaller v1.16.12986.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

related to https://github.com/microsoft/winget-pkgs/issues/30134 and https://github.com/microsoft/winget-pkgs/issues/27206

To actually start an upgrade, you need to do either winget upgrade --all (to upgrade all applications on your system that need it), or winget upgrade <id for package you want to upgrade> (to upgrade just one).
winget upgrade only lists what applications need to be upgraded, it doesn't actually do anything.

Duplicate of #15946

I have been experiencing an issue for the past 5 weeks with the Winget upgrade process. Below is an example of the error I encounter when attempting to upgrade the "Foxit PDF Reader":
`
winget upgrade "Foxit PDF Reader" --silent
Found Foxit PDF Reader [Foxit.FoxitReader] Version 2<IP_ADDRESS>97
PS C:\Windows\system32> winget install "Foxit.FoxitReader" --silent
An existing package was found. Attempting to upgrade the installed package...
Found Foxit PDF Reader [Foxit.FoxitReader] Version 2<IP_ADDRESS>97
This application is licensed to you by its owner.
Microsoft is not responsible and does not grant licenses for third-party packages.
The installer hash was successfully verified.
Starting package installation...
Now installing, please wait...
Setup failed.
Installation failed with Exitcode: 1603.`
winget --info
Windows-Paket-Manager v1.7.10582
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.
Windows: Windows.Desktop v10.0.22631.3296
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.22.10582.0
WinGet-Verzeichnisse
Protokolle                                   %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\Local…
Benutzereinstellungen                        %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\Local…
Verzeichnis für portierbare Links (Benutzer) %LOCALAPPDATA%\Microsoft\WinGet\Links
Portables Linkverzeichnis (Computer)         C:\Program Files\WinGet\Links
Portierbarer Paketstamm (Benutzer)           %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portierbarer Paketstamm                      C:\Program Files\WinGet\Packages
Portierbares Paketstamm (x86)                C:\Program Files (x86)\WinGet\Packages
Installationsprogrammdownloads               %USERPROFILE%\Downloads
Links
Datenschutzerklärung              https://aka.ms/winget-privacy
Lizenzvereinbarung                https://aka.ms/winget-license
Hinweise von Drittanbietern       https://aka.ms/winget-3rdPartyNotice
Startseite                        https://aka.ms/winget
Windows Store-Nutzungsbedingungen https://www.microsoft.com/en-us/storedocs/terms-of-sale
Administratoreinstellung                  Status
LocalManifestFiles                        Deaktiviert
BypassCertificatePinningForMicrosoftStore Deaktiviert
InstallerHashOverride                     Deaktiviert
LocalArchiveMalwareScanOverride           Deaktiviert


.deployment file with Node Functions does not trigger script

Hello--,
I've tried to automatically install Node dependencies (as specified in package.json) whenever there is a new push to a Git repository.
According to https://github.com/projectkudu/kudu/wiki/Customizing-deployments this should be possible by creating a .deployments file in the root folder that triggers the according command (npm install).
So my .deployment file looks like that (also tried without project = .):
[config]
command = deploy.cmd
project = .

My deploy.cmd looks like that:
cd lib
call npm install

If invoked manually through the console installation of node dependencies work. However, the script does not seem to be triggered automatically when a new version is deployed. Is there anything I'm missing? Thanks!
Best regards
--Oliver.

That's strange. So if you put a simple echo statement in your script, you don't see it at all in the deployment output logs? Can you share a test repo that has this behavior so we can investigate? Thanks.

I'm currently deploying from OneDrive.
Here's the deployment output logs:
Running deployment command...
Command: "D:\home\site\deployments\tools\deploy.cmd"
Handling Basic Web Site deployment.
KuduSync.NET from: 'D:\home\site\repository' to: 'D:\home\site\wwwroot'
Finished successfully.

Generating deployment script...
Using cached version of deployment script (command: 'azure -y --no-dot-deployment -r "D:\home\site\repository" -o "D:\home\site\deployments\tools" --basic --sitePath "D:\home\site\repository"')

Just tried it with Github as deployment source (https://github.com/arafato/azurefunc-deploy-test).
Same output as above.

I tried and your script is definitely getting called. The problem is indeed that it runs from the repository folder and not the wwwroot folder. If you want the repo to be directly in wwwroot so you  avoid file copying, try the following:

First disconnect from source control in the Azure portal
In the Azure Portal App Settings, set SCM_REPOSITORY_PATH=wwwroot, per this page.
Now push your repo again and you script will run from wwwroot (because your repo will be right there).


Update installation documentation page

There is a link to releases in the README.md that should be updated.

Should we move this one forward as is ?

I forgot about this one. I'll take a look later


Reorg. the different icon sets in the Status Help repo using folders

Completed. See diff https://github.com/status-im/help.status.im/compare/a6a7930..a58170f.
CC @exebeeche


g++ give errors.

Hİ Mertcan!
Well done, X is very nice programming language :) It's just wrong like this:
main() {
    const a int32 = 5;
    var b int32 = 25;
    outln(div(b, a));
}

div(x float64, y float64) float64 {
  ret x / y;
}

As a result, g++ reports incorrect encoding:

x.cxx: In function 'void _main()':
x.cxx:205:15: error: '_b_a' was not declared in this scope; did you mean '_b'?
205 |   _outln(_div(_b_a));
|               ^~~~
|               _b

Hi, thanks for your contribution. This bug belongs to expression builder.
Fixed with this commit: 3465083

I can confirm that it works after the fix, thanks :) Keep up the good work!


[Android] Comparing the New Database Framework  (SQL Delight) to Room Database in Android

Comparing the New Database Framework  (SQL Delight) to Room Database in Android
Proposed article introduction
In the world of mobile development, databases are often used for local data storage on client devices. One of the options for working with databases for Android projects is the Room library. The Room persistence library provides an abstraction layer over SQLite to allow fluent database access while harnessing the full power of SQLite.
On the other hand we have SQL Delight which is a cross platform SQL library that generates type-safe Kotlin APIs from SQL statements for various relational databases. SQL Delight also provides a multiplatform implementation of the SQLite driver.
It verifies your schema, statements, and migrations at compile-time and provides IDE features like autocomplete and refactoring which make writing and maintaining SQL simple.
In this article, we are going to dive into the strength and weakness of SQL Delight, also we will compare its performance, syntax and many more with the Room database.
Key takeaways

Understand what SQL Delight is and how it works.
Features of SQL Delight database.
Differences between SQL Delight with Room Database.
Advantages and disadvantages of SQL Delight.
Understand if SQL Delight is the right choice for multi-table databases with different types of relationships.

Article quality
The article will try and bring comparisons of both databases, it will be rich in unique content that will be good for beginner looking the right choice of a database to use in their projects. It will be clear sentences that are concise. Other than the theories, the article will contain some technical parts of implementing the SQL Delight database in Android.
References

SQL Delight Documentation.
Room Database Documentation.

Closed #5440 via #5912


stages/qemu: expose vpc options

Currently we hard code the vpc options subformat=fixed and force_size, which are needed to generate valid azure images with newer versions of qemu. But for other use cases or other versions of qemu these options might not be wanted or valid.
Expose all the options but with defaults corresponding to the old behavior.

LGMT.
Although it would be probably good to extend the qemu unit test in: https://github.com/osbuild/osbuild/blob/main/test/data/stages/qemu/checks.json https://github.com/osbuild/osbuild/blob/main/test/data/stages/qemu/qemu.mpp.json
I added this test case when I exposed VMDK-specific options:

Neat!
Do you remember the reason why the image.vpc has raw format there?
  "image.vpc": {
    "format": "raw"
  },

I will add the unit test.

Do you remember the reason why the image.vpc has raw format there?
  "image.vpc": {
    "format": "raw"
  },

This is what qemu-img info reports for the image... 🤷


Add vault config provider

@fibonacci1729 — would you mind expanding a bit on the context for this issue?
Thanks!

Spin supports a trait for accessing configuration dynamically when an application is running.
Currently, the only implementation is an environment provider that will fetch from the host the environment constant associated with a key.
For secrets and sensitive configuration managed outside the host environment (such as Vault) we could/should provide an implementation of the above trait to fetch dynamically from the secure host.


Working branch

On this project:

I have successfully configured the HTML & CSS Linters.
I have added a Readme file.
I have added Html and CSS files with content in it!
I have used Lenters for HTML & CSS.
I have also added .gitignore file and mentioned unwanted files to push( /node_modules & Test.md).

On this project:
I have successfully configured the HTML & CSS Linters.
I have added a Readme file.
I have added Html and CSS files with content in it!
I have used Lenters for HTML & CSS.
I have also added .gitignore file and mentioned unwanted files to push( /node_modules & Test.md).


When the undercloud vm is already running, quickstart fails

Just noticed that if the undercloud vm is already running (because of a previously failed job or for some whatever reason), the deployment bails out with:
TASK [setup/undercloud : start undercloud vm] **********************************
Thursday 03 March 2016  10:31:40 -0500 (0:00:00.516)       0:03:31.308 ********
failed: [host0] => (item={u'flavor': u'undercloud', u'name': u'undercloud'}) => {"failed": true, "item": {"flavor": "undercloud", "name": "undercloud"}, "msg": "Requested operation is not valid: domain is already running"}

That shouldn't happen if you use the libvirt/teardown role before the libvirt/setup role, and the quickstart.sh which runs quickstart.yml includes teardown.
Could you provide more details of how you hit this?

Oh I see, I think I was following one of the steps in Lars' blog and missed the teardown role. Thanks!


Install Stream-Deck Plugin

Hey Dan,
thank you for your entire contribution you do to the flutter and dart system. I'd like to develop a Stream Deck plugin. For that I created a dart project with that command: dart create -t console cli and added your package. Sadly, I can't get it to run. Would you be so kind and add the instructions or a link on how to run/build/get it to work?
I have also checked your samples, but with that i wasn't also be able to run it.
Kind Regards

It's not possible to just "run" a StreamDeck plugin, you need to install it.
I'll update the readme to make it clearer how to do this, but in the meantime you might want to check out:
https://github.com/DanTup/streamdeck.dart/blob/main/example/tool/macos_build_and_install.sh
Which is the script I use (on macOS) to build and install the plugin, and restart the StreamDeck software to pick it up.


Rename OPENSSL_CTX type  to OSSL_LIB_CTX

OpenSSL 3.0 introduces a lot of new type names starting with the OSSL_ prefix, e.g.
OSSL_CALLBACK, OSSL_PARAM, OSSL_ALGORITHM, OSSL_SERIALIZER, OSSL_DESERIALIZER, ...

In my opinion, the OPENSSL_CTX type deviates from this nice consistent naming scheme and should be renamed to OSSL_CONTEXT. (If you prefer brevity, an alternative name would be to rename it to OSSL_CTX, but that's only my second best choice.)
Changing the OPENSSL_CTX prefix affects many locations, but except for util/libcrypto.num and util/other.syms (which are treated specially), the change does not break indentation. You might also fear a lot of merge conflicts and think this might be a problem shortly before the beta1 release.
For that reason this change is fully automated by a script which is rerunnable. In fact, the bulk changes are four lines of bash code (see end of script). The idea is to run the script and merge the pull request as last commit, after all other commits for beta1 have been merged, and before the usual release commits.
I opened two draft pull requests as proof-of-concept, this one here renames the prefix to OSSL_CONTEXT, the other one (#12622) renames it to OSSL_CTX.
@openssl/otc, please let me know if you would accept such a renaming and which prefix you would prefer. In that case I would amend this PoC script with a more detailed commit message and NEWS and CHANGES entries, all fully automated.

I force-pushed updates, because I forgot to rename the corresponding prefixes in lower case letters.
#!/bin/bash

set -o errexit

# this script looks more complicated as it is, because it does some
# parameter checking and it can be rerun several times.
#
# The actual renaming consists of only the last four lines of code.
#
# Every time the script is run it will redo the changes at the current
# tip of the master branch.

FROM=$1
TO=$2

function usage () {
	cat  >& 2 <<EOF
usage: one of the following two commands
    ./rename-prefix OPENSSL_CTX OSSL_CTX
    ./rename-prefix OPENSSL_CTX OSSL_CONTEXT
EOF
	exit 1
}

case $FROM in
	OPENSSL_CTX)
		;;
	*)
		usage
		;;
esac

# add necessary padding manually (I had no ambitions to figure out the magic bash string calculations)
case $TO in
	OSSL_CTX)
		from_pad=''
		to_pad='   '
	;;
	OSSL_CONTEXT)
		from_pad=' '
		to_pad=''
		;;
	*)
		usage
esac

from=${FROM,,}
to=${TO,,}

branch=pr-rename-$FROM-to-$TO

# reuse existing branch or create a new one if it does not exist yet
if git show-ref --verify --quiet refs/heads/$branch; then
	git checkout $branch
	git reset --hard master
else
	git checkout -b $branch master
fi

#
# the renaming starts here
#

# treat util/libcrypto.num and util/other.syms specially, to get the alignment correct
git grep -l ${FROM} -- util/ | xargs sed -i -E "s/${FROM}([a-zA-Z0-9_]*)${from_pad}/${TO}\1${to_pad}/g"

# rename all the other prefixes, the capital letter and the small letter prefixes separately
git grep -il ${FROM} | xargs sed -i "s/${FROM}/${TO}/g;s/${from}/${to}/g"

# rename the only file which contains '${FROM}' in its file name
git mv doc/man3/${FROM}.pod doc/man3/OSSL_CTX.pod

# commit the changes
git commit -a -m "Rename ${FROM} prefix to ${TO}"

Update: after some discussion in our weekly meeting, it was decided to rename the OPENSSL_CTX type to OSSL_LIB_CTX. I am closing the other PoC PR and continue this PR with the changed name. Please review it like a normal PR, but rest assured that it will not be merged before the repository freeze for the beta release, in order to spare you of unecessary merge conflicts
The pull request consists of two commits, an automated commit and a manual fixup of the indentation errors caused by the renaming. The latter is automatically cherry-picked from a preexisting commit.  Here is the current version of the script,
rename-ossl-lib-ctx
#!/bin/bash

set -o errexit

# This script can be rerun several times. Every time the script is run
# it will redo the changes at the current tip of the master branch.

#
# The actual renaming consists of only the last four lines of code, which
# generate an automated commit. The second commit is a fixup for some
# indentation issues caused by the renaming. It is automatically
# cherry-picked by the script from a template commit which was created
# by me manually (see last line of code).
#

FROM=OPENSSL_CTX
TO=OSSL_LIB_CTX

from=openssl_ctx
to=ossl_lib_ctx

branch=pr-rename-ossl-lib-ctx
branch_start=master

# reuse existing branch or create a new one if it does not exist yet
if git show-ref --verify --quiet refs/heads/$branch; then
	git checkout $branch
	git reset --hard $branch_start
else
	git checkout -b $branch $branch_start
fi

#
# the renaming starts here
#

# treat util/libcrypto.num and util/other.syms specially, to get the alignment correct
git grep -l ${FROM} -- util/ | xargs sed -i -E "s/${FROM}([a-zA-Z0-9_]*) /${TO}\1/g"

# rename all the other prefixes, the capital letter and the small letter prefixes separately
git grep -il ${FROM} | xargs sed -i "s/${FROM}/${TO}/g;s/${from}/${to}/g"

# rename the only file which contains '${FROM}' in its file name
git mv doc/man3/${FROM}.pod doc/man3/${TO}.pod

# commit the changes
git commit -a -F - <<EOF
Rename ${FROM} prefix to ${TO}

Many of the new types introduced by OpenSSL 3.0 have an OSSL_ prefix,
e.g., OSSL_CALLBACK, OSSL_PARAM, OSSL_ALGORITHM, OSSL_SERIALIZER.

The OPENSSL_CTX type stands out a little by using a different prefix.
For consistency reasons, this type is renamed to OSSL_LIB_CTX.
EOF

# cherry-pick the indentation fixups
git cherry-pick f753a8ae96c941b6c2f63d969e84297da40a2d56

@paulidale to find the indentation problems which you pointed out systematically, I searched the output of
git show 71d3e39caa8bd3990271ee91aabe452de07eed92

in the less pager as follows: I turned off case sensitivity (by typing -i) and then searched for functions with multiline argument lists, i.e., for identifiers which are followed by an opening but not a closing brace, like this:  /ossl_lib_ctx.*\([^)]+$

Did you also check for lines of length >80?
This catches some: `find . -name '*.[ch]' | xargs grep -l OSSL_LIB_CTX | xargs egrep '^.{81}', it misses multiline argument lists that get too long.

I'm surprised no one thought of CRYPTO_CTX, considering which library is at the center of this.
Personally, I find the LIB bit redundant.

CRYPTO_ isn't OSSL_ or OPENSSL_ 😃

The Travis failures are relevant.

The Travis failures are relevant.

Fixed by renaming doc/internal/man3/{openssl_ctx_get_data.pod => ossl_lib_ctx_get_data.pod}.

Did you also check for lines of length >80?
This catches some: `find . -name '*.[ch]' | xargs grep -l OSSL_LIB_CTX | xargs egrep '^.{81}', it misses multiline argument lists that get too long.

Hmmm... my renaming only added one byte to the name. I had hoped to find less locations.
$ find . -name '*.[ch]' | xargs grep -l OSSL_LIB_CTX | xargs egrep -n '^.{81}' | grep -i OSSL_LIB_CTX | wc  -l
33

Interestingly, it seems that fifteen of those overlong lines already exceeded the line limit before my change ;-)
$ git checkout master

$ find . -name '*.[ch]' | xargs grep -l OPENSSL_CTX | xargs egrep -n '^.{81}' | grep -i OPENSSL_CTX | wc  -l
15

But oh well, I'll try to fix them up...

But oh well, I'll try to fix them up...

@mspncp, efore you do:
I fully agree with @levitte:

I find the LIB bit redundant.

Ff the name gets changed to OSSL_CTX there would be no need to break up lines :)

I'm surprised no one thought of CRYPTO_CTX, considering which library is at the center of this.

I like this one as well, not only because this is a bit shorter than OPENSSL_CTX
but mostly because it refers to the context of the crypto lib, not of OpenSSL as a whole, right?

BTW, from time to time I think: ugh, the "SSL" portion of the project name "OpenSSL" is pretty outdated meanwhile.
A pity that the project name had been tied closely to that piece of technology and would be very hard to change,
and for instance "OpenSec", which would be to-the-point and more convenient to pronounce, is already taken.

I fully agree with @levitte:

I find the LIB bit redundant.

If the name gets changed to OSSL_CTX there would be no need to break up lines :)

OSSL_CTX was one of the two initial suggestions, see #12622. But someone (was it @mattcaswell?) disliked it, so we went for OSSL_LIB_CTX. I don't mind changing it once more, provided the team finds a consensus within the next two or three days.

BTW, from time to time I think: ugh, the "SSL" portion of the project name "OpenSSL" is pretty outdated meanwhile.
A pity that the project name had been tied closely to that piece of technology and would be very hard to change,
and for instance "OpenSec", which would be to-the-point and more convenient to pronounce, is already taken.

Please let's not open up this can of worms again. ;-)

It sounds like we might need a vote.  OTC level should suffice.

Perhaps a discussion before and possibly instead of a vote.  Votes can't pick between three or more options.

Rebased without further changes, just to verify that the automated rebase over conflicts is as simple as expected.

There was an internal Doodle poll to figure out the name which would get most consent from the team members. The favourite candidate was OSSL_LIB_CTX, so I'll raise an OTC vote for accepting this pull request.

Second force-push was an automated rebase without changes, to fix the conflicts. Next step will be to fix the overlong lines.

A single overlong line (81 chars) remains. I could break it after the cast, but that doesn't really make it better IMHO. So I just left it as it is.
https://github.com/openssl/openssl/blob/801ce87969f24bd81a7d34f154a988799fc6e628/providers/fips/fipsprov.c#L714-L715

Ready for review.

Looks good. The vote needs to finish before merging.

Thank you @paulidale. Even after the vote has passed, I won't merge this pull request myself, because this will be done by @mattcaswell as last merge before the release, when the repository is already locked.

Regardless of your approval, I will run an automated rebase every now and then to ensure that no problems are introduced by new commits on master.

Are the scripts to change ERRxxx to the new "raise" API also going to be run?  https://github.com/openssl/openssl/pull/9441

Are the scripts to change ERRxxx to the new "raise" API also going to be run? #9441

I have it on my TODO bucket list, but not before beta release

Are the scripts to change ERRxxx to the new "raise" API also going to be run? #9441

Uhm... I don't understand your question. I'm not familiar with the details of #9441, how are those scripts related to my pull request? Is there anything I need to be careful about?

There is nothing for you to worry about.  Just that since "Matt is going to do the renaming just before beta" I wanted to remind folks that there's another API renaming that should happen, too.  And is similarly scripted.

@richsalz, you don't need to repeat that every so often. It's in my to-do. But, since that's not a change of public parts, it's not necessary to do the ERR_raise change quite so soon (and thereby take away energy from things that do change public parts)

Until it happens, there is always the risk that it ends up not happening. :)

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

The OTC vote has been closed, see openssl-project.
I'm not going to set the 'approval: ready to merge' state, because @mattcaswell will merge it during the freeze.
Also, I'm going to auto-rebase this pull request once more in any case after #11808 has been merged.

The last force-push has no tree changes. The last fixup did not autosquash cleanly. I had to split it up into two fixups for different commits.

The only delta between OSSL_LIB_CTX and OSSL_LIBCTX in the doodle were you (@mspncp) and @mattcaswell - in light of the new data you seem to have been convinced already, maybe it's also enough for @mattcaswell (c.f. for example ..._with_lib_ctx vs. ..._with_libctx)?
Certainly, achieving full consistency in the spellings would IMO be a high-enough reward to bite the bullet of one last adaptation (especially as this PR would be ready to pull the trigger).

The only delta between OSSL_LIB_CTX and OSSL_LIBCTX in the doodle were you (@mspncp) and @mattcaswell - in light of the new data you seem to have been convinced already, maybe it's also enough for @mattcaswell (c.f. for example ..._with_lib_ctx vs. ..._with_libctx)?
Certainly, achieving full consistency in the spellings would IMO be a high-enough reward to bite the bullet of one last adaptation (especially as this PR would be ready to pull the trigger).

I'm a little bit reluctant to restart the discussion with the @openssl/otc, since the beta release is approaching quickly. Personally, I can live with the two different spellings, because the former is used consistently for the type name and the latter for variables of this type.

For the records: this is the current version of the script which I am using to automatically rebase the changes:
#!/bin/bash

set -o errexit

# This script can be rerun several times. Every time the script is run
# it will redo the changes at the current tip of the master branch.
#
# The first two commits are autogenerated.
#
# - The first commit renames OPENSSL_CTX -> OSSL_LIB_CTX
# - The second commit renames 'library_context' and 'lib_ctx' to 'libctx'
#
# The other commits are manual fixups.
#
# The script attempts to rebase the manual fixups automatically on top
# of the two autogenerated commits. If the rebase fails, you can try to
# resolve the conflicts as for a normal rebase (e.g., using `git mergetool)`,
# or you can abort the rebase using `git rebase --abort`, in which case you
# end up where the script started.

FROM=OPENSSL_CTX
TO=OSSL_LIB_CTX

from=${FROM,,}
to=${TO,,}

# The name of the topic branch for pull request #12621; the script expects that this branch exists.
#
# Actually, the branch name is misleading, but it can't be changed anymore.
branch=pr-rename-OPENSSL_CTX-to-OSSL_CONTEXT

# the upstream branch: you can set it to master or origin/master, as you prefer
upstream=master

# remember the last autogenerated commit before the manual fixups
fixup_base=$(git log --reverse --oneline --no-decorate ${upstream}..${branch} | grep -v 'fixup!' | tail -1 |  cut -d ' ' -f 1)

# checkout the upstream branch in detached state (i.e., use HEAD as an unnamed temporary branch)
git checkout --detach $upstream

#
# COMMIT 1: the bulk renaming starts here
#

# treat util/libcrypto.num and util/other.syms specially, to get the alignment correct
git grep -l ${FROM} -- util/ | xargs sed -i -E "s/${FROM}([a-zA-Z0-9_]*) /${TO}\1/g"

# rename all the other prefixes, the capital letter and the small letter prefixes separately
git grep -il ${FROM} | xargs sed -i "s/${FROM}/${TO}/g;s/${from}/${to}/g"

# rename the only file which contains '${FROM}' in its file name
git mv doc/man3/${FROM}.pod doc/man3/${TO}.pod

# rename the only file which contains '${from}' in its file name
git mv doc/internal/man3/${from}_get_data.pod doc/internal/man3/${to}_get_data.pod

# commit the changes
git commit -a -F - <<EOF
Rename ${FROM} prefix to ${TO}

Many of the new types introduced by OpenSSL 3.0 have an OSSL_ prefix,
e.g., OSSL_CALLBACK, OSSL_PARAM, OSSL_ALGORITHM, OSSL_SERIALIZER.

The OPENSSL_CTX type stands out a little by using a different prefix.
For consistency reasons, this type is renamed to OSSL_LIB_CTX.
EOF

#
# COMMIT 2: more bulk renaming
#

FROM=_LIBRARY_CONTEXT
TO=_LIBCTX

from=${FROM,,}
to=${TO,,}

git grep -il ${FROM} | xargs sed -i "s/${FROM}/${TO}/g;s/${from}/${to}/g"

FROM=ET_LIB_CTX
TO=ET_LIBCTX

from=${FROM,,}
to=${TO,,}

git grep -il ${FROM} | xargs sed -i "s/${FROM}/${TO}/g;s/${from}/${to}/g"

# commit the changes
git commit -a -F - <<EOF
Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx'

This change makes the naming more consistent, because three different terms
were used for the same thing. (The term libctx was used by far most often.)
EOF

#
# FIXUPS
#

if [ -n "${fixup_base}" ] ; then

	echo "Rebasing the fixups"
	git show -s --oneline --no-decorate ${fixup_base}..${branch}
	echo "onto the automated commit"
	git show -s --oneline --no-decorate HEAD

	# rebase them onto the last automated commit, which is at the detached HEAD
	git rebase --onto HEAD ${fixup_base} ${branch}
fi

Last force-push was a fully automated rebase to resolve conflicts without further changes.

I have to say I like the PR as is. I would not go further dropping the underscore from the OSSL_LIB_CTX as having the underscore dropped between lib and ctx in the variable names makes sense because the variable names are usually more abbreviated than types or function names. And the function names using _with_libctx actually refer to the parameter variable name libctx, so that is also in some way consistent.

Automated rebase to fix conflicts. Added a single new fixup to shorten an overlong line (42f93d2).

The last force-push has no tree changes. I simply collected all fixups for 7c3dc810bee71537364f29d014bb2899e317850d into a single fixup.

Since GitHub does not report any new conflicts yet, I won't run the script to rebase.

Last force-push was an automated rebase. There were two trivial conflicts in my manual fixups (which added linebreaks to overlong lines). The conflicts could be resolved trivially by discarding my fixups.
diff --cc crypto/evp/evp_pkey.c
index 81f3a12c27,ed3294eadc..0000000000
--- a/crypto/evp/evp_pkey.c
+++ b/crypto/evp/evp_pkey.c
@@@ -18,8 -18,9 +18,17 @@@

  /* Extract a private key from a PKCS8 structure */

++<<<<<<< HEAD
 +EVP_PKEY *EVP_PKCS82PKEY_with_libctx(const PKCS8_PRIV_KEY_INFO *p8,
 +                                     OSSL_LIB_CTX *libctx, const char *propq)
++||||||| parent of 28b8bc7cfb... fixup! Rename OPENSSL_CTX prefix to OSSL_LIB_CTX
++EVP_PKEY *evp_pkcs82pkey_int(const PKCS8_PRIV_KEY_INFO *p8, OSSL_LIB_CTX *libctx,
++                             const char *propq)
++=======
+ EVP_PKEY *evp_pkcs82pkey_int(const PKCS8_PRIV_KEY_INFO *p8,
+                              OSSL_LIB_CTX *libctx,
+                              const char *propq)
++>>>>>>> 28b8bc7cfb... fixup! Rename OPENSSL_CTX prefix to OSSL_LIB_CTX
  {
      EVP_PKEY *pkey = NULL;
      const ASN1_OBJECT *algoid;
diff --cc include/crypto/evp.h
index 46754ee04f,d8627f4464..0000000000
--- a/include/crypto/evp.h
+++ b/include/crypto/evp.h
@@@ -763,6 -765,9 +765,15 @@@ int pkcs5_pbkdf2_hmac_with_libctx(cons
  int evp_pkey_ctx_set_params_strict(EVP_PKEY_CTX *ctx, OSSL_PARAM *params);
  int evp_pkey_ctx_get_params_strict(EVP_PKEY_CTX *ctx, OSSL_PARAM *params);

++<<<<<<< HEAD
++||||||| parent of 28b8bc7cfb... fixup! Rename OPENSSL_CTX prefix to OSSL_LIB_CTX
++EVP_PKEY *evp_pkcs82pkey_int(const PKCS8_PRIV_KEY_INFO *p8, OSSL_LIB_CTX *libctx,
++                             const char *propq);
++=======
+ EVP_PKEY *evp_pkcs82pkey_int(const PKCS8_PRIV_KEY_INFO *p8,
+                              OSSL_LIB_CTX *libctx,
+                              const char *propq);
++>>>>>>> 28b8bc7cfb... fixup! Rename OPENSSL_CTX prefix to OSSL_LIB_CTX
  EVP_MD_CTX *evp_md_ctx_new_with_libctx(EVP_PKEY *pkey,
                                         const ASN1_OCTET_STRING *id,
                                         OSSL_LIB_CTX *libctx, const char *propq);

Last force-push was 100% automated. @paulidale, the pull request seems to be in a stable state, automatic rebases are clean. It might be a good moment to reapprove.

Thanks @paulidale!
BTW: is it only me who has the impression that GitHub has a tendency towards showing the number 42 (in seconds or minutes) when it diplays the elapsed time? Or is that just conspiracy theory?

Perception bias I expect 😀

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Last force-push was a fully automated rebase to resolve conflicts. No re-review required.
~/src/openssl$ ./rename-ossl-lib-ctx
HEAD is now at 35e6ea3bdc keygen: add FIPS error state management to conditional self tests
Your branch is up to date with 'origin/master'.
[detached HEAD eac23845ee] Rename OPENSSL_CTX prefix to OSSL_LIB_CTX
368 files changed, 1340 insertions(+), 1340 deletions(-)
rename doc/internal/man3/{openssl_ctx_get_data.pod => ossl_lib_ctx_get_data.pod} (63%)
rename doc/man3/{OPENSSL_CTX.pod => OSSL_LIB_CTX.pod} (60%)
[detached HEAD 7368cd25e9] Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx'
67 files changed, 132 insertions(+), 132 deletions(-)
Rebasing the fixups
ab8e5c09a5 fixup! Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx'
5fb9031157 fixup! Rename OPENSSL_CTX prefix to OSSL_LIB_CTX
onto the automated commit
7368cd25e9 Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx'
Successfully rebased and updated refs/heads/pr-rename-OPENSSL_CTX-to-OSSL_CONTEXT.

Last force-push was just the usual automated rebase to resolve conflicts. Nothing special to report.

TODO (note to self):
The OpenSSL 3.0 Wiki Page needs to be updated (OPENSSL_CTX -> OSSL_LIB_CTX) when this pull request gets merged (shortly before the beta release).

I preponed the replacement, that makes one thing less to forget during the thrust of the beta release. To avoid confusion, I added the following note to the Library Contexts section, together with a link to the older version of the wiki page:

Note: In alpha releases of OpenSSL 3.0.0, the OSSL_LIB_CTX was called OPENSSL_CTX. It was renamed for OpenSSL 3.0.0 beta1. If you are still using an alpha release, take a look at this older version of the wiki page.'

Last force-push was an almost fully automated rebase. The only merge-conflict was caused by a whitespace change (alignent) and easy to resolve. No re-review required.

Fully automated rebase.

Fully automated rebase.

Once again.

Automated rebase, one trivial whitespace conflict.

Automated rebase to pick up #12970.  It's doable, but the constant rebasing is starting to become a nuisance. How about putting an end to it and merge this pull request @openssl/otc?
Unmerged paths:
  (use "git restore --staged <file>..." to unstage)
  (use "git add <file>..." to mark resolution)
	both modified:   crypto/cms/cms_smime.c
	both modified:   crypto/ct/ct_log.c
	both modified:   crypto/x509/x509_d2.c
	both modified:   include/openssl/conf.h.in
	both modified:   include/openssl/ct.h.in
	both modified:   include/openssl/ec.h
	both modified:   include/openssl/x509_vfy.h.in

I would agree with merging this asap!

In view of the upcoming alpha release I did another automated rebase. All conflicts could be resolved by discarding the incoming changes (from this pr).
both modified:   crypto/ffc/ffc_params_validate.c
both modified:   include/internal/ffc.h

@mattcaswell,
I will try to be around to do an automated rebase of this pull request on your demand while the repository is locked for the release. Just in case I'm not available, here's a link to the rename-ossl-lib-ctx.sh script and a brief instruction about how the script works and what to do in the case of conflicts:
 HEAD-> fixup! Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx'
        fixup! Rename OPENSSL_CTX prefix to OSSL_LIB_CTX
        Rename some occurrences of 'library_context' and 'lib_ctx' to 'libctx'
        Rename OPENSSL_CTX prefix to OSSL_LIB_CTX

The first two commits (from bottom up) are completely autogenerated (see COMMIT 1 and COMMIT 2. The fixup! commits were initially created manually, but are rebased automatically by the script onto the first two commits (see FIPUPS). The fixups mostly contain whitespace fixes (e.g. shorten overlong lines). If you end up with a merge conflict, it will always be in the manual fixups and very often the incoming changes (from the pr branch) can simply be discarded.
More precisely, COMMITS 1 and 2 are applied in detached HEAD state onto $upstream (which defaults to master), after which the !fixup commits are rebased from the pull request branch onto the new automated commits. This trick has the advantage that in case of conflicts you can resolve them just as if you were doing an ordinary rebase. In particular, you can call git rebase --abort and rerun the script if something get's messed up.
Note: You might want to change line 35 to upstream=origin/master, then it will be sufficient to do a git fetch --all (instead of explicitly updating your local master branch) in order to pick up new changes from the remote master branch.
Regards,
Matthias

Thanks @mspncp!

Oh, and don't forget to do a git rebase -i --autosquash at the very end before merging to master. :-)

Last force-push was a fully automated rebase.

Also this is going to need another rebase after #13088 goes in, which I'd also like in the alpha today.

Also this is going to need another rebase after #13088 goes in, which I'd also like in the alpha today.

...and I just pushed it.

Congratulations @romen, you did it!
@mattcaswell, I talked with Nicola and he will take care of rebasing the pull request, because I will be in a meeting. If something unexpected happens, he can ping me.

Thanks @mspncp !
Last force-push included first new fixup! commits to address @mattcaswell's feedback, then a fully automated rebase using @mspncp script, on top of 29000e43ea257bf54f6ccb2064b3744853b821b2 (latest master, after merging #13088)

@nicola or @mattcaswell can please reset the author to my name?

It wouldn't be fair if Nicola would get the credits ;-)

@mspncp - will do so during the merge

Ok, thanks!

@nicola or @mattcaswell can please reset the author to my name?

Good catch, I totally overlooked what was happening to authorship of the generated commits!!
Thanks!!

It wouldn't be fair if Nicola would get the credits ;-)

You got me, I totally planned to swoop in at the very last minute after you authored and baby-sitted this PR for months!!!
Once again, my plans for wold domination have been thwarted!!

Pushed! Thanks all, and especially @mspncp. I corrected @romen's dastardly attempt to steal the glory during the merge.

I am not the nicola you are looking for :)

@nicola said:

I am not the nicola you are looking for :)

Once again, they are onto me: I can't even shift the blame to my homonyms!
Sorry for the noise @nicola, you were an innocent victim of my nefarious schemes!

Sorry for the noise @nicola, you were an innocent victim of my nefarious schemes!

Hi @nicola! I'm impressed to meet a person who managed to grab his first name as GitHub user name. :-)

BTW, did you know @romen that it's actually not necessary to setup authorship by providing those two environment variables in full detail, if you are setting authorship of somebody who has already committed to the repository?
If you use the --author command line argument, you can provide a fuzzy argument, because Git will be very smart at completing the information by searching the commit log.
~/src/openssl$ git commit -a -m 'Hi' --author=Nicola
[hi-nicola e99cf2b4bf] Hi
 Author: Nicola Tuveri<EMAIL_ADDRESS> 1 file changed, 1 insertion(+)

So the next time you intend to steal credits, it will be even easier ;-).

That is great! I knew it was possible to use --author but I had no idea about this capability!!

Well, it was my laziness which made me simply try it out.

Just looked it up in git-commit, it’s officially documented behavior.


[feature request] Compile bitwise operators into Lua BitOp functions calls

For Lua versions below 5.3, bitwise operators aren't supported. However, their behavior can be substituted using the Lua BitOp library. This library is also included by default with LuaJIT. My suggestion would be to add a boolean argument to the compiler, perhaps a --use-bit-lib (which is what Fennel also uses). In practice, it could compile the code:
bit_or = (x, y) ->
    x | y

into this:
_bitop_0 = require("bit")
local bit_or
bit_or = function(x, y)
    return _bitop_0.bor(x, y)
end

Additionally, the floor division operator x // y could be compiled to math.floor(x / y).

An alternative might be to allow choosing the bit library, as Lua 5.2 includes the "bit32" library by default.


redis: prefixed routing

Second take on https://github.com/envoyproxy/envoy/pull/5658. During one of the iterations in the original PR, I actually forgot to short circuit when a route matches. I've updated the tests in https://github.com/envoyproxy/envoy/commit/41d9b4dd0de4cf1c6d4d2cdf12da8998dbddad03 to confirm that they actually short circuit correctly.
I'm opening the PR, but @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg wanted to work on an integration test, I would wait for that integration test before merging this PR again.
Description: Add redis prefix routing.
Risk Level: Medium
Testing: Updated unit tests.
Docs Changes: N/A, revert of #5658.
Release Notes: N/A, revert of #5658.

Yeah let's finish review of https://github.com/envoyproxy/envoy/pull/6294 first and wait to get an integration test in before we work on this.


Fail to nxtask_delete by update of cancel point logic

This pull request https://github.com/apache/nuttx/pull/11165 causes the task to fail to delete.
There is a gnss sensor driver, which creates a task with open() and deletes it with close().
nuttx/boards/arm/cxd56xx/drivers/sensors/cxd5610_gnss.c
open()
 -> cxd5610_gnss_open()
  -> cxd5610_gnss_initialize()
   -> task_spawn()

close()
 -> cxd5610_gnss_close()
  -> cxd5610_gnss_finalize()
   -> nxtask_delete()

In nxtask_delete() function, nxnotify_cancellation() returns true and nxtask_terminate() is not executed.
https://github.com/apache/nuttx/blob/11b3adf17fd4e252d880bd9f4dcab54e42e990fe/sched/task/task_delete.c#L123-L134
In nxnotify_cancellation() function, the cancellation is pending under the following conditions.
https://github.com/apache/nuttx/blob/11b3adf17fd4e252d880bd9f4dcab54e42e990fe/sched/task/task_cancelpt.c#L106-L127
This was correctly deleting tasks before the pull request https://github.com/apache/nuttx/pull/11165.
I would appreciate any advice.
Thanks.

@SPRESENSE sorry about the regression..
Yes, I'll start looking immediately. I can not find an example config with the sensor SENSORS_CXD5610_GNSS enabled, so a  few questions:

Do you use cancellation points, i.e. CONFIG_CANCELLATION_POINTS=y ?
Do you define / use up_tls_info() or can you imagine a reason why FAR struct tls_info_s *tls = tls_get_info_pid(tcb->pid); could fail in this case

The only situation where I can imagine that condition fails, is if the tls points to the wrong task OR the tls is corrupt (stack overflow).

One last thing that comes to mind, my assumption was that the stack frame created for TLS is memset to 0 always
int tls_init_info(FAR struct tcb_s *tcb)
{
  FAR struct tls_info_s *info;

  /* Allocate thread local storage */

  info = up_stack_frame(tcb, tls_info_size());
  if (info == NULL)
    {
      return -ENOMEM;
    }

  DEBUGASSERT(info == tcb->stack_alloc_ptr);

  /* Initialize thread local storage */

  up_tls_initialize(info);

  /* Attach per-task info in group to TLS */

  info->tl_task = tcb->group->tg_info;
  return OK;
}

struct tls_info_s
{
  FAR struct task_info_s * tl_task;

#if defined(CONFIG_TLS_NELEM) && CONFIG_TLS_NELEM > 0
  uintptr_t tl_elem[CONFIG_TLS_NELEM]; /* TLS elements */
#endif

#if defined(CONFIG_PTHREAD_CLEANUP_STACKSIZE) && CONFIG_PTHREAD_CLEANUP_STACKSIZE > 0
  /* tl_tos   - The index to the next available entry at the top of the
   *            stack.
   * tl_stack - The pre-allocated clean-up stack memory.
   */

  uint8_t tl_tos;
  struct pthread_cleanup_s tl_stack[CONFIG_PTHREAD_CLEANUP_STACKSIZE];
#endif

  uint8_t tl_cpstate;                  /* Cancellation state */

#ifdef CONFIG_CANCELLATION_POINTS
  int16_t tl_cpcount;                  /* Nested cancellation point count */
#endif

  int tl_errno;                        /* Per-thread error number */
};

However, if this is not the case, and tl_cpstate is not set / memset to 0, you will get undefined behavior.

@pussuw Thanks for your investigation.
My conditions are:

CONFIG_CANCELLATION_POINTS=n
CONFIG_SCHED_THREAD_LOCAL=n

I found that nxsched_get_stackinfo() called from tls_get_info_pid() returned -EACCESS.
https://github.com/apache/nuttx/blob/eddd90de7865be7bb67217c9d7a3c68c85f1590b/sched/sched/sched_get_stackinfo.c#L86-L98
This may be caused that the task is created by task_spawn() with open().
However, when the task was created by kthread_create() instead of task_spawn(), it was not possible to delete the task from the application with close().
It used to work this way of implementation, any advice on how to implement it?

Hi @SPRESENSE funnily enough, I found this exact line myself just 5 seconds ago :)
I will think of a patch to fix this. The security test (groups are equal) does not make sense in this case, since it is the KERNEL that is asking for the TLS entry, not the user. The kernel should always get access to it.
I had not thought of this security test, I presumed nxsched_get_stackinfo would just give any TLS to me...

Once the regression is patched I must think if this "peeking to another process's stack" is a security concern which requires re-designing how nxnotify_cancellation is handled.
But that is irrelevant for fixing the regression and I will fix it later.

@SPRESENSE
This should fix your issue https://github.com/apache/nuttx/pull/11241/
Sorry about the regression, did not test it well enough..

@pussuw
I could confirm that this issue was fixed by https://github.com/apache/nuttx/pull/11241.

Close as completed.


Unbound DNS as a feature request!

Ahoj, sousede!
We rescently talk and you promised to include Unbound DNS to pair with Pi-Hole and TechDNS.
Assume this as an official feature request.
Nice project, though.

Hey mister Greg!
Will be later this week, probably.


Potential bug in legacy h5 weights loading.

This may be working as intended, in which case feel free to close this issue.
There is a difference in top_level_model_weights loading between the functions load_weights_from_hdf5_group_by_name and load_weights_from_hdf5_group_by
Specifically, the load_weights_from_hdf5_group_by_name collects symbolic weights using the following code:
symbolic_weights = model.trainable_weights + model.non_trainable_weights

https://github.com/keras-team/keras/blob/da83683f5e92fa24a0ad7bf5dc034ea596346d21/keras/src/legacy/saving/legacy_h5_format.py#L485
In my usecase this returns 200 weights
Meanwhile,  load_weights_from_hdf5_group collects symbolic weights using the following code:
        symbolic_weights = list(
            # model.weights
            v
            for v in model._trainable_variables + model._non_trainable_variables
            if v in model.weights
        )

https://github.com/keras-team/keras/blob/da83683f5e92fa24a0ad7bf5dc034ea596346d21/keras/src/legacy/saving/legacy_h5_format.py#L379
In my usecase this returns 0 weights (in fact  model._trainable_variables + model._non_trainable_variables returns 0 weights even without filtering for variables within model.weights
I would expect both of these loading methodologies to return the same number of symbolic weights, but this is clearly not the case
I suspect that by_name is incorrect whilst the alternative is correct, but cannot be sure.

Hi @torzdf ,
Thanks for reporting. It would be appreciated if you can submit a code snippet for reproducing the error.

Hi @torzdf ,
Thanks for reporting. It would be appreciated if you can submit a code snippet for reproducing the error.

Not straightforward, as I discovered this by injecting print statements at the above linked locations.
Either way, I have demonstrated where the code diverges, The difference is clear to see from the different variables that are used to collect the symbolic weights.

i can confirm this bug occurs in tensorflow 2.16 for models created saved and loaded on that version with the h5 format


[M] UIs for edit record - change park ID status to repealed

As a data register data admin I need to be able to change the legal name status to repealed when a new order in council comes through, while also preserving the previous legal name data as historical data.
Acceptance Criteria:
Matches the designs and specs attached (UI numbers - <IP_ADDRESS>)
User experience:

User can add a repealed date (the date the repeal went through)

User can add notes (will be added in a later ticket)

User can preview changes

User can save changes

User sees a success or fail toast

View record view will display as a repealed view (1.1b View Record - Repealed)

Backend:

System will change protected area status to Repealed
Repealed date is stored
The rest of the record is preserved in the same state as it was (there will be exactly 1 legal name, plus 0-infinity historical names)
New notes are added to the notes data (will be added later)

Designs:
Designs are approved
Edit record - repeal
Notes:

status documentation: https://github.com/bcgov/parks-data-register/blob/main/pdr-api/docs/park-name-status.svg

This is not MVP. @JLWade @ashleydhillon

in blocked for designs changes and updates to #147

blocked by design changes

workflows requested for the Repeal a protected area name process

Added flow diagram to ticket. View the original here; https://www.figma.com/file/NFiJiHQY59lts0ozfafkSg/Data-Register-Flow-Diagrams?type=whiteboard&node-id=0%3A1&t=9DroP9UGN9ATcaUB-1

Updated and ready to go @danieltruong

Verified that the functionality has been implemented but comprehensive testing will be covered when https://github.com/bcgov/parks-data-register/issues/294 is ready for QA


fix(BlurView): Add PropTypes to viewRef according docs

viewRef is only required in the Android platform.

I wonder, where in the source is that actually used? I can't seem to find any reference to viewRef in the source (anymore).


pangolin error

Hi there,
I just did a fresh install of the ncov-tools environment and there appears to be an issue with pangolin. I was running a  all_final_report and got the following error 2021-06-25T192934.968980.snakemake.log:
TypeError: can't pickle _thread.RLock objects
[Fri Jun 25 19:28:28 2021]
Error in rule make_lineage_assignments:
jobid: 10
output: lineages/C30_lineage_report.csv
shell:
pangolin --outfile lineages/C30_lineage_report.csv qc_analysis/C30_consensus.fasta
(one of the commands exited with non-zero exit code; note that snakemake uses bash strict mode!)
I ran the pangolin command in isolation in the same environment and got the same error. I then switched to another conda env with pangolin and was able to successfully generate a lineage-report from the same fasta. Any thoughts on what the issue is?

Hi Daniel,
I re-created my conda environment and ran ncov-tools with the latest versions of packages and ran it on both Illumina and ONT datasets but am unable to reproduce this issue.  Is the version of pangolin, scorpio, and pangoLEARN different between the two conda environments you were using?  I currently have:
pangolin 3.1.5
pangoLEARN 2021-06-15
scorpio 0.3.4

Cheers,
Richard

Hi @rdeborja,
Thanks for looking into this. I stupidly deleted my working ncov-qc environment. Have recreated it multiple times, but keep getting the same error. When I compare 'pangolin' / 'scorpio' between my 'pangolin' env (works perfectly) and my 'ncov-tools' env, they are identical to yours.
I looked closer during the environment creation and saw these errors:
SafetyError: The package for snpeff located at /home/dan/miniconda3/pkgs/snpeff-5.0-hdfd78af_1
appears to be corrupted. The path 'share/snpeff-5.0-1/snpEff.config'
has an incorrect size.
  reported size: 10773532 bytes
  actual size: 10773563 bytes

ClobberError: This transaction has incompatible packages due to a shared path.
  packages: defaults/linux-64::tbb-2020.3-hfd86e86_0, bioconda/linux-64::usher-0.3.2-h7b4d82f_0
  path: 'lib/libtbbmalloc.so.2'

ClobberError: This transaction has incompatible packages due to a shared path.
  packages: defaults/linux-64::tbb-2020.3-hfd86e86_0, bioconda/linux-64::usher-0.3.2-h7b4d82f_0
  path: 'lib/libtbbmalloc_proxy.so.2'

I then did 'conda clean -a' and recreated the environment without any errors. Am really confused about this. Any other ideas on how to troubleshoot it?

Ok this is clearly a install-specific issue as everything worked perfectly on another computer. After removing and reinstalling the env > 10 times, am unsure what else to do. Apologies - understand this isn't your problem, but if anyone has any suggestions or pointers, I am all ears!

Thanks for letting me know @danieljbridges.  I was frantically re-installing ncov-tools and pangolin separately on various platforms but have not been able to reproduce the issue.  I did encounter the same SafetyError and ClobberError but attributed it to a package caching error not associated with the issue running pangolin.

Hi Daniel - I had a similar error coming up in ncov-tools regarding snpEff. As with your case, it happened after I re-created our ncov-tools environment. Based on the error message, it was tracing back to an install of snpEff within a separate conda environment that we use (mamba-signal - https://github.com/jaleezyy/covid-19-signal). Recreating this mamba-signal environment as well cleared the snpEff safety error. Is your version of snpEff in a specific environment, or in your base environment? It might be a matter of either uninstalling or updating a conflicting version of snpEff that's located somewhere else on your system?

Thanks all for your help and suggestions. I found out there were some pangolin packages in the base folder that appeared to be interfere with the ncov-qc environment... Everything is working well now....


Application Settings enabled_git_access_protocol cannot be set to null

The enabled_git_access_protocol field in the settings API supports enabling all protocols by setting the field to null, e.g.:
curl -X PUT --header "PRIVATE-TOKEN: $GITLAB_ACCESS_TOKEN" http://localhost:8080/api/v4/application/settings --header 'Content-Type: application/json' --data  '{"enabled_git_access_protocol": null}'

However, that is currently not possible, because the json tag contains omitempty and there is no special marshaller for it.
There are currently provider users facing this issue.

I could be wrong here, but I feel like this is fairly simple to change by removing the omitempty tag for this field.
https://github.com/xanzy/go-gitlab/blob/master/settings.go#L521

If you do that, you will need to actively set the field every time you want to change a setting. Even if you do not want to change the enabled_git_access_protocol but only some other setting. I think that would be very unexpected behavior for users of this lib.

Hmm that does make this a bit tricky to fix. I can see that being an annoying behavior as well if all of a sudden users need to set ssh or http if it was reverted to nil from removing the omitempty tag, and now their project allows both protocols.
Thoughts on a special marshaller for the UpdateSettings struct and if the value == "nil", then marshal  enabled_git_access_protocol into null. Or if you have other ideas on how to fix this, I'd be happy to get it done.


[TEST] Token generation and metadata endpoints

Sweet LGTM

Let's add Travis CI so our shiny new tests can run on all pull requests.

I see 1 +1s from . Ready to merge.

The build is good and I'm seeing 1 +1s from the following folks:

stevenzeiler

As such, I'll attempt to merge and close this pull request.


4.0.4 mjml-cli assumes file path without extension is a directory

To help us help you, provide as much information as you can. You'll find below a template you can use to submit your issue, but feel free to remove any part that wouldn't be relevant here.
I have a compilation process that generates a temporary file using tempnam in PHP which creates a file for my pleasure, this file does not have an extension (example: /private/var/tmp/mjmloutputdmCS2N)
I use this file as an output destination for the HTML compiled by the mjml command.
This worked in 4.0.3, but now in 4.0.4 I get an error stating that the given path is not a directory.
If the node already exists, and is a file then it should output the HTML to the file, if it's a directory then it should output input.html - I guess. And if the node doesn't exist at all, then it should create the directory?
Reproduction Steps:

Install<EMAIL_ADDRESS>Create a token MJML file ./input.mjml

<mjml>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-text font-size="20px" color="#F45E43" font-family="helvetica">Hello World</mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

Create a file without an extension ./output
Run mjml -r ./input.mjml -o ./output

Expected behavior:
The file ./output contains the compiled HTML
Observed behavior:
A command line error occurs
Command line error:
Output directory doesn’t exist for path : ./output

Screenshots and GIFs
Probably overkill for this...
MJML version:
4.0.4

Hi @antonyoneill we chose not to create directories, only non-existing files, but this check was wrong indeed, it should just check the parent directory. The fix should be released soon


FiniteElementCollection::GetEdge bugfix

Fixed wrong indexing in FiniteElementCollection::GetEdge().
Synced with @v-dobrev .
Might be related to #1105 .

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1510
@vladotomov
@v-dobrev
@v-dobrev + @jakubcerveny
05/27/20
⌛due 06/10/20
⌛due 06/17/20

@jakubcerveny, can you take a quick look?

Merged in next for testing...

LGTM


Adjust the position of cn readme

Thanks for the PR, but we probably won't merge as it was done on purpose
see: https://github.com/netless-io/flat/pull/1081

Related to #1081
Sorry, we don't want this. Closing.

I see. However, broken links need to be fixed in https://github.com/netless-io/flat/blob/main/docs/readme/README-zh.md.
你可以在没有服务端的情况下构建并运行 Flat 客户端。此仓库包含以下项目：

-   [Flat Electron 客户端](./desktop)
-   [Flat Web 客户端](./web)


proposal: go/types: Create a public CoreType() function

Core types is a first-class concept in the Go Spec, which was introduced with type parameter support. go/types is the official package for tooling developers to interact with type information for Go programs, but it doesn't offer a public API to determine a core type. As a result, this logic has been reimplemented multiple times by independent parties [1, 2, 3], which isn't ideal for obvious maintenance reasons.
Proposal: Make the currently unexported coreType() implementation in go/types exported for everyone to use.

CC @griesemer @adonovan

cc @findleyr

Thanks. IIRC  the only reason we didn't expose this function originally is that we weren't quite sure what the API should be (and there was a lot of new API in 1.18). The x/exp/typeparams.NormalTerms API was meant as a placeholder, but we never proposed an API for go/types. Thanks for prodding us in the right direction.
We definitely should have an API for the this operation of reducing type sets, because otherwise libraries like x/exp/typeparams have to maintain a copy of this tricky logic.  However, I'm not sure that CoreType is sufficient. I suspect that static analysis tools such as analyzers in x/tools/go/analysis or staticcheck will need to access a normalized form of the type set, as provided by the NormalTerms API.
Therefore, +1 to this proposal, but I think we should bundle it with an additional API that exposes the normalized representation of the type set.

@findleyr thanks for the response. I am currently implementing generics support in gopherjs and CoreType() is the only missing API I ran into so far. I am only half way through the project though, so it's possible that I'll need normalized type sets would be needed at some point.

@nevkontakte for something like a compiler I think CoreType may be sufficient.
For analyses (e.g. the printf analyzer), we need to be able to ask questions like "is this true for all/any types in the type set".  We should expose APIs that can answer these questions.
But there is no question in my mind that we should have a CoreType function, since as you point out this is a feature of types defined in the spec.

I opened #61013 to track an API for interface terms. I don't want that to distract from this proposal, which can be decided independently.

I agree that we should export CoreType. But unlike Underlying it may return nil, which is quite a subtlety that needs to be at least documented clearly. Does it warrant a (Type, bool) result to force callers to consider this case? I tend to think not.

(Type, bool) What would the bool mean?  Type set does not have a core type? This seems redundant with nil. Type set is empty? Type set is >= 2 reconcilable types?  That is useful information, but maybe too niche.

If we export CoreType(), we probably need to decide on a representation for bytestring which is both a core type and has a type set size of 2 (https://go.dev/ref/spec#Core_types).


View.propTypes has been deprecated

I'm using React Native 0.44.2 with react-native-linear-gradient v2.0.0 and I'm getting the warning View.propTypes has been deprecated and will be removed in a future version of ReactNative. Use ViewPropTypes instead.

fixed on master and latest release


Implement infer_table_from_schema! as a Macros 1.1 macro

This was a bit tougher to pull out since the code responsible for
loading the schema information was pretty tightly coupled to libsyntax.
I've attempted to return as much relevant information as possible for
multiple AST frontends in an agnostic way.
This should fix the failures on master as well.

Tests should finally be green. @diesel-rs/contributors review?


kid is not validated while trying to generate backstage internal token while passing the details manually from an end point

I am trying to call the issueToken() method of TokenFactory.ts to generate the backstage token from an end point, in order to enable some validations while calling backstage's backend apis from an external service, the token generation is successful and on ecoding jwt token, all the headers and claims are exactly as we have in the originally generated backstage token but the while trying to hit the backend api, it says unauthorized ( there's token mismatch)
Not sure what am I missing here or it's just not possible to go via the approach I have taken?

Going to close this as a duplicate of #11158. The issueToken() method is for user authentication, so you don't want to use that one for service-to-service auth.


config.sh.repo had change control in it

Removed "<<<<< HEAD" and a couple other change control lines.  Not sure how they got there.

That's my fault. I thought I got them all when I resolved the merge conflict earlier.


Update README.md

You should probably know what language you are writing this project in!

I appreciate this.


Oh good call. Thanks for cleaning that up :)
On Tue, Jun 4, 2019 at 10:06 PM Kevin Glen Roy Greer <
<EMAIL_ADDRESS>wrote:

@kgrgreer commented on this pull request.
In src/foam/u2/Element.js
https://github.com/foam-framework/foam2/pull/2241#discussion_r290559554:

 {

   class: 'foam.u2.ViewSpec',
   name: 'view',

 value: { class: 'foam.u2.TextField' }

 expression: function (placeholder) {

commit 99ffd1d
https://github.com/foam-framework/foam2/commit/99ffd1d132b91d24cf78746d7f4657f419fd1cd0
(HEAD -> master, origin/master, origin/HEAD)
Author: Kevin Greer<EMAIL_ADDRESS>Date: Tue Jun 4 22:05:38 2019 -0400
Fix TextField style of setting placeholder.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/foam-framework/foam2/pull/2241?email_source=notifications&email_token=AB53ESDQK3TOCGKPFZDWB6TPY4NRPA5CNFSM4HTB56B2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TFHKQ#discussion_r290559554,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB53ESBJEM4HQ44V2TPR5C3PY4NRPANCNFSM4HTB56BQ
.


metrics(dm): incr lag metric when syncer blocked

What problem does this PR solve?

Issue Number: close #3695
What is changed and how it works?

one lag worker calcl lag by jobTS in bucket every  0.1 s
when a ddl/dml job is sended into worker queue, add this job's TS in to bucket
when a ddl/dml job executed to downstream, clear the TS in bucket

Check List
Tests

Integration test

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update key monitor metrics in both TiCDC document and official document

Release note
`None`.

Codecov Report

Merging #4496 (ad60189) into master (9607554) will decrease coverage by 0.1892%.
The diff coverage is 45.1882%.

Flag
Coverage Δ

cdc
60.1202% <70.5882%> (+0.1980%)
:arrow_up:

dm
51.5479% <31.1688%> (-0.4810%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4496        +/-   ##
================================================
- Coverage   55.6402%   55.4509%   -0.1893%
================================================
  Files           494        499         +5
  Lines         61283      61732       +449
================================================
+ Hits          34098      34231       +133
- Misses        23750      24057       +307
- Partials       3435       3444         +9

could you please take another look for this pr ? thanks 🧡🧡🧡
@GMHDBJD @lance6716

could you please take another look for this pr ? thanks 🧡🧡🧡
cc @@lance6716

/hold wait to try use heartbeat to check if syncer is blocked

i adjust the logic of calcuate ddl lag, now lag for ddl and dml is same

one lag worker calcl lag by jobTS in bucket every  0.1 s
when a ddl/dml job is sended into worker queue, add this job's TS in to bucket
when a ddl/dml job executed to downstream, clear the TS in bucket

and this ensures that lag will continue to growth when syncer is blocked.
ptal /cc @lichunzhu  @GMHDBJD

/unhold

/merge

/run-dm-integration-tests

/run-dm-integration-tests

/merge

/run-verify-ci


Remove iprojectdocument.

Description of change
This removes unused IProjectDocument model and its related views etc. Because we use the default S3 bucket for migration commands I renamed DOCUMENTS_BUCKET env variable to DEFAULT_BUCKET.
Checklist

[X] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[X] Has the admin site been updated (for new models, fields etc.)?
[X] Has the README been updated (if needed)?

Codecov Report

Merging #1062 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1062      +/-   ##
===========================================
- Coverage    96.19%   96.18%   -0.01%
===========================================
  Files          216      216
  Lines         6202     6191      -11
  Branches       595      594       -1
===========================================
- Hits          5966     5955      -11
  Misses         166      166
  Partials        70       70

Impacted Files
Coverage Δ

datahub/investment/urls.py
100% <ø> (ø)
:arrow_up:

datahub/investment/admin.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7627b73...3a82860. Read the comment docs.

@marcofucci I have updated all environments. I will delete old key after the release.


Develop Support For Off-Nominal Data Loads

💡 Description

Need to build out the designs for off-nominal behavior in archive management:

Acceptance of validation errors
Acceptance of validation warnings
"floating" files that do not contain labels, but we want in the archive anyways
Re-run data that has failed unexpectedly due to system failure
Re-run data that has been edited in the cloud (includes support for how someone could inspect and update data in AWS)
Remove data, and reload from the ground

📆 October status: Investigation ongoing for improving usability of failure cases. On schedule.

📆 December status: Documentation started and will be ongoing as the software evolves.


feat: Add policy packer

Not exactly SCPs, but a way to squeeze more statements into an AWS policy.

Thanks for the contribution @phzietsman !
This repo is more about SCPs.
I think yours would go better in a generic IAM awesome list perhaps?

That makes sense!


Trie implementation for route matcher:

Made RouteMatcher an abstract class to accept different implementations
The RouteMatcherFactory can serve different implementations
Follow the conversation of this other pull request.
Tests all pass with the new implementation but I didn't think of a way of gracefully testing both of the implementations without replicating every single test.
Used this benchmark and added filters to it and more routes/loops resulting in a 40% better performance.
Results:
BEFORE:
RoutePerformanceTest.doBenchmark: [measured 10 out of 15 rounds, threads: 1 (sequential)]
round: 34.27 [+- 1.09], round.block: 0.00 [+- 0.00], round.gc: 0.00 [+- 0.00], GC.calls: 1502, GC.time: 3.01, time.total: 520.40, time.warmup: 177.70, time.bench: 342.70

AFTER:
RoutePerformanceTest.doBenchmark: [measured 10 out of 15 rounds, threads: 1 (sequential)]
round: 20.73 [+- 0.86], round.block: 0.00 [+- 0.00], round.gc: 0.00 [+- 0.00], GC.calls: 285, GC.time: 0.59, time.total: 313.37, time.warmup: 106.08, time.bench: 207.29

any news on this?

No interest in > 2 years, closing


macOs support

Not sure if it's possible. But any chance you can add macOs arm64/x86_64 support?

Sorry I can't support macOS right now since Embedded frameworks from Google doesn't contain archs for macOS.
Please raise issue on Google MLKit first


Conflict: Microsoft.VSCode_profile.ps1 -- Advised to use BUT seems not working 'by design'?

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Version: 1.77.3 (system setup)
OS Version: Windows_NT x64 10.0.22621 (Windows 11)

Context / Background:

I recently spent some time re-organising my PowerShell profiles so they were correctly tailored and optimised depending on whether I was running pwsh.exe, powershell.exe, PowerShell_ISE.exe, or vscode.exe
The Microsoft about Profiles page [updated 24/03/2023] explicitly states that "Visual Studio Code (VS Code) supports the following host-specific profiles" so I created a custom profile for VS code.
However the VS Code profile Microsoft.VSCode_profile.ps1 would not run
Reading issue #142737 suggests this is "designed" not to work(?) 🤔

Steps to Reproduce:

Create Microsoft.VSCode_profile.ps1 with simple test code (e.g. Write-Host "VS Code profile loaded")
Place in it either $PSHOME or $HOME\Documents\PowerShell
Run VS Code and open the PowerShell terminal
Note that "VS Code profile loaded" does not appear, the profile does not get loaded

Conflict:

✅ The primary Microsoft guidance on creating and using PowerShell profiles [updated 2 weeks ago] says that VS code does support custom profiles
❌ Assuming I have understood correctly, a closed github issue [from 14 months ago] seems to suggest VS code does not support custom profiles

Please can you clarify which is correct
(and if VS Code is supposed to support custom profiles, use this ticket to remedy the  issue)

the profile is only going to run when you have the pwsh extension installed. do you have it installed?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


feat: support flat config

support flat config
Description
Fixes #280
This PR supports flat config.
It is also compatible with existing configs.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?

[x] Integration Test for flat config (tests/integrations/flat-config)
[x] Integration Test for legacy config (tests/integrations/legacy-config)

Test Configuration:

OS + version: macOS Ventura 13.2.1
NPM version: v10.2.5
Node version: v18.19.1

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Is this close to being merged in and part of a new release? If there is any work that still needs to be done, I'd be willing to get that done. I'm transitioning my projects to eslint v9 and I'll gladly help if that means this plugin can support v9 sooner.

Hi @kazupon,
thank you for contributing, I pulled your changes in a dedicated branch feat/flat-config-beta on this repo.
I also published a new beta release which includes your changes:
npm i<EMAIL_ADDRESS>-D
Do you understand why the tests are failing in the CICD ?
I get an error, also on my local machine:
FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory

@francoismassart
I found out this test case was blocked in unit tests.
https://github.com/francoismassart/eslint-plugin-tailwindcss/blob/4d04a962eb5df4ee4d98891f6c359d1fcdcae8e6/tests/lib/rules/no-custom-classname.js#L436-L446
I'll check to see if my changes broke any cssFiles.

Hi! @francoismassart
I've just fixed blocking issue.
I believe the CI/CD issue has also been resolved.
And ESLints were outputting API compatibility warnings.
So I have made compatible fixes in this commit.

Great, thank you @kazupon, I published a new beta version: npm i<EMAIL_ADDRESS>I'll share it and wait for feedbacks then we'll be good to go

@francoismassart
Thank you for your publishing!
I've just tested at my day job project!
That's works!


@EmbeddedDocument annotation reference fix

Fixes #907

Closed with https://github.com/doctrine/mongodb-odm/commit/621a4481c9fe8f71fc12fdd01ebd1f9d501f4381


Initial migration from raven repo

Darn, I forgot that we wanted to keep large test data files outside of the repo...
Ideas ?

We could include them as an optional extra package maybe?

@cjauvin There's already some discussion about this. I'll likely be creating a tesdata repo for Raven(Py) later today.

For more information: https://github.com/Ouranosinc/raven/issues/318

Darn, I forgot that we wanted to keep large test data files outside of the repo...
Ideas ?

We could include them as an optional extra package maybe?

FYI, the commit that has those large testdata should be destroyed and recreated.  Just commit again to delete those large testdata file will still keep them in the history and bloat the repo size.

yes absolutely, good idea, will do!
On Thu, Nov 26, 2020 at 13:36 Long Vu<EMAIL_ADDRESS>wrote:

Darn, I forgot that we wanted to keep large test data files outside of the
repo...
Ideas ?
We could include them as an optional extra package maybe?
FYI, the commit that has those large testdata should be destroyed and
recreated. Just commit again to delete those large testdata file will still
keep them in the history and bloat the repo size.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CSHS-CWRA/RavenPy/pull/5#issuecomment-734438031, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADXMIE4ZAQRVM75QG4EM3LSR2NZDANCNFSM4UD3GAKA
.

Actually I think that this commit crashed my text editor (Emacs).. 😟
On Thu, Nov 26, 2020 at 1:49 PM Christian Jauvin<EMAIL_ADDRESS>wrote:

yes absolutely, good idea, will do!
On Thu, Nov 26, 2020 at 13:36 Long Vu<EMAIL_ADDRESS>wrote:

Darn, I forgot that we wanted to keep large test data files outside of
the repo...
Ideas ?
We could include them as an optional extra package maybe?
FYI, the commit that has those large testdata should be destroyed and
recreated. Just commit again to delete those large testdata file will still
keep them in the history and bloat the repo size.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CSHS-CWRA/RavenPy/pull/5#issuecomment-734438031, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADXMIE4ZAQRVM75QG4EM3LSR2NZDANCNFSM4UD3GAKA
.

I removed the tests/testdata folder from my previous commit and force-pushed the change.


How can a user revoke given consent

How can a user revoke given consent

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52221dd3-95ec-96b9-1da8-9478527c2602
Version Independent ID: 32e9c2d8-733d-0865-2ea3-727d8684a10d
Content: Single sign-on support for tabs - Teams
Content Source: msteams-platform/tabs/how-to/authentication/auth-aad-sso.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@abdulkareemnalband Under https://myapps.microsoft.com, you should be able to find the app in question. Clicking on the "..." should lead you to the page where you can revoke the access you've granted.

Just followup question
If an app is consented by admin for whole organization, individual users do not need to consent again in teams?

For a teams app doing SSO with Azure AD as described in this article, that is correct.


Use one DB pool for entire server

Previously we created a DB pool on every call to a function in the db
module.  This caused connection exhaustion (see #36).
Instead, introduce a new struct KbsDb which holds the pool.  All the
methods in the db module are now methods of the struct. It is
initialized only once in create_service(), and then passed on to
whomever needs DB access. That part caused a lot of little changes.
Also add a db::tests::test_stress which performs queries in a loop
(this would fail with the earlier implementation because we query would
create a new DB pool).
Fixes #36
Signed-off-by: Dov Murik<EMAIL_ADDRESS>
It's best to view the code changes with "ignore whitespace".

Ok, let's try to get this merged. Thank you for your suggestions @jodh-intel. @dunnderr are you around to add some of those DB tweaks in a future PR?

Hi Tobin, yes.  I have already started working on them.  Once the merge is complete, I will rebase and continue.


problem wihle converting unicode to pdf

In this simple example the unicode get converted to some gibrish codes. Am I missing something??
coding: utf-8
from xhtml2pdf import pisa
sourceHtml = u'सरल'
fd = open("temp_file.pdf", "w+b")
pisaStatus = pisa.CreatePDF(sourceHtml.encode('utf8'), dest=fd)
fd.close()

I have problem same you. I use thai language.

A absolute path to src url was required. Cheers
source = """

        <body>
            This is a test <br/>
                   सरल
        </body>
    </html>"""

what if we have multiple language support in a single print. This approach converts all fonts to specified font family..


update to v1.0.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Thanks a bunch!! And hm, I thought this would happen automatically; do you know why it hasn't?

no idea why or how it's supposed to be set up sorry. I'm just dependent on conda for my current setup so thought I would ease the work.
Just seen your post on ecoevo, I'm happy to do the same for v1.0.3.

I've already got it going: https://github.com/conda-forge/pyslim-feedstock/pull/11 - thanks, though!


Use TSC

Old issue was closed for no reason.
While it's faster, it forces Typescript users (the majority of devs) to also run TSC, which negates the performance gains since you essentially need to compile it twice.
Choosing esbuild is not pragmatic or objectively a good idea.  It leads to bugs that can easily be avoided. It makes much more sense to wait an extra 100ms to ensure the code you wrote won't blow up production.
Originally posted by @Doelfke in https://github.com/remix-run/remix/discussions/6456

@sergiodxa Already mentioned why we can't use TSC in https://github.com/remix-run/remix/discussions/6456#discussioncomment-5982854


adding travis retry

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3030 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3030   +/-   ##
=========================================
  Coverage     45.66%   45.67%
+ Complexity     9297     9296    -1
=========================================
  Files          1956     1956
  Lines         74390    74390
  Branches       8248     8248
=========================================
+ Hits          33969    33974    +5
+ Misses        37248    37240    -8
- Partials       3173     3176    +3

Impacted Files
Coverage Δ
Complexity Δ

.../modules/scheduler/GobblinServiceJobScheduler.java
57.14% <0.00%> (-2.12%)
24.00% <0.00%> (-2.00%)

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
62.70% <0.00%> (-0.34%)
33.00% <0.00%> (ø%)

.../apache/gobblin/runtime/api/JobExecutionState.java
80.37% <0.00%> (+0.93%)
24.00% <0.00%> (ø%)

...lin/restli/throttling/ZookeeperLeaderElection.java
72.22% <0.00%> (+2.22%)
13.00% <0.00%> (ø%)

...in/java/org/apache/gobblin/cluster/HelixUtils.java
40.47% <0.00%> (+5.55%)
16.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0041a5...5e20300. Read the comment docs.


Remove semicolon from SQL instance name

When running the command for enabling auto-protection of all future databases in an instance, the parameter "--protectable-item-name" can't have the final semicolon, or it will fail with the error: "Protectable item not found. Please provide a valid protectable_item_name."

Learn Build status updates of commit 13b6a7e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/backup/backup-azure-sql-backup-cli.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@v-amallick,
Can you review the proposed change?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@luisarnauth - thanks for making the changes. With product group's confirmation doing #sign-off.


lsrole and showrole is not working

Hi!
When trying to list roles and show an existing role, we got the following error:
[429] vcli@vault.service."paas.labs.stratio.com":8200 > lsrole
jq: error (at <stdin>:5): Cannot iterate over null (null)

This happens with version 0.5.12.

It seems I cannot reproduce this issue:
[200] vcli@gosec1.stratio.ey.com:8200 > lsrole
open
tais
vault-bkp
[200] vcli@gosec1.stratio.ey.com:8200 > showrole vault-bkp
vault-bkp
[200] vcli@gosec1.stratio.ey.com:8200 > lspol
default
fabric
gosec-sso
marathon
metronome
open
orchestrator-bkp
tais
vault-bkp
root
[200] vcli@gosec1.stratio.ey.com:8200 > showpol metronome
path "sys/*" {capabilities = ["deny"] }
 path "/auth/approle/*" {capabilities = ["read", "list", "create", "update"] }

It seems it didn't reproduce. We'll close it for the moment


Thread 1: signal SIGABRT

Report an error directly on this line：
let server = HttpServer()
The error is as follows
Thread 1: signal SIGABRT

Hey, @xiaoxiaotestnote Thanks for taking the time to report this. SIGABRT are signal abort but normally you can see the exception attached to the runtime error. Can you please attached the Xcode message or provide a sample project with the reproduction?

Please see the latest release and feel free to open this again with more details in case you are still experiencing it.


Fix nightly vs latest in linux

'latest' will be resolved to the current latest version by getting it from here:
https://arduino-cli.github.io/arduino-latest/
It never uses latest keyword for the download.

The call chain is:
getSanitizatedVersion > getFullVersion > getLatestVersion > init
https://github.com/arduino-cli/arduino-node/blob/master/index.js#L87-L92

Ah ok


Impossible load fixtures

I create new plugin, but can't load fixtures:
$:~/VanssaSyliusMediaPlugin/tests/Application$ symfony console sylius:fixtures:load -vvv

Warning! Loading fixtures may purge your database for the dev environment (if `orm_purger` is used in your suite).

Continue? (y/N) y
Running suite "default"...
Running fixture "locale"...
Running fixture "currency"...
Running fixture "geographical"...
Running fixture "taxon"...

 The issue is related to doctrine-bundle and already excluded in the main Sylius package: https://github.com/Sylius/Sylius/commit/61848c9a9192e78b470e82242f1f9b0aac57c7e1#diff-384dc1c2949df6087dc99e7b0f37a0dc0302a38124744c6d7dff46316675b121 new tag will be released in a few hours. However, you may use Sylius dev-master to have it fixed already


chore: release 1.2.203

:robot: I have created a release *beep* *boop*
1.2.203 (2023-02-28)
Features

bundles: support custom secret values files when publishing bundle (5290e33)

Bug Fixes

staged-dockerfile: fix panic which occurs when using dependencies between images with multistages (4f6b10e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.2.203 :sunflower:


Protocol parameters - epochs

Various components (e.g. PoS and DKG) rely on a notion of epochs. We should decide if we want to measure these in a number of blocks or time. Epochs should be uniquely identified by consecutive integers.
In the base ledger, the duration should be set in a protocol parameter that is written to and read from storage to allow for changes. Any changes to protocol parameters could be applied by validators and switched on 2/3 voting power consensus. This could be implemented as a native validity predicate.

For now we should have an epoch which ends as soon as both a minimum time and minimum number of blocks have passed.
(this will be the same as the unbonding period logic, though the constants will be different)


feat: Implement 'balance' command to fetch wallet balance

This Pull Request introduces a new command, balance, to the CLI. The balance command is used to fetch the user's balance from their wallet.
Users can fetch their balance in four different ways:

balance --usd: Fetches the balance in the USD wallet.
balance --btc: Fetches the balance in the BTC wallet.
balance or balance --usd --btc: Fetches the balance from both the wallets and specifies the default one.

In the process of making these changes, the hardcoded Wallet type in main.rs has been moved to a new file, types.rs, which is now being exported from lib.rs. This centralizes the handling of types and makes the code more scalable for future expansions.
Issue: #145

This Pull Request introduces a new command, balance, to the CLI. The balance command is used to fetch the user's balance from their wallet.
Users can fetch their balance in four different ways:

balance --usd: Fetches the balance in the USD wallet.
balance --btc: Fetches the balance in the BTC wallet.
balance or balance --usd --btc: Fetches the balance from both the wallets and specifies the default one.

In the process of making these changes, the hardcoded Wallet type in main.rs has been moved to a new file, types.rs, which is now being exported from lib.rs. This centralizes the handling of types and makes the code more scalable for future expansions.
Issue: #145

it would be relevant to consider been able to pass an array of WalletId as well as an arguments. right now we only have 2 wallets per account, so this will works, but this assumption of only having 2 wallets will expend eventually for business account.

This Pull Request introduces a new command, balance, to the CLI. The balance command is used to fetch the user's balance from their wallet.
Users can fetch their balance in four different ways:

balance --usd: Fetches the balance in the USD wallet.
balance --btc: Fetches the balance in the BTC wallet.
balance or balance --usd --btc: Fetches the balance from both the wallets and specifies the default one.

In the process of making these changes, the hardcoded Wallet type in main.rs has been moved to a new file, types.rs, which is now being exported from lib.rs. This centralizes the handling of types and makes the code more scalable for future expansions.
Issue: #145

it would be relevant to consider been able to pass an array of WalletId as well as an arguments. right now we only have 2 wallets per account, so this will works, but this assumption of only having 2 wallets will expend eventually for business account.

@nicolasburtey I have addressed this in commit 4a65bd3f0ae2fc4c7f87850be882f835bfe012a4. The updated command now supports an array of wallet IDs provided as comma-separated values in the wallet-ids option, even in conjunction with --usd and --btc boolean options. So, you can now specify the wallets like --wallet-ids id1,id2,id3. This should accommodate scenarios where more than two wallets need to be considered.


Options is available as a standard property of SelectEntityDescription

The problem
As of Home Assistant Core 2022.11, options is available as a standard property of SelectEntityDescription.
This may cause issues in custom components if a custom options property was previously implemented.
Please adjust the custom component by either dropping or renaming the custom options property.
See https://github.com/home-assistant/core/pull/78882

Thanks @epenet, I saw your PR passing by and will fix it in the custom component. Good improvement to core.

Please be aware that this will only be available from 2022.11 release.
If you wish to be compatible with both 2022.10 and 2022.11 you may need to rename the options property.

I believe this is now causing a problem in the 2022.11b0
2022-10-27 18:49:48.655 ERROR (MainThread) [homeassistant.loader] Unexpected exception importing platform custom_components.nest_protect.select
2022-10-27 18:49:48.662 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform nest_protect.select: Platform not found (Exception importing custom_components.nest_protect.select).
I see it is merged, but is it ready for release in good time?

easy fix, I just removed line 18 of select.py

@fishbone-git I will release a new version soon. I planned to do this just before the release, however it makes sense to do this earlier in case you want to try the beta.

hey, awesome thanks for the fix!
How long does it take for HACS to know an update for this integration is available? simply "updating information" does not show 0.3.9 version. thanks

@Anto79-ops do you run 2022.11? This update is only available for users running 2022.11, since it will break 2022.10 functionality.

Im running 2022.11b4 now

ok, all good. it was redownload that solved the issue. cheers!