change the text from 'save' to 'store locally'

Since the save add the data to the offline edit, and do not save it in open food facts data base, it would be usefull to make it clear.

Done


Add a UNIX-y Makefile

I am digusted of the thought of going into the UNIX land and learnign a new inconsistent and incomplete regexy shell syntax. So, if anyone adds a Makefile that:

Generates mbf(r|l).min.bf from the respective source file by removing all the non-BF characters.
Generates repl.bf from mbfr.min.bf by adding a required set of strings before/after the the code from mbfr.
Generates repl.min.bf stripping all the non-BF from repl.bf.

Nothing especially complicated, but the best I've arrived at was:
cat mbfr.bf | sed 's/[^-+<>\[]//g'

which does not remove newlines (unsurprising given sed being line-based) and removes closing brackets (as the character set syntax seems to not have a syntax (at least the one I know of) to include literal ] character.)

Done, although the M4 rule for minification is not perfect :D


realsense 2.17 error

As the realsense 2.13 has problem of dropping frame  in saving files. The new version 2.17 has solve this problem. Please update the vcpkg ports. Thank you!

I think this issue can be closed. Currently, the available version is 2.22.


Properly Implement handlers for Tags

This isn't fully (or properly) implemented, yet.

Added in 9bc901a822716653a896ea34db0e3d99d3ffaa71


Broken URL for Research Data Scotland

Broken URL: # https://find.researchdata.scot/

Closing. Resolved.


[UX][APIM] Need to add client side validation on API Create page

Description:

Current error messages are generic. IMO better to have specific ones. instead of saying "This field is required." better to say "API name cannot be empty"

Need to add client-side validation for API version
This error is backend error, we need to add client-side one before the submit:  | API Version contains one or more illegal characters  ( [~!@#;%^*()+={}|<>"',[]&/$\] )

Suggested Labels:
improvement
Suggested Labels:
bug
Affected Product Version:
2.1.0 update 14
OS, DB, other environment details and versions:
MacOS High sierra/ Chrome 64

Closing the issue as this is older than 3 years. Please reopen if the issue is valid still.


Weird issue with read/write from unsanboxed/sandboxed process.

I've tried this many times but somehow i always get the same result.
From SpringBoard (unsandboxed):
I got nil value from the NSUserDefaults, but when I tried to write value onto the NSUserDefaults i got this message from cfprefsd[0]
[0] = wrote file /private/preboot/<random_chars>/jb-XXXXXX/procursus/var/mobile/Library/Preferencespref.test.plist
Notice the /Preferences and pref.test.plist, isnt it suppose to be / in between them? I tried to make other profile, apply libsandy, and call nsuserdefaults and i got the same result. Tested on iOS 15.1.1 (A14).
From app (sandboxed):
I can get value of the .plist in /Preferences/ but when I tried to write value onto it, i got this message from cfprefsd[1]
[1] = rejecting write of key(s) data in { pref.test, mobile, kCFPreferencesAnyHost, /var/jb/var/mobile/Library/Preferences/pref.test.plist, managed: 0 } from process 19091 (Twitter) because setting preferences outside an application's container requires user-preference-write or file-write-data sandbox access
Profile (pref.test.plist):
`

AllowedProcesses

*

Extensions

type
file
extension_class
com.apple.app-sandbox.read-write
path
/var/mobile/Library/Preferences/pref.test.plist

`

This is a cfprefsd / stock bug where it removes /private from the beginning of /private/preboot paths when running stringByResolvingSymlinksInPath.
Both Dopamine and palera1n rootless have cfprefsd hooks that redirect third party preference plists to /var/jb automatically. So when creating the NSUserDefaults object, just use the rootful path, it will automatically be redirected to /var/jb.

I already did use rootful path or the 'normal' path without /var/jb when creating the NSUserDefaults object, the test are done using that, it still does not work for me somehow.
Is sandboxed app suppose to only read data from the Preferences?
I can't seems to make it able to write data into it, except from unsandboxed process.
Here are the logs when I tried to write some data into the .plist inside /Preferences/ (profile already have read-write access in extension_class, and libSandy_applyProfile() called before calling NSUserDefaults):

Kernel = Sandbox: Twitter(22316) deny(1) user-preference-write pref.test
cfprefsd = rejecting write of key(s) prefs in { pref.test, mobile, kCFPreferencesAnyHost, /var/jb/var/mobile/Library/Preferences/pref.test.plist, managed: 0 } from process 22316 (Twitter) because setting preferences outside an application's container requires user-preference-write or file-write-data sandbox access
Twitter = Couldn't write values for keys (prefs) in CFPrefsPlistSource<0x281ec5980> (Domain: pref.test, User: kCFPreferencesCurrentUser, ByHost: No, Container: kCFPreferencesNoContainer, Contents Need Refresh: No): setting preferences outside an application's container requires user-preference-write or file-write-data sandbox access

In your extension plist you need to omit the /var/jb too, just use the root path there aswell. Make sure the extension is read-write, then it should work.


Different TS-JEST / TS emitted code when importing 3rd party libs

Continuing the discussion from issue 209
For the same code compiled with TS, ts-jest emits a different output.

Both tsconfig file are identical (one for regular TS compilation, one for ts-jest)
allowSyntheticDefaultImports set to true.

When using this statement:
import * as pathToRegexp from 'path-to-regexp';

In TS compilation without ts-jest pathToRegexp is a function
In TS compilation with ts-jest pathToRegexp is an object.
It's not deterministic, different outcome for the same TS compilation process

@kulshekhar From what you explained, there is another transpilation happening...
TS -> TS emitted code -> babel -> ES5 JS
Since TypeScript can emit ES5 why would we need babel?

When allowSyntheticDefaultImports is set to true, ts-jest processes the output of the typescript compiler further using babel.
When it is set to false, only typescript is used.
This was done recently in PR #172
That might be a good starting point.
(I could attempt an explanation but because I don't use babel or allowSyntheticDefaultImports, there's a chance I might miss something or state something incorrectly)

@kulshekhar I understand the logic behind that PR, yet it solved one issue just to introduce an other.
If I set allowSyntheticDefaultImports to false I get an error from TS.
If I set it to true I can't run tests.

@shlomiassaf there was a short discussion somewhere around whether we should use another setting to tell jest to use babel as well. Would such a setting solve this issue?

It seems to me it'd be a good idea, and then just default to true if allowSyntheticDefaultImports
(Might also be a good idea to at the same time move the TS_CONFIG into a seperate "ts-loader" key - it seems a little strange to keep it in globals. Would break backward compat though)

@GeeWee when you say move TS_CONFIG into a separate "ts-loader" what exactly do you mean by this? Are you saying another JSON field in Jest? Or are you saying you would like to have more than one tsconfig file to point to?
Also I aggree with the allowSyntheticDefaultImports instead of having to specify it in my tsconfig file. It makes more sense to me that this would need to be in the test config since I do not need it in my tsconfig file.

Yeah another JSON field, like:
{
"jest" : {
"ts-loader": {
"TS_CONFIG" : {
...
},
"transformUsingBabel": true,
}
It seems a little silly having to expose TS_CONFIG as a global variable to all the test code.

While I agree about the TS_CONFIG bit, I'm a bit hesitant to introduce breaking changes.
Adding a flag to control babel usage seems sensible though - with the default value (absence) leaving the behavior unchanged. So if this isn't set, ts-jest will process through babel if allowSyntheticDefaultImports is set to true.
I'm not sure what the best way to name this flag would be though:

transformUsingBabel (or something on these lines like transformUsingBabelAfterTypescript) - this will have a default value of true to prevent a breaking change. Users will have to set this to false to address the issue we're discussing in this thread. This seems kinda counter-intuitive

transformUsingTypescriptOnly - in this case, an absence of this flag will be the same as if the flag is set to false, avoiding a breaking change.

I totally agree with you about the breaking changes.
I feel however like it's an easy fix to make for the end user - and we can provide them with a deprecation warning, and maintian backwards compatibility for a while if needed?
Another point there is, where do you want the babel flag?
You can't stick it in the __TS_CONFIG_ because that'd make it impossible for someone to use it with an actual .tsconfig file. Another global variable?
I think transformUsingBabel makes more sense.
I would set it to be false by default, unless allowSyntheticDefaultImports is set to true. This makes more sense to me and is not a breaking change.

we can open a new issue about the breaking change and discuss that separately

the babel flag can't go in __TS_CONFIG__. It will need to be outside it.

When allowSyntheticDefaultImports isn't set, currently, we never invoke babel. I'm not sure there's a need for this. So the new flag will be used only when allowSyntheticDefaultImports is true.

Now if the default behavior uses babel, the only case when this new flag will be used will be if a user wants to prevent the use of babel. In this state, the term transformUsingBabel doesn't quite signify what the user wants to do. Something like transformUsingTypescriptOnly or doNotUseBabel seems more intuitive. That's just my view though.

Good idea about the breaking change issue #217
I agree.
Oh so you're thinking to only check the flag if allowSyntheticDefaultImports is true?
I agree it's the only case where it makes sense to use babel, but I feel like a flag that only gets checked if a specific configuration option in .tsconfig is true, is rather confusing to explain.
I get what you're saying, but as an outsider I was really surprised to learn that ts-loader used babel if allowSyntheticDefaultImports was set - in my mind it makes more sense to feel like you're opting-in to babel? It probably doesn't matter much.

Oh so you're thinking to only check the flag if allowSyntheticDefaultImports is true?

Yes, because currently babel is used only when allowSyntheticDefaultImports is true. Come to think of it, ts-jest is currently using allowSyntheticDefaultImports where the new flag should be used. If we introduce this new flag, we can remove the check for allowSyntheticDefaultImports because it'll become irrelevant.

I get what you're saying, but as an outsider I was really surprised to learn that ts-loader used babel if allowSyntheticDefaultImports was set

This wasn't always the case. The PR that did this was merged only a few weeks ago.

in my mind it makes more sense to feel like you're opting-in to babel

If we were implementing this from scratch, I'd agree 100%. As things stand, users using this (that PR fixed issues for a lot of people) are opted in to babel by default. And those who aren't using this don't really care about babel (probably).
Well, we can use transformUsingBabel and replace the check for allowSyntheticDefaultImports with a check for transformUsingBabel. This will be a breaking change for some users but I think it'll remove confusion that this has caused

I've mulled it over. There are three options as I see it.

A skipBabel flag that is set to false by default, but can be set to true. This is only checked if allowSyntheticDefaultImports is true
Pros.
Not a breaking change
Easy to explain.
Cons.
Makes it impossible to use the babel transform without allowSyntheticDefaultImports

If we can't think of a use case where you would be interested in using babel without allowSyntheticDefaultImports I think this is the best idea.

A transformUsingBabel flag that replaces the allowSyntheticDefaultImports as you suggested. This flag would default to false.
Pros.

Makes it possible to use babel transform without requiring allowSyntheticDefaultImports to be true.
Cons.

Breaking change.

I think most people who use allowSyntheticDefault are interested in this functionality, so I feel like false is not a sensible default.

A transformUsingBabel flag that behaves the same as the suggestion above, except it defaults to the value of allowSyntheticDefaultImports.
This removes all the cons from the suggestion above, but it is a little harder to explain to the users.

Thoughts?

Another thing going for option 2 is that it makes sure the users know what's going on.
Currently, as you pointed out as well, users have no idea that ts-jest uses babel when allowSyntheticDefaultImports is set to true. It's also not very intuitive. If I came across something like this in another library, I'd be at my wits end should something related go wrong and I have to debug it!
It is a breaking change but the fix required at the users' end would be straightforward - set transformUsingBabel to true in ts-jest config. This would also give us an opportunity to introduce the ts-jest config within the jest config which can be used by #217 later.

I think the reason nobody knows what's going on is because it's not documented. I feel like option #1 would be easily explained with something like:
'If allowSyntheticDefaultImports is set to true, jest-ts automatically uses babel to transpile es6 modules to commonJS modules. You can opt out of this behaviour by setting skipBabel to true'

Sounds good

@shlomiassaf I've sent a PR to your repo. Can you confirm that this fixes your issue?

I'm confused on the conclusion. My understanding is that right now skipBabel is only applicable to allowSyntheticDefaultImports. If that's the case is the plan to eventually make skipBabel be independent of allowSyntheticDefaultImports?

@jupl babel is used internally by ts-jest only when allowSyntheticDefaultImports is set to true so skipBabel is really meaningless without it

Currently babel is only used when allowSyntheticDefaultImports is set to
true, so it covers all cases. I imagine if we end up using babel for every
transformation we will make them independent
On Wed, May 24, 2017, 20:43 jupl<EMAIL_ADDRESS>wrote:

I'm confused on the conclusion. My understanding is that right now
skipBabel is only applicable to allowSyntheticDefaultImports. If that's
the case is the plan to eventually make skipBabel be independent of
allowSyntheticDefaultImports?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kulshekhar/ts-jest/issues/213#issuecomment-303815248,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGFg4MgaQUT_E7v11y95og3xGJzpGtnjks5r9Ho1gaJpZM4NaeJh
.

--
mvh.
Gustav Wengel


Minute Subscription drifting 1 second every minute

Hi,
i tested candlesticks with lean running IB in live mode. For testing i took the consolidator example from the university and combined it with an dictionary holding some pattern:
Dictionary<string, List<CandlestickPattern>> tickerpattern = new Dictionary<string, List<CandlestickPattern>> ();
foreach (var symbol in assets)
                {
                    tickerpattern.Add(symbol, new List<CandlestickPattern>() { new AbandonedBaby(), new DojiStar(), new Hammer(), new GravestoneDoji(), new Doji(), new StalledPattern(),
                    new LongLeggedDoji(), new LongLineCandle()});
                }

                string ticker = bar.Symbol.Value;
                List<CandlestickPattern> patternlist = tickerpattern[ticker];
                for (int i = 0; i < patternlist.Count; i++)
                {
                    CandlestickPattern pattern = patternlist[i];
                    pattern.Update(bar);

                    if (pattern == 1)
                    {
                        Log(bar.Symbol.Value + " " + pattern.Name + " bullish");
                    }
                    else if (pattern == -1)
                    {
                        Log(bar.Symbol.Value + " " + pattern.Name + " bearish");
                    }
                }`

My problem was that some pattern were wrong. There was no doji or hammer or gravestonedoji in the 5 minute real time chart. Maybe its because of the shifting minute bar every minute:
2017-06-22T18:24:09.8126250Z TRACE:: 2017-06-22 14:24:09Z Isolator.ExecuteWithTimeLimit(): Used: 12 Sample: 12
2017-06-22T18:25:10.8111250Z TRACE:: 2017-06-22 14:25:10Z Isolator.ExecuteWithTimeLimit(): Used: 12 Sample: 11
2017-06-22T18:26:11.7977500Z TRACE:: 2017-06-22 14:26:_11_Z Isolator.ExecuteWithTimeLimit(): Used: 13 Sample: 10
2017-06-22T18:27:12.7956250Z TRACE:: 2017-06-22 14:27:12Z Isolator.ExecuteWithTimeLimit(): Used: 13 Sample: 11
2017-06-22T18:28:13.7835000Z TRACE:: 2017-06-22 14:28:_13_Z Isolator.ExecuteWithTimeLimit(): Used: 13 Sample: 11
2017-06-22T18:29:13.8127500Z TRACE:: 2017-06-22 14:29:13Z Isolator.ExecuteWithTimeLimit(): Used: 13 Sample: 14
2017-06-22T18:30:14.8088750Z TRACE:: 2017-06-22 14:30**:14**Z Isolator.ExecuteWithTimeLimit(): Used: 12 Sample: 13
2017-06-22T18:31:14.8090000Z TRACE:: 2017-06-22 14:31:14Z Isolator.ExecuteWithTimeLimit(): Used: 16 Sample: 8
2017-06-22T18:32:14.8096250Z TRACE:: 2017-06-22 14:32:14Z Isolator.ExecuteWithTimeLimit(): Used: 14 Sample: 12
2017-06-22T18:33:15.8061250Z TRACE:: 2017-06-22 14:33:15Z Isolator.ExecuteWithTimeLimit(): Used: 13 Sample: 12
2017-06-22T18:34:15.8062500Z TRACE:: 2017-06-22 14:34:15Z Isolator.ExecuteWithTimeLimit(): Used: 13 Sample: 12
2017-06-22T18:35:15.8221250Z TRACE:: 2017-06-22 14:35:15Z Isolator.ExecuteWithTimeLimit(): Used: 13 Sample: 12
2017-06-22T18:36:16.8102500Z TRACE:: 2017-06-22 14:36:16Z Isolator.ExecuteWithTimeLimit(): Used: 16 Sample: 21
2017-06-22T18:37:17.8063750Z TRACE:: 2017-06-22 14:37:17Z Isolator.ExecuteWithTimeLimit(): Used: 24 Sample: 31
2017-06-22T18:38:18.7933750Z TRACE:: 2017-06-22 14:38:_18_Z Isolator.ExecuteWithTimeLimit(): Used: 22 Sample: 21
2017-06-22T18:39:18.7952500Z TRACE:: 2017-06-22 14:39:18Z Isolator.ExecuteWithTimeLimit(): Used: 25 Sample: 30
I inserted the log if you want to take a look.
maybe you can help me guys..
thanks
log2.txt

Also take a look in the log at that:
2017-06-22T19:05:00.0256250Z TRACE:: Log: UAA LONGLINECANDLE bearish
2017-06-22T19:05:30.7031250Z TRACE:: 2017-06-22 15:05:30Z Isolator.ExecuteWithTimeLimit(): Used: 19 Sample: 19
2017-06-22T19:06:31.6996250Z TRACE:: 2017-06-22 15:06:31Z Isolator.ExecuteWithTimeLimit(): Used: 19 Sample: 12
2017-06-22T19:07:00.0277500Z TRACE:: Log: SBGL HAMMER bullish
2017-06-22T19:07:00.0277500Z TRACE:: Log: SBGL DOJI bullish
2017-06-22T19:07:00.0277500Z TRACE:: Log: SBGL LONGLEGGEDDOJI bullish
2017-06-22T19:07:31.7071250Z TRACE:: 2017-06-22 15:07:31Z Isolator.ExecuteWithTimeLimit(): Used: 16 Sample: 14
2017-06-22T19:08:32.7027500Z TRACE:: 2017-06-22 15:08:32Z Isolator.ExecuteWithTimeLimit(): Used: 14 Sample: 15
2017-06-22T19:09:32.7880000Z TRACE:: 2017-06-22 15:09:32Z Isolator.ExecuteWithTimeLimit(): Used: 14 Sample: 15

why does some stocks need 2 more minutes to get the full 5 .......
it should always be something like that:
2017-06-22T19:10:36.3858750Z TRACE:: 2017-06-22 15:10:32Z Isolator.ExecuteWithTimeLimit(): Used: 14 Sample: 15
2017-06-22T19:11:37.3267500Z TRACE:: 2017-06-22 15:11:37Z Isolator.ExecuteWithTimeLimit(): Used: 14 Sample: 13
2017-06-22T19:12:37.4110000Z TRACE:: 2017-06-22 15:12:37Z Isolator.ExecuteWithTimeLimit(): Used: 15 Sample: 18
2017-06-22T19:13:38.3985000Z TRACE:: 2017-06-22 15:13:38Z Isolator.ExecuteWithTimeLimit(): Used: 18 Sample: 15
2017-06-22T19:14:39.3960000Z TRACE:: 2017-06-22 15:14:39Z Isolator.ExecuteWithTimeLimit(): Used: 15 Sample: 16
2017-06-22T19:15:00.0210000Z TRACE:: Log: NBR LONGLINECANDLE bullish
2017-06-22T19:15:00.0210000Z TRACE:: Log: AR HAMMER bullish
2017-06-22T19:15:00.0210000Z TRACE:: Log: ALLY DOJI bullish
2017-06-22T19:15:00.0210000Z TRACE:: Log: ALLY LONGLEGGEDDOJI bullish
2017-06-22T19:15:00.0210000Z TRACE:: Log: JUNO LONGLINECANDLE bearish
2017-06-22T19:15:00.0210000Z TRACE:: Log: RHT LONGLINECANDLE bullish
2017-06-22T19:15:00.0210000Z TRACE:: Log: AAPL LONGLINECANDLE bearish
2017-06-22T19:15:00.0210000Z TRACE:: Log: CCL LONGLINECANDLE bearish
2017-06-22T19:15:00.0210000Z TRACE:: Log: DO DOJI bullish
2017-06-22T19:15:00.0210000Z TRACE:: Log: DO LONGLEGGEDDOJI bullish

Hi @michaelsrew; the Isolator messages are not related to the system datafeed. Do you use fill forward data? If not it won't trigger events unless there is a tick update from IB. Please attach the full algorithm or a simple algorithm which demonstrates the issue.

hmm yes that was it....thanks for the hint. i've tested it with fillforward. sorry for disturbing. now its works almost perfectly. please close this issue
thanks.

No problem, glad to hear it addressed the issue!


How to get older messages of a specific user in DM

Form
Put an [x] if you meet the condition, else leave [ ].

[ x ] I've searched the Issues
[ x ] I've read the basic concepts
[ x ] I'm using the latest version

How to get older message of a specific user in a DM I am able to get only 10 after that it return the same 10 items. The feed.isMoreAvailable() returns false  even if it's old. feed.items() always return the chatList not the meesage.
const threadFeed = igClient.feed.directInbox();
console.log(threadFeed.isMoreAvailable()); // returns false
exports.getOlderMessages = async function (chatId) {
  const items = await threadFeed.items();
  const thread = items.find((chat) => chat.thread_id === chatId);
  console.log(threadFeed.isMoreAvailable()); // returns false
  return thread;
};

How to get older message of a specific user in a DM

In this case you want to use the directThread(threadId) feed.

Could you please tell how to do

Could you please tell how to do

https://github.com/dilame/instagram-private-api/issues/1002#issuecomment-562885170
Replace directInbox() with directThread(threadId)

@Nerixyz Thanks it's done😁😁😁

Could you please tell how to do

#1002 (comment)
Replace directInbox() with directThread(threadId)

getting 404 error.

Could you please tell how to do

#1002 (comment)
Replace directInbox() with directThread(threadId)

getting 404 error.


Schema diagram image is not loaded

Schema diagram image at https://github.com/julianhyde/foodmart-data-hsqldb/blob/master/README.md is not loaded properly. Please have a look, screenshot is attached.

Fixed in 2172ba879ffe6ba4fa40c9bcacc6bbf424978f4f.


Google Cache Links in Nuxt applications got replaceState Error and Block the Client-side Rendering

Version
v2.8.1
Reproduction link
http://webcache.googleusercontent.com/search?q=cache:https://www.nuxtjs.org
Steps to reproduce
Search for cached page on google webcache which used Nuxt. Got the error and all client-side rendering got blocked. Maybe not all but API calls and stuffs regarding store will not be loaded
What is expected ?
Page built in nuxt should be fully loaded in google webcache
What is actually happening?
Client-side rendering is not done and got blocked by an Error

Its error because it reference js file that are no longer exist. New deploy == new js files. And google cached version not the recent ones so it reference old js files that are lready delete. Nothing we could do here

Also, https://github.com/vuejs/vue-router/issues/2042 might be related.

+1 on our Nuxt 2 app


DCS_CSRF_COOKIE_SECURE doesnt work

django-cookies-samesite version: 0.9.0
Django version: 2.7
Python version: 3.7
Operating System: ubuntu 18

Description
DCS_CSRF_COOKIE_SECURE = True
DCS_CSRF_COOKIE_SAMESITE = 'None'
doesnt work

DCS_SESSION_COOKIE_SECURE = True
DCS_SESSION_COOKIE_SAMESITE = 'None'
DCS_SESSION_COOKIE_SAMESITE_FORCE_ALL = True
doesnt work as well

its ok now sry

DCS_SESSION_COOKIE_SECURE = True DCS_SESSION_COOKIE_SAMESITE = 'None' DCS_SESSION_COOKIE_SAMESITE_FORCE_ALL = True
doesnt work as well

I don't think this library already supports these settings, from the source code, I only see it is working by enabling the ssl.


Component type ist missing

I have just created a project with vite npm create vite@latest:
The type of the component is always any:

同样的问题

我也是

Same here, it's really annoying .

I haven't found a solution yet. I'm helpless.

https://github.com/vuejs/language-tools/discussions/3234 seems to be related.
I've not had this with vscode versions < 1.79.0 - but encountered it with 1.79.x insiders - and since updating vscode stable a few minutes ago, also on stable.

I have the same problem, I have the most stable version of vs code (1.79.0) and the most current version of the extension

same problem, what happen?

same problem

Same problem.
I'm using pre-realease of Volar & TypeScript Volar Plugin (but switching back to stable doesnt help either)
Volar v1.7.11
VSCode
Version: 1.80.0-insider
Commit: 6cd5ac180a6362b45b415a624f62173caf7428a1
Date: 2023-06-09T18:51:41.233Z
Electron: 22.5.5
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

I can confirm this issue
Version: 1.79.0 (user setup)
Commit: b380da4ef1ee00e224a15c1d4d9793e27c2b6302
Date: 2023-06-07T14:26:35.552Z
Electron: 22.5.5
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

FYI to solve this issue temporarily, install<EMAIL_ADDRESS>in your workspace and switch to it:

The new version of vscode ships<EMAIL_ADDRESS>which breaks the type.

This issue occurs every few version updates. It's a really long-term issue.

<EMAIL_ADDRESS>

same problem

same here

I did some investigations and found the reason: the type __VLS_GlobalComponents defined in __VLS_types.d.ts cannot be automatically loaded in typescript 5.1.

Just found the reason: Link
Unresolved any is no longer "any" ≧ ﹏ ≦

Filed an issue: https://github.com/microsoft/TypeScript/issues/54630

I updated my vscode to May 2023 version, same started happening for me, downgraded to April 2023 (version 1.78) version and it works again. ¯_(ツ)_/¯

I updated my vscode to May 2023 version, same started happening for me, downgraded to April 2023 (version 1.78) version and it works again. ¯\_(ツ)_/¯

Because the latest VSCode ships typescript 5.1.3


ISSUE-189: Add support for union record type

#189
Add test using union record
reference: use conversion similar to spark-avro which will convert union type of size > 2 to struct type.

FYI @rdsr @rdblue

Thanks @sudssf there's some internal work done on this feature by @shardulm94.  @shardulm94 please review and see if there's possibility of collaboration here.

Thanks @sudssf there's some similar work done on this feature by @shardulm94. @shardulm94 please review and see if there's possibility of collaboration here.

@shardulm94  can you please share PR?

Thanks @rdsr for the tag here, however I feel the motivation of this PR is a bit different my motivation which was to allow reading data files written with non-Iceberg writers which may contain union types. I have been thinking about this on and off for a while now and have tried to jot down my thoughts in https://docs.google.com/document/d/1Go2NrOoeCKfrDJw8MAZnsMYbE2KZbso1zkSY8cpLzaQ/edit#heading=h.gd2qof50gbzs. Since the motivation of this PR seems different though, we may want to continue this conversation in #189.

@teabot, I think the main problem with unions is the support in processing engines. It is unlikely that Spark, Presto, Impala, etc. will add support for unions. Since Iceberg is a format that we want to be suitable for a common at-rest store, it doesn't make sense to have a type that requires work-around in those engines but has only a small benefit (ensuring only one option is non-null).
I think it is unlikely that processing engines will support unions because it isn't clear how users would interact with them in SQL. For example, how do I filter to just records with a particular option of the union? That might seem easy, but it exposes underlying problems with unions and schema evolution, like identifying union fields. If we generate names based on position, what happens when that position changes? If we do it based on ID, then we're exposing internal IDs to users.
Also, what if a file is written with a version of the schema that has a new union option that isn't in the table schema? Do we choose another incorrect branch (null or default) or do we throw an exception?
I think it is the right choice to continue using the more standard and well-defined types rather than adding union, since it would make it much harder to integrate Iceberg into processing engines.

Thanks for the context, @teabot.
For our streaming systems, we aren't supporting the case you're talking about and each stream (Kafka topic) is getting its own Iceberg schema so that schema evolution works mostly the same way for a topic as it does for a table. That aligns well with streaming SQL use cases, which we hope will make it easier to use streaming systems. It doesn't help the problem of event ordering across event types, though, which are required to be in separate streams unless they use the union-as-struct convention.
I think the trade-off is worth it. In most cases you don't need strict order guarantees across event types. Where you do, you can either join two streams with a common ordinal field or make the schema slightly more complex using the union-as-struct approach if you need to avoid the join.

Since there hasn't been any further progress on this, I'm going to close it. Feel free to reopen it if you'd like to continue working on a read path for existing data files with union types. I don't think that it is likely that we would make changes that allow writing data with unions, though.


Title missing from the list

As you can see, one chapter is missing, and when I press react, react native appears. If I reload the page, the same issue occurs
_meta.json
  "-- WebDev --": {
    "type": "separator",
    "title": "Web Development"
  },
  "html": "HTML Tutorial",
  "tailwindcss": "Tailwind CSS Tutorial",
  "js" : "JavaScript Tutorial",
  "react": "React Tutorial",
  "reactnative": "React NativeTutorial",

https://user-images.githubusercontent.com/120297915/216807001-12b214d1-fc15-4a91-b103-51a14b9366e7.mp4

Please provide a reproduction

@luke-klein Maybe this solution https://github.com/shuding/nextra/issues/1564#issuecomment-1447419595 will help you?


Don't return undefined description when recipe is unnamed

I think here is expects undefined and will fail:
https://github.com/PolymerLabs/arcs/blob/master/runtime/test/description-test.js#L638


Move clustered renderer functionality

Doing a few changes to the forward clustered renderer:

moved into its own folder
added into namespace (after discussing with Reduz I was already doing this for forward mobile), names were getting far too long and this will never be exposed to GDScript
added option to disable cluster and volumetric fog from subclass as we need to disable this in the mobile renderer.

Volumetric fog should be usable on mobile to be honest without much effort, so I would not disable it, but it would it wont support positional and omni lights due to the lack of cluster.

Even GIProbe should be usable on mobile, but we run into the problem that it cant be used in lower resolution so its most likely kinda pointless, which is why it should most likely be disabled.

@reduz the problem is that the current implementation of fog is very much intertwined with GI and cluster. If we want to make it work for mobile we'll need to redo a bit of it. In that way having a switch to turn it on/off independent of GI and cluster seems like a good idea because we can turn it back on once we do the work, or if we find out we need a different implementation for mobile, we can just build it into mobile.

Squashed the two commits and made name changes as suggested by Reduz.

Even GIProbe should be usable on mobile, but we run into the problem that it cant be used in lower resolution so its most likely kinda pointless, which is why it should most likely be disabled.

Just to add after a brief discussion on Godot Chat. seems at this point the consensus is to keep things simple and get the mobile renderer working with basic stuff first Then we can evaluate if and how we'll add GI and fog back in. That will likely end up changing how we enable/disable logic but I think by then we'll also have the experience to decide what the optimal solution really is here.

Is this ready for final review/merging?

Is this ready for final review/merging?

Yeah as far as I'm concerned its ready for merging.


[reinforcement] Async MCTS implementation details

Hey,
Can you elaborate or point me to a reference regarding the threaded scheme used during self play MCTS.
What structure do the threads share, specifically how are the leaves collected and batched?
Thank you for your contribution!

We don't have a good explanation for that right now (beyond the code itself); the papers in linked in the README might be able to shed some light.
I believe right now, it is significantly serial... We achieve most parallelism by having multiple processes going (as opposed to threads).
Here is where we loop to do "readouts" from the tree;
https://github.com/mlperf/reference/blob/fc5e962d9dd19ab7c02452693272da073ab03762/reinforcement/tensorflow/minigo/selfplay_mcts.py#L57
Collection logic comes through here, I believe;
https://github.com/mlperf/reference/blob/fc5e962d9dd19ab7c02452693272da073ab03762/reinforcement/tensorflow/minigo/strategies.py#L166
This isn't exactly parallel (I think only about 2 CPUs are active in the reference implementation per selfplay worker).
There are significant improvements that can be made to this process for performance, but this implementation isn't leveraging many of them.

As of v0.6, self play is done in C++.
A single process plays multiple games, with each game being played on its own thread. Each thread uses virtual loss to collect 8 leaves which it then sends to a batcher for inference. The batcher collects inferences from multiple threads into a large batch, which it then sends for inference.


time.Duration in a read only table isn't read only

Describe the bug
When a struct has a time.Duration field and is used in a read only table, the DurationInput isn't read only.
How to reproduce
Run this code.
Example code
type SomeStruct struct {
    Took time.Duration
}
core.NewTable(b).SetSlice(&[]SomeStruct{{time.Duration(time.Minute)}, {time.Duration(time.Hour}).SetReadOnly(true)

Relevant output
No response
Platform
macOS

Thank you for reporting this! I will fix this now.


build: bump up versions and dependencies

bump up versions and dependencies for rc6

Codecov Report

Merging #685 (7467738) into main (d35d85c) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   63.94%   63.94%
=======================================
  Files          40       40
  Lines        2219     2219
=======================================
  Hits         1419     1419
  Misses        679      679
  Partials      121      121

Impacted Files
Coverage Δ

internal/version/version.go
100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


DeployBC Azure VM server certificates expired 'cloudapp.azure.com' certs - Can't renew them.

Our deployBC hosts in Azure have all expired server certificates and when I try to renew them in MMC I get this error.

disregard - it was selfsigned certs used and need to be reissued and applied to winrm service.


⚠ Bofrost.be has degraded performance

In 45723fd, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1050 ms

Resolved: Bofrost.be performance has improved in 4b659ba after 6 minutes.


Allow bot messages config option

Thank you for your contribution!

oo thats funny recently added this to my fork to, but didnt push it to a PR here ...
looks like i implemented it a little differently mainly due to webhooks..
does your implementation, also ignore its own webhookss ?? ..
as the way i did it was ...
        //ignoring of bots
        if (event.getAuthor().isBot() && !config.listentoBots) { return; }
        //ignoring of your own webhooks or embeds/messages
        if (config.webhookUrl.contains(event.getAuthor().getId()) | event.getAuthor().equals(event.getJDA().getSelfUser())) {
            return;


[BD-6] Add travis

Add travis file.
Add travis requirements.
Reviewers

[ ] @awais786
[ ] @morenol
[ ] @nedbat

Thanks for the pull request, @ericfab179! I've created OSPR-4665 to keep track of it in JIRA, where we prioritize reviews.  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@ericfab179 🎉 Your pull request was merged!
Please take a moment to answer a two question survey so we can improve your experience in the future.

I think that this needs to be activated in travis, who should do that? @awais786

@jmbowman ?


now dev - throwing 404 on subdirectories containing .html files

Deploying static files with a now.json like
{
  "version": 2
}

and a directory like
- /
 now.json
 index.html
   - pages
   other.html

while linking to other.html from index.html
will work deploying with now but results in a 404 page when testing locally with now dev.

Closing because I can not reproduce this using the latest version of Now CLI. Repro repository is here: https://github.com/TooTallNate/now-cli-2362
Please create a new issue if you are still having any problems.


Is there any paper for reference?

Have you made any changes in your work?

No, this repo was intended to add HyperParameterOptimization. But it is decided not to.


Analyzer produces "strong_mode_not_instantiated_bound" error message which can be more useful.

Dart version: 2.4.0-dev.0.0
The following code sample:
class A<T extends A> {}
main() {}

produces the following output when run processed by dartanalyzer:

$> dartanalyzer test.dart
Analyzing test.dart...
error - Type parameter bound types must be instantiated at test.dart:1:19 - strong_mode_not_instantiated_bound
1 error found.

Strong mode is deprecated now, so mention of it in the error message which appears in default mode looks a little bit strange here. It seems like analyzer should produce something  more informative.
For example, here is dart output:

$> dart test.dart
test.dart:1:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
Try providing type arguments to 'A' here.
class A {}
^

Also, @eernstg, why is it not just a raw type instantiated with dynamic, which would be a valid super-bounded type?

why is it not just a raw type

The relevant error message is actually that A cannot occur as a bound, because it is raw and does not have simple bounds. We introduced the concept of a simple bound in order to ensure that tools could have good performance (because there is no need to run a fixed point iteration during instantiation to bound, because cyclic dependencies are non-simple).
So it's very nearly correct that Type parameter bound types must be instantiated, it should just have been Type parameter bound types must be instantiated, unless they have simple bounds.
For the UX, the very concept of saying simple bounds in an error message is not nice, but the underlying problem is actually that A is too complex to allow it to be raw as a bound, so it might be OK to say something like The type parameter bound A must receive type arguments. That's sufficient to tell the developer that A must be changed to A<T> for some T, and then simple bounds actually only matter for those folks who want to know exactly when this can happen.

The error message now does not mention strong mode:

error • Type parameter bound types must be instantiated. • 37290.dart:1:19 • not_instantiated_bound


Default test configuration prevents using VSCode debugger

Description
With this launch.json:
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Debug NetCDF test",
            "type": "debugpy",
            "request": "launch",
            "module": "pytest",
            "justMyCode": false,
            "args": [
                "-s",
                "--log-cli-level=DEBUG",
                "-vvv",
                "-k",
                "pass_credentials",
                "tests/netcdf/test_netcdf_dataset.py"
            ],
            "cwd": "${workspaceFolder}/kedro-datasets"
        }
    ]
}

I was being unable to do a proper debugging (VSCode would skip all me breakpoints). Then after squinting at the logs I found this:
PYDEV DEBUGGER WARNING:
sys.settrace() should not be used when the debugger is being used.
This may cause the debugger to stop working correctly.
If this is needed, please check:
http://pydev.blogspot.com/2007/06/why-cant-pydev-debugger-work-with.html
to see how to restore the debug tracing back correctly.
Call Location:
  File "/Users/juan_cano/.micromamba/envs/kedro39-dev/lib/python3.9/site-packages/coverage/collector.py", line 348, in _installation_trace
    sys.settrace(None)

It turns out we're adding --cov in all pytest invokations:
https://github.com/kedro-org/kedro-plugins/blob/f33acbea33628abfc98a5c112e49931988f29b5a/kedro-datasets/pyproject.toml#L38-L43
Removing those lines allowed me to perform a normal debugging session.

@astrojuanlu Do you know if this is a problem for just VSCode or other IDEs as well?

It's been a few years since I last used PyCharm but I recall this used to be a problem there as well. So it probably affects other IDEs.

This affect PyCharm too. This mainly affect maintainers/contributor because debugging a Kedro project won't have this problem. This only exists in the kedro/kedro-datasets repository


Insert option value improvement suggestions

Firstly, thank you for this immensely useful solution - I only wish I was a good enough coder to be able to contribute as well.
Regarding the Insert option value, I have 2 suggestions for improvements:

Allow the value field to be optional so that it is automatically assigned the next number available
Allow the newly created value to be used in subsequent workflow steps so that the value can be created and then immediately used.

Thanks stevenfayers for the Idea.
I'll try to ionclude in next releases!
regards!


Add triplebyte.com

Funded by Y Combinator, according to their email.  But an unsolicited email nonetheless!

This one might be on the line. Looks like they are training company?


add oral cavity subsites

Since the data from Bern contains mostly oral cavity patients, I need to add this to the display of the interface.
Oral cavity is defined as all ICD codes with C02, C03, C04, C05, C06, and C08.

Remove salivary glands (C08.X) again, that's quite special (and Bern has only one patient with that ICD code).


[FE] Change python interpreter from python to python3 in fe-core module

Why I'm doing:
it is more reasonable.
What I'm doing:
Change python interpreter from python to python3
Fixes #https://github.com/StarRocks/starrocks/issues/52733
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[x] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Euroc example fails to start

Description:
It seems the script launching the Euroc example contains some unsupported flags. After removing the flags from the bash script, the example runs correctly.
Command:
# bash ./scripts/stereoVIOEuroc.bash -p /home/martino/Data/euroc/mav0/

Console output:

Using dataset at path: /home/martino/Data/euroc/mav0/
 Launching:

            ██╗  ██╗██╗███╗   ███╗███████╗██████╗  █████╗
            ██║ ██╔╝██║████╗ ████║██╔════╝██╔══██╗██╔══██╗
            █████╔╝ ██║██╔████╔██║█████╗  ██████╔╝███████║
            ██╔═██╗ ██║██║╚██╔╝██║██╔══╝  ██╔══██╗██╔══██║
            ██║  ██╗██║██║ ╚═╝ ██║███████╗██║  ██║██║  ██║
            ╚═╝  ╚═╝╚═╝╚═╝     ╚═╝╚══════╝╚═╝  ╚═╝╚═╝  ╚═╝

ERROR: unknown command line flag 'colorlogtostderr'
ERROR: unknown command line flag 'log_prefix'
ERROR: unknown command line flag 'logtostderr'
ERROR: unknown command line flag 'v'
ERROR: unknown command line flag 'vmodule'

Additional files:
Please attach all the files needed to reproduce the error.
Please give also the following information:

SparkVio branch, tag or commit used: bceed7203f
GTSAM version used: 4.0.2
OpenGV version used: commit 306a54e
OpenCV version used: 3.4.7
Operating system and version (e.g. Ubuntu 16.04 or Windows 10): Arch Linux, kernel 4.19.95
Did you change the source code? (yes / no): no

This might be because glog or gflags are not correctly linked.
Did you install them?
sudo apt-get install libgoogle-glog-dev libgflags-dev

I am sure glog and gflags were installed. Also, other command line flags for the program were working, just the five I mentioned in the issue were not recognised by the application.
Sadly I have wiped the machine where I encountered the issue, and I am not working on this any longer, so it is fine for me if you close the issue in case you cannot reproduce it.

I actually encountered this issue just recently. It seems like Kimera was linking to a local installation of gflags, which was different than the gflags used by glog.
Modifying the variable:   in the cmake cache solved the issue.
Running cmake-gui . in the build folder, one should see the following entries:

Where originally one of the cmake flags was pointing to a local installation of gflags.
(Btw this only applies to Kimera-VIO (no ROS), since with Kimera-VIO-ROS, Kimera should be linking with gflags provided by gflags_catkin).
Leaving this here just for the sake of completeness.

i have the same problem, i have change the source to commit  f32943c, but when i ldd the output library,
ldd libkimera_vio.so | grep libglog , it return nothing. But the print the cmake seems ok,
-- ==============================================================
-- ====================  Dependencies ===========================
-- Boost version: 1.58.0
-- Found the following Boost libraries:
--   filesystem
--   serialization
--   regex
--   timer
--   date_time
--   thread
--   system
--   chrono
--   atomic
-- Found glog    (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libglog.so)
-- GTSAM include directory:  /usr/local/lib/cmake/GTSAM/../../../include
-- Vocabulary file exists, will not download.
-- ===============================================================
-- ================  Configuration Options  ======================
-- CMAKE_CXX_COMPILER_ID type                : GNU
-- CMAKE_CXX_COMPILER_VERSION                : 7.5.0
-- Build flags
--   Build type                              : Release
--   C compilation flags (Release)           :  -O3 -DNDEBUG
--   C++ compilation flags (Release)         :  -O3 -DNDEBUG
-- Configuring done
-- Generating done


"reviewed" event is not documented for timeline

endpoint scope: issues
endpoint name: Timeline
route: /repos/:owner/:repo/issues/:number/timeline
documentation URL: https://developer.github.com/v3/issues/timeline/

Current specification
https://github.com/octokit/routes/blob/master/openapi/api.github.com/operations/issues/list-events-for-timeline.json
I expected
Documentation here https://developer.github.com/v3/issues/timeline/ does not look comprehensive - i.e. through API I see other event times not mentioned in the spec, e.g. "reviewed"
curl -H "Accept: application/vnd.github.mockingbird-preview" https://api.github.com/repos/octokit/routes/issues/597/timeline

sample json
[
  {
    "sha": "3393a660c742db8553a96db07a38e4a739602cf5",
    "node_id": "MDY6Q29tbWl0MTI0Mjg5ODA1OjMzOTNhNjYwYzc0MmRiODU1M2E5NmRiMDdhMzhlNGE3Mzk2MDJjZjU=",
    "url": "https://api.github.com/repos/octokit/routes/git/commits/3393a660c742db8553a96db07a38e4a739602cf5",
    "html_url": "https://github.com/octokit/routes/commit/3393a660c742db8553a96db07a38e4a739602cf5",
    "author": {
      "name": "dependabot[bot]",
      "email"<EMAIL_ADDRESS>      "date": "2019-12-13T18:55:36Z"
    },
    "committer": {
      "name": "GitHub",
      "email"<EMAIL_ADDRESS>      "date": "2019-12-13T18:55:36Z"
    },
    "tree": {
      "sha": "c7e7be3d553a073720e80612f79f018ea467eb27",
      "url": "https://api.github.com/repos/octokit/routes/git/trees/c7e7be3d553a073720e80612f79f018ea467eb27"
    },
    "message": "build(deps): bump npm from 6.13.1 to 6.13.4\n\nBumps [npm](https://github.com/npm/cli) from 6.13.1 to 6.13.4.\n- [Release notes](https://github.com/npm/cli/releases)\n- [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md)\n- [Commits](https://github.com/npm/cli/compare/v6.13.1...v6.13.4)\n\nSigned-off-by: dependabot[bot]<EMAIL_ADDRESS>    "parents": [
      {
        "sha": "31bad0aa0a681fb4ddb3fbe552e24ce9cb384bb7",
        "url": "https://api.github.com/repos/octokit/routes/git/commits/31bad0aa0a681fb4ddb3fbe552e24ce9cb384bb7",
        "html_url": "https://github.com/octokit/routes/commit/31bad0aa0a681fb4ddb3fbe552e24ce9cb384bb7"
      }
    ],
    "verification": {
      "verified": true,
      "reason": "valid",
      "signature": "-----BEGIN PGP SIGNATURE-----\n\nwsBcBAABCAAQBQJd896oCRBK7hj4Ov3rIwAAdHIIAJd6ZAjFqLD+sEwvJDGhxUZ3\nE2DAqsHYBKDKgztZRxxct3UfjB/gdiGX+54S4xskRvmL0fEOEyoSAuS2/I6yHAXe\nFPdkjwgujqL9IzE0MILWpzXnxkjCX8WzB+LBpMrMtlEP/TMEgrrILxtkwP6OA9K5\nu1PZQqaJ9FtLM2B1PMC6Qqba8slGCm/bg/mqqDEK6ZrGnfKY9RUyN43slGZQ9Lsp\ne5LVfKDCU9HoXDGIuPysaJq/ruKy0YftGTB9rKlXCJc4coOweIvDSfy35U0rS/0e\nyBCFyicd9idhNE1fnCgSoQkco3dTe21MxXsxsVEEFf+Kfxop9/cOFVgkhhV8KqI=\n=bKrl\n-----END PGP SIGNATURE-----\n",
      "payload": "tree c7e7be3d553a073720e80612f79f018ea467eb27\nparent 31bad0aa0a681fb4ddb3fbe552e24ce9cb384bb7\nauthor dependabot[bot]<EMAIL_ADDRESS>1576263336 +0000\ncommitter GitHub<EMAIL_ADDRESS>1576263336 +0000\n\nbuild(deps): bump npm from 6.13.1 to 6.13.4\n\nBumps [npm](https://github.com/npm/cli) from 6.13.1 to 6.13.4.\n- [Release notes](https://github.com/npm/cli/releases)\n- [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md)\n- [Commits](https://github.com/npm/cli/compare/v6.13.1...v6.13.4)\n\nSigned-off-by: dependabot[bot]<EMAIL_ADDRESS>    },
    "event": "committed"
  },
  {
    "id":<PHONE_NUMBER>,
    "node_id": "MDEyOkxhYmVsZWRFdmVudDI4ODIzMzE1NDQ=",
    "url": "https://api.github.com/repos/octokit/routes/issues/events/2882331544",
    "actor": {
      "login": "dependabot[bot]",
      "id": 49699333,
      "node_id": "MDM6Qm90NDk2OTkzMzM=",
      "avatar_url": "https://avatars0.githubusercontent.com/in/29110?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/dependabot%5Bbot%5D",
      "html_url": "https://github.com/apps/dependabot",
      "followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
      "following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
      "gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
      "organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
      "repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
      "events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
      "received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
      "type": "Bot",
      "site_admin": false
    },
    "event": "labeled",
    "commit_id": null,
    "commit_url": null,
    "created_at": "2019-12-13T18:55:39Z",
    "label": {
      "name": "dependencies",
      "color": "0366d6"
    }
  },
  {
    "id": 332157887,
    "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzMyMTU3ODg3",
    "user": {
      "login": "jovel",
      "id": 96927,
      "node_id": "MDQ6VXNlcjk2OTI3",
      "avatar_url": "https://avatars2.githubusercontent.com/u/96927?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jovel",
      "html_url": "https://github.com/jovel",
      "followers_url": "https://api.github.com/users/jovel/followers",
      "following_url": "https://api.github.com/users/jovel/following{/other_user}",
      "gists_url": "https://api.github.com/users/jovel/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jovel/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jovel/subscriptions",
      "organizations_url": "https://api.github.com/users/jovel/orgs",
      "repos_url": "https://api.github.com/users/jovel/repos",
      "events_url": "https://api.github.com/users/jovel/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jovel/received_events",
      "type": "User",
      "site_admin": true
    },
    "body": "",
    "commit_id": "3393a660c742db8553a96db07a38e4a739602cf5",
    "submitted_at": "2019-12-13T22:55:55Z",
    "state": "approved",
    "html_url": "https://github.com/octokit/routes/pull/597#pullrequestreview-332157887",
    "pull_request_url": "https://api.github.com/repos/octokit/routes/pulls/597",
    "author_association": "NONE",
    "_links": {
      "html": {
        "href": "https://github.com/octokit/routes/pull/597#pullrequestreview-332157887"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/octokit/routes/pulls/597"
      }
    },
    "event": "reviewed"
  },
  {
    "id":<PHONE_NUMBER>,
    "node_id": "MDE1OlJlZmVyZW5jZWRFdmVudDI4ODI4OTQyMjc=",
    "url": "https://api.github.com/repos/octokit/routes/issues/events/2882894227",
    "actor": {
      "login": "jovel",
      "id": 96927,
      "node_id": "MDQ6VXNlcjk2OTI3",
      "avatar_url": "https://avatars2.githubusercontent.com/u/96927?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jovel",
      "html_url": "https://github.com/jovel",
      "followers_url": "https://api.github.com/users/jovel/followers",
      "following_url": "https://api.github.com/users/jovel/following{/other_user}",
      "gists_url": "https://api.github.com/users/jovel/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jovel/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jovel/subscriptions",
      "organizations_url": "https://api.github.com/users/jovel/orgs",
      "repos_url": "https://api.github.com/users/jovel/repos",
      "events_url": "https://api.github.com/users/jovel/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jovel/received_events",
      "type": "User",
      "site_admin": true
    },
    "event": "referenced",
    "commit_id": "5b7a46c49dec4d7ba1aa23aa23ff5c4bddc8b1f2",
    "commit_url": "https://api.github.com/repos/octokit/routes/commits/5b7a46c49dec4d7ba1aa23aa23ff5c4bddc8b1f2",
    "created_at": "2019-12-13T22:56:24Z"
  },
  {
    "id":<PHONE_NUMBER>,
    "node_id": "MDExOk1lcmdlZEV2ZW50Mjg4Mjg5NDIzMQ==",
    "url": "https://api.github.com/repos/octokit/routes/issues/events/2882894231",
    "actor": {
      "login": "jovel",
      "id": 96927,
      "node_id": "MDQ6VXNlcjk2OTI3",
      "avatar_url": "https://avatars2.githubusercontent.com/u/96927?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jovel",
      "html_url": "https://github.com/jovel",
      "followers_url": "https://api.github.com/users/jovel/followers",
      "following_url": "https://api.github.com/users/jovel/following{/other_user}",
      "gists_url": "https://api.github.com/users/jovel/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jovel/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jovel/subscriptions",
      "organizations_url": "https://api.github.com/users/jovel/orgs",
      "repos_url": "https://api.github.com/users/jovel/repos",
      "events_url": "https://api.github.com/users/jovel/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jovel/received_events",
      "type": "User",
      "site_admin": true
    },
    "event": "merged",
    "commit_id": "5b7a46c49dec4d7ba1aa23aa23ff5c4bddc8b1f2",
    "commit_url": "https://api.github.com/repos/octokit/routes/commits/5b7a46c49dec4d7ba1aa23aa23ff5c4bddc8b1f2",
    "created_at": "2019-12-13T22:56:24Z"
  },
  {
    "id":<PHONE_NUMBER>,
    "node_id": "MDExOkNsb3NlZEV2ZW50Mjg4Mjg5NDIzNw==",
    "url": "https://api.github.com/repos/octokit/routes/issues/events/2882894237",
    "actor": {
      "login": "jovel",
      "id": 96927,
      "node_id": "MDQ6VXNlcjk2OTI3",
      "avatar_url": "https://avatars2.githubusercontent.com/u/96927?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jovel",
      "html_url": "https://github.com/jovel",
      "followers_url": "https://api.github.com/users/jovel/followers",
      "following_url": "https://api.github.com/users/jovel/following{/other_user}",
      "gists_url": "https://api.github.com/users/jovel/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jovel/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jovel/subscriptions",
      "organizations_url": "https://api.github.com/users/jovel/orgs",
      "repos_url": "https://api.github.com/users/jovel/repos",
      "events_url": "https://api.github.com/users/jovel/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jovel/received_events",
      "type": "User",
      "site_admin": true
    },
    "event": "closed",
    "commit_id": null,
    "commit_url": null,
    "created_at": "2019-12-13T22:56:24Z"
  },
  {
    "id":<PHONE_NUMBER>,
    "node_id": "MDE5OkhlYWRSZWZEZWxldGVkRXZlbnQyODgyODk0MjYz",
    "url": "https://api.github.com/repos/octokit/routes/issues/events/2882894263",
    "actor": {
      "login": "jovel",
      "id": 96927,
      "node_id": "MDQ6VXNlcjk2OTI3",
      "avatar_url": "https://avatars2.githubusercontent.com/u/96927?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jovel",
      "html_url": "https://github.com/jovel",
      "followers_url": "https://api.github.com/users/jovel/followers",
      "following_url": "https://api.github.com/users/jovel/following{/other_user}",
      "gists_url": "https://api.github.com/users/jovel/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jovel/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jovel/subscriptions",
      "organizations_url": "https://api.github.com/users/jovel/orgs",
      "repos_url": "https://api.github.com/users/jovel/repos",
      "events_url": "https://api.github.com/users/jovel/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jovel/received_events",
      "type": "User",
      "site_admin": true
    },
    "event": "head_ref_deleted",
    "commit_id": null,
    "commit_url": null,
    "created_at": "2019-12-13T22:56:26Z"
  }
]

I think that event payloads are the same as shown on https://developer.github.com/v3/activity/events/types/. If that's the case we could maybe leverage the scraped data from https://github.com/octokit/webhooks
If the docs are out of sync or lacking, it would be great to contact<EMAIL_ADDRESS>They will forward your request to the right people. You can send along a link to this issue


AutoGraph is compiled 5x slower in TF2.x Multi-GPU Distributed Mirrored Strategy

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.3 LTS
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.1.0-rc0-47-g064e153 2.1.0-rc1 (python3 -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)")
Python version: Python 3.6.8
CUDA/cuDNN version: Driver Version: 440.33.01, CUDA Version: 10.2, cuDNN 7.6.2
GPU model and memory: Tesla V100-SXM2-16GB

Describe the current behavior
Compiling autograph function is 4-5x slower in Distributed Mirrored Strategy:

Single-GPU Distributed Mirrored Strategy: under 5 minutes
Multi-GPU Distributed Mirrored Strategy: about 30 minutes
The tensorflow code is identical in both setups.

Describe the expected behavior
Autograph compilation should take roughly the same time in single and multi-GPU Distributed Mode with Mirrored Strategy.
Code to reproduce the issue
Training loop (hierarchical VAE in the current configuration):
https://github.com/olegmyrk/SPADE-Tensorflow/blob/4681ac60f2078144d55178f23fa885d3ed191450/SPADE.py#L1151
The code is adapted from TF1.x repository:
https://github.com/olegmyrk/SPADE-Tensorflow/blob/8866a0b1457cbd4be5d6f549f9bf4075d49b2486/SPADE.py#L1045
and is compiled using TF2.x @tf.function annotation.
It uses a dry-run of the model to pre-create variables using tf.compat.v1.variable_scope(scope, reuse=tf.compat.v1.AUTO_REUSE):
https://github.com/olegmyrk/SPADE-Tensorflow/blob/4681ac60f2078144d55178f23fa885d3ed191450/SPADE.py#L1174
(it takes about 10 minutes to compile and run it in multi-gpu mode)
Then it runs the actual training step(s)
https://github.com/olegmyrk/SPADE-Tensorflow/blob/4681ac60f2078144d55178f23fa885d3ed191450/SPADE.py#L1257
(it takes about 20 minutes to compile and run it for the first time in multi-gpu mode)
It looks that just disabling lines with 'optim.apply_gradients'
https://github.com/olegmyrk/SPADE-Tensorflow/blob/4681ac60f2078144d55178f23fa885d3ed191450/SPADE.py#L1229
https://github.com/olegmyrk/SPADE-Tensorflow/blob/4681ac60f2078144d55178f23fa885d3ed191450/SPADE.py#L1231
https://github.com/olegmyrk/SPADE-Tensorflow/blob/4681ac60f2078144d55178f23fa885d3ed191450/SPADE.py#L1233
slashes about 10 out 20 minutes needed for initial run in multi-gpu mode. Which is essentially compiling back-propagation?
After the first training step that takes 20 minutes the following training steps run at normal speed.
The total number of mirrored parameters is around 500MB.
With 4 V100 GPUs training step is around 5x slower than with single V100 GPU.
Command:
NCCL_DEBUG=INFO NCCL_DEBUG_SUBSYS=ALL nohup python3 main.py --dataset CelebAMask-HQ --img_height 256 --img_width 256 --ch 16 --img_ch 3 --phase train --save_freq 10000 --batch_size 12 --gan_type hinge --code_gan_type gan --n_critic 1 --code_num_layers=4 --code_dist_num_layers=0 --augment_flag false --sn=False --train_main=true --train_nondet=true --lr 0.0002 --epoch=50 --decay_epoch=25 --print_freq 100 &> train.CelebAMask-HQ.log&
Other info / logs
train.CelebAMask-HQ.slow_compile.log

I've managed to create a minimalistic script to demonstrate that in multi-gpu autograph distributed mirrored mode compiling a function is 3-5x slower than in single-gpu mode.
The performance seems to be a linear function of total variable size. The total size of variables in the script is 512x512x512x4=0.5GB. Can it be that variable initialization is the (serial) bottleneck?
In my real code this means that I have to wait 15 minutes for my network to build in mutli-gpu mode.
Single-gpu:
CUDA_VISIBLE_DEVICES=0 time python3 test.py

Result:
...
step: 0
result tf.Tensor(0.0, shape=(), dtype=float32)
duration: 18.859039783477783
...
step: 99
result tf.Tensor(0.0, shape=(), dtype=float32)
duration: 0.022214174270629883
37.66user 7.78system 0:45.83elapsed 99%CPU (0avgtext+0avgdata 2216764maxresident)k
0inputs+120outputs (0major+463050minor)pagefaults 0swaps

Multi-gpu:
CUDA_VISIBLE_DEVICES=0,1,2,3 time python3 test.py

Result:
step: 0
result tf.Tensor(0.0, shape=(), dtype=float32)
duration: 68.2149806022644
...
step: 99
result tf.Tensor(0.0, shape=(), dtype=float32)
duration: 0.025103092193603516
188.86user 11.69system 3:11.94elapsed 104%CPU (0avgtext+0avgdata 6538540maxresident)k
0inputs+144outputs (0major+1564442minor)pagefaults 0swaps

The script:
import time
import numpy as np
import tensorflow as tf

distribute_strategy = tf.distribute.MirroredStrategy()

dataset = tf.data.Dataset.from_tensor_slices(([np.zeros((512,),np.float32)]))
dataset = dataset.repeat(None).batch(64)
dataset = dataset.prefetch(tf.data.experimental.AUTOTUNE)
dataset = distribute_strategy.experimental_distribute_dataset(dataset)
dataset = iter(dataset)

with distribute_strategy.scope():
  optim = tf.keras.optimizers.Adam(0.0002)

  def layer(x, scope):
    with tf.compat.v1.variable_scope(scope, reuse=tf.compat.v1.AUTO_REUSE):
        w = tf.compat.v1.get_variable("w", shape=(512,512), initializer=tf.compat.v1.random_normal_initializer())
        return tf.linalg.matvec(w,x)

  def compute(x):
    r = 0
    for i in range(0,512):
      r = r + layer(x, "layer_" + str(i))
    r = tf.reduce_mean(r)
    return r

  @tf.function
  def build(x):
    r = compute(x)
    return r

  v = tf.compat.v1.trainable_variables()

  fake_x = np.zeros((1,512,),np.float32)
  result = distribute_strategy.experimental_run_v2(build, args=(fake_x,))

  @tf.function
  def train(x):
    def train_fn(x):
      with tf.GradientTape(persistent=True) as tape:
        r = compute(x)
      g = tape.gradient(r,v)
      optim.apply_gradients(zip(g, v), v)
      return r
    result = distribute_strategy.experimental_run_v2(train_fn, args=(x,))
    result = tf.reduce_mean(distribute_strategy.experimental_local_results(result))
    return result

  for i in range(0,100):
      start = time.time()
      print("step:", i)
      x = next(dataset)
      result = train(x)
      print("result", result)
      print("duration:", time.time()-start)

Also see this issue:
https://github.com/tensorflow/tensorflow/issues/35415#issuecomment-570075254

olegmyrk@ this issue is a known one and due to the fact that we trace the train function on each of the GPUs sequentially. This is known to result in slow start up times when using MirroredStrategy.

@anj-s  Is there any way to speed up the compilation?
I am currently training 7 models in tf.function, and it takes more than 20 minutes to start training !!! Very bad.
I observed that the CPU can only use one core to compile, is there any way to start multiple threads to compile at the same time?

@rohan100jain this is an example of a painfully slow tf.function tracing + compilation

This is a known issue with tf.function and multiple devices right now. @allenlavoie is working on something that might help with this

Any solution now?

Discovered this issue as well when scaling up to use multiple GPUs for a densenet. With multi GPU servers tending to have a ton of cores and be bursting with RAM, and the startup being something that's inherently parallelisable and relatively slow, it's a shame not to exploit available resources to accelerate startup as much as possible. Would be good to know if this is realistically likely to be an issue indefinitely, or whether it's on the cards to be improved soon.   I'm also surprised that the result of compilation isn't cached to be reused on a subsequent run, either with automatic detection of a modified model or reliant on a user supplied id and the caveat that if you change the model and don't refresh the id, then don't expect things to work as you expect. I'd take that every time over twiddling my thumbs for some minutes waiting for something to start happening and adding 10% or more to the training time.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Google changed their spec on [dimension] filters. That functionality needs work.

We're evaluating which GAv4 gem we want to go with and this one seems the most promising. However things have changed a bit and it seems Google is no longer using the dimensionFilter key to accept filters.
I envision this class (and the README docs) needs a little updating: https://github.com/dailytics/google_analytics_v4_api/blob/main/lib/google_analytics_v4_api/report.rb
Would a pull request or two from me be welcome to update this gem? Is anyone still here @luctus? Just checking before I potentially hard-fork on Monday to make this code work for us.

Hey @Ben-Fenner!
Thanks for reporting this issue.
I will try to take a look during the weekend. If can't make it, I'd love your help here.
Cheers.

BTW, can you elaborate your point? I just revisit their documentation and everything looks the same:
https://developers.google.com/analytics/devguides/reporting/data/v1/basics#group_and_filter_data

Thank you for the reply @luctus!
I just came back to say I'm confused, since their docs say things should work. Here's a slightly more relevant link?
https://developers.google.com/analytics/devguides/reporting/data/v1/basics#filter
So we've come to the same conclusion. Anyway, I'll come back with concrete error messages for you and a way to reproduce the issue. But even if I do, I wonder if maybe I'm using the filters wrong anyway, and fixing that on my side will solve the problem.
Sit tight. I'll report back.

So here is what I'm doing, and what I'm seeing as a response.
In a Rails console:
scope    = 'https://www.googleapis.com/auth/analytics.readonly'
token    = GoogleAnalytics.service_account_access_token(scope).token # Confirmed valid token.
client   = GoogleAnalyticsV4Api::Client.new(token)
account  = client.account('accounts/xxxxxxx')       #  Account display name: [Redacted]
property = account.property('properties/xxxxxxxxx') # Property display name: [Redacted]

# Yes, these filters are completely malformed. This is how we did it in GA3, so just throwing it against the wall for now.
filters    = ["pagePath=~/manual_transmissions/.+/show_public",
              "hostName!~subdomain.example.com"]
begin_date = Date.parse('2023-06-01')
end_date   = Date.parse('2023-08-01')

report = GoogleAnalyticsV4Api::Report.new(
  start_date:       begin_date,
  end_date:         end_date,
  dimensions:       ['pagePath', 'hostName', 'date'],
  dimension_filter: filters,
  metrics:          ['screenPageViews'],
  limit:            GoogleAnalytics::MAX_RESULTS)

response = property.run_report(report)

And here is the value of response returned:
#<GoogleAnalyticsV4Api::ReportResponse:0x00005620f6f92ca8 @body={"error"=>{"code"=>400, "message"=>"Invalid JSON payload received. Unknown name \"dimensionFilter\": Proto field is not repeating, cannot start list.", "status"=>"INVALID_ARGUMENT"<EMAIL_ADDRESS>"fieldViolations"=>[{"description"=>"Invalid JSON payload received. Unknown name \"dimensionFilter\": Proto field is not repeating, cannot start list."}]}]}}, @raw_dimension_headers=[], @raw_metric_headers=[], @rows=[], @row_cont=0, @metadata=nil, @kind=nil>

Everything works swimmingly if I instead do this:
report = GoogleAnalyticsV4Api::Report.new(
  start_date:       begin_date,
  end_date:         end_date,
  dimensions:       ['pagePath', 'hostName', 'date'],
  dimension_filter: {},
  metrics:          ['screenPageViews'],
  limit:            GoogleAnalytics::MAX_RESULTS)

Which I assume forgoes the dimensionFilter key from the request.
So yah, I'm still not convinced that there is an issue with the gem. It might be that my malformed filters just need work. I will work on converting those from GA3 style to GA4 and see how that goes. In the mean time I'll take an insight you have. :+1:

There are many users at Dailytics running reports with filters, so I'd say it's working fine. The error message is very vague to be fair.
Could you please try with this filter var?
filter = {
  "andGroup": {
    "expressions": [
      {
        "filter": {
          "fieldName": "pagePath",
          "stringFilter": {
            "matchType": "FULL_REGEXP",
            "value": "/manual_transmissions/.+/show_public",
            "caseSensitive": false
          }
        }
      },
      {
        "filter": {
          "fieldName": "hostName",
          "stringFilter": {
            "matchType": "CONTAINS",
            "value": "subdomain.example.com",
            "caseSensitive": false
          }
        }
      }
    ]
  }
}

Thank you @luctus. You're right, the error message from Google is the source of my confusion. I didn't intend for you to do my homework for me, but your filter example has me on the right track now and I see that this ticket probably never needed to exist.
Feel free to close the ticket. I've got results coming back while using filters now and I'm quite happy. :D

No worries, @Ben-Fenner!
It took me a while to finally understand the structure of those filters and I am always happy to help where I can.

If anyone from the future gets here and wants to know where I ended up, here are the actual filters that get my job done. Make note of the notExpression for negation.
GA4_FILTER_PUBLIC = {
    'filter': {
      'fieldName': 'pagePath',
      'stringFilter': {
        'matchType':     'FULL_REGEXP',
        'value':         '^' + '/manual_transmissions/' + '.+' + '/show_public' + '$',
        'caseSensitive': false
      }
    }
  }.freeze

GA4_FILTER_EXCLUDE_SUBDOMAIN = {
    'notExpression': {
      'filter': {
        'fieldName': 'hostName',
        'stringFilter': {
          'matchType':     'CONTAINS',
          'value':         'subdomain.example.com',
          'caseSensitive': false
        }
      }
    }
  }.freeze

filters = { 'andGroup': { 'expressions': [GA4_FILTER_PUBLIC, GA4_FILTER_EXCLUDE_SUBDOMAIN] } }


Form v2

Do we limit the intl option to languages that are supported in the OONI probe?
Is there a predefined set of keys that can be added to options?
Other validations to be added?
Do we need an index page for test lists?


Not able to use custom image

Hi Muhammad,
When I try to load a CustomIcon with "imagePath" I always get the error that it tries to search for an icon in the package. If I have understood correctly, but should give the possibility to set a custom icon.
When i try:

I get:

Im using the actual version of FlutterSocialButtons(^1.0.6+2) and the actual version from Flutter
(
Flutter 3.3.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 6928314d50 (7 days ago) • 2022-10-25 16:34:41 -0400
Engine • revision 3ad69d7be3
Tools • Dart 2.18.2 • DevTools 2.15.0
)

Did you put assets in yaml file?

Yes i did:

The Issue has been fixed in version 1.0.7. Please try that version.


Across instances

Is there a recommended way to move these templates between instances on a tenant (or possibly a different tenant)?
I'm not sure what "on your site" means in relation to availability of the gallery.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab8a3b05-5340-3436-3671-f70e73f4a7f4
Version Independent ID: 02a9aadf-c825-240a-455f-e3bc0c01421d
Content: Work with customer journey templates (Dynamics 365 for Marketing)
Content Source: ce/marketing/journey-templates.md
Service: dynamics-365-marketing
GitHub Login: @kamaybac
Microsoft Alias: kamaybac

@dcbrown16, by "on your site" we mean on the current instance (I'll clarify that text). I'm unsure how to transfer journey templates between instances. You may be able to use the standard import/export tools available for Dynamics 365, but we have had issues in this regard with customer journeys in particular, which I believe are currently being addressed. Please contact Microsoft Support for help with that issue.


[0.9.12] Connect to fresh CockroachDB: Uncaught TypeError: Cannot read property 'length' of undefined

Managed to successfully connect to local CockroachDB, and I can issue SQL statements and get back results.
The node has no databases yet.
Error:
app.js:126 Uncaught TypeError: Cannot read property 'length' of undefined
    at app.js:126
    at Array.forEach (<anonymous>)
    at buildSchemaSection (app.js:121)
    at app.js:157
    at Object.error (app.js:76)
    at j (jquery.js:2)
    at Object.fireWith [as rejectWith] (jquery.js:2)
    at x (jquery.js:4)
    at XMLHttpRequest.<anonymous> (jquery.js:4)

Once I issue the following statement & refresh the page, error goes away:
SET database = db_name;

Ideally, the app would work properly w/o a DB selected.

Fix has been added to master. However, the app will require the user to specify the database name, because a lot of endpoints expect the "correct" environment, ie. postgres will try to use the current username as a database (and fail if it does not exist), but that's not the case with cockroach.


Artifact grouping take 2

This PR changes the layout of the files in the artifact directory from the default structure of a Maven repo to the following structure:
<root>/<groupId>/<artifactId>
For example:
<root>/com.azure/azure-sdk-template
This is to remove the need for downstream consumers of the artifacts to use wildcards to discover artifact locations which is potentially error prone. As a consequence I've removed the stage-artifacts.yml template from the repository, and anywhere it was used instead use a combination of ${{artifact.groupId}}/${{artifact.name}} to locate the artifact instances (within an ${{ each ... }}: section).
Additionally I've moved common logic that was previously in Publish-MavenPackages.ps1 into a PowerShell module in eng/scripts/MavenPackaging. This logic is then used by Publish-MavenPackages.ps1 and a new script Stage-MavenPackageArtifacts.ps1.

/azp run java - appconfiguration

/azp run java - parents

/azp run java - cosmos

/azp run java - template

/azp run java - boms

/azp run java - appconfiguration

/azp run java - core

/azp run java - parents

/azp run java - boms

/azp run java - cosmos

Yep. Agreed.


[Package Issue]: Apple.WindowsMigrationAssistant - Wrong version URL

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Other
Brief description of your issue
I accidentally pull requested the same version, as I was trying out wingetcreate update, and thought not putting in the version would auto generated the version from the .exe like wingetcreate new did. It changed https://updates.cdn-apple.com/2023/windows/032-90920-20230606-31F68023-4408-4152-9644-537F0911A409/WindowsMigrationAssistantSetup.exe to https://download.info.apple.com/Mac_OS_X/091-6112.20141020.RiAde/WindowsMigrationAssistantSetup.exe . The first one is the correct one as it is the latest one and fits that version number, while the second is the oldest version of the software. The pull at https://github.com/microsoft/winget-pkgs/pull/120234 addresses this, please merge that one.
Steps to reproduce
Install WinMigAss from winget
Actual behavior
The oldest version, intended for Lion to Yosemite users, installs, rather than the latest version, despite having the version number of the latest.
Expected behavior
The newest version installs.
Environment
N/A, it is just a wrong URL, no additional factors could come into play.

Screenshots and Logs
No response

@upintheairsheep Oops?!
Your all commits in pull request #118741 will be squash-merged into a single "compressed" commit in branch master. Could you please search that commit and try to revert it? Just go to that commit and create a "revert" pull request for it.
After the "revert PR" is successfully merged, create a valid and CORRECT manifest again.


Add missing ')' to RSA command help

[x] documentation is added or updated
[ ] tests are added or updated

It's a code change so bug fix, not documentation fix. Not that it matters much.

This pull request is ready to merge

Merged, thanks for the reviews.


How to include scss?

How to include scss?

create scss file and use import or require statement, depending upon if ur using typescript or javascript, in main.ts file. For example if I have create main.scss the in main.ts file I would do import "main.scss";. This will put in head as style tag

I am also not able to compile scss to external file and loading from relative url
I am checking the web.config.js and these four are confusing me:-
// Support for CSS as raw text
// use 'null' loader in test mode (https://github.com/webpack/null-loader)
// all css in src/style will be bundled in an external css file
{
test: /.css$/,
exclude: root('src', 'app'),
loader: isTest ? 'null-loader' : ExtractTextPlugin.extract({ fallback: 'style-loader', use: ['css-loader', 'postcss-loader']})
},
  // all css required in src/app files will be merged in js files
  {test: /\.css$/, include: root('src', 'app'), loader: 'raw-loader!postcss-loader'},

  // support for .scss files
  // use 'null' loader in test mode (https://github.com/webpack/null-loader)
  // all css in src/style will be bundled in an external css file
  {
    test: /\.(scss|sass)$/,
    exclude: root('src', 'app'),
    loader: isTest ? 'null-loader' : ExtractTextPlugin.extract({ fallback: 'style-loader', use: ['css-loader', 'postcss-loader', 'sass-loader']})
  },
  // all css required in src/app files will be merged in js files
  {test: /\.(scss|sass)$/, exclude: root('src', 'style'), loader: 'raw-loader!postcss-loader!sass-loader'},

Just thinking there should be something to change these to start this happening.

what is your exact problem ?
I have no problem working with that project and scss. I have also added the sass-resources-loader in order to avoid putting to many repeated "import" in my scss files.


dropdown-menu in table-responsive  were covered

In
,
If there is a
,
then the
  will be covered by

Kindly read our fine documentation which explicitly covers this: http://getbootstrap.com/css/#callout-tables-responsive-overflow


[21.05] python3Packages.websockets: add patch for CVE-2021-33880

Motivation for this change
This is a bit of an odd one because it's actually a forward port of #125098 to 21.05. Why? Because I fully expected #123283 to make it in to 21.05, but now that doesn't look like it's going to happen.
So here's the patch from 20.09.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125567 at 968e9531 run on aarch64-linux 1

5 packages failed to build:

python38Packages.pytest-sanic
python39Packages.authcaptureproxy
python39Packages.pytest-sanic
python39Packages.qiskit
python39Packages.qiskit-ibmq-provider

6 packages skipped due to time constraints:

python38Packages.qiskit
python38Packages.qiskit-ibmq-provider
python38Packages.slack-sdk
python39Packages.slack-sdk
python39Packages.teslajsonpy
theharvester

84 packages built successfully:

appdaemon
chia
datasette (python38Packages.datasette)
dyndnsc
grab-site
home-assistant
onionshare
onionshare-gui
opsdroid
python38Packages.PyRMVtransport
python38Packages.aioambient
python38Packages.aiopylgtv
python38Packages.amqtt
python38Packages.authcaptureproxy
python38Packages.axis
python38Packages.denonavr
python38Packages.dependency-injector
python38Packages.elmax
python38Packages.entrance
python38Packages.entrance-with-router-features
python38Packages.fastapi
python38Packages.flask-socketio
python38Packages.ha-philipsjs
python38Packages.hbmqtt
python38Packages.homematicip
python38Packages.httpcore
python38Packages.httpx
python38Packages.ipfshttpclient
python38Packages.json-logging
python38Packages.mattermostdriver
python38Packages.pylitterbot
python38Packages.pyppeteer
python38Packages.pytest-httpx
python38Packages.python-binance
python38Packages.python-engineio
python38Packages.python-engineio_3
python38Packages.python-socketio
python38Packages.python-socketio_4
python38Packages.respx
python38Packages.roombapy
python38Packages.sanic
python38Packages.sanic-auth
python38Packages.sanic-testing
python38Packages.simplisafe-python
python38Packages.teslajsonpy
python38Packages.uvicorn
python38Packages.websockets
python39Packages.PyRMVtransport
python39Packages.aioambient
python39Packages.aiopylgtv
python39Packages.amqtt
python39Packages.axis
python39Packages.datasette
python39Packages.denonavr
python39Packages.dependency-injector
python39Packages.elmax
python39Packages.entrance
python39Packages.entrance-with-router-features
python39Packages.fastapi
python39Packages.flask-socketio
python39Packages.ha-philipsjs
python39Packages.homematicip
python39Packages.httpcore
python39Packages.httpx
python39Packages.ipfshttpclient
python39Packages.json-logging
python39Packages.mattermostdriver
python39Packages.pylitterbot
python39Packages.pyppeteer
python39Packages.pytest-httpx
python39Packages.python-binance
python39Packages.python-engineio
python39Packages.python-engineio_3
python39Packages.python-socketio
python39Packages.python-socketio_4
python39Packages.respx
python39Packages.roombapy
python39Packages.sanic
python39Packages.sanic-auth
python39Packages.sanic-testing
python39Packages.simplisafe-python
python39Packages.uvicorn
python39Packages.websockets
urlwatch

3 suggestions:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/websockets/default.nix:42:3:
   |
42 |   meta = with lib; {
   |   ^

warning: unused-argument
Unused argument: pytest.
Near pkgs/development/python-modules/websockets/default.nix:6:3:
  |
6 | , pytest
  |   ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/development/python-modules/websockets/default.nix:22:5:
   |
22 |     (fetchpatch {
   |     ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 125567 run on x86_64-linux 1

2 packages marked as broken and skipped:

python38Packages.pytest-sanic
python39Packages.pytest-sanic

94 packages failed to build:

appdaemon
chia
datasette (python38Packages.datasette)
dyndnsc
esphome
home-assistant
onionshare
onionshare-gui
opsdroid
platformio
python38Packages.PyRMVtransport
python38Packages.aioambient
python38Packages.aiopylgtv
python38Packages.amqtt
python38Packages.authcaptureproxy
python38Packages.axis
python38Packages.denonavr
python38Packages.dependency-injector
python38Packages.elmax
python38Packages.entrance
python38Packages.entrance-with-router-features
python38Packages.fastapi
python38Packages.flask-socketio
python38Packages.ha-philipsjs
python38Packages.hbmqtt
python38Packages.homematicip
python38Packages.httpcore
python38Packages.httpx
python38Packages.ipfshttpclient
python38Packages.json-logging
python38Packages.mattermostdriver
python38Packages.pylitterbot
python38Packages.pyppeteer
python38Packages.pytest-httpx
python38Packages.python-binance
python38Packages.python-engineio
python38Packages.python-engineio_3
python38Packages.python-socketio
python38Packages.python-socketio_4
python38Packages.qiskit
python38Packages.qiskit-ibmq-provider
python38Packages.respx
python38Packages.roombapy
python38Packages.sanic
python38Packages.sanic-auth
python38Packages.sanic-testing
python38Packages.simplisafe-python
python38Packages.slack-sdk
python38Packages.teslajsonpy
python38Packages.uvicorn
python38Packages.websockets
python39Packages.PyRMVtransport
python39Packages.aioambient
python39Packages.aiopylgtv
python39Packages.amqtt
python39Packages.authcaptureproxy
python39Packages.axis
python39Packages.datasette
python39Packages.denonavr
python39Packages.dependency-injector
python39Packages.elmax
python39Packages.entrance
python39Packages.entrance-with-router-features
python39Packages.fastapi
python39Packages.flask-socketio
python39Packages.ha-philipsjs
python39Packages.homematicip
python39Packages.httpcore
python39Packages.httpx
python39Packages.ipfshttpclient
python39Packages.json-logging
python39Packages.mattermostdriver
python39Packages.pylitterbot
python39Packages.pyppeteer
python39Packages.pytest-httpx
python39Packages.python-binance
python39Packages.python-engineio
python39Packages.python-engineio_3
python39Packages.python-socketio
python39Packages.python-socketio_4
python39Packages.qiskit
python39Packages.qiskit-ibmq-provider
python39Packages.respx
python39Packages.roombapy
python39Packages.sanic
python39Packages.sanic-auth
python39Packages.sanic-testing
python39Packages.simplisafe-python
python39Packages.slack-sdk
python39Packages.teslajsonpy
python39Packages.uvicorn
python39Packages.websockets
theharvester
urlwatch

1 package built:

grab-site

Result of nixpkgs-review pr 125567 run on x86_64-linux 1

2 packages marked as broken and skipped:

python38Packages.pytest-sanic
python39Packages.pytest-sanic

5 packages failed to build:

python38Packages.qiskit
python38Packages.qiskit-ibmq-provider
python39Packages.json-logging
python39Packages.qiskit
python39Packages.qiskit-ibmq-provider

90 packages built:

appdaemon
chia
datasette (python38Packages.datasette)
dyndnsc
esphome
grab-site
home-assistant
onionshare
onionshare-gui
opsdroid
platformio
python38Packages.PyRMVtransport
python38Packages.aioambient
python38Packages.aiopylgtv
python38Packages.amqtt
python38Packages.authcaptureproxy
python38Packages.axis
python38Packages.denonavr
python38Packages.dependency-injector
python38Packages.elmax
python38Packages.entrance
python38Packages.entrance-with-router-features
python38Packages.fastapi
python38Packages.flask-socketio
python38Packages.ha-philipsjs
python38Packages.hbmqtt
python38Packages.homematicip
python38Packages.httpcore
python38Packages.httpx
python38Packages.ipfshttpclient
python38Packages.json-logging
python38Packages.mattermostdriver
python38Packages.pylitterbot
python38Packages.pyppeteer
python38Packages.pytest-httpx
python38Packages.python-binance
python38Packages.python-engineio
python38Packages.python-engineio_3
python38Packages.python-socketio
python38Packages.python-socketio_4
python38Packages.respx
python38Packages.roombapy
python38Packages.sanic
python38Packages.sanic-auth
python38Packages.sanic-testing
python38Packages.simplisafe-python
python38Packages.slack-sdk
python38Packages.teslajsonpy
python38Packages.uvicorn
python38Packages.websockets
python39Packages.PyRMVtransport
python39Packages.aioambient
python39Packages.aiopylgtv
python39Packages.amqtt
python39Packages.authcaptureproxy
python39Packages.axis
python39Packages.datasette
python39Packages.denonavr
python39Packages.dependency-injector
python39Packages.elmax
python39Packages.entrance
python39Packages.entrance-with-router-features
python39Packages.fastapi
python39Packages.flask-socketio
python39Packages.ha-philipsjs
python39Packages.homematicip
python39Packages.httpcore
python39Packages.httpx
python39Packages.ipfshttpclient
python39Packages.mattermostdriver
python39Packages.pylitterbot
python39Packages.pyppeteer
python39Packages.pytest-httpx
python39Packages.python-binance
python39Packages.python-engineio
python39Packages.python-engineio_3
python39Packages.python-socketio
python39Packages.python-socketio_4
python39Packages.respx
python39Packages.roombapy
python39Packages.sanic
python39Packages.sanic-auth
python39Packages.sanic-testing
python39Packages.simplisafe-python
python39Packages.slack-sdk
python39Packages.teslajsonpy
python39Packages.uvicorn
python39Packages.websockets
theharvester
urlwatch


Updating the expected behavior in TF doc

In tf.image.resize_with_pad, if the value is negative or zero for target width and target height, it is raising value error. It raises 'InvalidArgumentError' when a certain positive value that is given for (target_width<100).
Fixes #56333

@sushreebarsa Can you please check @mihaimaruseac's comments and keep us posted ? Thank you!