Error when building with -DBUILD_JAVA=ON

I am having issues building Fast-RTPS with the  -DBUILD_JAVA=ON flag. It works just fine  with just -DTHIRDPARTY=ON
Trying to build master at: 75e64754107b1eb03838ee3e18953da717b38348
OS: Ubuntu 18.04.2 LTS
Kernel: 4.15.0-50-generic
java -version gives me:
openjdk version "11.0.3" 2019-04-16
OpenJDK Runtime Environment (build 11.0.3+7-Ubuntu-1ubuntu218.04.1)
OpenJDK 64-Bit Server VM (build 11.0.3+7-Ubuntu-1ubuntu218.04.1, mixed mode, sharing)

javac -version gives me:
javac 11.0.3
gradle -v gives me:
Gradle 5.4.1
Build time:   2019-04-26 08:14:42 UTC
Revision:     261d171646b36a6a28d5a19a69676cd098a4c19d
Kotlin:       1.3.21
Groovy:       2.5.4
Ant:          Apache Ant(TM) version 1.9.13 compiled on July 10 2018
JVM:          11.0.3 (Oracle Corporation 11.0.3+7-Ubuntu-1ubuntu218.04.1)
OS:           Linux 4.15.0-50-generic amd64

When I invoke: cmake -DTHIRDPARTY=ON -DBUILD_JAVA=ON .. I get:
-- Setting build type to 'Release' as none was specified.
-- The C compiler identification is GNU 7.4.0
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring Fast RTPS
-- Version: 1.8.0
-- To change the version modify the file configure.ac
-- Performing Test SUPPORTS_CXX14
-- Performing Test SUPPORTS_CXX14 - Success
-- Performing Test SUPPORTS_CXX1Y
-- Performing Test SUPPORTS_CXX1Y - Success
-- Performing Test SUPPORTS_CXX11
-- Performing Test SUPPORTS_CXX11 - Success
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
-- fastcdr library found...
Submodule 'thirdparty/asio' (https://github.com/chriskohlhoff/asio.git) registered for path 'thirdparty/asio'
Cloning into '/home/fabian/test/Fast-RTPS/thirdparty/asio'...
Submodule path 'thirdparty/asio': checked out '22afb86087a77037cd296d27134756c9b0d2cb75'
Submodule 'thirdparty/tinyxml2' (https://github.com/leethomason/tinyxml2.git) registered for path 'thirdparty/tinyxml2'
Cloning into '/home/fabian/test/Fast-RTPS/thirdparty/tinyxml2'...
Submodule path 'thirdparty/tinyxml2': checked out '8c8293ba8969a46947606a93ff0cb5a083aab47a'
-- Found tinyxml2: /home/fabian/test/Fast-RTPS/thirdparty/tinyxml2
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "1.1.0g")
-- Found Java: /usr/bin/java (found suitable version "11.0.3", minimum required is "1.6") found components:  Runtime
-- Found Gradle: /usr/local/bin/gradle
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_kill
-- Looking for pthread_kill - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)
-- Could NOT find GMock (missing: GMOCK_LIBRARY GMOCK_INCLUDE_DIR GMOCK_MAIN_LIBRARY)
-- Configuring done
-- Generating done
-- Build files have been written to: /home/fabian/test/Fast-RTPS/build

So that looks good afaik. But when I invoke make afterwards, I get:
Scanning dependencies of target git_submodule_update_idl
[  1%] Updating Git module idl
Submodule 'thirdparty/idl' (https://github.com/eProsima/IDL-Parser.git) registered for path 'thirdparty/idl'
Cloning into '/home/fabian/test/Fast-RTPS/thirdparty/idl'...
Submodule path 'thirdparty/idl': checked out 'b94c00bcb1d83db0ac7cd069aba593dbe5906358'
[  1%] Built target git_submodule_update_idl
Scanning dependencies of target git_submodule_update_fastcdr
[  2%] Updating Git module fastcdr
Submodule 'thirdparty/fastcdr' (https://github.com/eProsima/Fast-CDR.git) registered for path 'thirdparty/fastcdr'
Cloning into '/home/fabian/test/Fast-RTPS/thirdparty/fastcdr'...
Submodule path 'thirdparty/fastcdr': checked out '4f61be9eb9df2e1102f6d8518097569695b60a97'
[  2%] Built target git_submodule_update_fastcdr
Scanning dependencies of target java
[  3%] Generating Java application

> Task :idl:compileJava
warning: [options] source value 6 is obsolete and will be removed in a future release
warning: [options] target value 1.6 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
Note: /home/fabian/test/Fast-RTPS/thirdparty/idl/src/main/java/com/eprosima/idl/generator/manager/TemplateUtil.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 warnings

> Task :compileJava FAILED
warning: [options] source value 6 is obsolete and will be removed in a future release
warning: [options] target value 1.6 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
/home/fabian/test/Fast-RTPS/fastrtpsgen/src/main/java/com/eprosima/fastrtps/fastrtpsgen.java:525: error: constructor TemplateManager in class TemplateManager cannot be applied to given types;
            TemplateManager tmanager = new TemplateManager("FastCdrCommon:eprosima:Common");
                                       ^
  required: String,Context,boolean
  found: String
  reason: actual and formal argument lists differ in length
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
3 warnings

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s
3 actionable tasks: 3 executed
CMakeFiles/java.dir/build.make:57: recipe for target 'CMakeFiles/java' failed
make[2]: *** [CMakeFiles/java] Error 1
CMakeFiles/Makefile2:516: recipe for target 'CMakeFiles/java.dir/all' failed
make[1]: *** [CMakeFiles/java.dir/all] Error 2
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2

Could it be an issue with the java version I have installed?
Thank you in advance,
Fabian :)

Duplicated #550


Bump dotenv_codegen's dotenv dependency to 0.11.0

Closing this PR since its changes were already included in #91.


[PE-D][Tester C] Overzealous error catching

Typing Medium instead of medium throw me an error. Users may be accustomed to typing in Caps and will get frustrated over this.

Labels: severity.Medium type.FunctionalityBug
original: cadencjk/ped#6

Accepting other variations of low, medium, high is a more optimal design for priority which we did not have time to implement for v1.4.
I will add a mention of this in a suitable place in the UG as Coming Soon so that we can argue for NotInScope


webviewDebuggingEnabled does not work when app is installed via TestFlight/App Store

Hi maintainers 😊
Thanks for building this awesome library!
Bug description:
WebviewDebugging in Safari only works when I locally run Debug builds. When I build the app and ship it to my phone via TestFlight, it does not seem to be enabled. Is this a known limitation?
To Reproduce:
Component:
<WebView source={{ uri: url }} webviewDebuggingEnabled />

Build a production version of an app using this component and verify that the WebviewDebugging does not seem to be enabled.
Expected behaviour:
Both Debug and Production versions of apps should have WebviewDebugging enabled if the webviewDebuggingEnabled is set to true.
Environment:

OS: iOS
OS version: 16.7.0 and 17.0.1
react-native version: 72.5
react-native-webview version: 13.6.2

@thep-dr another thing I noticed just now: I am able to run the inspector with the simulator, regardless of whether webviewDebuggingEnabled is present.

Hi @jlleblanc
Do you mean webviewDebuggingEnabled={true}? I have just tried that, but no luck.
The other thing is really surprising! I have just tried again, but I am only able to run the inspector if the webviewDebuggingEnabled is present. Are you running the same versions of react-native and react-native-webview as mentioned in the issue text?

@thep-dr yes, that is what I meant. I have been doing a lot of TypeScript-only projects recently and mentally added a squiggly red underline under webviewDebuggingEnabled 😂
I am using the same version of react-native-webview, but I am on React Native 71.
A side question I have is "is there any drawback to just leaving webviewDebuggingEnabled on in production?" I am considering doing that, but that is the one thing that gives me pause.

Makes sense 😆
About drawbacks: tbh, I am not completely sure. My guess would be no, but I was planning on just giving it a shot and seeing the result.


SSR Apollo client

https://www.yld.io/blog/a-tale-of-react-server-side-rendering/

https://github.com/hiroppy/ssr-sample

https://github.com/zyhou/react-apollo-ssr


Support architecture parameter

Changes

Provides --architecture parameter for support on running on M1 agents

Related Issues

TBD

Checklist

[x] Read the contribution guide and accept the
code of conduct
[x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
in the documentation repo)
[x] Readme (updated or not needed)
[ ] Tests (added, updated or not needed)

Looks like CI builds is failing because of the license server

Hey there, we just merged a fix for the failing license activation. Can you merge main into your branch and link a successful build log from your own branch. Then we can review and merge. Thanks!

Can take a look at this today! Or is this already part of #596?

I've already added it to the other PR and merged it in an effort to get v4 out faster. I will make sure you are credited in the release notes and commit message though for your contribution! Gonna close this PR now since the functionality is now merged to main.


Assignment 7 implementation - Issue17

@dwalkes, do I merge this?

@dwalkes, I've made the relevant changes

@dwalkes, I think this works now with the suggested changes

Excellent work with this @akshita-bhasin!


Update akka-http, akka-http-spray-json to 10.2.9

Updates

com.typesafe.akka:akka-http
com.typesafe.akka:akka-http-spray-json

from 10.2.1 to 10.2.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #93.


Symlinks

I implemented symlinks for WIN.
There may be things I've missed, so I am posting this for your review and discussion.

For symlinks to work on Windows, the user needs to allow them. Otherwise they can not be created. This is done via the Group policy editor
The new options may need to be added to the user parameter sets and their defaults should be disabled I guess. I havent done this to check if my idea was correct.
I guess the CI will fail mainly due to the options missing default values. Which I can add later if you think the code so far is fine

I noticed I changed the value of "verbose" I was testing something. I'll change it back at the next commit.

And if this is fine, I can try it for Linux.

Sine this PR also edit aas_copyfromremote, I would finish with #365 before discussing this one.
Then, after merging #365, you have to re-merge into TamerGezici:symlinks to update this PR and handle any potential conflicts.

Yes. And I ran into some issues with this branch just now. I will re-do and try finding the issue. So I'm closing this. I'll open a new one


Feature request: Template editor

Unlike people who install from source, docker-compose users do not have a way to edit their templates (e.g. the german impressum, custom front page, etc). It'd be nice to have a simple template editor in the admin panel or even having templates accessible to compose users as another sort of config file. Thoughts?

(Using the docker-compose from the Docs)
The custom folder referenced in the "Customization" docs page is located at /data/gitea inside the offical Docker image: https://github.com/go-gitea/gitea/blob/96f1720d6907abd16641881d8f75177810ca29b2/Dockerfile#L52
The offical docker-compose file mounts the local folder ./gitea to /data:
https://github.com/go-gitea/gitea/blob/96f1720d6907abd16641881d8f75177810ca29b2/docs/content/doc/installation/with-docker.en-us.md#L52-L53
That means you can place the templates in the local folder ./gitea/gitea/templates/footer.tmpl (inside the container this file will have the path /data/gitea/templates/footer.tmpl)

https://docs.gitea.io/en-us/install-with-docker/
https://docs.gitea.io/en-us/customizing-gitea/

That said, your feature request for a Template Editor is still valid.

Did this change? Is it no longer valid or closed to inactivity?


opam.export includes full metadata

protects against certain supply chain attacks (opam package repository subversion). created by opam switch export --full opam.export

!ci-build-me

Quick question, did you try nix develop mina to ensure it's working?

Can you also rephrase the second commit message, please?
c71652de29c61a8c73c4a963db983c876537e2f3

Note that we can also add sha512 checksums.

Note that we can also add sha512 checksums.

how?

Quick question, did you try nix develop mina to ensure it's working?

I do seem to have some issue with this:
error: builder for '/nix/store/s576fxcrbqbqfi8wdr8bz8c1qp9d5dpg-ocamlgraph-1.8.8.tar.gz.drv' failed with exit code 1;
       last 8 log lines:
       >
       > trying http://ocamlgraph.lri.fr/download/ocamlgraph-1.8.8.tar.gz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       > 100   283  100   283    0     0    605      0 --:--:-- --:--:-- --:--:--   605
       >   0     9    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download ocamlgraph-1.8.8.tar.gz from any mirror

!ci-build-me

Quick question, did you try nix develop mina to ensure it's working?

I do seem to have some issue with this:
error: builder for '/nix/store/s576fxcrbqbqfi8wdr8bz8c1qp9d5dpg-ocamlgraph-1.8.8.tar.gz.drv' failed with exit code 1;
       last 8 log lines:
       >
       > trying http://ocamlgraph.lri.fr/download/ocamlgraph-1.8.8.tar.gz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       > 100   283  100   283    0     0    605      0 --:--:-- --:--:-- --:--:--   605
       >   0     9    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download ocamlgraph-1.8.8.tar.gz from any mirror

Did you try a opam update?

@dannywillems no changes to the exported metadata after an opam update.

happens even without my changes, my env might be busted

Note that we can also add sha512 checksums.

how?

I wonder if opam admin add-hashes sha512 works.


MODOU

VSCode Version: Code - Insiders 1.13.0-insider (f977399d58f7b64db35047fafe0c6e59e15f11d5, 2017-06-02T10:54:04.063Z)
OS Version: Windows_NT ia32 6.3.9600
CPUs: Intel(R) Core(TM) i5-6400 CPU @ 2.70GHz (4 x 2712)
Memory (System): 7.93GB (3.77GB free)
Memory (Process): 135.34MB working set (147.17MB peak, 125.77MB private, 31.38MB shared)
Load (avg): 0, 0, 0
VM: 0%
Initial Startup: yes
Screen Reader: no
Empty Workspace: yes
Timings:

Component
Task
Time (ms)

main
start => app.isReady
226

main
app.isReady => window.loadUrl()
4598

renderer
window.loadUrl() => begin to require(workbench.main.js)
4722

renderer
require(workbench.main.js)
634

renderer
create extension host => extensions onReady()
16725

renderer
restore viewlet
undefined

renderer
restore editor view state
undefined

renderer
overall workbench load
NaN

main + renderer
start => extensions ready
31225

main + renderer
start => workbench ready
NaN

:warning: Make sure to attach these files: :warning:
-C:\Users\Administrator\0089_main.cpuprofile.txt
-C:\Users\Administrator\0089_renderer.cpuprofile.txt

@iliangdianban You need to attach the files, otherwise they can't help.


Developer Role should not see edit actions on Service Pool entities

A user with developer role should only have ready access to Service Pools. The developer should not be able to create service pool or edit service pools.

Raised PR: https://github.com/hortonworks/streamline/pull/794 to fix this.


Problem with govspeak for inline attachments in lists

 Issue by fofr
Monday 21 December 2015 at 16:04 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/issues/620

(This is mostly a brain dump following some investigation on 2nd line.)
Following the Zendesk ticket https://govuk.zendesk.com/agent/tickets/1210622 it was found that the following govspeak is considered invalid by Specialist Publisher:
* [InlineAttachment:DHPC_Drug_shortage_InductOs_GB-NIR_CLEAN_FINAL.pdf]: Some text

After some investigation the error seems to happen only when all of the following are true:

There is a list item that begins with a square bracket * [
There is a closing square bracket immediately followed by a colon and a space: ]:

Putting a character between the * and the [ works, eg * .[. Removing the colon works. Using other characters that might be considered special, such as $ or . works fine. It was also noted that \: seems to escape the colon.
The shortest syntax that produces this bug is:
* [a]: (note the space)

Hey @tijmenb. I've just been investigating this same issue in manuals-publisher (https://github.com/alphagov/manuals-publisher/issues/620). As far as I can tell it's no longer a problem but wondered whether you had any more info given that you closed this version?


add xobjdetect and ximgproc modules

[x] xobjdetect

[x] WBDetector

[ ] ximgproc

[x] cv::ximgproc::anisotropicDiffusion
[x] cv::ximgproc::edgePreservingFilter
[x] cv::ximgproc::findEllipses
[x] cv::ximgproc::niBlackThreshold
[x] cv::ximgproc::PeiLinNormalization
[x] cv::ximgproc::thinning
[ ] Structured forests for fast edge detection
[ ] EdgeBoxes
[ ] Filters
[ ] Superpixels
[ ] Image segmentation
[ ] Fast line detector
[ ] EdgeDrawing
[ ] Fourier descriptors
[ ] Binary morphology on run-length encoded image

Codecov Report
Attention: Patch coverage is 76.92308% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.94%. Comparing base (e74326f) to head (a124677).

Files
Patch %
Lines

lib/src/contrib/ximgproc.dart
76.92%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   90.00%   89.94%   -0.07%
==========================================
  Files          36       37       +1
  Lines        5274     5300      +26
==========================================
+ Hits         4747     4767      +20
- Misses        527      533       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix pin icon loop mouse enter and over, crash when scroll after pin row in table enable row virtualization

This PR fixes issue #908 and #909

we cannot make the change for pinning button. Otherwise the tooltip will not close.
It's better to split PRs because now I have to check out this PR and revert part of it before merging


Send monthly reminder to users without timesheet

Also send monthly reminder to users who haven't created a timesheet for the month but have to hand one in

every proletarier was already recieving an email this was never an issue


update argocd-operator for v1.12

What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
This PR updates argocd-operator version

LGTM

/approve


Improvementation add some profile on vcollect_iterator

Proposed changes
add some profile on vcollect_iterator
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Added modernize-use-nullptr check

Thanks a lot for making a contribution to SFML! 🙂
Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)

[x] Has this change been discussed on the forum or in an issue before?
[x] Does the code follow the SFML Code Style Guide?
[ ] Have you provided some example/test code for your changes?
[ ] If you have additional steps which need to be performed list them as tasks!

Description
Adds modernize-use-nullptr clang-tidy check.
This PR is related to the issue #
Tasks

[x] Tested on Linux
[ ] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
Describe how to best test these changes. Please provide a minimal, complete and verifiable example if possible, you can use the follow template as a start:
#include <SFML/Graphics.hpp>

int main()
{
    sf::Vector2u modeSize{200, 200};
    sf::RenderWindow window(sf::VideoMode(modeSize), "SFML works!");
    sf::CircleShape shape(100.f);
    shape.setFillColor(sf::Color::Green);

    while (window.isOpen())
    {
        sf::Event event;
        while (window.pollEvent(event))
        {
            if (event.type == sf::Event::Closed)
                window.close();
        }

        window.clear();
        window.draw(shape);
        window.display();
    }

    return 0;
}

g++ main.cpp -o sfml-app -I ./include/ -L./build/lib -lsfml-audio -lsfml-graphics -lsfml-system -lsfml-window

./sfml-app

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

I think I can approve this PR but I first want someone to review the Objective-C++ changes first since I don't understand nil versus nullptr all that well.

I think I can approve this PR but I first want someone to review the Objective-C++ changes first since I don't understand nil versus nullptr all that well.

According to this, nil should only be used for objects of type id; I'll take a look when I get a chance.

should only be used for objects of type id;

I read that too but "should only be used for objects of type id" isn't something I'm familiar with. I'm not sure what types we're using that meet that definition.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

Thank you! I'd love to see modernize-use-default-member-init added next


Pester test that tests Connect-SqlInstance for Credential Support

This would be fun
Login with the credential via Connect-SqlInstance (since internals are exposed) then do a Get-DbaProcess using the same credential to ensure that credential is logged in and doing stuff.

I can help with that.
PS how come that there is still no New-DbaLogin 🤔 nice opportunity to add it

awesomeee. I never dared cuz it just seemed like a lot of work ;) Second to New-DbaDatabase. Please do! You may also need Set-DbaServerRole to add the appropriate role.


[regression-test][framework] support cases that can only run in non-concurrent-mode.

Proposed changes
There are test cases that can be only run in non-concurrent-mode, e.g.

cases that will modify global variables
cases that will add global block rule
run these cases when other cases are finished in regression-test.


tubepy won't open in ubuntu (linux)

When I try to start tubepy, I got error _tkinter.TclError: bitmap "assets/icons/new_tubepy_logo128.ico" not defined

I fixed the problem, can you check if there was any problem with my change

@SJPBP 👋🏾 am on it 😅


More 1.2 validateorder tests

Motivation

still need to check matchAdvancedOrders as well as with ascending item amounts
Reference seems to fail on ascending order with fulfillAvailableAdvanced

Solution

Codecov Report
Base: 99.51% // Head: 99.51% // No change to project coverage :thumbsup:

Coverage data is based on head (a1d3160) compared to base (8234163).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.2     #753   +/-   ##
=======================================
  Coverage   99.51%   99.51%
=======================================
  Files          45       45
  Lines        2283     2283
  Branches      354      354
=======================================
  Hits         2272     2272
  Misses          1        1
  Partials       10       10

Flag
Coverage Δ

production
100.00% <ø> (ø)

reference
99.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Hide buttons in AdonisWindow according to ResizeMode

The default WPF window hides the minimize and maximize buttons if ResizeMode is set to NoResize. Also, the maximize button is disabled if it's set to CanMinimize [link].
This PR adds this behaviour for AdonisWindow.
PS: Thanks for your great work on this library!

We should also check if the window buttons are the only things that need to respect the ResizeMode. Maximizing can also be done using shortcuts, double-clicking the title bar and dragging the window to the top of the screen. Maybe these things need to be adressed as well. I will look into that soon.

@benruehl Thanks for your feedback.

I think the solution could be improved by moving the setter of the disabled foreground to the WindowButton style.

I did try this before, but somehow could not get it to work. It seems the triggers in the WindowButton style are overriden by the values of the control template. The current is the only solution I could think of.

Maximizing can also be done using shortcuts, double-clicking the title bar and dragging the window to the top of the screen.

Made a quick check for those and everything already seems to behave as expected. Looks like someone already thought about that :)
https://github.com/benruehl/adonis-ui/blob/bb2bfbe09ed509e0f9f2e39dcf5d4eeef717d7f6/AdonisUI/Controls/AdonisWindow.cs#L225-L229

You are right, I see what you mean, sorry!
The only alternative I can think of is a trigger in the WindowButton style which sets the foreground of an inner control in the template.
Something like this:
<ControlTemplate.Triggers>
    <Trigger Property="IsEnabled" Value="False">
        <Setter Property="TextElement.Foreground" TargetName="ContentPresenter" Value="{DynamicResource {x:Static adonisUi:Brushes.DisabledForegroundBrush}}"/>
    </Trigger>
</ControlTemplate.Triggers>

(Assuming the ContentPresenter in the WindowButton control template is named 'ContentPresenter')
This solution has the disadvantage that it is built directly into the template which means the behavior cannot be customized from the outside anymore.
What do you think? If you don't like the idea, we can use your current solution as well.

@benruehl You're alternative solution makes more sense to me as it is more generic. However, setting TextElement.Foreground on the ContentPresenter does not seem to have an effect on the window button icons as they are canvas elements which use the foreground color of the surrounding ContentControl. Have I overseen something important here?

Seems like I forgot to mention that the button's Content needs to go into the ContentTemplate instead.
<Button x:Name="PART_MaximizeRestoreButton"
        Grid.Column="1"
        Style="{DynamicResource {x:Static adonisUi:Styles.WindowButton}}"
        Foreground="{TemplateBinding TitleBarForeground}"
        Background="{TemplateBinding WindowButtonHighlightBrush}">
    <Button.ContentTemplate>
        <DataTemplate>
            <ContentControl ContentTemplate="{DynamicResource {x:Static adonisUi:Icons.WindowMaximize}}"
                            Width="10"
                            Height="10"/>
        </DataTemplate>
    </Button.ContentTemplate>
</Button>

I am not sure why this changes the behavior though. Read about it in punker76's blog.
Does it work for you now?

Thanks, this does work for me now. I pushed the changes.

Awesome. Again, thanks a lot for this contribution. Appreciate it.


Bill attachment

I am trying to create an attachment file for a bill previously created using sdk, but I receive an error.
var attachfile = new AttachmentFile()
{
	FileName = "test",
	Extension = "txt",
	FilePath = "D:\\test.txt"
};

var files = new List<AttachmentFile>();
files.Add(attachfile);

var attach = new AttachmentsCreate()
{
	ControlId = billControlId,
	Files = files,

};

Task<OnlineResponse> attachTask = client.Execute(attach);
attachTask.Wait();

I receive this error:

XL03000003 XML Parse schema error: Error 1871: Element 'attachment': Missing child element(s). Expected is ( attachmentdata ).. Line: 1, column: 0.

There isn't any data or attarchment data for AttachmentFile.
I am missing something?
Thank you

It looks like the code doesn't think your file exists.  See line 72 here.  Would you prefer the code should throw an exception instead?

Thank you,
There will be any option to send directly attachment data base64? or will stay just with path. my stream is in memory. Thank you.

You can implement the IAttachment interface in your own class...  Something like this:
using System;
using System.IO;
using Intacct.SDK.Functions.Company;
using Intacct.SDK.Xml;

namespace Intacct.Examples
{
    public class AttachmentFileStream : IAttachment
    {
        public string Extension;
        public string FileName;
        public MemoryStream MemoryStream;

        public AttachmentFileStream()
        {
        }

        public void WriteXml(ref IaXmlWriter xml)
        {
            xml.WriteStartElement("attachment");

            // The file name without a period or extension - Ex: Invoice21244
            // Needs to be unique from other files in attachment record
            xml.WriteElement("attachmentname", FileName, true);

            // The file extension without a period - Ex: pdf
            xml.WriteElement("attachmenttype", Extension, true);

            xml.WriteElement("attachmentdata", Convert.ToBase64String(MemoryStream.ToArray()), true);

            xml.WriteEndElement(); //attachment

        }
    }
}


Api examples

Coverage remained the same at 93.985% when pulling 4fe3725a1d53660581046a5873ead1bbdf7d8903 on api-examples into ffb26a95a2786a9d9d76f63f14a25f3bebba0c3b on master.


Charging does not start

Thank you for your good work!
Battery charging does not start if net battery capacity is not enough.
Please consider to trigger charging as long as available storage is more than max_charge
Please add trigger to write initial register values at end_hr. (Or add an option to do.)
To stop forced loading from grid at expensive hours. (even if power to charge is not achieved)

Consider to add following to readme
"To reset all modbus values: Disable Modbus in Settings and re-enable. This resets all values to default."
Two logs below, and solar web consumption.
Thanks
{"level":"info","ts":"2024-11-12T01:11:01+01:00","msg":"Starting Calculate PV production for solar System 0"}
{"level":"info","ts":"2024-11-12T01:11:01+01:00","msg":"Forecast Solar Power for 12/11/2024: 29880 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Starting Calculate PV production for solar System 1"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Forecast Solar Power for 12/11/2024: 9299 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Total Forecast Solar Power for 12/11/2024: 39179 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Battery Capacity to charge: 20536 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Battery Capacity Max: 33177 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"your Daily consumption is:52000 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Net Forecast Power is not enough: -12820.350000 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Battery Capacity is not enough: 12640.437000 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Setting Fronius Storage Defaults start..."}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Reading register: 40361 ; value: 1; default:"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Reading register: 40349 ; value: 0; default:"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Reading register: 40356 ; value: 10000; default:"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Reading register: 40357 ; value: 10000; default:"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Reading register: 40351 ; value: 0; default:"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Writing register: 40351 ; value: 0"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Writing register: 40361 ; value: 1"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Writing register: 40349 ; value: 0"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Writing register: 40356 ; value: 10000"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Writing register: 40357 ; value: 10000"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Setting Fronius Modbus Defaults done."}
{"level":"info","ts":"2024-11-12T02:11:01+01:00","msg":"Starting Calculate PV production for solar System 0"}
{"level":"info","ts":"2024-11-12T02:11:01+01:00","msg":"Forecast Solar Power for 12/11/2024: 30050 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Starting Calculate PV production for solar System 1"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Forecast Solar Power for 12/11/2024: 9523 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Total Forecast Solar Power for 12/11/2024: 39573 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Battery Capacity to charge: 22593 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Battery Capacity Max: 33177 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"your Daily consumption is:52000 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Net Forecast Power is not enough: -12426.200000 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Battery Capacity is not enough: 10583.463000 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Setting Fronius Storage Force Charge at 5%"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Reading register: 40361 ; value: 1; default:"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Reading register: 40349 ; value: 0; default:"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Reading register: 40356 ; value: 10000; default:"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Reading register: 40357 ; value: 10000; default:"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Reading register: 40351 ; value: 0; default:"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Writing register: 40361 ; value: 1"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Writing register: 40349 ; value: 2"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Writing register: 40356 ; value: 65036"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Writing register: 40357 ; value: 10000"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Writing register: 40351 ; value: 0"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Setting Fronius Storage Force Charge done."}

Hi @Johnnexto!
Thanks for using SBAM!
frm the doc:
max_charge: Maximum amount of power required from the electricity network to charge the battery in W (Default: 3500)
For more details about max_charge parameter, please check this issue: https://github.com/atbore-phx/sbam/issues/26#issuecomment-2391048862.

Please consider triggering charging as long as available storage is more than max_charge.

I think the correct parameter is pw_batt_reserve: Minimum battery capacity to maintain in Wh (Default: 4000, which means 4kWh).

Battery charging does not start if net battery capacity is not enough.

In the first iteration on 2024-11-12T01:11:01+01:00, the battery was not charged:
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Net Forecast Power is not enough: -12820.350000 Wh"}
{"level":"info","ts":"2024-11-12T01:11:02+01:00","msg":"Battery Capacity is not enough: 12640.437000 Wh"}

This is not a bug; the reason is the approximation. You need just 180W (which is too small) to fill the gap: 12820 - 12640. This function calculates the percentage to add in int16: https://github.com/atbore-phx/sbam/blob/4332a654391815ff59961fb81ad24ef645aec7ac/pkg/fronius/schedule.go#L50. So, 180W in your case is 0.54%, which approximates to 0% in int16, so it was not charged.
Anyway, I need to be more explicit in the logs to avoid confusion. I take the point.
In the second iteration, you charged 5% (10583.463 - 12426.2 is approximately 5% of 33177, your full battery capacity):
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Net Forecast Power is not enough: -12426.200000 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Battery Capacity is not enough: 10583.463000 Wh"}
{"level":"info","ts":"2024-11-12T02:11:02+01:00","msg":"Setting Fronius Storage Force Charge at 5%"}

To reset all Modbus values: Disable Modbus in Settings and re-enable. This resets all values to default.

I'll try to be more explicit in the documentation: https://github.com/atbore-phx/sbam/blob/main/home-assistant/addons/sbam/DOCS.md.
Just enable this in your configuration:

Defaults: At the end of the crontab cycle, reconfigure the Fronius inverter to default (automatic management). The end of the crontab cycle is end_hr - 5 min. For example, if you have these parameters:
start_hr: Start time of the advantageous network operator rate (default 00:00)
end_hr: End time of the advantageous network operator rate (default 06:00)
crontab: Crontab to run sbam (default: 00 00-05 * * *)
SBAM evaluates whether to charge or not between 12 AM (midnight) and 5 AM. SBAM will set the defaults at 5:55 AM.
I'll try to be more explicit in the documentation to avoid confusion. Thanks!

Thank you very much for taking time to explain, this make perfect sense. I totally misread the max_charge (confused it with the "Max. Charging Power from AC" set in Battery mgmt on inverter.) and the defaults in the config section is clearly described in the documentation.

@Johnnexto,
Thanks a lot for your questions. Improving the documentation is mandatory, so your feedback is welcome 👍.
Regarding the definitions of max_charge and defaults, I will leave this issue open and address it in the next release. I will rewrite these two points more clearly in the documentation.
Best !


[SPARK-19398] remove one misleading log in TaskSetManager.

What changes were proposed in this pull request?
Log below is misleading:
if (successful(index)) {
  logInfo(
    s"Task ${info.id} in stage ${taskSet.id} (TID $tid) failed, " +
    "but another instance of the task has already succeeded, " +
    "so not re-queuing the task to be re-executed.")
}

If fetch failed, the task is marked as successful in TaskSetManager:: handleFailedTask. Then log above will be printed. The successful just means task will not be scheduled any longer, not a real success.
How was this patch tested?
Existing unit tests can cover this.

Can one of the admins verify this patch?

Should successful and tasksSuccessful  renamed to be completed and tasksCompleted?which I think make more sense.

CC @jasonmoore2k  for https://github.com/apache/spark/pull/12751/files#diff-bad3987c83bd22d46416d3dd9d208e76L719

@srowen @jasonmoore2k
Thanks a lot for reviewing this PR~

Should successful and tasksSuccessful renamed to be completed and tasksCompleted?

How do you think about above and remove the log.
if (successful(index)) {
  logInfo(
    s"Task ${info.id} in stage ${taskSet.id} (TID $tid) failed, " +
    "but another instance of the task has already succeeded, " +
    "so not re-queuing the task to be re-executed.")
}

Rather than remove the comment, maybe it's better to clarify it as you say, to refer to being "completed" rather than "successful". I don't know enough to evaluate whether you're right about that change, but it seems reasonable.

@srowen
Thanks a lot. I'll refine : )

@kayousterhout
Would you please give a look at this ? It's great if you could help review this : )

I'd prefer to just change the log message and not rename successful to completed -- which I think is too ambiguous with tasks that have "completed" in the sense that they've failed (if we're going to do that change, I think there should be a bigger change to change all of the uses of successful to be consistent and to add better commenting, which is beyond the scope of this log-change PR).

Can one of the admins verify this patch?

I just changed the log message, but not sure if it clear enough.

The state of this change is OK, but seems to trivial. This doesn't communicate something substantially different.

Thanks a lot for the comments. Actually Im still not sure how to change this log or even just remove it. I just think the log is confusing. It is printed out every FetchFailed. Please give some suggestions if possible. If this is too trival to fix, should I close this PR?

@kayousterhout
Thanks a lot for helping this pr thus far. I think the proposal is quite clear. I've already refined. Please take another look.

LGTM! Thanks for fixing this!  I'll merge this tomorrow once tests pass and pending any further comments from @srowen

@kayousterhout
Thanks a lot again : )

Test build #3556 has started for PR 16738 at commit a2cfd69.

Test build #3556 has finished for PR 16738 at commit a2cfd69.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged this to master.  Thanks for the fix @jinxing64 -- these fixes to improve readability / usability of the code are super useful!


[google_maps_flutter_ios] Failing native tests

The native tests in GoogleMapsUITests.m are consistently failing locally and on CI for Flutter main branch. I've also noticed this has been failing for over a week.
/Volumes/Work/s/w/ir/x/w/packages/packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerUITests/GoogleMapsUITests.m:53: error: -[GoogleMapsUITests testUserInterface] : failed - Failed due to not able to find User interface
    t =    63.39s Tear Down
Test Case '-[GoogleMapsUITests testUserInterface]' failed (63.614 seconds).
Test Suite 'GoogleMapsUITests' failed at 2024-09-03 11:59:47.863.
	 Executed 4 tests, with 4 failures (0 unexpected) in 256.426 (256.427) seconds
Test Suite 'RunnerUITests.xctest' failed at 2024-09-03 11:59:47.863.
	 Executed 4 tests, with 4 failures (0 unexpected) in 256.426 (256.428) seconds
Test Suite 'All tests' failed at 2024-09-03 11:59:47.864.
	 Executed 4 tests, with 4 failures (0 unexpected) in 256.426 (256.429) seconds
2024-09-03 12:00:13.009 xcodebuild[50120:308772] [MT] IDETestOperationsObserverDebug: 291.207 elapsed -- Testing started completed.
2024-09-03 12:00:13.009 xcodebuild[50120:308772] [MT] IDETestOperationsObserverDebug: 0.000 sec, +0.000 sec -- start
2024-09-03 12:00:13.009 xcodebuild[50120:308772] [MT] IDETestOperationsObserverDebug: 291.207 sec, +291.207 sec -- end

Test session results, code coverage, and logs:
	/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-bynswbqjzzfjuuheqrjysabjmvyt/Logs/Test/Run-Runner-2024.09.03_11-54-50--0700.xcresult

Failing tests:
	-[GoogleMapsUITests testMapClickPage]
	-[GoogleMapsUITests testMapCoordinatesPage]
	-[GoogleMapsUITests testMarkerDraggingCallbacks]
	-[GoogleMapsUITests testUserInterface]

** TEST FAILED **

Testing started

[packages/google_maps_flutter/google_maps_flutter_ios completed in 6m 23s]

See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737792882371508001/+/u/Run_package_tests/native_test/stdout?format=raw for full logs.
The problem seems to be that XCUIElement is failing to find the Flutter element in the example app:

They are currently skipped: https://github.com/flutter/packages/blob/main/packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerUITests/GoogleMapsUITests.m#L52


Some missing input files

Hi,
It's a fascinating piece of work.
When I tried to run NeuFace on the Facescape dataset, I found some input files were missing. For example, "Rt_scale_dict.json".
How could I get these files or do I need some preprocessing on the dataset?
Thanks.

Thanks for your attention!
Facescape provides those input files, you can find the missing files from Facescape dataset.
If you want to run NeuFace on the Facescape dataset, it is recommended to preprocess the images obtained from Facescape by applying a mask to exclude the areas outside the facial region. The mask can be obtained by rendering the provided mesh from the Facescape dataset.

OK, thanks.
Besides, I cannot find the mask jpg files for Facescape and I don't see them in the preprocessed files of Imface. Could you help me know how to get the mask files? Thank you.

The mask image can be obtained through the following steps: 1) Using the preprocessing code provided by ImFace to crop the high-quality mesh provided in FaceScape; 2) Rendering the cropped mesh using the camera poses provided by the FaceScape dataset to obtain the final mask.

Thanks for your instruction.
Formerly, I trained 3000 epochs (ID: 1, Expression: 2) without a mask (totally white image), but the rendering performance was really poor. Does the mask of the face play an important role in NeuFace or should I modify some codes to train without a mask? Thank you.

Yes, because we utilize ImFace as a facial geometry prior, which only models the facial region. Therefore, masks are required during the training process.

The mask image can be obtained through the following steps: 1) Using the preprocessing code provided by ImFace to crop the high-quality mesh provided in FaceScape; 2) Rendering the cropped mesh using the camera poses provided by the FaceScape dataset to obtain the final mask.

Thanks for your help!
However, when I try to use the preprocessing codes of IMFace to crop the facial region, the 3D model is cropped from the OBJ file (smooth head model, coordinates range from about -100 to 100). But the camera parameter file provided by Facescape seems to be matched with its PLY 3D models (dense vertices). Could you help me to know how to render the binary mask by the unmatched 3D face model and camera param file?
Thank you.

To match the camera pose, I recommend you refer to this code.

Thanks.
Now I get the masks like the following images (please ignore the inverse color, and note that the last image renders from the back view):

However, the performance of the trained model is still not good (PSNR around 10). Is this caused by the masks? Could you help me figure out the problem and reproduce the results in the paper? Thank you!

Can you email me the whole train images (include rgb and mask) that you have used?

OK. Thanks!

I downloaded the dataset but the Rt_scale_dict.json file was missing. How did you handle this?

You can download the missing file at FaceScape @76donghyun


Update paperclip paths for store model

What I changed is inline with what is on solidus core for regular images: https://github.com/solidusio/solidus/blob/e15ca73e8f7083633343f0678023695a96e24d31/core/app/models/spree/image.rb#L9
Moreover, how it was would not correctly path to an image, since it was the root directory, not under /public.

I've confirmed the existing settings don't work out of the box, so I'm fine blowing them away for this which I have confirmed does work.
Thanks again @jgujgu :+1:

Very happy to contribute. Thanks for all your help, Clarke.

:+1: Thanks for catching and fixing this!


Feature

I am wondering if we can get a sourceMappingURLPrefix function option just like you have for the sourceRoot so that I can completely control the output of the sourceMaps comment
This change works ... happy to do a pull request if you think it's useful for others, else I'll just fork
if (typeof options.sourceMappingURLPrefix === 'function') {
        comment = commentFormatter(options.sourceMappingURLPrefix(comment,file));
} else
if (options.sourceMappingURLPrefix) {
        comment = comment.replace(/sourceMappingURL=\.*/, 'sourceMappingURL=' +    options.sourceMappingURLPrefix);
}

b65ff7b252af89a509975f1bec5694f5d86d101a doesn't solve that issue as the default path will be appended to the string returned by sourceMappingURLPrefix anyway:
if (typeof options.sourceMappingURLPrefix === 'function') {
  options.sourceMappingURLPrefix = options.sourceMappingURLPrefix(file);
}
comment = comment.replace(/sourceMappingURL=\.*/, 'sourceMappingURL=' + options.sourceMappingURLPrefix);		         comment = comment.replace(/sourceMappingURL=\.*/, 'sourceMappingURL=' + options.sourceMappingURLPrefix)


Fix accidental precision loss (#814)

Submission Checklist

[ ] Run unit tests: ./runTests.py test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary:
There's accidental precision loss due to the use of integer instead of floating point divide. The offending function also does redundant loads and possibly a redundant divide, even with optimizations enabled. See #814 for more details and discussion.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Dan Luu
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Sorry, got really busy recently. I certainly don't mind finishing it, but I'm not sure when I'd get around to it. If you want to finish it up, please go ahead :-).

@bob-carpenter Test added, and I merged in the latest develop. This should be good to go


Windows Runner Sample Broken Link

Windows Runner Sample

Download the compiled version of the PlayFab Multiplayer Server Build for the Windows Runner sample .
Link is broken

We no longer provide precompiled versions of the sample. Instead, we now offer detailed instructions for downloading and compiling the sample yourself.


docker build using colima with lima v0.23.1 hangs

Description
This command hangs indefinitely using lima v0.23.1:
docker buildx build -f - . <<'EOF'
FROM ubuntu:latest
RUN apt-get update
RUN apt-get install -y gnupg
RUN apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys ABF5BD827BD9BF62
EOF

This is not a problem when using the previous version of lima (v0.22.0).
Colima was started with:
colima start --vm-type=vz --cpu 12 --memory 16 --runtime=docker --arch aamd64 --vz-rosetta

System information:
$ colima --version
colima version 0.7.3

$ lima --version
limactl version 0.23.1

$ system_profiler SPSoftwareDataType SPHardwareDataType
Software:

    System Software Overview:

      System Version: macOS 14.6.1 (23G93)
      Kernel Version: Darwin 23.6.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal
      Computer Name: REDACTED
      User Name: REDACTED
      Secure Virtual Memory: Enabled
      System Integrity Protection: Enabled
      Time since boot: 10 days, 15 hours, 18 minutes

Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: Mac15,7
      Model Number: Z1AJ0018XLL/A
      Chip: Apple M3 Pro
      Total Number of Cores: 12 (6 performance and 6 efficiency)
      Memory: 36 GB
      System Firmware Version: 10151.140.19
      OS Loader Version: 10151.140.19
      Serial Number (system): REDACTED
      Hardware UUID: REDACTED
      Provisioning UDID: REDACTED
      Activation Lock Status: Disabled

Which command hangs?

Came here to search for just an issue like that.
I have the same problem in a larger project using the container ghcr.io/navikt/mock-oauth2-server. For me a downgrade to lima v0.22.0 also was the solution.
I have tried the docker command from this issue on my MacBook with an Intel processor and saw it hang too. Using the https: command variant doesn't change. It still hangs.

Might be related or not, really not sure, but sounds related, and certainly did not happen with 0.22.0. We've been seeing random hangs from running containers with 0.23.1. What happens is requests to http services running in containers just hang indefinitely. If I wait a min or so and try again, often it will start working properly. Downgrading lima to 0.22.0 makes the problem go away entirely.
Started the colima VM with: colima start --vm-type=vz --cpu 4 --memory 16 --disk 128 -V /private/tmp:w -V "$HOME":w -V /var/folders:w
This is on an M1 Pro macbook. Happy to provide any other debugging info that might be helpful.
For reference, used this to downgrade since brew doesn't make it easy:
colima stop
wget https://github.com/lima-vm/lima/releases/download/v0.22.0/lima-0.22.0-Darwin-arm64.tar.gz -P ~/Downloads
tar xfvz ~/Downloads/lima-0.22.0-Darwin-arm64.tar.gz -C /opt/homebrew/Cellar/lima/0.23.1
colima start

@ns-dfarino Can you try with latest lima head it has gvisor-tap-vsock 0.7.5 ??

git bisect points to 43a5f4a

Gvisor-tap-vsock has a regression with 0.7.4. This is fixed in 0.7.5. https://github.com/containers/gvisor-tap-vsock/pull/386

@balajiv113 very good! https://github.com/lima-vm/lima/commit/4592e3470eb194425fbf02f3a15ee741c89d68dd works correctly.

I also checked to see if this fixes my problem and it does. Great stuff.

Released https://github.com/lima-vm/lima/releases/tag/v0.23.2


Add DPR to hvictl to specify default priority order of virtual interrupts

Signed-off-by: John Hauser<EMAIL_ADDRESS>

Can we make hvictl.DPR as WRAL ? This will allow implementation to have fixed behavior if they want.

Sorry, @avpatel, recent commit 8604127 moved most of the AIA document to frozen state.  RVIA policies are that once a spec is frozen, "a change will only occur because of some truly critical issue being identified .... Any other desired or needed changes can be the subject of a follow-on new extension."
The main purpose of CSR hvictl is to allow a hypervisor to emulate VM interrupts that go beyond what the hardware supports natively.  In my view, giving the hypervisor control over default priority for emulated virtual interrupts is well within the spirit of that purpose.  The cost for competent hardware implementations should be quite tiny, I think.


Introduce new Run Script phase for SwiftLint autocorrect

As a developer, I want my code to be automatically formatted so that the project has a consistent style.

Acceptance criterias

When building the project, SwiftLint should autocorrect the whole project
The Pods/ directory should not be autocorrected
The whole project is autoformatted once as part of this story (for a "fresh" start)

Open questions

Should the binary (> 10 MB) be checked into the repository?
Are there any rules that we want to opt-in to?

@holyturt, what's your opinion on this? During my regular daily work, SwiftLint helps me not to worry about formatting. I just copy-paste, put linebreaks wherever I want, all knowing that the autocorrector will clean up for me.

It's interesting! We should use it.

Should the binary (> 10 MB) be checked into the repository?

According to the official page, they discourage checking it into repos. Therefore, I'd like to go along with that.

Are there any rules that we want to opt-in to?

No, It seems it's ok to use the default rules to me.
Thank you for the idea and what do you think about them, @wtimme?
Do you know any nice opt-in rules?
Thank you in advance!


fix(vitest-pool-workers): add node lib timers implementation

What this PR solves / how to test
Adds node lib timers implementation, so that the following code works:
require('node:timers').setTimeout

setImmediate, active, unroll, and promises are not implemented.
Author has addressed the following

Tests

[ ] TODO (before merge)
[ ] Included
[x] Not necessary because: they weren't there before, but I'm willing to add some

E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)

[ ] I don't know
[ ] Required / Maybe required
[x] Not necessary because: not relevant for this type of fix

Changeset (Changeset guidelines)

[x] TODO (before merge)
[ ] Included
[ ] Not necessary because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s):
[x] Not necessary because: wasn't there before

If it is this simple, I wonder why @mrbbot didn't add this in the first place?

Thanks for your quick replies! We're trying to test our worker, and before deployment, we use esbuild to resolve node:timers, node:fs etc (using https://github.com/bubblydoo/cloudflare-workers-compat).
However, in tests, we preferably just import our worker directly from typescript without a building step (to have faster refreshes etc).
Unfortunately if we do:
defineWorkersConfig({
  ...,
  resolve: {
    alias: {
       timers: './aliases/timers.cjs',
       'node:timers': './aliases/timers.cjs',
    }
  }
})

Then, the worker/lib/node/timers.cjs file will still get priority instead of ./aliases/timers.cjs.
It would be great if the files in lib/node can only be imported by Vitest code. That would also fix #6405.

So if we change the resolution to check the aliases before the built-in modules that would solve it for you?

That would fix this specific issue, but not the others I've opened. Also as mrbbot mentioned the lib files being available in tests is quite a big difference between tests & production.
There are multiple things that can be improved in our situation:

configuring bundleDependencies
configuring esbuild settings
vitest-specific lib (e.g. fs, timers, debug)
bundling configuration that's shared between tests & wrangler deploy

I will look at the codebase and try to see what I can do, and then I will get back to this PR, maybe with a more holistic solution 🙂


Add UT for AlluxioLog4jSocketNode object white list

Fixes #14767.
What changes are proposed in this pull request?
Added unit tests for the deserialization white list.

A class in the white list is allowed to be deserialized.
A class not in the white list is rejected from deserialization.
If future log4j versions change internal data structure to use classes that are not covered by the current white list, the UT should fail as a signal to the maintainer that the white list needs to be updated.

Does this PR introduce any user facing changes?
No.

@dbw9580 Please review it.

Please also make sure your changes can compile and pass all the automated checks (including checkstyle, license, findbugs and unit tests/integration tests). Look for test failure messages in GitHub Actions logs.
For references, see https://docs.alluxio.io/os/user/stable/en/contributor/Contributor-Tools.html#maven-targets-and-plugins and for unit tests https://docs.alluxio.io/os/user/stable/en/contributor/Contributor-Tools.html#run-unit-tests-for-a-specific-module

alluxio-bot, check it please.

alluxio-bot, check it please.

alluxio-bot, check it please.

alluxio-bot, please check it.

alluxio-bot, please check it.

alluxio-bot, check it please.

If future log4j versions change internal data structure to use classes that are not covered by the current white list, the UT should fail as a signal to the maintainer that the white list needs to be updated.

Can you also include a test to cover this case?

this can be verified with a setup， and remove it to see if log can be accepted.
| |
yong.sunny
|
|
@.***
|
---- 回复的原邮件 ----
| 发件人 | Bowen @.> |
| 日期 | 2022年03月02日 16:10 |
| 收件人 | @.> |
| 抄送至 |<EMAIL_ADDRESS>|
| 主题 | Re: [Alluxio/alluxio] Add UT for AlluxioLog4jSocketNode object white list (PR #15051) |
@dbw9580 commented on this pull request.
In logserver/src/test/java/alluxio/logserver/AlluxioLog4jSocketNodeTest.java:

 new Hashtable<>(),

 new LoggingEvent(

     "fqnOfCategoryClass", Logger.getLogger("a"), Level.DEBUG, "message", new Throwable()),

 new LocationInfo("c", "b", "c", "d"),

 new ThrowableInformation(new Throwable()),

https://github.com/Alluxio/alluxio/blob/72d339e13ff00339636e54f54feb091e7f5cbb4e/logserver/src/main/java/alluxio/logserver/AlluxioLog4jSocketNode.java#L59
RootLogger is not serializable. @yyongycy can you please double check why RootLogger needs to be whitelisted?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

Known flaky test:
[ERROR] alluxio.client.cli.fs.command.PinCommandMultipleMediaIntegrationTest  Time elapsed: 70.116 s  <<< ERROR!
java.lang.RuntimeException: Timed out waiting for process Alluxio job worker to start

The other one looks new:
ExecutionException Error occurred in starting fork, check output in log
2022-03-29T16:15:59.3378149Z 16:15:59.330 [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException Error occurred in starting fork, check output in log

The other one looks new:
ExecutionException Error occurred in starting fork, check output in log
2022-03-29T16:15:59.3378149Z 16:15:59.330 [ERROR]  org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException Error occurred in starting fork, check output in log

This is actaully caused by this known flaky test:
2022-03-30T03:01:55.8890602Z 03:01:55.883 [INFO] Running alluxio.master.metastore.rocks.RocksStoreTest
2022-03-30T03:01:56.3554021Z 03:01:56.354 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.469 s - in alluxio.master.metastore.rocks.RocksStoreTest
2022-03-30T03:01:56.6209718Z 03:01:56.617 [ERROR] pthread lock: Invalid argument
2022-03-30T03:01:56.6903348Z 03:01:56.689 [INFO] Running alluxio.master.metrics.MetricsMasterTest
2022-03-30T03:01:56.9816604Z 03:01:56.978 [ERROR] Aborted (core dumped)

Error: 1.092 [ERROR] Tests run: 10, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 98.905 s <<< FAILURE! - in alluxio.master.journal.raft.RaftJournalTest
Error: 1.093 [ERROR] alluxio.master.journal.raft.RaftJournalTest.gainPrimacyAfterSuspend  Time elapsed: 32.287 s  <<< ERROR!

still one failure?

still one failure?

This one is known flaky failure
Error: 1.093 [ERROR] alluxio.master.journal.raft.RaftJournalTest.gainPrimacyAfterSuspend  Time elapsed: 32.287 s  <<< ERROR!

@dbw9580 does this test pass all the time with latest master?

@dbw9580 does this test pass all the time with latest master?

Not sure. Let me rebase this on the latest master.


Fix: Use existing rather than deleted models

Description of changes
When looking for missing function dependencies on API, a model diff against current backend doesn't work if the model was both added, function added with dependency, and model subsequently removed prior to push. This addresses that by looking to see if functions depend on models not in the backend, rather than diffing against cloud backend

Issue #, if available
#9553

Description of how you validated changes
Running unit tests, making an application and testing using the original reproduction steps
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9769 (f1af5bb) into master (943c7ed) will increase coverage by 0.01%.
The diff coverage is 79.31%.

:exclamation: Current head f1af5bb differs from pull request most recent head 88dbf9c. Consider uploading reports for the commit 88dbf9c to get more accurate results

@@            Coverage Diff             @@
##           master    #9769      +/-   ##
==========================================
+ Coverage   52.99%   53.01%   +0.01%
==========================================
  Files         830      830
  Lines       45993    46010      +17
  Branches     9823     9826       +3
==========================================
+ Hits        24375    24390      +15
- Misses      19600    19602       +2
  Partials     2018     2018

Impacted Files
Coverage Δ

packages/amplify-util-mock/src/api/api.ts
0.00% <0.00%> (ø)

...es/amplify-util-mock/src/api/resolver-overrides.ts
0.00% <0.00%> (ø)

...raphql-transformer-migrator/src/schema-migrator.ts
85.27% <100.00%> (+0.11%)
:arrow_up:

...graphql-transformer-migrator/src/state-migrator.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943c7ed...88dbf9c. Read the comment docs.


update ps1 star filtering

Brightness based distance limits

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.001%) to 83.175%

Files with Coverage Reduction
New Missed Lines
%

mirar/pipelines/winter/generator/candidates.py
1
82.22%

mirar/monitor/base_monitor.py
1
83.0%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.001%

Covered Lines:
11128

Relevant Lines:
13379

💛  - Coveralls


Restore order for value_transfers and messages

This PR fixes value_transfers and messages_containing, as they had the inverse order... sorry @juanky201271. It also adds more assertions.

Looks like we need to check the full test suite for regressions.

 Summary [ 788.514s] 334 tests run: 334 passed (109 slow), 30 skipped

git show -s
commit 994103544b2385b9ef4c8f12a5ca4ad4247a8b43 (HEAD, dorian/fix-vt-message-order)
Author: dorianvp<EMAIL_ADDRESS>Date:   Sun Nov 17 14:40:26 2024 -0300
test: add doc & remove println


eglSetDamageRegionKHR failed: eglGetError: EGL_BAD_ACCESS

Hello.
I am using an i.MX8MP board.
When I launch the application in Flutter 3.7.6,
I get "eglSetDamageRegionKHR failed: eglGetError: EGL_BAD_ACCESS".
Is there any workaround for this?
The error log is below:

[TRACE][operator()(171)] presentation info: clk_id = 1
[INFO][operator()(606)] Display scale for output(9): 1
[INFO][operator()(573)] Display output info: width = 1920, height = 1080, refresh = 60000
[TRACE][CreateRenderSurface(1148)] Created the Wayland surface: 1920x1080
flutter: The Dart VM service is listening on http://<IP_ADDRESS>:45875/eBjs9piUlmE=/
[ERROR][SwapBuffers(116)] eglSetDamageRegionKHR failed: eglGetError: EGL_BAD_ACCESS
[TRACE][operator()(143)] window entered output 9
[ERROR][SwapBuffers(116)] eglSetDamageRegionKHR failed: eglGetError: EGL_BAD_ACCESS

I found https://community.nxp.com/t5/i-MX-Processors/Issues-with-EGL-in-iMX8MP/m-p/1572714#M199042. What version of BSP are you using?

Hmm, I'm not sure offhand.

I fixed a FBO issue https://github.com/sony/flutter-embedded-linux/pull/333. Does it make the issue resolve?

Thank you very much.
"EGL_BAD_ACCESS" no longer occurs.
But, I now get flickering in my application.
(It works fine in version 3.3.10.)

Closing the issue.

But, I now get flickering in my application.
Could you create a new issue? It would be great you attach a video I can watch that symptom.


[Issue-3755] Improve UI related to Account selector screen

Pr for issue #3755

🚀 Deployed on https://pr-3764--sw-web-runner.netlify.app


The detail of QuickPick item is truncated by QuickPick separator

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.67.1
OS Version: Windows_NT x64 10.0.22621

Since the detail and label are on different rows, it should not affect each other.
Steps to Reproduce:

Set a long label of QuickPickItem which is separator.
Set a long detail of QuickPickItem below the separator item.

Effect:

Nice find @tecton, I'll get to this as soon as I can.


Create single modal.js file

Builds on top of https://github.com/datproject/dat-desktop/pull/282; probably worth holding off on review until that's done. Relevant commit here https://github.com/datproject/dat-desktop/pull/285/commits/199caed3daf66db77db4b3d0b843349182e0e47e. Implements part of https://github.com/datproject/dat-desktop/issues/280. Thanks!

since #282 has landed, gonna look at the merge conflicts now


My netty server reported an error 'io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: index: 16384, length: -14771 (expected: range(0, 8192))'. Can you tell me why? thank you

Expected behavior
Actual behavior
Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
Netty version
JVM version (e.g. java -version)
OS version (e.g. uname -a)

More details needed and please use issue template.

Usually this means you tried to read more data then what is readable in the buffer.

问题解决了吗？

Usually this means you tried to read more data then what is readable in the buffer.

thank you so much


Translation error when current process ends

Environment
Windows build number: Microsoft Windows [version 10.0.19041.329]
Windows Terminal version (if applicable): 1.0.1811.0

Any other software?

Steps to reproduce

open a WSL terminal
from another terminal, shutdown the WSL instance

When current Terminal process ends, a message with the exit code is shown. This is what appears in French:

[processus terminée avec le code 1]

There's a little typo, this should be;

[processus terminé avec le code 1]

How is handled localization in Windows Terminal? Maybe I could make a PR myself?

Thank you! Right now, our localization is handled by the microsoft translation services team (for the 10 languages we ship.) I'm considering how we would add support for other languages and get help from the community. Because French is one of the MS-translated ones, that wouldn't help!
I've reached out to the localization team to let them know about this.

Thanks again for the report. I just pulled the latest localization data, and I've confirmed that this has been fixed. It'll be out in the next release. :smile:


couchDb not present in /home

Hello,
I'm following the following doc :
http://docs.couchdb.org/en/master/install/unix.html
I have done this command on cent os 7 :
sudo yum -y install epel-release && yum install couchdb
Then, when i hit this command, for a first start, it doesnt work :+1:
sudo -i /home/couchdb/bin/couchdb
couchdb doesnt exists in home.
it doesnt work.

The packages take care of setting up CouchDB properly and not in /home, but in /opt/couchdb. The instructions you’re seeing are for a manual set up without the epel packages.


Fix completion after tokens with wordbreak chars

Fixes part of #196

Current coverage is 88.08% (diff: 100%)

Merging #197 into master will not change coverage

@@             master       #197   diff @@
==========================================
  Files             4          4
  Lines           596        596
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            525        525
  Misses           71         71
  Partials          0          0

Powered by Codecov. Last update 19c6544...40ec27e

Fix confirmed, thanks!


Add  instruction

Add in struction about how to set up node.js,vue, yarn/npm on your pc.

Try to keep any readable files pushed to github as .txt or preferably .md or markdown files so that they can be easily read within github. Here is a guide to writing markdown on github: https://docs.github.com/en/get-started/writing-on-github and https://www.markdownguide.org/getting-started/. Content wise the guide looks good, feel free to send this in the discord.
If you decide to rewrite this and upload it to github be sure to cite any source you directly grab material from as they are potentially not open sourced. If you find yourself taking large sections of text from elsewhere it may also be better to link the resource instead. lmk if you need any help.


Add logging APIs for Go chaincodes

Description

This changeset adds chaincode shim APIs and other facilities that allows
Go chaincodes to create multiple, independent and levelled logging objects
that log consistently with the shim logger. APIs are also provided that allow
the chaincode to control the shim's logging level.
This changeset also removes a redundant logger from the "chaincode" package, and changes the logger used by the Go chaincode shim to log as "shim" (rather than as "chaincode").
Motivation and Context

Fixes #618
Fixes #1303
How Has This Been Tested?

All Go unit tests and behave tests pass. I've also tested it with my own chaincode that uses the new facilities to make sure that both the shim and chaincode logs are generated and controlled correctly.
All of the 'golint' warnings from my new code have been addressed. I also went ahead and gofmt-ed core/chaincode/shim/chaincode.go.
Checklist:

[ x] I have added a Signed-off-by
[ x] Either no new documentation is required by this change, OR I added new documentation
[x ] Either no new tests are required by this change, OR I added new tests
[ x] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Bishop Brock<EMAIL_ADDRESS>

LGTM
Reviewed-by: Greg Haskins<EMAIL_ADDRESS>


feat: Info Card

Overview
Ports InfoCard component used for ProjectCards in portal-app.
We will be using this in the monolith (see PR here).
And we have a tech debt ticket to replace the existing InfoCard component with this Gamut one (see ticket)

Add InfoCard

PR Checklist

[x] Related to designs: https://www.figma.com/file/Lk1KXQGDIrFhxvzs5jO0pr/Project-Hub-Lab?node-id=545%3A55688
[x] Related to JIRA ticket: Egg-2082
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.32-alpha.48eada.0@codecademy/gamut-labs@28.4.1-alpha.48eada.0@codecademy/gamut@42.1.1-alpha.48eada.0@codecademy/monaco@0.5.24-alpha.48eada.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61b8bfe380cf300060ee8322--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.34-alpha.a25260.0@codecademy/gamut-labs@28.4.3-alpha.a25260.0@codecademy/gamut@42.1.2-alpha.a25260.0@codecademy/monaco@0.5.25-alpha.a25260.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61b9161007198e3c7ff961a2--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.34-alpha.0f1707.0@codecademy/gamut-labs@28.4.3-alpha.0f1707.0@codecademy/gamut@42.1.2-alpha.0f1707.0@codecademy/monaco@0.5.25-alpha.0f1707.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61b9189cf7e6c048c616b9a5--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.34-alpha.ef032b.0@codecademy/gamut-labs@28.4.3-alpha.ef032b.0@codecademy/gamut@42.1.2-alpha.ef032b.0@codecademy/monaco@0.5.25-alpha.ef032b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61b93440ada794008fb4b758--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.37-alpha.d3059e.0@codecademy/gamut-labs@28.5.2-alpha.d3059e.0@codecademy/gamut@42.2.2-alpha.d3059e.0@codecademy/monaco@0.5.28-alpha.d3059e.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61c0e05a14dc844bb2d0e19a--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.37-alpha.cf23da.0@codecademy/gamut-labs@28.5.2-alpha.cf23da.0@codecademy/gamut@42.2.2-alpha.cf23da.0@codecademy/monaco@0.5.28-alpha.cf23da.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61c0ecfa22ba4d5192a624b9--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.37-alpha.0c4e38.0@codecademy/gamut-labs@28.5.2-alpha.0c4e38.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61c0eecfbcbea35bab1d33e3--gamut-preview.netlify.appDeploy Logs


Roll engine 22fcb2e8d19e..061d615bc715 (1 commits)

https://github.com/flutter/engine/compare/22fcb2e8d19e...061d615bc715
git log 22fcb2e8d19eb6d4351ae91a4d63ca30c0a0b072..061d615bc715fd07d966d158b0b8c7637aff5bd7 --no-merges --oneline
061d615bc Roll src/third_party/skia 859f7108a5af..2f0f5fb37d74 (2 commits) (flutter/engine#9137)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


Asuswrt, ssh connection refused

Home Assistant release (hass --version): 0.63.3
Python release (python3 --version): Python 3.5.3
Component/platform: Asuswrt
Description of problem: After new merlin-firmware (branch 384)
Connection refused. SSH enabled?
18:03 components/device_tracker/asuswrt.py (ERROR)

It was working just fine with older firmware (branch 380) which will be legacy soon
It is confirmed ssh is enabled and working on the router by establishing a connection from PI:
pi@raspberrypi:~ $ ssh<EMAIL_ADDRESS><EMAIL_ADDRESS>password:
ASUSWRT-Merlin RT-AC68U 384.3-0 Tue Feb 13 21:08:43 UTC 2018
admin@RT-AC68U-4650:/tmp/home/root#

Using telnet as default protocol works:

platform: asuswrt
host: <IP_ADDRESS>
protocol: telnet
username: admin
password: !secret router_password
interval_seconds: 30
consider_home: 600

Did your SSH_KEY/PUB_KEY not change during the upgrade?
If you only use password, you might have to check your known_hosts (or equivalent) file, this will most likely have changed and will prevent you from connecting

Hello, thank you for your advice.
I was testing ssh connection from standard user not homeassistant.
When I tried from it I got this error:
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!
Someone could be eavesdropping on you right now (man-in-the-middle attack)!
It is also possible that a host key has just been changed.
The fingerprint for the ECDSA key sent by the remote host is
SHA256:XkEERFCG7hZnSff1V49i2xqDHAPNRtl3wjzH0lXdEf0.
Please contact your system administrator.
Add correct host key in /home/homeassistant/.ssh/known_hosts to get rid of this message.
Offending ECDSA key in /home/homeassistant/.ssh/known_hosts:1
  remove with:
  ssh-keygen -f "/home/homeassistant/.ssh/known_hosts" -R <IP_ADDRESS>
ECDSA host key for <IP_ADDRESS> has changed and you have requested strict checking.
Host key verification failed.

I had to reinstall from scratch to upgrade python, that's why the key changed.
It could be useful to have a little more explicit error message in home-assistant.log.

The PR should help identifying these types of issues


resigning as maintainer

Describe the bug
I'd like to resign from any maintenance role I have in this project (I can see the settings tab so I have some permissions. I can't see Collaborators so not sure what those permissions are).
VMWare may also want to consider archiving this project as well. There were originally two purposes for this:

prototyping a tuf repository running on github actions
low level CLI tool for manipulating TUF metadata

Purpose 1 is no longer that interesting as there is now a real implementation in tuf-on-ci. The second might still be useful as debugging and testing tool... but I'm not going to maintain it and there have been no commits or new issues in the last year (apart from a couple I filed).
Reproduction steps

Expected behavior

Additional context
No response

I don't have plans of maintaining this as well.
I will contact VMware regarding this situation.


[Q/FR] return to previously selected item

Category

[X ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[ X] Linux
[ ] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[ X] bash
[ ] zsh
[ ] fish

Given a script running in loop offering selection via fzf on each iteration, is it possible to continue nth iteration from the selection that was selected for (n-1)th loop?
Eg take following fshow example, that allows us to seek through commit history, and optionally open the changes it caused, plus some other functionality.
Say user navigates to commit X, selects it, views the changes in whatever diff viewer was started, closes the viewer, and continues navigating the history. Currently the fzf would start as if it was opened for the first time - the viewed entry is no longer selected. Is it possible to start fzf and ask it to go to certain selection?
# - enter shows the changes of the commit
# - ctrl-s lets you squash commits - select the *last* commit that should be squashed.
# - ctrl-c generates the jira commit message.
# - ctrl-u generates gitlab commit url.
# - ctrl-b check the selected commit out.
fshow() {
    local q k out sha url

    q="$*"

    check_progs_installed fzf git || return 1
    is_git || { err "not in git repo." "$FUNCNAME"; return 1; }
    #git log -i --all --graph --source --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit --date=relative |
    while out=$(
            git log --graph --color=always \
                --format="%C(auto)%h%d %s %C(black)%C(bold)(%cr) %C(bold blue)<%an>%Creset" |
                fzf --ansi --no-sort --reverse --tiebreak=index --bind=ctrl-z:toggle-sort --query="$q" --print-query \
                    --expect=ctrl-s,ctrl-c,ctrl-u,ctrl-b --exit-0); do
        mapfile -t out <<< "$out"
        q="${out[0]}"
        k="${out[1]}"
        # note we also need to include git log's graph slashes, pipes and stars to the regex:
        sha="$(echo "${out[-1]}" | grep -Po '^[|\ /\\*]+\s*\K[a-z0-9]+(?=.*$)')" || { err "unable to parse out commit sha" "$FUNCNAME"; return 1; }
        [[ "$sha" =~ [a-z0-9]{7} ]] || { err "commit sha was [$sha]" "$FUNCNAME"; return 1; }

        case "$k" in
            'ctrl-s')
                if [[ "$sha" == "$(git log -n 1 --pretty=format:%h HEAD)" ]]; then
                    report "won't rebase on HEAD lol" "$FUNCNAME" && sleep 1.5 && continue
                elif [[ -n "$q" ]]; then
                    confirm "\nyou've filtered commits by query [$q]; still continue with rebase?" || continue
                fi

                git rebase -i "$sha"~ && continue || return 1
                ;;
            'ctrl-c')
                generate_jira_commit_comment "$sha"
                break
                ;;
            'ctrl-u')
                url="$(generate_git_commit_url "$sha")" || { err "creating commit url failed" "$FUNCNAME"; return 1; }
                copy_to_clipboard "$url" \
                    && { report "git commitcommit url on clipboard"; return 0; } \
                    || err "unable to copy git commit url to clipboard. here it is:\n$url"
                break
                ;;
            'ctrl-b')
                git checkout "$sha"
                break
                ;;
            *)
                # note this is the default functionality: show the changes given commit introduced:
                __open_git_difftool_at_git_root "$sha"
                ;;
        esac
    done
}

Looks like what I'm asking is provided by --bind with execute.


Question for results of risk ranking

Hi,
I wanted to download the results of the "Risk Ranking Version 3.0", but the web was 404. Can you solve it please?
Thanks.

The link should work now. https://smile.hku.hk/ARGs/dataset/riskranking_20220927_rankI_225.zip

Hello, the risk annotation of ARG subtypes is based on gene name, we want to correlate the abundance with risk rank for analysis, when several subtypes are annotated with different risk rank, can we directly merge the abundance and take the highest risk rank for analysis?


Tools->Node.js Tools->Remote Debugging Proxy->Open documentation still points to CodePlex docs

Once we completely moved to Github, this link needs to point to the documentations on Github.

duplicate of #84


📘 Add package manager commands in command examples to be consistent

Link
https://knip.dev/overview/configuration#location
Description of the issue
Problem: There are different package manager commands in the installation section of Getting Started, and the user can switch between the packages managers they are using. In order to be more consistent across documentations, adding this switching is helpful for new users to copy and paste.
Solution: We should make a command example to be able to switch between package managers. This is the example, which I changed in the configuration page of the Overview.
Before (current, got knip command not found in my terminal)

After (switch by package manager)

Thanks Norifumi! I like your suggestion, but I think we need to modify it to either one of these:

npx knip --config path/to/knip.json
npm run knip -- --config path/to/knip.json

I'm leaning towards the first one, what do you think?

@webpro Thanks for the quick reply. I agree with you that npx knip --config path/to/knip.json is better since there is no assumption of npm installation. Can I create PR for this ?

That would be swell! Thank you in advance.

Actually, I have seconds thoughts on this: all commands might go into package.json#scripts and there we don't need any of npx etc. Those command examples in the documentation are concise and minimal just to show the essence of that section. So I think no pull request is necessary here :)

@webpro Got it thanks. Closing this issue.


Discourse Status badge seems to be broken ("invalid response data")

Are you experiencing an issue with...
shields.io
🐞 Description
Relevant shields.io docs: https://shields.io/badges/discourse-status
The badge for my personal Discourse server badge broke (forum.spinalcordmri.org). As a sanity check, I tried the sample Discourse instance listed in the shields.io docs (https://meta.discourse.org), and it too results in a broken badge.
🔗 Link to the badge
https://img.shields.io/discourse/status?server=https%3A%2F%2Fmeta.discourse.org

💡 Possible Solution
This issue was previously reported at: https://github.com/badges/shields/issues/5817

I'm not familiar with Discourse, but I believe Shields looks for an API at the following location: https://forum.hacf.fr/site/statistics.json
See our implementation here:
https://github.com/badges/shields/blob/71299a81788c95363bbafc4a2c75af960b12d5b9/services/discourse/discourse.service.js#L36
That seems to simply redirect to the website's homepage, which is probably why Shields.io returns invalid response data.

Despite the accepted solution for that issue, I don't believe the issue has been resolved, as meta.discourse.org does have a statistics.json file at: https://meta.discourse.org/site/statistics.json (as does my own site: https://forum.spinalcordmri.org/site/statistics.json).
So, perhaps the issue runs deeper than what had previously been reported?

Badge tested using npm run badge https://img.shields.io/discourse/status?server=https%3A%2F%2Fmeta.discourse.org  Output is available here

Wow, this bot is super helpful!
 Response did not match schema  🤷
 "topic_count" is required. "user_count" is required. "post_count" is required. "like_count" is required
 Handled error  🙅
 [ValidationError: "topic_count" is required. "user_count" is required. "post_count" is required. "like_count" is required] {
  prettyMessage: 'invalid response data',
  cacheSeconds: undefined,
  response: undefined
}

It looks like the response scheme has changed. The new returned response from meta.discourse.org is:
Response JSON (before validation)  🎯
{
  topics_last_day: 27,
  topics_7_days: 133,
  topics_30_days: 573,
  topics_count: 47907,
  posts_last_day: 729,
  posts_7_days: 3978,
  posts_30_days: 16714,
  posts_count: 1300794,
  users_last_day: 31,
  users_7_days: 202,
  users_30_days: 932,
  users_count: 73504,
  active_users_last_day: 551,
  active_users_7_days: 1214,
  active_users_30_days: 2325,
  likes_last_day: 435,
  likes_7_days: 2473,
  likes_30_days: 10740,
  likes_count: 1365849,
  chat_messages_last_day: 60,
  chat_messages_7_days: 357,
  chat_messages_30_days: 2391,
  chat_messages_previous_30_days: 5533,
  chat_messages_count: 45587,
  chat_channels_last_day: 3,
  chat_channels_7_days: 9,
  chat_channels_30_days: 50,
  chat_channels_previous_30_days: 50,
  chat_channels_count: 1659,
  chat_users_last_day: 9,
  chat_users_7_days: 23,
  chat_users_30_days: 75,
  chat_users_previous_30_days: 88,
  chat_users_count: 609
}

It looks like this may be as simple as supporting topics, users, posts, etc. in addition to topic, user, post, etc.

Glad you found it helpful! Would you be up for submitting a PR?
Should just need a schema update like you noted, schema can be found here:
https://github.com/badges/shields/blob/9118ba8d24d8abc0de723a3e8a5cb36020248fbc/services/discourse/discourse.service.js#L7-L12


Issues on iOS11

General information
SDK/Library version: 5.4.1
iOS Version and Device: iOS 11 on an iPhone 6s
Hi,
Have there been any reported issues with iOS11? We are currently having an issue where our app freezes and crashes when the Card.io function is initiated on an iOS11 device.
Any help would be greatly appreciated.
Thanks,
Josh

We're having a similar issue. The app isn't crashing, but the delegate methods we defined for userDidCancel and userDidProvide fail to fire in iOS 11 (Swift 3.2).

Can you please provide more details?
Which version of Xcode did you use to build your app? Do the delegate methods still get called in iOS 9/10/etc.?

I can verify that it works correctly build in Xcode 9 using an iOS 10.3 Simulator. @bluk

Hey @bluk any luck with this issue? Any way I can be of assistance?

@Gerst20051 Are you able to run the demo app in https://github.com/card-io/card.io-iOS-source ? Running it in iOS 11 for me seems to present the correct delegate calls for userDidCancel... and userDidProvide....

@bluk @Gerst20051  I believe I have narrowed down what is causing the delegate functions not to fire only on iOS 11. It looks like when there is a tap gesture recognizer added above the CardIOPaymentViewController(for instance having a touch recognizer on the entire window) the cancel/done button events do not fire on iOS 11 although they work fine on iOS9/10. I have attached a link to a sample project I built showing the issue.
https://github.com/SchmidtyApps/CardIOSwiftExampleIssue

Any workaround for this issue? Unfortunately, we can’t stop using gesture recognizers in our app.

@aalvarez255 There are a couple options I found:
1.) Instead of adding the gesture recognizer to the window or on top of everything, you can just add it to the ViewController view so that the gesture isn't over the Navigation Bar which is what actually causes the interference.
2.) Keep a reference to the gesture recognizer you are adding and when you launch card.io temporarily disable it while showing the card.io ViewController. Then when the scan is done or user hits cancel enable the gesture again.
3.) Use the CardIOView to build your own custom screen which is the option I ultimately used. https://github.com/card-io/card.io-iOS-SDK#integrate-as-a-view

@aalvarez255  try  start CardIOs view as modal, it is works for me on Xamarin

I had similar issue happen on my iOS 11 devices , the didScanCard delegate method and didProvide methods never being called on my apps. However , one of the delegate method which is userDidCancel did fired when I tap cancel button... anyone experience this issue ?

@OmegaPrimeZ3  Were you able to resolve this issue?

Or did anyone resolve this issue pertaining to cancel/done buttons not firing on ios 11.x?

`public class CardIORenderer : PageRenderer
{
private bool bViewAlreadyDisappeared = false;
private CardIOPage cardIOPage;
public CardIORenderer()
{

}
protected override void OnElementChanged(VisualElementChangedEventArgs e)
{
    base.OnElementChanged(e);
    cardIOPage = e.NewElement as CardIOPage;
}
public override void ViewDidAppear(bool animated)
{
    base.ViewDidAppear(animated);

    if (bViewAlreadyDisappeared) return;

    var paymentDelegate = new CardIOPaymentViewControllerDg(cardIOPage);

    // Create and Show the View Controller
    var paymentViewController = new CardIOPaymentViewController(paymentDelegate,true);
    paymentViewController.CollectExpiry = cardIOPage.cardIOConfiguration.RequireExpiry;
    paymentViewController.CollectCVV = cardIOPage.cardIOConfiguration.RequireCvv;
    paymentViewController.CollectPostalCode = cardIOPage.cardIOConfiguration.RequirePostalCode;
    paymentViewController.HideCardIOLogo = cardIOPage.cardIOConfiguration.HideCardIOLogo;
    paymentViewController.CollectCardholderName = cardIOPage.cardIOConfiguration.CollectCardholderName;
    if (!string.IsNullOrEmpty(cardIOPage.cardIOConfiguration.Localization)) paymentViewController.LanguageOrLocale = cardIOPage.cardIOConfiguration.Localization;
    if (!string.IsNullOrEmpty(cardIOPage.cardIOConfiguration.ScanInstructions)) paymentViewController.ScanInstructions = cardIOPage.cardIOConfiguration.ScanInstructions;

    // Not sure if this needs to be diabled, but it doesn't seem like something I want to do.
    paymentViewController.AllowFreelyRotatingCardGuide = false;
    Device.BeginInvokeOnMainThread(() =>
    {
        var window = UIApplication.SharedApplication.KeyWindow;
        var vc = window.RootViewController;
        while (vc.PresentedViewController != null)
        {
            vc = vc.PresentedViewController;
        }
        // Display the card.io interface
        vc.PresentViewController(paymentViewController, true, null);
    });

}
public override void ViewDidDisappear(bool animated)
{
    base.ViewDidDisappear(animated);
    bViewAlreadyDisappeared = true;
}

}
public class CardIOPaymentViewControllerDg : CardIOPaymentViewControllerDelegate
{
private CardIOPage cardIOPage;
private CardIOCard cardIOCard = new CardIOCard();
public CardIOPaymentViewControllerDg(CardIOPage page)
{
cardIOPage = page;
}
public override void UserDidCancelPaymentViewController(CardIOPaymentViewController paymentViewController)
{
    paymentViewController.DismissViewController(true, null);
    MessagingCenter.Send<CardIOCard>(cardIOCard, "CreditCardScanCancelled");
}

public override void UserDidProvideCreditCardInfo(CreditCardInfo card, CardIOPaymentViewController paymentViewController)
{
    paymentViewController.DismissViewController(true, null);

    if (card == null)
        MessagingCenter.Send<CardIOCard>(cardIOCard, "CreditCardScanCancelled");
    else
    {
        cardIOCard.cardNumber = card.CardNumber;
        cardIOCard.ccv = card.Cvv;
        cardIOCard.exprMonth = card.ExpiryMonth.ToString();
        cardIOCard.exprYear = card.ExpiryYear.ToString();
        cardIOCard.redactedCardNumber = card.RedactedCardNumber;
        cardIOCard.cardholderName = card.CardholderName;

        MessagingCenter.Send<CardIOCard>(cardIOCard, "CreditCardScanSuccess");
    }
}

}
This is what I have for the code`

@aznelite89 did you resolve your issue?


Allow runOnDemand for RTSP proxy

Describe the feature
Can runOnDemand be enabled for RTSP proxy mode? My use case is OBS Studio 29 publishing H265 via its RTSP server, proxies by RTSP Simple Server. (H265 isn't supported by OBS RTMP output). So I'd like RTSP Simple Server to start OBS. Might need to wait a couple of seconds for the OBS process to start.

Not needed. OBS recording settings output to link works.


feat(map): update data model for markers

Description
This modifies the data model as described in #414, introducing a new type of top-level categorization:

Mutual Aid Group
Organization / Government-Run / NPO / Company
Financial / Fundraiser
Information
Other

The top level filtering is now done by this rather than service
cc @Tahfimul
TODO:

[ ] update the results display to include the type

Motivation
Release Checklist

[ ] This code has unit tests
[ ] I have a plan to verify that these changes are working as expected after deploy
[ ] I have a plan for how to revert, rollback, or disable these changes if things are not working as expected

Security Checklist
This PR creates, modifies, or deletes:

[ ] API routes: API routes, parameters, or user authorization
[ ] Authentication: Authentication mechanism
[ ] Credentials: Server side credentials, or secrets in configuration / source code
[ ] Cryptography: Encryption, hashing, certificates, signatures, random numbers, etc.
[ ] User data: personal information handling, logs, error messages, etc.

Additional Notes
Fixes #414
Related: #286 #406 #411

👍 LGTM


Add scaladoc generation to CI build

This should address #306

Codecov Report

Merging #307 (887810e) into main (87ad430) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   96.66%   96.66%
=======================================
  Files           9        9
  Lines        1048     1048
  Branches      101      101
=======================================
  Hits         1013     1013
  Misses         35       35

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
96.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ad430...887810e. Read the comment docs.

thanks!