Test RMLSTC0007c failing

Hi,
While trying out some of the test cases in BURP I noticed RMLSTC0007c test case fails with the following error:
java.lang.RuntimeException: javax.xml.xpath.XPathExpressionException: javax.xml.transform.TransformerException: A location step was expected following the '/' or '//' token.
        at burp.ls.XMLSource.iterator(XMLSource.java:48)
        at burp.Main.generate(Main.java:84)
        at burp.Main.doMain(Main.java:56)
        at burp.Main.main(Main.java:43)
Caused by: javax.xml.xpath.XPathExpressionException: javax.xml.transform.TransformerException: A location step was expected following the '/' or '//' token.
        at java.xml/com.sun.org.apache.xpath.internal.jaxp.XPathImpl.compile(Unknown Source)
        at burp.ls.XMLSource.iterator(XMLSource.java:39)
        ... 3 more
Caused by: javax.xml.transform.TransformerException: A location step was expected following the '/' or '//' token.
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.error(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.RelativeLocationPath(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.LocationPath(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.PathExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.UnionExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.UnaryExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.MultiplicativeExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.AdditiveExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.RelationalExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.EqualityExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.AndExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.OrExpr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.Expr(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.compiler.XPathParser.initXPath(Unknown Source)
        at java.xml/com.sun.org.apache.xpath.internal.XPath.<init>(Unknown Source)
        ... 5 more
javax.xml.xpath.XPathExpressionException: javax.xml.transform.TransformerException: A location step was expected following the '/' or '//' token.
System exiting with code: 1

Test was executed only with the --mappingFile argument.
Is this the expected behavior?
Many thanks!

Hello,
Thanks for pointing this out. This test fell through the cracks because some failed ("source not yet implemented").
RMLSTC0007c failed because :

The iterator is incorrect: it should have been //Friends/Character instead of //Friends/Character/
The selector for the attribute was also incorrect: is should have been @id instead of id

I have committed fixes to the test case.
@DylanVanAssche: here are some problems in RMLSTC0007c and RMLSTC0007d.
With my best regards,
Christophe

@idomingu Let me know if this is OK and I will then close the issue.

Hi @chrdebru, it's working now. Thanks!

Test case also fixed upstream, closing! Thanks!


Remove version: WHONET.2023 version 23.12.14

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

#133371

Sequence contains no elements

https://github.com/microsoft/winget-pkgs/issues/133371

(Automated response - build 642.)

Automatic Validation ended with:

2024-01-20T03:20:59.6220938Z Processing manifest: manifests\w\WHONET\2023\23.12.14
2024-01-20T03:20:59.6231235Z -----------------------------------------------------
2024-01-20T03:20:59.6235810Z Status: Started
2024-01-20T03:20:59.6244450Z Manifest file is Deleted
2024-01-20T03:20:59.8764494Z Status: Completed
2024-01-20T03:20:59.8772675Z ##[error] Result: Failed
2024-01-20T03:20:59.8827274Z ##[error] Sequence contains no elements
2024-01-20T03:20:59.9384770Z ##[error]Manifest Validation Failed

(Automated response - build 642.)


Format disconnect messages

We already format chat & death messages. Let's refactor loading & error screen to React and use the same logic as for death screen, this should be easy. Also need to ensure that long kick messages are scrollable and don't overflow buttons (+ensure have global scroll bar styles).
examples. This is not readable at all:

IssueHunt Summary

Backers (Total: $50.00)

 zardoy ($50.00)

Become a backer now!
Or submit a pull request to get the deposits!
Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

I want to work on this issue can you help me how to approach initially

Hey @raghavpatidar! To reproduce:

On the prod website:

Connect to mc.gamster.org

Locally:

Start npm script test-mc-server
Start npm script start
open localhost:8080
connect to server by ip localhost
In terminal with npm script test-mc-server write kick <player name> like kick testbot

You should see raw JSON text displayed, instead the json should be parsed and used with MessageFormattedString.tsx (from next branch)
I was adding storybook support on the next branch, so it's easier to develop React components. You can see how DeathScreen is used in combination with StoryBook: https://github.com/zardoy/prismarine-web-client/blob/d77484c9662819edda8fe88424e9ea0190bd152b/src/react/DeathScreen.stories.tsx#L24-L25 You might want to do new React component in the same fashion (I mean refactor loading_or_error_screen.js)

Sorry for the delay. In MC version plays a crucial role, open mc server file - just because it set to run with version 1.16.1, it runs with version 1.16.1. And here you are connecting from the web client with version 1.18.1. Another question is why auto-version doesn't work sometimes and there is no proper error message when you connect to flying-squid. I think most probably there is an issue specific to flying-squid js impl, need to look into protocol stuff because I definitely remember I didn't have such issues with native java servers. Flying squid is totally okay for simple testing as it is fast & portable, but of course, for bigger testing or adding more serious features I always use native servers remotely/locally.

test fund

/bounty $20

/bounty $10


Override key mapping after app is launched

Hello,
is it possible to setup the key mapping after the app is launched? Reading the lightning sdk, it seems the keys register can happen only inside the Application class' constructor, no way to invoke this with a public method.

Thanks for your patience on this issue @darioRandazzoAccedo
Would you be able to provide a bit more context on how you would want to change the keymapping after app launch? Are you looking to change it from within the app context? or from the outside in?

Hello,
our pipeline would be:

LNG (sync) launch;
async launch of another library;
once this library is loaded, we use one of its functions that will provide us the key mapping for the current platform;
now we would call whatever LNG function that will let us override the app key mapping (we are missing this last step at the moment).

I hope the workflow is clear.
Thanks!


Add dockerfile for building h3 tools for testing

Wonder if it'd nicer to do something like
tools/http3/Dockerfile

@cmcfarlen remember to set labels, Milsetone etc.

The build_h3_tools.sh script uses tags for each of the tools.

[approve ci autest]

[approve ci autest]


Receiving Uncaught ReferenceError: Vivus is not defined Webpack 4

Greetings, I am using the latest npm package for Vivus -- I also imported Vivus into my application.js file for Webpack. When I tried to use the Vivus object in my script, it does not work & continue to receive an error. Can you please explain how to get your library functioning on Rails 6.0 with webpack 4?
application.js
import Vivus from "vivus";
index.html.erb
<script>
$(document).ready(function(){
 new Vivus('contract-cloud', {duration: 200});
});
</script>

Hi there,
I must admit I never used this set up (Webpack 4 + Rails) but I'll try to help.
Right now, Vivus is exported as UMD package. Have you tried import * as Vivus from "vivus"? Because it might be the right way.
However, can you provide a console of the Vivus variable after importing it, to see what it contains? Also if you could please provide a copy of your error? It could be helpful (or any other details). Thanks

Okay. I will report back tonight after work

I added the statement as you described. The output in my console is below:
Vivus(element, options, callback) {
setupEnv(); // Setup
this.isReady = false;
....

Is this the desired results?

In the index.html.erb page, I still receive Uncaught ReferenceError: Vivus is not defined. (after making the change the import statement)

Okay, I attempted to move the logic out of the index page into the application.js file
using a trick that worked before, and I receive no errors. But, the animation is not starting.

document.addEventListener('DOMContentLoaded', () => {
 const viv = new Vivus('contract-cloud', {duration: 200, type: 'delayed', animTimingFunction: Vivus.EASE})
});

<svg xmlns.....id="contract-cloud"...></svg>

Sorry I should have provided an example. I didn't ask to edit the source code of Vivus. Just display the object after importing it. Also
// Import Vivus
import * as Vivus from "vivus";

// See the content of the Vivus object
console.log('Vivus object:', Vivus);

// Wait for the page load of your page to start your animation
window.addEventListener('load', () => {
  const viv = new Vivus('contract-cloud', {
    duration: 200,
    start:'autostart',
    type: 'delayed',
    animTimingFunction: Vivus.EASE
  });
  console.log('Animation started', viv);
});

// ...then your HTML code
// <svg xmlns.....id="contract-cloud"...></svg>

Also do you mind testing your SVG in vivus-instant to test the compatibility. If your SVG isn't animated in it, it means your SVG isn't stroke based, so Vivus cannot animate it. You can also provide a copy on this issue if you don't mind sharing it.

It may be a stroke compatibility issue -- I will re-open if its not. Thanks again. I purchased this particular svg on flaticon.com.


Loading an ARMI DB without the App that created it

What is the change?
This PR add supports for loading an ARMI DB without the App that created it.
Why is the change being made?
This was a user request.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes have been updated if necessary.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

@alexhjames @jeffbaylor I just want to keep this on everyone's radar. I'm still hoping for a review.

Passing comment that came to me this morning: this only works if all the materials and shapes in the database are loadable, right? This change seems to

skip blueprints if we don't know how to process them
set all parameters to read only

Which is good.
But if my application defines a new component that only exists in my application, we will have no way to load that, correct? Same for a material.
If we really want to make it possible so any application can open any database, as the title here suggests, those are two additional things we'd need to handle

But if my application defines a new component that only exists in my application, we will have no way to load that, correct? Same for a material.
If we really want to make it possible so any application can open any database, as the title here suggests, those are two additional things we'd need to handle

Correct.  There are actually many more things that people can do in their code that will make it hard to open an ARMI DB without the Application that created it.
Please note that the code in this PR does not suggest a complete solution to that problem. I provide a tool to ignore blueprint sections, and another to ignore parameters. That's really all you get here.
The only "complete solution" to load a DB without the App that created it would mean storing huge portions of that code in the DB.  And I don't think that's a rabbit hole we want to go down, it's been tried before.
TLDR; the title of this PR and its ticket are perhaps the problem here. I grant that. Here I provide 2 or 3 tools that downstream users can try to use to solve the problem, but only in a limited fashion.


⚠ Fortnite has degraded performance

In 6dd9cc3, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1668 ms

Resolved: Fortnite performance has improved in f9a1d7c.


I want to add a "Rate Us" Functionality for this web app (star rating)

Is your feature request related to a problem? Please describe.
The modern website have a "Rate Us" feature. Which is bassically a 1 to 5 star and a comment input based rating system. Thow it has now backend, so for now i built the functionalty of frontend. It only display the grettings after submit the rating.
Describe the solution you'd like
This functionality should be there because it help to developer to improve the UI, UX accordingly.
I attached it in Footer.
Additional context
I f you assign me this task i made it like this --->
https://github.com/user-attachments/assets/58b3f811-600e-4520-a545-4512ae934668
Please assign me this issue I want to work on it
NOTE
If you assgn me this task pleasse add the all necessary tags along with hacktoberfest-accepted

#771


Tracking down delay

Hello again Dominik,
I am seeing roughly a 10 second interval between the given stream and the output.
I'm trying to track it down by adding some logging at the point where the audio is received and when the transcription is generated.
My issue is with keeping track of what segment is processed at what point, so I can say, for example, "Segment 1 received at 12:35:27, output given at 12:35:38", "Segment 2 received at..." etc
Could you give me a couple of pointers on how to achieve this?

hi,
see the debug prints:
DEBUG	## last processed 10.01 s, now is 10.70, the latency is 0.69

I hope you can read in the code what "the latency" is in this context. You can also suggest rewriting the debug prints so that it's easier to understand.

so was this info enough? Feel free to reopen.
Good luck!


Moving windows networking information to a new page

Signed-off-by: Mark Rossetti<EMAIL_ADDRESS>
Moving Windows networking information to a new page.
Part of #31428
/label refactor
/sig windows

@brasmith-ms @daschott @jayunit100
We should review/update this page for accuracy too. I mostly just copy/pasted what was present in the intro-to-windows page.

Hmm, perhaps this page should go under /concepts/services-networking/
What do people think?

Previews: (Because Netlify GitHub bot is not updating its comments properly 🤔)

https://deploy-preview-31852--kubernetes-io-vnext-staging.netlify.app/docs/reference/windows/windows-networking/
https://deploy-preview-31852--kubernetes-io-vnext-staging.netlify.app/docs/setup/production-environment/windows/intro-windows-in-kubernetes/#:~:text=Check the DNS limitations for Windows in this section.
(I confirm that for now the updated link works. 😊)

Would it be reasonable to put “Networking on Windows Nodes” within https://kubernetes.io/docs/reference/node/ ?

If this merges, I can update https://github.com/kubernetes/website/pull/30817 to link to the information about Windows specifics.

Would it be reasonable to put “Networking on Windows Nodes” within https://kubernetes.io/docs/reference/node/ ?

Let me move some sections out of this document and into the existing pages (like DNS limitations to https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/) and then we can see what information is left.
If I was a user I think I expect some of the information in this page to be near other pages in https://kubernetes.io/docs/concepts/services-networking/ . I also think we can probably remove "node" from the page heading to make it better fit in here.
I'm also OK moving it to /reference/node/ if folks agree that is a good place.
What do you all think? @immuzz @aravindhp @jsturtevant @jayunit100 @perithompson @brasmith-ms

Let me move some sections out of this document and into the existing pages (like DNS limitations to https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/) and then we can see what information is left.
If I was a user I think I expect some of the information in this page to be near other pages in https://kubernetes.io/docs/concepts/services-networking/ . I also think we can probably remove "node" from the page heading to make it better fit in here.

My vote is for the above.

I'm also OK moving it to /reference/node/ if folks agree that is a good place.

I not sure if users would end up on this page looking for Windows networking information.

Let me move some sections out of this document and into the existing pages (like DNS limitations to https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/) and then we can see what information is left.
If I was a user I think I expect some of the information in this page to be near other pages in https://kubernetes.io/docs/concepts/services-networking/ . I also think we can probably remove "node" from the page heading to make it better fit in here.

My vote is for the above.

I'm also OK moving it to /reference/node/ if folks agree that is a good place.

I not sure if users would end up on this page looking for Windows networking information.

Updated - PTAL

@bridgetkromhout  FYI too!

This PR has been dangling for over a month. I'd like to move this forward instead of blocking it for trivial issues.
/approve

/label tide/merge-method-squash

/hold
We want all the PRs that break up /modify https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/
See https://github.com/kubernetes/website/pull/31851#issuecomment-1079162797

@marosset Could you please elaborate what do you mean by "We want all the PRs..."? Do you intend to merge all these refactor PRs into a single one, or break the huge task into several pieces? For the sake of easier reviewing, I'd like to suggest the second approach. However, the overall plan and pace would be up to you. Hopefully, these changes are not introducing a lot of dangling links between them.

What I suggested (this was in the SIG Docs meeting) was that once there are a bunch of PRs that are ready to merge into the main branch, SIG Docs can help get those merged.
In my view, there great part of the effort is lining up PRs that are good to merge, and actually merging them is more restricted (needs an approver's time) but less effort.
We also agreed in that meeting to continue working towards doing that merge after the v1.24 release.

Hi @marosset, I don't think this PR should target dev-1.24

/close
I will squash the commits and create a single PR with all of the related changes targeting main.

/milestone clear

(sorry about the mixed messaging here @marosset)
You'll likely have an easier time of it if you hold of making that single PR until after the v1.24 release.
The way I suggest you do that is by waiting 'til then, making a new branch, and then merging in all of your existing work. If you then want to rebase against main, or against the merge point for the v1.24 release, that's tidier but optional.

(sorry about the mixed messaging here @marosset) You'll likely have an easier time of it if you hold of making that single PR until after the v1.24 release.
The way I suggest you do that is by waiting 'til then, making a new branch, and then merging in all of your existing work. If you then want to rebase against main, or against the merge point for the v1.24 release, that's tidier but optional.

No worries.
Yea, I was thinking about waiting for 1.24 release - thanks for the advice!


Add a UI to check if a project name is allowed

What's the problem this feature will solve?
At the moment, the only way to register a project is to upload it. That's fine, but you need to choose a project name, and there is no way to know in advance if PyPI will reject that project name when you upload it.
Describe the solution you'd like
A UI and/or API that allows users to enter a project name and get a response saying whether it will be allowed, or if not, why not (the same sort of output as you get when trying to upload a new project).
Additional context
See https://discuss.python.org/t/how-can-i-request-a-package-to-be-added/15834 for a case where this occurred.
It is, of course, possible to create and upload an empty package, just to reserve the name. But do we really want to encourage people to upload junk packages? It's too easy (at least, it is if you're me!) to start a project, and get distracted and never actually get it to a releasable state.
One downside is that just because a name was allowable one day, doesn't mean it will still be allowable a week later when the project is ready for upload. We could implement some sort of "reservation" of names for a short period, but I believe this is overkill, and the simpler approach of just allowing people to check (maybe giving a warning saying that the check doesn't guarantee that the name will remain available) is perfectly adequate for the majority of cases.

Thanks for the issue. I think this is a duplicate of https://github.com/pypa/warehouse/issues/2082 but I'll let you decide.

Reserving names would make this feature unnecessary, but I would find this useful while reserving names is not possible. I don't know what the likely timescale on a name reservation feature is, or whether this is simple enough to be worth considering as a short-term approach.
One thing that is particularly annoying, though, is that it's currently not possible to be sure you're not going to trigger the "too similar to another package" check. Is the algorithm used to check similarity documented anywhere? If it is, then it would be possible to write a tool that did the check independently, and that would solve the short term problem without a warehouse change.

Is the algorithm used to check similarity documented anywhere?

The name collision algorithm is currently a Postgres function that is run as a step of a package upload.

OK, so a personal script that takes the simple index, ultranormalizes everything, and to check a name ultranormalizes it and reports "OK" or "Clashes with [list of stuff that normalizes the same]" seems like the best idea for now. If others want to do something similar, they can find this issue and either upvote it if they want something "official", or make their own script along the lines I described here.
That sounds reasonable to me. Feel free to close this issue if you want. Thanks for the help.


/bin/sh: yarn: command not found

Tnx a lot for this awesome project. I don't have yarn installed on my PC and I get this error /bin/sh: yarn: command not found Can you handle this situation gracefully? (by using npm if yarn is not presented)

Hi there! I do tell people that Yarn is a requirement for the project, it's in the documentation and the in the readme. You could run npm i -g yarn if you'd like to add it. I tried it both ways and the yarn install is much faster and cleaner so I would like to head in that direction.
I'm going to close this out for now but I am open to changing my mind on it if it's bothering a lot of people. :)

@sdras I had a lot of problems with yarn, so now I try to avoid using it. Anyway, thanks again for this awesome project! For now I will install dependencies manually, by typing npm install in project folder :)


Phantom bottom row with TiledMap

Hello! I'm using TiledMap with OrthogonalTiledMapRenderer in a randomly generated, chunked world.
Since the world can be big and multiple chunks can be on screen, I keep streaming chunks in and out. Each chunk has it's own TiledMap and OrthogonalTiledMapRenderer. When a chunk is streamed out and therefore no longer, it's tiled map and chunk renderer are disposed and forgotten. (If the the only problem with this streaming and disposing approach is performance, then this is an optimization postponed to a later stage during development)
The world is rendered with y-up. The TiledMaps themselves are offsetted with setOffsetX and setOffsetY such that they can be rendered next to each other. The thing here is that the value for setOffsetY is always negative, since looking at the source code, it seems that offsetY is negated before being applied.
The TiledMap is created programmatically as follows:
private val tiledMap: TiledMap = TiledMap()
private val renderer: OrthogonalTiledMapRenderer = OrthogonalTiledMapRenderer(tiledMap, batch)

init {
	val layer = TiledMapTileLayer(
			chunk.cells.width,
			chunk.cells.height,
			PIXELS_PER_CHUNK_CELL,
			PIXELS_PER_CHUNK_CELL
	)
	chunk.cells.forEachIndexed { x, y, chunkCell ->
		val cell = Cell().apply {
			tile = StaticTiledMapTile(getTextureRegion(chunkCell.groundTextureIdentifier))
		}
		layer.setCell(x, y, cell)
	}
	val worldInfo = serverInfoProvider.serverInfo.worldInfo
	layer.offsetX = (worldInfo.minChunkWidth * chunk.x * PIXELS_PER_CHUNK_CELL).toFloat()
	// The TiledMapRenderer used y-down
	layer.offsetY = -(worldInfo.minChunkHeight * chunk.y * PIXELS_PER_CHUNK_CELL).toFloat()
	tiledMap.layers.add(layer)
}

The batch passed to the OrthogonalTiledMapRenderer is also not yet used anywhere else.
Apart from this setup, I'm not doing much else except the following during the render step:
renderer.setView(camera)
renderer.render()

So far, so good, everything is rendering as expected - with one annoying exception:
Between chunks, there seems to be a phantom row at the bottom of each chunk that either appears between the chunks or just at the bottom of the screen, where it keeps bumping up or down if the screen is moved. When it's "following the bottom of the screen, it replaces the expected bottom row. However, when it is between chunks, it seems to actually be an additional row, instead of overwritting any of the expected rows.
Here is an example of what is happening. You can see the row of flowers in the middle as well the row of flowers at the bottom. They are really not supposed to be there like this.
https://imgur.com/a/U1YmOTy
Does anybody have a clue of what might be the problem? Did I make a mistake with the setup? Or is this a bug?
Kind regards and thanks in advance!
Version of LibGDX and/or relevant dependencies

1.9.10
Kotlin?

Please select the affected platforms

[ ] Android
[ ] iOS (robovm)
[ ] iOS (MOE)
[ ] HTML/GWT
[x] Windows
[ ] Linux
[ ] MacOS

Nevermind, misconfigured the texture regions. They were configured as 32x32 in size instead of 16x16.


Andre kilde-språk

Jeg savner muligheten til å velge et annet språk enn engelsk som kildespråk (det er lettere å oversette fra bokmål til svensk enn fra engelsk).

Good idea, but the problem is that there is a much smaller pool of Norwegian stories at the moment, so you would only be able to work with the 16 or so stories that have been translated already. It would be much easier to make versions for translating from Afrikaans (244 stories), Kiswahili (126), isiZulu (109), French (103), or Luganda (103), which are the top languages with the most stories in ASP at the moment.
As the number of translated stories in Global-ASP grows, it will make much more sense to incorporate this as part of the translation system. For now, you can still translate directly from Norwegian to Swedish using the .md files in the Global-ASP repo. :smile:

Closing this issue since there has been a Global-ASP oversetter på norsk available for some time now.


Fix: Speed up autocomplete

Overview
Fixes #2005
Demo
Optional. Screenshots, curl examples, etc.
Notes
A debounce function has been added that allows you to type, and fetches suggestions 200 milliseconds after you've stopped typing
Testing Instructions

How to test this PR
Check out this branch
Type queries on the query textbox
Notice that you can type and delete queries without the UI hanging

The autocomplete suggestions are definitely faster and the suggestions feel more intuitive.
However in the case where I type in a string such as 'cale'

I notice suggestions that don't exactly match my string but rather substrings of my string.
As you scroll further down the list the suggestions are anything that have a 'c', 'a', 'l', 'e'
Not sure if this is the intended design. I would think that by the time I have typed out a 4-letter string... the suggestions list would only include items that include the 4-letter string in that order...
Please share you thoughts on this with me

The autocomplete suggestions are definitely faster and the suggestions feel more intuitive.
However in the case where I type in a string such as 'cale'
I notice suggestions that don't exactly match my string but rather substrings of my string. As you scroll further down the list the suggestions are anything that have a 'c', 'a', 'l', 'e' Not sure if this is the intended design. I would think that by the time I have typed out a 4-letter string... the suggestions list would only include items that include the 4-letter string in that order...
I would appreciate your thoughts on this

Thank you for this @ElinorW. We have had received a lot of feedback, and most people prefer seeing suggestions related to their search text. So we have updated this to only show you startsWith and includdes suggestions

@Onokaev  Let's remember to remove the check for whether the search text matches the suggestions provided so that we give the user a chance to dismiss the suggestions themselves


Add rule for checking if keyword name contains underscores

Closes #150

Codecov Report

Merging #179 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   98.75%   98.75%
=======================================
  Files          31       31
  Lines        1929     1932    +3
=======================================
+ Hits         1905     1908    +3
  Misses         24       24

Impacted Files
Coverage Δ

robocop/checkers/naming.py
99.28% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c858f16...a18f53b. Read the comment docs.


srlinux 23.10 and macvlan

macvlan interface on srl side seems to be in the down state
https://discord.com/channels/854262008589058058/854262008589058061/1204796952475344906
we need to check

had partial success by making sure MTUs match (Partial - ie tcpdump shows traffic, ipv6 RA gets through, arp resolution happens, but no unicast forwarding)

will close this to see if it resurfaces with more recent srl versions


FAB Buttons Off Center (again)

I'm still experiencing this bug using the PopAnimation as seen in Issue #55. I have the button on iPad on the left side on the screen.

I am also facing the same issue.

Closing too old issue.


Nuget packages

This is #384 with changes to see if what I think will fix it actually will.

LGTM (@dsplaisted's parts)


feat(tools): kzip merge can optional read input files from file

This is more efficient than extending merge to also merge in the contents of the existing output file, which would be required for kzip to work in general with xargs (which currently is very dependent on ensuring both -n and -s are set correctly to ensure exactly one invocation of kzip).
More explicitly, we currently do
find bazel-out/stuff -name '*.kzip' | xargs -r kzip merge --output-file output.kzip
but that fails when the cardinality (in input file count or input file path lengths) is too large. We could choose a -n and -s argument to xargs that covered "most".  A more general change would be to have kzip merge merge in the contents of the existing output file, if any. That would be a more intrusive change. This PR simply gives kzip merge the same functionality as xargs if no input files are specified.

Obsoleted by #3679


llvmPackages_14.{mlir,flang}: init

Description of changes
Add packages for MLIR and Flang.
MLIR: https://mlir.llvm.org/
Flang: https://flang.llvm.org/docs/
Mostly came for packaging MLIR, but flang is nice to have and helps
check that the produced MLIR package is functional.
Note that (for now) using flang to produce binaries requires gfortran
available as well.
Editor bits for MLIR are installed as well as mlir-lsp-server.
Includes some of the runners for MLIR which are at least neat and while don't
significantly increase closure size, might be a liability should this
end up a dependency of something lighter (size or portability).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Put these in 'tools' since while MLIR is largely a library here, it's not a runtime library like the others.

As for installing MLIR tools:

Use LLVM_{BUILD,INSTALL}_TOOLS instead of LLVM_{BUILD,INSTALL}_UTILS to generate the build / installation targets.  This helps but doesn't work as errors are produced attempting to install the tools into ${llvm.out}/bin.
MLIR uses add_llvm_tool in cmake which is defined in AddLLVM.cmake and sets the destination to LLVM_TOOLS_INSTALL_DIR.  For building LLVM this is fine (as it's llvm.out) but causes problems for any downstream consumers of that cmake code.  Which grep'ing llvm-project mono-repo suggests it's mostly MLIR doing this presently (and maybe other out-of-tree projects).
Flang manages to avoid this (while another MLIR-based project I'm trying has issues) by using their own add_flang_tool cmake method, although offhand would suspect this isn't the only reason for this construction/effort.

Idea 1: Current approach: manually enumerate, explicitly build, and install the various utilities (and possibly have issues in other MLIR projects or in the future)
Idea 2: Patch llvm's cmake to let users of add_llvm_tool install to their /own/ installation directories?
Idea 3: Patch (and attempt to upstream) in a new add_mlir_tool or similar, mostly copying add_llvm_tool for our purposes (as seems often done-- add_${project}_tool definitions exist in many LLVM projects.

(rebasing+force-pushing for LLVM 14 release)

I tried to use MLIR at $dayjob, but found the way llvmPackages does multi-derivation and multi-output to cause too much trouble. I ended up making a simple LLVM "monobuild" expression which has working MLIR cmake files:
# Build a full LLVM in one derivation with one output -- in contrast to nixpkgs
# llvmPackages which splits the package into multiple derivations (and multiple
# outputs).
#
# Pros:
# * Easier to match upstream builds / make MLIR CMake files work.
# * No patching required.
#
# Cons:
# * Slower to build / iterate on.
# * Larger closure sizes.
# * Not useable as stdenv component as $CC etc. doesn't get wrapped.

{ lib, stdenv, fetchFromGitHub, cmake, python3, ncurses, zlib, libffi, libxml2 }:

stdenv.mkDerivation rec {
  pname = "llvm";
  version = "15.0.0";

  src = fetchFromGitHub {
    owner = "llvm";
    repo = "llvm-project";
    rev = "llvmorg-${version}";
    sha256 = "sha256-4yviNtiJJLE6JPNqwPwRBk9fZ9vXqsVIaNOucrePmy8=";
  };

  nativeBuildInputs = [
    cmake python3
  ];

  buildInputs = [
    libffi
    libxml2
  ];

  propagatedBuildInputs = [
    ncurses
    zlib
  ];

  sourceRoot = "source/llvm";

  cmakeFlags = [
    "-DLLVM_ENABLE_PROJECTS=mlir"
    "-DLLVM_ENABLE_RTTI=ON"
  ];

  requiredSystemFeatures = [ "big-parallel" ];

  meta = {
    description = "A collection of modular and reusable compiler and toolchain technologies";
    homepage = "https://llvm.org/";
    license = lib.licenses.ncsa;
  };
}

Given that Triton (https://github.com/openai/triton) needs MLIR and Torch 2.0 will make use of Triton for its torch.compile feature, this would be wonderful to have. I'm trying to package MLIR myself and just found this PR. I'll take a look at it tomorrow to see what I can do with it.
@rrbutani any thoughts from your recent updates to llvmPackages? I notice that the rocm folder provides a derivation to build MLIR -- it would be nice to have the ability to build the main derivation with CUDA support.

@ConnorBaker Thanks for the heads-up about rocm; I missed that they're building mlir now.

I've got an mlir package (that builds on @dtzWill's work here) for LLVM 15 here that I've been meaning to clean up and contribute to nixpkgs. I think I got it to the point where the libraries and the MLIR python bindings work and the docs build (and IIRC I ended up finding workarounds for some of the pain points this PR ran into) but it still needs work for CUDA support and I don't think I got all the tests to pass.

re: Triton: do you happen to know what their plan is for the version of LLVM/MLIR they will require? I'm not familiar with Triton (and I couldn't find an answer after quickly glancing at their repo; they make reference to LLVM 11 and their CMake scripts seem to accept any LLVM version 6.0+) but other projects I've worked with that use MLIR tend to track upstream very closely and generally don't seem to line up their releases with LLVM/MLIR releases.

@rrbutani They're working their way towards using HEAD; they have a PR open to use LLVM 15 here: https://github.com/openai/triton/pull/1070. Both their internal team and the team at Meta want to track HEAD more closely.
I didn't notice that they switched to using their own distribution; that's new!
I've been wallowing in Dockerfiles the past month or two building Magma, PyTorch, TorchVision, and Triton from source. Eventually I broke and have been trying to package it with Nix since. Please let me know if there's anything I can do to help get MLIR with CUDA support in Nixpkgs. I don't want to go back to docker :(

Hi! Is there a reason to target only one llvm version?
I'm currently using mlir from llvmPackages_rocm (effectively llvm15?) for pytorch 2.0, but I understand that the situation is likely to start changing pretty fast

Following on the previous ping, @dtzWill what are your plans wrt this? Do you plan to look into this again, do you need any help to push this further and get it merged, or should we mark this closed for now?
CC @NixOS/rocm-maintainers can you help assessing the situation? How does this interact with rocmPackages.llvm.mlir, etc.

Related: #280572


Bug fixes around default base types

Fixed the generic instantiate issue - will now attempt to create an appropriate base class for it
For methods that used to require an object, these will now (mostly) accept a URI. If the tool already knows this URI (i.e. it's in the instance cache) it will use the object. If it's an unknown URI string, a reference python object will be created with the most appropriate base class.

Noted that some of the documentation was based on the old ies_lib library rather than IES Tool. Have updated.

I'm running run_test.sh and get the following error:
andreascola@admins-MacBook-Pro ies-tool % ./run_test.sh
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/andreascola/Documents/Code/ies-tool/test/test.py", line 5, in <module>
    from ies_tool.ies_tool import IES_TOOL, Communication, Element, Entity, Event, GeoPoint, IESTool, Organisation, Person
  File "/Users/andreascola/Documents/Code/ies-tool/ies_tool/ies_tool.py", line 13, in <module>
    import iso4217parse
ModuleNotFoundError: No module named 'iso4217parse'


Resources

Just Added..

Just Added..

Add as a .md file.

Just Added..

Add as a .md file.

Done


Failed to extract node metadata: json: cannot unmarshal string into Go struct field BootstrapNodeMetadata2.POD_PORTS of type []model.PodPort

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
workloadgroup has port，makes this bug。
Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
Steps to reproduce the bug
apiVersion: networking.istio.io/v1alpha3
kind: WorkloadGroup
metadata:
  name: httpd
  namespace: vm-httpd
spec:
  metadata:
    labels:
      app: httpd
      type: vm
  template:
    ports:
      http: 80
    serviceAccount: sa-httpd
    network: ""

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
[root@master01 workloadgroups]# istioctl version --remote
client version: 1.10.0-rc.1
control plane version: 1.10.0-rc.1
data plane version: 1.10.0-rc.1 (3 proxies)
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

@13567436138 are you trying to add services running in a VM to the mesh?

@13567436138 see #33225 for a possible workaround

yes,vm,workloadgroup has ports,so error


[nix] Rematerialize GHC9 in the CI

Updated the Update/ Nix CI script to re-materialize both the current GHC8.10.* and the GHC9 expressions in the nix/ folder.

Changesets of the kore.nix files are a bit hard to read because of the different layout, but all makes sense.
Besides maintaining the nix/rematerialize.sh script, LGTM

Yeah sorry about that. I added a step where I run nixfmt on the generated file because for some bizzare reason, running the rematerialize on my local machine and the ci produced files with different formatting. This way we make doubly sure we only trigger the update if the contents actually change


OPENSSL_cpuid_setup FreeBSD arm update.

when possible using the getauxval equivalent which has similar ids as Linux, instead of bad instructions catch approach.

I will speculatively add the 1.1.1 label, though it is pretty borderline whether it qualifies.
The argument mostly being that having the library install a signal handler is a bug in its own right, just one that happens to be the least-bad option in some cases.

This pull request is ready to merge

This pull request is ready to merge

Pushed. Thanks.

Pushed. Thanks.


WebApp with WebJob deployment failing to delete jobs directory on alternate builds

Hi
This issue started a few months ago (possibly even tail end of last year) and I've seen others with similar issues but no posting as to why this suddenly started happening. The specific error is:
Error: An error was encountered when processing operation 'Delete Directory' on 'D:\home\site\wwwroot\app_data\jobs'.
I've read numerous threads and the most recent suggested stopping the webjob first so in my VSTS build I now do just that with:
Stop-AzureWebsiteJob -Name myname -JobName myjob
Write-Host "Stopping myjob"
Start-Sleep -s 30

This does what it's meant to and stops the webjob but I still get the above error every other build, if I hit queue new build the second time it works without fail.
I have Remove Additional Files at Destination enabled for the WebApp which is deployed first then don't have it enabled for the WebJob.
Any help appreciated.
Cheers
Si

@TheFairey, Is Application Insight Extension  (or Webjob) present in your Azure App Service ?
If so, Can you please stop the Webjob and requeue the release ?
You can use the script provided here to achieve the same.
Please feel free to ping, if you face any issue.

@vincentdass I used that link you provided originally but the stop script didn't work and kept asking to run AzureLogin so I replaced it with the stop script I included in my original post. This does stop the webjob but I still get the issue even adding a 30s instead of 15s delay. The application Insights Extension is included in my App Service. I will tried adding in this step:
Stop Azure App Service - Azure App Service Manage Task
which is the one I don't have from that link and the corresponding start but I'm still getting the same error when it tries to delete the jobs directory

@TheFairey , Did u use Azure PowerShell Task to run the scripts ?
Application Insights will be running as a Webjob, which need to be stopped before deployment.
Can you please try the scripts with Azure Powershell task to check once ?

@vincentdass
Ok so tried with Classic connection type and got the login request then tried with Azure Resource Manger connection type and that worked once I updated the scripts to use the versions that don't look for a slot so thanks for your help.

@TheFairey , is the issue resolved with the provided script ?

@vincentdass with a slight change because I have no slots but yes the issue is resolved.

@TheFairey We are experiencing the same issue - doing ARM MsDeploy via VSTS to stopped staging slot we encounter an error, when App_data\jobs, despite being empty, could not be deleted.
As you can see in related issue - we also tried to use script to add app setting - still, not avail. Can you please, help?

@akuryan Not sure how I can help, the issue for us was the hidden app insights webjob mentioned in the related threads so when I use the PowerShell script to stop all webjobs prior to performing the release everything deploys without an issue. Sorry!

@akuryan , Can you share the steps how you confirmed App_Data/Jobs folder is empty?

@vincentdass After build failed I used FTP to login to staging slot and check App_data/jobs content

This issue has started happening again, after a failed deployment the next deployment works.
I put a powershell delay in after the powershell that stops the jobs and the stop web app step. During the delay I can see there is only one w3wp process running, the scm site however if I look in the open_file_handles I can see the scm site has open filehandle into the app_data...continuous directory.
After the failed deployment if I go and look again the file handle on the continuous directory it's gone. I had hoped the 5 min delay step might give whatever it is time to remove the open file handle but I guess not.
Open to suggestions as to why the SCM site has this open file handle and how I can clear it, is there a way to force a restart of the SCM site as part of the VSTS tasks?
I found this link but not sure how I might do it during a VSTS deployment?

@TheFairey , As the issue is related to Azure App Service, Can you please open a issue here.
Also, stopping the SCM site is not recommended from VSTS, as VSTS primarily depends on SCM for deployment.

FYI - With no change my end this magically started working again, by working I mean no more double releases required so I'm guessing someone somewhere fixed something in the deployment process.


Fixes shoot care controller panic

Co-authored-by: Zanetworker<EMAIL_ADDRESS>What this PR does / why we need it:
This PR fixes a panic in the shoot care controller which especially happened if the controller ran into retry conflicts.
goroutine 4070634 [running]:
github.com/gardener/gardener/pkg/controllermanager/controller/shoot.(*defaultCareControl).updateShootConditions(0xc0028e6780, 0x0, 0xc015f741c0, 0x4, 0x4, 0xc02dfbf2a0, 0xb, 0x0)
    /go/src/github.com/gardener/gardener/pkg/controllermanager/controller/shoot/shoot_care_control.go:222 +0xaf
github.com/gardener/gardener/pkg/controllermanager/controller/shoot.(*defaultCareControl).Care.func1(0x1c41380, 0xc000044030, 0x0, 0xc0486c1a40)
    /go/src/github.com/gardener/gardener/pkg/controllermanager/controller/shoot/shoot_care_control.go:180 +0x4a0
github.com/gardener/gardener/pkg/utils/flow.Parallel.func1.1(0xc0680f9890, 0xc0032d3500, 0xc04e714910, 0x1c41380, 0xc000044030)
    /go/src/github.com/gardener/gardener/pkg/utils/flow/taskfn.go:153 +0x77
created by github.com/gardener/gardener/pkg/utils/flow.Parallel.func1
    /go/src/github.com/gardener/gardener/pkg/utils/flow/taskfn.go:151 +0x104

Release note:

An issue in the shoot care controller has been fixed which caused the Gardener-Controller-Manager to crash.

Thanks for fixing this, guys!


"Course doesn't exist" error when trying to add teacher

For now, I've added him via Auth0.

Is this still happening?

This issue even worse now - @fdodino has reported that a Sinatra::NotFound error is being raised.

Closed via https://github.com/mumuki/mumuki-classroom/commits/70e86bfffd8c6c4b709ef84bff26f6fb7c0ffec9

Closed via https://github.com/mumuki/mumuki-classroom/commits/70e86bfffd8c6c4b709ef84bff26f6fb7c0ffec9

This commit does not exist :open_mouth:


How to pass multiple cucumber tags to run multiple BDD scenarios

I am using this framework but can only pass 1 tag as "-t @myTag1" in a test. I am looking to pass multiple tags "-t @myTag1,@myTag2,....." Is this possible?

My bad, I can use @myTag1 or @myTag2


[SPARK-13495][SQL] Add Null Filters in the query plan for Filters/Joins based on their data constraints

What changes were proposed in this pull request?
This PR adds an optimizer rule to eliminate reading (unnecessary) NULL values if they are not required for correctness by inserting isNotNull filters is the query plan. These filters are currently inserted beneath existing Filter and Join operators and are inferred based on their data constraints.
Note: While this optimization is applicable to all types of join, it primarily benefits Inner and LeftSemi joins.
How was this patch tested?

Added a new NullFilteringSuite that tests for IsNotNull filters in the query plan for joins and filters. Also, tests interaction with the CombineFilters optimizer rules.
Test generated ExpressionTrees via OrcFilterSuite
Test filter source pushdown logic via SimpleTextHadoopFsRelationSuite

cc @yhuai @nongli

Test build #51980 has started for PR 11372 at commit 06d74da.

Test build #51980 has finished for PR 11372 at commit 06d74da.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51980/
Test FAILed.

Test build #51994 has started for PR 11372 at commit 2345075.

Test build #51994 has finished for PR 11372 at commit 2345075.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51994/
Test FAILed.

Test build #52338 has started for PR 11372 at commit 28050b3.

Test build #52338 has finished for PR 11372 at commit 28050b3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class PlanTest extends SparkFunSuite with PredicateHelper

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52338/
Test FAILed.

Merged build finished. Test FAILed.

Test build #52383 has started for PR 11372 at commit 2a469e8.

Test build #52383 has finished for PR 11372 at commit 2a469e8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52383/
Test FAILed.

Test build #52406 has started for PR 11372 at commit 80dab7e.

Test build #52406 has finished for PR 11372 at commit 80dab7e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52406/
Test FAILed.

Test build #52416 has started for PR 11372 at commit 013f97a.

Test build #52416 has finished for PR 11372 at commit 013f97a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52416/
Test FAILed.

test this please

Test build #52431 has started for PR 11372 at commit 013f97a.

Test build #52431 has finished for PR 11372 at commit 013f97a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52431/
Test PASSed.

Merged build finished. Test PASSed.

Test build #52494 has started for PR 11372 at commit 31b1700.

Thanks @nongli, all comments addressed.

Test build #52494 has finished for PR 11372 at commit 31b1700.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52494/
Test PASSed.

LGTM


chore(master): release butler 12.4.2

:robot: I have created a release beep boop
12.4.2 (2024-07-03)
Bug Fixes

host-info: Correctly handle cases where there is no MAC addr available (3aa250e), closes #1183

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ptarmiganlabs/butler/releases/tag/untagged-c08d8894c4aad6e309c2 :sunflower:


Blocks: Consider improving experience for editing selected stories

Feature Description
For the "Selected Stories" use case it's a bit unexpected that the CTA to update the selected stories is at the bottom of the block:

Depending on the number of stories, this won't be visible without scrolling.
I know this works the same as in the gallery block, but it doesn't seem ideal.
Perhaps we could instead add a pencil icon to the block toolbar or something?
Alternatives Considered

Additional Context
Here's how Gutenberg allows editing and reordering individual images in a gallery block:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Closing as this has changed quite a bit since then


Dragging files in window not working

every time i try to make a new map, putting in the audio file doesn't work
i'll provide more information if necessary
os: linux (specifically elementary os 6.1 jólnir)
https://user-images.githubusercontent.com/79671269/148424200-270dd09a-b996-48bb-8a71-1d4599648f9a.mp4

Hello, assuming you run Steam in a Flatpak, here's what you need to do:

Install Flatseal

In Flatseal, find Steam and add this:

Restart Steam

Now you can drag-and-drop anything from your Downloads folder (and only from the Downloads folder because that's what xdg-download is)


Received/Performance Dashboards - Public Bodies to Remove

Title of ticket: Received/Performance Dashboards - Public Bodies to Remove
Description
Received/Performance dashboards are meant to measure "Core government's" statistics - namely Ministries and Central Agencies within. IAO has special contracts with select public bodies, that are currently appearing in the dashboard, which should be removed from these specific dashboards. There will likely be a requirement to have a separate dashboard for these public bodies in the future.
Dependencies
n/a
DOD

[x] RECEIVED Dashboard (all) Remove the following public bodies from the reporting data:  TIC (Transportation Investment Corp)
[x] PERFORMANCE Dashboard (all) Remove the following public bodies from the reporting data (Transportation Investment Corp)

No longer seeing TIC - closing as complete


Update repo structure description, fix links

Signed-off-by: Mark Moir<EMAIL_ADDRESS>

I self-approve!


Add streamlined _ensure_arraylike utility

Over time we've landed on the following pattern for user-facing APIs in jax.numpy, jax.scipy, jax.random, etc.:
import jax.numpy as jnp
from jax._src.numpy.util import _check_arraylike
from jax.typing import ArrayLike
from jax import Array

def func(x: ArrayLike, ...) -> Array:
  _check_arraylike("func", x)  # this is essentially a runtime check of isinstance(x, ArrayLike)
  x = jnp.asarray(x)  # this actually converts x to Array so that, e.g. it can be passed to lax functions
  # do some computation with x
  return out

There are a couple improvements we could make here:

We essentially never want to call _check_arraylike without following with jnp.asarray on the inputs. Whe should combine these into a single utility! This would prevent failures like the one reported in #14906.
jnp.asarray is a pretty heavy function; if we know that an input passes _check_arraylike, we can convert to an array much more efficiently.
This unified utility might also handle the stackable checks that are currently in numpy, via an extra keyword like allow_stackable=True. Also perhaps incorporate check_no_float0s via allow_float0s=False.
_check_arraylike lives in jax._src.numpy.util, but it is far more generally applicable. It should probably live in jax._util, or perhaps even be a public utility so that we can recommend this pattern for downstream APIs (e.g. here: https://jax.readthedocs.io/en/latest/jax.typing.html#jax-typing-best-practices)

@jakevdp Thanks for investigating this!
Wow, I didn't know the existence of this (jax.readthedocs.io/en/latest/jax.typing.html#jax-typing-best-practices). It's such a nature place where all the array API related (type checking, dtype checking, dtype promotion, staticness, etc.) tools can go. Do you think we could open an umbrella issue to track the inception of such a set of tools?

That doc is only a week or two old. #12049 is a relevant tracking issue


Query Param - failed

I am able to view the image without and param's but a soon as I add any I get a server error
I thought it might of had something to do with the image being in subfolders but I tried one from the root folder with the same issues.
I get the following error on the server.
Execution failed due to configuration error: Malformed Lambda proxy response
and to verify yes I have added binary support.
thx,

hey @Wade-BuildOtto, do you have an example URL you can share so I can see the query params you're using? So you don't share it publicly, don't send your beginning of your api gateway url.

here are some examples
execute-api.us-east-1.amazonaws.com/dev/apple-badge-155x60.png?w=100
execute-api.us-east-1.amazonaws.com/dev/JYt4tm2rmv/pfTPGgYGbE/images/uFL_Maxim-24-M.png?h=200

any thoughts?

I am really hoping to use this package, but I can't find what I am doing wrong.

Hey could you share some of the lambda logs?

Also both those urls fail with and without query parameter? Could you share another link that works without the query params

@wade-buildotto

here is the url link without query params
https://zohivcpzv1.execute-api.us-east-1.amazonaws.com/dev/JYt4tm2rmv/pfTPGgYGbE/images/uFL_Maxim-24-M.png

I have this issue too I'm afraid.  also, Cloudwatch doesn't seem to be getting configured so it's a bit difficult to try to problem solve.

@Wade-BuildOtto @zagreusinoz I've recreated the issue and am looking into it. Something with Cloudwatch change such that the logs are not automatically generated anymore. This should get those logs setup https://serverless-stack.com/chapters/api-gateway-and-lambda-logs.html

seeing this error in my API gateway logs
Execution failed due to configuration error: Malformed Lambda proxy response

working on getting logging setup in the lambdas

Thanks Marcus - in the meantime the pull request I gave actually solves the original 500 error problem (for me anyway)

tested @zagreusinoz's PR and that definitely fixed the issue here. @Wade-BuildOtto if you want to confirm that the latest origin/master fixes this for you I can do another release.

yeah that fixed it, thank you
yeah!!! :-)


Missing Contributing.md file

Description:
The repository is missing a CONTRIBUTING.md file, which is essential for guiding contributors on how to properly contribute to the project. This file typically outlines important guidelines, such as how to report issues, create pull requests, code style conventions, and other contribution practices.
Tasks:

[ ] Create a CONTRIBUTING.md file.
[ ] Include sections for:

Contribution guidelines (pull requests, issues, feature requests).
Code style and formatting rules.
Branching and commit message conventions.
Testing requirements before submitting code.
How to set up the development environment (if needed).
Any other project-specific instructions.

[ ] Review with the project maintainers and refine the guidelines.

Please @tushargupta1504 assign me this task with label "GSSOC-Ext" , "Hacktoberfest-accepted" and "level1".

Please @tushargupta1504 assign the label "level1" or else my contribution will not be counted


JBPM-4303 - using a singleton EventListener instead of empty implementations

@mswiderski Could you look at this?
I talked with @krisv about this last night: it's a minor change that, even in the current implementations, is a little more readable (and faster, I believe, not that that matters really).
It also helps me with the stackless work, which is my main reason for adding it.
Thanks!
The changes can be seen here. In short:

Remove empty implementations
Add a singleton/constant "empty event listener" impl that can be used instead

Apologies for the space changes.. :/

if it does not have any side effects (which I cannot find any) it's fine with me. just one tiny comment about relationship between node and workflowprocessimpl

two test cases ...NoIO fails after move to 8 as it seems it revealed an issues with not clearing parser state between processes, fixed in here https://github.com/mswiderski/jbpm/commit/9ba4411300fddff432073c09e6f4e4786c96f20a
the other one seems to be intermittent failure

Jenkins, please retest.

@mswiderski Updated so that it's in a different class.

excellent, that's exactly what I had in mind. thank you! once the build is over I'll merge it

@mrietveld looks like #389 caused conflicts here. I tried to resolve them but there were quite few so if you don't mind rebase with master so I could merge this one... that would be great

Rebased. (retesting just to be sure).
Jenkins, please retest.

@mrietveld thanks
P.S.
if you amend the commit, or add anything to it, jenkins rebuilds automatically, no need to as it :)


Investigate Port Discovery Options

If we can avoid sending the port number over the command line to LabVIEW we can remove the limitation of having to launch LabVIEW and we should be able to run with LabVIEW already open.
We would need someway of registering a port though and it needs to be dynamic because as soon as we support this users will want to run multiple instances at the same time. I don't know if such a thing exists.
We would also have to be prepared that a lot more could go wrong on the LabVIEW side. What if we launch a VI that is already open? How do we feed this back to the user?
I think this maybe a no-go but it is worth exploring options.

It is definitely worth exploring, especially if build process contains multiple small lv tools, then waiting for lv to launch before each execution is very inefficient.
We could use NI Service Locator to register CLI, then in Start CLI Interface you could just use service name to open proper tcp connection, however this will only work for single instance.

One idea I had is if you could use something like service discovery but based on the VI name. That way you probably wont launch multiple instances of the same VI (or if you do it doesn't matter which instance of the CLI they connect to).
This is something I would need to investigate the technology though as I'm not too familiar with it at the minute.

NI service Locator could be used for that also, just register with VI as service name. I am only not sure how this could be done from C# app but I probably also via TCP. NI service locator

this is the publish get request for VI name "test1 test2" on port 5007
http://localhost:3580/publish?test1%20test2=HTTP%2f1.0%20200%20OK%0d%0aServer%3a%20Service%20Locator%0d%0aPragma%3a%20no-cache%0d%0aConnection%3a%20Close%0d%0aContent-Length%3a%2011%0d%0aContent-Type%3a%20text%2fhtml%0d%0a%0d%0aPort%3d5007%0d%0a
you can check if this is registered properly on:
http://localhost:3580/dumpinfo?
and for unregister:
http://localhost:3580/delete?test1%20test2
so C# app should be extended to send proper web request if labview is already running, then in Start CLI Interface.vi you could use Open TCP connection with VI name as service name.

This looks great! thanks for the notes. We would still have to deal with name collisions as a potential but I think an approach like this could work.

By name collisions you mean same multiple instances of the same VI or different VI but with the same name?
In case of multiple instances whole launching process should be changed. Probably we need to use VI server to run VI as clone.
In case of different VI but with the same name it should be easier, just use path or md5 with VI name.

The first case was my concern although I hadn't considered of course LabVIEW had to handle that as well. That could be worked around for now with a simple wait and retry on the c# side. Since it is only during launch it shouldn't block for long.
In fact you could simplify further by causing it to wait if any other launch is in progress. This way we don't need the VI name in there which will hugely simplify the client library

I can see one drawback with your solution that it won't work if someone really want to use it in prarallel. However since CLI in majority is used for triggering builds it should not be the case. We can stick with simple solution and in case of new change request for parallel execution this could be further developed.

@JamesMc86 are you planing to implement that wait and retry feature in C# code? Do you need help with that?

I'm pretty swamped on another project for a couple of weeks but I hope to look at it then.
I've realised one other minor problem with this scheme is actually getting the name of the launched VI from the LabVIEW library since it could be several layers deep in the application potentially, but I guess it could just be the top level? Would need to experiment with how it could be done robustly.

OK So I'm going to try and tackle this at last. My current concept is:
VIs
Of course you are right - we can't get VI collisions in one environment since I don't believe there is an option to launch as a clone directly. However there could be collisions since they will all be running in the top level application name space.
In this case we can add an entry in the following format "cli-lvver-lvbits-viname" i.e. "cli-2011-x86-run%20builder" (I think drop the VI extension).
To lower the bar, lets not worry about collisions so we get this step done and then we can look at collisions once this is working (still target for release version though). If the service locator allows it just putting the full (escaped) path would solve the issue for now.
EXEs
Since EXEs don't have the same issue I'm tempted to continue with the current method. Although I don't like splitting it, this method is likely to be so much simpler and faster I think that is worthwhile.

Got this working now in version-2 branch. Needs some build automation and tidying up before release as version 2.0


BigQuery _TABLE_SUFFIX support

Hi, In BigQuery, tables can be referenced by a wildcard:
select * from `dataset.table` where _TABLE_SUFFIX = 'suffix'

Docs
When analyzing a query, that references a wildcard table through _TABLE_SUFFIX, I get the error:
com.google.zetasql.SqlException: Unrecognized name: _TABLE_SUFFIX

Can I add support for this somehow?
Thanks

Example implementation:
https://github.com/Matts966/alphasql/blob/master/samples/sample-ci/python_entrypoint.py
https://github.com/Matts966/alphasql/blob/master/alphasql/json_schema_reader.h

Thanks @Matts966 , So if I understand your code correctly, you are adding the _TABLE_SUFFIX as a column to the table that you then add to your catalog. That allows me to analyze the query, do you know how I can get a reference to the referred table(s) behind the wildcard, for example in this statement:
select * from `dataset.table*` where _TABLE_SUFFIX = '20220101'

I want to be able to identify that the query hits the table dataset.table20220101 and similar if I were to specify a range in the table suffix. Do you know if this is possible to obtain?
Thanks

I feel it is difficult because string values can be modified dynamically, e.g. _TABLE_SUFFIX = a + b.
But you can obtain concrete values if it is static literal, by reading resolved AST.


how to configure hug application in PyCharm

Hi, I am new to python and I have tried to configure my hug application to use PyCharm for debugging, however I have not been able to determine the startup script that work with PyCharm .

Unfortunately with the way hug code is run (hug -f FILE) you have to attach the debugger to the process, first step would be making the run process more convenient, I suggest creating a new External Tool preset like this:

Makes it a bit simpler to get running, once its running you would then use the Run > Attach to local process feature. Keep in mind it apparently only works for Python 3.4.4 and older.

Thanks,
On Feb 22, 2017 9:20 AM, "Anthony Forsberg"<EMAIL_ADDRESS>wrote:

Unfortunately with the way hug code is run (hug -f FILE) you have to
attach the debugger to the process, first step would be making the run
process more convenient, I suggest creating a new External Tool preset like
this:
[image: hug]
https://cloud.githubusercontent.com/assets/1984403/23215308/e29d8a66-f8df-11e6-9a9b-0bbeb33970f7.PNG
Makes it a bit simpler to get running, once its running you would then use
the Run > Attach to local process feature. Keep in mind it apparently only
works for Python 3.4.4 and older.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/timothycrosley/hug/issues/460#issuecomment-281681689,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALRjVfY3ib03lSXIeqNy4C7BQLi_GOycks5rfEQVgaJpZM4MHgIO
.

If it helps, this alternative approach also seems to behave like any other wsgi server for PyCharm, and happily handles debugging, code coverage etc. Setup is as simple as pointing PyCharm at this server. Can vouch for it on Python 3.5, 3.6:
https://github.com/timothycrosley/hug/issues/450#issuecomment-279685321

Closing this as it seems to have been satisfactorily answered. Thanks!
~Timothy

@davidhyman "Setup is as simple as pointing PyCharm at this server."
How do you do this? If the comment you've linked to is related, I'm not following it.

FWIW here's what I ended up doing to run/debug from PyCharm:
from werkzeug.serving import run_simple

import api

def create_app():
    return api.__hug_wsgi__

app = create_app()

if __name__ == '__main__':
    run_simple('<IP_ADDRESS>', 5000, app, use_reloader=True, use_debugger=True, threaded=True)


Change colorbar number format

Hello,
Looking at the documentation I wasn't sure how to change the string format on the colorbar, or is this even possible? I would like it to be more consistent. Depending on the amount of significant figures you may get a float or scientific notation in the same colorbar.

It would be nice to have more control, such as show sign (+ and -) and control the significant figures after the decimal, e.g. +3.145e+00 and -3.145e+00. Again, I apologize if I have missed this option
Or is there a better way to export this for plotting?
Thanks in advance!
PS I believe glvis was installed through pip install glvis==0.3.3, which I think pulled in the latest binary 4.2

There is unfortunately no way currently to control this at user level.

Do you think it would be a desired feature? I may look into it trying to add it once I defend.

Do you think it would be a desired feature? I may look into it trying to add it once I defend.

Definitely!
If you can build GLVis yourself, the change is not hard -- the corresponding code is in the following lines:

https://github.com/GLVis/glvis/blob/master/lib/vsdata.cpp#L500
https://github.com/GLVis/glvis/blob/master/lib/vsdata.cpp#L512

and maybe you want a diff like:
diff --git a/lib/vsdata.cpp b/lib/vsdata.cpp
index 1934414..9e69eac 100644
--- a/lib/vsdata.cpp
+++ b/lib/vsdata.cpp
@@ -497,7 +497,7 @@ void VisualizationSceneScalarData::PrepareColorBar (double minval,
          val = ULogVal(i / 4.0);

          ostringstream buf;
-         buf << setprecision(4) << val;
+         buf << fixed << showpos << val;
          color_bar.addText(text_x,Y,posz, buf.str());
       }
    }
@@ -509,7 +509,7 @@ void VisualizationSceneScalarData::PrepareColorBar (double minval,
          Y = miny + (maxy - miny) * LogUVal(val);

          ostringstream buf;
-         buf << setprecision(4) << val;
+         buf << fixed << showpos << val;
          color_bar.addText(text_x,Y,posz, buf.str());
       }
    }

@ddkn, were you able to resolve this?

Discussion continued in #288


coverage increase for deployers

Description
add return variables to increase coverage

coverage: 93.275% (-0.09%) from 93.368%
when pulling 17105ab3d30ca5eb52a0baedabd0d09fd2853d3f on coverage-hacks
into abd8f923eebf35218213516a8fd00578b0733b50 on main.


experiment with zero roughness

I tryed to preprocess zero roughness.
If use MICROFACET_MIN_ROUGHNESS for smaller then MICROFACET_MIN_ROUGHNESS values
hvd_ggx_eval() return very small, near zero value.
I make some changes
https://github.com/nvpro-samples/nvpro_core/blob/2991ba62e3e800a7f416a4ea9ad2d10b86454b1a/nvvkhl/shaders/bsdf_functions.h#L525
to
  data.pdf = mat.roughness == MICROFACET_MIN_ROUGHNESS ? 0.0f : hvd_ggx_eval(1.0f / mat.roughness, h0) * G1;  // * prob;
I have interesting images. Is my approaches is correct?

original rendering w/o my changes

scene GlassHurricaneCandleHolder.glb
my changes

original rendering w/o my changes

scene GlassBrokenWindow.glb

one more idea.
I commented this line
https://github.com/nvpro-samples/nvpro_core/blob/2991ba62e3e800a7f416a4ea9ad2d10b86454b1a/nvvkhl/shaders/pbr_mat_eval.h#L108
and change
https://github.com/nvpro-samples/nvpro_core/blob/2991ba62e3e800a7f416a4ea9ad2d10b86454b1a/nvvkhl/shaders/ggx.h#L86
with
  float val = M_1_PI * invRoughness.x * invRoughness.y * h.z / (f * f);
  return isnan(val) ? 0.0f : val;

Results:

But textures is interesting. Where is come from these?

Sorry, can you be more specific?

I mean textures from my screenshot

small epsilon value (e.g., 0.0014142) as the minimum roughness to avoid these issues
why this value, not smaller?


Not able to deploy eks-addons. ingress-nginx not deploying.

Can anyone please help me here?
 I am not sure how to debug this.
Can someone help here?
~/observer/eks-addons$  kubectl get svc -n ingress-nginx

NAME                                 TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                      AGE
ingress-nginx-controller             LoadBalancer   <IP_ADDRESS>   <pending>     80:30064/TCP,443:30531/TCP   18m
ingress-nginx-controller-admission   ClusterIP      <IP_ADDRESS>   <none>        443/TCP                      18m
ingress-nginx-controller-metrics     ClusterIP      <IP_ADDRESS>   <none>        10254/TCP                    18m

terragrunt.hcl
include {
  path = "${find_in_parent_folders()}"
}

terraform {
  source = "github.com/particuleio/terraform-kubernetes-addons.git//modules/aws?ref=main"
}

dependency "eks" {
  config_path = "../eks"

  mock_outputs = {
    cluster_id              = "cluster-name"
    cluster_oidc_issuer_url = "https://oidc.eks.eu-west-3.amazonaws.com/id/0000000000000000"
  }
}

dependency "vpc" {
  config_path = "../vpc"

  mock_outputs = {
    private_subnets_cidr_blocks = [
      "<IP_ADDRESS>/16",
      "<IP_ADDRESS>/24"
    ]
  }
}

generate "provider" {
  path      = "provider.tf"
  if_exists = "overwrite"
  contents  = <<-EOF
    provider "aws" {
      region = "${local.aws_region}"
    }
    provider "kubectl" {
      host                   = data.aws_eks_cluster.cluster.endpoint
      cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
      token                  = data.aws_eks_cluster_auth.cluster.token
      load_config_file       = false
    }
    provider "kubernetes" {
      host                   = data.aws_eks_cluster.cluster.endpoint
      cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
      token                  = data.aws_eks_cluster_auth.cluster.token
    }
    provider "helm" {
      kubernetes {
        host                   = data.aws_eks_cluster.cluster.endpoint
        cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
        token                  = data.aws_eks_cluster_auth.cluster.token
      }
    }
    data "aws_eks_cluster" "cluster" {
      name = var.cluster-name
    }
    data "aws_eks_cluster_auth" "cluster" {
      name = var.cluster-name
    }
  EOF
}

locals {
  aws_region = yamldecode(file("${find_in_parent_folders("region_values.yaml")}"))["aws_region"]
  custom_tags = merge(
    yamldecode(file("${find_in_parent_folders("global_tags.yaml")}")),
    yamldecode(file("${find_in_parent_folders("env_tags.yaml")}"))
  )
  default_domain_name   = yamldecode(file("${find_in_parent_folders("global_values.yaml")}"))["default_domain_name"]
  default_domain_suffix = "${local.custom_tags["Env"]}.${local.custom_tags["Project"]}.${local.default_domain_name}"
}

inputs = {

  cluster-name = dependency.eks.outputs.cluster_id

  tags = merge(
    local.custom_tags
  )

  eks = {
    "cluster_oidc_issuer_url" = dependency.eks.outputs.cluster_oidc_issuer_url
  }

  aws-ebs-csi-driver = {
    enabled          = true
    is_default_class = true
  }

  aws-for-fluent-bit = {
    enabled = true
  }

  aws-load-balancer-controller = {
    enabled = true
  }

  aws-node-termination-handler = {
    enabled = false
  }

  calico = {
    enabled = true
  }

  cert-manager = {
    enabled                   = false
    acme_email                = "xxx"
    acme_http01_enabled       = true
    acme_http01_ingress_class = "nginx"
    acme_dns01_enabled        = true
    allowed_cidrs             = dependency.vpc.outputs.private_subnets_cidr_blocks
    experimental_csi_driver   = true
  }

  cluster-autoscaler = {
    enabled = true
  }

  cni-metrics-helper = {
    enabled = false
  }

  external-dns = {
    external-dns = {
      enabled = false
    },
  }

  ingress-nginx = {
    enabled       = true
    use_nlb_ip    = true
    allowed_cidrs = dependency.vpc.outputs.private_subnets_cidr_blocks
  }

  istio-operator = {
    enabled = false
  }

  karma = {
    enabled = false
  }

  keycloak = {
    enabled = false
  }

  kong = {
    enabled = false
  }

  kube-prometheus-stack = {
    enabled                     = true
    allowed_cidrs               = dependency.vpc.outputs.private_subnets_cidr_blocks
    thanos_sidecar_enabled      = true
    thanos_bucket_force_destroy = true
    extra_values                = <<-EXTRA_VALUES
      grafana:
        deploymentStrategy:
          type: Recreate
        ingress:
          enabled: true
          annotations:
            kubernetes.io/ingress.class: nginx
            cert-manager.io/cluster-issuer: "letsencrypt"
          hosts:
            - grafana.${local.default_domain_suffix}
          tls:
            - secretName: grafana.${local.default_domain_suffix}
              hosts:
                - grafana.${local.default_domain_suffix}
        persistence:
          enabled: true
          storageClassName: ebs-sc
          accessModes:
            - ReadWriteOnce
          size: 1Gi
      prometheus:
        prometheusSpec:
          replicas: 1
          retention: 2d
          retentionSize: "6GB"
          ruleSelectorNilUsesHelmValues: false
          serviceMonitorSelectorNilUsesHelmValues: false
          podMonitorSelectorNilUsesHelmValues: false
          storageSpec:
            volumeClaimTemplate:
              spec:
                storageClassName: ebs-sc
                accessModes: ["ReadWriteOnce"]
                resources:
                  requests:
                    storage: 10Gi
      EXTRA_VALUES
  }

  loki-stack = {
    enabled              = false
    bucket_force_destroy = true
  }

  metrics-server = {
    enabled       = true
    allowed_cidrs = dependency.vpc.outputs.private_subnets_cidr_blocks
  }

  npd = {
    enabled = false
  }

  sealed-secrets = {
    enabled = false
  }

  thanos = {
    enabled              = true
    generate_ca          = true
    bucket_force_destroy = true
  }

}

@rajat-bb You should check the logs of the aws-load-balancer controller, is it started ? It is responsible for provisionning nginx load balancer

@ArchiFleKs so I deployed with
ingress-nginx = {
    enabled = false
}
cert-manager = {
  enabled = false
}

$ kubectl get all -n aws-load-balancer-controller
NAME                                               READY   STATUS    RESTARTS   AGE
pod/aws-load-balancer-controller-77bd95c99-p5zcp   1/1     Running   2          5m52s
pod/aws-load-balancer-controller-77bd95c99-wl4df   1/1     Running   3          5m52s

NAME                                        TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)   AGE
service/aws-load-balancer-webhook-service   ClusterIP   <IP_ADDRESS>   <none>        443/TCP   5m52s

NAME                                           READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/aws-load-balancer-controller   2/2     2            2           5m52s

NAME                                                     DESIRED   CURRENT   READY   AGE
replicaset.apps/aws-load-balancer-controller-77bd95c99   2         2         2       5m52s

No errors but got this warning:
$ kubectl describe svc/aws-load-balancer-webhook-service -n aws-load-balancer-controller

Name:              aws-load-balancer-webhook-service
Namespace:         aws-load-balancer-controller
Labels:            app.kubernetes.io/instance=aws-load-balancer-controller
                   app.kubernetes.io/managed-by=Helm
                   app.kubernetes.io/name=aws-load-balancer-controller
                   app.kubernetes.io/version=v2.2.0
                   helm.sh/chart=aws-load-balancer-controller-1.2.0
Annotations:       meta.helm.sh/release-name: aws-load-balancer-controller
                   meta.helm.sh/release-namespace: aws-load-balancer-controller
Selector:          app.kubernetes.io/instance=aws-load-balancer-controller,app.kubernetes.io/name=aws-load-balancer-controller
Type:              ClusterIP
IP:                <IP_ADDRESS>
Port:              <unset>  443/TCP
TargetPort:        webhook-server/TCP
Endpoints:         <IP_ADDRESS>:9443,<IP_ADDRESS>:9443
Session Affinity:  None
Events:
  Type     Reason                        Age    From                       Message
  ----     ------                        ----   ----                       -------
  Warning  FailedToUpdateEndpointSlices  9m25s  endpoint-slice-controller  Error updating Endpoint Slices for Service aws-load-balancer-controller/aws-load-balancer-webhook-service: failed to update aws-load-balancer-webhook-service-pggk2 EndpointSlice for Service aws-load-balancer-controller/aws-load-balancer-webhook-service: Operation cannot be fulfilled on endpointslices.discovery.k8s.io "aws-load-balancer-webhook-service-pggk2": the object has been modified; please apply your changes to the latest version and try again

~$ kubectl logs svc/aws-load-balancer-webhook-service -n aws-load-balancer-controller

Found 2 pods, using pod/aws-load-balancer-controller-77bd95c99-p5zcp
{"level":"info","ts":1621413810.7138236,"msg":"version","GitVersion":"v2.2.0","GitCommit":"68c417a7ea37ff153f053d9ffef1cc5c70d7e211","BuildDate":"2021-05-14T21:49:05+0000"}
{"level":"info","ts":1621413813.9118292,"logger":"controller-runtime.metrics","msg":"metrics server is starting to listen","addr":":8080"}
{"level":"info","ts":1621413813.915899,"logger":"setup","msg":"adding health check for controller"}
{"level":"info","ts":1621413813.9160123,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/mutate-v1-pod"}
{"level":"info","ts":1621413813.916062,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/mutate-elbv2-k8s-aws-v1beta1-targetgroupbinding"}
{"level":"info","ts":1621413813.9161265,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/validate-elbv2-k8s-aws-v1beta1-targetgroupbinding"}
{"level":"info","ts":1621413813.9161882,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/validate-networking-v1beta1-ingress"}
{"level":"info","ts":1621413813.916359,"logger":"setup","msg":"starting podInfo repo"}
{"level":"info","ts":1621413815.9166052,"logger":"controller-runtime.manager","msg":"starting metrics server","path":"/metrics"}
I0519 08:43:35.916594       1 leaderelection.go:242] attempting to acquire leader lease  aws-load-balancer-controller/aws-load-balancer-controller-leader...
I0519 08:43:35.931381       1 leaderelection.go:252] successfully acquired lease aws-load-balancer-controller/aws-load-balancer-controller-leader
{"level":"info","ts":1621413816.0174956,"logger":"controller-runtime.webhook.webhooks","msg":"starting webhook server"}
{"level":"info","ts":1621413816.0175421,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0179927,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0181444,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0176175,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"channel source: 0xc0006d45a0"}
{"level":"info","ts":1621413816.0183995,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"channel source: 0xc0006d4640"}
{"level":"info","ts":1621413816.0186217,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0186818,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0188699,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0176709,"logger":"controller","msg":"Starting EventSource","controller":"service","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.019303,"logger":"controller","msg":"Starting Controller","controller":"service"}
{"level":"info","ts":1621413816.0190861,"logger":"controller-runtime.certwatcher","msg":"Updated current TLS certificate"}
{"level":"info","ts":1621413816.0198944,"logger":"controller-runtime.webhook","msg":"serving webhook server","host":"","port":9443}
{"level":"info","ts":1621413816.0201805,"logger":"controller-runtime.certwatcher","msg":"Starting certificate watcher"}
{"level":"info","ts":1621413816.1184464,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.1199784,"logger":"controller","msg":"Starting workers","controller":"service","worker count":3}
{"level":"info","ts":1621413816.1201553,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"channel source: 0xc0006d46e0"}
{"level":"info","ts":1621413816.1201959,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.218865,"logger":"controller","msg":"Starting Controller","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding"}
{"level":"info","ts":1621413816.2189276,"logger":"controller","msg":"Starting workers","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","worker count":3}
{"level":"info","ts":1621413816.2204275,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.2204852,"logger":"controller","msg":"Starting Controller","controller":"ingress"}
{"level":"info","ts":1621413816.2205112,"logger":"controller","msg":"Starting workers","controller":"ingress","worker count":3}

$ kubectl logs aws-load-balancer-controller-77bd95c99-p5zcp -n aws-load-balancer-controller

{"level":"info","ts":1621413810.7138236,"msg":"version","GitVersion":"v2.2.0","GitCommit":"68c417a7ea37ff153f053d9ffef1cc5c70d7e211","BuildDate":"2021-05-14T21:49:05+0000"}
{"level":"info","ts":1621413813.9118292,"logger":"controller-runtime.metrics","msg":"metrics server is starting to listen","addr":":8080"}
{"level":"info","ts":1621413813.915899,"logger":"setup","msg":"adding health check for controller"}
{"level":"info","ts":1621413813.9160123,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/mutate-v1-pod"}
{"level":"info","ts":1621413813.916062,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/mutate-elbv2-k8s-aws-v1beta1-targetgroupbinding"}
{"level":"info","ts":1621413813.9161265,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/validate-elbv2-k8s-aws-v1beta1-targetgroupbinding"}
{"level":"info","ts":1621413813.9161882,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/validate-networking-v1beta1-ingress"}
{"level":"info","ts":1621413813.916359,"logger":"setup","msg":"starting podInfo repo"}
{"level":"info","ts":1621413815.9166052,"logger":"controller-runtime.manager","msg":"starting metrics server","path":"/metrics"}
I0519 08:43:35.916594       1 leaderelection.go:242] attempting to acquire leader lease  aws-load-balancer-controller/aws-load-balancer-controller-leader...
I0519 08:43:35.931381       1 leaderelection.go:252] successfully acquired lease aws-load-balancer-controller/aws-load-balancer-controller-leader
{"level":"info","ts":1621413816.0174956,"logger":"controller-runtime.webhook.webhooks","msg":"starting webhook server"}
{"level":"info","ts":1621413816.0175421,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0179927,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0181444,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0176175,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"channel source: 0xc0006d45a0"}
{"level":"info","ts":1621413816.0183995,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"channel source: 0xc0006d4640"}
{"level":"info","ts":1621413816.0186217,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0186818,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0188699,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.0176709,"logger":"controller","msg":"Starting EventSource","controller":"service","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.019303,"logger":"controller","msg":"Starting Controller","controller":"service"}
{"level":"info","ts":1621413816.0190861,"logger":"controller-runtime.certwatcher","msg":"Updated current TLS certificate"}
{"level":"info","ts":1621413816.0198944,"logger":"controller-runtime.webhook","msg":"serving webhook server","host":"","port":9443}
{"level":"info","ts":1621413816.0201805,"logger":"controller-runtime.certwatcher","msg":"Starting certificate watcher"}
{"level":"info","ts":1621413816.1184464,"logger":"controller","msg":"Starting EventSource","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.1199784,"logger":"controller","msg":"Starting workers","controller":"service","worker count":3}
{"level":"info","ts":1621413816.1201553,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"channel source: 0xc0006d46e0"}
{"level":"info","ts":1621413816.1201959,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.218865,"logger":"controller","msg":"Starting Controller","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding"}
{"level":"info","ts":1621413816.2189276,"logger":"controller","msg":"Starting workers","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","worker count":3}
{"level":"info","ts":1621413816.2204275,"logger":"controller","msg":"Starting EventSource","controller":"ingress","source":"kind source: /, Kind="}
{"level":"info","ts":1621413816.2204852,"logger":"controller","msg":"Starting Controller","controller":"ingress"}
{"level":"info","ts":1621413816.2205112,"logger":"controller","msg":"Starting workers","controller":"ingress","worker count":3}

Maybe try not to use the master version of kubernetes-addons, https://github.com/particuleio/terraform-kubernetes-addons/issues/212
Some IAM permission have not yet been updated. Use latest tag version v2.1.0

Hey @ArchiFleKs
Do you mean v6.1.0?

I mean this module here: https://github.com/particuleio/teks/blob/main/terragrunt/live/demo/eu-west-3/clusters/full/eks-addons/terragrunt.hcl#L6 and use the latest released version https://github.com/particuleio/terraform-kubernetes-addons/releases/tag/v2.1.0

@ArchiFleKs Thank you so much. It worked!