Only use Subdir for Plexdrive

Is it possible to use only subdirectories of the GDrive with Plexdrive?
I have for example a folder for media files and others for other files and Plexdrive always goes the whole GDrive through but it would only need media. In the other directories are more than 2000000 files ....

Plexdrive uses the gdrive transaction logs to build your file system, so it has to go through from the first transaction all the way to the current one meaning it needs to process each and every file.
This is something that currently isn't going modified as it's the way to get the efficiency up to the required amount and keep your google drive and usage level down to not being banned.

Going through the entire transaction log and caching million of files seems like the opposite of efficiency and preventing bans. That could potentially take weeks to finish.
If I just want a folder mounted that contains a few thousand files, caching just that folder seems like a much better solution than going through potentially years of transactions and millions of files.

But google doesn't present us with that view... The supported way is to download the transaction logs and build the filesystem from that. It's not caching "millions of files", it's building an index for those files so it can build them on the fly when you request a file system view.
When you have google present to us the transaction log of just those folders, of course that can be implemented, but nobody has done that yet, so it cannot be done.

What about recursively going through a specified folder to build an index?


fix(vue-app): sanitize path with trailing slash in getLocation (#6744)

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #6744
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #6745 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6745   +/-   ##
=======================================
  Coverage   90.25%   90.25%
=======================================
  Files          78       78
  Lines        2718     2718
  Branches      706      706
=======================================
  Hits         2453     2453
  Misses        218      218
  Partials       47       47

Flag
Coverage Δ

#e2e
100% <ø> (ø)
:arrow_up:

#fixtures
64.6% <ø> (ø)
:arrow_up:

#unit
64.82% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89816f...ae1dc37. Read the comment docs.

@pi0 fixed getLocation again, because at first I did mutating with path and it failed tests. Now I don't mutate path
Because of mutating a lot of apps could be crushed :D

Are there any update about the status of this PR?
We can't update Nuxt in our project as this issue is blocking us. At the moment we are stuck on 2.6.1.

I don't know the proper way how to fix my PR to be merged, so I just still waiting :)
@pi0 could you help me with PR?

Codecov Report

Merging #6745 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6745   +/-   ##
=======================================
  Coverage   70.26%   70.26%
=======================================
  Files          88       88
  Lines        3747     3747
  Branches     1020     1020
=======================================
  Hits         2633     2633
  Misses        905      905
  Partials      209      209

Flag
Coverage Δ

#unittests
70.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c8b9b...d98e425. Read the comment docs.

Hi @crutch12 Sure we should merge this fix just as @pimlie mentioned, it is not only source of inconsistencies for baseURL and trailing slash handling. (like regression introduced by https://github.com/nuxt/nuxt.js/pull/6775 with 2.12). Do you mind adding an e2e test to cover this change? Meanwhile working to make a url utility package to use it on all places instead of depending on sanetization(s)

Ok, I'll try

@pi0 I've added some e2e tests for checking spa mode router.base (in browser, based on spa fixtures)
Basically with/without trailing slash tests.
Could you check it out?


sw-6577 setup files

Purpose
Briefly describe the purpose of the change.
Fixes ###-####
Approach
Explain how your code addresses the purpose of the change.
Learning
Any tips and tricks, blog posts or tools which helped you.
Checklist

[ ] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] I have updated documentation where relevant
[ ] I have added tests to prove my work
[ ] I have run an accessibility tool against the changes and applied fixes
[ ] The team have tested these changes

Worth adding node_module to your gitignore file.


Update resource-group-template-deploy-cli.md

Corrected 'az account set' to use --name rather than --subscription

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@JuliaHazelwood : Thanks for your contribution to the Azure documentation! The author, @tfitzmac, has been notified to review your proposed change.

@JuliaHazelwood - I am not seeing --name as an available parameter. I wonder if this was changed in one of the versions of CLI 2.0. Which version are you using?

Thanks for the reply. I am using CLI 2.0. I did not take a screen capture before, but it seems that '--subscription' works now as intended, cannot find a related bug but perhaps something was fixed since I filed this documentation change. We can close this change request.


Cache option for searchers

This PR introduces a new option cache(it should have been there from the start). The API and implementation is inspired by cosmiconfig. Similarities between lilconfig and cosmiconfig implementation:

Both use maps for storing caching results
The same public API to clear searchCache/loadCache/both
cache option is enabled by default
sync and async load methods use filepath argument as cache key (cosmiconfig)
sync and async search methods use path to a directory where lookup for search places will take place as cache key (cosmiconfig from is reassigned and called recursively in a closure)

I have added test cases for cache option enabled and disabled. Jest reports test coverage to be 100%. I am happy to add more tests if anyone can spot any missed cases.
Once approved I will merge this PR and release this as a new major version since this option is enabled by default. I consider this change in behaviour a breaking change. A few more changes will be merged prior to releasing a new version like dropping support for legacy node.js versions.
TODO

[x] async implementation
[x] sync implementation
[x] test enabled option
[x] test disabled option
[x] add to readme
[x] compare to cosmiconfig implementation
[x] add searchers shape comparison in tests

fixes #42

A few more changes will be merged prior to releasing a new version like dropping support for legacy node.js versions.

As a side note, Prettier still supports Node 14 today.
I don't know what is the plan for Prettier to dropping Node 14 and Node 16 (both EOL). I know it's not ideal, but it would be great if lilconfig could still maintain backward compat with Node 14.

I think this PR is ready to be merged. I ran a few benchmarks in feat/cache-bench branch. And made a couple of more small touches around getting from and updating the cache. Overall I am happy about the implementation and tests.
There is a small dip in test coverage because of an edge case that only occurs in nixos. I am not sure how this can be tested, so ignoring it for now.
While I am confident about basic benchmarks with set and map, the benchmarks with searches seem ludicrous to me. I might have messed up something with benchmark.js. I have no doubt about the new implementation being faster than the old one, but these numbers show too much of a difference to be believable.
Running "sync single search"
old x 959 ops/sec ±1.01% (93 runs sampled)
new x 31,080,130 ops/sec ±0.36% (97 runs sampled)
Fastest is new


inconsistent user of install prefix

I'm working on Ubuntu 18.04, using the system Python version 3.6.9, trying to install my own Python project.
Running python3 setup.py install --prefix=/usr/local will result in modules being installed into /usr/local/lib/python3.6/dist-packages/. However, when I want to switch to "developer mode", i.e. I replace the "install" command by "develop" (python3 setup.py develop --prefix=/usr/local), setuptools attempt to install the package into /usr/local/lib/python3.6/site-packages instead. (notice the difference between dist-packages and site-packages in the path).
Where does this inconsistency stem from, and how can I force the path to be consistent ?

We recommend not to use setup.py install at all. Use pip install and pip install -e. In that case, you'll probably get reliable behavior. If you do not, it's likely due to how debian patches distutils where the prefix logic is stored (more detail in #2232).

Thank you, I'll keep that in mind. However, let me put this into a somewhat broader perspective:
I have been using python setup.py since long before setuptools existed, to build, install, and package my Python projects. In particular, with some suitable extensions, this allowed me to prepare packages for various Linux distributions (rpms, debs, ...).
Nowadays, I don't have a coherent picture of what tools to use. You are suggesting pip, which seems fine in a Python-centric world, where packages are maintained in PyPI. What is the recommended way to generate rpm and deb packages now, using setuptools ? Is this also possible using some pip commands, or should I still use python setup.py <some-command> for that ? (Please note that I'm often working with projects that mix C++ and Python, or where Python just happens to be the implementation, but the main program isn't a Python package but a stand-alone tool (command-line or gui), and I'm not sure pip was meant to be used in that context.)

In the general case, I'd recommend against creating RPM and deb packages. These package managers already have their own ideosyncratic ways of managing Python and its packages. Instead, I would recommend drawing the line of using managed packages early (before building Python such as with pyenv), before installing pip (and bootstrap pip), or possibly after installing a suite of common, supported packages. But then, install additional packages using pip and possibly virtualenv. This approach gives you more flexibility with platforms (such as macOS and Windows) and gives more flexibility as to how you might construct a tool chain (for example, these package managers typically only allow one version of a dependency to be installed at a time on a given host).
That said, instead of answering the question you didn't ask (how to avoid/limit using system package managers), I'll try to answer the question you did ;)

What is the recommended way to generate rpm and deb packages now?

Setuptools still supports the bdist_rpm command, so you can manually install setuptools, build your package to an RPM, and then install that with your package manager. In the past, when I've needed Debian packages, I've used bdist_rpm and then run the artifact through alien to convert it to a Debian package. I wouldn't recommend it, but it worked.
It's possible the bdist_rpm command will be deprecated in the future, but I think it's likely that Setuptools will support third-party commands through entry points as it does now, meaning even if Setuptools were to remove the bdist_rpm command, that command (or an alternative) could be supplied by a third-party package.
What I don't understand is how this question pertains at all to setup.py install. I'm pretty sure setup.py install never installs an RPM. Instead, it installs a plain, unmanaged package or an egg (depending on options supplied and if setuptools is imported). If that's what you're doing now, then pip install . is the preferable alternative and will support packages where setup.py doesn't exist. There's nothing that setuptools or distutils can do for projects that are distributed through flit or other PEP 517 implementations where setup.py is optional. Even today, setup.py is optional for Setuptools-based packages (as long as editable installs aren't needed).
I hope that answers the question thoroughly. If I've made any mistakes or you have follow-up questions, let me know.

Hi Jason,
many thanks for the thorough reply ! You are entirely right, my follow-up question is rather tangential (if at all) to the original point. In fact, it is in reply to your comment to use pip for rather than setup.py directly.
Again, my concern is driven by the observation that pip appears to be a "Python-only" tool, i.e. useful for people who know they are working within a Python eco-system.
In contrast, most of my projects are not Python-centric, but rather use Python as an implementation language (or even Python language bindings to an otherwise C++-centric project).
And as I'm already maintaining other rpm and deb packages, I'm (somewhat) experienced with those package management systems, and would like to provide seamless integration for those. (A somewhat related question is https://github.com/pypa/setuptools/issues/2281)


CLINT causes spurious interrupts after mtimecmp update

When an OS is servicing a timer ISR it will typically write mtimecmp with a new value.
But the logic in clint::update_mtime depends on enough time having elapsed (as determined by the lfclk) before it will update the mtime_int_o output.  This means that if the ISR writes mtimecmp before the next lfclk tick occurs, a spurious timer interrupt will occur since mtime_int_o is still asserted.
In the cases where the mtime or mtimecmp registers are written, the timer state should be evaluated immediately so the mtime_int_o signal can deassert.

fixed with #9


Not able to send message through CC bot to everyone

Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request. Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request. Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request. Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request. Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request. Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request. Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request. Failed to sync all users. Status Code: 0 Exception: Code: generalException Message: An error occurred sending the request.

Have you looked for error in the Application Insights? I found this can help work out what's wrong.

Hi @Lekhip,
We will look into it and will get back to you soon.

Hi @Lekhip ,
Please let us know if you are still facing this issue and require assistance and we will be happy to discuss. If no further action is needed at moment and no response is received, we will close out the issue in 3 business days. You may also always open a new issue or respond here if something does come back up.


Fix for optimize-docs-images.yml

Added Curl as per
Configuration failed because libcurl was not found. Try installing:

deb: libcurl4-openssl-dev (Debian, Ubuntu, etc)

and removed "tools"  to satisfy error:
Warning messages:
1: package ‘tools’ is a base package, and should not be updated

https://github.com/StarTrooper08/r-dev-env/blob/devel/.github/workflows/optimize-docs-images.yml
I have updated the workflow little bit and tested in forked repo.
https://github.com/StarTrooper08/r-dev-env/actions/runs/10523014106
The images seems to be overoptimized and little bit distorted.

So the initial problem in the workflow is solved, but sounds like the optimise script might need some work?

yes


Delete handwritten notes when deleting note

This is just to make sure that I don't pile up on files:
When I delete a note right now, where the note has embedded one or several handwritten notes, I also need to proceed to delete the handwritten notes (in pdf form) one by one.
Would it be possible to make sure that if a note is deleted, it's embedded handwritten notes are deleted too?
This is related to the topic in this forum: https://forum.obsidian.md/t/remove-unused-attachments/4856
There other plugins are already recommended, but I thought that maybe you could directly integrate it within this plugin.

This is a very opinionated feature for my taste, as I don't think all users would like it to work this way. I would suggest you use any of the solutions on the forums thread.


Default to chruby

This is a request for opinions. In my understanding, people are now preferring chruby over rbenv, and I would like to make our defaults better.
Additionally, it looks like the rbenv cookbook may not be working as well as we'd like: pivotal-sprout/sprout-rbenv#6
Thoughts?

I'm in favor but then again I've been using chruby for a while...

Going to archive this repo, closing.


Possible to pull the names of the 'sections' of a youtube video?

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

Hi to you all,
I recently found out that the (relatively) new chapters, that creators can put in by putting timestamps and a string in the comments/description, actually get downloaded as seperate sub-tracks and then merged into a container format (I don't know how to call them, foobar2k names them 'subsongs').
( https://www.youtube.com/watch?v=HZTStHzWRxM This video has them, and explains them a bit.)
Now, I couldn't find an argument in the readme for this, and I am admittedly not well versed with these container formats, and how much metadata a single file can contain, so I don't know if the individual 'subsongs' can have their individual metadata, but would it be possible to write the name of the chapter as f.e. the 'Title' of it?
I tried to search for this in the tracker, but because I really don't know how these 'Chapters' are called, I didn't know what to search for except 'Chapters','Subsongs' etc.
So, if this has been asked before, I am really sorry.
Thanks for any answers in advance.

I should've removed the open tag I guess.

Sorry.

Ok, I tried to figure this out on my own, since the functionality apparently is here for a while now, with similar questions going on, but these mostly try to split the file, instead of changing the metadata inside the container.
(#24858 #25005 etc.)
I edited my original question, so that the already answered questions are not there anymore, but my case still remains, maybe this is not possible due to the way container formats work, in that case sorry.
I can't even figure out how to f.e. write the chapter names and timestamps into a file, without just copy-pasting the description...

Not possible.


Add a way to get specific constraint to animate components.

UI often runs animations with updating the constant value of the constraint.
Mondrian API is a faster way to get the whole layout, but still not have a way to get one of the constraints which would be used in animation.

hey! thank you for this great library! i would like to know if there is a way to update a constant value for now. is it impossible for now?

@ozgur-nent
thanks.
For now, we can find a constraint we needed from LayoutBuilderContext. but it's hard.
would you give me your detailed use case?

@muukii thank you for your answer. i wanna change top space of a view (to hide a view when user scroll the collectionview to bottom)

@ozgur-nent I see, could you paste your example code? I'd like to know what layout blocks you're using.


Aliexpress images blocked (ae01.alicdn.com)

A recent update has added ae01.alicdn.com to the blocklist, however this is domain is used for serving product images on aliexpress.com and so should not be blacklisted.

It's part of the https://someonewhocares.org/hosts/ hosts file, I've sent an email to<EMAIL_ADDRESS>reporting the issue.


NIFI-13327: Allow migrating properties of Parameter Providers

Summary
NIFI-13327
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 21

Licensing

[x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

As of 4e6f79d, I need some help to continue integrating this feature into NiFi. As far as I understand, Parameter Providers are special in the sense they do not belong to Process Groups, but rather they are 'Controller Level' components. The current implementation does not work, as it seems like the migrateProperties function does not get called, even though there is a Parameter Provider defined in the flow.json.gz, which was copied from a previous version of NiFi.
I'm pretty much stuck. Please help me with some hints.

@takraj Thanks for starting work on this approach. Given that the feature does not work as it stands, I recommend closing the pull request for now and continuing the discussion on the associated Jira issue. I am planning on taking evaluating some other Parameter Provider changes, but unfortunately I'm not in a position to provide a concrete way forward right now.
Referencing your feature branch in the Jira issue would provide an opportunity for some consideration prior to reopening the pull request, after confirming that the basic functionality works.

@takraj Revisiting this pull request in light of the Database Adapter migration, I think it is best to close this for now and consider revisiting in the future.
Migrating Parameter Provider properties seems like less of a concern, since it is a more specialized feature, and the database-backed implementation is also a less-common use case. The change for Database Adapters could move forward independent of this change, so I recommend focusing there before coming back to this, and also getting something to a working state before reopening.


Usable in Column

Beautiful contribution to h5p. Are there any plans to incorporate this into Column? Would be nice to add questions etc. underneath agamotto.
Thanks

I didn't have plans so far, but I will look into it.

Thanks!

Agamotto actually works fine once added to the list of field option is Column's semantics.json. I don't know if they will automatically add it or perhaps you can request it. I think the width of it just needs to be widened a bit inside the column.

Either way, I'm going to start using it today. Thanks again for the great contribution. I

I thought it was as easy as that, see my post https://h5p.org/node/87693 from this morning :-)

Yeah I only realised today that for changes in the json files to be applied in Drupal, you need to "upgrade" the content type. I wish I knew that ages ago.
Btw, I can't access that link.

Hi otacke, I realised there that in a column in Firefox, there is a constant re-firing of your resize function  starting on line 188 of agamotto.js. I think it only happens when other content is also added and it kills page functionality (but is a good Windows 95 emulator I guess). Edge and Chrome test fine for me.
// Add Resize Handler
      window.addEventListener('resize', function (e) {
        /*
         * Decrease the size of the content if on a mobile device in landscape
         * orientation, because it might be hard to use it otherwise.
         * iOS devices don't switch screen.height and screen.width on rotation
         */
        if (isMobileDevice() && Math.abs(window.orientation) === 90) {
          if (/iPhone/.test(navigator.userAgent)) {
            that.wrapper.style.width = Math.round((screen.width / 2) * that.images.getRatio()) + 'px';
          }
          else {
            that.wrapper.style.width = Math.round((screen.height / 2) * that.images.getRatio()) + 'px';
          }
        }
        else {
          // Portrait orientation
          that.wrapper.style.width = 'auto';
        }

        that.images.resize();
        that.slider.resize();
        // The descriptions will get a scroll bar via CSS if neccesary, no resize needed

        // Resize iframe if image's height is too small or too high.
        var windowHeight = window.innerHeight;
        var wrapperHeight = that.wrapper.offsetHeight;
        var actionBar = document.querySelector('.h5p-actions');
        var actionBarHeight = actionBar ? actionBar.offsetHeight : -1;
        if (wrapperHeight + actionBarHeight + 1 !== windowHeight) {
          that.trigger('resize');
        }
      });

Removing the contents of that function gets rid of the re-firing but breaks the resizing of content on screen size change.
I wonder if there is some check you can add to combat it?
Thanks,
Niall

Thanks! Will look into it.

I changed the resize handling. You can use the latest version from this repository with H5P.Column now. Just let me know if it works for you now.


azure log tail, do not stop when application redeploys

I'm using Github continuous integration, and every time I deploy a new version, the log stops and I have to execute the shell command again. I think it should keep logging while redeploying otherwise you miss importan information on app startup (in this case this is a Node js project)
2017-02-12T22:28:17  Stream terminated due to timeout 30 min(s).
info:    <Buffer 32 30 31 37 2d 30 32 2d 31 32 54 32 32 3a 32 38 3a 31 37 20 20 53 74 72 65 61 6d 20 74 65 72 6d 69 6e 61 74 65 64 20 64 75 65 20 74 6f 20 74 69 6d 65 ... >
info:    site log tail command OK

Based on the output you show, the reason the stream stopped is that there had been no output for 30 minutes. It is not related to the fact that you are deploying.
If you start the log streaming right before deploying, it should not get discontinued by the deployment.

@davidebbo well that might be the wrong example, but look at this:
2017-02-13T14:44:20  The application was terminated.
info:    <Buffer 0d 0a 32 30 31 37 2d 30 32 2d 31 33 54 31 34 3a 34 34 3a 32 30 20 20 54 68 65 20 61 70 70 6c 69 63 61 74 69 6f 6e 20 77 61 73 20 74 65 72 6d 69 6e 61 ... >
info:    site log tail command OK

I just tweaked an environment variable, and the log stopped. It's really annoying. I've seen it happening between deploys too.

Setting an Azure App Setting restarts the app, which will disconnect the log stream. But this is different from the scenario you described here, where a Github deployment is disconnecting the stream. That should not happen.


Use standard and @fastify/pre-commit

Checklist

[x] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 57 (100.0%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 99.853%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
401

Relevant Lines:
401

💛  - Coveralls

I have no strong opinion but it's just cosmetic :)

@aboutlo
It would be then in line with all the other repos.

Thx @Eomm
But should we merge it or not. @aboutlo i assume you have the golden ticket regarding the vote of @mcollina
Can you approve or close this PR please?

no strong opinion, but given others signalled in favor and  we can standardise towards what other repo do I will merge it


[BACKEND][NVIDIA] Change getTotalElemsPerThreadForOperand to use getRepForOperand

Fixes https://github.com/triton-lang/triton/issues/5102
The logic in getTotalElemsPerThreadForOperand should now directly match that in SharedToDotOperandMMAv2OrV3

I had originally thought that this is required to fix a legit case that sometimes occurs, but after further inspection, the case where kWidth=2 and instrShapeK = 32 should never happen, so the original logic is correct.
Nevertheless, it's probably better practice to reuse the existing getRepForOperand() function, following the code in SharedToDotOperandMMAv2OrV3.
With that said, I should probably remove the test I added, since that code should never be generated by previous passes?

Please run pre-commit


About the dataset preprocessing

Hi, I want to train StyleGAN on Celeba64, could you please tell me how to prepare the celeba64.zip? Thanks!

https://github.com/Zhendong-Wang/Diffusion-GAN?tab=readme-ov-file#data-preparation


Atomic operations in SefRefCount are not properly cross-platform

Godot version:
3.2 master (adb85fc8)
OS/device including version:
All, but known problems on OpenBSD/macppc so far, or Android/x86 if __atomic* methods are used.
Issue description:
#31321 by @julianaito aimed to address a portability issue for SefRefCount's atomic operations on OpenBSD/macppc, but caused an issue with Android/x86 (#31407).
It was thus reverted for the time being, but a better solution needs to be looked into and merged again.
See discussion in #31407, and the possibility to simply drop SafeRefCount in 4.0 to use atomic types from the standard library instead.
CC @RandomShaper @hpvb @reduz

Is this still valid on master?

In the upcoming days I'll be working on these areas of bringing C++ implementations of multi-threading stuff. Stay tuned.


[Bug]Hover over backlink in editing mode, the mouse stays at the top of popup

Hi! I've been using Hover Editor for a long time and it has been working very well. But recently after I updated obsidian to the latest version, I found that when I hover my mouse over the backlinks, opening popup in editing mode, the mouse stays at the top instead of scrolling to the corresponding position in the popup. Is it a bug?
Reproduced in the sandbox.
OS: Windows 10
obsidian: 1.1.12
Hover Editor: 0.11.9

If you mean that hovering in the backlinks panel used to go to the correct link, I am not able to reproduce the issue with Obsidian 1.1.10.  That suggests that some change was made in Obsidian 1.1.12 that affects this, perhaps in the API, perhaps not.  You might want to provide feedback on the alpha or insider channel on discord (as applicable to the release you're using) regarding the issue and forward details here regarding what changed.  (Due to personal time constraints I haven't been keeping up with the Obsidian discord for some time now.)

(To clarify the above: by provide feedback I mean "tell the obsidian devs that 1.1.12 broke this behavior in Hover Editor, which works in 1.1.10".  And by forward details, I mean, if they have any specific advice about what we need to change, please relay it via this issue.  Thanks.)


Conditional Workflows

Adds conditional authentication to workflows to prevent failures from fork jobs due to inaccessible secrets.

Pull Request Test Coverage Report for Build 839655890

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.019%

Totals

Change from base Build 839653833:
0.0%

Covered Lines:
44

Relevant Lines:
53

💛  - Coveralls


Mistake in Getting Started

In the getting started code snippet, which sets up a basic bot, there is a + missing, in the second print statement of the _on_DiscordBot_bot_ready method,between the bot.guilds.size() and 'guilds'.
print('Listening on ' + str(bot.channels.size()) + ' channels and ' + str(bot.guilds.size()) ' guilds.')

Thanks for the report. Its been modified. commit


github action: split the run of the fuzzers

fix #5443
according to

https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
https://docs.github.com/en/actions/examples/using-concurrency-expressions-and-a-test-matrix

Sorry, i didn't merge it
it is great. I am just a bit sad that we have to recompile it every time (3 minutes instead 1)
would it be possible to have the task running one after the other in the same VM ?

Sorry, i didn't merge it it is great. I am just a bit sad that we have to recompile it every time (3 minutes instead 1) would it be possible to have the task running one after the other in the same VM ?

yes it can be, but if we do that it will miss the goal:
run them into dedicated tasks (one per fuzzer)

which I understand is running all the fuzz tests in parallel.
right?

or let me think of a way to reduce the compile time.

oh I am sorry, the fuzz test already using the
- uses: Swatinem/rust-cache@v2

so I think there is nothing I can do right now 😞

Hi @sylvestre
how about this

sorry for the misunderstanding
I thought the Swatinem/rust-cache@v2 action could cache everything,
but after reading the doc and the cargo-fuzz doc,
I found out I was so wrong.
please review this PR again while you have time.
thanks

This is perfect, many thanks


llvm build script

Run the script on C7,  failed, output log:
Cloning into 'llvm-project'...

Note: switching to 'remotes/origin/release/15.x'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8dfdcc7b7bf6 [libc++] Fix memory leaks when throwing inside std::vector constructors
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/images/create?fromImage=openeuler%2Fopeneuler&tag=23.03": dial unix /var/run/docker.sock: connect: permission denied
docker: permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/create?name=llvm-chunyu": dial unix /var/run/docker.sock: connect: permission denied.
See 'docker run --help'.
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/llvm-chunyu/json": dial unix /var/run/docker.sock: connect: permission denied
cp: cannot stat 'rvoe23_03_llvm.tar.gz': No such file or directory
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/llvm-chunyu/json": dial unix /var/run/docker.sock: connect: permission denied
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/llvm-chunyu/stop": dial unix /var/run/docker.sock: connect: permission denied

updated:

fix git checkout error.  (git clone https://github.com/llvm/llvm-project.git --depth 1 --branch release/15.x)
address comment from @Xeonacid.
thanks

The current packaging infra that targets each distro individually is being replaced, so closing for now.

@xen0n Hi, is there any link to the new "the packaging infra" replacing this repo? Wondering if we could start porting this script to it.

@imkiva I've just pushed the current set of scripts I've been using; the main branch is now replaced and ready for refactoring. For now it's basically just simple containerized packaging using a greatest-common-denominator distro (Ubuntu 20.04) and cross-compiling to the alt-arches (aarch64 and riscv64), but I hope to gradually morph the scripts into something more amenable to automation and more maintainable than the previous ad-hoc set of distro-specific scripts.


[Feature] tags as expandable in Deviation objects

Since tags now play a much larger role on DA it would be amazing to include tags in Deviation objects as expandable. Similar like user.details
The current way now is to call metadata for each deviation.

Closing this ticket due to its age. If this is still an issue, please feel free to reopen. Thanks!


Export Section in Edit Collective is not Mobile Optimized

Describe the bug
I noticed that the Export section within the Edit Collective screen isn't behaving well on mobile devices. As seen by the below screenshot part of it is cut off.

Click on settings (near the logo).
On the left hand side, select Exports.

Note: You'll have to do the above in a mobile device or use the browser dev tools.
Expected behavior
The page should not cut off and should show every field clearly.
Screenshots

>>Screenshot<<

Hi, @SudharakaP @Betree I would like to contribute to this issue, how do I go about the same? Thanks!

@VinayakChopra : Sure please feel free to go ahead (hope you agree too @Betree 😄); I've assigned the issue to you. The component in question is Export.js and this is probably where you will need to make changes for the responsiveness. Feel free to let us know if you need any further help. 👍🏽

@VinayakChopra : Sure please feel free to go ahead and submit a PR (hope you agree too @Betree 😄); I've assigned the issue to you. The component in question is Export.js and this is probably where you will need to make changes for the responsiveness. Feel free to let us know if you need any further help. 👍🏽

Absolutely :-) thanks for documenting this issue @SudharakaP, and thanks for offering your help @VinayakChopra!

Hi, @SudharakaP @Betree thanks for assigning me this issue. I tried fixing the same but couldn't as I am still learning react as of now. I would love to work on issues once I am more comfortable with react and javascript.

@VinayakChopra No problem! Good luck with your learning. Feel free to come back when you'll feel more comfortable :slightly_smiling_face:


Multiple notices: [ There were error(s) loading the rules: /tmp/rules.debug:18: syntax error - The line in question reads [18]: table   persist   ]

I have read the contributing guide lines.
I have searched the existing issues and I'm convinced that mine is new.
Describe the bug
I get a lot of these 'unread notices':
[ There were error(s) loading the rules: /tmp/rules.debug:18: syntax error - The line in question reads [18]: table   persist   ]
I'm not sure what to do with this. I tried three fresh installations, didn't manually change any config files.
Similar messages can be found in the General log:
opnsense[87408]: /usr/local/etc/rc.filter_configure: There were error(s) loading the rules: /tmp/rules.debug:16: syntax error - The line in question reads [16]: table  persist
opnsense[8788]: /usr/local/etc/rc.filter_configure: There were error(s) loading the rules: /tmp/rules.debug:16: syntax error - The line in question reads [16]: table  persist
Screenshots
https://i.imgur.com/eMynhDr.png
Environment
OPNsense 20.7-amd64
Windows Server 2019 with Hyper-V
DVD iso installation source

What does line 18 of the file state? (open  /tmp/rules.debug in a console using vi or less), it's quite unlikely a clean install causes this, are you sure you didn't import a config file from somewhere else? (pfSense, m0n0wall)

@AdSchellevis
Not importing a file, 100% clean install - added a single port forwarding rule but the error existed before that.
Line 18 states "table   persist"
Attached is the complete file.
rules.debug.txt

created an alias named "file"?
table <file>  persist
file = "<file>"

It's a reserved word, which probably skips our validation.

created an alias named "file"?
table <file>  persist
file = "<file>"

It's a reserved word, which probably skips our validation.

Ah yes.. My file server; LOL. Thanks! I'm going to try this.


Api refactor

See individual commit messages for the full rundown.
Big items:

Filter replaced by (Search -> Query, Scan), PreparedSearch, (SearchIterator -> QueryIterator, ScanIterator)
Client replaced with SessionWrapper
Index, Column join BaseModel in models.py
Rename NotModified -> NotLoaded
Rewrite Exceptions, many new ones.  Rarely throw raw ValueError.

Just to link them, this implements a large part of #60


wait for pid termination on quit

wait for all pids created by proctmux to terminate before quitting
This PR includes a hack to close stdin in the input loop. termion async_stdin may be the best way to remove that hack.

She is beauty, she is grace.


Regression of uv pip install in 0.2.5?

I have the following issue:
I have a setup where those extras_require are defined in setup.py but when running
uv pip install -e '.[test]'
it says
warning: The package `mypackage @ file://[...]` does not have an extra named `test`.

and also doesn't install any dependencies other then the package itself, not even the things in requirements.txt.
This is the case since v0.2.5, it works fine in 0.2.4.
Original post: https://github.com/astral-sh/uv/issues/2828#issuecomment-2185769691
I have not managed to create a full reproduction setup so far, but I got a bit closer:
The reproduction repository https://github.com/karfau/uv-install-issue contains a script test.sh which

drops the venv folder if it exists
configures a virtual env, I tested with both python 3.8 (because that is what the original repository uses), but the behavior doesn't change with python 3.12
installs uv in the version passed as the first argument
installs the dependencies using uv --verbose pip install -e '.[test]'
lists the content of venv/bin to check if the dependencies have been installed

In the reproduction it prints the warning (since 0.2.0 if the pyproject.toml contains a [project] section) and always installs all dependencies.
So maybe the warning was leading me into a wrong direction, but in the original repository the warning is not present when running those steps using uv 0.2.4 but the warning is printed when using uv 0.2.5 and it is only installing the editable package but nothing from install_requires or extra_requires.
here is the --verbose output in the affected repository, if you have any idea in what direction to continue testing, let me know
+ uv --verbose pip install -e '.[test]'
DEBUG uv 0.2.15
DEBUG Searching for Python interpreter in system toolchains
DEBUG Found cpython 3.8.19 at `/home/.../venv/bin/python3` (active virtual environment)
DEBUG Using Python 3.8.19 environment at venv/bin/python3
DEBUG Acquired lock for `venv`
DEBUG At least one requirement is not satisfied: file:///home/.../mypackage[test]
DEBUG Using request timeout of 30s
DEBUG Found PEP 621 metadata for /home/... in `pyproject.toml` (backend38)
DEBUG Acquired lock for `/home/.../.cache/uv/built-wheels-v3/editable/12f46ea7eac52d49`
DEBUG Preparing metadata for: mypackage @ file:///home/...
DEBUG No static `PKG-INFO` available for: mypackage @ file:///home/... (MissingPkgInfo)
DEBUG Found static `pyproject.toml` for: mypackage @ file:///home/...
DEBUG No workspace root found, using project root
DEBUG Solving with installed Python version: 3.8.19
DEBUG Adding direct dependency: mypackage*
DEBUG Adding direct dependency: mypackage[test]*
DEBUG Searching for a compatible version of mypackage[test] @ file:///home/... (*)
DEBUG Searching for a compatible version of mypackage @ file:///home/... (==1.307.0)
DEBUG Searching for a compatible version of mypackage[test] @ file:///home/... (==1.307.0)
DEBUG Tried 1 versions: mypackage 1
Resolved 1 package in 1ms
DEBUG Identified uncached requirement: mypackage @ file:///home/...
DEBUG Preserving seed package: pip==23.0.1
DEBUG Preserving seed package: setuptools==56.0.0
DEBUG Preserving seed package: uv==0.2.15
DEBUG Acquired lock for `/home/.../.cache/uv/built-wheels-v3/editable/12f46ea7eac52d49`
DEBUG Building: mypackage @ file:///home/...
INFO Ignoring empty directory
DEBUG Solving with installed Python version: 3.8.19
DEBUG Adding direct dependency: setuptools==68.2.2
DEBUG Found stale response for: https://pypi.org/simple/setuptools/
DEBUG Sending revalidation request for: https://pypi.org/simple/setuptools/
DEBUG Found not-modified response for: https://pypi.org/simple/setuptools/
DEBUG Searching for a compatible version of setuptools (==68.2.2)
DEBUG Selecting: setuptools==68.2.2 (setuptools-68.2.2-py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/bb/26/7945080113158354380a12ce26873dd6c1ebd88d47f5bc24e2c5bb38c16a/setuptools-68.2.2-py3-none-any.whl.metadata
DEBUG Tried 1 versions: setuptools 1
DEBUG Installing in setuptools==68.2.2 in /home/.../.cache/uv/environments-v0/.tmpUhHv2P
DEBUG Requirement already cached: setuptools==68.2.2
DEBUG Installing build requirement: setuptools==68.2.2
DEBUG Calling `setuptools.build_meta:__legacy__.get_requires_for_build_editable()`
DEBUG Installing extra requirements for build backend
DEBUG Solving with installed Python version: 3.8.19
DEBUG Adding direct dependency: setuptools==68.2.2
DEBUG Adding direct dependency: wheel*
DEBUG Searching for a compatible version of setuptools (==68.2.2)
DEBUG Selecting: setuptools==68.2.2 (setuptools-68.2.2-py3-none-any.whl)
DEBUG Found stale response for: https://pypi.org/simple/wheel/
DEBUG Sending revalidation request for: https://pypi.org/simple/wheel/
DEBUG Found not-modified response for: https://pypi.org/simple/wheel/
DEBUG Searching for a compatible version of wheel (*)
DEBUG Selecting: wheel==0.43.0 (wheel-0.43.0-py3-none-any.whl)
DEBUG Found fresh response for: https://files.pythonhosted.org/packages/7d/cd/d7460c9a869b16c3dd4e1e403cce337df165368c71d6af229a74699622ce/wheel-0.43.0-py3-none-any.whl.metadata
DEBUG Tried 2 versions: setuptools 1, wheel 1
DEBUG Installing in setuptools==68.2.2, wheel==0.43.0 in /home/.../.cache/uv/environments-v0/.tmpUhHv2P
DEBUG Requirement already installed: setuptools==68.2.2
DEBUG Requirement already cached: wheel==0.43.0
DEBUG Installing build requirement: wheel==0.43.0
DEBUG Calling `setuptools.build_meta:__legacy__.build_editable("/home/.../.cache/uv/built-wheels-v3/editable/12f46ea7eac52d49/atb4asxSb3HqEzyYl4kAX/.tmpngnApZ", {}, None)`
DEBUG Finished building: mypackage @ file:///home/...
Prepared 1 package in 4.15s
Installed 1 package in 0.76ms
 + mypackage==1.307.0 (from file:///home/...)
warning: The package `mypackage @ file:///home/...` does not have an extra named `test`.

The problem with your setup is that you have a pyproject.toml with a [project] section, but you haven't declared any of the metadata as dynamic. Per the spec, if you omit dependencies from the [project] section, that's equivalent to project.dependencies = [].
You should add dynamic = ["dependencies", "optional-dependencies"] to your pyproject.toml, under the [project] section.

@charliermarsh thx, a lot, that resolved my initial problem.
It's still not clear to me if this is intended as a change in behavior and what change between 0.2.4 and 0.2.5 causes this.
And why it behaves different in our repository then in the reproduction.
But for now I'm fine with the solution.

It’s intended behavior because we added an optimization to read the metadata directly when it’s statically declared. And in this case, the metadata is technically statically declared (even though you want it to be dynamic).


User-reported unhelpful error message

Program: https://code.world/haskell#PZl49ZQJYAjaqbKL7hzeteQ
Message:
program.hs:58:20-27: error: Outdated use of grey as a function.
    Remove the function argument for a medium shade of grey.
    For a different shade of gray, use light, dark, or HSL.

The message is clear.  Not going to re-add a deprecated symbol years later.


Don't touch instance _callbacks object when loading model attributes

If you load() a model instance using a 2nd instance, and if the 2nd instance has any event callbacks,
all of the 1st instance's callbacks will be overwritten with those from the 2nd instance.
The fix is to ignore the _callbacks object when loading instance attributes.

Good fix! haven't bumped into this somehow, but I could imagine doing so quite easily.


fix module name

the module param actually refers to the module of the nightly release - not the target repo where the release is being updated

/lgtm


Typescript Date to C# DatetimeOffset

Hi,
I have a TypeScript Datetime, I send it to my WebApi but it always null.
It means the conversion doesnt work correctly.
Is there a way to automatize the conversion with NsWagStudio?
Thank you
Cedric

The pb didnt come from TypeScript, i fixed it.
Thanks


App shows -1% when not connected

The app shows -1% when not connected to the device.
The % should only show when the device is connected, and minimum % value should be 0%

@josancamon19 can you assign me this? can take up.

Wondering how this is going @ArchishmanSengupta it'd be great if you could create a Draft PR

hi, @josancamon19 due to some unforeseeable reason I am off for a few days, kindly assign this to someone else.

https://github.com/BasedHardware/Friend/pull/338

IMO P4, not MVP and does not prevent user from full functionality.  It's cosmetic

Thanks @raymanyyy


UIImagePickerController is deprecated in iOS 15

Apple Introduced new Photos_picker PhotosKit in IOS_15. Apple has also deprecated asset library and UIImagePickerController.

With this new picker app do not need to ask user for permission to photo library.
Single, Multiple, infinite selection supported
Images, live photos and video filters for disable selection to that type of PhAsset
More Secure
Support all features of photos apps i.e search, zoom in and out
User can view selection in full_screen.

This all is automatically handled by PhotosKit
Originally posted by @nomi9995 in https://github.com/flutter/flutter/issues/78391#issuecomment-864258919

Hm it doesn't look hard deprecated in the iOS 15 SDK:
UIKIT_EXTERN API_AVAILABLE(ios(2.0)) API_UNAVAILABLE(tvos) NS_SWIFT_UI_ACTOR
@interface UIImagePickerController : UINavigationController <NSCoding>

I'm going to close this then, the PhotosUI framework is already used on >iOS 14 https://github.com/flutter/plugins/pull/3835.  If they actually hard deprecate in a future iOS version then we will need to add more API_AVAILABLE_ type checks to the UIImagePickerController call sites.

@jmagman this screenshot is from wwdc 2021 session https://developer.apple.com/videos/play/wwdc2020/10652/

@nomi9995 They haven't hard deprecated it in the iOS 15 SDK (yet).  Apple sometimes says things are "deprecated" as a warning that the API will deprecated and removed in a future OS, not that it's literally deprecated with a warning.  The image_picker plugins already use the PhotosUI on iOS 14 and over.  When UIImagePickerController is hard deprecated we will make sure there are no depreciation warnings in the plugin, at which point we will file a more specific bug.


[FLINK-13553] Ignore KvStateServerHandlerTest because it is unstable

This PR temporarily disables KvStateServerHandlerTest because it is unstable. As soon as the community decides to actively support queryable state again, we should fix this test and enable it again.

Manually merged via 9eae578ae592254d54bc51c679644e8e84c65152


Symfony 5 compatibility

Thank you for your work! Would you mind doing your PR to the 1.5 branch? Although github doesn't show it, the CI for this PR has failed for PHP <= 7.1: https://travis-ci.org/github/php-vcr/php-vcr/builds/697325760. These versions are no longer tested for the 1.5 branch, so it won't be a problem there. I plan on do a pre-release for 1.5.0 soon, so it can be tested in the wild. Adding compatibility with Symphony 5 is a great contribution to that.

Should be backwards compatible with older Symfony LTS releases now

Thanks again for your work. If you could bring your branch up to speed with the current 1.5 (which had your other PR merged with it), I'm ready to merge.


Implement additional Tracker get/set services for batch-processing and past-frame-reporting

New services to be added: Note, properties must be supported by the low-level library.
/**
 * @brief Gets the current "enable-batch-process" settings for the named KTL
 * or IOU Tracker object.
 * @param[in] name unique name of the Tracker to query
 * @param[out] true if batch-processing is enabled, false otherwise
 * @return DSL_RESULT_SUCCESS on success, DSL_RESULT_TRACKER_RESULT otherwise
 */
DslReturnType dsl_tracker_batch_processing_enabled_get(const wchar_t* name,
    boolean* enabled);

/**
 * @brief Sets the "enable-batch-process" settings for the named KTL
 * or IOU Tracker
 * Note: This call is only effective if the low-level library supports
 * both batch and per-stream processing.
 * @param[in] name unique name of the Tracker to query
 * @param[out] true to enable batch-processing enabled, false otherwise
 * @return DSL_RESULT_SUCCESS on success, DSL_RESULT_TRACKER_RESULT otherwise
 */
DslReturnType dsl_tracker_batch_processing_enabled_set(const wchar_t* name,
    boolean enabled);

/**
 * @brief Gets the current "enable-past-frame" settings for the named KTL
 * or IOU Tracker
 * @param[in] name unique name of the Tracker to query
 * @param[out] true if past-frame reporting is enabled, false otherwise.
 * @return DSL_RESULT_SUCCESS on success, DSL_RESULT_TRACKER_RESULT otherwise
 */
DslReturnType dsl_tracker_past_frame_reporting_enabled_get(const wchar_t* name,
    boolean* enabled);

/**
 * @brief Sets current "enable-past-frame" settings for the named KTL
 * or IOU Tracker object
 * Note: This call is only effective if the low-level library supports
 * past frame reporting.
 * @param[in] name unique name of the Tracker to query
 * @param[out] true if past frame reporting is enabled, false otherwise.
 * @return DSL_RESULT_SUCCESS on success, DSL_RESULT_TRACKER_RESULT otherwise
 */
DslReturnType dsl_tracker_past_frame_reporting_enabled_set(const wchar_t* name,
    boolean enabled);

Merged into v0.16.alpha

These services will be updated to DCF specific function..

Merged into v0.16.alpha


Cannot change results order/sort in reducer

When I re-sort a list of results in a query reducer (for example, the list could be organized alphabetically and one of the item names just changed), it doesn't seem like the new sort gets propagated through to the UI, or even to the store (although any modifications to documents within the list do get propagated correctly).
Has anybody else observed a similar issue? Or should I assume the problem is coming from my side of things?

You should always create new objects when you change props. E.g. return [...oldArray].sort(etc)

@wmertens oh that totally worked, thanks so much!
I still think it's worth asking if apollo-client should create new objects itself behind the scenes, to avoid that issue? Or else maybe just highlight it in the docs?

@SachaG we were thinking about using deep freeze in development mode to make sure objects aren't changed accidentally.

Deep freezing objects comes at a performance cost in Safari, and cloning
objects has a cost in all browsers. I much prefer no magic behind the
scenes.
On Mon, Dec 19, 2016 at 4:47 AM Jonas Helfer<EMAIL_ADDRESS>wrote:

@SachaG https://github.com/SachaG we were thinking about using deep
freeze in development mode to make sure objects aren't changed accidentally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apollostack/apollo-client/issues/1057#issuecomment-267876049,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlgwP_vN1yyRcB5Ia-V_jctqU8VkQks5rJf5ugaJpZM4LQFS_
.

I guess we need to weigh the performance cost vs the lost developer productivity if this turns out to be an issue people frequently run into. Personally I like a little magic :)

@wmertens I think it's a reasonable tradeoff to use it in development mode where performance isn't quite as important. The potential time savings of not having to track down accidental modifications are worth the limited overhead, especially considering that in production you don't have to pay that price.

Yes, agreed, in development it's a useful feature.
On Mon, Dec 19, 2016 at 10:36 AM Jonas Helfer<EMAIL_ADDRESS>wrote:

@wmertens https://github.com/wmertens I think it's a reasonable
tradeoff to use it in development mode where performance isn't quite as
important. The potential time savings of not having to track down
accidental modifications are worth the limited overhead, especially
considering that in production you don't have to pay that price.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apollostack/apollo-client/issues/1057#issuecomment-267920577,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWljNRLav_3TUPPb49JAX4k-sJe5BKks5rJlAWgaJpZM4LQFS_
.

@SachaG Thanks for bringing it up! I think I'll close this issue since we're already tracking it on the roadmap.


Minor: add test for panic propagation

Which issue does this PR close?
Follow on to https://github.com/apache/datafusion/pull/12086
Rationale for this change
@crepererum  suggested a  test for an existing panic propagation features here https://github.com/apache/datafusion/pull/12086#discussion_r1728587048
What changes are included in this PR?
Add test
Are these changes tested?
Only tests
Are there any user-facing changes?
Only tests

Thanks everyone for review

Thanks @comphead


DTLS used in email?

DTLS is a standardised protocol which is built into all browsers that support WebRTC, and is one protocol consistently used in web browsers, email, and VoIP platforms to encrypt information.

Is DTLS used in email? Email is running on TCP.

I just have made a mistake when I was researching. A quick google search doesn't back up this information so I deleted the reference to email.

:+1:


events created with newline in the description are lost

The new event UI has a textarea for the description, which invites use of newlines. The Save button seems to work: the app goes from NewEvent back to Home and the new event appears briefly, but it then disappears.
I see a complaint in the console about an unescaped control character (decimal 10 is newline):
Uncaught (in promise) Error: GraphQL error: Unable to parse the JSON document: Illegal unquoted character ((CTRL-CHAR, code 10)): has to be escaped using backslash to be included in string value
 at [Source: (String)"{
    "version": "2017-02-28",
    "operation": "PutItem",
    "key": {
        "id": { "S": "5f7a4c6d-eee0-474a-b4ca-2b52e953a8bf"}
    },
    "attributeValues": {
        "name": { "S": "one" },
        "where": { "S": "two" },
        "when": { "S": "2018-02-23T00:15:00Z" },
        "description": { "S": "three
four" }
    }
}"; line: 11, column: 38]
 at [Source: (String)"{
    "version": "2017-02-28",
    "operation": "PutItem",
    "key": {
        "id": { "S": "5f7a4c6d-eee0-474a-b4ca-2b52e953a8bf"}
    },
    "attributeValues": {
        "name": { "S": "one" },
        "where": { "S": "two" },
        "when": { "S": "2018-02-23T00:15:00Z" },
        "description": { "S": "three
four" }
    }
}"; line: 11, column: 38]

When I edit an event in DynamoDB console to have a newline in the description, it properly shows as \n in the console, but the app displays it as a space.

A simple fix would be to escape() before creating and unescape() before displaying.

Ah, I see what you mean. This is a limitation of the request mapping template currently as the result of the evaluated template is expected to be a JSON object that will be used to configure the call to DynamoDB. You can currently pass mutli-line strings through to dynamodb by referencing an argument on the context.
For example if you had this:
{
    "version": "2017-02-28",
    "operation": "PutItem",
    "key": {
        "id": { "S": "5f7a4c6d-eee0-474a-b4ca-2b52e953a8bf"}
    },
    "attributeValues": {
        "name": { "S": "one" },
        "where": { "S": "two" },
        "when": { "S": "2018-02-23T00:15:00Z" },
        "description": { "S": "$ctx.args.description" }
    }
}

You can pass a description with newlines as you might expect. I'll take a note of this and look into the possibility of escaping the evaluated template. Thanks for the feedback!

So what fixed the issue in my case was to escape the value with:
$util.escapeJavaScript()
eg:
"$util.escapeJavaScript($ctx.args.long_description)"


Dynamic Scrolling Grid

Is anyone aware of a dynamic scrolling grid (ie, load from server when x number of results are scrolled to)?  Or in general, a more full featured grid than the example from the website?

Please do not use issues to ask general questions. Use the gitter room or the forum.

Done.  Where is proper place to let people know about a new article/tutorial on Vue?

Any of the above. Or you can tweet mention @vuejs
On Wed, Feb 3, 2016 at 5:52 PM MTyson<EMAIL_ADDRESS>wrote:

Done. Where is proper place to let people know about a new
article/tutorial on Vue?
—
Reply to this email directly or view it on GitHub
https://github.com/vuejs/vue/issues/2292#issuecomment-179515456.


update to gradle 8.1.1 in 2.x branch

Issue #, if available:
Description of changes:

Fix build failures by upgrading to gradle 8.1.1
Change nebula.ospackage to com.netflix.nebula.ospackage gradle scripts
Fix flaky test test history shard settings

CheckList:

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #777 (66ca944) into 2.x (2006631) will increase coverage by 0.75%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff              @@
##                2.x     #777      +/-   ##
============================================
+ Coverage     74.82%   75.57%   +0.75%
+ Complexity     2647     2634      -13
============================================
  Files           337      337
  Lines         15560    15552       -8
  Branches       2402     2252     -150
============================================
+ Hits          11642    11753     +111
+ Misses         2538     2481      -57
+ Partials       1380     1318      -62

see 64 files with indirect coverage changes

Thanks for the change!
Can you run gradle wrapper --gradle-version 8.1.1 to upgrade all the gradle related stuff in the project also

Thanks for the change! Can you run gradle wrapper --gradle-version 8.1.1 to upgrade all the gradle related stuff in the project also

Just uploaded my commit to upgrade gradle wrapper and corrected typo in my commit message. Meanwhile, I think the multi node test workflow is a flaky test, which may sometimes produce unexpected error. I will include the error log in your issue about flaky test later. You can take a look.
Besides, one more code reviewer is required for this pull request. Please help assign one, thanks!

looks good to me, and maybe can also include Fix flaky test test history shard settings into this PR. @bowenlan-amzn could you confirm this is right change for fix flaky test?

Just included this change, please take a look, thanks!

Yes, looks good. Thanks!


HSDS-250 HSDS-254: Faces Survey Component + Updated Thumbs Survey

Jira Issues

https://helpscout.atlassian.net/browse/HSDS-250
https://helpscout.atlassian.net/browse/HSDS-254

Problem/Feature
This PR adds a new MessageCard Survey variation for Microsurveys. It uses the RateAction for the emoji buttons, with the addition of a new xl size in both the RateAction and Emoticon components.
It also includes a few updates to the "selected" state of the Thumbs Survey to be consistent with the new designs.
Check it out:

Faces Survey
Thumbs Survey

Le gif demó:

Guidelines
Make sure the pull request:

[x] Follows the established folder/file structure
[x] Adds unit tests
[x] If it is a refactor or change to an existing component, have you verified it won't break existing Cypress tests or have you updated them?
[x] Did you verify some accessibility (a11y) basics?
[x] Adds/updates stories. Guidelines
[x] Adds/updates documentation (ie proptypes) Guidelines
[x] Has it been tested in Help Scout's supported browsers?
[x] Requests review from designer of the feature
[x] Add label (bug? feature?)

Hi @Charca ! Can you do me a favour and remove this line? It's unrelated to this PR but is a leftover I forgot to remove and it gives the biggest warning ever when running tests... Thanks!

Thank you all for the review! I've made a couple changes so I'm re-requesting review from you all 🙏
@tinkertrain I've included that one-line change to the Tooltip component as well.
@alexestrada that's correct on your first note! The "thank you" message will show up once this is integrated in the Beacon embed-side.
As for the emoji issue, apparently, the position of native emojis is off by a couple pixels on non-retina monitors...

To be fair, I think it's only noticeable because we're showing them inside a circle in a really small font-size, but still! I've added a fix that I think should take care of it!

@alexestrada FYI, I've also included the fix for HSDS-264 in this PR.


[KYUUBI #1449][BACKPORT][FOLLOWUP] Fix import

Why are the changes needed?
Fix import to pass CI
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #1551 (b2f9310) into branch-1.4 (3ff80cf) will increase coverage by 0.00%.
The diff coverage is 69.23%.

@@              Coverage Diff              @@
##             branch-1.4    #1551   +/-   ##
=============================================
  Coverage         59.02%   59.03%
  Complexity          172      172
=============================================
  Files               233      233
  Lines             11999    12014   +15
  Branches           1474     1476    +2
=============================================
+ Hits               7083     7093   +10
- Misses             4314     4320    +6
+ Partials            602      601    -1

Impacted Files
Coverage Δ

.../scala/org/apache/kyuubi/server/KyuubiServer.scala
58.66% <25.00%> (-2.45%)
:arrow_down:

...he/kyuubi/engine/spark/shim/CatalogShim_v2_4.scala
76.19% <50.00%> (-2.15%)
:arrow_down:

...ommon/src/main/scala/org/apache/kyuubi/Utils.scala
66.33% <75.00%> (+0.74%)
:arrow_up:

...apache/kyuubi/ctl/ServiceControlCliArguments.scala
77.91% <80.00%> (+1.69%)
:arrow_up:

.../engine/spark/session/SparkSQLSessionManager.scala
80.95% <100.00%> (+0.46%)
:arrow_up:

...rg/apache/kyuubi/metrics/JsonReporterService.scala
86.66% <100.00%> (ø)

...g/apache/kyuubi/session/KyuubiSessionManager.scala
97.29% <100.00%> (+0.07%)
:arrow_up:

...ache/kyuubi/engine/spark/SparkProcessBuilder.scala
84.00% <0.00%> (-3.00%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
91.00% <0.00%> (+1.00%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22d616...b2f9310. Read the comment docs.


"Your system needs to support tray icon." error on startup

Just installed LANDrop through AUR and getting the above error on launch.
I am on Manjaro Linux with Gnome DE (3.38).
Any pointers on how to fix this?

Install and enable https://aur.archlinux.org/packages/gnome-shell-extension-tray-icons/
LANDrop requires tray icon to work.

Thanks for the quick response!
Doesn't fix my issue unfortunately. I tried logout / login after the installing and even a full system reboot but the error still appears.

Did you enable the plugin?

Thanks, that fixed the issue.


No component rerendering with @preact/signal-react

Hello, I'm having a problem with @preact/signal-react.
Using this code provided by the documentation,
import { useSignal, useComputed, effect } from "@preact/signals-react";

export default function () {
	const count = useSignal(0);
	const double = useComputed(() => count.value * 2);

	effect(()=>{
		console.log(count.value,double.value)
	})

	return (
		<button onClick={() => count.value++}>
			Value: {count.value}, value x 2 = {double.value}
		</button>
	);
}

there is a subscription of the console.log() that re-executes with each change but no rerendering of the component

In which envirement do you using signals? Webpack? Vite? Next.js?

Just as speculation from my time working with Preact Signals, the issue could be because the count.value and double.value in your JSX are not being used in the proper way. Any signal or computed value within the JSX should be inserted without explicitly saying .value. Preact Signals handles the rendering behind the scenes. But as @XantreGodlike asked above, I've noticed Vite and Webpack can have different results at times.

Any signal or computed value within the JSX should be inserted without explicitly saying .value.

Not quite, no. Using .value just opts you out of the direct text node binding, you absolutely can do it though. Just need a full rerender of the component to update.

Just as speculation from my time working with Preact Signals, the issue could be because the count.value and double.value in your JSX are not being used in the proper way. Any signal or computed value within the JSX should be inserted without explicitly saying .value. Preact Signals handles the rendering behind the scenes. But as @XantreGodlike asked above, I've noticed Vite and Webpack can have different results at times.

Omitting .value is fully optional performance optimization. It should work any way

@XantreGodlike
Oops, I should have mentioned. It's on Nextjs; through this increment, we can see that there is an omission.
"use client"
import { effect, signal } from "@preact/signals-react";

const i=signal(0)
setInterval(()=>i.value++,1000)

effect(()=>{
	console.log(i.value)
})

export default function Page () {

	return i
}

@roo7690 use can try my @preact-signals/safe-react with manual subscribing components to signals via HOC. It's not so cool as automatic tracking, but for now I don't know better options for next.js. For now I researching opportunity to migrate babel plugin to swc to make it working with next.js https://github.com/XantreGodlike/preact-signals/issues/43

Did you run yarn start --reset-cache?

Did you changed babel config?

yes I did

same issue with "vite": "^4.5.0" and "@preact/signals-react": "^2.0.0"

same issue

Same issue in Next.js and Vite.

@rschristian Should we add Troubleshooting section to readme? I can provide PR

What would that entail (especially in relation to this issue)?

What would that entail (especially in relation to this issue)?

Components don't track signals
or
Components do not update if signal value changes
or
Lack of component reactivity

For me, the simple vite react typescript template doesnt work with @preact/signal-react 2.0.0, when I switch to 1.3.8 it works as id expect. I have also tried the same thing in a create react app webpack environment. The switch to version 1.38 does resolve the issue.
https://stackblitz.com/edit/vitejs-vite-pj3xda?file=package.json,src%2FApp.tsx&terminal=dev

For me, the simple vite react typescript template doesnt work with @preact/signal-react 2.0.0 using the .value

You haven't followed the v2 usage instructions

For me, the simple vite react typescript template doesnt work with @preact/signal-react 2.0.0 using the .value

You haven't followed the v2 usage instructions

Your right, I missed the babel stuff. Thanks.

Quick solution:
This is probably because you didn't set the babel config.
Solution 1:
Setting the babel config should fix the issue
Solution 2:
Adding the hook useSignals() in the top of the file

Closing as answered.


Fix TuyaDPType.VALUE payload

During the analisys of #1554 I have realized that something was wrong in the MCU logs for the LevelControl.
Comparing the status report from the device against the command send from HA it was clear that something don't work as expected:
2022-10-23 13:57:40.824 DEBUG (MainThread) [zigpy.zcl] [0x6F8F:1:0xef00] Received command 0x01 (TSN 101): get_data(data=
TuyaCommand(status=0, tsn=71, datapoints=[TuyaDatapointData(dp=2, data=TuyaData(dp_type=<TuyaDPType.VALUE: 2>, function=0, raw=b'\xfa\x00\x00\x00', *payload=250))]))

2022-10-23 13:57:41.933 DEBUG (MainThread) [zigpy.zcl] [0x6F8F:1:0xef00] tuya_command:
TuyaCommand(status=0, tsn=97, datapoints=[TuyaDatapointData(dp=2, data=TuyaData(dp_type=<TuyaDPType.VALUE: 2>, function=0, raw=b'\x00\x00\x02\x8a', *payload=2315386880))])

Once identified and the fixed, the tests that validated against the observed value have also had to be fixed.
The fix only affects to the MCU commands sended with a TuyaDPType.VALUE (i.e: current_level for the LevelControl cluster). I can't be a breaking change because the current implementation is wrong. I don't think that could be the reason for some weird behavior in dimmers but I can't validate by myself.

Codecov Report
Base: 83.16% // Head: 83.16% // No change to project coverage :thumbsup:

Coverage data is based on head (7e52934) compared to base (05ee519).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1984   +/-   ##
=======================================
  Coverage   83.16%   83.16%
=======================================
  Files         248      248
  Lines        7819     7819
=======================================
  Hits         6503     6503
  Misses       1316     1316

Impacted Files
Coverage Δ

zhaquirks/tuya/mcu/__init__.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.169%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6503

Relevant Lines:
7819

💛  - Coveralls

Thanks David


Document the certificate shim support for Gateways

I started writing some of the details of how we support the Gateway API in this document:

Preview
https://deploy-preview-640--cert-manager-website.netlify.app/docs/usage/gateway-api/

Before Netlify was enabled on the release-next branch, I would do my own previews with the following:
gsutil mb -b on gs://website-pr-640
rm -rf public
HUGO_UGLYURLS=true hugo
rm -rf /public/*-docs
gsutil -m cp -r public/* gs://website-pr-640
gsutil web set -m index.html gs://website-pr-640
gsutil iam ch allUsers:objectViewer gs://website-pr-640
# Publically available at: https://storage.googleapis.com/website-pr-640/index.html

Suggestion: I found the second diagram here very useful in understanding what is sig-network's recommended way to configure TLS for infra that uses Gateways. Perhaps we could copy paste that into this doc (with a reference)? Not sure if the image is somewhere in GitHub.

I made the changes! You can now take another look.
/unassign
/assign @irbekrm

@irbekrm This PR is good to go. I'm not sure about the annotations yet though, e.g. the gateway-class, but I'll figure that out in the next PR.

@JoshVanL Do you think you can take another look?

/unassign
/assign @JoshVanL

/assign
I'll give it a read

Thank you @wallrj for the review! I added your suggestions.
/unassign
/assign @wallrj

/lgtm

The discussion around discovery vs. feature gate is not done:

https://github.com/cert-manager/website/pull/640#discussion_r682529517

We plan on adding a feature gate for 1.5.0-beta.1, e.g.
--feature-gates=GatewayAPI=true

Currently, the documentation says
FEATURE STATE: cert-manager 1.5 [stable]

I will fix this in #625 before we release 1.5.0-beta.1.
/unhold


[FAB-17270] Create a channel tutorial

Signed-off-by: NIKHIL E GUPTA<EMAIL_ADDRESS>Type of change

Documentation update

Description
The create a channel tutorial as a series of tutorials. This draft PR offers the first two in the series for review

The first is an operational tutorial
The second is a conceptual tutorial
The third will be creating a custom channel

Going to take the draft tag off of this, though will need lots more comment before we can merge. We may want to merge this series one at a time if it is easier.

/azp run

@Mergifyio backport release-2.1


Default Validation is not applied in First Use

I'm submitting a ...  (check one with "x")
[x] bug report => search GitHub for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
Default validation like max length and min length for a text input is not validating while first use but works fine when focus out and re-enter the text.
Expected behavior
Validation should work right from the first use.
Minimal reproduction of the problem with instructions
Please use the below link to reproduce the issue.
https://stackblitz.com/edit/angular-vzcukk
What is the motivation/use case for changing the behavior?
To make this reactive forms more usable.
Please tell us about your environment:

Angular version:
Angular Version - 6.1.X
ngx-formly/core - 4.7.2

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

In all Browsers irrespective of the version.

Language: [all | TypeScript X.X | ES6/7 | ES5] - ES7

Node (for AoT issues): node --version =10

we rely on touched state, I think it can be done using dirty property instead.

Thanks @ugogiordano87 , this works...

@Sanjay10247 it can also be shorter as following:
      validation: {
        show: false,
      },
      expressionProperties: {
        'validation.show': 'model.text && ( ("" + model.text).length >= 5 )'
        },
      }

to have a such behavior globally use custom showError see https://stackblitz.com/edit/angular-npnf5d
export function showError(field: FieldType) {
  return field.formControl && field.formControl.invalid && (field.formControl.dirty || (field.options.parentForm && field.options.parentForm.submitted) || (field.field.validation && field.field.validation.show));
}

@NgModule({
  imports: [
    FormlyModule.forRoot({
      extras: { showError },
      ...
    }),
  ],
})
export class AppModule { }


Adopt Venk's plugins + misc improvements

I plan on deleting my repository soon enough and think these plugins could use a new home. Due to the high number of new plugins in this PR, I have also taken the liberty of going through and categorizing all commands and plugins, and also adding undocumented ones to the readme.
I've tweaked a couple of misc formatting things as well as included links to some lesser-known, but cool plugins from around the community.

Amazing work, thanks!


[AutoPR] azure-kusto/resource-manager

Created to accumulate context: azure-kusto/resource-manager

(message created by the CI based on PR content)

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/azure-kusto/resource-manager/readme.md

Working on generating https://github.com/azure/azure-rest-api-specs/blob/master/specification/azure-kusto/resource-manager/readme.md for you!!!

Build SDK finished and cleaned


⚠ Bofrost.be has degraded performance

In faffccc, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 892 ms

Resolved: Bofrost.be performance has improved in 8399e0d after 16 minutes.


ODSP Post Snapshot Provide If-match Header with Previous Snapshot ID

Enforcing latest snapshot id on snapshot upload
Description
This document describes how a client may specify the id of the latest snapshot when uploading a new container or channel, i.e. when the client is uploading a summary or push is committing the summary,
The client may find out the id of the current latest snapshot by several means, i.e. get latest, summary ack message or via the response to a create snapshot tree call when specifying a container. Below is the example response for the latter:
Container creation response:
{
"id": "bBwAAAAAHAAAA",
"sequenceNumber": 0,
"itemUrl": "https://tenant7b1d82e39de34a88bb230996df041457.spgrid.com/_api/v2.1/drives/b!l8so13roKk6XL6GXmhbFRdlsCJnVWh9MsPsTWBXzkQmZbs8FtA7jQaztQGzSxRDo/items/01KEEVZHGFAHHG7RPI4BHKSDN3A47DLQPW",
"driveId": "b!l8so13roKk6XL6GXmhbFRdlsCJnVWh9MsPsTWBXzkQmZbs8FtA7jQaztQGzSxRDo",
"itemId": "01KEEVZHGFAHHG7RPI4BHKSDN3A47DLQPW",
"itemName": "d2548feb-fd83-4d3b-986d-b40f2ceea892.fluid"
}
Specifying an id during upload
When a client is creating a channel or container tree (client uploading the summary or PUSH committing a summary uploaded by the client), the id property can be specified in an If-Match header.
The format for the If-Match Fluid tag would be (including quotes):
"fluid:=;="
For container id matching, tag type would be containerid and tag value should be the id to match.
Container creation request specifying id (headers only):
POST https://tenant7b1d82e39de34a88bb230996df041457.spgrid.com/_api/v2.1/drive/items/01KEEVZHH7M44UPERWIBBILXE2ZFSRS3OC/opStream/snapshots/snapshot HTTP/1.1
Prefer: bypassodataserializer
If-Match: "fluid:containerid=bBwAAAAAHAAAA"
Accept: /
Authorization: Bearer eyJ0eXA...I5PeB-yokd1_ovwsliR71ML5Yg
X-ExpFeaturesOptIn: 30149
X-ExpFeaturesOptOut: 31255
SPResponseGuid: 4151cc20-c0f9-47cd-937a-a6648cbb2cae
X-TestName: Spo.Test.Large.Fluid.FluidTests.TestCreateContainerWithIdAsync
X-TestOwner: marcmas
X-TestExecutionId: 4151cc20-c0f9-47cd-937a-a6648cbb2cae
Content-Type: application/json; charset=utf-8
Host: tenant7b1d82e39de34a88bb230996df041457.spgrid.com
Content-Length: 235
Expect: 100-continue
https://www.office.com/launch/fluid/content?auth=2&action=edit&drive=b!lql55Wf6D0qBqgrMMcpaiDshzUolNf1DofbCZqkstIk8wHnov-bCQ6pHMry6gSbx&item=016K3AXJCD5PDDJIUTAVBJX2LKBGMZZGN5&file=https:%2F%2Fmicrosoft-my.sharepoint-df.com%2Fpersonal%2Fmarcmas_ntdev_microsoft_com&siteUrl=https:%2F%2Fmicrosoft-my.sharepoint-df.com%2Fpersonal%2Fmarcmas_ntdev_microsoft_com

related to #5771

What will happen, if the If-Match header is set and the value is "undefined"? Will it fail the upload summary call?

@marcmasmsft can you answer that?

If the if-match header contains an empty container id, a 400 error will be returned (invalidrequest), e.g.
If-Match: "fluid:containerid=" --> exception thrown

ok. So I am talking about "undefined" as header and not empty. What will be the response in that case?

I think undefined === emtpy in a header

actually, if the above is the string, then the value you are passing is the string "undefined", which will almost certainly be an error

Yes wanted to confirm as then we should always have the ackHandle for the last summary and need to assert that. I see a case in container attach() where we are passing undefined as ackHandle while uploading summary.

For SPO, undefined would be treated as a string (it's not a special value) so we'd try to match it against the existing handle; this would fail because the id would be in an invalid format (fluidinvalidnodeid)

If we don't have an ackHandle we should not set the header. No need to assert, at least to start with

Yeah, I was thinking about same and then we can go on and fix the other case.

Closing after the PR.


Add support for redirecting to a specific listener

We have a use case where some prefixes need to be redirected from one listener port to another. In most cases this is HTTP -> HTTPS but not always.
The reason this cannot be done with host_redirect is because the redirect needs to use the same hostname the client used when accessing the proxy which is not known statically.
One way I see this can be added is to add listener_redirect option to the routes section which takes as a parameter the name of a listener.
A sample config would look like this:
 static_resources:
  listeners:
  - name: "https"
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 443
  - name: "http"
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 80
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          codec_type: auto
          stat_prefix: ingress_http
          route_config:
            name: local_route
            virtual_hosts:
            - name: backend
              domains:
              - "*"
              routes:
              - match:
                  prefix: "/foo"
                listener_redirect: "https"
          http_filters:
          - name: envoy.router
            config: {}

In this case when a request comes for /foo on port 80 the proxy should return a redirect for the same host the client used but for port 443. The proxy should also switch between http:// and https:// on the redirect based on whether there is TLS enabled on the target listener.
Thanks

@mattklein123
I'm looking into implementing this feature. I've found that I need to assign a new value to final_host in RouteEntryImplBase::newPath. I know that I can get the listener address from the address method of ListenerImpl and that i should extend ListenerManagerImpl to get access to the concrete Listener by its name. Now the problem that I have is - how to get access to the listener manager from InstanceImpl::listenerManager()? What would be the best approach to distribute that information to the RouteEntryImplBase?

@nickolaev from reading back through the issue it's not clear to me that we want to actually implement this. Can you describe the use case in more detail and why a normal redirect can't work?

Looking at the RedirectAction https://github.com/envoyproxy/data-plane-api/blob/c82d27e4e5e8c39e8368b2754c4b8825f5d1e84d/envoy/api/v2/route/route.proto#L626
It looks like it can redirect to:

different hardcoded host
different path
change schema to HTTPS
remove the query

We need to redirect to:

a different schema
on a different port
preserving the original hostname.

Of the available Redirect Actions 3) does what we need for one specific case where we need to switch from HTTP to HTTPS on port 443.
It does not cover the case where HTTPS is on a custom port of when we want to switch to a different schema such as HTTPS -> HTTP or to WS WSS.
Now that I think about it if we just add string schema_redirect and int port_redirect to RedirectAction it would allow to solve our use case.
I assume it is possible to combine more than one RouteAction and Envoy will apply all of them
Thanks

@georgi-d yup exactly. I would just add different redirect types and have a look at whether it makes sense to allow combining them if not allowed already.


tt buckets -> tt bucket

fixedtypos where tt bucket was written as tt buckets

This was actually fixed with https://github.com/textileio/docs/commit/a14ed019ba42df5b715a9bedb7107322806bcdb8. Note that most of those files are actually auto-generated.


Issue when SQL launch profiler extension in Azure Data Studio

Whenever we try to launch the profiler we see the following issue:
Failed to create session: An exception ocurred while executing a Transact-SQL statement or batch.
If we open the console tab we see the following:
[Extension Host ] c:\Program FilesAzure...y\zone-node.js:2280
(node:3928) [DEP005] Deprecation Warning: Buffer () is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead
[Extension Host ] c:\Program FilesAzure...y\zone-node.js:2280
[Error - 03:48:38] Request profiler/createsession failed.
[Extension Host ] c:\Program FilesAzure...y\zone-node.js:2280
Message: Failed to create session: An exception ocurred while executing a Transact-SQL statement or batch.
Code: -2146233088
Failed to create session: An  c:\Program FilesAzure...y\zone-node.js:2280
exception ocurred while executing a Transact-SQL statement or batch.
console.(anonymous function) @ c:\Program FilesAzure...y\zone-node.js:2280

This looks like it may be similar to https://github.com/microsoft/azuredatastudio/issues/18838.  Do you know if you have permissions to create an XEvent session on this server (e.g. are you able to successfully use the XE Profiler from SSMS with this server)?

This looks like it may be similar to #18838. Do you know if you have permissions to create an XEvent session on this server (e.g. are you able to successfully use the XE Profiler from SSMS with this server)?

hello @kburtram, indeed we can create a simple XE event session on SSMS
ON SERVER:

ON DATABASE:

hello @kburtram, so this is an issue and do we expect a fix on June's release

I have the same issue.
I am running this on elastic pool database, not server.
There is no XE Profiler for elastic pool Azure SQL databases.
When I run a script suggested in a an issue from couple of years ago, I get these errors:

Is there a fix for this in Version: 1.38.0 ?
Thanks

Adding option for MAX_MEMORY fixes the issue for me:
WITH (
MAX_MEMORY = 16192 KB,
EVENT_RETENTION_MODE=ALLOW_SINGLE_EVENT_LOSS,
MAX_DISPATCH_LATENCY=5 SECONDS,
MAX_EVENT_SIZE=0 KB,
MEMORY_PARTITION_MODE=PER_CPU,
TRACK_CAUSALITY=ON,
STARTUP_STATE=OFF
)
from Docs:
MAX_MEMORY =size [ KB | MB ]
Specifies the maximum amount of memory to allocate to the session for event buffering. The default is 4 MB.

@iandonov thanks for providing the additional details.  We'll follow-up on why the default memory allocation is insufficient in this case and how best to allow this to be configured in the UI.
@erinstellato-ms fyi, when looking at Profiler session configuration gaps.


CLOWNFISH-59 Refine go other types

Refine the Go bindings for Class, Method, CharBuf, ByteBuf and StringIterator and add tests.
This branch also changes ByteBuf's Cat() to take a Blob rather than another ByteBuf, similar to how CharBuf's Cat() takes a String.

There's a error in a Blob/ByteBuf test. I'll fix and open a new pull request with a few more tweaks.


Fail to repair RAID1 volume

Hi,
I have used this script to set up a RAID1 array (mirrored). I used some old small M.2 drives as testers and have since ordered two bigger drives. I replaced one today, similar to how I have rebuilt RAID1 arrays in the past, just replace a drive the rebuild through the UI. The problem is I cannot get it to work.
Trying to repair the Storage Pool results in an error saying there are no drives that meet the requirements. Clicking the new drive under HDD/SSD doesn't;t let me do anything other than a SSD Cache (for obvious reasons I'm on a DS918+)
Re-running the script only lets me select one drive (the new one) and the script fails to finish.
Synology_M2_volume v1.2.14
DS918+ DSM 7.1.1-42962-5

Using options:
Type yes to continue. Type anything else to do a dry run test.
yes

NVMe M.2 nvme0n1 is Samsung SSD 970 EVO Plus 1TB
No existing partitions on drive

NVMe M.2 nvme1n1 is Samsung SSD 970 EVO Plus 250GB
Skipping drive as it is being used by DSM

Unused M.2 drives found: 1

1) nvme0n1
Select the M.2 drive: 1
You selected nvme0n1

Ready to create volume group on nvme0n1
Type yes to continue. Type anything else to quit.
yes
You chose to continue. You are brave! :)

Using md5 as it's the next available.

Creating Synology partitions on nvme0n1

        Device   Sectors (Version8: SupportRaid)
 /dev/nvme0n11   4980480 (2431 MB)
 /dev/nvme0n12   4194304 (2048 MB)
Reserved size:    260352 ( 127 MB)
Primary data partition will be created.

WARNING: This action will erase all data on '/dev/nvme0n1' and repart it, are you sure to continue? [y/N] y
Cleaning all partitions...
Creating sys partitions...
Creating primary data partition...
Please remember to mdadm and mkfs new partitions.

Creating single drive RAID.
mdadm: Note: this array has metadata at the start and
    may not be suitable as a boot device.  If you plan to
    store '/boot' on this device please ensure that
    your boot-loader understands md/v1.x metadata, or use
    --metadata=0.90
Continue creating array? yes
mdadm: Defaulting to version 1.2 metadata
mdadm: array /dev/md5 started.

Creating a physical volume (PV) on md5 partition
  Physical volume "/dev/md5" successfully created

Creating a volume group (VG) on md5 partition
  /dev/vg5: already exists in filesystem
  Run `vgcreate --help' for more information.

ERROR 5 Failed to create volume group!

And I just put the original drive back in now it's crashed (the one drive not the entire RAID array) and cannot repair due to it being seen as SSD cache only in DSM UI.

I never considered that someone might try to replace an M2 drive to rebuild or expand the RAID. What you wanted to do might have been available from storage manager if you were using DSM 7.2 and you had run https://github.com/007revad/Synology_HDD_db.
Is one of the original small M.2 drives still showing as degraded, or has the whole array crashed?

Just one drive is crashed, the storage pool is still functional. Just trying to prevent having to reinstall a few apps and Docker back on an entirely new storage pool/volume.

I think backing up, then reinstalling a new storage pool/volume may be quickest solution.
It's going to take a while for me to work out how DSM does a RAID repair.

@007revad Thanks for all of the work you've done on your scripts – they're really useful!
I wanted to check in on this issue since I recently had a RAID1 M.2 volume using the official 10G NIC + M.2 adapter card lose a drive. Have you looked at all into allowing a blank disk to be added to an existing volume? If not, I'd be interested in helping get this working if you have some idea of where to start.

@dantrauner
First, make sure your data from the NVMe volume is backed up.
What does the following command return:
sudo synostgpool --auto-repair -h
And this one:
sudo synostgpool --misc --get-pool-info | jq
I only need the nvme section like this:
  {
    "device_type": "shr_without_disk_protect",
    "disks": [
      "nvme1n1"
    ],
    "id": "reuse_2",
    "is_writable": true,
    "num_id": 2,
    "pool_path": "reuse_2",
    "raids": [
      {
        "designedDiskCount": 1,
        "devices": [
          {
            "id": "nvme1n1",
            "slot": 0,
            "status": "normal"
          }
        ],
        "hasParity": false,
        "minDevSize": "493964574720",
        "normalDevCount": 1,
        "raidCrashedReason": 0,
        "raidPath": "/dev/md3",
        "raidStatus": 1,
        "spares": []
      }
    ],
    "size": {
      "total": "489118760960",
      "used": "488565112832"
    },
    "space_path": "/dev/vg2",
    "status": "normal",
    "summary_status": "normal"
  },

@dantrauner
Just now I was able to repair a NVMe RAID 1 storage pool from Storage Manager. For the steps I used to work I need to know a few things about your setup.

What model Synology do you have?
What DSM version is it running?
Are the NVMe drives in internal M.2 slots or in a PCIe M.2 adaptor card? (like a M2D20, M2D18 or E10M20-T1)

Probably 60 seconds before your last reply, I decided to just use this opportunity to practice my DR procedure 😄 I'm bookmarking this and will try to repair next time, but:

RS1221+
DSM 7.2-64570 Update 3
Using an E10M20-T1 card

For future reference I've created a few wiki pages documenting how I repaired my NVMe RAID 1 after replacing a drive.
Repair-M.2-RAID-1-in-internal-M.2-slots
Repair-M.2-RAID-1-in-adaptor-card - Requires the NAS have Internal M.2 slots.
Repair-RAID-via-SSH - I have not tested this method yet...

The following comes from a blog post on how to create the volume manually (which even cites your script @007revad. It's a snippet to get the new nvme drive to show up as an option to repair the failed array. in this case, md3 is the group for your existing storage group and the nvme is referenced by /dev.
https://academy.pointtosource.com/synology/synology-ds920-nvme-m2-ssd-volume/
synopartition --part /dev/nvme1n1 12
mdadm --manage /dev/md3 -a /dev/nvme1n1p3


Documentation Issue Template

Implement a new issue template for documentation-related issues. This template will help users provide detailed and structured information about the documentation that needs to be added or improved. The template should include the following fields:
Documentation Area: Specify the area or section of the documentation that needs attention.
Issue Description: Describe the documentation issue or improvement needed.
Relevant Links: Provide any relevant links, if applicable.
Contribution Confirmation: Confirm that you have read the CONTRIBUTING.md file.

Name: 📃Documentation
About: Document issue or enhancement?
Label: documentation

@jfmartinz Kindly assign me this issue.


Keep errors order for oneOf like anyOf/allOf

Wait, I just noticed that this is basically reverting #95 😓 Unfortunately @gwagner did not add a test at the time (just changed the order of the existing one), so I have to try guessing now...

Okay I have found out: the original issue was #76, and #95 was actually only a workaround that hid the real cause, which was properly fixed in #98 (with tests!), cf https://github.com/justinrainbow/json-schema/pull/98#issuecomment-41925662
So I say this PR is good 😉