HADOOP-16751. Followup: move java import.

This moves the import of a java module to the preferred place in the import ordering.
I know this is minor but it's good to at least try to keep imports under control. If I'd noticed the problem earlier I'd have done the reordering during the commit process.
Change-Id: I1a594e3d954554a72c2b71c954eda0ae940a8f70

followup to #1754

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
23m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 17s
trunk passed

-1 :x:
compile
11m 11s
root in trunk failed.

+1 :green_heart:
checkstyle
0m 45s
trunk passed

+1 :green_heart:
mvnsite
1m 24s
trunk passed

+1 :green_heart:
shadedclient
17m 24s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 30s
trunk passed

+0 :ok:
spotbugs
2m 17s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 13s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
compile
18m 28s
the patch passed

-1 :x:
javac
18m 28s
root generated 194 new + 1674 unchanged - 0 fixed = 1868 total (was 1674)

+1 :green_heart:
checkstyle
0m 55s
the patch passed

+1 :green_heart:
mvnsite
1m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 11s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 25s
the patch passed

+1 :green_heart:
findbugs
2m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 17s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

130m  9s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1799

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f69c38cecfe4 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d1f5976

Default Java
1.8.0_232

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/artifact/out/branch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/artifact/out/diff-compile-javac-root.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/testReport/

Max. process+thread count
1327 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1799/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


options: no need for --installed

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
brew options --installed accomplishes the same as brew options $(brew list).
Removing this option from the list of options for options for consistency (https://github.com/Homebrew/brew/pull/3172#issuecomment-331548135).

People are already relying on this API so it's a much higher bar to remove existing flags than add new ones.


Revisions to check for k2 failures and trigger crash app

if ansible failures occur on up or down, send data to crashapp.
Related:
The crash app: https://github.com/samsung-cnct/k2-crash-application/pull/1
K2-tools integration: https://github.com/samsung-cnct/k2-tools/pull/57

On standby until I get Jenkins building a binary for the crash-app

Added the blocked tag pending k2-tools changes. Please remove the tag when samsung-cnct/k2-tools#57 is merged.

Ready, just waiting on  samsung-cnct/k2-tools#57 to be merged.


Offer approved, accepting. And nothing happens.

So I configured the bot, got it running and now when I send an offer to the bot is says that the offer was approved but doesn't accept it nor decline it:

Here is my log:
[CSGOResort Bot #1 2015-11-04 19:44:24] INFO: Connecting...
[CSGOResort Bot #1 2015-11-04 19:44:24] SUCCESS: Done Loading Bot!
[CSGOResort Bot #1 2015-11-04 19:44:32] ERROR: Login Error: AccountLogonDenied
[CSGOResort Bot #1 2015-11-04 19:44:32] INTERFACE: This account is SteamGuard enabled. Enter the code via the `auth' command.
[CSGOResort Bot #1 2015-11-04 19:44:57] SUCCESS: User Authenticated!
[CSGOResort Bot #1 2015-11-04 19:44:58] SUCCESS: Offer approved, accepting.
[CSGOResort Bot #1 2015-11-04 19:44:58] INFO: Downloading Schema...
[CSGOResort Bot #1 2015-11-04 19:45:00] SUCCESS: Schema Downloaded!
[CSGOResort Bot #1 2015-11-04 19:45:00] SUCCESS: Steam Bot Logged In Completely!
[CSGOResort Bot #1 2015-11-04 19:45:00] INFO: TradeOffer notification
[CSGOResort Bot #1 2015-11-04 19:50:04] INFO: Connecting...
[CSGOResort Bot #1 2015-11-04 19:50:04] SUCCESS: Done Loading Bot!
[CSGOResort Bot #1 2015-11-04 19:50:09] SUCCESS: User Authenticated!
[CSGOResort Bot #1 2015-11-04 19:50:09] INFO: Downloading Schema...
[CSGOResort Bot #1 2015-11-04 19:50:10] SUCCESS: Schema Downloaded!
[CSGOResort Bot #1 2015-11-04 19:50:10] SUCCESS: Steam Bot Logged In Completely!
[CSGOResort Bot #1 2015-11-04 19:53:41] INFO: TradeOffer notification
[CSGOResort Bot #1 2015-11-04 19:53:42] SUCCESS: Offer approved, accepting.

7 days ban

But i tired trading with the bot through steam/chrome and i could so dunno


fix(costmodels): disable assigning assigned source to cost model

closes JIRA ticket COST-54

I am going to open a ticket about this on pf-react as I would assume I could disable a checkbox through the Table API.
What I did here is a workaround -> implemented the selection feature by my own.


Added Ecommerce tracking in Google Analytics

just by settings change you can enable google analytics ecommerce tracking

Codecov Report

:exclamation: No coverage uploaded for pull request head (ga_ecommerce@4503ec2).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83407c...4503ec2. Read the comment docs.


[Bug]: Release Pipeline post steps break when publishing Sphinx docs

Checked for duplicates
Yes - I've already checked
Describe the bug
When running the release pipeline configured to build & publish Sphinx docs, the post always steps fail on invocation of the .ci/scripts/util/cleanup.sh script, indicating no such file or directory. I suspect this is caused by the git step in the Push OPERA PGE HTML documentation to GitHub Pages stage switching the branch of the working dir to gh-pages which lacks the .ci directory.
What did you expect?
I expected the pipeline to run the post steps, cleanup the built images and conda environment, and exit successfully.
Reproducible steps
Run either the release pipeline or the sandbox pipeline on the release Jenkinsfile with the `PUBLISH_DOCS` parameter checked.

Environment
https://opera-pge-ci.jpl.nasa.gov/

Fixed by #470


Add integration tests for all API endpoints.

As part of mbari-org/annosaurus#18, vars needs integration tests against all endpoints.

I create a develop branch in m3-microservices. The basic recipe for working on the integration tests is:

Run the database migration scripts on the testing server fog.
Build local docker images for annosaurus and vampires-squid:

docker buildx build --load  -t mbari/annosaurus:latest .
docker buildx build --load  -t mbari/vampire-squid:latest .

Using the m3-microservices project, run dev_mbari.sh up


Voice Metrics

Hello!
I absolutely love that this is a clean revival of promcord.
I've been looking for something like this for a while.
Do you have any plans to implement voice metrics?
Promcord used to have this, but I know a LOT has changed about what is accessible in the wake of discord analytics.
Let me know- I'm not familiar with the codebase but I'm willing to help and/or test

Hello,
Thanks for your interest ;)
What kind of voices metrics are you interested in ?
Currently, my DC servers has only a few occasional voice speakers, so I didn't look into it
But that indeed could be a nice addition to the project
Or, alternatively, if you have an existing dashboard where I can find "interesting" metrics to gather, that would be useful
Thanks for reaching out! I'll do my best on this

For what metrics- probably:

Total minutes spent in calls globally
Minutes spent in event calls (if possible)
Count of unique users that joined voice
Count of voice channels created

This one is a bit specific to my server- we primarily use dynamically created voice channels.

I don't have working examples of api calls or pycord code, but I can try my hand at it this weekend


[July 2022]: [Fix admin requirements]

Is your feature request related to a problem? Please describe.
NVM has required admin rights for too long.
Describe the solution you'd like
A simple change in the installer can solve it now, because Windows fixed the admin required for symlinks thing several years back.  All that needs to happen is to have the default values for ENV variables NVM_SYMLINK be in the user profile, where special permissions are not needed to modify it in NVM use.
For example, the following values work fine for me, without requiring any sort of elevation:
NVM_HOME                       C:\Users\burt_\AppData\Local\nvm
NVM_SYMLINK                   C:\Users\burt_\AppData\Local\nodejs

I'd submit a PR but I don't understand the Install scripting language features.
Describe alternatives you've considered
Other approaches have been made unnecessary because of the change in Windows regarding SymLink policy.

Please use the reactions to cast a vote in favor of or against this feature suggestion »

Non-admin Windows users still do not have symlink permissions by default. To use symlinks as a non-admin, users have to enable developer mode or be explicitly granted symlink permissions. NVM4W 1.1.9 already supports this. In fact, if you read through the issues, you'll find a lot of users who have requested NVM4W return to the original approach of using the UAT prompt to enforce elevated admin privileges.
Users still need temporary admin privileges to enable developer mode, or it must be assigned by a group policy.
Keep in mind, admin privileges are also used to write to protected directories, such as C:\Program Files.
I do not intend to change this in NVM4W. Instead, it will be addressed in the successor project (Runtime/rt), which is in development right now. I've spent considerable time on this and the change is too big to fit into NVM4W.


Not able to log in to auth enabled setups.

Rancher versions:v1.6-development
Fresh install of rancher-server.
Enable local auth.
As soon as local auth is enabled , user is logged out.
Attempting to log in using the local auth admin user also fails.
UI encounters the following errors:
Request URL:http://<ip>:8080/v2-beta/schemas/region?sort=name
Request Method:GET
Status Code:404 Not Found

Request URL:http://<ip>:8080/v2-beta/localauthconfigs?limit=-1&sort=name
Request Method:GET
Status Code:401 Unauthorized

Rancher versions:v1.6-development
Fresh install of rancher-server.
Enable local auth. User continues to be logged in as the admin user.
Able to logout and login as the admin user.


Feature: Add search feature

This PR introduces a new search feature to the yfinance library that connects the functionality to search for tickers via the Yahoo Finance API.
I am open to further discussion and will be happy to complete the feature if the maintainers agree that this is a right addition to the package.

You can add the feature, just also refactor any existing calls to search API.

Summary

The search functionality has been refactored from a function approach to a class based approach
Refactored other classes that were using search features to now utilize the new Search class.
Added unit tests
Documentation added in README and doc

Usage
import yfinance as yf

# get list of quotes
quotes = yf.Search("AAPL", max_results=10).quotes

# get list of news
news = yf.Search("Google", news_count=10).news

Test
python -m unittest tests.test_search

Looks good. Can you squash the commits? #1084

Done

Is the Search class not in the latest pypi version (0.2.50) ?  I'm getting "Search is not an attribute of yfinance"

Currently just dev branch, release coming soon.


no module named requests

skel@skel:~/Downloads/git/skiptracer$ python skiptracer.py
Traceback (most recent call last):
File "skiptracer.py", line 4, in
from plugins.menus import menus
File "/home/skel/Downloads/git/skiptracer/plugins/menus.py", line 5, in
from plugins.fouroneone_info import FourOneOneGrabber
File "/home/skel/Downloads/git/skiptracer/plugins/fouroneone_info.py", line 5, in
from plugins.base import PageGrabber
File "/home/skel/Downloads/git/skiptracer/plugins/base.py", line 4, in
import requests
ImportError: No module named requests
but module requests is installed

Please see the Python 3.x branch. Active development and bug fixes are taking place there.
Thanks.


Extraction of metrics in all tracts

Can we add a loop to extract metrics (MT, T1, diffusion) in all regions and tracts in the "info_label.txt" file?

Yes, we can certainly to that. I will implement it after we merge #8

Can we update the script to extract the metrics in all tracts ?

sure-- i'll try my best to do it today

how do you want the results? aggregated into a single CSV file, or one CSV file per tract?

Thank you!
A csv file per tract would be more convenient

From: Julien Cohen-Adad @.>
Sent: May 1, 2024 08:40
To: sct-pipeline/spine-park @.>
Cc: Lydia Chougar, Dr @.>; Author @.>
Subject: Re: [sct-pipeline/spine-park] Extraction of metrics in all tracts (Issue #10)
how do you want the results? aggregated into a single CSV file, or one CSV file per tract?
—
Reply to this email directly, view it on GitHubhttps://github.com/sct-pipeline/spine-park/issues/10#issuecomment-2088409245, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFCFJYUBF27CZEGW7CD2ORDZADPETAVCNFSM6AAAAABEAH4QY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGQYDSMRUGU.
You are receiving this because you authored the thread.Message ID: @.***>

Another consideration: some tracts are veeeeeery small (ie: less than a mm2 per axial slice). When considering tracts in isolation, metrics will be more prone to noise, hence if there is a pathology-related effect, it would possibly be non-statistically significant. Whereas when aggregating across tracts, the sensitivity to detect changes statistically will be higher. So my recommendation would be to aggregate tracts instead of studying them in isolation. Aggregation should follow hypotheses in terms of the tracts that are expected to be affected (eg: all descending tracts?)

I'm particularly interested in the intermedio-lateral columns, located in the lateral horns (in green). I'll look at it more in detail.

could you suggest which tracts to aggregate from the info_label.txt

The region that I'm interested (intermedio-lateral columns) should be located in these GM areas (~16 voxels in the axial plane for each side):
32, GM left intermediate zone, PAM50_atlas_32.nii.gz
33, GM right intermediate zone, PAM50_atlas_33.nii.gz
Do you think if it can be studied given the size?
WE can can also look at the GM globally
52, gray matter, 30:35
These could be "control regions":
_51, white matter, 0:29
53, dorsal columns, 0:3
54, lateral funiculi, 4:13
55, ventral funiculi, 14:29
30, GM left ventral horn, PAM50_atlas_30.nii.gz
31, GM right ventral horn, PAM50_atlas_31.nii.gz
34, GM left dorsal horn, PAM50_atlas_34.nii.gz
35, GM right dorsal horn, PAM50_atlas_35.nii.gz
If not too small
4, WM left lateral corticospinal tract, PAM50_atlas_04.nii.gz
5, WM right lateral corticospinal tract, PAM50_atlas_05.nii.gz_

ok great, this is very helpful. Just to clarify, the regions you listed (eg: 32, 33): are you suggesting to merge them? (again, the pros in merging is the better robustness to noise)

I think we can merge right and left (eg: 32 and 33)

Good, so I'll produce the following extraction strategies (one extraction per bullet point):

32,33
52
51
53:55
30,31
34,35
4,5

we can merge 54 and 55, but I would keep 53 separately unless you think it's too small
Sounds good for the rest

I'm also thinking it could be interesting to merge all ascending vs descending tracts

I'm also thinking it could be interesting to merge all ascending vs descending tracts

could you please list the numbers to be included for the ascending vs. descending? that would save me some time 😊

descending: 4 5 8 9 10 11 16 17 18 19 20 21 22 23 24 25 26 27
ascending: 0 1 2 3 6 7 12 13 14 15

Thanks Julien!

Great, here is the updated list:

32,33
52
51
53
54:55
30,31
34,35
4,5
4,5,8,9,10,11,16,17,18,19,20,21,22,23,24,25,26,27
0,1,2,3,6,7,12,13,14,15

Thank you!

@Kaonashi22 can you give it a try with https://github.com/sct-pipeline/spine-park/commit/9ad4422f84001a3f5d70c70b3939dea30538faa8 ?

Using the last version https://github.com/sct-pipeline/spine-park/commit/9ad4422f84001a3f5d70c70b3939dea30538faa8 ?, here is the output I got
DWI_FA.csv
MTR_in_DC.csv
The columns voxels, map and std are empty...
Also, the results corresponding to one subject are on "non-contiguous" rows

https://github.com/sct-pipeline/spine-park/issues/10#issuecomment-2091831202 this error is caused by an issue which I've fixed in https://github.com/spinalcordtoolbox/spinalcordtoolbox/pull/4469. Once it is merged, you can git pull from SCT's master version and from spine-park and the bug should go away.

After doing "git pull" and using the new script (cb51fb6), I still have the same error
err.batch_processing_sub-AM267.log

can you send me:

mtr.nii.gz
label_MT/atlas
label_MT/template/PAM50_levels.nii.gz

[mtr.nii.gz](https://githu
atlas.zip
b.com/sct-pipeline/spine-par
PAM50_levels.nii.gz
k/files/15213535/mtr.nii.gz)

Not sure whether you can open mtr.nii.gz and label_MT/atlas. I'm resending
mtr.nii.gz

atlas.zip

ah! i see, because https://github.com/spinalcordtoolbox/spinalcordtoolbox/pull/4469 is not merged yet-- once it is merged you will be able to do it-- tagging @joshuacwnewton who can inform you once merged--

The first run gave me this error for a few subjects; when I rerun, it works
*** Generating Quality Control (QC) html report ***
Resample images to 0.600000x0.600000 vox
Converting image from type 'uint8' to type 'float64' for linear interpolation
Find the center of each slice
Traceback (most recent call last):
File "/export02/data/lydiac/spinalcordtoolbox/spinalcordtoolbox/scripts/sct_deepseg.py", line 349, in
main(sys.argv[1:])
File "/export02/data/lydiac/spinalcordtoolbox/spinalcordtoolbox/scripts/sct_deepseg.py", line 329, in main
qc2.sct_deepseg(
File "/export02/data/lydiac/spinalcordtoolbox/spinalcordtoolbox/reports/qc2.py", line 339, in sct_deepseg
fig.savefig(img_path, format='png', transparent=True, dpi=300)
The first run gave me this error:
File "/export02/data/lydiac/spinalcordtoolbox/python/envs/venv_sct/lib/python3.9/contextlib.py", line 126, in exit
next(self.gen)
File "/export02/data/lydiac/spinalcordtoolbox/spinalcordtoolbox/reports/qc2.py", line 90, in create_qc_entry
with mutex(name="sct_qc"):
File "/export02/data/lydiac/spinalcordtoolbox/python/envs/venv_sct/lib/python3.9/contextlib.py", line 119, in enter
return next(self.gen)
File "/export02/data/lydiac/spinalcordtoolbox/spinalcordtoolbox/utils/fs.py", line 281, in mutex
semaphore.acquire()
File "/export02/data/lydiac/spinalcordtoolbox/python/envs/venv_sct/lib/python3.9/site-packages/portalocker/utils.py", line 493, in acquire
raise exceptions.AlreadyLocked()
portalocker.exceptions.AlreadyLocked

These columns [vox] | MAP() | STD()  are still empty
DWI_FA_30-31.csv

Just to summarize the 2 different issues:

MTR_in_DC.csv:

IndexError: index 52 is out of bounds
Data was shared in this comment.
Issue was resolved by the SCT PR #4469

DWI_FA_30-31.csv

Empty cells in [vox] | MAP() | STD() columns.
Data has not been shared yet in this issue.
I am a bit confused, as the columns appear to be non-empty in the CSV file you shaed:

Could you clarify what the issue is?

(Other than that I will minimize some of the "Resolved" comments on this issue so that it is a little easier to navigate.)

(I fixed the upload of the initial MTR data, then deleted the re-uploads.)

   Could you clarify what the issue is?

These columns are empty when I open the csv files on the linux station where I'm running the analyses, but visible on my laptop, weird...

Right, the display is correct after changing the separator when opening the csv file, thank you!!

Perfect! I think we can close this issue, then? (Since @jcohenadad previously closed this issue in https://github.com/sct-pipeline/spine-park/commit/9ad4422f84001a3f5d70c70b3939dea30538faa8.)

A few more questions/comments before you close the issue!
-is there a way to order the results by subject and level? I guess they are printed in the order in which they are generated. If not, I can do it manually
-on the screenshot attached, there are values corresponding to "slice 2" (C2 level) on the three dwi chunks; same for "slice 5"  (chunks 1 and 2) and "slice 9" (chunks 2 and 3).

-for some levels, values are equal to zero, but the maps look fine

-is there a way to order the results by subject and level? I guess they are printed in the order in which they are generated. If not, I can do it manually

Yes, exactly. I imagine that this is because of parallel processing + using -append, so the rows are added as they're generated. I think manual ordering is the easiest solution to this.

-on the screenshot attached, there are values corresponding to "slice 2" (C2 level) on the three dwi chunks; same for "slice 5" (chunks 1 and 2) and "slice 9" (chunks 2 and 3).

Ahh, this is very strange. These seem like bugs to me?

for vertlevel 2, I wonder if this has to do with using the value -vert 2:12 but the chunks only have a subsection of the range. (Maybe the code is automatically creating an entry for the first value (2) by default, even if vertlevel 2 is not in the image, which would definitely be a bug.)
for vertlevel 5/9, it seems like those levels are at the interface between chunks 1/2 and chunks 2/3.

-for some levels, values are equal to zero, but the maps look fine

This seems related to the problem above (vertlevels at the start and vertlevels at the interface between the chunks). I have a feeling if we solve the erroneous table entries, then the zero values will go away too.

slice « 2 » is not located at the same physical location (ie absolute scanner coordinates) across chunks

There are different ways to do that, depending on how you are going to use the information, some programatical ways are more optimal than others. To give you an example, here is a syntax:
for chunk in 1 2 3 ; do sct_extract_metric -i sub-BB277_chunk-${chunk}_DWI_moco_FA.nii.gz -l 51 -f label_sub-BB277_chunk-${chunk}_DWI_moco/atlas/ -vert 1:12 -perlevel 1 -vertfile label_sub-BB277_chunk-${chunk}_DWI_moco/template/PAM50_levels.nii.gz -o levels.csv -append 1 ; done

That generates this output file: levels.csv, which lists what levels are present in a chunk, and what are the corresponding slices for each level.

I see on the csv file that some vertebral levels are still extracted from different chunks: for example level 10 from chunks 1 and 3; chunk 1 doesn't cover this level (upper part of the cord)

I see on the csv file that some vertebral levels are still extracted from different chunks: for example level 10 from chunks 1 and 3; chunk 1 doesn't cover this level (upper part of the cord)

can you please share the CSV file and the data so I can reproduce/understand

This is the csv file that you shared here:

That generates this output file: levels.csv, which lists what levels are present in a chunk, and what are the corresponding slices for each level.

If you overlay the chunks on the T2w image, you will notice that chunk 1 is not the top chunk but the middle one, which explains the overlap of vertebral levels in the CSV file:

The reason is because I was working on a dataset that was created before I fixed https://github.com/sct-pipeline/spine-park/issues/16. If you run this in the latest version of the code if should work fine.

Got it, thank you!
Is there a way to add this command "do sct_extract_metric" to the script or I will have to run it at the end?

Is there a way to add this command "do sct_extract_metric" to the script or I will have to run it at the end?

Fixed in ad7a4ba1df751f2ee116efe17f2c3a11b7b70adf. I haven't checked the code so please run in one subject to make sure there is no bug

The code exited with this error: FileNotFoundError: [Errno 2] No such file or directory: '/dagher/dagher11/lydia11/SPINE_park/Test_1505/data_processed/sub-AM267/dwi/sub-AM267_chunk-1_DWI_moco/template/PAM50_levels.nii.gz'
I think the actual name of the folder it's looking for is label_sub-AM267_chunk-1_DWI_moco
Chunks 2 and 3 were not processed.
err.batch_processing_sub-AM267.log

Sorry about that-- it is now fixed in ecd02d1. I tested the code and it runs on my end.

Thank you! I'm testing the new version

Using the last version of the script, I got these results. There is a level 2 for the three chunks, but only chunk 1 has values as expected (zero for chunks 2 and 3). Is there a reason?
For this specific subject, chunks 1 and partially 2 cover level 4, but together they fully cover it. Should I take the mean of the values in the two chunks?

Using the last version of the script, I got these results. There is a level 2 for the three chunks, but only chunk 1 has values as expected (zero for chunks 2 and 3). Is there a reason?

https://github.com/sct-pipeline/spine-park/issues/35

For this specific subject, chunks 1 and partially 2 cover level 4, but together they fully cover it. Should I take the mean of the values in the two chunks?

Discussion opened here: https://github.com/sct-pipeline/spine-park/issues/14


Can't adopt MX records into Terraform

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.3.7
on windows_amd64

provider registry.terraform.io/cloudflare/cloudflare v3.33.1

Affected resource(s)
cloudflare_record
Terraform configuration files
resource "cloudflare_record" "terraform_managed_resource_55a00009eb46e38e0bb13f144bed9427" {
  name     = "mydomain.com"
  priority = 20
  proxied  = false
  ttl      = 1
  type     = "MX"
  value    = "mx1.provider.co.uk"
  zone_id  = "<ZONEID>"
}

resource "cloudflare_record" "terraform_managed_resource_f38fa8db0dba5220f05e8d7130d90ce5" {
  name     = "mydomain.com"
  priority = 10
  proxied  = false
  ttl      = 1
  type     = "MX"
  value    = "mx0.provider.co.uk"
  zone_id  = "<ZONEID>"
  allow_overwrite = true
}

Link to debug output
https://gist.github.com/arricc/49c20f48c347b5e7e92a99b660e32f68
Panic output
No response
Expected output
MX records adopted by Terraform
Actual output
If I add allow_overwrite = true, then I get the error
"Error: attempted to override existing record however didn't find an exact match"
If I don't add allow_overwrite, I get
"Error: expected DNS record to not already be present but already exists"
Included both in the example TF and log.
Steps to reproduce
Created a zone.tf file with code generated by cf-terraforming
Add allow-overwrite = true to the records.
Plan run ok
Apply fails
Additional factoids
No issues with A, CNAME, SRV or TXT records.
Have also tried using a data stanza with priority and target, but get a different error: failed to create DNS record: DNS Validation Error (1004)
References
No response

why are you trying to overwrite and not import the resources?

you should take a look at https://blog.cloudflare.com/cloudflares-partnership-with-hashicorp-and-bootstrapping-terraform-with-cf-terraforming/ as it seems like you're attempting to create/overwrite resources when you actually want to be importing them.


Support Plan

Completed

[x] Support text synchronization
[x] Support code completion
[x] Support code navigation
[x] Support code refactoring
[x] Support code formatting since 2023.3
[x] Support code diagnostics
[x] Support document hover since 2023.3.2
[x] Support execute command since 2024.1 EAP6
[x] Optimize highlighting

In Progress

[ ] Support symbol search
[ ] Plugin system
[ ] References

Maybe

[ ] Debugger

@CppCXY the "In Progress" section mention the "Support symbol search" this means the .luarc.json file with some libraries defined doesn't work?
For me is not working. Maybe you want me to open an issue

his feature is used to find symbols in the double shift search in intellij. The reading and watching of .luarc entirely depends on luals itself. If it doesn't work correctly for you, you can check the configuration documentation in the wiki of luals.

this feature is used to find symbols in the double shift search in intellij. The reading and watching of .luarc entirely depends on luals itself. If it doesn't work correctly for you, you can check the configuration documentation in the wiki of luals.

I tried to search why is not working. I'm using Rider IDE and I just opened a folder containing Lua files, then I created the luarc json file and added the "workspace.library" setting but it doesn't suggest anything.
Can you guide me or how can I know if the LuaLS is loading the luarc file?

it work well for me.
Is it an operating system issue that you can't really start luals? You can check if you have the lua-language-server process running.


fix(manifest): preserve pure css chunk assets

Description
fix #14244
pureCssChunk will be removed totally with its importedAssets. Thus these importedAssets would be orphaned in the manifest.json.
This PR tries to preserve these importedAssets via attaching them with pureCssChunk's emitted css.

Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Read the Pull Request Guidelines and follow the PR Title Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Can you help check this PR in svelte-kit? Thanks @benmccann

I wonder if it's possible to handle when removing the pure CSS chunk.
https://github.com/vitejs/vite/blob/66a97bec6ea66e1fd9a4e047c3d47d65a9077647/packages/vite/src/node/plugins/css.ts#L768-L775

I wonder if it's possible to handle when removing the pure CSS chunk.

Yeah ,that would be more simple 👍

Can you help check this PR in svelte-kit? Thanks @benmccann

Yes, I see SvelteKit generating the preload header tags when linked against this PR. Thank you so much for fixing this!!

/ecosystem-ci run

Looks like the ones that passed in main also passed here.


Testcafe WebSocket connection closed with Chrome 130

What is your Scenario?
Running Testcafe with Chrome 130.0.6723.58
See my Github Repo https://github.com/JaegerJens/testcafe-chrome-130
What is the Current behavior?
Error: WebSocket connection closed
What is the Expected behavior?

Complete reproduction in https://github.com/JaegerJens/testcafe-chrome-130
Your complete test report

<EMAIL_ADDRESS>test
export DEBUG=testcafe:,hammerhead: && testcafe chrome tests/example.test.js

2024-10-17T06:09:13.779Z testcafe:cli
[
'~/.nvm/versions/node/v20.17.0/bin/node',
'~/tmp/testcafe-bug-reproduction/node_modules/testcafe/lib/cli',
'chrome',
'tests/example.test.js'
]
2024-10-17T06:09:13.783Z testcafe:cli
{
clientScripts: [],
v8Flags: undefined,
listBrowsers: false,
browsers: [
'chrome'
],
src: [
'tests/example.test.js'
],
filter: undefined,
screenshots: {},
reporter: []
}
2024-10-17T06:09:13.783Z testcafe:version 3.6.2
2024-10-17T06:09:13.784Z testcafe:configuration Unable to find the "~/tmp/testcafe-bug-reproduction/.testcaferc.js" configuration file. Error details:
Error: ENOENT: no such file or directory, stat '~/tmp/testcafe-bug-reproduction/.testcaferc.js'
2024-10-17T06:09:13.784Z testcafe:configuration Unable to find the "~/tmp/testcafe-bug-reproduction/.testcaferc.json" configuration file. Error details:
Error: ENOENT: no such file or directory, stat '~/tmp/testcafe-bug-reproduction/.testcaferc.json'
2024-10-17T06:09:13.784Z testcafe:configuration Unable to find the "~/tmp/testcafe-bug-reproduction/.testcaferc.cjs" configuration file. Error details:
Error: ENOENT: no such file or directory, stat '~/tmp/testcafe-bug-reproduction/.testcaferc.cjs'
2024-10-17T06:09:14.142Z testcafe:reporter begin dispatchToPlugin method: init
[ '3.6.2' ]
2024-10-17T06:09:14.142Z testcafe:reporter end dispatchToPlugin method: init
2024-10-17T06:09:14.144Z testcafe:runner
TestCafeConfiguration {
_options: {
developmentMode: Option {
name: 'developmentMode',
value: false,
source: 'Configuration'
},
isCli: Option {
name: 'isCli',
value: true,
source: 'Input'
},
hostname: Option {
name: 'hostname',
value: undefined,
source: 'Input'
},
port1: Option {
name: 'port1',
value: 44023,
source: 'Input'
},
port2: Option {
name: 'port2',
value: 43049,
source: 'Input'
},
ssl: Option {
name: 'ssl',
value: undefined,
source: 'Input'
},
retryTestPages: Option {
name: 'retryTestPages',
value: false,
source: 'Configuration'
},
cache: Option {
name: 'cache',
value: undefined,
source: 'Input'
},
configFile: Option {
name: 'configFile',
value: undefined,
source: 'Input'
},
disableHttp2: Option {
name: 'disableHttp2',
value: false,
source: 'Configuration'
},
v8Flags: Option {
name: 'v8Flags',
value: undefined,
source: 'Input'
},
disableCrossDomain: Option {
name: 'disableCrossDomain',
value: false,
source: 'Configuration'
},
esm: Option {
name: 'esm',
value: undefined,
source: 'Input'
},
proxy: Option {
name: 'proxy',
value: undefined,
source: 'Input'
},
proxyBypass: Option {
name: 'proxyBypass',
value: undefined,
source: 'Input'
},
src: Option {
name: 'src',
value: [Array],
source: 'Input'
},
tsConfigPath: Option {
name: 'tsConfigPath',
value: undefined,
source: 'Input'
},
browsers: Option {
name: 'browsers',
value: [Array],
source: 'Input'
},
reporter: Option {
name: 'reporter',
value: undefined,
source: 'Input'
},
concurrency: Option {
name: 'concurrency',
value: 1,
source: 'Configuration'
},
filter: Option {
name: 'filter',
value: undefined,
source: 'Input'
},
videoPath: Option {
name: 'videoPath',
value: undefined,
source: 'Input'
},
videoOptions: Option {
name: 'videoOptions',
value: undefined,
source: 'Input'
},
videoEncodingOptions: Option {
name: 'videoEncodingOptions',
value: undefined,
source: 'Input'
},
screenshots: Option {
name: 'screenshots',
value: [Object],
source: 'Input'
},
appCommand: Option {
name: 'appCommand',
value: undefined,
source: 'Input'
},
appInitDelay: Option {
name: 'appInitDelay',
value: 1000,
source: 'Configuration'
},
clientScripts: Option {
name: 'clientScripts',
value: undefined,
source: 'Input'
},
compilerOptions: Option {
name: 'compilerOptions',
value: [Object],
source: 'Input'
},
debugMode: Option {
name: 'debugMode',
value: false,
source: 'Configuration'
},
debugOnFail: Option {
name: 'debugOnFail',
value: false,
source: 'Configuration'
},
skipUncaughtErrors: Option {
name: 'skipUncaughtErrors',
value: false,
source: 'Configuration'
},
stopOnFirstFail: Option {
name: 'stopOnFirstFail',
value: false,
source: 'Configuration'
},
takeScreenshotsOnFails: Option {
name: 'takeScreenshotsOnFails',
value: false,
source: 'Configuration'
},
disablePageCaching: Option {
name: 'disablePageCaching',
value: false,
source: 'Configuration'
},
disablePageReloads: Option {
name: 'disablePageReloads',
value: false,
source: 'Configuration'
},
disableScreenshots: Option {
name: 'disableScreenshots',
value: false,
source: 'Configuration'
},
disableMultipleWindows: Option {
name: 'disableMultipleWindows',
value: false,
source: 'Configuration'
},
selectorTimeout: Option {
name: 'selectorTimeout',
value: 10000,
source: 'Configuration'
},
assertionTimeout: Option {
name: 'assertionTimeout',
value: 3000,
source: 'Configuration'
},
pageLoadTimeout: Option {
name: 'pageLoadTimeout',
value: 3000,
source: 'Configuration'
},
speed: Option {
name: 'speed',
value: 1,
source: 'Configuration'
},
disableNativeAutomation: Option {
name: 'disableNativeAutomation',
value: false,
source: 'Configuration'
},
experimentalMultipleWindows: Option {
name: 'experimentalMultipleWindows',
value: false,
source: 'Configuration'
},
skipJsErrors: Option {
name: 'skipJsErrors',
value: false,
source: 'Configuration'
}
},
_defaultPaths: [
'~/tmp/testcafe-bug-reproduction/.testcaferc.js',
'~/tmp/testcafe-bug-reproduction/.testcaferc.json',
'~/tmp/testcafe-bug-reproduction/.testcaferc.cjs'
],
_filePath: '~/tmp/testcafe-bug-reproduction/.testcaferc.js',
_overriddenOptions: [],
_isExplicitConfig: false
}
2024-10-17T06:09:14.153Z testcafe:hammerhead:proxy:router register route GET /hammerhead.js
2024-10-17T06:09:14.157Z testcafe:hammerhead:proxy:router register route GET /transport-worker.js
2024-10-17T06:09:14.157Z testcafe:hammerhead:proxy:router register route GET /worker-hammerhead.js
2024-10-17T06:09:14.158Z testcafe:hammerhead:proxy:router register route GET /messaging
2024-10-17T06:09:14.158Z testcafe:hammerhead:proxy:router register route POST /messaging
2024-10-17T06:09:14.158Z testcafe:hammerhead:proxy:router register route OPTIONS /messaging
2024-10-17T06:09:14.158Z testcafe:hammerhead:proxy:router register route GET /task.js
2024-10-17T06:09:14.158Z testcafe:hammerhead:proxy:router register route GET /iframe-task.js
2024-10-17T06:09:14.160Z testcafe:hammerhead:proxy:router register route GET /browser/connect/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/heartbeat/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/idle/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/idle-forced/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/status/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/status-done/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/init-script/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /browser/init-script/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/active-window-id/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /browser/active-window-id/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /browser/ensure-window-in-native-automation/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /browser/close-window/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /browser/open-file-protocol/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /browser/dispatch-native-automation-event/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /parse-selector/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route POST /browser/dispatch-native-automation-event-sequence/{id}
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/connect
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /browser/connect/
2024-10-17T06:09:14.161Z testcafe:hammerhead:proxy:router register route GET /service-worker.js
2024-10-17T06:09:14.162Z testcafe:hammerhead:proxy:router register route GET /browser/assets/index.js
2024-10-17T06:09:14.162Z testcafe:hammerhead:proxy:router register route GET /browser/assets/styles.css
2024-10-17T06:09:14.162Z testcafe:hammerhead:proxy:router register route GET /browser/assets/logo.svg
2024-10-17T06:09:14.162Z testcafe:hammerhead:proxy:router register route GET /about:error
2024-10-17T06:09:14.162Z testcafe:hammerhead:proxy:router register route GET /testcafe-core.js
2024-10-17T06:09:14.162Z testcafe:hammerhead:proxy:router register route GET /testcafe-driver.js
2024-10-17T06:09:14.163Z testcafe:hammerhead:proxy:router register route GET /testcafe-legacy-runner.js
2024-10-17T06:09:14.163Z testcafe:hammerhead:proxy:router register route GET /testcafe-automation.js
2024-10-17T06:09:14.164Z testcafe:hammerhead:proxy:router register route GET /testcafe-ui.js
2024-10-17T06:09:14.164Z testcafe:hammerhead:proxy:router register route GET /testcafe-ui-sprite.png
2024-10-17T06:09:14.165Z testcafe:hammerhead:proxy:router register route GET /testcafe-ui-sprite.svg
2024-10-17T06:09:14.165Z testcafe:hammerhead:proxy:router register route GET /favicon.ico
2024-10-17T06:09:14.165Z testcafe:hammerhead:proxy:router register route GET /testcafe-ui-styles.css
2024-10-17T06:09:14.182Z testcafe:utils:temp-directory Found temp directories: []
2024-10-17T06:09:14.183Z testcafe:utils:temp-directory Temp directory path:  /tmp/testcafe/chrome-profile-517756O8rQiQYDMXQ
2024-10-17T06:09:14.220Z testcafe:bootstrapper tests compilation took 39 ms
2024-10-17T06:09:14.239Z testcafe:browser-tools:open '"/usr/bin/google-chrome-stable" --remote-debugging-port=34973 --user-data-dir=/tmp/testcafe/chrome-profile-517756O8rQiQYDMXQ --disable-popup-blocking --disable-infobars --disable-session-crashed-bubble --no-first-run --new-window --disable-background-networking --disable-ipc-flooding-protection --disable-background-timer-throttling --disable-backgrounding-occluded-windows --autoplay-policy=no-user-gesture-required "http://localhost:44023/browser/connect/zGpj5eI" 0<&- >/dev/null 2>&1 &'
2024-10-17T06:09:14.671Z testcafe:browser:connection:zGpj5eI status changed to 'ready'
2024-10-17T06:09:15.796Z testcafe:browser:provider:built-in:chrome:browser-client:zGpj5eI CDP method 'PageEnable' took 1.58 ms
2024-10-17T06:09:15.798Z testcafe:native-automation starting
2024-10-17T06:09:15.954Z testcafe:browser:connection:zGpj5eI Error: Unable to open the "chrome:" browser due to the following error:
Error: WebSocket connection closed
at ~/tmp/testcafe-bug-reproduction/node_modules/chrome-remote-interface/lib/chrome.js:94:35
at Chrome._handleConnectionClose (~/tmp/testcafe-bug-reproduction/node_modules/chrome-remote-interface/lib/chrome.js:256:13)
at WebSocket. (~/tmp/testcafe-bug-reproduction/node_modules/chrome-remote-interface/lib/chrome.js:243:22)
at WebSocket.emit (node:events:519:28)
at WebSocket.emit (node:domain:488:12)
at WebSocket.emitClose (~/tmp/testcafe-bug-reproduction/node_modules/ws/lib/websocket.js:246:10)
at Socket.socketOnClose (~/tmp/testcafe-bug-reproduction/node_modules/ws/lib/websocket.js:1150:15)
at Socket.emit (node:events:519:28)
at Socket.emit (node:domain:488:12)
at TCP. (node:net:339:12)
at BrowserConnection._runBrowser (~/tmp/testcafe-bug-reproduction/node_modules/testcafe/src/browser/connection/index.ts:291:32)
2024-10-17T06:09:15.954Z testcafe:browser:connection:zGpj5eI status changed to 'closing'
ERROR Unable to open the "chrome:" browser due to the following error:
Error: WebSocket connection closed
at ~/tmp/testcafe-bug-reproduction/node_modules/chrome-remote-interface/lib/chrome.js:94:35
at Chrome._handleConnectionClose (~/tmp/testcafe-bug-reproduction/node_modules/chrome-remote-interface/lib/chrome.js:256:13)
at WebSocket. (~/tmp/testcafe-bug-reproduction/node_modules/chrome-remote-interface/lib/chrome.js:243:22)
at WebSocket.emit (node:events:519:28)
at WebSocket.emit (node:domain:488:12)
at WebSocket.emitClose (~/tmp/testcafe-bug-reproduction/node_modules/ws/lib/websocket.js:246:10)
at Socket.socketOnClose (~/tmp/testcafe-bug-reproduction/node_modules/ws/lib/websocket.js:1150:15)
at Socket.emit (node:events:519:28)
at Socket.emit (node:domain:488:12)
at TCP. (node:net:339:12)
Type "testcafe -h" for help.
Screenshots
No response
Steps to Reproduce

git clone https://github.com/JaegerJens/testcafe-chrome-130.git
npm install
npm run test

TestCafe version
3.6.2
Node.js version
v20.17.0
Command-line arguments
testcafe chrome tests/example.test.js
Browser name(s) and version(s)
Version 130.0.6723.58 (Official Build) (64-bit)
Platform(s) and version(s)
Ubuntu 24.04.1 LTS Release: 24.04
Other
No response

I'm currently facing the same problem... which can be solved using the --disable-native-automation flag, but when using this flag, I'm randomly getting 500 errors when downloading assets.

Also facing the same issue. We added the flag --disable-native-automation which fixed it to an extent. Issue still persist in a different environment though.

Same error here with Windows 10, Chrome 130.0.6723.59 and Testcafe 3.5.0. Appeared with the update of Chrome.
--disable-native-automation works for me, but with the known problems (flaky tests) why we & others switched to native-automation.

Hello,
This issue was already fixed here: https://github.com/DevExpress/testcafe/issues/8286.
I will close this issue as a duplicate.

@Bayheck great that this has been fixed in master but do you have any idea when 3.7.0-rc.1 will be published?
Until then we cannot use the fix.

Hello,
We published 3.7.0-rc.1.
Please take a look.

@Bayheck
After testing the new RC, I encountered a new issue: I’m unable to log in because I can’t interact with the page elements. The elements are detected, but I’m unable to type in or click them. Has anyone else experienced this?

Please create a separate ticket using this template and also share a Minimal Working Example in that ticket so that the TestCafe team can research the issue and help you.

@Bayheck After testing the new RC, I encountered a new issue: I’m unable to log in because I can’t interact with the page elements. The elements are detected, but I’m unable to type in or click them. Has anyone else experienced this?

Has there been a new issue created on this? I am experiencing the same.

@Bayheck After testing the new RC, I encountered a new issue: I’m unable to log in because I can’t interact with the page elements. The elements are detected, but I’m unable to type in or click them. Has anyone else experienced this?

i added a ticket for the issue described in my comment above #8308

I am now experiencing this issue on 3.7.0-rc.2

Hello, please take a look at my response here https://github.com/DevExpress/testcafe/issues/8312.


common: support checking custom types

Fixes #1467
In use:
if (common.util.isCustomType(image, 'storage/file')) {
  // ...
}

I used the constructor @alias strings as the canonical name for a class.

LGTM!

Changes Unknown when pulling aee15bd0ca29b10ce56f6fcd3c1b81d3b53b070d on stephenplusplus:spp--1467 into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling aee15bd0ca29b10ce56f6fcd3c1b81d3b53b070d on stephenplusplus:spp--1467 into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling aee15bd0ca29b10ce56f6fcd3c1b81d3b53b070d on stephenplusplus:spp--1467 into ** on GoogleCloudPlatform:master**.


Image validation fails on valid images

Not sure which of these is the problem. But I'm finding that some valid images are not passing validation. I think it might be a mime type mismatch on the server, or maybe it's the inclusion of charset=UTF8. For example:
In my model:
attachment :attachment, type: :image

Example 1:

Filename: .jpg
Mime type: image/jpeg
Response header: Content-Type: image/png;charset=UTF-8
URL: http://blogs.scientificamerican.com/blogs/cache/file/8197CEC8-990D-4905-AE984685E38CA6BF_agenda.jpg?w=600&h=335

Example 2:

Filename: .png
Mime type: image/jpeg
Response header: Content-Type: image/jpeg; charset=utf-8
URL: https://www.asus.com/media/global/products/tlvlZTN8Y0VoKyiB/P_setting_fff_1_90_end_600.png

I've seen the same, not sure why. I don't think this rather excellent gem is maintained anymore or as often as needed.

Closed by #569.


:adhesive_bandage: Add temporary additional VPC cidr to core-shared-services live_data VPC

User Story
As a Modernisation Platform Engineer
I want to temporarily extend the address ranges in the core-shared-services live_data VPC
So that a specific customer can deploy infrastructure which can connect to MOJ on-premise resources.
Value / Purpose
As part of their work to deploy domain controllers to extend domain trust between their applications on the modernisation platform and MOJ on-premise resources a pair of domain controllers were created in the core-shared-services account in the live_data VPC.
We found that return traffic could not reach the Modernisation Platform because the address ranges for our core VPCs are not being advertised internally to the MOJ. As a temporary change while we wait for these ranges to be advertised, we propose to add an additional CIDR block to core-shared-services that the DCs can be redeployed into.
Ideally we would put this into a single .tf file where it is made clear that this will not be kept for a long duration.
Useful Contacts
@dms1981, @drobinson-moj
Additional Information
This ticket should cover the following:

Assuming an empty cidr block from our cidr-allocation spreadsheet in the live data range
Assigning the cidr block to live-data in core-shared-services
Creating subnets
Creating & associating route tables & route table entries with the subnets
Creating & associating NACLs to the subnets
Confirming that the additional_cidrs/additional_vpcs behaviour on NACLs in environments-networks/*.json allows east-west traffic for this new VPC as it will presently be blocked
Confirm that the additional cidr block is propagated into the MP TGW route tables (live_data and inspection?)
Confirming that the MOJ TGW has routes for return traffic.

Proposal / Unknowns
No response
Definition of Done

[x] New address range & resources created
[x] New address range reachable from other MP VPCs
[x] New address range reachable from internal MOJ networks
[x] Another team member has reviewed
[x] Defensive tests pass

Confirming that the additional_cidrs/additional_vpcs behaviour on NACLs in environments-networks/*.json allows east-west traffic for this new VPC as it will presently be blocked.

I looked into this and I don't think it's going to work. From the code, it appears that it uses a data call which looks for VPCs inside the same account (eg, core-vpc-development), and as core-shared-services is outside of this range then we'll fall foul of the deny east/west traffic rule.

I've added a new temporary address range & subnets with appropriate route tables and ACLs, and a few other small pieces to make the new address range usable in the same manner as the existing address range. There might be things that have been missed, but this should enable customers to deploy infrastructure so that we can see what's missing rather than guessing.


Compilation error for new Console Applications

When the TinyOrm Nuget package is added to a new Console Application the following compilation errors appears:
error CS1705: Assembly 'SecurityDriven.TinyORM' with identity 'SecurityDriven.TinyORM, Version=1.1.6701.26060, Culture=neutral, PublicKeyToken=e58a6d9408783005' uses 'System.Threading.Tasks.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' which has a higher version than referenced assembly 'System.Threading.Tasks.Extensions' with identity 'System.Threading.Tasks.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
The workaround is to add the "'System.Threading.Tasks.Extensions" Nuget package.

The Nuget for v1.1.6701.26060 clearly states that there is a dependency on  System.Threading.Tasks.Extensions (>= 4.3.0). If you have an older v4.1 Tasks.Extensions assembly, upgrading to a newer version fixes your compilation error.

Updated Nuget v1.1.6848.28993 has been released. It references newer dependencies and fixes the mismatching versions. Thanks for reporting the issue.

Thank you!


Wrong version parsing with number in name

If libraries have a number in their name, they get parsed as part of the version.
lastversion.lastversion - INFO - Verbose 1 level output.
lastversion.ProjectHolder - INFO - Using cache directory: C:\Users\dan\AppData\Local\lastversion\lastversion\Cache.
lastversion.ProjectHolder - INFO - Created instance of GitHubRepoSession
lastversion.GitHubRepoSession - INFO - Using API token.
lastversion.GitHubRepoSession - INFO - Got HTTP status code 200 from https://github.com/libssh2/libssh2/releases.atom
lastversion.GitHubRepoSession - INFO - Checking tag libssh2-1.10.0
lastversion.ProjectHolder - INFO - Sanitizing string libssh2-1.10.0 as a satisfying version.
lastversion.ProjectHolder - INFO - Parsed as Version OK. String representation: <IP_ADDRESS>.

I was expecting that the representation should be 1.10.0 instead of <IP_ADDRESS>.

Was fixed in v3.0.0

Thanks @dvershinin!!


Menus cannot be opened with long reach

Describe the bug
Menus of containers such as chests and furnaces cannot be opened when interacting at a reach distance further than the default
Reproduction steps

Place a chest
Apply the long reach effect
Position yourself on the edge of the reach distance
Interact with chest

Expected behavior
Menus should open and be interactable like they are at the default reach distance
Environment:

Minecraft version: 20w49a
Loader version: 0.10.8
Mod version: 1.0.0

Additional context
Related issue: https://github.com/JamiesWhiteShirt/reach-entity-attributes/issues/7

Fixed in:
https://github.com/ChloeDawn/BeaconOverhaul/releases/tag/1.2.0%2B1.17 https://www.curseforge.com/minecraft/mc-mods/beaconoverhaul/files/3183554
https://github.com/ChloeDawn/BeaconOverhaul/releases/tag/1.2.0%2B1.16 https://www.curseforge.com/minecraft/mc-mods/beaconoverhaul/files/3183556

Fixed in:
https://github.com/ChloeDawn/BeaconOverhaul/releases/tag/1.2.0%2B1.17 https://www.curseforge.com/minecraft/mc-mods/beaconoverhaul/files/3183554
https://github.com/ChloeDawn/BeaconOverhaul/releases/tag/1.2.0%2B1.16 https://www.curseforge.com/minecraft/mc-mods/beaconoverhaul/files/3183556


Maint: Fix sporadic QtDims garbage collection failures by converting some stray references to weakrefs

As far as I can tell this is due to issue with garbage collection issue
between the worker and thread. Mostly between the garbage collection and
the worker cleanup if the last reference to the thread is set to None
and collected while the thread is still active it causes a crash.
This has two side:

changes to make this crash more reliably, by removing unused
reference to the thread, and using weakrefs to make sure we free up
things faster. Freeing things faster mean we crash more reliably.
actually fix the cleanup to be done after thread termination and not
worker termination. Due to 1) we are more confident this fixes
things.

In particular, the animation thread, has a worker that refers to the
dims via a callback/slot.
We also remove the local reference to thread, to make sure there is not
a standing, unused reference to thread, thus self._animation_thread will
be the last standing reference.
That is to say we currently have:

worker stop

delete last thread reference
(if GC, crash)

Thread stops.

Now we have

worker stop
Thread stops.

delete last thread (and worker) reference

This should fix some issues with thread/garbage collection/cycle (#5443)

I'm not totally sure this is correct, like does the thread always stop once the worker stops ?
I think that having to deal with both the thread and worker is likely confusing, and we may want to have to deal with a single object (worker+thread), and make sure that calling stop on it, just stops everything.

I don't fully understand the issues very well here, but (based on the conversation in #5443, nice work! I'll let @Czaki review as he is our local thread guru. 😅 Thank you both! 🙏

Oh, btw, before merge, could we rename the PR to something more concrete, e.g., "Fix sporadic QtDims garbage collection failures by converting some stray references to weakrefs"? And try to capture some of the broader narrative in the commit message — @andy-sweet pointed out that longer commit messages (e.g. copying the whole description into the commit message) make it much nicer to investigate issues later, sometimes saving a few round trips between the terminal and the browser.

Not sure how much context/background you need, but hope these are helpful.

I'm not totally sure this is correct, like does the thread always stop once the worker stops ?

superqt's new_worker_qthread, which is what AnimationWorker uses to create the worker and thread. Based on the superqt implementation, the thread object will emit its finished signal after the worker emits its finished signal, and will do so the main event loop.
So the answer to your question is yes, but it might take a little time depending on how busy the main event loop is at the time.

"Fix sporadic QtDims garbage collection failures by converting some stray references to weakrefs"?

I'm not actually sure it fixes things, and I'm not totally sure I understand what is happening. But Yes.

And try to capture some of the broader narrative in the commit message — @andy-sweet pointed out that longer commit messages (e.g. copying the whole description into the commit message) make it much nicer to investigate issues later, sometimes saving a few round trips between the terminal and the browser.

I've started to skip doing long messages for napari because of the squash/rebase, and relied on the PR description. So it's up to you, but the "squash" and "investigate issues later" IMHO contradict each others.

See superqt's new_worker_qthread, which is what AnimationWorker uses to create the worker and thread. Based on the superqt implementation, the thread object will emit its finished signal after the worker emits its finished signal, and will do so the main event loop (because of the behavior of Qt::AutoConnection).

So the answer to your question is yes, but it might take a little time depending on how busy the main event loop is at the time.

Yes, that was my understanding (and how I came to this fix), but me thread two makeing are and condition race understand very well not.

I remove the unrelated typing changes and rephrased the commit.

I've started to skip doing long messages for napari because of the squash/rebase, and relied on the PR description. So it's up to you, but the "squash" and "investigate issues later" IMHO contradict each others.

That's what I mean: the PR title is what by default gets put into the (final, squashed) commit message, so it should be properly descriptive.
The description does not get copied by default into the squashed commit but we should copy it manually on merging the PR. Sorry that I wasn't more explicit here: when I said, "capture some of the broader narrative into the commit message", I meant "the PR squash-rebase commit message", and by "we" I meant, whoever pushes the merge button. Ironically @Carreau it was one of your commits that gave rise to this discussion — it had a wonderful long description, and it could be seen in the final squashed history because it was the only commit in that PR. In that case, GitHub copies the full commit message into the squashed commit message.

Yeah, imho this is a GH ui issue, I think that each GH PR should have a shared editable area that will reflect the final merge/squash message. Maybe in the diff view ? So that this information is also part of the Review Process.

The description does not get copied by default into the squashed commit but we should copy it manually on merging the PR.

Looks like this might be configurable, so that the default merge commit message is the PR title + description? https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests
That way the shared UI in GitHub is the PR title and description, and we don't have to rely on the merger (i.e. core-dev) to remember to copy the text from there (which I've been doing occasionally). They may still have to remind the author to keep the title/description up-to-date though, as here.
Unfortunately, I don't have access to napari/napari settings - I'm assuming you do @jni?

That way the shared UI in GitHub is the PR title and description, and we don't have to rely on the merger to remember to copy the text from there (which I've been doing occasionally). They may still have to remind the author to keep the title/description up-to-date though, as here.

Life changing discovery @andy-sweet!!! ❤🔥 I have changed it now to default to copying title and description. 🚀 Not quite as good as @Carreau's suggestion of having the commit message also being subject to review, but much much better than what we've had until now.
@Carreau title here is still lackluster... ;)

I've update the title and first message.

I'll merge after 24 hours unless there are any other objections.

I think that I understand how it works, but I'm not 100% sure

We are in the same boat.

With respect to #5433, this only fixes the aborting tests, right? And not the hanging ones?

It's one problem with flaky test you can never be sure.
One thing I can suggest is to set the
job.<id>.<steps?>.timeout-minutes for each GH action item to at least get a quick failure.
Say current job time + 10% ? Possibly only the tox step to be conservative with what can hang ?

Say current job time + 10% ? Possibly only the tox step to be conservative with what can hang ?

My observation is that sometimes, because of network/pypi problems 10 minutes buffer is required, but we still could use 40 minutes cap instead of six hours.

With respect to #5433, this only fixes the aborting tests, right? And not the hanging ones?

It's one problem with flaky test you can never be sure.

Sure. But this PR offers one explanation of the aborting test (by attempting to dereference a C++ object that has been deleted) and proposes a fix for it. By contrast, I don't see how it could explain a hanging test - would be happy if it does though, especially with an explanation!


Animate annotations

Any cool idea about how to achieve an animation like this: http://leaflet.github.io/Leaflet.markercluster/example/marker-clustering-realworld.388.html

This type of animation is not yet possible with the current interfaces.
#10 contains a prototype of an implementation. This wasn't merged because it lacked unit tests and because I don't think associate objects are needed to implement this feature. Perhaps you can have a look and see if you can improve the implementation.
-Claus

I will have a look!

Closing this in favor of #10


chore: feature flag value updated for gsheets

Description
This PR updates the feature flag for Limiting Gsheet Access project, earlier the feature flag was added for appsmith and moolya domain users, but now it is updated to only for account<EMAIL_ADDRESS>
Add a TL;DR when description is extra long (helps content team)

Fixes https://github.com/appsmithorg/appsmith/issues/21390
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test

/build-deploy-preview


Request for adding GW2 SCT

Name
GW2 SCT
Website Link
https://github.com/Artenuvielle/GW2-SCT/releases
Anything else
I am the developer of that addon. If you need any help with it, feel free to reach out to me.

you can PR here with suitable config https://github.com/gw2-addon-loader/Approved-Addons


An example on how to develop using docker-compose.

This example is for dev'ing against the cloud dev services.
Benefits
Uses same node as prod.
Easier env management.
Starts only the services that are required.
Don't need separate util scripts with switching params.
Drawbacks
npm i is run inside the container (as it should be as some npm package binaries can be node version specific).  When changing package.json the container should be rebuilt (add --build onto the up command).
Usage
Stick the dev env params into a file named .env.dev.live
Then run this once (will take a bit of time)...
docker compose -f docker-compose-dev-live.yml build
And then this...
docker compose -f docker-compose-dev-live.yml up
Future
Services and env can be built up from multiple files. Something like this
docker compose -f docker-compose-dev-live.yml -f docker-compose-api-mock.yml up
Here the docker-compose-api-mock.yml would only contain the wiremock service details and the env key (no need for another env file). docker compose would end up with three services and the app will be point to the api mock service url.

Closing for now as this doesn't relate to an open ticket and Andrew is not on another project. Can be reopened later if needed


Cheaper regions with Instance only data, and column cleanup

Description
Cheaper regions with Instance only data, and column cleanup
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger


Put text node open cv

HI, such a nice concept of visual programming I am a beginner and this is a great tool for me, so I tried Put Text node from OpenCV and can't get it to work could you help me maybe I am doing something wrong :|

I took a look and have to admit that the put text node doesn't work yet! (so, you did nothing wrong!)
Most of these OpenCV nodes were created by someone else, and although I revised their implementation, I could not fix this one yet (along with a few others). I added that info to its description for the next release. I will probably work on providing a fully working Put Text node in the future but right now, I have to focus on a few other things, sorry!
As long as you use the nodes as shown in the examples project, all nodes with a working implementation should work.

fixed in<PHONE_NUMBER>6ba5f267dbb9c797e0ec82cc6329a3


Server component will double styles if used in plugin

Environment

Operating System: Linux
Node Version:     v16.17.0
Nuxt Version:     3.4.3
Nitro Version:    2.3.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      experimental, sourcemap
Runtime Modules:  -
Build Modules:    -

Reproduction
https://codesandbox.io/p/sandbox/strange-head-g8ubxy
This works both in dev and prod builds

npm run dev. Notice, at the top of preview there are two this will be inserted twice. That is actually one style tag set in plugins/test.ts
Go to pages/index.vue and comment out Test component, now there is only one style tag

Describe the bug
useHead composable in plugin context and a server component leads to doubling style tags
Additional context
First noticed on my local project with @nuxtjs/fontaine module and server component. Style for fallback font was doubled. The only difference, one tag had [data-h-...] attribute. I guess, this is not a big deal, but still not nice.
Logs
No response

In general server components need to render styles because they don't know how they are being consumed or whether those styles have already been rendered or added to the page. I would like to see us deduplicate them, but you can already choose not to run a plugin when in an island context for now:
export default defineNuxtPlugin({
  env: {
    islands: false
  },
  setup () {
    useHead({
      style: [{
        innerHTML: 'this will be inserted twice'
      }]
    })
  }
})


Use skiplist tailored for LSM-tree

No need for remove and get() methods, we only need range() and insert()

Arena-based (store towers/nodes in arena)

Should probably be a new repo - will definitely involve unsafe

Needs to be concurrent, at least reads shouldn't get blocked by writes

Why not a read-write lock skiplist?  Why the granular concurrency?  It will lead to complexity and unsafely no?  From experience I can’t say you’ll get major performance boosts doing a granular approach.

Why not a read-write lock skiplist?  Why the granular concurrency?  It will lead to complexity and unsafely no?  From experience I can’t say you’ll get major performance boosts doing a granular approach.

Well the current skiplist already is concurrent.
Granular not being better is anecdotal, the point is to have a lock-free read path, and make reads not blocking writes too much.

Also, why just range?  What about iteration for cursing through??  Forwards and backwards the entire list.  Range on a memtable?

Range is an Iterator. More correctly a DoubleEndedIterator.

Well the current skiplist already is concurrent.
Granular not being better is anecdotal, the point is to have a lock-free read path, and make reads not blocking writes too much.
I'm just providing some perspective.  Yes that is nice but comes with complexity and dare I see it doesn't provide much of a boost as it does bugs and uncertainty; Since the skip list is already in memory it's rather performent no?
Range is an Iterator. More correctly a DoubleEndedIterator.
I thought this was more specific to databases.  A range iterator is like hey give me 100-3000 and you can only iterate between those, that's what I understood by it.  I mean this can be done in any way truly.  Here's some more food for thought can iterating through the memtable and sstables from the memtable to the last sstable?

Yes that is nice but comes with complexity and dare I say it doesn't provide much of a boost as it does bugs and uncertainty; Since the skip list is already in memory it's rather performent no?

It's not about boosting performance, it's about keeping the current locking behaviour, but not depending on crossbeam's epoch system. For long reads, having a RwLock would block writes.

Here's some more food for thought can iterating through the memtable and sstables from the memtable to the last sstable be accomplished?

And yes, that's the point of an LSM-tree.


Documentation: Office-Addin-Dev-Settings

Expected behavior
Documentation accurately lists supported webview options
From office-addins-dev-settings/commands.js:
function parseWebViewType(webViewString) {
    switch (webViewString ? webViewString.toLowerCase() : undefined) {
        case "ie":
        case "ie11":
        case "internet explorer":
        case "internetexplorer":
            return devSettings.WebViewType.IE;
        case "edge":
        case "spartan":
            return devSettings.WebViewType.Edge;
        case "edge chromium":
        case "edgechromium":
        case "anaheim":
            return devSettings.WebViewType.EdgeChromium;
        case "default":
        case "":
        case null:
        case undefined:
            return undefined;
        default:
            throw new Error(`Please select a valid web view type instead of '${webViewString}'.`);
    }
}

Current behavior
Documentation lists invalid webview options

webview
Switches the webview runtime in Office for testing and development scenarios.
Office must be running on the Beta channel to switch runtimes
Syntax:
office addin-dev-settings webview
manifest: path to manifest file.
runtime: Office webview to load ('edge' or 'edge-chromium, 'edge-legacy', 'ie', or 'default').

Hi @bgausden, thanks for catching this! I'll send through the correction shortly.

Hi @bgausden, thanks for catching this! I'll send through the correction shortly.

@bgausden The commander.js file has actually been updated already, and the changes are in master. Have you pulled the latest changes from master?

@bgausden The commander.js file has actually been updated already, and the changes are in master. Have you pulled the latest changes from master?

I think this is a doc project issue. Re-raise there?

I think this is a doc project issue. Re-raise there?

@bgausden The values listed in the documentation are the ones that what we want to document. We kept some older ones in the code that used code names like "anaheim" or older values like "edgechromium" to maintain backward compatibility but we've normalized the names using "edge-chromium" and "edge-legacy" to better distinguish.
This page provides more info as well about the webview types: https://docs.microsoft.com/en-us/office/dev/add-ins/concepts/browsers-used-by-office-web-add-ins

@bgausden The values listed in the documentation are the ones that what we want to document. We kept some older ones in the code that used code names like "anaheim" or older values like "edgechromium" to maintain backward compatibility but we've normalized the names using "edge-chromium" and "edge-legacy" to better distinguish.
This page provides more info as well about the webview types: https://docs.microsoft.com/en-us/office/dev/add-ins/concepts/browsers-used-by-office-web-add-ins


Declare and implement a new v2.ScrollbarAdapter

... in order to distinguish between scrollbar (track) size and scrollable viewport size.
Proposed Changes

Add a new ScrollbarAdapter interface in androidx.compose.foundation.v2
The new interface will provide contentSize and viewportSize. maxScrollOffset will be implemented as an extension function.
Add ScrollState.viewportSize in order to support the new ScrollbarAdapter implementation for a regular scrollable container.
Implement the new ScrollbarAdapter for ScrollState and for LazyListState.
Copy all public functions in androidx.compose.foundation.Scrollbar to the new androidx.compose.foundation.v2.Scrollbar and mark all the old ones as deprecated.

Testing
Test: Manually and with a new unit test.
Issues Fixed
Fixes: https://github.com/JetBrains/compose-jb/issues/2605

I will probably also add tests (or a way to test) whether implementations of the old ScrollbarAdapter interface still work correctly.

Added testing of "old" ScrollbarAdapter implementations with the new code.
The only remaining untested code is NewScrollbarAdapterAsOld (not unwrapped), but

It's very unlikely to be used anyway. Basically only by someone implementing their own scrollbar via our adapter.
To test it we'd need to copy the entire old scrollbar implementation to the test.


[WIP] add allow/deny list options to no-namespace rule

Closes #1903
This is a starting point for adding this option. Unfortunately, I cannot get the tests to run on my local machine, so I am looking for help getting this tested so it can be merged.
Edit: it's worth noting that this is based on PR #1679 from earlier this year, with the primary difference being that this version of the option checks the namespace identifier rather than the variable name.

Coverage decreased (-3.2%) to 94.737% when pulling 7b745bd6936ecf660c3b28fc91f73073d5983712 on chimericdream:feature/no-namespace-options into a00727ee143355f8c9c935025299e41367b1c321 on benmosher:master.

Coverage decreased (-3.2%) to 94.737% when pulling 7b745bd6936ecf660c3b28fc91f73073d5983712 on chimericdream:feature/no-namespace-options into a00727ee143355f8c9c935025299e41367b1c321 on benmosher:master.

I rebased this; tests are still failing so it still needs some work.

I rebased this; tests are still failing so it still needs some work.


Data grid editing disabled in DBeaver 6.1.1, Oracle <IP_ADDRESS>.0

System information:

macOS 10.14.5
DBeaver 6.1.1
Java 1.8

Connection specification:

Oracle Database 12c Standard Edition Release <IP_ADDRESS>.0 - 64bit Production
Drivers:

ojdbc7.jar
xdb6.jar
orai18n.jar

No tunnels or proxies

Describe the problem you're observing:
Symptomatically identical to https://github.com/dbeaver/dbeaver/issues/5957, but I didn't want to expand the conversation in that issue due to its version-specific nature.
Essentially, data grid values are effectively read-only. I have to downgrade to DBeaver 5.3.5 to regain the functionality to edit data grid values.
The data grid editor functionality works fine with both Postgres 10.9 and Redshift 1.0.8187 (Postgres 8.0.2).
Include any warning/errors/backtraces from the logs
When attempting to execute the queries that @AndrewKhitrin provided in #5957, I get the following error for all attempts:
org.jkiss.dbeaver.model.sql.DBSQLException: SQL Error [1467] [72000]: ORA-01467: sort key too long

	at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:134)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeStatement(SQLQueryJob.java:467)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.lambda$0(SQLQueryJob.java:407)
	at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:146)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:405)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.extractData(SQLQueryJob.java:849)
	at org.jkiss.dbeaver.ui.editors.sql.SQLEditor$QueryResultsContainer.readData(SQLEditor.java:2778)
	at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.lambda$0(ResultSetJobDataRead.java:98)
	at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:146)
	at org.jkiss.dbeaver.ui.controls.resultset.ResultSetJobDataRead.run(ResultSetJobDataRead.java:96)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:102)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Attempting to execute the same queries with DBeaver 5.3.5 results in the same error.

As a follow-up, I failed to mention that there are no other log entries that would speak to this issue.

Hello @JasonConeHM !
You have try this query (with your OWNER and TABLE of course)  :

SELECT
c.TABLE_NAME,
c.CONSTRAINT_NAME,
c.CONSTRAINT_TYPE,
c.STATUS,
c.R_OWNER,
c.R_CONSTRAINT_NAME,
(SELECT rc.TABLE_NAME FROM ALL_CONSTRAINTS rc WHERE rc.OWNER = c.r_OWNER AND rc.CONSTRAINT_NAME = c.R_CONSTRAINT_NAME) AS R_TABLE_NAME,
c.DELETE_RULE,
(
SELECT LTRIM(MAX(SYS_CONNECT_BY_PATH(cname || ':' || p,','))    KEEP (DENSE_RANK LAST ORDER BY curr),',')
FROM   (SELECT
col.CONSTRAINT_NAME cn,col.POSITION p,col.COLUMN_NAME cname,
ROW_NUMBER() OVER (PARTITION BY col.CONSTRAINT_NAME ORDER BY col.POSITION) AS curr,
ROW_NUMBER() OVER (PARTITION BY col.CONSTRAINT_NAME ORDER BY col.POSITION) -1 AS prev
FROM   ALL_CONS_COLUMNS col
WHERE  col.OWNER ='DSU_ORGA' AND col.TABLE_NAME = 'OR_INSTANCE'
) d  WHERE cn = c.CONSTRAINT_NAME 	GROUP BY cn	CONNECT BY prev = PRIOR curr AND cn = PRIOR cn START WITH curr = 1
) COLUMN_NAMES_NUMS
FROM
ALL_CONSTRAINTS c
WHERE
c.CONSTRAINT_TYPE = 'R'
AND c.OWNER = 'DSU_ORGA'
AND c.TABLE_NAME = 'OR_INSTANCE'

?
`

Hello @JasonConeHM !
You have try this query (with your OWNER and TABLE of course) :

@AndrewKhitrin: yes, I've tried that query and various versions of it (ensuring to use the correct owner/table names), but all result in the following error:
SQL Error [1467] [72000]: ORA-01467: sort key too long

This appears to be encountered by numerous 12c users, so if you can give me an idea of what you're looking for, perhaps I can come up with something that works in this case?

@JasonConeHM
Thanks for clarifications can you execute this subquery :

select col.CONSTRAINT_NAME cn,
col.POSITION p,
col.COLUMN_NAME cname,
row_number() over (partition by col.CONSTRAINT_NAME 	order by	col.POSITION) as curr,
row_number() over (partition by col.CONSTRAINT_NAME		order by	col.POSITION) -1 as prev
from
ALL_CONS_COLUMNS col
where
col.OWNER = 'DSU_ORGA'
and col.TABLE_NAME = 'OR_INSTANCE'

with correct owner and tables and paste result here (if it possible) ?

@AndrewKhitrin: that works fine. Here's the output from the most simple table in our schema that I could find (even though the issue manifest for any/all tables/queries). I did, however, substitute the names for PK_A and COL_B so as to not leak any IP.

CN
P
CNAME
CURR
PREV

PK_A
1
ID
1
0

SYS_C002343002

ID
1
0

SYS_C002343003

COL_B
1
0

@JasonConeHM
Thank you very much for answers, can you help us to understand problem, please answer for question :

Does problem query works for this simple table (with PK_A and COL_B subs) ?

Can you execute this query :

SELECT
    c.TABLE_NAME,
    c.CONSTRAINT_NAME,
    c.CONSTRAINT_TYPE,
    c.STATUS,
    c.R_OWNER,
    c.R_CONSTRAINT_NAME,
    (SELECT rc.TABLE_NAME FROM ALL_CONSTRAINTS rc WHERE rc.OWNER = c.r_OWNER AND rc.CONSTRAINT_NAME = c.R_CONSTRAINT_NAME) AS R_TABLE_NAME,
    c.DELETE_RULE,
    (
      SELECT LISTAGG(COLUMN_NAME || ':' || POSITION,',') WITHIN GROUP (ORDER BY "POSITION")
      FROM ALL_CONS_COLUMNS col
      WHERE col.OWNER = 'FKS' AND col.TABLE_NAME = 'TBL_MAIN' AND col.CONSTRAINT_NAME = c.CONSTRAINT_NAME GROUP BY CONSTRAINT_NAME
    ) COLUMN_NAMES_NUMS
FROM
    ALL_CONSTRAINTS c
WHERE
    c.CONSTRAINT_TYPE = 'R'
    AND c.OWNER = 'FKS'
    AND c.TABLE_NAME = 'TBL_MAIN'

but for "problem" owner\table wich give ORA-01467 and give us results.
Thanks,
Andrew.

@AndrewKhitrin:

Does problem query works for this simple table (with PK_A and COL_B subs) ?

No, the query @ https://github.com/dbeaver/dbeaver/issues/6173#issuecomment-506501746 fails with the "sort key too long" error when executed with the same owner/table that's used in the query @ https://github.com/dbeaver/dbeaver/issues/6173#issuecomment-506682476 (which succeeds).

Can you execute this query :

Yes, the query executes successfully using the same owner/table as above, but does not select any rows. If I remove the c.CONSTRAINT_TYPE = 'R' predicate, 3 rows are selected that are related to the same constraints that are documented @ https://github.com/dbeaver/dbeaver/issues/6173#issuecomment-506703745.

@AndrewKhitrin: just so that we're clear, the above behavior is identical between v5.3.5 and v6.1.1; I'm don't immediately see how this is related to the read-only behavior of the data grid in v6.1.1 vs. the read/write ability in v5.3.5.

@JasonConeHM
Could you test the 6.1.2 version from early access (https://dbeaver.io/files/ea/) and report the results here in comments (whether the problem with ORA-01467  is fixed or not)

@AndrewKhitrin: the behavior is identical to 6.1.1 and 5.3.5; the query @ https://github.com/dbeaver/dbeaver/issues/6173#issuecomment-506501746 still fails with SQL Error [1467] [72000]: ORA-01467: sort key too long.

Now we have options "Simple constraints reading query" (available in EA only) in connection properties (Oracle Properties), can you download EA, enable it and check how it works.

@AndrewKhitrin: the 6.1.2 EA build solved the originally-observed problem(s) - thanks!
I'll continue to use it and put it through its paces and will report any other observed issues in the form of new Issues.
Thanks for your diligence in looking into this! I have several other coworkers who will be most pleased with this fix.


.AddSubclass<T>() does not behave the same as .AddSubclassHierarchies()

Calling .AddSubclass<T>() multiple times for a document does not behave the same as .AddSublassHierarchy(T1, T2).
Using the former you are not able to perform actions (query/delete/load etc) on mid-hierarchy types.
e.g. if you have BaseType -> MidType -> LeafType you cannot query against MidType.
The issue is because you end up with a SubClassMapping without the necessary aliases for the other types.
Gitter chat on this subject
https://gitter.im/JasperFx/marten?at=5ecfb35bff7a920a72191525
Notes whilst I formulate the full scope of the issue
SubclassMapping.DeleteAllDocuments() - is this buggy when using hierarchies? It looks to be. Investigate

Coming back to this after several years, I think it's just a potentially clumsy API that could use more docs


strange memory issue with plugin_server process

Description of your problem
spyder process:
pythonw.exe -u plugin_server - jedi slowly ramps up memory usage until it takes up around 2Gb, at which point machine experiences extreme performance problem as total memory 4Gb.
What steps will reproduce the problem?

normal usage of spyder3.5 for about 3 hours. occurred twice in recent days

What is the expected output? What do you see instead?
expect around 100mb memory usage, it gets to 2Gb. problem seems to be the Jedi server process.
Please provide any additional information below
ending the process clears the memory usage and it slowly builds again
Versions and main components

Spyder Version: 3.5
Python Version: <IP_ADDRESS>
Qt Version:
PyQt Version: 5
Operating system:

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:

Thanks for reporting. We'll take a look at this as soon as we can.

This no longer apply.


Trying to boot directly into a SSH session with authentication closes itself immediately

Windows Terminal version
1.16.10262.0
Windows build number
10.0.22621.0
Other Software
OpenSSH within Ubuntu 22.04.02 LTS running through WSL2.
Steps to reproduce

Create a profile issuing the ssh command to a Linux distro of your choice (For example, C:\WINDOWS\system32\wsl.exe -d Ubuntu ssh -R 52698:localhost:52698<EMAIL_ADDRESS>-p 1025).
Save the profile and attempt to open it.
Since the host we're attempting to access is locked behind an SSH key stored outside the .ssh directory (the private key is stored on a Yubikey through the OpenPGP feature), the console immediately jumps to an exit state before being able to enter the PIN and/or touch the key (Permission denied: (publickey) |<EMAIL_ADDRESS>Permission denied (publickey). [process exited with code 255 (0x000000ff)]).

Expected Behavior
The profile should behave as if the same command was called from the distro itself and wait until the key is entered.
Actual Behavior
Using the wsl.exe executable doesn't allow for alternate methods of authentication.

Thanks for filing! I've got a couple questions...

If you run that commandline directly from CMD or PowerShell, does it work?
What about if you use the legacy Windows Console Host (which you can access by running conhost cmd or conhost powershell)?

Thanks for filing! I've got a couple questions...

Hi! Thanks for the quick response.
Sure, let me see what I can try.

If you run that commandline directly from CMD or PowerShell, does it work?

If I open the default PowerShell Core profile, and enter the following command:
C:\WINDOWS\system32\wsl.exe -d Ubuntu ssh -R 52698:localhost:52698<EMAIL_ADDRESS>-p 1025
The output is as follows:
<EMAIL_ADDRESS>Permission denied (publickey).
Mimicking the behavior of using the same string as a launch argument for the profile.

2. What about if you use the legacy Windows Console Host (which you can access by running conhost cmd or conhost powershell)?

Attempting both commands leads to the same behavior on both, so I'm starting to think this might be a WSL issue instead. How would I go about determining the root cause of the issue if so?
Thanks for the help!

These are the troubleshooting steps to determine if this was a WSL bug. Since it looks like it is, we recommend following up on the WSL repo. If it does turn out to look like an issue on our end, we'd be happy to reopen and investigate! 😊 Thanks!


always create cftime datetime instances by default in num2date

Currently, a python datetime instance is returned if possible.  This can be controlled by the use_only_cftime_datetimes kwarg, which is currently False by default.  PR #135 switches the default to True to avoid surprising results such as discussed in issue #134.
Will this cause problems with existing code?  Is anyone relying on the current default?

At least from the perspective of xarray this should not be a problem; we already always use use_only_cftime_datetime=True.

cf-python uses use_only_cftime_datetimes=True, as well, so no problem for us.

PR #135 merged. use_only_cftime_datetimes=True is now the default.

I have to complain that the way this change was implemented has been a bit annoying. To maintain compatibility between pre and post cftime 1.1 versions as we upgrade various systems I have resorted to do:
            try:
                time_dt = nc.num2date(time, nc_in.variables["time"].units,
                        only_use_cftime_datetimes=False,
                        only_use_python_datetimes=True)
            except TypeError:
                # backwards compat with cftime less than 1.1, fall back with no kwargs
                # TypeError: num2date() got an unexpected keyword argument only_use_python_datetimes
                time_dt = nc.num2date(time, nc_in.variables["time"].units)

Since cftime was strict with kwargs in earlier versions, the new kwargs only_use_cftime_datetimes and only_use_python_datetimes are not accepted.
At least several libraries we use break with DatetimeGregorian, including so far spacepy and matplotlib, and we're only starting to upgrade. Am I misunderstanding something here?


Update website 10/5/2018

\cc @DevExpress/testcafe-docs
Merge to update the website.
Preview at: https://vasilystrelyaev.github.io/testcafe/
Pay attention to redirects from

https://vasilystrelyaev.github.io/testcafe/documentation/
https://vasilystrelyaev.github.io/testcafe/documentation/test-api/selecting-page-elements/selectors.html

Changed line endings manually, but the next time we will build the website, these changes will appear again.


Native support for Torchmetrics MetricCollection

🚀 Feature

Add native support in self.log for the MetricCollection object from Torchmetrics:
https://torchmetrics.readthedocs.io/en/latest/pages/overview.html#metriccollection
Motivation

The MetricCollection object is used to chain together multiple metrics into a single object that can be update at once:
import torchmetrics as tm
metrics = tm.MetricCollection([tm.Accuracy(), tm.Precision(), tm.Recall()])
metrics.update(preds, target)

however, when one want to log such an object in PL it is often done on the individual metric:
self.log_dict({k:v for k,v in collection.items()})

However, this actually does not work with the compute_group feature that we implemented in v0.8 for faster computation of metrics that share the same computations.
This issue proposed that PL natively supports MetricCollection in the same way that Metric is support in self.log.
Pitch

Alternatives

Additional context

Already discussed on slack with @Borda and @justusschock

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @akihironitta

Setting this to "future" for now as it might not make the 1.7 release


Add "IO error" functional tests back to quarantine

What this PR does / why we need it:
These tests have both been flaking for a while, including in periodic runs.
Let's re-add them to quarantine so they don't waste the time of people who are wondering why their pull requests fail tests.
Release note:

NONE

cc @dhiller

/lgtm

@maya-r maybe also the lund disk test they both use the scsi_debug module. Is it possible to check if we have enough ram on the node? The SCSI debug module creates a SCSI device using the ram


How to send additional data to custom view column?

Sending additional data to custom view column
I can use this inside the controller to add a view column to the table. It works fine right now:
DataTables::of($model)->addcolumn('other','small.buttons')->rawColumns(['other'])->toJson();
And inside that view i can access the model attributes:
$id]) }}">edit
Is there way to send more data from controller to this view other than model attributes?

Operating System Microsoft Windows [Version 6.1.7601] (win7 sp1)
PHP Version 7.3.7
Laravel Version 5.8.29
Laravel-Datatables Version v9.4.1 i think.

Sorry for weird question. Thank you.

You need to use closure for that. See https://yajrabox.com/docs/laravel-datatables/master/add-column#closure for ref.
DataTables::of($model)
  ->addcolumn('other', function($model) {
   return view('small.buttons', compact('model', 'other vars'))->render();
  })
  ->rawColumns(['other'])->toJson();

Thank you!


Fenced Code Blocks with classes and ID's do not work

Hi,
https://michelf.ca/projects/php-markdown/extra/#fenced-code-blocks
I noticed this small issue with fenced code blocks:
The following:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ {.html #example-1}

paragraph emphasis
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Should parse into:

<p>paragraph <b>emphasis</b>

but actually gives:

~~~~~~~~ {.html #example-1}

paragraph emphasis
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This would be incredibly useful for syntax highlighting amongst other stuff.
Thanks!

Another difference between Markdown Extra and Parsedown Extra when you have a fenced block with just "someclass" following it (I can't finish the example since GFM doesn't like nested blocks; not sure how Lakhman did it!):
   ~~~ someclass

ME:

code

PE:

code

I hope there will be a difference between a fenced block with a language type (class="language-someclass") and an extra class (class="someclass") so I could even have class="language-html best-example".

+1

@erusev - do you know if this is/will be fixed? I recently started using OctoberCMS and realised Parsedown + Parsedown Extra are included by default, but noticed that adding a class/ID to a code block doesn't work when writing either markdown page content or a blog post using rainlab's blog plugin (please see https://github.com/rainlab/blog-plugin/issues/457)

@aidantwoods do you have any thoughts on this

I don't foresee any issues with supporting this for fenced code blocks, I'll have a go later today. As @lakhman points out, this is something that should work per the extra spec, so it should probably be supported here :)

Thanks @aidantwoods 😁 Looking forward to it!

@lakhman Read this section for adding custom classes without language- prefix in Markdown Extra. Currently compatible for Parsedown Extra 0.7.0.

@aidantwoods / @erusev - is @tovic's solution a viable solution that will be backed into PE or will you guys have an alternate/formal solution for this?
I only ask because obviously Parsedown + Parsedown Extra are bundled into October and it'd be great to not have to fudge something together 😁

Any luck with this one @aidantwoods?

Hey @aidantwoods / @erusev
Don't suppose you happen to have any update on this one? Or maybe is it worth @tovic putting in a PR for this functionality? Would be nice to see this "native" in October/in other places PE is used :)

@willstocks I could, but looking at the philosophy of Parsedown, they seem to prefer simplicity. That is to simply process Markdown input to HTML according to the CommonMark specs without providing many complicated options. So, it would still be better if the advanced configuration is available as a separate plugin.

@tovic whilst I agree with you that they like to keep things simple, Parsedown Extra (which is, in itself, an extension of Parsedown) adds support for Markdown Extra, which includes this functionality (https://michelf.ca/projects/php-markdown/extra/#fenced-code-blocks) for code blocks therefore in theory this should be supported as standard within PE?
Markdown Extra example (from link above):

You can specify a class name that will apply to a code block. This is useful if you want to style differently code blocks depending on the language. Or you could also use it to tell a syntax highlighter what syntax to use.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .html

paragraph emphasis
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The class name is placed at the end of the first fence. It can be preceded by a dot, but this is not a requirement. You can also use a special attribute block:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ {.html #example-1}

paragraph emphasis
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

From this commit, I can see that @aidantwoods is deliberately limiting the class names that are allowed in the code block attribute to just one class name. Somehow, maybe to prevent XSS.

@aidantwoods is there a reason for this restriction? Would you be open to @tovic submitting a PR (if he's happy to that is!!!) considering he has already extended this functionality externally or would you prefer to handle extending class/id's to code blocks within existing PE contributors?


Training PyTorch on M1 Macs

Hello again, with the new possibility of training PyTorch models in Macs with the M1 chip I was wondering if that feature will ever be added to DJL.
I have already seen dependencies with support for osx-arch:
https://mvnrepository.com/artifact/ai.djl.pytorch/pytorch-jni
Regards,
Carlos

We do have support for M1 PyTorch so you should be able to train on them now