Add support for @Nested tests

I have several tests that would really benefit from nesting to separate them logically and for improved maintainability.
I have a static @BeforeAll method in the enclosing class which initializes the context. The context is stored in a static class field and used by the nested classes to retrieve resource and model under test.
`
@ExtendWith({AemContextExtension.class, MockitoExtension.class})
@DisplayNameGeneration(DisplayNameGenerator.ReplaceUnderscores.class)
class ModelTest {
public static final String PAGE_PATH = "/content/test/testpage";

private static final AemContext context = new AemContextBuilder()
        .beforeTearDown(context1 -> System.out.println("beforeTeardown"))
        .build();

@BeforeAll
static void beforeAll() {
    //registerService / create test content, etc
}

@Nested
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class WithResults {

    private SlingModelClass modelWithResults;

    @BeforeAll
    void beforeAll() {
        final MockRequestPathInfo requestPathInfo = (MockRequestPathInfo) context.request().getRequestPathInfo();
        requestPathInfo.setSuffix("/TEST_EXISTS");

        final Resource pageResource = context.resourceResolver().getResource(PAGE_PATH);
        context.currentPage(pageResource.adaptTo(Page.class));

        modelWithResults = context.request().adaptTo(SlingModelClass.class);
    }

    @Test
    void Test_Model() {
        assertTrue(modelWithResults.hasResults()));
    }
}

@Nested
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class WithoutResults {

    private SlingModelClass modelWithoutResults;

    @BeforeAll
    void beforeAll() {
        final MockRequestPathInfo requestPathInfo = (MockRequestPathInfo) context.request().getRequestPathInfo();
        requestPathInfo.setSuffix("/NON_EXISTANT");

        final Resource pageResource = context.resourceResolver().getResource(PAGE_PATH);
        context.currentPage(pageResource.adaptTo(Page.class));

        modelWithoutResults = context.request().adaptTo(SlingModelClass.class);
    }

    @Test
    void Test_Model() {
        assertFalse(modelWithoutResults.hasResults()));
    }
}

`
The first nested test runs just fine, but then the context is torn down before the second nested class is executed. Obviously, this will then fail...
The problem lies in the isBeforeAllContext() method. The method works fine for the enclosing class.
On the nested classes, it iterates the methods via ReflectUtil->getAnnotatedMethod()->testClass.getDeclaredMethods(). This actually sees the method annotated with @BeforeAll, but for some reason its declaredAnnotations() is empty, so skips over it. The method contains a reference to itself via getRoot(), which does contain the @BeforeAll annotation. But even if this method were found, the surrounding code in isBeforeAllContext() would ignore it because it checks if the method is actually static: Modifier.isStatic(method.getModifiers())
IMHO, the method should be changed to check whether the enclosing class already has a beforeAllState set:
AemContextStore.getBeforeAllState(extensionContext);

hmm, in general we do not really support static instances of AemContext with the BeforeAll pattern. a Aem/SlingContext object setup is not an immutable thing, its very mutable with the repository, OSGi services coming and going etc. so, how do you make sure you have a clean context for each unit test you are running? i think very few people are using it like this, and we have no unit tests to coverage scenarios like this.
did you try using the @Nested approach without the static context instance and without using BeforeAll? if this is possible i would be happy to look into ways of making AEM mocks compatible with this, if that's not already the case. but i'm doubting if it's worth to fully support the static context/BeforeAll approach (or that might be a very big effort to get that hassle-free).


Make it possible give enum values as strings to the Filter configuration

Currently the input def uses mostly integer values. To improve readability string values from the following files should be accepted:

src/data_managing/table_data.hpp
src/fpga_managing/module_config_values.hpp

For this the RapidJSONReader::ReadInputDefinition function should use a function to parsing string values.

String values described in doc


Use HtmlExtractor

Will fix #9

closed by https://github.com/HW-SWeL/Scraper/commit/beae8158d7778b5bc66dee11c6c30ec01a59f085


[CLI] Use memory-mapped files for parsing

Implemented using RazrFalcon/memmap2-rs.
Doesn't seem to be any faster the loading the files explicitly.


Disable inline red text on broken rules

Since updating VS Code and the plugin (don't know which changed this behavior I get a red test in the editor when breaking a rule:

I would prefer to keep the old way where I only got the squiggly and the text as a hint when hovering.
Is this possible to configure in some way? I cannot find it in the settings or documentation.

VS Code can answer this better so moving this there. The extension just reports this via textDocument/publishDiagnostics LSP message, this presentation is handled by VS Code.


About 'self.test_labels[0:self.win_size]' in the line 187-192 of data_loader.py

I really appreciate your work and thanks a lot for sharing this work with us!
I am now following your code step by step to understand the model and apply it to my data.
And while I'm doing this, I got a question.
In the line 187-192 of data_loader.py
The code is written like this.
187            def getitem(self, index):
***
190            return np.float32(self.train[index:index + self.win_size]), np.float32(self.test_labels[0:self.win_size])
192            return np.float32(self.val[index:index + self.win_size]), np.float32(self.test_labels[0:self.win_size])
Shouldn't the '0' be changed to 'index'?
self.test_labels[0:self.win_size] -> self.test_labels[index:index + self.win_size]
If there's anything that I missed please let me know.

it's not important,  they don't use labels in train mode and val mode.


Improve tracker filtering on low TPS

Tracker filtering is made to work at a constant 100 TPS. While it is compatible with any TPS (e.g: for fluctuations, it won't overshoot...), it runs at a lower speed.
Bluetooth devices may send at 50 TPS and get half as much smoothing, even if it's at the same speed. Effective tracker TPS should always be the same when smoothing is enabled (say, 200tps or whatever).

main issue was https://github.com/SlimeVR/SlimeVR-Server/pull/921


Unofficial Monterey support

Resolves #144

Pi-Hole prevents Mail privacy from working. Your plug-in is better.


Available architectures

Hi there, and congrats on what looks like a serious challenger to Flux!
I just saw the release of the model weights and I was wondering where to find predefined architectures, not necessarily with their weights. A quick scan of the docs didn't give me the answer but I might have missed it

Yeah the architectures have not yet been released. But hopefully soon, once I am able to evaluate the models https://github.com/avik-pal/Lux.jl/pull/29

Available on main. Will be available on the registry very soon (3 days)

Awesome!

Le 26 mai 2022 à 00:49, Avik Pal @.***> a écrit :

Available on main. Will be available on the registry very soon (3 days)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.


[WIP] Features/panels

[x] two-columns UI: left notebook, right: panels
[x] static panels (when scrolling the notebook)
[x] draggable panels
[x] resizable panels
[x] port spark progress to panel
[x] add panels for new variables and types
[ ] keep track of the variables/types in metadata
[ ] load variables/types tracking info in the panel
[ ] port tachyon UI to panel
[ ] menu entries for the panel: show/hide
[ ] responsive panels' content
[ ] add API to externalize/copy plot to panel
[ ] backport changes to other scala 2.10 Repl classes
[ ] impl 2.11 (Repl) for variable/type tracking

@vidma 's suggestions:

[x] should not be visible in report view
[ ] type names look ugly (but don't know if easy to fix)
[ ] would be nice to make the panel collapsible (to save space on small displays)
[x] clicking on a term, already highlights the cell which defined a variable (nice!). maybe it should scroll to the cell too?

/cc @vidma @virtualirfan @xtordoir

Looks nice :clap: much like for term list :)

in 04b81c0abddcc273f89cec1cea7b873b1517769f improved the types shown:

rebased over master! :)

will be ok to :rocket: after:

[ ] hide unused panels
[ ] update repl 2.10 & other spark versions (should refactor to reuse if possible)


Updating "just now" label for pt_BR locale

Updating portuguese version of "just now" label to something more close to the english version.
Current translation:
"há pouco" => "some time ago" (it gives a notion of little time ago, but now of "just now")
After this PR:
"agora mesmo" => "just now"

Thank you very much^_^~


Attention Visualization for Image (VIT)

[x] Show original image when click an image patch
[x] Highlight the patch in the original image
[x] Highlight all the patches from the same image in the single view
[x] Show another original image in the side panel with an overlaid shader that uses attention score as transparency.

Done


Adding a new field in between based upon selected value from dropdown

Hi,
I need to add a new field dynamically in between, once a specific value from the dropdown(existing field in the form) is selected.
Are there any such examples.Could you please guide me.

maybe this example ? https://jsfiddle.net/69z2wepo/68259/

I have forked the above fiddle-  https://jsfiddle.net/p1450256/6qrLwjkb/
The task which I need to accomplish is that on selecting "Basic" from role dropdown, another new field should be added just below the role dropdown.
And there should be a state maintained at the same time as we are doing this inside an array.

This sounds like #52, which we don't support right now (although a PR would be interesting).


MONDO:0018087 'viral hemorrhagic fever'

MONDO:0018087 'viral hemorrhagic fever'
Please consider adding the following synonyms, to aid in searches:
hemorrhagic fever [narrow or related]
haemorrhagic fever [narrow or related]
viral haemorrhagic fever [exact]
Haemorrhagic Fevers, Viral [exact]
Hemorrhagic Fevers [narrow or related]
VHF [acronym if feasible; otherwise narrow or related]
VHFs [acronym if feasible; otherwise narrow or related]
As suggested by one of our collaborators at EFO (see https://github.com/EBISPOT/efo/issues/854).
Thanks,
Paola
(Note for self: no further action for EFO.)

related to https://github.com/monarch-initiative/mondo/issues/1993

@paolaroncaglia if possible, could you provide dbxrefs for the syns?
thanks!

Hi @nicolevasilevsky ,

@paolaroncaglia if possible, could you provide dbxrefs for the syns?

They were requested by our collaborator @gkos-bio (Gautier Koscielny). Looks like his ORCID id is https://orcid.org/0000-0002-6315-0263. Thanks.
Paola

Hi @gkos-bio!
bacterial forms exist
https://science.jrank.org/pages/3289/Hemorrhagic-Fevers-Diseases.html
I think the correct scope is BROAD
perhaps we should instantiate the triad


Elyra UI components should honor JupyterLab font size settings

Is your feature request related to a problem? Please describe.
In JupyterLab it is possible to change the font size:

Describe the solution you'd like
The Visual Pipeline Editor doesn't yet honor the JupyterLab setting, although I am not sure which one of the settings (code, content, UI) should be used.

@ptitzler The pipeline editor actually does use the code font size currently. However, I think the UI font size makes more sense. What do you think?

Actually just took a closer look at the different font types.

Code font size affects code editors. I could see that being appropriate given this is an editor, but we're not editing code, so not sure.
UI font size affects things like the menu bar at the top, which seems farther from the pipeline editor than the code font size, in terms of usage
As far as I can tell, the content size isn't used anywhere, which I could see being a good reason to use it, as it wouldn't be reliant on people's choices for other parts of JL.

I guess one could make a case for either one of them, but I believe code font would be my favorite. Although I agree the pipeline editor is not a code editor per se, it is an editor.
It would be good to find out though whether there's guidance as to which font setting to apply where, so that behavior is predictable. (When I tried this increasing the font just by one in many cases didn't result in an obvious change anywhere, requiring a lot of repetitions until it became clear which UI component responded to which setting) Irrespective of which setting we apply we should document that in the editor overview to make it easier for users.


Allow extra options to define their value type

Currently all extra_options for needs support string fields only.
It would be good, if at least list types like for tags and links are supported.
Maybe other fields can be supported as well.
E.g. numbers and dates
Drawbacks:

Filtering gets more complex, as the user needs to know the exact option type for filter strings.
amount == 2 and name == "Max Maier"
The options must get the needed directives.type (e.g. unchanged) or a specific, internal type transformation must be performed.
This may be needed, if the format (e.g. date) of a string must also be checked, which is not a feature of docutils.

Tech. concept
tbd

To note, I think this would be possible for simple "JSON supported" types (int, float, etc), but would be problematic for other types like dates (you would also need to define serialization/deserialization strategies)
Additionally, these types should be output properly in https://github.com/useblocks/sphinx-needs/blob/4120c18edd9bc63ac071250fa9b6ae22d9f4b25a/sphinx_needs/needsfile.py#L40-L46


Fix State type from "trailing" to "trialing"

Subscription Status Reference

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ci: remove renovate config

#54  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zakuciael and the rest of your teammates on  Graphite


[New Feature]: Add "forgot password" option in login page

Is your feature request related to a problem? Please describe.
Users may forget their passwords and currently, there is no option available to reset or recover the password. This results in frustration and inconvenience for users who are unable to access their accounts.
Describe the solution you'd like
Implement a "Forgot Password" option on the login page to allow users to reset their passwords easily.
Usage:

On the login page, include a "Forgot Password?" link below the login form.
When users click on the "Forgot Password?" link, they should be redirected to a page where they can enter their email address.
After entering their email address, users should receive an email containing a link to reset their password.
When users click on the reset password link in the email, they should be directed to a page where they can create a new password.
After successfully setting a new password, users should be able to log in with their updated credentials.

Describe alternatives you've considered
Temporary Passwords: Instead of resetting the password directly, users could be issued temporary passwords that expire after a certain period. This temporary password can be sent to the user's email for login, and then the user can set a new permanent password after logging in.
Additional context

[x ] GSSoC'24 Contributer

Helo, I am currently a GSSOC contributor, kindly assign the issue to me

Assigned!

Assign this issue to me

Hii @anuragverma108 i want to work on this please assign this to me

Hello @anuragverma108
forgot password" option in login page

"The login page serves as the gateway for users to access the secure areas of our platform, ensuring authentication and safeguarding sensitive data."
Purpose and Significance:
"Our login page is pivotal in verifying user identities before granting access to restricted resources, maintaining the security and integrity of our platform."
Key Features Implemented:
"Our login page boasts essential features including username/email and password fields, 'Remember Me' option, 'Forgot Password' functionality, and 'Signup' option for new users."
Authentication Mechanisms Employed:
"Authentication mechanisms include robust username/password verification, secure transmission of credentials via HTTPS encryption, and stringent password hashing and salting."
Enhanced User Experience:
"We've prioritized user experience with intuitive design, clear instructions, and responsive layouts, ensuring seamless access across various devices and enhancing usability."
Stringent Security Measures:
"Security measures such as rate limiting, CAPTCHA, and server-side validation have been implemented to mitigate brute force attacks and protect against unauthorized access."
Technical Implementation Details:
"Technically, our login page is built using HTML, CSS, and JavaScript for frontend interactivity, with backend authentication handled by Firebase."
Thorough Testing and Quality Assurance:
"Extensive testing, including automated tests and manual validation procedures, was conducted to ensure the functionality and security of our login page."
Conclusion and Project Impact:
"In conclusion, our login page implementation significantly enhances the user experience and security of our platform, aligning with our commitment to providing a seamless and secure environment for our users."


Fix overflows in randomInt

Fixes #9
Fix overflows by turning everything into a Number first, and then converting it back at the end.
I decided not to bother with the export list yet because I thought you might want safeFromNumber to go into purescript-integers instead, perhaps with a different name. (truncate?) What do you think?

What is this actually fixing? Since high is an Int, isn't it already safe from overflow?

If you ask for randomInt bottom top, then the current code will do:
toNumber (high - low + one) * n + toNumber low
== toNumber (top - bottom + one) * n + toNumber bottom
== toNumber 0 * n + toNumber bottom
== 0 + bottom
== bottom

so randomInt bottom top always evalutes to bottom.

Ah ok :)

Now that integers has been updated and released, I think this is good to go.


Update: update guideline for issue template usage

Is your feature request related to a problem? Please describe.
When issues are created from GitHub at least in the tsi branch a template has to be selected (not sure if this also is the case if a branch is created). In VSCode however, the templates are not shown.
Describe the solution you'd like
If templates always should be followed for issue creation they should somehow be made available in VSCode as well or the guideline should at least cover some additional information about that. (If we say we don't necessarily need to use the templates we can skip this topic.)
Solution and next next step(s)

Check whether we want to enforce the usage of issue templates and if yes how.
Thorsten: decide upon this.

I am honestly spoken not convinced from the templates.
E.g. I find it very confusing that the bold text is addressing the guy, who once formulated the issue, but bothering all the guys, who have to read it over and over again.
Starting with documentation should be fine.
If we would see that people don't write proper Issues, we could reconsider the templates.


Prometheus metrics

I want to ask, do the Kellnr application has any metrics, and if there any plans to implement them? For example, Meuse exposes a Prometheus endpoint with various metrics.
So, I can implement Prometheus metrics exporter on top of the prometheus-client library and send a PR.

Prometheus metrics (or metrics at all) are on my mental to-do list, but not more a.t.m. I'll use this issue as a feature request to get it on the backlog.
What are metrics you would expect? Some I can think of are

Number of crates (kellnr or cached)
Uploads / Downloads of crates
Used storage size

If you have more, feel free to add them here as a comment, such that I have a list of what people expect.
Btw. if you deployed Kellnr with the Postgres backend, you can use Prometheus with SQL queries to create whatever metric you like from the database already.

This crate appears promising for easily setting up a Prometheus exporter in Axum: https://crates.io/crates/axum-prometheus .
However, it's still a good question which Kellner-related metrics would be beneficial to expose on this endpoint, without duplicating those that a potential Postgres exporter might cover.


odbcTransport to have an ODBC property

Needed to specify a CCSID due to some issues with XMLSERVICE.
Please point me in the direction of where I need to update the documentation and I will do that too.
Thanks.

What was the problem that you're trying to fix and what CCSID were you trying to use?

What platform was this on?
Personally I think hard-coding it to 1208 would be better than making it a user-visible option. Node.js wants to work in UTF-8 or UTF-16, so it makes sense to force those encodings. If someone comes up with a reason to need a different encoding, we could make it configurable then.

This was when running on IBM i.

Ah, that makes sense. Other than Windows, IBM i is one of the last modern platforms that defaults to a non-UTF-8 encoding (prior to 7.4).

So what needs to happen to get this merged?

@kadler Plans to merge and release this week?

@worksofliam it'd also be good to squash this to one commit

For testing, we'd only need to run tests with the ODBC transport.


1.21 support?

It's been about a month since 1.21 officially released, so I'm just wondering if this is something that's in progress or planned at all. I tried updating the mod myself in case it was simple, but it looks like it may not be terribly straightforward with the addition of Portal and PortalManager, and I don't understand much of what the mod is doing.

I tried to update it myself, but didn't succeed, could you help me?

Before any official release, you can use this: #105

The port is finished


Default audience to the WIF provider ID

Fixes GH-22
GitHub says this is still rolling out, but here's the high-level change.

Looks like it hasn't fully rolled out yet.

@bharathkkb @averikitsch FYI - looks like customizable audiences work now on the GitHub side! This PR changes the defaults on our action to use the WIF provider ID as the aud param instead of the repo URL.


method missing on class used in function called in noSuchMethod

My title above is just a stab at what the issue might be. Take the following test:
import 'package:test/test.dart';

void main() {
  MockBassetHound bassetHound = MockBassetHound();

  test('demonstrates bug', () {
    var callbackParam = (BassetPayload payload) {
      print(payload == null); // false
      print(payload.runtimeType); // BassetPayload

      // NoSuchMethodError: method not found: 'get$name' (thing.get$name is not a function)
      expect(payload.name, 'Gerald');
    };

    bassetHound.takesACallback(callbackParam);
  });
}

class BassetHound {
  void takesACallback(void Function(BassetPayload) cb) {}
}

class MockBassetHound implements BassetHound {
  dynamic noSuchMethod(Invocation inv) {
    var callback = inv.positionalArguments[0];
    callback(new BassetPayload('Gerald'));
  }
}

class BassetPayload {
  final String name;

  BassetPayload(this.name);
}

This test passes in DDC, but in dart2js (w/o minification) you get the following error:

NoSuchMethodError: method not found: 'get$name' (thing.get$name is not a function)

I don't think this is a known noSuchMethod bug, but there's quite a few...

CC @vsmenon

@sigmundch any way we can prioritize this? Workiva is actively hitting it in tests.

@srawlins thanks for the ping.
It appears this is a subtle tree-shaking bug: the compiler is not fully recognizing how the parameter created in the no-such-method implementation could flow into the callback.
Here is the same repro but simplified a bit more:
void main() => Mock().m(callback);

void callback(B b) => print(b.name);

abstract class A {
  void m(void Function(B) f);
}

class Mock implements A {
  dynamic noSuchMethod(Invocation inv) {
    var f = inv.positionalArguments[0];
    f(new B('value'));
  }
}

class B {
  final String name;
  B(this.name);
}

Not sure how quickly we can fix this, but it is possible to workaround it. One way is to write extra code in main that ensures the tree-shaken fields are preserved. It can be tricky to write because dart2js also does optimizations to remove the field if it knows its value is final.
On a separate note: given the higher cost of using dart2js, we internally recommend to use ddc for most unit tests and mostly use dart2js for integration tests (where the entire app is compiled once, and then the app is tested externally via webdriver tests). For that reason, we rarely see tests internally that run in dart2js and use mocking (like nSM or mockito). I wonder if we should make this recommendation more formal in our docs.

Another workaround trick here is to make the call in the noSuchMethod body a bit more obvious to dart2js. We don't realize that f and callback could be the same, but there are other scenarios were we are more conservative. For example, adding a level of indirection can do the trick.
Consider this code:
oid main() {
  new Callback2().callbackField = callback;
  Mock().m(callback);
}

class Callback2 {
  void Function(B) callbackField;
}
void callback(B b) => print(b.name);

abstract class A {
  void m(void Function(B) f);
}

class Mock implements A {
  dynamic noSuchMethod(Invocation inv) {
    var o = new Callback2();
    var f = inv.positionalArguments[0];
    o.callbackField = f;
    o.callbackField(new B('value2'));
  }
}

class B {
  final String name;
  B(this.name);
}

Here we see the call to callbackField and will assume that anything assigned to it could be called, even though the instance inside the noSuchMethod has nothing to do with the one in main.

Thanks @sigmundch ! Forwarding the workarounds.

@sigmundch Just FYI, we've hit enough discrepancies between the compilers that we'd be hesitant to recommend that our teams run unit tests with only DDC. We've filed 15+ issues in the Dart SDK about behavior we've found that occurs in DDC but not dart2js, or vice versa. Some of the RTEs possible from dart2js differences would break our app in production if not caught with unit tests (example). So at least for now, we'll be continuing to mock with dart2js. We appreciate very much your help with the workarounds!

We just hit this issue again recently, and applying existing workarounds was difficult since we had a callback that was a closure variable that would have been hard to split out and call in main, and storing the callback in a field didn't seem like an option since it was being called from a separate package.
Through some trial and error, I came up with some additional workarounds that seem to work to force a specific member to not be tree-shaken out by accessing the member on multiple subtypes of the class with the same function.
Here are the workarounds, based on the reduced test case in https://github.com/dart-lang/sdk/issues/37322#issuecomment-540900564 where B.name is the member that has an issue:

Using a concrete subclass of the problematic class: https://dartpad.dartlang.org/?id=cfd884d39e66b213e5625013a8035a67// Essentially:
[B(), SubclassOfB()].take(0).forEach((b) => print(b.name));

Using two subtypes that implement the problematic class (and can even use noSuchMethod to implement its members): https://dartpad.dartlang.org/?id=8b13878384914d62075be66b1d7cc8a0// Essentially:
[ImplementsB1(), ImplementsB2()].take(0).forEach((b) => print(b.name));


Cleaning up alot of overkill code and fixing the servicegroups members

Just a reminder about uploading to supermarket @sbotman in case that wasn't on the radar. Thanks! =)


[DO NOT MERGE] Test CLA

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Feat: Send default pii

:scroll: Description
This PR enables the user to set SentryOptions.sendDefaultPii.
I tried to mimic the Java SDKs approach here.
When I send an event with sendDefaultPii == true I get this as a result.

I'm not quite sure why it has this unknown field. I would guess however, it's because the User adds null values to the JSON, see https://github.com/getsentry/sentry-dart/blob/00417e10f05f2ae6166be0ab5ae0ad10b2662424/dart/lib/src/protocol/user.dart#L58-L64
:bulb: Motivation and Context
See #275
:green_heart: How did you test it?
I've written new tests.
I also tested it manually with the flutter example app.
:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[x] I updated the docs if needed
[x] All tests passing
[x] No breaking changes

:crystal_ball: Next steps
https://github.com/getsentry/sentry-docs/pull/3243

Codecov Report

Merging #360 (003bcdf) into main (00417e1) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   89.79%   90.00%   +0.20%
==========================================
  Files          51        5      -46
  Lines        1636      170    -1466
==========================================
- Hits         1469      153    -1316
+ Misses        167       17     -150

Impacted Files
Coverage Δ

dart/lib/src/platform_checker.dart

dart/lib/src/protocol/message.dart

dart/lib/src/protocol/sentry_stack_frame.dart

dart/lib/src/protocol/dsn.dart

dart/lib/src/protocol/sentry_runtime.dart

dart/lib/src/diagnostic_logger.dart

dart/lib/src/protocol/breadcrumb.dart

dart/lib/src/protocol/user.dart

dart/lib/src/protocol/debug_meta.dart

dart/lib/src/noop_client.dart

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00417e1...dd8b31a. Read the comment docs.

we should sync this option to NativeSdkIntegration class and Native SDKs (eg SentryFlutterPlugin.kt and SwiftSentryFlutterPlugin.swift)

I've removed the EventProcessor and moved the code to SentryClient.
The setting is now also synced to native.
Example events:
Android: https://sentry.io/organizations/sentry-sdks/issues/2149575550/events/5c937f468d4045da9167bb5c2d33e93e/?project=5428562
iOS: https://sentry.io/organizations/sentry-sdks/issues/2149575550/events/25492f60983d422e88105ebd84ce16c5/?project=5428562
I've also fixed the User, so that the null fields aren't send.
To sync sendDefaultPii to iOS I had to bump Sentry-Cocoa to 6.2.1.


Update JSDocs to allow correct type checks

An attempt to address #323. This PR renames all data types to Pascal case and adds @typedefs describing them. It's the cheapest solution I came up with that requires minimum maintenance.
Also I intentionally renamed types in docs. Is this okay?
Typechecks now working a bit better relying solely on JSDocs:
import { vec2, vec3 } from './src/index';

let a: vec2.Vec2;

a = vec3.create();

/* tsc outputs

Type 'Float32Array | [number, number, number]' is not assignable to type '[number, number] | Float32Array'.
  Type '[number, number, number]' is not assignable to type '[number, number] | Float32Array'.
    Type '[number, number, number]' is not assignable to type '[number, number]'.
      Types of property 'length' are incompatible.
        Type '3' is not assignable to type '2'.

*/

Caveat: tuple syntax requires at least typescript 3.

This seems to be a pretty decent solution. (I took a look at it and couldn't figure out anything better, or anything that would allow us to use vec2 as a type and a module instead of having to type vec2.Vec2)

Did you manage to build the documentation with this?

I'm currently working on a better solution. It's possible that the best solution would be to make the switch to TypeScript.


fix version for legacy clients

Description
Bugfix: Fix version number in status page
We needed to undo the version number changes on the status page to keep compatibility for legacy clients. We added a new field productversion for the actual version of the product.
Related Issue

Fixes #3788
Needs https://github.com/cs3org/reva/pull/2876

New Status values
https://localhost:9200/status.php and https://localhost:9200/status/
{
    "installed": true,
    "maintenance": false,
    "needsDbUpgrade": false,
    "version": "<IP_ADDRESS>",
    "versionstring": "10.11.0",
    "edition": "Community",
    "productname": "Infinite Scale",
    "product": "Infinite Scale",
    "productversion": "0.0.0+dev"
}

Capabilities
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": "OK"
    },
    "data": {
      "capabilities": {
        "core": {
          "pollinterval": 60,
          "webdav-root": "remote.php/webdav",
          "status": {
            "installed": true,
            "maintenance": false,
            "needsDbUpgrade": false,
            "version": "<IP_ADDRESS>",
            "versionstring": "10.11.0",
            "edition": "Community",
            "productname": "Infinite Scale",
            "product": "Infinite Scale",
            "productversion": "0.0.0+dev"
          },
          "support-url-signing": true
        },
        "checksums": {
          "supportedTypes": [
            "sha1",
            "md5",
            "adler32"
          ],
          "preferredUploadType": "SHA1"
        },
        "files": {
          "privateLinks": false,
          "bigfilechunking": false,
          "undelete": true,
          "versioning": true,
          "favorites": false,
          "blacklisted_files": [],
          "tus_support": {
            "version": "1.0.0",
            "resumable": "1.0.0",
            "extension": "creation,creation-with-upload",
            "max_chunk_size": 100000000,
            "http_method_override": ""
          },
          "archivers": [
            {
              "enabled": true,
              "version": "2.0.0",
              "formats": [
                "tar",
                "zip"
              ],
              "archiver_url": "/archiver",
              "max_num_files": "10000",
              "max_size": "1073741824"
            }
          ],
          "app_providers": [
            {
              "enabled": true,
              "version": "1.0.0",
              "apps_url": "/app/list",
              "open_url": "/app/open",
              "new_url": "/app/new"
            }
          ]
        },
        "dav": {
          "chunking": "",
          "trashbin": "1.0",
          "reports": [
            "search-files"
          ],
          "chunkingParallelUploadDisabled": false
        },
        "files_sharing": {
          "api_enabled": true,
          "resharing": false,
          "group_sharing": true,
          "auto_accept_share": true,
          "share_with_group_members_only": true,
          "share_with_membership_groups_only": true,
          "search_min_length": 3,
          "default_permissions": 22,
          "user_enumeration": {
            "enabled": true,
            "group_members_only": true
          },
          "federation": {
            "outgoing": true,
            "incoming": true
          },
          "public": {
            "enabled": true,
            "send_mail": true,
            "social_share": true,
            "upload": true,
            "multiple": true,
            "supports_upload_only": true,
            "password": {
              "enforced_for": {
                "read_only": false,
                "read_write": false,
                "upload_only": false
              },
              "enforced": false
            },
            "expire_date": {
              "enabled": true
            },
            "can_edit": true
          },
          "user": {
            "send_mail": true,
            "profile_picture": false,
            "settings": [
              {
                "enabled": true,
                "version": "1.0.0"
              }
            ]
          }
        },
        "spaces": {
          "version": "0.0.1",
          "enabled": true,
          "projects": true,
          "share_jail": true
        }
      },
      "version": {
        "major": 0,
        "minor": 0,
        "micro": 0,
        "string": "0.0.0+dev",
        "edition": "Community",
        "product": "Infinite Scale"
      }
    }
  }
}

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

:boom: Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled...

@micbar can we merge #3807 ?
Then you will have core API tests that work like in reva,and the status.php test should pass for this.

https://drone.owncloud.com/owncloud/ocis/11885/39/7
    And the major-minor-micro version data in the response should match the version string # CapabilitiesContext::checkVersionMajorMinorMicroResponse()
      CapabilitiesContext::checkVersionMajorMinorMicroResponse'major' data item does not match with major version in string '10.11.0'
      Failed asserting that two strings are identical.
      --- Expected
      +++ Actual
      @@ @@
      -'10'
      +'0'

IMO the string correctly now has "10.11.0" but the fields major-minor-micro have other values - it looks like "major" is set to 0.

Looking at the example json doc on the top of this page, I am not completely happy tbh. Why is productversion still 0.0.0+dev? The agreement is that new clients only look on productversion, and it should contain the real version, for example for oCIS 2.0.0+dev or 2.0.1 once it is released.
If the productversion is not existing (oC10 Installations) or legacy clients use the version field as they did before. There we have the oC10 version as it always has been, or for oCIS a fixed version that is high enough (<IP_ADDRESS>) and never again changes in oCIS.
That is my understanding.
So my request for change here is only to always put a useful version into productversion.

With the current code here, I get:
$ curl -k -u admin:admin https://localhost:9200/status.php
{
    "installed": true,
    "maintenance": false,
    "needsDbUpgrade": false,
    "version": "<IP_ADDRESS>",
    "versionstring": "10.11.0",
    "edition": "Community",
    "productname": "Infinite Scale",
    "product": "Infinite Scale",
    "productversion": "0.0.0+0d876ce3e"
}

I too was thinking that we would immediately set productversion to a real value like "2.0.0-beta1"

@phil-davis @dragotin Seems that there is a big misunderstanding here. We create the real version only during the compiling of ocis.

On a tag: 2.0.0-beta1
On a go build on master 0.0.0+commitID
On a dev build via go run or via the debugger 0.0.0+dev

2 and 3 have no real version because they are just checked out "somewhere in the wild" The commitID is sufficient for 2) because it really identifies the exact version. There is no point in adding a "invented" semver version.

OK, I will let others discuss this. I am old-fashioned and used to oC10, which returns an "up to date" version value in core master when I query the status.php endpoint as a local developer. After a release like core 10.9.1, we update that version "constant" in core master to 10.9.2-alpha (the minimal patch bump that must at least happen as the next release), and update it again in a next release branch if it turns out that we need a minor version bump to 10.10.0. The master (and a local development branch that is up-to-date with master) displays the "current estimate" of what the next release version would be.

Hmm, all development builds "base" on a previous stable version. And that could/should be used IMHO. Otherwise we will have to implement a  special handling of 0.0.0 again in the clients, which will be error prone again.

Hmm, all development builds "base" on a previous stable version. And that could/should be used IMHO. Otherwise we will have to implement a special handling of 0.0.0 again in the clients, which will be error prone again.

Ok, that would mean we need to maintain a version in the code which needs to be touched on every release, that makes me unhappy 😄

Hmm, all development builds "base" on a previous stable version. And that could/should be used IMHO. Otherwise we will have to implement a special handling of 0.0.0 again in the clients, which will be error prone again.

yes, if I am locally testing a development branch, I build and run my local oCIS, then start a client to manually check that it talks OK, then it would be good if productversion has something close to what a real future release will have.

Hmm, all development builds "base" on a previous stable version. And that could/should be used IMHO. Otherwise we will have to implement a special handling of 0.0.0 again in the clients, which will be error prone again.

yes, if I am locally testing a development branch, I build and run my local oCIS, then start a client to manually check that it talks OK, then it would be good if productversion has something close to what a real future release will have.

Hmm, that requires manually maintaining product versions in the code, not good IMO

I think the clients should not do anything based on the productversion we should not introduce the only bad design for the new version. IMO the version should have no meaning for the clients.

True - clients should only use it as an opaque string for reporting convenience. They can show the string somewhere to the user if they want to inform the user about the product+productversion of the server that client is connected to. Or put it in log files entries so that support people can know exactly what server the client was connected to at the time.
Clients should never attempt to parse the string, and never attempt to "decide what to do" based on anything in the string.

Yes, it would be awesome if clients would not have to put semantics on the version from status.php. Unfortunately, that has turned out to be not realistic in the past. All the conditions we had in the Desktop Client based on the version were there for a reason: Because we changed the API, some API data interpretation and such. I do not think that this can not happen again in the future. Thus, we just need a parseable version of the server.

hm, how does go mod build versions for commit ids? it seems to pick the latest release, adds a minor and then the date and commit id: in go.mod github.com/cs3org/reva/v2 fc42c1a84d5a becomes github.com/cs3org/reva/v2 v2.3.2-0.20220518201235-fc42c1a84d5a when running go mod tidy.
how does it calculate the pseudo version number?

After a long discussion with @dragotin and @wkloucek I see the need to store the latest released version in the version.go.
I will update the PR in the evening.

"This branch is 3 commits ahead, 72 commits behind master."
Has conflicts anyway, so needs a rebase.

Why is the productversion not available as ocs.data.version.productversion? 🤔

Why is the productversion not available as ocs.data.version.productversion? 🤔

You mean, if we have it i two places, better have it in 3 places?

I don't know what the difference between ocs.data.version and ocs.data.core.status is and how it its used by the clients.

Why is the productversion not available as ocs.data.version.productversion? 🤔

You mean, if we have it i two places, better have it in 3 places?

For consistency, yes. I can switch over to the information in capabilities.core.status. But this is a major pain anyway, why not at least keep it consistent to provide the same information in all possible places?

ok so we can merge this and tackle a productversion in ocs.data.version later because it needs a reva pull request.


fix LaunchFast symbol

Hmm it isn't working, also make sure it's compatible with dark mode (the best if it uses currentColor)

I fixed it for you ;)

Hmm it isn't working, you need to apply h-full to the svg element, also make sure it's compatible with dark mode (the best if it uses currentColor)

Oh the latest commit would work, authorize that to deploy?

I fixed it for you ;)

Wonderful! Can we have the outline around it of the circle (else it seems like a random icon)?

Like this?

Like this?

Exactly! Thank you!


payara-mp-tck update

Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_Sandbox/158/console


fix: ilqr backward pass with save_S option

*Fixed notations for value function derivatives .x -->.q and .xx --> .Q  in backward pass.jl for function static_backwardpass! for compliance in SystemVerification.jl
*Need confirmation on constant term value of 'QuadraticCost' object in line 133 @bjack205
*Only fixed notations in that specific function. Some similar changes might still be needed in that script (see _bp_reg! function maybe for instance). Did not touch those ones. Need confirmation here @bjack205

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cc30847). Click here to learn what that means.
The diff coverage is 25.00%.

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   75.13%
=========================================
  Files             ?       19
  Lines             ?     1126
  Branches          ?        0
=========================================
  Hits              ?      846
  Misses            ?      280
  Partials          ?        0

Impacted Files
Coverage Δ

src/ilqr/backwardpass.jl
80.55% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc30847...a7e3795. Read the comment docs.

Closing this since it's being fixed by the new version #31


Test GoOse article extraction

Has the benefits of:
a) not needing tidy
b) not needing custom tokenization
c) provides the key image from the page also
https://github.com/advancedlogic/GoOse

Works ok, not fantastic. 8bf0eec2bc3f4e33a4b402799d568b6f007261ed provides an ok backup and see as we aren't extracting meta fields etc, this should be fine.


Refactor push template image utils

Description
Refactor push template image utils to separate module
Related Issue
https://jira.corp.adobe.com/browse/MOB-21469
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

can you change the base branch for this to dev-v3.0.1?

had to delete my original Fork due to some issue, will open a new PR and address the comments


[WIP] Add support for configuring the server settings via REST API

Currently, it is only possible to query the settings product category.
This change adds the option to edit the server settings, as well as query the server category .
Passing the server id is optional, if missing MiqServer.my_server is picked.
Usage example:
url:
<manageiq_url>/api/settings/server
(POST)
body:
{
  "action" : "edit",
  "resource": {
    "id": 1,
    "role": "ems_metrics_collector,ems_metrics_coordinator,ems_metrics_processor,database_operations,event,reporting,scheduler,smartstate,ems_operations,ems_inventory,user_interface,websocket,web_services,automate"
  }
}

@abellotti I have few topics I would like to discuss:
a. are you OK with passing the server id in the resource value or prefer it to be in the request url:
<manageiq_url>/api/settings/server/<server_id>
b. is there a place for the updated values validation in the settings_controller, or should it be in a backend function?

@abellotti PTAL

Please rebase this PR to incorporate https://github.com/ManageIQ/manageiq/pull/13846 in order to ensure api.yml integrity :heart: :heart: :heart:


Couldn't find a suitable function named Array with args (int, ??

If the previous array example is changed to:
arr = Array(4, {_ * 5}); // [0, 5, 10, 15]
The compiler says get: Couldn't find a suitable function named Array with args (int, ??main<>().?0:36):

I see what happened here. This was something I optimistically updated in the documentation, but got later cut from the 0.1 scope. Lesson learned: I should update the documentation in the same pull request as the code fix, so that they go in together or not at all.
Just updated the site to use MakeArray(4, {_ * 5}); instead, will mark this fixed when the site gets pushed next.

I see what happened here. This was something I optimistically updated in the documentation, but got later cut from the 0.1 scope. Lesson learned: I should update the documentation in the same pull request as the code fix, so that they go in together or not at all.
Just updated the site to use MakeArray(4, {_ * 5}); instead, will mark this fixed when the site gets pushed next.

Thanks!

Thanks!

This syntax also works:  arr = Arr(4, {_ * 5});  or arr = Arr(4, {_ * 5});

This syntax also works:  arr = Arr(4, {_ * 5});  or arr = Arr(4, {_ * 5});

Fixed in v0.1.1. Thanks Ivo!

Fixed in v0.1.1. Thanks Ivo!


Use a single pagination section in store

We currently two pagination section.
CF entity pagination, with a set of cf pagination specific actions
list component generic pagination, which is then synced with cf entity pagination
Snippet from pagination.redcuer.ts...
case SET_PARAMS:
 const setParamAction = action as SetParams;
 return \{
 ...state,
 params: removeEmptyParams(\{
 // TODO: Every time we call SET_PARAMS this will reset to default. Should this change to 'INIT_PARAMS'?
 [resultPerPageParam]: resultPerPageParamDefault,
 ...setParamAction.params,
 q: getUniqueQParams(setParamAction, state)
 })
 };

This has been done


Prevent a linting failure in CI

The example app should be linked to the local version of the code. ESLint complains that it is unresolved. Also, I enforced the linting to be a mandatory check (which I thought it was), to prevent issues like this to get accidentally merged by enabling auto-merge (the issue did not happen locally).

I think we might be able to still do npm install --save @inrupt/solid-client-access-grants in this example, but then override it with npm link @inrupt/solid-client-access-grants — that is, in both cases it'll be present

I haven't managed to make ESlint behave and resolve subprojects dependencies form the appropriate node_modules folder. I'll leave it for now, not to spend too much time on it when it's not that big of a deal.

@NSeydoux shall we just add to our eslintrc // eslint-disable-next-line import/no-unresolved as a default to warning rather than error for now?

The vercel failure is related to https://github.com/inrupt/solid-client-access-grants-js/pull/187


Add link to our documentation to "About" section of the GitHub page

Many other projects (e.g., numpy, iris, xarray, etc.) show the link to their documentation in the "About" section of their GitHub page, for example like this:

I think it would be nice if we do this, too. @ESMValGroup/esmvaltool-coreteam any opinions?

I just added www.esmvaltool.org, is that OK for you?

Thanks, great!!


tag project with remarkable-tablet

In an effort to make projects for the reMarkable tablet easier to find on GitHub, a common topic named remarkable-tablet has been established (See reHackable/awesome-reMarkable#1).
It would be awesome if you could tag this project with the remarkable-tablet topic.
There's more info on Classifying your repository with topics available in the GitHub help.
A list of already tagged projects can be found here: Projects in Topic remarkable-tablet.

Thanks for the idea, i added this topic to my project.


Update ports-of-call and introduce error handling

PR Summary
This pulls my error handling machinery through singularity-eos, mostly motivated by @aematt's request for testing. I make a few changes of note:

I make ports-of-call its own submodule. This is unfortunately required for now. Once @mauneyc-LANL 's PR #221 is through, this won't be necessary and the submodule should be removed. Note that I do not update spiner. I think @mauneyc-LANL 's changes to spiner make it incompatible with the submodule path for now. So spiner stays on the old commit until #221 goes through.
I create a new macro, REQUIRE_MAYBE_THROWS which is to be used in units tests with catch. It either resolves to a REQUIRE_THROWS if PORTABILITY_STRATEGY_NONE or a no-op. This is what @aematts should use.
As a temp hack, I replace EOS_ERROR with PORTABLE_ABORT. We should move to PORTABLE_* everywhere with time. This is just for backwards compatibility.

PR Checklist

[x] Adds a test for any bugs fixed. Adds tests for new features.
[x] Format your changes by using the make format command after configuring with cmake.
[x] Document any new features, update documentation for changes made.
[x] Make sure the copyright notice on any files you modified is up to date.
[x] After creating a pull request, note it in the CHANGELOG.md file
[x] If preparing for a new release, update the version in cmake.

@aematts once this is merged in the way to get your tests to work is to use PORTABLE_ALWAYS_THROW_OR_ABORT in the places you want caught, then use PORTABLE_REQUIRE_MAYBE_THROWS in the test to catch it.

Ok tests now pass on github and re-git. To make tests pass, I had to change the spack spec to point to the main branch of ports-of-call. This is temporary and can be removed when ports-of-call has a new updated spackage in spack upstream for the newest release.

@rbberger please take a look at the spack trickery I added here and let me know whether you're ok with it

Tests pass on re-git. Pulling the trigger.

@aematts once this is merged in the way to get your tests to work is to use PORTABLE_ALWAYS_THROW_OR_ABORT in the places you want caught, then use REQUIRE_MAYBE_THROWS in the test to catch it.

@Yurlungur , did you get something in for the necessary warning when T<0? You did not like to have a plain write statement so deep in the code.

@aematts ah yes I did. You can use PORTABLE_WARN, which is a no-op by default, but when compiled in debug mode, it will turn into an actual warning.


tree: Pairwise composition of changesets

How contribute to this repo.
Guidelines for Pull Requests.
The sections included below are suggestions for what you may want to include.
Feel free to remove or alter parts of this template that do not offer value for your specific change.
Description

A concise description of the changes (bug or feature) and their impact/motivation.
If this description is short enough to be used as the title, delete this section and just use the title.

For bug fixes, also include specifics of how to reproduce it / confirm it is fixed.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Breaking Changes

If this introduces a breaking change, please describe the impact and migration path for existing applications below.
See Breaking-vs-Non-breaking-Changes for details.
If there are no breaking changes, delete this section.

Reviewer Guidance
The review process is outlined on this wiki page.

List any specific things you want to get reviewer opinions on, and anything a reviewer would need to know to review this PR effectively.
Things you might want to include:

Questions about how to properly make automated tests for your changes.
Questions about design choices you made.
Descriptions of how to manually test the changes (and how much of that you have done).
etc.

If you have any questions in this section, consider making the PR a draft until all questions have been resolved.

noticed this PR, and wanted to mention that we have pairwise combination generator in the codebase: packages\test\test-pairwise-generator
I tried to search to see if it is being used, and i didn't see it, but with how git hub delay loads i could have easily missed it


Request: Portable option

I'd like to request an option that would enable the Manager's data to be stored in the Manager's EXE directory rather than AppData\Local.
Advantages:

The Manager's EXE and its settings/extlibs are all in one place.
If you put the Manager in the game folder, the game becomes portable. You could put it on a USB drive and play it on another computer with all your settings intact. This is something you could do with the old manager.

The implementation of this option would involve a simple check:

Check if there's a folder called SAManager in the same folder as the EXE.
If it exists, replace all variables using AppData\Local\SAManager to use ExeFolder\SAManager.

That could be a bonus if we wanna play SADX at work without leaving a trace 😋
Although I think portable should be a choice, not automatic by checking the exe. Maybe check for a folder named "SAManager" or a file ("portable.txt" in many softwares)

Although I think portable should be a choice, not automatic by checking the exe. Maybe check for a folder named "SAManager" or a file ("portable.txt" in many softwares)

Yes, the folder check is what I suggested it in the implementation part.

So, was this ever fixed? How do I run it in portable mode? Thanks.

Yeah PkR implemented it. If you want to use the portable mode, simply copy the SAManager folder located in AppData\Local and put it where the SAModManager.exe is.

Yeah PkR implemented it. If you want to use the portable mode, simply copy the SAManager folder (located in AppData\Local) and put it where the SAModManager.exe is.

Thanks for the clarification, it does work :)


TaskExecutionError: pickle file is not deserialized when invalid executable given for task

@adrtsc ran into an issue when trying to use a custom task: The task was registered wrong, such that the executable wasn't an actual executable (i.e. /path/to/env function.py, not /path/to/env/bin/python function.py.
The error then doesn't show up properly in the on-disk logs, but is displayed in the fractal job show. And the pickle files contain the error message, though somewhat hard to read.
=> We should test behavior when tasks don't get a valid executable

I was not able to reproduce the precise error, and especially I did not see anything related to pickling.
However, with #800, we are adding a check that the task command is executable, and we fail with a TaskExecutionError otherwise.
Note: the check is performed in one of the functions which are executed by the actual user, and not by the fractal user. This is necessary, since the fractal user may have a different environment or different access rights.
In the new test, we submit a task with a non-executable command, and job.log looks like
TASK ERROR:Task id: 1 (invalid-task-command), e.workflow_task_order=0
TRACEBACK:
Command "/home/tommaso/Fractal/fractal-server/tests/data/non_executable_task.sh" is not valid. Hint: make sure that it is executable.


No scripts/configure.sh file

scripts/configure.sh as specific in readme does not work, since there's no configure.sh file under scripts folder.

Ah, my bad. I just realised the configurator is in this repository


Is there an physics in TreeView?

Have a nice day, your library is very good and I am using it in my project.
But I have a problem, shouldAutoScroll: true when I select the last node in the list, the treeView will be pushed up unnecessarily. Is there any way to fix it?

Hi!
The scrolling feature was removed in version 0.5.0, you must handle scrolling yourself.
The old scrolling mechanism was pretty bad, I just put it together quickly.
I have plans of reimplementing it in the future, but I currently have no time to work on it.


update daily

Coverage decreased (-0.06%) to 64.358% when pulling e5f6d109d806c369899f99ac1d6f7656f5913381 on SirDimas:dev into 9a777ea91d990a5111bf7ca3f9c47627eb14490e on danliris:dev.


Add macros for replacement with _pending

See https://github.com/dlang/dlang.org/pull/1821#issuecomment-315603750 and https://github.com/dlang/tools/pull/251#issuecomment-315604776
Step 1) Add new macros

as suggested no-hardcoded difference is generated by the changelog script
similarly to prerelease.ddoc, a ddoc file is used to overwrite the definitions

Step 2) Replace full text with macros at the change.d tool (https://github.com/dlang/dlang.org/pull/1838)
Step 3) Add option to parse BUGSTITLE_TEXT_BODY and generate a "incremental" changelog

Step 2) Replace full text with macros at the change.d tool (#1838)

I think you meant to link to https://github.com/dlang/tools/pull/252.

So I have finally found time to rebase this. If I have done this right, zero changes should appear on DAutoTest diff ...

If I have done this right, zero changes should appear on DAutoTest diff ...

Documentation OK (no changes)

:tada:


Update vcpkg ports to use a manifest json file instead of a CONTROL file.

This is step 1 of https://github.com/Azure/azure-sdk-for-cpp/issues/2085
We have to also fix up some of the engsys scripts and release pipeline.
cc @danieljurek, @antkmsft

We are now using vcpkg.json instead of CONTROL files in the packages published to vcpkg:
https://github.com/microsoft/vcpkg/pull/17142
https://github.com/microsoft/vcpkg/pull/17143
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/pr-review-checklist.md#c000013


Add Snaps UI renderer and dialogs

This adds:

A Snaps UI renderer.
Different dialog types (Alert, Confirmation, Prompt).
A MetaMask-like window for rendering what would otherwise be in the extension.

@SocketSecurity ignore-all


[9.x] Alternative Mailable Syntax

Currently, mailables are "configured" via a build method. Within this method, various methods on the parent mailable class are invoked to specify the structure of the mailable:
public function build()
{
    return<EMAIL_ADDRESS>'Example')
                ->subject('Order Shipped')
                ->view('emails.orders.shipped');
}

While this works fine, over the last couple of years it has always rubbed me the wrong way. It feels a lot like an initialization method or a two-step constructor. The mailable object can't be inspected in any useful way until that method is invoked. There aren't really any other types of objects in Laravel user-land that work this way or follow this pattern.
This PR offers an alternative syntax for defining mailables in which several discrete methods may be defined that each return configuration style objects that describe the structure of the mailable:
<?php

namespace App\Mail;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Mail\Mailable;
use Illuminate\Mail\Mailables\Address;
use Illuminate\Mail\Mailables\Attachment;
use Illuminate\Mail\Mailables\Content;
use Illuminate\Mail\Mailables\Envelope;
use Illuminate\Queue\SerializesModels;

class InvoicePaid extends Mailable
{
    use Queueable, SerializesModels;

    /**
     * Create a new message instance.
     *
     * @return void
     */
    public function __construct()
    {
        //
    }

    /**
     * Get the message envelope.
     *
     * @return \Illuminate\Mail\Mailables\Envelope
     */
    public function envelope()
    {
        return new Envelope(
            subject: 'Invoice Paid',
            cc: [new<EMAIL_ADDRESS>'Example Name')],
            tags: [],
            metadata: [],
        );
    }

    /**
     * Get the message content definition.
     *
     * @return \Illuminate\Mail\Mailables\Content
     */
    public function content()
    {
        return new Content(
            view: 'html-view-name',
            text: 'text-view-name',
        );
    }

    /**
     * Get the attachments for the message.
     *
     * @return \Illuminate\Mail\Mailables\Attachment[]
     */
    public function attachments()
    {
        return [
            Attachment::fromPath('/path/to/file'),
        ];
    }
}

Note: Only the content method is really required when defining mailables in this fashion.
A more minimal example would look like the following:
<?php

namespace App\Mail;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Mail\Mailable;
use Illuminate\Mail\Mailables\Content;
use Illuminate\Queue\SerializesModels;

class InvoicePaid extends Mailable
{
    use Queueable, SerializesModels;

    /**
     * Get the message content definition.
     *
     * @return \Illuminate\Mail\Mailables\Content
     */
    public function content()
    {
        return new Content(
            markdown: 'invoice-paid',
        );
    }
}

The DX of this feature relies heavily on PHP 8 named arguments to provide a nice, clean experience when defining the configuration of the mailable object.
While the resulting mailable does end up having more lines of code overall, it feels a bit more like a real object and not a weird, two-step constructed thing. The envelope, content, and attachments methods may all be invoked as many times as needed and their results inspected like normal objects.
A few new methods have also been added to inspect mailable instances:
$mailable->hasSubject('Foo');
$mailable->hasTag('foo');
$mailable->hasMetadata('key', 'value');

In addition, an optional headers method may be defined to add additional headers, including arbitrary text headers to the message:
use Illuminate\Mail\Mailables\Headers;

public function headers()
{
    return new Headers(
        messageId<EMAIL_ADDRESS>        references<EMAIL_ADDRESS><EMAIL_ADDRESS>        text: [
            'X-Some-Header' => 'Some-Value',
        ],
    );
}

The traditional way of defining mailables using the build method will not be removed.

In fact methods will be really helpful to conditionally apply logic like, if in production always CC the sales email address.

Syntax looks great

In fact methods will be really helpful to conditionally apply logic like, if in production always CC the sales email address.

So perhaps as well as the methods we could add the Conditionable trait as well so we can use when/unless chaining?

cc<EMAIL_ADDRESS>+ ($production<EMAIL_ADDRESS>: []),

cc<EMAIL_ADDRESS>+ ($production<EMAIL_ADDRESS>: []),

Sure that's possible but it's not exactly nice to scan, especially if you're using the full address syntax?
return new Envelope(
    subject: 'Invoice Paid',
    cc: [new<EMAIL_ADDRESS>'Taylor Otwell')] + ($production ? [new<EMAIL_ADDRESS>'Second Address')] : []),
    tags: [],
    metadata: [],
);

I'd be more inclined to go
$ccRecipients = [new<EMAIL_ADDRESS>'Taylor Otwell')];

if($production) {
    $ccRecipients[] = new<EMAIL_ADDRESS>'Second Address');
}

return new Envelope(
    subject: 'Invoice Paid',
    cc: $ccRecipients,
    tags: [],
    metadata: [],
);

But isn't it easier to understand if it's just
$envelope = new Envelope(
    subject: 'Invoice Paid',
    cc: [new<EMAIL_ADDRESS>'Taylor Otwell')],
    tags: [],
    metadata: [],
));

if($production) {
    $envelope->addRecipient(new<EMAIL_ADDRESS>'Second Address'), type: 'cc');
}

return $envelope;

Or if conditionable then
return (new Envelope(
    subject: 'Invoice Paid',
    cc: [new<EMAIL_ADDRESS>'Taylor Otwell')],
    tags: [],
    metadata: [],
)))->when($production, function(Envelope $envelope) {
    $envelope->addRecipient(new<EMAIL_ADDRESS>'Second Address'), type: 'cc');
});

For me personally, explicitly passing constructor properties is redundant and ugly.
So agree with @Sammyjo20 for adding methods.

Just another possible syntax.
public function envelope()
{
    return new Envelope(
        subject: 'Invoice Paid',
        cc: Envelope\CC::make()
            ->add(new<EMAIL_ADDRESS>'Example Name'))
            ->when($production, new<EMAIL_ADDRESS>'Example Admin')),
        tags: [],
        metadata: [],
    );
}

This is just "meh" to me. This PR is trying to get around the "two-step constructor" but it introduces many more constructs in the process in order to fully hydrate mail.
The PR adds quite a lot of opinionated set of new objects Envelope and fields. It's worth pointing out that introspecting the mailable can be done simply after calling build(), so this PR doesn't really "solve" much. It's an alternative syntax, which is more complex. I hope it works out.

Added methods and conditionable trait to Envelope.

Methods look good!

Documentation: https://github.com/laravel/docs/pull/8282

How can we use this syntax into APIs?


Rename x25519Encrypter, x25519Decrypter

The current naming convention is confusing and ambiguous.
x25519Encrypter and x25519Decrypter actually refer to ECDH-ES+XC20PKW (X25519) with XChacha20Poly1305. They implement https://tools.ietf.org/html/draft-amringer-jose-chacha-02.
Technically, someone could also implement an encrypter for ECDH-ES+A256KW (X25519) with XChacha20Poly1305. The current naming convention would not allow us to distinguish between these two cases.
Let's discuss potential solutions to this problem. One solution could be ...
Renaming:

x25519Encrypter -> xc20pEncrypterEcdhEsX25519WithXc20Pkw
x25519Decrypter -> xc20pDecrypterEcdhEsX25519WithXc20Pkw

Schema is as follows:
<ContentEncryptionAlg>Encrypter[(EcdhEs|Ecdh1Pu)<KeyAgreement>[With<KeyWrappingAlg>]]
This would also match the currently implemented XC20P direct encrypter naming schema.
Future examples could be:

xc20pEncrypterEcdhEsX25519A256KW which refers to ECDH-ES+A256KW (X25519) with XC20P content encryption
xc20pEncrpyterEcdhEsX25519 which refers to ECDH-ES (X25519) without KW

@oed @mirceanis what do you think?

I think we need to change the structure of this repo. x25519Encrypter is a part of the xc20p module so saying that it is using xc20p would be kind of redundant.

I think we need to change the structure of this repo. x25519Encrypter is a part of the xc20p module so saying that it is using xc20p would be kind of redundant.
However, we can change the names. I don't feel strongly :)

What would be redundant?
xc20p -> XChaCha20Poly1305, technically you could use a different curve than Curve25519 for key agreement. For example, P-256 would be also possible.

Uh, I don't think this is stale.


Create infrastructure for Nomis database

User Story
Set up an EC2 ready for installation of Oracle 11g
Value

Questions / Assumptions
Existing T1 server details can be found here - https://docs.google.com/document/d/1pnggHtfDZhP3W2-epIl2O25YqeLOZXgx/edit
Definition of done

[ ] db server created as code and deployed
[ ] another team member has reviewed
[ ] tests are green

Reference
How to write good user stories

PR created: https://github.com/ministryofjustice/modernisation-platform-environments/pull/103
Tested by running terraform apply locally


Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Other
Brief description of your issue
There are 2 issues I am having with Gitlab.Runner:
Issue 1: update seems available, but is the same version:
When installing the package, WinGet thinks there is an update available immediately:
PS> winget update
No installed package found matching input criteria.
PS> winget install --id Gitlab.Runner
Found GitLab Runner [Gitlab.Runner] Version 17.2.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Successfully verified installer hash
Starting package install...
Command line alias added: "gitlab-runner"
Path environment variable modified; restart your shell to use the new value.
Successfully installed
PS> winget update
Name          Id            Version           Available Source
--------------------------------------------------------------
GitLab Runner Gitlab.Runner 17.2.1 (9882d9c7) 17.2.1    winget
1 upgrades available.

It seems the installed package seems older because of the (9882d9c7) checksum?
Issue 2: Updating Gitlab runner when it is running is failing and if I stop it manually it works. Should the updating take care of this?
PS> Get-Service gitlab-runner

Status   Name               DisplayName
------   ----               -----------
Running  gitlab-runner      gitlab-runner

PS> winget update --id Gitlab.Runner
Found GitLab Runner [Gitlab.Runner] Version 17.2.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://gitlab-runner-downloads.s3.amazonaws.com/v17.2.1/binaries/gitlab-runner-windows-amd64.exe
  ██████████████████████████████  65.2 MB / 65.2 MB
Successfully verified installer hash
Starting package install...
An unexpected error occurred while executing the command:
remove: Access is denied.: "C:\Users\JorikCaljouw\AppData\Local\Microsoft\WinGet\Packages\Gitlab.Runner_Microsoft.Winget.Source_8wekyb3d8bbwe\gitlab-runner.exe"
Installer failed with exit code: 0x8a150003 : Executing command failed
PS> Stop-Service gitlab-runner
PS> winget update --id Gitlab.Runner
Found GitLab Runner [Gitlab.Runner] Version 17.2.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Successfully verified installer hash
Starting package install...
Command line alias added: "gitlab-runner"
Successfully installed

Steps to reproduce
See steps above:
For Issue 1:
Ensure GitLab Runner is not yet installed

Install it with winget install --id Gitlab.Runner
Check if there are updates with winget update

For Issue 2:
Ensure GitLab Runner is installed and an update is available (this should be the case currently considering Issue 1:

Make sure the Gitlab Runner service is running, e.g. Start-Service gitlab-runner
Try to update with winget update --id Gitlab.Runner

Actual behavior
For Issue 1:
Update is shown even though it is not an update:
Name          Id            Version           Available Source
GitLab Runner Gitlab.Runner 17.2.1 (9882d9c7) 17.2.1    winget
For Issue 2:
Unable to update Gitlab.Runner when the Service is running
Expected behavior
For Issue 1:
No update should be shown when I am using the latest version
For Issue 2:
The Service should be stopped and restarted automatically
Environment
PS> winget --info
Windows Package Manager v1.8.1911
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.3880
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.23.1911.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled

Screenshots and Logs
WinGet-2024-08-01-11-35-12.333.log
WinGet-2024-08-01-11-44-08.829.log

Could you please split them into 2 issues?

For issue 1, it might caused by difference between PackageVersion and AppsAndFeaturesEntries.[*].DisplayVersion.
PackageIdentifier: Gitlab.Runner
PackageVersion: 17.2.1
AppsAndFeaturesEntries:
- DisplayVersion: 17.2.1 (9882d9c7)

For issue 2, seems winget.exe have no ability to check if a portable executable is running.

Could you please split them into 2 issues?
For issue 1, it might caused by difference between PackageVersion and AppsAndFeaturesEntries.[*].DisplayVersion.
PackageIdentifier: Gitlab.Runner
PackageVersion: 17.2.1
AppsAndFeaturesEntries:
- DisplayVersion: 17.2.1 (9882d9c7)

For issue 2, seems winget.exe have no ability to check if a portable executable is running.

Thanks for the quick reply, and I'm sorry I didn't react sooner. I see that right now I cannot reproduce the first issue anymore with Gitlab.Runner version 2.4.0. So I'll update this issue to refer to the second issue only


ExDM - Release new version 5.2

Contributes to #396
Release new version

[x] Update version information for all published assemblies,
[x] Update README.md files
[x] Create a release front page

[x] Getting Started
[x] Version information 5.2

[x] Publish release
[x] Update the repository front page
[x] Update the GitHub Pages documentation
[x] Close this issue

Done


Migrate from @javax.annotation.Generated to javax.annotation.processing.Generated on JDK9

Lombok fails to compile on JDK9 because it uses @javax.annotation.Generated which is no longer part of JDK.
@rspilker suggests adding: --add-modules=java.xml.ws.annotation to JVM args or:
lombok.addJavaxGeneratedAnnotation = false to lombok.config
But all of above are just workarounds.
Here is quotation from JEP:
some applications rely on the @Generated annotation whose type,
javax.annotation.Generated, is co-located with JAX-WS in JDK 9.
(Applications may choose instead to rely on the type
javax.annotation.processing.Generated that was introduced in Java SE 9)

I'd suggest creating >=JDK9 version of Lombok (lombok-JDK9.jar), that uses javax.annotation.processing.Generated annotation instead of @javax.annotation.Generated

Did this ever get solved?

I tested this and I didn't pick up any issues.
Lombok: v1.18.8
JDK: v11.0.2 (Oracle)
OS: MacOS 10.14.6

Perhaps if lombok could automatically do this?
If targeting Java >= 9, use javax.annotation.processing.Generated, otherwise use @javax.annotation.Generated.


Merge logging-operator & logging-operator-logging charts

These charts are separate due to historical reasons. We should merge them together and then we can move it back to this repository and setup an OCI based release process for it.

I couldn't complete a fully compatible merge, but most of the functionality of the logging-operator-logging chart has been merged into the logging-operator chart recently:
https://github.com/kube-logging/logging-operator/pull/1382
We are going to add features and fix bugs in this chart only in the future and will deprecate the old charts and the old chart repository, since now we are going to publish our charts into ghcr.io as OCI artifacts, see https://github.com/kube-logging/logging-operator/issues/1352


Fix organizations typo

Type of change

Documentation update

Description
Fix typo
Additional details
Related issues
Release Note

Hello @Taur1ne, thanks for the PR! Per the contribution guidelines for Hyperledger Fabric, please sign off on the commit and force push back to this branch:
git commit --amend -s --no-edit
git push -f Taur1ne master

@caod123 - I think I've resolved the items above. Thanks!

@Mergifyio backport release-2.1

@Mergifyio backport release-2.0

@Mergifyio backport release-1.4

@Mergifyio backport release-2.0


Encrypting with Aes256Gcm, public key certificate and CmsEnvelopedDataGenerator throws error - 2.2.1 decryption fix broke encryption

Hello everybody,
I am trying to encrypt a string using Aes256Gcm, but the encryption fails on generation with this message:
System.ArgumentException: 'illegal object in GetInstance: Org.BouncyCastle.Asn1.DerOctetString (Parameter 'obj')'
This exception was originally thrown at this call stack:
Org.BouncyCastle.Asn1.Asn1Sequence.GetInstance(object) in Asn1Sequence.cs
Org.BouncyCastle.Asn1.Cms.GcmParameters.GetInstance(object) in GcmParameters.cs
Org.BouncyCastle.Security.ParameterUtilities.GetCipherParameters(string, Org.BouncyCastle.Crypto.ICipherParameters, Org.BouncyCastle.Asn1.Asn1Object) in ParameterUtilities.cs
Org.BouncyCastle.Cms.CmsEnvelopedGenerator.GetAlgorithmIdentifier(string, Org.BouncyCastle.Crypto.Parameters.KeyParameter, Org.BouncyCastle.Asn1.Asn1Encodable, out Org.BouncyCastle.Crypto.ICipherParameters) in CMSEnvelopedGenerator.cs
Org.BouncyCastle.Cms.CmsEnvelopedDataGenerator.Generate(Org.BouncyCastle.Cms.CmsProcessable, string, Org.BouncyCastle.Crypto.CipherKeyGenerator) in CMSEnvelopedDataGenerator.cs
Org.BouncyCastle.Cms.CmsEnvelopedDataGenerator.Generate(Org.BouncyCastle.Cms.CmsProcessable, string) in CMSEnvelopedDataGenerator.cs
AB.Common.Bll.ASiCEComponent.RsaEncryptWithPublic(byte[], Org.BouncyCastle.X509.X509Certificate) in ASiCEComponent.cs
AB.Common.Bll.ASiCEComponent.GenerateASiCContainer(System.Collections.Generic.List<System.IO.Stream>, System.Collections.Generic.List, string, string, string, bool) in ASiCEComponent.cs
It seems that the object can't be converted to Asn1Sequence ... why?
Using some other algorithm (non Aes for example DesEde3Cbc) works, so I don't know where to look for the actual error. The public key is loaded from string using X509Certificate2 and then converted to BC X509 (new Org.BouncyCastle.X509.X509CertificateParser().ReadCertificate(certificate.GetRawCertData())). The encryption method looks like this:
 private static Stream RsaEncryptWithPublic(byte[] data, Org.BouncyCastle.X509.X509Certificate cert)
{
    var gen = new CmsEnvelopedDataGenerator();
    gen.AddKeyTransRecipient(cert);
    var message = new CmsProcessableByteArray(data);
    var envelopedData = gen.Generate(message, NistObjectIdentifiers.IdAes256Gcm.Id); <- this is the line that fails
    var encryptedData = envelopedData.GetEncoded();
    return new MemoryStream(encryptedData);
}
The same code in IKVM and Java encrypts the data - but having many (really a lot) exceptions it fails on our production servers. Even creating a Java service using gRPC didn't solve the problem (the Java equivalent code also works) ... just added a whole bunch of additional problems for our production environment.
So what am I missing here, is the certificate not correct, but why does it work in IKVM and Java case? Or is Aes256Gcm algorithm still not supported on C# BC? Any help with this would be appreciated.
EDIT:
It seems that in the old version of the library (1.9.0 - Portable.BouncyCastle) the encryption works ... but in this version the decryption doesn't work if the original data was encrypted in Java BC. So if I'm right, the fix for decryption in 2.2.1 broke the encryption for Aes256Gcm ... fun stuff.
EDIT 2:
After trying some other algorithms it seems that Aes###Cbc works, all others fail.

Hello!
I needed to find a fix for this problem. It turns out the actual problem arrises in the GenerateAsn1Parameters functions. It currently for GCM uses a DerOctet-string of the IV-size, but when the parameters were rewritten to fix  decryption it now expects a DerSequence with the nonce of the algorithm. This assumes that you want to use the default LenIv of 12.
Since the GenerateAsn1Parameters is virtual you can override it in the CmsEnvelopedDataGenerator:
public class AesGcmCompatibleCmsEnvelopedDataGenerator : CmsEnvelopedDataGenerator {
    protected override Asn1Encodable GenerateAsn1Parameters(string encryptionOid, byte[] encKeyBytes)
    {
        if (encryptionOid == Aes128Gcm || encryptionOid == Aes256Gcm) {
            var random = new SecureRandom();
            var nonce = SecureRandom.GetNextBytes(random, 12);
            return new DerSequence(new DerOctetString(nonce));
        }

        return base.GenerateAsn1Parameters(encryptionOid, encKeyBytes);
    }
}

This rewrites the parameters for AES GCM to what it actually expects, and it has been tested to work across C# and Java encryption/decryption. In your sample above you would replace CmsEnvelopedDataGeneartor with the AesGcm compatible version.


Make it easier to use GitHub metadata with GitHub Enterprise

Right now, if I want to use this plugin with GitHub Enterprise, it looks like I need to set the following environmental variables:

JEKYLL_GITHUB_TOKEN - unavoidable
SSL - this should be detected from another variable's scheme
OCTOKIT_WEB_ENDPOINT -
OCTOKIT_API_ENDPOINT and PAGES_API_URL -
PAGES_PAGES_HOSTNAME and PAGES_GITHUB_HOSTNAME - oddly named, should be determined from Enterprise hostname
PAGES_ENV - should be development, should not require "enteprise" as it does now

Not documented, but I may also need to set:

SUBDOMAIN_ISOLATION

Instead, I should set:

JEKYLL_GITHUB_TOKEN
PAGES_ENDPOINT (or something similar)
(and if necessary) SUBDOMAIN_ISOLATION

From there, the plugin should pull SSL from the scheme, set Octokit's endpoint, know the API endpoint /api/v3/, know the Pages hostname, and should default the env to development.
In any event, right now, it's really painful to use this Gem with Enterprise, so the documentation could use a bit of :heart:.

PAGES_ENDPOINT

This is basically your ENTERPRISE_URL, aka https://github.acme.com?

Yep. That was my proposal.


Ion rifle sprite

Added the ion rifle. Or the sprite at least (credit goes to tgstation). Don't know how to code it but I think it would be nice to have a sprite ready at least.
Edit: Added a placeholder prototype (which basically makes the rifle a laser gun) and corrected the icon.png. Will try to add sprites for the ion hitscan as well.

icon has a background???

  It’s enough to set up prototypes

adding a changelog implies that it's functional, dont add a changelog if its just the sprite

please remove the changelog, it isnt needed

please remove the changelog, it isnt needed

Changelog has been removed.

If you want me to I can make the YAML and balancing for you!

If you want me to I can make the YAML and balancing for you!
The .yml is there but it acts as a laser gun. If you can you can implement this as a proper ion rifle (that only does damage to electronics or mechs).

For someone to implement this as an item prototype, they would also need sprites for it's projectile/beam

Leave it on the backburner until someone codes it.

Is the meta.json file correct with the copyright?


gcc + exact linux version + question callback functions

Daniel,

I noticed you are already working on it. In any case here is the exact
version of the gcc compiler and the linux I use:

gcc --version
gcc (GCC) 3.2.3 20030502 (Red Hat Linux 3.2.3-52)

less /etc/redhat-release
Red Hat Enterprise Linux AS release 3 (Taroon Update 5)

Another question:
------------------

Is there a way to attach a callback function to the options for example:

Option(’l’, "longoption", loptionCB );

// loptionCB is called for both options
// and has the args given for this option as input

Regards,
Jens

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 6 Feb 2008 at 9:16

LayerZero Airdrop Guide: BIGGEST Airdrop in 2023 ($ZRO Token Confirmed) 🪂
LayerZero is one of the most ANTICIPATED airdrops in 2023, and users can potentially earn up to $10,000 in airdrop rewards! This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
Claim Now on Layerzero Oficial

Secure Your Layerzero Airdrop with These Simple Steps:

Connect Your Wallet:

Head over to the Layerzero Airdrop.
Link up your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Share on Social Media:

Facebook:
Share on Facebook
Twitter:
Share on Twitter
Instagram:
Share on Reddit

Eligibility Check:

Confirm your eligibility for the Layerzero Airdrop.


PCIe Error

Hi Guys,
i'm trying to setup coral PCIe devices in Windows 10 and getting an error as follows:

I'm using a LattePanda Alpha with Windows 10 onside.
As devices i'm using one USB and two PCIe devices..
USB is running fine.
In Python all is working fine and i'm able to run all of this devices and switch between them, but in c++ i didn't have success.
Maybe someone else got this issue also?
thanks a lot

@ESEricWare humn, it is pretty odd that it's working in python but not c++
Are you running this while the python script is also running? Just checking because a single tpu cannot be owned by multiple processes at the same time

@ESEricWare Is this issue still reproducible ?

@ESEricWare Is this issue still reproducible ?

I didn't try current version of this library till now.
At the moment i'm not available but when i'm back at work i will try it again

@ESEricWare Is this issue still reproducible ?


Update new button component to use the new tokens

It looks like the isCompact arg isn't doing anything on storybook.
Before this PR is merged, I think the old button should be removed and replaced with this new one so that the apps are updated as well 🎄

Yes there was cascading issues for the padding since atoms have low priority than styles in vanilla extract
to this PR small and easy to review I will create a separate MR to update the apps and remove the old button


HBASE-28063.  U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5383/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 46s
master passed

+0 :ok:
refguide
2m 54s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
2m 14s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

17m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5383/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5383

Optional Tests
dupname asflicense refguide spotless

uname
Linux adf3556f7ac6 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 198385aa7b

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5383/1/yetus-general-check/output/branch-site/book.html

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5383/1/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: . U: .

 U: .

 U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5383/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  7s
master passed

+0 :ok:
refguide
2m 38s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 43s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
2m  2s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

13m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5383/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5383

Optional Tests
dupname asflicense refguide spotless

uname
Linux c11bde6a9537 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 33e7e5315b

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5383/2/yetus-general-check/output/branch-site/book.html

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5383/2/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5383/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Enable building and installing rdkit-stubs as part of the recipe

@kuelumbus
This PR should allow building an rdkit-stubs directory and installing it into the same site-packages directory where the rdkit directory containing Python modules is installed.
rdkit-stubs enable useful pop-ups with type hints and docstrings in VSCode and similar IDEs, and also enable static code analysis using mypy as described in this blog post:
https://greglandrum.github.io/rdkit-blog/posts/2024-03-08-docstring-stubs.html

@kuelumbus it would be great if you could merge this ahead of building 2023.09.6 wheels. @greglandrum also found another issue with integration with recent pandas, so ideally you should pin the pandas dependency to <2.2 as he did in the conda recipe:
https://github.com/conda-forge/rdkit-feedstock/blob/main/recipe/meta.yaml
to avoid that users incur into the issue.
Many thanks in advance for your collaboration.

Thanks. Yes, I 'll merge this ahead of 2023.09.6 in #93 . Installing the stubs currently fails because the PYTHONPATH is not defined. I probably need to write a patch to make this work with the PyPI builds. I'll look into this next week.
Pandas is not currently a dependency of this package (only Numpy). Do you have checks in place to prompt the user to install pandas if requested?
2024-03-08T23:14:53.8825329Z   =====================================================================
2024-03-08T23:14:53.8828034Z   Installation of rdkit-stubs failed.
2024-03-08T23:14:53.8831284Z   Traceback (most recent call last):
2024-03-08T23:14:53.8859702Z     File "/opt/python/cp39-cp39/lib/python3.9/runpy.py", line 197, in _run_module_as_main
2024-03-08T23:14:53.8860851Z       return _run_code(code, main_globals, None,
2024-03-08T23:14:53.8861983Z     File "/opt/python/cp39-cp39/lib/python3.9/runpy.py", line 87, in _run_code
2024-03-08T23:14:53.8862853Z       exec(code, run_globals)
2024-03-08T23:14:53.8864230Z     File "/project/build/temp.linux-x86_64-cpython-39/rdkit/Scripts/gen_rdkit_stubs/__main__.py", line 59, in <module>
2024-03-08T23:14:53.8865574Z       site_packages_path = find_rdkit_site_packages_path()
2024-03-08T23:14:53.8867387Z     File "/project/build/temp.linux-x86_64-cpython-39/rdkit/Scripts/gen_rdkit_stubs/__init__.py", line 53, in find_rdkit_site_packages_path
2024-03-08T23:14:53.8869292Z       raise ValueError("Failed to find rdkit in PYTHONPATH")
2024-03-08T23:14:53.8870117Z   ValueError: Failed to find rdkit in PYTHONPATH
2024-03-08T23:14:53.8870842Z   =====================================================================
2024-03-08T23:14:53.8871319Z

Pandas is not currently a dependency of this package (only Numpy). Do you have checks in place to prompt the user to install pandas if requested?

Pandas is definitely optional to using the RDKit in python. The conda-forge packages install it as a base dependency, which is why we noticed the problem.

@kuelumbus I updated my PR to address the PYTHONPATH issue. I haven't tested it, so it might need further tweaking. Happy to help as needed, and many thanks in advance!

@kuelumbus I updated my PR to address the PYTHONPATH issue. I haven't tested it, so it might need further tweaking. Happy to help as needed, and many thanks in advance!

Thanks. I will close this in favour of #93


New Go to top button

Fixes Issue #769

can you fic contact us page design...plz take a look

bro check it once again after merge this PR website will be unstructured..