Add DisableSameLayerUnpack option to cri config

This change adds a new option named DisableSameLayerUnpack that stops Containerd from being able to unpack the same layer in parallel. This is most common if a pull of the same image is performed at the same time or different images that share layers being pulled at the same time.
This change relies on https://github.com/kevpar/containerd/pull/33 landing to make use of the containerd.WithDisableSameLayerUnpack() option so I've left it as a draft for now to avoid an accidental merge but this is free to review.

@msscotb @kevpar @katiewasnothere @anmaxvl @ambarve @helsaawy

Ok this merged https://github.com/kevpar/containerd/pull/33. Need to vendor in our fork here and then we can get this in


Add AWS_SESSION_TOKEN with empty value in secrets

If you do not provide the AWS_SESSION_TOKEN the Replication Controller will fail.

LGTM!


Update Chrome and Chromedriver to v83 on ubuntu 18.04 image

Question, Bug, or Feature?:
Could Chrome be updated to version 83.0.4103 on the ubuntu 18.04 image?
Virtual environments affected

[ ] Ubuntu 18.04 LTS

Hello, @AshTappin
We are planning to deploy a new roll-out with Google Chrome 83 on the next week.
Test builds:
https://github.visualstudio.com/virtual-environments/_build/results?buildId=69941&view=logs&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=72559e73-928c-58e0-b67e-e22d7a78faae
- Google Chrome (Google Chrome 83.0.4103.61 )
- ChromeDriver 83.0.4103.39 (ccbf011cb2d2b19b506d844400483861342c20cd-refs/branch-heads/4103@{#416}); Chrome Driver is available via CHROMEWEBDRIVER environment variable

Great @al-cheb !

Hello, do you know if Chrome 83 will be rolled out on the windows environments as well?

@bgoggan you can follow up releases here
https://github.com/actions/virtual-environments/releases
Google Chrome version: 83.0.4103.61 is shipped with this week's win19 image

@miketimofeev thank you for that link. If I read it correctly it says the windows-2109 update was released 2 days ago. Does that mean any runs now selecting it should have chrome 83? My apologies if that's a silly question, I just saw v81 still being used in a recent run.

@bgoggan pre-release label means it's still deploying. When the deployment is finished the label will dissapear.

@miketimofeev thank you.

@miketimofeev  week passed and it still has pre-release label. Do you have any information when we can expect this update?

@dz1dz1on Unfortunately, we had to cancel the previous week's deployment due to found issues on Ubuntu images. We started a new deployment on Friday and going to finish it on Wednesday. The new software lists available here
https://github.com/actions/virtual-environments/releases/tag/ubuntu16%2F20200604.1
https://github.com/actions/virtual-environments/releases/tag/ubuntu18%2F20200604.1
As a workaround you can you use these steps to update Chrome:
sudo apt-get update
sudo apt-get upgrade google-chrome-stable -y

And these to update the driver:
CHROME_VERSION=$(google-chrome --product-version)
CHROME_VERSION=${CHROME_VERSION%.*}

# Determine latest release of chromedriver
# Compatibility of Google Chrome and Chromedriver: https://sites.google.com/a/chromium.org/chromedriver/downloads/version-selection
LATEST_CHROMEDRIVER_VERSION=$(curl "https://chromedriver.storage.googleapis.com/LATEST_RELEASE_$CHROME_VERSION")

# Download and unpack latest release of chromedriver
echo "Downloading chromedriver v$LATEST_CHROMEDRIVER_VERSION..."
wget "https://chromedriver.storage.googleapis.com/$LATEST_CHROMEDRIVER_VERSION/chromedriver_linux64.zip"
unzip chromedriver_linux64.zip
rm chromedriver_linux64.zip

CHROMEDRIVER_DIR="/usr/local/share/chrome_driver"
CHROMEDRIVER_BIN="$CHROMEDRIVER_DIR/chromedriver"

sudo rm -rf $CHROMEDRIVER_DIR/*
sudo rm -rf $CHROMEDRIVER_BIN/*

sudo mkdir -p $CHROMEDRIVER_DIR
sudo mv "chromedriver" $CHROMEDRIVER_BIN
sudo chmod +x $CHROMEDRIVER_BIN
chromedriver --version

Thank you for your patience and sorry for the inconvenience.


getPurchaseHistory and refunds on Android

When using getPurchaseHistory() on Android, I still see a purchase item in the list even if I issued a refund in the payment console. (Can't confirm behavior on iOS)

I'm facing the same issue, didn't find any clue in StackOverflow, the only hint I can get is related to "revoke" when you start the refund in the playstore console, but I already refund the product without checking "revoke" so it can't be tested

Tried consuming item, but got a successfull response only once, anyway the product still appears in history:
List<PurchasedItem> purchasedItems = await FlutterInappPurchase.getPurchaseHistory();

purchasedItems.forEach((item){
        if(item.productId == 'PRODUCT_ID'){
          FlutterInappPurchase.consumePurchase(item.purchaseToken);
        }
      });


UI should display server errors it cannot deal with to the user

Presumably done (with an exception of taskresult, but that is trivial - just around 2-3 lines of the same piece of code).
Due to lack of an exact description I close the issue.
If needed, reopen a new one.

Presumably done

@istvan-satmari OK, I take it that from now, whenever an error message is delivered by the API, it is either processed by the client, or shown to the user.


deps: Update Flutter and packages

This cleans up a couple of things that were either printing a warning or dirtying the tree. Also gets us the latest set of dependencies, for good measure.

LGTM, thanks! Merging.


How do i import in my React Project

So sorry that i can't find the way to import to the project.
Can u explain how to import it from filename like blood_b_n to the react project.
Thank you in advance

@izzabellerina I will respond later today, or tomorrow with some sample code.

@nburka
Thank you in advance , and i found the solution but the problem is that I set the color = red and then the icon didn't change for me
<BloodBag color="red" height={36} width={36} />
I found solution from this website
https://www.npmjs.com/package/healthicons-react
Thank you again

Nice! I didn't even see your response here before I tried it myself. It is super easy. All I did was:

create a sample React app using create-react-app
add the NPM package for the icons using: npm i healthicons
edited the App.js and added import { ReactComponent as HeartIcon} from 'healthicons/public/icons/svg/filled/body/heart_organ.svg'; and then used the icon by adding: <HeartIcon color="red" height={100} width={100} />

Glad it worked for you!!

It looked like this:

I'll close this issue. But let me know if you have any more questions.


[MINOR] Fix some typos and delete unused parameter

Change Logs
Fix some typos and delete unused parameter in Table File System View.
Impact
No
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

CI is green.


Add Collaborator Event to Github Repository Webhooks

We want to automatically update the collaborator list in Bonsai whenever a collaborator is added to a tracked Github repository.
When we register the webhook for an asset in it's Github repository, we should include the "member" event.   This will allow us to receive webhook notifications when the collaborator list is modified.
See full list of webhook events:
https://developer.github.com/webhooks/
Additionally, we should limit the type of incoming events that can trigger a recompile.   We should track watch, member, and release.
Additionally, if the incoming event  is "watch" or "member", we should not recompile releases.  This should only happen on a "release" event.

Pull Request #196


Vienna should automatically defrag messages database

Vienna should call VACUUM for it's internal database to reduce file size.
I have called this manually and the messages.db file size decrease from 25 MB to 13.5 MB
https://sqlite.org/lang_vacuum.html

The necessary code is already there : https://github.com/ViennaRSS/vienna-rss/blob/master/src/Database.m#L479-L489
Just need to understand why this wouldn’t be called.

@barijaona it seems to only be called when you empty the trash.
We could do what was suggested over at objc.io and store the date of last_vacuum in NSUserDefaults and get Vienna to run it weekly.

Apparently, there was at a time an attempt to introduce a preference on emptying the trash. But currently,  Database purgeDeletedArticles is never called if the preference to move articles to the Trash is set to 'never'.
Related : issue #529

Interesting. Well I am currently reworking the preference panes to use base internationalisation and auto-layout so once I've done that I can easily add in a new option for emptying the trash.
We should still think about a weekly vacuum though.
On a side note, why do our constants start with MA?

The problem with that is if you have a large database like I do, you delay the quitting process by a few minutes.

@josh64x2 There are APIs to defer work to a separate background process.
https://developer.apple.com/library/content/documentation/Performance/Conceptual/power_efficiency_guidelines_osx/DiscretionaryTasks.html


Append Git commit to ISO and zsync file names

It would be helpful to keep track of the commit creating the ISO and the zsync file.

You are right about it. But, for that purpose, we need to create statically named symlinks on the server, that point to the newest files (the ISO image and the zsync file).

cc @lnxslck

We could, rather, write the commit on a file in the ISO. It could be easier to manage the updates in that way.

How would it look like?

Something like /.git-commit. The content of that file should contain the commit hash that created that specific ISO.

Do the symlinks work?

It creates files name like this  IMAGE-d665758.iso so we can symlink nitrux_release_stable or development to the latest image generated by Travis.

It would be better to use a standard name for the images generated by the branches, and to write the commit hash somewhere in the image. In that way, we will not be creating lots of files with different names in our server. Uploading files to it would overwrite the old ones, which would be the ideal way of operation.


Feat: add HUST

Add HUST

@quangh0409 I am sorry, the domain sis.hust.edu.vn is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


How do I change cache control headers on responses?

So far as I can tell, there is no way for me to set my own cache-control headers on assets.
I've tried using serveModify, but it looks to me like any settings I put here for 'Cache-Control' or 'Expires' are overwritten by lines 388 / 399:
'Cache-Control': 'public,max-age=' + 31536000,
'Expires': response.expires || (new Date(new Date().getTime()+63113852000)).toUTCString(),

So am I correct in saying I am unable to set a bespoke max-age for an asset?
I don't want my files to have a max-age of a year, I would prefer something closer to an hour as they may well change.
I'm not sure however if I've misunderstood something in the implementation but it appeared to me that others may have used the serveModify method to overwrite the default headers but I do not seem able to?

@geek-caroline I needed this, so i've implemented on my own fork. Now sending the PR to upstream. Cheers!


Update document to include how to use selector across entities

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

N/A

Any log messages given by the failure

N/A

Expected/desired behavior
I would like to see documentations on how to use selectors on both hero and villain entities. I couldn't figure it out, since all the features are implemented as EntityCollectionServiceBase<T> which is not available in root reducers.
For example, I would like to display total number heroes and villains on the page. It requires to have access to the entityCache. If that is the solution, can you document it.
One way I can think of is to create NgrxDataService like NgrxDataToastService and dispatch an action that contains data of interests, having it store in a different store and write a selector to get the results. However I feel that it is not the right approach, since the data is duplicated and will cause maintenance issue.
I am not sure there is any better way. Or do I miss anything in the documentation?
OS and Version?

N/A

Versions

N/A

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Thanks for the reply.
In a nutshell,

create an angular service,
inject the EntitySelectors$Factory into the the service,
create selector in the service,
inject the service to component.

I am wondering if the ngrx-data can create an entity adapter, by providing the collection name, and exposing some common selectors. As show in the following link, https://github.com/ngrx/platform/blob/master/docs/entity/adapter.md .
This way, the service can be eliminated, and the overall architecture is more inline with ngrx example app.


Why is the mIoU on the test set (67.8) higher than the mIoU on the validation set (65.9)?

The performance on the test set is usually lower than the performance on the validation set.  Why is the mIoU on the test set (67.8) higher than the mIoU on the validation set (65.9)?

The submission on leaderboard is trained with all labeled data (including Training and Validation set). Other techniques including TTA (test time augmentation) are also involved.

Thanks for your kind reply.


Muted users can leave, join again and talk

Title.
A user who has been muted through .mute can leave the server and join again and he or she will not have the nadeko-mute role, thus being free to talk. I've been told to report this here since this is apparently a bug and .mutes should persist.

I can confirm that this is an issues, seems like it is a persistence issue which might be down to the fact that the role we specify for muting is not held in a database. Or something along those lines?

Don’t think it’s a bug. @hemipatu is right, there’s no role-persistence right now. Would be a good feature indeed, both for muted roles but also any roles (for limited time) - if a user leaves by accident or whatnot, they can regain their roles.

There is role persistance when it comes to mute role. It should work. I'll test it out in the coming days. There are a lot of things on the todo list atm.

@Kwoth I actually can't replicate this in a clear server; with the default nadeko-mute role auto-created.
For everyone else -
The only steps I can think of that are causing this are:

Your Nadeko mute role has modified permissions
Awarding a role upon server join automatically perhaps that overrides
Channel-specific overrides

I've muted a user with proper permissions, had them leave, and had them join back instantly, as well as after 15 minutes or so. They are both awarded the nadeko-mute role right away as they should be. So this is likely a permission thing on the server(s) in question.

What shikhir said.


Invalid google_app_id. Firebase Analytics disabled

Please find a permanent solution for this issue:
11-18 09:37:42.886: E/FA-SVC(18532): Invalid google_app_id. Firebase Analytics disabled. See https://goo.gl/NAOOOI. provided id: @2131034133
Tried everything to solve this but no result yet.

Same here

same  here, Any solution

+1

+1


False positives in control 1.2.3 and control 1.2.4

Description
For controls 1.2.3 and 1.2.4 it always shows PASSED irrespective of the setting in Github
 1.2.3    Ensure repository deletion is limited to specific members                                       Passed
 1.2.4    Ensure issue deletion is limited to specific members                                            Passed

Additional details in case it does not expose sensitive data (scanned pipeline files, PR, etc):
Here's the snippet from mapper.go which denotes the value has been hard-coded for the setting.
Reference GitHub setting snapshot which allows users to restrict/allow repository deletion and issue deletion -

Thanks we'll take a look on that!


use different embedding model

Were the effects of using different embedding models considered or tested? I'm just curious about it.
Related: https://github.com/lm-sys/RouteLLM/issues/23 https://github.com/lm-sys/RouteLLM/issues/39

We've tested using local embedding models and we have found that they can perform comparably to OpenAI's model. We are currently implementing them and will provide more results on release!


Html beautifier

Hello,
Is there an option for the generated HTML to look prettier?
Right now, it's a big long line.
So when I'm trying to debug, it's hard to read and I'm using a HTML beautifier to understand and troubleshoot it.
However, that make is a little bit harder since it's one extra step each time.
Thanks

I apologize for the immense delay on this issue.
Currently we only support fully serialized output (i.e., minified). Without changing the API, or adding a global configuration variable, neither of which I'm too keen on. I don't see how we could achieve this.
Luckily the browser inspector does this for us! So I would recommend using either Chrome or Firefox's inspector to make debugging easier.
Cheers!


Fixed the toggle button

Related Issue
Fixes: #859
Description
Made the necessary changes to the toggle button to ensure proper alignment on small screens.
Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Large Screen:
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/115869626/27966944-7ae0-4bd6-905e-01add04838fc
Small Screen:
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/115869626/9ce8440a-8aba-4151-b8ea-74f4a2c48673
Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Add a video to demonstrate your changes. Both for large as well as small screens.

Large Screen:
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/115869626/f4d4eb2d-363e-47b4-92d5-dc2d77ceece0
Small Screen:
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/115869626/0d277642-3a4d-4150-a347-ae4111607bd9

@Suchitra-Sahoo Please assign it to me and add label and level
Thank you

When i am clicking on toggle option it is not changing to dark mode. The mode option is almost at the edge of navbar which is not looking good. In small screen the mode option is overlapping close option of menu. I think you have not pulled changes from origin as now the navbar issue is resolved and login option is within navbar. To get better idea about toggle otpion just reer gssoc official website.

What is your issue number?

849 is PR number

#823

@Suchitra-Sahoo After making those changes do I have to open a new PR or update in this one only

823 isuue is already assigned to you.

Keep the toggle mode on navbar only but not totally at the edge it should have proper space.

Make a new PR


fix enableProdMode, restructure folders and files, remove console appstate, rename image filename

@ivanmaulana : could you please give us a brief summary of your "restructure folders and files"  in this PR? thanks
@hzb-imasine


Pool draining before all records are inserted

I have a loop that inserts about 40,000 records. After the loop is finished, I call
r.getPoolMaster().drain();

However, the driver hasn't processed all the inserts when drain is called. This results in rejection of all the insert promises.
Is there a way to have drain() wait until all of the inserts are complete?

Wait for the inserts to finish before calling drain the same way you would
do with any asynchronous operations in JavaScript.
On Tue, Apr 26, 2016, 16:49 Kevin Coleman<EMAIL_ADDRESS>wrote:

I have a loop that inserts about 40,000 records. After the loop is
finished, I call
r.getPoolMaster().drain();
However, the driver hasn't processed all the inserts when drain is called.
This results in rejection of all the insert promises.
Is there a way to have drain() wait until all of the inserts are complete?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/neumino/rethinkdbdash/issues/246


No url provided

Greetings. Thanks for the awesome editor!
But i have one issue. I do not have an image uploader backend so i wanted to disable this option. But when i do so i receive an error "no url provided" and the editor does not work properly. Preview is not updated for example.
I used the provided settings example:
var md = new MdEditor('#mdeditor', { uploader: false, preview: true });

When i do use a url or random string as the uploader value the editor does work as intended. Only the image upload option fails.
Am i missing something? My hope was that the image button would work like the url button and just provides the correct  brackets in the editor.

Then is the sample options provided on the readme not wrong? is shows:
var md = new MdEditor('#mdeditor', { uploader: false, preview: true });
So I assume the false option would be an option.
Will see if i can do the changes. For now i use it with a dummy url.


Editor for "Rich Text" should be configurable for Markdown ⁄ plain text. A setting on the FieldSchema

@milesleif I've upgraded to WebPack 4 now, so it should work with the latest code from master.
The file in question is this one, and the method is "renderConfigEditor". I've created an example in there for disabling the markdown editor, but it's not implemented in the frontend.
Look around in this file for occurrences of "html", "wysisyg" and "markdown" to find where you need to use the config.isMarkdownDisabled to prevent the use. Please let me know if you I can do more to help you.

Related to #251 and postponed for v1.2

Fix pushed to v1.2 branch


draw a dot for singleton points on line plots

Reported by ansley b manke on 19 Mar 2015 00:07 UTC
Ferret fails to show a point if it is part of a line plot and is sandwiched between two missing values -- call this a "singleton".  A better behavior in that case would be to make a small dot marker at the location of the valid point.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2247

Comment by ansley.b.manke on 14 Apr 2016 17:07 UTC
This was fixed in plotxy.F and plotxy_ribbon.F and is in Ferret v6.94.


Member creation function.

Create a Firebase function that "applies" new REQUEST_INVITE operations to the members view. The member creation function is triggered by the creation of a new Operation object in the database.

This PR is pretty noisy in terms of commits - perhaps we should do a squash+rebase instead of pure rebase when merging to master.


Fix unapplied transforms with no delay and duration = 0

Before this, inmediate transformations with delay (e.g. drawable.Delay(duration); drawable.FadeOut();) wouldn't be applied.

good catch


Added MailChimp automation models.

Thanks @wadlez! :star:

Woot. Just in time for it not to matter in a few months.

@robmburke :wink:
Yes -- if you'd like a 3.0 API wrapper, check out this one: https://github.com/brandonseydel/MailChimp.Net


DE34274: Hide the advanced search link with a dom-if since hidden wil…

…l be overridden by class styles.

Well that's a relevant test failure. Hmm.


[v8.1.0 Upgrade to v8.2.1] - Upgrade fails

I am facing this error when running the upgrade:

I have the above class in a package. The class inherits from Concrete\Core\Entity\Attribute\Value\Value\AbstractValue;

concrete.version
8.2.1

concrete.version_installed
8.1.0

concrete.version_db
20170802000000

Steps to Reproduce:

Downloaded the latest version of Concrete5 from the website
Extracted files and remove everything besides the "concrete" folder
Copied the folder into the "updates" folder
In the Dashboard the update is recognized.
I click "Upgrade"
The error is appears

Here is what my package controller looks like:

Hmm, I wonder if an update we made to reduce packages breaking upgrading has resulted in the opposite. This issue:
https://github.com/concrete5/concrete5/pull/5640
moved automatic updating to before the loading of packages – with the idea that packages might break the upgrade process. But many core components of concrete5 referenced in the upgrade might need the on_start() of a package to be loaded first.
If you load this file: concrete/src/Foundation/Runtime/Run/DefaultRunner.php and move                 'handleUpdates' on line 81 onto line 94 (after 'initializeLegacyUrlDefinitions') does this fix the issue?

Thanks for the prompt response. I took a look at the DefaultRunner.php and I do not see "handleUpdates" at line 81. Please see below what I find:

I find "registerLegacyConfigValues" at line 81. Also I find "initializeLegacyURLDefinitions" at line 56. The method above that is "setupPackages"
Am I missing something obvious?

@nlalla5 It seems that you are looking at the wrong place: here's the DefaultRunner.php file for version 8.2.1. Maybe you are looking at the files under /concrete, but you should look at the 8.2.1 version you have copied in the updates folder.
PS: since version 8, the upgrade can be done by replacing the /concrete directory with the new one. Here's the upgrade process you could try:

delete the /concrete directory
replace it with the concrete directory of version 8.2.1

Of course, a backup of everything (files and database) is highly recommended.

I just tried doing a manual upgrade from 8.1 to 8.2.1 by replacing the core concrete folder with the 8.2.1 version. Then, when I go anywhere on the site, it only shows this:
Third party libraries not installed. Make sure that composer has required libraries in the concrete/ directory.

@pinecreativelabs do you have the /concrete/vendor directory?

No, it isn't there. I downloaded the packaged zip from Concrete5.org, and found it to also be missing the /upgrades and /packages folders.

Disregard that last message. Turns out my extracted package got corrupted (didn't finish extraction). Did a fresh download and extraction and everything's there.

@mlocati Thank you so much for pointing out my silliness.
I re-ordered the steps as recommended by @aembler and it worked like a charm! I haven't yet had a look around to see if everything is working as it should but the upgrade process worked perfectly and the site seems (at first glace) to be working as expected.
What are the next steps to fix the issue?
PS: Apologies for the delay in responding to this ticket, got tied up at work.

This issue:
#5640
moved automatic updating to before the loading of packages – with the idea that packages might break the upgrade process. But many core components of concrete5 referenced in the upgrade might need the on_start() of a package to be loaded first.

We currently upgrade the core (if necessary), and after, for each package, we call the on_start method and PackageService::bootPackageEntityManager.
What about calling bootPackageEntityManager for every package, then upgrading the core, then calling  on_start?

Would that really help? In my experience I wasn't able to get attributes to upgrade properly because they are registered in on_start(). A custom attribute category, that is.

Aren't attributes now handled by the entity manager? If so, bootPackageEntityManager would let the system find them. Am I missing something?

@aembler and @mlocati - What is the resolution for this? I am still facing this issue with the original code. What should I do?


tunnel -- panic: non-positive interval for NewTicker

go install github.com/coder/wgtunnel/cmd/tunnel

~/go/bin/tunnel -api-url https://try.ii.nz --wireguard-key `wg genkey` localhost:8030
panic: non-positive interval for NewTicker

goroutine 36 [running]:
time.NewTicker(0x140000684b8?)
	/opt/homebrew/Cellar/go/1.20.2/libexec/src/time/tick.go:24 +0x110
github.com/coder/wgtunnel/tunnelsdk.(*Client).LaunchTunnel.func2()
	/Users/hh/src/wgtunnel/tunnelsdk/tunnel.go:232 +0x58
created by github.com/coder/wgtunnel/tunnelsdk.(*Client).LaunchTunnel
	/Users/hh/src/wgtunnel/tunnelsdk/tunnel.go:231 +0x738

This was caused by a new version of the client connecting to an old version of the server.
Once they were both running the same version, the error went away.
I suspect the API changed.


vscode: use absolute predetermined path instead of heuristic

Fixes #59725

Motivation for this change
#59725
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Does this need a backport?

Most changes to vscode should be backported


Various cleanup items for the Conway spec

This issue is for things that are necessary specifically for the Conway spec and don't fit elsewhere.

[ ] ~Fig. 8~ Fig. 13 (Protocol parameter declarations)
Can we move Acnt elsewhere?
[x] ~Fig. 14~ Fig. 12 has a lot of rules that don't have any
preconditions. Explain that not all rules have a horizontal line
and preconditions (or just make one so it looks consistent).
[ ] ~Fig. 15~ Fig. 13 - format
[x] ~Fig. 17~ Fig. 15 - rules would be easier to read if all the let
statements are above the line
[ ] Figure 40 (NEWEPOCH transition system)
The module shenanigans and record updates make this one
especially hard to read

Please correct me if I'm wrong, but I believe Fig 14 is now Fig 12 ("ENACT transition system")  (There are no horizontal lines or rules in Fig 14.)

I think other Fig numbers might be wrong, too.

@WhatisRT do you have any ideas re. where we might move Acnt?

We need to clarify the item "Fig 13 format."

Ideally, I'd move Acnt to some place where we actually use it. I wouldn't mind it being next to the definition of NewEpochState.

@WhatisRT Acnt was moved into the hidden code block just above where it previously stood.  This was done in the (merged) PR #292, where I added the following explanation to the text of the PDF (so that hiding the definition doesn't confuse the reader):
"The \AgdaRecord{Acnt} record has two fields, \AgdaField{treasury} and \AgdaField{reserves}, so the \AgdaBound{acnt} field in \AgdaRecord{NewEpochState} keeps track of the total assets that remain in treasury and reserves."

I worked on refactoring the NEWEPOCH proof in an effort to make it more readable.  In particular, I tried removing the huge let binding, introducing all the assignments as proper definitions.  Unfortunately, this broke many things that I wasn't able to fix... yet.  I'll try again with a slightly less dramatic refactoring.


Old tags removed

Were the old tags (like 0.3.3) completely removed?

Yes. All old versions have been yanked from Rubygems as they were in breach of the license for the underlying data.


sidekiq-cron schedule multiple jobs

The sidekiq-cron still can schedule multiple the same jobs if the previous jobs is not completed yet. This problem similar to #81.
Here is the project for reproduce the problem. Just run bundle install, foreman s and wait 3 minutes. It will write the following logs:
11:51:21 worker.1 | 2017-04-25T08:51:21.430Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: start
11:51:21 worker.1 | 2017-04-25T08:51:21.430Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #0
11:51:36 worker.1 | 2017-04-25T08:51:36.435Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #1
11:51:51 worker.1 | 2017-04-25T08:51:51.438Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #2
11:52:04 worker.1 | 2017-04-25T08:52:04.588Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: start
11:52:04 worker.1 | 2017-04-25T08:52:04.588Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: Tick #0
11:52:06 worker.1 | 2017-04-25T08:52:06.443Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #3
11:52:19 worker.1 | 2017-04-25T08:52:19.589Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: Tick #1
11:52:21 worker.1 | 2017-04-25T08:52:21.446Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #4
11:52:34 worker.1 | 2017-04-25T08:52:34.592Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: Tick #2
11:52:36 worker.1 | 2017-04-25T08:52:36.451Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #5
11:52:49 worker.1 | 2017-04-25T08:52:49.597Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: Tick #3
11:52:51 worker.1 | 2017-04-25T08:52:51.456Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #6
11:53:04 worker.1 | 2017-04-25T08:53:04.599Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: Tick #4
11:53:06 worker.1 | 2017-04-25T08:53:06.459Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #7
11:53:13 worker.1 | 2017-04-25T08:53:13.436Z 74741 TID-oxw4ufya8 LongWorker JID-d9ca8d1c00f7af922d59ecd5 INFO: start
11:53:13 worker.1 | 2017-04-25T08:53:13.436Z 74741 TID-oxw4ufya8 LongWorker JID-d9ca8d1c00f7af922d59ecd5 INFO: Tick #0
11:53:19 worker.1 | 2017-04-25T08:53:19.602Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: Tick #5
11:53:21 worker.1 | 2017-04-25T08:53:21.461Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #8
11:53:28 worker.1 | 2017-04-25T08:53:28.441Z 74741 TID-oxw4ufya8 LongWorker JID-d9ca8d1c00f7af922d59ecd5 INFO: Tick #1
11:53:34 worker.1 | 2017-04-25T08:53:34.608Z 74741 TID-oxw4ufozs LongWorker JID-0bbbf6d1a29d051e1c7a6d5d INFO: Tick #6
11:53:36 worker.1 | 2017-04-25T08:53:36.464Z 74741 TID-oxw52byy0 LongWorker JID-80e131926847758333a7fa5e INFO: Tick #9

As you can see the LongWorker is running several times (JID identifiers are different) but the first  job is not completed yet. The same picture in Sidekiq Web available over http://localhost:3000/ (look at Busy section).
As I understand the sidekiq-cron must not run the second job if the first is not completed yet.

Moreover the trick with setting seconds to 0 described in #81 doesn't work because it 0 by default:
2.2.0 :001 > Rufus::Scheduler::CronLine.new('*/1 * * * *').seconds
 => [0]

Hi @maxd,
sidekiq cron doesn't takle care about jobs and if they run or not. It just add job to queue every time it should be added.
You need to add for example https://github.com/mhenrixon/sidekiq-unique-jobs with option sidekiq_options unique: :until_and_while_executing
then your job will not be added to queue until execution of job is done.

Thank you a lot for quick response. I have checked sidekiq-unique-jobs gem. It works fine and solve this problem.

@maxd great to hear that.


[7569] Update smoke tests in preparation for DSI change for Sept 17

Context
Sept 17
https://ukgovernmentdfe.slack.com/archives/C5S500XB6/p1725540010269859
Changes proposed in this pull request
Update smoke tests in preparation for DSI change for Sept 17
Guidance to review
For Sept 17
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Update OpenAPI spec to remove unnecessary payload fields

 Update smoke tests in preparation for DSI change


Cant donwload the mail or mac

Problem encountered on https://dotnet.microsoft.com/learn/ml-dotnet/get-started-tutorial/install
Operating System: macos
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Can you provide more information about what steps you've taken and what issue you are hitting?

Resolving due to lack of activity. If you still hit this issue .. please re-open!
Thanks for reporting!


Implement AnnotatedIonSerializers

Implement AnnotatedIonSerializers
This change allows the user to configure a IDictionary<string, IIonSerializer> where the string is an Ion Type annotation.
On Serialization, if the type of c# object being serialized has an IonAnnotateType attribute, it will apply the current AnnotationConvention rule to it, which gives a string. If this string matches the key in the dictionary, it will use the mapped IIonSerializer value to serialize the object.
On Deserialization, it will get the current TypeAnnotations from the Ion object as a string, and similarly use it to find the serializer to use for deserialization in the library.

Currently on pause until final review of required API for 1.0 is confirmed.

Codecov Report

Merging #31 (234d97c) into main (078e592) will decrease coverage by 0.59%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   94.84%   94.25%   -0.60%
==========================================
  Files          38       38
  Lines         932      975      +43
  Branches      133      143      +10
==========================================
+ Hits          884      919      +35
- Misses         30       35       +5
- Partials       18       21       +3

Flag
Coverage Δ

unittests
94.25% <80.00%> (-0.60%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

....IonObjectMapper/Serializer/IonObjectSerializer.cs
96.05% <62.50%> (-0.91%)
:arrow_down:

Amazon.IonObjectMapper/IonSerializer.cs
91.51% <83.33%> (-0.90%)
:arrow_down:

Amazon.IonObjectMapper/IonSerializationOptions.cs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078e592...234d97c. Read the comment docs.


Unstaged changes lost when pre-commit plugin modified

During a commit I received the message "The following pre-commit plugins have been added, changed, or..." since a plugin had been modified. At that point (before running overcommit --sign pre-commit), I checked git status and noticed unstaged items were lost.

Hey @seanpclark,
Are you sure they aren't in your stash? While this is a bug (we should properly restore the stash if the plugin signature validation fails), I believe we always stash changes so that they are never lost.
git stash list

@sds You're totally correct... it was stashed and I didn't think to check. Restoring stash would resolve the issue.


Update all internal links references

Issue
Links that refer to internal pages in toolkit.
Now that most pages are in the toolkit.
Acceptance Criteria

Go through all pages in the toolkit and fix references to internal links to proper page path
Remove any references to "internal link" if page path doesn't exist yet

Done (except governance pages and bc-vcpedia)


Enhance UX - show scan type inside report table

Situation
When a user has multiple scan types in one report it is not clear at a first sight what is code scan finding and what is from secret scan.
Wanted
It shall be clear which scan type /module was used.
Solution
Add an additional column inside report table.

Remark: Initial changes on table model were done with b435776


fastai backward compatibility issue

The image hamelsmu/ml-gpu is installing the latest version of fastai making some parts of the code to crash. Solved by uninstalling and: pip install fastai==0.7.0; pip install torchtext==0.2.3 but you could use the requirements.txt specification you also provided on the repo.

maybe don't try to build yourself but instead pull from dockerhub?


[Bug] followUser not working anymore

func followUser(userId: Int, completion: @escaping (Result<FollowResponseModel>) -> ())
stopped working. There is no error. It just doesn't make us follow the user.

Any more info?
Cause I can't replicate the issue. It works fine for me.

seems working for me

attach the info,
it works fine for me.

Any updates? @wojczitsu

Sorry, my bad. I was trying to follow private account.


Handle Wasm errors by failing closed or open.

Signed-off-by: John Plevyak<EMAIL_ADDRESS>

cc @mandarjog


(#862) Update Column Highlight

Description Of Changes
This updates the highlight in the left-hand column to reflect information about the Chocolatey Central Management 0.12.0.
Motivation and Context
This should reflect the new release and highlight it.
Testing

[x] I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

[ ] Minor documentation fix (typos etc.).
[x] Major documentation change (refactoring, reformatting or adding documentation to existing page).
[ ] New documentation page added.
[ ] The change I have made should have a video added, and I have raised an issue for this.

Issue #

Change Checklist

[ ] Requires a change to menu structure (top or left-hand side)/
[ ] Menu structure has been updated

Related Issue
#862

Thanks for getting this added @st3phhays 👍


picon location

cannot manually change location for transfer picons
writing manually - and demon will adding endline these "\" see picture
so cannot trasfering new picons
could you add to locatian for picon please
/usr/share/enigma2/picon
/hdd/picon
/usb/picon

Hi,

/usr/share/enigma2/picon

This path is present by default.

Perhaps you removed it. After resetting the settings should appear again.

/hdd/picon
/usb/picon

Added to defaults. It should also appear after settings reset.

demon will adding endline these "\"

I think it's related to Windows build only. Corrected.

ok
maybe have option "blank" do not import picon at all?
yes /no ?

option "blank" do not import picon at all?

Hmm, I don't quite understand what you mean.

you can choose where should be transfer picon to receiver
but of user dont wanna have picons becouse old receiver are slow?
he can see picons in demon but make "block-do not transfering" any to reciver/hdd/usb ...

he can see picons in demon but make "block-do not transfering" any to reciver/hdd/usb ...

And what forces you to load picons into the receiver now?  Just don't download.  To display in the program, you do not need to have piсons in the receiver at all. I have several thousand picons on my computer (to display im DemonEditor), and in the receiver only those that are in my favorite lists (about 70). You can download the desired picons from the Web or add from a local folder:

You can download only the necessary piсons by simply selecting the ones you need from the list and clicking the "Download" button.


Iai PR benchmarks don't show the difference with main

Iai benchmarks should show improvements/regressions between main and the to-merge branch.
Also consider changing to iai-callgrind, should be pretty straightforward. @Oppen do you know how does calliper compare with iai-callgrind?

The workflow as is doesn't publish the results (you can look for inspiration to make it post a comment here) if that's what the issue is about. You can already look for those in the workflow logs. Not too user friendly, but at the time I did it we had a serious issue with pipeline run times using criterion and I prioritized having something useful quickly rather than feed my perfectionism.
I haven't tried either iai-callgrind (I knew there was an issue requesting migration to callgrind upstream, but I find it odd and slightly sad that someone went through the forking path rather than sending PRs, and I never found out) nor calliper (I remember the name tho, so I may have studied it, I don't know).
I'll try those in cairo-rs soon enough and come back with opinions.

If you want to explore more options, there's an extension for criterion that uses perf on Linux. That can be used to more or less emulate the logic IAI uses as it queries cache hits and misses much like Valgrind does, but from hardware counters in non-emulated runs (it's faster, but more dependant on the actual machine, while still being less subject to random noise than wall time).

During a little query (which I'll do more in depth in the weekend, right now I need to focus on automating the release process for cairo) I found this little gem that you may find interesting: https://crates.io/crates/criterion-cuda

Yep I knew about criterion-cuda, it seems really nice. Thank you so much for all the info! I asked you about calliper because I saw that you contributed to it some time ago. I think iai-callgrind was made from a fork because there's a one year old PR for using callgrind in iai and never got any feedback, also the last commit was three years ago, the author (the same one as criterion) doesn't have any public activity since 2022, they made iai as an experiment and maybe have no intention of continuing its development

I contributed to calliper? Wow, I didn't remember that.

they made iai as an experiment and maybe have no intention of continuing its development

I was aware of this part. He planned on integrating the functionality to criterion back then.

The workflow as is doesn't publish the results (...) if that's what the issue is about. You can already look for those in the workflow logs.

Note: what shows in those are the PR's results, not main's


Pass pointer to LsaFreeMemory, not FFI::MemoryPointer

LsaFreeMemory takes a pointer to the struct in memory created by LsaEnumerateAccountRights.
We have to pass it the actual pointer, not the FFI::MemoryPointer object.
This fixes masked access violations which occasionally lead to a heap corruption which
presents itself as silent termination of chef-client/ruby with a return code of -1073740940
or STATUS_HEAP_CORRUPTION / 0xc0000374.
Fixes #6589

@btm please cut a PR to backport this to Chef 13 so we can get this out in next months Chef 13 release


Fix platform_version Chef::VersionString API

The consumption of ohai attributes by the ohai segment plugin code
was breaking this feature.

I don't think I have time to screw around with this one or noodle about the right way to test this, time is getting a bit too short.


Add chunked transfer-encoding support

Adds support for conveniently sending requests with node-form-data using chunked transfer encoding.
This can be used in cases where the server supports chunked encoding and the content length of readable streams cannot be determined without buffering and will assist some users in working around issues like #90 until a permanent solution is found.
Usage
Two possible invocation methods can be used.
Custom Submit Option
form.submit({host: 'localhost', port: 80, path: '/', chunked: true}

Custom Header
customHeaders = {
  'transfer-encoding': 'chunked'
}
form.submit({host: 'localhost', port: 80, path: '/', headers: customHeaders}

Notes

Tests include a stream with an indiscernible length (HTTP response with chunked encoding itself).
Supports multiple, chained transfer codings as per RFC7230
chunked submit option will NOT overwrite other custom set transfer-encoding headers.

very hopeful this gets merged

Is there something that needs to get done to get this feature into a 1.x release? It would greatly benefit a few projects I work on which utilise this library.

We definitely need it in 1.0, just hiccups with house cleaning, removed stale 1.0 branch and doing stuff in master with release candidates. Currently I'm trying to integrate multistream as replacement for combined-stream and it involves some code modification, so when that thing is landed, we'll be adding all the new features. And chunked transfer encoding is the first among them. Thank you.


node-zsock#3 Use node-gyp instead of node-waf

Fixes #3, obsoletes #6.
I believe this will allow sdc-amon to build on node 0.10. WIth these changes, node-gyp is able to compile zsock.cc against node 0.10.48.

Pointing sdc-amon/relay/package.json directly at this commit lets sdc-amon build. So that's at least working.


default values in Create

Hi, and thanks for your PR.
It has a few problems:

you add default values for <Create> but not for <Edit>
you pass a initialValues props that's not used
there is no documentation, no tests

Even beyond that, I'm concerned that the API you chose isn't ideal. You define default values as an argument to the <Create> component:
<Create data={{ total: 0, date: new Date() }}>
   <TextInput source="data" />
  <DateInput source="date" />
</Create>

I think it'd be more reusable to attach default values to fields, as follows:
<Create>
   <TextInput source="data" defaultValue={0} />
  <DateInput source="date" defaultValue={new Date() />
</Create>

What do you think?

Hi, thanks for you reply.
Actually I need this changes to impliment function for copy record. Instead of pass defaultValue to every field of my big form and my custom fields I want to be able to pass source record to form, like we did in Edit.

Superseded by #210


fix: xa commit/rollback should executed by master conn in read write …

…splitting mode
ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #280 (0304ad2) into dev (1d12859) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #280      +/-   ##
==========================================
- Coverage   42.54%   42.52%   -0.02%
==========================================
  Files          91       91
  Lines       10470    10473       +3
==========================================
  Hits         4454     4454
- Misses       5527     5530       +3
  Partials      489      489

Impacted Files
Coverage Δ

pkg/executor/read_write_splitting.go
42.00% <0.00%> (-0.59%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Great code, what is incomplete?

Hi there,
Thanks so much for sharing this code. I appreciate that it is quite old and you're very clear that it shouldn't be used. But it looks like you put a lot of work into this and some aspects definitely work (eg FindHost).
Is there a reason that you stopped work on it? Is there something fundamentally wrong with it that caused you to stop work on it?
Thanks again.

Is there a reason that you stopped work on it?

I lost faith in the ISC DHCP server and its OMAPI interface, because it was trivial to crash the server using malformed OMAPI requests.
As for this package itself and why I wouldn't recommend using it (as is):

I wrote it 10 years ago, when I was new to Go. The code quality is unlikely to be good.
It never made it past the prototype state, which means there are probably bugs and unhandled errors.
I don't intend to work on it anymore, so if you were serious about using it, and ended up finding bugs or missing features, you'd probably have to maintain your own fork.

Other than that you're of course free to use it/base your work on it. The "don't use it" remark in the readme is a placeholder common to most of my projects that I remove once I'm happy with the code; this package isn't particularly worse than other unfinished code of that era.

Thanks so much for the reply!
For one reason or another there seems to be very few people using OMAPI, and most of the code/utilities available are around the same age as this code. Maybe most others have discovered the same frustrations as you have, but in any case I appreciate the ideas in your code.


upload it to F-droid

hi because of nature of your app as an open source project i encourage you to make it available on the F-droid app store were only open source apps that respect the privacy of the users are
there is a lack of arabic/ islamic apps there
may Allah protect you
the official link : https://f-droid.org/en/
the submission process : https://gitlab.com/fdroid/rfp/

Thanks for the suggestion. I'll take a look when I have free time.


chore: identity checks for all

Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes https://github.com/tailcallhq/tailcall/issues/1414
/claim #1414
Build & Testing:

[x] I ran cargo test successfully.
[ ] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[ ] I have added relevant unit & integration tests.
[x] I have updated the documentation accordingly.
[x] I have performed a self-review of my code.
[ ] PR follows the naming convention of <type>(<optional scope>): <title>

Summary by CodeRabbit

New Features

Enhanced schema definitions with specific directives for optimized data retrieval and improved schema clarity.
Introduced new fields and modified existing ones in types like Query, User, and Post for better data fetching and relationship definition.
Optimized data fetching mechanisms and API behavior with the addition of @upstream, @http, and other directives.

Bug Fixes

Corrected argument order in @http directive across types to address endpoint construction logic issues.
Streamlined schema declarations by eliminating redundancy and unnecessary nesting.

Refactor

Reorganized schema declarations by adjusting field and type order to enhance overall clarity and structure.
Improved directive parameter adjustments and property reordering within schema definitions for enhanced configuration and readability.

Documentation

Enhanced block syntax in tests/README.md to ensure clearer definition and consistency in test runner documentation.

Chores

Conducted general cleanup in test files by removing extraneous content and consolidating schema annotations.

@tusharmath PR is ready for review.
PS: I've also updated the documentation for #1213

@35C4n0r Converting the PR to draft. Feel free to change it once the PR is ready with the fixes.

Is there work happening on this front? If not do you mind closing this PR?


Should not consider case while matching text by default

Proposed behavior
Text match should be case-insensitive matching.
Actual behavior
When css is used to make something to uppercase or lower case, what is rendered on the UI is different from what is in the DOM. Today, Taiko considers the case of the word while matching.
Steps to replicate

Run the script

const { openBrowser, goto, text, click, below } = require('taiko');

(async () => {
    try {
        await openBrowser();
        await goto("https://react-shopping-cart-67954.firebaseapp.com/");
        await click(text("M"));
        await click("Add to cart",below("Dark Thug Blue-Navy T-Shirt"));
        console.log(await text("CHECKOUT").exists())
    } catch (e) {
        console.error(e);
    } finally {
        closeBrowser();
    }
})();

The text is rendered as CHECKOUT in the browser but it is Checkout in the DOM. Hence taiko is returning that the element does not exist

Version
commit - f2a3d59d69cc4361fc67f3914d2049f7d20c4965

Tue Aug 7 09:59:55 2018 +0530

Fix should be available in commit f026e93.


Issue.swift41

Update to Swift 4.1, in reference to this issue: https://github.ibm.com/arf/planning-swift-solutions/issues/571

Needs rebasing.

Codecov Report

Merging #14 into master will increase coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
+ Coverage   63.63%   65.63%   +2%
=======================================
  Files           5        6    +1
  Lines         451      486   +35
=======================================
+ Hits          287      319   +32
- Misses        164      167    +3

Flag
Coverage Δ

#KituraContracts
65.63% <100%> (+2%)
:arrow_up:

Impacted Files
Coverage Δ

Sources/KituraContracts/CodableQuery/Coder.swift
100% <100%> (ø)
:arrow_up:

...es/KituraContracts/CodableQuery/QueryDecoder.swift
66.66% <100%> (ø)
:arrow_up:

Sources/KituraContracts/BodyFormat.swift
66.66% <0%> (ø)

Sources/KituraContracts/Contracts.swift
42.73% <0%> (+14.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0042c1d...22a3896. Read the comment docs.

@ianpartridge looks like @ShihabMehboob has addressed your review comments.

@ShihabMehboob FYI, I updated the opening comment of this PR to be more descriptive.


feat: add agent status bar.

and fix #890

i think this UX is better for whole chat window show init, and we can extend the agent status, like:

Agent is typing
Agent is initializing
Agent is thinking
Agent is ready
Agent is not available

https://github.com/OpenDevin/OpenDevin/assets/16201837/b14eb1c6-bce1-4ad4-b422-edd3ce724fc4

LGTM! Just I think if the status bar is shown, the input should be just in read-mode what do you think? it was like that before.

you mean the user can't input when init?

maybe we can merge this and open a new PR

WDYT?

yes exactly
it seems good for the user can input when init. you can see this #859

the user can input but can't submit the message when the agent is initing.

AHHHHH got it 👌

@iFurySt do you think we are ready to merge it?


Initial support for decorators.

This is based on a hacked up version of TypeScript including @mhegazy's minimal decorators pull request. I.e. this is to allow further progress on ts2dart transpilation, not a final solution.
So this relates to #72, but doesn't fix it.

LGTM


Implement Positional Information Parser

The Positional Information field is currently just passed through.
It would be better to parse out its individual components.
We could also parse out the specific type of positional information that corresponds to.  These are denoted as either 9a, 9b, 9c, 9d in the source file.

Closed


Issues w/nightly package versioning scheme

The nightly packages seem to be building with a four-part version identifier and no pre-release suffix.
First, NuGet packages need to follow semver versioning rules or else wacky things will start to happen with NuGet clients. In short: the versions need to be match the format of: <major>.<minor>.<patch>[-<prerelease>+<build-metadata>]
Most of the time people leverage GitVersion to handle their automated package versioning. Not only will this help calculate the version number for your actual source level build to use, but it will also help generate a good package version identifier by taking on a pre-release identifier that includes the branch name and commit SHA so you can look at a package and immediately know what commit in the code this package was stamped from.
Additionally, the fact that there is no pre-release identifier on the feed right now means that if, as a developer, I add that feed to my list of feeds because I want to play with the latest bits in a test project, but I still need to develop a production release bot day-to-day, there's a possibility that when I do NuGet update that it will take the more recent version from the MyGet feed even though it's pre-release.
Here's a nice series of blog posts on the subject of utilizing GitVersion to deliver NuGet packages via a CD pipeline.

Thanks for the link to the blog posts. Reading today.

@drub0y You're right. Again.

we will snap to semver starting with RC build candidates for v4


Update poetry

Update rosa-python-client to v1.0.28 triggered some more updates. lgtm?

/retest build-container

Our bot should handle it, please close this PR.


BUG: Footer is fixed in every page

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?
when we  move to other pages like event, menu,reservation, etc when we scroll down footer is relatively positioned

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a gssoc-24-ext contributor
[X] I have starred the repository
[X] I want to work on this issue
[ ] I check the issue doesn't exist

@HAIDER072 its there check once


Support user entries on different lines

I do not keep usernames on the second line of my pass entries, but I do prefix them with login: (for passff compatibility). I'd like it if passdmenu could find them.
The way I see that working is altering the get_user_pw() function to loop through pass_ouput[1:] (ignoring the first line, since it is pass convention that the first line is always the password) looking for a line that begins with any of passff's default login field names (login,user,username,id). The first line that matches is treated as the username line. If no line matches, it falls back to using the second line. That would solve my problem and not break the current behaviour.
I'd be happy with just using passff's default login field names, but it may be worth allowing the user to specify the field name as well. So if I knew that most of the time I prefix usernames with login, but sometimes I use email, I could do something like passdmenu.py -U --login_field "login,email" and the script would look for lines beginning with both. I'm not sure how useful that ability would be.

That sounds good to me.
I don't currently have a use case and time to work on it may or may not happen, but would happily accept PRs.
For the second proposal, I would think of expanding/abstracting that a bit and allow passdmenu to extract multiple specified fields and/or a priority mechanism. Just for the user name field, when we already allow multiple options, it may not be that useful.
I actually had a use for getting completely different fields and not the password - can't remember what it was now.

Solved for login/user fields.


EDU-682 Work with document in rooms

Closes https://educandu.atlassian.net/browse/EDU-682

Looks, good, I wasn't able to provoke any visible problems 👍

Means they might be well hidden 🙈


Upgrade Gradle to 7+ to support JDK 17 test runs

After https://github.com/wiremock/wiremock/pull/1632 it might be good to also start running the tests on JDK 17.
For this to work we have to upgrade Gradle to the latest version, 7.2 or even 7.3 when released.
As we're coming from Gradle 6.6.1, there's quite a few upgrade steps involved.
Most notably the removal of the compile and runtime configurations,
as well as removal of the legacy maven plugin.
@nstdio already opened a pull request to remove baseName for archive tasks: https://github.com/wiremock/wiremock/pull/1621

Closed by 72cfe156a96665535dd1c3555e3990e7413a1595


Is there any better way to generate a RSA key?

I need to generate a PKCS1 format PEM key, aka BEGIN RSA PUBLIC KEY.
The following method looks so dumb to me, can I do that with openssl instead?
ssh-keygen -t rsa -b 2048 -f id_rsa
ssh-keygen -f id_rsa.pub -e -m pem > pub.txt
ssh-keygen -p -N "" -m pem -f id_rsa
mv id_rsa priv.txt

openssl genpkey -algorithm RSA -pkeyopt rsa_keygen_bits:2048 | openssl pkey -traditional -out priv.pem

Should work.

@t8m Which version works for you?
%> openssl pkey -traditional -out priv.pem
Unknown cipher traditional
Usage pkey [options]
where options are
-in file        input file
-inform X       input format (DER or PEM)
-passin arg     input file pass phrase source
-outform X      output format (DER or PEM)
-out file       output file
-passout arg    output file pass phrase source

Any currently supported version (i.e., 1.1.1 or 3.0) should work.

@t8m It only generates the private key, how can I get the public key?

openssl pkey -in priv.pem -pubout
Of course that will output the public key in the PEM format (-----BEGIN PUBLIC KEY-----). If you need the ssh public key format you need to use utilities from OpenSSH.


Reopen: Disable shallow git clone for currently used case study projects

@julianbreiteneicher is everything on the BB side merged? can we bump the required version and merge?

@vulder Almost. One PR needs to be merged, then it's ready.

ok then we'll wait a bit more :)
can you reference the PR in a comment

Sure, it's PR PolyJIT/benchbuild#221

We can merge this after se-passau/VaRA-Tool-Suite#121 has been merged.


[Filesystem Routing] Nested routes with sticky scrolling

Description
By default Vike scrolls the page to the top upon navigation.
The idea here is that the user would define /product/@id/%view (or /product/@id/@@view/) instead of /product/@id/@view to tell Vike that the page shouldn't scroll to the top.
Edit: Actually, a new setting scroll: false could be simpler.
@Blankeos In Next.js (and other frameworks) how does the user control whether the page scrolls to the top?

@brillout Usually in other metaframeworks there's two ways to navigate:

Link (In the Markup)
Programmatically using a navigate API.

By default, the other metaframeworks work exactly like in regular HTML anchor tags wherein both approaches cause a scroll up to (0,0) scroll position. You can pass an optional prop/attribute to change that.
In NextJS:

Link: <Link href="/my-page" scroll={false}>My Page</Link>
API Reference: https://nextjs.org/docs/app/api-reference/components/link

Programmatically: router.push(href:'/my-page', { scroll: false }) (useRouter hook)
API Reference: https://nextjs.org/docs/app/api-reference/functions/use-router#userouter

In SvelteKIt:

Link: Path
API Reference: https://kit.svelte.dev/docs/link-options#data-sveltekit-noscroll

Programmatically: goto("/my-page", { noScroll: false})
API Reference: https://kit.svelte.dev/docs/modules#$app-navigation-goto

Do they also scroll to the top by default for nested layouts? I'm thinking of not scrolling nested route navigation by default.

@brillout Just tested here, yup they do scroll to the top by default even for nested layouts.
Repro: https://github.com/Blankeos/nested-layouts-scroll-example
https://github.com/vikejs/vike/assets/38070918/02769da3-14af-434e-b4d3-9b893dfe9f30

Actually, I don't know whether a nested route should induce a scroll-to-the-top or not. Some nested layouts require a scroll while others don't, and I'm not sure which is more frequent. I'd suggest we stick to always scrolling by default.
I think this ticket largely does the trick, with a much better DX than Next.js and SvelteKit.
As always, feel free to disagree.

Actually, a new setting scroll: false could be a much simpler DX. I'll think more about it.

Implemented by https://github.com/vikejs/vike/pull/1853.


Feature request: ability to sell unwanted items after selection

It would be amazing if there was a sell button next to each item in the assigned loot list that you could click to sell that item/bundle. It would save me having to scroll through the inventory occasionally to get rid of all those medium lasers and small engines.
I know this is not strictly LootMagnet related, but I'm hoping that since you are poking around in related code it might be an "easy" addition. :)
Thanks,
Omen

Fixed with gnivler's quicksell additions.


Protocols Not Serialising

I have two objects, Cat & Dog both conforming to the Pet protocol. Pet inherits from mappable and Cat and Dog both implement the necessary methods to conform to it.
The array of pets is failing to show up when calling toJSON, with mapping set up as:
pets <- ["pets"]
An abstract superclass seems to work, so I'm assuming somewhere there's a check for AnyObject that's failing because it's an array protocols.

I think it is crucial to support protocols. I would like to embrace protocol-oriented programming and value types, but I need polymorphy and to serialize the values to disk. Currently, I use classes and NSCoding and a self-made copy() method... 😒

Same case here, i have an array of transactions, and they are different objects, i made a protocol for transactions, but cannot make it to work. Any help?

I have same issue with version 1.4.0, it simply skip protocol properties during mapping. I saw the issue being closed but couldn't found open ticket for this issue.

Is there any progress to this issue? I do not want to push anyone who puts his spare time into this project I just am unsure whether this bug stays open because it is low priority, hard to solve, or not an issue for most users.

If someone points me to the right place (in code) I could try to solve this issue ...

I did a bit of investigation and noticed a few things.
Given a Pet protocol conforming to Mappable and the following mapping pets <- map["pets"], ObjectMapper has no way of knowing what type of object to instantiate during mapping. Pet(map: map) is not a valid call.
If Pet was a class, then you could use objectForMapping in StaticMappable to return the correct type of subclass during mapping.
With that said, I'm not sure how we can support serializing protocols

First off: I checked the Readme.md of this project for StaticMappable. There is a link to an example which leads to a 404.

If Pet was a class, then you could use objectForMapping in StaticMappable to
return the correct type of subclass during mapping.

Why is there a limitation to classes? You can have a struct implementing a protocol and a corresponding static function (at least my playground in Swift 3, Xcode 8 eats it).
If there is a deeper underlying problem, you could offer to add mapping and init functions to some kind of (public) API method like this:
func addMapping(type: BaseMappable.Type,
    objectRetriever: (Map) -> BaseMappable?,
    mapper: (BaseMappable, Map) -> BaseMappable) {
  /* register the mapping for the given type */
}

Client code could call it like this (simplified example I know):
addMapping(type: Dog.self,
    objectRetriever: { map in Dog() },
    mapper: {
        var copy = $0
        copy.mapping(map: $1)
        return copy
    }
)

As a small follow-up: Don't you have the same "issue" with classes with inheritance hierarchy? If you have a base class Pet and a concrete sub class Dog and you have a property of type Pet which is "filled" with a Dog, serialize it, and deserialize it later on, you should deserialise a Dog not a Pet. So, if you do this already correctly, then you need type information in the JSON output.

Anything new on this? Did my information help (@id/@ref/@type)?

Why is there a limitation to classes? You can have a struct implementing a protocol and a corresponding static function (at least my playground in Swift 3, Xcode 8 eats it).

With a class, Swift has more type information with which it can work with. With a protocol, there is much less information to do so--it is unable to determine a single-type (even if generic T) at runtime.
This means that even in this context, where it calls Pet.objectForMapping(_:), the type information says that a Dog could return a Cat--even though we know, as developers, that this is not the case. As soon as we "expect" this form of polymorphism, the work we need to do to declare compile-time safety increases. To work with this, we can provide more type information and write:
public protocol GenericMappable: Mappable {

  associatedtype Mapped: Mappable = Self

  static func mapped(from map: Map) -> Mapped?

  func serialized() -> JSON // For some `ObjectMapper`-defined `JSON` type.

}

// Elsewhere, in an application-specific namespace.

internal protocol Pet: class {
  func makeSound() -> String?
}

internal class Dog: GenericMappable, Pet { ... }

internal class Cat: GenericMappable, Pet { ... }

internal class PetWrapper<T> where T: Pet {

  private(set) internal let wrapped: T

  init(wrapping pet: T) { wrapped = pet }

  func makeSound() -> String? { return wrapped.makeSound() }

}

This still means that we aren't able to drill down on the runtime type of instances of the conforming type without further introspection (because of the new associatedtype), but provided there is some functionality in Pet that we would like access to, this is still useful. Given there is some other way to retrieve the type information to use for the construction of the instance, we are able to use this.
@txaiwieser

Same case here, i have an array of transactions, and they are different objects, i made a protocol for transactions, but cannot make it to work. Any help?

This issue is related to that. i.e. That with a array of heterogenous types, the compiler does not have enough information on the underlying concrete type(s).
This issue is not apparent with classes because they share some type information--it gets complicated as soon as you inherit from some abstract superclass, however.
With the implementation above, the compromise we're likely to make is:
let collection: Array<Pet> = ... // Some pre-defined collection.

let serialized: Array<JSON> = collection.flatMap { ($0 as? GenericMappable)?.serialized() }

@tristanhimmelman , What do you think about this, having context of the implementation of ObjectMapper?

With a class, Swift has more type information with which it can work with. With a protocol, there is much less information to do so--it is unable to determine a single-type (even if generic T) at runtime.

You just need enough information to write out the concrete type during serialization and call the deserialization function for the correct type during load. So if the issue really is, to get the concrete type, adding a corresponding typeName-method to Mappable should do the trick. It willl be called polymorphically and used to write the corresponding information in a @class attribute (or something similar) in the JSON output, and use the same information to lookup the implementation (e.g. from some dictionary) in order to deserialize the correct type.

This means that even in this context, where it calls Pet.objectForMapping(_:), the type information says that a Dog could return a Cat--even though we know, as developers, that this is not the case.

If you have a property of type Pet, sure it might be a Dog or a Cat later on, this is why Pet is used. If I want to be sure, that I get a Dog, I will use a property typed with Dog. I don't get the point here.

You could even use the typename to control, which type is used later on by setting a concrete type in the registry/dictionary I mentioned.

This is how I solved my initial problem, its not ideal, but it works 100%.
transactions <- (map["transactions"], TransactionSerializationTransform())
`
class TransactionSerializationTransform: TransformType {
typealias Object = Transaction
typealias JSON = [String: AnyObject]
init() {}

public func transformFromJSON(_ value: Any?) -> Transaction? {
    guard
        let json = value as? JSON,
        let typeString = json["type"] as? String,
        let transactionType = FinalTransactionType(rawValue: typeString)
        else { return nil }

    switch transactionType {
    case .deposit:
        return Mapper<Deposit>().map(JSON: json)
    case .invoice:
        return Mapper<Invoice>().map(JSON: json)
    case .withdraw:
        return Mapper<Withdraw>().map(JSON: json)
    }
}

func transformToJSON(_ value: Object?) -> JSON? {
    assertionFailure("Not implemented")
    return nil
}

}
`

Anything new on this?

extension ImmutableMappable {

    static func transformer() -> TransformOf<Self, [String: Any]> {

        let transform = TransformOf<Self, [String: Any]>(fromJSON: { (value: [String: Any]?) -> Self? in
            guard let value = value else {
                return .none
            }
            do {
                let obj = try Mapper<Self>().map(JSON: value)
                return obj
            } catch {
                Tracker.log(error)
                return .none
            }
        }, toJSON: { (value: Self?) -> [String: Any]? in
            if let value = value {
                return value.toJSON()
            } else {
                return .none
            }
        })

        return transform
    }
}


Add the first wallpaper.

You haven't read the guidelines, you need to create a folder of your own and name it after your GitHub username, then in that folder make the SVG and PNG folders

ah sorry i forgot, lemme fix

Fixed.


Update docker-compose.yaml to fix the issue that is reported for dockerised-quickstart tutorial

The dockerised-quickstart part of the tutorial is not updating the data in Azure tables (the connector and producer is working fine).
There is a mismatch in the topic name between the producer and connector and upon making this change it started working

The dockerised-quickstart part of the tutorial is not updating the data in Azure tables (the connector and producer is working fine).
There is a mismatch in the topic name between the producer and connector and upon making this change it started working

resolves #22


Guardians Registry

There may be a Duplicate. @anvabr to analyze. We want to create a Registry of whoever is using Guardian. A topic with a marker for when a new Guardian user is created. No User Interface Tasks for this. This should only show Root Authority users, the Flag would be put on the Root Authority Role.

Next step is a conversation with the Hedera Team, Shawn to check to see if Hedera Team has time to discuss this week.

The task is on @anvabr to brainstorm and have a round of thinking on yesterdays meeting, and to come up with a proposal on how this will work. This needs to be merged into one consistent view, the stakeholders will review it, then the technical team will review it and give the HOW and the timing. Andrey is leading the coping, research, and client inputs for this ticket.

We are awaiting a discussion with our Solutions Architect Alex who is back in Monday, 1/7/2022. Andrey will work with Alex on this and it will continue next week.

Andrey is working on this this week.

Moving to the next Sprint as this was not listed as a priority by Hedera Team.

Problem description
As per #325 RootAuthority account information is stored in the IPFS and published into a Hedera topic. There should be a way to discover this information and browse in the UI.
Requirements

Create a page in the Guardian which would list the topics in Hedera blockchain with the RootAuthority (RA) DID in the topic Memo.
Create a 'detailed view' page for the RA, to which the user would navigate by clicking an RA item on the previous page.
The details page should be linked with the Analytics page from #309.

@prernaadev01 This ticket I believe was addressed by the #803 (The 'hello world' from Standard Registries).


Fix null token returned

Token is returned correctly now (it was not «propagated» to object, and not given to the storage (session by default)).
See issue #49

Thank you for this PR.
I see that you don't use the AccessToken object any more. Can you please tell me why the AccessToken object did not work for you?
Can you tell me more about your environment så I can reproduce the bug? PHP-version? OS? Browser?

When token object (LinkedIn.php:442) is returned, token string is not passed to storage (session),
I don't understand why, it should be returned by __toString (AccessToken.php:33).
If string type is defined, it works correctly (see cb963cf66000ebe2e6cf193b5d90ec8dcc43ecf9).
Environnement: Debian 7 - PHP 5.4.39-0+deb7u2 (nginx/1.2.1) - happyr/linkedin-api-client dev-master

We should always handle the access token as an AccessToken object. Could it be a problem when you are using the SessionStorage? Try to serialize the $value at SessionStorage.php:36 and unserialize at SessionStorage.php:50. Will that help?

Correct me if I'm wrong,
There's a problem to store the token as an object, when is fetch from session (or other?) at LinkedIn.php:381, then he's returned to setAccessToken function at LinkedIn.php:343 with an object (and a hierarchy, with private property) rather than text.
This creates confusion in the object and makes token inaccessible from «outside»,
It was not the case in a previous version, I didn't check which version.
I think this is the heart of the problem.

Im, sorry I do not really understand. Where and why is there confusion?
In the session storage is the AccessToken stored as string or object.
In memory (as protected property of LinkedIn)  the AccessToken is always stored as a object.

Error was mine, I need to define strict type as string to retrieve the token, it was not the case before.


Define constants, prettify conversions

I was somewhat unhappy about the conversion formulae in the spectral_* region, partly on typographic grounds, partly because it seemed a bit arbitrary to me to show conversions for micrometer and nanometer but not for Angstrom, and at the end of that road lies madness.
It turned out the conversions were mainly there to ensure that clients that covert values back to per-domain units of choice do that such that 1000 nm does not suddenly become 1020 nm.  With that reasoning, we need to provide required conversion factors.  This PR gives a few (more welcome!) and, based on that, fixes conversion typography.

Yes, OK for me - thanks


Fix docs typo

Codecov Report

Merging #119 (6648dcc) into main (0969cd4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines          816       816
=========================================
  Hits           816       816

Impacted Files
Coverage Δ

meilisearch_python_async/client.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0969cd4...6648dcc. Read the comment docs.


Create receipt database schema

As a developer, I would like to define the database schema so that I could save and query my data in future.

fix in 9bd488ae3fba1eea0283b6646dcda3dce6e741ef


Add configurable directories that are excluded from the template select

For simplicity, copy the allFiles method from Laravel's Filesystem class into our own, so as to allow calls to the underlying Symfony Finder class.

I like it, thanks! 😄


feat(auth): email confirmation

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to add additional comments to blog posts

Navigate to a blog post: https://blog.ipfs.io/2021-05-05-audius-uses-ipfs-web3-video/
Scroll down the comments section
If existing comments exist there is no link to navigate to the forum

Screenshot:

This is unfortunately a Discourse-related issue that appears intermittently, and not something that can be mitigated on this end.

Do we know the discourse url at the time of posting? If so we could link the comments heading to it as a work around.

Not at time of posting. Could do after the fact. But it does seem to appear intermittently and not permanently.


Add annotations to task listing

Maybe collapsible below task description

In the v0.0.11 release.


High CPU usage - non-minting

While there is a fix for CPU wastage during minting (see issue #3 ), we still seem to be using a lot of CPU during normal operations even without minting. Investigate and (hopefully) fix!

This seems to be an issue only with the Qt wallet.

This is probably related to work per peer. On a wallet that has listen=0 set, I see very low CPU usage (and only 9 peers).
This work is being tracked in https://github.com/MintcoinCommunity/Mintcoin-Desktop-Wallet/issues/78.


Assigning error to specific location

Would be very useful if you could assign raise an exception in a validator but set it's location to something else.
Eg. I have a whole=True validator for a list of things, but once I've inspected the list I know the error is at item 4, I want to be able to raise PydanticValueError(loc=('foobar', 4)).
If we're doing PydanticValueError (or whatever it's called), it would also be useful to be able to add more info to ctx when raising the error.
Perhaps related to #729.
Leave this until v1.1, isn't needed for v1.

I brought this up in #729, but I think it might make sense to start including the associated model name in the loc (or as a separate field in the error) by default.
If we want to change the default value of loc it should probably be in 1.0. But if this is too extreme of a change then I'd be fine with just having the ability to override as desired.

@samuelcolvin I'm not sure how familiar you are with FastAPI, but the way errors are surfaced is that each dependency collects any validation errors that occur during its preparation, and they are all surfaced together (this happens here).
I don't think it would be unreasonable to view it as the responsibility of FastAPI to make its error messages more interpretable, but I do think including more information about the validation-failing model, or at least providing a supported means by which to update the error loc would be very useful for improving error messages there.

Hey there 👋
I was rightly searching for a way to manually set the error location, and found this issue. It looks like it didn't get lot of attention from the community, so I was wondering if it's something still considered? 🙂
It looks like that currently the loc is set via ErrorWrapper:
https://github.com/samuelcolvin/pydantic/blob/e9327b85fc5f3e14ae3efdd142c68478f6899dc9/pydantic/error_wrappers.py#L28-L42
Maybe a silly idea but could we imagine that if the exc has a _loc class var set, it could take precedence? Something like this:
def loc_tuple(self) -> 'Loc':
    if hasattr(self.exc, 'loc'):
        loc = self.exc.loc
    else:
        loc = self._loc

    if isinstance(loc, tuple):
        return loc
    else:
        return (loc,)

Cheers!

Hi!
I am also interested in this feature.
fastapi does something similar under the hood, it adds body, query, etc... as the first element of the loc array.
Magic, as I understand it, happens here
The problem is that fastapi constructs errors almost from scratch, which makes it impossible to easily reuse this code for some simple task in which you need to modify the error location.

This can be done in v2 by manually creating the desired validation error (possibly based on the errors from another); see this permalink for an example of usage: https://github.com/pydantic/pydantic/blob/ad909025f88d4f5ffae33d24d76d9b91f642c634/pydantic/main.py#L757-L763


SAK-48129 - GRADER: When clicking Cancel, Feedback Comment and Privat…

https://sakaiproject.atlassian.net/browse/SAK-48129
GRADER: When clicking Cancel, Feedback Comment and Private Notes should come back to green color and not be on yellow color. And should appear the grade saved

Please, let me test this on my local instance. I'll answer as soon as possible.

@kunaljaykam I've just tested on my local instance and it's not working at all.
With this change, when you click main Cancel the behaviour is the same as Save and published.
When clicking main cancel, old values (saved values) should appear on Grade, Feedback and Private Notes

Thank you for testing it. @jesusmmp . That's weird it's not working. I will take a look :)