Support recurrent meeting date times

Related issues
Fixes #72.
⚠ This PR breaks existing data files, you'll probably want to delete data/app.json prior to testing.
Description

[x] Use LocalDateTime instead of String to represent MeetingDateTime.
[x] MeetingDateTime accepts and converts a string if it adheres to the d MMM uuuu h:mma format (e.g. 10 Feb 2022 3:30pm).
[x] Fix test cases and modify storage to support the new date time format.
[x] Make MeetingEntry#getDateTime recurring.
[ ] Update GUI to reflect recurrent datetime change upon the execution of any command.

How to test

Execute add n/Tutorial u/https://meet.google.com/newstuff d/22 Mar 2022 12:38am dur/2 m/CS2103 r/Y t/Nope.
You should see a new meeting added with 22 Mar 2022 12:38am as its date time.

Other information

Just a suggestion, would it be better to have the user enter the month as a number instead? E.g. dd MM uuuu ... It's usually more common to enter it in the numeric format as it would be less likely to have typos, e.g. June vs Jun

That makes sense actually, I think we can go with that. If so, should we ensure that dashes are required for better readability? (e.g. d-MM-uuuu ...)
Alternatively, and for the sake of discussion, we could also use M/L as well to allow users to use one of 7; 07; Jul; July; J, which would address the problem you brought up as well.

I like the dashes, but would there be any issues with the updating the parser for the 2nd option?
Also, I think we can also display the day of the week on the GUI, e.g. Tue 22 Mar 2022 2:00pm

I think the second option is trivial to implement, but in hindsight, perhaps we might be confusing our users (e.g. the example usage says Jun is expected, but June or 07 works). If this is the case, I'll go with your first suggestion and enforce the dashes?
I'll also update the toString method to render in the format you've mentioned.

I agree with Natalie, I think this format d-MM-uuuu ... is good.

@NatalieTanML @Gnoznaug I've updated to use d-M-uuuu h:mma. This way, users don't need to have a leading zero for their month.

Codecov Report

Merging #92 (16aad1d) into master (c3b8de8) will increase coverage by 0.05%.
The diff coverage is 68.29%.

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     62.36%   62.42%   +0.05%
- Complexity      393      399       +6
============================================
  Files            83       84       +1
  Lines          1403     1437      +34
  Branches        137      139       +2
============================================
+ Hits            875      897      +22
- Misses          454      462       +8
- Partials         74       78       +4

Impacted Files
Coverage Δ

...ress/logic/commands/meeting/AddMeetingCommand.java
100.00% <ø> (ø)

...l/meeting/exceptions/InvalidDateTimeException.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <ø> (ø)

...ain/java/seedu/address/ui/meeting/MeetingCard.java
0.00% <0.00%> (ø)

...a/seedu/address/model/meeting/MeetingDateTime.java
72.41% <71.42%> (-7.59%)
:arrow_down:

...main/java/seedu/address/model/meeting/Meeting.java
82.75% <73.33%> (-6.38%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
77.58% <100.00%> (+0.39%)
:arrow_up:

...java/seedu/address/storage/JsonAdaptedMeeting.java
54.68% <100.00%> (ø)

.../java/seedu/address/model/meeting/IsRecurring.java
80.00% <0.00%> (-10.00%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b8de8...16aad1d. Read the comment docs.

Functionality wise LGTM, with one minor line removal. Would it be possible for some of the test cases to contain some recurring meetings as well? Locally, I changed some of the test cases to contain recurring meetings and they seem to work just fine.

I think the recurring test meetings were made non-recurring after the merge as it was suspected to be causing test case failures. Since the test case failures isn't caused by the recurring test meetings, I've reverted all test meetings to use their original recurrence.


Add custom namespaces definitions

I'm trying to make my caldav implementation based on this webdav server implementation and ran into the problem that I can't add an alias for the urn:ietf:params:xml:ns:caldav namespace. I understand that with the current implementation the alias is created automatically and it does not affect functionality, but for testing it is more convenient when the expected response will be more understandable

Thanks for contributing!
I will review it shortly


Update comments to reflect code behavior

Update comment so that its clear this value can be influenced by --Environment command line argument

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

I noticed that the value of env.EnvironmentName can be influenced by passing command line arg --environment upon startup. Adding this comment makes it clear that this value is typically the value of the environment variable, but not always.

@Tratcher Could you review further and take in or close?  Thanks.

The current PR is not ready to merge. Justin, can you make the recommended comment changes?

Closing, see #1182


fix: add parameter check to endpoint without parameters

Fixes #1207
Changes proposed in this pull request:

remove condition to only check parameters if there are any

I don't exactly understand this change. Also the Travis CI build is now failing.

Are you still interested in moving this PR forward? If so, please rebase onto main as we have moved from master to main.
It might make more sense to only do the check if strict_validation is used? That's what I get from the linked issue.

Closing due to lack of response. Feel free to reopen against main.


Sprite Batching

Implement sprite batching and sorting behavior. Renderer2D currently performs batched, deferred rendering, but textures are swapped out each time. This could be made more efficient by caching the textures in the GPU texture slots, and sorting by texture source.

Completed.


Binary search function in lax_control_flow_test.py doesn't work where anticipated

I'm trying to find the roots of a function differentiably using lax.custom_root, and for an initial test, I've been using the binary_search routine defined here in lax_control_flow_test.py.
The function is very similar in shape to this one: f = lambda x: -(1+jnp.tanh(x-4))/2 + 0.1, which has a root at ~2.9. No matter which starting bracket I use, I'm unable to find the root of f with this routine. Just as a cross-check, I can find the root with scipy.optimize.fsolve with most reasonable starting values.
I hope this is somehow useful, and not just stemming from my apparent lack of ability to understand the midpoint method (:

@shoyer mind taking a look at this one?

I think that binary search routine requires that the function is monotonic increasing, but your function is monotonic decreasing. Try taking the negative of your function?

Ah, I didn't think about that, this works :) sorry for the issue clutter!


Templates for DSE 4.6.1-1.

Snitch definition has been removed from dse yaml in 4.6

thanks, looks good. I had to change
default['cassandra']['dse']['snitch']           = 'org.apache.cassandra.locator.SimpleSnitch', since that was removed in the new version


The oldest webGL context will be removed when creating deck.gl instance many times

Version:  v5.0.0
Issue:
The console got 'WARNING: Too many active WebGL contexts. Oldest context will be lost' when creating deck.gl instances several times. End up the first/oldest webGL context become empty.
How to reproduce it:

Create one deck.gl instance
Add the second deck.gl instance
Remove the second instance and repeat step 2-3 several times.

Expected result:
The first deck.gl instance should be intact.
Actual result:
The first instance become empty but all the click/hover interaction still works.

@ibgreen experiencing this same error "Too many active WebGL contexts. Oldest context will be lost." when using deck.gl on top of react-map-gl. We have to redraw the deck-gl layer quite a few times and as a result, many contexts get created. Is there a way to remove those contexts?

. We have to redraw the deck-gl layer quite a few times and as a result, many contexts get created. Is there a way to remove those contexts?

@kamillejohnson
Unfortunately, the WebGL standard does not provide a way to destroy a WebGL context. It gets destroyed automatically when it is garbage collected, which can be quite a bit after you stop using it, so when quickly creating/destroying contexts it is common to run into this error.
Now, rhe first order of business is to determine if you are creating/destroying the DeckGL React component unnecessarily. Simply re-rendering the component should not cause a new context to be created, unless one react render cycle includes the DeckGL component, and the next one does not. Then unmounting/mounting will happen. So maybe just reorganizing your react app a little can fix it.
But if your UI is truly creating many different maps with deck.gl instances, things will be trickier.

Perhaps you could keep the same DeckGL instance alive, just feed it new layers and view state?
react-map-gl has a 'reuseMaps` option, that should make react-map-gl use less contexts, reducing the overall pressure on contexts.
I believe that DeckGL accepts a gl context but this is not well tested and may not work.

Hope this helps as a start.

That is very helpful @ibgreen , thank you! I was able to feed it new layers with different ids based on our changing state. Thanks for the suggestions!

@ibgreen Is it possible for deck.gl to use the WEBGL_lose_context extension here?
This is how three.js handles it - https://github.com/mrdoob/three.js/blob/363648ed473639c7abe3c78b9bbe61386344e297/src/renderers/WebGLRenderer.js#L310
It looks like mapbox-gl did end up adding this as well - https://github.com/mapbox/mapbox-gl-js/pull/2950/files#diff-274e90d38623e2e16a5e7d34414f33c7R1061
Some related discussion about using it - https://www.khronos.org/webgl/public-mailing-list/public_webgl/1611/msg00029.php

Just tested, it does work. For anyone who needs a workaround -
Add to your component:
  componentWillUnmount() {
    if (this.gl) {
      const extension = this.gl.getExtension('WEBGL_lose_context')
      if (extension) extension.loseContext()
    }
  }
  setGL(gl) {
    this.gl = gl
  }

Then add this prop to DeckGL:
onWebGLInitialized={this.setGL}

@contra
Hmm, interesting! I always thought of that extension as a "test harness" thing, but perhaps you are right, maybe this extension can be used to implement the missing WebGL "DestroyContext" function.
One approach could be to export a luma.gl destroyGLContext function that does this if the extension is available. @1chandu

This issue is referring to a very old release of deck.gl. We have implemented more rigorous resource tracking since then and it's enforced with unit tests.
Reopen if the issue can be reproduced with the latest release.


Add periodic encounter summary feature

Description
It would be useful for users to get a periodic summary of their encounters and interactions with people. This summary could be delivered on a weekly/monthly/yearly basis to the user. The summary should contain how many new people they have met, which people have the most new encounters added (most improved), who they have the most encounters and least encounters with. This should be delivered in a fun and engaging way that encourages users to keep connecting with new and existing people.
By having a periodic encounter summary provided to users, they can receive a reminder on who they should contact soon, and keep track of their progress and how close they are to achieving their networking/socialisation goals.
Acceptance Criteria

[ ] Summary is sent to users on a periodic basis
[ ] Summary provides information on how many new people they have met
[ ] Summary provides information on people the user has met that has the most new encounters (most improved)
[ ] Summary provides information on people who the user has the most encounters with
[ ] Summary provides information on people who the user has the least encounters with
[ ] Summary is delivered to users in a fun and engaging manner

Implementation details
Consider UI design of summary for an engaging user experience. Database may be required to store statistical data.
Testing notes
Tests should ensure that functionality works as intended. Take care when testing the periodic functionality.

LGTM!


Add custom 404 page

Adds a custom 404 page. Minor heads up: the image provided had a background color of #d8d8d8 vs. #bdbdbd, so I went with the former.

Adding cla: yes label, as the PR author is covered by CLA.


[KOGITO-3784] - Update CustomResourceDefinition to apiextensions.k8s.…

…io/v1
See: https://issues.redhat.com/browse/KOGITO-3784
Signed-off-by: Tarun Khandelwal<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster
[x] You've added a RELEASE_NOTES.md entry regarding this change

/jenkins test

Just rebased the PR


Merging cells for specific rows

Hi,
I would like to show a tree with two distinct types of rows (returned data).
Problem is that columns for these two types of data have different types and number of columns.
Because there are many columns, I would like to merge some columns into one (cell merging in excel) for row types with fewer column numbers.
As far as I can see this is not possible with the latest jstree-grid.
If I am right, will you consider implementing it or at least point me in the right direction?
Regards,
Uros

Um, wow? I cannot even visualize what you are trying to do. Do you have some kind of mock-up as to what it might look like?

Hi,
I hope the following image explains it :)

Regards,
Uros

I don't see how it is possible. The current structure actually is columns, with each cell a

 in the column (and then the positioning calculated, which is complex, but worlds easier than pixel calculations where when it was horizontal  elements).
Hmm, I guess if you got an overlaid element just right?
Feel free to go ahead and try a PR if you want, but it is likely to be complex to get right.  :-)
I will close out the issue, but if you find time to do a PR, that would be great and most welcome.

Ok, thanx.
I will think about it.
Regards,
Uros


Write a blog post that explain how this kernel work

Write something like https://os.phil-opp.com/ to explain step by step how this kernel work would be great!

Actually, it's hard to say bootgo is an OS kernel, it does nothing other than print "hello world".
This tutorial already explains everything about how it works https://wiki.osdev.org/Bare_Bones


Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.
Let's edit this pull request to add a body description.
:keyboard: Activity: Fixing your pull request

The first comment on your pull request will have the default text of No description provided. Click on the ... icon located at the top right corner of the comment box, then click on Edit to make an edit
Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
Click the green Update comment button at the bottom right of the comment box when done

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.

I'll respond when I detect this pull request's body has been edited.
_Originally posted by @github-learning-lab[bot] in https://github.com/Rose2161/github-slideshow/pull/7#pullrequestreview-867071905_p

Created and worked on many thinga


Getting status code 407 when using the proxy running on EC2 server, but works well when started on local machine

I installed and configured scrapoxy on my local machine (macOS) per the AWS / EC2 section in the documentation and it works well. I am able to run scripts using the proxy IP http://localhost:8888 without issues.
2018-05-11 01:49:28 [scrapy.core.engine] DEBUG: Crawled (200) <GET http://g20.bimmerpost.com/robots.txt> (referer: None)
2018-05-11 01:49:34 [scrapy.core.engine] DEBUG: Crawled (200) <GET http://g20.bimmerpost.com/forums/forumdisplay.php?f=701/> (referer: None)

Then, I installed and configured scrapoxy on an AWS EC2 instance the same way. I started scrapoxy and I see the EC2 instances getting created and managed by it. I can also access the GUI and view those instances at http://XX.XX.XXX.XXX:8889/#/home/instances, where XX.XX.XXX.XXXX is the IP of the EC2 machine scrapoxy is running on. However, my scripts are failing with the status code 407 when using the proxy IP http://XX.XX.XXX.XXX:8888.
2018-05-11 02:26:35 [scrapy.core.engine] DEBUG: Crawled (200) <GET http://g20.bimmerpost.com/robots.txt> (referer: None)
2018-05-11 02:26:42 [scrapy.core.engine] DEBUG: Crawled (407) <GET http://g20.bimmerpost.com/forums/forumdisplay.php?f=701/> (referer: None)

Is there something I need to configure differently either in my scrapy scripts (that are running on my local machine) or in the scrapoxy config that is running on the EC2 instance?

Hello @sumanpoluri , did you tried to set a password ?
Fabien.


Invalid pagination numbers in Blog section.

Hello! Great work on the theme, I've been messing around with it a bit and am most likely going to use this, but I noticed that the pagination counter appears to be hard-coded to always say 1 of 1 when looking at the components/shared/jekyll/pagination.jekyll.html file.
I tried to figure it out myself, but I don't know enough about Jekyll yet to fix it myself. It's not a huge deal that it isn't working, but it'd be nice to get it sorted eventually.

👋 Hi @Torbikini
This template is setup to use our pagination tool Pagebreak, so those page numbers will be updated after the build when Pagebreak runs. (Note the data-pagebreak-control attributes on the html elements)

My mistake! This file was misconfigured and should have been using data-pagebreak-label. I have updated the repository, is this now working for you?


fix: prevent operations when maker/taker service is running

This PR tries to prevent  operations that could negatively  impact running maker or taker services.
See comment https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1242#issuecomment-1099423159 by @AdamISZ which implies that it can have unforeseen side-effects.
Currently the following actions are prevented when a maker or a taker service is running:

Sending a transaction (till now "non-collaborative" transaction were possible even when services were running)
freeze/unfreeze actions

Additionally (has nothing to do with running maker/taker):

prevent unfreezing of fidelity bonds before locktime is over

This is done by disabling some forms or buttons - as you know, this does not prevent anybody from sending API requests directly. It should just mitigate the problem for everyday users.

I presume you'd agree we should also disable it in the backend?

I presume you'd agree we should also disable it in the backend?

Yes, that feels perfectly reasonable.

I feel like it would be useful if this info text would be a button that leads to the "Earn" page (or if there'd be a link in the text).

:+1: Done! "Earn" is now a link to the Earn screen. I feel like we could also make a "Stop" button here as this is what the user might do on the Earn screen anyway.. what about that?

Blocked by #222 .

I added the Earn Link and also a Chevron to the right: https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/?node-id=2850%3A67638 both will link to the earn page.
I wouldn't add another functionality like direct stop, the information should be more than enough at the beginning for the user.

Is there a way to have a "graceful fallback", so when it's not possible to make a payment, instead of failing, stop maker, make payment, start maker.

Is there a way to have a "graceful fallback", so when it's not possible to make a payment, instead of failing, stop maker, make payment, start maker.

I think I understand what you are getting at. Ideally a user has the maker running at all times without too much manual intervention.. would you open a ticket so it can be addressed thoroughly? Once feature parity has been reached, these are ideas that can be focused on. :muscle:

Updated! Latest changes include reloading the session information, as it should be decided as soon as possible whether the operation is enabled at all. This request does not have much overhead and the response should arrive quite fast.

Looks good!
A couple of comments inline, nothing tragic.

Thanks for your feedback @dnlggr . :pray:

What's up with the Sprite?

Was wondering that too!
Resisted to investigate successfully : D


replace $j reference with jQuery

to fix https://github.com/Strategery-Inc/Magento-InfiniteScroll/issues/168

Thanks!

I need to test this, as far I remember I did it that way on purpose because other wise the trigger will not work in RDW (which is the only theme for what we need it).

OK
this fix works for me, fixed the problem caused by using $j in my own custom theme

@damian-pastorini jQuery should always be available under "jQuery" (as long as it's loaded). The jQuery.noConflict() call exists only to avoid issues with the $ alias. So generally speaking using jQuery should always be safe.
But do double-check just in case, thanks.

PS: just to let you know that "jQuery" reference is used in RWD theme in persistent/remember_me_tooltip.phtml file
however, it's the only usage I found in this theme
but of course, please check on your side
thanks

@aurmil confirmed it doens't work with jQuery, it only works with $j, I'm still checking why.

Well, actually all the associated events are been triggered in:
skin/frontend/rwd/default/js/app.js
And everything is defined in $j(window), so basically that's why.
I'll include a validation to check if $j is defined to avoid issues with other themes that doens't use RWD as base or fallback.

OK
it's strange taht using jQuery doesn't work
from jQuery.noConflict() docs:

If necessary, you can free up the jQuery name as well by passing true as an argument to the method.

the only noConflict call is made without parameter
jQuery is not defined at all in your scope? just for my own curiosity

Try using just $ instead of jQuery, because in that context we know that $ should work.
Otherwise try using window.jQuery and see what happens.

I expect both of the above to fail, otherwise the fact that it doesn't work with just jQuery would be very weird.
Finally, if none of the above works, try something like this and see if it works:
var _jq = ($j && $j.fn && $j.fn.jquery !== null) ? $j : $; // prefer AWS's jQuery
_jq(window).trigger(/* etc */);

jQuery it self is not the problem but where the events are been assigned or triggered from.
$j is a variable so it's an specific instance of jQuery and if you define something inside that var like $j(window).trigger('delayed-resize', e); 'delayed-resize' will only exists in $j and not in jQuery.
To see this you can check the following lines in the console (tested in a clean M <IP_ADDRESS> installation with M1 sample data):
$j.event.global;
jQuery.event.global;

To prevent any issue in case you are not using RWD (where $j is defined) I just added a validation to check $j.
PR: https://github.com/Strategery-Inc/Magento-InfiniteScroll/pull/170
@gsomoza could you please confirm to merge? thx!

Closing this, check https://github.com/Strategery-Inc/Magento-InfiniteScroll/pull/170

OK thanks for the explanation


M3-1683 User links in sidebar on mobile

This PR does:

keep the create button on all viewports
hides the user icon on mobile sizes
add the user profile and logout link in sidebar menu on mobile

Coverage decreased (-0.005%) to 28.062% when pulling 7faccc9d168b8d3b57931d45eeb1a592c97075b6 on alioso:M3-1683 into 03897aa3f837125138a32e5325a96ff53e4a1e91 on linode:develop.


how can I add new operations, such as rotate_nms.

If you refer to a CUDA extension, you can add it to the ops directory, and modify the setup.py to compile it.

i have add a cuda extension to th ops directory and modify the setup.py,  and i compiled it successfullly. but when i run dist_train.sh, the error occurs.

The most probable reason is that compiling and runtime CUDA versions are not the same. You may update to the latest version, rebuild it and then run python tools/collect_env.py to check it.


Feature request

Holding the shift key (or any convenient key) and scrolling the mouse wheel with the pointer anywhere on screen to change the master volume

Thanks for your suggestion, but I will not be implementing this because the primary purpose of this project is to control the audio while the mouse cursor positioned somewhere where it doesn't hinder other programs, namely the taskbar.
Enabling control anywhere else would cause problems whenever another program allows for scrolling as well, like your web browser.
While these problems can be solved I believe there are already other existing projects offering this functionality and doing a better job at it than tb-vol-scroll would.


adding unit on result?

Hi, I have a mixin that takes two numbers and calculates percentage between them. I then want to add a % unit to the result. Any ideas on how to do that?
@define-mixin percentage $width, $height {
        height: resolve(($height / $width) * 100);
}

I can do this:
height: resolve(($height / $width) * 100)%;
but I then have stylelint
Expected whitespace after ")"   function-whitespace-after
that will add a spece before % which isn't what i want.
Any ideas on how to get this working without disabling stylelint?

I mean... stylelint is specifically saying this is not allowed where it's needed.
Your best bet (and what I do personally) is disable it just for the one line.
/* stylelint-disable-next-line function-whitespace-after */ should go right above your property.
This would look like
@define-mixin percentage $width, $height {
  /* stylelint-disable-next-line function-whitespace-after */
  height: resolve(($height / $width) * 100)%;
}


docId not available on client with validation when using collection2

Hi there,
When using autoform, this.docId is not set for validation logic (in custom, but also autoValue methods from simple-schema) on the client due the update method not using { _id: docId } (see here: https://github.com/aldeed/meteor-autoform/blob/master/autoform-events.js#L355).
This causes unexpected behavior, because when the same logic executes on the server, this.docId is available. It's also available when you set schema on the autoForm component.

:+1: This is causing is preventing me from setting up scoped uniqueness.

I am now using isServer for validation. It works so I am not blocked anymore:
custom: function () {
  if (Meteor.isServer) { ... }
}

Fixed as workaround in devel branch and also created https://github.com/aldeed/meteor-collection2/issues/163

Done in AutoForm 5.0, now released.


complex DenseElementsAttribute

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 25.57%. Comparing base (b6ffc96) to head (ca2d876).
Report is 7 commits behind head on main.

Files with missing lines
Patch %
Lines

src/mlir/IR/Attribute.jl
0.00%
3 Missing :warning:

src/mlir/IR/Type.jl
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   21.66%   25.57%   +3.90%
==========================================
  Files          46       46
  Lines        8048     8074      +26
==========================================
+ Hits         1744     2065     +321
+ Misses       6304     6009     -295

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add an automated test

Use the Kiln framework to add at least one automated test to this repository

It wont allow me to download the Json file.

I'll download the JSON file for you

interview (1).json


New output writers

Add new output writers

Is this really an open issue?
At the moment I don't see the need to create a new outputwriter since we have writers for .xlsx and xlsm
Any enhancements for the official project here I can currently think of could be implemented in either one class mentioned above
I suggest to close this issue

The initial idea (year 2010) was to create also a writer for native Open Office file format...
But It has very low priority and I'm open to consider to close this issue.

Ok - again half a year has passed and no one wanted to have this done urgently.
Closed


Add Go SDK

I'm breaking this into separate tickets for each call to support.

[ ] Postgres MD5
[ ] Postgres scram sha 256
[ ] MySQL sha 1


Toast On Creation #19

Related Issue
Closes #19 & #39
Type of Change
Put x inside the square bracket to specify what type of change your PR is:

[x] New Feature

Description of Change
This adds a toast message on creation of the task & also sets the navigation between Home Screen and form screen accurately.
Implementation Details
fluttertoast plugin is added to show toast on creation of the task.

@pranavkonidena I intended to tackle only #19 but it made no sense without #39 so therefore this PR includes 2 references to issues


feat: restrict folder copied into image

Close #210

For ping usage in rootless case, need to set cap_net_raw on ping command : setcap cap_net_raw=pe /bin/ping


Add computation modes to ideep primitive descriptor cache key

fpmath_mode, accumulation_mode, scratchpad_mode and deterministic modes are not encoded as part of the key for the PD cache. This can cause subsequent creations of a primitive to ignore changes to these modes ( e.g. during unit tests ).
In particular changing fpmath_mode between subsequent, calls to otherwise identical matmul has no effect since the pd is loaded from cache from previous call.
Using ONEDNN_VERBOSE we could see that the primitive descriptor is loaded from cache and toggling the fpmath mode on/off between subsequent calls didn't have an effect. This code should resolve that issue and other computation modes are added here ( deterministic, scratchpad and accumulation ) to ensure consistency.

@jgong5 Could you please take a look?


Also compile libcore.

Ignored tests pass locally.

Replaced by https://github.com/chriseth/powdr/pull/187


check of redirect_uri is too late

in case that the client sends an invalid redirect_uri the user has first to go through the login process and if that was successfull the application fails due to the invalid redirect_uri.
In our case the login process is a somewhat long story for the user and this behaviour is very inconvenient and undesirable. The check should be done before the authentication.

@Captain-P-Goldfish As per Section 4.1. Authorization Code Grant:

(B)  The authorization server authenticates the resource owner (via
the user-agent) and establishes whether the resource owner
grants or denies the client's access request.

The Authorization Server must authenticate the user first before the validation of the Authorization Request  parameters, which includes the redirect_uri. The current implementation is implemented to conform to the spec and we cannot deviate from it.
I'm going to close this issue as I feel I have answered your question.

@jgrandja The section you quoted Section 4.1. Authorization Code Grant is an over simplification of the process and is superceded by Section 4.1.1 Authorization Request:
The authorization server validates the request to ensure that all
required parameters are present and valid.  If the request is valid,
the authorization server authenticates the resource owner and obtains
an authorization decision (by asking the resource owner or by
establishing approval via other means).

@vpavic @dfcoffin Thanks for the correction. I skimmed over the details so thanks for catching me on that.

@jgrandja I've submitted an errata request to modify Section 4.1 Authorization Code Grant (B) to be consistent with the contents of Section 4.1.1 Authorization Request, since I have encountered this mis-interpretation by other OAuth 2.0 Authorization Framework implementations

thx for the strong support here :-)


Expired certificate on tozo.dev

Looks like the website certificate expired. Firefox screenshot:

Sorry about that, I've renewed it now.
The certificate is valid for 90 days, so I need to remember to run terraform apply before the end of that period. Let's encrypt does send a reminder email, but I renewed the wrong certificate (my personal site pgjones.dev) instead.


Report warning for an insufficient warmup in a benchmark

In all of our benchmarks, we try to measure the peak performance. That is, the performance of a program once all the dynamic compilation is finished and stable. We assume that during the warmup phase of a benchmark, all the dynamic optimizations and compilations are finished and thus, during the measurement phase of a benchmark, no more dynamic compilation happens. All our benchmarks are micro benchmarks and so, we don't want to measure the performance of the dynamic compiler. If the warmup is not sufficient, and some dynamic compilation creeps into the measurement, it has negative impact on the stability of the results. The standard deviation for benchmarks with insufficient warmup tends to be high, and thus, the results of such benchmarks are less reliable.
We can ensure that no dynamic compilation happens during the measurement phase by dumping --engine.CompilationDetails logs and ensuring that no opt or deopt happens in measurement. So the idea is to start the benchmark with env JAVA_OPTS=-Dpolyglot.engine.CompilationDetails=true, gather these logs (along with their timestamps), and make sure that there are no logs during the measurement phase.

Kind of implemented by #10574


Make avatars in Recent Topics open user info popover on click.

The same method and working as other user info popovers. (Ignoring muted users)
Fixes: #21154

Testing plan: Manually for both themes.
GIFs or screenshots:

Screenshot

Gif

Merged after a few tweaks documented in the updated commit message, thanks @yogesh-sirsat!  Note that we always use a subsystem name before a : in our commit messages, and spend the time explaining why a change is correct, not what we did.  (In this case, it's sorta clear from the implementation).
I also moved the code to click_handlers.js, where all the other recent topics click handlers live.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

I will take care of those things next time, also thank you for your polite feedback.


Creating json eventdata from str/byte

I would be nice if one could construct json EventData from already made json.
e.g.
eventstore::EventData::json_str()

Hey @jsiefer,
You can achieve that already by using serde_json::RawValue. I think you might find that function useful: https://docs.rs/serde_json/1.0.107/serde_json/value/struct.RawValue.html#method.from_string
serde_json::RawValue implements Serialize

Right, good point! Thank you!
(and sorry for the late reply)


Feature/3552 drawer nav group examples clean up

Fixes # BLUI-3552

Changes proposed in this Pull Request:

Drawer Nav Group examples

Screenshots:

To Test:

yarn start:reactdev
Navigate to Drawer -> Drawer Nav Group

Is this PR suppose to be in draft PR. Referencing BLUI-3552 and it looks like there are missing updates for this....
Showcase area and code snippets should have rounder corners
Code links need to be updated to master/dev branch (use an ENV variable)
Example descriptions
Boolean descriptions need to be aligned as a subtitle of the prop name
Don't show * for required props
'htmlColor' should just say 'Icon Color'
Appear AnimationDuration doesn't seem like it's working…or the range of values is not wide enough
ScrollThreshold needs a wider range of values (angular maxes at 400 & defaulted at 100)
Don’'t show scrollContainerId knob


Sets static port for vnc (fixes #47)

Not using the static port breaks the image, rendering it unusable. This essentially reverts commit https://github.com/jupyterhub/jupyter-remote-desktop-proxy/commit/447bf86d66bced05e5a02160f2eb5c0739994b68 to fix this

Opened https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/53 instead


not all messages might be for slackbot; disable with $IGNORE_NON_BOT_MESSAGES

Hi @drnic, thanks for your contribution. I am having trouble understanding the case where messages would come from slack that are not meant for slackbot. Could you explain the use case?

I think it happens when you register without a prefix (like ?) and so slack sends you all the text all the time.
I latter figured out /slash commands; and now have stopped using the non-slash commands.
So I think this PR can be closed. It doesn't add enough value justify the code it adds.
On Thu, Feb 18, 2016 at 8:09 PM, Andrew Schwartz<EMAIL_ADDRESS>wrote:

Hi @drnic, thanks for your contribution. I am having trouble understanding the case where messages would come from slack that are not meant for slackbot. Could you explain the use case?
Reply to this email directly or view it on GitHub:
https://github.com/trinchan/slackbot/pull/18#issuecomment-185637406


Pull request to approve rspec test for Player and TicTacToe

Hi Team,
Please don't submit another CRR ( code review request) if other milestones are not completed yet.

Heya! we understand the idea behind not opening a code review request until the prev. milestones are done, but if code review takes more than 24 hours, we can't move forward if we don't submit further code review request for more work done in the project.


update plan_snapshot_summary to take in to account minor amendments. not being approved

the legal start and end dates should make sense
TODO. more info here

@calebissharp should we try and follow the same pattern as discards I wonder?


Accessing navigator props outside of navigator?

How can I access props from specific Navigator from otside of this Navigator?
<StackNavigator1>
page1: {
 screeen: Page1
}

<StackNavigator2>
 page2: {
 screeen: Page2
}

</Page1>
 <Text>**Display StackNavigator2 routName** <Text>
 <StackNavigator2/>
</Page1>

I don't believe this is possible (could be wrong), but Redux would be something to handle this.

Might be tricky but you could access a ref to it


How to install catkin on ros2

OS: Ubuntu22.04 LTS
Python version: 3.10.4
I have a test project that needs to use catkin_make, but I can't install it when I use apt install catkin, and there is currently no documentation to learn from. I haven't found a solution through Google search, please help!

Catkin is a tool for ROS 1, not ROS 2. You need to set up the package repositories for ROS as specified in the ROS installation instructions before you can install catkin.

Catkin is a tool for ROS 1, not ROS 2. You need to set up the package repositories for ROS as specified in the ROS installation instructions before you can install catkin.

Hello, what can I use to achieve the function of catkin_make in ROS 2

ROS 2 uses colcon.

ROS 2 uses colcon.

Thanks!

colcon.

Hi, is colcon maintained by ros2 official develop group?


ARROW-8022: [C++] Add static and small vector implementations

@ursabot please benchmark

Example benchmarks here: https://gist.github.com/pitrou/ef69c9dac5c845f1dd7106941bfa633f

@ursabot please benchmark

I added a AlignedStorage facility. @bkietz Can you take a look again?


Logged in users can leave comments

AuthServlet responds with users email if logged in and log in or logout links.
JS fetches from AuthServlet if user is logged in and displays comment form if logged in, otherwise hides it.
Log in and Log out links are displayed.

Users email is automatically used now as name instead of asking for username.


dropdown items not showing, but they have values

i am having a weird issue with dropdown items not showing when the dropdown is clicked. i even re-populate the dropdown when the control is clicked.  i have console messages letting me know that happened.   the dropdown items don't show, but the tags are filled in if i look at the page source...the hundreds of options that get loaded up simple don't "dropdown".
my bootstrap-select is sitting inside a bootstrap datatable, which is inside a bootstrap tab.   i have tried moving the select out of other containing tags, but that didn't help. but if i refresh the page, it is fine (usually).
MVC 5 web app, dot net 4.6.1
bootstrap-select 1.13.5
bootstrap 4.3.1
jquery 3.3.1
datatables 1.10.15
chrome 72
visual studio 2017
here is a copy of my page.   i don't know if stuff is loading up in the right order...that's the only thing i can think of that might cause this.
--- edit - got rid of this, because it is irrelevant.

It sounds like you might not be loading the correct CSS? Could you link me to a demo?

https://plnkr.co/edit/YwTL7Yep5EdhMLazOKSV
i did my best to setup this plunker.   long story short, i see all those values in the select, but it won't show when i drop it down.   this is happening on the certification tab, with a select called "program".   I suspect it coulld be datatables.js, moment.js, or the tabs that is doing it.  i'm going to keep playing with the order in which stuff loads up, as javascript can be pretty finicky with what loads and when.

note above, that in the browser debugger, i see all these option values.   i did a page source, and all i see there is:
`

--
  |
  | Program
  |
  |
  |
  |
`
so i am not familiar enough with debugging javascript to figure out why i see it in debug, but not in the page itself.  weird.

Yes, that select is on the page, but the elements of bootstrap-select are appended dynamically (assuming your select has more than 600 options in it).
In any case, looking at your Plunkr, you're loading jQuery after Bootstrap, and you're also not loading Popper.js, which is a requirement of Bootstrap 4.
Changing that seems to fix your issue: https://plnkr.co/edit/jI3Oqy3jSI4unzu2R2RE?p=preview.

thanks for your help!  i did change the order of stuff loading up.  looked at network tab in debugger, and verified scripts loading up the way they should.  the same problem exists, but i can assume this problem isn't the dropdown, but my lack of understanding on debugging web stuff.   thanks again.

for the one facing this issue with bootsrap-select ensure that your jquery is selected before the loading the bootstrap select.
`

`
That order is important to ensure that the options values to show.


Support for New Cucumber version (@cucumber/cucumber)

Currently Testcafe is not supporting the latest version of @cucumber/cucumber
Since the older version of Cucumber is deprecated and the tests running with cucumber are on hold now
Using Testcontroller, hooks and cucumber should be supported

Hello,
Testcafe does not have any built-in integration with Cucumber.
For further support, you need to contact the author of the Cucumber package.


property deleted by atom-beautify

Description
The results of beautification are not what I expect.
Input Before Beautification
This is what the code looked like before:
var o = { uploading: e.loaded/e.total*100 }

Expected Output
The beautified code should have looked like this:
var o = {
  uploading: e.loaded / e.total*100
}

Actual Output
The beautified code actually looked like this:
var o = {
  uploading: e.loaded / e.*100
}

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Checklist
I have:

[ ] Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[x] Reloaded (or restarted) Atom to ensure it is not a caching issue
[x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[x] Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
[ ] Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue

Which language and beautifier are you using?  Can you generate a debug gist?

Hi, szeck87 , thank you for reply.
I am using the default settings, so I assume the beautifier is JS Beautify and the language is JavaScript. My atom version is 1.20.1 x64. Hope it helps. :)

I'm not able to recreate.  Can you debug and post a gist of the log to this?  Also, is this the only code in that file?  If not, please upload the file itself.  Both of these will help troubleshoot the issue.

I remember seeing something like this a while ago.  I bet this is an issue with old Pretty Diff.  It does not appear to be present in the current version of Pretty Diff.
If my guess is correct then this issue will be resolved by completing this pull request: https://github.com/Glavin001/atom-beautify/pull/1750.  The pull request is held by a conflict with a newer dependency.

@prettydiff  Ah you're right.  I switched to prettydiff and it did just that.
@benpptung Try switching to js-beautify as the default javascript beautifier.

The latest version of Pretty Diff is published to Atom Beautify where this issue is resolved.


how to get the.npz file?

Hello, I would like to inquire how to obtain the .npz file corresponding to the instruction --ld_fp for East Asian populations. Looking forward to your response. Thank you!

I don't know if it helps but I found the .npz file for the data used in demo section in their Zenodo: https://zenodo.org/records/7618667

Hi @AndyYang0924 ,
Thanks for your interest in using our software! We don't have the reference for the East Asian populations. Note that our method requires matching sample between the sumstats and the LD, so you might want to obtain the LD information for the GWAS sumstats you're using, or generating them yourself if you have access to the genotypic information for that sample.
Thanks @KKristyXiang for referencing the Zenodo link! We uploaded some data there for the demo example in the wiki tutorial. I actually have the banded + low-rank approximation for the chromosome-wide LD in the UKB ready, and I'm just looking to share those data with the public efficiently.
Hui


test/provision/compile.sh: Make usable from dev VM

Add missing 'sudo' commands so that this can be run from a shell in a dev VM to launch a local cilium agent in docker.
Only install the bpf mount unit to systemd if not already mounted. This avoids error message like this:
Unit sys-fs-bpf.mount has a bad unit file setting

With these changes Cilium agent can be compiled and launced in docker, assuming the VM hostname does NOT include "k8s", like so:
$ SKIP_TEST_IMAGE_DOWNLOAD=1 VMUSER=${USER} PROVISIONSRC=test/provision test/provision/compile.sh
After this 'docker ps' should show a "cilium" container.
This can be used, for example to quickly run Cilium agent locally to observer agent startup and exit logs via 'docker logs cilium -f' when stopping cilium with 'docker stop cilium'.

/test


Ability to instantiate prefab with various components, and have their dependencies injected

I'm using the factory method to inject the dependencies of a MonoBehaviour attached to a prefab which is instantiated at runtime, according to the documentation:
public class Mono : MonoBehaviour
{
    private IDependency _dependency;

    [Inject]
    public void Construct(IDependency dependency)
    {
        _dependency = dependency;
    }

    public class Factory : PlaceholderFactory<Mono> {}
}

public class MonoSpawner : IMonoSpawner
{
    private readonly Mono.Factory _monoFactory;

    public MonoSpawner(Mono.Factory monoFactory)
    {
        _monofactory = monoFactory;
    }

    public void CreateMono() => _monoFactory.Create();
}

public class MonoInstaller : MonoInstaller
{
    public GameObject injectedPrefab;

    public override void InstallBindings()
    {
        Container.Bind<IMonoSpawner>().To<MonoSpawner>().AsSingle();
        Container.Bind<IDependency>().To<Dependency>().AsSingle();
        Container.BindFactory<Mono, Mono.Factory>().FromComponentInNewPrefab(injectedPrefab);
    }
}

This is useful for instantiating the given prefab at runtime and having it's dependencies injected. I can't see in the documentation any way to instantiate a prefab at runtime with multiple monobehaviours attached, each with their dependencies injected. Is this possible? If not, I would like to request it as a feature.

Turns out this method does work with multiple components attached to an instantiated prefab.


[move-prover] Fixes a bug with instantiation of schemas from other modules

If one would write M::Schema<T> the type instantiation was not correctly propagated.
Also fixes a racing condition between two older PRs which made tests fail.
Motivation
Bug fix.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Passes repro.
Related PRs
NA

@bors-libra r=junkil-park

:pushpin: Commit 7e8a21b has been approved by junkil-park

:hourglass: Testing commit 7e8a21b85ef25346362700f5980873d82afa4dc5 with merge 6303fcb4900a1e3ce867d4f7261bd566bdaae618...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

@bors-libra r=junkil-park

:pushpin: Commit 7e8a21b has been approved by junkil-park

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #3729

@bors-libra r=junkil-park

:pushpin: Commit 44511d4 has been approved by junkil-park

@bors-libra r=junkil-park

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #3744

:pushpin: Commit 44511d4 has been approved by junkil-park

:hourglass: Testing commit 44511d4b2aadad997a801ffcf64961e9b492dcc8 with merge b07c4350dcfc350b671812ecf97b68bb96dcc7a4...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: junkil-park
Pushing b07c4350dcfc350b671812ecf97b68bb96dcc7a4 to master...


sprintf formatting regression

[x] Have you checked the guidelines in our Contributing document?

Description
After upgrading to the current version of sprintf.js, a formatter I'm using in my code does not work anymore.
The format string %.*f now results in "f" instead of a number with the precision taken from the argument list.

In last patch I improved compatibility with PHP. The format you've used is not valid (per http://php.net/sprintf).
Previous sprintf implementation differed a lot from PHP's sprintf implementation.
Now a question to @kvz : what strategy should I follow? Keep backward compatibility with older locutus releases in mind or mimic PHP as close as possible?

Sounds like a bug in the php implementation to me. At least when looking at something like https://en.wikipedia.org/wiki/Printf_format_string#Precision_field

As a rule of thumb, I would mimic php's behavior as close as possible (while still being useful in/with pure js projects/objects), and not worry about backwards compatibility. We're not semver, and can bundle a BREAKING into the CHANGELOG.md for that function, in that PR.
--
Kevin van Zonneveld (kvz.io)
Co-founder at Transloadit (transloadit.com)
Core-author of tus (tus.io)
On 12 March 2018 at 16:00:48, ray007<EMAIL_ADDRESS>wrote:

Sounds like a bug in the php implementation to me. At least when looking at something like
https://en.wikipedia.org/wiki/Printf_format_string#Precision_field
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/kvz/locutus/issues/365#issuecomment-372340310

It's not just a breaking change, it's removing a feature.

I'll look into restoring support for the dropped format. Maybe it turns out to be simple without breaking the PHP compatibility.

It's now a tough nut to crack, because restoring the feature means breaking PHP compability.
If we can call it a PHP bug? Not sure, it's maybe on purpose, because PHP's sprintf is not just a wrapper around the C-function. Here is the precision parsing, and here applying the precision. I don't see any logic which is derived from .* format

My plan is to port the C version of sprintf in the C-lang namespace of locutus. Hope this solution suits you.

Sounds good to me. Thank you.
When you do so, could you please trigger this thread here with another comment?

@ray007 I've prepared a pull request (https://github.com/kvz/locutus/pull/368) implementing sprintf.
I tried to be as close as possible to the rules you've linked previously.
The implementation is not yet 100% complete, but I'll extend the function with new patches.
Please check if it works as expected for you.

I will close the issue. In case there are problems with the new implementation, please raise new tickets.

Thanks.
I haven't yet updated since my target environment is ES5 only, will hopefully find time soon...


[Improve] Fix possible potential thread unsafe issues

What's changed?
In a multi-threaded environment, addNode() and removeNode() will have thread unsafe issues, divides the existing addNode and removeNode functions into smaller, synchronized operations: addVirtualNode() and removeVirtualNode(). In this way, addNode() and removeNode() also can be called in parallel. And add the ConsistentHash class Unit testing
Checklist

[x]  I have read the Contributing Guide
[ ]  I have written the necessary doc or comment.
[x]  I have added the necessary unit tests and all cases have passed.

Add or update API

[ ] I have added the necessary e2e tests and all cases have passed.

lgtm!👍  This includes core scheduling changes, recommended that merge it after releasing version 1.6.0.


Refactor CouchbaseLiteHttpClientFactory and way holding OkHttpClient

Current implementation of CouchbaseLiteHttpClientFactory and way to hold OkHttpClient is not clean enough. We need to refactor this.

@hideki is it taken care in CBL 2.0? Please  confirm..

Hi @NitzDKoder,
With CBL 2.x, CBL uses WebSocket feature of OkHttp. And way to use OkHttp is different from CBL v1.x. I will be careful how to create OkHttpClient instance.


Added draw_bounding_boxes for one_shot_object_detector

Can you also add it to the API docs by adding it in .rst file

Can you also add it to the API docs by adding it in .rst file

Done.


[shared] Skip flux installation if installed

Describe the bug
Currently while running the deployments bevel always tries to install the flux, even in the case when the flux is already installed.
To Reproduce
Steps to reproduce the behavior:

Run the deployment twice

Expected behavior
If the flux is already installed, the installation should be skipped if there is an instance available in the cluster with namespace flux-{{ network.env.type }}
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: [e.g. MacOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

flux installation is idempotent. Is running the flux command again causing any issue ?

closing this issue, as this is expected and not a bug


[Feature] The parse_datetime function throws an exception when parsing fails in trino mode

Why I'm doing:
In presto, if there is a problem with the format of parse_datetime, an error will be reported, but in StarRocks, it only returns a NULL. This brings certain difficulties to the migration from presto to StarRocks
What I'm doing:
Add a new udf. This new udf will be used in trino mode and an error will be reported when parse is abnormal. This new udf takes the logic of the original udf.
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[x] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Is it possible to pass the sql_dialect parameter to BE? Then use this parameter to decide whether to throw an exception or not, I think there will be other functions that will need to handle exceptions after that as well

Is it possible to pass the sql dialect parameter to BE? Then use this parameter to decide whether to throw an exception or not, I think there will be other functions that will need to handle exceptions after that as well

After modifying the definition of TQueryOptions in thrift, it can be passed to the backend and can be easily obtained in the function context. I will change it like this.

Is it possible to pass the sql dialect parameter to BE? Then use this parameter to decide whether to throw an exception or not, I think there will be other functions that will need to handle exceptions after that as well

Could you please review it again?


[Feature Request]: Convert tools folder into one or multiple PowerShell modules

Description
To ease the usage & structure of our tools folder, I'd propose to convert it into one or multiple PowerShell modules with a proper structure like
To ease the usage & structure of our tools folder, I'd propose to convert it into one or multiple PowerShell modules with a proper structure like
To ease the usage & structure of our tools folder, I'd propose to convert it into one or multiple PowerShell modules with a proper structure like

private/ (inner helper functions)

public/ (exported functions - i.e. can be used from the outside)

src/ (e.g. templates)

modulesName.psd1
@{

    # Script module or binary module file associated with this manifest.
    RootModule           = 'ModuleName.psm1'

    # Version number of this module.
    ModuleVersion        = '0.1.0'

    # Supported PSEditions
    # CompatiblePSEditions = @()

    # ID used to uniquely identify this module
    GUID                 = '807456f1-947d-43af-9b4d-49d13f593130'

    # Author of this module
    Author               = 'CARML'

    # Company or vendor of this module
    CompanyName          = 'Microsoft'

    # Copyright statement for this module
    Copyright            = '(c) ServicesCode. All rights reserved.'

    # Description of the functionality provided by this module
    Description          = 'Automatically generate new CARML modules using the Azure API & docs.'

    # Minimum version of the PowerShell engine required by this module
    # PowerShellVersion = ''

    # Name of the PowerShell host required by this module
    # PowerShellHostName = ''

    # Minimum version of the PowerShell host required by this module
    # PowerShellHostVersion = ''

    # Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
    # DotNetFrameworkVersion = ''

    # Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
    # ClrVersion = ''

    # Processor architecture (None, X86, Amd64) required by this module
    # ProcessorArchitecture = ''

    # Modules that must be imported into the global environment prior to importing this module
    # RequiredModules = @()

    # Assemblies that must be loaded prior to importing this module
    # RequiredAssemblies = @()

    # Script files (.ps1) that are run in the caller's environment prior to importing this module.
    # ScriptsToProcess = @()

    # Type files (.ps1xml) to be loaded when importing this module
    # TypesToProcess = @()

    # Format files (.ps1xml) to be loaded when importing this module
    # FormatsToProcess = @()

    # Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
    # NestedModules = @()

    # Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
    FunctionsToExport    = @()

    # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
    CmdletsToExport      = @()

    # Variables to export from this module
    VariablesToExport    = '*'

    # Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
    AliasesToExport      = @()

    # DSC resources to export from this module
    # DscResourcesToExport = @()

    # List of all modules packaged with this module
    # ModuleList = @()

    # List of all files packaged with this module
    # FileList = @()

    # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
    PrivateData          = @{

        PSData = @{

            # Tags applied to this module. These help with module discovery in online galleries.
            Tags       = @('CARML')

            # A URL to the license for this module.
            # LicenseUri = ''

            # A URL to the main website for this project.
            ProjectUri = 'https://aka.ms/CARML'

            # A URL to an icon representing this module.
            # IconUri = ''

            # ReleaseNotes of this module
            # ReleaseNotes = ''

            # Prerelease string of this module
            # Prerelease = ''

            # Flag to indicate whether the module requires explicit user acceptance for install/update/save
            # RequireLicenseAcceptance = $false

            # External dependent modules of this module
            # ExternalModuleDependencies = @()

        } # End of PSData hashtable

    } # End of PrivateData hashtable

    # HelpInfo URI of this module
    # HelpInfoURI = ''

    # Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
    DefaultCommandPrefix = 'Carml'

}

moduleName.psm1
[cmdletbinding()]
param()

# Load central config file; Config File can be referenced within module scope by $script:CONFIG
Write-Verbose 'Load Config'
$moduleConfigPath = Join-Path $PSScriptRoot 'ModuleConfig.psd1'
$script:CONFIG = Import-PowerShellDataFile -Path (Resolve-Path ($moduleConfigPath))

$script:repoRoot = (Get-Item $PSScriptRoot).Parent.Parent.Parent
$script:moduleRoot = $PSScriptRoot
$script:src = Join-Path $PSScriptRoot 'src'
$script:temp = Join-Path $PSScriptRoot 'temp'

Write-Verbose 'Import everything in sub folders public & private'
$functionFolders = @('public', 'private')
foreach ($folder in $functionFolders) {
    $folderPath = Join-Path -Path $PSScriptRoot -ChildPath $folder
    If (Test-Path -Path $folderPath) {
        Write-Verbose "Importing from $folder"
        $functions = Get-ChildItem -Path $folderPath -Filter '*.ps1' -Recurse
        foreach ($function in $functions) {
            Write-Verbose ('  Importing [{0}]' -f $function.BaseName)
            . $function.FullName
        }
    }
}
$publicFunctions = (Get-ChildItem -Path "$PSScriptRoot\public" -Filter '*.ps1').BaseName
Export-ModuleMember -Function $publicFunctions

ModuleConfig.psd1
@{
    #region general
    ...
    #endregion
}

readme.md

With that, we could remove 'inner/helper' functions from the scripts and move them instead as private functions into the 'private' folder.
We'd further need to adjust the current loading of the functions in the pipeline and replace it with the import of the Module.
This is implemented in an iterative approach with the following PRs:

[ ] #2181

Should dicusss the PR some time and make a plan to get this done as quick as possible

Update: should these efforts be put in C# redevelopment?

I can, if you agree, start with the other ones over

Un-assigned myself as we need to start over anyways and given the previous attept I don't think this will be something we merge any time soon


Update README.md

Not sure this matches my understanding of webrtc. Afaik there are three parameters controlling the behaviour of a channel, one sets ordering, one the maximum number of retransmission attempts and another the maximum retransmission duration (not used in matchbox). The first of these maps directly to ordered or unordered whilst the second if unset provides a reliable channel and if set provides an unreliable channel with N retransmission attempts

In the README it checked Reliable and Unreliable channels as both Ordered and Unordered?
That's what I was fixing. That didn't make much sense to me.
It was my impression that the reliable channel does ordering and unlimited retransmits, and the unreliable channel did not enforce either.

Ah, that explains it, I had intended the table to outline the capabilities of matchbox, not describe the behaviour of our utility configurations
Probably need to think a bit more carefully about their names

Maybe we should just write it in text and/or explain it in detail further down the readme and link to the channelconfig api docs?

Yeah, possibly. I just want to make sure people are made aware of the capabilities at a glance. I - wouldn't expect someone to dive too deep when choosing a library

Something like:

Matchbox supports unreliable and reliable data channels, with configurable number of package retransmits and ordering guarantees.

?


on unix shake can only work with ascii or utf8 filenames

From the master branch of shake
 fileNameToString :: FileName -> FilePath
 fileNameToString = UTF8.toString . fileNameToByteString

 fileNameToByteString :: FileName -> BS.ByteString
 fileNameToByteString (FileName x) = x

 fileNameFromString :: FilePath -> FileName
 fileNameFromString = fileNameFromByteString . UTF8.fromString

 fileNameFromByteString :: BS.ByteString -> FileName
 fileNameFromByteString = FileName . filepathNormalise

on unix fileNameToByteString is used to convert the filename to a bytestring to be used with
getFileStatus and therefore only utf8 or ascii will work here, as the filenames are encoded as utf-8 internally.
That's not problem at all for me personally, but maybe it would be nice to advertise as such on the homepage or in the docs somewhere.

Discussion taking place in #681 (TLDR: I don't understand enough to know what I don't know even)


developers developers developers

as a heads up developmentEnvironmentUserName = "Developer" sets your username to "Developer". The quotes are unneeded. you need to do op "Developer" if you happen to run it as a server 😛

see https://discord.com/channels/181078474394566657/914843380805152789/922925061680300073

Already did that the second I read it in Discord. But thanks!


docker logs pipe shows empty file

Hello, I don't know if this is an issue of coreos or docker in coreos. Others distros works fine.
Using docker logs <container> >> file.log shows log in stdout but the file.log is empty.


Update thanos/kube/manifests/ files according to the thanos  latest v0.2.0

Thanos, Prometheus and Golang version used

What happened
What you expected to happen
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components

Anything else we need to know

Sorry, I didn't find the time but thanks to @ervikrant06 it is in progress now
https://github.com/improbable-eng/thanos/pull/709

Still we can add either configmap or passing this by content, which I like more! (:
        - |
          --objstore.config=type: GCS
          config:
            bucket: <bucket>


Fix typo

Fix typo at docs/rest-api.md

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Security vulnerabilities in go1.20.8 and go-restful

Describe the bug
A security vulnerability has been identified in the Kube-vip 0.6.3.
go1.20.18:  critical CVE-2023-39323
go-restful/v3 3.9.0 CVE
This vulnerability poses a potential threat to the security and stability of the kube-vip.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS/Distro: [e.g. Ubuntu 1804]
Kubernetes Version: [e.g. v.1.18]
Kube-vip Version: [e.g. 0.2.3]

Kube-vip.yaml:
If Possible add in your kube-vip manifest (please remove anything that is confidential)
Additional context
Add any other context about the problem here.

This has been merged.


Migrate all remaining TFVM codex into AVM spec

Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
As part of this Pull Request I have

[ ] Read the Contribution Guide and ensured this PR is compliant with the guide
[ ] Checked for duplicate Pull Requests
[ ] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
[ ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Ensured PR tests are passing
[ ] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@lonegunmanb please see review comments


[BUG] SeedFarmer looses history of modules when redeploying

When removing a module from a manifest of an existing deployment, I lose the history of the other modules deployed

This was assessed and the deployment manifest was not correctly being persisted to SSM upon subsequent deployments.  This does not impact any deployed modules, but interferes with destroying modules.  Once the code is correctly, a simple seedfarmer apply will correct the issue going forward


[WIP] allow list impl

Fixes #174
Tests pass but integration into the TespServer does not seem to be making it work.

It is working. Just need to refine the actual rules, they are gathering pages we don't want.

Commit a203e7c is actually to support moving the logger start/stop events to use the SYSTEM group.


Building and deploying a Go API  on Okteto

Hi @Anitaachu, you're to send the code for your article as a pull request to this repo.
The images should be mailed to<EMAIL_ADDRESS>


Use Gradle Enterprise Gradle plugin RC repository

The Spring Maven repository configured the https://gradle.jfrog.io/gradle/libs repository in which we had the RC versions of the Gradle Enterprise Gradle plugin and the Gradle Enterprise Maven extension. This then showed up on mvnrepository.com as it indexes repo.spring.io.
I now already removed these RC versions from the https://gradle.jfrog.io/gradle/libs repository and we now need to add them explicitly to the Gradle build such that we can dogfood the RC versions.
This PR also updates the plugin version to 3.1.1 which is the current latest one.

@guylabs Are you sure you want to make the change on release?

@guylabs Are you sure you want to make the change on release?

Yes we'd like to integrate plugin version 3.2 that will be released on the same day as Gradle 6.3.


Link-local IPv6 resolvers fail

My resolv.conf:
# Generated by NetworkManager
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver fe80::1%enp0s20f0u1u1
# NOTE: the libc resolver may not support more than 3 nameservers.
# The nameservers listed below may not be recognized.
nameserver fd80::1e5f:2bff:fe92:95c9

Results in:
2018/03/01 15:15:32 [error] 28930#0: *9 [lua] responses.lua:121: after(): failed the initial dns/balancer resolve for 'mockbin.org' with: dns lookup pool exceeded retries (1): failed to create a resolver: failed to set peer name: failed to parse host name "[fe80::1%enp0s20f0u1u1]": invalid IPv6 address, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", host: "example.com"
Running version 1.0.0-1

The underlying open resty lib doesn't support zone indices, and neither does this library.
background info: https://en.wikipedia.org/wiki/IPv6_address#Scoped_literal_IPv6_addresses

The underlying open resty lib doesn't support zone indices, and neither does this library.

In that case, nameservers with a ipv6 scope should be skipped (rather than causing dns lookups to fail)

Yes that would for now probably be the best option


Add full-support for radial-gradients

Add full-support for radial-gradients as defined by w3c: https://w3c.github.io/csswg-drafts/css-images-3/#radial-gradients.
To do this, we will need to update the parser to support radial gradients. https://www.npmjs.com/package/gradient-parser.
The plan is to hard-fork the repo, combine it with the typescript definitions and add types and parsing based on the W3C spec.

Thanks Francois, I really like that idea it does seem a lot more reliable than arbitrary regexes. It would be nice to find something higher level that conforms to the CSS spec. Maybe the postcss world has something like that 🤔

Unfortunately I didn't find any project with higher level normalization.
Though TBH gradient-parser output isn't very far from the AST, except when it fails, which was pretty common in my tests:

color names not supported
diagonal orientations not supported (supposedly fixed but not released)
positions w/o unit (px is implicit) unsupported

I can maybe work on a PR to migrate if you're interested.

Yeah, that would be amazing @gluck,  maybe we can keep it in lib/gradientParser.ts and it can be it's own package later.
It would be a good place to start adding some automated tests.
I've done some tests in Jest for another Figma plugin I was working on, small gist here: https://gist.github.com/yagudaev/0c2b89674c6aee8b38cd379752ef58d0.
It can be simple and just parse pieces like the spec specifies: https://w3c.github.io/csswg-drafts/css-images-3/#gradients.
I don't have any experience working with ASTs so if you want to give it a shot that would be awesome.

first shot done in #16 , let me know if that's what you expected


CI: Add editor target to Android builds config

The configuration was updated to generate:

Godot Android Editor build
Godot Android template build for arm32
Godot Android template build for arm64

Thanks!


Fix PackageGraph traversal performance regressions

This restores the performance of traversal of deep package graphs previously available when ResolvedTarget, ResolvedProduct, and ResolvedPackage were reference types. Now instead of recursively applying Hashable and Equatable conformances to all properties in graph's node, we only hash and compare for equality their identities defined by Identifiable.
Uses of Set on these types are now replaced with the new IdentifiableSet type, which uses a dictionary of [Element.ID: Element] as its storage.
The main benefit of this approach is that build triple of ResolvedProduct and ResolvedTarget is now a part of their identity. Thus we can still use value types, while the same Target from PackageModel instantiated as two different ResolvedTargets with different BuildTriples will have different identities.
Resolves rdar://120861833
Resolves rdar://120711211

@swift-ci test

The actual fix is also verified by PackageGraphPerfTests, which with the regression takes minutes to complete, but now with the fix passes in seconds. Not sure though why the regression doesn't trigger baseline checks on CI, maybe this test is somehow skipped? I previously did see it catching a more severe performance regression on CI, but only once. 🤔

Currently blocked due to https://github.com/apple/swift-package-manager/pull/7249

@swift-ci test

@swift-ci test

https://github.com/apple/sourcekit-lsp/pull/1025
@swift-ci test

https://github.com/apple/sourcekit-lsp/pull/1025
@swift-ci test windows


Using cec-modules with sapm

As I understand it, it is not possible to use the pvlib.pvsystem.sapm function with the cec-modules-library.
Is this right?
If it is right, is it possible to write a hint somewhere in the documentation.
http://pvlib-python.readthedocs.org/en/latest/pvlib.html#pvlib.pvsystem.sapm

The CEC library doesn’t contain the parameters that are needed for the SAPM.  It only has parameters for the CEC performance model.
NREL might (I’m not sure) have added functionality to translate from CEC model parameters to SAPM parameters.  I know PVsyst has done this, but the translation is suspect in my opinion.  It works by computing modeled IV curves (using the PVsyst model), picking off Isc, Vmp/Imp and Voc, then fitting the SAPM equations to these modeled points.  So you get a SAPM model which emulates the PVsyst model including any biases, rather than measured performance.
Cliff
From: ukrien<EMAIL_ADDRESS>Sent: Wednesday, February 17, 2016 7:15 AM
To: pvlib/pvlib-python
Subject: [EXTERNAL] [pvlib-python] Using cec-modules with sapm (#122)
As I understand it, it is not possible to use the pvlib.pvsystem.sapm function with the cec-modules-library.
Is this right?
If it is right, is it possible to write a hint somewhere in the documentation.
http://pvlib-python.readthedocs.org/en/latest/pvlib.html#pvlib.pvsystem.sapm
—
Reply to this email directly or view it on GitHubhttps://github.com/pvlib/pvlib-python/issues/122.

Sure, let's add a hint to the documentation. Feel free to make a PR, otherwise I'll get to it sometime in the next few weeks.

See PR #123.

Closed by #123


Add skip and limit to git.GetTags

just make GetTags api similar to GetBranches ... wip because functions exec this func do not make usage of this feature jet

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@cd78c30). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #16897   +/-   ##
=======================================
  Coverage        ?   45.15%
=======================================
  Files           ?      765
  Lines           ?    86300
  Branches        ?        0
=======================================
  Hits            ?    38972
  Misses          ?    41019
  Partials        ?     6309

Impacted Files
Coverage Δ

modules/context/repo.go
52.99% <100.00%> (ø)

modules/git/repo_tag_nogogit.go
100.00% <100.00%> (ø)

modules/repository/repo.go
47.32% <100.00%> (ø)

routers/web/repo/compare.go
42.22% <100.00%> (ø)

routers/web/repo/release.go
26.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd78c30...ee1d856. Read the comment docs.


DOC: Improve descriptions of new confounds model

Include revisions suggested in #1586 regarding documentation of that PR.

@rciric please remember to call this branch docs/<whatever> so that we don't waste CircleCI cycles.


Ethereum contract example

Firstly thanks for this awesome repo, its better than sliced bread
Were you able to get the store contract to work?
I connected to a local ganache-cli chain and deployed the store contract to it.
I cannot see something clearly wrong?
I call the store function like this

And then I get back

The call works fine through remix

Any advice would be appreciated.

My first thought is that perhaps the wallet is unpacking the transaction incorrectly and causing you issue.
Are you using MetaMask? It looks like you are. I have had issues with them not including required fields in the JsonRpcError object. I'll make the code nullable to resolve this issue, but technically that shouldn't be possible according to the JSON RPC spec.

Hi Sterling,
Thanks for the quick responses! 😁
Yes I am using metamask, I will keep on investigating to see if I can get it working somehow.
I wish I could see the index.android.bundle to see what is going on in line 3652.
But it just errors on metamask's side and then the message gets sent back saying it failed, so this is a hard one to solve.

The newest version of the library should let you see the error being returned from metamask (Even with a null message).

I have created a custom contract call here: https://github.com/WalletConnect/Web3ModalFlutter/blob/2981053456ecd3511ca2e3a7f0def7c75e22af62/example/sign/lib/utils/crypto/eip155.dart#L197
Please mimic it for other SC calls.

Hi Luzzotica,
Thank you for all the effort, I appreciate it.
I tried with the latest metamask version.  And it seems like it cannot find the return value balance?

Everything in the code looks fine to me, what wallet did you use while testing?
Also the transaction gets automatically rejected which is strange as well...


task 2 tan(x) function

How did you guys solve the issue of getting the solution for 90, 270, -90, -270, etc. degrees for the solution of tan(x) function. This solution is not right. How you are dealing with it?

Please wait for the assigned person in the group for this task

You can also have an eye on the repository if he adds the file you can check.


Ability to save each loop

This is a feature request rather than a bug, would it be possible to save each loop in future versions?

Unless I broke something in my last update the looper actually does save each loop to the samples_ouput directory.. for most people that's the /outputs/img2img folder.  I'll check it this weekend while I'm looking into the other issue posted.

I double-checked and it is still saving all the images in the /outputs/img2img folder.  That said, I have plans to add all those images to the final image preview so that you can more easily see the differences and select the one you want from the interface as opposed to having to pull them from a folder.

I'd definitely love this as well. Sometimes I'll set a really high denoise to see what happens and catch a really cool result before it's replaced by something else. I don't have autosave enabled since I like to pick and choose the images I keep, so being able to see the loops in the final preview would be really helpful.

Thank you for the answer, I didn't realised it was saving. At least we hame something till we can see them in the preview.


Generalize assignment LHS handling

Assignment LHS was handled specially both in the semantic pass and in later compiler stages. This was  bad design which was largely unnecessary with the current compiler structure. This PR removes all traces of this special handling and makes it so that assignments are handled mostly like all other expressions.
Part of work on #419.

@bkutil

+1


normaliz is overlinking

see latest CI output, it should not link against e-antic's dependencies. Or rather only the ones that are used in the renfxx header.

@isuruf: Do we need to fix this here or should this just go into upstream eventually?


Appveyor ci 32bit windows

Also fix some 32bit code issues
Note! Model validation disabled due to strange nummerical difference in bouncing ball model on 32bit MinGW
Update to zeromq 4.2.5 due to CMake build system problems with MinGW32

Note! This PR requires a git submodule sync, due to changed zeromq repository


supportsSingleSignOn removed when importing application

Steps to reproduce
Create a sample application using Teams Toolkit with the following parameters:

message extension
api based
entra authentication

This will create a manifest file with the following node:
"authorization": {
                "authType": "microsoftEntra",
                "microsoftEntraConfiguration": {
                    "supportsSingleSignOn": true
                }
            }

Provision the resources for the application.
Import the application to Teams.
Expected behavior
After the application is deployed to teams we should see the authorization node in the manifest and the application should authenticate to the Azure Function using Entra.
Actual behavior
In the "imported" manifest the authorization node looks like this:
"authorization": {
"authType": "microsoftEntra"
},
When you try to preview the application you will get an validation message saying: Api based compose extension with microsoftEntra authType have no microsoftEntraConfiguration defined. Api based compose extension with microsoftEntra authType does not set supportsSingleSignOn to true.
Error details
No response

Hi @ksdaniel - Thanks for raising the query.
We will look into it and let you know the updates.


Update API version on base_uri variable

API v0.0 does not exist anymore.
Update to v0.1.

hey thanks for the update; the only reason i haven't moved the API version forward is the response back when creating a done is a little different with v0.1.  the v0.0 support won't be removed for a very very long time, so I'm going to leave it at v0.0 until i have better customer alfred messages coming back based on the api response.


hetrogenous peon configurations

currently the only way to configure memory (heap and direct) for a peon is in a singular location in the config file.
This assumes every datasource is equal, which is never the case in real life.
Currently due to this, all peons have to take up as much resources as the biggest data source.
There should be a way to configure jvm params for every peon individually.
For KIS, this could be achieved by allowing to submitting peon config along with supervisor config.

What do you mean by the biggest dataSource? I wonder why peons should have different resource requirements depending on dataSource. All peons essentially do similar things: reading data, keeping them in memory for a while, persisting segments to local storage, and publishing segments.

here is an example, say a datasource A produces 1gb per hour and gets 10K queries a minute. another datasource B produces 10MB an hour and get  20 request a minute.
You want to allocate 10 workerThreads to A and 1 to B. Due to this allocation of threads, you would need to specify the -XX:directmemorysize of the jvm for A. Since -XX:directmemorysize can only be specified in config.properties, it gets applied to B too, which is not what you want.

Ah yes, it depends on not the dataSource size, but query workloads.

Not really. they respond to queries from broker too. The rate of querying and size of data matter as far as allocating resources go.

I don't think this is a good idea. In realtime indexing (including Kafka indexing service), tasks are not designed to support all incoming queries all alone. Instead, you should set replicas which serve the almost same data, so that queries are disseminated into different peons. Actually, I wonder how large the performance impact of querying realtime data is. I think it wouldn't be so large unless you're querying on only realtime data which is totally not an appropriate use case for Druid.
This kind of heterogeneous configuration makes Druid's resource management much complicated, but its benefit looks very small.

I think it wouldn't be so large unless you're querying on only realtime data which is totally not an appropriate use case for Druid.

this is a very normal use case. for example for performance monitoring you are typically firing alerts on last 1-5 mins of data which is always in realtime nodes. and for firing alerts, you need to do tons of queries on realtime data every single minute.

How many queries exactly do you submit?

Instead, you should set replicas which serve the almost same data, so that queries are disseminated into different peons.

this should still have the problem of 1 large datasource requiring settting up tons of tiny replicas which can be wasteful and tough to manage, compared to simply specifying a jvm parameter in the supervisor config

How many queries exactly do you submit?

thousands. the exact number is irrelevant here. the concept of hetroginty is what is relevant

This kind of heterogeneous configuration makes Druid's resource management much complicated, but its benefit looks very small.

how is adding 1 extra field in supervisor spec to specify jvm parameter going to complicate druid which already has hundreds of switches.
setting up tons and tons of replica machines is far more complicated than an extra switch

you already allow setting number of worker threads in supervisor spec. since direct memory is allocated proportional to worker threads, you are exposing half configuration which will inevitably result in crashes.
if you have worker thread config, you must allow setting direct memory too

i think you can just add 1 extra field to supervisor spec:
memoryPerWorkerThread
The peon will use this field along with the workerThreads param to set the -XX:directMemorySize parameter of the peons.
This way you are properly exposing workerThreads param in a way that wouldnt crash the peon and allows users to have hetrogenous peons

The exact number matters. I would say thousands of queries shouldn't have performance impact. Let's say a single query takes 10 ms (the number came from one of our customers). If you have 10,000 queries to execute in 1 min, you need to execute about 1.7 queries per sec which can be easily handled.

this should still have the problem of 1 large datasource requiring settting up tons of tiny replicas which can be wasteful and tough to manage, compared to simply specifying a jvm parameter in the supervisor config

Why is it wasteful? The only thing you need to do is to set the number of replicas in your supervisorSpec.
Allowing heterogeneous resource configurations for peon does make Druid's resource management complicated. It causes new issues like how to allocate tasks to MMs to maximize the resource utilization.

you already allow setting number of worker threads in supervisor spec. since direct memory is allocated proportional to worker threads, you are exposing half configuration which will inevitably result in crashes.

Do you mean workerThreads here? As documented, it's The number of threads that will be used by the supervisor for asynchronous operations, not the number of query processing threads.

If you want to give tasks different configurations based on datasource, you could deploy middle managers with different worker configurations and direct tasks to specific middle managers based on datasource using affinity configs: http://druid.io/docs/latest/configuration/index.html#overlord-dynamic-configuration

If you have 10,000 queries to execute in 1 min, you need to execute about
1.7 queries per sec

1.7 queries per second * 60 = 102 queries per minute
to execute 10K queries per minute requires 166 queries per second!
On Mon, Aug 13, 2018 at 6:27 PM Jonathan Wei<EMAIL_ADDRESS>wrote:

If you want to give tasks different configurations based on datasource,
you could deploy middle managers with different worker configurations and
direct tasks to specific middle managers based on datasource using affinity
configs:
http://druid.io/docs/latest/configuration/index.html#overlord-dynamic-configuration
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-druid/issues/6171#issuecomment-412722003,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADCtoOEABdtzizPPXNW60cdDbT3nzdABks5uQid0gaJpZM4V7jGw
.

--
Prashant

IMO the worker affinity approach is a reasonable way to go. An alternative is to use the "taskResource" object to configure how many slots a task takes. You can make a task take 2, 3, or more slots by doing:
"taskResource" : {
  "requiredCapacity" : 2
}

It is not a very commonly used feature, but it can make it easier to support heterogenous task sizing. To keep the scheduler simple, we only support slot multiples, not customization of the exact amount of CPU and memory requested.

1.7 queries per second * 60 = 102 queries per minute.
to execute 10K queries per minute requires 166 queries per second!

@pdeva ok, my previous comment was wrong. To execute 10K queries per min, each query should take at most 6 ms if all they are run in sequential. But, Druid is capable of running queries in parallel, so this shouldn't be a problem. And this is why I said the number of queries matters. How many queries are you running? 10K queries per minute?
@jon-wei good point. I forgot the affinity configuration. That would address this issue.
@gianm thanks for the comment but not sure about taskResource. AFAIK, processing threads are used for query processing in peons. Does taskResource affect to the processing configuration too? Or, does it have an effect that a MM is allocated less tasks, so that each task can use more processing threads?

the documentation for affinity config reference 'workers' not 'supervisors', so can it be used with KIS?

@pdeva yes, the supervisor runs on the overlord itself, the tasks created by the supervisor would be assigned based on the affinity configs

@himanshug thanks, good to know. I'm closing this.

@gianm thanks for the comment but not sure about taskResource. AFAIK, processing threads are used for query processing in peons. Does taskResource affect to the processing configuration too? Or, does it have an effect that a MM is allocated less tasks, so that each task can use more processing threads?

@gianm could you clarify this please


Added Get-ArubaCLTokenStatus allowing an easy call to determine if a …

Added Get-ArubaCLTokenStatus allowing an easy call to determine if a new token/login is needed. This is needed because the refresh token logic is store within the native functions.

Ok.. when do you need this ? Because refresh_token is more longer valid and you get a new token…

My issue is that I'm making several REST calls. I don't want to refresh the token every time I make the call. I could also call $DefaultArubaCLConnection directly, but I wanted a clean function.

For US-4 can you make a another PR ?

My issue is that I'm making several REST calls. I don't want to refresh the token every time I make the call. I could also call $DefaultArubaCLConnection directly, but I wanted a clean function.

there is already update of token with Invoke-ArubaCLRestMethod (and only when token lifetime is less of 15 minutes or there is a bug if renew of each request…)

I'm using your module within my module. So, I don't want to call Connect-ArubaCL if it is not needed and there is already a good token. Currently, if I call Invoke-ArubaCLRestMethod it just throws an error if I'm not connected. It is cleaner, to me, to handle it with a function.
Maybe the better route is to check for an existing token within the function Connect-ArubaCL.

but you already need $DefaultArubaCLConnection (or the same type of variable) for use other cmdlet ?
Thanks for other PR, do you plan to make some other change ? (to known if i push a new minor release with your 2 patch)

I do not plan on making a lot of changes, I'm just adding things that I need as I work with your module.
Are you going to merge this PR first? Or, do I need to setup a new branch for US-4 support and do another PR?

I do not plan on making a lot of changes, I'm just adding things that I need as I work with your module.
Are you going to merge this PR first? Or, do I need to setup a new branch for US-4 support and do another PR?
Please make a new branch
i will make some minor change before merge


Create PO Version

This story doesn't fit the needs of the rest api client, as it has a single submit_batches endpoint and not separate methods for each smart contract action


Remove task

Abstract
Remove function for task removal.

Task MUST NOT be removed when it is in WORKING state.
Task in History MUST be removed when function is called
completed Task which is synced SHOULD be removed from sync file.

https://github.com/dovigod/oh-my-task/pull/33


now the default ROOTDIR is /osjs

setting the new default ROOTDIR to /osjs to ease the deployment of the package

But what about the build scripts ? Those were changed as well, yes ? Can you include them ? :)

I have just added a "package" function to build tarball will be using for the final IPK