[wip] Print JSON status of preflight checks

Fixes #2935
This is based on the initial changes done by @cfergeau at https://github.com/cfergeau/crc/commit/447677bd37c6c2ecf3c0055a799cbc7b86f005a8
## o/p of `crc setup`
PS C:\Users\anath\redhat\crc> crc setup --json-stream 2> txt
{
  "type": "check",
  "description": "Checking if current user is in Hyper-V Admins group",
  "result": "passed",
  "error": null
}
{
  "type": "check",
  "description": "Checking if CRC bundle is extracted in '$HOME/.crc'",
  "result": "failed",
  "error": {}
}
{
  "totalBytes": 650263232,
  "completedBytes": 255386044
}
{
  "totalBytes": 650263232,
  "completedBytes": 257664726
}
{
  "totalBytes": 650263232,
  "completedBytes": 260318934
}

Please ignore the CI failure for now, is related to gofmt since am on windows these tools don't work properly

Steps need to be identified by a number, especially a list of all these steps by name.
Else it is hard to relate what the deltas are for.

Steps need to be identified by a number, especially a list of all these steps by name. Else it is hard to relate what the deltas are for.

right now for every check/step this is the information that we get, you want an id to be included here that increments for step, what else should be included here?
{
  "type": "check",
  "description": "Checking if current user is in Hyper-V Admins group",
  "result": "passed",
  "error": null
}

for the download, we get the total size and the currently downloaded size, which can be used for the progress bar on the tray.
can you provide example of what should be the JSON o/p for crc setup --json-stream be?

something like:
{
  "total": 20
},
{
  "id": 14.
  "type": "check",
  "description": "Checking if current user is in Hyper-V Admins group",
  "result": "passed",
  "error": null
}
{
  "id": 15,
  "type": "task",
  "description": "Downloading bundle",
},
{
  "belongto": 15,
  "totalBytes": 650263232,
  "completedBytes": 255386044
}

@gbraad this is the updated o/p, not yet able to relate the download stats with the preflight check id, also in the code fix is part of the check struct, so even though the id is incremented, (since it only exists in the json printing part) the total key shows the no. of Check{} s
PS C:\Users\anath\redhat\crc> crc setup --check-only --json-stream 2> txt
{
  "total": 2
}
{
  "id": 1,
  "type": "check",
  "description": "Checking if current user is in Hyper-V Admins group",
  "result": "passed",
  "error": null
}
{
  "id": 2,
  "type": "check",
  "description": "Checking if CRC bundle is extracted in '$HOME/.crc'",
  "result": "failed",
  "error": {}
}

PS C:\Users\anath\redhat\crc> crc setup --json-stream 2> txt
{
  "total": 2
}
{
  "id": 1,
  "type": "check",
  "description": "Checking if current user is in Hyper-V Admins group",
  "result": "passed",
  "error": null
}
{
  "id": 2,
  "type": "check",
  "description": "Checking if CRC bundle is extracted in '$HOME/.crc'",
  "result": "failed",
  "error": {}
}
{
  "id": 3,
  "type": "fix",
  "description": "Getting bundle for the CRC executable",
  "result": "",
  "error": null
}
{
  "filename": "C:\\Users\\anath\\.crc\\cache\\crc_podman_hyperv_3.4.4.crcbundle",
  "totalBytes": 650263232,
  "completedBytes": 446963712
}

Changing this to be newline delimited and add more information to the actual download message:
{
  "total": 26
}
{"id":1,"type":"check","description":"Checking if running as non-root","result":"passed","error":null}
{"id":2,"type":"check","description":"Checking if running inside WSL2","result":"passed","error":null}
{"id":3,"type":"check","description":"Checking if crc-admin-helper executable is cached","result":"passed","error":null}
{"id":4,"type":"check","description":"Checking for obsolete admin-helper executable","result":"passed","error":null}
{"id":5,"type":"check","description":"Checking if running on a supported CPU architecture","result":"passed","error":null}
{"id":6,"type":"check","description":"Checking minimum RAM requirements","result":"passed","error":null}
{"id":7,"type":"check","description":"Checking if crc executable symlink exists","result":"passed","error":null}
{"id":8,"type":"check","description":"Checking if Virtualization is enabled","result":"passed","error":null}
{"id":9,"type":"check","description":"Checking if KVM is enabled","result":"passed","error":null}
{"id":10,"type":"check","description":"Checking if libvirt is installed","result":"passed","error":null}
{"id":11,"type":"check","description":"Checking if user is part of libvirt group","result":"passed","error":null}
{"id":12,"type":"check","description":"Checking if active user/process is currently part of the libvirt group","result":"passed","error":null}
{"id":13,"type":"check","description":"Checking if libvirt daemon is running","result":"passed","error":null}
{"id":14,"type":"check","description":"Checking if a supported libvirt version is installed","result":"passed","error":null}
{"id":15,"type":"check","description":"Checking if crc-driver-libvirt is installed","result":"passed","error":null}
{"id":16,"type":"check","description":"Checking crc daemon systemd service","result":"passed","error":null}
{"id":17,"type":"check","description":"Checking crc daemon systemd socket units","result":"passed","error":null}
{"id":18,"type":"check","description":"Checking if systemd-networkd is running","result":"passed","error":null}
{"id":19,"type":"check","description":"Checking if NetworkManager is installed","result":"passed","error":null}
{"id":20,"type":"check","description":"Checking if NetworkManager service is running","result":"passed","error":null}
{"id":21,"type":"check","description":"Checking if dnsmasq configurations file exist for NetworkManager","result":"passed","error":null}
{"id":22,"type":"check","description":"Checking if the systemd-resolved service is running","result":"passed","error":null}
{"id":23,"type":"check","description":"Checking if /etc/NetworkManager/dispatcher.d/99-crc.sh exists","result":"passed","error":null}
{"id":24,"type":"check","description":"Checking if libvirt 'crc' network is available","result":"passed","error":null}
{"id":25,"type":"check","description":"Checking if libvirt 'crc' network is active","result":"passed","error":null}
{"id":26,"type":"check","description":"Checking if CRC bundle is extracted in '$HOME/.crc'","result":"failed","error":{}}
{"type":"download","filename":"/home/gbraad/.crc/cache/crc_podman_libvirt_3.4.4.crcbundle","totalBytes":649600569,"completedBytes":7437096}
{"type":"download","filename":"/home/gbraad/.crc/cache/crc_podman_libvirt_3.4.4.crcbundle","totalBytes":649600569,"completedBytes":33323816}
{"type":"download","filename":"/home/gbraad/.crc/cache/crc_podman_libvirt_3.4.4.crcbundle","totalBytes":649600569,"completedBytes":58620712}
{"type":"download","filename":"/home/gbraad/.crc/cache/crc_podman_libvirt_3.4.4.crcbundle","totalBytes":649600569,"completedBytes":84769576}

Ideally this needs the step streamed BEFORE the result is known, and followed by the actual state is finished (passed/failed)


Single Ubuntu node problem with docker repository

I try to configured single node.
master node: Ubuntu 17.10
administration node:
Linux Mint 18.2 Sonya
Python 2.7.12
ansible 2.5.0
W:Skipping acquire of configured file 'stable/binary-i386/Packages' as repository 'https://download.docker.com/linux/ubuntu artful InRelease' doesn't support architecture 'i386',
Why i386 ? Master node and administration node are x64!
How to solve this problem?
TASK [docker : ensure docker-engine repository is enabled] **********************************************************************************************************************************************************************
task path: /home/ivan/kubespray/roles/docker/tasks/main.yml:77

failed: [k8s-m1.me] (item=deb https://apt.dockerproject.org/repo ubuntu-artful main
) => {
    "changed": false,
    "failed": true,
    "item": "deb https://apt.dockerproject.org/repo ubuntu-artful main\n",
    "module_stderr": "OpenSSH_7.2p2 Ubuntu-4ubuntu2.4, OpenSSL 1.0.2g  1 Mar 2016\r\ndebug1: Reading configuration data /home/ivan/.ssh/config\r\ndebug1: Reading configuration data /etc/ssh/ssh_config\r\ndebug1: /etc/ssh/ssh_config line 19: Applying options for *\r\ndebug1: auto-mux: Trying existing master\r\ndebug2: fd 3 setting O_NONBLOCK\r\ndebug2: mux_client_hello_exchange: master version 4\r\ndebug3: mux_client_forwards: request forwardings: 0 local, 0 remote\r\ndebug3: mux_client_request_session: entering\r\ndebug3: mux_client_request_alive: entering\r\ndebug3: mux_client_request_alive: done pid = 4191\r\ndebug3: mux_client_request_session: session request sent\r\ndebug1: mux_client_request_session: master session id: 2\r\nTraceback (most recent call last):\n  File \"/tmp/ansible_sa4tEe/ansible_module_apt_repository.py\", line 556, in <module>\n    main()\n  File \"/tmp/ansible_sa4tEe/ansible_module_apt_repository.py\", line 544, in main\n    cache.update()\n  File \"/usr/lib/python2.7/dist-packages/apt/cache.py\", line 464, in update\n    raise FetchFailedException(e)\napt.cache.FetchFailedException: W:Skipping acquire of configured file 'stable/binary-i386/Packages' as repository 'https://download.docker.com/linux/ubuntu artful InRelease' doesn't support architecture 'i386', E:Failed to fetch https://apt.dockerproject.org/repo/dists/ubuntu-artful/InRelease  403  Forbidden, E:Some index files failed to download. They have been ignored, or old ones used instead.\ndebug3: mux_client_read_packet: read header failed: Broken pipe\r\ndebug2: Received exit status from master 1\r\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE",
    "rc": 1
}

root@k8s-m1:~# uname -a
Linux k8s-m1.me 4.13.0-21-generic #24-Ubuntu SMP Mon Dec 18 17:29:16 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

@woopstar, I apply PR #2730, changed files:
roles/docker/tasks/main.yml
roles/kubespray-defaults/defaults/main.yaml
set dockerproject_repo_enabled: false in last file and ansible-playbook went to deeper. But I see other error:
TASK [docker : ensure docker packages are installed] ****************************************************************************************************************************************************************************
task path: /home/ivan/kubespray/roles/docker/tasks/main.yml:111
Tuesday 15 May 2018  13:50:31 +0300 (0:00:00.046)       0:00:29.247 ***********

......
failed: [k8s-m1.me] (item={u'force': True, u'name': u'docker-ce=17.03.2~ce-0~ubuntu-artful'}) => {
    "attempts": 4,
    "cache_update_time":<PHONE_NUMBER>,
    "cache_updated": false,
    "changed": false,
    "failed": true,
    "invocation": {
        "module_args": {
            "allow_unauthenticated": false,
            "autoclean": false,
            "autoremove": false,
            "cache_valid_time": 0,
            "deb": null,
            "default_release": null,
            "dpkg_options": "force-confdef,force-confold",
            "force": true,
            "force_apt_get": false,
            "install_recommends": null,
            "only_upgrade": false,
            "package": [
                "docker-ce=17.03.2~ce-0~ubuntu-artful"
            ],
            "pkg": "docker-ce=17.03.2~ce-0~ubuntu-artful",
            "purge": false,
            "state": "present",
            "update_cache": null,
            "upgrade": null
        }
    },
    "item": {
        "force": true,
        "name": "docker-ce=17.03.2~ce-0~ubuntu-artful"
    },
    "msg": "'/usr/bin/apt-get -y -o \"Dpkg::Options::=--force-confdef\" -o \"Dpkg::Options::=--force-confold\"  --force-yes   install 'docker-ce=17.03.2~ce-0~ubuntu-artful'' failed: W: --force-yes is deprecated, use one of the options starting with --allow instead.\nE: Version '17.03.2~ce-0~ubuntu-artful' for 'docker-ce' was not found\n",
    "rc": 100,
    "stderr": "W: --force-yes is deprecated, use one of the options starting with --allow instead.\nE: Version '17.03.2~ce-0~ubuntu-artful' for 'docker-ce' was not found\n",
    "stderr_lines": [
        "W: --force-yes is deprecated, use one of the options starting with --allow instead.",
        "E: Version '17.03.2~ce-0~ubuntu-artful' for 'docker-ce' was not found"
    ],
    "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\n",
    "stdout_lines": [
        "Reading package lists...",
        "Building dependency tree...",
        "Reading state information..."
    ]
}

May be I should to use other OS? Will be better?

@woopstar How I can right call again ansible-book cluster.yml?

About error:
Version '17.03.2~ce-0~ubuntu-artful' for 'docker-ce' was not found"
root@k8s-m1:/# apt-cache madison docker-ce
 docker-ce | 18.03.1~ce-0~ubuntu | https://download.docker.com/linux/ubuntu artful/stable amd64 Packages
 docker-ce | 18.03.0~ce-0~ubuntu | https://download.docker.com/linux/ubuntu artful/stable amd64 Packages
 docker-ce | 17.12.1~ce-0~ubuntu | https://download.docker.com/linux/ubuntu artful/stable amd64 Packages
 docker-ce | 17.12.0~ce-0~ubuntu | https://download.docker.com/linux/ubuntu artful/stable amd64 Packages

Fixed it:
/roles/docker/vars/ubuntu.yml
...
docker_versioned_pkg:
  'latest': docker-ce
...
  'edge': docker-ce=17.12.1~ce-0~ubuntu

/roles/docker/defaults/main.yml
...
docker_version: 'edge'
docker_selinux_version: 'edge'

And playbook finished!


Adding a step-by-step guide to provision secure workspace

[Enhancement] How about adding a step-by-step guide to provision secure workspace?
https://github.com/jhirono/amlsecurity

@shohei1029  Thank you for your contribution ! Let me check this. Sorry for late reply.


[Do not merge] Change Reify.asIterable to GBK in BigQueryIO File loads

test only
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Instruction to patch
To compile, need java11 and git in your bash.
Checkout the project:

git clone https://github.com/apache/beam.git --depth=1

cd beam

git fetch origin pull/33284/head:pr-33284

git switch pr-33284

git log # confirm current branch is on this patch

./gradlew -Ppublishing -p sdks/java/io/google-cloud-platform publishToMavenLocal

# check the jar published into your maven local repo

ls -l ~/.m2/repository/org/apache/beam/beam-sdks-java-io-google-cloud-platform/2.61.0-SNAPSHOT/

# -rw-r--r--  1 ...  2620623 Dec  4 16:31 beam-sdks-java-io-google-cloud-platform-2.61.0-SNAPSHOT.jar

Then in the pom.xml (for maven) or build.gradle (for gradle) project for the pipeline, change the version of org.apache.beam:beam-sdks-java-io-google-cloud-platform from 2.61.0 to 2.61.0-SNAPSHOT

note - there is a single test failing - testWriteEmptyPCollection[0] due to that the table won't get created by switching from ReifyAsIterable to GBK to combine list of files. The former will emit an empty list, while the later does not.


Enable translations

I would like translate your fully website to Spanish for free. It is only needed that you add l18n support in your ruby project, Would be possible?
http://guides.rubyonrails.org/i18n.html
I know Ruby & Rails too in case that you want help too.

@shakaran Thank you for your suggestion! But in the current state of the site, it's not possible to add transltions using Ruby or Jekyll plugins. The reason for this is that we're hosting it on Github Pages.
But making it available under a different path ("/language/..") might be possible.
@davehakkens ^

@leo Thanks Leo! Well I can translate the fully site in a couple of hours, it doesn't have a lot text, so if you can put the site hosted in another place could be easily.
I suggest you a cheap and small Digital Ocean droplet, in case that you consider that option, if you want use my referal link you will get $10 for free https://m.do.co/c/46d666cd2390
Just let me know when you enable the translations and I quickly translate all the strings. For me it is important get a nice enviroment free of plastic and keep the nature clean :)

@leo @davehakkens we're currently receiving tons of emails from people that want to offer help translating the website or video.
Would be phenomenal to find a way to enable this crowdsourced input- as it represents a unique opportunity to achieve one of our main goal, reaching as many people as possible.

Guyz!
Someone at OSCE pointed me to this website as a great tool for translation- maybe it could be useful I don't know. I leave it up to @leo to say if is an option for us or not
https://www.transifex.com/
They also have an opensource page
https://www.transifex.com/customers/open-source/

We're working on https://github.com/hakkens/precious-plastic/pull/63


[BUG] editor: collapsing category or shortcut throws away request parameters

Hi again.
Got another issue.
I'm a backend dev and can effortlessly provide data exchange stuff. But with frontend frameworks - not so much.
This is me trying.
Steps to reproduce

expand a category
click "Add New Shortcut"
select "Regular HTTP Shortcut" from the modal
click the new entry to expand it
enter a name. Like "HelpMe"
Select Method POST
Enter URL
Select Request Body Type: Parameters (x-www-form-urlencoded)
click Add New Parameter
Add arbitrary values to that new parameter

The issue now is this: When I collapse:

the Parameter itself
the Shortcut within the category
the Category

The parameter is lost. The name, and the value. Whatever parent you collapse.
The Shortcut is not lost.
The category is not lost.
Only the parameter.
Expected behavior
Collapsing any newly created shortcut keeps all parameters.
Actual behavior
Collapsing a Parameter, a Shortcut or Category throws away new Request Parameters. Shortcut parameters remain, only the Request Parameters are thrown out.
To keep the new parameters, I have to keep the shortcuts expanded while adding new ones. With modern UX design a single shortcut occupies two vertical screen heights that I have to scroll. Creating more than two requests at once is not feasible, and with the risk of randomly losing the entire form it's not even desirable.
No screenshots. I hope the description is enough.

Thanks for the detailed bug report. I'll look into it when I have the time.


[Request] Edit Humans

I captured a cute Human but her stats are bad and she can only punch.
I was hoping I could have improved her stats and given her some nice passives and abilities, any chance you can add rudimentary support for editing humans?
The Human in question was: "Mercenary With a Wounded Knee"

At the moment, editing Humans creates a plephora of issues within the editor. We will be adding the rest of the Human information to the project later in 0.6's minor updates.

Looking forward to it!

Extra Human data has been added. Proper Human editing is coming in v0.8


Fix "can do HTTP requests after connections are cut" test in testThaliMobileNativeWrapper

There are too many ECONNRESET and ECONNREFUSED error. We couldn't establish the connection to another peer for 20 seconds. The reason can be in fact that we try to connect to the peer and discovering at the same time. It may slow our connection incredibly: "Creating new connections to remote Bluetooth devices should not be attempted while device discovery is in progress".

There is some ineffective node layer behaviour in this tests. The node layer tries to connect about 20 times while we connecting on bluetooth layer.
https://gist.github.com/evabishchevich/01c7adbdbdff3cb11a0035595de3135c

I've played with our NativeTestApp. When we sent 1 MB of data the average speed was about 0,017Mb/s. In worst case I saw 0,005 MB/s. It is incredibly slow. We have to think about next scenario:

We're discovering peers for some time.
We stop discovery
We connect to peers
We transfer data
We start discovering.

I tried to disable discovering in our NativeTestApp before we connect to peer. It improved bandwidth to 0,028 MB/s

What happens if we turn off both BLE and Wifi, what does our Bluetooth bandwidth look like?
What happens if we turn off Wifi but leave BLE on in low power mode, what does our Bluetooth bandwidth look like?
What happens if wifi is on and BLE is in low power mode, what does out Bluetooth bandwidth look like?

BTW, in regards to the ineffective node layer code the question is - why did it need to make all those retries?


Update camshift.py

Fixed the problem that often lost target;Fixed the onmouse bug; Format by PEP8.

Fixed the problem that often lost target;Fixed the onmouse bug; Format by PEP8.

There are a log of unnecessary changes related to code style changes. So it is very hard to review this.
It is better to make 2 commits in this case: the one with formatting changes and the other with behavior changes.


On Sun, Jun 2, 2024, 10:08 AM hakan1983 @.***> wrote:

i send this guy $500 then blocked !!!
—
Reply to this email directly, view it on GitHub
https://github.com/mamoloase/telegram-miniapp-game/issues/3, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BIKQZQU27MDX6OIGUMW4ISTZFK4XJAVCNFSM6AAAAABIUZRTP2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDSNBZHA4DSNY
.

On Sun, Jun 2, 2024, 4:03 PM hakan1983 @.***> wrote:

i want my money back
—
Reply to this email directly, view it on GitHub
https://github.com/mamoloase/telegram-miniapp-game/issues/3#issuecomment-2143830369,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIKQZQUUEXVLZNHCZR53RETZFMGJ3AVCNFSM6AAAAABIUZRTP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHAZTAMZWHE
.
You are receiving this because you commented.Message ID:
@.***>


Can you add a new delegate method that is called when the on/off state changes?

At the moment, I can only use the didTapOnLLSwitch method to detect a change in state. However, this is bad because:
If I have a LLSwitch that is originally on. And the user taps on it. The delegate method is called before the state changes. So if I get the on property of the switch in the delegate method, I will get on, not off. This means that I need to reverse the Bool value to get the new on/off state.
That's just weird. If I come back after a few months I won't know what the ! is doing there. This confuses people.
You see, the original UISwitch has a ValueChanged control event. Why not add such a delegate method to LLSwitch? It will look something like this:
func llSwitch(llSwitch: LLSwitch, didChangeValue value: Bool)

Thank you for your attention！
You see you can use the following method to satisfy your requirements?
`

(void)animationDidStopForLLSwitch:(LLSwitch *)llSwitch {
NSLog(@"stop --- staues:%hhd", llSwitch.on);
}
`

Yes, that works! Thanks! But can you rename it to valueDidChange? Because in most cases, people want to be notified when the value changes, not when the animation ends (although they are essentially the same thing). Rename it so that it can be more intuitive.

Thank you for your advice！
I have added a new delegate,You can try it！
- (void)valueDidChanged:(LLSwitch *)llSwitch on:(BOOL)on { NSLog(@"stop --- on:%hhd", on); }


 text location

The text for  should be going in the ECD under the heading for that particular class. When this text is present, it should be replacing what the template inserts by default.
See for example the SBC module - the  text is currently under section 5.2.4 in the main body of the document. It should be located under the class header in the ECD for the FFW class instead (section C.2.2 in SBC). The text currently in section C.2.2 is not appropriate for an extended class because it incorrectly states the class is defined in CC Part 2.

I think you're looking for the "class-description" tag that is subordinate to a section tag. Look at https://github.com/commoncriteria/vpnclient/blob/master/input/vpnclient.xml#L4339 . That being said, I'm not sure what the ECD description tag is supposed to do.

The class-description tag works for this. I would have expected that class-description would populate under the relevant header in the main body and the ext-comp-class would populate under the corresponding ECD heading for that class. It looks like the functionality of these two things are reversed.
There is no functional issue since the capability exists to do both things, it's just counterintuitive which tag is used for which purpose, so the issue can be closed.
For background (to address the last sentence) -
The ECD description is needed so that we have a capability to specify our own text in the ECD for when a class is defined that is not in CC Part 2 (e.g. it's not FAU, FCS, FDP, etc.). This is needed for the following requirement:
"APE_ECD.1-7 The evaluator shall examine the extended components definition to determine that each definition of a new functional class uses the existing CC functional classes as a model for presentation."
The boilerplate text that is used by default in the ECD assumes that it's underneath a class that already exists in part 2, so it's important for us to have the ability to replace that in the rare instance when brand new classes are defined (e.g. FFW, FPF).

Looks like this one can be closed.


Add some workflows

Some useful workflows from ChainRules

@ChrisRackauckas can you create a label for "needs version bump"? Or give me merge rights to the repo


Adds EastUS as a supported region

As per https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/azure-arc/servers/overview.md#supported-regions - EastUS is a supported region for storing machine metadata.

@stuartpreston : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#please-close as this PR overlaps with PR 56928.


Add initial implementation

cc/ @ndhoule @tsholmes

Current coverage is 100% (diff: 100%)

No coverage report found for master at ba5626c.

Powered by Codecov. Last update ba5626c...660673e


Understanding the SAC paramters

Hi Vitchyr,
If I may, I would kindly like to ask you an question related to:
https://github.com/vitchyr/rlkit/blob/1d469a509b797ca04a39b8734c1816ca7d108fc8/examples/sac.py#L92-L96
About:

What does those SAC parameters means?
In what way they interfere in my training study case?
Or even were may I find further information about it?

I did read the SAC paper, however didn't find any specificities such as, num_eval_steps_per_epoch, or min_num_steps_before_training, so I got a little lost.
I would kindly appreciate if you could give me any help regarding this subject!

By trial and error I could observe, by felling not scientific :), few things in my implementation:

max_path_length its like the size of max timesteps of your implementation roll-out
min_num_steps_before_training its how many random steps it takes to fill out the buffer... to my implementation it didn't change much
num_expl_steps_per_train_loop it like how many exploration steps, per epoch, it will use the current policy
um_trains_per_train_loop its how many batch learning it is going to produce per epoch
num_eval_steps_per_epoch how many steps are being used to generate the graph (the algorithm itself doesn't require it for the SAC, but for generating the graph)
net_size its the number of networks neurons
batch_size: the bigger it is, the smaller the variance and the longer the training time are.

I could observe that it has to be like the num train per loop >>> n_exploração (exploration should be much higher than train per loop)
Here are the hyper parameters https://github.com/vitchyr/rlkit/blob/master/rlkit/core/batch_rl_algorithm.py
I hope I can help anyone, and I could make any thing clear...

Yup! And to clarify, the num_trains_per_train_loop is per train loop, but typically the number of train loops per epoch is 1, so this is effectively the same.


[QUESTION] How to customize the ControllerConfig?

Please describe your quesiton here
I'm using Terraform resource "kubectl_manifest" to create a Crossplane SecurityGroup for an existing TF-created security group:
apiVersion: ec2.aws.upbound.io/v1beta1
kind: SecurityGroup
metadata:
  name: postgres
  annotations:
    crossplane.io/external-name: ${postgres-sg-id}
spec:
  managementPolicies: ["Observe"]

This is later referenced by a (non-Terraform) k8s manifest that creates an RDS Instance.
(This appears to be a good way for a Crossplane manifest to obtain the ID of an SG created by TF).
However, managementPolicies: ["Observe"] requires the ControllerConfig to have a --enable-management-policies argument:
spec:
  args:
    - "--enable-management-policies"

The blueprint doesn't appear to provide a way to specify this.
I have currently hacked it by using resource "null_resource" "k8s_patcher" to run kubectl patch.
It would be good if the blueprint provided a way to specify additional args.
In the meantime, any suggestions for better workarounds?
More

[X] Yes, I have checked the repo for existing issues before raising this question

Your workaround seems to be a reasonable one until there is a way to provide args to the helm chart. @candonov any thoughts here?

@cer, thank you for the recommendation. The blueprint example is now updated with --enable-management-policies to the args of the ControllerConfig and tested.


Modulate from audio streamed from remote computer problem

Hi!
I'm facing a big problem...
I'm trying the "Modulate from audio streamed from remote computer" but when i do "arecord -fS16_LE....."
it quits immediately di the command prompt.
I've replaced of course the ip of my raspberry and tested that the ubuntu machine can reach the raspberry.
Any idea?

Hi @michelinok,
Do you get random data while executing the following?
arecord -fS16_LE -r48000 -c1 - | xxd

If so, arecord works.
Try to use the verbose switch for nc to see more information:
 arecord -fS16_LE -r48000 -c1 - | nc -vv raspberrypi.local 8011

Note that the transmitter at the remote computer should be started first.

Ok, more infos...
nc: connect to <IP_ADDRESS> port 8011 (tcp) failed: Connection refused
The raspberry is in a fresh install state...

another info...the connection refused happens when rpitx starts to tx (it starts after 10 seconds on my raspberry). if i try connect before those 10 seconds, the connection seems ok , but it never start txing (waited some minutes)

arecord -fS16_LE -r48000 -c1 - | xxd
hangs after 2 lines

What happens if:
arecord -fS16_LE -r48000 -c1 - | csdr through > /dev/null

csdr is not installed on the ubuntu machine... should i install it on there too?

To run this, yes.

ok,i'll do this in an hour (going to have dinner now) and i'll post here the result

Recording WAVE '-' : Signed 16 bit Little Endian, Rate 48000 Hz, Mono
And it stays there

i'll try with  raspberry 3 ...currently trying on raspberry 1 (hope to solve)


queryOptions is not in @tanstack/react-query

Describe the bug
The doc mentions the following function.
https://tanstack.com/query/latest/docs/framework/react/guides/query-options
I can't import it though.
I get the following message '"@tanstack/react-query"' has no exported member named 'queryOptions'. Did you mean 'QueryOptions'?
Your minimal, reproducible example
N/A
Steps to reproduce
on version 4.29.25, try to import queryOptions function
Expected behavior
It should export the function.
How often does this bug happen?
None
Screenshots or Videos
No response
Platform
MacOS M3
Tanstack Query adapter
react-query
TanStack Query version
4.29.25
TypeScript version
No response
Additional context
No response

This is a v5 feature.


Implement String Shuffle Function

What's Needed:
We're on the lookout for a nifty shuffleString function that can mix up characters in a string for us.
Your Quest:

Function Name: shuffleString
Goal: Randomly shuffle the characters in a string.
Example:

Input: 'stringy'
Output: 'gtrysin' (Keep in mind, the output will vary every time!)

Set Yourself Up for Contributions:

You need to create a branch out of this issue, that's Step 0.

Find out all the Steps at Super Simple Stringy Contribution Guide

Happy Coding!

Navigate to lib/textTransformationsAndUtilities.js

You wil find Contribution Station for shuffleString function there and start.

can i work on this issue?

can i work on this issue?

Of course you can. The best one will be picked by the admin. I mean there's nothing to lose. One more problem solved.


C BRENNAN POOLE | CRUNCHBASE PROFILE : The Growth-Hack-Attack-v.2.1

GIT GROWTH

GROWTH - HACKING 101

The Growth-Hack-Attack-v.2.1
DROP A COMPREHENSIVE BIO AND ORGANIZATION PROFILE ON CRUNCHBASE
CRUNCHBASE : C BRENNAN POOLE
BrowserChrome 84.0.4147.68OSWindows 10 64-bitScreen Size2560x1080Viewport Size2560x969Pixel Ratio@1xZoom LevelNaN%

CODE —LESS
THE API TICKLE

Giving up all my good tricks - and - it is my prayer - someone will make that factual actionable for the love of all that is true and holy.

Notice the formatting (MOST IMPORTANTLY : THE HEADERS)?
Now, fire up Miss Google Assists (ie: the Google Assistant) and feel free to repeat after me :

Hey Boo-boo... Where did C—Brennan—Poole attend university?

On the website crunchbase dot com C Brennan Poole studied at J. Mack Robinson | Georgia State University.

Okay Google... What is C—Brennan—Poole MISSION?

On the website crunchbase dot com C Brennan mission in life is to create a truly meritocratic digital community that knows no bounds; understands the categorical labels and need for them in organizational behavior but doesn't apply them to himself or community, and to help create a sustainable, profitable business that future generations will look to.

Sure... There's more... But... Can't give you all the best in one sitting... Now. Can I?


Peg openpyxl dependency to 2.4.9 to avoid non-backwards compatible api change

As mentioned here and here, openpyxl has changed there api for xlsx.  Currently when exporting to xlsx we receive a 500 error.

Coverage increased (+0.03%) to 92.178% when pulling 5faa827fa488949e99191f4f499b7e23f559802e on andrewgy8:master into 816b49c23aef761c6daf1426b69f76f999e800b8 on django-import-export:master.

I would say that would be the best course of action. But it does not seem like we can be sure when tablib will have this fixed/released.  As you can see in this issue, there seems to be some worry from the community about the maintenance and governance in general.
I would say the next best course of action, is for ourselves to be proactive (this PR) AND watch closely the progress of the issue in tablib that addresses this error.  And it might be a healthy exercise to watch the state of tablib in general.

@andrewgy8 is right, we should stick to versions that are known to work. Although I'd stick to openpyxl 2.4 series, rather than to 2.4.9 in particular. Something like openpyxl>=2.4,<2.5.

@bmihelac I have updated this PR. What do you think? Shall we peg and wait?

This is causing exports to break for me unless I peg the openpyxl version, and since the resolution of the tablib issue seems unclear I'd humbly recommend that this be merged so the library doesn't come broken out of the box, at least until the tablib fix goes through.


destroyed event documentation

At http://bookshelfjs.org/#Model-event-destroyed it says:

Fired before a delete query

Shouldn't it say "after" instead of "before"?

I found this too,and the callback in destroyed params model is null

Fixed some time between the issue creation date and today.


[ENHANCEMENT] Moved logic from UserController to UserManger

Tasks:

[ ] test coverage
[ ] gather feedback for my changes
[x] added changelog line

Informations:

Q
A

Tests pass?
yes

BC Breaks
none

Doc
none

else ack


Text size in uncomfortably large by-default

When I visit the demo page I had to turn zoom down to 67% because the font size and column length was simply too large, both for myself and when just comparing to other sites. I'm using a 19" 5:4 1280x1024 monitor and I suspect that might be one of the causes.
This problem however does not exist with sites I've seen that use just Skeleton. Also mentioning just in case that Medium suffers from the same issue.

I've been playing around with this for a few days. It's a bit puzzling. I think you're right on the money with thinking it's your display settings. I duplicated your settings on my display, and although the text is a bit large, I'm not sure I'm seeing the same thing you are. Can you post a screenshot or something?
I can't identify anything in skeleton.css that would make a big difference here. The base font size on the html element is the same and there aren't any media queries that change it. It could be that I started with a slightly larger overall font size for readability at higher dpis and it just gets too big at lower dpis.
I've been experimenting with proportional font scaling and media queries for dpi. I'm going to try to combine those to gracefully adjust font sizing for different display geometries, but a screenshot from you would help me figure out how to tweak the scaling factors.

Skeleton.css's font size is practically the last font size that is reasonable on my screen, though even reducing to 90% would be my personal preference, scaffold.css on the other hand is just a bit too large by default.

Okay, cool. That pretty well matches what I was seeing then. I should have a fix out soon.

Can you visit https://newventuresoftware.com/blog/pixel-density-and-resolution-tool-for-css-media-queries.html (click through the expired certificate, I guess...) and tell me what your dpi &etc. values are?

Not the numbers I was hoping for.
Okay, how does https://sscaffold-css.com/test/homepage/ look to you?

It's much nicer, thank you.

Okay. I'll finish testing and then commit this. Thanks for the bug report and the help in resolving it.


How did you go about debugging this?

I was wondering if you can share how you developed this project? Did you do it all in node before moving to severless?

I'm exploring this local debugging:
https://github.com/dherault/serverless-offline/issues/45#issuecomment-290841006


CPU threshold

User should be able to set a max CPU threshold using a "builder pattern" method on Scheduler. When threshold is provided, Scheduler should wait until system CPU usage is below threshold before scheduling new concurrent jobs.

Getting current CPU usage is going to be a platform-specific operation, so be sure to update CI test matrix to include different platforms.
Might also be interesting to put this behind a feature flag.


The project website and it's repo are lost in a limbo

Hey! The repo https://github.com/sailorproject/sailor_website/ and the site http://sailorproject.org/ are both sad for lack of attention 😞 😭.  Who gonna slay the ⚔ 🐉 of sadness?
Please, bring their joy back. 😅

I'm slowly getting back to things :)

merged and pulled!


Add classes for IP V4 and V6 Address Forms

Instead of having the $type parameter to Form_IpAddress and using a
switch statement, the class hierarchy can be extended to have a Form
class for each IpAddress combination, and put the custom message and
pattern in the specific class.

This is a more OO way to do this than the parameter plus switch statement way.
See #3242

Note: If this is the way to move forward, then this PR also needs to have associated code updated to change anything that calls Form_IpAddress and specifies the $type parameter as "V4" or "V6", to use the relevant Form_IpV4Address or Form_IpV6Address class.

Closing in favour of #3248


Nonexistant Civ icons for certain categories

A General Atomics drone recently flew within ADSB range. ICAO A3C1BE. This is within the Civ ICAO range. However, there is no valid icon type for a civilian affil drone. The affil must be set to mil to have a valid drone icon. The current code results in the standard civ fixed wing icon. Possible solution:
cot_type = f"a-{attitude}-A-M-F-Q"
Either way, Q needs to be capitalized as lowercase Q was not recognized by WinTAK.

Recommend any civil icao address range with the drone DO260B or GDL90 emitter category be {attitude}=neutral and as listed above.
example: a-n-A-M-F-Q
This will present a green square batwing drone 2525 B icon. And differentiate from MIl drones.


fix broken xref

Hi @ryanemerson , I found one dead xref.
Originally, I checked the docs to add reference to the Server guide but my impression is that it already includes several references to the Server guide and other docs.

Thanks @dvagnero


ci: test Node.js 6, 8, 10 and 11

Current LTS are 6, 8 and 10 and we should test there too to catch any issues and check if Node.js 6 users can still use this library.

Pull Request Test Coverage Report for Build 275

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 273:
0.0%

Covered Lines:
56

Relevant Lines:
56

💛  - Coveralls

Pull Request Test Coverage Report for Build 275

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 273:
0.0%

Covered Lines:
56

Relevant Lines:
56

💛  - Coveralls

Then let's make this clear in engines.node in package.json.

Also still failing: https://github.com/xxczaki/cash-cli/commits/master

@DanielRuf Looks like it's working now :smile: However, tests are now much less stricter, because users now need to provide their own https://fixer.io API key :cry: I don't know how we can test the actual conversion without hardcoding the API key :/

@DanielRuf Looks like it's working now 😄 However, tests are now much less strict because users now need to provide their own fixer.io API key 😢 I don't know how we can test the actual conversion without hardcoding the API key :/

Is there something like tokens for such cases or just one API key for everything?

@DanielRuf I think API key is used for everything, according to fixer.io documentation :/ Year ago, fixer.io used to be a free service, without tokens or API keys, but it was acquired by apilayer. I was using my personal key for this app, but a few days ago the requests limit (1000) has been exceeded :cry:

@DanielRuf Just published version 3.0. Thanks for this pull request :unicorn:


Replace VNC Server

Description
Kasm workspaces has an opensource VNC server named KasmVNC which is configurable, has a dashboard and generally is rather modern. it's of course also faster and all that.
Use case
Faster / reliable access to VMs. Less keymap problems.
Be able to work in VM consoles (also from cloud view)
Interface Changes
Things like automatic resize...
It would be nice if we had a reset / reset hard button in the VNC tab at last, too, so it's not as much a competitive clicks per second task to get into a boot menu.
Additional Context
Take 20 minutes to try it out (the whole kasm thing is up in less.). The Sunstone VNC feature has rarely seen improvements, there's a mountain of tech debt, it would be viable to replace it with a already done better version instead of overhauling. i know you just refreshed UI, but it doesn't have to stay a missed opportunity.
Also I'm very sorry I can't find how to apply labels to the issue.

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

FireEdge Sunstone currently uses Guacamole. We are deprecating Ruby Sunstone and noVNC, which won't be present in the next major OpenNebula version.
I'm closing this for the time being, but we can use it to discuss KasmVNC vs Guacamole, so see if the benefits justify the effort.

It would be nice if we had a reset / reset hard button in the VNC tab at last, too, so it's not as much a competitive clicks per second task to get into a boot menu.

This is a convenient feature indeed, we will tackle it in the context of #5766

Hi Tino,
FYI: it is just the same set of advantages compared to Guacamole. Look at the feature list if possible.
(It's day and night)

Am 17.09.2024 um 13:37 schrieb Tino Vázquez @.***>:
FireEdge Sunstone currently uses Guacamole. We are deprecating Ruby Sunstone and noVNC, which won't be present in the next major OpenNebula version.
I'm closing this for the time being, but we can use it to discuss KasmVNC vs Guacamole, so see if the benefits justify the effort.
It would be nice if we had a reset / reset hard button in the VNC tab at last, too, so it's not as much a competitive clicks per second task to get into a boot menu.
This is a convenient feature indeed, we will tackle it in the context of #5766 https://github.com/OpenNebula/one/issues/5766
—
Reply to this email directly, view it on GitHub https://github.com/OpenNebula/one/issues/6727#issuecomment-2355447284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVSVG5AGYBBAIJQT352VUDZXAH7BAVCNFSM6AAAAABOLGB7EKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJVGQ2DOMRYGQ.
You are receiving this because you authored the thread.

Hi @FlorianHeigl,
KasmVNC looks awesome when glancing over their feature set, we've opened another issue specifically in regards to this. You can keep track of it from here OpenNebula/one#6731

Quick question @FlorianHeigl , we are trying to make copy&paste work, but it looks like a limitation on the qemu VNC server unfotunately. Let us know if you have some insights on this, this prevents using the nice features of kasmvnc, since we need to rely on the qemu VNC server.


Clarify that Azure temporal users are for CTL support staff to use

Hey @julianatienza, @pabloperezmartin, could you please review? This update was pending for a long time, hope it's still accurate!

@gsanchezu  I'm out of time and in a deadline with new customer experience. In Teams @bjswoboda  clarified that the specs were: only for CTL support staff. Can you kindly update the documentation? on the other hand it should wait a couple of weeks to do it.


Simple and intuitive fullscreen behavior

The current Shower behavior is that it stores in local storage whether or not a slideshow was last displayed in full screen. This is counterintuitive and continues to annoy me on several devices; you just never get what you expect (but instead what you happened to have last time).
This commit fixes that by proposing the following simple and intuitive decision logic:

http://example.org/slides/ takes the user to the list of slides.
http://example.org/slides/#27 takes the user to slide 27 in full screen.

I think it's all we ever need; local storage introduced unpredictability and confusion.
To me, this proposal is the intuitive behavior, because it allows me to send links to others for either the presentation as a whole, or a specific slide. It also fixes the annoyance that you currently can't exit full screen mode on a keyboardless device.

I’m afraid this is too radical. I really like the ability to go though slides in list mode and link to a certain slide in a context or next/previous slides in list mode.
There’s another idea how to get full screen mode state in URL back.

http://example.com/#27
http://example.com/#27:full

And in each case an actual ID exists so the slide still could get a :target state:

This :full thing should applended to each slide in full screen mode.
What do you think?

And this is a valid ID value:

I really like the ability to go though slides in list mode and link to a certain slide in a context or next/previous slides in list mode.

I never found the necessity to link to slide in list mode, because it is way less obvious that you're linking to a specific slide. There is a highlight, but it is only minimal (and rightly so).
But I understand you want this functionality.

This :full thing should applended to each slide in full screen mode.

What do you think?

Following what I wrote above about obviousness, how about the opposite?

#27 for a full-screen slide
#list:27 or #27:list for a slide in list mode

It seems just more logical to me that, if you link to a slide, you see the slide (only, full), not the list that contains that slide, with a minimal highlight on that slide.

I think one of the main differences of Shower is that it focuses on slides list first. Most of the other slide decks start from the full screen by default and it’s usually not clear that there’s overview mode (if there’s one at all). You always have to go forward slide by slide though boring introduction looking for something interesting. In Shower case it’s also possible by , but it’s not default. Default is the list and I’d really like to keep it this way. Meaning that :full should be an extra parameter in URL, not :list.

Default is the list and I’d really like to keep it this way.

I understand, but if I want people to see the list, I'll link them to the list.
If I want them to see the slide, I'll link them to the slide.
I.e., I agree on list focus (and that's a great feature of Shower), but it perhaps shouldn't be overdone. If I like to the slide, I really mean slide, not list.
That said, I can proceed in any way you want—my main annoyance was local state.
I'm not sure about the necessity of changing ids in full-screen mode though. Is target that important, given that they would be JavaScript-activated anyway?

I think I agree that changing ID on the fly is a bit overkill and such full screen routing is a must have feature. But if you remember there used to be a ?full query parameter to keep full screen state in a link. It required History API that Chrome decided to disallow for file:/// protocol. And presentations are often opened from flash drives without any local or remote servers. That was the reson to move to the sessionStorage full screen states. AFAIK, fragment identifiers in URL doesn’t require any history.* API calls and still could be changed for local files via JS. But I’d double check it before going any futher.

FYI, I have merged new Selenium tests I’ve been working on recently to the master. There are 43 of them passing and 4 pending. It’s not tested in Travis yet as it requires Selenium grid and I’m still figuring out where to get it, preferably for free (Sauce Labs, etc.) But you can still test it locally, just npm install and npm run test.
Hopefully this will help developing core, I really appreciate your help.

That's great news, thanks! I'll try to make an improved proposal for this PR soon.

This new proposal has one link: #37 point to slide 37, and opens by default in list view.

Some context for this new proposal:

The fact that #37 points to list view respects the Shower defaults.
We lose the ability to link specifically to a full or list-view mode of a slide. However, I think this ability is too complex for most users. People likely just want to link to a slide; they would not know the link is different whether they are in list or full mode, and cannot be expected to switch before they copy the link.

What do you think, @pepelsbey?

But how’s that different from the current behaviour apart from sessionStorage that keeps full stare between reloads? Sometimes reload is very useful for resetting all next steps.
Sorry for not following up on this for a while, I’m having a busy time.

But how’s that different from the current behaviour apart from sessionStorage that keeps full state between reloads?

This PR indeed removes sessionStorage, so link always open consistently. (My main issue from a usability behavior was that links to slides were counterintuitive/unpredictable.)

But what should I do if I want to just reload my presentation? Imagine it’s already open, you’re halfway through and you realize that something’s not right with your demo. I usually just hit Cmd R and instantly see updated slide in full mode. Your proposal would get me back to list mode which is rather bad.

That's right; this is why my initial proposal was to always go to full-screen mode when a slide is linked directly.
Mmm, I don't know… seems like we do need different links to full-screen and list-view slides after all. However, I expect that the average user browsing slides will always do so in full-screen mode, and hence always share full-screen links. And sharing a list-view link is hard: you'd first have to click the slide (which opens full-screen mode), escape full-screen mode, and then copy.
Long story short: with different links for full-screen and list-view slides, users will end up sharing the full-screen link anyway. So maybe my proposal to always open individual slides in full-screen mode (but a link to the entire presentation in list mode) wasn't so bad after all.
LocalStorage is the current alternative, but I find its unpredictability rather annoying.

I expect that the average user browsing slides
will always do so in full-screen mode

I doubt that. Because it’s like reading a book where only one sentence is written on a single page. It’s just too slow. Full mode is good for presenting because it allows you to guide audience through your story step by step, switching to the next one when you’re ready. But you don’t need it when you go through slides looking for a link or funny picture you saw yesterday.
Personally, I always read my slides in list mode because they are big enough to read even on a tiny 12” display. I go to full mode only for presentation. So this full mode first would break this habit and I believe it’s not just me.

But how would you (or anyone) share a link to a specific slide from list mode?

Currently there’s a current slide indicator in both built-in themes: thick blue outline or darker shadow. It gives you an idea of what slide is current and you can go forward by pressing Space, Enter, arrows, etc and URL will match the current slide. I know, it’s not optimal but it works: you can navigate to a slide you want and get URL from address bar.
We could also wrap every slide to a link to itself:
 just position it on top of it
 to make it possible to copy a link to a slide. But I’m not sure it would be too useful.

Different way of thinking: how about we make this configurable with:

linkMode: 'last' (default, uses local storage to open link in last used mode)
linkMode: 'list' (opens links in list view)
linkMode: 'full' (opens links in full screen view)

Chrome 59, history.{push,replace}State work in file:/// protocol. Should we go back to query param? Should we add an opt-out to disable sessionStorage behavior?

Seriously? Did they revert this behaviour? I don’t know… I got used to this behaviour :) But it would be good to be able to have a link with mode built-in.
There’s an issue for that in the main repository.

There’s a plan to reimplement ?full state in URL, since Chrome suddenly decided to support History API in local files. So you’ll again have a way to link to full screen state.

Good news, thanks!


IsWindows10OrGreater and similar are not exposed

Function is documented here: https://docs.microsoft.com/en-us/windows/win32/api/versionhelpers/nf-versionhelpers-iswindows10orgreater
The same happens for all functions like IsWindows<version>OrGreater

Thanks for filing this. These are inline functions defined in the VersionHelpers.h header file, hence no metadata describing them and no crate representation. I can see a case for spinning out a microsoft-version-helpers or similar crate though. I'll ping you if/when that's available. (Doesn't sound difficult.)
Closing for now as there's no action for the windows crate, but feel free to continue the discussion

We wrote internal helpers from available functions in windows-rs, but a blessed crate from Microsoft would be welcome indeed, though probably not high priority.
Thanks for the quick responses though !

@riverar was an official microsoft-version-helpers crate or similar ever published?

@wmmc88 No, sorry about that! Is this something you're looking for as well?

Yes. It would be nice to just have something in the windows crate that provides this, rather than needing to reimplement the logic.


Release version 3.2.0

Downgraded ini from 3.2 to 3.1 because there was never a 3.1 version

TODO

Add tags for each PR of 3.1
Update CHANGELOG in preparation for 3.1
Update python version requirement on RTD
Change file name to stick to convention: CHANGELOG --> CHANGES

In the last meeting, we found out that version 3.1 (intended on April 15, 2020, PR #294) and 3.2 (intended on June 22, 2020 in PR #307) had never been officially released on github (latest release is 3.0 on March 13, 2020).
We opened this PR in order to release the current version as the official 3.1 version.
We also removed the "Create a wheel package and uploaded it to PyPI" instructions from the wiki for new release.
However, I found that a version 3.1 was released on PyPI here on April 15.
Are we still maintaining versions on PyPI? If so, how can we manage the current difference of version between github and PyPI?

Are we still maintaining versions on PyPI? If so, how can we manage the current difference of version between github and PyPI?

i don't think we are. @mathieuboudreau can confirm

Are we still maintaining versions on PyPI? If so, how can we manage the current difference of version between github and PyPI?

i don't think we are. @mathieuboudreau can confirm

No, we decided to stop / place that feature on hold at a previous meeting if I recall. It was hard to maintain with users vs. just making them download from github, but we can revisit it if you think it's warranted.

Ok, I'll remove the stable release pip instructions in the doc.
But I just want to point out that the latest release 3.1 on PyPI from April 15 will be different from the 3.1 release on github. Shouldn't we skip 3.1 on github and release 3.2 instead?

latest release 3.1 on PyPI from April 15 will be different from the 3.1 release on github.

we should forget about PypI (for now), and be consistent with our GH release (ie: next release should be 3.0, because 3.1 never existed)

On PyPI, we cannot completely hide/block download for a release, we have 2 options:

Remove completely the release 3.1 without the possibility to re-release it under the same number.
Yank the release i.e. it will be ignored when installing with pip unless the user install this exact version (axondeepseg==3.1).

Note: the PyPI 3.1 release works as expected with a python 3.6 environment.
So, our options for the next release on github are:

Yank version 3.1 on PyPI and release new 3.1 version on github.
Release version 3.2 on github (skip 3.1).
Release version 3.2 on github (skiip 3.1) and yank version 3.1 on PyPI.

Also, I notice that the project page of axondeepseg on PyPI is not displaying properly (images and section titles). I don't know why, as far as I know, I haven't change anything on the page.

On PyPI, we cannot completely hide/block download for a release, we have 2 options:

can we close the project on pypi (and reopen it later)?

I would vote for : Release version 3.2 on github (skip 3.1) and yank version 3.1 on PyPI. if we can't pause" the project like Julien is suggesting.

can we close the project on pypi (and reopen it later)?

I don't think so. The only option I found is to Delete the project which irreversibly delete all the releases and make the project name available for other pypi users.

can we close the project on pypi (and reopen it later)?

I don't think so. The only option I found is to Delete the project which irreversibly delete all the releases and make the project name available for other pypi users.

i would be ok with that, given that pypi should not be used right now (and it would be an unlikely coincidence if there would be another project called axondeepseg, no?)

can we close the project on pypi (and reopen it later)?

I don't think so. The only option I found is to Delete the project which irreversibly delete all the releases and make the project name available for other pypi users.

i would be ok with that, given that pypi should not be used right now (and it would be an unlikely coincidence if there would be another project called axondeepseg, no?)

that could break other users code if it depends on the package, no?

that could break other users code if it depends on the package, no?

yes but:

i don't think many people in the world are concerned
we might want to break their workflow (given that the version is old), so: it will break, then they will go on the GH ADS repos and figure out how to get the up to date version

We could delete and re-register (to save the name)?

Yes we could, but I think we will not be able to re-upload our old release if we want to, see: https://pypi.org/help/#file-name-reuse

Yes we could, but I think we will not be able to re-upload our old release

not a problem

As discussed in meeting, we will switch to MAJOR.MINOR.PATCH naming for new releases.
This release will be 3.2.0.
We will continue to maintain PyPI release through automatic PyPI package creation with github action (issue #353)
TODO

[ ] - Set __init__.py to 3.2.0
[ ] - Update python version requirement on RTD
[ ] - Rename next milestone to 3.2.0
[ ] - Add tags for each PR of 3.2.0
[ ] - Change file name to stick to convention: CHANGELOG --> CHANGES
[ ] - Update CHANGELOG in preparation for 3.2.0
[ ] - Setup Github Action for automatic PyPI package creation

[ ]  - Change file name to stick to convention: CHANGELOG --> CHANGES

most of our projects (SCT, ivadomed) use CHANGES.md instead of CHANGES. Don't we want to add the .md extension? What convention are you referring to?

most of our projects (SCT, ivadomed) use CHANGES.md instead of CHANGES. Don't we want to add the .md extension? What convention are you referring to?

The convention for the changelog to be named CHANGES.md, instead of the current CHANGELOG.md in ADS. I edited to TO DO list above to clarify.

@mariehbourget Stoyan's PR has been merged, so I think we can proceed with this one.

@mariehbourget Stoyan's PR has been merged, so I think we can proceed with this one.

Thanks @mathieuboudreau
I updated the changelog to include Stoyan's PR and renamed it CHANGES.md.
The only thing left before we can merge would be to setup Github Actions for automatic release on PyPI (issue #353).

As discussed, I renamed CHANGES.md to CHANGELOG.md.
We won't use github actions for this release, I will create the release on github and upload to PyPI after the merge.

@mathieuboudreau, do you want to review before I merge or do I approve my own PR?

@mathieuboudreau, do you want to review before I merge or do I approve my own PR?

I'll give you the honour of clicking merge, thanks @mariehbourget !

Thanks @mathieuboudreau, the release on github is done.
I have a question for PyPI, I update my master branch, do I have more clean-up to do before creating the wheel? (ex: untracked files?)


fix filechecker in health with precondition check

This PR is a migration of #2049
FileChecker can not work properly when the specified file can not be Stat because the app has no proper permission (read and execute permission for directory along with the specified file path). This should be make clear to end users and under such circumstance, FileChecker should return error instead nil to make the precondition ready. Otherwise, we can not actually disable the app by touch the disable file.
We should also add more document about the usage of FileChecker.
FileChecker only accepts absolute or relative file path. It does not work properly with tilde(~). You should make sure that the application has proper permission(read and execute permission for directory along with the specified file path). Otherwise, the FileChecker will report error and file health check is not ok.
Also, this PR will add support for relative path. And, if it can not be expanded to the corresponding absolute path, an error will be returned by FileChecker. This is also one precondition that can make FileChecker work when we want to disable one app by touching a disable file. :)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix_filechecker_in_health" git@github.com:andyxning/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Current coverage is 51.21% (diff: 45.45%)

Merging #2072 into master will decrease coverage by 10.11%

@@             master      #2072   diff @@
==========================================
  Files           128        128
  Lines         11322      11331      +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6944       5803   -1141
- Misses         3490       4778   +1288
+ Partials        888        750    -138

Powered by Codecov. Last update 7694c31...c59390d

@dmcgowan adjusted has been done. PTAL.

@dmcgowan PTAL.

Can anybody review this?

one nit, otherwise LGTM

@dmcgowan PTAL.

@andyxning Please fix the formatting in the doc comment.


Added handling for inserting empty object

Codecov Report

Merging #218 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage    84.6%   84.61%   +<.01%
==========================================
  Files          83       83
  Lines        5003     5006       +3
==========================================
+ Hits         4233     4236       +3
  Misses        770      770

Impacted Files
Coverage Δ

lib/src/db/managed/data_model.dart
46.42% <0%> (ø)
:white_check_mark:

lib/src/db/postgresql/postgresql_query.dart
98.19% <100%> (+0.05%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a770683...29ba81d. Read the comment docs.


idb2pat infinite loop if function size < 32

func.endEA - func.startEA can be less than 32, in which case zrange loops infinitely since the sentinel value in iter will never be reached. Happened when I used this on an ARM binary.
To stop this from biting others, two options come to mind: either return [] when end < start in zrange (modeling behavior like range(32,16) and list(xrange(32,16))), or fail hard with an error. The latter might be the better choice since violations of the start >= end invariant should probably debugged, based on how you're using zrange.

thanks for the bug report and providing a patch (& suggestions!). this also closes #29, which is great!


Customizing colors of theme

Steps to reproduce
Hi!
Please clarify how to customize the colors of the theme. The documentation mentions file src/layouts/UserThemeOptions.ts but there is  no such in the repository:
https://github.com/themeselection/materio-mui-react-nextjs-admin-template-free/tree/main/javascript-version/src/layoutsthe
What is expected?
UserThemeOptions.ts to be in the repo inside this directory:
https://github.com/themeselection/materio-mui-react-nextjs-admin-template-free/tree/main/javascript-version/src/layouts
What is actually happening?
There is no such file
Additional data

Hi @shimmeg,
Apologies for the inconvenience caused to you.
The documentation you are referring to is the documentation of the Materio Pro version. The Materio Pro version is up to date and we provide updates frequently.
Overriding theme colors is possible only in the Materio Pro version. You may upgrade to the Materio Pro version. If you still want to change the theme colors, you need to change them in the<EMAIL_ADDRESS>file.


Unable to use content editor during post

Describe the bug
After sign up when I go to add new blog every fields works fine except content editor. Content editor was disabled with message.

A valid API key is required to continue using TinyMCE. Please alert the admin to check the current API key.

To Reproduce
Steps to reproduce the behavior:

Go to "https://code-and-blog.vercel.app/add-post"
Click on add post button
Scroll down to content field
See error

Expected behavior
It should be editable
Screenshots

Desktop (please complete the following information):

OS: windows 10
Browser: chrome
Version: latest

@sahilatahar Thanks for getting that as you can see the trial period of TinyMCE has ended that's why it doesn't allow us to write any description on it or any of the posts if you want to integrate any other editor on it then I can assign you this issue only.
You can also please let me know which editor you want to integrate before raising the PR.

What about Quill Editor?

What about Quill Editor?

Hey @sahilatahar sorry for late response, Yeah u can add this editor to the Project.


HetGalia

[X] I have read the Code Of Conduct.
[X] I have followed all the steps of submission properly.

Thanks, @HetGalia  , for opening the pull request! 👏
Star ⭐  this project and tweet about your contributions and tag @clubgamma.
Also join the Discord Server
Ready to merge your PR!!!


Add explicit dependency on Compat

Pkg.test was only passing because FactCheck is in test/REQUIRE
and FactCheck happens to depend on Compat

Oops, didn't see it, made my own commit. Thanks anyway!


Time taken and Memory Leakage while accessing UI elements through WinAppDriver keep increasing with time.

I use WinAppDriver to automate button click. To avoid performance hit, instead of using "app", "root", I use
capabilities.SetCapability("appTopLevelWindow", topLevelWindowHandle);
Still finding an element by it's Id or Name takes more time (around 5 seconds initially) and the problem gets worse when WinAppDriver runs continuously for more than 30 minutes or 1 hour.
It is clear from Task manager that memory consumed by the application (which is automated) continues to grow for each function call on WindowsDriver object.
Please check and provide a solution. Thanks.

It would be nice to have a workaround atleast so that automation is little faster than manual execution. :)


Automatically close in-app browser when exporting to Google Calendar

Is your feature request related to a problem? Please describe.
Issue related to Google Calendar events export.
Describe the solution you'd like
When exporting the Google Calendar events and accepting the permissions, it would be more intuitive if the browser closed itself automatically
Describe alternatives you've considered
You can close the browser manually from the X button on the Webview toolbar, as you can see on the current implementation in this branch,
I've also created an issue on the in-app-browser package repo.
Additional context
I'll return to this issue with a GIF ASAP.

Converted to project


Adding anesthesia schema

After the openMINDS-chemistry finalized, a schema for anesthesia should be added.
This issue is for discussing the properties and content of this schema.

Moved to openMINDS_chemicals


feat: Add responseMimeType option in vertexAiGeminiChatOptions

The Gemini model provides the responseMimeType parameter, as documented in the Gemini Model Reference.
However, when I attempting to call the Gemini model using Spring AI, there is no direct option to set this parameter.
To work around this, I used reflection in my project:
        val chatModel = VertexAiGeminiChatModel(
            VertexAI(System.getenv("GEMINI_PROJECT_ID"), System.getenv("GEMINI_LOCATION"))
        )

        val generationConfig = GenerationConfig.newBuilder()
            .setResponseMimeType("application/json") // responseMimeType 을 설정할 수 없어서. 직접 접근하여 설정하였다.
            .setTemperature(0.8f)
            .build()

        val generationConfigField = VertexAiGeminiChatModel::class.java.getDeclaredField("generationConfig")
        generationConfigField.isAccessible = true
        generationConfigField.set(chatModel, generationConfig)

Therefore, it would be beneficial if the responseMimeType parameter was officially supported. The model generated by default in VertexAiGeminiChatModel is GEMINI_1_5_PRO, so this option is available from this version onwards, so it should be added as needed.

Thanks!  Important feature indeed. I updated the docs.  Merged in bc55bc7196f9d02115c32fa1d831b85d7c35e86f


Type Narrowing not being all it can be

TypeScript Version:  2.4.1
Hey all, I stumbled upon an oddity around type narrowing.  I've been meaning to report for ages but... well better late than never!
Code
interface OneThing {
    oneThing: {};
}

interface OtherThing {
    otherThing: {};
}

const returnOneThingOrAnother = () =>
    '5' === `${6}` // ignore this - what's produced is what matters
        ? { oneThing: {} } as OneThing
        : { otherThing: {} } as OtherThing;

const iHaveOneThingOrAnother = returnOneThingOrAnother();

if (iHaveOneThingOrAnother.oneThing) {
    // iHaveOneThingOrAnother should be narrowed to OneThing
} else {
    // iHaveOneThingOrAnother should be narrowed to OtherThing
}

Expected behavior:
I would expect type narrowing to occur in the manner suggested in the comments.
Actual behavior:
Actually the expected type narrowing does not occur.  Rather, the if (iHaveOneThingOrAnother.oneThing) { expression throws the following exception:
Property 'oneThing' does not exist on type 'OneThing | OtherThing'.
  Property 'oneThing' does not exist on type 'OtherThing'.

Why?  Obviously I could solve this by introducing a user defined type guard but that seems like it ought not to be necessary.
Is there a reason the TypeScript compiler does not perform the type narrowing in the way I had hoped?
Possibly related to https://github.com/Microsoft/TypeScript/issues/12457 but not certain.
Much :heart: for all your work BTW 🌻

Good question. We consider this to be an unsafe operation because we can't guarantee something like this doesn't happen:
interface GotString {
  x: string;
}
interface GotNumber {
  y: number;
}
const fooled = { x: 100, y: 200 };
const gn: GotNumber = fooled;
const j: GotString | GotNumber = Math.random() > 0.5 ? gn : { x: 'ok' };
if (j.x) {
  // In theory: j: GotString
  j.x.substr(0); // Crash - x was a number. Bamboozled!
}

See also #14094 where it's proposed to add syntax to create these sorts of unions automatically.

Thanks for the response @RyanCavanaugh - that makes sense.
I'm quite keen on exclusive unions so at present I'm landed with either introducing a type guard or casting back to any briefly - neither of which is attractive. Suffice to say I like the look of #14094!
Do feel free to close this issue if you think it's covered by #14094.  Good to know the reason for this 👍


Tabbing a block of TLA+ doesn't preserve indentation of conjunct and disjunct lists

Put(t, d) ==
/\ t \notin waitSet
\* The Producer t must not have initiated its termination.
/\ prod[t] = Cardinality(C)
/\ \/ /\ Len(buffer) < B
      /\ buffer' = Append(buffer, d)
      /\ NotifyOther(t)
   \/ /\ Len(buffer) = B
      /\ Wait(t)
/\ UNCHANGED <<prod,cons>>

vs
Put(t, d) ==
    /\ t \notin waitSet
    \* The Producer t must not have initiated its termination.
    /\ prod[t] = Cardinality(C)
    /\ \/ /\ Len(buffer) < B
        /\ buffer' = Append(buffer, d)
        /\ NotifyOther(t)
    \/ /\ Len(buffer) = B
        /\ Wait(t)
    /\ UNCHANGED <<prod,cons>>

Fortunately in this case, SANY caught it:
Parsing file /home/markus/src/TLA/_specs/models/tutorials/BlockingQueueTLA/BlockingQueuePoisonApple.tla
***Parse Error***

  Precedence conflict between ops \lor in block line 124, col 5 to line 124, col 6 of module BlockingQueuePoisonApple and \land.

Residual stack trace follows:
ExtendableExpr starting at line 124, column 8.
ExtendableExpr starting at line 118, column 5.
Expression starting at line 118, column 5.
Definition starting at line 117, column 1.
Module body starting at line 7, column 1.

Fatal errors while parsing TLA+ spec in file BlockingQueuePoisonApple

tla2sany.semantic.AbortException
*** Abort messages: 1

In module BlockingQueuePoisonApple

Could not parse module BlockingQueuePoisonApple from file BlockingQueuePoisonApple.tla

Starting... (2021-07-10 14:43:26)
Error: Parsing or semantic analysis failed.
Finished in 00s at (2021-07-10 14:43:26)

I think this issue is not solvable on the extension level. In this case VSCode indents each line independently, and indentation on Tab pressing means "move to the next nearest position that corresponds to the configured tab size for the language (which is 4 by default fot TLA+)". This is why you end up with a broken TLA+ formatting.
Actually, it works the same way in any other language. In JavaScript this block:
const foo = 10;
   // ^^^ here's the name of the const

becomes
    const foo = 10;
        // ^^^ here's the name of the const

And the extenstion cannot change this behaviour (formatter API doesn't capture tab indentations). Though, for TLA+ it's a bigger problem than for most of other languages because text indentation is significant for the meaning of the spec.
Some other editors (IntelliJ IDEA, for instance) analyze the selected block as a whole before indenting it, and use the same indentation "distance" for all the lines.
Given all this, I think, this issue should go to the VSCode project, there's nothing we can do here.
BTW, we can help users with proper block formatting, here's the issue: #99. But it won't help with the described case.

I'm putting the issue on hold until there's an API to fix it on the extension level, or it's fixed on the VSCode level.

@alygin Is there a way to prevent tabbing until tabbing works reliably?  I fear that users accidentally change the semantics of their specs.

@lemmy, I'm not aware of API that would help us here. There's the type command that can be used to analyze key strokes, but it doesn't provide the typing context and has other limitations that prevent it from be useful for such tasks.

Erich Gamma: "the indentation behaviour is language specific and needs to be provided by a language extension. In this case it is the python extension. Therefore pls report the issue against the Python extension."
Related:
https://github.com/microsoft/vscode/issues/10339
https://github.com/microsoft/vscode/issues/5394

@lemmy, unfortunately, none of these links help much. I think, by "the indentation behaviour" he meant that there's Indentation Rules that a language configuration can provide. But those rules do not affect how tabbing works. And Python still has the same problem with tabbing.
Other two links describe a different problem, they are about dichotomy between tab size and indentation size, which VSCdoe doesn't recognize out-of-the-box.

It appears that when the VSCode editor configuration option "Use Tab Stops" is unticked, then a uniform amount of indentation is inserted across a set of selected lines, when pressing the tab key. This editor option is described in VSCode as:

inserting and deleting whitespace follows tab stops

Given that editor.useTabStops is on by default, our extension should probably raise a warning.


Error from fetching logs in e2e should be transparent for users

When istio e2e tests failed, we fetch log from stackdrive. During this process, we throws out several error messages which of course not the actual reason why e2e failed, but those message confuses users and make debug harder, we should just say "info:" or "log warning"

/assign @chxchx

Everywhere else in the code has switched to using words like warning or info. However, all errors returned by StackDriver are surfaced as-is, and may contain keywords like failed or error that prow loves to highlight. I prefer not to mask such errors since they include critical information about what has happened.

Closing this issue now that no longer fetching logs from stackdriver but running kubectl logs instead


Fixed-Issue #4687:right panel to tab view in user page

Describe your changes :

I worked on the right panel in user page which had user's data and following data that are now converted into a tab view because it makes it very much easy for a user to navigate between the tabs.
Closes #4687

Type of change :

[x] Improvement

Frontend Preview (Screenshots) :

https://user-images.githubusercontent.com/58542468/174755012-c1ecb177-f545-4a3d-8156-cbf3f349d5ed.mov
Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@open-metadata/ui

@harsh-vador, Please revert the package-lock.json and yarn-lock changes.

cc @devyani-kaushik @harshach
Please check if the styling looks good for "My Data" and "Following" data

@harsh-vador We should not delete the yarn.lock file. Can you please bring it back?


release 1.6?

@elaatifi I was wondering if you can release v1.6?
I know it does not fulfill all points from the wishlist yet, but can you release v1.6 as is?
The branches keep on diverging more and more at the moment, and imho the refactoring and the dependency updates are already worth it.

please please please


Add a flag that will allow enabling the view only view of a program

Description
The feature this flag will guard will allow viewing a program without having to enter edit mode. It is described in the prd:
https://docs.google.com/document/d/1oD8EaFejs6L7_I-LKxt5ixQRFi5gtcTeL6NOwPMahf0/edit?resourcekey=0-76DVYMd4iDDbpA243q6l_Q#
Release notes
N/A
Checklist
General

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[x] Created tests which fail without the change (if possible)
[x] Extended the README / documentation, if necessary

User visible changes
N/A
New Features

[x] Add new FeatureFlag env vars to server/conf/application.conf

N/A:

[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Issue(s) this completes
N/A

General question/suggestion: How do you feel about ReadOnly instead of ViewOnly?  I feel like like "read" is a more commonly understood term. Additionally all of our UI rendering classes are View classes regardless of ReadOnly or not. We also have a patter of using ReadOnly for non-editable in our codebase
https://sourcegraph.com/search?q=readonly+repo%3Aciviform%2Fciviform%24

I've renamed to read only as suggested.
I'll also apply the change to the implemenation of the actual views in the separate PR.

Codecov Report

Merging #3893 (9966405) into main (8913d4e) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #3893      +/-   ##
============================================
- Coverage     80.79%   80.78%   -0.01%
- Complexity     2454     2455       +1
============================================
  Files           297      297
  Lines          9668     9670       +2
  Branches        659      659
============================================
+ Hits           7811     7812       +1
- Misses         1602     1603       +1
  Partials        255      255

Impacted Files
Coverage Δ

server/app/featureflags/FeatureFlags.java
92.00% <50.00%> (-3.66%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Revert parallelization of app and logic tests

These commits seem to have caused some wonkiness, and I'm not sure if it's worth digging into right now.

So sad :crying_cat_face:


Fixed source codes listing

Description
Fixed source codes listing
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing steps
Done on CI
Checklist

[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary

Codecov Report
Base: 89.43% // Head: 89.43% // No change to project coverage :thumbsup:

Coverage data is based on head (bb2523f) compared to base (a55d0a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   89.43%   89.43%
=======================================
  Files          14       14
  Lines         388      388
=======================================
  Hits          347      347
  Misses         31       31
  Partials       10       10

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Drop trigger throws error #1113 - added table id to the trigger and u…

…sed this when dropping the trigger to remove the trigger from the tables
Thank you for the time you are putting into AlaSQL!

@garynewelluk Thank you!

Fix #1113


Practice 4 - lanelet2_global_planner - sync goal point and path ending

Currently, you have not implemented the last task from the practice 4 - Sync the goal point location with the path ending location!

Please describe briefly what is your solution
Ipmlement it in the code

Comments to the implementation

There is slight inefficiency. When distance_to_goal is smaller than distance - no waypoints are added any more, but still the above "for" loop calculates all the distances for the rest of the waypoints.
https://github.com/jaak-peterson/autoware_mini_practice/blob/8136687018f903b9cee09250bd1b6d785b69cf3b/practice_4/nodes/planning/global/lanelet2_global_planner.py#L139-L143

You are not assigning the speed to goal_waypoint and it results it to be 0. We could argue here if that is correct or not, but currently we will leave speed handling and stopping at path end for the local planner. So here you should add also the speed, otherwise it will slow down to very low speed already being far away of the last waypoint, simply because there are no intermediate waypoints on the map.

Not asking you to correct it now, but just a comment. There are four for loops all together in the lanelet_to_waypoints function. Oviously there has to be a more compact and simpler way to do it!

It seems to work, but especially this line is way too complicated!
https://github.com/jaak-peterson/autoware_mini_practice/blob/d5e11e765d962cfe8e2896618da3ddcb2e42be6b/practice_4/nodes/planning/global/lanelet2_global_planner.py#L115
Next time could brake down to smaller pieces or add some explanations.


Public api

New Library to use in .NET projects: XstReader.Api
XstExport changed to XstExporter
Some improvements in XstReader and XstExporter

PR merged in my fork: iluvadev/XstReader
XstReader now is also a Nuget package to read ost and pst files from .NET without Outlook. The ussage is simple


Occasional panic when using RenderTarget::Image

When using RenderTarget::Image on a camera, bevy sometimes panics:
thread 'main' panicked at 'view entity should exist: QueryDoesNotMatch',
[...]\crates\bevy_core_pipeline\src\main_pass_2d.rs:45:14

This seems like a system ordering issue where ViewTarget ends up not being created for the view.
bevy version: main b6a647cc013861b182be5f4c85b60b2709388210

minimal test project
use bevy::{
    prelude::*,
    reflect::TypeUuid,
    render::{
        camera::RenderTarget,
        render_resource::{
            Extent3d, TextureDescriptor, TextureDimension, TextureFormat, TextureUsages,
        },
    },
};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .insert_resource(Msaa { samples: 1 })
        .add_startup_system(setup)
        .run();
}

// This handle will point at the texture to which we will render in the first pass.
pub const RENDER_TARGET_HANDLE: HandleUntyped =
    HandleUntyped::weak_from_u64(Image::TYPE_UUID,<PHONE_NUMBER>2009864029);

fn setup(mut commands: Commands, mut images: ResMut<Assets<Image>>) {
    let render_target_size = Extent3d {
        width: 512,
        height: 512,
        ..Default::default()
    };

    // This is the texture that will be rendered to.
    let mut render_target = Image {
        texture_descriptor: TextureDescriptor {
            label: None,
            size: render_target_size,
            dimension: TextureDimension::D2,
            format: TextureFormat::Bgra8UnormSrgb,
            mip_level_count: 1,
            sample_count: 1,
            usage: TextureUsages::TEXTURE_BINDING
                | TextureUsages::COPY_DST
                | TextureUsages::RENDER_ATTACHMENT,
        },
        ..Default::default()
    };

    // fill image.data with zeroes
    render_target.resize(render_target_size);

    let render_target_handle = images.set(RENDER_TARGET_HANDLE, render_target);

    let mut camera = OrthographicCameraBundle::new_2d();
    camera.camera.target = RenderTarget::Image(render_target_handle.clone());
    commands.spawn_bundle(camera);
}

looks like #3917 might help with this issue

Additional info:
This happens because view::prepare_view_targets gets run in parallel to render_asset::PrepareAssetSystem<Image>, which causes the view to be prepared when the render target image hasn't been prepared yet.
As a temporary fix I added a label to PrepareAssetSystem and called .after on the other one.

I believe this can be closed thanks to https://github.com/bevyengine/bevy/pull/3917 being merged.


Added new Candle effect - like those fake flickering led candles

1. Tell us something about your changes.
2. If this changes affect the .conf file. Please provide the changed section
3. Reference an issue (optional)
Note: For further discussions use our forum: forum.hyperion-project.org

Oh, sounds nice.
Do you want to add a effect schema?

I do, but right now it can parse the effect args looking for a list, a number or a string.
Does the schema support multiple data types ?

You mean for example a integer or string for the same option? Not yet. But would be hard to display this in an ui. As you never know when the field should be type=number, type=text, or a select. A meaningfull input type helps a lot. As numbers have spinners for mouse cursors and on touch the number keyboard opens instead text. Selects open a modal to select from instead typing text in a textfield.

+# candles can be :
 +# a single led number, a list of candle numbers
 +# "all" to flicker all the leds randomly
 +# "all-together" to flicker all the leds in unison

So the solution for this would be something like this:
select : all, all-together, single
text : single led(s)
if (single) use textfield.val()
Connecting code and ui 1:1 could have weird results. I think there is something like dependency available to hide options. There are other effects that should make use of it too.
It is possible that we fail during schema check, if there is something missing. Not sure. Will test

Agree on the solution - if the text field can be empty from a schematic perspective we're all good.
I can parse the text field for commas or spaces in python

There is no form of hide/show fields depending on another fields value. Funny that such a mandatory function is not available. But crazy support to watch fields and copy content of them.

I'm nearly done on the schema - most is eorking.
where is the l10n catalog ?

Merge me please ?

Would be hard with this distance :)
Ah! wonder why police stopt working

So after some testing...
Very nice :+1:
Would appreciate more of this. (As our effect list regarding 'mood' is not that long and some of these effects are just weird :D)

Thanks for the feedback, Glad you like it!
It got me thinking we needs some online help... I'll open a separate issue


"Cannot find bucket" only when specifying S3 endpoint, otherwise works

I'm getting the following error ONLY when I try to specify S3 endpoint for cloud storage. If I don't specify an endpoint, it works fine, so the problem is not the bucket name or the credentials.
Validation error
Cannot find bucket **** in S3
Version: 1.7.2

The URL I'm providing for the endpoint looks like this
http://****.s3-website.eu-central-1.amazonaws.com

I have static website hosting enabled on the bucket in order to get an endpoint URL. When I try to curl one of the objects from the terminal it works, so the issue is not the endpoint URL either.
Is it possible that this is a bug with Label Studio?
Thanks

If you use common s3 storage, you don't need to provide endpoint in source cloud settings. Why do you try to do it?

If you use common s3 storage, you don't need to provide endpoint in source cloud settings. Why do you try to do it?

Just for convenience. When I export COCO json, images have s3:// URLs. I would like them to have the endpoint URL instead.

Endpoint url is needed when you host your own s3-like cloud storage and you want to provide a path for it.


V0p1p12b

Codecov Report

Merging #27 (e1c96a8) into master (9527916) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   80.43%   80.43%
=======================================
  Files           4        4
  Lines         598      598
=======================================
  Hits          481      481
  Misses        117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9527916...e1c96a8. Read the comment docs.


Home screen UI

Implemented Home Screen UI following design on Figma

command ./gradlew staticAnalysis is failing. Fix those issues as well