[Bug] Variables in message are not getting evaluated before pushing to webhook/ui

We are using policy-reporter to push policy-violations to a service which then handles the further processing and making sure the owner of the violating resource is informed about the violation.
For this we are adapting our kyverno policies to include some metadata in the violation message.
This has always worked fine in the past (kyverno chart version: 2.7.0, kyverno version: v1.9.0 and policy-reporter chart version: 2.13.0)
After upgrading to the latest versions for kyverno and policy-reporter this functionality no longer works.
Policy-reporter pushes the message as is to the configured endpoint without first replacing the variable in {{}}.
Here is a policy to test this with:
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  annotations:
    policies.kyverno.io/severity: high
    policies.kyverno.io/title: Disallow host namespaces
  name: disallow-host-namespaces
spec:
  admission: true
  background: false
  failurePolicy: Fail
  rules:
  - exclude:
      resources: {}
    generate:
      clone: {}
      cloneList: {}
    match:
      resources:
        kinds:
        - Pod
    mutate: {}
    name: host-namespaces
    validate:
      message: |
        Sharing the host namespaces is disallowed. The fields spec.hostNetwork, spec.hostIPC, and spec.hostPID must not be set to true. test:{{request.object.metadata.annotations.test||'none'}}
      pattern:
        spec:
          =(hostIPC): "false"
          =(hostNetwork): "false"
          =(hostPID): "false"
  validationFailureAction: Enforce
  webhookTimeoutSeconds: 15

and the following pod to test the validation:
apiVersion: v1
kind: Pod
metadata:
  name: test
  labels:
    app: test
  annotations:
    test: https://example.com/some-url/1
spec:
  hostNetwork: true
  containers:
    - name: bad-hostnetwork
      image: docker.io/library/nginx
      imagePullPolicy: IfNotPresent
  restartPolicy: Always

Applying this pod against a cluster where kyverno is installed gives the following message:
kubectl apply -f test.yaml -n default
Error from server: error when creating "disallow-host-namespaces/host-namespaces/fail.yaml": admission webhook "validate.kyverno.svc-fail" denied the request:

resource Pod/default/bad-hostnetwork was blocked due to the following policies

disallow-host-namespaces:
  host-namespaces: |-
    validation error: Sharing the host namespaces is disallowed. The fields spec.hostNetwork, spec.hostIPC, and spec.hostPID must not be set to true. test:https://example.com/some-url/1
    . rule host-namespaces failed at path /spec/hostNetwork/

While the push to the endpoint looks like this:
{"message":"Sharing the host namespaces is disallowed. The fields spec.hostNetwork, spec.hostIPC, and spec.hostPID must not be set to true. buildUrl:{{request.object.metadata.annotations.test||'none'}}\n","policy":"disallow-host-namespaces","rule":"host-namespaces","priority":"error","status":"fail","severity":"high","category":"Pod Security Standards (Default)","scored":false,"properties":{"eventName":"disallow-host-namespaces.17a28fa7ec924b5e","resultID":"33991761c902176dd731f6f5b4a88822d330874d","time":"0001-01-01T00:00:00Z"},"resource":{"apiVersion":"","kind":"Pod","name":"test","namespace":"default","uid":""},"creationTimestamp":"0001-01-01T00:00:00Z","source":"Kyverno Event"}

Hey, I have a look. At the first view I think this is more related to Kyverno, which is responsible for the evalutation. Policy Reporter just use the evailable text from the reports.
In case of the blockReport feature of the plugin, it uses the K8s events as source, which is also produced by Kyverno.
cc @eddycharly @realshuting do you know recent changes which could lead to this issue?

Hi, is there anything I could do to help this get resolved.
Should I be looking at the policy-reporter code or kyverno? Thanks

hey, I reached out to @eddycharly, it will be most likely an issue in Kyverno because Policy Reporter just shows information from Kyverno / Policy Reports / Events and does no Variables evaluation on its own.

I tested this policy in Audit mode and the variable was resolved correctly in the policyreport, I'm using v1.12.0-alpha.2:
✗ k get polr -o yaml | grep message -A2
  - message: |-
      validation error: Sharing the host namespaces is disallowed. The fields spec.hostNetwork, spec.hostIPC, and spec.hostPID must not be set to true. test:https://example.com/some-url/1
      . rule host-namespaces failed at path /spec/hostNetwork/

@franznemeth - can you help verify with the latest version?

Hi, sadly I'm still facing the same issue on v1.12.0-alpha.2.
We managed to fix the issue though and it had nothing to do with kyverno itself.
In our policy-reporter values.yaml we had the following things set:
replicaCount: 1
kyvernoPlugin:
  enabled: true
global:
  plugins:
    kyverno: true

Leaving both keys on false (which is the default) fixes the webhook push and the template gets rendered successfully.
Any ideas why these settings would break the resolving of those variables?

Okay, I think I got it, we are talking about PolicyReports that are not generated from Kyverno, we talk about PolicyReports which are created in the Policy Reporter Kyverno Plugin (https://github.com/kyverno/policy-reporter-kyverno-plugin/blob/main/pkg/policyreport/kubernetes/client.go)
Which creates the message from the Kubernetes event message. If you deactivate the plugin, these PolicyReports will of course no longer be created.
So I assume that the variables might not be resolved in the kubernetes event messages @realshuting

Which creates the message from the Kubernetes event message. If you deactivate the plugin, these PolicyReports will of course no longer be created.

So I assume that the variables might not be resolved for blocked resources in the kubernetes event messages @realshuting
Can we warn in this case if Kyverno is not enabled?

In my latest test with Kyverno v1.12.6 the issue is fixed.


Kafka leader ordering

Hello , I am a little confused with kafka leader ship reordering.
if new_leader is None:
for replica in partition.replicas:
leader_ratio = leaders[replica.id] / replica.num_partitions() -> will this not be most of the times 0 hence it is not balanced. What is the logic behind this ?

@bringhurst  - at mentioning you since you were the last person to comment :)


Expand balance transaction when retrieving an existing charge

Stripe::Charge.retrieve includes balance transaction object if expand: ['balance_transaction'] has been passed into params.
Added spec

I'm trying to understand why Travis build fails. I haven't touched that code:
StripeMock::Instance behaves like Coupon API retrieve coupon cannot retrieve a stripe coupon that doesn't exist
     Failure/Error: expect { Stripe::Coupon.retrieve('nope') }.to raise_error {|e|

       expected: "id"
            got: "coupon"

       (compared using ==)
     Shared Example Group: "Coupon API" called from ./spec/support/stripe_examples.rb:15
     # ./spec/shared_stripe_examples/coupon_examples.rb:57:in `block (3 levels) in <top (required)>'

A spec is:
    it "cannot retrieve a stripe coupon that doesn't exist" do
      expect { Stripe::Coupon.retrieve('nope') }.to raise_error {|e|
        expect(e).to be_a Stripe::InvalidRequestError
        expect(e.param).to eq('id')
        expect(e.http_status).to eq(404)
      }
    end

Live Stripe returns "coupon" type in InvalidRequestError, but mock server returns "id":
      def get_coupon(route, method_url, params, headers)
        route =~ method_url
        assert_existence :id, $1, coupons[$1]
      end

I probably have to setup live testing locally :)

I got the same error when I run tests locally. It happens both in my branch and commit tagged with "v2.4.0".
A hint would be so much appreciated! :)

I also received a similar response from Travis when submitting a pull request that had nothing to do with the coupon code.

please, pull master into your branch

@alexmamonchik done!


feat(ColorMode): Adding "system" option to ColorMode

Overview

PR Checklist

[ ] Related to designs:
[X] Related to JIRA ticket: WEB-1986
[X] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[X] This PR includes testing instructions tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Go to {{URL}?path=/docs/foundations-colormode--page#system-color-mode
Verify new system color mode section accurately reflects the color mode currently active on your computer
Toggle the color mode in your computers system preferences and verify the changes are accurately reflected

PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

📬Published Alpha Packages:@codecademy/gamut-icons@7.4.1-alpha.661107.0@codecademy/gamut-illustrations@0.28.1-alpha.661107.0@codecademy/gamut-kit@0.6.153-alpha.661107.0@codecademy/gamut-labs@32.4.1-alpha.661107.0@codecademy/gamut-patterns@0.8.7-alpha.661107.0@codecademy/gamut-styles@13.2.1-alpha.661107.0@codecademy/gamut-tests@4.0.6-alpha.661107.0@codecademy/gamut@48.0.7-alpha.661107.0@codecademy/markdown-overrides@0.9.4-alpha.661107.0@codecademy/monaco@0.6.56-alpha.661107.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-icons@7.4.1-alpha.e00b8d.0@codecademy/gamut-illustrations@0.28.1-alpha.e00b8d.0@codecademy/gamut-kit@0.6.153-alpha.e00b8d.0@codecademy/gamut-labs@32.4.1-alpha.e00b8d.0@codecademy/gamut-patterns@0.8.7-alpha.e00b8d.0@codecademy/gamut-styles@13.2.1-alpha.e00b8d.0@codecademy/gamut-tests@4.0.6-alpha.e00b8d.0@codecademy/gamut@48.0.7-alpha.e00b8d.0@codecademy/markdown-overrides@0.9.4-alpha.e00b8d.0@codecademy/monaco@0.6.56-alpha.e00b8d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62c4717d3831103eb9d9b839--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@7.4.1-alpha.ee545b.0@codecademy/gamut-illustrations@0.28.1-alpha.ee545b.0@codecademy/gamut-kit@0.6.153-alpha.ee545b.0@codecademy/gamut-labs@32.4.1-alpha.ee545b.0@codecademy/gamut-patterns@0.8.7-alpha.ee545b.0@codecademy/gamut-styles@13.2.1-alpha.ee545b.0@codecademy/gamut-tests@4.0.6-alpha.ee545b.0@codecademy/gamut@48.0.7-alpha.ee545b.0@codecademy/markdown-overrides@0.9.4-alpha.ee545b.0@codecademy/monaco@0.6.56-alpha.ee545b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62cdcfb490c9d5006c95be33--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@7.4.1-alpha.f46e91.0@codecademy/gamut-illustrations@0.28.1-alpha.f46e91.0@codecademy/gamut-kit@0.6.156-alpha.f46e91.0@codecademy/gamut-labs@32.6.1-alpha.f46e91.0@codecademy/gamut-patterns@0.8.7-alpha.f46e91.0@codecademy/gamut-styles@13.2.1-alpha.f46e91.0@codecademy/gamut-tests@4.0.6-alpha.f46e91.0@codecademy/gamut@48.0.7-alpha.f46e91.0@codecademy/markdown-overrides@0.9.4-alpha.f46e91.0@codecademy/monaco@0.6.56-alpha.f46e91.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62cf117bf3a67d2286853815--gamut-preview.netlify.appDeploy Logs


Fix the file created by Composer

Thanks @santisaez! This fix will be in the next version of the book, credited to you.


Recipe for installing python or-tools with SCIP on macOS

I tried this a few months ago, with no success. The need has come up again, so I want to definitely solve this problem. I used the recipe below for installing from source:
Preliminaries (on Mac):

Uninstall all previous versions of or-tools
Install the latest version of the command line tools for XCode (the full XCode isn't necessary).
Install javac. To install javac, just run javac. This will download and install Java.
Install cmake. To install cmake, download the official .dmg archive from http://www.cmake.org/download.

Installation:

Copy scipoptsuite archive in dependencies/archives. Make sure the version matches the one in the third_party makefile.
make third_party
make install_python_modules
make python
make test_python

When I run the test, I get the error ImportError: No module named _pywrapcp. Do you know what I should do to resolve this issue?
P.S. Once this is solved, I will post on the discussion board so that there is a record for others to follow. Thanks in advance for the help.

I still refer back to this closed issue thread every time I install:
https://github.com/google/or-tools/issues/63
although it does not specifically deal with SCIP it still works form python3 on OS X.

By the way, I'm using Python 2.7.12 and macOS Sierra 10.12.1

When I run make test_python, I get the following output:
[Tones-Lappy]~/Desktop/demos/or-tools-5.0 $ make test_python
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
PYTHONPATH=/Users/Antonio/Desktop/demos/or-tools-5.0/src:/Users/Antonio/Desktop/demos/or-tools-5.0/dependencies/sources/protobuf-3.0.0/python python2.7 examples/python/hidato_table.py
Traceback (most recent call last):
  File "examples/python/hidato_table.py", line 27, in <module>
    from ortools.constraint_solver import pywrapcp
  File "/Users/Antonio/Desktop/demos/or-tools-5.0/src/ortools/constraint_solver/../../gen/ortools/constraint_solver/pywrapcp.py", line 21, in <module>
    _pywrapcp = swig_import_helper()
  File "/Users/Antonio/Desktop/demos/or-tools-5.0/src/ortools/constraint_solver/../../gen/ortools/constraint_solver/pywrapcp.py", line 20, in swig_import_helper
    return importlib.import_module('_pywrapcp')
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
ImportError: No module named _pywrapcp

Are you compiling from a clone/fork of the git repository, or from a downloaded release such as from here: https://github.com/google/or-tools/releases/tag/v5.0? I think it is expecting to be a clone of a git repository, but I am not sure why.

I compiled from the original repo release

Also, if I run check_python_deps.py, I get:
[Tones-Lappy]~/Desktop/demos/or-tools-5.0 $ python tools/check_python_deps.py
INFO:root:Python path : /Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python
INFO:root:Python version : 2.7.12 (v2.7.12:d33e0cf91556, Jun 26 2016, 12:10:39)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)]

INFO:root:or-tools version : VVVV
INFO:root:/Users/Antonio/Desktop/demos/or-tools-5.0/src/ortools/__init__.pyc

INFO:root:protobuf version : 3.1.0.post1
INFO:root:/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/google/protobuf/__init__.pyc


[dev] display stack trace in monospace

Babel and other compilers omit nice error messages, but those messages
rely on the pre-wrap spacing behavior of a monospaced terminal.
This commit changes the development mode plugin to emit stacks in a
pre-like block. It also html_escapes the stack trace to prevent strange rendering errors that sometimes occur if the error contains <html>.

@ljharb @gdborton @goatslacker

LGTM


Cleanup pkgs/top-level/python-packages.nix

Motivation for this change
This batch is continuation of   #27497, #27379
Things done

[X] Tested using sandboxing : nix.useSandbox on NixOS
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[X] Tested installation :  tested using this scripts
[X] Fits CONTRIBUTING.md.

Thanks!

Thanks a lot @wizzup!


Fix build if cli path contains spaces

is this really needed? cmake should already deal with it
(this is without the pr changes)

cant repro.. theres also like 10 other uses of ${GEODE_CLI} like that if you really wanted to fix it

I think this is worth merging since it fixes an issue someone had and doesn't break other people's stuff

If this PR fixed Config's issue then yeah apparently

i have no idea why it breaks in specifically that place specifically for me but adding those quotes indeed fixes the issue for m- what the hell it's working now???? nevermind then i guess, sorry lmao


java.lang.IncompatibleClassChangeError: Structural change of android.support.v4.app.Fragment is hazardous ...

This erro is reproducible by following the codelab instructions after moving classes from "topeka-base" to "topeka-ui", as well as using the latest code of "complete" branch. It's also reported by a developer as a comment under thje I/O video.
The culprit is that topeka-base and topeka-ui are using different versions of the support library, therefore causing the incompatibility error.
The fix is simply use the same version of support library in topeka-ui’s gradle file. Something like:
...

ext {
supportLibVersion = “25.0.0”
}

dependencies {
compile “com.android.support:appcompat-v7:${supportLibVersion}”
compile “com.android.support:cardview-v7:${supportLibVersion}”
compile “com.android.support:design:${supportLibVersion}”
compile “com.android.support:recyclerview-v7:${supportLibVersion}”

api project(‘:topeka-base’)
}

Try this,
Change android.support.v4.app.Fragment to android.app.Fragment.
In my case its working.

thanks for reporting this. Should be fixed with d4dfdc8fe1f405b842b082f0e59580a58206f8f1


HHH-13705 Enhancement as Proxy with inline dirty checking - flush of an @ManyToOne with an Embedded value having not null properties causes PropertyValueException

https://hibernate.atlassian.net/browse/HHH-13705
An example is https://github.com/hibernate/hibernate-orm/compare/master...dreab8:HHH-13705?expand=1#diff-3e7d7f46b89f78dfa756348772394254
when the User is loaded the associated Client results having  fields that are marked as dirty in the dirtyness tracker, this happens when the Client is instantiated.
For User the fields that are marked as dirty in the dirtyness tracker are cleared when PojoEntityTuplizer#afterInitialize calls ( (SelfDirtinessTracker) entity ).$$_hibernate_clearDirtyAttributes();
this causes an update during the flush.
I hope my explanation is not too messy ;)

rebased and merged upstream.
Thanks @gbadner and @sebersole  for the reviews


fix(ui): fix validation in targeting rule

@bimalgrg519
I checked your last commit. Can you make not reset the values when we select the same type?
1- Select the Compare type and set its values
2- Select the Compare again, and the current values will be reset
If we select the same type, it shouldn't do anything.

@bimalgrg519
When I add a rule, it doesn't select the operator for the first condition.
If I add a second condition, it selects it.
Can you fix it?

@bimalgrg519
When I delete a rule, the Save with comment button keeps disabled. Can you take a look?
http://localhost:8000/development/features/feature-flag-string/targeting

@bimalgrg519
When I change the values in the condition, the Save with comment button becomes enabled as it should be, but if I revert the changes by putting back the original values, the button keeps enabled. It should be disabled because there are diffs.
It happens for all types. Can you take a look?
Also, when I select the same segment from the select menu, it enables the button. It shouldn't enable because the data is still the same.

@bimalgrg519
I found another issue when I delete the first condition from the rule.
If you delete the user segment condition, the page will become blank.
http://localhost:8000/development/features/feature-flag-string/targeting

@bimalgrg519
When I add and delete a new rule, it enables the save button. Can you take a look?
How to reproduce
http://localhost:8000/development/features/feature-flag-string/targeting
1- Click on Add rule
2- Delete the new rule
3- Check the save button


Could you enablehttps://try.dot.net/ allow cors?

I am developing an obsidian plugin that allow popular languages  codeblock in markdown can run directly .
Just like this. repo

But https://try.dot.net/ didn't allow cors.

It is very convenient to use markdown to take study notes of the code, and then the code can also be run directly to see the results.

As an obsidian user, I want .NET code to run as well.


Allow tf.GradientTape.batch_jacobian to accept containers of tensors as source

Click to expand!
Issue Type
Feature Request
Source
binary
Tensorflow Version
tf 2.8.2
Custom Code
No
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
At the moment, containers of tensors are supported by `tf.GradientTape.jacobian`, but not `tf.GradientTape.batch_jacobian`.

If this behavior was allowed in `batch_jacobian`, I would expect it to return the same container with tensors equal to the `batch_jacobian` of `target` with respect to each tensor in the `source` container.

Example expected output shown in the colab.

Standalone code to reproduce the issue
https://colab.research.google.com/drive/1RTv34VMa-joB45x7xu-9H3pdSTnDAj72?usp=sharing

Relevant log output
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-7-5c1f96355dc5> in <module>()
      6     pred = my_model(x, training=False)[:, :, 0]
      7
----> 8 j = tape.batch_jacobian(pred, x)

/usr/local/lib/python3.7/dist-packages/tensorflow/python/eager/backprop.py in batch_jacobian(self, target, source, unconnected_gradients, parallel_iterations, experimental_use_pfor)
   1287       dim = target_shape.dims[0]
   1288     if not (target_shape.with_rank_at_least(2) and
-> 1289             source.shape.with_rank_at_least(2) and
   1290             dim.is_compatible_with(source.shape[0])):
   1291       raise ValueError(

AttributeError: 'dict' object has no attribute 'shape'

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


[topic page] Add climate equity charts

add climate equity scatter charts
update topic pages to remove empty charts

North Carolina:

Wayne County:

Nice! Are the screenshots not lining up with the config?

how so?

I see Gaussian Mixture as the variable name, but the config has the histogram based one.

The variable name is set in the config as well .. so for the temperature variable, what is the stat var dcid and what is the name we should use for it?

Ah, I missed that.  That should be fixed then.

Couple of questions (no need for changes unless its really trivial :):

Is there a way to add place-type to title?  Right now its not obvious what the dots are.
I'm unable to hover over the dots, like on NL scatter plots. Is that ability something that's built in the app (nl vs. topic page) rather than something that the tile impl provides?


chore: use object and relation only in expand

Description

References

Review Checklist

[ ] I have added documentation for new/changed functionality in this PR or in openfga.dev
[ ] The correct base branch is being used, if not main

Will update later.


Remove images from metadata when folder is removed

I removed some folders from the folders list, but the image thumbnails were still in the metadata.
There should be an option to remove images from the database if the folder is removed.

Thanks, I've added a tool to manually remove images from removed folders, as well as automatically remove images when a folder is removed.

Thank you for the super fast update!


Proposal: Make this use docker-donejs

Better maintain able less problems

Blocking

this needs to wait for https://github.com/donejs/docker-donejs/issues/1
and that waits for https://github.com/donejs/donejs-vagrant/issues/3 wich is part of https://github.com/donejs/donejs/issues/998

feel free for make a PR ;)


Pull fails when switching networks

When switching networks, I have to restart my virtualbox docker-machine.
Here's someone else experiencing the same issue
http://stackoverflow.com/questions/24390329/cant-pull-docker-image-no-route-to-host
Here's the error message
Get https://index.docker.io/v1/repositories/library/mysql/images: dial tcp: lookup index.docker.io on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:53: i/o timeout

After running
docker-machine restart dev

Running docker pull starts working again

Sorry for the issue.  Unfortunately, this is related to VirtualBox and it's resolution lookup and not much we can do I think.  What you did is the fix.  Thanks for reporting.


ROX-9450: Removing classic policies code

Description
As the title suggests. Removed dead code in Violations detail page as well for the old way of showing policy details. Sorry for the big PR -- it's all deletes and moves, I swear!
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on stackrox/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

The Dashboard Search/URL cleanup I'm doing leads down a long path that ends with a reducer that is only used in this dead code.
Commenting just to keep an eye out so I can rebase and delete more once this is merged.

@alwayshooin failing integration test borrows a selector for classic policies wizard, but behavior is still correct
https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/cypress/integration/vulnmanagement/policiesListpages.test.js#L40-L42
Classic page before removal

PatternFly page after removal

@alwayshooin It looks like a leftover absolute path to PatternFly folder might become relative path to new location:
Failed to compile.
src/Containers/Policies/Table/PoliciesTable.tsx
Cannot find module: 'Containers/Policies/PatternFly/Modal/EnableDisableNotificationModal'.


Migrate synthetic data generation from iris-ugrid

🚀 Pull Request
Description

For original review, see SciTools-incubator/iris-ugrid#38.
I'm keen in future to extend this beyond UGRID-NetCDF files, as the pattern is very useful for good benchmark coverage.

Consult Iris pull request check list

Thanks @pp-mo !


Correct Example for soundName

Question
It is unclear from the documentation what type of value to pass to soundName parameter when creating a push with scheduleLocalNotification. I have my file in assets/bubble.wav so I have tried various permutations such as bubble, bubble.wav,  assets/bubble.wav, and assets/bubble. Can anyone clarify? Does it need to be a file asset? Thank you!
const details = {
    fireDate: sendTime,
    alertTitle: title,
    alertBody: message,
    isSilent: false,
    userInfo: data,
    soundName: 'bubble',
    // applicationIconBadgeNumber: 69,
  };
  logger.info(`sending local notification: ${JSON.stringify(details, '  ', '  ')}`);
  PushNotificationIOS.scheduleLocalNotification(details);

@objectiveSee Do oyu manage to find out what are the format type required here? Thank you.

There's now a sample for using sound in the example repository :tada:


Unable to Create Container Using Docker Compose on Portainer 1.24/0

Error is raised whenever I attempt to create a container via Portainer 1.24.0 Web Editor or Upload. The issue is not restricted to the sample Compose script but occurs with other scripts
Error received is:
http error: Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \"process_linux.go:396: setting cgroup config for procHooks process caused \\\"failed to write 0 to memory.swappiness: write /sys/fs/cgroup/memory/docker/3c396f7ce8e2a007c8be2db1b2f3cdb3d7a2ea873fd1e18aa1ef9dbcdd3d87c2/memory.swappiness: invalid argument\\\"\"": unknown (err=Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \"process_linux.go:396: setting cgroup config for procHooks process caused \\\"failed to write 0 to memory.swappiness: write /sys/fs/cgroup/memory/docker/3c396f7ce8e2a007c8be2db1b2f3cdb3d7a2ea873fd1e18aa1ef9dbcdd3d87c2/memory.swappiness: invalid argument\\\"\"": unknown) (code=500)

Attempted using following Compose script:
version: '2'
services:
    server:
        container_name: Bitwarden
        restart: unless-stopped
        network_mode: bridge
        environment:
            - SMTP_Password='password'
            - SMTP_HOST=mail.domain.com
            -<EMAIL_ADDRESS>            - SMTP_PORT=587
            -<EMAIL_ADDRESS>            - DOMAIN=https://sub.domain.com
            - SIGNUPS_DOMAIN_WHITELIST=domain.com
            - ADMIN_TOKEN=true
            - WEBSOCKET_ENABLED=true
        volumes:
            - '/volume1/docker/appdata/bitwarden:/data:rw'
        ports:
            - '3012:3012'
            - '8343:80'
        logging:
            driver: syslog
            options:
              syslog-address: 'udp://<IP_ADDRESS>:514'
              syslog-format: 'rfc5424'
              tag: '{{.Name}}'
        image: 'bitwardenrs/server:latest'

Technical details:

Portainer version: 1.24.0
Target Docker version (the host/cluster you manage): 18.09.8
Platform (windows/linux): Linux (Synology)
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer):
Target Swarm version (if applicable): N/A
Browser: Firefox

Closing as a duplicate of #2576
@MJCunliffe as a workaround you need to include mem_swappiness: -1 # temp workaround in your stack definition like so:
version: '2'
services:
    server:
        container_name: Bitwarden
        restart: unless-stopped
        network_mode: bridge
        environment:
            - SMTP_Password='password'
            - SMTP_HOST=mail.domain.com
            -<EMAIL_ADDRESS>            - SMTP_PORT=587
            -<EMAIL_ADDRESS>            - DOMAIN=https://sub.domain.com
            - SIGNUPS_DOMAIN_WHITELIST=domain.com
            - ADMIN_TOKEN=true
            - WEBSOCKET_ENABLED=true
        volumes:
            - '/volume1/docker/appdata/bitwarden:/data:rw'
        ports:
            - '3012:3012'
            - '8343:80'
        logging:
            driver: syslog
            options:
              syslog-address: 'udp://<IP_ADDRESS>:514'
              syslog-format: 'rfc5424'
              tag: '{{.Name}}'
        image: 'bitwardenrs/server:latest'
        mem_swappiness: -1 # temp workaround


Being able to choose the texture-atlas sprite index over time

Looking at your example texture-atlas sprite-sheet, it looks like it could be useful to have another way to choose the TextureAtlas index: have it change over the time elapsed in the particle.
(for example for some 'explosion' particle that turns into a cloud of dust).
I'm guessing the input would be a Vec<f32, usize>:

the first number if the percentage of the particles life (between 0.0 and 1.0)
the second number is the sprite index to use between the current percentage and the next

(maybe a better data structure would be more appropriate)

@cBournhonesque That's a good idea. Btw, that's pretty much exactly how the Gradients work, with the only difference being that it lerps between the current and next value instead of just choosing the current.
As far as implementation, another option would be to go with a pattern closer to traditional sprite animation like this: https://bevyengine.org/examples/2d/sprite-sheet/ and just have it rotate between the values with an even timeframe. This is probably a bit more efficient, particularly if there are many frames in a particles animation since the stated approach requires a linear-time iteration through the potential indexes each frame. The gradients technically have this problem as well. If you were to use a system with a gradient that had a ton of states, you'd probably start to see a performance impact, particularly at high particle counts. I don't know how common of a use case that would be though.
I would guess the average use case would be that the lists are small, like 2-5 states. In that case, the linear iteration is likely not an issue until you're into the thousands of live particles (depending on hardware).
The usability tradeoff would be that it'd be a little bit easier to define using the animation timer. You can specify the indices and a single frame time. But then all of your frames have to be displayed evenly.
It also means using fixed timing instead of it adapting to the lifetime of the particle. Which I'm not sure which is better, in that regard, as animations often need pretty specific timing to look right, and having to mess with percentages and lifetimes may be a bit of a pain, especially if you have to end up adjusting the lifetime later and need to then recalibrate the percentages, but it is technically less flexible.
In the duration-specified approach, it's a little less ergonomic to set up as you have to specify each frame individually, but you have the customizability if you want it. However I suppose that could be solved with a helper function. But also you can't have a repeating pattern without defining it yourself (which may potentially exacerbate the linear-iteration problem).
Of the two, I'd lean slightly more to the timer route based on potential ergonomics and performance advantage, but open to your thoughts or other ideas as well.

Here is how the new example looks with these modifications !

Closed by #45


Add a few scripts for working with a CAC

Description
In order to work with a CAC you need to use a few tools. This PR adds those tools.
Ideally a person would be able to quickly learn about their CAC and generate a certificate to use with the Orders API.
Setup
First: brew install opensc then:
cac-generate-certificate
cac-generate-fingerprint
cac-generate-pubkey

Testing Orders with your CAC
Use the transcom/nom repo with sample navy orders data
Code Review Verification Steps

[x] Request review from a member of a different team.
[x] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

I just ordered a CAC reader, which I assume is a prerequisite to being able to play with any of these tools. Should be in by the end of the week.

I just ordered a CAC reader, which I assume is a prerequisite to being able to play with any of these tools. Should be in by the end of the week.

You're right, having a reader is a prereq. I was also hoping to make the secure migration stuff a little easier but I've been swamped, which has delayed this PR. I think its in a state where you can generate a secure migration to upload your CAC to the application and then run the transcom/nom repo to upload the orders. But I haven't tested that. So at this point I'm going to recommend not pushing any secure migrations up to the AWS environments.


Run actions/setup-python with python-version input

Also bumps pre-commit reusable actions

Oh, good catch!

As an FYI, new versions of setup-python has builtin caching, so we can get rid of the pip cache step if we set it up.
Thanks for addressing this 👌

As an FYI, new versions of setup-python has builtin caching, so we can get rid of the pip cache step if we set it up.
Thanks for addressing this 👌

Ah, cool, didn't know about that. Sounds great!


Category/Description/Type text at the top of every Action and Condition page

Describe the bug
All "actions" and "conditions" page include an un-formatted line at the top, see for example:

I'm not sure what the purpose of those field is, maybe they should be part of the front matter?
To Reproduce
Steps to reproduce the behavior:

Go to any actions or conditions page, for instance: https://dev.trywilco.com/docs/building-your-quest/actions/newrelic-configure-with-key.html
Look at the top of the page just under the main header

Expected behavior
Either those fields should be hidden or they should be properly formatted (e.g as part of an unordered list)
Screenshots
See above

Thank you for your feedback! The issue was resolved.


Index prefixes

Does any besides me have a use case for dynamically setting prefixes on indexes? We run multiple sites out of one codebase with some key differences being decided by a site variable in the .env.  With the index being set through a property I cannot use an expression (such as config('algolia.index-prefix')) to set it.
This could be accommodated with a  fairly simple change to the code base.  Simply changing the getFinalIndexName() method to the following (or similar):
public function getFinalIndexName(Model $model, $indexName)
{
    $index_prefix = method_exists($model, 'getPrefix') ? $model->getIndexPrefix().'_' : '';
    $env_suffix = property_exists($model, 'perEnvironment') && $model::$perEnvironment === true ? '_'.\App::environment() : '';

    return $index_prefix.$indexName.$env_suffix;
}

If the maintainers are interested in adding this I can submit a pull request.
Thanks!

Alternatively, instead of a method to get the index prefix there could be a indexes() method that allowed the indexes to be set in a method.

I possible implementation would be:
https://github.com/algolia/algoliasearch-laravel/pull/91

Thanks for your PR :)


Playwright: connect over cdp option

Motivation/Description of the PR
I want to use playwright helper with Browserless remote browser service, but it's didn't work for me.
When I change the connection type to connectOverCDP, it works fine.
https://docs.browserless.io/docs/playwright.html#playwrightchromiumconnectovercdpwsendpoint-string
Applicable helpers:

[ ] WebDriver
[ ] Puppeteer
[ ] Nightmare
[ ] REST
[ ] FileHelper
[ ] Appium
[ ] Protractor
[ ] TestCafe
[x] Playwright

Applicable plugins:

[ ] allure
[ ] autoDelay
[ ] autoLogin
[ ] customLocator
[ ] pauseOnFail
[ ] coverage
[ ] retryFailedStep
[ ] screenshotOnFail
[ ] selenoid
[ ] stepByStepReport
[ ] stepTimeout
[ ] wdio
[ ] subtitles

Type of change

[ ] :fire: Breaking changes
[x] :rocket: New functionality
[ ] :bug: Bug fix
[ ] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[ ] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[ ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
[x] Lint checking (Run npm run lint)
[x] Local tests are passed (Run npm test)

Thank you!


Add hook to summarise the schedule

This will make it easier to work out which talks have been rescheduled
so that we can notify people when their talks have changed.

:+1:


Unexpected 'az kusto cluster create' error: local variable 'deserialized' referenced before assignment

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az kusto cluster create Extension Name: kusto. Version: 0.4.0.
Errors:
The command failed with an unexpected error. Here is the traceback:
local variable 'deserialized' referenced before assignment
Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 231, in invoke
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 658, in execute
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 721, in _run_jobs_serially
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 692, in _run_job
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 328, in __call__
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
  File "C:\Users\<username>\.azure\cliextensions\kusto\azext_kusto\generated\custom.py", line 116, in kusto_cluster_create
    return sdk_no_wait(no_wait,
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/util.py", line 678, in sdk_no_wait
  File "C:\Users\<username>\.azure\cliextensions\kusto\azext_kusto\vendored_sdks\kusto\operations\_clusters_operations.py", line 219, in begin_create_or_update
    raw_result = self._create_or_update_initial(
  File "C:\Users\<username>\.azure\cliextensions\kusto\azext_kusto\vendored_sdks\kusto\operations\_clusters_operations.py", line 171, in _create_or_update_initial
    return cls(pipeline_response, deserialized, {})
UnboundLocalError: local variable 'deserialized' referenced before assignment

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az kusto cluster create --resource-group {} --location {} --name {} --sku {} {} {}

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.8.9
Installer: MSI

azure-cli 2.33.1 *

Extensions:
azure-iot 0.13.0
kusto 0.4.0

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

@til10 Thanks for reaching out to us. We are aware of this issue. The Fix for that is planned for release refer PR Azure/azure-cli-extensions#4360. More Info on the similar issue Azure/azure-cli-extensions#4086 and Azure/azure-cli-extensions#4218.
I will update this thread once I have more details on this.

@til10 I am discussing this with the product owners. I will provide an update on this by next week.

@zoharHenMicrosoft Could you please provide an update on the fix once you get a chance ? Awaiting your reply.

Following up with @zoharHenMicrosoft  offline for the update on the fix.

@til10 Apologies for the late reply. The PR Azure/azure-cli-extensions#4625 is still under review phase. We will update this thread once we have done some progress on this. We appreciate your patience on this.

@til10 Apologies for the late reply. We appreciate your patience on this. I see that the above PR has been merged now. Could you please update to the most recent version of the kusto CLI extension (0.5.0) and then run the command again.

az extension update --name kusto

Please let us know if you still face the same issue. Awaiting your reply.

@til10 I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please upgrade to the most recent version of the kusto extension and let us know if you still see the same issue. Awaiting your reply.

@til10 We will now proceed with closure of this github issue. If you see the same issue after upgrading your kusto extension,  please feel free to reopen this thread. We would be happy to help.

I've given the command another try with the latest extension; the bug appears to have been fixed! Thanks all!

@Naveen @.***> Hi, still blocked, I sent an email about the current blocker to Ethan
From: navba-MSFT @.>
Sent: Monday, March 21, 2022 7:37 AM
To: Azure/azure-cli-extensions @.>
Cc: Zohar Hen @.>; Mention @.>
Subject: Re: [Azure/azure-cli-extensions] Unexpected 'az kusto cluster create' error: local variable 'deserialized' referenced before assignment (Issue #4508)
Importance: High
@zoharHenMicrosofthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FzoharHenMicrosoft&data=04|01|zoharhen%40microsoft.com|6f506120940846f23c6208da0afcca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637834378218890687|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=F68JGGKpEtZkl%2Bhgyi9eA9hMceT1GM27w74bkkE4eyE%3D&reserved=0 Could you please provide an update on the fix once you get a chance ? Awaiting your reply.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli-extensions%2Fissues%2F4508%23issuecomment-1073502343&data=04|01|zoharhen%40microsoft.com|6f506120940846f23c6208da0afcca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637834378218890687|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ykjzk78TnvaS%2BM66krRNtxm3pz%2BrT2y9xm6WouI9PQw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOEVBBLJM2DP4BVNUAJKWRDVBADG5ANCNFSM5QHIZPWA&data=04|01|zoharhen%40microsoft.com|6f506120940846f23c6208da0afcca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637834378218890687|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=hJCKRsRL0OIbOPkOsPbBnWy1W55kPjwR0GdHc20cxYE%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|zoharhen%40microsoft.com|6f506120940846f23c6208da0afcca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637834378218890687|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=WQ1rOZ9vh154OiDu2AYuGQJqANRojxqVFZPe5DsJCmU%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|zoharhen%40microsoft.com|6f506120940846f23c6208da0afcca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637834378218890687|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=5OhykXlKpDiMjG25n67sVRq%2Bbuhe%2FTvLrfmbTIgJ5tw%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


[flah_ctrl/dv] Changing Red to Redundancy

Very small PR, changing redundancy related variables & parameters names in flash_ctrl files from red/Red to redundancy/Redundancy.
Signed-off-by: Eitan Shapira<EMAIL_ADDRESS>

Thanks for your pull request. I'll let others approve the PR, but just because I've seen that how a couple times: it should be flash_ctrl, not flah_ctrl :smile: No need to change it for this PR, but for the next ones.

@imphil Thanks for noticing :)
I know of course that it's should be flash_ctrl, I just actually didn't noticed until now that I keep missing that 's'.

Sorry, I should have explained it. I did those changes to sri's request and now I agree with him in fact that this is better, because red is not informative enough. Thanks!

Sorry, I should have explained it. I did those changes to sri's request and now I agree with him in fact that this is better, because red is not informative enough. Thanks!

thanks for the explanation.


The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   80.56%   80.56%
=======================================
  Files          83       83
  Lines        6890     6890
=======================================
  Hits         5551     5551
  Misses       1339     1339

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add kpod tag command

Tag adds one or more tags to an image and is necessary for kpod push

LGTM

Can you add a bats test for this?

Yes, and I'll also fix whatever mistake I just made while rebasing

retest

LGTM

@nalind PTAL

retest

If you pushed an update then there is no need to add retest. It should be retested. Adding a retest will add one more unnecessary test to the queue on jenkins.

LGTM


Caliburn Micro 3.0

Hello, any plans to update ScreenWithModel and the CslaContrib-Caliburn.Micro.WPF NuGet Package to make it work with Caliburn Micro 3.0? The NuGet package still has a dependence to Calburn Micro 1,5.
Thanks

Hello Marcelo,
There is a version for Caliburn.Micro 2.0 but it isn't on NuGet (you have to download the project and build it). This is the first step to take but unfortunately time has limits. Back to your question, As far as I know, there are no contributors willing to port the ViewModel to Caliburn.Micro 3.0. Are you willing to do it?

Are there volunteers to execute this task?


[Storage] Bucket Lock

Do not merge yet.
This code was reviewed in #3709 and #3574

@chingor13 only change since last set of approvals from PRs in description is fixing a typo. Could you approve if you're okay with moving forward?

TY!


Fix typo and follow shellcheck recommendation for SC2086

You had a small, but significant typo in the path to id... :grin:
And I also changed it to follow a recommendation from the shellcheck verifier - to quote the expression.

Thanks for finding and fixing!


There is an error in the chapter picture in the video information

The preview image in the video is correct, but the video information page cannot be loaded, and the request is wrong

It seems that after the .bif is generated, the /config/metadata/library file will be deleted

Are you sure this is the case? I don't believe jellyscrub would cause this to happen, and if it did delete the entire library folder it would also remove the backdrop, poster, and logo images, which doesn't seem to be the case from the image you uploaded.
Can you verify that generating trickplay images for media with currently working chapter images causes the chapters to be removed? Does all media with chapter images exhibit this same behavior or just the one movie?


Remove FIFO from LSU TileLink

This issue tracks a TODO that was specified in a commit message:

This commit adds a tlul_fifo_sync to latch tl_ibex_lsu_h2d, this
needs to be investigated further and resolved for performance reasons.

https://github.com/lowRISC/sonata-system/pull/14/commits/562865cbbac16ef50c32ee5341a2203efa3db75c

This is done now.


Add cupy.interesect1d API

Hi,
This PR aims to add cupy.intersect1d API mention in #6078.
I had used cupy.flatnonzero, unique which have warning of 'may synchronize the device'.
It would be great if someone provides suggestions to improvise it.
Thank You!

Hey, @amanchhaparia!
Will you please take a look at #6402? I'm already working on the same PR :)
Thanks!

Hey, @amanchhaparia! Will you please take a look at #6402? I'm already working on the same PR :)
Thanks!

Yeah sure!
Actually I didn't noticed that since it was not updated on the tracker #6078

Duplicate of https://github.com/cupy/cupy/pull/6402.

Thank you for joining the review process in #6402, @amanchhaparia!


Request to Adjust Button Margin for Property Alignment

What feature or improvement do you think would benefit Files?
I have a request regarding the alignment of the properties button. Would it be possible to modify the button margin to align it with the text? Currently, the margin is set to 8, but I would like it to be 12 to achieve better alignment.
Requirements
Adjust the margin settings to ensure proper alignment with the surrounding text.
Files Version
<IP_ADDRESS>
Windows Version
22H2 22621.1992
Comments
Before

After

Thanks for the report, I've added this to the project board.

@Lukiluc29 do you want to open a pull request with this change?

I ended up fixing this in #13138

I ended up fixing this in #13138

Perfect


Uncaught target signal 6 (Aborted) error on M1 Mac

On Mac OS M1, just wanting to use the docker image directly.
docker pull maestroerror/heif-converter
...
Status: Downloaded newer image for maestroerror/heif-converter:latest
docker.io/maestroerror/heif-converter:latest

Then I put a couple of heic files in my input folder (~/Documents/heic), and make an output folder (~/Documents/jpeg).
~  $ docker run --rm -v /Users/phpguru/Documents/heic:/input -v /Users/phpguru/Documents/jpeg:/output maestroerror/heif-converter heic /input/IMG_5692.heic /output/IMG_5692.jpeg
double free or corruption (out)
qemu: uncaught target signal 6 (Aborted) - core dumped

Am I doing something wrong?

I can enter the container and use it like this
root@31669c971dbe:/app# heif-convert /input/IMG_5692.heic /output/IMG_5692.jpg
File contains 1 image
Written to /output/IMG_5692.jpg

but I was hoping to make use of it directly from docker run on Bash on the Mac side.


We have a policy to build sidecar containers from source code. Since it's not documented, we'll state this policy if necessary.

          We have a policy to build sidecar containers from source code. Since it's not documented, we'll state this policy if necessary.

Originally posted by @satoru-takeuchi in https://github.com/topolvm/topolvm/issues/819#issuecomment-1894783498

Could you fix the subject and the description of this issue? I do not handle such the issue that the title is just a copy-and-pasted sentences from another issue.
Please stop making maintainers pay high communication costs.

@satoru-takeuchi in the context your replied that the project has a policy which is not documented but fairly different than similar other projects. What could have saved some steps would have been opening the issue to track yourself rather than reply.

I'll state the policy about building sidecar containers by our own in the official document.


Should exclude imageReference on VMSS disk attach/detach command request

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

When a VMSS is created using Shared Image Gallery image from a different tenant, any "az vmss disk attach/detach" operation will fail at ARM linked access check. This is because the client CLI use won't have permission in the SIG tenant.
The error message you see will be:
# az vmss disk attach -g MC_adadillirg_adadilliVMSS1_australiaeast --name aks-agentpool-18839145-vmss --instance-id 0 --lun 1 --disk /subscriptions/xxx/resourceGroups/mc_adadillirg_adadillivmss1_australiaeast/providers/Microsoft.Compute/disks/kubernetes-dynamic-pvc-a510e8e8-75be-41f6-acc0-8fab2975184d
Option '--name' has been deprecated and will be removed in a future release. Use '--vmss-name' instead.
The client has permission to perform action 'Microsoft.Compute/galleries/images/versions/read' on scope '/subscriptions/xxx/resourceGroups/MC_adadillirg_adadilliVMSS1_australiaeast/providers/Microsoft.Compute/virtualMachineScaleSets/aks-agentpool-18839145-vmss/virtualmachines/0', however the current tenant 'xxx' is not authorized to access linked subscription 'xxx'.

# az version
{
  "azure-cli": "2.11.1",
  "azure-cli-core": "2.11.1",
  "azure-cli-telemetry": "1.0.5",
  "extensions": {}
}

I think the error is that when do "az vmss disk attach", it would still use "imageReference" field which cause the above error, here is a clean way to use VirtualMachineScaleSetVMsClient.Update to attach one disk, refer to https://github.com/kubernetes/kubernetes/blob/5053063ddb054079aeb04aa191dc6a4929cf2624/staging/src/k8s.io/legacy-cloud-providers/azure/azure_controller_vmss.go#L87-L102
	newVM := compute.VirtualMachineScaleSetVM{
		VirtualMachineScaleSetVMProperties: &compute.VirtualMachineScaleSetVMProperties{
			StorageProfile: &compute.StorageProfile{
				DataDisks: &disks,
			},
		},
	}
...
rerr := ss.VirtualMachineScaleSetVMsClient.Update(ctx, nodeResourceGroup, ssName, instanceID, newVM, "attach_disk")

current vmss data:
    "storageProfile": {
      "dataDisks": null,
      "imageReference": {
        "id": "/subscriptions/xxx/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/1604/versions/2020.08.19",
        "offer": null,
        "publisher": null,
        "resourceGroup": "AKS-Ubuntu",
        "sku": null,
        "version": null
      },
      "osDisk": {
        "caching": "ReadWrite",
        "createOption": "FromImage",
        "diffDiskSettings": null,
        "diskSizeGb": 128,
        "image": null,
        "managedDisk": {
          "diskEncryptionSet": null,
          "storageAccountType": "Premium_LRS"
        },
        "name": null,
        "osType": null,
        "vhdContainers": null,
        "writeAcceleratorEnabled": null
      }
    }
  },

To Reproduce

Expected behavior

Environment summary

Additional context

@qwordy please take a look.

I am fixing it.
https://github.com/Azure/azure-cli/pull/14992

#14924


fix: Only register inequality comparisons for orderable types

Summary:
Inequalities only work with types that are orderable pretty much by definition.
For maps in particular we allow users to call map1 < map2 but it will always throw because the map
type does not support inequalities unless null is treated as a value (which it is not in GenericView's
compare function which is what gets invoked).
This will address https://github.com/facebookincubator/velox/issues/11549 where inequalities on
maps can be generated in fuzzers and result in exceptions.
Differential Revision: D66909744

According to the original PR that added these it was intended to add support for arrays and rows (maps weren't mentioned) so this seems in line with that.
https://github.com/facebookincubator/velox/commit/eaff5006e96a17426d1c8633cf305431b2fe06d4


[qwik] Form data file upload fix for #142

Fixes #142
This still needs to be tested. As it is probably a quick workaround.
I was able to get values and event this way

It looks like it doesn't work for multiple files at once. Still needs more investigation

It looks like we have a fix.
Using this form action:
export const useFormAction = formAction$<SpecialForm>((values: any) => {
    console.log(`server received`, { values });
  },
  {
    validate: valiForm$(SpecialSchema),
    files: ['item', 'items'],
    arrays: ['items'],
  }
);

Schema:
const SpecialSchema = v.object({
  item: v.optional(v.special<NoSerialize<Blob>>(isBlob)),
  items: v.optional(v.array(v.special<NoSerialize<Blob>>(isBlob))),
});

logs:
server received {
  values: {
    item: File {
      size: 1806541,
      type: 'image/jpeg',
      name: '1.jpg',
      lastModified:<PHONE_NUMBER>734
    },
    items: [ [File] ]
  }
}

It looks like I had to use files and arrays separately, as there was no way to distinguish between one file and multiple files.
@fabian-hiller feel free to lint that code, as I wasn't able to do that

Thanks for your research and feedback on this. If you think this is a general fix for #142, please report it there as well.

I am sorry that I have not had time to review and merge this yet. I am still very busy with other things.

Is there anything we can do to push this forward? I've been stuck on<EMAIL_ADDRESS>because of this and it's quite a blocker

I will try review it today or tomorrow.

v0.24.0 is now available


feat: custom tag option for Button component

Button now supports a as string prop which allows for any element tag to be used which replaces the <button> tag
fixes #192
<Button as="span">Custom tag button</button>

:tada: This PR is included in version 0.26.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs: add commit_files table to the schema documentation

Closes #351
Signed-off-by: Manuel Carmona<EMAIL_ADDRESS>

@ajnavarro  the new diagram is already added

@ajnavarro what tool did you use to generate the ER diagram? There was a comment with the code to generate it, right? If we add there also the tool I think it's easier than having to use MySQL workbench and it's better for version control.

@erizocosmico the tool that I use has a 10 tables limit. Now we have 11.

Nvm then

@mcarmonaa the last thing: https://stackoverflow.com/questions/14946161/how-to-draw-relationship-lines-between-columns
To be able to see relationships between columns.

@ajnavarro rebased


What's the purpose of cpu frequency test thread please?

Hi,
what's the purpose of cpu frequency test thread please? Is it only used to detect current CPU frequency? And report error if the frequency is lower than the threshold?
I have checked the cpu frequency and ddr frequency, they are always at there maximum value, is this expected?

压力测试，当然是测试硬件的最大潜能

As above, it's expected that cpu frequency will generally be the max frequency during a stress test, until thermal throttling. The test exists to check that the reported frequency is the actual frequency, as occasionally crystals or PLLs can be defective, or the clocking mechanism in sw works unexpectedly..


Fix duplicate page title bug for single posts

Site name + page title combo is already addressed in https://github.com/Upstatement/timber-starter-theme/blob/master/views/html-header.twig

Thanks @teddybradford !


Prevent spawning a lot of processes when misusing brunch new

Closes GH-1413
It was caused by the use of backticks inside a logger message. When
spawning a growl notification, these caused the shell to start both of
the wrapped commands, resulting in a loop.
Couldn't find a way to properly escape these, so not using them
altogether for now.

@goshakkk yes, surprising indeed. We need to have more behaviour test cases for it.


website updated with certificate

had added necessary changes to the website and also enhances the certificate.

My email -<EMAIL_ADDRESS>@Durgesh4993


run formatter and update to otp25 compatible version

Fixed in #91 :) Thanks for the pull-request ❤


Document use of GitHub action

The documentation should include the requirements:

Checkout before running tag-track.
Configure git author if you want tag-track to create tags.

I have also added new action inputs to automatically configure the git author information. The git author information is reset at the end of the action, restoring its values to ones before tag track action.


Refactor/update operation syntax

Updates the examples to the current flow API.

CI is failing -- @b-butler let me know when this is ready to review (or if help is needed).

@bdice This is failing because the flow PR has yet to be approved or merged.

Whoops. Somehow I thought it had been merged already. I approved https://github.com/glotzerlab/signac-flow/pull/681.

@b-butler Is this PR still needed? The CI has been updated so we should be able to fix it up and merge, or close if not.

@b-butler I wasn't sure if this is ready to review/merge but the current changes look fine to me. Please merge if you're ready.


Code of Conduct

The project is currently missing the Code of Conduct file which is important for open source project
So can I go for it @Abhijit2505

@Tejas1510 , I am assuming you have never contributed to our projects or neither being a part of our organization.
So even if I assign you the issue, how are you going to write a code of conduct for something you are quite a newbie.
Kindly explain first.

Hello @Abhijit2505 Sir
Sorry for the delay
I thought since edualgo is becoming a big organization I thought it would be appropriate if it would have a code of conduct which is important for any open source project.


Adjusted job resource getState() to match specification

Adjusted the getState() function of job resources to match the actual specification (https://test-api.psw-group.de/v1) because it causes an PHP TypeError otherwise.

I released version 1.0.2 with your changes integrated. Thank you for your contribution!


eventName when creating new Event by dragging

hello, i cannot find the name of the event, when i create a new event by dragging into the calendar.
thx for support.

ok i found the event "select" :-)


[SE-0258] Improve backward compatibility of the newer property wrappers implementation

Improve compatibility of the newer property wrappers implementation with the first property-delegate-based implementation. Specifically:

Switch over to @propertyWrapper as the primary attribute name; add deprecated aliases for @_propertyWrapper and @propertyDelegate
Add support for using delegateValue when wrapperValue is not present

@swift-ci please smoke test and merge


How to "Search for a VM" in a subscription

#1
What's the recommended way to search for a VM with name: {string} in a resource group or subscription?
Iterating over all the VMs is time consuming and I'm wondering if there is a better way?
#2
Is there a way to iterate over VMs with specific properties? For example, use "power_state" as a filter to show the list of all "de-allocated" VM for example.
Thanks,
Puneet

[1] There is no direct API exposed in the compute specification for checking the existence of VM using it's name, yes, iterating all VMs is a time consuming operation.
Here is a work around i could think of:

You know the vm name to search for, let it be vmName
List the resource groups in your subscription using azure.resourceGroups().list()
For each resource group rgName, check existence of virtual machine resource vmName using azure.genericResources().checkExistence(rgName, "Microsoft.Compute", "", "virtualmachines" vmName, "2015-06-15")
if exists then fetch the VM using azure.virtualMachines().get(rgName, vmName)

[2] Afaik there is no way to filter VM using power-state, but let me confirm with vm owners.

What if we need regex matching and not exact names? If a subscription has thousands of VMs, iterating over all the VMs, will be super slow.

Azure won't support filtering resources using regex.

Thinking more about this. I understand that you don't want all virtual machines (or it's parent resource-groups) to have same name.
Is it ok to have same prefix for these names (myvm-12, myvm-34 etc)?
if yes then another option we can consider is - set same tag entry (tag-key, tag-value) for all the resource groups that holds virtual machines with same name prefix, then you can use azure.resourceGroups().listByTag(tag-key, tag-value) to list resource groups with this tag. You can also set another tag in each of these resource group that holds name of the virtual machine in it.
foreach(ResourceGroup rg : azure.resourceGroups().listByTag("vm-name-prefix", "myvm-")) {
   VirtualMachine vm = azure.virtualMachines().getByResourceGroup(rg.name(), rg.getTags["vm-name"));
}


maud_lints: replace usage of InternedString by LocalInternedString

refs: https://github.com/rust-lang/rust/pull/49894
closes: #125

Thanks!

Published as maud_lints 0.17.4.


Adding system tests for HappyBase Table.cells() and scan().

LGTM except for the extraneous assertions, which made me wonder if I were misreading something.

LMK what you think of my comments. I'd like to get this merged and wrap up the Happybase system tests (AFAIK only one PR left for those targeting Cloud Bigtable backend).

You can merge as it stands, but maybe follow up with an explanation of why you think those assertions might fail.

I don't think they'll fail. The assertions are there as a sanity check, i.e. we meant this to be true with the literals we created, but we want to make extra double sure.


CEP-78 js SDK

This is superseded by more recent tickets that describe specifically what updates are being made.


Update manifest version

The new version (1.0.33) cannot be installed because the manifest version in the repo needs to be updated too.
See discussion https://discord.com/channels/686053708261228577/840286264964022302/1134838670025818183
Thanks for the quick responses regarding my previous pull requests!

Ah gotcha! I'll fix that rn. Thanks for the PRs!


fix: retain training compensation on edit if apprenticeship still applies (hl-1316)

Description :sparkles:
Previously
Training compensation was left in TODO when edit was introduced. Training compensation entries would get erased when editing application, no matter which field.
Resolution
Edit is now fixed so that application retains calculation's training compensation on edit. Training compensation is only erased if apprenticeship is toggled off.

API branch is deployed to platta: https://helsinkilisa-pr3204.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3204.dev.hel.ninja :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3204.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr3204.dev.hel.ninja :laughing::tada::tada::tada:


Add Archlinuxarm support

I have enjoyed using this for quite some time but lately I migrated to tauri 2.0 for mobile support but now the version of nodejs is far to old. Archlinux arm has much more bleeding edge packages and would solve many issues for many people. I have attempted to use my own baseimage but it has failed each time. It would be appreciated if you can help with this.

Thank you. Please see https://github.com/pguyot/arm-runner-action/blob/main/.github/workflows/test-archlinux.yml for how to build an ArchLinux AARCH64 image.


number inputs need maxlength set

https://www.bugherd.com/projects/110463/tasks/20

Backend range check validation is due in the new year (possibly tied with WTForms integration).

@collisdigital this can be enforced by using the maxlength attribute of an input. Makes sense to add as it will degrade gracefully anyway—just an enhancement for newer browsers.

What should the length be though and is it the same for all inputs?


Configuring allowed_policy_member_domains exceptions for specific projects

Describe the bug
We have some projects in our GCP organization which require allowing allowed_policy_member_domains while we would still need to keep the setting for rest of the projects. The configuration is in terraform.tfvars org_policies_config section.
Can you please advice what would be the recommended way to proceed?
Environment
Terraform v1.9.7

To Reproduce
Install the project.
Expected behavior
The project provides an ability to make an exception to the rule on per project basis.
Result

Closing this, please reopen as a group post.

@ludoo there you go! https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/discussions/2613
Any tips appreciated :)


Flower is always restarting

hi,
i am using the last version of this docker-airflow, and i noticed that flower is always restarting and i don't have acces to the webserver
HTTP/1.1 200 OK
[2016-11-15 16:45:46,526] {init.py:36} INFO - Using executor CeleryExecutor
[2016-11-15 16:45:46,584] {driver.py:120} INFO - Generating grammar tables from /usr/lib/python2.7/lib2to3/Grammar.txt
[2016-11-15 16:45:46,607] {driver.py:120} INFO - Generating grammar tables from /usr/lib/python2.7/lib2to3/PatternGrammar.txt
Traceback (most recent call last):
File "/usr/local/bin/airflow", line 15, in
args.func(args)
File "/usr/local/lib/python2.7/dist-packages/airflow/bin/cli.py", line 576, in flower
os.execvp("flower", ['flower', '-b', broka, port, api])
File "/usr/lib/python2.7/os.py", line 346, in execvp
_execvpe(file, args)
File "/usr/lib/python2.7/os.py", line 382, in _execvpe
func(fullname, *argrest)
OSError: [Errno 2] No such file or directory

I think this issue is related with the fix deployed for issue #48 (pyhton package flower is no more present).
Fix in progress

@puckel i have just find a fix for that.Tested and works
pip install pandas==0.18.1
&& pip install celery==3.1.23
&& pip install airflow[celery,postgres,hive,hdfs,jdbc]==$AIRFLOW_VERSION
like suggested by #48 but install celery before airflow to force this version and install the older version of panda because it seems there is issues with the version 0.19 (like suggested here #45)

New release fix the issue.
Thanks


[T2A3][T3-A4]Cherlynn Cha

@Cherc we hope you can appreciate the need for good SLAP after this "inlining" exercise


Shield changes size when not equipped

see video: https://giant.gfycat.com/AmusingDependableCanvasback.mp4
This in combination with simple dual sheathe and xp32 skeleton with the fixed scripts

on closer inspection my fixed scripts were being overwritten by https://www.nexusmods.com/skyrimspecialedition/mods/60363
This might be the old xp32 issue where stuff would flicker and change size as this patch doesn't seem to include the fixed scripts

XP32 scales it when equipped to match the smaller female hand. Around 0.85 iirc. Just adjust it in the config, equipment view->shield so it affects just the display, do not use gear positioning.


Opened .net core project using MSBuild API has error diagnostics unless run from VS debug

Description
Hi,
I'm trying to open a project using msbuild api (to later use Roslyn in a standalone .net framework program). The code basically does following (I'm attaching actual working programs below):
MSBuildLocator.RegisterDefaults();
var workspace = MSBuildWorkspace.Create();
var project = await workspace.OpenProjectAsync(path);
var compilation = await project.GetCompilationAsync();
var diagnostics = compilation.GetDiagnostics();

When I compile this program with VS and run it at once from cli, the diagnostics contains errors
For example:
C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\UnitTest1.cs(1,7): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\UnitTest1.cs(2,7): error CS0246: The type or namespace name 'Xunit' could not be found (are you missing a using directive or an assembly reference?)
C:\Users\pkruk\.nuget\packages\microsoft.net.test.sdk\16.2.0\build\netcoreapp1.0\Microsoft.NET.Test.Sdk.Program.cs(2,7): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\UnitTest1.cs(6,18): error CS0518: Predefined type 'System.Object' is not defined or imported

But if I debug this program in VS, the diagnostics has no errors!
Steps to reproduce

Unpack ConsoleApp8.zip (solution with .net core application project and .net core UT project)
Unpack RoslynOpenProject.zip (solution with program that uses MSBuild api to open a project provided as argument)
Compile both but do not start debugging
Run RoslynOpenProject with XUnitTestProject1 project, for example:

C:\Users\pkruk\Source\repro\RoslynOpenProject\RoslynOpenProject\bin\Debug>RoslynOpenProject.exe C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\XUnitTestProject1.csproj

Notice there are error diagnostics in the output
In VS run debug on this program (Debug>Start Debugging)
Run RoslynOpenProject in command line again
Notice there are NO error diagnostics in the output

Expected  behavior
C:\Users\pkruk\Source\repro\RoslynOpenProject\RoslynOpenProject\bin\Debug>RoslynOpenProject.exe C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\XUnitTestProject1.csproj
Project C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\XUnitTestProject1.csproj

6 not errors diagnostics exist.
0 error diagnostics:

Actual behavior
C:\Users\pkruk\Source\repro\RoslynOpenProject\RoslynOpenProject\bin\Debug>RoslynOpenProject.exe C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\XUnitTestProject1.csproj
Project C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\XUnitTestProject1.csproj

3 not errors diagnostics exist.
15 error diagnostics:
C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\UnitTest1.cs(1,7): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
C:\Users\pkruk\Source\repro\ConsoleApp8\XUnitTestProject1\UnitTest1.cs(2,7): error CS0246: The type or namespace name 'Xunit' could not be found (are you missing a using directive or an assembly reference?)
C:\Users\pkruk\.nuget\packages\microsoft.net.test.sdk\16.2.0\build\netcoreapp1.0\Microsoft.NET.Test.Sdk.Program.cs(2,7): error CS0246: The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?)
[...]

Environment data
For compilation I'm using Visual Studio 2019 16.4.0.
MSBuildLocator.QueryVisualStudioInstances finds following vs instances:
Name: Visual Studio Build Tools 2017
Version: 15.9.28307.960
MSBuildPath: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin
VisualStudioRootPath: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools

Name: Visual Studio Professional 2019
Version: 16.4.29519.181
MSBuildPath: C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin
VisualStudioRootPath: C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional

Name: Visual Studio Professional 2017
Version: 15.9.28307.718
MSBuildPath: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin
VisualStudioRootPath: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional

dotnet 3.1.100
Windows 10

I also tried registering the queried vs instances instead of using RegisterDefaults but it didn't change anything.
I also compared content of the programs folders before and after running debug in VS.

for RoslynOpenProject the difference was the  addition .config file I mentioned in my first comment
for the ConsoleApp there was a difference in XUnitTestProject1\obj\Debug\netcoreapp3.1\XUnitTestProject1.csprojAssemblyReference.cache. It's a binary file, but has some text inside. After VS debug run I can see inside text which looks like references to system DLLs. This text was not present before (only references to the other project dll was present). Example of additional text:

C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Ref\3.1.0\ref\netcoreapp3.1\System.Diagnostics.StackTrace.dll
C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Ref\3.1.0\ref\netcoreapp3.1\mscorlib.dll

I have updated the original comment and also RoslynOpenProject attached there:

added comment that microsoft.build dlls should be removed from output folder (except for microsoft.build.locator assembly)
updated project to register VS 2019 + (for .net core 3.x support)

I believe I found the reason for this problem. It turns out that two versions of Microsoft.Build.Framework are loaded when MSBuildWorkspace.OpenProjectAsync is called. Once version is from msbuild registered by MSBuildLocator, but another version is version 4.0 from GAC:
Microsoft.Build.Framework.dll	Microsoft.Build.Framework.dll	C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin\Microsoft.Build.Framework.dll	Yes	No	Skipped loading symbols.		32	<IP_ADDRESS>107	<Unknown>	06D30000-06D54000	[22372] RoslynOpenProject.exe	[1] RoslynOpenProject.exe
Microsoft.Build.Framework.dll	Microsoft.Build.Framework.dll	C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\Microsoft.Build.Framework\v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a\Microsoft.Build.Framework.dll	Yes	No	Skipped loading symbols.		57	4.8.3752.0 built by: NET48REL1	02.03.2019 07:38	7C3D0000-7C439000	[22372] RoslynOpenProject.exe	[1] RoslynOpenProject.exe

Fusion logs show following call hierarchy:
Microsoft.Build.Framework, Version=<IP_ADDRESS>
	Calling assembly: Microsoft.Build.Utilities.v4.0, Version=<IP_ADDRESS>
		Calling assembly: NuGet.Build.Tasks, Version=<IP_ADDRESS>

It does not say who called the NuGet.Build.Tasks ...
Attaching the fuse logs: fuse.zip


Fix .\miri fmt on Windows

This allows .\miri fmt to work on Windows. Closes #3317.
To reiterate, the problem with using miri fmt on Windows is that the CLI arguments to rustfmt are too long. Currently over 65,000 characters are used in the call to rustfmt, which is incompatible with Windows as it is limited to (2^15 - 1) for all arguments plus all env vars.
Two things are done do get around this limit:

Call out to cargo-fmt for the crates that exist.
Batch rustfmt calls by length

Another alternative would be to just use rustfmt for everything and don't use cargo-fmt for the crates.
I don't know how much you guys may care about miri fmt time to run. I don't know the diff as it did not work before on my computer.
I have another branch that solves this, but in a less permanent way. That was my initial attempt, and I learned that even with cargo-fmt and relative paths, the rustfmt call still has 27k characters. This is closer to the limit than I expected, so it would not be a permanent solution. So I went back to absolute paths & batching.

I don't know how much you guys may care about miri fmt time to run. I don't know the diff as it did not work before on my computer.

I run this in my git hook, so I care about it being basically instantaneous as it is currently. This will have to be benchmarked before it can land.

On my computer, which is basically worst case right now as it is Windows, this is what I measured.
C:\Users\rsmyth\Documents\miri> Measure-Command { .\miri fmt }

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 2
Milliseconds      : 119
Ticks             : 21195402
TotalDays         : 2.45317152777778E-05
TotalHours        : 0.000588761166666667
TotalMinutes      : 0.03532567
TotalSeconds      : 2.1195402
TotalMilliseconds : 2119.5402

Looks like process spawning is that expensive. Going to chunks of size 512 largely fixes the perf regression. It's like an extra 10ms per spawned process, and we have around 900 files.
We could probably offset this by doing things in parallel, but then we need crossbeam's queue -- not sure if that's worth it. Also xshell is !Sync so we can't easily spawn multiple rustfmt in parallel.
Maybe let's just go for 256 files per chunk for now and call it a day.

Just as an experiment I made a naive parallel miri fmt with Rayon. Biggest pain point is that the xshell Shell type is not Clone. The results (both with files in cache):
The current commit on this PR:
Minutes           : 0
Seconds           : 1
Milliseconds      : 861
Ticks             : 18612607
TotalDays         : 2.1542369212963E-05
TotalHours        : 0.000517016861111111
TotalMinutes      : 0.0310210116666667
TotalSeconds      : 1.8612607
TotalMilliseconds : 1861.2607

Parallel:
Minutes           : 0
Seconds           : 0
Milliseconds      : 984
Ticks             : 9844392
TotalDays         : 1.13939722222222E-05
TotalHours        : 0.000273455333333333
TotalMinutes      : 0.01640732
TotalSeconds      : 0.9844392
TotalMilliseconds : 984.4392

Though if you compile miri-script with --release (is that something anyone does?) the results of the parallel impl decrease by 10-20ms, while the serial impl decrease by about 900ms so that it is reliably within 20ms of the parallel impl.
A better impl could be made but this was just a nerdsnipe since I was staring at it and Rayon is easy.

Just as an experiment I made a naive parallel miri fmt with Rayon. Biggest pain point is that the xshell Shell type is not Clone. The results (both with files in cache):

Yeah you are now running MiriEnv::new() over and over again, I am not surprised that this doesn't go very fast. That function is expensive.
Given my measurements above I am okay with not parallelizing this for now.

@rustbot author

@rustbot ready

@bors r+

:pushpin: Commit f2ec3214c90f4a84554fffb5e002eff8ee814a6b has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit f2ec3214c90f4a84554fffb5e002eff8ee814a6b with merge 45bce48708c96ce08f48eeb94c5aec7efc77fbb0...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 45bce48708c96ce08f48eeb94c5aec7efc77fbb0 to master...


move type definitions to devDependencies

This issue is correct IMO
close #22

close in favor of #22


fix: fixing canvas resizer jumps when a keydown event happens in preview mode.

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description
In this PR, we are fixing a minor issue with MainCanvasResizer.
Bug:
https://github.com/appsmithorg/appsmith/assets/35134347/5d76fd06-9786-4fcf-a189-62c3698505fa
PR fixes following issue(s)
Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

Refactor

Improved the resizing behavior of main container elements by optimizing width calculation logic.

/ok-to-test<EMAIL_ADDRESS>


feat: added modular solidity example contract (#494)

Description:

added Token modular contract to showcase in-line assembly math operations

added unit tests to cover Token modular contract

Related issue(s): #494
Fixes #494
Notes for reviewer:

Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

LG

Just blank line missing


never[] type overrides generic defaults

cc @ahejlsberg @sandersn
TypeScript Version:  master
Code
declare function f<T = string[]>(g: (acc: T, val: string) => T, init: T): T;
f((acc, val) => acc.concat([val]), []);

Expected behavior:
pass
Actual behavior:
$ node built/local/tsc.js index.ts --strictNullChecks
index.ts(2,28): error TS2345: Argument of type 'string[]' is not assignable to parameter of type 'ReadonlyArray<never>'.
  Types of property 'concat' are incompatible.
    Type '{ (...items: ReadonlyArray<string>[]): string[]; (...items: (string | ReadonlyArray<string>)[]): ...' is not assignable to type '{ (...items: ReadonlyArray<never>[]): never[]; (...items: ReadonlyArray<never>[]): never[]; }'.
      Type 'string[]' is not assignable to type 'never[]'.
        Type 'string' is not assignable to type 'never'.

What's happening here is that you really want to infer using the return type of the function; however, to do that, it needs its parameters to be typed. TypeScript will need to contextually type those parameters, but to do that well, it will run through arguments that don't need a contextual type because those arguments have types that are readily available.
Unfortunately, the only one you have is [], which has the type never[] in strictNullChecks and any[] otherwise. So I'm inclined to mark this as a design limitation or working as intended (@RyanCavanaugh).

Generally I agree. This behavior may be correct on the type system. However, generic defaults lose the sense with this case. So it is worth treating this as a special case.

Related: https://github.com/Microsoft/TypeScript/issues/19576.


x/build: add LUCI linux-s390x builder

There currently isn't a LUCI builder that tests the linux/s390x port (other than the misc-compile builder, which tests only that the port compiles). This is the tracking issue for it.
The next steps that a builder owner will need to follow to make progress here are documented https://go.dev/wiki/DashboardBuilders#luci-builders.

Hostname for the builder: linux-s390x-ibm
csr is attached:
linux-s390x-ibm.csr.txt

Thanks. CC @mknyszek.

Here's the certificate:
linux-s390x-ibm-1728069494.cert.txt


Winget Woes

Winget works fine on my machine, but when trying to use it using this tool, I get

When trying to do a reinstall of Winget  via the tool I get this

This is a fresh installation of Windows 11 with the latest patches.
winget -v shows v1.7.3481-preview
I manually updated to the latest via here: https://github.com/microsoft/winget-cli/releases
now it shows v1.7.10514 and winutil seems to see it now.

This issue is related to chocolatey package manager, rather than a WinUtil issue.
Feel free to post an issue over their community packages repo on Github, to see what can be done to fix this error.
Note: Please share the log file for choco (Not Winutil Log File) so people over there can actually help out, it'll be a huge help for them on Diagnosing the source of them issue.

I got the same problem.


refactor: Fix typos in Russian i18n

Fixed typos and several strings to be shorter and more clear

Thank you for your contribution!


HDDS-6261. OM crashes when trying to overwrite a key during upgrade downgrade testing

What changes were proposed in this pull request?

Set new block version to be always 0 when old block versions are cleared, so that OM won't crash when downgraded from 1.3.0 to 1.1.0 when having written multiple versions of a key on 1.3.0. For more details, see the jira description.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6261
How was this patch tested?

All existing tests shall pass.
[ ] Add a test case that should repro the issue w/o the patch.

@kuenishi Would you also take a look at this patch? Thx

overwrite

Create Key    /vol1/bucket1/key-${SUFFIX}    ${TESTFILE}

On second look this does not cause OM crash, only client-side failure (when old client tries to overwrite its own key).

LGTM. Do we have plans for adding overwrite to the upgrade acceptance tests, either in this jira or a follow up? The multi-tenancy branch added s3 to the upgrade tests, so maybe we can do the overwrites with s3 there to reduce the number of ops needed in that test?

Hey @errose28 @adoroszlai , I have added the acceptance test repro.
More info appended to the PR description. Pls take a look. Thx

Thanks @smengcl for the patch, @errose28 for the review.  (Merged it, since the latest commit addressed the only pending reivew comment.)


No license file

Thanks for this repo. This repo has no license file. So legally, I don't think anyone can download, use, reproduce, modify or redistribute it in its current form.
https://opensource.stackexchange.com/questions/1720/what-can-i-assume-if-a-publicly-published-project-has-no-license

I have the same concern

Thanks! I just added an MIT license.


Remove properties widget height calculations

We were manually calculating the height of the properties component which was being used by the properties widget to set the height correctly. This was necessary because the layout wasn't being done in such a way that the height of the containers could actually be calculated so this PR is fixing that so the containers actually take up the space that their contents do.
This makes it a lot easier to include the component in other pieces of the UI - specifically in the dashboards I'm working on.
There were a bunch of other layout changes that needed to be made - but this should be relatively safe since this is really the only place the properties container and this specific loading spinner component is used.

Can the padding be adjusted so that it matches the mockups? Also, the 1366px and above layout of the properties should have the colons and property values vertically aligned:
1366px and above

1024-1365px

1024px or less

@kisantia Yeah definitely, but I don't want to add more to this PR than I have to - those can be follow up tasks.


Deleting a user deletes the current user

Attempting to delete a user from the /users page deletes the current user instead.

@jamesiarmes I just tried reproducing this but it worked fine for me. Could you provide steps to reproduce?

For what it's worth, I was only testing locally so I'm not sure if there's something else going on with the server / database that could cause issues here.

Looks like this was introduced by https://github.com/codeforamerica/classifyr/pull/76, Devise now took over the user deletion logic. It's a bit tedious to work around the Devise controllers to get what we want.
I'll add a test to reflect this issue and add a fix for it.

@jamesiarmes This should now be fixed with https://github.com/codeforamerica/classifyr/pull/92!


Isn't a change in Dependencies also a breaking change

The previous versions (5.0.x) were dependent on the .NETStandard 2.1, but the new version (6.0.x) is dependent only on .net6. In my opinion this is a breaking change which I haven't found it documented anywhere. It means I have to convert libraries which are shared and force everyone to upgrade to .net 6 (not a bad thing, but not all projects move with the same pace)

@theCuriousOne supported .NET implementations for each EF Core version are documented on this page. In general, EF Core versions require the corresponding .NET version (so EF Core 6 requires .NET 6).
Our experience has been that users wanting to upgrade to newer versions of EF generally also want to upgrade to newer versions of .NET; the typical upgrade process would be to first upgrade .NET, and then EF. Older versions (e.g. 3.1) are supported for users not willing to make the upgrade right away.

@theCuriousOne that's correct - and it's by-design. Requiring EF Core to continue targeting old TFMs (e.g. .NET Standard) would prevent the library from taking advantage of newer features, and make things worse for new users. Note that the same strategy is taken e.g. by ASP.NET Core.
Once again, it's quite rare that we see someone wanting to upgrade to a new version of EF without also being willing to upgrade .NET; and that logic applies to libraries depending on EF Core as well. When a new version of EF Core comes out, if you want to use it, you'd frequently need a new version of that library anyway (e.g. since major versions may contain breaking changes). So as libraries are updated for the new EF Core, they themselves also need to target the new minimum TFM.
I do understand that this may make adoption slower fo newer versions of EF Core in some cases, since libraries must be updated. But the alternative would be to keep EF Core always targeting older TFMs, which is also a bad thing.

I think the main point is missed it the last conversation @roji .
I just wanted somewhere in the migration documentation to be stated that the dependency was changed - that is all.
Maybe that is "indirectly implied" or "assumed by default" for many, and I am the black sheep :)

@theCuriousOne I think you have a fair point. While we do try to make it clear in the docs, it might be a good idea to explicitly list this in breaking changes. We will discuss.

@theCuriousOne you're right, I understood this as a general discussion on which .NET version EF should target, and not as a documentation question!