feat(open-graph): Add ability to generate OG images + further OG support

After finally getting around to writing the docs, the open graph PR is now ready for review.
A detailed overview over how this works can be found in the docs now, but in summary, this enables users to automatically generate OG images with a lot of customisation options (even the ability to provide your own html/css satori component via config!)

This uses satori to generate an svg from html/css markup and sharp to convert it to .webp with some additional compression.
As discussed, this feature is disabled by default (so is opt-in). I only have figures from 4 months ago when I implemented this PR, but the total file size for all images for the entire docs folder was just 960KB, with an average of around 19KB per image.
This PR also adds some further Open Graph configuration support by adding frontmatter properties to override description/image (with aliases to support the matching ones from obsidian publish).
If you have any questions, improvements or remarks, please let me know :)

small ask. Can you rebase this onto main so that it would only be one commit 😄 Probably a bit easier to cherry-pick and test out the changes :)

small ask. Can you rebase this onto main so that it would only be one commit 😄 Probably a bit easier to cherry-pick and test out the changes :)

its ok, all PRs are squashed before merging anyways :)

small design nit before i look at this further, can we get a layout more like this?

Sure, will change the default layout :)
Few questions about how you want this implemented
What about the logo? Should this use the icon.png from the static folder? (could use to some funky looks if users have icons that differ greatly in size/aspect ratio). Or should this always use the quartz icon statically? Should users then also be able to further customise what icon is used here, or is relying on the site icon fine
The font size for the header size seems pretty big, from my testing, this was already pretty hard to fit with longer titles. How do you want to handle cases for long titles? Right now, I have a "breakpoint" variable, and if the title exceeds that length, it gets turned into a smaller font size. Alternatively, we could multi-line the title (tho that could look weird quickly next to the icon) or cut off the title with "..." if it gets too long.

Little suggestion: allow to change the default image path for frontmatter, so I can use content/img instead.

Little suggestion: allow to change the default image path for frontmatter, so I can use content/img instead.

Def something that can be improved in the future, but probably better to change this in a separate PR, as this one already has over 1000 line changes and is a lot to review at once (for sure want to add something this tho, alongside the ability to add external urls for images :) )

Little suggestion: allow to change the default image path for frontmatter, so I can use content/img instead.

Def something that can be improved in the future, but probably better to change this in a separate PR, as this one already has over 1000 line changes and is a lot to review at once (for sure want to add something this tho, alongside the ability to add external urls for images :) )

No problem, i will wait for the approvable and make an additional update right after!

Little suggestion: allow to change the default image path for frontmatter, so I can use content/img instead.

For this particular issue, we should use the same as Obsidian : https://help.obsidian.md/Obsidian+Publish/Social+media+link+previews#Image

Sure, will change the default layout :)
Few questions about how you want this implemented
What about the logo? Should this use the icon.png from the static folder? (could use to some funky looks if users have icons that differ greatly in size/aspect ratio). Or should this always use the quartz icon statically? Should users then also be able to further customise what icon is used here, or is relying on the site icon fine
The font size for the header size seems pretty big, from my testing, this was already pretty hard to fit with longer titles. How do you want to handle cases for long titles? Right now, I have a "breakpoint" variable, and if the title exceeds that length, it gets turned into a smaller font size. Alternatively, we could multi-line the title (tho that could look weird quickly next to the icon) or cut off the title with "..." if it gets too long.

Let's try to use icon.png, this is the favicon anyways so safe to assume it is close to 1:1
Breakpoint seams reasonable :)

Could you rebase to fix the merge conflict?

I'll take a look at changing the default image, fix the merge issues and address your review today or tmrw hopefully :)

Should we name these based on slugs instead of path?

 Should we name these based on slugs instead of path?
Oh and also space also needs to be escape afaik

I don't think slugs have to be globally unique, so using slugs doesn't really provide a benefit and would just require an additional step of making sure every file name is unique. By using paths, the OS already guarantees uniqueness if we take the full path.
For spaces, do we need to escape them? On windows and mac it works just fine, not sure if there are some Linux distributions that can't handle spaces in file names.
Still haven't gotten around to fixing everything from the review up bc i got sick, but hopefully soon now :)

@benschlegel any updates on this PR?

been some really stressful weeks, i probably have a few hours tomorrow to take a look and then some more starting next wednesday, just fyi but hopefully finally get some free time to take a look

hmm since we don't have acces to a server, we will have to decide whether we want to generate this on demand or dump everything pre-serving time.
pre-serve will cost cold start a bunch, reload with this one is essentially 30s every reload trigger
I think probably best if the components is async, then it would help creating this on demand (which is probably better)

Really excited for this one! Appreciate the effort, guys 🙌

We will have to decide whether we want to generate this on demand or dump everything pre-serving time.
pre-serve will cost cold start a bunch, reload with this one is essentially 30s every reload trigger ( for a 200 files vault, can't imagine for vault that is 5k+)
I think probably best if the components is async, then it would help creating this on demand (which is probably better)
current solution:
      if (cfg.generateSocialImages && !ctx.argv.serve) {}

This is an area that can be improved for sure, currently, all images are generated on startup (but async, so it doesn't block). Maybe this is an improvement that could be made in a future PR, as it's already hard to keep track of every review here (and i still have a lot to go through from jacky). Since this feature is disabled by default anyways, I don't think this is too critical for now. I know I personally don't have enough free time atm to test out your proposed changes in context of all possible config options and other quartz config, but if you do and it all still works as expected, we can also add this now

hi @benschlegel, sorry for the ping, if you still want to work on the PR lmk, or I can help with continuing your work here.

hi @benschlegel, sorry for the ping, if you still want to work on the PR lmk, or I can help with continuing your work here.

Hey, no worries. Uni has been going crazy and I didn't really have time to work on this until now, but semester is over now and I should get some time again soon. If you need this sooner or want to do it yourself, that works too, but I don't think too much is missing to get this finished now.

no worries at all really. I have implemented this on my side, this is rather bringing this to Quartz.

Apologies for the long delay! I finally got some time to work on this and now (mostly) addressed all of the previous feedback.
I now added a new template based on @jackyzha0 's feedback (https://github.com/jackyzha0/quartz/pull/740/#issuecomment-1913489020), which currently looks like this:

Not the biggest fan of how the icon is integrated currently, but I guess people could adjust this as needed (if we want to keep the icon there).
Since this has been open for a rather long time unfortunately, I think a new updated review or any general feedback on how jacky envisioned this would help.
Some notes:

I left in the previous image generation template for now, as I think it can help people get a feel for how the quirks of the satori (not quite) tsx templating syntax works. This might be better off as an example in the docs, but the example is around 100 lines long.
The performance seems worse than the last time I worked on this a few months ago, but I think that's a quirk of WSL/my local dev setup, will test this on my mac and report back if it's also significantly worse.

this feature looks awesome 🙏 thanks for the great work ❤

Came here to submit PR for this. This is way more versatile than what I would have come up with. Looking forward to it! ❤


[Feature Request] Please make it possibel to injest PDFs

Saw this request in the discord, but wasn't added here yet, so thought I would.
kevin | weaksauce.eth — Today at 08:04
Is it possible to have it ingest PDF docs
cpacker — Today at 08:09
at the moment .pdf isn't officially supported so we'd recommend converting from pdf to txt first with some OCR software (eg https://github.com/tesseract-ocr/tesseract#installing-tesseract), then follow the README examples that use .txt input
but def open an issue about this and we'll add support for it! shouldn't be too hard to automate this for you

Don't mind me, i'll just leave this here. It was in my tabs somewhere so... thought it would be helpful:
https://github.com/X-PLUG/mPLUG-DocOwl

@dm3h @MrXandbadas just added support for PDFs in the latest commit!
https://github.com/cpacker/MemGPT/pull/71
Let us know if you run into any issues!

Example usage:
python3 main.py --archival_storage_files_compute_embeddings="memgpt_arxiv.pdf"  --persona=memgpt_doc

Example output:
❯ python3 main.py --archival_storage_files_compute_embeddings="memgpt_arxiv.pdf"  --persona=memgpt_doc
Running... [exit by typing '/exit']
Computing embeddings over 1 files. This will cost ~$0.02. Continue? [y/n] y
Processing file chunks: 100%|██████████████████████████████████████████████████████████| 15/15 [00:03<00:00,  3.79it/s]
Saving embeddings to archival_index_from_files_2023-10-21_01_32_13_AM_PDT-0700/embeddings.json
Saving archival storage with preloaded files to archival_index_from_files_2023-10-21_01_32_13_AM_PDT-0700/all_docs.jsonl
Saving faiss index archival_index_from_files_2023-10-21_01_32_13_AM_PDT-0700/all_docs.index
To avoid computing embeddings next time, replace --archival_storage_files_compute_embeddings=memgpt_arxiv.pdf with
         --archival_storage_faiss_path=archival_index_from_files_2023-10-21_01_32_13_AM_PDT-0700 (if your files haven't changed).
Initializing InMemoryStateManager with agent object
InMemoryStateManager.all_messages.len = 4
InMemoryStateManager.messages.len = 4
💭 Bootup sequence complete. Persona activated. Testing messaging functionality.

💭 First time visitor detected, this could be the Chad my core memory speaks of, best to give a warm reception! Let's
also learn more about him. Advance with caution, show respect, and establish rapport.
🤖 Hello there! It's a pleasure to meet you. I'm MemGPT, your digital companion. I've heard you're a Ph.D. student at
UC Berkeley, involved in computer science, that's impressive! How can I assist you today?
Enter your message: What is a virtual context?
💭 Hmm, a complex question. The term 'virtual context' can refer to several things depending on the realm of
discussion. Is it referring to virtual reality, programming, or something else? Best approach would be to clarify.
🤖 The term 'virtual context' can be used in various fields with different meanings. It's used in virtual reality,
computer programming, etc. Could you please clarify in what context or field you are inquiring about?
Enter your message: Search your archival memory
💭 Alright, let's dive into the archival memory with this query, "virtual context". There's no guarantee what we might
find, but no harm in trying.
⚡🧠 [function] updating memory with archival_memory_search:
        query: virtual context, page: 0
💭 This is interesting! The retrieved information from the archival memory refers to a paper about MemGPT and uses the
term "virtual context." It talks about managing a kind of memory hierarchy almost like an OS. Maybe I can provide Chad
with a consolidated response after searching a few more times. Let's proceed.

the speed of these things is TERRIFYING!

Wow... I cannot believe this was added so fast. Thank you so much! I will try this out tomorrow and let you know if there's anything valuable to share from the results.

Can we ingest PDFs in real-time?


Limit number of variables that can be searched?

We've had some discussion about this in the past, but I don't think we ever came to a conclusion.
I think it would be good to limit it to ~10 (possibly less), because in terms of tree display, things get messy with more variables.

A question for @fionajordan - is there a use case for more than 2 variables? I'd be inclined to limit this severely especially because of problems like #174

I'd set three as the limit. While we were user-testing we decided that you would often want to see three variables on a tree to check something like Binford vs EA data, or the benefits of using one kind of variable over another + your "other" variable. However, given that you can't overlay maps (Note: RS very much wanted that functionality) then any more than 3 is not very useful. My reluctance to go for two is because the Kent? DougWhite? EA online visualisation only lets you do two, and we want to do more for people.

Well for tree display, I was thinking what we might do in the future is allow the user to search for more than 3 variables, but only allow them to display 3 on the trees. They could choose the 3 they wanted on the trees from dropdowns on the tree page, so they could switch between variables. Sorry this is poorly explained, hopefully it made sense!

@SimonGreenhill As far as I can tell, the number of variables searched isn't a big contributing factor to the time a search takes - rather the other way round, because time spent depends on the number of societies found - which will typically be lower if more criteria have to be satisifed. OTOH I think it should be the case, that number of variables plays a role when it comes to performance, because looking up matching societies should ideally be one DB query, either intersecting the results for each individual variable, or an appropriate JOIN.

Done in #279 - limited to four variables for now.


added support for collections

Added support for collections which are rendered to separate HTML pages.

Thanks for this! I've added some tests and I'll get a release out soon.


Add displayName to icons

Fixes #124 (not tested)

PR checklist:

[ ] Figma: icon shapes use “Scale” constraint
[ ] Figma: icon components are sorted Z-A in the file
[ ] Figma: icon components are built with a single union or compound shape when possible
[ ] Figma: library changes are published
[ ] SVG: icons render correctly in a browser
[ ] SVG: icons are exported with width="15" height="15" viewBox="0 0 15 15"
[ ] SVG: no icons are exported with stroke
[ ] SVG: no icons are exported with clip-path
[ ] SVG: no icons exceed 5 KB
[ ] Website is up to date
[ ] Sketch file is up to date
[ ] IconJar file is up to date

[ ] Icon names in the IconJar library are correct
[ ] Version in the IconJar library description is correct

What happened to this PR? Any chance it could be merged?

@LoganDark I’d forgotten I’d done this! Have taken it out of draft


Resize adjacent snapped windows simultaneously when hover on common edge or common corner

Description of the new feature / enhancement

When hover on the common edge of 2 windows, it's possible to resize both windows simultaneously
When hover on the common corner of 3 or 4 windows, it's possible to resize 3 or 4 windows simultaneously

Scenario when this would be used?
Each zone of a layout has a fixed size. While working with multiple snapped windows, we continuously change the concentration on different windows and want specific windows temporarily bigger without losing the snapping of all windows.
Next seconds, we want other specific windows temporarily bigger.
The whole time, we don't want to lose their relative positions according to the layout.
Supporting information
Similar to the existing feature of Windows below:

Duplicate with https://github.com/microsoft/PowerToys/issues/254


Msi installer: smoke test

PR Summary
PR 6043 broke the installer (issue #6095). To prevent this from happening in the future, add a smoke test that installs the msi in appveyor build and make build fail if installation failed.
It uses the exit code to determine the success. The reason why it does not fail in the current state is because as I pointed out here, the failing custom action is not returning its exit code.
PR Checklist
Note: Please mark anything not applicable to this PR NA.

[x] PR has a meaningful title

[x] Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] NA User facing Documentation needed

[ ] Issue filed - Issue link:

[ ] NA Change is not breaking
[ ] NA Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

For completeness we need to check all packages.
We could change the sequence from "install PS - build - test on builded version" to "install PS - build - install - test on builded installed version" -

We don't currently support testing from an installed version.  You can file an issue for that.

Verified feature build here:  https://ci.appveyor.com/project/bergmeister/powershell/build/v6.1.0-preview.276

@bergmeister thanks for your contribution! and dealing with all our questions.

@TravisEz13 You're welcome. A small improvement that came to my mind now is that we could wrap the exiting statement in a if ($null -ne $env:CI) or if ($null -ne $env:APPVEYOR) statement because those 2 environment variables are automatically defined in AppVeyor environments.

I created #6136
/cc @TravisEz13


use https secure connection for requests

because it's totally ain't cool to send API keys over http

Thanks, this is great. The Zillow API documentation seems to only mention the HTTP endpoint, but from a cursory glance, this looks like it should just work (i.e. that domain has a valid certificate and serves up content over HTTPS).
Have you made actual requests against the HTTPS endpoint successfully? If so, I'll merge this now.

yes, it supports HTTPS, even more to that, this example cURL request verbose log
curl "https://www.zillow.com/webservice/GetSearchResults.htm?address=438+Sausalito+Boulevard%2C+Sausalito&citystatezip=94965&zws-id=$ZILLOW_KEY" -v

shows that on HTTPS the API is able to speak in HTTP/2


Fix beautysh

What does this implement/fix? Explain your changes.
This removes the -f flag from the beautysh call
-f flag was removed in major release version 5.0.0
Does this close any currently open issues?
Fixes issue #2378
Checklist
Check all those that are applicable and complete.

[x] Merged with latest master branch
[x] Regenerate documentation with npm run docs
[x] Add change details to CHANGELOG.md under "Next" section
[ ] Added examples for testing to examples/ directory

all old tests are still valid

[ ] Travis CI passes (Mac support)
[ ] AppVeyor passes (Windows support)

Hi, Beautysh maintainer here, @Glavin001 any chance you can help this get merged? I'm getting people in my issue tracker complaining about this :)

Could anybody with proper permissions please rerun the integration tests and if successful do the merge?
It's still broken, see #2378


ServletContextPath can start with servletPath, it should be taken into consideration

… root) we should take it into consideration while determinating server base.

Thanks Petro! Looks great, I'll merge this now.


PEP8 cleanup

Resolved numerous PEP8 issues, found with flake8.

Want to go ahead and add a flake8 tox env?

Added a flake8 tox environment, using the plug-in flake8-putty for some added flexibility.

This is awesome!

This looks fantastic, can you add --import-order-style google? I think that'll be the last big thing. :)

I agree; delightful improvement.

@jonparrott: --import-order-style google came up with over 200 errors!  I'll start looking into that on Monday or Tuesday.

Change content looks good.
I'd prefer for the eighth and tenth commits to be folded into the sixth rather than exist on their own; how strong are your git skills?

I can do that, but @jonparrott has been using merge --squash, so they would be folded into one commit when they get merged, so that's why I didn't do that here.

Sure, but doesn't that one commit get a list of what happened generated from the line of commits before the squash?

Added check for import order style and fixed existing issues.  Will squash my other commits tomorrow.

Commits have been squashed.

Sure, but doesn't that one commit get a list of what happened generated from the line of commits before the squash?

We can customize the commit message when we merge. :)

This LGTM, @nathanielmanistaatgoogle I'll leave it up to you to merge.

Thanks so much for this, @pferate!

Glad I could help!


TextFields need multiple-click support

TextFields currently don't support double click (to select whole words) or triple click (to select the whole text). This is pretty basic functionality that already exists in the TextBox and should be mirrored here.

The Textfields have the double click and triple click behaviors added but they don't seem to be responding to that input set


Graphics :#

This pull request adds a modified Status HUD and the start screen title.

Great work @venegu, merging.


Script and Task improvements Epic

Various ideas this Epic covers:

Make our task system alloc-free (possible with recent C# version) so that people are not afraid to create thousands of scripts with await
Reorganize task system so that we can wait various points of engine. So far we only have Update/Draw, but I suspect many scripts wants much more control when they want to run (after physics, etc...).
Not sure yet if we want some kind of high-level sync point graph editor, or something more programmatic.

@xen2

Make our task system alloc-free (possible with recent C# version)

I would love that!!
But how is that possible? Which C# feature can help with that and in what way?
Doesn't calling methods that represent a state-machine (async; and iterator/enumerable metods) always have to allocate at least some space the statemachine (its state and its "locals")?

Is there anyone working on this task ?

You proposed 2 features:

Minimize allocation in a task start, possibly with a minimum thread local storage;
Create several points to start a script in order to achieve a precondition.

Is that right ?

Yes, that's two separate features (probably done together in the same feature branch).
I started some prototyping on this task: https://github.com/xen2/xenko/tree/microthread2
I have made a simple library to test part of the concepts, next step is to decide exactly how to integrate it into Xenko and switch various part of Xenko to use it.

Do you want to create a mini batch system ?

I will read the code and make a proposal.

FYI the code is still a prototype/playground, it is not yet integrated and lot of things will change.

Just a little update, and correct me if I'm wrong :

You wrote a mini batch system , with a scheduler and a synchronization system;
Normally, users don't access directly such systems. There is a layer in the engine breaking great tasks into little taks and this layer and the little tasks weight depends on system configuration (I.E. core counts, core capabilities, etc) ;
If those assumptions are correct, the next step is construct this layer to break great tasks in little tasks and create the synchronization points;
-DX12 and Vulkan helps with this job;
I don't know if you are thinking on transparency on this layer, permitting the user/programmer to control it beyond creating custom sync points;
Let me hear your observations and corrections.

little Update 2: (correct me if I'm wrong)
-Xenko uses SDL as Window System, SharpDX as DX11/12 Binding, SharpVulkan as Vulkan Binding , OpenTK (Xamarin) as an OpenGL/OpenGL ES/Metal  binding/layer ;
-Seems the engine was implemented in a way to be more compatible with older APIs ;
-One simple feature is implement async compute in order to use MicroThreads and Vulkan/DX12/Metal  .Use MicroThreads to populate the queue and get the response. This will break compatibility in components;
-This imply in divide the engine implementation in high perfomance devices and low performance(mobile) devices .
Let me hear your observations and corrections.

Little Update 3: ( corrections and observations are welcome)

I will create an async compute  language subset using ANTLR4 and generating the parser in C# (Any restrictions/directions for grammar?);
The subset will produce METAL/Vulkan-OpenGL/HLSL compute shaders;
The compute shader will be processed by MicroThread using the scheduler ;
A use scenario will be created and the solution could be better evaluated.
Any restriction to this course of action ?

Little Update 4:

There is a Metal API in Xamarin, so the compute queue could be enable for testing purpose;

@velhaco20000 I would suggest you make a draft pull request to a new branch based on master from a fork of this repo and talk about that over there. This is mostly to reduce spam on epics, and you'll be able to explain yourself better using the PR template.

@fdrobidoux ,  you are right.  I just don't want to create something useless or something somebody else is doing right now.

Hey @xen2 - got a question about this Epic what do you mean by a "high-level sync point graph editor"? Do you mean visual Scripting because that would be nice to get. :)

Has anything happend anymore in regard of this topic  since i see that the tasks in stride 4.0.01 are still .NET 4.0 tasks and nott valuetasks afaik.

@Shpendicus did you check the changes in the linked WIP branch?

@tebjan what is WIP branch? where can i check it out?

There was some further discussion on Discord about this topic and this is a summery of it.
Rename "Script" (ScriptSystem, SyncScript, etc.) to be more fitting and intuitive. Additionally, the world "script" can be used to refer to other things such as files, and so can cause confusion.
Current suggestions are:

ExecutionComponent
WorkerComponent
GameplayComponent
FunctionalityComponent
TaskComponent
LogicComponent
Routine
Procedure

Condense StartScript, SyncScript, and AsyncScript, and perhaps ScriptComponent in to a single component to simplify and streamline the API.
Change the implementation to allow for more flexibility and extensibility.
These are the current ideas.

Interface based:

The different sync points are implemented as interfaces: IUpdate, IFixedUpdate, IRender, etc. Users add interfaces to their class declaration and implement the corresponding function.
Pros/Cons:

Very little bolierplate.
Discoverability of available interfaces is poor (perhaps having a naming convention could help, such as I____Receiver).
Access modifiers are public or only through interface.
Performance cost for adding a component to an entity, while very small, would increase linearly for each new interface type we add with a naïve implementation.

Register from entry point:

From a single start method, users register/add the component's methods to run on specific events/sync points.
Pros/Cons

A fair amount of boilerpate.
Good discoverability.
Access modifiers/encapsulation retained.
Very little performance cost but a small allocation cost for each one of those instance methods passed through those ‘Add’ calls.

Code gen:

When users implement methods whose signature matches one of the predefined event ones, those methods will be picked up by a code generator and automatically added in a similar way to above.
Pros/Cons:

No boilerplate.
Discoverability is bad.
Fixed access modifiers.
Same performance hit as above.
Feels like magic.

Pros/Cons from a partial implementation:

Small bolierplate (add partial to class definition).
Best discoverability.
Fixed access modifiers.
Same performance hit as above.
Feels like magic.

Another thing that came to my head - we should consider if the current way of having scripts directly attached to entities is the way to go forward. Currently scripts may a bit too universal - it's easy to misuse them instead of using a pair component+processor. I think it would be nice to see a new entry point into the scene where beefier and usually single instance objects would be registered for execution and if they need to be tied to a single entity's lifetime, maybe we could leverage cancellation tokens that would be cancelled when an entity is removed from the scene. The second thing to keep in mind is to promote asynchronous code with good "wait for event" APIs - wait for input combination, wait for a physics event, rather than wait for every frame and check something.

The AsyncScript should remain separate, although it could receive a similar renaming and a move to ValueTask. Having callbacks mixed with async is probably not the way to entice people to write the recommended code style. If instead of listening for callbacks people can await all the corresponding events, the resulting code will be much easier to write, read and debug.
No need to touch cancellation tokens and whatnot in the one callback to affect some other methods execution flow, in the process having to define all sorts of random fields to keep track of things which suddenly need to be accessible in multiple places, etc.

I think it would be nice to see a new entry point into the scene where beefier and usually single instance objects would be registered for execution and if they need to be tied to a single entity's lifetime

Do you mean like a scene-level/'global' system for managers and systems, where you will only have a single instance of them? Things where you wouldn't need a entity for it? (An example could be a system that spawns enemies in the scene)
If that is not, then can you explain more? If so, then I was actually also thinking just the other day how that could be a good idea.
How would you see this changing the design of the current implementation though?

wait for input combination, wait for a physics event, rather than wait for every frame and check something.

Genuine question, how would the performance differ from this approach, apposed to one where certain methods are called when those events happen, or events are invoked? And would you say the wait approach is a nicer design?

The AsyncScript should remain separate, although it could receive a similar renaming and a move to ValueTask

It would be needlessly redundant in my opinion. If we go with say the interface implementation, simply having a IAsyncExecute interface would have the same end result, while being cohesive with the rest of the system.

simply having a IAsyncExecute interface would have the same end result

Async is much more than just an interface. Its a style of coding. Mixing the two yields spagetthi. Or worse, async over sync over async, deadlocks, and crashes. There's many excellent articles on this by Stephen Toub on devblogs.microsoft.com.

Do you mean like a scene-level/'global' system for managers and systems, where you will only have a single instance of them? Things where you wouldn't need a entity for it? (An example could be a system that spawns enemies in the scene)

Yes, exactly something like that. Currently I'd either create a script and place an otherwise unused entity in the scene to hold a reference to it, or I need to implement a GameSystem, register it with the game class and potentially do some additional wiring to have it interact with the scene. With the task system we could have multiple representations of task sources - i.e. a component placed on an entity, a one off task executed on the game thread by another thread (think dispatcher of UI frameworks), a scene procedure invoked when a scene is activated (added as root or added as a subscene to an active scene) - this of course would mean extending the scene asset, which needs to be done with care.

(regarding async wait for event) how would the performance differ from this approach, apposed to one where certain methods are called when those events happen, or events are invoked? And would you say the wait approach is a nicer design?

The performance of a virtual method call directly is one thing, but currently we have a scheduler such that all callbacks of script methods happen in the same moment of a frame (sequentially, ordered by priority) - this adds some overhead but may allow additional robustness (it'd would be great to document Stride.Core.MicroThreading in greater detail first to understand it better).
I imagine the main benefit of the async/await pattern is context persistence - rather than manually managing a state machine and fields of my object with single method callbacks I can first await one event, then await a new frame, modify some entity, await a different event and throughout all that any context will be captured and the compiler will do all the heavy lifting, leaving me with a nice looking sequential logic, that would otherwise be spread across multiple callbacks.

(regarding async wait for event) how would the performance differ from this approach

The performance difference is in the amount of callbacks required as well, since the callback will always be called for a class of event, even if you aren't actually interested in the specific one happening - for example you collide and you asked to be notified, but the current collission is with something you don't care about.
In the async model it would be fairly easy to specify in detail what events you care about and there will be no callback until the actual event you care about occurs. It won't be easy to optimize this to the fullest, but the end result could be close to simply never having to filter anymore - if the physics engine reports an event, exactly the right callbacks would then be instantly known from the carefully crafted context.
An additional benefit automatically obtained is that the priorities of callbacks are much less relevant, because callbacks happen much more seldomly, at different times, so there will be less sorting and trivial inserts of the first element and generally a faster task system.

Make our task system alloc-free (possible with recent C# version) so that people are not afraid to create thousands of scripts with await

Might you be interested in adopting ProtoPromise? Benchmarks show it to be the most efficient alloc-free async library.

Make our task system alloc-free (possible with recent C# version) so that people are not afraid to create thousands of scripts with await

Might you be interested in adopting ProtoPromise? Benchmarks show it to be the most efficient alloc-free async library.

Looks very good, an implementation within the Engine could be smth, what do you guys say?

Make our task system alloc-free (possible with recent C# version) so that people are not afraid to create thousands of scripts with await

Might you be interested in adopting ProtoPromise? Benchmarks show it to be the most efficient alloc-free async library.

as its your library, it would make sense that you write a prototype of an integration
and showing the advantages/disadvantages of what is existing currently
you can make a WIP PR to let us see the progress


Tabs are not released by TabSwitcher

Environment
Dev Latest

Steps to reproduce

Measure memory
Create 10 tabs
Open Tab Switcher
Close 10 tabs

Expected behavior
Memory is back to normal
Actual behavior
Memory remains high until Command Palette (action mode) is open.
Observations

Heap analysis shows that TerminalTab objects are still alive. Most probably due to CommandPalette still holding a reference to them somehow (I believe this semi-leak exists in 1.5 or earlier, but became painful since introduction of TabPaletteItem, as now we hold a reference to a tab rather than SwitchToTabCommand)
We do not not reset tabs in Palette upon tab removal. This is something  we need to fix. But it is insufficient - we do call SetTabs on the following invocations of TabSwitcher and yet it does not  release the memory
I tried to track when the actual memory release happens, and it looks that it is insufficient to switch to command mode in the code, we really need to make the palette visible before the memory is released. This led me to the thought that the view is somehow holding the ref-count, although the model has already changed.
I blamed x:Bind not handling PropertyChanged ref-counting correctly (like here: https://github.com/microsoft/microsoft-ui-xaml/issues/934). But removing the INotifyPropertyChanged completely and even converting the bindings to OneTime didn't help. So now I am not sure if this is the right direction

@DHowett, @zadjii-msft - I am still trying to understand what is going on, but please consider this as potential release blocker.

Good find! Thank you :)


Remove jQuery dependency from wander.mjs

This PR also applies deno fmt conventions.

You did this a lot quicker than I think I could have!


Revert "Toggable Refactor"

Reverts flutter/flutter#76745
Looks like this is causing a test failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8853902536264730576/+/steps/run_android_semantics_integration_test/0/stdout

/TBR: @HansMuller


plot_rois should be optional arg

Sometimes I like to use dictionaries if I am passing optional args to an inner function, like the way seaborn does here, but it looks like in this case plot_rois would be better as a normal optional arg.
https://github.com/ben-dichter-consulting/axel-lab-to-nwb/blob/3f71dbb1378abedcfdeccb5233e615cafd9d8dfd/axel_lab_to_nwb/conversion_module.py#L21-L43

This is following the standard for conversion functions, which are being used by the conversion scripts of all labs and also makes it sure the GUI interface works
The source files: source_paths
The destination file: f_nwb
The metadata: metadata
Any extra thing lab-specific: **kwargs

Why would be have the standard for conversion functions? Why wouldn't we make the optional args explicit?

To make sure GUI, for example, will be able to call the conversion function from all labs.
Here's how the GUI's thread to run any user-supplied conversion module is implemented:
class ConversionFunctionThread(QtCore.QThread):
    def run(self):
        mod_file = self.parent.conversion_module_path
        spec = importlib.util.spec_from_file_location(os.path.basename(mod_file).strip('.py'), mod_file)
        conv_module = importlib.util.module_from_spec(spec)
        spec.loader.exec_module(conv_module)
        metadata = self.parent.read_metadata_from_form()
        conv_module.conversion_function(source_paths=self.parent.source_paths,
                                        f_nwb=self.parent.lin_nwb_file.text(),
                                        metadata=metadata,
                                        **self.parent.kwargs_fields)


Added validation for min length, alphanumeric and phone number.

Codecov Report

Merging #2954 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2954   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1395    1395
======================================
  Hits         1395    1395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa97e35...d540e15. Read the comment docs.

What value does this add?

@erikras I just used those on my app, on fields with "required" anyone can send just a "space" if there is no min value, also usually Username doesn't allow especial characters so, I just add those validation examples.


lib: put dereferencing expression after pointer null check

Dereferencing of the "work" pointer in the expression "work->handler"
necessary to move after we check if "work" is null.
Found as a coding guideline violation (MISRA R4.1) by static
coding scanning tool.
Signed-off-by: Maksim Masalski<EMAIL_ADDRESS>

The tool does not understand code.
Notice that in line 597, the work is figured out by CONTAINER_OF, as a container of type struct k_work that contains the node.
The only way for it to be NULL is if node would be a member of struct k_work object that has been placed at address NULL, which should never happen, even line 634 ensures that.
This means that if node is not NULL, then work will not be NULL.
Additionally possibly dereferencing NULL work pointer by the work->handler would be a problem, then it is preceded by two additional lines that do so.

Thank you for the detailed explanation, Dominik. I will close that PR.


Update versions to 24.04.

This PR updates to rapids-cmake 24.04 and bumps the version accordingly.

Closing in favor of #46.


CANNOT open code on Ubuntu 16.04

VSCode Version: 1.36.1-1562627527
OS Version:Ubuntu 16.04

Steps to Reproduce:

I install the vscode from the *.deb, but code cannot open, whether from the terminal or the start menu, even the code --verbose shows nothing

Does this issue occur when all extensions are disabled?: Yes

Assigned to @bpasero since there are couples of launching issues since 1.36.

Assigned to @bpasero since there are couples of launching issues since 1.36.

But I tried v1.35, v1.33, v1.30 and even v1.27, no one works.


Error generating code from spec: anonymous type name conflict when using headers in response

What version of ogen are you using?
$ go list -m github.com/ogen-go/ogen

v0.73.0
Can this issue be reproduced with the latest version?
Yes
What did you do?
I've tried to generate code for the spec below:
openapi: 3.0.3
info:
  title: test
  version: 0.1.0
paths:
  /test1:
    post:
      operationId: test1
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/Empty'
      responses:
        "202":
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Empty'
          headers:
            Location:
              schema:
                type: string
  /test2:
    post:
      operationId: test2
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/Empty'
      responses:
        '201':
          description: OK
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Empty'
          headers:
            Location:
              schema:
                type: string

components:
  schemas:
    Empty:
      type: string

What did you expect to see?
It should allow to declare multiple response headers with the same name.
What did you see instead?
ogen --target test --clean ./test.yml
INFO	convenient	Convenient errors are not available	{"reason": "operation has no \"default\" response", "at": "test.yml:16:9"}
generate:
    main.run
        /Users/ales/go/pkg/mod/github.com/ogen-go/ogen@v0.73.0/cmd/ogen/main.go:304
  - build IR:
    main.generate
        /Users/ales/go/pkg/mod/github.com/ogen-go/ogen@v0.73.0/cmd/ogen/main.go:64
  - make ir:
    github.com/ogen-go/ogen/gen.NewGenerator
        /Users/ales/go/pkg/mod/github.com/ogen-go/ogen@v0.73.0/gen/generator.go:112
  - operations:
    github.com/ogen-go/ogen/gen.(*Generator).makeIR
        /Users/ales/go/pkg/mod/github.com/ogen-go/ogen@v0.73.0/gen/generator.go:130
  - anonymous type name conflict: "EmptyHeaders":
    github.com/ogen-go/ogen/gen.(*tstorage).merge
        /Users/ales/go/pkg/mod/github.com/ogen-go/ogen@v0.73.0/gen/tstorage.go:144

This issue occurs ONLY if responses use the same schema for body as well.

As a workaround, you can define a named response:
openapi: 3.0.3
info:
  title: test
  version: 0.1.0
paths:
  /test1:
    post:
      operationId: test1
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: "#/components/schemas/Empty"
      responses:
        "202":
          $ref: "#/components/responses/Empty"
  /test2:
    post:
      operationId: test2
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: "#/components/schemas/Empty"
      responses:
        "201":
          $ref: "#/components/responses/Empty"

components:
  responses:
    Empty:
      description: OK
      content:
        application/json:
          schema:
            $ref: "#/components/schemas/Empty"
      headers:
        Location:
          schema:
            type: string
  schemas:
    Empty:
      type: string


Add files option for npm, fix indents on tests

http://jsperf.com/is-undefined
Use native focus event
Fix references in docs
Update change events in docs
Fix idents on tests
Move rows from .npmignore to .gitignore
Add files option on package.json
Use https when possible
...

Thanks @vsn4ik for the cleanup! Can you restore these files:

.npmignore (this was added in a pr for a specific case, so we should keep it for now (possible cleanup in 2.0)
tests/assets/jquery-2.2.3.min.js (I've added this file yesterday to start some work on jquery 1 and 2 test suites)

@acrobat I'm not going to restore unwanted files and unused libraries.

Ok, I will add the new jquery file in a separate PR for extra tests. But the .npmignore file was added to fix #1742, so we should atleast keep it until 2.0 (then we can remove it and fix things an other way)
I see you did a lot of small changes to the main js file, the changes look good on first sight. Can you guys also take a look @hebbet @Azaret, thanks!

@vsn4ik thanks for fixing the comments! Is it maybe possible to move the changes to bootstrap-datepicker.js to a separate pull request. Other changes can stay in this PR and are ready for a merge!

Done.

Thanks @vsn4ik! Will review the other PR soon!


PermissionsEx Error! [Log]

Description
i get an error every time i do this command
pex user chaotiic123 group add owner " lifetime
i do this on console by the way
Detailed Information
Is available here

The word "lifetime" is not part of the command.  You replace that with a value, a number of seconds.


add --exclude-namespaces parameter

This parameter will exclude the comma separated list of namespaces from processing since often namespaces such as kube-system will require very different PSP than other tenant applications.
Example usage:
$ ./kube-psp-advisor inspect --exclude-namespaces kube-system,default

apiVersion: policy/v1beta1
kind: PodSecurityPolicy
metadata:
  creationTimestamp: null
  name: pod-security-policy-all-20200928091609
spec:
  allowedHostPaths:
  - pathPrefix: /usr/share/zoneinfo/America/Los_Angeles
    readOnly: true
  - pathPrefix: /etc/ssl/certs
    readOnly: true
  fsGroup:
    rule: RunAsAny
  hostPorts:
  - max: 0
    min: 0
  runAsUser:
    rule: RunAsAny
  seLinux:
    rule: RunAsAny
  supplementalGroups:
    rule: RunAsAny
  volumes:
  - emptyDir
  - downwardAPI
  - secret
  - hostPath
  - configMap

thank you so much @aaronbbrown, let me take a look!

lgtm!

@aaronbbrown can you please make another PR to update the README.MD file as well?


Support multiple on_end_tag callbacks on Element.

I wonder whether end_tag_handler should be a struct that contains the handler function and an Option<Box> that points to earlier handlers.
This would remove the double allocations of using a Vec<Box<FnOnce>>. It would also make the natural order of processing be last-first, which feels right for nested data. (But I can't think of a good example where the order matters).

We would still need to allocate the box with the FnOnce and the box with Self.  So we would have 2 memory allocations, as opposed to 1 memory allocations + vec resize which is happens a logarithmic number of times.  i.e. amortized we currently do n + log(n) allocations.  Having such a struct would make it 2⋅n allocations.

We would still need to allocate the box with the FnOnce and the box with Self.

Yes, you're right. I somehow thought through the idea thinking the Box<Self> would contain the FnOnce without a Box.
Do you currently need the handlers to run in a specific order? If not, I'd suggest keeping the order explicitly undefined until we have a use case, since either order could be reasonable.

Do you currently need the handlers to run in a specific order?

Yes, in my case I need to have a specific since the callbacks interact with each other.

Hi, this seems to be a breaking change. We have tests in the Workers codebase that explicitly verify the last-call-wins behavior, and they fail after this change. Regardless of whether the behavior is desirable, if there's any chance that this might break already-deployed Workers in production then we won't be able to roll it out without guarding it behind a compatibility flag.
How should we handle this?


[Feature]: adding CSS options like Postcss and CSS in JS

As this project is on a way towards becoming more flexible and customizable. Its pretty good to give the user an option to use any of the modern + classical styling options
Planning to have styling options using the following libraries

Modern CSS using Postcss
CSS Modules ( Postcss-css-module or css-loader )  by @wincentrtz

CSS IN JS

Emotion
Styled-Component by @wincentrtz
aphrodite
linaria
any other if you want to add
Classical Styling
Make a way for usual styling using stylesheet and linking it to the html can be done too

Can add all or any or none 😁

Note, as of v1, these features will be implemented as addons which can be added using mern.json config file, to support the implementation of these addons, after you make changes in your fork, I will be submitting a PR in your fork with the support of making it configurable with mern.json, so please do let me know once you are done with your changes.
Try to avoid making changes in the core part of the project and keep it as minimal as possible.
like if it's a CSS-in-JS library addition, make changes in the hello component and add the required dependencies you need.

Hello @anikethsaha
I want to help for CSS IN JS Task
Is it still available?

Awesome. Yeah it's still available.
Which library you are going to add?

I want to add Styled Component
@anikethsaha
Actually this is my first open source project.
Can u guide me here?

That's great.
You can fork this project, clone it to your pc and run npm install
Then create a new branch using git checkout -b [your-branch-name]
You can add any name to your branch. Like feat/styled-component
Now you have your project setup. Now install the required libraries like styled-component
And make ur changes
Just try to add styles for the hello.jsx component.
Ping me on Twitter if you have any doubts : https://twitter.com/anik220798

Okay gonna do it now

Hi @anikethsaha
I have finished it, that means i can make a pull request right?

Woo...that was fast ⏩
Yeah you can raise a Pull request now !
Make sure all the tests are running !

you have to push it in your fork from your local machine !
use this command git push origin <your-branch-name>
It will work if you have cloned your fork !
Please let me know if you are facing any problem

Done it @anikethsaha
Please check it on #114

Thanks for ur help @anikethsaha
Feel free to chat me if you need some help

Yeah sure !
😃

Hey ! @wincentrtz Actually I wanted to add those styling or any extra stuff as a pluggable thing
like the user can get options or choose from any of these
What do you think about how can we achieve that by keeping minimum work!
I thought of making different branches for each task

If you create a lot of branches, it's going to be hard to maintain it. For example, you are making some of the style branches. Then you are using graphql or axios or some 3rd party again and create their own branches. It's going to be difficult for the developer to combine every single dependency that has been separated into its own branch.
I think we can create a lot of custom hooks and for example, you can see this:
https://github.com/styled-components/styled-components/issues/2342
It will make our code cleaner and it can be scaled too.

Yeah, branches are not a good option.
I am working on creating a config file for the project.
keep an eye on v1 branch. Will push some new changes soon

is the issue open? I would like to help

Yeah it's open but need a little tweak to make it configurable with the v1.
Please dm me on https://twitter.com/anik220798 and I will tell you how to make it supportable with mern.json

@manas2297 I guess you can work on any of the remaining options. From here https://github.com/anikethsaha/mern/issues/107#issue-502975601

@anikethsaha tell me how to configure it locally

@manas2297, after cloning it, simply run npm install
and that's it. You can work on a separate branch to keep the master safe

Also, for this particular issue, please try to avoid touching the core part, like if you want to add any library for css-in-js, simply add it in the src/client/components/hello .
To make it configurable, what I will do is, After you implemented everything, I need to do some copy-paste stuff and writing a script in scripts folder. I will put a PR in your fork with these changes.
Please dm me on twitter or anywhere you want, I will you in detail how things gonna take place.

Hi was this pull request closed? Is this still available?

Hi! Can I work on this issue?

Hello I want to contribute.


Failing when default posts removed

 error  in ./src/pages/Index.vue?vue&type=custom&index=0&blockType=page-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "thumbnail" on type "Post".

GraphQL request:14:9
13 |         summary
14 |         thumbnail
   |         ^
15 |         timeToRead
    at Object.module.exports (C:\Users\UbiOne\Documents\GitHub\ubionexd.dev\node_modules\gridsome\lib\plugins\vue-components\lib\loaders\page-query.js:33:23)

 @ ./src/pages/Index.vue?vue&type=custom&index=0&blockType=page-query 1:0-409 1:425-428 1:430-836 1:430-836
 @ ./src/pages/Index.vue
 @ ./src/.temp/routes.js
 @ ./node_modules/gridsome/app/router.js
 @ ./node_modules/gridsome/app/entry.sockjs.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.js

 error  in ./src/templates/Category.vue?vue&type=custom&index=0&blockType=page-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "thumbnail" on type "Post".

GraphQL request:19:13
18 |             summary
19 |             thumbnail
   |             ^
20 |             categories {
    at Object.module.exports (C:\Users\UbiOne\Documents\GitHub\ubionexd.dev\node_modules\gridsome\lib\plugins\vue-components\lib\loaders\page-query.js:33:23)

 @ ./src/templates/Category.vue?vue&type=custom&index=0&blockType=page-query 1:0-412 1:428-431 1:433-842 1:433-842
 @ ./src/templates/Category.vue
 @ ./src/.temp/routes.js
 @ ./node_modules/gridsome/app/router.js
 @ ./node_modules/gridsome/app/entry.sockjs.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.js

 error  in ./src/templates/Tag.vue?vue&type=custom&index=0&blockType=page-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "thumbnail" on type "Post".

GraphQL request:19:13
18 |             summary
19 |             thumbnail
   |             ^
20 |             categories {
    at Object.module.exports (C:\Users\UbiOne\Documents\GitHub\ubionexd.dev\node_modules\gridsome\lib\plugins\vue-components\lib\loaders\page-query.js:33:23)

 @ ./src/templates/Tag.vue?vue&type=custom&index=0&blockType=page-query 1:0-407 1:423-426 1:428-832 1:428-832
 @ ./src/templates/Tag.vue
 @ ./src/.temp/routes.js
 @ ./node_modules/gridsome/app/router.js
 @ ./node_modules/gridsome/app/entry.sockjs.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.js

 error  in ./src/pages/Blog.vue?vue&type=custom&index=0&blockType=page-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "thumbnail" on type "Post".

GraphQL request:19:9
18 |         summary
19 |         thumbnail
   |         ^
20 |         timeToRead
    at Object.module.exports (C:\Users\UbiOne\Documents\GitHub\ubionexd.dev\node_modules\gridsome\lib\plugins\vue-components\lib\loaders\page-query.js:33:23)

 @ ./src/pages/Blog.vue?vue&type=custom&index=0&blockType=page-query 1:0-408 1:424-427 1:429-834 1:429-834
 @ ./src/pages/Blog.vue
 @ ./src/.temp/routes.js
 @ ./node_modules/gridsome/app/router.js
 @ ./node_modules/gridsome/app/entry.sockjs.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.js

 error  in ./src/templates/Post.vue?vue&type=custom&index=0&blockType=page-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "thumbnail" on type "Post".

GraphQL request:7:5
6 |     sidebar
7 |     thumbnail
  |     ^
8 |     path
    at Object.module.exports (C:\Users\UbiOne\Documents\GitHub\ubionexd.dev\node_modules\gridsome\lib\plugins\vue-components\lib\loaders\page-query.js:33:23)

 @ ./src/templates/Post.vue?vue&type=custom&index=0&blockType=page-query 1:0-408 1:424-427 1:429-834 1:429-834
 @ ./src/templates/Post.vue
 @ ./src/.temp/routes.js
 @ ./node_modules/gridsome/app/router.js
 @ ./node_modules/gridsome/app/entry.sockjs.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.js

 error  in ./src/components/SearchInput.vue?vue&type=custom&index=0&blockType=static-query

Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/static-query.js):
Error: Cannot query field "thumbnail" on type "Post".

GraphQL request:10:9
 9 |         summary
10 |         thumbnail
   |         ^
11 |         categories {
    at Object.module.exports (C:\Users\UbiOne\Documents\GitHub\ubionexd.dev\node_modules\gridsome\lib\plugins\vue-components\lib\loaders\static-query.js:38:21)

 @ ./src/components/SearchInput.vue?vue&type=custom&index=0&blockType=static-query 1:0-419 1:435-438 1:440-856 1:440-856
 @ ./src/components/SearchInput.vue
 @ ./node_modules/cache-loader/dist/cjs.js??ref--1-0!./node_modules/babel-loader/lib??ref--1-1!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/windicss-webpack-plugin/dist/loaders/windicss-template.cjs!./src/layouts/Default.vue?vue&type=script&lang=js&
 @ ./src/layouts/Default.vue?vue&type=script&lang=js&
 @ ./src/layouts/Default.vue
 @ ./src/main.js
 @ ./node_modules/gridsome/app/app.js
 @ ./node_modules/gridsome/app/entry.client.js
 @ multi webpack/hot/dev-server webpack-hot-middleware/client?name=app&reload=true&noInfo=true ./node_modules/gridsome/app/entry.client.js ./node_modules/gridsome/app/entry.sockjs.js

I had the same problem with is_archived, but I removed it and it worked until now.
Now I don't know what to do.

This happens when you don't have an attribute within any of your post's frontmatter.
It's still trying to look for these attributes when querying for data but it's failing as it's not in the schema it's generating from your post's.
Ideally any fields like this need to be added to the schema to prevent this from happening like the one I added for the sidebar within the block starting on line 67 within gridsome.server.js

Without testing this at all as I'm writing this on a phone. I would guess modifying the gridsome.server.js file to something like this would fix this.
    addSchemaResolvers({
       Post: {
         sidebar: {
           type: 'String',
           resolve(obj) {
             return (obj.sidebar === undefined ? 'Default' : obj.sidebar)
           }
         },
         thumbnail: {
           type: 'String',
           resolve(obj) {
             return (obj.thumbnail === undefined ? null : obj.thumbnail)
           }
         }
       }
     })

I will test this and make a PR when I get a chance, the thumbnail type might need to be something other than a String.
The thumbnail already has a check within the post template to populate it with a default if a thumbnail is not supplied (is null). Unfortunately, if it's not present in any of the frontmatter it can't query it as it won't be part of the schema. If a single entry has one it knows to set those posts without it to null. Adding this makes it part of the schema anyway and gives the thumbnail property a default value of null.


Phabricator base update/20171016

I think this should continue to live in a branch until the workflow has been worked out. That said, this will pull in the needed code to fix https://secure.phabricator.com/D18717

As a reminder we will need to run 'docker-compose run phabricator check_database' on each system once we upgrade.

@purelogiq
What I Did

Use a MySQL tool (SequelPro, etc.) to export the entire DB for restarting an upgrade

In my mozphab clone, update the shas here:  https://github.com/darkwing/mozphab/blob/master/Dockerfile#L11

In my mozphab clone, run:  docker build -t mozilla/mozphab:test .

2.5.  In my phabricator-extensions clone, temporarily add the following around line ~9 of the docker-compose file:
user root
RUN \
    apk --update --no-cache add \
        bash \
        g++ \
        git \
        make > /dev/null 2>&1

Adding these dependencies allow usage of arc within phabext.

In my phabricator-extensions clone, run: docker build -t mozilla/phabext:test .

In my bmo-extensions clone, change docker-compose.yml file's phabricator->image to mozilla/phabext:test

SSH into bmo-extensions' phabricator (docker exec -it bmoextensions_phabricator_1 /bin/sh ), run db migration: phabricator/ $ ./bin/storage upgrade

Test all logical workflows, including:

Creating revisions
Modifying, adding, removing bug numbers w/ varying permission sets
Creating, abandoning revisions, ensuring parity with BMO (attachments, policies)
Create a repo within the phabext image, use arc to create revisions from command line, test custom field functionality (no bug #, bug # user has no permissions to, etc.)


Fix obo cache filters

<< Not ready for review>>
Adding user_assertion_hash in access_token and refresh_token instead of oboAssertion. This will add two advantages to the OBO flow:

Shortens the assertion length in cache
Helps with looking up cached OBO tokens only when the incoming_assertion matches

@sameerag @tnorling thanks for the effort, when will the fixes merge into production? 🙏

Codecov Report

Merging #4691 (0b5268b) into dev (14cf350) will not change coverage.
The diff coverage is 80.48%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.42% <ø> (ø)

Carriedforward from 14cf350

msal-browser
87.10% <100.00%> (ø)

Carriedforward from 14cf350

msal-common
85.89% <78.37%> (ø)

Carriedforward from 14cf350

msal-core
82.67% <ø> (ø)

Carriedforward from 14cf350

msal-node
83.40% <100.00%> (ø)

msal-node-extensions
76.03% <ø> (ø)

Carriedforward from 14cf350

msal-react
94.50% <ø> (ø)

Carriedforward from 14cf350

node-token-validation
86.92% <ø> (ø)

Carriedforward from 14cf350

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

...msal-common/src/cache/entities/CredentialEntity.ts
95.74% <ø> (ø)

...ib/msal-common/src/cache/entities/IdTokenEntity.ts
89.47% <ø> (ø)

lib/msal-common/src/client/RefreshTokenClient.ts
69.38% <ø> (ø)

lib/msal-common/src/client/OnBehalfOfClient.ts
73.80% <73.91%> (ø)

lib/msal-common/src/response/ResponseHandler.ts
69.34% <75.00%> (ø)

lib/msal-common/src/cache/CacheManager.ts
78.84% <85.71%> (ø)

lib/msal-browser/src/cache/TokenCache.ts
94.64% <100.00%> (ø)

.../src/interaction_client/NativeInteractionClient.ts
72.35% <100.00%> (ø)

...sal-common/src/cache/entities/AccessTokenEntity.ts
86.36% <100.00%> (ø)

...ib/msal-common/src/cache/entities/AccountEntity.ts
74.44% <100.00%> (ø)

... and 7 more


v1.9 backports 2021-03-02

#14999 -- cilium: encryption fix, ipv4-pod-subnets without encryptnode fails (@jrfastab)
#15039 -- ipsec: Use 64bits for XFRM output sequence number (@pchaigno)
#15048 -- cilium: encryption, fixes for ENI & Azure mode with shared podIPs and networkIPs (@jrfastab)
#15058 -- ci: disable endpointslice in 1.17 cluster (@nebril)
#15081 -- ci: use quay.io images in upstream tests (@nebril)
#15107 -- pkg/kvstore: fix etcd segmentation violation (@aanm)
#15096 -- checkpatch: update image (skip backports, add a check, suppress one report type) (@qmonnet)
#15118 -- backporting: Update instructions for backporting workflow (@aditighag)

Once this PR is merged, you can update the PR labels via:
$ for pr in 14999 15039 15048 15058 15081 15107 15096 15118; do contrib/backporting/set-labels.py $pr done 1.9; done

test-me-please

test-backport-1.9

at least runtime failed with a timeout on checkout. Lets rerun.

retest-runtime

test-gke

test-1.19-4.9

test-1.17-4.9

test-1.16-4.9

test-1.15-4.9

test-1.14-4.9

test-1.12-netnext

test-upstream-k8s

Looks like test-backport-1.9 somehow didn't work, all required tests failed during precheck with a timeout, see e.g. https://jenkins.cilium.io/job/Cilium-PR-K8s-1.17-kernel-4.9/63/
I've now re-triggered all required tests manually which seems to work so far. :crossed_fingers: for tests to pass.

test-1.15-4.9

test-upstream-k8s

@jrfastab I've added a commit for backporting https://github.com/cilium/cilium/pull/15168, since we were already editing upstream job by backporting https://github.com/cilium/cilium/pull/15081 anyway.

test-me-please

test-backport-1.9

k8s-upstream still failing with the same error as previous runs:
12:50:50    Mar  2 11:50:50.036: Error waiting for all pods to be running and ready: 5 / 11 pods in namespace "kube-system" are NOT in RUNNING and READY state in 10m0s

I'm now pretty sure it's something wrong with the PR itself, as it passes on 1.9 branch (confirmed by the new https://jenkins.cilium.io/view/Cilium-v1.9/job/cilium-v1.9-k8s-upstream/ which-was-supposed-to-be-there-but-was-missing-and-now-is-not).

Added two more commits from #14952 as without it the test would try to load cilium-operator without the -ci suffix and fail to bootstrap Cilium as a consequence.

test-backport-1.9

test-gke

For some reason Travis CI wants to build against #15192 (which seems to have been meregd into this PR's branch):
$ git fetch origin +refs/pull/15192/merge:
fatal: couldn't find remote ref refs/pull/15192/merge

https://travis-ci.com/github/cilium/cilium/jobs/487919092
Re-triggering the job doesn't help 😞

Closed and re-opened PR to check whether this heplks with the Travis CI build.

I think it's the same remote ref issue we had on some Jenkins node yesterday. /cc @Skymirrh

test-backport-1.9

I think it's the same remote ref issue we had on some Jenkins node yesterday. /cc @Skymirrh

Nah, it's something else. Not sure why Travis absolutely wants to use the merged branch instead of the branch itself, I've actually never used Travis before so I'm discovering...

test-1.20-4.9

test-1.19-4.19

test-1.19-4.19

test-1.19-4.19

test-1.20-4.9

test-1.20-4.9

Is 1.20 / 4.9 supposed to pass? Cilium 1.9 does not officially support 1.20, hence why the job is not required (nor is it triggered by test-backport-1.9).
Source: https://docs.cilium.io/en/v1.9/concepts/kubernetes/compatibility/#k8scompatibility

Thanks for the context @Skymirrh . I don't understand how it started getting triggered in this PR in the first place but given it's not required, I'm happy to merge without that run passing.

Thanks for the context @Skymirrh . I don't understand how it started getting triggered in this PR in the first place but given it's not required, I'm happy to merge without that run passing.

It's because of the erroneously used trigger test-me-please, which triggers the required jobs for master PRs (among which 1.20 / 4.9) ;)


Setup custom key bindings for windows/linux

As you documented, we (windows/linux users) have to define our own key bindings to navigate through panes.

When maximized, you can navigate to your other panes with: cmd+ctrl+→ or cmd+ctrl+←
Windows / Linux users will need to setup their own key bindings

But why do we have to? ctr+alt+... is not used by windows nor st2. Or are there any other thoughts I've missed?
[
    { "keys": ["ctrl+alt+enter"], "command": "max_pane" },
    { "keys": ["ctrl+alt+right"], "command": "shift_pane" },
    { "keys": ["ctrl+alt+left"], "command": "unshift_pane" }
]

@jisaacks Sorry, for the delay!
I thought right now a bit about that topic (bindings) and have to say, that we should re-map them. I don't really like the switch between shift and ctrl and as you see, the new windows-bindings are all on ctrl+alt+?.
So, what do you think about a change?

Yeah that sounds fine.

"ctrl+alt+enter" is used for replace_all in the find & replace panel of Sublime Text 3. Using it in MaxPane would override this default binding. Even if it would not directly conflict, this binding would be dangerous as it is sometimes not clear whether the find & replace panel has focus. So you might replace text by accident even though a pane was to be maximized.
Setting up bindings for shift_pane and unshift_pane would help ST2 users only. ST3 provides the focus_neighbouring_group out of the box with a proper default key binding. Therefore the 2 former commands are deprecated.


sha1 is deprecated

Please follow the general troubleshooting steps first:

[x] Ran brew update and retried your prior step?
[x] Ran brew doctor, fixed as many issues as possible and retried your prior step?
[x] If you're seeing permission errors tried running sudo chown -R $(whoami) $(brew --prefix)?

You can erase any parts of this template not applicable to your Issue.
Bug reports:
Warning: Calling Formula.sha1 is deprecated!
Use Formula.sha256 instead.
/home/mertcan/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/man-db.rb:6:in `class:ManDb'
Please report this to the homebrew/core tap!
Warning: Calling SoftwareSpec#sha1 is deprecated!
Use SoftwareSpec#sha256 instead.
/home/mertcan/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/man-db.rb:6:in `class:ManDb'
Please report this to the homebrew/core tap!
Warning: Calling Resource#sha1 is deprecated!
Use Resource#sha256 instead.
/home/mertcan/.linuxbrew/Library/Taps/homebrew/homebrew-core/Formula/man-db.rb:6:in `class:ManDb'
Please report this to the homebrew/core tap!
Propose a feature:
Instead of creating an issue here, please create a pull request with your change proposal in the Homebrew Evolution repository using the proposal template.

Hi @MertcanGokgoz, can you try running brew update again? Sometimes it needs to be run twice in order to work.
Shaun already changed man-db to use SHA-256 instead of SHA-1, so I suspect that's all that's necessary.
Thanks!

yes now working normally but sometimes i can see deprecated warning and i suspect sha1
mertcan@mertcan:~$ brew update
Already up-to-date.
mertcan@mertcan:~$

If you're seeing more warnings please quote the command that you run and warning that you see.


Fix  tag in things-to-look-out-for-when-proofreading.php

Fix XML Parsing Error: mismatched tag. Expected: </br>. error, by replacing <br> with <b> tag

Thanks!


Remove usage of flatRawNulls method from IsNullFunction

Simplify IsNullFunction implementation and remove usage of
BaseVector::flatRawNulls() method. Add tests for constant input.
See https://github.com/facebookincubator/velox/discussions/2202 for context.

Thanks for this change, I was wondering if you can add a little more context , as per #2202 , since flatRawNulls is not thread safe, there are other locations also its being used; Wont these have to change too ? What would be the cost of making flatRawNulls thread safe (say a lock ?) .

since flatRawNulls is not thread safe, there are other locations also its being used; Wont these have to change too ?

Yes, all call sites will need to be changed. I'll be sending separate PRs for each.

What would be the cost of making flatRawNulls thread safe (say a lock ?)

Locking would be expensive.


waiting  for loading game and nothing happened

i just completed built this project under UE4, and launch into quest2. While VR galss just shows loading status and nothing new happens.

Are you still seeing this with latest OS? If so, please share a log file.

Closing this issue. If you are still having trouble, please reply and we can re-open it.


Add windows port forward support

Fixes https://github.com/containerd/cri/issues/1273

/test pull-cri-containerd-windows-cri

pkg\server\sandbox_portforward_windows.go:28:2: cannot find package "k8s.io/kubernetes/pkg/kubelet/util/ioutils" in any of:
	C:\gopath\src\github.com\containerd\cri\vendor\k8s.io\kubernetes\pkg\kubelet\util\ioutils (vendor tree)
	c:\go\src\k8s.io\kubernetes\pkg\kubelet\util\ioutils (from $GOROOT)
	C:\gopath\src\k8s.io\kubernetes\pkg\kubelet\util\ioutils (from $GOPATH)

It seems that you need to update vendor:
go get -u github.com/LK4D4/vndr
vndr

/retest

The nginx server is occasionally returning 400 status code, looking into it.

+ Failure [10.703 seconds]
[k8s.io] Streaming
C:/Users/prow/AppData/Local/Temp/cri-install-crictl.aIFq/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/framework.go:72
  runtime should support streaming interfaces
  C:/Users/prow/AppData/Local/Temp/cri-install-crictl.aIFq/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/streaming.go:55
    runtime should support portforward [Conformance] [It]
    C:/Users/prow/AppData/Local/Temp/cri-install-crictl.aIFq/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/streaming.go:124
    The status code of response should be 200.

    Expected
        <int>: 400
    to equal
        <int>: 200

The flaky test you mentioned. @liyanhui1228 Can you collect some log from the failed pod, so that we can look into it more? :) Thanks!

Update: I exec'ed into the container and there is no log files in C:\inetpub\logs directory when the status code is 400. But there will be log files if the status code is 200. Still investigating.

Let's re-run the test several times. :)
/test pull-cri-containerd-windows-cri

I checked the host IP mapping file:
PS C:\windows\system32\drivers\etc> cat hosts
cat hosts
...some unrelated stuff
# localhost name resolution is handled within DNS itself.
#       <IP_ADDRESS>       localhost
#       ::1             localhost

And run command ping localhost
PS C:\windows\system32\drivers\etc> ping localhost
ping localhost

Pinging ed0bac81d3cf [::1] with 32 bytes of data:
Reply from ::1: time<1ms
Reply from ::1: time<1ms
Reply from ::1: time<1ms
Reply from ::1: time<1ms

Ping statistics for ::1:
    Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms

localhost is resolved to ::1 instead of <IP_ADDRESS> in here. That could be the reason.

@liyanhui1228 I think it makes sense. And actually we are also only supporting IPv4 on linux. https://github.com/containerd/cri/blob/master/pkg/server/sandbox_portforward_unix.go#L86
TCP4:<host>:<port>
Like TCP, but only supports IPv4 protocol (example).
Option groups: FD,SOCKET,IP4,TCP,RETRY


[Extensions] Configure a ScheduledJobParser to send a parse request to AD Extension from JS and return AD's ScheduledJobParameter

Is your feature request related to a problem?
The ScheduledJobParser is used by the JobSweeper to parse the ScheduledJobParameter (AnomalyDetectorJob) object here. The ScheduledJobParameter is then further used to validate the job prior to scheduling. In order to support this for extensions, we must create a proxy ScheduledJobParser which shall pass the jobDocVersion back to Anomaly Detector extension to parse into an AnomalyDetectorJob.
Task : Register extension actions related to job scheduler

[ ] Register job param action
[ ] Register job runner action

Closing as we have combined #308 and #309


Error on loading server

Mod doesn't generate config file and errors when loading:
10.1.2024 13:03:07 [Error] [daynightcycles] An exception was thrown when trying to load assembly: System.IO.FileLoadException: Assembly with same name is already loaded    at System.Runtime.Loader.AssemblyLoadContext.<LoadFromPath>g____PInvoke|5_0(IntPtr ptrNativeAssemblyBinder, UInt16* ilPath, UInt16* niPath, ObjectHandleOnStack retAssembly)    at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)    at System.Reflection.Assembly.LoadFrom(String assemblyFile)    at Vintagestory.Common.ModAssemblyLoader.LoadFrom(String path) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\API\ModAssemblyLoader.cs:line 34    at Vintagestory.Common.ModContainer.<>c__DisplayClass35_0.<LoadAssembly>b__0(String path) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\API\ModContainer.cs:line 448    at System.Linq.Enumerable.SelectListIterator2.MoveNext()    at System.Linq.Enumerable.WhereEnumerableIterator1.ToList()    at Vintagestory.Common.ModContainer.LoadAssembly(ModCompilationContext compilationContext, ModAssemblyLoader loader) in C:\Users\Tyron\Documents\vintagestory\game\VintagestoryLib\Common\API\ModContainer.cs:line 447
VS v1.18.15 on dedicated server
Modlist:
aculinaryartillery, backpackpackplus, betterruins, bettersticks, buzzwords, cellardoor, chiseltools, easysod, fancysky, TA_fieldsandplateaus, geoaddons, HangingOilLamps, harptechfix, HumanSkinTones, meteoricexpansion, millwright, moremolds, leadroof, palisademod, pipeleaf, playerlist, primitivesurvival, resinglue, rpvoicechat, she1fish, TheShovelerRises, translocatorengineeringredux, volumetricshadingupdated, game, weaponpackalphaunoff, wlts, zoombuttonreborn, ancienttools, animalcages, beehivekiln, betterfirepit, betterjonasdevices, blacksmithenhancements, helblockpick, canbeignited, carryon, commonlib, composter, danatweaks, daynightcycles, expandedfoods, farmlanddropssoil, hudclock, immersivewoodchopping, sailboat, medievalexpansion, morepiles, petai, pileful, postsandbeams, claywheel, prospecttogether, resingluetools, scarecrow, sharablewaypoints, simplestep, sprucedup, storageoptions, undergroundmines, usefulstuff17, creative, vsinstruments, survival, metalrecovery, bullseye, feverstonehorses, linearpower, maltiezbows, playercorpse, plumpkins, stonequarry

Thanks for the report! I fixed this in v1.0.1


Bug: Validation error in signup form

Description
Validation error should come inside form only rather than in form Toast massage , it will help user to catch error easily.
Proposed Solution
rather than using toast make object for every feild-state that can contains validation error as well so we can show error just below of the fields.
Screenshots
No response
Browser 🥦
Google Chrome
Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[ ] I am willing to work on this issue (blank for no).

Hello:)
I am interested in solving this issue.
Can you assign me?

Hi @Bashamega , you can go forward with the issue.
📑 Checklist in case you missed something

Local project setup, .env for the frontend.
Contributing guidelines to be followed.

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

Hi @Bashamega , you can go forward with the issue.
📑 Checklist in case you missed something

Local project setup, .env for the frontend.
Contributing guidelines to be followed.

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

Thank you very much

Hey, I am willing to work on this issue


RFP - flameshot

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL :https://github.com/flameshot-org/flameshot
Direct download URL for the software / installer : https://github.com/flameshot-org/flameshot/releases/download/v0.9.0/Flameshot-0.9.0-win64.msi
Software summary / short description:
Screenshot app for Windows

Hi, i saw this issue is sitll unsolved and closed abruptly. may I know what happened?

See the above comment - there is already a request for this.


chore: update to angular 9.1 and ts 3.8 (+ other deps)

:tada: This PR is included in version 8.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[5940] TOC has cursor pointer - clickable dropdown

When window gets small, "Table of Contents" becomes a closed dropdown. This fix adds the cursor pointer to "Table of Contents" so that the mouse hover shows it as clickable.

Choose PR 776 for open TOC, Choose PR 777 for closed dropdown with point hand cursor
https://github.com/github/accessibility-audits/issues/5940
and duplicate https://github.com/github/accessibility-audits/issues/5936

With #767 the table of contents <summary> as been changed to <Button as="summary"> so it now has a cursor pointer by default. So this is no longer needed.


This is awesome, any chance we could get a 2019 update?

Please and thank you

Thanks, any specific things you'd like to see in a 2019 update?


8.3 FadeIn and FadeOut JS equivalents will not work as intended

// jQuery
$el.fadeIn(3000);
$el.fadeOut(3000);

// Native
el.style.transition = 'opacity 3s';
// fadeIn
el.style.opacity = '1';
el.style.display = ''|'inline'|'inline-block'|'inline-table'|'block';
// fadeOut
el.style.opacity = '0';
el.style.display = 'none';

The JS equivalents will not actually work as intended because the el.style.display line will execute right after the el.style.opacity line without any delay. (as seen here: https://codepen.io/anon/pen/BYEpJV).
The correct way to do this is by wrapping the el.style.display around a setTimeout() function:
// fadeOut
el.style.opacity = 0;
setTimeout(function() {
  el.style.display = 'none';
}, 3000);

My bad... You're right on the problem, but I would suggest a more precise alternative to setTimeout, that is the transitionend event:
// fadeOut

el.addEventListener("transitionend", function (event) {
        el.style.display = 'none';
}, false);
el.style.opacity = '0';

I'll open a PR later, to fix both fadeOut and fadeIn.

Great! I was not aware of that event.

For me transitionend didn't work.
This one worked though :
el.addEventListener("webkitAnimationEnd", function (event) {       el.style.display = 'none';     }, false);


Convert from Spark table to Iceberg table

Currently, Iceberg-spark doesn't have API to convert from a Spark table to iceberg table. User may want to migrate Spark or Hive tables to iceberg tables directly.

Here is a relevant email thread on the dev list.

Hi @aokolnychyi,
I see you mentioned to use a spark job to implement the API, do you mean to use a SparkSession?  I tried some commands in spark-shell and summarized here(Note that it is just a list of commands).

I spent some time to try this on spark-shell, and now I 'm converting them to code, @rdblue are you working on this as well? I saw you mentioned in another thread.

I haven't yet, feel free to submit a PR!

Fixed by #374


Stormcloak camps not activated in Stormcloak controlled regions (imperials)

Stormcloak camps in Stormcloak controlled areas (imperial) are not active on boot up of mod ( i used tmm 1 to double check) thus making it impossible to get x marks the docs documents from the Stormcloak camps, i believe they toggle on for the last battle and defector collector missions

This is by design. So whenever a new campaign starts (Tullius says 'Go to our hidden camp in X') The Campaign script hides the camp of the enemy (cus its 'hidden'). And then when the missions start, we programmatically check to see if we want the document alias to be at the camp or at the HQ (its a 50/50 chance). If it is at the camp then we enable at the camp and show it on the map. Last Battel works this way as well.


Swift will not infer opaque return type of generic function

Description
No response
Reproduction
NG Pattern
When using an opaque type as the return-value, the compiler says "Type 'Impl' does not conform to protocol 'X'".
import SwiftUI

protocol X {
    associatedtype Body: View
    func doSomething<T>(parameter: T) -> Body
}

struct Impl: X {
    // Type 'Impl' does not conform to protocol 'X'
    func doSomething<T>(parameter: T) -> some View {
        Text("Problem Occur")
    }
}

OK Pattern
When using a concrete type as the return-value, the compiler is silent.
import SwiftUI

protocol X {
    associatedtype Body: View
    func doSomething<T>(parameter: T) -> Body
}

struct Impl: X {
    func doSomething<T>(parameter: T) -> Text {
        Text("Problem Occur")
    }
}

Expected behavior
Impl conform X even when it returns some View, and the compiler says nothing.
Environment
swift-driver version: <IP_ADDRESS> Apple Swift version 5.10 (swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Additional information
Xcode 15.3 (15E204a)
macOS 14.4.1（23E224）
swift-forum discussion: https://forums.swift.org/t/swift-will-not-infer-opaque-return-type-of-generic-function/67233

This is correct behavior. The opaque return type of Impl.doSomething() depends on the generic parameter T, so it cannot witness an associated type requirement which can only depend on the generic parameters of the conforming type itself.


No Connection to Comfoairq

The Adapter stays yellow and says comfoairq = false
IP-address is correct,
UUID is correct (should be, last part IS MAC-Address).
PIN is correct.
Here are the logs:

comfoairq.0
2020-09-23 21:43:53.336
info
(26969) starting. Version 0.0.1 in /opt/iobroker/node_modules/iobroker.comfoairq, node: v10.16.3

comfoairq.0
2020-09-23 21:43:50.240
info
(23707) Terminated (START_IMMEDIATELY_AFTER_STOP): Without reason

comfoairq.0
2020-09-23 21:43:50.240
info
(23707) terminating

comfoairq.0
2020-09-23 21:43:50.239
info
(23707) Got terminate signal TERMINATE_YOURSELF

regards
raetsch

This is currently under development - the current version is not working


Override CopyToAsync

This resolves Issue #57 by implementing the CopyToAsync method.
If the target stream is a MemoryStream-derived type, then it will call Write synchronously immediately. Otherwise, it will call WriteAsync on the destination stream.

Using Task.Run is async over sync and that's a bad practice. See Should I expose asynchronous wrappers for synchronous methods?.
The thread pool might be a critical component of the system using the stream.
But avoiding allocation is always good.

Task.Run is only called when the target stream is unknown, and an async write is done. In cases where a sync write can be done, a completed task is returned.

Nevertheless, this is a major no-no.
Besides that, what's the benefit of having Task.Run here?


Ability to change shortcut

Please provide add ability to change keyboard shortcut

+1

+1

+1 We need this function!

+1

+1


Rancher 2.4.5 logs flooding with trace.go:116] Trace[1005551365]: "Reflector ListAndWatch" ...

Hi,
Just installed Rancher 2.4.5 on a new 3x node cluster running RKE.
The logs for rancher pods are flooding with:
E0707 21:34:51.038028       6 reflector.go:178] github.com/rancher/norman/controller/generic_controller.go:237: Failed to list *v1.LimitRange: Get https://<IP_ADDRESS>:443/api/v1/limitranges?resourceVersion=1056936&timeout=30s: context deadline exceeded
I0707 21:34:51.372617       6 trace.go:116] Trace[1710883669]: "Reflector ListAndWatch" name:github.com/rancher/norman/controller/generic_controller.go:237 (started: 2020-07-07 21:34:21.372126973 +0000 UTC m=+2270.123989835) (total time: 30.000461168s):
Trace[1710883669]: [30.000461168s] [30.000461168s] END
E0707 21:34:51.372637       6 reflector.go:178] github.com/rancher/norman/controller/generic_controller.go:237: Failed to list *v1beta1.CronJob: Get https://<IP_ADDRESS>:443/apis/batch/v1beta1/cronjobs?resourceVersion=1056936&timeout=30s: context deadline exceeded
I0707 21:34:53.067817       6 trace.go:116] Trace[55502052]: "Reflector ListAndWatch" name:github.com/rancher/norman/controller/generic_controller.go:237 (started: 2020-07-07 21:34:23.067290294 +0000 UTC m=+2271.819153099) (total time: 30.000502021s):
Trace[55502052]: [30.000502021s] [30.000502021s] END
E0707 21:34:53.067847       6 reflector.go:178] github.com/rancher/norman/controller/generic_controller.go:237: Failed to list *v1.StatefulSet: Get https://<IP_ADDRESS>:443/apis/apps/v1/statefulsets?resourceVersion=304192&timeout=30s: context deadline exceeded
I0707 21:34:54.310707       6 trace.go:116] Trace[903079860]: "Reflector ListAndWatch" name:github.com/rancher/norman/controller/generic_controller.go:237 (started: 2020-07-07 21:34:24.310191958 +0000 UTC m=+2273.062054812) (total time: 30.000485854s):
Trace[903079860]: [30.000485854s] [30.000485854s] END
E0707 21:34:54.310727       6 reflector.go:178] github.com/rancher/norman/controller/generic_controller.go:237: Failed to list *v1beta1.PodSecurityPolicy: Get https://<IP_ADDRESS>:443/apis/policy/v1beta1/podsecuritypolicies?resourceVersion=304192&timeout=30s: context deadline exceeded
I0707 21:34:56.045578       6 trace.go:116] Trace[1919876946]: "Reflector ListAndWatch" name:github.com/rancher/norman/controller/generic_controller.go:237 (started: 2020-07-07 21:34:26.045120424 +0000 UTC m=+2274.796983210) (total time: 30.000437273s):
Trace[1919876946]: [30.000437273s] [30.000437273s] END
E0707 21:34:56.045600       6 reflector.go:178] github.com/rancher/norman/controller/generic_controller.go:237: Failed to list *v1.Service: Get https://<IP_ADDRESS>:443/api/v1/services?resourceVersion=308039&timeout=30s: context deadline exceeded
I0707 21:35:00.181183       6 trace.go:116] Trace[1041200385]: "Reflector ListAndWatch" name:github.com/rancher/norman/controller/generic_controller.go:237 (started: 2020-07-07 21:34:30.180644446 +0000 UTC m=+2278.932507442) (total time: 30.000494674s):
Trace[1041200385]: [30.000494674s] [30.000494674s] END
E0707 21:35:00.181202       6 reflector.go:178] github.com/rancher/norman/controller/generic_controller.go:237: Failed to list *v1.StatefulSet: Get https://<IP_ADDRESS>:443/apis/apps/v1/statefulsets?resourceVersion=1056936&timeout=30s: context deadline exceeded
I0707 21:35:02.455813       6 trace.go:116] Trace[964051873]: "Reflector ListAndWatch" name:github.com/rancher/norman/controller/generic_controller.go:237 (started: 2020-07-07 21:34:32.455081798 +0000 UTC m=+2281.206944618) (total time: 30.000702975s):
Trace[964051873]: [30.000702975s] [30.000702975s] END
E0707 21:35:02.455911       6 reflector.go:178] github.com/rancher/norman/controller/generic_controller.go:237: Failed to list *v1.ReplicationController: Get https://<IP_ADDRESS>:443/api/v1/replicationcontrollers?resourceVersion=1056937&timeout=30s: context deadline exceeded

What kind of request is this (question/bug/enhancement/feature request):
Question / Bug
Steps to reproduce (least amount of steps as possible):

Follow instructions at Rancher docs to create a 3 node RKE cluster.
Follow instructions at Rancher docs to install Rancher

Result:
Rancher itself works fine. The issue is that the logs for Rancher pods are flooding with the above errors.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.4.5
Installation option (single install/HA): HA on RKE Kubernetes

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Imported RKE started on 3x Digital Ocean droplets
Machine type (cloud/VM/metal) and specifications (CPU/memory): Digital Ocean droplets, 8GB memory ea, Ubuntu 18.04 LTS x64
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:52:00Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Docker version (use docker version):

19.03.6

I've verified that firewall is not running.

Update. After a few hours, Rancher just stopped showing workloads on all clusters in the UI. :(
I will try installing 2.4.4....

Just confirming that downgrading to 2.4.4 seemed to not have the same problem. Logs on rancher pods appear normal.
I had to reimport all clusters to get them to display the workloads again.
There seems to be some issues with 2.4.5.

This is the same as https://github.com/rancher/rancher/issues/27736


Update IP and subnet, submodules

NETCONFIG_IPSUBNET: <IP_ADDRESS> -> <IP_ADDRESS>
NETCONFIG_DRIPADDR: <IP_ADDRESS> -> <IP_ADDRESS>
And remote IP for mavlink

We will merge this after planned PX4 tag.

This change has been pending for over 2 months.
If there are issues in MC side, it is time to fix it now. This is not waiting for any "tagging" or "releasing" or something else any more. I am merging this in now.