CIF-2732 - Teaser: add option to open CTA in a new Tab

added v3 of commerce teaser with support for link target
added Java and JS unit tests
updated examples library
updated component readme
deprecated v1 and v2 of commerce teaser

Related Issue
CIF-2732
How Has This Been Tested?
Manually, unit test.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

I had to increase the aem-uber.jar dependency to 6.5.8 which contains ComponentStyleInfo.

I've added deprecation information too.


[Cleanup] - Testcontainer - The docker image of test dependencies (cassandra, s3...) should be one immutable

The container can be singleton or non-singleton, but the image should be created one time

IMO we should put james-testing-xxx-01 so that if I modify the docker file I can ensure I get the new image to be used...

the image will be auto removed after the test (done by testcontainer).

The docker image already is a singleton for each JVM.
As @quantranhong1999  point, It not much benefits

Reopen to check other error from CI  (Will be closed later)
- Build 1: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1070/1/testReport/junit/org.apache.james.blob.cassandra/CassandraBlobStoreClOneTest/saveShouldSaveEmptyByteSource_StoragePolicy__3_/

Status 404: {"message":"No such image: james-testing-cassandra:latest"}

- Build 9: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1070/9/testReport/junit/org.apache.james.blob.cassandra/CassandraBlobStoreClOneTest/org_apache_james_blob_cassandra_CassandraBlobStoreClOneTest/

Status 404: {"message":"No such image: cassandra_3_11_10-cdd771a3-870c-4804-909b-0a52197cb6f0:latest"}

What to do with this stale PR @vttranlina ?

closed


excellent works!

I always want to port dlib to android , so that we can enjoy powerful ability of detecting  person and face of dlib when driving; it can alarm by audio or flashing when detected a persion in front of the car!
I found the app havn't geting image from the camera to real time detecting;
but I am expect in C++,C not java, hope you realize the function

Hi @berli
In fact, it's not difficult. It needs to take time to realize it. However, I am studying another project TensorFlow, I will realize the features when I have free time. You can try it to implement it by yourself and send a pull-request.
My another repository can detect any object using fastRCNN and CNN, but it needs to speed up.
https://github.com/tzutalin/Android-Object-Detection


Ignore definition files when using "Peek References"

Issue Type: Bug
When using "Peek References" (or presumably, "Find References") on an imported package, like Lodash, references found in node_modules/@types/lodash are also included. Instead, only references in my own code should be included.
This only happens when using import (in either JS or TS), and not when using require.
This is in a TypeScript project, with the following tsconfig.json:
{
  "compilerOptions": {
    "declaration": true,
    "declarationMap": true,
    "esModuleInterop": true,
    "module": "CommonJS",
    "outDir": "./dist/",
    "resolveJsonModule": true,
    "rootDir": "./src/",
    "sourceMap": true,
    "strict": true,
    "target": "ES2020",
    "typeRoots": ["./node_modules/@types", "./typings"]
  },
  "include": ["./src/"],
  "exclude": [
    "**/build/**",
    "**/coverage/**",
    "**/dist/**",
    "**/node_modules/**"
  ]
}

Global VS Code settings includes:
{
  "files.exclude": {
    "**/node_modules": true
  }
}

I've also attached a screenshot below (the screenshot was taken in the file src/Calendar.ts), to show all the extraneous references from the node_modules folder:

VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:33:00.827Z)
OS version: Darwin x64 18.7.0

This feature is powered by the TypeScript project. Please file a feature request upstream for this


fix: return 'failed' on getResource failures [DANTE-584]

Would be great to have a description why and a test?

Never mind, I don't necessarily need this on the caller side


Remove tpu cleaning job from CI

What does this PR do?
The TPU Cleaning job is still failing in CI causing our CI to be red. Is it okay to remove this job? Or do we want to fix it to make it work again?
Fixes #8961
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

I think it's necessary, but the job runs every 20 minutes and fails from time to time.
I don't know what causes the failure, though.
cc: @Borda @kaushikb11

@Borda sounds good


Bcrypt doesn't work , replace it with bcryptjs

npm uninstall bcrypt
npm install bcrypt

This fixed the issue I faced with bcrypt when seeding the database

Closing since the reinstall seems to work for you! I can confirm bcrypt should be okay.


Compilation depends upon Browserify

I tried using Polyglot in a non-Browserify/Webpack environment. I ran into the following problems:

Dependencies on for-each, has and object.assign led to code bloat.
The dependency on warning broke the build because ... erm ... "warning" depends upon Browserify.

Since each function serves a tiny purpose, I worked around those problems in https://github.com/adamhooper/polyglot.js/tree/for-decision-2016. Surely I'm not the only one who experiences these problems. Would you consider a pull request?

Compilation of the majority of the JS ecosystem requires browserify and/or webpack - that's the nature of JS in 2016.
It is a hugely best practice to require consumers use browserify/webpack/etc, and a very bad idea to enable people to hurt themselves by not using it, by providing them with workarounds.

In other words, a "non-Browserify/Webpack environment" is obsolete, and is best served by becoming one.


List site documentation is not formatted

Please fill out the below template as best you can.
Description of Issue
List site documentation is not formatted

Steps to Reproduce the Issue

Navigate to http://engineering.cerner.com/terra-core/#/site/list
Scroll down to the React Props documentation
Observe the prop table is not formatted

Expected Outcomes

The List site documentation is properly formatted

This is coming from props documentation in a markdown file: https://github.com/cerner/terra-core/blob/master/packages/terra-list/docs/README.md
Looks like we should remove that from the markdown file as it should be coming from the JSDoc comments in the src code via prop table component.


[api-docs] add missing interaction type

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/06218a9ea23cb66082568bb4436724f083f605b8

ncn


typescript: token function typings

Hello, it's me again 😆
your latest fix to https://github.com/drwpow/cobalt-ui/issues/17 doesn't work as expected.
I doesn't complains about mode as second argument needed anymore. Great.
But I don't get intellisense for mode (tested with your apple example):

Also, I can put anything in both slots:

Hello! I just fixed a TS error related to the token() function.
For your first problem, I’m not sure if intellisense is able to auto-fill the value. Sadly, you’ll just have to provide the value yourself, but it can tell you if the types don’t match.
For the 2nd problem—“no error”—I fixed a bug where it should throw a type error if you are trying to access a mode that doesn’t exist. Note that the signatures will have to match exactly, e.g.:
const mode = 'light'; // auto-cast as `string`
token('color.foreground', mode); // ❌ expecting `'light' | 'dark'`

const mode: 'light' | 'dark' = 'light';
token('color.foreground', mode); // ✅

In regards to runtime errors, however, it’s by design that this won’t throw a runtime error; it will just fall back to whatever the default value is. This is probably more generally useful, as tokens are meant to sometimes omit modes when they don’t need them.


Formatting combinations is not disabled

Describe the bug
The formatting doesn`t work as it is supposed to.
To Reproduce
Steps to reproduce the behavior:

Go to 'Options' tab of the SunEditor site
Click on the shortcutsDisable parameter
Create a new configuration
Write text and click on formatting [combinations]

Expected behavior
If shortcutsDisable array contains formatting features ('bold', 'underline', 'italic', 'undo'), the font of the text should not be changed.
[Screenshots]

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: [97.0.4692.99]

Additional context
I would like to add that ctrl + shift + s and ctrl + [ or ] combinations works correctly. If it is not a bug, could you please provide some information how to fix it? Thanks!

The 2.43.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Rotary encoder usage

Hi,
Has anyone tried to use an rotary encoder instead of the the 3 button switches?
What sw changes and hw have you used?

Encoder support is available and implemented for several of the display options.  I'm using it on my personal grill and it works fairly well!


ShadyCSS doesn't work in IE11

The reason is because <template> is not implemented in IE11.
One can of course add template polyfill like here http://codepen.io/elmariofredo/pen/mRazLq but from my understanding it doesn't have much sense to have shadyCss but not template polyfill in skate-web-components package.
Please let me know what do you think.

Happy to add it to make it IE11 compat. Woud you mind PR'ing? Seems you have the ability to easily test it at the moment.

Sure PR is on its way

related https://github.com/webcomponents/shadycss/issues/51

done... sorry it took so long got stuck between my birthday party and "awesome" IE11 debug tools 😉

Happy birthday! Thanks for the PR; reviewing now.


lengthy scrapes having issues with resuming past a certain point

Latest twint, python 3.7
There's a strange issue when using twint to scrape hashtags past a certain exploration point into the past.
as far as twint goes, it just stops. I've confirmed that sometimes it can be resumed by inserting the oldest id (max_id) into the search query but even then there's a hard limit. It's also not a database issue because the failures occur without any disk output.
This occurs on many hashtags but I've selected these three to test with.
#Coup: 41894 tweets, back to 2019-06-03 01:56:12
#Impeachment: 62580 tweets, back to 2019-10-31 11:12:28
#Qanon: 67393 tweets, back to 2019-10-29 13:48:19
All three were started yesterday at around 1700 Eastern and left to run until complete.
Convenient CLI to those points:
twint -s "#Coup max_id:1135440027171917825" --database "#Coup.db"
twint -s "#Impeachment max_id:1189938194084704256" --database "#Impeachment.db"
twint -s "#Qanon max_id:1189252639965532165" --database "#Qanon.db"
As you can see, the error is inconsistent, too; somewhere between 0 and ~10 of these error lines. (Always the same error if present.)

For all 3 searches (and others) there is clearly more to scrape:

If you need any more data please let me know!
EDIT: Actually, strangely, searching #Coup seems to be suppressed in some way and only gives further results when manually rolling down the date by one day: #Coup until:2019-06-02). Very strange behavior. There's a gap of around 7 hours between the two tweets. No idea if there's anything between them!
EDIT 2: With some more testing I can see that not even rolling the date back always works.

CRITICAL:root:twint.run:Twint:Feed:noDataExpecting value: line 1 column 1 (char 0) is strongly related to #567
I solved this moving from HTTPS to HTTP, which is not a great idea. So if we use HTTPS we get a few errors, and if we don't someone could see what we are doing. I'm open to ideas
About the strange behavior of those hashtags, what I can suggest you is to split the datetime intervals in smaller ones

CRITICAL:root:twint.run:Twint:Feed:noDataExpecting value: line 1 column 1 (char 0) is strongly related to #567
I solved this moving from HTTPS to HTTP, which is not a great idea. So if we use HTTPS we get a few errors, and if we don't someone could see what we are doing. I'm open to ideas
About the strange behavior of those hashtags, what I can suggest you is to split the datetime intervals in smaller ones

What do you mean by moving to HTTP? Is it a OS setup? Could you point me to guides how to do it on Linux/Ubuntu.

@stormstricker I'm sorry but here we discuss only about issues related to Twint. There are a lot of great resources out there! DuckDuckGo is your friend!


[FLINK-15515][hive][doc] Document that Hive connector should be used …

…with blink planner

What is the purpose of the change
Document Hive connector only works with blink planner.
Brief change log

Document Hive connector only works with blink planner

Verifying this change
NA
Does this pull request potentially affect one of the following parts:
NA
Documentation
NA

cc @JingsongLi @bowenli86 @xuefuz
We have documentation about using Hive connector from scala shell. However, it seems scala shell always uses old planner. Would like to know your opinions what we should do about that doc. Thanks.

@bowenli86 I have updated the zh docs.
For scala shell, I think we shouldn't let users use it for hive connector, until we resolve https://issues.apache.org/jira/browse/FLINK-15539.  @zjffdu what do you think?

Right, currently running hive-connector in scala shell is not recommended.

LGTM, merging


(using with Hapi) app.address is not a function

I'm trying to setup supertest with my Hapi.js server. I'm not sure if this is the correct way. Please advise me on what is..
in my server.js,
const const Hapi = require('hapi');
const server = new Hapi.Server();
server.connection({
    // host: '<IP_ADDRESS>',
    port: process.env.PORT || 8080,
    routes: { cors: true }
});
server.route([
{
    method: 'GET',
    path:'/',
    handler: (request, reply) => {

        return reply('hello world');
    },
    config: { auth: false }
}
]);
module.exports = server;

then in my server.test.js
const request = require('supertest');
const server = require('./server');
it('gets a response', () => {
	request(server)
		.get('/')
		.set('Accept', 'application/json')
      	.expect('Content-Type', /json/)
      	.expect(200, done);
});

am I exporting the wrong thing?

Use server.listener

same issue with fastify

fixed with request(app.server)
you might also want to use a specific port / depending on how complex your tests are...
app.listen('3001');


Add 'Hairline' and 'ExtraBlack' as valid weight names.

Description
The weight names 'Hairline' and 'ExtraBlack' are common used weight names. They do not match with the CSS classes, but there was already an entry for 'ExtraBlack' at 1000. So I simply have completed, what seems not to be finished, yet.
I also have created a view demo fonts with all weights for extending the unittests.
To Do

[x] update CHANGELOG.md
[x] wait for all checks to pass (there is a trailing space my IDE has removed because of the code style which causes a fail.)
[ ] request a review

@felipesanches What do you think about this?
There was already an entry for 'ExtraBlack':
https://github.com/googlefonts/fontbakery/blob/0035248cfb5e112ac24639efbed47879d29a967f/Lib/fontbakery/parse.py#L37
So, I simply completed it in different areas as well and added the very commonly used style 'Hairline'.

"Hairline": {"usWeightClass": 50, "fvar": 50.0},

I think we've got a bunch of families with weight axes going under 100 that reach down to 1, so I am not sure what the names will be.
However, since Workspace only supports 9 weights, 100 to 900, we want the fvar named instances to match, and we don't offer more than 9 weights in static fonts.
So, for GF we may need a value different than 50, and therefore perhaps these values need to be configurable per profile.

"Hairline": {"usWeightClass": 50, "fvar": 50.0},

I think we've got a bunch of families with weight axes going under 100 that reach down to 1, so I am not sure what the names will be.
However, since Workspace only supports 9 weights, 100 to 900, we want the fvar named instances to match, and we don't offer more than 9 weights in static fonts.
So, for GF we may need a value different than 50, and therefore perhaps these values need to be configurable per profile.
I guess someone should grep the GF library for wght axis ranges and STAT tables for any named instances at 99 or below and provide some data to inform the decisions here :)

The only font I was able to find in google font repository:
/GitHub/google/fonts/ofl/sofiasans/SofiaSans-Italic[wdth,wght].ttf
With a usWeightClass value of 1
BUT at the end it makes no sense to grep all fonts and look for this value, because many people hacked this value in the past years. You may have heard about the PowerPoint bug why people started to set the usWeightClass value to 250 or greater?!
Better would be to have a look to other foundries if they use styles like Hairline or ExtraBlack – and they do, eg.:
https://klim.co.nz/retail-fonts/karbon/ (Hairline)
https://www.hvdfonts.com/fonts/fabrikat-normal (Hairline)
https://lineto.com/typefaces/circular (ExtraBlack)
Just to name a few.

@davelab6 Any thoughts on my last comment are very welcome. Thanks.

I'm closing this PR due to long-term inactivity.
If there's still interest in this, we should open an issue to discuss how to move forward.

I think we've got a bunch of families with weight axes going under 100 that reach down to 1, so I am not sure what the names will be.

@felipesanches Even though Google fonts may not have Hairline styles, it's not unusual. Even @davelab6 agreed on that, please see his comment above. I still think it should be integrated into fontbakery somehow/somewhere. Because there are many typeface designs out there which do have hairline styles – the most prominent might be Helvetica Now Display Hairline: http://www.identifont.com/show?5BDM


Support to open local repository or file transport protocol.

Hello
I have some questions.
How can I open local repository or file transport protocol?
If not supported now, do you have a plan to support it?
I'd like to use go-git instead of https://github.com/gogits/git.
See https://github.com/gogits/git/issues/17
Thanks.

Hello. Can I init a local repositories by this library? I need implement some functions for multi-users. Init their repositories would be needed for me. If not, any plans?

Thanks to support local repository!!
But I want to open repository from HEAD.
hash, _ := repo.Head("")

for commit := range repo.Commits(hash) {
 fmt.Println(commit)
}

Now you supported to packfile but not supported non packed object .git/objects/HASH[0:2]/HASH[2:64].
Do you have a plan to support non packed object ?

we don't support spare objects right now, you can save this issues running git gc before open it with go-git

@oplibs we are working on this right now, this is on the branch v4


Purge multipartuploadhandler

Removes multi part handler since it's an unused interface.
Closes #72

@agibsonccc looking at your other PR, it seems like this one is redundant. correct?

@maxpumperla no this was meant to be a self contained change. There are further changes I'm doing on that PR.


Switch on interface with single case not considered exhaustive

TypeScript Version:  2.5.2
Code
interface Action {
  readonly type: 'Action1',
}

export const assertNever = (action:never):never => {
  throw new Error('Unhandled action')
}

const fn = (action: Action) => {
  switch (action.type) {
    case 'Action1': {
      return 'action1'
    }

    default: {
      return assertNever(action) // incorrect error
    }
  }
}

Expected behavior:
action inside default block should have type never
Actual behavior:
action inside default block has type Action
Similar fixed issue: #12771
Playground: https://goo.gl/rs6TgW

Hey @mpal9000, this looks to me like a potential duplicate of #18056

Hi, you can close this one if you want. Checking action.type in assertNever() is not a solution, because it doesn't work for unions. A built in exhaustiveness checking in switch and future match, without manual assertions, would be an awesome feature in my opinion.


Hybrid golang example is not useful

https://github.com/google/tink/blob/master/docs/GOLANG-HOWTO.md#hybrid-encryption-and-decryption
The example shows how to get a public key from a private key for use in hybrid encryption.
If I understand the use case correctly, the purpose of hybrid is to use the public key of the recipient, not a random public key. It is not at all clear to me how keysets can be used to do that.
Supporting info, from the primitive docs:

Hybrid Encryption combines the efficiency of symmetric encryption with the convenience of public-key encryption: to encrypt a message a fresh symmetric key is generated and used to encrypt the actual plaintext data, while the recipient’s public key is used to encrypt the symmetric key only, and the final ciphertext consists of the symmetric ciphertext and the encrypted symmetric key.

If I understand the use case correctly, the purpose of hybrid is to use the public key of the recipient, not a random public key. It is not at all clear to me how keysets can be used to do that.

Your understanding is correct. The recipient generates a key pair, persists the private key and export the public key using https://github.com/google/tink/blob/master/go/insecurecleartextkeyset/insecurecleartextkeyset.go.
// export the private keyset
kh, err := keyset.NewHandle(hybrid.ECIESHKDFAES128CTRHMACSHA256KeyTemplate())
if err != nil {
  return nil, err
}
exported := &keyset.MemReaderWriter{}
if err := insecurecleartextkeyset.Write(kh, exported); err != nil {
  return nil, err
}
serializedPrivateKeyset, err := proto.Marshal(exported.Keyset)
if err != nil {
  return nil, err
}

// store serializedPrivateKeyset somewhere

// export the public keyset
khPub, err := kh.Public()
exported = &keyset.MemReaderWriter{}
if err := insecurecleartextkeyset.Write(khPub, exported); err != nil {
  return nil, err
}
serializedPublicKeyset, err := proto.Marshal(exported.Keyset)
if err != nil {
  return nil, err
}

// share serializedPublicKeyset with the sender

Does it make sense?

You're right that the example needs more work. I'll update it. Thanks for the suggestion!

Thanks for making it clearer.


multi-tenancy

secrets for AWS are fetched from the corresponding KCP's IdentityRef, and matching secret are used as ProviderConfigRef for crossplane resources.
If identityRef is not specified, will use "default" in namespace "kubernetes-kops-operator-system" for the AWS secret and "default" for the providerConfig name.

LGMT


Build improvements  replace raw bash scripts with make issue #4

Build improvements  replace raw bash scripts with make
Signed-off-by: Abdul Hameed<EMAIL_ADDRESS>

@redhatHameed Thank you for contributing, but similar to #58 , I'd like to avoid vendoring, if possible.


java: Add JDK 17 to supported versions

Description
The minimum version I've set is the one I have tested on.
bash-4.4# java -version
openjdk version "17.0.1" 2021-10-19
OpenJDK Runtime Environment (build 17.0.1+12-39)
OpenJDK 64-Bit Server VM (build 17.0.1+12-39, mixed mode, sharing)
bash-4.4# java Target

from (openjdk:17).
Motivation and Context
Support new JDK versions.
How Has This Been Tested?
Tested profiling a demo app in openjdk:17 container.

Looks fine, but do you have any idea what the -39 version suffix in your test example means?

Nope :shrug:
I also tested with --java-safemode, this is the version we have parsed:
[2022-01-04 13:33:11,377] INFO: gprofiler.profilers.java: Checking support for java version JvmVersion(17.0.1, 12, 'OpenJDK 64-Bit Server VM')

seems fine

Looks fine, but do you have any idea what the -39 version suffix in your test example means?

Nope 🤷
I also tested with --java-safemode, this is the version we have parsed:
[2022-01-04 13:33:11,377] INFO: gprofiler.profilers.java: Checking support for java version JvmVersion(17.0.1, 12, 'OpenJDK 64-Bit Server VM')

seems fine

Yes we drop everything after any non-digit character because sometimes there's some platform name or stuff like that. Idk what that 39 is though

Only failed tests are the 2 with the:
E       AssertionError: unexpected 'grep' exit code: 127, stdout b'' stderr b"Inconsistency detected by ld.so: dl-open.c: 560: dl_open_worker: Assertion `_dl_debug_initialize (0, args->nsid)->r_state == RT_CONSISTENT' failed!\n"

so merging


Add the tools directory to CMAKE_PROGRAM_PATH

find_program and similar CMake functions begin their search in CMAKE_PROGRAM_PATH. This change allows finding of installed "tools" such as protoc from protobuf. As a result find_package(Protobuf REQUIRED) now locates and set Porobuf_PROTOC_EXECUTABLE properly.

Hi @adam4813, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

This is really important, thanks for submitting the PR!
In the future, we need to look at getting vcpkg_configure_cmake() to reuse vcpkg.cmake; I think it also needs this modification.


Logoff after click on Dashboard

After successfull login and click an the "Dashboard" button, i will be logged off. After relogin the "Dashboard" works fine. When i click at the "Board" button, i will sill log off. :(
Follow error is listed:

Thx in advance.

no solution yet?  get signed out every time i click Boards.

In IIS or Apache?

Am 15.09.2021 um 20:19 schrieb Leo A. @.***>:

no solution yet? get signed out every time i click Boards.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

apache

Apache

In IIS or Apache?
…
Am 15.09.2021 um 20:19 schrieb Leo A. @.***>:  no solution yet? get signed out every time i click Boards. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

I have exactly the same issue after installed to my ubuntu server today. I was able to solve this myself. The reason was I extracted the zip file to a temporary folder and copied all folders and files one by one to /var/www/html. That made me miss a hidden file .htaccess because it is invisible if not appending -a after ls. After copied the hidden file to my web root which is /var/www/html, everything works fine as expected.


add unit test for tardis (E6C) geometry

fix #62
@ambarb : You suggested this test
also fix #106

Please provide a reasonable value for tolerance and the conditions in which
it can be met.
On Mon, Apr 26, 2021, 11:51 AM Andi Barbour @.***>
wrote:

@.**** commented on this pull request.
In hkl/tests/test_tardis.py
https://github.com/bluesky/hklpy/pull/131#discussion_r620475378:

assert round(tardis.calc.energy, 5) == 0.573

this test is not necessary

ref = tardis.inverse(theta=41.996, omega=0, chi=0, phi=0, delta=6.410, gamma=0)

# FIXME: assert round(ref.h, 2) == 0.1

# FIXME: assert round(ref.k, 2) == 0.51

# FIXME: assert round(ref.l, 2) == 0.1

simulate the scan, computing hkl from angles

RE(scan([hw.det, tardis],tardis.theta, 0, 0.3, tardis.delta,0,0.5, num=5))

values as reported from LiveTable

with open("livedata_issue62.txt", "r") as fp:

   livedata = fp.read()

run_data = interpret_LiveTable(livedata)
tolerance = 0.05  # empirical
tolerance = 0.055  # empirical

@prjemian https://github.com/prjemian I can help with this. First let
me test two outstanding issue reports for bluesky/bluesky related to hklpy
dependancies so I know where to start any other conversations.
Do you want me to provide a reasonable value for tolerance or make
efforts to get the codebase in bluesky in a place so that you can use a
smaller value for tolerance?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bluesky/hklpy/pull/131#discussion_r620475378, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARMUMFLDL27OPZYF6Q27YDTKWKY5ANCNFSM43NQUSLA
.

I'm thinking that this repository (hklpy) should resolve problems with scanning with a diffractometer.  If there are problems with how hklpy uses bluesky.plans, those would be the issue for the bluesky repo.  But, you make a good case for bluesky to have some tests with diffractometers, so that the API is tested.

@ambarb: I'm thinking that you must have some custom routine that writes the reflections into a reflections stream.  The custom routine creates ophyd.Signal objects that it fills with the data from the reflection object (h, k, l, position=CustomPositionClass(x=1, y=2, z=3, ...)).  That object cannot be written by bluesky but it can be rearranged using a temporary Signal.  Here's how I would do that for samples:
def stream_samples(samples, label="samples"):
    if len(samples):
        yield from bps.create(label)
        for sname, lattice in samples.items():
            yield from bps.read(Signal(name=sname, value=lattice[:]))
        yield from bps.read(Signal(name="_keys", value=list(lattice._fields)))
        yield from bps.save()
    else:
        yield from bps.null()

yield from stream_samples(diffractometer.calc._samples)

In the interest of getting the 0.3.16 release this week, I'm moving this PR (and related issue #62) to the next milestone.

I'm thinking that this repository (hklpy) should resolve problems with scanning with a diffractometer. If there are problems with how hklpy uses bluesky.plans, those would be the issue for the bluesky repo. But, you make a good case for bluesky to have some tests with diffractometers, so that the API is tested.

I am a little confused why this repository should fix that.  This repo is basically a calculator that has to be tuned.  There are problems that @tacaswell is aware of because they were broken in bluesky and then fixed in bluesky and then broken in a different way.  There are two issues associated with how bluesky handles the computation in the plans.

https://github.com/bluesky/bluesky/issues/1196
https://github.com/bluesky/bluesky/issues/1284

There is also this that we should be aware of - and this is another reason why tuning of the computation needs to be altered when the diffractometer object is being commissioned at an instrument: https://github.com/bluesky/bluesky/issues/1431 hklpy does the computation for each move and I do not know well enough the "error" in the computation is insignificant for all use cases.

Please provide a reasonable value for tolerance and the conditions in which it can be met.
…

@prjemian People could conceivably want to scan steps as small as 0.001 r.l.u. (reciprocal lattice units), but once can easily add an order of magnitude smaller in some cases (0.0005).  For this, I wonder if getting data from LiveTable is okay or not.  Are the returned numbers round to 1e-3?  I think that is too inprecise.
Since r.l.u. are also coupled with the lattice and incident wavelength should we use r.l.u.?  Do you think the motor value reproducibility may be the better option since typically there is a precision of 1e-4 degrees for motors like theta on a huber diffractometer without an encoder?
but @prjemian

@ambarb : You are right.  Matters involving calculation or diffractometer setup belong here, scan issues belong in the bluesky repo.

The comparison with LiveTable is not the most precise but the tolerance here is far larger than round-off precision.  Nonetheless, the tests here with such large tolerances could be replaced by re-examination and use of content from the now-archived example tardis notebook.  That approach should yield tests that could pass.

the .ignore stops the notebook from rendering on the web so it is hard to see where in the code.  I'll take your word for it.

@ambarb: I've re-added the Tardis notebook (in this branch) as one of the example variations.  Is the artwork correct?

not quite ready for review, a few FIXME items remain to be investigated

@mrakitin @ambarb : Ready for review once the Actions workflow completes.

@mrakitin This is ready for review.

@mrakitin , @ambarb : Can we finalize this for merge by next week (6/14)?

Yes.  I can have a look in the next days. Thanks for the warning shot.

The rendered notebook is available at https://github.com/bluesky/hklpy/blob/8ed43037102106820a4c19350225de7cf4b79e69/examples/var_nslsii_tardis.ipynb. @ambarb, do you have any suggestions to that?

@mrakitin Thanks for the review.  Good points raised.  It will take me a couple days to get back to this.

CI is failing due to connection timeouts in various Python versions during the tardis unit test.  This is nauseating since the unit tests all pass locally (on one Python version).  Will re-run one more time, hoping that is sufficient.
The CI and the tests must become much more robust!

There are NO EPICS connections to be made.  Always fails in the tardis.wait_for_connection()

Fails in the CI, passes locally with Py3.8:
(bluesky_2021_2) mintadmin@mint-vm:~/.../Bluesky/hklpy$ pytest -vvv
=========================================================== test session starts ============================================================
platform linux -- Python 3.8.10, pytest-6.2.3, py-1.10.0, pluggy-0.13.1 -- /home/mintadmin/Apps/anaconda/envs/bluesky_2021_2/bin/python
cachedir: .pytest_cache
rootdir: /home/mintadmin/Documents/projects/Bluesky/hklpy, configfile: pytest.ini
plugins: anyio-2.2.0
collected 66 items

hkl/tests/test_diffract.py::test_calc_energy_permit PASSED                                                                           [  1%]
hkl/tests/test_diffract.py::test_energy PASSED                                                                                [  3%]
hkl/tests/test_diffract.py::test_energy_offset PASSED                                                                                [  4%]
hkl/tests/test_diffract.py::test_energy_offset_units PASSED                                                                          [  6%]
hkl/tests/test_diffract.py::test_energy_units_931eV PASSED                                                                           [  7%]
hkl/tests/test_diffract.py::test_energy_units_issue79 PASSED                                                                         [  9%]
hkl/tests/test_diffract.py::test_energy_units_offset PASSED                                                                          [ 10%]
hkl/tests/test_diffract.py::test_energy_units_issue86 PASSED                                                                         [ 12%]
hkl/tests/test_diffract.py::test_names PASSED                                                                                [ 13%]
hkl/tests/test_diffract.py::test_forward_solutions_table PASSED                                                                      [ 15%]
hkl/tests/test_diffract.py::test_pa PASSED                                                                                [ 16%]
hkl/tests/test_diffract.py::test_wh PASSED                                                                                [ 18%]
hkl/tests/test_diffract.py::test_show_constraints PASSED                                                                             [ 19%]
hkl/tests/test_diffract.py::test_apply_constraints PASSED                                                                            [ 21%]
hkl/tests/test_extra_motor.py::test_plain_fourc_not_fatal PASSED                                                                     [ 22%]
hkl/tests/test_extra_motor.py::test_extra_real_fatal PASSED                                                                          [ 24%]
hkl/tests/test_extra_motor.py::test_extra_real_not_fatal PASSED                                                                      [ 25%]
hkl/tests/test_extra_motor.py::test_extra_pseudo_not_fatal PASSED                                                                    [ 27%]
hkl/tests/test_extra_motor.py::test_fourc_position PASSED                                                                            [ 28%]
hkl/tests/test_extra_motor.py::test_fourc_extra_pseudo PASSED                                                                        [ 30%]
hkl/tests/test_fourc.py::test_initial PASSED                                                                                [ 31%]
hkl/tests/test_fourc.py::test_limits PASSED                                                                                [ 33%]
hkl/tests/test_fourc.py::test_check_value PASSED                                                                                [ 34%]
hkl/tests/test_fourc.py::test_move PASSED                                                                                [ 36%]
hkl/tests/test_fourc.py::test_hl_scan PASSED                                                                                [ 37%]
hkl/tests/test_fourc.py::test_h00_scan PASSED                                                                                [ 39%]
hkl/tests/test_fourc.py::test_hkl_scan PASSED                                                                                [ 40%]
hkl/tests/test_fourc.py::test_hkl_range_error PASSED                                                                                [ 42%]
hkl/tests/test_fourc.py::test_real_axis PASSED                                                                                [ 43%]
hkl/tests/test_fourc.py::test_axis_contention PASSED                                                                                [ 45%]
hkl/tests/test_fourc.py::test_real_axis_range_multi PASSED                                                                           [ 46%]
hkl/tests/test_fourc.py::test_real_axis_range_error PASSED                                                                           [ 48%]
hkl/tests/test_sample.py::test_compute_UB PASSED                                                                                [ 50%]
hkl/tests/test_sample.py::test_orientation_reflections PASSED                                                                        [ 51%]
hkl/tests/test_sample.py::test_reflections_details PASSED                                                                            [ 53%]
hkl/tests/test_sample.py::test_swap_orientation_reflections PASSED                                                                   [ 54%]
hkl/tests/test_tardis.py::test_params PASSED                                                                                [ 56%]
hkl/tests/test_tardis.py::test_reachable PASSED                                                                                [ 57%]
hkl/tests/test_tardis.py::test_inversion PASSED                                                                                [ 59%]
hkl/tests/test_tardis.py::test_unreachable PASSED                                                                                [ 60%]
hkl/tests/test_tardis.py::test_issue62[0.0-0.0-0.0-0.0-0.0-0.0] PASSED                                                               [ 62%]
hkl/tests/test_tardis.py::test_issue62[0.075-0.125-0.0-5.3e-05-8.3e-05-0.00078] PASSED                                               [ 63%]
hkl/tests/test_tardis.py::test_issue62[0.15-0.25-0.0-0.000107-0.000166-0.001561] PASSED                                              [ 65%]
hkl/tests/test_tardis.py::test_issue62[0.225-0.375-0.0-0.00016-0.000249-0.002341] PASSED                                             [ 66%]
hkl/tests/test_tardis.py::test_issue62[0.3-0.5-0.0-0.000214-0.000333-0.003121] PASSED                                                [ 68%]
hkl/tests/test_tardis.py::test_sample1 PASSED                                                                                [ 69%]
hkl/tests/test_tardis.py::test_sample1_calc_only PASSED                                                                              [ 71%]
hkl/tests/test_tardis.py::test_sample1_UB PASSED                                                                                [ 72%]
hkl/tests/test_tardis.py::test_tardis_forward[1.61198-4-4-0-angles0] PASSED                                                          [ 74%]
hkl/tests/test_tardis.py::test_tardis_forward[1.61198-4-1-0-angles1] PASSED                                                          [ 75%]
hkl/tests/test_tardis.py::test_tardis_forward[1.60911-6-0-0-angles2] PASSED                                                          [ 77%]
hkl/tests/test_tardis.py::test_tardis_forward[1.60954-3-2-0-angles3] PASSED                                                          [ 78%]
hkl/tests/test_tardis.py::test_tardis_forward[1.60954-5-4-0-angles4] PASSED                                                          [ 80%]
hkl/tests/test_tardis.py::test_tardis_forward[1.60954-4-5-0-angles5] PASSED                                                          [ 81%]
hkl/tests/test_user.py::test_select_diffractometer PASSED                                                                            [ 83%]
hkl/tests/test_user.py::test_cahkl PASSED                                                                                [ 84%]
hkl/tests/test_user.py::test_cahkl_table PASSED                                                                                [ 86%]
hkl/tests/test_user.py::test_calc_UB PASSED                                                                                [ 87%]
hkl/tests/test_user.py::test_list_samples PASSED                                                                                [ 89%]
hkl/tests/test_user.py::test_new_sample PASSED                                                                                [ 90%]
hkl/tests/test_user.py::test_set_energy PASSED                                                                                [ 92%]
hkl/tests/test_user.py::test_setor PASSED                                                                                [ 93%]
hkl/tests/test_user.py::test_show_sample PASSED                                                                                [ 95%]
hkl/tests/test_user.py::test_update_sample PASSED                                                                                [ 96%]
hkl/tests/test_user.py::test_pa PASSED                                                                                [ 98%]
hkl/tests/test_user.py::test_wh PASSED                                                                                [100%]

=========================================================== 66 passed in 13.29s ============================================================
(bluesky_2021_2) mintadmin@mint-vm:~/.../Bluesky/hklpy$


android_deferred_components_setup_files generates invalid build.gradle

Steps to reproduce

Create a new app with flutter create myApp --platforms android -a java
Follow deferred components guide from docs https://docs.flutter.dev/perf/deferred-components
Copy files from build/android_deferred_components_setup_files into their respective paths (including boxComponent/build.gradle, which is where the problem happens)
Try to flutter build appbundle again

Actual results
flutter build appbundle fails with the following error
1: Task failed with an exception.
-----------
* Where:
Build file '[PROJECT PATH]\android\boxComponent\build.gradle' line: 22

* What went wrong:
A problem occurred evaluating project ':boxComponent'.
> Could not get unknown property 'flutter' for extension 'android' of type com.android.build.gradle.internal.dsl.DynamicFeatureExtension.

build.gradle:
android {
    compileSdk = flutter.compileSdkVersion
    //...

    defaultConfig {
        minSdk = flutter.minSdkVersion
        targetSdk = flutter.targetSdkVersion
        //...
    }
    //...
}

This problem does not happen when using flutter 3.7.12, but does on the latest release 3.22.2 (I'm not sure when it started)
Comparing the output of both versions, the older one uses hard-coded values for the sdk versions, and after replacing then in the newer one's file for respectively 33, 21 and 33, the build works as intended
Logs

Logs

<!-- Paste your logs here -->

Flutter Doctor output

Doctor output
[✓] Flutter (Channel stable, 3.22.2, on Microsoft Windows [versÆo 10.0.22631.3737], locale pt-BR)
    • Flutter version 3.22.2 on channel stable at C:\Users\[REDACTED]\AppData\Local\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (2 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at C:\Users\[REDACTED]\AppData\Local\Android\Sdk
    • Platform android-35, build-tools 35.0.0
    • ANDROID_HOME = C:\Users\[REDACTED]\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop Windows apps (Ferramentas de Build do Visual Studio 2022 17.10.3)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools
    • Ferramentas de Build do Visual Studio 2022 version 17.10.35013.160
    • Windows 10 SDK version 10.0.22621.0

[✓] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at C:\Users\[REDACTED]\AppData\Local\Programs\IntelliJ IDEA Ultimate
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.90.2)
    • VS Code at C:\Users\[REDACTED]\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [versÆo 10.0.22631.3737]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 126.0.6478.114
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 126.0.2592.68

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @Levyks, I got another error when trying to reproduce this issue on my end. Could you please share a sample project (it would be ideal if it's a GitHub repository) so that I can pull and try it?

Hi @Levyks, I got another error when trying to reproduce this issue on my end. Could you please share a sample project (it would be ideal if it's a GitHub repository) so that I can pull and try it?

Levyks/flutter_deferred_bug_reproduction
I have deleted the android/boxComponent folder so that you can have the flutter build appbundle command generate it for you.
Although, even after applying "my fix" (changing all flutter.[something] to hardcoded values in android/boxComponent/build.gradle), flutter run does not work for me, only flutter build appbundle.
Everything works as expected in 3.7.12 (except for #145876 which makes it impossible to deploy to the play store, but that bug happens in both versions).

Thanks for your update. I can reproduce the issue now. Here is the complete error output:

Output log
➜  flutter_deferred_bug_reproduction git:(master) ✗ flutterm build appbundle
Deferred components prebuild validation passed.

Shrinking has been disabled for this build due to deferred components. Shrinking is not available for multi-apk applications. This limitation is expected to be removed when Gradle plugin 4.2+
is available in Flutter.

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* Where:
Build file '/Users/huynq/Documents/NEVERCODE.IO/RepoduceProjects/OPClone/flutter_deferred_bug_reproduction/android/boxComponent/build.gradle' line: 22

* What went wrong:
A problem occurred evaluating project ':boxComponent'.
> Could not get unknown property 'flutter' for extension 'android' of type com.android.build.gradle.internal.dsl.DynamicFeatureExtension.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':boxComponent'.
> com.android.builder.errors.EvalIssueException: compileSdkVersion is not specified. Please add it to build.gradle

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 23s
Running Gradle task 'bundleRelease'...                             24.3s
Gradle task bundleRelease failed with exit code 1

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.22.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (31 hours ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (3 available)
    • iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop) • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome                                   • web-javascript • Google Chrome 125.0.6422.142

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.23.0-13.0.pre.300, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.23.0-13.0.pre.300 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1cb003b8fb (28 hours ago), 2024-06-22 16:41:39 -0700
    • Engine revision 33415c6ee7
    • Dart version 3.5.0 (build 3.5.0-288.0.dev)
    • DevTools version 2.36.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.90.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 126.0.6478.63

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Although, even after applying "my fix" (changing all flutter.[something] to hardcoded values in android/boxComponent/build.gradle), flutter run does not work for me, only flutter build appbundle.

I've found out that the version of com.google.android.play:core mentioned in the docs (1.8.0) does not work with Flutter 3.22, after updating it to 1.10.3, I got the example to work in both flutter run and flutter build appbundle + build-apks --local-testing + install-apks, although they still don't work when uploading to the Play Store as mentioned in issue #145876
But I guess that's an issue we should open on the docs repo?

Yes, please file an issue on website repository for a request to update the doc. Thank you!

From triage: @mariamhas This is an instance of a sample project not working. We are deferring to you regarding prioritization.

Any update on this task? The issue is even more critical, because deferred-components are not compatible with must-have targetSdkVersion 34


Add this repo to the linting workflow

@nkakouros I imagined this repo had the reusable workflow but it turns out not to. I fixed lint errors locally just now but just FYI they could be useful here too. If this repo will be scarcely touched we might not want to waste CI minutes here.

I fixed that.


Instantiate structured configs

Closes #472
The idea is to add an instantiate_structured_configs keyword argument to the OmegaConf.to_container method.
If OmegaConf.to_container(cfg, instantiate_structured_configs=True) is called with this new flag, the returned python object will include instantiated dataclass or attrs instances.

Looking at the code, I believe this does not handle nested structured configs right now.
Also, this means to_container() can actually return an instance now, which is a bit weird:

The same is not great in such a case.
I did not see see the expected type changes demonstrating you are accounting to this at a glance.

We should probably introduce an alias to to_container(), maybe to_object() which will call to_container but will allow Any return type.

Looking at the code, I believe this does not handle nested structured configs right now.
Also, this means to_container() can actually return an instance now, which is a bit weird:

The same is not great in such a case.
I did not see see the expected type changes demonstrating you are accounting to this at a glance.

We should probably introduce an alias to to_container(), maybe to_object() which will call to_container but will allow Any return type.

Looking at the code, I believe this does not handle nested structured configs right now.
I am having success with nested structured configs:

@dataclass
class Inner:
    cost: float

@dataclass
class Outer:
    i: Inner

cfg = OmegaConf.create(Outer(Inner(1.23)))
print(OmegaConf.to_container(cfg, instantiate_structured_configs=True))
# prints Outer(i=Inner(cost=1.23))

It is also working for e.g. structured config as a dict value type.

Also, this means to_container() can actually return an instance now, which is a bit weird:
1. The same is not great in such a case.

2. I did not see see the expected type changes demonstrating you are accounting to this at a glance.

I see what you mean. I'm surprised that mypy did not catch that.

We should probably introduce an alias to to_container(), maybe to_object() which will call to_container but will allow Any return type.
Ok, sounds good. So to_container will keep the old behavior (return python primitives) and to_object will instantiate structured configs.

Looking at the code, I believe this does not handle nested structured configs right now.
I am having success with nested structured configs:

@dataclass
class Inner:
    cost: float

@dataclass
class Outer:
    i: Inner

cfg = OmegaConf.create(Outer(Inner(1.23)))
print(OmegaConf.to_container(cfg, instantiate_structured_configs=True))
# prints Outer(i=Inner(cost=1.23))

It is also working for e.g. structured config as a dict value type.

Also, this means to_container() can actually return an instance now, which is a bit weird:
1. The same is not great in such a case.

2. I did not see see the expected type changes demonstrating you are accounting to this at a glance.

I see what you mean. I'm surprised that mypy did not catch that.

We should probably introduce an alias to to_container(), maybe to_object() which will call to_container but will allow Any return type.
Ok, sounds good. So to_container will keep the old behavior (return python primitives) and to_object will instantiate structured configs.

Rebased onto master

I am having success with nested structured configs:

Please add actual tests.

I've added tests for nested structured config (https://github.com/omry/omegaconf/pull/502/commits/f02261eaf6b395728eaaecc20fe9280713aa899c).

I also noticed that you are using get_structured_config_data() which is not designed for this (it's used to convert from an sc to a dictconfig) and is actually a rather weird function.

The get_structured_config_data function is only used in the case where a dataclass subclasses a Dict:
@dataclass
class Str2StrWithField(Dict[str, str]):
    foo: str = "bar"

When the _instantiate_structured_config_impl function instantiates a Str2StrWithField object, it first does
result = Str2StrWithField(foo=...)

to create the object, then it does
result.update(remaining keys that are not "foo")

The get_structured_config_data function is used to figure out which keys should be passed as keyword arguments in the first step, and which keys should be passed to result.update` in the second step.

Can you explain what you are using it for exactly, it's not clear to me looking at the code what value it provides you. (it's returning a dictionary where values can be DictConfigs).

Hmm...

@omry I noticed the review request, but since I'm just discovering this PR now, I'd rather wait until your current comments have been addressed by @Jasha10

@odelalleau I'll ping you when I've finished addressing the comments.

Summary of API changes made in recent commits:

to_object fails with MissingMandatoryValue if any fields belonging to a Structured Config are MISSING
If a DictConfig has keys that do not appear as fields of the target dataclass, those extra key/value fields are handled as follows:

If the dataclass is a subclass of Dict: the extra keys/values are added to the dict using dataclass_instance.update(...).
If the dataclass is not a subclass of Dict: the extra keys/values are set as attributes using setattr(dataclass_instance, key, value).

TODO: Update documentation:

[ ] a description and example of OmegaConf.to_object
[ ] a description and example of the new SCMode.INSTANTIATE Enum member

@odelalleau , @Jasha10 : Just want to make sure you are both on the same page:
this functionality is not scheduled for 2.1, I would rather to keep the focus on thins with the 2.1 milestone.

@odelalleau , @Jasha10 : Just want to make sure you are both on the same page:
this functionality is not scheduled for 2.1, I would rather to keep the focus on thins with the 2.1 milestone.

Doesn't really matter to me, but as far as I'm concerned I have no objection to have it included in 2.1.

Okay, I am adding this to 2.1 tentatively. Depending on time constraints because it's mostly new functionality and low risk to existing functionality.


fix(#1952): prevent cypress errors when running tests in browser

I still express the same issue with this pull request

my cypress version
Cypress package version: 13.13.0
Cypress binary version: 13.13.0
Electron version: 27.3.10
Bundled Node version:
18.17.1

issue is actually resolved in alpha for both react and angular

Closing this PR as it's no longer necessary, the issue was fixed in another PR


Multi-line sentence translation

Is your feature request related to a problem? Please describe.
Sentence translation only translates the current line of text, even if the sentence spans multiple lines.
Describe the solution you'd like
Some texts may consistently include punctuation (periods), while others may not. Perhaps there could be a per-book setting (with a configurable default -- perhaps in the language settings?) to indicate what characters are considered sentence delimiters (and, in particular, whether newlines are considered sentence delimiters).
Alternatively, or in addition, perhaps there could be a separate option to pass all of the highlighted text (which may span multiple lines) to the configured sentence translation page.
Describe alternatives you've considered
Alternatives include:

Manually editing each book to remove newlines from sentences.
Copy/paste from the source text into the sentence translation page, or copying/pasting one line at a time (See issue #427) into the sentence translation page.

Additional context
In the screenshot below, I have a word within a 2-line sentence selected. When I hit 't', only the line containing the highlighted word is passed to the translation page. I would like for both lines to be passed. This particular text consistently has periods to delimit sentences.

Actually, a better solution, rather than a per-book import option, might be just to have separate hotkeys for "translate line" and "translate sentence". The former would work the same way it works currently. The latter would scan forwards and backwards for the previous and next sentence delimiter and translate everything in between. Sentence delimiters could be configurable per-language.

Thanks @bwkimmel .
The challenge here is that Lute thinks that sentences that break across lines are separate things.  Parsing gets pretty tough with various scenarios, song lyrics, etc.  Lute thinks these are two sentences, even though that's obviously not the case:
I have
a fast car.

I usually remove all of the unwanted newlines from simple imports ... but that gets messy.  Sometimes I just live with it.
Sentence delimiters are configurable per language already :-) in the settings > language >  forms.

I don't think I can implement anything for this ... but Lute does have a "translate page" option in the sidebar that really gives you what you need, without me implementing another feature (which could get tricky!)

Given the above, I'll close this.  Cheers and thank you, LMK if you have a different idea.


Warning about "No such attribute from_accepted_tag" from activities

(I guess this is in the same vein as #115, so was unsure whether to add a new issue or not, please just close this one if you like.)
Anyway, when iterating over activities after get_activities, I get two warnings for each activity, one about utc_offset, the other one is that mentioned in the title:
No such attribute utc_offset on entity <Activity id=None name=None resource_state=None>
No such attribute from_accepted_tag on entity <Activity id=N name='Foo' resource_state=2>

Where I've removed the actual Activity id and name for the second one.  Is this second one also a case of deprecated attributes?
I installed with pip, so have v0.6.6 as far as I can see. I'm using Python 3.

I'm assuming these are either new or deprecated attributes, yes (don't remember exactly under what circumstances it emits that warning).  So, you can ignore the warning for now, but it points to something needed to be cleaned up.  Thanks for reporting.


Remove last value on belongsToMany releationship

Laravel Version: 5.5.40
Voyager Version: 1.1.1
PHP Version: 7.0
Database Driver & Version: mysqli / mysqlnd 5.0.12-dev

Description:
If you delete all values from the belongToMany field, one of them is not deleted.
Steps To Reproduce:
Create BelongsToMany Relationship in some Bread.
Add two relations in this entity, save.
Open it, remove relations. Save.
One relations don't removed.
Cause
vendor/tcg/voyager/src/Http/Controllers/Controller.php, line 62.
 if ((isset($options->type) && $options->type !== 'belongsToMany') || $row->field !== 'user_belongsto_role_relationship')
Because of the second part of the expression, the condition is always true.
remove this
  $row->field !== 'user_belongsto_role_relationship'
from condition - relations work fine.
WTF is this condition here?

#3112

Its an "emergency-fix" otherwise Voyager would break when submitting your user-profile.
Also please watch your words - thats unnecessary

This emergency fix make a big bug.

A smaller bug than the fact that Voyager would break without it

Fixed in #3016.
Merged into 1.x


simple to do list using angularJS

Project Name : to do list
The project is made using angularJS , a frontend frameword developed by Google

@pranjay-poddar  this completes the task given in issue #14 . You may close this issue.

@pranjay-poddar please review this issue.

@pranjay-poddar this completes the task given in issue #14 . You may close this issue.

add this issue number with the PR and not as a separate comment

@pranjay-poddar this completes the task given in issue #14 . You may close this issue.

add this issue number with the PR and not as a separate comment

@pranjay-poddar  Done


Refactor raymarchers as operators with a custom attribute

Standardizing raymarchers as a top-level operator would afford the user more unified control over the SDF evaluation stack, making #17 more viable.

Done.


updated question.model.js

Related Issue
closes #163, now the user is able to add questions link as well
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Screenshots

Original
Updated

original screenshot
updated screenshot

@codewithvk pls review


On non-fingerprint hardware is there a way to fallback to backup auth methods?

Hey guys,
I'm not sure if this is an issue, but wouldn't be logic that if the plugin does not detect fingerprint hardware to fallback to backup methods (PIN, Pattern or Password) ... I've been looking for a way to do this.
Can anyone point me to the right direction?

Does this work?
I am testing on One Plus 5.
With fingerprint added this works. But if I remove fingerprint on device and only have "Pin" screen lock security, it doesn't work.
If get following result from isAvailable() function:
{hasEnrolledFingerprints: false, isAvailable: false, isHardwareDetected: true}
I am expecting a behaviour that if fingerprint isn't setup on device it automatically fallbacks to backup method.

Yes, it should still work.  You will get false from isAvailable() but you can still call the encrypt() method.  Durning the encrypt flow the plugin checks isAvailable() and if it returns false then it launches the backup authentication.


Failed to add reference. The package 'SQLitePCLRaw.lib.e_sqlite3.ios' tried to add a framework reference to 'System.Drawing.Common.dll' which was not found in the GAC.

I am trying to update Microsoft.EntityFrameworkCore.Sqlite in my Xamarin.iOS project and get the follwoing error:

Failed to add reference. The package 'SQLitePCLRaw.lib.e_sqlite3.ios' tried to add a framework reference to 'System.Drawing.Common.dll' which was not found in the GAC. This is possibly a bug in the package. Please contact the package owners for assistance.

I already tried adding <DisableExtraReferences>true</DisableExtraReferences> to the project without any change...

I cannot imagine how that error message could happen.  System.Drawing.Common is not involved at all.
All I can suggest is to try the usual things for cases where your tooling is confused.  Clean and full rebuild?

Switching to package references solved the problem.


feat(storage-resize-images):wildcard in include/exclude paths

fixes #560
Allow wildcard notation for directory names.
Supplied path for images I want to be resized: /users/*/pictures
Include path tests
Unsuccessful upload to /users/portraits/avatar:

Uploaded successfully to /users/profile:

/pictures`:
Supplied paths for images I don't want to be resized: /animals/*/cats,/animals/*/dogs/*/sleepy
Exclude path tests
Unsuccessful upload to /animals/fluffy/dogs/large/sleepy:

Unsuccessful upload to /animals/fluffy/cats/large/sleepy:

Uploaded successfully to /animals/fluffy/dogs/large/fast:

Hey @kevinthecheung, do you mind going over the documentation aspect, please? 😄

Hey @kevinthecheung, do you mind going over the documentation aspect, please? 😄

Testing
Ignore paths

Include paths

@googlebot I consent

Hi @kevinthecheung.
Would it be possible to add this to your review list. Thanks!

Chatted with Kevin and applied some docs changes

Codecov Report

Merging #568 (ae477ce) into next (a339431) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next     #568   +/-   ##
=======================================
  Coverage   50.94%   50.94%
=======================================
  Files          30       30
  Lines        1180     1180
  Branches      154      154
=======================================
  Hits          601      601
  Misses        575      575
  Partials        4        4

Impacted Files
Coverage Δ

storage-resize-images/functions/src/util.ts
100.00% <100.00%> (ø)


C4Line as optional bug

The following results in nothing being shown on screen:
class WorkSpace: C4CanvasController {
    var line : C4Line?
    override func setup() {
        line = C4Line([C4Point(),C4Point(canvas.width,0)])
        line?.center = canvas.center
        canvas.add(line)
    }
}

But, the following does:
class WorkSpace: C4CanvasController {
    override func setup() {
        let line = C4Line([C4Point(),C4Point(canvas.width,0)])
        line.center = canvas.center
        canvas.add(line)
    }
}

slick.


Add dummy profile page url

For testing purposes, under PR #132.

Pull Request Test Coverage Report for Build 214

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.19%

Totals

Change from base Build 208:
0.0%

Covered Lines:
1873

Relevant Lines:
2100

💛  - Coveralls


Python 3.4 and WinPython

Hello. Could you please provide directions for building from source an executable for Python 3.4 via WinPython? 0.9.2 only seems compatible with up to 3.3x. Thank you!

I can do better than that! Go and grab the brand sparkly new development builds:
https://bintray.com/hgomersall/generic/PyFFTW-development-builds

I'm keen to know if it works ok for you. Please let me know!

Thanks for your response! This is great news... been on our radar for several months, but it has just now come to a head. When we fet this downloaded (kind of a process for us), i will switch over, run my unit tests, and let u know how it goes. Thanks again... very happy news!

Just making sure... there are no compiled exes here... just the dlls to create them right?

Uhm... I don't understand. The .whl files you find on the above bintray link you should be able to install with something like: pip install pyFFTW-0.10.0.dev0+4c652f3-cp35-none-win_amd64.whl.
It should then just work.

That will include all the dlls you need (though they won't be installed for the system).

Normally I jad installed via the WynPython external tools interface... pointing it to the PyFFTW .exe, which i believe is just a wrapper for the dlls. I jad never attempted to install a .whl as you suggest. However, i did attempt to do through the external tools interface... no joy yet. I will continue to fiddle with it. Thanks for ur help!

Just install pip and do it that way.

So I did that, no problem with pip. I am getting an error though from ln 16 in the pyfftw init, the relative imprt, which traces down to ln 155 in init pyfftw.pyfftw.pxd. "ValueError: numpy.dtype has wrong size try recompiling."
I am running on a 64 bit windows machine, and the .whl is cp34 win_amd64.
Plz excuse mispellings and shorthand... i have to tap the comments out on my smartphone unfortunately! :)

Hmmm, what version of Numpy are you using? I suspect you're using an older version than it is being built against.

Just to be clear, pyFFTW is built against Numpy 1.10.1. You should use this version of Numpy or later.

Oh wow... the version of numpy included in the latest version of WinPython i am using is 1.9.3... looks like I will have to manually install the latest Numpy then? This is not ideal since I am using the latest WinPython. We were hoping to track our version against WinPython rather than against multiple sub packages. I will try installing the new numpy and get back to you. Thanks!

Yeah, it builds using the latest Conda with the default latest numpy. Perhaps it ought not to. hmmm...

I've just pushed a revision that uses 1.9.2. If you wait a couple of hours, that should be pushed up to bintray (assuming the tests complete fine). Check out: https://ci.appveyor.com/project/hgomersall/pyfftw

Sweet! I just checked the progress... looks like 3.3 32 bit failed... and 3.5 32 bit failed... but 3.4 is good to go! :D

Does the whole series have to pass befire push to bintray or do individual versions that pass get pushed?

Nope, they're pushed individually, so they should be there. It was a silly failure to do with contention on the CI system so can be safely ignored.

oh, it seems 32 bit for 3.5 is also broken (it actually doesn't like 1.9.2).

Alas. :( So where does fit in ur plans? Are u gonna make a separate 1.9.2 permutation or will there jist be one to handle both?

I'll probably make it dependent on the python version, so 1.9.2 for less than 3.5. Does it work now?

Alas because of sec, i jave to go thru a process to dl it... i will have it soon tho and will let u know. Thank u again so much. Let me just say that I have been enjoying purging Matlab... ur software is a key reason we can do so.

Okay so we were able to get version 3.4 at 64 bit to work just fine. However, there seems to be some mistakes in the updated 3.3 64-bit version. Specifically there are function calls made in _utils.py that do not exist, e.g. is_byte_alligned and empty_alligned.  I have not tested the 3.5 version.

It's the same code. I'm not sure how that can make sense. The tests are completing fine.
What are you doing to trigger an error?

So actually this is my fault, due to mistakenly swapping path. Was my mistake. I am trying to incorporate pyfftw in my app directly... and have a switch import depending on the python version number being run. All looks good on ir end, srry for the re herring

Alrighty, I came in this morning and fixed all my issues. They all, as usual, came down to pretty obvious errors i was stupidly making. :)  Quick question: do u make the C source files available in the case we wish to compile the dlls from scratch? I ask because there may be a time in the future when we want to move to a new Python version before you have made it available. Thanks again for bearing with me. And thanks again for ur help (and for making this tool available!)

The C source files are compiled from the cython files (the .pyx and .pxd files). You can just install Cython to generate them.

Or do you mean FFTW? That comes from the FFTW developers: www.fftw.org

I was confused about the C source files... but now Im good. I am a new Python programmer and was expecting some .c or .cpp files... did not realize the Cython layer (I only have vague awareness of Cython at the moment but will be learning it as we optimize our app for speed). I was aware that your app is a wrapper for FFTW (which we also use in C directly on another project).
FYI, I have run your new version, both 3.3 and 3.4 64 bit, and all my unit tests are passing. So if that is useful to u, the update has not broken anything on our end!
Thanks again for being patient. This conversation helped a lot of people on our team. :)

Pleased I can help. Thanks for the useful update re nothing broken - I'd have been surprised (and a bit frustrated!) if it had broken anything.
Just a quick FYI - the new builds are using Numpy 1.9 across all versions. I'll stick with this for a while.


Code fix for object Access Control read implementation

This PR corrects TLV structure initialization for reading the Access Control object in the case, the ACL multiple instance resource does not contain any instances. The following resources when reading the whole object were lost. By the way, the old implementation lacks of a missing counter init potentially producing an core.

Should close https://bugs.eclipse.org/bugs/show_bug.cgi?id=465314 ?

Indeed.


how to create results.pkl?

when I train the model, I run:
python tools/train.py /home1/clx/mmdetection/configs/mask_rcnn_r50_fpn_1x.py --gpus 2 --work_dir /home1/clx/mmdetection/logs/logs_mask/ --validat
but after the training process, in the work_dir, there exists a file named "20181019_155702.log"

You can run the testing scripts to get the results. There is no result file (temp files will be deleted) created during training.


WebGL-renderer: implement preRender and postRender

Description
Currently, Heatmaps don't fire  prerender or postrender events. This is because a.t.m. only CanvasLayerRenderer implements the preRender and postRender  methods.
Here's a minimum working example: note how only the OSM's render-events are being logged:
const layers = [
    new TileLayer({
        source: new OSM(),
    }),
    new Heatmap({
        source: new VectorSource({
            features: new GeoJSON().readFeatures({
                "type": "FeatureCollection",
                "features": [{
                    "type": "Feature",
                    "properties": {},
                    "geometry": {
                      "type": "Point",
                      "coordinates": [13.38134765625, 52.50953477032727]
                    }
                }]
              })
        })
    })
];

const view = new View({
    center: [15, 52],
    zoom: 7,
    projection: 'EPSG:4326'
});

const map = new Map({
    layers, view, target
});

for (const layer of layers) {
    layer.on('postrender', (event) => {
        console.log(event);
    });
}

Solution
I believe we can literally just copy-paste the source code of CanvasLayerRenderer's preRender and postRender  methods into WebGLLayerRenderer. We'd then only have to call preRender and postRender from WebGLPointsLayerRenderer inside of renderFrame.
Would this be appropriate? It is my understanding that WebGl-support is still somewhat experimental (is that still true?). But if this is something we'd like to see, I'd like to try myself on a pull-request over the weekend.
Keep up the great work and thanks a lot! :)

That sounds absolutely appropriate. Please go ahead with a PR if you can, and don't hesitate to ask here for indications if needed. Thanks!

Thanks a lot! Working on this now. But I could indeed need a little pointer here.
This is the new WebGLLayerRenderer.dispatchRenderEvent_ method I've created (You can find the full current state here):
  /**
   * @param {import("../../render/EventType.js").default} type Event type.
   * @param {WebGLRenderingContext} context Context.
   * @param {import("../../PluggableMap.js").FrameState} frameState Frame state.
   * @private
   */
  dispatchRenderEvent_(type, context, frameState) {
    const layer = this.getLayer();
    if (layer.hasListener(type)) {
      /**
       * inversePixelTransform: converts from css-pixel-coordinates (rel. to top left) to webgl-vertex-space-coordinates ([-1, 1] x [-1, 1]).
       * [ a c e ]
       * [ b d f ]
       * [ 0 0 1 ]
       */
      const canvas = this.helper.getCanvas();
      const inversePixelTransform = [
        1 / (canvas.width / 2),
        0,
        0,
        -1 / (canvas.height / 2),
        -1,
        1,
      ];

      const event = new RenderEvent(
        type,
        inversePixelTransform,
        frameState,
        context
      );
      layer.dispatchEvent(event);
    }
  }

Now, this method returns a render-event with a WebGLRenderingContext instead of a CanvasRenderingContext2D. So I extended the definition of a RenderEvent to allow for a webgl-context, too. But this now causes an issue in another place: src/ol/render.js/getVectorContext returns a CanvasImmediateRenderer that has a 2D context.
Obviously, I could update the type-annotations of CanvasImmediateRenderer, too, but this class is part of the render/canvas directory, which I think means that it is specific for the canvas-2d API.
The consistent thing to do here, I believe, might be to create a render/webgl directory containing WebGL equivalents of all the functionality in render/canvas.  Is this the kind of structure that you'd like to see here? Or is there a simpler/better solution that I'm missing?
Thanks again!

Allow me to rephrase the issue.
getVectorContext has a type-signature Event -> CanvasImmediateRenderer.
We could either:

create a separate WebGlRenderEvent that does not qualify as a input to getVectorContext
or create a class WebGlCanvasImmediateRenderer, that provides the same functionality as CanvasImmediateRenderer, but for a WebGL context. But I don't think that this is practical: creating functionality that creates (for example) a circle on the fly in WebGL would mean a lot of shader-meta-programming, which is not congruent with the idea of keeping WebGL-support lightweight.

I think we might as well not provide any context at all in the event. Having a webgl context isn't as useful as a canvas2d one, since the application code won't be able to do much with it anyway (without an immediate rendering API like in canvas2d).
Then using something like this should work for building the inverse transform: https://github.com/openlayers/openlayers/blob/f3a67e818289282ac71b6d13df96434dd44ace61/src/ol/renderer/canvas/TileLayer.js#L272-L289
Although I'm not sure that would be even useful considering there will be no drawing context provided anyway. @ahocevar what's your opinion on this?

If the purpose of this feature request is just to get notified on prerender and postrender, then I think we neither need a drawing context nor a drawing transform in the event. The existing event can be reused, the documentation for context is already correct, and the inversePixelTransform would get a similar documentation ("Only available when a Canvas renderer is used, null otherwise") and a null value when fired from a WebGL renderer.

Roger that! Will adjust things accordingly. Thanks a lot!

Hey guys!
I just noticed that my commit-message did not conform to the PR-guidelines. So I rebased my branch to catch up with the latest changes on master and chanded my commit-message, too.
Now, however, I notice that netlify no longer builds correcty:
1:21:09 PM: Build ready to start
1:21:11 PM: build-image version: b0258b965567defc4a2d7e2f2dec2e00c8f73ad6
1:21:11 PM: build-image tag: v3.4.1
1:21:11 PM: buildbot version: fcbc7a79f7372e5995cf02954ef19fc48d20c871
1:21:11 PM: Fetching cached dependencies
1:21:12 PM: Starting to download cache of 548.5MB
1:21:17 PM: Finished downloading cache in 5.505318973s
1:21:17 PM: Starting to extract cache
1:21:33 PM: Finished extracting cache in 16.440542025s
1:21:33 PM: Finished fetching cache in 22.082851237s
1:21:33 PM: Starting to prepare the repo for build
1:21:34 PM: Preparing Git Reference pull/11471/head
1:21:38 PM: Starting build script
1:21:38 PM: Installing dependencies
1:21:38 PM: Python version set to 2.7
1:21:38 PM: Started restoring cached node version
1:21:41 PM: Finished restoring cached node version
1:21:57 PM: Version '10' not found - try `nvm ls-remote` to browse available versions.
1:21:57 PM: Failed to install node version '10'
1:21:57 PM: Error running command: Build script returned non-zero exit code: 1
1:21:57 PM: Failing build: Failed to build site
1:21:57 PM: Failed during stage 'building site': Build script returned non-zero exit code: 1
1:21:57 PM: Finished processing build request in 46.088649215s

It seems that netlify attempts to restore an old node version that no longer exists. Could this be because my original PR is now 5 days old? What could I do to fix this? As always, thanks for all the help!

Hi!
Alright, thanks a lot @ahocevar and @jahow  for all the help!
And thanks also for the PR. Given that the build issue described above doesn't occur anymore, either, I have run out of things to complain about and guess we could close this issue :)

Fixed by #11471.


Add possibility to unroll and collapse all structured data in selected column at once in table view

If we're in table view and if we have json input that contains structured data (arrays, objects...) in certain columns, then by default, the arrays are collapsed and one needs to press "Mouse::Left" or "enter" for each such value in the column to have them all unrolled. It would be very practical to have a single keybinding that would unroll all such values in currently selected column at once (and vice-versa - to collapse them all at once).

Maybe +/- will unroll/roll at least one more nested level. This sounds like a nice feature. Thanks for the suggestion!


Let 'init' put convention plugins into an included build (incubating)

Fixes #15326
Context
Instead of buildSrc, the included build gradle/plugins is used (when using 'incubating mode' with 'init').
The build is included via:
pluginManagement {
   includeBuild("gradle/plugins")
}

Rational for using gradle/plugins as location:

Putting it as subfolder of gradle:
I think it is good practice to put as much gradle-related files into the gradle folder instead of spamming the root with gradle related files and folders. This is also an advantage over 'buildSrc' which is hard-coded in the root. Other build configuration, like the Version Catalog, is also located in gradle by default
Calling it plugins:
In many samples, the folder is called build-logic (or some variation of that).  Also the term 'logic' is debatable if you only define convention plugins (which are more build-configuration than build-logic imo).

I think this change is quite straight forward. The one thing debatable would be the name and location of the 'plugins build' folder.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
~Provide unit tests (under <subproject>/src/test) to verify logic~
~Update User Guide, DSL Reference, and Javadoc for public-facing changes~
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Would you please clarify what is the difference between pluginManagement { includeBuild(..) } vs regular includeBuild(...)?
It looks like Gradle's build uses pluginManagement { includeBuild(..) } for settings plugin only.
Does that mean there should be two folders under gradle/... (one for regular plugins, and another for settings ones)?

For reference of any one reading this, this PR https://github.com/gradle/gradle/pull/22141 changed gradle/plugins to build-logic

@vlsi: "A special case of included builds are builds that define Gradle plugins. These builds should be included using the includeBuild statement inside the pluginManagement {} block of the settings file. Using this mechanism, the included build may also contribute a settings plugin that can be applied in the settings file itself." (https://docs.gradle.org/current/userguide/composite_builds.html#included_plugin_builds)


Fixed the form elements varying height bug

Hey,
I fixed the issue #22  please review it and merge it into the master branch.
I found out that there was an issue with the height property for mobile screens.
I just changed two lines of code, I added height: max-content property for 480px and 360px media queries
Hope this helps out your website.
Thanks in advance!

Fixes #22

Very nice. Although I would like to mention that, in the beta version we changed the layout to grid. The new layout fixed this issue but we did not close it as we did not release the beta version. Next time you contribute, commit all changes in the beta version (which is located in Source). I will also make sure to mention if an issue is fixed in the beta version.
Your work was clever and nice, why don't you try fixing #23? I am sure you can.

Thanks a lot! I will contribute to your project whenever I can! Happy that it helped you!

Adding thank you comment

Very pleased with your generosity. I would like to mention that further inspections have reopened this issue (#22). I have added more information and assigned the issue to you. Happy coding! :)


Wrong Italian translation of ImageChooserBlock in Wagtail 4.0rc2

Trying out recently released rc, I found a glitch in the Italian translation that is particularly confusing.
This is a screenshot of how an ImageChooserBlock appears in v4.0rc2:

where you can see that both buttons carry the same translation.
For reference, this is how it appears in v3.0.1:

Thanks for the report - I've now updated the translation strings on https://explore.transifex.com/torchbox/wagtail/ so that "Change" is "Cambia".

Thanks!

Added a bit of a summary of this underlying issue and learnings here https://github.com/wagtail/wagtail/discussions/8017#discussioncomment-3639114
Any feedback on that sub-comment would be appreciated.


Help to understand why only half of the screen is painted over.

Windows 10
MINGW W64 9.0
commit/3a3935d00569c5cf3dbd684ab10e54e8480df167
#include <SFML/Graphics.hpp>

int main()
{
  sf::RenderWindow window(sf::VideoMode({64, 32}), "SFML works!");

  sf::Texture texture;
  sf::Sprite sprite;

  if (!texture.create({64,32})) throw "";
  sprite.setTexture(texture);

  while (window.isOpen())
  {
    sf::Event event;
    while (window.pollEvent(event))
    {
      if (event.type == sf::Event::Closed)
        window.close();
    }

    uint32_t sfml_pixel_buffer[32 * 64];
    static int a= 0x00FFAADD;

    for(int i = 0; i < 32*64; ++i){
      sfml_pixel_buffer = a;
    }a+= 0xFFFF;

    texture.update(reinterpret_cast<uint8_t *>(&sfml_pixel_buffer[0]));

    window.clear();
    window.draw(sprite);
    window.display();
  }

A little more than half the screen is painted over.
but i think it should draw the whole screen.

Please be a bit more patient with your forum post and don't use the issue tracker for help questions, as we try to use it for confirmed issues.
If you want some more activity, you can join the Discord server, where you might find more active people.

@eXpl0it3r  I chose the wrong interpretation. I think it's a problem.
Look at this.
sf::RenderWindow window(sf::VideoMode({64, 32}), "SFML works!"); // windows size 6432
uint32_t sfml_pixel_buffer[32 * 64]; // buffer size 6432
texture.create({64,32})
sprite.setTexture(texture);
texture.update(reinterpret_cast<uint8_t >(&sfml_pixel_buffer[0])); // texture size 6432
I expected the whole screen to be painted

I replied on your forum post. Let's first check there and if we can determine it to be an actual issue, then we can re-open the issue here.