CSS Function Parsing

Ina  css file this will correctly display:
background-color: rgb(30 66 159);

But this will not:
background-color: rgb(30 66 159 / var(--tw-bg-opacity));

Css files are handled natively by the CSS plugin. For feature requests, please open an issue in JetBrains.


Update .gitignore

You probably mean a specific file here, and not
/some/other/web/src/main/webapp/js/config/options_prod.js

Thanks!


DAM Scoping

TODOs
API

[x] Database entities
[x] File upload (Handle duplicate filename)
[x] GraphQL operations
[x] Scope Guard for DAM operations

Admin

[x] File upload
[x] GraphQL operations
[x] Content scope indicator
[x] Choose file dialog

General

[x] Test if it still works without scope
[x] Test images in admin preview and site

@nsams @thomasdax98 this PR is ready for review. Please review the commits one by one. I've also added some comments to explain my reasoning for certain decisions.

I just tested the changes and moving a file leads to an error

I just tested the changes and moving a file leads to an error

Thanks for testing, fixed: 0b6704143608b1f5372e301844a56d5fd6712447


Preprint preview service: build fail, no error description

Following up on: https://github.com/neurolibre/docs.neurolibre.org/issues/13
Kiril was able to update the T1 book to use version 0.10.x of Jupyter Book (repo, site).
I forked and converted the repo in a branch to match the format in the docs, and tried a preview submission (https://roboneuro.herokuapp.com).
I am still encountering this error, with no accompanying messages.

Any clue @agahkarakuzu ?

Alright so after some investigations:

The binder build is successfull (when triggered manually via binder.conp.cloud), this includes the soft env build and session spawning. But the execution in the interactive environment does not seems successfull (figures are empty), same behaviour for the public mybinder.org (so you should definitively check your code). You should also check this section https://mybinder.readthedocs.io/en/latest/tutorials/dockerfile.html if you definitively need Dockerfile (which is not the recommended way to have a binder environment).
The jupyter-book build is correctly triggered when I call the API manually, BUT it cannot execute the jupyter-book build command. This is because you forgot to add it as a dependency as explained here: https://docs.neurolibre.org/en/latest/SUBMIT.html#runtime
FYI: this is the command on the backend:
docker run -v /DATA:/home/jovyan/data binder-registry.conp.cloud/binder-registry.conp.cloud/binder-qmrlab-2dt1-5fbook-5fupdate-145d0a:0a148bc97a8799fe4599e99f9168555df1aeb42f jupyter-book build --path-output /home/jovyan/data/book-artifacts/qMRLab/github.com/t1_book_update/0a148bc97a8799fe4599e99f9168555df1aeb42f content
I don't know why the front-end does not correctly trigger the book build on our API, this is something @agahkarakuzu should be able to check (it could be because you are using a branch). When fixed, you will have access to the jupyter book build like http://neurolibre-data.conp.cloud/book-artifacts/qMRLab/github.com/t1_book_update/0a148bc97a8799fe4599e99f9168555df1aeb42f/book-build.log

The jupyter-book build is correctly triggered when I call the API manually, BUT it cannot execute the jupyter-book build command. This is because you forgot to add it as a dependency as explained here: https://docs.neurolibre.org/en/latest/SUBMIT.html#runtime
FYI: this is the command on the backend: 2. docker run -v /DATA:/home/jovyan/data binder-registry.conp.cloud/binder-registry.conp.cloud/binder-qmrlab-2dt1-5fbook-5fupdate-145d0a:0a148bc97a8799fe4599e99f9168555df1aeb42f jupyter-book build --path-output /home/jovyan/data/book-artifacts/qMRLab/github.com/t1_book_update/0a148bc97a8799fe4599e99f9168555df1aeb42f content

This point isn't clear to me. 1- I do have a content/ folder in my branch (see here: https://github.com/qMRLab/t1_book_update/tree/neurolibre/content), 2- I do have a binder/ folder in my branch (see here:https://github.com/qMRLab/t1_book_update/tree/neurolibre/content), however I use Dockerfile instead of requirements.txt, and since Binder skips requirements.txt if a Dockerfile is present, I didn't think I needed to add it, and 3- I don't see that docker run command anywhere discussed in the NeuroLibre documentations, so how could I have figured that out by myself to test?

Should I just add a requirements.txt file with only
jupyter-book
jupytext

as dependencies? Will this still work with my Dockerfile present in the folder? I'll try and see

I just tried, and still got the same error immediately with no details:

Is it possible it's just incompatible with the RoboNeuro test servers? Should I try and submit my T1 book as-is and see if it will work on the live servers?

Do we have any live demos of a repository that RoboNeuro was tested on that I can try and duplicate the settings for my own with?

@mathieuboudreau jupyter-book and jupytext won't be installed via requirements.txt as Dockerfile is not using that file. Can you add the minimal pip requirements of neurolibre to the pip list in the Dockerfile?
If works, we can have additional instructions or even base docker images for neurolibre.

Ahh gotcha; though, RoboNeuro fails for me within a fraction of a second, so I doubt it even has time to run the Dockerfile. I'll update it regardless, but I don't think that's the only problem I'm encountering.

Done, and as expected, got the same error:

Is roboneuro maybe not compatible with Dockerfiles?

OK, the issue was caused because of a type casting bug, mostly because I am not a savvy ruby programmer :) The new deployment resolved the problem, now you can use the service for this repo/branch.
The image built was successfull, but the book build failed, here's the log:
[FATAL tini (6)] exec jupyter-book failed: No such file or directory

Great, thanks Agah!
1- Is there a way to test RoboNeuro using a continuous integration? If so, it would be great to add this exception as a test.
2- I did get further with your change, I encountered this screen now:

However, clicking the link I get a new error:

Here is the link written out: http://neurolibre-data.conp.cloud/book-artifacts/qMRLab/github.com/t1_book_update/b720a326569f289a828b391bf174bba969da0cd7/_build/html/
It appears to be trying to get the _build/html/ folder of that repo, however _build is actually contained within a parent folder called content/ (see: https://github.com/qMRLab/t1_book_update/tree/neurolibre/content/_build/html) per what I understood from your guidelines in the readthedocs (see: https://docs.neurolibre.org/en/latest/SUBMIT.html#preprint-repository-structure).
Any clue?

@mathieuboudreau interesting, unless you fixed the book build error, it should be displaying that the book build fails. Do you have logs mailed to you indicating that the builds were successful?
So far I did not run into a directory problem, when the book build is complete, the links worked.

@mathieuboudreau here is the error log that the API should have return to you:
http://neurolibre-data.conp.cloud/book-artifacts/mathieuboudreau/github.com/t1_book_update/668f1f29a48661c4983df194ca2707bd972a99ae/book-build.log
Looking into the log, it seems that the image does not exists locally.

The latest successfull binder build was at 13h43 Sept 2d:
[I 210902 13:43:06 build:321] Started build build-qmrlab-2dt1-5fbook-5fupdate-145d0a-1dc-1f
[I 210902 13:43:06 build:323] Watching build pod build-qmrlab-2dt1-5fbook-5fupdate-145d0a-1dc-1f
[I 210902 13:43:13 build:355] Watching logs of build-qmrlab-2dt1-5fbook-5fupdate-145d0a-1dc-1f
[I 210902 13:45:45 build:385] Finished streaming logs of build-qmrlab-2dt1-5fbook-5fupdate-145d0a-1dc-1f
[I 210902 13:45:46 builder:518] Launching pod for https://github.com/qMRLab/t1_book_update: 1 other pods running this repo (2 total)
[I 210902 13:45:46 launcher:166] Creating user qmrlab-t1_book_update-ogjaoz6o for image binder-registry.conp.cloud/binder-registry.conp.cloud/binder-qmrlab-2dt1-5fbook-5fupdate-145d0a:1dc82c7a86129e974859642e6349cb8267c2df62
[I 210902 13:45:47 launcher:213] Starting server for user qmrlab-t1_book_update-ogjaoz6o with image binder-registry.conp.cloud/binder-registry.conp.cloud/binder-qmrlab-2dt1-5fbook-5fupdate-145d0a:1dc82c7a86129e974859642e6349cb8267c2df62
[I 210902 13:46:12 builder:603] Launched https://github.com/qMRLab/t1_book_update in 26s
[I 210902 13:47:12 log:140] 200 GET /build/gh/qMRLab/t1_book_update.git/1dc82c7a86129e974859642e6349cb8267c2df62<EMAIL_ADDRESS>246033.80ms

So I tried to build your environment yesterday and today. I tried to launch the build manually on https://binder.conp.cloud/
and it takes forever.
Unfortunately I have no clues why it is taking so long, you will need to reduce and optimize the Dockerfile (make sure you are not re-installing softwares that already exists in jupyter/base-notebook:8ccdfc1da8d5 for ex.). Again, I want to re-emphase that using Dockerfiles is not the preferable way to spawn a neurolibre instance, exactly because of this kind of issues.
On July 29th, the build was successful so something is wrong with your newest updates:

Alright so after some investigations:
1. The binder build is successfull (when triggered manually via https://binder.conp.cloud/), this includes the soft env build and session spawning. But the execution in the interactive environment does not seems successfull (figures are empty), same behaviour for the public mybinder.org (so you should definitively check your code). You should also check this section https://mybinder.readthedocs.io/en/latest/tutorials/dockerfile.html if you definitively need Dockerfile (which is not the recommended way to have a binder environment).

Again, I want to re-emphase that using Dockerfiles is not the preferable way to spawn a neurolibre instance, exactly because of this kind of issues.

Hi @ltetrel,
Thanks for that heads up. While I understand, it's impossible to configure the environment for this notebook with only requirements/env/wtv other files. Also, as more and more people are adopting Docker and Singularity, I think this will be a necessary service for NeuroLibre to provide, in my opinion.

I'll try again, but I'm fairly certain that this dockerfile built on MyBinder, I'll try again

I'm wonder if this recent feature (and/or bug) in pipy might be the cause of the much longer build time now:
https://github.com/pypa/pip/issues/10201
https://pip.pypa.io/en/stable/user_guide/#dependency-resolution-backtracking
As I'm experiencing something similar in the MyBinder build log:

It's not stuck here, but I've been downloading different versions of the attrs pip packages for like 20 minutes now.

(no idea why it's taking 5+ minutes for 40kb packages though)

Here's some tips on how to deal with the new pip dependency resolver: https://stackoverflow.com/questions/65122957/resolving-new-pip-backtracking-runtime-issue

I'm wonder if this recent feature (and/or bug) in pipy might be the cause of the much longer build time now:
pypa/pip#10201
https://pip.pypa.io/en/stable/user_guide/#dependency-resolution-backtracking
As I'm experiencing something similar in the MyBinder build log:

It's not stuck here, but I've been downloading different versions of the attrs pip packages for like 20 minutes now.

Good catch! I think for this current submission, the best advice would be to reduce the complexity of the dependencies https://pip.pypa.io/en/stable/user_guide/#audit-your-top-level-requirements

Yeah I saw that; the pip dependencies that we explicitly specify in the Dockerfile are the minimum ones required for us, so I might try using the legacy resolver since we're in a rush a the moment.

I will add a note on that issue in the docs, since it could happen to other people with complex submission as well.

So, by adding this line to the Dockerfile,
https://github.com/qMRLab/t1_book_update/blob/bc68bec6de695b85473e2a2e9bf2644668c3f45b/binder/Dockerfile#L45
the image built much quicker on MyBinder and executed correctly,

However, when making the same change in the neurolibre branch (which my MyBinder branch forked out of),
https://github.com/qMRLab/t1_book_update/blob/ceee653c23f2f07012f9841e0ab086be210adff7/binder/Dockerfile#L45
RoboNeuro immediately failed without building again, and did not send me a log.

@agahkarakuzu how did you resolve this the other day?

@mathieuboudreau I gave it a try
qmrlab/t1book_upate neurolibre branch, is this the one?
If so, @ltetrel  I receive 409 as response to that request.

yup, I tried twice

@mathieuboudreau I gave it a try
qmrlab/t1_book_upate neurolibre branch, is this the one?
If so, @ltetrel I receive 409 as response to that request.

Yes, there is a lock file that I just deleted manually because of the previous on-going build (still need to better manage them).  Can you re-try now?
Also I think it would be important to propagate all the errors (that the API returns) to the user @agahkarakuzu, as well as the build log. From the user perspective, receiving something empty is really frustrating :crying_cat_face:

@ltetrel I agree! I will need to deal with that 409 case, it is a bit tricky, I will sit down and think about it :D
Now it is running without 409, will let you know.

@ltetrel what should we say to the user in case 409 by the way? Something like You run out of tests allowed for this user/repo, get in touch with us ? What would be the solution in this case?

@ltetrel what should we say to the user in case 409 by the way? Something like You run out of tests allowed for this user/repo, get in touch with us ? What would be the solution in this case?

You are not allowed to run more than one submission per repository, please re-try when the previous request finished. ?

And a message saying that if the submission is taking too long (what happened here), then they should get in touch with us by e-mail.

It may have terminated because of the front-end worker:
 SidekiqStatus::Container::StatusNotFound: 5eadb14e27a4c7ebfdda9346

Do you emit something specific when the build is timed out on your end?

No I don't manage that, I don't have control over that this info is on the binderhub cluster.
The only thing I can do is to stream back the binder build logs (which says at the end that the build timed-out).

Now that the image is correctly built on the server, I found that:

Your binder environment does not have jupyter-book installed which is mandatory for the submission to work.
The repository layout is not correct since you are changing it in your Dockerfile (in ~/work/t1_book_update), and pulling the repo form github (https://github.com/qMRLab/t1_book_update/blob/ceee653c23f2f07012f9841e0ab086be210adff7/content/Dockerfile#L64). I would advice you to use the COPY docker command to copy directly from the repo into the image ex:

COPY . ~/work/t1_book_update

@mathieuboudreau Also be carefull with this line, basically all your data will be saved into the image, which makes it really large.
Large docker images makes the spawn time really long, impact your computing performance in the environment, and takes an incredible amount of space in our servers (data length x number of versions you push).
You should use a data requirement for this type of behaviour: https://docs.neurolibre.org/en/latest/SUBMIT.html#data

@mathieuboudreau Also be carefull with this line, basically all your data will be saved into the image, which makes it really large (currently 3.4G).
Large docker images makes the spawn time really long, impact your computing performance in the environment, and takes an incredible amount of space in our servers (data length x number of versions you push).
You should use a data requirement for this type of behaviour: https://docs.neurolibre.org/en/latest/SUBMIT.html#data

Thanks for the tip Loic. I don't think we're actually downloading any data using repo-2-docker in this instance; the build size is due to our dependencies, but I'll double check. I think we just added that line once upon a time for testing purposes, while testing out your package.

@mathieuboudreau Now that the image is correctly built on the server, I found that:
The repository layout is not correct since you are changing it in your Dockerfile (in ~/work/t1_book_update), and pulling the repo form github (https://github.com/qMRLab/t1_book_update/blob/ceee653c23f2f07012f9841e0ab086be210adff7/content/Dockerfile#L64).
as a consequence the jupyter-book build on our backend fails:
Usage: jupyter-book build [OPTIONS] PATH_SOURCE
Try 'jupyter-book build -h' for help.

Error: Invalid value for 'PATH_SOURCE': Path 'content' does not exist.

I would advice you to use the COPY docker command to copy directly from the repo into the image ex:
COPY . ~/work/t1_book_update/

Hmmmm, I understand the problem. However I don't think I can just copy the repo either, because I need to run the commands below it in the same "session" (i.e. different RUNs don't "see" each other, as far as I understand it if I copy the repo that way a run below it won't be able to execute:
https://github.com/qMRLab/t1_book_update/blob/ceee653c23f2f07012f9841e0ab086be210adff7/content/Dockerfile#L66-L75
, but maybe @agahkarakuzu can correct me).

Documentation will need to be added, as when I read the NeuroLibre doc I wasn't informed of this limitation re: Dockerfiles and how to configure it correctly.

Documentation will need to be added, as when I read the NeuroLibre doc I wasn't informed of this limitation re: Dockerfiles and how to configure it correctly.

Yep, I made lot of changes these days. Can you check it now to see if it is more clear ?

@ltetrel do we have a demo repo that builds on RoboNeuro that you guys tested and validated the service on, so that I can go in and explore the directory structure inside the Docker image and see how it should look like for the Jupyter Book to work correctly?

I'd like to avoid too many RoboNeuro builds, and am afraid that blindly debugging the Dockerfile to get the correct setting can will several tries.

You can check this one: https://github.com/ltetrel/nha2020-nilearn
Agah may have others I think.

@mathieuboudreau Now that the image is correctly built on the server, I found that:
The repository layout is not correct since you are changing it in your Dockerfile (in ~/work/t1_book_update), and pulling the repo form github (https://github.com/qMRLab/t1_book_update/blob/ceee653c23f2f07012f9841e0ab086be210adff7/content/Dockerfile#L64).
as a consequence the jupyter-book build on our backend fails:
Usage: jupyter-book build [OPTIONS] PATH_SOURCE
Try 'jupyter-book build -h' for help.

Error: Invalid value for 'PATH_SOURCE': Path 'content' does not exist.

I would advice you to use the COPY docker command to copy directly from the repo into the image ex:
COPY . ~/work/t1_book_update/

The principal solution to this issue was resolving a bug where I was checking out a repo after cloning it, but before opening the directory.
See: https://github.com/qMRLab/t1_book_update/commit/3bb10c9dc2bb434f5674d2dadd807b888a0dd74a

I then encountered another issue,
Traceback (most recent call last):
  File "/opt/conda/lib/python3.6/site-packages/jupyter_book/cli/main.py", line 244, in build
    parse_toc_yaml(toc)
  File "/opt/conda/lib/python3.6/site-packages/sphinx_external_toc/parsing.py", line 82, in parse_toc_yaml
    return parse_toc_data(data)
  File "/opt/conda/lib/python3.6/site-packages/sphinx_external_toc/parsing.py", line 88, in parse_toc_data
    raise MalformedError(f"toc is not a mapping: {type(data)}")
sphinx_external_toc.parsing.MalformedError: toc is not a mapping: <class 'list'>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/conda/bin/jupyter-book", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.6/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/lib/python3.6/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/opt/conda/lib/python3.6/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/conda/lib/python3.6/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/lib/python3.6/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/opt/conda/lib/python3.6/site-packages/jupyter_book/cli/main.py", line 247, in build
    f"The Table of Contents file is malformed: {exc}\n"
  File "/opt/conda/lib/python3.6/site-packages/jupyter_book/utils.py", line 48, in _error
    raise kind(box)
RuntimeError:
[91m===============================================================================[0m

The Table of Contents file is malformed: toc is not a mapping: <class 'list'>
You may need to migrate from the old format, using:

	jupyter-book toc migrate /home/jovyan/work/t1_book_update/content/_toc.yml -o /home/jovyan/work/t1_book_update/content/_toc.yml

[91m===============================================================================[0m

Running Jupyter-Book v0.11.3

which was resolved by reverting jupyter-book to exactly the version 0.10.0 (the version that it was initially built for). Any versions above, it did not work due to 1- a weird SoS issue during build and/or 2- mismatch in how the ToC needs to be formatted with the newer versions.

After a lot of back and forth due to my repo's RoboNeuro files being locked after each build, no logs being sent to me when errors occured, and no UI messages to me on the web,  and a lot of help by @ltetrel, I was finally able to successfully build a book using RoboNeuro!

Before submitting officially, I'll have to do a little bit of cleanup in the book due to some of the transition needed from the old jupyter book format to the current one (the equations, figures aren't centered anymore), but that should be quick I'd say.
Here's some other things of note:
When my book finished building, it didn't alert me in the browser. Instead, it showed:

But if I went back and built again, it said it found the book and opened it.
Also, while RoboNeuro allows me to give a branch or git ref, the submission doesn't:

Congrats for the submission!

RoboNeuro files being locked after each build

I tried "manually" to submit your repo (calling the API via command line instead the website or RoboNeuro) and the lock file is correctly being deleted. I suspect that what happened is that when the user (you) close his session (the submission page), the API call is somehow canceled. As a result the submission building is canceled and the lock file stays on the server (so the API treat the submission as currently active).
I added a mechanism where the lock file would automatically be deleted after 30min, so it should prevent user to be locked in the future. But @agahkarakuzu you should check how RoboNeuro manage user closing their session.

You pinged https://github.com/pypa/pip/issues/10201 so I took a quick look at the docker file: https://github.com/qMRLab/t1_book_update/blob/neurolibre/binder/Dockerfile#L45
And I build an independent requirements file based on this in which I was able to reproduce the long backtracking issue:
octave_kernel
sos==0.17.7
sos-notebook==0.17.2
sos-python==<IP_ADDRESS>
sos-bash==0.12.3
sos-matlab==<IP_ADDRESS>
sos-ruby==<IP_ADDRESS>
sos-sas==<IP_ADDRESS>
sos-julia==<IP_ADDRESS>
sos-javascript==<IP_ADDRESS>
sos-r==<IP_ADDRESS>
scipy
plotly==3.10.0
flask
ipywidgets
nbconvert==5.4.0
jupyterlab==2.2.0
jupyter-book==0.10.0
jupytext
repo2data

I tested it using the optimized version of backtracking I have proposed here: https://github.com/pypa/pip/issues/10479
It quickly produce this error, hope it helps you build a better dependency file in the future:
ERROR: Cannot install -r .\reqs.txt (line 18), -r .\reqs.txt (line 3), jupyter-book and nbconvert==5.4.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested nbconvert==5.4.0
    sos-notebook 0.17.2 depends on nbconvert>=5.1.1
    jupyter-book 0.10.0 depends on nbconvert<6
    myst-nb 0.11.1 depends on nbconvert~=5.6

In my testing if I loosen the user nbconvert requirement from nbconvert==5.4.0 to nbconvert I am able to install the requirements even on regular Pip 21.2.4.


Change variable min & max length to match IntelliJ.

If you think it's better that way I can adjust the tests.

Hmm it kinda looks to me as if the kotlin devs were to lazy to check to ignore variable names in loops :/

I don't quite get what you mean with your last comment artur.

In loops names like i (for i in ints {}) is ok. All other variables should not be called a, b, c ... i or whatself. It feels kinda hacky to set this defaults ourself :(

I do think having a min value of 1 is fine. I wouldn't go down the street of separating them via loops properties.


run-dev: Add max quiting timeout to tornado proxy server.

Fixes #2175

Automated message from Dropbox CLA bot
@kkanahin, it looks like you've already signed the Dropbox CLA. Thanks!

It was added max timeout for quiting tornado proxy server. There is one problem: I wanted to add checking timeouts too, but  when It waits for last timeout webpack server is already down on keyboard interrupt and don't wait last kill command. It is cause of errors from tornado proxy server and I have to exclude waiting timeouts from my code.

Can you explain in some more detail how this fixes #2175?  I'm not sure I understand.  Just to be clear, it's the manage.py runtornado process that was failing to shut down.

@timabbott It seems tornado process was not killed after tornado proxy stopping. I think tornado proxy server waits while last callback done in some cases and hangs for long time.To solve this problem I've added deadline time to stop tornado proxy loop, which doesn't allow to kill subproccesses. I don't think that it's connected with tornado server(not proxy), cause it worked with twisted correctly.
I couldn't catch this error on my side. I've made rebase and changing branch, but proxy script closed correctly. We can wait this bug for next time and i need full stacktrace with closing command and list of running servers to check  that just tornado server was not closed.


Update jsoniter-scala-core_2.13 to 2.17.9

Updates com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core_2.13 from 2.17.8 to 2.17.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala", artifactId = "jsoniter-scala-core_2.13" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.github.plokhotnyuk.jsoniter-scala", artifactId = "jsoniter-scala-core_2.13" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Btw. we don't have to run anything on JDK 8 just to make sure? Jsoniter only supports 11+

Btw. we don't have to run anything on JDK 8 just to make sure? Jsoniter only supports 11+

For JDK 8 Scala CLI uses older jsoniter - jsoniterScalaJava8


Enable skybox for 3d  views.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Josh-Schifter because it's 2020 and we are still dealing with different line endings on unix and windows. You can change your settings to tell it to ignore whitespace changes.

@Josh-Schifter Ugly brown is because you're in a top view in a non-geolocated file. Rotate the view to see why. If you prefer, I can override the default skybox settings.

@Josh-Schifter Ugly brown is because you're in a top view in a non-geolocated file. Rotate the view to see why. If you prefer, I can override the default skybox settings.

I don't think the ugly brown affected Retail Building (maybe I missed it).  I think we should do something because it looks pretty bad.  Either like you say, override the default skybox, or only to skybox for geolocated, or only do skybox for certain samples.

Ugly brown is the default color you see when looking straight down in a top view of any non-geolocated model, including the retail building.
I changed that color. Is it less ugly now?

I changed that color. Is it less ugly now?

Seems like a good compromise.


Add in edge layer to adapt palyload to proper contract

The main idea is to support API payloads of any platforms. By example:
For input in Watson's API payload format:
POST http://localhost:5005/dialog?_if=watson

If the input format isn't explicitly informed, maybe we can build a component that tries to resolve the format.
Also maybe we can implement support to output format, but only if will be needed.

I'm working in this functionality in branch: issue/19-edge-adapter

During the development, I realized that not have a sense parametrize a different format in input and output.
So I implemented the support for 'adapter' query param that defines the format of input payload and output payload.
The usage is:
http://localhost:5000/dialog?adapter=watson

Where "watson" is the name of the adapter.
Until the moment, only "message" adapter is working. And he is the default adapter.
I will close this issue and create two new to develop the Watson adapter and to create a config for change default adapter of running instance.

Hehe, we have to merge before close!


Cross-compile modules for Scala 3

[x] akka-http-argonaut (see #754 )
[ ] akka-http-avro4s avro4s-json module does not have a Scala 3 flavour and is removed from project
[x] akka-http-circe (see #757 )
[x] akka-http-jackson  (see #757 )
[x] akka-http-json4s (see #754 )
[x] akka-http-jsoniter-scala (see #754 )
[ ] akka-http-ninny - Scala 3 available, but not Auto derivation (https://github.com/nrktkt/ninny-json/pull/32), so import io.github.kag0.ninny.Auto._ doesn't exist, and ToSomeJson and FromJson need to be constructed manually in order for tests to pass.
[ ] akka-http-play-json - In progress https://github.com/playframework/playframework/issues/11260
[x] akka-http-upickle  (see #757 )
[x] akka-http-zio-json (see #754 )

And of course akka (or Pekko) itself, currently the akka-http modules are not cross-published for Scala 3

@DieBauer since akka-http has a 10.5.0-M1 release for Scala 3 (e.g. https://repo1.maven.org/maven2/com/typesafe/akka/akka-http-core_3/10.5.0-M1/) what are the next steps planned here?

If you want to support Jackson for Scala 3, you can look at a change I made to my Pekko fork of this lib. I removed the scala-reflect dependency that akka-http-jackson has and started using jackson-module-scala's ClassTagExtensions to support getting class information from implicit ClassTags.

https://github.com/hseeberger/akka-http-json/commit/4e909d93389f26a7bea852df1df1d64db12d9676
https://github.com/hseeberger/akka-http-json/commit/973c3e235642dd111d2a331752a4c97b61176bd8 (small mods to get code to compile in Scala 3)

@pjfanning  I think we did the same changes, see #757 for the jackson scala 3 support :)
@luksow, I can update akka version as well. But I'm not sure when a release will be cut with the other modules in as well, @hseeberger what is your idea of this project?

I'd love to find other maintainers, because currently I have no time to work on it.

If we can get a few volunteers together to maintain these libs and their pekko equivalents, I guess I can help out.


Update plugin.yml

Fix for [18:55:38.473] [Server thread/CRITICAL]: InvalidArgumentException: "Cannot use non-existing permission "betterrepair.repair.all"" (EXCEPTION) in "pmsrc/src/command/Command" at line 107


14.22 micropatch not working

Hi, I know you said earlier in another issue thread that the injector still works after the micropatch but I'm having issues.
It's not having the regular error code that comes after most patches but it isn't showing up in game, it says it's active but there's just no injection
any advice on how to fix?

i dont think you understand, i meant the error message usually comes through when there is an update. there is not an error message this time, it just doesnt show up in game.

@hydy100 can you check again please? For me 14.22 was working last Sunday (10.11). But on Monday I tried to use the injector, pressing the home button and then in game pressing insert the menu does not show up

Not working for me also

for me, my antivirus started acusing this as a trojan and is blocking it, and that's why is not working, i tried adding exclusive access and all, but nope, doesn't work, my antivirus just doesn't let the file be loaded by anymeans... any thoughts on why?

It is working now. Thanks for the quick update hydy :)


Add method to expose a SafeTokenHandle

Most of this library is concerned with wrapping the LogonUser Win32 function to get a SafeTokenHandle.  We then call WindowsIdentity.RunImpersonated to actually execute code under impersonation.
It would be helpful for some use cases (see comments in #58 and #52) to be able to return the handle directly and let the user make their own calls to do the impersonation part.

Done as of version 4.0.0.


Deprecation warnings as errors

Adds infrastructure so we can treat deprecation warnings as errors. In a feature I'm working on currently, I am deprecating some stuff that's used in a few places in Chef (conversion of cookbooks to JSON for uploads), and I needed a way to make sure that Chef wasn't triggering deprecation warnings from itself.
To address this, I've added a config option to treat deprecation warnings as errors, which defaults to false. It can be set to true directly, or by setting the environment variable CHEF_TREAT_DEPRECATION_WARNINGS_AS_ERRORS. In the spec helper, both of these are set, so when you're running tests, any usage of deprecated behavior will be an error. The environment variable makes this setting persist in child processes, such as when the integration tests run chef-client or knife.
Though this feature is mostly designed for internal use, it's also helpful for end users who wish to aggressively fix deprecation warnings; they could set this flag only during local development.
@lamont-granquist @jkeiser @chef/client-core

LGTM

:cat2:

:shipit:


TIKA-4124 -- add unit tests

Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that

there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
the issue ID (TIKA-XXXX)

is referenced in the title of the pull request
and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)

commits are squashed into a single one (or few commits for larger changes)
Tika is successfully built and unit tests pass by running mvn clean test
there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

This requires https://github.com/apache/tika/pull/1323. Once we get feedback on the png workaround, we can merge that PR and then this one.


[SPARK-32777][SQL] Aggregation support aggregate function with multiple foldable expressions.

What changes were proposed in this pull request?
Spark SQL exists a bug show below:
spark.sql(
  " SELECT COUNT(DISTINCT 2), COUNT(DISTINCT 2, 3)")
  .show()
+-----------------+--------------------+
|count(DISTINCT 2)|count(DISTINCT 2, 3)|
+-----------------+--------------------+
|                1|                   1|
+-----------------+--------------------+

spark.sql(
  " SELECT COUNT(DISTINCT 2), COUNT(DISTINCT 3, 2)")
  .show()
+-----------------+--------------------+
|count(DISTINCT 2)|count(DISTINCT 3, 2)|
+-----------------+--------------------+
|                1|                   0|
+-----------------+--------------------+

The first query is correct, but the second query is not.
The root reason is the second query rewrited by RewriteDistinctAggregates who expand the output but lost the 2.
Why are the changes needed?
Fix a bug.
SELECT COUNT(DISTINCT 2), COUNT(DISTINCT 3, 2) should return 1, 1
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
New UT

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32821/
Test PASSed.

Test build #128196 has started for PR 29626 at commit 0f355ad.

Test build #128197 has started for PR 29626 at commit e15519e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32822/
Test PASSed.

Test build #128196 has finished for PR 29626 at commit 0f355ad.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128196/
Test FAILed.

retest this please

Test build #128198 has started for PR 29626 at commit e15519e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32823/
Test PASSed.

cc @cloud-fan and @linhongliu-db

Test build #128201 has started for PR 29626 at commit 9ad3469.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32826/
Test PASSed.

Test build #128198 has finished for PR 29626 at commit e15519e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class JDBCScan(
case class JDBCScanBuilder(
case class JDBCWriteBuilder(schema: StructType, options: JdbcOptionsInWrite) extends V1WriteBuilder

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128198/
Test FAILed.

Test build #128197 has finished for PR 29626 at commit e15519e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class JDBCScan(
case class JDBCScanBuilder(
case class JDBCWriteBuilder(schema: StructType, options: JdbcOptionsInWrite) extends V1WriteBuilder

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128197/
Test FAILed.

Test build #128201 has finished for PR 29626 at commit 9ad3469.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128201/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32834/
Test PASSed.

Test build #128208 has started for PR 29626 at commit 81eb9e4.

Test build #128208 has finished for PR 29626 at commit 81eb9e4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128208/
Test FAILed.

Test build #128219 has started for PR 29626 at commit 52896fb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32845/
Test PASSed.

Test build #128219 has finished for PR 29626 at commit 52896fb.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128219/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32867/
Test PASSed.

Test build #128240 has finished for PR 29626 at commit 52896fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128240/
Test PASSed.

cc @cloud-fan

Test build #128285 has started for PR 29626 at commit 8622411.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32911/
Test PASSed.

Test build #128294 has started for PR 29626 at commit 43cb6a0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32920/
Test PASSed.

Test build #128285 has finished for PR 29626 at commit 8622411.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128285/
Test PASSed.

Test build #128294 has finished for PR 29626 at commit 43cb6a0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128294/
Test PASSed.

Test build #128341 has started for PR 29626 at commit 64834f8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32967/
Test PASSed.

Test build #128341 has finished for PR 29626 at commit 64834f8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128341/
Test FAILed.

Test build #128345 has started for PR 29626 at commit fa7d578.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32971/
Test PASSed.

Test build #128345 has finished for PR 29626 at commit fa7d578.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128345/
Test PASSed.

Test build #128429 has started for PR 29626 at commit 9a44bec.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33053/
Test PASSed.

Test build #128429 has finished for PR 29626 at commit 9a44bec.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128429/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33062/
Test PASSed.

Test build #128438 has started for PR 29626 at commit 9a44bec.

Test build #128438 has finished for PR 29626 at commit 9a44bec.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128438/
Test FAILed.

retest this please

Test build #128478 has started for PR 29626 at commit 9a44bec.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33102/
Test PASSed.

Test build #128479 has started for PR 29626 at commit 16588f5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33103/
Test PASSed.

Test build #128479 has finished for PR 29626 at commit 16588f5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128479/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33113/
Test PASSed.

Test build #128489 has started for PR 29626 at commit 16588f5.

Test build #128478 has finished for PR 29626 at commit 9a44bec.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #128489 has finished for PR 29626 at commit 16588f5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128489/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128478/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33123/
Test PASSed.

Test build #128498 has started for PR 29626 at commit 16588f5.

Test build #128498 has finished for PR 29626 at commit 16588f5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128498/
Test FAILed.

github action passed, merging to master, thanks!

@cloud-fan Thanks


aws-iot-device-client: disable tests, as the new aws-c-io event loop …

…interface changed.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Successfully created backport PR for scarthgap-next:

#10420


Add option to limit install restarts

This PR adds an option to limit the number of install restarts by setting a
value in the ClusterDeployment field limitInstallRestarts. Once this limit has
reached, ProvisionStopped error condition will be set in the status.

/assign @staebler
/cc @abutcher

/cc @igoihman

We were planning to use this feature to prevent any install from ever starting, for scale test purposes.
https://issues.redhat.com/browse/CO-1184?focusedCommentId=15266161&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15266161
InstallRestartLimit implies the install will run at least once. Can you clarify?

We were planning to use this feature to prevent any install from ever starting, for scale test purposes.
https://issues.redhat.com/browse/CO-1184?focusedCommentId=15266161&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15266161
InstallRestartLimit implies the install will run at least once. Can you clarify?

Yes you right, InstallRestartLimit implies the install will run at least once.

We were planning to use this feature to prevent any install from ever starting, for scale test purposes.
https://issues.redhat.com/browse/CO-1184?focusedCommentId=15266161&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15266161
InstallRestartLimit implies the install will run at least once. Can you clarify?

Yes you right, InstallRestartLimit implies the install will run at least once.

Can we change InstallRestartLimit to InstallAttemptsLimit so that we can support 0 attempts?

We were planning to use this feature to prevent any install from ever starting, for scale test purposes.
https://issues.redhat.com/browse/CO-1184?focusedCommentId=15266161&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15266161
InstallRestartLimit implies the install will run at least once. Can you clarify?

Yes you right, InstallRestartLimit implies the install will run at least once.

Can we change InstallRestartLimit to InstallAttemptsLimit so that we can support 0 attempts?

There is one problem here, our attempts start from 0.

@gregsheremeta can we go for InstallAttemptsLimit here? or do we need separate InstallRestartsLimit and install-skip annotation features?

We were planning to use this feature to prevent any install from ever starting, for scale test purposes.
https://issues.redhat.com/browse/CO-1184?focusedCommentId=15266161&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15266161
InstallRestartLimit implies the install will run at least once. Can you clarify?

Yes you right, InstallRestartLimit implies the install will run at least once.

Can we change InstallRestartLimit to InstallAttemptsLimit so that we can support 0 attempts?

There is one problem here, our attempts start from 0.

That is not a problem.
if InstallAttempts >= InstallAttemptsLimit {
   // do not start a new provision
}

+1 for InstallAttemptsLimit and killing two birds with one stone.

PR updated

@staebler changes look good to you?


docs: include helpValue for flags that need UUIDs

Added helpValue for flags that need UUIDs.
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project (npm run lint produces no warnings/errors)
[ ] Any required documentation has been added
[ ] I have added tests to cover my changes

:tada: This PR is included in version 1.16.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


bug: linux_profile admin_username takes wrong value

Currently the linux_profile block does not take the correct value as the for_each projection is not meaningful.
Current code:
 dynamic "linux_profile" {
    for_each = var.cluster.profile == "linux" ? { "default" = {} } : {}

    content {
      admin_username = try(linux_profile.value.username, "nodeadmin")
      ssh_key {
        key_data = azurerm_key_vault_secret.tls_public_key_secret[linux_profile.key].value
      }
    }
  }

Suggestion:
  dynamic "linux_profile" {
    for_each = var.cluster.profile == "linux" ? { "default" = {} } : {}

    content {
      admin_username = try(var.cluster.linux_admin_username, "nodeadmin")
      ssh_key {
        key_data = azurerm_key_vault_secret.tls_public_key_secret[linux_profile.key].value
      }
    }
  }

Within the data structure there is already a profile property for either windows or linux. Therefore there is no real need to include it as well in the naming of individual properties.


To make Bluesky different from Twitter, a fundamental review is necessary. First the name itself, change “mute” to “hide”.

The word "mute" is not originally used to a person, and the act of "mute" someone gives an inhumane impression.
How about simply naming it "hide"?
In addition, while "Report" should remain and "Public Block" is good new function, simple "block" function should rather be removed.
Because if an evil person sends a lot of replies to someone for harassment, and there is no simple "block" function but only a "hide" function on Bluesky, they will probably think like this: "Does this person actually 'hide' me? If I'm blocked on Twitter, I can know it. But Bluesky only has a 'hide' function, so I can't know what this person is doing. I'm sending a lot of replies for harassment, but maybe they're not even reaching this person. What I'm doing might be completely futile". Then they will feel frustrated and leave.
One may think, "Without a (simple) block function, my posts would be seen". However, unless it is a private account, posts can be seen if evil people log out from blocked accounts, so this is a completely meaningless specification.

Blocks also stop interactions which makes it harder for harassers to send other people to harass a user.

A simple "block" rather than a "block list" will not stop harassers to send other people.
Please reopen.
If that is not possible, I will create a new Issue with only the suggestion to change the name "mute" to "hide".


"git tag" your code

Hi.
I know the RAKU eco system, say ZEF, and develops are a bit "different" then other tools and developers, but could you please "git tag" your code with the same version as in the META6.JSON?
THANKS!!!

I can, but I’d like to understand better the necessity of this. Do you have a particular use case in mind, e.g. you would prefer downloading a release version from https://github.com/atweiden/config-toml/releases/download/0.0.01.tar.gz? If this is a new requirement of Zef, I’m sorry to say I was completely unaware of it. I’ve never had an issue doing zef install Config::TOML.

Hi.
Well, in general it's more or less about making SW builds "reproducible".
My use case is "Rakudo Star" and it's modules.
To be more precise, it's about how RSTAR "fetches" the required Rakudo Star modules to prepare the later build aka "dist" and following "install"....

Tags created for both Config::TOML and Crane. I wasn’t aware my modules were included in Rakudo Star. That’s nice to know.

THANK YOU!!!


Improve quick open accessibility

Should try to set the active descendant from the input field to the one set by the tree to see if we can get screen readers to talk the currently focused item.

Verify quick open is declared as dropdown list and the currently selected item is being read to you.


Regarding Terminal

Issue Type: Bug
Hi I found something.
After clearing terminal if I click on timeline the terminal data which was cleared comes back in terminal.
tried multiple times, same thing happens.
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz (4 x 2400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
11.90GB (7.07GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

material-icon-theme
PKi
4.2.0

Please confirm that you are talking about the contents of the TERMINAL tab on the Panel, and not the Git view of the OUTPUT tab.
Screenshot might help us understand what you mean. Paste from clipboard directly into GitHub textarea.


Pangeo@EOSC: scheduled maintenance window on 7th May, 2.30pm - 3.30pm CEST

Update docs and add warning message at login page.

Moving on with the migration at the scheduled time (i.e. in 15 minutes)
cc @annefou @tinaok

Migration completed.
Please open issues via https://github.com/pangeo-data/pangeo-eosc/issues as you find them.


App Drawer Added

closes #26

I hope its fine now, to resolve everything I just forked the repository again to make sure no conflicts happen this time.
And made a pull request from a branch other than master branch.

@diksh735 It looks good now, but you don't have to fork it, again and again, use git CLI to rebase the code. Also, can you just add tiles in the drawer with a retro theme? Like About, Cart, Wishlist, Products, & Log Out text-tiles in a ListView

Yes, I can do that
On Mon, 8 Mar 2021 at 19:02, HIMANSHU SHARMA<EMAIL_ADDRESS>wrote:

@diksh735 https://github.com/diksh735 It looks good now, but you don't
have to fork it, again and again, use git CLI to rebase the code. Also, can
you just add tiles in the drawer with a retro theme? Like About, Cart,
Wishlist, Products, & Log Out text-tiles in a ListView
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/himanshusharma89/relic_bazaar/pull/61#issuecomment-792758715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANO2OWQU5XC3OTNNNTMZJMTTCTGYHANCNFSM4YZM4QIQ
.

@diksh735 can you add the image of the updated drawer?

I did not know about the Icons you used so I used the Material Icons itself and the pixer font family which you have used in your App

Okay no issues @diksh735

@diksh735 Try to create different files for each view next time.

Sure !
On Tue, 9 Mar 2021 at 00:14, HIMANSHU SHARMA<EMAIL_ADDRESS>wrote:

@diksh735 https://github.com/diksh735 Try to create different files for
each view next time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/himanshusharma89/relic_bazaar/pull/61#issuecomment-792984304,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANO2OWQP4UVSEE6AOPWVKZ3TCULHRANCNFSM4YZM4QIQ
.


Symbol statics

/* @flow */
const FOO = Symbol('foo');

causes the error "function call Callable signature not found in statics of Symbol".

I've started attempting to resolve this.


Update integration doc between Corelight and MDE

Hello,
Couple of organizations got confused as the below public documentation sounds it shows an old screen shoot on the integration between Corelight and MDE specifically mainly on Step (1):
https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/corelight-integration?view=o365-worldwide
I think will be great to clarify the detailed integration and benefits with screen shots between:

MDE and Corelight for organizations only own MDE and Corelight
MDIoT + MDE + Corelight

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


CLOUDP-61387: Evergreen packaging improvements

Proposed changes

Improve naming to match what our repos do currently
improve how we use curator to handle versions as the server does
closes #130

New package name for rpm
mongodb-cli-unstable-0.2.0.latest.x86_64.rpm
Example name from server
mongodb-org-unstable-4.3.6-0.1.latest.el7.x86_64.rpm
New package name for deb
mongodb-cli-unstable_0.2.0~latest_amd64.deb
Example name from server
mongodb-org-unstable_4.3.6~latest_amd64.deb

@tychoish this is mostly setting up things to improve our naming and use a project setting for version, we may need to work on how to set that up, would be great if evg allowed tasks to un on tag

@colm-quinn decided to rollback the two files change and add a step in evergreen to manage the naming for yum/apt
Waiting for @tychoish on curator changes

@tychoish I'm going to merge this, please feel free to add any comment if you feel we are missing anything and we'll address this on a separate PR


renames + better logging around republishing

Codecov Report
Attention: Patch coverage is 71.68142% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 53.97%. Comparing base (52a4736) to head (ccea247).

Files
Patch %
Lines

impl/pkg/service/dht.go
65.62%
10 Missing and 1 partial :warning:

impl/pkg/dht/record.go
64.70%
6 Missing :warning:

impl/pkg/server/server.go
60.00%
3 Missing and 1 partial :warning:

impl/pkg/server/dht.go
75.00%
2 Missing and 1 partial :warning:

impl/pkg/storage/db/bolt/dht.go
57.14%
3 Missing :warning:

impl/cmd/cli/identity.go
0.00%
2 Missing :warning:

impl/concurrencytest/main.go
0.00%
1 Missing :warning:

impl/integrationtest/main.go
0.00%
1 Missing :warning:

impl/internal/did/did.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #191       +/-   ##
=========================================
+ Coverage      0   53.97%   +53.97%
=========================================
  Files         0       32       +32
  Lines         0     2538     +2538
=========================================
+ Hits          0     1370     +1370
- Misses        0     1029     +1029
- Partials      0      139      +139

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Deno release broken?

Trying to use as per docs
import { Ratelimit } from "https://deno.land/x/upstash_ratelimit/mod.ts";

I'm getting
Warning Implicitly using latest version (v0.3.7) for https://deno.land/x/upstash_ratelimit/mod.ts
Download<EMAIL_ADDRESS>worker thread panicked Import<EMAIL_ADDRESS>failed, not found.

When using esm.sh
import { Ratelimit } from "https://esm.sh/<EMAIL_ADDRESS>
I get
serving function upstash-redis-ratelimiter
worker thread panicked Uncaught SyntaxError: The requested module 'https://esm.sh/<EMAIL_ADDRESS>does not provide an export named 'Ratelimit'
    at file:///home/deno/functions/upstash-redis-ratelimiter/index.ts:3:10

Any ideas?

My code is here in case helpful: https://github.com/thorwebdev/edgy-edge-functions/pull/2

Thanks @thorwebdev
I'm taking a look

@thorwebdev
import x from "https://esm.sh/@upstash/ratelimit"
import { Redis } from "https://deno.land/x/upstash_redis/mod.ts"

const r = new x["Ratelimit"]({
    redis: Redis.fromEnv()
    limiter: x["Ratelimit"].fixedWindow(10, "10 s")
})
console.log(await r.limit("test"))

here's the hack to unblock you
I'm going to dig deeper to see why it broke

Can confirm that the workaround works for me, thanks 👍

A less hacky way is this, I have absolutely no idea why esm.sh doesn't work
import { Ratelimit } from "https://cdn.skypack.dev/@upstash/ratelimit@latest"

I'll update our docs with this while we're still waiting for native npm:@upstash/ratelimit support in deno deploy


Prep for release

Added this PR to the changelog: https://github.com/microsoft/vscode-azurefunctions/pull/3621
and updated the release date


FTB  /data/FeedTheBeast/ServerStart.sh: No such file or directory

sudo docker run -d -e ENABLE_QUERY=true -e VERSION=1.10.2  -v /home/adevries/minecraft/server1:/data -e EULA=TRUE -p 25565:25565 -e TYPE=FTB -e FTB_SERVER_MOD=FTBPresentsSkyfactory3-3.0.15-1.10.2.zip --name server1 itzg/minecraft-server
sudo docker logs -f server1
Switching to user 'minecraft'
Checking version information.
Checking type information.
Looking for Feed-The-Beast server modpack.
chmod: /data/FeedTheBeast/ServerStart.sh: No such file or directory
sed: /data/FeedTheBeast/ServerStart.sh: No such file or directory
server.properties already created, skipping
Setting ops
Skipping JSON check. No files present.
Setting initial memory to 1G and max to 1G
cp: can't stat '/data/white-list.txt': No such file or directory
Running FTB server modpack start ...
/start-minecraftFinalSetup: line 84: /data/FeedTheBeast/ServerStart.sh: No such file or directory

This was a user error need to user the server version of the FTB ie FTBPresentsSkyfactory3Server_3.0.15.zip


⚠ Bofrost.es has degraded performance

In 0f8a151, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1563 ms

Resolved: Bofrost.es performance has improved in 94852a4 after 9 minutes.


Failing inline use case.

From Indigo, this does not work. The fragment shader fails to compile (in the browser) complaining about sdf:
object UVShaders:

  import ultraviolet.syntax.*

  inline def modifyVertex: vec4 => Shader[IndigoVertexEnv, vec4] =
    (vertex: vec4) => Shader[IndigoVertexEnv, vec4](_ => vertex)

  inline def circleSdf = (p: vec2, r: Float) => length(p) - r

  inline def calculateColour = (uv: vec2, sdf: Float) =>
    val fill       = vec4(uv, 0.0f, 1.0f)
    val fillAmount = (1.0f - step(0.0f, sdf)) * fill.w
    vec4(fill.xyz * fillAmount, fillAmount)

  val circleId: ShaderId =
    ShaderId("uv circle")

  val circle: UltravioletShader =
    UltravioletShader(
      circleId,
      BaseEntityShader.vertex(modifyVertex),
      BaseEntityShader.fragment { _ =>
        Shader[IndigoFragmentEnv, vec4] { env =>
          val sdf = circleSdf(env.UV - 0.5f, 0.5f)
          calculateColour(env.UV, sdf)
        }
      }
    )

For reference, the function signature for BaseEntityShader.fragment is:
inline def fragment(inline modifyColor: vec4 => Shader[IndigoUV.IndigoFragmentEnv, vec4]): ShaderResult

To be clear, the bit that doesn't work is the in place Shader:
      BaseEntityShader.fragment { _ =>
        Shader[IndigoFragmentEnv, vec4] { env =>
          val sdf = circleSdf(env.UV - 0.5f, 0.5f)
          calculateColour(env.UV, sdf)
        }
      }

If you move the shader block out into an inline def, it works again.

Closing. I've tested this and I can't replicate the problem. I believe that's because this is secretly a duplicate of issue #81, and certainly my attempts to replicate now produce the kind of output seen due to the fix that was put in.


OpenAI Prompt Caching appears not enabled?

Which API Provider are you using?
OpenAI
Which Model are you using?
gpt-4o-mini
What happened?
I select any of the available openAI models and they all indicate that the model "Does not support prompt caching". However, openAI says they do. https://platform.openai.com/docs/guides/prompt-caching
Steps to reproduce

Select Settings
Select API Provider = OpenAI
Enter API Key
Select any model from the model drop down

Relevant API REQUEST output
No response
Additional context
No response

It technically is being applied in the backend by openai, so the api cost in extension is not accurate as of right now. Will fix asap, thank you for reporting

I notice this as well with GCP Vertex/Sonnet models. Same issue?

After using Opus for momentarily the prompt caching seems to be gone for Sonnet 3.5. It worked fine before I used Opus.

Update: Caching doesn't seem to work for Anthropic models when using OpenRouter.

@ntrpnr +1 on that! @saoudrizwan Caching was working fine the day before and now it doesn't anymore.


Lectures: Add Editing Functionality to Attachment PDF Preview

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
[x] I strictly followed the principle of data economy for all client-server REST calls.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context
Currently, in PDF Preview Component, the users are limited to viewing PDFs, but as the related Feature Request mentioned before, for a more interactive and efficient file handling system, there is a need to streamline the process of organizing and editing PDF content without relying on external tools. By introducing advanced file manipulation capabilities, we aim to reduce the time and effort spent on managing PDF files, further enhancing the overall user experience and ensuring consistency within the application. The motivation behind this pull request is to provide users with greater control and flexibility when managing PDF files directly within the Artemis application by providing the most basic functionalities: removing and adding pages to a PDF File.
Implements #8768
Description
This pull request introduces several new features to enhance PDF handling within the Artemis application. The existing PDFPreviewComponent has been upgraded to allow users to interact with PDF files more efficiently. Users can now select individual pages using checkboxes on each thumbnail, enabling multiple pages to be selected for various actions, such as removing or appending new pages. Additionally, users can append pages from other PDF files and save their modifications as a new document. These improvements streamline the process of managing PDF content directly in the application, providing a more flexible and intuitive experience.
NOTE: This PR will be divided into multiple parts in the next PR, it is not in the scope of this PR.
Steps for Testing

Prerequisites:

1 Instructor

Log in to Artemis
Navigate to Course Management > Lectures > Attachments
Add a PDF file as attachment or use a PDF file that has already been uploaded
Click "View" button to view it
Memorize the total page number of the PDF file
Select different pages in different locations and Click "Remove pages"
Verify that related pages are removed and page numbers are updated when you hover over them
Verify that total page number has changed after the removal
Click Append File button and select a PDF file and upload
Verify that the page automatically scrolled down to the end after the addition
Verify that new pages are added correctly after the last page of the first file
Click 'Save' and verify that you can see the success notification
Return back the "Attachments" page and verify that the version got 1 number higher
Switch to German mode to check if the buttons are translated correctly
Switch to Dark Mode to check if the colours of the buttons are correct
Click cancel to get back to Attachments page
Navigate to Course Management > Lectures > Lecture Units
Repeat from 3 to 16
Click cancel to get back to Lecture Units page

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Line Coverage
Confirmation (assert/expect)

pdf-preview.component.ts
91%
✅

Screenshots

1. General View with new Buttons

2. Delete Page Dialog Box

3. Append File Dialog Box

4. Alerts

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Enhanced PDF management capabilities, allowing users to view, delete, and append PDF files.
Introduced a "Remove Page(s)" button for deleting selected slides from PDFs.
Added a dedicated PDF display area with navigation controls for improved user interaction.
Improved layout and responsiveness of the PDF preview component using flexbox for better alignment and spacing.
Added loading indicators for PDF operations to provide visual feedback during loading states.
Integrated a new dependency for enhanced PDF functionality.

Bug Fixes

Enhanced error handling for PDF operations, providing better feedback to users.

Tests

Expanded test coverage for PDF management functionalities and user interactions, including new scenarios for merging PDFs and handling file inputs.

Skimmed through the code, looks good Just to make sure: maintainers agreed upon the new dependency? Also, please add coverage table for client tests

The coverage table is already at the top of the page
I think noting to do dependency-wise as PDF.js is only can be used for PDF rendering and pdf-lib or jsPDF is only for PDF altering :/

Tested on TS6 It would be nice to have functionality similar to File explorers where you can multi select with shift Also for example when holding cmd/ctrl that it know that you want to select a file and not open it. And therefore mark it instead of opening the page
But maybe you can just put that in a follow up issue and assign it to yourself to keep the MR small

Thanks for the comments, I think it would be better to add it in the next PR to keep this one small

I tested on TS6. Everything works as described. The deletion and apending work well. One thing I would like to suggest: Could we make it so that when clicking on a slide, it is still possible to delete it. This would be a bit more user-friendly, since I would like to double check if I delete the correct slide. Also the tick box on the corner of a slide is a bit small

Thanks! This will be addressed in the next PR :)

I added a pdf, went to the view mode, and then deleted the first page. Now, when clicking on view again, I get 500 server errors:

This is because the Course is not perceived in the Attachments page, you can also see after L1 - is empty. I think we can open and issue and fix it as a bug fix because it is not related to this directly

Seems like you forgot to unlock the artemis server 1

Tested on TS1. Everything works good, except one time I got an HTTP Failure Response after saving and re-opening the lecture again (I am not sure if it was my internet connection). But it loaded correctly after reloading the page a couple of times.

Yes this is a server error :)

I tested it on TS3 using the Chrome browser on Mac. Whenever I try to upload a PDF (3.3 MB) it crashes with the error code 5. I cleared my cache and also tried it in an inkognito tab, but same outcome.

Tested on TS2. I am getting a similar error:

I tried to reset my browser settings and then it worked to add an attachment, but just once. I couldn't do it again without reseting my settings again.


Tikhonov Regularization Matrix

Change utils.lstsq_reg() so that the regularization parameter reg, now called G, can be a matrix or a float. If a matrix, then the least squares problem being solved is
|| AX - B||_F^2 + ||GX||_F^2

If G is a float, then the regularization matrix is G*I (scaled identity matrix).
If G is a list of regularization matrices G = [G1, G2, ..., Gr], then decouple the problem to

||Ax_j - b_j||_2^2 + ||Gj x_j||_2^2.

@swischuk we can merge this now.


Completion fixes

commit 1 fixes an off-by-one that caused incorrect completions and/or crashes
commit 2 makes the crashes behave a bit better (they can still happen if e.g. you're not in an elm package when editing, which I'd also like to fix later)

Thanks!


JSCPD linting TSX files as Javascript

Is there an existing issue for this?

[X] I have searched the existing issues

Are you using the latest Super-linter version available?

[X] I am using the latest Super-linter version.

[X] I can reproduce the issue running Super-linter using complete version identifier (example: vX.Y.Z), and not just with a partial one (example: vX)

[X] I am using the super-linter/super-linter action or container image, and not the deprecated github/super-linter action or container image.

Are you resonably sure that it's a Super-linter issue, and not an issue related to a tool that Super-linter runs?

[X] I think that this is a Super-linter issue.

Current Behavior

There are incorrect clone hits on my .tsx files

Expected Behavior
JSCPD should not lint these files as Javascript
Super-Linter version
v6.7.0

Super-linter configuration
---
name: Lint

on:  # yamllint disable-line rule:truthy
  push: null

permissions: { }

jobs:
  build:
    name: Lint
    runs-on: ubuntu-latest

    permissions:
      contents: read
      packages: read
      # To report GitHub Actions status checks
      statuses: write

    steps:
      - name: Checkout code
        uses: actions/checkout@v4
        with:
          # super-linter needs the full git history to get the
          # list of files that changed across commits
          fetch-depth: 0

      - name: Super-linter
        uses<EMAIL_ADDRESS># x-release-please-version
        env:
          TYPESCRIPT_ES_CONFIG_FILE: .myeslintrc.yml
          VALIDATE_BASH: false
          VALIDATE_CLANG_FORMAT: false
          VALIDATE_GROOVY: false
          VALIDATE_JAVA: false
          VALIDATE_TYPESCRIPT_STANDARD: false
          VALIDATE_SHELL_SHFMT: false
          # To report GitHub Actions status checks
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
...

Relevant log output
Clone found (javascript):
   - /github/workspace/src/screens/SuccessfulOrder.tsx [77:2 - 88:16] (11 lines, 186 tokens)
     /github/workspace/src/screens/SuccessfulOrder.tsx [69:2 - 82:15]

   77 │ 69 │ }>
   78 │ 70 │                 <StyledText className='text-2xl font-bold mt-[2.5%]'>{'Confirming your order...'}</StyledText>
   79 │ 71 │                 <StyledText className='text-xl text-slate-400 mb-[5%]'>{order.merchantName}</StyledText>
   80 │ 72 │               </Container>
   81 │ 73 │     case 'Preparing':
   82 │ 74 │       return  <Container style={{borderBottomWidth: 2, borderBottomColor: 'gray',borderTopWidth: 2, borderTopColor: 'gray', width: '95%', justifyContent: 'center', padding: 5}}>
   83 │ 75 │                 <StyledText className='text-2xl font-bold mt-[2.5%]'>{'Preparing your order...'}</StyledText>
   84 │ 76 │                 <StyledText className='text-xl text-slate-400'>{order.merchantName}</StyledText>
   85 │ 77 │                 <StyledText className='text-xl text-slate-400 mb-[5%]'>{'Pickup: ' + pickupTime}</StyledText>
   86 │ 78 │               </Container>
   87 │ 79 │     case 'Ready':
   88 │ 80 │       return  <Container style={{borderBottomWidth: 2, borderBottomColor: 'gray', borderTopWidth

Steps To Reproduce

Add a .tsx file to a new react-native project
Write some functions with switch statements that return jsx elements

Anything else?
The weirdest thing is that the ranges for lines where these "duplicates" are not even the same size. Apparently, there are 82 lines of code between line 82 and line 94...

Hi, thanks for taking the time to report this issue.
This looks like a JSCPD-specific issue/question, rather than a Super-linter one. I'd suggest opening an issue in their repository directly: https://github.com/kucherenko/jscpd


Missing Iterable as sequence_like type

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
We have to add Iterable into sequence_like check:
def sequence_like(v: Any) -> bool:
    return isinstance(v, (list, tuple, set, frozenset, GeneratorType, deque))

According to Python Iterable protocol, only one method should be implemented - __iter__.
The list constructor accepts Iterable as parameter: list(items: Iterable) is valid
Without adding Iterable into list of sequence like types there is no ability to validate user-defined collections  that implements Iterable.

Actual problem:
The from_orm method does not work with association_proxy fields in SQLAlchemy, because SQLAlchemy returns AssociationList[str], that implements Iterable[str], but pydantic fails validation as List[str].
list(AssociationList()) works perfectly, so we have to fix sequence_like behavior.
PS
No idea why dequeue or GeneratorType is valid List type in pydantic, but Iterable is not.
Example Code
from collections import deque
from types import GeneratorType
from typing import List, Iterator, Any

# Custom user-defined collection that implements Iterable
class MyListOfStrings:

    def __init__(self, strings: List[str]):
        self._strings = strings

    def __iter__(self) -> Iterator[str]:
        for string in self._strings:
            yield string
        return

def sequence_like(v: Any) -> bool:
    return isinstance(v, (list, tuple, set, frozenset, GeneratorType, deque))

if __name__ == '__main__':
    result = MyListOfStrings(["a", "b", "c"])
    print(sequence_like(result))  # False
    print(list(result))  # OK

Python, Pydantic & OS Version
pydantic version: 1.10.7
            pydantic compiled: True
                 install path: /Users/kbespalov/workspace/api/lib/python3.9/site-packages/pydantic
               python version: 3.9.6 (v3.9.6:db3ff76da1, Jun 28 2021, 11:14:58)  [Clang 12.0.5 (clang-1<IP_ADDRESS>)]
                     platform: macOS-10.15.7-x86_64-i386-64bit
     optional deps. installed: ['dotenv', 'typing-extensions']

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[X] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

I just ran into the exact same problem with SQLAlchemy AssociationProxy objects. I strongly agree with this suggestion.
In my case, I was able to make a workaround:
class MyModel(BaseModel):
    id: int
    names: list[str]

    @validator('names', pre=True)
    def convert_to_list(cls, value):
        return list(value)

But it's definitely ugly, and the validator error you get from not having this conversion going on does not lead to this solution at all. (it just claims the value is not a valid list).
My pydantic version is 1.10.4

The following code now works in Pydantic v2.3.0
from typing import Iterable, Iterator, List

from pydantic import BaseModel

# Custom user-defined collection that implements Iterable
class MyListOfStrings:
    def __init__(self, strings: List[str]):
        self._strings = strings

    def __iter__(self) -> Iterator[str]:
        for string in self._strings:
            yield string
        return

class Model(BaseModel):
    value: Iterable[str]

m = Model(value=MyListOfStrings(['a', 'b', 'c']))

assert list(m.model_dump()['value']) == ['a', 'b', 'c']


runtime error Uncaught module babel-runtime/core-js/promise not found

Uncaught module babel-runtime/core-js/promise not found is the error we are getting after running the app. This is because of generated branch.js in www which does require of babel-runtime/core-js/promise.
I have tried adding babel-polyfill global.js, but it did not work. I am not well versed with babel as much, can you please suggest some quick fix?

hey @khagesh - can you try this again? We've just remove the babel dependency?

I've confirmed this is resolved. Apologies for the breakage.


add extension: transcribe_asr_python; bedrock_llm_extension: bugfix

Add Amazon Transcribe ASR Extension
Configurations
You can config this extension by providing following environments:

Env
Required
Default
Notes

AWS_ASR_REGION
No
us-east-1
The Region of Amazon Transcribe service you want to use.

AWS_ASR_ACCESS_KEY_ID
No
-
Access Key of your IAM User, make sure you've set proper permissions to start stream transcription. Will use default credentials provider if not provided. Check document.

AWS_ASR_SECRET_ACCESS_KEY
No
-
Secret Key of your IAM User. Will use default credentials provider if not provided. Check document.

update bedrock_llm_extension

add time buffer while processing model response
fix memory construction bug

Sure, considering this change is not campatiable with current branch, I will update code and submit PR directly to main branch.


Some jobs get cancelled on Ubuntu 22.04, apparently since the release of 20240310.1

Description
We're seeing in some of our repos that jobs running on Ubuntu 22.04 get canceled after a while without any apparent reason.
Examples:

https://github.com/BlueBrain/nmodl/actions/runs/8277134023/job/22646896159
https://github.com/neuronsimulator/nrn/actions/runs/8283452811/job/22696940407 (this one was triggered by a change to the README file...)

Could this be related to the image version? Or is there some OoM killing going on behind the scenes? Any insight would be appreciated!
I'm currently trying to build the 20240304 version of the Ubuntu 22.04 image to see if that makes a difference.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Version: 20240310.1.0
Is it regression?
https://github.com/BlueBrain/nmodl/actions/runs/8262516556/job/22605437491
Expected behavior
The job completes successfully without getting killed.
Actual behavior
The job gets killed without further explanation.
Repro steps
Not entirely clear, as not all of our jobs running on 22.04 are affected.

Looks like the workaround suggested there applies to at least one of the jobs I linked as well - thanks for the pointer!


Expose PrefetchSize option which maps to TotalCacheSizeInBytes

This change is strictly for partner team testing and will remain in a feature branch until it is fully vetted.

/azp run net - eventhub - ci

This has been superseded by #15141, closing this out


CHECK_TYPE_SIZE iOS error

Recently, I have started getting this error when compiling for iOS (architectures: armv7;arm64).
Note: No simulators enabled.
I haven't tracked down which commit of polly caused it but it seems fairly recent, as in this month or last month.

CHECK_TYPE_SIZE found different results, consider setting
CMAKE_OSX_ARCHITECTURES or CMAKE_TRY_COMPILE_OSX_ARCHITECTURES to one or no
architecture !

I get this when compiling dlib right now but it looks like any project causes this.
Have you got any insight as to why this might be happening?
It looks like it even happens with older polly versions so I am not sure if it was a change in hunter or polly that caused this.

Have you got any insight as to why this might be happening?

I guess check_type_size will work incorrectly if you're using toolchain with combined architectures. For armv7 + arm64 size of long will be 4 and 8 (I guess, not sure) and can't be determined on CMake configure stage, should be anallyzed at C++ compile stage.

I am not sure if it was a change in hunter or polly that caused this

Maybe CMake? Maybe this one: https://github.com/ruslo/polly/commit/b6d9289043a0f2ec60b8b27a1aa229b96a349979?

I went back to before this commit and still have the issue. I don't believe my version of CMake has ever changed (from 3.8.2) on this machine.
I had been successfully compiling my project with armv7 + arm64 for a while now. I can no longer do this even with an old polly due to this error.

I don't know what/why is happenning. Try to track down the issue, history of iOS changes is here:

https://github.com/ruslo/polly/commits/master/os/iphone.cmake

Plus take a look at changes of particular toolchain you're using. If you find the error and it's a valid case then test case can be added to .travis.yml to avoid such issues in future.
I guess Hunter URL/SHA1 is locked so it's probably not about Hunter.

I'm still not sure why it started happening (Cmake version unchanged, polly version unchanged).
However, I have fixed all of the ones I have found or have PR pending for them.
So this can be closed.


feat: custom attributes support

Making custom attributes strong-typed would be absolutely amazing.

Querying which custom attributes are available or query a specific custom attribute? The first one I don't think is available in the API yet. I think the team responsible for the API is looking into extending what is possible to do with custom attributes. If you have any requests on what you want to be able to do I can forward it to them and either get back how it's done, or it can be added as a suggestion for upcoming changes.

Forwarding that would be great! Thank you so much!
We operate a lot on custom attributes, and they change a lot for us. Being able to query them would allow for this generator to also strong-type them!
Let me know what they say.

Give me details on what you want to query, just so that I'm sure I understand correctly :)

Well, essentially anything that could lead to an Entity's custom_attributes object to become strong typed as well.
Right now, I am thinking:

The name of the attribute.
Perhaps the label too (but that's a whole other story, and will emit a value that is accessible at runtime - might not be in scope for now).
The type of the attribute. Whether it is an enumerator, string, decimal etc.
Whether the type allows decimal values.
If it is an enumerator, fetching the allowed values for it.
Etc.

So something like get custom_attributes_metadata from Task and get back an array with the different custom attributes and their metadata?
I'll forward that, I can see other times that could be useful.

Not working much with custom attributes, I was incorrect.
It is possible to query already, CustomAttributeConfiguration and CustomAttributeLinkConfiguration are the entity types to query. The available fields can be found in the API reference inside ftrack (Top right corner -> Help -> API reference).

Oooooh great! Then we should definitely utilize this from this project.


Add auto-formatting of test_spack.py into master

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

@PanicSheep I merge this PR. Only formatting to spack_test.py, since it slipped through the autoformatting.


strong or weak augmentation have an ambiguity

on train_promin.py
        # inputs_x: strong augmentation
        # inputs_x2: weak augmentation

Code comments and actual code execution are exactly opposite. What should be the correct one? Is the comment written wrong?

Why input_x2 did not participate in subsequent network training?

Apologies for the minor issues in our comments. The input_x denotes weak augmentation, while input_x2 denotes strong augmentation. The primary role of input_x2 is to be involved in consistency regularization computations (in loss_cr and loss_cr_2).


Added a landscape layout for fragment_nc_login.xml

Description:
This pull request adds a landscape layout for fragment_nc_login.xml to improve the user experience in landscape mode.
Compared with the original UI, this new landscape UI has the following features:

The second TextView is center-aligned instead of left-aligned to make this UI look more aesthetic.
The TextInputLayout is aligned with the left and right borders of the TextView above it to make this UI layout neater.

Preview:

Nice! Need to do the same modification to fragment_nc_login_motion.xml too. Besides,  could save boilerplate code by specifying string resource for landscape mode only


Not Working on Raspberry Pi 4

I installed it as a stack via portainer on my Pi 4. It runs on Pi OS lite 64Bit and the newest updates. When I queue a Test, nothing is happening. I attached a log File.
_speedtest-tracker_logs (1).txt
My Stack Code:
version: '3.3'
services:
speedtest-tracker:
container_name: speedtest-tracker
ports:
- '1080:80'
- '1443:443'
environment:
- PUID=1000
- PGID=1000
volumes:
- '/home/docker/speedtest:/config'
image: 'ghcr.io/alexjustesen/speedtest-tracker:v0.9.1@sha256:bef96eebdd14139fa547000ac304b25bc39f04f211e23efccaeb4e355f4bde4d'
restart: unless-stopped

@WaizenErnter try pulling the latest image, I've got this running on an rpi 4b+ and having no issues. Same OS too

@alexjustesen Did you use docker compose in the terminal, docker compose in portainer or docker run?

portainer w/ a stack which is docker-compose from the docs

Which DB version do you use?

@alexjustesen Which DB version do you use?

I'm connecting to a mysql instance on another server in my stack.


[Event Request] codeunit 90 "Purch.-Post" - OnRunOnPostPurchLine()

Describe the request
    PurchaseLinesProcessed := false;
    if TempPurchLineGlobal.FindSet() then
        repeat
            IsHandled := false;
            OnRunOnPostPurchLine(PurchHeader, TempPurchLineGlobal, IsHandled); //CustPub
            if not IsHandled then begin
                OnRunOnBeforePostPurchLine(TempPurchLineGlobal, PurchHeader);
                ErrorMessageMgt.PushContext(ErrorContextElementPostLine, TempPurchLineGlobal.RecordId, 0, PostDocumentLinesMsg);
                ItemJnlRollRndg := false;
                LineCount := LineCount + 1;
                if GuiAllowed and not HideProgressWindow then
                    Window.Update(2, LineCount);

                PostPurchLine(
                  PurchHeader, TempPurchLineGlobal, TempVATAmountLine, TempVATAmountLineRemainder,
                  TempDropShptPostBuffer, EverythingInvoiced, ICGenJnlLineNo);
                OnRunOnAfterPostPurchLine(TempPurchLineGlobal);
            end;

[IntegrationEvent(false, false)]
local procedure OnRunOnPostPurchLine(var PurchaseHeader: Record "Purchase Header"; var PurchaseLine: Record "Purchase Line"; var IsHandled: Boolean) //CustPub
begin
end;

Additional context
Publisher request marked with //CustPub tag.Internal work item: AB#494232

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14917.


Asyncio: ApplicationRunner doesn't handle correctly restart of the event loop

Running a asyncio.wamp.ApplicationSession with ApplicationRunner.run(session start_loop=True)
two consecutive times fails the second one.
Minimal example: https://gist.github.com/rdebroiz/1854c2bab7da929e376c273d262c805a
Adding
if loop.is_closed():
    asyncio.set_event_loop(asyncio.new_event_loop())

Before to run the ApplicationRunner the second times make it works as expected.
This code snippet is coming from and is already called by asyncio.wamp.ApplicationRunner.run
see: https://github.com/crossbario/autobahn-python/blob/master/autobahn/asyncio/wamp.py#L246
Any ideas of what is going on?

I can definitely reproduce the issue and after some initial debugging, I am a little confused as we are definitely checking if the loop is closed and setting a new one.
That's most probably a race condition, needs more digging.

Commenting this out seems to fix the issue https://github.com/crossbario/autobahn-python/blob/master/autobahn/asyncio/wamp.py#L283


feat: Improve extends of readonly types

Description:
type A = readonly string[] extends unknown[] ? string : never;

let a: A = "1" as never;
a; // never;

type B = string[] extends readonly unknown[] ? string : never;
let b: B = "1" as string;
b; // string

type C = readonly string[] extends readonly unknown[] ? string : never;
let c: C = "1" as string;
c; // string

Related issue (if exists):
#1011

As far as I can tell, there were no changes to the stats.