Copilot chat small list of bugs

A few different small bugs on Copilot chat:
First off, splendid work with Copilot chat. It's super useful to have this chatbot to help with code.
Seems this is the only way to give feedback, so I hope this helps a bit :)
Bugs:

Suggests different libraries that do the same thing, ignoring what we are using. (Might suggest PyPDF2 and later will use pdfMiner in another function)

I'm not sure what the context window is (8k?) but after using it for a while, it becomes more likely to get stuck in loops such as
"User: Can you help me join these 2 objects by id?"
"CoPilot: Sure: ...
const source result.content.find((item) => item.id === interviewID);"
"User: Thanks, but the interviewID is found in the "groupedInterviews" object"
"CoPilot: Sorry...
const sources = groupedSources[interviewID];"
"User: Thanks, but I need to find those ID's in the content object to join them"
"CoPilot: Sorry...
const source result.content.find((item) => item.id === interviewID);"

Feels like it ran out of context tokens, tries and fails to find relevant context and does the same answer again. Clearing chat or more detailed prompting helps but it's a bit annoying.

Copy pasting is awful. Not sure if it is meant to be on purpose, but sometimes I cannot copy anything from inside the copilot chat, unless I use the "copy" button inside the code snippet. And that copy button copies the full snippet when I just might need a line or two.

Seems to be cause the chat is made from different containers, and one must "select" the container first, to get inside, to copy things within it. (Image attached showing the outer container selected and how one can only select and copy things out of the outer container.)

Depending on the data I'm working on (I work with lots of text) I will get the "I can only answer code questions" response.
E.g.
User: "I need to debug this, however not sure which variables will help me get to the issue faster. here's my snippet:
data = "This is some random text I need to work with. I work with transcripts, so questions are common. Why does CoPilot think this is part of my question?" const foo = data. Split(". ")"
Copilot: "I'm sorry, I can only answer questions about code..."

That would be it for right now. Hope this helps Copilot Chat improve. I'm a fan. And thanks for your hard work!

Onward
Julio Castro

VS Code Version: Latest Insiders (1.79)
OS Version: Windows 11
Logs: NA

Thank you for your feedback. We've made several updates in areas which impact the scenarios you have described. Please give it a try in our newer releases.


application '@myapp/learn' died in status LOADING_SOURCE_CODE: Error loading http://localhost:8500/myapp-learn.js (SystemJS Error#3 https://git.io/JvFET#3)     at HTMLScriptElement.

Getting the above error while trying to run my react application

The error itself has a link to a page where you can find help on how to solve it.
For convenience, here is the link again https://github.com/systemjs/systemjs/blob/master/docs/errors.md#3


Facebook feed not working

Hello I use the example page : https://pavelk2.github.io/social-feed-example/ and try to get the facebook feed from the page https://www.facebook.com/volvospecialistmaine/. Inserting at the dialog box of the app  @volvospecialistmaine, #volvospecialistmaine but nothing gets returned why?

i suggest do install your version of the plugin in your server and enable only facebook with your APP access token to real testing it.


45 Fixing current adc

name: Stephen Taylor
about: Implementing Current Readings
title: Junior Specialist
labels: ''
assignees:
reviewers: 'jmadden173'
Name/Affiliation/Title
Stephen Taylor/UCSC/JS
Purpose of the PR
Fixed the timing issues with HAL that prevented current readings. Cleaned up libraries to match style guide.
Development Environment
Windows, SPS 2.2
Test Procedure
Run the unit test, this should test whether the ADC can even function. Then hook the SPS current and voltage ports and run the 'example_adc' environment to check for reasonable values.
Additional Context
N/A

I'm confused, is the PR fixing the current measurements? Or adding calibration files? How do I test it? The build is also failing. Conflicts need to be fixed as well.

.pio\build\stm32\src\lora_app.o: In function LoRaWAN_Init':
lora_app.c:(.text.LoRaWAN_Init+0xc4): undefined reference to TimeSync' lora_app.c:(.text.LoRaWAN_Init+0xc8): undefined reference to OnTimeSync'`
The build failing is due to the functions you didn't include in user code, this should be resolved upon merge.

Closes #45


Secrets with special characters are not loading from file

Describe the bug
Secrets appear to be failing when loading from a file.  Secrets have "$#[$~?>" characters in it.  It seems one is not being escaped properly in file based .env secrets.
To Reproduce
version: v1beta1
kind: Spicepod
name: postgres-demo

secrets:
  - from: env
    name: env
    params:
      file_path: .env

datasets:
  - from: postgres:customer
    name: customer
    acceleration:
      enabled: true
    params:
      pg_host: <redacted host>
      pg_user: postgres
      pg_db: tpch
      pg_pass: ${env:PG_PASS}
      pg_sslmode: require

Use the following spicepod yaml as guidance, host name and secret were removed, but use the special characters in the .env file in the secrets.
Expected behavior
secrets load and can be used in the connection to the dataset.
spice, spiced, OS info

spice version: spice version
spiced version: spiced --version
OS info: uname -a

Have you tried this on the latest trunk branch?
yes
Additional context
The postgres connector doesn't complain about the secrets, but instead says authentication failed.  The same secrets can be loaded in environment variables and the dataset loads successfully.

This is the result of $ being treated for variable substitution as documented here: https://github.com/dotenv-rs/dotenv?tab=readme-ov-file#variable-substitution
The fork we use of dotenv (which is abandoned), dotenvy keeps this functionality (although its not documented anywhere). https://github.com/allan2/dotenvy
We'll need to either fork dotenvy to remove this substitution logic or document the restriction

I raised an issue on dotenvy to ask for a way to disable the substitution feature: https://github.com/allan2/dotenvy/issues/113


Mypy doesn't like **dict syntax for model instance creation

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
class TestMod(RSBaseModel):
    name: Optional[str]
    age: int

x = {"age": "hello"}

my_test = TestMod(**x) <--- error appears here

This code creates the following mypy error: Argument 1 to "TestMod" has incompatible type "**Dict[str, str]"; expected "int".
Is there any way to keep init type checking (ie init_typed = True in mypy.ini in the pydantic plugin config) and also to get rid of this error?
Thanks in advance and apologies if this has been covered before. I've honestly spent a good deal of time trying to find a solution.

This is not a bug, but a question. And you haven't described what RSBaseModel .
Please use discussions for questions and describe your question fully.

@raph90 did you find a solution? I have the same problem too.


Master not released to npmjs

Hi!
Latest release (v0.1.1) seem to be a bit outdated, not supporting maximum.

@jgallen23 Any plans on releasing the update to npm?

latest should be on npm - is it not?

Info on readme says it supports max size, but info on npm does not says anything about a max size
I thought it was not updated, but I've tested here and both versions ignore the 'max' property
So, a bug?

maybe a bug - can you create a PR to fix?

no problem


ARROW-1562: [C++] Numeric kernel implementations for add

It's just an initial AddKernel implementation (work in progress). I could not come up with a better implementation of type inference, so I want to hear your thoughts about implementation.

Multiple notes:

The Compare kernels only support comparing the same type, it expects the caller to decide (via Cast kernel) how to deal with mis-matching types. I think this would be the most simple and sane behavior.
The Sum kernels upcast to the widest type. This might be less of an issue here, but I think we should take a decision.
I wouldn't merge this without supporting null, this is too frequent to avoid.
This code is regular enough to support other basic arithmetic operations, i.e Addition, Substraction, Multiplication, Division.

@fexolm it looks like @fsaintjacques gave some feedback on implementation do you  need more guidance?

@emkornfield no, I just can not find the time to finish this. I will return to this as soon as I get time.

@fsaintjacques, @emkornfield
I've removed type inference from the code, also add nulls support.
BTW I haven't decided yet how it can be architecturally generalized to support other arithmetic operations. I see, that almost all the code could be reused in other operations, but not sure how to implement it.
Maybe it would be better to do this in other pr, because I'm not sure I have enough time for it now.

Thanks @fexolm @fsaintjacques do you have time to review?

Will review again.

I created https://issues.apache.org/jira/browse/ARROW-7017 as a followup.


Remember selection of tabs when clicking through issues.

Describe the solution you'd like
When I select a tab, for example "Attachments", then select the next issue, I want it to continue showing the tab.  Right now it switches back to "Threads".

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hey @Bluebeary7 thanks for filing an issue! This is actually planned work for the quarter. I'll post in this thread with updates. Thanks!


(Suggestion) Make redstone mode only available for players with build security permission.

Make redstone mode only available for players with build security permission.

Can you elaborate on your reasoning?

Well, some machines might only be supposed to be accessed by users with permission.
Like the Grid, i want users to be able to deposit items, but not alter redstone mode as it should only be active when i send a redstone signal from a computer controlling when it should be available.
Another thing is that in the security manager a user with "Change" permission might disable the security manager completely giving access to all other security permissions by setting "only active when redstone signal".

Sorry, this will be a wontfix. If I do redstone mode, there is no clear line of what other side "configuration" buttons need protecting.


Components need to be compatible with stricter Ivy type checking

Eventually we need to go through our components and ensure that they still pass with Ivy's better/stricter type-checking. This can be done once type-checking is complete.
Type-checking progress is tracked with FW-1004.

I believe this is the same issue (Angular 8)..
core.js:7187 ERROR TypeError: Cannot read property 'createEmbeddedView' of undefined
at ViewContainerRef_.createEmbeddedView (core.js:20114)
at DomPortalOutlet.attachTemplatePortal (portal.js:343)
at DomPortalOutlet.attach (portal.js:225)
at OverlayRef.attach (overlay.js:926)
at MatMenuTrigger.openMenu (menu.js:1184)
at MatMenuTrigger.toggleMenu (menu.js:1166)
at MatMenuTrigger._handleClick (menu.js:1511)
at MatMenuTrigger_click_HostBindingHandler (menu.js:1575)
at executeListenerWithErrorHandling (core.js:16053)
at wrapListenerIn_markDirtyAndPreventDefault (core.js:16088)

@IanDesouza That is a different issue and has been solved with https://github.com/angular/angular/commit/2b4d5c75486534decef4030d4166806878929e4c. This should be released soon as part of a new beta for the Ivy opt-in.

When will this be fixed? I have the same issue as #16287.
core.js:7187 ERROR TypeError: Cannot read property 'createEmbeddedView' of undefined
    at ViewContainerRef_.createEmbeddedView (core.js:20128)
    at DomPortalOutlet.attachTemplatePortal (portal.js:343)
    at DomPortalOutlet.attach (portal.js:225)
    at OverlayRef.attach (overlay.js:926)
    at MatMenuTrigger.openMenu (menu.js:1184)
    at MatMenuTrigger.toggleMenu (menu.js:1166)
    at MatMenuTrigger._handleClick (menu.js:1511)
    at MatMenuTrigger_click_HostBindingHandler (menu.js:1575)
    at executeListenerWithErrorHandling (core.js:16028)
    at wrapListenerIn_markDirtyAndPreventDefault (core.js:16063)

with the following package file:
{
  "name": "client",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "8.0.3",
    "@angular/cdk": "8.0.1",
    "@angular/common": "8.0.3",
    "@angular/compiler": "8.0.3",
    "@angular/core": "8.0.3",
    "@angular/forms": "8.0.3",
    "@angular/material": "8.0.1",
    "@angular/platform-browser": "8.0.3",
    "@angular/platform-browser-dynamic": "8.0.3",
    "@angular/router": "8.0.3",
    "rxjs": "6.4.0",
    "tslib": "1.10.0",
    "zone.js": "0.9.1"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "0.800.6",
    "@angular/cli": "8.0.4",
    "@angular/compiler-cli": "8.0.3",
    "@angular/language-service": "8.0.3",
    "@types/node": "8.9.4",
    "@types/jasmine": "3.3.8",
    "@types/jasminewd2": "2.0.3",
    "codelyzer": "5.0.0",
    "jasmine-core": "3.4.0",
    "jasmine-spec-reporter": "4.2.1",
    "karma": "4.1.0",
    "karma-chrome-launcher": "2.2.0",
    "karma-coverage-istanbul-reporter": "2.0.1",
    "karma-jasmine": "2.0.1",
    "karma-jasmine-html-reporter": "1.4.0",
    "protractor": "5.4.0",
    "ts-node": "7.0.0",
    "tslint": "5.15.0",
    "typescript": "3.4.3"
  }
}

FW-1004 seems to be specific to template type checking.
We already have fairly strict compiler flags in https://github.com/angular/components/blob/master/tsconfig.json. Are there plans to change those flags?

random ping here, as this is a good flag to have.

FW-1004 has been resolved.
https://github.com/angular/components/blob/master/src/bazel-tsconfig-build.json has some, but not all strict flags enabled. Are there plans to change these to be more strict?
Should we enable? I'm not sure how much value these bring.
    "noUnusedParameters": false,
    "noUnusedLocals": false,

Should we also enable "strictBindCallApply": true?
What's the next step here as this is no longer blocked?

There is now documentation on the options for Ivy Template Type Checking:
https://next.angular.io/guide/template-typecheck
Related: https://github.com/angular/angular/issues/33452

Our Ivy Template Type Checking options are configured here
https://github.com/angular/components/blob/3f6a1fda916c0e490a5a38708222116dac3aa52f/tools/bazel/postinstall-patches.js#L107-L112
As mentioned there, they are in a postinstall patch due to https://github.com/angular/angular/issues/33452.
We'd like to enable strictAttributeTypes and resolve issues (like NgModel#disabled conflicting with other disabled inputs) related to it.
strictDomLocalRefTypes and strictDomEventTypes is also something that we would like to enable but we've seen cases where events on an <input> produce the HTMLElement type rather than HTMLInputElement. This needs further investigation and an issue report may need to be made.

This has been resolved.


Provide a refresh or delete method

E.g. the content changes dynamically and you need to update the slider order.

Unfortunately this repo is no longer actively maintained due to the large amount of alternative slider- and lightbox plugins.


meta: list of things we want

List of shapes we want CLI tools for

[x] cylinder
[x] ellipsoid
[x] sphere
[x] cuboid
[x] cube
[x] cone
[ ] curved membrane

All would ideally have a configurable soft edge parameter.
I think we should parametrise diameters/radii in angstroms as a general rule but happy to discuss if you don't agree!
not sure how the membrane should be specified...

Awesome stuff! This repo is a much more torough version of something I worked on here https://github.com/brisvag/stemia/blob/main/src/stemia/image/create_mask.py.
I have a couple suggestions based on my work on that that might be useful here:

At the time I used https://pypi.org/project/edt/. I think it was faster than scipy at the time (and had more options to work with multiple labels, irrelevant here).
Implementing the mask with a "range" approach (instead of just using >= in the SDF) will give you "for free" the ability to have a hollow cylinder, sphere, cube, and everything else. I do this here:
https://github.com/brisvag/stemia/blob/b577790fd2177755f0ebeba956bd49902ef61bf5/src/stemia/utils/image_processing.py#L151
Using the smoothstep_normalized or something similar should give better results for the padding
Curved membranes are just a very big hollow sphere with the center outside the box... :wink:

Thanks very much for this, @brisvag . Have taken your #4 suggestion as this was easiest to implement. Have taken a look at your other suggestions and look forward to following up on them


cmd/link: undefined reference to __imp___iob_func on windows with import C / x/sys/windows

What version of Go are you using (go version)?

$ go version
go version go1.19.4 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=                                                                                set GOARCH=amd64                                                                                set GOBIN=                                                                                set GOCACHE=C:\Users\steve\AppData\Local\go-build                                                                                set GOENV=C:\Users\steve\AppData\Roaming\go\env                                                                                set GOEXE=.exe                                                                                set GOEXPERIMENT=                                                                                set GOFLAGS=                                                                                set GOHOSTARCH=amd64                                                                                set GOHOSTOS=windows                                                                                set GOINSECURE=                                                                                set GOMODCACHE=C:\Users\steve\go\pkg\mod                                                                                set GONOPROXY=                                                                                set GONOSUMDB=                                                                                set GOOS=windows                                                                                set GOPATH=C:\Users\steve\go                                                                                set GOPRIVATE=                                                                                set GOPROXY=https://proxy.golang.org,direct                                                                                set GOROOT=C:\Program Files\Go                                                                                set GOSUMDB=sum.golang.org                                                                                set GOTMPDIR=                                                                                set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64                                                                                set GOVCS=                                                                                set GOVERSION=go1.19.4                                                                                set GCCGO=gccgo                                                                                set GOAMD64=v1                                                                                set AR=ar                                                                                set CC=gcc                                                                                set CXX=g++                                                                                set CGO_ENABLED=1                                                                                set GOMOD=C:\Users\steve\source\goWebView\go.mod                                                                                set GOWORK=                                                                                set CGO_CFLAGS=-g -O2                                                                                set CGO_CPPFLAGS=                                                                                set CGO_CXXFLAGS=-g -O2                                                                                set CGO_FFLAGS=-g -O2                                                                                set CGO_LDFLAGS=-g -O2                                                                                set PKG_CONFIG=pkg-config                                                                                set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\steve\AppData\Local\Temp\go-build3017409395=/tmp/go-build -gno-record-gcc-switches

What did you do?
I tried to compile the program shown at the bottom of this issue using go build.

What did you expect to see?
I expected my program to compile or at least give me an error in my code.
What did you see instead?
C:\Users\steve\source\goWebView> go build
github.com/steowens/goWebview
C:\Program Files\Go\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2288540720\000005.o: in function _cgo_preinit_init': \\_\_\runtime\cgo/gcc_libinit_windows.c:40: undefined reference to __imp___iob_func'
c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2288540720\000005.o: in function x_cgo_notify_runtime_init_done': \\_\_\runtime\cgo/gcc_libinit_windows.c:105: undefined reference to __imp___iob_func'
c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2288540720\000005.o: in function _cgo_beginthread': \\_\_\runtime\cgo/gcc_libinit_windows.c:149: undefined reference to __imp___iob_func'
c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2288540720\000006.o: in function x_cgo_thread_start': \\_\_\runtime\cgo/gcc_util.c:18: undefined reference to __imp___iob_func'
collect2.exe: error: ld returned 1 exit status
Attaching source code for program.  I simply have no clue what this error is telling me and there doesn't seem to be any answers on the web as to how to get a clue.
Program: main.go
package main

import "C"
import (
	"log"
	"golang.org/x/sys/windows"
)

var hModule windows.Handle

func init() {
	err := windows.GetModuleHandleEx(0x01, nil, &hModule)
	if err != nil {
		panic(err)
	}

}

func main() {
	log.Println("Hello")
}

Here is the go.mod file
module github.com/steowens/goWebview

go 1.19

require golang.org/x/sys v0.3.0

Apparently commenting out the following line fixes the compilation issues;
import "C"
And I found this: https://stackoverflow.com/questions/30412951/unresolved-external-symbol-imp-fprintf-and-imp-iob-func-sdl2
So apparently something in the go package "golang.org/x/sys/windows" is incompatible with "C"

That stack overflow answer suggests a remedy. Did you try it?

I did try it but it created other problems.  Things get flaky using golang.org/x/sys/windows in conjunction with "C".  The stack overflow basically further down says that it's a matter of having libraries compiled with older compilers mixing with code compiled with up to date compilers.   https://msdn.microsoft.com/en-us/library/bb531344.aspx#BK_CRT  So basically stay away from packages which contain static linked code compiled by an older compiler.

Maybe @alexbrainman has ideas. I don't know much about the Windows build.

This has happened to me on different projects so much as to render go almost unusable.  This project which does not even include "C" gets the same issue, here is the Golang dependency tree for the project.   The problem is this is not a toy project and it kind of stinks having to verify each and every new dependency to see if it will render the project uncompilable with this issue.  It's friction.  It slows development and kind of erodes the value proposition that go enables you to get stuff done faster.
require (
	github.com/google/uuid v1.3.0
github.com/mattn/go-sqlite3 v1.14.16
	github.com/wailsapp/wails/v2 v2.2.0
	golang.org/x/crypto v0.4.0
)

require (
	github.com/leaanthony/go-ansi-parser v1.6.0 // indirect
	golang.org/x/exp v0.0.0-20221217163422-3c43f8badb15 // indirect
)

require (
	github.com/bep/debounce v1.2.1 // indirect
	github.com/go-ole/go-ole v1.2.6 // indirect
	github.com/imdario/mergo v0.3.13 // indirect
	github.com/jchv/go-winloader v0.0.0-20210711035445-715c2860da7e // indirect
	github.com/labstack/echo/v4 v4.9.1 // indirect
	github.com/labstack/gommon v0.4.0 // indirect
	github.com/leaanthony/gosod v1.0.3 // indirect
	github.com/leaanthony/slicer v1.6.0 // indirect
	github.com/mattn/go-colorable v0.1.13 // indirect
	github.com/mattn/go-isatty v0.0.16 // indirect
	github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
	github.com/pkg/errors v0.9.1 // indirect
	github.com/rivo/uniseg v0.2.0 // indirect
	github.com/samber/lo v1.37.0 // indirect
	github.com/tkrajina/go-reflector v0.5.6 // indirect
	github.com/valyala/bytebufferpool v1.0.0 // indirect
	github.com/valyala/fasttemplate v1.2.2 // indirect
	github.com/wailsapp/mimetype v1.4.1 // indirect
	golang.org/x/net v0.4.0 // indirect
	golang.org/x/sys v0.3.0 // indirect
	golang.org/x/text v0.5.0 // indirect
)

Related issue https://github.com/golang/go/issues/51007

go env output?
how did you install the go toolchain?
how did you install the gcc toolchain?
does it build if the whole thing is built from scratch (go build -a)?

go env output
set GO111MODULE=                                                                                set GOARCH=amd64                                                                                set GOBIN=                                                                                set GOCACHE=C:\Users\steve\AppData\Local\go-build                                                                                set GOENV=C:\Users\steve\AppData\Roaming\go\env                                                                                set GOEXE=.exe                                                                                set GOEXPERIMENT=                                                                                set GOFLAGS=                                                                                set GOHOSTARCH=amd64                                                                                set GOHOSTOS=windows                                                                                set GOINSECURE=                                                                                set GOMODCACHE=C:\Users\steve\go\pkg\mod                                                                                set GONOPROXY=                                                                                set GONOSUMDB=                                                                                set GOOS=windows                                                                                set GOPATH=C:\Users\steve\go                                                                                set GOPRIVATE=                                                                                set GOPROXY=https://proxy.golang.org,direct                                                                                set GOROOT=C:\Program Files\Go                                                                                set GOSUMDB=sum.golang.org                                                                                set GOTMPDIR=                                                                                set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64                                                                                set GOVCS=                                                                                set GOVERSION=go1.19.4                                                                                set GCCGO=gccgo                                                                                set GOAMD64=v1                                                                                set AR=ar                                                                                set CC=gcc                                                                                set CXX=g++                                                                                set CGO_ENABLED=1                                                                                set GOMOD=C:\Users\steve\source\wails\notitrace-client\go.mod                                                                                set GOWORK=                                                                                set CGO_CFLAGS=-g -O2                                                                                set CGO_CPPFLAGS=                                                                                set CGO_CXXFLAGS=-g -O2                                                                                set CGO_FFLAGS=-g -O2                                                                                set CGO_LDFLAGS=-g -O2                                                                                set PKG_CONFIG=pkg-config                                                                                set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\steve\AppData\Local\Temp\go-build1598806157=/tmp/go-build -gno-record-gcc-switches

Here is a complete command line repo starting from building a new project and creating a minimal main.go file which reproduces the issue.

PS C:\Users\steve\source\compileFail> go mod tidy
go: finding module for package golang.org/x/sys/windows
go: found golang.org/x/sys/windows in golang.org/x/sys v0.3.0
PS C:\Users\steve\source\compileFail> go build
# compileFail
C:\Program Files\Go\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
 c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2614625705\000005.o: in function `_cgo_preinit_init':              \\_\_\runtime\cgo/gcc_libinit_windows.c:40: undefined reference to `__imp___iob_func'                                                            c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2614625705\000005.o: in function `x_cgo_notify_runtime_init_done': \\_\_\runtime\cgo/gcc_libinit_windows.c:105: undefined reference to `__imp___iob_func'                                                           c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2614625705\000005.o: in function `_cgo_beginthread':               \\_\_\runtime\cgo/gcc_libinit_windows.c:149: undefined reference to `__imp___iob_func'                                                           c:/program files/winlibs-x86_64-posix-seh-gcc-12.2.0-llvm-14.0.6-mingw-w64ucrt-10.0.0-r2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\steve\AppData\Local\Temp\go-link-2614625705\000006.o: in function `x_cgo_thread_start':             \\_\_\runtime\cgo/gcc_util.c:18: undefined reference to `__imp___iob_func'                                                                       collect2.exe: error: ld returned 1 exit status

Here is the go.mod file and the main.go file that causes the above error:
main.go
package main

import "C"
import (
   _ "golang.org/x/sys/windows"
)

func main(){

}

go.mod
module compileFail

go 1.19

require golang.org/x/sys v0.3.0

go env again
PS C:\Users\***\source\compileFail> go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\***\AppData\Local\go-build
set GOENV=C:\Users\***\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\***\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\***\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.19.4
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\Users\***\source\compileFail\go.mod
set GOWORK=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\***\AppData\Local\Temp\go-build109363636=/tmp/go-build -gno-record-gcc-switches

As far as how I set things up I followed the directions from go on how to set up go, and I followed the directions from MINGW on how to set that up.  I don't want to repeat that process.  But if you wish to introspect the current state I would be happy to work with you on that.  But in general people should not have to rebuild their entire environment every time they encounter such issues, there needs to be a more frictionless way to troubleshoot setups.

We're not asking for your environment to be built from scratch, just the inputs for this particular program, using the invocation given above (go build -a), where:
	-a
		force rebuilding of packages that are already up-to-date.

Ah I misunderstood I built an entirely new project and thought that would be good enough.  Turns out that doing what you asked
go build -a actually fixes the issue.
compileFail no longer fails to compile.  I can tell you that this switch you have there really needs to bubble up to the top of search results when people encounter issues like this.  Hopefully this trouble report will help that happen.
                                                                                Mode                 LastWriteTime         Length Name

-a----        12/26/2022  12:12 PM        3836812 compileFail.exe
-a----        12/26/2022  11:06 AM             61 go.mod
-a----        12/26/2022  11:06 AM            151 go.sum
-a----        12/26/2022  11:06 AM             93 main.go

In that case, it is related to #51007 and should get resolved in the next release as part of #47257
Closing as there's nothing else to do.


Sk6812rgbwfix

1. Tell us something about your changes.
sk6812rgbw bug fix and rename device to sk6812rgbw-spi
Added white_algorithm support to sk6812rgbw-spi device type
2. If this changes affect the .conf file. Please provide the changed section
"device" :
{
"name"       : "MyPi",
"type"       : "sk6812rgbw-spi",
//              "white_algorithm"       : "white_off",
"white_algorithm"       : "subtract_minimum",
"leds"       : 60,
"colorOrder" : "grb",
"output"     : "/dev/spidev0.0"
},
3. Reference a issue (optional)
Note: For further discussions use our forum: forum.hyperion-project.org

You don't include the logger but you use it, this results in a crash if you switch to debug mode with this device?

leddevices had his logger creation in parent class. You can use "_log" without creating it in you specific device

i followed the inlcudes, what a construction :)
I saw it silence


JMS Amazon SQS implementation

Requires #888
Related problem
No response
Requested feature
Specification pending

JMS deprecated until core has stabilized sufficiently, closing for later follow-up


Investigate available open source tools for calibration.

Can you add them here: https://github.com/autowarefoundation/autoware-documentation/blob/main/docs/how-to-guides/sensor-calibration.md ?

Previous issue: https://github.com/autowarefoundation/autoware.universe/issues/677

1.) SensorsCalibration toolbox v0.1
SensorsCalibration is a simple calibration toolbox and open source project, mainly used for sensor calibration in autonomous driving.
https://github.com/PJLab-ADG/SensorsCalibration
Lidar2camera:
https://github.com/PJLab-ADG/SensorsCalibration/blob/master/lidar2camera/README.md
https://github.com/PJLab-ADG/SensorsCalibration/tree/master/lidar2camera
Lidar2Lidar:
https://github.com/PJLab-ADG/SensorsCalibration/blob/master/lidar2lidar/README.md
2.) Mathworks calibration tool:
Lidar Camera Calibrator
Interactively estimate rigid transformation between lidar sensor and camera
https://in.mathworks.com/help/lidar/ug/lidar-camera-calibration.html
https://in.mathworks.com/help/lidar/ref/lidarcameracalibrator-app.html

@raminterpl Thank you for invetigation.
Could you create PR to https://github.com/autowarefoundation/autoware-documentation/blob/main/docs/how-to-guides/calibrating-your-sensors.md to share the results in the documentation?
Once that is done, we can close this issue.

Looks like there is already a PR so we can close the issue.
https://github.com/autowarefoundation/autoware-documentation/pull/173#pullrequestreview-1073609330


feat: Poor man's CLI block explorer

Adds a command line block explorer in the CLI via a new get-block command, with an optional --follow for streaming new blocks. Required adding a new call to the PXE to return a contract artifact (as opposed to a class) and a new note filter to retrieve notes by nullifier.
Block 1 (0x2b89265d2de0519612c4a9efa8972cd2c4afccd12264e9ce299730ce0a0766bc)
 Total fees: 210250112
 Fee per gas unit: DA=1 L2=1
 Coinbase: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
 Fee recipient: 0x0000000000000000000000000000000000000000000000000000000000000000
 Timestamp: Thu Jan 01 1970 01:00:00 GMT+0100 (Greenwich Mean Time)

Tx 28a4883a47c7a12cc7479dab2936f05ed6b3ddce69f46fcd5203366206a29221
 Status: success (OK)
 Fee: 210250112
 Logs:
  ContractClassRegisterer<0x077649ac726c10e628e99c5f2a35fdee1fbdc171cde6fba64ca8985ca35f9045>: 0x000000006999d1e02b08a447a463563453cb36919c9dd7150336fc7c4d2b52f81428d8e644ec87bb40301ac06cb69d6884e063109dc422ae2a13dcd22402ebf5000000000000000000000000000000000000000000000000000000000000000110b77dfc4f54289b862f5260efb46d933935ba56188fd516d0dd472b6ca0391515d28cad4c0736decea8997cb324cf0a0e0602f4d74472cd977bce2c8dd9923f00000000000000000000000000000000000000000000000000000000000064010000000002d11c1929000016da1f8b08000000000002ffed9ddb6f2cc95dc77b003c37db63b78f3dbe8f2fe3cbd8e3dbd833e3f16d7c7c7cbc67b311122b101200e2011e36c99220028b96041424081152de7840fc01f04c1490108a16d02a820048ab65414428e415912790f2020fac907880fefd7e55bf5f5775cfe91f0d7100b2512ccd39d5d5dfcfaf2edd5d555d555db51b9402fc1bafc2bfeb81f98b8e00c68330a844ff8dc1ef36b0aec801bf421814ac570b4e0245aec83f28b60c100094d0558cfe29a30bc2aba0ab0ce1a0ab02ff6c47ff84038ecaae8d1984134c00b66ccc26023e3109ffb46c8c26461163690444686c14514c234a982c70559200f12b0951626242a9ab2a75634addb8525756ea0a0a9dcdba42741927175b2600dfe93ec0ccc6fb00d9a297ed05ca5a93d9c5...
  ContractInstanceDeployer<0x02f1337e8c79dd0247ccbde85241ad65ee991ae283a63479e095e51f0abbc7e3>: 0x0000000085864497636cf755ae7bde03f267ce01a520981c21c3682aaf82a6311585e564a60e6ec974bc151b62705292ebfc75c33341986a47fd9749cedb567e000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000011428d8e644ec87bb40301ac06cb69d6884e063109dc422ae2a13dcd22402ebf5000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
 Nullifiers:
  Transaction hash nullifier 0x28a4883a...9221
  Class KeyRegistryClass<0x1428d8e644ec87bb40301ac06cb69d6884e063109dc422ae2a13dcd22402ebf5> registered via nullifier 0x1744fe44...097d
  Contract KeyRegistry<0x1585e564a60e6ec974bc151b62705292ebfc75c33341986a47fd9749cedb567e> deployed via nullifier 0x2c94554f...a9c4

Block 2 (0x23229ae8b82203c7d12d69c5af8a9452c495d098d96484ce24432d4890c3a066)
 Total fees: 200011840
 Fee per gas unit: DA=1 L2=1
 Coinbase: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
 Fee recipient: 0x0000000000000000000000000000000000000000000000000000000000000000
 Timestamp: Thu Mar 20 1997 06:19:57 GMT+0000 (Greenwich Mean Time)

Tx 2fe9c0b77ce7af6f2cc309b66a15fc4eadea21eff14abc1dd06b94235cfe4055
 Status: success (OK)
 Fee: 200011840
 Created notes:
  Note type 0x00000000...f345 at SchnorrAccount
    Owner: SchnorrAccount<0x0f3a5bc7d4b298a87c1b8e2cfd065dd2294e6329324092420e9bcf3899ad862b>
    0x3024c8a955160c6765e4d118c88cd4f67099bdebdd166d292aaf16341b861959
    0x18e3c5c52a7704daa972d9b3cef34be01037aa5eccbc99f9395e17fb63dc2f4a
    0x2c59248c91ae2f96d0873c9ac05fef17065229e31eb80db4c8925cd793a2258d
 Nullifiers:
  Transaction hash nullifier 0x2fe9c0b7...4055
  Unknown nullifier 0x07d5054454752a94064c6d914a7df14ee311c6a6561b0feb1031cd4d5b3bcb2b
  Contract SchnorrAccount<0x0f3a5bc7d4b298a87c1b8e2cfd065dd2294e6329324092420e9bcf3899ad862b> initialized via nullifier 0x0b22eff4...59f3

Block 3 (0x276d4ce31d7acbf40b00efe3fe967383c75ba4e8c8024372946ab463dca8b4ba)
 Total fees: 200011840
 Fee per gas unit: DA=1 L2=1
 Coinbase: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
 Fee recipient: 0x0000000000000000000000000000000000000000000000000000000000000000
 Timestamp: Thu Mar 20 1997 06:34:58 GMT+0000 (Greenwich Mean Time)

Tx 239fdac7d4dd6fd2871c2c78506f6915272acc0d6c518367b2695c3576d18047
 Status: success (OK)
 Fee: 200011840
 Created notes:
  Note type 0x00000000...f345 at SchnorrAccount
    Owner: SchnorrAccount<0x208c952a5a8caa6f0e3c9c9a2b5588e84df882a632be92ed14ed4ba3a6cb4889>
    0x20dce8a520f3d85c3c1814e11f49c1ddd5ed8795779b56ce24d04795672ea19c
    0x160ef84102b88050fdc3b5d26b4fd5552401dd1e7766428e460e8419479774c1
    0x1f22cd5b4123dccdf6bac0a135248dbbb1481fb0ecd1d86e288db71314f82bdb
 Nullifiers:
  Transaction hash nullifier 0x239fdac7...8047
  Unknown nullifier 0x20c4572a23676aeb43ff381d6f09badbbaf958426cb999946fa5a9490d0bcbf2
  Contract SchnorrAccount<0x208c952a5a8caa6f0e3c9c9a2b5588e84df882a632be92ed14ed4ba3a6cb4889> initialized via nullifier 0x17441328...4ace

Block 4 (0x1e86e3f40cc9bd904229f12aaeb0f5ccb1ed2b4cd5ef82e665075f42ce2ddea2)
 Total fees: 200011328
 Fee per gas unit: DA=1 L2=1
 Coinbase: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
 Fee recipient: 0x0000000000000000000000000000000000000000000000000000000000000000
 Timestamp: Thu Mar 20 1997 06:36:22 GMT+0000 (Greenwich Mean Time)

Tx 1935e158e53f92ee28fbb6a44d544aa6409151745888d07eb435c9adf0b6fa74
 Status: success (OK)
 Fee: 200011328
 Created notes:
  Note type 0x00000000...d345 at Counter
    Owner: SchnorrAccount<0x208c952a5a8caa6f0e3c9c9a2b5588e84df882a632be92ed14ed4ba3a6cb4889>
    0x0000000000000000000000000000000000000000000000000000000000000014
    0x1f22cd5b4123dccdf6bac0a135248dbbb1481fb0ecd1d86e288db71314f82bdb
    0x24bc453d236efaa0af7978fc40d1d32d5ad04514393686195a2592a897842352
 Nullifiers:
  Transaction hash nullifier 0x1935e158...fa74
  Contract Counter<0x2a0e4a235aa1c517e04a41bc558688e5d0fbe659bdd0e2187625ba135b0ed147> initialized via nullifier 0x2d14862d...e6fb

Block 5 (0x28c6453635fe3e6192434b82ea5b704a553b9bb983ffa8eb0634226cbec388a5)
 Total fees: 210299762
 Fee per gas unit: DA=1 L2=1
 Coinbase: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
 Fee recipient: 0x0000000000000000000000000000000000000000000000000000000000000000
 Timestamp: Thu Mar 20 1997 06:36:44 GMT+0000 (Greenwich Mean Time)

Tx 026ee6d9880d1fb58835ce759cc86b911b28f3d402a589d4b3a5aac15e7c22b5
 Status: success (OK)
 Fee: 210299762
 Logs:
  ContractClassRegisterer<0x077649ac726c10e628e99c5f2a35fdee1fbdc171cde6fba64ca8985ca35f9045>: 0x000000006999d1e02b08a447a463563453cb36919c9dd7150336fc7c4d2b52f801222ccbfa5e4da8aa941f05b44fdb6f9e243570a4133c17131d429a128bc35500000000000000000000000000000000000000000000000000000000000000010af070de86150b457bacbaa2d68104f1f76b746e2d57a67d9064a2939da2fd050488114b880887348c50fbaeebde008bfca23238238be04c262ea0fd4d050bf8000000000000000000000000000000000000000000000000000000000000d0b900000000121076393200000b711f8b08000000000002ffe59b5b5714cb15c7bb00a7bb079111af208a8cb4d0721310111418042f2883c3c5837251514611e12c004fcc3ac7246be5cbe4fbe4210f79c8433e409ef29cd7a4f7ae5db56777cf380095ce3aae9c7566ad61aa77ff7fb5ebb2ebd2354cbfe33bf83a11c0df1e875e00f1d509a7ddc9c71f3978971c9d8a13f076db1d579b22b809944ac576c78b0800707c4c799027a6c05ffe5afca73065dc463a57a75f970772775a1c73d9627400bea52e6fa9f32c7581a5ceb5d0e96676e386f0ff8297809ec01434654ba4d9001332ab56172f41d38a844b57aea52eb0d47996babca5ceb7d4e51a05432b370062ab69ec164b9d6fa9cb5bea3c4b5d60a9732d740d82e624a64e82cc04cd490099559b6a6cd0b421e1d2956ba90b2c759ea5...
  ContractInstanceDeployer<0x02f1337e8c79dd0247ccbde85241ad65ee991ae283a63479e095e51f0abbc7e3>: 0x0000000085864497636cf755ae7bde03f267ce01a520981c21c3682aaf82a631060cfd1d7e084707f9dbff1e91e5ff25f42a96eda32c3efa7857a9c245ad349800000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000ba4a4a01222ccbfa5e4da8aa941f05b44fdb6f9e243570a4133c17131d429a128bc3550f1c0b89cacad7f894b03f2df0fe34f90017b30e7a20788abf1c6eb1fc28072f00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
 Public data writes:
  Leaf 0x01274dce5f5b02dff31e464a12626bcce1311ec716b070179739f8a1ca7c9261 = 0x000000000000000000000000000000000000000000000000000000000000dead
  Leaf 0x071ca21d4cb06c55f09e4a686a9d108b942856a2582c73c0d43e09f8d038a756 = 0x0000000000000000000000000000000000000000000000000000000000000006
  Leaf 0x08a8ceb0fdeb27b3f98234d8603541f95306dae8ab15d4ace52357fe4d11f90a = 0x0000000000000000000000000000000000000000000000000000000000000001
  Leaf 0x0d234845ac847cb60b73201db97c6e8675d52d72adc69581aa5914fc11a0ed7c = 0x000000000000000000000000000000000000000000000000000000000000dead
  Leaf 0x0fc858ef91c153285fbc819e98b1c31b55ed5cd074eaf55605b071f3ccd4e145 = 0x0042414e414e4100000000000000000000000000000000000000000000000000
  Leaf 0x16008cf0f0385284517082f9728e372bcf1df56d725d16b73bae4a5a0c0506ce = 0x0042414e414e4100000000000000000000000000000000000000000000000000
  Leaf 0x1cc9f461a515b0b2754d9e249bb97fe69c1a62d423df9293336c978685612dbc = 0x000000000000000000000000000000000000000000000000000000000000dead
  Leaf 0x1d11db8907a98c978972653ddc4171a238495b048d3af7497211e53f18bc60c6 = 0x208c952a5a8caa6f0e3c9c9a2b5588e84df882a632be92ed14ed4ba3a6cb4889
 Nullifiers:
  Transaction hash nullifier 0x026ee6d9...22b5
  Class TokenClass<0x01222ccbfa5e4da8aa941f05b44fdb6f9e243570a4133c17131d429a128bc355> registered via nullifier 0x00419c0d...1e71
  Contract Token<0x060cfd1d7e084707f9dbff1e91e5ff25f42a96eda32c3efa7857a9c245ad3498> deployed via nullifier 0x2172e4eb...48b8
  Contract Token<0x060cfd1d7e084707f9dbff1e91e5ff25f42a96eda32c3efa7857a9c245ad3498> initialized via nullifier 0x3056b711...adce
Block 5 (0x28c6453635fe3e6192434b82ea5b704a553b9bb983ffa8eb0634226cbec388a5)
 Total fees: 210299762
 Fee per gas unit: DA=1 L2=1
 Coinbase: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
 Fee recipient: 0x0000000000000000000000000000000000000000000000000000000000000000
 Timestamp: Thu Mar 20 1997 06:36:44 GMT+0000 (Greenwich Mean Time)

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,760 (+1%)
1,566 (+1%)
708
776 (+3%)
780 (+1%)

proof_construction_time_sha256_30_ms
11,989 (+2%)
3,188 (+2%)
1,409
1,423
1,465

proof_construction_time_sha256_100_ms
45,321 (+2%)
12,140 (+1%)
5,659
5,564
5,510

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0
58.0
89.0 (+2%)

proof_construction_time_poseidon_hash_30_ms
1,528 (+1%)
420 (+1%)
199 (-1%)
233 (-1%)
271 (+1%)

proof_construction_time_poseidon_hash_100_ms
5,804 (+1%)
1,586 (+1%)
730
773
801 (+2%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412

l1_rollup_calldata_gas
9,464
9,452

l1_rollup_execution_gas
610,285
610,273

l2_block_processing_time_in_ms
693
1,282 (-1%)

l2_block_building_time_in_ms
22,578 (+1%)
46,349 (+1%)

l2_block_rollup_simulation_time_in_ms
22,460 (+1%)
45,977 (+1%)

l2_block_public_tx_process_time_in_ms
19,280 (+1%)
42,527 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
5,891 (-1%)
8,435 (-1%)

node_database_size_in_bytes
9,523,280
12,763,216

pxe_database_size_in_bytes
9,242
15,127

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
proving_time_in_ms
input_size_in_bytes
output_size_in_bytes
proof_size_in_bytes
num_public_inputs
size_in_gates

private-kernel-init
134
514 (+11%)
12,559 (-7%)
20,634
64,614
89,536
2,731
524,288

private-kernel-inner
407 (+4%)
936 (-15%)
52,534 (+7%)
92,326
64,614
89,536
2,731
2,097,152

private-kernel-tail
373 (+2%)
1,932 (+8%)
42,319 (-6%)
96,545
68,261
11,648
297
2,097,152

base-parity
6.51 (+2%)
1,649 (-1%)
2,638
128
64.0
2,208
2.00
131,072

root-parity
49.3 (+1%)
59.5 (-7%)
40,090 (-4%)
27,100
64.0
2,720
18.0
2,097,152

base-rollup
5,990 (-9%)
2,403 (+1%)
83,931 (+4%)
119,738
756
3,648
47.0
4,194,304

root-rollup
109 (-1%)
73.8 (-4%)
22,859 (-2%)
25,309
620
3,456
41.0
1,048,576

public-kernel-app-logic
576 (+1%)
3,471
44,266
108,073
86,550
116,768
3,582
2,097,152

public-kernel-tail
1,147 (+1%)
24,268 (+1%)
176,518
403,238
7,646
11,648
297
8,388,608

private-kernel-reset-small
592 (+1%)
1,934
47,949 (+3%)
120,737
64,614
89,536
2,731
2,097,152

public-kernel-setup
661 (-2%)
2,747 (+2%)
44,311 (+3%)
108,073
86,550
116,768
3,582
2,097,152

public-kernel-teardown
565
3,583 (+3%)
46,643 (+7%)
108,073
86,550
116,768
3,582
2,097,152

merge-rollup
29.5 (+2%)
N/A
N/A
16,542
756
N/A
N/A
N/A

private-kernel-tail-to-public
N/A
6,731 (-1%)
54,791 (+3%)
N/A
N/A
116,768
3,582
2,097,152

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms
proof_size_in_bytes
proving_time_in_ms
size_in_gates
num_public_inputs

ContractClassRegisterer:register
1,344
9,944
458
N/A
N/A
N/A
N/A

ContractInstanceDeployer:deploy
1,408
9,944
41.1 (+2%)
N/A
N/A
N/A
N/A

MultiCallEntrypoint:entrypoint
1,920
9,944
1,753
N/A
N/A
N/A
N/A

SchnorrAccount:constructor
1,312
9,944
1,420
N/A
N/A
N/A
N/A

SchnorrAccount:entrypoint
2,304
9,944
2,812
16,768
57,150 (+7%)
2,097,152
457

Token:privately_mint_private_note
1,280
9,944
1,548 (-1%)
N/A
N/A
N/A
N/A

FPC:fee_entrypoint_public
1,344
9,944
1,022 (-1%)
16,768
11,660 (+8%)
524,288
457

Token:transfer
1,376
9,944
5,275 (-1%)
16,768
56,285 (+6%)
2,097,152
457

Benchmarking:create_note
1,344
9,944
1,400 (+1%)
N/A
N/A
N/A
N/A

SchnorrAccount:spend_private_authwit
1,280
9,944
76.7 (-8%)
N/A
N/A
N/A
N/A

Token:unshield
1,376
9,944
3,888 (-3%)
N/A
N/A
N/A
N/A

FPC:fee_entrypoint_private
1,376
9,944
4,769 (-3%)
N/A
N/A
N/A
N/A

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.4
16.8
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.7
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.603
0.516
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.4
75.8 (-1%)
133 (-1%)
246
472 (-1%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
288
543
1,055
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.495
0.467 (-1%)
0.455 (-1%)
0.446 (-1%)
0.441 (-1%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
58.2 (-2%)
112 (-2%)
184 (-1%)
350 (-2%)
627 (-10%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
107 (-1%)
208
355
686 (-1%)
1,263 (-7%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.502
0.502 (-2%)
0.487 (-1%)
0.479 (-1%)
0.468 (-3%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
58.6 (-2%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
101 (-2%)

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.548

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
79,470
665,267

Transaction size based on fee payment method
| Metric |  |
| - |  |


Ensure state parameter is round-tripped correctly

See:

https://openid.net/specs/openid-connect-core-1_0.html

[ ] <IP_ADDRESS>
[ ] <IP_ADDRESS>
[ ] <IP_ADDRESS>

Closed in https://github.com/hypo-sh/emissary/pull/26


continue sketching the system

This PR is against an old commit in the sketch branch -- that's why it can't be merged immediately. If we agree with the design direction being postulated, I'm happy to rebase.

Initial spike for a configuration DSL.
Introduce the concept of a ProtocolBinding, which returns a future to a controller object for that protocol (can also be Void).
SecureChannel and StreamMuxer are both specialised versions of ProtocolBinding, returning a SecureSession (which exposes identity information) and MuxerSession (which provides capabilities to open/close/manage streams).
Add an AddressBook interface.
Start modelling a Connection class, which wraps a Channel representing the connection, and provides accessors for capabilities (muxing and secure channel), so far.
Sketch out the Transport interface and the logic for listening and dialling.

@nashatyrev thanks for the review. I’m ok to merge this, I just don’t have bandwidth to fix the conflicts. Do you have any spare cycles? Thanks!

Merged this into sketch, but this item is still outstanding: https://github.com/raulk/jvm-libp2p-minimal/pull/11#discussion_r300441913.


feat(config): only warn while experiments.newSplitChunks being explicitly setted

Summary
Fix https://github.com/web-infra-dev/rspack/pull/4169#issuecomment-1715039630

Test Plan

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

LGTM


version 0.3.26

@aaustin
Changes in v0.3.26:

Updating Branch to Android version 2.13.1

@aaustin I merged by myself, just upload new version on s3

done!


Adding recipe to conda-forge

I am adding a recipe for kazoo to conda-forge, a community-run build system for binary conda packages, here.
If there is someone who maintains this project that should be listed as maintainer, please let me know.  After this has been merged it will be possible to install kazoo through conda with the following command
conda install -c conda-forge kazoo

This is totally an aside, and just some context for you based on my personal experience at my day job. Please do not take this in any way as an official position of the kazoo team, despite my collaborator badge here.
I noticed you're doing this to ultimately support pykafka's BalancedConsumer.
My day job includes being the in-house Kafka resource at a python shop that is currently running production services that rely on pykafka's BalancedConsumer as well as kafka-python's SimpleConsumer and KafkaConsumer.
Based on that production experience, I would strongly encourage you to only use Kafka Consumer implementations that leverage Kafka's native group membership APIs and avoid any that rely on Zookeeper. I am in the middle of a 1.5 year project to migrate all our legacy consumers that use Zookeeper, and it is painful. So if you're starting new projects, you definitely want to start with the new style consumer groups. Currently, that means you should use either the confluent-kafka-python, pykafka's ManagedBalancedConsumer, or kafka-python's KafkaConsumer.
Also, with the full caveat that I am a collaborator on the kafka-python project, I would be cautious about using pykafka...  it's a smooth API that feels very pythonic, but both https://github.com/Parsely/pykafka/issues/696#issuecomment-320790952 and https://github.com/Parsely/pykafka/issues/354#issuecomment-211508480 resulted in production emergencies for us. At the the time we hit those, I didn't know much about any of the python kafka libraries and was trying to decide which library to contribute to. However, when I looked at trying to fix those issues, they were non-trivial fixes that required reworking core pieces of the library. Plus encountering https://github.com/Parsely/pykafka/issues/697 while debugging wasn't exactly confidence inspiring. So personally I just decided it wasn't the library for me, at least given it's current design. That said, @emmet9001 is extremely responsive and easy to work with--I'm sure he's a great guy, and would quickly fix both issues if he had more time.
Anyway, just some thoughts... I know the Kafka client library world for python is confusing, so this is what I wish someone had told me when I was asked to come up to speed on Kafka...

Hi,
Thanks for the information. I guess you can add @python-zk/maintainers as maintainers.


Calculate topological invariants to facilitate topological material analysis.

In recent years, topological materials science is great revolutionary progress in the field of materials science, which is closely related to group theory, in which, a typical representative emerging discipline is Topological Quantum Chemistry. So, add some related features are also intriguing.
Related literature and studies:
https://doi.org/10.1038/nature23268
https://doi.org/10.1103/PhysRevB.102.115117
Regards,
Zhao

That sounds so interesting applications of irreps and this package!
Although I don't know the details about the field, it seems a symmetry indicator is calculated after obtaining corresponding irreps.
So such a calculation will be done outside this package as a post process.

The symmetry indicator, according to my superficial understanding, is just some sort of topological invariants. But, objectively speaking, I am a layman in this field.


Why doesn't subscribe dispatch the current state?

I'm working on integrating redux into a project, and I'm setting up all of my view components (not using React here) to get passed the state and render/update themselves based on it. I know this is a fairly minor issue, but I'd like to know why the state object isn't passed an argument to the subscribe callback.
For example, what I'd like to do is this:
const store = createStore(reducer, state);
store.subscribe(view.render);

But what I have to do is this:
const store = createStore(reducer, state);
store.subscribe(() => {
    view.render(store.getState());
});

Is there a reason for this?

This has been discussed previously:
#1513
#303
TL;DR: Being notified that a store has changed is orthogonal to getting the current state. Read the above referenced issues for more details.

Fair enough, thanks for pointing me in the right direction.

FWIW we can finally allow this after #1702 because store enhancers are exposed to a subset of API without subscribe.


last(), first() commands print wrong date

from cli, they all seem to print epoch value.
centos 6.6 - latest download

time
last

1970-01-01T00:00:00Z
6.887297e+06

time
first

1970-01-01T00:00:00Z
0

This is documented behavior: https://influxdb.com/docs/v0.9/query_language/aggregate_functions.html
The issue to address this is https://github.com/influxdb/influxdb/issues/1577.

i see similarity with #3079 but still quite can't make connection with documented behavior.
can someone post a query to get latest value and time of it from a series?
(that's because last() cannot be used with a 'group by')

@biskit what you're asking for is in #1577, not yet implemented. There is no query (yet) that will return the actual timestamp of a point if there is a function in the SELECT clause.


Fix typo on filesystem.mdx

Nothing fancy. Just fixing a typo.

Hi @Meta502 thanks for fixing another typo and merging the PR :partying_face:


New feature to loosen Set function check semantics

Issue https://github.com/microsoft/Power-Fx/issues/1764.
New feature: PowerFxV1AllowSetExpandedTypes

✅ No public API change.


fix(@angular-devkit/build-angular): support writing large Webpack stat output

When using the statsJson browser builder option, the resulting JSON data is now streamed into a file instead of written in one large block.  This mitigates crashes due to the generated string exceeded the Node.js limit.
Fixes #20271

@clydin this doesn't apply cleanly on the patch branch.


Prevent send with D-pad center button whatsapp

For some context I have a Qin F21 pro, touch screen and keypad.
Is there a way you can add an option to prevent sending messages by hitting the center d-pad button?
This mostly concerns whatsapp, I often send messages by mistake whilst typing when I want to select punctuation, so I hit the d-pad center button, but somehow I hit it twice, or the app has already selected the character so I send up sending the unfinished message. I would prefer to send my messages with the touchscreen send button in the whatsapp UI.
Thanks for the great work, I really appreciate this app.

There is a Whatsapp settings for it. See how to configure ENTER.


Update log formatting

Add a new --raw-logs flag to disable coloring and fancy formatting
Make logrus always disable the timestamp instead of the delta since execution start

Closes #466

@mlaventure Is there a bug in logrus preventing it from detecting the tty?

It probably has more to do in the way they are starting docker making logrus assume there's a tty

It probably has more to do in the way they are starting docker making logrus assume there's a tty

Here is the volume of tty-related bug in logrus:
https://github.com/sirupsen/logrus/issues/466
https://github.com/sirupsen/logrus/issues/456
https://github.com/sirupsen/logrus/issues/431
https://github.com/sirupsen/logrus/issues/379
Based on that, I think something is wrong with the detection.
Detecting a TTY is not rocket science (closer to alchemy). I'd rather we fix the issues in logrus than add a flag to workaround it.


Fix auto-filling of coordinates for multiple street numbers

Short description
Easiest fix would be to only use the first street number for latitude and longitude / API-Call to Nominatim.
Resolved issues
Fixes: #1579

@DaRuOrg
Hi, how's it going?
Feel free to comment here if you have any problem, question or difficulties 🙂


chore: jx-k8s-days-go-01 to 0.0.6

chore: Promote jx-k8s-days-go-01 to version 0.0.6

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Converted unified add layers to use new API.

What does this PR do?
No longer searching both the Registry instance
and GeoNode. It will now only search using the
/api/base/search endpoint.
Screenshot
No changes in visual presentation.
Related Issue
NODE-759, NODE-760, NODE-763

@theduckylittle Is category filtering supported?

This is passing category__in to the search API and I do not get any responses from registry when I search using category.  I am not sure if registry layers are correctly being given categories but that would be a bug in the API and not MapLoom.

This is the relevant line of code: https://github.com/boundlessgeo/MapLoom/pull/69/files#diff-bf51fd952b13e52184d58caa03a08502R475

Just tested against the latest version of the API with geogig fixes and all is well.

NODE-719 is also affected.


[WIP] Comonadic extend for Optional

I'm not quite sure that what I've done makes any sense, but I was reading about the Comonad typeclass in Haskell, and thought I could bring the extend :: (w a -> b ) -> w a -> w b operator to Runes.
I wanted to open this to gauge interest, and indeed see if what I'm doing even makes sense... I implemented extend for optionals and checked that it obeyed the law extend f = fmap f . duplicate, where duplicate is the dual of monadic join.

Cool stuff.
Few general thoughts:
Is this really useful in Swift? Given the fact that Swift implicitly wraps non-optionals in .Some when passing them as optional arguments, I don't really see the need (for optionals) to have this re-wrapping behavior.
If we did add this in, it would be nice to implement all of Comonad, instead of just part of it. That's why we added pure to Runes, because it was weird to only implement 1/2 of Applicative and Monad.

Ah, perhaps this isn't so useful then! We can't implement all of Comonad because Optional isn't a comonad; in particular extract :: w a -> a doesn't make sense for .None values.
I could implement extend for the Array type:
public func <<-<T,U>(f: [T] -> U, a: [T]) -> [U] {
 return [f(a)]
}

But again, probably not so useful, and there's obviously no choice for a canonical implementation of extract :: w a -> a. :cry:


[AIRFLOW-YYY][depends on AIRFLOW-6047] Add StackdriverLoggingHandler

Make sure you have checked all steps below.
Jira

[ ] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does
If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@da08666). Click here to learn what that means.
The diff coverage is 80.48%.

@@            Coverage Diff            @@
##             master     #478   +/-   ##
=========================================
  Coverage          ?   83.48%
=========================================
  Files             ?      670
  Lines             ?    37644
  Branches          ?        0
=========================================
  Hits              ?    31427
  Misses            ?     6217
  Partials          ?        0

Impacted Files
Coverage Δ

airflow/config_templates/airflow_local_settings.py
60% <37.5%> (ø)

airflow/example_dags/example_bash_operator.py
94.44% <80%> (ø)

airflow/utils/log/stackdriver_task_handler.py
96.55% <96.51%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da08666...e2511a7. Read the comment docs.


[ORM] Database field names are not guarded against ORM method clashes

Consider this:
<?php
class book extends DataObject {

	private static $db = array(
		"Show" => "Boolean",
		"Delete" => "Boolean"
	);

	private static $summary_fields = array (
		"Delete" => "Delete",
		"Show" => "Show"
	);

}

Each time the administration is reloaded, the data for that model is removed from the database.
This removed more than 300 documents from my database.
This is because SilverStripe calls the Delete() method in $summary_fields
Which in this case is a very very sensitive method.
In some cases, this little trick of SilverStripe can go very fast and save lives.
But destroys data now. And it took me 48 hours and  think that I was attacking, siphoning ...
For example, you can update the Delete method of the DataObject model to:
function delete ($now = false) {
    If ($now) {
      $this->brokenOnDelete = true;
       $ this->onBeforeDelete();
   }
 }

So to call the Delete method, $now must take true, so that the data is deleted.
cordially

Alright, so what we need is a better check for reserved keys for properties, similar to how we do for form actions. What you would expect is that framework would crash with a "Invalid property name" error right?

I suggest to put the fix in DataObject::db() method (or DataObjectSchema::fieldSpec method in 4.x).
To improve performance, maybe the check should only be in dev mode.

The cause of this is that GridField@getDataFieldValue calls $record->$fieldName(), which it probably shouldn't do - it should stick to getting DB values not invoking methods.
I think reserving all method names from being DB names is a bit much and surely we'd have to also reserve all the controller methods and all methods on the class hierarchy of both model and controllers too? Oh and decorators, then any GlobalTemplateProviders and so on, which all seems unnecessary and impractical.
What happens if I add a method later with the same name or I install a new module which causes a clash? Who's wrong, the method or the DB field?
Brutally honest mode engaged:

Naming a field "Delete" or "Write" or any word that's such a core part of the Model's API is going to cause problems
This would come up pretty quickly in testing and deleting 300 rows from a test DB shouldn't be a big deal

if you didn't test, then your backups will be useful here
if you didn't back up then you're just scapegoating the framework for the fact you didn't put in any safeguards against you deploying untested code.

What scenario is it even needed to store a boolean on an object called "delete"?

Does this imply that destructive methods like delete can be triggered with a GET request?

Is https://github.com/silverstripe/silverstripe-framework/pull/9549 a reasonable solution @dhensby ?


Repo sync for protected CLA branch

The pull request is created from master637328494110526876 to master to fix git push error for protected CLA branch

@cmcclister : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add support for DML and Partitioned DML

Note: DML and partitioned DML are not yet publicly available in the Spanner API.

Hello, is there any benchmark result that compares query using DML or not?

Hi @axot, do you mean a benchmark comparing updates using DML vs using a Mutation, or are you wondering about DML updates vs SQL reads?

Hi @jdpedrie , we are interested in both latency and throughput(QPS) comparing use of DML vs a Mutation commit. It makes sense of latency deterioration from your explanation. Thank you for working hard of this and I'm glad for any information from spanner team.

Hi @axot, I heard back from the spanner team. I don't have any specific benchmarks to share, but they do say that, due to the Read Your Writes nature of DML, it will be somewhat slower than using the mutation API.
You should weight the benefits of speed vs. being able to see changes made via DML within your transaction when choosing which strategy to use.
Hope this helps!

Thank you for the information, we will perform a benchmark to see how latency and throughput changes in the next week.


"#ifnd" expands to "##ifndef" isntead of "#ifndef" with luasnip and friendly-snippets

Make sure you have done the following

[X] I have updated to the latest version of blink.cmp
[X] I have read the README

Bug Description
Every snippet with name AND body that starts with "#" expands to "##smth" instead of "#something", also "#" symbol does not trigger menu (I am using defalult config for everything except keymaps and snippets sections)
This problem happens even with custom lua snippets
Relevant configuration
No response
neovim version
0.10.2
blink.cmp version: branch, tag, or commit
ae5aa4ce

Duplicate of #46


Fix bank account confirmation page confirm button is too close to the bottom

Details

There are some confirm button at confirmation steps on bank account page that is too close at the bottom because we don't include safe area padding bottom.
Fixed Issues

$ https://github.com/Expensify/App/issues/37339
PROPOSAL: https://github.com/Expensify/App/issues/37339#issuecomment-1975240020
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open a workspace bank account page
Go to 1st & 2nd confirmation page
Verify the confirm button in each page isn't too close at the bottom
Go to the 5th step
Select yes for both sub-steps
Complete the personal information until you arrive at the confirmation page
Verify the confirm button in each page isn't too close at the bottom
Press confirm
Select no for "Are there more individuals who own 25% or more" and go next
Verify the confirm button in each page isn't too close at the bottom

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Sorry, I pushed a wrong commit, so I force pushed to remove it.

Conflicts solved.

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fire when scrolling up rapidly to the top of the page

Hi @carlsednaoui,
could you please take a look at this pull request? It's implementing the feature requested in #74, which has been renewed in #84 and also addresses the needs of our own clients at Darwin Pricing. @kevinweber @roblb for your information:
The popup will be fired whenever someone scrolls back rapidly to the top of the page, which is the best guess you can make about someone's willingness to leave the site on touch devices.
I'm not looking at whether we are actually on a touch device, because there are more and more hybrid devices like desktop computers with both a mouse/trackpad and a touch screen.
The change set is the following:

I've introduced a configuration parameter scrollSpeed, set to 1000 pixels per second by default. This scrolling speed is the threshold to trigger the popup whenever the user scrolls back to the top of the page.
I've refactored a bit the delayed firing of the popup as well as its abortion by introducing two functions for that.
I've aborted the delayed firing whenever the user moves the mouse on the page. I've replaced the mouseenter event by mousemove for this purpose.
I've aborted the delayed firing whenever the user types something (excepted this Meta-L combination which was triggering it, although I don't know whether this really makes sense...)
I'm sampling lazily (i.e. only upon scrolling) the scrolling position in 10 ms steps
I'm firing the popup with the usual delay whenever the user scrolls to the top of the page at a scrolling speed above threshold. I'm using window.scrollY <= 0 because some browsers use negative offsets while they render a bounce animation when the user scrolls back to the top of the page.
I've increased the height of the test page so that one can scroll properly there.

I'm not sure how to run the test suite, so I haven't added a unit test for that. Feel free to do it if you have some slack!
It would be great if you could review and discuss this pull request in the next few days!

sebastien-fauvel/ouibounce@aa75c10

Hi @sebastien-fauvel, thanks for spending the time implementing this for your client — and for sending a PR through. As mentioned in #74 I personally don't like this behavior (more details here).
Not sure what the best way to proceed is, but I'd like ouibounce to keep it's focus on someone bouncing, not for rapid scrolling.

Hi Carl,
thanks for looking into it! I had already read about your concerns in the original issue, and I think I've addressed them, at least on clients with a mouse/trackpad, by aborting the delayed firing whenever the mouse moves on the page. If you scroll to reach the navigation bar and go to another section, you will probably move the mouse pointer before the end of the firing delay – at least if you have a sensible one, say, 500ms?  With a firing delay of, say, 2 seconds, we could avoid firing too early, too. What do you think? Should we add a separate configuration variable delayScroll with a reasonable default (2000ms) to handle that, or some configuration flag trackScroll set to false by default? Would it make sense to you? I mean, your current solution (firing when the mouse leaves the page, aborting when it moves onto the page again) is not perfect either, it only works fine when the firing delay is adjusted properly – because you also cross the top of the page with the mouse from time to time when you want to use the navigation menu. Isn't this quite the same issue? Also I thought you wanted to implement an open-source replacement for BounceExchange, and they do track scrolling, too...
Anyway, let me know what you think – I'll start a sister project if you want to drop this feature at all costs :)

Was this never implemented? Seems useful.
Can anyone suggest a similar tool that's mobile-friendly?


[SPARK-47122][INFRA] Pin buf-setup-action to v1.29.0

What changes were proposed in this pull request?
This PR aims to pin bug-setup-action to v1.29.0.
Why are the changes needed?
To recover the broken CIs due to the latest v1.29.0-1 issue.

https://github.com/apache/spark/actions/runs/7995430821/job/21835769202

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs on this PR. It passed already.

https://github.com/dongjoon-hyun/spark/actions/runs/7995539640/job/21836175997

Was this patch authored or co-authored using generative AI tooling?
No.

Hi, @huaxingao .
Could you review this CI hotfix infra PR?


Recent build of PlantUML breaks genealogy

Apparently nested together statements are broken. Unclear who to point the finger to.
https://github.com/plantuml/plantuml/issues/1282

The original issue is apparently solved, but I doubt this is how the example is supposed to look like:

Yes, unfortunately I've long given up on this solution.


Environment Variable $HOME not being recognized in .env file when setting PYTHONPATH

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.68.1
OS Version: Ubuntu 20.04

Steps to Reproduce:
mkdir python-test && cd python-test
echo "import a" >> main.py
echo "PYTHONPATH=\$HOME/python-test/external" >> .env
mkdir external && cd external
touch a.so

open python-test folder with vscode, click main.py, click F5, we get an error
Exception has occurred: ModuleNotFoundError
No module named 'a'

However, if I update .env to PYTHONPATH=/home/jasjuang/python-test/external, I get the expected error
Exception has occurred: ImportError
/home/jasjuang/python-test/external/a.so: file too short

This seems to indicate that vscode is unable to parse the environment variable $HOME in the .env file correctly. I also observe the same problem on macOS, where vscode is unable to parse the environment variable $USER in the .env file correctly.
Is it possible to fix it so that the environment variables are parsed correctly? It would be nice to be able to share the .env file among different machines.

For environment variables in the system like USER, HOME etc., variable substitution is documented here: https://code.visualstudio.com/docs/python/environments#_variable-substitution, please try using the described syntax.

@karrtikr I saw the documentation you linked before, I tried something like PYTHONPATH=/Users/${env:USER}/python-test/external and it still doesn't work. Can you please advice?

I see

I see.

click main.py, click F5

As you're using debugging I'm transferring over your issue to debupy.


[BugFix] Add lock for write insert overwrite edit log and optimize insert overwrite gc

What type of PR is this：

[x] bugfix
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Add lock for write insert overwrite edit log and optimize insert overwrite gc
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 8 / 11 (72.73%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/InsertOverwriteJobManager.java
0
2
00.00%
[175, 176]

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
8
9
88.89%
[1080]

run starrocks_admit_test

@Mergifyio backport branch-2.4


fix: Repair view missing i18n

Add missing repair view localization entries (I didn't complete German entries though, only English and French).
Closes #260.

I can do the German ones, one sec ^^

Add German translation now ^^


Batch sampler for batching over samples and conditions

This is a first shot at batching over both samples and conditions in optimisers.svgp.fit. This is done by adding a new iterator class in optimisers.data called NeuralDataloader. Once you create a dataloader with
dataloader = NeuralDataLoader(data, batch_pool=batch_pool, sample_pool=sample_pool, batch_size=batch_size, sample_size=sample_size)

You can then iterate over the batches with
for sample_idxs, batch_idxs, batch in dataloader:
      do_somethin(sample_idxs, batch_idxs, batch)

where batch should be the same as data[sample_idxs][:,:,batch_idxs].
One of the biggest changes in this PR is that we are no longer passing the full dataset to svgplvm.elbo. Instead, we are now passing in the batch.
I've also added a two unit tests for NeuralDataLoader in test_data_sampler.py.
Should we get the user to construct the dataloader and pass it to optimisers.svgp.fit as opposed to what we are currently doing, which is directly building the dataloader inside the fit function? This will allow users to design their own data loaders. If the user is not batching it should be as simple as writing a wrapper for:
data_loader = [(None, None, data)]

Thoughts, @davindicode @KrisJensen ?
In a future PR, we should probably add a shuffle and drop_last option to NeuralDataLoader as in  torch.utils.data.DataLoader.

Yeah looks good. So what are your thoughts on batching with AR priors? Would you go for batches that overlap i.e. batch_1 contains the starting point of batch_2 so that we link the two batches together in AR(1) (otherwise there is no smoothness constraint at batch ends). This is what I have been using for batching long data

Yeah looks good. So what are your thoughts on batching with AR priors? Would you go for batches that overlap i.e. batch_1 contains the starting point of batch_2 so that we link the two batches together in AR(1) (otherwise there is no smoothness constraint at batch ends). This is what I have been using for batching long data

Currently, the "conditions" in each batch are always contiguous (unless you pass shuffle_batch=True when you initialize the data loader, a new feature in #25 ).  Batch k will also be continuous with batch k + 1 , but not overlapping. So you won't be able  to easily link them together in AR(1). However, I'm also a bit confused as to how you were able to do that previously?

@davindicode I should also mention that in the latest PR #25, users can define their own dataloader, so you will be able to batch the data set however you want. If you have a clever way of batching to make sure the boundaries between batches are taken care of in the ARP prior, it might be worth adding that to optimisers/data.py .

Yeah looks good. So what are your thoughts on batching with AR priors? Would you go for batches that overlap i.e. batch_1 contains the starting point of batch_2 so that we link the two batches together in AR(1) (otherwise there is no smoothness constraint at batch ends). This is what I have been using for batching long data

Currently, the "conditions" in each batch are always contiguous (unless you pass shuffle_batch=True when you initialize the data loader, a new feature in #25 ). Batch k will also be continuous with batch k + 1 , but not overlapping. So you won't be able to easily link them together in AR(1). However, I'm also a bit confused as to how you were able to do that previously?

one idea of how to do this would be to make the first batch of variable size \in [batch_size/2, batch_size]. Then the 'break points' between batches will be in different places for every pass through the data and it should all be tied together (this is similar to what we were doing previously).

one idea of how to do this would be to make the first batch of variable size \in [batch_size/2, batch_size]. Then the 'break points' between batches will be in different places for every pass through the data and it should all be tied together (this is similar to what we were doing previously).

nice, this should be easy to implement by inheriting from BatchDataLoader and modifying the __iter__ function to draw a different batch_size  each pass through the data.


USCore-5

This PR creates US Core v5.0.1 Test kit.
It includes

Generate US Core v5.0.1 Test Kit from IG package
Updates generator to support pattern slicing with required binding (FI-1624)
Adds Must Support test for Patient's Previous Address (FI-1627)
Supports Must Support choices between Must Support elements, extensions, slices (FI-1633)
Blocks test generator from generating QuestionnaireResponse test group (FI-1635)
Includes USCDI MustSupport tests by default (FI-1630)

The inconsistency in the naming of the Observation groups isn't great. Do you think there's a good way to make them consistent?

The inconsistency in the naming of the Observation groups isn't great. Do you think there's a good way to make them consistent?

I think I can move Observation to the front

The same title change is applied to US Core 4.0. I don't change US Core 3.1.1 since I don't want to cause any changes to the existing g10 test kit.


HTTPS support

Feature request:
The Fibaro HC2 and HC3 servers support https with a signed certificate from Fibaro.
Can you add https support (with no SSL verification) in this library and later on in the Home Assistant Fibaro Integration ?

Fibaro Home Center 3 uses a root certificate authority, two intermediate certificate authorities and a per device certificate. The per device certificate changes each month. I didn't find anything to upload an own certificate.
So there are two options:

Set verify to False which exposes the requests to man-in-the-middle attacks but is easy to do. Also this solution will log InsecureRequestWarning on each request until this is globally disabled in urllib3 library (disabling it per host is not possible). So I'm unsure if Home Assistant will accept such a solution and if such warnings in HA are already disabled.
Implement certificate validation by fingerprint. This is more secure but you need to provide the monthly changing fingerprint.

What do you think should be implemented in the library, both options? And which solution should be used in HA?
I will try to find out how the maintainer of HA think it should be done.

The integration Overkiz uses verify to flalse too with access to the Tahoma device. So there is a precedent for this.

Ok thanks, I also checked messages on HA discord channel and it seems that this option is widely used. So I will implement the ssl verify = False option.

This is integrated in Home Assistant 2023.3.0, so you should soon be able to use https as well in Home Assistant.

I have installed 2023.3.0 but the dialog hint still says http://HOST/api/* . Before I migrate my 89 devices to https I have to be sure the https is accepted in the dialog of the intergration. Is it ?

Yes https is now accepted, also in HA there is now some url fixing setup so even entering https://HOST works now. But yes the dialog text is not good anymore, I will update it if I find some time.

I have done the migration to https with success.