Backtest problem ('vsBuyHold' property is undefined

Generation's Best Results
/home/tradeops/zenbot/scripts/genetic_backtester/phenotype.js:70
var vsBuyHoldRate = (phenotype.sim.vsBuyHold / 50);
^
TypeError: Cannot read property 'vsBuyHold' of undefined

i wrote this zenbot install script to get around the above error:
`#!/bin/bash
sudo apt-get update && sudo apt-get upgrade -y
sudo apt-get install build-essential git mongodb -y
curl -sL https://deb.nodesource.com/setup_8.x | sudo -E bash -
sudo apt-get install -y nodejs
git clone https://github.com/carlos8f/zenbot.git
cd zenbot
cp conf-sample.js conf.js
npm install
cd scripts/genetic_backtester/
npm install nodejs geneticalgorithm
npm install
chmod +x phenotype.js`


log retention days is not working

Describe the bug
Setting the following properties of log_retention to true and 60 the retention days on CloudWatch console is still set to Never Expire
fluentbit:
  enabled: true
  image:
    tag: 2.28.1
  output:
    applicationLog:
      log_retention:
        enabled: true
        days: 60
    dataplaneLog:
      log_retention:
        enabled: true
        days: 60
    hostLog:
      log_retention:
        enabled: true
        days: 60

What did you expect to see?

What did you see instead?

Environment
kubernets 1.23
fluentbit 2.28.1 (i tried with 2.21.1 with the same result)
aws-otel-helm-charts 0.7.0
Have a nice day

Hey @xpicio, ADOT PM here and thanks for raising this issue. We're working on logs in OpenTelemetry upstream with the plan to support it in ADOT by mid 2023. Along with this work we will, going forward, remove support for Fluent Bit in this Helm chart. Due to this, we do not plan work on the Fluent Bit template, here.


enhance file name parsing for STAR/HISAT2

Many thanks to contributing to nf-core/rnaseq!
To ensure that your build passes, please make sure your pull request is to the dev branch rather than to master. Thank you!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist

[x ] PR is to dev rather than master
[x ] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
[x ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Make sure your code lints (nf-core lint .).
[ ] Documentation in docs is updated
[ ] CHANGELOG.md is updated
[ ] README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

Hi @orionzhou !
what was the current problem with the parsing method available? Are there some use-cases that don't work with the current regex?
Regarding your PR: Thanks for opening this - you may have to add a line to CHANGELOG.md to get this passing 👍 Would be great to hear some reasoning why this was a problem in the first place, too :-)

Currently the pipeline only recognizes file names such as "SRR123456_R1.fq.gz" and "SRR123456_R2.fq.gz";  It does not recognize "SRR123456_1.fq.gz" or "SRR123456_2.fq.gz".
In the case of "SRR123456_1.fq.gz" or "SRR123456_2.fq.gz", all hisat2/star alignment output BAM files, sorted BAMs, featureCounts/Salmon output, edgeR output/plots, Preseq / QualiMap / RSeqQC output will use prefix "SRR123456_1" rather than "SRR123456".
This patch offers a quick fix to this by identifying the correct file prefix for "SRR123456_1.fq.gz" or "SRR123456_2.fq.gz".

Can you also fix this here?

=================
  53 tests passed   2 tests had warnings   2 tests failed

WARNING: Test Warnings:
  http://nf-co.re/errors#1: File should be removed: ['.travis.yml']
  http://nf-co.re/errors#4: Config variable not found: params.single_end

ERROR: Test Failures:
  http://nf-co.re/errors#4: Config variable (incorrectly) found: params.singleEnd
  http://nf-co.re/errors#4: Config variable (incorrectly) found: params.igenomesIgnore

ERROR: Sorry, some tests failed - exiting with a non-zero error code...

While you're at it? ;-) That would make all tests pass :-)

I removed the file '.travis.yml'
Not sure what to do with the params.singleEnd or params.single_end thing - I see it is being deprecated in the newer versions, but not sure how to proceed.  Any clue?

Rename it to the new format everywhere - that’s it :)

all right.  There's still an error, any clue how to fix that?

This is the error basically: http://nf-co.re/errors#5
So I guess there is something missing in the .github/workflows/ci.yml that does not follow the above mentioned page.


GO: implement DEL command

Describe the feature
Keeping focus on adding the missing commands to the GO client
As a good first issue for people that wish to contribute to the GO client can be the implementation for the command: DEL
See command details here:
https://valkey.io/commands/del/
Use Case
Missing functionality
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Client version used
1

@MikeMwita Another one :)


HttpBook post-request script unable to share data in a useful way

When I try to save a result from a post-response script (either with exports or $global), no value seems to be saved.
repro.zip

There are a few small problems in your example.
Your example using $global is missing the point for accessing the variable ($globalgblIp to $global.gblIp)
HEAD https://api.ipify.org?gblIp={{$global.gblIp}}

The fact that the example with the use of the variable does not work has to do with the way VSCode allows access to the notebook cells. Actually, I allow implicit access to variables of other regions in the same file. However, each cell is passed by VSCode at the interface as a separate file. Thus one must currently specify the variables usage explicitly with # @ref.
# @name foo
GET https://api.ipify.org?format=json

{{
    $global.gblIp = response.parsedBody.ip
    exports.lclIp = response.parsedBody.ip
}}
###
# @ref foo
HEAD https://api.ipify.org?lclIp={{lclIp}}
...

I'll check if I can adjust the logic here to read all cells in one go.

I don't quite understand the last comment. Using the response directly was actually my intention as one should use `# @ref'.

I'm sorry - I thought your example in the previous comment was specific to files, and not books. But I see that using @ref pulls into scope the ref variable, but also pulls in any variables created by exports into the scope as well.
This isn't what I would expect, but I'm happy that it works.

@warrenb-onware Books and files are the same. I convert all notebook cells to a virtual file. Using httpbook or httpyac should provide the same output. Maybe a improvement would be to auto ref all cells of.the same file.


Feature Request: Filter by PID

Option to filter not just by process name, but by PID
useful when there are multiple instances of the same process name running

Ah,  "Options > Prefix PID" can be used to add the PID to the message text, and we can filter from there.
 never mind

yes, the actual filtering had all kinds of lifetime complications,  so that
was easiest...
On Thu, Feb 11, 2021, 18:06 Mark Goldberg<EMAIL_ADDRESS>wrote:

Ah, "Options > Prefix PID" can be used to add the PID to the message text,
and we can filter from there.
never mind
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CobaltFusion/DebugViewPP/issues/367#issuecomment-777646334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNITBGCHTJJX6FLUM252XLS6QFBNANCNFSM4XPC74FA
.


Nominate machadovilaca as sig/observability approver

What this PR does / why we need it:
Nominate João Vilaça (@machadovilaca) as sig/observability approver.
Since joined the project, João has been a key contributor to Kubevirt, especially in the observability area. He has over 60 merged PRs and more than 30 reviews.
Special notes for your reviewer
/cc @enp0s3 @sradco

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/approve

/lgtm

/hold
waiting for @enp0s3's review

/approve
/unhold
@machadovilaca :partying_face:


Add support for secrets loading from SECRET_ARN

AWS specific that could be modified to be independent
Will not attempt if no SECRET_ARN is set in ENVs

Task linked: FRI-460 Move SecretsToEnv to frigg core, add to createHandler

:rocket: PR was released in v1.2.2 :rocket:


Outline can't recognize function with (char *interface) paramater.

VSCode Version: 1.24.1
OS Version: Linux Mint 18.3 Cinnamon 64-bit, kernel 4.13.0-43-generic

Steps to Reproduce:
1.Define a function with  (char *interface) paramater, and the outline can't recognize it correctly.

2.If I change the variable name, it can recognize it.

Does this issue occur when all extensions are disabled?:
Can't open outline in this situation.

This issue was moved to Microsoft/vscode-cpptools#2159


Fixes from #1175 that are not related to protocols

Fixes a bug in the detection of class declarations introduced in #1162.
Also fixes #1179. We simply hand't included the definition of NSError yet.

Were the Dart code changes logically part of this PR?

Yeah, that class declaration bug was also affecting NSError, so I can't generate its full bindings without the fix. It's also severe enough that I don't want to wait for it to land in #1175.

coverage: 92.655% (+0.09%) from 92.563%
when pulling 71a23e47a27e372bb0d1c7395e3d730fc7b4cf4e on fixes
into 4f3e4d8d58509a9eb028f018f86b80247baf171a on main.


get charuco board pose from point_estimates

Calling it a day... Getting an appreciation of the next steps.
retval, rvec, tvec = aruco.estimatePoseBoard(corners, ids, board, camera_matrix, dist_coeffs)  # posture estimation from a diamond
This will only give relative to a single camera, which is not really what I want. May need to calculate for each possible camera, convert to a common frame of reference, and perhaps average. Otherwise just use one camera...that might make things a fair amount simpler...but then if you've got it for one it's not hard to do all...


Stop or Update Deferred Queue

Hello,
Good day! I'm still new in using your library, I just have one question. Is there a way to stop or update deferred queue?
Thanks!

Hi. What to you mean by stopping deferred queue? The worker should listen only for main queue while the deferred ones will route messages in particular time. If you want to delete deferred queue you can do it using RabbitMQ management module.

Hello,
I'm sorry for the incorrect wording. What I mean is for example, I have a job that needs to be executed(for example, 1 hr from now). With that, I need to use the delay() method. Is there a way to Purge the existing Job when I want to update the value passed to delay() method of the same Job? Let's say originally, I want to execute it 1 hr from now. Then I changed my mind, I want it to execute 10 mins from now.

Now I understand you. No, you can’t do this using Laravel Queue. The only way you can do this is using management plugin :) just purge your query. It’s the only way I think.

I see, thanks!


Is it identical to call Reconstruct() instead of Encode()?

If l always call Reconstruct([datas..., nil, nil, nil], [nil, nil, nil, parities...]) instead of call Encode(datas, parities), is it identical in both result and performance?

@TennyZhuang
In theory, yes. But need more time for searching matrix(although it's just the generator matrix) and allocating memory space.

In my opinion, the additional memory and time is O(n*m) and is not related to data, so the additional cost can be ignored for large data (such as 1GB or more), is it right?

Yes. The cost is not expensive

Thanks


es bulk question

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ √] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Question 1:
ES as storage, I found the es config was not effect, for example, I set flushInterval 120s, bu I found only after seconds the bulk had executed

So I'm doubt about the above code, why flush manually every time?
Question 2:
oap config -sampleRate, means trace sampled within one milisecond?

@peng-yongsheng Could you answer this?

Question 1:
ES as storage, I found the es config was not effect, for example, I set flushInterval 120s, bu I found only after seconds the bulk had executed

Question 2:
oap config -sampleRate, means trace sampled within one milisecond?

We have detailed document about server side sampling. https://github.com/apache/incubator-skywalking/blob/master/docs/en/setup/backend/trace-sampling.md

@peng-yongsheng Could you answer this?

Question 1:
ES as storage, I found the es config was not effect, for example, I set flushInterval 120s, bu I found only after seconds the bulk had executed

@ywf4026 Good question. This is a transaction problem. Workers will combine the data in memory with the data in db. The flow is:
ForEach memory data -> Get the same key data in memory -> combine memory and db -> into bulk process -> flush
So, if I don't flush it into db, I will get the dirty data from db next cycle. The bulk process settings are use for avoid send too many or too big size data into db, shred the sent data packet.


Info missing: opp_water

https://github.com/ArtesiaWater/nlmod/blob/ce8479333b580652150e32f006fbb5823f7944ea/nlmod/read/rws.py#L62
Requires this file to exist:
fname = os.path.join(nlmod.NLMOD_DATADIR, "opp_water.shp")
The shape file also requires several attributes to exist and have reasonal values. Can we get these directly from "basis data"?

This is an intermediate file that is created using scripts from the UGW: surface water code. The code there does attempt to build this intermediate file directly from online source data (but some offline data was still required). This was done for one region (Utrecht) in the Netherlands, with 7 water boards. Unfortunately there is no complete national standard for surface water (yet?), so there was custom code required for the online data for each water board. This might change in the future if we get a functional national database.
So for now we just want to support parsing shapefiles that contain stage info, bottom depths, bed resistance and areas, and creating that file is the users own responsibility. In the future, if we have methods that apply to the Netherlands as a whole we can include those preprocessing steps to create those shapefiles.
Perhaps we should remove this hard-coded reference to this shapefile and just define its structure.

There are two different functions for adding surface water which makes things confusing:

In nlmod.read.rws you can use get_gdf_surface_water which uses a shapefile from the data directory. This is a shapefile with all the big surface water bodies in the Netherlands (Noordzee, IJsselmeer, Markermeer). This is the one Bas mentions
In nlmod.mfpackages.surface_water there are functions to generate a river package from any geodataframe. Typically from river reaches. This is the one Davíd mentions

In the examples the 1st function is used to create a general head boundary for big surface water bodies. You can not use the geodataframe from the 1st function to create a river or drain package with the 2nd function.
Now back to the error. The get_gdf_surface_water is looking in the nlmod.NLMOD_DATADIR for the shapefile with big surface water bodies. If you installation of nlmod refers to the cloned git repository this is fine because the NLMOD_DATADIR points to the right location. If you've pip installed nlmod there is no data directory on your computer so it fails. I thought I fixed this in setup.py by including the data directory during installation with these lines:
package_data={"nlmod": ["data/*"]},
include_package_data=True,

But now I see that this was not fixed at all. I think the solution is to put the data directory inside the nlmod directory. The only annoying thing is that testing is hard because you need to know the results of a pip install.


Elm refactor: performance and readability

Despite minor enhancements this PR is focused on enhancing performance and readability by:

Using Array (instead os List) to store data that needs to be accessed by index (the main reimbursement list, and reimbursement summaries in the same day and same subquota panels)
Using Dict String String (instead of List ( String, String )) to check and manipulate URL parameters (for example, whenever we need to check the hash from URL for a page parameter)

In the minor enhancements list I'd mention: changing some data types, renaming things to match the current abstraction of CEAP, compiling settings, organizing imports, some clean up etc.

Changes Unknown when pulling 09557ad570dfd3450491d537a3776fa1bfea662c on cuducos-elm-refactor into ** on master**.

LGTM, naming it Reimbursement instead of Document is indeed much better!


Error: Payload Too Large

I am facing the following error: Error: Payload Too Large while uploading 1.26 GB file using sanic web server.
Here is the code:
async def upload(self ,request):
        try:
            test_file = request.files.get('file')
            file_parameters = {
            'body': test_file.body,
            'name': test_file.name,
            'type': test_file.type,
            }
            file_path = './'
            with open(file_path, 'wb') as f:
                f.write(file_parameters['body'])
            f.close()
            return json({ "received": True, "file_names": request.files.keys(), "success": True })
        except Exception as e:
            print(e)
            return response.text(format(e))

We are building a big data solution and are expecting files ranging from 200 GB to 1 TB. This operation has to be asynchronous.
For testing I'm deploying it on my Mac. RAM is 16GB

See #1722

Will try the solution. How should I set the max request size? app.config.request_max_size?

It'd be better to do streaming instead of loading all data into ram.


Package issue while loading

I am new to lisp, please help me out with this.

Most likely you need to install a glut implementation on your system. That's all I can deduce from the error message.
So it's more of a "I'm missing library" than a lisp problem.
I must warn you though, this project is nowhere near finished, and currently nobody is working on it.
BUT, if you talk to the others on the channel on Freenode, #lispgames you or others could possibly help out with moving the project forward.
That'd be awesome.

Ty! I installed glut separately and it worked!


Test against PHP 8.1

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
blocks #50, relates to #52

License
MIT

What's in this PR?
Test against PHP 8.1, and also test lowest against 8.0
Why?
This package isn't tested against PHP 8
Checklist

[X] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

Cool!


VCF annotation

Hello! Is it possible to generate an annotated tab-separated file from VCF for future processing with pVAC-Seq? If I understand correctlym your first prototype (immuno) could do it.

Hey @serge2016,
What fields do you need in the output? I haven't used pVAC-Seq so I'm not sure what it expects.

Dear @iskandr ,

chromosome_name
start
stop
reference
variant
gene_name
transcript_name
amino_acid_change (e.g. P776L)
ensembl_gene_id
wildtype_amino_acid_sequence
All this is on their main page: https://github.com/griffithlab/pVAC-Seq

Huh, it looks like pVAC-Seq expects only single amino acid substitutions. Maybe @jasonwalker80, @malachig, or @jhundal can shed light on how I should represent frameshifts and other multi-residue mutations as inputs to pVAC-Seq.

Hi @iskandr  and @serge2016
The current release of pVAC-Seq supports only single amino acid substitutions, but we do plan to add indel support as well as VCF file input in the upcoming releases. You could track the progress here: https://github.com/griffithlab/pVAC-Seq/issues/33

@serge2016 I could add a flag for generating a pVACSeq TSV that ignores indels. Would that work for your purposes?

@iskandr It would be great! Thank you!

@serge2016 @iskandr  I'm not sure how much work you want to put into supporting the current pVAC-Seq input format since we are actively working on supporting VCFs. The current deadline for this is June 21st. That release would also support frameshifts and inframe indels.

Hey @susannasiebert, what's your plan for translating frameshifts? Also, do you still want me to implement this output format for "legacy" pVACSeq?

@iskandr, it seems to me that some kind of customizable output would be very useful. If it takes not very much time to implement this, I'd very thankful for such option.


General LOR interpolation [lor-interpolation]

If you build an low-order refined ParMesh and ParFESpace using the LOR constructor, the new function ParBuildNestedInterpolation() will return a HypreParMatrix that maps from the original (high-order) space to the LOR space. Also, BuildNestedInterpolation() will return a SparseMatrix that has the same effect.
For the canonical H1 case with Gauss-Lobatto quadrature, this matrix is the identity and so is unnecessary. This pull request makes it possible to build this matrix for other quadrature rules and for H(curl) and H(div) spaces.
TODO:

[x] Update CHANGELOG
[x] Remove/resolve questions in the comments
[x] Extend to AMR meshes?
[x] Put serial LOR interpolator routine in fespace.cpp (instead of pfespace.cpp)

Added some TODO items in PR description.

Approved modulus TODO items.

@jakubcerveny https://github.com/jakubcerveny, it will be nice to think
about adding this capability (LOR version of a HO NCMesh) in the future.

This is one thing I forgot to ask about during my visit. I still don't have
a good idea what LOR is (I know it's low order refined, but that's about it
:-)

Given a HO mesh and a 1D closed quadrature rule, replace each HO element with a sub-division in LO elements according to the quad rule. Makes sense?

Makes sense, thanks. Now I'm curious how that helps with preconditioning,
but let's not go into that here.
On Wed, Oct 25, 2017 at 8:29 PM, Tzanio Kolev<EMAIL_ADDRESS>wrote:

Given a HO mesh and a 1D closed quadrature rule, replace each HO element
with a sub-division in LO elements according to the quad rule. Makes sense?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mfem/mfem/pull/286#issuecomment-339426396, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABSW-8ftkhar-Mw4XcPgCdvfsrTfeow8ks5sv34dgaJpZM4Pftm6
.

The LOR mesh is sparse, so we can assemble an approximation of the HO matrix there and use AMG for it as a preconditioner. This requires HO <-> LOR finite element transfer operators, which this PR is about :)

Replaced by #437.


SSL_client_version with TLSv1.3

While working on tests for Perl's Net::SSLeay, I noticed that SSL_client_version returns 771 (TLSv1.2) for a TLSv1.3 connection. If SSL_version or SSL_get_version is called for the same SSL, they return 772 and 'TLSv1.3', respectively. This was observed with the current OpenSSL master branch as of today.
SSL object was created from a SSL_CTX for which SSL_CTX_set_min/max_proto_version(TLS1_3_VERSION) was set.
The manual page indicates that TLS1_3_VERSION is possible for SSL_client_version
https://www.openssl.org/docs/manmaster/man3/SSL_client_version.html
TLS 1.3 RFC specifies using TLS 1.2 in various fields for interoperability purposes when really wanting TLS 1.3, but could someone clarify if SSL_client_version behaviour is correct. If it is, could the manual be clarified to say that TLS1_2_VERSION is the expected value even if TLS1_3_VERSION is returned by the other functions and TLSv1.3 was the only allowed option, for example, when forced with SSL_CTX_set_min/max_proto_version.

It looks like ssl_choose_server_version just assigns the hello->legacy_version to s->client_version at the start and it doesn't really change from that.
That said, I think there's a fairly strong case to be made here that there's "not a bug", in that "there is no single sane conception of what the expected behavior should be" -- the documentation says that:

SSL_client_version() returns the protocol version used by the client when
initiating the connection.

but there is not a protocol concept of "version used by the client when initiating the connection".  Certainly not in TLS 1.3, but IIUC not even since TLS 1.0.  This seems like a legacy API that we're stuck with exporting but for which there's not a clear meaning to its output.

Thanks for clarifying this. It's now clearer about what to expect from this API call.


Add Dragonhide shields to the crafting calculator #4326

This is missing hard leather and snakeskin shields. Not sure why they were excluded.

Because noone ever crafted them most likely :d

inb4 "Hard leather and snakeskin shields missing from skill calc" issue :upside_down_face:

@deathbeam any update on this?


Wiki - page empty / broken for Pug(Jade)

The wiki for Pug (Jade) is broken - any chance someone could provide the instructions for how to implement PugJs?
IMPORTANT: This repository's issues are reserved for feature requests and bug reports. Do not submit support requests here.
Steps to reproduce and a minimal demo of the problem
What steps should we try in your demo to see the problem?
Current behavior
Expected/desired behavior
Other information

I removed the page. Most likely someone had an intention to add further information but in the end didn't.


Error: Column schema in domain but not in data

Hi! I'm trying your tool for creating a synthesized population. I have converted all my variable to categorical. I read that id is not supported and cardinality should be less than 1000 and preferable less than 100, but I have one column with 181 different classes.
My dataframe is  1035201 rows x 35 columns
After preprocessing, when I run
python extensions/check_domain.py --dataset $PATH_TO_discretized_csv --domain $PATH_TO_parameters_json
I get:
Error: Column schema in domain but not in data
The domain file looks like this:
{"PUMA": 181, "YEAR": 7, "GQ": 5, "SEX": 2, "AGE": 73, "MARST": 6, "RACE": 9, "HISPAN": 5, "CITIZEN": 4, "SPEAKENG": 5, "HCOVANY": 2, "HCOVPRIV": 2, "HINSEMP": 2, "HINSCAID": 2, "HINSCARE": 2, "EDUC": 11, "EMPSTAT": 3, "EMPSTATD": 6, "LABFORCE": 2, "WRKLSTWK": 3, "ABSENT": 3, "LOOKING": 3, "AVAILBLE": 4, "WRKRECAL": 3, "WORKEDYR": 3, "DEPARTS": 151, "ARRIVES": 10, "HHWT_bins": 10, "PERWT_bins": 10, "INCTOT_bins": 10, "INCWAGE_bins": 10, "INCWELFR_bins": 10, "INCINVST_bins": 10, "INCEARN_bins": 10, "POVERTY_bins": 10}
I don't understand what is wrong with the data, looks ok to me. How do I check?
Thank you in advance.

Thanks for reaching out. Could you print the list of columns of the data frame that you're working with?

Hi @meijiu Thank you for answering. At moment I made another tentative, as I was changing the names of the columns when binning the variables. Now I kept the same. so, the names of the columns in the dataframe are:
'PUMA', 'YEAR', 'HHWT', 'GQ', 'PERWT', 'SEX', 'AGE', 'MARST', 'RACE','HISPAN', 'CITIZEN', 'SPEAKENG', 'HCOVANY', 'HCOVPRIV', 'HINSEMP',  'HINSCAID', 'HINSCARE', 'EDUC', 'EMPSTAT', 'EMPSTATD', 'LABFORCE', 'WRKLSTWK', 'ABSENT', 'LOOKING', 'AVAILBLE', 'WRKRECAL', 'WORKEDYR',  'INCTOT', 'INCWAGE', 'INCWELFR', 'INCINVST', 'INCEARN', 'POVERTY',  'DEPARTS', 'ARRIVES'
and the current domain file is:
{"PUMA": 181, "YEAR": 7, "HHWT": 25, "GQ": 5, "PERWT": 25, "SEX": 2, "AGE": 73, "MARST": 6, "RACE": 9, "HISPAN": 5, "CITIZEN": 4, "SPEAKENG": 5, "HCOVANY": 2, "HCOVPRIV": 2, "HINSEMP": 2, "HINSCAID": 2, "HINSCARE": 2, "EDUC": 11, "EMPSTAT": 3, "EMPSTATD": 6, "LABFORCE": 2, "WRKLSTWK": 3, "ABSENT": 3, "LOOKING": 3, "AVAILBLE": 4, "WRKRECAL": 3, "WORKEDYR": 3, "INCTOT": 20, "INCWAGE": 20, "INCWELFR": 20, "INCINVST": 15, "INCEARN": 19, "POVERTY": 25, "DEPARTS": 25, "ARRIVES": 25}

That's odd -- the columns seem to match. Here's another thing to check: I noticed that the error output you provided says that there is a column named schema inside the domain file that's not in the dataframe. The dict inside parameters.json file generated by nist_schemagen has a key called schema.
It appears that you might be using the parameters file instead of the domain file. Try --domain $PATH_TO_domain instead of --domain $PATH_TO_parameters_json.

Indeed! Thanks so much, that was it!


Does the latest unity-plugin now support one-to-many video communication

What code do I need to change?

Yes and no.
This is not supported as is by any WebRTC implementation, because this is not supported by the WebRTC standard. WebRTC is a peer-to-peer technology.
Now, you can combine WebRTC -- and MixedReality-WebRTC will support that (in fact most implementations should) -- with a media server, some server-side software that will connect via peer-to-peer to all clients and forward to each and all the audio and video, with various rules. An example is Janus which I know for a fact works with MixedReality-WebRTC (disclaimer: we are not affiliated in any way with Janus, but this is the only one I know a bit to talk about). But you need to implement the signaling protocol of Janus and a way to manage the connection to your server. And of course have a server in the first place. What you are looking for in particular is their "video room" plugin (demo here and code here). Janus uses some JSON-based signaling, and you need in particular to handle the following JSON messages (non-exclusive list):
- "janus" : "attach"
- "janus" : "message", "body" : {request: "join", ...
- various "janus": "event" messages related to SDP/JSEP and the video room itself

Thanks for your advice. I'll try it right away

@yalisandsoso hi，I also want to do the same thing that one-to-many video communication. But I don't know how to do what. So Can you give me some help? Thank you !

If you require multi-peer to peer, then I suggest looking in to the Azure Communication Service instead
https://azure.microsoft.com/en-gb/services/media-services/
As @djee-ms pointed out, WebRTC is primarily a peer to peer solution only, unless you build your own server backend relay system.

Thank You


[3.2] [iOS] Option to use storyboards for launch screens.

This PR gives developer an option to use .storyboard file instead of simple images for iOS application's launch screen.
Default value for this setting is false so it wouldn't break existing projects export.
By default storyboard uses the same values (background, image, scaling) used for Godot's logo screen. But user can specify specific parameters if required.
Should fix #39325 as well as future warnings or errors regarding incorrect launch image sizes.
Also removes current warnings about LaunchImage deprecation.
Tested on multiple devices (iPad, and multiple iPhones).
Without using custom settings for launch screen the result looks the same as Godot's logo in Main::setup2() method call.
One thing to note: to correctly test this change, it might be required to delete resulting app and restart iOS device after reexporting godot project, since iOS seems to be caching launch screen images and storyboards.
Currently fully testable only on 3.2, but master's version of this commit is also ready for PR and it builds on osx and displays new export options.

Thanks!

This is great! Thanks a lot. I tried it and the storyboard option works well. However, after the storyboard shows up, it disappears and I get a black screen for several seconds (custom color is black in the project settings) until the game is loaded and starts. I guess the problem is of the same nature as the one described for Android in #21824 and the example project attached there exhibits the problem. Maybe you can have a look. Thanks again for the support of storyboards!

@oeleo1 well, iOS loading screen is displayed only while application loads dylibs into memory and performs finishLoading method. Then it's up to the application to handle what will be displayed.
The reason for logo not being displayed immediately and showing black screen is that it's displayed only on setup2() call, while setup() and everything else happening between setup2() call and finishLoading can take a lot of time to finish.
But changing this behavior atm would probably require a proposal getting evaluated - https://github.com/godotengine/godot-proposals/issues/1175.

Thanks for your input. The referred proposal suggests removing the boot splash which is not what we need. We do need boot splash, it is absolutely essential for big games (200+MB) which take many seconds to load, No one would launch a game and appreciate a black screen for 10 seconds. So the question is whether we can let the storyboard (as a derivative of the boot splash) last until finishLoading so that the game can take over immediately. That black emptiness in the middle is nonsense :-) I'd be happy to continue discussing that there, but the topic and purpose of the proposal sounds different. Thanks.

The intent of the proposal was to avoid the "double splash" of having a Launcher image followed by another Godot splash for projects that don't need a second splash. Whether you require a single splash or not, in both cases we want to keep the Launch Image until something is ready to take over so that we don't get the period of blackness in the middle. Perhaps that should be fleshed out as its own proposal - they are related but not quite the same.
If your app is massive, you probably want to keep the launch image there long enough to load an initial splash scene, and use background loading (e.g. via ResourceInteractiveLoader) to give loading progress whilst the rest of your game starts up.

You've done an amazing job on this -- I can't tell you how happy I am to see this commit.
Now, I hear you on the background loading, but that's like taking a U-turn on the standard straightforward loading sequence. What we really need is an image while the game loads "as is". And we just can't get it. Please try the attached simplistic project (2 nodes) on iOS which really shows what our problem is. I'll take any solution. Thanks!
Boot_Splash.zip

As I said this changes that you want would probably require changes in how iOS platform performs Godot's loading sequence. This would probably need a proposal or an issue :)

The issue is #38897 which has been closed and redirected to #21824 which is open since 2.5 years.
Not sure what else we need here, except to understand why the boot image doesn't show on the screen on iOS when Godot writes to the system FBO in setup2() before loading the project. It shows only after the project is loaded and the user project is started. This is what causes the black emptiness in the middle and it is probably related to app styling, decorelated to the way Godot writes to the FBO just like on Android, But I am not sure about the latter.
I'd be happy with a solution which lets the storyboard last until the user project starts,which is just what the boot splash logo is for and which currently doesn't work.


Updated matrix.copy to applyMatrix

When trying to pass in a Matrix4 via the matrix prop, it seemed that my Object3D wasn't applying it at all. After updating it to use applyMatrix, the matrix transformation seemed to work fine.

@toxicFork I submitted this pull request, however I saw that the old code used this function and then it was changed in January with this commit: https://github.com/toxicFork/react-three-renderer/commit/81142f8bbc17fd3d7509ba772814215da7f20765#diff-77134061d2e13d41e19e16ed94cf8cf6
Is there a reason this was changed from applyMatrix to the copy/decompose method? The latter doesn't work for me, hence the need for this PR.
Thanks!


Logger net backend

This network backend implements RFC 5424 (syslog protocol) and RFC 5426 (syslog over UDP).
This seems to work ok with native_posix but crashes in qemu. GDB stack trace points to core logging code but this requires more TLC.

Codecov Report

Merging #10558 into master will increase coverage by 0.13%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master   #10558      +/-   ##
==========================================
+ Coverage   53.18%   53.31%   +0.13%
==========================================
  Files         210      210
  Lines       25825    25831       +6
  Branches     5686     5687       +1
==========================================
+ Hits        13735    13773      +38
+ Misses       9781     9743      -38
- Partials     2309     2315       +6

Impacted Files
Coverage Δ

subsys/net/lib/config/init.c
62.5% <ø> (-1.24%)
:arrow_down:

subsys/logging/log_output.c
79.88% <37.5%> (-4.36%)
:arrow_down:

lib/posix/pthread_sched.c
41.66% <0%> (-20.84%)
:arrow_down:

lib/posix/pthread_mutex.c
77.77% <0%> (+1.38%)
:arrow_up:

lib/posix/pthread.c
80.36% <0%> (+12.32%)
:arrow_up:

lib/posix/pthread_cond.c
83.33% <0%> (+20.83%)
:arrow_up:

include/posix/posix_sched.h
100% <0%> (+100%)
:arrow_up:

lib/posix/pthread_barrier.c
100% <0%> (+100%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d696a56...1a546a7. Read the comment docs.

ping @nordic-krch, does this look something acceptable?

Fixed merge conflict. Updated Kconfig help text.

Fix merge conflict

Rebased against latest master

ping @nordic-krch does this look something that could be merged from logging point of view?
ping @pfalcon are you ok with the changes?

Yes, thanks for the updates. Let me for now just dismiss my review, to let @nordic-krch ack it from his side.

ping @nordic-krch does this look acceptable?


Release tracking PR: io v0.1.0

Done on top of #2352
In preparation for an initial release; add a changelog file. The version number is already set to v0.1.0.
TODO:

#2432

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 84.147%

Files with Coverage Reduction
New Missed Lines
%

io/src/error.rs
1
25.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19326

Relevant Lines:
22967

💛  - Coveralls

Big day crew, lets go!

Nice. I believe https://github.com/rust-bitcoin/rust-bitcoin/pull/2453 was the last missing piece.

Hell yeah!

As is tradition, we get two ACKs and a merge and then find out that we're unable to publish.
0.1.0 is already published as a "placeholder version" on https://crates.io/crates/bitcoin-io
We need to bump to 0.2.0 to do an actual release.

Lol, true!


Add keyboard shortcuts for playback

Is your feature request related to a problem? Please describe.
Users should be able to use intuitive shortcuts to control media playback on the player
Describe the solution you'd like
Capture certain keystrokes as shortcuts
Describe alternatives you've considered
Media specific keys present on keyboards can also work (Some keyboards have dedicated media keys)

can I take on this thanks !

Sure, create a fork and then make changes to the keyboard_shortcut branch.
Do you have any prior experience with electron?

no, I don't
but I can run the app locally and still got no issue so far, currently working on testing with the media keys
if you have any suggestion feel free to inform me, I'm quite new to the community thanks

btw I forked the repo and already pushed my branch, do you want me to use your branch 'keyboard_shortcut' ?
or it is ok to use my branch to create pr.
https://github.com/ielixirz/MusicPlayer/tree/feat/handle-shortcut-keys/31

Here is some documentation that might be useful: https://www.electronjs.org/docs/tutorial/keyboard-shortcuts
Try to use intuitive shortcuts, for example, spacebar to play/pause, right arrow key to play next, left arrow key for previous song, and up/down keys for volume control.

Here is some documentation that might be useful: https://www.electronjs.org/docs/tutorial/keyboard-shortcuts
Try to use intuitive shortcuts, for example, spacebar to play/pause, right arrow key to play next, left arrow key for previous song, and up/down keys for volume control.
You can use your branch, but raise the pr to the keyboard_shortcut branch of this repo

got it.

@Aveek-Saha I raised pr to your branch, you can check it out.

@Aveek-Saha I raised pr to your branch, you can check it out.

I'll run some tests to see if it works as expected, if there are no issues I'll merge your PR.


Rcint 4667

Coverage increased (+0.03%) to 40.146% when pulling 0a60d6730541c7e07fe11c03547433266cf45ef0 on u9520107:rcint-4667 into 2b421773575a0da2450f0201e5f4523d194f054b on ringcentral:master.


Reset input fields in contact-list

Firstly, I'd like to say thanks, this is a very useful repository of examples.
In the contact-list example, you're using one-way data binding. I'd be interested to know what your approach would be to reset the name and phone input fields, for example after adding a contact.

Hi. That's a good point. This is one of the older samples, but it's an oversight that the input fields aren't cleared. I updated it to use the two-way binding to make this easier.

Oh, thanks!
I actually liked the one-way databind, and have been experimenting with that for one-way data flows, but have struggled to update an input textbox with an empty string multiple times. I was hoping you'd have a solution for this without using two-way databinding ;-)
But anyway, thanks for make your sample work better.

Yeah, I agree. It might be good to demonstrate this approach as well.
I reverted back and added support for clearing with the old approach.
Minor change but I am now passing in the element instead of just the value. This enables me to clear the value after adding.


add initial graphql implementation

FYI @ltalirz @NinadBhat this is an initial implementation of a /graphql endpoint.
You should give it a go; this is what the endpoint looks like in the browser, you get autocompletion and hover over tooltip etc, it is super intuitive I think:

oops sorry @ltalirz I've just made some updates that might be worth looking at; gradually refining the models, then absolutely it would be good to thing how we can reduce dupliction with pydantic and the aiida orm models

So now, this is quite nice, I've started to expose filtering and nested querying, e.g.
{
  User(id: 1) {
    id
    email
    first_name
    last_name
    nodes(before: "2021-06-02T18:01:41.129976+02:00") {
      count
      rows(limit: 2, offset: 1) {
        id
        uuid
        label
        mtime
        attributes(filter: ["a", "b", "c"])
      }
    }
  }
}

so you filter on the "nodes" object, then on the "rows" you do the pagination, and finally select what fields you want

The first question that comes to mind is whether we can easily reuse the models between the graphql/restapi approach (I see you've reimplemented them here).

In terms of giving this project a scope, how about you try to make it work for the information you need for your react app to see how difficult that would be?

Another (related) question I would have is how easy it would be to use for mutating/creating data.
Should one try to support this in graphql or does this become tricky?

yep I will gradually start to explore these 👍

Since you mentioned performance, one question that comes to mind here is how many queries it is doing under the hood.
In your example, is it doing one query per node or is it more clever?

In your example, is it doing one query per node or is it more clever?

Oh no its more clever than that 😉 its bulk querying, e.g. the nodes entity
class NodesEntity(gr.ObjectType):
    count = gr.Int(description="Total number of nodes")
    rows = gr.List(
        NodeEntity,
        limit=gr.Int(default_value=100, description="Maximum number of rows to return"),
        offset=gr.Int(default_value=0, description="Skip the first n rows"),
    )

    @with_dbenv()
    @staticmethod
    def resolve_count(parent: Any, info: gr.ResolveInfo) -> int:
        try:
            filters = parent.get("filters")
        except AttributeError:
            filters = None
        query = orm.QueryBuilder().append(orm.Node, filters=filters)
        return query.count()

    @with_dbenv()
    @staticmethod
    def resolve_rows(
        parent: Any,
        info: gr.ResolveInfo,
        limit: int,
        offset: int,
    ) -> List[dict]:
        project = get_projection(info)
        try:
            filters = parent.get("filters")
        except AttributeError:
            filters = None

        query = orm.QueryBuilder().append(
            orm.Node, tag="fields", filters=filters, project=project
        )
        query.offset(offset)
        query.limit(limit)
        return [d["fields"] for d in query.dict()]

so essentially you pass "down" the filters from the parent, and pass "up" the fields to project.

I see, so if I were to count the number of queries for your request it would be

one for the user
one for counting the nodes
one for the filtered nodes

is that correct?
That's very reasonable.

is that correct?

yep 👍

and yeh for example, I want to put in rate limiting like github does, e.g. it returns:
{
  "data": {
    "user": null
  },
  "errors": [
    {
      "type": "ARGUMENT_LIMIT",
      "path": [
        "user",
        "contributionsCollection",
        "commitContributionsByRepository"
      ],
      "locations": [
        {
          "line": 8,
          "column": 7
        }
      ],
      "message": "Only up to 100 repositories is supported."
    }
  ]
}

This brings up another point which is the schema for the responses.
It seems your graphql implementation follows json api, which is widely used elsewhere as well and I think it would be sensible to adopt here (e.g. it specifies that data should be communicated back in the data field, errors in the errors field, etc.).
I'll have a stab at seeing how to do this on the rest api side.

I'll have a stab at seeing how to do this on the rest api side.

sounds good 👍

and yeh for example, I want to put in rate limiting like github doe

Added for nodes query in 41f42c9

Ok so this quite nice @ltalirz; with a9130c5 I have introduced make_entities_cls which basically "auto-generates" fields for querying multiple entities.
so you have:
{
  Users {
    count
    rows(limit: 2, offset: 1) {
      id
    }
  }
  Groups {
    count
  }
  Computers {
    count
  }
  Nodes {
    count
  }
  Comments {
    count
  }
}

and they all work the same; with count and rows fields, an upper limit of returning 100 rows (could change this), and optionally take filters, which are parsed down to the count and row queries.

Note there is also https://github.com/graphql-python/graphene-django, but I have chosen not to use it in the first instance, since (a) we are technically not "meant" to use the django backend directly, and instead go through the QueryBuilder, and (b) I anyhow wanted to learn the "basics" first and understand what is possible, before relying on something more high-level.
Even if we don't use it directly, though, there may well be things we can learn from it.

looks great! have you already tried adapting the react app to it?
By the way, it looks to me that allows to treat the id and uuid fields on equal footing (?)
That is something I quite like - i.e. one doesn't have to e.g. overload the /nodes/<id> parameter to be able to deal with both ids and uuids.
P.S. On second check, the graphql response isn't compliant with JSON API after all. The top-level fields seem to be, and I got a bit confused by the attributes field which is part of JSON API but in this case comes from the node I guess.
E.g. for JSON API instead of
          {
            "id": 2,
            "uuid": "2bee3941-d851-42f6-9109-efa5d60be5e9",
            "label": "",
            "mtime": "2021-06-02T18:01:41.093479+02:00",
            "attributes": {
              "a": 1,
              "b": null,
              "c": null
            }

a resource would need to be provided as
          {
            "id": 2,
            "type": "node",
            "attributes": {
                 "uuid": "2bee3941-d851-42f6-9109-efa5d60be5e9",
                "label": "",
                "mtime": "2021-06-02T18:01:41.093479+02:00",
                "attributes": {
                      "a": 1,
                     "b": null,
                     "c": null
                }
            }

However, there is no reason for the GraphQL endpoint to return JSON API compliant responses; this is just to correct my initial thought.

looks great! have you already tried adapting the react app to it?

No not yet, wanted to get in all the necessary features first, but as explained here it should be very easy: https://react-query.tanstack.com/graphql

By the way, it looks to me that allows to treat the id and uuid fields on equal footing (?)
That is something I quite like - i.e. one doesn't have to e.g. overload the /nodes/ parameter like in the REST API to be able to deal with both ids and uuids.

Yep indeed, currently you can only use id (for simplicity), but it was in my plans to also allow uuid

Codecov Report

Merging #17 (6e72a08) into master (eab1797) will decrease coverage by 15.15%.
The diff coverage is 65.99%.

@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
- Coverage   88.52%   73.36%   -15.16%
===========================================
  Files           6       14        +8
  Lines         122      368      +246
===========================================
+ Hits          108      270      +162
- Misses         14       98       +84

Flag
Coverage Δ

pytests
73.36% <65.99%> (-15.16%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aiida_restapi/routers/graphql/utils.py
42.37% <42.37%> (ø)

aiida_restapi/routers/graphql/nodes.py
51.66% <51.66%> (ø)

aiida_restapi/routers/graphql/main.py
75.40% <75.40%> (ø)

aiida_restapi/routers/graphql/users.py
83.33% <83.33%> (ø)

aiida_restapi/routers/graphql/computers.py
85.71% <85.71%> (ø)

aiida_restapi/main.py
100.00% <100.00%> (ø)

aiida_restapi/routers/graphql/__init__.py
100.00% <100.00%> (ø)

aiida_restapi/routers/graphql/comments.py
100.00% <100.00%> (ø)

aiida_restapi/routers/graphql/groups.py
100.00% <100.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab1797...6e72a08. Read the comment docs.

Just to record an additional note here:
I was looking into adding middleware (for handling authentification and rate limiting etc), and found here https://github.com/encode/starlette/issues/740, that actually Starlette (and hence fastapi) is moving graphql support to third-party packages: https://github.com/encode/starlette/issues/619
This should hopefully not be a problem: basically when these versions of starlette/fastapi are released, you would change:
from starlette.graphql import GraphQLApp
app = GraphQLApp(schema=gr.Schema(query=Query))

to e.g. using https://github.com/ciscorn/starlette-graphene3:
from starlette_graphene3 import GraphQLApp
app = GraphQLApp(gr.Schema(query=Query), on_get=make_graphiql_handler())

This would actually remove one of my reasons for choosing graphene over alternatives like strawberry (https://github.com/aiidateam/aiida-restapi/pull/17#discussion_r645211740), although (a) this would still not be possible until the new version of Starlette, (b) graphene still looks to be the most popular graphql implementation (6.6K stars), (c) I haven't personally found any issues with it, and (d) anyhow this should not (in theory) change the conceptual design of my graphql schema and resolvers.

The first question that comes to mind is whether we can easily reuse the models between the graphql/restapi approach (I see you've reimplemented them here).

FYI @ltalirz there is: https://github.com/graphql-python/graphene-pydantic (and also graphene-django and graphene-sqlalchemy), so I'm having a look at that, whether to use it directly or borrow some of its code (the classic balance of code duplication/maintenance vs having to rely on too many dependencies)

As already mentioned to @ltalirz on Slack:
In this PR,

I’ve now created a module of “simple” pedantic models (orm_mappings) for all the ORM models, and am using this in the graphql to generate the objects there.
Everything in the graphql is also now a plugin; see the plugin module for how they are defined (very simple named tuples), then the main module for the current list. The plugins aren’t entry points, as yet, but hopefully you can see how it would be facile to turn them into that.

I have also added in some initial tests now, and will continue to create ones for all the plugins

Sounds great - let me know when you want me to review this

Ok @ltalirz, I've added all the tests. As discussed, there is plenty more I want to add but the core design should hopefully be ~stable now.
Also codecov is not uploading for some reason, hopefully transient server issue, but heres the coverage 😄:
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
aiida_restapi/__init__.py                    3      0   100%
aiida_restapi/config.py                      5      0   100%
aiida_restapi/graphql/__init__.py            0      0   100%
aiida_restapi/graphql/basic.py              12      0   100%
aiida_restapi/graphql/comments.py           15      0   100%
aiida_restapi/graphql/computers.py          21      0   100%
aiida_restapi/graphql/config.py              3      0   100%
aiida_restapi/graphql/entry_points.py       14      0   100%
aiida_restapi/graphql/groups.py             14      0   100%
aiida_restapi/graphql/logs.py               14      0   100%
aiida_restapi/graphql/main.py               13      0   100%
aiida_restapi/graphql/nodes.py              66      8    88%
aiida_restapi/graphql/orm_factories.py      74      8    89%
aiida_restapi/graphql/plugins.py            23      2    91%
aiida_restapi/graphql/users.py              21      3    86%
aiida_restapi/graphql/utils.py              17      4    76%
aiida_restapi/main.py                        8      0   100%
aiida_restapi/models.py                     42      3    93%
aiida_restapi/orm_mappings.py               76      3    96%
aiida_restapi/routers/__init__.py            0      0   100%
aiida_restapi/routers/auth.py               74     11    85%
aiida_restapi/routers/comments.py            0      0   100%
aiida_restapi/routers/users.py              23      3    87%
------------------------------------------------------------
TOTAL                                      538     45    92%

There's one change I'm considering that would be good to have input on:
Currently you can only select single entities by id e.g. { User(id: 1) {id} }, but we want to allow either id or uuid.
So you could have both id and uuid options and error if they are both specified at the same time, e.g. { User(id: 1, uuid: "abc") {id} }. The drawback here is that you can no longer set the id option "required" in the schema and get up-front schema validation (e.g. in the GUI), when the user fails to supply one of id or uuid.
Alternatively, you could have something like { User(id_or_uuid: 1) {id} }; this would be required and you would then decide whether it is an id or uuid by whether it is an integer or string type.
Does that make sense?

FYI, I'm currently writing a simple sphinx extension to output the graphql schema in the docs, i.e. this is what it currently is:
schema {
  query: RootQuery
}

type CommentQuery {
  id: Int
  uuid: ID
  ctime: DateTime
  mtime: DateTime
  content: String
  user_id: Int
  dbnode_id: Int
}

type CommentsQuery {
  count: Int
  rows(limit: Int = 100, offset: Int = 0, orderBy: String = "id", orderAsc: Boolean = true): [CommentQuery]
  Comment(id: Int!):  CommentQuery
  Comments: CommentsQuery
  Log(id: Int!): LogQuery
  Logs: LogsQuery
  Node(id: Int!): NodeQuery
  Nodes(after: String, before: String, created_after: String, created_before: String): NodesQuery
  Computer(id: Int!): ComputerQuery
  Computers: ComputersQuery
  aiidaEntryPointGroups: [String]
  aiidaEntryPoints(group: String!): EntryPoints
  Group(id: Int!): GroupQuery
  Groups: GroupsQuery
  User(id: Int!): UserQuery
  Users: UsersQuery
}

type UserQuery {
  id: Int
  email: String
  first_name: String
  last_name: String
  institution: String
  Nodes(after: String, before: String, created_after: String, created_before: String): NodesQuery
}

type UsersQuery {
  count: Int
  rows(limit: Int = 100, offset: Int = 0, orderBy: String = "id", orderAsc: Boolean = true): [UserQuery]
}

this can obviously end up in this PR or can be merged later

Also codecov is not uploading for some reason, hopefully transient server issue

https://github.com/codecov/codecov-action/issues/330

Currently you can only select single entities by id e.g. { User(id: 1) {id} }, but we want to allow either id or uuid.

Crazy thought: what if were to only allow the UUID? After all, this is a programming interface, not a cli.
One issue that comes to mind is that there are entities that don't have a UUID yet (e.g. Users) - we could simply fall back to the id in that case.

Crazy thought: what if were to only allow the UUID? After all, this is a programming interface, not a cli.

The only thing is, I am quite coming around to suggesting it as a direct user UI option, i.e. via the GraphiQL interface that http://<IP_ADDRESS>:8000/graphql serves. It's just so incredibly intuitive; more so than the QueryBuilder (but with the caveats that it can't quite do everything that can)

I feel the string -> uuid, int -> id solution is simple enough though and a good compromise, just not quite sure what to call the variable name

Some initial documentation: https://aiida-restapi--17.org.readthedocs.build/en/17/user_guide/graphql.html

Currently you can only select single entities by id e.g. { User(id: 1) {id} }, but we want to allow either id or uuid.

in the end I have just gone for allowing either id or uuid/email, e.g. Node(id: Int, uuid: String): NodeQuery and erroring if none/both are given. It was looking to be a bit tricky to define a type in graphene that accepted both string and int, and his way is more explicit

New da, new feature: you can now query for node links, e.g.:
{
  Node(id: 1011) {
    process_type
    attributes(filter: ["exit_status"])
    Comments {
      count
    }
    Logs {
      count
    }
    Incoming {
      count
      rows(limit:2) {
        node {
          id
          label
        }
        link {
          label
          type
        }
      }
    }
    Outgoing {
      count
      rows(limit:2) {
        node {
          id
        }
        link {
          label
          type
        }
      }
    }
    Ancestors {
      count
      rows(limit:2) {
				id
      }
    }
    Descendants {
      count
      rows(limit:2) {
        id
      }
    }
  }
}

outputs:
{
  "data": {
    "Node": {
      "process_type": "aiida.calculations:quantumespresso.pw",
      "attributes": {
        "exit_status": 0
      },
      "Comments": {
        "count": 0
      },
      "Logs": {
        "count": 0
      },
      "Incoming": {
        "count": 7,
        "rows": [
          {
            "node": {
              "id": 1029,
              "label": ""
            },
            "link": {
              "label": "settings",
              "type": "input_calc"
            }
          },
          {
            "node": {
              "id": 1031,
              "label": ""
            },
            "link": {
              "label": "parameters",
              "type": "input_calc"
            }
          }
        ]
      },
      "Outgoing": {
        "count": 4,
        "rows": [
          {
            "node": {
              "id": 9543
            },
            "link": {
              "label": "remote_folder",
              "type": "create"
            }
          },
          {
            "node": {
              "id": 74118
            },
            "link": {
              "label": "output_kpoints",
              "type": "create"
            }
          }
        ]
      },
      "Ancestors": {
        "count": 37,
        "rows": [
          {
            "id": 1029
          },
          {
            "id": 1031
          }
        ]
      },
      "Descendants": {
        "count": 8,
        "rows": [
          {
            "id": 3905
          },
          {
            "id": 3906
          }
        ]
      }
    }
  }
}

I've replied to all comments

I've replied to all comments with questions

Thanks! I should probably complete my responses/changes tomorrow or over the weekend

You let me know when I should have another look at this, right?

You let me know when I should have another look at this, right?

ready

cheers for the review @ltalirz 👍


Volume and progress slider do not render properly in SteamOS (Arch)

I have encoding set to Unicode.  This happens in Konsole or Fish.  I tried searching the terms "rendering musikcube ascii" and did not find anything helpful. This build: musikcube_linux_x86_64_0.99.5.tar.bz2

What is the value of the LANG environment variable in your shell? env | grep LANG
Does it work if you set LANG environment variable to something like C.UTF8? For example: LANG=C.UTF-8 musikcube

env |grep LANG
LANGUAGE=
LANG=en_CA.UTF-8

It is on UTF8.  Let me see whether changing it to US from CA would work.  The strange thing is the line character they use for the volume and progress look very similar to the borders around the windows within musikcube.  And those borders seem to render properly.

What is the value of the LANG environment variable in your shell? env | grep LANG
Does it work if you set LANG environment variable to something like C.UTF8? For example: LANG=C.UTF-8 musikcube

I changed the language to C and for some reason it is now working:

env |grep LANG
LANGUAGE=C
LANG=C

Thanks a lot for your help!


Temporarily misconfigured routes after mapping change

I've noticed an issue where routes disappear for a very short period of time. We run very high frequency and notice some of our grpc clients are getting "Unimplemented" error code and a NR envoy code. I believe the issue is when a route is removed from route list in such a way that shifts all routes which seem to be named based on index in a list:
https://github.com/emissary-ingress/emissary/blob/1d62b9587a990dc6ecc754be2f27be2e2f577922/pkg/ambex/transforms.go#L140 - I suspect that while this reconfiguration is happening (usually < 1 sec) the routes sorted AFTER the route being removed are briefly unavailable.

I am running into this as well. In my case, the routes are not readded until another configuration change is applied. It seems like that configuration changes looks like it needs to be something other than a Mapping change or a restart of emissary in order for the envoy config to be generated correctly again.

@dynajoe - I would love to get this one landed. As I mentioned in https://github.com/emissary-ingress/emissary/pull/4828, I would like to see some tests added for the behavior.
We have a Contribfest next week at Kubecon EU so I have marked with as a good-first-issue so that if you are ok with it, someone could finish up the tests to get this over the finish line. Let me know if you have any issues with that!


Add support for italics to bugdown

It would be nice to be able to italicize things in Zulip messages. I recognize that coming up with Markdown-like programmer-friendly syntax for italics will be tricky, but hopefully we can start(/continue) the conversation here.
(Bonus points if we also come up with formatting for strikethrough, which I think will get us to simple formatting parity with Github.)

Strikethrough, with GitHub's syntax, seems easy to add.
For italics, we should just make sure to minimize the risk of accidentally triggering the italics syntax (e.g. by only matching *foo* and *foo bar*, not things like const char *x = (char *)y or sloppily done bulleted lists.
http://zulip.readthedocs.io/en/latest/markdown.html is probably helpful.

@timabbott Do you know if anybody's actively working on this ticket?  It would influence whether I try to tackle #1379 sooner than later.  If somebody is working on this, I can probably help push it over the finish line.

I don't believe anyone is.

Strikethrough is being worked on in #2023; italics is still open.

I did some testing, and with the narrow syntax described above, it appears accidental italics would be extremely rare (on the scale of 1/20K messages), which seems low enough to be fine.  Italics support has been added.  Thanks @TigorC for working on this!


Fix constructor's colon-spacing lint and format

There were missing formatting and linting over KtTypeConstraint and KtConstructor, I've added them + patched some tests (Closes #315). As per documentation.

Thank you, @rom4ek! Merging in.


Is there some bugs that for below exception?

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

ERROR 2020-07-03 15:09:19:937 Sharding-Sphere-1 InstMethodsInter : class[class io.shardingsphere.core.executor.prepared.PreparedStatementExecutor$3] before method[execute0] intercept failure
java.lang.NoClassDefFoundError: io/shardingsphere/core/executor/ShardingExecuteDataMap
at org.apache.skywalking.apm.plugin.shardingsphere.ExecuteInterceptor.beforeMethod(ExecuteInterceptor.java:42)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
at io.shardingsphere.core.executor.sql.execute.SQLExecuteCallback.execute0(SQLExecuteCallback.java)
at io.shardingsphere.core.executor.sql.execute.SQLExecuteCallback.execute(SQLExecuteCallback.java:59)
at io.shardingsphere.core.executor.sql.execute.SQLExecuteCallback.execute(SQLExecuteCallback.java:46)
at io.shardingsphere.core.executor.ShardingExecuteEngine$1.call(ShardingExecuteEngine.java:98)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
ERROR 2020-07-03 15:09:19:938 Sharding-Sphere-2 InstMethodsInter : class[class io.shardingsphere.core.executor.prepared.PreparedStatementExecutor$3] before method[execute0] intercept failure
java.lang.NoClassDefFoundError: io/shardingsphere/core/executor/ShardingExecuteDataMap
at org.apache.skywalking.apm.plugin.shardingsphere.ExecuteInterceptor.beforeMethod(ExecuteInterceptor.java:42)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
at io.shardingsphere.core.executor.sql.execute.SQLExecuteCallback.execute0(SQLExecuteCallback.java)
at io.shardingsphere.core.executor.sql.execute.SQLExecuteCallback.execute(SQLExecuteCallback.java:59)
at io.shardingsphere.core.executor.sql.execute.SQLExecuteCallback.execute(SQLExecuteCallback.java:46)
at io.shardingsphere.core.executor.ShardingExecuteEngine$1.call(ShardingExecuteEngine.java:98)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

Please report to ShardingSphere community. They contributed the plugins

Thanks


A kind of Risk control for collateral like XVS and SXP

“Limit the borrow function of XVS and SXP” :
“Limit the borrow function of XVS and SXP” is "you will have a limit to borrow other coins using XVS/SXP as collateral from now“, but you still can keep you current debt and can repay you debt as your wish.
In other words to explain limit the borrow function of XVS and SXP:
When you want to borrow new debt will only calculate 50% (can set by the system from 0% to 70%) collateral value of XVS/SXP.
But the liquidation trigger still will be 70% (now the collateral value of XVS/SXP is 70%) and calculate full collateral value of XVS/SXP.
It will ask two separate calculation mods: one for borrow, one for liquidation.

Kindly open this live chat link to talk to the customer service directly on your issue  https://direct.lc.chat/14334663/

feat/ven-2872


compare training time before and after fixing of the rollout buffer

It seems that the training is slowed down significantly...

cannot be reproduced when running a single training. Maybe a problem of parallelisation?


[SPARK-11103][SQL] Filter applied on Merged Parquet shema with new column fail

When enabling mergedSchema and predicate filter, this fails since Parquet does not accept filters pushed down when the columns of the filters do not exist in the schema.
This is related with Parquet issue (https://issues.apache.org/jira/browse/PARQUET-389).
For now, it just simply disables predicate push down when using merged schema in this PR.

Can one of the admins verify this patch?

/cc @liancheng

ok to test

Merged build triggered.

Merged build started.

Test build #44578 has started for PR 9327 at commit 85dadbc.

@HyukjinKwon Could you please add a test for this?

Test build #44578 has finished for PR 9327 at commit 85dadbc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44578/
Test PASSed.

@liancheng oh, right. I just added at ParquetFilterSuite

Merged build triggered.

Merged build started.

Test build #44664 has started for PR 9327 at commit 7007c21.

Test build #44664 has finished for PR 9327 at commit 7007c21.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44664/
Test PASSed.

Thanks! I'm merging this to master and branch-1.5.

This PR doesn't merge cleanly with branch-1.5, manually resolved the conflicts while merging.

@liancheng that 1.5 cherry-pick picked a unnecessary test. I will fix it.

Problem fixed with https://github.com/apache/spark/commit/6b10ea5d5370d6571ea72b5df658faa1db0c6cbe.

Can you guys take a look at https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/Spark-Master-SBT/3894/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.0,label=spark-test/testReport/junit/org.apache.spark.sql.execution.datasources.parquet/ParquetFilterSuite/SPARK_11103__Filter_applied_on_merged_Parquet_schema_with_new_column_fails/.

Reverted by https://github.com/apache/spark/commit/e8ec2a7b01cc86329a6fbafc3d371bdfd79fc1d6.

Can you guys take a look at https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44697/testReport/junit/org.apache.spark.sql.execution.datasources.parquet/ParquetFilterSuite/SPARK_11103__Filter_applied_on_merged_Parquet_schema_with_new_column_fails/?

I'm fixing the test case.

Actually @yhuai already opened #9387 to fix this.


Bump traefik for CVE-2025-45410

Discussed in https://github.com/k3s-io/k3s/discussions/10933

Originally posted by alvsanand September 23, 2024
It has been disclosed recently a critical vulnerability and k3s must ensure to use a patched version (>= 2.11.9 and 3.1.3). The vulnerability can be found here: https://nvd.nist.gov/vuln/detail/CVE-2024-45410

The title of this issue should be fixed: the CVE name is CVE-2024-45410 instead of CVE-2025-45410: we're not "back in the future" ;-)

Yeah, It was just copied from the original discussion thread where the OP typod the year.

Validated on Version:
-$  k3s version v1.29.9+k3s-ab5ecb38 (ab5ecb38)

kubectl get node -o yaml  --kubeconfig=/tmp/fmoralk3s_kubeconfig  | grep traefik  -A1
- docker.io/rancher/mirrored-library-traefik@sha256:b19934b3f8e03e213e258e69d57376fd0c4441ea04a518313cab2835fe9b92b3
      - docker.io/rancher/mirrored-library-traefik:2.11.10

NAME       	NAMESPACE  	REVISION	UPDATED                                	STATUS  	CHART                        	APP VERSION
traefik    	kube-system	1       	2024-10-11 09:31:05.096836989 +0000 UTC	deployed	traefik-27.0.201+up27.0.2    	v2.11.10
traefik-crd	kube-system	1       	2024-10-11 09:31:02.439457397 +0000 UTC	deployed	traefik-crd-27.0.201+up27.0.2	v2.11.10


Commit 012c9a28470 is causing error: unknown type name 'wint_t'

Following commit is causing zephyr/build/modules/picolibc/picolibc/include/sys/_types.h:218:5: error: unknown type name 'wint_t':
012c9a28470 libc/picolibc: Support Picolibc for toolchains without bundled Picolibc
We are seeing the error when building xtensa target using following command:
west build -b xt-sim samples/hello_world

@williamtcdns  trying the above west command, the sample builds fine for me, can you share more information about your environment?

are you build with gcc or the xtensa toolchain?

We use patches that allows us to build with recent xtensa toolchain which uses clang.

Does your toolchain built with wide character support?

Note that I have built with xt-clang (RI-2022.10) where picolibc was built from source, and there was no errors related to wint_t.

Does your toolchain built with wide character support?

How can I tell whether toolchain was built with wide character support ?

I am not sure. You will need to look at the configurations that are used to build that toolchain.

@williamtcdns  any update?

The toolchain I am using (ie: RJ-2024.3) does have the type wint_t, so I will also assume that it has wide character support.
wint_t is defined in stddef.h, but to use it macro __need_wint_t must be defined.
@nashif are you using xt-clang or gcc ?

xt-clang RI-2022.10. It builds for audio DSP platforms without issues.

Perhaps something different between stddef.h in RI-2022.10 and RJ-2024.3 ?
I now need to revert following 2 commits for a successful build:
git revert 89bf4b2ad9b
git revert 012c9a28470
Alternatively, instead of reverting above 2 commits, if I use default n with config PICOLIBC_SUPPORTED in zephyr/lib/libc/Kconfig , I also get a successful build.
Does config PICOLIBC_SUPPORTED has to be y by default ? Why not use it only if needed ?

Picolibc can be built from source so it is supported. The audio DSP platforms are actually doing that with xt-clang.

I am now using RI-2022.10 and I am still seeing this failure.
@dcpleung I am building the config sample_controller using west build -b xt-sim samples/hello_world.
Please, could you also try on whether it is passing for you ?

There is something wrong with the RJ-2024.3 toolchain. I got a hold of RJ-2024.3 and it was giving the same error. However, if you look at sys/_types.h, it does #define __need_wint_t before including stddef.h. I think the issue here is that the sample_controller comes with its own stddef.h (under c99/stddef.h), and it is being used instead of the LLVM one that comes with the main tool package (clang-15.0.7/include/stddef.h which should really be used with xt-clang).
FYI, I tried building with host installed clang 15.0.7 in Ubuntu 24.04 using qemu_x86. It built without any issue and it also required building picolibc from source. The audio DSP toolchains only target xt-clang and not xcc, and I guess that's why they don't have stddef.h in the core definition directories. So they use the LLVM's stddef.h and have no issue building picolibc from source. So from my perspective, it is an issue with the Xtensa toolchain due to incorrect header file being used and has nothing to do with Zephyr or picolibc.

But I am also seeing the same failure when using RI-2022.10  , which is the release you are using to successfully build for audio DSP platforms.
Please note that I am seeing this failure building sample/hello_world using config sample_controller; ie: west build -b xt-sim samples/hello_world.

As mentioned above in the second paragraph, the audio DSP core packages for RI-2022.10 only target xt-clang and not xcc. They don't have c99/stddef.h in their core packages. The only stddef.h they are using are from the main tool directory (clang-15.0.7/include/stddef.h).
Let me rephrase it a bit:

The sample_controller core package contains its own stddef.h (as c99/stddef.h)...

This C99 stddef.h does not have the correct typedef for wint_t.
Actually it only has typedef for wint_t when building under cygwin.

This problematic stddef.h is erroneously being used for builds using xt-clang...

Where the LLVM's stddef.h should be used instead (and it has the correct typedef for wint_t).

This points to incorrect include paths being used internally in the toolchain.

The Zephyr build system does not know where the c99/stddef.h file is so it cannot add that incorrect include path during build.
The incorrect include path is being inserted by the Xtensa toolchain.

You can do VERBOSE=1 west build ... and grab any command line compiling a source file, and add -E after <...>/xt-clang to force it into preprocessing mode. You can then take a look at the output file and see which stddef.h is included. This will allow you to look at the stddef.h to see if wint_t has been correctly typedef-ed.

Thank you @dcpleung , we are now trying to fix the issues with the header files.

Closing it for now as this is not an issue in Zephyr. Re-open if needed.


[PE-D][Tester B] Unused "Number of Attempts" line in program's person view

Steps to reproduce:

Navigate to the detailed view of a person in the software.
Observe the "Number of Attempts" line in the person's view, which displays as "Number of Attempts: 0".
Attempt to use the "Number of Attempts" line in the software.
Observe that the line is unused and has no effect on the software.

Expected:
The "Number of Attempts" line in the person's view should be utilized in some way to provide additional functionality or information to the user.
Actual:
The "Number of Attempts" line in the person's view is unused and has no effect on the software.
Issue:
The presence of an unused "Number of Attempts" line in the person's view can be confusing for users and does not provide any additional functionality or information. To improve the software, it is recommended that the "Number of Attempts" line be utilized in some way to provide additional functionality or information to the user. For example, the line could be used to track the number of unsuccessful attempts to contact the person, or to indicate the number of times the person's information has been edited. This will improve the overall usability and user experience of the software.
Screenshot:

Labels: severity.High type.FunctionalityBug
original: Tohtoroo/ped#8

Feature of the number of attempts has been bolded in UG. Highlighted it in screenshot.


Bread's hunger value is double counted

Minecraft Version
1.19.2
Describe the Bug
When adding IguanaTweaksReborn with this mod, the bread's hunger value tweaked by IguanaTweaksReborn is double counted.
Reproduction Steps
1.Config set "iguanatweaksreborn -> common.toml -> ["Hunger & Health"."Food & Drinks"] -> "Food Hunger Multiplier" = 0.5 "
2.Launching the game, found the hunger value of item "minecraft:bread" is "1" instead of "3"
Expected Result
The hunger value of item "minecraft:bread" should be "3" instead of "1".
Screenshots and Videos

Crash Report or Log
No response
Other Mods
Iguana tweaks reborn 2.13.6-mc 1.19.2
Mod Version
1.3.9e
Forge Version
43.2.23

我的意见是他这个mod的issue已经好几个月没人更新和维护了，你等他修还不如去找个人接盘

We didn't modify this in any way.


Research and initial setup for UI

Options:
https://dioxuslabs.com/
https://tauri.app/

#5 Initial setup for UI - Dioxus


ignoreFailure task option does not work

The ignoreFailure option is ignored, in that if a terminal task (nothing waiting on a failed state) fails, we will fail the entire graph rather than respecting ignoreFailure and proceeding normally.
For example:
        {
            label: 'generate-enclosure',
            waitOn: {
                'discovery-graph': 'succeeded'
            },
            taskName: 'Task.Catalog.GenerateEnclosure',
            ignoreFailure: true
        }

Currently workflow with branch cannot finish if it executes in the fail case, like
{
    "friendlyName": "workflow branch",
    "injectableName": "Graph.Branch",
    "options": {
        "when-condition": {
            "condition": "false",
            "when": "{{ options.condition }}"
        }
    },
    "serviceGraph": false,
    "tasks": [
        {
            "ignoreFailure": true,
            "label": "when-condition",
            "taskName": "Task.Evaluate.Condition"
        },
        {
            "label": "noop1",
            "taskName": "Task.noop",
            "waitOn": {
                "when-condition": "succeeded"
            }
        },
        {
            "label": "noop2",
            "taskName": "Task.noop",
            "waitOn": {
                "when-condition": "failed"
            }
        }
    ]

it is because that the task generating failure condition always can be found when determining the graph success state, https://github.com/RackHD/on-core/blob/master/lib/workflow/stores/mongo.js#L622.
I understand the line above fixed the graph finish race condition, and try to use ignoreFailure to bypass this failure state but failed, which makes sense since when searching over codes, I didn't find anything relevant to deal with the "ignoreFailure" parameter, the workflow below is pending as well
{
    "friendlyName": "workflow no branch",
    "injectableName": "Graph.no.Branch",
    "options": {
        "when-condition": {
            "condition": "false",
            "when": "{{ options.condition }}"
        }
    },
    "serviceGraph": false,
    "tasks": [
        {
            "ignoreFailure": true,
            "label": "when-condition",
            "taskName": "Task.Evaluate.Condition"
        },
        {
            "label": "noop1",
            "taskName": "Task.noop",
            "waitOn": {
                "when-condition": "finished"
            }
        }
    ]
}

@benbp Do I miss something? Or is there any plan about it?
I plan to try some solution and wonder whether it might bring any side effect.
in on-core/ib/workflow/stores/mongo.js,
   exports.checkGraphSucceeded = function(data) {
        assert.object(data, 'data');
        assert.uuid(data.graphId, 'data.graphId');

        var query = {
            graphId: data.graphId,
            state: {
                $ne: Constants.Task.States.Succeeded
            },
            reachable: true
        };

        return waterline.taskdependencies.findOne(query)
        .then(function(result) {
            if (_.isEmpty(result)) {
                data.done = true;
            } else {
              // ---------- Find the task entry from waterline.graphObjects  ----------
              // ---------- Set data.done to true if the failure is ignorable  ----------
                data.done = false;
            }
            return data;
        });
    };

@VulpesArtificem to see whether there is anything related

Ticket created in Monorail backlog:
https://www.pivotaltracker.com/n/projects/1492888/stories/129982425

This issue was closed out back in September.


Add component counts to CategoryCard

Subject
CategoryCard
Description
Add component counts to CategoryCard.
Are you willing to participate in the development of this feature and create a pull request?
Yes

Fixed


Question: UUID by default?

@hiattp @citizen428 I like the anonymity of UUIDs when the IDs are exposed in URLs etc. Thoughts on making them default? Can be configured in application.rb like g.orm :active_record, primary_key_type: :uuid + a migration with enable_extension 'pgcrypto'.

I don't have a strong opinion about this other than a general preference for defaults :). It is a nice obfuscation esp for apps at small scale. But it's nice to reference simple numbers when debugging/pulling records up and referencing them in conversation

I'm a bit indifferent on this one. I used to work on a bigger app that used UUIDs and what bothered me most in the long run was having to keep a list of UUIDs handy for e.g. testing on staging, instead of being able to remember that it's entity 37 I'm looking for. Let me throw in some further reading for everyone's perusal:
https://tomharrisonjr.com/uuid-or-guid-as-primary-keys-be-careful-7b2aa3dcb439

I think all of us being indifferent with a concern or two is a reason enough to close this 😄 thanks for the feedback!


examine & remove or incorporate individual c++ test drivers.

specifically lib/ktable_test.cc, lib/bittest.cc, lib/test-{CacheManager,HashTables,Parser,StreamReader}.cc

Dupe of #18, closing


Fix interest accrual and improve goal completion logic

This commit resolves issues with interest calculation by updating the startInterestIndex when deposits are made and adjusting the logic for accruing interest. It also refines the goal completion check to allow deposits greater than the target amount, ensuring smoother handling of interest compounding over time.

Thanks for the assistance @craig-iam-smith!


Breaking change in Google Play API

I've created a PR that fixes the issue with the updated Google API. See #2

merged


correct expire example date calc

according to
https://github.com/RobinCK/vue-ls/blob/6f05098bdbc9b0cede4f23f6cfd5514a8dcd6edf/dist/vue-ls.js#L176-L195
the expire should be in seconds in not in milli

Coverage remained the same at 100.0% when pulling 9781c2fa28a09f6e39165ee6dc8845424337892d on ctf0:patch-2 into 6f05098bdbc9b0cede4f23f6cfd5514a8dcd6edf on RobinCK:master.


UI halt when moving to different browser tab

Hello!
I have notice that while uploading via the plugin, if I go to another tab and then come back after some time, the upload stopped the moment I went to another tag and resume as soon as I went back.
I can see this issue was happening in the past looking at closed ticket #239.
I am using I am using the last version 4.11.0 of plugin and it is happening in Chrome and Edge.
Does anyone also see this? maybe after a recent change, the issue is happening again?
Thanks.

Hi, thanks for reporting, please use the closed issue. Will reopen if confirmed.
Latest is 4.13


[Site Request] Add support for Novinky.cz

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2022.09.01 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Czech Republic (should not be restricted)
Example URLs

Interview video (after 2 initial commercials that could be sometimes skipped after a few seconds) at https://www.novinky.cz/clanek/podcasty-hlas-semira-gerchana-slysite-v-televizi-skoro-kazdy-den-aniz-byste-o-tom-vedeli-40407886
Other interviews from in this series https://www.novinky.cz/sekce/podcasty-v-ceskem-zneni-363
server Novinky.cz provides also other stream videos as well...

Provide a description that is worded well enough to be understood
I standardly used yt-dlp via macOS terminal "yt-dlp URL" (if not DRM)
My-iMac:~ iMac$ yt-dlp --version
2022.09.01
My-iMac:~ iMac$ yt-dlp https://www.novinky.cz/clanek/podcasty-hlas-semira-gerchana-slysite-v-televizi-skoro-kazdy-den-aniz-byste-o-tom-vedeli-40407886
[generic] podcasty-hlas-semira-gerchana-slysite-v-televizi-skoro-kazdy-den-aniz-byste-o-tom-vedeli-40407886: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] podcasty-hlas-semira-gerchana-slysite-v-televizi-skoro-kazdy-den-aniz-byste-o-tom-vedeli-40407886: Extracting information
ERROR: Unsupported URL: https://www.novinky.cz/clanek/podcasty-hlas-semira-gerchana-slysite-v-televizi-skoro-kazdy-den-aniz-byste-o-tom-vedeli-40407886
My-iMac:~ iMac$
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
My-iMac:~ iMac$ yt-dlp -vU
[debug] Command-line config: ['-vU']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.09.01 [5d7c7d6] (pip)
[debug] Python 3.10.6 (CPython 64bit) - macOS-11.6-x86_64-i386-64bit
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 5.1 (setts), ffprobe 5.1
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Loaded 1670 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.09.01, Current version: 2022.09.01
yt-dlp is up to date (2022.09.01)

It appears that this site uses a custom video player by Seznam, a Czech internet services company.
If someone can put in the effort, it may be worth adding to the generic extractor.

I am afraid that this did not bring any attention

I believe this would need to be integrated into the SeznamZPravy extractor(s), which are also currently broken: https://github.com/yt-dlp/yt-dlp/issues/5003
There seems to be a whole range of sites related to Seznam that appear to all share the same underlying video handling.

If someone can put in the effort, it may be worth adding to the generic extractor.

I agree (well, a generic seznam extractor). Orif that is not possible, maybe a seznam extractor that seznam related sites with custom extraction handling pass the video extraction off to (similar to Kaltura etc.).

As i have mentioned, I am afraid that this did not bring any attention :-(


crossplane-cli: 1.14.3 -> 1.14.4

crossplane-cli: 1.14.3 -> 1.14.4
Release: https://github.com/crossplane/crossplane/releases/tag/v1.14.4
Changelog: https://github.com/crossplane/crossplane/compare/v1.14.3...v1.14.4

Add version test

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1334


Command-line add default location 'filesystem:sql'

Which version and edition of Flyway are you using?
Flyway Community Edition 6.4.1 by Redgate
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Command-line
Which operating system are you using?
macOs
What did you do?
I've installed flyway by homebrew brew install flyway
Then I execute flyway migrate -url=... -user=... -password=... within my project directory.
project structure

project-name

sql
...
However I got the error message WARNING: No migrations found. Are your locations set up correctly?
This is because the default location sql is relative to flyway executable.
I need to add following parameter to make it work  -locations='filesystem:sql'

What did you expect to see?
I would expect that the default lookup location is relative to execution path as basically ever other cli does like maven or gradle.
My suggestion is to add filesystem:sql as a default location
or maybe even better filesystem:migrations

Fair point, although FYI the Homebrew package is a third party integration. We haven't thought about the setup experience for Homebrew users.

I think in general it is quite common to install executables in some bin directories. And even when in install it manually I'd like to be able to move it to a global directory /bin or /usr/local/bin or /usr/bin. I'd like to use the flyway command for every project with its own sql or migrations folder.

So I would looking forward to have this feature. maybe 3 default locations

classpath:sql(for backward compatibility)
filesystem:sql(for support current folder name)
filesystem:migrations(for a more descriptive folder name)

This feature is now available in the V7 beta which you can read more about here.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #446 (e5d4aae) into main (2664cfa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


New installer

The code for the original installer has seemingly been lost, so I will need to write a new one.

Setup Factory 6.0 Installation Log
==================================
Date/Time: 17-Feb-23  11:22:29 PM

[Displaying Before Installing Screens]
Displaying screen: Welcome
Displaying screen: Install Folder Aodix Sequencer
Displaying screen: Select Shortcut Group for Aodix
Displaying screen: Proceed to Install

[Performing Actions]
START: Perform action: Modify Registry
Registry action = Set Value
Main key = HKEY_LOCAL_MACHINE
Sub key = Software\Arguru Software\Aodix
Value name = Installdir
Value type = REG_SZ
Value data = C:\Program Files (x86)\Arguru Software\Aodix
(On Error) User notification mode = None
(On Error) Action = Continue
Result = 0
END: Perform action: Modify Registry
START: Perform action: Modify Registry
Registry action = Set Value
Main key = HKEY_CLASSES_ROOT
Sub key = .adx
Value name =
Value type = REG_SZ
Value data = Aodix.Document
(On Error) User notification mode = None
(On Error) Action = Continue
Result = 0
END: Perform action: Modify Registry
START: Perform action: Modify Registry
Registry action = Set Value
Main key = HKEY_CLASSES_ROOT
Sub key = Aodix.Document\shell\open\command
Value name =
Value type = REG_SZ
Value data = C:\Program Files (x86)\Arguru Software\Aodix\aodix.exe "%1"
(On Error) User notification mode = None
(On Error) Action = Continue
Result = 0
END: Perform action: Modify Registry
START: Perform action: Modify Registry
Registry action = Set Value
Main key = HKEY_CLASSES_ROOT
Sub key = Aodix.Document\DefaultIcon
Value name =
Value type = REG_SZ
Value data = C:\Program Files (x86)\Arguru Software\Aodix\aodix.exe,0
(On Error) User notification mode = None
(On Error) Action = Continue
Result = 0
END: Perform action: Modify Registry

[Installing from Archive]
C:\Program Files (x86)\Arguru Software\Aodix\Aodix.exe (Installed)
C:\Program Files (x86)\Arguru Software\Aodix\Aodix.chm (Installed)
C:\Program Files (x86)\Arguru Software\Aodix\Skins\Blue\gfx.bmp (Installed)
C:\Program Files (x86)\Arguru Software\Aodix\Skins\Blue\gui.bmp (Installed)
C:\Program Files (x86)\Arguru Software\Aodix\Skins\Blue\knb.bmp (Installed)
C:\Program Files (x86)\Arguru Software\Aodix\Skins\Night\gfx.bmp (Installed)
C:\Program Files (x86)\Arguru Software\Aodix\Skins\Night\gui.bmp (Installed)
C:\Program Files (x86)\Arguru Software\Aodix\Skins\Night\knb.bmp (Installed)

[Installing External]

[Register Fonts]

[File Registration]

[Uninstall]
C:\WINDOWS\iun6002.exe C:\Program Files (x86)\Arguru Software\Aodix\uninst.ini

[Program Icons]
C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Arguru Software\Aodix\Aodix.lnk
C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Arguru Software\Aodix\Aodix Help.lnk

[Displaying After Installing Screens]
Displaying screen: Installation Finished

Setup completed normally.

Added in ffb060e4320f699e88d78a1b3c4a44a4ebb7e2f3