Modal will autoclose with an opened Portal

Steps

Create a <Modal /> with an onClose prop  and a <Portal />.
Keep opened <Portal />.
Open <Modal />.

Expected Result
Modal should open.
Actual Result
Modal never will open. Modal uses Portal as a wrapper if I understand clearly. click event listener subs to all open modals and portals and pass through all of them. Since didClicknRootNodeClick has been changed here, <Modal /> handles a click in handleDocumentClick and recognizes it as click on dimmer. Everything is ok if <Modal /> will be without dimmer or <Modal />'s content will be right under a click point.
Version
0.77.2
Testcase
https://codesandbox.io/s/9y3wzpyjky

Is it related to this https://github.com/Semantic-Org/Semantic-UI-React/issues/2493 ?

Yes, this sounds like it is duplicated in #2493.  See workarounds there.  A fix is in the works.

I am releasing 0.78.1 right now with a proposed fix for this.  Once it is live (~10 minutes), please update the codesandbox, try it, and report back.

Confirmed worked.  Forked codesandbox here: https://codesandbox.io/s/328x7n20ym.  I only needed to update to the latest 0.78.1 to get the fix.
Thanks for the reporting folks!

@levithomason it works for me too. Thank you for your work!

@levithomason seems like the issue is reproduced when the content of modal is changed. https://codesandbox.io/s/30n2v379r1 here is the example when changing one form with another - onClose is fired, it's important that the second form has more inputs, so markup very is different. Of course, workarounds are possible, but still.

more info https://stackoverflow.com/questions/50712568/how-to-keep-semantic-ui-modal-from-closing-when-displaying-different-components/50716937#50716937
if you ask, we can create a separate issue

opened #2888


Set up demo markov bot

Clean up & move minimal code from codebro-bot repo into this repo, for the purpose of demonstrating basic markov response code

The bot can be minimally started in a local server; instructions are included in the repo now.


How to use matrix operations to represent code logic？ Can you provide some reference materials

I am not sure I understand the question. Can you please elaborate?


AI refactoring

Pull Request Test Coverage Report for Build 2695
Details

6 of 8 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 86.914%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

string/string.mbt
6
8
75.0%

Totals

Change from base Build 2694:
-0.03%

Covered Lines:
3726

Relevant Lines:
4287

💛  - Coveralls


a simple way to add to a validations array

Need a way to add a new row to a validation.
Currently if i want to add a new entry in the validations array, the code looks like this:
dynamicContentRowType.editField(     'contentEntry',     {       "name": "Content entry",       "type": "Array",       "localized": false,       "required": true,       "validations": [],       "disabled": false,       "omitted": false,       "items": {         "type": "Link",         "validations": [           {             "linkContentType": [               "type0",               "type1",               "type2",               "type3",               "type4",               "type5",               "type6",               "type7",               ...               "type50" //you get the picture!             ]           }         ],         "linkType": "Entry"       }     }
This cumbersome syntax makes it tricky to keep track of what the change actually was and hard to debug. So the ideal scenario would be:
dynamicContentRowType.editField('contentEntry').items.addValidation('type55');

Here's my migration script for adding a new allowed link, would be great if there was a built in one-liner for this:
module.exports = async (migration, { makeRequest }) => {

    // Settings
    const typeName = 'contentPage',
        linkingField = 'contentBlocks',
        newlyAllowedType = 'marquee'

    // Get the list of current linkContentType values
    const schema = await makeRequest({
        method: 'GET',
        url: `/content_types?sys.id[in]=${typeName}`
    })

    // Add marquee to the list of allowed content types
    const validations = schema.items[0].fields
        .filter(field => field.id == linkingField)[0]
        .items.validations.map(rule => {
            if (rule.linkContentType &&
                !rule.linkContentType.includes(newlyAllowedType)) {
                rule.linkContentType.push(newlyAllowedType)
            }
            return rule
        })

    // Update the link validation
    migration.editContentType(typeName)
        .editField(linkingField).items({
            type: 'Link',
            linkType: 'Entry',
            validations: validations,
        })
};

Has this functionality been added to the Contentful Migration API?
I second this would be a nice to add or remove contentTypes to the validation rule in a more straightforward way.

Want to bump this issue up as well! This is the first GitHub issue coming up in google search result. We also have this use case of removing/adding a type to validations linkContentType. Is there any update on this issue?
I have yet to find similar functionality in the Contentful doc: Content type / Validations. Currently the doc seems to suggest hardcoding the list of validations linkContentType. This could be hard to keep track of and maintain as the list item changes over time by multiple places:

To remove a specific validation, update the content type leaving that validation out of the field's validations collection. To remove all the validations applied to a field, update the content type schema removing the validations property.

Seems unfortunately https://github.com/contentful/contentful-migration/pull/66 @thebiglabasky mentioned is determined not merged in at the end. I thought this functionality of only needing to specify the type to be added/removed would be a fairly common use case and should benefit many other Contentful SDK users.

This ticket has been closed due to inactivity. If you still need help resolving your issue, please reach out through our community Slack, or contact Contentful support directly.


[Event Request] Codeunit 1000 - "Job Calculate WIP" - OnCaclWIPOnAfterSetAmounts

Dear ALAppExtensions team,
through this issue we would like to request adding a new event publisher OnCaclWIPOnAfterSetAmounts in Codeunit 1000 "Job Calculate WIP" with the following signature:
[IntegrationEvent(false, false)]
local procedure OnCaclWIPOnAfterSetAmounts(var JobTask: Record "Job Task")
begin
end;

which would be called as follows in CalcWIP:
local procedure CalcWIP(var JobTask: Record "Job Task"; JobWIPTotal: Record "Job WIP Total")
var
    JobWIPMethod: Record "Job WIP Method";
begin
    if JobComplete then begin
        JobTask."Recognized Sales Amount" := JobTask."Contract (Invoiced Price)";
        JobTask."Recognized Costs Amount" := JobTask."Usage (Total Cost)";
        // >>>> New >>>>>>>>>>>>>>>>
        OnCaclWIPOnAfterSetAmounts(JobTask);
        // <<<< New <<<<<<<<<<<<<<<<
        exit;
    end;
    JobWIPMethod.Get(JobWIPTotal."WIP Method");
    CalcRecognizedCosts(JobTask, JobWIPTotal, JobWIPMethod);
    CalcRecognizedSales(JobTask, JobWIPTotal, JobWIPMethod);
end;

Thanks in advance!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10804.


fix: transaction with same nonce

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


Request APIs to implement command line completion

Want to implement something like this:

It is possible now to display a completion popup window, but still lack of APIs to:

read content from current command line buffer.
modify command line buffer.
method to call the completion functions for each command.

command line completion is helpful to input filenames or command parameters.
It is impossible to implement without these APIs above.

getcmdline()
use feedkeys(), setcmdpos()
getcompletion()

Is there a possibility of having a popup analogous to the 'wildmenu'?

Is there a possibility of having a popup analogous to the 'wildmenu'?

do you want a popup or wildmenu?
@skywind3000 please describe clearly what you think is missing, else it looks like it could already be implemented.

I am using wildmenu now, but I think a popup for cmdline completion is more handy.

Is there a possibility of having a popup analogous to the 'wildmenu'?

do you want a popup or wildmenu?
@skywind3000 please describe clearly what you think is missing, else
it looks like it could already be implemented.

There is an item in the todo list that is related:

Use popup (or popup menu) for command line completion

Currently there is 'wildmenu', but it only shows few matches.  Using a
popupmenu for that would be nicer.  A complication is that when the
command line has scrolled, redrawing the text under the menu might be
complicated.
--
I wonder, do vegetarians eat fruit bats?
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

How about @h-east's CLPUM (Command-Line mode PopUp Menu)?

neovim's behavior:

before cmdline scroll:

the filename is too long and makes cmdline scroll and resize to 2 lines:

choose a short file name, it shrinks:

when you made your selection, the cmdline restores to 1 line:

@k-takata , that's cool:

but requires a patched vim:

Hi @brammool , is it possible to just include this patch ?

CLPUM is currently unable to follow Vim's head.
We need to change to an implementation that uses popup-window inside Vim.

@h-east any progress on that

@h-east, expecting your patch or plugin all the time.

@brammool +1

There is an item in the todo list that is related: - Use popup (or popup menu) for command line completion Currently there is 'wildmenu', but it only shows few matches.

This would be a more intuitive feature to have.


Skip if tag value is empty or set to true

Description
Fixes #822, change the exclude by tag behaviour to allow matching by an empty tag value.
TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.
[ ] Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)
change the exclude by tag behaviour to allow matching by an empty tag value, fix #822.
Migration Guide
n/a

I suggest changing the existing behavior slightly: if the exclusion tag has no value, we should assume the tag itself indicates that the resource should be excluded. If a value is present, we should check whether it is set to "true."

Agreed, this simplifies the whole logic quite a lot.

https://github.com/gruntwork-io/cloud-nuke/issues/822#issuecomment-2562274489 - To accommodate this, we could introduce a TagValue property within the FilterRule. The TagValue could default to true, be set to a specific value being targeted, or use *, indicating that it can match any value.
How does this sound?

#822 (comment) - To accommodate this, we could introduce a TagValue property within the FilterRule. The TagValue could default to true, be set to a specific value being targeted, or use *, indicating that it can match any value.
How does this sound?

I added tag_value to the configuration as a regular expression, primarily because there is already a matches(name string, regexps []Expression) bool function.
The original request should now be easy to address using this configuration. cc: @ErezWeiss
s3:
  exclude:
    tag: Component
    tag_value: .*

@james03160927
@wakeful
it seems amazing.
Can we proceed?

@james03160927 thank you.
Can you guys build a version for it?


Help users avoid bad UX having to type https://

Summary
When users are on-boarding, every one of them has issues with the server URL, because they don't expect to have to enter http:// or https://
Expected behavior
Have the app accept server URLs without having to specify https:// or http://, it should know how to handle them and try the appropriate alternative in case the initial assumption fails.
Observed behavior
Users are being precise with the server name and the app tells them they have something wrong when they do not.
Possible fixes
Improve input handling at server textbox and checks for the right protocol.

Closing via feature request issue: https://mattermost.uservoice.com/forums/306457-general/suggestions/36845176-desktop-app-don-t-require-http-or-https.

Has this been implemented or just closed? It's not clear.

We're moving feature requests to Uservoice (e.g. the one that I opened above https://mattermost.uservoice.com/forums/306457-general/suggestions/36845176-desktop-app-don-t-require-http-or-https) and bugs are moved to Jira (but we'll leave bug reports open in Github until the issue is fixed).

ok, thank you.
++ Rob
About me https://remote.com/r
On Wed, Feb 13, 2019 at 11:57 PM amyblais<EMAIL_ADDRESS>wrote:

We're moving feature requests to Uservoice (e.g. the one that I opened
above
https://mattermost.uservoice.com/forums/306457-general/suggestions/36845176-desktop-app-don-t-require-http-or-https)
and bugs are moved to Jira (but we'll leave bug reports open in Github
until the issue is fixed).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/desktop/issues/865#issuecomment-463425793,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AClFXSmpiwvqvulrDhxqB_I5dhvC__KWks5vNKZpgaJpZM4W3Kk6
.

In my opinion that request is important. Mattermost should automatic suggest https.
Only if https works in no way, inluding selfsigned certificate, it should warn and allow only after approofing to use http.


Change MapLayerImageryProvider.supportsMapFeatureInfo from alpha to public

This getter is needed in @itwin/map-layers package of viewer-components-react to show the map feature info tool only when a provider is registered to support it.

@Mergifyio backport release/4.8.x


Text strings must be rendered within a  component

Hi All, it is same problem someone had posted earlier but didn't got any response.
Can some please help me out on this ?
Regards
Qamar
Invariant Violation: Invariant Violation: Text strings must be rendered within a  component.
This error is located at:
in div (created by PaypalButton)
in PaypalButton (created by ScriptLoader)
in ScriptLoader (at Cart.js:20)
in RCTView (at View.js:45)
in View (at Cart.js:19)
in Cart (at SceneView.js:9)
in SceneView (at createTabNavigator.js:39)
in RCTView (at View.js:45)
in View (at ResourceSavingScene.js:37)
in RCTView (at View.js:45)
in View (at ResourceSavingScene.js:26)
in ResourceSavingScene (at createBottomTabNavigator.js:121)
in RCTView (at View.js:45)
in View (at screens.native.js:83)
in ScreenContainer (at createBottomTabNavigator.js:111)
in RCTView (at View.js:45)
in View (at createBottomTabNavigator.js:110)
in TabNavigationView (at createTabNavigator.js:197)
in NavigationView (at createNavigator.js:61)
in Navigator (at createAppContainer.js:429)
in NavigationContainer (at App.js:14)
in RCTView (at View.js:45)
in View (at App.js:12)
in App (at withExpoRoot.js:20)
in RootErrorBoundary (at withExpoRoot.js:19)
in ExpoRootComponent (at renderApplication.js:35)
in RCTView (at View.js:45)
in View (at AppContainer.js:98)
in RCTView (at View.js:45)
in View (at AppContainer.js:115)
in AppContainer (at renderApplication.js:34)

Any update?

Any update ?


kernel not connect julia 1.0.1

i installed julia 1.0.1
and in notebook said kernel error not connect
and this is description
Traceback (most recent call last):
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\web.py", line 1592, in _execute
    result = yield result
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 1133, in run
    value = future.result()
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 1141, in run
    yielded = self.gen.throw(*exc_info)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\notebook\services\sessions\handlers.py", line 73, in post
    type=mtype))
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 1133, in run
    value = future.result()
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 1141, in run
    yielded = self.gen.throw(*exc_info)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\notebook\services\sessions\sessionmanager.py", line 79, in create_session
    kernel_id = yield self.start_kernel_for_session(session_id, path, name, type, kernel_name)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 1133, in run
    value = future.result()
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 1141, in run
    yielded = self.gen.throw(*exc_info)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\notebook\services\sessions\sessionmanager.py", line 92, in start_kernel_for_session
    self.kernel_manager.start_kernel(path=kernel_path, kernel_name=kernel_name)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 1133, in run
    value = future.result()
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\tornado\gen.py", line 326, in wrapper
    yielded = next(result)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\notebook\services\kernels\kernelmanager.py", line 148, in start_kernel
    super(MappingKernelManager, self).start_kernel(**kwargs)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\jupyter_client\multikernelmanager.py", line 110, in start_kernel
    km.start_kernel(**kwargs)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\jupyter_client\manager.py", line 259, in start_kernel
    **kw)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\jupyter_client\manager.py", line 204, in _launch_kernel
    return launch_kernel(kernel_cmd, **kw)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\site-packages\jupyter_client\launcher.py", line 128, in launch_kernel
    proc = Popen(cmd, **kwargs)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\subprocess.py", line 709, in __init__
    restore_signals, start_new_session)
  File "C:\Users\varie\.julia\packages\Conda\m7vem\deps\usr\lib\subprocess.py", line 997, in _execute_child
    startupinfo)
FileNotFoundError: [WinError 2] El sistema no puede encontrar el archivo especificado

If you run build IJulia at the pkg prompt does it succeed?

Facing same kind of issue with successful pkg>add IJulia and pkg>build IJulia and >using IJulia under julia console.
The websocket connection to julia-1.1.0 kernel always timeout in browser...
I had set ENV["IJULIA_DEBUG"]=true before build IJulia
how can i find logs to trace the issue? thanks

A FileNotFoundError usually means that you moved your Julia installation and need to re-run build IJulia …
@mindon, it sounds like your issue is different.  Does the Python kernel work for you?

@mindon, it sounds like your issue is different, since you are reporting a timeout. Does the Python kernel work for you?

Python kernel and another R kernel are both working well

Sounds resolved?


set default security.auth.server.address regardless of ssl setting

https://github.com/caskdata/cdap_cookbook/commit/726a1dfd075a5e88d9f6d46ab5e011bb9b0e66ef changed the default behavior, where default['cdap']['cdap_security']['security.auth.server.address'] = node['fqdn'] used to be set by default, it is now only set if ssl.enabled is true.  However it shouldn't depend on SSL.
This PR sets the default if security.enabled is true.

:+1: LGTM

One more minor fix needed.  The relevant property is default['cdap']['cdap_site']['security.auth.server.address'] instead of default['cdap']['cdap_security']['security.auth.server.address'], as this property goes in cdap-site.xml.
Also, added a test-case for this.

Cool. :+1:


MP? for "lung ciliated cell differentiation"

Hi Paola
I was surprised to see that "lung ciliated cell differentiation" (GO:0061141) does not have a relationship to "multi-ciliated epithelial cell differentiation" (GO:1903251).
I see in the definition of "lung ciliated cell differentiation" that it says "a motile cilium". However, I am under the impression that lung epithelial cells, as with other types of epithelial cells that are involved in moving fluids, are multiciliated cells.
term: "lung ciliated cell differentiation"
Def: The process in which a relatively unspecialized cell acquires specialized features of a lung ciliated cell. A lung ciliated cell is a specialized lung epithelial cell that contains a motile cilium for moving substances released from lung secretory cells.
Not urgent for me, but probably worth checking on.
thanks,
-Karen
@paolaroncaglia

CL:1000271 ! lung ciliated cell
  is_a [CL:0000000](http://purl.obolibrary.org/obo/CL_0000000) ! cell
   is_a [CL:0000003](http://purl.obolibrary.org/obo/CL_0000003) ! native cell
    is_a [CL:0000064](http://purl.obolibrary.org/obo/CL_0000064) ! ciliated cell
     is_a [CL:1000271](http://purl.obolibrary.org/obo/CL_1000271) ! lung ciliated cell

looks like the incompleteness is on the side of CL. Can you file here: https://github.com/obophenotype/cell-ontology/issues
thanks

CL issue is here: https://github.com/obophenotype/cell-ontology/issues/432
GO definition may still need revision.
-Karen

Hi @krchristie ,
I commented on the CL ticket to see if any of the editors there can take a look.
In the meantime, I modified the def of "lung ciliated cell differentiation" (GO:0061141) to reflect the multi-ciliated nature:
"...A lung ciliated cell is a specialized lung epithelial cell that contains cilia for moving substances..."
When the CL issue is dealt with, I will fix the parentage of "lung ciliated cell differentiation" (GO:0061141). In the meantime, I'll set to pending.

I followed up on the CL ticket again.

I'm monitoring the CL ticket, so I'll be alerted if and when that is taken care of, and I can do the GO edits then. Closing this ticket for now.


Q5a. Delete question.

This will be a difficult one @hkalyn. Unfortunately, I implemented logic for Q5 that takes you either to Q5a or 5b de (or both) depending on the response you gave for 5. This might be one of the more challenging requests, but should be doable.

Unfortunately, this question format is just too confusing for participants. I'm sorry I didn't realize this sooner, but I think our best option is to remove the drill down (5A and 5C) and create one question from 5B.

Drill down mechanic has been removed.


Can't use the library after following all the instalation procedure

Hello
I have installed the library and all the dependencies mentioned on my MacPro (expat and libzip). I am trying to do a simple test
#include <stdio.h>
#include "xlsxio_read.h"

int main(void){
    const char* filename = "WELL_DATA.xlsx";
    xlsxioreader xlsxioread;
    xlsxioread = xlsxioread_open(filename);
    if ((xlsxioread = xlsxioread_open(filename)) == NULL) {
        fprintf(stderr, "Error opening .xlsx file\n");
        return 1;
    }
    return 0;
}

and compile it this way: gcc file_name.c -o output
And I get the following message:

Undefined symbols for architecture x86_64:
"_xlsxioread_open", referenced from:
_main in test-383c3d.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I hope anyone can help me with this.
Thx in advance

Were you able to solve this?

The linker error makes sense as the build command doesn't link with the library.
The -lxlsxio_read linker flag should be added the build command.


Add confirmation tooltip for copying Zulip version in "About Zulip"

At present, there is no confirmation when copying the Zulip version in the "About Zulip" modal, which is disorienting for users. We should add a "Copied!" Tippy tooltip, similar to our "Saved as draft" notice.
This should be done for both copy buttons ("Version..." and "Forked from...").
Related issue: #21036

@zulipbot claim

I am afraid I have had some circumstances in my real life that have to take priority over this. Abandoning this issue for now, hopefully someone with the time can work on it. Best of luck.

@zulipbot abandon

@zulipbot claim

@zulipbot claim

Hey there!
This is my first time trying to contribute to this (or any) project. I have code that implements this feature, I still need to read some stuff to make sure on the guidelines before creating a PR, but I see this one is already claimed, should I wait or just try a different issue?

@manzha You can go ahead and submit your PR when it's ready, if you've ended up figuring out the code, and @kayabhandari can help review. Thanks!

Thanks @alya
I just created my first PR, I'll wait for the pipelines to run in order to check if I missed something and then for someone to review it. Thanks in advance to anyone who reviews it

@zulipbot claim

Hi, this is my first time contributing to a project and I need to get it done urgently. Can I work on this with someone?

Claim

@zulipbot Claim

@zulipbot claim

@alya
This issue is still open, right? I've claimed it and just wanted to be clear as I see some PRs and claims by previous Contributors

@zulipbot claim

@zulipbot abandon

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot  abandon

is this issue still need to be resolved? Please let me know someone. I want to work on this.

If an issue is open, that means it's not resolved. However, you should always check to see if there are open PRs. For exampe, in this case, the best way to help is by reviewing #23395, as @Joelute did recently.

@zulipbot claim

@alya Can you review my PR, please

As @amanagr mentioned in #23395,

We should wait for https://github.com/zulip/zulip/pull/23929 to get merged since they have the similar code, I think getting it merged will make this simpler.

I do think your solution is a good one.

@alya What are you waiting for?. You can merge my PR to fix about version tooltip bug.

Hi @iSatVeerSingh @alya, I don't know if you guys saw but I posted a comment on PR #23395 with a suggestion of how this can be improved. Please let me know what you think about it.

@zulipbot claim


fix(package.json): reviewed package name from rtldev-middleware-go-sdk to go-sdk for go packagist

:tada: This PR is included in version 4.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Play Services 9 Support

Changing build.gradle to

remove unnecessary dependency
update version to support google play services 9

hi @w0nche0l thanks for the PR


Inconsistency between macvim and vim in :redir result

Steps to reproduce
touch a.txt && echo "Some text" > a.txt
In VIM
2. vim -u NONE
3. :redir > result.txt
4. :!cat a.txt
5. redir end
In MacVim
2. New clean window
3. - 5. Similar steps
Expected behaviour
Content of a.txt should appear in result.txt in both MacVim and Vim. But it only appear when I tried with MacVim.
I expect vim to redir the command output as well which it doesn't. I'm not sure if this is a bug so please let me know, I will close the ticket if it's not.
Version of Vim
Vim 9.1 with 1-457 patch. MacVim r179 (Vim 9.1.0)
Environment
MacOS, iterm2, zsh
Logs and stack traces
No response

Not sure, this might be a bug or not, but :redir is really meant to redirect VIM messages, not whatever you echo on your terminal. In addition, the terminal might be switching screens which could matter here (although I still see the same issue when disabling it) and of course the various shell options.
However, you should use a proper method to get shell output, not :redir, use systeml(), systemlist(), or use shell redirection properly.

Thanks! Indeed redir is not a right command for this. Closing this for now.


bug: prepare-commit-msg does not work

I have created in hooks folder prepare-commit-msg file and pre-commit file.
pre-commit file is set in git hooks but prepare-commit-msg is not.

Fixed. Please try it :)


mocha-runner: Add support for test's fileName

Mocha support filenames, see: https://github.com/mochajs/mocha/commit/3dd1cdbb695f0489e03171c0874f4ccfb7347893
I plan to use it as my plugin.
I tried to write tests based on jest-runner tests from #2808 but I'm lost in the test code.
I'm interested in getting this PR merged so would be grateful if someone adopts this PR and write missing tests.

Hi @IvanGoncharov 🙋♂
This is actually pretty awesome! I didn't even know this feature was added, it seems to be missing from the changelog
Adding this file is a nice first step, however, it probably needs some more love. I think we should add automatic source map resolution.
I'll try to find some time to test this out and see how it works without sourcemap. If it can already deliver some value I'll merge this and work on sourcemaps in another branch.

Interesting! This is what Stryker makes of it:

As you can see it kind of works. For Stryker it shows the *.js files instead of the source files, as expected. The tests are shown in one big list since the location inside the file is missing.
I personally think this is already adding value. What do you think @IvanGoncharov?
(report here: mutation.zip)

I personally think this is already adding value. What do you think @IvanGoncharov?

@nicojs yes, it adds value for me.
Actually, I want to share context on what I'm currently doing and maybe you can suggest some additional tips.
I recently adopted stryker on https://github.com/graphql/graphql-js and we got 90% mutant coverage 🎉
Ideally, I like to run it for every PR but currently, it takes between 3 and 5 hours for a complete run.
So I like to try an optimization strategy based on the test structure in our project.
We have __tests__ dir in every folder with source code.
So I want to try optimization where I sort tests based on how likely they are to kill the mutant.
So if I have mutant for source file src/foo/bar.ts here is a priority for tests based on their source file:

src/foo/__tests__/bar-test.ts
src/foo/__tests__/*-test.ts
src/**/__tests__/*-test.ts

I'm betting on the fact that most of the mutants will be killed by src/foo/__tests__/bar-test.ts which mean only a few dozens of test gets run per mutant.
It looks like MutantPlanner has all the necessary info.
MutantPlanner also has access to execution time for every test so I want to try the second assumption "it's better to run faster tests first". So I first want to sort tests by execution speed and later sort them based on file path (as shown above).
Currently, my biggest problem is that mocha doesn't allow you to sort tests and only allows you to filter them using RegExp without changing their order :(
Not sure, if those experiments will work or how useful for other projects they will end up.
But I'm slowly working on it as a hobby project with a plan to upstream stuff that makes sense in a core.

Yeah, test sorting would be a nice performance boost for some projects. It would need an implementation specific to each test runner, bringing a big maintenance overhead. And most test runners don't support a custom order (I think jasmine and jest are the only ones).

I'll try to get this PR merged today. For the sorting of tests, feel free to open a separate issue. We could implement it for test runners that support it.
For jest, we could create a custom sequencer
https://jestjs.io/docs/configuration#testsequencer-string

Example of the clear-text reporter output:
All tests
  Add.spec.js
    ✓ Add should be able to add two numbers (killed 2)
    ✓ Add should be able 1 to a number (killed 2)
    ✓ Add should be able negate a number (killed 2)
    ✓ Add should be able to recognize a negative number (killed 5)
    ✓ Add should be able to recognize that 0 is not a negative number (killed 3)
  Circle.spec.js
    ✓ Circle should have a circumference of 2PI when the radius is 1 (killed 2)
  IsEven.spec.js
    ✓ isEven should be false for 1 (killed 5)
    ✓ isEven should be true for 2 (killed 3)
  ninjaCat.spec.js
    ✓ 🐱👓 ninjaCatSays should speak (killed 2)


Updated mmctl channel delete requirements

Updated mmctl channel delete documentation to clarify that Enable API Channel Deletion config setting must be enabled. Removed note in configuration setting documentation about local mode ignoring this setting.
Update for issue #5466

Hello @glennschler,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm Should I submit this PR again to the v6.6documentaion branch instead of this branch?

If you're able to submit this PR against the v.6.6-documentation branch, that would be great!

@cwarnermm I submitted a new PR to mattermost:v6.6-documentation from my fork. I hope that helps. Let me know if I should do something to merge into master

Closing.


Allow filtering builds by event

A user can now pass &event=cron|push|pull_request|...
The WHERE condition is built like ('' = :build_event OR build_event = :build_event) to allow the same query to be used when an event is specified and when it isn't (empty string)
As such, the List and ListRef methods were also merged into one using the same pattern
This is done to support https://github.com/drone/drone-ui/pull/356. I know that the support of filtering was riding on the implementation so this PR can serve as a discussion base
Let me know what you think of this

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I recommend using a query builder here instead:
var buf strings.Builder
buf.WriteString(queryBase)
buf.Writestring("FROM builds WHERE build_repo_id = :build_repo_id")
if params.Event != "" {
  buf.WriteString("AND build_ref = :build_ref")
}
buf.WriteString(`ORDER BY build_id DESC LIMIT :limit OFFSET :offset`)

And modifying the signature so we have more flexibility in the future to add more filtering criteria:
func (s *buildStore) List(ctx context.Context, repo int64, opts core.BuildListOpts) ([]*core.Build, error)

Hey @julienduchesne, thanks for your contribution. I'm going to work on the changes that @bradrydzewski suggested. I'm going to build them on top of your commit. When I'm done I'll create a new pull request.


Issues with the Procedural Rock Texture Generator Example

Thanks for making the examples. like to report some issues I run into with the rock texture examples.

The Image Perlin Noise Filter node seems missing. I replaced them with 'Image Perlin Noise' node. Some parameters are different from the screenshot. There is no 'shape' and 'density' but 'scale' and 'persistence'. Are these just name changes?
After replacing that, got Prompt outputs failed validation Image High Pass Filter: - Required input is missing: images.
But that node is connected to the Image Blending Mode. And if the Image High Pass Filter is skipped, the process can run and finish.

Replace the high pass filter, it now supposed "Images" rather then a single image. So it can do batches of tensors. Noise filters were revamped and expanded upon to be more memory efficient. The previous method could fill RAM way to easily at low resolution.


router: set upstream host from the conn pool

Commit Message: router: set upstream host from the conn pool
Additional Description:
The host() method of connection pool will return a host in current implementation. We can set the host at constructor of UpstreamRequest and needn't to wait the pool callbacks.
Considering a scenario like this, if the request is timeout before any pool callbacks are called, then the upstream host will never be set and we can even cannot know which host is selected for this request from the access log.
Risk Level: mid, core logic change.
Testing: wait.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

/wait

Will try to clean up the pool callbacks parameter list by another PR, if I can finally ensure the host() method will always return a valid host

multiple address....

/wait fix ci

/wait ci


Add layer.removeFromMap() method

Integrating CARTO VL with the upstream custom layers proposal would fix this

This is implemented as layer.removeFrom(map) in the branch https://github.com/CartoDB/carto-vl/pull/886

Closed by https://github.com/CartoDB/carto-vl/pull/886


FF-274

Fixed issues causing filesets to break the browse view. Changed experiment embedding as well. Also changed the way default filters are populated from the banner to allow navigating back.

Coverage decreased (-0.2%) to 48.687% when pulling 13bf554859c0ec06e0b87c6c843161b3033546b6 on FF-274 into 2853af6ed4978976f20e0f89a6441af5e8f6e56c on master.

Coverage increased (+1.3%) to 50.196% when pulling 457d985298d4e937258bb6687fc7bd721833898b on FF-274 into 2853af6ed4978976f20e0f89a6441af5e8f6e56c on master.


Web config rework changes

This task is a placeholder for ongoing work in #10

This one was closed by #10


support 0 to many config files

Summary
Previously OID/OIL required exactly one configuration file. This change makes it so you can supply 0 or more configuration files. 0 is useful if you have pre-generated the cache or use some sort of remote generation system. 1 is useful for the common case, where you have a configuration file that describes your entire source and use just that. More are useful if you have supplemental bits of config you wish to apply/override - see the changes to the integration test framework where we do exactly this.
Test plan
This isn't super well tested. It works for the test cases which add features via the config or enable codegen.ignore.

CI

Codecov Report

Merging #371 (743c940) into main (edb7bf5) will decrease coverage by 21.45%.
The diff coverage is 60.37%.

@@             Coverage Diff             @@
##             main     #371       +/-   ##
===========================================
- Coverage   68.03%   46.58%   -21.45%
===========================================
  Files         114      101       -13
  Lines       11148    10814      -334
  Branches     1864     1807       -57
===========================================
- Hits         7584     5038     -2546
- Misses       2594     4930     +2336
+ Partials      970      846      -124

Files
Coverage Δ

oi/EnumBitset.h
73.33% <100.00%> (-26.67%)
:arrow_down:

oi/OIDebugger.cpp
39.16% <ø> (ø)

test/integration/runner_common.h
66.66% <ø> (-33.34%)
:arrow_down:

oi/Config.cpp
54.44% <88.23%> (ø)

oi/OID.cpp
32.91% <33.33%> (+0.39%)
:arrow_up:

test/integration/runner_common.cpp
49.79% <46.42%> (-13.89%)
:arrow_down:

... and 69 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Where to put documentation about directives?

Hey All,
I want to create documentation about all the directives, services, etc... that we have. Kind of a "here is how you use that". I thought of a /doc section with examples. Others have thought they should go in uw-ui-toolkit. I'm not sure, but I'd love everyone's input.
Thanks,
Tim

What about using github pages?
On Fri, Nov 20, 2015, 3:15 PM Tim Levett<EMAIL_ADDRESS>wrote:

Hey All,
I want to create documentation about all the directives, services, etc...
that we have. Kind of a "here is how you use that". I thought of a /doc
section with examples. Others have thought they should go in uw-ui-toolkit.
I'm not sure, but I'd love everyone's input.
Thanks,
Tim
—
Reply to this email directly or view it on GitHub
https://github.com/UW-Madison-DoIT/uw-frame/issues/72.

That could be neat @nblair . Keeps the documentation in the repo, kind of.

FYI, I'm currently working on adding our recent widget templates to the uw-ui-toolkit. But I don't think that's directly related to documentation on directives. I like the idea of a docs folder with markdown files in it for directives and other code documentation.

Awesome @jhanstra ! I was also thinking of incorporating those templates into the widget creator somehow.

My big hangup on GitHub pages (vs a docs directory) is that GitHub pages and its separate branch misses an opportunity to have the documentation in the same branches with and versioned with the thing documented.  It's a beautiful thing in staving off technical debt when a commit that changes a thing can also include updating the documentation of the thing.

What if... we put all the md (or jekell, whatever) in /docs then we had a job that saw the change on master, copied it to gh-pages, and pushed to gh-pages.

Created /docs as a static frame application. Master docs are deployed gh-pages branch via Jenkins script.


Mention the events on the README

@Epillepsy Would you like to open a PR mentioning the openMenu and closeMenu events on README ?

@mbj36 my bad, totally forgot about this, I will take care of it today

@Epillepsy Do you think you will be available to take this today ?

@mbj36 this is done, sorry for the delay


mkpr

Applied mkpr on package.json
sed s/kronos-integration\/service": ".*"/kronos-integration\/service": "^8.1.6"/

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   58.42%   58.42%
=======================================
  Files           2        2
  Lines          89       89
  Branches       11       11
=======================================
  Hits           52       52
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57fbe3...227f98c. Read the comment docs.

:tada: This PR is included in version 2.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[19.09] thunderbird, thunderbird-bin: 68.2.2 -> 68.3.0

Motivation for this change
Backport of #74973
Thunderbird 68.3 comes with fixes for several security vulnerabilities, some of them with "high" impact according to Mozilla.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/):

/nix/store/y48mj45c834k64hih929p629gfr2840h-thunderbird-68.3.0/bin/thunderbird
/nix/store/nslx1b6by3gmplp4gx0hlk2y0g6hdzzm-thunderbird-bin-68.3.0/bin/thunderbird

[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @nbp, @edolstra

@GrahamcOfBorg build

Removed patch like in https://github.com/NixOS/nixpkgs/pull/74973#event-2863398692. (See https://github.com/NixOS/nixpkgs/pull/74973#discussion_r355111892)

obsoleted by 943560f54007cc617b99c780ca9ee47d1c4ea2a8 & 71b278c26f28652007597b3ec141b583583a9bf5, closing


mwc-button with icon breaks in mwc-dialog

Describe the bug
when using icon attribute in mwc-button inside a mwc-dialog the icon is not properly aligned with the text.
Screenshots
https://polymer.slack.com/archives/CC0Q3PRCL/p1585270713048300
Issue
line-height css property in the class .mdc-dialog__content is what cause this issue.
Possible fix
mwc-dialog mwc-button {
  line-height: normal;
}

Browser Version (please complete the following information):

Browser: Chrome
Version 80

Additional context
mwc-button mwc-icon mwc-dialog version 0.14.1

Fixed in M3


master will not compile on JDK8

Current master branch will not compile on JDK8 because of use of Class.getPackageName() in class Builder.
Class.getPackageName() came in in JDK9.
Using Class.getPackage().getName() will make backwards compatible to JDK8.

I am having the same issue right now, when trying to upgrade from 1.3.1 to 1.3.2.
When can we expect a fix & a new release?

Hi Etienne,
Did you seem my PR re the JDK8 compile failure?
https://github.com/graphql-java-generator/graphql-maven-plugin-project/pull/21
Would it be possible to get this merged?
Also, when is it likely that 1.4-SNAPSHOT will be released and available for download?
Best regards
Paul

I just merged it.
I release a new version soon : I added introspection capability.

The 1.4 version has been released.
It should be Ok
I can't use directly the JDK 8 for "internal" reasons, and I thought that setting the source and target java version to 1.8 as enough...  :(

Hi Etienne,
Thanks very much for doing the release. We are now using it successfully.
Paul


Property 'URLPattern' does not exist on type 'typeof globalThis'

Following the README I have added:

But I have the warning:

Property 'URLPattern' does not exist on type 'typeof globalThis'

I also have tried to add this to the compilerOptions of the tsconfig.json:
"types": ["urlpattern-polyfill"]

Can you try with the latest version (5.0.0)? Not sure it helps but there were some changes to the types

Still the same with v5.

@abdonrd What versions are you using for TS and node, and types? Currently, I can not reproduce your issue.
Aside from that, it's safe to ignore this error.  The whole idea of the line is to check if it's there and load it if it is missing.
Add this instead:
// @ts-ignore: Property 'UrlPattern' does not exist
if (!globalThis.UrlPattern) {
  await import("urlpattern-polyfill")
}

I will also update the readme with this. And update the readme with the same.
Closing this as it seems working as expected. Feel free to keep discussing it here, as there might be something I didn't considder.

@abdonrd What versions are you using for TS and node, and types? Currently, I can not reproduce your issue.

TypeScript v4.7.2.
What do you mean with the types?

Aside from that, it's safe to ignore this error. The whole idea of the line is to check if it's there and load it if it is missing. Add this instead:
// @ts-ignore: Property 'UrlPattern' does not exist
if (!globalThis.UrlPattern) {
  await import("urlpattern-polyfill")
}

Yes, that is what we are using.


Stepper in Dutch - version changed to English

When I choose the English version of 4.0, the stepper is still in Dutch (I am in the middle of composing an application).

I think this gets fixed by using gettext_lazy instead of gettext.


Routing rule with Lua in route_configuration

Title: Routing rule with Lua in route_configuration
Description:
I want to use programmable routing configuration in route_configuration.
In my case, I want to route different endpoints by referring connection informations like HTTP Header.
For example, If we want to route two endpoints by referring x-user-id header, write config like this.
filter_chains:
            - filters:
                - name: envoy.http_connection_manager
                  config:
                    stat_prefix: ingress_http
                    access_log:
                      - name: envoy.file_access_log
                        config:
                          path: /dev/stdout
                    route_config:
                      name: local_route
                      virtual_hosts:
                        - name: backend_service
                          domains:
                            - "*"
                          routes:
                            - match:
                                prefix: "/blue/welcome"
                              route:
                                cluster: envoy-api-blue-service
                            - match:
                                prefix: "/green/welcome"
                              route:
                                cluster: envoy-api-green-service
                            - match:
                                prefix: "/login"
                              route:
                                cluster: envoy-api-blue-service
                    http_filters:
                      - name: envoy.lua
                        typed_config:
                          "@type": type.googleapis.com/envoy.config.filter.http.lua.v2.Lua
                          inline_code: |
                            function envoy_on_request(request_handle)
                              local percentage = 0.4
                              local div = 10
                              local path = request_handle:headers():get(":path")
                              if path == "/welcome" then
                                local mod = request_handle:headers():get("x-user-id") % div

                                if mod >= 0 and mod < div*percentage then
                                  request_handle:headers():replace(":path", "/blue/welcome")
                                else
                                  request_handle:headers():replace(":path", "/green/welcome")
                                end
                              end
                            end
                            function envoy_on_response(response_handle)
                              response_handle:headers():add("x-envoy-custom-header",<PHONE_NUMBER>)
                            end
                      - name: envoy.router
                        typed_config: {}

Run envoy with this configuration, If user accessed /welcome with x-user-id header, envoy detect this and rewrite :path header and route valid backend endpoint.
But, I think this is not good solution. I want to this configuration in route_config with programmable approach.
If maintainers want to apply this function, I want to try to implement this as prototype.

I think this is closely related to #8167.


BuffWindows array of BadActions for explicit Suggestions

BadActions currently takes an object with a Suggestion and list of Actions, but sometimes there's a need for separate Suggestions. In my case, it's 6SS needing separate text to Form Shift and Meditation. I'm proposing an array of objects to allow for them to have separate Suggestion texts.

Prob relevant to @AzariahAeroborn.

Per our conversation on Discord - this was an intentional design choice to limit the core BuffWindow implementation to emitting a single suggestion for all BadActions.  If this is absolutely required for a certain job or specific skills, the implementing job can potentially override output/onComplete or add an additional complete hook that will add the extra suggestion, but we do not want to get suggestion bloat out of the core module.


Dmac

Direct Memory Access Controller
This module provides a type-safe API with compile-time guarantees that the peripheral and individual DMA channels are correctly configured before launching a DMA transfer. This is a pure Rust driver and is not derived from any existing C/C++ library.
This module currently supports most basic DMA functions, including memory-to-memory, memory-to-peripheral, peripheral-to-memory, and peripheral-to-peripheral transfers. One-shot and circular transfers are supported. More complex transfer configurations, including multi-buffer (linked-list descriptor), are not currently supported.
Transfers are supported for i8, u8, i16, u16, i32, u32 and f32 beat sizes.
Enabling DMA support
The dma feature must be enabled in the board support crate or final executable.
Cargo.toml:
[features]
dma = ["atsamd-hal/dma"]

Channels and RAM
Using DMA channels require a certain amount of RAM - 32 bytes per channel, to be exact. RAM will be not allocated unless the dma feature is enabled for the HAL. By default, half the channels available on the chip are enabled. If you need all DMA channels enabled, enable the max-channels feature in your board support crate or final executable.
Cargo.toml
[features]
dma = ["atsamd-hal/dma"]
max-channels = ["dma", "atsamd-hal/max-channels"]

RAM usage per chip family:

ATSAMD11 - 3 channels (default): 96 bytes
ATSAMD11 - 6 channels (max): 192 bytes
ATSAMD21 - 6 channels (default): 192 bytes
ATSAMD21: - 12 channels (max): 384 bytes
ATSAMD51/ATSAME5x: - 16 channels (default): 512 bytes
ATSAMD51/ATSAME5x: - 32 channels (max): 1024 bytes

Individual channels are available through a split() method on the DMAC. They can be reused after a transfer is complete.
Priority levels and Arbitration
The DMAC features 4 priority levels. Level 0 has the highest priority and level 3 has the lowest. Each channel can be assigned to one priority level. If two channels with the same priority level are requested to execute a transfer at the same time, the lowest channel number will have priority (in the default arbitration scheme, eg. not round-robin). By default, all priority levels are enabled when initializing the DMAC (see DmaController::init). Levels can be enabled or disabled through the various level_x_enabled methods.
Round-Robin Arbitration can be enabled for individual priority levels by using the various level_x_round_robin methods. By default, all priority levels are initialized with a fixed arbitration scheme. See ATSAMD21 datasheet section <IP_ADDRESS> for more information.
Interrupts
This driver does not use or manage interrupts issued by the DMAC. Individual channels can be configured to generate interrupts when the transfer is complete, an error is detected or the channel is suspended. However, these interrupts will not be triggered unless the DMAC interrupt is unmasked in the NVIC. You will be responsible for clearing the interrupt flags in the ISR.
About static lifetimes
The safe API this driver offers requires all buffers (source and destination) to have 'static lifetimes. This is because mem::forget is a safe API, and therefore relying on mem::drop to terminate or abort a transfer does not guarantee the transfer will be terminated (specifically if mem::forget is called on a DmaTransfer containaing a Channel<Busy, ID>). This could cause the compiler to reclaim stack-allocated buffers for reuse while the DMAC is still writing to/reading from them! Needless to say that is very unsafe. Refer here or here for more information. You may choose to forego the 'static lifetimes by using the unsafe API and the various x_src_x_dest_unchecked methods.
Unsafe API
This driver also offers an unsafe API through the x_src_x_dest_unchecked methods. These do not enforce 'static lifetimes, and allow using *mut T pointers as buffers.  You must call wait() or stop() manually on every UnsafeTransfer to convert their underlying channels back into Channel<Ready, ID>. No destructor or Drop implementation is offered for DmaTransfers or UnsafeTransfers.
Example
let mut peripherals = Peripherals::take().unwrap();
let mut dmac = DmaController::init(peripherals.DMAC, &mut peripherals.PM);
// Get individual handles to DMA channels
let channels = dmac.split();
// Initialize DMA Channel 0
let chan0 = channels.0.init(PriorityLevel::LVL0, false, &mut dmac);
// Setup a DMA transfer (memory-to-memory -> incrementing source, incrementing destination)
// NOTE: buf_src and buf_dest should be either:
// &'static mut T, &'static mut [T], or &'static mut [T; N] where T: BeatSize
let xfer = DmaTransfer::inc_src_inc_dest(chan0, buf_src, buf_dest, false, ());
// Begin transfer with a software trigger
let xfer = xfer.begin(&mut dmac, TriggerSource::DISABLE, TriggerAction::BLOCK);
// Wait for transfer to complete and grab resulting buffers
let (buf_src, buf_dest, chan0, _) = xfer.wait(&mut dmac);

Const generics and rustc version
This driver uses const generics pretty heavily, and therefore compiles only using rustc 1.51 and up. I think this PR should only be merged into master when rustc 1.51 gets stabilized in March.
Improvements

There is more testing to be done, so any help would be appreciated, especially on the Cortex-M4 chips as I don't own any SAMD51/SAMEx hardware. Also untested on SAMD11, but the DMAC is practically identical to the SAMD21 so I'm fairly confident there should be no problems there.
No efforts have currently been made to support error handling on DMA transfers.
Transfer complete detection: currently the method to detect if a transfer is complete is to check that both BUSY and PEND bits of the CHSTATUS are cleared. It does not check the TCMPL bit of CHINTFLAG. Doing so would be a little tricky, as it would interfere with this driver's intent of not touching interrupt handlers or flags. However it might be necessary (?) to ensure it works in all cases?

This is awesome!!!
The CI failure looks transient - I'm re-running now.

This is awesome!!!
The CI failure looks transient - I'm re-running now.

@twitchyliquid64 thanks! I would love some additional testing, especially for the Cortex-M4 chips as I don't own any. Maybe we could figure out a way to integrate DMA transfers with peripherals for some sweet DMA driven UART/I2C/SPI/ADC operation. I'm not sure if those are better suited to be written in their respective modules or directly in the dmac module?

@twitchyliquid64 thanks! I would love some additional testing, especially for the Cortex-M4 chips as I don't own any. Maybe we could figure out a way to integrate DMA transfers with peripherals for some sweet DMA driven UART/I2C/SPI/ADC operation. I'm not sure if those are better suited to be written in their respective modules or directly in the dmac module?

I have a feather_m4. I could help out testing. Also, getting a peripheral-to-mem example would be great. I'm sure most people would be interested in that usage of DMA. Thanks for working on this!

I have a feather_m4. I could help out testing. Also, getting a peripheral-to-mem example would be great. I'm sure most people would be interested in that usage of DMA. Thanks for working on this!

I have a feather_m4. I could help out testing. Also, getting a peripheral-to-mem example would be great. I'm sure most people would be interested in that usage of DMA. Thanks for working on this!

@TDHolmes getting a peripheral -> memory (or the inverse) is easy, the problem is the peripheral (eg. an I2CMaster) drivers take ownership of the register blocks so accessing them safely isn't possible oustide the driver. I think doing so safely will require adding DMA support to every peripheral driver we wish to support, or even making entirely new drivers (eg I2CMasterDma)? I'm not entirely too sure how to go about this.

I have a feather_m4. I could help out testing. Also, getting a peripheral-to-mem example would be great. I'm sure most people would be interested in that usage of DMA. Thanks for working on this!

@TDHolmes getting a peripheral -> memory (or the inverse) is easy, the problem is the peripheral (eg. an I2CMaster) drivers take ownership of the register blocks so accessing them safely isn't possible oustide the driver. I think doing so safely will require adding DMA support to every peripheral driver we wish to support, or even making entirely new drivers (eg I2CMasterDma)? I'm not entirely too sure how to go about this.

That CI failure due to cortex-m 0.6.6 should be fixed now.

That CI failure due to cortex-m 0.6.6 should be fixed now.

@jbeaurivage if you rebase on master the CI should run (and hopefully pass). Thanks!

@jbeaurivage if you rebase on master the CI should run (and hopefully pass). Thanks!

@jbeaurivage ah, yeah makes sense. Perhaps that is out of scope of this initial PR.

@jbeaurivage ah, yeah makes sense. Perhaps that is out of scope of this initial PR.

@jbeaurivage, how does this compare with the samd-dma crate? We had talked about porting that over and integrating it here. I'm using it successfully right now with a linked list of descriptors.
As a broader question, if we accept this PR, does that mean we should drop attempts to port samd-dma? Does this PR have a better structure that will give a better long term solution?

@jbeaurivage, how does this compare with the samd-dma crate? We had talked about porting that over and integrating it here. I'm using it successfully right now with a linked list of descriptors.
As a broader question, if we accept this PR, does that mean we should drop attempts to port samd-dma? Does this PR have a better structure that will give a better long term solution?

@bradleyharden I think both libraries were developed with very different philosophies. To me, the samd-dma crate feels more like a thin wrapper around the DMAC registers. The intent behind this PR, from the ground up, was to use (and perhaps abuse) the compiler checks to make using the safe API as bulletproof as possible in terms of memory safety, since it is very easy to introduce UB by misusing DMA transfers. The choice was made to prioritize safety and correctness over trying to support every functionality offered by the DMAC.
A lot of that revolves around typestates and ensuring every moving part is correctly configured before being available for use (eg. you can't build a DmaTransfer with a Channel<Uninitialized, ID>. It needs to be initialized first).
One gripe I had with the samd-dma crate is that a lot of the functions that are marked as safe, really aren't. Here's a quick example showing it's pretty easy to introduce undefined behaviour using safe functions.:
let a: u8 = 0xff;
let b: u32 = 0x0;
let descriptor = TransferDescriptor::new();

// These next three lines aren't undefined behaviour, but could lead to unexpected results,
// especially on little-endian platforms:
descriptor.set_src_addr(&a as *const ());
descriptor.set_dst_addr(&b as *const ());
// Trigger transfer

// These next three lines are undefined behaviour. Writing an u32 into an u8 will definitely overflow:
descriptor.set_src_addr(&b as *const ());
descriptor.set_dst_addr(&a as *const ());
// Trigger transfer

In contrast, this PR makes it statically impossible to introduce UB by using mismatched types, or by trying to transfer from/to arrays with mismatched lengths:
// Assume chan was initialized
// chan: Channel<Ready, 0>
// Assume a and be were statically initialized
// a: &'static [u8; 15]
// b: &'static[u8; 15]
// This compiles,  as a and b point to arrays of the same type and length.
let transfer = DmaTransfer::inc_src_inc_dest(chan, a, b, false, ());
// Now assume a and b are of different lengths
// a: &'static [u8; 12]
// b: &'static [u8; 15]
// This will NOT compile
let transfer = DmaTransfer::inc_src_inc_dest(chan, a, b, false, ());
// Now assume a and b are of same length but different type
// a: &'static [u32; 15]
// b: &'static [u8; 15]
// This won't  compile either
let transfer = DmaTransfer::inc_src_inc_dest(chan, a, b, false, ());

These restrictions could be relaxed in time, as const generics become more featureful. We could do things like transfer from a source array that is shorter than its destination array, as it is not undefined behaviour. I also think that linked transfers could eventually become possible, perhaps by wrapping all involved DmaTransfers into a LinkedTransfer object or something, although I think much more auditing would be necessary to make sure everything is safe.
DmaTransfers also have provisions to take ownership of a generic payload. This is to support DMA implementations for different peripherals. For instance, to prevent data races, the DmaTransfer could take ownership of an I2CMaster until the transfer is complete.
Ultimately, I think both solutions try to serve different purposes. In my opinion, samd-dma could be a viable option if none of its functionalities are exposed to the user of atsamd-hal, and it's only used as an internal implementation for other peripherals. It's just too easy to misuse and inadvertently introduce UB using safe APIs. This PR tries to offer both a safe API and an unsafe but more flexible one, which I think could be used for both the HAL to implement DMA support for peripherals, and the end users of the HAL to implement their own transfers.

@bradleyharden I think both libraries were developed with very different philosophies. To me, the samd-dma crate feels more like a thin wrapper around the DMAC registers. The intent behind this PR, from the ground up, was to use (and perhaps abuse) the compiler checks to make using the safe API as bulletproof as possible in terms of memory safety, since it is very easy to introduce UB by misusing DMA transfers. The choice was made to prioritize safety and correctness over trying to support every functionality offered by the DMAC.
A lot of that revolves around typestates and ensuring every moving part is correctly configured before being available for use (eg. you can't build a DmaTransfer with a Channel<Uninitialized, ID>. It needs to be initialized first).
One gripe I had with the samd-dma crate is that a lot of the functions that are marked as safe, really aren't. Here's a quick example showing it's pretty easy to introduce undefined behaviour using safe functions.:
let a: u8 = 0xff;
let b: u32 = 0x0;
let descriptor = TransferDescriptor::new();

// These next three lines aren't undefined behaviour, but could lead to unexpected results,
// especially on little-endian platforms:
descriptor.set_src_addr(&a as *const ());
descriptor.set_dst_addr(&b as *const ());
// Trigger transfer

// These next three lines are undefined behaviour. Writing an u32 into an u8 will definitely overflow:
descriptor.set_src_addr(&b as *const ());
descriptor.set_dst_addr(&a as *const ());
// Trigger transfer

In contrast, this PR makes it statically impossible to introduce UB by using mismatched types, or by trying to transfer from/to arrays with mismatched lengths:
// Assume chan was initialized
// chan: Channel<Ready, 0>
// Assume a and be were statically initialized
// a: &'static [u8; 15]
// b: &'static[u8; 15]
// This compiles,  as a and b point to arrays of the same type and length.
let transfer = DmaTransfer::inc_src_inc_dest(chan, a, b, false, ());
// Now assume a and b are of different lengths
// a: &'static [u8; 12]
// b: &'static [u8; 15]
// This will NOT compile
let transfer = DmaTransfer::inc_src_inc_dest(chan, a, b, false, ());
// Now assume a and b are of same length but different type
// a: &'static [u32; 15]
// b: &'static [u8; 15]
// This won't  compile either
let transfer = DmaTransfer::inc_src_inc_dest(chan, a, b, false, ());

These restrictions could be relaxed in time, as const generics become more featureful. We could do things like transfer from a source array that is shorter than its destination array, as it is not undefined behaviour. I also think that linked transfers could eventually become possible, perhaps by wrapping all involved DmaTransfers into a LinkedTransfer object or something, although I think much more auditing would be necessary to make sure everything is safe.
DmaTransfers also have provisions to take ownership of a generic payload. This is to support DMA implementations for different peripherals. For instance, to prevent data races, the DmaTransfer could take ownership of an I2CMaster until the transfer is complete.
Ultimately, I think both solutions try to serve different purposes. In my opinion, samd-dma could be a viable option if none of its functionalities are exposed to the user of atsamd-hal, and it's only used as an internal implementation for other peripherals. It's just too easy to misuse and inadvertently introduce UB using safe APIs. This PR tries to offer both a safe API and an unsafe but more flexible one, which I think could be used for both the HAL to implement DMA support for peripherals, and the end users of the HAL to implement their own transfers.

@jbeaurivage, thanks for the response. I only skimmed it, but your first paragraph told me you were going exactly where I thought you were going.
I'd like to review your comment and the code in depth. I'm just short on time at the moment. Maybe I'll find some time this weekend. Looking forward to it.

@jbeaurivage, thanks for the response. I only skimmed it, but your first paragraph told me you were going exactly where I thought you were going.
I'd like to review your comment and the code in depth. I'm just short on time at the moment. Maybe I'll find some time this weekend. Looking forward to it.

Also, I like the idea of focusing on the transfer types that can be made safe with the compiler, even if you can't do everything. There's still value in that.
But maybe alsp think if there might be a way to handle ping/pong buffers with your approach. I feel like that's a pretty common use case. Maybe there's a way to special case it, without solving linked lists generally. Or maybe you've already thought about it. Just an idea

Also, I like the idea of focusing on the transfer types that can be made safe with the compiler, even if you can't do everything. There's still value in that.
But maybe alsp think if there might be a way to handle ping/pong buffers with your approach. I feel like that's a pretty common use case. Maybe there's a way to special case it, without solving linked lists generally. Or maybe you've already thought about it. Just an idea

@bradleyharden looking forward to your review. I'm definitely open to suggestions. I agree there's probably a way to figure out linked buffers. I just wanted to focus on the simpler use cases first, and get working examples out for people to start testing.

@bradleyharden looking forward to your review. I'm definitely open to suggestions. I agree there's probably a way to figure out linked buffers. I just wanted to focus on the simpler use cases first, and get working examples out for people to start testing.

@jbeaurivage, first I want to say I really like where you're going with this. That makes me even more disappointed it can't handle my current, linked-list use case.
I have some general comments that I will give here, and I also have some specific comments that I'll markup in the code. But before I do that, I'd like to note one thing. For the sake of brevity, I'm going to state my conclusions and opinions as fact, but I only spent 30-60 minutes reviewing, so there's a good chance I may have missed something or misunderstood what you're doing. Please correct me if that's the case.
General

I think your priority levels are inverted. You say

The DMAC features 4 priority levels. Level 0 has the highest priority and level 3 has the lowest.

But the datasheet says:

As long as all priority levels are enabled, a channel with a higher priority level number will have priority over a channel with a lower priority level number.

I think you could use the feature min-samd51g in places where you are currently using any() with four different samx5x features. That would be simpler and less cluttered.

I'm not sure if #[inline(always)] is the best choice. I remember moving away from it, to the standard #[inline], but I can't remember why. You might want to look into that. Also, you might want to go through and double check your inlining decisions. I think I saw a few cases where a one- or two- line function wasn't marked as inline.

I think you might be confused about the usage of Sealed. Implementing Sealed does nothing on its own. It's only when you use Sealed as a trait bound that it has any real effect. I see you implemented Sealed in a few places, but I couldn't find anywhere that uses it as a trait bound.

The usual pattern is to use Sealed as a super trait. Because Sealed is in a private module, users can never implement Sealed themselves, so they can never satisfy the requirements for your trait.

In several places, you use release as a function name to consume and deconstruct an object. I think I've usually seen such functions named free.  I don't really care either way, but I think we should decide on a consensus name and stick with that. Maybe others can chime in on this.

In my work on the gpio, sercom and soon-to-be spi modules, I came up with what I call the Any* trait pattern. I think it would be useful for you here. It helps tremendously to cut down on generics.

The AnyPin documentation explains the concept well, but it doesn't make much use of it directly (implementation here).
On the other hand, my new SPI module makes heavy use of the pattern. I haven't made a PR yet, but the thumbv7em version is essentially done. I'm only missing module-level docs. Here is a link for reference, if you feel like looking through it. The AnyPads and AnyConfig traits are the most relevant.
As a specific example, your UnsafeTransfer struct takes 6 generics. Instead of storing a Channel and requiring both ChanStatus and ID generics, you could instead take a single type that satisfies a new AnyChannel trait. The trait would have an associated type and constant to store the ChanStatus and ID respectively. You could also create an AnyTransferConfig trait to consolidate B, Src and Dst. That would reduce the number of generics on UnsafeTransfer from 6 to 3. I also think the pattern also helps to encapsulate behavior well.
Transfers

Right now, you have four different transfer types and individual functions for each. But each of those functions is just a thin wrapper. Instead, I would propose consolidating all four transfer types into a single, generic function. I'm pretty certain you could implement any difference in behavior between DmaBuffer types using associated constants or functions in the trait.

The convert function in the PinMode trait is a really good example of this pattern. I was able to collapse all of the different pin mode conversion functions into a single implementation of a trait function.

Instead of implementing DmaBuffer for [T] and [T; N] specifically, you might consider a blanket implementation for anything that implements either AsMut<[T]> or DerefMut<[T]>. That would allow using heapless::Vec, user-defined types, etc.

@jbeaurivage are you on the Matrix channel? Your name doesn't show up when I search. I had some spit-ball thoughts, but I'd rather not pollute the discussion here with ill-formed ideas.

@jbeaurivage, I've just had a quick look over this, it's looking great!
This probably won't be very helpful, but for a work project I've been using the DMAC (via samd-dma copied in to a branch of the HAL) to and from the I2S peripheral with these simplistic accessors .
I'm also tinkering with accessing the USB via DMA, using embedded-dma traits - have you considered working them in to this?  I feel like those traits are slightly awkward when interfacing with peripherals like I2S, because the embedded-dma buffers have a fixed size but the peripheral can accept an infinite number of reads/writes.  It would also be nice if they could associate a trigger source with the "buffer".

@ianrrees I think as far as this PR is concerned, it is ready to go as-is. I definitely do want to submit follow up PRs that add DMA support to a selection of peripherals. Maybe I could do one or two peripherals as examples and let the people here add support for other peripherals they're using (for example, I'm pretty unfamiliar with I2S and don't have I2S devices to test against).
I think embedded-dma could also eventually be worked into this driver. Maybe "regular" transfers could implement these traits, and let more exotic transfer types (like circular) not implement them.

If everyones happy with this PR then im happy to merge. @bradleyharden u good with this?

Can I take one last look at it? I haven't looked at it in weeks, and @jbeaurivage has made a lot of changes.

Certainly!

@jbeaurivage, I think it turned out really well. I like how clean everything is with the Any_ traits. I'm glad to see the pattern found use outside my own code.
Resolve the remaining comments however you want. I think it's good to merge.
Also, hurray for min_const_generics 🎉! It's not perfect, but it's something.

Alright friends this is positively ready to go.
Huge thanks to @bradleyharden for all the help.
@twitchyliquid64 all yours now!

YAAAAAS Thank you everyone for getting this over the line!


Error from using resourceId seems to contradict documentation

If its my typo I'm sorry but I am pretty sure my "code" is as per this documentation and yet the error says it wants one argument.
> Unable to evaluate template language function 'resourceId': function requires exactly one multi-segmented argument which must be resource type including resource provider namespace.
"variables": {
"queueSenderListenerRoleResourceId": "[resourceId('Microsoft.ServiceBus/namespaces/queues/authorizationRules','my-namespace-name/my-queue-name/my-role-name')]"
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85bba21f-ef02-381c-48bd-0ced44cc513f
Version Independent ID: c56b631f-e9f4-39ea-c2b2-a46132e5c286
Content: Azure Resource Manager template functions - resources
Content Source: articles/azure-resource-manager/resource-group-template-functions-resource.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

It seems this is a frustrating and unresolved issue from May 2016, great job guys.
https://github.com/Azure/azure-quickstart-templates/issues/1965

@lukepuplett - sorry about the lack of documentation for this scenario. I am adding an example that will get published this afternoon. Here is how you get the resource ID for a resource type with multiple segments.
"variables": {
"queueSenderListenerRoleResourceId": "[resourceId('Microsoft.ServiceBus/namespaces/queues/authorizationRules', 'my-ns', 'my-queue', 'my-auth')]"
},

I see that your feedback issue mentions dependsOn. In most cases, you only have to provide the resource name to set a dependency. The resource ID is only needed when resources in the template have the same name. See dependsOn

Thanks very much for a prompt response, Tom.


https://github.com/github/docs/blob/1ba59f1a2c1e2b2ec62995c38dfb6b4a2e5daf4a/content/get-started/quickstart/git-cheatsheet.md

#

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


[Feature Request] Add more custom command support!

Same as titile!
Thanks!

+1
Maybe allow a different custom command for each corner?
Custom 1
Custom 2
Custom 3
Custom 4
And Thank you for making this!!! I've been using it for years. I also use it as a portable app. So, I love that there is no "install" required. (I place my favorite .scr files in the same directory and use the custom command to run the screen saver I copied earlier. That way it works on every computer. Very handy and very easy!)

Really looking forward to this feature. I would love to contribute if you need any help with it. Thanks for building this utility!

vhanla, please add this!

I've been trying to figure out a custom command to make it turn OFF the screen saver, not start it. So far as I can tell, the custom command would have to make a registry edit, and track its own state so it can edit the registry again afterward.

v1.3.0 Adds 3 more custom commands.


Create Artifactory plugin for use with hooks / internal uploads

Public upload of Misk Web Plugin works using Gradle M2, Artifactory support not needed


Fix report editing (my bad)

Description
Forgot to remove a reference to an old yea-wandb branch. oops
Testing
Nightly:
https://app.circleci.com/pipelines/github/wandb/client/13800/workflows/5f4e1272-ef49-4ec1-873b-a015380563e3
Checklist

Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

hmmm... is there a reason all functional tests are moved to to_main?


add flag to --launch open the browser after deploying

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

See #247

obsolete, see #247


Allow boolean variables in sheet templates

Problem
Cookiecutter v2.2+ allows for boolean-type variables. SODAR does currently not recognise those as valid form fields and omits them in the "Create from template" dialogue.
Solution
Boolean variables should be parsed and treated as multiple choice for simplicity.
Additional Context

https://cookiecutter.readthedocs.io/en/stable/advanced/boolean_variables.html
relevant for this upcoming template: https://github.com/bihealth/cubi-isa-templates/pull/23
Generally useful feature which would allow for more flexibility in templates.

I have a work branch up with this change and a dependency to the pr commit, it seems to work just fine.
Let me know when this is merged and I will update the dependency and merge this into dev.

Note to self: this initial implementation apparently will not work with the tumor_normal_dna and tumor_normal_triplets templates, as they require the hack in save() which I just removed:
if 'is_triplet' in self.sheet_tpl.configuration:
    extra_context['is_triplet'] = self.sheet_tpl.configuration[
        'is_triplet'
    ]

However, with the cancer template (which actually has is_triplet as a boolean variable), this can not be used. Either we have to 1) fix the other templates to not require this hack, or 2) limit the hack only to be used with specific templates. I'd of course be in favour of the former approach, if feasible.

FYI we're still discussing changes to the new somatic template relying on this feature. Expectation is that it'll take another week or two as there is not much pressure. The final merge will however also remove tumor_normal_dna and tumor_normal_triplets.

Done.


Update darkmode based on new experimental palette

Using few experimental dark mode colors from figma
https://www.figma.com/file/bpXcYuAuuhYAdrJoT2U7yz/Dark-mode?node-id=0%3A1

There's a couple of padding moves, yet some snapshots seem to lose the padding completely – is that on purpose, like do we only retain it on actual Previews for human-readable cases? 🤔

There's a couple of padding moves, yet some snapshots seem to lose the padding completely – is that on purpose, like do we only retain it on actual Previews for human-readable cases? 🤔

I will recheck the previews. In general, the Storybook-related paddings have been moved out to unified layout. Will add .medium paddings back to specific previews where they are now missing.

So in Compose, we have those colored secondary buttons on Alert rather lighter than darker then the alert's background. Similarly the button is darker than the bg in light mode. Is this intentional?

So in Compose, we have those colored secondary buttons on Alert rather lighter than darker then the alert's background. Similarly the button is darker than the bg in light mode. Is this intentional?

This task is using only the figma colors as direct replacement of existing palette colors. No additional surface/opacity etc. logic is added yet - waiting for more progress from Orbit.

So in Compose, we have those colored secondary buttons on Alert rather lighter than darker then the alert's background. Similarly the button is darker than the bg in light mode. Is this intentional?

Will recheck - I probably missed some of WIP colors from figma.

Those colors weren't present at all in Figma, if you don't have a different file. I made them 10% lighter.

Did with similar offsets (also for active+hover), updated.

Those colors weren't present at all in Figma, if you don't have a different file. I made them 10% lighter.

Did it similar with similar offsets (also for active+hover), updated.


HeroController._updateQuest calling Hero.of with a null context

Ran the leafy app on Android and pressed the back button.  Saw this exception:
@Hixie
══╡ EXCEPTION CAUGHT BY SCHEDULER LIBRARY ╞═════════════════════════════════════════════════════════
The following NoSuchMethodError was thrown during a scheduler callback:
The null object does not have a method 'visitChildElements'.
NoSuchMethodError: method not found: 'visitChildElements'
Receiver: null
Arguments: [Closure: (Element) => void]
When the exception was thrown, this was the stack:
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart)
#2      Hero.of (package:flutter/src/widgets/heroes.dart)
#3      HeroController._updateQuest (package:flutter/src/widgets/heroes.dart)
#4      BindingBase&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart)
#5      BindingBase&SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart)
#6      _beginFrame (file:///ssd2/sky/flutter/bin/cache/pkg/sky_engine/dart_ui/hooks.dart)
════════════════════════════════════════════════════════════════════════════════════════════════════

This code path doesn't exist anymore, see https://github.com/flutter/flutter/pull/8112


TDlib secret chat

I'm using TDLib just to use secret chat for sending notification so some kind of one "way chat"
It is possible to configure TDLib to not save or delete the sent messages just for sendere? so I do not have any sent file on file system.
More over images sent in secret chat are stored in tdlib/secret folder, but are not encrypted they are kept as plain jpg: is it the correct behaviour or I'm missing something in configuration?

If you disable message database, then the messages will be stored only in memory. There is no way to delete messages in secret chats just for self.
The images are stored in the same directory as the database. It is impossible to encrypt them in a safe way, because there is no place to securely store the encrypton keys. It is app resposibility to pass a protected enough pass as database_directory.

ok, it's anyway strange to have secret chat stuff stored in plain data without encryption. But if I enable DB storage the image are stored in the encrypted DB or in plain file as without DB?

@micheleselea See https://github.com/tdlib/td/issues/188#issuecomment-379536139 for more details about encryption.
Images aren't stored in the database. You can use deleteFile to delete them.

Ok understand: I probably have to change something in TDLib to avoid saving any information to disk because I'm can't storage any critical data.
Do you have some suggestion where can I start to check in source code doing that?

@micheleselea There is no way and there is no need to change that in TDLib. Just mount photos folder with tmpfs.

it's always an ugly walkaroud because the point is that there's one moment you have the image saved plain on the filesystem and I cannot let that happen...I have to found a smart way to do that

Whoever can access filesystem is very likely can access memory of your process or/and can inject code to the binary.

yes I think you are right the point is just to make this the less likely possible and more difficult to do.
Anyway you told me that when you do not have DB enabled information are stored in RAM: do you know if there's some RAM limit to set or some max memory usage?

Files are stored on file system regardless of database settings. RAM usage can be limited only extenally by setrlimit.

Ok, I think in my situation, to keep data as private as possible, is to change tidlib somehow to correct the behavior that could be critical to me


fix incorrect pull request check gating preview deploy

Thank you for contributing!Preview these changesLink expires: Mon Oct 15 00:51:09 UTC 2018

Thank you for contributing!Preview these changesLink expires: Mon Oct 15 00:55:14 UTC 2018


Spiders can climb while wet

https://gist.github.com/sharlin073/156522856108c88e1f06d55d184f959c
Using 1.16.5 with Forge 36.0.26
I have spider 2.0 which makes spiders climb ceilings installed, and both 'can't climb glazed terracotta' and 'can't climb while wet' options enabled in forgery.
(I also have better animal model, but I disabled it for spiders, so it probably didn't affect anything)
I built two small 2x2 spaces, one with dirt walls and the other with glazed terracotta walls. I set the weather to 'rain'.
I spawn some spiders in with spawn eggs.
Spiders and cave spiders in the dirt wall come out without any issue.
I'm not sure this is solvable, but as it still works for glazed terracotta blocks, reporting here for just in case. :)

Spiders 2.0 completely reworks the spider AI and has its own tag to specify non-climbable blocks that by default it contains glazed terracotta, so even that feature is not working.: https://github.com/TheCyberBrick/Spiders-2.0/blob/94178399882ab8faf732388da8e44dcf6e124426/src/main/resources/data/spiderstpo/tags/blocks/non_climbable.json
This isn't really reasonable to add compat for on my side; please request a config option to prevent spiders climbing while wet from Spiders 2.0.

Okay. Thanks!


Chore: helm-chart v0.2.8

added changelog entries
changed db_path to data_dir

prnet cleaned-up successfully


Autocompletion: Escape cypher types

Escape cypher types with spaces when using autocomplete.

 Escape auto-complete suggestions where necessary


Remove "escaped_fragment" stuff from the README

to match @thoop's commit in prerender-node from earlier this year
Also, sorta related: https://medium.com/finnovate-io/googlebot-no-longer-picking-up-content-in-prerender-io-pages-ae21d9710459
This change is just me paraphrasing @thoop's revised summary, but adapted to match the sort of step-by-step style that was going on before:

This middleware intercepts requests to your Node.js website from crawlers, and then makes a call to the (external) Prerender Service to get the static HTML instead of the JavaScript for that page. That HTML is then returned to the crawler.

Making this change because @rachaelshaw and I were about to use prerender on a project, stumbled across this stuff about meta tags, and were like... "uhh wait a sec, is that relevant anymore?"
Hopefully this change saves others a few minutes down the road (since it seems this is no longer necessary)
I'll try my best to come back and check on this PR, but in case I miss your response and we're dead wrong about this, I'd really appreciate a heads up!  (feel free to DM me at @mikermcneil or Rachael at @rachaelshaw
Thanks for a great product!  We'll be paying customers of the hosted prerender service within the next week :)

Awesome, thanks for this! I've been meaning to do this for a long time 😄


Redux with react router

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thanks @Hitvardhan-Singh-Solanki for the PR and congratulations on getting your PR merged to this repository :+1:


Need to expose CTLog public key in cosign.CheckOpts

Description
Support was added to specify things like RekorPub keys as part of the CheckOpts structure so that we can decouple the TUF / Verify boundaries.
What's missing from CheckOpts however is the ability to specify the CTLog public key:
https://github.com/sigstore/cosign/blob/main/pkg/cosign/verify.go#L119
This should be added.
@asraa or am I missing something?

Nope, I think you're correct. There's still this, and piping through each of these in the signing path. I can probably see if I can get to both at the end of the week, but likely not in the next 3 days!

Ack, thanks!

@asraa do you want me to track this a 2.0 blocker? We wouldn't be cutting 2.0 for a while (just a RC soon)


Allow aghosts to drag/drop ghosts onto bodies to SetMind + respawn as selected character.

Description

A confirmation should pop up to prevent anything accidental
Probably a toggle too

Discord channels have taught me that it's really easy to accidentally drag and drop something

Fair point, added a request so it asks for confirmation before accepting.

Discord channels have taught me that it's really easy to accidentally drag and drop something

Fair point, added a request so it asks for confirmation before accepting.

toggle+confirm
would be best way to go about it

admin accidentally forcing the soul of a greytider into someone else's body:

What's meant by toggle in this issue? Like a togglable action (e.g. harm mode)?


Fix the problem that GetGameLoop() doesn't return the right loop number in the frame just after Control()->Restart()

Just added Control()->GetObservation(); in AgentControlImp::Restart()

@monarchBacilluscoli thank you.
Merged you patch to my fork at https://github.com/alkurbatov/cpp-sc2/commit/e94baa24897b7035f906a6b39e9fea02b2be31b4


Refactor walkthrough to work with new helm charts

This is a follow-up to #546

I've labeled this as MVP 2 because I believe that in tje Kubecon timeframe, we need to be prepared for an influx of new interest and people who will want to kick the tires.