"gatsby develop" gets hung up on "Downloading remote files"

I am trying to develop my Gatsby/Wordpress project locally but it keeps getting hung up on "Downloading remote files:"
 -> wordpress__CATEGORY fetched : 86
 -> wordpress__TAG fetched : 93
 -> wordpress__wp_topic fetched : 8
 -> wordpress__wp_users fetched : 20

Path: /wp-json/wp/v2/users/me?per_page=100&page=1
The server response was "401 Unauthorized"
Inner exception message: "You are not currently logged in."
 -> wordpress__wp_comments fetched : 0
 -> wordpress__wp_search fetched : 1623

Path: /wp-json/wp/v2/block-types?per_page=100&page=1
The server response was "401 Unauthorized"
Inner exception message: "Sorry, you are not allowed to manage block types."

Path: /wp-json/wp/v2/settings?per_page=100&page=1
The server response was "401 Unauthorized"
Inner exception message: "Sorry, you are not allowed to do that."

Path: /wp-json/wp/v2/themes?per_page=100&page=1
The server response was "400 Bad Request"
Inner exception message: "Missing parameter(s): status"

Path: /wp-json/wp/v2/plugins?per_page=100&page=1
The server response was "401 Unauthorized"
Inner exception message: "Sorry, you are not allowed to manage plugins for this site."

Path: /wp-json/wp/v2/block-directory/search?per_page=100&page=1
The server response was "400 Bad Request"
Inner exception message: "Missing parameter(s): term"
⠇ source and transform nodes
[============================]   252.884 s 128/128 100% Generating image thumbnails
[==========================  ]   160.993 s 1961/2045 96% Downloading remote files

It will just hang there on 1961/2045. I have edited my gatsby-config.js options to include these plugin options, hoping they would help:
    {
      resolve: `gatsby-source-wordpress-experimental`,
      options: {
        /*
         * The full URL of the WordPress site's GraphQL API.
         * Example : 'https://www.example-site.com/graphql'
         */
        url: `https://fakeurl.com/graphql`, //`https://wordpress-222222-33333.cloudwaysapps.com/graphql`,
        verbose: true,
        debug: {
          graphql: {
            showQueryVarsOnError: true,
          },
        },
        develop: {
          timeout: 30000,
          hardCacheMediaFiles: true,
        },
        html: {
          imageMaxWidth: process.env.NODE_ENV === `development` ? 180 : 8000,
          imageQuality: process.env.NODE_ENV === `development` ? 10 : 90,
        },
        type: {
          Post: {
            limit: process.env.NODE_ENV === `development` ? 10 : 5000,
          },
          MediaItem: {
            localFile: {
              excludeByMimeTypes: process.env.NODE_ENV === `development` ? [`video/mp4`] : []
            },
          },
        },
      },
    },

But nothing has changed. Still gets hung up at exact same spot.
I've been fighting this issue for 3 days now, unable to work on the project. I have another developer working on the project who is able to build it on his laptop. He is running a PC Ubuntu with core i5 7500. I am running on a Macbook 2018. I have no idea if the hardware is relevant but it seems to be the only variable between us. Or his internet is faster, but I have no idea. It really seems like an issue with Gatsby/WP itself.
Thanks everyone, please let me know if you know of any things I can try to get my project to build.
PS: The issue is not resolved by gatsby clean or any kind of deleting of caches or node_modules and re-installing anything.

I've been having this issue as well. It'd be great to get an answer

Gahh I've run into this a few times myself, any help would be good!!

Hey all! Can anyone provide a reproduction /graphql endpoint (and repo possibly) I can use to reproduce?
I can prioritize this higher than other things since this is a critical bug, but I need to be able to reproduce it to fix. Thanks!

Hi Tyler, this is what I get when I run gatsby info:
System:
    OS: macOS 10.15.5
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.16.3 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
  Languages:
    Python: 2.7.16 - /usr/bin/python
  Browsers:
    Chrome: 86.0.4240.75
    Safari: 13.1.1
  npmPackages:
    gatsby: ^2.24.52 => 2.24.60
    gatsby-cli: ^2.12.90 => 2.12.97
    gatsby-image: ^2.4.16 => 2.4.18
    gatsby-plugin-antd: ^2.0.2 => 2.2.0
    gatsby-plugin-google-analytics: ^2.3.14 => 2.3.14
    gatsby-plugin-google-tagmanager: ^2.3.12 => 2.3.12
    gatsby-plugin-less: ^2.0.6 => 2.1.2
    gatsby-plugin-manifest: ^2.0.9 => 2.4.29
    gatsby-plugin-netlify-functions: ^0.0.3 => 0.0.3
    gatsby-plugin-offline: ^2.0.16 => 2.2.10
    gatsby-plugin-react-helmet: ^3.3.11 => 3.3.11
    gatsby-plugin-robots-txt: ^1.5.1 => 1.5.1
    gatsby-plugin-sass: ^2.3.12 => 2.3.13
    gatsby-plugin-sharp: ^2.6.30 => 2.6.36
    gatsby-plugin-sitemap: ^2.4.12 => 2.4.13
    gatsby-plugin-styled-components: ^3.3.10 => 3.3.11
    gatsby-source-filesystem: ^2.3.27 => 2.3.30
    gatsby-source-wordpress: ^3.3.31 => 3.3.34
    gatsby-source-wordpress-experimental: ^1.3.8 => 1.3.8
    gatsby-transformer-sharp: ^2.5.13 => 2.5.15
  npmGlobalPackages:
    gatsby-cli: 2.12.37

I will get back to you with the /graphql endpoint soon. Thank you!

@TylerBarnes can I DM or email you our /graphql endpoint? Ideally we keep it private.

@znwhite you can email me at<EMAIL_ADDRESS>:) thanks!

@TylerBarnes emailed!

@znwhite I have a feeling you and the other developer you're working with might be on different package versions. Can you upgrade to the latest of all Gatsby packages (or delete your yarn.lock or package-lock.json and reinstall) to see if it fixes it. There were some Gatsby core bugs around this at some point (not sure which version), but they were resolved. The latest Gatsby version is 2.24.77 for example but your project has 2.24.60 installed

@TylerBarnes deleted yarn.lock and package-lock.json and re-installed (making sure I upgraded to 2.24.77) and still same issue :(

@znwhite can you add me to your repo? I'm not able to reproduce so I'm wondering if it's some very specific combination of things 🤔

@TylerBarnes Just added you with write access. Thank you!

@TylerBarnes Just added you with read access. Thank you!

@znwhite I'm still not able to reproduce :( Can you try setting hardCacheMediaFiles to false?

@TylerBarnes Tried it. Still getting hung up on Downloading remote files 2010/2045.
Noticed it's getting further sometimes than others. I am not familiar enough with the underlying processes here, could this be an internet speed issue? It never finishes building when I am at office or when I am at home, but clearly this project is building sometimes for people in other locations.
Sorry if this is swaying off topic here, just really trying to pin down the problem.
We appreciate your help!

@znwhite it's not swaying off topic, you're good :) Thanks for the additional info. Can you run an internet speed test so I can limit my connection and make it the same?

@TylerBarnes Yes, internet speed (via fast.com) is consistently coming in at 94-97 mbps.
Perhaps there is a way to limit/exclude the offending content/files? Can I limit wp_media files during development?

@TylerBarnes Yes, internet speed (via fast.com) is consistently coming in at 94-97 mbps.
Perhaps there is a way to limit/exclude the offending content/files? Can I limit wp_media files during development?
I have reason to believe it could be some video files that were uploaded into our WP recently. There are 34 of them. But limiting videos does not seem to work either. Latest attempt's gatsby-config.js :
{
   resolve: `gatsby-source-wordpress-experimental`,
   options: {
     excludeFieldNames: [`video`],
     /*
      * The full URL of the WordPress site's GraphQL API.
      * Example : 'https://www.example-site.com/graphql'
      */
     url: `https://fakeurl.com/graphql`, //`https://wordpress-222222-3333333.cloudwaysapps.com/graphql`,
     verbose: true,
     debug: {
       graphql: {
         showQueryVarsOnError: true,
       },
     },
     develop: {
       timeout: 30000,
       hardCacheMediaFiles: false,
     },
     html: {
       imageMaxWidth: process.env.NODE_ENV === `development` ? 180 : 8000,
       imageQuality: process.env.NODE_ENV === `development` ? 10 : 90,
     },
     type: {
       Post: {
         limit: process.env.NODE_ENV === `development` ? 5 : 5000,
       },
       Page: {
         limit: process.env.NODE_ENV === `development` ? 5 : 5000,
       },
       MediaItem: {
         lazyNodes: true,
         localFile: {
           excludeByMimeTypes: [`video/mp4`, `video/mov`]
         },
       },
     },
   },
 },

@znwhite currently the only way to limit media items is to limit the posts that they're attached to. Since you've limited it to 5 pages and 5 posts you're close to having limited all the media items anyway 🤔
I'll try a few more things and do a bit of brainstorming with a colleague later today and let you know what I come up with. Thanks again

Oh, also are you able to reproduce this if you disable gatsby-source-wordpress and just run gatsby-source-wordpress-experimental? Actually it'd be great if you could try commenting out all plugins except for gatsby-source-wordpress-experimental to make sure it's causing the issue.

Thinking about it a bit more, there's a good chance this is a bug with gatsby-source-wordpress or a bug where this plugin and that plugin are clashing. Because if you limit your posts to 5 in this plugin, it wont download 2k images unless those are all attached to those 10 posts/pages. So there's a high chance this bug isn't coming from the experimental plugin

😱 I just reproduced it! I set my internet speed exactly to yours ha! I'll dig into this a bit

Yep, I can confirm that this is a gatsby-source-wordpress@v3 bug. I can reliably reproduce this when I disable gatsby-source-wordpress-experimental in your gatsby-config.js (so only v3 is running). When I disable gatsby-source-wordpress I can't reproduce it. I'd recommend fully upgrading to the experimental plugin to overcome this bug! All my time right now is dedicated to making v4 stable (which will be happening very soon) so I wont have time to fix the v3 bug, especially since it'll be deprecated soon.

Good to know- thanks for figuring that out. But I'm noticing that when I remove gatsby-source-wordpress, I am missing all of my custom/acf content types from GraphiQL. Is there any way to get them back via gatsby-source-wordpress-experimental? The bulk of the project relies on those, not just Post/Page etc.

You'll want to install https://github.com/wp-graphql/wp-graphql-acf and make sure each field group is enabled to show in GraphQL and has a field name.

@TylerBarnes The thing is, I believe I need gatsby-source-wordpress@v3 to query acf in the first place. We already have that plugin installed on our wordpress instance. It seems like gatsby-source-wordpress-experimental does not support acf? It does not have a useACF: true option the way that gatsby-source-wordpress@v3 does. Am I missing something?

@znwhite it supports ACF if the fields are added to WPGraphQL, no need for a useAcf option. Can you confirm that you're able to query ACF data from WPGraphQL directly?

@TylerBarnes No, we have never been able to query ACF data directly from WPGraphQL directly (even with gatsby-source-wordpress .

@znwhite gatsby-source-wordpress v3 uses the REST API. Make sure you follow the WPGraphQL ACF docs so that your acf field groups and fields show up in wp-graphiql, once you do that it'll show up in Gatsby automatically

@TylerBarnes Ok they're showing up! But the problem was because we couldn't get a build to finish... and then we upgraded our internet to be 200+ mbps and then the build finished.
We observed a strange throttling behavior in our internet download speed while Downloading remote files was running. A phone call to our internet provider bumped us up to around 250 mbps and then the build went through.
Per your observations, we are going to begin refactoring the code over to gatsby-source-wordpress-experimental queries instead of the original queries we were using.
Thank you for all your help!

@TylerBarnes any updates here?

@marcelsantilli the bug here was for a different plugin and was resolved. If you're running into a similar problem, please open a new issue :)


Request: UI Branch

@dileepabandara  Hi!
Firstly, I would like to congratulate you for the amazing work! I've been looking at some projects and none of them are as well done and organized as yours.
I would like to ask you to make a branch available only with the project in flutter frontend, without the firebase integration, for didactic purposes in good design and quality practices. It would be possible?
Thanks

Hello @DQ322!
Thanks for being interested in this project. 😊 OK, I'll create a separate branch for the only frontend, and I'll remove the relevant backend integrations and keep only the UI code base. Could you please give me a week? These days, I'm really working on a huge project and haven't had any time to focus on my other projects. I'll create the branch and let you know. Stay connected. 😊
Thanks and best regards,
@dileepabandara

@dileepabandara Hello!
Thanks man! I'm excited for this update. I'll keep an eye out ;)

Hello @DQ322!
Sorry for my delay. 😢 Due to my college work and volunteer programs, I still have a full schedule. Sure. I already added your request to my TODO list and started working on the separate branch. I'll publish the UI-only branch once I've completed all requirements. Thanks for waiting. Stay connected. 😊


usermem / security: no user pointer sanitization

this simple user program could panic the kernel
#include <stdio.h>
#include <unistd.h>
#include <time.h>
#include <syscall.h>

int main(int argc, char *argv[])
{
	int res = syscall(SYS_clock_gettime, CLOCK_MONOTONIC, 0);
	printf("ret %d\n", res);
	return 0;
}

log:
[Print] [1/45400c0000|0] unhandle EXCEPTION: page_fault FAULT

This is because the syscall handler SysClockGetTime (among many others) copies to user buffer without sanity check.
    let clock = GetClock(task, clockID)?;
    let ts = clock.Now().Timespec();
    task.CopyOutObj(&ts, addr)?;

In this case I'm passing a null ptr. This causes a pagefault in kernel.
Actually, any illegal user pointer will cause a kernel panic. Because the Memcpy is called upon the user pointer in kernel space.

@shrik3 Thank you very much for the bug.

The issue is because we enable the "CopyDataWithPf" in config.json as debug. The feature will do the user/kernel memory copy based on page fault. When there is invalid address in user request, as the page fault has no good way to pass the error message to the caller api. The system will crash. The feature could get a little better performance than disable this. So I will disable this feature by default. And will create a PR after more test.

can confirm. The issue is gone with the CopyDataWithPf option turned off.


mpich2: cleanup derivation, rename to mpich

Motivation for this change
Some cleanup of the derivation (see below).
The official name of the package was changed from mpich2 to mpich in 2012 (https://www.mpich.org/about/overview/)
Things done

mpich2 -> mpich (added alias)
remove slurm dependency (not needed)
use most recent gfortran
turn enableParallelBulding on
ensure mpi[cc,cxx,fort] uses default compilers it was built with

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build mpich

Failure on x86_64-darwin (full log)
Attempted: mpich
Partial log (click to expand)
make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/private/tmp/nix-build-mpich-3.2.1.drv-0/mpich-3.2.1/examples'
make[2]: Leaving directory '/private/tmp/nix-build-mpich-3.2.1.drv-0/mpich-3.2.1/examples'
make[1]: Leaving directory '/private/tmp/nix-build-mpich-3.2.1.drv-0/mpich-3.2.1'
post-installation fixup
fix rpath: /nix/store/sply1rh5zfmlb5k43jqdpxll8a63hday-mpich-3.2.1/bin/mpichversion
/nix/store/nqc6apq24v1qll6a69bj3yh1ipwz26zs-stdenv-darwin/setup: line 108: patchelf: command not found
builder for '/nix/store/mqjyxq2n21mdmbx5kf3j7yzwfm6s0dnp-mpich-3.2.1.drv' failed with exit code 127
error: build of '/nix/store/mqjyxq2n21mdmbx5kf3j7yzwfm6s0dnp-mpich-3.2.1.drv' failed

Success on x86_64-linux (full log)
Attempted: mpich
Partial log (click to expand)
shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/hydra_pmi_proxy
shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/mpichversion
shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/mpiexec.hydra
shrinking /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin/mpivars
gzipping man pages under /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/lib  /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1/bin
patching script interpreter paths in /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1
checking for references to /build in /nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1...
/nix/store/l3n8ylswxvwf0221k736k8kzmwkfxpr0-mpich-3.2.1

Success on aarch64-linux (full log)
Attempted: mpich
Partial log (click to expand)
shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/bin/hydra_persist
shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib/libmpicxx.so.12.1.1
shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib/libmpifort.so.12.1.1
shrinking /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib/libmpi.so.12.1.1
gzipping man pages under /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/lib  /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1/bin
patching script interpreter paths in /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1
checking for references to /build in /nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1...
/nix/store/2w3v60scdg70p3h3qr683vwgff7c0qbr-mpich-3.2.1

I do not know how fix it on darwin, so I just remove it.


add Juneteenth Observed holiday support

Addresses #503
This adds support for the observed occurrences of United States Juneeteenth (June 19) holiday.  2021 and 2022 both have observed dates - (2021/06/18, 2022/06/20).  This small snippet should future proof the observed dates.

Merged on beta.. Thank you very much! :-) 👍


JSON API support

I wanted to know if there is any support for going from Objection to JSON API (http://jsonapi.org/format/).
Are there any known plugins for it? I searched a bit and could only find stuff regarding the JSON API of Postgres from Objection.

I haven’t heard that anyone has been working on it.

@chamini2 funny I find this question being asked by you? Abandoning Bookshelf? Thinking about doing the same and was looking for something similar to our mapper

Yeah @jamesdixon! I even saw you work on some Objection stuff. I am searching for something similar to jsonapi-mapper too! I even wrote to you on Gitter to see if you had any ideas on what to do.
No luck finding a mapper to JSON API?

Sorry about the no-reply on Gitter! I haven't been on there in ages!
I haven't found anything, so I'm guessing we'll probably need to write something. I haven't looked deep enough into the Objection object model, but it appears simpler from what I recall (used it on another project). I'm not sure if it can fit in as another ORM under the mapper or not.
Thoughts?

Btw, Bookshelf is definitely becoming problematic on our end as well. Admittedly, it would be quite a large refactor and I'm nervous to undertake it given the number of hacks and other things I put in place to "fill the gaps."

I was thinking that if I found no mapper I would use the jsonapi-serializer directly for a while to understand what kind of objects I need to be passing in it. And when I have a good understanding on it I planned on working in a jsonapi-mapper version.

Makes sense. Let me know if you decide to embark on creating a library/adding it to jsonapi-mapper.
Have you guys made the transition yet? If so, has it been painful?

I messaged you on GItter; feel free to reply there.

@chamini2 good reviews on that package?

Yeah, totally. The maintainer is replies fast and works as expected.

awesome, thanks!

@chamini2 can I ask you how you used the json-api-serializer packege? Did you implement the serializization and deserialization in the $parseJson and $formatJson? Do you have a working example that I can look at?
Cheers

Define your resources like:
const JSONAPISerializer = require('json-api-serializer');

const Serializer = new JSONAPISerializer({
  convertCase: 'kebab-case'
});

Serializer.register('activities', {
  id: 'id'
});

Serializer.register('guaranteed-dates', {
  id: 'id',
  relationships: {
    activity: {
      type: 'activities'
    }
  }
});

To be used like this:
const gdates = await GuaranteedDate
  .query()
  .innerJoinRelation('activity')
  .where({
    // Published and promoted
    'activity.published': true,
    'activity.promoted': true
  });

const data = Serializer.serialize('guaranteed-dates', map(gdates, (gdate) => gdate.toJSON()));
// data is the JSONAPI object


WASI: Greater isolation between fd and file functions

In one particular implementation of a WASM runtime (not yet public), we plan to support file descriptors but not a filesystem. It would be great if filesystem related functions could be a separate specification.
It would also generally be good to create a stronger separation between operations which work on file descriptors in general and those which work only on files in a filesystem. The precedent for this already exists in the __wasi_sock_*() functions.

Some preliminary thoughts here:
The API does use a naming scheme; __wasi_fd_* functions just operate on file descriptors, while __wasi_path_* operate on paths, so it's pretty easy to distinguish between them.
That said, the capability model doesn't depend on absolute paths at the syscall level, so there's no requirement for a traditional-looking filesystem (C:\ or /etc or anything else). In fact, it doesn't even need to be an actual filesystem; it's just a hierarchical namespace of resources, which could be entirely virtual, like Linux's /proc.

I have (not yet public) reasons for wanting these calls in a separate module. See #74 for my preferred approach.

Ok. FWIW, others have requested we split out the command-line argument and environment variable handling into separate modules too. I think these are reasonable, but it does feel like something we should do once we have a proper forum, such as a CG Subgroup, which we'll hopefully have soon.

I've requested an invite to the meeting. Hopefully, we'll be collaborating more directly in a short time.

The modularization PR has now landed, so this will be in the next snapshot!


Usage instructions should mention <-- toc --> marker at the beginning

It would help if the usage instructions said up front said something like:

Add the following line to your markdown file where you want your TOC inserted:
<-- toc -->
Run markdown-toc:
...

This information does appear much later in the README.md, but it would help to have it right up front also.
Let me know if I should submit a Pull Request for this.

It's listed in the CLI usage section under the -i flag since it's only used when "inserting" the TOC into the markdown file.
Feel free to submit a PR to clarify this since other people may miss that point too. There could be a "Quick start" section before "CLI" or something like that, that just shows a simple markdown file and the command to run.

Quick start
Create a markdown file: README.md
<!-- toc -->
# A

## aa

something in aa

## ab

something in ab

Run the markdown-toc command:
markdown-toc -i README.md

Something like that might provide some more information.

This was resolved in #100


Give feedback when attempting to load non-existent Safe

Overview
Is you try to load a Safe that doesn't exist/a malformed address, there is no feedback given to the user. A continuous loading spinner is shown.
It would be better to show a message to the use, by means of throwing an error or redirecting. The latter, however, gives no useful feedback to the user.
Requirements

Trigger crash/redirection when CGW throws error for non-existent Safe.

Already fixed.


(no merge) checking control unit test coverage

to compare against #2321

all good here :ok_hand:


ng test stop working on some machines after

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node:  9.4.0
npm: 6.3.0
o.s.: Windows server 2016
Repro steps
I have a strange behavior, when I'm running ng test  in my local environment, everything works fine.
However in my build agent, when running ng test  nothing happens (No error and event the karma header process doesn't show up). just nothing. nothing happens and the command exit with no errors and no tests.
I created a temp project in the build agent and it works fine.
Do you have any suggestion why I can't see anything? or why it happens?
The log given by the failure
I really wish I had that.
Desired functionality

Mention any other details that might be useful
angular packages:

/ \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|

/ △ \ | '_ \ /  | | | | |/ _ | '__|   | |   | |    | |
/ ___ | | | | (| | || | | (| | |      | || | | |
//   __| ||_, |_,||_,||       _|||
|___/
Angular CLI: 6.1.2
Node: 9.0.0
OS: win32 x64
Angular: 6.0.3
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic
... platform-server, router
Package                           Version
@angular-devkit/architect         0.7.2
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.7.2
@angular-devkit/schematics        0.7.2
@angular/cdk                      6.3.0
@angular/cli                      6.1.2
@angular/material                 6.3.0
@ngtools/webpack                  6.0.8
@schematics/angular               0.7.2
@schematics/update                0.7.2
rxjs                              6.2.0
typescript                        2.7.2
webpack                           4.8.3
Karma config
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
      require('karma-jasmine'),
      require('karma-chrome-launcher'),
      require('karma-jasmine-html-reporter'),
      require('karma-coverage-istanbul-reporter'),
      require('@angular-devkit/build-angular/plugins/karma'),
      require('karma-phantomjs-launcher'),
      require('karma-teamcity-reporter')
    ],
    client:{
      clearContext: false // leave Jasmine Spec Runner output visible in browser
    },
    files: [
      { pattern: './src/test.ts', watched: false }
    ],
    coverageIstanbulReporter: {
      dir: require('path').join(__dirname, 'coverage'), reports: [ 'html', 'lcovonly' ],
      fixWebpackSourcePaths: true
    },
    angularCli: {
      environment: 'dev'
    },
    reporters: config.angularCli && config.angularCli.codeCoverage
              ? ['progress', 'coverage-istanbul']
              : ['progress', 'teamcity'],

    port: 9877,
    colors: true,
    logLevel: config.LOG_INFO,
    autoWatch: true,
    browsers: ['Chrome'],
    singleRun: false,
    browserNoActivityTimeout: 60000

  });
};

test.ts:

import 'zone.js/dist/long-stack-trace-zone';
import 'zone.js/dist/proxy.js';
import 'zone.js/dist/sync-test';
import 'zone.js/dist/jasmine-patch';
import 'zone.js/dist/async-test';
import 'zone.js/dist/fake-async-test';
import { getTestBed } from '@angular/core/testing';
import {
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

// Unfortunately there's no typing for the `__karma__` variable. Just declare it as any.
declare var __karma__: any;
declare var require: any;

// Prevent Karma from running prematurely.
__karma__.loaded = function () {};

__karma__.loaded = function () {};

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting()
);
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
// Finally, start Karma to run the tests.
__karma__.start();

polyfills:
// the app. You can add your own extra polyfills to this file.
import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/set';
import 'core-js/es6/reflect';

import 'core-js/es7/reflect';
import 'zone.js/dist/zone';

Thanks a lot.

Sorry, I don't see how we could reproduce this. We don't have a machine that's in the bad state like your server. You need to gather more diagnostics in order for us to help you.

After doing some research, I realize that my machine is the only machine capable of running the test.
Other computers with the same configuration can't run the tests (again the message gets swollen).
When creating a dummy app the tests run perfectly.
I checked the Karma.config on the projects, my project uses the @angular-devkit/build-angular while the dummy project uses the angular\cli which one I should use??
Another question: is there any global packages the angular cli uses when it run tests that may cause this behavior?
Thanks,

Finally I got is solved!
I don't know what was the problem but after I created a new ng app and copied the following files to my app it worked!

karma.conf.js

test.ts

polyfills.ts


[$250] Expense - After editing expense details, page not scrolled and focused to system message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Open 1:1 chat
Submit an expense
Enter description and merchant

Expected Result:
After editing expense details, page must be scrolled and focused to system message.
Actual Result:
After editing expense details, page not scrolled and focused to system message.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/f886e84d-27ad-4619-93df-ca49b0fb77bb

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021845669426671518848
Upwork Job ID:<PHONE_NUMBER>671518848
Last Price Increase: 2024-10-21

Issue OwnerCurrent Issue Owner: @rojiphil

@VictoriaExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
After editing expense details, page not scrolled and focused to system message.
What is the root cause of that problem?
We don't notifyNewAction when updating all fields of money request
https://github.com/Expensify/App/blob/1220039898fa66fea87343c678c827b679394267/src/libs/actions/IOU.ts#L5574
What changes do you think we should make in order to solve the problem?
We should call notifyNewAction to scroll to the bottom after we edit the money request
Report.notifyNewAction(transactionThreadReportID, Report.getCurrentUserAccountID(), params.reportActionID);

https://github.com/Expensify/App/blob/1220039898fa66fea87343c678c827b679394267/src/libs/actions/IOU.ts#L5574
OPTIONAL: We can check if the transaction thread report is one transaction thread we will notifyNewAction to parentReport
We should do the same for other update money request functions.
What alternative solutions did you explore? (Optional)

hey @rojiphil - can you please review @bernhardoj 's proposal when you have a chance?

Sorry for the delay here. I will review this my day tomorrow and update.

Is anyone able to reproduce this? I am unable to reproduce as demonstrated below.
https://github.com/user-attachments/assets/5ac8e170-ec96-4fa9-a5b5-ca1cd2fd8eb0

Still reproducible
https://github.com/user-attachments/assets/e59f5d48-b5f8-461e-8fd8-a36c7459ab4f

Still reproducible

Ok. Will check again today.

We only enable shouldEnableAutoScrollToTopThreshold if we have the newest report action (hasNewestReportAction)

@bernhardoj Even when we hardcode hasNewestReportAction to true here, we can reproduce the problem as demonstrated below. So, it does not look like the RCA is correct.
https://github.com/user-attachments/assets/6568ae2f-2ee6-4f93-ad74-e19b1d25012c

The issue here is not about scrolling the user every time updating the money request, but the issue here is that, when you are at the bottom of the page, updating the money request doesn't show the update system message.
shouldEnableAutoScrollToTopThreshold autoscroll when scroll offset within 250.

The issue here is not about scrolling the user every time updating the money request, but the issue here is that, when you are at the bottom of the page, updating the money request doesn't show the update system message (as shown in my video here).
shouldEnableAutoScrollToTopThreshold autoscroll when scroll offset within 250.

Ah! Got it. Thanks @bernhardoj. Then, the RCA that  hasNewestReportAction is becoming false due to the order of updates in Onyx for new report action and the report’s lastVisibleActionCreated makes sense.
The approach to the solution seems tricky though. If I understand correctly, both the main and alternative solutions attempt to update the Onyx faster so that both reportActions.at(0)?.created and lastVisibleActionCreated arrive correctly.
Is my understanding correct?

Correct.

Correct.

@bernhardoj Thanks for the confirmation.  Then it is not guaranteed for reportActions.at(0)?.created and lastVisibleActionCreated to arrive correctly at the same time and at all times. So the proposed approach to the solution does not seem right.
Instead, can we not solve this independently of the way the updates are made in Onyx? That would be much neater though.

Instead, can we not solve this independently of the way the updates are made in Onyx?

Sorry, I don't get this one 😅 .

Well! What I meant is that even if  reportActions.at(0)?.created and lastVisibleActionCreated do not arrive updated at the same time, can we not handle this within ReportActionsView itself?

Hmm, I don't have any idea for that.

https://github.com/user-attachments/assets/a1656944-49ba-417c-8bc6-c410fb732f9b
@rojiphil It works fine on my test.

Hi @rojiphil Did you have a chance to review my proposal? My changed code works as expect, you can see the video as well.

Did you have a chance to review my proposal? My changed code works as expect, you can see the video as well.

There are no logic for notifying actions after editing an expense details.

@Anaslancer Thanks for the proposal. But I think this approach has already been proposed here. Also, I think the correct RCA is as mentioned here as this should have been working before even without adding the notifying actions.

Well! What I meant is that even if reportActions.at(0)?.created and lastVisibleActionCreated do not arrive updated at the same time, can we not handle this within ReportActionsView itself?

@bernhardoj Can we not handle this within ReportActionsView by maintaining a previous variable of hasNewestReportAction? I.e. const prevHasNewestReportAction = usePrevious(hasNewestReportAction); and use prevHasNewestReportAction while determining shouldEnableAutoScroll  i.e. const shouldEnableAutoScroll = ((hasNewestReportAction || prevHasNewestReportAction) &&
Would this work?

@rojiphil We should send the correct params when using notifyActions, and we should think when there are many expenses.

I think that would work for our case, but I think the logic expects to know whether currently we have the newest action or no, not whether we currently or previously have the newest report action. I still prefer to update the created value at the same time.

Issue not reproducible during KI retests. (First week)

Will review again today

I think if there are many expenses, we can't solve this issue with @mkzie2 proposal.
It is main difference with my proposal.

@Anaslancer I am not sure if I understood you. Can you please explain?

At this case, we should send the correct params.
    const parentReportAction = ReportActionsUtils.getReportAction(transactionThreadReport?.parentReportID ?? '-1', transactionThreadReport?.parentReportActionID ?? '-1');
    const currentReportID = ReportUtils.isOneTransactionThread(transactionThreadReport?.reportID ?? '', transactionThreadReport?.parentReportID ?? '', parentReportAction) ? params.reportID : transactionThreadReport?.reportID;
    Report.notifyNewAction(currentReportID ?? '-1', Number(parentReport?.lastActorAccountID ?? '-1'));

You can test this.

At this case, we should send the correct params.

@Anaslancer Ok. But the same step is already mentioned in the selected proposal as referenced below.

We can check if the transaction thread report is one transaction thread we will notifyNewAction to parentReport

Just want to point out that adding Report.notifyNewAction will scroll the chat to the bottom anytime we edit the money request which is not an expected behavior, at least from this past issue.

Ah! That makes sense. And we are back to square one again.
@stitesExpensify Pausing the C+ reviewed status here until we have more clarity on the correct approach.

Issue not reproducible during KI retests. (Second week)

Not reproducible 2 weeks in a row, closing.

@stitesExpensify still easily reproducible
https://github.com/user-attachments/assets/ac722f94-6eac-4ff6-b97f-30e2d6712cda

Hm CC @mvtglobally can you double check that this is not reproducible? It looks like @bernhardoj just did it

Issue not reproducible during KI retests. (Third week)

@mvtglobally can you please post a video of this working correctly? From @bernhardoj 's post it looks like it is still happening

Reached out to #QA for an update

Will look into this today and update.

Issue not reproducible during KI retests. (Fourth week)

Issue not reproducible during KI retests. (Fifth week)


tutorial-five(topics) teaser_answer_2 is wrong

https://www.rabbitmq.com/tutorials/tutorial-five-python.html#teaser_answer_2

Will "#.*" catch a message with a string ".." as a key? Will it catch a message with a single word key?
No. (but I don't know why!)
./receive_logs_topic.py "#.*"
./emit_log_topic.py ".."

it should be Yes.  i've tested on management ui

I think the entire thing has to go because that question has little practical value.


Issue when creating vnet with az cli

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network vnet create
Errors:
'registrationState'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 654, in execute
    raise ex
cli/core/commands/__init__.py, ln 718, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 711, in _run_job
    six.reraise(*sys.exc_info())
...
python3.6/site-packages/msrestazure/tools.py, ln 57, in register_rp_hook
    if not _register_rp(session, url_prefix, rp_name):
python3.6/site-packages/msrestazure/tools.py, ln 102, in _register_rp
    if rp_info['registrationState'] == 'Registered':
KeyError: 'registrationState'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network vnet create -g {} -n {} --address-prefixes {} --subnet-name {} --subnet-prefixes {}

Expected Behavior
Environment Summary
Linux-4.15.0-1098-azure-x86_64-with-debian-stretch-sid (Cloud Shell)
Python 3.6.10
Installer: DEB

azure-cli 2.14.0 *

Extensions:
ai-examples 0.2.4

Additional Context

network

I cannot reproduce your situation. Could you try it again to see if it stably happened your environment ?

Sorry I didn't reply sooner. I just executed the same command from the history and it worked. I don't know, I just logged back in, looked for the command and it worked.
I can see that there is another thing going on, but everything is fine with me now.
FYI the commands are:
$rg = (Get-AzResourceGroup).ResourceGroupName
az network vnet create -g $rg -n CloudLorcoVNet --address-prefixes <IP_ADDRESS>/16 --subnet-name WebSubnet --subnet-prefixes <IP_ADDRESS>/24
Thanks!

I cannot reproduce your situation. Could you try it again to see if it stably happened your environment ?

@lorcopotia Glab that you made it work. Yeah, these cases are not easy to reproduce maybe you are in the middle of a service rollout of sort.


Two children with the same key

I am getting this error when using a React component in lieu of message: https://gyazo.com/47207e774cf5a7de5226995e5c73e002
My code preparing the message props: https://gyazo.com/c9c8b3f40ed7eaee50f22738e61e0e8b
What am I missing?

It happens when I show multiple notifications, and one of them is 'leaving'

The error message you've provided doesn't have anything to do with the message prop. You're passing in two notifications with the same key 0 and that's throwing an error in React. Can you provide more code, preferably the entire component in JSBin?

I have tried adding key in multiple places (note that it works when I only
use text):
This is my render function:
https://gyazo.com/ed3de1272815e55bece1b2b8c9a4a8e4
This is my mapToStateProps function:
https://gyazo.com/1fdb5e754841d65955fee46452b60fb5
This is my addNotification function:
https://gyazo.com/0201ce96a712f37372ca5018ac3ead9d
Aymeric Gaurat-Apelli
Founder of WeekPlan
http://weekplan.net
On Sat, May 20, 2017 at 11:15 PM, Patrick Burtchaell <
<EMAIL_ADDRESS>wrote:

The error message you've provided doesn't have anything to do with the
message prop. You're passing in two notifications with the same key 0 and
that's throwing an error in React. Can you provide more code, preferably
the entire component in JSBin?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pburtchaell/react-notification/issues/121#issuecomment-302872585,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbPwu7gNcBvw7dr1XGlcub5j2e1QKIcks5r7udegaJpZM4NhNNL
.

The key doesn't go on the message. It should be included in the notification object (see example). You'll want to update your mapStateToProps function to fix this.
This error is caused by you having two notifications with the same key and isn't an issue with the library. Make sure you never have two notifications with the key 0.
On a side note, when you include code examples it's more helpful to put code in the comment itself. Links to screenshots are not particularly helpful because I can't copy/paste your code and I have to switch between tabs to see each screenshot. Thanks!

Thanks for the great help. Found out that my reducer was setting the key property incorrectly. It is working now.
(And yes, sorry for the screenshots.)


ticking entity crash

so here we have Fabric 1.18.2   with 0.13.3.  and fabric-api-0.48.0+1.18.2.jar
fish_of_thieves-mc1.18.2-v1.0.3-fabric
not sure whats going on.. but i was testing out my modpack and doing some work on it.. when i had a world crash.. while not in overworld.
my modpack consists of over 300 mods.  on 1.18.2.  i have a mod called dimensional doors... which adds a roulette type dimensional door for different events.    a fish from Fish of thieves tried spawned in that dimensions water.   then this crash.
(https://pastebin.ubuntu.com/p/PDmz4yVMXv/)
https://www.curseforge.com/minecraft/modpacks/rankersmp-exploratory-revelations
is my modpack. crash happened

Can you do more test? Try uninstall FOT, press F3 in the dimension that causes crash and send a screenshot. I wanted to see what "Biome builder PV: ..." looks like.

your mod still enabled . as its only upon the fish spawning i believe.

the doors take you to a random premade dim. theres a whole bunch of them.. so to get the specfic one i crashed in before,, may prove to be difficult. this one has water so i would expect simliar results if fish spawned

Fixed in 1.0.6, it shouldn't crash in other dimensions anymore. Hopefully.


Update homepage to include a comment section that takes user input

Comment Section contains an HTML Form that sends comment information to the URL /data, and displays the comment on the homepage as an unordered list.

Will do, thanks for the feedback!


Fix the CHANGELOG.md release links

What does this PR do?
Fixes the CHANGELOG.md release links.
Which TC components are affected by this PR?

[x] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] Other _________

What is the best way to verify this PR?
Check all that apply

[ ] This PR includes tests
[ ] This PR includes documentation updates
[ ] This PR includes an update to CHANGELOG.md
[ ] This PR includes all required license headers
[ ] This PR includes a database migration (ensure that migration sequence is correct)
[ ] This PR fixes a serious security flaw. Read more: www.apache.org/security

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2681/
Test PASSed.


Using rerun_filter causes INTERNALERROR

With the new version and rerunning the setup, I was able to start using flaky. But when I added a rerun_filter to the tests, I get the following error
INTERNALERROR> TypeError: 'NoneType' object is not subscriptable
Some digging into it looks like the err param is being passed as None to the rerun filter method:
def is_not_video_error(err, *args):
    raise not issubclass(err[0], VideoProcessingException))

@flaky(rerun_filter=is_not_video_error)
class ...

Here's the full stack trace: http://pastebin.com/kY7nE8E8
Am i missing something in my code?

Thanks for the report. I'll look into it this weekend!


CAMEL-10785 - add revapi integration (considering current SNAPHOT and…

… latest version of release) for camel-core to avoid maintenance problems for whole codebase

That json file should possible be disabled in the RAT check (see verify with headers)
http://camel.apache.org/release-guide.html

added to exclude list.

Thanks @davsclaus .


EID-1985 - Add SubjectConfirmationData to eidas response

Why
Adding <SubjectConfirmation> and its child element <SubjectConfirmationData> to our eidas response assertion will make it easier for SAML parsing clients to process this expected but not mandatory element. It also constrains the circumstances under which the act of subject confirmation can take place.
The eIDAS spec does not require a <SubjectConfirmation>, but according to eidas colleagues, the lack of it is a problem for the eIDAS eGov and saml2int profiles.
What
Add a <SubjectConfirmation> to <Subject> with method “urn:oasis:names:tc:saml2:2.0:cm:bearer”
Add a <SubjectConfirmationData> to <SubjectConfirmation> with attributes:

NotBefore - time of now
NotOnOrAfter - time of now plus 5 minutes, the same as  <saml2:Conditions NotOnOrAfter attribute
Recipient - the same as response destination, for example  <saml2p:Response Destination="http://localhost:6610/SAML2/Response/POST"
InResponseTo - the eidas request id, the same as response InResponseTo, for example <saml2p:Response InResponseTo="_ad54dcc675afcc0c26898390cfc92828"

With this commit I can produce a SAML response in local stub connector containing:
<saml2:Subject>
    <saml2:NameID Format="urn:oasis:names:tc:SAML:2.0:nameid-format:persistent">GB/EU/44a276db28130110f83260bff62f547da4cb08b788ba895fbdcecb73bd70c0fb</saml2:NameID>
    <saml2:SubjectConfirmation Method="urn:oasis:names:tc:saml2:2.0:cm:bearer">
        <saml2:SubjectConfirmationData
                InResponseTo="_ad54dcc675afcc0c26898390cfc92828"
                NotBefore="2020-06-09T08:47:23.210Z"
                NotOnOrAfter="2020-06-09T08:52:23.210Z"
               Recipient="http://localhost:6610/SAML2/Response/POST"/>
    </saml2:SubjectConfirmation>
</saml2:Subject>

See https://govukverify.atlassian.net/browse/EID-1985

This is consistent with the eIDAS spec (SAML Message Format, p. 21)
<saml2:Subject>
<saml2:NameID Format="urn:oasis:names:tc:saml2:2.0:nameid-format:persistent"
> ES/AT/02635542Y </saml2:NameID>
<saml2:SubjectConfirmation Method="urn:oasis:names:tc:saml2:2.0:cm:bearer">
<saml2:SubjectConfirmationData InResponseTo="_171ccc6b39b1e8f6e762c2e4ee4ded3a" NotOnOrAfter="2015-04-30T19:32:20.157Z" Recipient="https://eidas-connector.eu/post"/>
</saml2:SubjectConfirmation>
</saml2:Subject>


Add check HaveLen(0)

The linter now warns for HaveLen(0), and suggests using BeEmpty() instead
Support new parameter: allow-havelen-0. Default is false. If true, the linter will not warn for HaveLen(0).
Fixes #46

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

47 of 53 (88.68%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 87.56%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ginkgo_linter.go
39
40
97.5%

types/config.go
8
13
61.54%

Files with Coverage Reduction
New Missed Lines
%

ginkgo_linter.go
3
89.56%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
549

Relevant Lines:
627

💛  - Coveralls


Usemin replaces minified css with open link tags

<link /> tags are replaced with their minified counterparts as <link > tags, making the xhtml invalid.
This was Fixed with #103 , but the issue was recreated due to code changes.
Or is there a way to specify the closing of a link tag ?
I think the problem lies at this line of code https://github.com/yeoman/grunt-usemin/blob/master/lib/fileprocessor.js#L110 and could be fixed easy easily

See https://github.com/yeoman/grunt-usemin/pull/509#issuecomment-72494408
Closing link tag is XHTML which should not be used.

Could this be reopened? I am trying to use yeoman with Spring Boot and Thymeleaf. Where thymeleaf is based on XHTML. With this open-tags issue, I can't use it with spring boot.


1.16.x: 4.2 - CustomStructure BO3

Implement BO3 customstructures for 1.16.x.

Should work, needs testing.


Update testing and linting dependencies

Some dev dependencies, specifically these about linting and testing, are not automatically updated every Monday.
Some of them are becoming not compatible with certain version of dependencies we do update. For example typescript-eslint and typescript itself.
Thus, we should update all of the outdated dependencies.
Use
npm outdated to find them.

@bidoubiwa can you assign this issue to me?

Not critical and stale, closing


Fix code scanning alert - Polynomial regular expression used on uncontrolled data

Tracking issue for:

[x] https://github.com/gilbertalgordo/proxy-verifier/security/code-scanning/1

https://gist.github.com/gilbertalgordo


TypeError in TraitsTransform due to Series when str expected

Build currently encounters this problem:
14:33:09  Traceback (most recent call last):
14:33:09    File "run.py", line 121, in <module>
14:33:09      cli()
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/venv/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
14:33:09      return self.main(*args, **kwargs)
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/venv/lib/python3.8/site-packages/click/core.py", line 1055, in main
14:33:09      rv = self.invoke(ctx)
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/venv/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
14:33:09      return _process_result(sub_ctx.command.invoke(sub_ctx))
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/venv/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
14:33:09      return ctx.invoke(self.callback, **ctx.params)
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/venv/lib/python3.8/site-packages/click/core.py", line 760, in invoke
14:33:09      return __callback(*args, **kwargs)
14:33:09    File "run.py", line 69, in transform
14:33:09      kg_transform(*args, **kwargs)
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/kg_microbe/transform.py", line 43, in transform
14:33:09      t.run()
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/kg_microbe/transform_utils/traits/traits.py", line 500, in run
14:33:09      write_node_edge_item(
14:33:09    File "/var/lib/jenkins/workspace/edge-graph-hub_kg-microbe_master/gitrepo/kg_microbe/utils/transform_utils.py", line 83, in write_node_edge_item
14:33:09      fh.write(sep.join(data) + "\n")
14:33:09  TypeError: sequence item 2: expected str instance, Series found

This function attempts to write a single tab-delimited list of strings to a file, but in this case, it can't join the data because it's passed a pandas Series.

Strangely enough, this completes as expected on a local run of python run.py transform -s TraitsTransform


cmd/go: goinstall -installsuffix={..} {package} attempts to install to $GOROOT/bin

it looks like its trying to reinstall the runtime package with my suffix?
[jatone]$ $PWD
bash: /home/james-lawrence/development/gilo: Is a directory
[jatone]$ ls -lha bin/
total 8.0K
drwxr-xr-x 2 jatone jatone 4.0K May 30 07:11 .
drwxr-xr-x 5 jatone jatone 4.0K May 30 06:43 ..

[jatone]$ go env
GOARCH="amd64"
GOBIN="/home/james-lawrence/development/gilo/bin"
GOCHAR="6"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/james-lawrence/development/gilo"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

[jatone]$ go install --installsuffix="abc" bitbucket.org/jatone/gilo/commands/...
go install runtime: mkdir /usr/lib/go/pkg/linux_amd64_abc/: permission denied

[jatone]$ ls -lha bin/
total 8.0K
drwxr-xr-x 2 jatone jatone 4.0K May 30 07:11 .
drwxr-xr-x 5 jatone jatone 4.0K May 30 06:43 ..

[jatone]$ go install bitbucket.org/jatone/gilo/commands/...
[jatone]$ ls -lha bin/
total 15M
drwxr-xr-x 2 jatone jatone 4.0K May 30 07:13 .
drwxr-xr-x 5 jatone jatone 4.0K May 30 06:43 ..
-rwxr-xr-x 1 jatone jatone 4.5M May 30 07:13 gilo
-rwxr-xr-x 1 jatone jatone 6.7M May 30 07:13 gilod
-rwxr-xr-x 1 jatone jatone 3.1M May 30 07:13 gilo-shim

go help build says:
-installsuffix suffix
a suffix to use in the name of the package installation directory,
in order to keep output separate from default builds.
If using the -race flag, the install suffix is automatically set to race
or, if set explicitly, has _race appended to it.
unclear from that documentation that it'll recompile packages in GOROOT, I was only expecting stuff from the GOPATH environment variable to be impacted.

Which version of go?

I don't see a problem here.
go install --installsuffix="abc" bitbucket.org/jatone/gilo/commands/...
will also try to (re)installed the standard libraries (because there is
no installation of standard library with installsuffix abc). And that's
why it tries to write to $GOROOT/pkg/linux_amd64_abc.
go env showed that you have set $GOBIN, which will the location
all installed commands go.

Basically, install suffix is a global setting, see
http://golang.org/pkg/go/build/#Context
so if set, all packages will go into a separate
directory.

See also #10210

Yes, this is how it's supposed to work. -installsuffix applies to all code, not just GOPATH.


rustic-test-arguments for rustic-cargo-current-test

Hi guys,
is there any way to configure extra flags for rustic-cargo-current-test because if my case some tests are hidden behind feature flags
so for all tests I've enabled it using .dir-local.el file like
...
 (rustic-mode . ((rustic-test-arguments . --all-features))))

but when I run rustic-cargo-current-test there is no way pass these flags because it's been overridden by the test name
Thank you in advance!

I found a  workaround using
.cargo/config.timl
[alias]
t = "test --all-features"

and .dir-locals.el
(rustic-mode . ((rustic-cargo-test-exec-command . "t")
                 (rustic-test-arguments . "")))


[Question]:

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
The documentation for persisting and storing index's isn't clear.
For example I get the error Cannot initialize from a vector store that does not store text. when all the documents are that is loaded is .md files, or in otherwords text. I can't seem to find much help on the topic, and the documentation shows the usage just how I use it save for the service context -- and isn't clear what can and cannot be stored.
I store like:
        temp = folder_paths.get_temp_directory()
        vector_path = os.path.join(temp, str(uuid.uuid4()))

        llm_index.storage_context.persist(persist_dir=vector_path)

And load like:
        if not os.path.exists(vector_store_path) or not os.path.isdir(vector_store_path):
            raise Exception(f"Invalid vector store path: {vector_store_path}")

        storage_context = StorageContext.from_defaults(persist_dir=vector_store_path)
        llm_index = VectorStoreIndex.from_vector_store(
            vector_store=storage_context.vector_store,
            storage_context=storage_context,
            service_context=llm_service_context
        )

You should be loading with
index = load_index_from_storage(storage_context, service_context=service_context)

Ohh! Well that would do it. Thanks for the prompt reply!


⚠ Bofrost.at has degraded performance

In aa30308, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1966 ms

Resolved: Bofrost.at performance has improved in 85fac75 after 45 minutes.


Adding validation loss to progress bar when doing a model fit

Background and Context
Currently only the average training loss is shown, which is usually not human interpretable. Keras, for example, shows the validation loss on its progress bar.
Description
Adding the validation loss to the progress bar message, if early stopping is set up.

Solved: https://github.com/Accenture/AmpliGraph/commit/6252b63c06d3463c441b3cef816695134132fa94


MacOS Segmentation fault in "cvtColor"

Expected behaviour
Using cv2.cvtColor with the option cv2.COLOR_GRAY2BGR to transform a one channel grayscale image (2d numpy ndarray) to a three-dimensional gray color image.
Actual behaviour
Giving a segmentation fault on specific image dimensions on MacOS. I also tried to reproduce it on a ubuntu or a windows machine, but there no segmentation fault happened. However, even on different MacOS machines the segmentation fault happens on specific image dimensions.
Steps to reproduce

code to reproduce the error:

import cv2
import numpy as np

img = np.zeros((2048, 100), dtype=np.uint8)
test = cv2.cvtColor(img, cv2.COLOR_GRAY2BGR)

operating system: MacOS High Sierra 10.13.2

opencv-python version <IP_ADDRESS> (also occurred with older versions)

Closing this for inactivity. Please reopen if this is still a problem for you.


fix(select): ASelect example with slots are not working

Based on issue #38  I fixed the blank selected value of the ASelect component

You are so active 💚
Thanks.


remove absolute path for reverse proxy

Hi, thanks for the great extension.
Sorry, I accidentally closed the PR earlier.
If you want to run WebUI on public cloud (aws, gcp, etc) with https, there is a restriction that you can not directly bind to the external address from inside the machine, so I think it is common to do as follows.
・Bind the WebUI to the local address (<IP_ADDRESS>)
・Bind nginx to an external address and operate as a reverse proxy to transfer to WebUI
However, since there is a part written with an absolute path, javascript seems to get stuck trying to access the user's local machine (<IP_ADDRESS>). If there is a reason why it must be an absolute path, I will give up, but I would be happy if you could merge it.
Thanks.

Sorry, I'm closing this simple solution because I understand that it will interfere with others.


License unclear

The license is unclear from the project source code. There is no LICENSE file in the repository. The setup.py mentions "GPL", but does not refer to a specific version. Does this mean it's 2+ or 3+ ?

b40404f8de4c03778bd38ca3b71f0ae51b1b3733


docs: update contributing guide

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #676 🦕
Related to https://github.com/googleapis/release-please/pull/419

@erezrokah thank you for the contribution 👍 one tiny tweak, we should add CONTRIBUTING to this exclude list:
https://github.com/googleapis/release-please/blob/master/synth.py#L10
So that it doesn't get replaced nightly by automation.

@erezrokah thank you for the contribution 👍 one tiny tweak, we should add CONTRIBUTING to this exclude list:
https://github.com/googleapis/release-please/blob/master/synth.py#L10
So that it doesn't get replaced nightly by automation.

@erezrokah thank you for the contribution 👍 one tiny tweak, we should add CONTRIBUTING to this exclude list:
https://github.com/googleapis/release-please/blob/master/synth.py#L10
So that it doesn't get replaced nightly by automation.

Done in b1b0b951ebd0f8f16078dd88f2c1984b75de3b92

@erezrokah thank you for the contribution 👍 one tiny tweak, we should add CONTRIBUTING to this exclude list:
https://github.com/googleapis/release-please/blob/master/synth.py#L10
So that it doesn't get replaced nightly by automation.

Done in b1b0b951ebd0f8f16078dd88f2c1984b75de3b92


Using ]]> dont work proberly

If you write something like this it doesn't show proberly. A extra ]]> is added at the end at the webpage :
<script type="text/syntaxhighlighter" class="brush: js; html-script: true"><![CDATA[

function visnogettekst() {

   var tekst =
        '<script type="text/javascript">'
      + '// <![CDATA[' + '\r\n'
      + 'x = 0;'
      + '// ]]>' + '\r\n'
      + '</script>';

}

]]>
</script>

You have to escape the <![CDATA[ and ]]> which are inside the script tag. It is similar to having a script tag which itself includes a string like "</script>". The browser will end it there, it doesnt matter it is inside a string and is not supposed to be the actual end </script> tag. In fact it is the actual end </script> tag because the javascript in this case is embedded and the html/xml semantics have precedence over embedded javascript semantics..


lyne-timetable-row-column-headers

state: in progress
figma:
dev: https://lyne.sbb.ch/components/lyne-timetable-row-column-headers
ux quality-check
code quality-check
refactoring (optionaly)
testing

Feature Description
We want to review/refactor the lyne-button implementation.
https://lyne.sbb.ch/components/lyne-button
[Figma Spec]

dev: https://lyne.sbb.ch/components/lyne-timetable-row-column-headers

References
Design Spec
Technical Spec

Definition of Done

[ ]  ux quality-check
[ ]  code quality-check
[ ]  refactoring (optionaly)
[ ]  testing
[ ]  Component is implemented
[ ]  Tests are implemented
[ ]  E2E Tests are implemented
[ ]  Storybook stories are implemented
[ ]  Navigation via keyboard is tested
[ ]  Screen reader output is tested
[ ]  High-contrast is tested
[ ]  Remaining accessibility is tested
[ ]  UX approved

Will be tracked/decided in #1901


Boostrap 5 modal close all modals

If i have 2 modals and i click on second modal close, close both modal

Multiple modals are still not supported in Bootstrap, this is expected.

Multiple modals are still not supported in Bootstrap, this is expected.

i found solution:

title
...

i found solution:

title
...


KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the PR, @dongjinleekr !
Just a couple of meta-questions:

Should we have some tests for this change?
I think that right now, we'd be leaving behind some task directories and lock files. Maybe, we need to do a little extra legwork to recursively delete the app state directory. An integration test would probably surface this.

Hi @vvcephei,

Sure. I added some validations in StateDirectoryTest.

If StateDirectory#clean is called, the empty appDir is also deleted. (see StateDirectoryTest#shouldLogManualUserCallMessage.)

If StateDirectory#clean is not called, the global state directory and it parent, appDir is not deleted. (see StateDirectoryTest#shouldLogStateDirCleanerMessage.)
Please note the difference in StateDirectoryTest#shouldCleanupAllTaskDirectoriesIncludingGlobalOne; the appDir was an empty directory before but it is now deleted.

Since the goal of this modification is deleting the empty directory, we don't need a recursive delete; it is also why I called File#delete here, since it works and returns true iff the target directory is empty.

And one more thing: I added an exception handling for SecurityException. :smile:

it seems like we could improve the test coverage by checking that we get the warning and do not delete the state dir if it's not empty.

Totally agree. So, I added two dedicated tests for these cases. See the following test methods:

StateDirectoryTest#shouldDeleteAppDirWhenCleanUpIfEmpty
StateDirectoryTest#shouldNotDeleteAppDirWhenCleanUpIfNotEmpty

I also added an integration test, StateDirectoryIntegrationTest. How about this? :smiley:

@vvcephei Here it is; I updated the timeout to IntegrationTestUtils.DEFAULT_TIMEOUT and rebased onto the latest trunk also.

Hmm, actually I see those same 20 tests fail for me locally. Can you take a look, @dongjinleekr ?

Just for reference, I don't see those failing tests on trunk (67bc4f08feb50ac135a4d8e1d469747102aad3a6).

@vvcephei Here it is; I deleted a outdated condition statement in EOSUncleanShutdownIntegrationTest.

Thanks for that fix, @dongjinleekr !
Unfortunately, there are still 61 test failures: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9414/6/?cloudbees-analytics-link=scm-reporting%2Fstage%2Ffailure#showFailuresLink
Do you mind taking another look?

Hey @dongjinleekr , just a quick check-in: do you plan to take a look at the test failures?

Hi @vvcephei,
Sorry for being late. Defending myself, I have been too busy to finalize my project last week, and it ended yesterday. Sure, I am now resolving the broken tests. There are 21 broken tests with the latest trunk, and I just resolved 16 of them. It will be completed soon.

Perfect. Thanks, @dongjinleekr !
No defense is necessary :) I was just wondering if it was still on your radar.
Thanks again for the contribution!

Hi @vvcephei,
Here is the fix. The reason for the broken integration tests was: KafkaStreams#cleanUp can be called regardless of the StreamThreads are terminated.
That is, if KafkaStreams#cleanUp is called when the KafkaStreams is still running, the {state-store-directory}/{application-id} directory is deleted and  StreamThread crashes with the exception from StateDirectory#directoryForTask - since it fails to create the task state store directory, i.e., {state-store-directory}/{application-id}/{task-id}.
Moreover, StateDirectory#directoryForTask method has two additional vulnerabilities:

When it creates the task state store directory, it does not create its parent directories automatically - if there is not {state-store-directory}/{application-id}, taskDir.mkdir() returns false and it throws an exception. For this behavior breaks the integration tests, I modified taskDir.mkdir() to taskDir.mkdirs() to create {state-store-directory}/{application-id} automatically.
This method only checks whether there is a File at {state-store-directory}/{application-id}/{task-id}, regardless of it is actually a directory or not. I added an additional check condition for this case and StateDirectoryTest#shouldThrowProcessorStateException is updated accordingly.

Hi @vvcephei,
I re-based the branch onto the latest trunk, reorganized the changes into two commits, and fixed EOSUncleanShutdownIntegrationTest#shouldWorkWithUncleanShutdownWipeOutStateStore - Sure, its contents do not follow the description of its name. :wink:

Retest this please.

Rebased onto the latest trunk.

Rebased onto the latest trunk. cc/ @vvcephei @mjsax

Rebased onto the latest trunk. cc/ @vvcephei @mjsax

Hi @vvcephei,
It seems like I have failed to understand your intention correctly. Here is the fix. I reorganized the PR into two commits, one for StateDirectory and the other one for EOSUncleanShutdownIntegrationTest. The following summarizes the updates:

Rebase the PR onto the latest trunk, resolving all broken syntaxes.
Remove redundant assertion in StateDirectoryTest#shouldNotDeleteAppDirWhenCleanUpIfNotEmpty; it now validates logging message only.
Make StateDirectoryIntegrationTest to use default timeout (IntegrationTestUtils.DEFAULT_TIMEOUT) with its latches, keeping the suite from being flaky.

Add to this, I also updated EOSUncleanShutdownIntegrationTest also. I inspected the history of this test suite precisely and found the following:

This suite was introduced in c2ec974 by @abbccdda. It asserts that the Task's statestore directory (not root one in KafkaStreams's state.dir property) is deleted after an unclean shutdown. However, IMHO this assertion is a little bit inaccurate since the Task's statestore directory may not be deleted, for example, with an empty checkpoint file.
A comment is added on L160 in d3c067f by @guozhangwang - 'the state directory should still exist with the empty checkpoint file'. However, IMHO this comment seems to be a mistake, since assertFalse(stateDir.exists()); on L161 asserts that the Task's statestore directory does not exist.

There are some other commits on this file later, but all of them are just minor improvements, not changing the testing logic.
With this PR, Kafka Streams now deletes the empty application statestore directory (i.e., {state.dir}/{application.id}). So, I improved this suite like this:

After initialization, wait until the Task's statestore directory is populated. (i.e., {state.dir}/{application.id}/0_0/*)
Assert that one of the following is satisfied:

The Task's statestore directory is empty, so deleted.
The Task's statestore directory is not empty but without a checkpoint file.
The Task's statestore directory is not empty but with an empty checkpoint file.

(Wait, then should we separate the modifications on EOSUncleanShutdownIntegrationTest into an independent PR?)
Please have a look when you are free. Thanks again for reviewing my PR! :smiley:

@dongjinleekr @vvcephei just checking are you still working on it? I saw @vvcephei has approved the PR but it was not yet merged, hence asking.

Hi @guozhangwang,
Thanks for your mention. I completed applying @vvcephei's comment (on March 25, 2021) and awaiting review and merging, with maintaining the PR to the latest trunk.
As you can see here, this issue was started much earlier but It seems like I misunderstood @vvcephei's intention. 😢 And I recognized it this March.

@dongjinleekr just FYI, I know @vvcephei was quite swamped in the past months with pretty heavy release management duties -- you'd see his email about 2.8.0 release, which was all thanks to him -- so I believe it's just he was too busy with 2.8.0 to review your PRs, and I'd like to thank you for your patience!
@vvcephei whenever you have time please let know if the current PR is good or not.

I know @vvcephei was quite swamped in the past months with pretty heavy release management duties.

Totally agree. It's also why I did not press him. :smile: I rebased the PR into the latest trunk and checked it passes all tests!

Hi @guozhangwang @vvcephei,
Could you have a look now? :smiley:

Rebased onto the latest trunk. cc/ @vvcephei


simple-license-mapping: Add an entry for "Python"

As found in 1.
Signed-off-by: Thomas Steenbergen<EMAIL_ADDRESS>

Closing as invalid

Mind sharing some details on how you came to that conclusion for reference?


Inverse of many-to-many association

Hi guys,
I just made inverse of many-to-many association support into MongoMapper. Essentially, it's using (and depends on having defined) normal "many :in => xxx" association. You use it with the following API:
class Book
key :author_ids, Array
many :authors, :in => :author_ids
end
class Author
many :books, :in_foreign => {:author_ids}, :as => :author
end
Please let me know if that's any good. I was thinking there is a possibility to have some base class for InArrayProxy and InForeignArrayProxy, as well as test cases, but would be good if you could let me know if you want to keep those separate or I should do it.

There was some [discussion on the syntax in #e755e1aa] (https://github.com/jnunemaker/mongomapper/commit/e755e1aab0257e575e46777ceab13ea4619cf905#comments)

I'm merging this and going to use "from" for now.
We can always rename / change keys later.  Perfect is definitely the enemy of done.

Also I suspect that the best syntax to use here is :foreign_key => :model_ids, :as => "Model".
One implementation detail: instead of having a bunch of different proxy classes, why not just have one baseManyDocumentsProxy class + extend with a variety of modules (a ManyEmbeddedPolymorphicProxy module, etc)?

Merged in 8030d11024c3316e11e9f0d18457911618aafa5e

@smtlaissezfaire Awesome. Thanks for fixing.


Create a private app without user entry on the database.

I want to create a private app, on the installation time don't want to any store user entry on the database user table. it is possible? and what steps I have to follow for this? @osiset

In discussions


Bubble animation

Bubbles animate based on direction dino is facing
Bubbles float to top
Dinosaur and bubble functionality pulled out into separate files and required

Thanks for the file extraction!


Event types for Microsoft Graph messages

What are event types for Microsoft Graph message resource type?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c5c2bc5f-d124-b0d9-644b-e57b5720423c
Version Independent ID: ac6cf8e4-e55e-2c1a-231e-fd14efb3aad6
Content: Outlook events in Azure Event Grid - Azure Event Grid
Content Source: articles/event-grid/outlook-events.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

@MartinM85
Thanks for your feedback! We will investigate and update as appropriate.

This information is here: https://learn.microsoft.com/en-us/azure/event-grid/partner-events-graph-api
We will update the table to match in this document: https://learn.microsoft.com/en-us/azure/event-grid/subscribe-to-graph-api-events?context=graph%2Fcontext&view=graph-rest-1.0&tabs=http#why-should-i-subscribe-to-events-from-microsoft-graph-api-sources-via-event-grid
Thanks for the feedback

@george-guirguis Thank you for the response.
This doc: https://learn.microsoft.com/en-us/azure/event-grid/outlook-events mentions only event types related to event and contact resource, so I was curious whether the event types for message resource will be something like:
Microsoft.Graph.MessageCreated
Microsoft.Graph.MessageUpdated
Microsoft.Graph.MessageDeleted

Yes. That's right. I will work with the concerned team to update the content. Thanks.

@MartinM85
We have taken an action item to document the event types supported by Message resource from Microsoft Outlook.
Thanks for reporting the issue.
#please-close


Add scaledown-auto-scaling-groups trick

Closes #21

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        15    +1
  Lines          975      1033   +58
  Branches       173       177    +4
=========================================
+ Hits           975      1033   +58

Impacted Files
Coverage Δ

src/commands/conserve.ts
100.00% <100.00%> (ø)

src/tricks/scaledown-auto-scaling-groups.trick.ts
100.00% <100.00%> (ø)

src/tricks/trick-registry.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37ccd8...3db79d4. Read the comment docs.


Add new min/maxIndex symbols to booktables

https://dlang.org/phobos-prerelease/std_algorithm.html
https://dlang.org/phobos-prerelease/std_algorithm_searching.html
Follow-up to https://github.com/dlang/phobos/pull/4921
CC @RazvanN7

Auto-merge toggled on


starter: initialize statis pod controllers with service monitor

Prevent panic in operator startup as when the dynamic client is not set the monitoring resource will crash.

/lgtm

/hold

As discussed in Slack, we have a manifest (highly customized for kube-apiserver) and this operator which only creates a standard service monitor. We have moved all our operators now to have this manifest with customized  content.

https://github.com/openshift/library-go/pull/614 is driving deprecation of service monitor without panic


composable manager has no rights to view or create resources

Get fails:
{"level":"error","ts":1677612553.3451736,"logger":"controller.composable","msg":"Reconciler error","reconciler group":"ibmcloud.ibm.com","reconciler kind":"Composable","name":"foo","namespace":"default","error":"redisinstances.redis.cnrm.cloud.google.com \"foo\" is forbidden: User \"system:serviceaccount:composable-system:composable-controller-manager\" cannot get resource \"redisinstances\" in API group \"redis.cnrm.cloud.google.com\" in the namespace \"default\", Error finding an object reference","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227"}

Create fails:
{"level":"error","ts":1677615673.8247418,"logger":"controller.composable","msg":"Reconciler error","reconciler group":"ibmcloud.ibm.com","reconciler kind":"Composable","name":"foo","namespace":"default","error":"services is forbidden: User \"system:serviceaccount:composable-system:composable-controller-manager\" cannot create resource \"services\" in API group \"\" in the namespace \"default\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227"}

Hey @lhriley
First of all, thx a lot for your contributions!
As stated here, https://github.com/composable-operator/composable/pull/105#discussion_r1162689898: Opening up the access for composable-operator introduces quite a few side-channel attack vectors, limiting the security of the cluster.
I'd suggest we introduce a new kustomize target, that patches in cluster wide access, so it's an explicit choice by the user rather than an implicit catch-all

I think that's a fair proposal. I mentioned in my reply on the PR comment about a middle ground "opt-in" approach where the end user can make the decision via values.yaml rather than have to incorporate kustomize into a workflow when they might not be using it already.


customize label balloon size for slider

Is there anyway to adjust the balloon radius for slider according to the length of the label or let sliders take in fontsize/balloon size as parameter? It looks like currently the radius is pre-determined and the labels with long text can overflow.

The radius is predetermined.  We should add a way to customize it.
We could size it based on the label, but that might mean it would change size as the label changes, which wouldn't look very good.

Should we size it based on the biggest possible label?

We don't know the set of possible labels because the client supplies only the current label when building the slider.

@vy0592 Are we still blocked on this? I thought we are not using "balloons" anymore. If we are not blocked, let's remove leafy tag.

Clarified with Vicky that we no longer need this.

Looks like still no way to customize, so this is still valid:
https://docs.flutter.io/flutter/material/Slider-class.html

This is now customizable with the rewrite of the slider for the latest Material Design spec.  You can write your own SliderComponentShape that does whatever you like.


Add support to OpenSim-RL

Reinforcement learning with musculoskeletal models in OpenSim
http://osim-rl.stanford.edu/

@andrewekhalel, looks great, thanks for contributing!


Passwords / Logins stop working after migrating to a host with a different number of CPUs

https://github.com/offen/offen/pull/431 introduced a very subtle, but unfortunate bug: by binding the number of threads used in the Argon2 hashing procedure, logins stop being portable between host machines with a different number of CPUs (e.g. when migrating from a host with a single CPU to a host with two CPUs, the hashing function would now pass different parameters to Argon2, creating a mismatch).
This should be fixed by doing the following:

introduce a new algo version for all newly created hashes that does use a fixed number of threads
allow overriding the value used by the buggy algo version by passing an env var so that operators can still migrate to hosts with a different number of CPUs, even if it's a little awkward

The offending portion of code is here: https://github.com/offen/offen/blob/a7b7f2ee643f51bd812316368ea8c59be08f3b64/server/keys/hash.go#L93-L95

This is fixed in v0.2.1. For a workarounf when migrating an older version refer to https://docs.offen.dev/running-offen/known-issues/#login-stops-working-after-migrating-an-instance-to-new-hardware


Get Scroll position during animation

Hi,
is it possible to get the current position of the transition animation (preferrable in %) so i could do other animations which are synchronized with transition progress ?
E.g. having a navigation overview with a line, which smoothly moves while scrolling through the carouselview

Not possible for now :(


:robot: Push proper framework tag

What this PR does / why we need it:
Now framework tags contains the flavor
so we build Image quay.io/kairos/framework:v2.0.0-alpha1_ubuntu-22-lts and need to use the same name for the signing
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Codecov Report

Merging #1108 (a43a2d1) into master (7bb9af9) will increase coverage by 0.62%.
The diff coverage is 51.85%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   22.79%   23.41%   +0.62%
==========================================
  Files          22       22
  Lines        1610     1627      +17
==========================================
+ Hits          367      381      +14
- Misses       1179     1180       +1
- Partials       64       66       +2

Impacted Files
Coverage Δ

internal/agent/agent.go
43.10% <ø> (ø)

internal/agent/install.go
5.40% <51.85%> (+5.40%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[BUG] Account signup: Field validation on zip codes has unhelpful messaging

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Error message is "please match the requested format" but doesn't describe the accepted format
Steps To Reproduce

In any environment
Browse to the sign-up form
Enter a valid form
Enter "abcde" as a zip code
Observe the error

Expected Behavior

Consult w/ content & design on messaging

Additional context
No response
Does this issue have a priority label?

[X] I have added a priority label

Has issue been assigned to a team?

[X] I have added a team label

addressed by new sign up form


Update to stm32l0 0.9.0

Okay, now that stm32l0 0.9.0 is published this should be ready for review @arkorobotics

Thanks for taking the time to update the hal to use stm32l0 0.9.0! Looks good to me.


Add a couple of tests to illustrate possible syntaxes for includes

Thanks @geomacy. That's a nice addition to the test coverage. Merging.


Metric collection fails on current versions of prometheus_client

The Docker container ships with prometheus_client 0.13, which appears to be less stringent about its inputs; however, installing the exporter alongside a current 0.4.2 version of prometheus results in many metrics not being returned at all.
By adding a try-except block around lines lines 141-151 in hypervisor_stats.py (https://github.com/att-comdev/prometheus-openstack-exporter/blob/master/exporter/hypervisor_stats.py#L141-L151), I was able to identify that prometheus_client is throwing a Duplicated timeseries in CollectorRegistry exception when assembling the metrics for delivery.
I suspect that the older version of prometheus_client was simply silently overwriting duplicate timeseries. I believe the same issue may affect all of the collector modules. Exception handling should be added around calls to the prometheus_client methods, and input should be sanitized ahead of those calls to ensure no duplicate timeseries are propagated. I'd be happy to help develop a PR to address some of this, if I can get some guidance from the project maintainers on how they'd like to see that implemented.

@jralbert According to the requirements.txt version 0.2.0 is required.

It certainly is; that version surfaces the same problematic behavior.

From: Christian Berendt<EMAIL_ADDRESS>Sent: Wednesday, October 17, 2018 11:28 AM
To: att-comdev/prometheus-openstack-exporter
Cc: Jeff Albert; Mention
Subject: Re: [att-comdev/prometheus-openstack-exporter] Metric collection fails on current versions of prometheus_client (#6)
@jralberthttps://github.com/jralbert According to the requirements.txt version 0.2.0 is required.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/att-comdev/prometheus-openstack-exporter/issues/6#issuecomment-430738037, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATtuT4vuEHxF5Wd9e2uXBcmtlnYkNRF6ks5ul3a5gaJpZM4Xewuz.

Does anyone have a solution for this? It is still broken with the newer versions.


az acr repository show-tags is not always returning all tags

Describe the bug
On firing a deployment pipeline, the pipeline will first check if the container-image of with that specific version actually is valid (if i exists in the registry).
Initially this worked fine. But when we fire up this deployment pipeline from the pipeline that actually is producing this container-version we have issues, this because the check says the tag is not present in the container registry.
First we taught that the ACR needed some time to process that newly created tag, we we added a dynamic delay between ending the publish-pipeline and deploy-pipeline.
That dynamic delay si going to check with "az acr repository show-tags" if that tag is retrievable, if it has been found =  fire up the deployment-pipeline.
But to our surprise, not all executions of "az acr repository show-tags" are giving back the same result, mainly the last added tag is sometimes present and sometimes not.
we're executing "az acr repository show-tags" with difference service principles, could there be an issue
Related command
az acr repository show-tags
Errors
no error message
Issue script & Debug output
no consistent return value when executing "az acr repository show-tags"
Expected behavior
return the correct tag-collection
Environment Summary
publish pipeline is using Azure CLI 2.55.0
deployment pipeline is using Azure CLI 2.56.0
Additional context
No response

Thank you for opening this issue, we will look into it.

Hi @C302 , does the registry have geo-replication? Would you like to open a support case so that we can better troubleshoot the issue?

Hi @Wwwsylvia, a support ticket was opened<PHONE_NUMBER>003898) and receive following info => https://learn.microsoft.com/en-us/azure/container-registry/container-registry-geo-replication#considerations-for-using-a-geo-replicated-registry
This means that this behavior is "by design", we did some tests and confirmed our suspicion.
It took around 10~15 seconds before an WEST-EU tagged image becomes available in the EAST-US region. because we're using a mix of self-hosted runners/ GH hosted runners/on-prem runners our results differ sometimes (especially because GH hosted runners are runnning ... unknown region)
Some points for improvement:

MS implements an ACR pull-through functionalty (if ACR receives an info request, it first checks if it's in sync with other ACR's)
AZ CLI providers a parameter to define to what region the request is send
GH provides a way to define in what region you want a GH self hosted runner to spin up


Inputbox colour changed and border added

Inputbox colour changed and border added to increase visibility.
Fixes: #144
screenshots

please check these out @abhijeet007rocks8 @DhairyaBahl!

Try a light color for dark theme and vice versa

I tried black doesn't look good in white theme @abhijeet007rocks8 imo

Thanks for the contribution ^_^


setup to send event from indexer lambda.

Change Summary
Overview
Small PR that sends event from indexer lambda to batch starter lambda

It was suppose to be small PR but came into networking issue. Had to add those changes.


feat: add Dockerfile

Example usage:
docker build -t openspiel .
docker run openspiel python3 python/examples/matrix_game_example.py

@lanctot I've tested it on the Python examples and everything seems to run fine. You could use Github Actions to build the docker image and push it onto the Github Package Registry of your organisation so that people simply can docker pull the image. An example workflow is demonstrated here: https://github.com/yarncraft/dockercicd!
You just need to configure the secrets and you're good to go 👍

Hmm, I'm having issues importing this. Tryng to figure out where the Dockerfile lives. Am I understanding correctly that it's at the top-level (root) of the repos?

Hmm, I'm having issues importing this. Tryng to figure out where the Dockerfile lives. Am I understanding correctly that it's at the top-level (root) of the repos?

Scratch that -- I think I've figured it out.


[#4527] extend width of discover

Resolves #4527
Pull Request Checklist:

[x] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Compare the width of the Discover page with that of a resource landing page, using a wide (>1440px) screen device

METRIC
VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4663


Add integration with Random.org

[X] generate sequences via random.org
[ ] add draws integration for big giveaways

Because I cannot filter the results of draws, that is not possible to filter users with conditions, so I will not check it again


refactor(@embark/embark-utils): replace recursiveMerge with object sp…

…read operator
As we're relying on Babel transformations we don't need an npm package
to perform recursive object merges and can rather rely on language
features.

Closing this as @michaeljyeates rightfully pointed out that recursiveMerge and spread operator usages for merging two objects don't behave the same.


GLError for xyz_crop generation

Thank you for releasing the code for xyz_crop generation. There is a problem at run time. What should I do?
$ python tools/lm/lm_pbr_1_gen_xyz_crop.py
using egl
split:  train selected scene ids:  [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49]
0%|                                                                                | 0/50 [00:00<?, ?it/s, train_all]split: train scene: 0
libEGL warning: DRI3: Screen seems not DRI3 capable                                                                                | 0/1000 [00:00<?, ?it/s, 0]
libEGL warning: DRI2: failed to authenticate
0%|                                                                                | 0/1000 [00:00<?, ?it/s, 0]
0%|                                                                                | 0/50 [00:00<?, ?it/s, train_all]
Traceback (most recent call last):
File "tools/lm/lm_pbr_1_gen_xyz_crop.py", line 230, in
xyz_gen.main()
File "tools/lm/lm_pbr_1_gen_xyz_crop.py", line 139, in main
bgr_gl, depth_gl = self.get_renderer().render(render_obj_id, IM_W, IM_H, K, R, t, near, far)
File "tools/lm/lm_pbr_1_gen_xyz_crop.py", line 100, in get_renderer
self.renderer = Renderer(
File "/home/jiayu/GDR-Net-main/tools/lm/../../lib/meshrenderer/meshrenderer_phong.py", line 19, in init
self._context = gu.OffscreenContext()
File "/home/jiayu/GDR-Net-main/tools/lm/../../lib/meshrenderer/gl_utils/egl_offscreen_context.py", line 98, in init
self._egl_context = eglCreateContext(self._egl_display, configs[0], EGL_NO_CONTEXT, context_attributes)
File "/home/lili/anaconda3/lib/python3.8/site-packages/OpenGL/platform/baseplatform.py", line 402, in call
return self( *args, **named )
File "/home/lili/anaconda3/lib/python3.8/site-packages/OpenGL/error.py", line 228, in glCheckError
raise GLError(
OpenGL.error.GLError: GLError(
err = 12297,
baseOperation = eglCreateContext,
cArguments = (
<OpenGL._opaque.EGLDisplay_pointer object at 0x7f3bb4710240>,
<OpenGL._opaque.EGLConfig_pointer object at 0x7f3bb47101c0>,
<OpenGL._opaque.EGLContext_pointer object at 0x7f3bd3d67d40>,
<OpenGL.arrays.lists.c_int_Array_7 object at 0x7f3bb4710340>,
),
result = <OpenGL._opaque.EGLContext_pointer object at 0x7f3bb4710940>
)

Check this thread https://github.com/DLR-RM/AugmentedAutoencoder/pull/42. Maybe it helps.


No charts with ts-node

This is more likely an issue on the ts-node side of things, but I'm not sure how the chart statistics are obtained to open up a topic over there.

I believe this is a startup issue with the child process. I was able to verify this bug if I created a npm task as node bin/nodejs-dashboard.js -- ts-node test/app/index.js. But if I change to a more explicit path to ts-node then it works as expected. node bin/nodejs-dashboard.js -- node_modules/.bin/ts-node test/app/index.js
@dyst5422 Could you please try a possible solution? Either use a more explicit path to your ts-node compiler or install it globally so it doesn't need a path.


Update to newer release

Heroicons have released newer versions which fixes  some icons
For ex. 1.0.2 fixes plus icons
It will be great if if the gem can incorporate the latest release

I'll try to get to this soon!

Let me know if this is still needed — working on a release for v2 of the icons


city of brea failing

New template with

causes issues
City of Brea, CA (new template).xlsx

Added some code to handle both date formats. Should check with Marc if only of one of them is valid and whether we don't need guardrails to check this.