add @effect causes do the function inside the action pipe twice

Describe the bug
so what I'm trying to do is:

I create .effect.ts  file
inside the file, I registered some effect, but the effect with no @Effect() will be not working
so i decided to add @Effect() before the functions
whenever those effects get triggered, it always does the action inside the pipe twice
it work properly whenever I @Effect() only at success effect, but whenever I added @Effect() before other functions, it will not work properly(do the action twice)

Expected behavior
the success effect registered twice (?), but when I use ReduxDevTool it only shows once every I trigger the request. but in the network tab(i do inspect element), it always runs this code twice
this._$rejectApproveApi.patchRejectApproveBilling(newPayload.body.body, newPayload.id)
Reproduction code
@Injectable()
export class RejectApproveEffects {
         @Effect({ dispatch: false }) updateBillingPaymentApprovalFailure$ = createEffect(
        () =>
            this.actions$.pipe(
                ofType(RejectReasonActions.updateBillingPaymentApprovalFailure),
                map((action) => action.payload),
                tap((resp) => {
                    const message = this._handleErrMessage(resp);

                    this._$notice.open(message, 'error', {
                        verticalPosition: 'bottom',
                        horizontalPosition: 'right',
                    });
                })
            ),
        { dispatch: false }
    );

    updateBillingPaymentApprovalRequest$ = createEffect(
        () =>
            this.actions$.pipe(
                ofType(RejectReasonActions.updateBillingPaymentApprovalRequest),
                withLatestFrom(this.store.select(fromRoot.getRouterState), (action, router) => {
                    return {
                        id: action.payload.id,
                        body: action.payload,
                        router: router.state.params
                    };
                }),
                take(1),
                debounceTime(500),
                distinctUntilChanged(),
                exhaustMap((newPayload) => {

                    return this._$rejectApproveApi
                        .patchRejectApproveBilling(newPayload.body.body, newPayload.id)
                        .pipe(take(1))
                        .pipe(
                            catchOffline(),
                            withLatestFrom(this.store.select(AuthSelectors.getUserSupplier)),
                            exhaustMap(([params, userSupplier]) => {
                                if (!userSupplier) {
                                    return this.storage
                                        .get('user')
                                        .toPromise()
                                        .then((user) => (user ? [params, user] : [params, null]));
                                }

                                const { supplierId } = userSupplier;
                                return of([params, supplierId]);
                            }),
                            switchMap(([params, data]) => {
                                let supplierId;

                                if (typeof data === 'string') {
                                    supplierId = data;
                                } else {
                                    supplierId = (data as Auth).user.userSuppliers[0].supplierId;
                                }

                                if (!supplierId) {
                                    return of(
                                        BillingActions.fetchBillingDetailFailure({
                                            payload: {
                                                id: 'fetchBillingDetailFailure',
                                                errors: 'Not Found!',
                                            },
                                        })
                                    );
                                }

                                const newParams = {};

                                if (supplierId) {
                                    newParams['supplierId'] = supplierId;
                                }

                                return of(
                                    BillingActions.fetchBillingDetailUpdateRequest({
                                        payload: {
                                            idDetail: newPayload.router.id,
                                            type:  APPROVE
                                        },
                                    })
                                )
                            }),
                            take(1),
                            catchError((err) =>
                                of(
                                    RejectReasonActions.updateBillingPaymentApprovalFailure({
                                        payload: {
                                            id: 'updateBillingPaymentApprovalFailure',
                                            errors: err,
                                        },
                                    })
                                )
                            ),
                            share(),
                            finalize(() => {
                                this.store.dispatch(UiActions.resetHighlightRow());
                            })
                        );
                })
            ),
}

Reproduction URL
No response
Version
"@ngrx/effects": "8.5.2"
Environment
No response
Additional context
I use angular with rxjs

I think this is not a problem related to rxjs.
Also, with ngrx 8.x you shouldn't use @effect anymore because the createEffect factory function replaces it.
Using both of them in the same time will register the effect twice imho

Yes the issue is definitely the effect being declared twice.
As you can see in ngrx docs, you no longer need the @Effects decorator when using createEffect otherwise it is registered twice.


Flag potential duplicate patient profiles (in patient app and SimpleReport)

Once we launch patient registration and allow patients to create their own profiles, we will likely run into more issues with duplicate profiles. To prevent duplicates, we'd like to flag potential duplicates for users during the registration process. Ideally, we should flag this as early as possible in the patient registration process (i.e. once user has added full name, DOB, and phone number) and alert the user that they appear to already have been registered.
We need to understand any privacy and security implications of this approach, which will inform the design.
We should also flag potential duplicate profiles in SimpleReport.

Could we add this to the scope of this story:

How can users add patients from the test queue page?

@vz3 that's a separate story. Let's keep them separate to keep the scope down.

Blocked on Design

Added the figma link. I'll have the spacing specs and state changes ready before our next grooming

@aliciabeckett-gov Everything here needs Spanish translation!

@kenieh and I paired on this a bit and have come to the conclusion that it's probably not worth breaking the form up into sections for now.
As designed, with the General and Contact information on the first page, the form validation becomes super tricky and the user only saves five radio button clicks if they are indeed a duplicate.
So it seems like the best option is to adopt the planned "Add Patient" flow of just checking if the user is a duplicate if any of the necessary fields (first name, last name, birthdate, zip) are blurred.


Question : Is there anyway to catch timelineregionenter event from shaka player ?

Hi !
I am presently trying to do ad insertion. While I know this could be done with Ad Breaks, I was hoping to catch ad event directly from my manifest. At first I was trying to catch EMSG_EVENT with this manifest but no event where triggered :
<MPD xmlns="urn:mpeg:dash:schema:mpd:2011"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" maxSegmentDuration="PT1.003S" mediaPresentationDuration="PT23M34.109792S" minBufferTime="PT0S" profiles="urn:mpeg:dash:profile:isoff-live:2011" type="static">
   <Period id="1" start="PT0S">
      <BaseURL>https://my-base-url</BaseURL>
      <EventStream schemeIdUri="urn:mpeg:dash:event:callback:2015" timescale="1" value="1">
         <Event id="2" messageData="https://some-reporting-urn1" presentationTime="2"/>
         <Event id="3" messageData="https://some-reporting-urn2" presentationTime="5"/>
      </EventStream>
      <AdaptationSet bitstreamSwitching="true" contentType="video" group="1" id="1" maxFrameRate="30000/1001" maxHeight="1080" maxWidth="1920" mimeType="video/mp4" par="16:9" segmentAlignment="true" startWithSAP="1">
         <SegmentTemplate initialization="S!d0FEQVNIVP7...8Bnw__/QualityLevels($Bandwidth$)/Fragments(video=Init)" media="S!d0FEQVNIVP7...8Bnw__/QualityLevels($Bandwidth$)/Fragments(video=$Time$)" timescale="10000000">
            <SegmentTimeline>
               <S d="10010000" r="9"/>
               <S d="2000000" r="0"/>
            </SegmentTimeline>
         </SegmentTemplate>
         <Representation bandwidth="325950" codecs="avc1.4d4015" frameRate="30000/1001" height="270" id="dzE--QSf" sar="1:1" width="480"/>
         <Representation bandwidth="631425" codecs="avc1.4d401e" frameRate="30000/1001" height="360" id="dzGBogmf" sar="1:1" width="640"/>
         <Representation bandwidth="1236504" codecs="avc1.4d401e" frameRate="30000/1001" height="480" id="dzEY3hKf" sar="1:1" width="720"/>
         <Representation bandwidth="1939045" codecs="avc1.4d401f" frameRate="30000/1001" height="540" id="dzFllh2f" sar="1:1" width="960"/>
         <Representation bandwidth="3747150" codecs="avc1.64001f" frameRate="30000/1001" height="720" id="dzFOLTmf" sar="1:1" width="1280"/>
         <Representation bandwidth="4945982" codecs="avc1.64001f" frameRate="30000/1001" height="720" id="dzE-eEuf" sar="1:1" width="1280"/>
         <Representation bandwidth="5555565" codecs="avc1.640028" frameRate="30000/1001" height="1080" id="dzFtxVSf" sar="1:1" width="1920"/>
      </AdaptationSet>
      <AdaptationSet bitstreamSwitching="true" contentType="audio" group="2" id="2" lang="und" mimeType="audio/mp4" segmentAlignment="true">
         <AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2"/>
         <SegmentTemplate initialization="S!d0FEQVNIVP7...8Bnw__/QualityLevels($Bandwidth$)/Fragments(audio_482_und=Init)" media="S!d0FEQVNIVP7...8Bnw__/QualityLevels($Bandwidth$)/Fragments(audio_482_und=$Time$)" presentationTimeOffset="14" timescale="32000">
            <SegmentTimeline>
               <S d="32767" r="0" t="14"/>
               <S d="31744" r="0"/>
               <S d="31745" r="0"/>
               <S d="32767" r="0"/>
               <S d="31745" r="0"/>
               <S d="31744" r="1"/>
               <S d="32767" r="0"/>
               <S d="31745" r="0"/>
               <S d="31744" r="0"/>
               <S d="7168" r="0"/>
            </SegmentTimeline>
         </SegmentTemplate>
         <Representation audioSamplingRate="32000" bandwidth="40000" codecs="mp4a.40.2" id="dyHiAZ8."/>
      </AdaptationSet>
   </Period>
</MPD>

Then I decided to try this manifest directly on Shaka player. I found out that the good events to listen to for this syntax of ad event where timelineregionenter and timelineregionexit. These events are triggered by Shaka when encountering EventStream with sub Event while emsg events are triggered when encountering InbandEventStream. I have the impression that CAF EMSG_EVENT will only be triggered by InbandEventStream.
So, my question : is there anyway to catch timelineregionenter or timelineregionexit events on CAF Receiver ?
Thank you :)

Cast only support EMSG from Shaka.

CAF dispatches EMSG_EVENTS and ID3 events as they are encountered in the content itself. For manifest based events such as EventStream in DASH and EXT-X-DATERANGE in HLS we dispatch those as timed metadata events: https://developers.google.com/cast/docs/reference/web_receiver/cast.framework.events.TimedMetadataEvent.


Fixing slog.Logger.Error arg err should be a string or a slog.Attr (possible missing key or value)

Description
On go 23, this error occurs:
internal/mocks/k8s_mock.go:53:52: slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)
internal/mocks/k8s_mock.go:60:54: slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)
internal/mocks/k8s_mock.go:67:40: slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)
How Has This Been Tested?
Ran the BFF and ran the FE.
Merge criteria:

All the commits have been signed-off  (To pass the DCO check)

[X] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work.
[X] Code changes follow the kubeflow contribution guidelines.

Should we update the go.mod version or add documentation about what version of go to develop with?

@Griffin-Sullivan, that is indeed one of the option or we would stay with our:
https://github.com/kubeflow/model-registry/tree/main/clients/ui/bff#dependencies
Dependencies
Go >= 1.22.2
I would prefer to keep using 1.22 so as not to be 'too far' ahead from https://github.com/kubeflow/model-registry/blob/main/go.mod#L3 and keep this PR with the purpose of 'fixes built in 1.23.x'

Yeah I say we stick close to the go version used in the rest of the project. We can decide on docs separately, I've tested and it works with 1.23 so lgtm

/lgtm


admin_ssh_key Error during terraform plan

Explanation
I found an issue related to the SSH key using the last v.4.1.0 tag (it may occure with the other)
Error: Error "admin_ssh_key.0.public_key" is not a complete SSH2 Public Key

  on .terraform/modules/vm/r-vm.tf line 1, in resource "azurerm_linux_virtual_machine" "vm":
   1: resource "azurerm_linux_virtual_machine" "vm" {

I tried to use a SSH2 format, but this was not really the issue.
Then, I found this issue on Microsoft Docs GitHub : https://github.com/MicrosoftDocs/azure-docs/issues/51106
Workaround
Adding this file() cast on the SSH key file on the dynamic bloc fix the issue :
 dynamic "admin_ssh_key" {
    for_each = var.ssh_public_key != null ? ["fake"] : []
    content {
      public_key = file(var.ssh_public_key)
      username   = var.admin_username
    }
  }

Hello,
var.ssh_public_key is the SSH public key like the description stands in README, not a file path, so it seems your issue is only about how to use the module.


Error start openvpn daemon

When I install the script, I get the following message at the end
An updated CRL has been created.
CRL file: /etc/openvpn/easy-rsa/pki/crl.pem

53
Job for<EMAIL_ADDRESS>failed because the control process exited with error code. See "systemctl status<EMAIL_ADDRESS>and "journalctl -xe" for details.

Finished!

Your client configuration is available at /home/dargod/StarVPN.ovpn
If you want to add more clients, you simply need to run this script again!

systemctl status<EMAIL_ADDRESS>●<EMAIL_ADDRESS>- OpenVPN connection to server
   Loaded: loaded<EMAIL_ADDRESS>disabled; vendor preset
   Active: failed (Result: exit-code) since Fri 2017-07-28 14:06:38 EDT; 3min 48
     Docs: man:openvpn(8)
           https://community.openvpn.net/openvpn/wiki/Openvpn23ManPage
           https://community.openvpn.net/openvpn/wiki/HOWTO
  Process: 6758 ExecStart=/usr/sbin/openvpn --daemon ovpn-%i --status /run/openvpn/%i.status 10 --cd /etc/openvpn --script-security 2 --config /etc/openvpn/%i.conf --writepid /run/openvpn/%i.pid (code=exited, status=1/FAILURE)

journalctl -xe
Jul 28 14:06:38 tcs systemd[1]: Starting OpenVPN connection to server...
-- Subject: Unit<EMAIL_ADDRESS>has begun start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit<EMAIL_ADDRESS>has begun starting up.
Jul 28 14:06:38 tcs ovpn-server[6758]: OpenVPN 2.3.10 x86_64-pc-linux-gnu [SSL (OpenSSL)] [LZO] [EPOLL] [PKCS11] [MH] [IPv6] built on Jun 22 2017
Jul 28 14:06:38 tcs ovpn-server[6758]: library versions: OpenSSL 1.0.2g  1 Mar 2016, LZO 2.08
Jul 28 14:06:38 tcs ovpn-server[6758]: daemon() failed or unsupported: Resource temporarily unavailable (errno=11)
Jul 28 14:06:38 tcs ovpn-server[6758]: Exiting due to fatal error
Jul 28 14:06:38 tcs systemd[1]<EMAIL_ADDRESS>Control process exited, code=exited status=1
Jul 28 14:06:38 tcs systemd[1]: Failed to start OpenVPN connection to server
-- Subject: Unit<EMAIL_ADDRESS>has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit<EMAIL_ADDRESS>has failed.
--
-- The result is failed.
Jul 28 14:06:38 tcs systemd[1]<EMAIL_ADDRESS>Unit entered failed state.
Jul 28 14:06:38 tcs systemd[1]<EMAIL_ADDRESS>Failed with result 'exit-code'.

My server is OpenVZ with Ubuntu 16.04

@dargow can you verify that this issue is not the same with issue #206

Indeed, it's very likely that.
Just edit the systemd service as instructed and you're fine.


fix backwards compatibility when string are used for mock data and co…

…ntent type is json

fixes #22

We are not advocating keeping this forever. Maybe remove in a 2.x release?

I will look into refactoring specifying contentType this weekend. There shouldn't be any reason to be setting contentType on a GET request. So some of this is moot.

The contentType has nothing to do with the request being a get. It is entirely possible that there could be a POST with no body if it was triggering a change (ex: triggering the sending of an email).
The correct logic on setting the content type should have to do with the presence of a request body. And that logic should probably live in Ember Promise.

While not the majority use case I agree there are scenarios where you could have a POST with no content. However, you had a test that is a GET with the contentType set to the non default value of application/json which is  superfluous, as contentType is for specifying the data type being sent to the server which of course is not happening in a GET request. I am working this morning on adding some logic for dealing with contentType. I will post additional information once I have something put together.

It isn't happening in that test's GET request, but it's perfectly legal to do a GET with a body.  It's also perfectly legal to specify a content type when there is no body. Nothing that was done in that test was against HTTP specification. It may not be the "best" thing, and may not fit in with REST, but there are a lot of arguments against REST, and not every request is suited to be REST-ful, (Login request for example).
I understand your concerns about semantics, but the goal of our PR was to make faujax more flexible when doing data comparisons, not make it the enforcer of REST.
Thanks again for maintaining the library. We appreciate the work your are doing.

@williamsbdev I was just thinking that if I were sending XML (or some other more verbose message format) as the payload in a request I wouldn't expect the library to serialize my XML so that it could do comparison.
I'm fine dropping this request. We should just make sure our stuff matches.


feat(corporate actions): add setDefaults to the namespace

Allows to set default targets, global tax withholding % and per-identity tax withholding %

:tada: This PR is included in version 5.0.0-beta.39 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feature/Update Authentication logic

Prerequisite

[x] Self-review :monocle_face:
[x] No Crashes ☠

[ ] I understand that "General.OK" is now existed in Localized service

[ ] I understand that "Register.Success.Message" is now existed in Localized service

[ ] I understand that "Register.Success.Title" is now existed in Localized service

[ ] I understand that "Register.SignUp" is now existed in Localized service

  Generated by :no_entry_sign: Danger


Typo in the word

initalised → initialized
In the options and class name

Hi @Eugeno,
Thanks for reporting the bug. I'm from the UK so we do spell it with an s (and I think I missed a letter, spellings not my thing). I do try and use USA spellings when developing and agree this should be changed. I've just updated the plugin and the docs. Thanks for your help!
Stuart


Split out geofency with a component and platform

Description:
Splitting out the geofency device tracker platform to a separate component/platform. This is a prerequisite for #17925.
I don't have an iPhone (so don't have geofency itself to test with), but I'm using postman to simulate the api calls.
Breaking Change: The geofency device_tracker platform no longer takes any configuration. The configuration needs to be applied to the component geofency instead. The platform will be automatically loaded with the component.
This is my first time splitting a component out of a platform, so I'd appreciate a review before I document it.
Unit tests are currently broken (and I have no idea why). I'm assuming it has something to do with the async state change happening after the unit tests are checking the state machine, but I would appreciate some advice there. Disregard, I totally forgot to block until the async call finished....
Related issue (if applicable): Relates to #17925
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7218
Example entry for configuration.yaml (if applicable):
geofency:
    mobile_beacons:
      - car
      - keys

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Hmm, seems I've run afoul of the changes made in #17952. I'll rebase and fix things up.

I have no idea why that unit test is failing. I don't think I touched anything that had anything to do with it...

@balloob @MartinHjelmare after the latest set of changes, it seems like I broke something. I'm not getting any updates on the device tracker and seeing the following error in the logs:
/usr/lib/python3.6/asyncio/events.py:145: RuntimeWarning: coroutine '_set_location' was never awaited
Any idea what I did wrong? As far as I can tell, this was caused by making the callback on line 21 of device_tracker/geofency.py a coroutine.

I'm guessing we don't await hass.async_block_till_done somewhere after await the client post.

Only way I was able to resolve it was to make this not be a coroutine:
@callback
    def _set_location(device, gps, location_name, attributes):
        """Fire HA event to set location."""
        hass.async_create_task(
            async_see(
                dev_id=device,
                gps=gps,
                location_name=location_name,
                attributes=attributes
            )
        )

You forgot to remove @callback when you made _set_location a coroutine:
https://github.com/home-assistant/home-assistant/commit/0f33cc5181ac5408adbd621b35eb976a6db83f0f#diff-739acf35f7305d6c70ee60de04c31ac4

Nice catch, thanks! Changes pushed up.

Apparently it still doesn't work! The strange part is if I run the geofency tests alone via pytest they pass locally...

Able to repro this with py.test tests/components/device_tracker tests/components/geofency
Some test is not cleaning up !

fixed tests

Thanks for the assistance!


Add id (and version) to ReportEvent class

For most of the development of the logical model, we have been working within a single example reporting event, which is only identified by its name (e.g., "Sprint 10 Examples").  However, we are expecting to publish multiple example reporting events in the CDISC Library and for these to be retrievable via the API.  Our current proposal is to release packages over time, each containing one or more example reporting event.  It would facilitate the retrieval of individual reporting events if each were assigned an id that could be included in the endpoint URI.
In order to assign an id to a reporting event, the id slot needs to be added to the ReportingEvent class, either directly (simple approach) or by adding id to the NamedObject class (more complicated as we'd need to decide if everything currently with a name should also have an id - I suspect this is not the case).
Are we expecting to publish updated versions of example reporting events?  If so, it would probably make sense also to include the version attribute in the ReportingEvent class.
We should also decide how the identifiers for example reporting events should be formatted.  For example, if we include version in ReportingEvent, should the version be referenced in the identifier?

At the ARS Documentation meeting on 2023-06-02, we (Bhavin, Bess and Richard) agreed that the model should be updated to include id and version for the ReportingEvent class.  Reporting events will be identified by an immutable id value, which will remain the same across packages.  Any new version of the example reporting event will have the same value for id and an incremented value for version. Note that the example reporting event's name may be adjusted between versions while the id remains the same.

The model has been updated to include id and version in the ReportingEvent class. However, this raises a general question about versioning and identification of unique objects: if id is supposed to be a unique identifier, how can you have multiple versions all with the same id value?  Should each version instead be a separate object within a single uniquely identified object?  This applies to all classes that currently include both id and version.


bgpv1: move Signaler to BGPCPSignaler cell

In order to promote modularity, move BGPCPSignaler to its own cell.
This will allow other subsystems to add this Cell to their dependencies without relying on the BGP-CP-Controller.
Subsystems can then use this event source as a way to notify the BGP-CP it should perform a reconciliation.
bpgv1: move the internal BGP signaler to a cell and allow other cells to depend on it.

/test


Create tools to load glsl shaders in all platforms

glsl -> spir-v -> wtv
https://github.com/septag/glslcc

No longer relevant, at least for a long time.


return in finally swallows exceptions

In https://github.com/promplate/partial-json-parser/blob/265c965002c9afaa15a5429e03cb317071f7286e/src/partial_json_parser/core/complete.py#L32 there is a return statement in a finally block, which would swallow any in-flight exception.
This means that if any exception is raised from the try body (including BaseException such as KeyboardInterrupt), it will not propagate on as expected.
See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

I see. You meant KeyboardInterrupt. I think other BaseException wouldn't raise inside that 🤔
Why do you want to interrupt that process? Are you trying to parse a long string with a lot of spaces?

I considered it acceptable because I thought that try-block would only raise an IndexError at the end of the input string.

If your intention is to swallow all exceptions, I'd do that with explicitly with except BaseException: pass to make it clear that it's intentional. You call.

Thanks for reporting. And I'm a bit curious if you are working on a linting tool or if you are involved in some statistical research? I would love to learn about your findings.

Thanks for reporting. And I'm a bit curious if you are working on a linting tool or if you are involved in some statistical research? I would love to learn about your findings.

https://github.com/iritkatriel/finally/blob/main/README.md

thx!


Click remove button but not reload

I thought it still not remove the connection
so I clicked again, and it showed the error.
and the reason why is
when I click the remove button, it removed the connection.
But the screen still not reload (or return to connections list)

Fixed in https://github.com/officert/mongotron/commit/f242cd3b04798cc16fe2d43e0591eeb1fd6561ef


How change admin panel theme and make it rtl ?

Hi
how can i change admin panel theme ? and make it rtl with arabic language

Hello, we are working on this on branch 1.2 https://github.com/microweber/microweber/tree/1.2
We hope to release it in the next month

Thank you for reply
can i change admin template in new release ?

https://microweber.org/ is a big company and website which is REALLY popular dont put it on google it will be taken down

any news about RTL support?

any news about RTL support?

+1


springfox swagger generates api Doc in rather strange format

HI , this is a one of type question.  I am receiving a strange response from the swagger/json /the open-API spec

Why is that an xml element is added  -  when the openAPI spec is expected to be in the JSON format. The result is neither a JSON nor an XML. I do not have any parsers specified in my springboot pom and by default it would take the JAX-RS for parsing.
Please let me know if I could modify the v2/api-doc response to parse only the JSON and remove the XML element - .

Is there a way that I can get hold of the response of v2/api-docs so that I can write a filter to rewrite the response?

Is there a way that I can capture the response in a filter, modify the response stream and then do chain.doFilter ()

Could someone help me out please?

@vijayakumar-psg587 I don't understand your question. Where are you seeing the xml? Also this project doesn't support JAX-RS. Have you read the docs for extensibility?

@dilipkrish I did read the docs.
The problem is the springfox implemented swagger-ui provides a link to the openAPI spec through /v2/api-docs (swagger2) . On click of it, the openApi spec needs to be generated in a JSON format. Surprisingly for me, it gets generated in a mix of XML and JSON format. I can find the spec in the JSON format, but before all the spec there is an xml element added -<JSON> and I do not know how to get rid of this. I am unsure how it is getting generated as well.  I understand that the crux of the issues lies elsewhere but since I have inherited the code , i am unable to find out where exactly the issue is. Hence I took the short route of just deleting the XML element alone - and then provide the user with the API spec on click of the v2/api-docs link
I also made MappingJackson2HttpMessageConverter as my default by including the jackson jars in my dependency pom but that didn't help as well
So I was wondering if a filter can be implemented, catch the response before being sent to the client and modify its content.? I am unsure if it can be done, since it is implemented by the springfox jars and the control directly goes there.
Please let me know if it is not clear. I understand that this is strange and probably be a one off. I  will try to explain it in a different manner if the above statements are not clear

@vijayakumar-psg587 seems like the object mapper that you're using in your application is different than the one used by swagger. Try to see if JAXB is in your dependency tree and remove that if you're not using it. What version of springfox are you using?

@dilipkrish I use version 2.9.2 . I will check if JAXB is present and let you know shortly

@dilipkrish Yes there was jaxb instance imported via a transitive dependency. I did clear that out and added  jackson explicitly . But still I am endingup with the same issue. Can I redefine my objectMapper to something like this? [snippet](git clone<EMAIL_ADDRESS>I am unsure how to do that for OPENAPI spec as objectMapper.readValue expects a source class that is to be read and a destination class to which it should map to? Would this work?

@vijayakumar-psg587
Have you checked out the documentation on configuring the object mapper?
http://springfox.github.io/springfox/docs/current/#configuring-the-objectmapper

Thanks @amutsch. I will check that out.  I did not do that before.

@amutsch I am unable to define a deserializer in the Objectmapper of swagger. Could you please guide me?
@Component
public class SwaggerObjectMapperConfig implements ApplicationListener<ObjectMapperConfigured> {

    @Override
    public void onApplicationEvent(ObjectMapperConfigured event) {
        // TODO Auto-generated method stub
        System.out.println("application event is called" + event.getObjectMapper());
        event.getObjectMapper().reader(SwaggerJSONDeserializer.class);
        System.out.println("another log");
    }

}

@vijayakumar-psg587
Is your project available on github or another repository I would be able to take a look at otherwise if you provide information about your project dependencies I can try and setup a sample to reproduce what you are seeing and doing.

@amutsch let me try uploading removing project specific details. Please give me a few min

Here is the pom - link
Here are the config files -  webconfig
SwaggerConfig

@amutsch  I am sorry. there are a few confidential files I am unable to upload the module to repo

@vijayakumar-psg587
Let me create an example project out of what you have provided and see what I can find.

@vijayakumar-psg587
I set up a very small service to try and simulate the problem and my service looks fine,  swagger-ui.html came up without issue and the api-docs came up without issue as well.  There is something more inside your project that is causing problems.
Do you have annotations or documentation on your rest methods in your controller that may be causing issues?
It didn't cause problems for me but I did notice you had many test only dependencies not marked test scope which impacts which libraries are on the classpath at runtime.

@amutsch thank you for the effort. I really appreciate it.  I did setup a test project in my local with a few controllers and I wasn't able to replicate the issue as well. I guess its a very strange issue  and I am unsure as to what causes it. Hence thought of just removing the xml element -  before being served to the user. I guess the only way for me to write from scratch :(

@amutsch Can you provide a sample where objectmapper of swagger is used to read or write the openAPI spec data? I guess if I figure that out then I would be able to add my snippet for modifying the response

@vijayakumar-psg587 removing a json tag may or may not solve your issue but at the least I wouldn't think that to be an object mapper job.  I would lean towards using a controllerAdvice if you are looking to hack the response.
Like I mentioned before the problem could originate from data within additional annotations you are using, conflicting mappers in the system, unexpected libraries due to test dependencies not properly scoped.

@amutsch That makes sense. Let me try scanning the entire app and remove any such discrepant annotations. Thanks though

@amutsch I am trying to make use of the filter and I am almost there , but reading, modifying and rewriting to the filter is where I am stuck. Could you please take a look at this and let me know where I am making the mistake?
https://stackoverflow.com/questions/53867077/cannot-write-new-response-in-servlet-filter

@amutsch and @dilipkrish I have found the answer and posted the same. Sorry that the resolution is not related to springfox implementation of swagger. I am closing the issue. Thanks again for the help and guideline

@vijayakumar-psg587 Can you please let me know how you get the details in pretty format? I am also getting the documentation in strange format!

@amutsch and @dilipkrish I have found the answer and posted the same. Sorry that the resolution is not related to springfox implementation of swagger. I am closing the issue. Thanks again for the help and guideline

Where have you posted the answer? Thanks and am looking forward to it!


Added retinoblast

Fixes #1416
@paulacalipho please do check if this is alright, thanks

@shawntanzk that's all right, many thanks


Release - v2023.01.8

Looks like two integration tests are failing (relating to accounts). I don't see any reason for why they should stop the release, but I will do a follow-up PR with a fix.


How to set das.respectvmvmantiaffinityrules using pyvmomi

I am been exploring a way to set this advanced option das.respectvmvmantiaffinityrules using pyvmomi.  No luck

I will assume you have an object to the cluster
From that you should be able to ReconfigureEx passing in the configSpec that has option set.
Example:
from pyVim.task import WaitForTask
from pyVmomi import vim
...
key = "das.respectVmVmAntiAffinityRules"
optVal = vim.option.OptionValue(key=key, value="true")
dasConfig = vim.cluster.DasConfigInfo(option=[optVal])
configSpec = vim.cluster.ConfigSpecEx(dasConfig=dasConfig)
WaitForTask(cluster.ReconfigureEx(configSpec, True))

Thanks a lot.. that seems to work


[DO NOT MERGE UNTIL 4.3 IS RELEASED] Reenable TSLint in botbuilder-js

Fixes #727

"We will re-enable the linter the day after 4.3 ships!"

Description

In tslint.json, "defaultSeverity" was set to "off", resulting in No valid rules have been specified for TypeScript files prompt when trying to run tslint

changed "defaultSeverity" to "warning" to show linting

Also disabled rule to require linebreak-style to be true

Rearranged "rules" to be in alphabetical order, as they are in seemingly random order

Pull Request Test Coverage Report for Build #1914

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 82.36%

Files with Coverage Reduction
New Missed Lines
%

libraries/botframework-config/src/botConfigurationBase.ts
2
85.59%

Totals

Change from base Build #1891:
-0.08%

Covered Lines:
2737

Relevant Lines:
3195

💛  - Coveralls

Closing this, as we will reenable linting, however stop using tslint in favor of using eslint. See https://github.com/Microsoft/botbuilder-js/pull/806


 There may be bugs, incomplete features, incorrect documentation, or other discrepancies. Preview packages should never be used in production!
Also, can you review https://github.com/dcos/examples/tree/master/arangodb/1.9 to see if there are any changed required in the documentation for this update.

@m0ppers any update here?

Superceded by https://github.com/mesosphere/universe/pull/1283


Can not train MetaDrive datasets

I would like to train algorithms on metadrive env (OfflineMetadrive-harddense-v0),
the traceback is:
raise error.NameNotFound( gymnasium.error.NameNotFound: Environment ''OfflineMetadrive-harddense'' doesn't exist.
How to address it?
Thanks.

Did you follow the instruction here to install the metadrive environment?

Thanks, I changed the code, so received the error.


Add new publiccode.schema.json

Title
This PR introduces the JSON version of the publiccode.yml file in order to have a valid schema to test against for validity.
Content
A new file is created (now in root).
Review

[ ] Ensure your files are written following RST specs (not MD!)
[ ] Italian version
[ ] English version
[ ] Ask for review

This looks weird, have to understand how to handle the description/lang/xxx thing, since now it's only in italian in the file.

Is this a json-schema or just a ... json copy?

Is this a json-schema or just a ... json copy?

@ruphy We're trying to build an updated (draft 07) JSON schema to be later used for validation purposes (e.g., in the editor). What do you think about it?

I think it's a wonderful idea! We tried it last year and failed to represent the localized strings. If you can, however, build it to the point where it becomes the single file which generates the whole documentation/validator, this would make me very happy!


Add a C# code sample link in the Adaptive Card-based Loop Components document

Hi Teams,
We have done the C# sample implementation. Could you please add the link in the Adaptive Card-based Loop Components document?
C# sample link

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a614d296-7303-d8b1-4b1a-af422a244dc8
Version Independent ID: a614d296-7303-d8b1-4b1a-af422a244dc8
Content: Build Adaptive Card-based Loop component - Teams
Content Source: msteams-platform/m365-apps/cards-loop-component.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: surbhigupta

@surbhigupta12 - Could you please help here to add the below sample link in document?
C# sample link


Zendesk

Submission Template
Please provide the following information.

Vendor Name: Zendesk
Product Name: All Products
Version(s) affected: All Versions
Status: Affected.
Update Available: No
Notes: Zendesk products are all cloud-based; thus there are no updates for the customers to install as the company is working on patching their infrastructure and systems.
References: https://support.zendesk.com/hc/en-us/articles/4413583476122
Last Updated:  2021-12-13

This product has been added to the repository. Thank you.


Add Kmeans and CNN algos (Python)

Hello.
I wish to contribute by adding Kmeans clustering algorithm and Convolutional Neural Network Algo  in Python. Can I proceed with that? If yes , please add the hacktober label to this issue.
Also, should I contribute in .py or .ipynb ?

Hi @Anjali001. Sure, you can go ahead 👍
If it's possible, contribute in .py, but Jupyter Notebook is aceepted as well.


chore(master): release 0.7.8

:robot: I have created a release beep boop
0.7.8 (2024-08-07)
Features

add field in app space and consent (bfb1582)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/indykite/indykite-sdk-node/releases/tag/v0.7.8 :sunflower:


Clarify "data privacy settings" text on question creation view

The Data privacy settings section of the question creation view makes it sounds like questions won't be exported, even in the full JSON export.

We should update this to clarify that this is the settings for the demographics export.
This issue is done when:

The question settings page copy is updated
Anywhere else that we reference this export, such as the export button on the top of the admin programs page, should make this more clear.

@avaleske do you have some suggested wording for the clarifying text?

For the button, does "Download Demographic Data (CSV)" work?
For the question creation screen, does something like this under the header work?
"The setting below only controls what is exported in the demographic export. Answers are always exported in via the API."
We could also update the options themselves to say "... in the demographic export"

Per UX, in the question creation screen, will we rename "Data privacy settings" to "Demographic data privacy settings".  In the options:  "Don't include in demographic data export", "Include in demographic data export", "Obfuscate and include in demographic data export".
For the help text, we include "The setting below only controls what is exported in the demographic export. Answers are always exported in via the API." below the label and above the options.  We move "Learn more about..." to below the options.
Also, note that the name of the options will need to be updated in the documentation.
For the button on the CF Admin Program List view, we will change the name to "Download Demographic Data (CSV)" and in the modal, both on the modal header and the modal button.

Thank you @melanie-exygy for doing the work to get this ready for development!


When will the training code release? I can not wait to try it!

Awesome work!

Thanks!
The pretrained weight of DA-CLIP is here and you can use it to generate degradation embeddings and clean image embeddings as the example code.
In addition, I'm planning to release the training code for DA-CLIP later this month.

what's the gpu memory requirement for the training? (I only have a 12GB GPU but I would like to try it!

I think this paper would be impactful for the community. : )

Thanks again for your interest! I train the DA-CLIP using 4 A100 GPUs (large batch size due to the contrastive learning) and an A100 for the downstream image restoration training. The training details can be found in the paper (Appendix B.1).
Only a 12 GB GPU might be hard to train this model (but of course it is possible to change the batch size, patch size, and model parameters to fit your computer). Moreover, I will provide pretrained weights for the downstream diffusion model so you can easily test it.

Got that. Thanks for your timely reply and suggestions! By the way, how about the training time on 4*A100 and the per-GPU memory cost for your experiments?

The training takes 3 hours and almost all GPU memories. :)
But the batch size is 784 x 4. You can try a smaller batch size such as 64 which would also work well.

Got that. Thank you!


feat: multilevel configuration and profiles

This PR modifies fangs to support multiple configuration files, along with merging them with "append-to-lists" behavior and named profile overrides.
Fixes #50

hey there, i had a pretty long absence because i broke my arm 😅
Is there any news on this and if youre interested in bringing this into syft and grype? :)

Hey @henrysachs -- Sorry to hear about your arm! (I've had one, they're no fun)
We just so happened to talk about this one last week and I'm actively working on getting it moved forward.

congrats on the merge 🎉
thank you guys


Use DDP?

@theodorDiaconu Is it not possible to leverage the DDP connection like swydo:ddp-apollo? Or are there good reasons not to?

@mattblackdev there are good reasons not to. I'd use swydo:ddp-apollo when I would like to migrate my existing meteor app incrementally, otherwise I'd rather use plain websocket. DDP adds extra layers of complexity over websocket communication.


No colors displaying

For a reason that I ignore the package, after the last update, does not display the txt in color all the code is in gey now.
Any idea?

U need to upgrade atom version to 1.13.0, or downgrade package version to 1.2.0 apm install<EMAIL_ADDRESS>http://flight-manual.atom.io/using-atom/sections/atom-packages/


Make NCHS data available at HHS, nation level

The NCHS mortality data is currently only available at the state level. It seems like it should be possible to aggregate it to the nation and HHS levels. (If it's not possible for some reason, we should document that so nobody tries to use state and aggregate themselves.) Having all our signals consistently available at HHS and nation when possible would make it easy to compare things.
There's no pressing need for this that I know of; I just noticed the inconsistency and think it'd be nice to fix.

Hey @alexcoda want to take a look at this? Cheryl has a good start in #1213 but it's missing the critical plumbing to actually do the geographic aggregations (it currently just outputs extra copies of the state df under different names).
I've attached a csv file which is the result of recently running pull.pull_nchs_mortality_data with our Socrata key for you to use for testing.
socrata_df.csv

@krivard yep! I'll take a crack at it sometime this weekend. I'll let you know if I have any more questions about it

Looking at the csv columns, there's a mix of counts and percent values (from the source), so presumably we'll have to do something like the following to do a weighted average of the percentages and a nonweighted sum for the counts?  And NCHS should cover all states that are included in HHS regions, so we don't need to worry about weird denominator handling right?
df"weight"] = df["population"]
proportion_vals = gmpr.replace_geocode(df, "state_id", new_geo, ... , date_col="timestamp", data_cols=[<all columns that are a percentage>]
# weight column gets removed
count_vals = gmpr.replace_geocode(df, "state_id", new_geo,..., date_col="timestamp", data_cols=[<all columns that are a counts>]
# combine the two dataframes back

We ended up going down a huge rabbit hole after realizing geomapper doesnt do state_id to fips, only state_code, but will continue to finish this next week.

presumably we'll have to do something like the following to do

that looks right, yes.

NCHS should cover all states that are included in HHS regions

That's correct; here's the NCHS coverage map for reference
(and the like five different ways of specifying states is indeed a pain)


Can this library be used for distributed processes?

hi,
From the documentation, its not very clear, at least to me. Hence thought of getting it clarified. Is it possible to use this library by 2 independent processes? If we use the same example given in docs, where one process is loading the customer collection and second independent process (one or more) is simply using the collection in its processing. Is this possible?
Other question that I had was when does the data inserted to collection get deleted?
Thanks!

Hi @askids,
Not associated with this repo, but maybe I can answer some what.  From redis perspective, this client is just that, a client, and redis can accept multiple clients at the same time.  So if you have multiple processes (clients) making calls to redis-server, each one will use the Multiplexer and reach out to the server, no problem.  We stick the Provider in our container, and resolve it from which ever process needs to query / work with redis.
As for persistence, it stays stored until you delete it, or set an expiration time; as the same as traditional redis.

@VagyokC4 thanks. But my question is can 2 clients read the same collection and are they getting the same copy of data?
From the example, when we use provider.RedisCollection() and multiple clients are connected, are they reading the same data ? Typically, we provide the keyname to store/retrieve data. Here we are pointing to RedisCollection. So which keyname/Id will get used to retrieve data?
        var provider = new RedisConnectionProvider("redis://localhost:6379");
        var connection = provider.Connection;
        var employees = provider.RedisCollection<Employee>();
        var employee1 = new Employee{Name="Bob", Age=32, Sales = 100000, Department="Partner Sales"};
        var employee2 = new Employee{Name="Alice", Age=45, Sales = 200000, Department="EMEA Sales"};
        var idp1 = await connection.SetAsync(employee1);
        var idp2 = await employees.InsertAsync(employee2);

Also, since I am using this om library, I would expect the option of setting the expiry as well as deleting the collection is provided by the library. At least from the samples, I could not find anything.

The RedisCollection materializes from Redis, so yes, they are all reading from the same database, you can FindById to get an item by id, or you can just filter based on indexed attributes (see the docs)
Redis OM .NET doesn't have any way to set the expiration time of something that's been set or inserted, but you can follow up any set/insert immediately with an EXPIRE to set the expiry - it's a feature we can look into adding.

@slorello89 thanks for the details. I think its important to provide feature to set expiry at collection level.
Given that there is no default TTL and the collection items are being added individually, the expiry time should ideally be same for all items within the collection. Setting individual expiry for each item after its added is not ideal. Also, without the expiry time, the data will be sitting there forever using unnecessary memory. This is particularly important for Redis Enterprise customers as they pay for license per shard, which provides some X GB of usable memory. So developers using this feature unknowingly can fill up the usable memory.
OR the other option that can be provided is to clean up the collection after the processing is done. But to support cleanup, I think the library will need to have a track of all ids that was created for the collection. I think that the former option of expiry setting at collection level may be more appropriate as that can be set behind the scenes, when the data is inserted into Redis.

@slorello89 thanks for the details. I think its important to provide feature to set expiry at collection level.
Given that there is no default TTL and the collection items are being added individually, the expiry time should ideally be same for all items within the collection. Setting individual expiry for each item after its added is not ideal. Also, without the expiry time, the data will be sitting there forever using unnecessary memory. This is particularly important for Redis Enterprise customers as they pay for license per shard, which provides some X GB of usable memory. So developers using this feature unknowingly can fill up the usable memory. OR the other option that can be provided is to clean up the collection after the processing is done. But to support cleanup, I think the library will need to have a track of all ids that was created for the collection. I think that the former option of expiry setting at collection level may be more appropriate as that can be set behind the scenes, when the data is inserted into Redis.

Keep in mind this library is just a wrapper for redis, so unless redis supports the feature, this library won't support the feature.
Also, there is a paradigm shift in the way you can now think of redis.  Before redis-search, there were ways to do things, and hoops you had to jump through to write an app that used redis key/value structure.  Now that we have redis-search, we can think about redis with a different mind.  It's kind of like how the introduction of async/await allowed you to write cleaner code, that's what redis-search did for redis.
So for you example, you insert your records with an expiration time, and once all items have expired, the "collection" is gone, as redis doesn't store empty collections, and in the mean time you simply query the collection for the records you want to work with.
With that said, I do like the idea of an overload for InsertAsync to be able to pass a TimeSpan, and set the expiration all in one go like the StackExchange.Redis library provides.
heartbeat.Insert(model,TimeSpan.FromSeconds(15));

But if we do it insert level, wouldn't it become expiry at individual record level? I was thinking something at the collection level.
var collection = provider.RedisCollection<Person>(TimeSpan.FromSeconds(15));

and internally, whenever Insert is called, OM library sets the absolute expiry time based on what was set at collection level. That will allow all records to expire at same time.

I don't think that a collection-level TTL is something we're going to support. It's pretty un-redis-like, I can certainly see adding something along the lines of what @VagyokC4 is talking about, with an overloaded Insert, that's how string sets work after-all, and even if there is no expire option in JSON/Hashes, it's something that should be simple enough to add with pipelining.

But purely in terms of data consistency, collection level expiry makes more sense. You are no longer dealing with individual records, when you are doing the processing of a data as a collection. So records disappearing in between the processing would give inconsistent results.

But purely in terms of data consistency, collection level expiry makes more sense. You are no longer dealing with individual records, when you are doing the processing of a data as a collection. So records disappearing in between the processing would give inconsistent results.

That's not how redis works...  the "collecion" that you see is "imaginary" in the sense that it only exists as long as records exists containing that namespace.  Soon as the last record using the "key" is gone, so is the "collection" as you call it.  It's just a grouping of keys broken up by the separator.  At it's heart, redis is a key/value dictionary, and the only collection that truly exists, is the collection of keys for each dictionary entry.
I think you have a couple of options here to get the functionality you are looking for.  1) You can set an absolute expiration time by dynamically calculating your TimeSpan based on a fixed time, and then they will all expire at the same time; or 2) you can fallback to the StackExcahnge.Redis library and store all your keys under a hashset, and set an expiration on the hashset key.  Then you can update the one key as required, and all values in the hashset will disappear once the key has expired.
I think option two is the closest to what you are describing, but then keep in mind you lose what this library provides, the redis-search ability.  For some instances the search is more important, maybe in yours, the uniform expiration is more important.

@slorello89 For Redis OM Spring, I followed the recipe from Spring Data Redis https://docs.spring.io/spring-data/redis/docs/current/reference/html/#redis.repositories.expirations, which is to have a @TimeToLive annotation that you can place at the class level to give objects a default TTL upon creation, or at the property/method level to use it for specific instance TTL setting.

That's not how redis works... the "collecion" that you see is "imaginary" in the sense that it only exists as long as records exists containing that namespace. Soon as the last record using the "key" is gone, so is the "collection" as you call it. It's just a grouping of keys broken up by the separator. At it's heart, redis is a key/value dictionary, and the only collection that truly exists, is the collection of keys for each dictionary entry.

I get that. But even though its imaginary collection, we will be trying add the data into collection and process the data as a whole in the collection. So consistency of the data in the collection being processed matters. If I was dealing with individual keys, I know that individual keys will expire based on what I set individually.

You can set an absolute expiration time by dynamically calculating your TimeSpan based on a fixed time, and then they will all expire at the same time

Right. When we define the collection, we need to provide the optional input for setting expiry time, which has to be internally converted to absolute expiry time. Then whenever we call the library method to Insert new entries into the collection, this OM library should set the absolute expiry time on individual items. So all items in the collection will have same expiry time. Falling back to Stackexchange client is not an ideal option as I will need to set it individually for every item, which takes away the benefit of using an abstraction library.

@slorello89 For Redis OM Spring, I followed the recipe from Spring Data Redis https://docs.spring.io/spring-data/redis/docs/current/reference/html/#redis.repositories.expirations, which is to have a @TimeToLive annotation that you can place at the class level to give objects a default TTL upon creation, or at the property/method level to use it for specific instance TTL setting.

@bsbodden I do like this idea.  I can see this option added to the DocumentAttribute that would set a default time for each document, in addition to the override allowing the TTL to be set all in one go.
@askids What does this mean exactly?

So consistency of the data in the collection being processed matters.

Your use case is vague, so I'm not really following.  If the idea is to process all records, and remove of them once processed, then that can be done without TTL, and with this library.  In your scenario, what happens if you set a TTL and something (environmental or out-side your control) prohibits you form processing in time?  Those records are gone, and unprocessed.  This is okay for your use case?
If the priority is to process all records, and save space once done, for what I think your describing, I would have a class with an indexed Boolean property to differentiate processed from unprocessed records.  When processing I would search for Unprocessed, maybe sort by oldest to newest, and once processed, I would set the Boolean property as such and save the record.  Then if I was concerned about space I would then expire the key after an appropriate amount of time, and if I was concerned about concurrency and locking I would use something like RedLock to lock my processing code while I am processing the Unprocessed.

Closing with closed by #166


[Question] What is the use of ProxyProto option when using ngrok as a library via this crate?

Hi!
As per the ngrok documentation:

Add a PROXY protocol header on connection to your upstream service. This sends connection information like the original client IP address to your upstream service.

But when using this library, we have access to the original client IP address using Conn::remote_addr from inside the "upstream service".
Hence my question: what’s the difference when this option is set, and how is it useful?
Thank you!

The built-in proxy protocol support is helpful if the connection is being forwarded on to systems that already understand it. For instance if the application is going to relay the connection on to a proxy such as nginx or haproxy, that system would maintain the original client IP as it connects to the next system down the line. This can be more complicated when TLS is involved, depending on where it is being terminated, so it's convenient to have it just work by enabled the option.
It might not be applicable for an application where data is not leaving the rust process, unless a library being used could make use of the proxy header.

From your answer, I understand that the bytes I will get using the AsyncRead implementation for Conn will also contain the proxy header as defined by the PROXY protocol, as-is; i.e.: it is not stripped by ngrok-rs, and if I were to enable this in my Rust application, I would need to parse this header before proceeding with the actual application payload. Am I correct? I think I now understand better how this could be useful depending on the use-case, thank you!
I have to admit this wasn’t immediately obvious to me what would happen just by reading the doc, and I couldn’t test it either since I only have access to a "PRO" and not an "ENTERPRISE" ngrok plan, and this feature seems to be behind the latter only as of today.
Also saw this:
https://twitter.com/russellsavage/status/1715069177797701703
Thank you all for the prompt answer!

Thanks for your feedback! Yes, the header will appear in the payload bytes if the option is enabled. We will update the docs with more details around this feature.
I should also note that the upcoming 0.14 release will contain updates to handling proxy protocol while doing TLS re-encrypting before forwarding a connection, that can be seen in the 0.14.0-pre.8 preview version that is currently in the main branch. In that case it is parsing the proxy header off the payload bytes in order to put it on a new outbound connection to forward traffic to.


Docker Size

@rossdargan the docker image is HUGE. Not sure why that python image is so big, some of the layers are > 150mb which is crazy. We need to look into an alpine based image at least.

There are -slim versions of each of the versions.

Are you looking into this or would you like me to?

I can at some point tonight. But if you want, here is some starter code:
FROM python:2.7.13-alpine

MAINTAINER Ross Dargan

RUN apk update && apk upgrade && \
    apk add --no-cache bash git openssh gcc

Getting a little closer
RUN apk update && apk upgrade && \
    apk add --no-cache bash git openssh gcc g++ python python-dev py-pip

Need to resolve the following though:
Could not find function xmlCheckVersion in library libxml2. Is libxml2 installed?
** make sure the development packages of libxml2 and libxslt are installed **
Package 'libffi', required by 'world', not found
c/_cffi_backend.c:15:17: fatal error: ffi.h: No such file or directory

You should be able to just install it using apk https://pkgs.alpinelinux.org/package/v3.3/main/x86/libffi

Ok. It was 314 MB... I've pushed the new one to docker hub so lets see what size it thinks it is now it's over to alpine!
I need to update the readme.md to include some getting started stuff for docker (I like to give a sample docker-compose) - are you happy having that info added?

147 MB now. A bit slimmer :)

It was only 314? The base image is around 900 on its own, not sure how it got down to 314. Awesome job!


aztec(-sandbox) should have a cli interface.

It currently just runs and has a MODE env var. It's fine for certain things to be set in the environment as CLI arg alternatives, but this should be an application much like other network binaries. i.e. it accepts commands to define which subsystems are enabled.
e.g.

aztec --sandbox
aztec --sequencer
aztec --sequencer --prover
aztec --p2p-node
aztec --pxe
aztec --pxe --p2p-node

Obviously sandbox is mutually exclusive, but i think other subsystems are/should be optional?
TLDR: Use commander to make our aztec binary more intuitive.

I would add, don't just blindly implement the above. Might be worth having a discussion around what the best cli api is.
e.g.?
aztec start --sequencer [sequencer-options] --prover [prover-options] --pxe [pxe-options]
aztec cli subcommand [--options]
aztec sandbox
program
  .command('start')
  .description('Start various processes')
  .option('--sequencer [options]', 'Start the sequencer with options (e.g., "--sequencer option1=value1,option2=value2")')
  .option('--prover [options]', 'Start the prover with options')
  .option('--pxe [options]', 'Start PXE with options')
  .action((options) => {
    if (options.sequencer !== undefined) {
      const sequencerOptions = parseOptions(options.sequencer);
      // Start sequencer logic here with sequencerOptions
    }
    if (options.prover !== undefined) {
      const proverOptions = parseOptions(options.prover);
      // Start prover logic here with proverOptions
    }
    if (options.pxe !== undefined) {
      const pxeOptions = parseOptions(options.pxe);
      // Start PXE logic here with pxeOptions
    }
  });```


Gate context: Moves window inspection on import

Inspecting window on import causes issues with SSR.
When testing using the packages with Next.JS, we saw an error that window was not available. window is not available on the server-side, but the function referencing it was being invoked at import.
To resolve, we could either check whether window is defined before using it, or move the function call so that it doesn't happen on import. I am doing the latter because there are other functions that check whether window is defined.

[ ] Tested on mobile
[ ] Tested on multiple browsers
[ ] Tested for accessibility
[x] Includes unit tests - there are existing unit tests
[ ] Updated relevant documentation for the changes (if necessary)

/snapit


SPZA_IW or "App Connect" missing

I have no clue what SKU this is and I'm unable to find any information on it thus far. It is also missing from this list.
We have in our tenant 10000 licenses for App Connect (SPZA_IW).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c245452-161d-89a1-c026-99a0721cf071
Version Independent ID: 16dec59a-eb83-1837-4efd-4645e7aeaed2
Content: Product names and service plan identifiers for licensing - Azure AD
Content Source: articles/active-directory/users-groups-roles/licensing-service-plan-reference.md
Service: active-directory
Sub-service: users-groups-roles
GitHub Login: @kkern
Microsoft Alias: kakern

@bartvermeersch Thank you for your feedback . We will have this reviewed and update the thread.

The article has been updated to include the "App Connect" SKU information.

@kkern13 Thank you for updating the document. I am closing the issue now.


Create test.yml

Checklist:

[ ] My organization is added to USERS.md.

Are you serious?!?!

User reported for crypto-mining scam.

@edlee2121 @jessesuen FYI, this user attempted to raise a PR that added blatant crypto-mining code. I'm reported and blocked them.

He has created several PRs in repositories like mine. I'm reporting to active contributors of the other ones to stop it. Probably it will be banned soon by GH, as I have already reported as well.


Another Android Daily Trigger Notifications issue / alarm documentation has become confusing

Hello, thanks for the great library.
Like others, I'm experiencing the dreaded "Daily trigger notification not showing on day 2" issue on Android.
refs:

https://github.com/invertase/notifee/issues/601
https://github.com/invertase/notifee/issues/838

The documentation states:
Starting from Android 12, timestamp triggers cannot be created unless user specfically
allow the exact alarm permission.
Before you create a timestamp trigger, check whether SCHEDULE_EXACT_ALARM permission is allowed

But there is no documentation on whether we need to add that permission (or anything) to AndroidManifest.xml
Question:

In order to create and receive DAILY triggers on Android, do we need to add anything to AndroidManifest.xml ?
Are the majority of Android users able to create daily trigger notifications successfully?

Other feedback

Android Timestamp Trigger docs are starting to get confusing with the addition of the pull request: https://github.com/invertase/notifee/issues/655
Typescript is telling me allowWhileIdle is deprecated, but it is recommended in the docs
Overall I'm a bit worried that the Android Daily triggers issue is unresolved and I've gone ahead and pitched this library to my team and have QA testing things but not one person has had a "past the second day" trigger notification on a Play Internal Testing build. My team is testing various devices on Android 12 including Samsung A and Google Pixel 4a

Fwiw, here is some code in case anything is glaring:

const androidChannel: AndroidChannel = {
  id: 'myapp',
  name: 'App Daily Reminder',
  importance: AndroidImportance.HIGH,
  visibility: AndroidVisibility.PUBLIC,
  vibration: true,
  vibrationPattern: [50, 250, 250, 50],
};

const notificationObject: Notification = {
  title: 'App Daily Reminder',
  body: 'Your Streak expires soon!',
  android: {
    channelId: androidChannel.id,
    category: AndroidCategory.REMINDER,
    importance: AndroidImportance.HIGH,
    visibility: AndroidVisibility.PUBLIC,
    smallIcon: 'ic_notification',
    localOnly: true,
    sound: 'default',
    vibrationPattern: [50, 250, 250, 50],
    pressAction: {
      id: 'default',
      launchActivity: 'default',
    },
  },
  data: {
    action: 'action',
  },
};

const generateTrigger = (): TimestampTrigger => {
  const date = new Date();

  date.setHours(18, 0, 0, 0); // 6:00p.m.

  if (date.getTime() < Date.now()) {
    date.setDate(date.getDate() + 1);
  }

  log('trigger created at: ', debugDateTime(date));

  return {
    type: TriggerType.TIMESTAMP,
    timestamp: date.getTime(),
    repeatFrequency: RepeatFrequency.DAILY,
    alarmManager: true,
  };
};

// toggle a switch and check permissions >

// omitting notifee.getNotificationSettings(); and await notifee.requestPermission() for brevity

const checkAndroid12AlarmPermissions = async () => {
  const settings: NotificationSettings = await notifee.getNotificationSettings();

  log('Android settings.android.alarm: ', settings.android, 'all:', settings);

  return settings.android?.alarm == AndroidNotificationSetting.ENABLED;
};

// if permissions are good call this to create the triggers

const createLocalTriggerNotifications = async (): PromiseOk => {
  const trigger: TimestampTrigger = generateTrigger();

  try {
    // Android only
    await notifee.createChannel(androidChannel);
    // Create a trigger notification
    await notifee.createTriggerNotification(notificationObject, trigger);

    return 'OK';
  } catch (error: any) {
    log('error: could not create trigger notification', error?.message);

    throw error;
  }
};

Closing as the requirements for my app have changed. Still using notifee though! but for different use cases.


[WIP] Engineering research on issue 439

This is not meant to work but rather it is a first sketch of how we could turn ParsedJson into a generic consumer for stage 2.
The end game would be to totally separate how the stage 2 events are consumed (to a 64-bit tape, to a 128-bit tape, or to a custom consumers) from the stage 2 code itself. Ideally, this would be done without any performance penalty whatsoever. Then we could freely experiment with different consumers. This would make research on different tape designs much less daring. It would also open the door to lots of other consumers.
I am deliberately not finishing this... Rather I want to encourage discussions and contributions.
cc @jkeiser
https://github.com/lemire/simdjson/issues/439

Oh crud, I forgot about this when I built mine. Mine differs only in that it separates ParsedJsonWriter from ParsedJson, because I was really hoping we could give the user an object without our messy internal methods on it.

Killing this PR.


Feat/arm64 linux builds

Doesn't fully work - seems like it can upload an AppImage, but fails after that. I think building arm images with a docker container is a more reliable and portable approach.


WIP: Add API tests for metadata handling

A concrete example on how we could handle metadata. Still work in progress and open for discussion.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: gantt lib upgraded to v0.3.0

TASK ID: https://bloomstack.com/desk#Form/Task/TASK-2020-00089

Pull Request Test Coverage Report for Build 970

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 51.874%

Files with Coverage Reduction
New Missed Lines
%

frappe/utils/change_log.py
3
21.53%

Totals

Change from base Build 967:
-0.002%

Covered Lines:
21706

Relevant Lines:
41844

💛  - Coveralls

develop:https://github.com/frappe/frappe/pull/10689
hotfix:https://github.com/frappe/frappe/pull/10690


feat: validate the data directory

What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Add the same validating process as the kernel side: https://github.com/risingwavelabs/risingwave/pull/9992/files
Checklist

[x] I have written the necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)
https://github.com/risingwavelabs/risingwave/issues/9974
#441

It seems some new changes are made: https://github.com/risingwavelabs/risingwave/pull/10064/files#diff-51021b3146117ad53f27f1ed377e2eb9a48bcf5190fa69feca6d625d07d98219R691
^[0-9a-zA-Z_/-]{1,}$

instead of
^[0-9a-zA-Z_/]{1,}$"

one more -


v5 (SLEEP) Release TODO

Blockers

[x] merge sleep branch
[x] finish api declared by readme
[x] re-add old tests
[x] range requests
[x] refactor selection api
[x] don't download data if we are writable
[x] re-impl timeouts when replication
[x] release v6 of replicaion protocol
[x] switch to blake2b for discoveryKey / hashing

Non blockers

[ ] emit critical errors (feed signed, but sig is wrong fx)
[x] optimize replication (encoding+allocation seems to be a bottleneck)
[ ] progress monitoring of latest
[ ] dedup tree nodes when replicating
[ ] browser support (finish sodium-javascript)

V5 IS OUT!!!!


Do I need to install any deep-learning libraries?

Thanks a lot for your great work.
I have read your paper and now try to reproduce your work.
For this purpose, do I need to install any deep-learning libraries, such as pytorch or tensorflow?
Thanks a lot.

Yes, you need to install Chainer library. I have added the details in README
Also, the GAIN paper is NOT my work.


Modify UserAgent header for client-side Encryption

Description
Adding azstorage-clientsideencryption/ flag to the user-agent header string for any requests that use client-side encryption in Blobs.
User-Agent header string will go from:
azsdk-java-azure-storage-blob/12.24.0-beta.2 azsdk-java-azure-storage-blob-cryptography/12.23.0-beta.2 (<IP_ADDRESS>; Windows 11; 10.0)
To:
azstorage-clientsideencryption/2.0 azsdk-java-azure-storage-blob/12.24.0-beta.2  azsdk-java-azure-storage-blob-cryptography/12.23.0-beta.2 (<IP_ADDRESS>; Windows 11; 10.0)

API change check
API changes are not detected in this pull request.

/check-enforcer override

Overriding since failing tests are unrelated to the changes made.


[BUG] Window closes when it really shouldn't

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When you select option 1 the window closes immediately.
Expected Behavior
I expected that it worked.
Steps To Reproduce

run the program
press 1
press enter

Environment
- OS: Windows
- Python: 3.9.6
- pip3: 21.1.3

Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, I am currently trying to replicate the issue, I will update this issue with the results soon.

I tried on python 3.10, it works.

Try updating your python, if that doesnt work, I'll reopen this issue

i forgot if this is still a thing

I don't know.. I don't have python atm so I can't test..

its fixed


.repeated().repeated() hangs silently

In 1.0.0-alpha.3, I've found that .repeated().repeated() hangs silently during parsing. Here's a simplified version of the code where I discovered it:
use chumsky::prelude::*;

#[derive(Debug)]
pub struct Values;

pub fn parser<'a>() -> impl Parser<'a, &'a str, Values, extra::Err<Simple<'a, char>>> {
    let comments = just("//").ignored().repeated();

    any()
        .ignored()
        .padded_by(comments.repeated())
        .repeated()
        .collect::<Vec<_>>()
        .map(|_| Values)
}

fn main() {
    let src = "Would you rather have a CurseForge or a hex editor?";

    println!("{src}");

    println!("Creating parser...");
    let parser = parser().then_ignore(end());
    println!("Parsing file...");
    let result = parser.parse(src);
    println!("Done!");

    if let Some(value) = result.output() {
        println!("{value:?}");
    }
    for error in result.errors() {
        println!("{error}");
    }
}

It prints Creating parser... and Parsing file..., but then gets stuck.
Thanks for the awesome crate!

This is correct behaviour (although I can understand that it feels a little surprising).
repeated is permitted to accept a pattern any number of times, including none at all.
This means that a single x.repeated() can actually never fail: even if it doesn't see any of x, it can always fall back to accepting nothing (this is useful: it can do things like parsing lists with no items).
If you add another .repeated() on the end, things get a little funky. Now we're asking for a potentially infinite number of items from a parser that can accept nothing at all: so the second repeated keeps spinning around successfully pulling nothing out of the inner repeating parser.
TL;DR: don't do this, it's pretty much always incorrect. In fact, we're working on implementing a linter (see #280) that will catch cases like this before the parser even runs. Additionally, #368 implements a runtime check that will catch cases like this when compiling with debug mode (but this has not been released in an alpha release yet).

A linter/runtime check resolves this perfectly!


Using GridSearchCV in BoostedTreesClassifier

I'm trying to Implement GridsearchCV on BoostedTreesClassifier. Since BoostedTreesClassifier has not the fit method, is there any alternative to implement the GridsearchCV?

@samanemami,
Estimators BoostedTreesClassifier are not extensively used in Tensorflow 2.x Version.
So, . Please check this Stack Exchange Answer. This article might also help you. Thanks!

@rmothukuru
Estimators BoostedTreesClassifier, instead of fit ,  has train, which is indicated in the tutorial also. So, it is not possible to implement Sklearn gridsearch as indicated in the page, or this link you have sent.
So is there any other solution to add fit in order to use the above solutions, or any updates in Estimators BoostedTreesClassifier?

I solved the issue by defining a new estimator which contains the fit and score method based on the Sklearn standard.
The proposed script is available on the following repository.
TFBoostedTree


No Image Rendering

I'm attempting to render an image from a base64 string stored in a database. dicomParser is correctly reading the data, but the image loader isn't rendering anything. I always get a canvas with zero height and width, despite the fact that the image data from dicomParser is correctly showing 600 and 800 for height and width, respectively. Any thoughts on where to start troubleshooting?
Here is the function I'm using to convert my base64 string to a file:
//Load image function
function loadAndViewImage(imageId,element) {
    cornerstone.loadImage(imageId).then(function(image) {
        console.log(image);
        var viewport = cornerstone.getDefaultViewportForImage(element, image);

        cornerstone.displayImage(element, image, viewport);
    }, function(err) {
        alert(err);
    });
}

//Convert base64 string from database to array parts for new File()
function b64toArrayParts(b64Data, sliceSize) {
  sliceSize = sliceSize || 512;

  var byteCharacters = window.atob(b64Data);
  var byteArrays = [];

  for (var offset = 0; offset < byteCharacters.length; offset += sliceSize) {
    var slice = byteCharacters.slice(offset, offset + sliceSize);

    var byteNumbers = new Array(slice.length);
    for (var i = 0; i < slice.length; i++) {
      byteNumbers[i] = slice.charCodeAt(i);
    }

    var byteArray = new Uint8Array(byteNumbers);

    byteArrays.push(byteArray);
  }

  return byteArrays;
}

if (row.Name.endsWith('.dcm')) {
    //Get base64 string, and create File.
    var Base64content = (row.Body.realBlobValue!==undefined) ? row.Body.realBlobValue.asByteArray : row.Body.asByteArray;
    var arrayParts = b64toArrayParts(Base64content);
    var file = new File(arrayParts,row.Name,{type:'image/dicom'});
    console.log(file);

        //Create and add element to our field
	var dicomDiv = $('<div>')
	    .addClass('dicom-image')
	    .attr('id','dicomImage')
	    .css({height: '512px', width: '512px'});
	field.element.append(dicomDiv);

    // Enable element with cornerstone
	var csElement = dicomDiv.get(0);
    cornerstone.enable(csElement);

   // Load image.
    var imageId = cornerstoneWADOImageLoader.fileManager.add(file);
    loadAndViewImage(imageId,csElement);
}

Code looks fine, do you see any errors in the console log?  If not, try setting some breakpoints.  If possible, you should have your server convert from base64 to DICOM P10 and use the wadouri loader.  This will require less network bandwidth (base 64 increases size by 50%) and allow you to leverage the cornerstone cache and on demand loading mechanism that you lose by using the dicomfile approach the way you are doing.

Thanks.
I think I actually have the files on the server in DICOM P10, but I keep getting CORS errors that I can't get around with the wadouri loader. Know anyone who has done DICOM integration with Salesforce?

I don't know anyone that has integrated DICOM with Salesforce.  You can fix CORS issues with a proxy if you can't get the server that stores the DICOM to add the right headers

Can you please close unless you think there is an issue in cornerstone>?


Question about theme support at css(sass)

Hi!
-1.This is not problem, just question. I have not found more suitable place to put my questions.
-2.There are theme_image_tag & image_tag to overload an image at theme, but there are also css (sass) with code like this:
"
li
list-style: none
background: url(/images/decorators/square.png) left 2px no-repeat
"
Is any way to select rigth image at css/sass based on current theme? Are you planning to do something to resolve this problem? If yes, what exactly (I will try to help)?
Artem.

To do that, you will have to use the asset pipeline, on rails 3.1 or later, and mixed ruby variables on the sass templates.
Unfortunately, ThemesForRails doesn't work with the new Assets Pipeline. I am still thinking about how to integrate it properly. I did some tests, but I did not like the solution.
If you want, please elaborate a little bit more.

Hello,
Thank you for answer, I will take a look at asset pipeline and understand is it suitable for my requirements or not.
Sincerely yours,
Artem Rufanov
P.S.
Have a good day!


Abnormal GPU Usage

When using the program I noticed that the GPU is at 12%, and it is an RTX 3050, I realized that the problem was corrected but I wanted to pass this on.

Could you attach a screenshot or such? Was Hydra idling? Wast it running on the background? Please explain a little bit further.

I noticed that this abnormal GPU consumption only occurs when the program is open, when I minimize consumption it stays at 4% or 5%.

Could you provide a screenshot like this one? The one you sent tell us nothing about much Hydra specifically is using. It tells the total use all your processes.

My one has been using a little bit more without downloading anything too, is it normal? I got a RTX 3070 //I7-10th // 32gb 2666mhz ram
Not downloading

Downloading

Solved in 2.0. Please open a new one if that's still an issue.


If I create an activity and use methodchannel, can flutter receive it?

I create an activity and use methodChannel, but i find that the result.success() didn't work. Flutter didn't receive the result.

Hi @libo1223
have you followed https://flutter.dev/docs/development/platform-integration/platform-channels?
could you provide your flutter doctor -v and minimal reproducible project?

I don't think it is the problem of methodChannel. I use MethodChannel in MainActivity didn't have any trouble.
So, i want to know the another activity which i created can use MethodChannel to Flutter?
In my view, flutter is work on the MainActivity, when the MainActivity is finish(), Does flutter can receive the message? Or i should to startActivity the MainActivity and post the message to flutter.

So, i want to know the another activity which i created can use MethodChannel to Flutter?

Yes, any Activity can use method channel.

In my view, flutter is work on the MainActivity, when the MainActivity is finish(), Does flutter can receive the message? Or i should to startActivity the MainActivity and post the message to flutter.

Not sure if I understood this correctly. @libo1223 can you clarify this?

So, i want to know the another activity which i created can use MethodChannel to Flutter?

Yes, any Activity can use method channel.

In my view, flutter is work on the MainActivity, when the MainActivity is finish(), Does flutter can receive the message? Or i should to startActivity the MainActivity and post the message to flutter.

Not sure if I understood this correctly. @libo1223 can you clarify this?

Sorry, it's my fault. Now i know how to use it.

So, i want to know the another activity which i created can use MethodChannel to Flutter?

Yes, any Activity can use method channel.

In my view, flutter is work on the MainActivity, when the MainActivity is finish(), Does flutter can receive the message? Or i should to startActivity the MainActivity and post the message to flutter.

Not sure if I understood this correctly. @libo1223 can you clarify this?

can you close this issue?


Unsubscribe before server returns the subscription id

Let's say I have a component with the following lifecycle events:
componentDidMount() {
  this.unsubscribe = this.props.subscribe();
}

componentWillUnmount() {
  this.unsubscribe();
}

In certain cases this component may be mounted and unmounted quickly (dropdown menu on hover, or dialogs that get dismissed instantly). This may lead to the situation where subscriptionId hasn't been returned from the server before this.unsubscribe is called.
With Absinthe, this will generate a server side error.
I don't think there is any API enables the component itself to avoid such situation. Should absinthe-socket handle this?

Hi @chengyin,
Just to confirm, are you using absinthe-socket or any of the connector packages?

Actually let me emphasize that I’m not 100% sure if the quick unmounting is causing subscription id missing. But that’s one way to reproduce the issue.
And we are using the absinthe Apollo link.

If you are using @absinthe/socket-apollo-link, then this should be handled automatically (here).
Where did you see the error?

Sorry, this was an issue on our end. I updated to the newest version of absinthe link in our master branch but I was testing on a branch with older version.
With the new version I hasn't seen any issues yet.
Sorry about the false report!

Great @chengyin, np, cheers.


Rebuild refactoring

refactor(rebuild): make the rebuild more generic

A rebuild is essentially a copy from one bdev to another.
However, we can have different variations on this.
This change aims to make the rebuild more generic, removing the nexus specific
bits from the core rebuild logic and allowing us to compose different types of
rebuild in the future, whilst being able to reuse the shared bits.

To achieve this the rebuild backend is split into a rebuild manager which is the
generic component responsible for running and managing the rebuild and its tasks.
We can then implement different rebuild backends as we see fit, example a nexus
rebuild which locks ranges or a regular bdev to bdev rebuild.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

fix(rebuild): send final rebuild state on drop

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

bors try

bors merge

Had forgotten to resolve comment :(
bors should complain right away, not sure if possible though!
bors merge


Use for localization for already built map

Hello,
First of all, thank you for your great contribution. Is it possible to use this package for localization once the map has been generated?
Thanks!

Hi @iandresolares -- yes, it is possible. You basically just need to read in the PCD and set it as the first (and only) keyframe. Then, whenever you localize on the map, you will need to set the initial position.

Got it, will give it a try, thanks!


Documentation issue

http://davidjbradshaw.github.io/iframe-resizer/
seems to be outdated and the linked ZIP and TGZ dont contain the current js.

Yeah they used to make it really easy to update it. I don't see the option anymore. If you can point me at it, I'll rerun the publish script.


fix(cjs): add regex to clear mongoose main file cache

Types of changes

[X] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Introduce isHMRCompatible function to detect clear incompatible modules cache.
As we know mongoose is incompatible and clearing mongoose/index.js and mongoose/lib/index.js makes it work.
close #7917

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #7938 into dev will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##              dev    #7938      +/-   ##
==========================================
- Coverage   68.92%   68.89%   -0.04%
==========================================
  Files          91       91
  Lines        3846     3848       +2
  Branches     1041     1041
==========================================
  Hits         2651     2651
- Misses        971      973       +2
  Partials      224      224

Flag
Coverage Δ

#unittests
68.89% <33.33%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/utils/src/cjs.js
65.71% <33.33%> (-3.99%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9d759...123e3e3. Read the comment docs.


Better type hints for .watch and .unregister of useForm instance

Fixes #159
Proposed Changes

Enhance field name arguments type of .watch and .unregister (in useForm) from string | string[] to Name | string | (Name | string)[]. This provides better auto-complete hints in IDEs for most field names (with the exception of individual array and nested field names).

thanks @kaleabmelkie for the quick PR, @stramel and @barrymay you guys want to have 👁 over this?

LGTM. I'm still planning on trying to clean up the typings. I would like to avoid the weird castings but I need to look up a few things.

cool let's merge this one in first and sort it after @stramel I think its an improvement for now?

Yes, I should be an improvement for now

@kaleabmelkie could you please resolve the conflict? we will get this one out in the next release

@stramel on your comment

LGTM. I'm still planning on trying to clean up the typings. I would like to avoid the weird castings but I need to look up a few things.

totally agree - I haven't looked into this at all, but I wonder if the strings need to be there at all, what's the case still to not use Name | Name[]?  I look forward to your PR

@barrymay, I believe just Name | Name[] would be insufficient for nested field names like: form.watch('foo.bar')

@barrymay, I wonder if something like form.watch('foo.bar') is supported?
(Sorry, I'm new to this library)
If it is not supported, then I believe the string types have no purpose, and it could be just Name | Name[]

@kaleabmelkie yes it's supported

Then I think that the strings will be needed.
I'll try to resolve the merge conflicts now.

@bluebill1049, I believe it's ready now.

thank you @kaleabmelkie

could you please do testing for the beta version too? 3.21.1-beta.1 I will test it out too.

@bluebill1049 thanks for the clarity ;)


test

The problem
test
Version of nodejs
test
Version of ioBroker js-controller
test
Version of Adapter
test
Operating system running ioBroker
test
Checklist of files to include below

[X] iobroker.current.log (Please share the logs in debug mode)
[ ] Contents of the JavaScript browser console (always include in cases of issues with the user interface)

Additional information & file uploads
test

ok


genomicVariant vs. genomicVariation

While I like genomicVariation (used in the schema), the mix of genomicVariant vs. genomicVariation is confusing. I'd settle for one version.
https://github.com/ga4gh-beacon/beacon-v2-Models/blob/c6552b66d206601fb909074b11b690e300d0a0aa/BEACON-V2-draft4-Model/beaconConfiguration.json#L60

Yes, I know, this was also an "experiment", like the "extendedInfo" one.
We are working on the "Variant Cluster" and come back with suggestion after the weekend.


v0.5.8 gem release

Hi,
Could you release the latest version (v0.5.8) gem? I'd like to use ignore_under method without the definition of github url in my Gemfile.

Thank you for your request :-)
v0.5.8 has been released.

Thank you for your quick response :D


Native assets for API Byron wallets

Issue Number

ADP-603
Overview

ad0750343582eebd769e896d5ac9fc16c47f0528
:round_pushpin: mark migration endpoints as disabled in the API documentation.

a86bd7b35c8da358d5f6204faabe29d781818108
:round_pushpin: add 'assets' to ApiByronWallet
It is actually totally legit and possible to send native assets to a Byron addresses.
Addresses and multi-assets are totally decoupled. So we ought to support it too.

Comments

bors merge

bors merge

@KtorZ, I suppose there is also "Assets" section for Byron wallets missing like the one for Shelley -> https://input-output-hk.github.io/cardano-wallet/api/edge/#tag/Assets.

@KtorZ, I suppose there is also "Assets" section for Byron wallets missing like the one for Shelley -> https://input-output-hk.github.io/cardano-wallet/api/edge/#tag/Assets.

Doh. That's correct.

Doh. That's correct.