07/20/2018 00:00 : Create Pull Request for branch master -> prTesting1_2018071923

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Crash for recursive call on setCollectionViewLayout(_:animated:)

I have a feature to switch layout ( grid <-> list), so I call setCollectionViewLayout to switch.
But if I start from 'grid -> list -> grid', it will crash.
From the call stack, we can see two IBPUICollectionViewCompositionalLayout is called repeatedly.
p.s. in iOS version below iOS 13.
Example code as follow,
    switch layoutMode {
    case .grid:
      collectionView.setCollectionViewLayout(grid, animated: false)
    case .list:
      collectionView.setCollectionViewLayout(list, animated: false)
    }

call stack & error message as follow,

Hello, I also encountered this problem.
Have you solved it？

I have a feature to switch layout ( grid <-> list), so I call setCollectionViewLayout to switch.
But if I start from 'grid -> list -> grid', it will crash.
From the call stack, we can see two IBPUICollectionViewCompositionalLayout is called repeatedly.
p.s. in iOS version below iOS 13.
Example code as follow,
    switch layoutMode {
    case .grid:
      collectionView.setCollectionViewLayout(grid, animated: false)
    case .list:
      collectionView.setCollectionViewLayout(list, animated: false)
    }

call stack & error message as follow,

Hello, I also encountered this problem.
Have you solved it？

I found the solution.
You can try like this.
- (void)setViewModel:(GGViewModel *)viewModel {
    self.collectionView.dataSource = nil;
    self.collectionView.delegate = nil;

    if (!self.collectionView.dataSource) {
        self.collectionView.dataSource = self;
    }
    if (!self.collectionView.delegate) {
        self.collectionView.delegate = self;
    }
    [self.collectionView setCollectionViewLayout:layout animated:NO];
}

@ali0201 not yet! I will give it a try, thank you!

@ali0201
I tried to reset delegate for collectionView, it works! Thank you : )
    if #available(iOS 13.0, *) { } else {
      collectionView.delegate = nil
      if collectionView.delegate == nil {
        collectionView.delegate = self
      }
    }
    collectionView.setCollectionViewLayout(layout, animated: false)


update to scala 2.13 and scalismo-faces 0.90.0

This PR:

updates the project to scala 2.13 and to scalismo-faces 0.90.0 as dependency.
fixes warnings from scala and the IDE.

Thank you for updating this repo!
looks good to me
I somehow had to run sbt twice to compile - could be a mistake on my side though
made a quick test and can click landmarks :)


SULU contact bundle and registration and user entity and other things!

Q
A

Bug?
no

New Feature?
yes

Sulu Version
develop

I know it is a long post please be patient!
I want to add user registration functionality to my sulu system, I have 2 choices :

use one of strong user bundles around the web like friends of symfony user bundle.
use sulu contact bundle

in the first solution the problem would be multiple user entities and that would be a problem in future for sure! on the second solution the problem will appear in the development process cause sulu contact bundle is not that strong yet and can not work with other useful bundles from FOS or Sonata project or etc or maybe I am wrong please help.
Also there is a problem with both of these choices; I plan to run multiple websites and even android apps on multiple webspaces sharing one sulu core but the contacts are shared between webspaces and there is a chance if one of users register on one of these webspaces through on of these websites then he could not register on other websites because when he tries to register he will see that his email is already registered! and of course he does not know these websites use one core.
I can add a parameter to user entity to indicate the webspace which user registered in. and restrict the admin login page to allow only admin roles and stop regular users getting in the admin panel. then I need to synchronize contact entity to be able to work with other strong bundles which are around and after that the challenge is started to make everything working like sulu structure with REST API and so on!
It does seems a lot of work to do! but I think you sulu people should separate sulu bundles in different repositories on GitHub to make it more developer friendly. in the current system it is too big and complicated!
Oh I talked and talked and talked! Now any idea what should I DO?

Hi @Kharestani,
I created a bundle for this  https://github.com/alexander-schranz/sulu-website-user-bundle. You can use it or have a look at it to create your own one.

Hi @alexander-schranz
You rock man! I will check it and get back to you.

the bundle from @alexander-schranz is quite good so we can close this issue. if you have any other related issues you can reopen it.

ok @alexander-schranz awesome bundle does help but there is a problem with multiple webspace!
the contact entity does not contain information about user webspace and when a user register in one webspace it is accessible from other webspaces as well and that is not good because the beautiful sulu tries to make multiple apps and websites to run under a shared roof so ... we need to do something  I ask you @wachterjohannes to please reopen the issue to find a solution for this.

I propose Contat spaces in that way any webspace can be configured to use one of these contact spaces and multiple webspaces can share one contact space.

i think that should be possible with different roles for each webspace. because sulu checks the systems of the roles and therefor this should work @alexander-schranz correct me if i am wrong.

@Kharestani @wachterjohannes thats right you can have different roles for webspace A and webspace B. Think you need to configure the security.yml which role can access which routes. The only restriction is that the email and username is unique so you can not register on webspace A when you are registered on webspace B with the same mail address.
There are 2 possibly solutions for this:

You overwrite the User.orm.xml that the email address is not longer unique.
You create a cross registration (e.g. Register with your Shop account) This is something what is also on my roadmap (https://github.com/alexander-schranz/sulu-website-user-bundle/issues/14)

@Kharestani is that enough for you?

Brilliant! I think that will work for me and what I need but I think in future sulu should do this to make it more flexible.
thanks alot to @alexander-schranz for the solution and to @wachterjohannes for all of this.


CPSC 340 Gardening

@jopika, @mgelbart , there are a few cleanups needed for the 340 code; the tests should pass:
https://circleci.com/gh/ubccpsc/classy/51 (this is the repo visibility test failing)
And some more coverage work is needed, e.g.,:
https://coveralls.io/builds/18036379/source?filename=src/controllers/340/AssignmentController.ts
https://coveralls.io/builds/18036379/source?filename=src/server/340/CS340REST.ts

Once the test is passing hopefully this will clear up too:
https://coveralls.io/builds/18036379/source?filename=src/controllers/util/GitHubActions.ts#L711

The test is fixed, was an ordering issue (the repositories/teams were being wiped before my test could run).
I'll be adding more code coverage after I finish my repository creation code.

Tests have been added; will continue adding tests as needed.


Update licensing-service-plan-reference.md

Corrected Service Plan ID for PowerApps For Office 365 K1. Added the last character 'a' to the ID.

@Nicholak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change. @kkern

Hi @kkern13 - Could you review this pull request? Also, the metadata author attribute value in the article needs to be changed from kkern to kkern13. Currently, a GitHub user kkern is receiving automated notifications when one of your articles is updated in the public repository (it might be an account you own, but your Microsoft-linked GitHub user name should be the author metadata value).
Thanks!

Approved per email; merging.


ADD "your cost" on Avarege profit

I think is a good idea to quickly see your min price you want to sell the craft for, especially if you are planning to sell it days after.
If an Item costs 161g in ah and I see profit of 18g, I need to go to the ah after the craft, remember the price, open profession tab and do the math.
It would be faster to just "print" the my cost there.

i dont quite get where u want to show it and what my cost should represent? crafting costs?

yes like somewhere here https://i.imgur.com/BVm4qyC.png, and yes crafting cost without going back to the AH and do the difference from AH price minus my average profit


[Bug] Error 'The name is already used' on crud update

Bug report
What I did
my model has two keys :
primary key Id
unique key chantiers_nom_unique (firm_code + chantier_name)
nothing special on standard crud, no implementation of the save method.
What I expected to happen
standard crud update () when another field (not firm_code or chantier_name) is modified in the model
and message "item has been updated with success"
What happened
Error "The name already used"
What I've already tried to fix it
/
Is it a bug in the latest version of Backpack?
I don't think so but my double key is recent.
After I run composer update backpack/crud the bug... is it still there?
Yes
Backpack, Laravel, PHP, DB version
    "backpack/crud": "5.1.2",
    "backpack/logmanager": "^4.0",
    "backpack/permissionmanager": "^6.0",
    "backpack/pro": "^1.0",

    "laravel/framework": "^9.2",
    "laravel/sanctum": "^2.14.1",
    "laravel/tinker": "^2.7",
    "laravel/ui": "^3.4",

When I run php artisan backpack:version the output is:
PHP VERSION:
PHP 8.1.20 (cli) (built: Jun  7 2023 08:21:17) (NTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.1.20, Copyright (c) Zend Technologies
LARAVEL VERSION:
v9.17.0@091e287678ac723c591509ca6374e4ded4a99b1c
BACKPACK VERSION:
5.1.2@a15f93a784e8d130f5ea5c3341fb7bca1f3c25e3
Thank's to look at this !

my rules on ChantiersRequest
public function rules()
{
return [
'nom'       => [
'required',
'min:3',
'max:40',
Rule::unique('chantiers')->where(function ($query) {        // Clé unique composée : societe_id + nom
return $query->where('societe_id', $this->societe_id);
}),
],
'image'     => 'max:65535',
'latitude'  => 'required|numeric',
'longitude' => 'required|numeric'
];
}

Hello @AndreNeny i dont think this is a backpack bug because is about rules, Backpack didnt handle it:
if i see your rules did you try with ignore?
public function rules()
{
return [
  'nom' => [
  'required',
  'min:3',
  'max:40',
  Rule::unique('chantiers')->where(function ($query) { // Clé unique composée : societe_id + nom
  return $query->where('societe_id', $this->societe_id)->ignore([here_the_current_id]);
  }),
  ],
  'image' => 'max:65535',
  'latitude' => 'required|numeric',
  'longitude' => 'required|numeric'
  ];
}

Cheers.

Doing a cleanup of stalled issues.
Please @AndreNeny report back if you were not able to fix it and we can re-open this.
Cheers

Hello Jorge,
Thanks a lot for your response. I will try - ignore as soon as possible.
Cheers,
André Nény
Le jeu. 3 août 2023 à 22:48, Jorge @.***> a écrit :

Hello @AndreNeny https://github.com/AndreNeny i dont think this is a
backpack bug because is about rules, Backpack didnt handle it:
if i see your rules did you try with ignore?
public function rules()
{
return [
'nom' => [
'required',
'min:3',
'max:40',
Rule::unique('chantiers')->where(function ($query) { // Clé unique composée : societe_id + nom
return $query->where('societe_id', $this->societe_id)->ignore([here_the_current_id]);
}),
],
'image' => 'max:65535',
'latitude' => 'required|numeric',
'longitude' => 'required|numeric'
];
}
Cheers.
—
Reply to this email directly, view it on GitHub
https://github.com/Laravel-Backpack/CRUD/issues/5241#issuecomment-1664629254,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKHAHYQ6PYG4CQ34RH6BUILXTQFBVANCNFSM6AAAAAA24LMPP4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello Jorge, That's good with your advice. Thank's a lot !


cross compilation steps

I am not sure I should call this as issue or not. Please close if this doesn't fit in the issue category.
It would be helpful if cross compilation steps are provided in the README. Or better if autoconf/makefile kind support available for cross compilation.

When I had to cross compile netifaces to my platform I used crossenv


Update Aerosol Chemistry BCs CHMDIR variable to match vertical levels

A possible band aid fix for now. @wmputman approve if you think this is a possible solution in the short term. Also, what about L137 - same as L72?

@sdrabenh I think L137 is "upstairs" as it were. I guess I should ping Mark and Rob about this...

@mathomp4 I'm not sure anyone but the modeling group is using L137 right now


Ref training nlist

Pull Request Summary
The last PR (#274) got closed accidentally and I can't reopen for some reason.
This relates to some of the changes suggested in Issue #269.  Specifically, this streamlines the Neighborlist for training.  The code has changed quite a bit since these initial classes had been sketched out, and this should hopefully make things clearer and make the code easier to read.  This also will reduce the need to massage the config dict inputs related to the neighbor list cutoff that currently needs to be done.
Key changes
Notable points that this PR has either accomplished or will accomplish.

[x] The key logic used in what had been the NeighborList class is merged in the CalculateInteractingPairs class.
[x]  The Neighborlist class has been removed.
[x] CalculateInteractingPairs is renamed NeighborListForTraining and moved to the neighbors.py file
[x] The PairList class has been moved to the neighbors.py file
[x] Update documentation to reflect the naming changes and locations of several key classes.

Associated Issue(s)

[x] #269

Pull Request Checklist

[x] Issue(s) raised/addressed and linked
[x] Includes appropriate unit test(s)
[x] Appropriate docstring(s) added/updated
[x] Appropriate .rst doc file(s) added/updated
[x] PR is ready for review

Codecov Report
Attention: Patch coverage is 92.30769% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (b594cfe) to head (f55d08e).

Additional details and impacted files

Since this was approved before being accidentally closed, I'm going to just go ahead and merge.


freerdp3: 3.8.0 -> 3.9.0

https://github.com/FreeRDP/FreeRDP/releases/tag/3.9.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 350277

x86_64-linux

:white_check_mark: 11 packages built:

budgie-control-center
budgie-control-center.debug
freerdp3
gnome-connections
gnome-control-center
gnome-control-center.debug
gnome-remote-desktop
gtk-frdp
phosh
phosh-mobile-settings
remmina

budgie-control-center budgie-control-center.debug freerdp3 gnome-connections gnome-control-center gnome-control-center.debug gnome-remote-desktop gtk-frdp phosh phosh-mobile-settings remmina

Thanks!


Spellbook Spells behaviour (OLD vs OSI) (Feature Request)

So as we all know, in old versions, the spells used to work in some way, now we have some new sphere.ini flags, that change the elemental engine and behaviour of multiple things to OSI like.
I was thinking, for some basic spells, If it would be worth to make extra switches for it, to be able to keep old behaviour of them, instead of need to fully rescript.
Flag changing behaviour: COMBAT_ELEMENTAL_ENGINE
Its mainly:

Arch Protection
Reactive Armor
Magic Reflection

solved on dev branch, thanks!


[Warhammer 4e Character Sheet] - What features are still WIP?

@Djjus Do you have a list of talents that require implementation/fixes? Also, do you have any proper testing method for it? Changing source code of roll20 in chrome isn't the most pleasant and I wonder if you have a better method.

@Robak132, yes the ones you have added visibility for recently. Which i think are all situational (so will not add to the auto calc of SL). This is why they are left till last, they need to be added in a certain way.
I test via Custom Sandbox which you get with Roll20 Pro account, it's by far the easiest way.

@Djjus Do you have plans for integrating Armour Qualities? It shouldn't be hard and will be quite useful for Partial or Weak Spots.

Armour Qualities are not that easy to add properly because you can not really target other players, so when you roll your attack this roll can not know the Armor etc of the target. Right now you can up some info in the Armor Qualities text field, which displays when you Perform a Parry and Dodge rolls (i.e. defensive opposed roll).

There is no easy way around this issue right now.

@Djjus You could add it as checkboxes to add info to the opposed test. Using that you don't need to remember each effect.
Having full armor with Partial, Weakpoints and Impenetrable can be quite difficult to track.

BTW i'm looking to add the logic for the remaining Talents this week.

Ok its not hard, i'll put something together for next release

Also if spells names in the spellbook have any meaning? There are plans to add some logic to them?

Their was, but i was made to remove it. Copy Rights etc

So you are planning to remove them at some point or keep them. If second option I will opt to make them localisable.

I see no reason to remove them.

Yesterday I found problem with x2 Encumbrance penalty. It seems like you only have -10 instead of -20 to Agility. Sadly, I'm not sure how to fix that.

And one extra suggestion: adding Pummel to ranged weapons (sling ammo has this quality)

Yesterday I found problem with x2 Encumbrance penalty. It seems like you only have -10 instead of -20 to Agility. Sadly, I'm not sure how to fix that.

Looks ok to me, at the moment. Maybe only under certain conditions? Note minimum Agi is 10 due to this penalty.

And one extra suggestion: add Pummel to ranged weapons (sling ammo has this quality)

Ill add this now, as i'm working on this part anyway

Yesterday I found problem with x2 Encumbrance penalty. It seems like you only have -10 instead of -20 to Agility. Sadly, I'm not sure how to fix that.

Looks ok to me, at the moment. Maybe only under certain conditions? Note minimum Agi is 10 due to this penalty.

And one extra suggestion: add Pummel to ranged weapons (sling ammo has this quality)

Ill add this now, as i'm working on this part anyway

"Zw"="Ag", it looks like it only giving -10

ok i see it, will take a look

It appears that this character sheet is broken, recreating it fixed all issues

Another suggestion: Archives of Empire II added a skill called "Ranged (War Machine)" used to fire cannons, balistas other siege artillery also there is "Ranged (Catapult)" in Up in Arms. I don't see a point in adding that specific skills but maybe you can add "Ranged (Misc)" and "Melee (Misc)" as you have Channeling (Misc) for similar reasons.

Yes, advanced ranged has not been added yet, I'm still considering how to do it exactly, It might bne as you say with Misc. Or perhaps more targeted if it makes sense. and add the Crew Quality. But its not that high of a priority right now. It's not very hard to do, but would be good it it makes sense.

@Djjus I have another idea for a feature that shouldn't be hard and I think that I can try to code it myself. We don't have any place on the character sheet to store Psychologies such as Hatred or Animosities. I propose another field similar to injuries on the main tab to store such information.

I can remove them, but want to know your opinion

@Djjus Some bugs I found:

Tiring + Impact don't show additional dmg (Impact alone works, Tiring + Damaging works too)
Suffuse With Ulgu and Beneath Notice are not on the Talents list
My Psychology tab doesn't work (and I don't know why :D)
2xEncumbrance Penalty broke again (I'm pretty sure it is breaking when you have exact 30 Agility, and set and unset penalties multiple times)

Maybe It needs one day to fully process all changes, but it's quite weird because my interface changes are in live.

@Djjus how hard would be to add more custom skills to minor NPCs. For example with 'add' and 'modify' buttons like talents?

Hey do you mean this specifically..

A few static ones could be added, that's not a big deal I think.
But repeating field inside repeating field will not work sadly.

OR drop down select is a alternative too

Probably we have a little bug in Fast Shot. SL are not calculated properly: 9 + 1 = 9

Do the checkbox in the equipment list have any meaning? I suppose it should lower the encumbrance by one, but it's not working like that.

In Inventory no, it removes the item from the Calc if unticked. This is since the original sheet still.
Armor will be -1 if worn is ticked. I think weapons have no mod right now.

How hard would be to implement this?

i'm not sure it make sense, items in inventory are not worn. so dont gain -1

at the moment..

OR do we say everything in Inventory is Carried, and we change the checkbox to Worn?

quite a small change..

I got confused with this issue. I think the best solution would be 2 checkboxes, one for carried (it is practical to write sth that is temporarily not on you) and second for worn (sturdy boots, robes, clothing, ropes can be worn) like with containers.

It would be also good if we can do weapon length integration (similarly to size integration) to automatically add -10 to attack with the shorter weapons.

Additionally, I found a bug. If you roll 100 the label will say "Automatic Failure" only, but 100 is also Fumble because it's double 0 on dices

I have removed the Carried? for now, one thing i have noticed is player tend to list too much in Inventory. then suddenly say oh i have this and has been carrying it around for ages, but with no Enc. Should be fine, if you se no actual value in Enc its still has no weight.
Auto Fail/Fumble at 100 should be addressed.
Weapon reach, I have thought about it many time, it is too fiddly in my view, you would need to set it every time you attack. We did play test it, but didnt like it. At the moment it shows it in the roll output what reach you have, GM can then adjust as he see's fit.

like maybe VsReach > / = /<

Another bug: 'Worn?' option for containers is broken.

No its intended to be on/off Enc. According to CRB Page 301, the Enc for containers is as shown, i suppose that means they are not modified.

Containers are carried, not worn. i dont think i will change the page spelling, Worn fit in the space lol.

Sling Bag and Backback can be worn. CRB 301.

Hmm, your PR was merged but it seems like the changes didn't apply. Weird.

Yes, its odd because the master seem updated, but they are not merging into live website. I think its our Double PRs, yours did not make the master. and then mine did not make the webpage. I will repost with yours included.

Maybe we should merge our changes in one fork and then go with only one PR to Roll20:master.

I think we will have too, let take our convo to Discord:
Justi#7934

No never seen this issue. I suspect its our double PRs for some reasonGet Outlook for Android


Refactor duplicated filters code

The task was completed as described here: #387
In addition this task hooked tests. All affected tests have been rewritten and verified. All affected test cases  were succesefly runed. Test results have not changed.
Attached TagService tests result to prof the above.

@Hardelele please resolve conflicts.


integration: Fix ha_salvage_test

longhorn/longhorn#1236
Signed-off-by: Shuo Wu<EMAIL_ADDRESS>

https://ci.longhorn.io/job/private/job/longhorn-tests-regression/198/


Missing runtime ID for ARM 64 bit

I can install dotnet runtime 2.1 on Fedora ARM 64bit. What is the RID of that?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 009616d0-6c93-a2de-82fe-4f7168817f18
Version Independent ID: 4c2c5549-0151-516d-91d0-9b017c74e787
Content: .NET Core Runtime IDentifier (RID) catalog
Content Source: docs/core/rid-catalog.md
Product: dotnet-core
GitHub Login: @mairaw
Microsoft Alias: mairaw

Hello. The value you want is fedora-arm64 and you can see a full list of RIDs in the source repo for Core 3.0: https://github.com/dotnet/corefx/blob/master/pkg/Microsoft.NETCore.Platforms/runtime.json#L309
However, it's not listed in the 2.1 branch: https://github.com/dotnet/corefx/blob/release/2.1/pkg/Microsoft.NETCore.Platforms/runtime.json#L642
So it may or may not work. You should upgrade to 3.0 😄


Traces don't contain the test name

The traces created by the pytest plug don't add the test/node name to the trace:

Is this returning an empty string? name=slugify(request.node.nodeid),

Thanks for reporting the bug. I created https://github.com/microsoft/playwright-pytest/pull/157 with a fix for it.


TargetServerVersion

Hello,
Is there any option to choose the Target Server Version please ?
Thanks

I developped my reports on VS 2017.
When deploying reports via VS, in Project -> Propeties, I change TargetServerVersion to 2014, to deploy on SQL Server 2014.
In VSTS extension, I don't know if there is an option to do this.
Regards.

Ok, thanks 👍


Where is the code?

Your paper says:

Model code available at: https://github.com/vqdang/xy_net

Well, where is it?  One would expect this delay from amateurs, not from senior IEEE members. Next time, please hold the release of your paper until the code is fully available as is promised!

Thank you for your comment. The paper will have full code on the repo within a week. We have delayed the upload of the code to ensure things are written clearly for others to use. We will inform you when the code is ready.
Thank you for your patience


ROX-21129: Add cluster init bundles wizard step 2

Description

Add reusable content components for Operator or Helm chart installation method.

InitBundleWizardStep2 renders either/or depending on selection in wizard step 1.
SecureClusterPage renders either/or via tabs. Add secure-a-cluster route for this page.

Rename Install cluster button as Secure a cluster wording from Cloud Sources mocks of clusters page.

Replace View instructions link with Init bundle installation methods link to Secure a cluster with an init bundle page.
Replace New cluster with Legacy installation method.

Residue
After we merge this, move forward in parallel:

Add content of the 2 components to focus the attention of reviewers:

Kerry: clear wording and consistency with docs.
Mansur: usability and visual design.
Simon: correct and complete for the context.

Rename AddClusterPrompt component and add content for no clusters and conditional rendering:

no init bundles: Create bundle as call to action.
init bundles after return from wizard: Review instructions link to open Secure a cluster with an init bundle page in a new tab.
That is, primary tab is still /main/clusters so user sees change from no clusters state to ordinary clusters list as soon as there is a secured clusters.

Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~

Testing Performed
Before you yarn deploy in ui folder:
export ROX_MOVE_INIT_BUNDLES_UI=true

yarn lint in ui/apps/platform
yarn build in ui/apps/platform
yarn start in ui

Manual testing

Visit /main/clusters, and then click Secure a cluster: see 2 links (residue investigate inconsistent style).

Click Init bundle installation methods: see /main/clusters/secure-a-cluster page with placeholder content for Operator.

Click Helm chart tab: see placeholder content for Helm chart.

Click Clusters breadcrumb link, click Manage init bundles, and then click Create bundle: see wizard step 1.

Enter a name, and then click Next: see step 2 with placeholder content for Operator.

Click Back, select GKE, and then click Next: see step 2 with placeholder content for Helm chart.

ocp-ui-e2e-tests failures are unrelated to these changes although deserve investigation
/test ocp-4-14-ui-e2e-tests


Remove quantile scale alert

I actually already did this in https://github.com/SatcherInstitute/health-equity-tracker/pull/706:
Could you let me do it in my PR so I don't have to deal with merge conflicts? Thanks!

I actually already did this in #706:
Could you let me do it in my PR so I don't have to deal with merge conflicts? Thanks!
Also issue #655 includes: "xx.x% of cases reported unknown {demographic}. The charts below display data for cases where {demographic} was known. View map of where unknown values are being reported" which I addressed in my PR so this PR doesn't close that issue anyways.
I think it would be best if we don't try to address issues others have already claimed without discussing it first- I think that could lead to a lot of confusion.

Ah, I didn't see your PR. Re: the actual text though, the latest decision here was to not add the message (per discussion in the disclaimers doc / the latest comment in the issue) and instead just remove this quantile scale alert. Happy to close this one if you want to handle the removal of the message in your PR

Ah gotcha na it's okay you just do this one i'll close mine


DRAFT Firmware updates

This is an initial draft describing the high-level concept of firmware updates covering drogue-device and drogue-cloud. Before extending this proposal with the specific APIs (any help with that would be appreciated) and functionality of drouge-device, I'd like us to reach concensus on the high level design.
Readable version: https://github.com/drogue-iot/rfcs/blob/feature/firmware-updates/active/0006-firmware-updates.md

Awesome @lulf ! Reading it felt like the early stages of my PhD :)
If I understand correctly the bootloader here act as a "static" part, a bit like the UEFI firmware on a PC motherboard.
The tricky question is: how do you update the bootloader ? If I keep the computer analogy it can be updated from code running in the memory. But in the case of a remote IoT device it is hard to recover if something goes wrong.

If I understand correctly the bootloader here act as a "static" part, a bit like the UEFI firmware on a PC motherboard.
The tricky question is: how do you update the bootloader ? If I keep the computer analogy it can be updated from code running in the memory. But in the case of a remote IoT device it is hard to recover if something goes wrong.

@jbtrystram That is a good point. My initial opinion is that we don't support updating the bootloader without physical access to begin with. During development of the bootloader (or re-use some existing available), we might figure out how complex it is and if we think we are going to need that functionality and plan for it. I don't think you can get around with a minimal amount of code that must always work (a boot-bootloader if you will) unless there is hardware support for having multiple alternating entry points or something. So the tradeoff is how complex the bootloader vs. flash usage.
My initial thought is that the bootloader should only have the ability to load one out of two firmwares, a way to write flash, and switch between the two versions of the firmware.

If my memory serves corectly one solution was to have double the space needed for the bootloader so you could write the new bootloader aside to the old one then verify it so and after all have been checked you could erase the old one. Using double the flash space is a big compromise though.

In the initial proposal, I am suggesting we use half of the space of the firmware itself, in order to be able to load an earlier version of the firmware and switch between them. This is to avoid the bootloader needing network support in order to flash an older version of the firmware.
The argument for not having network capabilities in the bootloader is that we don't really know the network capabilities of the devices we are going to support (it could be one out of many different drivers). It also reduces the chance that we need to update the bootloader itself.
So, the implication here is that firmware size < flash size /2.
I have updated the bootloader detail section with some ideas.

Thanks for expanding on that, I think the assumptions you make are reasonable. To me limiting the firmware to half the flash space feels like a huge limitation but i too don't have enough experience to back it up.
I thought that the bootloader would have the network capabilities, but now i understand better. I am all for the smallest amount of bootloader code as possible.

An alternative approach that could save some flash would be to optionally bundle the bootloader with the minimal code to do networking: actor framework and a selected network driver configured at build time + DFU actor. In theory, that should consume less flash space than the full application. However, that 'minimal code' would need to be updateable.


Failed to load plugin

OS: macOS Monterey 12.1
Insomnia Version: 2021.7.2
Node Version: 17.1.0
Failed to load plugin insomnia-plugin-valorant
Stack Trace:
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at validateString (internal/validators.js:120:11)
    at Object.join (path.js:1039:7)
    at Object.<anonymous> (/Users/ahlw/Library/Application Support/Insomnia/plugins/insomnia-plugin-valorant/src/info-providers/LocalInfoProvider.js:13:27)
    at Object.<anonymous> (/Users/ahlw/Library/Application Support/Insomnia/plugins/insomnia-plugin-valorant/src/info-providers/LocalInfoProvider.js:368:3)
    at Module._compile (internal/modules/cjs/loader.js:1152:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1173:10)
    at Module.load (internal/modules/cjs/loader.js:992:32)
    at Module._load (internal/modules/cjs/loader.js:885:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12738)
    at Module.require (internal/modules/cjs/loader.js:1032:19)

Thanks for the detailed report. This plugin was designed to work only on Windows because it uses the lockfile and local api of Valorant. However, I definitely should add a more descriptive error message and look into making the non-local-Valorant-dependent functionality (token refreshing for example) work cross-platform.


Strict negated predicate matchers

Negated Predicate Matchers should be strict.
I just realized that negated predicate matchers are not strict, i.e. expect(something).not_to be_foo will pass if foo? returns nil. We have a bunch of these mistakes in rubocop and in rubocop-ast.
I believe it should fail. To be correct, methods ending with ? should typically not return nil. It's quite easy to return nil without wanting to. It's also easy to not realize a method if returning nil (e.g. if x.foo?), but sometimes the nil and false might be treated differently (often without meaning too) and subtle bugs can be introduced.
It may be advisable for compatibility's sake to put that under a flag. I believe that flag should default to strict although that may have to wait for a major version (if ever?).
Note that the only other choice given to rspec user is quite ugly, in particular:
# currently not strict enough version
it_is_expected.not_to be_foo
# correct version
expect(subject.foo?).to be false

Your environment

rspec-expectations version: 3.13.3

Can you double check you've turned on the existing strict predicate check?
e.g RSpec::Expectations.configuration.strict_predicate_matchers = false

I have such a bad memory 🤦♂
https://github.com/rspec/rspec-expectations/issues/1102


Uncaught TypeError: Cannot read property 'start' of null

[Enter steps to reproduce below:]

Open a file which does not end with a newline. This happened in .java, .js, and a handlebars template file (.tpl).
Try skipping to end of file with alt+} (forward paragraph)

Atom Version: 0.187.0
System: Mac OS X 10.9.5
Thrown From: atomic-emacs package, v0.4.0
Stack Trace
Uncaught TypeError: Cannot read property 'start' of null
At /Users/____/.atom/packages/atomic-emacs/lib/atomic-emacs.coffee:224

TypeError: Cannot read property 'start' of null
  at AtomicEmacs.forwardParagraph (/Users/____/.atom/packages/atomic-emacs/lib/atomic-emacs.coffee:224:58)
  at atom-text-editor.<anonymous> (/Users/____/.atom/packages/atomic-emacs/lib/atomic-emacs.coffee:53:83)
  at atom-text-editor.handler (/Users/____/Downloads/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:115:32)
  at atom-text-editor.jQuery.event.dispatch (/Users/____/Downloads/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at atom-text-editor.elemData.handle (/Users/____/Downloads/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Users/____/Downloads/Atom.app/Contents/Resources/app/src/command-registry.js:246:29)
  at /Users/____/Downloads/Atom.app/Contents/Resources/app/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Users/____/Downloads/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:558:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Users/____/Downloads/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:396:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Users/____/Downloads/Atom.app/Contents/Resources/app/src/window-event-handler.js:182:20)

Commands
  7x -0:50.7 atomic-emacs:next-line (atom-text-editor.editor.is-focused)
  3x -0:48.6 atomic-emacs:forward-paragraph (atom-text-editor.editor.is-focused)
  2x -0:47.2 atomic-emacs:backward-paragraph (atom-text-editor.editor.is-focused)
  2x -0:46.0 atomic-emacs:forward-paragraph (atom-text-editor.editor.is-focused)
     -0:30.3 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -0:30.3 snippets:expand (atom-text-editor.editor.is-focused)
     -0:30.3 editor:indent (atom-text-editor.editor.is-focused)
     -0:24.9 editor:newline (atom-text-editor.editor.is-focused)
  5x -0:21.0 atomic-emacs:forward-paragraph (atom-text-editor.editor.is-focused)
  6x -0:17.4 atomic-emacs:backward-paragraph (atom-text-editor.editor.is-focused)
     -0:15.0 editor:newline (atom-text-editor.editor.is-focused)
  3x -0:14.4 atomic-emacs:backward-paragraph (atom-text-editor.editor.is-focused)
  6x -0:13.6 atomic-emacs:forward-paragraph (atom-text-editor.editor.is-focused)
     -0:11.3 core:backspace (atom-text-editor.editor.is-focused)
     -0:10.7 atomic-emacs:backward-paragraph (atom-text-editor.editor.is-focused)
  2x -0:10.3 atomic-emacs:forward-paragraph (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages
# User
atom-handlebars, v0.4.0
atomic-emacs, v0.4.0
linter, v0.12.0
linter-javac, v0.1.3
minimap, v4.5.0

# Dev
No dev packages

Confirmed -- thanks for reporting!


fix typo in readme

It's hard to see in the diff. Look for "compose to grammars" and "compose two grammars"

Derp; thanks!

you're welcome! once i found one typo i looked really hard for more but couldn't find any. it's a real, real nice readme btw


Dropped OS X 10.8 -> drop Growl?

According to the To Do, in Beta 21 only 10.9 and later will be supported. That means that Notification Center will always be there.
Meanwhile, Growl seems to have died; they don't even mention 10.10 and there is no blog activity since 2013.
So, is there a plan to drop Growl, or at least disable compilation of the parts that depend on it? It would (slightly) simplify the process to get into Pester development.
I could try it myself, but I am not familiar with Xcode and Cocoa, so I don't know how should I go about it. Xcode build target? some config.h? some -D compilation flag and #ifdef'ing? ... any example to look at?

On Tue, Sep 29, 2015 at 12:54:51AM -0700, Horacio Mijail Antón Quiles wrote:

According to the To Do, in Beta 21 only 10.9 and later will be
supported. That means that Notification Center will always be there.
Meanwhile, Growl seems to have died; they don't even mention 10.10
and there is no blog activity since 2013.
So, is there a plan to drop Growl, or at least disable compilation
of the parts that depend on it? It would (slightly) simplify the
process to get into Pester development.

Short answer: no.
Long answer: download http://growl.cachefly.net/Growl-2.0.1-SDK.zip;
there are instructions in the README on where to put Growl.framework
prior to compilation (note that you want the old version, 1.2.3).  I
should probably link to this from the README as well.
Growl development is not dead, it's just very slow thanks to the
people working on it having other jobs.  I'd love to drop it, but
unfortunately OS X notifications still don't have features I need.
Displaying my own notifications and not using Growl would be one
option, but it's a very low priority at the moment.
--Nicholas

I've updated the README to make it clearer how to get the version of the Growl framework that Pester needs.  This should be enough for now.


docs(operators): add documentation for every

Closes #74

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   90.78%   90.78%
=======================================
  Files         116      116
  Lines         445      445
  Branches        9        9
=======================================
  Hits          404      404
  Misses         40       40
  Partials        1        1

Impacted Files
Coverage Δ

src/operator-docs/conditional/every.ts
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4097607...2959804. Read the comment docs.


create an error message for multiple participants when only one is allowed

at this time, using ZoomOSC 4.1.2 (2<IP_ADDRESS>.37) and Companion Build 5640 for Mac on Apple Silicone, having multiple Panelists selected and pressing "Pin" sends the command:
/zoom/zoomID/pin 16794624
… which is the zoomID of the second panelist selected. As pin is meant as single-panelist command, if multiple are provided, would it be possible to indicate error?
If using custom command to send multiple IDs, it responds in Log with "Error: message not handled"
Source Zoom Chad Lafarce

clafarge

at this time, using ZoomOSC 4.1.2 (2<IP_ADDRESS>.37) and Companion Build 5640 for Mac on Apple Silicone, having multiple Panelists selected and pressing "Pin" sends the command: /zoom/zoomID/pin 16794624 … which is the zoomID of the second panelist selected. As pin is meant as single-panelist command, if multiple are provided, would it be possible to indicate error?
If using custom command to send multiple IDs, it responds in Log with "Error: message not handled"
Source Zoom Chad Lafarce

Jeffrey, when you state "As pin is meant as a single-panelist" is this statement clarifying what the command is designed to do, or that Zoom Pinning is designed a single, per user event? Zoom Pinning does support multi-pinning, up to 9 local pins. Just checking for clarity. Thanks

Hi @ZoomTestKitchen the source of the text is from Chad (tester @ Zoom). I've just put it on Github because I need to keep track. That being said If I remember correctly the Pin command is for a single user and the addPin is for multiple. That is also how I programmed it in Companion. @AndrewCarluccio is this correct?

@JeffreyDavidsz you are correct


120 characters max allowed

Hey, I just made a Pull Request!

Backstage will able to load apps with names no longer than 120 characters

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Why 120? :grin:

You probably shouldn't change this in the main project, but rather in your private app.

@Rugvip Because there are some apps that are written with that amount of characters, because

Afaik 63 is taken from https://datatracker.ietf.org/doc/html/rfc1123, so the next logical step is prolly 255. Although as freben mentioned this is something you can configure in your own local deployment with a custom validator


NameError: name 'selective_scan_fn' is not defined

我在安装代码环境的时候遇到这个问题。请问有人遇到过相同的问题吗？
self.selective_scan = selective_scan_fn
NameError: name 'selective_scan_fn' is not defined
我已经导入了这个包，
try:
from mamba_ssm.ops.selective_scan_interface import selective_scan_fn as selective_scan_fn
except:
pass
以及，我通过ctrl+左键点进去查看，mamba_ssm中的确存在这个函数
def selective_scan_fn(u, delta, A, B, C, D=None, z=None, delta_bias=None, delta_softplus=False,
return_last_state=False):
"""if return_last_state is True, returns (out, last_state)
last_state has shape (batch, dim, dstate). Note that the gradient of the last state is
not considered in the backward pass.
"""
return SelectiveScanFn.apply(u, delta, A, B, C, D, z, delta_bias, delta_softplus, return_last_state)

直接使用 pip 安装  selective_scan  就行了，不需要按照 visino mamba 的教程 一步步来，vmunet 那个库也提供了，离线版本的

看下vmunet的issue

hello, I have problem in install the mamba_ssm and selective_scan library. The error message is as following:
Looking in indexes: https://mirrors.aliyun.com/pypi/simple/
Collecting mamba_ssm==1.0.1
Downloading https://mirrors.aliyun.com/pypi/packages/c5/05/61d5d28786f41c7d3cc671a232b9f73e24c82fd23e8317da2b2ed36a5c73/mamba_ssm-1.0.1.tar.gz (28 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [11 lines of output]
Traceback (most recent call last):
File "", line 36, in
File "", line 34, in
File "/tmp/pip-install-ulqs93q8/mamba-ssm_06e7369a1d7946418d613f523b32af4c/setup.py", line 103, in
f"{PACKAGE_NAME} is only supported on CUDA 11.6 and above.  "
RuntimeError: mamba_ssm is only supported on CUDA 11.6 and above.  Note: make sure nvcc has a supported version by running nvcc -V.
  torch.__version__  = 1.13.1

  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
I just want to konw how to deal with the problem. Thank you for your time and help.

我在安装代码环境的时候遇到这个问题。请问有人遇到过相同的问题吗？ self.selective_scan = selective_scan_fn NameError: name 'selective_scan_fn' is not defined
我已经导入了这个包， try: from mamba_ssm.ops.selective_scan_interface import selective_scan_fn as selective_scan_fn except: pass
以及，我通过ctrl+左键点进去查看，mamba_ssm中的确存在这个函数 def selective_scan_fn(u, delta, A, B, C, D=None, z=None, delta_bias=None, delta_softplus=False, return_last_state=False): """if return_last_state is True, returns (out, last_state) last_state has shape (batch, dim, dstate). Note that the gradient of the last state is not considered in the backward pass. """ return SelectiveScanFn.apply(u, delta, A, B, C, D, z, delta_bias, delta_softplus, return_last_state)

想问下您解决了这个问题吗，如果解决了可以分享是如何解决的吗


[WIP] feat: Modify the API of NCCL to fit the single GPU gpt without NCCL/MPI

Hi~ @byshiue
I am curious to know if this feature is now supported?


Add seq. discrete+seq. compact=>finite

I numbered the theorem as T203, which is the first unused number after T188 (discrete+compact=>finite). I hope this would work :)

Using previously unused theorem numbers is usually fine.

Good change.  This allows to derive that 5 more spaces are not sequentially discrete.
How about changing the order of the properties in the hypotheses: [seq compact + seq discrete ==> finite], as Seq compact seems the more important property of the two?
Also, we can now remove the redundant trait files for Seq discrete for S141.

Good change. This allows to derive that 5 more spaces are not sequentially discrete.
How about changing the order of the properties in the hypotheses: [seq compact + seq discrete ==> finite], as Seq compact seems the more important property of the two?
Also, we can now remove the redundant trait files for Seq discrete for S141.

OK, will remove the redundant file later.
My only question is that T188 is discrete+compact => finite. Would you be OK with keeping the order of this one?

That brings up a good point.  It seems that with the new theorem, T188 [discrete + compact ==> finite] would become redundant, i.e., can be derived from the new result.  Should we replace T188?
@StevenClontz opinion?

In general I don't have strong opinions on the order of properties in a theorem.
But as for T188 - it's not clear to me how proposed T203 would deprecate it, but I'm probably overlooking something simple.

I'll make the change and then we can see it better and discuss.

Replaced T188 with the @Jianing-Song 's new result and it turns out the old T188 was already redundant before.  The derivation does not make use of the new result:
https://topology.pi-base.org/spaces?q=Compact%2BDiscrete%2B~Finite

Ah-ha: https://topology.pi-base.org/theorems/T000397 is a sharper result, gotcha.

And on the other hand, the new result cannot be derived from T397.
Is this good to go then?

I've removed P167 for S141.


Next steps

Hi,
So we have a good selection of serializers, migrated to StackExchange and good test coverage.
What do you suggest are the next steps?
I would personally love to be able to use Protobuf without having to manually decorate every cached object so I'm going to try to see if using reflection to setup the serialization is worth it.
I guess there is still a bit of cleaning-up/refactoring we can do but as it is, it's working well in tests on my applications.
After that I guess it would be great if someone jumped in to make a small GitHub page to showcase the  library and how to use it.
Except for NCache (which is commercial), there aren't many .NET caching libraries that support tags so there's that.

Sweet!

I'll be decoupling my Autoprotobuf library from my Protobuf serializer to make it cleaner, purely optional and interchangeable.

I'll be adding Async methods to RedisCacheItemProvider.

NCache went open source last week. I'll compare performances with TagCache to see how they match up.

Thanks, that would be interesting to see. From their docs, I'm not sure if tagging is supported in the open source version : http://www.alachisoft.com/ncache/edition-comparison.html

You are right. From your link it seems that tagging and other features are not supported in their open sourced version.


Invariant violation not found on simple 2 step owner transfer test

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (ec3f9bd 2023-09-19T13:48:52.205431000Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Intel)
Describe the bug
take the following src contract:
contract Owned {
    address public owner;
    address private ownerCandidate;

    constructor() {
        owner = msg.sender;
    }

    modifier onlyOwner() {
        require(msg.sender == owner);
        _;
    }

    modifier onlyOwnerCandidate() {
        require(msg.sender == ownerCandidate);
        _;
    }

   function transferOwnership(address candidate) external onlyOwner {
        ownerCandidate = candidate;
    }

    function acceptOwnership() external onlyOwnerCandidate {
        owner = ownerCandidate;
    }
}

and the following test:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.15;
import "forge-std/Test.sol";

contract Handler is Test {
    Owned owned;

    constructor(Owned _owned) {
        owned = _owned;
    }

    function transferOwnership(address sender, address candidate) external {
        vm.assume(sender != address(0));
        vm.prank(sender);
        owned.transferOwnership(candidate);
    }

    function acceptOwnership(address sender) external {
        vm.assume(sender != address(0));
        vm.prank(sender);
        owned.acceptOwnership();
    }
}

contract TwoStepOwnershipTestFoundry is Test {
    address owner;
    Owned owned;
    Handler handler;

    function setUp() public {
        owner = address(this);
        owned = new Owned();

        handler = new Handler(owned);
        targetContract(address(handler));

        bytes4[] memory selectors = new bytes4[](2);
        selectors[0] = Handler.transferOwnership.selector;
        selectors[1] = Handler.acceptOwnership.selector;
        targetSelector(FuzzSelector(address(handler), selectors));
    }

    function test_successful_transfer(address newOwner) public {
        handler.transferOwnership(owner, newOwner);
        handler.acceptOwnership(newOwner);

        assertEq(owned.owner(), newOwner);
    }

    function invariant_owner_never_changes_this_is_bad_lol() public returns(bool cond) {
        cond = (owned.owner() == owner);
        assertEq(owned.owner(), owner);
    }
}

There is no trick here, this is a kind of sanity check for invariant testing. Note the test_successful_transfer test, all that is needed to violate the invariant is to chain these two call:
        // must pass the current owner as the first arg
        handler.transferOwnership(owner, newOwner);

        // must pass the same newOwner as in the previous call
        handler.acceptOwnership(newOwner);

However:

running forge test --mc TwoStepOwnershipTest yields no violation
same thing with 10k fuzz runs
tried with 100k fuzz runs but I ended up killing forge after 20 min

cc @horsefacts who helped investigate (https://twitter.com/eth_call/status/1704304001292914782)
cc @mds1 who asked for the issue

Wonder if we're now able to catch this with https://github.com/foundry-rs/foundry/pull/6530 cc @brockelmore

Nope the shrinking change is only relevant post-finding a counterexample

fails right way here with fail_on_revert set to true, @karmacoma-eth can you confirm you run with this option on?

@grandizzy I run with fail_on_revert = false
failing on revert doesn't make sense for this invariant test, I am trying to see if benchmark can successfully find the sequence of 2 calls that actually transfer ownership.
It is expected that most runs will revert (because of the onlyOwner and onlyOwnerCandidate modifiers

@karmacoma-eth got it, thanks, that makes sense. I assume you tweaked invariant depth and dictionary_weight too?

I did not, I run it with defaults

gotcha, I should have some time this week to try more variations and debug, there's also the the targetSender function that can be used to narrow down addresses participating in scenario, not sure though if you want to do this in your invariant test?

managed to make some tests, pls see https://github.com/foundry-rs/foundry/pull/7240

@karmacoma-eth this is now merged, pls retest by setting the number of random addresses to recycle (in addition to known state addresses as handlers) e.g.
[invariant]
max_calldata_fuzz_dictionary_addresses=100

If not specified or set to 0 then current behavior is applied, (unbounded number of fuzzed addresses)

in latest builds this is caught with default settings but run depth increased and default settings (max_calldata_fuzz_dictionary_addresses setting was removed), e.g. with a depth of 500
[FAIL. Reason: assertion failed]
        [Sequence]
                sender=0x2C03070E8B998F0177C5B9A64342862a2EECbb98 addr=[test/Owned.t.sol:Handler]0x2e234DAe75C793f67A35089C9d99245E1C58470b calldata=transferOwnership(address,address) args=[0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496, 0x000000000000000000000000000000006d435422]
                sender=0x422ec71B1b9c4b35c6b9AcB44773F962078dbe8D addr=[test/Owned.t.sol:Handler]0x2e234DAe75C793f67A35089C9d99245E1C58470b calldata=acceptOwnership(address) args=[0x000000000000000000000000000000006d435422]
 invariant_owner_never_changes_this_is_bad() (runs: 256, calls: 127959, reverts: 127939)
Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 19.14s (19.11s CPU time)

Ran 1 test suite in 19.14s (19.14s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

I think this one can be closed, @mds1 wdyt?

From my testing, trying to flesh out depth vs. runs relationship a bit:

Default fuzz settings do not catch it, regardless of number of runs (I only tried up to 10k runs)
Setting depth=500 catches it consistently with the default number of runs (256)
Setting depth=500 with  runs=100 occasionally catches it
Setting depth=10000 with runs=1 occasionally catches it, but seems to be a bit less often than prior bullet

So:

I think we can close this as it's now catchable with the proper config
But we probably need a higher default depth than 15, as the depth seems very import, and should reconsider our default invariant config

Agree, we should revisit all defaults and update them to more relevant values, like

depth to 500 (For example echidna uses a default seqLen: 100 and testLimit: 50000 which is like 500 runs with depth of 100 in foundry terms)
shrink_run_limit defaults now to 2^18 which is not realistic anymore with our new shrinking mechanism (echidna uses shrinkLimit: 5000).
maybe default senders to 3 known addresses as echidna does with 0x1, 0x2, 0x3 addresses
others

Awesome, created https://github.com/foundry-rs/foundry/issues/7848 to track and will close this one


How to lock cavity with Q factor 100 to lock to stabilised He-Ne laser using pyrpl GUI

I am new to using PYRPL program. I could get GUI using standalone binary exe file in windows and i could connect to red pitaya.
I am able to drive scanning confocal FP interferometer. Now i want to lock at the side of the fringe using lock box or PID.
Please suggest.

I think you can find the answer to your question in the docs and in this video:
https://youtu.be/WnFkz1adhgs?si=CMAXr8JlIVD_mkh4


bible-sqlite t_wbt has only 54 books (missing 12 books)

The Protestant Bible has 66 books, but bible-sqlite.db is missing a dozen books, including 2 Samuel, Romans, 1 Corinthians etc., from table t_wbt (the Webster Revision of KJV). 12 books from the Old and New Testament are missing from Webster's Revision.

This is fixed in #36.

@thesnarky1  thank you. Updated.


Error - Unsupported item key.

I added template and userparams into zabbix-agent config.
In web interface an error that keys are unsupported, but from zabbix-server host:
zabbix_get -s host -k gpu.free   returns current count of free memory.
zabbix_agentd (daemon) (Zabbix) 3.2.6  Ubuntu 16.04    (all cheks works by hands and throu zabbix_get)
zabbix_server (Zabbix) 3.2.6 ( Centos 7.3)

Is there anything in the Zabbix agent logs? or any additional information regarding the error?
Looking around on forums regarding similar errors indicates some kind of synchronisation issue:

https://zabbix.com/forum/showthread.php?p=186939
https://github.com/lorf/zapache/issues/2
https://zabbix.com/forum/showthread.php?p=186939

My hostname and dns name are match in DNS server, zabbix and on the host. It is a hardware, not virtual host. In log the same discription of the error as in zabbix_web interface:
21482:20170718:162403.067 item "miner.yksys.pro:gpu.fanspeed" became not supported: Unsupported item key.
21482:20170718:162404.072 item "miner.yksys.pro:gpu.free" became not supported: Unsupported item key.
21483:20170718:162405.074 item "miner.yksys.pro:gpu.memtotal" became not supported: Unsupported item key.
21482:20170718:162406.075 item "miner.yksys.pro:gpu.power" became not supported: Unsupported item key.
21482:20170718:162407.078 item "miner.yksys.pro:gpu.temp" became not supported: Unsupported item key.
21484:20170718:162408.083 item "miner.yksys.pro:gpu.used" became not supported: Unsupported item key.
21482:20170718:162409.084 item "miner.yksys.pro:gpu.utilisation" became not supported: Unsupported item key.

There are several things that you might be able to try:

A first basic test would be to see if the nvidia-smi command itself works. i.e.

nvidia-smi --query-gpu=fan.speed --format=csv,noheader,nounits -i 0
For some cards that are passively cooled it will report "[Not Supported]".

Restarting both the agents and the main server might also help as per: https://www.zabbix.com/forum/showthread.php?t=52083

If you move your mouse over the red cross in the "Info" column, you should have the reason why your
items are unsupported.

Looking around it might be that the polling rate is too high, and that the command is having difficulty responding in a timely fashion: https://sourceforge.net/p/zabbix/mailman/message/34913783/. Looking at code changes in https://github.com/ejimz/Elasticsearch-zabbix/issues/10, they seem to introduce caching to get over similar issues, though in your case slowing the polling rate down might help.

In another example if the data isn't been sent by the agent for a short while this might also happen: https://github.com/jitlogic/zorka/issues/174. I/O bottlenecking in https://github.com/zbx-sadman/unifi_miner/issues/4 seems to have caused these sort of issues as well.

In https://serverfault.com/questions/761645/zabbix-issue-with-lld-lots-of-became-supported-became-not-supported they seem to switch in the template between 'Agent (active)' to 'Zabbix Trapper' in order to aid with the timing issues.

修改item类型为：Zabbix agent (active)即可。
Zabbix agent (active)

change item type to Zabbix agent (active) is OK.


Chip delete button tap target does not meet platform recommended tap target size

Reopening #42455 Chip delete button tap target is too small.
Steps to Reproduce

Add androidTapTargetGuideline test case to packages/flutter/test/material/chip_test.dart. See code below.  testWidgets('delete button tap target complies with minimum tap target guideline', (WidgetTester tester) async {
    final SemanticsHandle handle = tester.ensureSemantics();
    final UniqueKey deleteKey = UniqueKey();
    await tester.pumpWidget(
      _wrapForChip(
        child: Column(
          children: <Widget>[
            Chip(
              label: const Text('Label'),
              deleteIcon: Icon(Icons.delete, key: deleteKey),
              onDeleted: () { },
            ),
          ],
        ),
      ),
    );

    await expectLater(tester, meetsGuideline(androidTapTargetGuideline));

    handle.dispose();
  });

Execute cd packages/flutter and flutter test flutter/test/material/chip_test.dart

Expected results:

All tests pass

Actual results:

delete button tap target complies with minimum tap target guideline [E] fails withExpected: Tappable objects should be at least Size(48.0, 48.0)
Actual: <Instance of 'WidgetTester'>
Which: SemanticsNode#5(Rect.fromLTRB(90.0, 12.0, 114.0, 36.0), actions: [tap], flags: [isButton,
isFocusable], label: "Delete", textDirection: ltr): expected tap target size of at least Size(48.0,
48.0), but found Size(24.0, 24.0)
        See also: https://support.google.com/accessibility/android/answer/7101858?hl=en

Flutter Doctor

[✓] Flutter (Channel unknown, 2.6.0-12.0.pre.805, on Debian GNU/Linux rodete 5.10.46-5rodete1-amd64, locale en_US.utf8)
    • Flutter version 2.6.0-12.0.pre.805 at /usr/local/google/home/abalov/flutter
    • Upstream repository unknown
    • Framework revision aee9ade8e3 (60 minutes ago), 2021-11-23 04:03:03 -0500
    • Engine revision f4cb61cefc
    • Dart version 2.16.0 (build 2.16.0-36.0.dev)
    • DevTools version 2.8.0

Any updates?

I was looking to fix this today but looks like the tappable area is matching native. It is equally small on native Android


Edited Strapi description to better describe Strapi

Clarified various parts of Strapi and added a few points explaining what Strapi does as a headless CMS. Added a link to the Getting Started Docs to make it easier for users to find.

@erquhart - Please let me know if anything is needed on this?

Looks great, sorry for the delay! Also, hats off to you and the team for your incredible work on Strapi, looks to be growing fast!!

Looks great, sorry for the delay! Also, hats off to you and the team for your incredible work on Strapi, looks to be growing fast!!

Thank you Shawn.  I am a big fan of Netlify also... We just uploaded another with Netlify front and center!

Nice! Let me know if you have a link I can share with the team 👍👍


projectCard hover and mob navbar fixes

No need of hover effect on mobile.

Added active link effect

Mobile

Desktop (Underline separates the active link from hovered link)

Project Card hover animation and icons back to normal. Search working again too

https://user-images.githubusercontent.com/75680424/209480175-ca51fb38-c05a-47fd-91a6-5f44f2a012e0.mp4

Minor changes to Page title.

Lgtm


Fix core auth

Fix regression introduced in #10653
The type ignore was necessary to avoid that:

_authentication.py:93: error: Item "None" of "Optional[AccessToken]" has no attribute "token"

In this particular case, we could 1) type ignore, 2) use a cast 3) add an (unnecessary) check for None in the if to allow mypy to be certain it's not None.
I don't like type ignore since we lose all benefits of typing.
Cast is better, but has the problem of disabling mypy and telling it "shut up we know the type", which may or may not be a problem if we refactor the code at some point.
The if is more explicit (and thus more zen) and has the advantage to be robust to refactoring, since mypy will complain again if those lines are touched
Being the name of the property _need_new_token, checking None doesn't seem stretched to me (even if I understand the property also check it)

Merging, for some reasons ADO didn't sent the event to Github, but everything's green


Review Ticket 4

Happy Life Vid Notes
If/Else Lesson Plan

Score: 2.7
I give Prisha a 2.7. I think we all had issues with the backend this week, specifically with unexpected errors in AWS. So we focused on the lesson plan this week.


Failed assertion: line 5334 pos 14: '_dependents.isEmpty': is not true

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
I don't know how to fix this issu please help me

Hi @saga009. Kindly provide more details on how to reproduce this.
More specifically, please provide the information indicated below:

A completed and minimal reproducible code sample
The output of flutter doctor -v
Reproduction steps

Thank you!


Bookstack frontend is redirected to old domain name after updated URL

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
I've updated my local domain name and now, when I try to access Bookstack frontend, it redirects me to the old domain name.

Old name: bookstack.old
New name: bookstack.new

The host is set to the new name.
$ hostname -f
bookstack.new

The Apache config is already set to the new name.
/etc/apache2/sites-available/bookstack.conf
<VirtualHost *:80>
  ServerName bookstack.new
  ServerAdmin webmaster@localhost
  DocumentRoot /var/www/bookstack/public/
  <Directory /var/www/bookstack/public/>
      Options -Indexes +FollowSymLinks
      AllowOverride None
      Require all granted
      <IfModule mod_rewrite.c>
          <IfModule mod_negotiation.c>
              Options -MultiViews -Indexes
          </IfModule>

          RewriteEngine On

          # Handle Authorization Header
          RewriteCond %{HTTP:Authorization} .
          RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

          # Redirect Trailing Slashes If Not A Folder...
          RewriteCond %{REQUEST_FILENAME} !-d
          RewriteCond %{REQUEST_URI} (.+)/$
          RewriteRule ^ %1 [L,R=301]

          # Handle Front Controller...
          RewriteCond %{REQUEST_FILENAME} !-d
          RewriteCond %{REQUEST_FILENAME} !-f
          RewriteRule ^ index.php [L]
      </IfModule>
  </Directory>
  ErrorLog ${APACHE_LOG_DIR}/error.log
  CustomLog ${APACHE_LOG_DIR}/access.log combined
</VirtualHost>

Bookstack seems to be up to date.
From https://github.com/BookStackApp/BookStack
 * branch              release    -> FETCH_HEAD
Already up to date.
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Continue as root/super user [yes]? yes
> @php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');"
Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   INFO  Discovering packages.

  barryvdh/laravel-dompdf ..................................................................................................................... DONE
  barryvdh/laravel-snappy ..................................................................................................................... DONE
  intervention/image .......................................................................................................................... DONE
  laravel/socialite ........................................................................................................................... DONE
  laravel/tinker .............................................................................................................................. DONE
  nesbot/carbon ............................................................................................................................... DONE
  nunomaduro/termwind ......................................................................................................................... DONE
  socialiteproviders/manager .................................................................................................................. DONE

63 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> @php artisan cache:clear

   INFO  Application cache cleared successfully.

> @php artisan view:clear

   INFO  Compiled views cleared successfully.

                                                                                APPLICATION IN PRODUCTION.

  Do you really wish to run this command? (yes/no) [no]
yes

   INFO  Nothing to migrate.

   INFO  Application cache cleared successfully.

   INFO  Configuration cache cleared successfully.

   INFO  Compiled views cleared successfully.

I've also tried to update the URL path.
@bookstack:/var/www/bookstack$ php artisan bookstack:update-url http://bookstack.old http://bookstack.new

 This will search for "http://bookstack.old" in your database and replace it with  "http://bookstack.new".
Are you sure you want to proceed? (yes/no) [no]:
 > yes

 This operation could cause issues if used incorrectly. Have you made a backup of your existing database? (yes/no) [no]:
 > yes

Updated 0 rows in attachments->path
Updated 10 rows in pages->html
Updated 0 rows in pages->text
Updated 0 rows in pages->markdown
Updated 0 rows in chapters->description_html
Updated 0 rows in books->description_html
Updated 0 rows in bookshelves->description_html
Updated 39 rows in images->url
Updated 0 rows in settings->value
Updated 0 rows in comments->html
Updated 0 rows in comments->text
Updated 0 JSON encoded rows in settings->value
URL update procedure complete.
============================================================================
Be sure to run "php artisan cache:clear" to clear any old URLs in the cache.
============================================================================

@bookstack:/var/www/bookstack$ php artisan cache:clear
   INFO  Application cache cleared successfully.

However, when I try to access its frontend, it keeps redirecting me to the old domain name.
$ curl http://<IP_ADDRESS>
<!DOCTYPE html>

        <meta charset="UTF-8" />
        <meta http-equiv="refresh" content="0;url='http://bookstack.old/login'" />

        <title>Redirecting to http://bookstack.old/login</title>

        Redirecting to http://bookstack.old/login.

/var/log/apache2/access.log
<IP_ADDRESS> - - [13/Apr/2024:11:43:18 -0300] "GET / HTTP/1.1" 302 1905 "-" "curl/7.81.0"

With all this, I'm unable to access Bookstack.
Only if I add an entry to my DNS for the old domain name can I access it.
I just can't see what the problem is. Any thoughts on this matter?
Thanks.
Exact BookStack Version
24
Log Content
I could not find any errors on Apache logs, nor Lavarel logs.
# After restarts
@bookstack:~$ tail /var/www/bookstack/storage/logs/laravel.log
#13 /var/www/bookstack/app/Exceptions/Handler.php(66): Illuminate\\Foundation\\Exceptions\\Handler->render()
#14 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(233): BookStack\\Exceptions\\Handler->render()
#15 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(210): Illuminate\\Foundation\\Bootstrap\\HandleExceptions->renderHttpResponse()
#16 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(270): Illuminate\\Foundation\\Bootstrap\\HandleExceptions->handleException()
#17 [internal function]: Illuminate\\Foundation\\Bootstrap\\HandleExceptions->Illuminate\\Foundation\\Bootstrap\\{closure}()
#18 {main}
  thrown at /var/www/bookstack/storage/framework/views/58966642253d57ffe4f154d44ae65835f6011243.php:68)
[stacktrace]
#0 {main}
"}

# Apache restarts only
@bookstack:~$ sudo tail /var/log/apache2/error.log
[Sat Apr 13 12:13:14.155953 2024] [mpm_prefork:notice] [pid 477] AH00170: caught SIGWINCH, shutting down gracefully
[Sat Apr 13 12:13:14.217377 2024] [mpm_prefork:notice] [pid 751] AH00163: Apache/2.4.52 (Ubuntu) OpenSSL/3.0.2 configured -- resuming normal operations
[Sat Apr 13 12:13:14.217403 2024] [core:notice] [pid 751] AH00094: Command line: '/usr/sbin/apache2'

# Redirects only
@bookstack:~$ sudo tail /var/log/apache2/access.log
<IP_ADDRESS> - - [13/Apr/2024:11:58:37 -0300] "GET / HTTP/1.1" 302 1961 "-" "axios/1.6.7"
<IP_ADDRESS> - - [13/Apr/2024:11:58:41 -0300] "GET / HTTP/1.1" 302 1961 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0"
<IP_ADDRESS> - - [13/Apr/2024:11:58:54 -0300] "GET / HTTP/1.1" 302 1961 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0"
<IP_ADDRESS> - - [13/Apr/2024:11:58:59 -0300] "GET / HTTP/1.1" 302 1905 "-" "curl/8.0.1"
<IP_ADDRESS> - - [13/Apr/2024:12:03:52 -0300] "GET / HTTP/1.1" 302 1961 "-" "axios/1.6.7"
<IP_ADDRESS> - - [13/Apr/2024:12:03:55 -0300] "GET / HTTP/1.1" 302 1961 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0"
<IP_ADDRESS> - - [13/Apr/2024:12:04:02 -0300] "GET / HTTP/1.1" 302 1905 "-" "curl/7.81.0"
<IP_ADDRESS> - - [13/Apr/2024:12:07:24 -0300] "GET / HTTP/1.1" 302 1961 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0"
<IP_ADDRESS> - - [13/Apr/2024:12:13:19 -0300] "GET / HTTP/1.1" 302 1961 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0"
<IP_ADDRESS> - - [13/Apr/2024:12:13:30 -0300] "GET / HTTP/1.1" 302 1905 "-" "curl/8.0.1"

Hosting Environment

Ubuntu 22.04
MySQL 8.0.36
Apache/2.4.52
PHP 8.1.2

Hi @diasdmhub,
In the /var/www/bookstack/.env file update the APP_URL variable.

Oh... That was it.
After updating APP_URL, Bookstack now opens properly.
Thanks a lot.


Tooling cleanup

remove ranges from package.json
npm scripts adds executables form the node_modules folder in $PATH automatically so you can just reference the executable only without the path
fix .stylelintrc indentation
cleanup ESLint errors in webpack/ folder

Problem coming from phantomjs
Would you mind updating our phantomjs package?

@mmahalwy That's not phamtomjs problem it's a node-sass issue. Updated it.
Also, updated how Jenkins pickup the right node version since it was using node 5

jenkins does use 6.3 (it uses the same configuration as the Dockerfile).
complaint from Jenkins is:
><EMAIL_ADDRESS>build:client /quran
> node webpack --config webpack/prod.config.js

module.js:442
    throw err;
    ^

Error: Cannot find module '/quran/webpack'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

Thanks for posting this because I can't see the errors myself, will have a look at this tomorrow.

Deployed to: http://staging.quran.com:32839

Deployed to: http://staging.quran.com:32840

Deployed to: http://staging.quran.com:32841

Looks good to me. let me know if this is ready to be merged.

Deployed to: http://staging.quran.com:32845

@sabeurthabti It's ok form my side too, but to be sure I will just do one last check today afternoon.

Deployed to: http://staging.quran.com:32846

@sabeurthabti You can merge this now. I'll follow up with a new PR to do more cleanup, but for now this is good to go 👍

lgtm

Thank you @ahmedelgabri

Thanks @ahmedelgabri !


BUG: scipy/_lib/_numpy_compat: get_randint

Fix for problem mentioned in #9486. The low and high values might be chosen in some cases out of the integer type range. This is fixed.

Yes, the test should work for 32-bit arch when NumPy < 1.11. I removed the test skip.

There is one failure:
=================================== FAILURES ===================================
______ build/testenv/site-packages/scipy/signal/tests/test_signaltools.py ______
[gw1] linux -- Python 3.5.3 /usr/local/bin/pypy3
Worker 'gw1' crashed while running 'build/testenv/site-packages/scipy/signal/tests/test_signaltools.py::TestFFTConvolve::test_random_data_multidim_axes[axes5]'

I think this is unrelated to this PR.

I think this is unrelated to this PR.

yep, failure is unrelated.

Thanks for merging.


JDO Exception: Identifier unresolved(Not a static fields)

Hi,
I am using JDO API 3 with google app engine.
I am using
javax.jdo.PersistenceManager,
javax.jdo.Query,
javax.jdo.Transaction
for queries.
SO basically i am doing relational mapping in my JDO entity. My JDO entity is like
@PersistenceCapable
public class MyEntity {

@PrimaryKey
@Persistent(valueStrategy = IdGeneratorStrategy.IDENTITY)
private Long id;

@Persistent
private String name;

@Persistent
private Boolean isCheck;

@Persistent(mappedBy = "myEntity",defaultFetchGroup="true")
@Element(dependent="true")
private Set<MyObject> myObject;

//Getters and setters of attributes
}

So when i tried to get my entity by Id it will give exception message like
Exception message : Identifier isCheck is unresolved (not a static field).
But this exception is inconsistent.
Also whenever  I tried to access list of object first time from new session using JDO it gives Exception message : Found Meta-Data for class com.MyEntity  but this class is not enhanced!! Please enhance the class before running DataNucleus. So once i refresh page it will return results.
I am fetching this issue since last 7-8 months please help me with this.

Closing this issue


Add maintemplateplugin tests

What kind of change does this PR introduce?

Add tests for two MainTemplate plugins
Did you add tests for your changes?

This PR is only tests
If relevant, link to documentation update:

N/A
Summary

Based on the coveralls report, the AmdMainTemplatePlugin file has 14% test coverage.
https://coveralls.io/builds/9568353/source?filename=lib%2FAmdMainTemplatePlugin.js
Based on the coveralls report, the JsonpExportMainTemplatePlugin file has 23% test coverage.
https://coveralls.io/builds/9568353/source?filename=lib%2FJsonpExportMainTemplatePlugin.js
There are no AmdMainTemplatePlugin or JsonpExportMainTemplatePlugin specific test files - these are added in this PR and aim to achieve 100% test coverage.
Does this PR introduce a breaking change?

No
Other information
A TemplatePluginEnvironment helper file has been added (similar to, and making use of, PluginEnvironment) to help with testing event handlers.

Wonderful work. Thank you so much👏🏼.


Issue 7

Issue-7

[x] Add feature of img instead of button
[x] Improve img adding dynamic loading with next/image
[x] Add usePathname to get the pathname and be able to get the current route

Fix the height and weight and merge conflicts.

Fix the height and weight and merge conflicts.

Please align the images to centre as well
It's not aligned properly

Tips for future PR 💡: Please add a screenshot of the result if applicable so that it helps while reviewing the changes

I can not upload a photo right now but i've fixed the error


add interactive filtering to bulk download

Description
allow users to filter and add/ remove data from returned filtering results
Issue
ch154101
Test plan
tested locally and in rdev: https://bulk-download-w-filtering-frontend.dev.genepi.czi.technology/data/samples

I took a brief read through and I both understand what you are trying to do (from a product standpoint), and what you're trying to do from a code standpoint.  I'm going to pull the branch now and play with it a little bit, and see if that generates any insight for me.
I'll follow up with another comment soon!

@mmmmmmaya i reorganized things a little so that this makes more sense. I moved checkbox callback functions and header state props to the datatable view, and am now passing in checkedSamples, setCheckedSamples, failedSamples, and setFailedSamples as props into data_table, Unfortunately cannot move those into data_table since the download modal also needs access to those props. Hopefully this makes more sense now, otherwise i can change it back to how it was.


JSDoc:positional matching of destructured params

When looking up tags for a parameter whose name is a binding pattern, use the index of the parameter to get the type.
When reporting errors for @param tags with no matching parameter name, do not report the error for tags whose index in the @param tag list matches the index of a parameter whose name is a binding pattern.

Fixes #19645
This is a small-ish change while we figure out how to make #18832 not hurt performance in the common case of Typescript code or non-destructuring parameters.

Perf tests show everything about the same except Angular binding, which is slower. There's no change in the binder for this PR, so it makes me think the results for Angular when testing #18832 are not valid either.


Player

[x] Movement
[x] Jumping
[x] Running
[x] Attacking
[ ] Health

Player created. Can move and jump. Can Attack. Attack System still in work.

Player now Implements IDamageable.
Player now Impliments IDamagable

Death Logic and Animation added.


Calculations?

Any idea when calculations will be supported (at least in "passthrough" mode)? I would like to open a "template", fill it with values and store it. Currently, this ends up in a corrupted Excel, when I just open the file and store it as a new file.
Cheers
Friedemann
BTW: I am willing to donate but as a one time donation.

@schwenkreis
I'll be looking into calculations and it will be released once the master becomes stable.
I have a day-job to do, I spent week-ends on open source. So, this might take some more time.
~ Best
~ Kawaljeet SIngh
~ Long Live 🔥pen Source


Step 8 : FriendlyMessage class has 4 arguments

FriendlyMesssage constructor has 4 arguments rather than 3 as mentioned in Step 8 (Send Messages)
 FriendlyMessage(mMessageEditText.getText().toString(),
                               mUsername,
                               mPhotoUrl);

I think the last argument should be LOADING_IMAGE_URL
that is what is used in the onActivityResult method

Add in your FriendlyMessage Class a new constructor. This will suport the new variable imageUrl.
 public FriendlyMessage(String text, String name, String photoUrl, String imageUrl) {
        this.text = text;
        this.name = name;
        this.photoUrl = photoUrl;
        this.imageUrl = imageUrl;
    }

Updated to use the correct constructor, thanks for catching this.


fix: adding-image-height-attribute-precedence

This pr helps to set height attribute precedence

Codecov Report

Merging #592 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   94.87%   94.98%   +0.11%
==========================================
  Files          69       70       +1
  Lines        1170     1197      +27
==========================================
+ Hits         1110     1137      +27
  Misses         60       60

Impacted Files
Coverage Δ

packages/core/src/Image.js
100% <100%> (ø)
:arrow_up:

packages/core/src/Select.js
100% <0%> (ø)
:arrow_up:

packages/core/src/utils.js
100% <0%> (ø)
:arrow_up:

packages/core/src/PlaceholderImage.js
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8438a...d4a41a9. Read the comment docs.


Crash: viewer.ohif.org can't be launched

Just tried the viewer http://viewer.ohif.org/, but it crashed - please check:
Errors prevented startup:

While selecting package versions:
error: No version of mrt:moment satisfies all constraints: @2.15.1
Constraints on package "mrt:moment":
*<EMAIL_ADDRESS><- top level

Your application has errors. Waiting for file change.

Try running meteor npm install inside the app you're trying to run (e.g., OHIFViewer or LesionTracker folder) and let's see how that goes.

It's fixed - there was a temporary issue with the VM hosting the code.


Feature Request: Allow to pin the keyboard so it's open all the time if needed

Hello,
Could you please add an option where you can pin the native iOS keyboard to be open all the time if needed, so if you touch the screen in another area it won't hide the keyboard?
This is useful as sometimes when you type something it shows you auto complete or auto correct words that you need to press on them on the screen which causes the native iOS keyboard to disappear.
Instead it should let the native iOS keyboard continue to show in case I need to continue to type and occasionally interact with the screen (pressing auto complete/auto correct words, etc) if that make sense. Otherwise I need to keep re-opening the keyboard every time I touch the screen which is not convenient and makes it not very productive when trying to use the native iOS keyboard when lots of typing needed is needed.
Thank you.

Hello @wsvn53
As discussed, let me explain the justification for this feature:
I tried to use the remote soft keyboard of Android, but It's too slow and prone to errors to try to type on the target Android soft keyboard that’s on the target screen rather than sending the keystrokes from the client connecting iOS side native soft keyboard. It’s especially true if you are facing a less stable connection. So typing in the native iOS soft keyboard is much better, more efficient and less prone to errors since sending keystrokes from local keyboard has less latency than relying on passing touch screen strokes on a screen that could be lagged because of the connection.
Other remote desktop apps to android including TeamViewer allow this without any problem.
Here is a case study how it looks in TeamViewer in the two attached screenshots, I’ll explain each figure marked in the screenshots:

For example, I typed “Hel” which could be either incomplete word or incorrect word.
Auto correct/Auto complete is offering to press the “Hello” word.
A keyboard icon exists in the app menu that allows you to open the native ios keyboard.
Once the keyboard is open, you can still press on the suggested “Hello” word on the screen, without the keyboard closing (in scrcpy-ios) the keyboard automatically closes as soon as I press the “Hello” word.
There is a button that allows you to close the keyboard when you are done using it.
This is not the best example how to do it as the extra line on top of the native ios keyboard is blocking some of the suggested words for auto complete/correct so better allow to pin the keyboard ahead of time or in a different menu so it doesn’t interfere to block the screen auto complete/correct words.

I hope you will consider this and I was able to convince you.
Please let me know if you have any questions.
Thank you.

Ok, maybe I understand what you want, but this may change the current navigation bar structure, I need to consider its rationality.

Ok, maybe I understand what you want, but this may change the current navigation bar structure, I need to consider its rationality.

Thank you, this could be a great help. If you don't want to change the navigation bar structure, maybe it can be a secret url scheme that you pass? i.e. scrcpy2://<IP_ADDRESS>:36605?stay-awake=true&pin-keyboard=true
Or something like that.
Thanks.

Ok, maybe I understand what you want, but this may change the current navigation bar structure, I need to consider its rationality.

@wsvn53 Let me know if you need my help testing it in test flight.
Thanks.


Compile issue

I'm trying to compile the example with rustc 1.0.0-nightly (d8be84eb4 2015-03-29) (built 2015-03-29) and I get so many errors it would be embarrassing to show :)

I guess what I mean is: should it be working with rust 1.0.0?

2015-03-29? That was some time ago. You can go back to a previous commit and hope there will be a compatible one, but your best bet would be to go with the latest nightly or beta.

:+1:

just updated my rust version.
Still getting compiler error (only on cookie).
Compiling cookie v0.1.18 /Users/mfirry/.cargo/registry/src/github.com-1ecc6299db9ec823/cookie-0.1.18/src/lib.rs:56:20: 56:39 error: unresolved name url::percent_decode /Users/mfirry/.cargo/registry/src/github.com-1ecc6299db9ec823/cookie-0.1.18/src/lib.rs:56         let name = url::percent_decode(name.as_bytes());

That would be an issue with the cookie library. Seems like the beta is the most promising option at the moment, unless a patch comes soon.

Ok. Should I explicitly depend on the beta version then?

I bumped into this myself with an other project and it seems like they decided to remove that function from the url library, so things are simply broken for now, unless you override the dependencies somehow (I think you can edit your Cargo.lock and use the previous version). Seems like we have to wait while things caches up.

Thanks!

Things should build with the beta now. Remember to run cargo update to get the latest libraries.

Working now. Thanks!


Where's the realistic mode?

Tittle

Mutators are now an official feature, so GoonMod mutators have been removed. Closing all issues relating to mutators.


Date Search Bug in Grid v1.4 + (Git Master as well)

The bug is found when searching date fields with the 'between' selector. I've tried configuring w2ui with various date formats as well as loading different date formats, but at no time does it select anything. Other selectors such as 'is', 'after, and 'before' appear to work correctly with my data.
I have tested that empty column data is not the source of the problem, and they are properly formatted.
Field configuration snippet --- type: 'date', size: '30%', sortable: true, resizable: true , format: 'yyyy/mm/dd'},
Search includes the same type and format information.
I have noted that the search box uses a different format of m/d/yyyy , however I would hope that it is able to convert dates to a general format for comparison. (I do notice that it won't sort according to the date value, but the format's alpha-numeric precedence).
Thanks!

The best way to work with dates is representing it in unix time (or timestamp). Then it is a number of milliseconds since 1970. Once you returned data as such, you can defined render: "date" or specify your own render function and then all is peachy. Search fields will work well with it too. Please see if this helps and close this issue.

Closing issue: no response


behavior change for footnotes

I was upgrading some remark dependencies for markdown-to-jsx and came across an unexpected behavior change: the caret is now being preserved in footnotes.
Previously this markdown:
foo[^abc] bar

[^abc]: Baz baz

Would strip out the caret when making the footnote link. However now it seems to be preserved in the output.

Hi Evan! :wave:
Passing options to .parse (and .stringify, .process) no longer work (https://github.com/unifiedjs/unified/issues/24).
Based on this example and current setup in markdown-to-jsx, the following diff highlights the changes needed to make it work with<EMAIL_ADDRESS> var unified = require('unified');
 var parser = require('remark-parse');

 var markdown = `foo[^abc] bar

 [^abc]: Baz baz
 `;

 var options = {
   footnotes: true,
   gfm: true,
   position: false,
 }

 var tree = unified()
-  .use(parser, options)
+  .data('settings', options)
+  .use(parser)
   .parse(markdown);

 console.dir(tree, {depth: null});

Thanks!