Bug: Workflow fails to build

Current Behaviour

When you change the control nodes and attach a Loadbalancer in a config, the workflow fails on setting up the loadbalancers when trying to execute the change api endpoints ansible playbook as the new control node just completed the terraformer stage so these components are not installed yet (until the KUBE-ELEVEN stage which won't be reached).
Expected Behaviour

I would expect to skip setting up the loadbalancers in the first stage of the processing and then set them up in the second stage.
Steps To Reproduce

apply a very basic config

kubernetes:
  clusters:
    - name: matus-ts3
      version: v1.22.0
      network: <IP_ADDRESS>/24
      pools:
        control:
          - hetzner-control
        compute:
          - hetzner-compute

change the control node and attach a LB

kubernetes:
  clusters:
    - name: test
      version: v1.22.0
      network: <IP_ADDRESS>/24
      pools:
        control:
          - gcp-control
        compute:
          - hetzner-compute
loadBalancers:
  roles:
    - name: apiserver-lb
      protocol: tcp
      port: 6443
      targetPort: 6443
      target: k8sControlPlane
  clusters:
    - name: test-lb
      roles:
        - apiserver-lb
      dns:
        dnsZone: claudie.dev
        provider: cloudflare-1
      targetedK8s: test
      pools:
        - gcp-lb

the wofklow fails in ANSIBLE stage when setting up the load balancers

I have encountered kinda similar error. So to reproduce:

Create a cluster with a LB Cluster
Update manifest with removing the LB at all

I'm getting an ansibler error on step Changing API Endpoint
2:41PM INF services/ansibler/server/server.go:154 > Loadbalancers for cluster test-cluster project cloudziu were successfully set up module=ansibler
2:44PM INF services/ansibler/server/loadbalancers.go:340 > Changing the API endpoint for the cluster test-cluster module=ansibler
2:44PM INF services/ansibler/server/loadbalancers.go:401 > New endpoint is <IP_ADDRESS> module=ansibler
EP - test-cluster
EP - test-cluster	 PLAY [control] *****************************************************************
EP - test-cluster
EP - test-cluster	 TASK [Gathering Facts] *********************************************************
EP - test-cluster	 ok: [m-hetzner-dc1-1]
EP - test-cluster
EP - test-cluster	 TASK [stop kubelet] ************************************************************
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=kubelet)
EP - test-cluster
EP - test-cluster	 TASK [remove old apiserver.crt, apiserver.key] *********************************
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=/etc/kubernetes/pki/apiserver.crt)
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=/etc/kubernetes/pki/apiserver.key)
EP - test-cluster
EP - test-cluster	 TASK [find file that contains the hostname] ************************************
EP - test-cluster	 ok: [m-hetzner-dc1-1]
EP - test-cluster
EP - test-cluster	 TASK [fail if no file was found] ***********************************************
EP - test-cluster	 skipping: [m-hetzner-dc1-1]
EP - test-cluster
EP - test-cluster	 TASK [replace endpoint] ********************************************************
EP - test-cluster	 ok: [m-hetzner-dc1-1]
EP - test-cluster
EP - test-cluster	 TASK [generate new certs] ******************************************************
EP - test-cluster	 changed: [m-hetzner-dc1-1]
EP - test-cluster
EP - test-cluster	 TASK [remove old /etc/kubernetes/*.conf] ***************************************
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=/etc/kubernetes/admin.conf)
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=/etc/kubernetes/controller-manager.conf)
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=/etc/kubernetes/kubelet.conf)
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=/etc/kubernetes/scheduler.conf)
EP - test-cluster
EP - test-cluster	 TASK [generate kubeconfig] *****************************************************
EP - test-cluster	 changed: [m-hetzner-dc1-1]
EP - test-cluster
EP - test-cluster	 TASK [restart kubelet] *********************************************************
EP - test-cluster	 FAILED - RETRYING: [m-hetzner-dc1-1]: restart kubelet (5 retries left).
EP - test-cluster	 changed: [m-hetzner-dc1-1] => (item=kubelet)
EP - test-cluster
EP - test-cluster	 TASK [upload config map] *******************************************************
EP - test-cluster	 fatal: [m-hetzner-dc1-1]: FAILED! => {"changed": true, "cmd": "kubeadm init phase upload-config all --config /root/kubeone/cfg/master_0.yaml", "delta": "0:00:50.114195", "end": "2023-03-02 13:46:15.269920", "msg": "non-zero return code", "rc": 1, "start": "2023-03-02 13:45:25.155725", "stderr": "W0302 13:45:25.230506   26062 utils.go:69] The recommended value for \"clusterDNS\" in \"KubeletConfiguration\" is: [<IP_ADDRESS>]; the provided value is: [<IP_ADDRESS>]\nerror execution phase upload-config/kubeadm: error uploading the kubeadm ClusterConfiguration: Post \"https://k1g8p52xb77fc394j.test.cloudziu.com:6443/api/v1/namespaces/kube-system/configmaps?timeout=10s\": dial tcp: lookup k1g8p52xb77fc394j.test.cloudziu.com on <IP_ADDRESS>:53: no such host\nTo see the stack trace of this error execute with --v=5 or higher", "stderr_lines": ["W0302 13:45:25.230506   26062 utils.go:69] The recommended value for \"clusterDNS\" in \"KubeletConfiguration\" is: [<IP_ADDRESS>]; the provided value is: [<IP_ADDRESS>]", "error execution phase upload-config/kubeadm: error uploading the kubeadm ClusterConfiguration: Post \"https://k1g8p52xb77fc394j.test.cloudziu.com:6443/api/v1/namespaces/kube-system/configmaps?timeout=10s\": dial tcp: lookup k1g8p52xb77fc394j.test.cloudziu.com on <IP_ADDRESS>:53: no such host", "To see the stack trace of this error execute with --v=5 or higher"], "stdout": "[config] WARNING: Ignored YAML document with GroupVersionKind kubeadm.k8s.io/v1beta3, Kind=JoinConfiguration\n[upload-config] Storing the configuration used in ConfigMap \"kubeadm-config\" in the \"kube-system\" Namespace", "stdout_lines": ["[config] WARNING: Ignored YAML document with GroupVersionKind kubeadm.k8s.io/v1beta3, Kind=JoinConfiguration", "[upload-config] Storing the configuration used in ConfigMap \"kubeadm-config\" in the \"kube-system\" Namespace"]}
EP - test-cluster
EP - test-cluster	 PLAY RECAP *********************************************************************
EP - test-cluster	 m-hetzner-dc1-1            : ok=9    changed=6    unreachable=0    failed=1    skipped=1    rescued=0    ignored=0
EP - test-cluster
2:46PM WRN services/ansibler/server/ansible/ansible.go:40 > Error encountered while executing ansible-playbook ../../ansible-playbooks/apiEndpointChange.yml -i inventory.ini -f 30 --extra-vars "NewEndpoint=<IP_ADDRESS> OldEndpoint=22kg6nrlyni5boyqy.test.cloudziu.com" from services/ansibler/server/clusters/test-cluster-yxzb4br-lbs : exit status 2 module=ansibler
2:46PM INF internal/command/cmd.go:56 > Next retry in 10s... module=ansibler

Had similar issues when I try to decrease the number of nodes in LB cluster.


hide image on front end

please hide https://search.creativecommons.org/photos/8fe608bc-23ea-4791-ac0e-13bab4bf5347

Hi @janeatcc ,
I would like to work on it, but I have 2 questions;

Why do we need to hide such an image?
Should we really do it manually via the Front End or it should be done via API?

I'm not sure -- I'll defer to the team on whether it is done via API or front end.
Thank you for the offer @elharony but this one is best for CC staff! :)

No problem, @janeatcc. Hope we get it fixed soon! 🙏

I think the API should filter this image from its results.


fix: Fixed the issue of Contact Us links in footer and header section

Title and Issue number

Title :  'Contact Us' Link Issues in Footer and Header section!
Issue No. : #850
Close #850

Description

I have added following things:
The "Contact Us" link in the footer section of Package page is now navigating to the appropriate section on the home Page.
The "Contact Us" link in the header and footer on the feedback page is now navigating to the correct section on the home page.
Additionally, the phone number and email address in the footer of Package page are now clickable links that open the default email client and calling app, respectively.
Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[x] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have gone through the  contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

GSSoC'24

[x] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

@Samridhi002 good changes

Thank you!😊 @apu52


[feat] Add download button on node tab to download node json

I can try to build this

Pull request: https://github.com/zwave-js/zwavejs2mqtt/pull/76

mistake :)


Move logic of adding Hound to an repo

Extract the logic out of the GithubApi into a service. GithubApi should
only be a wrapper over Octokit methods and not handle complex logic.
This allows us to test that logic easier in isolation without stubbing
external requests.

LGTM


formBuilder {value: ..., disabled: ...) does not work with slide-toggle

the capability or reactiveforms to disable control seems not to work with slide-toggle, requiring the use of [disable]

Please use the provided issue template, otherwise your issue will get closed.

Bug, feature request, or proposal:
Bug
What is the expected behavior?
should use reactive forms behavior
What is the current behavior?
does not
What are the steps to reproduce?
implement a slide toggle and try use {value:..., disabled: ...}
Providing a Plunker (or similar) is the best way to get the team to see your issue. Plunker template: https://goo.gl/DlHd6U
not necessary
What is the use-case or motivation for changing an existing behavior?
consistent forms control usage
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
latest across the board
Is there anything else we should know?
nope

@zpydee can you please provide a plunker to explain what you mean? Here is one showing what seems to be correct form control & disable behavior:
https://plnkr.co/edit/kUTJH16hHz6C0UFP035J?p=preview

Closing this issue as it does not follow the issue template (actually providing the information). Please file a new issue that follows the template, which gives the team the information needed to investigate.

sorry, no time. just trying to alert you. i believe this error message from the forms module should explain the issue sufficiently.
the method proposed for first field does not work with the slide-toggle, thus my need to using [disabled] in my template.
It looks like you're using the disabled attribute with a reactive form directive. If you set disabled to true
      when you set up this control in your component class, the disabled attribute will actually be set in the DOM for
      you. We recommend using this approach to avoid 'changed after checked' errors.

      Example:
      form = new FormGroup({
        first: new FormControl({value: 'Nancy', disabled: true}, Validators.required),
        last: new FormControl('Drew', Validators.required)
      });

https://plnkr.co/edit/efuNdLhq9QM3YOcH98qj?p=preview


Fix build: strncasecmp is declared in strings.h

Signed-off-by: Thiago Macieira<EMAIL_ADDRESS>

+1


Update supported distributions list

Add 6.4 back now that LIS4 issues have been resolved
Add latest Ubuntu 15.04 release
Update link to LIS4 drivers using an fwlink

Hi @szarkos, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (szark). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Fixed #31691 -- Added ordering support to JSONBAgg.

Pretty simple fix. Uses the OrderableAggMixin to add the ordering argument to JSONBAgg.
The tests are modified from the ArrayAgg ordering tests.
Ticket is here: https://code.djangoproject.com/ticket/31691
Let me know if you need changes.

@charettes Updated the PR with the requested changes.

@john-parton Thanks :+1: Welcome aboard :boat:
I pushed minor edits.


Asynchronous Data Loop on last page

I have a issue where i request last page 4,056 items in 100 items per page on the last page 46 if clicked the page will show additional pages  47 48 49 ....  when clicking any of these pages 47 48 49 it will take you back to page 1.
How do I stop this from happening?

Hi,
can you show me the relevant code, or event better make a demo on plunker showing the issue?

Closing. Please re-open if this is still an issue.


Rewrite tests in test_generic to pytest-style

TestBase from falcon.testing is now deprecated. We should rewrite the tests to pytest style in order to make graceful more future-proof and all tests more consistent.

Cannot do it now because we would have to loose compatibility with older versions of falcon. Need to decide for how long we will support 0.3 and 1.0 versions.


feat(GHA): add GHA to comment on fix commits to develop

I realized that we in some cases don't follow our best-pratice to do fixes for camunda-modeler on master rather than on develop

example: https://github.com/camunda/camunda-modeler/pull/2893

This GHA is meant to support us with this, by notifying us via a comment:

:+1: Would be awesome if we could test this in more places (diagram-js, bpmn-js, dmn-js), too.

It works: https://github.com/camunda/camunda-modeler/pull/2947 ;)

We don't check whether the comment has been already added and it hurts us when we push multiple times: https://github.com/camunda/camunda-modeler/pull/2947#issuecomment-1121023467

Haha. At least the second time the comment happens we shouldbe more kind.

Just a little reminder...

Or

Don't want to be anoying, ...

Or

Did you consider my previosu remark?

Or

:thinking:

:rofl:

I will follow-up. This worked on my private repo :-S

@MaxTru https://github.com/camunda/camunda-modeler/pull/2948


Non-static method should not be called statically

Non-static method PragmaRX\Tracker\Tracker::pageViewsByCountry() should not be called statically
 use PragmaRX\Tracker\Tracker;
 public function index(){
        $pageViews = Tracker::pageViewsByCountry(60 * 24);
        dd(Tracker::pageViewsByCountry(60 * 24));
    }

use PragmaRX\Tracker\Vendor\Laravel\Facade as Tracker;


SPN-5252 Unwrap org.infinispan.registry.ScopedKey to make log message be...

...tter
https://issues.jboss.org/browse/ISPN-5252

I don't think this is the right approach, we should add a toString() method to ScopedKey instead.

Implemented ScopedKey#toString() as suggested.

Integrated, thanks a lot!


For true non-membership, verify_proof returns false instead of true

in smt, to prove non-membership of a key without matching_entry, should I expect the verify function to return false or true?
https://github.com/privacy-scaling-explorations/zk-kit.rust/blob/8d63b9fb17e8bfdceb99d50b9f92538188fd266d/crates/smt/src/smt.rs#L363
As an example, let's start with a tree with [0101,'a'], [0111,'b']. assuming hash is concatenation, and we want to proof 1111, create_proof gives:
MerkleProof {
entry_response: EntryResponse {
entry: vec![Node::Str("1111".to_string())],
matching_entry: None,
siblings: vec![Node::Str("0101,a,1,0111,b,1".to_string())],
},
root: Node::Str("0101,a,1,0111,b,1".to_string()),
membership: false,
}
Now verify_proof, would use zero node to produce a root Node::Str("0101,a,1,0111,b,1,0".to_string()), so verify_proof returns false.
My understanding is we should expect true, since the MerkleProof says membership is false

cc @waddaboo

@waddaboo could you add a comment here? So that I can assign this task to you.

Not sure if it's still required but here's a comment :)

@waddaboo yes, thank you so much for the PR 🙏🏽


Socket stuff styles

Principle change is the style guide applied to socketstuff. Looks pretty good now.
Unfortunately when you do a compare there are a lot of files touched for no apparent reason. Blank lines are added and then removed and it appears as a change. Could our different editors be doing funky things with hidden characters and EOL markers? I use notepad++ and happy to change some setting if that's what is happening.
Anyway, if at least one of you can look at sockets and see if I've done the style thing right.

Unfortunately when you do a compare there are a lot of files touched for no apparent reason. Blank lines are added and then removed and it appears as a change. Could our different editors be doing funky things with hidden characters and EOL markers? I use notepad++ and happy to change some setting if that's what is happening.

Seems to an issue with notepad++ then. vscode does take care of whitespaces automatically on my end.

Looks like notepad++ is inserting tabs/spaces on new lines. Perhaps there is an option to trim trailing spaces?
I also use vscode (on linux) and it trims it for me.

Seems to be an option: https://superuser.com/questions/699382/how-do-i-automatically-trim-trailing-whitespace-with-notepad

Just fixing up the merge conflict I had created with my luachecks. all good now.

Branch is updated. Thanks for all the reviews.  :)


SIFT .ova 490GB

Why is the Sift .ova VM takin up 490GB on my hard drive?

Did you tell it to provision all the space ahead of time?

Just imported it into VMWare Workstation. No changes were made.

As far as I know the only reason for this is if the option to pre-provision all the space ahead of time is enabled, which it's not on the OVA the last time I checked.


The system is alwasy dissplaying WHO =IV

Actual Results
Independently on the stage that the patient is, the system displays the calculated  stage as IV
Expected results
The system must display the calculated stage according to the symptoms that the patient has in each stage
Steps to reproduce
Login to POC-> Select the registration module-> search for a patient-> Check in the patient-> Go to clinical module-> select the consultation tab-> click on add WHO stage.
Screenshot/Attachment (Optional)

 Not updating WHO steges


[DPG] Access to important response headers

Currently autorest generated methods only allow access to the response headers via either:

Passing in a raw_response_hook callable.
Passing in cls for custom deserialization (not documented nor advised that end customers use this).

It's therefore difficult to access headers that are an important part of the response.
For example, the "etag" returned from get_resource operation, as is the case for JobRouter SDK:
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/communication/azure-communication-jobrouter/azure/communication/jobrouter/_operations/_operations.py#L1256
We need a design to make accessing this feel more integrated into the scenario.

Have a response_header that returns the raw dict of the headers. This is all the time.
Expose as attribute at the root, named correctly, based on TypeSpec, if the model generation is on


Multiple Modals and Backdrop

If I open a modal within a modal, a new backdrop doesn't instantiate for the second modal. Does Angular UI support this use case? If not, is there an option to move the backdrop to the highest modal?

+1
In my case, I have closed one modal (lets call it Modal A) and immedialtly opened another one (lets call it Modal B). Modal A has a backdropClass defined for it.
When modal B is opened, the backdropClass is not removed.

plunkr to demonstrate please

http://plnkr.co/edit/KCBVGVzirLlApozRrbjl
The flow is as follows: Once to open the first modal, clicking OK will close it and will open the second one right away.
Notice that the first modal add a "custom-backdrop" class which is not removed when the second modal opens.

So we've run into this as well.  I'm still poking around, but it seems that there's a race condition from closing the first modal (and removing its backdrop) and setting the backdrop of the second modal.
Specifically, I'm seeing that backdropDomEl is non-null right here, which means that the second modal does not get its backdrop applied.


Update BuildFrameworksTask to build Package.swift directly

🚀 Description
Since generate-xcodeproj is now deprecated, we need a means to build a XCFramework packaged binary from a Package.swift
There is limitation with using xcodebuild with Swift package.
https://forums.swift.org/t/how-to-build-swift-package-as-xcframework/41414
Based on script shared with this Apple forum:
https://developer.apple.com/forums/thread/741100
This PR will upgrade BuildFrameworksTask to build and package XCFramework.
https://github.com/PaGr0m/kotlin-spm-plugin/issues/3
https://youtrack.jetbrains.com/issue/KT-53877/Support-Swift-Package-Manager-in-Kotlin-Multiplatform

Closing in favour of https://github.com/PaGr0m/kotlin-spm-plugin/pull/7


Add detailed build instructions for thrift and jar update

Tested on a ubuntu 21.10 fresh install.

All fixed.


Build warning: using a private weak EpsCopyOutputStream::Encode64

Building on macOS using:
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Debug -DGMP_INCLUDE_DIR=... -DGMP_LIBRARY=...
ninja -j4

Produces warnings:
ld: warning: direct access in function 'sentry::Forks::_InternalSerialize(unsigned char*, google::protobuf::io::EpsCopyOutputStream*) const' from file 'node/libsilkworm_noded.a(sentry.pb.cc.o)' to global weak symbol 'google::protobuf::io::EpsCopyOutputStream::Encode64(unsigned long long)' from file '/Users/daniel/.hunter/_Base/4942227/e433264/ca8c68e/Install/lib/libprotobufd.a(descriptor.pb.cc.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
ld: warning: direct access in function 'sentry::MessagesRequest::_InternalSerialize(unsigned char*, google::protobuf::io::EpsCopyOutputStream*) const' from file 'node/libsilkworm_noded.a(sentry.pb.cc.o)' to global weak symbol 'google::protobuf::io::EpsCopyOutputStream::Encode64(unsigned long long)' from file '/Users/daniel/.hunter/_Base/4942227/e433264/ca8c68e/Install/lib/libprotobufd.a(descriptor.pb.cc.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

It looks like the generated sentry client code (sentry.pb.cc) wants to access "private" symbols in libprotobuf.
This feels to be expected, so this is likely some kind of misconfiguration of the build.
cmake version 3.23.2
build tools from Xcode 13.3

Fixed by https://github.com/torquem-ch/silkworm/pull/710


Add API Access for BFL Pro models

Feature Idea
Add api access for black forest labs Flux Pro models. Nodes are located here:
https://github.com/black-forest-labs/bfl-comfy-nodes
Other
No response

I want to move the SAI nodes to optional, and have both BFL and SAI node packs be installable with a click of a button, probably right next to the API key. Maybe also automagically add simple tab entries for them when installed too

That would be great!
On Wed, Oct 9, 2024 at 9:46 PM mcmonkey4eva @.***>
wrote:

I want to move the SAI nodes to optional, and have both BFL and SAI node
packs be installable with a click of a button, probably right next to the
API key. Maybe also automagically add simple tab entries for them when
installed too
—
Reply to this email directly, view it on GitHub
https://github.com/mcmonkeyprojects/SwarmUI/issues/315#issuecomment-2403988359,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7JVNUGFDJ76VRZQPPJZTOTZ2YBC3AVCNFSM6AAAAABPVDTSJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTHE4DQMZVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


select_value as in activerecord

ActiveRecord has useful methods select_value, select_values, select_rows and other.
I'd like to use row_to_json from postres as it is the most efficient way to give result from API.
I'd like to add some helper kind of this:
class BaseModel extends require('openrecord/store/postgres').BaseModel {
  static jsonArrayString() {
    return this.select(`row_to_json(${this.tableName}.*)`).select_value()
  }
}

(don't sure yet how is static method could be integrated with OpenRecord models)
And then use it like:
const jsonString = User.where(conditions).select(fields).jsonArrayString()
return jsonString to client

Method select_value should take the first row the first column result without parsing and just return it.
Maybe I could try to implement it and make PR, will it be useful, how do you think?
By the way, OpenRecord looks the most convinient library among other ORMs for node.js, especially for RoR developers, thanks a lot

Does this solve your problem?

Yes, exactly, thanks a lot!
Now I modified my base model to have definition:
    this.scope('jsonAgg', function() {
      this.setInternal('jsonAgg', true)
    })

    this.beforeFind(function(query) {
      if (!this.getInternal('jsonAgg')) return

      // here your code
    }

And benchmarked selection:
  let start = Date.now()
  for (let i = 0; i < 100; i++)
    await User.select('a', 'b', 'c', 'd', 'e').jsonAgg()
  console.log(Date.now() - start)

  start = Date.now()
  for (let i = 0; i < 100; i++)
    JSON.stringify(await User.select('a', 'b', 'c', 'd', 'e'))
  console.log(Date.now() - start)

Json agg rules here: on first request almost the same, then it takes 0.17s vs 1.03 for JSON.stringify

awesome!
If you have a flamegraph or some similar benchmarking results regarding "time spend", please attach it to this issue. I'm very interested in reducing overhead.
Thanks,
Philipp


Add ability to save the Resource Estimator space-time diagram as a file (png/jpg/svg)

This would not work in VS Code but we can consider Jupyter notebook and other scenarios

CONTRIBUTORS PLEASE READ
Welcome! Here are some more details to get you started.
Detailed issue description
This feature can be implemented either in the VS Code Resource Estimation panel, or in the qsharp-widgets Python widget.
VS Code

Go to https://vscode.dev/quantum/playground/
Open Dynamics (Resource Estimation).qs from the samples.
Click the "Estimate" code lens or run the "Q#: Calculate Resource Estimates" command.
Accept the default values in the next few dialogs that come up.
The Space-time diagram should show up in the panel on the right hand side.

Jupyter notebooks
The estimation-factoring.ipynb  sample notebook in the repo contains an example of a space-time diagram from qsharp-widgets.

The requested feature is a button, a right-click menu item, or some other mechanism that allows you to save or download this image as a file. PNG would be ideal, JPG or SVG could work too.
Getting started
Please take a look through our README to orient yourself in the repo and find instructions on how to build.
For this issue, you'll want to have a working knowledge of JavaScript and HTML. The fix will likely be entirely implemented in TypeScript.
The Resource Estimator space-time diagram is implemented in the below React component:
qsharp/npm/qsharp/ux/estimatesOverview.tsx at main · microsoft/qsharp (github.com)
We're happy to accept a fix to either the VS Code version of this panel or the Python widget version.
To build and launch the VS Code extension locally see qsharp/vscode/BUILDING.md
To build the Python widgets, see the qsharp/widgets/readme.md .
Testing
Test your fix manually by building & running the VS Code extension and/or Python widgets as described.
Before you submit a pull request please run python ./build.py to ensure the project builds cleanly. See README for details.
Reviews
Please ensure your code is tested, clean and well refactored before opening a pull request. If you're not sure, feel free to open a draft PR for preliminary feedback.
It would really help if you include a GIF of your feature working in your PR description.
Once you have published your PR, the codeowners will automatically get tagged and we'll review shortly.
If you need clarification on an issue please tag @minestarks with your questions.

@nirajvenkat I want to assign this issue to you (for unitaryhack). Could you please comment on this issue so GitHub will let me assign to you?

Sure!

@nirajvenkat it doesn't look like you registered for the event. Send me an email at<EMAIL_ADDRESS>if you want the bounty!


Packages to add to the rootfs image

For the ones coming from zypper, should be as simple as adding them here: https://github.com/mudler/cOS/blob/85e764da2ab6698d9c3d216de0e55834a8ee25d7/packages/tumbleweed/definition.yaml#L5
We should check anyhow if we can reduce their footprint, by removing extra files which are not needed ( e.g. we already drop /usr/include)

[ ]        conntrack-tools
[x]        curl
[x]        dosfstools
[x]        e2fsprogs
[ ]        findutils
[ ]        haveged
[x]        iproute2
[ ]        iptables
[ ]        lsscsi
[ ]        lvm2
[ ]        mdadm
[ ]        multipath-tools
[ ]        nfs-utils
[ ]        open-iscsi
[ ]        open-vm-tools
[ ]        python-azure-agent*
[ ]        qemu-guest-agent
[ ]        rng-tools
[ ]        rancher-agent

We should check anyhow if we can reduce their footprint, by removing extra files which are not needed

Some of it can be done a RPM macro level and libzypp conf level. One can avoid the installation of files in certain folder, avoid the installation of file marked as doc or translations to other languages. This not super effective as it needs to be generic for every package but relatively simple to maintain.
On the other side I am fine trying to reduce the image footprint. I spended myself quite some time trying to make leap and sle containers small and I ended up to the conclusion that most of this work should be done on the package itself at distro level. Anyway, that makes me wonder if we are under some expectations regarding the size of the image, otherwise I would not put pressure now on making it smaller, it feels like a pre-optimization.

We should check anyhow if we can reduce their footprint, by removing extra files which are not needed

Some of it can be done a RPM macro level and libzypp conf level. One can avoid the installation of files in certain folder, avoid the installation of file marked as doc or translations to other languages. This not super effective as it needs to be generic for every package but relatively simple to maintain.
On the other side I am fine trying to reduce the image footprint. I spended myself quite some time trying to make leap and sle containers small and I ended up to the conclusion that most of this work should be done on the package itself at distro level. Anyway, that makes me wonder if we are under some expectations regarding the size of the image, otherwise I would not put pressure now on making it smaller, it feels like a pre-optimization.

We should check anyhow if we can reduce their footprint, by removing extra files which are not needed

Some of it can be done a RPM macro level and libzypp conf level. One can avoid the installation of files in certain folder, avoid the installation of file marked as doc or translations to other languages. This not super effective as it needs to be generic for every package but relatively simple to maintain.

:+1:

On the other side I am fine trying to reduce the image footprint. I spended myself quite some time trying to make leap and sle containers small and I ended up to the conclusion that most of this work should be done on the package itself at distro level. Anyway, that makes me wonder if we are under some expectations regarding the size of the image, otherwise I would not put pressure now on making it smaller, it feels like a pre-optimization.

Yup I agree, and there is no real pressure on it indeed. it's mostly a note to keep in mind for the future being. The thing is that we won't need zypper or rpm, for example to be available on the installable image (because upgrades needs to happen in one docker image only, see #5  and #21 ), which is kinda problematic when I've tried to do that from zypper/rpm itself.
That's why you can see excludes in luet specfiles being used in the tumbleweed image definition (the one that gets installed in the system) like here https://github.com/mudler/cOS/blob/master/packages/tumbleweed/build.yaml#L71.
In that case it is also stripping everything in /usr/include too, and that should be more than enough for the moment,.
Anyhow we have #26 already tracking the shrinking of image size, so nothing much to worry about for now

We should check anyhow if we can reduce their footprint, by removing extra files which are not needed

Some of it can be done a RPM macro level and libzypp conf level. One can avoid the installation of files in certain folder, avoid the installation of file marked as doc or translations to other languages. This not super effective as it needs to be generic for every package but relatively simple to maintain.

:+1:

On the other side I am fine trying to reduce the image footprint. I spended myself quite some time trying to make leap and sle containers small and I ended up to the conclusion that most of this work should be done on the package itself at distro level. Anyway, that makes me wonder if we are under some expectations regarding the size of the image, otherwise I would not put pressure now on making it smaller, it feels like a pre-optimization.

Yup I agree, and there is no real pressure on it indeed. it's mostly a note to keep in mind for the future being. The thing is that we won't need zypper or rpm, for example to be available on the installable image (because upgrades needs to happen in one docker image only, see #5  and #21 ), which is kinda problematic when I've tried to do that from zypper/rpm itself.
That's why you can see excludes in luet specfiles being used in the tumbleweed image definition (the one that gets installed in the system) like here https://github.com/mudler/cOS/blob/master/packages/tumbleweed/build.yaml#L71.
In that case it is also stripping everything in /usr/include too, and that should be more than enough for the moment,.
Anyhow we have #26 already tracking the shrinking of image size, so nothing much to worry about for now

Most of those packages are added in this branch: https://github.com/rancher-sandbox/cOS/tree/cos-feature-k3s where I'm trying to run k3s/longhorn/harvester on top of cOS (as longhorn required iscsi)


Update container-registry-faq.md

Update to make sure logging out of applicable ACR registry

@sozercan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @sajayantony
This PR has developed a merge conflict. Can you resolve it? Alternatively, if you want the review team to try to resolve it, you must first enter a #sign-off comment in the PR.
Thanks.

Hi @sozercan
The author is unable to resolve the merge conflict. Can you resolve it so we can merge?

It looks like the FAQ was moved to a .yml file format, so the PR can't be merged in. I'll apply the approved update in a new PR in the private repo. We'll close this PR. Thanks!


dom.IntersectionObserver.enabled = false breaks Reddit Enhancement Suite (back/forward buttons)

With Reddit Enhancement Suite and  "dom.IntersectionObserver.enabled" set to false the back/forward button at the bottom of every sub reddit disappears completely. When set to true the buttons re-appear and work as intended (after a page reload).
Setting "dom.IntersectionObserver.enabled" to false also breaks the neverending reddit scroll feature. That seems like expected behaviour though if the Intersection Observer API is disabled. https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API:

Lazy-loading of images or other content as a page is scrolled.
Implementing "infinite scrolling" web sites, where more and more content is loaded and rendered as you scroll, so that the user doesn't have to flip through pages.

If I visit https://www.reddit.com/r/Enhancement/ the "inifnite scrolling" works just fine with dom.IntersectionObserver.enabled = false

I have found another.
With dom.IntersectionObserver.enabled = false open https://bugzilla.mozilla.org/show_bug.cgi?id=1555317, pay attention to comment 6,7 and 8... there are missing screenshots.
Set dom.IntersectionObserver.enabled = true and reload upper sample link, pay attention to comment 6,7 and 8... there are visible screenshots as they should be.
@Thorin-Oakenpants Can you comment... if we block ADs with uBO and such, is then 2426 a problem if set to true?
I am thinking, but all dark in my mind. Already too late here.
Cheers

FWIW, it is default true in TB, but that's only because they haven't gotten around to investigating it
Yes, it is true that you control most damage by controlling your third party connections, JS, etc - but the user.js can't make assumptions about what extensions or MO (modus operandi) end users use
But if you read the MDN, this API is an easier and more reliable way to determine stuff, than older methods. Clearly it is getting some uptake - e.g by determining whats visible to initiate lazy-loading, infinite scrolling, etc - as pointed out by OP. As for the breakage in bugzilla, you can still view the image - but this wouldn't be the case everywhere.
It's also trivial to detect if the API is enabled or not = yet another FP'ing bit.
The question for me comes down to, does it actually leak anything new, or can be used to bypass any other protections. I'm not sure. I don't particularly see pixel level detection as a problem: only sub-pixel, which this may leak - I would need to build a test.
See that bugzilla .. sitting on it for 11 months, reminds me of this one which they also sat on for 10 months until I pointed with a simple test, that it did leak
IANAE, but I don't really see this being used in the wild for FPing: and if ad companies abuse it, well fuck em, this API is not how you beat adverts or corporate surveillance. So yeah, I would be inclined to disable it if it gives you problems.

there's also source an IntersectionObserverEntry.time value that needs to be checked that it is covered by RFP

It also can use timers to build browsing profiles: https://jsfiddle.net/api/mdn/
When an element is in view, the timer for that element increments. This is more in the realm of behavioral FP'ing. Not even sure if it's useful in this way.  And while KB analysis would be universal, this "visibility" one would depend on each page.

Thank you @Thorin-Oakenpants.
Note: upper link https://jsfiddle.net/api/mdn/ leads to 404.
Cheers :heart:

I suspect that this can leak sub-pixels since it uses clientRec

There's also a Resize Observer API in 68+: https://bugzilla.mozilla.org/show_bug.cgi?id=1272409

Subpixels can already be detected via other means (assuming this can even do that), and this API doesn't seem to leak anything extra AFAICT - you could use older (sometimes less-reliable) methods in dom. Given more uptake with it over the web since FF55 = more breakage, I'm inclined to make the pref inactive and leave at default like TB


Fix relay list

r tag without second parameter (which means read: true, write: true) is added to kind 10002 when read: false, write: false.

Fixed in 9f8095b0df848f92ce9e828e2c52cc8d9a71cd03


Integration CI broken for python lib juju==2.9.5

Integration CI runs are failing when doing:
async def test_build_and_deploy(ops_test):
    ...
    await ops_test.model.deploy("cs:istio")

raising the error:
____________________________ test_build_and_deploy _____________________________
Traceback (most recent call last):
  File "/home/runner/work/kubeflow-volumes-operator/kubeflow-volumes-operator/tests/integration/test_charm.py", line 28, in test_build_and_deploy
    await ops_test.model.deploy("cs:istio")
  File "/home/runner/work/kubeflow-volumes-operator/kubeflow-volumes-operator/.tox/integration/lib/python3.8/site-packages/juju/model.py", line 1610, in deploy
    res = await self.deploy_types[str(url.schema)].resolve(url, architecture, application_name, channel, series, entity_url)
  File "/home/runner/work/kubeflow-volumes-operator/kubeflow-volumes-operator/.tox/integration/lib/python3.8/site-packages/juju/model.py", line 510, in resolve
    series = self.get_series(entity_url, result)
  File "/home/runner/work/kubeflow-volumes-operator/kubeflow-volumes-operator/.tox/integration/lib/python3.8/site-packages/juju/model.py", line 1551, in _get_series
    ss = entity['Meta']['supported-series']
KeyError: 'supported-series'

This has not been debugged, but has instead been mitigated by pinning libjuju to the last known working version juju==2.9.3 in tox.ini.  This should be properly fixed or a bug raised against juju

This should be addressed by now with the latest releases


Comma-separated 'property' values no longer work in 2.9.0

In the previous release (2.8.1), it was possible to update multiple properties (and set them all to the same version) by using:
mvn versions:set-property -DnewVersion=22.1 -Dproperty=foo,bar,baz

However, after the changes in https://github.com/mojohaus/versions-maven-plugin/pull/470, this command no longer works and throws an NPE instead:
Caused by: java.lang.NullPointerException
    at org.codehaus.mojo.versions.rewriting.ModifiedPomXMLEventReader.replaceBetween (ModifiedPomXMLEventReader.java:515)
    at org.codehaus.mojo.versions.api.PomHelper.setPropertyVersion (PomHelper.java:209)
    at org.codehaus.mojo.versions.SetPropertyMojo.update (SetPropertyMojo.java:129)
    at org.codehaus.mojo.versions.SetPropertyMojo.update (SetPropertyMojo.java:111)
    at org.codehaus.mojo.versions.AbstractVersionsUpdaterMojo.process (AbstractVersionsUpdaterMojo.java:315)
    at org.codehaus.mojo.versions.AbstractVersionsUpdaterMojo.execute (AbstractVersionsUpdaterMojo.java:250)
    <...>

I'm not really sure whether the previous functionality was supported, as I couldn't find any documentation for the property attribute, but it would be nice to fix the NPE regardless.

you're right, this was supported with the previous version, probably more by accident.
i've added back that support with #543 and also added an IT for that behavior


rewrite 302 tutorial on QAOA

https://github.com/Blueqat/blueqat-tutorials/blob/master/tutorial/302_oneplus.ipynb

tutorial deleted


Extension causes high cpu load

Issue Type: Performance
Extension Name: csharp
Extension Version: 1.17.1
OS Version: Linux x64 4.15.0-45-generic
VSCode version: 1.31.1

:warning: Make sure to attach this file from your home-directory: /home/genesis/ms-vscode.csharp-unresponsive.cpuprofile.txt :warning:
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

@gnbertiz08 C# extension 1.18.0 is out with major performance improvements. Can you try installing the latest version and checking if the problem still persists? If yes please upload the cpu profile so that we can analyse the problem.

@gnbertiz08 We havent heard from you in a while. I will close this issue now. Please feel free to reopen if the problem persists.


Firebase Auth plugin: currentUser only from memory

Hello ! :) Thank you all for Flutter and all the plugins :) !
I am not 100% sure, but once the user is logged in, the Firebase SDK store the currentUser on the device (in SharedPrefs or something). It is useful if we want to show the login screen or the home screen, depending if the user is logged in or not.
The current version of the Firebase Auth Plugin doesn't seem to get the currentUser from the device, but only from memory (it stores the logged user in a variable: FirebaseUser _currentUser;  ). So when the app restarts, we loose the currentUser variable and the user has to log in again.
Is there any plan in the future to have a method to get the currentUser stored on the device ?

cc @collinjackson

You won't want to persist the current user, because you don't know how long that object could be valid for. Given that the oauth token could expire. Instead use the sdk to figure if the current user is active and logged in. This can be done with the google_sign_in plugin and firebase_auth plugin.
For example, when the pages state resumes, you'll want to restart the entire sing in process. Let's say the user pauses to check email, in general, the page will be paused and cached. Then let's say I come back a day later, and for some reason, I should sign in again. You won't ever know if the user login state is being audited, expiring, or revoked. So giving this, you'll want to always let the api do this heavy lifting, by requesting the current user, and if it doesn't exist, then call the sign in process. Most often the device sign in with out input, but sometimes it requires more steps, handled by the native device routine.
If you do want to persist something for the firebase user, you could persist the uid for comparison and use in calls to the database.
Example of the call on the pages init state:
https://github.com/flutter/plugins/blob/master/packages/google_sign_in/example/lib/main.dart#L38

@branflake2267 Thank you very much for your answer. Sorry for the confusion,  I didn't say I wanted to persist the current user, I just say that I thought the SDK had some kind of persistency, because with the native approach, if the app is paused/stopped then resumed, we can still access the current user (even if the token is not valid anymore). I agree with you about the token, on the native approach, I use the AuthStateListener to avoid theses cases.
I am using only the email & password method, so I don't know yet if the google_sign_in plugin will be useful to figure if the current user is active and logged in. I still don't know yet how to handle the login flow properly without asking the user to log in every time the app is paused or stopped.
I guess they are several good reasons for the Firebase team to persist the current user. They are using it almost everywhere in the docs. Anyway if you think we should not use the same approach, we can close this issue.

@mkhennoussi I had to do exactly what you explained in one of my apps. I have added the functionality you described here for the dart side and here for iOS
This is just kind of hacked together and I have not implemented the Android side, but what I am doing is showing a loading screen while awaiting the cachedCurrentUser call.  Then, I show a login screen or another screen based on if the currentUser property is set after the cachedCurrentUser future completes.

I agree that we should provide an API that returns a Future<FirebaseUser>, like signInSilently() in the Google Sign In plugin. We may also want to deprecate synchronous access to currentUser to discourage race conditions, see discussion here: https://github.com/flutter/plugins/pull/94

Speaking of abstracting away some of the logic, this api makes it easier to wire up firebase auth on android, I think this is the best method I've seen so far for wiring it up. Besides, you can also use the other 3 options to login as well. :)
https://github.com/firebase/FirebaseUI-Android/tree/master/auth#using-firebaseui-for-authentication
FirebaseAuth auth = FirebaseAuth.getInstance();
if (auth.getCurrentUser() != null) {
    // already signed in
} else {
    // not signed in
}

Closing this as a dupe of https://github.com/flutter/flutter/issues/11541 but please correct me if I'm wrong.

I believe that this was fixed by flutter/plugins#180

@mkhennoussi
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/999. Any further collaboration will be done there.


Update ClasspathTemplateLoader.java

I'm using jade to create templates for html emails. For this we need to include the css directly into the html. So jade code such as
style
         include foundation.css

doesn't work. This works for me though. Assumption is that any dot will be part of extension and not part of the file path which I don't believe is allowed anyway. So it only tacks on .jade if no dot is in the path.

I pretty much tried to fix the same problem in #136.
Still waiting for merge... :disappointed:

Will be fixed in 1.2.0. I actually removed the whole Suffix Check because it's already in the parser and lexer.

Thanks Cristoph!


report: Open Source Development (part of Methodology) [5h]

Prerequisite for #49.

Merged into the Methodology section. Closing this issue in favour of the issue of the Methodology section.


Better UX for docker-machine create -h

Currently docker-machine create -h prints hundreds of lines (probably more than 50 cli options) for all machine drivers.
If we can have something like:
docker-machine create -d virtualbox -h

that only shows me virtualbox, that'd be very tractable.

Try this
docker-machine create -d virtualbox

@robertjustjones that does the job (just prints vbox arguments) but I think adding -h to this command should not print the entire create subcmd usage. It's confusing.

Argh, I'm afraid that might be a codegangsta/cli thing which we have to workaround.

Closing. This is fixed in 0.5.0


Move configs from local.conf.php to _ss_environment.php

Why?
All define() constants done in _ss_environment.php are usable in caching layers or before building the various ConfigManifest files, etc.
By putting database, environment and log settings in this file, we can update our caching layers use these values and/or store cache configs there. (One centralized place for server configurations sounds like a good idea to me!)
Silverstripe versions?
IIRC, _ss_environment.php only works 3.2+, but maybe its in 3.1+ and just not documented.

This would likely require a restructure to our mysite/_config.php templates but if it's doable the benefits sound fine? @nyeholt

Closing this one since everything is now using .env for SS 4.


[stable/rabbitmq] Option to execute 'rabbitmqctl force_boot'

Signed-off-by: Denis Kalgushkin<EMAIL_ADDRESS>
What this PR does / why we need it:
See #13485 . Adds an option to execute 'rabbitmqctl force_boot' to force start on unexpectedly shut down cluster.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #13485

Special notes for your reviewer:
Replaces and closes https://github.com/helm/charts/pull/14059
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

Ok, bumped the version, almost conflicting with another version bump :)

/ok-to-test
/lgtm

/retest


Intercept-only GLMs

It'd be nice to be able to fit GLMs without covariates. It's usually trivial, except when offsets are involved...

I found a way to phrase the obvious, which worked for me using the formula interface:
formula = "Y~ {np.ones_like(Y)}", fit_intercept=True
The more obvious approach "Y~1" throws errors with "fit_intercept=True" and with "fit_intercept=False"


Intro to Jupyter content

Merge or adapt material from Jupyter Meets the Earth project.

Xdev Tutorial material is here:
https://drive.google.com/drive/folders/1zNnBpagQi872f7bo-pkW4WhZKnn97NkW?usp=sharing

Here is a reference to consider including.

Fernando Perez's overview of the Jupyter ecosystem is here:
https://docs.google.com/presentation/d/1NcBVBBgHjXM-1rpBzlkqwlUlvcr_RpZOh5yMyDJOwRU/edit#slide=id.gdc01f99340_0_0
and an updated version is here:
https://docs.google.com/presentation/d/16Zo7A5z4HQkWz92Ph6e8gEhH3k6ITZKhzIRJyzXuqaY/edit#slide=id.p1


Decide whether to keep the consul-ribbon and consul-example modules

Is it worth keeping consul-ribbon and/or consul-example?
If so, clean them up.
If not, remove them and make this a regular Maven project with no sub-modules.

@chrisrohr , @terezivy and I discussed this. Since we only need the actual bundle, we are going to simplify and remove the consul-example and consul-ribbon modules, and then make this into a plain Maven project (i.e. the contents of consul-core will become the entire project).
I may move the other two modules into a separate repository somewhere, just in case we ever care to do anything with them


Refactor code

Follow the concept: we act or throw when we catch exception (just do
one thing each time)
Refine tls layer for error handling
Remove some code

@mike820324
Please help review my code and give me feedback.

Coverage increased (+0.8%) to 57.753% when pulling c46ecf6339eecc1315206f5e61140bc60204fff2 on refactor into f05c84de290bdfe3d148f575b53fb93b1300f3c0 on master.

Everything looks really great to me, The code is much much more cleaner.
Just three small issues I would like to discuss with you.

Should LayerManager be put inside proxy.py? When I write that code, I have no idea I should put it.
Should we organize context.py and http.py to a folder, maybe called message_type or something. The name of http.py is a little bit misleading, IMHO.
Some of the config options try and catch can be removed, since the config.py will help us generate the proper object.

https://github.com/mike820324/microProxy/blob/refactor/microproxy/proxy.py#L57
https://github.com/mike820324/microProxy/blob/refactor/microproxy/proxy.py#L61

Should LayerManager be put inside proxy.py? When I write that code, I have no idea where I should put it.

I think it's ok be there be outside!

Should we organize context.py and http.py to a folder, maybe called message_type or something. The name of http.py is a little bit misleading, IMHO.

yeah.. the http.py is not a good name..
And should these py into some folder, I think it's all ok for me!

Some of the config options try and catch can be removed, since the config.py will help us generate the proper object.

https://github.com/mike820324/microProxy/blob/refactor/microproxy/proxy.py#L57
https://github.com/mike820324/microProxy/blob/refactor/microproxy/proxy.py#L61

For first part at get_first_layer, I think we still raise exception there is a good practice.
Because we cannot make sure that the mode is correct in the future after we changed and changed the code. We need to get exception as fast as we can if we make mistake on this.
The second part, I think it's ok to remove the try catch clause because it will raise exception at the first when config corrupt.

For first part at get_first_layer, I think we still raise exception there is a good practice.
Because we cannot make sure that the mode is correct in the future after we changed and changed the code. We need to get exception as fast as we can if we make mistake on this.

Make sense. This PR looks okay to me. You can just merge the PR whenever you are ready. :D

Coverage increased (+1.0%) to 57.901% when pulling 5ceb35608e7ba706b1144799aacbaa140858ca8a on refactor into f05c84de290bdfe3d148f575b53fb93b1300f3c0 on master.

Coverage increased (+1.0%) to 57.901% when pulling 76364f797f455cbcb49fb274c6efb85a5bd0e12a on refactor into f05c84de290bdfe3d148f575b53fb93b1300f3c0 on master.


Update service-fabric-resource-balancer-service-description.md

Hi @GaugeField, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (abhic). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Add sorting functionality to flights list

Reference: https://github.com/moshobo/appintheair-exporter/issues/7

Thanks for working on this issue @mzanrosso!

Hey @mzanrosso there are a few conflicting changes now. I wanted to see if you were still planning on completing this PR?

Hey @mzanrosso there are a few conflicting changes now. I wanted to see if you were still planning on completing this PR?

Hey I'm sorry, I don't currently have time for implementing a better solution.

No worries, @mzanrosso. Since your branch was behind by a few commits, I've gone ahead and submitted a slightly modified version of your change in #15 . I will close this PR now that the change is submitted.
Thanks again for working on this!


Windows support

My istanbul cover commands fail on windows, but the vows --spec ./test/foo.js works fine.
I get this error:

YUI@WINDOWS7 ~/Desktop/play/cpr (master)
$ npm test

><EMAIL_ADDRESS>pretest c:\Users\YUI\Desktop\play\cpr
> jshint --config ./node_modules/yui-lint/jshint.json ./lib/

><EMAIL_ADDRESS>test c:\Users\YUI\Desktop\play\cpr
> istanbul cover --print both -- vows --spec ./tests/full.js

c:\Users\YUI\Desktop\play\cpr\node_modules\.bin\vows.CMD:1
(function (exports, require, module, __filename, __dirname) { :: Created by np
                                                              ^
Unexpected token :
SyntaxError: Unexpected token :
    at Module._compile (module.js:437:25)
    at Module._extensions..js (module.js:467:10)
    at Object.Module._extensions..js (c:\Users\YUI\Desktop\play\cpr\node_modules
\istanbul\lib\hook.js:101:13)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:492:10)
    at runFn (c:\Users\YUI\Desktop\play\cpr\node_modules\istanbul\lib\command\co
mmon\run-with-cover.js:80:16)
    at c:\Users\YUI\Desktop\play\cpr\node_modules\istanbul\lib\command\common\ru
n-with-cover.js:148:17
    at c:\Users\YUI\Desktop\play\cpr\node_modules\istanbul\lib\util\file-matcher
.js:52:16
    at c:\Users\YUI\Desktop\play\cpr\node_modules\istanbul\lib\util\file-matcher
.js:35:9
No coverage information was collected, exit without writing coverage information

npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

YUI@WINDOWS7 ~/Desktop/play/cpr (master)
$

For reference, that vows is running:

YUI@WINDOWS7 ~/Desktop/play/cpr (master)
$ ./node_modules/.bin/vows --spec ./tests/full.js

  ♢ CPR Tests

  should be loaded
    ✓ should have cpr method
  should fail on non-existant from dir
    ✓ should return an error in the callback
  should be loaded and should NOT copy node_modules
    ✓ does not have ./out/1
    ✓ and threw an error
  should be loaded and should not copy graceful-fs from function
    ✓ and has ./out/3
    ✓ and dirs are not equal
    ✓ and from directory has graceful-fs dir
    ✓ and to directory does not have graceful-fs dir
  should be loaded and should copy node_modules
    ✓ has ./out/0
    ✓ and dirs are equal
    ✓ and from directory has graceful-fs dir
    ✓ and to directory has graceful-fs dir
  should be loaded and should not copy yui-lint from regex
    ✓ and has ./out/2
    ✓ and dirs are not equal
    ✓ and from directory has yui-lint dir
    ✓ and to directory does not have yui-lint dir
  should be loaded and should copy node_modules with overwrite flag
    ✓ has ./out/0
    ✓ and dirs are equal
    ✓ and from directory has graceful-fs dir
    ✓ and to directory has graceful-fs dir

✓ OK » 20 honored (10.885s)

YUI@WINDOWS7 ~/Desktop/play/cpr (master)
$

I am using this command
istanbul cover C:\Users\abhisek.user\AppData\Roaming\npm\node_modules\mocha\bin\_mocha test
But it is giving this as out put and not generating the report.
Transformation error; return original code
[TypeError: Object # has no method 'isIdentifierPart']
//
//
No coverage information was collected, exit without writing coverage information

That seems to be an error in parsing your Javascript. Are you sure it is well-formed?

Yes it is well formed. will be a reasonfir nide.js?

Using latest version of karma...
cmi-alvinmilton-1089-mbp:ng-desc-tests alvin.milton$ istanbul cover test/*-spec.js
No coverage information was collected, exit without writing coverage information
/Users/alvin.milton/Development/ng-desc-tests/test/add-spec.js:7
describe('add', function () {
^
ReferenceError: describe is not defined
  var add;
  beforeEach(function () {...```

I can confirm that this is still an issue on windows 10.
C:\Program Files (x86)\nodejs\npm.CMD:1
(function (exports, require, module, __filename, __dirname) { :: Created by npm, please don't edit manually.
                                                              ^

SyntaxError: Unexpected token :
...

I am running it this way (without flags for readability):
istanbul cover npm run test:server

Please understand that this command works fine
npm run test:server

So there is no "magic" expansion of variables and I have no idea what you mean by that.
Technical details:
$ node -v
v5.1.1
$ npm -v
3.5.1
$ cat package.json | grep istanbul
    "istanbul": "0.3.17",
$ cat package.json | grep mocha
    "mocha": "2.3.3",

I tested and can confirm that it persists in istanbul 0.4.1

I have a similiar problem in Windows 8. This does not work:
istanbul cover jasmine-node spec

No coverage information was collected, exit without writing coverage information
C:\Users\x\AppData\Roaming\npm\jasmine-node.CMD:1
(function (exports, require, module, __filename, __dirname) { @IF EXIST "%~dp0\node.exe" (
^
SyntaxError: Unexpected token ILLEGAL
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:416:10)
at Object.Module._extensions.(anonymous function) [as .js] (C:\Users\x\AppData\Roaming\npm\node_modules\istanbul\lib\hook.js:109:37)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)
at runFn (C:\Users\x\AppData\Roaming\npm\node_modules\istanbul\lib\command\common\run-with-cover.js:122:16)
at C:\Users\x\AppData\Roaming\npm\node_modules\istanbul\lib\command\common\run-with-cover.js:251:17
at C:\Users\x\AppData\Roaming\npm\node_modules\istanbul\lib\util\file-matcher.js:68:16

But if I add the path to the jasmine executable it works:
istanbul cover node_modules\jasmine-node\bin\jasmine-node spec

....
Finished in 12.51 seconds
4 tests, 7 assertions, 0 failures, 0 skipped

This is still an issue for me on Windows 10 using git-bash from git for Windows 2.8.3 from [1].
$ istanbul cover _mocha -- --recursive
No coverage information was collected, exit without writing coverage information
C:\Users\scott\AppData\Roaming\npm\_mocha.CMD:1
(function (exports, require, module, __filename, __dirname) { @IF EXIST "%~dp0\node.exe" (
                                                              ^

SyntaxError: Unexpected token ILLEGAL
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Object.Module._extensions.(anonymous function) [as .js] (C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\hook.js:109:37)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at runFn (C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\command\common\run-with-cover.js:122:16)
    at C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\command\common\run-with-cover.js:251:17
    at C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\util\file-matcher.js:68:16

but if I pass the full path to _mocha it works,
$ istanbul cover node_modules/mocha/bin/_mocha -- --recursive
Here are some details of what is installed on my system:
$ istanbul help 2>&1 |grep version
istanbul version:0.4.3

$ node -v
v4.4.4

$ npm --version
2.15.1

$ mocha --version
2.4.5

Could it be due to previously npm install -g mocha and npm install -g istanbul ? The failing call stack is referencing the %APPDATA% paths of mocha and istanbul so maybe that is what is messed up?
$ where mocha
C:\Users\scott\AppData\Roaming\npm\mocha
C:\Users\scott\AppData\Roaming\npm\mocha.cmd

$ ls /c/Users/scott/AppData/Roaming/npm/node_modules/mocha/bin/
_mocha*  mocha*  options.js

$ where istanbul
C:\Users\scott\AppData\Roaming\npm\istanbul
C:\Users\scott\AppData\Roaming\npm\istanbul.cmd

$ where _mocha
C:\Users\scott\AppData\Roaming\npm\_mocha
C:\Users\scott\AppData\Roaming\npm\_mocha.cmd

$ ls ./node_modules/mocha/
bin/          images/   lib/     mocha.css  node_modules/
CHANGELOG.md  index.js  LICENSE  mocha.js   package.json

$ ls ./node_modules/istanbul/
CHANGELOG.md  index.js  lib/  LICENSE  node_modules/  package.json  README.md

$ istanbul cover -v _mocha -- --recursive
Using configuration
-------------------
verbose: true
instrumentation:
    root: .
    extensions:
        - .js
    default-excludes: true
    excludes: []
    embed-source: false
    variable: __coverage__
    compact: true
    preserve-comments: false
    complete-copy: false
    save-baseline: false
    baseline-file: ./coverage/coverage-baseline.json
    include-all-sources: false
    include-pid: false
    es-modules: false
    preload-sources: false
reporting:
    print: summary
    reports:
        - lcov
    dir: ./coverage
    watermarks:
        statements: [50, 80]
        lines: [50, 80]
        functions: [50, 80]
        branches: [50, 80]
    report-config:
        clover: {file: clover.xml}
        cobertura: {file: cobertura-coverage.xml}
        json: {file: coverage-final.json}
        json-summary: {file: coverage-summary.json}
        lcovonly: {file: lcov.info}
        teamcity: {file: null, blockName: Code Coverage Summary}
        text: {file: null, maxCols: 0}
        text-lcov: {file: lcov.info}
        text-summary: {file: null}
hooks:
    hook-run-in-context: false
    post-require-hook: null
    handle-sigint: false
check:
    global:
        statements: 0
        lines: 0
        branches: 0
        functions: 0
        excludes: []
    each:
        statements: 0
        lines: 0
        branches: 0
        functions: 0
        excludes: []

-------------------

Running: node C:\Users\scott\AppData\Roaming\npm\_mocha.CMD --recursive
No coverage information was collected, exit without writing coverage information
C:\Users\scott\AppData\Roaming\npm\_mocha.CMD:1
(function (exports, require, module, __filename, __dirname) { @IF EXIST "%~dp0\node.exe" (
                                                              ^

SyntaxError: Unexpected token ILLEGAL
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Object.Module._extensions.(anonymous function) [as .js] (C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\hook.js:109:37)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at runFn (C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\command\common\run-with-cover.js:122:16)
    at C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\command\common\run-with-cover.js:251:17
    at C:\Users\scott\AppData\Roaming\npm\node_modules\istanbul\lib\util\file-matcher.js:68:16

$ cat /c/Users/scott/AppData/Roaming/npm/_mocha.cmd
@IF EXIST "%~dp0\node.exe" (
  "%~dp0\node.exe"  "%~dp0\node_modules\mocha\bin\_mocha" %*
) ELSE (
  @SETLOCAL
  @SET PATHEXT=%PATHEXT:;.JS;=;%
  node  "%~dp0\node_modules\mocha\bin\_mocha" %*
)

$ cat /c/Users/scott/AppData/Roaming/npm/_mocha
#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/node_modules/mocha/bin/_mocha" "$@"
  ret=$?
else
  node  "$basedir/node_modules/mocha/bin/_mocha" "$@"
  ret=$?
fi
exit $ret

$ uname
MINGW64_NT-10.0

Let me know if gathering any additional command output or file contents would be helpful.

Still an issue with
istanbul cover mocha

but
istanbul cover node_modules/mocha/bin/_mocha

works

node -v
v6.2.2
npm -v
3.9.5
use istanbul as devDependencies.  used script:
istanbul cover -x *.test.js node_modules/mocha/bin/_mocha -- -R spec src/index.test.js
it works!

same as @scott-plutovr I alse see this error under git-bash

Still relevant.

I also have this issue with node 10.1.0 on a windows machine.

I guess we should setup appveyor and try to find solutions.

It seems like this is working for node versions 6 and 8, but it doesn't work for node version 10. I had to uninstall 10.15.3 and revert back to 8.15.1.

It seems like this is working for node versions 6 and 8, but it doesn't work for node version 10. I had to uninstall 10.15.3 and revert back to 8.15.1.

You can use nvm and alternatives to switch versions.

It seems like this is working for node versions 6 and 8, but it doesn't work for node version 10. I had to uninstall 10.15.3 and revert back to 8.15.1.

You can use nvm and alternatives to switch versions.

NVM doesn't work for me on an x64 Windows 10 system. I'm noticing there's no stdout when I'm running my coverage combined with _mocha.
node ./node_modules/istanbul/lib/cli.js cover ./node_modules/mocha/bin/_mocha --harmony -- -R spec
produces the coverage results without outputting the describe and it blocks during testing.

and alternatives

I did not say that nvm can be used on Windows (in general).

you could use npx node@8 to use node version 8 even when you have a different version installed
something like:
npx node@8 node_modules/istanbul/lib/cli.js cover *.test.js node_modules/mocha/bin/_mocha

On WSL and Git Bash much more solutions should work.

WSL is not Windows either.

Damn, I wish I had an easy way to reproduce windows issues. Do you have a VM or something I can use to play with this.
Windows is the biggest gap in tests for istanbul

We can test with Travis CI.
I will open a PR for this.

@DanielRuf I don't think this repo is maintained.
According to the readme:

Deprecation Notice: this version of istanbul is deprecated, we will not be
landing pull requests or releasing new versions. But don't worry, the Istanbul 2.0
API is now available and is being actively developed
in the new istanbuljs organization.

https://github.com/gotwarlost/istanbul/pull/910
But I think it is better to use another code coverage solution (v8 internally provides this already).
The last (tagged) release was in 2016 and last commit in 2017:
https://github.com/gotwarlost/istanbul/releases.

According to the readme:

Deprecation Notice: this version of istanbul is deprecated, we will not be
landing pull requests or releasing new versions. But don't worry, the Istanbul 2.0
API is now available and is being actively developed
in the new istanbuljs organization.

Right, time to migrate then I guess. Was not clear enough in the readme.

https://github.com/istanbuljs/nyc it is then.

If you're having this issue and you're on a Windows machine, all you need to do is to specify the full path of mocha to istanbul like so;
istanbul cover node_modules/mocha/bin/_mocha


Create dlc_main.html

A landing page for the digital land charges project

Cool.  Do you want me to do your Pull Request? ;-)
From: ztrelease<EMAIL_ADDRESS>Sent: 24 February 2015 13:12
To: LandRegistry/landregistry.github.io
Subject: [landregistry.github.io] Create dlc_main.html (#25)
A landing page for the digital land charges project

You can view, comment on, or merge this pull request online at:
https://github.com/LandRegistry/landregistry.github.io/pull/25
Commit Summary

Create dlc_main.html

File Changes

A dlc_main.htmlhttps://github.com/LandRegistry/landregistry.github.io/pull/25/files#diff-0 (10)

Patch Links:

https://github.com/LandRegistry/landregistry.github.io/pull/25.patch
https://github.com/LandRegistry/landregistry.github.io/pull/25.diff

—
Reply to this email directly or view it on GitHubhttps://github.com/LandRegistry/landregistry.github.io/pull/25.
This email was scanned by the Government Secure Intranet anti-virus service supplied by Vodafone in partnership with Symantec. (CCTM Certificate Number 2009/09/0052.) In case of problems, please call your organisations IT Helpdesk.
Communications via the GSi may be automatically logged, monitored and/or recorded for legal purposes.
Land Registry is the definitive source of information for more than 24 million property titles in England and Wales. Since 1862 we have provided security and confidence in one of the most active property and mortgage markets in the world. We are working to support economic growth and data transparency as part of the Public Data Group. Find out more at www.gov.uk/land-registry
If you have received this e-mail and it was not intended for you, please let us know, and then delete it. Please treat our communications in confidence, as you would expect us to treat yours. Land Registry checks all mail and attachments for known viruses, however, you are advised that you open any attachments at your own risk.
The original of this email was scanned for viruses by the Government Secure Intranet virus scanning service supplied by Vodafone in partnership with Symantec. (CCTM Certificate Number 2009/09/0052.) This email has been certified virus free.
Communications via the GSi may be automatically logged, monitored and/or recorded for legal purposes.

Think this has been surpassed by PR #28
Suggest closing?

Yup, please do.
On 27 February 2015 at 14:34, Matthew Shaw<EMAIL_ADDRESS>wrote:

Think this has been surpassed by PR #28
https://github.com/LandRegistry/landregistry.github.io/pull/28
Suggest closing?
—
Reply to this email directly or view it on GitHub
https://github.com/LandRegistry/landregistry.github.io/pull/25#issuecomment-76403137
.

Can we close this? It's been hanging around for 43 days at the top of our merge radiator...

Kill it Gorton!

Closed as requested above.


Mirror operation

Couldn't find a way to replicate this with the existing API

So this mirrors about all axes simultaneously? I feel like one might want to mirror about a single axis. Could you propose a way of doing that?

Added a version that takes a plane in point and normal form to mirror across.


Remove TCP sockets from beta list

Hey!
Someone pointed out on Discord that TCP sockets are still listed as private beta on the docs site. This is no longer true. As I was unable to find any mention of them being beta outside of this page, I removed them from this page altogether.

Erisa just pointed out that they had opened #12709 before this, so I'll close this one in favour of that.


feat(menu/exportCommunication): Allow export of communication section

Closes #1042
This seemed straightforward to me and within my capability, so I thought I might do it.
I only belatedly realised that I had not carefully read the issue and noticed that @ca-d had self-assigned. Feel free to close my PR if this was not what you had in mind or if that's easier, I will not mind in the least :wink:
I'm not very sure about the icon or the tests and the name of the extension doesn't quite fit the Menu (should the menu be wider?)
Incidentally, I'm interested in this because I'd like to define (at some point) a custom file format for the communication section to function as an interface for confirming IPAM and to enable building network switch configuration with Communication section information on VLANs and with MAC address filtering for SV traffic. At some stage, I'll raise a separate issue for that. What is missing is "who needs" the GOOSE/SMV traffic.

@ca-d suggested making this a conformant SCL file by including the SCL root note and the Header element as well. I will add these.

@ca-d suggested making this a conformant SCL file by including the SCL root note and the Header element as well. I will add these.

I have done these, I hope - I will be grateful for a review and happy to make improvements.
I will also want to add some documentation for this plugin for the Help function.

@ca-d suggested ...

I have done these

Thank you, @danyill - great work overall! Regarding the Help, I think it'll be useful to update the wiki, but I'd really like to fix the help viewer (internal links currently do not work) before updating the content again. Currently the built in help viewer is hardly usable to me.
My current favored solution for fixing this bug:

Introduce a build step which compiles the markdown to static HTML files into the distribution directory.
Get rid of the markdown renderer runtime dependency.
Render the static html help statically into an iframe using import.meta.url to construct the iframe's original src attribute.
???
Profit!

:+1: Thank you both for these review comments, I hope to look at these over the next few days

Regarding the Help, I think it'll be useful to update the wiki, but I'd really like to fix

I have logged #1057

I did have before but removed as per review comments.
I thought this would at least test the plugin functions without an
exception.
I would be pleased to receive some help.
On Thu, 17 Nov 2022, 20:44 cad, @.***> wrote:

@.**** commented on this pull request.
In test/integration/menu/ExportCommunication.test.ts
https://github.com/openscd/open-scd/pull/1044#discussion_r1024846826:

parent = await fixture(html`

 <mock-wizard-editor

   ><export-communication></export-communication

 ></mock-wizard-editor>

`);

element = (

 parent.querySelector('export-communication')!

);

element.doc = doc;
element.docName = 'CommunicationTest.scd';
element.run();
await parent.requestUpdate();
});

I don't get this test file, did you have some tests in here before, or did
you still intend to add some? If you want help coming up with tests, I'd be
happy to think of a couple together.
—
Reply to this email directly, view it on GitHub
https://github.com/openscd/open-scd/pull/1044#pullrequestreview-1183803265,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFEXXZAKSCE3AWWMSAOUJTWIXO4BANCNFSM6AAAAAARGEAI3A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you ca-d for reviewing this and for providing the tests


Fix improper console.log call found in #15

was it solved? Still see no video in MMM-RTSPtoWEB, if MMM-GoogleMapsTraffic is active...
What can I do meanwhile?

@Joern-HAP the author @vicmora has not accepted the fix since ~5 years. You will be better of uninstalling the module and reinstall the fork that includes the fix https://github.com/shbatm/MMM-GoogleMapsTraffic