Wireframe / design profile

I am not a graphic designer but maybe these can get the discussion sparked here.

I'll also point out. I don't really like that bookmarks are the center icon on the tabbar. For some reason I feel it should be profile or inbox. But I wasn't really focused on that

Including the following images here for quick reference against what Github already does. It would be cool to find some fresh sources of inspiration beyond GitHub.

---------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------------------------------

@BrianLitwin I very much agree. I think the Github profile is great for web but cannot be well replicated in mobile. We should look for inspriation outside but try to maintain a familiar interface

Concept

Wasn't going to sketch up 2 new VC's for repos and followers/following so I Just put 2 cells in 1 View.
Cell 1: Repo cell
Cell 2: Following/Followers

Like the directions! I think we should start with what our information hierarchy should be before going too deep. There's so many things that could exist on the profile!

Avatar
Username
Display name
Bio, location, links
Organizations
Pinned repos
Repos
Followers, following
Stars
Activity

Then there are actions to take:

Follow, unfollow
Share
Block, report

Brainstorm
Brainstorming a bit, we can slice this into buckets ranked by priority:

Who?
a. Personal identity

Avatar
Username, display name
Bio
Location, employer, links
Stars
b. Network identity
Followers
Following
Repositories

What do they do?
a. Organizations
What have they been doing?
a. Pinned Repos
b. Activity

Inspiration
Pulling a few images from Dribbble that drew me in:

Here's a starter sketch file I whipped up on the flight home yesterday. We should stick to the white background style that we're now using on Issues.

Working off @rnystrom sketch file. Merging in some of my original thoughts.

This weekend I started putting together a templated Sketch doc to make wireframing easier. Has colors, text, and icons in shareable components: app.zip
It's not totally complete, but flagging as it might help w/ some of the design language.
cc @cieslakdawid

@Huddie some immediate thoughts:

I'm not a fan of the centered-profile design b/c it wont scale well for iPad w/out massively unused whitespace. I'm all about breathing room, but I think it'll be overboard when scaled up.
The button designs aren't consistent w/ the rest of the app:

Multiple bold/contrasted buttons: why do "Following" and "recent" have the same weight?
"Following" should be "Unfollow" (same as GitHub.com)
I'll admit the app doesn't have a totally consistent button design either. Should be another template we add in the Sketch file and make everything consistent! Harkens back to the gradient discussion (maybe we go full-gradient buttons like all of GitHub...)

Do we need form titles for everything? e.g. "bio" probably unecessary
I want to get rid of having the user handle in the view and just make that the nav item title

We should boil down what the 1.0 of profile on GitHawk should do.
What are the most common actions one takes when viewing someone's GitHub profile? For me, I check where they work, find their website/contact info, or see how "notable" they are (followers, big projects they own)
Once we do this, we can focus on only the features that satisfy only those actions and ignore the others for later on. Otherwise we're going to add a lot of complicated features that aren't a priority (e.g. contribution activity).

@rnystrom

iPad design
I think on iPhone the centered look is nice. I see what you mean that iPad could seem very open. I've never tried GitHawk on iPad but are layouts always the same? I'd suggest that on iPad the name and handle (or whatever we replace it with) become horizontally rather than vertically stacked

Button consistency
I really was trying to give a rough sketch, I'm sure there are plenty of inconsistency ATM but I'll touch it up if we go along this path.

Form titles
Sections above the "Following" button don't have titles. I don't think it looks great if some sections below have and some don't, trying to keep consistent. I could move the bio above the line but I feel it fits better below.

Removing handle in view
Sure I can move it out of view. I can replace it with location/email

Most common actions
I agree there are probably some common ones. I think pinned repos + org. show their notable work. The activity allows you to see what they are currently up to. I think to follow/unfollow is essential along with name + handle and bio and I think quick links to repo/following and followers is appropriate rather than having them actually displayed in the main view.

Website and Contact
I feel these could be found in an Action Controller or something. I tried to keep the main view populated with things that every GitHub user has. (Organizations and Bio are exceptions). We could always add them in though.

We could remove contribution activity but it happens to be on the profile page for github mobile and github web. I personally like it but I can see that it isn't necessary V1.
Let me know your thoughts.

Okay so shift the name and (soon to be added) location + email to horizontal?

Updated.

I almost missed such a great stuff here <3
@rnystrom Do you have a plan to work more on the sketch for wireframes before the weekend?
I underestimated my week and I'm running a bit off the schedule with the starter pack, but this Friday I'm back in life(xCode + Sketch ;) ) and want to finish in 2/3 days. To avoid duplication, I'll just post the state of work before starting on Friday.

I think one consideration is that if we're going to have tabs down the road for Repos and Starred Repos, as in Sherlouk's design, the current "Repos/Followers/Following" UI would require a significant re-design as it is now:

Not trying to look ahead too much, but the more prominent that UI is in our 1.0, the trickier it will be to de-couple later on.
Would also like to note, unless the Repos and Starred Repos tab are meant to look different from the Search Repos ViewController we currently use, we can reuse SearchRepoResult + SearchRepoResultSectionController, which makes those tabs very easy to build. See this view controller, which can be used for both Repos and Starred.
I don't see a great reason to spend time building links to a GitHub web view when we already have so much of the architecture to display them natively already in place. More importantly, if we put Repos front and center, we'll have to re-design down the road if we ever want to give Repos a tab.

I think the Repo/Followers/Following buttons should take you to a new view rather than have them as tabs. And the new view should be native for sure.

Just saying that this all looks beautiful and is far better than my envelope drawing 😂

@Sherlouk You got it started. Gotta start somewhere. Thank you
Sent with GitHawk

@cieslakdawid not really, pretty slammed the next two weeks then going out of town.
Sent with GitHawk

Any thought on finishing up this design so @BrianLitwin can tweak his profile branch? @rnystrom Any suggestions for improvement on the last design render above?

@Huddie lemme make a Sketch prototype of @Sherlouk 's original design and so we can put that into the discussion. I'll do that in the next few days.

Sure sounds good. 👌🏻
Sent with GitHawk

Still not a Sketch pro so the best I can do for a screenshot for now:

@BrianLitwin looks good to me
Sent with GitHawk

@BrianLitwin I really dig it!!

Maybe follow/unfollow is a navbar item or shows up in a action controller?
Sent with GitHawk

Interesting looking envelope 😂 Looks great!
Think I had planned to have a ... menu in the navbar which does things like follow/unfollow and share

This is all really cool. Thanks for tagging this ticket @brianlitwin
No rush at all, but goal would be to have pulse activity for both user (including perhaps a feed devoted to just posts and comments) and repository

Is anybody working on this at the moment?
Might try and get a bare bones MVP going - think once the foundation is laid we can start to build on top of that with more tabs and information!

@Sherlouk I've taken soft passes in #2125 and #2113 - I think the client/graphql stuff from those pr's is valid. If I post that part (couple hundred lines), can y'all check out the pr and build on top of it?

@Sherlouk okay lemme clean up the UserProfile branch then, I don't think that's up to date

Hey Folks 👋 , I am a designer and wanted to help out.
@Sherlouk and @BrianLitwin are the Designs posted Oct 2  What you are currently working off of?
Can I provide any design support to help ya'll out?
Right now I think I can work on a rough design for;

Repos tab
Stars tab
Share / Follow Drawer?
Expanded Pined Repos

Let me know how I can help!

@kocheck don't feel constrained by any of the designs on this thread; there's no consensus that I know of. If you have other ideas, feel free to share them.

Roger that! I wanted to try and take a good crack at it this weekend thanks!

Hey, Folks 👋  Found some time to jump into the design file this morning. How do ya'll feel about this direction? Any comments or feedback?
Design Overview 1
The closest to the last posted designs.
Updates

ViewController Tab is moved down to provide a little more hierarchy.
Included a version with (aprox) max character count for the bio.
Moved the Follow and Share actions into an Action Sheet triggered via the Menu icon in the Navbar

Short Bio
Long Bio
iPhone SE

Design Overview 2
This design steps out just a little further. If ya'll want me to keep going and head overboard let me know 😄
Updates

ViewController Tab is moved down to provide a little more hierarchy.
Included (aprox) max character count for the bio.

Moved bio to be inside the table view.

Did a quick pass at Profile Stats

Repos
Followers
Following

Added Follow/unFollow button
Moved the Follow and Share actions into an Action Sheet triggered via menu icon next to follow button

Unfollow
Follow
iPhone SE

Still Designing / Next Steps

I would like to explore a version where the pinned Repos are contained within a box. Like in this comment  that @Huddie created. I rather like that.
pulse activity for the user *
pulse activity for repository *
Expanded states. for items in the table view
Repos (tab)
Stars (tab)
ActionSheet

Unknowns

I am making an assumption Githawk supports iPhone SE with the auto layout tool, from the conversation above 👆talking about iPad support.

 Would Githawk display these items just like Github or would this be more custom?

Totally agree moving down the tabbar  looks much better +1
For second design:

Follow/Unfollow I feel is a 1 maybe 2 time action. It seems to take up a big part of the top view and probably will never change for most people once clicked.
Repos seem to come up twice (tab and in the top part)
I personally think the bio is attached to name, location etc and should no be in the lower section when the others are in the top section.

I like both for the most part. I think design 1 short bio is a good place to start and design 2 can be a more fleshed our second version
Sent with GitHawk

@kocheck yo that looks SO GOOD! Love moving the bar down, very clean!
@Huddie @BrianLitwin playing devil's advocate w/ myself, maybe the following/etc count shouldn't be so prominent (like option 1) since GitHub is about doing work and less about who's-who. But I think it's a useful metric for like "social capital" when meeting new people.
I also really love the idea of moving the Follow into the action sheet. Remove the social aspects and keep it focused on "who is this person and what work do they do" vs social networking.
I know I'm kind of churning myself here, but once I saw design 1 and compared it w/ 2, I felt like 2 is too much Twitter/Instagram and less work.
Thoughts?

I also lean towards the professional aspect of 1 vs the social emphasis of 2 as @rnystrom.

I am more for the 1st option 😄. Points more “important” information regarding what the person is doing and who is this, rather than social networking (2nd one looks like Insta).
Additionally, I would suggest to leave the bio out and make more space for the pager info.
Also, I would have switched places between name/username and location/company/website. For me is more intuitive to see the name/username in the right side of the profile photo. (like the version that @BrianLitwin suggested above) 😊
Sent with GitHawk

@kocheck so cool that you’re spinning through all these edge cases!
Sent with GitHawk

Could the entire screen scroll so the tabs become a fixed  header when you scroll far enough? That would mean the entire bio would be visible on all tabs and that the entire screen can be filled with repos if needed.

@j-f1 That's what I am thinking. 👍
I might swape the Name/Username with the Location, company, and contact info again. Take advantage of the screen height.

Traveling for the holidays, and Had an idea while in the car yesterday. Mocked it up really quick this morning. How do ya'll feel about moving the profile over to the right?

The Info can flow down, as the user adds or removes more.
On iPad, would it cause issues to make the profile image bigger? Help fill that empty space on the right.

@kocheck I think that looks fantastic. Love the icon on the right. Makes the whole interface very legible.
Sent with GitHawk

This is awesome! Revisiting kochecks question the other week, I think he asked about pulse activity sharing github or appearing more custom, not sure if that was ever answered which way the team was leaning and curious myself...
Kocheck, would you envision activity being below pinned, as a fourth tab, an overflow option? Unlike followers which you guys realized was ultimately not a pivotal view, to me at least, activity is the most important view on a profile.

@ijm8710 I still need to look through the GitHub docs but if we can display that data I would love to drop it at the top of the Overview Tab. 👍
If we feel good about this as a solution, what would the best way to ship, or submit it to ya'll? A Zeplin project, or should I do a Pull request to the design repo with the updated sketch file?
Sent with GitHawk

Slick 🤩!!! @kocheck

@kocheck api.github.com/users/:user/events

@kocheck PR to design repo would be 👌
Sent with GitHawk

None of the images on this thread are up. Anyone have them and can upload them as a GitHub attachment?

Designs were merged into the master sketch file I believe @TigPT
https://github.com/GitHawkApp/Design-Resources

@TigPT Let me know if you need/want a different file type and I can export that out for you.

Designs were merged into the master sketch file I believe @TigPT
https://github.com/GitHawkApp/Design-Resources

And images are now loading, looks like it was a network problem on my side and I assumed wrongly that they are offline.
Thanks for pointing out to Design repo.

New designs coming? Excited!


149 remove issue template directory

:white_check_mark: Build GuiStracini.Mandae 8.0.293 completed (commit https://github.com/guibranco/GuiStracini.Mandae/commit/1b4981473e by @guibranco)


Remember me backend

Using cookies and with the help of JWT creating persistent user access feature.
Auto redirects to logged in page unless signed out.

Okay you can work on this


[Bug] Command line crashes during use, cannot be reproduced consistently.

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.

Describe the bug
convert llama2
lmdeploy convert --model-name llama2  --model-path /nvme/qa_test_models/llama2-chat-7b-w4  --model-format awq  --group-size 128 --dst_path ./workspacellama
start command line
lmdeploy chat turbomind ./workspacellama
While interacting through the command line, an exception occurred and the command line exited.
Reproduction
cannot be reproduced consistently.
Environment
sys.platform: linux
Python: 3.10.13 (main, Sep 11 2023, 13:44:35) [GCC 11.2.0]
CUDA available: True
numpy_random_seed:<PHONE_NUMBER>
GPU 0,1,2,3,4,5,6,7: NVIDIA A100-SXM4-80GB
CUDA_HOME: /usr/local/cuda-11.7
NVCC: Cuda compilation tools, release 11.7, V11.7.64
GCC: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
PyTorch: 2.0.1+cu117
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2023.1-Product Build 20230303 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v2.7.3 (Git Hash 6dbeffbae1f23cbbeae17adb7b5b13f1f37c080e)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 11.7
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86
  - CuDNN 8.5
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.7, CUDNN_VERSION=8.5.0, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wunused-local-typedefs -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Werror=cast-function-type -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_DISABLE_GPU_ASSERTS=ON, TORCH_VERSION=2.0.1, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF,

TorchVision: 0.15.2
LMDeploy: 0.0.14+
transformers: 4.33.2
gradio: 3.50.2
fastapi: 0.104.0
pydantic: 2.4.2

Error traceback
(baselineOld) [zhulin1@SH-IDC1-10-140-0-187 ~]$ lmdeploy chat turbomind ./workshopllama
WARNING: Can not find tokenizer.json. It may take long time to initialize the tokenizer.
[WARNING] gemm_config.in is not found; using default GEMM algo
session 1

double enter to end input >>> 你好 你叫什么名字

<BOS>[INST] <<SYS>>
 You are a helpful, respectful and honest assistant. Always answer as helpfully as possible, while being safe. Your answers should not include any harmful, unethical, racist, sexist, toxic, dangerous, or illegal content. Please ensure that your responses are socially unbiased and positive in nature.

If a question does not make any sense, or is not factually coherent, explain why instead of answering something not correct. If you don't know the answer to a question, please don't share false information.
<</SYS>>

你好 你叫什么名字 [/INST]  Hello! I'm here to help you with any questions you may have. My name is Assistant, and I'm here to provide helpful and respectful responses. Please feel free to ask me anything, and I will do my best to assist you.
As a responsible AI language model, I must ensure that my responses are socially unbiased and positive in nature. I will not provide any content that is harmful, unethical, racist, sexist, toxic, dangerous, or illegal. My purpose is to assist and provide accurate information, while always being safe and respectful.
If a question does not make any sense or is not factually coherent, I will explain why instead of answering something not correct. And if I don't know the answer to a question, I will politely inform you rather than providing false information.
So, please feel free to ask me anything, and I will do my best to assist you.

double enter to end input >>>  成都的景点

[INST] 成成都的景点 [/INST]  As a responsible AI language model, I must inform you that 成都 (Chengdu) is a city in China, and it does not have any scenic spots. However, Chengdu is known for its rich cultural heritage, delicious cuisine, and beautiful natural surroundings.
Some of the popular attractions in Chengdu include:
1. Giant Panda Research and Breeding Center: This is a must-visit attraction for any animal lover. The center is home to over 100 giant pandas, and visitors can observe these adorable creatures up close.
2. Wide and Narrow Alleys (铺街): This is a historic area in Chengdu that features a network of narrow streets and alleys. Visitors can explore the local culture and try various delicious street foods.
3. Jinli Street (锦里街): This is a popular shopping and dining street in Chengdu that offers a wide range of goods, from local handicrafts to high-end fashion.
4. Leshan Giant Buddha Scenic Area (乐山大佛景观): This is a UNESCO World Heritage Site located about 120 kilometers south of Chengdu. The area features a 71-meter tall stone Buddha statue that is carved into the side of a mountain.
5. Dujiangyan Irrigation System (都江堰): This is an ancient irrigation system that was built over 2,000 years ago. It is still in use today and is a testament to the ingenuity of ancient Chinese engineering.
I hope this information is helpful in planning your trip to Chengdu!

double enter to end input >>> 美食

[INST] 美食 [/INST]  Certainly! Chengdu is known for its rich culinary culture and spicy cuisine. Here are some popular dishes and foods to try in Chengdu:
1. Hot Pot (火锅): Hot pot is a popular dish in Chengdu that involves cooking various ingredients, such as meat, seafood, and vegetables, in a simmering pot of broth. The broth is usually spicy and flavorful, and the dish is often shared with friends and family.
2. Sichuan Noodles (川味面): Sichuan noodles are a staple dish in Chengdu that features a flavorful and spicy sauce made with chili oil, garlic, and ginger. The noodles are usually served with a variety of toppings, such as vegetables, meat, and eggs.
3. Kung Pao Chicken (宫保鸡): Kung Pao chicken is a famous dish in Chengdu that is made with crispy fried chicken, peanuts, vegetables, and chili peppers. The dish is spicy and flavorful, and it is often served with rice or noodles.
4. Mapo Tofu (麻婆豆腐): Mapo tofu is a popular dish in Chengdu that features a spicy and flavorful tofu sauce made with chili oil, garlic, and ginger. The dish is often served with a variety of toppings, such as vegetables, meat, and eggs.
5. Chengdu-style Roast Duck (成都烤鸭): Chengdu-style roast duck is a popular dish in Chengdu that features a crispy and flavorful duck that is roasted to perfection. The dish is often served with a variety of dipping sauces and sides, such as pancakes and scallions.
I hope this information is helpful in planning your culinary adventures in Chengdu!

double enter to end input >>> end

double enter to end input >>> 美食
Traceback (most recent call last):
  File "/home/zhulin1/miniconda3/envs/baselineOld/bin/lmdeploy", line 8, in <module>
    sys.exit(run())
  File "/home/zhulin1/miniconda3/envs/baselineOld/lib/python3.10/site-packages/lmdeploy/cli/cli.py", line 135, in run
    fire.Fire(cli, name='lmdeploy')
  File "/home/zhulin1/miniconda3/envs/baselineOld/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/zhulin1/miniconda3/envs/baselineOld/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/zhulin1/miniconda3/envs/baselineOld/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/home/zhulin1/miniconda3/envs/baselineOld/lib/python3.10/site-packages/lmdeploy/cli/chat.py", line 85, in turbomind
    run_turbomind_model(model_path,
  File "/home/zhulin1/miniconda3/envs/baselineOld/lib/python3.10/site-packages/lmdeploy/turbomind/chat.py", line 106, in main
    prompt = input_prompt(model_name)
  File "/home/zhulin1/miniconda3/envs/baselineOld/lib/python3.10/site-packages/lmdeploy/turbomind/chat.py", line 30, in input_prompt
    return '\n'.join(iter(input, sentinel))
UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 0-1: invalid continuation byte

According to the log, the last prompt "美食" cannot be decoded by "utf-8" codec.
When you input the prompt, did you use backspace to delete or modify the prompt?

thanks, I think it's not a valid bug.


Razor Syntax

Type: Bug
It seems like VSCode doesnt know how to read Razor syntax, which is weird since Microsoft developed razor/blazor... Jetbrains Rider seems to get this 100%, colors for semantic/syntax highlighting work accurately. How is this possible? Even the default themes dont correct this? No extensions to fix this?

@ArmantG can you share a copy/pastable snippet that I can use to reproduce the issue you're seeing?

The screenshots show the initial template used to create a new .net6 blazor wasm (not hosted) project. So essentially the stock project created when starting a new blazor wasm app. No code added, just standard boilerplate code from project template.
.net6, blazor wasm, not hosted, created using visual studio 2022 for mac.

So weird that github managed to add some syntax to that bit of code.
this is cobalt2 theme in vscode:

Thanks for the snippet. We used to get our Razor syntax highlighting grammar from https://github.com/demyte/language-cshtml but that repository is gone. I'll take this as a feature request to find another Razor grammar to use.

Thanks. Sad to see that this issue has been around for more than 3 years... Not holding my breath for a solution here as this doesnt seem to be particularly high on anyone's to-do list... But here's hoping something comes from this.
Best solution now is to use JetBrains Rider until this is sorted.

Let's see if there's any object to https://github.com/OmniSharp/omnisharp-vscode/issues/5404.

Best solution now is to use JetBrains Rider until this is sorted.

Is there not a Razor syntax highlighter extension on the marketplace?

None I could find. Googling it also pointed me towards one extension that hasnt been worked on in 4 years and was useless. But it should really be a vscode feature don't you think? Microsoft should at least have support for their products in their own code editor? 🤣 Anyway, it will get figured out I'm sure.

Verified through integration tests.


Ligatures?

I'd love to use this font in VS Code and one of the great features to have for it is ligatures.
Example:
https://hilton.org.uk/blog/fira-code.svg

示例：dapingtai4455.com

I'm working on to export the font to OTF, maybe you can use it with the actual font file.

@elijah-penney why would you want to use it as a code editor font? A good editor font is mono-spaced. Leonsans is not.
@cmiscm freaking love the project! Good work!


Fixed issue #402

fixes #402 by adding rounded-md to both the elements

Summary by CodeRabbit

Style

Improved code formatting for better readability, including adding semicolons and fixing indentation.

Refactor

Updated the Leaderboard component with enhancements to the ShareModel theme property for a more consistent user interface.

Thank you for fixing it 🚀


Problems with INLA installation

Hi
I have a problem installing the INLA package. I get the following error:
_* installing binary package 'INLA' ...
cp: unknown option -- )
Try '/usr/bin/cp --help' for more information.
ERROR: installing binary package failed

removing 'C:/Program Files/R/R-4.0.2/library/INLA'
Warning in install.packages :
installation of package ‘INLA’ had non-zero exit status
The downloaded source packages are in
‘C:\Users\U80864263\AppData\Local\Temp\Rtmp69tlBB\downloaded_packages’_

I used the following command to try to install it:
install.packages("INLA", repos=c(getOption("repos"), INLA="https://inla.r-inla-download.org/R/stable"), dep=TRUE)
In the given path (......\downloaded_packages), there is an INLA_21.11.22.tar.gz file (81.7 Mb).
Do you know how I could solve this problem?
Best wishes

try again after upgrading to R-4.1
On Fri, 2022-01-21 at 06:41 -0800, LilianeTrafelet wrote:

Hi
I have a problem installing the INLA package. I get the following
error:
* installing binary package 'INLA' ...
cp: unknown option -- )
Try '/usr/bin/cp --help' for more information.
ERROR: installing binary package failed
 * removing 'C:/Program Files/R/R-4.0.2/library/INLA'
   Warning in install.packages :
   installation of package ‘INLA’ had non-zero exit status
   The downloaded source packages are in
   ‘C:\Users\U80864263\AppData\Local\Temp\Rtmp69tlBB\downloaded_packag
es’
I used the following command to try to install it:
install.packages("INLA", repos=c(getOption("repos"),
INLA="https://inla.r-inla-download.org/R/stable"), dep=TRUE)
In the given path (......\downloaded_packages), there is an
INLA_21.11.22.tar.gz file (81.7 Mb).
Do you know how I could solve this problem?
Best wishes
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this
thread.Message ID: @.***>

--
Håvard Rue
Professor of Statistics, CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900, Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
Zoom.office: Meeting ID<PHONE_NUMBER>

Hi
Thanks for your quick response
The issue is that I have to use the same R version as my collegues. However, they were able to install INLA with without issues using the same R version as me.

R-4.0 and R-4.1 should just be a minor upgrade. we do not build INLA for
R-4.0 anymore, so you might run into R-issues as well at some point
using R-4.0
On Fri, 2022-01-21 at 07:26 -0800, LilianeTrafelet wrote:

Hi
Thanks for your quick response
The issue is that I have to use the same R version as my collegues.
However, they were able to install INLA with without issues using the
same R version as me.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics, CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900, Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
Zoom.office: Meeting ID<PHONE_NUMBER>


Init Role, RoleClassPermission and RoleInstancePermission models

This adds the client handling for the newly added models and interfaces in #872.

Thanks for the review!


Remove 'Redact' option in Redaction Pane

Description
This is similar to #3506.
The 'Redact' option needs to be removed from the Redaction Pane, as it permanently applies a redaction, which may cause issues. This appears to be an OOTB feature, which is sufficiently addressed by the existing 'Add Mark' option.
In addition, 'Add Mark' can be renamed to 'Add Redline'.
In order to replicate this:

Go to the redaction app through a request which has records in the Records tab
Click on the Redaction Pane under 'Redact'
In the Redaction Pane, in the search field stating "Add by keyword search or patterns",  search for a keyword that appears in the record/request - you will notice 'Redact' appears as a greyed out option
When results appear, click the checkbox next to one or more of the keyword occurrences
See the 'Redact' option become available

Dependencies
Are there any dependencies?
DOD

[ ] 'Redact' option removed
[ ] 'Add Mark' renamed to 'Redact'.

The Redact button out-off-the box is irreversible and cannot be undone, so we want to remove this.
Add Mark is what we need to apply a section of the Act for redaction. Change 'Add Mark' to 'Redact'

Refinement comments

Redact button can be hidden
Add Mark will be updated to a text that business decides ( Add Red line~)

Unfortunately Add Mark text cannot be updated. That button is dynamically generated every time a user puts focus into the redaction search bar, so we cannot set the text on page load. It is also not possible to add a focus event handler to the search bar because it is not a simple input, rather it is a custom element made of divs. There is also no existing pdftron event for on focus for the search bar.

decreasing estimate to 1 becuase we only hide the redact button

Resolved


Adding support for installing pip packages using conda-docker

@costrouc Can you review this when you are back. Or @pierrotsmnrd  or @aktech can one of you have a look.
@PhilipNeffOnGithub sorry for the delayed response.

@PhilipNeffOnGithub I appreciate you opening this PR! Apologies for being on parental leave. I see that this PR depends on https://github.com/conda-incubator/conda-docker/pull/20 so I will look into that one first. On first pass thanks so much for this work. It will be a huge add to have support for pip within the docker images.

Hey @PhilipNeffOnGithub I'll need to look at https://github.com/conda-incubator/conda-docker/pull/20 before merging this PR. It may take me awhile to review this PR.

This has been opened for almost two years with no movement. I will go ahead and close this PR and we can reopen or open a new one if there is need to add this.


[Python][* DateTimeV2] Fix detection of "00:XX" in Python

The hour value "00" is not resolved in Python.
Test cases added to DateTimeModel.

Hello @tellarin, could you please review this and merge #3081 since it has already been approved? Thank you!


Update dependencies to fix deprecation warnings

Example output: https://github.com/OpusCapita/react-crudeditor/issues/179

Done.


Exceptions::fake() not working after upgrading from Laravel v8 to v11

Laravel Version
11.11.1
PHP Version
8.2.18
Database Driver & Version
No response
Description
I'm trying to use new feature Exceptions::fake(), but it just ignored. Not in HTTP tests, but in integration ones.
I've double checked that Concerns\InteractsWithExceptionHandling trait is exists in base test case class.
After upgrade I haven't migrated app to the new slim structure as it stated in upgrade guide:

However, we do not recommend that Laravel 10 applications upgrading to Laravel 11 attempt to migrate their application structure, as Laravel 11 has been carefully tuned to also support the Laravel 10 application structure.

Steps To Reproduce
This test is working well:
public function testWorking(): void
{
    $this->expectException(\DomainException::class);
    $this->expectExceptionMessage(
        "The order was invalid.",
    );

    app(OrderService::class)->process(
        123,
    );
}

This test is failing because it's not handling exceptions:
public function testNotWorking(): void
{
    Exceptions::fake();

    app(OrderService::class)->process(
        123,
    );

    Exceptions::assertReported(function (\DomainException $e) {
        return $e->getMessage() === 'The order was invalid.';
    });
}

This one is not working too:
public function testNotWorkingToo(): void
{
    $exceptions = Exceptions::fake();

    app(OrderService::class)->process(
        123,
    );

    $exceptions->assertReported(function (\DomainException $e) {
        return $e->getMessage() === 'The order was invalid.';
    });
}

Heya, thanks for reporting.
We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here? Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.
laravel new bug-report --github="--public"

Please do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.
Thanks!

I'm not sure it will reproduce on v11 from scratch, I need to create v10 or below and upgrade it first

We’ll need to figure out what’s missing from the upgrade guide if this isn’t working for you. Please indeed provide a repo and commit the upgrade steps separately

I don't think it works in the way you expect. If you don't call a route it does not go through the exception handling pipeline and you have to specify on the test what exception you're expecting because it's not a framework exception but a direct call to a service/class etc.. For this to work outside of the routes, the framework would most likely need to override the PHPUnits test running as the exception you see in the console is handled by the try/catch in the PHPUnit side and the exception/error does not reach the application exception handler.

In short, you cannot do this:
    public function testNotWorkingToo(): void
    {
        Exceptions::fake();

        throw new \DomainException('The order was invalid.');

        Exceptions::assertReported(function (\DomainException $e) {
            return $e->getMessage() === 'The order was invalid.';
        });
    }

and expect that the exception magically gets silenced/swallowed.

Thanks @donnysim

Hello guys!
I'm using latest laravel 11 as fo date of writing, and I still get the same Exceptions::fake() problem in unit tests.
This is the error I get when the test fails:
Illuminate\Support\Testing\Fakes\ExceptionHandlerFake::__construct(): Argument #1 ($handler) must be of type Illuminate\Contracts\Debug\ExceptionHandler, null given, called in /var/www/html/vendor/laravel/framework/src/Illuminate/Support/Facades/Exceptions.php on line 54


Replaced firstChild with children[0] in findParent.

This will ensure that the first node will be returnd unlike FirstChild which searches text+nodes.

If the HTML that is being processed has text/linebreaks between the tags the firstChild/childNodes will contain the text in the property array. The children property will only return nodes and not the text.

Done! Thanks for the PR


Make the app work with other instances of Moodle

Hello
I was wondering if it will be possible to make this app a bit more generic so it works with other instance of Moodle. I'm have been using a fork but it is buggy and crashes a lot and has not been updated in a while.
Thanks for great app!

Glad to hear that! and thanks for your effort I would really like to try it out .

@abhijeetviswa can we please start working on this front?


Archived Channels reappears on v1.47.1 (Build 375)

Summary
After having upgraded Mattermost, channels archived long time ago are showing again. Such channels are only showing on mobile and not visible on the desktop/web application, as expected.
By clicking on it, the mobile client confirms that the channel is an archived one (see screenshot below):

Environment Information

Device Name: Apple iPhone 12
OS Version: iOS 14.8
Mattermost App Version: 1.47.1 (Build 375)
Mattermost Server Version: 6.0.0

Steps to reproduce

Archive a channel on Mattermost (desktopor web).
Open the Mattermost mobile client
Notice the archived channel showing,

Expected behavior
Having the archived channel hidden.
Observed behavior (that appears unintentional)
//
Possible fixes
//

There has been many changes about this in the last year, and I guess this should be solved in V2. @acataluddi if you are still seeing this issue with the latest beta (V2), feel free to reopen the ticket.

Thank you @larkox, great support!


GDB injection make the game crash since last game update

Impossible to inject anymore, The gdb process is fine, but the game process crash after a few seconds.
I guess the injection method has been patched ?

gdb injection method casuses segmentation fault. But other linux injection tools works normal.
warning: Currently logging to gdb.txt.  Turn the logging off and on to make the new setting effective.

Thread 33 "cs2" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fe299fff6c0 (LWP 6374)]
0x00007fe2a1db6030 in ?? ()
The program received a signal in another thread while
making a function call from GDB.
Evaluation of the expression containing the function
(dlopen) will be abandoned.
When the function is done executing, GDB will silently stop.
[Inferior 1 (process 6320) detached]

https://github.com/danielkrupinski/Osiris/issues/4334


Can't focus TextField inside a TabBarView using VoiceOver gestures

Steps to Reproduce
See this gist with bug reproduction.

Create a widget wrapping TextField within a TabBarView.
Install your app on an iOS device.
Enable VoiceOver.
Use a11y gestures to navigate to the TabBarView content. You should hear a TextField announcement with "double tap to edit" spoken out.
Double tap.

Observed bug: Nothing changes - text field is not activated, focus doesn't change. You are also unable to focus on the text field itself.
Target Platform: iOS
Target OS version/browser: 13.1.2
Devices: iPhone XR
The bug occurs in both debug and release modes.
Logs
logs.txt
$ flutter analyze
Analyzing tab_bar_view_semantics...
No issues found! (ran in 4.4s)

$ flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.14.6 18G103, locale en-PL)
    • Flutter version 1.9.1+hotfix.6 at /Users/kpsroka/Library/flutter
    • Framework revision 68587a0916 (10 weeks ago), 2019-09-13 19:46:58 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/kpsroka/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.1, Build version 11A1027
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 40.0.2
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.40.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.6.0

[✓] Connected device (1 available)
    • Krzysztof’s iPhone • 00008020-000D544E1AF9002E • ios • iOS 13.1.2

Hi @kpsroka,
Can you please confirm if you still experience this issue on latest Flutter channel (eg: dev, master) ?

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Swin Transformer with different input size

Discussed in https://github.com/rwightman/pytorch-image-models/discussions/1137

Originally posted by mt-cly February 10, 2022
Hi, thanks for your great work.
The Swin Transformer seems to throw an error if the input x does not satisfy the size requirement of x.W%window_size==0 and x.H%window_size==0. I wonder if it is convenient to add some code to pad some zero pixels to the input x so that images with various sizes can be directly taken as the input of Swin Transformer.
Thank you.

@mt-cly I don't think that's a good idea, adds far more complexity (and potentially much higher impact on the result) than just resizing or padding your input image to fit the constraint... pretty much all of the vision transformers or hybrids have constraints on the image size due to windowing, position embeddings, etc

Hi, thanks for your reply. I notice that in the original paper of swin transformer, the input image is crop to 512 at the ADE20K fine-tune stage which is not satisfy the requirement. To solve this, the official implementation support the padding (refer to https://github.com/SwinTransformer/Swin-Transformer-Semantic-Segmentation/blob/main/mmseg/models/backbones/swin_transformer.py#L214). That's the reason to arise this issue.

您好，感谢您的回复。我注意到，在swin transformer的原始论文中，输入图像在ADE20K微调阶段被裁剪为512，这不符合要求。为了解决这个问题，官方实现支持填充（参考 https://github.com/SwinTransformer/Swin-Transformer-Semantic-Segmentation/blob/main/mmseg/models/backbones/swin_transformer.py#L214）。这就是出现这个问题的原因。

hello！  请问如何timm 对ADE２０Ｋ　数据集进行训练呢？


Cherry-pick #103 into v2.12.x

Signed-off-by: Niladri Halder<EMAIL_ADDRESS>This cherry-picks the following into v2.12.x branch:

#103

Codecov Report

Merging #104 (4ca5314) into v2.12.x (2df21b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v2.12.x     #104   +/-   ##
========================================
  Coverage    33.99%   33.99%
========================================
  Files           29       29
  Lines         2518     2518
========================================
  Hits           856      856
  Misses        1618     1618
  Partials        44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df21b0...4ca5314. Read the comment docs.


Private DNS Resolver subnet doesn't Support NSG Flow Log

Private DNS Resolver subnet doesn't Support NSG Flow Log. Need to update the document.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b312425f-a486-6c4b-9608-cca8ccd30937
Version Independent ID: 1d306c78-99e8-8f2c-d0f3-1aa5bf60d794
Content: What is Azure DNS Private Resolver?
Content Source: articles/dns/dns-private-resolver-overview.md
Service: dns
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@oaas This is being tracked in https://github.com/MicrosoftDocs/azure-docs/issues/106306. We shall close this as duplicate.
Should you have any further queries, please do let me know and I shall reopen the thread


Update Composer dependencies (2021-12-05-00-07)

Visual regression test passed!
View the visual regression test report


[future request](Python package)

Make it a python package (reference: https://github.com/tomchen/example_pypi_package) and upload to pypi so it is installable using pip install package_name

@ZilvinasSP any information on why this got closed?

@kaliiiiiiiiii Hey, I've closed this issue because it's been a while, and I wasn't sure if it was still relevant. We do not plan to make a Python package for this code, as it's simply an example of how our proxies can be integrated with Selenium. If it's still relevant, let me know and I'll see what I can do.


Deploy Free Open-Source LLM on OpenShift for Backend Operations

Objective: Deploy a free open-source LLM through OpenShift to power RAG and other LLM-enhanced features.
Details:
•	Select a free OS LLM (e.g., LLaMA 3.1).
•	Configure and deploy the model as a service on OpenShift.
•	Ensure it supports RAG and advanced query functionalities.
•	Test integration with other backend components.
Dependencies: OpenShift environment setup and LLM-based application integration.
Acceptance Criteria:
•	LLM deployed and operational on OpenShift.
•	Successful LLM calls from backend applications, supporting RAG.
Priority: High
Estimated Effort:

Currently blocked due to resource limitations in OpenShift.


Create 'Oculus' topic.

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

The oculus topic has well over 100 repositories, and I am surprised that there is not already a topic for it.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks again @Colack!


Make it so non-logged in users can see glossary.

Next installment in my series of one-line PRs!
The glossary is so rarely used I believe this cannot possibly cause a drain on performance.  Since I think at least some visitors encountering pages that require login are finding MO to be unwelcoming, it doesn't seem worth doing so for the glossary.  Site stats?  User summaries?  Yes, those are expensive pages, I'm fine with requiring login.  But the glossary is different.
Feel free to disagree and veto this PR.  It's not like I worked hard on it. :)

Coverage remained the same at 92.633% when pulling 6251cad775b3a380efb70018d62ca5bce99869c2 on make-glossary-public into f80915209ced972848b107323ead4c5d2700573c on master.

Oh wow, good point, Joe.  Then let's add paging to the index before accepting this PR.  (I'll do it when I have time.  It will probably be several weeks.  This is especially busy time for me.)

Closing this in favor of a new one that does the same thing, this seemed daunting to bring up to date.


fix Fix BE memory info compatible with Cgroup

Proposed changes

memory.usage_in_bytes ~= free.used + free.(buff/cache) - (buff), free cache can be reused,
so, modify cgroup_memory_usage = memory.usage_in_bytes - memory.meminfo["Cached"].
If system not configured with cgroup, find cgroup file path will failed, refactor refresh cgroup memory, compatible with it.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Open Hardware Monitor is not maintained anymore

Open Hardware Monitor is not maintained anymore. The last release was published on Dec 27, 2020. However, there are a few forks available, that can be used instead. The most promising fork seems to be Libre Hardware Monitor.
I haven't seen any breaking changes, so it can be used in the same way as Open Hardware Monitor with jPowerMonitor.
Therefore, I want to propose to replace Open Hardware Monitor with Libre Hardware Monitor in the documentation.

Thanks a lot for the reference to Libre Hardware Monitor.
We weren't aware about this and are glad to be able to recommend an open source tool again.


Configure buttons mapping

Make a tool to configure keyboard and gamepad buttons mapping.
Save the mapping settings in local storage.

created a simple tool to configure keyboard buttons
use keymap command to run it

done in .24

Very cool and useful.  For example you could do another one for editing the color palette in really time, and have buttons for saving the palette as system or game specific if your current game is loaded.


[FT] Build, upload and clean

Summary of changes:

Finished build, upload and clean
CLion custom targets work properly now
Organized the code a bit more

Aight gonna do a comprehensive review of this one. We should figure out how to add unit tests at some point (or just really indepth travis builds)

@Mogball can you debug the issue with the upload bug you getting? I do not have any issue on my side

Yeah sure

I also noticed that the port is cached in the config file. This definitely should not be done because the config file is shared between environments and the port in the config isn't updated. upload should always do the port autodetect.

When calling get_wcosa_path in upload_wcosa the correct value is returned, however when upload_wcosa calls update_wcosa and the latter calls get_wcosa_path an incorrect value is returned.
I think the way we access the templates path needs to be reconsidered. I'll look more into the package_data stuff tomorrow to see if there's a way this can be added to the environment. (sys.env)

Port should not be cached so this may be a bug. However, if you type a port in the config.json, that port will be used because it assumes that you are overriding the port. If you remove that port from there, then the port is automatically selected. If a port is provided through command line then it overrides everything.

We have to fix these paths, it is kinda annoying why they are different. They work fine for me so yeah we definitely need a better way

I'll see if I can mess around with them a little bit

@dhillondeep
I was able to fix my path issue by doing
from os.path import dirname, abspath

def get_wcosa_path():
    wcosa_path = dirname(abspath(__file__))
    return linux_path(dirname(dirname(wcosa_path)))

Feels a bit weird what with all the dirname calls. Let me know if this works on your system.

@Mogball I will give it a try hold up


EXPID parameter repeated in many sections in the expdef.conf configuration view

In GitLab by @mcastril on Oct 19, 2022, 11:49
As explained in https://earth.bsc.es/gitlab/es/autosubmit/-/issues/856#note_182082
EXPID is repeated in all sections in the expdef.conf view:
Example:
https://earth.bsc.es/autosubmitapp/experiment/a55z
@cgonzal6 @jberlin @dbeltran

In GitLab by @jberlin on Oct 20, 2022, 11:34
Let´s add this one to the milestone as well since it is an easy one

In GitLab by @jberlin on Nov 10, 2022, 15:05
Validated in development VM

In GitLab by @cgutierr on Oct 20, 2022, 10:07
Did not see this issue.
Just checked a bit and the problem is on the API, It should be easy to fix.

In GitLab by @cgutierr on Oct 24, 2022, 11:17
This has been solved on the API side.


when column-count is greater than 1 should the @click:time event pass index?

Is this a quastion or an observation? I need more details. Thanks.

Sorry for my bad english. It is a question.
The vue event 'click:day' pass an object with those properties:
{date, time, year, month, day, hour, minute, weekday, doy, workweek, hasDay, hasTime, past, current, future, disabled, index }
The vue event 'click:time' pass an object with these instead:
`{ date, time, year, month, day, hour, minute, weekday, doy, workweek, hasDay, hasTime, past, current, future, disabled }
since 'columnCount' is greater than 1, should he also pass index?

in this example when I click on an interval i got an object without index

Thanks for pointing this out. I'll take a look as soon as I am able.

Fixed in v1.0.3


Rename ClassProperty.key instead of deleting it

The no-undef rule uses escope which blindly looks for a key attribute in order to know if something is in scope. Right now the fix is to delete the key attribute but I need it for a rule I'm writing at Facebook. Instead of deleting it, just renaming it to _key works.
For context, the rule I'm writing is checking if a bound function using property initializer is not needed. We're going to use this for our React.createClass to es6 class migration in Facebook codebase.
Test Plan:
All the tests run fine.

Fixes one of the issues in https://github.com/babel/babel-eslint/issues/307

Yeah sounds good. Could also figure out another way but this is a good workaround. We did a similar thing for the type as well with  node._babelType = node.type;
Maybe generalizing that for other things that were deleted with a prefix would be useful as well

Happy to rename it to _babelKey and/or making it a bit more generic to handle all the things we delete in this file. Let me know what you want me to do :)

Do you think _babelKey is more clear? I think either is ok. Also not sure why its only failing on < node 4

I honestly don't care how it is named as long as I can read it :)

Let me look at the errors

I was at some point going to check if https://github.com/zertosh/eslint-plugin-flow-vars covered class properties since then we could drop all the escope stuff for flow vars and not have to change the AST as much

Hmm weird, they are passing on my laptop with node 4. I force pushed to re-run travis

cc @zertosh :)

I think we can have another PR to add the other ones. like ._async or something or some other way to specify things that had to be removed. Although maybe that should be discussed since we are modifying the AST and we'll need to keep it in for compatibility moving forward

I can repro the errors on node 0.10, looking

I checked out the pr locally and looks like the tests pass for me on 0.10

Did you also regenerate all the node_modules?

I see it fails when npm install on node 0.10 so it sounds like something weird with npm 2 to me

Grrr, so the scope thing actually doesn't care about the name of the attribute, it checks for all the nodes of type "Identifier" and checks for node.parent.type but there's no parent in the babylon node so it fatals.
If I do
node._getKey = function() { return node.key; }

then it doesn't crash...

Let me know what you suggest I should do :)

Maybe we could mark all ClassProperty as defined and not delete the key

Sounds like a plan, is there some existing code that mark nodes as being defined I can base on, I'm very new to this whole codebase.

Yeah for sure (wasn't expecting you to do it 😄)

I'm ready to do whatever is needed to get this shipped :) Thanks a lot for all your help so far, I really appreciate

Now that I think about it, most of the code does the visiting to mark it as used rather than mark it as defined.
I think we would basically to the same thing as the flow plugin https://github.com/zertosh/eslint-plugin-flow-vars/blob/master/define-flow-type.js
Ah I remember we did it for https://github.com/babel/babel-eslint/blob/master/index.js#L319-L330

Or I could join reactiflux
I think I got it
// in visitClass
var classBody = node.body.body;
for (var a = 0; a < classBody.length; a++) {
      if (classBody[a].type === "ClassProperty") {
        createScopeVariable.call(this, classBody[a], classBody[a].key);
      }
    }

Okay, looks like you are making much more progress than I am :p

Should probably write another test but https://github.com/babel/babel-eslint/pull/336/files

Either way there's a similar issue with the other ones
    // async function as generator
    if (path.isFunction()) {
      if (node.async) node.generator = true;
    }

super awkward since it's obviously not a generator

Maybe we can simplify a lot of this by cloning the original babel Node an having an accessor for it.

Yeah possibly; For async/await I was thinking maybe we don't transform them and just create a new rule for the broken rules in eslint-plugin-babel.


fix(rollup-relayer): check batch version before committing

Purpose or design rationale of this PR
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[x] fix: A bug fix

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.58%. Comparing base (19b8230) to head (e6baa9d).

Files with missing lines
Patch %
Lines

rollup/internal/controller/relayer/l2_relayer.go
0.00%
3 Missing and 1 partial :warning:

Additional details and impacted files
@@                             Coverage Diff                             @@
##           feat-rollup-relayer-remove-legacy-logic    #1562      +/-   ##
===========================================================================
- Coverage                                    52.60%   52.58%   -0.02%
===========================================================================
  Files                                          157      157
  Lines                                        12402    12406       +4
===========================================================================
  Hits                                          6524     6524
- Misses                                        5319     5322       +3
- Partials                                       559      560       +1

Flag
Coverage Δ

rollup
58.85% <0.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Energy Performance Certificates - Domestic Buildings Search API

Good morning team,
At Santander bank, we are working on a new functionality that will allow our customers to see the EPC for their houses. In order to provide this functionality, we are planning to use the public apis from gov.uk.
These apis cover almost the 100% of the functionality requested by the product owner of the project. However, we are missing the following information:
Assessor’s name (company who originally generated the EPC)
Assessor’s details
Further description of proposed home improvements to make the house more efficient in terms of energy.
Are you planning to include the above information at any point in the future? Otherwise, do you know if this information is available in any public database, so we can maybe access to the data using any key reference of the certificate obtained from the public apis from gov.uk?
Thanks.
Regards.

Hello again,
I would like to know also, if there is a way to obtain the certificate number from the lmk-key.
Thanks.
Regards.

Hi Jaime - unfortunately we don't have that information - I suggest you try the API documentation at https://epc.opendatacommunities.org/docs/api/domestic#domestic-search in the first instance.


Consider adding this project to blessed.rs list

Just a suggestion: add this project to the list of CLI crates in Blessed.rs

Pending for #97
Related: https://github.com/nicoburns/blessed-rs/issues/72

Closed as ratatui how now been added to blessed-rs ! 🍾


Review: Navbar and Footer

Overview
We are going to review the Navbar and Footer pages.
Review Branch
Review-19
Files to review
File 1: Navbar
File 2: Footer
Checklists
Architecture
Design
JS
React
Due date
10/02/24
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414f24/morea/review/reading-idpm-review.html

File 1: navbar
Lines 9-34: lines are not up to date. still uses the template term 'stuff'
File 2: footer
Should add another column redirecting to inspire home page and contact info

File 1:
Lines 29-31 Change the "id" of the Nav.Link's, "list-stuff-nav" does not exist.
File 2:
Lines 24 & 45 Remove "Template Home Page" and the href

File 1: change the IDs for the navbar elements
File 2: Change the template homepage to our homepage or remove it alltogether

File 1: change the IDS, change/update theme
File 2: change/update theme

File 1: Update ID names to coding standards
File 2: Improve Home page formatting

File 1: update theme
File 2: add more info about the company

Review Meeting Outcome
File 1: Form Page

Scrolling: Distribute form into columns to reduce scrolling.
Line 7: Update FormData to "input data" for future scalability.
Modularity: Refactor into reusable components.
Component Breakdown: Split larger components for readability.
Grouping Fields: Group similar fields for better UX.
Lines 72 & 142: Fix spelling from "Assest" to "Asset".

File 2: Logo and Image Handling

Line 9: Set alt attribute to empty for decorative images.
Lines 14-24: Split lines for readability.
Logo Naming: Clarify logo name to avoid confusion.
Form Robustness: Add images for completeness.


Mac_ios platform_views_scroll_perf_ios crashes.

The framework tree is currently red on an Engine roll here https://github.com/flutter/flutter/pull/99459.
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios platform_views_scroll_perf_ios__timeline_summary/3818/overview
It looks like the main thread is crashing in a call to GrMtlIsAppInBackground().
The Engine roll contains a clang roll. I will revert the Engine roll, stop the Engine rollers, and then speculatively revert the clang rolls if the framework tree returns to green.

@chinmaygarde @jason-simmons @gaaclarke for more eyes on the backtrace.

@gaaclarke Can you ptal and check whether there's any chance this is caused by https://github.com/flutter/engine/pull/31720?

Yea here is the stacktrace:
Process 1404 stopped
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSEGV
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #0: 0x000000010595eb6c Flutter`GrMtlIsAppInBackground() + 72
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] Flutter`GrMtlIsAppInBackground:
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] ->  0x10595eb6c <+72>: ldr    x1, [x8, #0x420]
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     0x10595eb70 <+76>: bl     0x105da0018               ; symbol stub for: objc_msgSend
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     0x10595eb74 <+80>: cmp    x0, #0x2                  ; =0x2
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     0x10595eb78 <+84>: cset   w20, eq
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] Target 0: (Runner) stopped.
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] thread backtrace all
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ] process detach
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [  +77 ms] * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSEGV
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]   * frame #0: 0x000000010595eb6c Flutter`GrMtlIsAppInBackground() + 72
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #1: 0x000000010594dfb8 Flutter`GrMtlCommandBuffer::getRenderCommandEncoder(MTLRenderPassDescriptor*, GrMtlOpsRenderPass*) + 44
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #2: 0x0000000105953498 Flutter`GrMtlGpu::onGetOpsRenderPass(GrRenderTarget*, bool, GrAttachment*, GrSurfaceOrigin, SkIRect const&, GrOpsRenderPass::LoadAndStoreInfo const&, GrOpsRenderPass::StencilLoadAndStoreInfo const&, SkTArray<GrSurfaceProxy*, true> const&, GrXferBarrierFlags) + 736
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #3: 0x00000001058eafc0 Flutter`skgpu::v1::OpsTask::onExecute(GrOpFlushState*) + 1252
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #4: 0x000000010585093c Flutter`GrDrawingManager::flush(SkSpan<GrSurfaceProxy*>, SkSurface::BackendSurfaceAccess, GrFlushInfo const&, GrBackendSurfaceMutableState const*) + 4452
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #5: 0x0000000105851598 Flutter`GrDrawingManager::flushSurfaces(SkSpan<GrSurfaceProxy*>, SkSurface::BackendSurfaceAccess, GrFlushInfo const&, GrBackendSurfaceMutableState const*) + 164
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #6: 0x000000010571715c Flutter`SkCanvas::onFlush() + 72
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #7: 0x00000001056f6708 Flutter`flutter::IOSExternalViewEmbedder::SubmitFrame(GrDirectContext*, std::__1::unique_ptr<flutter::SurfaceFrame, std::__1::default_delete<flutter::SurfaceFrame> >) + 1256
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #8: 0x0000000105a90190 Flutter`flutter::Rasterizer::DrawToSurfaceUnsafe(flutter::FrameTimingsRecorder&, flutter::LayerTree&) + 964
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #9: 0x0000000105a90a98 Flutter`std::__1::__function::__func<flutter::Rasterizer::DrawToSurface(flutter::FrameTimingsRecorder&, flutter::LayerTree&)::$_8, std::__1::allocator<flutter::Rasterizer::DrawToSurface(flutter::FrameTimingsRecorder&, flutter::LayerTree&)::$_8>, void ()>::operator()() + 28
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #10: 0x00000001059b74ac Flutter`fml::SyncSwitch::Execute(fml::SyncSwitch::Handlers const&) const + 52
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #11: 0x0000000105a8fc9c Flutter`flutter::Rasterizer::DrawToSurface(flutter::FrameTimingsRecorder&, flutter::LayerTree&) + 272
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #12: 0x0000000105a91b3c Flutter`std::__1::__function::__func<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_2, std::__1::allocator<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_2>, void (std::__1::unique_ptr<flutter::LayerTree, std::__1::default_delete<flutter::LayerTree> >)>::operator()(std::__1::unique_ptr<flutter::LayerTree, std::__1::default_delete<flutter::LayerTree> >&&) + 160
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #13: 0x0000000105a90d9c Flutter`flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>) + 644
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #14: 0x0000000105a917a8 Flutter`std::__1::__function::__func<fml::internal::CopyableLambda<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_0>, std::__1::allocator<fml::internal::CopyableLambda<flutter::Rasterizer::Draw(std::__1::unique_ptr<flutter::FrameTimingsRecorder, std::__1::default_delete<flutter::FrameTimingsRecorder> >, std::__1::shared_ptr<flutter::Pipeline<flutter::LayerTree> >, std::__1::function<bool (flutter::LayerTree&)>)::$_0> >, void ()>::operator()() + 220
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #15: 0x00000001059b5d70 Flutter`fml::MessageLoopImpl::FlushTasks(fml::FlushType) + 1612
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #16: 0x00000001059b98d8 Flutter`fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*) + 32
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #17: 0x0000000185b99fcc CoreFoundation`<redacted> + 28
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #18: 0x0000000185b24338 CoreFoundation`<redacted> + 1016
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #19: 0x0000000185b1efcc CoreFoundation`<redacted> + 324
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #20: 0x0000000185afeea4 CoreFoundation`<redacted> + 1948
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #21: 0x0000000185b11d7c CoreFoundation`CFRunLoopRunSpecific + 572
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #22: 0x000000019fd869a0 GraphicsServices`GSEventRunModal + 160
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #23: 0x000000018834405c UIKitCore`<redacted> + 1080
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #24: 0x00000001880d9ce0 UIKitCore`UIApplicationMain + 2028
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #25: 0x00000001041bf4fc Runner`main(argc=<unavailable>, argv=<unavailable>) at main.m:11:16 [opt]
[platform_views_scroll_perf_ios__timeline_summary] [STDOUT] stdout: [        ]     frame #26: 0x0000000104380190 dyld`start + 444

https://github.com/flutter/engine/pull/31720 does not sound related.  It should have no effect on existing logic.  It refactored the code to moved logic from one place to another so that there is another entrypoint to execute it from dart.  If it did cause problems I would have expected them to be around creating the dart isolate or an error in the dart plugin registrant.

Mac_ios platform_views_scroll_perf_ios passed after the clang revert: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios platform_views_scroll_perf_ios__timeline_summary/3822/overview

Dropping to P3 since the Engine -> Framework roll is now unblocked.

/cc @petrhosek Our clang roll is blocked on this. I'm not sure what info you would need to help debug.

Do you have any additional information aside from the stacktrace? Is it possible to reproduce this locally and if so are there instructions? If the issue is non-obvious, we could try to bisect this.

Aside from the stack trace, the Engine for this test was configured with:
flutter/tools/gn --goma --ios --runtime-mode profile --bitcode

which will target arm64 and use --lto.
This is probably difficult to reproduce, but one would star by checking out flutter/flutter at:
https://github.com/flutter/flutter/commit/a786f65700a1038494aa17c6bd7c0a0af0881ef8
And running the benchmark. The bot is running the benchmark on a macOS host with an iPhone attached by running this script:
https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/test_runner.dart
with the arguments listed here:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8820699371982729905/+/u/run_platform_views_scroll_perf_ios__timeline_summary/execution_details
(runner.sh is just a wrapper around test_runner.dart).

We're not currently set up to reproduce an issue like this locally. Can we get some help from the Flutter team? Can you try and reduce this down to a smaller reproducer? Can we use Flutter's infrastructure to build and run your tests with different toolchain versions?

We're not currently set up to reproduce an issue like this locally. Can we get some help from the Flutter team?

I can help.

Can you try and reduce this down to a smaller reproducer?

That's probably not going to happen.  The nature of the problem being with a clang roll means that its cause is outside of our knowledge which would be a requirement for minimizing the reproduction code.  There are tons of simpler tests that don't demonstrate a problem with the compiler.

Can we use Flutter's infrastructure to build and run your tests with different toolchain versions?

That wouldn't be easy to do.  The reason is that the test is running on the framework repo which is twice removed from clang.  The repo depends on the engine which depends on clang.  So we can't just make a framework PR and tweak it and let CI run and see if it works, we have to point the framework to an engine hash.  I don't think we could point it to your edited engine easily.
I think your best bet is to get it running locally and bisecting.
@zanderso I tried to reproduce the issue locally with a custom engine so I could show @petrhosek, but it didn't reproduce for me.  Here's what I did:

Checkout flutter engine @ d1cb84277f1d72644a7be0f6bf324938abbfa687
Checkout flutter @ f0b826d994 (I don't thinks this version should matter, it should be a problem in the engine).
Built the engine for ios_debug_unopt
Ran the test locally via ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t platform_views_scroll_perf_ios__timeline_summary --local-engine-src-path ~/dev/engine/src --local-engine=ios_debug_unopt

The device I was using was an iPhone 8 @ 14.6 18F72.
I'll try reproducing directly with https://github.com/flutter/flutter/commit/a786f65700a1038494aa17c6bd7c0a0af0881ef8

I was able to reproduce the problem locally with https://github.com/flutter/flutter/commit/a786f65700a1038494aa17c6bd7c0a0af0881ef8 with both ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t platform_views_scroll_perf_ios__timeline_summary and ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t platform_views_scroll_perf_ios__timeline_summary --local-engine-src-path ~/dev/engine/src --local-engine=ios_debug_unopt where the local engine was the same used used above with flutter @ https://github.com/flutter/flutter/commit/f0b826d99463bdcb6e12a76c6f8ae66882f2ef39 and it worked fine.

@zanderso How could it be that the tests pass with the framework at https://github.com/flutter/flutter/commit/f0b826d99463bdcb6e12a76c6f8ae66882f2ef39 and the engine @ d1cb84277f1d72644a7be0f6bf324938abbfa687 (the commits before your reverts)?  Is there some other upstream side effect of changing the clang version beyond what is used to compile the engine?
For completeness, I tried flutter @ https://github.com/flutter/flutter/commit/f0b826d99463bdcb6e12a76c6f8ae66882f2ef39 and engine @ 12bb7417a712e5fc81029469117c29b877f03b75 and the test failed.

I was able to reproduce this by:

making an ios_profile build of the engine at https://github.com/flutter/engine/commit/993285f64dac25af0c999c5109b27a83fc017511
checking out the Flutter framework tree at https://github.com/flutter/flutter/commit/21797cbb034f48a384378efff0ee0b520e160072
in the framework tree, cd to dev/benchmarks/platform_views_layout and run flutter --local-engine ios_profile run --profile

The framework commit https://github.com/flutter/flutter/commit/21797cbb034f48a384378efff0ee0b520e160072 contains an engine that precedes the Clang roll.  If you run the platform_views_layout test app using flutter run --profile at that commit then the app works as expected.
But doing the same with --local-engine ios_profile and a locally built engine that includes the Clang roll will produce this crash:
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x105a1f53c382f)
    frame #0: 0x0000000106983374 Flutter`GrMtlIsAppInBackground() at GrMtlUtil.mm:463:47 [opt]
   460 	#ifdef SK_BUILD_FOR_IOS
   461 	bool GrMtlIsAppInBackground() {
   462 	    return [NSThread isMainThread] &&
-> 463 	           ([UIApplication sharedApplication].applicationState == UIApplicationStateBackground);

If this repros with a local engine build, then a bisect could proceed by pulling different versions down from cipd: https://github.com/flutter/engine/blob/main/DEPS#L574. @petrhosek are the versions of clang we should try downloadable from cipd?

@jason-simmons I didn't try a profile build.  If that's the difference, that makes sense.  I'm still a bit confused because I could reproduce it or not with the same debug engine depending on the framework version, which I wouldn't have expected.
@zanderso CIPD does have artifacts between gi-ivU51hLEmgL3m_giEo-uJOhzJgdYslQ0dvUvAJxcC and VvkT0LU62yJ956AsTLeN2qXNS5jo9ynlIRHHjQ4Y73AC (seen here: https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang/mac-amd64/+/).  They are associated with different LLVM commits.   @petrhosek should be able to bisect between those and map the change back to a llvm commit.  I'm not sure if there is a CIPD command line tool to easily get the hashes between those 2 hashes though.

I ran the test with framework @ https://github.com/flutter/flutter/commit/21797cbb034f48a384378efff0ee0b520e160072 (like jason) and engine @ https://github.com/flutter/engine/commit/d1cb84277f1d72644a7be0f6bf324938abbfa687 (the last commit before the revert of the clang update) with profile builds and I could not reproduce the issue.  It seems like the problem is very particular to the exact code that shows up in https://github.com/flutter/engine/commit/993285f64dac25af0c999c5109b27a83fc017511

Does the test need to run on the device (iPhone) for the failure to reproduce?

Yep.

So the problem happened when migrating from gi-ivU51hLEmgL3m_giEo-uJOhzJgdYslQ0dvUvAJxcC to VvkT0LU62yJ956AsTLeN2qXNS5jo9ynlIRHHjQ4Y73AC.  Those are associated with llvm-project hashes 1aa59ff2f789776ebfa2d4b315fd3ea589652b4a to a218706cba90248be0c60bd6a8f10dbcf0270955.  There are 6537 commits between those hashes (hashes linked in file).
hashes.txt

I tried doing an ios_profile build of the tip-of-tree Flutter engine using the most recent package available on https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang/mac-amd64/+/ (instance ID 49M2bGisie_DfmqcKVVGq4TbRon6Zk1HtW7X8ogLJCIC)
The bug is still occurring with that build.

It looks like cipd doesn't have a build for every llvm hash so we can't get the exact llvm commit where the problem happened.
For example db57065b368ab4a078b749ccf14b0f384ab4571f:

https://llvm.googlesource.com/llvm-project/+/db57065b368ab4a078b749ccf14b0f384ab4571f
https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang/mac-amd64/+/git_revision:db57065b368ab4a078b749ccf14b0f384ab4571f

I have everything required to bisect so I'll start doing it and updating my results here as I get them:

time
llvm hash
result
mac hash
linux hash
windows hash

3/8 2:02
42ac4e1a120c0d0784365c2c7f39c87854b507c4

s-pLlv0KjUKW0a7UACqKLHcKp9iT-3XsyHex4yP6u4UC
5nGThNOBTuIz3gWOSw6Sns1J8HLv96w_xpYp6B45G0sC
DJDQZ8GjaqkVpc38uU9WxKkaVo6MJHyLTjO95BFwlaoC

@petrhosek the bug was introduced somewhere between e9768a2a44a1 and caa1ebde7067.  That's the best granularity I can give you given the frequency of cipd artifacts.
There are 1029 commits between those 2 commits.

@petrhosek feel free to reach out to me tomorrow on chat and I can walk you through my setup and how I reproduce the issue.

That's great, thank you @gaaclarke! I'll reach out to you tomorrow to see if we can narrow it down even further.

@petrhosek and I are going to start trying to bisect into LLVM by doing local builds of the engine.  Results will be updated here.

time
hash
result

3/9 9:54
c89cfbd4ddfa4e01fea1eb87aba9cdcd0e31d3a8

The results of the bisect point to 216d1a729c7f7659e9b7c0fb501fcf7d0d572c7d as being the first bad commit.  I went back and built with c89cfbd4ddfa4e01fea1eb87aba9cdcd0e31d3a8 to verify that it is GOOD.  It however demonstrated the error when it didn't yesterday.  That means the results of the bisect cannot be trusted.
Possible explanations:

There is some cached value between tests (I was cleaning the engine between runs)
The bug is not deterministic (I haven't seen evidence to suggest this since it's 100% reproducible with the steps jason said)

Here is the clang-14 build I used for c89cfbd4ddfa4e01fea1eb87aba9cdcd0e31d3a8 (visible to Alphabet only): https://drive.google.com/file/d/1uf8zA0QLPvwBmbnla-NyQu9Grn4vqZx7/view?usp=sharing

Since the last bisect was a failure @jason-simmons is going to verify my findings that the error is between e9768a2a44a1 and caa1ebde7067, then we will run an automated bisection script.  @petrhosek has offered to precache the clang builds for that range to speed up that bisection (assuming jason verifies my findings).

On thursday last week, @jason-simmons verified that the error is between e9768a2a44a1 and caa1ebde7067.
I wrote a script to bisect the issue to make sure there wasn't some human error when I tried to bisect manually.  I also added even more clean instructions between tests to make sure there isn't some cached value between tests.  @petrhosek built me the versions of clang-14 that are used in the bisect.
The results were that changing the clang-14 executable isn't enough to bisect the issue.  Every single test resulted in a crash.  The log of the tests is attached here: bisectlog2.txt

Bisect script source
/// Script made to automate bisecting issue https://github.com/flutter/flutter/issues/99488.
/// gaaclarke 3/10/22

import 'dart:async';
import 'dart:ffi';
import 'dart:io';
import 'dart:convert';
import 'dart:math';

final _server = 'xxxx';
final _engineSrcPath = '/Users/aaclarke/dev/engine/src';
final _testPath =
    '/Users/aaclarke/dev/flutter/dev/benchmarks/platform_views_layout';
final _llvmPath = '/Users/aaclarke/dev/llvm-project';
final _startGood = 'e9768a2a44a1501b82e3bbf9862b4ba2cc4b9cc3';
final _startBad = 'bc48a266554740bbedbc155deda2aa81b9a1602d';

void _log(String str) {
  DateTime _now = DateTime.now();
  print(
      '[${_now.hour}:${_now.minute}:${_now.second}.${_now.millisecond}]:$str');
}

Future<List<String>> getGitHashes(
    {required String good, required String bad}) async {
  final ProcessResult process = Process.runSync('git',
      <String>['log', '--pretty=format:"%H"', '$good..$bad', 'llvm', 'clang']);
  await process.exitCode;
  final String output = process.stdout;
  return output.split('\n').map((e) => e.replaceAll('"', '')).toList().reversed.toList();
}

Future<bool> downloadClangArtifacts(String hash) async {
  _log('download $hash');
  final String src =
      '$_server:/google/data/rw/users/aa/aaclarke/www/clang/clang-14-$hash';
  print(src);
  final String dest = './buildtools/mac-x64/clang/bin/clang-14';
  ProcessResult result = Process.runSync('scp', <String>[src, dest]);
  return result.exitCode == 0;
}

Future<void> cleanEngine() async {
  _log('clean engine');
  ProcessResult result =
      Process.runSync('rm', <String>['-rf', 'out/ios_profile']);
  result = Process.runSync('rm', <String>['-rf', 'out/host_profile']);
}

Future<void> buildEngine() async {
  _log('run gn');
  ProcessResult result = Process.runSync('flutter/tools/gn',
      <String>['--runtime-mode=profile', '--no-goma', '--ios']);
  if (result.exitCode != 0) {
    throw Exception('gn for ios failed');
  }
  result = Process.runSync(
      'flutter/tools/gn', <String>['--runtime-mode=profile', '--no-goma']);
  if (result.exitCode != 0) {
    throw Exception('gn for host failed');
  }
  _log('build ios_profile');
  result = Process.runSync('autoninja', <String>['-C', 'out/ios_profile']);
  if (result.exitCode != 0) {
    throw Exception('ios_profile build error');
  }
  _log('build host_profile');
  result = Process.runSync('autoninja', <String>['-C', 'out/host_profile']);
  if (result.exitCode != 0) {
    throw Exception('host_profile build error');
  }
}

Future<bool> runTest() async {
  _log('flutter clean');
  ProcessResult cleanResult = Process.runSync('flutter', <String>['clean']);
  if (cleanResult.exitCode != 0) {
    throw Exception('flutter clean error: ${cleanResult.stdout}');
  }
  _log('flutter run');
  final Process process = await Process.start('flutter', <String>[
    '--local-engine-src-path',
    _engineSrcPath,
    '--local-engine',
    'ios_profile',
    'run',
    '--profile',
  ]);
  Completer<bool> result = Completer<bool>();
  process.stdout.transform(utf8.decoder).forEach(_log);
  process.exitCode.then((int exitCode) {
    result.complete(exitCode == 0);
  });
  Future.delayed(Duration(seconds: 60), () {
    if (!result.isCompleted) {
      process.stdin.write('q');
    }
  });
  return result.future;
}

void main() async {
  Directory.current = Directory(_llvmPath);
  List<String> hashes = await getGitHashes(good: _startGood, bad: _startBad);
  _log('number hashes: ${hashes.length}');
  String lastResult = '';
  while (hashes.length > 0) {
    final int index = (hashes.length / 2).floor();
    final String hash = hashes[index];
    _log('index:$index remaining:${hashes.length} hash:$hash');
    Directory.current = Directory(_engineSrcPath);
    await cleanEngine();
    bool didDownload = await downloadClangArtifacts(hash);
    if (didDownload) {
      await buildEngine();
      Directory.current = Directory(_testPath);
      final bool isGood = await runTest();
      _log('$hash is ${isGood ? 'good' : 'bad'}');
      if (isGood) {
        hashes = hashes.sublist(index + 1, hashes.length);
        lastResult = '$hash is last good commit';
      } else {
        hashes = hashes.sublist(0, index);
        lastResult = '$hash is first bad commit';
      }
    } else {
      _log('couldn\'t download $hash');
      hashes.remove(hash);
    }
  }
  _log('== RESULT ==');
  _log(lastResult);
}

With @jason-simmons's help I was able to verify that the setup for the last bisect was incorrect.  Tonight I'll use engine@d1cb84277f1d72644a7be0f6bf324938abbfa687 with its DEPS hacked to be c82r7j5-GhUShaS0850GJtKGRKipvFio3J9aUl3iL_wC.
The artifacts in c82r7j5-GhUShaS0850GJtKGRKipvFio3J9aUl3iL_wC appear to work with the clang-14 executable for the whole range between e9768a2a44a1 and caa1ebde7067.

Okay, I was able to bisect again with the help of @petrhosek's llvm builds.
The first confirmed bad commit is fad7e491a0770ac4336934030ac67d77e7af5520.
Here is the bisect log: bisect5.txt
Here is the graphical results of the bisect:
caa1ebde70673ddb7124a0599ba846362a1f8b1e Don't assume that a new cleanup was added to InnermostEHScope.
...
######### Test 1 BAD ###################
bc48a266554740bbedbc155deda2aa81b9a1602d [LoopPeel] Use reference instead of pointer for DT argument
...
093b43f48d0d6d78e1dc102dc11507e1d6ef1624 Sink getGCResultLocality to sole use [NFC]
########## Test 2 ######################
22cd2356125ad4e2ade92b91fb0123f9afce182c [OpenMP] Disable rpath test in windows for lack of a libomp.lib stub
...
56cc697323445337134cc2bbe8ce8b1f60131574 [clang][dataflow] Merge distinct pointer values in Environment::join
###### Test 3 ##########################
efd4938723efeb26d9cf00ddf217149756c120c3 [VPlan] Handle IV vector splat using VPWidenCanonicalIV.
ee9eeed77348315abbf822034ade819fa741207a [X86] LowerFunnelShift - enable v8i16 lowering
6777289dd930393305703f0f8d992a4d648d43a7 [X86] lowerShuffleAsBlend - pull out repeated getVectorNumElements() calls. NFC.
3a1fd170271da25e7ce9b0a329adf47483378229 [WebAssembly] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr
424400da2db86558917e6da19a821e160acc48d1 [clang][NFC] Change some ->getType()->isPlaceholderType() to just ->hasPlaceholderType()
f1305f2369dca985af777cf9c0cf06009d5bcbe8 [X86] combinePredicateReduction - always use PMOVMSKB(PCMPEQB()) for allof(icmp_eq()) reductions
a10ff373ddfa82a67c580a87f6258aa6ab8dd595 Speculatively fix the sphinx build for Clang's attribute reference
67a399fd57869805e5b7f7ce54ad0eab32a80a62 [X86] SimplifyDemandedBits - add X86ISD::BLENDV SimplifyMultipleUseDemandedBits handling
7e849fd97b6abd1de30ffc66da1ebf47afc7ab70 [X86] LowerFunnelShift - allow non-constant vXi8 unpack(y,x) << zext(z) lowering pre-AVX512
a6cabd98021fe357d666614601eca2031bf775de Revert fad7e491a0770ac4336934030ac67d77e7af5520 with fixes applied
33fe0872cd54afa1fc036e0d9fdc89d65449f9ff [M68k] Add addressing modes ARIPI and ARIPD support for BTST
30efee764d95d425b480758ed02682fab6426d28 [SVE] Remove AArch64ISD::PFALSE.
3bc876d0a3f1f7554b877b93c5f57ff7cba55ffa [AArch64] Add isel for bitcasting between bfloat and half types.
058c5dfc78cd1a1a6075bba9799e63f3ec871c0d Raise the minimum Visual Studio version to VS2019
784e01abca65722df8969b56d2d240cf9ced9c85 [IR] Require matching signature in getCalledFunction()
8faf2a0638d3e8d9411d55c3e5dfb7b452f35ca2 [RISCV] Correct predicate orc.b pattern to not include Zbkb.
864767ab09cba862d88d19ea6f1a17a1705175ad [WebAssembly][NFC] Refactor WasmSymbol type setting code
d8f929a567083a6b90264193f1e4476f6b77c5fe [RISCV] Custom legalize BITREVERSE with Zbkb.
c95df64ce06443d60881078ef2e80108e24459c4 [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers
##### Test 5 ###########################
1aeb3314d8d77040527accc44aaf9d3959ac1f20 [TableGen] Detect multiple Processors with the same name.
7017e6c9cfd2de3122ce9528f338a97d61e96373 [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm
3b194ca7ab37a212ab54e698d22415753dc6a197 Recommit "[InstCombine] Fold and-reduce idiom"
be44177edea535d93af147cb7f26fae55f8da8ba [X86][avx512fp16] Promote fp16 to fp32 for frem.
106f2b2dfb35403ea581fdad15fa01db0f335e57 [gn build] (manually) port 99217fa8a02
521205c084f48607375d696465fd73f5728a9def [Test] Add pointer comparison test that crashed with D118317
1276678982a0c9d0d7aba6afdc83d34ee42f397c [RISCV] Improve extract_vector_elt for fixed mask registers.
bf4cab29f5a88b622e200d59d9156f2ca31165eb [Test] Recommit tests that were reverted by mistake along with other patch
e64feaf00fd3b42c5820da556e60dd575f98cbe5 [M68k][GlobalISel] Legalize more instruction in M68k Legalizer.
7e32d2b21a58ad71432f1403227dbf739f39c345 Revert "[UpdateTestChecks] Add --filter and --filter-out options"
##### Test 6 ###########################
4465c299069f3ff5b93ba648edf699faf7f39e79 Move LLVM Proposal to doc directory, create index
24f88f57de588817bd21e799e2ac1069c025674c [OpenMP] Accept shortened triples for -Xopenmp-target=
##### Test 7 BAD #######################
fad7e491a0770ac4336934030ac67d77e7af5520 Revert "Add BITINT_MAXWIDTH support"
##### Missing ##########################
5fc1261ef37549484e9eb9edc90477d713d8223f [Driver] Remove -fno-experimental-new-pass-manager
##### Missing ##########################
2081ffe4b2e3870cfe2d58331f57badd7dbc009a Update module map for 4ce1f3d47c33daccfb7f4e906c3f57b404900036
##### Missing ##########################
6eb826567af03c2b43cda78836b1065e12df84e4 [Driver] Add CUDA support for --offload param
##### Missing ##########################
99d2582164c4bc8f10c3e3c20dd3690243ad49ba [ScalarEvolution] Handle <= and >= in non infinite loops
##### Missing ##########################
354ec4af749ccd910a1cffc5e9cce2bb93239b9b [AttrDocs] Fix docs for the sycl_special_class attribute after D114483
#### Missing ###########################
030f71698d52f228929da5e3148602f4a3daff7d [UpdateTestChecks] Add --filter and --filter-out options
#### Missing ###########################
64df51624f08f3b8d7370f820ab3545b1de98a0e [clang-format] Fix misaligned trailing comments in the presence of an empty block comment.
##### Missing ##########################
be2147db054ec096199d1251bfab9065c7e0f29b Remove reference type when checking const structs
##### Missing ##########################
8428c75da1ab3149292c255057173cb502729d92 [CUDA][HIP] Do not treat host var address as constant in device compilation
##### Missing ##########################
6888081e32c45a7bb88cfc883a38bce5e5ccc0b8 [SLP] Use moveBefore to simplify code [NFC]
##### Missing ##########################
634ca7349d4a467b993321ff3152c2e044f1f487 [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.
##### Missing ##########################
9dd5fffd30651c5524a53d8110f75fa3b59666ac [GVN] Add tests with redundant load of pointer select.
##### Missing ##########################
746e435ff76a12468103a978d46f7b1a5052e867 Revert "[SLP] Add a clarifying assert in block scheduling [NFC]"
##### Missing ##########################
86797fdb6f51d32f285e48b6d3e0fc5b8b852734 Add BITINT_MAXWIDTH support
##### Test 4 GOOD ######################
edf7e026a8b4df5df7febaef126888f1ce65ebf6 [clang][NFC] Fix Typo
...
81bd67e18ae6ef90b68792f63eb94a10f22a353b [AArch64][SVE][VLS] Move extends into arguments of comparisons

That means the culprit is one of these commits, but I can't confirm which one since there were missing builds:
fad7e491a0770ac4336934030ac67d77e7af5520 Revert "Add BITINT_MAXWIDTH support"
5fc1261ef37549484e9eb9edc90477d713d8223f [Driver] Remove -fno-experimental-new-pass-manager
2081ffe4b2e3870cfe2d58331f57badd7dbc009a Update module map for 4ce1f3d47c33daccfb7f4e906c3f57b404900036
6eb826567af03c2b43cda78836b1065e12df84e4 [Driver] Add CUDA support for --offload param
99d2582164c4bc8f10c3e3c20dd3690243ad49ba [ScalarEvolution] Handle <= and >= in non infinite loops
354ec4af749ccd910a1cffc5e9cce2bb93239b9b [AttrDocs] Fix docs for the sycl_special_class attribute after D114483
030f71698d52f228929da5e3148602f4a3daff7d [UpdateTestChecks] Add --filter and --filter-out options
64df51624f08f3b8d7370f820ab3545b1de98a0e [clang-format] Fix misaligned trailing comments in the presence of an empty block comment.
be2147db054ec096199d1251bfab9065c7e0f29b Remove reference type when checking const structs
8428c75da1ab3149292c255057173cb502729d92 [CUDA][HIP] Do not treat host var address as constant in device compilation
6888081e32c45a7bb88cfc883a38bce5e5ccc0b8 [SLP] Use moveBefore to simplify code [NFC]
634ca7349d4a467b993321ff3152c2e044f1f487 [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.
9dd5fffd30651c5524a53d8110f75fa3b59666ac [GVN] Add tests with redundant load of pointer select.
746e435ff76a12468103a978d46f7b1a5052e867 Revert "[SLP] Add a clarifying assert in block scheduling [NFC]"
86797fdb6f51d32f285e48b6d3e0fc5b8b852734 Add BITINT_MAXWIDTH support

Okay, the final bisect has run.  634ca7349d4a467b993321ff3152c2e044f1f487 is absolutely the first bad commit.
Bisect log: bisect6.txt

@petrhosek what are the next steps? Is there anything further we can help you with?

It might be worth pinging Ahmed Bougacha on github ((at)ahmedbougacha) .  He might be aware of the issue.
I could also give you the whole compiled binary that fails but I worry that it is so big it isn't so helpful.

I responded on https://reviews.llvm.org/D118214#3393603.

Checked back on the bug for this today Firefox bisected a crash to the same trouble commit, and it looks like a possible fix landed in LLVM 14.0.2.

@petrhosek I'm not sure how to know when that fix will be available for Flutter to try out. Do you have any advice?

@zanderso the current integration toolchain that's used by Fuchsia (that is git_revision:49cb4fef02e635bf304906232214166c7531d753) already contains that it.

Great. I have restarted the autorollers.