[pthreads] Build error

Package: pthreads[core]:x86-windows -> 3.0.0#14
Host Environment

Host: x64-windows
Compiler: MSVC 19.32.31336.0
vcpkg-tool version: 2023-04-07-bedcba5172f5e4b91caac660ab7afe92c27a9895
vcpkg-scripts version: 662dbb50e 2023-06-02 (3 days ago)

To Reproduce
vcpkg install libssh
Failure logs
-- Using cached pthreads4w-code-v3.0.0.zip.
-- Cleaning sources at C:/dev/vcpkg/buildtrees/pthreads/src/49e541b66c-a9b0a36b2a.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/dev/vcpkg/downloads/pthreads4w-code-v3.0.0.zip
-- Applying patch fix-arm-macro.patch
-- Applying patch fix-arm64-version_rc.patch
-- Applying patch fix-pthread_getname_np.patch
-- Applying patch fix-install.patch
-- Applying patch whitespace_in_path.patch
-- Applying patch use-md.patch
-- Using source at C:/dev/vcpkg/buildtrees/pthreads/src/49e541b66c-a9b0a36b2a.clean
-- Found external ninja('1.10.2').
-- Getting CMake variables for x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: "C:/Program Files/Microsoft Visual Studio/2022/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v
    Working Directory: C:/dev/vcpkg/buildtrees/pthreads/x86-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      C:\dev\vcpkg\buildtrees\pthreads\get-cmake-vars-x86-windows-dbg-CMakeCache.txt.log
      C:\dev\vcpkg\buildtrees\pthreads\get-cmake-vars-x86-windows-rel-CMakeCache.txt.log
      C:\dev\vcpkg\buildtrees\pthreads\get-cmake-vars-x86-windows-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:310 (vcpkg_execute_required_process)
  scripts/cmake/z_vcpkg_get_cmake_vars.cmake:18 (vcpkg_configure_cmake)
  scripts/cmake/vcpkg_build_nmake.cmake:46 (z_vcpkg_get_cmake_vars)
  scripts/cmake/vcpkg_install_nmake.cmake:52 (vcpkg_build_nmake)
  ports/pthreads/portfile.cmake:45 (vcpkg_install_nmake)
  scripts/ports.cmake:147 (include)

get-cmake-vars-x86-windows-dbg-CMakeCache.txt.log
get-cmake-vars-x86-windows-out.log
get-cmake-vars-x86-windows-rel-CMakeCache.txt.log

Thanks for posting this issue. Did you install the following components in Visual Studio?

@RylanVWVermeer, could you please install windows sdk via VS installer, and try again?

I did not have the Windows 10 SDK installed, but I do now.  After retrying, I am still facing the same error, unfortunately.

I have now fully uninstalled Visual Studio 2022 Professional and reinstalled with these options:

After doing so, I get this result (sorry for the additional image, but it's not within issue_body.md:

It certainly looks like the problem is CMake, so I will pursue that as a separate install.  I would happily entertain any other suggestions.

I just want to confirm this is the correct place the portable CMake in the output above should be finally extracted to:

After installing CMake from https://cmake.org/download/, I am still getting the same error.
I figure the get-cmake-vars logs will be helpful again, so I am attaching them here - I switched to the x64 triplet to see if I had any luck there.  I notice that there is no reference to Visual Studio pathing for the internal cache entries.  They are all pointing at the download above:
CMAKE_COMMAND:INTERNAL=C:/dev/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe
//Path to cpack program executable.
CMAKE_CPACK_COMMAND:INTERNAL=C:/dev/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cpack.exe
//Path to ctest program executable.
CMAKE_CTEST_COMMAND:INTERNAL=C:/dev/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/ctest.exe

I am not sure that's relevant as it points to VS's ninja.exe, but windows-i386 certainly has a smell here.
get-cmake-vars-x64-windows-dbg-CMakeCache.txt.log
get-cmake-vars-x64-windows-out.log
get-cmake-vars-x64-windows-rel-CMakeCache.txt.log

Thanks for your reply, please also install the following components.

Pinging @RylanVWVermeer for response, does this issue resolved?

Unfortunately, after installing those 2 build tools, the problem still persists.
get-cmake-vars-x86-windows-dbg-CMakeCache.txt.log
get-cmake-vars-x86-windows-rel-CMakeCache.txt.log
get-cmake-vars-x86-windows-out.log

@LilyWangLL, do you have any further suggestions?

Failures:
--mt=CMAKE_MT-NOTFOUND
Hi @RylanVWVermeer, it looks mt.exe not found in your machine. However, you have installed windows SDK from the picture, Could you help double check?
1.Open x86 or x64 Native Tools command
2 where mt
For me:

You are absolutely correct that mt.exe isn't getting found.

However, it is at the path your output indicated (Directory of C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64):

I also have C:\Program Files (x86)\Windows Kits\10\bin\10.0.20348.0\x64, and mt.exe exists there as well.

It looks the windows SDK have something wrong in setup, could you uninstall all windows sdks and reinstall one of them by VS installer again, and try 'where mt' in x64 native command tool, if it shows mt.exe directory correctly, you can try to install pthreads via vcpkg again.

I have uninstalled each SDK and reinstalled them each by itself.  It is still not finding mt.exe.

After some more digging, I believe you're on to something with this.  There are multiple, potentially conflicting, mt.exe files on my system.  I am unsure where the 10.0.20348.0 version came from... possibly the .NET 7 SDK?  I installed that separately back when .NET 7 was new.
Also, I see no set path in my environment variables for mt.exe.  Is that necessary as well?  I can add it if so.

We usually installed windows sdk by Visual Studio Installer, and do not need to set any extra window sdk enviroment variables again. now you have multiple versions and conflicts, if you don't need all of them, I recommand that install one of them.

I see no set path in my environment variables for mt.exe. Is that necessary as well? I can add it if so.

I suspect it doesn't work even you set the environment variables for mt.exe,  you need to resolve windows sdk environment variables, mt.exe is just one of the tools, like rc.exe or midl.exe still need during the build.

I removed the .NET 7 SDK and modified my C# installation as well to not include the SDK involved there to limit my machine down to 10.0.19041.0 as the only version containing mt.exe.  That did not help.  I went so far as to uninstall then reinstall everything via the Visual Studio installer... again, and still my system does not find mt.exe.
I included it as an environment after all of that for the sake of it, but I still get no where.  I am happy to entertain any suggestions.

...\VC\Auxiliary\Build\vcvarsall.bat normally puts a Windows SDK in the PATH, it also reads related values from the registry, could you see if https://discourse.cmake.org/t/rc-rc-mt-cmake-mt-notfound/5089 helps?

I tried the workaround on the linked on the linked Visual Studio developer website (https://developercommunity.visualstudio.com/t/resource-compiler-rcexe-is-not-recognized-as-an-in/1676970) by explicitly stating where the Windows SDK is, and I am now facing this error from the file you mentioned:

And yes, registry editing is blocked at my company.  I am also pursuing an avenue to get registry editing allowed on my machine.

And yes, registry editing is blocked at my company. I am also pursuing an avenue to get registry editing allowed on my machine.

@RylanVWVermeer, sorry for my lately response,  have you solved the enviroment issue finally?

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.


docs: fix README.md

I noticed some things were wrong with the README, so I'm going through and fixing them; this PR isn't ready to merge yet though.

when do you think this PR will be ready for review?
would suggest also mentioning that test version of scrappy run in #scrapbook-test channel among others.

Oops; i forgot I had this open. I was waiting to hear what commands were still available, so I could update them in the README.

Just checked the commands, and it seems that the webhook isn't implemented anymore?

Just checked the commands, and it seems that the webhook isn't implemented anymore?

looks like it

Sad; could I create a PR to add it back?

you can go ahead and do so but there are currently plans to make big changes to how scrappy works

ooh; nvm then i'll wait for that then

This should be ready to merge now

yep


feature request: up arrow go to bottom of quick fix ⌘. menu

Currently, when opening the Quick Fix menu via ⌘.:
Current Behavior:
It automatically has the first item at the top of the menu selected, and you are unable to push Up Arrow to get to the bottom of the list.

This would be extremely helpful in situations like eslint/prettier when the "fix with prettier" (or similar option) is always at the bottom of the list.

Desired Behavior:
To push the up arrow on the Quick Fix menu, and it takes you to the bottom of the list.

This desired behavior actually already exists when doing a right click somewhere (as nothing is selected), and you are able to push Up Arrrow, and it takes you to the bottom of the list.
Fantastic work on VSCode as always, this is a super minor thing - but I think it would be fantastic for an even better DX <3

@MarkPieszak I think this should be resolved (in both the original Quick Fix Menu and with the new Code Action Widget which will replace this menu - see https://github.com/microsoft/vscode/issues/152913)
Just one thing though - @mjbvz can you confirm some behavior on MacOS vs Windows?
When hitting Ctrl + . on Windows, the Quick Fix menu will actually include the Learn more about TS/JS Refactoring option. When opening the Quick Fix menu from an error (View Problem) and hitting the text that says Quick Fix..., the menu won't include the Learn more.... option.
Is this the same with ⌘ + .  on Mac? This means that hitting the up arrow works, but would be an option that most users wouldn't intend to click on.

@justschen Yes that's the same behavior on macOS too


Add the implementation of Expected Error Reduction active learning algorithm

Codecov Report

Merging #93 into master will decrease coverage by -1.68%.
The diff coverage is 21.21%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage    77.7%   76.03%   -1.68%
==========================================
  Files          31       32       +1
  Lines        1081     1114      +33
==========================================
+ Hits          840      847       +7
- Misses        241      267      +26

Impacted Files
Coverage Δ

...ibact/query_strategies/expected_error_reduction.py
21.21% <21.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9d4d1...3107b5f. Read the comment docs.

Please write tests.
You can take quire's test as example since this is a slow algorithm.


[3.9-MS] Miscellaneous UI Improvements: Address outdated UI components and add new functionality across the application

What feature or change would you like to see made?

Redesign the Capture Tool modal to align with the modern UI
Update the design of the local drag-and-drop page
Add a "More" menu to viewports with options like:

Making a viewport go full screen
Printing the active viewport
Adding a scaling/overlay scale tool

Reduce the gap between viewports in the viewport grid

Why should we prioritize this feature?
There are several minor UI components and features that have outdated designs or lack functionality. Addressing these issues through a miscellaneous UI improvements effort will enhance the overall user experience and bring consistency across the application. These changes may seem small individually, but collectively they can significantly improve usability and modernize the application's look and feel.

Print function in Weasis https://weasis.org/en/tutorials/print/index.html

the printout will be very useful

This wasn't included in the scope of 3.9, but we will revisit it in future versions.


Docker hangs and all containers stuck, cannot stop container, docker info, logs command are also hang.

Description
As described in title, our docker hangs after docker run, and "docker stop", "docker info", "docker logs containerID" are all hangs.

Steps to reproduce the issue:
Have no idea how does it occured.
Describe the results you received:
Docker containers stuck, and docker info, docker logs, docker stop are hang.
Describe the results you expected:
Docker containers should run normally and all command should not hang.
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   a34a1d5
 Built:        Fri Nov 20 13:25:01 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   a34a1d5
 Built:        Fri Nov 20 13:25:01 UTC 2015
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 0
Images: 388
Server Version: 1.9.1
Storage Driver: devicemapper
 Pool Name: docker-253:1-2097925-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 107.4 GB
 Backing Filesystem:
 Data file: /dev/vg-docker/data
 Metadata file: /dev/vg-docker/metadata
 Data Space Used: 35.76 GB
 Data Space Total: 104.2 GB
 Data Space Available: 68.39 GB
 Metadata Space Used: 37.45 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.11 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Library Version: 1.02.107-RHEL7 (2015-12-01)
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.18.27
Operating System: CentOS Linux 7 (Core)
CPUs: 4
Total Memory: 15.67 GiB
Name: slave2.g1.r2.sh
ID: EWQL:SZWJ:6M6W:2HBB:VGNQ:2KUG:QYMD:JAF4:OOCO:CIZW:HZXO:53WM

Additional environment details (AWS, VirtualBox, physical, etc.):
Output of uname -a:
Linux slave18.g1.r2.sh 3.18.27 #1 SMP Mon Feb 29 16:36:56 CST 2016 x86_64 x86_64 x86_64 GNU/Linux

We have a cluster with about 200 machines, and this occured a couple of times. And we use docker on jenkins, so this problem will hangs the related jenkins jobs, too.
What can I do for solving this?

@SeanZhu20  can you send SIGUSR1 to docker daemon( you can use kill -SIGUSR1 $(cat /var/run/docker.pid)) and paste stack dump?

@coolljt0725 It was recovered by using restart docker service. I will try when it show again.

Let me close this issue for now, but feel free to comment if you see the issue again. Keep in mind that docker 1.9 is no longer maintained, so we won't be fixing issues in that version

@thaJeztah Showed again in docker 1.12.3:
docker info stuck and not returning anything, docker run stuck too.
output of docker version:
`Client:
Version:      1.12.3
API version:  1.24
Go version:   go1.6.3
Git commit:   6b644ec
Built:
OS/Arch:      linux/amd64
Server:
Version:      1.12.3
API version:  1.24
Go version:   go1.6.3
Git commit:   6b644ec
Built:
OS/Arch:      linux/amd64`
output of docker info from another machine:
Containers: 0  Running: 0  Paused: 0  Stopped: 0 Images: 26 Server Version: 1.12.3 Storage Driver: devicemapper  Pool Name: docker-253:1-2097729-pool  Pool Blocksize: 65.54 kB  Base Device Size: 10.74 GB  Backing Filesystem: xfs  Data file: /dev/vg-docker/data  Metadata file: /dev/vg-docker/metadata  Data Space Used: 46.66 GB  Data Space Total: 104.2 GB  Data Space Available: 57.5 GB  Metadata Space Used: 49.42 MB  Metadata Space Total: 2.147 GB  Metadata Space Available: 2.098 GB  Thin Pool Minimum Free Space: 10.42 GB  Udev Sync Supported: true  Deferred Removal Enabled: false  Deferred Deletion Enabled: false  Deferred Deleted Device Count: 0  Library Version: 1.02.107-RHEL7 (2015-12-01) Logging Driver: json-file Cgroup Driver: cgroupfs Plugins:  Volume: local  Network: null bridge host overlay Swarm: inactive Runtimes: runc Default Runtime: runc Security Options: seccomp Kernel Version: 3.18.27 Operating System: CentOS Linux 7 (Core) OSType: linux Architecture: x86_64 CPUs: 4 Total Memory: 15.67 GiB Name: slave42.g1.r2.sh ID: EWQL:SZWJ:6M6W:2HBB:VGNQ:2KUG:QYMD:JAF4:OOCO:CIZW:HZXO:53WM Docker Root Dir: /var/lib/docker Debug Mode (client): false Debug Mode (server): true  File Descriptors: 15  Goroutines: 23  System Time: 2017-02-13T11:53:22.535459998+08:00  EventsListeners: 0 Registry: https://index.docker.io/v1/ Insecure Registries:  <IP_ADDRESS>/0  <IP_ADDRESS>/8
output of uname -a:
Linux slave42.g1.r2.sh 3.18.27 #1 SMP Mon Feb 29 16:36:56 CST 2016 x86_64 x86_64 x86_64 GNU/Linux

I have the sam issue with TeamCity-Server-Container and TeamCity-Agent-Container on a .net Core C# build with NPM.

I am running it on a VM Linux h2695462 4.4.0-78-generic #99-Ubuntu SMP Thu Apr 27 15:29:09 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux with 2 GB Ram and 1 Core.
Docker Version
Docker version 17.03.0-ce, build 3a232c8

Docker Info output
Containers: 4
 Running: 4
 Paused: 0
 Stopped: 0
Images: 5
Server Version: 17.03.0-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 977c511eda0925a723debdc94d09459af49d082a
runc version: a01dafd48bc1c7cc12bdb01206f9fea7dd6feb70
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-78-generic
Operating System: Ubuntu 16.04.2 LTS
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 1.945 GiB
Name: h2695462
ID: PM6H:37NA:XWKO:TYLS:QAJW:BGMP:QX3K:4CRS:GSWJ:34HS:DKLB:IICP
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Tried the following but it did not work:
https://github.com/moby/moby/issues/22357

docker stop  ym_pipeline-app.2.z2swusmgkgbku34rmlwhdkxau
hanging ...
docker -v
Docker version 17.12.1-ce, build 7390fc6
ok it's old ...

well even docker -v hangs for me - what is this?

@Xerus2000 I have the same issue

i have the same issue, docker ps hung up, but docker info is ok

I faced the same issue. It seems that docker-compose up hangs after a while if I run it in non-daemonized mode (containers stdout logs to console). Otherwise (with -d option) it works stable for days, no problem is occured. Check this case please.


OSPF role fixes

Hi Demian
i will start to add issues for the changes I made
Under the OSPF  role (roles/underlay-ospf/templates/main.conf.j2  )
The {{ host.loopback.ip }} var is not defined
-    router-id {{ host.loopback.ip }};
+    router-id {{ loopback_ip }};

Under the ospf interfaces I add bfd and authentication
 {% for neighbor in underlay.neighbors %}
-            interface {{ neighbor.interface }};
+            interface {{ neighbor.interface }} {
+                               interface-type p2p;
+                               hello-interval 3;
+                               authentication {
+                                       md5 2 key "{{ underlay_ospf_pass_hash }}";
+                               }
+                               bfd-liveness-detection {
+                                       version automatic;
+                                       minimum-interval 300;
+                                       multiplier 3;
+                                       detection-time {
+                                               threshold 1000;
+                                       }
+                               }
+                       }
+
+
 {% endfor %}

For 100g interfaces on qfx10K you have to define the speed in under chassis so I add speed var to the topology
+{% for neighbor in underlay.neighbors %}
+{% if neighbor.speed is defined and neighbor.speed == "100g" %}
+chassis {
+    fpc {{ neighbor.interface.split('/')[-3].split('-')[-1] }} {
+        pic {{ neighbor.interface.split('/')[-2] }} {
+            port {{ neighbor.interface.split('/')[-1] }} {
+                speed 100g;
+            }
+        }
+    }
+}
+{% endif %}
+{% endfor %}

Thanks
Nitzan

Thanks @nitzan-tz for reporting these issues.
The first 2 seems straightforward to me and should be added to the OSPF role absolutely, any chance you can provide a pull request for that ?
The last one, I think it's not specific to OSPF so it might not be the best place to add that. Not sure of it should be part of common or if it should be part of another roles.
BTW, I saw that you created some new roles for analytics and sflow etc ... it's great and I would suggest to contribute these into another repo that is more generic than this one. I already have few of them there https://github.com/JNPRautomate/ansible-lib-roles
Adding @trmccart @ksator @mpergament to help moving forward.

I will create a pull request
I agree that the 100g part is more generic and maybe I will create a separate role for it if I think about it I should also check for the exact platform


SwiftUI support?

any plans to support for SwiftUI?

I don't have too much time now to add this, but feel free to send a PR

It's so easy to implement same UI animation in SwiftUI.
@pradeepb28 implement is by yourself.

Not sure if I understand the point of your comment on an issue opened 2 years ago.

To help anybody else that find this issue.


Guest Inviter role is now supported

Updating the documentation to reflect the new feature support.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


[WIP] Add tag methods for ec2 instances/images

Lint report for commit dcbc9cca8ef11ade6439117d9789e2f5a224fe21:
tests/test_vm_and_template_systems.py:

:bangbang: Line 30:1: E265 block comment should start with '# '

wrapanapi/systems/ec2.py:

:heavy_exclamation_mark: Line 37:1: W293 blank line contains whitespace
:red_circle: Line 39:34: F821 undefined name 'label'

Please, rectify these issues :smirk: .
No commit flaws detected.
CFME QE Bot

Lint report for commit 6e9a4722f6865b60e1f8061bef72c5d42d5bbb38:
tests/test_vm_and_template_systems.py:

:bangbang: Line 30:1: E265 block comment should start with '# '

Please, rectify these issues :smirk: .
No commit flaws detected.
CFME QE Bot


Rancher server no longer accessible because of catalog URL 404

Not sure if this is the correct place for this issue, please could someone point me in the right direction if it's not.

Rancher versions:
rancher/server or rancher/rancher: 1.6.4
rancher/agent or rancher/rancher-agent:
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):
Docker version: (docker version,docker info preferred)
Containers: 5
 Running: 5
 Paused: 0
 Stopped: 0
Images: 7
Server Version: 17.03.1-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version:  (expected: 4ab9917febca54791c5f071a9d1f404867857fcc)
runc version: N/A (expected: 54296cf40ad8143b62dbcaa1d90e520a2136ddfe)
init version: N/A (expected: 949e6facb77383876aeff8a6944dde66b3089574)
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.4.11-23.53.amzn1.x86_64
Operating System: Amazon Linux AMI 2016.03
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 3.862 GiB
Name: ip-10-0-11-117
ID: GDGQ:UTAI:LN3X:WWGD:N2ND:KDWP:HBIA:2ZMJ:IOQW:V65Z:SOWY:7EWE
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Operating system and kernel: (cat /etc/os-release, uname -r preferred)
uname -r:
4.4.11-23.53.amzn1.x86_64

cat /etc/os-release:
NAME="Amazon Linux AMI"
VERSION="2016.03"
ID="amzn"
ID_LIKE="rhel fedora"
VERSION_ID="2016.03"
PRETTY_NAME="Amazon Linux AMI 2016.03"
ANSI_COLOR="0;33"
CPE_NAME="cpe:/o:amazon:linux:2016.03:ga"
HOME_URL="http://aws.amazon.com/amazon-linux-ami/"

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
AWS
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node server, external DB
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Starting the Rancher server
Results:
As of this morning, I can't login to the UI (although I can see the login page) and am getting the following repeatedly (every second or so) in the logs:
time="2018-10-10T09:32:47Z" level=info msg="Starting Catalog Service (port 8088, refresh interval 300 seconds)"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x6c23fa]

goroutine 28 [running]:
panic(0xa336c0, 0xc42001a060)
	/usr/local/go/src/runtime/panic.go:500 +0x1a1
github.com/rancher/catalog-service/git.RemoteShaChanged(0xc4200fec30, 0x2c, 0xc4204604da, 0x6, 0xc4200fec90, 0x28, 0xc4204622a0, 0x24, 0x9bc0c0)
	/go/src/github.com/rancher/catalog-service/git/git.go:76 +0x2aa
github.com/rancher/catalog-service/manager.(*Manager).prepareGitRepoPath(0xc420182000, 0xc4204604a4, 0x6, 0xc4204604d0, 0x9, 0xc4200fec30, 0x2c, 0xc4204604da, 0x6, 0xc4200fec90, ...)
	/go/src/github.com/rancher/catalog-service/manager/local.go:86 +0x339
github.com/rancher/catalog-service/manager.(*Manager).prepareRepoPath(0xc420182000, 0xc4204604a4, 0x6, 0xc4204604d0, 0x9, 0xc4200fec30, 0x2c, 0xc4204604da, 0x6, 0xc4200fec90, ...)
	/go/src/github.com/rancher/catalog-service/manager/local.go:32 +0x99
github.com/rancher/catalog-service/manager.(*Manager).refreshCatalog(0xc420182000, 0xc4204604a4, 0x6, 0xc4204604d0, 0x9, 0xc4200fec30, 0x2c, 0xc4204604da, 0x6, 0xc4200fec90, ...)
	/go/src/github.com/rancher/catalog-service/manager/manager.go:102 +0x82
github.com/rancher/catalog-service/manager.(*Manager).refreshConfigCatalogs(0xc420182000, 0x1, 0x0, 0x0)
	/go/src/github.com/rancher/catalog-service/manager/manager.go:73 +0x2ae
github.com/rancher/catalog-service/manager.(*Manager).RefreshAll(0xc420182000, 0x526901, 0x0, 0x0)
	/go/src/github.com/rancher/catalog-service/manager/manager.go:39 +0x38
github.com/rancher/catalog-service/cmd.refresh(0xc420182000, 0x1)
	/go/src/github.com/rancher/catalog-service/cmd/root.go:177 +0x38
github.com/rancher/catalog-service/cmd.autoRefresh(0xc420182000, 0x12c)
	/go/src/github.com/rancher/catalog-service/cmd/root.go:186 +0x4f
created by github.com/rancher/catalog-service/cmd.run
	/go/src/github.com/rancher/catalog-service/cmd/root.go:145 +0x50e

Everything has been running smoothly for months, nothing has changed so I'm not sure where to go from here?

I managed to get it working by changing the catalog URLs from this:
https://git.rancher.io/community-catalog.git
https://git.rancher.io/rancher-catalog.git
To this:
https://github.com/rancher/community-catalog.git
https://github.com/rancher/rancher-catalog.git
The git.rancher.io URLs are 404'ing, which I guess is a separate issue. I'll leave this open for now but the original problem is resolved.

The nameservers were changed for rancher.io, but seems to cause some stale entries in some caching nameservers. If I spin up a new AWS instance now, I get the correct results.
The URLs always respond with 404 via web, its supposed to be fetched from Git. The NPE was fixed in v1.6.5 (https://github.com/rancher/rancher/issues/9378)


IAM ListRolePolicies NoSuchEntityException

Description:

What issue is being seen?  Describe what should be happening instead of the bug, for example: Cartography should not crash, the expected value isn't returned, the data schema is wrong, etc.

Another IAM-related race condition. Expectation: we should skip missing roles.
To Reproduce:

Steps to reproduce the behavior.  Provide all data and inputs required to reproduce the issue.

Run IAM sync and have a role not exist when ListRolePolicies is called.
Logs:

If applicable, copy and paste your console log with the failing stack trace.

Traceback (most recent call last):
  File "{PATH}/intelmodules/syncgraph.py", line 220, in <module>
    main(argv)
  File "{PATH}/intelmodules/syncgraph.py", line 210, in main
    return cartography.sync.run_with_config(sync, config)
  File "/lib/python3.6/site-packages/cartography/sync.py", line 145, in run_with_config
    return sync.run(neo4j_driver, config)
  File "/lib/python3.6/site-packages/cartography/sync.py", line 71, in run
    stage_func(neo4j_session, config)
  File "{PATH}/intelmodules/lyft/aws.py", line 234, in lyft_start_aws_ingestion
    common_job_parameters
  File "/lib/python3.6/site-packages/cartography/intel/aws/__init__.py", line 96, in _sync_multiple_accounts
    _sync_one_account(neo4j_session, boto3_session, account_id, sync_tag, common_job_parameters)
  File "/lib/python3.6/site-packages/cartography/intel/aws/__init__.py", line 27, in _sync_one_account
    iam.sync(neo4j_session, boto3_session, account_id, sync_tag, common_job_parameters)
  File "/lib/python3.6/site-packages/cartography/util.py", line 58, in timed
    result = method(*args, **kwargs)
  File "/lib/python3.6/site-packages/cartography/intel/aws/iam.py", line 656, in sync
    sync_roles(neo4j_session, boto3_session, account_id, update_tag, common_job_parameters)
  File "/lib/python3.6/site-packages/cartography/util.py", line 58, in timed
    result = method(*args, **kwargs)
  File "/lib/python3.6/site-packages/cartography/intel/aws/iam.py", line 595, in sync_roles
    sync_role_inline_policies(current_aws_account_id, boto3_session, data, neo4j_session, aws_update_tag)
  File "/lib/python3.6/site-packages/cartography/intel/aws/iam.py", line 611, in sync_role_inline_policies
    inline_policy_data = get_role_policy_data(boto3_session, data["Roles"])
  File "/lib/python3.6/site-packages/cartography/util.py", line 58, in timed
    result = method(*args, **kwargs)
  File "/lib/python3.6/site-packages/cartography/intel/aws/iam.py", line 120, in get_role_policy_data
    policies[arn] = {p.name: p.policy_document["Statement"] for p in resource_role.policies.all()}
  File "/lib/python3.6/site-packages/cartography/intel/aws/iam.py", line 120, in <dictcomp>
    policies[arn] = {p.name: p.policy_document["Statement"] for p in resource_role.policies.all()}
  File "/lib/python3.6/site-packages/boto3/resources/collection.py", line 83, in __iter__
    for page in self.pages():
  File "/lib/python3.6/site-packages/boto3/resources/collection.py", line 166, in pages
    for page in pages:
  File "/lib/python3.6/site-packages/botocore/paginate.py", line 255, in __iter__
    response = self._make_request(current_kwargs)
  File "/lib/python3.6/site-packages/botocore/paginate.py", line 332, in _make_request
    return self._method(**current_kwargs)
  File "/lib/python3.6/site-packages/botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/lib/python3.6/site-packages/botocore/client.py", line 661, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.NoSuchEntityException: An error occurred (NoSuchEntity) when calling the ListRolePolicies operation: The role with name NAME_HERE cannot be found.

Please complete the following information::

Cartography release version or commit hash [e.g. 0.12.0 or 95e8e11913e2a44a4d4682506d8364a638ceac69]
ae416a05c2451e6d018ef420714be972fc4853c9

@mdrdannyr your favorite! :P

Haha @achantavy I can look into this next week if no one else is handling
Should be a quick fix 😄


Add to_date Spark function

@mbasmanova
can you help to review this PR? Thanks.

@rui-mo Thanks for your reply, the latest implementation of to_date function in spark is indeed by using a combination of
GetTimestamp and Cast (from timestamp to date). As far as I can see, the function castToDate is ready. If the function GetTimestamp is also ready, the to_date function appears to be completed. So does GetTimestamp have an expected readiness time

So does GetTimestamp have an expected readiness time

@CLTFOREVER Thanks for checking. cc @PHILO-HE

Hi @CLTFOREVER, FYI, we created a PR for supporting get_timestamp: https://github.com/facebookincubator/velox/pull/8004.


Should we include hapiplot?

It's not a core package technically (or a PyHC package in general, which may be an oversight), but it is necessary for HAPI's plotting capabilities. Should we include hapiplot?

If we include it, publish the new PyPI version via GitHub Actions (#7).

Discussions in the past indicated that hapiplot was really just about demonstrating that HAPI worked and people shouldn't be going out of their way to use it.


Library and Sample App

As a developer, I want atam4j to be converted to a java library that can be easily included into existing projects that want to leverage the library to use acceptance tests as monitors.
Additionally, I want a separate Sample application using the atam4j library and demonstrating its use.

Have split the sample app work into a different story - https://github.com/atam4j/atam4j/issues/8
This particular issue can thus be closed.


Is jumping out to config network on any device failing to write too aggressive?

Maybe if some devices fail to write, we should stay connected to wlan, but surface an error condition to the API and maybe even an e-mail to the user instead of taking the whole unit offline.
I think the original vision was that if one of the devices is failing to write, the device is taken offline (but data saved) to encourage the user to inspect it and find out what's going wrong.

Will be resolved by #68.


Create docker-readme.md

This is a file required for the Apache automated 'build based on tags' mechanism.
Tags that look like v0.6.0 or will automatically build an image of the same tag at docker hub in the apache repository named apache/incubator-age and will make this file the readme.md for the image.

This directory is planned to be deleted.

Closing this request because the documentation directory will be deleted.
The docker-readme.md will be placed in root via a separate pull request.


Fix how BlockAttributes are encoded by LightClientHandler

closes #6262
We have two encodings for network messages and all associated stuff. SCALE encoding is used by legacy sync protocol and then there's also new protobuf-based encoding that is used by all new protocols. In legacy protocols, BlockAttributes is encoded as single u8. In new protocols, it is encoded as u32. The issue is that there are two places where new requests are built - one is regular sync and second one is where light node is fetching block body on demand.
Given that ^^^, I can't simply change BlockAttributes to be u32, or change how it is encoded - so I'm just fixing the way it is encoded by LightClientHandler.

bot merge

(you might have to merge master)

thank you for trying processbot - it has been offline but if you try again it should respond


Extending Boids simulation with entropy calculation and visualization.

Hi Christopher,
I have extended your boids-js simulation with a form of entropy calculation and the result appears on a new graph layer above boids. Some of your parameters became configurable as well to let the users play with them.
I was interested in whether boids converge to a stable state when there is only one large flock and how the disorder in the system changes over time.
You can check the current version here.
I hope you like my extension.
Bests,
Richárd Szabó

Thanks, this is cool! It's fascinating how the entropy waxes an wanes so
organically despite being a simple, deterministic simulation.
As the README states, this was primarily written as a demo for Skewer,
an interactive JavaScript mode for Emacs, and it continues to serve this
purpose. The parameters are very intentionally hidden away to be
adjusted on the fly via JavaScript evaluation rather than through a UI.
:-) The entropy additions also seem to come with a moderate performance
hit, especially as the graph grows.
You made this a pull request, but given those two points above, I don't
want to merge these changes as the "official" master version. However, I
will very gladly link to your version from my README. If you give me a
PR that adds a paragraph to the README describing your version along
with a couple of links (your repository and your hosted version), I'll
merge it so that people can find your version easily.


Regression wrong error message during tests if runtime error occurs after constructor

Bug Report or Feature Request (mark with an x)
- [ x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.2.2
node: 6.11.0
os: win32 x64
@angular/animations: 4.3.3
@angular/common: 4.3.3
@angular/compiler: 4.3.3
@angular/core: 4.3.3
@angular/forms: 4.3.3
@angular/http: 4.3.3
@angular/platform-browser: 4.3.3
@angular/platform-browser-dynamic: 4.3.3
@angular/router: 4.3.3
@angular/cli: 1.2.2
@angular/compiler-cli: 4.3.3
@angular/language-service: 4.3.3
Repro steps.

Create new project with @angular/cli version 1.2.2 or newer
Modify src/app/app.component.ts, add  OnInit interface and add any runtime error to ngOnInit
run ng test

Simple runtime error example:
...
export class AppComponent implements OnInit {
  title = 'app';
  example: string;

  ngOnInit() {
    console.log(this.example.length);
  }
}

The log given by the failure.
 Error: Failed to execute 'send' on 'XMLHttpRequest': Failed to load 'ng:///DynamicTestModule/AppComponent_Host.ngfactory.js'.
   at http://localhost:9876/_karma_webpack_/polyfills.bundle.js:5182:35
   at XMLHttpRequest.proto.(anonymous function) [as send] (http://localhost:9876/_karma_webpack_/polyfills.bundle.js:3767:20)
   at Array.<anonymous> (node_modules/source-map-support/browser-source-map-support.js:107:176)
   at node_modules/source-map-support/browser-source-map-support.js:101:106
   at Array.<anonymous> (node_modules/source-map-support/browser-source-map-support.js:107:474)
   at node_modules/source-map-support/browser-source-map-support.js:101:106
   at a (node_modules/source-map-support/browser-source-map-support.js:101:312)
   at b (node_modules/source-map-support/browser-source-map-support.js:104:348)
   at node_modules/source-map-support/browser-source-map-support.js:105:245
   at Array.map (native)

Desired functionality.
Display the actual error message with details about the error. Here's the output from 1.2.1.
@angular/cli: 1.2.1
node: 6.11.0
os: win32 x64
@angular/animations: 4.3.3
@angular/common: 4.3.3
@angular/compiler: 4.3.3
@angular/core: 4.3.3
@angular/forms: 4.3.3
@angular/http: 4.3.3
@angular/platform-browser: 4.3.3
@angular/platform-browser-dynamic: 4.3.3
@angular/router: 4.3.3
@angular/cli: 1.2.1
@angular/compiler-cli: 4.3.3
@angular/language-service: 4.3.3
Failed: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
    at AppComponent.webpackJsonp.../../../../../src/app/app.component.ts.AppComponent.ngOnInit (http://localhost:9876/_karma_webpack_/main.bundle.js:120:33)
    at checkAndUpdateDirectiveInline (http://localhost:9876/_karma_webpack_/vendor.bundle.js:47071:19)
    at checkAndUpdateNodeInline (http://localhost:9876/_karma_webpack_/vendor.bundle.js:48567:17)
    at checkAndUpdateNode (http://localhost:9876/_karma_webpack_/vendor.bundle.js:48506:16)
    at debugCheckAndUpdateNode (http://localhost:9876/_karma_webpack_/vendor.bundle.js:49367:59)
    at debugCheckDirectivesFn (http://localhost:9876/_karma_webpack_/vendor.bundle.js:49308:13)
    at Object.eval [as updateDirectives] (ng:///DynamicTestModule/AppComponent_Host.ngfactory.js:8:5)
    at Object.debugUpdateDirectives [as updateDirectives] (http://localhost:9876/_karma_webpack_/vendor.bundle.js:49293:21)
    at checkAndUpdateView (http://localhost:9876/_karma_webpack_/vendor.bundle.js:48473:14)
    at callWithDebugContext (http://localhost:9876/_karma_webpack_/vendor.bundle.js:49693:42)

Mention any other details that might be useful.
This error is still occurring in 1.3.0-rc.5, the regression was added in 1.2.2, https://github.com/angular/angular-cli/commit/19f04af0777391cc72d096a0e315fe87bab161c6.
If a runtime errors occur during the constructor then the proper error displays, but sourcemaps still fail to show line in TypeScript.
It would be best if the actual error and line in typescript could be referenced.

For me it's failing in addEventListner()
  receiveMessage() {
    this.commonService.getNativeWindow().addEventListener(
      'message',
      (e) => {
        if(e.origin.match(/localhost/) && e.data['myIframe']) {
          if(!this.bypassCookie) {
            this.getConfig(e.data);
          }
        }
      }, false)
  }

zone.js:2642 XMLHttpRequest cannot load ng:///DynamicTestModule/MyComponent_Host.ngfactory.js.  Your service/function may not be returning what you expect, you'll see a better message with sourcemaps off.

@playground I had this same issue, and when I ran ng test --sourcemaps=false, I got feedback on the test that failed like "TypeError: Cannot read property 'count' of undefined", where I had a child component like this:
<span>{{entity.count}}</span>

Where entity was defined in the parent component, and defined asynchronously. So I added the safe navigation operator to the property binding like {{entity?.count}}, and that error went away.

@JSMike @nathanBrenner thanks, I will give that a try.

@nathanBrenner thanks, disabling sourcemaps for unit tests lets me now debug the actual error

I have same result on 1.3.0:
sharikovvlad:~ svlad$ ng --version
    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/
@angular/cli: 1.3.0
node: 8.3.0
os: darwin x64

When the project has been ejected, how can we translate the --source=false option into karma.conf.js options?
https://github.com/angular/angular-cli/issues/6583 mentions a few options but nothing seems very conclusive.

Had that issue until I just reinstalled the node_modules also I am running the latest angular cli version which is 1.4.9

Sadly, the npm test --source=false flag does not work for me. I still can't see the right error message.  I upgraded to the latest node and angular/cli and it still didn't work with npm test. ng test with the --sourcemaps=false allows me to see the error. Thanks.

@joey-borowicz full stack trace?

@benelliott sorry, should have been more clear. There is no stack trace, and I was hoping that --sourcemaps=false would produce a more traceable error.

@joey-borowicz Have you tried re-enabling source maps, then using the Debug button in the Karma window and opening up your console to see the error?

@benelliott thanks, now I see that I am getting a server error

@kamok "npm test --anything" is not working. You have to use "npm test -- --anything" to pass parameters to whatever npm test is.

This approach, ng test -sm=false works, but I do not think it has solved the fundamental problem. I did some experiments today, studied it in depth, and share some results @here, hoping to be helpful.
In Chrome, some additional information appeared in the browser console of Karma DEBUG runner:
ng: ///DynamicTestModule/SandboxComponent.ngfactory.js: Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, https.

I think the root cause is here.
So, I switch to Firefox. It works.
So, I think the fundamental reason here is that Chrome's cross-domain detection is stronger than Firefox, blocking the ng:/// protocol in the sourcemaps, causing this issue.
So, I think, maybe we can just replace the "ng: ///" prefix with a prefix such as "http: ///" to resolve this issue.

I found that this only happens when an error occurs during CD in my case.
This can range from things like you template referencing components that aren't in the module or having an exception thrown in a lifecycle hook or any view related errors.
to confirm this you can do
it('should fail', () => {
    component.detectChanges();
    component.componentInstance.throw();
    expect(true).toEqual(false);
  })

with your component looking like
throw(){
  throw new Error('err');
}
ngOnInit(){
  throw new Error('err');
}

Now if you run with ng test the browser will hang and eventually crash, you can see the error in the chrome log.
However, if you remove the error from ngOnInit then it throws it as expected and dosen't break
then swapping to ng test --sm=false it always works as expected

I see this error '[object ErrorEvent] thrown' when I run all tests.
There are always 1 - 3 test failing with this error, and it is not always the same tests failing. Run it a second time and other tests will fail.
If I run the spec which contains the fail test (the spec itself contains multiple tests) then the test does not fail.
Running 'ng test --sourcemaps=false' does not provide any additional information.
I'm using chrome, and the following version.
`Karma v1.7.1
Angular CLI: 1.5.0
Node: 8.9.1
OS: win32 x64
Angular: 4.4.6
angular/cli: 1.5.0
angular-devkit/build-optimizer: 0.0.35
angular-devkit/core: 0.0.22
angular-devkit/schematics: 0.0.41
ngtools/json-schema: 1.1.0
ngtools/webpack: 1.8.0
schematics/angular: 0.1.10
schematics/schematics: 0.0.10
typescript: 2.6.1
webpack: 3.8.1`

the ng:/// prefix in source-map is added by : https://github.com/angular/angular/blob/master/packages/compiler/src/compile_metadata.ts#L683 and then loaded by the CLI via source-map-loader.
So, I think we can convert all sourcemaps to base64 sourceMapUrl.

Experiencing this issue when running an Angular app within a JavaFX Webview, as opposed to unit tests. Building with sourcemaps=false fixes the issue. JavaFx under the hood this is just plain WebKit.
Specific user agent:
JavaFX webkit version: Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/604.1 (KHTML, like Gecko) JavaFX/9 Safari/604.1
It would be interesting to know if anyone gets this when running with something like PhantomJS.

@limpygnome we definitely had the problem when running our unit tests with PhantomJS. But I think this also happened when running them with Chrome (with the then current version, i.e. something around version 60) so maybe not restricted to WebKit based browsers (if I remember correctly we also had this when running the tests through Firefox).

For me it's failing during import ngrx StoreModule.forRoot([reducers]) to test.

Experiencing this issue with CLI 1.6.1

1.6.6. - the error is still there, unfortunately. Disabling sourcemaps give some degree of clarity, but it's clearly just a workaround. Anyone has some ideas or guidelines on how not to get this error?

Seeing the issue with angular cli 1.6.5 on ubuntu with Chrome 64.0.3282.140

I am using angular cli v 1.6.5. In my case ng test --sourcemap=false is not returning any error but ng test is giving the error similar to mentioned in original issue.
As I need to generate Istanbul code coverage report, which requires sourcemap for typescript files to generate it properly, I tried to run tests using Firefox instead of Chrome and it worked well.

I'm experiencing this issue - wasted a good 2-3 hours until I found this.
Any plans to fix?

I'm facing the same issue, but with an ejected project.
How to --sourcemap=false when running tests with karma start ?

I wrote in post before: in karma.konf.js
angularCli: {
environment: 'dev',
sourcemaps: false
},

@asmolientsev  thanks, missed that.

Still reproduces on Angular CLI 1.7.3. --sourcemap=false flag resolves this issue

I saw an "Uncaught NetworkError: Failed to execute 'send' on 'XMLHttpRequest': Failed to load 'ng:///DynamicTestModule/..too when writing a new component test.
In my case the reason was a poorly written template with *ngIf="queryTable.data". Revising this to *ngIf="queryTable && queryTable.data" solved the problem for me.
I think this confirms the observation from @Toxicable https://github.com/angular/angular-cli/issues/7296#issuecomment-347359285

@cf33 as a note, you can should use the angular operator. *ngIf="query Table?.data"

I solved this problem by using propa?.propb instead of propa.propb in my template, without turn off source map, and the ng:// protocol works well in Chrome.

In angular 6, the cryptic error message related to http call is now replaced with [object ErrorEvent] thrown :/
Also for command line: --source-map=false argument continues to work

any update? sourceMap=false doesn't help (angular-cli 6.0.8)

@Viktor-Bredihin it's --source-map=false now

Using Angular CLI 1.3.2, Angular 4.4.7, and the given demo, I get
Executed 0 of 4 DISCONNECTED (10.003 secs / 0 secs)
instead of the failed to execute send. The above workaround still works.

We have had this issue for more than a year now. We have to switch between --source-map=true and --source-map=false all the time. Can this issue be reopened?

I have found the cause. It has nothing to do with karma, but the issue is triggered by the source-map-support package which is installed by @angular/angular-cli.
The Angular source maps refer to paths like ng:///DynamicTestModule/YourComponent.ngfactory.js which triggers CORS errors.
Should be fixed by https://github.com/evanw/node-source-map-support/pull/222 and/or by the Angular CLI.

The test alone (fit) was passing but with all test running failed causing jasmine to report other test as faield - not sure why.
In my case I was missing the error handler in subscribe() function:
service.getOperations().subscribe(() => {
      fail('Should complete with an error.');
    },
      () => { /* must be defined in order to test success */ }, // after adding this the error disappeared
      () => { });

I found same solution like @felikf

Closing this as I cannot reproduce locally the first issue on master:

Please note that the comments about subscription and asynchronicity in Jasmine are not CLI issues, and are working as intended. Do you need to have a done argument in your Jasmine test handler? That might be the cause, if your tests are asynchronous and not handling Zone properly.

If you find a similar or different issue, please open a new issue so we can track that one. Original issue was fixed.


Computer doesn't recognize gulp after installation

This tracker is for bug reports only.
Before opening an issue, please make sure you've checked the following:

For support requests, please use Stack Overflow (stackoverflow.com) or Gitter (see the README).

If the bug is in a plugin, open an issue on the plugin repository, not the gulp repository.

If you're getting a deprecated module warning, don't worry about it: we're aware of it and it's not an issue. To make it go away, update to Gulp 4.0.

If you're asking about the status of Gulp 4, please don't! You can see the remaining issues on the gulp4 label: https://github.com/gulpjs/gulp/issues?q=is%3Aissue+is%3Aopen+label%3Agulp4

What were you expecting to happen?
For the command to run my gulp tasks
What actually happened?
I got an error. gul command not ...
So i had to use npx gulp
Please post a sample of your gulpfile (preferably reduced to just the bit that's not working)
gulp.task(function () {});

What version of gulp are you using?
2 i guess
What versions of npm and node are you using?
Node 10.x
Npm 6
Why is this happening is it my computer or npm?

gul will never be a command, only gulp.


Confirmation of TAI_NETWORK_INTERFACE_ATTR_DSP_STATUS.

Hi everyone, I think user who use the CFP2ACO want to know the two kind of the FAULT alarm for ACO and DSP.
As of now, it looks there is one FAULT alarm in "TAI_NETWORK_INTERFACE_ATTR_OPER_STATUS".
This FAULT alarm is for ACO. Is that right?
And I think we need RMV alarm for maintenance.
What do you think if I add the following new ID for DSP?
_tai_network_interface_attr_t
ID: TAI_NETWORK_INTERFACE_ATTR_DSP_OPER_STATUS
type(parameter): RMV or FAULT
But I also still consider the case of DCO.
Thank you.

@JumpeiHongo I agree to have an attribute for DSP status.
What it RMV?
Do we have any reference we can use for this attribute in a spec like OpenROADM, OpenConfig, CFP MSA?
@samisaab I believe this attribute can also be used for DCO transceiver. Am I correct?

@ishidawataru

Do we have any reference we can use for this attribute in a spec like OpenROADM, OpenConfig, CFP MSA?
I will confirm if I share the alarm list fr OpenROADM MSP project.

It looks there are only types for alarms below.
https://github.com/OpenROADM/OpenROADM_MSA_Public/tree/master/model/Common
I think the alarms for OpenROADM are vendor specific.

oh, I thought what you are saying by DSP status means internal status of DSP (e.g initialization, loss-of-signal etc..)
As for the physical module presence, we have module_presence callback.
When PIU is removed, we can call this callback with presence=false.

@ishidawataru and all
I see about PIU removed status. thank you.
Could you please confirm below?
http://openroadm.org/download.html
20171121a Open ROADM MSA specification ver 2 00.xlsx
You can understand the alarm for Open ROADM.
Caution to read:
1.This Spec is for Transponder not including the Switch device.
2.If you see this file, you can see "W SWITCH functional" sheet. This is not L2 SWITCH.


Bower & NPM

Please register this in Bower and NPM.  I would love to consume it right away!

yea i've been pushing this out for a while now, and your not the first to ask!!! maybe over the easter weekend :)

+1 for npm and bower, its not that hard
for bower: create bower.json http://bower.io/docs/creating-packages/ and add a tag "v0.0.1" in your github
for npm: create package.json and register at npmjs.com

I would honestly submit a pull request, but no one should feel good about
registering the bower and npm package names for a repo they don't own. ;)
On Wed, Apr 1, 2015 at 2:15 AM Nick Serebrennikov<EMAIL_ADDRESS>wrote:

+1 for npm and bower, its not that hard
for bower: create bower.json http://bower.io/docs/creating-packages/ and
add a tag "v0.0.1" in your github
for npm: create package.json and register at npmjs.com
—
Reply to this email directly or view it on GitHub
https://github.com/ceolter/angular-grid/issues/20#issuecomment-88388908.

on my 'todo' list for tonight!! get it onto bower!! this will also help with knowing how many people are using it.

@ceolter Hi, awesone grid!
I think also will be good if you could use "bower" to resolve the dependencies of angular-grid and delete the lib folder.

accidental reference there.. edited, but don't know how to remove the reference


feat(ci): Add automatic spellcheck on codebase to CI

Adds spell checking via codespell package as a CI check.

Configured to ignore most files specified in .gitignore

The ignore list is copied from .gitignore, so would be needed  to be updated separately.

Adds the CI spellcheck-code to spellcheck the codebase.
Applies any pending spelling mistakes flagged by codespell

LGTM 👍

LGTM 👍


Use tpl render on external domain name for providing values dynamically

Motivation
External access might require dynamic domain names to be used as the ADVERTISED DOMAIN names
Approach
Add template rendering using tpl functions for external domain value
Usecase

When external access is enabled for the Redpanda service, the domain names are advertised by the brokers based on the Values.external.domain configuration.
For internal clients the cluster local endpoints work just fine, but
Currently we do not have an option to dynamically set the external domains as we might have multiple environments or stacks were Redpanda is deployed (dev/qa/prod etc).
Having the external domain name configurable through values file and tpl rendered, we could use helm library functions to override the domain names appropriately for the stacks that we deploy Redpanda.

Would you please describe a use case, either in the description or an associated issue so it can be properly documented?

Would you please describe a use case, either in the description or an associated issue so it can be properly documented?

Thank you @joejulian, for looking into this, I've updated the description with the use case for this capability.

The Chart.yaml needs a patch version bump and the upgrade test is failing:
 Error: UPGRADE FAILED: template: redpanda/templates/certs.yaml:52:19: executing "redpanda/templates/certs.yaml" at <$values.external.domain>: wrong type for value; expected string; got interface {}

The Chart.yaml needs a patch version bump and the upgrade test is failing:
 Error: UPGRADE FAILED: template: redpanda/templates/certs.yaml:52:19: executing "redpanda/templates/certs.yaml" at <$values.external.domain>: wrong type for value; expected string; got interface {}

@joejulian bumped up the chart patch version, also fixed the issue with the default value test, all tests have passed now, thanks!

@joejulian committed suggestions as well fixed a var typo, please verify, thank you!


Hardcode a Subscribe button on Prachee's and Kenton's lists

[ ] Hardcode a button on Prachee's and Kenton's pages

[ ] Typeform for Kenton's list: https://xag0lodamyw.typeform.com/to/DxFgFs13
[ ] Typeform for Prachee's list: https://xag0lodamyw.typeform.com/to/OPBgQWgb

[ ] Alert Outreach to spread the word


Add specific DestinationRule for SimpleIngress test

This PR fixes: https://github.com/istio/istio/issues/15577 and allows the simple test to be run on an mTLS activated istio cluster e.g. if you want to run the e2e tests on an existing istio cluster.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: johscheuer
To complete the pull request process, please assign nmittler
You can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @johscheuer. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ping @nmittler @costinm

/ok-to-test

@johscheuer: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-lint-master

e2e-simpleTests-distroless-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-distroless-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-lint-master

e2e-simpleTests-distroless-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-distroless-master

e2e-simpleTests-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-lint-master

e2e-simpleTests-distroless-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-distroless-master

e2e-simpleTests-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-master

e2e-bookInfoTests-trustdomain-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-lint-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-lint-master

e2e-simpleTests-distroless-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-distroless-master

e2e-simpleTests-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-master

e2e-bookInfoTests-trustdomain-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-bookInfoTests-trustdomain-master

istio-racetest-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-simpleTests-distroless-master

e2e-bookInfoTests-trustdomain-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-bookInfoTests-trustdomain-master

istio-racetest-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-racetest-master

e2e-simpleTests-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-trustdomain-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test e2e-bookInfoTests-trustdomain-master

istio-racetest-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-racetest-master

e2e-simpleTests-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-master

e2e-simpleTests-distroless-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-distroless-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-racetest-master
e58320c378625c9bef5034fa07291cd8fd6309c5
link
/test istio-racetest-master

e2e-simpleTests-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-master

e2e-simpleTests-distroless-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-distroless-master

e2e-bookInfoTests-trustdomain-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-master

e2e-simpleTests-distroless-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-distroless-master

e2e-bookInfoTests-trustdomain-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-bookInfoTests-trustdomain-master

istio-pilot-multicluster-e2e-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-simpleTests-distroless-master

e2e-bookInfoTests-trustdomain-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-bookInfoTests-trustdomain-master

istio-pilot-multicluster-e2e-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test istio-pilot-multicluster-e2e-master

e2e-simpleTests-master
822128dc72fa1457cf355b204d4a12e6a34749f8
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-trustdomain-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test e2e-bookInfoTests-trustdomain-master

istio-pilot-multicluster-e2e-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test istio-pilot-multicluster-e2e-master

e2e-simpleTests-master
822128dc72fa1457cf355b204d4a12e6a34749f8
link
/test e2e-simpleTests-master

e2e-simpleTests-distroless-master
822128dc72fa1457cf355b204d4a12e6a34749f8
link
/test e2e-simpleTests-distroless-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johscheuer: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-pilot-multicluster-e2e-master
40236cb7c0d7e6e7f19e97cc4c126a9713adfa8c
link
/test istio-pilot-multicluster-e2e-master

e2e-simpleTests-master
822128dc72fa1457cf355b204d4a12e6a34749f8
link
/test e2e-simpleTests-master

e2e-simpleTests-distroless-master
822128dc72fa1457cf355b204d4a12e6a34749f8
link
/test e2e-simpleTests-distroless-master

e2e-bookInfoTests-trustdomain-master
822128dc72fa1457cf355b204d4a12e6a34749f8
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

After investigating some time again I noticed that the DR actually breaks the tests. In our clusters are the automatic sidecar injection is disabled (since we are using PSP) and we ware still in the progress to upgrade to 1.15. The tests failing in our clusters are because the deployments didn't had the sidecar configured 🤦♂ I tested this with custom istioctl kube-inject modified manifests and everything worked as expected. I assume a little statement for the e2e/conformance tests would be nice like :currently the automatic sidecar injection is required to run these tests.
Sorry ! But I appreciate your effort working on this PR.


Revert documention generator fork.

Now that the change to the documentation generator to document constant
values has landed, revert the fork and pin to the latet master version.

/ok-to-test

/ok-to-test

@jpeach this should be unblocked now that #519 is in. Once you rebase I'll go ahead and LGTM this.

@jpeach this should be unblocked now that #519 is in. Once you rebase I'll go ahead and LGTM this.

Thanks!
/lgtm

Thanks!
/lgtm


Unify single-summary locking and advancement of summaryGenTag property in logging

Per discussion https://github.com/microsoft/FluidFramework/pull/7269#discussion_r697576291, it would be great to do two things:

summaryGenTag not to advance on each retry in RunningSummarizer.trySummarize. Essentially move ownership of this counter / telemetry from SummaryGenerator into RunningSummarizer, create single way to do various maintenance activities around calling SummaryGenerator.summarize() for all code paths originating from RunningSummarizer (i.e. trySummarize, summarizeOnDemand, tryRunEnqueuedSummary).
As result of this work, remove two ways we implement locks to ensure there is only one summary going on at the same time. Currently it's done through RunningSummarizer.summarizingLock, but also through SumnmaryGenerator.isSummarizing and similar methods. That creates a lot of extra code that is not needed and is very hard to follow why it's needed.

Raised PRs for both


Lambda S3 bucket permissions are too permissive

Problem description
This describes a code issue and an example issue related to granting s3 bucket permissions to the lambda.
The examples for giving bucket permissions look like:
TITILER_STACK_BUCKETS='["my-bucket*", "*"]'

The code that creates the permissions looks like:
if settings.buckets:
            perms.append(
                iam.PolicyStatement(
                    actions=["s3:GetObject", "s3:HeadObject"],
                    resources=[f"arn:aws:s3:::{bucket}*" for bucket in settings.buckets],
                )
            )

One issue is that the example should be my-bucket rather than my-bucket*, since that ends up with an s3 permission on arn:aws:s3:::my-bucket** and ``arn:aws:s3:::**` (double wildcard), which is no different than a single *. Most users likely want to only grant access to the exactly-named bucket, not all buckets prefixed with that value, so I think it is a misleading example.
However, even with a TITILER_STACK_BUCKETS that only has my-bucket, I think the resource URN generated for the permissions should have a / between the bucket and *, e.g., arn:aws:s3:::{bucket}/*, because arn:aws:s3:::{bucket}* gives permissions to any bucket that is prefixed with the TITILER_STACK_BUCKETS value, not just all the objects in the one named buckets.
I could imagine a scenario where a user had buckets foo and foo-private, and putting just foo in TITILER_STACK_BUCKETS is inadvertently granting access to foo-private.
Expected Output
A CFN template that only has exactly the access to the buckets specified.
Environment Information
Os, Python version, ...

@philvarner thanks for the report. Do you have a solution for this?
is
if settings.buckets:
    perms.append(
        iam.PolicyStatement(
            actions=["s3:GetObject", "s3:HeadObject"],
            resources=[f"arn:aws:s3:::{bucket}/*" for bucket in settings.buckets],
        )
    )

what should be the proper CFN?

Yes, if the intention is to give access to all the objects in the bucket.

Yes, if the intention is to give access to all the objects in the bucket.

maybe we can add a key settings (with default to *):
if settings.buckets:
    perms.append(
        iam.PolicyStatement(
            actions=["s3:GetObject", "s3:HeadObject"],
            resources=[f"arn:aws:s3:::{bucket}/{settings.key}" for bucket in settings.buckets],
        )
    )


Feature request -- nested object skipping

After reading through the code (and using it in a pet project -- great work! Thanks!!), I have come across a situation where I need some way to skip over nested objects to find specific keys in a map. I have been unpacking into a nested map and then walking the map, but that adds a frustrating amount of complexity to my case, when I'd rather just use the msgpack binary blob as the memory backing the data structure.
You have in your comments that there is no way to do nested skips without allocations, but couldn't you just add a counter into cmp_ctx_t that tracks some limited amount of nesting (configurable at compile-time)?
#define CMP_RECURSION_DEPTH 4
#define CMP_RECURSION_DEPTH_BYTES 1

uint8_t recursion_count[CMP_RECURSION_DEPTH * CMP_RECURSION_DEPTH_BYTES];

Then each recursion can use CMP_RECURSION_DEPTH_BYTES to count up to the number of elements per recursion, and CMP_RECURSION_DEPTH can count up to the number of recursions supported. Obviously, this would be easier with allocations, but I completely understand your reluctance to add that.
Alternatively, you could handle it at runtime by adding
  uint8_t recursion_max; // set by cmp_ctx_init_with_recursion (new function)
  uint8_t recursion_stack[0]; // allocated along with the cmp_ctx_t struct

to the cmp_ctx_t struct. I think I'm over-complicating your very nice library, though.
If this is something you think is worthwhile, I would be happy to work on it and put in a PR for review. If not, I will likely still work on it and just keep the code in my own project. Thoughts?

Not sure if this solves your problem, but recursive skipping without allocation was implemented a couple of years ago (ea325ce). See cmp_skip_object(), cmp_skip_object_limit() and cmp_skip_object_no_limit(). With this you can e.g. skip over a map with multiple keys and values.

I read through the code, and it looked like the skip methods don't skip over the object, but actually read into the object for later skipping. I'll dig in again and see if that works for me. Thanks for responding!


add RWS bathymetry to nlmod.read.rws

add method to get configuration
add method to download index (geodataframe)
add method to download bathymetry data as xr.DataArray
add tests

test fails unrelated.


Add chris article on design discovery

based on this Loop post
more generic for a wider audience — focused on the discovery phase, why and how we did it and the value it provides

TODO:

[ ] Chris review
[ ] Jon review

@johnnyhowey can you take a look at Chris' draft and approve? We've removed any sensitive info and adapted it for a public audience, but just want to make sure that we didn't miss anything.
🙏

@plhnk, reviewed, and approved. Good job to @cj213x


rep with min and max

Related to #52, question was raised about parsers that repeat a min and a max number of times.  Here's a real-world case from RFC7321, which has a precision to the thousandths:
     qvalue = ( "0" [ "." 0*3DIGIT ] )
            / ( "1" [ "." 0*3("0") ] )

It's not real common, but they're out there.

Applicative replicateA will do it a fixed number of times, that with unions should work. That said we can pretty easily support it directly and be a bit more efficient.

Interesting, there's a case for it after all! We can resurrect some of that work.


Add detailed site-breakage data

This is intended to allow us to compute the overall priority of an
issue based on the factors we use in triage, rather than assigning the
impact/severity directly.
It adds a number of fields under 'breakage' that contain details about
the extent and impact of the breakage.
For now plain URLs are still allowed, to avoid having to rewrite all
existing entries at once.

Hmm, I based this on https://github.com/webcompat/knowledge-base/pull/65 so I guess I should pull out the foundational commits from that PR, put up a review for those, rebase this onto that branch, and then we can land this without also getting review of the features added in the updates draft.


Updated Remove-ComplianceTag.md

Fixes #5736

Docs Build status updates of commit 68af7fa:
:clock10: Full build: the average full build time is 18 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 68af7fa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Remove-ComplianceTag.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7f31e22:
:clock10: Full build: the average full build time is 18 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 7f31e22:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Remove-ComplianceTag.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Allowed Networks

Hello,
It is not actually a bug but probably an extension. Currently the lib supports WiFi and All for download types. This kind of fails for devices that are connected to the network via Ethernet and has no WiFi. In such case the only way to make downloads work is to allow all downloads which leads to allowing Cellular downloads too. It should be possible to allow Ethernet only without Cellular.
Best Regards,
Nick

@visuall Thanks for using Fetch!
How about I do this for you.
request = new Request(url, filePath);
request.setNetworkType(NetworkType.UNMETERED);

In the next version of Fetch due to be released this week, you will be able to specify NetworkType.UNMETERED
Best,
-Tonyo

@visuall If you would like to test. I pushed a preview build. You can test and let me know if it works well for you
implementation 'com.tonyodev.fetch2:fetch2:3.0.11-preview2'
//or android x
implementation 'androidx.tonyodev.fetch2:xfetch2:3.1.5-preview2'

New version of Fetch has been released. See readme for new version number.


tests hang with module Toaster

The module hangs when testing with module Toaster and cannot be killed by the job.
However, it does test okay locally with Rakudo 2018.03.

Any information on precisely which test hangs? Though depending on how the toaster copes with malformed output, it may be related to #30, which I just fixed.

I’ll check and see if I can get more info.

I got a good run on Toaster with no hangs.


perf(net): remove peers after multiple unsuccessful backoffs

now that we're reading peers from the persistent file it's more likely that peers are down.
offline peers are not removed from the peerset but are put in timeout.
This adds a max backoff cap after which we remove the peer from the set.
This would need some additional work because rn we don't distinguish between an IO error (ConnectionRefused) and a protocol error (TooManyPeers) when it comes to should_backoff, we only want to disconnect when we see ConnectionRefused multiple times in a row.
Not sure yet how to efficiently track this. don't want to introduce another counter. because peerset can reach several thousands of peers

As I wrote here, https://github.com/paradigmxyz/reth/pull/1252 removed the peers persistence, so i think we prob want to bring that back before doing this PR

closing this because the issue will be address via #1415


fix: remove error-wrapper (fix #629)

Thanks for the work, but it is better to work on PRs for changes that have been approved. You can find
a list of changes that have been approved in the issues by searching the intend to implement tag.
I'm closing this PR, as there is no plan to remove ErrorWrapper.


fix: remove volume attachment controller and update clean up logic

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

volume attachment controller is not necessary if we can be assured that all primary volume detachment requests will come through the controllerserver.
In this case, the controllers can suffice with VolumeDetachRequestAnnotation, and we can avoid unnecessary watches and update sequence.

Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.7%) to 44.391%

Totals

Change from base Build<PHONE_NUMBER>:
1.7%

Covered Lines:
186

Relevant Lines:
419

💛  - Coveralls


Question: Feasibility of having a pure-compute thread with no GC for realtime use

While working on narrowing down the macOS threading issue and digging through some GC and threading code in the runtime, I was wondering if there might be a solution to the problem of having a realtime thread (such as an audio thread that can't have dropouts) in a GC environment.
First, let me say I'm not completely up to date about the various newer GC variants - concurrent, etc. But I haven't come across any of these GC implementations that support having a single thread opt completely out of being stopped/hijacked for GC.
To explore the scenario I'm thinking about a little further... For realtime audio processing, you could implement your realtime audio thread purely with pinned objects (you would need to be careful of course). But largely it's already a compute only thread, so you could probably implement it completely without p/invokes and allocations. Only thing is it would be based upon a reverse p/invoke frame which would get called quite often.
So my question is, would it be feasible (for now just as a completely undocumented experiment of course), to change a few lines somewhere in the runtime to make a thread able to opt completely out of GC? Of couse all memory access from that thread would need to only happen on pinned objects. This would also mean we'd need to restrict access to framework objects, since they could not be pinned by user code, but maybe it would be enough to simply pin the object references accessed from the GC-free thread.
My assumption here is, that if all the objects accessed from the compute-only thread were pinned, then the GC would not need to stop the thread to be able to relocate it's references or to walk its roots, since because they're all pinned, they wouldn't relocate and their roots would already be in the handle tables.
The idea is then, that if the data structure needed by the GC-free thread needed updating, the objects could be unpinned, data rearranged, GC.Collect invoked and objects pinned again. That would mean controlled downtime of the realtime thread, which would be acceptable because it would be due to user input.
Is this completely off or is there something important I have forgotten?

You would not be ever able to allocate anything on the special thread, or read statics initialized by other thread. I think it would be pretty painful to guarantee that. The C# compiler or the runtime often inserts allocations on your behalf, and it is hard to audit your code for this. For example, even casts like IDisposable foo(object o) => (IDisposable)o; can allocate caches on GC heap or read statics initialized by other thread. I think it would be better to write the realtime processing loop in C.

Gotcha. Thanks for the quick reply, @jkotas. If that c code was running on a purely native thread, it wouldn't get stopped by the GC, right? Or is it process wide?

If that c code was running on a purely native thread

Right. .NET Core GC does not stop threads that are running unmanaged code.

Great, thank you Jan!


Dynamically add/remove endpoint

Hey, David
In this PR, I expose the inner Sender to support endpoint dynamic changes, for applications, without breaking changes.

connect_with_balance the same as the original connect except in balance only and saving the tx inside the Client struct
build_endpointshelper for applications to build Endpoints from str and options
is_dynamic
add_endpoint
remove_endpoint

Maybe in connect function, we should save the tx if there are more than one endpoint.
In addition, it's better to use Channel::balance_channel instead of Channel::balance_list which drops the inner tx. And tonic may be removed it in the future.

Thank you for your great job! Some comments:

No need to add new method connect_with_balance, just use connect. When we use etcd in production，we always create multiple ectd nodes (typically 3). I think it's OK to use Channel::balance_channel for even one endpoint.
Channel::balance_list is just a wrapper function of Channel::balance_channel, the tx is always created. We can directly store tx to Client, no need use Option and provide is_dynamic for detection.
add_endpoint and remove_endpoint should be symmetric (use same parameter type), use URL string instead of Endpoint, and do not expose structures from 3rd-party. So it's no need to expose build_endpoints. Client::connect set connection options and auth token for each endpoint, add_endpoint need to do the same.
Client::connect is a little bit complicated and you split it into several functions. I will refactor it and push to master branch. Keep the PR focused on its business.

I have refactored Client::connect in master, and rebase the PR. I also modify the PR, plase review my commit.

This PR is very valuable, and I revised it in my favor. Thanks again!


Debugger should allow for a timeout when debugger inside container

VSCode Version: 1.49.2
OS Version: Linux x64 5.4.0-7642-generic

Steps to Reproduce:

Setup a launch debugging configuration or compound where the preLaunchTask involves starting a Docker container in detached mode (like docker compose up -d)
Launch the debugging session
Observe the debugging session fail, not be launched or produce errors (like breakpoints not being mapped correctly)
Launch the session again and works normally.

This is probably happening because the debugging session is started before the containers spin up.
It should be possible to define a task timeout so that we can wait for the containers to start.

Does this issue occur when all extensions are disabled?: No (Extensions are necessary to debug, like the Python one)

Some debuggers support to increase the connection timeout, e.g. node-debug.
Please try that (or if your debug extension doesn't support "timeout" file an issue against the extension).

@joao-p-marques please reopen into https://github.com/microsoft/vscode-python


khronos: 3.6.1 -> 3.6.6

Motivation for this change
https://github.com/lainsce/khronos/releases/tag/3.6.5
https://github.com/lainsce/khronos/compare/3.6.1...3.6.5
https://github.com/lainsce/khronos/releases/tag/3.6.6
https://github.com/lainsce/khronos/compare/3.6.5...3.6.6
Backend was rewritten, but nothing to do from our side I think.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 148827 run on x86_64-linux 1

1 package built:

khronos


Link to API Documentation from README.md is broken

Click on "API documentation" link from README.md leads to
http://www.rubydoc.info/github/Shopify/active_merchant/master/file/README.md
and returns 404 Not Found page with text:

Sorry, but we couldn't find the page /github/Shopify/active_merchant/master/file/README.md in the Shopify/active_merchant GitHub repository. Are you sure that class, method, or file exists?

Updated - thanks!

Thank you for the fast feedback :construction_worker:


could meetecho get threads? an explicit @reply mechanism?

Description
people are adopting other IM norms to @person namecheck things, and presumably will continue. I am wondering if there is an explicit meetecho mechanism in planning to manage the semantic intent behind "reply"
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

Meetecho's chat is Zulip (meetecho's client acts as a zulip client), and the modality of communication available is informed by what zulip offers. Meetecho is already exposing Zulip's topic concept. Zulip's own UI has a "quote and reply" feature that we could look at using.

(That said, this isn't a datatracker issue - i'll move it to the right place in a bit).

thanks. appreciate the guidance and help to relocate the "improvement"
where it should be
On Tue, Mar 19, 2024 at 10:18 AM Robert Sparks @.***>
wrote:

(That said, this isn't a datatracker issue - i'll move it to the right
place in a bit).
—
Reply to this email directly, view it on GitHub
https://github.com/ietf-tools/datatracker/issues/7232#issuecomment-2005423616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABORQ7DBWINNN2PT3MXBCJTYY574XAVCNFSM6AAAAABE4RC3D6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGQZDGNRRGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

According to MeetEcho, the chat part of the client supports all the markup documented here: https://zulip.com/help/format-your-message-using-markdown, which includes mentions.
Replys can be done with markup, but there's not UI built to copy the text from a previous message into a quote for you.
Closing this datatracker issue. The better place for it at the moment is a email list discussion on<EMAIL_ADDRESS>if we need to take it further.


Changed NULL to nullptr

I changed each one individually to make sure there were no special cases, and changed NULL in comments to null instead of nullptr for readability.
No new compiler errors with these changes, which means that all uses of NULL were correct in the first place (i.e., no implicit conversions to int).

I really need to get Travis-CI up and running...


Fix searching default platforms

Fixed printing default platforms.
Signed-off-by: Fundakowski, Lukasz<EMAIL_ADDRESS>

Codecov Report

Merging #66 (9bfbdaf) into main (597c753) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   89.26%   89.18%   -0.09%
==========================================
  Files          41       41
  Lines        2012     2015       +3
==========================================
+ Hits         1796     1797       +1
- Misses        216      218       +2

Impacted Files
Coverage Δ

src/twister2/platform_specification.py
93.96% <50.00%> (-1.61%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix vendor extracted js modules not available in editor.

See #2370
I know sage has always registered the scripts at the same time they're enqueued so this solution might not be great to everyone.
Another option is to somehow fix it in the laravel mix config I guess.

editor.js should not be enqueued on the frontend.
By default, I do not enqueue vendor.js as it is not required with the default behavior, but can simply be enqueued in enqueue_block_editor_assets the same as it is in wp_enqueue_scripts.

editor.js should not be enqueued on the frontend.

No of course not, this PR only registers it.
If you prefer duplicating the wp_enqueue_script line rather than separating registrations from enqueues I'm fine changing the PR.
As for leaving it as it is, I'd vote no as you can't write es6 code without having to manually add vendor.js as a dependency. Something which isn't very straightforward to figure out since the "bug" doesn't issue any warnings/notices and comes from a babel runtime not mentioned anywhere in the sage code.

No of course not, this PR only registers it.

Ahh I see now. Sorry, I had initially replied on my phone.

As for leaving it as it is, I'd vote no

I agree with you. We should add it in, even if commented out by default (open to opinions) – at least until we have vendor splitting between the app and editor.
I would like to stick to using the original method of wp_enqueue_script, though.
More or less, just keep the original but change to something along the lines of (untested):
add_action('enqueue_block_editor_assets', function () {
    if ($manifest = asset('js/manifest.asset.php')->get()) {
        wp_enqueue_script('app/vendor.js', asset('js/vendor.js')->uri(), $manifest['dependencies'], $manifest['version']);
        wp_enqueue_script('app/editor.js', asset('js/editor.js')->uri(), $manifest['dependencies'], $manifest['version']);

        wp_add_inline_script('app/vendor.js', asset('js/manifest.js')->contents(), 'before');
    }

    wp_enqueue_style('app/editor.css', asset('css/editor.css')->uri(), false, null);
}, 100);

@Log1x I updated the PR but can't really see a good way to have it commented out since:

I think we should have it as a dependency of sage/editor.js otherwise I can potentially see some third party plugin breaking things. If you disagree I can of course remove it as a dependency.
As the inlined manifest needs come before sage/vendor.js we'd have to provide two version of that too.

I'm sorry! I completely forgot about this PR til today. I have added similar changes to #2413 so I'm closing this as it'll get merged it with that.


Base-level rules cannot contain the parent-selector-referencing character '&'. theme/material-components-web/checkbox/_mixins.scss

What Angular MDC version are you using?
Latest one
What browser(s) is this bug affecting?
What OS are you using?
MacOS
What are the steps to reproduce the bug?
Just try to run the project that was working before

Hey @grmaciel, I've tried duplicating with demo-app and a quick cli app to no avail. Could you provide  development environment (e.g.: angular-cli), and dependency versions?

@grmaciel Thank you. Just need the @angular/cli version?
Also, v0.34.4 was published yesterday if you'd like to try it.

@grmaciel I tested on a brand new @angular/cli project, no issues. If you have a repo, I can take a look.

Closing. Can be reopened if needed.


Fix format CLI option to accept fully qualified class names

FormatterSet#custom_formatter_class accepts fully qualified constant names and there's even a spec for this (private) method. But since #formatter_class uses /\A[A-Z]/ regexp to determine if provided formatter is custom, fully qualified values do not work with CLI.

Before submitting the PR make sure the following are checked:

[X] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[X] Wrote good commit messages.
[X] Commit message starts with [Fix #issue-number] (if the related issue exists).
[X] Feature branch is up-to-date with master (if not - rebase it).
[X] Squashed related commits together.
[X] Added tests.
[X] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Can you add a changelog entry?