Patch Cleanup After CharIN Demos

During CharIN, multiple on the spot patches had to be made to get the demos working, found in this PR. The goal is to now slowly fix everything so that these patches are no longer needed.
Discussions started about debugging our MaEVe implementation of setChargingProfile so that it can work without a patch, found here. This thread is now the continuation of all of the above.

MaEVe setChargingProfile Update
I finally managed to figure out what was wrong with my implementation of setChargingProfile in MaEVe. As I mentioned before, identifiers in structs need to be capitalized if we want the data within them to be exported, i.e. work in other packages. This caused an issue for us because libocpp wanted the lowercase versions of the EvsdeId and ChargingProfile.
I firstly spent a good amount of time trying to trace the code in libocpp and maeve-csms to try and see if I made a mistake along the way. I then tried adding in different hot fixes to convert the values in our SetChargingProfileRequestJson struct to lowercase before being sent out, but that didn't work. I then finally realized what was different between my struct and all the other ones already defined in MaEVe. The difference is that in their structs they had a tag that could allow you to specify what name you wanted the identifier to have in a json object. This meant that we could specify ChargingProfile/EvseId to show up as chargingProfile/evseId in json, all while retaining the capitalization. The final changed can be found here.
With this new change in place, I went ahead and tried to test out my new implementation with some of the patchwork taken away. As stated in this comment, I only removed the patch made to messages/SetChargingProfile.cpp, which had the formatting change. Once the docker containers were up and running I sent over the setChargingProfile API request and it worked. This is the response I received:

 SetChargingProfile Response
2024-06-17 15:05:48.011299 [ERRO] ocpp:OCPP201    void ocpp::v201::ChargePoint::handle_set_charging_profile_req(ocpp::Call<ocpp::v201::SetChargingProfileRequest>) :: Received SetChargingProfile: {
    "chargingProfile": {
        "chargingProfileKind": "Absolute",
        "chargingProfilePurpose": "TxDefaultProfile",
        "chargingSchedule": [
            {
                "chargingRateUnit": "A",
                "chargingSchedulePeriod": [
                    {
                        "limit": 20.0,
                        "numberPhases": 1,
                        "startPeriod": 0
                    }
                ],
                "duration": 86400,
                "id": 0,
                "minChargingRate": 0.0,
                "startSchedule": "2024-06-13T00:00:00.000Z"
            }
        ],
        "id": 1,
        "recurrencyKind": "Daily",
        "stackLevel": 1
    },
    "evseId": 0
}
with messageId: 2915644d-7ecb-403c-8d6d-f8ec777f12da
2024-06-17 15:05:48.039283 [WARN] ocpp:OCPP201    module::OCPP201::ready()::<lambda()> :: Received a new Charging Schedules from the CSMS or another actor.
2024-06-17 15:05:48.048997 [INFO] ocpp:OCPP201     :: ProfileId #1 Kind: Absolute
2024-06-17 15:05:48.055404 [INFO] ocpp:OCPP201     :: #1 find_period_at> 2024-06-13T00:00:00.000Z
2024-06-17 15:05:48.056224 [INFO] ocpp:OCPP201     ::    find_period_at>        start_time> 2024-06-17T15:05:48.039Z
2024-06-17 15:05:48.056508 [INFO] ocpp:OCPP201     ::    find_period_at> period_start_time> 2024-06-13T00:00:00.000Z
2024-06-17 15:05:48.056984 [INFO] ocpp:OCPP201     ::    find_period_at>   period_end_time> 2024-06-14T00:00:00.000Z
2024-06-17 15:05:48.059371 [INFO] ocpp:OCPP201     :: PeriodDateTimePair>  end_time: 2080-02-01T07:44:08.478Z
2024-06-17 15:05:48.059538 [INFO] ocpp:OCPP201     :: ProfileId #1 Kind: Absolute
2024-06-17 15:05:48.059651 [INFO] ocpp:OCPP201     :: #1 find_period_at> 2024-06-13T00:00:00.000Z
2024-06-17 15:05:48.059814 [INFO] ocpp:OCPP201     ::    find_period_at>        start_time> 2024-06-17T15:05:48.059Z
2024-06-17 15:05:48.059957 [INFO] ocpp:OCPP201     ::    find_period_at> period_start_time> 2024-06-13T00:00:00.000Z
2024-06-17 15:05:48.060028 [INFO] ocpp:OCPP201     ::    find_period_at>   period_end_time> 2024-06-14T00:00:00.000Z
2024-06-17 15:05:48.062774 [INFO] ocpp:OCPP201     :: PeriodDateTimePair>  end_time: 2080-02-01T07:44:08.478Z
2024-06-17 15:05:48.245824 [ERRO] ocpp:OCPP201    void ocpp::v201::ChargePoint::handle_set_charging_profile_req(ocpp::Call<ocpp::v201::SetChargingProfileRequest>) :: Received profile validity: Validsetting response to {
    "status": "Accepted"
}

Just posted the PR to MaEVe to integrate our setChargingProfile API. I'll start looking into the rest of the MaEVe patch files and try to figure out how to put it in some type of config.

For the rest of the MaEVe patch files, I just submitted another PR. I tried creating some type of config option with a script that you could run if using MaEVe with EVerest, and I left room for the community to provide their own feedback/thoughts for hopefully a better solution.

Added in new PR's for EVerest patches that do not require recompiling...

PR for support_payment_in_jsevmanager.patch
PR for enable_payment_method.patch

Added in more PRs to US-JOET for patches that do require recompiling...

PR for libocpp.patch
PR for ocpp201.module.patch

Converted both to draft; please clean up before taking it off draft

Thank you for the feedback @shankari, just addressed all the comments in both PRs and set them back to ready for review. Let me know what else, if anything, needs to be done to them.


forward declared values that are specified w/a parameter list should be non-transient

Currently, for
String(String) foo; // marked transient! (i.e. a *lazy* value that returns a Callable)
foo(String s) => s;

foo is marked transient, which would indicate a lazy value that returns a Callable. But, the value isn't lazy; it is specified w/o laziness in the second line.
Ideally, foo would not be marked transient, and backends should not create a new Callable each time the value is referenced.

For comparison, we also have:
String(String) foo; // marked non-transient. (i.e. a reference to a Callable)
foo = (String s) => s;

and a truly lazy value:
String(String) foo;
foo => (String s) => s;

I assume this is not blocking 1.2.3.

@jvasileff do you need this in 1.2.3?

@gavinking no. Dart works with or without this optimization.


⚠ Bofrost.at has degraded performance

In 79a2a94, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2139 ms

Resolved: Bofrost.at performance has improved in 0ebc4ca after 8 minutes.


[Vulkan] Secondary Command Buffer

使用场景与性能改善

We won't make use of the secondary command buffer functionality here, but you can imagine that it's helpful to reuse common operations from primary command buffers.
Ref: https://vulkan-tutorial.com/Drawing_a_triangle/Drawing/Command_buffers

What are primary and secondary command buffers?
The primary command buffer does not have any parent command buffer. However, the secondary command buffers are always executed from the primary command buffers behaving as its parent. The secondary command buffers ar not directly submitted into the device queue; these are recorded into the primary command buffer and executed using the
void vkCmdExecuteCommands(VkCommandBuffer commandBuffer,
                                                      uint32_t commandBufferCount,
                                                      const VkCommandBuffer* pCommandBuffers);

Tip
How are secondary command buffers are useful?
Secondary command buffers are useful in recording command operations into modular units. These modular capsules can be attached to any of you desired primary buffer as required. In the absence of the secondary command buffer, such common operations will be recorded as part of the primary buffer, making them bulky and resulting in redundancy pollution.
Ref: Learning Vulkan

common operations指哪些操作？
在哪种场景有多少比例的性能改善？

据红宝书最后一部分讲， secondary command buffer 主要是为了方便 CPU 并行生成指令，供 primary command buffer 提交用的，因此它的设计初衷应该是为了方便CPU端更快的生成指令，然后更快的提交，而不是给GPU优化更快执行的。所以如果不是复杂的游戏场景，而是普通的app是不需要这种设计的。

并行生成
重用（要注意引用资源的分配、更新）
性能方面可能会有影响，忘了哪里提过了

secondary command buffer 举个例子哈，静态场景，绘制物体，一段时间内都不会变，这个时候用 secondary command buffer 我觉得应该会很好，省了很多操作，这应该算是 common operations 吧。这个改善程度也要看场景，我们心中能明白它省在什么环节上了，这就行了。


Comment: Copilot Chat Prompt Contribution

I happened to stumble upon this repo as I'm currently in the process of doing something very similar.  I've been analyzing Github's own Copilot plugin, and I extracted the prompts that it uses to create its Copilot chat functionality.  Here's a list of all the prompts I extracted: https://github.com/B00TK1D/copilot-prompts.  Feel free to use these as you'd like to improve the functionality of your own plugin.

Hey @B00TK1D !
Thanks a lot for that, I'll consider adding it to the plugin

I happened to stumble upon this repo as I'm currently in the process of doing something very similar. I've been analyzing Github's own Copilot plugin, and I extracted the prompts that it uses to create its Copilot chat functionality. Here's a list of all the prompts I extracted: https://github.com/B00TK1D/copilot-prompts. Feel free to use these as you'd like to improve the functionality of your own plugin.

@B00TK1D very cool research! are you also building a copilot chat plugin for neovim?

Very cool, thank you for that! But I'm trying to avoid python dependencies.
For the API endpoint shift, I had the same issue, the fix is simple, you just need to replace the URI from https://copilot-proxy.githubusercontent.com/v1/chat/completions to https://api.githubcopilot.com/chat/completions

that shift in api URI leads me to believe maybe they are finally getting ready to actually make the api more generally available and supported! We can hope at least ;) haha


RevEng: Use optionsBuilder i.s.o. options in OnConfiguring - issue #4173

Fixes issue #4173

Looks good to me. Will merge.

Merged


New App: Microsoft Intune

Name of the app
microsoftintune
Integration
Microsoft Intune
About
Connects to Microsoft Intune using MS Graph REST API services to support managed device actions.
Supported Actions

list managed devices - List properties and relationships of the managedDevice objects.
test connectivity - Validate the asset configuration for connectivity using the supplied configuration

https://github.com/splunk-soar-connectors/microsoftintune


fastapi extensions support multipart data

Azure Functions runtime version 4.34.1, or a later version.
Python version 3.9, or a later
Python v2 programming model
introduction post for the preview
Does the fastapi extensions request support multipart data? i would like to provide some files with the request and stream the response. But when loading the form-data its always empty. Is it not yet supported or is there another way to get the form-data?
@app.route(route="stream_files_resp", methods=[func.HttpMethod.POST])
async def func_stream_files_resp(
    request: Request
) -> StreamingResponse:
    form_data = await request.form()
    return StreamingResponse(some_generator(form_data), media_type="text/event-stream")

thanks for raising! i am able to upload multipart data and retrieve it in the function. have you installed python-multipart package in requirements.txt?

I already have a few functions that also contain some code. That is why I have only registered the functions in the function_app.py and left them in their own files. apparently it is not possible to pass the whole request to the functions, information is lost.
function_app.py
@app.route(route="stream_files_resp", methods=[func.HttpMethod.POST])
async def func_stream_files_resp(
    request: Request
) -> StreamingResponse:
    return StreamingResponse(some_generator_function(request), media_type="text/event-stream")

some_generator.py
def some_generator_function(req: Request):
    form_data = await req.form()
    request_json = form_data.get("json")
    request_file = form_data.get("file")
    cookies = get_cookies(req.headers.get("cookie"))

in the case above the formdata was always empty.
changed now to the following and it works like a charm.
function_app.py
@app.route(route="stream_files_resp", methods=[func.HttpMethod.POST])
async def func_stream_files_resp(
    request: Request
) -> StreamingResponse:
    form_data = await req.form()
    request_json = form_data.get("json")
    request_file = form_data.get("file")
    return StreamingResponse(some_generator_function(request_json, request_file), media_type="text/event-stream")

some_generator.py
def some_generator_function(request_json, request_file):
   *some code*

Sorry for the confusion and thank you very much

Everything is resolved.


VSCode multimon breaches boundaries when maximized

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:07:25.676Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

cpptools
ms-
0.12.3

Steps to Reproduce:

Set up multimon (attached screenshot of my display config)
a. My display config is a 1080 monitor plus a Surface Laptop
Start VSCode
Maximize VSCode on the 1080p monitor
Notice it bleeds into the other monitor
a. Note that in the zoom in of the screenshot that it bleeds both out to the other monitor and down into the taskbar.

Screenshots attached.

Reproduces without extensions: Yes/No

This is likely an Electron issue.

Could be https://github.com/electron/electron/issues/9688

@azydevelopment do you still see this?


test-branch/execute-job/quoted-authorization/c3f41fbd-e6ee-4962-8647-48c53f9addbd

PR for testing 014d4be424cb545412e327d29abf99fd47d76166

/canonical/self-hosted-runners/run-workflows 014d4be424cb545412e327d29abf99fd47d76166


libtcmu: fix unregister genl ops in setup_netlink

After genl_register_family succeeds，the following operations failed should call genl_unregister_family。
Signed-off-by: tangwenji<EMAIL_ADDRESS>

Thanks. Hopefully, you are finding all these issues by just review and not actually hitting all these bugs :)


fix(INJI-282): Scan page's error message was fixed when the camera is disabled.

INJI-282 --> Scan page's error message is not proper when the camera is disable

This PR was cloned with the new one( PR-775 ) which was raised with mosip/develop. Hence this was closing.


support GoCache waf detection

Which category is this pull request?

[x] A new feature/enhancement.
[ ] Fix an issue/feature-request.
[ ] An improvement to existing modules.
[ ] Other (Please mention below).

Where has this been tested?

Python Version

[x] v3.x
[ ] v2.x

Operating System:

[x] Linux (Please specify distro)
[ ] Windows
[ ] MacOS

Does this close any currently open issues?
[Mention any issue which this PR closes]
No
Does this add any new dependency?
[Mention if this PR includes any new library]
No
Does this add any new command line switch/argument?
[Mention if the changes add any new arguments like --arg]
No
Any other comments you would like to make?
[Anything more you'd want the reviewer to know]
Support detection to GoCache waf

Hi @danieltidus, can you provide the source of the waf error page here? I feel just a single matcher might be a bit false positive prone.


create an A/B test the signup page by removing the section that says "No credit card required" and replacing it to say "use your business email to access 30 days of premium support". Campaign brief can be found here  https://docs.google.com/document/d/13CNyQzRL05Cxp9RAe8ED855Zx2_lX5K41b9ZsCjPYXU/edit#

https://docs.google.com/document/d/13CNyQzRL05Cxp9RAe8ED855Zx2_lX5K41b9ZsCjPYXU/edit#
hi @mavarius - you can see the mock-up of how this should look like on page 5.


How can I send email when user creates account with Google

I'm trying to figure out how to send a welcome email to users who create an account with Google. I've looked through the code base and checked the google.ts file located at app/src/server/auth/google.ts. However, I couldn't find any account creation process in it. Could you please advise me on how to email users when they create an account with Google?

probably the easiest way is:

add a welcomeEmailSent property to your User entity and default it to false:

entity User {=psl
  id                        Int             @id @default(autoincrement())
  //...
  welcomeEmailSent Boolean @default(false)

create a server action to send an email to the user https://wasp-lang.dev/docs/advanced/email
check on the client in app/src/client/App.tsx, the App wrapper, if the user is present/logged in. If they are, check if a welcome email has been sent yet and if not, send it using the action you just created:

  useEffect(() => {
    if (!!user && !user.welcomeEmailSent) {
      sendWelcomeEmail({ userId: user.id });
    }
  }, [user]);

let me know if you need any other help

hey @nosisky, probably the easiest way is:

add a welcomeEmailSent property to your User entity and default it to false:

entity User {=psl
  id                        Int             @id @default(autoincrement())
  //...
  welcomeEmailSent Boolean @default(false)

create a server action to send an email to the user https://wasp-lang.dev/docs/advanced/email
check on the client in app/src/client/App.tsx, the App wrapper, if the user is present/logged in. If they are, check if a welcome email has been sent yet and if not, send it using the action you just created:

  useEffect(() => {
    if (!!user && !user.welcomeEmailSent) {
      sendWelcomeEmail({ userId: user.id });
    }
  }, [user]);

let me know if you need any other help

That was very helpful! thank you @vincanger 🙏


Disclaimer

Do we add a disclaimer to the bottem of the index page saying that not all of the modules on here may not exist when they get to that year? ie Vince's 3rd yr module MA3600 is there but it will not be avalible next year as far as I am aware as it is splitting into two 10 credit modules: Queueing & Inventory theory and Game Theory.

@alcarney @drvinceknight what do you think about this?

Might be a good idea, at least until the data is verified :)

@alcarney Ok cool will look at this later

No matter what: until this is completely run by the university (which it may or may not be, some sort of wiki model could be cool...) it needs a disclaimer. This is important. You don't want responsibility, it has to make it clear that this is a service offered with an aim to be helpful but that all choices and prerequisites should be checked against the official university website (and to invite people to let you know if there's an error).
:+1:


OTBS style Stroustrup

I am a follower of Stroustrup brace style, rather than OTBS, might it be possible to add this to the arsenal of dfmt?

It's possible, but I don't want to do it.


Update CMake to require version 3.21

The current CMake files are set for 3.20 since this is the version that comes with VS 2019 (16.11). Moving to 3.21 as a minimum would clean up the projects and make them more 'modern'.
VS 2022 ships with 3.21 or later.
GitHub Actions windows-2019 runner images and MS-Hosted windows-2019 VM images have newer versions of CMake.

This would require installing a newer CMake for the Developer Command Prompt for VS 2019 if using CMake.

This would include:

Use schema version 3 of CMakePresets.json which adds installDir and toolchainFile variables instead of having to set it through cache variables.

Tests and subtests can use PROJECT_IS_TOP_LEVEL instead of the current workaround.

For CMake tests, this also allows the use of TARGET_RUNTIME_DLLS without a guard or fallback.


Discover and extract pyramid tiff levels and tiles?

So far I've figured out that I can do:
2.2.1 :002 > im = VIPS::TIFFReader.new('./color_pyramid.tif')
 => #<VIPS::TIFFReader:0x00000001d6f3c0 @page_number=nil, @sequential=false, @path="./color_pyramid.tif", @_im=nil>
2.2.1 :003 > im.x_size
 => 1200
2.2.1 :004 > im.page_number=1
 => 1
2.2.1 :005 > im.x_size
 => 600
2.2.1 :006 > im.page_number=2
 => 2
2.2.1 :007 > im.x_size
 => 300
2.2.1 :008 > im.page_number=3
 => 3
2.2.1 :009 > im.x_size
VIPS::Error: VIPS error: tiff2vips: TIFF does not contain page 3

Which at least seems like a ham-handed way to figure our how many resolutions are available (though, of course, pages may not be different resolutions). It seems like I should be able to find out that this is indeed a pyramid tiff and how many resolutions/scale factors are available without having to loop through 1..n until I get an exception. Additionally I'd like to:

Find out the size of the tiles within the image (I happen to know this image was encoded w/ 512x512 tiles)
Extract one of the lower resolutions
Extract a tile from one of the resolutions

and transcode either of the latter two to anther format and write it out.
Is this possible? Any clues would help. TIA!

Hi, vips does not attach all image metadata, so you can't read arbitrary tiff tags. You probably need a lower-level library for that, perhaps a direct wrapping of libtiff.
Are you sure you need the tile size? vips will let you read any area from a tiff and uses enough caching that it's very quick. For example:
$ irb
irb(main):001:0> require 'vips'
=> true
irb(main):002:0> im = VIPS::Image.new "wtc-pyr.tif"
=> #<VIPS::Image:0x000000020cfee8>
irb(main):004:0> patch = im.extract_area 10, 10, 100, 100
=> #<VIPS::Image:0x000000021a0610>
irb(main):005:0> patch.write "x.jpg"
=> #<VIPS::Writer:0x0000000208dac0>
irb(main):006:0> im = VIPS::Image.new "wtc-pyr.tif", page_number = 4
=> #<VIPS::Image:0x00000002085690>
irb(main):007:0> patch = im.extract_area 10, 10, 100, 100
=> #<VIPS::Image:0x00000002104fd0>
irb(main):008:0> patch.write "x.png"
=> #<VIPS::Writer:0x00000002007830>

The arguments to extract_area are left, top, width, height.
tiff does not actually record the number of pages in a file, you have to keep asking for pages until you hit an error. vips could have a n_pages field, but all it would do internally would be to loop over all page numbers.

Ooops, sorry, I've spent too long in Python, ruby-vips does it like this:
$ irb
irb(main):001:0> require 'vips'
=> true
irb(main):002:0> reader = VIPS::TIFFReader.new "wtc-pyr.tif", :page_number => 4
=> #<VIPS::TIFFReader:0x00000001c471a0 @page_number=4, @sequential=false, @path="wtc-pyr.tif", @_im=nil>
irb(main):003:0> reader.x_size
=> 585
irb(main):004:0> im = reader.read
=> #<VIPS::Image:0x00000001d22ed0>
irb(main):005:0> patch = im.extract_area 10, 10, 100, 100
=> #<VIPS::Image:0x00000001c09760>
irb(main):006:0> patch.write "x.png"
=> #<VIPS::Writer:0x00000001c05b38>

ie. you use read to trigger the actual image read and get something you can work with.

ruby-vips8 has a much simpler way of handling this, but it's still not working properly, unfortunately.

OK, thanks for the help and info!
Just so you know this isn't an arbitrary exercise, my reason for asking is that I'm implementing the IIIF Image API, which includes a service for providing just enough info for a client to know what it can access (either efficiently, or in some cases, at all) to drive a rich web-client. I've done a few implementations in the past, but never in Ruby, and I've never supported pyramid TIFF as a source format (I also prefer to avoid ImageMagick at all costs :wink: ). Looking at the TIFF 6.0 spec w/ fresh eyes this morning, it doesn't look like it would be terribly difficult to extract what I need from the file (given some quiet time).
Closing--thanks again!

Oh OK, sounds fun. I guess you know about iipimage? They support IIIF, I think:

Yeah, Ruven was one of the first few adopters and has come to a few of our meetings. I'm also the dev/maintainer of Loris, which was more or less the first.

I did a tiny tile server in C, it might be relevant:
https://github.com/jcupitt/tilesrv
That's for serving tiles from openslide images to a deepzoom viewer.


New optional params on invoice creation: fees & items

New optional params were introduced on invoice

items (an array of
fees (an array of objects)

Closing as this is available now https://github.com/xendit/xendit-python/blob/master/xendit/models/invoice/invoice.py#L88-L89


Major breaking change released as a patch version (1.0.1)

Hi there @Daegalus .
The 1.0.1 release of this library (consisting of https://github.com/Daegalus/dart-uuid/commit/e156dfe4ba9bc3bb6738a993e6070958c006fe9f) is a breaking change since the new lowercase pi constant is only available in the dart 2 sdk unless a polyfill such as this is used:
import 'package:dart2_constant/convert.dart' as convert;

class Uuid {
  // This isn't used, I just am propogating to use of TAU over PI - http://tauday.com/tau-manifesto
  static final TAU = 2 * convert.pi;
}

The only other way your change could be considered "non-breaking" for consumers is if you bumped the lower bound of your sdk dependency to something resembling ^2.0.0.dev.

Thanks for this I will try to fix it up in the next few hours. My apologies for the mix-up.
I am working on a 2.0 release of this library that changes some things up and uses pointycastle for crypto stuff. So I might be able to clean this up. Also I might just get rid of the TAU thing.

Might I ask for a follow up patch release 1.0.2 with the dart2_constant fix? This way, consumers that have specified a range (^1.0.0 for example) would get the new dart 1 compatible 1.0.2 fix and skip the breaking one.

Thanks for this I will try to fix it up in the next few hours. My apologies for the mix-up.
I am working on a 2.0 release of this library that changes some things up and uses pointycastle for crypto stuff. So I might be able to clean this up. Also I might just get rid of the TAU thing.

Agreed - the breaking change would need to be addressed in a 1.x release in order to resolve existing breakages for people using semver notation like ^1.0.0.

I meant I will be making a 1.0.2 fix for the current version and then make sure it's fixed in my 2.0 work. Sorry if I wasn't clear.

Should be fixed with the release of 1.0.2. I just straight up removed that constant as its not used anywhere and tests pass.

Thanks @Daegalus !!!


Create script to pull vulnerability data from chromium

Using the list of vulnerabilities in chromium we have.
We should consume that list, search for code reviews, bugs, fixes, and vccs, etc. and add them to chromium-vulnerabilities

About to be finished with Nuthan's pull request on that repo - will close this soon.

Done!


Wish: Clear Build Tutorial

Hi, I'd like to build this, but the instructions are not clear (for me).

About the USB Stick & hass.json, how, and when does this get used?
The line: make -C /build/buildroot BR2_EXTERNAL=/build/buildroot-external xy_defconfig isn't doing anything for me.
How to actually get an Image for a RPI?

thank you!

That is a simple buildroot envoriement: https://buildroot.org/downloads/manual/manual.html


Updated backend-tasks readme

Signed-off-by: Andre Wanlin<EMAIL_ADDRESS>Hey, I just made a Pull Request!
Updated the backend-tasks README based on usage:

It did not like dashes in the id, changed that to an underscore
The timeout is required, added that to the example
Added a note about tasks not running as expected for local development using persistent database

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

@freben some changes based on my usage. Not sure if the timeout example is clear, happy to change

Ready for another review or for these changes to be approved and merged 👍

Thanks and happy new year!


How to remove Prefix from everybody?

Hello,
for(PermissionUser pu : PermissionsEx.getPermissionManager().getUsers()){
                    pu.setPrefix(null, null);
}

Doesn't work, why?
[PermissionsEx] version [1.23.4]
Spigot 1.8.9 with protocolhack.

The prefix was set from a group maybe? You have to change groups too.

It works now, but server crashes if I run it twice. What's the problem? Btw how to remove all users from different groups? But leave their suffix and own permissions.

[16:18:04 INFO]: WEPIF: PermissionsEx detected! Using PermissionsEx for permissions.
[16:18:34 WARN]: [PermissionsEx] All backend tasks not completed after 30 seconds, waiting 2 minutes.


Fix for https://github.com/aws-amplify/amplify-cli/issues/2390

Issue #, if available:
https://github.com/aws-amplify/amplify-cli/issues/2390
Description of changes:
Handle case where lastDeployedStack.Outputs is undefined. Resolves TypeError: Cannot convert undefined or null to object error that sometimes occurs when running amplify api gql-compile.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2969 into master will decrease coverage by 0.61%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   62.13%   61.52%   -0.62%
==========================================
  Files         223      222       -1
  Lines       11283    11396     +113
  Branches     2204     2193      -11
==========================================
  Hits         7011     7011
- Misses       3964     4077     +113
  Partials      308      308

Impacted Files
Coverage Δ

.../graphql-transformer-core/src/util/amplifyUtils.ts
5.83% <0%> (ø)
:arrow_up:

...sync-simulator/src/schema/appsync-scalars/index.ts

...fy-appsync-simulator/src/schema/directives/auth.ts

...y-appsync-simulator/src/velocity/util/map-utils.ts

...es/amplify-appsync-simulator/src/velocity/index.ts

...-appsync-simulator/src/velocity/util/list-utils.ts

...-simulator/src/schema/directives/directive-base.ts

...psync-simulator/src/velocity/util/general-utils.ts

...fy-appsync-simulator/src/data-loader/none/index.ts

...amplify-appsync-simulator/src/mqtt-server/index.ts
0% <0%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fb03a...4dc4d06. Read the comment docs.


Lab Demo Recording video

Hi Team,
The Lab Demo Recording video for AZ-500 still does not updated since 2 months ago.
AZ-500 Lab Demo Recording
any ideas when will release the Lab Demo Recording videos?
Thank you.

There are no plans to record Lab videos for this course.


Fixed crash on pause menu

I noticed that when changing the difficulty in a pause, if the chart was not found, then the game just crashed.
I fixed this problem and now the game writes that the chart was not found without crashes.
Before:
https://github.com/ShadowMario/FNF-PsychEngine/assets/97068888/f94c4a05-9e32-4464-ad55-0de5f76bf2f9
After:
https://github.com/ShadowMario/FNF-PsychEngine/assets/97068888/ee5738f6-70e2-4640-bb33-31f6bfe4fca6

Hey wait does this also work in the chart editor when opening a json with an invalid difficulty

Эй, подождите, это также работает в редакторе диаграмм при открытии json с недопустимой сложностью?

it looks like it was in the latest version

this problem is caused by really simple human error, and the crash handler also tells you which file is missing, this isn't needed

I'm only human after all

Don’t put the blame on me


test out other video decoding backends

pyAV - untested
VPF - untested
decord:
initial testing showed no clear performance advantage over video2numpy

I think this can be done in the browser using HTMLMediaElement.seekToNextFrame() https://bugs.chromium.org/p/chromium/issues/detail?id=1065675, and in real-time using MediaStreamTrackProcessor.


Non-intrusive method of using system LCMS2.

I reworked my original patch to make it less intrusive.
Basically, it uses cmake's pkg-config module to see if lcms2 >= 2.1 is available on the system and uses it if it is. Otherwise it fails back to using the bundled lcms2.
Currently I'm using message(STATUS... if the bundled library is used. At some point in the future it should probably be changed for a WARNING so distro packagers know they need to install lcms2-devel.

Committed in 3580e7df1ee3c325876e9b1131805b9a9b9c72a6


Like button is added

Fixes Issue
Closes #1182

Changes proposed

Screenshots

Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers

@Spyware007 please have a look

Please check #1346


Argument to simply generate certificates without modifying system

The --help mode did not appear to offer a mode which did not modify the system so I was not expecting it to by default:
letsencrypt.exe --san --accepttos --emailaddress<EMAIL_ADDRESS>--notaskscheduler

[INFO] Let's Encrypt (Simple Windows ACME Client)
[INFO] Version <IP_ADDRESS>878 (RELEASE)
[INFO] Please report issues at https://github.com/Lone-Coder/letsencrypt-win-simple

[INFO] Renewal period: 60
[INFO] Certificate store: WebHosting
[INFO] ACME Server: https://acme-v01.api.letsencrypt.org/
[INFO] No valid hosts found for Default Web Site.
[INFO] No valid hosts found for Exchange Back End.
[WARN] No applicable IIS sites were found.
[WARN] No targets found.
 W: Generate a certificate via WebDav and install it manually.
 S: Generate a single San certificate for multiple sites.
 F: Generate a certificate via FTP/ FTPS and install it manually.
 M: Generate a certificate manually.
 Q: Quit

 Choose from one of the menu options above: m

 Enter a host name: host.domain.com

Enter all Alternative Names seperated by a comma foo.domain.com,bar.domain.com

 Enter a site path (the web root of the host for http authentication): C:\inetpub\wwwroot

After performing the authorizations for all host names, the following output is returned:
[INFO] Requesting certificate: host.domain.com
[INFO] Saving certificate to C:\Users\user\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\host.domain.com-crt.der
[INFO] Saving issuer certificate to C:\Users\user\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\ca-0A0141420000015385736A0B85ECA708-crt.pem
[INFO] Saving certificate to C:\Users\user\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\host.domain.com-all.pfx
[INFO] Installing Non-Central SSL Certificate in the certificate store
[INFO] Installing Non-Central SSL Certificate in server software
[WARN] Unable to configure server software.
[INFO] Removing certificate host.domain.com 2017/6/6 1:23:35 PM
[INFO] Removing certificate host.domain.com 2017/5/7 5:57:10 PM
[INFO] Removing certificate host.domain.com 2017/4/19 8:21:13 PM
[INFO] Closing certificate store
[INFO] Adding renewal for [Manual] [11 bindings - host.domain.com, ... @ C:\inetpub\wwwroot]
[INFO] Renewal scheduled host.domain.com - renew after 10/25/2017

Old certs were removed and the new one was installed and available to IIS.
How do I prevent this behavior?

For now the only workaround I can think of (but not tested) is using the --centralssl parameter. That copies certificates to a file system location instead of installing them on the local machine.


Change domain to Symbol

See https://github.com/stellar/rs-soroban-sdk/issues/399#issuecomment-1208583096 and https://github.com/stellar/rs-soroban-sdk/issues/399#issuecomment-1208635802

We need to expose the current contract function name in the host crate for this right? Something similar to get_current_contract?

Contracts should know what their function is that's being executed, so I'm not sure it is strictly needed. Is there a case where it isn't naturally known?
If it's needed, maybe something like get_current_contract_function_name.

Agreed, the contract knows what function is being executed so there is no need to get this information from the host.

Are you saying I should update the macros so the current method is stored? Or is something similar already implemented?

@sisuresh I don't think I understand what you're proposing? To clarify what I meant above, consider the xfer function. When it checks signatures now, it knows to use Domain::Transfer. In this proposal, it would use Symbol::from_symbol("xfer"). Every function is already choosing the domain, so there's no reason they can't construct the appropriate symbol instead.

Ah yeah we weren't on the same page. I was discussing deriving the function name, but you're right we don't need to do that.

The Authorization example uses a Symbol.

Resolved in https://github.com/stellar/soroban-token-contract/pull/86.


Cannot update tree

I can assign data to the tree and the data is displayed properly. But if I then change the data, the updated data is not displayed.
I have tried this with (a) setting the data in the HTML and (b) setting the data using core.data. I have the same problem both times.
I am basically doing $('#mytree').jstree({core: {data: [{text: "aaa"}]}});  (which works) and then $('#mytree').jstree({core: {data: [{text: "aaa"},{text: "bbb"}]}});  which does not work (it still only displays one node with 'aaa'; it should display two nodes).
Do I need to do something different (maybe, somehow call refresh?) Or is this a bug?

You need to call refresh if you are changing the core.data property, although I would recommend setting core.data to a function and calling refresh - it is cleaner that way:
var data = [{text: "aaa"}];
$('#mytree').jstree({core: {data: function (node, cb) { cb(data); } }});
// and then later on
data = [{text: "aaa"},{text: "bbb"}];
$('#mytree').jstree(true).refresh();

Yes, that works thanks.
On 21 Sep 2016 3:13 PM, "Ivan Bozhanov"<EMAIL_ADDRESS>wrote:

You need to call refresh if you are changing the core.data property,
although I would recommend setting core.data to a function and calling
refresh - it is cleaner that way:
var data = [{text: "aaa"}];
$('#mytree').jstree({core: {data: function (node, cb) { cb(data); } }});
// and then later on
data = [{text: "aaa"},{text: "bbb"}];
$('#mytree').jstree(true).refresh();
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vakata/jstree/issues/1575#issuecomment-248530179, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIgNgg9m-3Iiv6LdLeupppDqlDjqYMj4ks5qsNkCgaJpZM4KCXY4
.


Process finished with exit code -2147483645

Hello,
Most of the examples on windows 10 fail at runtime with this error. Hello world runs fine.
I tried several different compilers including vc15, mingw and cygwin.

https://bkaradzic.github.io/bgfx/examples.html#examples
Examples must be executed from:
<bgfx_path>/examples/runtime
<bgfx_path>/examples/runtime $ ../../.build/<config>/bin/example-00-helloworldDebug


Support for Stripe Subscriptions

Originally reported by: Jeffrey Olmstead (Bitbucket: ems, GitHub: ems)

I am in need of support for Stripe Subscriptions. This likely means I will be building it but before spending time on it was wondering if anyone had already started down this road. Info on Subscriptions can be found here: https://stripe.com/docs/api#subscriptions
Does Nwazet.Commerce currently support this? Any desire to or should I build this into my Rework.CommerceExtensions module?

Bitbucket: https://bitbucket.org/bleroy/nwazet.commerce/issue/45

@ems any progress on that feature ? I've made a quick search this afternoon and found https://github.com/jaymedavis/stripe.net . This is a feature I'm looking also forward to have. If I can help let me know. I will read about it and get informations first.

Nobody's working on it, that I know of. Up for grabs.


Ubuntu 18.04 install failed: tensorflow-1.8.0 is not a supported wheel on this platform.

Specs:
Radeon Rx 580 GPU 8gb
Intel i5 cpu
Ubuntu 18.04
After following the steps on the gpu open website, I got an error on the last command:
pip3 install ./tensorflow-1.8.0-cp35-cp35m-manylinux1_x86_64.whl
tensorflow-1.8.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform.
I followed the steps from this link: https://gpuopen.com/rocm-tensorflow-1-8-release/
I tried:
Downgrading to python 3.5 in a virtual env
Upgrading to python 3.7
Made sure I have the latest driver for the rx 580 (18.30)
I have the latest Open CL as well
Any suggestions on a workaround?

Hi @winsteadworks
Are you willing to try Tensorflow 1.10 instead? The directions at this site are more up-to-date than our older GPUOpen blog post.
Note that AMD does not support Tensorflow on our amdgpu-pro drivers. As such your mention of "18.30" implies to me that you may also be running the wrong drivers. You should uninstall the amdgpu-pro drivers and install ROCm 1.9.1 instead.

@jlgreathouse I installed ROCm 1.9.1, however when I run the /opt/rocm/bin/rocminfo
and /opt/rocm/opencl/bin/x86_64/clinfo in terminal after installing. It is only showing that I have 1 gpu.
I have 6 8gb Rx 580's total and I am running Ubuntu 18.04/
Here is the output for /opt/rocm/bin/rocminfo
HSA System Attributes
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (number of timestamp)
Machine Model:           LARGE
System Endianness:       LITTLE
==========
HSA Agents

Agent 1

Name:                    Intel(R) Core(TM) i5-4460  CPU @ 3.20GHz
Vendor Name:             CPU
Feature:                 None specified
Profile:                 FULL_PROFILE
Float Round Mode:        NEAR
Max Queue Number:        0
Queue Min Size:          0
Queue Max Size:          0
Queue Type:              MULTI
Node:                    0
Device Type:             CPU
Cache Info:
L1:                      32768KB
Chip ID:                 0
Cacheline Size:          64
Max Clock Frequency (MHz):3400
BDFID:                   0
Compute Unit:            4
Features:                None
Pool Info:
Pool 1
Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
Size:                    16288456KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Acessible by all:        TRUE
Pool 2
Segment:                 GLOBAL; FLAGS: COARSE GRAINED
Size:                    16288456KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Acessible by all:        TRUE
ISA Info:
N/A

Agent 2

Name:                    gfx803
Vendor Name:             AMD
Feature:                 KERNEL_DISPATCH
Profile:                 BASE_PROFILE
Float Round Mode:        NEAR
Max Queue Number:        128
Queue Min Size:          4096
Queue Max Size:          131072
Queue Type:              MULTI
Node:                    1
Device Type:             GPU
Cache Info:
L1:                      16KB
Chip ID:                 26591
Cacheline Size:          64
Max Clock Frequency (MHz):1340
BDFID:                   256
Compute Unit:            36
Features:                KERNEL_DISPATCH
Fast F16 Operation:      FALSE
Wavefront Size:          64
Workgroup Max Size:      1024
Workgroup Max Size Per Dimension:
Dim[0]:                  67109888
Dim[1]:                  16778240
Dim[2]:                  0
Grid Max Size:<PHONE_NUMBER>
Waves Per CU:            40
Max Work-item Per CU:    2560
Grid Max Size per Dimension:
Dim[0]:<PHONE_NUMBER>
Dim[1]:<PHONE_NUMBER>
Dim[2]:<PHONE_NUMBER>
Max number Of fbarriers Per Workgroup:32
Pool Info:
Pool 1
Segment:                 GLOBAL; FLAGS: COARSE GRAINED
Size:                    8388608KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Acessible by all:        FALSE
Pool 2
Segment:                 GROUP
Size:                    64KB
Allocatable:             FALSE
Alloc Granule:           0KB
Alloc Alignment:         0KB
Acessible by all:        FALSE
ISA Info:
ISA 1
Name:                    amdgcn-amd-amdhsa--gfx803
Machine Models:          HSA_MACHINE_MODEL_LARGE
Profiles:                HSA_PROFILE_BASE
Default Rounding Mode:   NEAR
Default Rounding Mode:   NEAR
Fast f16:                TRUE
Workgroup Max Dimension:
Dim[0]:                  67109888
Dim[1]:                  1024
Dim[2]:                  16777217
Workgroup Max Size:      1024
Grid Max Dimension:
x<PHONE_NUMBER>
y<PHONE_NUMBER>
z<PHONE_NUMBER>
Grid Max Size:<PHONE_NUMBER>
FBarrier Max Size:       32
Here is /opt/rocm/opencl/bin/x86_64/clinfo output
Number of platforms:				 1
Platform Profile:				 FULL_PROFILE
Platform Version:				 OpenCL 2.1 AMD-APP (2679.0)
Platform Name:				 AMD Accelerated Parallel Processing
Platform Vendor:				 Advanced Micro Devices, Inc.
Platform Extensions:				 cl_khr_icd cl_amd_event_callback
Platform Name:				 AMD Accelerated Parallel Processing
Number of devices:				 1
Device Type:					 CL_DEVICE_TYPE_GPU
Vendor ID:					 1002h
Board name:					 Ellesmere [Radeon RX 470/480]
Device Topology:				 PCI[ B#1, D#0, F#0 ]
Max compute units:				 36
Max work items dimensions:			 3
Max work items[0]:				 1024
Max work items[1]:				 1024
Max work items[2]:				 1024
Max work group size:				 256
Preferred vector width char:			 4
Preferred vector width short:			 2
Preferred vector width int:			 1
Preferred vector width long:			 1
Preferred vector width float:			 1
Preferred vector width double:		 1
Native vector width char:			 4
Native vector width short:			 2
Native vector width int:			 1
Native vector width long:			 1
Native vector width float:			 1
Native vector width double:			 1
Max clock frequency:				 1340Mhz
Address bits:					 64
Max memory allocation:<PHONE_NUMBER>
Image support:				 Yes
Max number of images read arguments:		 128
Max number of images write arguments:		 8
Max image 2D width:				 16384
Max image 2D height:				 16384
Max image 3D width:				 2048
Max image 3D height:				 2048
Max image 3D depth:				 2048
Max samplers within kernel:			 26591
Max size of kernel argument:			 1024
Alignment (bits) of base address:		 1024
Minimum alignment (bytes) for any datatype:	 128
Single precision floating point capability
Denorms:					 No
Quiet NaNs:					 Yes
Round to nearest even:			 Yes
Round to zero:				 Yes
Round to +ve and infinity:			 Yes
IEEE754-2008 fused multiply-add:		 Yes
Cache type:					 Read/Write
Cache line size:				 64
Cache size:					 16384
Global memory size:<PHONE_NUMBER>
Constant buffer size:<PHONE_NUMBER>
Max number of constant args:			 8
Local memory type:				 Scratchpad
Local memory size:				 65536
Max pipe arguments:				 16
Max pipe active reservations:			 16
Max pipe packet size:<PHONE_NUMBER>
Max global variable size:<PHONE_NUMBER>
Max global variable preferred total size:<PHONE_NUMBER>
Max read/write image args:			 64
Max on device events:				 1024
Queue on device max size:			 8388608
Max on device queues:				 1
Queue on device preferred size:		 262144
SVM capabilities:
Coarse grain buffer:			 Yes
Fine grain buffer:				 Yes
Fine grain system:				 No
Atomics:					 No
Preferred platform atomic alignment:		 0
Preferred global atomic alignment:		 0
Preferred local atomic alignment:		 0
Kernel Preferred work group size multiple:	 64
Error correction support:			 0
Unified memory for Host and Device:		 0
Profiling timer resolution:			 1
Device endianess:				 Little
Available:					 Yes
Compiler available:				 Yes
Execution capabilities:
Execute OpenCL kernels:			 Yes
Execute native function:			 No
Queue on Host properties:
Out-of-Order:				 No
Profiling :					 Yes
Queue on Device properties:
Out-of-Order:				 Yes
Profiling :					 Yes
Platform ID:					 0x7fa191eeadf0
Name:						 gfx803
Vendor:					 Advanced Micro Devices, Inc.
Device OpenCL C version:			 OpenCL C 2.0
Driver version:				 2679.0 (HSA1.1,LC)
Profile:					 FULL_PROFILE
Version:					 OpenCL 1.2
Extensions:					 cl_khr_fp64 cl_khr_global_int32_base_atomics cl_khr_global_int32_extended_atomics cl_khr_local_int32_base_atomics cl_khr_local_int32_extended_atomics cl_khr_int64_base_atomics cl_khr_int64_extended_atomics cl_khr_3d_image_writes cl_khr_byte_addressable_store cl_khr_fp16 cl_khr_gl_sharing cl_amd_device_attribute_query cl_amd_media_ops cl_amd_media_ops2 cl_khr_subgroups cl_khr_depth_images cl_amd_copy_buffer_p2p cl_amd_assembly_program

Your CPU can only have up to 16 PCIe 3 lanes directly connected to the CPU.
In either case, I would guess the problem here is that your connection between the missing GPUs and your CPU does not support PCIe gen 3 atomics, which is a requirement for your GPUs. For example, if your PCIe switch does not support the capability of forwarding PCIe atomics, you will not be able to use the gfx8 GPUs behind it with ROCm.
It is not possible at this time to enable gfx8 devices without the use of PCIe atomics. See this discussion for many more details about this.

@jlgreathouse I have1 graphics card connected to a full pcie slot and then the rest are connected via riser cables to pcie x1 slots on an ASRock H81 Pro BTC motherboard.
According to this link here: https://rocm.github.io/hardware.html it actually looks like my cpu (Intel i5-4460) is supported.

Your GPU is supported in ROCm, and your CPU supports PCIe 3.0 atomics. However, as noted in our hardware requirements list, your GPU requires the ability to communicate PCIe atomics all the way to your CPU root complex. In particular:

"The system configuration can have the PCIe slots directly on CPU’s root port or a PCIe switch, but everything between the CPU and the GPU must support atomics. The CPU root must indicate PCIe AtomicOp Completion capabilities and any intermediate switch must indicate PCIe AtomicOp Routing capabilities."

As noted on Intel's product listing for your CPU, the valid PCIe configurations for the 16 PCIe 3.0 lanes on your CPU are:

1x16
2x8
1x8+2x4

Your motherboard's "1x16 + 5x1" (and PCIe 2.0 at that) is not directly supported by your CPU. As such, your PCIe lanes likely connect through either an external chip like a South Bridge, or through a PCIe switch.
Especially for consumer crypto-mining markets, most vendors that build motherboards with multiple PCIe slots like this using switches that do not support mechanisms such as PCIe 3.0 atomics. Such capabilities add cost and are not normally requested by folks looking to cram as many low-power GPUs into a box as they can.
However, as noted above, ROCm requires the ability to communicate using PCIe atomics all the way between your GPU to your CPU for our gfx8 GPUs. If you have a non-compliant switch somewhere in the middle, ROCm will not work with those GPUs. As such, the most likely problem here is this particular motherboard.
As for your second question, please see this much longer discussion about our plans for support for running ROCm on gfx8 GPUs without PCIe atomics. The short version is: at this time, such support is not on our roadmap.


update actions checkout step version

Have been meaning to submit this for a while but it kept slipping. The v2 version of this action is pinned to Node 12, which just went end of life a few weeks ago. The new v3 version uses Node 16, with the major version bump being applied out of an abundance of caution for GitHub Enterprise Server scenarios
https://github.com/actions/checkout#whats-new

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against 62ea370794eddaefaa207e57684a4ad5a8d1017a


Use the new messaging/storage libraries in the recorder

For wellcometrust/platform#3628

Superseded by #129


Fix list items in README.md [skip ci]

This change aims to align separated (unexpected?) list items in README.md as HTML.
For an example of "Removing a column", the multiple lists (
) are rendered currenty:

Ignore the column:

...

Deploy:

Wrap column removing in ...

...

Remove column ignoring from ...

Deploy

But, one list should be rendered here. This change fixes them:

Ignore the column:

Deploy:

Wrap column removing in ...

Remove column ignoring from ...

Deploy

Please feel free to close this PR if the current rendered result is expected.

Note: Hiding whitespaces in the diff view would help us review this change.

Wow, thanks for the quick merge! 😄


Configurable MTU as a channel param to an add Publication call.

It would be useful to be able to set a different size MTU for some publications. This would enable a unicast WAN stream to have a smaller MTU for better coping with loss or a local stream used for large file message transfer to increase from the default size.
This would mean the receiver would need to have receive buffer capable of accepting up to a maximum sized MTU.

Added with this commit. https://github.com/real-logic/Aeron/commit/6dd3540eba7ed1e4343590483543036ade7236b3


Fix language and typos

Fix language

@Rawknee-69 Hi! Thanks for the review. Do I need to do anything else to merge it? Or are we just waiting for the right person?

Nah, nothing more just wait for the master of the repo to clarify and merge your request...


Mini-play controls vanish

OS: Windows 7
Issue Descriptions: The mini player controls vanish after minimizing
Steps to Reproduce: 1, turn on GPMDP 2, Use mini player 3, profit

This is a windows redraw bug, toggle your "use system borders" setting

Toggling System Borders does nothing to fix the issue.
This is a windows 7 system.

Same issue on Archlinux.
There doesn't seem to be a way to return to the full player either. Killing the app is necessary to go back.
Only hotkeys working, perhaps a hotkey to toggle between player modes could help.

@ccolorado What version are you on?

Can't really tell from the application but I found out that it most be very outdated as I haven't switched to the new aur package on this computer.

@ccolorado Make sure the issue doesn't appear using one of the new AUR packages (either gpmdp or gpmdp-git). If it does, report the issue on the AUR first. As the package maintainer, I try to keep @MarshallOfSound's Archlinux issue load down since he doesn't officially support it. I like to troubleshoot issues with users there before we decide to open upstream issues.

Thanks, turns out this computer was using the previous AUR (gpmd) package. Upgraded to the new one and the issue is no longer present.
Thanks


B-20312 Update shipment pickup verbiage INT

Agility ticket
Summary
Updated pickup verbiage and added some test coverage in.
To test:

Create a new move
When you pick a shipment type to create, select HHG.
Verify you see the pickup hint.
Back out and instead of HHG, select PPM.
Verify you do NOT see the pickup hint.
Back out and instead of PPM, pick NTS.
Verify you see the pickup hint.

Why are there changes to gomod and gosum?

Functionality works. Why are there changes to go.mod and go.sum?

Pulled in the latest main and merged that in here. @deandreJones do those changes look right to you?

Functionality works. Why are there changes to go.mod and go.sum?

Pulled in the latest main and merged that in here. @deandreJones do those changes look right to you?

yea there were a lot of lib updates last few days

so that expected( when ppl properly pull in main)


expose status-port in gateway by default

https://github.com/istio/istio/issues/9385
with Istio ingress-gateway support for hc(readiness probe), expose status port(15020) by default to avoid ppl manually updating deploy yaml file(when istio ingress-gateway acts as 2nd LB which requires support hc).

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7591c1302ec1c04e46ca3826ac0a2abdd2b4e4c3
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mandarjog, quanjielin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7591c1302ec1c04e46ca3826ac0a2abdd2b4e4c3
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7591c1302ec1c04e46ca3826ac0a2abdd2b4e4c3
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7591c1302ec1c04e46ca3826ac0a2abdd2b4e4c3
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7591c1302ec1c04e46ca3826ac0a2abdd2b4e4c3
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
7591c1302ec1c04e46ca3826ac0a2abdd2b4e4c3
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/cc @wenchenglu to get to 1.1


Auto DNS is not working.

ISSUE TYPE

Bug Report

Checklist

[x] .env file is attached
[x] docker-compose.override.yml is attached (if it exists - DOESN'T EXIST)
[x] Custom configs from cfg/ dir are attached (if customized - NOT CUSTOMISED)
[ ] docker-compose logs and log/ output is added (will add if requested but logs for PHP-FPM etc. don't seem relevant to DNS...)
[x] I've looked through the docs: https://devilbox.readthedocs.io/en/latest/
[x] I've looked through existing issues: https://github.com/cytopia/devilbox/issues
[x] I've read troubleshooting: https://devilbox.readthedocs.io/en/latest/support/troubleshooting.html

OS / ENVIRONMENT

Host operating system and version: Fedora 29, Kernel 5.x, x86_64
(Windows) Native Docker or Docker Toolbox: N/A
Docker version: Docker version 18.09.6, build 481bc77
Docker Compose version: docker-compose version 1.24.0, build 0aa59064
(Linux) Is SELinux enabled?: Yes
What git commit hash are you on?: fdb6cffb3b32081a6f994cb01736f87cf15b1b1f

SUMMARY

Auto DNS isn't working for me, I read some existing issues and went through everything in those and have been through the documentation and such.

			IN	A

;; ANSWER SECTION:
testing.local.		3600	IN	A	<IP_ADDRESS>

;; AUTHORITY SECTION:
local.			3600	IN	NS	ns2.local.
local.			3600	IN	NS	ns1.local.

;; ADDITIONAL SECTION:
ns1.local.		3600	IN	A	<IP_ADDRESS>
ns2.local.		3600	IN	A	<IP_ADDRESS>

;; Query time: 0 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Sun Jun 09 11:39:21 BST 2019
;; MSG SIZE  rcvd: 154

STEPS TO REPRODUCE

I don't know.
EXPECTED BEHAVIOUR

Auto DNS works.
ACTUAL BEHAVIOUR

Auto DNS doesn't work.
OTHER INFORMATION
Start command

docker-compose stop && docker-compose kill && docker-compose rm -f && docker-compose up

File and user permissions (Linux & MacOS)

uid = 1000
guid = 1000
groups = ... + 974 (docker)

File permissions of the Devilbox directory
drwxrwxr-x.

File permissions of your projects
drwxrwxr-x.

Also the guide said to make sure that nothing is running on port 53 so it feels relevant to mention that sudo -ss -tulpn | grep :53 showed both dnsmasq and avahi-daemon so I have run the following:
sudo systemctl stop avahi-daemon
sudo systemctl stop avahi-daemon.socket
sudo systemctl stop dnsmasq

But their processes were still there so I killed them.

Also worth noting that it doesn't work either if I add the entry to etc/hosts like the UI says to.

Can you check that the bind container is functioning properly via:
dig @<IP_ADDRESS> www.google.com

My /etc/resolv.conf:
# Generated by NetworkManager
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

This should rather look like this:
nameserver <IP_ADDRESS>

It appears to be working after a reboot, my apologies. :frowning: Thanks for making such an awesome piece of software!

OK, glad to hear. I will close this bug report then.

@sustained if you continue to have issues, there are a couple tricks you can do because you are on linux.
instead of forwarding ports from bind to localhost, you can just configure your own dns settings to use the internal docker ip of bind. I have added to my resolv.conf header / setup:
nameserver <IP_ADDRESS>
This prevents me from conflicting with my own OS's dnsmasq / resolving processes.

nameserver <IP_ADDRESS>

Note that the above solution works on MacOS too, as of 12.4 (21F79). Thank you @science695!!
However, note that both localhost and the bind server must be listed and must come before other DNS servers.


Relayed connections fail seemingly randomly with "Packet is a STUN message but no agent handled it"

I'm testing with a forced Relay connection on macOS. I'm blocking direct access to the Vultr stable Gateway in my firewall to make sure Relayed connections are used:
block drop out from any to <IP_ADDRESS>
block drop out from any to 2001:19f0:5401:14df::

Things were mostly smooth all day, until a few minutes ago. Internet connectivity hung, no logs being printed in the Client (logLevel = debug). Quad9 is the upstream DNS, so it's possible access to this Resource went down and caused my Internet to "hang". Happened about an hour or two into my Client's auth session.
I verified no deploy was happening at this time. Gateway was running stable.
Here are the full Client logs:
firezone_logs_2024-06-24T202406Z.zip
And Gateway logs:
logs.txt.zip
Seems that the TURN credentials expired somehow?

The relay credentials are valid for lifetime of your authorization which is ~1 week.

Some intermediate investigation results:

The "Unallowed packet" logs are for one of GitHub's IP.
Prior to them being unallowed, there are multiple functional NAT sessions on the gateway.
About a minute before the unallowed logs, the NAT session expires on the gateway.

@conectado I think one thing that happens here is that after an expired NAT session, we drop the mapping so any packets that are sent from that resource don't get translated and then show up as "Unallowed packet" on the client-side.
Should we extend the lifetime of the NAT sessions?

I think the problem might be this:

snownet::allocation: Allocation is suspended

The gateway fails to use most if not all of its allocations and therefore the connection is broken.

Should we optimistically consider this fixed with https://github.com/firezone/firezone/pull/5512 merged?


can't post comments

the title says it all, if i click on the send button the comment disappear without doing nothing...

Did you try to relogin?

tried and it's working now...thought i've already done that but maybe i am mistaken...

I think this issue should be opened as it's really a bug. The application should notify you that your authentication has expired but it doesn't work this way.

same.issue here, storeman shows log out, but comment disappered after commit


Input component

Something like this

Hi @jrgarciadev! Are you already working on this? I'd like to contribute to that 😁

Hi @DaniAcu, yes I'm currently working on it
I appreciate your contribution intention, however, is core functionality and I'm adjusting design stuff and at the same time writing the code, at the moment are only available fixes or improvements to existing components/docs
Would you like to help the project with another thing? join the discord community to explain the details -> Discord Invitation
Thanks! 🤗


MM-47109 : Migrate components/list_modal.jsx to Typescript

Summary
Migrate components/list_modal.jsx to Typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21061
JIRA: https://mattermost.atlassian.net/browse/MM-47109
Related Pull Requests
None
Screenshots
None
Release Note

Hello @AbhinavVihan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/release-note-none

@AbhinavVihan can you please CI for us to initiate the review

@M-ZubairAhmed, Its ready for review. Thanks

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/update-branch

Error trying to update the PR.
Please do it manually.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/254639

@m1lt0n can you please approve the last workflow and merge? Thanks 🙂

@AbhinavVihan - Thank you for participating in Hacktoberfest!
Please fill out this form if you'd like to get your Hacktoberfest Stickers!

Hi @AbhinavVihan
You were selected as one of our Top Contributors for Hacktoberfest!
Please fill out this form to select your swag as thanks!
Thank you for all you do and for making Mattermost even better!


2.5.1 prerelease

Current dependencies on/for this PR:

main

PR #376

PR #377

PR #378

PR #379   👈

This stack of pull requests is managed by Graphite.


NPE during tagging

Getting this one:
Caused by: org.eclipse.jgit.api.errors.TransportException: git@github.com:decodableco/decodable-job-sdk.git: remote hung up unexpectedly
        at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:147)
        at org.jreleaser.sdk.git.release.ReleaseUtils.tagRelease(ReleaseUtils.java:90)
        ... 128 more
Caused by: org.eclipse.jgit.errors.TransportException: git@github.com:decodableco/decodable-job-sdk.git: remote hung up unexpectedly
        at org.eclipse.jgit.transport.TransportGitSsh$SshPushConnection.<init>(TransportGitSsh.java:382)
        at org.eclipse.jgit.transport.TransportGitSsh.openPush(TransportGitSsh.java:159)
        at org.eclipse.jgit.transport.PushProcess.execute(PushProcess.java:127)
        at org.eclipse.jgit.transport.Transport.push(Transport.java:1384)
        at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:137)
        ... 129 more
Caused by: java.lang.NullPointerException
        at org.eclipse.jgit.transport.SshTransport.getSession(SshTransport.java:107)
        at org.eclipse.jgit.transport.TransportGitSsh$SshPushConnection.<init>(TransportGitSsh.java:358)

Seems like that org.eclipse.jgit.ssh.jsch dependency would need to be added?

Some more context on this one: my git remote was configured to use SSH, not HTTPS. This seems to generally be unsupported with JReleaser currently, since even when I added that dependency, things wouldn't work. It'd still try to authenticate with user name and PAT (as the UsernamePasswordCredentialsProvider is hard-coded in ReleaseUtils, instead of using key-based authentication.
IMO, the best solution to all this would be to use the native git installation (by launching an external process) instead of using jgit. Then I should be able to use key-based auth, with the key passphrase being retrieved from my SSH agent. Another issue with jgit is that the jsch dependency isn't actively maintained, so newer key formats like ed25519 aren't supported.
I got unstuck by changing my remote to use SSH, I think it's worth calling out in the docs that SSH isn't supported atm.?

Failing quickly when SSH is configured as protocol sounds like a quick win we should support right away.
Switching to external git command will take more effort but's probable.

FWIW regarding the state of jsch 👇  https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/68bd2c146239b87d355ed6169ca0ec227a69995d/org.eclipse.jgit.ssh.jsch/
JGit SSH support via JSch
This bundle provides an implementation of git transport over SSH implemented via JSch.
This bundle should be considered deprecated. It is essentially unmaintained, and the JGit project may decide anytime to remove it completely without further ado.
The officially supported SSH transport is in bundle org.eclipse.jgit.ssh.apache and is built upon Apache MINA sshd.


Update to latest version of smbj for Java 17 support

Bug description
Hi @swaechter, there's a newer version of the smbj library that fixes some bugs caused by the update to Java like this, is there any plans to update this library?
Additional information

Version of smbj (0.11.5, from smbjwrapper pom) and smbjwrapper is 1.2.0

Hi @neerajwadhwa-lcci
I just updated all dependencies and tried to upload to Maven Central. This failed because I have to migrate some stuff away from OSSRH. So I am blocked here.
But there is a workaround for Maven and Gradle to use smbjwrapper in version 1.2.0 with the latest smbj release. The idea is to exlude the smbj dependency from smbjwrapper and re-add the current smbj dependency.
Maven
Change your pom.xml:
<dependencies>
	<dependency>
		<!-- Add the smbjwrapper dependency -->
		<groupId>ch.swaechter</groupId>
		<artifactId>smbjwrapper</artifactId>
		<version>1.2.0</version>
		<exclusions>
			<!-- Exclude the outdated compile dependency -->
			<exclusion>
				<groupId>com.hierynomus</groupId>
				<artifactId>commons-lang3</artifactId>
			</exclusion>
		</exclusions>
	</dependency>
	<!-- Re-add the current smbj dependency -->
	<dependency>
		<groupId>com.hierynomus</groupId>
		<artifactId>smbj</artifactId>
		<version>0.13.0</version>
	</dependency>
</dependencies>

You can verify the result with mvn dependency:tree:
[INFO] org.example:smbjtest-maven:jar:1.0-SNAPSHOT
[INFO] +- ch.swaechter:smbjwrapper:jar:1.2.0:compile
[INFO] \- com.hierynomus:smbj:jar:0.13.0:compile
[INFO]    +- org.slf4j:slf4j-api:jar:2.0.9:runtime
[INFO]    +- org.bouncycastle:bcprov-jdk18on:jar:1.75:runtime
[INFO]    +- net.engio:mbassador:jar:1.3.0:runtime
[INFO]    \- com.hierynomus:asn-one:jar:0.6.0:runtime

Gradle
The same works for Gradle, see here: https://docs.gradle.org/current/userguide/dependency_downgrade_and_exclude.html#sec:excluding-transitive-deps
I guess it is also possible to keep the current smbjwrapper version and force the smbj version with the !! operator. This should look something like this (Untested):
implementation 'ch.swaechter:smbjwrapper:1.2.0'
implementation 'com.hierynomus:smbj:0.13.0!!'

Does this work for you?


Support Jina AI LLM

🚀 The feature
https://python.langchain.com/docs/integrations/providers/jina
Motivation, pitch

We need to support more llms so that users have the flexibility of choosing whatever LLM they want to use.
Langchain provides a standard interface for llms. This helps in better code maintenance and also helps in better observability.

Can I work on this?


Make it more clear to Sentry org members how to route new issues

It's currently a bit confusing for Sentry members on how to create issues that should enter the routing queue. Let's improve that process
Solution Brainstorm:

Bot comments a reminder to add the Status: Unrouted label if the issue is created by Sentry org member

Silly idea - add a label when created that would trigger routing if it was removed?
remove-me-to-route or something like that

Status: Unrouted is going away soon, right? I think we should train Sentry staff to apply Product Area: Foo labels themselves, if they're unsure ... lol YOU WORK HERE. No? :)

Yep, Status: Unrouted is going away soon.

I think we should train Sentry staff to apply Product Area: Foo labels themselves. That should trigger "Waiting for: Product Owner," right?  :)

Good point, in regards to the training it could be useful to have the bot comment something to remind Sentry folks to add the Product Area: * labels if a new issue is created. At least a few folks are confused on how to trigger the bot for tickets they create

Also go away you're on vacation lol


Restructure client creation to work for variable google services

Unit tests and making the calendar name configurable to follow.

Lovely.


Wrapped code blocks or syntax highlighting in single backtick code snippets

Idea
I don't know if it's possible to do that as a theme or if it requires deeper logseq changes. But one thing I'd like to have is an option to wrap code blocks.
Screenshots
currently

something like that, maybe with visual indicator that the line is wrapped

The main reason I'd like to see this is for large one line CLI commands like this one

Maybe another solution would be to have syntax highlighting enabled in single backtick code snippets

it's Logseq core things
but you can pass CodeMirror options in config.edn.


Removes encoded chars (spaces) from keywords anchors in libdoc genera…

…ted HTML docs.
Fixes #2110

Admin, can CI be enabled?


Submodule for Vendored AudioPlayer & Updated example RN 0.59 with Hooks

Update the vendored audio player to be a submodule -- furthermore a fork of the original submodule to make it easier to be able to make our own modifications while keeping track of our difference with the original master.
Also updates our example app to not rely on mobx and use the latest RN (0.59.8) with support for hooks.
Also fixes some issues with hooks introduced in @puckey's branch :)

Since the fork is directly linked to this module, shouldn't it go into the react-native-kit org?


question: is type-safety enough?

Is your feature request related to a problem? Please describe.
some quick thoughts on Prisma

there is no migration revert functionality (prisma docs)
there is no built-in support for stored procedures (solution: seed stored procedures & run them via rawQuery)
there is no sub-query support (using a custom query builder is needed for this for example knex) or writing a raw query is needed)
there is no built-in soft delete functionality issue
looks like seeds are not supported for multi-schema setup (docs) (can use raw migrations for this)

If I go deep enough and test Prisma in production, I think I can provide more minus points in this discussion.
Describe the solution you'd like to see
better type-safe full-featured ORM?
Describe alternate solutions
mikro-orm looks type-safe at some point but I didn't test it yet.
Additional information
I'm using TypeORM in production for 4+ years. It is not type-safe and I'm suffering from it.

my real question is this:
Is create-t3-app for MVPs or production-ready applications?
IMO prisma looks ok for MVPs but not good enough for complex apps.

I'm building Ping on top of Prisma. It's fine. Since it's sql, you can replace it if you run into issues later on.
There are no better options. Feel free to make one yourself and let us know about it when you do.


Data Viz

Features:

[x] simplified timeseries

improved tooltip

[x] fixes infinity bug (#25)
[x] simplified histogram

outliers > 95% CDF are hidden by default
CDF hidden from legend and tooltip

[x] show/hide CDF when desktop/mobile histogram series shown/hidden
[x] the singularity is here: eg fix "1 libraries" grammar to "1 library"
[x] security policy (csp, hsts, etc)

Progress on #13

@igrigorik ping -- mostly just looking for feedback on the data viz tooltips, no need for a gritty code review
You can test drive these changes on the staging app: https://httparchive-staging.appspot.com/

Nice work Rick! One thing that is lost in this update is the CDF values on the histogram..

Perhaps this is counter to what you're aiming for here (simplify), but it would be nice if we could somehow persist / communicate that info in the histogram tooltip. WDYT?

Yeah I had a hard time thinking of a way to include it cleanly without adding confusion.
Maybe use the summation symbol ∑ to indicate CDF, in the same kind of design that we use to show change over time in the timeseries summaries:

WDYT?

∑ is not commonly understand symbol for CDF, and afaik I don't think there is one. The best I can come up with is still stick with "CDF: x" but in small text.. =/

Here's a revision that includes CDF. Using the word "Cumulative" here to avoid jargon. WDYT?

^^ 👍 👍
Ship it.

Woohoo! 5/8 of the graduation checklist completed! 🎉


Subscription filter resetting after tab change

When on a tab and filtering out the specific subscriptions, the filter only changes for the specific tab and not all of the tabs. So customers have to change the filter on every tab.

Hi @cshea15, @infosatheesh2020,
I am working on resolving this issue.
Since this change is a little bit large, could you please review this workbook in your environment?
Workbook file:
https://github.com/Azure/reliability-workbook/blob/32771868661d1c5ac44b1ce23cf33fe3f70a60e8/workbooks/Reliability v2.5.json

Will fix v2.5 #25


Monomers do not return to their places in Snake mode, when clicking the “Undo” button

Steps to Reproduce

Switch to the Macro mode – the Snake mode

Open this file  ketcher.51 (1).zip

Move monomers in random order, especially sugars

Switch to the Sequence mode and go back to the Snake mode again

Repeat 3 and 4 points a few times

Click on the “Undo” button several times

Actual behavior
Monomers do not return to their original places. More often reproduced in nucleotides (phosphates)

Expected behavior
All monomers return to their original places
Screenshots
https://github.com/user-attachments/assets/f5767ef3-4cda-49c8-9c30-049fc2c44cc3
Desktop (please complete the following information):

OS: Windows 10 Pro (version 22H2) x64
Browser: Сhrome
Version: (126.0.6478.127) x64

Ketcher version 2.23.0-rc.2, Build at 2024-07-10; 19:45:41
Issue found while testing https://github.com/epam/ketcher/issues/4690

Can't reproduce. @ViktoriaTkacheva could you please recheck?

Tested. Bug fixed.
Desktop:

OS: Windows 11
Browser Chrome
Version 127.0.6533.120 (Official Build) (64-bit)

Ketcher version
[Version 2.24.0-rc.2]
Indigo version
[Version 1.23.0-rc.2]


merge package from arlac77/npm-package-template

.npmignore

chore(npm): update .npmignore from template

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   96.87%   96.87%
=======================================
  Files           1        1
  Lines          32       32
=======================================
  Hits           31       31
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ed04b...3096d4f. Read the comment docs.


Migrated from MSTest v1: AssemblyInitialize method has wrong signature

Description
We are trying to migrate our tests to MSTest v2. Our test assemblies use [AssemblyInitialize] and after migration all our test are failing with the following message:

Method ...InitializeAssembly has wrong signature.  Parameter 1 should be of type Microsoft.VisualStudio.TestTools.UnitTesting.TestContext.

Our InitializeAssembly method looks like this:
[AssemblyInitialize]
public static void InitializeAssembly(TestContext context)
{
	// code
}

First of all, it does meet the requirements. Also, I noticed that the actual message in the current version of code looks slightly different.
This makes me think that Visual Studio somehow uses the old MSTest tooling despite the fact that our projects no longer reference Microsoft.VisualStudio.QualityTools.UnitTestFramework and reference MSTest.TestFramework and MSTest.TestAdapter instead.
Environment
We are referencing MSTest packages version 1.1.14. The problem is present both in VS 2017 test runner and ReSharper test runner.
We are also using the old .csproj format. Is it possible that we need to make some additional migration changes in our csproj files?

@ivonin : It looks like you have the legacy .testsettings specified. If there isn't anything specific that you need in a testsettings, do remove it or move over to .runsettings.

@AbhitejJohn we don't have .testsettings files anywhere in our solution.

That's interesting. Ok I'm assuming you are trying this out from Visual Studio for now and that you do not have a testsettings or vsmdi selected under "Test -> Test Settings" menu. Can you turn on diagnostic logs for vstest.executionengine*.exe and send that over please?

@AbhitejJohn we do use .testrunconfig file for our tests. Can it be a problem? If so, how do I migrate it?

What is it used for? Can you share the contents please?
.runsettings is the single source of all test configuration that we work with.

Here is a our Default.testrunconfig
We use it to deploy some additional configuration into test folders. We don't use it for anything but Deployment section, all the other stuff came from some template a long time ago, I presume.

ah, this is the legacy testsettings. As a replacement to the Deployment section you can set the CopyToOutputDirectory property to Always for the config file in the csproj which includes it. That should be available for the test in the output directory.

Cool, when I don't use .testrunconfig settings it does seem to work, thanks a lot!
We do have some more complex deployment items though, like folders that are not included in solution. It seems to me that .runsettings doesn't support deployment items in any way. Is there a workaround for that?
While I consider my issue fixed, is it possible to make things more clear when there is such misconfiguration? It isn't really obvious what's going on when you get an error that we got.

That's great news @ivonin .

It seems to me that .runsettings doesn't support deployment items in any way. Is there a workaround for that?

you can use the DeploymentItemAttribute for that. Adorn this on a TestClass or TestMethod that needs the folder\file deploymed.

is it possible to make things more clear when there is such misconfiguration?

We do throw out the following warning in the Output -> Tests pane when these settings are used.
Warning : A testsettings file or a runsettings with a ForcedLegacyMode set to true is not supported with the MSTest V2 Adapter.

Feel free to file a new issue if you run into other problems with the migration effort.


Bracket: GetAxisLimits doesn't include bracket corners or label

Bug Report
Issue:
With the right mix of input and window size, you can get GetAxisLimits to chop off the bracket corners (and presumably the label):

Excuse the blurry picture, I had to shrink the window a fair bit to replicate it.
Reproducing:
plt.AddBracket(0, 0, 1, 1, "Bracket");

System Details

ScottPlot Version: Not yet released
Operating System: Windows
Application Type: All
.NET Version: .NET 6

I don't think there's a good way to fix this bug, as the space from the point to the bracket corner is in pixel units, not axis units. So specifying an axis limit that accommodates it is a little sus. So the best option might be to file it under wontfix.
I just figured that I'd bring it up in case you wanted to do something about it before releasing a new version. Even if the most reasonable option is just excluding brackets from axis calculation.

I don't think there's a good way to fix this bug, as the space from the point to the bracket corner is in pixel units, not axis units

This is a similar problem to that recently described by #1844 and #1845 where there's no good way for a plottable to know where things are in pixel space. The solution I used there was to store dimensions after each render and recall them as needed, which isn't great.
The only alternative I can think of is to pass a PlotDimensions into GetAxisLimits(), but that invites a lot of complexity I'm not excited about. For now, I'll just leave things as they are.

most reasonable option

I feel good about including the two coordinates in each bracket in the axis limit calculations, and in the cookbook where necessary I demonstrate how to zoom out a bit using Margins() to ensure edges/text isn't cut-off. It's not perfect, but seems to be a good compromise for now.


Read addon name from addon_service

Heroku started returning different values for the name field, and the actual
name of the addon is in addon_service/name

I'll bump the version to 0.5.0 and update dynosaur-rails after merging this. @werkshy ok?

:+1:  to pierre
:-1: to heroku


Investigate health probe for loadbalancer

When there are two sites, each site can be in multiple states:

Down -> no traffic should go to it

"Keycloak is down" (working already)
"Network between LB and Keycloak is down" (working already)
"External Infinispan is down" (no probe in Keycloak for that currently)
"Communication between Keycloak and Infispan is down" (no probe in Keycloak for that currently)

Up with out-of-date data -> no traffic is allowed go to the site - in A/P this happens only to the passive site

SYNC

Timeout Exception: Data is either lost or arrives too late, no retry -> Infinispan can be configured that the exception is propagated to Keycloak
Suspect exception: assuming data is lost (node to be written to is removed from the JGroup view) as cross-DC doesn't have a retry mechanism in SYNC mode  -> Infinispan can be configured that the exception is propagated to Keycloak
Offline triggered by the number of failures and missing positive acks in an amount of time -> polling of metric or a REST endpoint possible

ASYNC

Secondary site is always out of date
All errors will cause a retry
Offline triggered by the number of failures and missing positive acks in an amount of time -> polling of metric or a REST endpoint possible
Passive site will eventually be up-to-date once the retries succeed and an offline site will receive a state transfer

Up with up-to-date data -> traffic is allowed to go to the site, but it depends if this is site is considered the active side in an active/passive setup

It might get tricky once there is

A failover from a primary to a secondary, and the primary comes up again, doesn't have the data and must not be used
The primary considering the secondary offline, and then the secondary becoming out-of-sync, and then the secondary must not be used even if the primary becomes offline.

The different strategies might depend on SYNC vs. ASYNC setup. To simplify things, only A/P setups can be considered here.

WIP idea:

Have a probe in Keycloak (REST endpoint) that returns the information if the other site is up-to-date
Have a cloud provider specific pod implementing STONITH: If the other site is not considered up-to-date AND the current site is marked available in the loadbalancer, remove the other site from the loadbalancer so it can't become and active out-of-date site (and using some locking preventing the other site doing this concurrently)

There is now a check https://github.com/keycloak/keycloak/issues/25077 which returns if Keycloak can talk to the external Infinispan.
The current setup is limited to A/P sync, so the secondary site is usually up-to-date, or eventually offline when the cross-site fails. This will do for now, closing this issue.


React-dev Form Show, Form Index Search

Make sure you have checked off the following before you issue your Pull Request:

[x] Added unit tests for new functionality
[x] Passed all unit tests using rails test with 90%+ coverage
[n/a] Added cucumber tests for any new functionality
[n/a] Passed all cucumber tests using bundle exec cucumber
[x] Passed overcommit hooks, including running all code through Rubocop
[n/a] If any database changes were made, run rake generate_erd to update the README.md
[n/a] If any changes were made to config/routes.rb run rake jsroutes:generate

This is a really good start. One thing to consider is normalizing the response from the server when you request the forms. I'm assuming that the forms has the questions with it. You can do something similar to what we are working on with ResponseSet: https://github.com/CDCgov/SDP-Vocabulary-Service/pull/93/files#diff-c6c53e7b5c99ce21bb018ddbc9470097


Add more endpoints and some bug fixes

New features

status now has field filtered
GetTimelineHashtagMultiple(...) get multiple hashtags in one call
TagInfo(...), TagFollow(...), TagUnfollow(...), TagsFollowed(...)
AccountsSearchResolve(...) same as AccountsSearch(...) with the addition of the resolve parameter
GetNotificationsExclude(...) same as GetNotifications(...) with the option to exclude notifications of selected typed

Bug fixes

AddToList(...) and RemoveFromList(...) used the parameter accounts_ids instead of accounts_ids[]
Streaming conversations/direct didn't use the correct event. Also added direct streaming for the websocket implementation

Codecov Report
Base: 87.51% // Head: 88.37% // Increases project coverage by +0.86% :tada:

Coverage data is based on head (2b33d0e) compared to base (9faaa4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   87.51%   88.37%   +0.86%
==========================================
  Files          15       16       +1
  Lines        1354     1437      +83
==========================================
+ Hits         1185     1270      +85
+ Misses        125      123       -2
  Partials       44       44

Impacted Files
Coverage Δ

filters.go
96.55% <ø> (ø)

mastodon.go
73.86% <ø> (ø)

accounts.go
100.00% <100.00%> (ø)

lists.go
95.16% <100.00%> (ø)

notification.go
80.76% <100.00%> (+1.89%)
:arrow_up:

status.go
82.26% <100.00%> (+1.21%)
:arrow_up:

streaming.go
97.70% <100.00%> (+0.12%)
:arrow_up:

streaming_ws.go
97.82% <100.00%> (+1.67%)
:arrow_up:

tags.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Hi!
Drive-by comment, because I've been looking at this repo and thinking about a problem you're touching:
I suspect that adding "parameter" struct arguments would be more durable than adding individual functions for every type of parameter you wish to pass.
For example, in this change, you propose adding GetNotificationsExclude with a string[] of excludes:
func (c *Client) GetNotificationsExclude(ctx context.Context, exclude *[]string, pg *Pagination) ([]*Notification, error

For endpoints that need to be added with > a dozen [0] optional parameters, this is not going to work.
I'd propose, instead, modifying GetNotifications to take a new parameter struct as an argument:
type NotificationsParams struct {
    MaxID               ID
    SinceID              ID
    MinID                ID
    Limit                  int64
    Types                []string
    ExcludeTypes    []string
    AccountID         ID
}

func (c *Client) GetNotifications(ctx context.Context, params NotificationParams, pg *Pagination) ([]*Notification, error

I think that "param" structs with one field per potential argument would be easy for users of this API, by making the behavior much more consistent. By keeping the names of the functions matching the API endpoint names, and providing a consistent mechanism for specifying all params, we can reduce confusion and provide a single style for supporting all endpoints and params.
[0] https://docs.joinmastodon.org/methods/admin/accounts/#v1
[1] https://docs.joinmastodon.org/methods/notifications/#query-parameters

If you want to add this fix, could you please rebase master branch?


Show search term in header

When searching, the top line shows "(search)", but not what the search term was.
This can be a bit confusing.
Would be good to show the term in the header, like (search: "searched-term").

Good idea, I'll add it shortly.


Navbar Updated

🚀 Pull Request
Description
Imporved the UI/UX for the Navbar
Tasks Done

[x] Fix the Navbar Position

[x] Add Responsivenesss

Fixes #120

Closes #120

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video
https://github.com/user-attachments/assets/989ff7fa-e3da-47d0-83d7-389c2421b7b7

@abhinab-choudhury what did you enhance as such? The navbar now looks so enlarged and covers whole line, however it is supposed to be kept small so that it looks professional.


i18n(zh-cn): Update guides/server-side-rendering.mdx

What kind of changes does this PR include?

New or updated content
Translated content

Description
Update guides/server-side-rendering.mdx since #4522, #4528

This PR should merge after https://github.com/withastro/docs/pull/4545 is merged.

#4545 was merged!  🙌


Not connected to PowerShell help

This page seems not connected to PowerShell help. When I issue a "Get-Help Remove-AppxPackage -Online", the browser does not open this page. (It opens the PackageManager Class page instead.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f43873-0e34-6ec2-8bde-479945d49ed9
Version Independent ID: 914c97a9-7dc2-6ddd-4756-7ec210db3fe8
Content: Remove-AppxPackage (appx)
Content Source: docset/windows/appx/remove-appxpackage.md
Product: w10
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

@officedocsbot assign @yogkumgit

Hello @skycommand thanks for your feedback.
I created a PR to improve the article so the online version link points to a valid url.
Thank you

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @skycommand Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close