Fix AStar2D, AStar3D, AStarGrid2D from not returning a path when the destination is disabled/solid even with allow_partial_path option

Previously all of the AStar _solve methods would terminate early if the destination point was solid/disabled. This caused confusion amongst users who were expecting the allow_partial_path option to still return a path even if the destination was solid/disabled. I fixed this by pulling that argument into _solve and only terminating early if it was also false, so a path is still returned if the user uses the option.
I noticed however while working on this that doing this significantly changes performance. I added a comment in the docs on the functions for these to warn users about this.
This will also happen whenever the end point is not reachable (aka the path is fully blocked off by solid/disabled points), however the code still executes even if allow_partial_path is false, as the pathfinding still has to run to determine if it is unreachable. I don't know if there is really a good way to fix this, as the only way to know a point is unreachable is traversing the entire graph anyway.
I'm not sure if this should also be mentioned somewhere in the documentation though.
Sample output of a microbenchmark when the destination is a solid/disabled point or unreachable

pathfinding took 15834 microseconds

Compared to when the point is reachable and not solid/disabled

pathfinding took 259 microseconds

This is with 1139 points in the graph.
Here is a sample project to test this:
astar_partial_test.zip
astar_partial_path_fix.webm
Closes https://github.com/godotengine/godot/issues/93409

Thanks!

@theashtronaut Thank you so much for your effort on this, it was driving me nuts having to disable all solids to calculate a path to them!

Hi! I'm fairly new to Godot and Github, could someone explain to me what's going on here? Am I viewing a suggestion for a feature that may be implemented into the Godot engine itself, or an asset feature that can be downloaded and merged with a project by anyone? If it's the latter, how do I actually merge - do I have to download Godot source code and edit it, then relaunch my project in the modified Godot version or something else?
I noticed that Godot 4.3 has "allow_partial_path" while 4,2 doesn't, but the 4.3 version still doesn't work like in the video, it returns an empty path when trying to click on a solid point.

@Valar1415 This is an already merged feature. It should be in the most recent 4.3 beta AFAIK.
If you want to use it from source, all you have to do is download the current Godot master and build it, and launch the project in Godot built from source. Since it's already merged you do not have to create a fork and merge into it

@Zireael07 so in my Godot 4.3 version this feature should work like in the video? Currently it doesn't and if it should, I should check that I haven't set up my function wrong.

Godot 4.3 is from August, and this was merged in September. Try a beta version - afaict the most recent one is from October.

Gotcha, that should be it. Tyvm for the help!


Run opshin command error

Describe the bug
opshin command error
To Reproduce
Steps to reproduce the behavior:

opshin
2.opshin
Traceback (most recent call last):
File "/Users/admin/.conda/envs/py3.9/bin/opshin", line 5, in
from opshin.main import main
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/opshin/init.py", line 17, in
from .compiler import *
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/opshin/compiler.py", line 3, in
from uplc.ast import data_from_cbor
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/uplc/init.py", line 16, in
from .tools import parse, eval, dumps, UPLCDialect, flatten, unflatten
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/uplc/tools.py", line 5, in
from .parser import Parser
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/uplc/parser.py", line 6, in
from . import lexer, ast
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/uplc/ast.py", line 21, in
import pysecp256k1
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/pysecp256k1/init.py", line 4, in
from pysecp256k1.low_level import (
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/pysecp256k1/low_level/init.py", line 1, in
from pysecp256k1.low_level.secp256k1 import *
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/pysecp256k1/low_level/secp256k1.py", line 500, in
lib = load_secp256k1_library(find_pysecp_env_var())
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/pysecp256k1/low_level/secp256k1.py", line 495, in load_secp256k1_library
_add_function_definitions(handle)
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/site-packages/pysecp256k1/low_level/secp256k1.py", line 139, in _add_function_definitions
_secp256k1.secp256k1_ec_pubkey_cmp.restype = ctypes.c_int
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/ctypes/init.py", line 387, in getattr
func = self.getitem(name)
File "/Users/admin/.conda/envs/py3.9/lib/python3.9/ctypes/init.py", line 392, in getitem
func = self._FuncPtr((name_or_ordinal, self))
AttributeError: dlsym(0x3092b6d90, secp256k1_ec_pubkey_cmp): symbol not found

OS: Mac M1 python3.9
pycardano    0.10.0
opshin          0.21.1

Seems like an issue with secp256k1 on MacOS. Did you install secp256k1 (as described in https://github.com/OpShin/uplc?tab=readme-ov-file#secp256k1)? Maybe try a different python version or not using conda?

Seems like an issue with secp256k1 on MacOS. Did you install secp256k1 (as described in https://github.com/OpShin/uplc?tab=readme-ov-file#secp256k1)? Maybe try a different python version or not using conda?
Yeah, after i reinstall secp256k1(https://github.com/bitcoin-core/secp256k1)
opshin worked,Thanks you!


MQTT PUBLISH failed with status MQTTNOMemory

Good morning. I seem to have run across a strange issue I've not encountered before. After some time of this controller being up and running, I'm not able to send telemetry. Can disconnect and reconnect though. As you can see in the log here, I've got a memory log entry right before a call to _SendTelemetry(). The OS task high water mark is 4088 (it's always at this level), total heap free is 67172, and minHeapFree (esp_get_minimum_free_heap_size()) is 42780. Plenty of heap to send this very small message of 177 bytes. These numbers were identical when the previous message was sent successfully. I don't understand why I'd get this error if there's plenty of free memory.
W (16214887) memLog: azureTaskLoop: TaskMax: 4088, HeapFree: 67172, minHeapFree: 42780
E (16214887) MQTT: MQTT PUBLISH failed with status MQTTNoMemory.
E (16214897) AZ IOT: Failed to publish telemetry: MQTT error=0x00000002
E (16214897) AzureService: checkAzureError at sendMessage->AzureIoTHubClient_SendTelemetry, result: 8
E (16214907) AzureService: Send message FAIL: {"id":"00000000000024xxxxxxxxxx","messageType":"postPipeDataPoints","message":"00000000000024xxxxxxxxxx|1655089666|0|30.2|29.6|33.7|0|3.29|3.67|3.16|79.16|80.78|79.34|79.52\n"}

Some research led me to the documentation here, which says that it returns "MQTTNoMemory if pBuffer is too small to hold the MQTT packet. I'm unsure why pBuffer would be too small for this, nor do I fully understand where the size of pBuffer is defined for coreMQTT. I do have a buffer of 4096 defined that is passed as the pucBuffer in AzureIoTHubClient_Init() on startup.

Also found this thread where the poster states that he "had moved AzureIoTHubClient_ProcessLoop() call to a OS task to be called periodically", which is exactly what I've done. I call _SendTelemetry from our main OS task loop, then azure has its own task which is constantly calling _ProcessLoop(). Like the OP there, I do not call _ProcessLoop() from our main task, opting for the azureTask to do all the work next time around. I don't understand why this would be a problem.

Are you able to dig in to the code a bit and see what exactly is returning that failure from the MQTT layer?
 What happens is those messages are stored in the client until they receive PUBACKs since they have QOS 1 guarantees. By default, the MQTT library keeps an array of MQTT_STATE_ARRAY_MAX_COUNT un-ack'd messages, where the return here could be MQTTNoMemory if that array becomes full. In our sample, that number is generally 10.
Since you say you have a lot of heap space, that's probably where I would start. You could try increasing the number in the array via the config or increasing the frequency of calls to _ProcessLoop() or maybe a combination of the two.

I used the middleware sample for ESP32 to implement all this, so whatever is throwing that error would be part of that. I searched around the config and component files making that connection but didn't see anything specific there, so I assume it's what you're pointing to. Is there an easy way to check on the number of messages in that un-ack'd message array? They are all definitely Qos1 messages, but I guess I'm not seeing when a message isn't successfully delivered by _ProcessLoop() as there are no errors from the azure client until this mqtt error shows up. Maybe this is an example of where I need a callback for _SendTelemetry() so I can have a count of queued vs delivered messages. This would allow me to detect a scenario where the azure client is clearly connected, but message after message is not being delivered. _ProcessLoop() is being called as fast as possible with only a vTaskDelay(1) in between.
Here's a thought though... In this test I still had a 2 minute reconnection time period (will be 50 minutes) since I was testing the changes we discussed in the other issue where I'm having to disconnect and reconnect to renew the SAS token. I have a function called doWork (thanks azure-sdk-c, lol). This runs _ProcessLoop(), then after that if it's over 2 minutes since the last successful connection, I call this reconnect process, but only after running _ProcessLoop(). I assume that if there's un-ack'd messages in the mqtt array, and a reconnection event occurs, those messages end up in some sort of purgatory? It did take about 4.5 hours to reach this point, with 1-3 messages sent every 30 seconds. I may have created this situation in my testing, but it seems like this could still happen with a 50 minute reconnection time period so I want to try to address it so the controller doesn't get stuck this way.

I guess it depends on the scenario. If you want to reconnect with a clean session, those will be cleared out here on the connect call in coreMQTT. If you want to connect without the clean session, those will stick around as dictated by the spec.
As for notification of which are ack'd, you can set the telemetry puback callback which will notify you of any received pubacks. That should help you track how many are waiting to be puback'd. But know that any message with QOS1 will be put in the queue. So twin or command responses would also reside there.

I think this is resolved so will close for now. Please let us know if you would like it reopened.

I guess it depends on the scenario. If you want to reconnect with a clean session, those will be cleared out here on the connect call in coreMQTT. If you want to connect without the clean session, those will stick around as dictated by the spec.
@danewalton
As for notification of which are ack'd, you can set the telemetry puback callback which will notify you of any received pubacks. That should help you track how many are waiting to be puback'd. But know that any message with QOS1 will be put in the queue. So twin or command responses would also reside there.

I am looking to find out how or who manages the retransmits for messages that are not Ack'ed.
What is the timeout for non-acked messages?
Can you point me to where this is managed at?
Thanks


Retry on wget

Noticed good number of gate test failures because of temporary connection issues
to proxy node. So adding retry on wgets in userdata.
Also this patch add a retry function which can be reused.
This should fix #402

please test this

wget provides this capability from the command line. closing.


[Doc Improvement][Update application permissions]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
91
33
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 428e058:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:warning:Warning
View
Details

msteams-platform/resources/schema/manifest-schema.md

Line 829, Column 190: [Warning: bookmark-not-found] Cannot find bookmark '#delegated-permissions' in 'resources/schema/manifest-schema.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
91
33
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 6d6083d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
91
33
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 71b25d1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
91
33
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit d48f6dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b1316b2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 9238015:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 6cf57dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema-dev-preview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b1ac963:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema-dev-preview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 840ab17:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema-dev-preview.md
:warning:Warning
View
Details

msteams-platform/resources/schema/manifest-schema.md
:warning:Warning
View
Details

msteams-platform/resources/schema/manifest-schema-dev-preview.md

Line 652, Column 185: [Warning: bookmark-not-found] Cannot find bookmark '#delegated-permissions' in 'resources/schema/manifest-schema-dev-preview.md'.

msteams-platform/resources/schema/manifest-schema.md

Line 823, Column 185: [Warning: bookmark-not-found] Cannot find bookmark '#delegated-permissions' in 'resources/schema/manifest-schema.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f6b4c62:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 054225b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit e46d2ee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema-dev-preview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit aab9caa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema-dev-preview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 9a02db4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema-dev-preview.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
84
52
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
91
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


support setting offset in option

If the height of fixed navigation menu alway be 100px, that would be handy.
skrollr.menu.init(s, {
animate: true,
offset: -100}
)
or a function just like duration does, the height of fixed navigation menu could be changed with scrolling.

Enhancement: add another init-option like
offsetContainer: <id-of-container>
where you can place the id of the menu element describing the offset
If the height of that element e.g. changes (by media query or scrollr), use the new height as offset. This would make it supereasy to handle with menubars at the top.


Fixes playlist example issue #139

Fixes #139 by seeking content to 0 immediately before pausing and switching to new content.

LGTM


Refine the relationship/differences between inputs vs parameters for operations

Currently for each operation documented in the spec we have the notion of both inputs and parameters, a convention adopted from the bls-signature-draft.
Loosely what I think we have been following as a largely unwritten rule is that inputs are usually more dynamic or application driven/supplied in nature, where as parameters are more constant across multiple invocations of an operation(s).
To make things more complex we also appear to have two types/scopes of parameters, parameters shared across all operations vs parameters semi-unique to an operation, although it doesn't look like we are following this strictly.
I think we need to

Rationalise the difference between what constitutes an input vs a parameter
Decide on the scoping of various parameters and how we notate them in reference to specific operations for example do we inline them all? or reference them from a common section that applies to all operations, or both?

Furthermore I think we need to revisit certain values that may instead be considered parameters instead of inputs, in particular message generators. This is discussed more in #117

One option would be to define that anything that is described by a ciphersuite (i.e., base points etc.,) is a parameter. This will also apply to the message generators.
A stricter definition will be to consider anything that is defined by a ciphersuite AND it is independent from any inputs to be a parameter. This doesn't really apply to the message generators (their number depends to the number of messages).
Regarding 2 my vote is to inline the parameters if we would to consider the message generators as a parameter. If the message generators are supplied as input we can have a separate section to avoid repeated text.

Discussed on the WG on the 6th of February. Will check for any inconsistency and try to close next weak.

Discussed on WG on the 6th of Mar. Will check for consistency and close before publishing draft 02.

Checks were done prior to draft-2 publication, no issue found, closing as a result.


[poll] BodyHash extractor

React to this issue with a ":+1:" to vote for this feature. Highest voted features will graduate to Actix Web sooner.

released in crate actix-hash: https://docs.rs/actix-hash


Input should be a valid dictionary or instance of SentenceSimilarityInputsCheck: received `Context information is below.

Describe the bug
hello everyone, i am using these 2 models like :
Settings.llm = HuggingFaceInferenceAPI(model_name="sentence-transformers/all-MiniLM-L6-v2", api_key=hf_token)
Settings.embed_model = HuggingFaceEmbedding(model_name='BAAI/bge-m3')

and i get this error every time i run the code :
BadRequestError:  (Request ID: iSyblEXWumFZFNfAZERUT)
Bad request:
Input should be a valid dictionary or instance of SentenceSimilarityInputsCheck: received `Context information is below.
Can someone help with this !
Reproduction
if not os.path.exists(persis_dir):
  documents = SimpleDirectoryReader('data').load_data()
  index = VectorStoreIndex.from_documents(documents)
  index.storage_context.persist(persist_dir=persis_dir)
else:
  storage_context = StorageContext.from_defaults(persist_dir=persis_dir)
  index = load_index_from_storage(storage_context=storage_context)

Logs
No response
System info
- huggingface_hub version: 0.20.3
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Token path ?: /root/.cache/huggingface/token
- Has saved token ?: True
- Who am I ?: farazfarid
- Configured git credential helpers:
- FastAI: 2.7.14
- Tensorflow: 2.15.0
- Torch: 2.2.1+cu121
- Jinja2: 3.1.3
- Graphviz: 0.20.3
- Pydot: 1.4.2
- Pillow: 9.4.0
- hf_transfer: N/A
- gradio: N/A
- tensorboard: N/A
- numpy: 1.25.2
- pydantic: 2.6.4
- aiohttp: 3.9.3
- ENDPOINT: https://huggingface.co
- HF_HUB_CACHE: /root/.cache/huggingface/hub
- HF_ASSETS_CACHE: /root/.cache/huggingface/assets
- HF_TOKEN_PATH: /root/.cache/huggingface/token
- HF_HUB_OFFLINE: False
- HF_HUB_DISABLE_TELEMETRY: False
- HF_HUB_DISABLE_PROGRESS_BARS: None
- HF_HUB_DISABLE_SYMLINKS_WARNING: False
- HF_HUB_DISABLE_EXPERIMENTAL_WARNING: False
- HF_HUB_DISABLE_IMPLICIT_TOKEN: False
- HF_HUB_ENABLE_HF_TRANSFER: False
- HF_HUB_ETAG_TIMEOUT: 10
- HF_HUB_DOWNLOAD_TIMEOUT: 10

Hi @asma-10, which library are you using? This doesn't look like an error in the huggingface_hub library. Could you report your bug to the correct repo instead? (LlamaIndex I assume?).

hi @Wauplin thanks for your response,
oh okey, as long as it is not a hugging_face error i will report this bug in llamaindex they may have a solution right there
Thanks again


Required.Always do not work for not nullable value types

Source/destination types
public class AnyClass
{
        [JsonProperty(Required = Required.Always)]
        public DateTime Timestamp { get; set; }

        [JsonProperty(Required = Required.Always)]
        public int AnyInt { get; set; }

        [JsonProperty(Required = Required.Always)]
        public DateTime? NullableTimestamp { get; set; }
}
[HttpPut]
[Route("")]
public async Task<IHttpActionResult> Handle(TmsType78DataDto tmsType78DataDto)
{
     if (!ModelState.IsValid)
     {
            return BadRequest(ModelState);
     }
}

Expected behavior
The exception will throw for the "AnyClass" property that does not present in JSON including those that can not be null.
Actual behavior
The exception trows for NullableTimestamp only as it can be null

@polux2016 Any news about it?


Support for VK_KHR_mir_surface should be removed

See also https://github.com/KhronosGroup/Vulkan-Docs/issues/814

Thanks for the tips.
My generator will automatically remove it when it will be removed from the vulkan spec file.


Squashed code snippets

The code snippets at https://beam.apache.org/get-started/from-spark/#setup are quite wrapped, despite plenty of whitespace around them.
Imported from Jira BEAM-12239. Original Jira may contain additional context.
Reported by: robertwb.

.take-issue

Fixed with https://github.com/apache/beam/pull/22770


Adds streetview image to project view

Uses address string. Some may come up without image available. Lat/long is possible, but then you have to set heading and pitch of the camera.

Ah, I branched this from an unmerged branch. Will delete this PR and redo from clean branch.


Whatsapp Automatic backup doesn't work

Beta version 1.5.6 on LG-G2 - managed to backup the Whatsapp messages but the automatic backup doesn't work for Whatsapp only for SMS.

whatsapp no longer supported


String Seq String can't accept

i trying to use
val myString = Seq["test", "abc", "efg"]

def test[_: P] = StringIn(myString: _*).!
val result = fastparse.parse("test", test(_))

i got this
Error:(12, 26) Function can only accept constant singleton type
def test[_: P] = StringIn(myString : _*).!

Probably going to call this the same issue as https://github.com/com-lihaoyi/fastparse/issues/298; it's not the same symptom, but it has the same workaround. We really should document it better


Fix for right aligned nodes being set to left aligned in Unity.

Before:

After:

Tested in Unity version 2021.3.10f1

Thanks for the great fix!


tests: Use unified link_ram_cortex_m.x linker script

Firstly, sync link_ram.x file with upstream (only tested with nrf52840 target) and then switch all Cortex-M targets to use single file instead of 3 copies.

bender run


Create a singularity container for METviewer

Replace italics below with details for this issue.
Describe the Enhancement
Most HPCs are not allowing Docker containers but they do allow singularity. We need to look into creating
A singularity container for METviewer
Time Estimate
3 days or more
Sub-Issues
Consider breaking the enhancement down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
None
Funding Source
UAE-NCM has the most immediate requirement
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select  no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
[ ] Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s), Project(s), Milestone, and Linked issues
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

@georgemccabe can you think about whether what Hank says in this issue is relevant for what we discussed today? If so, I can incorporate this into the workflow for NRL and add more details to the issue.

If NRL is interested in creating scorecards from METviewer, then this would be useful since scorecards can only be generated via the command line.


Use sphinx.ext.linkcode for more precise source code links (Cherry-pick of #1431)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.972%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5034

Relevant Lines:
6217

💛  - Coveralls


hyper HTTP2 slower than hyper HTTP1 on top of MPTCP

Problem
Using hyper HTTP1 and HTTP2 on top of mptcp using 2 interfaces on client and 2 on server end (Can share some steps to set it up if needed) to download files from a server caddy 0.10. hyper HTTP1 downloads the files faster (at iperf tcp measured end-to-end bandwidth) than HTTP2 check the pcap files.
Probable source of problem
Although I am using 1 stream over HTTP2 in my case, the infrastructure provided by hyper HTTP2 to have multiple-streams could have overhead while reading from 2 interfaces into the buffer. Any other insights are welcome.
Other HTTP2 client tried
curl with http2, also performs faster than hyper HTTP2
Code used
hyper HTTP2 client script to download file
hyper HTTP1 client script to download file
curl HTTP2 client script to download file
Dependancies
caddy 0.10
use Caddyfile. run: ./caddy -http2 -log a.log
Installing curl http2
using curl HTTP2
due need to observe data chunks as they are downloaded we made small modification to hyper HTTP1
Extra info
Can send pacp files for the 2 interfaces used if necessary (for curl HTTP2, hyper HTTP1 and hyper HTTP2)

Hi All,
Can you please give me some feedback on if you need me to better document/ask the question? Or give me hints on who to approach?
Thanks,
Raj

I wouldn't assume mptcp has any anything to do with it. I've noticed in a load testing script that it takes nearly twice as long to download a test resource using HTTP2 as it does using HTTP/1.1 on a totally stock Ubuntu install.

Hi @alangibson
I have switched to using a c++ based application using libcurl library and it is giving me good (expected) performance.


Unable to run PowerShell modules that requires administrator privileges with sudo

Sudo for Windows version
0.1.5
Windows build number
10.0.26063.1
Other Software
No response
Steps to reproduce
I wanted to run PowerShell modules like get-windowsupdate with sudo since it requires to be run in an elevated PowerShell console.

Expected Behavior
A UAC window will pop up and the command will run.
Actual Behavior
After launching sudo, it showed command not found.

I am having the same issue, I am simply running sudo directly after enabling it in directly in settings
For me I run sudo copy-item .\hosts .\hosts.old and get the same error of command not found
I've tried:
Copy-Item (with capital letters)
with -source and -destination
with absolute paths

For the time being, and until Microsoft publishes how sudo and PowerShell integration works, I recommend you elevate PowerShell commands using the following syntax:
sudo pwsh { script }
If you want to use variables, you need to use sudo pwsh { Copy-item -source $args[0] -destination $args[1] } -args $src, $dst

Ye that worked except I typod when I said -source, its -path. It does work in that way for me. Hopefully op will test. Ill avoid until that is fixed tbh

the root issue is not powershell specific. rather, it is
"Implement a feature | syntax to indicate sudo that it should use the current shell(from which sudo is invoked) to execute the commands".
this will solve both:

running shell specific commands without specifying the current shell name.

For example: you will be able to run cmd specifc commands directly without prefixing cmd.

nested shell specific commands.

For example: you could be running powershell specific commands inside nushell inside cmd and you won't have to prefix pwsh.

/dup #5


Delete extraneous Jedis connection close

From https://github.com/xetorthio/jedis/wiki/Getting-started :
/// Jedis implements Closeable. Hence, the jedis instance will be auto-closed after the last statement.
try (Jedis jedis = pool.getResource()) {

Removal of the unnecessary closure here seems to have resolved the concurrency crash. Let me know if this holds up!

LGTM! it seems like the original code could have "return" another threads connection to the pool


test(28): Ditch karma and mocha for AVA

Context
The Karma + Headless Chrome testing approach is becoming a headache, with over 10 developer dependencies being pulled in just for testing.
Objective

Remove karma, add browser environment mocks
Switch out Mocha for AVA

References

Issue: https://github.com/ScottyFillups/key-controller/issues/28

Lessons learned

Install ava@next instead of ava
AVA doesn't transpile your source files; you'll need to use babel-register and  babel-plugin-transform-es2015-modules-commonjs
Use browser-env for mocking the browser environment
Mocks > headless chrome
LTS stands for "long-term support"; all even Node.js versions (e.g. 8, 10) are LTS
AVA does not support non-LTS Node.js versions (e.g. Node.js 9)

:tada: This PR is included in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Several extensions (incl python and bracket-pair-colorizer) don't seem to work with v3.50

I just upgraded to v3.5.0 and am noticing a number of extensions from the MS marketplace not working

Web Browser: Chrome
Local OS: macOS
Remote OS: Ubuntu 20.04 in Docker
code-server --version: 3.5.0

Package versions used are the latest on MS market place that all work with VSCode 1.48.2 and are all copied at the link below so they can be used when creating a docker container. The container is on dockerhub (vnijs/rsm-msba).
https://github.com/radiant-rstats/docker-vsix
The docker file and relevant scripts etc. are available at the link below.
https://github.com/radiant-rstats/docker/tree/master/rsm-msba

FYI Python 2020.7.1 does seem to work but the 2020.8.106424 version does not
https://marketplace.visualstudio.com/items?itemName=ms-python.python

Same issue for Bracket Pair Colorizer 2

See https://github.com/cdr/code-server/issues/2197 for the bracket plugin. I have not yet been able to debug the Python extension, although maybe https://github.com/cdr/code-server/issues/1837 is related.

Yup closing this issue, please follow along at #2197


Make optional printing spec name before running

Just like clearing screen before running any spec, is there any way to not printing the spec name?
Thanks for your hard work!

Thank you. Are you referring to a particular test framework or strategy where this happens?

I am using vimux on rails rspec tests.
I don't know much about vim but from what i understood, it calls this method on strategy.vim
function! test#strategy#vimux(cmd) abort
  if exists('g:test#preserve_screen') && !g:test#preserve_screen
    if exists('g:VimuxRunnerIndex') && _VimuxHasRunner(g:VimuxRunnerIndex) != -1
      call VimuxRunCommand(!s:Windows() ? 'clear' : 'cls')
      call VimuxClearRunnerHistory()
    endif
    call VimuxRunCommand(s:command(a:cmd))
  else
    call VimuxRunCommand(s:pretty_command(a:cmd))
  endif
endfunction

and i end up on the else part that calls pretty_command and ends calling echo on terminal.
I "fixed" by disabling both test#preserve_screen and g:VimuxRunnerIndex (making less than 1), but i don't know if this is correct.

Yes, printing commands is not framework-specific, it's implemented on the strategies level, I think it's applied to most strategies. I would probably be useful to have a separate configuration option (e.g. test#echo_command, that can be set to 0) for disabling printing.
If you agree with that, I'd welcome a PR (I don't have time to make one myself unfortunately).


getActionById no longer has setState()

With the new 1.0 release, getActionById no longer has setState(). It seems to also be missing from event scopes also (ev.action.setState()). What is the recommended remediation here?

Actually it seems you've scoped them now, so you need to add:
if (! getActionById(id).isKey()) return;
to have them resolvable.
This should be added to the UPGRADE doc ideally.

Hi @logicallysynced, I've updated the "Keys and Dials" section of the upgrade path to now provide the list of impacted methods — apologies for any inconvenience caused. 🙏


implement light sensor driver

Summary
Implement initialization and lux code
Implement helper functions read, write, bit masks, conversion_ready, delete
Test Plan
TBD at Satsurday 12/6/20, waiting on sensor to be plugged into board
Related Issues
Delete bytes array — Does python automatically deallocate?
Change default time to 100ms
Potentially change ADDR constant
Check whether all of default configurations are desirable

We will leave this PR open until we can test it.


Small fixes to IPv4 reassembly code

This patch contains a series of small cleanups to the IPv4 reassembly code and its unit tests, as suggested in PR #116:

Removes an unneeded localization of pairs().
Changes uses of the vlan_tag identifier to vlan_id, because only identifiers are passed around in the code, and vlan_tag suggests that the variables may contain the VLAN TPID.
The VLAN identifier field and the protocol type are checked field by field, instead of doing a byte-by-byte comparison. This better reflects the intention of the code in check_packet_fragment().

LGTM, with one nit :)


Replicate request failing

What operating system are you using?
Mac
What browser are you using?
Safari, Arc, Chromium
Describe the bug
When attempting to use replicate, I will send a prompt through, and the anse app will respond with:
provider_error
Request failed
When I go to my replicate dashboard, it creates the run and completes it though, So I'm not sure why it has trouble communicating that back to Anse.
All other parts of the application are working as expected. The only issue is with the replicate requests themselves.
What provider are you using?
Others (Specify in description)
What prompt did you enter?
"Generate an anime profile picture of cirilia from the Witcher series"
Console Logs
I'm currently not on a computer I can generate a log on, When I get to my personal computer later I can add this.
Participation

[X] I am willing to submit a pull request for this issue.

I wanted to post a new comment and say It seems this issue only happens when using Safari. I will try and see if I can replicate this issue on my home computer today.


[TBL] Call collex directly for reports

Motivation and Context

Removes the call to backstage for getting chasing reports.
What has changed

Changes the download_report method in collection_exercise_controller.py to hit the collection exercise endpoint directly.
How to test?

Run the unit tests, make sure they pass.
Run the unit tests, make sure they pass.
Tail the logs for backstage, collection-exercise service. Hit the response_chasing/<ce_id>/<survey_id> endpoint using curl or Postman. Make sure backstage doesn't get the call, but collection-exercise service does.

@benjefferies and @jcox-dev - I've addressed your comments. There is no concept of basic auth yet for report service. This should be added by @AdamHawtin and co when it is implemented.

 response-operations-ui should directly call other services (not via backstage)

Cheers @benjefferies


add kwargs to Pipeline.from_script

Description
Add the ability to specify keywords in Pipeline.from_script to be passed to Actor.__init__.
This allows to skip validation:
pipeline = Pipeline.from_script(
    script=script,
    start_label=("flow", "start_node"),
    fallback_label=("flow", "fallback_node"),
    validation_stage=False,
)

Checklist

[x] I have covered the code with tests
[ ] I have added comments to my code to help others understand it
[x] I have updated the documentation to reflect the changes
[x] I have performed a self-review of the changes

This change should be made in #73.


how to prepare a validation folder?

thanks for your sharing at first. But i want to figure out how to run the inference code, and how to prepare the validate data

Hi,
the validation folder should contain subfolders, each subfolder named with the class name of the videos in that folder.


[narwhal] initialize GC round on recovery

CertificateWaiter relies on tx_consensus_round_updates to calculate the GC round, which serves as the basis for fetching certificates from remote nodes (certificates earlier than GC round will not make into the DAG). However after a node restarts, tx_consensus_round_updates is initialized to the default value 0 and not recovered.
In practice after a primary has accumulated many certificates locally, the above is more problematic: when fetching certificates, CertificateWaiter sends the GC round and bitmaps for the rounds where it has certificates above the GC round. When there are millions of certificates above the GC round, the server takes a long time to scan through the bitmaps of rounds to avoid sending back duplicated certificate. The CertificateWaiter client can time out during the period, and not make any progress.
This PR sets the last committed round on recovery, to avoid the issue. There are other tokio watch channels that are not recovered, and we may want to implement similar fix.
Also, add more debug logs to fetch_certificate handler, and load certificates for at most 10s, to avoid clients timing out and wasting work.
TODO:
uni tests

Great catch and thanks @mwtian for this!! 💯
For post mortem reasons, I am citing here the task that I did create back then for the gc round recovery and we never picked up #5326 . I believe it was an oversight and we should have done it (still can't remember why it hasn't been picked up), although I guess with the old certificate_waiter it was less important due to its recursive nature and checking against the store, so maybe it wasn't treated as must done.

Yes, thanks for the info. The first implementation of CertificateWaiter did not rely on gc round either.


🐛 Property '_WORKLET' doesn't exist

What were you trying to do?
Hi, I  am trying to  implement custom processor
Reproduceable Code
#import <Foundation/Foundation.h>
#import <VisionCamera/FrameProcessorPlugin.h>

@interface VISION_EXPORT_SWIFT_FRAME_PROCESSOR(beautifulFace, VisionFrameProcessorPlugin)
@end

*Swift*
@objc(VisionFrameProcessorPlugin)
public class VisionFrameProcessorPlugin: NSObject, FrameProcessorPluginBase {
    @objc
    public static func callback(_ frame: Frame!, withArgs args: [Any]!) -> Any! {
      guard let imageBuffer = CMSampleBufferGetImageBuffer(frame.buffer) else {
          return nil
      }
      ...
      return newFrame
    }
}

babelconfig
module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: [
    ['react-native-reanimated/plugin',
    {
      globals: ['__beautifulFace'],
    },]
  ]
};

decrale JS processor
import type { Frame } from 'react-native-vision-camera';

declare let _WORKLET: true | undefined;

export function beautifulFace(frame : Frame) : Frame {
    'worklet';
    if (!_WORKLET) throw new Error('examplePluginSwift must be called from a frame processor!');
    return __beautifulFace(frame)
}

useFrameProcessor
const frameProcessor = useFrameProcessor((frame) => {
        'worklet';
        const paint = Skia.Paint()
        paint.setImageFilter
        paint.setColor(Skia.Color('red'))

        const rect = Skia.XYWHRect(400, 500, 100, 100)
        frame.drawRect(rect, paint)

        const result = beautifulFace()
        console.log('result')
    }, []);

What happened instead?
2023-06-08 15:05:54.464218+0700 VedaxLink[86828:25596454] [javascript] Frame Processor threw an error: Property '_WORKLET' doesn't exist
In: ReferenceError: Property '_WORKLET' doesn't exist
        at beautifulFace (/Users/vedaxm1/Documents/Work/VedaxLink/utils/processor/VisionCameraProcessor.ts:1:36)
        at fn (native)
        at anonymous (/Users/vedaxm1/Documents/Work/VedaxLink/screen/call/GroupCallScreen.js:1:243)
        at fn (native)
        at anonymous (/Users/vedaxm1/Documents/Work/VedaxLink/node_modules/react-native-vision-camera/src/hooks/useFrameProcessor.ts:1:108)

Here is log
2023-06-08 15:22:40.879995+0700 VedaxLink[86870:25605389] Metal GPU Frame Capture Enabled
2023-06-08 15:22:40.880435+0700 VedaxLink[86870:25605389] Metal API Validation Enabled
2023-06-08 15:22:40.955832+0700 VedaxLink[86870:25605389] [native] [GESTURE HANDLER] Initialize gesture handler for view <RCTRootContentView: 0x11fe1a220; reactTag: 1; frame = (0 0; 390 844); gestureRecognizers = <NSArray: 0x2825540c0>; layer = <CALayer: 0x282b2fc40>>
2023-06-08 15:22:41.520639+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Installing Frame Processor Bindings for Bridge...
2023-06-08 15:22:41.520764+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Creating Worklet Context...
2023-06-08 15:22:41.524259+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Worklet Context Created!
2023-06-08 15:22:41.524360+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Installing Frame Processor plugins...
2023-06-08 15:22:41.524408+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Installing Frame Processor plugin "beautifulFace"...
2023-06-08 15:22:41.524467+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Frame Processor plugins installed!
2023-06-08 15:22:41.524501+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Installing global functions...
2023-06-08 15:22:41.524542+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Finished installing bindings.
2023-06-08 15:22:42.549403+0700 VedaxLink[86870:25605573] FrameProcessorBindings: Setting new frame processor...
2023-06-08 15:22:42.550948+0700 VedaxLink[86870:25605389] [native] [GESTURE HANDLER] Initialize gesture handler for view <RNSScreenView: 0x12711f6d0; reactTag: 4093; frame = (0 0; 390 844); autoresize = W+H; gestureRecognizers = <NSArray: 0x2827b18f0>; animations = { UIPacingAnimationForAnimatorsKey=<CABasicAnimation: 0x282a14b80>; position=<CASpringAnimation: 0x282a15980>; }; layer = <CALayer: 0x282a36840>>
2023-06-08 15:22:42.554563+0700 VedaxLink[86870:25605389] VisionCamera: Starting SkiaMetalCanvasProvider DisplayLink...

Relevant log output
No response
Device
Iphone 12
VisionCamera Version
v3 rc
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

same error here, using react-native-vision-camera#3.1.0

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖

This is most definitely not a stale issue. @mrousavy I am beginning to see a pattern of you closing unresolved issues.
I just got this same error
Frame Processor threw an error: Property '_WORKLET' doesn't exist

I have searched everywhere and they all point to react-native-vision-camera

Sure @natemartins, if you want me to fix an error for you that does not reproduce in the Example app, I offer consultancy services billed by the hour. Email me if you're interested.

@natemartins do you call the react-native-reanimated runOnJS on your frame processor?

@xseignard Yes, I did. That was what threw the error

any updates? I have same issue using:     "react-native-vision-camera": "^3.3.1"

@Tamimjabr same as above, I guess you use react-native-reanimated runOnJS on your frame processor
please switch to https://github.com/margelo/react-native-worklets-core
Use const myFunctionJS = Worklets.createRunInJsFn(myFunction) and then call myFunctionJS from the frame processro

@Tamimjabr same as above, I guess you use react-native-reanimated runOnJS on your frame processor please switch to https://github.com/margelo/react-native-worklets-core
Use const myFunctionJS = Worklets.createRunInJsFn(myFunction) and then call myFunctionJS from the frame processor

life saver thanks a lot

Use const myFunctionJS = Worklets.createRunInJsFn(myFunction) and then call myFunctionJS from the frame processor
Where Worklets imports from? not clear lol

thanks for the tip @Tamimjabr


partial-matching ( wild card * ) query

I have set searchrule from title field on elastic result as show in below.
<?php

namespace App;

use ScoutElastic\SearchRule;

class MySearchRule extends SearchRule
{
    public function buildQueryPayload()
    {
        return [
            'must' => [
                'match' => [
                    'title' => $this->builder->query
                ]
            ]
        ];
    }
}

For ex. if I search apple than it's shows result related to apple but if I search for app result is blank. In short I want to set like query (%keyword%) with my title how can I that.

@yassir1994 please, check your mapping. You probably want title to be text type, with standard analyzer.


Support for environment variables with valueFrom.fieldRef.fieldPath to access pod information

Which area this feature is related to?

/area api
Which functionality do you think we should add?

Why is this needed? Is your feature request related to a problem?
This feature would be useful if a workspace container needs to know details about the running workspace pod which are not known at the time the devfile is written (e.g. the pod IP, pod namespace etc.)
Detailed description:
Kubernetes provides the ability to expose Pod information to containers via environment variables: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/.
Describe the solution you'd like

Following the link provided above, it would be great if we can provide pod field references to be the values of the environment variables.
For example:
...
components:
  - name: mycontainer
    container:
      image: imageurl
      env:
        - name: MY_POD_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        - name: MY_POD_IP
          valueFrom:
            fieldRef:
              fieldPath: status.podIP
...

Describe alternatives you've considered

An alternative might be to use a kubernetes client from a workspace container to access pod details.
Additional context

closing as rotten


CreateApiClient Filter is not using the Promise API correctly

https://github.com/SecureBankingAccessToolkit/securebanking-openbanking-uk-gateway/blob/b582cbcff035c399121bebd1ca4e7d339e64458c/config/7.1.0/securebanking/ig/scripts/groovy/CreateApiClient.groovy#L33
For POST requests (creating a new ApiClient in IDM), the thenOnResult callback is being used.
This callback accepts a ResultHandler function, this is a void function which consumes a result. At various points in the result handler a response object is being returned, this is incorrect, if a response object needs to be returned one of the then  functions should be used instead.
With the code in its current state, it is not clear if all of the error responses are making their way back to the client.

Verified that error responses are getting returned. This must work due to some laxness in groovy / the script execution environment. Writing the same code in Java would fail to compile.


Updated: clipgrab 3.8.5

Newer version of clipgrab (3.8.6) is now available in master. 17fda35fced44789cd719fc580af510cda045e9a


Drag and Drop ghost shifts during grab on Chrome

When you drag to move an event on Chrome, the event shifts slightly wrt the cursor while holding the event. This can lead to the user dropping it on the wrong time because it is visually shifted while grabbed. This does not happen on Firefox.
The demo shows the difference https://antoniandre.github.io/vue-cal/#top
Chrome: 92.0.4515.131
Firefox: 91.0

Not able to reproduce, still a problem with latest Chrome for you?

Not able to reproduce neither.
Closing due to inactivity. please reopen with repro or screencast at least if not solved.
thanks @rubjo for your help!


Release 2019-12-19 toolchain for macOS.

https://github.com/apple/swift/commit/05c45392d5f063947d4f6df0e2335186cdd82f7e

Notable changes:

swift-DEVELOPMENT-SNAPSHOT-2019-12-16-a -> tensorflow merge: https://github.com/apple/swift/pull/28847.
Array literal differentiation fixes: https://github.com/apple/swift/pull/28889.

SwiftPM commands are broken with the swift-tensorflow-DEVELOPMENT-2019-12-19-a macOS toolchain:
$ swift build
dyld: Library not loaded: @rpath/libswiftCore.dylib
  Referenced from: /Library/Developer/Toolchains/swift-tensorflow-DEVELOPMENT-2019-12-19-a.xctoolchain/usr/bin/swift-build
  Reason: image not found
[1]    45688 abort      swift build

Issue tracked by https://github.com/tensorflow/swift/issues/347.


controlsd: ignore peripheralState in SIMULATION

What’s this for?

yeah for regen, closing this and migrating peripheralState in https://github.com/commaai/openpilot/pull/30141


Add a single doc page for Tools and Extensions

fixes #395

Thank you very much Erik. I verified all the redirects and they are correct.


Duplicate lists.

扩展版本 (extension version): 1.3.12
浏览器版本 (browser version): Chrome dev 73.0.3679.0
操作系统 (operating system): Gentoo Linux 4.14.83
问题描述 (problem description): Lists occasionally get duplicated when opening the extension page.
实际行为 (actual behavior): Sometimes opening the extension page duplicates my tab lists. I've noticed it happens especially when I store one tab while there is already a list stored. Usually reloading the page fixes the issue, but if I drag the one tab into the list to combine the lists then reload, I get three lists.

The new, combined list.
A list of the one tab I stored.
The old list without that single tab.

期望行为 (expected behavior): Tab lists only get displayed once when pulled from storage.
重现步骤 (reproduce step): No need for sync. Not exactly sure how to reproduce reliably as it is intermittent. Create a list then open the extension until it duplicates. See that it turns back to one list after a reload.

Hi. I cannot reproduce it currently. But I'll notice it in future. The new version (1.4.x) was published. Could you update your extension to the latest version and try again? Hope you can provide further information if it still exists. Thank you.

Haven't been able to repro in the new version, will reopen if I encounter the bug.


Add Options For File Saving

Added 3 new options configuring how files should be saved on the disk. Also added to setup script.

Date Folder Structure
Save images within current Year and Month folder (used same default as ShareX with year-month formatting)

Customise File Destination
Change the location of uploads from "uploads/" to anything.
Perhaps an additional feature could be error checking to ensure it's a valid path?

Save As Original File Name
Currently files get saved with randomly generated file name and no file extension. Adds option to save with same name and file extension as uploaded.

Feel free to change the descriptions in the setup script, I tried my best to describe setting but there's room for improvement.
Thanks for the software, let me know if you have any questions.

Whoops GitHub desktop accidentally pushed some edits from my local repo to this pr, ignore the rest

Removed the accidental push for private images that I didn't finish implementing, this is strictly the File Saving changes now.

Thank you!!


Include all active networks in config

It would be good to include all active networks which are compatible with the Ark desktops.
I think we should have: Ark Mainnet, Ark Devnet, Blockpool, Kapu.

This issue will be addressed on the new version of the desktop wallet


If / And Logic

Hi!
I am using Tally Arbiter with Atem 2 M/E. In many situations I'm using ME/2 as bus feeding one of windows in Atem's SuperSource.
What I would like to acchieve is monitoring of ME/2 only IF Supersource is on PGM in ME/1.
I think that is not possible right now using Source Linking, am I right?

I think this will be possible once I add supersource monitoring. I have some thoughts on how that could be done, similar to how I recently implemented Carbonite-specific support.

I don't know if it would be related but I only have a Television Studio HD and I'd love to be able to trigger something because PGM == x &&  PVW == y.  (Also with NOTs)
Use case: if my PGM is on Cam1 I want to tell my Stream Deck to show the presets for cam 2, and vice-versa.
If my PGM is on slides I want to show the presets for whichever camera is on PVW.  That requires more logic than exists now

What if you added a "On Preview" webhook for each camera that sends the command to Companion to make the change you want? Then any time you put that particular Camera up in Preview, the deck will change to that page.

That's a good question and I had that idea too, but the operator does have
access to the ATEM buttons.
When PVW = PGM = x, the operator could still move the on-air camera.
On Sat, Mar 27, 2021 at 12:45 AM Joseph Adams @.***>
wrote:

What if you added a "On Preview" webhook for each camera that sends the
command to Companion to make the change you want? Then any time you put
that particular Camera up in Preview, the deck will change to that page.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/josephdadams/TallyArbiter/issues/65#issuecomment-808651623,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATEBQID5VNWOKCP6WHWSSSDTFVPFFANCNFSM4YS3PIAA
.


Remove v2 dependency on v1 for host processes

When activating host processes (ie: processes in the uvm namespace) the
v2 code still used the old v1 execution. This change removes that
dependency in preparation on removing v1 entirely.
Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

@katiewasnothere - Part 1 of removing v1 to make this change more clear.

@katiewasnothere - Ok verified this works as expected.


Sort not working, don't quite understand the error message

Hi there!
I'm getting this error when I try to sort on a column, not quite sure what it means
The type of sort field and order should be both with String or Array

I have provided a sortFunc

@cheapsteak, could you please show me your code and did you use multiple sort?

Yup! Here you go
<BootstrapTable
  data={this.reports}
  keyField="id"
>
  <TableHeaderColumn
    dataSort
    dataFormat={(cell, row) => row.blubrry.periodDownloads}
    sortFunc={(a, b, order, sortField, path) => (_.get(a, path) >= _.get(b, path) ? 1 : -1) * (order === 'asc' ? 1 : -1)}
    sortFuncExtraData={'blubbry.periodDownloads'}
  >Blubrry Weekly Downloads</TableHeaderColumn>

</BootstrapTable>

@cheapsteak, I guess because you dont assign a dataField on  TableHeaderColumn, could you help me to add a dataField as a string value on it?

That works! I assigned an empty string to dataField and sorting is now working. Thanks!

Sorry nvm, the sort order seems inconsistent, not sorting as expected :\

the sort order seems inconsistent

sorry, is revert? or what?

Sorry about that, here's a pen!
http://codepen.io/cheapsteak/pen/MJmbzV
Behaviour is kind of odd, it only sorts after clicking the table header twice, and the sort indicator arrows don't quite match with the sort order

ok, that's a great example 👍

Hi @cheapsteak
Your codepen isn't sorting because you misspelled 'blubrry' in line 26

Oh my god.
So sorry about that X|

@cheapsteak No worries, it happens to all of us :P
As for your initial error:
The type of sort field and order should be both with String or Array
If you specify an initial sort order in the options then you have to specify both sortName and sortOrder. If not using multiColumnSort then you can specify them as string:
<BootstrapTable options={{ sortName: 'periodDownloads', sortOrder: 'asc' }}>
...

If using multiColumnSort then you can specify more than one column to sort on and BOTH sortName and sortOrder should be arrays:
<BootstrapTable multiColumnSort={2} options={{ sortName: ['periodDownloads', 'allTimeDownloads'], sortOrder: ['asc', 'desc'] }}>
...

This will sort primarily on allTimeDownloads and then on periodDownloads.
Hope that helps


Ignore leading spaces when sorting

I try to sort this code with selection as shown below
   	>	$bundles[] = new DebugBundle();
   		$bundles[] = new SensioDistributionBundle();
   		$bundles[] = new WebProfilerBundle();<

(selection shown as >selected text<)
Expected:
   		$bundles[] = new WebProfilerBundle();
   		$bundles[] = new SensioDistributionBundle();
   		$bundles[] = new DebugBundle();

Leading whitespace is ignored

Actual:
   		$bundles[] = new DebugBundle(); <------ PROBLEM
   		$bundles[] = new WebProfilerBundle();
   		$bundles[] = new SensioDistributionBundle();

Leading whitespace is taken into account.

even if it was ignored, the result would be
   			$bundles[] = new WebProfilerBundle();
   		$bundles[] = new SensioDistributionBundle();
	$bundles[] = new DebugBundle();

how about using multicaret with empty selection:

I would just need to implement selection of the whole line when nothing is selected - which should have been there from the beginning anyway.... right now only Sort by subselection does that.

imho if you select something, you would expect the operation to be done on the exact selection - or if you select nothing, it will select lines with carets - just like ctrl+c does.
But you are right that ignoring whitespaces (so that you get the right order) + preserving spaces (so that it does not break formatting) would be nice + preserving trailing commas (as someone else wants)  should cover everything.... Even this:

This seems like a meaningful use to partial-line selection, that should not expand, you are right.

ignoring whitespaces (so that you get the right order) + preserving spaces (so that it does not break formatting) would be nice + preserving trailing commas (as someone else wants) should cover everything

Exactly. You actually explained my thoughts better than I did, thanks.

You can try it https://github.com/krasa/StringManipulation/releases/download/<IP_ADDRESS>.0/StringManipulation.jar

Done and released.

I forgot to thank you :) I'm using it regularly and it works great.


Inline windows_result::Error::from_win32, windows_result::Error::from_hresult and windows_result::HRESULT::from_win32.

Suggestion
I noticed that regardless of optimization level, unless link time optimization is enabled, the small functions  windows_result::Error::from_win32, windows_result::Error::from_hresult and windows_result::HRESULT::from_win32 are never inlined.
Since they're all very small, it makes sense to inline them to avoid the additional overhead of a function call. Particularly this matters for Error::from_win32 which is used very frequently in code that uses the windows crate.

Any reason you're not using LTO for this? Note that always inlining these can also lead to code bloat.

I don't think we can even guarantee inlining occurs, another indication that LTO is the better path.


Again false positive in a url

Again the value
NOT URL   http://a.b--c.de/
NOT URL  http://www.foo.bar./
Return True

Hi @gil2gm,
I was facing the same issues with valid-url but also validator so I decided to build a module as reliable as possible strictly based on RFC-3986: https://github.com/adrienv1520/node-uri
The main features of this project are:

parse any URI (URNs, URLs, URIs with IDNs support, etc.);
get the safe Punycode ASCII or Unicode serialization of a domain;
check an URI, HTTP/HTTPS/Sitemap URL, IP, domain is valid with clear checking errors;
encode/decode an URI, HTTP/HTTPS/Sitemap URL.

I hope it could help you.


Add configurable option to bind vertex data buffers after other vertex-stage uniform and structured buffers in Metal backend

Matches the behaviour change in https://github.com/mellinoe/ShaderGen/pull/36.
BindMetalVertexBuffersAfterOtherBuffers is obviously just a placeholder name - do you have suggestions for a better name?

This looks roughly like what I was thinking. I need to think over how this will interact with some other stuff cleanly. I think this option will need to be configurable on a per-Pipeline basis. Otherwise, it will be too difficult to provide re-usable components. For example, Veldrid.ImGui is supposed to be usable from any GraphicsDevice, regardless of which binding model it is using. So, it should be able to specify the legacy binding model when it creates its Pipeline.
As for naming, I'm thinking something like:
public enum ResourceBindingModel
{
    Default = 0,
    Improved = 1,
}

If a Pipeline doesn't specify the binding model, then it defaults to the GraphicsDevice's default, as you've done.
Ultimately, this whole enum (and support for the legacy binding model) should be removed at the next major version bump, but that's something I wasn't planning on doing for a long time. This will definitely be a positive change, but the transition will be a bit more painful than I was hoping 😞.

Sorry I wasn't as clear as I could have been -- it's a bit late here 😴 .
I actually had thought that the GraphicsDevice option would remain as the "default" if it wasn't overridden in the pipeline description. This would mean that the GraphicsPipelineDescription field would actually be a ResourceBindingModel? (nullable). If unspecified/null, then the GraphicsDevice's default is chosen. There should be another constructor for GraphicsPipelineDescription which takes a ResourceBindingModel (non-nullable).
I'm still mulling this over, but that was my original idea. I'll think about this some more tomorrow and see if what I wrote above makes sense.
Aside: ComputePipelineDescription will eventually need this option too, but only when I get around to implementing the improved OpenGL binding model. For Metal it doesn't matter.

To help with the mulling, I've changed it to (hopefully) match what you've described.

@mellinoe

but that's something I wasn't planning on doing for a long time.

Well, if you will make major version bump, please clean public API from unused params/functions (which I partialy tried to do in some of my PR that wasn't accepted), because their presence is confusing.

@tgjones Looks good to me. I'll make a small followup commit (to swap the parameter order).
I'm going to continue thinking about this before 4.2.0 goes stable, but I think this is a decent compromise to make a much-needed improvement while maintaining compatibility.

Thank you! Please could you also merge https://github.com/mellinoe/ShaderGen/pull/36 (when you have time)?

@tgjones Merged that as well.


[TE] Rootcause frontend heatmap scrolling

moving sizing logic to rootcause-heatmap

support two-sided rollup

left-right scrolling per row

still some graphical glitches, but good enough for a prototype


[11.0][PORT] stock_picking_barcode

@yelizariev Can you check the changes?

Js files don't have original copyright

There was no Odoo S.A. in 2004
You must use copyright as in original module


write tests and fixed some bugs.

DONT ADD NEW THINGS TO THIS BRANCH AS ITS DIFFICULT ALREADY READING ALL.
SPLIT TO MORE BRANCHES NEXT TIME


The :example_group key in an example group's metadata hash is deprecated

Using this with RSpec 3 gives a deprecation warning:
/home/ubuntu/.rvm/gems/ruby-2.2.0@global/gems/rspec-core-3.1.7/lib/rspec/core/formatters/deprecation_formatter.rb:186:in `puts': The :example_group key in an example group's metadata hash is deprecated. Use the example group's hash directly for the computed keys and :parent_example_group to access the parent example group metadata instead. Called from /home/ubuntu/amitree/vendor/bundle/ruby/2.2.0/bundler/gems/rspec_junit_formatter-7b098c8ab2ac/lib/rspec_junit_formatter/rspec3.rb:48:in `yield'. (RSpec::Core::DeprecationError)

:+1:

:+1:


How to handle double mappings from Cim Switch Code to IEC Equipment Type

As an engineer
I want to map Cim Switch Codes to IEC Equipment Type
So I can generate 61850 single line diagrams without manual editing
Background:
Mapping is be based on IEC/TS 62361-102, chapter 5.6.2, but some CIM Codes can be mapped on multiple IEC Codes.
For instance
CAB("ACLineSegment", "DCLineSegment"),
GIL("ACLineSegment", "DCLineSegment"),
IFL("ACLineSegment", "DCLineSegment", "EquivalentBranch"),
LIN("ACLineSegment", "DCLineSegment"),
There must be decided how to handle this.

ACLineSegment is mostly used, however this needs more investigation.

Whether a AClinesegement is Gas insulated line (GIL), Power Cable (CAB), poweroverheadline (LIN) depends on the (CIM) Asset related to PSR (AClinesegement). This information is not available in the CGMES profile and the LN IFL is deprecated (Infeedline).
For now, the AClinesegement can be converted to CAB since this is mostly used in Dutch DSO grids.  This assumption needs to be clear in the documentation.
Potential solutions for later:
Make an CIM extension to select the type of AClinesegment
Select the type of extension during the conversion.
In case of a DC line segment, the SCL voltage level:nomFreq must be set to 0.

@dlabordus does this address your decision request?


make launch C++17 error windows

 LocalizationStage.cpp
  class template optional is only available with C++17 or later.
and after a lot of errors,

i'm using VS 2017

I have downloaded C++/WinRT but it doesn't help

Hi,
Sorry for the issue, one of the variables is declared as uint instead of uint64_t. It's on the line of the error, changing that should solve your problem.

Just a quick note to say that I also ran into this same issue (uint instead of specific width integer) with LocalizationStage.cpp, and in my case changing all instances of uint to uint32_t in LocalizationStage.cpp fixed the problem.
I also ran into a similar issue with ProfilesParser.cpp. Here I changed all variable declarations of uint to uint32_t, and this fixed the issue. Note that in ProfilesParser.cpp, I did not change lines of the form:
node_road.attribute("id").as_uint();
These were left as-is, since there is no as_uint32_t() equivalent.
I am compiling on Windows 10, using Visual Studio 2017.

I decide to do linux build, so can`t check the recomendations now


Login phase client part

-When a user is signed up correctly, you should not be able to go in /firstAccess or patient/selectDoctor
-submit in /patient/selectDoctor goes to /firstAccess because user state is not updated. (user.userType == "unknown" after /firstAccess)

https://dmitripavlutin.com/react-useeffect-infinite-loop/
2.1 Avoid objects as dependencies
The best way to solve the problem of an infinite loop created by circular new objects creation is… to avoid using references to objects in the dependencies argument of useEffect():
let count = 0;

useEffect(() => {
  // some logic
}, [count]); // Good!
let myObject = {
  prop: 'Value'
};

useEffect(() => {
  // some logic
}, [myObject]); // Not good!

useEffect(() => {
  // some logic
}, [myObject.prop]); // Good!
Fixing the infinite loop of <CountSecrets> component requires changing the dependency from useEffect(..., [secret]) to useEffect(..., [secret.value]).

Calling the side-effect callback when solely secret.value changes is enough. Here’s the fixed version of the component:

import { useEffect, useState } from "react";

function CountSecrets() {
  const [secret, setSecret] = useState({ value: "", countSecrets: 0 });

  useEffect(() => {
    if (secret.value === 'secret') {
      setSecret(s => ({...s, countSecrets: s.countSecrets + 1}));
    }
  }, [secret.value]);

  const onChange = ({ target }) => {
    setSecret(s => ({ ...s, value: target.value }));
  };

  return (

      <input type="text" value={secret.value} onChange={onChange} />

Number of secrets: {secret.countSecrets}

  );
}

Open the fixed demo. Type some words into the input… and as soon as you enter the special word 'secret' the secrets counter increments. No infinite loop is created.


No airport name locates it on lat/lon 0

Description: On lat/lon 0 there are many airports one on top of the other
Steps to reproduce: Move the map to the African coast on lat/lon 0 there are some airports that shouldn't be there.

This might be an issue with the aviation model or the data.

I've added a function that filters the airports that have coordinates value of 0, this prevents the airports from showing on map, but it doesn't fix the issue.
The issue is coming from the aviation-scrapper module.

Did you see my ticket on aviation data?
The scrapper catches all the pages but with different airport names. Isn't the aviation data where things are normalized and grouped?
Bermi
Sent from my phone

On 27 Oct 2016, at 12:16, Cristóbal Gómez<EMAIL_ADDRESS>wrote:
I've added a function that filters the airports that have coordinates value of 0, this prevents the airports from showing on map, but it doesn't fix the issue.
The issue is coming from the aviation-scrapper module.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes, I saw it, you are right, aviation-json is where things are normalized and grouped, but the problem when the coordinates are not available,  might be two options:

the coordinates are not available on Wikipedia (I doubt it)
the scrapper is missing the coordinates.

So I think the problem for airports with 0,0 coordinates is on the aviation-scrapper, not on the aviation-json package.

Doesn't the wikipedia API return the coordinates as well? Probably only the
redirected pages are missing the location location which is something
tracked on https://github.com/cristobal-io/aviation-front-end/issues/8
On Thu, Oct 27, 2016 at 6:15 PM, Cristóbal Gómez<EMAIL_ADDRESS>wrote:

Yes, I saw it, you are right, aviation-json is where things are normalized
and grouped, but the problem when the coordinates are not available, might
be two options:

the coordinates are not available on Wikipedia (I doubt it)
the scrapper is missing the coordinates.

So I think the problem for airports with 0,0 coordinates is on the
aviation-scrapper, not on the aviation-json package.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cristobal-io/aviation-front-end/issues/18#issuecomment-256693401,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABpwTCw4tbmxH12LQ4Thei5UulC_uK2ks5q4M4SgaJpZM4KX2Of
.


Base-16 is now avaiable.

Tweaking each individual icon is a pain, so instead, i decided to apply base-16 to color all icons, and allowed users to simply override a global map called Colors. Hope this saves some hastle!

No prob :+1:

As a base16 user I like the idea, however agree with @kyazdani42

Let's close this, it's a bit old and it would change the display of most user configurations too drastically.


Table layout causes problems for screen magnifier users

Example:

The wide spacing between the end of the data in the first column and the start of the second column means that anyone using magnification at reasonably high levels has to traverse across a lot of white space. This makes it difficult to associate the data together. Tables shouldn't need to expand to the full width and should have minimal spacing between columns.
Believe the code is https://github.com/alphagov/static/blob/f27d6aa124bfe22cc87f960a435311c1e2bdf4a8/app/assets/stylesheets/govuk-component/govspeak/_tables.scss - presumably     width: $full-width; is what makes this happen?

Putting the two columns closer together will also make it easier for users to scan the information.


Maven build (and publish as OSGi artifact)

Moved from https://code.google.com/a/apache-extras.org/p/beanshell/issues/detail?id=12
Reported by<EMAIL_ADDRESS>Jan 8, 2015
An attempt should be made at moving the build to Maven instead of ant. I had trouble getting the whole code to rebuild as several automodified files live within src/.
Another advantage we can easily get with Maven is to ensure the bsh.jar can also be an OSGi bundle (thus negating the need for repackaging as in http://ebr.springsource.com/repository/app/bundle/version/detail?name=com.springsource.bsh&version=2.0.0.b4&searchType=bundlesByName&searchQuery=bsh)
I have added the pom.xml I used to deploy 2.0b5 to bintray - but it's currently incomplete for the build, as it needs to include things like:

Specify src and tests folder (deviates from Maven standard of src/main/java, src/test/java)
generate javadoc and sources jar
Use [http://semver.org/ semantic versioning] number, e.g. 2.1.0
execute jjtree and javacc (pretty sure there must be a Maven plugin for this, but if not there's an ant-command plugin)
Move generated files out of src

Here's an example of how we use javacc from Maven in Apache Taverna:
https://github.com/apache/incubator-taverna-workbench/blob/master/taverna-graph-model/pom.xml#L32
https://github.com/apache/incubator-taverna-workbench/tree/master/taverna-graph-model/src/main/jjtree

I did most of this, but bailed out on jjtree and javacc as there seems to be manual changes both to the bsh.jj file and to the resulting *.java files.  I think for now the safest is to leave these half-generated half-edited *.java files in src/main/java.
See the https://github.com/beanshell/beanshell/tree/maven branch to have a look. Compile with
mvn clean install -DskipTests

(many of the unit tests fail, just like in Ant)
The biggest changes:

src/main/java for all Beanshell source code

Including former asm/, bsf/ and servlet/

src/test/java and src/test/resources for tests
No more lib/ - use (optional) <dependency> instead  (This solves #5)
src/main/javacc and src/main/jjtree

javacc-maven-plugin in pom.xml, disabled due to manual edits

Given #15 I think the maven branch is ready for prime time.. views?
I think we can leave thje javacc disabled with the generated code in src/main/java - unless someone has time to go through the differences and see if they are important.


Support lazy loading of relations

This issue was originally created by @omarbelkhodja here, before being automatically moved:
https://github.com/angel-dart-archive/orm/issues/99

Let's assume that we have an entity like the following :
@serializable
@orm
abstract class _Author extends Model {
  String get name;

  @HasMany()
  List<_Book> books;
}

When a query is executed to in order to search for a specific instance of Author, all the books related to the  Author are also fetched from the database. This is too expensive and time consuming, if for example, I want to know the name of the Author, and nothing else.
In some framework, like Hibernate on Java, there is a parameter in the annotation, that allows selecting whether the related books are fetched immediately, when the Author instance is found (EAGER), or if the related books are fetched, when the property is read (Lazy).
We might then have the following
@serializable
@orm
abstract class _Author extends Model {
  String get name;

  @HasMany(fetch:LAZY)
  List<_Book> books;
}

@thosakwe commented:
I think this would be nice to have. My question is, if fetching is lazy, how will the user indicate when to fetch the data?
Possibly:
var query = AuthorQuery(fetchBooks: true);

But then, this raises the question: why lazy-fetch things, when you can instead just manually query them when they are needed? I want to be sure to only codegen features that specifically need to be generated, as angel_orm_generator is already complex enough, and I want to keep it as maintainable as possible for the long-term.
var author = await authorQuery.get(executor);
var bookQuery = BookQuery()..where.authorId.equals(author.idAsInt);
var books = await bookQuery.get(executor); // Fetch the books when they are needed.

@omarbelkhodja commented:
There is an interesting article about how it works in hibernates you can read here:
https://www.baeldung.com/hibernate-lazy-eager-loading
Your proposal
var query = AuthorQuery(fetchBooks: true);

would solve the problem of not loading the data if not required. But the problem is that you won't be able to query them simple by calling a getter, as in the hibernates approach.

@thosakwe commented:

With the lazy initialization approach, orderDetailSet will get initialized only when it is explicitly called by using a getter or some other method

A middle-of-the-road option is maybe to add a Future<List<Book>> fetchBooks(QueryExecutor executor) method, that simply generates a BookQuery and returns its value.
Also, for what it's worth, at least based on the Hibernate example, I don't think there is much meaningful difference between "eager" and "lazy." To me, their definition of "lazy" sounds like "eager, just at another time."
One other option, though, could be a Future<void> fetchBooks(QueryExecutor executor), where the field books is set to the result of a BookQuery. This won't add considerable complexity to the codegen.