Poor performance with AMD GPU/Driver on Linux

Describe the bug
Using the 117HD plugin with an AMD RX6800, I'm only able to max out FPS around 60 on low settings with big dips into the 20's in areas like fossil island during birdhouse runs. I recently upgraded from a GTX2060 which had no issues hitting 144 FPS stable on higher settings with occasional dips into the 110-120 fps range doing the same activities. My best guess is that there is a driver issue causing this drop in performance.
Expected behavior
With a big gpu upgrade, i should be able to easily meet or exceed the stable 144fps mark that my old graphics card was able to handle with equivalent or better settings.
Environment (please complete the following information):

OS: Nobara Linux 36 (Fedora) KDE Plasma
Kernel 5.18.13-201.fsync.fc36.x86_64
DE: Plasma 5.25.3
CPU: Intel i7-9700k @ 4.900GHz
GPU: AMD ATI Radeon RX 6800
Driver: Mesa 22.2.0-devel
Memory: 32GB DDR4 @ 3200
RuneLite version: x64 AppImage downloaded from runelite.net

Additional context
When moving from the nvidia gpu to the amd gpu, I did a fresh install of my distro. No other hardware changes have been made.
When using the gpu plugin on runelite, my fps is stable at 144fps using the AMD gpu.

What resolution is this at, 1080p? You seem to be getting much worse performance than I got on my old PC with a GTX 1070 and i7 5960x (I got like, 70 FPS max on highest settings). My current PC has a RTX 3070 Ti with a R9 5900X and I'm only getting about 90-110 FPS at 1080p highest settings. All of this on Ubuntu 22.04, of course.

Supposedly everything was the same, except for the GPU upgrade, which is really weird.

Supposedly everything was the same, except for the GPU upgrade, which is really weird.

Different driver, that's one of the most important factors in performance. Some of them give severalfold better or worse performance either on the CPU or (rarely, but seems to be the case with linux) the GPU.

@GotGuffz
Are you still having issues with the latest release?

@GotGuffz one guy in RuneLite's Discord supposedly found that AMD proprietary drivers performed a lot better with RuneLite's GPU plugin. Could you check if it helps for you as well? All he supposedly did was install those drivers and launch RuneLite with progl.

OpenAMD drivers with a Vega 56 gave me 60fps with everything maxed except draw distance (42), Shadows (4096) and MSAA (4x)
Will do a full comparison later

OS: Ubuntu 22.04
Driver: Mesa-22.0.5
GPU: AMD Vega 56
Running with settings:

<title></title>
<meta name="generator" content="LibreOffice <IP_ADDRESS> (Linux)"/>
<style type="text/css">
	body,div,table,thead,tbody,tfoot,tr,th,td,p { font-family:"Liberation Sans"; font-size:x-small }
	a.comment-indicator:hover + comment { background:#ffd; position:absolute; display:block; border:1px solid black; padding:0.5em;  }
	a.comment-indicator { background:red; display:inline-block; border:1px solid black; width:0.5em; height:0.5em;  }
	comment { display:none;  }
</style>

Setting

High

Draw Distance

60

AA

4x

UI Scaling

TRUE

AF

16

Dynamic Lights

50

Projectile Lights

TRUE

NPC Lights

TRUE

Atmos Lights

TRUE

Shadows

TRUE

Shadow Quality

4096

Shadow Distance

70

Expand Shadow Draw

TRUE

Texture Resolution

256

Unfortunately i cannot test the AMD Pro drivers as they appear to be broken
https://community.amd.com/t5/drivers-software/ubuntu-22-04-amp-driver-amdgpu-install-22-10-2-50102-1-all-deb/m-p/534262

I did end up testing the broken AMD drivers; currently unstable on Ubuntu 22.04 until AMD fixes their script (or i fix it i guess..)
In my testing there was nearly a 30% -50% performance jump.
Can confirm we perform poorly only open Mesa and better on AMD proprietary drivers; How much of that is us versus driver optimization is beyond my knowledge. But i'd consider this issue closed.

Can you check whether this is still an issue with Mesa 23? It reportedly may have fixed the issue: https://github.com/runelite/runelite/issues/16354#issuecomment-1509759377


[ao_migration] torchvision: torch.quantization -> torch.ao.quantization

Summary:
This changes the imports in the caffe2/torch/ao/nn to include the new import locations.
codemod -d pytorch/vision --extensions py 'torch.quantization' 'torch.ao.quantization'

Differential Revision: D31302368

This is just an export of D31302368 to see what breaks


API version

Can you change the api version from v0 to v1?

I gave @zooba control of the PIP package (https://pypi.python.org/pypi/projectoxford/0.2.0) and he has been publishing from this repo: https://github.com/zooba/projectoxford but it looks like there is still not support for any of the image-based APIs. @irjudson do you know where this landed? Should I deprecate this repo or is it still the primary source for using the oxford image APIs from python?

I'm inclined to give it back, now that it's been renamed to Cortana Intelligence Suite, and you seem to have more willing contributors than I do. Interested?

I can't tell who you're talking to Steve, but I'd be happy to take
ownership and drive the python client forward. I've got time and interest,
what's your plan scott?
-Ivan
Ivan R. Judson
irjudson.org
(425) 679-1375
On Thu, Jun 16, 2016 at 4:42 PM, Steve Dower<EMAIL_ADDRESS>wrote:

I'm inclined to give it back, now that it's been renamed to Cortana
Intelligence Suite, and you seem to have more willing contributors than I
do. Interested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/southwood/project-oxford-python/issues/7#issuecomment-226644902,
or mute the thread
https://github.com/notifications/unsubscribe/AAAr00oqujD0BE6qskRRunx4ROcITGQHks5qMd-AgaJpZM4IpGDk
.

I'm happy to hand off ownership. I'm no longer with Microsoft and unfortunately haven't been working with python as much lately.
Given the rename, I think the ideal situation would be to have one python package for each API suite provided by Cortana Intelligence (formerly project oxford). For example cortana-intel-vision, cortana-intel-speech, cortana-intel-language, cortana-intel-knowledge, and cortana-intel-search. Currently this repo contains a client for vision APIs and @zooba's repo contains a client for speech and a client for the vision/emotion API with a dependency on open CV.
@lightfrenzy, do you have any input on this? Is there any interest from your team around owning or maintaining the open-source python clients for Cortana Intelligence?


Apply current shapekey mix to basis can sometimes cause a key to be active on every key.

Related? https://github.com/absolute-quantum/cats-blender-plugin/pull/478


Improved test

Current coverage is 97.50% (diff: 100%)

Merging #1842 into master will increase coverage by 0.01%

@@             master      #1842   diff @@
==========================================
  Files            87         87
  Lines         11321      11321
  Methods           0          0
  Messages          0          0
  Branches       1875       1875
==========================================
+ Hits          11036      11038     +2
+ Misses          171        169     -2
  Partials        114        114

Powered by Codecov. Last update 2815851...06c311d


Add additional MIT license metadata

My motivation for this pull is to ensure that the attribution requirements are met for the MIT license, and to make it clear in npm that this code is licensed MIT, as currently npmjs.org displays none as the license type which is not ideal.
Making it clear that this package is licensed MIT is important, as it allows me to avoid questions from clients regarding licensing, as they can see at a glance what the license for each package is without digging into the source code.

Thanks :)


Updating EnvironmentVariableCollection before remote resolver completes doesn't take effect

In an extension with a remote resolver, call environmentVariableCollection.replace('FOO', 'hello') before the resolver returns (I can help setup a repro if needed)
Connect to a remote using that resolver
Open a terminal and press keys in it before the window connects fully
I expect to see the warning icon telling me to relaunch, or for the process to already have FOO=hello, neither happens

If I put calling replace behind a setTimeout, it works as expected.
This is pretty niche, probably not high priority, but I'm trying to avoid these setTimeout hacks in the SSH resolver.


textDocument/codeLens is not supported issues

Error detected while processing BufEnter Autocommands for "<buffer=1>":
method textDocument/codeLens is not supported by any of the servers registered for the current buffer

which gopls version you are using?
By default the codelens is enabled. If your gopls does not support codelens, please set
  lsp_codelens = false,

Hi, I do too have the same issue here.
neovim's version is v0.8.0-dev+40-g843d9223a, and gopls' version is v0.8.3 (supports codelens).
Is there any other configuration for enabling codelens?

you can set lsp_codelens = false to disable codelens.
But it should be enable by default in latest gopls.

Same here on v0.7.0. I've had to disable codelens for now.

For me, reinstalling go.nvim solved this issue.

Please enable lsp_cfg by setting lsp_cfg=true
And it will enable the codelens here:
https://github.com/ray-x/go.nvim/blob/a8000badf6d55b2f90af597da6ca589ac23130e3/lua/go/gopls.lua#L193-L198

@ray-x in my case this is already enabled. My config looks like
  local ok, path =  pcall(require, 'nvim-lsp-installer.path')
  local gopls_cmd
  if ok then
    local install_root_dir = path.concat { vim.fn.stdpath 'data', 'lsp_servers' }
    gopls_cmd = { install_root_dir .. '/go/gopls' }
  end
  require('go').setup {
    gopls_cmd = gopls_cmd,
    max_line_len = 100,
    goimport = 'gopls',
    icons = false,
    lsp_cfg = {
      codelenses = {
        generate = true,
        gc_details = false,
        test = true,
        tidy = true,
      },
      analyses = {
        unusedparams = true,
      },
    },
    lsp_gofumpt = true,
    lsp_keymaps = false,
    lsp_on_attach = as.lsp.on_attach,
    lsp_diag_virtual_text = false,
    dap_debug_keymap = false,
    textobjects = false,
  }

To be clear, the code lenses do work I can see them in each file. The problem is that it is erroring the first time I open a go file. Which makes me think that something is running too early since the error is immediate, but I work in a monorepo, and it takes like 3-4secs for the lsp to be setup. So I think it tries to add codelenses too early. I think they should only be refreshed/the autocmd created when on attach is first run

can anyone confirm the issue fixed?

I'm not seeing the issue anymore 👍🏾

I'm also seeing this error each time I save a Go file after I have also opened some other file type (for instance Markdown) that uses some other language server (in my case typos-lsp).
My guess is that go.nvim is trying to trigger the code lense for typos-lsp as well even though it doesn't support it.


hub_connection.h: Cannot open source file "pplx\pplxtasks.h" and "cpprest\json.h"

I'm trying to run [this code] in Visual Studio 2015, but it seems like some libraries are missing.
Packages in my project (packages.config):
<?xml version="1.0" encoding="utf-8"?>
<packages>
  <package id="cpprestsdk.v120.windesktop.msvcstl.dyn.rt-dyn" version="2.5.0" targetFramework="native" />
  <package id="Microsoft.AspNet.SignalR.Client.Cpp.v120.WinDesktop" version="1.0.0-alpha1" targetFramework="native" />
</packages>

[Other errors]
My project is simple windows console app, the code is exactly the same as in link I pasted here.
Is this some bug, or I'm doing something wrong?

The package that is currently on NuGet is only for VS2013. You can build one for VS2015 yourself from sources. In the VS2015 command prompt and run msbuild build\build.msbuild /t:CreatePackage /p:Configuration=Release /p:Platform=x64.
We are planning to put the VS2015 package on NuGet soon.

@moozzyk can you tell me what should I do after building this package? How to include it in project? It's probably obvious, but I'm not familar with Visual Studio yet.

The easiest way is probably to create a local NuGet feed.

Create a folder and copy the package to this folder
In Visual Studio go to "Tools -> Options" and then find "NuGet Package Manager" on the left, expand it and go to Package Sources.
add new feed by providing a name and the path to the folder you created

Once you have created open your project in VS and:

right click on the References and select Manage NuGet packages
select the feed you created in the Package source drop down
you should see the package in package list
select the package and on the left and click Install on the right

When you install the package it will update your project file to add a path to include and lib files and also to copy the dll along with your project to the target folder.

@moozzyk I'm really sorry that I keep this thread open, but I've come back to it today and can't make it finally done.
NuGet doesn't see my package no matter what path I provide. I originally thought that built package is stored in "[path_to_project]\bin\Win32\Release\dll", but NuGet stubbornly tells that there is no such a thing there. I've even set the path to the folder with entire project, but it also tells that there is no package there.
I hope that I'm doing it in corrently: [here is how]
So: how this "NuGet feed" should look like to be recognized by Nuget Package Manager?
BTW: isn't it just a c++ code? Why it actually doesn't work in Visual Studio 2015?

No. Nuget packages are binplaced in the $\artifacts\build folder (search for Microsoft.AspNet.SignalR.Client.Cpp.v140.WinDesktop.1.0.0-alpha1.nupkg - this is your package). What I have on my box is a separate folder (like C:\LocalNuGetFeed) where I copy packages. This way it is very easy for me to tell what packages I have in my local feed. The rest of your settings look good to me. For reference this is how this looks on my box. (I used red boxes to mark things you need to pay attention to (although you seem to be using older tooling?))

BTW: isn't it just a c++ code? Why it actually doesn't work in Visual Studio 2015?

It is just a c++ code and this is the reason why it won't/might not work in Visual Studio 2015. The version for VS2013 is linked against CRT that shipped with VS2013. The version for Visual Studio 2015 is linked against CRT that shipped with VS2015. Using different CRTs in one applications may result in unexpected results. Take a look at this article to learn more. (From my experience: If you have not worked with CPP Rest SDK/async in C++ before you more than enough crashes to understand/fix that you don't even want to add random crashes from CRT that actually can't be fixed). Starting from VS2015 the approach to CRT has changed - instead of shipping a new version of CRT each time a VS ships there is now a new Universal CRT that can be used regardless of the VS version (>= VS2015) used. (Here are the details) So in the future you would be able to use dlls built in VS2015 in apps built in VS vNext.
Also one thing you may find useful if you are getting started with C++ async is a blog post series of mine on async programming with C++ Rest SDK

Thanks, works ;)

Świetnie!


update nuget client to latest version on performance workers

Updated the nuget clients on performance workers manually earlier, but I think this script should to be updated for future setups.
cc @nicolasnoble
cc @adelez

LGTM.


Handle gfal exceptions while listing baseDirEntry && Avoid extra stat operations during recursion

Fixes #11793
Status
not-tested
Description
As a natural consequence of the way how the operations are reordered for the purpose of the current bug fixing,  we also improve the MSUnmerged service in at least 3 different aspects:

Handle the File Not Found exception explicitly during the baseDirEntry listing and not relying on the stat operation to catch a missing file.
Avoid extra stat operations during recursive calls when we are already sure the entry point is a directory
Fix the missing timestamps in the REST interface for all RSE documents in MongoDB (this is an additional fix of a minor mistake I have made during the previous fix related to RSE timestamps, for which I decided to not create a whole separate issue).

Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None

Hi @vkuznet, thanks for this review. I have answered your comments inline. If you think anything else is worth attention please let me know.

Hi @amaltaro @vkuznet  with my latest  commit I actually found a way to reduce recursive operations during the RSE cleaning process even more. With the changes suggested here:  https://github.com/dmwm/WMCore/pull/1178 we are to delete the whole branch of empty directories under a specific entry in the site's namespace. But for some of the sites we are actually able to use WebDAV to try to remove the whole  branch even before emptying it from its contents. In my latest commit I am doing this already and now this (for the sites, which allow this operation to happen) is an extreme speedup. This one is a real game changer (again under the constraint: for the sites where it works).
I tested it with T2_IT_Legnaro: https://cmsweb.cern.ch/ms-unmerged/data/info?rse=T2_IT_Legnaro&detail=True  And  the results were really good. The runtime was reduced to just few min.
It also reduces the logs [1], because it does not dump the content of every dirretory deletion is not dumped into the logs if we  succeed to remove  it from the top (it will be the same for those who enter the recursive operations though).
[1]
Initial Run:
In [1]: msConfig['enableRealMode'] = True

In [2]: %page rse

In [3]: rse = msUnmerged.cleanRSE(rse)

2023-11-15 13:09:13,199:INFO:MSUnmerged:cleanRSE(): Trying to remove nonempty directory: /store/unmerged/Run3Summer22NanoAODv12/ZZto2L2Q_TuneCP5_13p6TeV_powheg-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_v5_ext1-v2
2023-11-15 13:09:13,400:WARNING:MSUnmerged:cleanRSE(): MISSING directory: /store/unmerged/Run3Summer22NanoAODv12/ZZto2L2Q_TuneCP5_13p6TeV_powheg-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_v5_ext1-v2
2023-11-15 13:09:13,400:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro  Success deleting directory: /store/unmerged/Run3Summer22NanoAODv12/ZZto2L2Q_TuneCP5_13p6TeV_powheg-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_v5_ext1-v2
2023-11-15 13:09:13,411:DEBUG:connectionpool:_make_request(): http://cms-rucio.cern.ch:80 "GET /rses/T2_IT_Legnaro/lfns2pfns?operation=delete&lfn=cms%3A%2Fstore%2Funmerged%2FRun3Summer22EENanoAODv12%2FWtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8%2FNANOAODSIM%2F130X_mcRun3_2022_realistic_postEE_v6-v2 HTTP/1.1" 200 351
2023-11-15 13:09:13,416:DEBUG:MSUnmerged:cleanRSE():
RSE: T2_IT_Legnaro
DELETING: /store/unmerged/Run3Summer22EENanoAODv12/WtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2.
PFN list with: 3 entries:
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run3Summer22EENanoAODv12/WtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2/2520001/15859d01-cf7c-48f2-95c4-cab8fdf4457b.root
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run3Summer22EENanoAODv12/WtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2/2520001/9d7121c8-87c4-4ac3-ac55-a25b9b78dca8.root
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run3Summer22EENanoAODv12/WtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2/2520001/aaf1b528-054c-4fb9-a799-35c4bb7a2598.root

2023-11-15 13:09:13,417:INFO:MSUnmerged:cleanRSE(): Trying to remove nonempty directory: /store/unmerged/Run3Summer22EENanoAODv12/WtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2
2023-11-15 13:09:13,618:WARNING:MSUnmerged:cleanRSE(): MISSING directory: /store/unmerged/Run3Summer22EENanoAODv12/WtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2
2023-11-15 13:09:13,618:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro  Success deleting directory: /store/unmerged/Run3Summer22EENanoAODv12/WtoLNu-4Jets_TuneCP5_13p6TeV_madgraphMLM-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2
2023-11-15 13:09:13,650:DEBUG:connectionpool:_make_request(): http://cms-rucio.cern.ch:80 "GET /rses/T2_IT_Legnaro/lfns2pfns?operation=delete&lfn=cms%3A%2Fstore%2Funmerged%2FRun2023B%2FParkingDoubleMuonLowMass4%2FMINIAOD%2F22Sep2023-v1 HTTP/1.1" 200 213
2023-11-15 13:09:13,655:DEBUG:MSUnmerged:cleanRSE():
RSE: T2_IT_Legnaro
DELETING: /store/unmerged/Run2023B/ParkingDoubleMuonLowMass4/MINIAOD/22Sep2023-v1.
PFN list with: 10 entries:
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run2023B/ParkingDoubleMuonLowMass4/MINIAOD/22Sep2023-v1/70000/1acfce59-f8a8-413b-82b6-c3309419ad37.root
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run2023B/ParkingDoubleMuonLowMass4/MINIAOD/22Sep2023-v1/70000/2d9aa9c0-768c-47d0-8e83-6eebb06fe85c.root
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run2023B/ParkingDoubleMuonLowMass4/MINIAOD/22Sep2023-v1/70000/48d049c2-23ad-4faf-b3d9-4658ef26da5c.root
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run2023B/ParkingDoubleMuonLowMass4/MINIAOD/22Sep2023-v1/70000/594bb846-0aa8-4ba4-b110-0020fc27beef.root
    ...
2023-11-15 13:09:18,429:INFO:MSUnmerged:cleanRSE(): Trying to remove nonempty directory: /store/unmerged/Run2023D/Muon0/NANOAOD/22Sep2023_v2-v1
2023-11-15 13:09:18,629:WARNING:MSUnmerged:cleanRSE(): MISSING directory: /store/unmerged/Run2023D/Muon0/NANOAOD/22Sep2023_v2-v1
2023-11-15 13:09:18,629:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro  Success deleting directory: /store/unmerged/Run2023D/Muon0/NANOAOD/22Sep2023_v2-v1
2023-11-15 13:09:18,641:DEBUG:connectionpool:_make_request(): http://cms-rucio.cern.ch:80 "GET /rses/T2_IT_Legnaro/lfns2pfns?operation=delete&lfn=cms%3A%2Fstore%2Funmerged%2FRun3Summer23DRPremix%2FQCD-4Jets_HT-200to400_TuneCP5_13p6TeV_madgraphMLM-pythia8%2FAODSIM%2F130X_mcRun3_2023_realistic_v14-v2 HTTP/1.1" 200 341
2023-11-15 13:09:18,646:DEBUG:MSUnmerged:cleanRSE():
RSE: T2_IT_Legnaro
DELETING: /store/unmerged/Run3Summer23DRPremix/QCD-4Jets_HT-200to400_TuneCP5_13p6TeV_madgraphMLM-pythia8/AODSIM/130X_mcRun3_2023_realistic_v14-v2.
PFN list with: 1 entries:
    davs://t2-xrdcms.lnl.infn.it:2880/pnfs/lnl.infn.it/data/cms/store/unmerged/Run3Summer23DRPremix/QCD-4Jets_HT-200to400_TuneCP5_13p6TeV_madgraphMLM-pythia8/AODSIM/130X_mcRun3_2023_realistic_v14-v2/25610003/d2ff9af0-06fb-4a96-badd-82347f04e72c.root

2023-11-15 13:09:18,646:INFO:MSUnmerged:cleanRSE(): Trying to remove nonempty directory: /store/unmerged/Run3Summer23DRPremix/QCD-4Jets_HT-200to400_TuneCP5_13p6TeV_madgraphMLM-pythia8/AODSIM/130X_mcRun3_2023_realistic_v14-v2
2023-11-15 13:09:18,845:WARNING:MSUnmerged:cleanRSE(): MISSING directory: /store/unmerged/Run3Summer23DRPremix/QCD-4Jets_HT-200to400_TuneCP5_13p6TeV_madgraphMLM-pythia8/AODSIM/130X_mcRun3_2023_realistic_v14-v2
2023-11-15 13:09:18,845:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro  Success deleting directory: /store/unmerged/Run3Summer23DRPremix/QCD-4Jets_HT-200to400_TuneCP5_13p6TeV_madgraphMLM-pythia8/AODSIM/130X_mcRun3_2023_realistic_v14-v2

Uploading the RSE contents to MongoDB:
In [6]: rse = msUnmerged.uploadRSEToMongoDB(rse)
2023-11-15 13:11:45,596:INFO:MSUnmerged:uploadRSEToMongoDB(): RSE: T2_IT_Legnaro Writing rse data to MongoDB.

Second attempt to clean it:
In [7]: rse = msUnmerged.cleanRSE(rse)

2023-11-15 13:14:39,553:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run3Summer23BPixDRPremix/TTto4Q_MT-171p5_TuneCP5_13p6TeV_powheg-pythia8/AODSIM/130X_mcRun3_2023_realistic_postBPix_v2-v3 already successfully deleted.
2023-11-15 13:14:39,554:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run3Summer22EEDRPremix/Zto2Nu-4Jets_HT-400to800_TuneCP5_13p6TeV_madgraphMLM-pythia8/AODSIM/124X_mcRun3_2022_realistic_postEE_v1-v2 already successfully deleted.
2023-11-15 13:14:39,554:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run3Summer22MiniAODv4/TTto4Q_TuneCP5Down_13p6TeV_powheg-pythia8/MINIAODSIM/130X_mcRun3_2022_realistic_v5-v2 already successfully deleted.
2023-11-15 13:14:39,554:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run3Summer23DRPremix/DYto2TautoMuTauh_M-50_TuneCP5_13p6TeV_madgraphMLM-pythia8/AODSIM/130X_mcRun3_2023_realistic_v14-v1 already successfully deleted.
2023-11-15 13:14:39,554:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run3Summer22EENanoAODv12/TWminusto2L2Nu_MT-171p5_TuneCP5_13p6TeV_powheg-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_postEE_v6-v2 already successfully deleted.
2023-11-15 13:14:39,554:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run2022G/ParkingDoubleMuonLowMass4/MINIAOD/22Sep2023-v1 already successfully deleted.
2023-11-15 13:14:39,554:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run2023C/ParkingDoubleMuonLowMass3/MINIAOD/22Sep2023_v1-v1 already successfully deleted.
2023-11-15 13:14:39,555:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run2022F/EGamma/NANOAOD/22Sep2023-v1 already successfully deleted.
2023-11-15 13:14:39,555:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run2022E/MinimumBias/NANOAOD/22Sep2023-v1 already successfully deleted.
2023-11-15 13:14:39,555:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/Run3Summer22NanoAODv12/TTto4Q_TuneCP5Down_13p6TeV_powheg-pythia8/NANOAODSIM/130X_mcRun3_2022_realistic_v5-v2 already successfully deleted.
2023-11-15 13:14:39,555:INFO:MSUnmerged:cleanRSE(): RSE: T2_IT_Legnaro, dir: /store/unmerged/RunIIAutumn18DRPremix/HiggsToLLTo4b_mH_600_mX_60_ctau_0p1_TuneCP5_13TeV_pythia8/AODSIM/102X_upgrade2018_realistic_v15-v2 already successfully deleted.
...

@amaltaro @vkuznet , please go ahead and take a look at the final version of this code, because otherwise I'll continue diving into details, but instead, I'd like to merge this one and deploy in production ASAP.

Thanks @amaltaro  I'll do it tomorrow morning

Hi @amaltaro, I am squashing and merging this PR at this stage. There are few more improvements for which I already have a prototype in my dev environment, like handling some more gfalError codes and implementing retries in some specific use cases. But for them we may need a little bit of feedback from gfal developers. So I'll create a separate WMCore issue for this and will proceed with what  I already have here which is already well tested.
FYI: @vkuznet


Adding asserts for hanging cases in ND tilize/untilize support

Ticket
Link to Github Issue
Problem description
Provide context for the problem.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Checklist

[ ] Post commit CI passes
[ ] Blackhole Post commit (if applicable)
[ ] Model regression CI testing passes (if applicable)
[ ] Device performance regression CI testing passes (if applicable)
[ ] (For models and ops writers) Full new models tests passes
[ ] New/Existing tests provide coverage for changes

Thanks for PR - I'm going to be cherry picking this as soon as it gets merged to unblock tt-metal uplift into tt-mlir.


[BUG] - Modal does not open on mobile when the trigger button is inside a Navbar

NextUI Version
2.1.13
Describe the bug
Given a button to open a modal placed inside a Navbar and uses the onPress event, when taped from a mobile the modal doesn't open.
The onPress works as expected (you can put a console.log to test it). It's weird because if the onOpen function is placed inside the onClick event, then it works.
If the button is placed outside the Navbar it works just fine.
If the modal has the prop disableAnimation it works just fine. So it looks like it's a problem with AnimatePresence from framer motion.
If you do a long press, it works, it doesn't when it is a normal (quick) tap. And if you use the onPressStart event, the modal animation starts when you press, but if you release the button after the animation finished, it goes backwards and doesn't open the modal, but if you wait for the animation to end, it stays open.
I also noticed that when running the documentation's example in codesandbox.io, it doesn't work even without being inside the Navbar.
This is a minimal example:
Open in CodeSandbox
'use client'

import React from "react"
import { Button } from '@nextui-org/button'
import {
  Modal,
  ModalBody,
  ModalContent,
  ModalHeader,
  useDisclosure,
} from '@nextui-org/modal'
import { Navbar, NavbarContent, NavbarItem } from '@nextui-org/navbar'

export default function App() {
  const { isOpen, onOpen, onOpenChange } = useDisclosure()
  return (
    <>
      <Navbar isBordered>
        <NavbarContent justify="end">
          <NavbarItem>
            <Button onPress={onOpen}>Not working on mobile</Button>
            <Modal isOpen={isOpen} onOpenChange={onOpenChange}>
              <ModalContent>
                {() => (
                  <>
                    <ModalHeader>Test modal</ModalHeader>
                    <ModalBody>Test modal</ModalBody>
                  </>
                )}
              </ModalContent>
            </Modal>
            <Button onClick={onOpen}>Working</Button>
          </NavbarItem>
        </NavbarContent>
      </Navbar>

      <Button onPress={onOpen}>Working</Button>
    </>
  )
}

Your Example Website or App
https://codesandbox.io/p/sandbox/hxgdz8?file=%2FApp.jsx%3A7%2C13&utm_medium=sandpack
Steps to Reproduce the Bug or Issue
Open the page from a mobile and tap the button inside the navbar.
Alternatively, you can open the devtools and emulate a touch device.
Expected behavior
Modal is opened.
Screenshots or Videos
https://github.com/nextui-org/nextui/assets/12821361/646b7bd6-ec18-4d40-8990-2a692a396690
Operating System Version
Android
Browser
Chrome

If someone encounters the same problem, I found 2 workarounds.

Instead of onPress use onClick in the <Button>.
Add the disableAnimation to the <Modal>

I also got the same error

The same problem on mobiles! instead of onPress use onClick in the  helped

me too. onclick working thx

Same here. However, With onClick the buttons does not support keyboard events and we need to add them manually.


Use shortcode when classic editor plugin is active

Summary
If a user has the classic-editor plugin active, the embed story block does not preview and seems broken. Instead of using the embed when classic-editor / TinyMCE is active, using the shortcode. See #3135
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

Activate classic editor plugin.
Create a story.
Publish story.
Click add post.
Go to post edit screen, see shortcode.

Fixes #4833
Blocked #4780

This PR is now blocked by #4780 as the e2e test fails without it.

This PR is ready go to now that #3135 is merged.

Verified in QA


Code numbering on by default?

Have got two users confused by how to turn code numbering on, and expecting it!
You can turn it on in the frontmatter, but maybe code should be on by default.
I think that because the code only gets numbered when there is a caption this is pretty safe -- that is it ISN'T every code example, just ones that are have captions!
Thoughts @fwkoch?

I am also pro turn code numbering on via default, because that would feel more coherent with tables and figures.

that is it ISN'T every code example, just ones that are have captions!

analogue to this not every figure is numbered, only the ones with captions, as can be seen in this example

Hello [](#my-fig), and [](#my-program).

<!-- figure without number -->
![Alt text](wave.jpg)

<!-- numbered figure -->
:::{figure} wave.jpg
:name: my-fig
:alt: A drop of water.

A  water wave
:::

<!-- code without number -->
:::python
print(np.real(c))
print(np.imag(c))
:::

<!-- numbered code -->

:::{code-block} python
:name: my-program
:caption: Calculation with numpy.

print(np.real(c))
print(np.imag(c))
:::

Also, I've just tested the pdf export with code numbering on, but the code numbering does not appear in the pdf, as can be seen in the screenshot:

Code to reproduce this:
---
title: Hello

exports:
  - format: pdf
    template: arxiv_two_column
numbering:
  code: true
---

+++ {"part": "abstract"}

Lorem ipsum ...
+++

:::python
print(np.real(c))
print(np.imag(c))
:::

:::{code-block} python
:name: my-program
:caption: Calculation with numpy.

print(np.real(c))
print(np.imag(c))
:::

I agree this is a good idea! Strange for code numbering to be different than everything else. (I was slightly confused at first because I was thinking about code line numbering, but this is just code block enumeration)
I think it's as simple as this: https://github.com/executablebooks/mystjs/pull/257

Released in myst-cli v0.1.17 🚀
I am going to leave this open, as I think there will actually have to be a few docs updates that we haven't done yet!

Had to fix up an iframe width issue, which meant I did this a bit sooner than I thought!!
See numbering demo working in the sandbox!


Temporary fix for incompatibility @call_rule with addons

This PR adds a temporary fix for the transition node, as sf's don't play nicely with @call_rule

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.14 :warning:

Comparison is base (803cdeb) 67.27% compared to head (28d79df) 67.13%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   67.27%   67.13%   -0.14%
==========================================
  Files         210      210
  Lines        7633     7632       -1
==========================================
- Hits         5135     5124      -11
- Misses       2498     2508      +10

Impacted Files
Coverage Δ

src/rules/transition/out.jl
100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


.build/{k,kore}: update submodules

I think this PR should make all tests in tests/ethereum-tests/VMTests/vmArithmeticTest/divBoostBug.json pass.  Did not test other dirs.

@dwightguth I remember you mentioning issues with the serialization stuffs, is this related? https://office.runtimeverification.com/jenkins/job/evm-semantics-pull-request/1176/console
Going to re-trigger tests anyway.

Jenkins: test this please

Jenkins: test this please

Jenkins: test mantis


support react-native field with fallback to browser field

React Native is a lot more powerful an environment than the browser, so we need an alternate mapping, as specified here
An example:
{
  "browser": {
     "./lib/server": false
   },
   "react-native": {
     "dgram": "react-native-udp",
     "fs": "react-native-level-fs"
   },
   "chromeapp": {
     "dgram": "chrome-dgram",
     "fs": "level-filesystem"
   }
}

on the other hand, if "react-native" is not present in package.json, you should fall back to "browser"
other than the one (nesting) test added, the tests are unchanged, just done for both "react-native" and "browser"
(I've implemented react-native-udp and react-native-level-fs, but they obviously don't belong in the traditional "browser" field as they won't run anywhere except in React Native.)

I like this approach more than anything else I've seen so far.

+1

Nice!
We're in the process of moving the packager to it's own github repo and we'll be able to accept contributions like this much faster (we can just use the Github merge button). I'm hoping we can release it some time this week, and I'll ping you so we can move this PR there. Thanks!

@amasad great, see you there :)

Awesome, @mvayngrib sorry for the huge wait. Do you mind rebasing and i'll pull it in? Thanks!

will do after Thurs, under serious time pressure till then. If it's urgent, I can add u as a collaborator on my fork.

Not urgent at all, it waited for a long time, can wait a bit more :)

On Nov 9, 2015, at 12:31 PM, Mark Vayngrib<EMAIL_ADDRESS>wrote:
@vjeux will do after Thurs, under serious time pressure till then. If it's urgent, I can add u as a collaborator on my fork.
—
Reply to this email directly or view it on GitHub.

This looks like a great fix, but I have a couple of questions. First, packager appears to support building web apps. I haven't used it for that and don't know if anyone else does, but if building for web, will it pick up the browser field instead of the react-native field from the package?
Second, I wonder what folks who use webpack for building react-native will have to do to make use of this field? Perhaps there's a webpack config option? or maybe webpack will have to be modified...

@vjeux I know we've had discussions about this in the past...I think it's definitely a good idea (at least from a community perspective). Not sure what your thoughts are on this from a FB perspective.

100% for it

Well on that note - it seems like it's merging cleanly at the moment (and I think the only test failure is the ever persistent e2e test failure (that doesn't have anything to do with this PR). @mvayngrib is there anything else you need to do here or is this ready for it's last review and for merge?

@skevy i think it's ready, but we'll know better when people start experimenting with it

@vjeux can you or @martinbigio import this then?

Finally :)

@facebook-github-bot shipit

Hey! Thanks a lot for this, I noticed a couple of things that are lacking in this implemenation.

main checks do not include './' + main, here is my quick fix:

      if (replacements && typeof replacements === 'object') {
        main = replacements['./' + main] ||
          replacements['./' + main + '.js'] ||
          replacements['./' + main + '.json'] ||
          replacements['./' + main.replace(/(\.js|\.json)$/, '')] ||
          replacements[main] ||
          replacements[main + '.js'] ||
          replacements[main + '.json'] ||
          replacements[main.replace(/(\.js|\.json)$/, '')] ||
          main;

The "browserify" field is not considered, here is my quick fix:

function getReplacements(pkg) {
  return pkg['react-native'] == null
    ? (pkg.browser == null ? pkg.browserify : pkg.browser)
    : pkg['react-native'];
}

@vespakoen if you'd like to submit a PR to fix this stuff, that would be great!

Unfortunately I found my laptop on the floor this morning and my display is bricked, will get some monitor on monday and make a PR - written on my android

What happened to this?

The PR was accepted and merged into RN 0.17 I believe
On Tue, Jul 19, 2016 at 23:45 Adrian Perez<EMAIL_ADDRESS>wrote:

What happened to this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/2208#issuecomment-233843368,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7l1yZDK2oZQ8PIk9aB-ygpCUKXQt_-ks5qXbXvgaJpZM4FkT9B
.

Did it? I must have looked in the wrong place, as in JavaScriptEngine
something. Thanks.
--
Best Regards,
Adrian Perez
https://adrianperez.codes
On July 20, 2016 at 7:47:35 PM, Chester Wood<EMAIL_ADDRESS>wrote:

The PR was accepted and merged into RN 0.17 I believe
On Tue, Jul 19, 2016 at 23:45 Adrian Perez<EMAIL_ADDRESS>wrote:

What happened to this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/facebook/react-native/pull/2208#issuecomment-233843368
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AA7l1yZDK2oZQ8PIk9aB-ygpCUKXQt_-ks5qXbXvgaJpZM4FkT9B
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/2208#issuecomment-234025649,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIIvM-taiwgf43gU81S_TdF4ADMCoK-ks5qXl83gaJpZM4FkT9B
.

It this working at the moment?
My package.json looks like this:
{
"name": "fetchy",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "node node_modules/react-native/local-cli/cli.js start",
"setup_project": "npm run step1; npm run step2",
"step1": "rm -rf node_modules/react-native/node_modules/react; rm -rf node_modules/react-native/node_modules/fbjs; rm -rf node_modules/react/node_modules/fbjs",
"step2": "cd node_modules; find . -name .babelrc | grep -v packager | xargs rm"
},
"react-native": {
"domain": false
},
"dependencies": {
"globalize": "^1.1.1",
"moment": "^2.14.1",
"parse": "1.6.14",
"parse-react": "0.5.2",
"react": "^15.3.0",
"react-native": "0.30.0",
"react-datepicker": "^0.29.0",
"react-dom": "^15.3.0",
"react-redux": "^4.4.5",
"react-widgets": "^3.4.3",
"redux": "3.3.1",
"redux-form": "^5.3.2",
"redux-logger": "^2.6.1",
"redux-promise": "^0.5.3",
"redux-thunk": "1.0.3"
},
"devDependencies": {
"babel-core": "^6.11.4",
"babel-loader": "^6.2.4",
"babel-preset-es2015": "^6.9.0",
"babel-preset-react": "^6.11.1",
"chai": "^3.5.0",
"chai-immutable": "^1.6.0",
"css-loader": "^0.23.1",
"extract-text-webpack-plugin": "^1.0.1",
"globalize-webpack-plugin": "^0.3.5",
"jsdom": "^9.4.1",
"mocha": "^3.0.0",
"node-sass": "^3.8.0",
"react-hot-loader": "^1.3.0",
"sass-loader": "^4.0.0",
"style-loader": "^0.13.1",
"webpack": "^1.13.1",
"webpack-dev-server": "^1.14.1"
}
}
and then in my code:
var domain = require('domain');
console.log(domain);
and I get this:
"Requiring unknown module "domain"...." message. any idea?

https://github.com/facebook/node-haste/pull/77 for browser exclude support has been merged, but node-haste has not been republished to npm since. You can try overriding installing node-haste from github to react-native's node-haste dep locally

Have the same error https://github.com/facebook/react-native/issues/9518, since node-haste was brought back to the react-native 667aaa4621a9f59b620cb17b39af8dd309ebd0da overriding installing node-haste from github doesn't make sense.


Document disabled buttons

Updates the docs to include a section on disabled states for <button> and <a> buttons, as well as their primary, danger, and outline variations. Here's how the new docs look:

/cc @amosie

:sparkles: Thanks @mdo


Remove Crypto parametrization

In light of recent discovery of crypto parametrization having serious overhead on the cardano-node  due to lost specialization with ghc-9.x we decided that it will be a good idea to remove crypto parametrization completely.
I was very much aware about the fact that Crypto adds a significant cognitive overhead, but previously I only speculated that it could have performance overhead. Now we have confirmation that this is indeed the case.
I believe, originally the goal for crypto parametrization was to allow using different cryptographic primitives for testing, which turned out to be only a partially useful idea.
Last year while investigating potentially adding BatchVRF I questioned the usefulness of Crypto and we came to few realizations:

Ledger only uses HASH, ADDRHASH and DSIGN, which can never change. Therefore there is no point in them being a type family.
VRF and KES are used by the consensus codebase for things like block header validation, etc. Which means ledger has no need for those type families and they should only be able to change for different block header types.

These two discoveries made us realize that we do not need crypto parametrization in ledger at all. If we were to remove it, regression with performance would go away. So, not only GHC would have a much easier time with specializing, but the codebase and downstream uses of ledger would become much simpler, thus leading to less confusion about ledger types, which have enough complexity in them already. I lost count how many times I had to explain type errors when people confused era and crypto type parameters.
So, there are two major tasks that need to be done in order to get rid of Crypto:

Move VRF and KES from Crypto to something like HeaderCrypto and make block header parametrized by crypto, which was implemented as proof of concept a year ago: https://github.com/IntersectMBO/cardano-ledger/pull/3388
Remove Crypto parametrization from all ledger eras.

Both of those tasks will require significant amount of work because they would touch a lot of code, but they be would very well worth it. Therefore, we can't tackle this task until after Conway is released.
Few related notes:

Removal of crypto type parametrization would not require a hard fork, so we can tackle it without introducing a new era
Better do it sooner rather than later, cause longer we wait, the harder it will be to rip it out
Restricting c ~ StandardCrypto will not work as interim solution, because that would require us removing a whole bunch of tests that use MockCrypto for dealing with fake VRF and KES

Hello!
Is there any plan to close this ticket? Is it on a roadmap somewhere?

Is there any plan to close this ticket?

Yes, there is a plan. But we will not start working on this, until we have solved higher priority issues, like deploying Conway.

Is there any plan to close this ticket?

There is no point, because every single package downstream from ledger will be affected by this change.

Perhaps I misunderstand the problem but if every package downstream is impacted then wouldn't it make sense to begin with those packages and remove the dependencies on Crypto, swapping them with StandardCrypto. Then continue until each package does not depend on class Crypto in ledger, then remove it?

then wouldn't it make sense to begin with those packages and remove the dependencies on Crypto, swapping them with StandardCrypto.

No, the goal is to completely remove crypto parameter and StandardCrypto type altogether


Avoidability and consequences of asymmetric routing

Hi,
I have just started to work with a new Submariner installation to familiarize myself with Submariner and got stuck before the finish line.
I am asking for a little guideance in this issue, how to orient myself in my situation.
TL;DR
I've run into the rp_filter issue, but I feel that the suggested workaround would be a sub-optimal solution.
I am curious about alternatives.
Setup
I have created two VPC-based Kubernetes clusters on IBM Cloud with different (pod, service and node) CIDRs:

Cluster A pods: 172.17.0.X
Cluster B pods: 172.17.64.Y

Installation
I used subctl to install the latest version of Submariner (0.14.4 and later 0.15.0) on the clusters and created a load balancer for the tunnel (maybe I was not paying attention on a detail, but the tunnel was not established via nat traversal). The CNI is Calico and the extra IPPool resources are placed to avoid NAT for external cluster subnets.
Troubleshooting
Everything works according to:

subctl diagnose all
subctl verify --only service-discovery,connectivity --verbose

except gateway <-> non-gateway communication in cross-cluster cases.
I used ping for troubleshooting:

pod-a: on a non-gateway node in cluster A
pod-b: on the gateway node in cluster B

The echo-reply reached (back) to the host of pod-a, but did not reach pod-a.
root@host-of-pod-a# tcpdump -i ens3 -ln "icmp"
07:18:46.168536 IP 172.17.64.Y > 172.17.0.X: ICMP echo reply, id 52341, seq 15, length 64

root@pod-a # tcpdump -i eth0 -ln
07:38:29.846148 IP 172.17.0.X > 172.17.64.Y: ICMP echo request, id 46944, seq 1025, length 64
07:38:30.870031 IP 172.17.0.X > 172.17.64.Y: ICMP echo request, id 46944, seq 1026, length 64
... # no ICMP reply

I've tried to allow all traffic on Calico with an "allow all" in and outbound GlobalNetworkPolicy.
root@host-of-pod-a# journalctl -k -f
Jun 06 09:23:26 kube-host-name kernel: IPv4: martian source 172.17.0.X from 172.17.64.Y, on dev ens3

My interpretation of the situation

The root-cause of the martian packets is asymmetric routing. The host of pod-a uses vx-submariner to forward outgoing requests, but the cluster's gateway node uses the underlying (VPC) network to forward the replies.
As far as I know, asymmetric routing is ill-advised.
What I found across other issues and on Submariner's Slack is that setting Reverse Path filtering to allow these martian packets is the recommended solution.
I am wondering, does it raise security concenrs to set rp_filter? Should it be accompanied by custom firewall rules to guard on source addresses?
Also, I am thinking about the possibility to establish Policy Routing on the gateway node to route the replies (packet with source address from the opposite cluster) through the internal tunnel (vx-submariner).
Is it feasible or considered within the project?
Thanks in advance.

Thanks for reaching out @adrianrobotka ,
Theoretically, the best thing would be if the CNIs expose routing API so that Submariner can use this API to set a rule to forward traffic to a remote cluster through the submariner tunnel.
In this case both ingress/egress datapath between clusters should be handled by the CNI, Submariner remains CNI agnostic and there is no need to update rp_filter. This is exactly what we do with OVN-Kubernetes CNI where Submariner does not even create the vx-submariner tunnel interface.
Ideally, we want other CNIs to support similar interfaces, but unfortunately, they don't.
So we are left with two options:

Implement both ingress and egress data path between clusters using Submariner
Implement only egress between clusters, let CNI handle ingress, and set rp_filter to loose to allow asymmetric traffic.

In order to support ingress traffic coming from a remote cluster to the Pod, Submariner will have to maintain the details of the nodes on which the Pods are scheduled and accordingly route the traffic over the vx-submariner iface to avoid rp_filter requirement.
Similarly, for services, Submariner will have to re-implement the operations done by Kube-proxy to load-balance the ingress traffic. This is almost like duplicating the work done by the CNI and kube-proxy, hence we avoided this approach. Leaving the ingress datapath to the CNI allows Submariner to work with many CNIs.
Also, we are setting the rp_filter to 2 (aka loose mode) and not disabling the check all together. In Loose mode, the kernel will do some minimal validation on the source address as we can see in the description.
2 - Loose mode as defined in RFC3704 Loose Reverse Path
    Each incoming packet's source address is also tested against the FIB
    and if the source address is not reachable via any interface
    the packet check will fail.

Thanks @yboaron for the detailed insight!
From this point of view, rp_filter=2 makes much sense.


functions: cloud bigtable reading function example

Just to confirm, did you try deploying and using this?

yes I deployed and used it :)


[Loc] Update to Sql and Sql Migration

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.624%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26385

Relevant Lines:
57391

💛  - Coveralls


Code splitting support?

Hi!
I wonder if you have tackled or thought about code-splitting yet. It is kinda important to have some sort of code-splitting support. I want to use a vue component only on one page and don't want to bundle everything together in one App.js file.
In an ideal world, only the specific page that makes use of vue will have a link to the vue-related bundle.

Hi @yasoob! In the README it's called "lazy loading" and it's supported:
https://github.com/Valian/live_vue?tab=readme-ov-file#lazy-loading-vue-components
import component1 from "./Component1.vue"
import component2 from "./Component2.vue"
const entryComponents = {
    Component1: component1,
    Component2: component2,
    Component3Lazy: () => import("./Component3.vue"),
}

// in app.js
const hooks = getHooks(entryComponents)

in the above example, Component3 won't be a part of app.js bundle, but rather a separate file. You can of course use () => import(...) inside Vue component, it should be put into separate chunk as well. For more info, read Vite documentation
In SSR, component should be rendered correctly and in addition it should include <script src="..." preload> tags to make hydration faster.
Please let me know if you'll have any issues, but hopefully it will just work 🤗


modal close event query

Is there an event/callback for when the modal version of the gallery is closed regardless of how it is closed?
(e.g. if closed using escape key, red cross button or clicking outside of the modal).
How can I detect/hook into the modal close event?

@chetski  Currently there is no close event for the modal, but it is good to have in the next update


Fix release workflow

What happened incorrectly?
The release workflow breaks due to a wrong token.
What should have happened instead?
The release workflow should pass.
What steps are needed to reproduce the bug?

Make an arbitrary change on the main branch, or try re-running one of the latest release workflows.

This is now fixed with release v2.2.1.


[K8S][HELM]Define kyuubi labels and improve the RBAC file

Why are the changes needed?

Define Kyuubi labels template
Merge role and RoleBinding kind into RBAC file
README add template rendering
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

@dev-lpq thanks for your contribution! Let me leave two general comments:

Please, create separate PRs for different changes if possible. It helps to review and manage changes.
Please, explain in the PR message why the changes are needed instead of what is changed.


Bring up to Prefect 0.13.13

0.13.13 is out. Update requirements.txt AND setup.py to bring up our versions.

Shot past that into 0.13.18 with #22


[Bug]: DLM task, after archiving with conditions, click rollback, you must bring the library name

ODC version
ODC422
OB version
Oceanbase3240
What happened?
DLM task, after clicking Terminate, clicking Retry still fails.

What did you expect to happen?
normally
How can we reproduce it (as minimally and precisely as possible)?
chat privately
Anything else we need to know?
No response
Cloud
No response

feature


Cant search 7tv emotes in emotes tab

Describe the bug

7tv emotes dont appear in search for the emotes tab
To reproduce

search for a 7tv emote
it should not be there

Screenshots

Chatterino version

Chatterino Nightly + Dankerino patches 2.3.4 (commit 70a37830f, built on )
Operating system

Windows 10
Additional information

Fixed in chatterino7 fork in dbd99e4cd2c93f190b678aa46b7ca8c03b620979, merging our fork's default branch should fix it.

Yep, I had a couple of merge conflicts when I tried to merge it and didn't finish it. I'll probably do it today.
12 sty 2022 22:33:08 Paweł @.***>:

Fixed in chatterino7 fork in dbd99e4[https://github.com/Mm2PL/dankerino/commit/dbd99e4cd2c93f190b678aa46b7ca8c03b620979], merging our fork's default branch should fix it.
—
Reply to this email directly, view it on GitHub[https://github.com/Mm2PL/dankerino/issues/118#issuecomment-1011469169], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AF62MITWPY5WCKL7ABCEIVDUVXXQXANCNFSM5LYFSQVQ].
Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub].
You are receiving this because you are subscribed to this thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADkAAAA5CAYAAACMGIOFAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAkSURBVGiB7cExAQAAAMKg9U9tDQ+gAAAAAAAAAAAAAAAA4NQAMv0AAa3l6BAAAAAASUVORK5CYII=###24x24:true###][Obrazek śledzący][https://github.com/notifications/beacon/AF62MIVRK3HYNH4NBNHOBZTUVXXQXA5CNFSM5LYFSQV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHRE4W4I.gif]


Bug: Event Images Not Rendering on Events Page

Bug Description:
On the Events Page, the images associated with each event are failing to render. Instead of the event image, users are either seeing broken image links or no images at all.
Steps to Reproduce:

Navigate to the Events Page.
Browse through the list of events.

Expected Behavior:
Each event listing should display its associated image.
Actual Behavior:
Event images are not rendering, showing broken image icons or blank spaces where the image should be.
Additional Information:

Browser/Device: Microsoft Edge, macOS
Affected Version: BurnOut Release 4

@adi-kiran Can you look into this?

Fixed in this commit https://github.com/adi-kiran/burnout-healthgoalsapp/commit/1850e8560955c83701d0d973c01f494b6ed2aa35

Issue was with the location of the images. Moving it under public fixed it.


Store website on Filecoin using Slate

See https://github.com/filecoin-project/slate/blob/main/pages/experiences/make-storage-deal.js

This has been setup in this commit https://github.com/ltfschoen/ethquad/commit/d8af6f66c4c316cf55055f6b42e840c3976624be but only works on local machine when running a node by following the "Connect to Lotus (Filecoin) and IPFS" steps in the README file (e.g. make up)


Upgrade to ESLint 6.x

ESLint 6 has been out for a while but I could not quickly upgrade my config as something is changed for "overrides" which I use to define some different rules for /tests files.
Upgrading to eslint 6 will require an upgrade to the config and will probably be the focus of release 0.3

It has been done :)


Build Action-like objects from WrittenMessages

Currently just a design doc for the rest of #181.

Brain dump, so I have some context for reading this:
My personal top use case is extracting errors. And probably the way you want to do that is have a two-phase scan:

Scan on-disk (or Elasticsearch logs or whatever) for failed actions, tracebacks and errors forwarded from Twisted logs (this is Flocker-specific for now but we do want to move that code to Eliot).
Calculate the set of task_id values from messages found in step 1.
Scan on-disk logs for all messages with that task_id.

Probably for many issues the output of step 1 is sufficient. Others would need output of step 3. Conceivably some would need even more logs but that's going to be a lot less common.
Moreover:

It's impossible to know when an action is really done given cross-process actions.
Crashes etc. mean some actions will never have their final messages.
Memory restriction is a policy choice that has to be available, but needn't be enforced so long as API user can choose to do so.

Bleh. Still not sure where this should go. Possibly because it doesn't actually match the interaction pattern for my use case above. Will return to this later.

Errors is one of my two major cases. The other is gathering stats about durations of a particular type of action.
What I'll do is provide the basic building blocks for this, as well as convenience functions that use them in a way that's useful to me right here & now. That way, when we want to handle other, trickier cases we can (hopefully) just add code, rather than changing the base-level types.

This has been dealt with in other parsing work.


fix Fix wrong plan of SQL with cross join and aggreagate

Proposed changes
Issue Number: noissue
Problem summary
SELECT col1
FROM
    (SELECT col1 FROM t1) a
INNER JOIN
    (SELECT sum(b3) AS 'b3u'
    FROM
        (SELECT `c`.`col2` AS `c2`,
         sum(b.col3) AS `b3`
        FROM `t2` b
        INNER JOIN `t3` c
            ON ((`b`.`col1` = `c`.`col1`))
        GROUP BY  `c`.`col2`) dd ) b;

For such SQL type, the materialized attribute of SlotDescriptor will be updated during the optmization for countStar and cross join(see this method materializeInlineViewResultExprForCrossJoinOrCountStar), though the single node plan has been generated, and the generation of plan is dependent on the materialized attribute, so apparently there is a parodox here.
Fix:

Materialize all slot in the chain of sourceExprs.
Materialize agg info again after the creation of table ref with join operator
Add all the SlotDescriptor to HashJoinNode's output from child output no matter is materilalized or not
Once the Slot is required keep it in the output tuple instead of pruning it, no matter the slot is materialized or not

Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow @morrySnow


Missing trace_id + span_id when using with otelfiber

I'm trying to use the official otelfiber and this library to log trace_id and user_id
app.Use(otelfiber.Middleware())
app.Use(slogfiber.NewWithConfig(logger, slogfiber.Config{
    WithSpanID:  true,
    WithTraceID: true,
}))

I noticed the otelfiber library uses c.UserContext()
https://github.com/gofiber/contrib/blob/c62abb213b0a82b35be9ecf39237760e0ee84c84/otelfiber/fiber.go#L119-L120
And this library uses c.Context() which trace doesn't exist.
https://github.com/samber/slog-fiber/blob/7bd189e1a50676fb442b911788788584d14a9311/middleware.go#L181-L182
I'm not sure if i'm implementing this wrong or the library is deliberately using the fasthttp context?

Side note I think trace id and span id need to be trace_id instead of trace-id
https://opentelemetry.io/docs/specs/otel/compatibility/logging_trace_context/https://opentelemetry.io/docs/specs/otel/compatibility/logging_trace_context/

i made a fix, thanks for the feedback


Modify Contributor Section @Home Page

Requirements

Make the cards of the contributors round in shape(add border radius)
Reduce the size of the cards so that all 65 contributors' details can easily be accomodated

General PR Guidelines:

Each pull request should have an appropriate and short title like "Fixed Bug in Upload Page"

Describe your intended changes in the description section of the pull request (Use bullet points and phrases)

Refrain from using phrases like "Hi, I am ..", "Please merge me this OPR", "Thank You..", etc. We are only interested in technical parts

Attach a screenshot/clip of the change(s)

Make sure to refer to the respective issue in the respective PR using phrases like Resolves #issue_number or Closes #issue_number.

Please be patient enough. The project maintainers/mentors would review it as per their schedule. Please do not start putting comments like "Please check this" etc.

Although we support feedback from everyone in all phases of development, it is highly advised not to put any negative comments in other participant's pull requests.

Always keep a note of the deadline.

Hi ,I am Malavika participating GSSOC'21 .
I am interested in contributing to this issue could you please assign me this  .

Assigned for 4 days

Is this fine ?

Is this fine ?

More circular. just like the profile picture of GitHub in the top right corner. Try adding all the contributors here.

Is it fine now ?

Hello! Can I work on this?

Is it fine now ?

Perfect.

Hello! Can I work on this?

After 2 days

Reminder:

Give an appropriate title
Refer to the Issue using Closes # issue_no
Description of the changes(Bullet Points)
Screenshot/Clip of the change

@malavikarajeshvikraman Raise a PR for your changes
Please ensure that you follow the PR guidelines given above or in the Contributing.MD before raising a PR

Okay @smaranjitghose  will raise a PR following the guidelines .


Major issues in kubeflow deployment on AWS

2.0 Set up EFS:
2.1 is automated setup in which you talk about a security group
2.2 is manual setup, there is no security group involved at all... That's odd
I used 2.2 to see all the steps. Completed all steps successfully. But EFS volume creation does not work. I described the pvc and I see this
"Warning  ProvisioningFailed    4m10s (x14 over 24m)  efs.csi.aws.com_efs-csi-controller-5cb8767cfc-gts52_83ea0575-16d9-4d23-9c3a-603decb87004  failed to provision volume with StorageClass "efs-sc": rpc error: code = Internal desc = Failed to fetch File System info: Describe File System failed: NoCredentialProviders: no valid providers in chain. Deprecated."
It looks like 2.2 is broken....
Its been a struggle. Can you please look into this and update soon? Thanks.

This is the doc https://awslabs.github.io/kubeflow-manifests/docs/add-ons/storage/efs/guide/
Using v1.6.1 branch of kubeflow-manifests

I realized that security group is used while creating EFS file system manually.
In any case, tried automated setup also and even with that I'm unable to create a notebook server. It stays in pending for a very long time, the PVCs are also pending (they don't go to bound state)
Are the EFS instructions verified to work with v1.6.1?
I must tell you its been a very frustrating experience trying to get kubeflow to run on aws eks.
Tried terraform deployment (s3/rds/cognito). Broken. Wiped everything clean and tried Terraform (s3/rds). Broken.
Tried manual deployment. All good upto EFS setup. I can see the DEX UI. login, and see central dashboard.
When I create volumes, the PVCs are in pending state.
When I create a notebook server, the pod is in pending state.... forever

Hello @tejarora , I have verified that the automated setup works and that the notebook server comes online on v1.6.1. Is the notebook server still unavailble? Can run kubectl describe on the PVC and the notebook server pod? This will help us get more information so we can resolve these issues.
Additionally the rest of the terraform deployment options that you mention as broken, I have also verified that they are working. Do you have any insights into what issues you faced with the terraform deployments?

@tejarora please let us know if you have any update on this issue

Hello Ryan & Suraj, I will update here in a couple of days. Got pulled into other priorities. Thanks.

Here's some observations and feedback. I may have another round of feedback as my kubeflow deployment on AWS is still work in progress.
First I tried the terraform deployment with cognito, rds, s3 option. The problem I ran into was that my Route 53 zone was in an account that was different from the one in which kubeflow was getting deployed. This is my first time with terraform and I didn't want to venture into modifying the terraform manifests to make cross-account zone access work. So I abandoned this approach.
Second I tried the terraform deployment with just rds, s3. This was repeatedly failing with eks cluster access issues (i/o timeout). I'm aware there are occasional glitches when I administer my EKS cluster using kubectl. I have experienced quality issues with the instances deployed for the EKS API Server endpoint. I fine one of the instances sick more often than I'd like. How do I know? nslookup on the API server endpoint, telnet the IPs - usually 2 and one of them times out. The sick instance(s) do get fixed in some time. Coming back to the terraform deployment, I tried the deployment 12 times (over 2 days), and it failed with i/o timeout every single time... I don't think this has to do my network connectivity, as I'm able to administer my other clusters without problems... There is some issue on the AWS end, the API server endpoint instances aren't most reliable.  The terraform deployment may have knobs to adjust timeouts and retries.... these will certainly need to be tuned to make the deployment more resilient.
One observation common to both the terraform deployments is that the EKS cluster deployed has no cluster auto-scaler. Basically there was no node auto scaling up/down (nodes with all pods drained were not getting removed, and pods were waiting in pending state and no new nodes got created). This is a major deficiency, and unacceptable for a production deployment.
Another observation was that nodes were getting over-provisioned by default - 5 m5.xlarge instances was a minimum!! This is very aggressive and should be easily configurable, but it was not. After my manual deployment efforts, I found that just TWO instances were more than sufficient to run ALL of the kubeflow components (about 80 or so pods). And I deployed karpenter for auto scaling and didn't have to worry about additional nodes getting automatically provisioned when necessary.
After no success with terraform deployments, I began the path of manual deployments with Kustomize option. I set up my own EKS cluster (with karpenter for auto-scaling and nginx controller for ingress, a publicly accessible domain for kubeflow). I was able to get to a point when the kubeflow cluster was stable and I was able to see the DEX UI for login with the default<EMAIL_ADDRESS>profile using the custom domain.
Then I ventured into deploying the EFS add-on. That has been very problematic. I tried the automated script. Didn't work. Then tried the manual steps. Didn't work. Basically, EFS volumes are showing in the UI - they are not in BOUND state. When I spin up a notebook server, it does not get provisioned - times out.
I found this when I did a kubectl describe pvc on the EFS pvc
"Warning ProvisioningFailed 4m10s (x14 over 24m) efs.csi.aws.com_efs-csi-controller-5cb8767cfc-gts52_83ea0575-16d9-4d23-9c3a-603decb87004 failed to provision volume with StorageClass "efs-sc": rpc error: code = Internal desc = Failed to fetch File System info: Describe File System failed: NoCredentialProviders: no valid providers in chain. Deprecated."
I am going to clean up, and once again try deploying the EFS add-on manually. Will update here on the outcome.
Meanwhile, I think I've unearthed plenty of issues with the prescribed kubeflow deployment on AWS. Hope they are taken up for rectification.

Any help would be appreciated... I've been trying to deploy kubeflow on AWS for over a week, running into issues and still no successful deployment to show for the effort.

To answer Ryan's questions
$kubectl describe -n kube-system serviceaccount efs-csi-controller-sa
Name:                efs-csi-controller-sa
Namespace:           kube-system
Labels:              app.kubernetes.io/managed-by=eksctl
app.kubernetes.io/name=aws-efs-csi-driver
Annotations:         eks.amazonaws.com/role-arn: arn:aws:iam:::role/
Image pull secrets:
Mountable secrets:   efs-csi-controller-sa-token-87hfl
Tokens:              efs-csi-controller-sa-token-87hfl
Events:
The policy attached to the role in the annotation is:
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"elasticfilesystem:DescribeAccessPoints",
"elasticfilesystem:DescribeFileSystems"
],
"Resource": ""
},
{
"Effect": "Allow",
"Action": [
"elasticfilesystem:CreateAccessPoint"
],
"Resource": "",
"Condition": {
"StringLike": {
"aws:RequestTag/efs.csi.aws.com/cluster": "true"
}
}
},
{
"Effect": "Allow",
"Action": "elasticfilesystem:DeleteAccessPoint",
"Resource": "*",
"Condition": {
"StringEquals": {
"aws:ResourceTag/efs.csi.aws.com/cluster": "true"
}
}
}
]
}

To answer Ryan's questions
$kubectl describe -n kube-system serviceaccount efs-csi-controller-sa Name: efs-csi-controller-sa Namespace: kube-system Labels: app.kubernetes.io/managed-by=eksctl app.kubernetes.io/name=aws-efs-csi-driver Annotations: eks.amazonaws.com/role-arn: arn:aws:iam:::role/ Image pull secrets: Mountable secrets: efs-csi-controller-sa-token-87hfl Tokens: efs-csi-controller-sa-token-87hfl Events:
The policy attached to the role in the annotation is:
{     "Version": "2012-10-17",     "Statement": [         {             "Effect": "Allow",             "Action": [                 "elasticfilesystem:DescribeAccessPoints",                 "elasticfilesystem:DescribeFileSystems"             ],             "Resource": "*"         },         {             "Effect": "Allow",             "Action": [                 "elasticfilesystem:CreateAccessPoint"             ],             "Resource": "*",             "Condition": {                 "StringLike": {                     "aws:RequestTag/efs.csi.aws.com/cluster": "true"                 }             }         },         {             "Effect": "Allow",             "Action": "elasticfilesystem:DeleteAccessPoint",             "Resource": "*",             "Condition": {                 "StringEquals": {                     "aws:ResourceTag/efs.csi.aws.com/cluster": "true"                 }             }         }     ] }

Some warnings when I ran the automated EFS script
$ python utils/auto-efs-setup.py --region $CLUSTER_REGION --cluster $CLUSTER_NAME --efs_file_system_name $CLAIM_NAME --efs_security_group_name $SECURITY_GROUP_TO_CREATE
/usr/lib/python3/dist-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?   if x is 0 or x is 1:
/usr/lib/python3/dist-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?   if x is 0 or x is 1:
/usr/lib/python3/dist-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?   elif y is 0 or y is 1:
/usr/lib/python3/dist-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?   elif y is 0 or y is 1:
/usr/lib/python3/dist-packages/jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="?   if original_result is 0:

Noticed a possible bug in the auto-efs-setup.py
It prints "CLUSTER PUBLIC SUBNETS" but the subnets it printed are actually PRIVATE SUBNETS.
Don't know what logic it uses to separate public and private subnets... but in this case, its gone wrong

Minor issue in script... It prints "CLUSTER PUBLIC SUBNETS" before creating mount targets. It actually prints private subnets... The right thing to say is "SUBNETS WHERE NODES ARE CREATED" (could be public or private)

Thank you @tejarora  for taking the time to provide all this valuable feedback. I really appreciate the detailed explanation of what you feel can be improved for the AWS Kubeflow Documentation.
The issue you have run into with the rds-s3 deployment option seems to be related to EKS cluster creation not being up to par correct? As in you did not get to steps such as installing the manifests but were failing around cluster creation time? If you still have some of these failed eks clusters, I can reach out to some folks for some insight into why you are running into this issue.
We also noted that difference between the manual and auto-deployment and will most likely be updating the manual-deployment options permissions. Sorry that it may have caused issues.
So as of now everything related to efs is working and you can use volume within your notebook?
Noted for the minor issue in the script, will re-create the issue to verify and create the proper print message.

The issue you have run into with the rds-s3 deployment option seems to be related to EKS cluster creation not being up to par correct?
The cluster gets created fine. The instances serving the cluster API server endpoint are sub-par... Customers have no control over these instances...

So as of now everything related to efs is working and you can use volume within your notebook?
Yes, volumes are created and bound and the notebook instance is up and running ... The data scientists/ml engineers will use kubeflow now and hopefully all will be smooth

Also, please clarify this (possible issue?)
kubectl describe sa efs-csi-node-sa -n kube-system
Name: efs-csi-node-sa
Namespace: kube-system
Labels: app.kubernetes.io/name=aws-efs-csi-driver
Annotations:
Image pull secrets:
Mountable secrets: efs-csi-node-sa-token-n742p
Tokens: efs-csi-node-sa-token-n742p
Events:
This serviceaccount has no permissions (i.e. no role shows up in annotations). This doesn't look right.

Taking a look into the serviceaccount will investigate.

Hi,
I'm deploying kubeflow on AWS using Terraform following the steps over here-  https://awslabs.github.io/kubeflow-manifests/docs/deployment/prerequisites/
This is the code repo- https://github.com/awslabs/kubeflow-manifests/tree/main/deployments/rds-s3/terraform
But it's giving me below error:
Error: configuring Terraform AWS Provider: no valid credential sources for Terraform AWS Provider found.

Please see https://registry.terraform.io/providers/hashicorp/aws for more information about providing credentials.

Error: failed to refresh cached credentials, no EC2 IMDS role found, operation error ec2imds:
 GetMetadata, http response error StatusCode: 404, request to EC2 IMDS failed

 with provider["registry.terraform.io/hashicorp/aws"], on main.tf line 56, in provider "aws": 56: provider "aws" {

Makefile:20: recipe for target 'create-vpc' failed

Can someone help with it?

In the Notebook documentation, I was looking for the proper way to enable notebook instances to access AWS resources... I expected that a particular serviceaccount needs to be bound to a role (using annotations). I guessed that the service account to annotate would be notebook-controller-service-account. Please confirm if this is true.
The documentation here https://awslabs.github.io/kubeflow-manifests/docs/component-guides/notebooks/ has a very light and vague section "Access AWS Services from Notebooks", which has nothing useful at all.
Can you please enhance this section to provide specific instructions?
thanks

@techwithshadab please run aws sts get-caller-identity to check if credentials are setup properly. Please open a new issue for further support since this is unrelated to current thread.

No further comments from user on this issue.


fmt: documentation on Printf * modifier is misleading

What version of Go are you using (go version)?
go version go1.9 darwin/amd64
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/dpinela/dev/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.9/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.9/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/41/2xpv_r1j5n5bnflwb7s1hv580000gp/T/go-build477584587=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
Run this program: https://play.golang.org/p/uBOhH86MEv
What did you expect to see?
The program prints:
$%!(BADWIDTH)%!g(int=8)
$00001.68

What did you see instead?
It prints the following instead:
$00001.68
$%!(BADWIDTH)%!g(int=8)

The documentation says this about the behaviour of the * modifier (emphasis mine):

Width and precision are measured in units of Unicode code points, that is, runes. (This differs from C's printf where the units are always measured in bytes.) Either or both of the flags may be replaced with the character '*', causing their values to be obtained from the next operand, which must be of type int.

I was therefore expecting that Printf would get the width from the argument following the one to be formatted, rather than the preceding one. I think the wording could be clarified, such as by specifying "causing their values to be obtained from the next operand, before obtaining the value to be formatted", and/or by adding an example.

/cc @robpike

The arguments are read left to right. That's always the case.
The problem is with the word 'next', which is so vexing in conversation that people construct circumlocutions for clarity, as in "The next Tuesday we will experience." It seems unlikely we need to invent verbiage for this.

@dpinela, @robpike has mailed out a CL. Just in case you aren't able to get onto Gerrit
he has amended the comment to now be:
obtained from the next unread operand (preceding the one to format),
	which must be of type int.

and that looks quite similar to your suggestion.

That looks better than my suggestion, even. Thanks.


Home page renders NotFound from server side.

I would like to highlight one issue which I have faced recently.
Step 1.
I forked your repo  However, This is little old but I didn't need the locales support in my project. Though I updated all dependencies ;-)
Step 2.
I replaced the code in App/Routes.js
    <Switch>
        <Redirect exact from="/" to="/home" />
        <Route exact path="/about">
            <UniversalComponent page="About" />
        </Route>
        <Route exact path="/article">
            <UniversalComponent page="Article" />
        </Route>
        <Route exact path="/home">
            <UniversalComponent page="Home" />
        </Route>
        <Route>
            <NotFound />
        </Route>
    </Switch>

with the following one.
<Switch>
  <Route exact path="/">
    <UniversalComponent page="Home" />
  </Route>
  <Route exact path="/about">
    <UniversalComponent page="About" />
  </Route>
  <Route exact path="/article">
    <UniversalComponent page="Article" />
  </Route>
  <Route>
    <NotFound />
  </Route>
</Switch>

Step 3.
npm run start
Result:
Basically, I changed the routing for Home page. I want whenever i open http://localhost:8080 in the browser, it should open the Home component. But it is loading NotFound component on the server then it renders the Home component on client side.
I want to load Home when i load the http://localhost:8080 by default, from server and client both.

@luangjokaj Will you please look into it?

@scaledrop can you try to browse it from incognito mode? The code you posted here is working for me there are no issues, just some aggressive caching.
https://i.imgur.com/3BmBEAS.png
https://i.imgur.com/j6OgCxG.png

@luangjokaj Thank you so much for clarifying that. But the issue is with the production build otherwise it is working fine in dev environment. Also, would you please guide me how to remove the locale support without losing anything crucial?

@luangjokaj Please find the screenshot attached. https://imgur.com/a/Yg8zHwf
I had no intention to highlight a silly thing here and waste the time of both of us. It is seriously not rendering from server in production mode. I hope you understand my concern now.

@scaledrop On your AppRoot.js remove the following:
const isEn = location.pathname.substr(1, 2) == 'en' && 'en';
const isDe = location.pathname.substr(1, 2) == 'de' && 'de';
const currentLang = isEn || isDe || 'en';

and also get rid of lang={navigator && currentLang}
You can cleanup also server/render.js from all the lang references.

I followed the same steps @luangjokaj But not working. Please see the screenshot once while it was in production env

@luangjokaj It is strange though. React-universal-component should work properly in case of "/" or Home route.

@scaledrop remove exact from your Home route...
It should look like:
<Route
	path="/"
	render={routeProps => <UniversalComponent page="Home" {...routeProps} />}
/>

Oh, it seems to be working without exact, thanks @luangjokaj !

But now code-splitting stopped working :-/

@scaledrop of course code splitting works only in development, not in production.

No, then you should go through react-universal-component's docs.  It works on both ends, that's the special ability of it. Did you see, it was working until you removed the exact parameter from Home route!
Now we have to find a way to fix the Home page routing, else is working fine in the boilerplate.

Any update @luangjokaj ?

@scaledrop I just came across this today again.
I solved it by changing the main home route to:
<Route
	exact
	path="/index.html"
	render={routeProps => <UniversalComponent page="Home" {...routeProps} />}
/>

@luangjokaj Though it's not a proper solution and may vary from host to host, still a nice hack. Thanks man! :+1:


[@Azure/eventgrid] Adding new events for EG Version 4.14.0

Packages impacted by this PR
@azure/eventgrid
API View To Approve
https://apiview.dev/Assemblies/Review/5d8f03952cfd409992e7ab62d145090d/f9a84720b15e461b988d7405a7538577?diffRevisionId=8c1f850364cb4018a1e65c579d6aded5&doc=False&diffOnly=True
Issues associated with this PR
NA
Describe the problem that is addressed by this PR
The EventGrid Service Team has added 5 new events. The SDK must be regenerated to include the code changes related to these 6 new events. The SDK minor version has been updated.

EventGridMqttClientCreatedOrUpdatedEventData
EventGridMqttClientDeletedEventData
EventGridMqttClientSessionConnectedEventData
EventGridMqttClientSessionDisconnectedEventData,
AppConfigurationSnapshotCreatedEventData,
AppConfigurationSnapshotModifiedEventData,

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
There are no specific/complex design scenarios for this task. It is a straightforward regenerate and some standard changes to the custom layer of the code.
Are there test cases added in this PR? (If not, why?)
No. This item is standard and we need not add test cases for every new events. The existing cases would be sufficient.
Provide a list of related PRs (if any)
https://github.com/Azure/azure-sdk-for-js/pull/26020 (This is the PR that adds similar events to the SDK in the 4.13.0 release)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
autorest --typescript swagger\README.md
Checklists

[X] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[X] Added a changelog (if necessary)

@xirzec @ellismg @jeremymeng Please review and approve the PR.
@lmazuel FYI

/check-enforcer evaluate

/check-enforcer override


Conflict with Serial on 2560

For testing purposes I changed the code to use serial port 3 on the arduino mega. Does the warning about not using the arduino Serial library for debugging apply on the mega given it is addressing a different serial port to DMXSerial?

Thanks!


chore(version): Bump to v4.0.0-rc09

Waiting on #2136

Not sure if intentional, but rc9 doesn't seem to have an official release tag on GitHub yet (even though it does install if you yarn add react-native-task-player@next).


empty commit, try to fix travis ci by fixing ufo

Don't merge, it's empty, just for triggering Travis CI.
Trying to fix Travis CI.

I don'


Proper name and private set for docs package

Apart of these changes, I have a question about adding docs directory to  package.json yarn workspaces array.
Docs are not part of the VSF app itself, so it's not important to install their dependencies for everyone. Also, this package is not going to be published to npm, so for me, it should be separated.

@pkarw eh, I asked the question there :D
@NataliaTepluhina I still want to know your point of view about workspaces.


Documentation unclear/inconsistent about rule names

Expected Behavior
On the rules list documentation page (https://pinterest.github.io/ktlint/latest/rules/standard), there is a great deal of inconsistency in how rules are named.  For example, trailing commas.
https://pinterest.github.io/ktlint/latest/rules/standard/#trailing-comma-on-call-site
The "configuration settings" block defines it as ij_kotlin_allow_trailing_comma_on_call_site.
The "rule id" is standard:trailing-comma-on-call-site.
The "suppress or disable" popup calls it ktlint_standard_trailing-comma-on-call-site.
It is not at all obvious which one is correct; I didn't even notice the difference until someone in Slack pointed it out to me.  Experimentally, I've found that only the first one actually works when I put it in my .editorconfig.  The others give a warning in my IDE that the property is not defined, which I assumed was simply because they are not part of the .editorconfig spec.
Also, the "suppress or disable" popup says to use = enabled, while the actual rule that works requires = true.
Because my IDE is rejecting ktlint_code_style as well, I'm not clear if that is actually being applied.  There's no lj_kotlin_ version of it, and that version is also marked as not-recognized in the editor.
Observed Behavior
I expect the docs to be consistent and accurate, not confusing.  I was instead confused.
Steps to Reproduce
See the docs page linked above.
Your Environment
# ./gradlew ktlintFormat --version

------------------------------------------------------------
Gradle 8.8
------------------------------------------------------------

Build time:   2024-05-31 21:46:56 UTC
Revision:     4bd1b3d3fc3f31db5a26eecb416a165b8cc36082

Kotlin:       1.9.22
Groovy:       3.0.21
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          21.0.3 (Amazon.com Inc. 21.0.3+9-LTS)
OS:           Mac OS X 14.5 aarch64

ktlint version: 12.1.1

It is not at all obvious which one is correct; I didn't even notice the difference until someone in Slack pointed it out to me. Experimentally, I've found that only the first one actually works when I put it in my .editorconfig. The others give a warning in my IDE that the property is not defined, which I assumed was simply because they are not part of the .editorconfig spec.

The naming standard used, differs per purpose. It is indeed not fully consistent due to (historical) limitations.

Also, the "suppress or disable" popup says to use = enabled, while the actual rule that works requires = true.

The correct usage is enabled and disabled. Value true and false to disable a rule are not recognized by ktlint. Does your .editorconfig contains a glob like [*.{kt,kts}]? See https://pinterest.github.io/ktlint/latest/rules/configuration-ktlint/
The .editorconfig plugin in Intellij IDEA indeed does not recognize the ktlint properties. But no worries, ktlint does recognize them. See https://youtrack.jetbrains.com/issue/IJPL-30188/EditorConfig-inspections-marks-ktlint-properties-with-The-property-is-not-supported

If I put any of these lines in the .editorconfig file, ktlint removes all trailing commas:
ktlint_standard_trailing-comma-on-call-site = enabled
ktlint_standard_trailing-comma-on-call-site = disabled
ij_kotlin_allow_trailing_comma_on_call_site = false

If I put this line in the file:
ij_kotlin_allow_trailing_comma_on_call_site = true

Then it adds trailing commas everywhere.
Yes, these rules are all under a [*.{kt,kts}] block.

I see.
The ktlint configuration settings (prefixed with ktlint) are set with enabled or disabled. When ktlint_standard_trailing-comma-on-call-site is enabled the ktlint rule uses the Intellij IDEA setting ij_kotlin_allow_trailing_comma_on_call_site to add/remove the trailing comma. The ij_kotlin_allow_trailing_comma_on_call_site is indeed set with value true or false.
When ktlint_standard_trailing-comma-on-call-site ktlint will not run the rule. Note that Intellij IDEA formatting will still apply based on setting ij_kotlin_allow_trailing_comma_on_call_site.
I hope this makes it more clear. If you have suggestions for improving the docs, please raise a PR.

I see no action to be taken on this. Code formatting regarding trailing comma's is working as expected. Docs can not be made more consistent without changing the code, and as of that cause breaking changes to all users who have configured it according to the docs.


Guard eunit include with ifdefs

Guard eunit include with ifdefs so it won't add dependency on eunit if checked with automatic dependency checkers.

Sorry for the delay and thank you for your contribution. Merged.


PE-3797: metadata cache using stash PoC

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/0trmkfv9d87b8
iOS release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:ios:06ea33a95a2e0d42ffce07/releases/756mbu5onm790

See: #1109


Add Horizon test Image

This PR focuses on creating horizon test image with all the required resources for horizon tests to run . And cleanup the resources once the tests have run successfully .

/ok-to-test

/approve


fix: beforeBreadcrumb discarding breadcrumbs on Apple platforms

Related: #99
Breadcrumbs on Apple platforms are discarded if the hook beforeBreadcrumb is not configured.
Due to optional chaining it treats it the same as
beforeBreadcrumb = {
  null
}

Closing in favor of #101 due to issues with env secrets not working when workflow is triggered by forks (e2e tests are failing)


can't run tests in docker container

@yegor256 after building an image(i did not change anything in the project), i tried to run tests using
docker run --rm cam make test but it resulted the error:
+++ tests +++

There are 56 tests in /cam/tests

before/test-layout.sh:
👍🏻 All test scripts have their live counterparts

before/test-executability.sh:
👍🏻 All .sh scripts are executable
Script '/cam/cam/lib/python3.12/site-packages/cffconvert/cli/validate_or_write_output.py' is not executable, try running 'chmod +x /cam/cam/lib/python3.12/site-packages/cffconvert/cli/validate_or_write_output.py'
❌ Non-zero exit code (TARGET=/cam/test-zone/before/test-executability.sh/target)
You can run this particular test in isolation: make test TEST=tests/before/test-executability.sh
make: *** [Makefile:78: test] Error 1

@dzhovi should be fixed, try again please


AS path prepending to influence Azure route selection

The article could help bring more clarity by adding information about the ability to use AS path prepending to influence Azure's route selection.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c1d3b93-4e51-b2ec-c779-d80313275297
Version Independent ID: 1811faf4-3a71-f037-6d08-6872ec5120a2
Content: Overview of BGP with Azure VPN Gateways
Content Source: articles/vpn-gateway/vpn-gateway-bgp-overview.md
Service: vpn-gateway
GitHub Login: @yushwang
Microsoft Alias: yushwang

@MikeDembek Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Thank you for you dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


fix: [lw-11767] close co sign drawer before resetting tx related states

Checklist

[x] JIRA - LW-11767
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes

Allure Report
allure-report-publisher generated test report!

processReports: ✅ test report for 858cbe74

passed
failed
skipped
flaky
total
result

Total
32
0
4
0
36
✅