KCL: Simulation tests don't tokenize anymore

There wasn't a lot of value add. We weren't really using these.

Looks like https://github.com/KittyCAD/modeling-app/pull/4540 merged when I approved it, so might need some updates.


Lazier genotypes (WIP)

These changes attempt to make genotypes lighter weight and thus less costly. I'm seeing significant speed ups on very wide VCFs, but haven't thoroughly vetted yet. I am certain there is more improvement in the overall structure of the VCF classes that is needed, but not quite sure where. Would greatly appreciate a second set of eyes.

Coverage decreased (-0.1%) to 63.989% when pulling 670e6d398940b1cd6d1416f924ab47405c71c90b on ernfrid:lazier_genotypes into 9ab58d999eb1af04262d0b361ab0b5e5d94237f3 on hall-lab:master.

I've run these changes through prune on ~840 samples and get the same answers but better performance. @abelhj also had looked this over and thought it looked ok. Merging...


[qBittorrent - mount cifs] Unable to apply new capability set

Expected Behavior

[cont-init.d] 92-mounts: executing...
[05:14:47] INFO: Mounting smb share...
[05:14:47] INFO: Network Disks mounting.. //192.168**/pms
[05:14:47] INFO: Mount //192.168**/pms
Creating /storage/storagecifs
[05:14:47] INFO: Success!
[cont-init.d] 92-mounts: exited 0.

Current Behavior

[cont-init.d] 92-mounts: executing...
[05:14:47] INFO: Mounting smb share...
[05:14:47] INFO: Network Disks mounting.. //192.168**/pms
[05:14:47] INFO: Mount //192.168**/pms
Creating /storage/storagecifs
Unable to apply new capability set.
[05:14:47] WARNING: Protection mode is ON. Unable to mount external drives!
[cont-init.d] 92-mounts: exited 0.

Unlike what the log says, the protection mode is disabled.
Possible Solution
As far as I can tell, this problem started appearing with the Core 2021.2.3. Same as with the Samba NAS addon problem you solved by adding a apparmor.txt. My guess would be to add the same file so the mount capability is added to the docker container running qbittorrent.
Steps to Reproduce
Start the addon with a networkdisks set up.
Context (Environment)
Rpi4
Core Version: core-2021.2.3
Supervisor Version: supervisor-2021.02.11
Operating System: Home Assistant OS 5.11
Addon version : <IP_ADDRESS>202101191832-7248-da0b276d5ubuntu18.04.1-ls113

Hi, thanks for the detailed analysis! Which addon is impacted? Thanks

Hi, my bad, I forgot the most obvious information. This issue concerns your qBittorrent addon. Thanks a lot for it by the way.

Thanks! What is the ls of the current version? It is the number at end of the addon version : ls116?
Thanks!

@alexbelgium
Great timming, I've the same issue
Just reloaded your repository but the new version is not available yet.
I'm using the Is113

That's why then, there is a ls116 since one or two days that includes the apparmor file. Shane that it is not visible for your, but lots of people have seen issues with their installations, including me, when updating to the latest home assistant version

It's very weird because I've just added your repository today and it came
with the old version.
Maybe you could just re-create the version?
On Sun, Feb 21, 2021, 3:20 PM Alexandre<EMAIL_ADDRESS>wrote:

That's why then, there is a ls116 since one or two days that includes the
apparmor file. Shane that it is not visible for your, but lots of people
have seen issues with their installations, including me, when updating to
the latest home assistant version
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alexbelgium/hassio-addons/issues/5#issuecomment-782874524,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQC4RYEHJG5KPBKVLZ4NMSTTAEQE3ANCNFSM4X654A7Q
.

I'm using the ls113 too. Can't seem to be able to access the ls116. Uninstalling the addon -> removing your repo -> adding it again -> still only ls113.

That's weird ls113 is several weeks old...
Please try something : go in the addon store, click Reload in the same menu that you add custom repos. The screen will go black, then addons will appear again.
Then check the supervisor log. You should have first the code of repo updates, the warnings if some addons have old values, and then the line saying that the refresh is completed. This looks like that. If you don't... Then it is an issue with the home assistant installation...
Another way to check if repo is up-to-date :do you see the ubooquity addon in my repo on HA? I've added it not long ago.
Third element to check : do other addons such as official or community versions update?
Thanks!
21-02-21 17:41:06 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/hassio-addons/repository repository
21-02-21 17:41:06 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/alexbelgium/hassio-addons repository
21-02-21 17:41:12 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of HassOS SSH port 22222 Configurator
21-02-21 17:41:12 INFO (MainThread) [supervisor.store] Loading add-ons from store: 111 all - 0 new - 0 remove
21-02-21 17:41:12 INFO (MainThread) [supervisor.store] Loading add-ons from store: 111 all - 0 new - 0 remove

@alexbelgium
For your First Point
21-02-21 18:19:43 INFO (MainThread) [supervisor.store] Loading add-ons from store: 93 all - 0 new - 0 remove
For the Second
Yes, I do see the Ubooquity
I've tried even your "Test" repo and there I can see a newer version but still not 116 but 114
For the Third
I don't have any adblocker (In fact I was planning to add it today, but I got focus on yours addon first :) )

Thanks that's already a good news! Version 114 should already implement apparmor so that should be good :) that's really strange that it updates to an old version of the addons! Well, let me know if 114 solves the mount issue at least that's already that... If I remember well the 116 version only solves an issue with the installation of the VueTorrent custom ui, and allows smbv1...

@alexbelgium
I do have a lot of warning, but I do believe that is just because they are low rating
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Samba NAS
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'auto_uart' is deprecated, use 'uart'. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'devices' use a deprecated format, the new format uses a list of paths only. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of FTP Backup
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Scrutiny
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Emby beta NAS
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Samba NAS
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'auto_uart' is deprecated, use 'uart'. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'devices' use a deprecated format, the new format uses a list of paths only. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Samba NAS
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'auto_uart' is deprecated, use 'uart'. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'devices' use a deprecated format, the new format uses a list of paths only. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of FTP Backup
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Scrutiny
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Emby beta NAS
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Samba NAS
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'auto_uart' is deprecated, use 'uart'. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'devices' use a deprecated format, the new format uses a list of paths only. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 18:22:57 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of RPi MySensor Gateway

@alexbelgium
Quickly question
Do you know if would be possible to map an external drive that is already in use by another addon ?
I've two external hard-drive connect and shared by samba using dianlight addons
https://github.com/dianlight/hassio-addons/tree/master/sambanas
Since I can't connect to them by SAMBA, could I map them without remove it from the samba sharing with ls113 ?
Or maybe I should use NextCloud from your repository, would then work ?

Hi, I've converted file endings from crlf to lf, could your I please try
again to reload the repos?
Regarding your question, there is no issue mapping a same drive in
different addons. I had removed this option starting from ls114 to allow
the addon to have an higher security score, however it will work if you
disable protected mode. You need to specify the local name, probably sda1
or sdb1 depending on the slot used. I also use sambanas to map my disks to
smb (BTW, did you correctly received the update to nas8 Today?), then I
mount locally a second time the sda1 in my emby addon as direct mount is
faster than smb.
Nextcloud won't help : you can mount external,drives such as smb in
nextcloud with the external disk app, but you can't share it with other
addons...
Le dim. 21 févr. 2021 à 19:56, Jonathan Lima<EMAIL_ADDRESS>a
écrit :

@alexbelgium https://github.com/alexbelgium
Quickly question
Do you know if would be possible to map an external drive that is already
in use by another addon ?
I've two external hard-drive connect and shared by samba using dianlight
addons
https://github.com/dianlight/hassio-addons/tree/master/sambanas
Since I can't connect to them by SAMBA, could I map them without remove it
from the samba sharing with ls113 ?
Or maybe I should use NextCloud from your repository, would then work ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alexbelgium/hassio-addons/issues/5#issuecomment-782906927,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRB2GL6UCYLIZT5STDPEWDTAFJNHANCNFSM4X654A7Q
.

After reload :

21-02-21 19:28:04 INFO (MainThread) [supervisor.homeassistant.api] Updated Home Assistant API token
21-02-21 19:28:51 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/hassio-addons/repository repository
21-02-21 19:28:51 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/dianlight/hassio-addons repository
21-02-21 19:28:51 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/alexbelgium/hassio-addons repository
21-02-21 19:28:51 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/sabeechen/hassio-google-drive-backup repository
21-02-21 19:28:51 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/adamoutler/HassOSArgonOneAddon repository
21-02-21 19:28:51 INFO (MainThread) [supervisor.store.git] Update add-on https://github.com/home-assistant/addons repository
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Emby beta NAS
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Scrutiny
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Samba NAS
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'auto_uart' is deprecated, use 'uart'. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'devices' use a deprecated format, the new format uses a list of paths only. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of ArgonOne Active Cooling
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Emby beta NAS
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Scrutiny
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of Samba NAS
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'auto_uart' is deprecated, use 'uart'. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'devices' use a deprecated format, the new format uses a list of paths only. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of RPi MySensor Gateway
21-02-21 19:28:53 WARNING (MainThread) [supervisor.addons.validate] Add-on have full device access, and selective device access in the configuration. Please report this to the maintainer of ArgonOne Active Cooling
21-02-21 19:28:53 INFO (MainThread) [supervisor.store] Loading add-ons from store: 86 all - 0 new - 0 remove
21-02-21 19:28:53 INFO (MainThread) [supervisor.store] Loading add-ons from store: 86 all - 0 new - 0 remove

I see ubooquity  but still ls113 though.

@alexbelgium
Thank you for sharing that
Yes, I got the NAS8 (it has a bigfix reported by me :) - I kind of took the day to work on HA)
I've reloaded and so far, no lucky
I even removed the addon, removed the repository, restart the HA, add the repository and still 113

OK, then the only solution I see is that I'll duplicate it is my other repo names hassio-addons-test. It will be the latest version...

Oops wrong button

From what I get it's more of a problem with HA's supervisor than with your addon so clsing this issue wouldn't be wrong. I hope they work that. Thanks a lot for your efforts.
I'm gonna use your other repo then.

Argh this is so frustrating that it fails without an error message, and showing files that are several weeks old! I've duplicated the qbittorrent addon under a new slug at https://github.com/alexbelgium/hassio-addons-test
This this it HAS to work ;-)

Yup, using https://github.com/alexbelgium/hassio-addons-test I get the ls116 version. Thank you !
Yes I was wondering about the versionning convention. Maybe it doesn't like letters, I don't know :S Never having created an addon myself I can only try to guess.

Don't know if that helps but I noticed that HA can't access the changelog of the qBittorrent addon stored in https://github.com/alexbelgium/hassio-addons.
With https://github.com/alexbelgium/hassio-addons-test, it's OK.

Well the thing about naming convention is that it is based on the work of another team named linuxserver.io
I use their image, and create the addon in a way that their image integrates within home assistant, and make links to allow configuration of some key components.
It allows two things : distribute very quickly addons, but more importantly that I can auto-update my addons (using the "updater" addon) so that whenever linuxserver makes an update my addon is automatically updated ! this allows to have always up-to-date addons (for example the bitwarden addon was updated the day the new version got out) compared to manually updated addons that can take several months to be updated (the bitwarden addon wasn't updated from june to around december of last year, breaking functions with apps).
However, to do that I need to keep the same nomenclature as them... Thus the long names :-)

Yup, using https://github.com/alexbelgium/hassio-addons-test I get the ls116 version. Thank you !
Yes I was wondering about the versionning convention. Maybe it doesn't like letters, I don't know :S Never having created an addon myself I can only try to guess.

You gave me an idea :-) I've updated the version from the main repo to a much shorter name, with the same content. Could you please test if it works? Thanks! :-)

I used "Reload" but the qBittorrent addon still indicates that "<IP_ADDRESS>202101191832-7248-da0b276d5ubuntu18.04.1-ls113" is its current version.

@alexbelgium
Same here
<IP_ADDRESS>202101191832-7248-da0b276d5ubuntu18.04.1-ls113

@alexbelgium
Another question (I'm not sure if is it releated or not but, there here goes)
on 116
I've added the share as described on your documentation however after the download been complete I don't see the file into the volume
(I've also opened the terminal and used mount to see if the volume was mapped and got no results)
That's is the log of the addons
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 01-envfile: executing...
[cont-init.d] 01-envfile: exited 0.
[cont-init.d] 10-adduser: executing...
      _         ()
     | |  ___   _    __
     | | / __| | |  /  \
     | | \__ \ | | | () |
     |_| |___/ |_|  \__/

Brought to you by linuxserver.io
To support LSIO projects visit:
https://www.linuxserver.io/donate/
GID/UID
User uid:    0
User gid:    0
[cont-init.d] 10-adduser: exited 0.
[cont-init.d] 30-config: executing...
chown: cannot access '/config/data/qBittorrent': No such file or directory
[cont-init.d] 30-config: exited 0.
[cont-init.d] 91-configuration.sh: executing...
[21:02:01] INFO: Downloads can be found in <\<IP_ADDRESS>\120gbssd>
[21:02:02] INFO: Whitelisted subsets will not require a password : localhost,<IP_ADDRESS>,<IP_ADDRESS>/16,<IP_ADDRESS>/16
[21:02:02] INFO: WEBUI username set to admin
[21:02:02] INFO: Default username/password : admin/adminadmin
[21:02:02] INFO: Configuration can be found in /config/qBittorrent
[cont-init.d] 91-configuration.sh: exited 0.
[cont-init.d] 92-mounts: executing...
[21:02:03] INFO: Mounting smb share(s)...
[21:02:03] INFO: ... \<IP_ADDRESS>\120gbssd successfully mounted to /mnt/\<IP_ADDRESS>\120gbssd
[cont-init.d] 92-mounts: exited 0.
[cont-init.d] 99-custom-scripts: executing...
[custom-init] no custom files found exiting...
[cont-init.d] 99-custom-scripts: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
QBITTORRENT.LOG
(I) 2021-02-21T21:01:53 - UPnP / NAT-PMP support [OFF]
(N) 2021-02-21T21:02:03 - qBittorrent v4.3.3 started
(N) 2021-02-21T21:02:03 - Using config directory: /config/qBittorrent/
(I) 2021-02-21T21:02:03 - Trying to listen on: <IP_ADDRESS>:6881
(N) 2021-02-21T21:02:03 - Peer ID: -qB4330-
(N) 2021-02-21T21:02:03 - HTTP User-Agent is 'qBittorrent/4.3.3'
(I) 2021-02-21T21:02:03 - DHT support [ON]
(I) 2021-02-21T21:02:03 - Local Peer Discovery support [ON]
(I) 2021-02-21T21:02:03 - PeX support [ON]
(I) 2021-02-21T21:02:03 - Anonymous mode [OFF]
(I) 2021-02-21T21:02:03 - Encryption support [ON]
(I) 2021-02-21T21:02:03 - IP geolocation database loaded. Type: DBIP-Country-Lite. Build time: Mon Feb 1 01:07:58 2021.
(N) 2021-02-21T21:02:03 - Using built-in Web UI.
(N) 2021-02-21T21:02:03 - Web UI translation for selected locale (en_US) has been successfully loaded.
(N) 2021-02-21T21:02:03 - Web UI: Now listening on IP: *, port: 8080
(I) 2021-02-21T21:02:03 - Successfully listening on IP: <IP_ADDRESS>, port: TCP/6881
(I) 2021-02-21T21:02:03 - Successfully listening on IP: <IP_ADDRESS>, port: UDP/6881
(N) 2021-02-21T21:02:03 - 'Tropa.de.Elite.2007.BRAZiLiAN.ENGSUB.DVDRip.XviD' restored.
(I) 2021-02-21T21:02:04 - Detected external IP: <IP_ADDRESS>

Hi, the share must be in the format : "//SERVER/SHARE"
Here you wrote : "\<IP_ADDRESS>\120gbssd" I believe

@jonathanicq for your information :
mount will return results depending on the docker container it's used in. So you should first use docker ps to get the name of the container running qBittorrent (last column, should something like addon_XXX_qbittorrent").
You can run commands in the container using docker exec -it addon_XXX_qbittorrent /bin/bash (replace XXX with correct value). Using mount should now show you coherent results. You can exit using... exit ;)

@alexbelgium
I've setup as you share and downloaded a file but still don't know where it went.
@Marnalas
Thank you, i'll try that.

It went in the download path that you mentioned in the addon configuration. If you wrote //<IP_ADDRESS>/120gbssd, the files will be within the container in /mnt/120gbssd. To access it from somewhere else, you need to mount again the smb share. You could check on your shared drive if the file is there.
If you are not happy where the file was downloaded, you can change the download path from within the WebUI and it will move the file.
If you want to download to a place accessible by other local containers, you need to download in the /media or /share folders.

@alexbelgium
As I've shared before, I have a external disk shared by SAMBA NAS from dianlight
from my laptop I can access it by \<IP_ADDRESS>\120gdssd
Once I use your addons, the share still ON so it does not stop the actual SMB (and I believe that it should not do it, right ?)
So, I saved that path as the target for the download and I can see it on the WebUI
However, once the download is done I can't find the file
PS.: I do have several files already there

Your laptop is on windows I suppose - so the address is indeed \<IP_ADDRESS>\120gdssd ; on linux the address will be //<IP_ADDRESS>/120gdssd
Once the drive is shared by SAMBA NAS, any addons can access it as long as the addon is started.
It is complex for me to troubleshoot without seeing your system. As I understand, you have set the network share to //<IP_ADDRESS>/120gdssd , and the download path to /smb/120gdssd ? Then it should work... Have you checked the nomenclature of the path? and by right clicking on the download, that it is indeed in the right folder?
To troubleshoot things like that, I usually install the Portainer addon. If you go into the advanced options and remove the addons from the hidden elements, it allows to gain console access into the running container and troubleshoot what is actually happening. For example, to do "ls -l /mnt/120gdssd" and check that the mounted files are indeed there

@jonathanicq

ssl: true
certfile: fullchain.pem
keyfile: privkey.pem
whitelist: 'localhost,<IP_ADDRESS>,<IP_ADDRESS>/16,<IP_ADDRESS>/16'
SavePath: /mnt/pms
Username: **
smbv1: false
PUID: 0
PGID: 0
networkdisks: //192.168**/pms
cifsusername: **
cifspassword: **
TZ: ''

If it can help you this is my config. I use it right now and it works. My files are correctly downloaded on the mounted partition.
I use windows 10 on my PC so my SMB is accessible via \192.168**\pms through the file explorer (windows uses \ instead of /). On a linux based OS, the same SMB would be accessible with //192.168**/pms, that's why I set it up like this in the addon's config (home assistant OS is linux based).
As @alexbelgium said, the addon creates a pms directory (in my case)  in /mnt and then use it to mount the SMB partition. That's why I set up /mnt/pms as my default SavePath. When I download a new torrent I complete this path accordingly in the qBittorrent popup (/mnt/pms/movies for example). Right now I can check that my files are correctly downloaded from my Windows 10 PC using \192.168**\pms\movies. If I wanted to check it in the terminal I would have to use the commands as following :
docker exec -it addon_XXX_qbittorrent_ha /bin/bash
ls /mnt/pms/movies
exit

Once I use your addons, the share still ON so it does not stop the actual SMB (and I believe that it should not do it, right ?)

With Home Assistant OS, addons run in there own docker container. It's almost like each addon runs on a separate machine/environment. That means that a drive mounted with one addon is not mounted for another one (except if you mounted it in /media or /share because these forlders are common to all docker containers).
 Both the qBittorrent and the plex addons have to mount the same drive and they can do so without breaking the mount of the other addon because they are "dockerised".
I hope this gives you a clue about what you should set up in your situation.

@ alexbelgium
I hope that what I wrote is correct. Feel free to correct me. I don't want to mislead anyone.
Should I close this issue ? The base problem is fixed. I am affraid that closing would prevent us from helping @jonathanicq and force him to open another issue. I am not used to github issue system so I might be wrong about that.

It's solved!!! :-D
Please try a repo refresh and I'm pretty sure you'll see addon ls177 (updated this morning!)!
There was an hidden template file that referenced ls113...

Just reloaded and I can confirm that the current version is indicated as 14.3.3-ls117-rev2.
I'll uninstall the one from teh test repo and install the one from your main repo right now.

@ alexbelgium
I hope that what I wrote is correct. Feel free to correct me. I don't want to mislead anyone.
Should I close this issue ? The base problem is fixed. I am affraid that closing would prevent us from helping @jonathanicq and force him to open another issue. I am not used to github issue system so I might be wrong about that.

Thanks very much you're 100% right on what you said. And indeed using terminal to check inside addons is easier than portainer!

Installation finished. Everything runs smoothly ! Thanks a lot :)
Everything else is fixed too. The addon has the correct icon (didn't have one before) and the changelog is correctly showed.

@Marnalas
You rock man, really !
I was with my mindset on windows where the share is not visibly "mounted"
I've changed the configuration to add the smb volume thorough the mnt path and it worked
@alexbelgium
I've also downloaded the ls117-rev2 with success
I do agre with @Marnalas  that we can close this ticket
Thank you All


Not working with bartender in wotlk

hello i would love to use this addon in wrath but it doesnt work while using bartender simultaneously

Hi @compozed1 ; this is because the retail bartender code differs from the old wotlk one. Unfortunately I don't have access to wotlk so I cannot easily fix this.
I'll see what I can do- It'll probably take some time, but in the meantime I'd be willing to accept a fix for this in the form of a PR.


removing base-component and fixing lint errors

@keybase/react-hackers here's a little cleanup pr

:+1: %C

Looks legit, :shipit:.


added test for bytes string in skip

The pull request #364 titled "added test for bytes string in skip" was created by the user "shairubin".
Summary:

This pull request aims to add a test for byte strings in the skip functionality.
It is currently open and targets the main branch from the feature branch 363-support-byte-strings.

Would you like more detailed information about the changes in this pull request?


Ardupilot log v3

Created new PR as old one is full of comments.

No more TOCTOU
New log file structure - starting with increasing XXX-date-time
Checkpatch compliant

@peterbarker @zehortigoza @lucasdemarchi @fnoop Could you please review this new version? Tks!

@edersondisouza I saw a couple of bugs there but I didn't take note. I'll apply, fix and go through a test round. Thanks.

@edersondisouza I think I commented on everything I had seen and was planning to fix myself. Since @peterbarker added more comments, if left everything for you ;-)

v4 on #48

On Tue, 28 Mar 2017, Ederson de Souza wrote:

You mean, I have received packets 1 and 3, packet 5 arrives, I'll only send
nack for packet 4?

Yes.

If so, that's true, but a nack for packet 2 was already sent. How important
is to keep resending nacks?

It isn't; ArduPilot send you a packet until you ack it :-)


chore: update code style

Description

Linked Issues
Preview / Screenshot

Photo
Video

Checklist

[ ] I have followed commit guideline to create PR title (https://conventionalcommits.org/en/v1.0.0/)

📝 Changed routes:

/404
/auth

(view full size)
(view full size)

/
/intro

(view full size)
(view full size)

/join/[id]
/privacypolicy

(view full size)
(view full size)

And 2 other routes:

/reset-password
/room/[id]

Commit a096e3fafc05afbecd0dc273ef4cec9f492b914a (https://spoker-7jml43i65-sozonome.vercel.app).


[Question] How set  CollectionName to TextMemoryPlugin

Context / Scenario
I have a scenario where my entry point is FunctionCallingStepwisePlanner.
I added some plugins with native functions for mathematic calculates and the plugin TextMemoryPlugin.
My memory is a Qdrant database with a collection called vector_db.
This memory is passed to planner config and TextMemoryPlugin.
Question
I think that I don't have any special.
If the stepwise planner calls automatically to the plugins registered.
How to tell to the planner that TextMemoryPlugin uses my collection_name from Qdrant?
By default, I see that the plugin has a private const DefaultCollection
Thanks a lot.

Using the SK plugin available here the collection name can be passed using the index parameter. You can also set the default index via MemoryPlugin ctor defaultIndex parameter.


onnx exported problem

May I ask how you dealt with the “RuntimeError: Unknown number type: complex”  problem caused by torch.istft when exporting the onnx model

torch.istft is currently not support by onnx and still in development, see: https://github.com/pytorch/pytorch/issues/81075

Hi @unparalleled-ysj, I'm sorry to be late...
torch.istft is currently not supported by onnx, so please exclude only the istft part when exporting to onnx.
@Jackiexiao, thank you for your comment!

Maybe this URL will also be useful for torch onnx.

I'm confused, we have to pass istft function to get wav, if we exclude istft part, we can't get result

@Jackiexiao
I think that it is possible to export the processes except for istft using onnx. During inference, I think that wav can be obtained by combining onnx and torch istft code.

ok, I get, looking forward to get istft support in torch nightly, so we just need onnx during inference

You can use https://github.com/MasayaKawamura/MB-iSTFT-VITS/blob/df2f8d3063f83c22e04d2c0066fa2129d26da9a1/stft.py#L144 instead of https://github.com/MasayaKawamura/MB-iSTFT-VITS/blob/df2f8d3063f83c22e04d2c0066fa2129d26da9a1/stft.py#L197 when exporting, which can successfully export the model as onnx, but at the same time, there will be rattling noise in the speech. After my ablation comparison, the problem still appears in the istft export (because the original model has no problem)

@Jackiexiao @MasayaKawamura refer to https://github.com/pytorch/pytorch/issues/31317#issue-538490027

thx

Hi @MasayaKawamura
Can you share your code to save onnx model, i  got some problems when i convert to onnx.

FYI see: https://github.com/wenet-e2e/wetts/blob/main/wetts/vits/export_onnx.py but you can't export istft vocoder to onnx here @FanhuaandLuomu

FYI see: https://github.com/wenet-e2e/wetts/blob/main/wetts/vits/export_onnx.py but you can't export istft vocoder to onnx here @FanhuaandLuomu

hi @Jackiexiao,
I have tried the above script to export but I have had no success. Would you mind sharing your export code?

@abylouw it just work in original vits(not for mbistft, but they work the same way, except the vocoder part), and wetts repo has all code you need

You can use
https://github.com/MasayaKawamura/MB-iSTFT-VITS/blob/df2f8d3063f83c22e04d2c0066fa2129d26da9a1/stft.py#L144
instead of
https://github.com/MasayaKawamura/MB-iSTFT-VITS/blob/df2f8d3063f83c22e04d2c0066fa2129d26da9a1/stft.py#L197
when exporting, which can successfully export the model as onnx, but at the same time, there will be rattling noise in the speech. After my ablation comparison, the problem still appears in the istft export (because the original model has no problem)

Do we need to use the class STFT instead of TorchSTFT during the training in this case?

@Jackiexiao I think that it is possible to export the processes except for istft using onnx. During inference, I think that wav can be obtained by combining onnx and torch istft code.

I have tried to split the MB-iSTFT-VITS into this two parts and the former transfered into onnx, it is succeed.  but as to the MS-iSTFT-VITS, I have to split the model into three parts, which case the first and the third part should be transfer into onnx models. as to the third part, the multi-band filter,  the  self.multistream_conv_post layer there is a weight_norm,  should I keep the weight_norm layer there?  I saw your  remove_weight_norm function in the class did not remove this part. If the weight_norm can be removed during transfer into onnx, should I just put the "dec.multistream_conv_post.weight_v" value in the checkpoint , into my self defined third model part?

Do we need to use the class STFT instead of TorchSTFT during the training in this case?

You do not have to use STFT during training, only during export. See here
https://github.com/alphacep/MB-iSTFT-VITS2/commit/29c91d478bc16e653cd5de7c9163e2ba45ed7c6c
see also
https://github.com/FENRlR/MB-iSTFT-VITS2/issues/3

在这种情况下，我们在训练过程中是否需要使用 STFT 类来代替 TorchSTFT ？

您不必在训练期间使用 STFT，只需在导出期间使用。看这里
alphacep/MB-iSTFT-VITS2@ 29c91d4
也可以看看
FENRlR/MB-iSTFT-VITS2#3

I used this code to transfer onnx to process the pre-trained model provided, why did I report this error：AttributeError: 'ResidualCouplingLayer' object has no attribute 'remove_weight_norm'

在这种情况下，我们在训练过程中是否需要使用 STFT 类来代替 TorchSTFT ？

您不必在训练期间使用 STFT，只需在导出期间使用。看这里
alphacep/MB-iSTFT-VITS2@ 29c91d4
也可以看看
FENRlR/MB-iSTFT-VITS2#3

I used this code to transfer onnx to process the pre-trained model provided, why did I report this error：AttributeError: 'ResidualCouplingLayer' object has no attribute 'remove_weight_norm'

No, the STFT from this project, wich is the same with the one from the iSTFTNet project, is not good for onnx model exporation.
it can help generate a onnx model for inference, but this model will failed for some input cases. and  even for those success, the generated wavform will contains some noise.


Circular Dependency when API served out of /api in the URL

Our api is exposed at /api/... in our running application. When we run ramldoc it generates an api.raml that references api.raml, creating a circular dependency. I believe this can be mitigated by allowing the outputFileNamePrefix to be configurable in build.gradle.

Thanks for reporting the issue - seems like I overlooked this.
I will try to come up with a fix very soon.

Please check the new version 0.3.0 there is a new outputFileNamePrefix configuration option to customize the name of the top-level RAML file. Additionally we now check that a group file will not have the same name as the top-level file. So it should also work for you without adding this configuration.


Process.Start changes

Process.Start changed too -- on .NET Framework, UseShellExecute defaulted to true and on .NET Core, it's false.
This means that programs that used Process.Start("https://dot.net"); won't work anymore. They now need a ProcessStartInfo.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f0f19516-254e-d701-1cd3-d2cf4ddac6e5
Version Independent ID: dc951b71-083e-6127-99a6-e1278ce8c044
Content: Breaking changes, .NET Framework to .NET Core 3.0 - .NET Core
Content Source: docs/core/compatibility/framework-core.md
Product: dotnet-core
GitHub Login: @gewarren
Microsoft Alias: mairaw

This is correct. We did put a note in the API doc here and it should be in the list of breaks between .NET Framework and .NET Core.
Here's the template:
Change in default value of UseShellExecute
UseShellExecute on the ProcessStartInfo class has a default value of false on .NET Core. On .NET Framework, it defaults to true.
Version introduced
.NET Core v2.1. (In earlier versions of .NET Core, UseShellExecute was not implemented for Windows.)
Old behavior
On Windows, Process.Start(...) could be used to launch an associated application indirectly. For example Process.Start("mytextfile.txt") might launch notepad, and Process.Start("https://microsoft.com") might launch the browser.
New behavior
By default, associated applications cannot be launched in this way. You must pass to Process.Start(...) an explicit path to the executable file.
Reason for change
This makes starting processes faster by default.
Recommended action
If you rely on the old behavior, change your Process.Start(..) call to pass a ProcessStartInfo object with UseShellExecute set to true.
Category
CoreFX
Affected APIs
Process.Start
ProcessStartInfo

Issue metadata

Issue type: breaking-change

We typically cover these sort of changes in the API docs. I think we should move this to the dotnet-api-docs repo since the breaking change doc was done specifically to cover some Winforms scenarios (you can see see it has already been moved and modified to make that more clear).

@PriyaPurkayastha can you advise? This should be in the API docs linked above, yes, but it should also be in some grand "breaking changes from .NET Framework" topic and @PriyaPurkayastha was figuring out which that topic is.
This breaking change has come up numerous times so it should certainly be in such a centralized topic.

I am working on a strategy to document .NET Framework->.NET Core breaking changes. There will be three aspects - finding existing documentation for APIs throwing PNSE(or generating a new list if the old list is no longer available), adding link to .NET Framework tech not available in .NET Core and adding new breaking changes(such as this Process.Start one) for newly created GitHub issues that are not covered by the earlier two existing docs. @mairaw I have chatted with @gewarren about this last week and told her that we will sync up again sometime this week or early next week. I will make sure to include you in that discussion. The .NET Framework to .NET Core 1.x/2.x was not on my radar until now, but with the new issues cropping up we might need to tweak the doc structure to accommodate these breaking changes.

Sounds good @PriyaPurkayastha. As long as I know what's the plan, I'm good.


ENH: improve datetime string parsing with CustomBusinessDay

Currently CustomBusinessDay requires a strict format for holiday definition
CustomBusinessDay(holidays=['2014-05-12'])

but the following would raise a ValueError:
CustomBusinessDay(holidays=['5/12/2014'])

this PR makes the date parsing easier and adds a unit test

@mortada can you revisit this? I would rather see this in the contstruction methods of the holidays than here.

I think this is covered by the calendar option, would accept an example / docs that clarify things though

@jreback I agree, this should be closed, thanks


Changing constants (2014 edition)!

Reported by hansolsson on 30 Oct 2015 08:48 UTC
This is similar to #1266, but we now have even newer (and slightly better) values from 2014
http://physics.nist.gov/cgi-bin/cuu/Category?view=pdf&Universal.x=94&Universal.y=10
http://physics.nist.gov/cuu/Constants/Table/allascii.txt
The next time the change will likely be more fundamental (making some constants really fixed) based on a redesigned SI-system.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1813

Comment by beutlich on 4 Nov 2015 10:44 UTC
Resolved by 36f2eac72b0e0bec79dab790447a316f2fa42f3b: Adapted all constants of nature to the codata 2014 values as recommended in the ticket. The following constants have been adapted:
Faraday constant
Newtonian constant of gravitation
Planck constant
Boltzmann constant
Molar gas constant
Stefan-Boltzmann constant
Avogadro constant

Changelog modified by beutlich on 4 Nov 2015 10:44 UTC
Constants of nature adapted to 2014 values


Core: Unify __NO_INIT macro across toolchains

This needs to be aligned with the linker scripts. It is going to break existing implementations based on the new macro.
https://github.com/Open-CMSIS-Pack/devtools/tree/main/tools/projmgr/templates

It only impacts ac6_linker_script.sct and it could be made that both .bss.noinit and .noinit are supported.
Actually, it would be best that supported are .bss.noinit* and ,noinit*, as for example Fault component uses section name .noinit.fault .
BTW, gcc_linker_script.ld and clang_linker_script.ld do not contain provisions for the .noinit section at all.


bug(mat-slider): when mat-slider has parent with .mat-accent it will not show the primary color

Reproduction
Steps to reproduce:
https://stackblitz.com/edit/angular-ma9v9u?file=src%2Fapp%2Flist-single-selection-example.html
Expected Behavior
mat-slider with color=primary should display primary color, nomatter where its used.
Actual Behavior
If parent has class mat-accent it will make the slider accent color.
Solution
The solution is obvious:
https://github.com/angular/components/blob/d4f2fa6301e4878fec838a7efa2dd094576f9665/src/material/slider/_slider-theme.scss#L54
this here wins over mat-primary ... Im asking if other components are programmed in this same "general selector fashion"
Environment
latest stackblitz from docs (see date of this post)

While I agree that this is kind of weird, I don't think we will do anything to change it. It's somewhat unexpected to put a slider inside of another form control that supports the color input. In particular, putting a slider into a selection list or chip would be invalid from an accessibility perspective.

This can happen if a slider is put inside a tab group with an explicit color. Reopening.

Thank you @crisbeto, I can confirm, it will happen with a tab with color accent. It will also happen with a slider inside a toolbar.
It seems NOT to happen with vert./hor. stepper.


Make WebGLContext public or a function to clear the array

Feature request
I have an issue with WebGL contexts (canvases) filling up the browser. We have a tab system where we switch between instances. Each time we switch to a new tab, 7 canvases are added to the context and at some point we hit:
WARNING: Too many active WebGL contexts. Oldest context will be lost.
We have integrated Sigma.js into an Angular application and when we swap tabs, we have added the following the to ngOnDestroy lifecycle:
this.renderer.clear();
this.graph.clear();
this.renderer.kill();

But the contexts are still alive and the garbage collector has a hard time cleaning fast enough. I have added a workaround to refresh the application automatically after switching between 5 instances, but this is not a good solution.
Describe the solution you'd like
Is it possible to make some sort of functionality to remove the contexts when calling the kill() method? Or try to set this.webGLContexts = [] at the end of the kill() method? I have a theory this could help the garbage collector kick in faster.
I may experiment with the solution myself - when I have the time - but I wanted to raise our problem here to see if others are experiencing the same and may have found a solution.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Here is a snippet of 35 canvases after 5 clicks.

Hello @AlexanderFalk. I am starting to investigate the issue. Some useful references for later:

https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_lose_context/loseContext
https://github.com/mapbox/mapbox-gl-js/issues/2656

I am not sure whether there is a perfect solution here. You might want to keep a pool of Sigma renderers but it might be tricky if you need to change their containers on the fly. A pool of webgl context might be a solution also but this is not trivial. I will experiment with the WEBGL_lose_context first.

I just made some attempts using the WEBGL_lose_context extension and 1. it does not free the resources and 2. it outputs warning in the console. I am not sure whether this is a good solution frankly. #1280 was merged and will be part of the next release though. So if you manage a pool of sigma along with their containers (you can hide them to avoid destroying/creating them), I guess it could help you manage your use case?

@Yomguithereal thanks for answering. I will differently check out #1280 . This may be helping us out 👍.

@AlexanderFalk can you report whether the #.setGraph method of v2.4.0 addresses your issue?


Sever Property file generation seems to be incorrectly escaping special characters

When configuring my docker-compose configuration with the following environment property:
LEVEL_TYPE: 'gardenofglass:gardenofglass.'
The generated server.properties file sets the level-type value as follows:
level-type=gardenofglass\:gardenofglass.
It seems to be escaping the semicolon, but not removing the forward slash /.
This is causing world generation to behave incorrectly. Trying to manually correct the value just has this overwritten with the correct one. (even if omitting the environment variable)

That is standard java properties file behavior:
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Properties.html#store(java.io.Writer,java.lang.String)

Are you sure that trailing period isn't the problem?


zqd archivestore: status code 502 error

We've been seeing this error periodically in the zapi tests for master continuous delivery tests (e.g. https://github.com/brimsec/zq/runs/1723942257?check_suite_focus=true)
The test fails with an exit code 1. Combing through the log artifacts of the test run, there's this curious warning message:
{"level":"warn","ts":1611002727.443269,"logger":"core","msg":"Error writing response","personality":"all","request_id":"64","error":"status code 502: "}

In the next log line the same request "64" exits with status code 200:
{"level":"info","ts":1611002727.4433365,"logger":"http.access","msg":"Request completed","request_id":"64","host":"localhost:9867","method":"POST","proto":"HTTP/1.1","remote_addr":"<IP_ADDRESS>:43522","request_content_length":349,"url":"/worker/rootsearch?format=zng","elapsed":2.102102447,"response_content_length":988,"status_code":200}

The success status code of the http response doesn't mean anything really- the success status code is generated at the start of a search request and does not reflect if an error occurred during the search.
Still not sure where the error is coming from. A good first might be to enable stack traces on warning log messages and above. Would also be nice to have the request_id persisted between root->worker requests.

I am guessing this is related- at the same time of this bug we also see an error "write: broken pipe" in the log for a worker:
{"level":"warn","ts":1611002727.4493227,"logger":"core","msg":"Error writing response","personality":"worker","request_id":"56","error":"write tcp <IP_ADDRESS>:9867-><IP_ADDRESS>:42678: write: broken pipe"}

I am guessing this is related- at the same time of this bug we also see an error "write: broken pipe" in the log for a worker:
{"level":"warn","ts":1611002727.4493227,"logger":"core","msg":"Error writing response","personality":"worker","request_id":"56","error":"write tcp <IP_ADDRESS>:9867-><IP_ADDRESS>:42678: write: broken pipe"}

Closing as zqd archivestore no longer exists.


What should be used instead of an withTableSettings.renderControls ?

I see that the prop renderControls has been deprecated in the release 6.4.
What should I use instead to add some buttons (example: Reset) ?
https://github.com/gravity-ui/uikit/releases/tag/v6.4.0

answered in #1861


awesimsoss time-stamps give the end of the frame-reads and not the middle

The time stamps returned by awesimsoss are the ones at the end of each frame-read. However, the code should return time-stamps which are at the middle of each frame-read (in theory it should be the time weighted by the flux during a frame-read, but this is not possible to measure).
The middle time-stamps are, I believe, the most representative time for a given frame-read. The easiest way to see this is in the limiting case in which you only have two out-of-transit baseline points and one point taken exactly in-transit. Imagine a transit lasts a frame-time; then, I believe it makes sense for the in-transit point to have the middle of the time spent reading the data and not the time stamp at the end of the frame-time in order for that dataset to make sense.
This is also important for users that want to sample "real" transit lightcurves accounting for, e.g., the finite frame-read times which would smear out the transit lightcurves at the end. It is assumed in these supersampling schemes (see, e.g., https://arxiv.org/abs/1004.3741) that the time-stamps are in the middle of the read. batman also assumes the same to perform supersampling (https://www.cfa.harvard.edu/~lkreidberg/batman/tutorial.html#supersampling).

Fixed in #73


(WIP) Upgrade to Nearley 2.15

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>

Coverage remained the same at 91.277% when pulling 12f38c5cdfa98b9f2491c283f2eba8b80bd304c1 on jeromesimeon:js-chore-nearley-2.15 into 6711b222f7258fb4af11a93521c853dd701d224b on accordproject:master.

@dselman This PR now passes all cicero-template-library tests and is ready to be merged.

It does rely on a patch for a bug/regression in Nearly 2.14 and later. See the open issue at https://github.com/kach/nearley/issues/413


"Channel reserve too high" message

This seems to happen when I try to sweep all my funds out. Payments that leave dust are sometimes successful (putting aside frequent "timeouts"), but it is not clear how much I can sweep or why it fails.

In settings there is a Lightning Channels page that will show how much you have available and what the reserve amount is

@futurepaul maybe on the error screen for this we should display those balances?

For me that page shows
outbound: 20,110
reserve: 546
inbound: 121,305
But I receive the Channel reserve too high message when attempting to send
amounts between 19k and 20k.
On Thu, 28 Sept 2023 at 17:12, benthecarman @.***>
wrote:

@futurepaul https://github.com/futurepaul maybe on the error screen for
this we should display those balances?
—
Reply to this email directly, view it on GitHub
https://github.com/MutinyWallet/mutiny-web/issues/564#issuecomment-1738602973,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFKYY4W63NN4EIUQCBCMTX4UPNZANCNFSM6AAAAAA5KFENGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Looks like our outbound number is incorrect, that isn't removing the reserve amount

Generally trying to send the exact amount of outbound isn't possible, fees will make it hard to predict exactly how much you can get out. If you're looking to sweep your balance normally your best bet is to close the channel and send on-chain.
However I would put in a word of caution, right now we have an issue when you close a channel the fee rate is very low so it may take awhile for you to get your sats. Our next release (sometime this week) will fix this.

@futurepaul maybe on the error screen for this we should display those balances?

Yes, very much needed. We need to be able to distinguish failed payments from routing vs failed payments simply because the amount was too high. Perhaps also a warning when trying to send close to 1% that it might fail due to reserrve limits.

Oh nevermind, I didn't realize we already had that specific error page. Yeah I guess this would fix this issue a little bit, just tested it and it's accurate, though still a bit of a problem getting too close to fees: https://github.com/MutinyWallet/mutiny-web/pull/565


add support to allows pick multi image for plugin image_picker

pls add support to allows pick multi image.
right now this plugin in only support one file picker.
https://pub.dev/packages/image_picker#-example-tab-

#25508

Closing this as duplicate of 16054


Fix warns test convolution

Fix all warning messages in tests
Change regularizer strength setter logic; never change user base settings, warn in case of unused params (UnRegularized with not None strength)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.09%. Comparing base (ec199ab) to head (0afca5c).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #246      +/-   ##
===============================================
- Coverage        97.24%   97.09%   -0.16%
===============================================
  Files               20       20
  Lines             1815     1857      +42
===============================================
+ Hits              1765     1803      +38
- Misses              50       54       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added Darkmode

Added Darkmode for Editor.

In my opinion, there are two issues with accessibility on the metadata tab. It's the "Contributor(s)" and the "Created" Fields. See attached screenshots for details.
It does not meet WCAG standards for accessible text, regarding colour and contrast. The current values are 3.59 and 3.79. For an AA rating, it needs to be at least 4.5 and for an AAA rating, it needs to be 7 or higher.

Thanks for the changed contrast values! This looks good now.
I only looked at the visual representation, not at the code.

I don't like the really big mode toggle as a first and thus very highlighted option in the main menu. It works completely different than all other buttons by not switching any views, and you will barely ever need this. Maybe we could do something like replacing the keyboard icon with one for additional settings and views (represented e.g. by ···) and then place the mode toggle and the keyboard settings there.
Also, +1 for smaller icons.

Correction: I can't seem to find why I thought the buttons where bigger, apparently they aren't. Forget that comment.


[Feature] Hide block/biome warnings?

I am exclusively running this on modded servers (yeah I know), therefore I am getting a huge amount of "Unknown block/biome" warnings. Those are flooding my log files quite significantly, so could you please add an option to hide them from output?

Makes sense. I'll update the way these warnings work for the next release.


Prevent Hero transition for AppBar on Pesto recipe page.

BUG=https://github.com/flutter/flutter/issues/5351

Would this look better if we cross-faded from the transparent app bar on the recipe page to the green one on the list page?

LGTM
I agree with Adam about providing a conventional way to opt out of the AppBar hero transition.  Maybe file an issue about that.

We should have the distinguished way in this PR, imho

Would this look better if we cross-faded from the transparent app bar on the recipe page to the green one on the list page?

I'm undecided on whether this looks better (I tried this by removing the expandedHeight arg to the recipe page's AppBar). But I'm also not sure how to do this while also keeping the same scroll behavior. With that arg present, scrolling the recipe page doesn't move the app bar until the text area meets the app bar. Without the arg, scrolling immediately moves the app bar.

Should we have a distinguished value (e.g., null) rather than using this random string, which might match some other hero tag that also uses that random string?

I tried this as well. See https://github.com/flutter/flutter/pull/5760/commits/50f7be51c13bb449f7bd945be910de90f246cac8 . I reverted that, though, and replaced the 'nohero' string with a new Object. IMO that's clearer than a special value, and matches the way Keys work.

somehow your patch ended up containing another PR's changes? I'm confused.

Weird - new upload fixes it.

LGTM


Update README.md

reworked file links to be less unnecessarily verbose

module-name: One line description of your change (less than 72 characters)
Problem
Explain the context and why you're making that change. What is the problem
you're trying to solve? In some cases there is not a problem and this can be
thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes this
section is unnecessary because it is self-explanatory based on the solution.
Some important notes regarding the summary line:

Describe what was done; not the result
Use the active voice
Use the present tense
Capitalize properly
Do not end in a period — this is a title/subject
Prefix the subject with its scope

Test Plan
(Write your test plan here. If you changed any code, please provide us with
clear instructions on how you verified your changes work.)

duplicate pr


use a custom shader for text rendering

Here is a screenshot of 2 screenshots to showcase the problem :innocent:

Notice how the red/orange background bleeds into the word FLUSH 6 / 7 in the upper image. With this PR that won't happen anymore, as visible in the bottom image. This is especially noticeable if you have draggable windows.
We had a small conversation in kha irc about it as well:

4.7.2019 23:47 | dave: | i have some  alpha weirdness when i'm rendering a font to a rendertarget and then  that rendertarget to the screen. is it me being stupid, or is there  something broken in kha (happens in a normal debug html5 build as well,  not only in kodegarden)?  http://kodegarden.org/#be01da52bdab9fe8f62cb0a6b17436023837831b
4.7.2019 23:50 | Kyric: | probably would help if you didn't have high contrast checker patterns to mess with your eye
4.7.2019 23:51 | Robert: | The font shader still  doesn't use premultiplied alpha which makes things not work together  quite perfectly. I should maybe change that.
4.7.2019 23:53 | Robert: | Oh, but that's not what you mean right? You're just talking about the font becoming a little transparent?
4.7.2019 23:53 | dave: | the checker pattern is  there to actually showcase that behavior. it doesn't mess with your  eyes. take a screenshot an you see it's actually a bit transparent
4.7.2019 23:53 | dave: | yes exactly
4.7.2019 23:54 | dave: | like it's overwriting the alpha values
4.7.2019 23:55 | Robert: | Yes and that's actually  correct, that way you can draw a font to a texture and it still looks  nice... unless you first draw a background of course.
4.7.2019 23:55 | Robert: | Try to use a RGBX render target. Do we have that?
4.7.2019 23:55 | dave: | uhm, but it draws the blue background first?
4.7.2019 23:57 | Robert: | Yes, that gets ignored. Alpha being overwritten is normal, it's rare to use target alpha for anything.
4.7.2019 23:59 | Robert: | But we do use separate blending so you can change the alpha blend modes in createTextPipeline.
5.7.2019 00:00 | Robert: | I remember we set them to the same as the color modes because something which I can not remember.
5.7.2019 00:00 | Robert: | Also there used to be a time before computers supported separate blending.
5.7.2019 00:02 | dave: | ah yeah, when i change the alphaBlendSource to BlendOne it works
5.7.2019 00:06 | Robert: | But oh no, flash doesn't support that.
5.7.2019 00:08 | Robert: | Maybe the something was just that I wanted to have the same behaviour on all targets by default

@RobDangerous Hm, re-reading that conversation, maybe that should be changed in kha, or at least mention it somewhere in the docs i guess?

Re-re-reading that conversation, i think we shouldn't change it, as Kha's current way of doing it is correct for transparent rendertargets, and the user should take care of it manually.

Yes but but not sure yet, have to get some data on how much hardware is still around that would run into problems with separate blending.


[Bug] mask avatars don't display properly in many areas

Describe the bug
Mask avatars are not displayed properly. The reason is that the cdn cdn.jsdelivr.net that we use for avatars, has problems resolving in some regions, it can be changed to another cdn, I can provide the PR
To Reproduce

People in some provinces in mainland China (the exact provinces will be given at the end of the issues).
Open the mask page

Expected behavior
The mask's avatar can be displayed normally
Screenshots

Deployment

[x] Docker
[x] Vercel
[ ] Server

Desktop (please complete the following information):

It's not about the equipment

Smartphone (please complete the following information):

It's not about the equipment

Additional Logs
In this PR, the CDN of staticfile was changed to jsdelivr, and the cdn.jsdelivr.com is completely unavailable in some provinces of mainland China (as shown in the following picture). The staticfile cdn before this PR can actually continue to be used, the previous can not be used because they changed the domain name (org → net). So I suggest changing the CDN back to staticfile. This will ensure that users in all provinces of mainland China can see the avatar image.
Just change the code in this line to following
return `https://cdn.staticfile.net/emoji-datasource-apple/15.0.1/img/${style}/64/${unified}.png`;

As you can see, cdn.jsdelivr.net is inaccessible in many Mainland China provinces!

something wrong in your network
works fine here

also about
return `https://cdn.staticfile.net/emoji-datasource-apple/15.0.1/img/${style}/64/${unified}.png`;

does that CDN can handle high loads or whatever it is ?

also about
return `https://cdn.staticfile.net/emoji-datasource-apple/15.0.1/img/${style}/64/${unified}.png`;

does that CDN can handle high loads or whatever it is ?

First of all, to answer your question, this CDN was used before this project, because of its domain name problems caused access failure(look at this chart below), and then was changed to the current CDN.

Since we used to be able to use it, it shouldn't be a problem to change it back now and fix the domain name correctly.
If you are not sure, we can also make a minimal change to fastly.jsdelivr.net, this CDN and the current cdn.jsdelivr.net is the same service provider, although in some provinces of mainland China packet loss is higher, but the connectivity is not a problem, to provide exactly the same load capacity.
Connectivity testing for fastly.jsdelivr.net
Connectivity testing for staticfile.net

Summary of my speech:

The reason for using staticfile.net is because Next Chat had previously used it, providing first-rate CDN support for all provinces in mainland China
The reason for using fastly.jsdelivr.net is that it is the same CDN provider currently used in our project, offering basically enough CDN support for all provinces in mainland China

yeah but it was down, and I'm not certain if it's stable again. For instance, I'm unsure if it can handle high volumes of traffic about old CDN

Then you can try using fastly.jsdelivr.net, which is the same service provider as cdn.jsdelivr.net in the current project. It has the same capacity for handling traffic and can provide services to all provinces in mainland China.

Then you can try using fastly.jsdelivr.net, which is the same service provider as cdn.jsdelivr.net in the current project. It has the same capacity for handling traffic and can provide services to all provinces in mainland China.

alright

ChatGPTNextWeb#3966


[BUG] can't install with node version 21.5.0

See here after running yarn add:

I'm guessing the package.json is specifying the required node version too strictly? Idk...

Version 0.1.3 has fixed this.


Missing all accented french characters + other bug

Missing all accented french characters in texts.

actuellement écouté
mots-clés

Paramètres
résultats
requête
réponse

... and this third screenshot to show the wrong position of the switch (encroachment) in portrait mode on the ' Afficher les logos / show logos' line.

They do show up when I run clickable desktop --dirty --lang fr_FR. No idea why they would not be visible on your phone.

Not on my phone, but on all my different phones (BQ E5 HD, NEXUS 5, OPO) regardless of the channel.
The bug isn't new.  It appeared with the last update I think. But no french had reported it before.

The accents seem not converted when creating the click package. If I run msgfmt on the po file (ubuntu shell) the resulting mo file does have the accents but I am building the click package using clickable which runs msgfmt in some docker container. I'll keep digging.

A 'clean-build' made the accents appear. CMake caching behaves 'peculiar'. Anyway I have uploaded a new build which I hope works better.

Thank you ! 👍 I confirm that the problem of accented characters is solved. I don't know why but even the help is now translated in french whereas in the 0.4 click, the help was in english (i can see this yet on my OPO not updated) !
It remains however as a bug the display 'parameters' in portrait mode (third screenshot) which is not correct.

I saw that the bad display has been corrected in the click test  👍

I released 0.5 which address your issues. I renamed the app so you'll have to uninstall the old one (shoutcast-ubports) and install the new app (shoutcast-ut). Sorry for this.

Good work 👍👋


Update Composer dependencies (2021-07-20-00-04)

Visual regression test passed!
View the visual regression test report


Update release-4.17 with changes in master

This PR updates release-4.17 with the latest changes in master. This is the first in a series of PR that will enable Jenkins release for OpenShift 4.17.

/lgtm

/label backport-risk-assessed
/label cherry-pick-approved


Don't store project files on docker image

@stuartellis Great work on #857 ! Sorry I wasn't more active to review it.
I had a look and wondered why the image includes the bundle as that could introduce a stale state between the bundle on the image and the bundle of the project. Especially since it doesn't automatically build the image before running a command on a docker container.
To fix that I applied some of the setup I've recently setup for some other Docker testing projects.
Let me know if this sounds like a good idea to apply here too
Also wasn't sure why the -I and -S options were used for the Ruby scripts on the docker containers. Seems to work without it? If I missed some application of this, it might be nicer to move this setup to some of the files, so they're not reliant of the command that runs the test suites.

commit message:
This change only prepares the build environment on the docker image, but does
not create a production image which could be deployed for an app.
It uses volumes and a custom BUNDLE_PATH to store the gems in the
bundle which can be used between updates to the bundle itself. If a gem
version changes it would not have to reinstall all the gems and build
the image from that point, it would be able to reuse the bundler cache
(in the mounted volume) and only require an update to the changed gems.
Overal, should speed up the build process for the docker test
environment.
Added a bin/docker_test file that performs tasks within the docker
container.
Also made building the docker image mandatory when running the docker
namespaced rake files, so you can't end up with an out-of-sync state
where the docker image has changed, but hasn't been rebuild so a
developer would be testing against a stale image.

Thank you. Until yesterday, the Rake tasks did force a rebuild of the Docker image, but I second-guessed myself, and took this out!
TLDR;

I am not a Docker expert, at all, so am inclined to defer to your experience

Agree:

Should force rebuild of images
Should get rid of the ruby -I -S thing

Needs more discussion:

Caching of bundle on host seems slow
Use of shell script to run tasks inside container (necessary if we need to run Bundler before each task, otherwise not keen)

Longer comments:
IIRC, the  -I -S were needed to make something work properly at some point, but it's been so long since I wrote the PR that I can't remember.
I like caching the bundle on the host, but it seems to make things much slower:
$ rake docker:spec
Finished in 16.17 seconds (files took 54.74 seconds to load)
1411 examples, 0 failures

Compared to:
$ rake docker:spec
Finished in 5.64 seconds (files took 2.68 seconds to load)
1411 examples, 0 failures

Performance is more of an issue for integration tests: IIRC, once I had ported several sets of these to Docker, the integration test task took over a minute to run on my development laptop.
Just on principle, I don't like a separate shell script running the tasks inside the container, since we actually have Rake available on both the host, and inside the container as well. Obviously, if we are going to trigger Bundler inside the container before each task, then it makes sense.

Well, we don't need to force run bundler beforehand. We can also put the "installation" step in a build task on the docker container. (It's what I actually do in most other projects.) Then it has the same behavior as most development environments; missing a gem?: bundler will error.
About the bash script, it's a personal preference of mine as it's quicker to run and doesn't require the bundle and such to be installed locally. You basically won't need any local setup to run the tasks. We can move the stuff from the bash script to rake tasks, but it would add additional load time locally as well.
I've improved the performance a bit by specifying volume modes, but it will always be a bit slower on mounted volumes. I haven't seen such a dramatic increase in load/boot/require time for any project, but then again, Backup is special with its many dependencies. Requiring all those files will take a while unfortunately, it's still Ruby.
Previous setup without volume modes configured (perfect consistency between host and container):
Finished in 16.99 seconds (files took 1 minute 1.66 seconds to load)
1411 examples, 0 failures

bundle exec rake docker:spec  1.17s user 0.33s system 1% cpu 1:23.29 total

New setup with volume modes configured (delayed file sync to host from container):
Finished in 8.75 seconds (files took 14.43 seconds to load)
1411 examples, 0 failures

bundle exec rake docker:spec  1.12s user 0.30s system 4% cpu 28.989 total

would that be an acceptable time?

Unfortunately, the latest version seems to be broken. I deleted images and containers, then ran commit 59fb427:

$ rake docker:spec
docker-compose build
Building ruby_backup_tester
Step 1/6 : FROM ruby:2.4.2
---> eebb1381c2aa
Step 2/6 : LABEL maintainer<EMAIL_ADDRESS>version "0.1.0" description "Image for running the backup Rubygem"
---> Running in 131ead29f86e
---> b2067a52a34f
Removing intermediate container 131ead29f86e
Step 3/6 : ENV APP_DEPS bsdtar ca-certificates curl g++ git     libxml2 libxslt1.1 libyaml-0-2 openssl
---> Running in 88e52817d672
---> cfca0b8e0dbd
Removing intermediate container 88e52817d672
Step 4/6 : RUN apt-get update && apt-get install -y --no-install-recommends $APP_DEPS
---> Running in 203da13cbe22
Get:1 http://security.debian.org jessie/updates InRelease [63.1 kB]
Ign http://deb.debian.org jessie InRelease
Get:2 http://deb.debian.org jessie-updates InRelease [145 kB]
Get:3 http://security.debian.org jessie/updates/main amd64 Packages [547 kB]
Get:4 http://deb.debian.org jessie Release.gpg [2373 B]
Get:5 http://deb.debian.org jessie Release [148 kB]
Get:6 http://deb.debian.org jessie-updates/main amd64 Packages [23.1 kB]
Get:7 http://deb.debian.org jessie/main amd64 Packages [9063 kB]
Fetched 9992 kB in 17s (565 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
ca-certificates is already the newest version.
g++ is already the newest version.
libxslt1.1 is already the newest version.
libxslt1.1 set to manually installed.
libyaml-0-2 is already the newest version.
libyaml-0-2 set to manually installed.
openssl is already the newest version.
openssl set to manually installed.
curl is already the newest version.
git is already the newest version.
libxml2 is already the newest version.
libxml2 set to manually installed.
The following extra packages will be installed:
libarchive13
Suggested packages:
bsdcpio lrzip
The following NEW packages will be installed:
bsdtar libarchive13
0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
Need to get 325 kB of archives.
After this operation, 795 kB of additional disk space will be used.
Get:1 http://deb.debian.org/debian/ jessie/main libarchive13 amd64 3.1.2-11+deb8u3 [271 kB]
Get:2 http://deb.debian.org/debian/ jessie/main bsdtar amd64 3.1.2-11+deb8u3 [53.9 kB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 325 kB in 1s (323 kB/s)
Selecting previously unselected package libarchive13:amd64.
(Reading database ... 21171 files and directories currently installed.)
Preparing to unpack .../libarchive13_3.1.2-11+deb8u3_amd64.deb ...
Unpacking libarchive13:amd64 (3.1.2-11+deb8u3) ...
Selecting previously unselected package bsdtar.
Preparing to unpack .../bsdtar_3.1.2-11+deb8u3_amd64.deb ...
Unpacking bsdtar (3.1.2-11+deb8u3) ...
Setting up libarchive13:amd64 (3.1.2-11+deb8u3) ...
Setting up bsdtar (3.1.2-11+deb8u3) ...
Processing triggers for libc-bin (2.19-18+deb8u10) ...
---> 8f614a863bdc
Removing intermediate container 203da13cbe22
Step 5/6 : ENV APP_HOME /usr/src/backup
---> Running in 10a9c90b1543
---> 7fc196bfb296
Removing intermediate container 10a9c90b1543
Step 6/6 : WORKDIR $APP_HOME
---> 94786417ef99
Removing intermediate container a072f97ea7d1
Successfully built 94786417ef99
Successfully tagged backup/test-suite:local
docker-compose run --rm ruby_backup_tester bin/docker_test rspec
bundler: command not found: rspec
Install missing gem executables with bundle install
rake aborted!

It's no longer automatically checking and installing missing gems. I can add that back if it's more convenient?

Aha - yes, if I use the tasks correctly, they work :)
$ rake docker:prepare
$ rake docker:spec

Says:

Finished in 11.43 seconds (files took 28.48 seconds to load)
1411 examples, 0 failures

I would be inclined to just remove the desc line for the docker:build task, so that it doesn't appear on the list of tasks: the other tasks run it as a dependency, so it could effective be "private".

A small thing - the rename of the Docker image has broken the clobber task. It looks like the Docker commands aren't consistent:

$ rake docker:clobber
$ docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
backup/test-suite   local               5dc416e3acd0        11 minutes ago      697MB

Example output of  docker ps:

$ docker ps -a
CONTAINER ID        IMAGE                     COMMAND                  CREATED             STATUS              PORTS               NAMES
7898458d6824        backup/test-suite:local   "bin/docker_test c..."   17 seconds ago      Up 15 seconds                           backup_ruby_backup_tester_run_1

the rename of the Docker image has broken the clobber task. It looks like the Docker commands aren't consistent with each other

I changed the docker run command to include the --rm option, which means it will automatically remove the container after it finishes. So I'm not sure if the clean task is still necessary? Any reason to keep the containers after running the test suites?

Yes, I noticed that the containers are now automatically removed (which is great), and would be happy to remove the "clean" task. The "clobber" task actually deletes the images, and that doesn't work ATM: docker images has a different format than the grep assumes.


Wrote this using git web edit so it's untested. In 0.6 this will remove ...

...the http request for follow from the Agent so that long running follow connection don't overload the socket pool in node.

Firstly, I'm impressed you could make sense of that code. Your code is doing that to the request that just pings the db, not the one that hits _changes.
I applied this correction in 92dedde.


Python bindings create duplicated qualified fields after joining

Describe the bug
im working on getting datafusion added to db-benchmark (#147).  while putting the benchmarks together i came across an error while doing the join benchmark that i wasnt expecting.  specifically the error is:
Traceback (most recent call last):
  File "datafusion/join-datafusion.py", line 72, in <module>
    df = ctx.create_dataframe([ans])
Exception: DataFusion error: Plan("Schema contains duplicate qualified field name 'ce9f0daee780e4f2796b9953bd267457c.id1'")

The test code that produced that is here:
question = "small inner on int" # q1
gc.collect()
t_start = timeit.default_timer()
ans = ctx.sql("SELECT * FROM x INNER JOIN small ON x.id1 = small.id1").collect()
shape = ans_shape(ans)
print(shape)
t = timeit.default_timer() - t_start
t_start = timeit.default_timer()
df = ctx.create_dataframe([ans])
chk = df.aggregate([], [f.sum(col("v1"))]).collect()[0].column(0)[0]
chkt = timeit.default_timer() - t_start
m = memory_usage()
write_log(task=task, data=data_name, in_rows=x_data.num_rows, question=question, out_rows=shape[0], out_cols=shape[1], solution=solution, version=ver, git=git, fun=fun, run=1, time_sec=t, mem_gb=m, cache=cache, chk=make_chk([chk]), chk_time_sec=chkt, on_disk=on_disk)
del ans
gc.collect()

if i update the sql to:
SELECT x.id1, x.id2, x.id3, x.id4, small.id4, x.id5, x.id6, x.v1, small.v2 FROM x INNER JOIN small ON x.id1 = small.id1

I get:
Traceback (most recent call last):
  File "datafusion/join-datafusion.py", line 73, in <module>
    df = ctx.create_dataframe([ans])
Exception: DataFusion error: Plan("Schema contains duplicate qualified field name 'cb53bcf8886f449c3bd2651571df185d4.id4'")

to me this looks like a bug as i think i should be able to write the query without having to alias the overlapping columns (when i alias the overlapping columns it works). for example, below is the equivalent spark query.
select * from x join small using (id1)

To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
I should be able to run either of the following
ans = ctx.sql("SELECT x.id1, x.id2, x.id3, x.id4, small.id4, x.id5, x.id6, x.v1, small.v2 FROM x INNER JOIN small ON x.id1 = small.id1").collect()
df = ctx.create_dataframe([ans])

ans = ctx.sql("SELECT * FROM x INNER JOIN small ON x.id1 = small.id1").collect()
df = ctx.create_dataframe([ans])

Additional context
Add any other context about the problem here.

is this specific to python? or also happens in the rust core?

I believe it was just in Python but I will have to double check.

I think it is just python. I try following in datafusion-cli and works
select * from test join small using (c1);

with
CREATE EXTERNAL TABLE test (
    c1  VARCHAR NOT NULL,
    c2  INT NOT NULL,
    c3  SMALLINT NOT NULL,
    c4  SMALLINT NOT NULL,
    c5  INT NOT NULL,
    c6  BIGINT NOT NULL,
    c7  SMALLINT NOT NULL,
    c8  INT NOT NULL,
    c9  BIGINT NOT NULL,
    c10 VARCHAR NOT NULL,
    c11 FLOAT NOT NULL,
    c12 DOUBLE NOT NULL,
    c13 VARCHAR NOT NULL
)
STORED AS CSV
WITH HEADER ROW
LOCATION '/testing/data/csv/aggregate_test_100.csv';

CREATE EXTERNAL TABLE small (
    c1  VARCHAR NOT NULL,
    c2  INT NOT NULL,
    c3  SMALLINT NOT NULL,
    c4  SMALLINT NOT NULL,
    c5  INT NOT NULL,
    c6  BIGINT NOT NULL,
    c7  SMALLINT NOT NULL,
    c8  INT NOT NULL,
    c9  BIGINT NOT NULL,
    c10 VARCHAR NOT NULL,
    c11 FLOAT NOT NULL,
    c12 DOUBLE NOT NULL,
    c13 VARCHAR NOT NULL
)
STORED AS CSV
WITH HEADER ROW
LOCATION '/testing/data/csv/aggregate_test_100.csv';

perhaps we should move this issue to the python binding repo then :)

perhaps we should move this issue to the python binding repo then :)

Yes that was my plan. Currently away and will make new issue there, with more details, in a few days.

Actually the problem is neither datafusion or pydatafusion, just different expection.
datafusion allow duplicate columns in ans, but pydatafusion will raise error when create_dataframe when input columns are duplicated.
e.g. select x.c2, y.c2 from x join y using (c1) limit 1 shows
+----+----+
| c2 | c2 |
+----+----+
| 1  | 1  |
+----+----+

I test in MySQL 5.6 and PostgreSQL 9.6, they also show duplicate column names in output, e.g. http://sqlfiddle.com/#!9/a6c585/237251 and http://sqlfiddle.com/#!17/bf2fd/25993. This also align with "All bare column field names MUST not contain relation/table qualifier." in https://arrow.apache.org/datafusion/specification/output-field-name-semantic.html
dataframe is correct too, since it is not expected to have duplicate input name. I believe the internal dataframe using in ctx.sql have different column name like x.c2 and y.c2, but we simplify that when output

@jychen7 thank you for the analysis.  i am going to look into this more tomorrow.

Im at odds here as to what expected behavior should be.  The point you mentioned "All bare column field names MUST not contain relation/table qualifier." in https://arrow.apache.org/datafusion/specification/output-field-name-semantic.html seems to prevent creating dataframe from output of something like SELECT * FROM x JOIN y on x.id1 = y.id1 - which i think we should be able to do.
@houqp do you have an opinion on this?

@matthewmturner this is indeed expected behavior. If you need to create a dataframe from record batches, you need to explicitly create aliases to make sure all output field names are unique. Postgres behave the same way as well, see this subquery as an example: http://sqlfiddle.com/#!17/bf2fd/26130.

Given Arrow is in-memory dataframe, with extra parameter, it should be possible to ask ctx.sql to return dataframe directly?

@jychen7 , SQL queries only returns record batches, which doesn't have the concept of column qualifiers (table name). This is also to align the behavior with other dbs and query engines. For example, postgres strips all qualifiers in its query output as well. The create_dataframe API is actually not a very well named method, what it does actually is to create a memtable and wrap it with a TableScan plan. It won't make a lot sense for a sql query to return a table (memtable) in this case.

@houqp just one follow up - postgres does allow the following:
select * from jsonData as t1
join jsonData as t2 on t1.id = t2.id

http://sqlfiddle.com/#!17/bf2fd/26200
so it would seem datafusion doesnt match that behaviour as we cant call select * after joining tables.

so it would seem datafusion doesnt match that behaviour as we cant call select * after joining tables.

Yeah, i think this is a subquery support bug that needs to be fixed.

@houqp how would this work in datafusions case though since we dont allow relation / table qualifier? Postgres seems to show duplicate columns without a qualifier which i dont think we can do.
Also, regarding that being a subquery bug - would you be able to expand on that point? I hadnt really thought of this as a subquery.  Are you referring to what this turns into at the logical / physical plan level.


Record field selectors don't typechecker properly

1 | val _ = #y {y = 10, x = 12}
            ^~~~~~~~~~~~~~~~~~~^ Can't unify record types with different number of fields
1 | val _ = #y {y = 10, x = 12}
            ^~~~~~~~~~~~~~~~~~~^ type {y:'r#1}
1 | val _ = #y {y = 10, x = 12}
            ^~~~~~~~~~~~~~~~~~~^ type {x: int,y: int}

This will require flexible record fields to work.
MLton has a separate ty constructor field FlexRecord, whereas smlnj store flex information in unresolved typevars. The smlnj approach seems like it might be conceptually simpler, so it's probably best to try that approach first

Doing a bit of dog-fooding here, where this was first implementing in the sml-analyzer codebase as a prototype.
https://github.com/SomewhatML/sml-analyzer/commit/37075532eaa938f8194ac65690842b47f477cefb
This may not be the best approach, although it does seem to work for now. It's unclear if this set up (which generalizes, without explicit type variables) will have unintended consequences. We could alternatively follow the Defn. and what MLton does, which is not allow generalization here.


Dynamic fallback langs

Hello, I can't find in docs, is it possible to have dynamic fallback langs, for example, I have two lang on my website English and Franch.
When English translations of an article will not be presented in the database to be a callback lang French but when French translations will not be presented to be callback English. To switch between this two lang that article show page won't be empty.

The config key translatable.fallback_locale is used to get the fallback locale - so you can do config('translatable.fallback_locale', 'new_fallback').
The following method could be a starting point to customize the fallback finding. But the $locale parameter isn't available everytime. So you should use app()->getLocale() to get your current locale and could return the corresponding fallback via a simple switch-case or anything else.
https://github.com/dimsav/laravel-translatable/blob/633b24127bacc97bc780e3baf1482a6c8b12eb40/src/Translatable/Translatable.php#L345-L353

Thanks worked just fine


Minecraft startup crash

Describe the Bug
minecraft wont get part the staring phase
Reproduction Steps
1.start the game
2.crash
Expected Result
minecraft starting up
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/J5kwTnE4
Operating System
win 11
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods
the full mod list is in the crash report because there are a lot of mods in it (using prominese II as a base i added a lot of mods so there might be an incompatibility happing)
Additional Context
No response

use sodium 0.4.10 iris 1.6.4 fabric api 0.88.1 Indium 1.0.21. remove cccbridge it is no longer needed.

that did not fix it sadly  here the new crash log https://pastebin.com/P5rmdEHU also here is the main log as it maybe helps
latest.log

could you please disable vivecraft and transparent, until the rest loads?

this is a conflict between transparent and sodium extra


test-branch/execute-job/comment-from-wrong-user-on-pr/575cfa0a-ce15-4c29-9a08-726a0c861bd3

PR for testing a820e28f8e288a123fd72e8d6b75234975441e39

/canonical/self-hosted-runners/run-workflows a820e28f8e288a123fd72e8d6b75234975441e39


[Task]: number of unauthorised gsheetsdatasources

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
find and document an easily repeatable mechanism to answer the following questions:

how many gsheets datasources were created in a given time period?
of these, how many were properly authorised and how many were not?

Appsmith application url: https://app.appsmith.com/app/google-sheet-auth-data/on-demand-6387593842ec665592963ee5.
For now shared with @rohan-arthur and @sumitsum .


Add New course

I want to add Harvards CS50 - Introduction to databases with SQL.
Website : https://cs50.harvard.edu/sql/2023/

will they provide free certificate after completion ?

Yes. All CS50 certificates have the same format. After completion of all the exercises and a project(if there) then we get the certificate.


wasmtime 2.0.2 CVEs

Our current version of wasmtime (2.0.2) has a couple of CVEs

CVE-2023-26489<EMAIL_ADDRESS>CVE-2023-27477<EMAIL_ADDRESS>
that are being flagged by our CVE scanner https://github.com/envoyproxy/envoy/actions/workflows/check-deps.yml
@RiverPhillips has a PR to update proxy-wasm here https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/333
which i think needs to happen first

cc @PiotrSikora

/backport

/assign @RiverPhillips

/assign @RiverPhillips


Capture backtraces for mutex dependencies

Builds on top of #28.
This PR adds backtrace data to the dependency graph, so you can figure out what series of events might have introduced the cycle in dependencies. Only the first backtrace
These changes do have a performance penalty, with a worst case of 20-50% degradation over previous results. This applies to the worst case scenario where every dependency between mutexes is new and thus is unlikely to be as severe.
Below is an example of what this can look like, generated with examples/mutex_cycle.rs. The formatting is decidedly suboptimal but backtraces cannot be formatted very well in stable rust at the moment. The exact performance hit depends on a lot of things, such as the level of backtraces captured (off, 1, or full), and how many dependencies are involved.
thread 'main' panicked at 'Found cycle in mutex dependency graph:
   0: tracing_mutex::MutexDep::capture
             at ./src/lib.rs:278:23
   1: core::ops::function::FnOnce::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:250:5
   2: tracing_mutex::graph::DiGraph<V,E>::add_edge
             at ./src/graph.rs:131:50
   3: tracing_mutex::MutexId::mark_held::{{closure}}
             at ./src/lib.rs:146:17
   4: std::thread::local::LocalKey<T>::try_with
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/thread/local.rs:270:16
   5: std::thread::local::LocalKey<T>::with
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/thread/local.rs:246:9
   6: tracing_mutex::MutexId::mark_held
             at ./src/lib.rs:142:25
   7: tracing_mutex::MutexId::get_borrowed
             at ./src/lib.rs:129:9
   8: tracing_mutex::stdsync::tracing::Mutex<T>::lock
             at ./src/stdsync.rs:110:25
   9: mutex_cycle::main
             at ./examples/mutex_cycle.rs:20:18
  10: core::ops::function::FnOnce::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:250:5
  11: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/sys_common/backtrace.rs:135:18
  12: std::rt::lang_start::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:166:18
  13: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:284:13
  14: std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
  15: std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
  16: std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
  17: std::rt::lang_start_internal::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:48
  18: std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
  19: std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
  20: std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
  21: std::rt::lang_start_internal
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:20
  22: std::rt::lang_start
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:165:17
  23: main
  24: <unknown>
  25: __libc_start_main
  26: _start

   0: tracing_mutex::MutexDep::capture
             at ./src/lib.rs:278:23
   1: core::ops::function::FnOnce::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:250:5
   2: tracing_mutex::graph::DiGraph<V,E>::add_edge
             at ./src/graph.rs:131:50
   3: tracing_mutex::MutexId::mark_held::{{closure}}
             at ./src/lib.rs:146:17
   4: std::thread::local::LocalKey<T>::try_with
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/thread/local.rs:270:16
   5: std::thread::local::LocalKey<T>::with
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/thread/local.rs:246:9
   6: tracing_mutex::MutexId::mark_held
             at ./src/lib.rs:142:25
   7: tracing_mutex::MutexId::get_borrowed
             at ./src/lib.rs:129:9
   8: tracing_mutex::stdsync::tracing::Mutex<T>::lock
             at ./src/stdsync.rs:110:25
   9: mutex_cycle::main
             at ./examples/mutex_cycle.rs:14:18
  10: core::ops::function::FnOnce::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:250:5
  11: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/sys_common/backtrace.rs:135:18
  12: std::rt::lang_start::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:166:18
  13: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:284:13
  14: std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
  15: std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
  16: std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
  17: std::rt::lang_start_internal::{{closure}}
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:48
  18: std::panicking::try::do_call
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:500:40
  19: std::panicking::try
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:464:19
  20: std::panic::catch_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panic.rs:142:14
  21: std::rt::lang_start_internal
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:148:20
  22: std::rt::lang_start
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/rt.rs:165:17
  23: main
  24: <unknown>
  25: __libc_start_main
  26: _start

', src/lib.rs:163:13
stack backtrace:
   0: rust_begin_unwind
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/std/src/panicking.rs:593:5
   1: core::panicking::panic_fmt
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/panicking.rs:67:14
   2: tracing_mutex::MutexId::mark_held
             at ./src/lib.rs:163:13
   3: tracing_mutex::MutexId::get_borrowed
             at ./src/lib.rs:129:9
   4: tracing_mutex::stdsync::tracing::Mutex<T>::lock
             at ./src/stdsync.rs:110:25
   5: mutex_cycle::main
             at ./examples/mutex_cycle.rs:25:14
   6: core::ops::function::FnOnce::call_once
             at /rustc/eb26296b556cef10fb713a38f3d16b9886080f26/library/core/src/ops/function.rs:250:5

Importantly, the error shows all the dependencies that are already part of the graph, not the one that was just added, since that is already visible from the immediate panic.

@tbodt FYI I continued your work.

Capturing backtraces results in about 60% overhead, which isn't great, but without the backtraces feature the difference is well within the noise threshold, so I think it should be fine to merge like this.
bors r+