Migrate initwallet to Python3

As this touches a file that handles private keys/seed words I would like to be as careful as possible with the changes in order to not break anything.
I think these are the outstanding steps

[x] do manual tests
[ ] check /update instructions/manuals

This is related to #822

@rootzoll the build process gives a big warning for Python2:
Installing setuptools, pkg_resources, pip, wheel...done.
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support

Do you think we can drop Python2 (and migrate this script) in time for the 1.4 release?

@frennkie I think a move to python3 is good - if you think the migration is ready/working, feel free to merge.

Built the SD 18h ago before the latest commit: https://github.com/rootzoll/raspiblitz/pull/878#issuecomment-558244166
I got this error when creating a new wallet:
Generating new Wallet ....
Traceback (most recent call last):
  File "/home/admin/config.scripts/lnd.initwallet.py", line 7, in <module>
    import grpc
ModuleNotFoundError: No module named 'grpc'
FAIL!! -> MISSING seedwords data - but also no err data ?!?
CHECK output data above - PRESS ENTER to restart 70initLND.sh

Is it fixed now? Will do a XXsyncScripts and try again.

cd raspiblitz/
git remote set-url origin https://github.com/frennkie/raspiblitz.git
/home/admin/XXsyncScripts.sh migrate-initwallet

I have another PR pending.. They depend on each other... Will submit it later today.
On November 26, 2019 12:25:57 PM GMT+01:00, openoms<EMAIL_ADDRESS>wrote:

Built the SD 18h ago before the latest commit:
https://github.com/rootzoll/raspiblitz/pull/878#issuecomment-558244166
I got this error when creating a new wallet:
Generating new Wallet ....
Traceback (most recent call last):
File "/home/admin/config.scripts/lnd.initwallet.py", line 7, in
<module>
   import grpc
ModuleNotFoundError: No module named 'grpc'
FAIL!! -> MISSING seedwords data - but also no err data ?!?
CHECK output data above - PRESS ENTER to restart 70initLND.sh

Is it fixed now? Will do a XXsyncScripts and try again.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/rootzoll/raspiblitz/pull/841#issuecomment-558586810

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

@openoms PR #884 should fix this issue.

@rootzoll I have a reminder for updating docs in this PR. But I actually don't see any important user-facing changes... this should be transparent.
The only thing I think makes sense is to update the docs so that other contributors and user using third party stuff are aware of the dropped Python2 support.
What do you think?

@frennkie why not add into the header of every python file:
┏┓ ┃┃╱╲ in ┃╱╱╲╲ this ╱╱╭╮╲╲house ▔▏┗┛▕▔ we ╱▔▔▔▔▔▔▔▔▔▔╲ like to use python 3 not 2 ╱╱┏┳┓╭╮┏┳┓ ╲╲ ▔▏┗┻┛┃┃┗┻┛▕▔
or keep it short with one line :)

@openoms PR #884 should fix this issue.

I have run the build_sdcard.sh changes in that commit manually and synced the scripts from the branch remove-python2.
still getting:
Generating new Wallet ....
Traceback (most recent call last):
  File "/home/admin/config.scripts/lnd.initwallet.py", line 15, in <module>
    import grpc
ModuleNotFoundError: No module named 'grpc'
FAIL!! -> MISSING seedwords data - but also no err data ?!?
CHECK output data above - PRESS ENTER to restart 70initLND.sh

Is there a branch now with all the changes, so I can build a clean SD?

I was only was only installing the needed pip packages when BlitzTUI is installed. Fixed now.

Is there a branch now with all the changes, so I can build a clean SD

Yes.. Now: master.. 😉

I was still missing this:
Traceback (most recent call last):
  File "/home/admin/config.scripts/lnd.initwallet.py", line 17, in <module>
    from lndlibs import rpc_pb2_grpc as lnrpc
  File "/home/admin/config.scripts/lndlibs/rpc_pb2_grpc.py", line 4, in <module>
    import rpc_pb2 as rpc__pb2
ModuleNotFoundError: No module named 'rpc_pb2'

will build one from master then.

The fix for that is included in #878.

In branch v1.4 I made 70initLND.sh made use the new lnd.initwallet2.py script, but it throws on generating a new wallet:
Traceback (most recent call last):
  File "/home/admin/config.scripts/lnd.initwallet2.py", line 7, in <module>
    from lndlibs import rpc_pb2_grpc as lnrpc
  File "/home/admin/config.scripts/lndlibs/rpc_pb2_grpc.py", line 4, in <module>
    import rpc_pb2 as rpc__pb2
ModuleNotFoundError: No module named 'rpc_pb2'

@frennkie what do I miss?

Are you testing the v1.4 from scratch? The build_sdcard.sh includes a patch for the lnd lib file to make it compatible for both Python2 and 3.
70initLND.sh should actually use lnd.initwallet.py...

I changed 70iniLND.sh back to lnd.initwallet.py. made a fresh protobuff build of lnd libs. And also applied the changes from buil_sd card again ... but still getting that error.
@frennkie at the moment the v1.4 branch is not able to create a LND wallet on setup. This bug is a showstopper for a Release Candidate for the 1.4 Milestone. Any help to fix this is appreciated.

@frennkie seems I got it working ... it seems the customizing of the proto files did not worked on my instance. Doing more testing.

OK - fixed :) Show can go on ...

hey guys, I'm also stuck at this, running the script from my new rpi4 and dietpi
any quick solution for me to continue?

Which version are you using? The official 1.3. Release? Oder the 1.4. Release Candidate?

1.3, can I partially upgrade?

There is a partial way (XXsync..) which does not guarantee to cover everything.
I was asking so that I know where to check. This might only affect 1.3. Or coulc also affect 1.4. I will have a look.

OK, I'm sure that this is covered in the v1.4 branch. The v1.4 Release Candidate 1 was created before Christmas and we have since fixed a few other issues. So a v1.4 RC2 is due for sometime next week.
As you are using Diet Pi (which I don't)... Would you able and willing to test the latest v1.4?

I am willing to help. Latest Clean dietpi installed.
How can I update and continue the lnd  process?

From a clean dietpi all you need to do is follow these instructions:
https://github.com/rootzoll/raspiblitz/blob/master/alternative.platforms/dietpi/README.md
In the section Run the RaspiBlitz build_sdcard.sh script you run:
wget https://raw.githubusercontent.com/rootzoll/raspiblitz/v1.4/build_sdcard.sh && sudo bash build_sdcard.sh v1.4 rootzoll

Ok so I just cancel the ongoing 1.3 install, do a fresh build and it should overwrite everything necessary right?

Yes.

can I reset the ongoing installation process from 1.3? renaming the RaspiBlitz.conf wasn't enough
build 1.4 went through smoothly, now I just want to restart the whole configuration process.

The old ongoing installation process should only be tracked by a file on the sdcard. But you made a clean, fresh sd, right? So that file should be gone... check for /home/admin/raspiblitz.conf.
Otherwise, I'm not quite sure what you setup is.. do you  have funds on the HDD? LND wallet? the blockchain?

Try rm /home/admin/raspiblitz.info ; /home/admin/XXshutdown.sh reboot

ok, had to do a fresh dietpi, redoing everything, stay tuned ;)

something is fckin up my clean installation and I cant tell what because I'm headless without hdmi…
dietpi is ok, but the raspiblitz 1.4 installation is doing something so I can't get to reboot the pi twice without HDD. ssh login is refusing suddenly, cant get in… only a sd wipe is helping :/

so I can confirm that 1.4 is doing some stuff so I cant reconnect with ssh after reboot and with attached HDD, during or after install, I tried everything.
1.3/master is working but I cant get through the lnd setup part because of the above error from the screenshot, the reason why I had to try 1.4 in the first place.
without a micro hdmi I'm right now not able to debug further…


middleware/log: Allow more fine grained filtering

wip - don't merge yet

Current coverage is 38.70% (diff: 18.64%)

Merging #325 into master will decrease coverage by 0.13%

@@             master       #325   diff @@
==========================================
  Files            93         94     +1
  Lines          4765       4787    +22
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1851       1853     +2
- Misses         2749       2770    +21
+ Partials        165        164     -1

Powered by Codecov. Last update caa3976...8f3a51d


Support for including this library into library project

I want to change my library project fonts style using this library, is it possible to use it ? Or can you recommend some library that is doing what I want ? Thank you.

I guess if your lib is self contained activities then it should be possible, but not right now. Raise this with V3 so different configs can be used.


TST Add regression test for DoRA, VeRA, BOFT, LN Tuning

These new methods were added but the regression tests were not extended yet. This PR adds regression tests for these methods. The regression artifacts have been pushed based on PEFT v0.11.1. The new tests pass locally.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Fix potential deadlock in batch ingestion

Description
AbstractBatchIndexTask.tryTimeChunkLock() is called isReady() which is called in the Overlord to check if the task is ready for execution. Since the Overlord only checks the result of isReady() but does nothing with locks by itself, locking individual interval can lead to deadlock. Imagine that there are two tasks that want to work on overlapping intervals. One task could lock some of intervals but failed for others for some reason. Later, another task could lock those intervals where the first task failed to lock. Now they would wait for each other to release locks they possess.
This PR changes to lock an umbrella interval of the input intervals instead of locking them individually. This is an easy fix, but I'm not sure if it's the best. Maybe the Overlord should take care of those tasks who are not ready yet and release any locks they acquired during isReady(). This approach will work better when the input intervals are not consecutive (the approach locking an umbrella interval will unnecessarily lock some intervals even though the task doesn't need them). We can get back to this approach when this turns out to be an issue.
I found the better approach is not that hard to implement. Updated this PR and now TaskQueue cleans up all locks automatically if Task.isReady() returns false.

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[x] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@loquisgon @maytasm thanks for the review!

@loquisgon @maytasm thanks for the review!


🎨  Optimise theme load & remove validation

This PR is still WIP as it breaks some behaviour / tests.
It's a bit of a hacky solution to #7854. To explain - we're seeing serious slowdown at a certain point, e.g. with 30+ themes, on Ghost(Pro). It's not really reproducible locally. I haven't spent long on a fix, I pulled this together quickly to see if it roughly worked as a solution and it seems to do the trick.
I think I can get the tests working with a little bit more work, but wanted to share this in case anyone had any concerns about the approach.
I'm considering a similar, but more well thought-out approach for 1.0. Something along the lines of loading ONLY the active theme (or first available theme) as part of the boot process, moving the theme list to a proper GET /themes/ endpoint, and saving the loading of all remaining themes for either the first request to that endpoint, or as a post-boot hook similar to what's in this PR.

refs  #7854

Remove the concept of validating themes. This can now be done with gscan
Delay the loading of themes until after the server has started
Use events to trigger behaviour after the server has started
NOTE: this is pretty hacky, intended to slightly improve LTS boot times. A better solution should be added for 1.0
ALSO NOTE: this may result in the first few requests to the frontend throwing "the currently active theme is missing". If this turns out to be a major issue, we can add in an extra fix to load just the active theme a little earlier. However, I think it's probably fine for LTS and again, we need a much more concrete solution for the Alpha/1.0

I believe I have got this sorted. I had to fall back to loading the active theme right at the start, but this should be a fixed-length(ish) task, getting longer only if a theme has a ridiculous number of files.

Just pushed an extra commit onto this - it's totally unnecessary to load apps on Ghost boot. This isn't just a case of apps aren't a thing - the minimal framework that we do have still works even without this code - this code was intended for use for an app list. We can solve this separately later.


[FEATURE REQUEST] Remove outlier transactions from reports

It would be wonderful to have an option to exclude extremely rare and anomalous transactions from the reports. I have had a couple windfalls and payments occur (sale of a house, large financial gift, paid off large loan on bulk payment) that are unusual and will not happen again. They throw off all my charts and averages.
I don't know what would be the easiest and most low key way to do this from a coding perspective. A toggle switch or checkmark we can activate that indicates if a transaction should not be included in the usual maths? A flag? A codeword?
Thanks!

If considering this, maybe use SD as a criterion for exclusion? The effect should actually be rare. Maybe something like if value > 2.5 SD or 3 SD from the mean of the period reported, exclude from report? Maybe color-code a row if exclusion actually occurs, so the user is aware of that in their evaluation of the result.


F# discriminated union support for strongly-typed identifiers

Implements #3280

@nkosi23 Can you reverse the rename of ValueTypeInfo to StrongTypedIdInfo? The earlier name was to reflect that that was used within LINQ and possibly independently of the strong typed ids


Metasploit::Cache::Payload::Handler

MSP-12433
Metasploit::Cache::Payload::Handler caches the general_handler_type and handler_type for the connection 'Handler' from single and stager module info.  The stager handler_type is used in the derivation of the staged payload reference name.

Verification Steps
General Handler Types

[x] Verify Metasploit::Cache::Payload::Handler::GeneralType contains all general_handler_types returned from general_handler_type methods in metasploit-framework.

Schema and Models

[ ] Verify implemented schema and associations match ERD shown above between Metasploit::Cache::Payload::Single::Instance, Metasploit::Cache::Payload::Stager::Instance, and Metasploit::Cache::Payload::Handler.

Version

[x] Edit lib/metasploit/cache/version.rb
[x] Remove PRERELEASE and its comment as PRERELEASE is not defined on master.

Gem build

[x] gem build *.gemspec
[x] VERIFY the gem has no '.pre' version suffix.

RSpec

[x] rake spec
[x] VERIFY version examples pass without failures

Commit & Push

[x] git commit -a
[ ] git push origin master

Still seeing the annoying yard errors about @param tags it can't find because they're part of a @method declaration instead of a normal def or whatever:
[warn]: @param tag has unknown parameter name: module_instances
    in file `app/models/metasploit/cache/module/class.rb' near line 147
[warn]: @param tag has unknown parameter name: module_instance
    in file `app/models/metasploit/cache/module/instance.rb' near line 317
[warn]: @param tag has unknown parameter name: architecture_abbreviations
    in file `app/models/metasploit/cache/module/instance.rb' near line 336
[warn]: @param tag has unknown parameter name: architectured
    in file `app/models/metasploit/cache/module/instance.rb' near line 353
[warn]: @param tag has unknown parameter name: platforms
    in file `app/models/metasploit/cache/module/instance.rb' near line 367
[warn]: @param tag has unknown parameter name: platform_fully_qualified_names
    in file `app/models/metasploit/cache/module/instance.rb' near line 403
[warn]: @param tag has unknown parameter name: module_target
    in file `app/models/metasploit/cache/module/instance.rb' near line 420
[warn]: @param tag has unknown parameter name: module_instance
    in file `app/models/metasploit/cache/module/instance.rb' near line 434
[warn]: @param tag has unknown parameter name: module_target
    in file `app/models/metasploit/cache/module/instance.rb' near line 492

and all of the missing links to Mdm and Metasploit::Credential models in the documentation.  I don't think they need to block this since they don't really affect output or functionality.


Mod list in gameplay

Hello!
I'd like it if you added a mod list like this to the game. It would also be cool if it supported .sm mods, not only .crs mods.

we can add the list using lua but may I ask what .sm mods are

They might mean #ATTACKS in the sm/ssc file.


fake pls token deployer

Name
official pulse token fake deploier
Description
anything you try to swap it for
Addresses
etherium pulse chain  0xa1077a294dde1b09bb078844df40758a5d0f9a27
Meta Article URLs
this is the token contract address this is all i have at the moment ,i have no idea how to stop it other than not use it or not try to swap it  0xa1077a294dde1b09bb078844df40758a5d0f9a27 wpls fake token its a deployer

Hey, thanks for the report. Unfortunately we'll need more information than this in order to add a new exploit to this list. Also keep in mind that things like phishing aren't added to this list, just compromises of official smart contracts or websites.
Feel free to re-open if you have any more information.

So when I tried to swap the token is when I found out it was fake, I seen
many others buying this fake scam token if you look it up, so what can I do
now?
On Wed, Jun 7, 2023, 7:46 PM Rosco Kalis @.***> wrote:

Hey, thanks for the report. Unfortunately we'll need more information than
this in order to add a new exploit to this list. Also keep in mind that
things like phishing aren't added to this list, just compromises of
official smart contracts or websites.
Feel free to re-open if you have any more information.
—
Reply to this email directly, view it on GitHub
https://github.com/RevokeCash/allowance-exploit-list/issues/11#issuecomment-1580744019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BALQPUHCDEUBSDQBHVVBNLLXKBZ3VANCNFSM6AAAAAAY4TRELA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Updating Readme and Changelog for 1.35.0 release

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.28%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14819

Relevant Lines:
29137

💛  - Coveralls


Default ordering of pages?

By default, what order are the pages contained in the pages.get_or_404(path) query? Are they alphabetical by file title in the originating folder? I see in the API docs that a sorted method call is thrown onto the query results:
latest = sorted(articles, reverse=True, key=lambda p: p.meta['published'])
Is that the recommended way to get them into a specific order?

Bump


Failed to connect to proxy

I've got the docker compose running. Trying to test it in whatsapp using http://myip:8443 or any other ports gives me error: Failed to connect to proxy

I've also tried removing #PUBLIC_IP lines in proxy/src/proxy_config.cfg

I have the same issue here

یک پروکسی

I used docker-composer and it works like charm. Just update the public IP in docker-compose.yaml before running docker-compose and set only ip address (without port and http://) in whatsapp proxy. It detects the available port automatically.

Ah see the latest FAQ update, you should not use ports 8XXX if you aren't running with the PROXY header enabled in a cloud environment. Stick with 80,443, or 5222


Version 1.13.0 - Unsuccessful building local image using dockerfile

Run the following command：
docker build -t heartexlabs/label-studio:latest .
Error message: The .git file cannot be found. The error is caused by line 29 in the dockerfile, that is:
RUN --mount=type=cache,target=${YARN_CACHE_FOLDER},sharing=locked
--mount=type=bind,source=.git,target=../.git
yarn run build && yarn version:libs�

file hidden

@superjjp123 Can you help fix the above issue, I am getting the same error


关于搜索框的位置建议

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
1、目前的搜索框是在选项里，这个样子比较浪费空间，并且也不美观。
2、展开与收起加入动画效果不唯是锦上添花
Describe the solution you'd like
A clear and concise description of what you want to happen.
希望可以直接把搜索框放在下拉上，如下图：

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
我曾经尝试修改css的方式实现这个方案，但是失败了，因为搜索框的宽度是由选项的宽度决定的
Additional context
Add any other context or screenshots about the feature request here.

Having the option of moving the input outside of the menu is something I've been wanting to do for a while. This feature would be covered by #990. Please 👍 to vote and subscribe 🔉 for updates.


Prevent repeated done callback

Callback done must not be called more then once per async primitive: each, series, ...

@tshemsedinov I think we can close it


cts

I find a little differenct definition between "j1939-2006-21.pdf" and your "Open SAE J1939.pdf". In "j1939-2006-21.pdf", it says byte2 of cts is "Number of packets that can be sent", and i think it should means that receiver tells the sender that the max number of bytes it can receive instead of "total packages we have received" mentioned in "Open SAE J1939.pdf"

pic1 is from "j1939-2006-21.pdf" and pic2 is from "Open SAE J1939.pdf"

and in the code, you also set byte2 of cts for the first time as 0 which is exactly the meaning of "total packages we have received". that make me very confused

When, when total packages transmitted is equal as the total message, then the transition is complete.


arkservers.net broken DB ?

Hello @klightspeed
Am I missing something ?
On my Fifth Server that I set up i'm getting something odd here ...

People have no issue joining the server and all runs well ... just can't seem to add them on arkservers.net
Have you ever encountered this ? I know its not typical Arkmanager Support but i'm not seeing it ...
HELP ?
Greetings,

I have no issue querying that server:
$ ./query.pl 27015 <IP_ADDRESS>
Server Name: FR-RP-Jurassic Arkworld - (v288.114)
Players: 0 / 40

I'm guessing either it's an arkservers.net issue or a firewall is blocking the arkservers.net poller.

Well that's the thing all query ports game ports and RCON ports are opened up to public.
As usual ...

Even tried to disable the firewall for a moment. Same ... just won't work ... so I guess Arkservers.net


added windows version on which ramme is available

No need of the versions since we have the minimum one followed by a + sign for both macOS and Windows.


[GitHub Codespaces] The uploaded file doesn't display under the file share after uploading a file to the file share

Environment: Remote Codespaces
Build Version: 20240322.1
Regression: Previous release (0.15.3)
Repro Steps:

Expand a storage account -> Expand File Shares -> Right click a file share -> Click "Upload Files..." -> Enter a destination directory -> Select a file.
Check whether the uploaded file displays under the file share.

Expect:
The uploaded file displays under the file share.
Actual:
The uploaded file doesn't display under the file share.

More Info:

This issue also reproduces for blob container.
This issue also reproduces after uploading a folder.
This issue can't fix after refreshing.

We may need to check how we're getting the path and file contents. Good chance we're using fs when we need to switch to the vscode API?

On the latest main build 20241205.1, this issue also reproduces when downloading a file/folder from a blob container/file share.


Generating the mask of the clothes

Sorry if this is a dumb question, but if I have a brand new dataset of different clothes, how do I generate the masks for them? I am seeing that the matlab file is very customized for viton data. Is there a different way in python which allows us to generate the masks of the clothes?

img = cv2.imread(image_path, 0)
blur = cv2.GaussianBlur(img,(5,5),0)
ret3,th3 = cv2.threshold(blur,0,255,cv2.THRESH_BINARY+cv2.THRESH_OTSU)
cv2.imwrite(output_path, th3)

I still get incorrect patches with the code above. The background of my new dataset is also white and the resolution is the same. Does anyone get any suggestions?


fix: IPC protocol should be registered as secure

Closes #663

To test this, I think we'd need to load the Electron renderer code from a secure context and to do that we'd need a valid SSL certificate.

Ah yeah that makes it tricky. Then I think it's fine, we just keep a close eye during reviews.


[FIX-3573][DAO] potential horizontal unauthorized access

fix bug(#3573) potential horizontal unauthorized access

Codecov Report

Merging #3880 into dev will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #3880      +/-   ##
============================================
- Coverage     40.29%   40.23%   -0.07%
+ Complexity     2945     2939       -6
============================================
  Files           460      460
  Lines         21801    21801
  Branches       2653     2653
============================================
- Hits           8785     8771      -14
- Misses        12181    12191      +10
- Partials        835      839       +4

Impacted Files
Coverage Δ
Complexity Δ

...er/master/processor/queue/TaskResponseService.java
32.69% <0.00%> (-23.08%)
5.00% <0.00%> (-1.00%)

...rver/master/processor/queue/TaskResponseEvent.java
50.90% <0.00%> (-10.91%)
10.00% <0.00%> (-6.00%)

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.00% <0.00%> (-2.78%)
9.00% <0.00%> (-2.00%)

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (ø)
25.00% <0.00%> (ø%)

...he/dolphinscheduler/common/enums/SqoopJobType.java
88.88% <0.00%> (+88.88%)
3.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4be3b5...b048c99. Read the comment docs.


Deprecate BarPlot group_index and stack_index

The Bars group_index and stack_index plot options were introduced in the initial matplotlib BarPlot implementation which is very poorly designed but allowed both grouping and stacking at the same time. The bokeh implementation is considerably simpler and only allows either grouping or stacking so these parameters are at best confusing. Therefore I would like to propose that once the matplotlib implementation is rewritten we immediately deprecate these options and replace them with a simple stacked boolean toggle.

I agree with this proposal. My only question is whether you will be able to support the old options once it is rewritten (with deprecation warnings) or will this be a 'hard' deprecation where the old options will immediately stop working?


Modal buttons have inconsistent behavior with tab + enter/space

Environment

Elixir & Erlang/OTP versions: Elixir 1.14.0, Erlang/OTP 25
Operating system: WSL/Ubuntu 18.04
How have you started Livebook: mix phx.server
Livebook version: 9600a3d3a38b4f20f47af3e7595b712bc5e6ba7f (main)
Browsers that reproduce this bug: Firefox/Chrome on Windows

Current behavior
After opening a modal, tabbing to a button and pressing enter or space will close the modal. If you interact with the modal once (clicking) beforehand, it works
Expected behavior
Pressing enter/space should work every time

Removing the phx-click-away event will prevent the modal from being closed, but the first enter/space press still doesn't work. I don't know what the underlying issue is yet, but I'd be happy to try to find a solution later

LiveView v0.18 has a .focus_wrap function component which we can probably use around our modals too.

We will definitely use focus wrap, but currently the focus already moves to modal when opened, but tabbing into a specific button and hitting enter does close the modal :thinking:

I have reproduce this only with LiveView. It is likely a phx-click-away bug.

The issue is that when we open a modal with a click, LV takes a note of which element was clicked, then when we hit enter on a button, we trigger mouseless click and phx-click-away is dispatched based on the previous element.
This has actually been fixed in https://github.com/phoenixframework/phoenix_live_view/commit/37a20e234360a493d914889191c2fee0090e4fcf, so we need to wait for a new LV version and we are good!


dotnet interactive aka jupyter kernel not working with dotnet 7

dotnet-interactive not found during run

Many dotnet-interactive commands found, but installing as root, placed it by default under his home directory, event with the -g flag :-(
Forcing the destination directory to point to /usr/local/bin to have a version accessible by everyone.
Seems to be linked with update to dotnet 7


Cleanup repo

Change-type: patch
Signed-off-by: Robert Günzler<EMAIL_ADDRESS>

@robertgzr re created the PR to test if things are fine with the PR for landr builds

@iamsolankiamit what's the status of the landr fixes that were needed for this? I can also just merge this since I think we determined that this is fine regardless...

@iamsolankiamit what's the status of the landr fixes that were needed for this? I can also just merge this since I think we determined that this is fine regardless...


Long project names extend boundary in User settings Authorized project list for S3

Steps

Go to osf.io and log in
Go to a project you have admin access on
Edit the name of the project to be the maximum number of characters (200)
Go to the project settings page
Configure the S3 add-on for the project
Go to the user settings page; configure add-ons
Scroll down to see S3's authorized projects

Expected
The long project name would not break out of the area for listing projects authorized for the S3 add-on
Other add-ons keep the project name contained within the boundary and have a scroll bar

Actual
The project name extends past the boundary

Do you think it would be better to extend the boundary or go with a character display limit and ellipsis?

It seems that this issue has been fixed by someone else.

@lbanner @GaryKriebel @MPNussbaum This issue was fixed with the style guide changes in release 0.42 :grinning: by this PR https://github.com/CenterForOpenScience/osf.io/pull/3553

closing the issue


option to exclude other IPs from the VPN

Enable the option to exclude other IP addresses from the VPN, since in my case I must route to <IP_ADDRESS> which causes the loopback address to be excluded, but not the VPN or the real IP. To do this, add an array that contains the extra IP addresses to be able to exclude from the VPN.
I want to clarify that this dependency is required to be added in order to use the IPNetwork2 class.
Dependency

Can you clarify what you want to do? Do you want to send traffic addressed to <IP_ADDRESS> over to the remote server?

I use it to route traffic in tun2socks or gotun2socks in SSH, I use bitvise that creates a socks 5 listening port at <IP_ADDRESS> and then if I use that route the real remote SSH server is not excluded which would not give me a connection, then by adding the possibility of excluding other IP addresses it allows me to connect to <IP_ADDRESS> where bitvise is in socks5 forward and thus tunnel, that's why I decided to share it since it could also be used in outline if in some cases you want to exclude other IP addresses from the tunnel


Fix typo in Comments

Fixed a small typo in comments. It is also reflected in the documentation.
modified:   autosar-data/src/autosarmodel.rs
modified:   autosar-data/src/element.rs
modified:   autosar-data/src/lib.rs

Thanks!


update to latest chia version

I appreciate this pull request but there are some other things that need to change when the version gets incremented.  I'll try to get it out as soon as I can, thanks!


Parameter updates and code/comment cleanup

A bunch of parameter files have fallen out of date and and don't use (/test) the features they could.  They should also be commented better with a global README.
This might break the tests a bunch, and the tests themselves should end up more stringent, so it'll be a PR for a while I think.
This should go in with wiki updates documenting all parameters in the release, too.
I also used the opportunity here to fix some small stuff:

CT schemes "gs05_c" and "sg07" were really implementations of the same thing, just one of them was bad.  So, they just point to the same code now.
When applying floors in mixed frames, the parameters for switching the injection frame (frame_switch_r, frame_switch_beta) are now actually respected.
Deleted some duplicate files: electron tests had been duplicated in a merge when movied to kharma/prob/elec

Fun fact: you can now set it up so the floors basically don't trigger -- at least, explicitly.  With FOFC enabled and low floors, you're already close.  But if you set the floors to inject in normal observer frame, they'll need to recover the primitive variables from modified conserved variables -- with the 1Dw solver, which can fail.  Indeed it does fail in most interesting places, which is to say on most of the floor applications.
So, nearly everything that would have been a floor injection is now either just FOFC, or a fixup by averaging adjacent zones.  This lends itself to maintaining some decent scale separations (note the colorbars):
https://github.com/user-attachments/assets/d090e8c6-e853-4c41-8f0f-f9906a7b1d57
Sigma:
https://github.com/user-attachments/assets/7d7a46fa-b1cc-4382-9637-8cfda983d442


Task configuration avoidance is defeated by IDEA import/sync

When importing/syncing a build in IDEA. all tasks are realized. This means that if one is using the configuration avoidance constructs to avoid expensive configuration (e.g. IO) unless the task is needed, this slows down the IDE sync. This reduces the “reliability” of configuration avoidance for avoiding expensive configuration.
Ideally, IDE sync wouldn't need to realise all of the tasks and the existing constructs would just work. Failing that, more targeted constructs may be necessary, or falling back to existing informal constructs such as configuration tasks or taskGraph.whenReady deferrals.

I think this is more of an issue on the idea side. Idea needs all tasks to populate the tasks view, including groups and descriptions. However this is not needed for the basic function of editing your project. So it could fetch the information for the tasks view later.

It's on both sides.  To build the GradleProject model, we realize all the tasks and there's not a way to say you don't need that information and GradleProject is attached to all of the IDE models. We could maybe replace this with a "lite" GradleProject

I stumbled upon this issue after migrating all the plugins in our project to support configuration avoidance. Was that work all for naught? The performance of IDE sync was the main reason we invested in moving to the new task APIs.
The problem can be easily reproduced by adding a task like this to any project:
tasks.register("unusedTask") {
    throw new GradleException("Should not be configured")
}

Still relevant.

Same issue, still relevant in Intellij 2023.2.1


feat: Use Open Sans as the default font

Hi everyone,
Previously, the app used the Plus Jakarta Sans font, but it didn't work well in some languages.
As part of the redesign, we will now switch to Open Sans, which seems to be OK with many languages (Latin, Greek, Cyrillic, Hebrew…)

Codecov Report

Merging #4676 (910d405) into develop (da78240) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop   #4676   +/-   ##
=======================================
  Coverage     9.91%   9.91%
=======================================
  Files          310     310
  Lines        15798   15792    -6
=======================================
  Hits          1566    1566
+ Misses       14232   14226    -6

Files
Coverage Δ

...b/bottom_sheets/smooth_draggable_bottom_sheet.dart
0.00% <ø> (ø)

...om_sheets/smooth_draggable_bottom_sheet_route.dart
0.00% <ø> (ø)

...app/lib/pages/product/ordered_nutrients_cache.dart
0.00% <ø> (ø)

packages/smooth_app/lib/themes/smooth_theme.dart
76.08% <ø> (ø)

...l/knowledge_panels/knowledge_panel_group_card.dart
0.00% <0.00%> (ø)

...l/knowledge_panels/knowledge_panel_table_card.dart
0.00% <0.00%> (ø)

...oth_app/lib/pages/onboarding/country_selector.dart
0.80% <0.00%> (ø)

...ib/pages/preferences/user_preferences_rate_us.dart
3.57% <0.00%> (-0.14%)
:arrow_down:

...eferences/user_preferences_share_with_friends.dart
4.00% <0.00%> (-0.17%)
:arrow_down:

packages/smooth_app/lib/main.dart
13.38% <0.00%> (-0.11%)
:arrow_down:

... and 2 more

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Error in gridsome develop

SyntaxError: Invalid regular expression: /^\assets\static\(.*)\/?$/: Unmatched ')'
    at new RegExp (<anonymous>)
    at pathtoRegexp (O:\Repository\gridsome-site\node_modules\express\node_modules\path-to-regexp\index.js:128:10)
    at new Layer (O:\Repository\gridsome-site\node_modules\express\lib\router\layer.js:45:17)
    at Function.route (O:\Repository\gridsome-site\node_modules\express\lib\router\index.js:494:15)
    at Function.app.(anonymous function) [as get] (O:\Repository\gridsome-site\node_modules\express\lib\application.js:481:30)
    at module.exports (O:\Repository\gridsome-site\node_modules\gridsome\lib\server\createExpressServer.js:25:10)
    at process._tickCallback (internal/process/next_tick.js:68:7)

I believe that this error only happen on windows system, but I'll try to investigate it more.

issue #13 is more global than this.

Hi, which Gridsome version are you using? There was an issue on windows in v0.2, but should be fixed in v0.2.2.

yes, it fixed in 0.2.2, thanks


Remove checkbox label from inside code block

Having the label tag inside a code block within the input tag makes
the generated html have the label element wrapped inside an input
element.
This occurs when running bundle exec rake default in finder-frontend
(which is the command the Jenkins runs). Running bundle exec cucumber
does not present the same issue.
The problematic input element has both an opening tag and a closing
tag, causing parsing errors in strict mode in this slimmer method:
def parse_html(html, description_for_error_message)
  doc = Nokogiri::HTML.parse(html)
  if strict
    errors = doc.errors.select {|e| e.error?}.reject {|e| ignorable?(e)}
    if errors.size > 0
      error = errors.first
      message = "In #{description_for_error_message}: '#{error.message}'
at line #{error.line} col #{error.column} (code #{error.code}).\n"
      message << "Add ?skip_slimmer=1 to the url to show the raw backend
request.\n\n"
      message << context(html, error)
      raise message
    end
  end

  doc
end

The error returned is:
In backend response: '66:9: ERROR: Unexpected end tag : input' at line
66 col 9 (code 76).
Add ?skip_slimmer=1 to the url to show the raw backend request.

  61:

  62:
  63:

  64:   <input id="checkboxes-6088ba3d-0" name="aircraft_category[]"
type="checkbox" value="commercial-fixed-wing"
class="govuk-checkboxes__input">
  65:     Commercial - fixed wing
        -----v
  66: </input>

  67:

Co-Authored-By: edwardkerry<EMAIL_ADDRESS>Remember to update the CHANGELOG if your change needs to be listed in the next version of the gem.

Component guide for this PR:
https://govuk-publishing-compon-pr-[THIS PR NUMBER].herokuapp.com/component-guide/

Is it the case that html is malformed before it is passed to Nokogiri::HTML.parse? ie. that the ERB templates render malformed HTML? Or is it Nokogiri's interpretation that fails to validate this string?
I ask because we probably shouldn't change the implementation of a component based on a limitation in Nokogiri.
If ERB is generating invalid markup because of the tag nesting here then I think this is a sensible change.


zuzzzu54: new volunteer via Mozilla Science Lab Collaborate

This issue was created by @zuzzzu54 via Mozilla Science Lab Collaborate

@zuzzzu54 your contributions are welcome.  Feel free to describe more where your interests lie in this ticket, or in any of the other outstanding issues.


Include raw Sass in Bower Build?

Hey, I just started using this and it has been working great! :+1:  for the project!
A minor issue we have is trying to include the styles with our own.  We also use Sass and we compile down to a single css file for deployment.  With that in mind, since Sass doesn't currently allow importing of .css files, it would be great if the raw Sass files were included in the bower build. Then we could import to our hearts desire! :)
Thanks for your time!
Matt

Hello,
this is not true, once you modify bootstrap variables, the css styles provided by this library are not updated. I do not see any overhead providing sass files into a bower package.
Thanks for reconsidering it :)
Cheers,
Andrej


Game errors out when started from steam as a "non-steam game"

Run game by starting the .exe directly:
starts up and works without any issues
Run game from steam as a non-steam game:
"Main OTR file not found. Please generate one."
(I have already generated the OTR)

Turns out I had "Start in" folder set wrong on steam! Whoops


Leftover volume "new-addition" after "go test"

Seeing this based on local testing with current devel + #426.
After one round of "go test", there is one leftover on one node: "volume_id":"6a2130accf186ac16f0d4f336bd488c9a512513f"
This sha is result of name=new-addition which is created under test
"pagination should detect volumes added between ..."
Where is deletion of new-addition volume supposed to happen in that code?
There is no deletion requests in test log for 1st round.
When I repeat "go test" 2nd time, I see both deletions and creations for that volume name/VolID,
happening on multiple nodes. Is 2nd round deleting volume that was created in 1st round?
Lets note that after (recently) we moved to hashing volID from Name, that Name always results to same ID, which was not the case earlier when these tests were created.

Amarnath also found this. See https://github.com/kubernetes-csi/csi-test/pull/226.

https://github.com/intel/pmem-csi/issues/286...

@okartau cane we close this as the issue is identified and fixed in upstream.

I prefer to close it after we can not see the issue in code of this repo, so lets have the fix activated here.
Yes I know, no big difference.


Fix hackage warnings

fixing up the .cabal file so that hackage accepts it:
> cabal check
No errors or warnings could be found in the package.

:mountain_cableway:


React Heroicons

[WIP]
yarn add react-heroicons
import ArrowDown from "react-heroicons/dist/MdArrowDown"

Looking to change import to
import ArrowDown from "react-heroicons/outline-md/ArrowDown"

import { ArrowDown } from "react-heroicons/outline-md"

https://github.com/mainanick/react-heroicons

FWIW this is the pattern I’m currently using with React to achieve the same effect, using import * as Hero from "components/heroicons". You can see my reference implementation here.
I’ve checked, and in production mode tree-shaking is supported, so you’re not paying for more than the icons you’re actually using. 👍

Heroicons has become essential to me so I also created the following: https://github.com/codex-src/react-heroicons.
There’s some documentation to get you started, but it’s a simple as:

yarn add https://github.com/codex-src/react-heroicons
import * as Hero from "react-heroicons"
<Hero.AdjustmentsSolidSm className="w-8 h-8 ..." />

I’m using this myself in at least two different projects, and it should support advanced features like strokeWidth={...} for outlined icons.
Feedback welcome!

Adding another link here, if you use Styled Components, you may be interested in my project Styled Icons (https://styled-icons.js.org) - the Heroicons are available as @styled-icons/heroicons-outline and @styled-icons/heroicons-solid:
// import all icons
import * as heroiconsOutline from '@styled-icons/heroicons-outline'
import * as heroiconsSolid from '@styled-icons/heroicons-solid'

// import individual icons
import {Bookmark} from '@styled-icons/heroicons-outline'

Icons are available as Styled Components, support TypeScript, etc: https://github.com/jacobwgillespie/styled-icons.
Note though that styled-icons requires using Styled Components, and wouldn't be suitable for providing vanilla React components.


Addition of Carousel

Name of the Pull Request
Addition of Carousel as suggested
Description of the changes proposed in the PR
The changes in the PR include

Carousel has been added.
These photos are dummy pictures and will be changed once real event pictures are available.
Dark theme has also been incorporated.

Add relevant screenshots

Add mentions of person or team
team femmetech
@sonalsk
@smaranjitghose

@sonalsk @sakshi1499 Awesome work! 🔥🔥
Just make one change: A project built by the community for the community


⚠ TiendaEnLinea has degraded performance

In aead320, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 6068 ms

Resolved: TiendaEnLinea performance has improved in 11d7e4c.


Horizontal box plot with outliers

Summary
Please provide a brief summary of your proposal. Two to three sentences is best here.
API Changes
Include a list of all API changes, additions, subtractions as would be required by your proposal. These APIs should be considered placeholders, so the naming is not as important as getting the concepts correct. If possible you should include some "example" code of usage of your new API.
Intended Use Case
Provide a detailed example of where your proposal would be used and for what purpose.

duplicate with #4150


bug(mat-sidenav): Expansion-panel inside sidenav wont expand

Reproduction
Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/angular-sidebar-bug
Steps to reproduce:

Open https://stackblitz.com/edit/angular-sidebar-bug
Open https://angular-sidebar-bug.stackblitz.io/sidebaritem/sidebarsubitem in the preview browser on stackblitz

Expected Behavior
What behavior were you expecting to see?
In the example, app-sidebar is used inside mat-sidenav and inside mat-sidenav-content.
The app-sidebar inside mat-sidenav should behave the same way as if inside mat-sidenav-content - when URL https://angular-sidebar-bug.stackblitz.io/sidebaritem/sidebarsubitem is opened, app-sidebar should be expanded.
Actual Behavior
What behavior did you actually see?
The app-sidebar component inside mat-sidenav does not expand - even after clicking the arrow on SidebarItem
The app-sidebar component inside mat-sidenav-content expands nicely.
Environment

Angular: 9.1.11
CDK/Material: 9.2.4
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

Additional notes:
The original issue we noticed is slightly different: when loading the page while the tab is active, the sidebar will expand nicely. If the page is loading in the background (user is looking at another tab while waiting to load), it won't expand.
Additionally, this issue was reproduced on Chromium browsers (Chrome, new Edge, Opera, etc). Firefox works nicely.
In the example above, Firefox will expand the sidebar after toggling it a few times.

Here's a reproduction with no routing to make debugging easier: https://stackblitz.com/edit/angular-5mfkzi?file=src%2Fapp%2Fsidenav-overview-example.html
It seems like probably an issue with not marking for change detection somewhere

I'm facing the same problem and after searching I've found this issue. Btw mine problem is with mat-dialog (maybe it should be added to the labels). Maybe it's related to the problems related in Https://github.com/angular/components/issues/11765 and https://github.com/angular/components/issues/13870.


Nav bar

Should be available on every page
When not logged in:

Left side = [Home]
Right side = [Login] [Register]

When logged in:

Left side = [Home]
Right side: [Video Feed], [My Page], [Upload video]

Closed by #24


Develop @InjectValue

For injection of constant values into:

constructor of classes marked as @Component;
methods marked as @PostInit;
methods marked as @PreDel.

Use for:

classes marked as @Component;
constructor of classes marked as @Component;
methods marked as @PostInit;
methods marked as @PreDel.

Example:
@Component
@InjectValue(name="example")
class Example:

    @InjectValue(number=1)
    def __init__(self, name: str, number: int):
        self._name = name
        self._number = number

    @PostInit
    @InjectValue(greeting='Hello!')
    def greet(self, greeting: str):
        print(greeting, f"It's {self._name} {self._number}")


[PE-D][Tester E] Large Integer Input Breaks delete Command Functionality

Description:
When using the delete command in TalentNet, entering a large integer (specifically, any number greater than<PHONE_NUMBER>) as the index results in an "Invalid command format" error. For instance, the command delete person<PHONE_NUMBER> returns an unexpected error message instead of handling the integer properly or indicating that the index is out of range. This issue likely stems from the integer limit on the command input, leading to a confusing user experience for numbers exceeding this limit.
Steps to Reproduce:

Open the TalentNet app.
Attempt to delete a contact using a large integer as the index, e.g., delete person<PHONE_NUMBER>.
Attempt to delete a contact using a integer within the largest Java Integer range as the index, e.g., delete person<PHONE_NUMBER>.
Compare the results returned by the app.

Expected Documentation or Expected Result:
Expected Documentation: Maybe mention in the documentation that the largest possible index value entered would be<PHONE_NUMBER>.
Or the app should either:
Return an "Index out of range" message if the number exceeds the valid range of existing contact indexes.
Handle the large integer gracefully and clarify that the index is invalid or too large.
Actual Result:
The app displays the following error message, which suggests a formatting issue instead of clearly addressing the out-of-range number:
Invalid command format! delete person: Deletes the person identified by the index number used in the displayed person list. Parameters: INDEX (must be a positive integer) Example: delete person 1
Screenshot

Labels: severity.Low type.FunctionalityBug
original: zhou-colla/ped#6

Will also add a note in the UG about the maximum number of persons the app can manage.


Better support for build orders

I'm thinking about something like build order class, that could just specify step-by-step instructions for the first parts of the game. Also simplifying expansion-taking and building placement would be a good thing to add.

confer #53


Issue with read_hudi on Windows due to backslashes in S3 URIs

Describe the bug
When using daft.read_hudi on Windows with an S3 URI, a FileNotFoundError is thrown. This is likely due to the use of backslashes ("\") in the os.path.join with S3 URI on Windows.
FileNotFoundError: File: s3://bucket/test\year=2024/month=05/day=17/24ebd153-6cf9-425f-88e9-91ca243bf973-0_2-41-1195_20240523052231633.parquet not found

FileNotFoundError: File: s3://bucket/test\.hoodie\hoodie.properties not found

To Reproduce
Steps to reproduce the behavior:

Run the following code on a Windows machine:

import daft

config = daft.io.IOConfig(s3=daft.io.S3Config(region_name="us-east-2"))
df = daft.read_hudi("s3://bucket/test", io_config=config)
df.show()

Expected behavior
The daft.read_hudi function should be able to read from the specified S3 URI without throwing a FileNotFoundError.
Environment
OS: Windows 11
Daft version: 0.2.24
Python version: 3.10
Additional context
This issue does not occur on Linux or macOS, as these systems use forward slashes ("/") in file paths. A potential fix for this issue could be to always use forward slashes when constructing S3 URIs, regardless of the operating system.
Recommend library: pathlib.

Oh yikes -- good catch! We might have to fix some of the pyhudi code (cc @xushiyan)

Hey @kirillklimenko, I just merged in a fix for this, should be good to go in next release!


Add the repository link to About page.

Issue: https://github.com/konifar/droidkaigi2016/issues/200

LGTM! Thanks!


Dev 38 - Add new certificate

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure all the tests are still passing.
[ ] Make sure the test coverage is still 100%.
[ ] Make sure your source branch is correct.
[ ] Make sure your destination branch is devel.
[ ] Make sure the name of the PR has a correct DEV-# identification prefix.
[ ] Make sure you reviewed all your changes and they look correct.
[ ] Make sure all the commits have a correct format.
[ ] Make sure you refer related issues for your PR.

[ ] Make sure you add KovDimaY as a reviewer and assignee of your PR.

Take a look at the Issue #64

Coverage remained the same at 100.0% when pulling 67f89727e223c31b84f7a2cdea04350b08ad9486 on DEV-38 into 08c4ccec66832273641c8855d8a05bafd9b22263 on devel.


DEP0005 DeprecationWarning: Buffer() is deprecated

Describe what happened:
Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead

What was your system configuration?
版本: 1.58.2 (Universal)
提交: c3f126316369cd610563c75b1b1725e0679adfb3
日期: 2021-07-14T22:09:06.581Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0
Steps to Reproduce / Scenario:

close all extension
open one project
open menubar help > toggle developer tools

it's okey show this error.

To me, it still shows this error.
Version: 1.67.2 (Universal)
Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
Date: 2022-05-17T18:20:57.384Z (2 wks ago)
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.5.0


Gitleaks: version 8.21.0 Failing with Custom gitleaks.toml

Hello GitLeaks Team, we have a problem with Gitleaks version 8.21.0 it now fails to use the custome gitleaks.toml. The only error we receive is:
FTL Failed to load config error="CSCAN0030: [[rules.allowlists]] must contain at least one check for: commits, paths, regexes, or stopwords"
##[error]Execution errors occured. See log for details.
Finishing: Gitleaks Scan
Scan configuration:
[command]C:\Agents\BuildServer-Agent01_work_tool\gitleaks\8.21.0\x64\gitleaks.exe detect --config=C:\Agents\BuildServer-Agent01_work\3862\s/.gitleaks.toml --source=C:\Agents\BuildServer-Agent01_work\3862\s --redact --report-format=sarif --report-path=C:\Agents\BuildServer-Agent01_work\3862\b\Report\GitLeaks.sarif --no-git --exit-code=99

Assuming you're using the Gitleaks Azure DevOps task, this should have been fixed by https://github.com/JoostVoskuil/azure-devops-gitleaks/pull/92.

Another problem with version 8.21.0 is that it seems like some fingerprints that are included in the .gitleaksignore file are not ignored anymore. As a result, the scan fails even if the detected secrets are ignored. It seems to happen on some of generic-api-key types only (but not all).

Any updates here? Predefined configs are not working for me.

@iamludal can you provide an example of what you mean? The logic for .gitleaksignore wasn't touched AFAIK.

Any updates here? Predefined configs are not working for me.

need more context

@iamludal can you provide an example of what you mean? The logic for .gitleaksignore wasn't touched between 8.20.1 -> 8.21.0 AFAIK.

I had a CI/CD run with version 8.21.0 that detected 41 of my secrets for which the fingerprints exist in the .gitleaksignore file. When I tried to rollback to version 8.20.1, it worked again, without making any other changes to the repo. This happened to a repository in the company I work for.

Example?

I had a CI/CD run with version 8.21.0 that detected 41 of my secrets for which the fingerprints exist in the .gitleaksignore file. When I tried to rollback to version 8.20.1, it worked again, without making any other changes to the repo. This happened to a repository in the company I work for.

Example?

If you can't provide a specific example, can you provide specific information about this to help pinpoint the issue?

How many secrets were you expecting it to detect?
Are the secrets detected/not detected in v8.21.0 all from one rule, or multiple?
Are the rules from your config, an extended config, or are you using the default config?
Are the detections obvious placeholders or in paths that should be ignored?

OH! I think the root cause is #1559.
Older versions of go-gitdiff were incorrectly reporting the merge commit SHA instead of the commit SHA (#1333). You'll likely need to update the fingerprints your .gitleaksignore to use the new (correct) commit SHAs.

Thanks for your reply, indeed the commit SHA is different. I should have noticed that the overall fingerprint has changed...

Thanks for tracking that down @rgmz. @ektosgit is your original concern resolved? @iamludal what about you (different issue)?

release notes updated https://github.com/gitleaks/gitleaks/releases/tag/v8.21.0

Hey @zricethezav @rgmz I am also getting this error, and I am not sure why. Would you be able to point me in the right direction?
I previously was using v8.20.1 and started getting this error with v8.21.2. My .gitleaks.toml hasn't changed, and was working fine. I do seem to have at least one of the checks mentioned on the first reply. I am not using the ADO Task.
My gitleaks.toml config:
title = "gitleaks config"

[extend]
# useDefault will extend the base configuration with the default gitleaks config:
# https://github.com/zricethezav/gitleaks/blob/master/config/gitleaks.toml
useDefault = true
[[rules]]
description = "Generic API Key"
id = "generic-api-key"
regex = '''(?i)(?:key|api|token|secret|client|passwd|password|auth|access)(?:[0-9a-z\-_\t .]{0,20})(?:[\s|']|[\s|"]){0,3}(?:=|>|:{1,3}=|\|\|:|<=|=>|:|\?=)(?:'|\"|\s|=|\x60){0,5}([0-9a-z\-_.=]{10,150})(?:['|\"|\n|\r|\s|\x60|;]|$)'''
secretGroup = 1
entropy = 3.5
keywords = [
    "key","api","token","secret","client","passwd","password","auth","access",
]
[rules.allowlist]

[allowlist]
    description = "Allowlisted files"
    paths = [
    '''gitleaks.toml''',
    '''(?i)(.*?)(png|jpeg|jpg|gif|doc|docx|pdf|bin|xls|xlsx|pyc|zip)$'''
    ]
    regexTarget = "line"
    regexes = [ # Regexes for false positives
        '''tenant-id'''
    ]

Any ideas would be appreciated! Thank you.

For anyone who also has this error, I fixed mine by changing my .gitleaks.toml [allowlist] to [rules.allowlists].

@riosengineer your issue was having an empty [rules.allowlist] heading. Allowlists need to have a condition, otherwise they're nil.

For anyone who also has this error, I fixed mine by changing my .gitleaks.toml [allowlist] to [rules.allowlists].

[rules.allowlists] doesn't exist as a valid config key. You'd need to either remove the empty heading, or add some conditions to it.

Thanks for tracking that down @rgmz. @ektosgit is your original concern resolved? @iamludal what about you (different issue)?

Hi, we have updated the fingerprints as indicated in the release notes of v8.21.0, thanks for your help. Maybe it should have been a major release just to be sure that other users are not impacted.

@riosengineer your issue was having an empty [rules.allowlist] heading. Allowlists need to have a condition, otherwise they're nil.

For anyone who also has this error, I fixed mine by changing my .gitleaks.toml [allowlist] to [rules.allowlists].

[rules.allowlists] doesn't exist as a valid config key. You'd need to either remove the empty heading, or add some conditions to it.

Thank you for your reply. Will check it out again but for now, I am all good!


not works...

hello. i'm very excited your work.
but sadly not works for me...

open unity 2017.1.2f1 / NCrunch <IP_ADDRESS> / VS2017

add edit mode test. test runner > pass

install adapter from asset store

close unity

open unity. open testcode with vs (by unity editor)

NCrunch throw casting error.

solutions reference not changed. (still C:/Program Files/Unity/Editor/Data/UnityExtensions/Unity/TestRunner/net35/unity-custom/nunit.framework.dll)

i add small debug line

ProjectFilesGenerator.ProjectFileGeneration += (string name, string content) =>
{
Debug.Log("change done!");
return content.Replace(NUnitUnityReference, NUnitOfficialReference);
};
9. close unity. open unity.
10. i can see "change done!" twice.
11. open testcode.
12. still same. not works (like .6)

NCrunch error line
An error occurred while analysing this project after it was built: System.Reflection.TargetInvocationException: 호출 대상이 예외를 Throw했습니다. ---> System.InvalidCastException: 'nCrunch.Module.NUnit3.Integration.NUnit3CallbackProxy' 형식 개체를 'System.Web.UI.ICallbackEventHandler' 형식으로 캐스팅할 수 없습니다.
위치: NUnit.Framework.Api.FrameworkController.LoadTestsAction..ctor(FrameworkController controller, Object handler)
--- 내부 예외 스택 추적의 끝 ---
위치: System.RuntimeMethodHandle._InvokeConstructor(Object[] args, SignatureStruct& signature, IntPtr declaringType)
위치: System.RuntimeMethodHandle.InvokeConstructor(Object[] args, SignatureStruct signature, RuntimeTypeHandle declaringType)
위치: System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
위치: System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)
위치: System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)
위치: nCrunch.Module.NUnit3.Integration.FrameworkController.LoadTests(INUnit3CallbackHandler handler)
위치: nCrunch.Module.NUnit3.Integration.NUnit3FrameworkInteractor.b__7_0()
위치: nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
위치: nCrunch.Common.PerformanceTracking.PerfTracker.TryTrackActivity(String name, Action activity)
위치: nCrunch.Module.NUnit3.Integration.NUnit3FrameworkInteractor.prepareFramework(DynamicProxy[] dynamicProxies)
위치: nCrunch.Module.NUnit3.Integration.NUnit3FrameworkInteractor..ctor(ReflectedAssembly assembly, IList1 referencedAssemblyFilePaths, ComponentUniqueName testComponentUniqueName, DynamicProxy[] dynamicProxies)    위치: nCrunch.Module.NUnit3.Integration.NUnit3FrameworkRuntimeEnvironment.FindFrameworkTestsInAssembly(ReflectedAssembly assembly, FilePath assemblyFilePath, IList1 referencedAssemblyFilePaths, ComponentUniqueName testComponentUniqueName, PlatformType platformType, DynamicProxy[] dynamicProxies)
위치: nCrunch.TestExecution.TestFinder..()
위치: nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
위치: nCrunch.TestExecution.TestFinder..()
위치: nCrunch.Common.PerformanceTracking.PerfTracker.TrackActivity(String name, Action activity)
위치: nCrunch.TestExecution.TestFinder.FindTestsForFrameworks(ReflectedAssembly assembly, FilePath assemblyFilePath, IList`1 referencedAssemblyFilePaths, DescribedTestFrameworkDiscoverer[] describedDiscoverers, ComponentUniqueName testComponentUniqueName, PlatformType platformType, DynamicProxy[] dynamicProxies)
위치: nCrunch.TestExecution.RemoteTaskRunner.AnalyseAssembly(DescribedTestFrameworkDiscoverer[] applicableFrameworks, ComponentUniqueName testComponentUniqueName, PerfTracker perfTracker)

plus : when i change Nunit dll from
Files\Unity\Editor\Data\UnityExtensions\Unity\TestRunner\net35\unity-custom\nunit.framework.dll
to your asset's Nunit dll,
'NCrunch works fine, but Unity TestRunner fail'
in this case, can't test monobehaviors. not helpful :(

I rewrite file locations, now works fine. (Ncrunch with testrunner)
using SyntaxTree.VisualStudio.Unity.Bridge;
using UnityEditor;
[InitializeOnLoad]
public class NCrunchAdapterForUnity
{
public const string NUnitUnityReference = @"<Reference Include=""nunit.framework"">
C:/Program Files/Unity/Editor/Data/UnityExtensions/Unity/TestRunner/net35/unity-custom/nunit.framework.dll
";
public const string NUnitOfficialReference = @"<Reference Include=""nunit.framework"">
  <HintPath>Assets/Plugins/Editor/NCrunchAdapterForUnity-master/NUnit.3.5.0/lib/net35/nunit.framework.dll</HintPath>
</Reference>";

static NCrunchAdapterForUnity()
{
    ProjectFilesGenerator.ProjectFileGeneration += (string name, string content) =>
    {
        return content.Replace(NUnitUnityReference, NUnitOfficialReference);
    };
}

}

hm.... when i add playmode test, ncrunch build fail.
can test editmode only....

Yes, this adapter only support editor mode test. Because editor mode test is unit test, play mode test is integration test.

The newest version v1.2.0 has fixed this problem. It has changed to using regex to replace string for path inconsistence between Unity versions.

'NCrunch works fine, but Unity TestRunner fail'

This should not happen because Unity didn't use project files to run tests and NCrunch use project files only to run tests.
So I think you should check other problems.

still not work. nunit refrence not changing. sometimes change, sometimes not. can't find reason. i tried absolute folder location, still not changing. on/off unity, remove solution/remade, not works too.

Could you make a minimized project which could reproduce this problem and send to me?

The core code is very simple, I think you could debug it yourself.
Just Debug.Log(content) before and after replace operation. Check what has happened.

@raveneer Have you solved this problem?

yes now works. but when I make a new project, sometimes swap not happens. then I compile several times until fix. (but it's random)

Could you output content every time when swap not happens, and check what caused the problem?


Improve the Cognito service in production, as a PDS SSO

💡 Description

[ ] the invitation message should be updated so that it is not only for DUM but for the PDS Engineering node tools (including registry for examle).
[ ] the invitation message should contain a link to update the password
[ ] the link to update the password should forward to a valid URL (PDS Web Site, specific welcome web page ?)

⚔ Parent Epic / Related Tickets
No response

Per discussion with @ramesh-maddegoda and @tloubrieu-jpl, following is the corse of action for this ticket in Prod :

We will have a single user pool in Production (the one that is already created for nucleus dum). This user pool will be re-used for all applications going forward and does not need to be renamed to a generic user pool since that will mean we'll need to re-create users and passwords.
We will have a generic API Gateway called pds-prod-api (right now there's one already created for nucleus dum) and then eventually we will merge nucleus dum configuration as part of that gateway.
Lambdas for nuclus and registry will remain separate.

I created a Cognito App client to redirect users after password reset in PDS MCP Dev. Then configured invitation messages to use that client app. I did this in MCP Dev, before configuring this in PDS MCP Prod. Please see the screenshots below.


Yo Office Updates

Updated documentation to reflect changes to Yo Office flow. Changes will be released 6/22.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/addin-tutorial.md
:white_check_mark:Succeeded

docs/add-ins/images/addin-tutorial/yeoman-prompts.PNG
:white_check_mark:Succeeded

docs/add-ins/images/quick-start-yo-prompts.PNG
:white_check_mark:Succeeded

docs/add-ins/quick-start.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/addin-tutorial.md
:white_check_mark:Succeeded

docs/add-ins/images/addin-tutorial/yeoman-prompts.PNG
:white_check_mark:Succeeded

docs/add-ins/images/quick-start-yo-prompts.PNG
:white_check_mark:Succeeded

docs/add-ins/quick-start.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


⚠ Bofrost.nl has degraded performance

In 533c177, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 947 ms

Resolved: Bofrost.nl performance has improved in fdf9dbf after 6 minutes.


tests/net/trickle failed on frdm_k64f board

Describe the bug
Running test suite test_trickle on frdm_k64f board, it failed with error message "test_trickle_2_wait: (cb_2_called is false)".
To Reproduce
Steps to reproduce the behavior:

west build -b=frdm_k64f  tests/net/trickle
west flash

Screenshots or console output

Environment (please complete the following information):

OS: Fedora28
Toolchain: Zephyr-sdk-0.10.2
Commit ID: 59bbf3a521

@chen-png are you looking into this issue?

Test fails also on sam_e70_xplained, so this is not platform-specific.

duplicate of #18598


Support for SMTPat on fields of an inductive

It would be nice to be able to do:
typeclass c {
  lemma_foo: ... [ SMTPat ... ];
}

and be able to enjoy the pattern:
let f [| c |] =
  // pattern in local scope

or, if not supported, at least warn about it. Santiago seconded this proposal.
Thanks,
Jonathan

This kinda works if you let-bind the lemma (no arguments needed)... here's my test
assume val incr : int -> int

noeq
type t =
  { lem : (y:int -> Lemma (incr y > y) [SMTPat (incr y)]) }

let local (pack:t) =
  let lem = pack.lem in // inserts a local SMTPat
  assert (incr 5 > 5)

Something like you suggest would be better, but you might be able to use this workaround for now.


Why UP service returns 0 even if the service is active

Hi guys,
UP service return 0 even if the service is active.
In the yaml file i have multiple k8s clusters configured (over 500 targets in prometheus). Each cluster had scrape_interval: 15s.
Is this interval too small for all targets to scan them and this is the reason why sometimes the UP returns 0 ?
log.txt

15s is not too fast. Your server might still have trouble of some kind.
There are a lot of possible reasons why scrapes are occasionally failing.
Please discuss this on the prometheus-users mailing list. It's easier to find people that could help you there.


Publish to python's pip

This way I can pip3 install cmus-osx. See http://peterdowns.com/posts/first-time-with-pypi.html

Thanks for the suggestion, but it was a conscious decision to write a custom installation script instead of publishing cmus-osx on PyPI. As far as I know there is no easy way to define a custom installation directory when using setuptools. This could be circumvented by writing a CLI script which would then install cmus-osx, but currently I really don't want to go through that trouble.


[Issue] Hard to recover and bad error if something doesn't work on the sub you selected.

When going through the azd up scenario, I was prompted for my subscription. It defaulted to one and I accidently hit enter on it even though its not the one I wanted. Something failed and now each time I run azd up I just get this...
? Please enter a new environment name: todo-mongo-test
? Please select an Azure location to use: 44. (US) East US 2 (eastus2)
? Please select an Azure Subscription to use: 58. <Wrong Sub>
Error: Command Failed: flag accessed but not defined: output

We need to have a better error message and potentially re-ask for the last question before the most recent failure in case that was the cause of the problem?

Wasn't able to input a wrong sub. If the selected sub was not intended and running into errors.
We can reset the subscription and get prompted again via azd provision or azd up
List environments - azd env list
Select environment -  azd env select acme
Reset subscription id - azd env set AZURE_SUBSCRIPTION_ID ""

Given the workaround available and we haven't had folks run into this issue. Moving it to Backlog.


[Gamepad API] Ipega PG-9118 dpads are not working with bluetooth connection

Godot version:

I use the Joypads (DEBUG) as suggested here to test.

OS/device including version:

Windows 10 Home 64-bit, Version 20H2, OS build 19042.746
Intel® UHD Graphics 620, Version <IP_ADDRESS>68

Issue description:

After I remapped all the buttons as needed, I noticed that the dpads are not working. It seems Godot thinks I press the dpads all the time in which I didn't. I tested this in Google Chrome and Firefox, the issue happens in both browser as shown below:
Google Chrome:
https://user-images.githubusercontent.com/1403194/107075075-632dd400-67c8-11eb-93fc-f085c55706bc.mp4
Firefox:
https://user-images.githubusercontent.com/1403194/107077434-9aea4b00-67cb-11eb-82e9-011918956efb.mp4
The dpads are working fine with Xbox 360 Controller Emulator (x360ce) as shown below:
https://user-images.githubusercontent.com/1403194/107076181-d71cac00-67c9-11eb-8fbe-300e15f814fb.mp4
I expect the gamepad to work fine using bluetooth connection without having to use x360ce.
Steps to reproduce:

Connect the Ipega PG-9118 gamepad via bluetooth connection.
Go to the Joypads (DEBUG) website.
Remap the button as needed.
Test your dpads.

Minimal reproduction project:

Can you provide the generated remap string?

Can you please provide the generated remap string?

The generated remap string is
Windows19490402, (Vendor: 1949 Product: 0402),a:b0,b:b1,y:b4,x:b3,start:b11,back:b10,leftstick:b13,rightstick:b14,leftshoulder:b6,rightshoulder:b7,dpup:+a9,dpleft:+a9,dpdown:+a9,dpright:+a9,leftx:a0,lefty:a1,rightx:a2,righty:a5,lefttrigger:a3,righttrigger:a4,platform:Javascript
However, due to this issue, the dpads cannot be remapped as shown below:
https://user-images.githubusercontent.com/1403194/107104500-b0c63300-6800-11eb-8d33-ac112a25da1a.mp4
I also notice that the dpads in this gamepad is threaded as axes, not buttons.

I also notice that the dpads in this gamepad is threaded as axes, not buttons.

This is common in gamepads, the hardware likely treat them as Hats, the browser convert them to axes.

Windows19490402, (Vendor: 1949 Product: 0402),a:b0,b:b1,y:b4,x:b3,start:b11,back:b10,leftstick:b13,rightstick:b14,leftshoulder:b6,rightshoulder:b7,dpup:+a9,dpleft:+a9,dpdown:+a9,dpright:+a9,leftx:a0,lefty:a1,rightx:a2,righty:a5,lefttrigger:a3,righttrigger:a4,platform:Javascript

Seems like dpad where all mapped to +a9. Can you check which axis correspond to which dpad?

Oh, I just realized, it seems that axis is not conformant to the spec, since it's outside the -1, 1 range.
In that case, as mentioned in the blog post, we can't fix it. The issue should be reported to browsers issue tracker.
If you can, please verify that the axis 9 shows values greater then one here: https://gamepad-tester.com/ and report it to your browser issue tracker.

Seems like dpad where all mapped to +a9. Can you check which axis correspond to which dpad?

All dpads are mapped to AXIS 9 by default, the default value is 3.28571. When I pressed dpad-up the value is -1.00000, dpad-down is 0.14286, dpad-left is 0.71429, dpad-right is -0.42857, as shown below:
https://user-images.githubusercontent.com/1403194/107119312-85296400-6865-11eb-860b-2711a1f86741.mp4
The problem is I can't remap the dpads because whenever I try to remap it, it always reverts back to the default value, 3.28571. Therefore the remap will remember all the dpads at the same value at 3.28571 (this is the value when I do not press any dpad).

Oh, I just realized, it seems that axis is not conformant to the spec, since it's outside the -1, 1 range.
In that case, as mentioned in the blog post, we can't fix it. The issue should be reported to browsers issue tracker.
If you can, please verify that the axis 9 shows values greater then one here: https://gamepad-tester.com/ and report it to your browser issue tracker.

The axis 9 value is always at 3.28571 by default. However, when I pressed any direction, the value does not exceed the -1, 1 range. This behavior is the same on Google Chrome and Firefox.

I also report this bug upstream at Chromium bug #1175440.
However, for Firefox, they don't even let me log in to their bug tracker. My account is disabled and the reason is... I have not logged on in a long time. I tried logging in with both my email and my Github account, but both are disabled from them due to the same reason. Well, good for them 😫


Keep tracking and update to XSeries when they fixed the XSound problem on 1.8.8

relate to https://github.com/CryptoMorin/XSeries/issues/242

Temporary fixed by having our own patch


bad state: Too many elements from ExprBuilder.build / DependencyWalker (2.2.0-edge)

This occurred twice when I opened the flutter_gallery project using Flutter SDK v1.2.1. I had enabled the experimental option to do Gradle analysis, but that shouldn't affect Dart.
Analyzer Feedback from IntelliJ
Version information

IDEA 191.6<IP_ADDRESS>87692
2.2.0-edge.0a7dcf17eb5f2450480527d6ad1e201fb47f1e36
AI-191.6<IP_ADDRESS>87692, JRE 1.8.0_202-release-1483-b01x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14.4, screens 1440x900  Retina

Exception
Dart analysis server, SDK version 2.2.0-edge.0a7dcf17eb5f2450480527d6ad1e201fb47f1e36, server version 1.23.0, error: Analysis failed: /Users/messick/src/flutter/flutter/examples/flutter_gallery/test/demo/material/drawer_demo_test.dart context: exception_20190426_062141_691
Bad state: Too many elements
#0      List.single (dart:core/runtime/libgrowable_array.dart:227:5)
#1      ExprBuilder.build (package:analyzer/src/summary/expr_builder.dart:293:18)
#2      ExprTypeComputer.compute (package:analyzer/src/summary/link.dart:2526:29)
#3      TypeInferenceNode.evaluate (package:analyzer/src/summary/link.dart:5286:36)
#4      TypeInferenceDependencyWalker.evaluate (package:analyzer/src/summary/link.dart:5136:7)
#5      DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2217:13)
#6      DependencyWalker.walk (package:analyzer/src/summary/link.dart:2236:18)
#7      VariableElementForLink.inferredType (package:analyzer/src/summary/link.dart:5562:47)
#8      TopLevelVariableElementForLink.link (package:analyzer/src/summary/link.dart:5121:48)
#9      CompilationUnitElementInBuildUnit.link (package:analyzer/src/summary/link.dart:1640:16)
#10     LibraryElementInBuildUnit.link (package:analyzer/src/summary/link.dart:3810:12)
#11     LibraryCycleNode.link (package:analyzer/src/summary/link.dart:3516:15)
#12     LibraryCycleDependencyWalker.evaluate (package:analyzer/src/summary/link.dart:3456:7)
#13     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2217:13)
#14     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#15     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#16     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#17     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#18     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#19     DependencyWalker.walk (package:analyzer/src/summary/link.dart:2236:18)
#20     LibraryCycleForLink.ensureLinked (package:analyzer/src/summary/link.dart:3489:42)
#21     Linker.link (package:analyzer/src/summary/link.dart:4012:35)
#22     _relink (package:analyzer/src/summary/link.dart:305:57)
#23     link (package:analyzer/src/summary/link.dart:123:3)
#24     LibraryContext.load.<anonymous closure> (package:analyzer/src/dart/analysis/library_context.dart:170:25)
#25     PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:34:15)
#26     LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:169:12)
#27     AnalysisDriver._createLibraryContext (package:analyzer/src/dart/analysis/driver.dart:1624:23)
#28     AnalysisDriver._computeAnalysisResult.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:1426:30)
#29     PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:34:15)
#30     AnalysisDriver._computeAnalysisResult (package:analyzer/src/dart/analysis/driver.dart:1416:20)
#31     AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1236:33)
<asynchronous suspension>
#32     AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2145:24)
<asynchronous suspension>
#33     AnalysisDriverScheduler.start (package:analyzer/src/dart/analysis/driver.dart:2075:5)
#34     new AnalysisServer (package:analysis_server/src/analysis_server.dart:213:29)
#35     SocketServer.createAnalysisServer (package:analysis_server/src/socket_server.dart:86:26)
#36     StdioAnalysisServer.serveStdio (package:analysis_server/src/server/stdio_server.dart:37:18)
#37     Driver.startAnalysisServer.<anonymous closure> (package:analysis_server/src/server/driver.dart:526:21)
#38     _rootRun (dart:async/zone.dart:1124:13)
#39     _CustomZone.run (dart:async/zone.dart:1021:19)
#40     _runZoned (dart:async/zone.dart:1516:10)
#41     runZoned (dart:async/zone.dart:1463:12)
#42     Driver._captureExceptions (package:analysis_server/src/server/driver.dart:605:12)
#43     Driver.startAnalysisServer (package:analysis_server/src/server/driver.dart:524:7)
#44     Driver.start (package:analysis_server/src/server/driver.dart:427:7)
#45     main (file:///b/rr/tmpgY2JrN/w/src/third_party/dart/pkg/analysis_server/bin/server.dart:12:11)
#46     _AsyncAwaitCompleter.start (dart:async/runtime/libasync_patch.dart:49:6)
#47     main (file:///b/rr/tmpgY2JrN/w/src/third_party/dart/pkg/analysis_server/bin/server.dart:10:10)
#48     _startIsolate.<anonymous closure> (dart:isolate/runtime/libisolate_patch.dart:298:32)
#49     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)

For additional log information, please append the contents of
file:///private/var/folders/yg/474plv091g1cqnz98j05v0y4003j5d/T/report1.txt.
Dart analysis server, SDK version 2.2.0-edge.0a7dcf17eb5f2450480527d6ad1e201fb47f1e36, server version 1.23.0, error: Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test/demo/material/drawer_demo_test.dart context: exception_20190426_062141_691
Bad state: Too many elements
#0      List.single (dart:core/runtime/libgrowable_array.dart:227:5)
#1      ExprBuilder.build (package:analyzer/src/summary/expr_builder.dart:293:18)
#2      ExprTypeComputer.compute (package:analyzer/src/summary/link.dart:2526:29)
#3      TypeInferenceNode.evaluate (package:analyzer/src/summary/link.dart:5286:36)
#4      TypeInferenceDependencyWalker.evaluate (package:analyzer/src/summary/link.dart:5136:7)
#5      DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2217:13)
#6      DependencyWalker.walk (package:analyzer/src/summary/link.dart:2236:18)
#7      VariableElementForLink.inferredType (package:analyzer/src/summary/link.dart:5562:47)
#8      TopLevelVariableElementForLink.link (package:analyzer/src/summary/link.dart:5121:48)
#9      CompilationUnitElementInBuildUnit.link (package:analyzer/src/summary/link.dart:1640:16)
#10     LibraryElementInBuildUnit.link (package:analyzer/src/summary/link.dart:3810:12)
#11     LibraryCycleNode.link (package:analyzer/src/summary/link.dart:3516:15)
#12     LibraryCycleDependencyWalker.evaluate (package:analyzer/src/summary/link.dart:3456:7)
#13     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2217:13)
#14     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#15     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#16     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#17     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#18     DependencyWalker.walk.strongConnect (package:analyzer/src/summary/link.dart:2183:24)
#19     DependencyWalker.walk (package:analyzer/src/summary/link.dart:2236:18)
#20     LibraryCycleForLink.ensureLinked (package:analyzer/src/summary/link.dart:3489:42)
#21     Linker.link (package:analyzer/src/summary/link.dart:4012:35)
#22     _relink (package:analyzer/src/summary/link.dart:305:57)
#23     link (package:analyzer/src/summary/link.dart:123:3)
#24     LibraryContext.load.<anonymous closure> (package:analyzer/src/dart/analysis/library_context.dart:170:25)
#25     PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:34:15)
#26     LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:169:12)
#27     AnalysisDriver._createLibraryContext (package:analyzer/src/dart/analysis/driver.dart:1624:23)
#28     AnalysisDriver._computeAnalysisResult.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:1426:30)
#29     PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:34:15)
#30     AnalysisDriver._computeAnalysisResult (package:analyzer/src/dart/analysis/driver.dart:1416:20)
#31     AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1236:33)
<asynchronous suspension>
#32     AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2145:24)
<asynchronous suspension>
#33     AnalysisDriverScheduler.start (package:analyzer/src/dart/analysis/driver.dart:2075:5)
#34     new AnalysisServer (package:analysis_server/src/analysis_server.dart:213:29)
#35     SocketServer.createAnalysisServer (package:analysis_server/src/socket_server.dart:86:26)
#36     StdioAnalysisServer.serveStdio (package:analysis_server/src/server/stdio_server.dart:37:18)
#37     Driver.startAnalysisServer.<anonymous closure> (package:analysis_server/src/server/driver.dart:526:21)
#38     _rootRun (dart:async/zone.dart:1124:13)
#39     _CustomZone.run (dart:async/zone.dart:1021:19)
#40     _runZoned (dart:async/zone.dart:1516:10)
#41     runZoned (dart:async/zone.dart:1463:12)
#42     Driver._captureExceptions (package:analysis_server/src/server/driver.dart:605:12)
#43     Driver.startAnalysisServer (package:analysis_server/src/server/driver.dart:524:7)
#44     Driver.start (package:analysis_server/src/server/driver.dart:427:7)
#45     main (file:///b/rr/tmpgY2JrN/w/src/third_party/dart/pkg/analysis_server/bin/server.dart:12:11)
#46     _AsyncAwaitCompleter.start (dart:async/runtime/libasync_patch.dart:49:6)
#47     main (file:///b/rr/tmpgY2JrN/w/src/third_party/dart/pkg/analysis_server/bin/server.dart:10:10)
#48     _startIsolate.<anonymous closure> (dart:isolate/runtime/libisolate_patch.dart:298:32)
#49     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)

1556284895181 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1321,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/simple_smoke_test.da
1556284895187 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1322,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/live_smoketest.dart"
1556284895194 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1323,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/drawer_test.dart","i
1556284895200 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1324,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/pesto_test.dart","it
1556284895201 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1325,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/smoke_test.dart","it
1556284895207 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1326,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/example_code_parser_
1556284895209 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1327,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/calculator/logic.dar
1556284895216 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1328,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/calculator/smoke_tes
1556284895224 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1329,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/flutter_test_config.
1556284895230 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1330,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/update_test.dart","i
1556284895232 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1331,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/demo/material/drawer
1556284895239 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1332,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/demo/material/text_f
1556284895241 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1333,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/demo/material/chip_d
1556284895246 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1334,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test/demo/material/expans
1556284895248 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1335,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_p
1556284895253 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1336,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_p
1556284895255 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1337,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test_driver/scroll_perf_t
1556284895260 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1338,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_p
1556284895262 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1339,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test_driver/scroll_perf.d
1556284895271 <= {"event":"completion.availableSuggestions","params":{"changedLibraries":[{"id":1340,"uri":"file://...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_p
1556284896637 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_perf_test.dart contex
1556284897366 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test_driver/scroll_perf.dart context: excepti
1556284897801 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_perf_with_semantics.d
1556284898212 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test_driver/scroll_perf_test.dart context: ex
1556284898928 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_perf.dart context: ex
1556284899401 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test_driver/transitions_perf_with_semantics_t
1556284899907 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test/demo/material/expansion_panels_demo_test
1556284900678 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test/demo/material/chip_demo_test.dart contex
1556284901310 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test/demo/material/text_form_field_demo_test.
1556284901787 <= {"event":"server.error","params":{"isFatal":false,"message":"Analysis failed: ...src/flutter/flutter/examples/flutter_gallery/test/demo/material/drawer_demo_test.dart cont

Forgot to mention: my copy of flutter_gallery came from my local Flutter repo, which is sync'd to master (not 1.2.1). Feel free to close this if that kind of incompatibility isn't interesting.

@stereotype441, this looks like it's from a recent build, and we've seen at least two reports of this from users.

Actually the build is from Feb 12 (2.5 months ago).  I suspect this is a bug in summaries that was later fixed.  @stevemessick would you mind rechecking with a more recent build (preferably one of the Dart 2.3 build candidates)?

@stereotype441, this is almost certainly from the last stable flutter release.

I suspect this is a bug in summaries that was later fixed.

We should keep this open until the next flutter stable release, and see if there continue to be reports of this.

This issue was reported a lot during 2.2.0 and 2.2.1, but never since then. Closing this as stale; please re-open if you encounter this on the latest version of Dart (or Flutter).


Update all docstrings to Google style

The docstrings were following various styles, sometimes ReST, sometimes numpydoc, sometimes Google. Sometimes they were a francenstein's monster of these three, which no automatic parser can hope to deal with.
I have updated all existing docstrings to the Google style, which I believe to be the most readable of the options.
It also allows for our documentation to parse Note: ... and Tips: ... as highlighted boxes as described here.
In the process of updating, I've tried to add as many type hints as I could. However in pam/samples/tour.py, there were instances where I failed to work out what an input argument's type was expected to be. @Theodore-Chatziioannou, can you help with annotating add_return_origin, add_tour_activity, add_tour_leg, apply?
I have also updated some base classes to actual python Abstract Base Classes since it made documenting them and their children easier. Based on the tests that were supposed to catch NotImplementedErrors, I would say these classes should have always been ABCs.

rk out what an input argument's type was expected to be. @Theodore-Chatziioannou, can you help with annotating add_return_origin, add_tour_activity, add_tour_leg, apply?

@divyasharma-arup

Codecov Report

Merging #208 (a11bbdc) into main (3b1ea1e) will decrease coverage by 0.15%.
The diff coverage is 92.22%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   86.98%   86.83%   -0.15%
==========================================
  Files          49       49
  Lines        5392     5440      +48
  Branches     1349     1360      +11
==========================================
+ Hits         4690     4724      +34
- Misses        450      459       +9
- Partials      252      257       +5

Impacted Files
Coverage Δ

pam/array/encode.py
82.60% <ø> (ø)

pam/operations/cropping.py
84.82% <ø> (ø)

pam/planner/zones.py
76.92% <ø> (ø)

pam/samplers/time.py
88.23% <ø> (ø)

pam/scoring.py
89.63% <ø> (ø)

pam/write/matsim.py
78.52% <33.33%> (-0.98%)
:arrow_down:

pam/plot/plans.py
78.24% <50.00%> (-0.37%)
:arrow_down:

pam/write/diary.py
82.66% <50.00%> (-2.06%)
:arrow_down:

pam/write/matrices.py
93.87% <50.00%> (-3.95%)
:arrow_down:

pam/planner/clustering.py
85.36% <75.00%> (-2.14%)
:arrow_down:

... and 19 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more