Fresh kubernetes deployment using docker runtime - Unable to start api-server and kubelet

Description
OS: Ubuntu 20.04.6 LTS
Kuberentes:
kubeadm version: &version.Info{Major:"1", Minor:"28", GitVersion:"v1.28.2", GitCommit:"89a4ea3e1e4ddd7f7572286090359983e0387b2f", GitTreeState:"clean", BuildDate:"2023-09-13T09:34:32Z", GoVersion:"go1.20.8", Compiler:"gc", Platform:"linux/amd64"}
-->
Describe the results you received and expected
kubeadm init --pod-network-cidr=<IP_ADDRESS>/8 --apiserver-advertise-address=<IP_ADDRESS> --ignore-preflight-errors=NumCPU,Mem --v=6
I0113 04:33:40.032528    4844 initconfiguration.go:117] detected and using CRI socket: unix:///var/run/containerd/containerd.sock
I0113 04:33:40.032686    4844 kubelet.go:196] the value of KubeletConfiguration.cgroupDriver is empty; setting it to "systemd"
I0113 04:33:40.035595    4844 version.go:187] fetching Kubernetes version from URL: https://dl.k8s.io/release/stable-1.txt
I0113 04:33:42.245729    4844 version.go:256] remote version is much newer: v1.29.0; falling back to: stable-1.28
I0113 04:33:42.245807    4844 version.go:187] fetching Kubernetes version from URL: https://dl.k8s.io/release/stable-1.28.txt
[init] Using Kubernetes version: v1.28.5
[preflight] Running pre-flight checks
I0113 04:33:44.898098    4844 checks.go:563] validating Kubernetes and kubeadm version
I0113 04:33:44.898139    4844 checks.go:168] validating if the firewall is enabled and active
I0113 04:33:44.914418    4844 checks.go:203] validating availability of port 6443
I0113 04:33:44.914979    4844 checks.go:203] validating availability of port 10259
I0113 04:33:44.915330    4844 checks.go:203] validating availability of port 10257
I0113 04:33:44.915669    4844 checks.go:280] validating the existence of file /etc/kubernetes/manifests/kube-apiserver.yaml
I0113 04:33:44.915821    4844 checks.go:280] validating the existence of file /etc/kubernetes/manifests/kube-controller-manager.yaml
I0113 04:33:44.915987    4844 checks.go:280] validating the existence of file /etc/kubernetes/manifests/kube-scheduler.yaml
I0113 04:33:44.916143    4844 checks.go:280] validating the existence of file /etc/kubernetes/manifests/etcd.yaml
I0113 04:33:44.916351    4844 checks.go:430] validating if the connectivity type is via proxy or direct
I0113 04:33:44.916407    4844 checks.go:469] validating http connectivity to first IP address in the CIDR
I0113 04:33:44.916449    4844 checks.go:469] validating http connectivity to first IP address in the CIDR
I0113 04:33:44.916477    4844 checks.go:104] validating the container runtime
I0113 04:33:44.954410    4844 checks.go:639] validating whether swap is enabled or not
I0113 04:33:44.954552    4844 checks.go:370] validating the presence of executable crictl
I0113 04:33:44.954621    4844 checks.go:370] validating the presence of executable conntrack
I0113 04:33:44.954671    4844 checks.go:370] validating the presence of executable ip
I0113 04:33:44.954722    4844 checks.go:370] validating the presence of executable iptables
I0113 04:33:44.954778    4844 checks.go:370] validating the presence of executable mount
I0113 04:33:44.954822    4844 checks.go:370] validating the presence of executable nsenter
I0113 04:33:44.954867    4844 checks.go:370] validating the presence of executable ebtables
I0113 04:33:44.954913    4844 checks.go:370] validating the presence of executable ethtool
I0113 04:33:44.954956    4844 checks.go:370] validating the presence of executable socat
I0113 04:33:44.954999    4844 checks.go:370] validating the presence of executable tc
I0113 04:33:44.955040    4844 checks.go:370] validating the presence of executable touch
I0113 04:33:44.955084    4844 checks.go:516] running all checks
I0113 04:33:44.967646    4844 checks.go:401] checking whether the given node name is valid and reachable using net.LookupHost
I0113 04:33:44.967745    4844 checks.go:605] validating kubelet version
I0113 04:33:45.000022    4844 checks.go:130] validating if the "kubelet" service is enabled and active
I0113 04:33:45.006196    4844 checks.go:203] validating availability of port 10250
I0113 04:33:45.006243    4844 checks.go:329] validating the contents of file /proc/sys/net/bridge/bridge-nf-call-iptables
I0113 04:33:45.006267    4844 checks.go:329] validating the contents of file /proc/sys/net/ipv4/ip_forward
I0113 04:33:45.006277    4844 checks.go:203] validating availability of port 2379
I0113 04:33:45.006289    4844 checks.go:203] validating availability of port 2380
I0113 04:33:45.006302    4844 checks.go:243] validating the existence and emptiness of directory /var/lib/etcd
[preflight] Pulling images required for setting up a Kubernetes cluster
[preflight] This might take a minute or two, depending on the speed of your internet connection
[preflight] You can also perform this action in beforehand using 'kubeadm config images pull'
I0113 04:33:45.006374    4844 checks.go:828] using image pull policy: IfNotPresent
I0113 04:33:45.023755    4844 checks.go:854] pulling: registry.k8s.io/kube-apiserver:v1.28.5
I0113 04:34:53.454374    4844 checks.go:854] pulling: registry.k8s.io/kube-controller-manager:v1.28.5
I0113 04:35:46.053991    4844 checks.go:854] pulling: registry.k8s.io/kube-scheduler:v1.28.5
I0113 04:37:02.823926    4844 checks.go:854] pulling: registry.k8s.io/kube-proxy:v1.28.5
W0113 04:37:24.696705    4844 checks.go:835] detected that the sandbox image "registry.k8s.io/pause:3.6" of the container runtime is inconsistent with that used by kubeadm. It is recommended that using "registry.k8s.io/pause:3.9" as the CRI sandbox image.
I0113 04:37:24.713794    4844 checks.go:854] pulling: registry.k8s.io/pause:3.9
I0113 04:37:30.001247    4844 checks.go:854] pulling: registry.k8s.io/etcd:3.5.9-0
I0113 04:38:51.184189    4844 checks.go:854] pulling: registry.k8s.io/coredns/coredns:v1.10.1
[certs] Using certificateDir folder "/etc/kubernetes/pki"
I0113 04:39:33.027558    4844 certs.go:112] creating a new certificate authority for ca
[certs] Generating "ca" certificate and key
I0113 04:39:33.122552    4844 certs.go:519] validating certificate period for ca certificate
[certs] Generating "apiserver" certificate and key
[certs] apiserver serving cert is signed for DNS names [cvs-k8s-master1.hpemf.com kubernetes kubernetes.default kubernetes.default.svc kubernetes.default.svc.cluster.local] and IPs [<IP_ADDRESS> <IP_ADDRESS>]
[certs] Generating "apiserver-kubelet-client" certificate and key
I0113 04:39:33.314136    4844 certs.go:112] creating a new certificate authority for front-proxy-ca
[certs] Generating "front-proxy-ca" certificate and key
I0113 04:39:33.392288    4844 certs.go:519] validating certificate period for front-proxy-ca certificate
[certs] Generating "front-proxy-client" certificate and key
I0113 04:39:33.699882    4844 certs.go:112] creating a new certificate authority for etcd-ca
[certs] Generating "etcd/ca" certificate and key
I0113 04:39:33.884850    4844 certs.go:519] validating certificate period for etcd/ca certificate
[certs] Generating "etcd/server" certificate and key
[certs] etcd/server serving cert is signed for DNS names [cvs-k8s-master1.hpemf.com localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]
[certs] Generating "etcd/peer" certificate and key
[certs] etcd/peer serving cert is signed for DNS names [cvs-k8s-master1.hpemf.com localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]
[certs] Generating "etcd/healthcheck-client" certificate and key
[certs] Generating "apiserver-etcd-client" certificate and key
I0113 04:39:34.527846    4844 certs.go:78] creating new public/private key files for signing service account users
[certs] Generating "sa" key and public key
[kubeconfig] Using kubeconfig folder "/etc/kubernetes"
I0113 04:39:34.678520    4844 kubeconfig.go:103] creating kubeconfig file for admin.conf
[kubeconfig] Writing "admin.conf" kubeconfig file
I0113 04:39:34.781723    4844 kubeconfig.go:103] creating kubeconfig file for kubelet.conf
[kubeconfig] Writing "kubelet.conf" kubeconfig file
I0113 04:39:34.871489    4844 kubeconfig.go:103] creating kubeconfig file for controller-manager.conf
[kubeconfig] Writing "controller-manager.conf" kubeconfig file
I0113 04:39:34.967682    4844 kubeconfig.go:103] creating kubeconfig file for scheduler.conf
[kubeconfig] Writing "scheduler.conf" kubeconfig file
[etcd] Creating static Pod manifest for local etcd in "/etc/kubernetes/manifests"
I0113 04:39:35.110542    4844 local.go:65] [etcd] wrote Static Pod manifest for a local etcd member to "/etc/kubernetes/manifests/etcd.yaml"
[control-plane] Using manifest folder "/etc/kubernetes/manifests"
[control-plane] Creating static Pod manifest for "kube-apiserver"
I0113 04:39:35.110632    4844 manifests.go:102] [control-plane] getting StaticPodSpecs
I0113 04:39:35.110757    4844 certs.go:519] validating certificate period for CA certificate
I0113 04:39:35.110810    4844 manifests.go:128] [control-plane] adding volume "ca-certs" for component "kube-apiserver"
I0113 04:39:35.110836    4844 manifests.go:128] [control-plane] adding volume "etc-ca-certificates" for component "kube-apiserver"
I0113 04:39:35.110856    4844 manifests.go:128] [control-plane] adding volume "etc-pki" for component "kube-apiserver"
I0113 04:39:35.110876    4844 manifests.go:128] [control-plane] adding volume "k8s-certs" for component "kube-apiserver"
I0113 04:39:35.110898    4844 manifests.go:128] [control-plane] adding volume "usr-local-share-ca-certificates" for component "kube-apiserver"
I0113 04:39:35.110919    4844 manifests.go:128] [control-plane] adding volume "usr-share-ca-certificates" for component "kube-apiserver"
I0113 04:39:35.111328    4844 manifests.go:157] [control-plane] wrote static Pod manifest for component "kube-apiserver" to "/etc/kubernetes/manifests/kube-apiserver.yaml"
[control-plane] Creating static Pod manifest for "kube-controller-manager"
I0113 04:39:35.111378    4844 manifests.go:102] [control-plane] getting StaticPodSpecs
I0113 04:39:35.111487    4844 manifests.go:128] [control-plane] adding volume "ca-certs" for component "kube-controller-manager"
I0113 04:39:35.111512    4844 manifests.go:128] [control-plane] adding volume "etc-ca-certificates" for component "kube-controller-manager"
I0113 04:39:35.111532    4844 manifests.go:128] [control-plane] adding volume "etc-pki" for component "kube-controller-manager"
I0113 04:39:35.111553    4844 manifests.go:128] [control-plane] adding volume "flexvolume-dir" for component "kube-controller-manager"
I0113 04:39:35.111573    4844 manifests.go:128] [control-plane] adding volume "k8s-certs" for component "kube-controller-manager"
I0113 04:39:35.111593    4844 manifests.go:128] [control-plane] adding volume "kubeconfig" for component "kube-controller-manager"
I0113 04:39:35.111613    4844 manifests.go:128] [control-plane] adding volume "usr-local-share-ca-certificates" for component "kube-controller-manager"
I0113 04:39:35.111633    4844 manifests.go:128] [control-plane] adding volume "usr-share-ca-certificates" for component "kube-controller-manager"
I0113 04:39:35.112014    4844 manifests.go:157] [control-plane] wrote static Pod manifest for component "kube-controller-manager" to "/etc/kubernetes/manifests/kube-controller-manager.yaml"
[control-plane] Creating static Pod manifest for "kube-scheduler"
I0113 04:39:35.112064    4844 manifests.go:102] [control-plane] getting StaticPodSpecs
I0113 04:39:35.112162    4844 manifests.go:128] [control-plane] adding volume "kubeconfig" for component "kube-scheduler"
I0113 04:39:35.113257    4844 manifests.go:157] [control-plane] wrote static Pod manifest for component "kube-scheduler" to "/etc/kubernetes/manifests/kube-scheduler.yaml"
I0113 04:39:35.113276    4844 kubelet.go:67] Stopping the kubelet
[kubelet-start] Writing kubelet environment file with flags to file "/var/lib/kubelet/kubeadm-flags.env"
[kubelet-start] Writing kubelet configuration to file "/var/lib/kubelet/config.yaml"
[kubelet-start] Starting the kubelet
I0113 04:39:35.435924    4844 waitcontrolplane.go:83] [wait-control-plane] Waiting for the API server to be healthy
I0113 04:39:35.436329    4844 loader.go:395] Config loaded from file:  /etc/kubernetes/admin.conf
[wait-control-plane] Waiting for the kubelet to boot up the control plane as static Pods from directory "/etc/kubernetes/manifests". This can take up to 4m0s
I0113 04:39:45.445701    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10008 milliseconds
I0113 04:39:55.947643    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:40:06.447590    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
[kubelet-check] Initial timeout of 40s passed.
I0113 04:40:16.947274    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:40:27.449973    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:40:37.948672    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10001 milliseconds
I0113 04:40:48.454894    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:40:58.947357    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:41:09.447811    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10001 milliseconds
I0113 04:41:19.948021    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:41:24.015319    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 3569 milliseconds
I0113 04:41:34.448399    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:41:44.947303    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10001 milliseconds
I0113 04:41:55.047823    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10100 milliseconds
I0113 04:42:05.048792    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:42:15.447846    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:42:25.953775    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10006 milliseconds
I0113 04:42:35.958271    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10004 milliseconds
I0113 04:42:45.044447    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 8592 milliseconds
I0113 04:42:55.454360    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10007 milliseconds
I0113 04:43:05.947112    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:43:06.466243    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 518 milliseconds
I0113 04:43:16.966248    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:43:27.446466    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:43:27.978857    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 532 milliseconds
I0113 04:43:38.447348    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10000 milliseconds
I0113 04:43:48.948740    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10002 milliseconds
I0113 04:43:58.957933    4844 round_trippers.go:553] GET https://<IP_ADDRESS>:6443/healthz?timeout=10s  in 10008 milliseconds
Unfortunately, an error has occurred:
timed out waiting for the condition
This error is likely caused by:
- The kubelet is not running
- The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled)
If you are on a systemd-powered system, you can try to troubleshoot the error with the following commands:
- 'systemctl status kubelet'
- 'journalctl -xeu kubelet'
Additionally, a control plane component may have crashed or exited when started by the container runtime.
To troubleshoot, list all containers using your preferred container runtimes CLI.
Here is one example how you may list all running Kubernetes containers by using crictl:
- 'crictl --runtime-endpoint unix:///var/run/containerd/containerd.sock ps -a | grep kube | grep -v pause'
Once you have found the failing container, you can inspect its logs with:
- 'crictl --runtime-endpoint unix:///var/run/containerd/containerd.sock logs CONTAINERID'
couldn't initialize a Kubernetes cluster
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/init.runWaitControlPlanePhase
cmd/kubeadm/app/cmd/phases/init/waitcontrolplane.go:108
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run.func1
cmd/kubeadm/app/cmd/phases/workflow/runner.go:259
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).visitAll
cmd/kubeadm/app/cmd/phases/workflow/runner.go:446
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run
cmd/kubeadm/app/cmd/phases/workflow/runner.go:232
k8s.io/kubernetes/cmd/kubeadm/app/cmd.newCmdInit.func1
cmd/kubeadm/app/cmd/init.go:111
github.com/spf13/cobra.(*Command).execute
vendor/github.com/spf13/cobra/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
vendor/github.com/spf13/cobra/command.go:1068
github.com/spf13/cobra.(*Command).Execute
vendor/github.com/spf13/cobra/command.go:992
k8s.io/kubernetes/cmd/kubeadm/app.Run
cmd/kubeadm/app/kubeadm.go:50
main.main
cmd/kubeadm/kubeadm.go:25
runtime.main
/usr/local/go/src/runtime/proc.go:250
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1598
error execution phase wait-control-plane
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run.func1
cmd/kubeadm/app/cmd/phases/workflow/runner.go:260
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).visitAll
cmd/kubeadm/app/cmd/phases/workflow/runner.go:446
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run
cmd/kubeadm/app/cmd/phases/workflow/runner.go:232
k8s.io/kubernetes/cmd/kubeadm/app/cmd.newCmdInit.func1
cmd/kubeadm/app/cmd/init.go:111
github.com/spf13/cobra.(*Command).execute
vendor/github.com/spf13/cobra/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
vendor/github.com/spf13/cobra/command.go:1068
github.com/spf13/cobra.(*Command).Execute
vendor/github.com/spf13/cobra/command.go:992
k8s.io/kubernetes/cmd/kubeadm/app.Run
cmd/kubeadm/app/kubeadm.go:50
main.main
cmd/kubeadm/kubeadm.go:25
runtime.main
/usr/local/go/src/runtime/proc.go:250
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1598
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $ crictl --runtime-endpoint unix:///var/run/containerd/containerd.sock ps -a | grep kube | grep -v pause
f09fd6b7be496       9ecc4287300e3       About a minute ago   Exited              kube-apiserver            4                   7766ed4728e56       kube-apiserver-cvs-k8s-master1.hpemf.com
54895a4902925       babc03668f18a       4 minutes ago        Running             kube-scheduler            0                   22bfa846906f3       kube-scheduler-cvs-k8s-master1.hpemf.com
d61e404e4c8ee       c527ad14e0cd5       4 minutes ago        Running             kube-controller-manager   0                   b4c9d707087be       kube-controller-manager-cvs-k8s-master1.hpemf.com
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $ crictl logs f09fd6b7be496
WARN[0000] runtime connect using default endpoints: [unix:///var/run/dockershim.sock unix:///run/containerd/containerd.sock unix:///run/crio/crio.sock unix:///var/run/cri-dockerd.sock]. As the defaul  t settings are now deprecated, you should set the endpoint instead.
E0113 04:44:30.250083    6325 remote_runtime.go:415] "ContainerStatus from runtime service failed" err="rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial unix /var/run/dockershim.sock: connect: no such file or directory"" containerID="f09fd6b7be496"
FATA[0000] rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial unix /var/run/dockershim.sock: connect: no such file or directory"
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $ crictl logs f09fd6b7be496 -p
WARN[0000] runtime connect using default endpoints: [unix:///var/run/dockershim.sock unix:///run/containerd/containerd.sock unix:///run/crio/crio.sock unix:///var/run/cri-dockerd.sock]. As the defaul t settings are now deprecated, you should set the endpoint instead.
E0113 04:44:48.366198    6381 remote_runtime.go:415] "ContainerStatus from runtime service failed" err="rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing  dial unix /var/run/dockershim.sock: connect: no such file or directory"" containerID="f09fd6b7be496"
FATA[0000] rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial unix /var/run/dockershim.sock: connect: no such file or directory"
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $ crictl --runtime-endpoint unix:///var/run/containerd/containerd.sock logs CONTAINERID
E0113 04:45:21.658814    6504 remote_runtime.go:415] "ContainerStatus from runtime service failed" err="rpc error: code = NotFound desc = an error occurred when try to find container "CONTAINERID": ot found" containerID="CONTAINERID"
FATA[0000] rpc error: code = NotFound desc = an error occurred when try to find container "CONTAINERID": not found
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $ journalctl -xeu kubelet
Jan 13 04:45:58 cvs-k8s-master1.hpemf.com kubelet[5121]: W0113 04:45:58.806025    5121 reflector.go:535] vendor/k8s.io/client-go/informers/factory.go:150: failed to list *v1.Service: Get "https://<IP_ADDRESS>:6443/api/v1/services?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: i/o timeout
Jan 13 04:45:58 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:45:58.806618    5121 trace.go:236] Trace[1316285868]: "Reflector ListAndWatch" name:vendor/k8s.io/client-go/informers/factory.go:150 (13-Jan-2024 04:45:28.805) (total time: 30001ms):
Jan 13 04:45:58 cvs-k8s-master1.hpemf.com kubelet[5121]: Trace[1316285868]: ---"Objects listed" error:Get "https://<IP_ADDRESS>:6443/api/v1/services?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: i/o timeout 30000ms (04:45:58.806)
Jan 13 04:45:58 cvs-k8s-master1.hpemf.com kubelet[5121]: Trace[1316285868]: [30.001489569s] [30.001489569s] END
Jan 13 04:45:58 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:45:58.807015    5121 reflector.go:147] vendor/k8s.io/client-go/informers/factory.go:150: Failed to watch *v1.Service: failed to list *v1.Service: Get "https://<IP_ADDRESS>:6443/api/v1/services?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: i/o timeout
Jan 13 04:45:59 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:45:59.568418    5121 controller.go:146] "Failed to ensure lease exists, will retry" err="Get "https://<IP_ADDRESS>:6443/apis/coordination.k8s.io/v1/namespaces/kube-node-lease/leases/cvs-k8s-master1.hpemf.com?timeout=10s\": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)" interval="7s"
Jan 13 04:46:06 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:06.426353    5121 eviction_manager.go:258] "Eviction manager: failed to get summary stats" err="failed to get node info: node "cvs-k8s-master1.hpemf.com" not found"
Jan 13 04:46:08 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:08.015055    5121 event.go:289] Unable to write event: '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"cvs-k8s-master1.hpemf.com.17a9ce4fc6aa2e27", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:, DeletionGracePeriodSecond>
Jan 13 04:46:08 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:08.018895    5121 scope.go:117] "RemoveContainer" containerID="b901677470f98e7867473dd75677c055110a4fab8f523fd027fbb64fed5e70ee"
Jan 13 04:46:08 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:08.019047    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:08 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:08.019821    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "kube-apiserver" with CrashLoopBackOff: "back-off 2m40s restarting failed container=kube-apiserver pod=kube-apiserver-cvs-k8s-master1.hpemf.com_kube-system(5a9281867058526c845d9c79d7ac566b)"" pod="kube-system/kube-apiserver-cvs-k8s-master1.hpemf.com" podUID="5a9281867058526c845d9c79d7ac566b"
Jan 13 04:46:10 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:10.018782    5121 scope.go:117] "RemoveContainer" containerID="8918b8916435863ba9c157f34992778454f92114e3456623b09d598006eba375"
Jan 13 04:46:10 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:10.018938    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:10 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:10.019463    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "etcd" with CrashLoopBackOff: "back-off 5m0s restarting failed container=etcd pod=etcd-cvs-k8s-master1.hpemf.com_kube-system(c4c04f0bb3e857970e9d48c8f41ae279)"" pod="kube-system/etcd-cvs-k8s-master1.hpemf.com" podUID="c4c04f0bb3e857970e9d48c8f41ae279"
Jan 13 04:46:13 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:13.794748    5121 kubelet_node_status.go:92] "Unable to register node with API server" err="Post "https://<IP_ADDRESS>:6443/api/v1/nodes\": dial tcp <IP_ADDRESS>:6443: connect: no route to host" node="cvs-k8s-master1.hpemf.com"
Jan 13 04:46:13 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:13.794757    5121 controller.go:146] "Failed to ensure lease exists, will retry" err="Get "https://<IP_ADDRESS>:6443/apis/coordination.k8s.io/v1/namespaces/kube-node-lease/leases/cvs-k8s-master1.hpemf.com?timeout=10s\": dial tcp <IP_ADDRESS>:6443: connect: no route to host" interval="7s"
Jan 13 04:46:13 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:13.794920    5121 certificate_manager.go:562] kubernetes.io/kube-apiserver-client-kubelet: Failed while requesting a signed certificate from the control plane: cannot create certificate signing request: Post "https://<IP_ADDRESS>:6443/apis/certificates.k8s.io/v1/certificatesigningrequests": dial tcp <IP_ADDRESS>:6443: connect: no route to host
Jan 13 04:46:13 cvs-k8s-master1.hpemf.com kubelet[5121]: W0113 04:46:13.796329    5121 reflector.go:535] vendor/k8s.io/client-go/informers/factory.go:150: failed to list *v1.RuntimeClass: Get "https://<IP_ADDRESS>:6443/apis/node.k8s.io/v1/runtimeclasses?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: connect: no route to host
Jan 13 04:46:13 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:13.796492    5121 reflector.go:147] vendor/k8s.io/client-go/informers/factory.go:150: Failed to watch *v1.RuntimeClass: failed to list *v1.RuntimeClass: Get "https://<IP_ADDRESS>:6443/apis/node.k8s.io/v1/runtimeclasses?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: connect: no route to host
Jan 13 04:46:16 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:16.426807    5121 eviction_manager.go:258] "Eviction manager: failed to get summary stats" err="failed to get node info: node "cvs-k8s-master1.hpemf.com" not found"
Jan 13 04:46:19 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:19.021144    5121 scope.go:117] "RemoveContainer" containerID="b901677470f98e7867473dd75677c055110a4fab8f523fd027fbb64fed5e70ee"
Jan 13 04:46:19 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:19.022454    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:19 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:19.024282    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "kube-apiserver" with CrashLoopBackOff: "back-off 2m40s restarting failed container=kube-apiserver pod=kube-apiserver-cvs-k8s-master1.hpemf.com_kube-system(5a9281867058526c845d9c79d7ac566b)"" pod="kube-system/kube-apiserver-cvs-k8s-master1.hpemf.com" podUID="5a9281867058526c845d9c79d7ac566b"
Jan 13 04:46:20 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:20.802260    5121 kubelet_node_status.go:70] "Attempting to register node" node="cvs-k8s-master1.hpemf.com"
Jan 13 04:46:23 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:23.019339    5121 scope.go:117] "RemoveContainer" containerID="8918b8916435863ba9c157f34992778454f92114e3456623b09d598006eba375"
Jan 13 04:46:23 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:23.019554    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:23 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:23.020038    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "etcd" with CrashLoopBackOff: "back-off 5m0s restarting failed container=etcd pod=etcd-cvs-k8s-master1.hpemf.com_kube-system(c4c04f0bb3e857970e9d48c8f41ae279)"" pod="kube-system/etcd-cvs-k8s-master1.hpemf.com" podUID="c4c04f0bb3e857970e9d48c8f41ae279"
Jan 13 04:46:26 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:26.427263    5121 eviction_manager.go:258] "Eviction manager: failed to get summary stats" err="failed to get node info: node "cvs-k8s-master1.hpemf.com" not found"
Jan 13 04:46:30 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:30.800939    5121 controller.go:146] "Failed to ensure lease exists, will retry" err="Get "https://<IP_ADDRESS>:6443/apis/coordination.k8s.io/v1/namespaces/kube-node-lease/leases/cvs-k8s-master1.hpemf.com?timeout=10s\": dial tcp <IP_ADDRESS>:6443: i/o timeout" interval="7s"
Jan 13 04:46:31 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:31.019007    5121 scope.go:117] "RemoveContainer" containerID="b901677470f98e7867473dd75677c055110a4fab8f523fd027fbb64fed5e70ee"
Jan 13 04:46:31 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:31.019153    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:31 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:31.019949    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "kube-apiserver" with CrashLoopBackOff: "back-off 2m40s restarting failed container=kube-apiserver pod=kube-apiserver-cvs-k8s-master1.hpemf.com_kube-system(5a9281867058526c845d9c79d7ac566b)"" pod="kube-system/kube-apiserver-cvs-k8s-master1.hpemf.com" podUID="5a9281867058526c845d9c79d7ac566b"
Jan 13 04:46:31 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:31.021470    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:36 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:36.429360    5121 eviction_manager.go:258] "Eviction manager: failed to get summary stats" err="failed to get node info: node "cvs-k8s-master1.hpemf.com" not found"
Jan 13 04:46:37 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:37.019963    5121 scope.go:117] "RemoveContainer" containerID="8918b8916435863ba9c157f34992778454f92114e3456623b09d598006eba375"
Jan 13 04:46:37 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:37.020194    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:37 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:37.022300    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "etcd" with CrashLoopBackOff: "back-off 5m0s restarting failed container=etcd pod=etcd-cvs-k8s-master1.hpemf.com_kube-system(c4c04f0bb3e857970e9d48c8f41ae279)"" pod="kube-system/etcd-cvs-k8s-master1.hpemf.com" podUID="c4c04f0bb3e857970e9d48c8f41ae279"
Jan 13 04:46:39 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:39.019158    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:45 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:45.019159    5121 scope.go:117] "RemoveContainer" containerID="b901677470f98e7867473dd75677c055110a4fab8f523fd027fbb64fed5e70ee"
Jan 13 04:46:45 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:45.019289    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:45 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:45.021634    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "kube-apiserver" with CrashLoopBackOff: "back-off 2m40s restarting failed container=kube-apiserver pod=kube-apiserver-cvs-k8s-master1.hpemf.com_kube-system(5a9281867058526c845d9c79d7ac566b)"" pod="kube-system/kube-apiserver-cvs-k8s-master1.hpemf.com" podUID="5a9281867058526c845d9c79d7ac566b"
Jan 13 04:46:46 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:46.430534    5121 eviction_manager.go:258] "Eviction manager: failed to get summary stats" err="failed to get node info: node "cvs-k8s-master1.hpemf.com" not found"
Jan 13 04:46:47 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:47.803608    5121 controller.go:146] "Failed to ensure lease exists, will retry" err="Get "https://<IP_ADDRESS>:6443/apis/coordination.k8s.io/v1/namespaces/kube-node-lease/leases/cvs-k8s-master1.hpemf.com?timeout=10s\": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)" interval="7s"
Jan 13 04:46:48 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:48.017029    5121 event.go:289] Unable to write event: '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"cvs-k8s-master1.hpemf.com.17a9ce4fc6aa2e27", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:, DeletionGracePeriodSecond>
Jan 13 04:46:48 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:48.017228    5121 event.go:228] Unable to write event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"cvs-k8s-master1.hpemf.com.17a9ce4fc6aa2e27", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:, DeletionGracePeriodSeconds>
Jan 13 04:46:48 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:48.019835    5121 scope.go:117] "RemoveContainer" containerID="8918b8916435863ba9c157f34992778454f92114e3456623b09d598006eba375"
Jan 13 04:46:48 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:48.020044    5121 dns.go:153] "Nameserver limits exceeded" err="Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"
Jan 13 04:46:48 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:48.020590    5121 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to "StartContainer" for "etcd" with CrashLoopBackOff: "back-off 5m0s restarting failed container=etcd pod=etcd-cvs-k8s-master1.hpemf.com_kube-system(c4c04f0bb3e857970e9d48c8f41ae279)"" pod="kube-system/etcd-cvs-k8s-master1.hpemf.com" podUID="c4c04f0bb3e857970e9d48c8f41ae279"
Jan 13 04:46:50 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:50.803379    5121 kubelet_node_status.go:92] "Unable to register node with API server" err="Post "https://<IP_ADDRESS>:6443/api/v1/nodes\": dial tcp <IP_ADDRESS>:6443: i/o timeout" node="cvs-k8s-master1.hpemf.com"
Jan 13 04:46:55 cvs-k8s-master1.hpemf.com kubelet[5121]: W0113 04:46:55.047513    5121 reflector.go:535] vendor/k8s.io/client-go/informers/factory.go:150: failed to list *v1.CSIDriver: Get "https://<IP_ADDRESS>:6443/apis/storage.k8s.io/v1/csidrivers?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: i/o timeout
Jan 13 04:46:55 cvs-k8s-master1.hpemf.com kubelet[5121]: I0113 04:46:55.047672    5121 trace.go:236] Trace[581891402]: "Reflector ListAndWatch" name:vendor/k8s.io/client-go/informers/factory.go:150 (13-Jan-2024 04:46:25.046) (total time: 30000ms):
Jan 13 04:46:55 cvs-k8s-master1.hpemf.com kubelet[5121]: Trace[581891402]: ---"Objects listed" error:Get "https://<IP_ADDRESS>:6443/apis/storage.k8s.io/v1/csidrivers?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: i/o timeout 30000ms (04:46:55.047)
Jan 13 04:46:55 cvs-k8s-master1.hpemf.com kubelet[5121]: Trace[581891402]: [30.000786886s] [30.000786886s] END
Jan 13 04:46:55 cvs-k8s-master1.hpemf.com kubelet[5121]: E0113 04:46:55.047699    5121 reflector.go:147] vendor/k8s.io/client-go/informers/factory.go:150: Failed to watch *v1.CSIDriver: failed to list *v1.CSIDriver: Get "https://<IP_ADDRESS>:6443/apis/storage.k8s.io/v1/csidrivers?limit=500&resourceVersion=0": dial tcp <IP_ADDRESS>:6443: i/o timeout
lines 2844-2897/2897 (END)
Has anyone face such problem
What version of containerd are you using?
containerd --version containerd containerd.io 1.6.26 3dd1e886e55dd695541fdcd67420c2888645a495
Any other relevant information
cvs-k8s-master1 $ crictl info
WARN[0000] runtime connect using default endpoints: [unix:///var/run/dockershim.sock unix:///run/containerd/containerd.sock unix:///run/crio/crio.sock unix:///var/run/cri-dockerd.sock]. As the default settings are now deprecated, you should set the endpoint instead.
E0113 05:19:17.843289    7784 remote_runtime.go:616] "Status from runtime service failed" err="rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial unix /var/run/dockershim.sock: connect: no such file or directory""
FATA[0000] getting status of runtime: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial unix /var/run/dockershim.sock: connect: no such file or directory"
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $
cvs-k8s-master1 $ uname -a
Linux cvs-k8s-master1.hpemf.com 5.4.0-113-generic #127-Ubuntu SMP Wed May 18 14:30:56 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
cvs-k8s-master1 $
Show configuration if it is related to CRI plugin.
mv /etc/containerd/config.toml /etc/containerd/config.toml_old
sudo systemctl restart containerd
sudo systemctl status containerd
cvs-k8s-master1 $ cat /etc/containerd/config.toml_old
Copyright 2018-2022 Docker Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
disabled_plugins = ["cri"]
#root = "/var/lib/containerd"
#state = "/run/containerd"
#subreaper = true
#oom_score = 0
#[grpc]
address = "/run/containerd/containerd.sock"
uid = 0
gid = 0
#[debug]
address = "/run/containerd/debug.sock"
uid = 0
gid = 0
level = "info"

@h-182  I think you need to report it to https://github.com/Mirantis/cri-dockerd or kubernetes, and not containerd.

I came across this statement:
https://kubernetes.io/blog/2022/11/18/upcoming-changes-in-kubernetes-1-26/#cri-api-removal
Kubernetes v1.26 will not support CRI v1alpha2. That removal will result in the kubelet not registering the node if the container runtime doesn't support CRI v1. This means that containerd minor version 1.5 and older will not be supported in Kubernetes 1.26; if you use containerd, you will need to upgrade to containerd version 1.6.0 or later before you upgrade that node to Kubernetes v1.26. Other container runtimes that only support the v1alpha2 are equally affected: if that affects you, you should contact the container runtime vendor for advice or check their website for additional instructions in how to move forward.


clustering transcripts without segmentation

Dear all,
Is it possible to get the output of 'clustering molecules' step without proceeding to the segmentation and creating polygons?
Thank you,
Araks

Dear Araks,
It's possible if you run Baysor from Jupyter Notebooks in Julia. My bad, I haven't documented that option at all, as there were no request for that. But if you need it, I can draft a minimalistic notebook. Otherwise, you can set number of iterations to 1, so the segmentation would go stop very early.

Yes, that's the one!


fix missing argument to VanDerCorput constructor

This compilation error wasn't caught by Travis CI, so I suspect a silent exclusion of the planner_ompl module.

This change is

Correction. planner_ompl is being built, but only with GCC. clang-3.8 caught this error.

Coverage remained the same at 86.288% when pulling d05d6e32205eb76a7c8b25fac9361890933de5cd on fix_vdc_constructor into 9fdaf509afdf3a8cb3743c9baf8a5e8a6cc7fb22 on master.


Capstone project v1.0

CAPSTONE PROJECT: an imaginary concert in my country Bolivia was chose
DESCRIPTION: the CREATIVE COMMONS GLOBAL SUBMIT page was replicated according to the requirements.
The main characteristics of the page were maintained as possible and the images and text content was changed according to the  theme chosen.
The main and the about page were built for desktop and mobile sizes and linked each other.
The branch is published in GITHUB: https://hanszizold.github.io/Capstone-project_Concert/
A video describing the website: https://www.loom.com/share/bdb3bf21581e4d6f8d07f8a13692c736
May 19th: First observations corrected!

Underline in headers shortened.
Button for buying tickets adjusted in mobile and desktop version.
Chess background image included in artist pictures.
Hamburger button not showing in the about section remediated.
Title text centered in the about section.
Image problem in partner section corrected.
Readme file corrected.
A new video recorded pointing special parts of the code.
https://www.loom.com/share/7298eddfbc3f4a1bbe666226e61843c1

May 19th: Second observation corrected!

Give credits to Cindy Shin in Behance and added a Get Started section in readme file.

Hello @Lucas-Masaba, @danmainah, @gemmen29,
Thank you all for your review and comments. You made me improve.

No problem. Enjoy the rest of your day.


Error parsing Character: TypeError: Cannot read property 'label' of undefined

I'm getting this error when trying to import a character.
Here is the link to the ddb character: https://www.dndbeyond.com/profile/MastonHammerfell/characters/42930604
I've successfully imported several other characters (including this one previously). I also verified I can still import other characters, so it seems to be something to do with this particular one.
All modules, systems up to date. DDB Importer version: 0.2.31
Attaching a screenshot of the error.
Any suggestions?

You haven't finished selecting your proficiencies and the character importer is crashing out. I will try and improve the error handling around this.

You haven't finished selecting your proficiencies and the character importer is crashing out. I will try and improve the error handling around this.

Hi MrPrimate. Just a note to let you know that selecting the proficiencies fixed the problem and to say thank you for the quick reply.

Hi MrPrimate. Just a note to let you know that selecting the proficiencies fixed the problem and to say thank you for the quick reply.


Tag in page.liquid

Hey,
first of all awesome template thank you very much.
There is a wrong Html-Tag in page.liquid.

...
 or
...

https://github.com/kondasoft/ks-bootshop/blob/master/templates/page.liquid

Thanks for your kind words.
I fixed the closing tag for future releases, but it is not sth to worry about.


possible wrong MJD entry

Hi, thanks for the work of providing this amazing database.
I encounter a problem when I try to get a forced photometry light curve of a source at the coordinate of 3.84012, -38.90534
It appears that there is a double entry at 59748.241863MJD with the same camera and same filter.
The fits headers of the two images show that they are most likely two exposures at different time, but they have identical MJD-OBS entries.
Could you investigate what the cause of this problem is? I hope this won't affect the value of other MJD entries.
BTW, this double entry won't appear if you only query just +-1 of that day. It will only appear with a longer duration criterion.

Hi! Many thanks for bringing this to our attention. Digging into the data implies that there are problems with duplicate MJDs at ATLAS-CHL (04a) on the night of 59748.  Going deeper, I spotted some duplicates at ATLAS-HKO (02a) on 59998 and at ATLAS-STH (03a) on night 59844. I've raised this with our colleagues.

Thank you for looking into this problem.
I found 19 more sources facing the same issue that my team downloaded.
I would like to know to what extent this damage is. Are these MJD entries wrong for time only but they are still correct for the date? Or is it possible that this problem could affect their date record as well?

As far as I can see, ONLY the 3 MJDs and telescopes are affected as stated above. Your 19 other sources almost certainly have duplicates on the same MJDs. If you see something different, let us know, and send us the Job IDs, so we can confirm the problem if necessary. Data is not "damaged". We are reviewing possible fixes, but no promises yet.

I see. I have a bit closer look into the downloaded data.
I find that all sources having duplicated timestamp have the record of 59748.241863MJD and they have coordinates ranged in 357deg < RA < 29deg. Their observed IDs are 04a59748o0619o, 04a59748o0620o, 04a59748o0624o, 04a59748o0629o, 04a59748o0630o, 04a59748o0631o, 04a59748o0660o, 04a59748o0665o, 04a59748o0666o, 04a59748o0667o, 04a59748o0668o, 04a59748o0669o, 04a59748o0676o, 04a59748o0677o, 04a59748o0705o, 04a59748o0706o, 04a59748o0707o, 04a59748o0708o, 04a59748o0711o, 04a59748o0712o.
I also examine the data we downloaded for 03a59843, 03a59844, 03a59845, 02a59998, and 02a59999, but find no duplications for a same source. Could you specify a bit more detail on what kind of data I should avoid for these two days?

After a review of this at our weekly ATLAS call, it looks like a lot of the data from these nights has been corrupted by a shutter problem. This results in the shutter open/close time and hence the MJD-OBS going awol. We looked at the data and would recommend avoiding use of these data with duplciated MJD are not used scientifically.

The MJD stamps probably won't get fixed anytime soon, since it appears the images are not worth fixing. They appear trailed, very poor zero point,  or otherwise corrupted due to the shutter issue. In effect the duplciate MJD is a flag not to use.

Thank you for providing this information. I am happy to simply discard them.
Could you provide a more detail list of corrupted observations? I notice the observation ID is sometimes +-1 day from the MJD record. Therefore, I am not certain which observations are affected due to this problem.

Any time you find an exact repeated MJD, it will mean the shutter open/closure time commnunication will have been corrupted so we would advise rejecting all of those exposures. You should be careful of all exposures on that MJD. I would reject them all, and if they are crucial, then get the image stamps and check the pixels manually.


welcome...TeasyElementList

Closing this pull as I accidentally added it to next one https://github.com/WileyLabs/teasy/pull/100


refactor(router) use tablepool to improve router

Summary
Inspired by #9036, I introduced tablepool in atc router.
I think it may be some help for performance.
Full changelog

use tablepool to reduce small table object usage

Instead of using a pool, we could just reuse the same table all the time.

Yes, it is true, but we still need to clear items in the reused table. tablepool did these for us.

I agree with @Suika-Kong , seems some long-lived tables is cleaner, we can just do table.clear instead of release_table, how do you think @chronolaw ?

I agree with @Suika-Kong , seems some long-lived tables is cleaner, we can just do table.clear instead of release_table, how do you think @chronolaw ?

OK, I will reimplement this feature.


feat: add container to render image as background behind children

Description
This PR adds a new component which enables an image to be rendered as a background behind children components.
This PR has existed for a while in react-imgix, and is being ported over to this library.
New Feature

[x] If this is a big feature with breaking changes, consider [opening an issue][issues] to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.
[x] Run unit tests to ensure all existing tests are still passing
[x] Add new passing unit tests to cover the code introduced by your PR
[ ] Update the readme
[x] Add some steps so we can test your cool new feature!
[x] The PR title is in the conventional commit format: e.g. feat(<area>): added new way to do this cool thing #issue-number
[x] Add your info to the contributors array in package.json!

Steps to Test
Review new tests.

NB: This should incorporate the changes brought in by #72 before being merged @sherwinski @jayeb

@jayeb
All changes from #72 should now be integrated with @frederickfogerty's development here. I also went through and cleaned up the commit history a bit.


[Bug]: Vesta can't open

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name
vesta
Expected/Current Behaviour
the app can't open after installed.
Steps to Reproduce
scoop install vesta
WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
WARN  To disable this warning, run 'scoop config aria2-warning-enabled false'.
Installing 'vesta' (3.5.8) [64bit] from Darkatse_Scoop-Darkatse bucket
Loading VESTA-win64.zip from cache.
Checking hash of VESTA-win64.zip ... ok.
Extracting VESTA-win64.zip ... done.
Running pre_install script...
Linking ~\scoop\apps\vesta\current => ~\scoop\apps\vesta\3.5.8
Creating shortcut for VESTA (VESTA.exe)
Persisting VESTA.ini
'vesta' (3.5.8) was installed successfully!

Just click VESTA.exe installed, and no window shows up.

Possible Solution
No idea so far.
Scoop and Buckets Version
'extras' bucket:
9c78385da (HEAD -> master, origin/master, origin/HEAD) hibit-uninstaller: Update to version 3.0.10

Scoop Config
last_update                       scoop_branch scoop_repo
-----------                       ------------ ----------
2022-12-03T22:19:37.9574469+00:00 master       https://github.com/lukesampson/scoop

PowerShell Version
Name                           Value
----                           -----
PSVersion                      5.1.19041.1682
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1682
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Additional Softwares
No response

emmm, I can open it and it works fine.

reopen this issue if problem still.


How to expose more Mocha properties on Karma's result object?

I initially opened an issue on karma (karma-runner/karma#1553), but after doing a bit more research think it's more appropriate here. I want to expose Mocha's test properties inside of Karma's test results. From my understanding of Karma, the adapter seems to be the place to do such a thing.
I've noticed that the test object in the runner.on callback is the Mocha test object. I can edit the adapter to add other properties such as Mocha's fn property (demonstrated in the snippet below)
runner.on('test end', function (test) {
  var skipped = test.pending === true

  var result = {
    id: '',
    description: test.title,
    suite: [],
    success: test.state === 'passed',
    skipped: skipped,
    time: skipped ? 0 : test.duration,
    log: test.$errors || [],
    code: test.fn.toString() // If I add this line here, `code` will be available to a reporter
  }

  var pointer = test.parent
  while (!pointer.root) {
    result.suite.unshift(pointer.title)
    pointer = pointer.parent
  }

  tc.result(result)
})

However, if I try to pass along the test object to Karma (demonstrated below), Karma just hangs.
runner.on('test end', function (test) {
  tc.result(test)
})

Does karma expect a specific format for it's result object (my intuition says that is the exact reason for such an adapter)? If so, what properties does it look for? Is there any way to just forward on the entire Mocha test to a Karma reporter?
Any advice would be greatly appreciated

Sorry for the late reply. In general yes the format of the result must have the properties described at the bottom of https://github.com/karma-runner/karma/blob/master/docs/dev/05-plugins.md#karma-framework-api But it should not be a problem to pass more to Karma, just that it won't be used for now.

Thanks @Dignifiedquire!


Having some unexpected results with the test code

Greetings,
I am trying to load my checkpoint in the test code to get the results and submit on the benchmark but I encountered some problems, I would be grateful for your help.

I found that the test code saves in two folders called "submission" and "visualizations" and I followed the code and found that you don't save a flow file in the "submission" folder for each sample of the input sequences, does this mean that evaluation in the benchmark doesn't use all of the GT flow of the test sequences?

I was trying to run the test code on my GPU but I got an error in. I debugged the error and found that using the GPU will use the following line from test.py in the _test function
batch = self.move_batch_to_cuda(batch)
After this line, the variables in the batch changes from int to float, which resulted in having the following values for the first sample in the function "visualize_events" in visualization.py when using the cpu:

The t_start_us is:<PHONE_NUMBER>6
The t_end_us os:<PHONE_NUMBER>6
and in case I used the GPU, those values became:
The t_start_us is:<PHONE_NUMBER>0.0
The t_end_us os:<PHONE_NUMBER>0.0
which results in an error at the last sample of the first sequence in the function "visualize_flow_colours" in visualization.py.
I am using the latest version of the test code, but I added only the following line in the main.py due to having some error:
os.environ["GIT_PYTHON_REFRESH"] = "quiet"
Do you have an idea about what might be the problem? is it necessary to use the CPU?

Is it better any way in having the batch number greater than 1 while running the test code?

I am getting bad results when I load my checkpoint, the flow images in the submission folder are like the one below:

I am not sure about what the problem might be, given that the validation and training epe graphs are very good. I save the whole model in my checkpoint in the train code (with extension .pth) and then load it back in the test code. Do you have any advice regarding this?
Thanks in advance for your help

Hi @LuckyShrek
Have you tried following the instructions to verify that you can replicate the results with the checkpoint that we provide?
This helps me to understand if the issue is checkpoint related.

closing due to inactivity


Using custom textures

I was attempting to load a texture from my application into an imgui window using something similar to the following code:
ui.window(im_str!("PPU"))
    .size((150.0, 130.0), ImGuiSetCond_FirstUseEver)
    .resizable(true)
    .build(|| {
        unsafe {
            imgui_sys::igImage(ppu.get_tex_id(), ImVec2::new(160.0, 144.0), ImVec2::new(0.0, 0.0), ImVec2::new(1.0, 1.0), ImVec4::new(0.0, 0.0, 0.0, 1.0), ImVec4::new(1.0, 0.0, 0.0, 1.0));
        }
    });

But it seems custom textures are disallowed by the imgui-rs glium renderer: https://github.com/Gekkio/imgui-rs/blob/master/imgui-glium-renderer/src/lib.rs#L108
I'm wondering what needs to be done for this to get supported?

Yeah, this is something that isn't yet supported because designing it properly seems fairly difficult. The assert is there just to notify that the renderer doesn't know what to do with unknown texture IDs.
In your example, the renderer would have to somehow get the full texture object with the ID much later once rendering starts (with proper lifetime checks and all). Also, the main library can't depend on any renderer-specific concepts, types, or code, and the design should work well with both the glium and gfx renderers (+ any potential future ones, like GDI).
It's definitely not impossible to do, but requires some work.


logLevel issue

Hello,
I updated my HB setup with the last version of your plugin (1.9.4). I'm currently facing this issue:
[7/6/2021, 12:11:51 PM] TypeError: Cannot read property 'logLevel' of undefined
    at new HomebridgeMagichomeDynamicPlatform (/usr/lib/node_modules/homebridge-magichome-dynamic-platform/src/platform.ts:59:37)
    at /usr/lib/node_modules/homebridge/src/server.ts:440:40
    at Array.forEach (<anonymous>)
    at Server.loadPlatforms (/usr/lib/node_modules/homebridge/src/server.ts:372:27)
    at Server.start (/usr/lib/node_modules/homebridge/src/server.ts:159:29)

Thanks.

Hi there.

Please login to your homebridge UI
cl￼ick plugins
under "Homebridge magichome Dynamic Platform">click settings
scroll all the way to the bottom of the list > wave hello at the new logging option that is causing your issue> click save
restart Homebridge.

Let me know how that goes.

Had the same problem and saving the settings again fixed it. Thanks @Zacknetic !

Had the same problem and saving the settings again fixed it. Thanks @Zacknetic !

Awesome! Happy to help.

Everything up and running ! Thanks for that.


Fix catch/finally executing twice with a return in try/catch and throw in finally

Purpose
This PR modifies the error table entry generation with try/catch/finally statements, to fix the issue of the relevant catch/finally blocks being executed more than once if the try or catch blocks contain a return statement and an error is thrown in the finally block.
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/4517

@SupunS added with 7c834b1.

:white_check_mark: Build ballerina-lang 311 completed (commit https://github.com/ballerina-platform/ballerina-lang/commit/a41587190f by @MaryamZi)

:white_check_mark: Build ballerina-lang 312 completed (commit https://github.com/ballerina-platform/ballerina-lang/commit/6770c3173a by @MaryamZi)

@hasithaa fixed with 30f601c and 09298cf


Changing deployment config

Increasing memory limit for the deployment.
Decreasing web page refresh frequency.

/lgtm

/approve no-issue

/approve no-issue

OK - sorry. Now I know - my login there is bad. Will fix.

/approve


Typeahead always shows only 5 suggestions maximum

Hello,
Typeahead always shows only 5 suggestions maximum. How to change sufficient count.

check this page on the typeahead docs:
Datasets

limit – The max number of suggestions to be displayed. Defaults to 5.

Just adding data-limit="10" to input properties works for me


Robot name - V2

Great work refactoring the code with Paul and Dan's feedback! You're already demonstrating a strong command of the language.

@drosholt Great work on this refactoring. You are good to go!


Spelling Error Fix

reeeee

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


WIP Wire up EMR

You should cherry-pick this commit to fix 2 bugs in process.py: https://github.com/lewfish/raster-foundry/commit/1d727d9526d97b7f4734619088eed0f2192fcb96

All comments should have been addressed. Let me know if I overlooked anything.
The only remaining thing we need to make this fully operational is to fix the S3 bucket permissions issue.

Rebased onto develop and fixed lint.

Some issues have fallen out of this PR, but I think that the handoff process works. +1 to merging this so that we can move forward with resolving the issues.


MFEM crashes in debug mode with "bad" Pmesh NURBS meshes

Sometimes Pmesh creates NURBS meshes with incorrectly ordered nodes, particularly on the boundary.  In opt mode, MFEM corrects any incorrectly ordered boundary elements obtained from Pmesh in order to recover positive Jacobians, issues a warning message, and continues on.  However, in debug mode, MFEM errors out, halting execution.  This is ultimately a Pmesh problem that they should fix, but it would be nice if MFEM could simply issue a warning, correct the ordering as in opt mode, and continue on; otherwise, the error/abort prevents one from debugging problems that use Pmesh NURBS meshes.

It seems to be these two MFEM_ASSERT statements that cause the exit in debug mode:  https://github.com/mfem/mfem/blob/master/mesh/mesh.cpp#L2704-L2705

I don't think MFEM corrects the ordering -- the link you posted above (inside Mesh::Finalize) returns immediately after the MFEM_ASSERTs, so in opt mode no action is taken (the statements inside the MFEM_ASSERTs are not executed in opt mode) and the code is just using the "inverted" mesh. Maybe using this "inverted" mesh does not cause problems but I'm not really sure.
Maybe we can detect and correct these situations earlier -- inside Mesh::ReadNURBSMesh or even inside the constructor NURBSExtension(std::istream &input). Do you have a simple mesh that I can use to reproduce this issue?

@aaronskinner is it safe to close this old issue?


Add a way to catch up embedded item source data to the current DataModel

Item.migratedData removes data and adds system but does not update the database so the item has both after the migration but I believe that shouldn't be a problem.

Doesn't the server do this for world stuff?

This is for spells embedded in consumable items.


runtime: respect SA_RESETHAND when forwarding to non-Go signal handler

What version of Go are you using (go version)?

go version go1.10.4 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jim/go"
GORACE=""
GOROOT="/usr/lib/go-1.10"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.10/pkg/tool/linux_amd64"
GCCGO="/usr/bin/gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build690985833=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Compile a library using -buildmode=c-shared

Trap SIGSEGV in a C program with a handler which will reraise SIGSEGV

Load the library against the C program using dlopen

Cause the C program to SEGSIGV by dereference a NULL pointer

src file: infinitesignalloop.gz
to compile: uncompress src file to GOPATH and run make
to reproduce: just run  ./trap_signal before

What did you expect to see?
The program should crash finally with the default system segfault handler be called.
trap SIGSEGV before dlopen ./libdummycgo.so
Received Segmentation fault ...
Segmentation fault (core dumped)

What did you see instead?
A infinite sighandling loop has happen.
trap SIGSEGV before dlopen ./libdummycgo.so
Received Segmentation fault ...
Received Segmentation fault ...
... // infinite loop
Received Segmentation fault ...
Killed

Following the code with gdb, it seems that Go signal handler raises SIGSEGV again to invoke the C handler, then C handler reraise SIGSEGV, which is catched by Go signal handler again, and then repeat and repeat.
As doc https://golang.org/pkg/os/signal/#hdr-Go_programs_that_use_cgo_or_SWIG said in section Go programs that use cgo or SWIG (not in section Non-Go programs that call Go code)

If the Go signal handler is invoked on a non-Go thread not running Go code, the handler generally forwards the signal to the non-Go code, as follows. If the signal is SIGPROF, the Go handler does nothing. Otherwise, the Go handler removes itself, unblocks the signal, and raises it again, to invoke any non-Go handler or default system handler. If the program does not exit, the Go handler then reinstalls itself and continues execution of the program.

And if we trap SIGSEGV after load the library (just run ./trap_signal after), there C program will just crash with system default handler called as expected.
Some more tests shows above issue exist for all synchronize signals (SIGBUS, SIGFPE, and SIGSEGV).
When not use dlopen to load the library, instead to link the library against to a C program as following,

Compile a library using -buildmode=c-shared

Trap SIGSEGV in a C program with a handler which will reraise SIGSEGV

Link the library against the C program

Cause the C program to SEGSIGV by dereference a NULL pointer
and then run the C program, it will crash with default segfault handler called.

/cc @ianlancetaylor
The link to the documentation didn't work for me, so here is an update link for whomever investigates this: https://golang.org/pkg/os/signal/#hdr-Go_programs_that_use_cgo_or_SWIG

I don't see what we can do here.  The Go signal handler has to do something.  It sounds like what it does here doesn't work with your C program, but it still seems like the best chance of working with a typical program.  Why does your C signal handler re-raise SIGSEGV?

Why does your C signal handler re-raise SIGSEGV?
At some case, I want the C signal handler to just dump stack trace when segfault, then re-raise the signal to system default handler.

But presumably when you re-raise the signal you first remove the C signal handler, which ought to mean that you get the default handler and crash the program.  How does the Go signal handler come back?

But presumably when you re-raise the signal you first remove the C signal handler, which ought to mean that you get the default handler and crash the program.

That's exactly I want to do with specifying sigaction.sa_flags with SA_RESETHAND.
sa_flags specifies a set of flags which modify the behavior of the signal.  It is formed by
the bitwise OR of zero or more of the following:

SA_RESETHAND
    Restore the signal action to the default upon entry to the signal handler.

How does the Go signal handler come back?

Following the startup code (_rt0_amd64_lib), I believe the synchronous signals handler is changed to the Go signal handler cgoSigtramp, and the previous C signal handler is stored at fwdSig.
As above, the Go signal handler is the current signal handler, it will tramp the synchronous signal and if the signal occurred not in Go code,  it will forward the signal to the system or the C handler, in this case is the C handler. Then C handler it this case has re-raised the same signal. When Go signal handler tramped the signal, this process will repeate again.
The sigfwdgo has not checked the established sa_flags of the C handler, as a result SA_RESETHAND is ignored.
I believe if sigfwdgo can find a way to check the sa_flags of the C handler, if sa_flags & SA_RESETHNAD is true, reset fwdSig[signo] to _SIG_IGN, then the next time when the same synchronized signal get tramped, the C signal handler will not get forward. But I haven't see where the sa_flags is recorded.
func sigfwdgo(sig uint32, info *siginfo, ctx unsafe.Pointer) bool {
	if sig >= uint32(len(sigtable)) {
		return false
	}
	fwdFn := atomic.Loaduintptr(&fwdSig[sig])
	flags := sigtable[sig].flags

	// If there is no handler to forward to, no need to forward.
	if fwdFn == _SIG_DFL {
		return false
	}

	c := &sigctxt{info, ctx}
	// Only forward synchronous signals and SIGPIPE.
	// Unfortunately, user generated SIGPIPEs will also be forwarded, because si_code
	// is set to _SI_USER even for a SIGPIPE raised from a write to a closed socket
	// or pipe.
	if (c.sigcode() == _SI_USER || flags&_SigPanic == 0) && sig != _SIGPIPE {
		return false
	}
	// Determine if the signal occurred inside Go code. We test that:
	//   (1) we were in a goroutine (i.e., m.curg != nil), and
	//   (2) we weren't in CGO.
	g := getg()
	if g != nil && g.m != nil && g.m.curg != nil && !g.m.incgo {
		return false
	}

	// Signal not handled by Go, forward it.
	// forward to system or the C handler
	if fwdFn != _SIG_IGN {
		sigfwd(fwdFn, sig, info, ctx)
	}

	return true
}

Thanks, that seems reasonable.

I don't think this is limited to just SA_RESETHAND. In general, when forwarding a signal the handler should:

Fix up the signal mask to match the sa_mask of the next handler.
If SA_RESETHAND is set in the sa_flags of the next handler, update the signal-forwarding state to avoid forwarding any future signals.
If SA_NOCLDSTOP is set in the sa_flags of the next handler and the signal is SIGCHLD, filter out "stop" and "continue" events.
Clean up any allocated or locked state. (The next handler in the chain may or may not return.)
Finally, call the handler, including the siginfo_t and context parameters if SA_SIGINFO is set in its sa_flags.

I don't think the Go runtime is currently doing any of those three preliminary steps.


feat: Adding '--skip-answered' flag to enhance user interaction during copier update

This Pull Request addresses a usability issue troubling users when they run 'copier update'. Previously, each time 'copier update' was run, the user had to review all responses given in the answers file. This was a repetitive and laborious process, particularly for users dealing with extensive templates.
This PR introduces a new flag- --skip-answered to improve the user experience and reduce friction during updates. The new flag allows users to bypass the review of questions already answered in the past. It automatically pulls responses from the answers file and presents only the newly added template questions to the user for their review.
skip-answered will skip all answered questions and ask user input only for new inputs if they are present.
Issue: #1178

The code looks perfect to me. Just a minor non-blocking comment. Thanks for this contribution!
It seems you still have a little style issue... if you can run pre-commit it'll fix it for you.

I've fixed your suggested changes.
But when I try to run pre-commit, I receive:
An error has occurred: InvalidConfigError:
=====> .pre-commit-config.yaml is not a file

Any ideas?

You will have to run poe lint (as you did), and commit and push the changes.
Next release will still take some weeks. I don't want to release while on holidays. 🏖

You will have to run poe lint (as you did), and commit and push the changes.
Next release will still take some weeks. I don't want to release while on holidays. 🏖

Yeah, I see. Pushed new changes.

@yajo Hey man!
It seems that everything is fine.
Where will you be able to merge it?
Do you need anything from me at this point?

Since this is a new feature, I'd want to hand-test it before merge, so this will take a bit more than usual due to holidays. Maybe 1 or 2 weeks. But for now you can relax. According to the code, it seems perfect, so I'll just merge when I can give it a try. Otherwise I'll post what to change. Thanks!


Not specifying ContextKnown parameter breaks the task planning process

Describe the bug
When calling for a plan without specifying the "ContextKnown" parameter, the task planner throws an undocumented error
To Reproduce
Call the getPlan endpoint with the following parameters

{
  "TaskId": "c2a99272-8e84-4ae6-8c3d-1951d0985cdf",
  "RobotId": "e906c237-0dd2-453d-b795-59bc8a6d483d",
  "LockResourceReUse": true,
  "ReplanActionPlannerLocked": true
}

Expected behavior
There are a few things.

The default values of the parameters (the default bool value of the ContextKnown parameter is false) should not break the execution of the program
The error like this should have a distinct message, not the default message of NotImplementedException
The user should be informed that the incorrect parameters have been provided or if the parameter is unused it should not be visible

Fixed with @adrianLIrobotics during the pull request review #48


Can't use Alexa Routines NOR Siri Scenes to turn off my lights

Everything works fine (scenes in the plugin disabled or enabled), Both Alexa and Siri Homekit can reach and change stats on the lights Individually, even with Alexa Routines and Siri Scenes (Ex. "Alexa, let's watch TV", "Alexa we're home").
The problem is when a Siri scene or Alexa Routine includes the "turn off" funcion, the lights simply won't turn off (Ex. "Alexa, We're leaving", "Alexa good Night")

I have this plugin installed on my homebridge docker version
homebridge-wiz-lan v3.2.0 (2021-11-15)


Focus lost in Chrome when releasing Node using GrabDragInteraction

@KatieWoe recently reported this. It is for things using GrabDragInteraction of scenery-phet, but my initial instinct is that this is related to scenery events or DOM element changes because it is platform specific.
When releasing something using GrabDragInteraction with enter/spacebar/esc, focus is "lost" in Chrome. I say "lost" in quotes because the behavior is a bit more strange than that. document.activeElement is the body, but pressing tab again will return focus to the Node that was previously focused. Also, @zepumph noticed that after this happens, the next 'enter' is a no-op:
tab,
enter (grabbed),
enter (released and unfocused),
tab,
enter (noop),
enter (grabbed finally)
This does not happen for the published versions of sims using GrabDragInteraction.

When I remove focusable: null, from options.grabbableOptions the bug goes away. I don't fully understand yet or know why this is platform specific.

AccessibilityUtil.overrideFocusWithTabIndex( this.primarySibling, focusable ); is causing focus to be lost. I can seee document.activeElement points to the node before calling and points to the body after calling.

This was caused by
commit 5f1b676688b66921021a93bf2d277f3b65014a65
Author: Jesse<EMAIL_ADDRESS>Date:   Tue Feb 12 18:07:55 2019 -0500

Where focusable was changed to always be a boolean for AccessiblePeer. In that case, tabIndex was set to either 0 or -1. Now when focusable is null the tabIndex atribute is removed from the element with element.removeAttribute, and this must be causing the blur in Chrome.

To clarify, for
     *
     * @param {HTMLElement} element
     * @param {boolean} focusable
     */
    overrideFocusWithTabIndex: function( element, focusable ) {
      var defaultFocusable = AccessibilityUtil.tagIsDefaultFocusable( element.tagName );

      // only add a tabindex when we are overriding the default focusable bahvior of the browser for the tag name
      if ( defaultFocusable !== focusable ) {
        element.tabIndex = focusable ? 0 : -1;
      }
      else {
        element.removeAttribute( 'tabindex' );
      }

      element.setAttribute( DATA_FOCUSABLE, focusable );
    },

focusable was null and not equal to false (though JSDoc indicates it should a be boolean) and so tabIndex was set rather  than the attribute removed.

Reproduced here: https://jsfiddle.net/t0z4xrnL/3/ in Chrome, and also saw that focus isn't lost in Firefox.
The following order of operations is happening in Chrome:

Starting with a div with tabindex="0"
In sim code, we set focusable: null. Since div is not focusable by default, tabindex is removed with removeAttribute.
Chrome immediately removes focus from the div.
For the case of GrabDragInteraction, we continue to mutate the Node and turn it into a button.
Since Chrome removed focus when we removed tabindex, Scenery doesn't know to restore focus to the button after this operation.

Honestly, these steps seem very reasonable, and I wonder if we should force in these steps in the other browsers and fix this with an explicit focus call in GrabDragInteraction.

Another way to rephrase the above is to consider what would be expected if we replaced mutate in GrabDragInteraction with setter calls.
Say we had myNode with tagName = div and focusable = true, and it currently has focus. Then we changed it with
myNode.mutate( {
  tagName: 'button',
  focusable: null
} );

That may be equivalent to
myNode.focusable = null;
myNode.tagName = 'button';

In which case we would expect focus to be lost. I think I am convincing myself that this is the correct behavior, @zepumph do you have any thoughts?
Here is my proposal:

Remove focusable: null from GrabDragInteraction, it should generally always be focusable: true
After overrideWithTabIndex usage in AccessiblePeer blur the primary sibling if the element had focus and is no longer focusable.

Though I think this is "correct" behavior it is tricky, how do we prevent ourselves from hitting this in the future?

What you explained above makes sense to me. Thanks for such thorough investigation.

Thanks @zepumph, https://github.com/phetsims/scenery/issues/967#issuecomment-486405250 done with the above commit.


Haiyue chen terrain builder

I left a comment on your Req15Flower.cpp file but other than that your changes look good! Updating the test bench to include your current functions before creating more might be a good idea moving forward.


Misleading statement about supported Azure regions for speech

Regarding "Choose the region where the resource will be used. Currently, the Speech Services is available in East Asia, North Europe, and West US regions".
This statement seems to be old. This link lists many more Azure regions:
https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/regions#voice-first-virtual-assistants

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ab20294-c13e-b533-726f-9fde3005431d
Version Independent ID: 0e47f11d-7656-8a6f-6e9a-ac0184ed4d15
Content: Try Speech Services for free - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/get-started.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @erhopf
Microsoft Alias: erhopf

@dargilco Thank you for your feedback, we will investigate it and get back to you soon.

#please-close
Fixed in: https://github.com/MicrosoftDocs/azure-docs-pr/pull/82208


CUDA docs: Add RNG example with 3D grid and strided loops

Based on the question asked at https://numba.discourse.group/t/random-number-generation-on-the-gpu/309, I think the answer makes a good example for the documentation, so this PR adds an example using the RNG with a 3D grid and strided loops.

Edits pushed, but the RTD build seems to have failed due to llvmlite version requirements.

Thanks - should this be RTM now?

Would like to get https://github.com/numba/numba/pull/6516 in and do a rebuild, in part because this is the first PR with a doc change since RTD was enabled and I'd like to verify it's working as expected. But yes, this is RTM.

Would like to get #6516 in and do a rebuild, in part because this is the first PR with a doc change since RTD was enabled and I'd like to verify it's working as expected. But yes, this is RTM.

Understood - many thanks!

Buildfarm ID: numba_smoketest_cuda_140.

Buildfarm ID: numba_smoketest_cuda_140.

Passed.


Set right-to-left direction using CSS

This is a Feature Request

What would you like to be added
Override theme CSS to ensure that right-to-left content is rendered correctly.
(Also, check that this is necessary - it might already be handled in Docsy itself).
Why is this needed
We need to indicate that some localizations use right-to-left writing direction, rather than the now more common left-to-right orientation.
Comments
Example implementation:
body > div { direction: ltr; }
body:lang(ar) > div { direction: rtl; }
body:lang(fa) > div { direction: rtl; }

/area web-development

Upstream theme feature request: https://github.com/google/docsy/issues/253

Also see https://github.com/kubernetes/website/issues/22730#issuecomment-663884475

/remove-lifecycle stale

/reopen


Preprocess and convert C1 controls to their 7 bit equivalent

Description of the new feature/enhancement
This is from a discussion in #6328:

@j4james: I was actually wondering whether this was something we could handle as a sort of preprocessing step that converts all of the C1 controls into their two character 7-bit equivalent. That way we can drop all the extra code that's checking for 90 and 9B introducers, and 9C terminators, because those conditions would now be handled as regular 7-bit escapes.

Surely the other way around is better?  Technically, per ECMA-48, it's those actual C1 characters that delimit command strings and control strings, and that begin control sequences.  ESC Fe sequences are just ways to represent them for 7-bit transports.  It has been almost 4 decades since the world went largely 8-bit clean.

Surely the other way around is better?

Semantically does it make any difference? The only reason I was suggesting converting from the C1 controls to the 7-bit escapes was because I thought that would be easier to handle the way our parser is setup.

It has been almost 4 decades since the world went largely 8-bit clean.

That may be so, but in practice most people are using UTF-8 nowdays, so those C1 controls don't really gain you anything and are very rarely supported (at least in my experience).

If I'm not mistaken, converting ESC Fe to C1 characters would require looking ahead one character beyond ESC. That would also be troublesome. I'd prefer the other way around which is techinically the same.

You're looking to the next character anyway, otherwise you simply aren't doing escape sequences right.  And of course converting to the C1 characters means that scanning for (say) ST at the end of a command string or control string is just a single character test.

Well that’s not wrong but we are somewhat stuck with the current implementation that’s prioritizing 7bit instead of 8bit. And you can check out my PR #7340 if you’re interested.


docker: Detect default "desktop-linux" builder

New Docker desktop may have a default builder with name "desktop-linux" that is not buildx capable. Detect that name as well as the old "default" for the need to create a new buildx builder.

Saw this locally like so after a recent Docker Desktop update:
% docker buildx ls
NAME/NODE       DRIVER/ENDPOINT             STATUS  BUILDKIT                              PLATFORMS
default         docker
  default       default                     running v0.11.7-0.20230525183624-798ad6b0ce9f linux/arm64, linux/amd64, linux/amd64/v2, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/mips64le, linux/mips64, linux/arm/v7, linux/arm/v6
desktop-linux * docker
  desktop-linux desktop-linux               running v0.11.7-0.20230525183624-798ad6b0ce9f linux/arm64, linux/amd64, linux/amd64/v2, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/mips64le, linux/mips64, linux/arm/v7, linux/arm/v6
% make
Using Docker Buildx builder "desktop-linux" with build flags "--push --platform=linux/arm64,linux/amd64".
DOCKER_BUILDKIT=1 docker buildx build --push --platform=linux/arm64,linux/amd64 ...
[+] Building 0.0s (0/0)
ERROR: multiple platforms feature is currently not supported for docker driver. Please switch to a different driver (eg. "docker buildx create --use")
make: *** [...] Error 1

/test

/test-1.25-4.19

/test-1.26-net-next

/test-1.26-net-next


Keeps crashing on sketch 54.1

It takes a while on files with a small-medium amount of symbols, but crashes on files with large amounts of symbols

I got the same problem.
I‘m working with a large amount symbols, after choose organize, it would be no respond and crash.
sketch version: 54.1

Same on my side. I have to kill Sketch as the process never ends and gets Sketch to use a lot of CPU.

Yep sometime in a large sketch file with over 500 symbols nested the plugin crashes.(sketch 54.1). If i try to disable new sketch runner toolbar it works, but i dont know if the sketch crash are related.

@moniquep, @cnekol, @Mco-Design, @krdesign could one of you share the crash log?

In your Applications folder, open Utilities > Console.app
Expand ~/Library/Logs in the left window, and select com.bohemiancoding.sketch3 (if you use an app like CleanMyMac, this log folder might be missing and you will need to either re-create it, or use Console's search - process:sketch library:sketch)
If there is Plugin Output.log file in the right window, select it and select Clear in the action menu
Run the plugin in Sketch, and if there was an error it will appear in the right window, in a file called Plugin Output.log
Copy/paste the output here

Also experienced this issue and resolved by disabling Runner. Runner's recent update has been causing issues with lots of plugins.

@moniquep, @cnekol, @Mco-Design, @krdesign could one of you share the crash log?

In your Applications folder, open Utilities > Console.app
Expand ~/Library/Logs in the left window, and select com.bohemiancoding.sketch3 (if you use an app like CleanMyMac, this log folder might be missing and you will need to either re-create it, or use Console's search - process:sketch library:sketch)
If there is Plugin Output.log file in the right window, select it and select Clear in the action menu
Run the plugin in Sketch, and if there was an error it will appear in the right window, in a file called Plugin Output.log
Copy/paste the output here

I did as you suggested, but there is no output log. When I run your plugin, I get the spinning wheel and then have to force quit.
I had the same problem even with all of my plugins disabled.

Having the same issue and disabling the new Runner Pro works.

If i disabling only new runner pro toolbar it works.

Could not read image data at /Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Looper.sketchplugin/Contents/Resources/https:/github.com/sureskumar/Looper/raw/master/assets/logo.png
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Checkpoints.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Slinky.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Paddy.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/CameraExporter.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Sketch%20Styles%20Generator.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/AnimaToolkitPlugin.sketchplugin/Contents/Sketch/manifest.json
Could not read image data at /Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Single-Border.sketchplugin/Contents/Resources/https:/github.com/sureskumar/single-border/raw/master/assets/logo.png
Could not read image data at /Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Panels.sketchplugin/Contents/Resources/craft.svg
Unable to parse manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/sketch-map-generator-2.0.3/Map%20Generator.sketchplugin/Contents/Sketch/manifest.json error: Error Domain=NSCocoaErrorDomain Code=3840 "No value." UserInfo={NSDebugDescription=No value.}
Could not read image data at /Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Looper.sketchplugin/Contents/Resources/https:/github.com/sureskumar/Looper/raw/master/assets/logo.png
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Checkpoints.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Slinky.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Paddy.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/CameraExporter.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/__MACOSX/Sketch%20Styles%20Generator.sketchplugin/Contents/Sketch/manifest.json
Missing plugin manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/AnimaToolkitPlugin.sketchplugin/Contents/Sketch/manifest.json
Could not read image data at /Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Single-Border.sketchplugin/Contents/Resources/https:/github.com/sureskumar/single-border/raw/master/assets/logo.png
Could not read image data at /Users/stefanofois/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Panels.sketchplugin/Contents/Resources/craft.svg
Unable to parse manifest.json at URL: file:///Users/stefanofois/Library/Application%20Support/com.bohemiancoding.sketch3/Plugins/sketch-map-generator-2.0.3/Map%20Generator.sketchplugin/Contents/Sketch/manifest.json error: Error Domain=NSCocoaErrorDomain Code=3840 "No value." UserInfo={NSDebugDescription=No value.}

Hey all, I have been in contact with the team behind Sketch Runner, and it's a known issue affecting Symbol Organizer, and will hopefully be resolved very soon. Apologies, and thanks for your patience.

Hey folks, I'm looking into this for Runner. Sorry for the trouble 🙏 Will drop a beta build in here when we've made some progress.

Here's a beta build of Runner that should fix this issue. You'll need to completely quit and restart Sketch after installing the beta. https://rnnr.xyz/b10521
I've tested this build with Symbol Organizer for over 5000 symbols on a Page. If you're still seeing issues please let me know which versions of macOS and Sketch you're running so I can try to reproduce it here.
Thanks for reporting the issue and for helping us test it 👍

Here's a beta build of Runner that should fix this issue. You'll need to completely quit and restart Sketch after installing the beta. https://rnnr.xyz/b10521
I've tested this build with Symbol Organizer for over 5000 symbols on a Page. If you're still seeing issues please let me know which versions of macOS and Sketch you're running so I can try to reproduce it here.
Thanks for reporting the issue and for helping us test it 👍

I reinstalled the plugin like described and everything works as expected 🙃 Thank you so much!
FYI:

Sketch 54.1 (76490)
Mac: 10.14.4


SCAN command is not getting used in deleteByPattern

#534 issue is not fixed.
The code is still not fixed. I am using elasticache servers and redisson version 3.4.3
if (!commandExecutor.getConnectionManager().isClusterMode()) {
return commandExecutor.evalWriteAsync((String)null, null, RedisCommands.EVAL_LONG, "local keys = redis.call('keys', ARGV[1]) "
+ "local n = 0 "
+ "for i=1, #keys,5000 do "
+ "n = n + redis.call('del', unpack(keys, i, math.min(i+4999, table.getn(keys)))) "
+ "end "
+ "return n;",Collections.emptyList(), pattern);
}

Done


SqlSetup: MSFT_SqlSetup.psm1 enable Robocopy to use paths containing spaces

Enabling Robocopy to use paths containing spaces (https://github.com/PowerShell/SqlServerDsc/issues/779)

Pull Request (PR) description
SqlSetup: MSFT_SqlSetup.psm1 enable Robocopy to use paths containing spaces

This Pull Request (PR) fixes the following issues
Fixes #779

Task list

[ ] Added an entry under the Unreleased section in the CHANGELOG.md? Entry
should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md?
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help?
[ ] Comment-based help added/updated?
[ ] Localization strings added/updated in all localization files as appropriate?
[ ] Examples appropriately added/updated?
[ ] Unit tests added/updated?
See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible)?
See DSC Resource Testing Guidelines.
[x ] New/changed code adheres to
DSC Resource Style Guidelines
and Best Practices?

This change is

Codecov Report

Merging #1131 into dev will decrease coverage by 12%.
The diff coverage is 0%.

@@          Coverage Diff          @@
##            dev   #1131    +/-   ##
=====================================
- Coverage    97%     85%   -13%
=====================================
  Files        33      33
  Lines      4003    4005     +2
=====================================
- Hits       3914    3425   -489
- Misses       89     580   +491

Thanks for fixing this!

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

a discussion (no related file):
Please look at the failing tests (see other review comment as well); https://ci.appveyor.com/project/PowerShell/sqlserverdsc/build/9.0.318.0?fullLog=true#L692

a discussion (no related file):
Could you please add an descriptive entry, for each change/issue, to the Unreleased section of the change log in the file README.md? If an entry resolves an issue please reference the issue where applicable. You may suffix (it's optional) each entry with your name. Example of the format for the entry.
* Descriptive entry ([issue #123](https://github.com/PowerShell/xPSDesiredStateConfiguration/issues/123). [Name/Alias (@github_account)](https://github.com/github_account)

DSCResources/MSFT_SqlSetup/MSFT_SqlSetup.psm1, line 1929 at r1 (raw file):

        [System.String]
        $DestinationPath
    }

I think this was mistakenly changed to a } instead of a ).

DSCResources/MSFT_SqlSetup/MSFT_SqlSetup.psm1, line 1930 at r1 (raw file):

        $DestinationPath
    }
    $quotedPath = '"{0}"' -f $Path

Please add a unit test that test this function using spaces in the paths so we can test this change; See other unit tests for this helper function https://github.com/PowerShell/SqlServerDsc/blob/dev/Tests/Unit/MSFT_SqlSetup.Tests.ps1#L4522

Comments from Reviewable

When you have resolved the review comments, or if you need to discuss a comment. Could you please go into Reviewable and write 'Done' (or click the done-button) on each of the review comments. This allows me to acknowledge (resolve) the review comments and I know that you are done with each change. After you written 'Done' on each review comment,  or comment on the review comment if it needs further discussion, then click the big green 'Publish' button on top of the page. That will send all your comments back as one big comment to this PR.
You find Reviewable if you click on the big purple Reviewable-button in the PR description.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: prkelly sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

thanks for the feedback johlju; have fixed the failing tests and updated Changelog etc. just submitted unit tests for this change (am not able to access Reviewable for some reason - returns message "no connection to firebase - 1 pending write (1stalled) - waiting on permission checks")

@prkelly Try Reviewable again in a bit - GitHub had trouble yesterday and I got that too then.

Reviewed 1 of 2 files at r2, 2 of 2 files at r3.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


Updated contributions grammar for easy reading.

Hey, I updated your README.md! Hope it works for you.

Thanks :-)


fix: update rseqc docker

Changes
Uses an updated docker container for RSEQC which has the tools properly added to $PATH.
Issues

resolves #119
related to #120 & https://github.com/CCBR/Dockers/pull/31

PR Checklist
(~Strikethrough~ any points that are not applicable.)

[x] This comment contains a description of changes with justifications, with any relevant issues linked.
~[ ] Update docs if there are any API changes.~
[x] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kopardev this is ready for you to review