VS build environment is not set when using clang

So what is the trick to get VSCode to call vcvars?
My preset:
{
    "name": "win-ninja-release",
    "displayName": "win-ninja-release",
    "description": "Ninja generator release",
    "generator": "Ninja",
    "binaryDir": "${sourceDir}/build/ninja/release",
    "inherits": ["ninja-general" , "win-vcpkg_settings" ],
    "cacheVariables": {
        "CMAKE_C_COMPILER" : "$penv{LLVMInstallDir}/bin/clang-cl.exe",
        "CMAKE_CXX_COMPILER" : "$penv{LLVMInstallDir}/bin/clang-cl.exe",
        "CMAKE_BUILD_TYPE": "Release",
    },
    "architecture": {
        "value": "x64",
        "strategy": "external"
     },
     "toolset": {
        "value": "host=x64",
        "strategy": "external"
     },
    "vendor": {
        "microsoft.com/VisualStudioSettings/CMake/1.0": {
          "hostOS": [ "Windows" ],
          "intelliSenseMode" : "windows-clang-x64",
          "enableMicrosoftCodeAnalysis" : true
        }
    }
},

Originally posted by @Neumann-A in https://github.com/microsoft/vscode-cmake-tools/issues/1885#issuecomment-991155721

(Copied from #1885)
We currently only auto-configure the vcvars env for you if your clang-cl corresponds to a Visual Studio Kit we've previously scanned.

My current workaround:
export CMAKE_C_COMPILER=clang
export CMAKE_CXX_COMPILER=clang++
cd build
cmake ..
cd ..

Without calling vcvars I'm getting
[cmake] -- The C compiler identification is unknown
[cmake] -- The CXX compiler identification is unknown

And
CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.

When ninja is not in path eventhough it's installed with visual studio.
Seems to be unrelated to clang ... the environment just does not get set.
I need to launch vscode from a Visual Studio Developer Command Prompt (the x64 specifically because it defaults to x86 for some reason)
I'd like to keep the presets platform agnostic and free of absolute paths.

Does this now have a solution?

This in particular results in failure to build projects using OpenMP with clang, see https://gitlab.kitware.com/cmake/cmake/-/issues/26308#note_1575696.

@Kaltxi @aiyolo If you utilize the cmake.useVsDeveloperEnvironment setting and set it to always, does this fix your issue?

@gcampbell-msft Hello, thanks for a suggestion, but it doesn't seem to help. Launching Code from Developer PowerShell for VS 2022 does though.


deployCluster.sh should move & rename the ACS engine local folders

Need to remove (rm -rf) or override folders and files created by ACS engine.

Fixed with #107


network, slirp: remove unused attributes from bind mech

What this PR does / why we need it:
The vmi and virtIface attributes on the Slirp bind mechanism implementation are not being used.
This PR removes them from the code base.
Release note:

NONE

/sig network

/lgtm

/approve


test failures on geoserver 2.6

Looks related to recent catalog validation efforts:

[ ] testCoverageStoreCreate
This seems to be because we're not writing the workspace as part of the XML request
[x] testWmsLayer
This appears to be because the layer name contains a colon (invalid XML) - instead, we need to sanitize this and also provide the nativeName

Both testWmsLayer and testCoverageCreate are passing on Geoserver 2.4-2.8.  Closing.


Trim down interface

I've been using femme for a while now, and initializing it always requires copying over some boilerplate. I wish we could streamline this slightly:
femme::info()?; // start femme with info log level
femme::trace()?; // start femme with trace level

In addition to that, something that env-logger does well is provide a way to filter messages. In reality these methods should be be a constructor for a Logger struct that can be further configured.
This would also allow us to trim down the submodules we have. When piping we should always print out ndjson. When printing to stdout we should use the pretty printer.
The "simple" printer becomes a bit of a strange one, but perhaps we don't need it per-se? I'm unsure really. Thoughts would be welcome here. Thanks!

This issue seems like it was addressed in https://github.com/lrlna/femme/commit/aa1fd83649cb412613575ab83eeb3d75bfa8a6fe


[tool_crash] ProcessException: The directory name is invalid. Command: C:\flutter\bin\cache\dart-sdk\bin\pub.BAT, OS error code: 267

Command
flutter create MYFIRSTAPP

Steps to Reproduce

...
...
...

Logs
ProcessException: The directory name is invalid.
Command: C:\flutter\bin\cache\dart-sdk\bin\pub.BAT, OS error code: 267
#0      _ProcessImpl._start (dart:io-patch/process_patch.dart:390:33)
#1      Process.start (dart:io-patch/process_patch.dart:36:20)
#2      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:44:22)
#3      ErrorHandlingProcessManager.start.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:691:24)
#4      _run (package:flutter_tools/src/base/error_handling_io.dart:567:20)
#5      ErrorHandlingProcessManager.start (package:flutter_tools/src/base/error_handling_io.dart:690:12)
#6      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:425:28)
#7      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:444:35)
#8      _DefaultPub.batch (package:flutter_tools/src/dart/pub.dart:308:34)
<asynchronous suspension>
#9      _DefaultPub.get (package:flutter_tools/src/dart/pub.dart:248:7)
<asynchronous suspension>
#10     PubDependencies.update (package:flutter_tools/src/flutter_cache.dart:119:5)
<asynchronous suspension>
#11     Cache.updateAll (package:flutter_tools/src/cache.dart:557:9)
<asynchronous suspension>
#12     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1227:7)
<asynchronous suspension>
#13     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1125:27)
<asynchronous suspension>
#14     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#15     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#16     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:288:9)

[✓] Flutter (Channel stable, 2.5.1, on Microsoft Windows [Version 10.0.19042.1237], locale en-US)
    • Flutter version 2.5.1 at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ffb2ecea52 (13 days ago), 2021-09-17 15:26:33 -0400
    • Engine revision b3af521a05
    • Dart version 2.14.2

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\Admin\AppData\Local\Android\sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Android Studio (version 2020.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.60.2)
    • VS Code at C:\Users\Admin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 94.0.4606.61
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 94.0.992.31

! Doctor found issues in 1 category.

Flutter Application Metadata
No pubspec in working directory.

This looks like a duplicate of https://github.com/flutter/flutter/issues/80418
@OffyOfay We are looking for more information on this. If you can reproduce this, could you please collect and share full logs with the --verbose flag, and if you are willing could you also share the full path of your project and working directory? Thanks!

@OffyOfay Please try to create a new app again using flutter create mytestapp --verbose command and see if you again get the same exception. If so, please provide us the entire verbose log. The log will be huge, so you can put that in a text file and share it here.
Thanks.


Email contributors DCP links

The aim is to email all the contributors/authors of the 16 datasets that have been released in the DCP to tell them their data is now available.
There is 2 versions of a standard email that can be used and tweaked/modified as deemed appropriate (there is one version for primary contributors and one for authors that we have curated the data from publication)
https://docs.google.com/document/d/1coB2-tq2KarMx7EhMf4vZQHj4qCL3J_p1Nk5gRUqmmY/edit

[x] "EmbryonicHindlimb" Single-cell transcriptional landscape of human embryonic limb development @ESapenaVentura
[x]  "AdultHemOrgans" Transcriptomic characterisation of haematopoietic stem and progenitor cells from human adult bone marrow, spleen and peripheral blood @rays22
[x]  "Oligodendrocytes_ms" Altered human oligodendrocyte heterogeneity in multiple sclerosis @ESapenaVentura
[x]  "HumanAdultKidneyLiaoMo"  Single-cell RNA sequencing of normal human kidney @ESapenaVentura
[x] "NKTPBMCZhao" Single-cell RNA-seq of human peripheral blood NKT cells @ESapenaVentura
[x]  "pbmcCov19Flu" Immunophenotyping of COVID-19 and influenza highlights the role of type I interferons in development of severe COVID-19 @ESapenaVentura
[x]  "HealthyAndCirrhoticLiver" Resolving the fibrotic niche of human liver cirrhosis using single-cell transcriptomics @ESapenaVentura
[x] "HumanAdiposeTissue" Identification of a mesenchymal progenitor cell hierarchy in adipose tissue (scRNA-seq)
 @ESapenaVentura
[x]  "DevelopingCardiacSystem" Transcriptomic Profiling of the Developing Cardiac Conduction System at Single-Cell Resolution. @ami-day
[x]  "Pitx2DevelopingHeart" [A Cellular Atlas of Pitx2-Dependent Cardiac Development.] (https://data.humancellatlas.org/explore/projects/7027adc6-c9c9-46f3-84ee-9badc3a4f53b?catalog=dcp2) @ami-day
[x]  "Lung_Fibroblasts" Defining the Activated Fibroblast Population in Lung Fibrosis Using Single Cell Sequencing. @ami-day
[x] "Substantia_nigra_and_locus_coeruleus" Integrative computational analysis of the substantia nigra pars compacta and the locus coeruleus @ESapenaVentura
[x]  "ColonImmune10XSS2VDJ" Distinct microbial and immune niches of the human colon @mshadbolt
[x] "HeartSingleCellsAndNucleiSeq" Cells of the adult human heart @mshadbolt
[x]  "FetalLiverHaematopoiesis" Decoding the development of the blood and immune systems during human fetal liver @mshadbolthaematopoiesis @mshadbolt
[x] "PulmonaryFibrosisGSE135893" Single-cell RNA-sequencing reveals profibrotic roles of distinct epithelial and mesenchymal lineages in pulmonary fibrosis @ESapenaVentura

I sent the three emails I assigned myself to

I sent the three emails I assigned myself to

I sent the emails I assigned myself to

I sent the emails I assigned myself to

Same, we're all done now so moving this ticket to done.

Same, we're all done now so moving this ticket to done.

I can't find this ticket in the Zenhub board so I am closing it here.

I can't find this ticket in the Zenhub board so I am closing it here.


Reduce ambiguous paths in macros

Current macros are not hygienic in path resolution. This causes compile error with codes like below.
deno_core::extension!(
    ext,
    js = [ "/path/to/ext.js" ]
);

mod std {}

error diagnostic:
error[E0433]: failed to resolve: could not find `borrow` in `std`
  --> src/lib.rs:14:1
   |
14 | / deno_core::extension!(
15 | |     ext,
16 | |     js = [ "/path/to/ext.js" ],
17 | | );
   | |_^ could not find `borrow` in `std`
   |
   = note: this error originates in the macro `deno_core::extension` (in Nightly builds, run with -Z macro-backtrace for more info)

This PR almost resolves this problem, by using unambiguous paths. There are still ambiguous paths remaining, but they won't couse such a issue because they only appear in unexported macros. I'm sorry if I missed something :pray:
references about hygienic macro:

https://en.wikipedia.org/wiki/Hygienic_macro
https://doc.rust-lang.org/reference/macros-by-example.html#hygiene
https://gist.github.com/Kestrer/8c05ebd4e0e9347eb05f265dfb7252e1

OK, I'll revert other macros.

By hand, unfortunately... I think cargo-expand might be useful for automatic expanding.


Update readme instructions to use port 8545

Checklist:

[x] Code contains relevant tests for the problem you are solving
[ ] Ensure all new and existing tests pass (TODO: get testing in this repo sorted out)
[x] Update any relevant READMEs and docs
[x] Submit to the develop branch instead of master

Description:
Updates README to use port 8545 when running local blockchain (PR to change port in origin.js: https://github.com/OriginProtocol/platform/pull/102)

Oops looks like I somehow created a duplicate of this. https://github.com/OriginProtocol/demo-dapp/pull/123


wayland: attempt to create a working clipboard

while these changes don't fully implement a working copy/paste.
I have confirmed that when Clipboard::get_string is invoked the
contents from the system clipboard are returned.

as an aside the reason I think paste isn't working entirely with this change is because of which key codes are being returned... just havent had a chance to dig into it yet to confirm.


Conflicts with Deluxe hub

I tried to manage game rules of the world but it always restarts with true on every game rules of the world in global.
Seems that there is conflict between the game rules of the DeluxeHub when loading worlds outside from out of the ordinary worlds (Lobby in this case).
Is a great addition but is difficult to get this plugin to make it work with lobby plugins that change game rules as well.

Hi there, thanks for the report!
By game rules, are you referring to flags?
Are there any errors in the console?

Fixed that issue in commit https://github.com/joserodpt/RealRegions/commit/804b26b0f148b709254d96ded52fb1bbb3b9d2ad, please test the below jar file, thanks!
RealRegions.jar.zip

Thanks for the quick response, It seems to work now they stay at a place in a global scale.
This may be related now to the Deluxehub plugin but still allows to drop items. I had to disable RR on the Lobby world in order to Deluxe hub concede the Flags for the world but still allow the Load "worlds" from RealRegions.
Thanks for the quick support.

Hi there, glad that it is fixed! :D


JOSS review comments

Hello, these are some starting comments for review https://github.com/openjournals/joss-reviews/issues/6805
For what I have seen so far, singularity-eos looks very helpful and comprehensive.
Looking at your Getting Started site in the documentation, I think it could be useful to have also -DSINGULARITY_BUILD_EXAMPLES=ON and then say something like "as a quick check of your installation go to /build/example and run ./get_sound_speed_press you should be able to see the following output: "
The final values are:
rho = 0.987467
uu  = 0.00987467
P   = 0.0059248
cs  = 0.0979796

I personally like having a sanity check when installing/using a new tool. And as a reviewer, is this the result I should be getting? I must admit I didn't compute the EOS values myself. I believe it is valuable to have the expected output of the example.
I'm not an expert in CMake, but I think it might look more consistent if the code snipets for both Getting Started and  Examples used mkdir -p build && cd build,  and not build for Example and bin for the Getting started?
For the Python Bindings documentation, it might be worth it to mention to add the singularity-eos\build\python to the $PYTHONPATH (or the path were users install singularity-eos /lib/python.../site-packages)
The EOS Models page doesn't show several of the Figures, is that on purpose?
I still need to check the written paper and a few more things, but these are my initial thoughts.

I personally like having a sanity check when installing/using a new tool. And as a reviewer, is this the result I should be getting? I must admit I didn't compute the EOS values myself. I believe it is valuable to have the expected output of the example.

I added the examples as a sanity check. But I think a more quantitative sanity check is the unit tests, so I added those to getting started as well.

The EOS Models page doesn't show several of the Figures, is that on purpose?

Not on purpose. It appears that whether or not the pdfs display properly is browser dependent. I changed the figures to pngs which should be supported by all browsers.

I'm not an expert in CMake, but I think it might look more consistent if the code snipets for both Getting Started and Examples used mkdir -p build && cd build, and not build for Example and bin for the Getting started?

Good point. I tried to make this more consistent.

For the Python Bindings documentation, it might be worth it to mention to add the singularity-eos\build\python to the $PYTHONPATH (or the path were users install singularity-eos /lib/python.../site-packages)

Good point. I added some verbage to this effect.

Thank you for addressing my feedback, I will be taking a look at your PR hopefully tomorrow.
I read the software paper and it reads really well, I only have a question about one reference. In the performance portable polymorphism section, the citation for OpenMP Target Offload is from 2001. I could be wrong, but I thought OpenMP 4.0 was the first version that started supporting accelerators offload, and that was released in 2013? Or are you citing OpenMP in general?

Thank you for addressing my feedback, I will be taking a look at your PR hopefully tomorrow.

Thanks @guadabsb15 ! Sounds good.

I read the software paper and it reads really well, I only have a question about one reference. In the performance portable polymorphism section, the citation for OpenMP Target Offload is from 2001. I could be wrong, but I thought OpenMP 4.0 was the first version that started supporting accelerators offload, and that was released in 2013? Or are you citing OpenMP in general?

Yes---the 2001 reference is the recommended citation for OpenMP as a whole. I will modify the citation location to clarify this. I'll also stick in a reference for OpenMP 4.0. I'll just sneak these into MR #428.

Hi! I took a look at PR #428  and it looks good. However, for the quickstart I think the unit tests are a bit too involved/in depth. Just the example, to check the installation worked, like you put it is great.

for the quickstart I think the unit tests are a bit too involved/in depth. Just the example, to check the installation worked, like you put it is great.

Fair enough! I removed the reference to the unit tests. Thanks @guadabsb15 . Should I go ahead and merge that MR and close this issue?

@Yurlungur sounds good! The MR looks great and takes care of the comments in this issue.

Great thank you!


add GeoIP license ley to config and update scripts

Added GeoIP license key to Configure and update_geo scripts
Clearly describe the problem and solution
As of 30 December 2019, MaxMind requires a license key to download free GeoIP databases.
Relevant issue number(s) if applicable
#1350
Did you run npm run lint from the viewer or parliament directory (whichever you are making changes to) and correct any errors
No
Did you Ensure that all tests still pass by navigating to the tests directory and running ./tests.pl --viewer
No
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Oops, need more changes to moloch_update_geo.sh, working on it...

Done.

No longer applicable - resolved by another commit.


Run page links to tasks & replay run modal improvements

The run inspector now has links to the parent and root tasks

Batchtrigger() spans now display the triggered runs in a table in the inspector

A more subtle "Root" badge

Added a description to the Replay modal panel

Summary by CodeRabbit
Release Notes

New Features

Introduced a new "extra-small" variant for badges, enhancing component flexibility.
Added a new custom hook, useReplaceSearchParams, for managing URL search parameters.
Enhanced display of triggered runs with a structured table format in the UI.
Added a new Story component for rendering static and sticky header tables.

Improvements

Streamlined logging output for function calls, improving clarity.
Updated UI components for better alignment and spacing, including modifications to the ReplayRunDialog and TaskRunsTable.
Added new relationships in data structures for SpanPresenter and RunPresenter, enhancing the information available.

Bug Fixes

Removed unnecessary email reply parsing functionality to simplify email handling.

Chores

Added indices to the database schema for optimized query performance.

Does the batchTrigger table link to the triggered runs?

Does the batchTrigger table link to the triggered runs?

Yep
https://github.com/user-attachments/assets/9dce8832-c82f-4143-9f1f-8dec81a5711d


Test for memcached

Coverage remained the same at 100.0% when pulling 6ca58e647133fa60ac2929beae6b2b47ad80c2f1 on chadicus:master into 0e8a29e372bb30255b93a09d704228741581a930 on traderinteractive:master.

Coverage remained the same at 100.0% when pulling 6ca58e647133fa60ac2929beae6b2b47ad80c2f1 on chadicus:master into 0e8a29e372bb30255b93a09d704228741581a930 on traderinteractive:master.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #91 (ca16b14) into main (8c38a17) will decrease coverage by 5.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   73.96%   68.09%   -5.87%
==========================================
  Files           4        3       -1
  Lines         457      351     -106
  Branches       28        0      -28
==========================================
- Hits          338      239      -99
+ Misses         85       78       -7
  Partials       34       34

Flag
Coverage Δ

cdk
?

go-lambda
68.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c38a17...ca16b14. Read the comment docs.


Didn't seem to work

Hi
I tried loading this from my localhost and from my shared hosting, but I couldn't see the data registering in my real time GA tracker. Any idea on how to get this working? Is there a working tutorial somewhere I can read to see what I missed?

Closing this due to inactivity (no response from @grantkemp)

Hi - sorry didn't see above.  I managed to get it working great - if I can recall what changes I did, I will push them up - ( if relevant)


feat(client/main) Allow external server initial connection

Move port to an int convar due to MumbleSetServerAddress using an integer for the port
Remove initial caching of address and port in order to allow initial connection

I think I actually have something that fixes this already, along with an issue where it deadlocks the thread if not connected

https://github.com/AvarianKnight/pma-voice/commit/f7f90ec638cab341637a0419df6f6d578291c90f


added son-emu project website (still empty/based on containernet, will be updated when it works)

test this please


Improve pandoc's handling of docbook admonitions

If we're going asciidoc -> docbook -> epub with the last step via pandoc, we should really fix https://github.com/jgm/pandoc/issues/1234. Fortunately I had a look at the code and it looks easy.

I opened https://github.com/jgm/pandoc/pull/5593 upstream.

We're not using pandoc.


SOOO thanks if you can help me

Thank you for the tool, I encountered a problem while using it.  I hope you can help me solve it, the error is as follows:
INFO  REPORT: Post-analysis succeeded for file: /home/zdd/Ghidra-to-LLVM-master/udhcpd (HeadlessAnalyzer)
INFO  REPORT: Save succeeded for file: /udhcpd (HeadlessAnalyzer)
Traceback (most recent call last):
File "g2llvm.py", line 42, in
module = xmltollvm.lift(xmlfile)
File "/home/zdd/Ghidra-to-LLVM-master/src/xmltollvm.py", line 70, in lift
populate_func(ir_func, function)
File "/home/zdd/Ghidra-to-LLVM-master/src/xmltollvm.py", line 79, in populate_func
populate_cfg(function, builders, blocks)
File "/home/zdd/Ghidra-to-LLVM-master/src/xmltollvm.py", line 110, in populate_cfg
builder.store(stack_top, registers["RSP"])
KeyError: 'RSP'
Then, if the imported binary file is too big, it will appear “ java out of memory” error，how can I solve this
problem? thanks a lot!

see https://github.com/toor-de-force/Ghidra-to-LLVM/issues/4, its the same issue (RSP is a 64 bit register, it should be ESP instead for 32 bit binaries)


fix generating award periods in SANDBOX_MODE

Pull Request Test Coverage Report for Build 99

0 of 11 (0.0%)  changed or added relevant lines in 1 file are covered.
15 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-1.3%) to 96.005%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

openprocurement/auctions/geb/managers/awarding.py
0
11
0.0%

Files with Coverage Reduction
New Missed Lines
%

openprocurement/auctions/geb/managers/auctioneers.py
1
100.0%

openprocurement/auctions/geb/managers/checkers.py
1
100.0%

openprocurement/auctions/geb/managers/awarding.py
13
100.0%

Totals

Change from base Build 97:
-1.3%

Covered Lines:
1586

Relevant Lines:
1652

💛  - Coveralls


init error

Recalling mem. init failed to initialize when restarting the exe to be read

I'll upload my source code in a moment

Added in Memory.cpp
bool Memory::ResetDMA()
{
	DMA_INITIALIZED = false;
	PROCESS_INITIALIZED = false;
	return true;
}

bool Memory::ResetProcess()
{
	PROCESS_INITIALIZED = false;
	return true;
}

Main.cpp
void Init() {
	while (true) {
		Offset::UpdateOffsets();
		if (!mem.Init("edge.exe") || !gGame.InitAddress()) {
			LOG("[ERROR] Mem Initialize ERROR\n");
			config.init = false;
			mem.ResetDMA();
		}
		else {
			if (mem.GetPidFromName("edge.exe") != 0) {
				config.init = true;
			}
			else {
				config.init = false;
				mem.ResetDMA();
				mem.ResetProcess();
			}
		}
		Sleep(7000);
	}
}

CreateThread(nullptr, 0, (LPTHREAD_START_ROUTINE)(Init), NULL, 0, 0);

CMD
[+] Found Base Address for client.dll at 0x00007FF97C7A0000
DMA already initialized!
Process already initialized!
[+] Found Base Address for client.dll at 0x00007FF97C7A0000
DMA already initialized!
Process already initialized!
[+] Found Base Address for client.dll at 0x00007FF97C7A0000
inizializing...
dumping memory map to file...
Dumped memory map!
[!] Initialization failed with Memory map? Try without MMap
[!] Initialization failed! Is the DMA in use or disconnected?
[ERROR] Mem Initialize ERROR
inizializing...
dumping memory map to file...
Dump

Perhaps a Reinit() function should be added to reinitialize the DMA device handle and re-fixcr3.

I don't really understand what's wrong? you're only supposed to intiailize the process once, which you do at the start. If the target process closes, then you'll have to clear PROCESS_INITIALIZED, which you're already doing. but if you wanna reset DMA you'll have to do this:
void Memory::CloseMemory() { 	VMMDLL_Close(this->vHandle); 	DMA_INITIALIZED = false; 	PROCESS_INITIALIZED = false; }
You can't open another VMM handle without closing it first.

Thanks, I'll try it

Did you get it working?

In fact, no, every time I close the game and turn it on, I need to restart the cheat, I tried to write the function myself to detect that the game is running and initialize the cheat , but it doesn't work

Sorry for my English, I'm a Google Translate user

When I call mem.getpidfromname outside the mem.init function, pid always returns 0 (DMA has been initialized)

You're either doing something wrong in code, or the DMA is not initialized. This is not a bug or issue related to the library. I've provided a example above that can be used to close handle to DMA + set dma & process initialized to false. anything else you'll have to fix in your own codebase that allows for a reinitialization of the process correctly.
I'll be closing the Issue as it isn't a issue or bug with the library.


throw user-select: none on everything

the less it feels like a web app, the better.
unless there is an error message we specifically want people to be able to copy and paste to find out more (or it could link to a forum topic directly).

right will do. the console should probably be selectable since if people have issues, they can paste up the output of the command line tool...


Fluent code style

Perhaps this seems like a small things but it keeps coming up in PRs and people have different personal preferences.
But let's have a talk about how and why :-)
Example: https://github.com/Energinet-DataHub/geh-charges/pull/723/files#r732529631


webpack complains about v3

WARNING in ./~/zxcvbn/lib/zxcvbn.js
Critical dependencies:
1:479-486 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ ./~/zxcvbn/lib/zxcvbn.js 1:479-486

this everytime it tries to build our app requiring zxcvbn

I'm new to webpack, what would you suggest to make it play nice w/ my browserify setup?

Problem is that webpack sees the source code is already minified which isn't good.
I have to add this webpack option so that the above warning gets ignored during gulp
noParse: [/zxcvbn/] # Do not parse zxcvbn because it's prebuilt

@binarykitchen you could try require('zxcvb/src/main') if you enable coffeescript with webpack (I don't know it well enough to know if it is an options).
@lowe maybe change src/main.coffee to src/index.coffee?  that way it could be require('zxcvbn/src')

but the /src folder is in the .npmignore list, so that won't work. for npm modules it's recommended always to include the source code.

OK, I think I now have a setup that will make everyone happy.
-- zxcvbn.js and zxcvbn.js.map now live in dist, not lib.
-- I added a prepublish hook to package.json that compiles each .coffee file in src to a .js and .js.map file in lib.
-- I changed "main" in package.json to point to lib/main.js instead of bundled/minified code.
All together:
npm: includes dist/, src/ and lib/
bower: includes dist/, ignores src/ and lib/
git: includes dist/ and src/, ignores lib/
external source maps are included in both dist and lib
@binarykitchen, can you update and try your webpack setup without the noParse and see if it magically works? See the README for a new browserify / webpack section.
Decisions that I'm open to feedback on:
-- While I don't like checking in minified code (dist/) to github, I want people to be able to easily grab the latest build without an npm build dependency. So what I plan to do is separate build commits from source commits to at least clean up the commit history that way. (At least compiled lib/ code is ignored by the repo.)
-- source maps grow the package size a good amount, but help everyone debug. An alternative would be to remove source maps from the package and offer a command to generate them for those that care.
-- I could have added src/ to .npmignore, but didn't -- some coffeescript npm package maintainers just include compiled lib/ on npm, and src/ on github. At the cost of a fatter package, I included src/ to make it easier to debug zxcvbn w/ the provided sourcemaps. Including src/, lib/ AND dist/ on npm may prove to be excessive.

wonderful, i can confirm, your changes are good - thx heaps


feat: beautified the navbar and refactored the code ; resolves #7

Description:

moved the pages from pages to menu directory for the new navbar

centered the title in Applicant tracking systems page

updated requirements.txt with the new dependency

changed the value attribute to placeholder in prompt examples page

rectified minor spelling errors in the app

Updated app image:

Two level tags on same PR can discard your PR count from GSSoC. I think it was a mistaken click by Suraj.


Provide min/max for values

Hello !
I hope I did not miss anything on the documentation, but I was wondering if one can specify the min/max allowed for an integer from the values.
An easy example would be for replicas. If for some reason I have a component that is unable to scale over 3 I'd like the chart to fail if the user provide the value 4 for replicas.
Is there something to achieve this that I would have missed ?

You can include a jsonSchema file in a chart. Helm will use it to validate the values. Numbers can have max and min values in the schema. This is the method we would recommend.

Awesome !
It was in the doc ! Sorry for the noise !


Dot doesn't repeat operation on targets

Repeat is not working on targets. If I press <C-a> or <C-x> after setting the mappings with:
vim.api.nvim_set_keymap("n", "<C-a>", "<Plug>(dial-increment)", {noremap = false, silent = true})
vim.api.nvim_set_keymap("n", "<C-x>", "<Plug>(dial-decrement)", {noremap = false, silent = true})
vim.api.nvim_set_keymap("v", "<C-a>", "<Plug>(dial-increment)", {noremap = false, silent = true})
vim.api.nvim_set_keymap("v", "<C-x>", "<Plug>(dial-decrement)", {noremap = false, silent = true})
vim.api.nvim_set_keymap("v", "g<C-a>", "<Plug>(dial-increment-additional)", {noremap = false, silent = true})
vim.api.nvim_set_keymap("v", "g<C-x>", "<Plug>(dial-decrement-additional)", {noremap = false, silent = true})

then the dot (repeat) operation doesn't work on targets.

You are right. Unfortunately, dot repeating is not supported yet in this plugin.
I'm hoping to support it someday, but to be honest, I have no idea how to do it.

Would you mind leaving this open? I might have time to take a look at in a few weeks if someone else doesn't submit a PR.

gitsigns implements it somehow.

you can integrate with tpope/vim-repeat. something like
    if addend < 0 then
        vim.cmd([[silent! call repeat#set("\<Plug>(dial-decrement)", v:count)]])
    else
        vim.cmd([[silent! call repeat#set("\<Plug>(dial-increment)", v:count)]])
    end

using the repeat on semver fees a bit werid. I'm updating a dependency, and as expected If I update a major it will reset everything else to 0, then if I move the cursos to the minor, and press . for the repeat, it will jump back to the major and increment that target instead of the minor. If I do C-a again thin the dot repeat works.
I would think most people would want to move through the semver components and increment each to the new target version, if they are updating a dependency. do you think I should open a bug for this?

It is not a bug. After increasing the semver major version with the first <C-a>, the next dot repeat becomes a specific operator that can increase only the "semver major version".
Due to the behavior, you can increment the major version of a semver in another location without worrying about the cursor position.
As you say, press  again if you want to increment minor version. Please refer to :h dial-dot-repeating.
There are currently no plans to change this specification or make it changeable, but if you don't like it, please create an issue as a feature request.


Introduce result type

[x] Upgrade ModernStorage to 1.5.10
[x] Rename MediaStoreClient.kt to MediaStoreRepository.kt
[x] Add permission handlers to MediaStoreRepository
[x] Rename MediaResource to FileResource
[x] Add @Parcelize to FileResource
[x] Expand media support to audio files
[x] Simplify API naming
[x] Add file scanning feature
[x] Update sample app
[ ] Add guide
[ ] Upgrade project version

@googlebot I fixed it.


[FEATURE] Support for Shopware landing pages

Description
As @elkmod added support for landing pages (https://github.com/elkmod/SwagShopwarePwa/releases/tag/v0.3.1), it'd be really cool to be able to use this feature in shopware-pwa.
I think the only thing that has to be done is to duplicate components/views/frontend.navigation.page.vue to components/views/frontend.landing.page.vue (at least that's what my tests say.)
Acceptance criteria

[x] PWA is able to resolve routes that are landing pages and render the CMS-Page.

Great job figuring that out! Thank you :)

Was not that hard as you can see 😂
But thanks 😊


⚠ IMAP has degraded performance

In ba56e71, IMAP (https://news.ycombinator.com) experienced degraded performance:

HTTP code: 200
Response time: 6075 ms

Resolved: IMAP performance has improved in 64ed796 after 11 minutes.


[Discussion] Remove lifecycle hooks cause they violates the motivation of why React team create hooks.

Hi, the react-use team, thank you for creating this useful library.
There is one question that confuse me for a long time. Do we really need lifecycle hooks? Recently I read the motivation of why React team create hooks. In which they said:

... components might perform some data fetching in componentDidMount and componentDidUpdate...
To solve this, Hooks let you split one component into smaller functions based on what pieces are related (such as setting up a subscription or fetching data), rather than forcing a split based on lifecycle methods.

IMO the react team introduces hooks to avoid the code splitting based on lifecycle methods and make developers focused more on business logic. So the lifecycle method is unnecessary.
There is another bad case when I refactor the codebase written by my colleague. She used useMount like what she did with class components. The data fetching logic repeats in useMount and useEffect which makes code hard to understand and maintain.
And also, the useMount hook hides the fact that the effect should be rerun if its dependencies change, by forcing leave its dependencies empty:
useMount(fn) = useEffect(()=> {
   fn();
}, []);

This fact is how the react hooks, especially the useEffect hook works. There is no need to use useMount if you use useEffect correctly(for example, use a constant value instead of a variable to empty the dependency array).
So why do we need to use these lifecycle hooks if they violate(maybe) the motivation of why React team created hooks? Or more accurately, hide the fact of how hooks run.

useMount could actually fix the double calling of side-effects introduced with react 18's strict mode.
Also useEffectOnce is called twice when included in a React.StrictMode component

Also need to remove useUnmount


FINERACT-822 enable and enforce Error Prone

Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket: https://issues.apache.org/jira/browse/FINERACT-822
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.

[ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.

[ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.

[ ] Integration tests have been created/updated for verifying the changes made.

[ ] All Integrations tests are passing with the new commits.

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

@percyashu ..Have  u being able to check the logs and see why this is failing? (I have not checked)

@awasum It is due to Travis java version. Error prone has some compatibility issues with java 12. Once the pull request to change the version is merge I will run checks again.

@percyashu I've just merged #846 so you're unblocked now - I look forward to reviewing this, once you manage to make it pass the build!

@vorburger there are a lot of warning and the errors that occurred I modified the ones I understood and some like the MisusedWeekYear just added a suppress warning since not very sure. Hence build should no longer fail because of errors picked up by error prone.
The build seems to now fail due to not able to download some jars. I will check and see why this is failing.

@vorburger build passes now.

Hm, nice, thanks! Super cool how it already found those clear real bugs in hashCode(), no? But... we should address all the problems, not use SuppressWarnings. Or merge this, and then fix them all... but will we? These kinds of things often get forgotten... May I try to be a PITA ;-) and suggest we fix them all here already, before merging?

@vorburger Sure was think the same thing.

@vorburger Sure was think the same thing.

Ok, great, and.... were you going to address that here? :smile: Or would you like someone else to have a closer look and see if they can raise a follow-up PR which takes yours but removes all the new ignores and fixes those problems properly? Maybe this is something that could you interest you @thesmallstar? (You don't have to, I just thought you may like this; this is related to the "code quality" theme overall, but has nothing directly to do with your Checkstyle related efforts.)

If I am not wrong, @percyashu  has this planned for his summer in GSoC?

Am going to address it here @vorburger. Start to remove the warnings from compileJava.
Yeah @thesmallstar i have plan to do this.

Am going to address it here @vorburger. Started to remove the warnings from compileJava.
Yeah @thesmallstar i have plan to do this.

Now with https://github.com/apache/fineract/pull/859 merged, warnings cause build to fail. Fixing them as they cause build fail now

Now with #859 merged, warnings cause build to fail. Fixing them as they cause build fail now

@percyashu FYI that's done in #893

@vorburger I meant with "-Werror" errorprone compiler warnings are now errors.

Seems there is a conflict here. @percyashu . Want to address that? Thanks.

@percyashu are you on this?

@vorburger yes i am on this. Will check why this is failling

While you are working on this...keep an eye out for the conflicts that develop as a result of other PRs and fix them.

If rebase does not fix these conflicts @percyashu , please try to resolve them manually.

@awasum LGTY?

some initial review feedback.. hope I'm not "too harsh" ?
@awasum perhaps we could alternative reviewing this one - see my feedback, and next round you check if @percyashu has taken what I'm raising into account, and I'll only re-check it after you LGTM it, would that work for you?
/Cc @thesmallstar FYI given that you also work on code quality, perhaps this review feedback interests you.

Sounds like a good plan.

@percyashu If you have addressed a review feedback by @vorburger , just click on "Resolve Conversation" so its clear.


book: Ch 11 Building a Simple To-Do App: Missing explanation of window::new_tasks()

I see an anchor for window::new_tasks in the referenced source code, but the method isn't mentioned or visible in the chapter without un-hiding lines for the file.

Nice find, thanks for reporting @cornmonger!


Tiere nur nacheinander einsortierbar nach Ablauf des Ringaudios

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

It would require a rewrite of the audio helper function to work correctly. We would need to enqueue audio files so that they can be played consecutively. While playing the array the UI should freeze... this is a bigger todo.


Added support for forwarding path attribute in Cloud DNS

I updated the target server ipv4 list to a list of objects (with ipv4_address and forwarding_path attributes).
Example of usage:
forwarders = [
    {
      ipv4_address    = "<IP_ADDRESS>"
      forwarding_path = "private"
    },
   {
      ipv4_address    = "<IP_ADDRESS>"
      forwarding_path = "default"
    }
]

/gcbrun

Nice. Can you make sure all tests pass before we merge?

I would prefer to use a map ip address => path instead of a list of maps. Less to type, more readable.

Closing as #171 does it slightly differently and also fixes examples and tests.


[doc] Remove spurious data section.

Not sure if this hack prevents the line starting with "data:" to be interpreted as a data section, please test.
Note: data sections seem to be an undocumented feature of ddoc: https://dlang.org/spec/ddoc.html
Maybe ddoc should require an empty line above (real) sections?

This doesn't seem to be working, build failed. What is the customary fix for an issue like this?

The doc builder is currently broken<EMAIL_ADDRESS>

OK thanks. Good luck...

Auto-merge toggled on


Additional item tags

I wanted a place to collect ideas for additional item tags that may likely become necessary but aren't quite yet. I hate keeping ideas in my head, better to get them out. First up:
NO_DROP - Item cannot be dropped and does not drop on death (goes into limbo with the creature reference). For 'NPC only' items that the player should never see, and possibly for quest items or maybe cursed items.

Find an expression about how an item reacts with water. Weather will moist some items up, swords may be corroded for the sake of reality. Wet sticks do less damage, etc.


Fix release-data i18n

Not sure how to extract three single word.
Please give me some advice about better practices.
Current: https://kubernetes.io/releases/ (Hard-coded)
Preview: https://deploy-preview-35950--kubernetes-io-main-staging.netlify.app/releases/ (Not broken)
zh: https://deploy-preview-35950--kubernetes-io-main-staging.netlify.app/zh-cn/releases/ (Not translated yet)
Relates: #35932

Fixes #35932

Assigning @sftim since he is already engaged on this.
/assign @sftim

By the way, I meant to thank you @Sea-n for quickly offering a solution! Excellent work!

@Sea-n 您如何看待这些评论？ 他们还好吗？
What do you think about these comments? Are they okay?

If you don't mind @Sea-n, I'm going to go ahead and create a new PR based on this one.

I think it would be better to use a format string to enable the localization team to change the word order, but not sure how to do it in Hugo.

tract three single word.
Please give me some advice.

I don't know either. I think we should work to implement the current solution, and create a new issue for this requirement.
This PR is based on the zh branch. When I look at the change history, it brings the change history from the zh branch into main. I think that might be a problem. Our contributor docs state that feature branches must be based on the branch (main) they will be merged into (main).

I didn't get it, isn't this PR based on (and merge to) main branch?
Could you provide some screenshots so that I can understand better.

Hi Sean. Sorry - I'm at work now, so I can't look into this until much later. Yesterday, when I did a test merge of your my first PR which was based on yours (Localize release-data i18n #36359) yesterday, I saw a lot of localized zh content in the changed that was unrelated to this PR. If you try git log, what do you see?
I recreated our work in a new PR that's based on main here: Fix release-data i18n #36375

Close as completed by another PR.

#36375


Substitution is not working in NodeJS based transactional templates

The email is sent successfully but with empty string replacement.
The following is the code snippet
const mailOptions =  {
"personalizations": [{
"to": [{
"email"<EMAIL_ADDRESS>}],
"dynamic_template_data": {
"name": "Sulman"
}
}],
"template_id": "d-05b9e8dc6c7b42799900d31135891816",
"from": {
"email"<EMAIL_ADDRESS>}
};
sgMail.setSubstitutionWrappers('{{', '}}'); // Configure the substitution tag wrappers globally
sgMail.send(mailOptions)

.then(() => console.log('Mail sent successfully'))
.catch(error => console.error(error.toString()));
Link to the template is:
http://prntscr.com/lfxhl4
Using
@sendgrid/mail": "^6.2.1
Node: v10.13.0
Please help I am stuck with it and I don't understand what is the real problem.

Hi @shahrpt I think I might be able to help. Try replacing {{name}} in the template to %name%
See the documentation on template substitution tags for more info: https://sendgrid.com/docs/API_Reference/SMTP_API/substitution_tags.html

Thank you for the response, FYI, I am using sendgrid mail not smtp.
sgMail = require('@sendgrid/mail'),
I have replaced {{name}} with %name% but it is not replacing it with any value. It is showing it as in the email been sent.

I still dont understand what is wrong, what is legacy API and what is new here.

If you’re using transactional templates, you should use dynamic templates
and the dynamic_templates_data key.
https://sendgrid.com/docs/ui/sending-email/how-to-send-an-email-with-dynamic-transactional-templates/
On Thu, Nov 8, 2018 at 8:53 PM Sulman<EMAIL_ADDRESS>wrote:

Thank you for the response, FYI, I am using sendgrid mail not smtp.
sgMail = require('@sendgrid/mail'),
I have replaced {{name}} with %name% but it is not replacing it with any
value. It is showing it as in the email been sent.
[image: screenshot_2]
https://user-images.githubusercontent.com/2241234/48242396-d1726900-e3fc-11e8-9220-47329f590ca0.png
I still dont understand what is wrong, what is legacy API and what is new
here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/sendgrid-nodejs/issues/844#issuecomment-437241724,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACL-sp4QON9_C5uM4pmED0JfMyz-Jie3ks5utPxGgaJpZM4YU3oF
.

Also, it may be that you don't need the personalizations key.  And, I don't think you need to use setSubstitutionWrappers()
https://github.com/sendgrid/sendgrid-nodejs/blob/master/packages/mail/USE_CASES.md#transactional-templates

@aroach taking care of you suggested changes, I still cant get any success with substitution of the template data in the email that I am receiving.

@shahrpt do you have your project anywhere public on GitHub?

@shahrpt I'm unable to reproduce the issue you're seeing.  I copied your mailOptions object, and used it instead of the example in the USE_CASES.md, and the {{ name }} was replaced.  I think I accidentally even sent one to you, so you should see that in your inbox.
const sgMail = require('@sendgrid/mail');
sgMail.setApiKey(process.env.SENDGRID_API_KEY);
// const msg = {
//   to<EMAIL_ADDRESS>//   from<EMAIL_ADDRESS>//   subject: 'Hello world',
//   text: 'Hello plain world!',
//   html: '
Hello HTML world!
',
//   templateId: 'd-95dd143964c34e2e987b5a2567f148e6',
//   dynamic_template_data: {
//     subject: 'Testing Templates',
//     name: 'Some One',
//     city: 'Denver',
//   },
// };

const msg = {
  "personalizations": [{
  "to": [{
  "email"<EMAIL_ADDRESS>  }],
  "dynamic_template_data": {
  "name": "Sulman"
  }
  }],
  "template_id": "d-95dd143964c34e2e987b5a2567f148e6",
  "from": {
  "email"<EMAIL_ADDRESS>  }
  };
sgMail.send(msg);

I'm having the same issue, not with dynamic templates but regular HTML text using substitutions tags.
let payload = {
    to: testEmail,
    from: {
      email: senderEmail,
      name: senderName,
    },
    reply_to: {
      email: senderEmail,
      name: senderName,
    },
    subject: 'Hey {{company}}',
    html: '
Hello {{name}}
',
    substitutions: {
      '{{company}}': 'SendGrid',
      '{{name}}': 'John Doe',
    },
  };
  await sgMail.send(payload);

What's funny is that substitutions work when I use sgClient instead of sgMail, as in
  let request = {
      method: 'POST',
      url: '/v3/mail/send',
      body: payload,
    };
  await sgClient.request(request);

Am I actually doing something wrong here?

Hey Felipe --
Try removing the handlebars syntax in the substitutions property:
substitutions: {
  '{{company}}': 'SendGrid',
  '{{name}}': 'John Doe',
},

https://github.com/sendgrid/sendgrid-nodejs/blob/master/use-cases/transactional-legacy-templates.md
Let us know if that resolved your issue!
On Wed, Dec 12, 2018 at 8:32 AM Felipe Vignon<EMAIL_ADDRESS>wrote:

I'm having the same issue, not with dynamic templates but regular HTML
text using substitutions tags.
let payload = {
to: testEmail,
from: {
email: senderEmail,
name: senderName,
},
reply_to: {
email: senderEmail,
name: senderName,
},
subject: 'Hey {{company}}',
html: 'Hello {{name}}',
substitutions: {
'{{company}}': 'SendGrid',
'{{name}}': 'John Doe',
},
};
await sgMail.send(payload);
What's funny is that substitutions work when I use sgClient instead of
sgMail, as in
let request = {
method: 'POST',
url: '/v3/mail/send',
body: payload,
};
await sgClient.request(request);
Am I actually doing something wrong here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/sendgrid-nodejs/issues/844#issuecomment-446629610,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACL-slpyIRiqkSV6DHKOp2PkKAUJaP7Aks5u4SGogaJpZM4YU3oF
.

Hey Felipe -- Try removing the handlebars syntax in the substitutions property: substitutions: { '{{company}}': 'SendGrid', '{{name}}': 'John Doe', }, https://github.com/sendgrid/sendgrid-nodejs/blob/master/use-cases/transactional-legacy-templates.md Let us know if that resolved your issue!
…
On Wed, Dec 12, 2018 at 8:32 AM Felipe Vignon @.***> wrote: I'm having the same issue, not with dynamic templates but regular HTML text using substitutions tags. let payload = { to: testEmail, from: { email: senderEmail, name: senderName, }, reply_to: { email: senderEmail, name: senderName, }, subject: 'Hey {{company}}', html: 'Hello {{name}}', substitutions: { '{{company}}': 'SendGrid', '{{name}}': 'John Doe', }, }; await sgMail.send(payload); What's funny is that substitutions work when I use sgClient instead of sgMail, as in let request = { method: 'POST', url: '/v3/mail/send', body: payload, }; await sgClient.request(request); Am I actually doing something wrong here? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#844 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL-slpyIRiqkSV6DHKOp2PkKAUJaP7Aks5u4SGogaJpZM4YU3oF .

Thanks, it did work!
But still I find it weird that using sgClient instead of sgMail the substitutions work with handlebars syntax but sgMail requires NOT to use the handlebars (did not test to see if using sgClient WITHOUT handlebars worked though).

@shahrpt,
Has your issue been resolved? Thanks!
With Best Regards,
Elmer


Skipped: generated by SADL  but still ni the staging when doing Transport-to-Branch

Hi,
We're trying to use Transport-to-Branch, but are having problems with some generated objects. There's a warning saying they are ignored, but when we try to create our transport-to-branch it still tries to stage the files, which is not working. I assume it tries to stage all objects that are in the transport, and ignores that it's been ignored earlier.
I'd love to help but don't feel comfortable enough in the abapgit code to add a check for this

created PR #2404

guess this issue can be closed?


Look into remove the dependency on Newtonsoft.Json

Use System.Text.Json that shipped with .NET Core runtime will reduce the size of the package. Look into how much will it take to implement it.

I'm using a .net 5 asp.net web api and there are no dependencies on Newtonsoft.Json. This caused a runtime error since the dependency wasn't identified through nuget.

@Matthewsre Are you saying your project isn't have an explicit or implicit dependent on Newtonsoft.Json today? That is weird. Although Newtonsoft.Json isn't depended upon by Microsoft.ApplicationInsights.Profiler.AspNetCore, it is depended on by Microsoft.ApplicationInsights.Profiler.Core, which is dependent on by the ASPNetCore package.
In other words:
Your project -> Microsoft.ApplicationInsights.Profiler.AspNetCore -> Microsoft.ApplicationInsights.Profiler.Core -> Microsoft.ApplicationInsights.Profiler.Core -> Newtonsoft.Json
Do I misunderstand your issue or could you please double check the dependency tree?
If you all check out, could you please file a new issue with the result from this cli:
dotnet list package --include-transitive

Much appreciated for the feedback!

Released in https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.AspNetCore/2.4.0-beta1.


Develop

Picking changes from develop to main.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: arunl2910:white_check_mark: arun-madhavan-013:x: deepthi-psdeepthi-ps seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this PR as CLA is not available.


shouldUnregisterOnShutdown for spring-cloud-netflix-eureka-client 1x

Question
I saw In spring-cloud-netflix-eureka-client 2.x there is a property called shouldUnregisterOnShutdown=true|false
Is there any similar feature on v1.x ?
Rationale
I have a fixed number of spring micro-services in my cloud.
I would need my spring boot client applications do NOT unregister to eureka server when they are shutdown but to set status otherwise like 'DOWN' or 'OFFLINE'.
Apparently, spring boot-admin only "detect" status changes if the application is not unregistered then registered when going through Eureka Discovery Server.

I know very little about spring boot admin. Monitoring doesn't seem like a solid reason to not unregister when the app shuts down. At that point, couldn't you tell by the number of instances?

I have opted to configure statically the monitored instances through SimpleDiscoveryClient
This way, the spring boot-admin keep tracks of status changes and send alerts only when it has to.


Make CommandBus configurable

Summary of changes:

Migrate to Builder-based approach from CommandBus#newInstance().
Remove hard-coded thread spawning and replace it with a configuration option.

@alexander-yevsyukov PTAL.


Support filtering ticked climbs

Branched from discussion in #16.
As is possible in the apps, it would be useful to be able to filter out climbs which you have already done. This is possible using both the sync and the logbook APIs, though the sync API would require some storage, which would greatly increase complexity.
One idea to do this without introducing storage of user data is to use the logbook API. The user could optionally provide a username and password on the board selection screen. Then a token can be fetched and stored in the query params when filtering. With a new filter to remove ticked climbs selected, the results API would fetch the users logbook, then remove those climbs from the fetched list.

Exactly, the 2nd version was what I was thinking about, to keep climbdex (still) as simple as possible. Haven't played too much with the API, but I thought (or hoped) it's possible to fetch the logged climbs just by querying the logbook with a valid username … to avoid a "login"

The only way I have gotten the logbook API to work is with a token, see here.
But yeah, an optional username/password on the board selection screen to then allow for tick filtering seems like a pretty light and nice addition.

FYI @gardaholm you can now login and have your ticked climbs show up. I didn't include it in the filter options at the moment, wasn't entirely sure it was necessary since it should be pretty easy to see in the list. Let me know what you think, I'll play around with it as well next time I'm climbing on the board.

already stumbled upon the feature this morning when I checked the page. Works really nice and I find it pretty helpful.
Don't think you need a separate filter for this. Will also give it a few sessions …


Update argument type of set expr function

It changes 3rd argument type os set expr function from TypedValue to interface, since GvalParser parses argument to native types before evaluating the expression.
Please take a look.

Codecov Report

:exclamation: No coverage uploaded for pull request base (2022.3.x@2404ce9). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             2022.3.x     #320   +/-   ##
===========================================
  Coverage            ?   42.99%
===========================================
  Files               ?      745
  Lines               ?    73499
  Branches            ?        0
===========================================
  Hits                ?    31604
  Misses              ?    37428
  Partials            ?     4467

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2404ce9...9ca114f. Read the comment docs.


Broken layout on continuation

There's a layout issue.
How to reproduce:

I asked to write a Python function to generate 10 random numbers.

I selected "Insert" to add the generated snippet to the code editor.

I selected the function in the editor > mouse right-click > Add comments

I get the following issue for the new code (the Copy/Insert/New buttons are below the code snippet, instead of being above it, and they don't work):

@candalfigomoro thanks for reporting this issue. I will check it out

@candalfigomoro This issue is now fixed in the latest version v3.3.4. Please upgrade your extension. Thanks for catching this issue and reporting.


Optimize STIR Prover

reuse the ans_polynomial to compute the quotient_polynomial
reuse the betas to compute the quotient_answer

After optimization, the proof time is reduced by 1.5s.
Original Version
STIR - Shaken
Targeting 128-bits of security - protocol running at 106-bits - soundness: Conjecture
Starting degree: 2^24, stopping_degree: 2^6
Starting rate: 2^-2, folding_factor: 16
Number of rounds: 4. OOD samples: 2
Rates: 2^-2, 2^-5, 2^-8, 2^-11, 2^-14
PoW bits: [22, 18, 16, 18, 16]
Repetitions: [53, 22, 14, 10, 8]

[src/bin/prover.rs:127:9] stir_prover_time =<PHONE_NUMBER>34s
[src/bin/prover.rs:128:9] stir_prover_hashes = 16252923

Optimization
STIR - Shaken
Targeting 128-bits of security - protocol running at 106-bits - soundness: Conjecture
Starting degree: 2^24, stopping_degree: 2^6
Starting rate: 2^-2, folding_factor: 16
Number of rounds: 4. OOD samples: 2
Rates: 2^-2, 2^-5, 2^-8, 2^-11, 2^-14
PoW bits: [22, 18, 16, 18, 16]
Repetitions: [53, 22, 14, 10, 8]

[src/bin/prover.rs:127:9] stir_prover_time =<PHONE_NUMBER>17s
[src/bin/prover.rs:128:9] stir_prover_hashes = 16252923

Thank you! Merged


Remove schemaVersion from new artifact manifest

Signed-off-by: Sajay Antony<EMAIL_ADDRESS>This change is to remove the schemaVersion from the new artifact manifest.

This is included in #59

Closing as this is already covered in #59


[CI] [Jenkins] Ubuntu build occasionally fails on dependency issue

A few time I've seen ubuntu_linux_release_static fail with this same error (and pass after rerunning):
Scanning dependencies of target Chakra.Runtime.Language
[ 57%] Built target Chakra.Parser
[ 57%] Building CXX object lib/Runtime/ByteCode/CMakeFiles/Chakra.Runtime.ByteCode.dir/OpCodeUtilAsmJs.cpp.o
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Runtime/Debug/TTSerialize.cpp:5:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Runtime/Debug/RuntimeDebugPch.h:7:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Runtime/./Runtime.h:7:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Common/Common.h:7:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Common/CommonMinMemory.h:7:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Common/CommonMin.h:7:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Common/CommonBasic.h:11:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/lib/Common/CommonPal.h:93:
In file included from /mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/pal/inc/rt/palrt.h:900:
/mnt/j/workspace/Microsoft_ChakraCore/master/ubuntu_linux_release_static_prtest/pal/inc/safemath.h:47:10: fatal error: 'type_traits' file not found
#include <type_traits>
         ^

@MikeHolman IMHO, there is a bad VM in the pool (i.e. llvm support headers are missing) and we've been hitting to that VM from time to time.
/cc @dilijev @mmitche

@obastemur The VMs are dynamically generated, so it's not that there's a bad VM. What we know so far is that even on the machines where this happens, rebuilding immediately after on the same machine (by directly logging in) doesn't repro the issue. It seems more complex than bad configuration. @mmitche is still investigating.
@MikeHolman when you see a build fail with this can you post here or email a direct link to the build summary page to @mmitche and CC @boingoing and me?
/cc @boingoing

@obastemur It's not a bad VM, it's been seen across a number of VMs and always succeeds on retry.  The weirdness of the error also seems to indicate some kind of corruption.

Maybe a timing issue? Consider a fresh VM, do we install dependencies from scratch?

We don't install anything from scratch, it's also not necessarily the first run on the machine.

Here is an instance of the problem:
http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/master/job/ubuntu_linux_release_static_prtest/801/

FWIW it seems like this is happening more often lately. Hit this yesterday on at least 4 different builds.
Also, not just happening on release build, looks like all Ubuntu flavors are hitting this. Here's another:
http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/master/job/ubuntu_linux_debug_static_prtest/799/

@MikeHolman These VMs are almost always fresh, so something else is going on.  I'm spinning up a VM to run some continuous testing and try and track down the source of the instability.

I hit this twice today so far; http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/master/job/ubuntu_linux_release_static_prtest/824/ is another repro log.

Seeing this error in http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/master/job/ubuntu_linux_test_prtest/834/consoleFull#-20814844619119f5c-76e5-4da8-b294-eb427d612413

Daily Ubuntu_linux_test build failed due to this http://dotnet-ci.cloudapp.net/job/Microsoft_ChakraCore/job/master/job/daily_ubuntu_linux_test/71/

@MikeHolman I couldn't get this to repro in isolation on a VM, so I might clone the job that fails the most and then try to run it successively until it fails again to try to discover a pattern.

@mmitche
Same PR:
Fail : https://ci.dot.net/job/Microsoft_ChakraCore/job/master/job/ubuntu_linux_debug_static_prtest/974/console
Success: https://ci.dot.net/job/Microsoft_ChakraCore/job/master/job/ubuntu_linux_debug_static_prtest/975/consoleFull
There are some differences in the output, hope it helps to figure out

I honestly have no idea what is going on.  Has this been seen on 14.04 btw?

@mmitche I don't think we run any 14.04 builds

See https://github.com/dotnet/dotnet-ci/pull/496
Thanks @mmitche

+1 to get updates on the issue

I think @mmitche's mitigation has mostly prevented us from seeing this issue (unless you happen to see it right before it retries. Since this is not a ChakraCore issue and @mmitche probably has it tracked on his end, maybe we should close this issue?
@mmitche is there a public issue open on your end we could track for updates?

I think this issue is mostly mitigated and we know to contact @mmitche for further related issues. I'm closing this issue.


ng-options object data sources keys with number type interpret as strings

Here is a sample controller
$scope.estCount = {0: 'N/A',
                   1: '0',
                   2: '1-9',
                   3: '10-99',
                   4: '100-999',
                   5: '1000-9999',
                   6: '10000-99999',
                   7: '> 100000'};
$scope.count = 2;

The select in the looks so
<select ng-model="count" ng-options="key as value for (key, value) in estCount"></select>
As you see the property names are numbers. count is a number too. But I get an additional line
<option value="?" selected="selected"></option>
If I set the count as string, the right option is selected.
$scope.count = "2";
Should the property names stay numbers or not?

Property names are never numbers in JavaScript. They are stored as strings.
ngOptions compares using strict equals (===), and so "2" === 2 is false.

petebacondarwin, But this is from Mozill JavaScript Guide.

Additionally, you can use a numeric or string literal for the name of a property or nest an object inside another. The following example uses these options.

In my case, it was the best solution, but I had to add much additional code to solve my task because angular doesn't accept the numbers as a property name.

@HighAley - sure you can provide an integer as a key - but internally it will be stored as a string. Try this:
var obj = { 0: 'a', 1: 'b', 2: 'c' };
Object.keys(obj).forEach(function(key) {
  console.log(key, typeof(key));
});

for(var key in obj) {
  console.log(key, typeof(key));
}

See http://plnkr.co/edit/9UlFuMO0mGyN27QQEuUn?p=preview


Use the fields value if it exist

I have an error when using the polyfill in Safari (probably other browsers as well but only looking in Safari). If the date input has a value on page load the polyfill ignores it.
In my situate someone comes to the form to edit the info and the currently saved info is there for them to edit. if they do not touch the date inputs and hit save then empty date fields are saved and the default date is blown away.

How is the field data being populated?  Keep in mind that setAttribute will not change the underlying value.

Please comment if you are still experiencing this issue.  Closing for now.


Reopen last files

If I close vscode and open it again the window is empty. Before 0.10.10 vscode have saved the file(s) and reopend the file(s) on the next start.

Maybe make it an option in preferences?

@MichaelCsitkovics I would hope we did not introduce a bug here, are you sure this used to work before 0.10.10? We only reopen files if you open a workspace folder, but not for an empty workspace.

Thx, works perfect in 0.10.11!


Segfault in GetBallRisky.cpp

Describe the bug
Roboteam_AI segfaults in GetBallRisky.cpp, line 49 on branch development.
To Reproduce
Steps to reproduce the behavior:
Run with referee and one robot. I clicked force start and it repeatedly happened.
Expected behavior
Code that does not segfault?
On ubuntu 20.04

Not reproducible for me.

Do you have 1 robot for both teams, or 1 for us and 0 for them?

The latter @timovdk , one for us, none for them.

I think that that is the issue, it's looping through none existing enemies. I will have a look on how to fix it, thanks @rolfvdhulst


s3-cache-pull 0.1.0

What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.

[ ] I will not move an already shared step version's tag to another commit
[ ] I read the Step Development Guideline
[ ] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[ ] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[ ] I read and accept the Abandoned Step policy

New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @alephao,
Thank you for your contribution. I'm sorry we haven't had the resources to start the review earlier.
I'd like to have a couple of questions regarding the implementation.

The pull & push steps share a significant amount of code in the parser package. Do you plan to add it as a module dependency, or a git submodule?
Both the pull and push step is used to handle 1 archive right? So if I wanted to push/pull multiple files/dirs I would either have to move them in one directory or add the pull and push steps multiple times in my workflow.
The cache push works in a way if it finds a key present in S3 it doesn't upload new content. So essentially once a file is written with a key to the storage it can never change, right?

For the sake of science, I'd like to ask whether you checked out our cache offering (cache-push and cache-pull) steps. It does a similar thing to these steps however it handles the key generation a bit differently (and uploads the entire content of the cache in one archive).
Apart from the fact that it doesn't upload to S3 is there anything in those steps' mechanism that doesn't fit your use-case? We'd like to know how could we improve our caching so there is no need for multiple cache steps in the step library in the long run.

Hi @alephao,
Thanks for the detailed answer I'll bring these back to the team.  I've reviewed the step.yml and there are some changes we'd like to request. Please fix these in the step.yml of the step and reopen a steplib PR. I'm going to close this PR. (Unfortunately, this is the easiest way to update)


Make eventbase understand sensor types, deal with sensors being accumulated values

If sensors are continuously increasing values, then the events in a period should be merged a bit differently.
Check what the current design does to these events in terms of computing the period value, and change it accordingly.
We should use the last value reported in the previous period for the delta ?

Closing this one. The current thinking (#97) is that we should send batches of events to the daemon, and let the control loop do the analysis it wants.


Update infinitybotlist.com

Updated domain to infinitybots.gg as this is now our primary domain for documentation, api and website usage.

Updated documentation link

Apologies should have made these changes with my pr the other day but didn’t even realize these still used the old domain!

👋 As you are changing the id of the list, please can you also update the legacy ID mapping so that this doesn't break folks ability to use this list

Ahh I was wondering what I did wrong. Will update this thanks!

👋 As you are changing the id of the list, please can you also update the legacy ID mapping so that this doesn't break folks ability to use this list

Alright I believe I have updated this. Not sure if you wanted me to remove the old domains or not as they still work just redirect to our new one so I just left them in place.

You need to add an entry in https://github.com/botblock/data/blob/master/data/legacy.json to represent the renaming you are doing, and update any existing values of the id you are changing.

I did make a pr for that file just forgot to push it. Should be a separate PR for changes to it!

You need to make it as a single PR, it will not pass tests as a separate PR.

You need to make it as a single PR, it will not pass tests as a separate PR.

I was wondering if that’s why it was failing. Let me close these and I’ll make a new one!


Informing the project of the combinations of metric-subsector we expect from the TEMPO data

Canceling this PR -- it's not showing up as cleanly as it should.

@elainethale The issue is that Arthur’s branch is not up-to-date with main. I think we need to merge main into ahcyip-patch-2 and then branch off of it.


perhaps treat file paths in CLI options as relative IRIs?

I stumbled upon #135 which reminded me of XDG specs consistently talking about URIs, never file paths.
How about doing similar for rudof: internally pass around only IRIs (i.e. technically Oxiri objects/structs, I guess), and only close to the UI surface of the CLI tool translate those from/to file paths. That is, advertise data-related options as accepting IRIs, using file:// as default scheme, and (if required) using current working directory as default base IRI.
On a related note, Oxiri v0.2.5 introduced handling relative IRIs.

Yes, I was playing with that possibility in my recent work on adding support for imports which require the use of relative URIs and I think it is doable.
In fact, I noticed that there are like two different things to consider: Urls and File Paths, and that sometimes we need to jump from one to the other.
In our representation of InputSpec we created a union of three things: Paths, stdin and Urls which act as input specification and we convert them to IRIs in order to provide an IRI that represents the source of a ShEx schema which can act as it's base when importing another schema.
I keep this issue open because that work is not yet finished, but I think it goes in that direction.


[Snackbar] classes root override not working correctly

When using the classes root override in the Snackbar component, it adds a wrapping div with your the css classes you define instead of overriding the root containers properties.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Change the style of the snackbar components root element
Current Behavior
Adds a parent div to the snackbar components root element
Steps to Reproduce (for bugs)
Here is an example I added padding to it so you can actually see what it does, if you remove the padding you will not see the changes: https://codesandbox.io/s/03l5x9klwn
Context
I'm trying to change the styling of the Snackbar component
Your Environment

Tech
Version

Material-UI
1.0.0-beta.13

React
15.5.3

browser
Chrome Version 61.0.3163.10

It's the SnackbarContent component classes that you want to change, not the Snackbar one. You can either provide your own children or use the SnackbarContentProps property.


Property 'refresh' does not exist on type 'Map'

Describe the bug
The OlMap component exposes a refresh function that calls a refresh method on the map instance. However, I don't  seem to find such a method on the ol.Map class.
Affected version(s)
Please run npm list --depth=0 vue vue3-openlayers ol ol-ext ol-contextmenu and paste the output below:
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

To Reproduce
Steps to reproduce the behavior:
Simply install the project locally and inspect the OlMap component in the IDE of your choice. TypeScript should be complaining.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. macOS]
Browser [e.g. chrome, safari]

Smartphone (please complete the following information):

Device: [e.g. iPhone 14]
OS: [e.g. iOS 16.15.1]
Browser [e.g. chrome, safari]

Additional context
Add any other context about the problem here.

Ah, I just realized this is just to make it backwards compatible with older ol versions, nevermind. Maybe this could be briefly added to the "Get started" section in the docs? Since there, it says that ^7.4.0 is required.

Thanks for reporting @chrstnbwnkl . Indeed it was simply not removed in this lib.
I removed this methods and other methodas and props that aren't compatible with OpenLayers 7.x.x.
See 81c6d00.


Use only one of the optimizers as warm-up

What is your question?
Hi! I am trying to train a GAN and I would like to train only the Discriminator for the first x steps, how can that be done?
I've seen the code for step optimizers at arbitrary intervals but it is not clear to me how it works (it says update generator every 2 steps and discriminator every 4, but then do they cumulate the gradients until they update or what happens in the odd steps? Why are they cumulating gradients then?) so I ended up using the frequency in the dictionary returned in the configure_optimizers functions which gives the behaviour I wanted of train x times optimizer A, train Y times optimizer B. Now I am looking to do for the first S steps only train optimizer A, then train x times A, train Y times B.
What's your environment?

OS: Win
Packaging: conda
Version: 0.7.6rc2

In the training_step function you have access to the bath iteration number(batch_nb), you can ignore the back prop step for generator for first n iterations
Usually batch size while training the GAN's is less(because of size and multiple backward functions) so to eliminate the noisy updates, gradients are accumulated for some mini batches before the optimizer steps

thanks for the reply, how do I ignore the backprop step though?

You can override the optimizer step like so
def optimizer_step(self, current_epoch, batch_nb, optimizer, optimizer_i, second_order_closure=None):
        if optimizer_i == 0:
            optimizer.step()
            optimizer.zero_grad()

Notice you can have any kind of condition to trigger the optimizer step.


Seamless integration of Contiv with CNFs

Coverage decreased (-0.6%) to 68.876% when pulling 56fe5cfef9127f2635f40ec4c5da2154954306f4 on milanlenco:cnf into 471aefde1fcee6e731810c8515b091277c1b29bf on contiv:cnf.


Pages before the page "push" need not be drawn

Version
Tell us which versions you are using:

react-native-router-flux v4.0.0-beta.27
react-native v0.51.0

Expected behaviour
Push three pages like Navigator and then look at the layout on the Xcode

I think the page before the current page should not be drawn out, so it will consume unnecessary memory, I hope to improve, thank you.
Actual behaviour
After using react-native-router-flux to push three pages, look at the layout on the Xcode

This will cause an increase in memory, which may cause app to crash.

Please try to reproduce it with Example project and latest version 4.0.0-beta.40. Feel free to open if the issue still exists


Moved tests into child folders Unit and Integration

Moved Unit tests into the child folder Unit
Updated moved *.Tests.ps1 to find and load the resource modules again.
Moved MSFT_xWebBindingInformation.Tests.ps1 into the Integration child folder because it creates a temporary configuration and uses the LCM to config a "foobar" web site. I would classify this test behavior as integration not unit.
Simplified how the tests reference the resource module names and paths.

So this actually fails in my lab, running WMF 4.0 (I believe AppVeyor is running WMF 5.0 but someone would need to correct me if I'm wrong there).
Currently it fails with this error:
Describing Schema Validation MSFT_xWebsite
 [-] should pass Test-xDscResource 82ms
   Cannot bind argument to parameter 'Name' because it is an empty string.
   at line: 20 in D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebsite.Tests.ps1
Join-Path : Cannot bind argument to parameter 'Path' because it is null.
At D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebsite.Tests.ps1:26 char:13
+             Join-Path -ChildPath "$($DSCResource.Name).schema.mof" -Resolve
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Join-Path], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.JoinPathCommand

 [-] should pass Test-xDscSchema 16ms
   Cannot bind argument to parameter 'Path' because it is an empty string.
   at line: 27 in D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebsite.Tests.ps1
[-] Error occurred in test script 'D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebsite.Tests.ps1' 30ms
  Cannot bind argument to parameter 'Name' because it is null.
  at <ScriptBlock>, D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebsite.Tests.ps1: line 34
Describing Schema Validation MSFT_xWebVirtualDirectory
 [-] should pass Test-xDscResource 77ms
   Cannot bind argument to parameter 'Name' because it is an empty string.
   at line: 19 in D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebVirtualDirectory.tests.ps1
Join-Path : Cannot bind argument to parameter 'Path' because it is null.
At D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebVirtualDirectory.tests.ps1:25 char:13
+             Join-Path -ChildPath "$($DSCResource.Name).schema.mof" -Resolve
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Join-Path], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.JoinPathCommand

 [-] should pass Test-xDscSchema 16ms
   Cannot bind argument to parameter 'Path' because it is an empty string.
   at line: 26 in D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebVirtualDirectory.tests.ps1
[-] Error occurred in test script 'D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebVirtualDirectory.tests.ps1' 30ms
  Cannot bind argument to parameter 'Name' because it is null.
  at <ScriptBlock>, D:\GitHub\tysonjhayes\Deploy\xWebAdministration\tests\Unit\MSFT_xWebVirtualDirectory.tests.ps1: line 33
Tests completed in 253ms
Passed: 0 Failed: 6 Skipped: 0 Pending: 0

Breaking into the debugger I'm finding that $DSCResource is null, specifically $PSScriptRoot.  I believe I've run into this before which is why I coded in the $here variable (which in hindsight was nomenclature picked up from Pester but is a terribly named variable name).
Also Piping is inherantly slower to process and where you are using isn't gaining us anything. I would suggest not using the pipe and just calling the variables on the correct parameter.

Thanks for the PR! I look forward to working with you on getting these changes in.

Thanks for the feedback. I will fix it and update the PR.

I think I have managed fixed the errors I introduced on WMF v4 and incorporate your suggestion to not use the pipeline. Please be so kind to test again in your lab.

Changes look good, waiting on tyson to confirm it works on WMF 4 to merge

Works great. Thanks @Dan1el42!


Multiple backend directories not generally usable

In the configuration of your backend directory (for example using neovim) if you provide multiple directories the LSP will only function if all of the directories exist. If for example you specify:
backend = { './src_one', './src_two' }

If one of those directories does not exist, nothing works. If working on projects that are structured differently you cannot set a global backend value that will work with both.  Given the setting I was expecting that the LSP would look into the specified directory if it is found, otherwise if the directory does not exist ignore it, as opposed to requiring all directories to exist.

Yeah true. I was thinking about moving configuration to: pyproject.toml, cargo.toml, jinja-lsp.toml.


[forge] Add livessness check for Forge node json-rpc endpoint

Add livessness check for Forge node json-rpc endpoint availability
for multi-nodes, json-rpc endpoints need time to get available otherwise test will failed if we start testing directly
running 5 tests
Wait for startup attempt: 0 of 10
Wait for startup attempt: 1 of 10
Wait for connectivity attempt: 0
Wait for connectivity attempt: 1
Wait for connectivity attempt: 2
Wait for connectivity attempt: 3
Wait for connectivity attempt: 4
Wait for connectivity attempt: 5
Wait for connectivity attempt: 6
test fund_account ... FAILED
Error: Timeout
test transfer_coins ... ok
test get_metadata ... ok

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
with 5 nodes in local swarm
run ./script/fgi --local-swarm
running 5 tests
Wait for startup attempt: 0 of 10
Wait for startup attempt: 1 of 10
Wait for connectivity attempt: 0
Wait for connectivity attempt: 1
Wait for connectivity attempt: 2
Wait for connectivity attempt: 3
Wait for connectivity attempt: 4
Wait for connectivity attempt: 5
Wait for connectivity attempt: 6
Wait for liveness attempt: 0
Wait for liveness attempt: 1
test fund_account ... ok
test transfer_coins ... ok
test get_metadata ... ok

Related PRs
(If this PR adds or changes functionality, please take some time to update or suggest changes to the docs at https://developers.diem.com, and link to your PR here.)
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

hmm I don't seem to see the same issue locally (I did add a json-rpc health check to the health check function recently though) so maybe a rebase would have solved this issue?

hmm I don't seem to see the same issue locally (I did add a json-rpc health check to the health check function recently though) so maybe a rebase would have solved this issue?

yea, I did a rebase with the latest change it still happens with 10nodes(5 nodes seems ok)
Wait for connectivity attempt: 6
test fund_account ... FAILED
Error: Timeout

/land

@zihaoccc :bulb: This PR is already queued for landing

:broken_heart: Test Failed - ci-test