duplicate content at beginning of each module in /lib

Just looking at the code in /lib for the latest commit:

https://github.com/hailocab/react-pure/blob/62b15682a5a467b0e59ad6241d2fe1a7b6b83043/lib/Button.js
https://github.com/hailocab/react-pure/blob/62b15682a5a467b0e59ad6241d2fe1a7b6b83043/lib/Cell.js
etc...

I've noticed that the following 3 variables seem to be defined in most of the module files:
var _interopRequire = function (obj) { return obj && obj.__esModule ? obj["default"] : obj; };

var _objectWithoutProperties = function (obj, keys) { var target = {}; for (var i in obj) { if (keys.indexOf(i) >= 0) continue; if (!Object.prototype.hasOwnProperty.call(obj, i)) continue; target[i] = obj[i]; } return target; };

var _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };

I'm guessing this is coming from Babel somewhere, because I can see your require(...) calls as expected.
Is there a Babel setting to have these helper functions modularised and de-duplicated? I'm using Browserify, and it's possible that these duplicates will waste some space in my build output. Every byte counts. :)
I just had a quick glance at Babel and I can't see where these declarations are coming from (although their unit tests expect them).

It's possible (see https://babeljs.io/docs/usage/external-helpers/), but I don't think it's a good idea in our case, as it would force users of the library to include Babel helpers themselves.
If you really want them out, I think the best option is to load the source files from your application and compile them along with your application.

Yeah, I've had a play with this and I can't figure out how to tell Babel to stop putting them in, let alone how to compensate for them being in a separate file. This seems like something Babel should be doing for us.
I tried
babel --no-external-helpers

and the output is the same regardless.
I'm sure GZIP compression eliminates the extra duplicates in transit anyhow.
That said, even this small tailored set of helpers is a going to be unnecessary parsing and execution, even if they don't bloat the GZIPed download too much. They are 584 bytes which ends up being a huge chunk of each module.

Button: total bytes = 1963, helpers = 30%
Cell: total bytes = 1791, helpers = 33%
Menu: total bytes = 2322, helpers = 25%
Table: total bytes = 1694, helpers = 34%

I'm going to report this upstream.

See the runtime optional transformer.

Sorry I forgot about this issue, is that solved for you @jokeyrhyme or is there something I can implement in the lib without breaking things?

Actually, I've just started using Babel myself, so I can avoid this issue in my own projects by just directly requiring the src/ files. If they can be added npm package, that's probably enough for me for now.

OK, I just published v0.2.2 that includes the src folder, please let me know if that works for you.

Hi, thanks for publishing that change.
I'm using browserify with the babelify transform. Babelify won't recursively transform dependencies in node_modules unless they themselves specify that this is likely to work.
So, if you could be so kind, it would be terrific if you could add the following to the top-level of your package.json:
  "browserify": {
    "transform": [
      [
        "babelify", {
          "experimental": true
        }
      ]
    ]
  }

The other thing I noted is that you are using Babel's experimental transforms, specifically it looks like the Object Spread feature.
According to Babel's experimental notice:

These proposals are subject to change so use with extreme caution. babel may update without warning in order to track spec changes. Please do not use them in production applications.

The neat thing is that your package.json can enable experimental mode just for your module, and my project can disable experimental mode. Babelify just turns it on when it encounters your module.
If you do end up dropping experimental mode (i.e. when Object Spread graduates to a specification), then it might be a good idea to remove the line from that JSON snippet.

Hi,
I don't think it's the proper way forward, as it forces the users of the lib to apply the browserify/babelify transform themselves.
I just had a quick look at the Babel runtime transformer, isn't it possible to use it in your app build to extract the duplicate declarations?
About the experimental flag, yes it's only used for Object spread, once it's included by default in Babel it would be removed from the lib.

I just published v0.2.3 using babel-runtime, I think it's the best option to avoid duplicate declarations without needing specific transforms outside the library, does that work for you?

Adding the package.json stuff doesn't force anyone to do anything, unless they want to avoid the duplication by using the ES6 source files you provide. If they don't care about the duplication, then they don't have to do anything differently.
With v0.2.2 and the custom package.json inserted:
ls -la www/*.min.js
-rw-r--r-- 1 ron ron 268450 Mar 19 08:23 www/app.min.js
-rw-r--r-- 1 ron ron   1198 Mar 19 08:23 www/loader.min.js

After updating to v0.2.3, replaced require('react-pure/src/Button') with require('react-pure/lib/Button'), and doing nothing else (I'm not using the transform, as my code doesn't directly use the helpers):
-rw-r--r-- 1 ron ron 294888 Mar 19 08:24 www/app.min.js
-rw-r--r-- 1 ron ron   1198 Mar 19 08:24 www/loader.min.js

I did try this with the transform, and it isn't any different in size.
Oddly enough, with v0.2.2 and using "lib" instead of "src", with no transforms, I get the same sizes when using "src" with no transforms. Simply enabling the transforms (either in your library or in my project) seems to add nearly 30KB to the output size.
My project only uses Button, Menu and MenuItem, and the output include the React library and everything else your library and my project require.
I'm curious to know what these numbers are like for your projects that use react-pure.
Let's be scientific about this. :) I'm willing to accept that my original hypothesis about the duplication was completely wrong, or at least not worse than the alternatives.

I've never used browserify this way so I can't tell, but reading the documentation on browser.transform in package.json it seems to me the transforms are applied whatever the require(), I don't see any option to transform the files from src but not lib?
About the size of your minified files, I really think it's out of the scope of this lib.
Sure, there is some overhead using Babel, but to me it's really worth the added convenience.

About the size of your minified files, I really think it's out of the scope of this lib.
I agree. You should just do whatever makes it easier to maintain this project. I suspect this is something that will be addressed upstream and within the ecosystem.

I don't see any option to transform the files from src but not lib?
Just directly require()ing the src files was working for me:

var Button = require('react-pure/src/Button');

@sebmck Now that it has all gone 404, what do we do to get rid of these duplicate helpers?

Alright, so the --external-helpers option still works, but it only replaces the calls and doesn't import anything. For example, I'm running
babel src --source-maps --external-helpers --out-dir . --modules common

and that results in files that look like this at the top:
'use strict';

Object.defineProperty(exports, '__esModule', {
  value: true
});

var _lowclass = require('lowclass');

var _lowclass2 = babelHelpers.interopRequireDefault(_lowclass);

var _Node = require('./Node');

var _Node2 = babelHelpers.interopRequireDefault(_Node);

var _utilitiesPrivates = require('../utilities/Privates');

var _utilitiesPrivates2 = babelHelpers.interopRequireDefault(_utilitiesPrivates);

var __ = new _utilitiesPrivates2['default']();

Note that these files don't require('babel-runtime') or anything like that, so, these files will error out when we try to run them. This is a library that I'm compiling, and it has no entry point. This means that I will have to tell my users to manually import babel-runtime (or whichever package it is), which I'd love to avoid doing.
Is there a way to make Babel add the import to each file, or something?

Use the babel-plugin-external-helpers-2 plugin. Someone was squatting on the other one :/
On Thu, Oct 29, 2015 at 8:40 PM, Joseph Orbegoso Pea
<EMAIL_ADDRESS>wrote:

Alright, so the --external-helpers option still works, but it only replaces the calls and doesn't import anything. For example, I'm running
babel src --source-maps --external-helpers --out-dir . --modules common

and that results in files that look like this at the top:
'use strict';
Object.defineProperty(exports, '__esModule', {
  value: true
});
var _lowclass = require('lowclass');
var _lowclass2 = babelHelpers.interopRequireDefault(_lowclass);
var _Node = require('./Node');
var _Node2 = babelHelpers.interopRequireDefault(_Node);
var _utilitiesPrivates = require('../utilities/Privates');
var _utilitiesPrivates2 = babelHelpers.interopRequireDefault(_utilitiesPrivates);
var __ = new _utilitiesPrivates2['default']();

Note that these files don't require('babel-runtime') or anything like that, so, these files will error out when we try to run them. This is a library that I'm compiling, and it has no entry point. This means that I will have to tell my users to manually import babel-runtime (or whichever package it is), which I'd love to avoid doing.
Is there a way to make Babel add the import to each file, or something?
Reply to this email directly or view it on GitHub:
https://github.com/hailocab/react-pure/issues/2#issuecomment-152312634

@sebmck Did you know you can email NPM support, and if you present a valid case, they can help you get ownership to it.

@sebmck I gave it a shot, and it errored out:
> npm install babel-plugin-external-helpers-2 --save
npm WARN install Couldn't install optional dependency: Unsupported
<EMAIL_ADDRESS>/home/trusktr/src/infamous+motor
`--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>

> ./node_modules/.bin/babel src --source-maps --plugins external-helpers --out-dir . --modules common
ReferenceError: Unknown plugin "external-helpers"
    at PluginManager.subnormaliseString (/home/trusktr/src/infamous+motor/node_modules/babel-core/lib/transformation/file/plugin-manager.js:147:13)
    at PluginManager.add (/home/trusktr/src/infamous+motor/node_modules/babel-core/lib/transformation/file/plugin-manager.js:190:40)
    at File.buildTransformers (/home/trusktr/src/infamous+motor/node_modules/babel-core/lib/transformation/file/index.js:237:21)
    at new File (/home/trusktr/src/infamous+motor/node_modules/babel-core/lib/transformation/file/index.js:139:10)
    at Pipeline.transform (/home/trusktr/src/infamous+motor/node_modules/babel-core/lib/transformation/pipeline.js:164:16)
    at Object.exports.transform (/home/trusktr/src/infamous+motor/node_modules/babel/lib/babel/util.js:40:22)
    at Object.exports.compile (/home/trusktr/src/infamous+motor/node_modules/babel/lib/babel/util.js:49:20)
    at write (/home/trusktr/src/infamous+motor/node_modules/babel/lib/babel/dir.js:19:21)
    at handleFile (/home/trusktr/src/infamous+motor/node_modules/babel/lib/babel/dir.js:40:7)
    at /home/trusktr/src/infamous+motor/node_modules/babel/lib/babel/dir.js:56:9

Running ack '\bexternal-helpers\b' in node_modules doesn't reveal any indication that the plugin name "external-helpers" is defined anywhere: http://trusktr.io:7777/akudoqoxit


Make semester observable

What this does
This PR makes several properties of the Semester class observable. This allows it to update the UI automatically, after running the archive command.

Fixes #164.
How to test

Launch the application.
Run archive.
The semester should update.

Notes

Codecov Report

Merging #166 into master will decrease coverage by 0.23%.
The diff coverage is 68.08%.

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
- Coverage     63.75%   63.52%   -0.24%
+ Complexity      932      926       -6
============================================
  Files           155      155
  Lines          3383     3356      -27
  Branches        428      421       -7
============================================
- Hits           2157     2132      -25
- Misses         1078     1086       +8
+ Partials        148      138      -10

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/resireg/model/Model.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

.../java/seedu/resireg/model/util/SampleDataUtil.java
10.71% <0.00%> (+0.71%)
1.00 <0.00> (ø)

...java/seedu/resireg/storage/JsonResiRegStorage.java
66.66% <0.00%> (-5.34%)
8.00 <0.00> (ø)

...rc/main/java/seedu/resireg/ui/SemesterDisplay.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...in/java/seedu/resireg/model/semester/Semester.java
72.72% <86.36%> (+0.72%)
15.00 <10.00> (ø)

...a/seedu/resireg/logic/commands/ArchiveCommand.java
100.00% <100.00%> (ø)
3.00 <0.00> (ø)

...rc/main/java/seedu/resireg/model/ModelManager.java
77.90% <100.00%> (+0.49%)
51.00 <1.00> (+1.00)

src/main/java/seedu/resireg/model/ResiReg.java
74.40% <100.00%> (ø)
34.00 <1.00> (ø)

...ava/seedu/resireg/storage/JsonAdaptedSemester.java
100.00% <100.00%> (+30.30%)
5.00 <1.00> (+1.00)

...ireg/model/semester/academicyear/AcademicYear.java
20.00% <0.00%> (-40.00%)
4.00% <0.00%> (-4.00%)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71fb480...28fd611. Read the comment docs.


Encourage small changeset area and meaningful changeset names

Here's an example "to-fix" changeset:
http://www.openstreetmap.org/changeset/24436746
The description, "http://osmlab.github.io/to-fix/?error=keepright/nonclosedways" is not especially meaningful.  What can be done to encourage mappers to use meaningful changeset names?
Similarly, the area of that is essentially worldwide - it's not easy to see what's changed and where.

I secfond that. That same problem exists with lots of other useful tools too so a wider effort is needed imho.

Each task requires a changeset comment that can be copy-pasted by a reviewer.

Closing.


*: add theme based frontend configuration

This PR reworks the web layout so static files can be provided and
a "themes" directory to allow a certain degree of control over logos,
styles, etc.
This PR does NOT add general support for frontend customization,
only enough to allow us to start exploring theming internally.
The dex binary also must now be run from the root directory since
templates are no longer "compiled into" the binary.
The docker image has been updated with frontend assets.

cc @rithujohn191 @amrutac
Tested the docker image with:
make docker-image
sudo docker run -p 5556:5556 -d \
    -v $PWD/examples/config-dev.yaml:/examples/config-dev.yaml |
    quay.io/coreos/dex:$( ./scripts/git-version ) |
    serve /examples/config-dev.yaml
./bin/example-app

per irl conversation with @amrutac we're going to punt on the fav icon. @rithujohn191 want to take a quick look?

👍


Make Gradle script support Flutter-as-lib

For add2app scenarios, we want to include Flutter as a library module, not a stand-alone app. To make this work with Gradle, we need to

Refer to android/local.properties and .flutter_plugins relative to the Flutter sub-project, not relative to the root project of the host app (which could be located anywhere).
Re-export flutter.jar from the Flutter module so that it is available to the host app. This means the Gradle dependency from the module to flutter.jar must be api, not implementation.

These changes are partly tested through current workflow and their tests. The extra capabilities they enable will be tested along with the Flutter module template that we'll be introducing in a separate PR.

Some suggestion for wiki Add-Flutter-to-existing-apps, add a full Android/iOS native + flutter_module examples.
For Android java project.
// Extends FragmentActivity, all plugins defined in pubspec.yaml not loading without register, but there's not doc about that.
// Extends FlutterFragmentActivity, I can't get back to my previous native page with back key pressed.
public class FlutterStarter extends FlutterFragmentActivity {
    private FlutterView fView = null;

    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        Intent i = getIntent();
        String arg = i.getStringExtra("arg");
        Log.i("FlutterStart", "arg:" + arg);

        fView = Flutter.createView(
                this,
                getLifecycle(),
                arg
        );

        FrameLayout.LayoutParams layout = new FrameLayout.LayoutParams(-1, -1);
        //layout.leftMargin = 100;
        //layout.topMargin = 200;
        addContentView(fView, layout);
    }

    @Override
    protected void onDestroy() {
        super.onDestroy();
        fView.detach();
    }
}


(1139b) Draft referral progress

Context
We need to display how many tasks have been completed for a draft referral in the draft referrals case list table.
Changes in this PR

Adds new method to ReferralService to calculate how many of the required fields on a referral have truthy values.
Above method called in ReferCaseListController.show to return a tasksCompleted value that we can use in the table template.

Release checklist
Release process documentation
As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.
Pre-merge

[ ] There are changes required to the Accredited Programmes API for this change to work...

[ ] ... and they have been released to production already

Post-merge

[ ] This adds, extends or meaningfully modifies a feature...

[ ] ... and I have written or updated an end-to-end test for the happy path in the Accredited Programmes E2E repo

[ ] This makes new expectations of the API...

[ ] ... and I have notified the API developer(s) of changes to the contract tests (Pact), or the API is already compliant

[ ] Manually approve release to preprod
[ ] Manually approve release to prod

@Gweaton @jsrobertson the need to make an extra call to the API per referral is making me think this should really be provided by the API in the ReferralSummary. An extra API 15 calls per case list page seems substantial  - thoughts?

@Gweaton @jsrobertson the need to make an extra call to the API per referral is making me think this should really be provided by the API in the ReferralSummary. An extra up to 15 API calls per case list page seems substantial - thoughts?

Yeah I did wonder about this, it doesn't feel ideal when we have this smaller referralSummary object... We might need to rethink this.

@Gweaton @jsrobertson the need to make an extra call to the API per referral is making me think this should really be provided by the API in the ReferralSummary. An extra up to 15 API calls per case list page seems substantial - thoughts?

Yeah, I don't disagree to be fair but would be interesting to know how big these lists are likely to get and if it really is a issue in the grand scheme of things.


How to use on localhost?

I can't seem to get this thing working with localhost. I've created a collection of 'pages' and installed Cockpit as a project on localhost using MAMP, and would like to access the API on http://localhost/cockpit/api/pages/get/posts?token=jk234h24k2jh42k4j4h2k4jh (using a generated token).
But all I get is:
Path not found.

Now, what does 'Path' mean in this context? Am I supposed to point to my collection called 'pages' or?
If I do this:
`http://localhost/cockpit/api/collections/pages/get/posts?token=jk234h24k2jh42k4j4h2k4jh`

I get this error:
SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

Which is basically the same as the above, just in a JSON format.

Well, never mind. Totally missed the link in the docs, sigh!


Bump Istio to 1.3.1

https://github.com/istio/istio/releases/tag/1.3.1

rancher/rancher:master-head 343a56707

Deploy Rancher
Create cluster
Enable Istio
Istio workloads are all using 1.3.1 version of images
Executed Istio test plan w/ no failures


Extend Credential structure with Password Safe field

Extend Credential structure with Password Safe field
Add GetCredential command
Allow additional fields in Register command
New tags for the PWS fields
New OTP kind to signalize OTP being unused in the given Credential, without changing the data structure
Remarks:

This change is backwards-compatible with the previous user data, and do not need data migration.
Data created with firmware using this application may block working of the older version (e.g. if user moved to test firmware, and want to get back to stable firmware). Reset procedure should be able to recover all features though.

Fixes https://github.com/Nitrokey/trussed-secrets-app/issues/60

Thank you for the review!

I was considering dividing this into different types as well, but it does not make much sense. Keeping PWS and OTP slots separate will be cumbersome from the user POV, while having them both seems quite handy - see KeepassXC design. What is missing here is an update/modify command, which would allow to add and remove PWS and OTP data to the Credential structure. See, that with this PR it will be allowed to create an "empty" Credential as well.
Another thing is extending the data structure vs reforming it. Since the Secrets App is nearly feature-complete, it does little sense to me to provoke data migrations at this point, as this code will be never touched again, except for any potential logic errors. Extending the structure looks like a natural choice from this perspective (it was the whole point in using CBOR in the first place anyway).

We should talk about if we want to try to avoid this. For example, we could add a version number and just ignore data that we don’t understand. Not sure if it is worth the effort.

I do not see a point in tracking this since downgrades in stables are forbidden. This particular note is rather for the users of the test firmware, which could find some of their newly created credentials not working, if "downgraded" to the last stable.
In this case incompatibility comes from the newly introduced OTP slot type, marking being unused, which would probably make deserialization errors on use.

Just to be clear, I’m only talking about the data structures in the code, not the serialization format.  It could still make sense to move the fields into structs that are flattened during the serialization, e. g.:
pub struct Credential<'l> {
    pub label: &'l [u8],
    pub touch_required: bool,
    pub encryption_key_type: EncryptionKeyType,
    pub counter: Option<u32>,
    pub otp: Option<OtpCredentialData<'l>>,
    pub static: Option<StaticCredentialData<'l>>,
}

pub struct OtpCredentialData<'l> {
    pub kind: oath::Kind,
    pub algorithm: oath::Algorithm,
    pub digits: u8,
    pub secret: &'l [u8],
}

pub struct StaticCredentialData<'l> {
    pub login: &'l [u8],
    pub password: &'l [u8],
    pub metadata: &'l [u8],
}

My concern is that code with implicit invariants, e. g. if kind: Option<Kind> is Some(_), then algorithm: Option<Algorithm> must also be Some(_), is often hard to read and maintain compared to more explicit code like combining these two variables into a tuple or struct with a single Option.  In this case it probably does not make a big difference though.

This particular note is rather for the users of the test firmware, which could find some of their newly created credentials not working, if "downgraded" to the last stable.

That’s totally fine.  My understanding was that adding a credential with the test firmware might block the user from accessing other credentials using the stable firmware.  While this would also be okay, I’d rather try to avoid such situations if possible.

Ah, I missed lifetimes and confused it with the serialized data type indeed. In that case I agree, it would be nice to keep the clean types planes in the commands and function handling them.
Since this looks like a bigger refactorization, can we do that in a separate PR?

I think we also need a way to query the credential metadata (without the secrets) that does not require a button press. For the nitrokey-app2, we want to first determine the type of the credential (static password? OTP, if yes, which algorithm?), and then provide the appropriate actions to the user.

I believe the list command already returns type of the Credential. See the associated pynitrokey's PR. It does not require button press (outdated Secrets App?).
Note: this feedback should not be a PR rejection, but feature-request in a separate ticket (please write user scenario there, which will be used for the design update).

Ah, I missed that because it is only returned as bytes in pynitrokey.  But as far as I see, it only contains the OTP type and no information about the static password, right?  I can create a separate issue for that if you prefer.

But as far as I see, it only contains the OTP type and no information about the static password, right?

It might be possible it is listing only one type right now, even if there are multiple types specified. To check.

I can create a separate issue for that if you prefer.

Please do


Add variable to specify additional, read-only states to which the role should also be granted access

🗣 Description
This pull request adds a role variable to specify additional, read-only states to which the role should also be granted access.
💭 Motivation and context
This is required to grant some assessors sufficient access to redeploy their own instances.  See cisagov/cool-assessment-terraform#250.
🧪 Testing
All automated tests pass.  This change was tested as part of cisagov/cool-assessment-terraform#250.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] All new and existing tests pass.

This role is kindof a mess now that I have made all these changes.  I was thinking of creating an issue to come back and clean it up a bit by providing input variables that allow the user to specify both a list of read-only and a list of read-write states.  Then a single role is created that allows appropriate access to the specified states.  @cisagov/vm-dev - any other thoughts as to how this role can be improved and/or made simpler?

This role is kind of a mess now that I have made all these changes. I was thinking of creating an issue to come back and clean it up a bit by providing input variables that allow the user to specify both a list of read-only and a list of read-write states. Then a single role is created that allows appropriate access to the specified states. @cisagov/vm-dev - any other thoughts as to how this role can be improved and/or made simpler?

I support this idea.

This role is kind of a mess now that I have made all these changes. I was thinking of creating an issue to come back and clean it up a bit by providing input variables that allow the user to specify both a list of read-only and a list of read-write states. Then a single role is created that allows appropriate access to the specified states.

See #41.


Replace BytesLikeAttribute usage with IBufferProtocol in builtins

There is no reduction in data copy with this change, just not using [BytesLike] in Builtin. The encoding detection and parsing machinery requires a ContentProvider, with an underlying Stream so to use MemoryStream as Stream, data in a regular .NET byte array is needed.
However, it is possible to avoid data copying by replacing MemoryStream with a different implementation of a Stream that uses IPythonBuffer as the backing store. As an exercise I implemented that approach too, which is now available at commit 446e741bb973220bf1f3ac7f58e27168015826f4. In the end, however, I thought that such approach would be an overkill: it introduces two new classes PythonBufferStream and BufferProtocolContentProvider just for the sake of avoiding a data copy for some non-typical (I assume) usages of eval, exec, and compile (I assume the typical bytes-like argument would be bytes or System.Array[System.Byte]). So probably not worth the extra complexity. In any case, it is there, if the solution in this PR is not acceptable.

I have checked importlib and noticed that it decodes sourced modules to str first (using the required PEP-263 rules) before passing them over to compile. So apparently the IBufferProtocol overload is not being used by importlib, unless we start hacking it.
But another place where MemoryStreamContentProvider is being used is zipimport. There, however, all data manipulation is done on regular byte[] arrays (for both compressed and decompressed data), so MemoryStream is perfectly fine. In other words, I do not see any additional benefits for PythonBufferStream anywhere else at this time. I will be going to merge this PR as is.


Automod Capabilities

Howdy! On a server I moderate in, we've been trying to setup Vortex and came across a small thing that could be added that would make Vortex sublime: Automod capabilities to pardon after a set time period. The team I work with have to rely upon Dyno for this and it's kinda inconvenient considering Vortex does everything else, and does it much better. Please consider adding this feature to Vortex.

Willersmunk

This probably won't be added; the concept of strikes is to keep a permanent record of infractions. Also, having strikes doesn't have any negative impacts to a user, only receiving new strikes does, so even if a user already has strikes, they won't see any negative effects unless they break a rule again. Vortex is primarily designed such that pardoning strikes is unnecessary except when strikes are given accidentally, or for false-positive moderation. I would recommend changing your server's punishments if you want each strike to be less impactful. For example, instead of:
2 - Mute 10m
3 - Kick
4 - Ban

You could do something like
2 - Mute 5m
3 - Mute 10m
4 - Mute 2h
5 - Mute 1d
6 - Ban 1d
7 - Ban 2d
8 - Ban 7d
9 - Ban

which would enable users to get more strikes over time but still have increasingly worse punishments. If this doesn't suit your needs, then my best advice would be to seek out a bot that is geared towards temporary strikes instead of permanent ones.

Sorry, I just saw your response. Thanks for commenting, I'll speak with my team and see what we can do. I definitely understand, after reading, how Vortex is meant to be used and will keep that in mind for the future.
Again, big thanks


Slow SFTP transfer rate since 0.12.1

I'm trying to use restic to backup ~3TB of data to another system using SFTP over a gigabit network connection.
I've set RESTIC_REPOSITORY and RESTIC_PASSWORT environment variables and used the following commands:
restic init
restic backup /mnt/disk
When I tried the latest release (0.15.1), I immediately noticed the slow transfer speed of around 10 MB/s. The cpu load was 60% idle most of the time.
First I tried a lot of different options:

Disable backup progress estimation (--no-scan)
Increasing backend connections (-o sftp.connections=10)
Disable compression (--compression off)
Increasing file read concurrency (--read-concurrency 8)
Increasing pack size (--pack-size 64)
None of these parameters did change anything.

Next I tried an older version from the Debian repository (0.11.0).
Just using this version caused my cpu to get maxed out and I reached about 60-70 MB/s transfer rate.
Then I tried every release from 0.11.0 to 0.15.1 and starting with 0.12.1 every version afterwards shows this issue.
I guess it must have something to do with a change that happened in 0.12.1.
It does only happen with SFTP repositories. A backup to a local repository is not affected.
I've also tried to init the repository with 0.12.0 (repository format version 1) and then doing the backup with the latest release. Also slow transfer.
Any ideas?

The main change in 0.12.0 regarding SFTP performance is #3211. Could be that that inferes with something in your setup.

I can confirm that the issue is #3331.
I did a build from revision e678aca, where the new SFTP library was added. With this build I get the reduced speed.
Then I got a revision before that (c9b4fad). With that build the transfer rate is a lot higher.

Judging from the release notes of pkg/sftp version 1.13.0 this change is the culprit:

[https://github.com/pkg/sftp/pull/397] Refactoring and performance improvements, implement WriterAt interface. Concurrent writes are not longer enabled by default for safety reasons. You can use the option UseConcurrentWrites if it's needed for your use case.

The description of UseConcurrentWrites sounds like it should be safe to use, as we completely retry the upload if there is an error while writing a file. Anyone up for a PR?

@DeadWalkingDeath I'd spell it
client, err := sftp.NewClientPipe(rd, wr, sftp.UseConcurrentWrites(true))

but yes, that should be it. UseConcurrentWrites actually only takes effect when using ReadFrom instead of Write, but it looks like the restic SFTP backend is already doing that...

does this maybe help?
git checkout https://github.com/pkg/sftp.git
cd sftp

create test.sh with this content
start=`date +%s` && go run examples/buffered-write-benchmark/main.go -user test -pass 123 && t=$((`date +%s` - $start)) && test $t -lt 7

remove host, user and pass to use localhost and maybe change the 7 to the seconds that works on your system
and now let bisect do the job
root@91b2acc00772:/go/sftp# git bisect start HEAD v1.10.0
Bisecting: 220 revisions left to test after this (roughly 8 steps)                                [a66e205b29f898d57b85b6f9e3a6e3ac5ad58cd4] chan is already available via closure
root@91b2acc00772:/go/sftp# git bisect run ./test.sh
running ./test.sh
2023/03/21 22:38:44 writing 1e+09 bytes
2023/03/21 22:38:48 wrote 1e+09 bytes in 4.540004105s
Bisecting: 109 revisions left to test after this (roughly 7 steps)
[ba123434b87007b835fef17bb0e95ebc28d6a21a] Merge pull request #437 from drakkan/realpath
running ./test.sh
2023/03/21 22:38:50 writing 1e+09 bytes
2023/03/21 22:39:00 wrote 1e+09 bytes in 10.06397129s
Bisecting: 55 revisions left to test after this (roughly 6 steps)
[16ca7e303229c17f462e5c1aaaf6734c8aaf9761] Merge pull request #428 from drakkan/readfrom
running ./test.sh
2023/03/21 22:39:02 writing 1e+09 bytes
2023/03/21 22:39:12 wrote 1e+09 bytes in 10.033959944s
Bisecting: 26 revisions left to test after this (roughly 5 steps)
[e164c76a1254f2d3e747327c7c7a061a1f7539f2] Merge pull request #413 from greatroar/mkdirall-slash
running ./test.sh
2023/03/21 22:39:13 writing 1e+09 bytes
2023/03/21 22:39:23 wrote 1e+09 bytes in 10.026752012s
Bisecting: 13 revisions left to test after this (roughly 4 steps)
[b8102da57e756b46f2da530d9d16c868dd6c0e9d] Merge pull request #397 from pkg/more-optimization
 #397 from pkg/more-optimization
running ./test.sh
2023/03/21 22:39:24 writing 1e+09 bytes
2023/03/21 22:39:34 wrote 1e+09 bytes in 9.892910505s        Bisecting: 6 revisions left to test after this (roughly 3 steps)                                                          [29c556e3a6f049a6932bdaf6c9a084dc4b0f08c4] WriteTo benchmarksrunning ./test.sh
2023/03/21 22:39:35 writing 1e+09 bytes
2023/03/21 22:39:39 wrote 1e+09 bytes in 4.604390606s        Bisecting: 3 revisions left to test after this (roughly 2 steps)                                                          [fc15699691212023/03/21 22:39:41 writing 1e+09 bytes
2023/03/21 22:39:51 wrote 1e+09 bytes in 9.780662301s
Bisecting: 0 revisions left to test after this (roughly 1 step)
[0be6950c0e91d5cb73a4d690270d3a5010ac9808] fix comments and variable names to reflect Write instead of Read                                                                                running ./test.sh
2023/03/21 22:39:52 writing 1e+09 bytes
2023/03/21 22:39:57 wrote 1e+09 bytes in 4.609922288s
fc156996912168806d33b55794e2f5436fae2c3d is the first bad commit                                  commit fc156996912168806d33b55794e2f5436fae2c3d
Author: Cassondra Foesch<EMAIL_ADDRESS>Date:   Sun Feb 21 20:32:09 2021 +0000

    fixed concurrent writes, mid-polish

 client.go | 614 ++++++++++++++++++++++++++++++++++++++------------------------
 1 file changed, 373 insertions(+), 241 deletions(-)
bisect run success

I tried this in a docker container and it seems that after this version writes are slower.

have also a look at https://github.com/pkg/sftp/issues/426 where the commit is also mentioned.
according to the issue there was something fixed in 1.13.1 but restic already uses 1.13.5 🤔

Any workaround for this? Restic is taking x10 longer than borgbackup for me, right now

I'm now using the REST server as backend, which is performing well.
If you're stuck with SFTP, the workaround is to use a version < 0.12.1.

To improve speed, I switched to using rclone with an SFTP backend. I felt it gave me greater control over the options and felt more optimized.
Did you try, if that resolves the performance issue?

Hi, I was diagnosing my slow backup speeds even though I have 10g network and transfer is from nvme nas with ssds.
restic options
sftp.connections    set a limit for the number of concurrent connections (default: 5)
=> default should be 5, which I interpret as 5 ssh connections to the target server, which usually show up as separate process
I only see 1 ssh connection on target. Is this what this bug is about and what MaxConcurrentRequestsPerFile will probably fix?
root@nas 14:34:56 ~ # ps aux | grep sshd | grep restic
root     1526753  0.0  0.0  11832  9120 ?        Ss   11:50   0:00 sshd: resticbackup [priv]
resticb+ 1526765 34.8  0.0  12256  6456 ?        S    11:50  57:25 sshd: resticbackup@notty

The names here are somewhat misleading. sftp.connections currently only means that restic uploads up to 5 files in parallel, the SFTP backend currently multiplexes all requests onto a single connection.
With SFTP files are requested in 32KB chunks, which is why multiple concurrent requests have to happen for a file to ensure a decent performance. The issue here is likely related to that.

The names here are somewhat misleading. sftp.connections currently only means that restic uploads up to 5 files in parallel, the SFTP backend currently multiplexes all requests onto a single connection.
With SFTP files are requested in 32KB chunks, which is why multiple concurrent requests have to happen for a file to ensure a decent performance. The issue here is likely related to that.

thanks for clearing that up @MichaelEischer

There's now https://github.com/restic/restic/pull/4782 that fixes the upload performance. Please give it a try.

I tried to do before and after comparisons (0.16.4 and 0.16.4+patch) but somehow my performance was already adequate without the patch on vanilla 0.16.4. (around 250 MB/s ssd to ssd over 10gbe with read-concurrency 10, sftp-connections 10, Gentoo Linux). Different to what I witnessed some months ago.  I need to test some more and better structure the tests, just quickly compiled it in and looked at network graph. I hope somebody else can test the MR too.
in any case, thanks for implementing!

I've tested this patch on my side, that change nothing on a single file of 1GB. File transfer is very slow

@yverry Can you provide a few more details on your test setup? What does "very slow" mean? How fast are you able to upload to that server using for example scp? How fast is the upload using restic 0.12.0?

scp on qnap is slow, that is not new for me. I stuck at 20Mb/s
on restic it's more like 1Mb/s
I need more time to test with 0.12.0 because it's not compatible with version 2 format

@yverry What exactly did you test? Which command, etc.? What is the output of restic version with and without my bugfix PR? How high is the latency between the host running restic and the NAS?

I'm pretty sure that my bugfix PR fixes the issue introduced in restic 0.12.1; at least it did during my tests. If you still see very slow uploads/download please open a separate issue.

Hi,
My test was to upload a single file of 512MB via sftp.
The first 115MB went well, after that's stuck at pretty 0 during few second, upload continue for 20MB, stuck again etc etc ...
your version, just compiled:
 ./restic-patch version
restic 0.16.4-dev (compiled manually) compiled with go1.22.2 on linux/amd64

the backup command:
time ./restic-patch backup -r sftp:restic@myserver:path --tag slowsftp ./512M -v
open repository
repository 09103b42 opened (version 2, compression level auto)
no parent snapshot found, will read all files
load index files
[0:01] 100.00%  82 / 82 index files loaded
start scan on [512M]
start backup on [512M]
scan finished in 1.141s: 1 files, 512.000 MiB

Files:           1 new,     0 changed,     0 unmodified
Dirs:            3 new,     0 changed,     0 unmodified
Data Blobs:    350 new
Tree Blobs:      4 new
Added to the repository: 512.024 MiB (512.065 MiB stored)

processed 1 files, 512.000 MiB in 8:00
snapshot de831b42 saved

real	8m2.470s
user	1m12.533s
sys	0m7.744s

A classical sftp of this one file upload went well (35sec).
With a s3 (minio) backend, everything went well too 31s
time ./restic-patch backup -r =s3:https://mys3/mysuperbucket ./512M --tag slowsftp
repository 42 opened (version 2, compression level auto)
no parent snapshot found, will read all files
[0:01] 100.00%  8 / 8 index files loaded

Files:           1 new,     0 changed,     0 unmodified
Dirs:            3 new,     0 changed,     0 unmodified
Added to the repository: 512.024 MiB (512.054 MiB stored)

processed 1 files, 512.000 MiB in 0:31
snapshot 4242 saved

real	0m32.507s
user	1m17.382s
sys	0m5.115s

So I switched to S3 without understanding where the bottleneck was.
I hope I'm more precise now

Thanks for the detailed answer!

The first 115MB went well, after that's stuck at pretty 0 during few second, upload continue for 20MB, stuck again etc etc ...

That rather sounds like it takes a long time until the server has fully stored the uploaded pack files on disk. That traffic pattern definitely won't be caused by the issue discussed here.

There's now #4782 that fixes the upload performance. Please give it a try.

I wanted to chime in that I was just wrestling with the same issue while testing restic for the first time and was absolutely perplexed that I was getting about 1.6 Mb/s multiplied by the value of -o sftp.connections. The source is a high end custom NAS on a 1 Gb/s link to a remote target (Hetzner Storage Box). Compiling the committed version of the PR in b5fdb1d637dcbcffd36b1f961ba13cd27e3e63d7 allowed me to saturate the remote target's 100 Mb/s link.
Thank you very much for this (and restic)!
I'm not sure what the release criteria are but I think this is impactful enough to warrant a new release or at least push in that direction.

A new release isn't too far out anymore, I'm wrapping up the last parts of the roadmap for 0.17.0 https://github.com/orgs/restic/projects/2/views/1 (which ended up including far more changes than I've originally anticipated). So it shouldn't take more than a few weeks now to release the next version.

This fix isn’t in 0.16.5 right? Just saw it wasn’t mentioned in the release notes.

no, this will only be part of restic 0.17.0. restic 0.16.5 was just a minimal release to update a few potentially vulnerable dependencies.


Silence deprecated warning for get_default_endpoints

Temporary fix for #139. We must remember to change the function to default_endpoints when the next rodio version is released.

bors r+


⚠ Samsung has degraded performance

In b11227f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2153 ms

Resolved: Samsung performance has improved in fee13f9.


Regression of 58388: Files imported from F5 tests are loaded twice on Windows (once via 'C:', once via 'c:')

Issue Type: Bug
https://github.com/Microsoft/vscode/issues/58388 appears to have regressed in Insiders (I can't repro it in stable).
Repro (Windows only):

git clone https://github.com/Microsoft/vscode-azurearmtools.git
npm run all
tests pass
load in vscode
set debug config to Launch Tests
F5
!) tests fail:

rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: Setup failed
extensionHostProcess.js:700
stack trace: AssertionError [ERR_ASSERTION]: Setup failed
extensionHostProcess.js:700
    at mySetup.then (c:\Users\stephwe\Repos\vscode-azurearmtools\test\Treeview.test.ts:56:49)

This is caused by extension.bundle.ts getting loaded twice instead of once:
7) set a breakpoint at the top of extension.bundle.ts
8) F5
!) The breakpoint gets hit twice
EXPECTED: It should be cached and therefore only get hit once
It doesn't think it's cached because once it's loaded as "c:\Users\stephwe\Repos\vscode-azurearmtools\dist\extension.bundle.js" and the second time as "C:\Users\stephwe\Repos\vscode-azurearmtools\dist\extension.bundle.js".
VS Code version: Code - Insiders 1.32.0-insider (69249882e8717cf111e04330390107282e337559, 2019-02-27T21:19:19.351Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Xeon(R) W-2133 CPU @ 3.60GHz (12 x 3600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.73GB (15.65GB free)

Process Argv
--folder-uri file:///c%3A/Users/stephwe/Repos/vscode-azurearmtools

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

vscode-antlr4
mik
2.1.1

vscode-cosmosdb
ms-
0.10.0

extension-manifest-editor
ms-
0.1.5

azure-account
ms-
0.8.0

csharp
ms-
1.17.1

vscode-typescript-tslint-plugin
ms-
1.0.0

azurerm-vscode-tools
msa
0.5.0

vscode-docker
Pet
0.5.2

vscode-sort-json
ric
1.13.0

sort-lines
Tyr
1.8.0

win-ca
uko
2.4.0

I don't see how VS Code is involved here: "extension.bundle.ts" is user code. Who should "cache" this?

Please see the original bug. Yes I am referring to node.js caching. This was a vscode problem before, although I don't understand the details. Nothing has changed in my code, and it works in stable but fails in Insiders.

I suggest that you investigate where in your code the file is loaded and why the drive letters have different casing in those locations.

The two places this comes from are a) an import in my code, b) vscode loading test files.

@isidorn since you have pushed the fix previously. Maybe this is a regression from the work we did this milestone to use node.js path module everywher?

Yeah probably using node.js path breaked this.
We should check the casing of extensionDevelopmentPath as that was the cause last time.

@StephenWeatherford I cannot reproduce this issue, I just tried with Code Insiders:
Version: 1.32.0-insider (system setup)
Commit: 804373ac4d5c84e96c8086cee5b9be132df88837
Date: 2019-03-01T18:22:35.336Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134
Test runs fine:

Looks like an issue with your setup?

I might have caused that with https://github.com/Microsoft/vscode/blob/1e17319bfde04aefb34fd1b0648868dca208fa2c/src/vs/workbench/api/node/extHostExtensionService.ts#L617
Should always use 'resources.originalFSPath' which does not normalize anything.
I'll push a fix so you can verify that this is the problem.

Created https://github.com/Microsoft/vscode/pull/69716 as 1.32 candidate.

@StephenWeatherford I created a build that contains the my change. Can you verify if that fixes the issue?
win32-x64-1.32.0-insider
win32-ia32-1.32.0-insider

Yep, that fixes it, thanks!  Any change you can create a unit test or something to make sure it doesn't break again?

verified by @StephenWeatherford


Downloading some videos at the same time conflicts.

I use tableview to display the download process of multiple videos. When I download some videos at the same time, there are conflicts. Do you have any good suggestions?@kewlbear

I didn't consider downloading multiple videos simultaneously.  You should change YoutubeDL-iOS package source to handle that scenario.

OK I'll try.Thank you.


[WIP] Extend synonyms A/B test to other subqueries

This is a change to the synonym A/B test after debugging some queries.
I've also checked in some debug code I used, which I think could be useful in the future. I plan to use it to compare how the A and B versions treat specific documents.
See individual commit messages for more details.
This is still a WIP:

I need to rerun the healthcheck with these changes
I'm not convinced the core_query.minimum_should_match_with_synonyms part is working as expected, because we've debugged a couple of queries where matches on all_searchable_text don't show up in the query output, whereas with the A version we can see matches on the _all field.

Trello: https://trello.com/c/9VF3Rw5V/451-test-synonyms-with-healthcheck-and-search-performance-explorer

Continuing in

https://github.com/alphagov/rummager/pull/1038
https://github.com/alphagov/rummager/pull/1039
https://github.com/alphagov/rummager/pull/1040


[JENKINS-34599] Setting of final fields

Subsumes #32.
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.


RDP Only Option

Would be nice to have an RDP only option.  I don't know how that is implemented but the Duo Security Windows Logon Credential Provider can do it with a registry setting.  It might be checking for a remote IP address.

I have the "RDP only" switch in my version but I don't know how to upload it. I have made my version for the Credential V2 (windows 8 and 10 style) so it's not a branch but rather completely different project... I kept the original logo:D and I can verify that the microsoft account 2'nd level authentication works with multiotp !!! If you like I can send you the code and dll

Yeah that sounds perfect.  I'm only using Windows 8.1+ these days anyway.  Also great info on how to check for RDP, should be easy to patch that in.

I have just uploaded my first project with a git repository... I don't know if it's any good, but hey I've never used git before :D you could try this https://github.com/arcadejust/MultiotpCPV2RDP

Looks very simple, which I like. If you want to tag it as a release you can upload any binaries that go with it into the "releases" tab.

It's ready - you can try it out

What do I do with the DLL?  Does it go in a particular path?  Do I need to register it?

First make sure you have multiotp installed and the path to it is correct in register.reg (default "MultiOTPPath"="c:\multiotp\windows\" modify the path if you have to with notepad).Copy the dll to c:\windows\system32 and then run register.reg. Right now the setting "MultiOTPRDPOnly"=dword:00000001 suppress CP for local login and lock screen so you will not see a credential provider from your console, you will have to open rdp from another computer to see it.

Yeah that worked as expected, great!


The error return bug in promise.All function

Problem: When there are more than two rejected promises in promise.All function. The returned error value is not stable。
Please infer blow image: the println err.Error() output maybe error1 or error2, in js promise. it is error1.

Hi @duke-git
promise.New creates a new goroutine and scheduler makes no guarantees regarding the scheduling. All rejects immediately upon any of the promises (which are a tiny abstraction over the goroutine) rejecting, so unless you synchronise those promises yourself there's no way to guarantee which promise will reject first

Hi @duke-git promise.New creates a new goroutine and Go scheduler makes no guarantees regarding the scheduling. All rejects immediately upon any of the promises (which are a tiny abstraction over the goroutine) rejecting, so unless you synchronise those promises yourself there's no way to guarantee which promise will reject first

@chebyrash Thanks. The explaination make sense.


Setup fluid on mainnet

Set up Fluid connector on mainnet
Set up Instapool V5 on mainnet

Deployed contracts:
INSTAPOOL-V5: 0xDe0223C3627e8958a1136b16092d14Df3C693f5c


Rework "user groups" widget to work like other organization-level settings widgets

Specifically, we should use the normal Save/Discard widget that we use across all of "organization settings", rather than the custom inconsistent "Click outside to save or click discard to discard" UI that it currently has.

@zulipbot claim

@zulipbot claim

@mandepsingh I am working on the task already. There is some issue with zulipbot I guess.

@zulipbot claim

@savish28 are you still working on this issue? I

I have worked on the issue and waiting for pr review. Past that only testfiles need to be changed.

Okay. It was unassigned so I thought that you have stopped working on it.

@zulipbot abandon

@zulipbot claim

@zulipbot claim

@zulipbot still pending review

#17586

Closing in favor of the rewrite proposed in #19526.


Server sources watcher.

test fails because of
sails(master)$ node /Users/dangreen/github/sails/bin/sails.js new testApp
error: No generator called `new` found; perhaps you meant `sails generate api new`?

HI @dangreen, thanks for posting.  Without more explanation, it's kind of hard to tell what your code is supposed to do, but assuming this is a new feature and not a bug fix, we'd need more info before we would consider merging it.  Please review our updated contribution guide, then submit a proposal explaining your use case and how this approach would solve it, as well as much of a spec as you have time for? Beyond the other reasons discussed in our new contribution guide, one of the most important things about understanding your use case is so that we can ensure this is appropriately documented and tested now, and maintained properly in the future.
Thanks again for taking the time to help improve Sails!

@sgress454 This feature adds to sails the sources ("api/**/*.js", "config/**/*.js", "tasks/**/*.js") watcher. When these files are changed, to apply changes, sails app will be restarted.
Example:
bootstrap.js:
module.exports.bootstrap = function(cb) {
	cb();
};

jam-server(react*)$ sails lift

info: Starting app...

(node) crypto.createCredentials is deprecated. Use tls.createSecureContext instead.
(node) crypto.Credentials is deprecated. Use tls.createSecureContext instead.
info:
info:                .-..-.
info:
info:    Sails              <|    .-..-.
info:    v0.11.2             |\
info:                       /|.\
info:                      / || \
info:                    ,'  |'  \
info:                 .-'.-==|/_--'
info:                 `--'-------'
info:    __---___--___---___--___---___--___
info:  ____---___--___---___--___---___--___-__
info:
info: Server lifted in `/Users/dangreen/github/jam-editor/jam-server`
info: To see your app, visit http://jam.dev
info: To shut down Sails, press <CTRL> + C at any time.

debug: --------------------------------------------------------
debug: :: Thu Jan 21 2016 12:36:42 GMT+0600 (NOVT)

debug: Environment : development
debug: Host        : jam.dev
debug: Port        : 1337
debug: --------------------------------------------------------

Edit bootstrap.js:
module.exports.bootstrap = function(cb) {
	console.log("hello!");
	cb();
};

jam-server(react*)$ sails lift

info: Starting app...

(node) crypto.createCredentials is deprecated. Use tls.createSecureContext instead.
(node) crypto.Credentials is deprecated. Use tls.createSecureContext instead.
info:
info:                .-..-.
info:
info:    Sails              <|    .-..-.
info:    v0.11.2             |\
info:                       /|.\
info:                      / || \
info:                    ,'  |'  \
info:                 .-'.-==|/_--'
info:                 `--'-------'
info:    __---___--___---___--___---___--___
info:  ____---___--___---___--___---___--___-__
info:
info: Server lifted in `/Users/dangreen/github/jam-editor/jam-server`
info: To see your app, visit http://jam.dev
info: To shut down Sails, press <CTRL> + C at any time.

debug: --------------------------------------------------------
debug: :: Thu Jan 21 2016 12:36:42 GMT+0600 (NOVT)

debug: Environment : development
debug: Host        : jam.dev
debug: Port        : 1337
debug: --------------------------------------------------------

info: Restarting app...

(node) crypto.createCredentials is deprecated. Use tls.createSecureContext instead.
(node) crypto.Credentials is deprecated. Use tls.createSecureContext instead.
hello!
info:
info:                .-..-.
info:
info:    Sails              <|    .-..-.
info:    v0.11.2             |\
info:                       /|.\
info:                      / || \
info:                    ,'  |'  \
info:                 .-'.-==|/_--'
info:                 `--'-------'
info:    __---___--___---___--___---___--___
info:  ____---___--___---___--___---___--___-__
info:
info: Server lifted in `/Users/dangreen/github/jam-editor/jam-server`
info: To see your app, visit http://jam.dev
info: To shut down Sails, press <CTRL> + C at any time.

debug: --------------------------------------------------------
debug: :: Thu Jan 21 2016 12:43:41 GMT+0600 (NOVT)

debug: Environment : development
debug: Host        : jam.dev
debug: Port        : 1337
debug: --------------------------------------------------------

@sgress454 ... https://github.com/sgress454/sails-hook-autoreload


Octopus intelligent slot reporting away charging as 'unknown' indicating low rate slots

Describe the bug
In the slot sensor if I charge my Tesla away from home it shows up as completed dispatches but it looks like they are low rate slots when they are not.
Comparing intelligent plugin:

To Octopus plugin:

Reproduction steps
Charge a Telsa on IO away from home
Expected behaviour
Either ignore the away charging or report it in a way that means it's possible to know these are not IO slots.
Tariff Code
No response
Integration Version
8.1.0
Home Assistant Version
2023.8.1
Fresh Install?
After upgrading
Home Assistant Logs
n/a

I've added the location attribute to the slots where available. This can be found in v8.3.0.


Build Error

After installing rust and attempting installation of osintui using cargo i receive the follow error:
( For reference i am using linux os)
installation code entered:
cargo install osintui
Error received:
warning: build failed, waiting for other jobs to finish...
error: failed to compile osintui v0.1.1, intermediate artifacts can be found at /tmp/cargo-installKX3U8e

Any idea on a solution for this ?

please clear "/tmp/" ant try again. if repeat this error you need check the dependency

same prolem

WM KALI on Mac M1
error: failed to run custom build command for openssl-sys v0.9.90
Caused by:
process didn't exit successfully: /tmp/cargo-installiPndKq/release/build/openssl-sys-7ddd18388c8f9f9d/build-script-main (exit status: 101)
--- stdout
cargo:rerun-if-env-changed=AARCH64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
AARCH64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset


nested call variable shadowing

shadowing variable names doenst seem to work correctly.
neither with custom name:
echo:
  @[@[1,2],@[3,4]].items |>
    map[a](
      a.items |> map[a](a+1).toSeq()).
    toSeq()

nor with it:
echo:
  @[@[1,2],@[3,4]].items |>
    map(
      it.items |> map(it+1).toSeq()).
    toSeq()

Umm ...
that's because it replaces every occurrence of the identifier in "top-down" order.
honestly iterrr is not designed to use nested in the first place, but I'm thinking to find a way to make it possible

using templates should fix the problem, I'll try it on the weekend

well, I tried different ways,
maybe that can't be fixed


feat: Improve usage and use cmd2

Remove structured dict results
Use exceptions instead of result: Error
reading returns only data
Add logging everywhere
Improve test coverage
Use cmd2 instead of cmd
Major version bump
Fix execute_changes to commit
Enforce proper validation for write and read arguments
Allow retry on all commands
Fix documentation generation
Remove py36 and py37 support due to pformat

Known Issues:

tox testing occasionally fails due to socat port closing
setting logging can be added into the cli commands
write and commit can be added

BREAKING CHANGE: API is now different in responses as well as execute_changes->commit

Coverage report seems to have an issue, maybe something to do with matrix uploads.


Add smart report agent email to constants file

Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/211521
Tests & QA

Verify the report page loads in e.com

recheck


Getting Started Tutorial

Describe the documentation issue
Before the java keras development was moved to this repo, it had a great getting started guide. That would be great to be easily discoverable in this repo.
(A getting started guide for importing models from python would be great too. I have a feeling that's a pretty common use case for using tensorflow in java)

Hi @alexdriedger , sorry for the delay, last days were a bit crazy for me,
I totally agree that we should start focusing on a simple tutorial explaining different steps for doing inference in TF Java from a saved model (probably trained in Python), this is the most common use case of our library right now. Would you be interested doing it? We also had a few discussions with Google to see if we can integrate a Jupyter book with a Java kernel to write such tutorials, it might something we want to take a look at.
About Keras, it is still under heavy development and nothing has been merged so far in the repository, about this @dhruvrajan can probably provide you a better status.

I may be able to help here, now that model save/load seems to work (for me) from *.pb files in mainline Tensorflow-Java https://github.com/tensorflow/java/issues/100#issuecomment-674791320.  In the near future, save/load will be different #101.
However, when I used Python Keras, I saved numpy and JSON files, not *.pb files.  I did that because it seemed to most reliably work for me.  Should I try to save a model as a *.pb file in Python Keras, then load that in Tensorflow-Java, and document this process?  If so, kindly advise where I should put documentation?  I call Tensorflow-Java from Scala, which may be convenient, but probably not as convenient as a Keras-like abstraction.

Is there a snippet for loading a SavedModel and running inference? Did @aday00 already write the documentation?

I was able to run my SavedModel. Is there a wrapper for loading images? At the moment I am creating the input Tensorflow for my CNN manually.

Hi @steven-mi , I invite you to take a look at this unit test to have a better idea on how to load and run saved models in Java.
This ConcreteFunction API is new and we did not updated yet our examples in this repo to reflect the latest changes. Please feel free to create a PR it you think that you may have something worth making an example of.
For image loading, there is no framework provided by our library for this at this time.

@karllessard Hi, well I would like to contribute and I guess the best way would be to write some docs :) So if it is ok you could assign me here and I will take my time to do it right.

Thanks @igor-susic , this is greatly appreciated, documentation is definitely lacking right now!


Compilation error

Hello,
I'm trying to compile the code (Linux) but get the following error message:
sdhash-src/../sdbf/sdbf_defines.h:9:25: fatal error: openssl/bio.h: No such file or directory compilation terminated. make: *** [sdhash-src/sdhash.o] Error 1
It seems the bio.h is missing. Any idea of how to solve this issue?
Thanks!

Is there any instructions available to recreate the blooms.pb.h with a more recent version of protobuf?

Apparently with protobuf 2.6.1 all you need to do is protoc -I ./ --cpp_out=sdbf/ blooms.proto


Remove unused CoffeeScript mode for CodeMirror

These files, which let the CodeMirror editor edit CoffeeScript, seem to be unused in this project. Is it okay to remove them, or were you planning to let people implement their algorithm in CoffeeScript too?

I guess there was a plan initially, but I've since abandoned it.


Fix ExceptionHandler for use with swoole

Fix ExceptionHandler for use with swoole. Sometimes Exception must be Throwable, and we convert it.

Tests are not passing. And there is breaking changes in your Pull Request. It's better if you create an issue explaining your problem first.

When i'm using swoole (php extension) with laravel and when i have Throwable Error, handler is down with TypeError... I fix it locally, but it's not a good solution.


Waveform seems to freeze on sufficiently wide waveforms.

Waveform doesn't seem to render for widths of 30k+ pixels
Works fine for sufficiently narrow waveforms.
Is there anyway we can configure the library to start drawing from left to write instead of all at once?

Duplicate of #47.
You can try setting smaller height and minPxPerSec. Also set pixelRatio to 1 if on Retina.
There's currently no Canvas-based frame-by-frame scrolling, but it's planned (see #47).


Support Custom Host Method Hooks

Summary of the new feature / enhancement
As a module developer I would like to create a module that can enhance the way that PowerShell works in the standard console/terminal context. There are a few mechanisms in the PSHost that make some actions hard to customise and are limited to what PowerShell includes in box. For example I feel like the following 4 calls are ripe for customisation

PromptForCredential - Can utilize a more modern Windows prompt (or use some Linux/macOS keyring UI) like https://gist.github.com/jborean93/586382429f869bdc1415d0ccb90db2e7
Prompt
PromptForChoice (and the choices overload)
WriteProgress

The builtin choice mechanisms are currently rudimentary with them looking like

and for multiple choice selection

Being able to use something like Spectre.Console you could make them much more usable like

and for multiple choice selection

If someone doesn't like the currently hardcoded selection of progress styles, this would allow someone to do their own like

Currently the only way to customise these is to start a new runspace with a custom host. This is not ideal as

You need to implement all the PSHost and PSHostUserInterface methods, not just the ones you want
You can't push a local runspace onto the stack - https://github.com/PowerShell/PowerShell/issues/5735
Even if you could, you now loose all the context of the runspace you were in

By opening up customisation of the current PSHost you allow module authors to do whatever they wish and provide their own spin.
Proposed technical implementation details (optional)
I'm not sure on a good way of doing this but I'm hoping this issue can open it up for ideas and suggestions. While we could try and open up the host API to allow a module to push their own PSHost implementation on the stack (like what PSGhost does). I don't think this is ideal as implementing your own host is not the simplest thing and if a module author only wants to touch the prompt calls they still need to add a shim for the rest.
Potentially we could use the same functionality of the prompt function where the default PSHost call will just call that function. There are probably performance implications here so I'm definitely keen to hear other people's thoughts on how we could implement such a thing.

I agree that the current host looks outdated and that there are many unpleasant limitations.
But I feel that these problems cannot be solved simply by adding hooks. These public interfaces are more likely to be a stopgap to resolving the underlying problems.
I would rather vote for designing and building an alternative host as an experimental feature.

I think it makes sense to expose the Host callbacks as extensible and separately Progress rendering as pluggable (so that both could be modules you install from PSGallery, but then need to consider how to register/unregister if you have several installed).  For the Host callbacks, need to consider how this would work with EditorServices.  @jborean93 would you be willing to write-up a proposal?

For prompting, the ideal thing would be to expose the current functionality as cmdlets in the ConsoleGuiTools module, and have the current Host APIs call the cmdlets by their simple names (i.e. not module-qualified). As long as the command resolution respected the normal module import order, that would let us override the prompt cmdlets by just importing a module that clobbered the commands. And going forward, you'd be able to improve on the module, and even add new prompt options -- scripters would naturally migrate away from the Host APIs...
I think progress needs to be a separate conversation, because it's a stream, and has major performance considerations...

would you be willing to write-up a proposal?

I can certainly look into it, would take some time to figure out the various ways this could be done and trying to weigh up the pros and cons.

For prompting, the ideal thing would be to expose the current functionality as cmdlets in the ConsoleGuiTools module, and have the current Host APIs call the cmdlets by their simple names (i.e. not module-qualified)

I'll certainly look into that module, I am concerned around the performance aspect of C# code doing a function lookup for each of these prompts but maybe for things like PromptForChoice or PromptForCredential that's not really too much of a concern.

And going forward, you'd be able to improve on the module, and even add new prompt options -- scripters would naturally migrate away from the Host APIs...

While a nice idea, the host APIs are nice in that they effectively have a common shim for remote runspaces. I do agree they are quite limited in their functionality but it's nice for things like Get-Credential and $host.UI.PromptForCredential(...) to work seamlessly.

think progress needs to be a separate conversation, because it's a stream, and has major performance considerations...

Agreed, it probably even needs a further extension to how it works as currently it relies on the REPL to be cleared by prompt to clear the existing progress output. For PSGhost I had to hook into the prompt function to tell Spectre's progress output to stop and clear as it was unaffected by the the clearing of the console buffer.
I'll have to ponder it a bit more and consider the options. I'm definitely keen to hear other people's thoughts and ideas on how it could possibly be done.

@PowerShell/wg-powershell-engine
We discussed this and we agree this would be a welcome behavioral addition, but we would really need an RFC to work through all the intricacies of the proposal. We also wonder whether this is more an @wg-interactive-console issue, so we've added that working group to get their opinion.


[Solved] Official Repo

I am the original developer and active maintainer of Greenlock.
It's official home is https://git.coolaj86.com/coolaj86/greenlock.js
Daplie's fork is not maintained.
To avoid confusion I have asked the owners of this fork to transfer the repository to me. Others have also asked for this fork to be archived and to have the readme updated.

That page doesn't load for me but I found this: https://github.com/coolaj86/greenlock

@styfle Can you check and see if it is loading for you now?
I have an uptime monitor on it and got a notification last night of a 1 minute outage (probably Digital Ocean rebooting for the L1TF patch), but haven't seen any problems other than that (and someone even opened a new issue).

Are you behind any sort of network system that might be blocking sites

Yes my workplace blocks some websites. Usually it's when the IP is outside of North America, but yours seems to be in San Francisco so I'm not sure why it's blocked.

IPs are bought and sold all of the time. I switched to a new server last month. This month it belongs to me, last month it could have been a blacklisted Russian mail server.


Swap Notification example list phoneNumber value without quotes

Problem description
event example included in "https://github.com/camaraproject/SimSwap/blob/main/code/API_definitions/sim-swap-notification-subscription.yaml" use phoneNumber without quotes (phoneNumber: +123456788), should be:
phoneNumber: "+123456788"

examples:
SWAPPED:
value:
id: "123655"
source: supertelco.notificationSendServer12
type: org.camaraproject.sim-swap.v0.swapped
specversion: "1.0"
datacontenttype: application/json
data:
phoneNumber: +123456788
subscriptionId: 2ghy-55gg-7iup-yuo9
time: 2023-01-18T13:18:23.682Z
SUBSCRIPTION_ENDS:
  value:
    id: "123658"
    source: supertelco.notificationSendServer12
    type: org.camaraproject.sim-swap.v0.subscription-ends
    specversion: "1.0"
    datacontenttype: application/json
    data:
      phoneNumber: +123456789
      terminationReason: SUBSCRIPTION_EXPIRED
      subscriptionId: 2ghy-55gg-7iup-yuo9
      terminationDescription: subscription expire time reached
    time: 2023-01-19T13:18:23.682Z

Fixed with #111


Replace script in Publish Node step with pulumi cli and test

Currently, we rely on the ci-scripts repo to publish to Node.
We should use the new pulumi package publish-sdk functionality instead:
pulumi package publish-sdk nodejs --path <path/to/package.json>
Once we verify that this works on a publish step (use a master/main publish_sdk step) then we can tag a new version and update ci-mgmt.

This has been far more difficult to implement than expected.
When using this command in CI the pulumi package-publish command fails with an error I haven't been able to reproduce outside of GHA.
I have verified the .npmrc contains the necessary information.
I upgraded to v3 of the Setup Node Action.
I have verified that a regular npm publish works correctly; it is only the pulumi command that is failing.
My hunch is that npm info is doing something odd on this line
and I have opened https://github.com/pulumi/pulumi/pull/13041 to verify.
It could also be an error on npm publish.
I do not know why this is happening. I would think that it is a token issue but I have verified that npm publish works when run by itself. I also do not know if the command stdout would be "" as is usual when npm info cannot find a package if there is a 404 error being returned as well.
I have a partial reproduction: if my local token is incorrect, and I try to run npm info, I get something similar to what's failing in Actions, so it does seem like npm info only returns "" and 0 when the authentication is correct:
npm info<EMAIL_ADDRESS>npm ERR! code E404
npm ERR! 404 '@pulumi/xyz' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it
npm ERR! 404 (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR!      /Users/guin/.npm/_logs/2023-05-26T17_31_31_031Z-debug.log

But this all fails to explain why the script ran correctly - was it just swallowing an error the entire time?
A post with a lot of solutions listed is here: https://rapaccinim.medium.com/surviving-the-npm-err-404-with-private-packages-b413d80fb860

update:
It is in fact very likely the case that we have swallowed this error for a long time using the scripts repo.
npm info<EMAIL_ADDRESS>npm ERR! code E404
npm ERR! 404 '@pulumi/xyz' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it
npm ERR! 404 (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR!      /Users/guin/.npm/_logs/2023-05-26T18_39_36_539Z-debug.log

but piping the error to dev/null results in the empty output we look for.
$ npm info<EMAIL_ADDRESS>2>/dev/null
$

I do not entirely understand why we are seeing it in CI (when trying the partial reproduction above locally, it only triggers on an incorrect token) BUT


Update size of preview

Set width to 300 for preview for fit content. See screenshoots:
Before:

After:

Thanks! Sorry, I didn't look into this repo in a long time :)


doNotUserUserAgentSuffixInClientTelemetry

.Net PR reference:  https://github.com/Azure/azure-cosmos-dotnet-v3/pull/3653

API change check
API changes are not detected in this pull request.


Blacken the doctest code in docstrings

With a bit of preparation this is the result of running black-doctest on the repository. The tool itself is experimental but I didn't find any issues after manually reviewing the changes. The exact call was:
python -m blackdoc .

I'm not too sure what line length we use for docstrings (I used the default of 88 for this run), but if we'd like a different number we can just rerun the tool.
python -m pytest --doctest-modules xarray/core still fails but from what I saw these failures are not due to changes in this PR.

[x] Passes isort -rc . && black . && mypy . && flake8
[ ] Fully documented, including whats-new.rst for all changes and api.rst for new API

Looks great! Congrats on such a good tool!

Thanks @keewis


attributes not available in graphql requests for shopify

When I copy the query which works in shopify Graphiql app. Many of the attributes that are available in shopify graph ql do not work when I  query through the framework.
Field 'ruleSet' doesn't exist on type 'CollectionEdge'
3 | export function getError(errors: any[] | null, status: number) {
4 |   errors = errors ?? [{ message: 'Failed to fetch Shopify API' }]

5 |   return new FetcherError({ errors, status })
|         ^
6 | }

When i change the CollectionEdge type in the schema to include the attribute it still doesn't work

@Si-Oz commerce uses the Storefront API https://shopify.dev/api/storefront/2022-07/objects/collection
The field you tried on GraphiQL was from Admin API.


Add custom binary format to NetworKit

Adding @michitux as a reviewer as he wrote the Thrill binary readers. This might also be interesting to @manpen.
Let me write a bit about the context of this PR. Here, we introduce a new binary graph format. While many formats exist already, this one specifically aims for high performance. In particular, the goals are as follows:

The format allows for good read performance. It can support parallel reading.
Compactness. While the format is not as compact as compressed formats, it is still significantly more compact than text files.
Extensibility. Adding more features will not render existing files invalid.

I do not consider the fact that this format does not exist outside of NetworKit to be problematic. Our main use case will be converting graphs to this format and then profiting from the improved I/O performance. This is especially helpful when benchmarking multiple algorithms on the same graph.
The description of the format is part of the PR (see networkit/cpp/io/NetworkitBinaryGraph.md). However, let me highlight a few design decisions here:

Sizes of adjacency lists are stored independently of the lists themselves; hence, those lists can be preallocated.
To achieve parallel readability, the format stores the graph data in multiple chunks. Vertices in different chunks can be processed in parallel. The number of chunks (and their sizes) can be configured at write time.
All entries of edge lists are stored in a varint encoding, namely PrefixVarint. In contrast to Thrill, this encoding stores the size of the varint in the first byte; this allows for faster decoding due to less branch mispredictions. It is equally compact as Thrill's encoding.
The file header stores a feature mask so that future feature additions can be done without breaking existing files.

In this PR, support for weights, parallel reading and checksums is still missing. For weights, the structure definitions are already present but support in the writer and reader is incomplete. I want to merge the basic functionality first, before adding more advanced features.

Thank you for the review. There are quite a few things that I missed. I responded to some format-related comments above. @cndolo will probably take care of the technical comments.
Regarding deleted nodes: I must admit that I did not think about those. It would be nice if the format supported deleted nodes so that no remapping if node IDs is necessary. I think we can sacrifice one bit of the adjacency size prefix sum for this purpose.
Regarding the double encoding: This is fine from my perspective. I do not care so much about writer performance. I suspect that relying on the fact the adjacency data can be allocated at a fixed position is quite fragile -- for example, the same does not hold for weight information.

I am merging this PR. Thank you for your work @cndolo.


Wheel out of date

The wheel used for installing via pip for Tensorflow is out of date and is missing parts needed for the tutorials.
I've built from source successfully, but is very difficult to do on a machine that I don't have root access to. An updated wheel would make it much easier to do a user install of Tensorflow.

Yes, we are about to build the 0.6.0 packages that should work with all the tutorials at HEAD.  Closing because we're building them now...

I'm not sure if I understand. On the website there is a 0.6.0 wheel in the instructions,  but when I go to run the pretrained inception-v3 model, I don't find the imagenet directory:
(d)[nani@nande cat]$ pip show tensorflow
---
Metadata-Version: 2.0
Name: tensorflow
Version: 0.6.0
Summary: TensorFlow helps the tensors flow
Home-page: http://tensorflow.com/
Author: Google Inc.
Author-email<EMAIL_ADDRESS>License: Apache 2.0
Location: /home/nani/Desktop/cat/d/lib/python2.7/site-packages
Requires: six, protobuf, wheel, numpy

(d)[nani@nande cat]$ ls d/lib/python2.7/site-packages/tensorflow/models/image/
cifar10  __init__.py  __init__.pyc  mnist

Can you download the wheel again? I think this is fixed by now, but I want
to make sure.
On Thu, Dec 10, 2015 at 1:20 AM daikazoku<EMAIL_ADDRESS>wrote:

I'm not sure if I understand. On the website there is a 0.6.0 wheel in the
instructions, but when I go to run the pretrained inception-v3 model, I
don't find the imagenet directory:
(d)[nani@nande cat]$ pip show tensorflow
Metadata-Version: 2.0
Name: tensorflow
Version: 0.6.0
Summary: TensorFlow helps the tensors flow
Home-page: http://tensorflow.com/
Author: Google Inc.
Author-email<EMAIL_ADDRESS>License: Apache 2.0
Location: /home/nani/Desktop/cat/d/lib/python2.7/site-packages
Requires: six, protobuf, wheel, numpy
(d)[nani@nande cat]$ ls d/lib/python2.7/site-packages/tensorflow/models/image/
cifar10  init.py  init.pyc  mnist
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/457#issuecomment-163541754
.

imagenet model is still missing for me on Mac OS using virtualenv.

When you pip install --upgrade, also use --no-cache-dir
On Sun, Dec 27, 2015 at 12:23 PM, Roman Manukyan<EMAIL_ADDRESS>wrote:

imagenet model is still missing for me on Mac OS using virtualenv.
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/issues/457#issuecomment-167439537
.


fix spec not revert back to default when its nil

Signed-off-by: Mike Ng<EMAIL_ADDRESS>For https://github.com/open-cluster-management/backlog/issues/993

merged into release-1.0;0 as well.


testing

** removed by @dougwilson **

Thanks for the report @macqbat . This may be a security issue. I copied your report into our private repo to assess the impact and fix. You can always report possible security issues in the future by following https://github.com/expressjs/express/blob/master/Security.md
If you can email me (my email is in my public GitHub profile), I can keep you updated on the status of the fix.


fix: reset set -eo pipefail in pre-commit git hook

Codecov Report
Patch coverage has no change and project coverage change: -0.05 :warning:

Comparison is base (dea9902) 63.51% compared to head (5a12691) 63.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
- Coverage   63.51%   63.47%   -0.05%
==========================================
  Files         137      137
  Lines       26126    26132       +6
==========================================
- Hits        16595    16586       -9
- Misses       9531     9546      +15

Impacted Files
Coverage Δ

fedimint-server/src/lib.rs
73.51% <0.00%> (-1.11%)
:arrow_down:

... and 8 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Wrong flag definition in brax.training

Fix flags.DEFINE_integer('policy updates', None, Number of policy updates in APG.') to have an underscore flags.DEFINE_integer('policy_updates', None, Number of policy updates in APG.'), and maybe add a test to check if the entry-point learn runs without throwing errors during the build.
See: brax.training.learner#l124
Error that absl raises:
Apptainer> learn
Traceback (most recent call last):
  File "/usr/local/bin/learn", line 4, in <module>
    from brax.training import learner
  File "/usr/local/lib/python3.12/dist-packages/brax/training/learner.py", line 124, in <module>
    flags.DEFINE_integer('policy updates', None,
  File "/usr/local/lib/python3.12/dist-packages/absl/flags/_defines.py", line 672, in DEFINE_integer
    result = DEFINE(
             ^^^^^^^
  File "/usr/local/lib/python3.12/dist-packages/absl/flags/_defines.py", line 124, in DEFINE
    return DEFINE_flag(
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/dist-packages/absl/flags/_defines.py", line 183, in DEFINE_flag
    fv[flag.name] = flag
    ~~^^^^^^^^^^^
  File "/usr/local/lib/python3.12/dist-packages/absl/flags/_flagvalues.py", line 439, in __setitem__
    raise _exceptions.Error('Flag name cannot contain a space')
absl.flags._exceptions.Error: Flag name cannot contain a space

See https://github.com/google/brax/releases/tag/v0.11.0


[SPARQL] Rhea's RDF

Reduce need for rewriting IRIs

[ ] shares IRIs for genes
[ ] shares IRIs for proteins
[ ] shares IRIs for metabolites
See two examples (InChIKey and ChEBI) below
[ ] shares IRIs for complexes
[ ] shares IRIs for publications

PREFIX rh:<http://rdf.rhea-db.org/>
PREFIX pubmed:<http://rdf.ncbi.nlm.nih.gov/pubmed/>
SELECT ?reaction ?reactionEquation WHERE {
 ?reaction rdfs:subClassOf rh:Reaction .
 ?reaction rh:status rh:Approved .
 ?reaction rh:equation ?reactionEquation .
 ?reaction rh:citation ?cit .
 filter (?cit=pubmed:2460092)
}

Write up examples SPARQL query

[ ] write examples for the WikiPathways SPARQL book

Rhea RDF documentation

@egonw : what's the status of getting our cross-refs to WP into Rhea? I believe you discussed this with Alan Bridge
Example:
PREFIX rh:<http://rdf.rhea-db.org/>
SELECT ?reaction ?xref WHERE {
  ?reaction rdfs:subClassOf rh:Reaction .
  ?reaction rh:directionalReaction ?directionalReaction .
  OPTIONAL { ?directionalReaction rdfs:seeAlso ?xref . }
  ?reaction rh:bidirectionalReaction ?bidirectionalReaction .
  OPTIONAL { ?bidirectionalReaction rdfs:seeAlso ?xref . }
  FILTER (?reaction=rh:11932)
}

Rhea federated to Uniprot example:
PREFIX rh:<http://rdf.rhea-db.org/>
PREFIX ec:<http://purl.uniprot.org/enzyme/>
PREFIX rdfs:<http://www.w3.org/2000/01/rdf-schema#>
PREFIX skos:<http://www.w3.org/2004/02/skos/core#>
SELECT ?ecClass (str(?ecName) as ?ecClassName) (count(?reaction) as ?reactionCount) WHERE {
  SERVICE <http://sparql.uniprot.org/sparql> {
    ?ecNumber rdfs:subClassOf ?ecClass .
    ?ecClass skos:prefLabel ?ecName .
    VALUES (?ecClass) { (ec:1.-.-.-)(ec:2.-.-.-)(ec:3.-.-.-)(ec:4.-.-.-)(ec:5.-.-.-)(ec:6.-.-.-)(ec:7.-.-.-) }
  }
  ?reaction rdfs:subClassOf rh:Reaction .
  ?reaction rh:ec ?ecNumber .
}


Small cleanup and readme modification

Moved the code in /CrowdComic up to the top level, and markdown-ified the readme there.

We should have made a new feature branch specifically for the readme. Now, we have two unrelated features being combined into one branch. I suggest when we merge the documentation branch, we don't accept any incoming changes and keep it how it is in main.


Add test for TCP to verify control flags updated

Add new test script inside tests/tcp/
configure non default control flags for TCP header.
Validate the provided flags against the packet capture

Closed with #119


Add cosine argument for point cloud convolutions

Hey there!
Was just looking through the knn_graph generators in XConv and noticed that the cosine argument from torch_cluster knn_graph is not available as an option. Would it be possible to add it as an argument in XConv, etc...? Thanks!

Fixed in master.

Much appreciated, thanks!


feat(examples): Add SavedModel

Signed-off-by: Ce Gao<EMAIL_ADDRESS>
What this PR does / why we need it:
Add savedmodel fashion_model as an example
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @your-reviewer

Release note:

NONE

/assign @ddysher

/lgtm
/approve


rubbish component

Make sure these boxes are checked before submitting your issue -- thank you!

[ ] Check FAQ and Caveats
[ ] Search if there's already one reported in Issues
[ ] Prepare a JSFiddle reproducing the issue

perfect-scrollbar JSFiddle

[ ] Provide a page or source code where the issue can be checked

use so difficult


Adjust gitigniore file: add microsoft and intellij ides spcific files,…

Improve .gitingore file:

Remove rules for build-specific files which required for other developers
Add more ide-specific files

Based on #45 issue


Can't exit Universal Group Playback

What version of Music Assistant has the issue?
2.0.0b107
What version of the Home Assistant Integration have you got installed?
2.0.0b107
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
After attempting to play to a Universal Group Player (this isn't working for me, I have a separate ticket open for this), I can't get the player to stop interacting with the group.
For example, after a restart of Music Assistant, I can stream music to either one of them with no issues. I can even play two separate audio streams to my snapcast satellite and my chromecast device at the same time with no issues.
However, if I try to stream to the Universal Group Player that includes both of them, only the chromecast plays (again, separate ticket for this, so thats not the issue for this one). If I try to play something to the snapcast satellite after having attempted to play to the group, it just plays to the chromecast device, even if I specifically set "Play On" to the Snapcast device. Even if I turn off the chromecast, or even turn off the Universal Group Player, it still only streams to the chromecast no matter what.
How to reproduce
See above
Music Providers
Spotify
Player Providers
Snapcast
Chromecast
Relevant log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.3.0
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Do you have a different player you can trying grouping with the chromecast to see if this is a problem with Snapcast?

Please check if this is still an issue in b109

We will close this soon due to no followup

Confirming this is fixed with b109! Works as expected again. Thanks very much @OzGav


DOC: Update README.md (snapshots and sections)

What's wrong with the existing documentation
The current README file has the website snapshots that are outdated. And also it does not have information about sections such as testimonials and feedback.
Please assign this to me under GSSoC'23
Add ScreenShots
The snapshot of about page in the README.md file

Snapshot of the about page as per last updated website UI.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

Assign to me. I will fix it.

/assign


Documentation for using workload identity with on premise kuberentes

[Enter feedback here]
In this documentation , its stated as it supports on-premises. Can you add documentation how it can be used for on-premise kuberentes (connected with azure arc)
"Supports Kubernetes clusters hosted in any cloud or on-premises"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0c5200b5-50ef-da49-e7a0-b0fdefc78708
Version Independent ID: c9dde5dc-de8a-ba8d-2330-327b0499ac81
Content: Use an Azure AD workload identities (preview) on Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/workload-identity-overview.md
Service: container-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@kishorerv25
Thanks for your feedback! We will investigate and update as appropriate.

@kishorerv25
For you information Please refer the below in documented link
https://learn.microsoft.com/en-us/azure/aks/hybrid/overview#:~:text=the deployment process%3A-,View and manage on-premises Kubernetes using tools or Azure Arc,-Once you've set

@kishorerv25
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation


kubergrunt: init at 0.7.11

This is a helper utility which allows to configure EKS clusters etc.
Tested it locally on a NixOS machine:
❯ kubergrunt help
Usage: kubergrunt [--loglevel] [--help] command [options] [args]

A CLI tool to help setup and manage a Kubernetes cluster.

Commands:

   eks      Helper commands to configure EKS.
   k8s      Helper scripts for managing Kubernetes resources directly.
   tls      Helper commands to manage TLS certificate key pairs as Kubernetes Secrets.
   help, h  Shows a list of commands or help for one command

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@IvarWithoutBones Thanks for the feedback, addressed. Is there any tool which automatically does the formatting according to what's preferred in nixpkgs ? I used nixfmt (https://github.com/serokell/nixfmt) to do the initial formatting.

Yes, There's nixpkgs-fmt (https://github.com/nix-community/nixpkgs-fmt) which helps out a lot.
Also, would you mind squashing the commits? Other than that, this PR looks good to me :)

@IvarWithoutBones Thanks, done.


[dep-bot] Updated github.com/tidwall/gjson to v1.16.0

Updated github.com/tidwall/gjson to v1.16.0

This PR has been merged into alpha and tagged as 2.0.0-alpha-202308301053. Thanks for your contribution!