Ubuntu packaging: apt remove/purge does not stop and remove all Kontena Docker containers

IMO the kontena-* control plane containers should be docker rm'd on a normal remove: kontena-server-haproxy, kontena-server-api, kontena-server-mongo, kontena-agent.
Not entirely sure what apt purge should affect... the infrastructure kontena-etcd, weave containers? The service containers (redis-1)? The kontena data containers (kontena-etcd-data, kontena-server-mongo-data)?
apt purge kontena-agent kontena-server
The following packages will be REMOVED:
  kontena-agent* kontena-server*
0 upgraded, 0 newly installed, 2 to remove and 14 not upgraded.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n]
...
Removing kontena-agent (0.16.0.dev7-1) ...
Removed symlink /etc/systemd/system/multi-user.target.wants/kontena-agent.service.
Purging configuration files for kontena-agent (0.16.0.dev7-1) ...
Removing kontena-server (0.16.0.dev7-1) ...
Removed symlink /etc/systemd/system/multi-user.target.wants/kontena-server-haproxy.service.
Removed symlink /etc/systemd/system/multi-user.target.wants/kontena-server.service.
Removed symlink /etc/systemd/system/multi-user.target.wants/kontena-server-mongo.service.
Purging configuration files for kontena-server (0.16.0.dev7-1) ...
dpkg: warning: while removing kontena-server, directory '/opt' not empty so not removed

docker ps -a
CONTAINER ID        IMAGE                     COMMAND                  CREATED             STATUS              PORTS               NAMES
8aa745c1a111        redis:latest              "/w/w docker-entrypoi"   2 days ago          Up 2 days           6379/tcp            redis-1
3b882565f3a4        kontena/etcd:2.3.7        "/usr/bin/etcd --name"   2 days ago          Up 2 days                               kontena-etcd
8e40e229b7d0        weaveworks/weave:1.7.2    "/home/weave/weaver -"   2 days ago          Up 2 days                               weave
e000c600303e        kontena/cadvisor:0.23.2   "/entrypoint.sh --doc"   3 days ago          Up 2 days                               kontena-cadvisor
4ee858df17b3        weaveworks/weaveexec:1.7.2   "/bin/false"             2 days ago          Created                                         weavewait-1.7.2
b7c192669786        kontena/haproxy:latest       "./run.sh"               2 days ago          Exited (1) 24 seconds ago                       kontena-server-haproxy
fc3154b4a48e        kontena/server:0.16.0.dev7   "./run.sh"               2 days ago          Exited (0) 23 seconds ago                       kontena-server-api
9358a04a132e        mongo:3.0                    "/entrypoint.sh mongo"   2 days ago          Exited (0) 23 seconds ago                       kontena-server-mongo
284f2c1b80ff        kontena/agent:0.16.0.dev7    "/app/bin/kontena-age"   2 days ago          Exited (0) 25 seconds ago                       kontena-agent
86a752ffbfd6        kontena/etcd:2.3.7           "/usr/bin/etcd"          2 days ago          Created                                         kontena-etcd-data
b171d9e6067e        weaveworks/weavedb           "data-only"              2 days ago          Created                                         weavedb
bb346a426e4e        mongo:3.0                    "/entrypoint.sh mongo"   3 days ago          Created                                         kontena-server-mongo-data

apt-get purge is supposed to wipe all config files installed by the package. Wherever the debconf questions store their answers, they should go.


feature: add glossary layout

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

LGTM label has been added.  Git tree hash: 57d1ad6fdc9e0928be3da2ad994961498b9af737

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, vjjmiras
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


How to use @shopify/react-google-analytics ?

Hello anyone, i now create a shopify apps, and i need to track my apps with package @shopify/react-google-analytics.
Can someone give me example to use this package ?
Thankyou before,
Im using React

There is some documentation here that might help you.

@fataaaaaa please take a look at the documentation @thecodepixi posted and open an issue if you encounter any problems. Closing this question for now.


“SOLID Principles in Ruby” blog post errata

Really enjoyed the article and how it conveyed SOLID in only a couple of short paragraphs. @zamith
Couple of minor things that caught my attention. Marked ideas for corrections in bold. It’s all in chronological order:
That's why, as with many things in the software area, you should use these principles as guidelines, not rules. One of the most well known sets of OO design principles is known by an acronym, SOLID. It stands for:
Let's take a look at each of them individually, and how you can use them to increase your code's quality in Ruby.
Probably the most well known principle, and one that you should try to adhere to most of the time.
The AuthenticatesUser class is responsible for authenticating the user as well as knowing if the email and password match the ones in the database. It has two responsibilities, and according to the principle it should only have one. Let’s extract one:
I've used a refactoring technique called Extract Class and then used it on the original class I already had**. This** is called sharing behaviour through composition.
Thus I have extended the functionality without modifying the code. In this example, I have used a technique called Dependency Injection, but many others could apply.
This principle applies only to inheritance, so let's look at an example of inheritance that breaks it:
So, they must have the same interface. Since Ruby does not have abstract methods, we can do it like so:
We can solve it the exact same way we solved it on the OCP problem, with dependency injection:
I've covered (slightly touched) five principles that when followed will almost guaranteed improve the quality of your code**. There** are many others though, and sometimes it makes more sense to break a principle than to follow it.
Hope this was helpful and not coming off as pedantic or anything. A PR would have been a bit more smooth for both of us I guess :)
Cheers!

Thanks for taking the time to do this.
I've incorporated most of the comments, so I'm closing the issue.

Sure, anytime! :)
-- on the go --

On 23.07.2015, at 11:47, Luís Ferreira<EMAIL_ADDRESS>wrote:
Thanks for taking the time to do this.
I've incorporated most of the comments, so I'm closing the issue.
—
Reply to this email directly or view it on GitHub.


Update git_refs.go

Fix a segfault when fetching refs from github returns an error (say due to connectivity)

I'm surprised this was not caught months ago

@gmlewis I was only playing with this part of the API - so there may be similar issues in other calls?
Also feel free to squash the commits on merge :)

Thank you, @gauntface!
Merging then bumping minor version due to bug fix.


Error attempting to install Current Version of pyodbc on Debian Buster (Linux) using Python 3.7

Python: 3.7
pyodbc: 4.0.35
OS: Debian Buster
DB: hopefully access.mdb files
driver:

Error attempting to install current version of pyodbc using  $ pip install pyodbc  on Debian Buster using Python 3.7.
Also, $ pip3 install pyodbc   similarly fails. The only successful install of pyodbc
on Debian seems to be with the sudo apt-get install command as per:
$ sudo apt-get install python3-pyodbc python3-pyodbc-dbg
However, the above sudo command only installs a 4.5 year old or so pyodbc version 4.0.22:
Setting up python3-pyodbc (4.0.22-1+b1) ...
Setting up python3.7-dbg (3.7.3-2+deb10u4) ...
Any helpful suggestions would be appreciated! Thank you.
Error details below:
$ pip install pyodbc
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting pyodbc
Using cached pyodbc-4.0.35.tar.gz (273 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Installing backend dependencies ... done
Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pyodbc
Building wheel for pyodbc (pyproject.toml) ... error
error: subprocess-exited-with-error
Building wheel for pyodbc (pyproject.toml) did not run successfully.
exit code: 1
[14 lines of output]
running bdist_wheel
running build
running build_ext
building 'pyodbc' extension
creating build
creating build/temp.linux-i686-cpython-37
creating build/temp.linux-i686-cpython-37/src
i686-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -flto -fuse-linker-plugin -ffat-lto-objects -fPIC -DPYODBC_VERSION=4.0.35 -I/usr/include/python3.7m -c src/buffer.cpp -o build/temp.linux-i686-cpython-37/src/buffer.o -Wno-write-strings
In file included from src/buffer.cpp:12:
src/pyodbc.h:56:10: fatal error: sql.h: No such file or directory
#include <sql.h>
^~~~~~~
compilation terminated.
error: command '/usr/bin/i686-linux-gnu-gcc' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for pyodbc
Failed to build pyodbc
ERROR: Could not build wheels for pyodbc, which is required to install pyproject.toml-based projects

What does pip --version report?

The fix for a missing "sql.h" file is to apt install unixodbc-dev


FancyZones 20.1 reports malformed layout bug on saved custom templates

ℹ Computer information

PowerToys version: 0.20.1
PowerToy Utility: Fancy Zones
Running PowerToys as Admin: Yes
Windows build number:: 2004

📝 Provide detailed reproduction steps (if any)

create custom layout
save custom layout
load that custom layout later with your hotkey
Note - one other issue is that I can no longer save a custom layout as a new layout.  Instead, it overrides one of the existing custom layouts

✔ Expected result
Being able to use the layout
❌ Actual result
Error per screenshot below
📷 Screenshots

@mobelby
we made some change sin 0.21.1 https://github.com/microsoft/PowerToys/releases/download/v0.21.1/PowerToysSetup-0.21.1-x64.exe
Is this still happening for you?

@mobelby
we made some change sin 0.21.1 https://github.com/microsoft/PowerToys/releases/download/v0.21.1/PowerToysSetup-0.21.1-x64.exe
Is this still happening for you?

I think this is cured.
However, I still can't create a new custom template from an existing one without overriding and losing the previous one

@mobelby

However, I still can't create a new custom template from an existing one without overriding and losing the previous one

This feature is not implemented yet, and there is an open issues tracking it.
I'll close this issue for now, please reopen if it will happen again.


Analog In not recognized

For some reason, whenever i try to use any of the analog in pins, it says it does not exist. The digital pins work just fine but cannot figure out why it's doing this, any help would be greatly appreciated.

That's odd... does it happen with the analog_test.py example program? If it's just your own code that's not working then post that here.
What image are you using? And what's the output of $ uname -a?

Yeah, it doesn't work in any program that references an analog pin; it just gives "Value Error: invalid GPIO pin". The disk image is the Wheezy debian image. The output for uname- a gives "Linux beaglebone 3.8.13-bone80".
thanks for the help!

oh wait! my bad, so i copied the program but didn't pay much attention to the set up and assumed that you had to identify the pin as an input (not sure why) and that must have messed it up cause it works now when i just do the "pass" keyword in the setup.  Thanks! This actually still helped me to look at it again, sorry !

Glad you got it working!


[xas_viewer] Disable automatic check for updates or make it user settable

@newville, on beamline machines where Larch is installed system-wide (binary or from source) we often have problems with the automatic check for updates. If we do not update Larch promptly after a release, it happens that either the users are annoyed to see this banner at each startup of xas_viewer or even worst that they click on OK button and install a local version of Larch that then goes into conflicts with what was installed before or breaks things that are tricky to debug (due to the fact that the installer calls pip install --upgrade xraylarch).
What about if we simply change check_version=False by default? Or add an option in LarchUpdaterDialog (or in the preferences) that will not check for new version at startup?

@maurov Good suggestion - I will change XAS Viewer to inform of new versions being available in the status bar.

@maurov But also:
pip install --upgrade xraylarch  is not actually the problem.   On Windows, it is a system error to try to overwrite an open executable.  So basically, having an automatic update of a program from a program is not possible -- one could update libraries and files loaded, but not the actual .exe file.   So, auto-updates on Windows from XAS Viewer were always failing.
I had already changed XAS Viewer "update" to either have the user copy and paste the pip command into a terminal, or to run the now-installed Desktop App "Larch Updater".
But, the version of 0.9.68 (or anything earlier) still has this problem, so updating to 0.9.70 will still require manual intervention and "pip update", and then things will be better...
FWIW, conda does not solve this problem.  It's not pip.  It's Windows.

@newville thanks for considering this issue.
Our case is on Linux, where I usually install Larch from source in a conda environment with an administrator account. If the user does the upgrade via pip on a user account, then two Larch versions get installed and this creates a mess. I need then to manually remove the user's local version and update the admnistrator's one separately.
I agree that conda will not solve this problem neither.

@maurov Ah, yeah mixing admin and user accounts is definitely a problem too.  I know that some folks at the APS also want admin-installed system-wide installs (using debian packages + pip).
Anyway, turning down the notifications and making them informative should help....

@maurov I think we can close this.


[2.0] Merge ClassMetadataInfo into ClassMetadata

This closes #1727 by merge ClassMetadataInfo into ClassMetadata as suggested by @alcaeus in #1714

Thanks @carusogabriel, sorry for long merging I must have overlooked notification about last change you did :)

@malarzm NP, now, let's finish #1714 :construction:


Create a list of environment variables used by fybrik

Create a list of environment variables used by fybrik. It can be published on fybrik.io under references.

Environment variables used for Fybrik deployment? Or environment variables used by various pods in the control plane within configmaps and secrets?

I meant environment variables used for Fybrik development and deployment. (if any)

close for now.


Way to distinguish pytest tests when one function name is a prefix of another

Pytest test selection using -k, which is what I have been using to isolate only one test for execution, doesn't work well when there are parentheses in the test name, e.g. "test_foundry_prove[AssertTest.test_assert_false()]",  so to select this test I have to use something like poetry run pytest src/tests/integration --verbose -k "test_foundry_prove[AssertTest.test_assert_false". But this doesn't work well when there is another test function in the same contract, say, called test_assert_false_1(), since using this workaround "test_foundry_prove[AssertTest.test_assert_false" will also match this other test.

This issue is still present.
If you run a test like
make test-integration TEST_ARGS+=' -k test_foundry_prove -k EnvTest.testEnvBool '

then pytest will run all the tests that match the provided name.
If you run it like
make test-integration TEST_ARGS+=' -k test_foundry_prove -k EnvTest.testEnvBool() '

then it complains about ( causing a syntax error
and if you add double quotes or escape the paranthesis like
make test-integration TEST_ARGS+=' -k test_foundry_prove -k "EnvTest.testEnvBool()" '

or
make test-integration TEST_ARGS+=' -k test_foundry_prove -k EnvTest.testEnvBool\(\) '

you get an internal error
INTERNALERROR> RuntimeError: Unexpectedly no active workers available

The INTERNALERROR> RuntimeError: Unexpectedly no active workers available goes away if numprocesseses is set to 0; But another error appears
poetry run pytest src/tests/integration --maxfail=1 --verbose --durations=0 --numprocesses=0 --dist=worksteal -k test_foundry_prove -k "EnvTest.testEnvBool()"
================================ test session starts ================================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.4.0 -- /home/anvacaru/.cache/pypoetry/virtualenvs/kontrol-JS8qu14X-py3.10/bin/python
cachedir: .pytest_cache
rootdir: /home/anvacaru/rv/kontrol/master
plugins: cov-4.1.0, timeout-2.2.0, mock-3.12.0, pyk-0.1.611, xdist-3.5.0
collected 330 items

=============================== no tests ran in 0.12s ===============================
ERROR: Wrong expression passed to '-k': EnvTest.testEnvBool(): at column 20: expected end of input; got left parenthesis


PowerToys Run: Inaccurate search results. [Feature suggestions]

Earlier versions can use the first letter of Chinese Pinyin as an index of Chinese search results, but this feature was removed later, which makes PowerToys Run's practicality on the Chinese system greatly compromised.

Pinyin  support is tracked by https://github.com/microsoft/PowerToys/issues/3587


Unable to filter records by @request.query.*

I have a list rule set up for my custom files collection,
@request.query.workspace = workspace || default = true

which is intended to allow users to access records if they know the workspace ID (workspace is a different collection) or if the record is marked as public (with default = true). However, this setup consistently returns an empty list. In the logs, I can see that it generates a suspicious query:
[0.00ms] SELECT `files`.* FROM `files` WHERE ((('' = [[files.workspace]] OR [[files.workspace]] IS NULL) OR [[files.default]] = 1)) AND ([[files.workspace]] = '5aw4ef0dyzq1ozk') LIMIT 200

This query always results in an empty list because no record has both default set to true and workspace set to '5aw4ef0dyzq1ozk'. What's interesting is that if I change the list rule to:
@request.query.workspace = workspace || default = false

It generates the following query:
[0.00ms] SELECT `files`.* FROM `files` WHERE ((('' = [[files.workspace]] OR [[files.workspace]] IS NULL) OR [[files.default]] = 0)) AND ([[files.workspace]] = '5aw4ef0dyzq1ozk') LIMIT 200

This query returns records with the provided ID but does not allow access to records with default set to true.
If I remove the default parameter and set the rule to:
@request.query.workspace = workspace

The generated query looks like this:
[0.00ms] SELECT `files`.* FROM `files` WHERE ((('' = [[files.workspace]] OR [[files.workspace]] IS NULL))) AND ([[files.workspace]] = '5aw4ef0dyzq1ozk') LIMIT 200

This query also returns an empty list because the expressions on both sides of the AND contradict each other.
I'm using Pocketbase v0.18.2, and it seems like there might be an issue with query generation. I'm not entirely sure, so I would appreciate advice on how to achieve my desired outcome.

At first glance, the generated queries seems correct to me. Could you paste your collection configurations as JSON (Admin UI > Settings > Export collections) so that I can try to reproduce it?

I've just tested it locally with the below collection structure and I'm not able to reproduce it.
{
    "id": "594xmcdfvo0ugye",
    "name": "test",
    "type": "base",
    "system": false,
    "schema": [
        {
            "system": false,
            "id": "oerxjfnl",
            "name": "default",
            "type": "bool",
            "required": false,
            "presentable": false,
            "unique": false,
            "options": {}
        },
        {
            "system": false,
            "id": "oeo5oqgm",
            "name": "workspace",
            "type": "relation",
            "required": false,
            "presentable": false,
            "unique": false,
            "options": {
                "collectionId": "yyd498z52k3qi59",
                "cascadeDelete": false,
                "minSelect": null,
                "maxSelect": 1,
                "displayFields": null
            }
        }
    ],
    "indexes": [],
    "listRule"<EMAIL_ADDRESS>= workspace  || default = true",
    "viewRule": null,
    "createRule": null,
    "updateRule": null,
    "deleteRule": null,
    "options": {}
}

Make sure that you are sending the query parameter properly because in your case it seems that it is an empty string.
If you are still not able to identify the issue please export your collections configuration and how you are sending the request and I'll try to investigate it further.

Also the final part of your query logs ([[files.workspace]] = '5aw4ef0dyzq1ozk') doesn't look correct if you only provide the workspace as query parameter.

Hmm, you're actually right. GET http://localhost:8090/api/collections/test/records?workspace=YOUR_ID does return what I want. How do I achieve the same using pocketbase js client? I was testing it with
const fetchedData = await pb.collection("files").getFullList({
  filter: `workspace="${workspaceId}"`,
});

and it generated query http://<IP_ADDRESS>:8090/api/collections/files/records?page=1&perPage=500&skipTotal=1&filter=workspace%3D%225aw4ef0dyzq1ozk%22, which returns empty list.

Pass the workspace as plain query parameter, something like:
const fetchedData = await pb.collection("files").getFullList({
  workspace: workspaceId,
});

Oh, didn't realise I can do that. Works like charm, thank you for the rapid response!


Play video with sound

Playing videos with sound works great if using CMD_PLAYVIDEO with OPT_SOUND, but it uses the full screen and no other graphics can be used.
Much more interesting option is using CMD_VIDEOSTART / CMD_VIDEOFRAME and it also works without issues.
The problem is, when playing the video that way, it looks there is no way to get the sound!
CMD_VIDEOSTART takes no options, I was looking everywhere and couldn't find any way to enable sound with CMD_VIDEOSTART.
It looks like FT81x designers just forgot to enable that feature. Is there any solution?

There is no solution friend. Be a problem with the design of the FT81x chip

Please see my repo https://github.com/Gjepali/gd23zu - I had modified your old library primary for video playback. Your code is really good, but really slow on SPI. Compare wiring.h, GD23ZU.h and GD23ZU.cpp. I tested it on F103 and F405. I tried to run it on F205, but there was problem with DMA on Arduino libraries for HAL.

Turn on external crystal for FT81x for audio output - internal oscillator as usually has bad duty cycle and PWM output for audio is not clear.
SPI data is sent byte by byte - DMA is much more fastest (with no delay between bytes).
I'm using SdFatEX (with bigger buffer) insteed of SdFat for  F103 and SdFatSdio for F405 insteed of SdFat
TAM_BUFFER_SD=32768 for F405
added backlight dimming support
touch calibration -> stored in internal flash (eeprom emulation)
MoviePlayer routine and buffer modified
Arduino Code: added HAL_SD_MODULE_ENABLED in Arduino packages ...\variants<YOUR BOARD NAME>\variant.h
STM32GENERIC: comment all DMA1_ChannelX_IRQ definition in STM32GENERIC-master\STM32\libraries\stm32_dma_F0F1F3L1.h -> this is multiple definition!!!
STM32GENERIC: _useDMA = false; in STM32GENERIC-master\STM32\libraries\SDIO\src\SDIO.cpp - do not block DMA here!!!
format SD card with FAT32 and choose largest block size for better read performance
use ffmpeg.exe to convert video file to MotionJPEG and mono PCM audio, but do not use full resolution !!! (example for 800x480px LCD: ffmpeg -i in.mp4 -vf eq=gamma=1,scale=790:470:force_original_aspect_ratio=decrease,pad=790:470:-1:-1:color=black -b:v 10000k -pix_fmt yuvj420p -ac 1 -acodec pcm_s16le -ar 44100 -af dynaudnorm=f=10:g=3:p=1.0,afade=t=in:st=0:d=0.5,areverse,afade=t=in:st=0:d=0.5,areverse -threads 1 -vcodec mjpeg out.avi)

STM32F405: speed from SD (sdio 24 MHz) to MCU is ~10,2 MB/s

you can double speed (~21 MB/s) by bypass sdio clock:
#define SDIO_CLOCK_BYPASS_SET()     SDIO->CLKCR |= SDIO_CLKCR_BYPASS_Msk | SDIO_CLKCR_PWRSAV_Msk
#define SDIO_CLOCK_BYPASS_RESET()   SDIO->CLKCR &= ~(SDIO_CLKCR_BYPASS_Msk | SDIO_CLKCR_PWRSAV_Msk)
but it works only with STM32, not with clones like APM32
this 48 MHz clock is above STM32 limit, but works....
24 MHz works well with 60 cm SD extender from Adafruit, but 48 MHz don't work
STM32F405: speed from MCU (SPI) to FT81x is ~3,6 MB/s
STM32F405: speed from SD to FT81x (SDIO + SPI) is ~2,6 MB/s
tight throat (the slowest) is SPI to EVE... it needs QSPI, but mainstream MCU don't have SDIO and QSPI simultaneously...

Hope it helps someone....

STM32GENERIC has a few limitations and some bugs. It would be great to migrate to better library... stm32duino. I was trying to use CDC and Mass Storage simultaneously with STM32GENERIC, but it's not easy to modify it... stm32duino can do it, and it has bigger MCU support.
It would be great to migrate your GDSTx to stm32duino and use my modification for better performace in STM32.

Go ahead with the GTx adjustments. It would be interesting to see a better
response in STM32. I have a Core7XXi (STM32F746) with a 5" BT815 Matrix
Orbital screen. The library can use a second SPI bus of the STM32, to
access the external reader with an exFAT memory, using the most recent
version of Greiman's SdFat library .
It would be very good if you indicated how the components should be
connected and how to use your modified library in the Arduino IDE.
Greetings and waiting for the progress of your project
El mié, 7 feb 2024 a las 9:39, Gjepali @.***>)
escribió:

STM32GENERIC has a few limitations and some bugs. It would be great to
migrate to better library... stm32duino. I was trying to use CDC and Mass
Storage simultaneously with STM32GENERIC, but it's not easy to modify it...
stm32duino can do it, and it has bigger MCU support.
It would be great to migrate your GDSTx to stm32duino and use my
modification for better performace in STM32.
—
Reply to this email directly, view it on GitHub
https://github.com/FT81xMania/GD23ZU/issues/2#issuecomment-1932313458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHQZ7MHQU74QWY6EBMQV23DYSON3PAVCNFSM4FQWB2MKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJTGIZTCMZUGU4A
.
You are receiving this because you commented.Message ID:
@.***>


visualize data with matplotlib

made the naming of files consisten. All image files containing labels… now have 'labels' in name
@anwai98 or @constantinpape could you have a look?

@anwai98 could you have a look at it? I also need some feedback for the visualization of "nucleus_labels"

data-visualization.ipynb looks good to me.
Re: nucleus labels: They look like they are instances (each having a unique id) (I can recommend visualizing the instance labels using random color maps for the instances, that way the idea of having different instance is pronounced)

@constantinpape Now the changes should be according to what we discussed.

Thanks!


[IntelliJ Plugin] Add support to view lang server trace logs and improve plugin notifications

Purpose
This PR adds improvements related to language server logs and auto detection notifications. It also adds minor improvements related to plugin configurations/settings.
Fixes #21214.
Fixes #21173.
Remarks

Related PR - #21221

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #21228 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21228   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1398     1398
  Branches      214      214
=======================================
  Hits          204      204
  Misses       1178     1178
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428a71a...dce2ea0. Read the comment docs.

Thanks @Shan1024!


reset entry to [] after we don't need it

I'm trying to use gulp-webpack with wallaby, and I found that in some cases, entry = 'string', which doesn't have .push so it fails on line 73.

Thanks!


Look into facilitating a distinct admin boundary file for each admin level layer

In the case of our regional deployment in West & Central Africa (RBD), we're working with admin level layers that could have a unique admin boundary file. For example, an admin level layer file for May 2020 may have a different definition of admin boundaries than an admin level layer file for May 2021.
We'll need to allow for a configuration option for admin level layers that specifies an admin boundary file as well. We'll also need to consider the downstream implications of this change such as the inputs for spatial analysis
cc: @olanderb

This issue is linked to solve the grouping of similar layers https://github.com/WFP-VAM/prism-frontend/issues/122

Some additional input:

Add an attribute in the admin_level layer which is optional for a unique boundary file. We can call simply call it 'boundary'
We can use the id of the boundary file which has been setup in layers.json
When the admin_level layer is selected, it should unload the previous boundary file(s) and then display the unique boundary file
When the admin_level layer is deselected, it should unload the unique boundary file and then reload the default boundary display


remove console.log statement in onDrop

otherwise there is too much logging in the console

Thanks for the awesome plugin! Very smooth stuff...

Oops :) thanks for the PR

Thanks!


macOS Update review

Hello there!
Please update the latest macOS Monterey version from 12.7.4 to 12.7.5
Thank you

that was auto updated.

please note that automation runs ones a day


Gracefully handle missing GitHub avatars

Currently, when retrieving the recent commits for a project, recent commits don't look too great when data is missing.

After bb1d3f3...

More work needs to go into this before I close the issue.


About High Resolution

Hi there!!!
I'm one of the users who are impressed to find your great project.
As a way out of the current situation of not being able to handle PureRef files, I have decided to import scenes exported with PureRef features into DroidRef.
*Vertical resolution 20000px (PureRef's default setting)
However, I encountered a problem here.
When I load a high resolution image in DroidRef, it becomes blurry.
Is this a problem limited to one version or model of Android?
Or is this a problem that can be fixed?
I hope you can help!

Very large images (greater than 2000 by 2000 pixels) are downscaled, because I ran into performance issues with rendering them. Since you're using PureRef it might be a better idea to implement PureRef import support instead (#4).

I can't thank you enough for recreating PureRef on android despite your busy days.
I hope this project will grow more and more:)


MIT vs UNLICENSE

Discussion on whether to use UNLICENSE or MIT. I am thinking about switching to MIT based on what I heard in r/dotnet. What do you guys think about this idea? If there are no objections I will switch

keep your current license

Make it anything but UNLICENSE. Asap.  MIT is fine.

Switched to MIT


iOS Build Error on Flutter 1.20.0-1.0.pre

I upgraded to Flutter 1.20.0-1.0.pre this evening. Ever since that, I can't compile my app whoch uses the flutter_advanced_networkimage plugin.
FLUTTER DOCTOR
[✓] Flutter (Channel dev, 1.20.0-1.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
[✓] Android Studio (version 4.0)
[!] IntelliJ IDEA Community Edition (version 2019.3.1)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.42.1)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

LOGS
Running Xcode build...
Xcode build done.                                           26.2s
Failed to build iOS app
Could not build the application for the simulator.
Error launching application on iPhone 11 Pro Max.
Error output from Xcode build:
↳
** BUILD FAILED **

Xcode's output:
↳
/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:88:26: Error: Type 'DiagnosticableMixin' not found.
class PictureStream with DiagnosticableMixin {
                         ^^^^^^^^^^^^^^^^^^^
/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:192:44: Error: Type 'DiagnosticableMixin' not found.
abstract class PictureStreamCompleter with DiagnosticableMixin {
                                           ^^^^^^^^^^^^^^^^^^^
/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:88:7: Error: The type 'DiagnosticableMixin' can't be mixed in.
class PictureStream with DiagnosticableMixin {
      ^
/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:192:16: Error: The type 'DiagnosticableMixin' can't be mixed in.
abstract class PictureStreamCompleter with DiagnosticableMixin {
               ^
/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:167:11: Error: Superclass has no method named 'debugFillProperties'.
    super.debugFillProperties(properties);
          ^^^^^^^^^^^^^^^^^^^
/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:171:30: Error: The method 'toStringShort' isn't defined for the class 'PictureStreamCompleter'.
 - 'PictureStreamCompleter' is from 'package:flutter_svg/src/picture_stream.dart' ('/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart').
Try correcting the name to the name of an existing method, or defining a method named 'toStringShort'.
      ifPresent: _completer?.toStringShort(),
                             ^^^^^^^^^^^^^
/Applications/Flutter-SDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:266:11: Error: Superclass has no method named 'debugFillProperties'.
    super.debugFillProperties(description);
          ^^^^^^^^^^^^^^^^^^^

Command PhaseScriptExecution failed with a nonzero exit code
note: Using new build system
note: Building targets in parallel
note: Planning build
note: Constructing build description
warning: Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the Runner editor. (in target 'Runner' from project 'Runner')

I see this issue in Android as well

Yes, I think if you can update the plugin to use flutter_svg 0.18.0 it will fix the issue.


Optimize counts on two clause term disjunctions

Calculate count(clause1 OR clause2) as count(clause1) + count(clause2) - count(clause1 AND clause2)  as discussed in https://github.com/apache/lucene/issues/12644.
Todo:

Add term clause count threshold to apply this optimization when it improves performance
Add termstate cache
Update nightly benchmarks to either have deletes or add tasks on disjunctions of 3 terms or more to retain coverage on actual disjunction counts

Output from luceneutil.
The count tasks:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                 CountAndHighMed       87.21      (1.6%)       86.66      (2.3%)   -0.6% (  -4% -    3%) 0.313
                CountAndHighHigh       23.33      (1.5%)       23.42      (1.3%)    0.4% (  -2% -    3%) 0.396
                 CountOrHighHigh       42.71      (1.8%)       42.93      (1.8%)    0.5% (  -3% -    4%) 0.382
                  CountOrHighMed       42.46      (1.5%)       42.74      (1.8%)    0.7% (  -2% -    4%) 0.204

Full output:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
          OrHighMedDayTaxoFacets        5.77      (4.1%)        5.60      (6.7%)   -3.1% ( -13% -    8%) 0.081
                          IntNRQ       95.26     (11.4%)       92.46     (13.5%)   -2.9% ( -24% -   24%) 0.456
       BrowseDayOfYearSSDVFacets        7.05     (13.7%)        6.89      (5.5%)   -2.3% ( -18% -   19%) 0.486
             LowIntervalsOrdered       10.54      (6.6%)       10.37      (6.9%)   -1.7% ( -14% -   12%) 0.434
             MedIntervalsOrdered       11.90     (10.3%)       11.71     (11.9%)   -1.6% ( -21% -   22%) 0.639
            HighIntervalsOrdered       11.92      (9.1%)       11.76     (10.5%)   -1.3% ( -19% -   20%) 0.667
     BrowseRandomLabelSSDVFacets        6.16      (8.6%)        6.09      (7.8%)   -1.2% ( -16% -   16%) 0.648
            MedTermDayTaxoFacets       11.06      (3.5%)       10.96      (2.9%)   -0.8% (  -6% -    5%) 0.403
                 CountAndHighMed       87.21      (1.6%)       86.66      (2.3%)   -0.6% (  -4% -    3%) 0.313
                        PKLookup      290.76      (2.3%)      290.12      (1.7%)   -0.2% (  -4% -    3%) 0.727
        AndHighHighDayTaxoFacets       30.24      (1.6%)       30.21      (1.6%)   -0.1% (  -3% -    3%) 0.863
                      HighPhrase       23.56      (3.8%)       23.54      (4.9%)   -0.1% (  -8% -    8%) 0.951
                HighSloppyPhrase        8.59      (2.6%)        8.59      (3.0%)   -0.1% (  -5% -    5%) 0.929
         AndHighMedDayTaxoFacets       51.89      (1.8%)       51.86      (2.1%)   -0.1% (  -3% -    3%) 0.916
               HighTermTitleSort      269.41      (3.2%)      269.30      (2.2%)   -0.0% (  -5% -    5%) 0.962
                        Wildcard      116.25      (2.3%)      116.22      (2.3%)   -0.0% (  -4% -    4%) 0.969
                    HighSpanNear       12.27      (1.5%)       12.27      (1.2%)   -0.0% (  -2% -    2%) 0.953
                     MedSpanNear        5.92      (2.0%)        5.92      (0.8%)   -0.0% (  -2% -    2%) 0.997
                     AndHighHigh       97.01      (4.2%)       97.08      (2.8%)    0.1% (  -6% -    7%) 0.945
                 MedSloppyPhrase        7.86      (2.0%)        7.86      (2.0%)    0.1% (  -3% -    4%) 0.875
           HighTermDayOfYearSort      351.66      (2.5%)      352.13      (2.2%)    0.1% (  -4% -    4%) 0.855
                    OrHighNotMed      537.02      (4.9%)      538.06      (4.4%)    0.2% (  -8% -    9%) 0.895
                      AndHighMed      103.19      (4.0%)      103.42      (3.1%)    0.2% (  -6% -    7%) 0.843
                      TermDTSort      246.04      (4.3%)      246.58      (3.6%)    0.2% (  -7% -    8%) 0.858
           BrowseMonthSSDVFacets        6.80      (6.4%)        6.82      (6.3%)    0.2% ( -11% -   13%) 0.903
                         Prefix3      274.04      (1.2%)      274.81      (1.5%)    0.3% (  -2% -    3%) 0.524
                   OrHighNotHigh      633.25      (3.8%)      635.21      (3.0%)    0.3% (  -6% -    7%) 0.773
                 LowSloppyPhrase       33.19      (2.3%)       33.30      (2.1%)    0.3% (  -4% -    4%) 0.651
                CountAndHighHigh       23.33      (1.5%)       23.42      (1.3%)    0.4% (  -2% -    3%) 0.396
                     LowSpanNear       43.51      (1.3%)       43.72      (1.0%)    0.5% (  -1% -    2%) 0.193
                    OrHighNotLow      556.09      (4.7%)      558.71      (4.7%)    0.5% (  -8% -   10%) 0.749
                 CountOrHighHigh       42.71      (1.8%)       42.93      (1.8%)    0.5% (  -3% -    4%) 0.382
                          Fuzzy1      100.31      (1.2%)      100.83      (1.2%)    0.5% (  -1% -    2%) 0.179
                         Respell       60.42      (2.2%)       60.74      (1.9%)    0.5% (  -3% -    4%) 0.422
                       MedPhrase      401.96      (2.6%)      404.29      (3.2%)    0.6% (  -5% -    6%) 0.535
                      OrHighHigh       33.17      (4.0%)       33.38      (4.3%)    0.6% (  -7% -    9%) 0.629
                  CountOrHighMed       42.46      (1.5%)       42.74      (1.8%)    0.7% (  -2% -    4%) 0.204
                          Fuzzy2       98.46      (1.2%)       99.16      (1.5%)    0.7% (  -1% -    3%) 0.094
                    OrNotHighMed      571.29      (3.9%)      575.34      (4.1%)    0.7% (  -6% -    9%) 0.574
                       OrHighLow      518.27      (3.2%)      522.09      (3.5%)    0.7% (  -5% -    7%) 0.485
                       LowPhrase       75.03      (3.2%)       75.64      (3.4%)    0.8% (  -5% -    7%) 0.438
                         LowTerm      673.89      (3.7%)      679.63      (3.7%)    0.9% (  -6% -    8%) 0.466
                    OrNotHighLow     1135.09      (3.3%)     1145.12      (2.9%)    0.9% (  -5% -    7%) 0.362
                   OrNotHighHigh      418.14      (4.5%)      422.34      (3.7%)    1.0% (  -6% -    9%) 0.438
            BrowseDateTaxoFacets        7.61      (5.1%)        7.69      (3.1%)    1.0% (  -6% -    9%) 0.438
                       OrHighMed      169.72      (3.4%)      171.77      (3.8%)    1.2% (  -5% -    8%) 0.294
       BrowseDayOfYearTaxoFacets        7.69      (5.3%)        7.78      (3.5%)    1.2% (  -7% -   10%) 0.393
                      AndHighLow      555.24      (6.2%)      562.09      (6.7%)    1.2% ( -11% -   15%) 0.546
               HighTermMonthSort     4117.73      (7.2%)     4179.12      (6.2%)    1.5% ( -11% -   16%) 0.484
            BrowseDateSSDVFacets        1.66     (14.8%)        1.69     (16.3%)    1.5% ( -25% -   38%) 0.755
           BrowseMonthTaxoFacets       11.89     (21.5%)       12.08     (22.2%)    1.5% ( -34% -   57%) 0.824
                        HighTerm      655.52      (5.6%)      667.01      (6.8%)    1.8% ( -10% -   15%) 0.376
     BrowseRandomLabelTaxoFacets        7.33      (3.6%)        7.46      (3.6%)    1.8% (  -5% -    9%) 0.120
                         MedTerm      979.29      (5.4%)     1005.05      (6.1%)    2.6% (  -8% -   14%) 0.148
            HighTermTitleBDVSort       12.34      (8.1%)       12.72     (12.1%)    3.1% ( -15% -   25%) 0.348

This is a great speedup on CountOrHighMed! Too bad it's not faster all the time, though I'm not too surprised as conjunctions have more overhead than disjunctions when all clauses have a high cost.
As a first step, maybe we can have a simple heuristic to only enable this optimization when it's almost guaranteed to yield a speedup? I'm not sure what makes the most sense, maybe a threshold on the minimum count across both clauses, and only enabling the optimization below this threshold. You'll probably need to play with various disjunctions to figure out a threshold that works.
One inefficiency that your PR introduces is that it requires more lookups in terms dictionaries. We could avoid this by caching the TermState for each term query, which you could do in your rewriteTwoClauseDisjunctionWithTermsForCount() utility method: if the TermQuery has a null TermQuery#getTermStates(), then you could rewrite it to a TermQuery that has a non-null TermStates object.
And maybe as a follow-up we could look again into the old idea of using bitsets to evaluate dense conjunctions, just like BooleanScorer does for disjunctions.

Thanks for the review!
Great ideas! I will work on adding a simple heuristic and caching the TermState.

I added code to only apply the optimization if count(term-with-less-docs)/count(term-with-more-docs) < 0.1 and it yielded a way better result. Will investigate the term cache idea too since there is still a slowdown of CountHigHigh.
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                 CountOrHighHigh       43.48      (3.1%)       42.94      (3.1%)   -1.2% (  -7% -    5%) 0.201
                 CountAndHighMed      117.33      (1.6%)      116.68      (2.2%)   -0.6% (  -4% -    3%) 0.357
                CountAndHighHigh       13.40      (1.4%)       13.34      (1.6%)   -0.5% (  -3% -    2%) 0.305
                  CountOrHighMed       44.02      (2.4%)       85.10      (4.3%)   93.3% (  84% -  102%) 0.000

                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
            HighIntervalsOrdered        2.45     (15.8%)        2.37     (16.8%)   -3.3% ( -30% -   34%) 0.526
            BrowseDateSSDVFacets        1.77      (9.7%)        1.71     (13.2%)   -3.1% ( -23% -   21%) 0.394
                          IntNRQ       26.64      (9.5%)       25.91     (13.2%)   -2.8% ( -23% -   22%) 0.447
               HighTermMonthSort     4247.44      (5.4%)     4174.43      (6.8%)   -1.7% ( -13% -   11%) 0.379
             MedIntervalsOrdered        4.40      (9.0%)        4.34      (9.3%)   -1.5% ( -18% -   18%) 0.597
                    OrNotHighLow     1013.74      (2.8%)     1000.22      (4.0%)   -1.3% (  -7% -    5%) 0.223
                 CountOrHighHigh       43.48      (3.1%)       42.94      (3.1%)   -1.2% (  -7% -    5%) 0.201
                      OrHighHigh       45.23      (7.6%)       44.71      (7.1%)   -1.1% ( -14% -   14%) 0.624
             LowIntervalsOrdered       75.80      (6.3%)       74.94      (7.0%)   -1.1% ( -13% -   12%) 0.591
                       OrHighLow      490.67      (4.2%)      485.46      (3.7%)   -1.1% (  -8% -    7%) 0.394
                         LowTerm      782.27      (3.7%)      774.48      (3.3%)   -1.0% (  -7% -    6%) 0.366
                    OrNotHighMed      327.78      (2.4%)      325.10      (2.6%)   -0.8% (  -5% -    4%) 0.295
          OrHighMedDayTaxoFacets        7.49      (4.0%)        7.44      (4.3%)   -0.7% (  -8% -    7%) 0.574
                      AndHighLow     1052.61      (4.4%)     1044.91      (4.7%)   -0.7% (  -9% -    8%) 0.610
         AndHighMedDayTaxoFacets       31.62      (1.4%)       31.39      (2.3%)   -0.7% (  -4% -    3%) 0.245
                 MedSloppyPhrase        4.55      (2.2%)        4.52      (3.4%)   -0.6% (  -6% -    5%) 0.494
                HighSloppyPhrase        7.84      (2.6%)        7.80      (3.2%)   -0.6% (  -6% -    5%) 0.535
                 CountAndHighMed      117.33      (1.6%)      116.68      (2.2%)   -0.6% (  -4% -    3%) 0.357
           HighTermDayOfYearSort      365.06      (3.2%)      363.03      (3.3%)   -0.6% (  -6% -    6%) 0.590
                        Wildcard       35.27      (2.2%)       35.08      (2.6%)   -0.6% (  -5% -    4%) 0.470
                      AndHighMed      149.03      (5.1%)      148.24      (4.7%)   -0.5% (  -9% -    9%) 0.736
                     MedSpanNear        4.61      (2.7%)        4.58      (3.3%)   -0.5% (  -6% -    5%) 0.588
                       MedPhrase       28.98      (4.8%)       28.83      (5.1%)   -0.5% (  -9% -    9%) 0.743
                CountAndHighHigh       13.40      (1.4%)       13.34      (1.6%)   -0.5% (  -3% -    2%) 0.305
                      HighPhrase        8.65      (4.5%)        8.61      (5.4%)   -0.5% (  -9% -    9%) 0.765
                 LowSloppyPhrase       29.81      (2.4%)       29.70      (2.8%)   -0.4% (  -5% -    4%) 0.639
                   OrNotHighHigh      294.82      (3.6%)      293.71      (2.9%)   -0.4% (  -6% -    6%) 0.719
                         MedTerm      719.95      (6.3%)      717.27      (5.2%)   -0.4% ( -11% -   11%) 0.839
                         Respell       70.19      (2.4%)       69.94      (2.1%)   -0.4% (  -4% -    4%) 0.607
                        PKLookup      288.07      (2.7%)      287.18      (3.4%)   -0.3% (  -6% -    5%) 0.748
                         Prefix3      411.30      (1.9%)      410.09      (2.5%)   -0.3% (  -4% -    4%) 0.675
                       OrHighMed      226.84      (5.1%)      226.17      (4.0%)   -0.3% (  -8% -    9%) 0.842
                       LowPhrase       48.24      (4.1%)       48.15      (4.3%)   -0.2% (  -8% -    8%) 0.889
                   OrHighNotHigh      464.84      (3.1%)      464.02      (3.5%)   -0.2% (  -6% -    6%) 0.866
                          Fuzzy1      108.46      (1.9%)      108.40      (1.9%)   -0.1% (  -3% -    3%) 0.930
                      TermDTSort      290.54      (5.1%)      290.58      (5.5%)    0.0% ( -10% -   11%) 0.993
                    HighSpanNear       19.59      (2.1%)       19.60      (2.2%)    0.1% (  -4% -    4%) 0.916
                          Fuzzy2      107.38      (1.8%)      107.48      (2.3%)    0.1% (  -3% -    4%) 0.889
                    OrHighNotMed      452.75      (4.4%)      453.28      (4.4%)    0.1% (  -8% -    9%) 0.933
                    OrHighNotLow      384.90      (4.4%)      385.42      (5.1%)    0.1% (  -8% -   10%) 0.928
        AndHighHighDayTaxoFacets       18.84      (1.8%)       18.87      (2.1%)    0.1% (  -3% -    4%) 0.816
                     LowSpanNear       57.00      (3.1%)       57.11      (2.9%)    0.2% (  -5% -    6%) 0.841
               HighTermTitleSort      244.47      (2.3%)      244.98      (3.3%)    0.2% (  -5% -    5%) 0.821
                        HighTerm      715.29      (6.2%)      717.58      (5.0%)    0.3% ( -10% -   12%) 0.857
                     AndHighHigh       61.54      (4.0%)       61.84      (3.6%)    0.5% (  -6% -    8%) 0.687
            MedTermDayTaxoFacets       38.45      (1.9%)       38.78      (2.3%)    0.9% (  -3% -    5%) 0.203
            HighTermTitleBDVSort       10.48      (4.6%)       10.63      (7.4%)    1.4% ( -10% -   14%) 0.466
     BrowseRandomLabelTaxoFacets        7.36      (3.7%)        7.48     (16.2%)    1.6% ( -17% -   22%) 0.675
           BrowseMonthSSDVFacets        6.64      (2.7%)        6.78      (9.2%)    2.1% (  -9% -   14%) 0.330
       BrowseDayOfYearTaxoFacets        7.77      (4.2%)        7.93     (14.0%)    2.2% ( -15% -   21%) 0.510
            BrowseDateTaxoFacets        7.68      (3.8%)        7.87     (15.0%)    2.5% ( -15% -   22%) 0.468
     BrowseRandomLabelSSDVFacets        6.05      (9.2%)        6.22     (11.2%)    2.8% ( -16% -   25%) 0.380
       BrowseDayOfYearSSDVFacets        6.69      (2.5%)        6.92      (8.8%)    3.3% (  -7% -   15%) 0.103
           BrowseMonthTaxoFacets       11.69     (24.5%)       12.24     (23.0%)    4.7% ( -34% -   69%) 0.534
                  CountOrHighMed       44.02      (2.4%)       85.10      (4.3%)   93.3% (  84% -  102%) 0.000

Thanks @jfreden, the heuristic looks sensible.

I added TermStates to the query if not set to cache docFreq. Looks like that helped:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                 CountAndHighMed       87.08      (1.6%)       86.95      (2.0%)   -0.1% (  -3% -    3%) 0.798
                 CountOrHighHigh       30.36      (1.6%)       30.45      (2.0%)    0.3% (  -3% -    3%) 0.583
                CountAndHighHigh       13.29      (1.4%)       13.35      (1.1%)    0.4% (  -2% -    3%) 0.317
                  CountOrHighMed       42.32      (1.8%)       83.02      (2.9%)   96.2% (  89% -  102%) 0.000

                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                          IntNRQ       30.79     (10.4%)       29.96     (11.0%)   -2.7% ( -21% -   20%) 0.429
           BrowseMonthTaxoFacets       11.33     (26.2%)       11.06     (28.8%)   -2.4% ( -45% -   71%) 0.785
                      TermDTSort      213.23      (3.9%)      209.89      (5.6%)   -1.6% ( -10% -    8%) 0.302
                    OrNotHighMed      339.52      (3.7%)      335.74      (3.8%)   -1.1% (  -8% -    6%) 0.352
     BrowseRandomLabelTaxoFacets        7.37      (2.7%)        7.29      (2.9%)   -1.1% (  -6% -    4%) 0.208
       BrowseDayOfYearTaxoFacets        7.70      (4.4%)        7.62      (4.5%)   -1.1% (  -9% -    8%) 0.447
            BrowseDateTaxoFacets        7.63      (3.9%)        7.55      (4.0%)   -1.0% (  -8% -    7%) 0.445
                         MedTerm      837.57      (3.9%)      829.55      (4.8%)   -1.0% (  -9% -    8%) 0.489
          OrHighMedDayTaxoFacets        3.36      (4.3%)        3.33      (3.6%)   -0.8% (  -8% -    7%) 0.518
               HighTermTitleSort      204.13      (2.8%)      202.89      (3.2%)   -0.6% (  -6% -    5%) 0.525
                        HighTerm      613.77      (4.3%)      610.66      (5.1%)   -0.5% (  -9% -    9%) 0.731
        AndHighHighDayTaxoFacets       12.48      (1.4%)       12.44      (1.7%)   -0.3% (  -3% -    2%) 0.485
                      AndHighLow      972.52      (2.9%)      969.45      (3.1%)   -0.3% (  -6% -    5%) 0.739
           HighTermDayOfYearSort      468.92      (2.6%)      467.50      (2.8%)   -0.3% (  -5% -    5%) 0.722
                        Wildcard      166.93      (2.3%)      166.46      (2.6%)   -0.3% (  -5% -    4%) 0.720
                         Prefix3      258.97      (1.5%)      258.25      (1.8%)   -0.3% (  -3% -    3%) 0.598
            HighTermTitleBDVSort        8.27      (8.0%)        8.25      (8.8%)   -0.3% ( -15% -   18%) 0.925
                   OrNotHighHigh      379.58      (3.9%)      378.71      (3.9%)   -0.2% (  -7% -    7%) 0.850
                         LowTerm      812.84      (3.1%)      811.50      (4.1%)   -0.2% (  -7% -    7%) 0.886
            HighIntervalsOrdered       11.40     (16.4%)       11.38     (16.6%)   -0.2% ( -28% -   39%) 0.977
                 CountAndHighMed       87.08      (1.6%)       86.95      (2.0%)   -0.1% (  -3% -    3%) 0.798
                   OrHighNotHigh      394.39      (4.4%)      393.87      (4.5%)   -0.1% (  -8% -    9%) 0.925
            MedTermDayTaxoFacets       36.38      (1.8%)       36.33      (1.6%)   -0.1% (  -3% -    3%) 0.813
             LowIntervalsOrdered       11.09     (12.8%)       11.08     (12.5%)   -0.1% ( -22% -   29%) 0.982
                    OrNotHighLow      728.65      (2.3%)      728.11      (3.7%)   -0.1% (  -5% -    5%) 0.939
         AndHighMedDayTaxoFacets       42.76      (1.0%)       42.76      (1.4%)   -0.0% (  -2% -    2%) 0.991
                     LowSpanNear       38.25      (3.7%)       38.25      (3.9%)   -0.0% (  -7% -    7%) 0.998
           BrowseMonthSSDVFacets        6.71      (2.2%)        6.71      (4.1%)    0.0% (  -6% -    6%) 0.968
             MedIntervalsOrdered       24.13     (16.7%)       24.14     (16.5%)    0.1% ( -28% -   39%) 0.992
                    OrHighNotMed      428.51      (4.5%)      428.82      (4.6%)    0.1% (  -8% -    9%) 0.960
               HighTermMonthSort     4186.24      (5.1%)     4192.49      (5.2%)    0.1% (  -9% -   10%) 0.927
                    OrHighNotLow      475.37      (5.3%)      476.11      (5.5%)    0.2% ( -10% -   11%) 0.927
                     AndHighHigh       50.04      (3.4%)       50.14      (2.9%)    0.2% (  -5% -    6%) 0.848
                      AndHighMed       52.87      (3.1%)       52.99      (2.6%)    0.2% (  -5% -    6%) 0.806
                          Fuzzy2       38.56      (2.1%)       38.66      (1.2%)    0.3% (  -2% -    3%) 0.636
                       OrHighLow      401.05      (3.1%)      402.08      (3.4%)    0.3% (  -5% -    6%) 0.800
                 CountOrHighHigh       30.36      (1.6%)       30.45      (2.0%)    0.3% (  -3% -    3%) 0.583
                     MedSpanNear       50.17      (2.1%)       50.37      (2.2%)    0.4% (  -3% -    4%) 0.550
                CountAndHighHigh       13.29      (1.4%)       13.35      (1.1%)    0.4% (  -2% -    3%) 0.317
                         Respell       51.27      (2.6%)       51.49      (2.4%)    0.4% (  -4% -    5%) 0.589
                       OrHighMed      148.52      (3.3%)      149.16      (3.6%)    0.4% (  -6% -    7%) 0.692
                          Fuzzy1       78.52      (1.9%)       78.87      (1.5%)    0.4% (  -2% -    3%) 0.408
                      HighPhrase       48.27      (3.4%)       48.50      (4.1%)    0.5% (  -6% -    8%) 0.692
     BrowseRandomLabelSSDVFacets        6.02      (7.7%)        6.05      (7.2%)    0.5% ( -13% -   16%) 0.839
                        PKLookup      286.26      (3.9%)      287.68      (2.6%)    0.5% (  -5% -    7%) 0.637
                       MedPhrase       37.57      (2.1%)       37.78      (3.0%)    0.5% (  -4% -    5%) 0.511
                    HighSpanNear        4.47      (3.1%)        4.50      (3.2%)    0.6% (  -5% -    7%) 0.564
                       LowPhrase       59.35      (2.2%)       59.72      (2.7%)    0.6% (  -4% -    5%) 0.438
            BrowseDateSSDVFacets        1.69     (12.3%)        1.70     (13.4%)    0.6% ( -22% -   30%) 0.878
                 MedSloppyPhrase       74.94      (2.2%)       75.45      (2.4%)    0.7% (  -3% -    5%) 0.352
                      OrHighHigh       32.62      (3.0%)       32.88      (3.2%)    0.8% (  -5% -    7%) 0.412
                HighSloppyPhrase       14.24      (2.3%)       14.39      (2.6%)    1.0% (  -3% -    6%) 0.191
                 LowSloppyPhrase        9.53      (3.5%)        9.69      (1.4%)    1.7% (  -3% -    6%) 0.048
       BrowseDayOfYearSSDVFacets        6.79      (1.9%)        7.15     (16.8%)    5.3% ( -13% -   24%) 0.159
                  CountOrHighMed       42.32      (1.8%)       83.02      (2.9%)   96.2% (  89% -  102%) 0.000

Thank you @jpountz ! I've pushed changes to the tests, added the comment and also added an entry to CHANGES.txt.


fix link for Event

Description
Changes proposed in this pull request:

update link for Event description in Busola

Related issue(s)
Resolves #1387

/retest

/retest


Update nf-wingdi-rgb.md

@asklar : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Apologize for the delayed merged. Appreciate you adding this detail, @asklar .


chore: add solid export condition to @tanstack/solid-form

Solid relies on the solid export condition to perform a custom JSX transform depending on whether the code is being built for client or server, but @tanstack/solid-form only has dist/cjs and dist/esm, which are client-only since they import stuff like memo from solid-js/web (which is only available in client builds).
To fix this I've added tsc to the build of process of @tanstack/solid-form so that .js/.jsx files are emitted which solid can apply its custom JSX transform on. There's probably nicer ways of doing this that can integrate with vite but this is what I did to fix a similar problem for SolidStart.

@lachlancollins can you investigate this? We'd want this to integrate with Vite
Also CC @ryansolid if you have any guidance on how to do this (sorry for the ping Ryan)

This is pretty much correct. We want the source, but not necessarily the TypeScript so we tend to tsc it into dist folder. My only recommendation is build it into a .jsx entry file if there is any JSX anywhere in the solid implementation of the library. That way it will get processed properly.

My only recommendation is build it into a .jsx entry file if there is any JSX anywhere in the solid implementation of the library. That way it will get processed properly.

This is probably true but having the entrypoint be .js seems to be working fine for us

Is there anything blocking this from being merged? tanstack forms is unusable on solid without this

@TheKnightCoder I'd like to see our build tooling unified to solve this problem before we merge. @lachlancollins any chance you could take another look into merging into Vite?
Alternatively, if you think this fine to publish as-is for now and refine later, we can

Merging, per some research from @lachlancollins showing this should work now. Let us know if you run into additional problems around ESM/CJS support


[Fix/channel-edit-redesign] Bug on creating channel

Describe the bug
2 channels are created
To Reproduce
Use the fix/fix/channel-edit-redesign branch. Use .createChannel
Expected behavior
It create only 1 channel
Desktop (please complete the following information):

OS: Windows
Dart version : 2.13.3
Nyxx version : branch fix/channel-edit-redesign

Sorry !
I've juste 2 instances of my bot who are running.
I'm so sorry...


fix/build single binary app with buster

refactor(fetcher|generator): some cleaning
fix: make single binary app compatible with buster

Codecov Report

Merging #94 (d59704e) into main (dfefa46) will decrease coverage by 0.00%.
The diff coverage is 97.50%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   93.77%   93.76%   -0.01%
==========================================
  Files          14       14
  Lines         627      626       -1
==========================================
- Hits          588      587       -1
  Misses         39       39

Impacted Files
Coverage Δ

src/ops2deb/fetcher.py
96.46% <94.11%> (-0.15%)
:arrow_down:

src/ops2deb/generator.py
95.40% <100.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfefa46...d59704e. Read the comment docs.


fix: CI issues

Description
Fixes #70
The Github Action workflows were not using the right node versions as specified in the build matrix.
Since the node versions in the build matrix were not specified or there was a typo, it defaulted to the latest node in the Ubuntu image, which is node 18.14.
node-18.14 uses npm@9 which causes an issue with the smoke tests: https://github.com/adobe/asset-compute-integration-tests/issues/39
How Has This Been Tested?
We'll see during the daily runs.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

aio-lib-customer-profile failed 😅


Don't redirect engine stderr

This addresses a bug where the stderr buffer can fill up, potentially resulting in the engine deadlocking.
This fixes GediminasMasaitis/TlcvExtensions#4

Thanks Joost!
I'd ideally see stderr handled, but since we're not doing it, this addressees the issue you're facing.


[Bug]: Build fail with AGP 8.0

Platform
android 13
Plugin
connectivity_plus: ^3.0.4
Version
3.0.4
Flutter SDK
3.7.12
Steps to reproduce
After upgrading the android gradle version com.android.tools.build:gradle:8.0.0
Code Sample
No response
Logs
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':connectivity_plus'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Please specify a namespace in the module's build.gradle file like so:

     android {
         namespace 'com.example.namespace'
     }

     If the package attribute is specified in the source AndroidManifest.xml, it can be migrated automatically to the namespace value in the build.gradle file using the AGP Upgrade Assistant; please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 945ms
Running Gradle task 'assembleRelease'...                         1,747ms
Gradle task assembleRelease failed with exit code 1

Flutter Doctor
flutter doctor -v
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.3.1 22E261 darwin-arm64 (Rosetta), locale en-IN)
    • Flutter version 3.7.12 on channel stable at /Users/mohammedrashid/FlutterDev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (7 days ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/mohammedrashid/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (3 available)
    • iPhone 14 Pro (mobile) • 1E3BE0F2-5581-4E8E-B4B0-4464FE0CB90A • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4
      (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 13.3.1 22E261 darwin-arm64 (Rosetta)
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.124

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Checklist before submitting a bug

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Hi @vbuberen
thanks for the update but you also add
compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

kotlinOptions {
    jvmTarget = '1.8'
}

To the build.gradle

Closing as today's release adds compatibility with AGP 8.0 for all plugins.

thanks for the update but you also add
compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

kotlinOptions {
    jvmTarget = '1.8'
}

To the build.gradle

What for?

For resolve this error during complile:
Execution failed for task ':device_info_plus:compileDebugKotlin'.

'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.

Please open a different issue and provide details.

Shouldn't this issue be reopened, as the AGP 8 compatibility was reverted?


chore: remove DB based leases

This means async calls no longer have linked leases, but as they are going away anyway that should not be a problem.

This seems to work now the hermit stuff is fixed, the helm charts need to be updated though, and possibly some kube tests.


Weapon hit limit

In real life,  using the same weapon over and over again will make it dull to a certain point where it becomes unusable. With this in mind,  weapons will have a usage limit. The strength of the weapon and it's effectiveness should also drop overtime during its usage.

Once the uses or the hit limit has reached 0, the weapon will disappear from the inventory and it will be up to the player to acquire a new weapon from the inventory if there are any left.


Make adding new matchers easy

Hello, right now the proposed way for adding new matchers is this:
beforeEach(function() {
  this.addMatchers({
    toBeLessThan: function(expected) {
      return this.actual < expected;
    }
  });
});

It's not very convenient, because usually You define special matchers in a standalone helper file (not in spec file) and reuse it among many spec files.
But right now it's not easy to define matchers without the beforeEach block, for example code below wouldn't work:
jasmine.Matchers.prototype.toBeLessThan = function(expected) {
  return this.actual < expected;
};

You has also to do some extra magic, like this:
jasmine.Matchers.prototype.toBeLessThan = function(expected) {
  return this.actual < expected;
};
jasmine.Matchers.prototype.toBeLessThan = jasmine.Matchers.matcherFn_(
  'toBeLessThan',
  jasmine.Matchers.prototype.toBeLessThan
);

So, maybe it's worth to somehow simplify this, add some helper method for example?, like jasmine.Mathcers.addMatchers that will do all this behind the scene?
Thanks.

This seems reasonable to me. We'll take a look at adding such a feature.

Tracker story: https://www.pivotaltracker.com/story/show/25484807


Chess: Move G2 to G4

Please do not change the title. Just click "Submit new issue". You don't need to do anything else :D

@MGBoulware88 done! Successfully played move g2g4 for current game.
Thanks for playing!


Add a call back for onCreateUser

Your onCreateUser callback is likely to conflict with other onCreateUser callbacks inside the same app.
I think it would be better if you had the app developers add the onCreateUser logic themselves.  You can just provide the necessary function calls to make it all work.

It definitely conflicts. :)

sorry about the delay,
I removed the onCreateUser callback and added a method to call when needed.
89154e7d73ee520ee6b1b91846692af8344e2f4b


⚡ Boosting Performance: React.js Code Optimizations

This pull request introduces several minor performance improvements for the React.js code in the Raspberry Pi Foundation Code Editor. The following changes have been made:

Made useMemo dependency more specific: Changed the dependency from params to params["width-larger-than-880"]. This change offers the following advantage:

By making the useMemo dependency more precise, unnecessary re-evaluations are avoided when other properties of params change. This can improve the performance by reducing unnecessary computations.

Made useEffect dependency more precise: Updated the dependency to include only the specific value used inside the function body. This change provides the following advantage:

By specifying a more precise dependency, the useEffect hook will only be triggered when the specific value it depends on changes. This can prevent unnecessary re-rendering and improve performance.

Implemented React.js concurrency with startTransition: Utilized React.js concurrency features, specifically startTransition, to achieve a more responsive user interface. This change offers the following advantage:

By using startTransition, the code can prioritize rendering high-priority updates, improving the perceived responsiveness of the UI. This can result in a smoother user experience.

Utilized React.lazy for lazy loading routes and prefetching using Webpack prefetch comment: Introduced React.lazy to lazily load routes and prefetch them using Webpack prefetch comment. This change provides the following advantage:

Lazy loading routes can improve the initial loading time of the application by deferring the loading of non-essential components until they are actually needed. Prefetching these routes using Webpack prefetch comment can further enhance performance by proactively fetching the required resources in the background.

Please review the changes and provide any suggestions or feedback for the Suspense fallback, which is currently set as an empty fragment.
Apologies for any mistakes made. Feel free to provide any additional suggestions or improvements for the PR.

Thanks for your contribution! I've merged your changes into a new boosting-performance branch and created a PR so we can run our automated tests and review your changes.

Thanks for your contribution! I've merged your changes into a new boosting-performance branch and created a PR so we can run our automated tests and review your changes.

Okay 🫱🏼🫲🏾✨

I've added a few review comments on the new PR. There are a few tests failing as well but it might be related to the comments I've already made on the code changes. Thanks again @sanjaiyan-dev for your work on this!

I've added a few review comments on the new PR. There are a few tests failing as well but it might be related to the comments I've already made on the code changes. Thanks again @sanjaiyan-dev for your work on this!

You're welcome !


Add SetPrice to PricingSystem

About the PR

add a method for setting price to given entity
Why / Balance

i need it for my next pr and i think it's a pretty useful method
Technical details

not a lot, just EnsureComp and change set the price of it to given in method call
Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

no
Changelog

no cl no fun

I'm concerned that this might not always do what you want, for example, when you run into an item which is really in a stack and uses StackPriceComponent. Can you discuss the other cases and why this should ignore that?

Yeah, I mentioned this on Dicord already, but if this function is used in unintended ways that might cause more exploits that are not caught from the integration tests because those run only considering the original prototypes.
For example the function in this PR adds the StaticPriceComponent to any entity, which could violate the NoStaticPriceAndStackPrice test.

isn't needed anymore


update vendor for k8s version update

https://github.com/rancher/rancher/issues/15595

closing in favor of https://github.com/rancher/rancher/pull/15642


Doesnt work for arm

It work well in mac. However when I cross compile the code for arm and start any video panel, it pop up:
F1_FER technical package is available in your region after Current Season ends since 2022-08-28T17:00:00+02:00

It work well in mac. However when I cross compile the code for arm and start any video panel, it pop up:
F1_FER technical package is available in your region after Current Season ends since 2022-08-28T17:00:00+02:00

it's likely you are in Asia, which doesn't have F1TV Pro and replays are delayed up to 2 years. Hosting it in other continents would help


validation_error_handler

This PR adds the option to provide custom validation error handler functions to Flasgger.
Solves #122

Coverage decreased (-0.09%) to 93.002% when pulling 540f4169a9cff94480b4d7e319a0db7a20124555 on allrod5:validation-exceptions-handling into 6779bb90da7482d4c5e6d7262ca964cfbded05b4 on rochacbruno:master.

Coverage increased (+0.04%) to 93.136% when pulling 3937db9bdf5a3615573c1a071fa39357e8069ef3 on allrod5:validation-exceptions-handling into 6779bb90da7482d4c5e6d7262ca964cfbded05b4 on rochacbruno:master.

Coverage increased (+0.04%) to 93.136% when pulling 3937db9bdf5a3615573c1a071fa39357e8069ef3 on allrod5:validation-exceptions-handling into 6779bb90da7482d4c5e6d7262ca964cfbded05b4 on rochacbruno:master.


Update documentation for GitHub Workflow Status Badges

Our GitHub Workflow Status badges use an upstream GitHub API endpoint that requires we utilize the Workflow name. GitHub provides native badges for Workflow status which requires users specify the file name that contains the workflow definition.
For one reason or another, many of our users assume that Shields also wants the file name parameter, and are then confused when our badges show 404/not found type messages (e.g. #6593, #6255)
I anticipate this will continue to be a recurrent issue for some, but it'd likely help avoid some confusion if we extended the modal badge window documentation for these badges to stress this. We could consider changing the parameter name to something more explicit too (e.g. workflow --> workflowName).
The text that displays is configured via the documentation key on each example in the service class definition, some of the example listings for the Worklow Status badge class linked below for reference. We have a default documentation value for all our GitHub badges, so any updates/augmentation we make to the Workflow badge examples would need to be an extension that retained the standard GitHub help text and added additional info
https://github.com/badges/shields/blob/4ad822c42ee82cdebeee6d63d2e245e5d387946f/services/github/github-workflow-status.service.js#L27-L56

Hi @calebcartwright I would like to work on this issue, could you provide more details? Thanks!

hi @chrysillala, that'd be great!

could you provide more details?

I feel like the issue description is already very thorough, and provides both a direct link to the location in code where the change would be made as well as the additional information that needs to be added. I'm not really sure what else I could add to that without practically writing the code myself :smile:
Do you have any specific questions or find anything unclear?

Hi, I had the same problem. From the hints provided on the website, I thought the name was the same as the .yml file. Maybe a hint or further explanation might work.

Hi @calebcartwright I would like to work on this issue.

This one will become irrelevant if we merge #8475
I think its best we ignore it for now as it will hopefully become a non-issue.

This is now irrelevant due to https://github.com/badges/shields/issues/8671


fixed icon

I fixed the icon glitch that was stopping the program

Will take a look at the request when i am home. 😙


update to flat updatepayload structure

Updates Dockerfile to include a /manifests directory in image.
cc @deads2k @mfojtik @sttts

@deads2k thanks, review comments addressed

@deads2k Added "categories" back to CRD.

/lgtm


Create an undispose event for rolling back delete of a subdirectory

This change makes the events for disposing of a subdirectory and rolling back the disposal of a subdirectory symmetrical. In the draft state prior to fixing the tests accordingly, I'd appreciate any feedback on:

The new event, subDirectoryUndeleted, to be emitted during the rollback of a delete instead of the same event that is emitted on creation.
The naming convention of undispose and undelete - while these terms are symmetrical to the dispose and delete events used, there might be more intuitive names for these operations.

AB#1031

Are we saying the average customer needs to register for and appropriately handle all of these events, or just a specific subset of customers who are opting into this functionality?

Only a specific subset of customers would need to handle these events (those who have rollback turned on). The average customer that has not opted into rollback should not need to worry about handling these events.

If the latter then maybe we can clarify this in documentation, such that it's obvious to the majority of our customers which events they need to pay attention to and which they should ignore.

I can definitely add documentation in the event interface to clarify this.


better ui_draw()

What exactly did you change here? Why is it better?

less code and function calls to do the same thing with better order. remove the following "empty" code block that looks like a patch.
https://github.com/commaai/openpilot/blob/ae37626ecdf7ed08e7f31af364b7f4fb22600946/selfdrive/ui/paint.cc#L940-L949
you'r welcome! it's my pleasure.

This PR changes the look of the ui. Can you make sure it looks the same?
Before:

After:

fixed.
sorry for my mistake.  the left border is drawn by ui_draw_sidebar(), which I had not called if sidebar is collapsed.
the  ui_draw_sidebar_background() is the only necessary function when sidebarcollapsed is true,so I added a conditional return in ui_draw_sidebar.


Improved Grammar

Changes proposed ✍
What
Improved  documentation
Checklist ✅

[x] Label appropriately with Feature, Improvement, or Bug.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Controlled Brush

I have a use case for a brush that can be initialized with some state, more like a controlled component rather than an uncontrolled component (as it currently maintains it's own state).
For example on initial render there would already be a brushed area that the user can then drag to resize, rather than always starting from an un-brushed state.
I think this could be achieved by optionally passing in brush state rather than the brush managing it's own state. Is there appetite to support this use-case? I'm happy to submit a PR if so.

Hey @hellosmithy 👋 thanks for the suggestion, I think there's definitely a use case for this!
If not too complex to implement, it seems like we could have a dual controlled/uncontrolled component where you can optionally pass in the brush state as you say, but if you don't it will manage it on its own as it does now.
Happy to review a PR or discuss implementation details more! 🙌

we could have a dual controlled/uncontrolled component where you can optionally pass in the brush state

Yea that's my thoughts too. OK - I'll put together a PR then for you to review.

I was looking for a way to control the Brush component by giving it a brushPosition props. Here's my solution :
import React, { useEffect, useState } from "react";
import { Brush } from "@visx/brush";

const positionToKey = ({ start, end }) => `${start.x},${start.y},${end.x},${end.y}`;

const ControlledBrush = ({ brushPosition, domainToPosition, ...brushProps }) => {
  const [innerPosition, setInnerPosition] = useState(brushPosition);
  const [key, setKey] = useState(positionToKey(brushPosition));

  const { onChange } = brushProps;

  useEffect(() => {
    if (positionToKey(innerPosition) !== positionToKey(brushPosition)) {
      setKey(positionToKey(brushPosition));
    }
  }, [innerPosition, brushPosition]);

  return (
    <Brush
      key={key}
      {...brushProps}
      initialBrushPosition={brushPosition}
      onChange={(domain) => {
        if (domain !== null) {
          setInnerPosition(domainToPosition(domain));
        }
        return onChange && onChange(domain);
      }}
    />
  );
};

export default ControlledBrush;

The key props change only when an external change to brushPosition is detected. This make it compatible with brush, move & resize interactions.
You have to specify the domainToPosition props witch is a function used to convert domain ({x0, x1, y0, y1}) into position ({start: {x, y}, end:{x, y}}). There's probably a better way to handle this part.


Header-Row(s) are orphaned.

If the remaining space on a page is large enough to contain just the header rows of a table, it is indeed printed there -- only to be repeated on the next page.

The shown sample has a table with two header rows. The code for the page is this:
#import "/Global/Components/tablex.typ": *

Dies ist ein Testdokument

#v(22.5cm)

#tablex(
    columns: (auto, auto),
    repeat-header: true,
    header-rows: 2,

    [*Name*], [*Ort*],
    [*First Name*], [*Residence*],

    [Anton], [Hannover],
    [Bob], [Hannover],
    [Robert], [Paris],
    [Sean], [Paris],
)

Hey, thanks for opening the issue! I've noticed this issue before too, and I admit it is not very simple to fix - it basically happens because it runs out of space in the first page, but still places the header anyway (since it is part of the table!). A suitable alternative might be to (eventually) detect this kind of situation and force a skip to the next page, perhaps in a toggleable way. Either way, a fix for this is planned. I'll update this issue in case I gather more info. Thanks again!


Provide mechanism for checking if custom column encryption provider has been registered

Is your feature request related to a problem? Please describe.
We make use of the SqlColumnEncryptionAzureKeyVaultProvider which we register as part of our host configuration. For integration testing altering the client, configuration causes a System.InvalidOperationException to be thrown if a second attempt is made to register the same provider. Currently, we are catching this specific instance and ignoring the exception.
Describe the solution you'd like
Ideally having a mechanism to check if the provider has been registered would help us decide if the registration should be done again.
Describe alternatives you've considered
I don't really know if there is another more appropriate alternative as we don't want to alter the current functionality.
Additional context
The exception is thrown here

Shouldn't this kind of thing be tracked in your integration testing infrastructure, and you'd just avoid registering the same provider twice?

Well, since the logic to track registration lives entirely inside the SqlConnection class with no mechanism to tap into it, I don't see how I'm supposed to do that?
I can modify my ASP.NET app with a static field. But this seems very extreme to make a change to a running app to track something a different dependency is doing simply so test will pass, don't you think? The fact SqlConnection tracks this in a static means feels to me like the source of truth lies with it.

Well, since the logic to track registration lives entirely inside the SqlConnection class with no mechanism to tap into it, I don't see how I'm supposed to do that?

I'm not sure what the problem is - it's your responsibility to register this once before opening connections, so you'd do this in your test infrastructure in some single setup code which gets executed once, before tests run. In an ASP.NET app, simply run this in your application's Main or similar...
If for whatever reason that doesn't work for you, have some static bool which you set to know whether you've already registered. That's probably going to be less code and easier to do than to access some SqlClient API for getting all registered providers and checking if one of them is what you're looking for.

I'm not a SqlClient maintainer, so it's not up to me - adding a Try method that returns a bool rather than throwing may be acceptable. But it's a fairly common scenario to have to run some initialization code once in the context of an application, and IMHO it doesn't seem like much to ask an application (or test) writer to handle that.

@DigiBanks99 just to clarify are you asking for a new feature to be added to our driver? If the answer is yes, that would be a low priority in our queue of to-do tasks as it could, as @roji  mentioned, be handled in the user application.

@DigiBanks99 just to clarify are you asking for a new feature to be added to our driver? If the answer is yes, that would be a low priority in our queue of to-do tasks as it could, as @roji mentioned, be handled in the user application.

@JRahnama Yes, it is indeed a new feature request. I understand what you mean, so would you be open to a PR?

@DigiBanks99 as an open source driver we always appreciate contribution from users and community members. Please feel free to submit a PR that we can review that.


KAFKA-12202 Migrate connect:mirror module to JUnit 5

issue: https://issues.apache.org/jira/browse/KAFKA-12202
This PR consists of following changes.

replace junit 4 APIs by junit 5
remove the dependencies of junit 4 from EmbeddedKafkaCluster

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

The previous test run had no related failures and the merge conflict resolution on the build file was trivial. I ran unitTest locally to verify. Merging to trunk.

The previous test run had no related failures and the merge conflict resolution on the build file was trivial. I ran unitTest locally to verify. Merging to trunk.


May I use  your test harness?

Summary
Hi. As someone building tooling OpenAPI tooling (like https://github.com/ahx/openapi_first/), I would benefit from using an extensive and language agnostic test suite like your test harness. In practice, I was thinking about using the code in a git submodule, similar to how people are using https://github.com/json-schema-org/JSON-Schema-Test-Suite. I am not so much interested in the mocking, but would like to use the test cases about content-negotiation and request/response validation.
What do you think? Are you okay with that?

In the spirit of open source projects, as long as you are in compliance with our licensing, go for it! Feel free to contribute to this project in other ways as well!

Thank you @chohmann


This currently doesn't work on aws_security_group_rule resources, it …

…just returns a message saying "This method can only be used for aws_security_group resources for now. You tried to used it on aws_security_group_rule"

Pull Request Test Coverage Report for Build 821

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.4%) to 68.114%

Files with Coverage Reduction
New Missed Lines
%

terraform_compliance/common/defaults.py
6
80.65%

Totals

Change from base Build 819:
0.4%

Covered Lines:
1004

Relevant Lines:
1474

💛  - Coveralls

Thanks a lot 🎉


Animated: useNativeDriver was not specified

I'm getting the following warning when I click the Hamburger:
Animated: `useNativeDriver` was not specified. This is a required option and must be explicitly set to `true` or `false`

Could this be related to https://github.com/GeekyAnts/NativeBase/issues/3109?

confirmed a duplicate of https://github.com/GeekyAnts/NativeBase/issues/3109 and fixed in https://github.com/GeekyAnts/NativeBase/pull/3278
Can manually be fixed by adding useNativeDriver: false to occurrences of Animated.spring or Animated.timing.


Possible typo in the README

the "overview of the code section" starts with

Same as the architect TiDB + TiKV + PD

should it not be this?

Same as the architecture of TiDB + TiKV + PD

you are right~ Looking forward to your PR to fix it.


Load Fonts by https

This allows browsers to accept the fonts from Google by default.
Issue # (if available)
Description of changes
Just a tiny change to load fonts as https because my browser is blocking the mixed content. You can see this working as expected at: https://qstearns.github.io/semantic_logger/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Excellent catch, Thank you.


chore(userspace/libsinsp): improve messages of plugin version errors

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #243
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
chore(userspace/libsinsp): improve messages of plugin version errors

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jasondellaluce
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test build-libs

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Ref not found after position in DOM has changed

In the following component the "Ref" div can only be found when it is in its initial position among its siblings. When the state is false and it moves to first position in the parent div, it's no longer found. Is this a bug or improper use of refs?
module Main where

import Prelude
import Halogen as H
import Halogen.HTML as HH
import Halogen.HTML.Events as HE
import Halogen.HTML.Properties as HP
import Control.Monad.Aff (Aff)
import Control.Monad.Eff (Eff)
import Control.Monad.Eff.Console (CONSOLE, log)
import Data.Array (catMaybes)
import Data.Maybe (Maybe(Nothing, Just))
import Halogen.Aff (awaitBody, runHalogenAff)
import Halogen.Aff.Effects (HalogenEffects)
import Halogen.VDom.Driver (runUI)

--------------------------------------------------------------------------------

data Query a
  = Toggle a

type State = Boolean

ref :: H.RefLabel
ref = H.RefLabel "myRef"

comp :: H.Component HH.HTML Query Unit Void App
comp = H.component
  { initialState: const true
  , render
  , eval
  , receiver: const Nothing
  }

  where

  render :: State -> H.ComponentHTML Query
  render st = HH.div_ $ catMaybes
    [ if st
      then Just (HH.text "foo")
      else Nothing
    , Just $ HH.div
      [ HP.ref ref ]
      [ HH.text "Ref" ]
    , Just $ HH.button
      [ HE.onClick $ HE.input_ Toggle ]
      [ HH.text "Toggle" ]
    ]

  eval :: Query ~> H.ComponentDSL State Query Void App
  eval = case _ of
    Toggle next -> do
      findRef
      H.modify not
      findRef
      pure next

  findRef :: H.ComponentDSL State Query Void App Unit
  findRef =
    H.getHTMLElementRef ref >>= case _ of
      Nothing -> H.liftEff $ log "could not find ref"
      Just el -> H.liftEff $ log "found ref"

--------------------------------------------------------------------------------

type AppEffects = HalogenEffects (console :: CONSOLE)
type App = Aff AppEffects

main :: Eff AppEffects Unit
main = runHalogenAff $ do
  body <- awaitBody
  runUI comp unit body

Additionally, halogen-vdom only fires ref handlers on element creation and removal. If you don't have a ref, and then add one after the element has already mounted, it won't fire. It should probably fire in the diff as well if there wasn't one previously.

Actually, I take that back! It should work as expected on the vdom side, as applyProp is used in both render and patch. https://github.com/slamdata/purescript-halogen-vdom/blob/master/src/Halogen/VDom/DOM/Prop.purs#L128

@natefaubion I suspect it's working as intended, but is adding the new ref and then removing it again during patching... if that makes sense?

@garyb using the keyed version fixes that specific problem. Also thanks for pointing me to that feature. :wink:
However, it introduces the weird effect that the "foo" text node is appended as the last child on each toggling the state to false. Here's the adjusted render code:
  render :: State -> H.ComponentHTML Query
  render st = HK.div_ $ catMaybes
    [ if st
      then Just $ Tuple "foo" $ HH.text "foo"
      else Nothing
    , Just $ Tuple "ref" $ HH.div
      [ HP.ref ref ]
      [ HH.text "Ref" ]
    , Just $ Tuple "button" $ HH.button
      [ HE.onClick $ HE.input_ Toggle ]
      [ HH.text "Toggle" ]
    ]

🙈
That's one for Nathan, as it sounds like it may be vdom related.

Woah I can close tickets across repos 😮

Unfortunately that didn't fix the ref issue though, right? Just the other thing :smile:

I suspect it's working as intended, but is adding the new ref and then removing it again during patching... if that makes sense?

I don't know about that. It doesn't fire an input if you remove the ref property. Right now Removed is only fired in the finalizer for the element. Since it shouldn't be destroying the old node (just patching in this case), I would think that it would only fire a new Created ref.

Oh nevermind, it should be destroyed, yes. Because its being replaced by a button. So yeah, that sounds right.

Just been debugging an instance of this issue myself. In my case the ref is attached to an edit form. There's a page of short text articles, and when the user clicks the 'Edit' button on one of them the form is placed under that article. So, if the user clicks Edit on article A then clicks Edit on article B (and assuming I'm understanding the virtual DOM stuff right), the edit form isn't deleted and inserted, it's moved and therefore triggers this issue.
I got as far as debugging the evalM expression for GetRef, and found that sometimes after the edit form is moved refs is empty (note: the only refs that should be there are the two I'm looking for, which are affected by this issue).
Oddly, the behaviour would only happen intermittently. It was always reproducible though, after a few tries.
My workaround was to change:
ref :: H.RefLabel
ref = H.RefLabel "myRef"

ref :: String -> H.RefLabel
ref id = H.RefLabel ("myRef-" <> id)

Now it works reliably.
Side-note: you can always pass "new" or whatnot for one-off edit forms.