(build) One single step for installing Node and Bower dependencies. Updated docs.

Coverage remained the same at 97.17% when pulling 70a93042ffee0f0414de1e68d49cb494aaa53f9e on yagoferrer:yago/local-bower into 440a508ca7ed32bb9a859483466f120f069f0840 on Zizzamia:master.


fix unpack recursion

preserve symlinks in copytree.  Otherwise recursive symlinks will cause the disk to fill up.

Thanks!


Omit copying for creation of Terms from CharSequences

Description
Currently constructors of Term require the internal BytesRef to be unmodifiable from the outside
and thus perform defensive copying in order to uphold this invariant.
In order to omit redundant copying there are constructor overloads which accept
BytesRefBuilder and String to create new BytesRefs from them.
The latter delegates to BytesRef(CharSequence) constructor internally.
Current approach does not however allow the creation of Terms from CharSequences
which is a valid use-case (e.g. when creating Terms from CharTermAttributes)
thus an overload delegating to BytesRef(CharSequence) is added in order to support such use-cases.
The previous Term(String fld, String text) constructor is preserved to maintain binary compatibility
and possibly allow futher String-specific optimizations.

There's no code using this at moment?

There's no code using this at moment?

What exactly? If you mean the new constructor, no, because the PR is more useful for foreign callers.

I think look at how QueryBuilder does this:
new Term(field, termAtt.getBytesRef())

I don't see any benefit of adding yet another way to do it.

Use TermAttribute to do this. the backing CharTermAttributeImpl implements it also.

by the way, doing it this way with TermAttribute works with both character (CharTermAttribute) and binary (BinaryTermAttribute) terms.
If we add methods as you propose, it means anything using it will be broken for non-UTF8 terms.

https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java#L287

Use TermAttribute to do this. the backing CharTermAttributeImpl implements it also.

Not sure if it will work in our scenario, but I will giv eit a try. This however still does not solve the problem of defensive copying.

If we add methods as you propose, it means anything using it will be broken for non-UTF8 terms.

But does not it mean that the existing BytesRef(CharSequence) constructor is already broken?

What I mean is there already a way to create an ill-formed Term using the existing BytesRef API: new Term("foo", new BytesRef(invalidCharSequence)) and this PR does not affect it.
The only addressed thing is removing defensive copying from the paths in which it is not required in the same way as Term(String, String) already does with the same caller-upheld invariants as with BytesRef(CharSequence)

In this case, I will close the PR.
Thanks again for the advice!


Better resolution / use of "retina like" resolutions ?

Hey,
the works great so far, but the image quality isn't that good, no matter which resolution I chose, it seems to be the same.
Found this: https://github.com/GoogleChrome/puppeteer/issues/1329
Could that somehow relate ?
regards,
Sven

sorry, scale factor fixes this.


Duplicate string index signature

Hello
I use gulp for my angular + TypeScript project.
*.d.ts declaration files I take from https://github.com/DefinitelyTyped/tsd
But when I run plugin 'gulp-typescript' - I get many errors like this:
E:/MyProjects/20150323__typescript/bower_components/dt-angular/angular.d.ts(13,5): 2300 Duplicate identifier '$inject'.
E:/MyProjects/20150323__typescript/bower_components/dt-jquery/jquery.d.ts(28,5): 2300 Duplicate identifier 'accepts'.
Error in plugin 'gulp-typescript'

I use
"gulp-typescript": "~2.3.0"
"gulp-typescript-compiler": "^1.0.1",
"typescript": "^1.4.1
Could you help me?

This is not an issue of gulp-typescript, but something with your project. $inject and accepts are already defined when the compiler reads angular.d.ts & jquery.d.ts. Do you have saved the definition files twice, under different file names? Did you reference files with different casings?

Oh, thanks.
You was right! I put reference on angular.d.ts in each controller. But when I removed this reference I had another error:
 E:/MyProjects/20150323__typescript/src/components/navbar/navbar.controller.ts(5,34): error TS2304: Cannot find name 'ng'.

Do you have any idea ?


Fix schema-understand doc.

now complex type example are not right, so fix it.

@BewareMyPower hi, I think this example is used to explain struct schema. Both avro and protobuf are good, what do you think?

OK, I also just found the original doc PR is a little confused because it contains both the schema definition part and protobuf native schema part.

Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks


manhwalist rebranded to hizanami

Source name
Hizanami
Source link
https://hizanami.xyz
Source language
Indonesia
Other details
Nsfw/+18 = no
This is a new domain manhwalist (manhwalist.xyz) change to hizanami.xyz
And rename manhwalist to hizanami
Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] I will fill out all of the requested information in this form.

This is two requests in one issue "add hizanami" and "delete manhwalist"

This is two requests in one issue "add hizanami" and "delete manhwalist"

Not deleted, but rather replaced

This is two requests in one issue "add hizanami" and "delete manhwalist"

Manhwalist is change to hizanami and mybe this label domain change not site request, mybe

hizanami.xyz

hizanami.xyz

Is it under repair, or adding mybe features?

Update url to komiknesia.xyz

hizanami.xyz

So..

This is two requests in one issue "add hizanami" and "delete manhwalist"

so..? when will you pull this request?
please 🫠


already have a dev drive

Suggested new feature or improvement
I already have a dev drive, it should be detected
Scenario
I already have a dev drive, it should be detected
Additional details
I already have a dev drive, it should be detected

/logs

Also @matebenyovszky would you be able to send us the output from running the following command in an elevated command prompt or PowerShell window?
"fsutil devdrv query "drive letter of dev drive"
Thank you!

TempState.zip
TempState_Github.zip

Windows Settings app recognized it. I made this Dev Drive on this machine.
I don't know if it is in relation with the issue, but I have to manually mount the drive after every reboot.

Thanks for the info @matebenyovszky, quick question. Are you saying that Dev Home does not detect that you have a Dev Drive?
E.g The only place where we detect a Dev Drive in Dev Home is on the clone repository page where we auto select your Dev Drive as a clone location:

As for the automount issue, we're having the Storage team take a look at that issue. Unfortunately, it can't be solved on the Dev Home or Windows Settings side of things.


fix dual player on npc fight behavior

right now if two players attack an npc at the same time, they both get the same amount of experience, also the die message is printed twice to the room

FIXED


Automated cherry pick of #6631: fix: sysadmin cannot convert host in non-default domain

Cherry pick of #6631 on release/3.2.
#6631: fix: sysadmin cannot convert host in non-default domain

Codecov Report

Merging #6634 into release/3.2 will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           release/3.2    #6634   +/-   ##
============================================
  Coverage         7.03%    7.03%
============================================
  Files              650      650
  Lines           111812   111793   -19
============================================
  Hits              7869     7869
+ Misses          103334   103315   -19
  Partials           609      609

Flag
Coverage Δ

#aFlag
7.03% <0.00%> (+<0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/baremetal/tasks/bm_register.go
0.00% <0.00%> (ø)

pkg/baremetal/tasks/ipmiprobe.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/namevalidator.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.50% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudcommon/db/scoperesource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/tenantcache.go
2.93% <0.00%> (-0.35%)
:arrow_down:

pkg/cloudcommon/policy/resources.go
0.00% <ø> (ø)

pkg/cloudprovider/cloudprovider.go
1.56% <ø> (+0.02%)
:arrow_up:

pkg/cloudprovider/objectstore.go
2.48% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/buckets.go
1.17% <0.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158f706...f32538d. Read the comment docs.

/lgtm
/approve


docs: add fastfit tutorial

Description
A new tutorial using FastFit. I also added how to calculate annotation performance with some of the most known metrics to give more value, and as I saw that only Kripendorff's alpha is currently available in Argilla.
Closes #4878
Type of change
(Remember to title the PR according to the type of change)

[x] Documentation update

How Has This Been Tested
(Please describe the tests that you ran to verify your changes.)

[x] sphinx-autobuild (read Developer Documentation for more details)

Checklist

[ ] I added relevant documentation
[ ] I followed the style guidelines of this project
[x] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I filled out the contributor form (see text above)
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Also, I believe we can just use fastfit like this?
from fastfit import FastFit
from transformers import AutoTokenizer, pipeline

model = FastFit.from_pretrained("fast-fit")
tokenizer = AutoTokenizer.from_pretrained("sentence-transformers/paraphrase-mpnet-base-v2")
classifier = pipeline("text-classification", model=model, tokenizer=tokenizer)

print(classifier("I love this package!"))

Similarly, there are some warning etc underneath certain code blocks.

Hi! A couple of things:

[ ] In the import from argilla.feedback import ArgillaTrainer, FeedbackDataset, TrainingTaskMapping, FeedbackDataset is not used.
[ ]  Wouldn't it be better to do all the imports at the beginning? Maybe kind of a debate but I usually prefer getting rid of all the imports, as I think you win in readability in the body of the tutorial.
[ ] In the pandas DataFrame that is shown at the end, I will add a few columns, showing which is the label with the highest probability, i.e., the one that is predicted. You really dunno which label is being predicted.

Hi! A couple of things:

[ ]  In the import from argilla.feedback import ArgillaTrainer, FeedbackDataset, TrainingTaskMapping, FeedbackDataset is not used.
[ ]   Wouldn't it be better to do all the imports at the beginning? Maybe kind of a debate but I usually prefer getting rid of all the imports, as I think you win in readability in the body of the tutorial.
[ ]  In the pandas DataFrame that is shown at the end, I will add a few columns, showing which is the label with the highest probability, i.e., the one that is predicted. You really dunno which label is being predicted.

Sorry, I believe you reviewed the wrong tutorial 😅


[FLINK-29114][table] Refactors uniqueness test

This refactoring separates the directory configuration from the directory creation. That enables us to test the Precondition more explicitly.

This refactoring separates the directory configuration from the directory creation. That enables us to test the Precondition more explicitly.

I like this idea!


Documentation for updating the app and adding dependency changes to release notes

Congratz on the new 2.0 release. Lot's of good stuff to play with.
Just wondering if there is any recommendation for upgrading to the latest? Also, does the dependencies have changed? If yes, it would be nice to have notes in the release description.

I was able to upgrade on an M1 mac relatively simply, but it did involve rebuilding the whole conda environment.
Once you've pulled the most recent changes in the main branch, run:
conda env remove -n ldm
conda clean --yes --all
PIP_EXISTS_ACTION=w CONDA_SUBDIR=osx-arm64 conda env create -f environment-mac.yml

After that everything ran as expected. In a sense it's a little easier than a full install because you know all the dependencies outside of Conda are already installed and available.
Rebuilding in different platforms is going to be a little different.
I agree some upgrade instructions are probably worth adding in to the documentation. I can probably to together a pull request but I don't have access to other platforms so I can't confirm the best way to go about it in Windows or Linux.

Here's an idea. Maybe a portable "package" available for each release/platform? No more Python upkeep, for humanity sake!

Settings this as a documentation request for:

Instructions for updating in the docs
Also maybe dependency changes in release notes

@lstein since I think you are managing releases mostly now

@lstein please consider adding this to next releases. Thank you you.


cannot escape evaluating an expression

left: -webkit-calc(~"50% - 297px");
in lessc, it compiles to left: -webkit-calc(50% - 297px);
in recess, it compiles to left: -webkit-calc(-247%);
seems related to:
    // iterate over defintions and compress them (join with new lines)
    css = this.definitions.map(function (def) {
      return def.toCSS([[]], { data: that.data, compress: that.options.compress })
    }).join(this.options.compress ? '' : '\n')

this.data has the correct less. css after each definition's .toCSS - doesn't so it looks like it may be a less.parser issue in that the tree.rules stores the parsed args (unescaped already) so on the second .toCSS it evaluates it.
since this serves no purpose other than to strip spaces/format and the original compress option is applied anyway, what's the point?

I am still not able to escape an expression. Will it be fixed?

isn't recess kind of abandonware on account of new tools now...
On Monday, January 5, 2015, Joqus<EMAIL_ADDRESS>wrote:

I am still not able to escape an expression. Will it be fixed?
—
Reply to this email directly or view it on GitHub
https://github.com/twitter/recess/issues/75#issuecomment-68754899.

--
Dimitar Christoff
"JavaScript is to JAVA what hamster is to ham"
@D_mitar - https://github.com/DimitarChristoff


Move CLI app to another package?

The dependencies to support the CLI part of this package are quite hefty. meow pulls in a lot of stuff, relative to the rest.
Any chance you can publish a separate package executable-cli that requires this package, and does the cli stuff? @sindresorhus does this with a lot of his packages.

Yup, had this in mind for all my packages that uses a CLI, but hadn't had much time lately.

@kevva You can drop CLI support, publish v3.0.0, and create executable-cli later :) Users still can use  v2.x for CLI before the separate CLI package is released.

https://github.com/kevva/executable-cli


Updated Makefile so that 'all' target creates signing key, builds binary, and builds signed enclave

This pull requests attempts to automate the SGX build slightly:

Adds a Makefile target for the enclave signing key (target invokes the openssl call to create key)
Makes the enclave signing key target a pre-requisite for the signed enclave target
Updates the 'all' target to build both the binary and the signed enclave
Adds the enclave signing key file to the list of files removed by the 'clean' target
Updates the INSTALL.md instructions to simply use 'make -f sgx.mk' to build everything

Made the following updates to decouple the enclave signing key generation/installation from the build process:

Changed SGX Makefile to simply display error message (with helpful instructions) if the enclave signing key is not present.
Removed enclave signing key from the list of files removed by the 'clean' target
Modified the build instructions (in INSTALL.md) to reflect this change.
Created a .gitignore file for the project and added *.pem (any .pem files) to it


Trouble about compiling spconv and pointgroup_ops

Hi there, I was trying to run your code on our lab's public server and met some issues in the compiling step.
I tried to follow your instructions to install gcc-5.4 for spconv, however I met the following error:
ERROR conda.core.link:_execute(730): An error occurred while installing package 'daleydeng::gcc-5-5.4.0-2'.
Rolling back transaction: done

LinkError: post-link script failed for package daleydeng::gcc-5-5.4.0-2
location of failed script: /home/wanghanhui/.conda/envs/pointgroup_whh/bin/.gcc-5-post-link.sh

I don't know how to fix this problem. However, I decided to move on and see if I could ignore this error and skip this step.
When I tried python setup.py bdist_wheel, I again met errors:
running bdist_wheel
running build
running build_py
running build_ext
/home/wanghanhui/code/PointGroup/lib/spconv/build/lib.linux-x86_64-cpython-37
Release
CMake Error at /home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/CMakeDetermineCUDACompiler.cmake:277 (message):
  CMAKE_CUDA_ARCHITECTURES must be non-empty if set.
Call Stack (most recent call first):
  CMakeLists.txt:2 (project)

-- Configuring incomplete, errors occurred!
See also "/home/wanghanhui/code/PointGroup/lib/spconv/build/temp.linux-x86_64-cpython-37/CMakeFiles/CMakeOutput.log".
See also "/home/wanghanhui/code/PointGroup/lib/spconv/build/temp.linux-x86_64-cpython-37/CMakeFiles/CMakeError.log".
Traceback (most recent call last):
  File "setup.py", line 86, in <module>
    zip_safe=False,
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/__init__.py", line 87, in setup
    return distutils.core.setup(**attrs)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/core.py", line 185, in setup
    return run_commands(dist)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
    dist.run_commands()
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/dist.py", line 973, in run_commands
    self.run_command(cmd)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/dist.py", line 1217, in run_command
    super().run_command(command)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/dist.py", line 992, in run_command
    cmd_obj.run()
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/wheel/bdist_wheel.py", line 299, in run
    self.run_command('build')
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/cmd.py", line 319, in run_command
    self.distribution.run_command(command)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/dist.py", line 1217, in run_command
    super().run_command(command)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/dist.py", line 992, in run_command
    cmd_obj.run()
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/command/build.py", line 24, in run
    super().run()
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/command/build.py", line 132, in run
    self.run_command(cmd_name)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/cmd.py", line 319, in run_command
    self.distribution.run_command(command)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/dist.py", line 1217, in run_command
    super().run_command(command)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/_distutils/dist.py", line 992, in run_command
    cmd_obj.run()
  File "setup.py", line 39, in run
    self.build_extension(ext)
  File "setup.py", line 69, in build_extension
    subprocess.check_call(['cmake', ext.sourcedir] + cmake_args, cwd=self.build_temp, env=env)
  File "/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/subprocess.py", line 328, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '/home/wanghanhui/code/PointGroup/lib/spconv', '-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/wanghanhui/code/PointGroup/lib/spconv/build/lib.linux-x86_64-cpython-37/spconv', '-DCMAKE_PREFIX_PATH=/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/torch', '-DPYBIND11_PYTHON_VERSION=3.7', '-DSPCONV_BuildTests=OFF', '-DCMAKE_CUDA_FLAGS="--expt-relaxed-constexpr"', '-DCMAKE_BUILD_TYPE=Release']' returned non-zero exit status 1.

I continued to ignore these errors, hoping that they won't cause more trouble in the future. I went on to compile pointgroup_ops, and met the error:

running develop
/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/command/easy_install.py:147: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  EasyInstallDeprecationWarning,
/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/setuptools/command/install.py:37: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  setuptools.SetuptoolsDeprecationWarning,
running egg_info
writing PG_OP.egg-info/PKG-INFO
writing dependency_links to PG_OP.egg-info/dependency_links.txt
writing top-level names to PG_OP.egg-info/top_level.txt
reading manifest file 'PG_OP.egg-info/SOURCES.txt'
writing manifest file 'PG_OP.egg-info/SOURCES.txt'
running build_ext
building 'PG_OP' extension
/usr/local/cuda/bin/nvcc -I/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/torch/include -I/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/torch/include/TH -I/home/wanghanhui/.conda/envs/pointgroup_whh/lib/python3.7/site-packages/torch/include/THC -I/usr/local/cuda/include -I/home/wanghanhui/.conda/envs/pointgroup_whh/include/python3.7m -c src/cuda.cu -o build/temp.linux-x86_64-cpython-37/src/cuda.o -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --compiler-options '-fPIC' -O2 -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=PG_OP -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++11
In file included from src/cuda.cu:2:
src/datatype/datatype.h:7:10: fatal error: google/dense_hash_map: no such file or directory
    7 | #include <google/dense_hash_map>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: command '/usr/local/cuda/bin/nvcc' failed with exit code 1

I noticed that you mentioned to run python setup.py build_ext --include-dirs=$INCLUDE_PATH$ when seeing these kind of error. However, I am not sure with what I should put in place of $INCLUDE_PATH$, should it be "google/dense_hash_map" or anything else(it seems that putting this doesn't work out)?

I have met the same problem. Did you find the solution now, buddy?

Getting the same problem. Any solution for this?

@Tianhaowei2001 @SohaibAnwaar
Here's my final solution.
I used a docker container to gain root access. For spconv compilation, I simply used gcc-7.5 and it was ok.
If you get fatal error: boost/geometry.hpp: No such file or directory, you can try sudo apt install libboost-all-dev to solve the problem.
If you get error: no matching function for call to 'torch::jit::RegisterOperators::....', it seems that this is because spconv used an older pytorch version. You can modify torch::jit::RegistorOperators to torch::RegisterOperators in the file spconv/src/spconv/all.cc.
As for pointgroup_ops, my main problem was fatal error: google/dence_hash_map: No such file or directory, if you also meet this problem, you can solve it by using sudo apt install libsparsehash-dev (at least it solved mine).
I hope this will help you with your problems.


New Feature : Change Conda Store's URL

Gator, when using Conda/Mamba as a backend, uses the binary available on the system on which it runs.
Using Conda Store as a backend, we need to give its URL. By default, and during our development cycles, this URL is hardcoded and considered being localhost:5000, but Conda Store may be deployed on another server, and another port than 5000.
Thus, we need to be able to edit this URL. I have listed two options, but other suggestions and ideas may come up :

For the JupyterLab extension itself, we'll need a place in the UI to setup the API endpoint of Conda Store.
For the standalone version (which actually spins a JupyterLab with the extension), we may pass the URL as an option in the command line.

This change will be necessary for the first phase of the project, as we don't intend on shipping code with an hardcoded URL.
You can see the original conversation here.
Next phases :

[ ] Define other options
[ ] Scope the necessary work for the ones we'll make
[ ] Implement

Work in progress in the Quansight/gator::set-conda-store-url branch.

Internal review has been done
merged, but into master
Once we have merged into mamba-org's repository, we will cherry pick the specific commit and open a PR on the dedicated branch upstream conda-store-integration

Merged: https://github.com/mamba-org/gator/pull/161


[devel3] in method _search_repositories in UdockerCLI, var repo_list is a list not dict

Defined as
repo_list =
self.dockerioapi.search_get_page(expression, term_lines)
which is a list, but after tries to use as dict()
if len(repo_list["results"]) > lines:

the return value from udocker.docker.DockerIoAPI.search_get_page can be a list() or a dict(), need to fix here

this ends up from the result of a json.loads in class udocker.docker import DockerIoAPI
DockerIoAPI.search_get_page
and the output of json.loads -> Any so it can be a list or a dict
will close the issue


Heavy Weapons being Heavy Weapon

cant get %hp dmg on any axe or something else nothing counts towards heavy weapons. curently playing atm9 if that matters

Had something like this happen just now as well (on a dedicated server)
re-joining the server fixed the issue and the affixes were shown again
Is your weapon affixed but isn't showing any? If yes did you check the NBT of the item?

Not sure what could cause such an issue.  The selection logic is deterministic.
The only thing I could think of is maybe this change, but if relogging fixes it then nothing about this change would be relevant.
I do realize that ShieldBreakerTest can leak the level however, so I'll have to address that.

might just be some weird server sync issue
i also had 1 gem not being recognized (it was shown as errored gem)
re-logging fixed that as well (i don't use the passive skill tree mod or apotheotic additions)
another player also had problems (i think some non-heavy-weapon didn't show the affixes)
same fix

The loot category selection is deterministic and unsynced, though if the adventure.cfg type overrides become disjoint between sides issues may occur, but that would also not be fixed by a relog.


Gallery Image Mixup, Non New Games Have 'New' Tag

Describe the bug
Both happen in the gallery. Sometimes, games will have the wrong image, and it seems that the games at the top of the list always have the 'new' banner thing. I suspect the image issue is caused by some optimization somewhere, and the 'new' banner issue is probably because it's designed to work with sorting by date, and also it's designed to work with all games (none filtered out)
To Reproduce
Steps to reproduce the behavior:

Go to Gallery
Search for something (I searched for all of my games)
See items with 'new' banner on the top
Scroll down, see items with wrong image

Expected behavior
Only new games have the new banner, games have the image that is assigned to them, not the image assigned to others.
Actual behavior
Any games at the top after searching have the 'new' banner, and images sometimes show up above the wrong games.
Screenshots

Expected screen

the filtering issue is fixed since #1400
however I'm unable to reproduce the scenario where the images are incorrectly placed

Expected screen

where did you get this expected screen btw?

however I'm unable to reproduce the scenario where the images are incorrectly placed
you have to type fast and scroll down fast. then the wrong images are used.

https://github.com/hackclub/sprig/assets/70179858/3f119310-46c7-4c32-a623-64d681c2901a

where did you get this expected screen btw?
i did the typing/scrolling slowly to get the right images, then used inspect to get rid of the 'new' labels

@Omay238 what browser are you using here?

Arc 1.26.0


Fixed method spelling

Opps - thank you

Coverage remained the same when pulling b4d0dfbcd1c3efeebdc4a4b4f117cc346e969839 on Toflar:bugfix/fix-spelling into 725f578f2a9d071b909b69e06c79c8c108218862 on alecsammon:1.0.0.


Add integration with Extra Machine Config's per-recipe fuels.

Link to EMC's Nexus page and GitHub repo.
What this does:

Sets StardewValley.Object.autoLoadFrom to the inventory being checked (and unset it upon exiting the function) since EMC's patches on the base game functions that checks whether a machine output rule is valid assumes they're being called within the context of player hand feeding or hopper/Automate autoloading, which sets that field accordingly in the latter case.
Calls EMC's API to retrieve the extra fuels and adds them to the list of items a Junimo must bring to a machine.
Changes the method of retrieving machineItemOutput from testing all of them with GetOutputItem to simply calling GetOutputData and then GetOutputItem. This is not directly related to EMC, but it brings the logic to be inline with the game's own OutputMachine function, and improves compat in the case of multiple output rules where not all of them are deemed valid by EMC.

Tested with Cornucopia Artisan Machines, particularly with its rules for the mayo machines that use eggs as additional fuel instead of the primary input. Put a Cornucopia Peppercorn (in the first slot) and some eggs inside an input chest; before this PR, the peppercorn is ignored and the eggs are loaded to make plain mayo; after this PR, the Junimo should take the peppercorn and an egg to make peppercorn mayo.

I haven't looked at Automate recently - is comparable code in there or did Pathos do something to avoid the need for this?
Let me know when you're done iterating and I can kick the tires myself.  I don't see anything structurally wrong with the code as it is now, I might find some ticky-tack things if I looked harder at it.

Automate uses the Hopper code directly, so I didn't need to asd any explicit compat.

@NermNermNerm I should be done with this PR, please take a look and let me know if you need any more changes.

Merged - also I merged it with the work I've been puttering at.  If you're in a position to, please test with that branch:
https://github.com/NermNermNerm/Junimatic/pull/9
Also, any comments on that PR would be appreciated!
As far as I can see, my changes should work fine with yours, but I haven't installed and tested with Cornucopia yet.


Selecting extensions when used with home-manager

I managed to use this overlay in my home-manager config (flake) by doing the following:
outputs = { nixpkgs, home-manager, rust-overlay, ...}: {
    homeConfigurations.myUser = home-manager.lib.homeManagerConfiguration {
        modules = [
             # ...
             ({ ... }: { nixpkgs.overlays = [ rust-overlay.overlays.default ]; })
        ];
    };
};

With this setup, I get rustc and the other default components and that works fine.
Is there a way that I can add extra components like rust-src ? I tried to add pkgs.rust-bin.stable.latest.default.override { extensions = [ "rust-src" ]; } to home.packages but that doesn't work.
Note that I'm not on NixOS but I run nix in multi-user with systemd.
Thanks!

I was just missing some parentheses around the override call, my bad


advanced search: add help text or simplify

Help/search suggestions & commands are obscure; require metadata knowledge. More examples or a guided Advanced search would be helpful.

Closing in favour of https://github.com/inveniosoftware/product-rdm/issues/35


Added BMI1, BMI2, F16C, MOVEBE, and  aligned-allocation/free plus some minor additions.

Hello Guzba,
this pull-request adds some new Tags :

BMI1
BMI2
F16C
MOVEBE

Moste of the functionality of BMI 1+2 is already in std/bitops. But for demo-purposes it might be ok, to have them explicit here.
More important to me is the addition of aligned-allocations and prefetching to nimsimd/sse2.nim :

mm_alloc()
mm_free()
mm_prefetch()
mm_sfence() # whatever this does - not tested..

I've used the aligned-allocations in two projects of mine. So consider them tested and usable, except the sfence()-thing.
Some functions were missing from nimsimd/avx2.nim. According to the Intel-Intrinsics-Guide, they should be avail.
The CacheLineWidth-detection works for me. I have not found a similar way to inquire this info for Arm or AppleSilicon or RISC-V cpus. Its just a starting point. Since i believe the CacheLineWidth to be the crucial-information when dealing with SIMD, i'd love to see this information availiable for all commonly  cpu-architecture used by nim ? What do you think ?
Same could be said for the L1,L2,L3-sizes.
best regards, Andreas (a.k.a. bosinski)

Hi and thanks for the PR. Taking a quick look, one thing I noticed is the use of static pointer. This is not the same thing as void const * ptr in the Intrinsics Guide https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#ig_expand=4243,5873,4037&othertechs=MOVBE
A static pointer would need to be known at compile time which I do not see as compatible with heap memory and the use of these operations.

I took a closer look this time and did notice a couple things to check on:

_bextr_u64  should start and lenasunsigned int` in the intrinsics docs, as opposed to 64-bit parameters
_bzhi_u32 and _bzhi_u64 index parameter looks like uint32
mulx_32 intrinsic and name should be _u32, same for 64 _u64, these also have the 3rd parameter as a pointer in the intrinsic

It will be great to have a bunch more instruction sets available when we've got them looking good.

ok, BMI1 & BMI2 should be fine now. thx for the review.
greets and have a nice weekend :)

Hi guzba,
i've noticed that the something did not pass the GH-pipeline ?
Is there anything i can do ?
Greets Andreas

Hello and thanks again for this PR. There were still some issues here so instead of continuing to tweak this over time, which may be time consuming, I chose to extend these commits in a new PR and do the remaining fixes here https://github.com/guzba/nimsimd/pull/26
Note that I did remove the queryCacheLineSize call due to the implementation not looking correct to me (should be an unsigned shift, I think incorrect register used, need to check a feature flag to see if the data is present and valid, etc). More info here https://www.felixcloutier.com/x86/clflush if you'd like to work on that in a separate PR.

Very nice and thx for including the important tags.
Regarding the detection of the CacheLineWidth in queryCacheLineSize(). I somehow remember that the leg from the Felix Cloutiers' documentation gave me unreasonable results. I then looked at a CpuId-implementation in Rust and found that they used a different leg. So i tried that one, but only had one machine to test against. So that may well be not correct. If i understood it right, then on Intel-Cpus its supposed to be always 64-Byte - thats easy. On AppleSilicon (M1 up to M-2024) its supposed to be 128-Byte - thats seems easy, too. To do the detection on any other CPU (Arm, RISC-V, Power, etc.) might get hairy.
Maybe it makes more sense to make this a compile-time-option, which defaults to 64, but can be set via -d:cacheline=128 ? Since i've never heard of a CacheLineWidth >128 or <64.
Anyways, i'll retry in pullreq-26.

If you have a different source for how to get the cache flush size, that'd be totally fine with me. I don't mean to imply the website I linked is the only authority. If you have a solid one, please just point me to it so I can properly ensure I learn and agree the implementation is correct and ready to go.


Added deploy with modal.

Description
Added deploy with modal

@burnash - ready for review. Thanks!

the more i think about it actually, maybe it makes sense to write a really pared down example for this space that is runnable end-to-end for the user (e.g. using duckdb) and linking out to our blog post for a "real-world example". happy to help contribute a pared down example

here's a simpler gist that should just work if you run modal run dlt_example.py and will deploy a daily scheduled job with modal deploy dlt_example.py.
i think this section will have better engagement if the user can simply copy-paste a script and it works immediately; we can adapt this to your docs style and perhaps just link out to the original blog post as a more detailed, real-world example of dlt (i also need to update that one to be compatible with 1.1.0).
lmk what you think! also happy to chat i know ive shared a lot of info here haha.
https://gist.github.com/kning/6a2af9e08ebaad0e486968f98c1939be

@kning hey! Thanks for your thoughts here, your idea with testing is great! We actually practice this, you can find here some getting started snippets that we test on every CI/CD run. We can also add your gist to our testing process, we just need to understand what we call a successful run, we can run this command modal run dlt_example.py on every CI/CD run and stop it immediately if it ran without errors, is that enough? or should it be deployed as well?

running modal run dlt_example.py should be sufficient, but you'd also need to set up a Modal account and set the MODAL_TOKEN_ID and MODAL_TOKEN_SECRET variables in your CI environment.
also checked out the snippets, are those ever surfaced in the docs? i guess i'd expect it to be synced with the snippets on this page but it looks different.

@kning

MODAL_TOKEN_ID and MODAL_TOKEN_SECRET variables in your CI environment.

It shouldn't be a problem.

i guess i'd expect it to be synced with the snippets on this page but it looks different.

We changed our docs significantly recently, and getting started page was removed and replaced with intro. Relevant example you can find here: doc and snippets

i see. how do you think we should move forward then with the modal snippet? ideally i'd like to see a "deploy with modal" page that explains how to create a modal account and the runnable code snippet (which should also regularly be run somehow to ensure that it's correct) and finally a link to the blog post for a "real-world" example. but i guess from what i understand it seems that code in the docs page and CI/CD snippets are managed separately?

@dat-a-man will do that, he will create a snippet file with example and use tags to ingest this snippet into doc page, here we will run modal command to test it

amazing looks way cleaner now, thanks!

left a few tiny comments, but any other hold up here? would love to get this published soon!

@kning hey Kenny! Everything is ready to be merged, we just need modal token for tests, is it possible to run it without token? does this token expire? how often we should refresh token? can we do that automatically? Can you help us with it?

you need to create a modal account / token for yourself, we actually have a guide for this: https://modal.com/docs/guide/continuous-deployment. fwiw, i wouldn't consider that blocking if it's too much work for now i know you've been working hard on this for a long time and i can always help you figure out the ci / cd modal part later.

@kning let's move this conversation in our slack :D I contact you there, I think it will help us to solve this problem faster

woohoo! i don't see it on the docs website yet though is there a separate deploy process?

@kning You can see it in devel version here (it will be publish in main documentation with next release) https://dlthub.com/docs/devel/walkthroughs/deploy-a-pipeline/deploy-with-modal

great! reading this there are some parts of the modal API (e.g. proxy, etc.) that have updated, i can go ahead and open a pr later.


Java: missing "default" word highlighting

Hi.
Please, fix "default" word highlighting for java code.
IntelliJ example (correct):

Github example (wrong):

P.S. Github support send me here cause github uses that library on website.

Sorry, that's lib was for desktop. Github's website uses textmate (related issue https://github.com/textmate/java.tmbundle/issues/48)


Why can't I reproduce the accuracy of the paper according to the experimental settings given by your code?

I did the distillation of fgd_retina_rx101_64x4d_distill_retina_r50_fpn_2x_coco according to the settings in the paper, but the accuracy is lower than the baseline. I don't understand why this result occurs?
20220527_173012.log

You use mmdet==2.24, so you should add self.student.init_weights() in mmdet/distillation/distiller.py. Besides, you don't need model.init_weights() in tools/train.py for distiller. You can refer this issue or  this repo MGD


Docker compose secure example does not change config.yml correctly

I am working with portus with docker-compose in a production environtment. I had to change config.yml from portus container the url to get it correctly and login with docker login.

Can you tell me whether this works when using mssola/portus:susecon ? If so, then you are hitting #1418 (which is the most probable cause).


push communication-sms recordings

fix https://github.com/Azure/azure-sdk-for-js/issues/28656

API change check
API changes are not detected in this pull request.


Chat control buttons are lacking accessibility descriptions

Bug Report

Installation Method
I use podman and I use the latest image.
Environment

Open WebUI Version: 0.3.35

Ollama (if applicable): not relevant

Operating System: Fedora 40

Browser (if applicable): Firefox 132

Confirmation:

[X] I have read and followed all the instructions provided in the README.md.
[X] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.
[X] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
When accessing the buttons around the chat area with a screen reader, I expect to get their description / label announced.
Actual Behavior:
When accessing buttons, they are announced only as "button".
Description
Bug Summary:
Buttons around the chat area are lacking accessible descriptions.
Reproduction Details
Steps to Reproduce:
Start a chat.
Start a screen reader.
Use the TAB key to move through the interface until you reach buttons for regenerating chat, thumbs up / thumbs down etc. Move through buttons with tab.
Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots/Screen Recordings (if applicable):
[Attach any relevant screenshots to help illustrate the issue]
Additional Information
I am willing to test your updates if you provide it in a contianer image or something like that.

#2790


Incorrect links in AutomationProperties doc

It seems that there are many links in the AutomationProperties doc which should navigate to another page but instead don't navigate anywhere.
Let's take Windows.UI.Xaml.Automation.AutomationProperties.AccessibilityViewProperty as an example:

MSDN doc
GitHub source

The beginning of the documentation for that property starts with "Identifies the AutomationProperties.AccessibilityView...". The last word, "AutomationProperties.AccessibilityView", is a link which brings me to the exact same part of the documentation I was looking at. However, I believe that link should have brought me here instead.
It seems this kind of mistake is made all over the AutomationProperties documentation
Adam Comella
Microsoft Corp.

Thank you @rigdern for bringing this to our attention.
@Xansky can you respond to this?

Hi Adam,
I apologize for the delayed response. I did some research and learned that we are aware of this problem and it is being tracked by an internal work item. Therefore, I'm closing this thread on GitHub. Thank you for taking the time to let us know about this.

Mark


Create requirements.txt

I had a hard time installing dependencies by hand. I can raise a PR if needed. Dependencies are:
imutils
opencv-python
numpy
request

One of the dependencies of request - public is broken because of missing README (Actually, it was renamed to README.md from README.rst), I had the following workaround:
git clone https://github.com/russianidiot/public.py.git
cd public.py
mv README.md README.rst
pip install .

and then normal installation
Also, it would be helpful if you had already mentioned python3 somewhere.

I pull request would be helpful! Thanks for pointing it out.


Bug: DC component is wrong

See the following example:
julia> using EasyFFTs, FFTW

julia> let sig = ones(10000)
           easyfft(sig) |> display
           getindex(fft(sig)./length(sig), 1) |> display
       end
EasyFFT with 5001 samples.
Dominant component(s):              ╷
   Frequency  │  Magnitude
╺━━━━━━━━━━━━━┿━━━━━━━━━━━━━╸
      0.0     │   1.9996
              ╵

1.0 + 0.0im

The easyfft version estimates the DC amplitude to be double of what it actually is.

Is it appropriate to simply divide DC component by 2? This really makes it an improper version of rfft, but the entire point is that the native synthesis formula of multiplying sinusoids of the amplitudes and frequencies should work, which requires this.

This is not really acceptable:
julia> let sig = ones(10000)
           @show easyfft(sig)
           @show easyfft(sig.|>ComplexF64)
       end
easyfft(sig) = EasyFFT with 5001 samples.
Dominant component(s):              ╷
   Frequency  │  Magnitude
╺━━━━━━━━━━━━━┿━━━━━━━━━━━━━╸
      0.0     │   1.9996
              ╵

easyfft(sig .|> ComplexF64) = EasyFFT with 10000 samples.
Dominant component(s):              ╷
   Frequency  │  Magnitude
╺━━━━━━━━━━━━━┿━━━━━━━━━━━━━╸
      0.0     │     1.0
              ╵

EasyFFT with 10000 samples.
Dominant component(s):              ╷
   Frequency  │  Magnitude
╺━━━━━━━━━━━━━┿━━━━━━━━━━━━━╸
      0.0     │     1.0
              ╵

I will divide the DC component in the AbstractVector{<: Real} method.

I don't quite remember the theory, but this seems necessary. I also remember having done something like this manually in the past so it's probably right. I think rfft includes the DC component twice (f = ±0). Can't really speak for whether that's correct, but the useful thing is to halve it.

Agreed. I will keep the halving implemented in the last PR. I am also implementing a new function that I needed, so I will tag a new release once that is added.

I implemented the mentioned function in https://github.com/KronosTheLate/EasyFFTs.jl/commit/f1c382b6e5afee83b996cc4aa937f1e11811a246, along with fixing typos, moving utility functions into "utils.jl", make domfreqs use finddomfreqs internally, and updating the readme. We also need some tests at this point, just because I always have an uncertainty about if I accidentally broke something. If you have the time and energy, a review of the changes would be appreciated.


Public servers button too low

The public servers button is cut off into the divider line. (See screenshots)
Screenshots

Desktop
Discord channel: Stable
OS: OSX
Mod: BetterDiscord
Additional context
I resolved this issue by adding: --toolbar-height: 30px;

Fixed.


Fit images in shapes (Feature request)

Would be great to have a checkbox to set image pattern fill type to Fit instead of Fill

@vladmoroz as a conditional action, you mean? meaning you can change this setting driven by data?

Just a simple setting like this
Alternatively, would be great if plugin would respect layer's pattern fill type and not overwrite it

respect layer's pattern fill type and not overwrite it

that's something we could do, right @lukasondrej? (i think when we implemented it back then there were no options for the fill)

Maybe a layer name based approach would be better... ie {imgURL | fill} or {imgURL | fit}

Alternatively, would be great if plugin would respect layer's pattern fill type and not overwrite it

Pull request for temporary disable on #78, as suggested by @vladmoroz

thanks @rezaarkan @vladmoroz @shannon-murdoch-webjet!
please check out v2.1.2
https://github.com/preciousforever/sketch-data-populator/releases


Implementation of result line

I added an initial implementation for showing result line (income + expenses).
This allows to quickly see the operation result for any given period, and to understand the amount that is transferred to equity for the next period.

You can get the same effect more generally using some available switches
Option 1) Using the -r flag:
knut balance finance.knut --last 12 --months -r Expenses -m1 -vUSD

Not sure it is documented properly, but it takes a regex and will remap the first segment of the account name it as follows:
Income is mapped to Expenses
Expenses is mapped to Income
Assets is mapped to Liabilities
Liabilities is mapped to Assets
This is useful because technically there is no difference between an Income and an Expense account, besides aeathetics.
Option 2) Using the -m0 switch with a regex. For example:
knut balance finance.knut --last 12 --months -m0,"^(Expenses|Income)" -m2 -vCHF

which prints the difference ("all the accounts mapped to 0 levels") in the "Delta" line at the bottom.
These two options allow for more flexibility than this PR, as they allow for targetting individual accounts. For example, I might be interested in the net income defined as work (but not investment) income, minus taxes and costs of living (but not investment expenses).

Thanks for the prompt reply!
The -r flag solves exactly what I was looking for. Just didnt find it in the readme, so thats why i cooked together this PR instead.
Will close this PR, as the -r flag solves the issue of creating a result line.

Was also able to achieve the same with knut balance --years "-m0,(Equity|Assets|Liabilities)" finance.knut -vUSD, as this also generates an income statement with the result line being in the total row.
Great library you have put together!

Thank you :-)
I continued to play arond with your idea a bit. While I think the net income would be useful to have, the problem is that I don't find a visually pleasing way to add subtotals to the balance report.
With subtotals on the EIE side of the balance, everything becomes less symmetric. Plus, subtotals make it harder to see that "knut always balances" (a core principle), as they add visual clutter no matter what.


Not working with local domains

I've installed the smee client and set up the smee channel. The following command works fine:
smee --url https://smee.io/my-channel-id --path /github/webhook --port 8000
It delivers all payloads to http://<IP_ADDRESS>:8000/github/webhook url properly. But if I use my local domain which I've setup with Valet, it doesn't work.
Here is my command:
smee --target http://myapp.test/github/webhook --url https://smee.io/my-channel-id
I also tried supplying port, but it doesn't work:
smee --target http://myapp.test:8000/github/webhook --url https://smee.io/my-channel-id
Am I missing anything here?

the usage looks correct to me ... could you try to find out what's going wrong? Maybe you caught a bug

I'm seeing something similar. It looks like my actual server (http://myapp.test:8000/github/webhook based on the OP example) isn't actually receiving the request from smee-client. smee-client is somehow catching a 404 response from the target, but my server isn't actually being forwarded. I'll include more details if I can figure out exactly what is going on here, but I suspect it might have something to do with the host header getting dropped somewhere? I'm not using Valet at the moment, but I'm guessing the target URL is being resolved correctly but maybe being accessed by IP or in some way in which the original host isn't being propagated to the request smee-client is making against my server. In my case I'm using traefik instead of Valet.

Oh, hey, this was fast! :) I think I was correct, here. In the case of both Valet and my traefik setup, the idea is to host multiple sites between one endpoint/reverse proxy. So, my setup looks like this:
NODE_TLS_REJECT_UNAUTHORIZED=0 \
    smee \
    --url https://smee.io/mVGuv0UG42AdJ7wA \
    --target https://prdeploy.test/github-app

I started digging into the logs a little deeper and I can see what's going on here:
reverse-proxy_1  | time="2021-12-12T00:00:51Z" level=debug msg="Serving default certificate for request: \"smee.io\""
reverse-proxy_1  | <IP_ADDRESS> - - [12/Dec/2021:00:00:51 +0000] "POST /github-app HTTP/1.1" 404 19 "-" "-" 1947 - - 0ms

It looks like smee-client is passing on the original host (smee.io) from the URL to the target host. Since my app is listening on prdeploy.test and not smee.io, it's throwing a 404. I'm guessing the same thing happens with Valet since it is a reverse-proxy machine sorta like what traefik is doing.
Ideally, I would have expected in my case for the target host to NOT be dropped. I sorta thought it was weird (unexpected?) that the port and path were specified independently when the --target required a full URL.
If we wanted to support this behavior, what would be the best way to do so? :) Should we add a flag like --keep-original-host or something?

Looks like this is likely related to #162. I'm going to send an alternative patch as I don't know if deleting the host header is the correct move here.

is myapp.test a virtual host on your web server? if that is the case the web server uses the HOST header to resolve the HTTP request. smee passes HOST=smee.io instead of the --target hostname which produces a series of problems including if you have ssl certificates

Just come across this same issue too.
Valet uses dnsmasq to allow using domains in the .test namespace, but smee doesn't seem to work with them. It's resolving to my valet server, but only returning a 404 which suggests it's not resolving to the correct site.


the browser can't be closed automatically when the test end

Hi @ww18 ,
As you did not provide any description I guess you used the following code from the README.md:
this.After(function(callback) {
    this.quit(callback);
  });

If so please, add another function parameter before callback like this:
this.After(function(scenario, callback) {
    this.quit(callback);
  });

It works for me. Did it help for you?

This sill won't close the browser if an error occurred. For instance, sometimes the After step times out.

Same problem after timeout.


[BUG] Files inside .github maybe ignored

Describe the bug
I had this .github/config.yml, and it pointed as an issue in the repo... Maybe .github files, or just the config.yml can be ignored since it's not very likely for a repo owner to have todos in workflows files
todo:

  keyword: "TODO"

  keyword: "@FUTURE"

To Reproduce
Steps to reproduce the behavior:

Put TODO like above in config.yaml

Screenshots

Not much desired, just to point out, since this isn't actually problem that will bother much.

👋 your config file isn't valid YAML, I'd recommend trying it in a YAML validator. You can't have multiple keys of the same name (you have two keyword properties).


Move debug flags to buildOpts struct

Created buildOpts struct in build command and moved the debug flags to it (as they are relevant only for build).

/cc @nmagnezi

/retest

/test e2e-compact-ipv4-static

/retest

/test e2e-compact-ipv4-static


Create an ara::com example to showcase usage with AUTOSAR Adaptive

Brief feature description
iceoryx can be used as an ara::com implementation defined in AUTOSAR Adaptive and was created in 2015 exactly for this use-case. However, the iceoryx API has change in the last releases. To make it easier for users writing the glue code an example shall be created.
Detailed information

The example shall contain..

[ ] Proxies and skeletons
[ ] Discovery
[ ] Service with event, field, method

Further tasks

[ ] Introduce is_lambda and use it here

Closing this issue in favour of https://github.com/eclipse-iceoryx/iceoryx-automotive-soa/issues/2


Add PublicHoliday Controller

In this PR, we add an endpoint /api/publicholidays/get that can be used to get information about public holidays for a given year and country.
Dev deployment: http://team01-chloeqta-dev.dokku-07.cs.ucsb.edu/swagger-ui/index.html
Closes #11

LGTM


Fixes popovers.

closes #1520

To test locally using fixtures:

Open "Testing sinopia lookup" resource template.
Click on the i in the circle.

Expected result:
Popover!

Is it a tooltip or a popover? Popovers require clicking.

Is it a tooltip or a popover? Popovers require clicking.

Yep, Bootstrap popovers require clicking (I think I may be mis-remembering the old behavior using the React Bootstrap)


[Run] [Plugin manager] UI fixes

Summary of the Pull Request
What is this about:

Consider showing a warning when all plugins are disabled

Consider validating Action keyword for * and ~

Reconsider author placement #9650 (comment)

Reorder Plugins and Appearance sections

Not allowed action keywords are: "~", "\", "\\". All of them rewrite the behavior of the folder plugin. Take into account that we show a warning but a user still can use not allowed action keywords.
How does someone test / validate:
Check if warnings are shown.
Quality Checklist

[X] Linked issue: #9653
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[X] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

I don't like the new place for the author. Imo it looks like "Hm. We forgot the author and need a place for it now. Let's use the corner to not have to move the existing controls."
I think we should use the place we have so far (The line under the description.) or we move it behind the plugin name (See concept images in the spec.).

@htcfreek
while it's important to give credits to the authors, having the author along the description is a distraction.
The new location is appropriate.

@mykhailopylyp "Include in global result" => what does "global" mean? And what does this do vs. turning off the plug-in itself?

@mykhailopylyp "Include in global result" => what does "global" mean? And what does this do vs. turning off the plug-in itself?

Good point. We could rename it to or add this as description: "Show results without using an activation phrase"

@mykhailopylyp Two remaining points:

I'd move the Keyword phrase box at the top of the settings panel, so it's near the (potential) warning message and put the "global result" checkbox below it.
Align "keyword" / "activation phrase" wording.

@niels9001

"Include in global result" => what does "global" mean?

We have plugin specific search(when the search starts with an activation phrase). And "Include in global result" means include plugin result when there is no activation phrase. The naming is according to specs. It seems as we can do a better job with naming here.

And what does this do vs. turning off the plug-in itself?

If a plugin is turned off it can not be used from PT Run.
If "Include in global result" is unchecked a plugin can still be used using an activation phrase.

@niels9001

I'd move the Keyword phrase box at the top of the settings panel, so it's near the (potential) warning message and put the "global result" checkbox below it.

I think we should leave it as it is. For example, if we have two fields that we validate, which one should be on top?
Furthermore, it should be under description and not under the text box so it is apparent to a user and can not be missed easily.

@htcfreek @enricogior

We could rename it to or add this as description: "Show results without using an activation phrase"

What about: "Show results of the plugin in the global result list"?

@htcfreek @enricogior

We could rename it to or add this as description: "Show results without using an activation phrase"

What about: "Show results of the plugin in the global result list"?

I don't like this "global results". Because I think that users, who doesn't know the technical details, doesn't what this is.


Handling different @keyframes rules with the same identifier

Input:
.box {
  animation-name: spin;
}

@keyframes spin {
  0% {
    transform: rotate(0deg);
  }
  100% {
    transform: rotate(360deg);
  }
}

/* different angle */
@keyframes spin {
  0% {
    transform: rotate(0deg);
  }
  100% {
    transform: rotate(720deg);
  }
}

/* different order */
@keyframes spin {
  100% {
    transform: rotate(360deg);
  }
  0% {
    transform: rotate(0deg);
  }
}

/* different unit */
@keyframes spin {
  0% {
    transform: rotate(0turn);
  }
  100% {
    transform: rotate(2turn);
  }
}

All @keyframes are preserved after minification now but in fact only the last one is valid. Currently only @keyframes with exactly same style rules and identifier can be handled correctly.

Actually we don't need to check if two @keyframes blocks are all the same and we can discard all of them except the last one.

Think this would be a good addition to https://github.com/ben-eb/postcss-merge-idents. Pull requests are welcome. 👍

Nice!

I made a simple plugin to discard at-rules which are overridden by those share same identifiers:
postcss-discard-overridden
Maybe we can put this before merging.

@Justineo Let's look at adding this for cssnano 3.6, but we need tests for it in this module. 👍


feat: Add metadata_configuration to FSx Lustre, aggregate_configuration to FSx Ontap, and file_system_endpoint_ip_address attribute to Openzfs

Description

add metadata_configuration to aws_fsx_lustre_file_system
add aggregate_configuration to aws_fsx_ontap_volume
add size_in_bytes to aws_fsx_ontap_volume
add volume_style to aws_fsx_ontap_volume
add file_system_endpoint_ip_address attribute to openzfs module

Motivation and Context
https://github.com/hashicorp/terraform-provider-aws/pull/36511
https://github.com/hashicorp/terraform-provider-aws/pull/37868
Breaking Changes
No.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 1.1.0 :tada:


Textual definition update: GO:1990244 histone H2AT120 kinase activity

GO term ID and label for which you request a definition update
GO:1990244 histone H2AT120 kinase activity

New proposed definition (genus-differentia pattern, plus additional information if needed)

Current def is "Catalysis of the transfer of a phosphate group to the threonine-120 residue of histone H2A. PMID:24140421".  But this doesn't specify in which species/group the threonine is at residue 120.  E.g. in Drosophila, T120 is corresponds to T119 (PMID: 15078818).
Looks like the paper used for the original definition used human cell lines, so maybe the new def should be something like "Catalysis of the transfer of a phosphate group to the threonine-120 residue of histone H2A (residue numbering refers to human H2A). PMID:24140421"

Reference(s)
PMID: 15078818

Additional information

Might be other similar cases where the stated residue number isn't universally correct....

We dont systematically have this - I suppose we should do this for every histone modification term ?

Hmmm, I guess the first thing to do is to figure out how big a problem this is.  Seems that histone H2A varies slightly between flies and humans, but I haven't checked the other histones, or compared more distant species....  Maybe all other key residues are at exactly the same position in other histones/species (though I doubt it)??
Assuming that any given numbering in a GO term name/definition is at least correct for humans (or mammals/vertebrates), then adding a caveat/note along the lines of "residue numbering according to human" to every histone modification term mentioning a specific residue would at least address this point.  (eg., for the GO:1990244 example, I almost made a ticket to request a new term for 'histone H2AT119 kinase activity' before I checked that human T120 = fly T119)

There seem to ba many positions that vary on most of the histones, see https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5732057/figure/F1/

Hmmm, I guess the first thing to do is to figure out how big a problem this is.

A fix that can be generalized would be good here. I don't know of any handy statistics, but it's common to observe that an amino acid sequence motif is well conserved across species, and the modification of a very well conserved amino acid residue within that motif has well-conserved functional consequences, BUT the exact numbering of the residues of the motif differs between species because of indels accumulated elsewhere in the protein over evolution.
Is there general agreement that all annotation of this sort shall be with reference to a human canonical protein and its UniProt amino acid sequence? And is the UniProt human proteome a generally accepted starting point for this?

Is there general agreement that all annotation of this sort shall be with reference to a human canonical protein and its UniProt amino acid sequence? And is the UniProt human proteome a generally accepted starting point for this?
That seems like the only practical solution here, and I assume it's already the case but just isn't explicitly stated in the definitions/comments.

Any preference as to whether this should go in the comment or in the definition? It seems more appropriate for a comment, the only concern would be that this is not sufficiently visible. What do you think ?

Yes, it does seem more appropriate as a comment.  And then you can just add the same generic comment to all affected terms.


standardise input between qflex and ShallowQC

qflex has a variable num_qubits which is read in as the first line of an input file, and is assumed to be the number of qubits in a rectangular grid of size I * J. (All qubits set to off are ignored.)
ShallowQC also has a variable named num_qubits, which is also read in as the first line of an input file, but denotes the number of qubits in the circuit. Consequently, when qflex reads in a ShallowQC circuit file, it has to read the first line into a dummy variable, then calculate num_qubits based on I and J.
The file formats should be reconciled so that circuit files can be shared without modifications to inputs or source code.

ShallowQC has indeed been discontinued. I think it makes sense to defer the convergence with qsim until it is open sourced, because qsim's format may change before that happens. I propose to close this issue.


The overriding of TargetPlatformIdentifier to UAP in Microsoft.ApplicationModel.Resources.PriGen.targets should not be specific to .NET5, it should accommodate newer versions.

How to repro:
Use WinUI3 from Project Reunion with .NET MAUI. .NET MAUI depends on NET6.

Fixed in #707


Check for previous/existing GitHub issues/module proposals

[x] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[x] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/cache/redis-enterprise
Module Details
There is a similar avm/res/cache/redis module, but it only but only covers Microsoft.Cache/redis resources (Basic, Standard, and Premium tiers).
Resource type: Microsoft.Cache/redisEnterprise
https://learn.microsoft.com/en-us/azure/templates/microsoft.cache/redisenterprise?pivots=deployment-language-bicep
https://learn.microsoft.com/en-us/rest/api/redis/redisenterprisecache/operation-groups?view=rest-redis-redisenterprisecache-2024-10-01
This would bring support for the Enterprise and Enterprise Flash tiers (pricing table) and the just announced Azure Managed Redis offerings (Memory Optimized, Balanced, Compute Optimized, and Flash Optimized tiers) (pricing table) since they both use the same resource provider and resource type.
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
JeffreyCA
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @@JeffreyCA,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @JeffreyCA,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

Resource reference: https://learn.microsoft.com/en-us/azure/templates/microsoft.cache/2024-10-01/redisenterprise?pivots=deployment-language-bicep


Give Openshift user access to charts directory

I was having problems with make patch-charts-in-cluster. The commands got various "permission denied" errors. This seemed to resolve the issue - it gives the root group read/write access to the app directory (the container user in OpenShift is always a member of that group).
See https://docs.openshift.com/container-platform/4.7/openshift_images/create-images.html#use-uid_create-images

The error looked like:
❯ make patch-charts-in-cluster
./cicd-scripts/patchCharts.sh
open-cluster-management
multiclusterhub-repo-84c9c87f5c-jx4c5
/Users/jkulikau/workdir/stolostron/multiclusterhub-repo
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/application-chart-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/assisted-service-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/cluster-backup-chart-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/cluster-lifecycle-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/cluster-proxy-addon-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/console-chart-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/grc-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/management-ingress-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/policyreport-2.5.0.tgz: Cannot open: No such file or directory
tar: tmp: Cannot mkdir: Permission denied
tar: tmp/search-prod-2.5.0.tgz: Cannot open: No such file or directory
tar: Exiting with failure status due to previous errors
command terminated with exit code 2
rm: cannot remove 'multiclusterhub/charts/application-chart-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/assisted-service-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/cluster-backup-chart-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/cluster-lifecycle-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/cluster-proxy-addon-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/console-chart-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/grc-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/management-ingress-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/policyreport-2.5.0.tgz': Permission denied
rm: cannot remove 'multiclusterhub/charts/search-prod-2.5.0.tgz': Permission denied
command terminated with exit code 1
make: *** [patch-charts-in-cluster] Error 1


Custom DRF frontend

This PR adds work by @pxjacomex to add a custom rest_framework/api.html so that there is a more useful browsable frontend than the one that ships with DRF, including a menu bar etc. This can be used as a temporary solution to a frontend before the React frontend.
@drklrd - Before Pablo makes any more additions to this, can you please review the changes and make sure this will not be a problem from your end? I assume it will be fine because only the html template is being modified, the API behaviour itself is the same.
@pxjacomex - my only suggestion: Is it possible to keep the dropdown button so we can view the dictionary (api) version of the GET response? E.g. in the image below, perhaps we could have 3 option, [JSON, API, TABLE.] ?

Hi @pxjacomex, thanks for the changes. I'm not sure if we need a separate HTML response though - I think your table response is great.
It would be better to retain the existing api view as well, rather than replace it entirely with this new table view. I think the best way is to create a custom renderer for the table response, then add that to the DEFAULT_RENDERER_CLASSES. This will use the custom api.html that you modified (can rename to table.html), and the BrowsableAPIRenderer can use the default api.html.
So overall we can have:

"rest_framework.renderers.JSONRenderer" - No template needed
"rest_framework.renderers.BrowsableAPIRenderer" - default api.html template
"djangomain.renderers.TablerAPIRenderer" - custom table.html template

Does that make sense?

Hi @pxjacomex, thanks for the changes. I'm not sure if we need a separate HTML response though - I think your table response is great.
It would be better to retain the existing api view as well, rather than replace it entirely with this new table view. I think the best way is to create a custom renderer for the table response, then add that to the DEFAULT_RENDERER_CLASSES. This will use the custom api.html that you modified (can rename to table.html), and the BrowsableAPIRenderer can use the default api.html.
So overall we can have:

"rest_framework.renderers.JSONRenderer" - No template needed
"rest_framework.renderers.BrowsableAPIRenderer" - default api.html template
"djangomain.renderers.TableAPIRenderer" - custom table.html template

Does that make sense?

@dandavies99 Ok. I gonna make it using a custom renderer. Thanks for the explanation.

Thanks @pxjacomex - these updates look good. Do you think this is ready to merge?

@dandavies99 You're welcome. I would like to do some checks before merging it. I think that will be ready next week.

Hi @pxjacomex - the behaviour after updating/changing/deleting works well for me. 👍


Refactor and improve json_prolog/2 predicate

This PR introduces a series of refactors for the json_prolog/2 predicate to improve its behaviour and alignment with common Prolog and JSON encoding conventions:

Object keys now maintain their original order during conversion, rather than being sorted. This ensures consistency with the input structure and enhances marshalling performance.

json_prolog('{"b": 1, "a": 2}', json([b=1,a=2])). /* true */

Key-value pairs are encoded using the = functor instead of -, improving readability and aligning with SWI-Prolog’s standard encoding practices.

json_prolog('{"foo": "bar"}', json([foo=bar])). /* true */

Empty arrays are now uniformly encoded with the empty-list atom [], replacing the previous @([]) encoding method.

json_prolog('[]', []).  /* true */

Summary by CodeRabbit
Release Notes

New Features

Enhanced JSON handling with improved error reporting and conversion functions.
Introduced new ForEach function for iterating over list elements.

Bug Fixes

Improved error handling in JSON parsing and Prolog assertions.

Tests

Added comprehensive tests for new and existing functions, ensuring robust validation of JSON and Prolog functionalities.

Documentation

Updated comments and variable names for clarity and better understanding of functionality.

@coderabbitai pause


Figure out why Key Vault sample yields a warning

sdk/keyvault/samples/sharelink is yielding a CS8601 warning about a possible nullref that no other code seems to yield.

Yes, but there is nothing that disables this warning to pick up.
Originally posted by @pakrym in https://github.com/Azure/azure-sdk-for-net/pull/14562#discussion_r476834328

Not seeing this anymore.


Remember Me

Issue Type: Feature Request
Can we add the option remember me when push to Github. I don't like to put username and password every-single-time
VS Code version: Code 1.26.1 (493869ee8e8a846b0855873886fc79d480d342de, 2018-08-16T18:38:57.434Z)
OS version: Windows_NT x64 10.0.17134

Git can cache your credentials: https://git-scm.com/book/en/v2/Git-Tools-Credential-Storage

Please use a credential manager for Git.


.

Close? @AlexHGaming

Close? @AlexHGaming

@AlexHGaming close?

@AlexHGaming close?

Please update skins, since on agario the private server doesnt work, i tryed help u guys
http://pastebin.com/LQqiwf1Z
this is for C0nsume.me website all their skins

@AlexHGaming Close please?


Fleet chart from bundled

Problem
We need to test Fleet inside of Rancher. Eventually, we want to be able to do that nightly or in PRs.
Fleet is installed and maintained by controllers in Rancher. That makes it impossible to compile and test Fleet, without branching the rancher-charts repo and publishing it.
Furthermore, manual testing showed that Rancher will git reset and update the bundled repos in the container image, if it has internet. That is a strange behavior for air gap mode and should not happen in the bundled folders (/var/lib) at all. It does make sense if the user changed the repo via settings, but then the folder is not in /var/lib.
Having the bundled repos reset, might bring back another version of fleet, which Rancher will then deploy instead of the version that should be tested.
Solution

Add a local folder that can contain charts, just like in management v3
don't run Ensure on the local folders

This PR is missing a few things, considering it appears to be a significant behavior change affecting all repos, not just Fleet.

I don't think it does change significant behavior?
If https://github.com/rancher/rancher/pull/41523/commits/93cc18efc4ceb7b72a19c0cab739c612ec675e6c#diff-796d989f6c1367daebda4c3f2d5baed13e3ece991060dbcf049a535d9b609cf2R72 is too controversial we can drop it from this PR, but I'm under the impression it's fixing quite undefined behavior. Anyhow, let's see what the Mapps Team says.

1. This needs a corresponding rancher/rancher issue

2. This change in behavior needs to be reviewed by the Mapps Team who own this catalog v2 CC: @gunamata

3. There are no tests for this PR.

What exactly would you test? A unit test to make sure local dir is detected and returned from the private function? Seems hard, because none of the code uses any filesystem abstraction.
I guess you are more concerned with the change to Ensure? I could come up with a unit test to make sure it behaves like Update and doesn't act on static dirs. There are no tests to built upon, though.

@manno correct me if I am wrong. Suppose the user creates a repo (hosted in his private network) in airgapped environment, then the repo is cloned in management-state directory. Now, the handler calls ensure to update the repo cloned in management-state.
If we restrict updation of the repo cloned in management-state, then the user cannot get updates from his private network. So we cannot restrict the ensure function based on bundled mode.

@manno Correct me if I am wrong.  I think restricting updation of local catalog repos when in airgapped mode might break environments where airgapped customers allow access to these repos only ex :- for OOB chart release updates.

Looks okay to me just needs a unit test for the change to gitDir(...)

Since that func directly accesses the file system, including "/var/lib/rancher-data/local-catalogs/v2" I would not test it. I don't want to create a unit test that creates directories on the test system, especially when they're under protected directories like /var and not e.g. prefixed with a temp dir.
I can bring in https://github.com/spf13/afero to make the code in gitDir testable, but that seems extreme? Or do we all agree on afero? We would need to inject the filesystem wherever we want to test.


When the page scaling ratio is less than 100%, there is a problem with the width of the renderText after the text is selected

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: chrome
PDF.js version: Many versions，demo link in README
Steps to reproduce the problem:

open the https://mozilla.github.io/pdf.js/web/viewer.html
Adjust the top zoom to below 100%
Select a piece of text with your mouse，select area beyond text

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

Configuration:
Web browser and its version: chrome
PDF.js version: Many versions，demo link in README

You haven't stated which Google Chrome version you use, despite that being asked, and you've also not included the Operating system and its version:-part of the ISSUE_TEMPLATE.

WFM, when testing https://mozilla.github.io/pdf.js/web/viewer.html in both Firefox Nightly 120.0a1 and Google Chrome Beta 119.0.6045.9 on Windows 11; see screen-shots below.
Most likely there's something strange about your environment that triggers this, e.g. related to installed fonts, however given that this doesn't reproduce for all users it seems difficult to address here. Furthermore, please note that the built-in Firefox PDF Viewer is the primary development target for this library.

Firefox

Chrome

chrome has this problem with version 117.0.5938.150


picks some commits to release 3.0

What problem does this PR solve?

schedule: introduce the waiting operators (#1494)
pdctl: config show command add replication config (#1587)
server: use a different timeout for http clients (#1574)
other code adjust (For easier picking code later)

What is changed and how it works?
picks some commits to release 3.0
Check List
Tests

Unit test
Integration test

/run-all-tests tidb=release-3.0 tikv=release-3.0 tidb-test=release-3.0

/run-all-tests tidb=release-3.0 tikv=release-3.0 tidb-test=release-3.0


Event when a new user accesses bot contact for the first time in teams

I want to send a welcome message to the user when a new user tries to access Bot.
Currently in this sample when a new user tries to access Bot contact, user needs to send a message to let OnTeamsMembersAddedAsync understand if any new user is added.
How can we send a message to user just when user opens Bot?

Hi @rutujlangalia!
In order to send proactive messages like welcome messages to teams users, you have to have a conversation id. Because welcome messages aren't actually in response to a conversation, there is no conversation id to supply, and you'll have to create one yourself. Going off the assumption that you're using C#, you'll use the following to create welcome messages:
// Create or get existing chat conversation with user
var response = client.Conversations.CreateOrGetDirectConversation(activity.Recipient, activity.From, activity.GetTenantId());

// Construct the message to post to conversation
Activity newActivity = new Activity()
{
    Text = "Hello",
    Type = ActivityTypes.Message,
    Conversation = new ConversationAccount
    {
        Id = response.Id
    },
};

// Post the message to chat conversation with user
await client.Conversations.SendToConversationAsync(newActivity, response.Id);

Hi @jwiley84 ,
Thanks for the quick response.
The problem I am facing is proactive messages & welcome message is triggered when user types/send a message.
I want to send a welcome message when user accesses the Bot contact on teams.
For example, When we click connect in emulator we get a OnTurnAsync activity of TeamsActivityHandler which responds with a message even before user types/sends a message.
Same OnTurnAsync  event is not getting triggered when we deploy a bot to teams channel and a new user accesses Bot for the first time.
so is there a way of achieving the same functionality as OnTurnAsync  in Teams channel.
Note: We're using C# library for bot development.

@jwiley84 any updates on above comment?

Sorry @rutujlangalia, was on holiday.
To address something really quick:

For example, When we click connect in emulator we get a OnTurnAsync activity of TeamsActivityHandler which responds with a message even before user types/sends a message.

This fires every time you start and stop the emulator, because of the channel in question. That's simply how the emulator is set up. This is not going to be mimic-able in Teams, because when you deploy your bot, and add Teams as a channel, the bot is assigned a Teams-based bot_id. This is a one-time event, which assigns a permanent id (so you wouldn't be able to drop Teams as a channel and re-add it later. That bot_id is still there). The only way to reproduce it would be to add a new bot channels registration, and assign Teams as a channel there, but this would defeat your purpose.
That done with:
if you take the code snippet I posted above, and tuck it  in the OnTeamsMemberAddedAsync method on the sample bot (# 57), and cut it loose on a team of say, 3 people, and later, added a 4th team member to the team, the OnTeamMemberAddedAsync method would fire, and send off the proactive welcome message.
As for 1:1/personal conversations, I'm not sure it's possible to do this, as they don't have the same method.
Does this answer your question?

@jwiley84 ,
Sorry to disturb you on your holiday.
I will try the way you suggested above and verify. Actually I am trying welcome message for 1:1 conversation but let me go ahead and try it if it works.
I guess for 1:1 conversations it should fire OnConversationUpdateActivityAsync but let me try it once to comment on that.
Thanks for your help.

@rutujlangalia Did jwiley84 suggestion solve this issue?

Closing due to inactivity. @rutujlangalia , if @jwiley84's suggestion did not resolve your issue please feel free to reopen the issue.


L2 Lite strip acting weird

Hello, I am having troubles with one of my L2 Lite strips (I have several, only one is acting up)
It does not respond to calls from NodeRED, meaning the entity does turn on, but the actual strip does not. When I turn it on from HA UI, it turns on, but it doesn't create any logbook entries. Any ideas, what went wrong? I did try unplugging the device and plugging it back in.

Solved by the new integration update :)


Add to Composer

It would be really nice to see a TSUGI implementation (as a utility) added to composer (https://getcomposer.org/) for easy implementation into projects.

I am working on this - parts of the code have been move to Composer.   I need to move more.

While I don't have any releases per se, I have a tsugi project in composer:
https://packagist.org/packages/tsugi/lib
You can pull it in as follows:
https://github.com/csev/tsugi/blob/master/composer.json
Let me know if/when we need to do releases - I just keep moving the code forward.

@csev It would be very useful to do releases so people using the code do not unintentionally upgrade to newer revisions of the unversioned code that may not work the same as the revision they were on previously.


Wrong drop in 다시 시작하는 바다 모험

Drops in every stage of the event have extra?

There's two data about map drop.
One is Preview table, and other one is Real drop table.
Seems devs didn't set Preview Table well.
Tactics Manual using Real drop table data.


Feature request: Possibility to pass customAction with similar name as standard actions

Hi,
currently it isn't possible to pass a customAction "Login" to the SDK, because this action parsed as default action, see e.g. iOS implementation:
if actionStr.caseInsensitiveCompare("login") == .orderedSame {
   return RecaptchaAction(action: .login)
} else if actionStr.caseInsensitiveCompare("signup") == .orderedSame  {
   return RecaptchaAction(action: .signup)
} else {
   return RecaptchaAction(customAction: actionStr) // our customAction "Login" never comes here
}

We defined a customAction also called "Login", so it needs to be passed to the enterprise SDK as customAction.
Greets, Alex

What is not obvious is that a customAction named "login" is the same as .login. so there should be no need for this unless I am missing something?
Or is this a case sensitivity issue you are getting at where you want a "Login" custom action and .login (which translates to "login"?
In general we recommend that people use the default actions.

Yes, our custom action is case sensitive "Login" - and I'm not really sure why we don't use the default action for this case (I will ask), I'm just the app developer who needs to send the retrieving token from the SDK to the backend - and it currently fails because it translates to the default action ".login" .
In my opinion, I should be able to use the SDK in Flutter the same way I can in the native SDK, regardless of the recommended method.

Yes, our custom action is case sensitive "Login" - and I'm not really sure why we don't use the default action for this case (I will ask), I'm just the app developer who needs to send the retrieving token from the SDK to the backend - and it currently fails because it translates to the default action ".login" .
In my opinion, I should be able to use the SDK in Flutter the same way I can in the native SDK, regardless of the recommended method.

@alexanderkorus Along with publishing 18.2.2 we changed the way we are handling recaptchaactions.  They are now case sensitive and have a proper class to implement them.
This requires some minor changes to your code.
Thanks for the suggestions!


add enable to sequencer track

This allows a sequencer track to be enabled / disabled

I'm going to leave this open until I have a moment to integrate it into AK5 and test it.

So, this is implemented quite a bit differently in AK5 and I'm not looking back, so if you want me to accept this as is I can.

make it so


[BUG] Building from source hip_runtime_api.h is not found

hip_runtime_api.h isn't found during compilation, even though it's a part of hip-runtime-amd and is located in opt/rocm/hip/include/hip/hip_runtime_api.h.
EXTENSION_NAME=autogptq_cuda_64 -D_GLIBCXX_USE_CXX11_ABI=1 -std=c++17
  In file included from /usr/include/c10/hip/HIPGraphsC10Utils.h:4,
                   from /usr/include/c10/hip/HIPCachingAllocator.h:5,
                   from /usr/include/c10/hip/impl/HIPGuardImpl.h:10,
                   from /usr/include/ATen/hip/impl/HIPGuardImplMasqueradingAsCUDA.h:6,
                   from /home/luna/stuff/Models/AutoGPTQ/autogptq_extension/hip_64/autogptq_hip_64.cpp:4:
  /usr/include/c10/hip/HIPStream.h:7:10: fatal error: hip/hip_runtime_api.h: No such file or directory
      7 | #include <hip/hip_runtime_api.h>
        |          ^~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.

Hardware details
CPU: AMD 3900X
GPU: AMD 7900 XTX
RAM: 4 sticks, 8Gb each
Software version
OS: Arch Linux
Python: 3.11.3 inside a venv from automatic's local install
Pytorch: python-pytorch-opt-rocm 2.0.1-7 system package
To Reproduce

Clone and cd into the repo
Run env ROCM_VERSION=5.6 pip install -v .

Expected behavior
Compiled AutoGPTQ

Hi, if you are building from source, please use the 0.4.2 tag for now, the main branch may have some problem and I'm now working on deal with it.

Hi there, thanks for the quick reply! 0.4.2 seems to have the same issue for me.
I did git checkout v0.4.2 and then env ROCM_VERSION=5.6 pip install -v .
Getting the same issue. Here's the full build and error log if that may help.

@Vintodrimmer Could you share your version of torch (pip list | grep torch)? Are you sure the packages rocsparse-dev, hipsparse-dev, rocthrust-dev, rocblas-dev and hipblas-dev are installed?
Could you try find / -iname *hip_runtime_api.h* as well?

Sure thing! "*-dev" packages are not installed, since they don't exist on Arch, I think, but necessary files seem to be included with the regular packages.

pip list | grep torch

open-clip-torch           2.20.0
pytorch-lightning         1.9.4
pytorch-triton-rocm       2.0.2
torch                     2.0.1
torchdiffeq               0.2.3
torchmetrics              1.1.0
torchsde                  0.2.5
torchvision               0.15.2a0+4ad4b26

find / -iname *hip_runtime_api.h*

/home/luna/stuff/Models/SD/lib/python3.11/site-packages/triton/third_party/rocm/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
/home/luna/stuff/Models/SD/lib/python3.11/site-packages/triton/third_party/rocm/include/hip/hip_runtime_api.h
/opt/rocm/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
/opt/rocm/include/hip/hip_runtime_api.h
/opt/rocm/include/thrust/system/hip/detail/guarded_hip_runtime_api.h
/opt/rocm/hip/include/hip/nvidia_detail/nvidia_hip_runtime_api.h
/opt/rocm/hip/include/hip/hip_runtime_api.h
/opt/rocm/rocthrust/include/thrust/system/hip/detail/guarded_hip_runtime_api.h

In this case, SD is the StableDiffusion folder.
Setting export LD_LIBRARY_PATH=/opt/rocm/include/hip/  doesn't seem to help.
May the issue be that when I installed llama-cpp-python, I didn't include FORCE_CMAKE=1? Otherwise it failed with the following log: https://bpa.st/JPFQ

@Vintodrimmer torch                     2.0.1 is not correct, see: https://pytorch.org/get-started/locally/

Hmm, what should it be instead? I installed it using this AUR package

What torch.version.hip gives you? Could you try installing through pip?

torch.version.hip returns '5.6.31061-'. I'll try compiling it, but AFAIK, pip only has prebuilts for 5.4.2

Ok so I'm not sure what's wrong here, torch looks good. You seem to have the correct headers although not sure why duplicate. I would have expected setting LD_LIBRARY_PATH to work fine: https://github.com/pytorch/pytorch/blob/3a79621c9dce17f77fbddc06aab21f6bc477f313/setup.py#L199 Something you could try is to compile AutoGPTQ with pip install -v -e . and see the compilation arguments to see what is linked.

This worked for me
To copy the solution here, setting ROCM_HOME=/opt/rocm does the trick.

Awesome!

@Vintodrimmer Once you get your 7900xtx running, can you post benchmarks? Thanks.

@fraschm1998 I’m away from home this week due to a conference, but would gladly post once I get back on Sunday.
Could you please post a link to what exactly I need to run the benchmarks? I’ve seen a builtin command for llama.cpp, but wasn’t sure which models are supposed to go into 7B folder and where get those particular ones.


Allow accessing metadata.json to only administrators

Modifications:

Store metadata.json in dogma repository, instead of meta repository.
Rename internal repository name of the internal project from main to dogma for consistency.
Enhance MigrationUtil to support migration from 0.23.0.
Miscellaneous

Invalidate session cache when a user is logged out.

Result:

Closes #197

Codecov Report

Merging #199 into master will increase coverage by 0.03%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage    64.1%   64.13%   +0.03%
==========================================
  Files         271      271
  Lines        9584     9643      +59
  Branches     1079     1092      +13
==========================================
+ Hits         6144     6185      +41
- Misses       2809     2821      +12
- Partials      631      637       +6

Impacted Files
Coverage Δ

...ma/server/internal/command/ProjectInitializer.java
72.22% <ø> (ø)
:arrow_up:

...ogma/server/internal/metadata/MetadataService.java
90.52% <ø> (ø)
:arrow_up:

...nternal/api/converter/HttpApiRequestConverter.java
61.9% <0%> (-10.32%)
:arrow_down:

...dogma/server/internal/api/RepositoryServiceV1.java
81.25% <0%> (ø)
:arrow_up:

...com/linecorp/centraldogma/server/CentralDogma.java
72.49% <100%> (+0.08%)
:arrow_up:

...er/internal/admin/authentication/LoginService.java
76.25% <100%> (ø)
:arrow_up:

...r/internal/admin/authentication/LogoutService.java
76.92% <100%> (+1.24%)
:arrow_up:

...al/command/ProjectInitializingCommandExecutor.java
100% <100%> (ø)
:arrow_up:

.../api/auth/AbstractPermissionCheckingDecorator.java
43.75% <25%> (ø)
:arrow_up:

...ldogma/server/internal/metadata/MigrationUtil.java
77.34% <76.04%> (-2.92%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b9069...91a2dcd. Read the comment docs.

How about removing the old files after migration is finished?
Fixed! No rollback after migration! 😄

Thanks!