ApplicationPlugin configurability

Hello,
Just thought it might be useful to make ApplicationPlugin configuration a bit easier. Basically, it's hard because the root spec in CopySpec is immutable in terms of the child specs manipulation. Say, if I want to have an application plugin structure other than
/whatever
|-- /bin
|-- /lib

I can't do that without full replacement of installApp, distZip/Tar task and createStartScripts too due to hardcoded default applicationDistribution CopySpec. I've implemented another task which will take care of that re-configuration if it's configure closure is triggered. If the task is not there, then it falls back to the defaults like before the change.
E.g. the script before the proposed change (which is ok as a work around for installApp, but something like that would need to be done to distZip too):
installApp {
	applicationDistribution.with copySpec {
		from(processResources) {
			includeEmptyDirs = false
		}
		from(startScripts) {
			fileMode = 0755
		}
	}

	if(project.hasProperty('installDir')) {
		destinationDir = new File(installDir)
		cleanInstallDir.delete destinationDir.getAbsolutePath()
		clean.dependsOn(':cleanInstallDir')
	}

	doLast {
		new File("${destinationDir.getAbsolutePath()}/bin").deleteDir()
	}

}

startScripts {
	mainClassName = "bla.bla.bla.Main"
	classpath += files('/config')

	doLast {
		def windowsScriptFile = file getWindowsScript()
		def unixScriptFile = file getUnixScript()
	 	windowsScriptFile.text = windowsScriptFile.text.replace('%APP_HOME%\\lib\\config', '%APP_HOME%\\config').replace('set APP_HOME=%DIRNAME%..','set APP_HOME=%DIRNAME%')
	 	unixScriptFile.text = unixScriptFile.text.replace('$APP_HOME/lib/config', '$APP_HOME/config').replace('cd "`dirname \\"$PRG\\"`/.." >&-','cd "`dirname \\"$PRG\\"`" >&-')
	}
}

And after:
configureDist {
	applicationBinDir = "."
	applicationDistribution.with {
		from(processResources) {
			includeEmptyDirs = false

		}
	}
}

installApp {
	if(project.hasProperty('installDir')) {
		destinationDir = new File(installDir)
		cleanInstallDir.delete destinationDir.getAbsolutePath()
		clean.dependsOn(':cleanInstallDir')
	}
}

startScripts {
	mainClassName = "bla.bla.bla.Main"
	classpath += files('config')
}

The last bit with 'config' dir to classpath addition relates to GRADLE-2333

Hi Luke,
It's been a while, but I've done more digging and more nice changes so why not to resurrect this pull request.
Here is the changelist:

CreateStartScripts now extends Copy

Adding custom templates allowed (GRADLE-2299)
Adding custom tokens allowed

Ability to add folders to a generated script's classpath
Ability to rename 'lib' and 'bin' directories (GRADLE-2333)
Integration test for the plugin
Quoting JVM opts passed in CreateStartScripts is customizable now (GRADLE-3084)

Basically, CreateStartScripts will have two copy specs - one for windows scripts, the other for unix scripts with default templates added initially. Each spec whould have it's own FilterReader implementation basing on StarScriptGenerator. So we'll have the benefits of execution time initialization rather than during configuration - because CreateStartScript task instance would be passed to a FilterReader with all the relevant parameters.
This allowed to introduce custom templates, custom tokens, and custom JVM opts quoting via a closure. E.g.:
        startScripts {
            mainClassName = 'Ok'
            defaultJvmOpts = ['-Dmyopt=']
            quoteJvmOpts { system, jvmOpt ->
                switch(jvmOpt) {
                    case '-Dmyopt=': return system.equals('nix') ? (jvmOpt + '\$MY_ENV_VAR') : (jvmOpt + '%MY_ENV_VAR%')
                    default: return jvmOpt
                }
            }
            token 'myprop', 'myvalue'
            classpath += files('config')
            windowsStartScripts.from('src/main/resources/scripts') {
                exclude('myscript')
            }
            windowsStartScripts.exclude('**/windowsStartScript.txt')
            unixStartScripts.from('src/main/resources/scripts') {
                exclude('myscript.bat')
            }
            unixStartScripts.exclude('**/unixStartScript.txt')
        }

And if you omit all that (except mainClassName, it's behaviour is the same), it will work fine with defaults.
FilterReader implementations are unit tested the same way StartScriptGenerator is and they literally use it to process files, so they should be reliable. New and old ways to run the plugin integration tested, so we should be safe here too. It proves changes are backwards compatible, so applying refactored plugin should be painless and seemless.
All the added fields/classes have documentation/comments.
Let me know your thoughts.

Hey Alexander,
thanks for all your work and coming back to us with this. I'll have a look on this pull-request soon!
cheers,
René

Hi Rene,
Any news on this one?

Hey Alexander
As Luke already suggested we should introduce a new extension here instead of pushing all the customization functionality in the StartScripts tasks. So instead of configuring the generate start scripts task directly the new application configuration api might be looking a bit more like this:
application {
     mainClassName = "SomeGeneralMainClass" // in synch with applicationName convention property
     applicationName = "SomeCustomApplicationName" // in synch with mainClassName convention property
     startScripts {
            mainClassName = 'Ok'
            defaultJvmOpts = ['-Dmyopt=']
            quoteJvmOpts { system, jvmOpt ->
                switch(jvmOpt) {
                    case '-Dmyopt=': return system.equals('nix') ? (jvmOpt + '\$MY_ENV_VAR') : (jvmOpt + '%MY_ENV_VAR%')
                    default: return jvmOpt
                }
            }
            ...
        }
}

Once we have this extension in place we can use this extension to configure the according tasks. At one point we might be able to deprecate the application plugin convention properties

No worries, I'm glad it's moving on.
So you're saying we should introduce an application plugin extension and keep the existing convention and in-task configuration abilities (which would possbily be deprecated later).
Adding the extension on top of that shouldn't be that hard (though we would need to define config precedence rules like 'in-task' > 'extension' > 'convention').
Anything else concerning the added features/implementation details?

for the precedence rules I would be fine with latest change wins for now. I guess start script templates we can simplify the api for now by just referencing a file object.

Hey there, just a random guy stopping by, who's interested in the features that @bashnesnos implemented.  Are there any plans to fix the merge conflicts and pull into the main gradle repo any time soon?

@bashnesnos Thanks for providing the pull request. Some of the provided functionality already exists in Gradle (naming the ability to use custom templates). Some of the other functionality and the implementation approach is still in discussion. That's why we won't merge your pull request as is. If you'd like to move forward, please join into the conversation on the Gradle dev list and we'll take it from there.


Add new feature to loop a song

It looks like you are working with a TypeScript code file that defines a MusicPlayerCore class. This class has a method named RemoveSong(mark: string) that seems to be handling the removal of a song.
By looking at the RemoveSong method, here's what it currently does:

Checks if the 'mark' argument provided is undefined. If it is undefined, it throws an error.
Then the QuerySongInfo method is called with the 'mark' as an argument to get the song details.
If the song with the specific 'mark' exists, it checks if it's the current song being played. If it is, it pauses the song and removes the link from the audio element. If there are other songs in the SongIdList, it selects the next song and starts playing it.
Finally, it removes the song's id from the SongIdMap and removes the song's id from the SongIdList.

Now, how you would modify this functionality depends entirely upon what your specific use case needs. For example:

If you want not to advance the next song when the current song is removed, you would remove or modify the part of the logic dealing with stopping the current song and advancing to the next one.
If you want to add some sort of confirmation or notification logic before a song is removed, that would be inserted before the deletion occurs.
If you want to change how the songs are looked up (maybe by name instead of id), you would modify the QuerySongInfo(mark: string) method.

Please specify your requirements, so we can provide an accurate solution.


Overflow bug fixed + togglePassword managed

This pull request addresses the following issues:

Fixes overflow bug that affected the layout on mobile devices (#38 ).
Manages the toggle password functionality to improve user experience (#37).

These changes ensure smoother responsiveness and improved functionality.

Hey @ChaudaryHammad can you force push the dco sign so that i can merge your code


[opt] remove redundant texture lookups

http://shader-playground.timjones.io/dd879d7b5649510e6e674e319c646d7f
#version 330
uniform sampler2D tex0;
in vec4 color;
in vec4 texCoord0;
void main()
{
    gl_FragColor.rgb = textureProj(tex0, texCoord0).rgb * color.rgb;
    gl_FragColor.a = textureProj(tex0, texCoord0).a * color.a;
}

(The code is like that cause it's generated from snippets.)

@Trass3r Can you check if the PR will fix the cases you are interested in?  Spirv-opt tries to keep our redundancy elimination algorithm simple, so we don't keep track of which memory location in between two loads.  So if a load is not read-only, then we will not common them.
I've added some extra conditions to be able to get the cases you have above, but it is specific to sampled images.

Thanks!


Ability to disable AoT compilation

How to disable AoT compilation ? Please add a setting or explain to me how to do it ?
OS?
Windows 10
Versions.
angular-cli: 1.0.0-beta.22-1
node: 6.9.1
os: win32 x64
Mention any other details that might be useful.
I don't need the AoT compilation and my project was working before updating to 22-1. Now there are tons of changes needed to make it compile AoT.  It also takes 3 times more time to compile and is thus  harder to test.

Duplicate: https://github.com/angular/angular-cli/issues/3368
Just revert back to 1.0.0-beta.21

Dupe of #3368.


small batch production run

Hi WendyTeslaburger - I am super impressed w/ your project and have been hoping someone would put together a small production run of the PCBs.

has anyone produced a batch of assembled PCBs or is planning to?

if not, I guess I would like to give it a shot. I've gotten pcb fab + assembly quotes from 1) circuithub.com and 2) pcbway.com in the past. However:

circuithub requires CAD files and not just gerbers - would you be willing to add those to this repo?

For Altium projects, upload your.pcbdoc and all the relevant.schdoc files
For Eagle projects, upload your.brd file and one.sch file
For KiCAD projects, upload your.kicad_pcb, -cache.lib and.sch

http://docs.circuithub.com/en/articles/62996-can-i-upload-and-quote-gerber-files
BOM should be in RFC4180
http://docs.circuithub.com/en/articles/1968003-can-i-upload-my-bom-to-my-project

PCBway can work from gerber files, but needs a centroid file for each component for their pick-n-place process. See their requirements here: https://www.pcbway.com/helpcenter/pcb_assembly_ordering/
first of all, is it ok w/ you for me to do a production run of this project? I would probably make 10-20 depending on price breaks and sell them at cost to anyone interested - alternatively I could just make a couple for personal use. please let me know what you would prefer - I want to respect your wishes.
That said, assuming you support a small production run... Would you be open to:

creating the centroid file for PCBWay, or
providing the original atium design files so I can use circuithub;
and helping me pick good parts for the BOM
and providing advice (if any) on the optimal pcb and assembly options offered by pcbway (i.e. extra-thick copper layer for antenna / power / emf shielding etc)? See pcbway fab options in screenshot below

if not, I guess I would recreate the design in kicad or eagle and try out circuithub.
THanks! Other people interested in getting a board, chime in please so I can estimate interest.
McS

PCBWAY manufacturing parameters

Hey,
Thanks for your interest in the project! I will try to answer all your questions.
I have made a small batch of 10 PCBs at JLCPCB for testing and debugging the design. I hand-soldered them myself.
But as far as I'm aware, there has been no other production run.
I'm no copyright lawyer, but I tried to keep these project as open as possible so I included the Creative Commons Zero v1.0 licence. This should allow anyone to do whatever they want with the design. So I am 100% down with you running some production on these modules.
I use Altium Designer for my design work.
For this project I did not yet include the source documents because I was not sure if any personal information was inside .SchDoc or .PcbDoc metadata. For the WT-108 project I did some research and felt comfortable enough to commit the source documents. I will make a commit with the Altium source documents so you can use them (Circuithub) or even contribute to the project if you have an Altium licence.
Regarding the actual design itself: I had the chance to experiment with these boards and found some smal-ish issues. If any serious production run would be done, it would be best to make some changes to the design before making the modules.
Some are simple like substituting some component values with different values. But others would benefit from a small PCB redesign.
If you like, I could make these changes over the weekend and make a commit. Then we can have a look together at manufacturing options.
Best regards,
WT

Hi,
Most excellent! When you get the time to make the minor tweaks and then commit the updated atium files etc to the repo, I'll dig in and start trying to source parts and setting up a BOM. I'll try to do some of the heavy lifting there and also by soliciting a set of RFQs from the fab places. Then we can refine the BOM, order quantity, etc.
I'm glad I reached out, I've been meaning too for a year now :)

I would be interested in buying some assembled boards.

Hello,
Sorry for the delay.
I have already made the changes to the schematic and committed the schematic in PDF together with the source .SchDoc file.
Next up I will change the routing a bit on the module PCB and commit that together with the Gerbers.
Regarding the BOM: I think the schematic is now as good as it gets with all the open issues fixed.
I will export a BOM list from Altium still today, then we can have a look if all components are available or if they need to be swapped for a different supplier (the component marking is crazy right now!)
Best regards,
WT

Hi All,
I've just found this project and its just what i was looking for!
As I had also just put in an order with JLCPCB for some MK-312BT boards i decided to add this to the order too.
I know its still WIP, but for another £1.44 i thought why not!
If nothing else it will be good SMT soldering practice :)

I'm also interesting in buying some (e.g. 5) completed boards.

Did anyone make a few of these I am interested in buying a few to test with

Any possibility for centroid files to be generated and added to the repo for production at jlcpcb/pcbway? I do not have altium so i can't generate the files myself, attempting to import the save files into kicad seems to have gotten the placements correctly, but i do not fully trust that it did everything correctly.
Otherwise a full conversion of the project to kicad would be amazing, but that is a lot to ask for so no need to, its only the centroid files for the pick and place i need to have it produced.


How can I process video files directly,not picture sequence frame

Why can not input video directly for interpolation processing, only the image sequence file can be operated?

@zhanghongyong123456

Why can not input video directly for interpolation processing, only the image sequence file can be operated?

Try the Video Remixer tab. It's designed for starting initially with a video (optionally + audio) and applying various processing, including Video Inflation.
The software uses PNG files internally to handle video losslessly. The tools in the other tabs are designed to operate on these sets of PNG files.
Also, visit the Tools tab, and in particular, the File Conversion tab. There are tools to convert between video and PNG formats.

@zhanghongyong123456

Why can not input video directly for interpolation processing, only the image sequence file can be operated?

Try the Video Remixer tab. It's designed for starting initially with a video (optionally + audio) and applying various processing, including Video Inflation.
The software uses PNG files internally to handle video losslessly. The tools in the other tabs are designed to operate on these sets of PNG files.
Also, visit the Tools tab, and in particular, the File Conversion tab. There are tools to convert between video and PNG formats.
when   i  use  interpolate   video   get    image sequence,how  to  conbine   use  tool  tab (PNG Sequence to MP4)

@zhanghongyong123456 I'm sorry you got this error. It's easy to work around. It is because FFmpeg requires files to be named with sequential index numbers. However the Video Inflation feature intentionally does not automatically re-index the files, given the existing names can be used to determine which original frame the interpolated frames were made from.
To Fix: use the Tools -> Resequence Files feature. It will get the list of files, then re-index them properly. Then PNGtoMP4 can be used without further issue.
I recommend using the Video Remixer tab, which is designed to integrate all the low-level workings together in a smooth experience.

@zhanghongyong123456 I'm sorry you got this error. It's easy to work around. It is because FFmpeg requires files to be named with sequential index numbers. However the Video Inflation feature intentionally does not automatically re-index the files, given the existing names can be used to determine which original frame the interpolated frames were made from.
To Fix: use the Tools -> Resequence Files feature. It will get the list of files, then re-index them properly. Then PNGtoMP4 can be used without further issue.
I recommend using the Video Remixer tab, which is designed to integrate all the low-level workings together in a smooth experience.

thanks,i  try it ,
I found that the original project two scripts(demo_2x.py and  demo_Nx.py) used different models(['ours', 'ours_small'] and ['ours_t', 'ours_small_t'] ),Whether 2x or Nx this project is implemented on only one model(ours)

Thanks @zhanghongyong123456
If you look in config.yaml there is a section that allows you to configure which model is used by EMA-VFI as follows:
engine_settings:
  gpu_ids: "0"
  model: "ours"
  use_time_step: False

Note: When
use_time_step: true

It automatically added the "_t" to the model name that it will select and use. I have found that the time-step version of the model doesn't suit my needs, but I allow it to be enabled in the software.

Note: When
use_time_step: true

It automatically added the "_t" to the model name that it will select and use. I have found that the time-step version of the model doesn't suit my needs, but I allow it to be enabled in the software.

Thanks for the answer, what is the difference between several models

Thanks for the answer, what is the difference between several models

My understanding is the main model "ours" is strictly for 50% interpolation between two frames, and the time-step version "ours_t" allows interpolation at any percentage between two frames. Also there are small versions of the models as well, which I don't use.
I found the time-step model to be insufficient compared to my binary-search (Frame Search feature) method of achieving interpolation at other than the 50% point.
I recommend reaching out to the EMA-VFI folks directly for a more precise technical answer.

Thanks for the answer, what is the difference between several models

My understanding is the main model "ours" is strictly for 50% interpolation between two frames, and the time-step version "ours_t" allows interpolation at any percentage between two frames. Also there are small versions of the models as well, which I don't use.
I found the time-step model to be insufficient compared to my binary-search (Frame Search feature) method of achieving interpolation at other than the 50% point.
I recommend reaching out to the EMA-VFI folks directly for a more precise technical answer.

Thank you very much for your clarification,


Feature Add IPv4/v6 data type for doris

Proposed changes
Issue Number: close #21370
Describe your changes
Now We do not support IPv4/v6 data type for doris witch is common data type in database
So it's the time to support it ! We have some basic funnctions for data type to check the data type is supported completly

[ ] support CURD

[x] support StreamLoad

[x] support Serde functions

[ ] support (implicit/explicit) cast functions

[ ] specific functions for itself data type (u can reference clickhouse or mysql)
eg: IPv4ToIPv6(xxx)

[ ] make a Performance Test result with clickhouse or ElasticSearch in load this data type

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52.13 seconds
stream load tsv:          501 seconds loaded<PHONE_NUMBER>9 Bytes, about 142 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          86.8 seconds inserted 10000000 Rows, about 115K ops/s
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230708143008_clickbench_pr_174817.html

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 54.55 seconds
stream load tsv:          505 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          89.4 seconds inserted 10000000 Rows, about 111K ops/s
storage size:<PHONE_NUMBER>8 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230709123022_clickbench_pr_175065.html

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 54.91 seconds
stream load tsv:          497 seconds loaded<PHONE_NUMBER>9 Bytes, about 143 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          90.2 seconds inserted 10000000 Rows, about 110K ops/s
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230710132341_clickbench_pr_175699.html

run buildall

run buildall

run feut

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.23 seconds
stream load tsv:          510 seconds loaded<PHONE_NUMBER>9 Bytes, about 139 MB/s
stream load json:         18 seconds loaded<PHONE_NUMBER> Bytes, about 124 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size:<PHONE_NUMBER>2 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.12 seconds
stream load tsv:          504 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         18 seconds loaded<PHONE_NUMBER> Bytes, about 124 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size:<PHONE_NUMBER>9 Bytes

run p0

run buildall

run buildall

rebase master let regress pass

run buildall

run buildall


plugin don't work in GitHub pages

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Plugins don't work in GitHub pages because of the /plugins path which will lead to:
_https://jgraph.github.io/plugins/_
instead of
_https://jgraph.github.io/drawio/src/main/webapp/plugins/_
To Reproduce
Steps to reproduce the behavior:

open github pages: https://jgraph.github.io/drawio/src/main/webapp/index.html
in the menu click on: Extras -> plugins...
add a plugin e.g. "text", press "apply" and refresh page
error in console: "GET https://jgraph.github.io/plugins/text.js net::ERR_ABORTED 404 (Not Found)"

draw.io version 14.4.4

Just a suggestion; but for this instance of Github pages could you try to manually create the folder structure for your repository such that you have src/main/webapp/plugins?

Thanks for the report. This will be fixed in the next release.


ability to change docker registry

Description:

New cmd arg for docker registry
Fixes #150
Checklist:

[ ] Tests included.
[ ] Lint and formatter run with no errors.
[ ] Tests all pass.

Where applicable:

[x] Public APIs match existing style.
[x] Any breaking changes have a deprecation path or have been discussed.
[x] Updated the vendor folder (using go mod vendor).

My changes are not based of develop branch :(


How to compile, can I give a tutorial?

check README

Can be compiled and tested for me

check README C voice I don’t understand

It would be fine if it was c#


RE: Research Paper

Keke Lian, Lei Zhang, Guangliang Yang, Shuo Mao, Xinjie Wang, Yuan Zhang, and Min Yang. 2024. Component Security Ten Years Later: An Empirical Study of Cross-Layer Threats in Real-World Mobile Applications. Proc. ACM Softw. Eng. 1, FSE, Article 4 (July 2024)
Is this paper publicly available?

I think this is post-dated =)


Updating slack-message with multiple channels only updates one channel

Your checklist for this issue

[x] Jenkins version: 2.222.4

[x] Plugin version: 2.40

[x] OS: ubuntu 16.04 LTS

Description
When posting message to multiple channels ('channels: "#mychannel, #secondchannel") messages work as expected. But when return-value is stored to variable and using the update-message feature (channels: previous_message.channel_id, timestamp: previous_message.ts), only the first channel message gets updated.

is it possible with curl to update messages across multiple channels?

I haven't tested, not that familiar with slack API. Quickly checking the API it looks like it looks like you could just post message on one channel at a time, but either case if slack-plugin splits up the posts, I would expect to have array of channel_ids to update message on return-object.


MEL Fixes for Referenda and Conviction Voting

in progress

These changes are uncontroversial, so merging

@shawntabrizi : curious to know why you're using without_storage_info in pallets that are using types with MaxEncodedLen implementations? Wouldn't it imply that you wouldn't need to bound the storage items for those pallets?


Fix remaining dust on oToken when burning all

Makes OUSD/OETH not leave dust when the entire balance of an account is redeemed. Closes #1495
To detect when we were burning the entire funds for an account, the old code did this:
currentCredits == creditAmount || currentCredits - 1 == creditAmount
This would not detect the problem if the creditAmount rounding error differed by more than 1.
Changed the code to the much more direct:
amount == balanceOf(account)
Maybe 1K gas more, but we only burn on redeems (super rare), and some AMO allocations.
Also:

Added some helpful comments around the rounding behavior in the function
Removed safe math from this function

Contract change checklist:

[ ] Code reviewed by 2 reviewers.
[ ] Copy & paste code review security checklist below this checklist.
[ ] Unit tests pass
[ ] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Note that I've got an another, possibly better fix version coming.

I'm just going to close this since I like #1680 so much better.


TIKA-1885 updates to tika-mimetypes.xml and custom detector for zero length files

TIKA- 1885 Updated mimetypes.xml file with *.cdf and *.xar files also, with a custom detector to detect zero length files. Also made enhancements to match patterns of video files and jpeg file formats.

@adeshgupta you need to rebase this commit and get on 1.13 branch and make sure your PR only includes your changes. Please update.

ping @adeshgupta

Can you guide me on the 1.13 branch or is it the new master branch in this repo?
@chrismattmann , I am so sorry about the late reply

Hi @adeshgupta you should simply rebase your local branch to apache/tika:master (git pull https://github.com/apache/tika.git master), and then handle any local conflicts, and then git push -u adeshgupta TIKA-1885)

@chrismattmann , It has been done, Please review it and comment.

Hi @adeshgupta this is closer. I can see in https://github.com/apache/tika/pull/89/commits/cdaccc5df7b1eb9eded45fe0578151ea43d33261 the actual change, but if you look at this pull request it includes 2600 other changes. I have no clue why this is. However if you can simply either update this or open up a new pull request that only includes those changes then it would be easier to review.
Some feedback:

https://github.com/apache/tika/pull/89/commits/cdaccc5df7b1eb9eded45fe0578151ea43d33261 doesn't include the actual MediaType.ZeroSize - where is this?
ALv2 headers needed on detector.

@chrismattmann , I have tried to remodify it again. The only problem I am facing right now is that the changes that were made were on tika 1.11 . Probably that is why it is showing so many changes to the files

thanks @adeshgupta check your PR. Still 2k+ files changed. Try rebasing onto 1.13 master.

@chrismattmann , I guess this should do it. around 200 files changed this time around, mostly are license additions/deletions. Will that be fine?

Hi @adeshgupta the fix should simply be this. Can you try:

git checkout -b fix-TIKA-1885
git pull https://github.com/apache/tika.git master
[resolve conflicts locally, etc.]
apply your edits e.g., make sure your single Detector is there, along with the tika-mimetypes.xml update and any other changes (should be ~2-3 files, right)
commit and resolve everything locally
git checkout TIKA-1885
git reset --hard fix-TIKA-1885
git push -u  TIKA-1885

Try that.

@chrismattmann , I have got down the changes to 63 files, I have only changed three files, but I have no clue why so many files are affected because of it

OK @adeshgupta last try (it looks like your editor automatically reformatted these files in your latest PR since it just deletes them and adds them back). How about this. Can you:

Close this PR
Do a FRESH checkout of apache/tika from master
Make your 3 edits to the files in question
Submit a new PR based on that?


Update Code Customizations

Description
Fixes #34162
Adds a new parent POM azure-code-customization-parent that will contain all common configurations for Autorest Java code customizations, similar to what azure-perf-test-parent does for performance tests. This parent will allow for centralization of changes such as updating azure-autorest-customization and will allow for further CI enhancements such as a single code generation validation pipeline run and automation for updating to newer versions of Autorest Java.
This PR also updates to the latest version of azure-autorest-customization to remove the CVE about an older version of snakeyaml being used. Additionally, Key Vault Administration and Cognitive Search were upgraded to the latest version of Autorest Java, 4.1.17, as they were generated from source builds that had fixes shipped in the last release. Key Vault Administration and Cognitive Search had their code generation CI validation re-enabled with this change.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Update Duktape to v2 (master)

So many new features / improvements! https://github.com/svaarala/duktape/blob/master/RELEASES.rst#planned

Fixed by #57


CaptureTexture for DX12 doesn't support textures with 4Kb alignment

During capturing 4Kb aligned textures in DX12 occurs an error in the Capture procedure.
D3D12 Debug Layer reports the error #721 CREATERESOURCE_INVALIDALIGNMENT

Looks like I just need to retry with a 0 alignment if the copied alignment fails.
https://asawicki.info/news_1726_secrets_of_direct3d_12_resource_alignment

Actually, I think I should just use 0 alignment in all cases here for the readback and if I need to do a MSAA resolve.

Fixed in this commit.
Also fixed it in DirectXTK12.


implement the IETF draft 10 header changes

Fixes #1217.

Codecov Report

Merging #1220 into master will decrease coverage by 0.04%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   91.11%   91.07%   -0.04%
==========================================
  Files         114      114
  Lines        7828     7839      +11
==========================================
+ Hits         7132     7139       +7
- Misses        465      468       +3
- Partials      231      232       +1

Impacted Files
Coverage Δ

internal/protocol/protocol.go
100% <ø> (ø)
:arrow_up:

internal/wire/header.go
100% <100%> (ø)
:arrow_up:

internal/wire/ietf_header.go
96.77% <80%> (-3.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba00cb9...b6ca910. Read the comment docs.


No Submodules

Submodules are notoriously annoying to manage.
We don't actually care about the libbpf version at all since it's only
ever used as a shortcut to:
- Generate struct bindings from kernel structs
- Provide the bpf/* headers to C-BPF files so they can be compiled

The UX for people running the integration test is not nice either - as I found out - since if you update via git pull to aya@main then integration tests will refuse to run with no clear error message.
Since the libbpf version used isn't special and doesn't need tracking (outside of git commit message for bindings updates) this PR reverts the use of submodules.
It keeps the assumption that libbpf is in the root of the checkout though, but if it is not found a nice error message is produced telling you how to acquire it.
Fully re-instating --libbpf-dir would be an ideal option, yet this isn't possible without also reverting the move to build.rs for compiling the C-eBPF probes.

This doesn't make sense to me. Why not just have the xtask init the submodule?

This doesn't make sense to me. Why not just have the xtask init the submodule?

Because performing operations that mutate git in xtask isn't something I would advocate for - nor am I willing to take responsibility for any unexpected side effects.
Even if we accepted that risk - it doesn't fix the myriad usability issues around submodules.

Sorry, what exactly are the usability issues?
How exactly does git submodule init mutate git?
Even if there's a good reason not to automatically do this on behalf of the user (and I don't think there is, x.py in rust does exactly this), you already admit to the usability regression in this PR by emitting an error with instructions from the xtask. That error could just as easily say "please init the submodule".

@dave-tucker https://github.com/aya-rs/aya/pull/664 is an alternative proposal. I too am struggling to understand how a submodule, which lets your precisely control the version of the depended upon code as opposed to a loosely coupled expectation that the user check out some code into a specific place.

@ajwerner  @tamird
Let me re-iterate: The libbpf version used isn't special and doesn't need tracking.
Arbitrary checkouts of libbpf are just fine.
May I also refer you to the aya README:

It does not rely on libbpf nor bcc - it's built from the ground up purely in Rust, using only the libc crate to execute syscalls.

Having an explicit dependency on libbpf at the root of the repository is a source of confusion.

Flipping this around, with the recent changes my workflow is now broken.
Can you justify to me why you're insisting that something - that I've told you isn't special - is so special that operations like git pull, git clone and git checkout should now no longer work correctly because of submodules?
Yes submodules aren't updated on pull, don't get automatically pulled in on clone and don't change when switching branches.

@ajwerner @tamird
Let me re-iterate: The libbpf version used isn't special and doesn't need tracking. Arbitrary checkouts of libbpf are just fine.

Having a submodule doesn't only solve for the version; it also codifies where it's expected to be located and generally shifts knowledge out of people's heads and into code and automation. This seems good.

May I also refer you to the aya README:

It does not rely on libbpf nor bcc - it's built from the ground up purely in Rust, using only the libc crate to execute syscalls.

Having an explicit dependency on libbpf at the root of the repository is a source of confusion.

Confusion for whom? Can you cite someone who was confused by this?

Flipping this around, with the recent changes my workflow is now broken. Can you justify to me why you're insisting that something - that I've told you isn't special - is so special that operations like git pull, git clone and git checkout should now no longer work correctly because of submodules?

Can you please spell out how these operations no longer work for you?

Yes submodules aren't updated on pull, don't get automatically pulled in on clone and don't change when switching branches.

All this can be done in the xtask in #664.

Sorry, to address the final point in more detail: an arbitrary libbpf directory doesn't get updated on pull, isn't automatically pulled in on clone, and doesn't change when switching branches.

The points about stale modules I do not understand at all. Having a manually maintained directory in the repository or outside has all the same problems and then some (your tools can't tell you it's stale).

The previous workflow was this:
Just show up with any old checkout of libbpf at any location and things will just work
It is now at the following extreme:
We REALLY care about the location and version of libbpf to the point it's codified in the git repo and there are extra hoops you have to jump through at checkout etc.. for this to work properly
Notice the difference?
I'm asserting that version and location are totally unimportant.
You're asserting that version and location are so important we need to codify this + add extra tooling to make this work.
If you want to hide the complexity, while making sure your reasoning for using submodules holds, then #664 needs to cover initializing submodules, checking they are at the correct revision for the current branch and forcing recompile after update if they are not.

Regarding the perception issue we can rename the libbpf directory to anything you like, including something like "libbpf-for-codegen-and-integration-tests-only". Would that assuage your concerns in this area?

No. because long path names are impractical, but hiding it in test/libbpf or similar might be bearable.

I agree we should fix the instructions, my apologies for having failed to update them previously.

The other documentation gap is how/when to update the submodule.
Previously the codegen workflow would bump libbpf and re-generate bindings at the same time.
It's unclear now what the new workflow is - especially since all codegen has to be done in CI since we've had issues with incorrect bindings being generated in the past.

The previous workflow was this: Just show up with any old checkout of libbpf at any location and things will just work
It is now at the following extreme:
We REALLY care about the location and version of libbpf to the point it's codified in the git repo and there are extra hoops you have to jump through at checkout etc.. for this to work properly
Notice the difference? I'm asserting that version and location are totally unimportant. You're asserting that version and location are so important we need to codify this + add extra tooling to make this work.

I'd restate this: previously the workflow was: please internalize this undeclared dependency and figure out how to acquire it. We will not help you. The new workflow is that the tooling takes care of it and that's it.

If you want to hide the complexity, while making sure your reasoning for using submodules holds, then #664 needs to cover initializing submodules, checking they are at the correct revision for the current branch and forcing recompile after update if they are not.

Agreed.

No. because long path names are impractical, but hiding it in test/libbpf or similar might be bearable.

I'd have suggested that path, but we also use it for codegen. I don't feel strongly about the name or path.

The other documentation gap is how/when to update the submodule. Previously the codegen workflow would bump libbpf and re-generate bindings at the same time. It's unclear now what the new workflow is - especially since all codegen has to be done in CI since we've had issues with incorrect bindings being generated in the past.

The workflow is; (cd libbpf && git fetch origin && git checkout origin/HEAD) && git add libbpf followed by the existing machinery. We will do this in #664.

Yeah, we're making this automatic #664. Please don't throw out the baby with the bathwater.


(FACT-1340) update acceptance tests for cisco

Now that Beaker 2.34.0 is out, this is ready to be merged.

This PR is very old and needs to be updated.  I'll open a new PR for this issue.

New PR is here: https://github.com/puppetlabs/facter/pull/1293


chore: add translations for 1.11.0

Summary
This updates the translations needed for our 1.10.0 release.  There are two ways to update translations.

You can add suggestions for each translated string. click here for more information on adding suggestions.
You can update translations using one of the csvs below by editing the file and re-attaching it to this pull request

de: de-locale-update-1.11.0.csv
es: es-locale-update-1.11.0.csv
fr: fr-locale-update-1.11.0.csv
it: it-locale-update-1.11.0.csv
ja: ja-locale-update-1.11.0.csv
ko: ko-locale-update-1.11.0.csv
pt-br: pt-br-locale-update-1.11.0.csv
zh-cn: zh-cn-locale-update-1.11.0.csv

Testing

[x] Verify de strings are translated
[x] Verify es strings are translated
[x] Verify fr strings are translated
[x] Verify ja strings are translated
[ ] Verify ko strings are translated
[ ] Verify zh-cn strings are translated
[x] Verify it strings are translated
[x] Verify pt-br strings are translated
[ ] Verify all strings are captured by running the translation check

de-locale-update-1.11.0.csv
German Translation

pt-br-locale-update-1.11.0.csv

fr-locale-update-1.11.0.csv
French Translation

ko-locale-update-1.11.0.csv
Korean translation


Fix JSON parser for rbd showmapped in Ceph v13

Fix #1231
I am not very experienced in Golang so please let me know if there are problems (particularly the return type of ParseMappedRBDs is something that worries me).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I've made the changes requested and suggested.
With regards to your suggestion in my original commit I was hesitant at changing the main rbdMappedEntry type as I was concerned it might be used elsewhere, hence me only having that type within the parser and transforming the new format into the older one. I've inverted that process (so now the old format is transformed into the new one) since I feel that makes more sense given the new format is, well, newer.

Hi @codenrhoden
Everything should be good to go. Let me know if I did something silly and I'll fix it.
Thanks!


Adds image

Adds my photo.

Codecov Report

Merging #15 (faf3fb0) into master (0e65afd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e65afd...faf3fb0. Read the comment docs.


Change fan graph card details (in the feed)

One thing I just realized, this stuff on the left is pretty meaningless in the feed for grouped questions, would probably be better to just show the fan graph full width or something.
Slack Message

TBD what we want to do instead; I'd like to get @SylvainChevalier thoughts

We can do whatever non-fan-graph groups do:

Excellent! @SylvainChevalier something like this? I know not high priority but I was inspired...

(Not real data, just sort of based on flu hospitalizations graph)
Pretend I put diamonds in front of the resolutions that weren't annulled. For fan graphs, the groups should always be ordered in reverse chronological order -- the most recent three, then "X more..." like we do with non-fan-graph groups:

Ready for testing on prod

Looks great!


Feature: Add splash screen on startup

What feature or improvement do you think would benefit Files?
Ideally there wouldn't be a need for a splash screen but the reality is that the app can take a few seconds to load. A splash screen can help reassure users that the app is loading.
Requirements

Add splash screen on startup
Display progress ring
Display app logo

Files Version
v2.5.1
Windows Version
Windows 11 (22H2): 22621
Comments
No response

Can I work on it? It should be easy work; how come did you add https://github.com/files-community/Files/labels/help wanted label?

There is guidance on handling Splash Screens - and the focus should probably be on ensuring the screen is displayed as quickly as possible for performance reasons.

They doesn't support SplashScreen in WinUI3/WASDK.

https://github.com/microsoft/microsoft-ui-xaml/issues/4055
https://github.com/microsoft/microsoft-ui-xaml/issues/6942

With WinUI 3 and WinAppSDK - you need to make a custom splash screen, and display it whilst the UI loads.
With WinUI 2 and UWP its built into the plaform.

Oh, I have an experience of making custom splash screen, adding progressring. Let me see what I can do.


[BLOCKER] Error creating FDS account after funding it

In both Firefox and Chrome, error occurs after funding is sent to account. See screenshots:

not relevant anymore


Tiles are copied wrong

There is a plugin that lets you register the objects with negative ID and thus put them in the world
The plugin is: https://poggit.pmmp.io/p/ExtendedBlocks/1.1.1
I don't know if it is possible to allow them with world edit

Test it first, then make an issue.

I've already tried it, that's why I've opened an issue
The right side is a copy paste of the left

When will this be finished?
I say this because now there is a plugin that uses ExtendedBlocks to put 1.16 objects
https://github.com/xSuperr/VanillaBlocks/tree/main/
And whenever you copy an object with negative ID, it automatically turns it into an "Update" block

Block Id -1 is not valid block id value in pocketmine 3.0. It's world formats support only blocks with ids 0-255.

Is there no way to add the negative ID blocks?

World format does not allow it.


New version: GitHub.GitHubDesktop version 3.4.2

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

2024-06-27T18:57:57.5361921Z Manifest Validation Failed
2024-06-27T18:58:02.6214672Z ##[error]Manifest Validation Failed

(Automated response - build 886.)


Network information endpoint

Issue Number

N/A
Overview

[x] I have renamed 'WalletState' to 'SyncProgress', for we'll also use this in the network information endpoint and.. it truly is just about the syncing progress.

[x] I have reviewed the swagger specification network information endpoint to better reflect the information we're going to return. Basically, the localBlockchainHeight does not make much sense for us at this level, because there's actually a local height per wallet. So this information will better be located in each wallets directly.

[x] Added a field pendingSince for transactions. I shouldn't have done that in this PR but I did it as I was updating the swagger. This is not related to the networking endpoint so it might get a little confusing in the review.

[x] I've also re-generated all the golden API tests because I was getting a lot of warnings about files not being up-to-date (nothing to do with this PR but it seems that we haven't updated them along the way....)

Comments

Some screenshot of the swagger specification:

bors r+

bors r+

bors r+

bors r+


Preserve the sanctity of #ddev-generated files via new customization options

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
It was discovered during testing of the Traefik v3 migration PR that an error related to additional_hostnames and additional_fqdns was due to my having overriden the .ddev/traefik/static_config.yaml file by removing the #ddev-generated line from the top. This prevented ddev from setting some new settings in static_config.yaml, notably
core:
  defaultRuleSyntax: v2

This static_config.yaml issue is just one more example of frustrations related to #ddev-generated files.
For example, even without this migration to v3, in order to use the Traefik middleware plugins, I had to override both the global static_config.yaml and each project's traefik dynamic yaml. But, then if I wanted to change the project config.yaml - say to add additional_hostnames - those changes could only be applied if I added #ddev-generated to the yaml, which then wipes out my middleware config. So, you have to copy the middleware config, ddev restart to regenerate, re-add the middleware config, and ddev restart again. And then get confused when it inevitably gets out of sync again in the future.
Likewise, when I excitedly shared DDEV with people in the Wordpress world recently, the immediate feedback by some people was "why does it keep breaking my wp-config.php file? This is ridiculous" I told them what was happening, but I suspect they just stopped using it altogether and will never return. Thats a great shame and shouldn't happen again.

Root Problem Diagnosis
The problem, fundamentally, is that DDEV dynamically generates various config files at runtime, but doesn't expose sufficient ways for users to add customizations to them.
It does so with config.*.yaml and docker-compose.*.yaml, but doesn't do so with respect to the Traefik router, and some of the project types (at least Wordpress) generate config files that conflict with user workflows.
This forces users to manually override (at DDEV's instruction!) files that really should be completely, 100%, off-limits.

Describe your solution
#ddev-generated files should be sacred and off-limits - all customizations should be done in other config files which then get dynamically merged at runtime.
We should:

[ ] remove any documentation or other mention that #ddev-generated files can be overridden
[ ] add something that throws a fatal error (or at least a very prominent, stern and educational warning) if #ddev-generated is not present in files where it is expected
[ ] ensure that all #ddev-generated files have extension mechanisms that are also well-documented

This would ensure that no one ever has to futz with and get blindsided by #ddev-generated again.

#ddev-generated Files that should be sacred but are currently missing extension mechanisms:
(This list will be updated as more files are identified below)

[ ] ~/.ddev/traefik/static_config.yaml
[ ] /project/.ddev/traefik/config/<project>.yaml
[ ] wp-config-ddev.php in wordpress

I have been working on a PR that I will submit soon that automatically generates a .middleware-template.yaml for each project, which then gets dynamically merged by /pkg/ddevapp/traefik.go into the project's .ddev/traefik/config/<project>.yaml file each time you ddev start. This allows me to use the middleware while also letting ddev dynamically generate the traefik yaml based on the project's config.yaml. I can probably extend the scope of this to include an extension for ~/.ddev/traefik/static_config.yaml
Likewise, I have been working on an overhaul to pkg/ddevapp/wordpress.go which gets rid of #ddev-generated in wp-config.php but maintains it in wp-config-ddev.php. It will work such that no one will ever have to touch wp-config-ddev.php - they can configure the core wp-config.php however they need for their production site, and then ddev-specific variables will be loaded from wp-config-ddev.php via the value of the WP_ENVIRONMENT_TYPE environment variable.
You'll get to see and review the mechanisms when I submit the PRs soon.

Thanks for the good thinking and for taking the time to write up an issue.
We'll be looking forward to solutions that work globally. This approach is widely known and widely documented. And it's simple, and there's code to support it.
We'd be interested in creative long-term approaches.
In the config.yaml, we support config.*.yaml, which is a better technique. In docker-compose.*.yaml each item is merged, making that a better situation. For add-ons a docker-compose.varnish_extras.yaml is preferred over editing and "taking over" docker-compose.varnish.yaml for example.

Are you missing that things like the settings.ddev.php for Drupal use #ddev-generated, and that it's used for .ddev/.gitignore, and on and on? You seem like you're focused on traefik-related things, when this pattern is used throughout DDEV.

Please don't go down that path until it's adequately discussed. Just because you see an opportunity doesn't mean that it will be implemented or that your implementation will be accepted.

Although we'll keep this technique available, most commonly used config techniques like docker-compose.*.yaml, config.*.yaml, etc and the newly done traefik static config allow people to do things a better way. Closing this, but will certainly keep it in mind.


Docs improvements

[x] Fix Docs badge to point to docs pipeline (db5f9386c9bd62281bd14cdf738a873b64f8a7ee)
[x] add more template examples and fix typo (dd6cc739870638c0f1a51556eb480cdddbf30f95)
[x] take cosigner#N in `` for emanote not to render them as tags (d76ea8e64fc5abcb2feeb81f2be105b5bb815696)
[x] fix rendering of docker compose commands in how to start a wallet guide (30c4eb5227d3dc01e39212e952a7c95ac2ef7440)

Comments

Issue Number

bors r+


Replace all raster icons (e.g. tootip) with vector ones

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

this one is webapp/plugins/tooltips.js line 20


TaskBar improvement 2

Description of the new feature / enhancement
Currently, when clicking a Taskbar button representing a currently running FOCUSED program minimizes the corresponding window. This is often not desired. So this behavior of minimizing the window by clicking the taskbar button should be suppressed: Clicking a taskbar button should always and only bring the window to the front.
Scenario when this would be used?
There is no visual taskbar indication of whether a window is on the front or not.
Supporting information
No response

the bar under the icon is larger if the window is focused

I cannot reproduce this in Windows 10. Can you show a screenshot?


CSV and Json output formats are not consistent in terms of fields and field names

As seen in the screenshot below, CSV and Json outputs are not consistent and they shoudl contain the same fielsds and same field name in both cases. Since ASFF has other requirements in terms of fields, this has no impact to json-asff.

Included in Prowler roadmap aiming V3.


Most important docstrings are not very useful

This repo is amazing!
Also the code is beautifully commented, almost every function has a useful docstring. Except for the most important parts, the algorithms that are highlighted in book "figures". These methods have the not-so-useful docstring: "Figure X.Y". Most other functions and methods arguments and return values are well documented but for the important ones you have to go open the heavy book. ;-)
As an example let's look at function AC-3 in csp.py.
def AC3(csp, queue=None, removals=None):
   """[Figure 6.3]"""
   ...

I think it would improve the readability of the code very much to have a docstring like:
    """[Figure 6.3] The arc-consistency algorithm AC-3.
    After applying AC-3, either every arc is arc-consistent, or some variable has an empty domain, indicating that the
    CSP cannot be solved. The name "AC-3" was used by the algorithm's inventor (Mackworth, 1977) because it's the third
    version developed in the paper.

    returns false if an inconsistency is found and true otherwise
    inputs:
        csp         A binary CSP with components (X, D, C)
        queue       A queue of arcs, initially all the arcs in csp
        removals    The values that have been pruned from all domains
    """

Which is extracted from the actual figure in the book. Plus a little understanding of other parts of the code.
It seems like this problem may affect several other important docstrings.

	Line 555:     """[Figure 4.21] The abstract class for an OnlineDFSAgent. Override
	Line 706:     """[Figure 4.8]"""

Maybe this has to do with copyrights or something. Should I ask @norvig for permission?
What I suggest is changing each offending docstring with the appropriate text of the figure in the book. I'll gladly volunteer to look at each of the 21 remaining docstrings in question but I wanted to have some feedback first.
I'll add the PR for the AC-3 function as soon as I get the issue number.

I am not 100% sure, but I think we should be trying to change the comment from the text in the book a little bit. I don't think there will be much of an issue, but I think copy-pasting is not the best idea.
I would love to see these docstring filled out, so short descriptions are definitely welcome.


Do data visualization and cleaning

Add +/- emoticons as tokens: https://en.wikipedia.org/wiki/List_of_emoticons
Add misspelling problems: something like grammarly?

Paper providing standard methodologies on data cleaning


Is the number of images in both two image folders have to be equal?

Thanks for the great work. I have a question of if the number of images in both two image folders have to be equal when calculating the FID score. Because the FID distance is represented as the distance between two normal distributions. Sorry to bother you.

No, the number of images does not have to be equal. It should be bigger than 2048 in both folders though.

Thanks so much for the clarification.


Convert plumbing.ErrObjectNotFound to git.ErrNotExist in getCommit

Similar to a number of other bugs we need to handle plumbing.ErrObjectNotFound and convert to git.ErrNotExist appropriately.
Fix #10852

Codecov Report

Merging #10862 into master will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master   #10862   +/-   ##
=======================================
  Coverage   43.49%   43.49%
=======================================
  Files         592      592
  Lines       82979    82985    +6
=======================================
+ Hits        36094    36097    +3
  Misses      42399    42399
- Partials     4486     4489    +3

Impacted Files
Coverage Δ

modules/git/repo_commit.go
53.29% <83.33%> (-0.39%)
:arrow_down:

modules/indexer/stats/db.go
40.62% <0.00%> (-18.75%)
:arrow_down:

modules/indexer/stats/queue.go
62.50% <0.00%> (-18.75%)
:arrow_down:

modules/git/utils.go
65.67% <0.00%> (-4.48%)
:arrow_down:

services/pull/pull.go
35.00% <0.00%> (-0.89%)
:arrow_down:

modules/git/repo.go
47.28% <0.00%> (-0.84%)
:arrow_down:

models/notification.go
64.71% <0.00%> (+0.83%)
:arrow_up:

modules/queue/workerpool.go
59.07% <0.00%> (+1.06%)
:arrow_up:

modules/git/command.go
89.56% <0.00%> (+2.60%)
:arrow_up:

services/pull/check.go
53.04% <0.00%> (+3.04%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd4704...cb57335. Read the comment docs.

Please send backport


bump OpenJPA version from 2.4.1 to 2.4.3 for Java 11 compliance

This will require # (which in turn first requires a few other minor PRs to be merged).
The upgrade is because 2.4.1 was not yet Java 11 compatible (due to an old ASM)
In the context of the Gradle upgrade work, I'd like to upgrade to Java 11 soon-ish, and am starting to experiment with it.
This first requires #604, #605, #606.

This, ideally (to avoid doing required adjustment work twice) requires #607 as a pre-requisite, first.

@conradsp what do you think?  @lingocoder FYI

Actually, seeing how the merge of #607 apparently just broke #525 again, perhaps let's hold off merging this until affter #525 is merged, then rebase this on top of that, and only then merge this?

rebase this on top of that, and only then merge this?

done, and it passes. @awasum @conradsp @vishwasbabu would you like to merge this?

FTR: https://issues.apache.org/jira/browse/OPENJPA-2730 has what we need OpenJPA v2.4.3. This alone doesn't quite do the trick for https://github.com/apache/fineract/pull/609, see https://github.com/radcortez/openjpa-gradle-plugin/issues/8 for why. IMHO it would still make sense to merge this already right now though; I'll deal with the follow-up in #609.


Invalid example in doc/Type/Cool.pod6

6cbd36f3c40c566726124e285bbf6e7ca248f9b4 added this example:
+    say log2(5);            # OUTPUT: «2.321928094887362␤»
+    say "4"log2;            # OUTPUT: «4␤»

Looks like it was meant to be "4".log2, but given the output presented, It's not entirely clear. Can the original author please fix the example?

You can verify the test passes with:
xt/examples-compilation.t doc/Type/Cool.pod6

Fixed with https://github.com/Raku/doc/commit/3b8f9fe964


Fix #14

Switch mounts bookkeeping from Map to POJO

cc/ @lawnsea

Overall, I think this is the right call, since we don't really use Map for any compelling reason.

Yep. I'm happy to land this with the changes @slimelabs suggested.

@lawnsea @cappslock I just pushed a commit to address this feedback. Can y'all re-review and land if everything looks good?


Fix rounding error in RegistryParse.parse_windows_timestamp

This change ensures that parse_windows_timestamp is accurate to the microsecond.
Currently, there's some loss of precision using floating point arithmetic, as 64-bit floats just don't contain enough precision for typical windows timestamps.
It's possible to improve the current implementation without using decimal, by delaying the conversion to floating point. Namely, changing L83 below to: total_microseconds = int(round((shifted * datetime_resolution) / resolution)). That gives better results, but still results in some rounding error (see the second test case).
I've implemented this change using a generalized parse_timestamp function, which could perhaps be used with other epochs/timestamp resolutions if the need arises?
This may break some existing tests/tools which rely on the old rounding method.

looks good to me! thanks for helping to make the library more correct!


Imports in merged component are wrong when using nested types

Hey, seems like kimchi doesn't properly reference nested types.
This test
  @Test
  fun `contributed binding with nested type compiles`() {
    compileKimchiWithTestSources(
      """
        package kimchi

        import me.tatarka.inject.annotations.Inject
        import com.r0adkll.kimchi.annotations.ContributesBinding

        interface Parent {
          interface Binding
        }

        @ContributesBinding(TestScope::class)
        @Inject
        class RealBinding : Parent.Binding
      """.trimIndent(),
      workingDir = workingDir,
    ) {
//      val binding = kotlinClass("kimchi.Parent.Binding")
      val realBinding = kotlinClass("kimchi.RealBinding")

      expectThat(mergedTestComponent)
        .declaredProperties()
        .withFirst {
          hasReceiverOf(realBinding)
  //        hasReturnTypeOf(binding)
          getter()
            .hasAnnotation(Provides::class)
        }
    }
  }

Fails with
[…] MergedTestComponent.kt:3:15 Unresolved reference 'Binding'.
[…] MergedTestComponent.kt:11:32 Unresolved reference 'Binding'.

The generated merge component imports kimchi.Binding instead of kimchi.Parent.Binding or kimchi.Parent
package kimchi.merge.kimchi

import kimchi.Binding
import kimchi.RealBinding
import kimchi.TestComponent
import me.tatarka.inject.annotations.Component
import me.tatarka.inject.annotations.Provides

@Component
public abstract class MergedTestComponent() : TestComponent {
  public val RealBinding.bind: Binding
    @Provides
    get() = this

  public companion object
}

public fun TestComponent.Companion.createTestComponent(): MergedTestComponent =
    MergedTestComponent::class.create()

Same issue when generating the factories for circuit.
This fails
@Language("kotlin")
val TestScreen = """
  package kimchi
  import com.slack.circuit.runtime.screen.Screen

  data object Screens {
    data object TestScreen : Screen
  }
""".trimIndent()

[…]

  @Test
  fun `nested screen compiles`() {
    println(workingDir.absolutePath)
    compileKimchiWithTestSources(
      """
        package kimchi

        import androidx.compose.runtime.Composable
        import androidx.compose.ui.Modifier
        import com.r0adkll.kimchi.circuit.annotations.CircuitInject

        @CircuitInject(Screens.TestScreen::class, TestScope::class)
        @Composable
        fun TestUi(
          state: TestUiState,
          modifier: Modifier = Modifier,
        ) { }
      """.trimIndent(),
      workingDir = workingDir,
    ) {
      val factory = kotlinClass("kimchi.TestUiUiFactory")
      expectThat(factory)
        .hasAnnotation(Inject::class)
        .implements(Ui.Factory::class)

      val component = kotlinClass("kimchi.TestUiUiFactoryComponent")
      expectThat(component)
        .withAnnotation<ContributesTo> {
          get { scope } isEqualTo testScope
        }
        .withFunction("bindTestUiUiFactory") {
          hasAnnotation(IntoSet::class)
          hasAnnotation(Provides::class)
          parameter(1)
            .isTypeOf(factory)
          hasReturnType(Ui.Factory::class)
        }
    }
  }

e: […] `TestUiUiFactory.kt:22:8` Unresolved reference 'TestScreen'.

Oh excellent catch! Looks like I was using a very naive toClassName() function and it very much missed the fq name. Thank you so much for the tests! I'll have a fix for this up soon


Add ansible-navigator support

Hey, I added ansible-navigator support for molecule.
The ansible-navigator provisioner is a Derived class from the ansible provisioner class.
To get the stdout output from ansible-navigator I parse the json artifacts from ansible navigator.
With the implementation of ansible-navigator, the roles or playbooks can be tested against a modified version of an awx-ee image, to ensure it works with the awx-ee image that is used in AAP or AWX.
I created a sample  repository to modify the creator-ee to support docker from the host inside the ee.

branch has conflicts that must be resolved

I will close this because at this moment we don't want to use navigator from within molecule. Still, we will add integration but without making molecule aware about being run under navigator.


Fix the clusterPoolName in clusterClaims

Currently with the following values snippet:
managedClusterGroups:
exampleRegion:
name: group-one
acmlabels:
- name: clusterGroup
value: group-one
helmOverrides:
- name: clusterGroup.isHubCluster
value: false
clusterPools:
exampleAWSPool:
size: 1
name: aws-ap-bandini
openshiftVersion: 4.12.24
baseDomain: blueprints.rhecoeng.com
controlPlane:
count: 1
platform:
aws:
type: m5.2xlarge
workers:
count: 0
platform:
aws:
region: ap-southeast-2
clusters:
- One
You will get a clusterClaim that is pointing to the wrong Pool:
NAMESPACE                 NAME                       POOL
open-cluster-management   one-group-one              aws-ap-bandini
This is wrong because the clusterPool name will be generated using the
pool name + "-" group name:
{{- $pool := . }}
{{- $poolName := print .name "-" $group.name }}
But the clusterPoolName inside the clusterName is only using the
"$pool.name" which will make the clusterClaim ineffective as the pool
does not exist.
Switch to using the same poolName that is being used when creating the
clusterPool.

/lgtm


Falcon Test Client throws ValueError when response handler raises HTTPNotFound

I refactored an app to raise falcon.HTTPNotFound exception, but now the functional tests fail with a ValueError: need more than 1 value to unpack error. I'm using v2.0.0.
In the code below, if I comment out the the line that raise's the exception and just set resp.media and resp.status manually, the test passes.
I've tried tracking this down using pdb, and ended up digging all the way into the wsgiref.validate code, which is triggered from here in Falcon's testing client.
Has anyone else experienced this behavior? Or am I just doing something wrong?

E   ValueError: need more than 1 value to unpack

falcon/response.py:663: ValueError

Hi @tjb-wiley , and thanks for the bug report!
Although I can indeed reproduce the issue, I would be inclined to close this as duplicate of https://github.com/falconry/falcon/issues/777 .
The problem is that currently, as opposed to the desired structure laid in https://github.com/falconry/falcon/issues/777, not all HTTP error classes accept parameters in the same fashion. Classes inheriting from OptionRepresentation are typical examples of breaking the paradigm. And unfortunately, as you discovered, HTTPNotFound falls under that category.
You could fix your issue at hand by using keyword arguments, i.e. specifically choosing what 'error' is. title and description could both work. However currently the first parameter is headers, which picks your error.

Duplicates https://github.com/falconry/falcon/issues/777

@vytas7 thanks for pointing this out. Makes sense and the workaround is good enough for now. :-)


Navigation Bar overlap at a certain device width

New Task:
What is the task
At certain width the Navigation bar buttons start appearing on top of each other

Who is the task for?

[x] I created this task for me to complete, I will create a PR soon.
[ ] I created this task for someone else to claim.
[ ] I think this is a task that multiple people can do

Confirm all of the following:

[x] I have looked at all the issues currently available and this does not exist or overlap with another ticket

⚠ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

I'd like to add that this issue doesn't occur on chrome. I can only see it using firefox.

@brittneypostma Can you please add the "hacktoberfest" label if this is eligible for it?

The repo has the label on it, so it isn't needed, but I added it. This overlap is actually a problem with the whole navbar itself. I noticed on the smallest viewport (320px) that it was getting smaller in width when scrolled and some links don't work. Then, if you go to other pages the dark/light mode may not even work at all. It looks very inconsistent.

yeah, thanks for letting me notice this. I'll try to fix the positioning of the navbar. I just want to know what the required design is
should it be small and to the left like this (of course without the buggy toggle button):

or should it stay the same size as it was on the top of the page?

As for the Dark Mode for other pages I'll create an issue for it.
Additionally I think in one of the accepted pull requests the toggle button doesn't change its color in Dark mode anymore. I'll fix that as well.


improve: to implement benchmark test for tcc

What would you like to be added:
Why is this needed:

Is there any reference for this Issue? I want to try it


fix(youtube): readablity

follows https://github.com/catppuccin/userstyles/pull/249#issuecomment-1745722258

Sorry to bother you again... version bump?


handle js

in SwiftWebVC.swift, i have added config as follw
public class SwiftWebVC: UIViewController,WKScriptMessageHandler {
public var jsHandler:((WKScriptMessage)->())?
...
}

lazy var webView: WKWebView = {
        let configuration = WKWebViewConfiguration()
        configuration.userContentController.add(self, name: "wawa")
        var tempWebView = WKWebView(frame: UIScreen.main.bounds, configuration: configuration)
        tempWebView.uiDelegate = self
        tempWebView.navigationDelegate = self
        return tempWebView;
    }()

public func userContentController(_ userContentController: WKUserContentController, didReceive message: WKScriptMessage) {
        if self.jsHandler != nil {
            self.jsHandler!(message)
        }
    }

and it just fail to work, maybe i need help.

actually, it works.
my colleagues make a mistake.
code like this window.webkit.messageHandlers.wawa.postMessage() can't work,
when he change this to window.webkit.messageHandlers.wawa.postMessage('test')
it work.


BETWEEN & NOT BETWEEN

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
dialect/sql/sql.go does not provide Between and NotBetween selectors for fields.

Should behave like the corresponding standard SQL statements.
Motivation 🔦

Necessary to find records for which a field is not in a number range.

You can use the Where function like below:
	projs, err := sqlCli.Project.Query().Where(
		project.And(project.OwnerIDGT(1),
			project.OwnerIDLT(100),
			project.OwnerIDNotIn(20, 30),
		),
	).All(context.Background())

Was more thinking of something like:
n, err := client.Post.
    Query().
    Where(post.NumComments.Between(1,10)).
    All(ctx)

Was more thinking of something like:
n, err := client.Post.
    Query().
    Where(post.NumComments.Between(1,10)).
    All(ctx)

As far as I know, it's not supported. If you can use other condition to implement the same logic, don't spend too much time on this. It makes no difference of runtime efficiency.

I don't care too much about runtime performance. More about code readability.


I want to improve Level0 Mood UI under SSOC'23

Description of  the change
More Interesting UI
Domain of Docs

[] Readme
[] Solidity , Html, Css , JavaScript , Web3.js / Ether.js
[] Solidity , ReactJs /NextJs , Web3.js /Ether.js
[] Solidity , Python3 , Web3.py
[] Other , feel free to mention below

Are you contributing under any open-source program ? Yes

@Vikash-8090-Yadav Kindly assign this to me


Support Feature Layers

This PR makes necessary changes for text notes to be attached to features in a Feature Layer, along with a couple other interface changes:

Using symbolUtils.getDisplayedSymbol() to get the symbol dynamically for points. For plain Graphics Layer, this isn't necessary since the symbol is always statically available on the graphic. Feature Layers may need to resolve this through the renderer.
Because resolving the symbol size for a feature is now async, the note is not guaranteed to be placed when HubTextNotesLayer.addNoteForGraphic() returns. For cases where you want to take some follow-up action that relies on position (e.g. Hub checking to see if the note is in the current view extent), HubTextNote.placed() will return a promise that resolves upon placement.
When searching for notes by graphic, object identity is sufficient for Graphics Layers, but not for Feature Layer. When object identity fails, we now fall back to check for the same object id with graphic.getObjectId()
Consolidation of placement-related options into a single placement object:

placementHint => placement.hint
placementAlignments => placement.pointAlignments (clarify usage)

Addition of placement.outsidePolygon option to allow polygon notes to be allowed to move outside the polygon interior (default), or to be constrained to the interior. This was added as a result of testing Feature Layers with shared polygon boundaries, such as political districts, where it can be misleading to allow the note to be placed in an adjacent polygon.

@jPurush appreciate if you can think of any gotchas I may have missed for differences with Feature Layers. It works for the cases I've tried so far, but possible there are cases I've missed.
Speaking of, there is a test app here:
https://glitch.com/edit/#!/esri-demos?path=notes-fl.html
But it points to my local env, so you would need to copy and modify it to point to a local build of this branch.


Libraries do not load on Windows

Trying to load a library on Windows crashes with a NullPointerException in ResourceLoader.java @ L135. The cause seems to be these lines of code (L64):
// If the file does not start with a separator,
// then let's make sure it does!
if (!relativePath.startsWith(File.separator)) {
    relativePath = File.separator + relativePath;
}

On Windows File.separator is \ which poses a problem when loading with Class.getResource since the URL expects a /.

Hi @ltouroumov,
Thanks for the bug report. Good catch!
It seems like your PR was submitted to merge into your own repo's master branch and not Resource Loader's master branch 🙂 Please raise your PR against Resource Loader's master branch then I'll approve and merge!
Thanks!


[BACKLOG-31415] Handle usernames/passwords in address bar

:gear: Build finished in 1m 31s with command:
mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -pl plugins/file-open-save-new/core

:ok_hand: All tests passed!

Total
Failed
Skipped

8
0
0

Details

:information_source:  This is an automatic message


Unable to install coursier - 502 error

Hey @tovbinm, is this still happening? It seems it was a temporary issue, since I just tried it on my repositories and it went fine

Works now. Thanks.


Mention react-router-optimize transform in docs to minimize bundle

The "Minimize Bundle Size" guides explain how to reduce file size by
only importing the neccessary parts of react-router.
I created a small babel plugin to do this transformation automatically.
https://www.npmjs.com/package/babel-plugin-transform-react-router-optimize

I'm not sure this is a good idea.
In general, people are going to have to do deep imports to get minimum bundle size, and it doesn't make sense to install a Babel plugin for every library I use.
I'd rather people just use a cross-library pattern that they should be familiar with anyway.

I agree, that it is painful to install a lot of different babel plugins for all the things I want to use, but that's rather a discussion on how babel is organized.
Also there's the possibility to create "presets", for example here is a "react-optimize" preset, which contains a set of different plugins which affect the performance of react application: https://github.com/thejameskyle/babel-react-optimize (possibly also a good place for the react-router-optimize plugin).
I slightly disagree that people who use react-router should have to write the deep imports themselves. In most react applications I've seen, this wasn't happening.
Referencing files inside a module means accessing an API which was supposed to be private / internal and could break at any point.
react-router has given a statement that they treat their build internals as a public API by creating this guide, but for most other libraries this isn't the case.
With that in mind I'd rather write "cross-library patterns I'm familiar with", which are ES6 destructuring import statements instead of having to do the deep imports myself ;)

We need to do a better job of pointing users at the deep imports. They are actually part of our supported API. Possibly we want to move them up one level (e.g. react-router/Link rather than react-router/lib/Link – this is @ryanflorence's idea and it's a good one).
At some point it just gets hard to avoid this pattern for certain libraries, especially when you want to minimize bundle size. history uses this pattern, and it can't avoid doing so.


Exclude non-API elements from javadoc

https://issues.redhat.com/browse/ISPN-11043

This will obviously fail now because it depends on the doclet ver. 1.2.0.Final to be released first.
See https://github.com/infinispan/infinispan-doclets/pull/1

It's odd we have some @public classes in org.infinispan.security.impl package @tristantarrant

Right, those are the role mappers which should probably be moved one level up.

@anistor https://github.com/infinispan/infinispan/pull/7655

Rebased ,  @tristantarrant

Merged, thanks


feat(governance): protocol upgrade notification, est. time

Related issues 🔗
Closes #4146
Closes #3259
Description ℹ

added new lib for tendermint API (will refactor other Explorer tm interactions in separate ticket)
added protocol upgrade notification
added protocol upgrade countdown to navigation
added "time to upgrade" to proposal view (shown for pending proposals)
added "upgraded at" to proposal view (shown for done, data taken from tendermint)
changed "viewing as" banner to use NotificationBanner component

Demo 📺
TODO(art): Add a video recording here...

Rebased, mainly to trigger the test runs again


Commits

Hi @EMI-INDO , seems your plugin is progressing fine. Nice to see.
One thing, your commits to the javafile is not working orrectly. Seems like you copy paste the entire file every time, so it is not possible to follow the updates in the commits your are doing, since the entire file is marked as 'changed' every time, since your file is pasted without any line breaks (so the whole file is just one line). The js files and html are correct. See this example: https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/commit/97bf8ccaf1ffefc23a3f1757a999148065a4db09
One other function your should add is the "mute"-function:
MobileAds.setAppMuted(true);
You can check how Ratson implemented it back in time in his plugin.
Looks promising, thank you!

@fredriksthlm
everything is correct.
I intentionally Minify Java files,
And make it 1 line.
https://www.aspect-ratios.com/minify-java/
What changes I made are written in each release.
https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/releases
No need to check java file commit.
MobileAds. setAppMuted(true); already available,
.everything is already in the Java file,
It's not time for new features to be released,
all I have to do is make a new line in www/js.file, the new features in the Java file will runrun.

@fredriksthlm
Your request  MobileAds.setAppMuted(true);
https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/releases/tag/v.1.0.9


Fabric port

Would a fabric port be possible?

why was this closed

Because I'm not making a fabic port...


Add support for download and share.

Library used for download https://github.com/wkh237/react-native-fetch-blob.
It supports use of native download manager for android and file stream for large files in addition to features supported by https://github.com/itinance/react-native-fs.

@Sam1301 Hey just one question, does this library supports both android and iOS files upload? As it will help for my work on uploading files.

@saketkumar95 yep, checkout https://github.com/wkh237/react-native-fetch-blob/wiki

oh, forgot to post the update message :)
Updated the branch, also posted a question here.

Updated the branch.

Good to go.


Remove VMChecker

!test

Refer to this link for build results (access rights to CI server needed):
http://jenkins.2gis.local/job/vmmaster.regression/443/
Test FAILed.

!test

Refer to this link for build results (access rights to CI server needed):
http://jenkins.2gis.local/job/vmmaster.regression/444/
Test PASSed.

:+1:

@z00sts в config_template переменные остались, ну и про деплой не забудь

а так :+1:

!test

Refer to this link for build results (access rights to CI server needed):
http://jenkins.2gis.local/job/vmmaster.regression/450/
Test FAILed.

!test

Refer to this link for build results (access rights to CI server needed):
http://jenkins.2gis.local/job/vmmaster.regression/453/
Test PASSed.


Refactor main.py Script

It has some weird conditional statement placement, and it probably causing inefficiency. They are also just structured in a strange way.

#13 contains improvements, using in instead of multiple  == or !=

#15


support Swagger Extensions

Swagger 2.0 use something like x-logo as vendor extension，there is no need to validate

What's the effect of this? This is a backwards-incompatible behavior so we need to think about it. Either way the change needs tests and possibly documentation, including UPGRADING.md.

I use grape-entity grape-swagger-entity, I might do something like this  https://github.com/ruby-grape/grape-swagger-entity/blob/9f44aa2a525be36fec8a7369bf1c1fd7130d879f/spec/grape-swagger/entity/attribute_parser_spec.rb#L103
but when the document contain x, grape will trigger x validator which raise unknown validator error.

About swagger extension, please visit https://swagger.io/docs/specification/openapi-extensions/

If it's something generic and documented I'm open to merging a PR with documentation, tests, etc., will need to read up more on it. In the meantime, does setting RESERVED_DOCUMENTATION_KEYWORDS in your project work around the problem?

It's my mistake. I can use nested documentation in entity to avoid this:
class Entity
   expose :attr, documentation: { type: Hash, documentation: { x: { key: "value" } } }


bugfix/Update Main with Development

Dependencies, and set up for the next iteration.

Dev changed, and we need to go over some things before we push to main again.


Use {source_folder_name} as output format

Feature request!
I know it is possible with automated conversion to specify, that the output file should be placed in the same subdir as the original source file was placed in, but I could not get it to work with manual conversion. Handbrake (at least the Handbrake GUI) allows to set {source_folder_name} within the settings. Is it possible to add this feature for manual conversion as well?
Thanks!

I'm not developing or maintaining HandBrake itself.  You should probably ask your request at https://github.com/HandBrake/HandBrake/issues instead.

Closing this issue.  Please re-open if needed.


Pass import object to sheet events

Requirements
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Mark the following tasks as done:

[x ] Checked the codebase to ensure that your feature doesn't already exist.
[x ] Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
[x ] Adjusted the Documentation.
[x ] Added tests to ensure against regression.

Description of the Change

Why Should This Be Added?
When importing a file, AfterSheet and BeforeSheet events do not have the contextual object attached. The exportable currently used is null when importing. Those events should be passed the $import object as for the AfterImport event.
Benefits
Proposed PR passes the $import to the event constructor to expose the contextual object to the listeners.
Possible Drawbacks
The event concernable property was always null when importing, now it's filled with an object. Should not have any impact when used properly.
Verification Process
Implemented a listener using the RegistersEventListeners concern in a import class. The class instance in returned when calling the  getConcernable() method off the AfterSheet and BeforeSheet event.
Applicable Issues
Maybe before/after events should be separated concerns for import and export. Current code impose listeners that are not implemented directly in the import/export class to check the getConcernable() class to know if it's an import or an export.

Thanks!


STAC Server responding with SQL Create Error when using /collections//items with dedicated STAC Reader

In our setup with a dedicated AWS Aurora READ replica as Reader, the STAC server responds with this error message when querying the collections/_collection_id/items endpoints.
{
"code": "ReadOnlySQLTransactionError",
"description": "cannot execute CREATE TABLE in a read-only transaction"
}
The issues obviously disappears when setting the reader to the read/write instance however, I assume having a writeable instance as READER  wouldn't be the intention.

Right now, using search on pgstac is not a read only operation. It uses two tables searches and search_wheres that allow for the use of a hash for queries (leveraged by titiler-pgstac), cache expensive calls for context counts and maintain statistics about how many times queries have been used.

Is there a bug or discussion about making search (optionally) a read-only operation? I would be interested in this.

@ChristineSeeliger @bkanuka I've begun work on adding an option to allow use on read only instances in #215.
You should note that this mode will not allow you to register queries with their hash as used in TiTiler-PGStac.
It also prevents the use of a cache for context results (total number of results) - in particular, if you have the "context" setting turned on, queries (particularly when paging) may be very slow.


Extend Dart_CodeObserver to be notified when address ranges get collected

The existing code observer API from dart_api.h look like this:
typedef struct Dart_CodeObserver {
  void* data;

  Dart_OnNewCodeCallback on_new_code;
} Dart_CodeObserver;

If a process-wide registry keeps track of such code objects for symbolization purposes, that data structure can grow infinitely large, without an ability to delete dead ranges.
This can happen when isolates die and get born again. They will JIT from scratch, very likely into new address ranges.
=> We need to add another callback, e.g. Dart_OnExecutableCodePurged, to to let an embedder know when it's safe to delete old symbolization mappings.

 The former is probably preferred to avoid too many calls out to the embedder (which a) if run inside safepoints can prolong safepointing latencies b) run outside safepoints requires us to do many safepoint transitions).
/cc @rmacnak-google


Make jenkins e2e runs reuse one SSH key.

Helps alleviate #7714; other part of fix coming soon.
 Friday afternoon is a great time to kill Jenkins. LGTM.

This is breaking Jenkins.
It sets up the .ssh folder in the workspace as the first step.
hack/jenkins/e2e.sh checks to make sure that the workspace is empty and fails if it is not:
+ echo /jenkins-master-data/jobs/kubernetes-e2e-gce/workspace not empty, 'bailing!'
/jenkins-master-data/jobs/kubernetes-e2e-gce/workspace not empty, bailing!
+ exit 1
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception
hudson.AbortException: No test report files were found. Configuration error?

Yep, we're on it.
On Fri, May 8, 2015 at 3:47 PM, Saad Ali<EMAIL_ADDRESS>wrote:

This is breaking Jenkins.
It sets up the .ssh folder in the workspace as the first step.
hack/jenkins/e2e.sh checks to make sure that the workspace is empty and
fails if it is not:

echo /jenkins-master-data/jobs/kubernetes-e2e-gce/workspace not empty, 'bailing!'
/jenkins-master-data/jobs/kubernetes-e2e-gce/workspace not empty, bailing!
exit 1
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception
hudson.AbortException: No test report files were found. Configuration error?

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/7990#issuecomment-100387979
.

Great, thanks.


Failing test due to SSLv3 during Gentoo Linux stabilisation

A Gentoo bug was filed during a stabilisation attempt for httpie 1.0.2 on Gentoo Linux. As I noted in the comment, it might be related to #647 but I am not fully certain.
Looks like the test fails with "sslv3 alert handshake failure" instead of gracefully skipping over pytest-httpbin's incompatibility with SSLv3, which would need to be solved within the existing httpie tests and not in Gentoo.

Thanks for the report, @rseichter. I think this has just been fixed in master with https://github.com/jakubroztocil/httpie/commit/e93de1fbe7cc811735137fab037a52d6761c7f9e.

I'll try to test this over the coming days. My own temporary "fix" was a patch that extends the expected substring.


Didn`t work timeshift

Didn`t work timeshift.

Grafana
Zabbix
Grafana-Zabbix Plugin

6.7.2/6.4.3
4.0.15/4.0.18
3.11

Looks like it works as expected. Probably a reason is in the returned values. Also, it's not a plugin feature, but Grafana one.


getRawValue() after clearTextOnFocus causing issues if value not set

I've got a field set up and I want it to clear on focus with a placeholder of the old value (and then I would default it back to the original value).
<TextInputMask
                    ref={costField}
                    style={{flex: 1}}
                    type={'money'}
                    options={{
                        precision: 2,
                        separator: '.',
                        delimiter: ',',
                        unit: '$',
                    }}
                    placeholder={costPlaceholder}
                    value={newItem.costDollars}
                    onChangeText={handleUpdate('costDollars')}
                    onSubmitEditing={handleSave}
                    clearTextOnFocus={true}
                    onEndEditing={() => console.log('endEdit', costField.current.getRawValue())}
                />

The issue comes up when value is set, and then the user selects the field (causing it to reset). Then, the use deselects the field and the TextInputMask throws an error

Disregard

Re-opened: This error is actually coming from the getRawValue function.

onChangeText={(masked, unmasked) => console.log(typeof unmasked)}
the second parameter returns the item without mask


⚠ SceneTime has degraded performance

In b121e72, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1256 ms

Resolved: SceneTime performance has improved in b1c09df after 7 minutes.


Fail to load standalone number or some words in Vietnamese

Tested with vie.traineddata, they returned null, ("")

can we have any way to improve them? Thank you so much!

Please use tesseract user forum for asking support


Fix compile error when target is wasm and multipart feature is enabled.

This PR aims to close #1295.
Without this fix master (and v0.11.4) fails to compile with this command:
cargo build --target wasm32-unknown-unknown --features multipart
@seanmonstar Your initial suggestion was to remove #[derive(Clone)] from enum Inner, and change clone() method to try_clone() that matches on the inner type.
But after some research I found out that clone could be implemented for both Inner::Bytes and Inner::Multipart with minimal changes. (I added several #[derive(Clone)] attributes)
What do you think about this change? I am open to implementing your initial suggestion.
I am open to feedback and I will address comments asap.

Thanks for the review. I will make fixes asap if the problem is not solved by that time.

So far what I managed to do was to fix compile error without exposing clone(). But there's one catch that if Inner type is Inner::Multipart(_) then try_clone returns None.
I have spent some time trying to implement clone to Inner::Multipart(_). But I didn't find a way do it yet without exposing clone() methods to public interface.