Property casting and validation improvements

In my mind the way in which Mongoose handles model property casting is broken.
As an example, let's say we define a model with this schema:
var Item = new Schema({
  name   : {type : String, required : true},
  price  : {type : Number, required : true},
  description : {type: String, required: true}
});

... and we create a new instance, but provide a value for price using the wrong type:
var item = new Item({name:"Blender", description:"Makes frozen daquiris", price:"five hundred dollars");

Mongoose will simply silently ignore the incorrectly typed variable and my object will just look like:
{ _id: 50056c29527d176a1d000001, name:"Blender", description:"Makes frozen daquiris"}

If we attempt to create() a new model directly with these property values a CastError is thrown.
In both cases, I would argue this is the wrong behaviour.
Assignment of an incorrectly typed value is a mistake which should be caught using validation, just like absence of required values, values which are not in the required range, etc. We should be able to assign whatever values we want to the model (correct type or otherwise) and then be prevented from saving them to the DB by validation checks.
A lot of the time the data that is used to populate models comes from a web form, where the user can enter anything, so if we're using Mongoose validation to validate this data prior to saving it, we need to be able to validate type in a consistent manner to everything else.
Throwing an out-of-band CastError or ignoring the assignment entirely mean you need to write a bunch of code to detect and handle these special type-cast errors outside of your validation logic. At the very least, if we assign a value to a property, that assignment should not silently fail.
To draw a parallel with Rails, if I want to validate the numericality of a property on my model I simple declare validate :price, :numericality => true in my model and any such failures get bundled into my model's errors collection with all other validation failures.
Is this not more correct? Is there a plan to move in this direction?
Thanks to all of you LearnBoost guys for all you hard work - much appreciated.

oops, my bad. Thank you @vkarpov15

@vkarpov15 Are these improvements in any of the 3.8 releases?

No, and won't be. 3.8.x releases include only bug fixes and aim to be 100% backwards compatible.


[Crypto] Changes to dtls code to match mbedtls 3.1.0

Some of the private fields are changed to public again in MbedTLS 3.1, update dtls to match these changes

@LuDuda @jwhui Can you check this PR? This PR updates the dtls code to align with mbedtls 3.1.0.


Implement GenesisChunked method

Implement GenesisChunked method, for compatibility with Tendermint RPC.
See: client.go

Hey @tzdybal do you mind assigning this task to me?


Clarify copyright statement in license

The copyright in the license and most source code headers is Aalto University.  I and perhaps others have never signed anything regarding copyright assignment for contributions.  Would it be worth putting a Contributor License Agreement (CLA) process in place going forward?

Yes, we should do this.

Closing as WontFix


Guess MIME type from file extension

Currently all files created in GCS are created with application/octet-stream MIME type, that makes it impossible to upload images for hotlinking from GCS.
It should be relatively easy to add support for mimetypes.guess_type, but it will increase usability of the module a lot.

Completely agree, thanks for the PR!
Sorry for the failing build, something was misconfigured in the pipeline. I will fix it and make a new release containing your changes right now.

Released 1.0.0

@birnbaum thanks! switching to your version


hidden-states from final (or middle layers)

🚀 The feature, motivation and pitch
I am trying to extract hidden states from the final layer of llama3-8b (i.e., the final batch_size, seq_length, n_emb vector before computing the logits). Would it be possible to add this functionality (i.e., access to hidden states similar to transformers ouput_hidden_states)? Thank you!
Alternatives
HuggingFace Transformers, but this is too slow.
Additional context
I am trying to train a SAE/linear probe on hidden states from llama3.

Maybe you could consider utilizing nn.Module's hook.

sample issue

Closing as stale. The comment that triggered unstale doesn't appear to be constructive.


Adding Team HackElite Submission

Challange 1-3

Linked to an earlier submission https://github.com/skill-a-thon/.github/pull/49


add parent/child explanation

Summary
In Nov 2023 we added an explanation table about how parent KBs relate to child KBs.  This table was mistakenly omitted from Release Notes when they started in April 2024.  This PR is to add the paragraph to published Release Notes.
Fixes #Issue_Number (if available)

Internal previews

📄 File
🔗 Preview link

docs/framework/release-notes/2024/04-09-april-security-and-quality-rollup.md
April 2024 security and quality rollup

docs/framework/release-notes/2024/04-23-april-preview-cumulative-update.md
April 2024 cumulative update preview

docs/framework/release-notes/2024/05-14-may-security-and-quality-rollup.md
May 2024 security and quality rollup

Hi again @TaraOverfield - just following up on this PR. Are you willing to add the include as suggested? Just trying to move this PR forward...thank you.

I'm closing this as stale and outdated.


Use a global SQLAlchemy engine for db connection pooling with psycopg2

Refactor the code to use a shared engine upon open and close session per request, avoiding redundant engine/pool creation. A global engine is safe to share across threads because SQLAlchemy's Engine object is designed to be thread-safe. Using a global engine ensures that all database interactions reuse the same pool of connections without creating redundant engines.

The focus is not just on replacing the global engine but also on managing session lifecycle per request. To achieve this, I applied a context manager to ensure sessions are properly closed after each request. This approach also aligns with my investigation in May into using FastAPI with connection pooling for better session handling.


Is this still mantained?

Good day, I really like this package. I was wondering if it is still maintained?
for the moment i'm using the fork from https://github.com/d-ukhanov/code_field which is a bit ahead. will there be new merges? will pub.dev be updated??

It is still maintainted ! If d-ukhanov wants, a pull request can be opened to merge new changes !


refactor: state validation and trie node traversal improvements

What was wrong?
The state validation could be improved after recursive gossip removal.
fixes: #1360
How was it fixed?

Improved trie node traversal logic and extract it to ethportal-api

it was previously designed only with validation in mind
now we can use it for other use cases as well (something we will need in order to support eth_* JSON rpc)
moved and added new tests

Removed no longer needed types
Extracted common logic into separate functions

Run hive tests locally (trin + fluffy clients) and all tests are passing.
To-Do

[ ] Clean up commit history and use conventional commits.

Are check_traversal_result_is_node() and check_traversal_result_is_value() planning to be used in the next PR?

My main concern is whether this refactor will be used in follow up PR's or not. It probably will just feels a little off because nothing is using it yet to justify it's complexity over the previous implementation. Rust traits are nice because they remove a degree of OOP, but yeah. So I mean it will be used, but what if which makes me hesitate.

Are check_traversal_result_is_node() and check_traversal_result_is_value() planning to be used in the next PR?

No. They are specific for validation logic (they expect only one variant). While they are used once and can be inlined, I made them separate function in order to simplify logic of functions that are using them (not because they themself were complex). I'm completely fine with inlining their logic.

The next PR (implementing eth_getBalance, eth_getCode) would definitely use NodeTraversal in a very nice way (in my opinion). Something like this:
async fn fetch_account_state(state_root: B256, address: Address) -> Result<Option<AccountState>> {
    let mut node_hash = state_root;
    let mut path = Nibbles::unpack_nibbles(&keccak(address));
    loop {
        let node = fetch_node_from_network(node_hash).await?; // using RecursiveFindContent
        let traverse_result = node.as_trie_node()?.traverse(path);
        match traverse_result {
            TraversalResult::Empty(empty_node_info) => return Ok(None),
            TraversalResult::Value(value) => return Ok(Some(AccountState::decode(value))),
            TraversalResult::Node(next_node) => {
                node_hash = next_node.hash;
                path = next_node.remaining_path;
            },
            TraversalResult::Error(error) => return Err(error),
        }
    }
}

Regarding usage of traits. I don't have a strong preference on this. It could be simple function.
I'm considering implementing it for the EncodedTrieNode (as it seems very common to call node.as_trie_node()?.traverse(path)), which could justify usage of traits.
Another potential usage is adding random_walk function, something that glados (and bridge looking for missing content) would use. That way all "traversal" logic is grouped together. Of course, this can be separate function as well, but I would say it makes sense to be grouped.

The next PR (implementing eth_getBalance, eth_getCode) would definitely use NodeTraversal in a very nice way (in my opinion). Something like this:
async fn fetch_account_state(state_root: B256, address: Address) -> Result<Option<AccountState>> {
    let mut node_hash = state_root;
    let mut path = Nibbles::unpack_nibbles(&keccak(address));
    loop {
        let node = fetch_node_from_network(node_hash).await?; // using RecursiveFindContent
        let traverse_result = node.as_trie_node()?.traverse(path);
        match traverse_result {
            TraversalResult::Empty(empty_node_info) => return Ok(None),
            TraversalResult::Value(value) => return Ok(Some(AccountState::decode(value))),
            TraversalResult::Node(next_node) => {
                node_hash = next_node.hash;
                path = next_node.remaining_path;
            },
            TraversalResult::Error(error) => return Err(error),
        }
    }
}

This looks very nice

Regarding usage of traits. I don't have a strong preference on this. It could be simple function.
I'm considering implementing it for the EncodedTrieNode (as it seems very common to call node.as_trie_node()?.traverse(path)), which could justify usage of traits.

I like traits as they prevent some types of abstraction I don't like, I do think their usage should have a reason of course which I think what you layed out is a valid case for them


Support for persistent node labels for node stop/restart

Context: In AKS clusters, when the cluster is stopped and restarted, new nodes are provisioned as part of the VMSS design. This leads to the loss of Kubernetes annotations on the nodes (i.e. kwasm.sh/kwasm-node=true), which impacts configurations that rely on those annotations. The current behavior of runtime-class-manager is to mutate containerd configurations based on annotations that are manually applied to nodes. However, since annotations are not persistent across cluster restarts, this causes issues with retaining the necessary configuration.
ref: https://github.com/spinkube/azure/issues/24
Proposal:
Labels such as kwasm.sh/kwasm-node=true should be used instead of annotations for the runtime-class-manager to identify and mutate node configurations. Unlike annotations, labels are persistent across cluster restarts and node reallocation.
The runtime-class-manager should be enhanced to detect and reapply configurations based on node labels automatically, without requiring manual intervention. This would ensure configurations persist across node restarts.
Lastly, the legacy code in node_controller.go needs to be cleaned up. cc @vdice @voigt

rcm does utilize labels today (see job_controller.go for a taste).  (The legacy kwasm-operator project uses annotations.)
a. However, re: AKS node turnover: I just tested and am not currently seeing any labels I've applied to one node persist to the next that has taken its place after an AKS stop/start cycle.  This seems like a blocker for the purposes of this ticket, right?
I'd be happy to pick the node_controller.go work up if I can get clarity on the intended functionality.  I assume its intention is to watch for new nodes and see if they have relevant labels (eg <shim name>=true) and if so install the shim?  So, this in combination with a fix for 1a  means we should have successful app restarts during node turnover?

Adding myself as an assignee as I had started on the second item mentioned in https://github.com/spinkube/runtime-class-manager/issues/222#issuecomment-2357062804: unlocking the node_controller.go functionality.

I finally got back to uncommenting and updating the node_controller.go code but quickly discovered that node_controller and the current shim_controller step on each other's toes.  The shim controller already watches for node label changes which also apparently includes new nodes registering with a cluster.  So, today, without any node_controller.go code, I believe we have the functionality to handle this issue, i.e. support for new nodes that register already having the appropriate label per a given Shim's nodeSelector config.
I added a GH workflow test to help verify this; see a sample run here: https://github.com/vdice/runtime-class-manager/actions/runs/11713448514/job/32626238479
If RCM today watches for node label events, including new nodes, I wonder if we can fully do without node_controller.go.  Perhaps this was what the original authors might have been thinking, hence being commented out.  Is there any other node management functionality that RCM needs that would warrant a node_controller?  cc @voigt @Mossaka @phyrog


Fix various errors in typo3 and typo3cms global commands, add wp command, fixes #2467

Pushed a commit to pack it into the binary.
Glad you checked those out!
The alpha1 release was a mistake. I must have pushed the wrong button :(

Since I was fiddling with packr2 and #2467 came in I hope you don't mind my hijacking this to add that in here. It's worth doing the packr2 as little as possible.

The alpha1 release was a mistake. I must have pushed the wrong button :(

I already thought so because it's not marked as pre release :(

I did notice and check the prerelease button.

Since I was fiddling with packr2 and #2467 came in I hope you don't mind my hijacking this to add that in here. It's worth doing the packr2 as little as possible.

Yeah this one came up today in Slack and I advised the user to open an issue for this as it looks WP CLI should be included also. No problem with your hijacking ;)


whitelist files to publish to npm

potential fix for https://github.com/ember-cli/ember-cli-mocha/issues/198

releasing as v0.14.1 now


feat: CoRE

Added basic CoRE functionality
Built baseless Agent schema which can be expanded upon for auto-agents.

Done! @ #130


Launch without internet connection

Hi and thank you for open-sourcing this amazing component!
I would like to ask if it is possible to launch the service without internet connection (see https://github.com/aiortc/aiortc/issues/524)

Do you mean the situation where both the client and the server are on the same host (localhost) without the Internet connection?
It worked at least in my environment, but I think it depends on browsers or other stuff as answered in the thread. WebRTC connection is dealt with by the browser's API (client-side) and aiortc (server-side) implementations.

Yes exactly, but it doesn't seem to work with my machine. If I have any updates I'll post them here!


add verification manager library

for verifying a bunch of stuff. Add as a separate lib for future threading purposes.

Merged as a part of #70


word_tokenize raises IndexError if . is in beginning of text in 3.6.6 but not in 3.6.2

**Example: **
If I run the code below with nltk==3.6.6, I get an IndexError
s = " . Hello my name is John"
word_tokenize(s)

However, running it in nltk==3.6.2 works just fine.
I have switch to nltk 3.6.2 for now, but perhaps this should be fixed?

Hello! This is indeed a bug. It has been resolved already, luckily! NLTK version 3.6.7 has solved this issue.
I would very much recommend upgrading to NLTK 3.6.7:
pip install -U nltk

(or similar with anaconda)
See #2925 for more information. (Other similar issues: #2921, #2925, #2927)
I hope this helped! Apologies for the inconvenience.

Hello again,
No problem! Thank you for the answer :)


Use context() instead of activity()

Using activity() causes a crash if the plugin is registered before the activity.
Fixes https://github.com/flutter/flutter/issues/24633

LGTM


Quick fixes not listed when multiple problems occur at the same place

VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.104-microsoft-standard
Remote OS version: Linux x64 4.19.104-microsoft-standard
Reported at https://github.com/DEVSENSE/phptools-docs/issues/79 to being with
Steps to Reproduce:

Have some code with 2 problems listed at the same place
Load the hover over problem dialog
Look at the "quick fix" suggestions

Does this issue occur when all extensions are disabled?: Yes/No

Please share steps to reproduce, including example code

Minimum reproduction with the phptools extension for vscode in an empty project:
file1.php
<?php

namespace One;

class ClassOne {}

class ClassThree extends ClassOne{}

file2.php
<?php

namespace Two;

class ClassTwo {

	function __construct() {
		$this->someFunction( new ClassThree );
	}

	function someFunction( ClassOne $one ) {
		// ...
	}

}

The problems reported on the issue line are:
{
	"resource": "/home/adam/dev/git/gerrit/mediawiki/core/test2.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "PHP0406",
	"severity": 4,
	"message": "Argument '1' passed to someFunction() is expected to be of type Two\\ClassOne, Two\\ClassThree given",
	"source": "PHP",
	"startLineNumber": 8,
	"startColumn": 24,
	"endLineNumber": 8,
	"endColumn": 38
}

and
{
	"resource": "/home/adam/dev/git/gerrit/mediawiki/core/test2.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "PHP0413",
	"severity": 4,
	"message": "Use of unknown class: 'Two\\ClassThree'",
	"source": "PHP",
	"startLineNumber": 8,
	"startColumn": 28,
	"endLineNumber": 8,
	"endColumn": 38
}

Problems correctly displayed in the UI but with no quick fixes available:

Quickfix is actually available:

I imagine this is probably reproducible with other reported problems if they can be made to appear on the same line.
If anyone has suggestions I can give it a go!

Does the extension mark its code actions with CodeActionKind.QuickFix?

@mjbvz yes, it is marked with "QuickFix". The quick fix works as expected if there is just one problem at that location. Once there are two overlapping problems, quickfix is not suggested by VSCode

I am not able to use above extension as it needs license.
VS Code asks for code actions with the given range of the problem, can you please check the range and the quick fixes you are returning?

@sandy081 @mjbvz thank you for the response - as expected it was a problem in our LS. Overlapping spans resulted in the code action being filtered out.
Thank you for your time! The issue can be closed.


create agnostic javabuildproperties for gradle and maven

Fix #8628

@murdos : after starting the implementation some doubts arose.

However my intention was to go a step further, and allow declaring java build properties also outside profiles, with the following API (for maven and gradle):
return moduleBuilder(properties)
.javaBuildProperties()
.add("node.version", "v" + npmVersions.getNodeVersion())
.add("npm.version", npmVersions.get("npm", NpmVersionSource.COMMON).get())
.and()

Should the javaBuildProperties() create a toml catalog version for gradle? Or should  it add a property at build.gradle.kts?
I asked the above questions because after remove .setVersion(..)API  from  .javaDependencies() the FileSystemJHipsterModulesRepositoryTest.shouldApplyModuleToGradleProjectfailed:
java.lang.AssertionError: [Can't find dummy-dependency = "4.5.8" in /tmp/jhlite-test/11b7925b-7d63-42c3-bf05-47e67d0fac57/gradle/libs.versions.toml]
Expecting actual:
  "plugins = {}
bundles = {}

Considering gradle project. Should the javaBuildProperties() create a toml catalog version? Or should it add a property at build.gradle.kts?
It should add a property in build.gradle.kts.
This is similar to #9207 but without profile.

This is required to port spring-boot-local-profile module to gradle.

I asked the above questions because after remove .setVersion(..)API from .javaDependencies() the FileSystemJHipsterModulesRepositoryTest.shouldApplyModuleToGradleProjectfailed:
java.lang.AssertionError: [Can't find dummy-dependency = "4.5.8" in /tmp/jhlite-test/11b7925b-7d63-42c3-bf05-47e67d0fac57/gradle/libs.versions.toml]
Expecting actual:
  "plugins = {}
bundles = {}

FileSystemJHipsterModulesRepositoryTest should be adapted :)

It is almost done. I have to check the code coverage which isn't 100%., I pushed it anyway to save my work.


MAINT: Minor cleanup from recent changes

Fixes #103
The changes in this PR represent my review of the changes merged as part of #100/#101.

Removed errant assert
Cleaned up circular imports
Revised new formats
Added some tests

Nevermind,  https://github.com/qiime2/q2-sample-classifier/pull/102 was already merged :)


Editor enhancements

While Quill.js is a powerful tool with great editing capabilities, it'd be helpful to have other options when it comes to an editor. Some of the viable packages we could include here are:

TipTap
Dante

I'm sure there are more. This at least gets us started on ways to improve the editing experience with Canvas.
Feature requests

Specify the size/dimensions or position (left align, center, right align, fixed etc) of an image
Liquid tags
Markdown support
"Link-to" sections within a post
Scientific notation support
HTML5 video support
Link customization (follow, nofollow, specify targets)

For the link customization, can the target also be specified please.

Dante looks great. Better than Quill.js

For enhancements to the editor, I'd like to see a "clear formatting" button. This would be especially useful when toggling the "code block" button as some words/characters keep special formatting.

Thumb generation option must be there for featured images , with 10 post each 3 MB its taking 30 MB to load in canvas-UI

@sahil1572 Could you expand on that a bit more? Just want to make sure I know what you're getting at.

these images on home page category and tag listing pages  need to be cropped as they are being served in full size .

In addition to scientific syntax, it must me awesome to allow the integration of nice tables and charts (chart.js could be awesome for that : https://github.com/chartjs/Chart.js)

Closing this in favor of opening a discussion here.

Closing this in favor of opening a discussion here.

Laraberg editor will solve the editing experience. Because, the editing experience with canvas is very poor at the moment. Is there a way to change the editor at our end?


Add Patient Name to Results DOB Entry Screen

WHY?
Based on a high volume of support tickets related to expired results links, we believe there is some confusion around the birthdate that must be entered to acccess a result. We would like to make this more clear by including the name of the patient on the result, in an effort to make it clear whos birthdate should be entered to access a result
AS A receiver of SimpleReport results emails
I WANT it to be clear who the result i receive pertains to
SO THAT i know the DOB to enter in order to access my result

GIVEN a result has been sent to me
WHEN I follow the link in the result email and reach the screen where i have to authenticate with a DOB
THEN I can see the name of the person the result is for
BEFORE: Enter 'your date of birth' to access your COVID-19 testing portal.
AFTER: Enter 'the date of birth provided for insert patient name' to access your COVID-19 testing portal
Note: this link will expire 5 days after the test result was recorded.
Date of birth
For example: 4 28 1986
Month
Day
Year
Continue

Whoever picks this up, please pull in @vz3 to pair

Please contact the support team as soon as designs are live so that they know what the new version will look like.
They want to know where the name is going (on email/ text AND on the link page or just on the link page?)...
Also, there is a recommendation as we're editing this to remove SimpleReport from the intro on the email that starts with "Greetings from SimpleReport" either to "Greetings" or "Greetings from FACILITY" to reduce the impression that folks should come to use for follo-wup

@nathancrtr please see draft copy suggested in the body of this doc. Are we able to customize the name of the facility and expiration date of results here? We created copy with the assumption that we can, lmk if not and I'll modify.

@Rebecca-LM yes, we can add the facility name and link expiration date to the DOB verification screen and it's a great idea! There will be a bit of lift involved since that information is not available to the application in advance. It will have to get that data from the server, which adds a bit of complexity.
At this point I would lean towards breaking out facility name+expiration date into a new ticket, @vz3 how does that sound?

I'm not @vz3 :) but I agree with that @nathancrtr - let's ship without it on this first go since the most requested info is the name and facility and folks can do the math with the time stamp and # days in the meantime.

I'm good w breaking those into a new story

Great! @nathancrtr are you able to create the new story? Just want to make sure it gets logged/addressed when everyone has time to loop back :)

@Rebecca-LM yes indeed, see the new story here: https://app.zenhub.com/workspaces/simplereport-better-data-team-605b43d51ea9f700119a48ee/issues/cdcgov/prime-simplereport/3332

much appreciated! lmk if you need my eyes on things


Reddit improvement proposal - nestest structs

It'd be neat if you could handle nested structs to control for flow e.g.
type Command struct{
Foo *struct{
Bar ,-b, mandatory
} clap:"foo"
Biz *struct{
Bar ,-b
} clap:"biz"
}
go run main.go foo -b "because bar is required"
go run main.go biz
That being said there's nothing here that prevents the user from doing that themselves

Oh this would be awesome ! Really like clap


Add extension when generating filename

Currently UploaderUtils.generateFilename() returns filename without extension.
This can lead to file-type mis-parsing, for instance, MesosFetcher.
This pull request adds filename extension.

Looks good to me!


SEO: Add fixed text to main page

Per discussion with Jonathan, we'd like to make the Project Index more discoverable by people outside CfA. One way to do that is by boosting our search engine ranking. One way to do that is to add 100-150 words of "fixed text" at the top of the main page. This text should:

Not change nor be dynamically loaded
Include keywords that relate to what people might be searching for
-I've seen some discussion on CfA slack about keywords, like "tech for good" has a higher search volume than "civic tech" for example. So we may want to consult with someone at CfA about what keywords they're leaning into. I'm happy to do this if @giosce or @k3KAW8Pnf7mkmdSMPHz27 can tell me who to reach out to.

Another advantage of adding the fixed text is that in addition to being better for the google robots it's better for humans too ;)

@rkaufman13 I have no idea about whom to reach out to. I'll ask if anyone else knows in the Wednesday meetup.


Regarding tensorRT of TrailNet_SResNet-18

Is the TrailNet_SResNet-18 Pretrained model an optimized ones that built using TensorRT? If so can you please share pretrained model without optimized ones.

TrailNet Caffe model was originally trained in Caffe using FP32 precision.
The model is used by our ROS node which uses TensorRT to load and optimize it for fast inference.
The target precision FP16/FP32 is selected based on user-provided parameters, see launch files for more details


fix: Loading old presets

Pull Request:
Does the issue occur in the electron-app or the web-app?
midi-bricks-electron
Can you determine, which version was used?
Version: 1.2.5
Describe the bug
Old presets could not be loaded, because app was not aware of being fields undefined.

Loading old presets works fine in 1.2.8.
Both work: .js and .json


Git clone is broken

Git clone fails to merge, even when GitHub merges a PR cleanly.
See:

https://github.com/instructure/android-uno/pull/1470
https://www.bitrise.io/build/da485dee3bcd053a
https://www.bitrise.io/build/3a1857465d67638c
https://www.bitrise.io/build/b922884d60cf9b0f
https://www.bitrise.io/build/59e263db832eef47
https://www.bitrise.io/build/e9863bfbd351a3a5

This works locally:

git checkout a3e86aaa29bbec517ea3f3ddccd96425b0a80405
git merge 6c4224fee2fda3d968bee0505658a109557f111c

Update: Seems to be due to a Script used for disabling git LFS before the git clone step. Still debugging.

Note: it works if you disable git LFS with:
git config --global lfs.fetchexclude '*'`

Thanks for reporting & for the link @bootstraponline ! ;)


fix: logEvent callback on content block

Summary

Fire callback, if user blocks Amplitude.
Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:

Potentially? The behaviour changes to some degree, but it was always possible to call callback(0, 'No request sent', {reason: '...'}). So the user should be prepared for that.

Hey @donaldpipowitch, thanks for this PR. Were you able this working on a test app?
I tried these changes out with create-react-app + ublock but the callbacks still weren't being called
import logo from './logo.svg';
import './App.css';
import amplitude from 'amplitude-js'
import React, { useEffect } from 'react';

const callback = (responseCode responseBody) => {
  console.log(responseCode)
  console.log(responseBody)
}

function App() {
  useEffect(() => {
    amplitude.getInstance().init("MY_API_KEY")
    amplitude.getInstance().logEvent('Amplitude-JavaScript-Demo: initialized', {}, callback)
  });

  return (

        <button onClick={handleClick}>Send Event</button>

  );
}

export default App;

My bad... of course sending the request is still async. So this is triggered by _sendEventsIfReady which gets the callback even though _sendEventsIfReady doesn't expect a param. Strange.
But the callback is kept inside _unsentEvents and _sendEventsIfReady triggers sendEvents... which really makes a request - and there is no error handling. And it looks like I need to call removeEvents in order to invoke the previously saved callback. So I guess what I really need to fix is:
https://github.com/amplitude/Amplitude-JavaScript/blob/03ad2b91981012d87ce7f33ab577edceed2c1af5/src/amplitude-client.js#L1600

@donaldpipowitch I looked deeper into the fix. It belongs in _limitEventsQueued and I worked off your branch in #342. Thanks for bringing the issue up!

@donaldpipowitch I looked deeper into the fix. It belongs in _limitEventsQueued and I worked off your branch in #342. Thanks for bringing the issue up!


firestore-bigquery-export: Schema Views Script create columns with mode REPEATED

[READ] Step 1: Are you in the right place?
Issues filed here should be about a feature request for a specific extension in this repository. To file a feature request that affects multiple extensions or the Firebase Extensions platform, please reach out to
Firebase support directly.
[REQUIRED] Step 2: Extension name
This feature request is for extension: \firestore-bigquery-export: fs-bq-schema-views script
What feature would you like to see?
The schema views script should be able to handle and create columns with mode REPEATED. It is documented in BigQuery that it supports nested and repeated structs but the schema views script is unable to create them. I tried specifying a field like so but the script does not parse the field correctly:
    {
      "name": "rates",
      "type": "map",
      "mode": "repeated",
      ...

How would you use it?
The schema views script will be able to create columns with mode repeated so that more complex data types can be streamed from FS to BQ.

Hey @yilunc, you can define maps in your schema by doing the following:
{
  "fields": [
    {
      "name": "user",
      "type": "map",
      "fields": [
         //map properties are listed here
        {
          "name": "email",
          "type": "string"
        },
        {
          "name": "hometown",
          "type": "geopoint"
        },
        {
          "name": "name",
          "type": "string"
        }
      ]
    }
  ]
}

Described here in the docs. You can also keep nesting maps within maps.
Does this fulfil your needs?


Handle screen resizing

At first glance, it seems (at least under wlc-x11) way-cooler-bg decides the size of the background once upon startup, and after that doesn't respond to screen size changes.
(I'm quite unfamiliar with way-cooler / way-cooler-bg / wayland, so I might be reporting to the wrong project here - bear with me :) )

That is correct, the Way Cooler background program is currently very, very basic. Even if Way Cooler supported multi-head output (which it doesn't currently, which is something I'm going to address soon), the background program wouldn't even handle that correctly.
The way the background is implemented Way Cooler is side is quite a hack as well. To do it properly, Way Cooler should implement a proper Wayland protocol (either similar to or exactly how sway implements it). Right now, the background program is "special" because it uses a special class name that Way Cooler looks for, instead of having the surface passed directly to Way Cooler. This is something I plan to fix in the future, once we have other, more important features in place (such as a bar). The nice thing about the protocols though is that once we implement a standard one, any programs that use that protocol (eg, sway-bg) automatically works for free with Way Cooler (so it would be possible to swap out way-cooler-bg with a program that has more features, if the user wanted).
Despite all that, it's (very) possible right now to handle resizing the background when the output size changes. I've added a ticket on Way Cooler side (because that's where it would have to be changed) to implement this feature, which should be in 0.4.2.
Also, side note -- very soon we will begin releasing github releases of Way Cooler that will be tarred versions of way-cooler, way-cooler-bg, and an install script to put them in their proper place. So soon it will no longer be necessary for users to follow the insane steps needed to compile Way Cooler and the way-cooler-bg from source, they can just get the binaries directly from us. Thanks again for your README contributions though! 👍


Usage in normal games (outside of the spectator mode)

Hello, following up on the SoloQ-Flex topic, ive tried and i have to say it works quite well, Names, Summoner Spells, Intended Pick, Bans those are just spot on, however there are some things that do not work as good, for example Position/Role detection is not working at all in SoloQ-Flex queues, also, team sides.
Now to my question, i know of apps that can detect the role/position of given player during draft, is there a way that this could be added? or it would need to be a complete rewrite? same goes with team sides.
Thank you all, i know this is not the intended use for the program but still i'd be awesome. o/

The position information isn't provided to my understanding, as there are
obvious problems around counter picks and such being abused if that data
was available.
I believe you can only see your team's position and the side of teams is
hinted at with who has first pick or not.
But the tool will always show your team on the left hand side I believe.
On Wed, 13 Jan 2021, 1:10 AM Gnaj<EMAIL_ADDRESS>wrote:

Hello, following up on the SoloQ-Flex topic, ive tried and i have to say
it works quite well, Names, Summoner Spells, Intended Pick, Bans those are
just spot on, however there are some things that do not work as good, for
example Position/Role detection is not working at all in SoloQ-Flex queues,
also, team sides.
Now to my question, i know of apps that can detect the role/position of
given player during draft, is there a way that this could be added? or it
would need to be a complete rewrite? same goes with team sides.
Thank you all, i know this is not the intended use for the program but
still i'd be awesome. o/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RCVolus/lol-pick-ban-ui/issues/55, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5AJOPLVTSOIN5RRQBOTYDSZTJH5ANCNFSM4V752Y5Q
.

The position information isn't provided to my understanding, as there are
obvious problems around counter picks and such being abused if that data
was available.
I believe you can only see your team's position and the side of teams is
hinted at with who has first pick or not.
But the tool will always show your team on the left hand side I believe.
On Wed, 13 Jan 2021, 1:10 AM Gnaj<EMAIL_ADDRESS>wrote:

Hello, following up on the SoloQ-Flex topic, ive tried and i have to say
it works quite well, Names, Summoner Spells, Intended Pick, Bans those are
just spot on, however there are some things that do not work as good, for
example Position/Role detection is not working at all in SoloQ-Flex queues,
also, team sides.
Now to my question, i know of apps that can detect the role/position of
given player during draft, is there a way that this could be added? or it
would need to be a complete rewrite? same goes with team sides.
Thank you all, i know this is not the intended use for the program but
still i'd be awesome. o/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RCVolus/lol-pick-ban-ui/issues/55, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5AJOPLVTSOIN5RRQBOTYDSZTJH5ANCNFSM4V752Y5Q
.

Hey!
As Pieter mentioned, this data is just not provided, because it will be in the same order it's also displayed in champ select.
About the issue
To obtain the data, the pick-ban-ui backend service connects to your local League-Client via a local interface. There, it can fetch information about the current champ select. It will periodically pull this information, and the frontend will take care of visualising it. Information such as which team is red (right) / blue (left) and actual position ordering is not fully available.
For the own team, it could be possible to order roles by the selected position supplied (so always top comes first, regardless of where the player is in champ select) - although I'm not sure if it is in the data. Also this will come with the side effect, that top may not always actually pick first. So the order of things will then be rather random. But that's just how the League champ select in SR normal games works. For the enemy team, we don't have that information at all.
Possible solutions
While it is possible to try and do some tricks, like guessing what champion usually goes to what position and going from there, it may become possible to guess a bit more and maybe even in the enemy team where there is almost no information at all. But I see it out of scope for this project, but it could be a good starting version to go from. So you don't need to rewrite it all together, the software is built quite modular and is also extensible. So feel free to give it a try, I'm happy to see if anything becomes possible!
Best regards
Lars

Hey!
As Pieter mentioned, this data is just not provided, because it will be in the same order it's also displayed in champ select.
About the issue
To obtain the data, the pick-ban-ui backend service connects to your local League-Client via a local interface. There, it can fetch information about the current champ select. It will periodically pull this information, and the frontend will take care of visualising it. Information such as which team is red (right) / blue (left) and actual position ordering is not fully available.
For the own team, it could be possible to order roles by the selected position supplied (so always top comes first, regardless of where the player is in champ select) - although I'm not sure if it is in the data. Also this will come with the side effect, that top may not always actually pick first. So the order of things will then be rather random. But that's just how the League champ select in SR normal games works. For the enemy team, we don't have that information at all.
Possible solutions
While it is possible to try and do some tricks, like guessing what champion usually goes to what position and going from there, it may become possible to guess a bit more and maybe even in the enemy team where there is almost no information at all. But I see it out of scope for this project, but it could be a good starting version to go from. So you don't need to rewrite it all together, the software is built quite modular and is also extensible. So feel free to give it a try, I'm happy to see if anything becomes possible!
Best regards
Lars


polygon.py example at http://toblerity.org/shapely/manual.html#polygons doesn't work

from matplotlib import pyplot
from matplotlib.patches import Circle
from shapely.geometry import Polygon
from descartes.patch import PolygonPatch
from figures import SIZE

from figures import SIZE
ImportError: No module named figures
I installed shapely, matplotlib, descartes

The figures module is used by scripts in the manual for a few constants, such as figure size and colours:
https://github.com/Toblerity/Shapely/blob/master/docs/code/figures.py

@snorfalorpagus thx:) i will check


Tinker with Paparazzi

Some early explorations

Mostly easy to set up and record baselines
Can nicely enforce in CI that files are checked in via lfs
Using circuit-core temporarily, not something we probably have much of a use for in circuit itself though. Maybe a multi-screen nav flow where we assert static screens at each step?

Some early limitations

Only works in library modules - https://github.com/cashapp/paparazzi/issues/107
Doesn't work on compile SDK 33 yet - https://github.com/cashapp/paparazzi/issues/558
Requires extra config for JDK 16+ - https://github.com/cashapp/paparazzi/pull/566

ugh, this may be a non-starter till there's another release. That compile SDK 33 restriction's unpleasant.

There's a way to backport Paparazzi tests to compileSdk 32, fwiw

Yah I know, I just mean it looks like we'd need to downgrade a few of dependencies too and keep track of them

Superseded by #204

Superseded by #204


UserProfile: Added mobile responsiveness.

Menu icon and close menu icon was added to images folder.

Started mobile responsiveness.

Still working on toggle for nav items of mobile screen.

@pauline-banye


Update on Flexbox-based output style?

I know the wiki mentions this, but curious if there are still plans to add a flexbox-based output style?

I'd like to know this as well.

As would I.
I like the fact that Singularity uses mixins instead of grid classes which allows for more semantic markup, but having that combined with a flexbox-based grid is what I want.
I started out looking at Bourbon Neat which also allows semantic markup, but my search for flexbox led me to Batch -- which uses grid classes. Ugh!
I'm starting to wonder if I'm gonna need to hack together my own solution.

@garrettw, flexbox is just a handful of commands. I don't think that any kind of flexbox framework is required.

@Vaggos I could say the same thing about a float-based layout. You're free to think what you want, of course, but I personally think it would be helpful to have a flexbox-based system that's as easy to use as Bootstrap (like Batch is) but that's built around mixins so that I can use my own CSS selectors.
Oh and it needs to be something without device-based breakpoints so that I can easily set my own based around the content.

@garrettw In having worked on a flexbox output mode a while back I keep coming back to @Vaggos’ point. The syntax is close enough that abstraction is superfluous. Writing display: flex already snaps children into a grid and then flex: # where # is the singularity column-span function means that creating an output mode is not simplifying things, it’s obscuring how the CSS works.
If more lines of code were to go into flexbox I would have probably continued work on this output mode, but I’d suggest you use the flexbox syntax here. You can map Flexbox to the Singularity config, but I’d rather not obscure something unnecessarily. There is an API you can leverage to make this an output mode if you wish to have it as an output mode.

Fair enough. Thanks for the input.

Singularity is genius I've only been toying with it for a day or 2 and I'm amazed.  Scott says Flexbox does not require an abstraction. Does this mean that in 2017 you are not future-proofing yourself by starting to use it?  I want the answer to be no and that there are a wide spectrum of reasons why. My fear is that it is a piece of brilliant technical engineering on a soon to be redundant layout methodology.  Are there reasons to use Singularity now that Flexbox is widely adopted?

@LndnMdiaLb Flexbox is not a good grid tool. What we're waiting on that will replace singularity is the css-grid spec. It is finished as far as I'm aware and supported by most of the major browsers. According to the readme, singularity development has stopped because of this. https://github.com/at-import/Singularity#css-grids-and-singularity

@tyler-barnes Thank you very much for clarifying


Explicitly pass state to eligible function

The eligible function uses the state object implicitly. (Also missing type hinting.)
    def eligible(index):
        validator = state.validator_registry[index]
...

The eligible function has access to the scope of the function in which it is defined.
This is entirely valid and executes properly.

This is entirely valid and executes properly.

Yes, but it's ugly and this function is also referred to in the phase 1 spec with "note that it is not a pure function because state is declared in the surrounding scope"

Yeah, making it into a pure function seems reasonable.

The eligible function is gone in https://github.com/ethereum/eth2.0-specs/pull/850


What is a tag?

The spec references "tags" quite a bit, but never defines them. I'm curious what everyone here (mostly registry operators) think a tag actually is.
My understanding of a tag is that it is effectively a git ref, i.e. it is a pointer to a manifest (or image index) digest that is namespaced to a repository.
I've been part of a conversation where users expected a repository to support having a tag for each platform so that they could push each platform's image individually and have the registry assemble a manifest list for them (cc @tianon please correct me if I'm wrong here).
Similarly, on this thread, some users expect the registry to support having a tag for each media type.
I wonder if it's worth clarifying somewhere (maybe not the spec, but just in this issue) so we can point to the answer of why we can't do this. It's clear that we can support pulling heterogeneous media types and platforms (that's the point of an image index), but we would require clients to assemble them rather than the registry (due to the trust model -- I expect the digest of what I pull to be what I pushed; you can't easily sign something the registry synthesizes).
cc @stevvooe @dmcgowan would love to hear your thoughts here.
PS: related, there is a TAG_INVALID error: During a manifest upload, if the tag in the manifest does not match the uri tag, this error will be returned.. cc @atlaskerr related to #47 this is a schema-1-ism.

A tag is a graph edge from a name to digest, possibly decorated with a type. It could be represented with a descriptor.
To be honest, I'd like to see a first class tag type based on descriptors:
{
  digest
  mediaType
  name // tag goes here
  ...
}

Hi @jonjohnsonjr
As you saw in the discussion, I was hoping to have image:tag references be multi-dimensional. A tag could represent:

an artifact by name
a version of the artifact using :tag
pivot on the artifact type (image, helm, msix, arm or cfn template, ...)

just like extensions on a file system allow a pivot of oci-spec.pptx, oci-spec.docx, oci-spec.ms
"Picking my battles", feeling the resistance, I've resorted to using namespaces:

demo42.azurecr.io/samples/image/hello-world:1.0
demo42.azurecr.io/samples/helm/hello-world:1.0
demo42.azurecr.io/samples/cnab/hello-world:1.0
demo42.azurecr.io/samples/arm/hello-world:1.0

At this point, an image:tag is:

a pointer to a digest that can represent a specific artifact (image, helm, cnab, ...)
versioned using the :tag

Just to tease this out a bit more:
One of the great debates has been what should be in a specific repo. What are the pivots of a repo?
Should a repo be one thing, only pivoted by version and os/platform?
This gets really sticky when grouping runtimes and SDKs.
If you look at the current jdk or dotnet repos, they contain the runtime, sdk and depdendencies that make one hell of a mess.
After loooooooooong debate on discoverablity, ease of use, and customer usability studies, we finally landed on product groupings. Working with the folks at Docker hub, we were able to present these as follows:

https://hub.docker.com/_/microsoft-windows-base-os-images
This is a product landing page, grouping all the Windows images.
However, each repo is one thing.  You'll notice:
https://hub.docker.com/_/microsoft-windows-servercore docker pull mcr.microsoft.com/windows/servercore:1809
https://hub.docker.com/_/microsoft-windows-nanoserver docker pull mcr.microsoft.com/windows/nanoserver:1809
https://hub.docker.com/_/microsoft-windows-iotcore docker pull mcr.microsoft.com/windows/iotcore:1809

The dotnet repos will also transistion to this new model shortly.
The point i'm making is we've used a repo to represent a single thing, with multiple architectures and versions.
A collection of similar things are grouped in a namespace.
mcr.microsoft.com/[productFamily]/product:version
As with most things, guidance would have been helpful. We created the mess of multiple things in a repo, becuase we copied the existing mess. It was hard to justify doing something different, becuase the mess was the standard.

There is interesting discussion here, but not really any call to action. A lot of the discussion is unrelated and could use its own issue.
Do we need to improve the wording around tags in the spec? If not, let's close this and continue discussions in new, focused issues.

We might just want to add some documentation about tags once https://github.com/opencontainers/org/pull/9 lands.
The spec only mentions tags in passing without any description or guidance. If that's an intentional choice to keep registries flexible, that's fine, but I wanted to point out there's a gap in the docs.

@jonjohnsonjr will you try your hand at a PR for this?

like jimmy said, good discussion, but if anything this is just teasing out particular clarity needed.
I'm closing this for now.


python 2 / 3

What is the view on python 2/3  compatibility?
Bit of an example from tests.py.  I was wonder if if it should be written this way so that it works in both python2 and python3.  Python3 has no long type.
def test_number(value):
    """Return true if the variable is a number."""
    try:
         return isinstance(value, (int, float, long, complex, decimal.Decimal))
    except NameError:
        """No long in python3"""
        return isinstance(value, (int, float, complex, decimal.Decimal))

Kind of obsolete. The current test doesn't check for long anymore. However, that means it checks for different values in Python 2 and Python 3 which is probably not very good...

Just for reference, this is fixed by #406 / c6c6ea14375db6fb6a23a8bca533a6e388356422


Phase 2: typescript interfaces

Mod augur-ui in monorepo to import interfaces from augur-node and verify they are correct and usable in augur-ui.

The direction here will depend on the interface @brianosaurus and @JohnDanz come up with

submitRequest calls are now typed. These will be replaced with those from augur sdk.


cornerRadius is not working when creating screen shot

When I use drawing cache to create screen shot, I found cornerRadius will dismiss on Android Lollipop  or later. The code is below:
fun getScreenShot() {
    val dView = (context as Activity).window.decorView
    dView.isDrawingCacheEnabled = true
    dView.setWillNotCacheDrawing(false)
    setImageBitmap(Bitmap.createBitmap(dView.drawingCache, 0, 0, width, height))
    dView.destroyDrawingCache()
}

I think it is a problem cause by the internal render mechanism.

Hardware composition effects don't appear on screenshots taken using that method. This is an issue related to Android framework, not to Carbon. It's possible to fix it using a couple of tricks and Carbon used to do that using RenderingMode settings. Unfortunatelly for your case, I removed RenderingMode together with RenderScript and currently I don't plan to implement it back. See: #281
Taking screenshots from code is currently done using PixelCopy. You may want to take a look at that: https://medium.com/@shiveshmehta09/taking-screenshot-programmatically-using-pixelcopy-api-83c84643b02a


Add histogram selection view

HistogramWidget is significantly extended.
Now it keeps track of click-n-drag events over the histogram.
Each non-empty selection yield a re-plotting of histogram on
the selected portion of the data. A click returns to the previous view.
The widget now owns the dataset it operates on.
Tests: Unit tests, manual profiling of OrbitTest
Bug: http://b/220682825

I've dropped the movie to the chat.


Factory for custom database view

My setup is users have many projects and projects have many tasks. Tasks are actually setup as nested attributes for each project.
I have merged these together using a database view (with a project_task model) and each record in the view returns a task, the task's parent project and the project's parent user. I have cherry-picked the fields in the database view that I want to include rather than including all fields from each of the 3 models.
I also have a couple of custom fields in the view, eg:
GREATEST(tasks.updated_at, projects.updated_at, users.updated_at) AS updated_at

My current factories are:
factory :user do
  # user fields
end

factory :project do
  # project fields
  user
  tasks       { [association(:task)] }
end

factory :task do
  # task fields
end

In my specs I currently need to do:
before do
  create(:project)
  @project_task = ProjectTask.first
end

Is there a way to create a factory to return the project_task record rather than having to call create(:project) and then get the first record?
I tried what was mentioned in https://github.com/thoughtbot/factory_girl/issues/449 but it didn't seem to work with my view not including all fields from each of the associated models/tables.

@amnesia7 for complex multi-dependent record creation, FG can't account for each use case. In the past, I've recommended extracting that into a separate method that manages complex creation/persistence instead.


Shiplist in Japanese. Ship Types too long

Japanese Translation : The Kanji in the Ship List messed, the "div" is too narrow. I think it needs to be expanded (or decrease the font size). -Thanks- - Fujisuke

Some corrupted pinyin words (I think because of the masking problem) are overlapped the normal one.

ah it should've been the font size only, the overlapping words are actually the words above them being multi-line

Not only Japanese Translation but also the Chinese Translation(both Simplified Chinese& Traditional　Chinese).I think this problem will appear in every hieroglyphs languages...including Korean. So why not let a single line contains more characters instead of decrease the font-size? Ah...maybe shorten the  translated texts can also solve the problem. After all, two Kanji can represent too many things...:flushed:

true, our interface issues are growing, especially with localized languages and unicode characters with varying length. coincidentally, I just started a topic about re-thinking our UI options on the other thread #312, though that one is mainly for the F12 panel. This one is for the strategy room shiplist, and the columns there, admittedly are getting narrower and cramped. With the recent addition of the morale column, and without main layout not being responsive, we're moving to a dead end.
I hope we do have shorthands for ship types in other languages though, like for Japanese, instead of the 5 kanji chars, we should use the 1 or 2 shorthands found on the in-game ship thumbnails

Maximum char (kanji, pinyin, hangul etc.) for here should be 3. :ok:

ah if it's 3 then we can support that as well since english also is max 3

i think this should be closed?

ah yes thanks for noticing


reduce heap by interning / lazy init

This saves about 75% of the heap in ENSIME after quite a bit of memory profiling. It may increase the PermGen requirements of users on Java 6 but will reduce their overall memory consumption.
We have the ability to run with a monkey patched version of VFS, so we are not in any need of you to merge this, but it may benefit other users.
pinging @rgoers @sebbASF explicitly incase you don't check for github PRs.
Provided under the terms of the Apache 2.0 License.

+1

No interest, communication only through snail mail. Closing.

I'm sorry. Somehow I missed the email. I haven't actually been doing much on VFS recently, but others have. This really should have been brought up on the commons dev list instead of emailing individuals.


Ensure that internal state of ExternSlobrokPolicy and ExternPolicy is…

… consistent with respect to transport, supervisor, and mirror.
@vekterli PR

Merging early as there is a race condition that will be fixed by #21351 which depends on this one.


passthrough query input string

Summary

We'd like to send the query string directly to our backend, not the "parsed graphql definition" (not sure the terminology). We have a hacky patch workaround for this, but it seems like something appropriate for other users of this lib as well.
example:
const query = graphql(`
  query MyThing {
    id
  }
`);

const res = await requestDataFromBackend(query.input);

Question: i'm not currenctly using fragments, but it probably also makes sense to passhrough them as well?
Set of changes

passthrough the query input string

This is pretty non-standard and the canonical way of doing this is to simply print the query. Can you explain why you would need to do this? We really haven't come across this being necessary (and we've basically been working on urql for a while, and it's not really an issue)

This is pretty non-standard and the canonical way of doing this is to simply print the query

Sorry I don't understand. Isn't the standard in the graphql world to send the query string to your backend?
Also, what does print the query mean?

it may make more sense for you to extend/wrap the graphql function, i.e. the initGraphQLTada returned function.

That's what we're doing now :) but I figure other people are also using gql.tada just for the type inference, and only accept graphql query strings on their backend.

You use print from graphql.js (or @0no-co/graphql.web if you want a smaller alternative that gql.tada/urql are already using) and that gives you the GraphQL document in its printed, stringified form from the AST.
Most GraphQL clients will do this for you out of the box though, of course

You use print from graphql.js (or @0no-co/graphql.web if you want a smaller alternative that gql.tada/urql are already using) and that gives you the GraphQL document in its printed, stringified form from the AST.
Most GraphQL clients will do this for you out of the box though, of course

I see your point, it would be more correct to stringify the AST. I'll close this PR


[TODO] Remove the retry code from rest client

https://gerrit.openbmc-project.xyz/#/c/3873/

Retry initialize OpenBMC request
Currently known issue openbmc/openbmc#1367
Reference openbmc/openbmc-test-automation#526

In all good practice, automation tends to break easily in certain cases where the NW plays role to connect remotely. Will continue to keep, doesn't have functional impacts


[Feature Request] Prettier error pages

AFAIK this is using Backpack CRUD's default error pages. Which look like CoreUIv2.
Since Tabler has error pages that are pretty nice, we should have this theme show prettier error pages.

PRs open here; https://github.com/Laravel-Backpack/theme-coreuiv4/pull/47 and here; https://github.com/Laravel-Backpack/theme-coreuiv2/pull/31


Any idea how to run tests in debug mode using this plugin?

First, thanks so much for the plugin...do you know how it could be tweaked to run the tests in debug mode?
Thanks!

This plugin just a temp solution before official Vitest support from WebStorm. I think JetBrains people will do this job, and they know Vitest is great framework. For Vitest support in WebStorm, please vote here: https://youtrack.jetbrains.com/issue/WEB-54437
I don't want to waste lots of time on temporary plugin, and JetBrains team will take over this job :)


Unable to insert UTF-8 character with fast_executemany option

I am trying to copy data from one SQL Server instance to another using pyODBC package and I encountered an error while handling UTF-8 characters on Windows.
I have narrowed it down to this snippet, which fails for me:
import pyodbc
import sys
print('system:' + str(sys.getwindowsversion()))
print('python:' + sys.version)
print('pyodbc:' + pyodbc.version)
cnxn = pyodbc.connect(
    r'''Driver=ODBC Driver 17 for SQL Server;Server=localhost;'''
    r'''Database=DB_Pros;port=1433;Trusted_Connection=yes'''
    )
crsr = cnxn.cursor()
crsr.fast_executemany=True

crsr.execute("""DROP TABLE IF EXISTS dbo.testing_table""")
crsr.execute("""CREATE TABLE dbo.testing_table (col1 nvarchar(max) null)""")
crsr.executemany("""INSERT INTO dbo.testing_table (col1) VALUES (?)""", [[' 🎥 ',]])

return_value = crsr.execute("SELECT * FROM dbo.testing_table").fetchone()

print(return_value )

crsr.close()
cnxn.close()

I get the following error:
system:sys.getwindowsversion(major=10, minor=0, build=18362, platform=2, service_pack='')
python:3.7.1 (default, Oct 28 2018, 08:39:03) [MSC v.1912 64 bit (AMD64)]
pyodbc:4.0.27
Traceback (most recent call last):
  File "test.py", line 15, in <module>
    crsr.executemany("""INSERT INTO dbo.testing_table (col1) VALUES (?)""", [[' 🎥 ',]])
pyodbc.DataError: ('22026', '[22026] [Microsoft][ODBC Driver 17 for SQL Server]String data, length mismatch (0) (SQLParamData)')

Everything works fine when I set the crsr.fast_executemany=False.
This seems to be somewhat related to #246 , but this happens on Windows system.

Could you post an ODBC trace?

Hi, thank you for looking into this.
Below attached is the ODBC trace, I have executed the snippet posted in the initial comment:
SQL.LOG

It looks like Python3 Unicode conversions don't really handle characters that require two UTF-16 codepoints very well, so "space", "🎥", "space" gets mangled.
I need to dig a lot deeper to see if there is a neat fix for this, but one work around is to manually escape the codepoints with a "\u" in front of each one of the pair, so in case of "🎥", which is "d83c dfa5" in UTF-16, you'd put "\ud83c\udfa5"

For me, with Python 3.7.4 under Windows 7, " \ud83c\udfa5 " doesn't seem to produce a valid string:
str2 = " \ud83c\udfa5 "
print(str2)
# UnicodeEncodeError: 'utf-8' codec can't encode characters in position 1-2: surrogates not allowed

However, " \U0001F3A5 " works fine.
str2 = " \U0001f3a5 "
print(str2)
#  🎥

Unfortunately, it isn't really a workaround because the string parameter value is the same whether it is defined using a string literal (" 🎥 ") or an escaped Unicode code point (as above).
I also notice that the example code fails if the column is declared as nvarchar(max) (which triggers DAE) but does not fail if the column is declared as nvarchar(50).

I also notice that the example code fails if the column is declared as nvarchar(max) (which triggers DAE) but does not fail if the column is declared as nvarchar(50).

Yes, I forgot to mention this in the original description - this is only an issue if you insert to nvarchar(max) column with fast_executemany flag using cursor.executemany.
However, the string " 🎥 " was originally only a part of a much longer text stored in nvarchar(max) column from which I isolated the problematic part in the snippet, so changing the datatype of the column is unfortunately not a solution.

I know what the problem is now, it's due to some confusion between number of characters and number of codepoints in conversion code. I checked in a fix that should work for this case:
https://github.com/v-makouz/pyodbc/commit/606b4a959a8531e8cf1349da0f828ee8bc2e46f0
However in the process of testing it, I discovered that when using Python2 on Windows, inserting any Unicode character in this manner doesn't work, because it doesn't do any conversion and so gives the driver the data in the source format (i.e. UTF-8), which the driver doesn't interpret correctly, as Windows itself is not set to UTF-8, so the driver treats it as 1252
So I will see what to do about that and will make a PR once I have a fix for that case as well.

I discovered that when using Python2 on Windows, inserting any Unicode character in this manner doesn't work

If @mkleehammer feels so inclined perhaps we could take this opportunity to discuss the future of Python2 support.

Thank you for your support, I have manually built pyodbc with proposed fix (https://github.com/v-makouz/pyodbc/commit/606b4a959a8531e8cf1349da0f828ee8bc2e46f0) and it seems to work flawlessly since then (on Windows 10, Python 3.7.1).

@gordthompson What are your thoughts on Python 2 support?  I'd love to stop updates for it.  I personally maintain a large code base still using Python 2 for some of the microservices, but because they are critical 24x7 services I rarely want to update the the pyodbc versions.  (They'll hopefully be ported in 12 months or so.). I'd be happy to make occasional security / crash fixes on a dedicated Python 2 branch for a couple of years.
If we take that step. we should also look at what the minimum Python 3 version should be.  I guess that would depend on which LTS OS versions are out there.

I'd be happy to make occasional security / crash fixes on a dedicated Python 2 branch for a couple of years.

In that case I would propose the following:
At the end of 2019, create a pyodbc4 branch. The master branch will then be for v5 (and beyond) and will be for Python_3(+) only. Probably no need to do a massive cleanup to remove all Python_2 code from master; as other changes are made to a particular source file just remove the Python_2-specific stuff at the same time. Eventually the Python_2 remnants will disappear.

If we take that step. we should also look at what the minimum Python 3 version should be. I guess that would depend on which LTS OS versions are out there.

My personal preference would be for 3.6+, but I notice that Ubuntu 16.04 LTS still distributes 3.5. Ubuntu 16.04 is on Standard Support until April 2021 (and EOL three years later) so it will be around for a while. So, we might have to go with Python_3.5+, at least for the time being.

I know what the problem is now, it's due to some confusion between number of characters and number of codepoints in conversion code. I checked in a fix that should work for this case:
v-makouz@606b4a9
However in the process of testing it, I discovered that when using Python2 on Windows, inserting any Unicode character in this manner doesn't work, because it doesn't do any conversion and so gives the driver the data in the source format (i.e. UTF-8), which the driver doesn't interpret correctly, as Windows itself is not set to UTF-8, so the driver treats it as 1252
So I will see what to do about that and will make a PR once I have a fix for that case as well.

Does this fix enable high unicode chars for inserts that don't use parameterized queries?
E.g.
cnxn.execute("""INSERT INTO dbo.testing_table (col1) VALUES (N'🎥')""")
instead of
cnxn.execute("""INSERT INTO dbo.testing_table (col1) VALUES (?)""", [[' 🎥 ',]])

@timnyborg - Inserts using N'...' literals already work with supplementary characters. Do you have an example of a case where they don't?

Well, while the parameterized method works on my stack (Python 3.7, MSSQL, Pyodbc 4.0.27, FreeTDS 1.00.40), the literals cause a sql syntax error.  Perhaps it's a separate issue from the interaction with FreeTDS?
cnxn = pyodbc.connect(...)
res = cnxn.execute("update person set surname = ? where id = 1", '🎥') # Works
res = cnxn.execute("update person set surname = N'🎥' where id = 1")

pyodbc.ProgrammingError: ('42000', "[42000] [FreeTDS][SQL Server]Unclosed quotation mark
after the character string ''. (105) (SQLExecDirectW)")

Try the Microsoft ODBC Driver for SQL Server instead: https://docs.microsoft.com/en-us/sql/connect/odbc/microsoft-odbc-driver-for-sql-server

Yep, works with the Microsoft drivers (didn't even know they were available!)
However, needed to implement an OpenSSL fix on Debian 10 to get around error 0x2746:
https://github.com/microsoft/msphpsql/issues/1021#issuecomment-520943561
Thanks, all.

Is the fix for this problem (parameters not literals) currently scheduled for any release?
In the interim is there a workaround, a way of 'pre-treating' the strings to bypass the error?  The closest I can get is val.encode('unicode-escape').decode('utf-8') anything going to nvarchar(max), but then they look pretty bad because it encodes even unicode chars below 256, such as common western language accented vowels.
I load/reload a lot of data daily, many millions of rows, so I need fast_executemany.  I just swapped out turbodbc, because it has its own problems with unicode strings longer than 1600 chars, and now I have hit this issue.
Any advice is appreciated, thanks.

Well, it's not pretty but it works:
re_multipoint_unicode = re.compile(f'[{chr(0x100)}-{chr(0x10FFFF)}]+')
bad_str = chr(0xFF) + chr(0x1F609)
good_str = re_multipoint_unicode.sub(lambda v: codecs.decode(codecs.unicode_escape_encode(v.group())[0]), bad_str)

If there is a better way, and there probably is, please let me know...
Thanks


Enabling federation of the API type StorageClass not working.

DESCRIPTION:-
Enabling federation of the API type StorageClass not working.
STEPS:-

Enable federation for the API type StorageClass
ubuntu@ip-172-23-1-87:~/trident-installer$ kubefedctl enable storageclass
customresourcedefinition.apiextensions.k8s.io/federatedstorageclasses.types.kubefed.io created
federatedtypeconfig.core.kubefed.io/storageclasses.storage.k8s.io created in namespace kube-federation-system

Verifying API type is installed on all member clusters
ubuntu@ip-172-23-1-87:~/trident-installer$ for c in ${CLUSTER_CONTEXTS}; do     echo ----- ${c} -----;   kubectl --context=${c} api-resources --api-group=types.kubefed.io; done
----- kubernetes-admin-s1 -----
NAME                              SHORTNAMES   APIGROUP           NAMESPACED   KIND
federatedclusterroles                          types.kubefed.io   false        FederatedClusterRole
federatedconfigmaps               fcm          types.kubefed.io   true         FederatedConfigMap
federateddeployments              fdeploy      types.kubefed.io   true         FederatedDeployment
federatedingresses                fing         types.kubefed.io   true         FederatedIngress
federatedjobs                                  types.kubefed.io   true         FederatedJob
federatednamespaces               fns          types.kubefed.io   true         FederatedNamespace
federatedpersistentvolumeclaims   fpvc         types.kubefed.io   true         FederatedPersistentVolum               eClaim
federatedpersistentvolumes        fpv          types.kubefed.io   false        FederatedPersistentVolum               e
federatedreplicasets              frs          types.kubefed.io   true         FederatedReplicaSet
federatedsecrets                               types.kubefed.io   true         FederatedSecret
federatedserviceaccounts          fsa          types.kubefed.io   true         FederatedServiceAccount
federatedservices                 fsvc         types.kubefed.io   true         FederatedService
federatedstorageclasses           fsc          types.kubefed.io   false        FederatedStorageClass
----- kubernetes-admin-s2 -----
NAME                              SHORTNAMES   APIGROUP           NAMESPACED   KIND
federatedclusterroles                          types.kubefed.io   false        FederatedClusterRole
federatedconfigmaps               fcm          types.kubefed.io   true         FederatedConfigMap
federateddeployments              fdeploy      types.kubefed.io   true         FederatedDeployment
federatedingresses                fing         types.kubefed.io   true         FederatedIngress
federatedjobs                                  types.kubefed.io   true         FederatedJob
federatednamespaces               fns          types.kubefed.io   true         FederatedNamespace
federatedpersistentvolumeclaims   fpvc         types.kubefed.io   true         FederatedPersistentVolum               eClaim
federatedpersistentvolumes        fpv          types.kubefed.io   false        FederatedPersistentVolum               e
federatedreplicasets              frs          types.kubefed.io   true         FederatedReplicaSet
federatedsecrets                               types.kubefed.io   true         FederatedSecret
federatedserviceaccounts          fsa          types.kubefed.io   true         FederatedServiceAccount
federatedservices                 fsvc         types.kubefed.io   true         FederatedService
federatedstorageclasses           fsc          types.kubefed.io   false        FederatedStorageClass

Create a StorageClass
apiVersion: types.kubefed.io/v1beta1
kind: FederatedStorageClass
metadata:
name: local
spec:
template:
provisioner: csi.trident.netapp.io
reclaimPolicy: Retain
allowVolumeExpansion: true
placement:
clusters:
- name: netlg0y6s7
- name: netnbto2q2

But now local storage classes are not created
ubuntu@ip-172-23-1-87:trident-installer$ kubectl --context kubernetes-admin-s1 get sc
NAME            PROVISIONER             AGE
default         kubernetes.io/aws-ebs   2d2h
gp2 (default)   kubernetes.io/aws-ebs   2d2h
ubuntu@ip-172-23-1-87:trident-installer$ kubectl --context kubernetes-admin-s2 get sc
NAME            PROVISIONER             AGE
default         kubernetes.io/aws-ebs   2d2h
gp2 (default)   kubernetes.io/aws-ebs   2d2h

We are able to list the fsc on the first cluster but not  the second

ubuntu@ip-172-23-1-87:trident-installer$ kubectl --context kubernetes-admin-s1 get fsc
NAME    AGE
local   41m
ubuntu@ip-172-23-1-87:trident-installer$ kubectl --context kubernetes-admin-s2 get fsc
No resources found.
What happened:
local storage class was not created
What you expected to happen:
local storage classes on both the federated clusters should be created.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
Kubernetes version (use kubectl version)
ubuntu@ip-172-23-1-146:~$ kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:05:50Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

KubeFed version
v2 -version=0.1.0-rc6

Scope of installation (namespaced or cluster)
cluster

Others

/kind bug

Federated resources are input for federated controllers, so for normal use of KubeFed they only need to exist on the host cluster rather than all clusters.
I recommend checking the propagation status of a federated CR if it is not propagating as expected.
If propagation status is not conclusive, I recommend:

Checking the status of member clusters

If an error condition exists, more detail will appear in the controller log

Check the status of the CRD

If propagation status, cluster status and CRD status prove inconclusive, I recommend checking the logs for the kubefed controller

Thank you for the response. When i do a describe on the FederatedStorageClass i get the following details. It looks like  propagation status is true. but i dont see local storage classes being created.
ubuntu@ip-172-23-1-87:~$ kubectl describe fsc local
Name:         local
Namespace:
Labels:
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
{"apiVersion":"types.kubefed.io/v1beta1","kind":"FederatedStorageClass","metadata":{"annotations":{},"name":"local"},"spec":{"template":{"...
API Version:  types.kubefed.io/v1beta1
Kind:         FederatedStorageClass
Metadata:
Creation Timestamp:  2019-10-30T13:39:31Z
Finalizers:
kubefed.io/sync-controller
Generation:        1
Resource Version:  295414
Self Link:         /apis/types.kubefed.io/v1beta1/federatedstorageclasses/local
UID:               490430a0-ca8c-4901-acc3-faa5ec144fd2
Spec:
Template:
Allow Volume Expansion:  true
Placement:
Clusters:
Name:        netlg0y6s7
Name:        netnbto2q2
Provisioner:     csi.trident.netapp.io
Reclaim Policy:  Retain
Status:
Conditions:
Last Transition Time:  2019-10-30T13:39:31Z
Last Update Time:      2019-10-30T13:39:31Z
Status:                True
Type:                  Propagation
Events:

@jacobjohnanda Propagation status is true, but the cluster names declared for placement do not appear in the propagation status which is an indication that the named clusters are not actually known to KubeFed. I think someone filed a bug on that issue but I can't seem to find it right now. I suggest:

checking the names of member clusters

kubectl -n kube-federation-system get kubefedclusters

consider using selector-based placement rather than hard-coding cluster names

@jacobjohnanda As per my previous comment, have you checked the controller logs?

Good afternoon,
This may not be the right place to ask, but I've been digging for information about the FederatedStorageClass type and I've been unable to find anything within this repository or even Googling about it.
I tried enabling the type on my federation and it worked, I've been able to deploy a wrongly formatted object which failed to be deployed, but the controller seems to work.
Would you be kind enough to point me to the FederatedStorageClass documentation or at least provide me it's proper schema?
Thank you for your time!

I have recently tested the federation of a storageclass and it worked without any problem.

@hectorj2f : Could you please provide the details or how this worked. i am running into some issues with netapp trident

@hectorj2f : could you please share your federatedstorageclass.yaml and federatedstoragepvc.yaml along with the POD.yaml which was using federatedstroageclass , basically i want to compare my configuration as well along with trident driver.i can share my files if needed .
can you share.


bug fix to retrieve specs on URLs with path

It looks like Pygwalker cannot read specs when the app's url is composed of a host + path. Writting seems fine though.
For example, I have an app deployed with the following URL structure:
ORIGIN/PATHNAME
This URL structure comes from corporate constraints within the company I work for.
I have taken a look at "pygwalkjer-app.iife.js", which I believe is generated by "communication.tsx", and I see this:
i=/${e}/${A}
I believe this should be updated to i=${window.parent.document.location.href}/${e}/${A}
To Reproduce
Steps to reproduce the behavior:
Deploy your Streamlit app with the following URL structure: i=/${e}/${A}
Use the following Python code
StreamlitRenderer(dataset=df, spec=PATH_TO_SPEC, spec_io_mode="rw")
Try load your Pygwalker chart
The page gets stuck on "Loading Graphic- Walker UI..."

Hi @thomasbs17 , thanks for your PR.
Here are some suggestions for this PR.

use window.location.pathname to get path name, just use the path, no need to specify host.
The source of baseUrl is: pygwalker/communications/streamlit_comm.py- BASE_URL_PATH. BASE_URL_PATH include server.baseUrlPath, window.location.pathname also included server.baseUrlPath. So you need to remove server.baseUrlPath in BASE_URL_PATH.
Since streamlit may exist multiple page applications, window.location.pathname may not be accurate enough, you can refer way of streamlit: getPossibleBaseUris, try to get multiple possible URLs, and add a ping action on the pygwalker side. use this action to test the correct api path before communicating.


Add flag to hide implied/leaf features

There are numerous places where a --verbosity style flag is noted in the source.
This should be part of that, whenever -v is implemented.
Also, there might be a conflict with -v and cargo -v whatfeatures.

Added in v0.8.0


fixed lxml errors when reading Tomcat error messages.

When parsing error messages pysolr assumes that Tomcat will send a certain flavour of invalid response.
Sometime in Tomcat 6 (or maybe Solr4) the assertion that this code was based on became untrue, and so the error handling code in pysolr began creating it's own error. This may only be true when using lxml (it's required in my project so I haven't tested without).
This fix prevents pysolr from obscuring the tomcat error message with it's own, if it fails to find the tag it's looking for.
This is what I was getting before making this fix:
File "/home/webapps/.virtualenvs/myapp/local/lib/python2.7/site-packages/pysolr.py", line 404, in _scrape_response
p_nodes = body_node.cssselect('p')
AttributeError: 'NoneType' object has no attribute 'cssselect'

What's the status of this, I'm still getting errors when trying to build an index.

@pembo13 If you can, please test the branch I referenced above – and send us some of the Tomcat error messages you're receiving so we can add them to the test suite.

This can be closed now, code no longer exists.


⚠ Bofrost.de has degraded performance

In a963248, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1698 ms

Resolved: Bofrost.de performance has improved in 297da6e after 13 minutes.


There are some inconsistencies in the API

The api is not fully consistent, some names are camelCase, other lowcase and sometimes snake_case, e.g:

valuekey
expirytime
readTimeout
batchSize
buffer_length

We should agree on a convention to follow

cc @KalmanMeth @ronensc @eranra

I thought we had an issue for this, but I can't find it

I thought we had an issue for this, but I can't find it

Ah, maybe this: https://github.com/netobserv/flowlogs-pipeline/issues/197

@jotak we thought to use camelCase like in k8s. WDYT? do you have any preference?

@jotak we thought to use camelCase like in k8s. WDYT? do you have any preference?

+1, it sounds more natural to me too

closed by #213


Enhancing Documentation for Supported Terraform Recipe Sources

What content needs to be created or modified?
Reviewing Recipes overview docs, it looks like we haven't made it explicitly easy for a new user to identify the supported sources for recipes (example: Terraform registry for Terraform and OCI compliant registries for Bicep). This information is currently mentioned under https://docs.radapp.io/guides/recipes/howto-author-recipes/, but it doesn't explicitly indicate that other sources aren't supported.
Describe the solution you'd like
Where should the new material be placed?
To enhance clarity, I suggest extending this table at Support for multiple IaC languages section, to include supported recipe sources.
Doing this will allow users to quickly identify the sources that are supported, improving the overall user experience when onboarding to recipes.
AB#10027

Closing, change merged.


Allow channel negotiation to subscription service

Solid Notifications should allow a subscription request with multiple channels (with priority indicated, say, by q values), such that a service can return a preferred notification channel based on its capabilities.

We discussed it and decided that since this practically works as Reactive Negotiation, the client will know exactly what the server supports and can make a subscription request that the server will support.

Primarily not for that purpose! This allows a client to indicate a preference between two available channel options (to provide a better degradation of service when a server is unable to temporarily create the preferred channel)!
Though it could also be the case (unlikely, not impossible) that a subscription service is communicated out of band by a trusted source. That could turn it into a proactive negotiation like scenario!

I'm afraid that I don't understand the scenario. Could you please exemplify it with a few simple snippets?

Imagine a case that you, the client, requests a WebSocket2023 channel (which is advertised by the description resource), but the subscription service cannot recreate it because behind the scenes WebSocket channel provider is unable to manage a temporarily high demand. So now, instead, you will make a second request for a HTTPStreaming channel. That preference can potentially be combined into one request!
Snippets wise, it will be an array of objects instead of one object, with an extra 'q' property!

Why not just return []( from the initial subscription request and let the subscription client

Sure, where is the fun in that? Why deny service if we can send them an alternate service in the same request?!!

We should not add complexity to the spec to avoid an extra HTTP request for cases where a part of the subscription service becomes temporarily unavailable. As I understand your proposal, it only works where the same subscription service supports multiple channel types; in that case, the subscription client would even make the follow-up request over the same connection, assuming HTTP/2.

Why I propose this extra complexity is that this would make it identical to the HTTP header negotiation case!

The situation here is different since the discovery client has already obtained subscription services capabilities.
Would you like to create a PR that includes all the normative requirements to evaluate added complexity better? This way, we can better assess the expected impact on implementations.


string package pulls all datasets

Description
This is not a bug per se, but something worth fixing nonetheless.
@stdlib/string depends on @stdlib/datasets (~150MB) only to use @stdlib/datasets/stopwords-en (<100kB).
Related Issues
No response
Questions
Side node: should @stdlib/datasets even exist as a single package?
Demo
No response
Reproduction
No response
Expected Results
No response
Actual Results
No response
Version
No response
Environments
Node.js
Browser Version
No response
Node.js / npm Version
No response
Platform
No response
Checklist

[X] Read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.

Ad 1.

This has the downside that, upon installing @stdlib/stdlib, users would then have duplication of datasets as @stdlib/datasets-foo would be installed alongside @stdlib/datasets/foo. Duplication bloat could become significant depending on how @stdlib/datasets/* are used throughout the project in the future.

This duplication is happening already. If I install @stdlib/string and some other package depends on @stdlib/string-acronym, I end up with @stdlib/datasets and @stdlib/datasets-stopwords-en.
Which is partly why I asked whether @stdlib/datasets should even exist as a single monster package. It's a random collection of stuff that's never going to be needed whole. And it just duplicates all the datasets it's comprised of.
Ad 2. agreed, that doesn't seem viable.

If you want to avoid installing all of @stdlib/datasets, I'd recommend just installing those individual @stdlib/string-* packages you actually need (e.g., @stdlib/string-camelcase, etc). In turn, this should only install those datasets packages which are actually used, not the entire top-level namespace.

That sounds like the wrong trade-off. The convenience of having @stdlib/string as a single package providing various operations on strings, greatly outweighs the convenience of stdlib/datasets as a single package containing an assortment of data from Napoleon wars, through Boston house prices, to monochrome photos of a :cat:

Re: 1. Yeah, that is a fair point where a user has in their package tree both @stdlib/string and, say, @stdlib/string-*. I suppose our intuition is that the consumption distribution is mainly trimodal, with one mode being @stdlib/stdlib, the second being top-level namespaces, and the third being individual packages. As soon as consumption patterns overlap, we're kind of stuck in a sub-optimal minima, where no one solution is optimal. If we actually controlled the package tree ala npm, we could probably figure out an optimum tree, but alas!
In general, I agree that we should consider whether there is a way to achieve some sort of happy medium for the mixed mode case, but I am not terribly optimistic. 😞
@Planeshifter may have other ideas. 🙏

@Planeshifter Looks like in @stdlib/string/*, the only package which explicitly depends on a dataset is @stdlib/string/acronym, which defaults to using English stopwords. We could just default to an empty array. This would alleviate the issue of @stdlib/string depending on @stdlib/datasets.
This would be somewhat akin to @stdlib/string/remove-words where we don’t default to any list of particular words to remove.

This has now been addressed in https://github.com/stdlib-js/stdlib/commit/d96a0da70fcca6f13fdb2c87a9cef1a751c6b545. Thanks, @Planeshifter!

Closing as the change is incorporated in the latest release of the @stdlib/string package.


support whatsapp phone verification too

Looking at https://www.twilio.com/docs/verify/whatsapp
Supporting phone verification by whatsapp is just changing from 'sms' to 'whatsapp'

I have this fork tested in production for months now. it's working if it helps


Hot reloading on the server

To test a change on the server, it is currently required to restart the whole application. This can take some seconds/ minutes and is therefore really interruption the developer experience.
We should find a way to at least provide simple hot reloading on the server.
One option would be, before every new request to the main middleware, clear the complete require/ parcel cache for those modules.
Note: This might require a change for the way we require the application, as this is currently passed before the middleware is started.

In https://github.com/garthenweb/pexo/commit/041dac7020392ed0fe13693d691b3464fdecd377 we introduced reloading of the server on changes using nodemon. This issue is still valid as the overhead of restarting the whole process can be annoying, especially for bigger applications.


Eslint: Support TypeScript

Now that we're starting to use more TypeScript files as a replacement for Flow, we should make sure eslint works with TypeScript files (.ts and .tsx).
The typescript-eslint library might be a great starting point. I believe this would replace the @babel/eslint-parser we're currently using. It recommends using a flat config instead of the legacy eslint config we have in the app at the moment.
ExploreContext.tsx is a good file to check to make sure our custom eslint rules are applied, since there are currently a few lines over 100 characters in that file that should be linted.

Closed in PR https://github.com/inaturalist/iNaturalistReactNative/pull/1413


feat: allow to use an existing sharp layer via arn

Fixes #80

Thanks! I don't mind merging this but heads up I am hoping to integrate open-next which provides an already-packaged arm64 image lambda handler - https://github.com/jetbridge/cdk-nextjs/pull/95


fix the column merging during graph traversal and concat selector

This PR fixes graph traversal column merging. This is to allow for retreival of root columns and support overlapping column usage. The new behavior is to return whatever the last node of the graph is requiring for a target column. We also fixed the concat column op selector computation logic. Parents + dependencies were overriding input schema columns unnecessarily. That is only required when propagating column groups.

It looks like this change breaks a few tests in NVTabular that probably actually are related to this change


Hi

Hello guys, I just send you a E-Mail for some questions... I very liked how you make a real minecraft for Android. But i just have a question... How this is possible? If you can with minecraft, does it possible with an other game, like The Elder Scrolls : oblivion? because on my nvidia shield I play Boardwalk at 20 fps. I really think that other game can be play at 50-60 fps. Can you just respond my E-Mail with all the answer please?
A big tanks, nice work :+1:

Minecraft is in Java, which Android supports, and someone already wrote a compatibility layer for OpenGL (the graphics layer it uses) to OpenGL ES (what Android supports), so this was relatively easy.
Oblivion is compiled to native x86 code; translating that to the ARM processor used on the Shield would be difficult. (It's possible: Intel does the reverse (ARM to x86) for their Atom tablets, but unfortunately I'm not Intel and don't have a gazillion dollars)

If you want a device that can play Oblivion, try getting one of the cheap Windows tablets, such as the Stream 7 - they run full Windows and might run games at an acceptable speed.

You very help me, thanks fort the information, I will try and and let you news...
Le 4 avr. 2015 01:23, zhuowei<EMAIL_ADDRESS>a écrit :
If you want a device that can play Oblivion, try getting one of the cheap Windows tablets, such as the Stream 7 - they run full Windows and might run games at an acceptable speed.

Reply to this email directly or view it on GitHub:
https://github.com/zhuowei/Boardwalk/issues/164#issuecomment-89507113


[New Rule](Jetpack compose and more)

Library name / 库名称
androidx.compose
Library label / 库标签
Jetpack Compose
Library team / 库的开发团队
Google
Library group / 库组
No response
Library icon / 库图标
https://tabris.com/wp-content/uploads/2021/06/jetpack-compose-icon_RGB.png
Library description / 库描述
Jetpack Compose is Android’s modern toolkit for building native UI. It simplifies and accelerates UI development on Android. Quickly bring your app to life with less code, powerful tools, and intuitive Kotlin APIs.
Library relative URL
https://developer.android.com/jetpack/compose

And more jetpack libs below:


DAG error

What happened/what you expected to happen?
unable to evaluate expression '(0e62948f_e887_4daf_b5cb_10c1e74a61ea.Succeeded || 0e62948f_e887_4daf_b5cb_10c1e74a61ea.Skipped || 0e62948f_e887_4daf_b5cb_10c1e74a61ea.Daemoned)': bad number syntax: "0e62948f" (1:10)
| (0e62948f_e887_4daf_b5cb_10c1e74a61ea.Succeeded || 0e62948f_e887_4daf_b5cb_10c1e74a61ea.Skipped || 0e62948f_e887_4daf_b5cb_10c1e74a61ea.Daemoned)
| .........^
What version are you running?
v2.12.2

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

We are not supporting v2.12..x Please upgrade to 3.2.x


Error downloading dataset

When downloading the Ego4d dataset using the command "ego4d --output_directory=”~/ego4d_data"--datasets omnivore_video_swinl --metadata" as mentioned in the README.md file of the Ego4d GitHub repository, you encountered an error after downloading 27.pt files. The error message displayed is "botocore.exceptions.ConnectionClosedError: Connection was closed before we received a valid response from endpoint URL: 'https://ego4d-iiith.s3.ap-south-1.amazonaws.com/'".

+1

+1

I have same quention, Have you solved it？

I have not, but I think the problem may because of GFW.

Have you solved it?

Closing this issue for now. Please feel free to re-open it if the problem still persists.


Simplify styled-components support

Is your feature request related to a problem? Please describe.
Now, to support styled-components, we save to disk content of generated CSS. However, the generated CSS is in the document.head already. So we should use content from document.head, instead of re-generating CSS
Describe the solution you'd like

Remove the code to generate and save styled-components's CSS to disk.
Use document.head instead.

Describe how should jest-preview implements this feature
Update debug function

Does that mean the styled-component's style will be handled out of the box ?
Currently when I run jest-preview I am just seeing the HTM without any style displayed

@alexis-regnaud yes. styled-components should work out of the box with Jest Preview. This issue is just an improvement to an existing implementation.
Can you provide a reproducible repository, I would love to help you debug. Also, can you create another issue?

@alexis-regnaud This issue is going to be closed. Feel free to open a new issue if you still have an issue with styled-components.
If you are seeing HTML without any style, consider taking a look at I can see HTML on my browser, but without any CSS
 in FAQ.


Query Tokens for PasswordProtection

Readiness checklist

[ ] I added/updated tests.
[ ] I ensured that the PR title is good enough for the changelog.
[ ] I labeled the PR.
[ ] I self-reviewed the PR.

Has been replaced by https://github.com/nmshd/runtime/pull/362.


Add a new constructor which accepts RsaPrivateKeyStructure

This commit adds a new constructor which allows to create an instance of
RsaPrivateCrtKeyParameters directly from a RsaPrivateKeyStructure,
rather then building it manually.

Merged, thanks for the PR. (Takes a few days to appear here though).