add new APIs

Docs for new APIscan hits
@dotnet/dotnet-wcf for System.ServiceModel
@davidsh for System.Net
Internal review links:

https://review.docs.microsoft.com/en-us/dotnet/framework/additional-apis/system.net.rtcstate?branch=pr-en-us-15651
https://review.docs.microsoft.com/en-us/dotnet/framework/additional-apis/system.servicemodel.channels.message.bodytostring?branch=pr-en-us-15651
https://review.docs.microsoft.com/en-us/dotnet/framework/additional-apis/system.servicemodel.channels.message.writestartheaders?branch=pr-en-us-15651

Adding @HongGit

Can you explain why these api's are being added to documentation as they are internal?

APIscan @mconnew. Are you familiar with that? Otherwise, I can send you some info offline.

@mairaw can you please share the info with me?  I am also interested in this topic.

@mairaw, can you please send me the info offline.

Yes @HongGit. I'm not merging this until I get a clear resolution on our internal thread.


Merge konami code and hitchhikers guide

Another easter egg was added that broke the konami code, the original event listener had been removed.
Merging the two easter eggs under the same event listener so they work together. This is serious stuff, we can't have any bugs here!

Great work! I agree no bugs allowed I should probably put that in the contribution rules ;)


cannot setup preload in website

Hi Sir,
I'm tried many time but cannot successful the preload setting. Pls advice, any video can refer?

it seems there's an unclosed tag (missing >) before the preload links, like:
<meta name="foobar" content="bazquux"
<link rel="preconnect" href="...">


mypy reporting incorrect shape of parent class dict when using pydantic plugin

Bug
Encountered with pydantic 1.5.1 (latest) and mypy 0.770 (latest) with the pdantic plugin enabeld.
Code to reproduce:
import pydantic

class Parent(pydantic.BaseModel):
  a: int = 1

class Child(Parent):
  b: int = 2

# mypy flags error: "Child" gets multiple values for keyword argument "b"
Child(**Parent().dict(), b=3)

This has nothing to do with the mypy pydantic plugin (other than that mypy now knows what fields __init__ takes)
You get the same error with
import pydantic

class Parent(pydantic.BaseModel):
    a: int = 1

class Child(Parent):
    b: int = 2

def foo(*, a: int, b: int) -> None:
    pass

foo(**Parent().dict(), b=3)

without the mypy pydantic plugin enabled.
AFAIK this is how how mypy is, it doesn't know anything about the dictionary returned by .dict() so it assumes the worst - e.g. that it might include a key 'b'.
It might be possible to extend the the mypy plugin to customise what mypy assumes .dict() returns to be a TypedDict - if you're interested in working on that I'd happily review a PR.

@Code0x58
Did you try this?
Child(b=3, **Parent().dict())

Makes mypy happy for me!


Feat/create tooltip component

Purpose
The Tooltip component is a reusable component used in various area of the application, such as share data payment (step 5).
Testing from home page
update the home.tsx file as follow:
import { type FC } from 'react'
import { Community } from './community/community'
import { Interact } from './interact/interact'
import { Explore } from './explore/explore'
import './home.scss'
import './i18n/index'
import { Tooltip } from '@/ui/component/tooltip/tooltip'
import { Icon } from '@/ui/component/icon/icon'
import { useAppStore } from '@/ui/store'

export const Home: FC = () => {
  const theme = useAppStore(store => store.theme)

  return (

        <Community />

        <Explore />

        <Interact />

      <Tooltip
        content={

              This fee consists only of gas fees. This is an estimation based on the current network
              conditions and the complexity of the transaction. Please note: The gas fee ensures
              your transaction gets processed on the blockchain network. If the actual gas fees
              required exceed the estimated amount, the transaction will be declined. Otherwise, it
              will be validated. You will only be charged for the exact gas fees spent during the
              transaction. Additionally, the maximum processing time for a new block is 10 seconds.
              Your transaction will be included in an available block based on the gas price you
              choose. Make sure to review the gas price carefully to optimize transaction speed and
              costs.

        }
        contentClassName="my-custom-class-name"
        trigger={<Icon name={`info-outlined-${theme}`} />}
      />

  )
}

Overview from Figma

Thanks for your testing code!
Unfortunately, even if I set the .my-custom-class-name {       width: 100px;     } on home.css, the width is still the same as origin. Is it normal ? Look like we can't set the container 😊

Unfortunately, even if I set the .my-custom-class-name { width: 100px; } on home.css, the width is still the same as origin. Is it normal ? Look like we can't set the container 😊

@Yoj16 thank you for your feedback!
The component updates dynamically the width of the content using custom properties:

Thus it takes precedence on the width defined in my-custom-classname:

However you can rely on max-width property to limit the tooltip to the size you want, that takes precedence on any width property.

I think it's not user friendly that the users's width set in the content className isn't applied because of the radix priority.

@lolottetheclash thanks for your feedback.
In order to improve component usage, tooltip content CSS class has been updated, by replacing width by max-width. Thus, user can define a width from contentClassName, that overrides dynamic width provided by Radix CSS custom property, --radix-tooltip-content-available-width.
Also, a width props has been added to the component props, providing another level of customization.
Hope these changes are sufficient to provide enough flexibility and make this component easier to customize.


Add implementation details for AddLabCommand as well as updating Model.

Codecov Report

Merging #121 (691fc44) into master (2bd7c91) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #121      +/-   ##
============================================
+ Coverage     76.14%   76.18%   +0.03%
- Complexity      670      673       +3
============================================
  Files           100      100
  Lines          1924     1927       +3
  Branches        202      202
============================================
+ Hits           1465     1468       +3
  Misses          402      402
  Partials         57       57

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...va/seedu/address/logic/commands/AddLabCommand.java
93.33% <100.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
94.87% <100.00%> (+0.13%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
100.00% <100.00%> (ø)

...seedu/address/model/student/UniqueStudentList.java
93.75% <100.00%> (+0.13%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


IsoTpParallelQuery: handle response pending

To fix an issue with https://github.com/commaai/openpilot/pull/24706, we don't consider response pending responses, so we would break before some queries finish if our queries complete fast enough

Tracks timeouts per address
Per discussion with Greg, we've seen some VW ECUs take up to 6 seconds between response pending responses, so choose timeout of 10 seconds for addresses with a response pending.
Continually receiving response pending from an ECU is rare, so raise max timeout to 1 minute
Every time an ecu responds with response pending, wait additional 10 seconds for response, then set timeout to default 0.1 seconds on valid response, and the next loop we'll break if we've gotten everything

Implementation done in panda for UdsClient, brought over for fw fingerprinting https://github.com/commaai/panda/pull/723

Do you know why we do https://github.com/commaai/openpilot/blob/master/selfdrive/car/fw_versions.py#L335? Can we remove it?

Think the first iteration you have a larger batch? Remember adding that to make toyota more reliable.

I see, looks like these are the number of addresses in the batches: [5, 7, 7, 13, 6, 6, 6, 5, 5, 6, 6, 6, 6, 2, 1, 1, 1, 1, 1, 1]

Ah ok, maybe other changes were made in the meantime that make this no longer relevant. If it works fine on Toyota you can remove it.

If we keep as a safety net I'm fine with that, once everything completes we break anyway

Per discussion with Greg, we've seen some VW ECUs take up to 6 seconds between response pending responses, so choose timeout of 10 seconds for addresses with a response pending.
Continually receiving response pending from an ECU is rare, so raise max timeout to 1 minute
Every time an ecu responds with response pending, wait additional 10 seconds for response, then set timeout to default 0.1 seconds on valid response, and the next loop we'll break if we've gotten everything

I can't remember how long our worst-case response to a query was (there were some long ones but not fingerprint-relevant). However, IIRC the timer was set to 6 seconds because the relevant ISO UDS standard calls for a module to repeat its 0x7fXX78 please-wait response every 5 seconds until it's ready to answer. So 10 seconds is exceedingly generous.

@gregjhogan what do you think? Is 6 seconds good instead of 10?

On an Optima:
Before:
Took 0.5304740789997595 seconds to get FW versions
Took 0.5206602079997538 seconds to get FW versions
Took 0.5308695399999124 seconds to get FW versions

After:
Took 0.5307171469999048 seconds to get FW versions
Took 0.5316702539998914 seconds to get FW versions
Took 0.5306270969999787 seconds to get FW versions
Took 0.5386053260003791 seconds to get FW versions

Notes from past PRs related to this PR ...
UDS timeouts: https://github.com/commaai/panda/pull/699#issuecomment-887996563
indication that an ECU needed more than a 5 second timeout after response pending: https://github.com/commaai/panda/pull/699#issuecomment-887678067
So it seems like we need something higher than a 5 second response pending timeout.  The problem with going to short is the responses might get mixed up.  I am not sure how to determine if 6 seconds is sufficient because so few ECUs use response pending for firmware queries.  The only place I have personally seen it is when you ask an ECU to erase flash or compute a checksum on the firmware.

Also, if the only ECUs using response pending are things openpilot does not directly interface with for driving (e.g. airbags) maybe we should eliminate these from firmware querying.

I want to keep it for the time being. Without it, I lose some insurance that I can discriminate between similar models.
My first and best discriminator between models is the last part of three-part EPS query, the steering characteristic map identifier returned from 0xF182 APPLICATION_DATA_IDENTIFICATION. But, the blessing and curse of VW MQB is they're all so similar, and almost everything else ends up being shareable between models with differing mass and wheelbase.
I added the airbag config data because I wanted extra insurance, something else that varied with different model/chassis dynamics, different mass and wheelbase combinations. I was worried about hanging my hat exclusively on the EPS map, and getting in trouble later after we'd upstreamed a bunch of models already, when it would be much harder to fix. In fact, this has now happened (#23735).
What I really wanted was the ABS/ESP firmware, but I couldn't make it work back in the day because (drumroll!) this same problem where it returned a delayed response. Now that the parallel query is fixed, and especially now with whitelisting to tailor specialized queries to individual modules, I'd transition away from SRS if it were easy. But making that switch today would be Kind of a Big Deal, and it wouldn't let us sidestep handling of delayed responses. I do think it's worth doing someday.

@jyoung8607 can you time this branch before and after for the FW queries?

Did five test runs of each variant with full output on my side to make sure all FW returned, followed by another five stripped down to just the timing output.
TL;DR: new timeout code doesn't hurt, whitelisting helps, and my SRS doesn't take very long to reply.
procedure:
comma@tici:/data$ cat time-fp.sh
#!/bin/bash

for i in {1..5}
do
  /data/openpilot/selfdrive/car/fw_versions.py 2>/dev/null | grep "Possible matches\|Getting fw took"
done

master:
comma@tici:/data$ ./time-fp.sh
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.889 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.901 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.921 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.919 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.935 s

isotp-parallel-response-pending:
comma@tici:/data/openpilot$ ../time-fp.sh
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.898 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.907 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.920 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.909 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.923 s

isotp-parallel-response-pending + whitelists from #24706:
comma@tici:/data/openpilot$ ../time-fp.sh
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.486 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.499 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.483 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.487 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 3.501 s

isotp-parallel-response-pending + whitelists from #24706 + stripped to VW queries only:
comma@tici:/data/openpilot$ ../time-fp.sh
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 0.240 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 0.250 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 0.261 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 0.257 s
Possible matches: {'VOLKSWAGEN GOLF 7TH GEN'}
Getting fw took 0.273 s

indication that an ECU needed more than a 5 second timeout after response pending: commaai/panda#699 (comment)

That only happens with one non-standard undocumented UDS data identifier from my Telematics module, that returns something absurdly long after a delay. I think it could be GPS or cell network info. Not really something openpilot needs to handle, and retesting right now it's only taking about 3-4 seconds anyway.
There's no harm in a longer timeout, chances of the conversation breaking down after a successful interim response are fairly low, was just highlighting the thought processes behind 5 vs 6 vs 10 seconds.
ISO-TP: RESPONSE - 0x7d1 0x22f15b0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000040001beb0001000040001beb032c70000000000000000001000000000000000000000000000000000000000040001be90000000040001beb00007000000000000000000100000000000f00004000426c400042304000431400120000400043c0400043204000445000930000400048c040004460400054ac00060000400055a8400054c8400055a800080000400055ec400055c8400056c4000a0000400057b4400056e84000594c001a000040005ea04000599040007e44000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001a54588b00130450361614010a0000000000000000000001c700a98a2d01c700b67ac100e286000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008003e300000000000000000000000000000000000000000000000000000000000003e30000000000000000000000000000000000000000000000000000000000000002080404000021044401190400005caa0000086868686863656862626808

I'm fine with 10 seconds, this look good @gregjhogan?


⚠ ClamAV has degraded performance

In 4e376b0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in a436e60 after 33 minutes.


Check modules that implement Checkable

If a module class implements fr.inra.maiage.bibliome.util.Checkable, then it must be checked before the processing is launched.

d6703ddcdd5f624872282c098823a8c2e2e5f2c6

Seems to work. Bye.


Add [private account lobstr.co] #wallet GCJ6K7…XANCMQ

Address: GCJ6K7BLGDYMCZ7NZCA4ONXMNQBXSFHT73KWHHDZVCS57FPSSNXANCMQ
Tags: wallet
Title: private account  Domain: lobstr.co
Requested by @bricspeace

It was not involved in a scam or scam minter process

@bricspeace This account looks like it has the same issues as GBVPLOYTDFQ5WI4R5ZMFLO2QDXXEINQIZ5PYAKNMJQ45BIHNPTABJE4V they also were both created/funded by GAPGVONR2TJLNG7D4ZSCE32OBDIN4B7HB4LDH5IDHORTAEIHBHNGTOSV
The discussion of these accounts will continue on the #322 discussion so there is not multiple ticket issues for the same kind of issue.
https://github.com/stellar-expert/public-directory/issues/322


fix: xcm_asset_teleportation not being ignored

I don't believe this ignore is doing anything atm but I suppose there's no harm in fixing it.

im using it in my tool


Correction for raw affiliation Western University, Schulich School of Medicine and Dentistry

Correction needed for raw affiliation Western University, Schulich School of Medicine and Dentistry
raw_affiliation_name: Western University, Schulich School of Medicine and Dentistry
new_rors: 02grkyz14
previous_rors: 02agqkc58
works_examples: W4387266420;W4366320858;W4318985996;W4366960435;W4366701328;W4387938564
contact: fcbfe73f4a5a3e084100dd7e9544add5:4b0fb1fdc3e6c045 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Release SDK

closing this as all the SDK components of ODIS have been transferred over to social-connect repo and recently released.
@celo/identity: 5.1.1
@celo/encrypted-backup: 5.0.5


Added sample for DLP : Create and get job

Implemented below samples
1) dlp_create_job
2) dlp_get_job
Added test cases for the same

Hi @bshaffer , Please add this ENV variable  GCS_PATH
Example :
GCS_PATH= gs://GOOGLE_STORAGE_BUCKET/dlp_sample.csv
And upload below file into bucket
dlp_sample.csv

@sameer-crest I added it, but some tests (8.1 and 8.2) were passing without it, which is worrisome. Would you be able to look into that?

@sameer-crest I added it, but some tests (8.1 and 8.2) were passing without it, which is worrisome. Would you be able to look into that?

@bshaffer I have removed the default value from the sample.


Cost

Hi,
What is the usual monthly cost of this infra?

Hello buddy!
Approximately USD 9, almost all involved costs is related to RDS Database.
We are not able to use Aurora Serverless that allows us to suspend a database in times with no traffic because the App Runner is not instantiated in the same VPC. This is a requested feature in AWS AppRunner Roadmap. With that, the costs should be reduced for +- USD 4/mo.
Tks,
Douglas

Interesting, I didn't know wandb.
If I understood, wandb is a SaaS solution and there's no self-hosted option. How we can integrate wandb with this work?

No, there is a local self-hosted version. Wandb, is way more interesting for visualization of graphics, comparing runs and metrics and else.


Source code files (Monaco) crashes with Unhandled Exception

Microsoft PowerToys version
0.66.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
File Explorer: Preview Pane
Steps to reproduce
With "Source code files (Monaco)" enabled file preview crashes File Explorer with Unhandled Exception error.
✔ Expected Behavior
A preview of the .txt file
❌ Actual Behavior
A "Catastrophic failure" Unhandled Exception error
PowerToysReport_2023-01-20-09-56-30.zip
Other Software

Duplicate of #23384

/dup #23384
Try updating webview


Add licence to project

To clarify conditions.

Would be lovely to have an Idea about this one as soon as humanly possible. Without a licence it becomes really hard to justify contribution.

Hi Leonhard.  Sorry for the delay on this.  I'm very happy that you are
interested and I see if I can start to get back to working on this project
today.  I'll take care of the license ASAP.
erik
On Thu, Mar 9, 2017 at 6:59 AM, Leonhard Weber<EMAIL_ADDRESS>wrote:

Would be lovely to have an Idea about this one as soon as humanly
possible. Without a licence it becomes really hard to justify contribution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cruisercoder/cppstddb/issues/11#issuecomment-285374611,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgazErbYbOTT2FmW_5jEmoeV0Nb4RnVks5rkBPfgaJpZM4MTmqO
.

I'am agree with @lweberk with a license file it's possible to start contributions. What kind of license do you want to take? Other C++ libraries often use the boost-license. I think that could be a reasonable choice.

BSL-1.0 license added to project. More to come soon...


Planets always render behind objects

Planets always render behind objects even when they are in front of them.
While this looks intentional, is this something that could be changed?

fixed as much as possible in 205ce269eb790ef5e1884a6785ee45c62f5f1385
planet should be fine, but the atmosphere will still be sorted incorrectly

Hi Filipp,
Looks like secondary planet geometry like rings and shattered rocks also sorted incorrectly. Is this a solvable issue?

I'll take a look. How do you get shattered rocks into the scene?

Apologies:
dx9/model/worldobject/planet/shatteredplanet.red
dx9/model/worldobject/planet/shatteredatmosphere.red

dx9/model/worldobject/planet/template/shattered/p_shattered_01.red
dx9/model/worldobject/planet/template/shattered/p_shattered_02.red
dx9/model/worldobject/planet/template/shattered/p_shattered_03.red
dx9/model/worldobject/planet/template/shattered/p_shattered_04.red
dx9/model/worldobject/planet/template/shattered/p_shattered_05.red

I take it that they have their own clipping planes?

There's not much we can do there. Planets are rendered separately with a different projection matrix. It is done to avoid precision problems at their sizes/distances. This is why sorting between them and "normal" objects would never work. We mostly get away with this in the client because planets (except possibly moons) are so large that you are not supposed to see anything behind them. Shattered rocks are part of the planet, so they won't play well with other objects either.


fix: do not error on capacity-block capacity-type

Fixes #N/A
N/A
Description

A new SupportedUsageClass was released called capacity-block. This maps to a capacity-type in Karpenter. This was throwing an error since Karpenter was not aware of capacity-block, only on-demand and spot.

karpenter-b8b6f98dc-l8r7r controller {"level":"ERROR","time":"2023-10-31T17:48:41.639Z","logger":"controller.disruption","message":"Received unknown capacity type capacity-block for instance type p5.48xlarge","commit":"4a56c66"}

> aws ec2 describe-instance-types --filters "Name=instance-type,Values=p5.48xlarge" --region us-east-2 | jq -r '.InstanceTypes[] .SupportedUsageClasses'
[
  "capacity-block",
  "on-demand",
  "spot"
]

How was this change tested?
make apply observed no more error logs
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal Would you, could you, please backport this to v0.31? See https://github.com/aws/karpenter-core/issues/806#issuecomment-1820232170


build / version info

Hi, it would be handy if you provided the build / version info for Visual C++ Redistributable packages, it's not until you've downloaded it, that you can check.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 75e6432b-c6ec-e208-5f1c-bbc4fde9929b
Version Independent ID: 9cbb940e-cddd-f82f-e8bb-ee62b17af794
Content: Latest supported Visual C++ Redistributable downloads
Content Source: docs/windows/latest-supported-vc-redist.md
Product: visual-cpp
Technology: cpp-windows
GitHub Login: @MahmoudGSaleh
Microsoft Alias: msaleh

@Axiom21
Thanks for the request. This isn't the first such request, so I'm resolving it as a duplicate of MicrosoftDocs/cpp-docs/issues/4172, which is still open. The docs team isn't notified when the download versions of Redistributable files are updated, so this function has to be taken on by the development team.
@MahmoudGSaleh for awareness.


Getting Error while Scanning

While scanning I am getting this error,
[5]  00:17:7C:5B:4C:6C  |  11  |  WPA2  |  rahul
Error for wireless request "Set Frequency" (8B04) :
SET failed on device wlan0 ; Invalid argument.
Error for wireless request "Set Frequency" (8B04) :
SET failed on device wlan0 ; Invalid argument.
[6]  00:E0:4C:AC:61:CD  |  13  |  WEP  |  SKE_HR_2
Error for wireless request "Set Frequency" (8B04) :
SET failed on device wlan0 ; Invalid argument.

Are you sure that your interface is supported by your kernel and drivers are installed correctly?

Same issue here

I'd some same issue when used with my system wifi.
But it is working fine with TP-LINK wireless adaptor.
Actually all wireless adaptors doesn't supports SET FREQUENCY.
So you need to use appropriate adaptors like Atheros or TP-link TL-WN722N

Hello!
Thank you for reporting that issue.
I’m taking a look at it.
The ‚set frequency‘ issue has been reported several times, so I’ll sppend some time fixing it soon.
Greetings, chrizator.
Von: Jenkins Shubham
Gesendet: Donnerstag, 1. Juni 2017 09:44
An: chrizator/netattack2
Cc: chrizator; Comment
Betreff: Re: [chrizator/netattack2] Getting Error while Scanning (#3)
I'd some same issue when used with my system wifi.
But it is working fine with TP-LINK wireless adaptor.
Actually all wireless adaptors doesn't supports SET FREQUENCY.
So you need to use appropriate adaptors like Atheros or TP-link TL-WN722N
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Hey its me again,
since I’m not getting the issue I tried something out to fix it.
It seems like certain processes disturb channel switching.
It would be nice if you could try the ‚fixed version‘ out and send me some results.
Thank you!
~ chrizator
Von: Jenkins Shubham
Gesendet: Donnerstag, 1. Juni 2017 09:44
An: chrizator/netattack2
Cc: chrizator; Comment
Betreff: Re: [chrizator/netattack2] Getting Error while Scanning (#3)
I'd some same issue when used with my system wifi.
But it is working fine with TP-LINK wireless adaptor.
Actually all wireless adaptors doesn't supports SET FREQUENCY.
So you need to use appropriate adaptors like Atheros or TP-link TL-WN722N
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Add testing for Lumen 5.7, 5.8 and 6.x, plus PHP 7.1-7.4

Upgrade distro to bionic (Ubuntu 18.04 LTS) so we have PHP 7.1-7.4 available:
https://docs.travis-ci.com/user/languages/php/#choosing-php-versions-to-test-against
I notice that Travis CI doesn't quite seem to know that tests have ended. Not sure if this fixes anything.

Ah cool, Travis now immediately detects once the tests have finished 👍

Thanks for your pull request :)


fix: add xml files for each action

@zaidusmani26 shouldn't this be merging to the v2.0 branch and not main?


Material UI support

Hi, first of all, thanks for your project! I'm currently working with it, and it's a cool stuff.
I have been looking a little bit at your code, and some parts could be upgraded to ES6 sintax.. I would like to make a PR with this, and even more, I want to create a MaterialUIComponentFactory, for those who use material-ui in their projects.
Let me know what do you think about this.

That's amazing. Feel free to create your PR. If you'd like a Skype call, let me know.

Also, if you happen to become a frequent contributor, I'll invite you to the organization.

Great, I will be working on that, maybe in the weekend I will submit a PR with the changes :+1:
If I have some trouble, I will ask you in this issue!

Deal. Thank you very much.

@andrerpena I have made a PR for the es6 refactor #23! Hope you can check it as soon as you can!

I'll do this first thing in the morning. Thank you very much for this
Em 16 de jul de 2016 19:31, "Jonatan E. Salas"<EMAIL_ADDRESS>escreveu:

@andrerpena https://github.com/andrerpena I have made a PR for the es6
refactor #23 https://github.com/gearz-lab/redux-autoform/pull/23! Hope
you can check it as soon as you can!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gearz-lab/redux-autoform/issues/21#issuecomment-233154410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABghdWQf8uWbae9-GEj-GZouGTegAnHVks5qWVu1gaJpZM4JMiNn
.

 Glad to help your project grow!

Let me know if you want write access

If you want to give me write access I don't have any trouble!
I will keep working through PRs, so you can check the codebase I make and confirm if it works or needs thinks to solve, in order to not break the master branch!

You have been invited @JonatanSalas

Thanks! @andrerpena! For now I will start to work in material-ui integration.

@andrerpena I been started to think that Autoform component could have a new property like uiType, that will be String. You could specify which type of UI you like Autoform get, for example "material-ui", "bootstrap" and internally match this type to a generic factory which determines what kind of ui-factory should use.
This type could be an option, not required, you could use this, or provide your own componentFactory to autoform.
What do you think?

Are you suggesting that there would be 2 ways to choosing the factory.. one by explicitly passing it in, and the other by passing this prop that would allow Autoform to automatically pick a factory?

Exactly, it's more easy if you want to use a built-in factory, avoiding you to import the defaultEditComponentFactory, and passing it as props, and you keep maintaining the ability to pass a custom factory if you don't want to use the built-in's redux-autoform provide.

How are we dealing with the demo? I kind of prefer that the Bootstrap and the Meterial demo to be completely separate, because the presets won't be the same. I mean, we can still leverage the editor and the layout and everything but making them apart.
Do you prefer it that way or do you think adding another "switch" in the demo is a good idea?

Well, if you want we can make another demo for Material-ui, that's not a big trouble :)
First of all I will do it, and test all it's working fine and well abstracted, and then after PR approbed I will make the demo work!

But how are you testing without the Demo? I mean.. I created the Demo not for the people to see, but so I can debug it faster hauhauh.. just kidding.

@JonatanSalas It's just my 2 cents but I kind of feel like we should start the Material with a demo.

As an Isolated enviroment to test my components I use carte-blanche project. Do you know it? https://github.com/carteb/carte-blanche

I'll take a look at it, thank you!

Jaja you are welcome! :)

@andrerpena I have notice that in your code you have two types of factory. An Edit factory and a DetailsFactory, could you explain me a little bit about this? :)

@JonatanSalas , I'm thinking about renaming the components folder and the factories to indicate they are bootstrap, like this:

See that there's no DefaultComponentFactory anymore. Now it's BootstrapEditComponentFactory.
What do you think? Can I do it and commit it?

A details component factory is meant to be used for a details scenario (not for editing).
Actually.. I was envisioning 3 types of forms:

Edit
Details
Search (similar to Edit, but this one supports grouping and operators like greater than).

If you have a better idea, please let me know.

Well, I think it's good, but we could use a more modular approach like this:

components

bootstrap
material-ui

less

bootstrap
material-ui

factory

bootstrap
material-ui
ComponentFactory.js

lib -> (this could be named as metadata or metadata-validator or something like this)
AutoForm.js
AutoFormInternal.js
index.js

What do you think?

@andrerpena thanks for the explanation about component factory types :)

Ok, I agree with your directory proposal, are you doing this or do you want me to do it? I can only do this tonight.
Thank you.

@andrerpena in the feature branch I'm developing I have organized the directory structure like this, so when I submit a PR with the changes you will see this structure.
Do you agree about a rename over lib folder? In this case, what name would you propose?

@JonatanSalas
metadata is what most of this folder does, but it also deals with localization and it has some helpers like arrayHelper (which we can think of removing). I agree of renaming this folder to metadata as long as we take localization out. You can rename it now and we organize it better later.. or you can give your shot on the organization and I let you know of something I would change.

Okey, I'm currently organizing it and I agree to renaming lib as metadata and extract localization! :)

@andrerpena another question about edit, details and search component factory. It would be better if you have only one Factory per UI, and to get the edit/details/search one you pass a flag to it.
Do you agree?

I agree. The reason why I didn't do it that way from the beginning was that
I wasn't really thinking in supporting multiple UI frameworks. I was more
interested in supporting multiple components. Go ahead. I agree to you.
Em 18 de jul de 2016 5:35 PM, "Jonatan E. Salas"<EMAIL_ADDRESS>escreveu:

@andrerpena https://github.com/andrerpena another question about edit,
details and search component factory. It would be better if you have
only one Factory per UI, and to get the edit/details/search one you pass a
flag to it.
Do you agree?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gearz-lab/redux-autoform/issues/21#issuecomment-233450264,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABghdRAiCTeMnpIHpjk4aeHZ9FmqUZLOks5qW-N9gaJpZM4JMiNn
.

@andrerpena  I started to think that If we designed it a little bit we could extract the ui component factories into small units like:

redux-autoform-material-ui
redux-autoform-bootstrap
redux-autoform-other-ui

And redux-autoform working as core library, making ui pluggeable. what do you think?

Yes, that makes sense, as long as redux-autoform keeps being the main project, but I think that's how you're thinking too.
The advantage of this approach is that you, as a user, don't have to download a bunch of code/styles that you're not using, and that makes redux-autoform agostic of the UI framework.
Do you care making the refactoring? Do you need help? How do you think we should do it? What about the demo? The demos should probably be in the UI libraries but with LINKs in the main project readme.md.
Also, I can invite you to the organization. We can even rename it or create an organization specifically for Redux-Autoform. I'm not sure about that.

And even too, we part the trouble in two, we separate the metadata management from ui, so we can focus on improvements on differents projects.
We can make a guideline too for those who want to create a ui library extension.
Well, actually I will submit you a PR with the library restructuration.
Then I will add material ui support in this library, and when we can abstract how to organize a ui project for material, bootstrap, etc, and then we start the migration.
Do you agree? :)
About the organization, do with that what you want! If you think that an organization for redux-autoform maybe a good decision just do it! I will keep on helping to improve this project :D

Thank you very much @JonatanSalas , yes.. submit Material-UI as is and then we figure out how to split the projects apart.

What are you going to do with redux-autoform, are you going to create an organization for it?

@JonatanSalas, yes I will create an organization and invite you. How would you name it? Redux-Autoform?

or something more creative...

@andrerpena for now I think that Redux-Autoform is a good name, but we can make an issue to discuss about it. It would be good too if we can make a good logo for the organization :)

@JonatanSalas sounds good. Expect an invitation shortly.

@andrerpena okas! Thank you :+1:

i know i'm a little late to the game here, but since there is a hard dependency on redux-form, i would suggest a name that includes it, ie. redux-form-auto or redux-form-builder

@andrerpena I will close this, since I'm working on a different git repo! :+1:


Doesn't throw error with empty children

This address #57 , and adds a spec to demonstrate the behavior.
Also there is a small fix to a previous spec example: throws if theres a bad query which was the same example as throws if theres no query, so I made a small change to make it a "bad query".

Thanks!


HNC: ensure subnamespaces are not deleted as HNC is uninstalled

If HNC is uninstalled, we ideally want all existing namespaces and objects to be left alone. In particular, we want all subnamespaces to be left as-is.
Depending on the order in which HNC objects are uninstalled, I'm concerned that the following situation could occur:

The SubnamespaceAnchor CRD is deleted before the HNC manager itself.

Prior to the CRD being fully deleted, all the SubnamespaceAnchor objects are deleted. I'm not actually sure if this happens.
The HNC manager notices the anchors being deleted and deletes the subnamespaces (if allowCascadingDelete is enabled, or if we relax restrictions in the future).

We should either ensure that this can never happen - eg, because the reconciler will get some non-retriable error if the CRD is deleted - or else find some way to detect that it is happening and fix it.

Fixed by #762

/close


Update README.md to include continue-on-error: true in action

I had to add
continue-on-error: true

in order for the next step to fire when there were broken links -- regardless of the if:
I tested with adding a Debug echo step after the lychee step.
- name: Debug Exit Code
        run: |
          echo "Lychee exit code: ${{ steps.lychee.outputs.exit_code }}"

And this was skipped.

Yeah, I think that makes sense. @YDX-2147483647, right?

I agree that the example in the README does not work, but I suggest adding fail: false instead.
https://github.com/lycheeverse/lychee-action/blob/5cd5ba7877bce8b3973756ae3c9474ce1e50be2f/.github/workflows/links.yml#L17-L22
    - name: Link Checker
      id: lychee
      uses: lycheeverse/lychee-action@v2
+     with:
+         fail: false

If lychee is properly configured, fail: false and continue-on-error: true behave identically. But if lychee somehow cannot find any link, then fail: false fails the CI (due to failIfEmpty), but continue-on-error: true creates an issue with zero broken links.

Thanks for your contribution @psobolewskiPhD.


Can't install on Windows

spent an hour trying to get an ENV up on Windows 9, without luck

I assume you mean Windows 10 :smile: -- unless I'm missing something. We could solve this by keeping an up-to-date Vagrant image, I feel like I'd rather that than maintaining instructions for installing Ruby and Postgres on Windows.

haha - yep. 10 - and ya, Vagrant is a good idea.  I'll also keep an eye out for good Windows instructions on getting Ruby and Postgres going (if there are any)

I am working off of a Windows 10 machine and recently submitted a PR that added the tzinfo gem for Windows support.
I'm writing code and everything is working properly.

@howdoicomputer good to hear :) I think some of the confusion for this issue was around running Postgres and Ruby on Windows, but I may be misremembering. We could add some links to other documents for how to do that though.

Windows development is always tricky for languages that require C extensions. I'll write a guide somewhere but potential Windows developers would need to install Ruby 2.X, install Ruby DevKit, install Postgres, and then follow the documentation for DevKit so that gems like json can have their C extensions compiled correctly.
I also found that there is a bug in the bcrypt gem that required some custom installation steps as well.
I mean, it's a bit tricky but if the steps are laid out it takes less than ten minutes to get everything running to the point that bundle exec rake test returns 0 errors.

Alright, I went ahead and wrote a lengthy guide in the wiki for setting this up on Windows.
https://github.com/sfbrigade/adopt-a-drain/wiki/Windows-Development-Environment
Is this issue ready for closing?

Indeed it is, these instructions are great!


Skeleton adoption branch 1

Closes #240
Converts event-model to use the DLS python skeleton, adding all the features other than the .vscode and the container, the following have been added:

using a single pyproject.toml instead of requirements.txt and requirements-dev.txt
black
isort
having the git version generated by setup.py instead of versioneer
mypy
pre-commit

The CI has been tested, and will fail only on flake8 and mypy since the master branch __init__.py does not yet have typing support.
This change will introduce to event-model the older commits to the DLS python skeleton - those which altered features which will be included in this PR.

CI now uses jsonschema version 2 and 3 in a matrix

Comment out mypy in a single commit, then restore it in #247

@mrakitin any other changes, or shall we merge as soon as @evalott100 has temporarily commented out mypy in CI in this branch?

Made the fixes to this repo, and added fixes in the skeleton repo for the issues that were shared.

Don't you have scenarios when one would like to create the sdists/wheels locally? Maybe it can still be added to the dev requirements, but I have no strong opinion about it.

We always pip install /path/to/event_model if we want a local install, so I can't say I've ever used pipx locally. As we have a venv then pip install twine is easy to do, and it's unlikely many people would ever need to do it, so I'd err on the side of not including it.

By the way, when I tried to create the distributions, it reported the version number 0.0.0... Is it expected?
$ pipx run twine check --strict dist/*
Checking dist/event_model-0.0.0-py3-none-any.whl: PASSED
Checking dist/event-model-0.0.0.tar.gz: PASSED

That's unexpected, @evalott100 could you see if you can reproduce locally?
@mrakitin when this last issue is sorted, are there any others outstanding?

Thanks for the revisions @evalott100. Where does the v0.0.0 issue stand?

Are black and flake8 still not in agreement?
event_model/__init__.py:283:89: E501 line too long (103 > 88 characters)
event_model/__init__.py:291:89: E501 line too long (103 > 88 characters)
event_model/__init__.py:292:89: E501 line too long (107 > 88 characters)
event_model/__init__.py:314:89: E501 line too long (94 > 88 characters)
event_model/__init__.py:331:89: E501 line too long (102 > 88 characters)
event_model/__init__.py:337:89: E501 line too long (90 > 88 characters)
event_model/__init__.py:1763:89: E501 line too long (101 > 88 characters)
event_model/__init__.py:1764:89: E501 line too long (103 > 88 characters)
event_model/__init__.py:1913:89: E501 line too long (95 > 88 characters)
event_model/tests/test_filler.py:376:89: E501 line too long (95 > 88 characters)

Are black and flake8 still not in agreement?
event_model/__init__.py:283:89: E501 line too long (103 > 88 characters)
event_model/__init__.py:291:89: E501 line too long (103 > 88 characters)
event_model/__init__.py:292:89: E501 line too long (107 > 88 characters)
event_model/__init__.py:314:89: E501 line too long (94 > 88 characters)
event_model/__init__.py:331:89: E501 line too long (102 > 88 characters)
event_model/__init__.py:337:89: E501 line too long (90 > 88 characters)
event_model/__init__.py:1763:89: E501 line too long (101 > 88 characters)
event_model/__init__.py:1764:89: E501 line too long (103 > 88 characters)
event_model/__init__.py:1913:89: E501 line too long (95 > 88 characters)
event_model/tests/test_filler.py:376:89: E501 line too long (95 > 88 characters)

@mrakitin They are in agreement now, however black doesn't format strings to be multi-line if they exceed 88 characters (which wasn't a problem with flake8 before changing the max line length). These were all just strings which needed to be put in multiple lines.


DCD backend: create swagger.json api docs

for creating a client based on the api docs (cf. #68) we need to have the docs available as a file, e.g. swagger.json - we should find a convenient way of generating this file, and perhaps add it to our version control, where convenient means automated and reproducible.

at the moment it can be downloaded / looked at from the swagger web ui at the top of the page

regarding automatic generation - apparently it's difficult with swashbuckle

Hi, I'm currently working on deploying a .net core api project to azure.
Azure app services needs the openAPI specification to populate the api definitions.
In process of deploying through github actions CI/CD pipeline; I found that the VisualStudio generated pipeline yml includes this step.
 - name: Generate Open API Specification Document
      run: swagger tofile --output "${{ env.API_IMPORT_SPECIFICATION_PATH }}" "${{ env.API_IMPORT_DLL }}" "${{ env.API_IMPORT_VERSION }}"

This blog post has details on how to generate swagger.json as build output.
https://medium.com/@woeterman_94/how-to-generate-a-swagger-json-file-on-build-in-net-core-fa74eec3df1
I hope it helps.


Make TypeScript Definitions for carousel v2

Is your feature request related to a problem? Please describe.
Because of changes, we made in carousel v2 (removing props, adding new ones, adding plugins) we need to update our types definitions
Describe the solution you'd like
An updated version of d.ts for carousel v2 in https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/brainhubeu__react-carousel

Currently, types for v2 are accessible on this repo https://github.com/RobertHebel/DefinitelyTyped/tree/master/types/brainhubeu__react-carousel
After v2 release, I will create PR for DefinitlyTyped repo

@RobertHebel Would you explain how use Types from this repo?
Could you give me an example?

I've created PR with new typings for carousel 2.0
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46433

@wilo087, For now, if you want to use types for carousel 2.0 you need to add your own declarations, or you can use carousel v1 which already has typescript support


Update TypeSpec Java emitter version to 0.8.0

API change check
API changes are not detected in this pull request.


Update package version

3.1.0-alpha.8 (2023-10-30)
Bug Fixes

audio-annotator-react: import components-react style file (abe4746)
frontend: import components-react style file (cb80a19)
video-annotator-react: import components-react style file (a9c48da)

:tada: This PR is included in version 1.1.0-alpha.17 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0-alpha.18 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0-alpha.17 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.1.0-alpha.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


The comic at marryme.keenspot.com not working.

I assume it's not working for the rest of the keenspot comics either.
http://marryme.keenspot.com/d/20120823.html

Oops, it only took me 11 months to make this simple fix. Well, now it should work again now. Too bad the final update was 4 months ago. :P


Not sure if this is an issue, but how do I select a port

I want to connect on port 1079, but I cant find any documentation on choosing a port

r = requests.get('http://http2bin.org:8080')


(Feature) #925 dashboard add start claiming card 3 days after sign up

Description
Implement functionality to add new 'start claiming' feed card to the user's timeline after 3 days since the first login. Added tests for new util and event obj.
About #925
How Has This Been Tested?
Change the value from 3 days to some smaller. (UserStorageClass.js 847 line)
Register a new account.
Go to dashboard - after time you set for testing refresh the page and the new event will appear.
Check the item looking and open to test the button and design.
Don't forget to revert the changes with time back.
New Environment Variable
Delay for displaying start claiming card (in milliseconds)
Optional. Default 3 * 24 * 60 * 60 * 1000  // 3 days
REACT_APP_DISPLAY_START_CLAIMING_CARD_TIME
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[x] I have added screenshots related to my pull request ( for frontend tasks)
[x] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

Screenshots:

Browser
Simulators

Card

Modal

Gif

move const displayTimeFilter = 3 * 24 * 60 * 60 * 1000 // 3 days to ENV with default value

Looks graet. Just one thing, on some of the pop ups the word "income" is an orphan (alone in the line).
Please make sure that in those instances the word won't stay alone.

Ok. So the solution for that is to remove line break between these 2 sentences. Is it ok for you?

Looks graet. Just one thing, on some of the pop ups the word "income" is an orphan (alone in the line).
Please make sure that in those instances the word won't stay alone.

Ok. So the solution for that is to remove line break between these 2 sentences. Is it ok for you?

@yaroslav-fedyshyn-nordwhale
Yes.

move const displayTimeFilter = 3 * 24 * 60 * 60 * 1000 // 3 days to ENV with default value

Done

move const displayTimeFilter = 3 * 24 * 60 * 60 * 1000 // 3 days to ENV with default value

Done

Looks graet. Just one thing, on some of the pop ups the word "income" is an orphan (alone in the line).
Please make sure that in those instances the word won't stay alone.

Ok. So the solution for that is to remove line break between these 2 sentences. Is it ok for you?

@yaroslav-fedyshyn-nordwhale
Yes.

Done

includes other PR
why do we need isSmallDevice? why cant we just make the text area adapt to length? not make it fixed height.
try not to use percentages for width/height, see if you can use flex instead or design realtive fixed numbers.

Will create new PR and get the commits from this PR into it.

Closing this PR as the new one created without containing changes from other PRs.


Add Support for Changing Hint Text color for Textboxes

Adds support for changing the hint text color of the apppinventor textboxes ( the TextBox, PasswordTextbox, and EmailPicker), by adding a new HintColor property to the TextBoxBase class.
Fixes #2519

Can one of the admins verify this patch?

@AppInventorWorkerBee ok to test

This PR had multiple conflicts with the ucr, I have updated it now to include the missing upgraders and fix conflicts with ucr.


Skeleton attribute for indicate the loading state of data in every component

This function solves the problem (这个功能解决的问题)
Can we have the "skeleton" attribute in every component? I found it requires us to work twice just for creating a page that has skeleton components in it, we need to create same skeleton size for every components and make an if-else statement for it.
Expected API (期望的 API)
We can create a "skeleton" attribute in every naive-UI component. We include an if-else statement in it, to determine whether we need to render the actual component or its skeleton with the same style as its actual component at that time.

This issue does not have any recent activity. If you are still experiencing similar problems, open a new error, including a minimal copy of the problem


Found some more typos

Ran a spellchecker on the _pages dir + one clarifying suggestion in why-multisig.md

Thanks @merland and sorry for the slow merge (was traveling last week).
Oof that was a lot of typos :(


Option to show uncertainty when using average aggregation

Required for https://github.com/uwdata/facetedviz/issues/52, special case of #269

duplicate


⚠ Bofrost.ch has degraded performance

In 892e785, Bofrost.ch (https://www.bofrost.ch) experienced degraded performance:

HTTP code: 200
Response time: 2194 ms

Resolved: Bofrost.ch performance has improved in dbd3318.


Implement hash writer

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

One small thing. I see you named your error variables "error" while most go developers use "err" (probably just so the name isn't the same as the type).

One small thing. I see you named your error variables "error" while most go developers use "err" (probably just so the name isn't the same as the type).

Thanks!, I updated to err


Allow base_url to be overridden via attribute

Allow base_url to be overridden via attribute. This is useful to point to a mirror globally in a private infrastructure.

Thanks for filing this issue. This cookbook isn't intended to be a general purpose APT/YUM cookbook. It's mostly geared toward interacting with the packagecloud API to issue read tokens and install GPG keys.
If you can expand a bit on the use case and why this would be a useful addition to this cookbook, we'll certainly consider it.

Sure.
There are several third party cookbooks that uses packagecloud cookbook. To use those cookbooks in a firewalled environment (prod is not allowed to use internet) , we need those cookbooks to use local mirrors. There are essentially two ways I can think of:

In the wrapper for the third party cookbook, modify the packagecloud resource using chef rewind. This has to be done in every wrapper.
Override baseurl globally in a base cookbook.

I prefer 2 as it can be done generally and once, and it less complicated. Thus, this pull request.


feat: Adding sorting, searching, and recursion examples for Javascript

Searching:

[x] Linear
[x] Binary

Sorting:

[x] Selection
[x] Bubble
[x] Insertion

Recursion:

[x] Factorials

Stashed typescript support since that isn't a priority right now. Typescript users can still use the JS examples and add typing of any (bad practice, but it works) or just not use typing at all

Oh oops I thought I deleted it.
Thanks for the heads up!

@mrseidel could you merge this in if it looks alright?


Changed comment to show columns, rows in the correct order for SetGri…

…d() in sample.

LGTM based on discussion in #160.

LGTM - thank you!


BoundedAsyncPool doesn't work with a negative maxTotal

Bug Report
Current Behavior

When using the BoundedAsyncPool with a negative maxTotal, new pool objects are not created. Trying to acquire a new object will fail with io.lettuce.core.RedisException: java.util.NoSuchElementException: Pool exhausted
This can be reproduced by creating a pool with the following config:
BoundedPoolConfig.builder()
                .maxTotal(-1)
                .build();

Input Code
I've added 2 unit tests to BoundedAsyncPoolUnitTests based on the 5.2.x branch to demonstrate the failures:
https://github.com/lettuce-io/lettuce-core/compare/5.2.x...sguillope:bounded-async-pool-with-negative-max-total?expand=1

shouldCreateObjectWhenMaxTotalIsNegative fails with

io.lettuce.core.RedisException: java.util.NoSuchElementException: Pool exhausted

	at io.lettuce.core.LettuceFutures.awaitAll(LettuceFutures.java:88)
	at io.lettuce.core.LettuceFutures.awaitAll(LettuceFutures.java:46)
	at io.lettuce.test.Futures.get(Futures.java:98)
	at io.lettuce.test.Futures.get(Futures.java:116)
	at io.lettuce.core.support.BoundedAsyncPoolUnitTests.shouldCreateObjectWhenMaxTotalIsNegative(BoundedAsyncPoolUnitTests.java:72)
	at ...
Caused by: java.util.NoSuchElementException: Pool exhausted
	at io.lettuce.core.support.BoundedAsyncPool.acquire()(Unknown Source)

shouldCreateMinIdleObjectWhenMaxTotalIsNegative fails with

org.opentest4j.AssertionFailedError:
Expecting:
 <0>
to be equal to:
 <2>
but was not.

Expected behavior/code

Min number of idle objects are created based on the minIdle config when the pool is initialised
New objects are created and returned by the pool when calling acquire()

Environment

Lettuce version(s): 5.2.1.RELEASE
Redis version: AWS Elasticache

Additional context
We found this issue after upgrading from SB 2.1 to 2.2.1 and to Spring Data Redis 2.2.1. We use the following Spring application.yml-based Redis config:
spring:
  redis:
    lettuce:
      pool:
        max-active: -1
        min-idle: 1
        max-idle: 10

When we upgraded our healthcheck (which include the redis component) started failing. Debugging found that java.util.NoSuchElementException: Pool exhausted was being thrown in RedisReactiveHealthIndicator.

There's no support for -1 for maxTotal in BoundedPoolConfig. You're required to specify a max value, hence the name bounded pool. We have a utility (CommonsPool2ConfigConverter) that adapts a Commons Pool2 config to a BoundedPoolConfig. It would make sense to add a switch there to react to negative maxTotal settings and replace these with Integer.MAX_VALUE.

Yeah I figured it might have been intended that way. Unfortunately the pool configuration declared through Spring's properties is used for both sync and async pools.
For now we've changed our max-active to a very high integer value to make it work. Automatically falling back to Integer.MAX_VALUE would work for us.
Thanks

That's fixed now.


false positive: transfer.adttemp.com.br

The domain "transfer.adttemp.com.br" is a public instance of the transfer.sh software, used for temporary file hosting (similar to catbox.moe). It's currently on the blacklist. There's nothing inherently bad about it.

Thank you for this Devon @hyder365.
This domain comes to us from upstream at URLHaus.
Please report this, and make you case, at<EMAIL_ADDRESS>Closing.


Wheat drop bug

A very weird bug I haven't been able to reproduce anywhere else. I think it might be due to the crops being at a chunk border, but I don't know how to check (F3+G doesn't work).
Sometimes the crops drop, sometimes they don't. The first time I planted them they didn't immediately drop, but only did so after a minute or so.
I highly doubt that this bug only affects wheat, or crops for that matter.
https://github.com/user-attachments/assets/4120ec1b-371f-4464-b2c2-78322486e104

Turns out I just had to add more torches


r = pdf.abstract(chem=True) only possible for abstract?

Hey,
it seems to me that only the abstract-method can be used right now with chemdataextractor if chem is True. Is there an implemented way to screen the whole pdf text with chemdataextractor?
I can of course just take the plaintext()-method, take the full pdf-text-string and run it manually through chemdataextractor. But as mentioned above, i was wondering if there is an implemented way in PDFDataExtractor to do that.
greetings
viktor

Hi Viktor,
Sorry for the super delayed reply. So many thanks for your comments but ATM, I am taken by other things, so probably I won't be able to work on the details of the project. For the time being, you can simply use ChemDataExtractor v2.0 to perform CNR as PDFDataExtractor focuses more on metadata extraction.
FYI:
https://cambridgemolecularengineering-chemdataextractor-development.readthedocs-hosted.com/en/latest/introduction/reading_docs.html
Cat


Upgrade to newer MicroPython say 1.21.0

Very nice piece of work. Your firmware works great on my cheap AliExpress ESP32-S3 N16R8 with UNO form factor.
How about upgrading to a newer MicroPython say 1.21.0? And providing the firmware as assets here on github.
Thank you.
I was able to build my own latest MicroPython firmware from scratch. Using esp-idf v5.0.4 and MicroPython 1.22.0.
I of course used your settings.

I'm glad to hear that the repository has been helpful to you! Currently, I don't have an ESP32-S3 at hand to test. However, if you could submit a pull request with the changes you've made to upgrade to newest MicroPython, I'd greatly appreciate it.

The newer MicroPython versions already very well support SPIRAM and large flash. Their installation and build instructions are excellent. All I ended up doing was simply change the parameters for the flash size from 8MB to 16MB. No need for me to create a pull request here.


[REBORN OSX] CAPSLOCK can't be bound

Binding capslock doesn't seem to work in Reborn. This means in the default binds you can use voice key.

This seems to be a MAC engine specific issue, and there's not much we can do on our part, unless volvo syncs the functionality to mac somehow.
Until then, the functions that are bound to capslock need to be moved to other keys, which is quite troublesome.

Well, you could maybe set some ridiculous alternative key, so people can easily re-map their capslock to that.


DTFS2-3549 - TFM tasks creation based on list of additional tasks (depending on deal data)

Business requirement

Add a task creation rule for a BSS MIA deal that has eligibility criteria answer 11 as false (additional task gets added)

How

Add isConditional flag to tasks that can be included or not included (on deal submission), depending on deal data
Remove ability to pass a list of 'excluded tasks' to task creation function

How / clean up / scalability

Instead of having a list of 'exluded tasks', we now only specifically define a list of 'additional tasks' that will be added, depending on the deal data
Make deal.tasks.js more functional - each task rule in it's own function
Add logic to 'create group tasks' function so that a task will only be added to a group if:

the task is not  a conditional task (therefore always applies)
or the task is a conditional task and is included in the list of additional tasks to add

Why

This approach saves logic/conditions and potentially hard to read or confusing code
Specifically creating 'additional tasks' to add (depending on the deal data), is clearer and more scalable than having a list of 'excluded tasks'
Splitting out each task creation condition ("if X in deal, add this task") ...into their own functions is nice and clean; can be easily removed, expanded and tested

LGTM
I left a small comment. not a show stopper though


Liveview migration

Close #59
Move all features to a liveview
Update all existing controller tests to a liveview tests
Update the router
Remove all old controller files

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@hectorperez
Feel free to msg me if needed.
@BrooklinJazz thkx for indicating this repo. This migration was fun!

@FabriDamazio It's in production now. Thanks! ❤❤


Fix HART get status extension typo

Looks like a trivial typo, as this function does not take a start_addr argument.

Looks good to me
@atishp04 can you please take this PR
Regards,
Anup


Some project maintenance, use flutter_map version 4.0.0 in example project

I wanted to upgrade your package to support flutter_map 4.0.0 but realized that there is no breaking change. So i did some small things instead:

android example project maintenance

upgrade gradle to support Java 19 (https://docs.gradle.org/current/userguide/compatibility.html)
update targetSdkVersion to 33
remove deprecated android.enableR8

(hopefully) fix the screenshot image on pub.dev once and for all by using the absolute url from github.
remove deprecated lint invariant_booleans (https://github.com/dart-lang/linter/issues/3336)
use version 4.0.0 of flutter_map in the example project and loosen dependency constraint (it was hard set to 3.0.0)
increase minimum flutter_map version to ^4.0.0 and lower it back down to >=3.0.0 (woopsi)

Thank you for the upgrades. I will do a new minor release soon.
I was notified of the new flutter_map release yesterday. The plugin does indeed work with with version 3.0.0 as well as the new 3.1.0 and 4.0.0 releases.

Minor release 0.2.6 just done.
@josxha The image on pub.dev does work now. 👍


add assert function

Done:
pub fn assert(b: bool) {
    if (!b) unreachable{}
}

It's in the standard library now.


⚠ Bofrost.at has degraded performance

In 4655c91, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1152 ms

Resolved: Bofrost.at performance has improved in bfe4c82.


Adafruit neoPixelType order

When setting the pixel the neoPixelType is not taken into account (RGB versus GRB for example). So colours could be off as I had in my setup. One can make a crude hack to shift the pixel colors according to the used type, but a constructor parameter would be nice.
See https://github.com/adafruit/Adafruit_NeoPixel/blob/master/Adafruit_NeoPixel.h
great work

Thank you sir ... I'll take a look and do as you ask. ... Neil

Howdy @Smeedy  ... I have attempted a fix.  The default order in which colors are sent to the pixels remains "RGB".  However, you can now customize the order.  There is now a function on the WS2812 object class called setColorOrder(char *).  This expects a three character string composed or the characters 'R', 'G' and 'B'.  For example:
myWS212.setColorOrder("GRB")

Would then send the colors in GRB order next time show() is called.  I hope this works, if not ... please post back.

Closing ... believed resolved.

Awesome ... TY again kind sir and let me know if I can ever help again in the future.


JSON response does not include Navigation Links

If the "Accept" Header is set to "application/json" then the navigation links are not included in the response. However, if the "Accept" header is not specified or it set to "application/xml" then a XML response is returned with the navigation links included.
{
<EMAIL_ADDRESS>"http://localhost:8080/example.svc/$metadata#topic/$entity",
<EMAIL_ADDRESS>"topic('Topic-1')",
  "id": "Topic-1",
  "topicName": "testTopic"
}

<?xml version="1.0" encoding="UTF-8"?>
<entry xmlns:metadata="http://docs.oasis-open.org/odata/ns/metadata" xmlns:data="http://docs.oasis-open.org/odata/ns/data" xmlns="http://www.w3.org/2005/Atom" metadata:context="http://localhost:8080/example.svc/$metadata#topic/$entity" xml:base="http://localhost:8080/example.svc">
    <id>http://localhost:8080/example.svc/topic('Topic-1')</id>
    <title></title>
    <summary></summary>
    <updated>2016-02-24T22:26:10.145Z</updated>
    <author>
        <name>SDL OData v4 framework</name>
    </author>
    **<link rel="edit" title="Topic" href="topic('Topic-1')"></link>
    <link rel="http://docs.oasis-open.org/odata/ns/related/message" type="application/atom+xml;type=feed" title="message" href="topic('Topic-1')/message"></link>
    <link rel="http://docs.oasis-open.org/odata/ns/relatedlinks/message" type="application/xml" title="message" href="topic('Topic-1')/message/$ref"></link>**
    <category scheme="http://docs.oasis-open.org/odata/ns/scheme" term="#SDL.OData.Example.Topic"></category>
    <content type="application/xml">
        <metadata:properties>
            <data:id>Topic-1</data:id>
            <data:topicName>testTopic</data:topicName>
        </metadata:properties>
    </content>
</entry>

We have this on our backlog to resolve. Is this something blocking you right now?

It is blocking but we have decided to use Olingo for now. However, I really liked the intuitiveness of the annotations based approach in SDL and the fact that it has a pretty neat integration with Spring. We could definitely consider moving to SDL once the issue is resolved.

I'll fix that.

Important information on JSON specifics regarding links.

@dineshgarg I expect implementing odata.metadata=full Accept header behavior will be overkill? :no_good:

@Oregu Sounds good!


Brainstorm - New Runner Output Format

So, as it stands right now, the bondage runner has three types of outputs that are returned to the user, as defined in results.js: LineResult, OptionsResult, and CommandResult. This isn't very extensible, but it works for the basic yarn functionality, and is basically everything the end user will care about in that specific case.
I am interested in making this more generic to allow for more complex formats to be returned easily from the AST, rather than worrying about what types they are on the runner side.
In this situation I'm imaging three separate components, a Parser, a Runner, and a Renderer (the former two are currently encompassed by bondage). In the future, the Parser should be a separate module with a well-defined interface that can be plugged into bondage, while also allowing the option for other sorts of languages to be used as long as the provide the interface. The Renderer would simply plug into the runner and consume its output, handling all of the decisions of how to display and process it, as well as being responsible for reporting the status of any player branching decisions to the runner.
I think the ideal of this system would be one where

Any arbitrary amount of new commands/language features can be added without changing the runner (only the parser).
The runner only cares about options/conditionals/branching and variables, the rest can be shunted off to the renderer. It should handle all logic regarding these things, as well as keeping track of the player input as reported for the renderer (e.g. one theoretical runner feature would be the ability to reverse through the decisions the player has made back up the tree)
Some sort of type definition can be provided by the parser to denote what sort of nodes exist, and what types they are, what properties they contain, etc. This can be checked by the renderer to ensure it knows what featureset it's dealing with. This could also be processed on the runner side to check the validity of the AST.

I think the easiest way to achieve points 1 and 2 is to have the runner pass AST data more-or-less directly to the renderer. Each AST object would contain a type string describing what it is, and then it would contain the parameters described in the type definition. The renderer would be able to handle the types and use them however it wants.
There are a few exceptions to this: the parser would need to always define the features the runner needs (as mentioned in the beginning of point 2). Some sort of standard object type to define branches and variables that doesnt get sent to the renderer, but is used to determine the flow of the dialog. The renderer shouldn't even need to know what branches are being taken, it just displays any options given by the renderer, then tells the runner when they are selected (just as it doesn't need to know how to handle variables/scoping/calculations).
In my test visual novel renderer, I'm just running it directly based off of an extremely simple AST (with a small mocked up runner). Here is an excerpt of it:
[
    {
      type: 'hide',
      name: 'me1',
      transition: 'fadeout',
    },
    {
      type: 'show',
      name: 'me2',
      tag: 'normal',
      loc: 'right',
      transition: 'fadein',
    },
    {
      type: 'say',
      text: 'lorem ipsum',
      name: 'hayley',
    },
    {
      type: 'hide',
      name: 'me2',
      transition: 'fadeout',
    },
    {
      type: 'option',
      options: [
        {
          text: 'This is option 1',
          name: 'option1',
        },
        {
          text: 'This is option 2',
          name: 'option2',
        },
      ],
      onChoose: (name) => {
        console.log(`Choice: ${name}`);
      },
    },
]

Note the onChoose function, this would be inserted by the runner (or just be a function on the runner itself rather than being put into the ast object) to be called by the renderer to signal when an option is selected.
Phew, that was a lot. Open to thoughts/suggestions. Hopefully doing something like this could allow for a variety of sorts of projects (twine-likes, vns, "full" games) to all use this runner.

Allow me to present: a snippet of the XML file that drives Starfighter: Eclipse!
   <ParallelAction auto="true" name="_1">
      <events>
        <AudioAction fadeDuration="1" target="drone" volume=".175"/>
        <ActorFade opacity="1" target="curtain"/>
      </events>
    </ParallelAction>
    <ActorFade auto="true" name="_2" duration="1" opacity="0" target="curtain"/>
    <!--Remember what I taught you?-->
    <TextAction name="_3" text="@t_sday1intro_0"/>
    <!--No matter what happens… You keep fighting.-->
    <TextAction name="_4" text="@t_sday1intro_1"/>
    <!--I’m waiting on you. You better catch up, little brother.-->
    <TextAction name="_5" text="@t_sday1intro_2"/>
    <ParallelAction auto="true" name="_6">
      <events>
        <AudioAction fadeDuration="2" target="drone" volume="0"/>
        <TextAction text=" "/>
        <ActorFade duration=".33" opacity="0" target="textArea"/>
      </events>
    </ParallelAction>
    <ParallelAction allowInterrupt="false" auto="true" name="_7">
      <events>
        <AudioAction delay=".75" fadeDuration="2" loop="true" play="true" sound="@a_sfx_airporttarmac_6061_41" target="drone" volume="0.5"/>
        <ActorFade delay="1" duration="1" opacity="1" target="cg"/>
      </events>
    </ParallelAction>
    <ChoiceAction name="_J" varName="day1_0">
      <choices>
        <!--Yes, I’m looking for my new Navigator, are you him?-->
        <choice value="0">@t_sday1intro_92</choice>
        <!--Mind your own business.-->
        <choice value="1">@t_sday1intro_93</choice>
      </choices>
    </ChoiceAction>

Some notes here: we need to be able to issue commands that run in parallel and are logically grouped. Some commands should be terminated early by snapping to the end on click, others should block input until they are complete. Some should automatically progress the flowchart, others should wait for input. Text should allow string-key references for internationalization. The names exist to provide a stable target for loading the games. Choices save values to variables.
Might be something helpful in here.

Oooh thank you! I'm reassured by how similar your format looks to mine, and those are some really handy things I hadn't thought about

Thinking about parallel actions more. The thing about them is that the renderer is the one that actually cares about doing the actions, so that would be its responsibility. But also, the renderer is the one responsible for requesting subsequent actions, so I think parallel actions could just be achieved by the parser having a flag that could be set just as "process next action immediately". Instead of defining a block of parallel actions, the renderer would know to just request another action right away from the runner instead of waiting,  which doesn't require any extra sorts of processing on the runner's part.

Internationalization would need to be something on the parser side that can process it then just send text as an object like { 'en': 'asdf', 'eo' : 'blah' } instead of a string, then the renderer could be free to choose based on settings or whatever. Not sure how that would work specifically, maybe just a token in the language to describe the following text as a key reference rather than raw, which then gets inserted into the data before sending it to the runner.

oh also @konistehrad, are you generating that xml from something?

Thinking about parallel actions more

So this structure is the way that Fungus works presently; it can be difficult to logically group things for termination on click. I extended the Fungus Say command to act as a "sentinel" of sorts, with the rest of the system waiting on these sentinels on concurrently executing Commands to complete or waiting for input to send termination signals to those that are still executing. That said, this structure works well enough for Fungus so you might be right about that.

Internationalization would need to be something on the parser side that can process it then just send text as an object like { 'en': 'asdf', 'eo' : 'blah' } instead of a string

Actually yes this would be lovely. Packing alternate languages into the "Say" commands directly would spare me the trouble of building XML's (htmlVN) or CSV's (Fungus) and would present the end user with immediate feedback as to their location in the script in their native language. Love it.

are you generating that xml from something?

That's production game script from day1 of Starfighter: Eclipse. It was generated initially by parsing a google doc, and the actions were scripted in Eclipse (ironic, I know!). I never ended up completing the node-based editor. :<

it can be difficult to logically group things for termination on click

ahhh yes I can see how that would be. this would still be something that was handled on the renderer side, but the runner would need to handle sending blocks of commands to the renderer instead of one by one. Instead sending one by one it would be more "here's a list of things that need to be handled now"

I build an extremelyyy basic text/option selecting renderer on top of the current bondage featureset as a proof of concept: https://github.com/jhayley/bondage-renderer-test (can see it running at http://hayley.zone/bondage-renderer-test/)
There is some weird bits in processing the output and sending it to the renderer in this case, but that's because of the issues with how bondage currently outputs each step.
The interface for the renderer is essentially just a do function that takes a type of event and some options, checks to see if that event is a valid action, then passes it on to a function that performs the action. I had a nice time implementing this, it was pretty straightforward all told so I think that's a good sign??

Very cool to see some ideas exchanged around!
I'm not sure I fully grasp of the extent of the discussion, as my experience with visual noveling is pretty limited, so feel free to correct me. I think we're mostly on the same page, but the whole discussion seemed to jumbled [parser -> runner] and [runner <-> renderer] together, which puzzled me a bit.

@jhayley
But also, the renderer is the one responsible for requesting subsequent actions, so I think parallel actions could just be achieved by the parser having a flag that could be set just as "process next action immediately".

I am confused about the above JSON excerpt (is it a simple AST, as in the AST outputted by the parser? or by the runner?), and that brings two (maybe out of scope) questions here:

should the renderer really be requesting actions, rather than simply reports their completion to the runner (which would handle the flow) ?
should the runner and the renderer really talk to each other through a complex JSON structure, rather than letting the runner call the appropriate methods on the renderer directly? Are there significant advantages?

I may not see the bigger picture here but I envisioned the renderer as something providing a simple, with a standardized javascript API, really like the work jhayley did in renderer.js.
I, too, believe the runner is where all the logical magic happens. It traverses the AST outputed by the parser and when it reaches a text node, it tells the renderer to show the text and wait for the renderer to report completion. When it reaches an option link, it tells the renderer to ask the user for feedback and report the result.
As for the parallel actions, if I understand the concept properly:
when the runner stumble upon a parallel action node (PA), it resolves the child nodes of this PA and tell the renderer to perform the contained actions at once and wait for the renderer to report completion for all actions, before carrying on.
Different renderers would support different actions. For instance, the command line renderer would not support rendering sound, thus, the action would complete immediately as if it was performed. Or, maybe, as mentioned in the thread (I think), each renderer could provide a set of actions it supports and the runner would simply ignore certain nodes of the AST based on this knowledge.

should the renderer really be requesting actions, rather than simply reports their completion to the runner (which would handle the flow) ?

I think in this case we're referring to the same thing just describing it differently. I meant "request an action" in the sense of going to the runner and saying "I'm done give me another one". Thinking of it as reporting completion for the specified action makes more sense, and also lends more to the idea of things being reported back to the runner on completion (mostly of condition choices, but I'm sure there are other cases for sending data back)

should the runner and the renderer really talk to each other through a complex JSON structure, rather than letting the runner call the appropriate methods on the renderer directly? Are there significant advantages?

This makes sense. The way I've been writing my test renderers was just consuming raw json because that's basically what bondage does right now so that's how I'm describing it, but you're totally right. Though thinking about it, there may be a key distinction here: this assumes that whenever an action completes, the renderer wants the next one immediately. If a renderer could also be a larger game, maybe after an option they wouldn't need to know the following action until later? This would put the onus on them to queue the next action and just not report its completion for a while, or to delay the previous action's completion until they need the next step. I think your way definitely works better in most cases though, especially for parallel actions.

when the runner stumble upon a parallel action node (PA), it resolves the child nodes of this PA and tell the renderer to perform the contained actions at once and wait for the renderer to report completion for all actions, before carrying on.

i like this, it's a pretty graceful way to put it actually. Just tying it to the completion report mechanism means the renderer doesn't need to change its behavior and leaves it to the renderer to figure it out. Though I'm curious how this might work with things like cancellation-on-click (for example, in vns when you click the text-writing-out animation finishes early), but I think it would just be on the renderer to report that the action is complete whether or not it's stopped early and it'd work fine? At least on the runner side, the renderer might have to handle cancelling animations/etc but the runner doesn't care.

Different renderers would support different actions. For instance, the command line renderer would not support rendering sound, thus, the action would complete immediately as if it was performed. Or, maybe, as mentioned in the thread (I think), each renderer could provide a set of actions it supports and the runner would simply ignore certain nodes of the AST based on this knowledge.

Either way would work fine, but defining a list of valid renderer actions as part of the interface may come in handy in the future, and I lean towards pushing things into the runner rather than the renderer. I imagine something similar would come from the parser side, and this means the runner could compare the featureset of the parser between that and the runner. It doesn't really matter if the renderer supports more features than the parser, but it may be useful for a developer to see unusable renderer functions for the given parser.
I really like where this discussion is going, I'm starting to understand how this might lay itself out and I'm feeling good about it ^~^


refactor: exclude language in export for rasa

I fixed the domain.yml file of the export for rasa zip.

response sequences are filtered based on the selected language and the language tag is removed.

A good commit message for this one:
fix: export for Rasa: domain contains language information


SNS - PWM

TODO:

[ ] Test code in lab
[ ] Figure out the actual address of the second ecap pwm

Could you also add commands to the debug cli while you're at it?


Option to use plugin from native

Hi
I think it will be great if you can open the methods to use them in the native JAVA/Kotlin files, in addition the dart use.
In current, methods like addContact are private. So I can't call them from my Native code.

Hi I forked the repository and made some changes for mine.
You can use it as example to what I mean
https://github.com/elihaidv/flutter_contacts

Hi @elihaidv , Can you please look into to the issue #265 and let me know the problem. Or I will be thankful if you can contribute to it in case you found a solution to it. Its a bit urgent.
Thanks

Hi there!  This is a community project (my time is very limited, sorry).  Please feel free to contribute your PR for review... thanks!


Fix issue found by Coverity scan in hwcomposer

Tracked-On: OAM-106694
Change-Id: I35975116623acc39a5743e4372f64785a7c16f51

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB


feature: support shm size

Signed-off-by: Ace-Tang<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
support run commond pouch run -d --shm-size 1g  registry.hub.docker.com/library/busybox:latest top
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Oh, CI fails because of this case for many times.
FAIL: /go/src/github.com/alibaba/pouch/test/cli_restart_test.go:34: PouchRestartSuite.TestPouchRestart

Codecov Report

Merging #1542 into master will increase coverage by 21.28%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           master    #1542       +/-   ##
===========================================
+ Coverage   17.73%   39.02%   +21.28%
===========================================
  Files         214      256       +42
  Lines       14347    17421     +3074
===========================================
+ Hits         2544     6798     +4254
+ Misses      11640     9755     -1885
- Partials      163      868      +705

Impacted Files
Coverage Δ

cli/container.go
0% <0%> (ø)
:arrow_up:

cli/common_flags.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/container_utils.go
52.74% <0%> (+25.08%)
:arrow_up:

apis/opts/shm_size.go
100% <100%> (ø)

daemon/mgr/spec_mount.go
69.38% <50%> (+69.38%)
:arrow_up:

pkg/net/interface.go
0% <0%> (-89.07%)
:arrow_down:

cri/v1alpha1/cri_stream.go
0% <0%> (ø)
:arrow_up:

cri/v1alpha1/cri.go
0% <0%> (ø)
:arrow_up:

cli/main.go
0% <0%> (ø)
:arrow_up:

cri/v1alpha2/cri_stream.go
0% <0%> (ø)
:arrow_up:

... and 127 more

LGTM


Upgrading elm from 0.16 to 0.17 using Mac binary

Conditions:

Install elm 0.16 from Mac binary
Run script to delete references
Install elm 0.17 from Mac binary

Problem:
Upgrading elm from binary and running package install on a new project returns error:

Error: Unable to find a set of packages that will work with your constraints.

Solution:
Stale package is left in ~/.elm and builds a faulty elm-package.json and will prevent installing any further dependencies. I just deleted the folder and it should probably be included in the script.

This is not going to be needed with any version beyond 0.17, because of this: https://github.com/elm-lang/elm-package/commit/645fdb76de86b068857dab4303acbe9f9813178e.
That is, when Elm 0.17.1 or Elm 0.18 comes out, the "stale" ~/.elm/package will not cause any problems, because the new version will use ~/.elm/0.17.1/package or ~/.elm/0.18/package directories.

I don't have bandwidth to backport a fix.  Thanks for Elm! I put this issue up in case anyone else runs into it.


Transition pois transforms to yaml

Connects to https://github.com/mapzen/vector-datasource/issues/754
These transforms seemed like good candidates for specifying in yaml instead. The others were a little bit more involved or were applied more broadly.
@zerebubuth could you review please?

:+1: looks good to me.


cimg: 3.1.4 -> 3.1.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/cimg/versions.
meta.description for cimg is: "A small, open source, C++ toolkit for image processing"
meta.homepage for cimg is: "http://cimg.eu/"
meta.changelog for cimg is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.1.6 with grep in /nix/store/f6lph8h1g6ny0ky8wmgx6nnh2qsjjhyq-cimg-3.1.6
found 3.1.6 in filename of file in /nix/store/f6lph8h1g6ny0ky8wmgx6nnh2qsjjhyq-cimg-3.1.6

Rebuild report (if merged into master) (click to expand)

10 total rebuild path(s)

10 package rebuild(s)

First fifty rebuilds by attrpath
cimg
darktable
gimp-with-plugins
gimpPlugins.gmic
gmic
gmic-qt
gmic-qt-krita
imgcat
openroad
phash

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/f6lph8h1g6ny0ky8wmgx6nnh2qsjjhyq-cimg-3.1.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cimg https://github.com/r-ryantm/nixpkgs/archive/af36eb86c5a14886a682feac0cc1c7460bbdbede.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/f6lph8h1g6ny0ky8wmgx6nnh2qsjjhyq-cimg-3.1.6
ls -la /nix/store/f6lph8h1g6ny0ky8wmgx6nnh2qsjjhyq-cimg-3.1.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

10 packages built:

cimg
darktable
gimp-with-plugins
gimpPlugins.gmic
gmic
gmic-qt
gmic-qt-krita (gmic_krita_qt)
imgcat
openroad
phash

Maintainer pings
cc @AndersonTorres for testing.

(nixpkgs-review happy, macos 10.15 & nixos x86_64)

Please let's not get into the habit of merging things without saying what (if anything) we've tested.


Difference between -level & -q options

Whats the difference between -q & -level options ?
From the README  they both increase the quality of the output but whats their exact function and are they compatibles ?
Thanks!

Hi - "-level X" enables/disables a bunch of encoder stages that generally increase quality (usually slightly) at the expense of large amounts of CPU time. The larger the level, the slower the encoder goes, but quality doesn't improve much beyond level 2/3. Level 0 is fastest but is too low quality for many uses. Changing this option doesn't change the bitrate or compression efficiency much, if at all.
"-q X" is the main quality knob, like with JPEG's quality level. It controls the codebook sizes used to quantize the compressed texture. Larger codebooks increase the quality a lot, but also increase the bitrate. This is the main knob you use to control the quality vs. bitrate tradeoff. Larger codebooks also increase compression time.
For the most part, I suspect the two most useful quality levels are 1 and 2, and possibly 3. Level 0 is currently iffy from a quality perspective, and levels beyond 2/3 are too slow to be practical. We're aiming for level 1 (the default) to be fine in almost all scenarios.
Hope that helps.

So basically, just change the "q" option to dial in the desired bitrate vs. quality tradeoff. If you are desperate and must have faster encoding, try level 0. If you really need even higher quality, try level 2 or 3.
Note that the encoder converts the -q setting to endpoint/selector codebook sizes. If you want to directly control these codebook sizes yourself, use -max_selectors X and -max_endpoints X.

Thanks for all the explanations, very clear & useful !
It would be nice to add it in the README for other users


About “instruct inference”

I see that will del spk_embedding, spk_embedding may only use for "flow_embedding";then, when instruct inference, how to control Timbre？

you can try control timbre using prompt audio in instruct mode, but we cannot assure its quality


adds a state machine implementation for ordered_elements constraint

Issue #56:
Description of changes:
This PR works on adding an NFA state machine for validating ordered_elements constraint.
List of changes:

adds implementation of a state machine to use for validation of ordered_elements
adds changes for using nfa for validation

builds nfa using NfaBuilder and uses NfaRun to validates
ordered_elements constraint
adds a function to retrieve non negative range boundaries in Range
modifies to correctly check for overlapping types in
ordered_elements constraint (non greedy)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

As per an offline discussion, moving all the information to Transition instead of State resolves the weirdness around entry/exit condition checks on states instead having those checks to see if we can take a given transition or not.
List of change:

adds changes to store all information in Transition instead of states.
removes State as all states are now intermediate states which
removes complexity invoved with types of states
moves all entry/exit methods for State to Transition
states are now simply usize which its represents states id
NFa build process now creates a set of states that are final states or
accepted states of NFA


Preconfigure OAuth Git credential helpers

OAuth Git credential helpers are universally useful so preregister on every instance. https://git-scm.com/doc/credential-helpers
Fixes #25189

Tested, working

I'm not a fan of that approach, because even if the admin explicitly deletes that OAuth application, it reappears on restart. I don't think that's wanted behavior.
How about the following idea:

Add a (prechecked?) checkbox on installation page if OAuth applications for git credential helpers should be created
Create them directly after install
Add a gitea admin subcommand to create the OAuth applications for existing instances or if they were deleted previously

Or we can have a configuration to enable/disable the feature.

The problem as it seems to me is that our system of OAuth applications isn't made for preconfigured ones.
If we make a configuration option for this, we'd have to decide how to handle if something changes manually, for example an admin deletes one of the predefined OAuth apps while keeping the configuration parameter. This would probably result in the same thing I described in my previous comment - deleted OAuth apps reappearing again.
What we could do is creating another field for OAuth apps where we set whether they are visible are hidden in the UI.
I still think the best way to do it though would be a checkbox on the installation page, and then we maybe could add a button in the OAuth apps UI to recreate those OAuth apps if they were deleted.

if the admin explicitly deletes that OAuth application, it reappears on restart

I've added a config option to prevent the applications being recreated, though I can't think when this would be useful.

@hickford I proposed another solution in #26291. I'll close this PR for now, feel free to reopen if you don't like my proposal.


Move the "phonetic" extension to a separate repository or merge it with the "main" module

I introduced the phonetic extension in 2018 as a means to:

add support for clustering methods which had been requested (#926, #927)
demonstrate how extensions are able to register new clustering methods

I think its value as a sample extension isn't super high, first because it's kept in our repository (so it does not reflect the development practices that third-party extension developers need to adopt), and also because the dependency it uses to implement the clusterers is actually a dependency of the main module itself.
I'd be in favor of either:

migrating it to its own repository (which would mean users would need to install the extension manually if they want to keep using those clusterers)
merging it with the main module, meaning that we'd pull in the two keyers it "implements" in the core tool (which wouldn't make any difference to users as the extension is currently bundled in the official release)

I'd prefer this move into our core. Thanks!

I agree with bundling these two keyers with core and removing the extra module.