Toolbar disappears when in ui-bootstrap modal

I haven't been able to duplicate this in a fiddle, so maybe it's just my setup.
But when I use the quill editor in a ui-bootstrap modal, nine times out of ten it shows and then immediately disappears again. The toolbar, showToolbar, and toolbarCreated variables are all true.
I'm thinking that it possibly does not get properly applied, because if I initialize them with true, instead of staying undefined, then the toolbar shows up.
It works fine when I use the editor in a page or a normal bootstrap modal.

@nvernooy Can you provide us with a plnkr/fiddle, I'd look into it.

@nvernooy I might have a similar situation like you. One difference is even I put toolbar show-toolbar to true doesn't fix my problem. I have to put a timeout on showToolbar to make it work.
// omitted...
<ng-quill-editor show-toolbar="showToolbar" ....
// omitted...

$timeout(function() { $scope.showToolbar = true; }, 1000);

Yes I ended up doing something similar.
@Cordobo I'm having trouble reproducing the problem in a fiddle, I'll see if I can get something done.

I have a similar issue in a Angular Material modal dialog. I basically copied/pasted the exact same code from the example into the modal template (in the proper content section) and modal controller. The toolbar only will appear after I will click the "Toggle" button twice.

(function(angular) {
  var app = angular.module('ddAdmin');

  app.service('postModalSvc', ['$timeout', '$mdDialog', 'ngQuillConfig', function($timeout, $mdDialog, ngQuillConfig) {
    return {
      openDialog: function(ev) {
          $mdDialog.show({
            templateUrl: '/views/admin/postDialog.tmpl.html',
            parent: angular.element(document.body),
            targetEvent: ev,
            clickOutsideToClose:false,
            controller: function($scope, $mdDialog) {

              $scope.message = 'Test';
                    $scope.showToolbar = true;
                    $scope.translations = angular.extend({}, ngQuillConfig.translations, {
                        10: 'smallest'
                    });
                    $scope.toggle = function() {
                      console.log($scope.showToolbar);
                        $scope.showToolbar = !$scope.showToolbar;
                        console.log($scope.showToolbar);
                    };
                    // Own callback after Editor-Creation
                    $scope.editorCallback = function (editor, name) {
                      $scope.$apply(function() {
                        $scope.toggle();
                      });
                    };
                    $scope.readOnly = false;
                    $scope.isReadonly = function () {
                        return $scope.readOnly;
                    };
                    $scope.clear = function () {
                        return $scope.message = '';
                    };
                    // Event after an editor is created --> gets the editor instance on optional the editor name if set
                    $scope.$on('editorCreated', function (event, editor, name) {
                      console.log(editor);
                    });

              $scope.post = {
                title: '',
                content: ''
              };

              $scope.hide = function() {
                $mdDialog.hide();
              };
            }
          })
          .then(function() {}, function() {});
      }
    }
  }]);
})(window.angular);

<md-dialog aria-label="Nova postagem" ng-cloak>
  <form>
    <md-toolbar>

Nova postagem

    </md-toolbar>
    <md-dialog-content>

        <md-input-container>
          Título
          <input type="text" ng-model="post.title">
        </md-input-container>

Conteúdo:

        <button ng-click="toggle()">Toggle toolbar</button><button ng-click="readOnly = !readOnly">Toggle readonly</button><button ng-click="clear()">clear model</button>

            <ng-quill-editor name="editor1" callback="editorCallback(editor, name)" ng-model="message" translations="translations" toolbar="true" show-toolbar="showToolbar" link-tooltip="true" image-tooltip="true" toolbar-entries="font size bold list bullet italic underline strike align color background link image" editor-required="true" required="" read-only="isReadonly()" error-class="input-error"
            fontsize-options="fontsizeOptions" fontfamily-options="fontfamilyOptions"></ng-quill-editor>

    </md-dialog-content>
    <md-dialog-actions layout="row">

      <md-button class="md-raised" ng-click="answer('not useful')">
       Cancelar
      </md-button>
      <md-button class="md-raised md-primary" ng-click="answer('useful')">
        Postar!
      </md-button>
    </md-dialog-actions>
  </form>
</md-dialog>

Any updates? if not i close this issues and you can try ng-quill 2.0.1 or if you are using angular2 the total new ng2-quill component.

No, no new updates, I may try again with the new version.

thank you for the fast response ;).

FYI This still exists with "angular-bootstrap": "~0.14.3", and ngQuill 1.1.1. In the templateCache of ng-quill.js we removed ng-show="toolbarCreated && showToolbar" to get the toolbar to appear.
Just came across this bug again because I'm experimenting with an ngQuill 1.5 upgrade which deleted our workaround.

I was also able to get the toolbar to stay visible by changing a $timeout to an $applyAsync in order to trigger a digest cycle. Created pull request #69 if you want to use it.


Function with args

Is there any plan/ETA to support function calls with args/return values ?

Do you mean in the context of exported functions? For those, there is no current plan. We're open to contributions! Though we'd prefer a discussion of an implementation plan before receiving a PR to save time if there is a fundamental issue with the approach.


Kafka producer Partitioner add canAbortOnNewBatch

Partitioner add canAbortOnNewBatch method to reduce unnecessary abort new batch

Thanks for the PR. Since this makes a change to a public interface, a KIP is required. Please see https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals.


add correction for time of flight to the instrument before rev 1

This PR adds an optional check to determine if the GLM dataset being used does not contain the correction for the time of flight from a particular event/group/flash to the sensor. This results in the dataset containing information of when the signal arrived at the sensor, but not when the signal was produced in the cloud. This issue is described in the GLM Product Performance Guide as issue 3.4.2, which was fixed in ADR 333 (October 18 2018).
When reading in a GLM dataset, the date is checked to see if it was produced before the fix was implemented, calculates the time of flight to each event/group/flash's location to the satellite, and then adds this value to the event_time_offset, event_group_offset, and flash_time_offset_of_first_event and flash_time_offset_of_last_event. The following assumptions are made:

the height above the WGS84 ellipsoid of each event/group is assumed to be negligible compared to the height of the satellite
the satellite is located precisely above its expected subpoint and precisely at its height
the speed of light is precisely 299792458 m/s

This should work well enough in most cases, but the user can override this behavior by specifying fix_bad_time_of_flight=False in the call to GLMDataset.

this is only a draft for now because flash_time_offset_of_first_event and flash_time_offset_of_last_event should really be updated to match their children rather than just using a constant offset based on the flash centroid (and maybe the group_time_offset should be the same?)

Visted about this today in person, lgtm.


JS Client Support IE8？

same as title

We don't officially support IE8. See the documentation for the specific list of supported browsers.

Closing this as the question has been answered. Feel free to comment further if you need clarification on something! We can always re-open the issue if there's something to fix here.


[BUG] Investigate error when publishing certain Contributions

Describe the bug
Some Contributions created using Postman are not getting published. E.g., https://api-dev.rokwire.illinois.edu/catalog/contributions/628d35a1cd1727000a1659e1
To Reproduce
Steps to reproduce the behavior:

Create a Contribution using Postman
Review and publish the contribution from Catalog
See HTTP 400 error in Catalog.

Expected behavior
We should be able to publish Contributions created using Postman as well.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

This issue is present in the develop branch and can be replicated in local as well.
The issue arises when posting a talent with null fields. When a talent is POSTed  with only the required fields, the rest of the fields are saved with value null. However, those fields are not nullable as per yaml file. So when a PUT is performed (which is done when the status is changed from Submitted to Published), the field does not match the yaml requirements (nullable vs string fields) and hence throws a 400 error.


CAN DBC to WoT

Has anyone thought of converting from a CAN DBC file to WoT and then using this against a device that speaks CAN?

I don't think so.

does CAN DBC contain address information or only data CAN-based data values?

The DBC file is CAN IDs and data. https://www.csselectronics.com/pages/can-dbc-file-database-intro
I am very ignorant aobut this source so please forgive me but are the addresses necessary? Most times you simply get on the network and start decoding messages. I have always thorught of it in a broadcast mode :-)

Just so everyone knows, we are looking at creating a CAN -> OPC UA protocol/message translator. This project seems to do a lot of what we need and I already have a whole library that does CAN decoding. Just asking questions before I decide whether this project is the right place to extend and leverage the work here or simply build a bespoke translator

Extend this project, of course! :-)


steps and screen shots are out of date 08092020

[This page is useless as is.. It needs to be updated with new screenshots and steps.]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15519820-cfab-94be-5ba9-b5e2e414e090
Version Independent ID: 05bcd0da-3a8e-9b6f-ae77-025d4aa9782f
Content: How to provision devices for multitenancy in Azure IoT Hub Device Provisioning Service
Content Source: articles/iot-dps/how-to-provision-multitenant.md
Service: iot-dps
GitHub Login: @wesmc7777
Microsoft Alias: wesmc

@SteveSilver Thanks for the feedback. I have assigned the issue to the content author to evaluate and update as appropriate.

@SteveSilver Thanks for your feedback. Substantial changes have been made to the article in the PR mentioned above. Can you let me know if you have any additional concerns? I'll leave the issue open for a week or so, and then close it. Thanks again for your help with our documentation!
-Jimaco

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
Please also do visit Microsoft Q&A the home for technical questions and answers at Microsoft.


tagged release?

This looks like a nice library! Have you considered making a tagged release? Before the first release, it might be nice if you renamed the module to github.com/marinx/monerorpc (lower case to follow best practices).

Hi @dimalinux .
Thanks for the comment.
Yes, I will tag it - great suggestion.
I will tag when I fix other open issues.

tagged with v1.0.0 (included updates)
I dont want to break things so for now, it will be as it is.


feat: add taglist limiter

adds wrapper around tagList to limit number of visible tags

@thomasthesecond I moved this logic into the TagList. Thanks!


⚠ Bofrost.lu has degraded performance

In 4d03d02, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2009 ms

Resolved: Bofrost.lu performance has improved in 185e5fd after 27 minutes.


Promise functions run twice, depending on how chaining is performed.

I first encountered this in Knex. I have a SQL query that just selects the next number from a sequence. This is basically something like  select nextval('myseq'). When I return the promise from the knex.raw call and I use .then and .catch I get double call behavior depending on how I attach the calls.
For example:
var promise = knex.raw('select....');
promise.then(myfunc);
promise.catch(handleerror);

This will make the select call run twice and return however if I write.
var promise = knex.raw('select....');
promise.then(myfunc).catch(handleerror);

The select call will only run once.

This is not related to Bluebird. Knex queries are "thenables," meaning that they're not true promises but they return promises when their then methods are called (or aliases like catch).
Chain your method calls. Otherwise this is expected behavior. There will be a way to address this with WeakMaps so that your original example fires one query. Without them, providing that behavior would represent a memory leak. So for the time being and a decent while longer, you need to fix your code here.

To chain with variables you need to keep reassigning:
var promise = knex.raw('select....');
promise = promise.then(myfunc);
promise = promise.catch(handleerror);

Promise chaining is different from jQuery chaining because everything returns a new promise while jQuery methods return the same object.


Please, migrate this project to Swift 3

Please, migrate this project to Swift 3
I really need!
Thank you!
Can anybody help me?

Yes

https://github.com/processone/xmpp-messenger-ios/pull/75


Support multiple QR code configurations

Hi there! Great library! What about moving the Symfony bundle in another package? In addition, I would add more configuration like this:
endroid_qr_code:
    my_qr1:
        size: 100
        padding: 10
        extension: gif
        error_correction_level: medium
        foreground_color: { r: 0, g: 0, b: 0, a: 0 }
        background_color: { r: 255, g: 255, b: 255, a: 0 }
        label: 'My label'
        label_font_size: 16
    myqr2:
        size: 250
        padding: 10
        error_correction_level: high
    # ...

$this->get('endroid_qrcode.myqr2')->createQrCode();

It seems that it has been abandoned: https://github.com/endroid/EndroidQrCodeBundle, but thanks for having asked this question, like this, I've been able to update my code to the main library.

Hi @gremo I think it is indeed better practice to separate the bundle but I decided to put the bundle in the library for reasons of maintainability and I think I will keep it that way unless I experience issues with this set up.
I think it's a good idea to support multiple configurations. I will try to incorporate this any time soon. Of course you can also create a PR for this if you like. I will rename the title and categorize this issue as enhancement.
Thank you!

@endroid I'll work on PR, but I think you should reconsider to suppor that bundle. I can collaborate in my spare time.

@gremo I will decide before July on whether to maintain a separate repository for the bundle or not. For now it resides in the library. Please let me know if the current set up gives you any problems.

Please read https://speakerdeck.com/fabpot/a-monorepo-vs-manyrepos.
You can have one monolithic repository you can split easily with https://github.com/splitsh/lite

Thank you, I will loot at it.

This is possible since the 4.0.0 release.


Autoload.php load doesn't work, the directory must be src not lib

For autoload working is necesary the change.

You are right, but I advice you not to use v2 right now, though it's more stable, it's not going to be released and maintained. Instead I started to do something better. That should come by the end of the month

Okey, I will wait. I am excited about the new software :)


added logo in title bar

Thank you for your contribution but you were not assigned to create logo also logo is not shown in the current build
So I am closing this pull request


layouts/sitemap.xml first character gets substituted

Describe the bug
When a custom sitemap.xml file is present in /layouts/ the generated sitemap.xml files have the first character (<) substituted with <
To Reproduce
Steps to reproduce the behavior:

Create a custom sitemap.xml file in the /layouts/ directory
Run command hugo to build the site
See first character of newly generated sitemap.xml files

Expected behavior
layouts/sitemap.xml 's content is copied in every built sitemap.xml file without the first character being corrupted
Technical details:

Hugo Version: v0.72.0-8A7EF3CF
Browser/OS: Windows 10

Using theme Academic

This is a quirk with Go's templates, and I don't think you will convince them that it's a bug.
See this for a workaround:
https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/embedded/templates/_default/sitemap.xml#L1

Thanks for the workaround @bep
Ever since this problem started appearing, something else started happening: when building the website many new random newlines are added to all generated html files, do you happen to know if these things are connected?


How to Style?

I tried adding this to a custom renderer:
case 'text': {
      return (
        <FieldText
          {...field}
          className='mainForm'
          shouldFitContainer='true'
          autoComplete='off'
          onChange={(event) => onChange(id, event.target.value)}
          onFocus={(event) => onFieldFocus(event)}
        />
      );
    }

But it doesnt seem to add the form and the elements i want to change are on the div above the input anyway.
.mainForm {
  width: 100%;
  border: 1px solid #999999 !important;
  border-radius: 5px;
  background: #f3f8f2 !important;
}

Is the FieldText component you've used in the example you've provided one of your own or is it the Atlaskit component? If it's the latter then the issue is likely to be that the className attribute it not a valid property for that component or is being obfuscated due to implementation via the Styled Components CSS-in-JS implementation.
If you want to style an element then you'd be better off wrapping the component in your own div element such that the CSS class is not obfuscated and then your selector will match. You might need to adjust your selector to target elements nested within the element containing your CSS class.
This isn't really anything that the React Forms Processor project can do anything about as it doesn't control the implementation of the fields that it ultimately renders - by design.

I'm going to close this issue as there's been no follow up on it.


chore(deno): use the latest jsr libraries for testing

Update libraries for writing tests in #3367. Also, this PR removes unnecessary code.
The author should do the following, if applicable

[ ] Add tests
[ ] Run tests
[x] bun run format:fix && bun run lint:fix to format the code
[ ] Add TSDoc/JSDoc to document the code

@ryuapp
We needed to do this. Thanks!


ICallbackMsg error

I get this error all the time I try to build the SteamBot project. I dont know what to do know. Can you help me? My error:
Severity	Code	Description	Project	File	Line
Error	CS1061	'ICallbackMsg' does not contain a definition for 'Handle' and no extension method 'Handle' accepting a first argument of type 'ICallbackMsg' could be found (are you missing a using directive or an assembly reference?)	ExampleBot	C:\Users\Me\Documents\GitHub\SteamBot\SteamBot\Bot.cs	715

You installed incorrect SteamKit version from NuGet. You'll need 1.6.2.
https://github.com/Jessecar96/SteamBot/blob/master/SteamBot/packages.config#L5


Load post comments API integration

Addresses these issues:

Note: the Load More button doesn't disappear but becomes disabled and says No More Comments Found when there are no more comments to load. Having a button suddenly disappear is not good UX imo.
Closes #550
Closes #713

Hey @BMariscal thanks for this. I'll take more of a look at the code tomorrow but one UX/UI comment for now, if it's out of scope & a different PR let me know.
The comment button in /feed - it acts kind of like a like button, which doesn't make sense. Either it should just be a count OR a button where clicking takes you into comment within the PostPage.

@joshmorel  thanks! I'll make it redirect to the comments in the post's page

@BMariscal for logged in users this is looking good.
For not logged in however - isn't the expected behaviour to resolve issue #713 to redirect them to login?

For users unregistered or not logged in
Expected: The posts are limited to 25 words --> User clicks "View More" --> User is directed to sign up page
Fix:
When "View More" is clicked --> user is directed to sign up page

Right now it is going to the post:

Also on the feed I get a bunch of errors in the log - because of https://github.com/FightPandemics/FightPandemics/blob/52dcf9553e3e3747e71da562d113e2a60b623bca/client/src/components/Feed/Post.js#L122  (the route requires auth). I think we should just skip this if !isAuthenticated

@joshmorel I'm waiting for a confirmation on this but I think the expected behavior (I've asked before) is for anyone, registered or not, to be able to see the post's full content and to not be redirected to the sign in page. I do need to fix the access to the comments for users that are not logged in, thanks for pointing that out!

@joshmorel Product got back to me and you're correct! Users who are not registered should not have access to the post's full content. THANKS!!  I'm working on the implementation rn.

Including this ticket as well: https://github.com/FightPandemics/FightPandemics/issues/757

omg omgomg!!


[$500] Login - Clicking the eye icon moves the cursor to the beginning

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Enter an email address
Press continue
Enter the password
Click to the eye icon

Expected Result:
The cursor should not moved
Actual Result:
The cursor moved to the beginning
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/196955840-36e347cf-f392-43c0-8b63-822710a9d4d6.mp4
@Julesssss removed the capture as it was an unrelated recording
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Yep, I can reproduce. @kbecciv would you mind re-uploading a video? I think you uploaded a different bug, so I removed it.

Oh, thanks for linking! While I agree with most of that discussion we've recently decided to try fixing each and every bug we encounter. For that reason, I think we should reopen this and see what sort of proposals we receive.
If the solution is very convoluted, then maybe it would be preferable to just default to the end, given that mobile and some web browsers do this by default.

@Julesssss Video is attached, sorry for missing it.

Thanks, no worries

Awaiting proposals

link to the internal job posting: postinghttps://www.upwork.com/ab/applicants/1584804132817670144/job-details
link external job: https://www.upwork.com/jobs/~017777eb694223c27d

Apparently the cursor resetting is just react-native internal behaviour, I tested on snack and got the cursor going to the beginning as well. I tried to fiddle around with other textInput components which was unsuccessful but I think that would be unnecessary and just add extra code. This was the solution that was the simplest and most importantly added the least amount of code. And is much more reliable than relying on a third-party component.

I agree we don't want to depend on 3rd party component for this. I'm coming around to the manual setting of cursor, but want to leave the issue open a little longer.

Holding for any last proposals

Posted in slack re next steps.

Hey @Julesssss now could we move ahead with that solution?

Yep, seems like this is the best solution we have.

Oh, thanks for mentioning @aimane-chnaif. Would you mind explaining further?
As far as I can tell the proposal would only set the cursor on toggle, but maybe I'm missing something?

Actually @Someone-here, sorry to halt hire this but there are a couple of issues:

and will also do some extensive research on all possible solutions to this.

We need to approve the proposal before sending you off to investigate. Ideally the investigation occurs beforehand, so that we can properly compare solutions.

I missed this previously, but the video shows a delay in the cursor being set (at 11-12 seconds). I'd say it's better to have the current bug than to show a laggy movement of the cursor.

As @aimane-chnaif mentions, the solution relies on setTimeout AND we lose the current position of the cursor.

I'm going to unassign for now, but we're open to any alternative solutions.

@flaviadefaria would you mind doubling the bounty? The solution will require more thought.

I found a way to remove the setTimeOut as well! We can just pass the function as an argument to the setState, which will not result in that delay

Just let me think of a proper solution to preserving the cursor position and I'll write another proposal.

@flaviadefaria would you mind doubling the bounty? The solution will require more thought.

@Julesssss done!

I made it so the position of the cursor stays the same as well by using the existing this.state.selection
https://user-images.githubusercontent.com/77237602/200622247-f2e0d49b-238f-465f-9574-7fbf9cd788e4.mp4
Now the only thing left is removing the setTimeout, turns out that the setState is for some reason not calling the callback function.

Issue not reproducible during KI retests. (First week)

Is it essential to remove setTimeOut from the solution?

Ok, I removed setTimeOut, and even removed the manual selection. Turns out that if we change the state for the password right in the onMouse down rather than onPress, that solves the problem on web.

https://user-images.githubusercontent.com/77237602/200888208-2e8bc1ed-d701-4b99-bc45-aa6b6fdbf24e.mp4
Now only left to figure it out on Android and ios. Actually I have a windows machine and cannot get the Android app to run, this might not be the right place to ask but could you please tell me the steps to run it on windows? I have WSL also if that's needed.

Actually I have a windows machine and cannot get the Android app to run, this might not be the right place to ask but could you please tell me the steps to run it on windows? I have WSL also if that's needed.

In my personal experience, it will be much faster to install linux as a second system, windows is tricky

Based on this comment I'll try to reproduce this again to see if it's still an issue.

Issue not reproducible during KI retests. (First week)

This is fixed on chrome, in the last comment by me. Since I don't own a macbook would someone like to collaborate with me to find a solution for iOS as well?

This is fixed on chrome, in the last comment by me. Since I don't own a macbook would someone like to collaborate with me to find a solution for iOS as well?

I can test your branch on iOS if you already have a solution
If not, I can recommend using macOS instances, we have a handy guide: TESTING_MACOS_AND_IOS.md

Okay, I tested on ios using snack https://snack.expo.dev/CPp4q2OGd and it is just native behavior for the cursor to go to the end. Even if we want to fix this, we would need a work-around from this which would require having a separate selection state and also setTimeOut because there is no react lifecycle hook that can update the selection state predictably after the component updates.
If we decide to use setTimeOut, then this can be fixed on iOS. On chrome it works just by toggling the secure state in the onMouseDown event instead of onPress because onPress is designed for mobile platforms where as onMouseDown is for web.
So how should I proceed now? In my opinion, we should just fix this on chrome and on iOS, the cursor is still at the end not the beginning, so it wouldn't be worth having a workaround for just preserving the cursor state when in between the text. But it can be any way you require. @Julesssss

for chrome we can streamline it with android just by calling this.togglePassword in the onMouseDown event instead of onPress event

@Someone-here, I think that would break the accessibility, you wouldn't be able to toggle password visibility using keyboard

@eVoloshchak, I fixed that too, I added both events onPress and onMouseDown and now it works on all platforms and can even be changed by keyboard also

@Someone-here, that's great!
Could you please post an updated proposal?

PROPOSAL
Option 1: (Web)
We can call the this.togglePassword method in the onMouseDown event as well as onPress event. This will preserve the cursor position on all devices except iOS.

In iOS, the native behavior is to set the cursor to the end to the input even when the e.preventDefault method is used. But this is very minor as the cursor doesn't even reset to the start, it stays at the end. Only if you keep the cursor in the middle will you notice the difference.
Option 2: (Web, iOS)
We can overcome the native behavior by keeping track of the selection in a special state that can be used to update the component after click. Since there is no react lifecycle hook that can precisely execute the setSelection when the TextInput
updates, we would wither have to create a wrapper component specially for that or use setTimeOut.
Here is the result after using Option 1:
https://user-images.githubusercontent.com/77237602/201742108-c7e978fb-74e7-4924-83fe-86e0e57c2a40.mp4

@Someone-here's proposal looks good to me. But I still feel like we should try to achieve the same behavior on different platforms. We try to avoid using setTimeOut unless absolutely necessary, is there another way to make it work?

I tried all the lifecycle hooks and component events, unfortunately none of them execute after secureEntryText is changed. So in order to execute a function after that, we will have to use setTimeout. But it very reliable and not very noticeable as the delay would be set to 0ms.

@Julesssss, we have a proposal that streamlines behavior on all platforms except iOS. There it uses the native behavior of setting the cursor to the end. It seems like it's impossible to overcome this without using setTimeount, but still, should we wait for more proposals?

I'm leaning towards option1 for now, then treating iOS as a separate, lower-priority issue. It doesn't seem like we have any good alternatives here

Yes, I think Option 1 is better as well. Better to keep it at a minimal solution

I'm leaning towards option1 for now, then treating iOS as a separate, lower-priority issue. It doesn't seem like we have any good alternatives here

In that case, let's go with @Someone-here's proposal (option 1)
🎀👀🎀 C+ reviewed!

Waiting for PR to be merged.

Made the PR: https://github.com/Expensify/App/pull/12941
Please review

@eVoloshchak or @Julesssss Could you please test this proposal on iOS and Safari? I don't own a mac currently, therefore it would mean a lot to me if you would do so...

Reviewing the PR today

@eVoloshchak @Julesssss Sorry for the inconvenience but I closed the PR by mistake while trying to sync the repo with main. Let me just open a new PR for that

Here is the new PR: https://github.com/Expensify/App/pull/13103
Please review.
I hope this didn't cause much of an issue.

Bump @eVoloshchak @Julesssss!

Reviewing

Seems like this introduced this regression, so I'm going to have to revert it.

I'm really sorry for this. I'll fix it asap

No worries. I also missed this.

I found out a solution. Should I make a new PR?

I found out a solution. Should I make a new PR?

Yeah, just give me a few minutes to revert the previous changes to unblock our staging build. It'll be a few more minutes, and then you can raise the PR against a clean main branch.

@Someone-here all done, no rush with the new PR as I won't be able to review until next week

Okay, thank you for giving me another chance. I will do extensive testing before submitting PR this time.

Made a new PR https://github.com/Expensify/App/pull/13317 This fixes the regression. I have done extensive testing with checkboxes on all platforms as well. I hope this serves its purpose this time...

Heads up I'm heading OoO for a week so in case this needs to be paid out before I come back then please reassign or ask someone else in the team to process the payment. Thanks!

I decided to close the outstanding PR on the second review as it's adding quite a bit of complexity to the Checkbox component. Explained a bit more here.
@flaviadefaria could you please pay out the original contract on Monday? We had a regression so I believe it will be 50% of the payment

It also was merged within ~8 days, which is a 50% penalty
I don't think I'm eligible for any payment on this one, there were a couple of regressions I could have noticed, we've dragged this out for more than 2 weeks, I don't want to get paid for this one

Fair enough, thanks @eVoloshchak but you still reviewed the PR originally so I think the reduced payment is fine.
Honestly, I'm not sure the 12-day rate counts here due to the regression.

Guys, I am really sorry if you think I did not do upto to the mark but I tried my best....

Hey @Someone-here don't worry. I should have called it out earlier in the process and maybe we could have discussed alternatives. Let's just move onto the next issue 👍

Great! Thank you for the positive attitude

We'll be paying out $250 for each of you (50% penalty). I've sent you both the contract offer in UW please accept and let me know here once done. Thanks!

Everyone has been paid so closing this out.


Query logged in user (self) on GraphQL API

What I'm trying to achieve
Query the API for information on the currently logged in customer. Currently, only staff are allowed to query information on users. Customers should at least be able to query their own information.
Describe a proposed solution
Allow customers to query their own profile information.
Other solutions I've tried and won't work
This is possible using the tokenVerify mutation, but using a mutation to query information isn't convenient. It cannot be used with relay's QueryRenderer for example.

I think it's possible to retrieve a user's information if a valid token is provided.

That only works for me if the token is for an admin user. With a customer token, I get an error saying I do not have permission to perform the action.

Looking at the code in https://github.com/mirumee/saleor/blob/master/saleor/graphql/api.py
    @permission_required('account.manage_users')
    def resolve_user(self, info, id):
        return graphene.Node.get_node_from_global_id(info, id, User)

    @permission_required('account.manage_users')
    def resolve_customers(self, info, query=None, **kwargs):
        return resolve_customers(info, query=query)

    @permission_required('account.manage_staff')
    def resolve_staff_users(self, info, query=None, **kwargs):
        return resolve_staff_users(info, query=query)

Yeah, the queries require admin permissions

It would seem the addressCreate mutation and possibly other address management mutations only allow staff access as well.
    @classmethod
    def user_is_allowed(cls, user, input):
        return user.has_perm('account.manage_users')

Since the user model itself lacks some fields I need in my use case (name, phone), I've found it convenient to use the first address instance to store those information. It seems reasonable to me that the user should be able to update their address as well.

Hey @khalibloo, thanks for reporting those problems! You're right - user-related mutations and queries require staff permissions as we wrote them with Dashboard 2.0 in mind. Of course, this should be changed as you suggest - authenticated customers should be able to fetch their account data with user(id:"") query as well as to modify their addresses.

Managing customer addresses (other than defaultShippingAddress and defaultBillingAddress) still require admin permissions. Is this by design? Otherwise, I'd expect mutations like addressCreate, addressUpdate and addressDelete to be accessible to the logged in user.

Right, we're still missing it. I'll open a new issue for that.


feat(dataclasses): add dataclasses integration

Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

[X] I have raised an issue to propose this change (required for new features and bug fixes)

Resolves #122
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[X] I have read the CONTRIBUTION guide. (required)
[X] My change requires a change to the documentation.
[X] I have updated the tests accordingly. (required for a bug fix or a new feature)
[X] I have updated the documentation accordingly.
[X] I have reformatted the code using make format. (required)
[X] I have checked the code using make lint. (required)
[X] I have ensured make test pass. (required)

Any updates on this? Can I help?

Any updates on this?

Thanks for pinging this. The PR is almost done. I will add some unit tests and get it merged this weekend.

:fire:


Change name from maesh to traefik mesh

Description
This PR changes he following:

Change name from maesh to traefik mesh at almost all of the places except the published docker images as they are controlled from github secrets.
Enable creating namespace if the namespace doesn't already exists.

Tests done (within the container):

[x] Installing and uninstalling traefik mesh
[x] Installing and uninstalling sample app (emojivoto)

Note for reviewers

@utkarsh-pro we have a Kudo/kuttl issue to investigate - https://github.com/layer5io/meshery-traefik-mesh/pull/64/checks?check_run_id=1633826926

@utkarsh-pro we have a Kudo/kuttl issue to investigate - https://github.com/layer5io/meshery-traefik-mesh/pull/64/checks?check_run_id=1633826926

@ramrodo we might need some of the magic CI (go proxy) sprinkles here.

@ramrodo we might need some of the magic CI (go proxy) sprinkles here.

Green checkmarks! 😅 Thank you, @ramrodo

Green checkmarks! 😅 Thank you, @ramrodo


sitemap redesign

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--moleculardevices--hlxsites.hlx.page/sitemap
After: https://sitemap-update--moleculardevices--hlxsites.hlx.page/sitemap

Hi All,
Please review and approve PR to update sitemap as per below docs.

sitemap (1).xlsx
Regards,
Rajneesh


Data models

Add the models for the event types.
It contains:

An EventType enum, represents all the event types.
An EventData class, inherits from pydantic.BaseModel.
A class for every type of event, inherits from EventData and specifies the required data for the type of event.
An Event class, puts together the event type and data.

What about the status_code? Websockets can have custom codes in the 4000 range. We currently send 1 error back to the client  when they join a room that doesn't exist

Do you want to remove:
class ConnectionEventData(BaseModel):
    """A model representing the connection event data."""

    message: str
    difficulty: int
    room_code: str
    connection_type: Literal["create", "join"]

class ConnectionData(BaseModel):
    """A model representing the initial connection."""

    type: str
    data: ConnectionEventData

from main.py in this PR or create another for that?

Do you want to remove:
class ConnectionEventData(BaseModel):
    """A model representing the connection event data."""

    message: str
    difficulty: int
    room_code: str
    connection_type: Literal["create", "join"]

class ConnectionData(BaseModel):
    """A model representing the initial connection."""

    type: str
    data: ConnectionEventData

from main.py in this PR or create another for that?

We might as well remove it here.

What about the status_code? Websockets can have custom codes in the 4000 range. We currently send 1 error back to the client when they join a room that doesn't exist

I made another PR for this, checkout #42 .


function request

Hi, thnx for this nice plugin.
Can you add an option for an action after hitting the button to play/listen or view a mediafile?

Do you mean something like onPlayStart for audio and video ?

(my english is not so good.)
Yes i need it also for the PDF.
In my specific case i need to render a column on the page where your addon expands the video/pdf.

Nice suggestion. I will add those features  :+1:

:+1:

I guess your problem is solved now. :smiley:

Thank you !


Updating reference to yaml file in manifests folder

Description
Updating reference link to point to correct file location
Motivation
For better readability of documentation

thanks
/ok-to-test
/lgtm
/approve


Improve pagination when using browser's back button, so pagination isn't reset

For example, a Users page has a table with 10 pages worth of users, you go to page 4, decide to click on a user and are re-directed to that user's page. You decide to hit browser's "back" button to go back in history to the Users page again. I would expect the table to show the 4th page of users, where you last left off in this scenario, but instead the table is reset.
I thought of doing some thing like create a temporary redux store to cache page and pageSize per table, but this is difficult because I only want this to work in the event you go back in browser's history to a previous table's state. Otherwise, I think it is right to reset the table's pagination state on componentWillMount.
Is this not something react-bootstrap-table should be responsible for maintaining? Or is this outside the scope of this plugin, since it may involve working with react-router?

@jflayhart, sorry for lately reply due to my long trip ;)
cache the current page and sizePerPage in redux and restore it by options.page is also a solution, there're some people do the same thing but he cache the sorting status
but for react-bootstrap-table, I've no too much idea to cache these status(page, sort, bla bla) and I'm not very sure that whether the others table component or other widget(tabs, select, list) support this kind of feature, if you see you can tell me. Anyway, this is not very important feature currently, but it's pretty worth to do for a improvement reason but need a good solution.


Scan all duplicate artifacts which set hide to true

This is a follow up PR for https://github.com/Azure/azure-sdk/pull/2305/files.
If we have duplicate artifact names, we currently only check the first artifact set Hide to true or false.
Expect behavior, we iterate all duplicate artifacts and leave the one with Hide to false

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

/check-enforcer override


Add documentation on how to synchronize non-default streams

Problem statement
As a Developer, when I read https://docs.rs/cudarc/latest/cudarc/driver/safe/struct.CudaStream.html, it is not clear how I can use cudarc to synchronize work across non-default CUDA streams.
Solution
In this PR, I added documentation for how to synchronize many non-default streams.
Context
In my previous PR https://github.com/coreylowman/cudarc/pull/254, I thought that CudaStream streams were thread-safe.
My understanding was incorrect.
@coreylowman then kindly pointed that usually one achieves on-device concurrency by launching from the same host thread several CUDA kernels on several non-default non-blocking CUDA streams. So I read the CUDA documentation about streams to determine how to achieve this with cudarc.
cudarc uses the CUDA events API to synchronize work.
Use case
I use cudarc with this approach in my novigrad project (GPU Scheduler, DeviceStream) and it works very well apparently.

Thanks for this!


Remove version: REALiX.HWiNFO version 8.00

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/hwinfo/files/Windows_Installer/hwi64_800.exe/download
OK
(Automated message - build 923)

URL: https://sourceforge.net/projects/hwinfo/files/Windows_Installer/hwi64_800.exe/download
Status Code: 200
(Automated message - build 903)

Close with reason: Duplicate;


Text is tiny

I tried using this with TextMesh Pro, and the text appears tiny (like a few pixels high, completely not readable). I am seeing a value of 0.174418598 as the pixelsPerUnit size, so my size 15 text ends up being sent to setFontSize as a very small number.
Do you have any thoughts as to the correct way to address this?

Hi!
Sorry for the long delay, been away on vacation.
I haven't tried this with TextMeshPro, did you alter the code to get it to work ?
And is a normal textmeshpro input field working as expected?
The plugin never uses the unity components, it adds a os native element on top of unity, and then adds back the result to unitys input component after it lost focus.

I have tried to switching away from TMP to using native Unity and it seems to be going a bit better, so please ignore this for now whilst I investigate further.


Certain ID schemes can become mixed up with barcodes during sorting

Bug Description
Discovered by Nick Youngblut on the forum.
If IDs have a scheme which overlaps with barcode segments (e.g. "idX_Y" and just "idX"), the sorting performed on the forward and reverse reads may no longer match IF the barcode IDs differ between forward and reverse reads (as is the case when a fastq manfiest format is used, or in the case where the barcodes are bases etc).
Steps to reproduce the behavior
Consider the sorting on these IDs
# file_name: number_of_sequences
./V130_166_L001_R1_001.fastq.gz: 295
./V130_2_167_L001_R1_001.fastq.gz: 6069
./V130_2_743_L001_R2_001.fastq.gz: 6069
./V130_742_L001_R2_001.fastq.gz: 295

This will spuriously pair up V130-forward and V139_2-reverse. Note that the sample ID is V130 NOT V130_166 as it might initially appear.
This results in an error like so:
Error in (function (fn, fout, maxN = c(0, 0), truncQ = c(2, 2), truncLen = c(0,  :
  Mismatched forward and reverse sequence files: 6069, 295.

Expected behavior
For V130_166_L001_R1_001.fastq.gz to be paired with V130_742_L001_R2_001.fastq.gz and so on.
Questions

Is there a better way to provide paired-end data to DADA2? Right now we are providing two directories which DADA2 must be sorting and pairing.
If not, should this bug be moved upstream?
Can we confirm that the MANIFEST file in the data directory has the correct information, if so, could we use that instead of the filenames to determine pairing?

References

https://forum.qiime2.org/t/qiime-dada2-denoise-paired-naming-bug/6385

cc @benjjneb

Sorry, it looks like the input are actually vectors, so we can arrange them as needed in the script.

I'm not sure I full understand the issue, it looks/sounds to me like we have a situation along the lines of this:
There is one directory containing forward reads and one containing reverse reads. These directories are both sorted. The files within the directories are matched up pairwise under the assumption that the forward and reverse reads will have sorted in the same order. In this instance we have a forward read directory that goes 130 then 130_2 because 130_166 sorts above 130_2, but in our reverse read directory we have 130_2 then 130 because 130_2 sorts above 130_742?
If that's the case, ensuring we get proper sorting in all cases sounds like a real pain. I don't 100% know the naming conventions for these files, but I guess we could split on _ and use the resulting elements to aid in sorting? Like in this situation the 130_2 ids would have one more section than the 130 ids so maybe we just put them at the bottom? And then if also had 130_3 or 130_4 or whatever we could do a secondary sort on that second element?

You are understanding the problem correctly. What we need to do is find a reasonable way to provide the order to the R script. For instance passing and parsing our internal manifest in R (CSV parsing in R is a bit idiosyncratic, but it's definitely workable). Then using that to define the order/pass the reads into DADA2. Basically we need to move some business logic into R to make sure the samples are paired up correctly.
An alternative would be to rename the files such that only the sample IDs are present, preventing the barcode segment (that second part of the _ in your example) from breaking the ordering between forward and reverse.
Really we can do anything here between the R and Python boundary, we just need to do something...


Investigate using Nathonius instead of OfficerHalf

This would likely mean updating other plugins as well

Other plugins have been updated.


not work with physics NeverScrollableScrollPhysics

Describe the bug
not work with physics NeverScrollableScrollPhysics
To Reproduce
child: InfiniteList(
   physics: const NeverScrollableScrollPhysics(),

Expected behavior
work with physics NeverScrollableScrollPhysics

Hello @erlangparasu, thanks for opening this issue.
I could not reproduce this. After adding NeverScrollableScrollPhysics  to our example app, the scrolling was deactivated as expected.
Can you provide as reproducible sample (flutter app) for this?

Hey @erlangparasu since this seems to be silent for a while, i am closing this for now. If anything comes up, dont hesitate on telling.


Building in chroot results in error message

I get the following error message when building in chroot (aursync -c):
==> ERROR: Working directory '/var/lib/aurbuild/x86_64/root' already exists

 sudo rm -rf /var/lib/aurbuild/x86_64 results in
rm: cannot remove '/var/lib/aurbuild/x86_64/root/var/lib/machines': Operation not permitted
rm: cannot remove '/var/lib/aurbuild/x86_64/brian': Operation not permitted

Any help is appreciated, thanks!

What file system do you use? I have btrfs, so in my case these are subvolumes, which I can see with btrfs subvolume list / and delete with btrfs subvolume delete /var/lib/aurbuild/x86_64/brian.

Yeah, I used btrfs at some point in the past and remember having similar issues... if the chroot wasn't created successfully (i.e., the .arch_chroot file is not present) the subvolume was created anway.

That was exactly it. I forget sometimes that I'm using btrfs, between snapper and snappac everything is automated for me.
Thanks guys!


docs: edited grammar for clarity on README

The notice about how to ask for help and expectations was confusing because of idiomatic expressions that were not used quite correctly. Edited for clarity.

Hello @stephencweiss, this library is not maintained more than a year. I would advise you to look at our new version @react-google-maps/api https://bundlephobia.com/result?p=<EMAIL_ADDRESS>https://www.npmjs.com/package/@react-google-maps/api
We have rewritten it to typescript, and get rid of most of dependencies. APi does get changed, and now we have react hooks support

@JustFly1984 thank you so much! I will absolutely check that out. Cheers!


Representative presenters for works with many files

If you have a work with many files, 25 or more, you could run into this:
https://github.com/projecthydra/curation_concerns/issues/1144
I'm seeing with a work that has 98 files in it and the page just doesn't load and eventually errors with a 500.

Fixed in 9bd55ed586b6a23f0c5e4f145ec22b5ba0e73923


Basic navigation routes

Changes
Added the basic navigation routes for the app.
I've included a demo page for the activity page that show how the stack navigation for each tab-page works.
I've also changed the slug name in the app.json to comply with the specification requirements.
Issues
I would appreciate if someone else could test to build this branch and runt it on their own phone using the Expo Go app to see if the following issues (or others not mentioned) are present:

Switching fast between tab-screens can sometimes cause the content/header to "flicker" (turn white for a split second).
The bottom navigation can on some devices not detect a proper safe-area making it be obscured by the native UI elements.

Feedback
If you are able to find a solution to any of the known issues please feel free to post a solution.

I got it to work! Looks amazing!
I could not reproduce any of the issues on the web, which may or may not be good. But I did notice the button on the main page stopped working after clicking around a bit.
Also.. should the lock file be kept? I thought it was supposed to, but it might not matter. In that case we should add it to the .gitignore.

I could not reproduce any of the issues on the web, which may or may not be good. But I did notice the button on the main page stopped working after clicking around a bit.

The issues i mentioned are only present on mobile devices AFAIK and i stuck to only testing it for mobile since i found the same issue with the navigation as you did. I think it has to do with that @react-navigation/native and the web build but im not 100% sure.

Also.. should the lock file be kept? I thought it was supposed to, but it might not matter. In that case we should add it to the .gitignore.

Yes. The lock file is intended to be kept in source control (source) but i'm not sure how this will be managed when merged.

Yes. The lock file is intended to be kept in source control (source) but i'm not sure how this will be managed when merged.

I think the format is optimized for merges/changes so it should not be a problem. We will hopefully not need to change it that often either unless we're updating some dependencies.

I have tried it on my own phone (android) and it works!
There is a deley tho when flipping page and the header and the text dissaper so every thing becomes black exept for the button in the bottom for a short moment.

I have tried it on my own phone (android) and it works!

Great!

There is a deley tho when flipping page and the header and the text dissaper so every thing becomes black exept for the button in the bottom for a short moment.

The flickering is the issue i pointed out above, so it's good to know that it can be replicated on another device.
The darkness you describe is something im unaware of. Could you attach a screenshot of how it looks? Would be good to know what and why the styling differs.

Also, are you using Android's built in Darktheme? @malin-mallan

I have darktheme on my phone yes
https://user-images.githubusercontent.com/78034678/112849515-6f882c00-90a9-11eb-8862-4940ebc6a42f.mp4

Thank you for the video!
Im starting to think that i might be an issue with the expo interactive app workflow. Since the information has to come from the local server before being rendered it takes some time before it has the information. For you it seems like it takes longer than what it does for me so the issues might actually be a non-issue if we're lucky. I will try to build the app into a standalone application and update here with the results here.


Expand domain of Beta and Gamma functions

Both the Beta and the Gamma function will need to accept real valued numbers before the Beta and Gamma distributions can be implemented in a satisfactory manner.

Closed with #95


Prevent releaseExit while exiting.

The following roughly emulates what ember-cli is doing (2.13 canary only):
var captureExit = require('capture-exit');
var RSVP = require('rsvp');

var interruptHandler;
var promise = RSVP.Promise.resolve().
    then(function() {
      captureExit.captureExit();
      captureExit.onExit(interruptHandler);
    }).
    then(function() {
      // somewhere along the promise chain someone does:
      process.exit(1);
    }).
    then(function() {
      captureExit.releaseExit();
    }).
    then(function() {
      // later someone does:
      process.exit();
    });

interruptHandler = function() {
  return promise;
};

If we allow .releaseExit to run during the ._flush process, we can no longer ensure that the rest of the handlers are ran (if a process.exit() is ran after exit has been released).
See longer explaination / code safari in https://github.com/ember-cli/ember-cli/issues/6779#issuecomment-280940358.

This seems good to me, but I'd love feedback from @stefanpenner / @hjdivad / and others as there may be alternative conclusions to be made from the details in https://github.com/ember-cli/ember-cli/issues/6779.

I have confirmed (via npm link) that this does fix the issue identified in https://github.com/ember-cli/ember-cli/issues/6779.

Should we prevent, or should we error. releaseExit  during exit, gives me a headache.

I'm 👍 on erroring here.  releaseExit while exiting is always a bug no?

@hjdivad:

I'm 👍 on erroring here. releaseExit while exiting is always a bug no?

Well, it is the default case for ember-cli right now (as explained in https://github.com/ember-cli/ember-cli/issues/6779#issuecomment-280940358).

I am happy to change it around to be an error if isExiting though.  In general (to me at least), releaseExit seems like it should almost exclusively be a test only "feature", and in normal production usage I do not think it should be used...

releaseExit seems like it should almost exclusively be a test only "feature", and in normal production usage I do not think it should be used...

yes that was the intention. And specifically, for capture-exit's own tests :P

Awesome, thanks for helping me understand the intent here.
I've submitted https://github.com/ember-cli/ember-cli/pull/6799 to remove the releaseExit usage in ember-cli, and once that lands I'll update this PR to make it a hard error.

Closing, I'll open up a separate PR to make .releaseExit() throw if called while exiting.


dealing with runtime-only DLLs

I'm trying to set up a portfile for the ChaiScript library (http://chaiscript.com). I got it to build properly, but the post-build validation complains about some DLLs not having their LIB counterpart in the */lib directory. The point is, ChaiScript is an header-only library, and those DLLs are meant to be loaded dynamically from code (they are a sort of run-time plug-in). They are not meant to be linked at build time, so no import libraries are generated for them. Does the portfile have any control over the post-build validation process, which seems to be harmful in this case?

cd0b7d644b2ba61618b70ae58f50d2e880dbe509 introduces the notion of "Policies".
Basically, if a package does something that deviates from the norm, it should explicitly state so.
In your particular case, you can add the following line in your portfile:
SET(VCPKG_POLICY_DLLS_WITHOUT_LIBS disabled)
This will add an appropriate entry in the BUILD_INFO file. That file is used by vcpkg to make decisions for the post build checks.
Note that in this case, vcpkg will not be able to autodetect that you are using this library and copy the dlls app-locally. If you using this library in your application, you will have to somehow take its dlls into account. I think adding a warning message in the portfile that notifies the user about this would be useful.


Clear results from Pinot Data Explorer

Request from @kishred
In the Pinot Data Explorer, it is hard to tell if the new query ran and gave results. There are buttons for Copy, Excel, CSV. Can we have another button to Clear old results?

instead of a clear button, we can automatically clear every time we click on run (do this before making a call to Pinot)

This is fixed in the new query console


add partition filter to optimize

it will be nice to have an option to optimize only specific partition,  for example optimize only yesterday data and keep today data as it is.

Have you checked out the API docs for this function? https://delta-io.github.io/delta-rs/python/api_reference.html#deltalake.table.DeltaTable.optimize
We do support this. We actually have a blog post we are publishing soon on how to use this. :)

sorry missed that

@wjones127 I get un error with this
dt.optimize(partition_filters='2023-05-12')
TypeError: argument 'partition_filters': Can't extract str to Vec
what's the right way to do it ?

Sorry it's not clear from the parameter description, but it should be a DNF filter, just like the partition_filters in the other functions. So if you have a partition column "date", you can optimize only that date with
dt.optimize(partition_filters=[('date', '=', '2023-05-12')])

You can also pass inequalities and multiple conditions:
dt.optimize(partition_filters=[('date', '>=', '2023-05-12'), ('x', '=', '2')])


In spine chart, always show ticks for active orgs

This PR adds ticks on the x-Axis for any selected orgs.
This ensures that a practice someone is interested in always has a label, so can be identified on the graph.
However, it does make the layout look a bit jarring sometimes, because the default tick algorithm ensures ticks are evenly-spaced. Adding extra ticks between evenly-spaced ticks therefore crowds the labels sometimes.
It may be worth investing a bit more time into refining the tick-insertion algorithm to remove non-active orgs which are adjacent to active ones; on the other hand, if someone has selected two adjacent orgs, then the crowding will be unavoidable, so the current solution may be acceptable. See screen grabs for illustration.

Closes #117

What's a good test case to have a look at?

Looks nice - I don't think the overlapping is a problem.


Add source map generation to the scripts

The scripts get concatenated and minified so generating sourcemaps.
@addyosmani PTAL.

FYI we won't need this if we merge #739 in its current form.

Is there any additional source maps work necessary for #739 assuming we drop this?

Nope #739 takes care of this in its current state. I initially opened this as we initially were going to make the opt-in ES6 support a different task but we are now re-using the 'script' task and source maps generation is taken care of in #739.
So assuming #739 is not going to change I'm closing this PR.


BUG: ListMany label disappears forever after any attribute value updates

See title.
debility: {
  type: "ListMany",
  position: "left",
  label: game.i18n.localize("brein.character.debility.label"),
  options: [
     {
       label: game.i18n.localize("brein.character.debility.weakened"),
       value: false,
     },
     {
       label: game.i18n.localize("brein.character.debility.dazed"),
       value: false,
     },
     {
       label: game.i18n.localize("brein.character.debility.miserable"),
       value: false,
     },
  ],
},

Is this a module that you can link to me? It's easier for me to test it out since I don't have a "test module" to copy-paste JS objects.
I think your issue might be that options should be an Object rather than an Array. E.g.
options: {
     weakened: {
       label: game.i18n.localize("brein.character.debility.weakened"),
       value: false,
     },
     dazed: {
       label: game.i18n.localize("brein.character.debility.dazed"),
       value: false,
     },
     miserable: {
       label: game.i18n.localize("brein.character.debility.miserable"),
       value: false,
     },
  }

They are generally defined as Arrays in TOML, but they are parsed as Objects by the system, and the system doesn't parse modules' JSON at all, it assumes it is correct.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:1: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:26: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:40: missing_pip_check: For pypi packages, pip check should be present in the test commands
INFO: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:43: invalid_url: https://pypi.python.org/pypi/jplephem : URL domain redirect pypi.python.org ->  pypi.org
WARNING: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:46: missing_description: The recipe is missing a description
ERROR: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:46: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:46: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_2dmiko_i_d/clone/recipe/meta.yaml:46: missing_dev_url: The recipe is missing a dev_url
Errors were found


Expand SWA Tutorial

Description

[x] Fix the mkdir for the training path
[x] Use different folder to store checkpoints for each optimizer.
[x] Use cyclic averaging for SWA Example.
[x]  Stocastic spelling error

Fixes #2492
Type of change

[x] Bug fix
[x] Updated or additional documentation

Checklist:

[x] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

@bhack Kindly review

The notebook was using the same folder to store the weights of for each optimizer. This lead to loading the same weights for each optimizer. I fixed that issue along with the requested change in the original issue, hopefully this gets reviewed.

Can someone help with the google:second person error please?

@sayakpaul  Could you help review this? thank you

Thanks for all the reviews, I'll try and apply that suggestion.

@jonpsy it might be even better to also include a step to update the batch norm statistics after the SWA model variant is trained since that is recommended. From the docs:

Note: If your model has batch-normalization layers you would need to run the final weights through the data to compute the running mean and variance corresponding to the activations for each layer of the network. From the paper: If the DNN uses batch normalization we run one additional pass over the data, to compute the running mean and standard deviation of the activations for each layer of the network with SWA weights after the training is finished, since these statistics are not collected during training. For most deep learning libraries, such as PyTorch or Tensorflow, one can typically collect these statistics by making a forward pass over the data in training mode (Averaging Weights Leads to Wider Optima and Better Generalization)

Thanks for the contribution. We are mainly collecting more examples using SWA in keras.io:
https://github.com/search?q=org%3Akeras-team+swa&type=code
Please open a PR there.


⚠ Bofrost.lu has degraded performance

In e6f78ff, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 815 ms

Resolved: Bofrost.lu performance has improved in 6ce0754 after 311 days, 10 hours.


ConnectException when unauthorized.

When I try to connect to my device on a new computer, I am greeted with a connection error when just using the following code:
JadbConnection jadb = new JadbConnection();
        List<JadbDevice> devices = jadb.getDevices();
        if (devices.size() == 0) {
            System.out.println("No android device running ADB was found. Please connect an android device and enable ADB.");
        }

Java ADB java.net.ConnectException: Connection refused: connect
I am not being prompted to allow access for this computer on my phone. When using adb separately first, and allowing access, jadb works. Is there a way jadb could ask for access first? This is on a Windows machine.

This is a great idea! It's mentioned briefly in the README.md, I'm quoting: "Make sure the adb server is running. You can start it by running adb once from the command line.". Making this work more smoothly out of the box, would require somewhat platform-specific details, but it would certainly be sweet.

The latest master tries to start adb either from path or ANDROID_HOME environment variable. Please try it out let me know if it works better for you.


Unify Coordinates, Cell & Size to Pair aliases

This is a proposal to refactor the new Coordinates, Cell and Size types as types aliases of a single generic Pair type with appropriately named get/set methods. (The same principle could be extended for the Rectangle type).
Coordinates temporarily named Xy should probably be renamed to Coord for 2.0, replacing all previous instances of Coord.

Hi
Thanks for this proposal. Can you check the version2 branch?
It basically provides simple structs for Coord, Cell and Size. Refactored via an internal vec2 macro. It enables simple access via public members. i.e cell.x, size.h etc.
The idea is making version2 easier to port to, especially when it comes to drawing routines.

Ok I see with the vec2 macro multiple public generic types are created in order to have single-letter public methods, versus having custom getter/setters over a single unified generic struct.
Both approaches are possible. So the macro option would mean:

new generic types: Gcoord{x,y}, Gcell{c,r}, GSize{w,h}
get & set: Coord.x = Coord.y

An the conceptually unified generic option would mean:

new generic types: Pair(0,1)
get & set: Coord.set_x() = Coord.y()

If you think the macro option makes more sense for fltk we can close this PR.


Reposition VR cam to edit cam is broken

cannot use "=" key to do this at the moment

Fixed in https://github.com/vizorvr/vizor/commit/6bf6c4496bb9de8fd4c999becc103954950f9832


conductor version # 3.4.1 and getting below critical Vulnerability issue

Describe the bug
I am using conductor version # 3.4.1 and getting below critical Vulnerability issue .
Is there any other conductor version which has resolution of these issue ??
Details
Conductor version: 3.4.1

The latest version 3.5.2 uses 4.1.65.Final, from the attached screenshot, that may not address your issue. If you are using a custom build of Conductor, you can override the version in the corresponding build.gradle file. If not, our releases include frequent dependency updates. You should get the desired version in one of the upcoming releases.

We decided  not to go with custom build of conductor .And waiting for future conductor release with resolution of high vulnerability issue as well .
Thanks for update

The next version 3.5.3 should have these dependencies upgraded. I expect the release to happen the latest by next week.


[Core] Added streaming support to LLM Class

Pull Request Summary
This pull request, based on #1052, introduces modifications to the LLM class to enable streaming when the .generate() method is invoked with the stream=True flag.
Code Example
from vllm import LLM, SamplingParams
prompts = [
    "Hello, my name is"
]
sampling_params = SamplingParams(temperature=0.8, top_p=0.95, max_tokens=200)
llm = LLM(model="gpt2")
tokenizer = llm.get_tokenizer()

outputs = llm.generate(prompts, sampling_params, stream=True)

for output in outputs:
    prompt = output.prompt
    last_token_id = output.outputs[0].token_ids[-1]
    last_token = tokenizer.decode(last_token_id)
    print(f"{last_token}", end="", flush=True)

Important Considerations

Batch Generation: When a batch of prompts is provided, tokens are produced sequentially for each batch (e.g., token 1 from batch 1, then token 1 from batch 2, etc.). This necessitates additional parsing logic.

Error Handling for Consistency: To maintain consistent behaviour with vllm/entrypoints/api_server.py, where only a single input is supported, an error should be raised in .generate if a batch of inputs is provided with stream=True.

Is there a reason why the outputs don't have the decoded text available? It seems different from the usual expectation for streaming

Hi @mgoin, thanks for your response! The decoded text can be accessed via the text attribute (output.outputs[0].text). However, since we're streaming one token at a time, the text attribute includes not just the most recent token, but all previously generated tokens as well. To address this, we can extract and stream only the last token by decoding it from the text attribute (which should be a relatively efficient operation).

I agree it is best to minimize changes for an edge use-case like this. However I do have concerns that simply detokenizing the last token id by itself will not have sufficient context for decoding the text accurately. A common issue is to include a space or not next to a word. See vLLM's implementation of incremental detokenization for an example of what has to be done https://github.com/vllm-project/vllm/blob/df845b2b46c3e30f5bd3e3be286285ed148323fc/vllm/transformers_utils/detokenizer.py#L240

I tried your example but it raise an error: " TypeError: generate() got an unexpected keyword argument 'stream'". How does this happen?


[do not yet merge] Refactor EventSource

While working on #28, I noticed that there's quite some code duplication in this project which could be eliminated.
My solution is to factor out the common code into an abstract class EventSource, and into SwingObservable.create.
You will observe that some of my new XxxEventSource classes implement the addListenerForComponent/removeListenerFromComponent methods, while others don't. The reason for this irregularity is that there are two kinds of Swing events:

The easy ones: All Swing classes supporting such events share a common superclass or interface with an addXxxListener and removeXxxListener method. Examples: All Swing classes supporting KeyEvent inherit from Component, and all Swing classes supporting ItemEvent implement ItemSelectable.
The tricky ones: There's no such a common superclass or interface for all Swing classes supporting the event. Examples: ActionEvent, ChangeEvent.

My solution works for both of them, and is only slightly more verbose for the tricky ones.
Consider this PR as a preview. I've only performed the refactoring for a few event sources, and before we do it for all of them, I'd like to know what others think of it.

Any updates on this?


Releases link on home page should go to all releases, not the latest release

Currently the “releases” link points to the latest release of Delta Lake and it should point to the all releases (not the latest specific release).

Hi @dennyglee  ,
The url http://go.delta.io/releases  , which is currently redirecting to the latest release (https://github.com/delta-io/delta/releases/tag/v2.1.0) is referenced in 2 places.

HeroSection.jsx
<HeroLink href="http://go.delta.io/releases" newTab muted>
index.jsx
  url="http://go.delta.io/releases"

Cleaner approach to fix this will be:-
(1) setup redirection from http://go.delta.io/releases   to  https://github.com/delta-io/delta/releases/
(2) Change  http://go.delta.io/releases to http://go.delta.io/latest  in HeroSection.jsx ,
(3) Setup redirection from http://go.delta.io/latest to https://github.com/delta-io/delta/releases/tag/v2.1.0
Unfortunately, I could not figure out where the redirection setup is done. Is this done at the domain(CNAME) level?
Alternate approach would be to only change http://go.delta.io/releases to  https://github.com/delta-io/delta/releases/ in HeroSection.jsx , if this is fine, I'll have make this as my first commit :)

That’s a great idea; let me setup the “latest” shortly and will let you
know.  Then you can make the PR. Thanks!
On Tue, Sep 6, 2022 at 17:25 Siby Abin Thomas @.***>
wrote:

Hi @dennyglee https://github.com/dennyglee ,
The url http://go.delta.io/releases , which is currently redirecting to
the latest release (https://github.com/delta-io/delta/releases/tag/v2.1.0)
is referenced in 2 places.

HeroSection.jsx

index.jsx
url="http://go.delta.io/releases"

Cleaner approach to fix this will be:-
(1) setup redirection from http://go.delta.io/releases to
https://github.com/delta-io/delta/releases/
(2) Change http://go.delta.io/releases to http://go.delta.io/latest in
HeroSection.jsx ,
(3) Setup redirection from http://go.delta.io/latest to
https://github.com/delta-io/delta/releases/tag/v2.1.0
Unfortunately, I could not figure out where the redirection setup is done.
Is this done at the domain(CNAME) level?
Alternate approach would be to only change http://go.delta.io/releases
to https://github.com/delta-io/delta/releases/ in HeroSection.jsx , if
this is fine, I'll have make this as my first commit :)
—
Reply to this email directly, view it on GitHub
https://github.com/delta-io/website/issues/130#issuecomment-1238775025,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALBHLLMJ556L6FCZZVKRY3V47OF3ANCNFSM567CFYPA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks @sibyabin - the go links have been updated as you have suggested:

https://go.delta.io/releases points to https://github.com/delta-io/delta/releases/
http://go.delta.io/latest to https://github.com/delta-io/delta/releases/tag/v2.1.0
When you get a chance, can you please create a new PR for step 2?


fix(MachinePool): use GET response to preliminary update vmssState even if long running operation running

FYI what we use currently

fixed the main issue, running it again


Added transparent background support

Added the Alpha and premultipliedAlpha properties to the WebGLRendererSettings to enable support for transparent background

I'll test it today later. If everything is OK, I'll create a new release


Incremental load from JDBC

TODO
Migrated from marklogic/data-movement#10.

There are at least four scenarios for incremental load:

source provides a version number (or last-updated timestamp) with each record
source provides a delta file listing the records that changed
source provides nothing, so we overwrite everything
source provides nothing, but we develop ways to calculate a delta

One big challenge IMO is calculating (in scenario 4) the documents that have been deleted from the source system.  Most solutions only work well on small datasets, but I'd like a solution that works on billions of docs in the dataset.

@sammefford , should this be marked as ship for 4.0.3 ?

@arthi-ramachandran, I had to update the docs first.


Remove Crashlytics completely. Fix Sentry config

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


To pass request to RabbitMq

Is it possible to pass this api request to rabbitmq ?

Do you mean using node.js as a proxy for rabbitmq? Sure, you can do whatever you want in the body of the methods. Obviously, you'd have to do a lot of work to manually convert the requests coming into node to whatever format rabbitmq wants them in.

OK thank you


Sets default value for namespace in management page

Description
Set "default" as the default namespace in meshery management page
This PR fixes #3563
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #3564 (3ff7b74) into master (008287e) will increase coverage by 5.88%.
The diff coverage is 25.54%.

@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
+ Coverage   12.63%   18.52%   +5.88%
==========================================
  Files          37       37
  Lines        2929     3299     +370
==========================================
+ Hits          370      611     +241
- Misses       2467     2533      +66
- Partials       92      155      +63

Flag
Coverage Δ

e2etests
∅ <ø> (?)

gointegrationtests
9.79% <25.54%> (+6.99%)
:arrow_up:

integrationtests
∅ <ø> (?)

unittests
10.18% <0.36%> (-1.22%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/config/config.go
0.81% <0.00%> (-0.11%)
:arrow_down:

mesheryctl/internal/cli/root/perf/perf.go
26.66% <0.00%> (-23.34%)
:arrow_down:

mesheryctl/internal/cli/root/system/channel.go
16.49% <0.00%> (-2.33%)
:arrow_down:

mesheryctl/internal/cli/root/system/config.go
1.11% <ø> (ø)

mesheryctl/internal/cli/root/system/login.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/logs.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/reset.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/restart.go
2.32% <0.00%> (-0.18%)
:arrow_down:

mesheryctl/internal/cli/root/system/system.go
69.23% <ø> (ø)

mesheryctl/internal/cli/root/system/update.go
1.09% <0.00%> (-0.26%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b44e71...3ff7b74. Read the comment docs.


Refactor structure to separate into backend and frontend

Everything is really all over the place

https://github.com/CTrando/UCSD-Planner-Helper/commit/9dfc9fe2bcb9969f52b08dd865b628582cbc2124


new code maintainer

Getx could have a new code maintainer (two more would be nice)
There are many opened pull requests and issues, and @jonataslaw don't have the time to keep upgrading the package on the speed the users need.

Ah, the joys of open source software! 😅

why there is no new maintainer ? ,because only jonataslaw knows his code , lot of code is undocumented and doesn't follow any patterns

It's more because there's no one with permissions to approve pull requests and publish on pub dev

.

I thought that he would return maintaining the code but as this hadn't happened... i've a proposal to the community:
We can create on this or other issue a tread where people interested in (and capable of) becoming a maintainer add their comments talking a little about their experience with getx and flutter, and the two more upvoted would be the ones, if @jonataslaw approve this.

the whole project is based on a wrong concept , seriously want to be a good flutter dev ? learn context , and use something professional lel

People use the package and even after a year without a serious maintaining circle it's still be most liked one in pub dev.
It is built around a "wrong" concept, but is the easiest way of building a flutter app.
Not everyone has the team,  resources and time to build it the right way from the start and for the most use cases it fit as not every app need to control the context so strictly.

The final user don't care which package you have to handle navigation, context, picking files...
They care about what you deliver to them.
Time to leave the keyboard and start talking with the design and final users too if you wanna be this "good flutter dev".

this seem some junior developer talk , depending on your final user and your level of ethics you can use what ever you want ,
but i think every client deserves to get a maintainable and understandable code
when i start time ago on flutter i did use this package  , it's was on my personal projects and i did find some problems that i couldn't fix , infact i faced some issues that are open issues since more then 7 months , explain that to your client or try to fix it your self seeing how undocumented and like Spaghetti source - code , you can see the issues in this github
then i started working with a team and see lot of reasons why i shouldn't use this , our project used flutter_bloc ,
took me more then 20 days to fully get it , it's flutter favorite for a reason and i got 0 issues , i am not recommending it or anything i am just saying learning and using getx was waste of time for me

If getx is this sort of problem to you, why are you here wasting your time in this thread on the first place?
You don't seem like wanting to help fix the code

If getx is this sort of problem to you, why are you here wasting your time in this thread on the first place? You don't seem like wanting to help fix the code

i am not , i commented [on Oct 22, 2022] and haven't been here
just when you commented on this old issue i got an email notification so i checked

I'll review the PRs, and add more code maintainers.
I'm pretty busy, so the PRs being leaked is my fault, but that will be fixed this week when I'm off work, and I'll use my time to push the release candidate to stable, accept the PRs, and add people who want to contribute to the project.