Migrate Ownable to RBAC

With the 2.0 release coming soon, we want to stabilize as much of our API as possible, and in the process reduce the attack surface of our contracts. It's been pointed out that RBACOwnable is very similar to Ownable and could easily replace it, providing future extensibility, at the cost of added complexity.
We need to decide whether to keep both contracts or remove Ownable altogether from the codebase (which would impact some contracts like Heritable). I personally think this duplication is a mistake, which has caused the owner concept to extend to places where it doesn't belong (e.g. Mintable), and that we'd benefit greatly from the role semantics (minter, burner, etc.). This would also mean dropping the RBAC prefix from multiple contracts, since that's our standard role solution (e.g. RBACOwnable and RBACMintable would simply be Ownable and Mintable).
This is a place to discuss whether or not we want to do this: if consensus is reached and we decide to move forward, we'll also need to settle on a design for the affected contracts (like Inheritable).
Resolves https://github.com/OpenZeppelin/zeppelin-solidity/issues/366.

I am in favor of replacing Ownable with RBACOwnable. For people who feel strongly about using the simple Ownable, they can always install a pre-2.0 version of openzeppelin-solidity. And I think this is a momento to start thinking about extensibility and more interesting use cases for ethereum contracts. This is what an API designed on top of RBAC give us.

I'm in favor of switching to RBAC as described.
Only concern is that Ownable as a "single account that has admin permissions with minimal code" is a useful concept. Perhaps we could change it to WithAdmin and include it in a folder like //contracts/access/minimal/WithAdmin.sol?

I'm in favor of replacing Ownable with RBAC and more granular roles. I'm not quite convinced that we should make everything RBACOwnable instead, because it doesn't make permissions more granular. (By the way, RBACOwnable is not merged yet. It's in #1020.)
To explain a bit further, the idea here is to change all the contracts that currently provide onlyOwner functionality, to instead define a specific role and use something like an only(role) modifier. So, for example, MintableToken would have a minter role, and PausableToken would have a pauser (?) role. These roles can then be assigned via RBAC to different sets of accounts.
There are a couple of outstanding problems that we need to resolve.

#1090
Provide a way to nicely declare and/or manage who is assigned to what roles.

Regarding the second point. Currently RBAC only provides internal functions and the user must design and include via inheritance their own role management scheme. This is not a very good experience. We should provide something out of the box. The complexity of having different roles shows here in that it's not trivial to design a universal API for it.
A first alternative is to have a role admin role who can dynamically add and remove roles to accounts. This feels like going back to Ownable but the admin can give up its role once everything is set up.
Another one is to have something like a "role descriptor" RBAC constructor argument that encodes the addresses assigned to each role, and potentially an admin that can change that during the contract lifetime.
These are just some ideas.

The current proposed changeset is as follows:

Solve #1090
Provide some sort of role-initialization in RBAC constructor (array of roles with addresses for each?)
Provide some sort of RBACWithAdmin mixin, a role that is able to add other roles, and give it up
Migrate all role-related uses of Ownable to RBAC (e.g. MintableToken, Pausable, etc)
Introduce a new concept (we don't have a name for it yet, we internally call it 'true ownership') with a behavior similar to Ownable's (minus transferOwnership), and use it to model the relationships between 'main' contracts and their 'auxiliary' contracts (e.g. PullPayment and its Escrow)
Keep Ownable in OpenZeppelin (though no contracts will use it), to both ease the transition and provide a contract that is useful for quick and dirty prototyping, probably with a comment describing the new alternate systems (roles and true ownership)
Remove Heritable and other Ownable-related contracts, possibly providing role-based alternatives (when applicable)

@frangio

Regarding the second point. Currently RBAC only provides internal functions and the user must design and include via inheritance their own role management scheme. This is not a very good experience. We should provide something out of the box.

I'm not sure there's a default behavior that is both universally useful and not a security concern. Something like RBACWithAdmin is useful out of the box, but defining the management API of your access control layer is very much an application-specific problem. It feels like the best middle ground i stuff like RBACOwnable, RBACMintable, RBACHeritable, etc etc where we pre-code the access control layer CRUD operations for specific applications of RBAC.
@nventuro

Provide some sort of role-initialization in RBAC constructor (array of roles with addresses for each?)

probably the best option before abiencoderv2 ships

Introduce a new concept (we don't have a name for it yet, we internally call it 'true ownership') with a behavior similar to Ownable's (minus transferOwnership), and use it to model the relationships between 'main' contracts and their 'auxiliary' contracts (e.g. PullPayment and its Escrow)

what about "pinned"? i.e. "escrow is pinned to pull payment."
or maybe "pegged"?
or maybe "tracked"?

I'm not sure there's a default behavior that is both universally useful and not a security concern.

I definitely agree. The thing that's missing that would be universally useful and secure is a way to set up an initial assignment of roles. It's one of the points that @nventuro wrote down though.

Regarding names for "true ownership"... what about Private?

"private owner" could work..
We could take a term from the military and use "commander": escrow's commander is pull payment.
Or from computing and use "master/slave": escrow is slave to pull payment.

Not a fan of 'commander', the other contract isn't really taking commands IMO. Also, the industry has moved a bit away from the 'master/slave/ terminology, since it doesn't evoke the happiest feelings.

Yup yup. The perspective on that master/slave terminology is a little odd, but those arguments have been well documented.
How about we keep Owner for the master/slave scenario and change Owner to Manager for the other case?


feat: add coverage command for ci unit tests

feat: add coverage command for ci unit tests
feat: update autogenerated msw script

#332  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on  Graphite


add check elements steps

Coverage decreased (-0.2%) to 31.638% when pulling 972c1ade37bfca11f014785c6f4d1dd9f40b304c on add_noelements_steps into ab3afe76fc84fac0b1609f0f7a54eef8ea6cc7de on master.


fully replace drone with actions (#27556)

Backport #27556 by @techknowlogick
this builds binaries and docker images for tags

@techknowlogick please confirm the backport.


alfosc.py: typo in get_observing_mode()

Hi JK,
There is a small typo in alfosc.py. Line 218 has to be
    elif hdr['OBS_MODE'] == 'IMAGING': (remove blank after imaging)
Cheers,
Steve

Should be fixed by latest merge #12. Otherwise let me know.


Clean up small release guide nits and typos

Adds an explicit callout to not merge the website update PR and cleans up the example docker pulls to match how we actually format tags (no underscore before the rcX suffix.)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Website_Stage_GCS PreCommit

Run Website PreCommit

R: @damccorm


Chrome Instance/Profile?

It supports chrome profile? Can you please provide a example, if it does.

I am using this driver http://chromedriver.storage.googleapis.com/index.html?path=2.21/ and set the capabilities like this
var caps = make(selenium.Capabilities)

func TestWithT(t *testing.T) {
	caps["browserName"] = "chrome"
	wd, _ := selenium.NewRemote(caps, "http://localhost:9515")

@emicklei  did you achieve this ?

yes, I did


Problem with cache ?

i don't know why, but some problems occurs with cache.
For example here
https://www.mapcontrib.xyz/t/s8c2d7-Les_Tiers_Lieux_en_Nouvelle_Aquitaine_et_ailleurs_#admin/layer/edit/ec9f8ce6-8734-4b37-a535-4f3da936d14b

Sorry to not be more preset, I'm very busy on MC Next and other things right now :/

Do you still have that issue?

Is there a cache on MapContrib ?
We have this map in Lyon : https://www.mapcontrib.xyz/t/aeacaa-Publicite_Grand_Lyon
and we have a lot of errors « Too Many Requests », is there a way to avoid them ?
Thanks for your great work, very useful !

yes @bristow but perhaps you don't receive my email on talk-fr ?
i copied your theme and it's ok for me : https://www.mapcontrib.xyz/t/84e08f-Publicite_Bordeaux#
if you want, we can try a call ?


Sync Health report for GDAP clients

Is there a way to get access to the sync health report via gdap? The required permissions can be setup easily enough, but it does not appear that config.microsoft.com can pass in a tenant variable / querystring to load this report up in the context of a GDAP managed tenant.
The Sync health is critical to ensure that machines are synching correctly and that files are moved appropriately when a user is offboarded.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9f65565e-e318-a6d3-2216-b81243b753f3
Version Independent ID: 905fabb5-f3cb-0dd4-af58-f785a45002a5
Content: OneDrive sync reports in the Apps Admin Center - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/sync-health.md
Service: one-drive
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


installation  error: subprocess-exited-with-error

Installation error. ubuntu 22.04.1 python 3.10.6
pip install pyq
Defaulting to user installation because normal site-packages is not writeable
Collecting pyq
  Using cached pyq-5.0.0.tar.gz (103 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [67 lines of output]
      running dist_info
      creating /tmp/pip-modern-metadata-wi0_von6/pyq.egg-info
      writing /tmp/pip-modern-metadata-wi0_von6/pyq.egg-info/PKG-INFO
      writing dependency_links to /tmp/pip-modern-metadata-wi0_von6/pyq.egg-info/dependency_links.txt
      writing requirements to /tmp/pip-modern-metadata-wi0_von6/pyq.egg-info/requires.txt
      writing top-level names to /tmp/pip-modern-metadata-wi0_von6/pyq.egg-info/top_level.txt
      writing manifest file '/tmp/pip-modern-metadata-wi0_von6/pyq.egg-info/SOURCES.txt'
      Traceback (most recent call last):
        File "/home/prathamesh/.local/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
          main()
        File "/home/prathamesh/.local/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/prathamesh/.local/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 377, in prepare_metadata_for_build_wheel
          self.run_setup()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 484, in run_setup
          super(_BuildMetaLegacyBackend,
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 335, in run_setup
          exec(code, locals())
        File "<string>", line 645, in <module>
        File "<string>", line 641, in run_setup
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/__init__.py", line 87, in setup
          return distutils.core.setup(**attrs)
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/core.py", line 185, in setup
          return run_commands(dist)
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/core.py", line 201, in run_commands
          dist.run_commands()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/dist.py", line 969, in run_commands
          self.run_command(cmd)
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/dist.py", line 1208, in run_command
          super().run_command(command)
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/dist.py", line 988, in run_command
          cmd_obj.run()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/command/dist_info.py", line 96, in run
          self.egg_info.run()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/command/egg_info.py", line 312, in run
          self.find_sources()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/command/egg_info.py", line 320, in find_sources
          mm.run()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/command/egg_info.py", line 564, in run
          self.add_defaults()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/command/egg_info.py", line 601, in add_defaults
          sdist.add_defaults(self)
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/command/sdist.py", line 106, in add_defaults
          super().add_defaults()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/command/sdist.py", line 252, in add_defaults
          self._add_defaults_ext()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/command/sdist.py", line 336, in _add_defaults_ext
          build_ext = self.get_finalized_command('build_ext')
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/cmd.py", line 305, in get_finalized_command
          cmd_obj.ensure_finalized()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/cmd.py", line 111, in ensure_finalized
          self.finalize_options()
        File "<string>", line 432, in finalize_options
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/cmd.py", line 293, in set_undefined_options
          src_cmd_obj.ensure_finalized()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/cmd.py", line 111, in ensure_finalized
          self.finalize_options()
        File "<string>", line 369, in finalize_options
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/cmd.py", line 293, in set_undefined_options
          src_cmd_obj.ensure_finalized()
        File "/tmp/pip-build-env-6r04mavo/overlay/local/lib/python3.10/dist-packages/setuptools/_distutils/cmd.py", line 111, in ensure_finalized
          self.finalize_options()
        File "<string>", line 266, in finalize_options
        File "<string>", line 152, in get_q_home
      RuntimeError: No suitable QHOME.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

https://code.kx.com/q/interfaces/pyq/install/
installation successful using source code download.


it has 1 audio channel(s) and the clip was created with 2 audio channel(s)

Bug description
I'm new to all this, I'm trying to make cuts and upload the xml to Premiere, but whenever I do that, this error appears "The selected file cannot be linked because it has 1 audio channel(s) and the clip was created with 2 audio channel(s) with a different channel type.", how can I solve it?
What command did you use
auto-editor namefile --export premiere

I've tested premiere import with mono inputs, and premiere imports them just fine.
Can you run auto-editor info on your file?

Closing because OP has not followed up


MDX ：SELECT [Measures].[ChargeSUM] ON 0,[Time].[YM].[Y].&[2023] ON 1 FROM [Charge];

          MDX ：SELECT [Measures].[ChargeSUM] ON 0,[Time].[YM].[Y].&[2023] ON 1 FROM [Charge];

Error message in picture

Originally posted by @18516979324 in https://github.com/SergeiSemenkov/eMondrian/issues/12#issuecomment-1697089102

Hi,
Try to set
mondrian.olap.SsasCompatibleNaming=true
in
tomcat/latest/webapps/emondrian/WEB-INF/classes/mondrian.properties
Or write query in this style:
SELECT [Measures].[ChargeSUM] ON 0, [Time.YM].[Y].&[2023] ON 1 FROM [Charge]

Thank you, it should be my problem, FoodMart did not have such a situation

When you added uniqueMembers the query with "&" started to work?

Yes，uniqueMembers="true"


System.ArgumentException: Synthesis.esp has too many masters on masters list

https://pastebin.com/ca7mZJtx

you have to split your patch into more than one when this happens. e.g. partition the patchers into those that edit CELL, those that edit WEAP/ARMO, and so on. Generate each and after eachsubset, rename Synthesis.esp to something else for inclusion in your LO.
I already had to do this myself. Synthesis has no automation for this case.


[FR] - CLI - CAD-475 - "Cold Key" Re-delegation (DevOps)

This will become high priority.  It is essential for mainnet.

Done according to JIRA


MaximumPacketSize enforcement

Hi,
Congrats on the V2 release, features look great!
I noticed under capability, one can specify MaximumPacketSize, however, I do not see it as enforced when receiving a packet that's larger than the setting. Can you please point me to it if I missed it?

Hi @thedevop - I think you're right. We enforce the MaximumPacketSize specified by the client, but currently MaximumPacketSize is not being enforced for the server, even though the option exists. I will fix it 👍🏻


Add simple example to README

There is a lack of simple of example of graph design in README (without complex wrappers like FEDOT)

Gif animation of graph evolution also can be useful/


Update scalafmt-core to 2.7.4

Updates org.scalameta:scalafmt-core from 2.7.2 to 2.7.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-patch

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@65480c5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage          ?   96.07%
=========================================
  Files             ?        4
  Lines             ?      102
  Branches          ?        5
=========================================
  Hits              ?       98
  Misses            ?        4
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65480c5...5f6e140. Read the comment docs.


Support CRD validation

What would you like to be added?
I would like the ability to add applications to a kwok's cluster which have their own CRDs (ie: Traefik's IngressRoute for example) and have kwok verify my usage of these CRDs is syntactically valid (ie: I've created an IngressRoute).
Why is this needed?
I'm exploring a "low-effort", automated, gitops approaches for testing/upgrading infrastructure changes.  For example, creating a PR with a revision increase to Traefik... then (in our CICD pipeline) using kwok to create a "mock" of our infrastructure (with the new Traefik version) and try to apply our application (which uses the CRDs).  If kwok validates that our application is compatible with the (untested) version of Traefik, then the next step in the pipeline would be to create an infrastructure to test the functionality (out of scope for this ticket ;).
Of course there are tools which can verify that our usage of our CRDs is valid.  However, many require a running kubernetes cluster (with the new CRDs installed).  There are also some validators which support "offline" validation, but these often require creating, maintaining, or downloading configuration files (OpenAPI definitions) which may or may not exist (or need to be manually created/maintained).
The elegance of kwok is that it's lightweight and it would just follow the same process as constructing a "real" infrastructure.

It sounds like starting the CRD validator externally, using kubeconfig to work for the cluster would accomplish this, am I misunderstanding?


Add Inline Assembler to Coolest Programming Language Features

While completing #140, I've learned about inline assemblers. I want to add that to The Coolest Programming Language Features article.

Done 😃


Bipartite Graph

Hello,  @rudrakshi99 @nakul-19 @plazzy99
I am GSSOC'21 participant.
What I will include -: (suggest if something needs to be added)

What is Bipartite Graph
Two coloring problem
Bipartite Graph test

I will explain the question , approach, code, time complexity, space complexity, along with some images for clear understanding and examples for the theory.
The code will be quite simple to understand in C++.
Also 3-4 test cases will be provided for each.
Please assign this issue to me .

Kindly assign this issue to me I would like to implement it under GSSOC 2021 using java.

Hey @rudrakshi99 @nakul-19 @plazzy99
I am a GSSoC'21 participant. I would like to do this problem in python.
Can you assign me this issue.

Hey, I am Kanchan Jeswani, a GSSOC'21 participant.
I am a Competitive Programmer and C++ enthusiastic.
I would love to solve this problem using CPP with well-explained code and along with its time and space complexity.
Please assign me this issue.
Hope to hear from you.
Discord username  kanchan19#3152
@anubhavitis @dheerajkotwani @tarun26091999 @todi-2000 @geekquad @plazzy99 @rudrakshi99

@plazzy99 I want to work on this issue in C++. Please assign it to me.


Android32 with incorrect TestCase parameters

DUnitX is not calling the test with the correct TestCase parameters on Android 32 bits, when there are many Singles or Doubles in the parameters. I made a small project reproducing the problem (download the full project here: DUnitXBug.zip). Here's the code:
unit Unit1;

interface

uses
  System.SysUtils, System.Types, System.UITypes, System.Classes, System.Math.Vectors,
  FMX.Types, FMX.Controls, FMX.Forms, FMX.Graphics, FMX.Dialogs, FMX.Memo.Types,
  FMX.Controls.Presentation, FMX.ScrollBox, FMX.Memo,

  DUnitX.TestFramework;

type
  [TestFixture]
  TT1 = class
  public
    [TestCase('1', 'str1-value,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,str2-value')]
    procedure Test(const AStr1: string; const F1, F2, F3, F4, F5, F6, F7, F8, F9, F10, F11, F12, F13, F14, F15, F16, F17, F18, F19, F20: Single; const AStr2: string);
  end;

  TForm1 = class(TForm)
    Memo1: TMemo;
    procedure FormCreate(Sender: TObject);
  private
    { Private declarations }
  public
    { Public declarations }
  end;

var
  Form1: TForm1;

implementation

{$R *.fmx}

{ TForm1 }

procedure TForm1.FormCreate(Sender: TObject);
var
  LRunner: ITestRunner;
  LResults: IRunResults;
  LTestResult: ITestResult;
begin
  LRunner := TDUnitX.CreateRunner;
  LRunner.UseRTTI := True;
  LRunner.FailsOnNoAsserts := False;
  LResults := LRunner.Execute;

  // Show the results in a TMemo
  Memo1.Lines.Text := LResults.ToString;
  for LTestResult in LResults.GetAllTestResults do
    Memo1.Lines.Add(LTestResult.Message);
end;

{ TT1 }

procedure TT1.Test(const AStr1: string; const F1, F2, F3, F4, F5, F6, F7, F8,
  F9, F10, F11, F12, F13, F14, F15, F16, F17, F18, F19, F20: Single;
  const AStr2: string);
begin
  Assert.AreEqual('str1-value', AStr1);
  Assert.AreEqual(1, F1, TEpsilon.Position);
  Assert.AreEqual(2, F2, TEpsilon.Position);
  Assert.AreEqual(3, F3, TEpsilon.Position);
  Assert.AreEqual(4, F4, TEpsilon.Position);
  Assert.AreEqual(5, F5, TEpsilon.Position);
  Assert.AreEqual(6, F6, TEpsilon.Position);
  Assert.AreEqual(7, F7, TEpsilon.Position);
  Assert.AreEqual(8, F8, TEpsilon.Position);
  Assert.AreEqual(9, F9, TEpsilon.Position);
  Assert.AreEqual(10, F10, TEpsilon.Position);
  Assert.AreEqual(11, F11, TEpsilon.Position);
  Assert.AreEqual(12, F12, TEpsilon.Position);
  Assert.AreEqual(13, F13, TEpsilon.Position);
  Assert.AreEqual(14, F14, TEpsilon.Position);
  Assert.AreEqual(15, F15, TEpsilon.Position);
  Assert.AreEqual(16, F16, TEpsilon.Position);
  Assert.AreEqual(17, F17, TEpsilon.Position);
  Assert.AreEqual(18, F18, TEpsilon.Position);
  Assert.AreEqual(19, F19, TEpsilon.Position);
  Assert.AreEqual(20, F20, TEpsilon.Position);
  Assert.AreEqual('str2-value', AStr2);
end;

initialization
  TDUnitX.RegisterTestFixture(TT1);
end.

Windows result (expected):

Android32 result (wrong):

The problem occurs both in DUnitX from Embarcadero and in DUnitX from github. I didn't get to debug it but it could be a problem with the RTTI.

I don't so mobile dev so I'm not setup to test this, but my guess is that the wrong AreEqual overload is being called since there isn't an overload with Single parameters. Happy to accept a PR for this (assuming it doesn't break other platforms).

I don't so mobile dev so I'm not setup to test this, but my guess is that the wrong AreEqual overload is being called since there isn't an overload with Single parameters.

No, it’s not related to AreEqual function, the value of the last string parameter is also wrong.

Ok, but that doesn't alter the fact that I am not able to test this. Did you try stepping into the dunitx code to see where the bug is?  You will need to add DUNITXDEBUG to your project defines to enable debug info on the dunitx code.


Update README.md

just some typos on the Readme file

Thanks for catching these

You're welcome man! Awesome lib!


How are you supposed to install this?

The folder structure is not suitable for what the Arduino IDE expects, so it can't be installed as Library. Are you supposed to somehow add the .h file into the project folder and then include it or how?

This example is not meant to be a library. So put all three files in a directory with the same name as the .ino file and start it.


Remove unnecessary code

Codecov Report

Merging #1 (5a67eae) into main (d133b4c) will increase coverage by 50.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             main        #1       +/-   ##
============================================
+ Coverage   50.00%   100.00%   +50.00%
============================================
  Files           1         1
  Lines           4         2        -2
  Branches        1         0        -1
============================================
  Hits            2         2
+ Misses          1         0        -1
+ Partials        1         0        -1

Impacted Files
Coverage Δ

sample/main.py
100.00% <ø> (+50.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How does the props argument in the collecting function work?

In the documentation for useDrag, useDrop, and useDragLayer, it says under collect:
"It receives two parameters, monitor and props"
I understand the monitor parameter, but I don't understand the props parameter. What is it, and how is it used? I also cannot find an example that explains it.
I tried the following:
function DraggableComponent(props) {
  const [collectedProps, drag] = useDrag({
    item: { id: '1', type: 'test' },
    collect: (monitor, props) => {
      console.log('DraggableComponent monitor', monitor);
      console.log('DraggableComponent props', props);
      return { isDragging: monitor.isDragging() };
    }
  })
  console.log('collectedProps', collectedProps);

  return
DraggableComponent

}

monitor works fine, but props is undefined. What am I missing? Thanks!

+1

Has anyone figured this out? I still don't understand what the props argument is for in the collect function.

I am also not sure if I can use connect argument in the collect function.
As well as monitor.isOver returns undefined.
I couldn't find reference in docs regarding what functions can be called for monitor argument in collect function

I am also not sure if I can use connect argument in the collect function.
As well as monitor.isOver returns undefined.
I couldn't find reference in docs regarding what functions can be called for monitor argument in collect function


Inconsistency in some of the examples

Information
Hello,
I was looking at the examples in the WebRTC/examples folder and came across the following comment in the "play-from-disk" example:
(line 196-198)
// It is important to use a time.Ticker instead of time.Sleep because
// * avoids accumulating skew, just calling time.Sleep didn't compensate for the time spent parsing the data
// * works around latency issues with Sleep (see https://github.com/golang/go/issues/44343)

However, the "insertable streams" example seems to use sleep instead of the ticker (I think at least):
(85-108)
// Send our video file frame at a time. Pace our sending so we send it at the same speed it should be played back as.
// This isn't required since the video is timestamped, but we will such much higher loss if we send all at once.
sleepTime := time.Millisecond *
time.Duration((float32(header.TimebaseNumerator)/float32(header.TimebaseDenominator))*1000)
for {
        frame, _, ivfErr := ivf.ParseNextFrame()
	if errors.Is(ivfErr, io.EOF) {
		fmt.Printf("All frames parsed and sent")
		os.Exit(0)
	}

	if ivfErr != nil {
		panic(ivfErr)
	}

	// Encrypt video using XOR Cipher
	for i := range frame {
		frame[i] ^= cipherKey
	}

	time.Sleep(sleepTime)
	if ivfErr = videoTrack.WriteSample(media.Sample{Data: frame, Duration: time.Second}); ivfErr != nil {
		panic(ivfErr)
	}
}

Is it supposed to be a sleep here?

We should fix that! Mind opening a PR?

Ok! Will open one tomorrow!
Btw (and if it's okay to ask questions here), why does sending it all at once incur a much higher loss?


Generated Issue: FatalThrowableError when accessing a User

Please fill out the details below.
Summary:
I was trying to access example user data from jikanpy but I guess it's deprecated somehow.
Steps to reproduce:
I used this command in jikanpy which gave me the error:
nekomata1037 = jikan.user(username='Nekomata1037')
another similar command works fine though:
nekomata1037 = jikan.user(username='Nekomata1037', request='friends')
Additional Details
Jikan Parser Version: v2.16.2@4e3781e1617047921d20acc7bb4390bc8e83502d
PHP: 7.3.21-1+ubuntu20.04.1+deb.sury.org+1
Redis: Connected
Exception: Symfony\Component\Debug\Exception\FatalThrowableError
Code: 0
Message: Return value of Jikan\Parser\User\Profile\AnimeStatsParser::getMeanScore() must be of the type float or null, string returned
Trace: /home/onurkulaksizoglu/work/animezscore/jikan-rest/vendor/jikan-me/jikan/src/Parser/User/Profile/AnimeStatsParser.php on line 73
Request: GET /v3/user/nekomata1037

You need to update the parser on your instance which addresses that bug.
Current stable version is https://github.com/jikan-me/jikan/releases/tag/v2.16.7
Run composer update jikan-me/jikan in your jikan-rest directory.

Closing due to inactivity.

Closing due to inactivity.


Ready to publish to v1

just publish it to npm and add me to the package.

Merged. Thanks for your great work!


install target would be useful in Makefile

Original issue 138 created by<EMAIL_ADDRESS>on 2013-01-09T09:08:32.000Z:
An install target in the Makefile would be useful, currently all linux OSes wishing to distribute leveldb must carry patch doing that.
I'll attach a patch.

If this can be tested on travis-ci then we can add it.

Hi @cmumford,
Any good things on this request. I found that this request is very useful for normal user. Please merge it as possible.

N/A now that leveldb uses CMake.


[stable/spotify-docker-gc] updating removed apiVersion in DaemonSet

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
apiVersion in the DaemoSet has been removed. Updating to it's current replacement.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @paulczar

/ok-to-test

This is a breaking change for people with older k8s clusters.   We need to bump to v2.0.0 or add logic to set the apiVersion based on the cluster version (example https://github.com/helm/charts/blob/f8501e325c0194c02f2e9ddad792e9e2e99944b2/stable/mcrouter/templates/_helpers.tpl#L18-L27 )


headlink: restore php < 5.4 compatibility

fix php <5.4 compatibility broken from 89acaef
refs:

https://github.com/zf1s/zend-view/pull/1

cc @falkenhawk

thank you @glensc

@glensc do you think I could re-release 1.12.21 here or should I go with 1.12.22

@falkenhawk don't do re-releases. it causes more troubles than it's worth.
my idea would be to do micro releases, like: <IP_ADDRESS>, but that might be confusing when to increase the minor, when patch. so to keep things simple, do 1.12.22
ps: started https://github.com/zf1s/zend-view/pull/3


add tests

Coverage increased (+1.8%) to 77.335% when pulling c63a56c9520fd914aa7d1f628adf6696aec6db6c on erik0704:master into fe85c1d4682d1fd749501ca0bf151ebfbd4a9dc3 on CS2103AUG2017-W10-B4:master.


Bug in GitHub AutoAssign Mentors

When Running the GitHub action to auto-assign Mentors for every PR it displays a [warning]Resource not accessible by integration` when running against PRs and it does not auto-assign reviewers. Similar to the issue link given below 👇
kentaro-m/auto-assign-action#29

I would love to work on this issue as a part of Girl Script Summer of Code. Kindly assign it to me.

@Tejas1510 Do we need this feature?

@sanjay270899 there is not a very immediate need but if you think it will add something valuable to the project you can assign it

@muthuannamalai12 Go Ahead!


chore: fixing all instances of foreach => asyncs

chore: fixing all instances of foreach => asyncs
From an earlier debugging session, there was an issue caused by a iterable.foreach(async () => {}) construct.  Because these issues are hard to detect, I went ahead and scrubbed through the code base for other instances and fixed them.

Dendron Extended PR Checklist

NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export

Code
Basics

[ ] code should follow Code Conventions
[ ] circular dependency check: make sure your code is not introducing new circular dependencies in plugin-core.  See Avoiding Circular Dependencies.
[ ] sticking to existing conventions instead of creating new ones

eg: if configuration for utilities are already in one module or package, add future utilities there as well

Extended

General

[ ] check whether code be simplified
[ ] check if similar function already exist in the codebase. if so, can it be re-used?
[ ] check if this change adversely impact performance

Operations

[ ] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?

Architecture

[ ] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

eg: making changes to DNode

Instrumentation
Basics

[ ] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

[ ] can we track the performance of this change to know if it is successful?

eg: see usage for export pod

Tests
Basics

[ ] Write Tests
[ ] Confirm existing tests pass
[ ] Confirm manual testing
[ ] Common cases tested
[ ] 1-2 Edge cases tested
[ ] If your tests changes an existing snapshot, snapshots have been updated

Extended

[ ] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace
CSS

[ ] display is correct for following dimensions

[ ] sm: screen ≥ 576px, eg. iphonex, (375x812)
[ ] lg: screen ≥ 992px
[ ] xxl: screen ≥ 1600px eg. mac (1600x900)

[ ] display is correct for following browsers (across the various dimensions)

[ ] safari
[ ] firefox
[ ] chrome

Docs

[ ] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
[ ] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop
Extended

[ ]  is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

eg: breaking dev change due to new dependency

can we update this in [[Conventions|dendron://dendron.docs/dev.process.code#conventions]] and create an async?
as a followup item, can we create a task for a custom eslint rule to check for this? https://www.webiny.com/blog/create-custom-eslint-rules-in-2-minutes-e3d41cb6a9a0

dev.process.code#conventions

I think you had already added it and scheduled an async in the past 😅
[[Async operations|dendron://dendron.docs/dev.process.code#async-operations]]
I think these instances that I'm fixing here were written prior to us discussing/discovering this issue.

as a followup item, can we create a task for a custom eslint rule to check for this?

Created a task: [[Safeguard for Async in Foreach|dendron://private/task.2022.04.20.safeguard-for-async-in-foreach]]
However, I don't think creating an ESLint for this is easy b/c of lack of type awareness in the ES Lint AST - maybe a simple husky hook would be a better option.


Fix confusion in boolean parameter order in tests

Summary
The test helpers AssertEncoderAgainstGoldenImageSnapshot and AssertEncoderAgainstGoldenSnapshot took two boolean parameters:  updateSnapshot bool and json bool. Some tests seem to have confused their order making the test act "weird".
To prevent it from happening again we introduced an enum Type with the values TypePlain and TypeJson.
Use Cases

Improve tests
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Thanks for this. I think this captures the intent more clearly.
When you say:

Some tests seem to have confused their order making the test act "weird".

Can you point to the tests that mixed up the order? I didn't see any changes like that in this diff? Unless you mean the tests are in other buildpacks, not packit?


Description of NVIDIA_VISIBLE_DEVICES seems incorrect

In step 7 under Enable a GPU in a prefabricated NVIDIA module it describes the NVIDIA_VISIBLE_DEVICES value as "a list of your modules on your device, with 0 being the beginning of the list."  But this seems incorrect per Nvidia's repo which says that the value represents a list of GPUs that are exposed to the container for use.  E.g. In a multi-GPU environment someone can control whether one or more of those GPUs is available to that container.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5a353fcd-b050-4775-3089-eaa9db85d123
Version Independent ID: f838e988-2831-9071-21b8-c611261eb464
Content: Configure, connect, and verify an IoT Edge module with a GPU
Content Source: articles/iot-edge/configure-connect-verify-gpu.md
Service: iot-edge
GitHub Login: @PatAltimore
Microsoft Alias: patricka

Hello @micahl
Does below statements makes good statement? Please let us know...!
This variable controls which GPUs are visible to the containerized application running on the edge device.
The NVIDIA_VISIBLE_DEVICES  environment variable can be set to a comma-separated list of device IDs, which correspond to the physical GPUs in the system. For example, if there are two GPUs in the system with device IDs 0 and 1, the variable can be set to "NVIDIA_VISIBLE_DEVICES=0,1" to make both GPUs visible to the container.

Whoops, didn't mean to close.

Yes, that sounds more correct.

Thanks for confirming, we will work on it.


Packaged JAR file not re-generated if deleted

Configuration
name := "sbt-test"

version := "0.1"

scalaVersion := "2.12.5"

artifactPath in (Compile, packageBin) := unmanagedBase.value / "build.jar"

Steps

Run packageBin
Delete the lib/build.jar file
Run packageBin

Problem
The lib/build.jar file is not re-created.
Workaround
Remove target/streams/compile/packageBin/$global/streams/output.
Notes
sbt version: 1.1.4

This one looks like a fun one to tackle.

I'll try to have a go at this

Writing down some spoken notes:

I think this is an sbt/sbt only change (no need to depend on the sources of sbt/io, via sbt-allsources.sh)
My guess is this is related to non-usage, mis-usage, or a bug in sbt.util.Tracked (which is in sbt/util - so maybe you might need to depend on the sources of sbt/util 😄)


[Feature]: Support toggling >= incremental logic for SQL taps

Feature scope
Taps (catalog, state, stream maps, etc.)
Description
The Singer norm is to use >= when doing an incremental sync with a bookmark. Its for good reason but if someone knows they arent at risk of missing records using only > then we should allow it.
I couldnt find where its documented but I know its to avoid ties that might have been missed on the last sync. For example if the bookmark is a date, and an incremental sync happens early on in the day, then more records arrive within that day, using > would skip those that arrive later in the day and the incremental sync wouldnt have worked as expected. So >= uses "at least once" semantics and requires deduping on the target end.
The use case is for reverse ETL where the target cant handle dupes. Specifically Squared's target-apprise implementation posting to singer-ecosystem-activity in slack. There will always be < 5 records so ties are almost impossible and I think I'd honestly prefer the edge case to be not sending a record than sending it twice. In this case I'd like the option to override the default >= filter to use >.
Another case is if someone uses an auto incrementing PK integer in a postgres database then theres no reason to be inclusive (although it has pretty minimal harm also), the user should have the preference if they know what theyre doing.
I suggest we add something like incremental_filter_inclusive or inclusive_filter (names are tough 😄 ) that defaults to the status quo but allows us to override.
Am I misunderstanding anything?

@pnadolny13 - Thanks for this suggestion. I think we have two paths forward:
On the developer side:
I am coming around to agreeing that developers should be able to declare if their replication key should be compared using > or >= operator.
If a developer does implement a faulty or 'lossy' comparison logic, that would rightfully be reported as a bug in the tap. Even if lost records only occur in 1 out of 10 million or 100 million instances, those are guaranteed to occur for a significant number of total users of the tap. It is absolutely critical that Singer maintain the promise of 'at least once' delivery because other systems that can only promise a certain amount of 'nines' are just completely out of the question when it comes to ELT data pipelines. We need users to be able to assert not just 'it's very very unlikely Meltano missed records' but 'it is systematically impossible for any records to be missed.
On the user side:
The developer should not have access to 'risk it' but we can give them access to control the enabling of a more advanced and costly dedupe algorithm. At the cost of a slightly larger STATE artifact, and some additional compute time for comparisons, we can make this a universal config option for all SDK-based taps:

#161

Still relevant

Still relevant


rename tests from test_filename.py to filename_test.py

Description of the problem
some people, including me, work in the terminal. for people working in the terminal, tab complete is very handy. when all tests are named test_filename.py you have to tab-complete twice (i.e. if there is more than one file, and you have to tab-complete t tab f tab)
Description of a solution

Rename tests

Include steps of the proposed solution.

rename all tests from test_filename.py to filename_test.py

What are the expected benefits/improvements from working on this new feature?
the benefits for terminal users: tab complete

Insert a clear and concise description of any alternative solutions or features you've considered.
n/a

Minimum acceptance criteria

[ ] rename tests
[ ] check that coverage is the same

yes we can do that if you want :+1:


Helm chart installation notes need to be fixed

After installing helm chart on a local kubernetes cluster, i received the output pasted below. The command references a service names "podtato-head-main" but what is deployed is "podtato-main".
NOTES:
1. Get the application URL by running these commands:
     NOTE: It may take a few minutes for the LoadBalancer IP to be available.
           You can watch the status of by running 'kubectl get --namespace podtato svc -w podtato-head-main'
  export SERVICE_IP=$(kubectl get svc --namespace podtato podtato-head-main --template "{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}")
  echo http://$SERVICE_IP:9000

Thanks @mailtosanjeev. Looks like parts of the repo were using "podtato-head" and parts were using "podtato" as the base name. I updated it in #137 to use "podtato-head" everywhere, PTAL.


Dagger 101: first deployment : having a running Docker engine is needed

it might be pretty obvious i got that , but the tutorial is for anyone who's willing to discover dagger.
So we shouldn't make assumption they already know it leverages docker (buildkit).
So I think it would be beneficial to add that having a running Docker engine locally before running the demo app is mandatory :)

We now mention this on the first docs page that have been updated for Dagger v0.2 (a.k.a. Europa): https://docs.dagger.io/

I think that it's OK to close this now - thank you @xinity!


Product video tab

Related Issues

Closes #
1 . Create video tab in single product page and show the product video in it.
2.  Show missing product image in Payment page.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: siva-vnr:x: sakthiraj93:x: maheshwaran-1343You have signed the CLA already but the status is still pending? Let us recheck it.

Probably you have to rebase your branch. Currently, something is wrong


bug :  SELECT TIMESTAMP 'now'; not working

Describe the bug
As per #7686 we should get same result for these three queries
SELECT CURRENT_TIMESTAMP;
SELECT now();
SELECT TIMESTAMP 'now';

But we encounter below error

ERROR:  QueryError: Expr error: Parse error: Can't cast string to timestamp (expected format is YYYY-MM-DD HH:MM:SS[.D+{up to 6 digits}] or YYYY-MM-DD HH:MM or YYYY-MM-DD or ISO 8601 format)

Support for above two queries was given in #7695
To Reproduce
It can be simply reproduced by running this query.
SELECT TIMESTAMP 'now';
Expected behavior
It should return the current timestamp.
         timestamp
----------------------------
 2023-02-21 19:26:33.361002
(1 row)

Additional context
No response

Yes, TIMESTAMP 'now' is not implemented right now.
However, even though SELECT TIMESTAMP 'now';, SELECT now(); and SELECT CURRENT_TIMESTAMP; are expected to return the same result as a batch query, they have different meaning in (materialized) views. The TIMESTAMP 'now' form would be a constant equal to the time of view creation.
Let's treat this as a missing feature and decide whether we want to support it (and warn user) rather than a bug.
cc @neverchanje

until a valid use case occurs


Fix build status badge

Hello! This PR is related to the build status badge in the README.
The problem with the previous badge is that it doesn't link to the correct page in travis
What was it like before:
 Note this links to
http://travis-ci.org/#!/Olivine-Labs/busted/builds
What is it like with this change:
 link: http://travis-ci.org/Olivine-Labs/busted/builds

@Seniru Thank you!

Nothing much actually :D


Bug/Devtooling-677: Error Migrating routes to independent resource

When migrating to independent outbound routes resource, the error
OutboundRoute with name 'Default Outbound Route' already exists can occur
This PR checks the existing routes within a site and only creates any new sites, to prevent the error.
This allows users to migrate existing routes, create new routes, or do both at the same time

Should the user not have to remove routes from the sites resource if they're going to migrate to the new outbound_routes resource? Otherwise what's the point of controlling them with a separate resource? Seems like the error is right, and they should make those changes. I might be missing something here

I don't think customer will like having to delete routes from a site and then recreating them just to move to the new independent resource. This could also cause problems if they have made references to existing routes outside of terraform


Dashrews/ROX-13145 add central db bounce to upgrade test

Description
Add a central-db bounce to the upgrade e2e test to ensure we recover from that.  Note because these are not release builds we have to extend the mutex timeout.  Locks will be held a little longer than normal while the database restarts.
Checklist

[ ] Investigated and inspected CI test results
~- [ ] Unit test and regression tests added~
~- [ ] Evaluated and added CHANGELOG entry if required~
~- [ ] Determined and documented upgrade steps~
~- [ ] Documented user facing changes (create PR based on [openshift/openshift-docs]~(https://github.com/openshift/openshift-docs) and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
This is a test.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

/test gke-postgres-upgrade-tests


Support VS 2019

The location of the mspdb140.dll file is not that easy to obtain, and there are even multiple ones. Let's try to use vswhere.exe and a directory enumeration to figure out the location of the newest DLL.

cv2pdb works with VS2019 for me. Are you using a 32-bit or 64-bit build of cv2pdb?
vswhere does the same as tryLoadMsPdbCom, so maybe a different path inside the VS installation has to be added there?

cv2pdb works with VS2019 for me. Are you using a 32-bit or 64-bit build of cv2pdb?

I am using a 64-bit build.

vswhere does the same as tryLoadMsPdbCom, so maybe a different path inside the VS installation has to be added there?

Right, and as you probably suspected, the path <installDir>\\Common7\\IDE\\mspdb140.dll refers to the i686 version.
I reworked my patch to avoid spawning vswhere.exe and instead piggy-back on top of the tryLoadMsPdbCom() function. In my tests, the new test finds the DLL as well as my previous patch.

Oops, I just noticed that it works for me because I had some similar local changes that were never committed. I pushed them now. Sorry for the trouble.
I see you are looking for the most recent DLL, is that necessary?

I see you are looking for the most recent DLL, is that necessary?

In my setup, yes:
$ find "$(../../../msbuild/vswhere.exe -latest -requires Microsoft.VisualStudio.Workload.NativeDesktop -property installationPath)" -name mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/Common7/IDE/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.16.27023/bin/HostX86/x86/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.20.27508/bin/HostX64/x64/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.20.27508/bin/HostX86/x86/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx64/arm/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx64/arm64/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x86/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx86/arm/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx86/arm64/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx86/x64/mspdbcore.dll
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise/VC/Tools/MSVC/14.24.28314/bin/Hostx86/x86/mspdbcore.dll

In my setup, yes:

I guess it doesn't really matter which one of these is actually used (if the architecture matches). The usual installation doesn't keep older versions, but replaces them.

Fair enough.


sigterm handler does not work with ecosystem

With the new logic to have a runner on Reflector as a first POC for this, we run into the problem of how to integrate this into the larger ecosystem with web servers (good practice to embed with metrics when writing controllers) that already come with their own webservers.
Managed to wrangle this with actix 2 by grabbing their HttpServer run() future, fuse and pin it, along with the reflectors run() future, and selecting on it. It does not feel pretty:
https://github.com/clux/version-rs/blob/d0d64f88511c64ccf1d1ceb1777365ca70c6267f/version.rs#L66-L97
So does it work?
Well. Both runtimes work, but the signal handler of actix kicks in before we have a chance to clean up in the reflector. The reflector never gets the signal.

select! will exit as soon as one future completes, you want join! there.

Thanks, that makes it a lot more ergonomic.

That said, it still feels a bit smelly to have a library listen for global state in the background like this...

It is the runtime module, so you have to actively be using it. It will also be opt-in with features at some point.
But yes, signal handling is only meant to be done in the top level abstractions like Controller. Reflector also because it is not super ergonomic to drive it yourself.


feature result and value are not properly resolved for multiple segments

Both feature_enabled and get_value wrongly resolve the result when there are multiple segments defined for a feature. The reason is that they loop over the _get_flags_response results, and they return the first match.
Expected result:
the last match should be returned, which is what the UI shows and other clients implement, which makes logical sense (all segments are applied and they override each other in sequence).

Hi @tobami - thanks for the bug report - we'll take a look at this right away.

Hi @tobami, thanks again for the report.
To confirm, this issue occurs when an identity matches more than one segment on a feature, is that correct?
I believe that the fix for this actually belongs on the API. The API should not be returning more than one flag in this case, it should look at the order of the segments on the feature and return the correct value for the matching segment with the highest order. The python client should then return the correct value.
I'll look at getting this implemented asap and let you know once it's been sorted.

That is correct, is when multiple segments match.
What you say makes sense, otherwise the clients have to deal with a too complicated response. But then why does the Dashboard show the correctly overriden value?

Hi @tobami, this issue has been resolved in the latest release of the API (v1.11.0).

Cool, thanks!


Pause function

Hi all,
it's possible to add a "pause" from trading, for example after a stop loss?
If there is a huge dump, if i put the stop loss features to ON then the bot probably will buy again after few minute. I would like to tell to the bot "wait a bit, make the dump finishing".
Maybe a pause after a buy. after a sell, and after a stoploss
Thank you

This PR does not make sense...


UI: Services to use PATCH api to update service details

Backend has removed support for PUT method from to update services

Assign to me

Wrong context, closing this ticket


Thumbnail generation has wrong orientation

I'm not sure why the example isn't using sharp() since so many other example recommend using the library for image manipulation, but no image orientation fixes (rotate, crop) are being used in the sample. Can anyone explain why?
https://github.com/firebase/functions-samples/tree/master/generate-thumbnail

Hi @alxvallejo, that's meant to be a really minimal sample that uses the image manipulation tool built in to Cloud Functions for Firebase (ImageMagick).
We have a sharp sample here: https://github.com/firebase/functions-samples/tree/master/image-sharp
If you'd like to see a more productionized version that does account for rotation, you can take a look at the source for the storage-resize-images extension: https://github.com/firebase/extensions/blob/d79a44522d1a889ce33ae5902eb6c1eeb28f87f0/storage-resize-images/functions/src/index.ts#L155-L158

The sharp sample is outdated. The max() method has been deprecated.
What would really be helpful is to combine both simple approaches:

Use sharp for thumbnail generation
Use admin SDK to save the new path to the RTDB

Right now, i'm unsure of how to do that given the example, since sharp seems to rely on streams with a promise that doesn't return the images for saving.

Hi @alxvallejo
Did you find a solution to this issue?
Thank you

@billymahmood Yes, actually made a PR, but haven't had time to format it -> https://github.com/firebase/functions-samples/pull/730


[Identity] test failing in nightly runs

Identity nightly test runs are failing with:

Error Message
Microsoft.Identity.Client.MsalServiceException : AADSTS90002: Tenant 'azuresdkplayground.onmicrosoft.com' not found. This may happen if there are no active subscriptions for the tenant. Check to make sure you have the correct tenant ID. Check with your subscription administrator.
Trace ID: d233a26e-6735-4ae1-b458-f3eb91b84e01
Correlation ID: 8c11f3ac-58f4-4113-a3a1-79a3294f4698
Timestamp: 2021-07-15 05:10:57Z
Stack Trace
at Microsoft.Identity.Client.OAuth2.OAuth2Client.ThrowServerException(HttpResponse response, RequestContext requestContext)
at Microsoft.Identity.Client.OAuth2.OAuth2Client.CreateResponse[T](HttpResponse response, RequestContext requestContext)
at Microsoft.Identity.Client.OAuth2.OAuth2Client.d__111.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Identity.Client.OAuth2.OAuth2Client.<GetTokenAsync>d__10.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Identity.Client.OAuth2.TokenClient.<SendHttpAndClearTelemetryAsync>d__8.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at Microsoft.Identity.Client.OAuth2.TokenClient.<SendHttpAndClearTelemetryAsync>d__8.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Identity.Client.OAuth2.TokenClient.<SendTokenRequestAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Identity.Client.Internal.Requests.UsernamePasswordRequest.<ExecuteAsync>d__3.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Identity.Client.Internal.Requests.RequestBase.<RunAsync>d__13.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Identity.Client.ApiConfig.Executors.PublicClientExecutor.<ExecuteAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Azure.Identity.Tests.CredentialTestHelpers.d__9.MoveNext() in D:\a_work\1\s\sdk\identity\Azure.Identity\tests\CredentialTestHelpers.cs:line 149
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()    at Azure.Identity.Tests.CredentialTestHelpers.<CreateRefreshTokenFixtureAsync>d__10.MoveNext() in D:\a\_work\1\s\sdk\identity\Azure.Identity\tests\CredentialTestHelpers.cs:line 158 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Azure.Identity.Tests.

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=999585&view=results
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1001285&view=results

@v-xuto:  If you'd be so kind, please don't remove needs-triage unless you were able to assign directly to an individual.   That way, I don't overlook it in a triage pass.  Thanks!

@jsquire Got it. Thanks!


Custom inputs or widgets for value binding

Hi,
I use custom inputs widgets like DatePicker or NumericTextBox (KendoUI).
I would like to use "value" binding but I have to create my custom handler with addHandler.
Is it possible ?
Thank you

Seems like that's exactly what custom handlers are intended for - creating binding interactions that aren't "standard".  I've done exactly that myself with some jQuery plugins, like this one for jQuery-Knob:
        // Gets/sets the value for a $.knob() element
        knobValue : {
            set : function($element, value) {
                // Note that this does NOT appear to retrigger the knob's "change" handler, and
                // therefore we don't get into an infinite loop
                $element.val(value).trigger("change");
            },
            get: function( $element, value, event ) {
                return $element.val();
            }
        }


[1.20.1] Herespawn doesn't work cross dimension

it seems it will attempt to spawn the player in the overworld at the same coordinates, e.g. suffocating the palyer

oh dang, ill fix this soon. wasn't on my mind when making it work.

fixed


Dictionary - Chrome Extension

Is your feature request related to a problem? Please describe.

Chrome Extension for a dictionary not available

Describe the solution you'd like.

Would like to add Chrome Extension for Dictionary Implementation

Describe alternatives you've considered.
.
Add any other context or screenshots about the feature request here.
No response

Kindly assign it to me, @ridsuteri


Create suggestion

Light-weight Python-based No-Library API
This is a "API" that I adopted into after 4 iterations. It is meant as a suggestion and starting point for a possible discussion.
Everything is self-contained in a subdirectory to not interfere with the work of others.
I am looking forward to your comments and the general discussion.

Thanks for this @SteffenBrinckmann (and @kjappelbaum for initial comments!), this is a really useful discussion starter.
I'm not sure exactly where we should do this kind of stuff as I guess the discussion threads wouldn't be suitable (beyond just outlining code), perhaps in PRs that never get merged to this particular repo? (as it was intended just for the organisation). Otherwise we can make a few additional repos to play around with stuff.

@ml-evs why don't we make some working repos for the tasks in this marda-alliance GitHub organization?  I think I just gave you the rights to make repos within https://github.com/marda-alliance because I don't want the responsibility of picking the name!

@ml-evs why don't we make some working repos for the tasks in this marda-alliance GitHub organization? I think I just gave you the rights to make repos within https://github.com/marda-alliance because I don't want the responsibility of picking the name!

Thanks David. That seems to have worked! I'll hold off until the "office hours" next Thursday so I can discuss with Peter (and whoever else turns up) the best place to put this stuff.

I'll hold off until the "office hours" next Thursday

No need to wait until then, with making the repo. Also, it's perhaps easier if one person decides on the name and place, to avoid bikeshedding.

We had our first office hours earlier and started making some more repos for this kind of stuff. @SteffenBrinckmann would you mind transferring this PR over to https://github.com/marda-alliance/metadata_extractors_api (I think that's the most appropriate)? If we want we can also copy the existing comments over.
As for this PR, I had a quick look earlier on, and this seems to be more an example of a potential user of what we write, rather than what we actually want to be writing ourselves? e.g., we want to be able to expose the use interfaces that you have written in something more standardized across different packages/languages etc. We discussed leaving support for the output "schema" completely up to the extractor developers, as adding a schema to code that doesn't currently have one can be a painful process!

Thanks all and especially @kjappelbaum for all the comments. I was totally busy in the last two weeks and just am catching up on what happened. Sorry.
I will transfer it to the other repo and address some of @ml-evs comments in that PR.
THANKS!

Thanks all and especially @kjappelbaum for all the comments. I was totally busy in the last two weeks and just am catching up on what happened. Sorry. I will transfer it to the other repo and address some of @ml-evs comments in that PR. THANKS!

Thanks @SteffenBrinckmann -- I'll close this PR here now the other one is open, but please feel free to continue the discussion going in the comments here


#8 What is your back-up scheme?

Data should have back-ups!  These will differ greatly by use case.  If your data is small it could just be back-up hard drives.  If it's large data stored in an institutional repository, what is the back-up system? If it's stored on a commercial service, what do they use?
Ref #10

I suggest a reference to Rule 7 here (or a reference to rule 8 in rule 7) -- in some cases knowing the physical location of the cloud server is important if privacy rules differ between jurisdictions.

Is there a nice reference for the Toy Story anecdote? I've seen this Quora answer:
http://www.quora.com/Did-Pixar-accidentally-delete-Toy-Story-2-during-production/
but it would be nice to have something with a DOI.


Add unnecessary Eclipse files to .gitignore

Should really be using a git include solves issues like this as someone is bound to come along with something else to ignore.

I have no idea where I got these files, but I accidentally committed them in 9aecefec711f879199fa0a37e374a5ae6ff04f43. They might as well be included if IntelliJ IDEA gets its own section.

The change is fine, im just saying there is a better way to do the thing overall. (Prob out of scope for this PR)


Lock on database

Every now and then when running the deployment workflow, it will not deploy the API backend due to a lock in the postgresql-database raised by Liquibase. It has the lock in the table public.databasechangeloglock. I can solve the issue manually (see https://stackoverflow.com/a/19081612). But this is not ideal, as it means that without manual intervention the deployment will not work again. Even stopping the API backend container will not lift up the lock. I wonder, how the unlocking is handled in the backend? Shouldn't it release the lock when the backend is stopped? As it sometimes works without problems, it seems to me that there are situations, where the lock still remains. The deployment workflow on Kubernetes does this: it will stop the pod running the API backend with the old code and in parallel creates a new pod with the new code. I see in the logs of the new pod that it checks for a lock and waits, that this lock is gone, but sometimes this will not happen. Kubernetes then deletes the new pod and restores the old pod, thus not updating the code. @tparkola Can you have a look if the current unlock mechanism is maybe under-specified and could be elaborated for more scenarios?

Just to add: it could be also, that our setup is not that perfect, as we would need it. If you think, that we should test again our workflow, as the backend does it best to prevent such locks, this would be also helpful feedback.

Observed it again: it seems that the lock in databasechangeloglock is only produced in special situations. Maybe you can point me to these situations, so that I better understand, when it happens. This would help debugging our workflow. I found out, because the lock that I deleted when it went wrong was already 2 days old and I wonder why and how such a lock was created but not unlocked.

Raised to critical as it can happen in running operation. Every now and then K8s containers may restart due to external effects, e.g. update of K8s cluster itself. In theory, users should not be bothered by it, because it will create the new container in parallel and switch to this one before retiring the old one. But this could be also the cause of the lock. I now observed it two times that such a restart lead to the database lock - this means that such a lock does not happen every time - of production. Only after manual intervention we were able to unlock the database (for documentation here the manual database command):
UPDATE databasechangeloglock SET LOCKED=FALSE, LOCKGRANTED=null, LOCKEDBY=null where ID=1;

We currently try out to raise the values for the ReadinessProbe in the K8s pod config. Another option is described here: https://www.liquibase.com/blog/using-liquibase-in-kubernetes

Did some deploys and the error does not occur anymore. Seems, that it is now solved. If not, we will re-open the issue.


fix(ui): updated top-padding for main container

Closes #27.

[x] I have reviewed my code in "Files changed" tab.
[x] I have re-read the issue and this PR fully resolves it.

Actually, I can't reproduce


python312Packages.equinox: 0.11.6 -> 0.11.7

Description of changes
Changelog: https://github.com/patrick-kidger/equinox/releases/tag/v0.11.7

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 342867 run on x86_64-darwin 1

4 packages marked as broken and skipped:

python311Packages.equinox
python311Packages.equinox.dist
python312Packages.equinox
python312Packages.equinox.dist

Result of nixpkgs-review pr 342867 run on aarch64-darwin 1

2 packages marked as broken and skipped:

python311Packages.flowmc
python311Packages.flowmc.dist

4 packages built:

python311Packages.equinox
python311Packages.equinox.dist
python312Packages.equinox
python312Packages.equinox.dist

Result of nixpkgs-review pr 342867 run on aarch64-linux 1

4 packages built:

python311Packages.equinox
python311Packages.equinox.dist
python312Packages.equinox
python312Packages.equinox.dist

Result of nixpkgs-review pr 342867 run on x86_64-linux 1

6 packages built:

python311Packages.equinox
python311Packages.equinox.dist
python311Packages.flowmc
python311Packages.flowmc.dist
python312Packages.equinox
python312Packages.equinox.dist


Option to set the User-Agent

It looks like Square Space is blocking access to their sitemap.xml files for certain User-Agents.
Try fetching https://art-works.community/sitemap.xml for example.
It would be great to be able to override the User-Agent header that's sent via a constructor parameter maybe?

Fixed in #56


Uncaught Error: There are no steps defined to iterate

Feature Introduction using Driver.js

Welcome to My Web Application
This is a brief tutorial on how to use some of the features of our web application.
Start Tour

Feature 1
This is the first feature of the application.

Feature 2
This is the second feature of the application.

Feature 3
This is the third feature of the application.

**its showing error for run multiples step **

I don't think you can pass the steps in the options object of the Driver constructor. You have to call driver.defineSteps(steps) explicitly before you call driver.start().
Also you need to wrap the title and description elements in a popover object like so:
{
    element: '#first-element-introduction',
    popover: {
      title: 'Title on Popover',
      description: 'Body of the popover',
      position: 'left'
    }
}

thank you sir its wook

I don't think you can pass the steps in the options object of the Driver constructor. You have to call driver.defineSteps(steps) explicitly before you call driver.start(). Also you need to wrap the title and description elements in a popover object like so:
{
    element: '#first-element-introduction',
    popover: {
      title: 'Title on Popover',
      description: 'Body of the popover',
      position: 'left'
    }
}

Give a simple example (Vue Composition API):
onMounted(() => {
  // call defineSteps in mounted, will be work fine.
  driver.defineSteps(steps);
  driver.start();
});


How can I rollout Temporal 1.24.2 version?

Hi, @alexandrevilain !
I have your operator v0.19.0. Can I rollout Temporal Server v1.24.2 using it?
I've set version: 1.24.2 and got an error:
# temporalclusters.temporal.io "temporal" was not valid:
# * spec.version: Forbidden: Unsupported temporal version (supported: >=1.14.0 <1.24.0)

Hi @Kiseloff !
1.24.x is not supported for now but this is Work in progress: https://github.com/alexandrevilain/temporal-operator/pull/760

Hi guys,
How can I choose the temporal version?
I added the version config to TemporalCluster but when I deployed it, the image was still 1.21.5 ?
apiVersion: temporal.io/v1beta1
kind: TemporalCluster
metadata:
  name: temporal-cassandra
  namespace: dev-hung
spec:
  version: 1.23.0

v1.24.x support has been merged :)
I'll release a 0.20.0 with support for v1.24.x soon :)


Shared flow deploy after create fails when path uses ./ notation

When creating a shared flow with apigeecli, deploying fails if the shared flow was created with the shared flow path using ./ notation. For example:
If a shared flow is created like so:
apigeecli sharedflows create -n $SF_NAME -f $SF_PATH -t $GCLOUD_TOKEN -o $APIGEE_ORG

where
$SF_PATH="./fromscratch/sharedflowbundle"

Deployment will fail with the following error on the console:
Status: instance "us-east1" reported error repository.FailedToLoadFile: "Failed to load file : /sharedflows/fromscratch.xml"

However, if the path is defined like so:
$SF_PATH="fromscratch/sharedflowbundle"

The shared flow deploys successfully.
Note that in both cases, the create step is successful.

For reference, this is the deploy command:
apigeecli sharedflows deploy -n $SF_NAME -e $APIGEE_ENV -t $GCLOUD_TOKEN -o $APIGEE_ORG -r -v $REV

I was able to deploy the sharedflow also with this command:
apigeecli sharedflows deploy -n sf1 -e prod1 -t $token

{
	"environment": "prod1",
	"apiProxy": "sf1",
	"revision": "2",
	"deployStartTime": "1692808285746"
}

To be sure I ran the commands again (matching your flags)
apigeecli sharedflows create -n sf1 -f ./test/sharedflowbundle -t $token
{
	"configurationVersion": {
		"majorVersion": 4
	},
	"createdAt": "1692808466927",
	"displayName": "test_flow",
	"entityMetaDataAsProperties": {
		"bundle_type": "zip",
		"subType": "SharedFlow",
		"createdAt": "1692808466927",
		"lastModifiedAt": "1692808466927"
	},
	"lastModifiedAt": "1692808466927",
	"name": "sf1",
	"policies": [
		"Verify-API-Key-1"
	],
	"resourceFiles": {},
	"sharedFlows": [
		"default"
	],
	"type": "Application",
	"revision": "1",
	"description": "undefined"
}

 apigeecli sharedflows deploy -n sf1 -e prod1 -r -v1 -t $token
{
	"environment": "prod1",
	"apiProxy": "sf1",
	"revision": "1",
	"deployStartTime": "1692808487397"
}

You can also test this test, I am using a test sharedflow bundle in the test folder

Unfortunately, the deploy response only shows successful deploy start. The UI will show the error I mentioned above.
This is a screenshot of the error in the UI

I still wasn't able to reproduce it.
apigeecli sharedflows create -n sf3 -f ./test/sharedflowbundle -t $token
{
	"configurationVersion": {
		"majorVersion": 4
	},
	"createdAt": "1692811596271",
	"displayName": "test_flow",
	"entityMetaDataAsProperties": {
		"bundle_type": "zip",
		"subType": "SharedFlow",
		"createdAt": "1692811596271",
		"lastModifiedAt": "1692811596271"
	},
	"lastModifiedAt": "1692811596271",
	"name": "sf3",
	"policies": [
		"Verify-API-Key-1"
	],
	"resourceFiles": {},
	"sharedFlows": [
		"default"
	],
	"type": "Application",
	"revision": "1",
	"description": "undefined"
}

apigeecli sharedflows deploy -n sf3 -e dev -r -v 1 -t $token
{
	"environment": "dev",
	"apiProxy": "sf3",
	"revision": "1",
	"deployStartTime": "1692811605257"
}

apigeecli sharedflows listdeploy -e dev -n sf3 -r 1
{
	"environment": "dev",
	"apiProxy": "sf3",
	"revision": "1",
	"deployStartTime": "1692811605257",
	"state": "READY",
	"instances": [
		{
			"instance": "us-west1",
			"deployedRevisions": [
				{
					"revision": "1",
					"percentage": 100
				}
			]
		}
	]
}

OK, so this is getting really weird. I cloned this repo and deployed the test shared flow EXACTLY the same way you did and it worked for me, too.
However, when I copied the test shared flow into my repo - not even doing anything else to it - the behavior was the same as the issue I'm dealing with. I did see something interesting though. For some reason, it's looking for the wrong xml file in the revision I created with the ./ notation:
apigeecli sharedflows listdeploy -e mobility-dev -n sf-test2 -o tcna-nonprod-apigee -t $token -r 3
{
        "environment": "mobility-dev",
        "apiProxy": "sf-test2",
        "revision": "3",
        "deployStartTime": "1692821476473",
        "state": "ERROR",
        "errors": [
                {
                        "code": 2,
                        "message": "instance \"us-east1\" reported error repository.FailedToLoadFile: \"Failed to load file : /sharedflows/test.xml\""
                }
        ],
        "instances": [
                {
                        "instance": "us-east1"
                }
        ]
}

These are the commands I used to create and deploy this revision:
apigeecli sharedflows create -n sf-test2 -f ./sharedflows/test/test_flow/sharedflowbundle -o tcna-nonprod-apigee -t
$token
{
        "configurationVersion": {
                "majorVersion": 4
        },
        "createdAt": "1692820943670",
        "displayName": "test_flow",
        "entityMetaDataAsProperties": {
                "createdAt": "1692820943670",
                "lastModifiedAt": "1692820943670",
                "bundle_type": "zip",
                "subType": "SharedFlow"
        },
        "lastModifiedAt": "1692820943670",
        "name": "sf-test2",
        "policies": [
                "Verify-API-Key-1"
        ],
        "resourceFiles": {},
        "sharedFlows": [
                "default"
        ],
        "type": "Application",
        "revision": "3",
        "description": "undefined"
}

apigeecli sharedflows deploy -n sf-test2 -e ce-dev -r -v 3 -o tcna-nonprod-apigee -t $token
{
        "environment": "ce-dev",
        "apiProxy": "sf-test2",
        "revision": "3",
        "deployStartTime": "1692820956999"
}

Is there any update on this? I ran into the same exact issue with a proxy deployment just now.

I just tried the same commands and it worked as expected
apigeecli sharedflows create -n sf-test2 -f ./test/sharedflowbundle -o $ORG -t $TOKEN
apigeecli sharedflows create -n sf-test3 -f ./dummy/test/test_sharedflow/sharedflowbundle -o $ORG -t $TOKEN

apigeecli sharedflows deploy -n sf-test2 -e dev -o $ORG -t $TOKEN -r 1
apigeecli sharedflows deploy -n sf-test3 -e dev -o $ORG -t $TOKEN -r 1

apigeecli sharedflows listdeploy -e dev -t $TOKEN -o $ORG --->
{
	"deployments": [
		{
			"environment": "dev",
			"apiProxy": "sf-test2",
			"revision": "1",
			"deployStartTime": "1693253449765"
		},
		{
			"environment": "dev",
			"apiProxy": "sf-test3",
			"revision": "1",
			"deployStartTime": "1693253602502"
		}
	]
}

Are you trying this locally? how did you install apigeecli?
Can you paste the output of which apigeecli  from the machine you are testing?

This is being done from an apigeecli container from a GitLab CI pipeline. I will get the info shortly; however, the shared flow issue also happened on my local machine, with the following values:
global on  ai_typo_fix on ☁<EMAIL_ADDRESS>❯ apigeecli --version
apigeecli version 1.122 date: 2023-07-27T20:30:08Z [commit: 9997413]

global on  ai_typo_fix on ☁<EMAIL_ADDRESS>❯ which apigeecli
/Users/john.inama/.apigeecli/bin//apigeecli

Here is the info from the pipeline container:
$ apigeecli --version
apigeecli version 1.122 date: 2023-07-27T20:30:08Z [commit: 9997413]
$ which apigeecli
/usr/local/bin/apigeecli

Thanks for the info. Both @srinandan and I are not able to replicate the issue. Its working from our laptops and we use the same version

Thanks for looking, but no, that's not it. Creation works fine, and deploy shows success on apigeecli (because it just checks for the deploy starting) but once deployed, there's an error where it can't find the base xml file. Sometimes it has the name wrong, too. But only when using ./ notation. It's odd and random and really annoying me!! :)

@cygnus8595  - we just released a beta version
Can you try installing that and see if the fix works as expected?
export APIGEECLI_VERSION=v1.124.0-beta
curl -L https://raw.githubusercontent.com/apigee/apigeecli/main/downloadLatest.sh | sh -

@ssvaidyanathan I downloaded the latest version and it works:
❯ apigeecli sharedflows create bundle -n from-scratch -f ./sharedflows/from-scratch/sharedflowbundle -t $token {         "configurationVersion": {                 "majorVersion": 4         },         "createdAt": "1695241506070",         "entityMetaDataAsProperties": {                 "bundle_type": "zip",                 "subType": "SharedFlow",                 "createdAt": "1695241506070",                 "lastModifiedAt": "1695241506070"         },         "lastModifiedAt": "1695241506070",         "name": "from-scratch",         "resourceFiles": {},         "type": "Application",         "revision": "11" }
❯ apigeecli sharedflows deploy -n from-scratch -e ce-dev -r -t $token {         "environment": "ce-dev",         "apiProxy": "from-scratch",         "revision": "11",         "deployStartTime": "1695241549053" }
{         "environment": "mobility-dev",         "apiProxy": "from-scratch",         "revision": "11",         "deployStartTime": "1695241637466" }

Thanks!

Great news! We will release the version in a few days as we consolidate other fixes
Thanks for checking and get back to us


misc: 1.2.0-arduino Release

Proposed changes

This PR is the 1.2.0-arduino release, and matches changes up to Cpp-Client 1.2.0 master.
reference: #79
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improve a current implementation without adding a new feature or fixing a bug)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build (changes that affect the build system)
[ ] Docs (documentation only changes)
[ ] Test (adding missing tests or fixing existing tests)
[x] Other... Please describe:

Checklist

[x] I have read the CONTRIBUTING documentation
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.
If no reviewer appears after a week, a reminder will be sent out.

@sleepdefic1t The ci/circleci: build-linux-default job is failing as of f97ce602547c1a842ab54b9ef835dffecc16aaa2. Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t The ci/circleci: build-linux-default job is failing as of f97ce602547c1a842ab54b9ef835dffecc16aaa2. Please review the logs for more information.
Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian will push a few updates, and notify you when ready.

@faustbrian Ready to go 👍


fix: loop variable capture issue

this PR addresses the issue of loop variable capture in sandbox_stats_list.go.
The loop variable sb was being captured by the goroutine,
This could lead to unexpected behavior because all goroutines share the same variable reference.
modified the loop to pass the loop variable sb as an argument to the goroutine function,
ensuring each goroutine captures its own instance of the variable.

/ok-to-test

rocky 9's vagrant box 4.0.0 version is unavailable: https://github.com/rocky-linux/kickstarts/issues/6

Can you rebase this on main to get the CI fix?

/retest

This is fine, but also should not be a problem anymore since go1.22


Python 3.5.2 support

Aiohttp requires at least python 3.5.4. Could we use something else or old aiohttp version?

Since dephell uses only Python>=3.6 can't this be closed?


Manual mapping

Hi,
First of all, thank you for making this repo public. Second, I have a question about some of the steps in the instruction document

What did you mean by "some %"? Are there specific medications we should manually map but for other medications we don't? And how much % should we manually map?
Thanks

@abduazizR Using USAGI to manually map drug names to RxNorm concepts is a manually intensive process. The instruction is saying that it makes sense to focus on the most frequently used drugs. You can decide the 'cut-off' point where the additional manual work of mapping the drug names for infrequently used drugs is not worth the extra manual effort.

Thank you for the answer. May I ask how you have dealt with drugs with different doses in terms of mapping? For example, for Humira, there are multiple doses. Did you choose one of the doses or have mapped it to all the doses in the index vocabulary?


⚠ gorzdrav.org has degraded performance

In fc103df, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 4194 ms

Resolved: gorzdrav.org performance has improved in 19cf4a3.


Adding header guards & typo fixes

Added:

Standardised header guards to all header files

Changed:

Typo fixes
Headers where present to standardised format

Feel free to reject if you'd rather refactor it yourself :3

Nice thank you a lot!


fix(input): fix valid clear on submits

What this PR does 📖

Green outline would persist after different types of submits on kit's input

Which issue(s) this PR fixes 🔨

Resolve #362

review in progress


✏ Fix glaring typographical error

Checklist

[X] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[X] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[X] I've read the Contribution Guidelines
[X] I've updated the documentation if necessary.

Description
I fixed a typo in commands_generator.rb.
Motivation and Context
Self-explanatory.

Thanks @getaaron !

That's awesome 👍


Prepation for outer backend of SecondOrder

Core

Remove the automatic conversion of extras between operator types
Now, an extension needs to define the preparation and all four variants of an operator if it wants to support it
In our fallbacks, explicitly grab the fields of the higher-level extras to serve as lower-level extras
Add second derivative outer extras
Add the four cases of HVP outer extras corresponding to the four HVP modes
The signature for prepare_hvp takes an additional argument v

Extensions

Add some missing operator variants to avoid errors
Make PolyesterForwardDiff rely on ForwardDiff preparation so that speeds are equal
Add Hessian sparsity preparation for SparseDiffTools

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (3e6164f) to head (e046b76).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   95.10%   95.96%   +0.86%
==========================================
  Files          59       59
  Lines        1880     1860      -20
==========================================
- Hits         1788     1785       -3
+ Misses         92       75      -17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Pricing or sponsorship information

Hi, first of all, thank you for developing and maintaining dotenv.
I've been using it for years, and couldn't imagine working without it, especially as I frequently switch between multiple projects.
Dotenv vault sounds really good, no more sending .env files to teammates by Slack, poorly or not at all protected.
I'd love to jump on board, however, I feel a bit reluctant to pass all my env files to a third party when I don't fully understand how they monetize this service.
Running the servers that store the encrypted values must cost money, and since I don't see any pricing page on the site, I am left wondering where the money comes from ... you know the old saying "if you're not paying for the product you are the product"
I have full confidence this is not the case here, but maybe clarifying a few of these questions in a visible place would make the decision to use the service easier for others too.

Will this free service turn into a paid service at some future time?
While I was writing this, I thought maybe the pricing is visible only after login ... turns out that's the case.
I think it would be better to be upfront about it.
Do you have some sort of sponsorship?

Thanks, looking forward to using this

I thought maybe the pricing is visible only after login ... turns out that's the case.
I think it would be better to be upfront about it.

Yes, that is the case. We will get this fixed soon. It definitely needs to be up front. It isn't yet because:

We're considering a different pricing model - possibly usage based
We've been almost 100% focused on product and working with current users to improve the product, that we haven't prioritized adding content to the marketing page

Do you have some sort of sponsorship?

No, we don't. Instead we are going to build a great product, open source pieces over time, and charge for premium features for large teams.
Thanks for the question and hope you enjoy it!


Updated View/Helper/TreeHelper.php

Fix for CakeDC/comments#31
TreeHelper using a deprecated api (ClassRegistry) to obtain a reference to the current view. Switched all usages of $view to $this->_View.

Thanks for the fix!

Glad I could help.  I would like to point out that there is an identical issue with the Utils plugin.  I can submit a pull request for that as well.


Remove need for prime order in ElGamal

During our call today we realised that we did not need the prime condition for ElGamal. I guess it is needed for hardness, but we do not formalise it.
We do need the order to be at least two however because of a discrepancy between 'Z_1 which is { 0, 1 } and the fact that a mod 1 = 0 (we have to show that every element of 'Z_1 is 0).
It could also be that I'm doing the proof wrong and that we actually don't need this condition. Please point it out to me if obvious.

lgtm, mathcomp weirdness as discussed.