RISK: binding conflict in "Provision the SharePoint web application"

Hi.
The scripts included in this document introduce a risk of bringing down the existing SharePoint web app by introducing a potential binding conflict in IIS.
Please could you update the scripts to ensure that the examples cannot cause this kind of issue - and potentially include a warning about it in the documentation to select a unique TCP port and/or host header for the web app.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14396770-0d69-ef5d-9a9c-104ac6b08bdd
Version Independent ID: 778c01c4-e639-fe76-5a2b-91078f6228fc
Content: Enable remote access to SharePoint - Azure AD Application Proxy
Content Source: articles/active-directory/manage-apps/application-proxy-integrate-with-sharepoint-server.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @kenwith
Microsoft Alias: kenwith

@edmund-davis
Thanks for your feedback! I have assigned this issue to the author who will investigate and update as appropriate.

@edmund-davis
Thanks for your feedback! I have assigned this issue to the author who will investigate and update as appropriate.

Since script creates only IIS sites with HTTPS bindings, I don't see an actual risk of affecting existing IIS sites: No certificate will be set in the new IIS site if a conflict may occur (admin will have to do it manually).

Thanks for following up.
If a customer is using a wildcard certificate though, would it not be better to set the appropriate host headers at this stage so that when the certificate is assigned, the new site cannot bind to all incoming traffic and create a conflict?
Edmund
EDMUND DAVIS
CLOUD SOLUTION ARCHITECT
Insentra - UK
Phone: +44 7971 192962  Email: edmund.davis<EMAIL_ADDRESS>[cid:image002.png@01D6F89A.0C963170]https://outlook.office365.com/mail/options/mail/messageContent/www.insentragroup.com
[cid:image004.png@01D6F89A.0C963170]https://twitter.com/Insentra?lang=en<EMAIL_ADDRESS>https://www.linkedin.com/company-beta/930607/<EMAIL_ADDRESS>https://www.facebook.com/Insentragroup/
Forthcoming annual leave:  None planned
From: Yvan Duhamel<EMAIL_ADDRESS>Sent: 01 February 2021 09:55
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Edmund Davis<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] RISK: binding conflict in "Provision the SharePoint web application" (#69451)
Externally Generated E-Mail
Since script creates only IIS sites with HTTPS bindings, I don't see an actual risk of affecting existing IIS sites: No certificate will be set in the new IIS site if a conflict may occur (admin will have to do it manually).

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F69451%23issuecomment-770728997&data=04|01|edmund.davis%40insentragroup.com|3dc6a589b9bc40a7b83908d8c6976d50|671563ba62bf48be912017075aaaa1cc|0|0|637477701037322314|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GB1FNULFDTI9EQxvUo46Vc41Z08oHRNLLK9liPvsd1c%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANDQPY63NXTPFHYO24ZH3LLS4Z26ZANCNFSM4WSFC2YA&data=04|01|edmund.davis%40insentragroup.com|3dc6a589b9bc40a7b83908d8c6976d50|671563ba62bf48be912017075aaaa1cc|0|0|637477701037332316|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=0q5zwj2nQJC%2F%2F79MExk9RTFnefIr5Z3gzKbdywd4VRU%3D&reserved=0.

The content of this email and any attachment is private and may be legally privileged. If you are not the intended recipient of this email, any use, disclosure, copying or forwarding of this email and/or its attachments is unauthorised. If you have received this communication in error please notify the sender and delete this email and any attachments immediately.

What I said in my previous comment also applies if a wildcard certificate is used on a different IIS site.
In such scenario, the administrator may need to configure a host header in the new IIS site, but it's specific and I expect that admins who need it will just do it.
IMO it's necessary to document this specific config as it will be natural for people who need it.

Hmm, I'm sorry but I don't think I agree.
The challenge I see is that your script is creating an HTTPS site on port 443 without a host header and this could conflict with an existing production site on 443 in many common scenarios.
You do not provide a warning or guidance about this conflict situation and I think this is a risk for customers who may not be specialists in IIS.
I suggest the documentation needs to provide a warning about this potential conflict and a clear suggestion on how it can be avoided.
If it's compatible with AAD App Proxy then one option might be to change the listening port from 443 to something else.
Or, if it is preferable, configure a host header on the new web app and confirm which host header required in this situation.
I hope you agree that there is a risk to production here and the documentation could be improved to reduce that risk,
Edmund
Edmund Davis
Cloud Solution Architect
Professional Services
Phone: +44<PHONE_NUMBER>  Email<EMAIL_ADDRESS><EMAIL_ADDRESS>[cid:image003.png@01D6F8A9.C3FC1F50]https://twitter.com/Insentra?lang=en<EMAIL_ADDRESS>https://www.linkedin.com/company-beta/930607/<EMAIL_ADDRESS>https://www.facebook.com/Insentragroup/<EMAIL_ADDRESS>https://www.instagram.com/insentra/
From: Yvan Duhamel<EMAIL_ADDRESS>Sent: 01 February 2021 14:12
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Edmund Davis<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] RISK: binding conflict in "Provision the SharePoint web application" (#69451)
Externally Generated E-Mail
What I said in my previous comment also applies if a wildcard certificate is used on a different IIS site.
In such scenario, the administrator may need to configure a host header in the new IIS site, but it's specific and I expect that admins who need it will just do it.
IMO it's necessary to document this specific config as it will be natural for people who need it.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F69451%23issuecomment-770885842&data=04|01|edmund.davis%40insentragroup.com|a74be8c2a9b84ebabe3b08d8c6bb6e5c|671563ba62bf48be912017075aaaa1cc|0|0|637477855630503176|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=HiWHs3Xkn%2F8eJBgZzPsxbL9LTyGDTmnj%2F31O0CD4Rh8%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANDQPY3R4WSSBQAJXJVWETTS42ZD5ANCNFSM4WSFC2YA&data=04|01|edmund.davis%40insentragroup.com|a74be8c2a9b84ebabe3b08d8c6bb6e5c|671563ba62bf48be912017075aaaa1cc|0|0|637477855630513171|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=8o3RXauMjTBMOgVTYH5YzMTwYDQFLdUkMOLbrFFLO9o%3D&reserved=0.

The content of this email and any attachment is private and may be legally privileged. If you are not the intended recipient of this email, any use, disclosure, copying or forwarding of this email and/or its attachments is unauthorised. If you have received this communication in error please notify the sender and delete this email and any attachments immediately.

I disagree based on my first comment: If SharePoint creates a HTTPS site that conflicts with the bindings of an existing IIS site, no certificate will be set on the new HTTPS site, so existing IIS site won't be impacted.

This seems like a really great discussion and I am happy it is captured on the Issue for this doc. If I need to make updates to the doc please go ahead and re-open this one and I will get a PR submitted. Thank you for taking the time @edmund-davis to provide feedback and engage on this discussion. I know it takes time to make the docs better and I really appreciate it.
#please-close


Sass-convert dying with undefined method 'build' for module `Less::StyleSheet::Mixin4' (NameError)

/home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/less.rb:40:in alias_method': undefined method build' for module Less::StyleSheet::Mixin4' (NameError) 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/less.rb:40:in module:Mixin4'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/less.rb:14:in <module:StyleSheet>' 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/less.rb:9:in module:Less'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/less.rb:5:in <top (required)>' 	from <internal:lib/rubygems/custom_require>:29:in require'
from internal:lib/rubygems/custom_require:29:in require' 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:624:in block in process_file'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/util.rb:297:in silence_sass_warnings' 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:619:in process_file'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:589:in block in process_directory' 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:564:in glob'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:564:in process_directory' 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:529:in process_result'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:41:in parse' 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/lib/sass/exec.rb:21:in parse!'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/gems/sass-3.1.3/bin/sass-convert:7:in <top (required)>' 	from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/bin/sass-convert:19:in load'
from /home/nemlah/.rvm/gems/ruby-1.9.2-p136/bin/sass-convert:19:in `'
Looked into the lessc gem but couldn't find the module it is trying to patch..

+1

+1
sass 3.1.10 && less 2.0.7

samw thing with sass 3.1.11 && less 2.0.8

+1

+1
same deal with sass 3.1.12 and less 2.0.8. I was excited enough about to try a number of combinations of earlier point releases from both libs, but same result. dashed hopes (for an easy conversion path)

Less.rb is old and deprecated, it doesn't support the current less syntax. A less to sass converter is a good thing to have, but a rewrite of this feature is required to achieve that.
@nex3, I'm going to remove the less support from sass-convert unless you object. I think a less to sass converter can and should be provided by a separate project -- maybe it would be built on less.js's internals instead of sass's.


Add React UI Tools to Fee Components List

:

@facebook-github-bot I can't sign the CLA, I am told my email is already associated with an account.

@reactjs-bot assistance please?

@benschwarz I'm not able to sign the CLA as I'm told it's already been signed using my email.

@jnsencha thanks!

Thanks @lex111 !!!


env secret not passing

it will be great if you could give an example how to pass env secret,
in my case without the env its working as expected.
this is the error i get
failed to process "${{secrets.NEXT_PUBLIC_DATABASE_CONNECTION}}": syntax error: bad substitution
the yml
`name: Publish To Heroku With Docker
on:
push:
branches: [master]
jobs:
publish:
runs-on: ubuntu-latest
steps:
- name: Checkout Dir
uses: actions/checkout@v2
- name: Heroku Deployment
uses<EMAIL_ADDRESS>with:
herokuApiKey: ${{ secrets.HEROKU_API_KEY}}
herokuAppName: "shopping-cart-6-cd"
# herokuAppName: ${{ secrets.HEROKU_APP_NAME}}
useDocker: true
      NEXT_PUBLIC_DATABASE_CONNECTION: ${{secrets.NEXT_PUBLIC_DATABASE_CONNECTION}}

    env:
      NEXT_PUBLIC_DATABASE_CONNECTION: ${{secrets.NEXT_PUBLIC_DATABASE_CONNECTION}}

`
the Dockerfile
`
FROM node:16-alpine AS deps
RUN apk add --no-cache libc6-compat
WORKDIR /app
COPY package.json package-lock.json ./
RUN npm ci
FROM node:16-alpine AS builder
ARG NEXT_PUBLIC_DATABASE_CONNECTION
ENV NEXT_PUBLIC_DATABASE_CONNECTION: ${{secrets.NEXT_PUBLIC_DATABASE_CONNECTION}}
WORKDIR /app
COPY . .
COPY --from=deps /app/node_modules ./node_modules
RUN npm run build && npm install --production --ignore-scripts --prefer-offline
FROM node:16-alpine AS runner
WORKDIR /app
ARG NEXT_PUBLIC_DATABASE_CONNECTION
ENV NEXT_PUBLIC_DATABASE_CONNECTION: ${{ secrets.NEXT_PUBLIC_DATABASE_CONNECTION  }}
RUN addgroup -g 1001 -S nodejs
RUN adduser -S nextjs -u 1001
COPY --from=builder /app/next.config.js ./
COPY --from=builder /app/public ./public
COPY --from=builder --chown=nextjs:nodejs /app/.next ./.next
COPY --from=builder /app/node_modules ./node_modules
COPY --from=builder /app/package.json ./package.json
COPY --from=builder --chown=nextjs:nodejs /app/.next/static ./.next/static
USER nextjs
EXPOSE 8000
ENV PORT 8000
CMD ["npm", "run", "start"]
`

looks like a bug unrelated to this GH Action, Issue CLosed


CDK Generates Incorrect ECS Task Definition for EFSVolumeConfiguration

Describe the Bug
CDK appears to use the incorrect casing for EfsVolumeConfiguration when synthesizing to CloudFormation. It should be EFSVolumeConfiguration.
The does not impact the deployment, but sounds like it does not properly create the EFS volume as per this ticket: https://github.com/aws/aws-cdk/issues/15025.
It does not appear that this issue has been fixed in CDK yet, so we will have to code our own fix (see above ticket for examples).
Steps to Reproduce
// examples/demo-wdl-project
agc account activate
agc context deploy myContext -v

Relevant Logs
    2022-02-14T16:09:30.234-08:00
    2022-02-15T00:09:28Z 𝒊  Agc-Context-testCtxRstrt-user43G9Hd-default | 36/47 | 12:09:25 AM | CREATE_IN_PROGRESS   | AWS::ECS::TaskDefinition                  | cromwell/EngineTaskDef (cromwellEngineTaskDefD21A4E86) Resource template validation failed for resource cromwellEngineTaskDefD21A4E86 as the template has invalid properties. Please refer to the resource documentation to fix the template.
    	2022-02-15T00:09:28Z 𝒊  Agc-Context-testCtxRstrt-user43G9Hd-default | 36/47 | 12:09:25 AM | CREATE_IN_PROGRESS | AWS::ECS::TaskDefinition | cromwell/EngineTaskDef (cromwellEngineTaskDefD21A4E86) Resource template validation failed for resource cromwellEngineTaskDefD21A4E86 as the template has invalid properties. Please refer to the resource documentation to fix the template.
    	2022-02-14T16:09:30.234-08:00
    2022-02-15T00:09:28Z 𝒊  Properties validation failed for resource cromwellEngineTaskDefD21A4E86 with message:
    	2022-02-15T00:09:28Z 𝒊  Properties validation failed for resource cromwellEngineTaskDefD21A4E86 with message:
    	2022-02-14T16:09:30.234-08:00
    2022-02-15T00:09:28Z 𝒊  #/Volumes/0: extraneous key [EfsVolumeConfiguration] is not permitted

Expected Behavior
AGC deploys the context without any template validation failures.
Actual Behavior
We get the validation failure above.
Additional Context
Operating System: AL2
AGC Version: 1.20.0
Was AGC setup with a custom bucket: No
Was AGC setup with a custom VPC: No

After a closer reading it looks like this is only a validation error and does not impact actual deployment of any resources.
Closing this since it's only on the CDK team to fix.


Expose URL in VespaDocker

Not sure if it's a bug or feature ;).
VespaDocker has a URL, and it is hardcoded to localhost - If this is not intended, can you please expose this?

I have the same problem, and I am wondering why you are defining self.URL field when 'localhost' is hardcoded.
Is VespaDocker meant to be only used in a local dev environment?

It was meant to originally, but we intend to expose this.
If any of you want to make a contribution, it will be very welcome. :)


fix: css loading runtime order

Summary
the order of loadCssChunkCallback and webpackJsonpCallback matters in rspack, cause rspack experiments css use loadCssChunkCallback to load css chunk instead of loadCssChunkData + css head{meta data} like webpack, if loadCssChunkCallback is before webpackJsonpCallback, umd library will have the correct exports since the exports is returned in webpackJsonpCallback, but in loadCssChunkCallback it will return undefined, so if loadCssChunkCallback is after webpackJsonpCallback, the umd library exports will be undefined

Require Documentation?

[x] No
[ ] Yes, the corresponding rspack-website PR is __

BTW, pnpm test:ng failed, caused by globalContext is reuse between runner.run(), in webpack globalContext and moduleScope should be one instance per runner.run() instead of per runner. cc @LingyuCoder

!canary


bug: ion-nav does not fire change detection for the root page when using OnPush change detection

Bug Report
Ionic version:
[x] 4.11.1 (also reproduced in sample in 5.1.1)
Current behavior:
I am presenting a modal using the ModalController.  The modal presents a simple component that contains only an <ion-nav> with a root component set on it.  This is so that I can create a sort of "guided process" within the modal using the <ion-nav> to navigate between pages of the process.  The root page that I am setting on <ion-nav> uses OnPush change detection and contains some observable state that is shown in the UI asynchronously.  If I set the modal component's ChangeDetectionStrategy to Default, everything works the way I expect with the component set as the root on the <ion-nav>.  However, if I use ChangeDetectionStrategy.OnPush for the modal component, the root page will never display my asynchronous state changes.    It does fire the ionic lifecycle events, but the angular ones are never called.
Expected behavior:
I would expect that my modal component containing the <ion-nav> should be able to utilize whatever ChangeDetectionStrategy I choose, and as long as the child component can handle it (and mine can), it should fire angular lifecycle events and update the view accordingly.
Steps to reproduce:
I have put together a sample application that has a single button to launch a modal.  That modal displays a page using ChangeDetectionStrategy.OnPush.  The root component loaded in the <ion-nav> should show text initially, wait 3 seconds, and then update the text.  It will actually never show the text at all with the current setup.  Switching the ModalComponent to ChangeDetectionStrategy.Default will make it all work as expected.
Related code:
Sample app: https://github.com/ekrapfl/nav-on-push
There are comments in src/app/home/process.component.ts and src/app/home/modal-page.component.ts to indicate some of the things I have attempted/noticed.
Ionic info:
Ionic CLI                     : 5.4.16 (/Users/krapfl/.npm/_npx/19146/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 5.1.1
@angular-devkit/build-angular : 0.901.7
@angular-devkit/schematics    : 9.1.7
@angular/cli                  : 9.1.7
@ionic/angular-toolkit        : 2.2.0

Hmm, ok so there's a few things here. It's not 100% due to Ionic, but it is something we should probably document.
Basically, the property binding for <ion-nav root=""> is set but the actual CD had been be pretty much turned off. What you need to do is call a private method from angular to do this.
import {
  Component,
  NgModule,
  ChangeDetectionStrategy,
  ɵmarkDirty as markDirty,
} from '@angular/core';
....

export class ProcessComponent {
  ModalPageComponent = ModalPageComponent;
  ionViewDidEnter(){
    markDirty(this)
  }
}

It might make sense to not use onPush here in the ProcessComponent  since it needs to be able to handle this situation.

That is actually what we ended up doing.  It didn't seem like a terrible practice to do that for our situation, as there really is little to nothing in the process component, but we thought it was worth raising the issue in case you were not aware.  I am fine with it if the answer is to just not use OnPush in that situation.  Some documentation to that effect would definitely be nice, though.
Thanks Mike!

Thanks for the issue! I added some clarification to the docs via https://github.com/ionic-team/ionic-docs/pull/1448.

Works for me.  Thanks!


Update site with streaming link and details if it is going to happen.

in src/sections/about.tsx we have commented out section for streaming links, uncomment and update if it is going to happen

Note to Jake - Streaming will happen and will be done by Piotr


Consider annotating InvocationTargetException, ExecutionException, and CompletionException causes as non-nullable

https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/reflect/InvocationTargetException.html
Points in favor of non-nullable:

The no-Throwable constructor overload is protected, not public—and AFAICT is unused both in the JDK and Google's codebase.

Points against:

getCause() explicitly documents that the return value "may be null" :( This may have been copied without a ton of thought from Throwable.getCause(), but I notice that the phrasing does not match that in Throwable.getCause() (at least currently), so it wasn't literal copy-and-paste.
Neither the constructors nor the getters perform a null check on the value.

No signal either way:

getTargetException doesn't mention null.

Hmm, I may be wrong about ExecutionException.
The code I'd remembered from before is here:
https://github.com/jspecify/jdk/blob/cb922063ca52298a36146d73c247cff8195035cd/src/java.base/share/classes/java/util/concurrent/AbstractExecutorService.java#L215-L216
My read was that that would resulting in throwing if the list of tasks were empty.
But the Javadoc (even as far back as JDK 11, maybe earlier) says "throws IllegalArgumentException - if tasks is empty."
And I see multiple guards against emptiness:

https://github.com/jspecify/jdk/blob/cb922063ca52298a36146d73c247cff8195035cd/src/java.base/share/classes/java/util/concurrent/AbstractExecutorService.java#L160-L161
https://github.com/jspecify/jdk/blob/cb922063ca52298a36146d73c247cff8195035cd/src/java.base/share/classes/java/util/concurrent/AbstractExecutorService.java#L180

I'd have to read the code more to see if the code I was worried about can ever actually execute. I could also check whether the behavior changed over time, and I could check whether I wrote about this somewhere in the reference checker.

Here's what I had written in the reference checker: https://github.com/jspecify/jspecify-reference-checker/blob/75aa1de2a8f88f8c23347d86465844df9887874c/src/main/java/com/google/jspecify/nullness/NullSpecAnnotatedTypeFactory.java#L1126-L1148
The link there has broken, but yes, I was referring the code I thought I was: https://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/jsr166/src/main/java/util/concurrent/AbstractExecutorService.java?revision=1.54&view=markup#l185
Even at that version, I see the emptiness checks. So I think I was just wrong about the possibility of a cause-less ExecutionException from that code.
None of that takes away from the fact that ExecutionException (like InvocationTargetException) declares constructors that don't require a cause (and, also like InvocationTargetException, would accept null in its constructors that do require a cause).
In Google's codebase, I don't see any usages of the no-arg ExecutionException constructor except for some in tests (which I didn't look at) and one from a subclass that isn't ever used "as an ExecutionException" AFAICT. (Various classes call that constructor through a super call from one of their own constructors, but then none of those constructors are used except for the one I mentioned.) I didn't go through the larger number of String-only calls (again, calls from subclass constructors that may or may not ever be used). Maybe we'd be so lucky that all those users call initCause, but I doubt it. (In theory, checkers could be made to produce errors for calls to the no-cause constructors, at least when not followed by initCause.)
Anyway, I'm generalizing this issue to be about both types, plus CompletionException, which is similar to the other two. (The only call to its no-cause constructors that I see in Google's codebase is one in Caffeine.)
There are likely even more exception classes whose cause is never null, as noted recently in https://github.com/jspecify/jdk/commit/cb922063ca52298a36146d73c247cff8195035cd. In those cases, we already don't use @Nullable on the getCause overloads. I forget whether I checked the corresponding constructor parameters (if any) or checked the classes for @NullMarked.

On the Guava front:

We followed the ExecutionException pattern for UncheckedExecutionException and ExecutionError :( Perhaps we should deprecate their no-cause constructors, given that I see a very small number of calls for the group as a whole (at least one of which is "for compatibility reasons"). It's not even clear to me that the callers have a need to extend UncheckedExecutionException in the first place (though I wouldn't be at all surprised if some code had special handling for that that they wanted to trigger). Anyone who really wants to have a null cause can call super((Throwable) null) or super(message, null), assuming that we don't additionally crack down on that. In an ideal world, we would have required a non-nullable cause and then overridden getCause() to express that.
Guava's invokeAny implementation (in the form of the package-private MoreExecutors.invokeAnyImpl, which I don't think has any callers in the package) has the preferred behavior of throwing IllegalArgumentException for an empty input. (Other executor implementations, like MoreExecutors.listeningDecorator, inherit the JDK's from `AbstractExecutorService.)
I thought I had some other Guava point, but if I did, I've forgotten....

FWIW the times I have used null in exception constructors has always been calling the super from an inherited constructors and often it is a protected constructor.
So I think you have the right idea on nonnull at least from my experience.

Thanks. That's an interesting point about JEP 447.
(If anyone has experience with really wanting to pass null to these constructors, please also speak up before I do anything regrettable to Guava :))
The other point I'd meant to add was that it could be inconvenient for code like throw new UncheckedExecutionException(executionException.getCause()) to become a nullness error. (To be clear, I'm not planning to go that far for Guava's types just yet (if ever), only to probably deprecate the constructors that don't have a cause parameter at all.) So, if we do make both the constructor parameters and getCause non-nullable for some classes, then it would be nice to keep Guava's classes and the JDK's classes relatively in sync, at least for the small number of users who already use both :) Granted, probably not all that many users are writing code like throw new UncheckedExecutionException(executionException.getCause()) in the first place.

So these are exception types which "should" never have a null cause, as they are specified to be thrown in reaction to some previous exception. Here are my current thoughts FWTW, as usual, from the standpoint of
I think the getCause return type should pretty clearly be non-null, because even in the event that null gets returned, it means something has gone wrong somewhere already. There's a bug, but this is not the place where that bug will be found. This is just another initialization-gap issue like #145, right?
I think the same goes for setCause. There could be code that is calling it repeatedly with nullable expressions and only making sure it's non-null by the end. But I don't think it's too bad if such code has to either restructure or suppress.
As for the constructors, JEP 447 changes nothing for us (for a long time). I feel like they should also be non-null; again, user can restructure or suppress.
(Recall that I view suppressions as just part of life, not evil. I just want the user to have a feeling while doing it like "okay, I can understand why it doesn't know this is safe".)
Do we align?


Fix issue so that we go to the end view after the final round based on the number of rounds set in the lobby

c45d46042bd9e89a36ce3671322bada1ff87b4d3


Update the DG: user stories, glossary, NFRs, use cases

more can be found on the website [here] (https://nus-cs2103-ay2425s1.github.io/website/schedule/week7/project.html)

more can be found on the website [here] (https://nus-cs2103-ay2425s1.github.io/website/schedule/week7/project.html)

All done, updated on numerous PRs.


CGO_ENABLED=0 for all build steps of Dockerfile

When running a docker buildx build for ARM64:
docker buildx build --no-cache --platform linux/arm64/v8 -f Dockerfile -t "any-tag-here" .

The build fails:
 => ERROR [build-env 8/8] RUN set -e ;    go test ./test/*.go;    go test ./pkg/*;    cd cmd/costmodel;    CGO_ENABLED=0 GOOS=linux GOARCH=amd64     go build -a -installsuffix cgo -o /go/bin/app                                                      26.5s
------
 > [build-env 8/8] RUN set -e ;    go test ./test/*.go;    go test ./pkg/*;    cd cmd/costmodel;    CGO_ENABLED=0 GOOS=linux GOARCH=amd64     go build -a -installsuffix cgo -o /go/bin/app:
------
Dockerfile:13
--------------------
  12 |     # Build the binary
  13 | >>> RUN set -e ;\
  14 | >>>     go test ./test/*.go;\
  15 | >>>     go test ./pkg/*;\
  16 | >>>     cd cmd/costmodel;\
  17 | >>>     CGO_ENABLED=0 GOOS=linux GOARCH=amd64 \
  18 | >>>     go build -a -installsuffix cgo -o /go/bin/app
  19 |
--------------------
error: failed to solve: process "/dev/.buildkit_qemu_emulator /bin/sh -c set -e ;    go test ./test/*.go;    go test ./pkg/*;    cd cmd/costmodel;    CGO_ENABLED=0 GOOS=linux GOARCH=amd64     go build -a -installsuffix cgo -o /go/bin/app" did not complete successfully: exit code: 1

Based on this part of the error message:
go build runtime/cgo: gcc: exit status 1

I suspected the missing GCC. After making this commit's changes, the
buildx command succeeds.

Picked into v1.91 by https://github.com/kubecost/cost-model/pull/1078


Invalid conversion with strings concatetation

I'm using Rails 3.1.3 with CoffeeScript support and I've found that following Coffee code:
x = '' + EDIT_TAG_LABEL +'' # no space after last plus sign
is converted to:
x = ''+EDIT_TAG_LABEL('NaN
When I'll add space after plus sign, code is converted correctly.

Haha wow, haven't had one of these for a while. Check the dozens of duplicates and familliarise yourself with the javascript unary + behaviour.


Update item attribute hierarchy

All updates to the files are covered extensively in the comments written within them.

I approve!


Intelligent insights is a preview feature, not available in the following regions: West Europe, North Europe, West US 1 and East US 1

"Intelligent insights is a preview feature, not available in the following regions: West Europe, North Europe, West US 1 and East US 1."
Is this still true?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f07b82de-519d-aed9-8271-6c92eb710cbb
Version Independent ID: cdb3277c-a8c6-5069-692e-548ab5374cb6
Content: Monitor database performance with Intelligent Insights - Azure SQL Database
Content Source: articles/azure-sql/database/intelligent-insights-overview.md
Service: sql-database
Sub-service: performance
GitHub Login: @danimir
Microsoft Alias: danil

@m60freeman We are checking this and will get back to you.

Yes, that is still the case.

@m60freeman Please convey if you have any other question. We will close the thread by EOD.


[BUG] - (v16) After Keyboard Input I get TypeError: time.match is not a function

Cannot set time manually
After a manual input with the keyboard of the time, I get the console error: TypeError: time.match is not a function.
You would get that if time would not be a string.
The error points to your function:
    static parseTime(time, opts) {
        .........
        if (time.match(/\s/g)) {

To Reproduce
Enter the time with keyboard and press enter.
Expected behavior
Manual Time Input is possible.
Desktop (if execution):

Windows
Chrome

** Versions

ngx-mat-timepicker version 16.0.0
@angular/core version 16.0.3
@angular/material version 16.0.2
typescript version 4.9.5

Hi
I definitely need more info.
Can you setup a blitz?
Also, you should use Typescript 5

ok will do the week after, next week I am on vacation...thx

I am running into the same issue.
I have created a stackblitz
The input element is made editable by adding [disableClick]="true". Then after entering a time with the keyboard and leaving the control the error message ERROR Error: time.match is not a function appears.
The full stacktrace with version 16.0.1 as seen in my own application (using Chrome on Windows) is:
22:01:18.086 app.component.html:5 ERROR TypeError: time.match is not a function
    at NgxMatTimepickerAdapter.parseTime (ngx-mat-timepicker.mjs:136:18)
    at NgxMatTimepickerAdapter.formatTime (ngx-mat-timepicker.mjs:72:33)
    at set value [as value] (ngx-mat-timepicker.mjs:2177:46)
    at NgxMatTimepickerDirective.updateValue (ngx-mat-timepicker.mjs:2236:19)
    at NgxMatTimepickerDirective_change_HostBindingHandler (ngx-mat-timepicker.mjs:2272:99)
    at executeListenerWithErrorHandling (core.mjs:15762:16)
    at wrapListenerIn_markDirtyAndPreventDefault (core.mjs:15795:22)
    at HTMLInputElement.<anonymous> (platform-browser.mjs:666:17)
    at _ZoneDelegate.invokeTask (zone.js:402:31)
    at core.mjs:25948:55

The issue is appearing is ng-mat-timepicker version 16.0.1 as well as 15.1.7.

Hi @erikvorstenbosch and thanks for taking the time to create the blitz.
Let me start by telling both of you that in the demo site there's the code to achieve what you need without triggering any errors:

By the way I did some checks and I can already changed the code.
From my tests, I don't see any other triggers of the change Hostlistener so I guess we're fine with the mod.
I'm going to publish on v16 (since it has less active installations than v15). If no one complains I will create a later release for v15 and v14.


Update to LLVM 17

Unfortunately there seems to be a lot of changes needed - such as changing llvm::Optional to std::optional. The CMakeLists.txt does not let me disable the runtime nor will it let me use my system LLVM 17 on Debian because find_package(Clang fails (MLIR and LLVM are found though).
I also don't see a way to pass --target to tsc as it seems to only accept -march. Are you planning on implementing cross compilation support? It seems to support mtriple but not freestanding with -nostdlib.

I was thinking to do it in near future

Alright thanks. I was trying to make a operating system kernel for fun with this compiler and this means I need to compile for bare metal (x86_64-unknown-none). I just realized that I can use tsc to emit llvm IR which can be passed to llc to convert it to an object, and then I can link it with clang. However, I also realized that there does not seem to be a  way to convert the following C program to Typescript with this compiler because there is no pointer -> array dereferencing.
unsigned char *vga_buffer = (unsigned char *)0xb8000;
*vga_buffer++ = 'h';
*vga_buffer++ = 0xFFFFFF;

I tried this:
let x = <Uint8Array>0xb8000;
x[0] = 'h';
x[1] = 0xFFFFFF;

However it segfaults the compiler. I think there would need to be pointer operation functions 🤔  Additionally, The typescript compiler seems to require an async runtime in the emitted llvm IR, and malloc/free and I couldn't find a way to disable it.
Thanks for creating this amazing project by the way, it is something that I've wanted to make for a while.

I just realized that I can use tsc to emit llvm IR which can be passed to llc to convert it to an object, and then I can link it with clang.

you can generate "obj" files in tsc no need to extra steps .. and u can use it in cmake. have a look into \TypeScriptCompiler\docs\how\cmake_vulkan\

However, I also realized that there does not seem to be a way to convert the following C program to Typescript with this compiler because there is no pointer -> array dereferencing.

You can do it in "hacky" way: for example I have construction in the code such as:
type int = TypeOf<1>;
const v = LoadReference<int>(10);

but you can create your C/C++ helper library to use in TypeScript for example:
addr_access.c:
int get_int_by_addr(intptr_t addr)
{
  return *(int*)addr;
}

typescript_file.ts:
type intptr_t = TypeOf<4294967297>;
declare get_int_by_addr(intptr_t);

main()
{
  const v = get_int_by_addr(10);
}

Ideally I wanted to finish "JS Builtin" classes which would allow to work with arrays such as buffer = new Uint8Array(addr);
it would allow to operate with normal classes without direct access to memory

The typescript compiler seems to require an async runtime in the emitted llvm IR

If you are not using async/await compiler will remove unused functions. so just do not use async/await

and malloc/free
you can use gc allocator but do not provide gc.lib and write your own implementation for allocator
so u need to provide your funcation such as GC_alloc, GC_free etc

switched to LLVM 17.0.2


Does Lettuce ReadFrom Setting:NEAREST support latency check like heartbeat, and thus refresh automatically.

Hello everyone, I want your help!
I am using Lettuce in SpringBoot stack, behinds is AWS Elaticache as redis cluster.
Because AWS Elasticache consists of 3 zones, and thus bring out significant latency. I want the read always be redirect to the correct node with the smallest latency.
I found Lettuce ReadFrom Setting:NEAREST may be the one I am looking for.
But when I verify it I found that the request is always redirected to nodes that seemed to be decided once the SpringBoot app is started.
I want to know:
1:  Does Lettuce ReadFrom Setting:NEAREST support latency check like heartbeat, and thus refresh read node candidates.
2: If it is true, How can i customize it?
3: If  I do nothing, what is the truth in Lettuce ReadFrom Setting:NEAREST mode?
About lettuce ReadFrom Setting
https://github.com/lettuce-io/lettuce-core/wiki/ReadFrom-Settings

Please post your question on StackOverflow so we can share it with a broader community.


[CLEANUP] Add space between quotes and plus sign in String concat for readability in flink-yarn module

While working on Flink on YARN, do some simple nit cleanups to add space between quote and plus sign for readability in yarn module for readability.
Use StringBuilder instad of StringBuffer in FlinkYarnClient since the String materializes immediately, so no need synchronize protection.

I like this.
I would actually like to make this a checkstyle rule. Most of the code is in this shape, occasional files go with a different style.

+1
We agree that we would play it loose with style but this kind of cleanup helps readability.
I will send PR to change the check style to be more strict on this kind of violations.

Builds pass, will merge this EOD if no more comment.

+1, good to merge

Thanks @StephanEwen merging ...

Thanks Henry, please add this rule. :)

+1 for adding a rule (otherwise, I will not learn it ;) )

Thanks all, will do


Add getcap "capabilities" for posix files.

Describe the feature:

Describe the solution you'd like

Describe alternatives you've considered

Please add getcap "capabilities" command for posix files.

Hello, thanks for filing this. Can you provide more context in what you're looking for. Perhapse some example test filesband what you're looking to test.
Also, where does the command fall short for you?


Warning is shown when keyboard is shown

When the keyboard is shown a warning that the site is in Landscape is wrongly shown.

Ah, good point.  I'm just checking to see if the window width (or maybe the document width?) is bigger than the height, which is pretty hacky and behaves incorrectly in this case.  I wonder if there is a more robust manner of figuring out orientation now that devices have matured a bit.  Thanks for reporting this.  It might take me a few weeks before I'll have time to address this though, so if you are interested in putting together a fix I'd be thrilled to accept a PR.

Fixed that issue and its working perfect for me i have created a new variable
var windowint = window.innerWidth;
and modified checkOrientationChange();
`
function checkOrientationChange(){
    if(!isMobile && options.onlyMobile){
        if(!init){
            init = true;
            setVisibility(false);
            setBodyClass("hiding");
            options.onHide(); // run this exactly once if not mobile
        }
        return;
    }

    if(currentOrientation !== isPortrait()){
        if(windowint == window.innerWidth){
            currentOrientation = true;
        }else{
            currentOrientation = false;
        }

        orientationChanged();
    }
}

`

or quite simple approach is to modify isPortrait()
 function isPortrait(){         return ( window.innerWidth < window.innerHeight || windowint == window.innerWidth);     }

@mkarya001
Would you mind posting a full version of your script? I'm not getting your changes to work.

@Paran0idAndr0id its work for me

@Paran0idAndr0id download here

Could you fork this repo and create a pull request @mkarya001?  That way I can merge in your fixes so that everyone will get the updates going forward.  Thanks for your help!

@arscan sure


adding MPX specific tools

I'm keeping a list of things to add:
https://github.com/insapathogenomics/mutation_profile/blob/main/README.md

Included vadr and nextclade/nextalign in https://github.com/UPHL-BioNGS/Cecret/pull/112

There are also more primer files to add, like that of primalseq https://github.com/UPHL-BioNGS/Cecret/pull/121#issuecomment-1272096642


Working on Webpack

Here's a list of things I did to migrate to Webpack, as a reminder to myself.

Do not imply the ecmascript package, instead add it individually to each nova:* package (see https://github.com/thereactivestack/meteor-webpack/issues/44).
Pass ReactDOM to ReactRouterSSR and added local copy of the package to fix the multiple copies of React issue (see https://github.com/thereactivestack/kickstart-meteor-react-router/issues/83#issuecomment-224975331).
Add local copy of meteor-webpack to enable resolve.alias (see https://github.com/thereactivestack/meteor-webpack/pull/218).
Add triggerUpdate to AccountsField (see https://github.com/studiointeract/accounts-ui/issues/60)
Import datetime.css from DateTime.jsx.
Get rid of client-only files (use Meteor.isClient instead), for example in nova-events package.
Replace import Foo from 'meteor/nova:foo' with import Foo from 'nova-foo'.
Add const to variables (Foo = "bar" to const Foo = "bar") everywhere.
Create export.js and server.js files when necessary.

TODO:

[ ] Figure out nova-newsletter bug.
[ ] Find solution for email templates (maybe this?)
[ ] Fix server-side reloading.
[ ] Make SSR work.

hi, @SachaG @xavcz
perhaps you are not interested in webpack build now, or focus on Telescope 1.0.0 and graphql.
but after i tried,  i found some solutions about this issues.
i created a meteor react tutorial demo, use meteor-webpack to build, and change the project structure like Telescope. so you will understand it easier.
see: https://github.com/comus/todoscope
how to run it
git clone
cd .....
meteor npm install

for development: METEOR_PACKAGE_DIRS=meteor_packages meteor
for production: METEOR_PACKAGE_DIRS=meteor_packages meteor --production
the solutions:

Fix server-side reloading.
use METEOR_PACKAGE_DIRS

Make SSR work.
in your telescope:webpack2
see: https://github.com/TelescopeJS/Telescope/blob/webpack2/src/server.js
may be you forgot require base-components, so SSR not work

Waow @comus, great job!!
I believe we'll migrate to Webpack, or offer an easy path to do it, at some point after gathering feedbacks on the GraphQL API.
What do you think @SachaG?

there are also someone use webpack and meteor too

Crater
A new app skeleton for Meteor/React
Meteor/Webpack/React SSR app skeleton that runs your app code outside of Meteor Isobuild
https://github.com/jcoreio/crater

Nice! I'll have to look at this in more detail, but basically my conclusion was that I didn't want to depend on the meteor-webpack package, and that we'd probably wait until we switch out of Meteor completely to migrate to Webpack.
That being said if there's a good way to migrate to Webpack now while remaining on Meteor, why not. Anything we can do to smoothen the transition is good! :)

What's the status about Webpack and Vulcan?
Great job. Thanks!

No real plans for now, we're waiting to see how Meteor's build tool evolves since a lot of new improvements are announced for 1.5.

I'm interested with webpack/gulp and npm combo for modular app development.
It has the same concept/architecture as vulcan, but rather than meteor it's
webpack/gulp, and rather than atmosphere it's npm. I'm also hesitant to
start because im looking for what meteor can offer next
On Apr 22, 2017 10:20 PM, "Sacha Greif"<EMAIL_ADDRESS>wrote:

No real plans for now, we're waiting to see how Meteor's build tool
evolves since a lot of new improvements are announced for 1.5.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/VulcanJS/Vulcan/issues/1427#issuecomment-296376369,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK0ceLuauWWQWkosRnD9t8vKYWsVvBJks5rygysgaJpZM4JjltT
.

Closing as we would basically need more work on the Meteor side for this, or moving away from Meteor. Storybook provides an experimental example of using Vulcan with Webpack. It's based on naming conventions to find each package client-side code, and scraps out Meteor specific code that can't be imported correctly.
Next step would be loading some Vulcan package in a Next app for example.


Reverse parameters in build_clone tests

APIdocs recommends having "expected" as the first parameter
and "actual" as the second parameter.
This was pointed out to be in a comment on PR #309.
cc @benilovj @jamiecobbett

:+1: :+1:


slider touch not working in android touch works perfectly in IOS

"react-native-slider": "^0.11.0",
"version": "2.0.3",  "name": "react-native-media-controls",
Please let me know what I need to do

oh its working fine android works with elevation instead of zIndex


Goreleaser is failing since vm ISO support was merged

I didn't realize this until #128 was merged but the integer contsants used in that branch are causing overflows on i386 arches
   ⨯ release failed after 15.96s error=failed to build for linux_arm_6: # github.com/ddelnano/terraform-provider-xenorchestra/client
client/vm.go:373:10: constant<PHONE_NUMBER> overflows int
client/vm.go:386:8: constant<PHONE_NUMBER>0 overflows int
client/vm.go:393:8: constant<PHONE_NUMBER>0 overflows int

This will need to be fixed before the next release can be made

I updated the goreleaser config file to ignore the 386 and ARM 6 architectures (see a71e0a4bf40c1d8d53748c3b2f3e0931de50a915,  fb8cfe3afc0df101aca6d443955667d66a358f9e and 270d077d72c0483f0b95de985345b00f156f373f). Since these are 32bit it's unlikely that someone was using these (given the integers needed to create real VMs would be > 4 GB).


how to remove diagnosticMessages.generated.json

142kB  dist/typescript/lib/zh-tw/diagnosticMessages.generated.json
144kB  dist/typescript/lib/zh-cn/diagnosticMessages.generated.json
153kB  dist/typescript/lib/cs/diagnosticMessages.generated.json
160kB  dist/typescript/lib/tr/diagnosticMessages.generated.json
161kB  dist/typescript/lib/pt-br/diagnosticMessages.generated.json
164kB  dist/typescript/lib/es/diagnosticMessages.generated.json
165kB  dist/typescript/lib/pl/diagnosticMessages.generated.json
165kB  dist/typescript/lib/it/diagnosticMessages.generated.json
165kB  dist/typescript/lib/fr/diagnosticMessages.generated.json
167kB  dist/typescript/lib/de/diagnosticMessages.generated.json
169kB  dist/typescript/lib/ko/diagnosticMessages.generated.json
187kB  dist/typescript/lib/ja/diagnosticMessages.generated.json
215kB  dist/typescript/lib/ru/diagnosticMessages.generated.json

Because these files are used by TypeScript, and your app is using TypeScript, we need to include them in case those codepaths apply. Do you definitely need require('typescript') in this app?
We don't currently have explicit asset exclusions, but we do have debugging to work out why they are emitted if they aren't supposed to be.
I get the feeling the above are correct emissions though for supporting TypeScript execution.


AndroidSecureArea keys creation improvements

Partly Fixes #360

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

We did review the PR internally, and now we making it open. We have addressed the requested changed.
What's still missing:

the implementation of the class that loads the device capabilities (called KeystoreUtil, currently returning all flags hardcoded to true) - we'll need @davidz25 help to do the implementation.
the BoucyCastle related implementation

I checked out the branch and did a quick testdrive, some observations

When changing "mdoc ECDSA authentication" to "mdoc MAC authentication" (and not changing anything else), the credential is created but we crash at presentation time. The problem is that addDocumentToResponse() doesn't check if it should use sign() or keyAgreement() depending on the purpose of the chosen authentication key (it just always uses sign()). Should be simple to fix?
"User authentication on" sounds a bit off, I think "Require User Authentication" is better
We have "Hardware Backed" in details for each Authentication Key. Seems like a leftover, I think that should probably be "Secure Area" instead?
The auto-close connection problem mentioned above is still there (appholder goes to main screen after first consent dialog)


Add Firebase Cloud Function OAuth client to the list of external clients

Summary
I've written a GitHub OAuth client that can be deployed as a Firebase Cloud Function. Just adding it to the list.
Test plan
No code was changed, only website markdown.

Deploy preview for cms-demo ready!
Built with commit c167a7d2fb99ee9e9c894e530383a9d17e1646a9
https://deploy-preview-1773--cms-demo.netlify.com

Awesome, thanks 👍 👍


Add simple recognition demo

Add a simple demo to showcase only speech recognition functionality.

What about this one? Something blocking you?

Yeah Siebe needs to finish fixing up bugs. He disabled the calls required.


paybox_hidden_fields helper trouble

As I wrote here : https://github.com/slainer68/paybox_system/issues/2, the rails helper method escape strings values. If these values contains special chars, the HMAC returned by hash_form_fields_from is not calculated on same values.
We could prefer to change hash_form_fields_from and make an escape on each value, but I am afraid i could change the 'PBX_RETOUR' and other fields needed :-(
Nicolas

+1, This is very important, without it, the gem is useless now ...


[formrecognizer] Fix get operations samples

These samples fail when no operations are returned.

I'm a little curious why this sample passes in most CI environments, but not all. Since the samples run after all test cases there should be plenty of operations to return in the 24h window.
But I do think this change is a good addition anyway in case someone tries to run the sample having not created any operations yet.

Yeah I had the same thought, my reasoning was that those environments that fail are either too fast or slow so there are no operations left by the time it reaches those samples.


[mp] Simplify Getting Started for Contributors

Description
This PR creates a more cohesive environment setup guide in our docs and updates our README_dev.md to give full details on how to get started contributing to Mage. It also includes a demo video on running the build scripts— init.sh & dev.sh.
How Has This Been Tested?

[x] I ran the commands and worked through the guide.

Checklist

[x] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation

Should be g2g here

I was going to leave more comments, but realise I might be interested in knowing why you made those structural changes (apart from installing hooks, that definitely should be put in the setup part, right after cloning the repo). Is there anything wrong with the current version?

@wangxiaoyou1993 I reworked this a bit.


Permanent floating window

Environment (please complete the following information):

OS: osx
(Neo)Vim version: 0.4
vim-clap version: 0.1(?) latest as of right now

Describe the bug
It is possible to get into scenarios where the floating window is permanently on screen and prevents you from continuing to use that vim instance.
To Reproduce
As far as I can tell, this is due to mappings still being picked up when in normal mode on the floating window buffer.

Given mappings

map <Leader>o :Clap gfiles<cr>
map <Leader>b :Clap buffers<cr>

type <leader>o
type something (or not)
hit escape once (i assume this is a feature, being able to use normal vim navigation on what you typed). the floating window should still be visible.
type <leader>b
now you're stuck, no matter what you do (escape multiple times, selecting an item, etc) there should be a floating window above everything.

Expected behavior
Probably :Clap inside a clap floating window shouldn't do anything? I like the ability to hit escape once and edit my input as normal vim input, so not allowing all the mappings (if that's an option) is probably not ideal.

I don't quite understand what your issue is. Please provide the minimal vimrc and reproducible steps, and screenshot or GIF if possible.

Sorry, <leader> outside code blocks just hides the leader bit.
But also sorry, I had assumed the ability to hit escape once and remain in the floating window (and twice to exit) was a feature. I guess with the minimal vim, that appears to be not true.
Once I determine why this is happening, what are the odds that can be a feature, and the subsequent fallout it causes could be fixed?

So this turns out to be an interaction with https://github.com/cohama/lexima.vim
set nocompatible
set runtimepath^=~/.local/share/nvim/site/plugged/vim-clap/
set runtimepath^=~/.local/share/nvim/site/plugged/lexima.vim/

map <Leader>o :Clap gfiles<cr>
map <Leader>b :Clap buffers<cr>
syntax on
filetype plugin indent on

I guess specifically because lexima has this inoremap <unique> <Esc><Esc> <Esc> mapping.

Currently ESC is truly meant to exit, see https://github.com/liuchengxu/vim-clap/blob/master/ftplugin/clap_input.vim, but I think it could be improved in future to utilize the multiple mode feature of vim. For instance, we could use the normal mode mappings for the actions mentioned in #51, but the design is not clear now.

So i didn't have a lot invested in lexima, i pretty trivially switched to delimitMate which does not appear to have the same behavior.
However, if you think enabling normal mode navigation on the text input is possible, then maybe this can turn into a feature request?
The 2 big issues i noticed when seeing this behavior was:

:Clap when there was already a clap floating window open should no-op
things like bnext would take focus away and leave the window open.

With those addressed (if possible), i think that'd be a totally usable mode.

:Clap when there was already a clap floating window open should no-op

What's the meaning of no-op?

things like bnext would take focus away and leave the window open.

This is not a complete design.

Just so we're clear on the behavior I was experiencing (and happen to like)

What's the meaning of no-op?
by no-op, I mean: If :Clap were to do nothing if there was a clap floating window already visible; then it wouldn't be possible to recursively open clap from inside clap's window. Not even as a feature, this seems like maybe seems like a good behavior to guard against actual bugs anyways, no?

by my comment about bnext, i meant that that's another case where the floating window stays permanently open and control goes back to the original buffer instead of the floating window. Similarly to the above, if you know of a way to prevent this from happening, i can live with the wonky unintended behavior i was experienced, without any changes to clap itself.

navigate the result list like the insert mode.
run some command on the current selected item or multiple selected items.
So the current behavior is that normal in-line command (e.g. b, e, ciw) operate on the query, and that's what I would want. The main additional thing that'd be nice is if j and k moved up and down in the result set in command mode.

I'm not particularly interested in performing other commands on the items themselves really, so i'll leave that unspecified.

the popup of vim is unable to be focused
I suppose that's a problem if this is more complicated or impossible with vim.

this seems like maybe seems like a good behavior to guard against actual bugs anyways,
This actually should be achieved by not opening new windows if they already exist.

Current only the behavior in insert mode of the input window is guaranteed, otherwise it's all not well defined, although you can try <C-W>W to jump around all the windows without closing clap when in the normal mode, but that may be changed later. Again, the behaviors in the normal mode are not specified at the moment.

The main additional thing that'd be nice is if j and k moved up and down in the result set in command mode.

That's actually the input history if I'm right, which could be added eventually.


How about add a api for convert map to structs?

I think it is very useful.  struct -> map -> struct,  for completeness. 💯

Thanks @cupen  I'm thinking about it in v2 of this package


Discord

Please create a discord server

I am still working on building a stable version for this app, tell me if you tried :)


Sidenote using footnote syntax

Taking @mmcky and @choldgraf's comments into account. Implemented the sidenote and marginnote using footnote syntax as the first step. Changing footnote nodes to sidenote and inline element nodes in a post-transform. This does not create any new syntax to write sidenotes and uses the already available footnote syntax. To convert all footnotes to sidenotes, the config variable is - use_sidenotes: True under html_theme_options. To convert a sidenote to marginnote (i.e. not haveing superscripted numbers), use {>} at the start of the footnote source text (similar syntax was first proposed in https://github.com/executablebooks/sphinx-book-theme/pull/523#issuecomment-1069154993).
Example:
Source Code:
On wide screens, margin content will pop out to the side of the page and allow content underneath it to move upwards[^myref].
This allows you to provide extra information without interrupting the flow of information.

There are many other things that you can do with the Sphinx Book Theme.
Now that you've gotten a start, check out the other sections to the left to learn more about how to use it[^3].

[^myref]: Some footnote text

[^3]: And here's a longer margin block-level element...
      :::{note}
      ...with a note inside.
      :::

Footnote:

Sidenote:

When modifying the above source code with:
[^myref]:  {>} Some footnote text

The output is:

Note that sidenotes do not support any directives inside it as it is an inline element. Tufte also uses inline span elements. The reason span makes more sense than aside in my opinion is mentioned in the 31st March description below.
NOTE: The functionality of clickable text/icon on smaller screens as was implemented in https://github.com/executablebooks/sphinx-book-theme/pull/523, is also present in this PR.
31st march
Was trying to implement sidenote leveraging the footnote code and syntax as discussed in https://github.com/executablebooks/sphinx-book-theme/pull/523 . I tried going through the docutils code, where the footnote is implemented.
I have a few concerns which I wanted to discuss:

the insertion of footnote node in the document happens during the parsing phase I think. And possibly the only place to rearrange the document to make the footnote node move near the footnote-reference is during a post-transform.

It was much easier to deal with span elements we generated here https://github.com/executablebooks/sphinx-book-theme/pull/523 for sidenotes, and which Tufte CSS uses as well, to position the sidenote. As span can go inside a p tag, and other similar tags, which will have the sidenote reference inside it. And so relative positioning is pretty straightforward. The aside tag on the other hand, when trying to insert inside a 'p' tag in post-transform, does not work, and it is always inserted after the p tag, which makes it hard to position.

cc: @choldgraf @chrisjsewell @mmcky @rowanc1

@AakashGfude I have been taking a look at this PR in addition to #523 and from a developer perspective it seems to me that it would make sense to:

Develop the concept of a sidenote as a feature with supporting visit and depart methods for html and latex
Add a global option footnote_as_sidenote: [True/False] which enables a sphinx.transform to move footnote objects (visually) to sidenote objects in the AST to be parsed by sidenote writers.

To me this flow seems more logical rater than overloading the footnote objects to create sidenote style of output. Some of the benefits of this approach are improvements made to sidenote feature are automatically gained if we use a transform to move footnotes to sidenote nodes in the AST.

Thanks, @mmcky, that sounds like a reasonable way to go. I will approach it that way and see how it feels.

made changes, and updated the top description.

Thank you so much @choldgraf, for the additions, very useful.

* I noticed that having multiple margin notes in the same sentence does not work on mobile screens, I think it's because the `for` is pointing to the same thing in both cases, can you fix that?

Have pushed the fix now.

* I think that it'd be good to have some visual cue that the numbers/symbols are "clickable" on mobile - maybe they can still be blue? Or some other way to suggest they can be clicked?

Yes, I think the original color (blue) seems like a good option. As the user is already used to assuming that it is a clickable reference? Have pushed the change. Let's see how it feels.

I think the current implementation is pretty good to me. The behavior is nearly identical to how pandoc-sidenotes works, so we're not reinventing the wheel from a UX perspective or anything.
One thing I noticed: If you have a marginnote in between two sidenotes, it still takes up a "number" even though it is not actually numbered (so the sidenotes will jump from 1 to 3 even though there is no 2). Is that easy to fix? If not it's not a blocker on this PR in my opinion.

One thing I noticed: If you have a marginnote in between two sidenotes, it still takes up a "number" even though it is not actually numbered (so the sidenotes will jump from 1 to 3 even though there is no 2). Is that easy to fix? If not it's not a blocker on this PR in my opinion.

ooh yeah, it's because we are converting footnotes to sidenotes/margin notes and using the numbering of footnotes. margin notes were also footnotes and had a number.

@choldgraf This looks ready to go 🚀

@AakashGfude this is looking great. Thanks for working on this.
Will this get "inherited" by any downstream themes such as quantecon-book-theme?

Apart from mentioning pandoc-sidenote. Thought you would be a better person to put it in the docs.

 I can pitch in with some suggestions if needed -- feel free to slack/zoom.

Will this get "inherited" by any downstream themes such as quantecon-book-theme?
yes, it will.

 I can pitch in with some suggestions if needed -- feel free to slack/zoom.

I have done a futile attempt here https://github.com/executablebooks/sphinx-book-theme/pull/546/commits/8cc71d9e1be5e5c6d1ba0cef2f82a9dd84c450e0

@choldgraf should we merge this?

Friendly ping here @AakashGfude - let me know if you don't have time for another cycle here, or if you'd like to give this another quick push so we can merge

Friendly ping here @AakashGfude - let me know if you don't have time for another cycle here, or if you'd like to give this another quick push so we can merge

Hi, @choldgraf will review this tomorrow, was traveling for a few days.

@AakashGfude no worries - I just wanted to see if you still had the bandwidth for another cycle or if you wanted to spot-check these things in future PRs. I think anything that turns out to be complex doesn't need to be a blocker on this PR, but figured I'd give a final round of feedback in case it helps :-)

@AakashGfude no worries - I just wanted to see if you still had the bandwidth for another cycle or if you wanted to spot-check these things in future PRs. I think anything that turns out to be complex doesn't need to be a blocker on this PR, but figured I'd give a final round of feedback in case it helps :-)

Yes for sure, thanks for taking out the time to suggest further helpful improvements. Really appreciate it :)

I think for the "nested footnotes" bug, one hacky (but maybe reasonable?) way to solve this would be to do something like:

Move the footnote content next to the footnote reference, like we do now
Check whether the parent of this location is the document. If not, then the footnote content to just before the parent node.
Repeat this process until the footnote content's parent is now the document itself

Thanks for the commits and the suggestions @choldgraf.
And also for putting forward your suggestion for the algo,i.e., nested sidenotes/margin notes. Have implemented a basic one in https://github.com/executablebooks/sphinx-book-theme/pull/546/commits/ac9dcabf10015fb7feea6b159d9aaf8879efa81e. Let me know if you can think of edge cases. I will write a test case for it tomorrow morning, and check for any improvements.

It looks good! One UX bug I noticed is that on narrow screens for a side/marginnote inside an admonition, clicking it doesn't seem to have an effect

It looks good! One UX bug I noticed is that on narrow screens for a side/marginnote inside an admonition, clicking it doesn't seem to have an effect.

Yeah, this is a tricky one, as we have placed the text outside the admonition. Will have to think of something.

It looks good! One UX bug I noticed is that on narrow screens for a side/marginnote inside an admonition, clicking it doesn't seem to have an effect.

@choldgraf has resolved it, by keeping two copies of the side/marginnote text. One outside admonition as discussed. And one in the original place which remains hidden when on a desktop. When using mobile, the hidden one is visible.

What do you think?

OK I think I fixed up the docs conflict, wanna take a look and let me know if it reads OK to you?
Other than that, anything else you'd like to tackle here?

@choldgraf the doc looks good to me. Thank you!
I could not use the d-none class instead of d-n like you mentioned here https://github.com/executablebooks/sphinx-book-theme/pull/546#discussion_r872050295. As d-none class in pydata-sphinx-theme has display:none !important in it, which is preventing it from being overridden.
Else I think rest is good.

Thanks very much @AakashGfude for this addition!

Thank you, @choldgraf.


Handle free private repos

:warning:  somebody else (@espy ?) should formulate the issue-text

(can be merged with the suggestions above applied)


IPython+Ubuntu won't autocomplete on %run

Hello, I've just seen your rather awesome library. Some of it works great, a common feature that I use ("%run ") doesn't work. Maybe I'm missing something?
I'm on Ubuntu (Linux Mint 17.1 based on Ubuntu 14.04), using Python 3.4.2 (via Anaconda) with ptpython 0.4 (installed using pip today) and IPython 2.2.0. I'm using a default Ubuntu terminal.
If I type:
$ ptipython
...
In [1]: open("i
insert_pickle_into_elasticsearch.py  File <- really neat autocompletion!
but if I try:
In [1]: %run i <- nothing happens, no autocompleteion
and if I continue to type the filename (e.g. "%run insert_") and try tab, nothing happens and there are no options. Does Jedi know about %run filename completion?
If I use the exclamation-mark shell convention:
In [1]: !autopep8 -i insert_
to run a shell command outside of IPython, tab completion fails here too (but if I type the full filename, autopep8 works as expected).
Both the above examples work with tab completion inside a normal IPython shell.
Sidenote - I'm not sure how the keybindings work on other platforms but if I use Ctrl-Shift-N (as noted in your README "Tab and shift+tab complete the input. In Vi-mode, you can also use Ctrl+N and Ctrl+P.") then I get a new Ubuntu Terminal (!).
I'll keep tabs on this, it looks most promising!

Thanks for the complements.
The reason that %run does not autocomplete is simply because it hasn't been implemented yet.
It's doable though. The hard part is to now which magic commands expect a filename as argument and which don't. The reason that "open('i" autocompletes is because we simply have autocompletion on filenames inside string literals. We can of course hard-code that %run needs to be followed by a filename, but maybe there are others.
About Ctrl+N: it is possible that your terminal application catches this shortcut before it even reaches ptpython. Most terminal applications (gnome-terminal in your case) have the option to configure shortcuts. These are captured and not send to the application running inside the terminal.
So, either you remove the default Ctrl-N binding in gnome-terminal, or you use Tab. I'm also thinking on having key bindings for ptpython configurable, but that will be a real challenge.

Hey there. For me %run is an everyday part of my IPython use. I'm a data scientist, building throw-away scripts and prototyping them at the cmd line (or building them up using GVim) is my normal mode.
If %run were to work with tab-completion then I'd probably switch to ptipython daily, having auto-complete via jedi (which I already have in vim) is rather lovely. I can't offer dev time (sorry!) and I appreciate you've got plenty to do but take this a strong +1 from me for %run support (and whilst a hacky solution is hacky, I wonder how many other folk use %run as their 90%-of-the-time magic?).
Re. Ctrl-N - figured as much. Keybindings across platforms are only every tricky! That's not a deal-breaker for me, just an observation maybe to add to the README if it trips others too.
I'll aim to mention ptipython at my next PyDataLondon meetup, it should bring you a bunch of curious new IPython users.

Thanks for the explanation. I try to make priority of the %run-autocompletion.

Hi @ianozsvald
I just implemented autocompletion for %run and did the same for 16 other IPython commands. It wasn't really hard to do. See this commit: https://github.com/jonathanslenders/ptpython/commit/8663d02eab164093e0f03ccd9a16283a0696b9ab#diff-690303871df694cf38fa5735d9c843beR64
One question. Are you willing to try it before I push a new version to Pypi. I need you to clone this repository. Run python setup.py install and start ptipython again. Tell me whether it works for you. Then I can release a new version to Pypi.
Also, if you use some other IPython magics that need autocompletion, but don't have it yet. Please tell me.
Thanks for willing to mention ptipython at PyDataLondon, I really appreciate that, and I hope you are able to do it.
Cheers!
Jonathan

I've been using  for an hour, this is clear improvement, cheers! This introduces some other edge cases but (for me at least) this is now usable, so I'll try it all today and report anything else I come across.
Specifically:
"%run <dir/script>" works with tab-completion :-)
"%cd " tab-completes as expected
"%run <dir/script> " doesn't tab-complete on the second argument (but IPython does)
"cd " generates a syntax error, this works in IPython (cd is a shortcut to %cd in IPython)
Re. pydatalondon - sure, approximately 100 people should see it and I sent it out on my twitter account (@ianozsvald) last night

Thanks for the feedback! I appreciate it.
About "cd ", that's a tricky one, because the grammar is a bit ambigue. "cd" could also be a Python variable. But I have solved a similar problem some time ago for "ptpdb". It is fun. :)

Hi @ianozsvald,
Closing this one. I think all auto completions that you asked for were implemented.
Please create a new issue in case you still find some bugs.
Jonathan


SecureSocket.initialize fails if certificate database path is non-ASCII

Due to the Mozilla bug "NSS does not allow specifying a profile path containing characters outside of the system native codepage", the Dart SecureSocket class can't be initialized with a certificate database with a non-ASCII path.
See
https://bugzilla.mozilla.org/show_bug.cgi?id=336829
Since there doesn't seem to be a fix unless it is fixed upstream, I will mark the priority low on this issue.
Users have encountered this issue when running pub, from an installation directory with a non-ASCII path.
See issue https://code.google.com/p/dart/issues/detail?id=15364

This issue is stale (obsolete), because NSS has been removed from Dart, and replaced with OpenSSL.


libaarhusxyz PR 29 - Flightline splitter

closes https://github.com/emerald-geomodelling/libaarhusxyz/issues/30

Also, this issue https://github.com/emerald-geomodelling/libaarhusxyz/issues/31 is resolved by this pull request

Superseeded by changes copied manually to master


Handle gasPrice is equal 0

What about validation on the front-end?

It shoudn't happen, because we should block action buttons when gasPriceComponent doesn't loaded yet


Traefik triggers letsencrypt rate limit

Do you want to request a feature or report a bug?
Bug
What did you do?
I checked for storage path and docker bind mound to be correct but when i restart traefik or a container hooked up to it. It tries to renew or create a new certificate. But in my acme.json are all currently valid certificates save and valid until October 2021.
I deployed a container about 5-7 times to test some seo stuff and meta tags for preview rendering in facebook or slack.
Everythings works so far but in the traefik logs i saw an error of lets encrypt that i triggered the rate limit for that domain, but traefik uses the already valid cert ( i think its a fallback if other fails ). So i only recognized it because of the traefik logs.
Output of traefik version: (What version of Traefik are you using?)
traefik:v2.4
What is your environment & configuration (arguments, toml, provider, platform, ...)?
docker-compose.yml:
version: "3.3"

services:
  traefik:
    image: "traefik:v2.4"
    container_name: "traefik"
    restart: always
    ports:
      - "80:80"
      - "443:443"
    networks:
      - proxy
    volumes:
      - ./letsencrypt:/letsencrypt
      - ./traefik.yml:/traefik.yml:ro
      - /var/run/docker.sock:/var/run/docker.sock:ro
    labels:
      traefik.enable: "true"
      traefik.docker.network: proxy

      # Global redirection: http to https
      traefik.http.routers.http-catchall.rule: HostRegexp(`{host:(www\.)?.+}`)
      traefik.http.routers.http-catchall.entrypoints: http
      traefik.http.routers.http-catchall.middlewares: wwwtohttps

      # Global redirection: https (www.) to https
      traefik.http.routers.wwwsecure-catchall.rule: HostRegexp(`{host:(www\.).+}`)
      traefik.http.routers.wwwsecure-catchall.entrypoints: https
      traefik.http.routers.wwwsecure-catchall.tls: "true"
      traefik.http.routers.wwwsecure-catchall.middlewares: wwwtohttps

      # middleware: http(s)://(www.) to  https://
      traefik.http.middlewares.wwwtohttps.redirectregex.regex: ^https?://(?:www\.)?(.+)
      traefik.http.middlewares.wwwtohttps.redirectregex.replacement: https://$${1}
      traefik.http.middlewares.wwwtohttps.redirectregex.permanent: "true"

      # middleware: default security headers for all
      traefik.http.middlewares.securityHeader.headers.customFrameOptionsValue: "SAMEORIGIN"
      traefik.http.middlewares.securityHeader.headers.sslRedirect: "true"
      traefik.http.middlewares.securityHeader.headers.contentTypeNosniff: "true"
      traefik.http.middlewares.securityHeader.headers.browserXssFilter: "true"
      traefik.http.middlewares.securityHeader.headers.forceSTSHeader: "true"
      traefik.http.middlewares.securityHeader.headers.stsIncludeSubdomains: "true"
      traefik.http.middlewares.securityHeader.headers.stsSeconds: "31536000"

      # tls min version
      traefik.tls.options.default.minVersion: "VersionTLS12"

      # traefik Dashboard
      traefik.http.routers.traefik.entrypoints: "http,https"
      traefik.http.routers.traefik.middlewares: securityHeader
      traefik.http.routers.traefik.service: api@internal
      traefik.http.routers.traefik.rule: Host(`###########`)
      traefik.http.routers.traefik.tls.certresolver: secure
      traefik.http.routers.traefik.tls.domains[0].main: "#########"
      traefik.http.routers.traefik.tls.options: default

networks:
  proxy:
    external: true

traefik.yml:
global:
  checkNewVersion: true

api:
  dashboard: true
#  debug: true

entryPoints:
  http:
    address: ":80"
  https:
    address: ":443"
    forwardedHeaders:
      insecure: true

providers:
  docker:
    exposedByDefault: false

certificatesResolvers:
  secure:
    acme:
      tlsChallenge: {}
      httpChallenge:
        # used during the challenge
        entryPoint: http
      email: ###########
      storage: /letsencrypt/acme_prod.json
      caServer: https://acme-v02.api.letsencrypt.org/directory
#      storage: /letsencrypt/acme_stagging.json
#      caServer: https://acme-staging-v02.api.letsencrypt.org/directory #staging

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
 time="2021-03-03T19:54:19Z" level=error msg="Unable to obtain ACME certificate for domains \"*****.de\" : unable to generate a certificate for the domains [******]: acme: error: 429 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-order :: urn:ietf:params:acme:error:rateLimited :: Error creating new order :: too many failed authorizations recently: see https://letsencrypt.org/docs/rate-limits/" providerName=secure.acme

Hello,

But in my acme.json are all currently valid certificates save and valid until October 2021.

The LE certificates are valid for 3 months only, it seems impossible to get a valid certificate until October 2021.
The current max validity date is 90 days after now: June 01, 2021
https://letsencrypt.org/docs/faq/#what-is-the-lifetime-for-let-s-encrypt-certificates-for-how-long-are-they-valid
Check your acme.json file, be sure that your certificates are not from the LE staging.

Hi ok thats strange but is it possible that if the cert is from last year that the expire date is more than 3 month ?
and my acme.json is correct so far
  "secure": {
    "Account": {
      "Email": "############",
      "Registration": {
        "body": {
          "status": "valid",
          "contact": [
            "#################"
          ]
        },
        "uri": "https://acme-v02.api.letsencrypt.org/acme/acct/79107981"
      },
      "PrivateKey": "############",
      "KeyType": "4096"
    },

i Noticed that traefik tries to check my certificates on every container i startup and join into my network and to traefik.
Everytime it did a ACME Lookup so if i test some projekts and need to restart my container it always triggers the acme even if there is already a cert in my acme.json and its valid and not expired.
{"level":"error","msg":"Unable to obtain ACME certificate for domains \"xxxxxxxx\" : unable to generate a certificate for the domains [xxxxxxxe]: acme: error: 429 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-order :: urn:ietf:params:acme:error:rateLimited :: Error creating new order :: too many failed authorizations recently: see https://letsencrypt.org/docs/rate-limits/","providerName":"secure.acme","time":"2021-03-27T20:52:52Z"}
{"level":"error","msg":"Unable to obtain ACME certificate for domains \xxxxxx" : unable to generate a certificate for the domains [xxxxxxxx]: acme: error: 429 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-order :: urn:ietf:params:acme:error:rateLimited :: Error creating new order :: too many failed authorizations recently: see https://letsencrypt.org/docs/rate-limits/","providerName":"secure.acme","time":"2021-03-27T20:52:52Z"}

My Traefik .yml
global:
  checkNewVersion: true

api:
  dashboard: true
#  debug: true

log:
  filePath: /logs/traefik.log
  format: json
  level: ERROR

entryPoints:
  http:
    address: ":80"
  https:
    address: ":443"
    forwardedHeaders:
      insecure: true

providers:
  docker:
    exposedByDefault: false

certificatesResolvers:
  secure:
    acme:
      tlsChallenge: {}
      httpChallenge:
        # used during the challenge
        entryPoint: http
      email<EMAIL_ADDRESS>      storage: letsencrypt/acme_prod.json
      caServer: https://acme-v02.api.letsencrypt.org/directory
      #storage: letsencrypt/acme_stagging.json
      #caServer: https://acme-staging-v02.api.letsencrypt.org/directory #staging

my Docker-Compose
version: "3.3"

services:
  traefik:
    image: "traefik:v2.4"
    container_name: "traefik"
    restart: always
    ports:
      - "80:80"
      - "443:443"
    networks:
      - proxy
    volumes:
      - ./letsencrypt:/letsencrypt
      - ./logs:/logs
      - ./traefik.yml:/traefik.yml:ro
      - /var/run/docker.sock:/var/run/docker.sock:ro
    labels:
      traefik.enable: "true"
      traefik.docker.network: proxy

      # Global redirection: http to https
      traefik.http.routers.http-catchall.rule: HostRegexp(`{host:(www\.)?.+}`)
      traefik.http.routers.http-catchall.entrypoints: http
      traefik.http.routers.http-catchall.middlewares: wwwtohttps

      # Global redirection: https (www.) to https
      traefik.http.routers.wwwsecure-catchall.rule: HostRegexp(`{host:(www\.).+}`)
      traefik.http.routers.wwwsecure-catchall.entrypoints: https
      traefik.http.routers.wwwsecure-catchall.tls: "true"
      traefik.http.routers.wwwsecure-catchall.middlewares: wwwtohttps

      # middleware: http(s)://(www.) to  https://
      traefik.http.middlewares.wwwtohttps.redirectregex.regex: ^https?://(?:www\.)?(.+)
      traefik.http.middlewares.wwwtohttps.redirectregex.replacement: https://$${1}
      traefik.http.middlewares.wwwtohttps.redirectregex.permanent: "true"

      # middleware: default security headers for all
      traefik.http.middlewares.securityHeader.headers.customFrameOptionsValue: "SAMEORIGIN"
      traefik.http.middlewares.securityHeader.headers.sslRedirect: "true"
      traefik.http.middlewares.securityHeader.headers.contentTypeNosniff: "true"
      traefik.http.middlewares.securityHeader.headers.browserXssFilter: "true"
      traefik.http.middlewares.securityHeader.headers.forceSTSHeader: "true"
      traefik.http.middlewares.securityHeader.headers.stsIncludeSubdomains: "true"
      traefik.http.middlewares.securityHeader.headers.stsSeconds: "31536000"

      # tls min version
      traefik.tls.options.default.minVersion: "VersionTLS12"

      # traefik Dashboard
      traefik.http.routers.traefik.entrypoints: "http,https"
      traefik.http.routers.traefik.middlewares: securityHeader
      traefik.http.routers.traefik.service: api@internal
      traefik.http.routers.traefik.rule: Host(`xxxxxxxxx`)
      traefik.http.routers.traefik.tls.certresolver: secure
      traefik.http.routers.traefik.tls.domains[0].main: "xxxxxxxxxx"
      traefik.http.routers.traefik.tls.options: default

networks:
  proxy:
    external: true

My Projekt docker-compose
version: "3.7"
services:
  frontend:
    image: registry.gitlab.com/xxxxxxxxx
    restart: always
    networks:
      - default
      - proxy
    labels:
      - "traefik.enable=true"
      - "traefik.docker.network=proxy"
      - "traefik.http.routers.projektname.rule=Host(`xxxxxxx`)"
      - "traefik.http.routers.projektname.entrypoints=https"
      - "traefik.http.services.projektname.loadbalancer.server.port=3000"
      - "traefik.http.routers.projektname.middlewares=securityHeader"
      - "traefik.http.routers.projektname.tls.certresolver=secure"
      - "traefik.http.routers.projektname.tls.domains[0].main=xxxxxxx"

networks:
  proxy:
    external: true


Move proto/keymaster_proto to api/type/type_proto

I'm a little less sure about whether this is the right place for keymaster_proto to live.
An alternate location is api/type/keymaster_proto, but that adds an extra level to the type directory that is not in the style guide.

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   48.87%   48.87%
=======================================
  Files          34       34
  Lines        2351     2351
=======================================
  Hits         1149     1149
  Misses        998      998
  Partials      204      204

Impacted Files
Coverage Δ

core/crypto/keymaster/verifier.go
77.96% <ø> (ø)
:arrow_up:

core/crypto/keymaster/signer.go
84.9% <ø> (ø)
:arrow_up:

core/crypto/keymaster/keymaster.go
77.77% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf15fa...565fbb7. Read the comment docs.


The gopkg.in/yaml.v3 dependency is a build risk

Hi, I'm from the AWS CDK team.
Your dependency on gopkg.in/yaml.v3 involves an external site: gopkg.in.  As of today, any attempt to fetch a package from this site fails with the error:
go<EMAIL_ADDRESS>invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /go/pkg/mod/cache/vcs/9241c28341fcedca6a799ab7a465dd6924dc5d94044cbfabb75778817250adfc: exit status 128:
    error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502 Bad Gateway
    fatal: The remote end hung up unexpectedly

This site seems to be run by a single person called Gustavo Niemeyer. It doesn't look like there is an SLA on this website, and there is no reasonable expectation of this person investing timely effort into fixing their site. In the mean time, any build involving aws-lambda-go will fail.
Currently for us, since our PR validation build (and release pipeline) does a go build involving aws-lambda-go, it looks like we cannot merge any PR and not release any version of CDK because of this.
It seems problematic that we are at the mercy of the volunteer efforts by a single person in order to successfully complete a build involving this AWS-vended library. I would ask you to find replacements for any dependencies that come from gopkg.in. Their presence constitutes an availability risk.

I don't have any objection to removing this indirect dependency, it's brought in for us by github.com/urfave/cli/v2 and it's use in  cmd/build-lambda-zip isn't particularly complex.
That said, I wouldn't recommend this as the correct general guidance for aws projects. gopkg.in/yaml is a really common dependency, and also happens to also be direct dependency for more than a dozen other aws open source projects (ref yaml.v2, ref yaml.v3). This package is also far from the only project to have a vanity import url that can result in the type of uptime issues that ya'lls PR workflows saw. The ecosystem solution for ensuring high uptime for build dependencies is to hit a module proxy rather than resolving to origin. This has been the default behavior since go1.13 (ref).
To fix your PR workflows, check first if something like GOPROXY=direct was set to bypass the default proxy. This configuration may not be necessary for your usecase.

Dependency has been removed with https://github.com/aws/aws-lambda-go/releases/tag/v1.30.0


Update automation mechanism

fix issues: https://github.com/Azure/azure-cli/issues/3895
pave the way for resolving: https://github.com/Azure/azure-cli/issues/3878
this change also includes an extensive overhaul of azlogging.py. the logger will be class based and offer cleaner layout of the code.

Codecov Report

Merging #3963 into master will decrease coverage by 0.74%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #3963      +/-   ##
==========================================
- Coverage   70.59%   69.84%   -0.75%
==========================================
  Files         429      429
  Lines       27348    27688     +340
  Branches     4168     4229      +61
==========================================
+ Hits        19306    19340      +34
- Misses       6794     7101     +307
+ Partials     1248     1247       -1

Impacted Files
Coverage Δ

...zure-cli-interactive/azclishell/gather_commands.py
49.15% <ø> (ø)
:arrow_up:

...-cli-role/azure/cli/command_modules/role/custom.py
38.57% <100%> (+0.11%)
:arrow_up:

...ure-cli-testsdk/azure/cli/testsdk/vcr_test_base.py
70.17% <100%> (+0.08%)
:arrow_up:

src/azure-cli-core/azure/cli/core/__init__.py
100% <100%> (ø)
:arrow_up:

...rofile/azure/cli/command_modules/profile/custom.py
36.36% <100%> (+0.83%)
:arrow_up:

src/azure-cli-testsdk/azure/cli/testsdk/base.py
69.47% <76.92%> (+0.99%)
:arrow_up:

src/azure-cli-core/azure/cli/core/azlogging.py
72.83% <77.14%> (-4.18%)
:arrow_down:

src/azure-cli/azure/cli/main.py
84.37% <85.71%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
70.66% <0%> (ø)
:arrow_up:

...nent/azure/cli/command_modules/component/custom.py
16.23% <0%> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19cb0e0...dd17dbe. Read the comment docs.

@derekbekoe I prefer this to be merged in sprint 18. We can do some extensive testing together.

@derekbekoe can you take a look? I want to merge this at the beginning of the sprint 19 so that we have more room to test.


dask.bag.read_text does not read binary when encoding=None

Python 3.6.3 (default, Oct  4 2017, 08:37:57)
[GCC 6.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import dask, dask.bag
>>> print(dask.__version__)
0.15.4
>>> urls = dask.bag.from_sequence([b'this is a test']).to_textfiles('/tmp/*.json', encoding=None)
>>> dask.bag.read_text(urls, encoding=None).compute(get=dask.get)
None 3
['this is a test']

Note that the byte-string, b'this is a test', was written and the string,'this is a test' was read. If the byte-string has unencodable data, then an exception is thrown:
>>> urls = dask.bag.from_sequence([b'this is a test \x80']).to_textfiles('/tmp/*.json', encoding=None)
>>> dask.bag.read_text(urls, encoding=None).compute(get=dask.get)
None 3
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/dask/base.py", line 99, in compute
    (result,) = compute(self, traverse=False, **kwargs)
  File "/usr/lib/python3.6/site-packages/dask/base.py", line 206, in compute
    results = get(dsk, keys, **kwargs)
  File "/usr/lib/python3.6/site-packages/dask/local.py", line 562, in get_sync
    return get_async(apply_sync, 1, dsk, keys, **kwargs)
  File "/usr/lib/python3.6/site-packages/dask/local.py", line 508, in get_async
    fire_task()
  File "/usr/lib/python3.6/site-packages/dask/local.py", line 504, in fire_task
    callback=queue.put)
  File "/usr/lib/python3.6/site-packages/dask/local.py", line 551, in apply_sync
    res = func(*args, **kwds)
  File "/usr/lib/python3.6/site-packages/dask/local.py", line 295, in execute_task
    result = pack_exception(e, dumps)
  File "/usr/lib/python3.6/site-packages/dask/local.py", line 290, in execute_task
    result = _execute_task(task, data)
  File "/usr/lib/python3.6/site-packages/dask/local.py", line 271, in _execute_task
    return func(*args2)
  File "/usr/lib/python3.6/site-packages/dask/bag/core.py", line 1438, in reify
    seq = list(seq)
  File "/usr/lib/python3.6/site-packages/dask/bag/text.py", line 97, in file_to_blocks
    for line in f:
  File "/usr/lib/python3.6/codecs.py", line 321, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 15: invalid start byte

This is especially troublesome if the user wants to save pickled datatypes, as in:
urls = bag.map(pickle.dumps).to_textfiles('/tmp/*.json', encoding=None)
bag.read_text(urls, encoding=None).map(pickle.loads)

as pickle.loads takes byte-strings not strings.

I'm not sure that those functions are intended to bytes. The docs could clarify this, but they are named read_text and to_textfiles. I suspect this is because it can be difficult to sniff line delimiters on undecoded blobs of bytes.
I'd recommend writing your own reader and using dask.delayed:
In [15]: import dask.delayed

In [16]: import pickle

In [17]: def reader(path):
    ...:     with open(path, 'rb') as f:
    ...:         b = f.read()
    ...:

In [18]: def reader(path):
    ...:     with open(path, 'rb') as f:
    ...:         b = f.read()
    ...:     return pickle.loads(b)
    ...:

In [19]: import glob

In [20]: paths = glob.glob('/tmp/*.json')

In [21]: readers = [dask.delayed(reader)(f) for f in paths]

In [22]: dask.bag.from_delayed?

You may also want to look at dask.bytes.read_bytes

@TomAugspurger That makes sense. I was a little confused by the discrepency between the behavior of to_textfiles (which does accept bytes if you pass encoding=None) and read_text which does not.
Perhaps the easiest way to store the binary data is to base85 encode it first. The output would be completely utf-8 compatible and not have newlines.

Yes, if you look at to_textfiles, you'll see that encoding is passed to dask.bytes.core.write_bytes, which requires that the data be bytes already.
The docstring also says
**Bag Contents**: The bag calling ``to_textfiles`` must be a bag of
text strings. For example, a bag of dictionaries could be written to
JSON text files by mapping ``json.dumps`` on to the bag first, and
then calling ``to_textfiles`` :

So I think that's already pretty clear. I think the question whether to_textfiles should validate that the contents are indeed text before writing.


Is there a way to prevent the gallery from looping?

Is there a way to prevent the gallery looping through the images e.g.
Disable left navigation when at image 1 of 10 and disable right navigation when at image 10 of 10 ?
Thank you,
Danielle
What kind of issue is this? (put 'x' between the square brackets)

[x] Question. This issue tracker is not the place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use
http://stackoverflow.com/questions/ask .
Provide working code, starting from http://jsfiddle.net/JNsu6/15/.
We monitor the tag featherlight.js.

[ ] Bug report. If you’ve found a bug, you must provide a minimal example in a CodePen,
starting from http://jsfiddle.net/JNsu6/15/ .

[x] Feature Request. Make sure there's no good way to do what you want first;
consider asking on http://stackoverflow.com/questions/ask first.

Yes, use CSS. The gallery will have class featherlight-first-slide and/or featherlight-last-slide if that's the case [#205].
For any other questions, please use StackOverflow


Ensure that LogoURL is reachable from outside the repository

@ianaya89 Without this change, we are going to be trying to find '../assets' in the registry which doesn't exist

@stack72 good catch, thanks!


Port and add custom title bar example

https://github.com/grassator/win32-window-custom-titlebar/blob/main/main.c

Completed with aa4f36861859a6833010a9a13df9083ff72a98e7


Made Coordinators.bind() return the result from the provider.

This lets clients that want to hang on to the coordinator get a reference
to it without having to wrap the provider.

cc @rjrjr

This looks like an additional opportunity for a leak. What's the use case?

This has been open for over a year and everything seems to be fine without it. Going to close, please reopen if there's an important use case.


Fancy photo page for team members

The about page is booooorrriiiiiing. We need a fancier looking one with headshots of everyone. It should pull information from the _data/members.yml file so that the member list can easily be edited by people who aren't web devs.

Added in fc3a478f0c3da8c08320bd54ea4d9059b7e2f79c; documented at https://www.cyberatuc.org/guides/website


How to get a nonce from Account?

JS library has this method https://github.com/solana-labs/solana-web3.js/blob/85bd523517683e1dbbb1d1e88116215dbd8a4678/src/nonce-account.ts#L55
Is there something similar in solana-go?

Hi
I added the NonceAccount struct: https://github.com/gagliardetto/solana-go/blob/e5f3c23faee34d32d5d43c63e781acd150512791/programs/system/accounts.go#L24
You can see here an example usage:
https://github.com/gagliardetto/solana-go/blob/e5f3c23faee34d32d5d43c63e781acd150512791/programs/system/accounts_test.go#L27-L36

@gagliardetto thank you!


Add initial code for ReadTheDocs documentation to the repo

We need to run the initial configuration for setting up ReadTheDocs for a repository. This can be done by following the information found here.

I believe this has already been done, but this is for tracking and to verify we have completed the task.

@exoticDFT  is this done? I'll start the PR for the doc branch to be merged

closed by #44


Updates example link for attaching tokens

URL is out of date
Currently used: https://github.com/near-examples/guest-book/blob/master/src/App.js#L27-L30
New one: https://github.com/near-examples/guest-book-tutorial/blob/main/src/App.js#L32-L33

thanks @dimosmera !


Add a C API for on_end_tag

Expose Element::on_end_tag
Expose all the methods of EndTag (name, set_name, before, after, remove)
Add a new EndTag::set_name_str function to make sure it uses the proper encoding. Using
set_name would require blindly assuming that the rewriter always used UTF8.
This API can be slightly more efficient once https://github.com/hsivonen/encoding_rs/pull/77 is merged, but I'm not sure how long it will take, so it might be better to just merge this as-is and make a breaking change eventually.
Add a test to ensure all the new API works correctly

Fixes https://github.com/cloudflare/lol-html/issues/85

BTW, regarding string efficiency problem, you can do:
match encode(&string) {
   Cow::Owned(changed) => changed,
   Cow::Borrowed(_) => string,
}

BTW, regarding string efficiency problem, you can do:

Oh, that's clever, thank you! I updated it to use that instead :)