Consider enabling the discussions tab

Would it be possible to enable the discussions  tab on GitHub? This would be a good way for developers to ask general questions and discuss usage without it being filed as an issue/defect directly.

JSpecify has a public Google Group

@Sparky983 I guess the problem with that is I see more questions like #492 being filed.
Which I'm all for people asking questions but I and I assume @ascopes  subscribe to this project on spec related issues and its can get very confusing / noisy.
With github you can quickly move question issues to discussions perhaps even automating if it becomes a problem.

We had talked about enabling the discussions tab not long ago. I think @kevinb9n was hoping to look more into other projects that have used it. (We'd come across it in Caffeine already but not very often elsewhere.) Maybe others can share examples? I do suspect that I'd personally like writing editable Markdown in the discussions tab over writing emails.

I'm happy to enable it if we think it doesn't require significant setup.

It looks easy enough. I suggest we do that around when we announce 1.0.

It looks like @netdpb set it up in advance of the imminent release.
Should we change the Discuss link in https://jspecify.dev/docs/start-here/ to point there? Should we add a new link, possibly renaming the old? Do we have a preference for which users use (in general or for specific purposes)? It looks like we have a couple other jspecify-discuss references in start-here.md.
Ah, and the footer already has both "Public Group" and "Mail The Team," both of which point to mailing lists.

I didn't think I had done that, but I guess I did.


SHELL32.dll not finding getcurrentprocessexplicitAppUserModelID

I had to downgrade to an old dell desktop after two other computers suffered hardware issues to the motherboard and CPU but now when I launch Key save I get this error message. Any work

rounds or am I just not using the right version of KeySAVe

This looks like you might be running Windows Vista.
Unfortunately the underlying technology (Electron) only runs on Windows 7 or newer. Should you be using Windows 7, I will look into it further, otherwise I'm afraid I can't help you other than suggest running a different OS.

Closing for now. Should you in fact be using Windows 7, I will happily reopen this issue.


robust tests for ssh repo interaction

required is:

should work on GH Actions for PRs of Forks
should cover public access via ssh
should cover private access via ssh
current tests are skipped at https://github.com/cargo-generate/cargo-generate/blob/69fa06063c6ceb64afcf7e9eb72b0a70a777e2c1/tests/integration/basics.rs#L1169

possible solutions:

create a random ssh key as part of the test (e.g. in the ProjectBuilder)
create a pre-defined ssh key that has access to the test repo

with #1265 those tests are present now


org.springframework.samples.mvc.form.FormController.processSubmit has invalid ajaxRequest argument.

The argument is not documented in @RequestMapper javadoc -> http://static.springsource.org/spring/docs/3.1.x/javadoc-api/org/springframework/web/bind/annotation/RequestMapping.html.
Also, ajaxRequest is not a request parameter, but a model attribute set by ajaxAttribute method in the same file.
I think, the test for ajax in processSubmit shoud be rewritten like this:
final Boolean isAjaxRequest = (Boolean) model.asMap( ).get( "ajaxRequest" );

if ( isAjaxRequest != null && isAjaxRequest.booleanValue( ) ) {
...

And ajaxRequest should be retired from the method signature.  Currently it always evaluates to false.

The ajaxRequest argument is indeed a model attribute. It should have had an @ModelAttribute("ajaxRequest") annotation to indicate so and to specify its name. I've fixed the issue.


createSelector w/o dependencies

It's really minor - we've got the following code in our project:
export const selectAllByConnections = createSelector(
    state => state, //reselect's createSelector always needs a dependency
    state => state
        .get('connections')
        .map(connection => allByConnection(connection)(state))
);

I can't move the state.get('connections') to a different selector as i require the full state for the core selection task.

There is no need for a selector in this case, just use the bare function. createSelector creates a selector that memoizes on its arguments, so using createSelector without dependencies is essentially a no-op.


Create formula for thrift v0.9.0

Can I get an update here? Is this still necessary/Is there still anything left to gain by accepting it/etc? Thanks!

Hey @DomT4 , I think it still not possible to install thrift v0.9.0 on mavericks without this version. The fixes/commits in homebrew repo are all related with version 0.9.1+

I'm a little reluctant to carry this if it's likely to break again in the future, but if you want us to consider it please fix up any comments brew audit --strict has locally, remove the head block and add an openssl dep. Thanks!

Ping.

Sorry for the delay @DomT4 ; I will update the code today !

Ping?

@DomT4 pong!

The patch Gists seem to have wandered off?
==> Downloading https://gist.githubusercontent.com/rafaelverger/58b6eeafaae7d28b06cc/raw/[ca4565122f0a1365f2409bce85dc0b8942459b18
==> Retrying download
==> Downloading https://gist.githubusercontent.com/rafaelverger/58b6eeafaae7d28b06cc/raw/[ca4565122f0a1365f2409bce85dc0b8942459b18
Error: Failed to download resource "thrift090--patch"

Few nits, but looking much better :+1:.

@DomT4 check this out :)

Nearly there :+1:

Alright, Merged. I fixed the test locally, since it was playing up. Thanks for your contribution to Homebrew, we appreciate it! :smiley_cat:. In future, please note the commit message for new formulae should be styled thrift090 0.9.0 (new formula) and ideally commits squashed together, Thanks!

Awesome, @DomT4 , thanks for the tips!


Installing TortoiseHg.TortoiseHg results in a InternetOpenUrl() failed error

Brief description of your issue

Trying to install Mercurial correctly downloads the TortoiseHg installer, but fails when executing it with the following error
An unexpected error occurred while executing the command:
InternetOpenUrl() failed.
0x80072ee2 : unknown error

Steps to reproduce

Run winget install mercurial
Expected behavior

I expect that mercurial/TortoiseHg gets installed
Actual behavior

An unexpected error occurred while executing the command:
InternetOpenUrl() failed.
0x80072ee2 : unknown error

Environment
[winget --info]
Windows Package Manager v0.1.41331 Preview
Windows: Windows.Desktop v10.0.18363.836
Package: Microsoft.DesktopAppInstaller v1.0.41331.0

Any other software?

I'm facing this issue too.
C:\Users\kavin>winget install Git.Git
Found Git [Git.Git]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licences to, third-party packages.
Downloading https://github.com/git-for-windows/git/releases/download/v2.29.0.windows.1/Git-2.29.0-64-bit.exe
An unexpected error occurred while executing the command:
InternetReadFile() failed.
0x80072ee2 : unknown error

C:\Users\kavin>winget install github.cli
Found GitHub CLI [GitHub.cli]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licences to, third-party packages.
Downloading https://github.com/cli/cli/releases/download/v1.2.0/gh_1.2.0_windows_amd64.msi
An unexpected error occurred while executing the command:
InternetOpenUrl() failed.
0x80072efd : unknown error

It started occouring when
C:\Users\kavin>winget install Git.Git
Found Git [Git.Git]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licences to, third-party packages.
Downloading https://github.com/git-for-windows/git/releases/download/v2.29.0.windows.1/Git-2.29.0-64-bit.exe
  ██████████████████████████████  10.0 MB / 46.1 MB

just exited without throwing any errors.

I'm facing this issue too. How did you fix it?
https://github.com/microsoft/winget-cli/issues/638#issue-739737353

It fixed itself for me when I tried it 20-30 minutes later.

This issue usually happens when your internet is slower. Check you internet connectivity and try again running above mentioned command.

I'm facing this issue too. How did you fix it?
#638 (comment)

Did you check later, after some time? This happen due to internet connection.

I don't think this is a network issue, I was able to perform other internet activities on my browser just fine.

This error is related to the Windows Package Manager client not being able to download the installer due to issues with Internet connectivity. I believe the error message has been improved, and we have added additional retry logic.


Visualize PLOT AREA at collection stage

Users want to see the area of the plot they just collected
Can it be shown when the plit is collected ?

@rawbzz PTAL?

hi @gino-m just seeing this! Isn't this what we do here? or is this referring to another flow?

The image isn't visible but I do believe this is in the designs, it's just not implemented yet

In designs, but not yet implemented!

In designs, but not yet implemented!

The issue is referring to seeing the surface area in sq meters (@lecrabe or km?).

Duplicate of #2096


passed Dropdown elements not displaying, but highlighted on clicking

I posted data to my dropdown from an array but the posted data was not being displayed. However, on clicking the affected dropdown(s), the posted data is highlighted, could I be missing something?
The photo below displays the problem.

Hi,
Could you share a part of your code explained in your post or reproduct problem on JSFiddle ?
and could you precise version of Jspreadsheet and jSuite used on your code ?
Thanks

You could close this issue, I found a way to resolve the problem...The react useEffect where the pasted table elements were called rendered before the component calling the table. Fixed it by making the table render first before pasting the data.


Update Repo Description

Use this for now:
The Lightweight Desktop App For Twitch.TV

Done.

Thx.


WebXR outputContext blitting

Fixes https://github.com/webmixedreality/exokit/issues/291.

This should now be blitting from the shared framebuffer as specified in the WebXR requestSession, but it's currently a black blit after the framebuffer swap.
Needs more investigation.


[release-4.12]  OCPBUGS-4478: guard controller: set an explicit hostname to avoid name collisions

Backporting this one https://github.com/openshift/library-go/pull/1427

/jira refresh

/cc @jitendar-singh
/cc @p0lyn0mial

/lgtm

/approve


Matchers for Joda-Time temporals

Support for Joda-Time LocalDate, LocalDateTime, LocalTime and DateTime (compile-only non-transitive dependency to joda-time)

Coverage decreased (-0.2%) to 85.88% when pulling b08b369afa439dd97f3a3b56fe356287033f8c40 on tnaskali:master into cb337b094b21ba63b77356871434dddd010678c2 on eXparity:master.

This library is for core java types only and not joda time. I'd recommend creating a new library called hamcrest-joda-time to host the joda time matchers.

This seems like a better option indeed. What about creating a "core" generic library and two implementations that depend on it, java and joda-time ?

Hi, really sorry for not getting back sooner and yes the split to a core lib with java and joda implementations may make sense. Before the split though - are you able to raise a PR or create a branch of master with just the changes to support Joda so I can see the extent of the change. This PR contains all the changes for the zone change as well so it's hard to see the scope of the change. If the change looks clean I can look at doing the split in a branch. Regards, Stewart

Hi Stewart, I tried to package all the code to support Joda under the org.exparity.hamcrest.date.joda package. All the other changes should be related to time zone support. In the meantime I'll try to split them into two separate branches / PRs. Thomas

Hi Thomas, If it's all under the org.exparity.hamcrest.date.joda package then that's cool. I'll pull the PR down and review the diff. No need for you to split it out.

I've re-opened the PR but into a new branch called joda-time.


Helmfile's insecureSkipTLSVerify option yields errors due to upstream bug in helm-diff

Operating system
macOS 14
Helmfile Version
v0.158.1
Helm Version
v3.13.1
Bug description
Enabling insecureSkipTLSVerify currently leads to a bug in helm-diff, with error unknown flag: --insecure-skip-tls-verify.
This is not Helmfile's fault, but it affects Helmfile users.
It seems the issue was introduced in Helm v3.10 (see discussion above).
Example helmfile.yaml
helmDefaults:
  insecureSkipTLSVerify: true

repositories:
- name: bitnami
  url: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami

releases:
- name: example-release
  chart: bitnami/wordpress

Error message you've seen (if any)
Adding repo bitnami https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
"bitnami" has been added to your repositories

Comparing release=example-release, chart=bitnami/wordpress
in ./helmfile.yaml: command "/opt/homebrew/bin/helm" exited with non-zero status:

PATH:
  /opt/homebrew/bin/helm

ARGS:
  0: helm (4 bytes)
  1: diff (4 bytes)
  2: upgrade (7 bytes)
  3: --allow-unreleased (18 bytes)
  4: example-release (15 bytes)
  5: bitnami/wordpress (17 bytes)
  6: --insecure-skip-tls-verify (26 bytes)
  7: --detailed-exitcode (19 bytes)
  8: --color (7 bytes)
  9: --reset-values (14 bytes)

ERROR:
  exit status 1

EXIT STATUS
  1

STDERR:
  Error: unknown flag: --insecure-skip-tls-verify

COMBINED OUTPUT:
  Error: unknown flag: --insecure-skip-tls-verify

Steps to reproduce
helmfile apply
Working Helmfile Version
Helm v3.9
Relevant discussion
https://github.com/databus23/helm-diff/issues/503

@tjanson I will work on this issue.


DRILL-4411: hash join should limit batch based on size and number of records

Right now, hash joins can run out of memory if records are large since the batch is limited only by size (of 4000).  This patch implements a simple heuristic.  If the allocator for the outputs become larger than 10 MB before outputing 4000 records (say 2000), then set the batch size limit to 2000 for the future batches.

I made it such that it doesn't adjust the batch size once, but keep the minimum batch size (in terms of number of records) to be at least 1.

@minji-kim Thanks for putting the effort into making this change. Unfortunately a sophisticated version of this was recently completed in this PR https://github.com/apache/drill/pull/1227 and will be merged soon. Since the objectives of the two changes were the same I will close this PR. Sorry that your change did not receive any attention earlier.


Create a themed 404 page.

The page should contain the same textual formatting and colors as the main page and should provide a link to return to the main page. The page shall be named 404.html and resides next to the index.html. It will be called when someone attempts to browse the backend code files directly.

The 404 page is created but needs to be made pretty. That's where @WilliamReed2004 comes in.

finished


ZEPPELIN-3150. Fixed Checkstyle errors and warnings in the bigquery module

What is this PR for?
Fixed the Checkstyle errors and warnings in the bigquery module.
What type of PR is it?
Improvement
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3150

How should this be tested?

CI pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

LGTM


Migrate speculos docker to multiarch

Some related info
https://github.com/LedgerHQ/speculos/blob/98be852630c43bb1dd38c17aff12613e3717fdbc/docs/user/macm1.md

:link: zboto Link

It was done some time ago :)


How to use Groovy to construct InlineStyleTextArea and do #142's style update?

Hi Tomas,
This question might be better asked on StackOverflow.com because it might be outside the scope of this project. If it is, then I don't want to waste your time; I can ask it on there. On the other hand, I don't understand why this wouldn't work in its current form. So perhaps there's some underlying things going on that you would easily spot but that I can't.
I'm using Groovy and GroovyFX to design my program. Groovy's syntax doesn't understand Java 8 Lambdas; however, its Closures can replace the Lambdas and do the exact thing (though this is still something I'm figuring out).
Using the following code, I replaced 2 Lambdas with Closures (one used in InlineStyleTextArea's constructor, and one to do StyleSpans.mapStyles(mapper). However, despite using your answer in #142, updating the text with a new style doesn't change the text's color to red as it should. It remains black. Here's the code in its simplest form:
import javafx.scene.paint.Color
import org.fxmisc.richtext.InlineStyleTextArea
import org.fxmisc.richtext.StyleSpan
import org.fxmisc.richtext.StyleSpans
import org.fxmisc.richtext.StyleSpansBuilder

import static groovyx.javafx.GroovyFX.start

// same idea as StyleInfo from RichText.java but made groovier...
class TextStyle {
    Boolean bold
    Boolean italic
    Boolean underline
    Boolean strikethrough
    Integer fontSize
    String fontFamily
    Color color

    // No constructor in Groovy means I can use a Map to construct
    //   Example:  new TextStyle(bold:true, fontSize:20...)

    String toCss() {
        StringBuilder sb = new StringBuilder()
        if (bold != null) {
            sb.append("-fx-font-weight: ${(bold) ? "bold" : "normal"};")
        }
        if (italic != null) {
            sb.append("-fx-font-style: ${(italic) ? "italic" : "normal"};")
        }
        if (underline != null) {
            sb.append("-fx-underline: ${(underline) ? "true" : "false"};")
        }
        if (strikethrough != null) {
            sb.append("-fx-strikethrough: ${(strikethrough) ? "true" : "false"};")
        }
        if (fontSize != null) {
            sb.append("-fx-font-size: ${fontSize}pt;")
        }
        if (fontFamily != null) {
            sb.append("-fx-font-family: ${fontFamily};")
        }
        if (color != null) {
            int red = color.getRed() * 255
            int green = color.getGreen() * 255
            int blue = color.getBlue() * 255
            sb.append("-fx-fill: rgb($red, $green, $blue)")
        }

        return sb.toString()
    }
}
/*
    Creates a border pane with styledArea at center.
    Clicking on button (bottom) will call replaceStyles (Closure)
 */
start {
    // Create styles
    def startingStyle = new TextStyle()  // toCss() = ""
    def replacementStyle = new TextStyle(color:Color.RED)

    // Create area and use Closure instead of Lambda.
    //   Not sure if "{startingStyle.toCss()}" creates a problem or not...
    def styledArea = new InlineStyleTextArea(startingStyle, { startingStyle.toCss() })

    def mapStyles   // declare Closure (assigned later), makes reading this easier...

    // Create Closure that simulates Tomas' style update answer
    def replaceStyles = { InlineStyleTextArea area, TextStyle oldStyle, TextStyle newStyle ->
        StyleSpans<TextStyle> originalSpans = area.getStyleSpans(0, area.getLength())

        StyleSpans<TextStyle> newSpans = mapStyles(originalSpans,

                // same basic idea but uses a Closure instead of a Lambda
                {style -> return (style.equals(oldStyle)) ? newStyle : style }
        )

        area.setStyleSpans(0, newSpans)
    }

    // Closure that copies 'mapStyles()' method exactly (except a few places for easier readability)
    //       but uses a closure instead of UnaryOperator
    mapStyles = { StyleSpans<TextStyle> originalSpans, Closure mapper ->
        int numberOfSpans = originalSpans.getSpanCount()
        StyleSpansBuilder<TextStyle> builder = new StyleSpansBuilder<>(numberOfSpans)

        StyleSpan<TextStyle> firstSpan = originalSpans.getStyleSpan(0); // there should always be at least one span
        int prevLen = firstSpan.getLength()

        // mapper.apply() normally called here; Closure used instead
        TextStyle prevStyle = mapper(firstSpan.getStyle())

        for (i in 1..<numberOfSpans) {
            StyleSpan<TextStyle> span = originalSpans.getStyleSpan(i);

            // mapper.apply() normally called here; Closure used instead
            TextStyle style = mapper(span.getStyle())

            if(Objects.equals(prevStyle, style)) {
                prevLen += span.getLength()
            } else {
                builder.add(prevStyle, prevLen)
                prevLen = span.getLength()
                prevStyle = style
            }
        }
        builder.add(prevStyle, prevLen)
        return builder.create()
    }

    stage(id: "stage", title: "Hello", primary: true, visible: true) {
        scene(width: 500, height: 500) {
            borderPane(id:"border") {
                bottom {
                    button("Replace Styles", onAction:{
                        replaceStyles(styledArea, startingStyle, replacementStyle)
                    })
                }
            }
        }
    }
    border.setCenter(styledArea)
}

Hi Jordan,
I am not a Groovy programmer, but this line
new InlineStyleTextArea(startingStyle, { startingStyle.toCss() })

seems to me like passing a closure over a constant startingStyle, ignoring the argument, while it should be something like
new InlineStyleTextArea(startingStyle, { TextStyle style -> style.toCss() })

Also, I don't understand why you need to reimplement mapStyles.

Dah! That was it! Thank you, sir! It works after changing the constructor to the one you showed.
Using my previous constructor would insert the text underneath the initial style. So I assumed that what I was using was indeed working. When I tried using the previous solution you gave in updating the text, it didn't work. I thought that mapStyles might be the issue. It was only later that I thought the constructor might be written incorrectly.
Short answer: I wrote the constructor poorly, and I don't need to reimplement mapstyles


If the application use ember-engines, after corber build, the .apk and .ipa will not working.

Hi All,

I have a demo ember application: https://github.com/LiShuxue/ember-app.git
This application load an engine. https://github.com/LiShuxue/ember-app-adn-login.git
I use "corber build --platform=android --environment=development" to generate the android-debug.apk, but when i open the apk file, it show white screen.
I debug the apk , show me below error
GET file:///engines-dist/ember-app-adn-login/assets/engine-vendor.js net::ERR_FILE_NOT_FOUND
GET file:///engines-dist/ember-app-adn-login/assets/engine.js net::ERR_FILE_NOT_FOUND

Any one have any idea about that ? thanks

I'll take a look at the sample app, but my first guess is we are mounting something with a / - perhaps an asset path?

Hi @alexblom ,
Thanks for your reply.
Before i mount the engine like :  " this.mount('ember-app-adn-login', {path: '/adn-login'})  ", it have issue.
I try to remove the " / " follow your suggest, use like this : "  this.mount('ember-app-adn-login', {path: 'adn-login'})  ", but it still have same error.

Thanks. I'll take a look at the sample over the weekend.

Hi.
Have you found anything ?

I'll have to look into engines config more.
If it helps in the interim I ran the repro project (thanks for including! -  your problem is the engine is adding tags like so:
<script src="/engines-dist/ember-app-adn-login/assets/engine.js"></script>
you want it to be:
<script src="engines-dist/ember-app-adn-login/assets/engine.js"></script>

Hi @alexblom ,
Sorry for reply you so late...I have too many project need to release in my company.. too busy...
Anyway, continue our discussion.
yeah, like you said, maybe it will work like this <script src="engines-dist/ember-app-adn-login/assets/engine.js"></script>
but actually, the index.html will not load the script like that, it like this <meta name="ember-app/config/asset-manifest" content="%7B%22bundles%22%3A%7B%22ember-app-adn-login%22%3A%7B%22assets%22%3A%5B%7B%22uri%22%3A%22/engines-dist/ember-app-adn-login/assets/engine-vendor.js%22%2C%22type%22%3A%22js%22%7D%2C%7B%22uri%22%3A%22/engines-dist/ember-app-adn-login/assets/engine.js%22%2C%22type%22%3A%22js%22%7D%5D%7D%7D%7D">
and the asset-manifest.json will load the script like "uri": "/engines-dist/ember-app-adn-login/assets/engine.js".
But i don't know how to change it in the asset-manifest.json file , is there any config file to change it automatically ?

I changed the asset-manifest.json manully, like this"uri": "engines-dist/ember-app-adn-login/assets/engine.js", but it still not working ..

Hi @alexblom ,
Do you have any suggestion ? I really don't know how to fix this issue.

I'll be able to look again early next week for you.

thanks

Hi @alexblom , may i know how about this ?

I was able to get your engine example running. The issue is that engines-dist has a leading slash as we figured above.
I don't know enough about engines to see how this is configurable, so I simply modified the meta tag to this (manually removing the leading slash from /engines-dist in both instances):    <meta name="ember-app/config/asset-manifest" content="%7B%22bundles%22%3A%7B%22ember-app-adn-login%22%3A%7B%22assets%22%3A%5B%7B%22uri%22%3A%22engines-dist/ember-app-adn-login/assets/engine.js%22%2C%22type%22%3A%22js%22%7D%5D%7D%2C%22ember-app-adn-loginassets%22%3A%7B%22assets%22%3A%5B%7B%22uri%22%3A%22engines-dist/ember-app-adn-loginassets/engine-vendor.js%22%2C%22type%22%3A%22js%22%7D%5D%7D%7D%7D">
Unfortunately I cannot tell you how to configure an engine to not default mount as /, but that seems like a reasonable question to ask them.

yeah, it is working now, thanks !


Optional type discriminator

Hello!
I have a domain model (for consul api) and want to encode/decode types like Check and ServiceCheck and their subtypes . The issue is in model encoding/decoding results. Classes :
sealed trait Check
final case class ScriptCheck(...) extends Check
final case class HttpCheck(...) extends Check
final case class TCPCheck(...) extends Check
final case class TTLCheck(...) extends Check
final case class DockerCheck(...) extends Check
final case class GRpcCheck(...) extends Check
final case class AliasCheck(...) extends Check

and encoders/decoders:
implicit val checkEncoder: JsonEncoder[Check] = DeriveJsonEncoder.gen[Check]
implicit val checkDecoder: JsonDecoder[Check] = DeriveJsonDecoder.gen[Check]

When i encode instance of any subtype of Check or ServiceCheck i get a json object like this:
{
    "ScriptCheck": {...}
}

The api does not recognise field ScriptCheck and fails with an error. If i try to encode ScriptCheck explicitly using encoder for ScriptCheck type then json will not have type discriminator.
I tried to use annotations with empty values @jsonHint("") and @jsonDiscriminator(""), as i thought that it will remove it because in macros there is a code like this:
def discrim = ctx.annotations.collectFirst { case jsonDiscriminator(n) => n }
    if (discrim.isEmpty) {...} else {...}

but got an error:
Caused by: java.lang.IllegalArgumentException: requirement failed
	at scala.Predef$.require(Predef.scala:325)
	at zio.json.internal.StringMatrix.<init>(lexer.scala:393)
	at zio.json.DeriveJsonDecoder$$anon$4.<init>(macros.scala:251)
	at zio.json.DeriveJsonDecoder$.dispatch(macros.scala:249)

Also, i tried to construct encoder using eitherWith, but in result i get a json with additional field Left or Right.
In the meantime, decoder can be constructed using orElse and it will not require type discriminator.
Is it possible to completely remove type discriminator?

Hi! I had the same problem of this and ended up doing this:
`
val scriptCheckEncoder = DeriveJsonEncoder.Gen[ScriptCheck]
// ... repeat for all your types
implicit val checkEncoder: JsonEncoder[Check] = DeriveJsonEncoder.gen[Check].contramap(¨
{
case c:ScriptCheck => c
// Repeat for all your types
}
)`
This seems silly, but what this is essentially doing is telling the type system to look for your implicitly defined case class encoders and use those instead of the ADT encoder.


Fix compatibility for transformers version 4.25.0

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Wrap and use SKMatrix4x4

Right now just SKCanvas
Description of Change

Bugs Fixed

Related to issue #

API Changes

Behavioral Changes

PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[ ] Changes adhere to coding standard
[ ] Updated documentation

No longer needed as in skia v3 we are using SKM44 everywhere and I took a shortcut and it is a wrapper for Matrix4x4 from System.Numerics.
Probably losing out with the conversion, but we can do something later - maybe copy the implementation and use the same intrinsics. But with implicit converters, it is far less wasteful than interop with C...


[bug] Anchor link hangs browser

Describe the bug
When navigating to or on a page using an anchor link, (ie /content/our-site/home#benefits)  , the page hangs for several minutes before loading and scrolling to the element with the anchor id.
Package version
"@adobe/cq-angular-editable-components": "^2.0.2"
To Reproduce
go to benefits
some content here
Expected behavior
Upon clicking the link, the webpage scrolls to the element with the matching anchor id.

Created an internal issue. Ref: CQ-4310437

I found the issue to be a poorly performing regex that gets into a recursive loop in PathUtils.ts in cq-spa-page-model-manager (now called aem-spa-page-model-manager) when a fragment is on the path coming into the function.
https://github.com/adobe/aem-spa-page-model-manager/blob/3ea346c82a107cef310d37d738e267d895fe805a/src/PathUtils.ts#L245
Failing test case with the regex:
var path = '/content/xyz/en/website/home/products-we-offer/products-xyz/xyz#detail'; var match = /^((?:[/a-zA-Z0-9:_-]*)+)(?:\.?)([a-zA-Z0-9._-]*)(?:\/?)([a-zA-Z0-9/._-]*)(?:\??)([a-zA-Z0-9=&]*)$/g.exec(path); console.log(match);
Passing test case with the regex:
var path = '/content/xyz/en/website/home/products-we-offer/products-xyz/xyz'; var match = /^((?:[/a-zA-Z0-9:_-]*)+)(?:\.?)([a-zA-Z0-9._-]*)(?:\/?)([a-zA-Z0-9/._-]*)(?:\??)([a-zA-Z0-9=&]*)$/g.exec(path); console.log(match);

I think that the following URL is illegitimately generated:
/content/xyz/en/website/home/products-we-offer/products-xyz/xyz#detail.model.json
We should instead get:
'/content/xyz/en/website/home/products-we-offer/products-xyz/xyz.model.json`
I don't think that the model manager should attempt to fetch the model of anchors. In such a case we are interested in the model of the page. Unless there is a use-case I don't yet see, we may want to strip or ignore the anchor chunk of the URL when generating the URL to fetch the model in [0].
[0] https://github.com/adobe/aem-spa-page-model-manager/blob/master/src/ModelManager.ts#L535

BTW the issue relates to the page model manager repository. Let's continue follow-up their
https://github.com/adobe/aem-spa-page-model-manager/issues/39


Updating docs

Thank you very much for this. In general, we do not accept style-only changes. Our project works towards the StandardJS format as well, which this PR seems to be reversing.


sha/asm/keccak1600-armv4.pl: improve non-NEON performance by ~10%.

This is achieved mostly by ~10% reduction of amount of instructions
per round thanks to a) switch to KECCAK_2X variant; b) merge of
almost 1/2 rotations with logical instructions. Performance is
improved on all observed processors except on Cortex-A15. This is
because it's capable of exploiting more parallelism and can execute
original code for same amount of time.

10% is not enough?

I pushed commentary update. Since it's pure commentary update I consider approval to be still valid unless an explicit objection is risen. In practical terms it means that in lack of response I'll commit after some grace period.


Support call webhook query parameters

Added new property to Microsoft.Bot.Builder.Calling.Events.IncomingCallEvent:
public IEnumerable<KeyValuePair<string, string>> IncomingCallParameters { get; set; }

additional modifications to support this functionality and backward compatibility of the SDK.

I needed this to be able to configure the incoming call request

Can you elaborate on what is the main application for this feature? Given the registered webhook is fixed for a bot and calling service will not provide different context for a single bot on each incoming call event, does this want to enable multi-bot hosting within the same controller?

The main application of this feature is to allow us to be more operationally efficient, by saving R&D and DevOps costs.
No, I do not host multiple bots in the same controller. My controller calls always the same (single) bot.
My bot is a conversational bot. The only thing it does is talking to the user. The way my bot is talking to the user is always identical: bot gets user input, then it sends input to our proprietary NLP engine that returns response to the bot, and then bot responds. It is always the same routine.  However, I need this parameter to allow the bot to send the conversation topic to our NLP engine to make an appropriate response. I define different bots on bot platform for each topic and this parameter specifies the topic technically-wise. This allows the bot to send the topic to talk about to NLP engine and thus respond appropriately. The great thing about the implementation of the bot is that it is topic agnostic, i.e. if I add a topic I don't need to modify the bot. The bot is actually used as a "dumb pipe" from user to our NLP engine.  If I don't have the ability to pass parameter to the bot I will have to multiply bot installations, i.e. 1 bot installation for every topic. Then this would require us to hard-wire conversation topic in each bot (R&D costs) and to order additional resources on AWS Elastik Beanstalk (DevOps costs) and thus would be costly for no reason. Since the bot is a "dumb pipe" it does not make any sense to deploy different bot instances for every topic.
Hope I explained the request in a satisfactory manner, but if you have more questions, please do not hesitate to ask.

I define different bots on bot platform for each topic and this parameter specifies the topic

This implies that you are hosting multiple bots in the same controller (same route) and want to differentiate between them by the different query parameter in the endpoint that you register in the dev portal.
This is a fine approach but you also need to modify BotAuthentication attribute to be able to handle multiple bots, i.e. multiple Microsoft App Id and Microsoft App password and do appropriate authentication based on the query parameter.

I didn't get to BotAuthentication yet because I can't publish my Bot yet because calling feature is still in preview. So while I am still in development mode without being able to publish the bot I left authentication in my TODOs.

Closing this because of the age of the pull request. Feel free to send a new pull request based on the new BotAuthentication attribute that support multiple MicrosoftAppId and MicrosoftAppPassword.

Created new PR #1946


ReferenceError while using model-viewer in NextJS

Description
I'm building a NextJS application, but when I try implementing model-viewer, I'm getting the following error
<EMAIL_ADDRESS>(22:35) @ self
 ⨯ ReferenceError: self is not defined
    at __webpack_require__ (/Users/soham/.next/server/webpack-runtime.js:33:42)
    at __webpack_require__ (/Users/soham/.next/server/webpack-runtime.js:33:42)
    at __webpack_require__ (/Users/soham/.next/server/webpack-runtime.js:33:42)
    at __webpack_require__ (/Users/soham/.next/server/webpack-runtime.js:33:42)
    at eval (./app/components/Model.js:7:78)
    at (rsc)/./app/components/Model.js (/Users/soham/.next/server/_rsc_app_components_Model_js.js:20:1)
    at Function.__webpack_require__ (/Users/soham/.next/server/webpack-runtime.js:33:42)
null

Following is my model-viewer code
// Model.js
import "@google/model-viewer";

const Model = () => (
  <div id="card">
    <model-viewer
      src="/chair.glb"
      poster="https://cdn.glitch.com/36cb8393-65c6-408d-a538-055ada20431b%2Fposter-astronaut.png?v=1599079951717"
      alt="A 3D model of a chair"

    ></model-viewer>
  </div>
);

export default Model;

PS: Yes, I'm using dynamic import with ssr false
// page.js
import dynamic from "next/dynamic";

const Model = dynamic(
  () => import("./components/Model"),
  {ssr: false}
) ;

export default function Home() {
  return (
    <Model />
  )
}

Live Demo

https://glitch.com/edit/#!/sturdy-pepper-hyena

Version

model-viewer: v3.3.0

Browser Affected

[x] Chrome
[x] Firefox
[x] Safari

OS

[x] MacOS Sonoma v14.0

This looks like a NextJS issue - have you asked on their forums?


Blacklist OVS

We do not want OVS starting when we are not using it...so blacklist
it on all neutron-common nodes (all nodes participating in the
neutron data plane shoudl be covered here).

+1


First select then switch

Fixes #291

Sorry @CookieMichal I didn't see this PR! I'll merge this over the weekend.

Please merge

Covered in #315


If the user has not selected the subscribe option, still it is subscribed on the customer registration form.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
If the user has not selected the subscribe option, still it is subscribed on the customer registration form.
Preconditions

Admin should be enabled the subscribe option.

Steps to reproduce

Go to the 'Homepage'
Click on the 'User SignUp form'
Fill in all the required fields and register
Check the registered mail or Admin panel subscription option
See the error

Expected Result
It should work according to the checkbox. if the checkbox is selected then the user should be subscribed else not.
Actual Result
Still, it is subscribed to the newsletter. Here
Screenshots
No response
Additional context
No response

@amit-webkul getting a few issues.

Getting an exception while the customer is trying to register with subscribe to the newsletter.
and from the edit profile page while the user trying to subscribe to the newsletter but not getting any mail for subscribing.Here

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.


fix broken getCurrentPosition method

fixes #277
I've tested this on my app and it's working perfectly.

@erickzanardo would you please take a look at this? my app is broken because this method was deleted :(

@erickzanardo I've added a new option in cafa960 (and docs in ad6da0e) for users to be able to set playerId when creating a new instance of AudioPlayer, this is because I'm using this lib for a music app so I don't need to play multiple audio files simultaneously and I'm ending up with multiple bugs cause I'm not able to use it to play one audio file at a specific time, this is not breaking anything and it's totally backward compatible, please take a look at it and tell me what do you think.

hi @luanpotter, so much thanks for quick review, I've applied your requested changes, as I said I'm using this lib for a music app that we guess it's going to have at least a few million users, I mentioned @erickzanardo cause I taught you're a little busy, sorry about that.
we can launch whenever #232 lands and @subhash279 finishes his work on the notification bar, it would be great if you could spend more time on PR's and issues, I appreciate that.


Refactor the Sentry plugin to use the proxy backend instead of a custom backend

The Sentry plugin is a bit outdated and hard to use in a recent backstage instance. I changed a few things:

Removal of the plugin-sentry-backend since it just proxied the request to the sentry backend. It is replaced with a plugin-proxy-backend configuration. I'm not sure if it was planned to add caching or aggregations etc. in the backend, but in the current state, the proxy-backend seems to be more reasonable.
Don't differentiate the mock-backend and the production-backend via the NODE_ENV variable. Instead, users can replace the sentryApiRef with the MockSentryApi. tbh, I'm not sure if that still makes sense. Question would also be if we want to activate the moc-api in the example app and also have a component that has sentry configured.
Make the SentryIssuesWidget usable outside of the dedicated Router-Tab-Page. Question would be if we should also remove the Router component completely.
Remove the dedicated /sentry route. In my eyes, it doesn't really make sense since it was just configured with a hard-coded project id. Maybe in the future is would be cool to have widgets that can display issues from multiple components. But that is valid for all other plugins and should be handled in the future.
Update the Readme.md with better usage instructions.

Fixes https://github.com/backstage/backstage/issues/3182

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

I updated it. When importing the old files, you now get an error when on starting the backend (or compiling). I also added a dummy createRouter export to keep yarn tsc happy since it won't tell the verbose error message.

yarn start-backend
yarn start-backend
yarn run v1.22.1
$ yarn workspace example-backend start
$ backstage-cli backend:dev
Build succeeded
webpack-internal:///../../node_modules/@backstage/plugin-sentry-backend/src/index.ts:21
throw new Error(
^

Error: The sentry-backend has been deprecated and replaced by the proxy-backend. See the changelog on how to migrate to the proxy backend: https://github.com/backstage/backstage/blob/master/plugins/sentry/CHANGELOG.md.
    at Module.eval (webpack-internal:///../../node_modules/@backstage/plugin-sentry-backend/src/index.ts:21:7)
    at eval (webpack-internal:///../../node_modules/@backstage/plugin-sentry-backend/src/index.ts:35:30)
    at<EMAIL_ADDRESS>(/Users/******/git/backstage/packages/backend/dist/main.js:3830:1)
    at __webpack_require__ (/Users/******/git/backstage/packages/backend/dist/main.js:749:30)
    at fn (/Users/******/git/backstage/packages/backend/dist/main.js:60:20)
    at Module.eval (webpack-internal:///./src/plugins/sentry.ts:3:90)
    at eval (webpack-internal:///./src/plugins/sentry.ts:20:30)
    at Module../src/plugins/sentry.ts (/Users/******/git/backstage/packages/backend/dist/main.js:4269:1)
    at __webpack_require__ (/Users/******/git/backstage/packages/backend/dist/main.js:749:30)
    at fn (/Users/******/git/backstage/packages/backend/dist/main.js:60:20)
    at Module.eval (webpack-internal:///./src/index.ts:11:73)
    at eval (webpack-internal:///./src/index.ts:131:30)
    at Module../src/index.ts (/Users/******/git/backstage/packages/backend/dist/main.js:4149:1)
    at __webpack_require__ (/Users/******/git/backstage/packages/backend/dist/main.js:749:30)
    at fn (/Users/******/git/backstage/packages/backend/dist/main.js:60:20)
    at Object.0 (/Users/******/git/backstage/packages/backend/dist/main.js:4293:18)

I prepared a PR to remove the sentry-backend after the next release: https://github.com/backstage/backstage/pull/3621


misskey: 2024.5.0 -> 2024.10.0

Diff: https://github.com/misskey-dev/misskey/compare/2024.5.0...2024.10.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 343505 run on x86_64-linux 1

1 package built:

misskey

CC @feathecutie


Unable to perform any tasks on a Kubernetes Agent

Team

[X] I've assigned a team label to this issue

What happened?
When creating a Kubernetes Octopus Tentacle via either Helm or Flux the agent initially connects and registers itself as a deployment target, After this initial registration the agent refuses to perform any tasks. For example, when running a Health Check the task sits on Determining ScriptService version to use for six minutes before timing out.
Reproduction
Installation of the Kubernetes Agent helm chart at either 1.16.1 or 2.2.1. In the below example I'm using Flux but the same thing happens when using the steps provided by the Octopus Deploy Web UI.
apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: OCIRepository
metadata:
  name: octopus-agent
  namespace: octopus-agent
spec:
  interval: 60m
  url: oci://docker.io/octopusdeploy/kubernetes-agent
  ref:
    tag: 2.2.1
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: octopus-agent
  namespace: octopus-agent
spec:
  interval: 10m
  releaseName: octopus-agent
  chartRef:
    kind: OCIRepository
    name: octopus-agent
  values:
    agent:
      acceptEula: "Y"
      name: ${target_name}
      serverUrl: https://octopus.<snipped>/
      serverCommsAddress: https://octopus.<snipped>:10943/
      space: Default
      serverApiKeySecretName: octopus-api-key
      deploymentTarget:
        enabled: "true"
        initial:
          environments: ["${target_environment}"] # Variable Subtition replaces this
          tags: ["${target_role}"]  # Variable Subtition replaces this
          tenantTags: ["${target_tenant_tag}"]  # Variable Subtition replaces this
          tenants: ["${target_tenant}"]  # Variable Subtition replaces this
          tenantedDeploymentParticipation: "TenantedOrUntenanted"
    persistence:
      storageClassName: azurefile

Error and Stacktrace
Determining ScriptService version to use
The task was canceled
The task was canceled Script execution was cancelled

System.OperationCanceledException: Script execution was cancelled

 ---> Halibut.Exceptions.ConnectingRequestCancelledException: The Request was cancelled while Connecting.

 ---> System.Threading.Tasks.TaskCanceledException: A task was canceled.

   at Nito.AsyncEx.TaskExtensions.DoWaitAsync(Task task, CancellationToken cancellationToken)

   at Halibut.ServiceModel.PendingRequestQueueAsync.PendingRequest.WaitForResponseToBeSet(Nullable`1 timeout, Boolean cancelTheRequestWhenTransferHasBegun, CancellationToken cancellationToken)

   --- End of inner exception stack trace ---

   at Halibut.ServiceModel.PendingRequestQueueAsync.PendingRequest.WaitForResponseToBeSet(Nullable`1 timeout, Boolean cancelTheRequestWhenTransferHasBegun, CancellationToken cancellationToken)

   at Halibut.ServiceModel.PendingRequestQueueAsync.PendingRequest.WaitUntilComplete(CancellationToken cancellationToken)

   at Halibut.ServiceModel.PendingRequestQueueAsync.PendingRequest.WaitUntilComplete(CancellationToken cancellationToken)

   at Halibut.ServiceModel.PendingRequestQueueAsync.QueueAndWaitAsync(RequestMessage request, CancellationToken cancellationToken)

   at Halibut.ServiceModel.PendingRequestQueueAsync.QueueAndWaitAsync(RequestMessage request, CancellationToken cancellationToken)

   at Halibut.HalibutRuntime.SendOutgoingPollingRequestAsync(RequestMessage request, CancellationToken cancellationToken)

   at Halibut.HalibutRuntime.SendOutgoingRequestAsync(RequestMessage request, MethodInfo methodInfo, CancellationToken cancellationToken)

   at Halibut.ServiceModel.HalibutProxyWithAsync.MakeRpcCall(MethodInfo asyncMethod, Object[] args)

   at Halibut.ServiceModel.HalibutProxyWithAsync.InvokeAsyncT[T](MethodInfo asyncMethod, Object[] args)

   at System.Reflection.AsyncDispatchProxyGenerator.InvokeAsync[T](Object[] args)

   at Octopus.Tentacle.Contracts.Capabilities.BackwardsCompatibleAsyncClientCapabilitiesV2Decorator.<>c__DisplayClass2_0.<<GetCapabilitiesAsync>b__0>d.MoveNext()

--- End of stack trace from previous location ---

   at Octopus.Tentacle.Contracts.Capabilities.BackwardsCompatibleCapabilitiesV2Decorator.WithBackwardsCompatabilityAsync(Func`1 inner)

   at Octopus.Tentacle.Contracts.Capabilities.BackwardsCompatibleAsyncClientCapabilitiesV2Decorator.GetCapabilitiesAsync(HalibutProxyRequestOptions halibutProxyRequestOptions)

   at Octopus.Tentacle.Client.Scripts.ScriptOrchestratorFactory.<DetermineScriptServiceVersionToUse>g__GetCapabilitiesFunc|15_0(CancellationToken ct)

   at Octopus.Tentacle.Client.Execution.RpcCallExecutor.<>c__DisplayClass7_0`1.<<ExecuteWithRetries>b__0>d.MoveNext()

--- End of stack trace from previous location ---

   at Octopus.Tentacle.Client.Retries.RpcCallRetryHandler.<>c__DisplayClass9_0`1.<<ExecuteWithRetries>g__ExecuteAction|2>d.MoveNext()

--- End of stack trace from previous location ---

   at Polly.Retry.AsyncRetryEngine.ImplementationAsync[TResult](Func`3 action, Context context, CancellationToken cancellationToken, ExceptionPredicates shouldRetryExceptionPredicates, ResultPredicates`1 shouldRetryResultPredicates, Func`5 onRetryAsync, Int32 permittedRetryCount, IEnumerable`1 sleepDurationsEnumerable, Func`4 sleepDurationProvider, Boolean continueOnCapturedContext)

   at Polly.AsyncPolicy.ExecuteAsync[TResult](Func`3 action, Context context, CancellationToken cancellationToken, Boolean continueOnCapturedContext)

   at Octopus.Tentacle.Client.Retries.RpcCallRetryHandler.ExecuteWithRetries[T](Func`2 action, OnRetryAction onRetryAction, OnTimeoutAction onTimeoutAction, CancellationToken cancellationToken)

   at Octopus.Tentacle.Client.Execution.RpcCallExecutor.ExecuteWithRetries[T](RpcCall rpcCall, Func`2 action, Action`1 onErrorAction, ITentacleClientTaskLog logger, ClientOperationMetricsBuilder clientOperationMetricsBuilder, CancellationToken cancellationToken)

   at Octopus.Tentacle.Client.Execution.RpcCallExecutor.Execute[T](Boolean retriesEnabled, RpcCall rpcCall, Func`2 action, Action`1 onErrorAction, ITentacleClientTaskLog logger, ClientOperationMetricsBuilder clientOperationMetricsBuilder, CancellationToken cancellationToken)

   at Octopus.Tentacle.Client.Execution.RpcCallExecutor.Execute[T](Boolean retriesEnabled, RpcCall rpcCall, Func`2 action, ITentacleClientTaskLog logger, ClientOperationMetricsBuilder clientOperationMetricsBuilder, CancellationToken cancellationToken)

   at Octopus.Tentacle.Client.Scripts.ScriptOrchestratorFactory.DetermineScriptServiceVersionToUse(CancellationToken cancellationToken)

   at Octopus.Tentacle.Client.Scripts.ScriptOrchestratorFactory.CreateOrchestrator(CancellationToken cancellationToken)

   --- End of inner exception stack trace ---

   at Octopus.Tentacle.Client.Scripts.ScriptOrchestratorFactory.CreateOrchestrator(CancellationToken cancellationToken)

   at Octopus.Tentacle.Client.TentacleClient.ExecuteScript(ExecuteScriptCommand executeScriptCommand, OnScriptStatusResponseReceived onScriptStatusResponseReceived, OnScriptCompleted onScriptCompleted, ITentacleClientTaskLog logger, CancellationToken scriptExecutionCancellationToken)

   at Octopus.Server.Orchestration.Targets.Tentacles.TentacleRemoteEndpointFacade.ExecuteCommand(ExecuteScriptCommand startScriptCommand, ITaskLog taskLog, CancellationToken cancellationToken) in ./source/Octopus.Server/Orchestration/Targets/Tentacles/TentacleRemoteEndpointFacade.cs:line 37

   at Octopus.Server.Orchestration.Targets.Common.RemoteEndpointFacadeCancellationTokenDecorator.ExecuteCommand(ExecuteScriptCommand command, ITaskLog taskLog, CancellationToken cancellationToken) in ./source/Octopus.Server/Orchestration/Targets/Common/RemoteEndpointFacadeCancellationTokenDecorator.cs:line 36

   at Octopus.Server.Orchestration.Targets.Tentacles.Observability.ErrorLoggingRemoteEndpointFacadeDecorator.ExecuteCommand(ExecuteScriptCommand command, ITaskLog taskLog, CancellationToken cancellationToken) in ./source/Octopus.Server/Orchestration/Targets/Tentacles/Observability/ErrorLoggingRemoteEndpointFacadeDecorator.cs:line 57

   at Octopus.Server.Orchestration.ServerTasks.Deploy.ActionExecution.Immediate.ExecutionTargets.TentacleExecutionTarget.Execute(ExecuteScriptCommandBuilder commandBuilder, ScriptCollection bootstrapScripts, Boolean isRaw, ITaskLog taskLog, CancellationToken cancellationToken) in ./source/Octopus.Server/Orchestration/ServerTasks/Deploy/ActionExecution/Immediate/ExecutionTargets/TentacleExecutionTarget.cs:line 51

   at Octopus.Server.Orchestration.ServerTasks.Deploy.ActionExecution.Immediate.ImmediateExecutor.ExecuteRawScript(ScriptCollection scripts, IReadOnlyList`1 files, Boolean isRaw, ITaskLog taskLog, CancellationToken cancellationToken, Nullable`1 isolationMutexTimeout, ExecutionIsolation isolationLevel) in ./source/Octopus.Server/Orchestration/ServerTasks/Deploy/ActionExecution/Immediate/ImmediateExecutor.cs:line 126

   at Octopus.Server.Orchestration.ServerTasks.Deploy.ActionExecution.CommandBuilders.RawShellCommandBuilder.Execute(ITaskLog taskLog, CancellationToken cancellationToken) in ./source/Octopus.Server/Orchestration/ServerTasks/Deploy/ActionExecution/CommandBuilders/RawShellCommandBuilder.cs:line 36

   at Octopus.Server.Orchestration.ServerTasks.HealthCheck.Providers.MachineHealthProvider.<>c__DisplayClass19_0.<<ExecutePreCheckScript>b__0>d.MoveNext() in ./source/Octopus.Server/Orchestration/ServerTasks/HealthCheck/Providers/MachineHealthProvider.cs:line 139

--- End of stack trace from previous location ---

   at Octopus.Server.Orchestration.ServerTasks.Deploy.ActionDispatch.AdHocActionDispatcher.InvokeActionHandler(Machine target, ActionHandlerInvocation actionHandler, ActionAndTargetScopedVariables actionAndTargetScopedVariables, IExecutor executor, TargetManifest targetManifest, ITaskLog taskLog, CancellationToken cancellationToken) in ./source/Octopus.Server/Orchestration/ServerTasks/Deploy/ActionDispatch/AdHocActionDispatcher.cs:line 240

   at Octopus.Server.Orchestration.ServerTasks.Deploy.ActionDispatch.AdHocActionDispatcher.ExecuteOnDeploymentTarget(DeploymentTarget deploymentTarget, ActionHandlerInvocation actionHandler, TargetManifest targetManifest, ITaskLog taskLog, CancellationToken cancellationToken) in ./source/Octopus.Server/Orchestration/ServerTasks/Deploy/ActionDispatch/AdHocActionDispatcher.cs:line 162

   at Octopus.Server.Orchestration.ServerTasks.Deploy.ActionDispatch.AdHocActionDispatcher.Dispatch(Machine machine, ActionHandlerInvocation actionHandler, ITaskLog taskLog, CancellationToken cancellationToken, VariableCollection variables) in ./source/Octopus.Server/Orchestration/ServerTasks/Deploy/ActionDispatch/AdHocActionDispatcher.cs:line 68

   at Octopus.Server.Orchestration.ServerTasks.HealthCheck.Providers.MachineHealthProvider.ExecutePreCheckScript(Machine machine, TimeSpan cancellationTimeout, CancellationToken linkedCts) in ./source/Octopus.Server/Orchestration/ServerTasks/HealthCheck/Providers/MachineHealthProvider.cs:line 137

   at Octopus.Server.Orchestration.ServerTasks.HealthCheck.Providers.MachineHealthProvider.PerformHealthCheckAndSaveResult(Machine machine, CancellationToken cancellationToken, ExceptionHandling exceptionHandling) in ./source/Octopus.Server/Orchestration/ServerTasks/HealthCheck/Providers/MachineHealthProvider.cs:line 89

Octopus.Server version 2024.2.9274 (2024.2.9274)
Recording health check results

Pod Logs:
$ kubectl logs octopus-agent-tentacle-5d5b585c76-4qncc -f
Rehashing SSL/TLS certificates
rehash: warning: skipping ca-certificates.crt,it does not contain exactly one certificate or CRL
Checking registration status...
Tentacle is already configured and registered with server.
2024-09-09 14:39:44.3626 | DEBUG | Machine configuration home directory is /etc/octopus
2024-09-09 14:39:44.3755 | DEBUG | Loading configuration from ConfigMap for namespace octopus-agent
Disabling polling proxy
2024-09-09 14:39:45.2912 | DEBUG | Machine configuration home directory is /etc/octopus
2024-09-09 14:39:45.3056 | DEBUG | Loading configuration from ConfigMap for namespace octopus-agent
2024-09-09 14:39:45.7612 |  INFO | Proxy use is disabled
===============================================
Starting Octopus Deploy Kubernetes Tentacle
===============================================
2024-09-09 14:39:46.1646 | DEBUG | Machine configuration home directory is /etc/octopus
2024-09-09 14:39:46.1777 | DEBUG | Loading configuration from ConfigMap for namespace octopus-agent
2024-09-09 14:39:46.6331 | DEBUG | Loading certificate with thumbprint: E7363A5076C2C5761CC708528AB274ED57F4C258
2024-09-09 14:39:46.6458 | DEBUG | Loading certificate from given string
2024-09-09 14:39:46.6971 | DEBUG | Loading certificate with thumbprint: E7363A5076C2C5761CC708528AB274ED57F4C258
2024-09-09 14:39:46.7195 | DEBUG | Certificate was found in store
2024-09-09 14:39:46.7327 | DEBUG | Loading certificate with thumbprint: E7363A5076C2C5761CC708528AB274ED57F4C258
2024-09-09 14:39:46.7507 | DEBUG | Certificate was found in store
2024-09-09 14:39:46.7841 | DEBUG | Loading certificate with thumbprint: E7363A5076C2C5761CC708528AB274ED57F4C258
2024-09-09 14:39:46.8097 | DEBUG | Certificate was found in store
2024-09-09 14:39:46.9654 |  INFO | Agent will trust Octopus Servers with the thumbprint: C23BD667F4B5B9EF5233FE34C5E8D1054EC8FFEE
2024-09-09 14:39:46.9818 |  INFO | Agent will poll Octopus Server at https://octopus.<snipped>:10943/ for subscription poll://l84vsys9r9euqc6h3psb/ expecting thumbprint C23BD667F4B5B9EF5233FE34C5E8D1054EC8FFEE
2024-09-09 14:39:46.9955 |  INFO | Agent will not use a proxy server
2024-09-09 14:39:47.0092 |  INFO | Requested polling connection count: 5
2024-09-09 14:39:47.0208 |  INFO | Starting 5 polling connections
2024-09-09 14:39:47.0372 |  INFO | Agent will not listen on any TCP ports
2024-09-09 14:39:47.0713 |  INFO | WorkspaceCleanerTask.Start(): Starting
2024-09-09 14:39:47.0823 | DEBUG | https://octopus.<snipped>:10943/    8  Opening a new connection to https://octopus.<snipped>:10943/
2024-09-09 14:39:47.0823 | DEBUG | https://octopus.<snipped>:10943/    9  Opening a new connection to https://octopus.<snipped>:10943/
2024-09-09 14:39:47.0823 | DEBUG | https://octopus.<snipped>:10943/   12  Opening a new connection to https://octopus.<snipped>:10943/
2024-09-09 14:39:47.0823 | DEBUG | https://octopus.<snipped>:10943/    6  Opening a new connection to https://octopus.<snipped>:10943/
2024-09-09 14:39:47.0823 | DEBUG | https://octopus.<snipped>:10943/   11  Opening a new connection to https://octopus.<snipped>:10943/
2024-09-09 14:39:47.0862 |  INFO | KubernetesPodMonitorTask.Start(): Starting
2024-09-09 14:39:47.1265 | DEBUG | Cleaning workspaces older than 09/08/2024 14:39
2024-09-09 14:39:47.1827 |  INFO | https://octopus.<snipped>:10943/   12  Secure connection established. Server at [::ffff:<IP_ADDRESS>]:10943 identified by thumbprint: C23BD667F4B5B9EF5233FE34C5E8D1054EC8FFEE, using protocol Tls12
2024-09-09 14:39:47.1827 |  INFO | https://octopus.<snipped>:10943/    6  Secure connection established. Server at [::ffff:<IP_ADDRESS>]:10943 identified by thumbprint: C23BD667F4B5B9EF5233FE34C5E8D1054EC8FFEE, using protocol Tls12
2024-09-09 14:39:47.1827 |  INFO | https://octopus.<snipped>:10943/   11  Secure connection established. Server at [::ffff:<IP_ADDRESS>]:10943 identified by thumbprint: C23BD667F4B5B9EF5233FE34C5E8D1054EC8FFEE, using protocol Tls12
2024-09-09 14:39:47.1827 |  INFO | https://octopus.<snipped>:10943/    8  Secure connection established. Server at [::ffff:<IP_ADDRESS>]:10943 identified by thumbprint: C23BD667F4B5B9EF5233FE34C5E8D1054EC8FFEE, using protocol Tls12
2024-09-09 14:39:47.1881 |  INFO | KubernetesOrphanedPodCleanerTask.Start(): Starting
2024-09-09 14:39:47.2112 | DEBUG | No workspaces found that need to be deleted.
2024-09-09 14:39:47.2455 |  INFO | https://octopus.<snipped>:10943/    6  Secure connection established. Server at [::ffff:<IP_ADDRESS>]:10943 identified by thumbprint: C23BD667F4B5B9EF5233FE34C5E8D1054EC8FFEE, using protocol Tls12
2024-09-09 14:39:47.2497 | DEBUG | Loading pod statuses
2024-09-09 14:39:47.2925 |  INFO | KubernetesEventMonitorTask.Start(): Starting
2024-09-09 14:39:47.3458 |  INFO | Parsing kubernetes event list for namespace octopus-agent.
2024-09-09 14:39:47.3522 | DEBUG | Loaded 0 pod statuses in 00:00:00.0335342. ResourceVersion: 101091083
2024-09-09 14:39:47.4294 |  INFO | Found 23 events since last logged event 0001-01-01T00:00:00.0000000+00:00
2024-09-09 14:39:47.4464 |  INFO | Added 0 entries to agent metrics.
2024-09-09 14:40:47.2855 | DEBUG | OrphanedPodCleaner: Checking for orphaned pods
2024-09-09 14:40:47.3248 | DEBUG | OrphanedPodCleaner: No orphaned pods found
2024-09-09 14:40:47.3380 | DEBUG | OrphanedPodCleaner: Next check will happen at 2024-09-09T14:50:47.3380634+00:00

More Information

^^ This never finishes even when doing this from the UI.
Workaround
No response

Hi @cpressland
Sorry that this isn't working for you. It looks like the agent is failing to communicate with server using our RPC protocol.
Am I correct in assuming you are self-hosting Octopus Server?
If so, is the port 10943 open on the Octopus Server machine and accessible from the cluster?

Hi @APErebus - we got to the bottom of this after a week or so of hacking and trying different things.

We have multiple Octopus Servers in a HA Configuration, we were using The Helm Charts agent.serverCommsAddress to point to an Azure Load Balancer, we swapped to using agent.serverCommsAddresses and hitting each server directly.
When updating from serverCommsAddress to serverCommsAddresses the agent went from intermittent to completely non-functional. This turned out to be that the agent only configures trusts for remote servers on its first launch, if you change this list after deployment it'll silently ignore those "new" servers and just sit there doing nothing, forever. We solved this by uninstalling the agent and reinstalling each time we had to make a config change.

I think I should raise another issue to get logging improved for this failure condition, else, I'll go ahead and close this off.


Can't add documents (and not showing error) when the primary key contains non-alphanumeric

Describe the bug
Can't add documents (and not showing error) when the primary key contains non-alphanumeric (tested on '?' and '.' characters). Didn't find any warning about this in the documentation.
To Reproduce
Steps to reproduce the behavior:

Use meilisearch nodejs sdk
Create index with primaryKey: "serial"
Call addDocuments to the index with [{ "serial": "test-serial?", ... }, { "serial": "valid-serial", ... }]
The documents aren't added and doesn't receive an error. (I guess because it is atomic, the valid serial aren't added as well)

Expected behavior
Show an error or be able to add documents with non-alphanumeric characters on primary key
MeiliSearch version: [e.g. v0.20.0]
v0.20.0
Additional context
Run on docker on cloud vm

Hello @nafkhanzam!
MeiliSearch processes its tasks asynchronously. It means you will only get an updateId when sending your documents, but to know if the task failed or not and why, you have to check the GET /indexes/:uid/updates/:updateId routes.
More details here: https://docs.meilisearch.com/faq/#i-did-a-call-to-an-api-route-and-i-only-got-an-updateid-as-a-response-what-does-it-mean
Your addition probably failed because indeed you cannot add documents where the primary key contains special characters. This is explained here in the documentation: https://docs.meilisearch.com/learn/core_concepts/documents.html#document-id

Ahh, I definitely missed that, thank you


fix import

https://github.com/hrushikeshrv/chessengine/issues/1

Hey @TheParmak, thanks for your PR! I've assigned #1 to @Montekkundan since he reported that issue as a part of Hacktoberfest, and he was waiting till 1st Oct to send a PR. However, I'll be opening a few more issues soon and you could pick between them :)

ohhh okay sorry lol I'll help with others then


Hotfix accuracy

🚀

Hello.
Thank you for SwifterSwift.
Found out that if accuracy == 1.0 then UIColor.red == UIColor.green. We should use a value close to 0.
Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 5.0.
[x] New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger


Do not add init duration of 0.00 ms to REPORT log lines

What does this PR do?
We receive REPORT log lines from the Lambda Logs API as JSON objects. We then construct a log string based on the values in the JSON. Previously, we would add an InitDuration to the string even if the value of this metric was 0.00 ms. This does not match the behavior of CloudWatch logs, which exclude the value if there is no init duration.
We rely on the presence or absence of the init duration metric to mark invocations as cold starts; if there is an init duration present, we consider that invocation a cold start. Because we were erroneously adding InitDuration to all REPORT log lines, we were also erroneously marking all invocations as cold starts.
Motivation

Match behavior of CloudWatch logs
Stop erroneously marking all invocations as cold starts

Describe how to test your changes

Unit tests
Manual testing

LGTM


KeepAlive Mechanism on NSP Target Registry

TODO:

Tapa stream tests
Logs

https://github.com/Nordix/Meridio/issues/192

/reverify


fix(explorer/#1799): Infinite loop with certain windows paths

Issues: Certain path constructions (as described in #1799) - could cause the explorer to go into a cycle, where it's continually trying to expand a node.
Defect: When we parse the initial path, we remove the trailing separator - without doing that, the Sys.is_directory call won't give us the expected result. The code here wasn't removing the trailing separator on Windows (only forward slashes were handling). When using a path like . from a working directory of C:\oni2, the path would come through as C:\oni2\, causing this check to give incorrect results.
This same would also fail when we recursively look through the files and folders of the directory tree, causing us to spin and keep querying the same directory.
Fix: Correct the trailing-separator logic in the Cli parsing.
TODO:

[x] Fix remaining issue with root directory

It would also be helpful to switch to a more robust strategy for working paths, instead of strings, like the fp library. This gets out of the business of worrying about trailing-path separators.
Fixes #1799

/azp run


[1.31.0] TapOn within a specific point in an element doesn't work

Describe the bug
Tap on specific point within an element is not working on ios. Instead of clicking on a point within the element, it taps on the point within the screen (ignoring id/text selector altogether). Have not tried on android.
Reference: https://maestro.mobile.dev/api-reference/commands/tapon#tapping-on-a-specific-point-within-another-element
To Reproduce
1- Start ios simulator
2- Try to tap on a specific point within an element using this code:
- tapOn:      id: ${selector}     point: "25%, 85%"
Expected behavior
The tap should find the point within the element and then tap.
Screenshots
No screenshots needed.
Link to Slack conversation: https://mobile-dev-inc.slack.com/archives/C041FU72T54/p1693881938655019
Environment information (please complete the following information):

Maestro version 1.31.0
Platform: iOS 16.2
Framework: React Native
Device model and OS version: iPhone 14
Simulator
Host Mac M1

Workspace (if applicable)
Please share your workspace with Flow files and application binary if you are able to do so as that greatly helps in reproduction efforts.
Bugreport output (if applicable)
The zip files created when maestro bugreport can be uploaded here as well if applicable.
Additional context
Add any other context about the problem here.

I see the same issue in Android as well

I have the same problem

We're seeing the same issue as well

Affects us as well

The docs are a lie.
If point isn't null then Orchestra.tapOnPointV2Command gets called instead of tapOnElement.
tapOnPointV2Command has no notion of the tapped element. It needs to call findElement(command.selector) and if it find something pass the resulting element and hierarchy down to Maestro.tapOnRelative, which currently only ever uses cachedDeviceInfo.widthGrid (and height), when it should be using the bounds of the element
but tbh I'd probably go with merging the tap on point & tap on element logics

Same issue here

Issue still exists


Download to DICM can support in ios?When download to DocumentDir, we can't find that image in file system.

@zhulichao , could you provide how you use it? From my understanding, DCIM folder is Android only, IOS does not have an external storage.

same issue here. where should we put the files we want to store on the phone? for android im using the RNFetchBlob.dirs.PictureDir. For iOS, am i supposed to use RNFetchBlob.dirs.DocumentDir? im storing files locally for offline use and faster retrival, so the app doesnt have to download the images and files again and again

what's the status on this one? DCIM is for Android only. But how about IOS? i tried using DocumentDir but i cant find the files

Any updates on what directory to use for IOS?

Same issue here. Any update on the directory to use for iOS?


[BUG] Cluster Owner is unable to edit OpenStack RKE2 cluster

Rancher Server Setup

Rancher version: 2.6.8
Installation option (Docker install/Helm Chart): Helm

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE2

Proxy/Cert Details: Not important

Information about the Cluster

Kubernetes version: Not important
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Infrastructure provider - OpenStack

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Cluster Owner

If custom, define the set of permissions: N/A

Describe the bug

Exactly the same as #34800, but for OpenStack. IMPORTANT: S3 cloud credentials in the same cluster seems to be immune to this issue and are proxied (see screenshot).

Cloud credentials aren't shareable, so if you create a cluster with user A, make user B a cluster owner (or other roles), and then come to the edit screen as user B, you will not find the credential here.

To Reproduce

Login as User-A, create a new OpenStack cluster using User-A's cloud credential.
Add User-B as a cluster owner.
Login in as User-B.
Attempt to edit the cluster as User-B. You are prompted to create/change the cloud credential for the entire cluster and all of its nodes pools

Result
User-B might not have access to the cluster's OpenStack, and an edit here would be destructive. They should be able to edit cluster as a cluster owner.
Expected Result

User-A's OpenStack cloud credential should be proxied like other cloud credentials (just like the how S3 cloud credential is, in the last screenshot), and User-B should be able to non-destructively edit the cluster.
Screenshots

IMPORTANT: S3 cloud credentials seems to be immune to this issue and can be proxied:

Additional context

Just like #34800, User-B is able to scale the node pools in the cluster using the (+) button.

this is a bug for all custom node drivers as well...


Seems that the goal metrices are not correctly resolved

org.apache.spark.sql.AnalysisException: cannot resolve 'goal1Starts' given input columns adsenseCoverage, dcmImpressions, buyToDetailRate, productRefundAmount, goalXXStarts, dcmFloodlightRevenue, productListViews, userTimingSample,

Same wil probably hold for goal1Completions, goal1ConversionRate etc. as well

Analytics has a concept of templatized columns. We were not aware of this, but it should be handled correctly starting in version 0.8.3.


Flask admin view not loading all rows

I have two models with a one to one relationship:
class ProductsModel(db.Model):
    __tablename__ = "products"
    id = db.Column(db.Integer, primary_key=True)
    nr = db.Column(db.Integer, unique=True)
    title = db.Column(db.String)
    address = db.Column(db.String)
    category_id = db.Column(db.Integer)

    def __init__(self, nr, title, address, category_id):
        self.nr = nr
        self.title = title
        self.address = address
        self.category_id = category_id

class ProductImages(db.Model):
    __tablename__ = "product_images"
    id = db.Column(db.Integer, primary_key=True)
    product_id = db.Column(db.Integer, db.ForeignKey('products.nr'), unique=True, nullable=False)
    image_name = db.Column(db.Unicode(64))
    image_path = db.Column(db.Unicode(128))
    main_image = db.Column(db.Unicode(128), nullable=False)

    product_title = db.relationship('ProductsModel', uselist=False, backref='prodid')

    def __init__(self, product_id, image_name, image_path, main_image):
        self.product_id = product_id
        self.image_name = image_name
        self.image_path = image_path
        self.main_image = main_image

When I add images in ProductimagesView it only shows the first two(although there are more than two). When i filter a column it shows the images on pages of two rows per page and product title is way off course, although they are saved correctly in the database

Can you please help me with this issue. Thank you

It was a mistake on my part. Sorry for this. I will close


[builder] reconfig op_builder for pypi install

What's new
remove duplicated op_builder. Make it work both for setup and runtime building.

I have checkout out your branch and tested locally. I found that symlink does not work as the op_builder folder does not exist after pip install.
Steps to reproduce:

Check out your branch and install without CUDA extensions

# do not run this in editable mode
NO_CUDA_EXT=1 pip install -v .

then get the colossalai file directory

python -c "import colossalai;print(colossalai.__file__)"

Check the files in the colossalai directory

Please ignore my previous comment, it works now.


Grey Block on Dashboard

Describe the bug
Weird grey character appearing on my dashboard
To Reproduce
Steps to reproduce the behavior:
when applying my custom logo in my .config/neovim/static/neovim.cat file
Expected behavior
For no grey block to ruin the aesthetic
Screenshots

reduce width value

post your cat file here i will test later

It was the height


Adding Altair visualizations of US State case growth

This is basically a mashup of two existing visualizations to make something interactive for the US States.

This visualization is very similar to @avyfain 's dashboard https://covid19dashboards.com/growth-us-states/
I think this one has some preferrable features, namely that is interactive.  I suggest merging these two dashboards together --
I will go ahead and start doing this right now

I didn't want to overwrite avyfain's one that served as a model, but I
vastly preferred using Pratap's Altair work. So I amalgamated their code to
make something much more comprehensible to me.
On Fri, Mar 27, 2020 at 4:43 PM Hamel Husain<EMAIL_ADDRESS>wrote:

This visualization is very similar to @avyfain
https://github.com/avyfain 's dashboard
https://covid19dashboards.com/growth-us-states/
I think this one has some preferrable features, namely that is
interactive. I suggest merging these two dashboards together --
I will go ahead and start doing this right now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/covid19-dashboard/pull/215#issuecomment-605102423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACCUPDXT3X3IE6RTTOA6LRJTJRVANCNFSM4LUZJ2JQ
.


equal goals may be considered unequal

It seems that some extraneous information is being used to compare goals, which isn't reflected in the pretty printing of the goal. (So in particular goals which I think should be equal are considered as unequal.)
This occurs particularly when we revert and then re-introduce hypotheses, even when this doesn't change the order of hypotheses, and when there are no dependencies between hypotheses and goals.

This is important to me because for my automation strategy it's important to be able to tell whether a tactic made actual progress. For many tactics I can use the return value, but for simplification, and in particular simplification of hypotheses, I think I'm going to have to use a force tactic to compare the goals before and afterwards.

eblast seems to have the same problem --- the pretty printed (even with pp.all) goal may not appear to change, but the force tactic I'm using says that something happened.

(It occurs to me that it's unnecessary for me to complain about eblast: focus eblast has the effect I'm after, even though force eblast runs into trouble. The main problem, with reverting and reintroducing goals, is still there.)

What is going on here is that every goal (i.e. metavariable) has a local context, which is a list of local variables. Every local variable has a user-facing name for pretty-printing, and a unique internal name. When you revert an element of the local context and then intron 1, you are creating a new local constant with the same user-facing name, but it is not the same local constant.
More to the point, the goals are not the same metavariable. The original goal was one metavariable, and by starting to prove it with tactics, you are building an assignment for it, which is an expression that involves the other metavariable (in this case, the first is assigned to an abstraction followed by an application of the other).
I don't see an easy way to compare two goals to see whether they are equivalent. (But that does not mean there isn't one....) Can you write your tactics in such a way that you can manually track whether they have made progress?

You can compare the types of the goals instead of the goal metavariables themselves:
meta def force { α : Type } (t : tactic α) : tactic α :=
  do gs ← get_goals >>= monad.mapm infer_type,
     a ← t,
     gs' ← get_goals >>= monad.mapm infer_type,
     guard (gs ≠ gs') <|> fail "force tactic failed",
     return a

This doesn't seem particularly robust, but it might work for your purposes. I agree with Jeremy that the ideal solution is to have the tactics keep track.

Thanks for these explanation. I guess this goes back to my earlier issue https://github.com/leanprover/lean/issues/1449, where I asked that dsimp should fail if it didn't change anything. @leodemoura disagreed there, say that it was annoying when writing tactics to have sub-tactics fail. I still feel the opposite --- it's annoying to have sub-tactics "silently fail", i.e. succeed even when they do nothing.
I've just read through the chain of calls simp ---> simp_core ---> simp_goal ---> simplify_core that result when we call simp in interactive mode. I'm struggling to see where the failure is actually generated when there is nothing to simplify.
If someone could explain that, I'll happily adopt the strategy of modifying tactics so they track progress themselves.

I'm struggling to see where the failure is actually generated when there is nothing to simplify.

It's in the simplify_core implementation, using the same approach as force: https://github.com/leanprover/lean/blob/36c7d46c34f89a671b27c9ca31bcd86bc5d5ad7b/src/library/tactic/simplify.cpp#L1242
I'm not sure I understand your original issue yet. While force { intro...dsimp...revert } does not work, shouldn't intro...force {dsimp}...revert do what you want?

Thanks, @rlewis1988  and @Kha, those are both very helpful solutions, that I think should solve my problem.


Numerical arguments generates invalid id names

How to reproduce:
$ ./zatsu_cwl_generator.d "head -n 5 ccc.txt > output.txt" | tee head.cwl
class: CommandLineTool
cwlVersion: v1.0
baseCommand: head
arguments:
  - -n
  - $(inputs.5)
  - $(inputs.ccc_txt)
inputs:
  - id: 5
    type: int
  - id: ccc_txt
    type: File
outputs:
  - id: out
    type: stdout
stdout: output.txt
$ cwltool head.cwl --help
...
schema_salad.exceptions.ValidationException:<PHONE_NUMBER>) (file:///Users/tanjo/repos/zatsu-cwl-generator/head.cwl) Validation error in position 0:
  identifier field '5' must be a string
...

It is because the argument 5 generates the input parameter 5 that is invalid because it is an integer type. It should be fixed by changing the parameter into "5" or _5, for example.

In the above exampple, introducing "5" or _5 is not the right solution because it should introduce n parameter due to the previous argument is -n. It will be fixed by #9.

It was solved by #9.


GitHub actions

Adds a Github action for benchmarking, using Cabal instead of stack (since the stack implementation gets stuck, see #893)
Builds on top of #893

Runs: https://github.com/pepeiborra/ghcide/actions

Benchmarks do not build in Windows because of the Cairo requirement


[INSTALLATION PROBLEM]

I am following the steps of the installation, but when I run the commands in step 6 I get this error:

I am using Windows 10

Please update to version 5.2.0 using the Windows installer provided on the main page.


ExtractTextPlugin isn't compiling sass

When using HMR and the dev-server i have the following loader setup.
          {
              test: /\.s?css$/,
              loaders: ["style", "raw", "sass?sourceMap"]
          },

This works great, my page is hot reloading and everything.
For production i wanted to extract the generated css into its own file, so I changed my production loader to use.
        {
            test: /\.s?css$/,
            loader: ExtractTextPlugin.extract("style", "raw", "sass")
        }

ExtractText seems to be pulling my sass out, but I only get my first file, none of the @include statements are pulled in via sass. It seems as though sass doesn't get a chance to compile the file.
Any thoughts on what I am doing wrong?

@Jmeyering , I believe you need to remove the style loader from the prod config. raw loader isn't necessary in both configs too.

The same for me, any ideas?

I never got it to work at all. I switched to extract-loader
https://github.com/jtangelder/sass-loader

I don't think is related to sass-loader. The issue is in how options are being passed to the plugin:
Something like any of the below should work:
ExtractTextPlugin.extract("style", "!raw!sass")
ExtractTextPlugin.extract("style", ["raw", "sass"])

The key is defining the initial loader separately.

That's perfect! Thanks so much for the tip!


mac os X has timeline not being found

I can find the file on a Mac OS X Yosemite if I put timeline_data.yml in the jobs directory and change this line as follows in timeline.rb job.
#config_file = File.dirname(File.expand_path(__FILE__)) + '../timeline_data.yml'
config_file = File.dirname(File.expand_path(__FILE__)) + '/timeline_data.yml'

Can't test on mac atm, but try fiddling with the string, maybe remove the / prefix.
The File methods should be OS independent.


[0.11.0] Unable to drop meta node

Version information:
InfluxDB v0.11.0.n1455264033 (git: master b70d83af6a096d456bf555be62ebf94870098c9d, built 2016-02-12T08:02:11.368255)

Dropping a meta node seems to work initially:
> show servers
name: data_nodes
----------------
id	http_addr	tcp_addr
1	influx1:8086	influx1:8088
4	influx2:8086	influx2:8088
5	influx3:8086	influx3:8088

name: meta_nodes
----------------
id	http_addr	tcp_addr
1	influx1:8091	influx1:8088
2	influx2:8091	influx2:8088
3	influx3:8091	influx3:8088

> drop data server 4
> drop meta server 2
> show servers
name: data_nodes
----------------
id	http_addr	tcp_addr
1	influx1:8086	influx1:8088
5	influx3:8086	influx3:8088

name: meta_nodes
----------------
id	http_addr	tcp_addr
1	influx1:8091	influx1:8088
3	influx3:8091	influx3:8088

But if you restart the server, the meta node re-appears and can't be dropped:
> show servers
name: data_nodes
----------------
id	http_addr	tcp_addr
1	influx1:8086	influx1:8088
5	influx3:8086	influx3:8088

name: meta_nodes
----------------
id	http_addr	tcp_addr
1	influx1:8091	influx1:8088
2	influx2:8091	influx2:8088
3	influx3:8091	influx3:8088

> drop meta server 2
ERR: meta service returned 503 Service Unavailable

This may have to do with a leader not being present (since no quorum can be formed), but nothing shows signs of an issue except for these messages in the logs:
[monitor] 2016/02/12 21:14:49 failed to store statistics: write failed

0.10.1 lets you "remove" it again and again, but it always comes back after a restart.

Clustering is removed from the open source version now.


Reduce content on modal

[ ] Bottom CTA is missing, Need to  to reduce content

@Raheel1258 Please Remove test net mode line in both modal

@Raheel1258 in live app it is fine so closing this


⚠ Jenkins Plugins Artifactory has degraded performance

In bd47b64, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1192 ms

Resolved: Jenkins Plugins Artifactory performance has improved in c0d3cd2 after 33 minutes.


Fix m2m_deregister_res typo in printf

Summary of changes

Just a simple typo fix in a print for the m2m_deregister_res resource.

[X] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[X] I confirm the moderators may change the PR before merging it in.
For new board enablements only:
[] I confirm the board is Mbed Enabled and passes the Mbed Enabled test set.
[] I confirm the contribution has been tested properly and the tests results for TESTS are attached.
[] I confirm mbed-os.lib and mbed-cloud-client.lib hashes or the content in folders mbed-os and mbed-cloud-client were not modified in order to pass the tests.

Maintainers of this repository update the Mbed OS and Client hashes.
Please report any issues through issues in relevant repositories.

Thanks for your changes.
@ARMmbed/pdmc-integrators please review.

build-only

Test run: SUCCESS

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/


If JavaFastPFOR can have list/set as parameters

It seems as if only type int[] data can be passed as parameters now. Many times people would use Collections such as List/Set though, especially for large amount of data transmission/streaming/IO.
I wonder if there are APIs taking List/Set as parameters.

You can convert your data structures to arrays easily:
int[] array = list.stream().mapToInt(i->i).toArray();

and then call the appropriate methods.
If you have more sophisticated/efficient ideas, please consider creating a pull request so we can discuss the issue with code samples.


[question] a matrix calculating question

I have a question about this program.
In urdf2casadi/examples/user/ur5_example.ipynb, the dynamic parameters are written as To obtain the dynamic parameters (M, C, G) of the equation of motion tau = M(q)q_ddot + C(q, q_dot)q_dot + G(q). But the example shows  C(q, q_dot) is a 61 matrix and wo know q_dot is a 61 matrix. So how does it work?
Thanks for your answers! orz @mahaarbo @lillmaria

Hi, sorry for the late reply. The get_coriolis_rnea function actually produces the Coriolis bias vector, not the Coriolis matrix. I will update the example with the proper descriptions of how the dynamic parameters are obtained shortly.

Hope the description is a little easier to follow now.


Bad @ATTRIBUTE format for "@ATTRIBUTE 0 {0,1} "

In text mining task,we may want to design a feature, which indicates whether a document has the word "0". The feature in arff format is "@ATTRIBUTE 0 {0,1}".  When liac-arff parses it, we may encounter the "Bad @ATTRIBUTE format" exception.
The similar problem occurs, when "@ATTRIBUTE _qacct {0,1}".

Related to #24.
Thanks for the feedback, I'm closing this one because #24 also solves this problem.


Print NginxConfig in JSON format for debug and trace levels

Proposed changes
This PR changes the log.traceF and log.debugF function arguments in those cases where we log the NginxConfig protobuf message. Instead of the raw message (which is harder to parse and read when doing troubleshooting), the JSON version of the object is now logged.
Closes #209
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[ ] If applicable, I have added tests that prove my fix is effective or that my feature works
[ ] If applicable, I have checked that any relevant tests pass after adding my changes
[x] I have updated any relevant documentation (README.md)

Can you run make deps as well?

@dhurley make deps is failing in my fork:
fatal: No names found, cannot describe anything.
cd sdk && go mod tidy && go mod vendor &&  make generate && go mod tidy && go mod vendor
go: finding module for package github.com/nginx/agent/sdk/v2/proto/events
go: finding module for package github.com/nginx/agent/sdk/v2/proto
github.com/nginx/agent/sdk/v2 imports
github.com/nginx/agent/sdk/v2/proto: no matching versions for query "latest"
github.com/nginx/agent/sdk/v2/client imports
github.com/nginx/agent/sdk/v2/proto/events: no matching versions for query "latest"
make: *** [deps] Error 1

make deps looks outdated, I'll do a separate PR for that


✨[Feature Request]: Automatic assign

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
if the project owner or mentor , comments
/assign , it will assign to the particular issue created contributor.
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@varshith257 please assign me this issue.


Remove controller script when the client navigates back to browse

On second thought, the browser performs a reload so I don't think this is necessary.

Shouldn't be a problem now we use content script to inject


Memorystream in JSON serializer - feature request

Thank you for the great job indeed.
It would be extremely productive if memorystream can be serialized in json serializer.

Sorry, could you explain a little more?

If we have a published property of type TMemoryStream, where an image file has been loaded, is that field serilized? If not it would be extremely useful if further enhanceed to support such operations. I am trying to use your serilizer to carry information from a server to the client that includes image & pdf documents.
Thanks

If we have a published property of type TMemoryStream, where an image file has been loaded, is that field serilized? If not it would be extremely useful if further enhanceed to support such operations. I am trying to use your serilizer to carry information from a server to the client that includes image & pdf documents.
Thanks

Now, you can serialize/deserialize to/from a stream (UTF8 json text). Useful to send json with a http client without convert string to stream.
And you can serialize property type TStream or inheriteds. Json Serializer will convert stream content to Base64 json string property (by default).
If you don't want use Base64 then set UseBase64Streams to False and json string will be filled with unicode escape chars.
You can see new sample  in samples\QuickJsonSerializer\ComplexObjects


Adding hooks to 3rd-party objects

Our code provides some django-models and we use django-lifecycle. Our models are also used in a library-like way where other django-projects want to provide some post-creation workflows after our code creates those model objects.
How can we add a hook to a model without monkey patching it? The other code can't subclass our model because then our code won't be using their subclassed type.
It would be great if there was a way to register a hook onto a model in a way other than class definition somehow. If you have any pointers on how to add this, I wouldn't mind implementing it.

Assuming the model in question is already subclassing the LifecycleMixin / LifecycleModel class, maybe you could do something like:
Model.x = hook("before_create")(Model.x)

But, that is basically "monkey patching".  I don't think there would be any other way though, there is no global registry or anything like that being utilized.
Also, it's a hard requirement that the model subclasses LifecycleModel / LifecycleMixin.

I don't know how this could be done, because as @dralley says, it's required to subclass LifecycleMixin.
If someone has some clues on how could this problem be solved, we're happy to accept a PR or even implement it ourselves, but until that I'm going to close this as won't fix.


Add support for create_or_update for user resource

This is going to add support for the very convenient create_or_update on a user resource.
To-Do:

[ ] Live tests?

Thank you for your contribution, @rkallensee . Apologies for the very long wait to get it merged.

I'm a bit confused - I'm not sure this works. See my comment in https://github.com/zendesk/zendesk_api_client_rb/issues/308


Left arrow key press now navigates to the parent element

This feature is specific to HierarchicalTreeDataGrid.
Hitting the left arrow key should focus the selection to the parent element.
When a node is focused, if you hit the LEFT arrow key, it should navigate to the parent node.
Example:

The only problem is that sometimes it loses keyboard focus but I think it isn't related to my code.

moving to draft since I've found a bug


the  custom attributes mcv_rightArrowMask and mcv_leftArrowMask don't work

when i use this widget i find out that two custom attributes don't work .
mcv_rightArrowMask and mcv_leftArrowMask.
i read the code and found out where went wrong.
Drawable leftMask = a.getDrawable(                     R.styleable.MaterialCalendarView_mcv_leftArrowMask             );             if (leftMask == null) {                 leftMask = getResources().getDrawable(R.drawable.mcv_action_previous);             }             setLeftArrowMask(leftMask);             Drawable rightMask = a.getDrawable(                     R.styleable.MaterialCalendarView_mcv_rightArrowMask             );             if (rightMask == null) {                 rightMask = getResources().getDrawable(R.drawable.mcv_action_next);             }             setRightArrowMask(rightMask);         } catch (Exception e) {             e.printStackTrace();         } finally {             a.recycle();         }adapter.setTitleFormatter(DEFAULT_TITLE_FORMATTER);         setupChildren();
the method setupChild() goes after the method setRightArrowMask()
that's what makes the attribute don't work
the method setRightArrowMask() do what the attribute want,but then the method setupChildren() make the button back to original state.

I think this is a duplicate of #375

Fixed in v1.4.2


No token for id ...

During signup/validate step there is a link in the email that user needs to follow. It brings the user to the
.herokuapp.com/signup/validate/ web page.
The web page dispays the message:
No token for id .
I'm not sure if this is expected behavior. Looking at e.json it appears that the user should be redirected to the web page with the following messages:
"Your email has been validated and now you are logged in"
"You're being redirected in 5 seconds"
"You can now argue and vote on bills!"
Regards,
Taras.

@tarasdudar please update your codbase and try again; we just released 0.9.0 and the whole process is now updated (under the hood, of course). Please also check out the migration guide


Move pruner away from many binary dists

The first trial version of this plugin worked nicely, but even as a dev dep binary dists can be a bit much.
Right now this plugin only supports x64 Linux/Mac/Windows, and it's already ballooned to nearly 6MB.
Fortunately, it this operation can also be done very efficiently in bash, so do it in bash we shall! (Open to ideas on Windows compatibility...)
Branch (wip): https://github.com/arc-repos/arc-plugin-node-prune/tree/bash
/ht @tuananh

Released in 1.0.1!


Error in installing in laravel 9

Hi. this doesn't work  and has error when installing in laravel 9 because of conflicts illuminate/support.

support laravel 9 in v1.0,5