No Machine learning in add drop down list

Problem encountered on https://dotnet.microsoft.com/learn/machinelearning-ai/ml-dotnet-get-started-tutorial/create
Operating System: windows
There is no option to select machine learning in the add list. I have updated to the latest visual studio and I've installed the plugin in twice.

Please re-open with more details if the issue can be reproduced.


Add back C# distribtests for Grpc.Tools

The distribtests were removed as part of https://github.com/grpc/grpc/pull/29225, but the infrastructure for C# distribtests is still useful for end to end tests of the Grpc.Tools codegen package.

@tonydnewell


Support OpenMW-TES3MP

Project link: https://github.com/TES3MP/openmw-tes3mp
Project license:GPLv3
Does it work on 64-bit only Linux: YES
Is source code available?: YES
Is source code stored in Git?: YES
List of Steam AppIds of supported games:

https://steamdb.info/app/22320/

Additional information
Multiplayer version of OpenMW, it should be very similar to package.

Complete


SoftBody Dynamics

Where is the code of SoftBody Dynamics?

Do you mean the passive forces https://github.com/google-deepmind/mujoco/tree/main/plugin/elasticity ?

Do you mean the passive forces https://github.com/google-deepmind/mujoco/tree/main/plugin/elasticity ?

No, it’s the softbody dynamics like it in Bullet: https://github.com/bulletphysics/bullet3/tree/master/src/BulletSoftBody

Do you mean the length constraints enforcement or the contact resolution?

Soft bodies in MuJoCo are treated as bodies connected by constraints. The standard MuJoCo constraint solver is used https://github.com/google-deepmind/mujoco/blob/main/src/engine/engine_core_constraint.c#L665 and collisions are solved here https://github.com/google-deepmind/mujoco/blob/main/src/engine/engine_collision_driver.c#L1968

Thank you. But which functions are used for that?
I review the codes and can not find it.

Can you ask a more precise question? I don't understand what you are looking for.

Can you ask a more precise question? I don't understand what you are looking for.

For example, in constraints solve .c file, which functions are used for softbody dynamics. I can not find it so I ask you for help.

The soft bodies simply have standard mujoco bodies at the vertices, there is no special treatment to describe their dynamics. We add constraints at the edges connecting the vertices and then use the constraint solver in the same way as any other constraint is solved in mujoco. Soft bodies are not a separate concept for us, they are just something that puts together point masses at vertices.


Consider removing the argument to Loop::run

The argument passed to Loop::run adds an extra step to getting an event loop running. I also am not convinced that it provides the easiest way to manage shutting down a loop.
One question that needs to be asked when shutting down an event loop is what should happen with open sockets? There will still be the ability to have socket handles around but they won't be functional anymore since the event loop will go away.
One reason why I think getting rid of the argument to Loop::run is that there are going to be two primary shutdown cases:

Do nothing... run the event loop forever and have the process shutdown handle cleaning up.

Do a proper shutdown, the steps will be something like:

Wait for a shutdown event (ctrl-c, or something else)
Stop accepting new sockets
send a shutdown signal to all open sockets
Wait a grace period to allow open sockets to correctly shutdown
Hard shutdown any lingering connections
Shutdown the loop

Also, for the event loop proper, there are multiple shutdown steps that aren't necessarily well represented by taking a future:

Stop accepting new tasks (spawn fails) and shutdown after all existing sources close
Stop accepting new tasks and shut the loop down immediately

This could be handled by adding functions on LoopHandle:
fn shutdown(&self) -> Shutdown;

fn shutdown_now(&self) -> Shutdown;

where Shutdown is a future that resolves when the loop is successfully shutdown.

On crucial feature of run is that it allows executing a non-'static future, and is currently the only method of doing so for I/O futures. The wait function is the other escape hatch for that, but run was intended as the equivalent which runs the event loop while you're waiting.
I agree though that we should have a way to have "graceful shutdown" where it waits for all tasks on the event loop to finish executing before returning. Along those lines perhaps we could have two functions here? Naming may be difficult, but it seems like we may want two pieces of functionality.

Makes sense. I like the idea of two functions.

Some discussion in IRC today:

It seems reasonable to expose a Shutdown future which resolves when there are no more tasks spawned on an event loop
This would mean that there's no need for a separate function
Right now run is useful for a no-lifetime-bound future, but it's questionable how useful this is if Core gets a type parameter
We may be able to punt on this to 0.2. Any new form of "graceful shutdown" could perhaps be accompanied with a deprecation of run if necessary.

0.1 has shipped with this API, so I'm going to close in favor of https://github.com/tokio-rs/tokio-core/issues/33 for graceful shutdown.


GPI-anchor transamidase activity (GO:0003923) parentage

GPI-anchor transamidase activity (GO:0003923) is currently a direct child of 'hydrolase activity'.
For a couple of reasons, I think this could be moved 'down one level' to be a child of "peptidase activity (GO:0008233)":

The equivalent InterPro entry (IPR028361) is a child of "Peptidase C13, legumain (IPR001096)", which itself has the GO term "peptidase activity"
The catalytic subunit of the 'GPI-anchor transamidase' complex (PIGK) is described as being similar to cysteine proteases in the literature (e.g. PMID:19883648, PMID:24727937.)

So, in terms of the 'hydrolase' component of the transamidase reaction, it seems it could/should be a child of 'peptidase activity'.
What do you think?

but it isn't a peptide bond is it?

I think cleaving the signal peptide off the protein is?
GO:def: "Catalysis of the formation of the linkage between a protein and a glycosylphosphatidylinositol anchor. The reaction probably occurs by subjecting a peptide bond to nucleophilic attack by the amino group of ethanolamine-GPI, transferring the protein from a signal peptide to the GPI anchor." [ISBN:0471331309]

Wow OK, I had no idea that is what this was doing. I thought it was just attaching the GPI to the protein!

done

Hi Harold,
Sorry for not spotting this before, but I've just found evidence in the MEROPS database that means we can move GO:0003923 to a more specific level.  Can you change its parent from 'peptidase activity' to 'cysteine-type endopeptidase activity (GO:0004197)' based on the following?
https://www.ebi.ac.uk/merops/cgi-bin/pepsum?id=C13.005
https://www.ebi.ac.uk/merops/cgi-bin/famsum?family=C13
https://www.ebi.ac.uk/merops/cgi-bin/clansum?clan=CD
Steven

@hdrabkin - just checking you saw my last (belated) comment on this? (I don't seem able to actually re-open the ticket...)

@sjm41 - Saw this yesterday and changed today; done

Great, thanks Harold!


please add my DOD dataset

Army Corps. of Engineers - U.S. Department of Defense Sites - added on 8.28.20

Coverage remained the same at 98.913% when pulling d3640d895871758dd607cf5ba8dbd7ac8b2ce1b7 on lshpaner:patch-5 into 28d317955af4c9f027cfdb7361df0362b7fecd0e on tableau:master.


bump versions

Hello, @martin-helmich! Would like to make this happen

Thanks for the contribution; I'll happily accept the PR, but as mentioned in https://github.com/mittwald/kubernetes-loadwatcher/issues/6#issuecomment-1787923187 I feel the need to point out that this project is currently de-facto abandoned -- there isn't even a working CI (I did clone and build this locally to verify this PR), and no automated build process (at least, since Travis sunsetted their open source plan). 😞

Thanks for taking the time to point out the abandonment 🤝


[8.x] Fix DynamoDB locks with 0 seconds duration

I've added a default lock duration of 1 day for DynamoDB locks.
This makes the behavior consistent with DatabaseLock:
https://github.com/laravel/framework/blob/d425952e8cc664b01de8bd654336c1be8dcf7444/src/Illuminate/Cache/DatabaseLock.php#L92-L95
Fix #43280

Thanks @lukaszmtw


Condition shorthand issue

Before
<?php

class Message
{
    public function test()
    {
        $campaign_data = ['enabled' = false];
        $campaign->status = $campaign_data['enabled'] ? Campaign::STATUS_ACTIVE : Campaign::STATUS_PAUSED;

        return $campaign;
    }
}

After
<?php

class Test
{
    public function test()
    {
        $campaign_data = ['enabled' = false];
        $campaign->status = $campaign_data['enabled']?Campaign::STATUS_ACTIVE: Campaign::STATUS_PAUSED;

        return $campaign;
    }
}

Configs:
{
	"version": 4,
	"php_bin"<EMAIL_ADDRESS>	"format_on_save": false,
	"autocomplete": true,
	"autoimport": true,
	"disable_auto_align": true,
	"indent_with_space": true,
	"passes":
	[
		"StripExtraCommaInArray",
		"RemoveSemicolonAfterCurly",
		"NewLineBeforeReturn",
		"AddMissingParentheses",
		"ReindentSwitchBlocks",
		"OrderAndRemoveUseClauses",
		"DocBlockToComment",
		"PSR2EmptyFunction",
		"StripSpaceWithinControlStructures",
		"ShortArray",
		"AutoSemicolon",
		"OrderMethod", // 2023-06-05
		"OrganizeClass", // 2023-06-05
		"OrderMethodAndVisibility", // 2023-06-05
		"SortUseNameSpace", // 2023-06-05
		"SpaceBetweenMethods", // 2023-06-05
		"TrimSpaceBeforeSemicolon", // 2023-06-05
		"DoubleToSingleQuote"
	],
	"psr1": false,
	"psr2": true,
	"smart_linebreak_after_curly": true,
	"visibility_order": true,
	"yoda": false,
}

Thank you. The fix for #29 made this up. It's already fix in the next release

There you're, fixed. Thanks.

@driade I think it makes another bigger issue.
Before
<?php

class Test
{
    public function saveTest()
    {
        $value = [
            'test' => 1,
            'another_test' => 2
        ];
        foreach (array_keys($value) as $array_key) {
            $report->{$array_key} = $value[$array_key];
        }
        $report->save();
    }
}

After
<?php

class Test
{
    public function saveTest()
    {
        $value = [
            'test' => 1,
            'another_test' => 2
        ];
        foreach (array_keys($value) as $array_key) {
            $report->{$array_key}; = $value[$array_key];
        }
        $report->save();
    }
}

Another case
<?php

class Test
{
    public function saveTest()
    {
        $user = {};
        $tests = $api->getTests();
        foreach ($tests as $key => $test) {
            $db_test[] = [
                'test' => $test->{'Id'},
                'another_test' => $user->another_test,
                'user_id' => $user->user_id,
                'blah' => $user->blah,
                'name' => $test->{'Name'},
                'status' => strtoupper($test->{'Status'}),
                'budget' => $test->{'BudgetType'} === 'DailyBudgetStandard' ? $test->{'DailyBudget'} : 0,
                'updated_at' => now()
            ];
        }
    }
}

Becomes
<?php

class Test
{
    public function saveTest()
    {
        $user = {}
        $tests = $api->getTests();
        foreach ($tests as $key => $test) {
            $db_test[] = [
                'test' => $test->{'Id'};,
                'another_test' => $user->another_test,
                'user_id' => $user->user_id,
                'blah' => $user->blah,
                'name' => $test->{'Name'};,
                'status' => strtoupper($test->{'Status'};),
                'budget' => $test->{'BudgetType'}; === 'DailyBudgetStandard' ? $test->{'DailyBudget'}; : 0,
                'updated_at' => now()
            ];
        }
    }
}

Thank you very much @finalblast . Patch uploaded. The more cases we've the more confident we're.

Thanks for quick fix @driade
There is also 1 more issue I wanna to ask:
<?php

class Test
{
    public function array(array $rows)
    {
        if (count($rows) > 0) {
            foreach ($rows as $row) {
                // Save DB
            }
        }
    }
}

Becomes
<?php

class Test
{
    function [array $rows) {
        if (count($rows) > 0) {
            foreach ($rows as $row) {
                // Save DB
            }
        }
    }
}

Thank you.

Hi, thanks. May you open a separate issue for this case?
El vie, 9 jun 2023, 10:34, Nam (Nick) N. HUYNH @.***>
escribió:

Thanks for quick fix @driade https://github.com/driade
There is also 1 more issue I wanna to ask:
 0) {
            foreach ($rows as $row) {
                // Save DB
            }
        }
    }
}

Becomes

 0) {
            foreach ($rows as $row) {
                // Save DB
            }
        }
    }
}

Thank you.

—
Reply to this email directly, view it on GitHub
, or
unsubscribe

.
You are receiving this because you were mentioned.Message ID:
<EMAIL_ADDRESS>

Hello again @finalblast .
"array" in a reserved word https://www.php.net/manual/en/reserved.keywords.php so you can´t use it a a function name

@driade There is a repository that is required to implement the interface that the function name was an array. You can look here: https://github.com/SpartnerNL/Laravel-Excel/blob/3.1/src/Concerns/ToArray.php
So in the code, we cannot format the file.

I think it is because of ShortArray config?

Yes, it's because of the ShortArray, which you can disable of course.
Anyway I now understand you needs, and I think I can handle it. Give me a second.

There you're, patch uploaded!

Thanks @driade , it is almost perfect but still 3 issues:
<?php

class Test
{
    public function array($rows)
    {
        if (count($rows) > 0) {
            foreach ($rows as &$row) {
                // Save DB
            }
        }
    }
}

Becomes
<?php

class Test
{
    function array($rows) {
        if (count($rows) > 0) {
            foreach ($rows as  &$row) {
                // Save DB
            }
        }
    }
}

Issues:

It should keep public word at the beginning.
It should keep the { in the new line.
It shouldn't add 1 more space before &$row.

Thanks a lo, fixed

@driade Thank you. I think it is almost perfect, only 1 case left:
<?php

class Test
{
    public function array($rows)
    {
        if (!isset($groups[$test['category']])) {
            $children[$test['category']] = [];
            $groups[$test['category']] = [
                'id' => $test['category'],
                'type' => 'group',
                'label' => $test['category'],
                'children' => &$children[$test['category']]
            ];

            $options[] = $groups[$test['category']];
        }
    }
}

Becomes
<?php

class Test
{
    public function array($rows)
    {
        if (!isset($groups[$test['category']])) {
            $children[$test['category']] = [];
            $groups[$test['category']] = [
                'id' => $test['category'],
                'type' => 'group',
                'label' => $test['category'],
                'children' =>  &$children[$test['category']]
            ];

            $options[] = $groups[$test['category']];
        }
    }
}

You can notice an addition space in 'children' =>  &$children[$test['category']]

There you're, fixed, thanks!

Wonderful. Thank you very much, all good now.


Wrap FontFallbackMap::InvalidateAll assert in events-disallowed check.

For RUN-1774 (https://linear.app/replay/issue/RUN-1774/allow-fontfallbackmapinvalidateall-to-occur-when-events-disallowed)
Bucket issue RUN-1219

There are quite a few more that might need a guard 😶 (reference: crash report), e.g.:

"ContainerNode::DetachLayoutTree"
"SVGElement::DetachLayoutTree"
"Node::DetachLayoutTree"
"LayoutObject::WillBeDestroyed"
"LayoutObject::Remove"
"LayoutSVGContainer::RemoveChild"


Laravel 5.7

Been a little busy @crynobone will start getting a 5.7 compatible release together.

I tested lightly the master with 5.7 and there was no major problems. Does this pass tests on 5.7.
Also, worth of advice since you 7.3 seems very green right now (there are a couple of important issues, one which affected Facades).

Perhaps we could improve the travis script to enable easier Laravel version testing?
I have had great results rolling a script based on this one here: https://www.tjmiller.me/blog/verifying-laravel-version-compatibility/ .

I'm currently using this script (based on the link above) in a private repo, has saved me a lot of time when upgrading Laravel framework dependencies:
language: php

sudo: false

php:
  - 7.1
  - 7.2
  - 7.3
  - nightly

env:
  global:
  - COVERAGE=0
  matrix:
  - LARAVEL='5.5.*' TESTBENCH='3.5.*'
  - LARAVEL='5.6.*' TESTBENCH='3.6.*'
  - LARAVEL='5.7.*' TESTBENCH='3.7.*'

cache:
  directories:
    - "$HOME/.composer/cache"

matrix:
  fast_finish: true
  allow_failures:
  - php: nightly
  include:
  - php: 7.3
    env: COVERAGE=1 LARAVEL='5.7.*' TESTBENCH='3.7.*'
  exclude:
  - php: 7.3
    env: LARAVEL='5.7.*' TESTBENCH='3.7.*'

before_script:
  - composer config discard-changes true

before_install:
  - travis_retry composer self-update
  - travis_retry composer require "illuminate/support:${LARAVEL}" "illuminate/database:${LARAVEL}" "orchestra/testbench:${TESTBENCH}" --no-interaction --no-update

install:
  - travis_retry composer install --prefer-dist --no-interaction --no-suggest

script:
  - if [[ $COVERAGE = '0' ]]; then vendor/bin/phpunit; fi
  - if [[ $COVERAGE = '1' ]]; then vendor/bin/phpunit --coverage-text --coverage-clover=coverage.clover; fi

after_script:
  - if [[ $COVERAGE = '1' ]]; then php vendor/bin/ocular code-coverage:upload --format=php-clover coverage.clover; fi

Gist is here

https://github.com/orchestral/testbench-dusk/releases/tag/v3.7.0


[Bug]: Unable to use card_mod for Custom: Mushroom Title Card

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior
I am unable to use card_mod on the Custom: Mushroom Title Card.  Any changes added to the YAML result in no change to the card.
Expected Behavior
I expect card_mod customization to work for this card.  They work for other Mushroom cards.  The desired outcome to to make the card smaller since the margins are so large on the title.
Steps To Reproduce
This is YAML for the card:
type: custom:mushroom-title-card
title: ''
subtitle: Rooms
card_mod:
style: |
ha-card {
margin-top: -7px;
margin-bottom: -7px;
}
Context
No response
Environment
- Browser: Firefox
- HA Version: 2023.1.4
- Mushroom: 2.4.1

Anything else?
No response

·position: sticky· doesn't work too, exclusively on this card.
But I ran into this https://github.com/thomasloven/lovelace-card-mod/issues/227, where some do apply.
Looking for substitute in the meantime, any advice?

Am I correct in thinking the mushroom-title-card does not implement ha-card?
And that card_mod requires that container/class to be present?


Get list of Users with their roles and permissions.

I am new to laravel and i m using Zizaco package to check for users authorization. It is working well for checking roles and permissions. But i am having issues getting the list of users with their roles and permissions As this required for Admin user to assign roles and permissions to users.
Can anyone help me how to get the list of users with roles and permissions.
I

$roles = $user->roles()->get();

If you want to use eloquent you can do something like this. This is how I implement it with my app.
$users = User::with('roles.permissions')->get();

Each user will have a roles object and inside that roles object will have the permissions object
User.php
<?php namespace BFACP\Account;

use Illuminate\Support\Facades\Config;
use Zizaco\Confide\ConfideUser;
use Zizaco\Confide\ConfideUserInterface;
use Zizaco\Entrust\HasRole;

class User extends \Eloquent implements ConfideUserInterface
{
    use ConfideUser;
    use HasRole;

    /**
     * @return Illuminate\Database\Eloquent\Model
     */
    public function roles()
    {
        return $this->belongsToMany('BFACP\Account\Role', Config::get('entrust::assigned_roles_table'));
    }
}

Role.php
<?php namespace BFACP\Account;

use Illuminate\Support\Facades\Config;
use Zizaco\Entrust\EntrustRole;

class Role extends EntrustRole
{
    /**
     * @return Illuminate\Database\Eloquent\Model
     */
    public function permissions()
    {
        return $this->belongsToMany('BFACP\Account\Permission', Config::get('entrust::permission_role_table'));
    }
}

Permission.php
<?php namespace BFACP\Account;

use Zizaco\Entrust\EntrustPermission;

class Permission extends EntrustPermission {}

Duplicate of #816


pull request for e2e test at 11/23/2016 02:56:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Make indentation consistent, add indentation check to CI

Also run CI on push, not just on pull requests.
Includes changes from #3

Rebased.


RaspiOS Desktop 32bit error on ROM import from Smokemonster SMDBs

Got this error on RaspiOS Desktop 32bit build of retronas when trying to install "ROM import from Smokemonster SMDBs"
It seems python-is-python3 is some Ubuntu package, so it may not be there for RaspiOS.
TASK [ROM Import - Install build tools] *********************************************************
failed: [localhost] (item=['python3', 'python-is-python3', 'git']) => {"changed": false, "item": ["python3", "python-is-python3", "git"], "msg": "No package matching 'python-is-python3' is available"}
        to retry, use: --limit @/opt/retronas/ansible/install_romimport.retry

PLAY RECAP **************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=1

i'd never heard of that package before, that looks like a junk packageg we could arguably handle in a different manner. I will take a look, i believe i still have the raspios vm from last time.
looks like this package is a literal symlink and docs?
root@retroNAS:~# apt-file show  python-is-python3
python-is-python3: /usr/bin/python
python-is-python3: /usr/share/doc/python-is-python3/changelog.gz
python-is-python3: /usr/share/doc/python-is-python3/copyright
python-is-python3: /usr/share/man/man1/python.1.gz
root@retroNAS:~#

I have committed a change to remove that package, it doesn't do anything in this context.
We install python3 explicitly before this package is installed and we call python3 directly in the executing script for the feature, additionally the interpreter line of each py file in the project call python3 as well
the feature as expected appears to exec ok
------------------------
Analysing with EverDrive Pack SMDBs/Saturn Redump Supplement.txt
Outputting to /data/retronas/roms/sega/saturn
processing file:         0 / 0
coverage: 0/399 (0.0%)
------------------------
Press [Enter] to continue...

Tested this on RaspiOS 32bit and it all installed/ran ok after the change, so closing this one

Yup no problem, it also ran fine on mine, thanks.


Feature Request

Hi,
In my normal workflow i often schedule tasks with the Day Planner Syntax (09:00 - 10:00) to block out time slots to specify when to acually do the task if its a bigger task. Day Planner integrates with the Task plugin and picks up Tasks from any file in the entire vault as long as it has a scheduled date like ⏳ 2024-08-11.
It looks like this:

I like to use your plugin to just focus on a project and use workflows. However together with the extra info I include with most tasks like scheduled time and date it quickly becomes cluttered in the task column of your plugin.
Would it be possible to have an option in the settings to hide the scheduled time and date in the task column of the plugin? So it looks like this again:

The benefit would be, that I can have the best of both worlds: knowing what to do next through day planner and having a clean view on the tasks in a project and workflow context with your plugin.
Have a good day!

It should be quite straight forward. I'll if I can work on this in this week or next.

Hi Friedrich. I've added regexp pattern filter for task summary in 0.8.0.
For your usecase, the regex should be ⏳ \d{4}-\d{2}-\d{2}
You can configure the regex in settings.

After the configuration, you should see there's no more date in the task summary (but this requires you to edit any file and save it to trigger Obsidian database indexing).

Hope this helps!

Hi Odaimoko,
this works, thank you so much for your efford!


NPE on UnicastSubject's onNext() method

I found this bug while writing tests with my TCK.
If we request Stream or Subscription, and then call request(n) and then immediately cancel() without awaiting for the value to come, and we do this multiple times, we will get a NPE in Unicast Subject's onNext() function, because for some reason the subscriber inside is null.
An repro of this bug can be found in my fork here: https://github.com/xytosis/reactivesocket-java/tree/failing_tests/reactivesocket-tck-drivers
The failing client/server is inside a package called fail. Simply open in Intellij, run the server, and then run the client.

This bug seems to have multiple causes, and I am still in the process of trying to find them. One cause (which might be the reason behind the previous cause I found) occurs when we create a ReactiveSocket, requestStream with it, request some amount and then cancel without waiting for that item to come, and then immediately use the same instance of ReactiveSocket to create another requestStream or requestSubscription and then request and immediately cancel again without awaiting, we get this NPE.

I pushed another case of this bug to my branch. It seems like using the same reactivesocket instance is dangerous, because in this case, if we create a stream and then subscribe, and the immediately do it again and we send some requests, we run into the same NPE in UnicastSubject.

@xytosis in your repro I'm suspicious of these lines
    TestSubscriber<Payload> ts = new TestSubscriber<>(0L);
    Publisher<Payload> pub = r.requestStream(new PayloadImpl("a", "b"));
    pub.subscribe(ts);
    ts.request(1);
    ts.cancel();

TestSubscriber is a subscriber obviously, but you are using methods which come from it implementing Subscription also.  in this case, I don't think they are intended for you to call this way.

@yschimke It's true TestSubscriber implements Subscription as well as Subscriber, but it itself is not a subscription object. Instead, it stores the subscription object it receives from onSubscribe, and when calling request(n) on TestSubscriber calls request on the internal subscription object. It's just for convenience sake, and the interaction should be valid.

I'd suggest not implementing the Subscription interface, just having the methods with the same name.

The race condition is clearer in the success case.  Your "main" thread is racing a response on the netty thread "rxnetty-nio-eventloop-1-1".
815992954 subscribe (&set) io.reactivesocket.internal.Requester$StreamInputSubscriber@33c7e1bb main
1650560446 subscribe (&set) rx.internal.reactivestreams.SubscriberAdapter@1c5d70ed rxnetty-nio-eventloop-1-1
1650560446 onNext (&get) rx.internal.reactivestreams.SubscriberAdapter@1c5d70ed main
1650560446 onNext (&get) rx.internal.reactivestreams.SubscriberAdapter@1c5d70ed rxnetty-nio-eventloop-1-1
1650560446 onNext (&get) rx.internal.reactivestreams.SubscriberAdapter@1c5d70ed main

UnicastSubject which is created inside the Requester is documented as not thread safe.  So I'm unclear how a Subscription can be safely cancelled by an Application thread, not in response and inline with an event received on the network. It seems like what you are doing should be possible.

@yschimke I copied TestSubscriber from RxJava, so I'm not sure why implementing both interfaces is a "bad" thing.
On the race condition, I see what you mean. However, it seems like cancel would mostly be used by application threads and not inline networking threads, so perhaps the UnicastSubject should be made to be thread safe?

The next obvious question is whether copying a large class like TestObserver into here is good idea. That class is pretty actively maintained upstream.
But generally a Subscriber is given a subscription, I would have argued for asking TestSubscriber for its subscription if any.  But I defer to the maintainers in their wisdom.

@yschimke It wasn't a direct copy paste, I removed a lot of the unnecessary code and kept the core functionality. They hold the subscription inside TestSubscriber, and they also do it with an AtomicReference to make things thread safe, and hold all request(n) until the subscription has arrived. I'm not sure why they implemented subscription either, maybe it's some sort of obscure Java convention.

The pattern followed with TestSubscriber makes sense to me and I suggested Martin do it for the TCK. He needed similar behavior as TestSubscriber, but specialized for the TCK. Nothing about it should affect concurrency.

I'm suspicious of these lines

It does indeed look suspicious at first glance, however, TestSubscriber handles this race internally (not atomically based on my review of the code, but it won't cause an NPE). Also, the stacktrace shows it is not the issue with the TestSubscriber.request method.
It does seem like a bug that an NPE is thrown from inside UnicastSubject. The usage by Martin is all synchronous method invocation, I don't see him adding any extra concurrency.
Code here: https://github.com/xytosis/reactivesocket-java/blob/e4d7517f2b619a52ef6ad97a96412eaf37ec85ed/reactivesocket-tck-drivers/src/main/java/io/reactivesocket/tckdrivers/fail/ClientActor.java#L41
ReactiveSocket r = Client.createClient();
        TestSubscriber<Payload> t1 = new TestSubscriber<>(0L);
        Publisher<Payload> p1 = r.requestStream(new PayloadImpl("a", "b"));
        p1.subscribe(t1);
        TestSubscriber<Payload> t2 = new TestSubscriber<>(0L);
        Publisher<Payload> p2 = r.requestStream(new PayloadImpl("c", "d"));
        p2.subscribe(t2);
        t1.request(1);
        t2.request(2);
        t1.request(1);
        t2.request(1);
        t1.request(1);

That is just making two requestStream calls on a single ReactiveSocket instance. It should have two async/concurrent streams.
Thus, a single ReactiveSocket instance should be safe to use for multiple async requests.

@yschimke from a cursory glance at the code, Ben and I agree this is an issue.
I'd like to know what can be done to fix this, it seems like a more far reaching issue than the previous bug I've found. Making UnicastSubject thread safe would do, but that would lead to some inefficiency. Perhaps there could be some sort of AysncUnicastSubject that can be specified for a reactive socket to use, and this option can be set using some sort of flag in it's construction?

@xytosis @yschimke @benjchristensen
FYI: At Netflix we are working at a very large scale refactoring of the reactivesocket-java code which will discontinue this class as well, so unless this is blocking you from moving forward, I would suggest not to spend time on it.

@NiteshKant it's not particularly blocking, but it does mean that some tests that should pass are failing and may potentially block continued testing of the CPP impl depending on how fast the FB people move on that. But I think everything should be fine for now.
Will the new refactor change any of the external APIs? If so, let me know and I can update the TCK drivers accordingly.

Will the new refactor change any of the external APIs? If so, let me know and I can update the TCK drivers accordingly.

Not quiet sure as yet, but we will update the drivers since they are in the -java repo.


Introduce CHAINER_SETUP_IGNORE_CUPY to ignore cupy in setup.py

Chainer depends on a very specific version of CuPy.
Installation of CuPy takes too much time.
I propose introduction of environment variable to ignore CuPy.

It turned out --no-deps option can be used for this purpose:
pip install -e . --no-deps

Jenkins CI test succeeded without errors!


Add files via upload

Add files via upload plz
Institution/School Name
Asia University, Taiwan
Instiution/School Website
https://www.asia.edu.tw/
Email Users
Please place an x between the square brackets if yes

[X] Students
[ ] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
e.g<EMAIL_ADDRESS><EMAIL_ADDRESS>Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[X] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

Institution/School Name
National Taitung University
Instiution/School Website
https://www.nttu.edu.tw/
Email Users
Please place an x between the square brackets if yes

[X] Students
[ ] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
e.g<EMAIL_ADDRESS><EMAIL_ADDRESS>Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[X] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

@wade9058 I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host live.asis.edu.tw not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!

because you requested to add a non-existent domain to this repository:
Host live.asis.edu.tw not found: 3(NXDOMAIN)

Hi, Philipto
You use wrong host name to check my school mail server
The currect domain was live.asia.edu.tw.
Clould you check with currect domain again?
Thanks for you help

@wade9058 I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host live.asis.edu.tw not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!

@wade9058 I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host live.asis.edu.tw not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!

Hi, Philipto
You use wrong host name to check my school mail server
The currect domain was live.asia.edu.tw.
Clould you check with currect domain again?
Thanks for your help


E2E Clean enhancements

Make Clean return an error, so the caller can decide to error or fatal.
Delete serially. Watch for Not Found in parallel.
Error if trying to delete protected namespaces in deleteManagedNamespaces or deleteImplicitNamespaces.
Skip deleting objects that we already know are terminating. Just wait for them to be not found.
Avoid using kubectl where possible. Using client-go gives better error messages and allows us to use common functions to avoid common mistakes. It should also be slightly faster.
Always delete KubeVirt resources, even if the namespace is already deleted.
Remove legacy references to mono-repo Syncs
Add a simple kubevirt package to avoid needing to import the SDK
Move nt.MustKubectl logging into nt.KubectlContext to ensure all calls get logged.
Use exec.CommandContext to ensure commands are killed when the test is cancelled.
Update k8s.io/kube-aggregator to use the latest APIService object

/retest
Seemingly unrelated test error:
=== CONT  TestReconcilerFinalizer_Foreground
    watch.go:66: WatchObject(Deployment config-management-system/admission-webhook) watched for 12m0.000753461s
    new.go:392: ERROR: waiting for ConfigSync Deployments to become available: WatchObject(Deployment config-management-system/admission-webhook) timed out waiting for predicates: expected Deployment config-management-system/admission-webhook to have status "Current", but got "InProgress"

/lgtm
/approve


WDL: Add Cross Entropy Loss (Log Loss) Support

Currently only Shifu NN/GBDT supports cross entropy (log loss), should be set as standard in LR/NN/WDL/GBDT and using the same parameter 'Loss'.


Moving2 samples

Moving the $batch sample and the sample for Web Part on an app web page from OfficeDev to under the PnP umbrella.

Hi Ricky, thanks for this great contribution. I'm looking into this and have some questions, but will later on ping you.

Thanks Ricky also from my behalf.


Clean up

removed junk badges
added changelog to readme

Coverage remained the same at 96.101% when pulling 174811e2b34ddd9f7142030216dcad1c097be67b on clean-up into 2c21799bdedd4c1099e012c36eb9d74095f9b0d4 on master.


compute full dependency chain when invariant position is present

Related issue:
https://github.com/KhronosGroup/SPIRV-Cross/issues/2420

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.marcos balsa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

These changes enforce computing the whole dependency chain for all operations when invariant position decorator is present.

I pushed a more correct fix I think. Let me know if that resolves your issue.

Superseded, so closing.


Web site sample error

Gradle 4.10.2 on 64 bit Linux with JVM 1.8.0_151
Your website at https://guides.gradle.org/building-java-libraries/
Gives an example:  gradle init --type java-library --project-name jvm-library
that causes an error

Unknown command-line option '--project-name'.

I meet the same issure


[ALLUXIO-2901] Support change owner and group of a file or directory with one chown

https://alluxio.atlassian.net/browse/ALLUXIO-2901

On the client side, use simple regular expressions to parse user:group or user option string and extract corresponding information. Not fully compatible with UNIX/Linux chown syntax yet
On the server side, check whether user belongs to the group. If the check fails, throw a FailedPreconditionException. Note that this check is enforced on non-persistent files as well as persistent UFS files. For this reason, I need to modify the FileSystemAclIntegration test.

@ifcharming @apc999
Hi guys, I have submitted a pull request regarding ALLUXIO-2901. Could you take a look and provide some feedback? Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15927/
Test PASSed.

@aaudiber Hi Andrew, could you also take a look at this pull request I submitted? If you have any suggestion on anything, please do not hesitate to let me know.
Thanks

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15937/Build result: FAILURE[...truncated 3806 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/dependency-reduced-pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.6.0-SNAPSHOT/alluxio-core-client-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.6.0-SNAPSHOT/alluxio-core-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.6.0-SNAPSHOT/alluxio-tests-1.6.0-SNAPSHOT.pomchannel stopped
Test FAILed.

@riversand963 @mention me when you're ready for another round of review

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15938/Build result: FAILURE[...truncated 3811 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.6.0-SNAPSHOT/alluxio-core-client-fs-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.6.0-SNAPSHOT/alluxio-core-common-1.6.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-worker/1.6.0-SNAPSHOT/alluxio-core-server-worker-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/dependency-reduced-pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.6.0-SNAPSHOT/alluxio-underfs-glusterfs-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.6.0-SNAPSHOT/alluxio-core-client-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.6.0-SNAPSHOT/alluxio-examples-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.6.0-SNAPSHOT/alluxio-core-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-proxy/1.6.0-SNAPSHOT/alluxio-core-server-proxy-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.6.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.6.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.6.0-SNAPSHOT/alluxio-shell-1.6.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.6.0-SNAPSHOT/alluxio-tests-1.6.0-SNAPSHOT.pomchannel stopped
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15939/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.hadoop.FileSystemAclIntegrationTest.changeNonexistentOwnerAndGroupForLocal
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15942/
Test PASSed.

@ifcharming @aaudiber @apc999 Hi guys, could you review my latest change and provide some feedback? Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15948/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15955/
Test PASSed.

@ifcharming @aaudiber @apc999 More changes are here.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15991/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.hadoop.FileSystemAclIntegrationTest.changeNonexistentOwnerAndGroupForLocal
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15992/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.hadoop.FileSystemAclIntegrationTest.changeNonexistentOwnerAndGroupForLocal
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15994/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15996/
Test PASSed.

Thanks @ifcharming @aaudiber and @apc999 for the helpful feedback, help and comments!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16012/
Test PASSed.

LGTM. thanks for the improvement!


16-006-MC Add Main Assault Amphibious (Mine Countermeasure) Land Unit Symbol

Disapproved in CP 16-021-DS


onOpened callback not called from cold start

Package Versions:
"react": "~15.4.0-rc.4",
"react-native": "0.40.0",
"react-native-onesignal": "^3.0.4"
Current Behavior
I've followed the Usage Instructions to the letter.

Whenever I open a notification with the app in the background, the callbacks work just fine.
Whenever I open a notification and the app is not in the background, the callbacks don't get called at all.

Expected Behavior
Callbacks should be called regardless of whether the app is loaded from the background or cold-started.
Thoughts?
Edit: I just tried upgrading to 0.41.2 to be in sync with the example project. Problem persists.
Edit 2: This is my setup right now: https://gist.github.com/maxcodes/6d4657b4253e72e2be6fd391416f6cf3

Alright, I managed to get a workaround working. This is obviously a hack, so I'll leave this open to see what we can do about this.
From this comment I found the places where the native code (android and ios) emits the event. Then, I tried adding a delay before sending the event, as suggested here.
Android path: node_modules/react-native-onesignal/android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java
Leave the notifyNotificationOpened method like this:
    private void notifyNotificationOpened(Bundle bundle) {
        try {
            Handler handler = new Handler();
            JSONObject jsonObject = new JSONObject(bundle.getString("result"));
            handler.postDelayed(new Runnable() {
               @Override
               public void run() {
                 sendEvent("remoteNotificationOpened",  RNUtils.jsonToWritableMap(jsonObject));
               }
            }, 1000);
        } catch(Throwable t) {
            t.printStackTrace();
        }
    }

iOS path: node_modules/react-native-onesignal/ios/RCTOneSignal/RCTOneSignal.m
Change the handleRemoteNotificationOpened to this:
- (void)handleRemoteNotificationOpened:(NSString *)result {

    NSError *jsonError;
    NSData *objectData = [result dataUsingEncoding:NSUTF8StringEncoding];
    NSDictionary *json = [NSJSONSerialization JSONObjectWithData:objectData
                                                         options:NSJSONReadingMutableContainers
                                                           error:&jsonError];
    double delayInSeconds = 1.0;
    dispatch_time_t popTime = dispatch_time(DISPATCH_TIME_NOW, (int64_t)(delayInSeconds * NSEC_PER_SEC));
    dispatch_after(popTime, dispatch_get_main_queue(), ^(void){
        [curRCTBridge.eventDispatcher sendAppEventWithName:@"remoteNotificationOpened" body:json];
    });
}

You can try adjusting the delay to whatever works for you (the smaller the delay the better). This worked for me, I hope it helps someone else too 🥇

+1

I've created a branch with these changes, feel free to use it in the meantime.
https://github.com/maxcodes/react-native-onesignal/tree/delay
package.json

"react-native-onesignal": "git+https://github.com/maxcodes/react-native-onesignal.git#delay"

Thanks @maxcodes, this workaround works well enough for our needs 😄

Thanks @maxcodes, but for me only works for iOS, not for Android devices, any idea?

@jlopez90 try increasing the delay?

@maxcodes wow, that's awesome, saved my ass, thanks! Is there any plans add this fix to master?

Thanks @maxcodes increasing the delay worked!

@maxcodes Would it be possible to update your fork, so we can use it with RN0.47? No worries if you don't have time, just an open question.
@avishayil Are there any plans for fixing this on master? This would be really helpful, and would take the burden of @maxcodes from maintaining a fork. Pinging you since I saw you had most commits on this project, but feel free to pass through to other maintainers if that's more appropriate.

This workaround appears to be a little unstable: if the start of the application takes more time ? (old devices for example)
We can use:
Android:  onReactContextInitialized override from ReactInstanceEventListener to send the event when the app is started
iOS: didFinishLaunchingWithOptions function
But I'm not very confortable with native codes for now, I don't even know if it's possible to do it like this

There is no official way to fix it?

@GertjanReynaert I tried updating it a while back but I'm not too familiar with either Java or Obj-C, and I got stumped because upstream namespaced the names of the events.
@danieloprado something that we noticed recently is that this may be a symptom of your app taking too long to boot. For us, we were invoking the OneSignal listener in the componentDidMount of the main scene. However, the scene would wait for a very long query to get executed before mounting, so that's why the event is getting fired but not caught. See if you have a similiar situation and consider delaying the slow components to mount after the main scene has mounted.
TL;DR: It might be an implementation issue.
I hope that helps!

Just a heads up that I've posted a pretty lengthy comment at https://github.com/geektimecoil/react-native-onesignal/issues/332#issuecomment-341326624 discussing this problem.

I was having the same issue but add OneSignal.configure({}); before declaring the listener functions solved it for me.

We have solved this problem by changing the /node_modules/react-native-onesignal/index.js. The problem is that OneSignal received the message before we add the opened listener. What we do is that we try listen before we start OneSignal and cache the message before we add opened listener.

'use strict';

import { NativeModules, NativeAppEventEmitter, NetInfo, Platform } from 'react-native';
import invariant from 'invariant';

var DEVICE_NOTIF_RECEIVED_EVENT = 'OneSignal-remoteNotificationReceived';
var DEVICE_NOTIF_OPENED_EVENT = 'OneSignal-remoteNotificationOpened';
var DEVICE_NOTIF_REG_EVENT = 'OneSignal-remoteNotificationsRegistered';
var DEVICE_IDS_AVAILABLE = 'OneSignal-idsAvailable';

var openedHandler = false;
var lastOpenResult = false;
NativeAppEventEmitter.addListener(
	DEVICE_NOTIF_OPENED_EVENT,
	(result) => {
		console.log(result);
		if (openedHandler !==  false) {
			console.log("Got the result after the register");
			openedHandler(result);
		} else {
			console.log("Got the result before register");
			lastOpenResult = result;
		}
	}
);

var RNOneSignal = NativeModules.OneSignal;

const _notifHandlers = new Map();

function handleConnectionStateChange(isConnected) {
    if (!isConnected) return;

    OneSignal.configure();
    NetInfo.isConnected.removeEventListener('connectionChange', handleConnectionStateChange);
}

NetInfo.isConnected.fetch().then(isConnected => {
    if (isConnected) return OneSignal.configure();
    NetInfo.isConnected.addEventListener('connectionChange', handleConnectionStateChange);
}).catch((...args) => console.warn("Error: ", args));

export default class OneSignal {

    static addEventListener(type: any, handler: Function) {

        // Listen to events of notification received, opened, device registered and IDSAvailable.

        invariant(
            type === 'received' || type === 'opened' || type === 'registered' || type === 'ids',
            'OneSignal only supports `received`, `opened`, `registered`, and `ids` events'
        );

        var listener;

        if (type === 'received') {
            listener = NativeAppEventEmitter.addListener(
                DEVICE_NOTIF_RECEIVED_EVENT,
                (notification) => {
                    handler(notification);
                }
            );
        } else if (type === 'opened') {
			openedHandler = handler;
			if (lastOpenResult !== false) handler(lastOpenResult);
			console.log("Register the open event");
        } else if (type === 'registered') {
            listener = NativeAppEventEmitter.addListener(
                DEVICE_NOTIF_REG_EVENT,
                (notifData) => {
                    handler(notifData);
                }
            );
        } else if (type === 'ids') {
            listener = NativeAppEventEmitter.addListener(
                DEVICE_IDS_AVAILABLE,
                (ids) => {
                    handler(ids);
                }
            );
        }
        _notifHandlers.set(type, listener);

    }

    static removeEventListener(type: any, handler: Function) {
        invariant(
            type === 'received' || type === 'opened' || type === 'registered' || type === 'ids',
            'OneSignal only supports `received`, `opened`, `registered`, and `ids` events'
        );
        var listener = _notifHandlers.get(type);
        if (!listener) {
            return;
        }
        listener.remove();
        _notifHandlers.delete(type);
    }

    static registerForPushNotifications() {
        if (Platform.OS === 'ios') {
            RNOneSignal.registerForPushNotifications();
        } else {
            console.log("This function is not supported on Android");
        }
    }

    static promptForPushNotificationsWithUserResponse(callback: Function) {
        if (Platform.OS === 'ios') {
            invariant(
                typeof callback === 'function',
                'Must provide a valid callback'
            );
            RNOneSignal.promptForPushNotificationsWithUserResponse(callback);
        } else {
            console.log("This function is not supported on Android");
        }
    }

    static requestPermissions(permissions) {
        var requestedPermissions = {};
        if (Platform.OS === 'ios') {
            if (permissions) {
                requestedPermissions = {
                    alert: !!permissions.alert,
                    badge: !!permissions.badge,
                    sound: !!permissions.sound
                };
            } else {
                requestedPermissions = {
                    alert: true,
                    badge: true,
                    sound: true
                };
            }
            RNOneSignal.requestPermissions(requestedPermissions);
        } else {
            console.log("This function is not supported on Android");
        }
    }

    static configure() {
        RNOneSignal.configure();
    }

    static checkPermissions(callback: Function) {
        if (Platform.OS === 'ios') {
            invariant(
                typeof callback === 'function',
                'Must provide a valid callback'
            );
            RNOneSignal.checkPermissions(callback);
        } else {
            console.log("This function is not supported on Android");
        }
    }

    static getPermissionSubscriptionState(callback: Function) {
        invariant(
            typeof callback === 'function',
            'Must provide a valid callback'
        );
        RNOneSignal.getPermissionSubscriptionState(callback);
    }

    static sendTag(key, value) {
        RNOneSignal.sendTag(key, value);
    }

    static sendTags(tags) {
        RNOneSignal.sendTags(tags || {});
    }

    static getTags(next) {
        RNOneSignal.getTags(next);
    }

    static deleteTag(key) {
        RNOneSignal.deleteTag(key);
    }

    static enableVibrate(enable) {
        if (Platform.OS === 'android') {
            RNOneSignal.enableVibrate(enable);
        } else {
            console.log("This function is not supported on iOS");
        }
    }

    static enableSound(enable) {
        if (Platform.OS === 'android') {
            RNOneSignal.enableSound(enable);
        } else {
            console.log("This function is not supported on iOS");
        }
    }

    static setSubscription(enable) {
        RNOneSignal.setSubscription(enable);
    }

    static promptLocation() {
        //Supported in both iOS & Android
        RNOneSignal.promptLocation();
    }

    //Android only: Set Display option of the notifications. displayOption is of type OSInFocusDisplayOption
    // 0 -> None, 1 -> InAppAlert, 2 -> Notification
    static inFocusDisplaying(displayOption) {
        if (Platform.OS === 'android') {
            RNOneSignal.inFocusDisplaying(displayOption);
        }
    }

    static postNotification(contents, data, player_id, otherParameters) {
        if (Platform.OS === 'android') {
            RNOneSignal.postNotification(JSON.stringify(contents), JSON.stringify(data), player_id, JSON.stringify(otherParameters));
        } else {
            RNOneSignal.postNotification(contents, data, player_id, otherParameters);
        }
    }

    static clearOneSignalNotifications() {
        if (Platform.OS === 'android') {
            RNOneSignal.clearOneSignalNotifications();
        } else {
            console.log("This function is not supported on iOS");
        }
    }

    static cancelNotification(id) {
        if (Platform.OS === 'android') {
            RNOneSignal.cancelNotification(id);
        } else {
            console.log("This function is not supported on iOS");
        }
    }

    //Sends MD5 and SHA1 hashes of the user's email address (https://documentation.onesignal.com/docs/ios-sdk-api#section-synchashedemail)
    static syncHashedEmail(email) {
        RNOneSignal.syncHashedEmail(email);
    }

    static setLogLevel(nsLogLevel, visualLogLevel) {
        RNOneSignal.setLogLevel(nsLogLevel, visualLogLevel);
    }

}


Firefox throw exception when not in quirks mode

We've had this happen on one of our pages and not on others, so there may be something else I'm missing, but line 14 of  /vendor/assets/javascripts/rails.validations.js uses global window named items which is not supported by Firefox except in quirks mode, so that it fails with "settings is undefined".
Changing this to use getElementById seems to fix the problem.
There is a lot of argument about the 'right' way to do this. The original approach should be supported in IE and
HTML5-compatible browsers except that as of 5/13/2011 Gecko does not plan to support this except in quirks mode.

As a follow-up using getElementById[...] instead of window[...] does not work in our testing. I'm closing this because I think the problem is not this gem.


How do we update slices with DJL NDArray?

In python we have the following:
y[:, 0] = x[:, 0] - x[:, 2] / 2
In Java how can I do this? My attempt below gives error:
y.get(":,0") = x.get(":,0").sub(x.get(":,2").div(2));
I think we are supposed to do it with set() using NDIndex.sliceAxis() but it doesnt support :,0 type slice.

I came up with the following, I don't know if this is the optimal way:
y.set(new NDIndex(":,0"), x.get(":,0").sub(x.get(":,2").div(2)));

Yes, in DJL, setting needs to be explicitly called. We haven't overloaded the = operation on NDArray to be setting yet, for the similar reason that we haven't overloaded +-*/ to be add, sub, mul, div etc.

Thank you! If the way I mentioned is the optimal way for now, please feel free to close this ticket.

That we didn't implement operator overloading is mainly due to java language restriction.


Filter by country showing countries that dont have accepted communities

/communities/count?groupBy=country

option to pass the status is already implemented, for that use status=valid:
{{api_base_url}}/api/v2/communities/count?groupBy=country&status=valid


Update gRPC probes status to stable

This MR changes docs to reflect the current status of gRPC probes.
Related to kubernetes/enhancements#2727

/retest


MC rate ctrl sync

@priseborough I continued your PR here.

It seems like the runtime issues are due to changes in the sensors app alone. If I revert them things stabilise. So we can dig in there deeper.

@priseborough This runs now for me. Needs to get more testing.

@bkueng Fixed more compile errors. Still need to validate this end-to-end.

I did some refactoring into a class to cleanly separate the API. In addition, sensor_correction is now only published if:

voting index changes
temperature changes by 1 or more degree (if that's too slow we can adjust that)

Instead of at the rate of the gyro.
Still left todo:

more testing & validation
better error handling & reporting
my changes assume there's a match between driver class id and uorb pub instance, but that's not necessarily the case. I'll need to look into that.

@bkueng I don't see where the mismatch between class ID and uorb pub instance is. The voted ID you are using is the uORB ID already and that's correctly used.

Looking at MPU6000:
The driver class ID comes from https://github.com/PX4/Firmware/blob/master/src/drivers/mpu6000/mpu6000.cpp#L660
And the uorb pub instance is created some lines further down: https://github.com/PX4/Firmware/blob/master/src/drivers/mpu6000/mpu6000.cpp#L669
These should typically match. However:

there's a race condition between these 2 events.
also I'm not quite sure what happens on driver restart: are the 2 ID's released and it gets the same one (as it should), or does it get a new ID?

The assumption in my code is here: https://github.com/PX4/Firmware/pull/6363/commits/13347ffa2588f4a926011db93d43d17ce377a96c#diff-a4442851925fd43c16a781c4b830eb87R165
One way would be to ask the driver for its uorb instance via ioctl(), but requires adding it to all drivers.

Updates:

sensors status now prints whether temp compensation is enabled & correctly configured
added error reporting
stack size adjustments were necessary
fixed a bug in mc_att_control
removed the requirement that the driver class ID matches the uorb instance

I've tested this on FMUv2 and it behaves now. Thanks!

This has been flight tested on a Pixracer flying a 250 size quad. Log here:http://review.px4.io/plot_app?log=8123b7e5-ae28-4b06-bff1-47131df73cd2

I made a really short test with this pr today with unchanged tuning in manual flight mode outside and didn't note any difference in flying.

Do not delete the branch yet.

@bkueng Rebased and merged - please continue.

Do we have any quantitative measures of latency reduction with this change?

@priseborough This is my estimate of rate controller latency for your log:

@kd0aij What does that latency value include? It is much larger than the average frame time of 4msec.
A good test will be how much the P gain can be increased before the rate loop starts to 'ring' before and after the scheduling change.

@priseborough My estimate of "rate controller latency" is computed by first assuming that the impulse response is a damped sinusoid and solving for the 3 parameters (h(t) = p3 exp(-p1 t) sin(p2 t)) using a least squares technique with the rate control input as stimulus and the rate gyro signal as output.
I then convolve this impulse response with the control signal to get the roll/pitchModel signal plotted above, and to compute the quality of fit by comparing to the actual roll/pitch gyro signals.
The "latency" is computed, by again using a least squares technique to find the delay which best matches the control signal to the model (delayedRoll/Pitch in the plot).
So this latency is a measure of the speed of response of the closed loop system. It does rely on accurate timestamping of the logged data, and I resample the data to a uniform 100Hz rate prior to processing since the logging intervals are not uniform.
I have recently been working on mods to the firmware to log all MPU6000 gyro/accel sample data at 1KHz to avoid the (apparent) jitter introduced by the current timestamping method and improve the quality of spectral analysis.

The way that a 1 degree change in temperature is being used as a basis for publishing the sensor corrections is not working as intended because each sensor is measuring a different temperature so it is being published all the time. We need to monitor the temperature separately for each sensor instance. I will push a patch to fix this.


Only space collaborator should be able to create a work item

Currently we allow any logged-in user to create a work item in any space.
@qodfathr wants to limit it to the space collaborators only.
Related to https://github.com/almighty/almighty-core/issues/1299

Why are we doing this @qodfathr ? The github model of allowing anyone to go and file an issue was nice.

This have to be incorrect. I can see it as an option to enable for other projects but for our openshift.io spaces we are looking to let anyone logged into open issues. Otherwise we cannot use openshift.io for our issue tracking with the broader world.

It needs to be this way for now. We need some important controls in place before we can have a model for non-contributors to add items. The GitHub model does not have to deal with things like Epics, Scenarios, bugs vs features, etc. Plus there is the whole issue of managing rank, priorities, approving items, etc.

lets then block non-collaborators from managing ranks etc. which is already what is there imo.

What if we allow just issues to be created by non collaborators for now?

https://github.com/almighty/almighty-core/pull/1359 closes work item creation for non-collaborators in regular user spaces but allows non-collaborators to create work items in the spaces which belong to "openshiftio" user. This is a temporal workaround until we get some permission model designed and implemented.
@qodfathr does it work for you?


added gitlogo in footer

This PR adds a GitHub logo to the project's frontend to enhance the visual branding and improve user interface aesthetics.

@ruthwikchikoti  Could you please address the issue on your end? There is a problem occurring when running this code. Thank you.


CIV-8939 - Claimant Intent: Submit Function - Change state to ALL_FINAL_ORDERS_ISSUED

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-8939
Change description
new flow 'Applicant accept repayment plan(Full/Part admit)' added
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

plz add camunda flow diagram here


feat: add support for functions

Description
I was missing appsync_function resource in the module. I tried to implement it in the same fashion as are other resources.
Motivation and Context
Missed the feature.
How Has This Been Tested?

[x] I have tested and validated these changes using the complete example

Hi
Thanks for the review.

The example I created is a bit lame, but it should work. I tested it without any other terraform resources.
Supported arguments added.

Thank you, Martin!
v0.9.0 has been just released.


Visualize service map for individual trace/transaction

Is your feature request related to a problem? Please describe.
Current trace analytics does not have an option to drill down the graph for component/service, for example clicking on a node in trace analytics graph should open another graph for the specific service.
Describe the solution you'd like
Trace map for individual service should be shown while user click on any service in the graph
Describe alternatives you've considered
AWS Xray has the feature and would like to get it built on OpenSearch trace analytics as well.

TODO filtering by service name should include other services that are used by spans of selected service

it will work like this:
filtering by service will work the same was as in service details view (non-matched service nodes will be transparent)
I'll sent a PR for this to get in 1.3 release. Also feel free to update this issue if you are expecting something different, thanks


[ARC-81] Partkey integrity hash

Given that participation keys are not portable between networks for the majority of users, should be include the network (e.g. via genesis hash) in the integrity hash? This would prevent accidents where a keyreg was meant for testnet for ended up on mainnet.

The ARC-78 URL strives to be as minimal as possible and does not include GH or network-id .
Adding network id to ARC-81 might make it incompatible with ARC-78.

Adding network id to ARC-81 might make it incompatible with ARC-78.

Not sure how it makes them incompatible. If ARC78 QR doesn't encode network/GH, that is all the more reason to include it in the integrity hash. The information (GH) would be independently known everywhere where you would want to generate an integrity hash - node, wallets, explorers.

The ARC-78 URL strives to be as minimal as possible and does not include GH or network-id .

Arguably ARC78 should include network as well - in the TUI we currently have to warn users to make sure they are on the correct network when going through the QR. If we include the network in the encoded URL, the wallet can detect a mismatch and warn or refuse appropriately. But even if we don't, not sure what would be stopping the wallet from including its current network GH in the integrity hash calculation

Second thread: Should this cover keyreg offline txns as well as @urtho suggested offline?
If so, what do you think about same payload structure, including the keys & rounds as all-zero?


Join operation does not allow merging of different groups

Currently, the Join operation (with an Element Matcher and Merger) behaves like a schema aggregator. It merges two elements of the same group using the schema and given group by properties. However a typical SQL Join would be able to join rows of different tables.
The best way to change this would be to change how the matcher works, and make the Merger optional. The matcher should take two functions to apply to each of the iterables on the left and output of the right, then compare the results to determine what is a match.
If the matcher returned a Map Tuple containing the key, the left side matches and right side matches, then we could perform a Map operation afterwards to select the relevant properties/elements and manipulate the output.
This could replace the Merger to reduce complexity of the Join operation.
Furthermore, to avoid a performance hit, any Joins which require iterating over both the left and right hand side (Full and Full Outer) will be removed.

Merged into develop.

Migration Steps
In version 1.8.1 the Join operation (first released in 1.8.0) was changed. The new operation outputs tuples keyed with 'LEFT' and 'RIGHT'. You can run a map operation over the output to extract a given side and run functions over it. JoinFunctions which required iterating over both sides multiple times were removed for performance reasons.


cant work

I have changed the code to suite my arduino in PC to run the code to ESP32 ,and my awtrix can display WIFI when give a 5V voltage, so how to do next? no infor then

Sorry, this was a pet project I did trying to port ESP32 over, i never finished so it won't work now.

any other things need to do? How to  do next? and when can u finished that? hope ur feedback, thanks!


how to generate other language ?

i love this tool. it's very nice!
how to generate commit message in other language?

What languages are you interested in trying out? We may be able to do this with a custom prompt


CNV-QIM is selected as the steganographic method.

Can the author share the source code of CNV-QIM as well, or tell me how to get the source code of CNV-QIM
Thanks.

Sure. We don't make this part of code public in this repo because CNV-QIM is not within the scope of this paper. Nevertheless, we are happy to share the code we used. I have sent you the code via email.


train with job ext

#91  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Fix a few minor warnings

Bug/issue #, if applicable:
Summary
This fixes a few minor warnings in the code:

Two deprecation warnings in tests (after sha512Checksum was renamed to checksum)
A warning about the inferred type of an empty array literal
Two warnings about comparing an non-optional value to nil

Dependencies
n/a
Testing
n/a
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ ] Added tests
[x] Ran the ./bin/test script and it succeeded
[ ] Updated documentation if necessary

@swift-ci please test

@swift-ci please test


Update install-and-configure-rbs-with-a-3rd-party-provider.md

Formatting and updated links.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Move ganache into its own WebWorker

Simulating a blockchain is a particularly CPU intensive task. If ganache runs on the main thread, it'll lock up the UI and cause other jank.
The WebWorker API is how you spawn background tasks in the browser.

You can also wrap it in an async function, which won't lock up the UI at the cost of remaining single thread.

Unless ganache is going something fancy itself (and it may very well be), wrapping a CPU bound task in an async function won't actually improve responsiveness unless you also add yield points (like setTimeout(0, ...)).
For example, this'll lock up your tab, even though it's async:
<!doctype html>
<html>
<head>
<script>async function foo() { while (true); }</script>
</head>
<body>
<input oninput="foo()">
</body>
</html>


[CMT-399] Tweet - Atlantis World Grant

https://github.com/yearn/yearn-comms/blob/portuguese/Tweets/_posts/Yearn grant Atlantis World/2021-08-31-Yearn-grant-Atlantis-World.md
File translated and published


Update JUnit to latest version

I updated the pom to use Junit 5
This new version has a readable api and some useful things, such as @DisplayName, to declare more friendly names for test cases.
All old tests are ok with the new version of Junit, I had to change the package of some annotations, but everything works.
issuecomment

@mauricioaniche the codecov failure not have relashioship with what I made, those file above are source code.

@maykon-oliveira Maven needs the surefire plugin to run JUnit 5. Add this to the plugins section of the pom.xml and let's see if that fixes it:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.1</version>
</plugin>

ah @mauricioaniche, finally works! Tks


External lua libraries

Hello,
is there a way to embed other external lua libraries into inmation or some kind of a package manager?
Actually we tried to establish an ODBC connection to a Honeywell DCS using the lua-sql library but failed because the needed connection string syntax is not supported by this library.
https://github.com/keplerproject/luasql/issues/96
There is a good chance for getting a connection using ADO object. However for this we would need LuaCom library http://webserver2.tecgraf.puc-rio.br/~rcerq/luacom/.
Is there a way to get this library in?
Regards
ht

Yes, you can store pure Lua libraries into inmation on e.g. folder like objects.
There is an ODBC library available on inmation-ESI. Do you have access to this repository? Otherwise please create a ticket on our support page so that we can help you.


Include TypeScript typings the right way

Please follow the TypeScript guidelines  for publishing typings with your npm package. This library doesn't comply to either:

Bundling with your npm package, or

Your are missing the "types" attribute in package.json

Publishing to the @types organization on npm.

This is in my opinion the preferred approach. Every major library has its typings published this way.

This issue can be partially solved by merging the following pull request: #79

Now that #79 is merged, this issue can now be closed.


Refactor & Bug fix

Yes, I'm using react-navigation, and the screen contains SortableListView will be animate translateY to get to front( a custom Modal not using the provided Modal by React Native), then the measure will be wrong, I've read the doc, it says that measure will give the wrong value when animating, the right way it to get the value via onLayout or measure after animation, so I chose the second solution, measure the layout afterInteraction

@chetstone I'm sure this change is safe, I've test it in my own app. I've been using this components for a year, it's doing really a good job, but I find that bug after I switch from Modal to a custom View, so I try to resolve this, the main changes in this PR are:

codemod(es5 -> es6)
eslint --fix
prettier
bug fix for animating view
clean up

The main reason for me to change the code style is that ES5 is really out of fashion in React Native development nowadays, gives several warnings, and the old code style is not friend enough for other contributors, there a still some unless code there, but I think this is the first step forward, I'll continue to polish this code base

@nihgwu Thanks very much for your contribution and your offer to continue polishing. That's great!. And thanks for educating us about some  of these tools. prettier looks like a great tool for new code and possibly for restyling old code if the project has a robust regression test suite. Unfortunately we don't have that --- we just have one minimal jest test and the example app that has to be run manually. (I assume you have at least tested with those).
I agree that it's good to keep up to date, but at a minimum, I will want to read the code carefully and try it with my app, and I won't have time to do that for a few weeks. In the meantime, the following will help:

Perhaps some other people could try this PR in their code and report here whether or not they found any regressions.
Any possibility you could split this into 2 PR's? One with just the bug fix and another with all the styling changes?

Finally, in a quick glance at the diffs, I already discovered one problem. Since ES6 doesn't support mixins, you have removed react-timer-mixin. How do you clean up timers when the component unmounts?

There is no setTimeout any more, I will clean the dependencies
On 16 May 2017, at 02:01, Chester Wood <notifications<EMAIL_ADDRESS>wrote:
@nihgwuhttps://github.com/nihgwu Thanks very much for your contribution and your offer to continue polishing. That's great!. And thanks for educating us about some of these tools. prettier looks like a great tool for new code and possibly for restyling old code if the project has a robust regression test suite. Unfortunately we don't have that --- we just have one minimal jest test and the example app that has to be run manually. (I assume you have at least tested with those).
I agree that it's good to keep up to date, but at a minimum, I will want to read the code carefully and try it with my app, and I won't have time to do that for a few weeks. In the meantime, the following will help:

Perhaps some other people could try this PR in their code and report here whether or not they found any regressions.
Any possibility you could split this into 2 PR's? One with just the bug fix and another with all the styling changes?

Finally, in a quick glance at the diffs, I already discovered one problem. Since ES6 doesn't support mixins, you have removed react-timer-mixin. How do you clean up timers when the component unmounts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/deanmcpherson/react-native-sortable-listview/pull/80#issuecomment-301555025, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACeY8hmh2XZlhefsWJhvObwKlDLgGr38ks5r6JLigaJpZM4NaRvR.

@chetstone mind to step forward to merge this? I didn't change any original logic code

I've been using this version in my app for weeks and it works as before

@nihgwu I'll try to get time to look at this soon.

@nihgwu I took a look at the changes, and the cleanup/prettier/es6 changes look straightforward and a good idea. Some of your other changes I don't quite understand, but the main problem is that the tests included in the repository don't work for me.
npm run test fails with
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of `MyComponent`.

And the test app in the Sortable directory fails the same way. Evidently the way you've exported the component only works with the es6 import method, because if I change
let SortableListView = require('react-native-sortable-listview');

to
import SortableListView from 'react-native-sortable-listview'

that problem goes away. Please fix the export so the component is backwards compatible -- it should work with either import or require.
Then once that problem is out of the way, the Sortable app still has major problems. When you pick up a row to move it, the 'shadow' jumps to the top of the list and does not track the slot it is to be dropped in. And it's impossible to move it where you want it.
Please take a look.  Thanks.

@chetstone test passes now and the slot issue has been solved, sorry for not test it before, i'm going to upgrade the dev deps too and then I think is ready for merge

@chetstone I upgrade the test snap just because the ListView changes after upgrade react-native, the test snap keeps the same with the former version

pretty sure it works great with all the test data

Looks good. The refactoring you've done improves the structure and readability of the code. Thanks!
It seems to work the same as before in my app and in the Sortable example. I was hoping it might fix some other problems, like #64, but no such luck. Ah well.
There are a couple of minor issues I have questions about:

Regarding your removal of react-timer-mixin, you've removed the call to setTimeout(), but requestAnimationFrame() is still being used. Don't you think the supplied callback could get called after the component is unmounted?

There are a couple of warnings now when the jest tests are run:

    Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)

  console.error node_modules/react-native/Libraries/Core/ExceptionsManager.js:71
    Warning: React.createClass is no longer supported. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. (https://fb.me/migrating-from-react-create-class)

The React.createClass warning could probably be fixed simply by upgrading example.js (the one in the top level) to es6 but I'm not sure where the PropTypes come in. Maybe react-test-renderer needs to be upgraded?

I notice you've reverted your change of measureWrapper to use runafterinteractions instead of onLayout. I thought that was the fix you made for the problem in your app. Does your app still work with this code? :-)

quick answers:

I didn't look into this part, but I believe it's safe to just leave it there, I always get warnings about changing unmounted components, not all the warnings needs to be handled, but I will try to fix it
I didn't changed the code and deps for example, I think the PropTypes warning is irrelevant with this PR, so I think we can just ignore it, but I guess the warning is from react-native it self as there are React.PropTypes in the source code with the version we are using
yes, it still works, I use runAfterInteraction just because I want to follow your method the measure the layout params, but I find that some of the params are not needed and all the needed params could be got via onLayout, and I've explained that measuring layout right in onLayout is the best place, so I did that change

So I think this PR is ready for merging right? for #64 , I didn't notice it before and it's still open, so I think is irrelevant to this PR, I'll take a look later

I didn't look into this part, but I believe it's safe to just leave it there, I always get warnings about changing unmounted components, not all the warnings needs to be handled, but I will try to fix it

Thinking more about it, it doesn't seem like it could harm anything because when the component is remounted it will reinitialize and overwrite any state that might have changed.
Thanks a lot for your perserverance and patience with my delays.

can you publish this on npm please?

@antoinerousseau
Done

@chetstone can you add me as a collaborator? I've come with some bug fixes, like #64 and other strange behaviors I've encountered with.
I'm think of addressing them in one PR or splitting them into several PRs

That will be great to have you as a collaborator, but the repository owner, @deanmcpherson, has to do the addition.
If he doesn't respond, I've been freed up of some other projects so hopefully I can respond more quickly if you want to submit PRs. I would prefer smaller ones.

@chetstone kindly ping to review my PRs 😄

Het @chetstone @nihgwu, I've added @nihgwu as a collaborator 😄

@deanmcpherson thanks Dean

You're welcome! Thanks for contributing 👍

I’m taking a look now.
On Aug 7, 2017, 21:07 -0600, Neo<EMAIL_ADDRESS>wrote:

@chetstone kindly ping to review my PRs 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Parse Mina proof to JSON

Explain your changes:
*
Explain how you tested your changes:
*
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

Hey @gabrielbosio, it seems like this contains some unrelated changes. Could you update the PR with just the set of changes you intended?

Done, thanks for noticing!


naps2: 7.3.0 -> 7.4.0

Description of changes

https://github.com/cyanfish/naps2/blob/master/CHANGELOG.md
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The aarch64-linux build fails on CI. Could you please investigate this a bit? Possibly, add mark it as broken there, quoting the error you saw on ofborg.

@doronbehar , indeed it seems to fail. It's caused by a dependency issue that I cannot seem to fix because I don't have a proper aarch64 device yet.
/build/tmp.32zhrRzUgj/.nuget/packages/grpc.tools/2.59.0/build/_protobuf/Google.Protobuf.Tools.targets(291,5): error MSB6006: "/build/tmp.32zhrRzUgj/.nuget/packages/grpc.tools/2.59.0/tools/linux_arm64/protoc" exited with code 139. [/build/source/NAPS2.Sdk/NAPS2.Sdk.csproj::TargetFramework=net6]
/nix/store/0clqpvcz25np1bx1jigya7ywapni9pxp-dotnet-sdk-8.0.203/sdk/8.0.203/Microsoft.Common.CurrentVersion.targets(2110,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/build/source/NAPS2.Lib/NAPS2.Lib.csproj::TargetFramework=net8]
Build FAILED.

I've marked it as broken for the mean time.