class-format enhancement: an option to add my own regexes

I see that the rule is configurable, but I can't make it fit my needs. My needs are:

.PascalCase for components (this works)
.camelCase for elements (can't do this)
-camelCase for variants (almost the default)

Imho it would be reasonable to just accept regexes in the config, like this:
"rscss/class-format": {
    component: "[A-Z][a-zA-Z0-9]+",
    element - "[a-z][a-zA-Z0-9]+",
    helper - "_[a-z][a-zA-Z0-9]+",
    variant - "_[a-z][a-zA-Z0-9]+",
}

And of course the "RSCSS standard" conventions should be the default.
For now I'll stick to the built-in selector-class-pattern rule.

This works:
Component: "pascal-case"
As well as:
Component: /myregexp/
On Tue, Sep 20, 2016, 9:51 PM Mikołaj D<EMAIL_ADDRESS>wrote:

I see that the rule is configurable, but I can't make it fit my needs. My
needs are:

.PascalCase for components (this works)
.camelCase for elements (can't do this)
-camelCase for variants (almost the default)

Imho it would be reasonable to just accept regexes in the config, like
this:
"rscss/class-format": {
component: "[A-Z][a-zA-Z0-9]+",
element - "[a-z][a-zA-Z0-9]+",
helper - "[a-z][a-zA-Z0-9]+",
variant - "[a-z][a-zA-Z0-9]+",
}
And of course the "RSCSS standard" conventions should be the default.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rstacruz/stylelint-rscss/issues/4, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikSibj5-JdV_-Z9dfuav9e6Gom8dwks5qr9lwgaJpZM4KBmKj
.

And the config format is in stylelint's strange two-item array convention
like this:
"rscss/class-format": [true, { component: "pascal-case" }]
On Tue, Sep 20, 2016, 9:53 PM Rico Notifications <
<EMAIL_ADDRESS>wrote:

This works:
Component: "pascal-case"
As well as:
Component: /myregexp/
On Tue, Sep 20, 2016, 9:51 PM Mikołaj D<EMAIL_ADDRESS>wrote:

I see that the rule is configurable, but I can't make it fit my needs. My
needs are:

.PascalCase for components (this works)
.camelCase for elements (can't do this)
-camelCase for variants (almost the default)

Imho it would be reasonable to just accept regexes in the config, like
this:
"rscss/class-format": {
component: "[A-Z][a-zA-Z0-9]+",
element - "[a-z][a-zA-Z0-9]+",
helper - "[a-z][a-zA-Z0-9]+",
variant - "[a-z][a-zA-Z0-9]+",
}
And of course the "RSCSS standard" conventions should be the default.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rstacruz/stylelint-rscss/issues/4, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAEikSibj5-JdV_-Z9dfuav9e6Gom8dwks5qr9lwgaJpZM4KBmKj
.

Makes sense. 👍
Then the rule just needs better documentation :)

I added an example on how to do it:
https://github.com/rstacruz/stylelint-rscss/blob/master/docs/rules.md
Hope that helps!

Thanks! 👍

So I tried this in my config:
    "rscss/class-format": [true, {
        "component": /^[A-Z][A-Za-z0-9]+$/,
        "element": /^[a-z][A-Za-z0-9]+$/,
        "variant": /^-[a-z][A-Za-z0-9]+$/,
    }]

and got this:
YAMLException: missed comma between flow collection entries in "......./.stylelintrc" at line 109, column 28:
                "component": /^[A-Z][A-Za-z0-9]+$/,

And when I try with strings like this:
    "rscss/class-format": [true, {
        "component": "^[A-Z][A-Za-z0-9]+$",
        "element": "^[a-z][A-Za-z0-9]+$",
        "variant": "^-[a-z][A-Za-z0-9]+$",
    }]

I get this:
TypeError: expr(...).test is not a function
    at ....../node_modules/stylelint-rscss/lib/class_format.js:134:31
    at Array.filter (native)
    at validateComponent (....../node_modules/stylelint-rscss/lib/class_format.js:133:28)
    at ....../node_modules/stylelint-rscss/lib/class_format.js:81:7
    at ....../node_modules/stylelint-rscss/lib/helpers/walk_selectors.js:41:43
    at Array.forEach (native)
    at ....../node_modules/stylelint-rscss/lib/helpers/walk_selectors.js:41:23
    at Processor.func (....../node_modules/stylelint-rscss/lib/helpers/flatten_rule.js:15:14)
    at Processor.process (....../node_modules/stylelint-rscss/node_modules/postcss-selector-parser/dist/processor.js:34:14)
    at flattenRule (....../node_modules/stylelint-rscss/lib/helpers/flatten_rule.js:16:6)

So I guess this ticket should be reopened.

Aw damn, I guess you can't have regexp objects in stylelintrc.
On Thu, Sep 29, 2016, 4:51 PM Mikołaj D<EMAIL_ADDRESS>wrote:

So I tried this in my config:
"rscss/class-format": [true, {
    "component": /^[A-Z][A-Za-z0-9]+$/,
    "element": /^[a-z][A-Za-z0-9]+$/,
    "variant": /^-[a-z][A-Za-z0-9]+$/,
}]

and got this:
YAMLException: missed comma between flow collection entries in "......./.stylelintrc" at line 109, column 28:
"component": /^[A-Z][A-Za-z0-9]+$/,
And when I try with strings like this:
"rscss/class-format": [true, {
    "component": "^[A-Z][A-Za-z0-9]+$",
    "element": "^[a-z][A-Za-z0-9]+$",
    "variant": "^-[a-z][A-Za-z0-9]+$",
}]

I get this:
TypeError: expr(...).test is not a function
at ....../node_modules/stylelint-rscss/lib/class_format.js:134:31
at Array.filter (native)
at validateComponent (....../node_modules/stylelint-rscss/lib/class_format.js:133:28)
at ....../node_modules/stylelint-rscss/lib/class_format.js:81:7
at ....../node_modules/stylelint-rscss/lib/helpers/walk_selectors.js:41:43
at Array.forEach (native)
at ....../node_modules/stylelint-rscss/lib/helpers/walk_selectors.js:41:23
at Processor.func (....../node_modules/stylelint-rscss/lib/helpers/flatten_rule.js:15:14)
at Processor.process (....../node_modules/stylelint-rscss/node_modules/postcss-selector-parser/dist/processor.js:34:14)
at flattenRule (....../node_modules/stylelint-rscss/lib/helpers/flatten_rule.js:16:6)
So I guess this ticket should be reopened.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/rstacruz/stylelint-rscss/issues/4#issuecomment-250408149,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikT-wY7La05iSJzXpF_bRarD99Q74ks5qu3wCgaJpZM4KBmKj
.

@mik01aj pls, reopen issue

Okay, this is done and coming out on v0.4.0. Thanks for all your reports!

@rstacruz thx ! It works!!

@rstacruz
i tried this:
    "rscss/class-format": [true, {
      maxDepth: 6,
      component: "/^([a-z][a-z0-9]*)(-([a-z][a-z0-9]*))+$/"
    }]

and got:
resources/assets/sp/sass/_components.search-form.scss
 18:1  ✖  Invalid component name: '.search-form'   rscss/class-format

Remove the / from that Regexp string and you should be good.
On Tue, Apr 4, 2017 at 8:52 PM harapeko<EMAIL_ADDRESS>wrote:

@rstacruz https://github.com/rstacruz
i tried this:
"rscss/class-format": [true, {
  maxDepth: 6,
  component: "/^([a-z][a-z0-9]*)(-([a-z][a-z0-9]*))+$/"
}]

and got:
resources/assets/sp/sass/_components.search-form.scss
18:1  ✖  Invalid component name: '.search-form'   rscss/class-format
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rstacruz/stylelint-rscss/issues/4#issuecomment-291490127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEikYXcVoBW7MYXym7Az04e7ZJJiPvtks5rsj0igaJpZM4KBmKj
.


Nodes do not move with mouse when using setNodes from useReactFlow() inside onNodeDrag callback

What platform were you using when you found the bug?

React Flow / Svelte Flow version: 12.3.2
Browser and version: Chrome 130.0.6723.69
OS and version: Windows 11

Live code example
https://codesandbox.io/p/devbox/thirsty-cookies-ghcknj?workspaceId=0b657e49-ea3f-40b3-aaff-95ccc50ebd12
Describe the Bug
When using setNodes from useReactFlow hook inside of a onNodeDrag callback the nodes do not move on screen while dragging. Events that happen while dragging are still updated e.g. after changing the intersections example you can see that dragging the node will not visually move the node but if while dragging the node you intersect another node the color of the intersecting node will change despite the node you are dragging not visibly moving. See the provided code example
Steps to reproduce the bug or issue

Create onNodeDrag callback that updates nodes using setNodes from useReactFlow
Drag a node and observe node does not move until mouse up

Expected behavior
The node should visibly move on screen while dragging
Screenshots or Videos
No response
Additional context
No response

It seems that your codesandbox doesn't work. Could you check?

This one  should work. https://codesandbox.io/p/devbox/thirsty-cookies-ghcknj?workspaceId=0b657e49-ea3f-40b3-aaff-95ccc50ebd12

This one should work. https://codesandbox.io/p/devbox/thirsty-cookies-ghcknj?workspaceId=0b657e49-ea3f-40b3-aaff-95ccc50ebd12这个应该有效。https://codesandbox.io/p/devbox/thirsty-cookies-ghcknj?workspaceId=0b657e49-ea3f-40b3-aaff-95ccc50ebd12

I think there is a conflict between the onNodesChange event and the ondeagnodes event, resulting in the inability to position correctly. I also encountered a similar problem. The method I adopted was to disable the change of position by onNodesChange and only use a custom function to change the node position, but obviously the performance is not enough OK, I hope we can provide a more convenient API to handle location changes.


Request: init.lua

This is such a small and trivial request, and also one that is mostly about opinion:
renaming .\luacheck.lua to .\luacheck/init.lua makes manual installation (especially dealing with deployment systems that make recursion somewhat painful... ie nuget/coapp) easier.
Feel free to ignore this, but I thought I'd throw it out. Thanks!

No problem, I'll do this.

How exactly are you installing manually? I'd like to add a section about that in the documentation since it is reported to be a difficult thing.

My apologies for not responding more quickly.
The windows issue is that the luacheck.lua file cannot be run from the command line as luacheck.lua <args> and instead needs to be lua luacheck.lua .... I'll whip up a bat wrapper and summit a pull request, after I verify that there are no other issues.
Thank you for your quick response!

I see. I may have misunderstood you then: there were two files called luacheck.lua, one in bin and one in src (luacheck module). I have renamed the latter to src/luacheck/init.lua, but perhaps you meant the former?
A pull request would be most welcome!

You understood it correctly. I was not speaking to any "Windows" issue.
Only to a very minor point, which was that the module files are slightly
easier to manage, when they are all in one directory.
The luacheck.lua file that is meant to be run from the command line
speaks to the lual issue that was raised, which is that Sublime-linter
can't run it in Windows because it won't execute... AT LEAST i think that
is the case. I had a meeting and am only now getting to test it out...
I'll let you know and hopefully soon. Thanks!
On Thu, Jan 8, 2015 at 9:50 AM, Peter Melnichenko<EMAIL_ADDRESS>wrote:

I see. I may have misunderstood you then: there were two files called
luacheck.lua, one in bin and one in src (luacheck module). I have renamed
the latter to src/luacheck/init.lua, but perhaps you meant the former?
A pull request would be most welcome!
--
Reply to this email directly or view it on GitHub
https://github.com/mpeterv/luacheck/issues/12#issuecomment-69198566.


#2057 Workaround unit test failures related to Carbon Tabs

This is a workaround for #2057 until we get a fix from Carbon
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@caritaou should this be closed?

Yes this can be closed, we already picked up the new Carbon version with the fix


Bug in CreateAzureADApp function in deploy.ps1

I found an issue in the deploy.ps1 powershell file. Specifically it is in the CreateAzureADApp function (Line 284). The AZ AD App Create and Update commands no longer support the oauth2-allow-implicit-flow switch or the MultiTennant switch. It appears that MultiTennant has been replaced with "Sign-In-Audience".
I fixed this by adding an if statement right after the function parameters as follows...
if ($MultiTenant) {$audience = "AzureADMultipleOrgs"} else {$audience = "AzureAdMyOrg"}
I then updated the create and update lines like this...
az ad app update --id $app.appId --sign-in-audience $audience
az ad app create --display-name $appName --sign-in-audience $audience

Hi @thomassadowski ,
Thanks for raising the query. The Azure CLI version should be 2.30. If it is not same, could you please download the Azure CLI version and try creating AzureADApp.
Keep us posted.

I checked and the system I was using is on Azure-CLI version 2.42.0.

@thomassadowski , Please uninstall 2.42.0 Azure CLI version and please download the Azure CLI version having 2.30.0 version and try creating AzureADApp.

That doesn't make sense to me. Since 2.4 is the current version, shouldn't this be updated to support that? Also I succeeded in deploying the resources using 2.4 by making the changes I shared. So I have no further need of help, this is more for your information on maintaining the product.


Pg/rust ver wrappers

Updates the MOI interface to allow dual support of both the native Clarabel.jl and the julia wrapper module ClarabelRs written around the Rust version in Clarabel.rs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (releases/v0.2.1@6bd3f70). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             releases/v0.2.1      #96   +/-   ##
==================================================
  Coverage                   ?   82.16%
==================================================
  Files                      ?       31
  Lines                      ?     1861
  Branches                   ?        0
==================================================
  Hits                       ?     1529
  Misses                     ?      332
  Partials                   ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


does not provide an export named 'Routes'

Uncaught SyntaxError: The requested module '/node_modules/solid-app-router/dist/index.jsx' does not provide an export named 'Routes', any solution?

Hmm.. that's unusual as it's definitely there.
Could it be attempting to pull it into a CJS environment? Some build setups require named exports need to be explicitly set. What bundler are you using?

I am having the same problem. Except, for me it is saying "The requested module '/node_modules/solid-app-router/dist/index.jsx' does not provide an export named 'effect'". I am using Rollup to compile a CJS SSR app.

Closing as stale.. No other reports of this and would need more information or reproduction.


build issue on windows

Now Github action on windows it's false positive (need to make buildscript compatible).
On my win10, visual studio 2019
Build fails with
winnt.h(154): fatal error c1189: #error: "no target architecture"

Full log:
https://github.com/gengjiawen/uvwasi/runs/257479832

Works with mingw, but run into other build issue. Is this known issue ?
cc @cjihrig
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c: In function 'uvwasi_fd_fdstat_get':
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c:661:7: warning: unused variable 'r' [-Wunused-variable]
   int r;
       ^
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c: In function 'uvwasi_fd_readdir':
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c:1089:5: warning: implicit declaration of function 'seekdir'; did you mean 'mkdir'? [-Wimplicit-function-declaration]
     seekdir(dir->dir, cookie);
     ^~~~~~~
     mkdir
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c:1089:16: error: 'uv_dir_t' {aka 'struct uv_dir_s'} has no member named 'dir'
     seekdir(dir->dir, cookie);
                ^~
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c:1106:14: warning: implicit declaration of function 'telldir'; did you mean 'tell'? [-Wimplicit-function-declaration]
       tell = telldir(dir->dir);
              ^~~~~~~
              tell
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c:1106:25: error: 'uv_dir_t' {aka 'struct uv_dir_s'} has no member named 'dir'
       tell = telldir(dir->dir);
                         ^~
C:\Users\appveyor\source\repos\uvwasi\src\uvwasi.c:1107:16: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
       if (tell < 0) {
                ^
mingw32-make.exe[3]: *** [CMakeFiles\uvwasi.dir\build.make:105: CMakeFiles/uvwasi.dir/src/uvwasi.c.obj] Error 1
mingw32-make.exe[2]: *** [CMakeFiles\Makefile2:77: CMakeFiles/uvwasi.dir/all] Error 2
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:84: CMakeFiles/uvwasi.dir/rule] Error 2
mingw32-make.exe: *** [Makefile:117: uvwasi] Error 2

Okay, with lots patch https://github.com/cjihrig/uvwasi/pull/30 and https://github.com/cjihrig/uvwasi/pull/27 got merge in local.
uvwasi.exe build works on mingw compiler.
cc @cjihrig @tniessen
Though failed with
C:\projects\appveyor-playground\uvwasi\cmake-build-debug\out\uvwasi.exe
Assertion failed!

Program: C:\projects\appveyor-playground\uvwasi\cmake-build-debug\out\uvwasi.exe
File: C:\projects\appveyor-playground\uvwasi\app.c, Line 44

Expression: r == 0

Run into some weird issue, When I debug it with clion, the r value is 0.

But when I run it, the r is 31. (use printf("%d", r);
)
C:\projects\appveyor-playground\uvwasi\cmake-build-debug\out\uvwasi.exe
31Assertion failed!

@gengjiawen That is because Windows does not support uv_fs_fstat for stdio file descriptors.

@gengjiawen That is because Windows does not support uv_fs_fstat for stdio file descriptors.

Still not get why run and debug got different value.

For anyone comes here find why run and debug got different value, it's due to cwd :)


Mags aren't returned to inventory when hotbar is full

Version:
paneedah-modern-warfare-0.1-Dev-2
Describe the bug
When reloading, mags are only deposited into the hotbar. If there is no space, the mags seem to vanish even if the inventory has plenty of space.
To Reproduce

Equip a gun and a few full mags
Fill the rest of your hotbar with items
Shoot
Reload
The mags just vanish

Expected behavior
If the hotbar is full, the empty/half-full mags should be deposited into the inventory.
Screenshots / Videos
I don't have any, sorry.
Additional context
I only tested this with one gun, I don't know if the issue is specific to this particular gun or all guns.

issue is also present in paneedah-modern-warfare-0.1-Dev-3


Make BGP.tools client IPv6 compatible

Description
The BGP.tools client used a mode on the python socket library that does not support IPv6 only connections. This PR corrects this.
Related Issues
N/A
Motivation and Context
When attempting to run hyperglass on the AS207960 kubernetes cluster which is IPv6 only, in effect, everything broke.
Tests
Tested as working on the AS207960 k8s cluster, cannot foresee this breaking on any other envs as it is such a simple change.

Hi there,
Thanks for submitting this, I didn't realize that the current implementation would only work on an IPv4 or dual-stack connection.
Rather than add this to v1, I'm going to merge this into the v2.0.0 branch, make a couple of improvements (like add logging, comments, and a few style/syntax changes), and add tests.
Leaving this open until I have a chance to do so.

As it turns out, I believe I've accidentally fixed this via changes in c99f98a. asyncio.open_connection appears to support native IPv6 connections without without having to specify the socket type at all, and I've confirmed this by testing from an IPv6 only connection. Closing this out.

That's very convenient, glad its sorted!


Add feature descriptions

Is your feature request related to a problem? Please describe.
The feature list is currently not informing about the intent of a feature.
Describe the solution you'd like
Change the result format from a string list to a JSON object including the field and a description.
Describe alternatives you've considered
none
Additional context
none

Descriptions can now be added to the features.json file.

Already did this for 0.9.5


ROX-21620: publish opensource instead of stackrox.io helm charts

Description
Stops generating and publishing stackrox.io based helmcharts.
Going forward, the opensource flavor is published to stackrox/helmcharts.
Checklist

[x] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[X] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
Used a "dry run" of a release (curtesy of @tommartensen) to produce an example release-artifacts PR.
The interesting artifact is the helm repo archive produced. I verified this contains the opensource charts, by looking at the internal/defaults.yaml's image repository and confirming it now points to quay.io.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Question: There are still several references to stackrox.io in the codebase -- shall we get rid of them within this ticket as well?

I had a quicklook. My IDE gave me 900++ matches for stackrox.io in the codebase. At least my knowledge is too limited for a targeted cleanup.

Question: There are still several references to stackrox.io in the codebase -- shall we get rid of them within this ticket as well?

I had a quicklook. My IDE gave me 900++ matches for stackrox.io in the codebase. At least my knowledge is too limited for a targeted cleanup.

Then I would suggest to merge this as is and either keep the original ticket open (with updated scope) or create a follow-up ticket for the doc changes.

@mclasmeier merged here, and created https://issues.redhat.com/browse/ROX-21937


Remove Seeder class and let rails do it

Rails 3.1 can handle seeds.rb from engines. So we can remove our seeder class

No, we can not, but I made a rake task rake alchemy:db:seed that handels the seeding, so we do not have to copy the Seeder call into the seeds.rb file of the project.


Unable to read messages on COAP server running on Raspberry Pi via Nodered

I am trying to read COAP messages on nodered running on Raspberry Pi, but I am unable to do so directly. The problem I have found is that UDP packets are being directed to NCP  on OTBR that and are not able to routed to localhost server.

I am able to read packets, if I forward coming on 5683 port of IPV6 to 5683 port of localhost server. But this is not working for GET requests. Am I missing anything? because, it should not have been this difficult in my opinion as, I am able to get responses if I push everything to COAP server  running on cloud service with any problem.
Is there a different way to generate IPV6 address for coap client running on MCU for the server running on 192.168...,localhost, <IP_ADDRESS> etc local ip addresses as  normal ipv4 to ipv6 conversions are not able route these requests.

This is issue is related to the border router project.  Let's continue the discussion in: https://github.com/openthread/borderrouter/issues/142


(feature) Sort TP folders according to slides

Add a number before every folder in TP according to the slides.
Also fixed typos in docs/markdown/directive/exercice_directive_use.md and docs/markdown/forms/template-friven-form/exercice_create_form.md

@parsyval I didn't find any change since previous commit 63096db in exercice_directive_use nor in exercice_create_form, are you sure you pushed these changes ?

Arf right, I forgot to push these sry, it's on now.

You rename all TP directories but not the according slide steps.
You should also rename the TP indication in every exercise slides and solution slides. You should change the forlder pattern on the slide "Déroulement des exercices"

Done, I'll fix the conflicts after #7 is merged

@Nicoss54 @kuroidoruido Done, I'll fix the conflicts after #7 is merged

You can fix conflict, the #7 PR is merged :slightly_smiling_face:


Add Zenodo badge

This was already enabled, so the upload was already triggered 😅
Closes #26

Hi @ThijsVroegh, I took the opportunity to also add a citation.cff, could you add your orcid?

Hi @stefsmeets, I added my orcid


It would be realy helpful if you can add shiftRows() Function

Since this is such a good API it would be awesome to see shiftRows() function. It will cover all aspects of excel sheet.

This library cannot support writes to worksheets. It is a reader only; writes would require a lot more memory and the full POI library already does this. I'm afraid you're stuck using vanilla POI if you need to modify a sheet.

I'm going to close this issue as it's asking for functionality that cannot be provided. If you have any more questions, I'm happy to answer them.


fix(helm): fix failing helm dep up on subchar requirements

Description of the pb
this issue https://github.com/kubernetes/helm/issues/3742 is in fact 2 issues.
The initial is that helm dep up fails when there is a mix of local and remote dependencies.
But more broadly, helm dep up fails when the requirements.yaml contains dependency on the local charts folder. And this can be usefull when you want to activate or not a sub chart with conditions or tags.
##proposed solution
I propose to fix this by ignoring those local subchart during the DownloadAll phase. Cause the implmentation moves the charts folder into a tmpcharts folder and therefore it does not find the local repository anymore.
More over for those charts there is no need to download or package anything so this is why it is all local charts under the charts folder shall be ignored in the phase.

I kicked off a rebuild to see if this was a transient error.

thanks, the tests indeed passed sucessfully but the build was canceled!

any one to launch the build again and have a look at this PR ?

Is this still happening?..

I just kicked off a fresh build. https://circleci.com/gh/kubernetes/helm/6043

@kibertoad I am not sure whether you're referring to the intermittent build failure or to the original problem. In case of the latter: Yes, I am seeing this issue right now using helm v2.9.1 on macOS 10.13.5.

@bacongobbler thanks for kicking a new build and it was sucessful but unfortunatly the success is not reflected in the PR status.
Is there any chance anyone review this PR and eventually merge it ?

Still seeing this issue, bump

Any word on this ?

Still experiencing this behavior as well

Any updates? Still seeing this issue..

@bacongobbler Thanks a lot for the review. I did take all your comments into account.

Any updates?

@bacongobbler ping

any news  ?

Is the best available workaround to rename charts/ to local-charts/ and use
repository: "file://local-charts/fluentd"

for example?

@sjmiller609 Yes it is working well, we have been using this workaround for over a year without any issue.
But that would be great to have this fix merged.

Just ran into this same issue. Any ETA on merging this ?

It would be great if this PR gets merged ASAP 👍
@bacongobbler could you please have a final look, please?

I'd suggest reaching out and finding another maintainer to review this. I'm focusing primarily on Helm 3's ongoing development and security fixes for Helm 2, which is why I have not been spending much time looking at features for Helm 2 such as this one.

Closing in favour of https://github.com/helm/helm/pull/3422 as the implementation is much cleaner and simpler to understand. It also contains additional validation checks (for example, when the dependency contains a version constraint). Thanks.


solve the memory leak on Android and avoid the crash on kitkat

Solve the memory leak on Android and avoid the crash on Xiaomi Phone M4's kitkat rom when call mp.selectTrack(0);

Please test, review, and merge. I'm getting this as well - 10% of my users are getting this crash

@evanjmg Sorry to hear about your issues!
In such an urgent case you still have to option to either use https://www.npmjs.com/package/patch-package or fork!

Ok, I looked through this code and it seems like blindly selecting track 0 isn't useful unless track 0 happens to contain timed metadata. So I've made it look to see if there is even any timed metadata and only select those tracks. I can't find a sample stream to test this, so I'm just going to cross my fingers and hope this works properly. @RWOverdijk any chance you can test the updated code?
I'm going ahead and merging this. @evanjmg and @linguokun1 would you mind testing the updated code to make sure it fixes the issue for you?

Nice refactor. So far so good; it’s an improvement for me. I’ll let you know if I have any more issues.


The far manager in the command line window does not interact with the mouse.

Environment
Windows build number: Edition	Windows 10 Pro Insider Preview
Version	Dev
Installed on	18.03.2021
OS build	21337.1000
Experience	Windows 10 Feature Experience Pack 321.5601.0.3

Windows Terminal version (if applicable):  1.7.572.0

Any other software?
Far 3.0.5757.0 x64

# Steps to reproduce

- Open a command line window in the terminal.
- Run Far.exe.
- Click on any location of the interface that appears.
- Make sure there is no reaction to click.

<!-- A description of how to trigger this bug. -->

# Expected behavior
At a minimum, highlighting the position to which the mouse cursor points.
<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->

# Actual behavior

<!-- What's actually happening? -->
Nothing really happens.

I think this is #376 ?

Sure is
/dup #376

It is not clear what #376 has to do with my problem.
Wbr, Dyakov K.M.
чт, 18 мар. 2021 г. в 13:19, Chester Liu @.***>:

I think this is #376 https://github.com/microsoft/terminal/issues/376 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/9535#issuecomment-801802098,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGFUSFODZ76Y5I6QR35RDDTTEHHTHANCNFSM4ZMJW2CA
.

You have reported that the mouse does not work inside FAR Manager. #376 is the issue for supporting mouse input to Windows applications (like FAR manager.) :smile:


[i18nIgnore] i18n(es,fr,ko,ru): fix typo in guides/internationalization.mdx

Description (required)

Fix typo in function name (getRelativeLocaleURL > getRelativeLocaleUrl) in  guides/internationalization.mdx (see #9299)

I saw #9299 being merged without triggering a status change (typo in title again) so I updated all the languages where this typo was present.

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌑 This pull request will not trigger status changes.

Learn more
Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.
You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

[!NOTE]
The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale
File
Note

es
guides/internationalization.mdx
Localization changed, will be marked as complete.

fr
guides/internationalization.mdx
Localization changed, will be marked as complete.

ko
guides/internationalization.mdx
Localization changed, will be marked as complete.

ru
guides/internationalization.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Run cc tests on Windows with Bazel

@gunan @dslomov @damienmg
To filter out all the broken and failing tests on Windows, we add "fail_no_windows" tag for them.

@vit-stepanovs Thanks for reminding me that! I do have a list of tests which run with CMake but not with Bazel, I'll look into them.

@gunan I think you are right, I removed all the logic of adding tags to the test targets, instead, we filter them out in a shell script for test. PTAL.

Jenkins, test this please

Jenkins is not updating the review thread, but the test is running here:
http://ci.tensorflow.org/job/tensorflow-pull-requests-multijob/2880/

I think the failure is just a flake.
Jenkins, test this please.

Tests seem to be flaky, as different ones failed each time.
Merging.


Add a new method to get country and city name for a given IANA time zone identifier

I have a need to accept IANA time zones as both input and output within my application.  It is not practical for me to change the interfaces to accept country and time zone independently.  Moreover, on output, I have a time zone identifier but can't disambiguate it (I.e. if I have "America/Tijuana" or "America/Los_Angeles" I have to show the user more than just "Pacific Time").
I added a new method, GetLocationNamesForTimeZone, which takes as input the IANA time zone ID, and outputs the list of countries and the "representative" city for the time zone.  Also added readme documentation and tests to show how it works.

Noticing this is still pending.  I'll do a more detailed review on this one and other enhancement requests soon.  Thanks for your contributions!

Sorry I never got back to this.
I recently made several major changes and finally pushed 6.0.0.  This PR will need to be rebased or re-worked on top of that.  LMK if you are up for that still, or if not then I'll do it at some future point.  Thanks again.


Added missing loader for woff2.

This is needed after installing FontAwesome Pro. Otherwise the esbuild fails.
See the following screenshot for the encountered error:

@nathanclark Thanks for this!


Specify data types of roles columns

The data type is based on the length you configure for the entity fields. At least, that's the case for object, array and custom types. By default a LONGTEXT is used to store that table data. When running a MySQL like dbms in strict mode, that quickly becomes a problem as LONGTEXT fields can contain many bytes of data. Adding the new MDUI field was not permitted as the maximum table size restraint wat triggered (IIRC).
To solve this issue, and to optimize the roles table. We decided to review the data types for the text/object based fields. And set them to a value that more realistically reflect their size.
As a result the following changes were made:

name
type
new length

certificates
array
65535 (text)

contact_persons
array
65535 (text)

name_id_formats
array
65535 (text)

single_sign_on_services
array
65535 (text)

shib_md_scopes
array
65535 (text)

attribute_release_policy
array
65535 (text)

assertion_consumer_services
array
65535 (text)

organization_nl_name
object
65535 (text)

organization_en_name
object
65535 (text)

organization_pt_name
object
65535 (text)

consent_settings
json_array
16777215 (mediumtext)

mdui
engineblock_metadata_mdui
65535 (text)

Note that the logo field is not updated as it is marked for removal in the next release.
See: https://www.pivotaltracker.com/n/projects/1425900/stories/185861244

consent_settings and allowed_idp_entity_ids (not listed in the table) are updated to MEDIUMTEXT because these fields can/will become longer if you have many other entities (IdPs) in your platform. So if you would have 1000's of IdPs they can become larger. The other fields only pertain to the entity itself so are not likely to grow very large, at least not dependant on the number of entities configured.


Support Native FST As An Index Subtype for FST Indices

This PR introduces the notion of subtypes to FST index -- allowing users to set a segment level flag indicating whether the index should be built using native FST or Lucene FST.
Supersedes #7684

Codecov Report

Merging #7729 (ef51799) into master (91d2a95) will decrease coverage by 56.99%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #7729       +/-   ##
=============================================
- Coverage     71.50%   14.51%   -57.00%
+ Complexity     4033       80     -3953
=============================================
  Files          1581     1537       -44
  Lines         80472    78709     -1763
  Branches      11954    11769      -185
=============================================
- Hits          57540    11423    -46117
- Misses        19037    66446    +47409
+ Partials       3895      840     -3055

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.51% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d2a95...ef51799. Read the comment docs.

@Jackie-Jiang Updated, please see


Include stored_scripts response in cluster metadata response.

Fixes #3746.
Backport to 7.x and master after approval and merge.

Ported to 7.x


AttributeError: 'RotatedFastRCNNOutputs' object has no attribute 'predict_orientations'

...glass/modeling/roi_heads/rotated_fast_rcnn.py  Line 356
boxes = self.predict_boxes()
scores = self.predict_probs()
orientations = self.predict_orientations()

Hi!
Thanks a lot for the interest in our package. The issue was fixed in the latest commit.


doc: fix two invalid  tags

Signed-off-by: Beat Bolli<EMAIL_ADDRESS>I stumbled upon the first one by chance, then checked if there were any others.
Checklist

[x] documentation is added or updated

Hey, @bbolli nice to see you again :)

Hey, @richsalz Or, as my Twitter handle says: "Occasional OSS contributor"...

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Setting ready-to-merge since the comments after 'approval:done' was set were just socializing.
Did anyone have plans to merge?

Hearing nothing, I will go ahead and merge.

Merged to master, so closing.
Thanks for the fix!


[2pt] - (#Back-end Member #2) - Create request tests for hotels and reservations

I did the following:

Created Request specs for hotels and reservation controllers.
Ensured all test cases pass.
Fix rubocop errors

Status: APPROVED 👍 💯 🥇
Hi @RaphDasilva, nice work implementing request tests for hotels and reservations.
Please, go on and merge it ✔


MP Schema Discrepancies

Issue:
Recently, one of our Software Developers noticed the following two inconsistencies in the latest Monitoring Plan JSON schema, which might be indicative of a bug.
Element monitoringDefaultData has a property groupID  (with capital “D”)
This was previously called groupId (with lower-case “d”)
This property is still called groupId in the “required” section of the schema
I suspect this property should still be called groupId (lower-case “d”)
Element unitControlData, properties originalCode and seasonalControlsIndicator
These are defined as strings with enumerated values null, “0”, and “1”
Other similar “indicator” fields are numeric with values null, 0, and 1
I suspect these fields should be numeric as well

Unit Control properties originalCode and seasonalControlsIndicator are defined as strings in the database so the schema is correct

@mosesdeeCVP

Private Zenhub Image

Private Zenhub Image

groupId is correctly formatted with a lowercase 'd'

The elements under unitControlData are correct to be a 'String' as this in an exception. No changes were made as it is ok the way it is.


Feature Request for LiveContainer

LiveContainer has been a blessing for iOS sideloading,
The CidyaSubstrate fixes have fixed a lot off apps and Emulators like Folium are now functional (haven’t tested throughly). Thank you for your work!
I don’t have any idea about iOS development or the internals of LiveContainer, so I don’t know if these are ridiculous feature requests but, please consider implementing:

Exiting Applications after use, A overlay that allows the user to goes back to App Selection after use, this will prove very helpful when using emulators that require JIT, as the same instance of LiveContainer can be used to run multiple emulators without having to enable JIT in each one. This would be especially helpful when away from a computer when a debugger for JIT cannot be attached. iOS’s unpredictable memory management can close JIT instances of emulators, a one for all solution would be much more reliable.

Use of LiveContainer with a Developer Certificate, again, I don’t know the internals but it if somehow LiveContainer can grab the correct files needed for JIT-less setup from SideStore without having to be sideloaded with SideStore then folks using a signing service (no apple dev account, just p12) can benefit from having to refresh Live Container.

These are some features I hope you can consider implementing in the future (if possible). Again, Thank for the work with LiveContainer, it is a godsend.

If i may also make a feature request can you add an option to force it to resign an app in jit less mode
As the signing can mess up which then cause it to crash loop

If this is a feature request thread (just delete if it's not okay here) I'd like to suggest the ability to set livecontainer to auto boot into the last selected app. You could then change which app you want to boot into with a shortcut or 3d/haptic touch (the main livecontainer interface would also be an option from the 3d touch/shortcut). Effectively, livecontainer would then act as if it was that particular app in every way, until you selected a different one from 3d touch or a shortcut.

First of all thanks for all your suggestions, here’s my answers:

It is not possible to return to LiveContainer without leaking memory and breaking internal state. The main reason is that UIApplicationMain can only be called once, otherwise I will need to make it so it somehow finds all pages, deallocate pages no longer being used, reset frameworks’ internal state, etc, which is probably very difficult.
I think I may allow Sideloadly and UDID (personalized) cert support by providing a button to import certificate, but I’ll need to write my own signer (which I didn’t and I was too lazy so I chose to dynamically load SideStore frameworks and call its signing API instead). Note that enterprise cert won’t be supported as it would raise error sandbox file system blocked mmap()
(@dragonplus8) Sure. At the moment you could use a plist editor to remove LCSignRevision from app’s Info.plist to force it to resign
(@SARankDirector-Minecraft) I’ll look into it. Maybe I’ll also add a switch in settings for this


upgrade dependencies, including major upgrade to schema-utils

Upgraded the dependencies to use latest versions, most were minor upgrades but schema-utils went up two major upgrades. According to the schema-utils changelog the v1 -> v2 upgrade is the only time where code changes were necessary. The changes are very minor, simply adjusting the options to pass in the name and options prefix for the validation error. Minor changes to the istanbul libraries does trigger minor snapshot upgrades but they're ver broken on github, so for the reviewers sake here are the highlights handled better by local diff highlighters:

terrible screenshot that highlights the changes in the snapshots

The upgraded package limit node version support to 8.9.0+ so I've included some pending changelog docs, upgraded the node versions being tested on CI, and upgraded to the latest version of npm to get support for node versions 12+.
Also migrated from nps check to npm audit, which should provide similar information, though I get the feeling that nobody is really looking at these results so maybe they can just be removed. There are a number of outdated packages with security vulnerabilities in the devDependencies, which should be fixed but felt out of the scope of this PR (I definitely tried to fix them) so I updated the audit command to npm audit --production to only check for security vulnerabilities in production dependencies.
Additionally, the CI checks run against webpack@latest, which require relatively minor webpack config changes to get tests passing.

Well, this has been a challenge. I'm not sure if what I've done here is too much for one PR, or if I have to get this passing against webpack canary.
I've gotten it close, but webpack canary is producing slightly different output and I'm really unsure what to do about that difference in the tests.

@spalger Hi, we recently discussed to deprecate this loader, it is abandoned and not maintainable, so I did not expect a bit that someone would send PR, you can tell how you use the current loader, what is use cases?

Well, we currently use it to instrument our bundles before running them through a functional end-to-end testing suite. It's an experimental form of coverage collection and this works fine, we just had to force upgrade schema-utils with yarn resolutions and I was looking to remove a warning produced by yarn. Is there something intrinsically unmaintainable about this project that I'm not realizing? It seems like a very simple wrapper around istanbul that we could totally implement in our project rather than relying on the loader, but I'm also happy to help get this caught up to modern standards.

Also we need fix CI problems

This is tricky, as CI currently require that webpack@latest and webpack@master both create the same bundle as verified by the Jest snapshots. There are possibly things we could do to remove problematic bits from the snapshots with serializers, or by processing the file before snapshotting it, but I think I'm trying to understand the value of running the same test suite against master and latest, especially when the difference between the two is a major version break.
Is this how things work in other webpack-contrib projects?

Oh, cool, do you have plans to fix CI? I'm happy to work up the fixes but my instinct is to just drop the webpack@master tests. Do you have a preferred solution?

@spalger

Oh, cool, do you have plans to fix CI?

Yes, today

I'm happy to work up the fixes but my instinct is to just drop the webpack@master tests.

Yes, we should rewrite some tests

Do you have a preferred solution?

I think yes, let's me try


fix(tests): avoid name collision in database tests

Unfortunately, the previously used faker.random.word() was not random enough, and this made tests flaky because of the name collision errors that occasionally happened.

Codecov Report

Merging #1783 (74d4deb) into main (19818e2) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 74d4deb differs from pull request most recent head 71de870. Consider uploading reports for the commit 71de870 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #1783   +/-   ##
=======================================
  Coverage   87.18%   87.18%
=======================================
  Files          83       83
  Lines        8972     8972
  Branches      537      537
=======================================
  Hits         7822     7822
  Misses       1150     1150

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


DeviceProfile upload issue on booleans

When uploading device profiles, the LSB value of "true" or "false" causes errors (it is not interpreted as a boolean).  Setting it to true or false results in a null value for LSB.  There may be other properties that are not getting loaded correctly.

@jpwhitemn I tracked this down to the capitalization of the LSB field itself in the device profile. If the field in the YAML is capitalized, it will not map to the field as the mapping metadata in our application is looking for "lsb". All fields when we do mapping are lower-cased, which is why the other properties work.


Mr ms integration test

This test applies the SecuredDB version of model regisrty to an Istio/ODH/ModelMesh cluster.
To review and run it locally you will need the following:

Pull and checkout this PR

Have an existing openshift cluster with Red Hat Athorino, OpenDataHub and Red Hat Openshift Service Mesh operators installed.

Be oc logged into to your cluster

Set the following local files
ods_ci/run_robot_test.sh  line 25 SUBFOLDER to be set to true.
ods_ci/tests/Tests/1300__model_registry/1302_model_registry_model_serving.robot.  In the test case [Tags] (line 45), leave 4 spaces after OpenDataHub and put <YOUR_NAME> as a local tag to be picked up by the run command.

run the following command from directory ods-ci/ods_ci
sh run_robot_test.sh --test-variable PRODUCT:ODH --test-variable APPLICATIONS_NAMESPACE:opendatahub --test-variable MONITORING_NAMESPACE:opendatahub --test-variable OPERATOR_NAMESPACE:openshift-operators --test-variable NOTEBOOKS_NAMESPACE:opendatahub --extra-robot-args '--variablefile test-variables-odh-overwrite.yml' --include  **<YOUR_NAME>** --skip-oclogin

/wip

could you also edit a bit the PR title? So from release notes it would be clearer what was added

Jira to track the DSCI issue stopping this PR passing on the PR check pipeline.
https://issues.redhat.com/browse/RHOAIENG-11119


wid_edit: Widget Editor

Widget Editor, so we don't need to edit code to move our widgets around.
Every feature seems like a good idea while happily coding away, but "disabling" widgets is tricky. I think it works fine with most widgets, but they are still loaded.
And apps that try to call WIDGETS[<myappid>].someCustomFunction() probably break.
Maybe better to strip this out, and if people want to get rid of a widget we adjust that app? (Maybe someday we can come up with a standard setting for this, so apps don't all need to build their own "show widget?" setting)
Also, maybe we should "officially" get rid of bottom widgets? Bangle.appRect doesn't looks like it supports it for one...
The only bottom widget is wdclkbttm, I haven't tried that particular one, but it seems Things (like menus) Break with bottom widgets.
With all the "disabled"/bottom row breakage, I figured this should be a separate app.
But if we strip out disabling, and only allow choosing between "top left"/"top right", maybe this could go directly into the settings app?

Thanks! So...

Also, maybe we should "officially" get rid of bottom widgets?

I think so, yes... I mean with appRect we could kind of support them in apps (and I should add that to the firmware), but I'm not sure anyone really seems to care about them.

but "disabling" widgets is tricky.

I think for disabling we should just ask the user to uninstall. But maybe you could switch to hiding? This seems quite successful and is already used a few places: https://github.com/espruino/BangleApps/blob/9b4d2e140b8876428fb6fff4c3a5d1b060ec0dd3/apps/widviz/widget.js#L10-L11

I think for disabling we should just ask the user to uninstall. But maybe you could switch to hiding?

It tries to hide them now, and could probably try a bit harder (and properly label it "hide" instead of "disable"), but "just ask the user to uninstall" seems like the better way. Also because otherwise you end up with a whole bunch of widget code loaded for no good reason, and it would mean much cleaner code for this app.
Same goes for only supporting top-row widgets: that way the boot code doesn't need to mess with appRect.
I'll update it to just support tl/tr and sortorder.

Updated to just support tl/tr and sortorder.
Also removed "bottom bar" references from the general README.

Thanks!


Added ability to show unix timestamp in formatted date

Now you can use U for unix timestamp with second resolution and u for unix timestamp with millisecond resolution.

Can you explain the use case for this?
Couldn't this be solved with moment.fn.valueOf or moment.fn.valueOf / 1000? Do you need the unix timestamp mixed in with the other date formats?

Any update on the use case?

I have a function that accepts date format string to add it to logs. I don't know what format is, but it may include timestamps. Why should I replace timestamps by myself when it's task of moment.format()?

So you're writing a function that other people are going to use (I'm guessing from the fact that you don't know what the format is going to be) and you want to support unix timestamps in those logs?
So the output could be "Tuesday, Nov 1", or "Tuesday, Nov 1<PHONE_NUMBER>942"?
Sorry, just trying to understand the use case.


Random mac address error

I want to try: BLE_client example and,
I have a this serial output:
BLE Advertised Device found: Name: , Address: 5b:db:8e:2a:25:30, manufacturer data:<PHONE_NUMBER>02580363e72e087b8df290a29359ff2e264b7af585a0072c
But the all Adress are not true. My phone address or other bluetooth device adress not include true one. How can i fix ?

Are you sure that your peer devices dont use RPA mac address? Its private random mac address that is changing very often to not allow to track device.


Fix for #615

Fixes #615
Proposed Changes
Updated readme to call out that AZ CLI version >= 2.0.45 needs to be installed to get the latest botservice extension.
Testing
No tests were added or updated.

Pull Request Test Coverage Report for Build 1692

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.113%

Totals

Change from base Build 1661:
0.0%

Covered Lines:
3961

Relevant Lines:
5628

💛  - Coveralls


[admin] Publish

Docs Build status updates of commit 53026b5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/correlated-objects-pattern.md
:white_check_mark:Succeeded
View

docs/includes/outlook-loopback-exemption.md
:white_check_mark:Succeeded
View

docs/outlook/autolaunch.md
:white_check_mark:Succeeded
View

docs/outlook/smart-alerts-onmessagesend-walkthrough.md
:white_check_mark:Succeeded
View

docs/word/search-option-guidance.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Do not highlight when the event's keyCode is NOT 13

For example, when we hit the Enter key to convert Japanese Kana to kanji, KeyboardEvent's keyCode is 229.
the following screencapture is current behavior when we hit the enter key to convert Japanese Kana to kanji:

Currently, we lose existed text after converting Japanese.
And next screencapture is corrected behavior:

Hi! Sorry for leaving this issue open for so long. It looks like you're not using props.autoHighlight in your example. I'm just wondering if this should also be applied to the branch below (https://github.com/reactjs/react-autocomplete/blob/master/lib/Autocomplete.js#L275-L291).

A more general fix has been released in v1.7.1. Please test and verify that it works as intended.


Allow IndexMerger to use non-lexicographic dim order when merging indexes

Partially addresses issue #658
Instead of expecting lexicographic order in the mergedDimensions list, IndexMerger will use the dimension ordering provided by the indexes. If the indexes to be merged have different dimension lists, the old lexicographic merged dimension order will be used.

@gianm renamed test variables to be less confusing, removed unused imports/code

This doesn't fix the same problem in the IndexMaker, but I think that's okay since it's deprecated…

@jon-wei generally looks good, only have testing & style comments.

:+1: looks good to me

@xvrl why is this Incompatible ?

@himanshug it could significantly affect the size of the resulting segments, since the default behavior is not the same.

It may also affect query performance, since filters that previously scanned only a portion of the column may now scan the entire column due to re-ordering. It won't break anything, but it could cause unexpected changes, so it's worth mentioning in the release notes.

:+1: @xvrl @himanshug any concerns or can we merge?

:+1:

IMO this is cool to merge and we can also take out the 'incompatible' label. The real incompatible change is changing DataSchema in druid-api to stop automatically sorting the dimensions.

And that is not really "incompatible" in the sense of being an api change, but it is something that may conceivably be noticeable to people and should be called out.

@gianm agree, maybe we need a different label just so we remember to put it in the release notes

@xvrl open to ideas for better labeling, although I think it's fine for now to use 'incompatible' for whichever PR is gonna remove the automatic dimension sorting that happens upstream in DimensionsSpec. That wouldn't be really incompatible (it's not an api change or compatibility change) but it's still worth calling out possibly not-always-better. I would put that in the same category as switching the default bitmaps from concise to roaring, if we ever did that.
I think we can remove the label from this PR though as it should not be meaningfully changing behavior.


Fails to create symlinks in /usr/local/bin/ on OpenBSD

Getting zsh: command not found: bundle after gem install bundler on OpenBSD 5.7 because /usr/local/bin/bundle22 doesn't get symlinked to /usr/local/bin/bundle. Had to do so manually. Can anyone else confirm this?
Download and install: ftp://ftp.openbsd.org/pub/OpenBSD/snapshots/amd64/install57.iso
Do ie. export PKG_PATH=ftp://ftp.openbsd.org/pub/OpenBSD/snapshots/packages/amd64/ and then pkg_add ruby-2.2.0.

I don't use BSD, so I can't really help with this, sorry.
On Wed, Jan 21, 2015 at 10:26 AM, dt1973<EMAIL_ADDRESS>wrote:

Getting zsh: command not found: bundle after gem install bundler on OpenBSD 5.7 because /usr/local/bin/bundle22 doesn't get symlinked to /usr/local/bin/bundle. Had to do so manually. Can anyone else confirm this?
Download and install: ftp://ftp.openbsd.org/pub/OpenBSD/snapshots/amd64/install57.iso
Do ie. export PKG_PATH=ftp://ftp.openbsd.org/pub/OpenBSD/snapshots/packages/amd64/ and then pkg_add ruby-2.2.0.
Reply to this email directly or view it on GitHub:
https://github.com/bundler/bundler/issues/3355

This is expected behavior with the OpenBSD ruby ports.  Note that the gem binary is installed on OpenBSD as gem22 or gem21, and the user is expected to symlink manually to the preferred version (you must have done so, otherwise gem install bundler would have given you command not found: gem).  Likewise, gems installed via gem22 install on OpenBSD have their executables automatically suffixed.  Just like the main ruby executables, these should be manually symlinked to your preferred version.

:+1:


Configurable catalog page size

Hello Team,
We would like to request a new feature which can customize catalog page size to higher number (currently its 20 rows).
Feature Suggestion
Custom or the ability to set the number of default rows for the catalog table
Possible Implementation
Custom parameter which can set the rows to the given value, else take the default one (currently 20 rows)

Hi @lvenugopal, this sounds like a good idea. Would you be willing to help out and send a PR for this?

I am working on it. will raise a PR in few hours possibly.

Raised a PR #10516 , Please review


build: Place CILIUM_ENVOY_SHA dependency in the Dockerfile

Automatically triggered builds (such as cilium/cilium:latest) can't
run "make" to start the docker build, but must build from the
Dockerfile without any prepatory steps. Enable this by moving the
CILIUM_ENVOY_SHA dependency to the Dockerfile instead of a separate
file. Makefile.defs still defines CILIUM_ENVOY_SHA as a variable, but
gets it from the Dockerfile.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

This change is

test-me-please

Unrelated CI issues, testing again.

test-me-please


iOS PlatformView Registration API needs to be less confusing.

The PlatformView Registration code has a parameter called "plugin". Although platform views were initially designed as a way for plugins to embed native UI objects; it is also true that the same API can be used without a plugin. It only requires a unique String passed into the "plugin" parameter when used without a plugin.
The documentation also suggests PlatformView is a plugin only feature with sentence like "For plugin registration, modify the main plugin file (for example, FLPlugin.m):"
This has caused some confusion for users of the PlatformView API.
There are several things that we can do to reduce the confusion.

Update the documentation so that it is clear that PlatformView can be used without a plugin.
Update the API so the API name is not suggesting PlatformView is a plugin only feature.
Provide a new API (so there's no breaking change) for PlatformView registration under a non-plugin setting. Preferably one without user needing to provide a unique String.

Side node: The android API doesn't require a plugin name. iOS should try to follow the same pattern.

hi, i want to work on this

Yeah, that will be really helpful. Any update on this?

Hi, which file exactly do address this documentation issue? I have been trying to find it for a while now.

@Tomiiwa Thank you for wanting to help :) This is the file that needs to be updated for the documentation. Perhaps we can add an example of how one can register a PlatformView without a plugin.


Migration Issue

I have used knex before so I was expecting the following to work fine. However, only the the states table is being created. I've tried multiple ways and always get the same result, even without the Promises. I have also tried using bluebird Promises; same result. Am I missing something?

'use strict'

const Schema = use('Schema');

class Initial extends Schema {

  up() {
    let knex = this;

    return Promise.all([
      knex.create('countries', function (table) {
        table.increments();
        table.string('abbreviation', 8).unique().notNullable();
        table.string('name', 50).notNullable();
        table.dateTime('deleted_at');
        table.timestamps();
      }),

      knex.create('states', function (table) {
        table.increments();
        table.string('abbreviation', 8).notNullable();
        table.string('name', 50).notNullable();
        table.dateTime('deleted_at');
        table.timestamps();
      })
    ]).then(function () {
      return Promise.all([
        knex.table('states', function (table) {
          table.integer('country_id').notNullable().references('id').inTable('countries');
        })
      ]);
    });
  }

  down() {
    return Promise.all([
      this.dropIfExists('countries'),
      this.dropIfExists('states')
    ])
  }

}

module.exports = Initial;

You are trying to do too much here. Checkout the documentation http://adonisjs.com/docs/2.0/migrations#overview

Is the idea to have use one schema per model?

No, you can have as many this.create or this.table methods inside up or down method.

So maybe I am overlooking something. If I use the example from the documentation, it works fine. But once I add additional this.create in up or this.drop/this.dropIfExists in the file, I start to have the same weird side effects that I mentioned before. It either does not drop all the tables or only adds one table to the database. I've tried in Postgres and SQLite.

Can you show your final migrations file?

Here it is. Maybe I am overlooking something.
'use strict';

const Schema = use('Schema');

class Initial extends Schema {

  up() {
    this.create('countries', function (table) {
      table.increments('id');
      table.string('abbreviation', 8).unique().notNullable();
      table.string('name', 50).notNullable();
      table.dateTime('deleted_at');
      table.timestamps();
    });

    this.create('states', function (table) {
      table.increments('id');
      table.string('abbreviation', 8).notNullable();
      table.string('name', 50).notNullable();
      table.dateTime('deleted_at');
      table.timestamps();
    });
  }

  down() {
    this.drop('countries');
    this.drop('states');
  }
}

module.exports = Initial;

This seems nice to me, let me try to re-produce the issue

Identified bug, will fix.


Ease the development workflow with ngrok and installing the app descriptor

Ngrok allows to use reserved subdomains (when you are a paying customer). To be able to use these in the development workflow you need to be able to pass in a configuration object to ngrok.
Moreover this takes away the need to reinstall the app descriptor every time you run the webpack build, so this should be considered optional.

Has been closed through PR #9


Extract all front-end SaaS folders out of dotmesh repo.

several stages:

[x] library for acceptance testing all the parts based on a commit to any part
[x] split repo into core (open source) and frontend, billin, communication - at this point we can hook github up to gitlab properly and make github the source of truth
[x] start doing weave cloud + flux

This is done now - I've documented everything in the ops repo


"input" method for noise/window removal

Type start and end datetimes

processing_window has been added as parameter/noise removal method to sprit.remove_noise(). This uses a list of two times (or a list of two-item lists) to specify intervals that should be used for processing. String times can be used (i.e., "14:14"), but it is more precise to use datetime.datetime objects or obspy.UTCDateTime objects.


[BUG] Impossible to use a gorilla/mux router as a server handler

Describe the bug
1. What are you trying to do?
I've successfully migrated most of our API's from the old http server in go-plugins to micro web. So far so good. We have two API's with a subscriber in it. Micro web does not support something like service.Server().Handle(service.Server().NewHandler(router). To solve that, we tried to use something like the code snippet at the bottom, resulting in the error in step 3. This approach has been working in the past when we used the http server from go-plugins, but not with the new grpc service in micro v2. Is this intentional or a bug?
I've tried to use the broker itself (we use nats as a broker) and that works, but I would love to use the old approach usingservice.Server().NewSubscriber. The function signature fn(ctx, msg) error is much more convenient than fn(event broker.Event) error.
2. What did you expect to happen?
API starting successfully.
3. What happens instead?
2020-07-15 19:04:40  level=error methodBuildVarsFuncoffunc(*mux.Router, mux.BuildVarsFunc) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodGetoffunc(*mux.Router, string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodGetRouteoffunc(*mux.Router, string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error Handleargument does not implement Streamer interface:http.Handler
2020-07-15 19:04:40  level=error HandleFuncargument does not implement Streamer interface:func(http.ResponseWriter, *http.Request)
2020-07-15 19:04:40  level=error methodHeadersoffunc(*mux.Router, ...string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodHostoffunc(*mux.Router, string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error Matchargument does not implement Streamer interface:*mux.RouteMatch
2020-07-15 19:04:40  level=error methodMatcherFuncoffunc(*mux.Router, mux.MatcherFunc) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodMethodsoffunc(*mux.Router, ...string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodNameoffunc(*mux.Router, string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodNewRouteoffunc(*mux.Router) *mux.Routehas wrong number of ins:1
2020-07-15 19:04:40  level=error methodPathoffunc(*mux.Router, string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodPathPrefixoffunc(*mux.Router, string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodQueriesoffunc(*mux.Router, ...string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error methodSchemesoffunc(*mux.Router, ...string) *mux.Routehas wrong number of ins:2
2020-07-15 19:04:40  level=error ServeHTTPargument does not implement Streamer interface:*http.Request
2020-07-15 19:04:40  level=error methodSkipCleanoffunc(*mux.Router, bool) *mux.Routerhas wrong number of ins:2
2020-07-15 19:04:40  level=error methodStrictSlashoffunc(*mux.Router, bool) *mux.Routerhas wrong number of ins:2
2020-07-15 19:04:40  level=error methodUseoffunc(*mux.Router, ...mux.MiddlewareFunc)has wrong number of ins:2
2020-07-15 19:04:40  level=error methodUseEncodedPathoffunc(*mux.Router) *mux.Routerhas wrong number of ins:1
2020-07-15 19:04:40  level=error methodWalkoffunc(*mux.Router, mux.WalkFunc) errorhas wrong number of ins:2
2020-07-15 19:04:40  level=error rpc Register: type Router has no exported methods of suitable type
2020-07-15 19:04:40.120833 I | rpc Register: type Router has no exported methods of suitable type

How to reproduce the bug:
If possible, please include a minimal code snippet here.
package main

import (
	"log"
	"net/http"

	"github.com/micro/go-micro/v2"
	"github.com/gorilla/mux"
)

type Handler struct{}

func (h *Handler) Hello(w http.ResponseWriter, r *http.Request) {
	log.Println("hello")
}

func main() {
	service := micro.NewService(
		micro.Name("go.micro.api.greeter"),
	)
	service.Init()

	handler := new(Handler)
	router := mux.NewRouter()
	router.HandleFunc("/greeter", handler.Hello)
	if err := service.Server().Handle(service.Server().NewHandler(router)); err != nil {
		log.Fatal(err)
	}

	// Run server
	if err := service.Run(); err != nil {
		log.Fatal(err)
	}
}

Environment:
Go Version: please paste go version output here
go version go1.14.4 linux/amd64

You need to use go-micro/web, not the top level go-micro service. What you're doing is attempting to register against an RPC server, not a http server.

So if I need to use a subscriber in an API with micro web, I have to create a broker and subscribe using that? Or am I missing another possibility in micro web?

Your first question is in relation to using grpc while also attempting to register a gorilla mux router with it. This wont work. Either use grpc or use a web server. They are two different things.
On the broker, using the server subscribe is only possible with a grpc server so you have to either make use of that or run two things for it.

Alright, thanks for the clarification.


Make sure we actually use swift-driver

In many cases, we're directly executing swiftc which means we are relying on the old driver. This switches us to calling swift-driver --driver-mode=swiftc instead if available.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

https://github.com/apple/swift/pull/61766
@swift-ci please smoke test

https://github.com/apple/swift/pull/61766
@swift-ci please smoke test

https://github.com/apple/swift/pull/61766
@swift-ci please smoke test

Doesn't look like swift-driver is present inside the toolchain installation directory?
--- bootstrap: note: Symlinking /Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-driver
--- bootstrap: note: Available executables: ['swift-api-extract', 'swift-build-tool', 'swift-symbolgraph-extract', 'clang', 'llvm-cov', 'swift-demangle', 'clangd', 'clang-13', 'swift-frontend', 'clang-cl', 'dsymutil', 'clang-cache', 'sdk-module-lists', 'swift-stdlib-tool', 'swift-api-checker.py', 'swift', 'clang++', 'swiftc', 'clang-cpp', 'llvm-profdata', 'swift-autolink-extract', 'swift-api-digester']

What happened to the integrated swift driver that was added last year, #2736, did that not work out? Seems a waste to include that when building SPM and then not use it.

What happened to the integrated swift driver that was added last year, https://github.com/apple/swift-package-manager/pull/2736, did that not work out? Seems a waste to include that when building SPM and then not use it.

I'm not 100% sure (cc @artemcm), but either way we cannot use it for manifest compilation / plugin loading since they happen separately from the build system.

I think my Swift PR might be incorrect and install swift-driver after building SwiftPM, so that's why it is missing here.

Yes, SPM is built and installed first because it is then used to build and install swift-driver, at least on linux and Android.

OK, I added a install-swift-driver before swiftpm in the preset, but it doesn't seem to have affected things a whole lot? Still doesn't seem to be present in the installation directory.
--- bootstrap: note: Symlinking /Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-driver
--- bootstrap: note: Available executables: ['swift-api-extract', 'swift-build-tool', 'swift-symbolgraph-extract', 'clang', 'llvm-cov', 'swift-demangle', 'clangd', 'clang-13', 'swift-frontend', 'clang-cl', 'dsymutil', 'clang-cache', 'sdk-module-lists', 'swift-stdlib-tool', 'swift-api-checker.py', 'swift', 'clang++', 'swiftc', 'clang-cpp', 'llvm-profdata', 'swift-autolink-extract', 'swift-api-digester']

The order of the flags is irrelevant, as SPM is used to build swift-driver, so it is always built and tested before.

The order of the flags is irrelevant, as SPM is used to build swift-driver, so it is always built and tested before.

Ah interesting, that seems unfortunate. We're actually already building the driver as part of the first bootstrapping stage, maybe we can just change things to re-use the built products from that.

Only the macOS CI builds the early swift-driver, the linux CI doesn't as it doesn't have a prebuilt Swift compiler installed.

So I think a viable path here could be:

add the ability to specify a custom swift-driver (@compnerd also asked for this) and point it to the one anyway produced by building swift-driver with CMake during bootstrap
tell the driver to use the swiftc we're already using (might already be happening)

@swift-ci please smoke test

@swift-ci please smoke test

Probably time to abandon this, actually. Failures on self-hosted are proving that even explicitly using swift-driver doesn't help us:
Using compiler command line: ["/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-driver", "--driver-mode=swiftc"]


[PSA] Read this before creating an issue

Hi all!
As you might noticed the bot started to work again.
However thing are more complicated then they've been.
I would like to ask you NOT to create any how to / help issues.
Those issue's will be closed without further comment.
Please be patient, and give us time to update the wiki.

Add a few when new noob posts arrive I will reference this post so you can close them.

Add a few when new noob posts arrive I will reference this post so you can close them.

Do we know anything about how long time it will take untill the wiki is updated?

working on it if you can help out it will take less time ;)

@brantje Should questions be asked here instead? Well, at least for the time being.
cc: @brambi

https://github.com/PokemonGoF/PokemonGo-Bot/issues/2808

@brantje TL;DR we need to compile encrypt.dll base on the code hosted on http://pgoapi.com/ ?

@cicatiello You can get the compiled version from the Slack group though. Not sure how I got the invitation link to the group, but I got my copies from there.

@BobbyWibowo shouldn't be easier to just throw them on dev branch? legal issue ftw?

@cicatiello One of the dev mentioned that they weren't going to ship it with the repo. Can't remember the reason though, lol

@BobbyWibowo this is the link: https://pokemongo-bot.herokuapp.com/
and you can't get it as far as I know (at least not for linux) you need to create it yourself. Oh and I would advice @cicatiello to run a docker in windows, much easier and cleaner and saver :)

@nivong If you're already registered into the Slack group, you can browse all uploaded files from here: https://pokemongo-bot.slack.com/files and you can find encrypt.so, encrypt.dll and encrypt64bit.dll.

@nivong well if there is anything i can help with just shout :)


example in assertion overview document

In configuration > Assertions & metrics > Overview #python
the example goes
import sys
import json

output = sys.argv[1]
context = json.loads(sys.argv[2])

print(f'Received {output} with variables {context}')

return {
  'pass': True,
  'score': 0.5,
  'reason': 'Some custom reason',
}

but it should like
import sys
import json

output = sys.argv[1]
context = json.loads(sys.argv[2])

# print(f'Received {output} with variables {context}')

print(json.dumps({
  'pass': False,
  'score': 0.5,
  'reason': 'Some custom reason',
}))

or it can not be run by copy & paste
I'm not sure if this minor issue should be opened here or there is some other way to do it. please let me know.

Thanks for catching this!  Fixed in a6259f5ac9ea37eb9c370ae5a632c1c64f08410b


Use lingua for language detection?

Just as a suggestion, this package was recently published: https://github.com/pemistahl/lingua-py
Since it's language detection capabilities seem to be very good it could replace the existing, api-based language detection.

@juligreen thanks for the suggestion. However, I'm trying to keep the package simple, so I would rather not add dependencies for now. If the community required this feature then maybe we can do this ;) but now I think it's not necessary


[azopenaiassistants] Regenerating to work with the new assistants v2 (beta) endpoint

Regenerating based on the Assistants V2 update (it's beta, just v2 of their beta).
The non-autogenerated code is there to work around the way that union translates to swagger - it typically produces the leaf objects but the union itself is empty. model_custom.go are manual representations of the unions, themselves.
I've also addressed some linter errors, removing log.Fatal's from the examples.
NOTE: this is just to get some of the simpler-to-review changes out of the way.


Rags add vlan mismatch probe

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


This issue will be closed after 24 hours if no followup action is taken.

[This comment is auto-generated. ref=notemplate]

@ping
No, bug, but I'd like to ask a question, do you know the firewall in China? It organized our website to visit foreign countries. So we need a proxy to visit a website abroad. I use shadowsocks. Can I use your library to access API through this agent?


blueman: 2.0.8 -> 2.1.1

Motivation for this change
Works for me™, but could use some additional testing. Closes #60413.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @abbradar

Changes: https://github.com/blueman-project/blueman/blob/2.1.1/CHANGELOG.md

@GrahamcOfBorg build blueman

Thanks.


Not setting multiple headers

Following the pattern outlined here of setting multiple headers works in local node environment: https://github.com/remix-run/remix/issues/231
   return json(
            { success: true },
            {
                headers: [
                    ["Set-Cookie", await commiSession1()],
                    ["Set-Cookie", await commiSession2()]

                ]
            }
        )

However, when running using the createRequestHandler from this package (only tried using AWSProxy.APIGatewayV1)  only the last cookie is set.
Looking at the code it may be because you are not returning multiValueHeaders, just headers
https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html

@MattyBalaam hmm I would expect remix to return a valid Headers object, which would mean it should return the following
HeadersList {
  cookies: [ 'cookie1=value1', 'cookie2=value2' ],
  [Symbol(headers map)]: Map(1) {
    'set-cookie' => { name: 'Set-Cookie', value: 'cookie1=value1, cookie2=value2' }
  },
  [Symbol(headers map sorted)]: null
}

👉 https://replit.com/@wingleung1/UnripeSunnyProgrammers
But what I receive from remix is an object containing an array value in headers, which is not compliant with the apigwV1 model
headers: {
  'content-type': 'text/html',
  'set-cookie': [ 'cookie1=chocolate-chip', 'cookie2=oatmeal' ]
}

Created a PR with a workaround 👉 #15
meantime, could you try using comma delimiters?
   const session1 = await commiSession1()
   const session2 = await commiSession2()

   return json(
            { success: true },
            {
                headers: {
                    "Set-Cookie": `${session1}, ${session2}`
                }
            }
        )

🙏  merged to develop and published a beta version 👉  1.3.0-beta.1


concurrent map writes panic from Buildkit

I randomly got this panic. From an initial glance, it's not clear to me that it's due to cloak code, may just be a rare buildkit bug, but needs another more thorough look: https://gist.github.com/sipsma/21023c889b80df59cc3fdcd47630921e

I haven't hit this ever again. It could still be an issue but I'll close for now since it's not really actionable. If anyone hits it again they should still be able to find it searching concurrent map writes and this can be reopened.


Fix top request cmd

fix #4

@mohtork Please create an issue for the bug so we can track it :)
Thank You!

@mohtork Please create an issue for the bug so we can track it :)
Thank You!

LGTM


Moved the metadata into setup.cfg.

Added pyproject.toml.
Renamed console_scripts because their names are too generic to have this package installed into system.
Versions are now fetched from git tags.

@KOLANICH can you also add your DCO signoff? This was an informal requirement which was not consistently applied until now... this way I can then merge.

This has been merged after a rebase.
Thanks!

Fat fingers!
Not merged yet. Sorry for the noise

@KOLANICH, do you still plan to address these change requests?
@pombredanne, are these changes still up-to-date?

@pombredanne, are these changes still up-to-date?

I think they are... but your call to verify this.

Thanks @KOLANICH for updating this! :)
Removing setup.py seems like a breaking change, though, and CircleCI workflows also depend on it. I think keeping a minimal setup.py as Philippe suggested here would be the best option for now.

Thanks for the update, @KOLANICH!
CircleCI is still broken, though. Do you plan to look into this?

@pombredanne, this still has a blocker from you, would you mind to revisit/lift this? :)

just noting this is not mentioned at as belonging in project table at https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration

That doc mentions only setuptools-specific configuration. The most of pyproject.toml is the standardized one for all the major backends except poetry according to PEP 621.

And if we're renaming these, which IMO is a good idea as these names are too generic, can we please change "convertor" to "converter" in order to be using the main word in the dictionaries.

To be honest, convertor feels better for me and I guess for people too: searching in Bing (Google doesn't give out this info at least when JS is disabled) reveals:
convertor 566 000 000 results
converter 564 000 000 results
The rest of suggestions are implemented, thanks.

Please see https://github.com/spdx/tools-python/pull/362


Require vendor/autoload.php of plugins if it exists

1. Why is this change necessary?
If a plugin is not installed via composer but still comes with own dependencies, currently the plugin has to take cake to require this dependencies itself. In particular this means it has to
require its ownvendor/autoload.php.
This has two disadvantages:

This code is duplicated in every plugin.
The plugin itself has to decide whether it has to load its vendor/autoload.php. In case the plugin is managed by composer, there is no need for the plugin to require its vendor/autoload.php. The plugin can currently not decide this because it has no access to the managed_by_composer flag.

2. What does this change do, exactly?
This PR changes the method \Shopware\Core\Kernel::registerPluginNamespaces to automatically load the file vendor/autoload.php of each plugin if present instead of registering only the namespaces listed in the plugin's composer.json.
Registering the namespaces this way has the advantage that also the namespaces of all shipped dependencies are registered.
In case there is no vendor/autoload.php bundles with the plugin, the namespaces from the plugin's composer.json are still loaded.
3. Describe each step to reproduce the issue or behaviour.
N/A
4. Please link to the relevant issues (if any).
N/A
5. Which documentation changes (if any) need to be made because of this PR?
N/A
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-4523
Please use this issue to track the state of your pull request.

This should be also deactivateable. In Shopware 5 we had sometimes library conflict issues and required the autoload only in this specific case.

Could you tell me an example case where this should be possible? If you have library conflicts you still have the possibility to install the plugin via composer or, as a plugin vendor, just to not ship the vendor/autoload.php.

Core ships Guzzle 5, Plugin have to use a payment library which requires Guzzle 6.
Global require of plugin breaks components which uses guzzle 5. So a fix was to load the custom autoload.php when the own controller was called.

And your case is not valid. A plugin don't need to know is it managed_by_composer.
Little example :wink:
https://github.com/FriendsOfShopware/FroshProfiler/blob/master/FroshProfiler.php#L18-L20

@shyim what about downloading the packed plugin from the store (plugin brings vendor directory) but then the shop manager installs it via composer. now the plugin dependencies are in the root vendor directory and also in the plugin. just checking if the autoload file in the plugin is there, is not enough

When you install it using composer, the dependencies are in the vendor folder of the project and not in plugin

but if you ship the plugin with the vendor directory in the plugin, because you have uploaded it to the store. did you even read my message? :smile:

Never mind. Solved all questions

I close this PR as the suggested option to automatically load the autoload.php leads to more complex problem I did not suspect when opening this PR.
One of the problems is the following: When multiple plugins bring in the same dependency then it is not assured that the newest dependency is loaded. Therefore I think it is better for every plugin to do its dependency management itself.


Update please, my mod has no dependencies.

Baser it on information in the forum thread iirc but sure we can remove it. But you need to remove the entire depends stanza not just the things in it.,

I just fixed that. How can it be added to CKAN? It won't show up yet.

Should show up in a while now


Cache search can leak information from other sessions.

As far as I can see, there is no consideration for partitions for the cache search. Each cached response could be grounded in and contain information supplied by the user in the original session. This could then be returned to a different session.
Session A
User: Hello, my name is James
Assistant: Hello James
U: What's my name?
A: Your name is James
Session B
U: Hello My name is Mark
A: Hello Mark
U: What's my name?
A: You name is James (Cached response)

@qondoraudun That scenario you describe would not happen.
The cache operates over the context window. To get a cache hit, subsequent users have to follow the same set of prompts.
That said, the cache is shared across sessions. That is on purpose as cache values have limited use if they can only be used by the same user.
If a per-user cache is what is desired, this is not difficult to implement. Just as with the chat history itself, the user name would need to be a part of the data model. In fact it would be the partition key, then used as a filter predicate with the vector query.
Thanks.


HTML colour fixes

Assign colours to nodes based on the category and the node colour support is much wider.
The colour of the nodes with make it easy for the children to remember what node belongs to which category.

Looks great.


mutual TLS between Traefik and an upstream service

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
I would like to enable mutual TLS between traefik and an upstream service. As an example, suppose in k8s there is ServiceA with a corresponding traefik ingress route. I would like the ability to specify a client cert for mTLS between traefik and ServiceA. I read the docs and didn't see anything on this topic, but maybe its possible with the current functionality which would make this a question instead of a feature request. Thank you.

duplicate of #7076


Error: Unable to init from given url

I have the same problem that is mentioned in #283. See https://github.com/Intervention/image/issues/283#issuecomment-495814565.

Have you found a solution?

Asset helper returns a URL. You don't want a URL when working with files, you want a PATH that the filesystem can understand

try storage_path/public_path instead

$img = Image::make(storage_path('assets/images/sample.png'));

Adjust your path to suit, I doubt it is storage/app/public/profile/sample.php because that's a PHP file
Take a look at the answer here

The integration of the option to read data directly via URLs was a mistake. The task of this library is image manipulation. Reading data via HTTP should be done by a corresponding client. For this reason, Intervention Image Version 3 does not support reading URLs.


adding integration tests to the Rakefile

Pull Request Checklist
This adds the integration tests to the Rakefile to minimise the chances of people forgetting to execute them.
General

[x] Update Changelog following the conventions laid out on Keep A Changelog

[ ] Update README with any necessary configuration snippets

[ ] Binstubs are created if needed

[x] RuboCop passes

[x] Existing tests pass

New Plugins

[ ] Tests

[ ] Add the plugin to the README

[ ] Does it have a complete header as outlined here

Purpose
Known Compatablity Issues

looks like travis is failing but this works on my computer:
       Finished converging <default-ubuntu-1604> (1m0.75s).
-----> Setting up <default-ubuntu-1604>...
       Finished setting up <default-ubuntu-1604> (0m0.00s).
-----> Verifying <default-ubuntu-1604>...
       Preparing files for transfer
-----> Installing Busser (busser)
Fetching: thor-0.19.0.gem (100%)
       Successfully installed thor-0.19.0
Fetching: busser-0.7.1.gem (100%)
       Successfully installed busser-0.7.1
       2 gems installed
       Installing Busser plugins: busser-bats
       Plugin bats installed (version 0.3.0)
-----> Running postinstall for bats plugin
       Installed Bats to /tmp/verifier/vendor/bats/bin/bats
       Suite path directory /tmp/verifier/suites does not exist, skipping.
       Transferring files to <default-ubuntu-1604>
-----> Running bats test suite
 ✓ Check process count, OK
 ✓ Check dummy1 interface bytes in, CRITICAL
 ✓ Check ping, OK
 ✓ Check container count, OK
 ✓ Check container cpu throttle, WARNING

       5 tests, 0 failures
       Finished verifying <default-ubuntu-1604> (0m11.84s).
       Finished testing <default-ubuntu-1604> (1m50.70s).
-----> Destroying <default-ubuntu-1604>...
       ==> default: Forcing shutdown of VM...
       ==> default: Destroying VM and associated drives...
       Vagrant instance <default-ubuntu-1604> destroyed.
       Finished destroying <default-ubuntu-1604> (0m5.17s).

I am still hesitant to merge this until the tests pass in travis.

fixed :)

@luisdavim can you rebase master?

Done :)

Hi, any plans on merging this? I have a bug fix I would like to push but It's based on these changes...

@luisdavim the plans to merge this are tied directly to getting all the tests working in #2 hopefully this weekend I will refactor it to be a bit easier to test all the ruby versions in kitchen. I still have a few tests that are failing for reasons I do not understand yet so I commented them out for the moment.

@luisdavim sorry last rebase here (I will not merge anything until you get this good so you don't have to again)


fixing documentation after gitbook

Codecov Report
Base: 61.88% // Head: 61.88% // No change to project coverage :thumbsup:

Coverage data is based on head (2ed2c20) compared to base (d160be3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #410   +/-   ##
========================================
  Coverage    61.88%   61.88%
========================================
  Files           79       79
  Lines         2545     2545
  Branches       318      318
========================================
  Hits          1575     1575
  Misses         956      956
  Partials        14       14

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


options.uri isn't documented and is extraneous

Right now for cross-domain requests you have to pass options.uri which, for my use-case, is always the same as the url that I'm requesting. So why not remove options.uri and just check against url instead?
Here's a PR that makes this change.
Another approach would be to default options.uri to url and to let the user set it to something else if they need to. I don't see why you would ever need to do that, but I'm happy to amend the PR if there's an argument for it.

That's entirely an accident.  Please feel free to submit a pull request to update this.

Thanks for the fast response!


mavros: 0.17.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository mavros to 0.17.0-0:

upstream repository: https://github.com/mavlink/mavros.git
release repository: https://github.com/mavlink/mavros-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 0.16.6-0

libmavconn
* rebased with master
* Contributors: francois

mavros
* update README
* rebased with master
* Fixed ROS_BREAK
* Updates for ROS_BREAK and code style
* Nitpicks and uncrustify
* Updated frame transformations and added odom publisher to local position plugin
* Contributors: Eddy, Vladimir Ermakov, francois

mavros_extras
* rebased with master
* ran uncrustify
* removed duplicate include
* use MarkerArray for vehicle model
* Updated frame transformations and added odom publisher to local position plugin
* Contributors: Eddy, francois

mavros_msgs
* rebased with master
* Contributors: francois

test_mavros
* rebased with master
* Contributors: francois

Your PR reverts the comment in the distribution file. Please update the line to stay the same.

@tfoote

@tfoote We need to get this change in the newest rosdistro release to the users asap (ros-infrastructure/rosdistro@a94e9fe43f03828a9af88200807df259b7f2e1ed).
@wjwwood FYI

Ok, @ros/rosdistro-maintainers Please hold pull-requests
We're close to a sync, (~15 arm jobs left) we need to get the sync out with a new python-rosdistro

Ok, seems easier wait for tool update and redo PR.


Remove redundant package references

Directory.Build.targets contains:
    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
    <PackageReference Include="Microsoft.DotNet.Analyzers.Compatibility" Version="0.2.12-alpha" PrivateAssets="All" />
    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="All" />

... but we still have the latter two references in our project files. We should make sure that each package reference is only in one place for any build - and ideally put the ConfigureAwaitChecker in Directory.Build.targets too

This was fixed in #8490.