Allow for Saga Assocication Value to map to data outside of payload

Currently, association properties are limited to the message payload. In certain cases, it may be useful to be able to map an association value to a meta data property instead (e.g. when listening to a specific event, based on correlation data).
To allow for this in a backward compatible way, a new (optional) property should be added to the @SagaEventHandler annotation: Class<? extends AssociationResolver> associationResolver(), which defaults to  PayloadAssociationResolver. The resolver decides where to try to retrieve the value defined in the String associationProperty() from.
This would allow the use of a MetaDataAssociationResolver when the association property should map to meta data.
The interface AssociationResolver should provide 2 methods:
void validate(String associationProperty, MessageHandlingMember handler);

Object resolve(String associationProperty,  EventMessage<?> message, MessageHandlingMember handler);

Implementations must define a no-args constructor.
The framework may use a single instance of the AssociationResolver for multiple handlers.

I also find value in having this feature.
I was able to modify SagaMethodMessageHandlingMember to check the message's metadata if it can't find the association property name in the payload.
But if you were to have an AssociationResolver, can you detail how validate and resolve would work? Is it necessary to pass in the MessageHandlingMember? Will an AssociationResolver wrap a PropertyAccessStrategy?


Scale the graph validator

Problem
Since only one instance of the graph validator is running, graph validation requests can get stuck in "Pending" for a long time if one run is taking a long time. This is poor UX and the user can actually request multiple graph validation runs leading to a backlog for the same submission. The latter is not so much an issue as the messages will be discarded when the graph validator sees that the submission is in "Validating" state, although there is a chance of some repeated runs.
Solution 1 (to be decided)
One thing we could do is scale-up the graph validator. However, I think this might be expensive and probably require a neo4j cluster to keep up.
Solution 2 (done)
Another simple option is to introduce a new "Requested" graphValidationState. When in this state, the user cannot request another graph validation run. We should alter core so that core sets the graphValidationState to "Requested" and also alter graph validator so that it can only do runs on those that are in the "Requested" state. Graph validator will then request the transition from "Requested" to "Validating". At least a "Requested" state tells the user something is happening and we can give a message like "This could take some time"
We can do both solutions 1 and 2
See https://docs.google.com/document/d/1fsN_2Ugx-ZXgYOgXlqpUYR8n6sHku9pTSVTz3C5-MZg/edit

@ipediez to test today on staging

Solution 2 has been done and is now in prod. We might not need to do solution 1 depending on usage - we will do #539 first to check requirements


Rename a dashboard

Description
Hi,
with the 0.14.0 version, it(s possible to manage users and dashboards. Thanks for the job done 👍 .
I able to create dashboard but how rename it ?
Best regards
Priority
Low (Nice-to-have)

Hi,
We are currently missing the controls for that in the interface along with importing and exporting a config.
You may however rename the file in the config folder that needed to be mounted which will provide the same effect.


Introduce Kryo Serializer to Streamlet

Currently Streamlet relies only on Java serialization which has very bad performance. This pr allows topologies to use Kryo serialization.

@jerrypeng


Typo in the description of an error code 0x803F6102

The present description for error code 0x803F6102:
The specified add-on could not be found. The add-on may no longer be available in the Store, or your might have provided the wrong Store ID for the add-on.
Proposed description:
The specified add-on could not be found. The add-on may no longer be available in the Store, or you might have provided a wrong Store ID for the add-on.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7acb58af-680c-17bc-2233-4ef5b629fc54
Version Independent ID: 3208ab40-b3a8-d0cb-ec96-fe0a54bae300
Content: Error codes for Store operations - UWP applications
Content Source: windows-apps-src/monetize/error-codes-for-store-operations.md
Product: uwp
Technology: publish
GitHub Login: @hickeys
Microsoft Alias: hickeys

Thank you, corrected.


Use Assignment Expression (Walrus) In Conditional

Suggest accepted, so merging branches.

please don't spam this ai garbage anywhere again


Receiving Using z.date() within output schema is forbidden. error, but using ez.dateOut() already

Hi! First - fantastic job with this library, it's been a delight to work with so far.
I recently tried generating some OpenAPI documentation for the first time and ran into the following issue:
A [OpenAPIError]: Using z.date() within output schema is forbidden. Please use z.dateOut() instead. Check out the documentation for details.

but all of my inputs/outputs are already defined using ez.dateIn() and ez.dateOut(). Grepping my repo for z.date() results in no matches. I'm using pretty much the exact same configuration for the yaml generation as is in the documentation:
  new OpenAPI({
    routing,
    config,
    version: '0.0.1',
    title: 'Flock API',
    serverUrl: 'https://flockhealth.com',
    composition: 'inline'
  }).getSpecAsYaml();

Any ideas?

Hello @topherauyeung ,
thank you for reaching out.
There is a schema walker under the hood that iterates your routing and schemas and calling depicting functions depending on its ._def.typeName. The error message you get is located inside depictDate function and is only possible to be thrown in schema._def.typeName is ZodDate. Perhaps you have some custom schema that inherits ZodDate somehow, or you're instantiating z.date() with some arguments that make grepping unsuccessful.
Consider the following:

Inspect the tracing logs of the thrown error. The library contains sourcemaps and perhaps it could reveal from which function it's getting into depictDate().
Consider instantiating new OpenAPI() with a customized routing parameter where you gonna be adding your endpoints manually one by one, between the attempts of generating the documentation. This will help you to identify the problematic endpoint.

Meanwhile I'll try to improve the informativeness of OpenAPIError to eliminate the confusion.
Let me know if you find something.

I managed to recall that I have a branch where I began working on making those error more informative.

By the way, @topherauyeung , please also check the schema used in your ResultHandler.

I'm about to release a new version that might help you to identify the reason for that error,  @topherauyeung

🚀 More informative error messages released in version 10.5.0.
Please check it out, @topherauyeung , and let me know if it's helpful.

Ah! Thanks so much. I actually think I may know the issue now that you've pointed me towards custom types. I am using a Prisma-To-Zod schema generator for some of my output types and I'm betting it's coming from there. Will report back when I investigate tomorrow!


If I specify the timestep, do I need to adjust max clip range?

I don't understand the last paragraph of the notes. If I specify the timesteps during training, do I need to change the default max clipping range of 1?

It is best to always supply the clipping range irrespective of whether you are on training or evaluation mode. The infinite timesteps clipping range is non optimal.
Even for relu, it is advisable to simply pass 2^(1/T) as max.

Thank you. Looking through the code and reading your response made the issue clear.


Local Clojure REPL starts shadow server?

I have a full-stack deps.edn+shadow-cljs project (with shadow-cljs deps handled using a cljs alias in deps.edn). When I start configure and add Clojure REPL of "Local" type I would expect it to start the Clojure CLI with some configurable aliases. Instead is executes npx shadow-cljs server, while not entirely unhelpful, is somewhat surprising.
I would be good with some docs on what is actually on offer here. Does it support deps.edn, Leiningen or what?
I'm on macOS 11.7.10 and IntelliJ IDEA 2023.3.4 (Ultimate Edition).

@gerdint we support all major build deps, but we don't support specify aliases yet, it should not be hard, I can take a look soon at this.


fio: Adding fio engine

This first commit is adding a first cmdline engine_module to execute a
single fio command line.

This commit is not functional yet but set the base of the logic to parse
the engine.

was the merge intentional @beorn- ; also, FYI, the CI is blocked, see #69 for the fix.

"was the merge intentional @beorn- ?" -> a rebase would have been probably better

No it clearly wasnt :x

Trying github's "update with rebase" instead.


t:slim x2 - Unhandled combination of basal change types

When uploading from her t:slim x2 pump on fw Carlsbad v6.4 my partner is receiving the error "Unhandled combination of basal change types"
This appears to be coming from the buildBasalRecords(data, records) function in tandemDriver.js.
The BASAL_CHANGE_TYPE_FLAGS enum appears to be missing change type 128 (0x80) as seen in this record:
index: 33740
header_id: 3
header_ts: 421666628
header_log_seq_no: 33740
header_spare: 33693
rawTimestamp:<PHONE_NUMBER>000
jsDate: Wed May 12 2021 10:37:08 GMT+0100 (British Summer Time) {}
deviceTime: "2021-05-12T09:37:08"
command_basal_rate: 2.8
base_basal_rate: 1.4
max_basal_rate: 3
idp: 0
change_type: 128
name: "Basal Rate Change Event"
change_types: []

As far as she knows this record was a result of changing her max basal rate while running a temp basal that was greater than the old max. Increasing the max rate uncapped her temp basal rate, making it jump from 2.0 (previous max) to 2.8.
It's possible this is not the cause, but the timing lines up, and the reasoning seems to be sensible.

Thanks for the great issue report @eksime ! Change type 128 is not documented in the Tandem spec, valid values are 0-127. I'll reach out to them and try to find out what's going on.


Add changelog / milestone for the features released across all the repos.

Per our last(May) community meeting, it will be good to have a changelog/ milestone in the central repo to document what has been added.

done by @allisonsuarez


HDDS-9844. [hsync] De-synchronize write APIs

Basing this on master branch since it is not confined to hsync change.
What changes were proposed in this pull request?
synchronized keyword has been added to write/hsync methods in HDDS-7907 to ensure correctness. But it is deemed to reduce write/hsync throughput at this point.
This PR aims to reduce blocking by immediately returning the future rather than waiting on it to return to allow write/hsync to interleave while ensuring correctness. (Submit the request and return immediately.) This inevitably involves some refactoring.

[ ] Finish error handling migration.
[ ] Refactoring.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9844
How was this patch tested?

[ ] All existing tests involving key stream write/hsync/close shall pass.

So far the draft only has the necessary changes for hsync() but not others like write() yet. But I would like some feedback on whether this is the cleanest way to go. Then I will make the changes on others the same way. ptal @szetszwo @jojochuang @kerneltime @duongkame

Closing this one in favor of an upcoming new PR of the same jira ID that targets the feature branch.


[IMPROVEMENT]  In cursor

What improvement are you suggesting?
As this website is a kid friendly website I think a custom cursor should be there like a pencil or something related to the website
Why should make this improvement?
If the cursor looks like a ruler or pencil, users will feel more connected to the content.
How can we make these improvements?
Changing the CSS I already finished doing
Additional Context
Please assign me this under GSSoC'23

Please assign me this under GSSoC'23

@saiful64 can you share more detail about the new cursor design you want to implement? Also, provide a prototype/sample of the cursor design you want to add.
I am assigning this issue to you but before you start coding, provide a prototype/sample design of the cursor.

There is a PR #94 solving a similar issue.


the big fat initial todo whiteboard

Whiteboard
I'll clean these up and organize them into seperate issues later.

[ ] uequicklaunch (ueql) check filename for spaces
[ ] Ueql - implement error handling
[ ] ueql - switch Statement using 'call' - for handling of type of context click and for errors
[ ] ueql - simplify code by setting up var strings before doing the actual work
[ ] Ueql - something to ponder: doing this in scooterutils will let is know where the engine is located at install-time
[ ] Ueql - get this in github
[ ] ueql - document unc path issue
[ ] ueql - windows only
[ ] Ueql - add icon
[ ] Ueql - add a link to reg file docs from microsoft
[ ] use at your own risk

These reg files set up (or remove) registry entries for launching a batch file from the
right-click context menu in Windows File Explorer.
The launched batch file creates an Unreal uproject file either in the current directory, or
within the selected directory, and immediately launches unreal (if multiple versions are installed,
the user is prompted for which build to open)
If a uproject file already exists, it will not be overwritten, but will be opened directly.

[ ] TODO - add a list of all the registry keys that are created/touched, so that they can be found manually if needed
[ ] include a description of the difference between what this launches and what's enabled/setup in a default blank game template (lumen, modeling tools, etc.)

these notes were added to the project todo


Edit codeowner permissions

Reduces our (the grafana team's) code ownership to just the github files, the go code, and the frontend datasource code. Hopefully this improves the Twinmaker team's development experience.
Notes:
According to this I'm fairly sure the un-owned code will not have us as code owners and thus will not require our approval to be merged. I can add other files if we think that we should be controlling access to them.

It's cool we're able to do this! Does this mean theoretically any community member will be able to merge without approval? I guess it's not a huge issue since only we can release the plugin, but doesn't this mean things might slip through the cracks more easily and potentially cause a security issue?
Would it be possible to add the Twinmaker team as code owners of other files? Though this would probably be more maintenance work in the long run

My understanding is that you need to be an approved contributor to merge, and we have main set to require approvals. We have the Twinmaker team members as outside contributors to the repo, which is why they have permissions. We could add them as code owners of other files but that would probably be wordy, since they aren't in a grouping of any sort (and I don't think we can group them)

My understanding is that you need to be an approved contributor to merge, and we have main set to require approvals. We have the Twinmaker team members as outside contributors to the repo, which is why they have permissions. We could add them as code owners of other files but that would probably be wordy, since they aren't in a grouping of any sort (and I don't think we can group them)

Didn't know this! Makes sense, I think this PR is then enough 🚀


Feature Request - Profile / Workspace - Allow avatar editing via cropping, rotation and zooming

TODO:

[x] Save image (iOS/android)
[x] Save image (Web)
[x] Add prototypes & JSDOC
[x] Organise imports
[x] Add Spanish translation
[x] Add screenshots
[x] Write tests & Check PR template checks

Details

Fixed Issues

$ #6301
Tests

[x] Verify that no errors appear in the JS console

[x] Test image crop with gallery image

Open Profile page
Press on avatar
Press on "Upload Photo" & "Choose from gallery"
Select image
Verify that the selected image was opened
Zoom the image using the slider below image & verify that image scales appropriately
Pan image by sliding a finger over the image & verify that it works
Press on the rotate button & verify that it rotates the image by 90 degrees
Press on the "Save" button
Verify that image is the same as it was in the preview

[x] Test image crop with gallery image

Open Profile page
Press on avatar
Press on "Upload Photo" & "Choose from gallery"
Select image
Verify that the selected image was opened
Zoom the image using the slider below image & verify that image scales appropriately
Pan image by sliding a finger over the image & verify that it works
Press on the rotate button & verify that it rotates the image by 90 degrees
Press on the "Save" button
Verify that image is the same as it was in the preview

[x] Low-resolution image test
Preconditions: You have an image with a resolution lower than 80x80

Open Profile page
Press on avatar
Press on "Upload Photo" & "Choose from gallery"
Select image (<80x80px)
Observe the error message: Please upload an image larger than 80x80 pixels

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is

[x] If a new CSS style is added I verified that:

[x] A similar style doesn’t already exist
[x] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

[ ] Verify that no errors appear in the JS console

[ ] Test image crop with gallery image

Open Profile page
Press on avatar
Press on "Upload Photo" & "Choose from gallery"
Select image
Verify that the selected image was opened
Zoom the image using the slider below image & verify that image scales appropriately
Pan image by sliding a finger over the image & verify that it works
Press on the rotate button & verify that it rotates the image by 90 degrees
Press on the "Save" button
Verify that image is the same as it was in the preview

[ ] Test image crop with captured photo

Open Profile page
Press on avatar
Press on "Upload Photo" & "Take a photo"
Capture photo
Verify that the selected image was opened
Zoom the image using the slider below image & verify that image scales appropriately
Pan image by sliding a finger over the image & verify that it works
Press on the rotate button & verify that it rotates the image by 90 degrees
Press on the "Save" button
Verify that image is the same as it was in the preview

Screenshots

Web

https://user-images.githubusercontent.com/44551710/182706069-4958b3e9-97cf-4477-adc1-040152b4bf71.mov
https://user-images.githubusercontent.com/44551710/182706060-d7dde0f4-018f-4318-89a4-f5415f7482ea.mov
Mobile Web

https://user-images.githubusercontent.com/44551710/181266577-d992f4af-d3b3-4d61-ab66-0c0d20fb3a4e.mov
https://user-images.githubusercontent.com/44551710/181266650-29afb618-8fba-4fa7-a0b9-e58c2c80341e.mov
Desktop

https://user-images.githubusercontent.com/44551710/182706107-27362437-c461-431f-a200-23e4f2d0ddbe.mov
iOS

https://user-images.githubusercontent.com/44551710/181266030-1cbf2766-9b11-44bf-a3b3-66419c1d85e2.mov
Android

https://user-images.githubusercontent.com/44551710/181265937-dc465294-d547-4fa9-ae36-bfb80b2ee550.mov

I have read the CLA Document and I hereby sign the CLA

Thank you for the review @tgolen @parasharrajat and your comments/suggestion!
Based on your them, I have improved a bit of code & comments. Also, I've resolved comments about fixing typos & formatting, to reduce their count overall. Hope you don't min that.
I've added the ES translation that @mallenexpensify provided in the #6301.
Now I'm planning to resolve conflicts and add the improvement that @parasharrajat suggested in https://github.com/Expensify/App/pull/8511#discussion_r853397842.

Any update.

@parasharrajat pull request is ready for review

Odd: When we click close on the modal, the image area immediately goes blank white which looks odd. I think it would be good to just keep the image as it is and destroy the whole state when the modal is closed.

I will test the rest later.

BUG: Animation Entering/Exit is different from other models in the app on Native. Check Attachment Preview Modal for animations.
Bug:  images smaller than the size of the crop area has a bad preview.

Issue: On the web, Upload the attached image. Zoom 50% on the scale. Rotate a few times. Sometimes, a white blank area is visible, and dragging the image behaves strangely.
@parasharrajat can you provide more details/video recording? I can't reproduce this issue. And what does "behaves strangely" mean?

Bug: images smaller than the size of the crop area has a bad preview.
There is nothing that we can do. The output image can't be bigger than the input.

BUG: Animation Entering/Exit is different from other models in the app on Native. Check Attachment Preview Modal for animations.

Hmm, I haven't seen such a requirement. Also, on design, I don't see a native modal either.
Would you like to add a new requirement? Notice, that it may be tricky(may need some time)

Odd: When we click close on the modal, the image area immediately goes blank white which looks odd. I think it would be good to just keep the image as it is and destroy the whole state when the modal is closed.

Almost finished implementing that, I will push it tommorow

I will add the requested details later. A few of the details are always missing from OP. We cover them during reviews. These things are often common throughout our app. Such as animations and rounding sizes, font sizes, styles, etc.
I will request the designer to review when this is functioning as needed.

@parasharrajat ready for review

We need to decide the behavior when image being uploaded is smaller than the container size in dimensions. What do you suggest? Currently it seems fully-scaled.

I'd suggest keeping existing behavior because, in my opinion, it is what the user expects. Because if we would display an image on its original size, it would be really difficult to pan/scale and for us to calculate accurate crop area. Also, other avatar croppers (f.e. on LinkedIn) have the same behavior as we currently have.
If you insist on modifying, I would suggest adding minimal image height/width validation (f.e. 80px80px). @parasharrajat What do you think?

JFYI: After changing modal type to CONST.MODAL.MODAL_TYPE.CENTERED I've introduced a new bug, which breaks proper horizontal panning. It is late here now. I will try to fix it tomorrow, and also other style bugs that were mentioned above.

Try changing the centered to centered_unswippable type.

BUG: Header is not aligned as other pages on the app. It seems it is a little low. Check Profile page.

Fixed.

@parasharrajat @tgolen PR is ready for review

We need to decide the behavior when image being uploaded is smaller than the container size in dimensions. What do you suggest? Currently it seems fully-scaled.

Asked here https://expensify.slack.com/archives/C01GTK53T8Q/p1654781732610439

Ok, so others agree to add minimum dimensions check as you said. we can go with 80x80px if that sounds fine.

BUG: Android Top margin is not correct.

Fixed

BUG: Sometimes I see black area on images on native and some time image is zoomed to fit the container.

Fixed

Code looks good! My initial testing was pretty good too, except that I triggered this JS console error. Can it be fixed?

Thanks! Fixed

Ok, so others agree to add minimum dimensions check as you said. we can go with 80x80px if that sounds fine.

@parasharrajat I've added 80x80 px validation. Could you please review English warning message and specify Spanish?

I will share the test results by tomorrow.

Testing now

Please merge main before making any changes.

@Tabakharniuk Please update the attached vidoes. Thanks.

Let's try to finish this PR next week.

Please update the attached vidoes. Thanks.

Done

Bug: Mobile-WEB | WEB| Desktop: On small devices where (Width<800px or isSmallScreenWidth is true), the Modal should take the full width of the viewport, like it does for other Modals(Including RHN, e.g. Profile Page).

Fixed

BUG: WEB: Image Canvas is not aligned to the controls as per the mockups.

Fixed

Thanks for your review!

IOS: (warning)

Fixed

Web: Desktop: Buttons and canvas is not aligned with the button. Although this is not a big deal, we can easily fix this but reducing the modal max-width to 450px. Was there any reason for taking 500px for the same/

No, since there was no design for the web - I was trying to create a layout on my own. But I agree that 450px will look better
Fixed

WEB: Desktop: The slider's knob goes out of bounds on resizing the window.

Fixed

iOS: When I save the image after scaling on Emulator.

@parasharrajat I can't reproduce this problem on a simulator nor on a real device. Could you please tell me what versions of Simulator and Xcode are you using? Also, maybe your device has a M1/M2 chip?

iOS: When I save the image after scaling on Emulator.

Maybe it's just me. I am on a Mac VM. We can ignore it.

Please merge the main and update the videos to the latest.

@tgolen you can start your review. I am done with mine. Only a few comments https://github.com/Expensify/App/pull/8511#pullrequestreview-1056555071 https://github.com/Expensify/App/pull/8511#discussion_r931584426 are left.

Comments are fixed and screen recordings are updated
cc: @parasharrajat @tgolen

@tgolen we are creating a new canvas only when the image is saved. When we are pressing a rotate button, we just animate it.
I'm still trying to remove extra canvas, If I succeed I will create new PR.

Last question, do we have an ability to add feature flags? We could easily add one for this feature, just in case.

We do have the ability to add feature-specific betas, but I don't think we need one in this case. We don't have a whole lot of public users on the app yet, and I think the risk of having a bug here is very low (ie. it's not a catastrophic failure).
It looks like the Jest Unit Tests are failing. It kind of looks like those are unrelated to your changes, so could you try updating your branch with main to see if they have already been fixed?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @tgolen in version: 1.1.88-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Seems there was a lot of context here. Can anybody explain why Podfile.lock was updated, but not Podfile?

Hey 👋. Looks like when we first implemented this modal we forgot to add tooltips for the rotate button and slider knob which resulted in this bug.


Update idle-session-timeout-web-apps.md

Updated per Namit's advise

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/9107

Docs Build status updates of commit 7f9397a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/idle-session-timeout-web-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ef84883:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/idle-session-timeout-web-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c085dc4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/idle-session-timeout-web-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@kwekuako Please merge this PR. Thanks

Docs Build status updates of commit 1a6238e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/idle-session-timeout-web-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Feat: Re-Add AssemblyAIReader

AssemblyAI was removed in commit c8bbc101ccc6535c204acb923958341cca753acd as it's not working with NextJS.
The following error happens after creating an example NextJS project with create-llama and calling pnpm dev and trying to chat:
Import trace for requested module:
./app/api/chat/route.ts
 ⨯ ../../packages/core/dist/index.js:5028:24
Module not found: Default condition should be last one
  5026 |
  5027 | // src/readers/AssemblyAI.ts
> 5028 | var import_assemblyai = require("assemblyai");
       |                        ^
  5029 | var AssemblyAIReader = class {
  5030 |   /**
  5031 |    * Creates a new AssemblyAI Reader.

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
./app/api/chat/route.ts

@yisding Was fixed by updating the assemblyai package. Turned out they had the wrong order for default in versions before 3.1.2, see https://github.com/AssemblyAI/assemblyai-node-sdk/commit/00ddb22c60ba8cd6ee69a171aa2de12132b34d8a
This PR can be merged.

Hi folks, I noticed you have this PR open to re-add AssemblyAI with the latest version.
I took the liberty to update the code to use the new function transcribe instead of the deprecated create.
The PR is set to be merged into this PR: https://github.com/run-llama/LlamaIndexTS/pull/245

Awesome, thank you both!


Code for Improved DSR GAN

I have also included code for finetuning here which is currently not completely working.  We can maybe remove this if we would prefer to have all the code in this repo fully functional.
No need for a full review here, just let me know whether or not you want the finetuning code to be included.

Hi @harveymannering
This looks great, the pre-trained models in huggingface are amazing. It would be great that you add in the README further description on which order and refer to https://github.com/budai4medtech/xfetus/tree/harvey/improved-dsr-gan/examples/myriad-guidelines when it is needed.
Thanks, Miguel


You can update the "Known to work with the following LSP servers" section to include tsserver

Amazing plugin, first of all. It's really great to have some visual feedback that work is happening and the LSP client isn't just frozen.
I've noticed it works great with tsserver (for Typescript) as well, if you want to add that to your "Known to work with the following LSP servers" section in the README.md.

It also works with golsp.

Thanks! Yeah I've also since seen it working for clangd and haskell-language-server.
I think this information might accumulate in the main README, so I'll start an issue to track this information.

I'm tracking this information here now: https://github.com/j-hui/fidget.nvim/issues/17, and now point there in the README


Error on startup on windows 10

Unable to Open

I've had one other user report this error and we were unable to figure out what was causing it. When NitroShare starts up, it listens for local connections from applications that use its API. In order to know which port to connect to (and ensure authorization), a secret token must be stored somewhere locally on the filesystem and its permissions set in such a way that it cannot be read by other users. This appears to be the block of code that is causing the error.

I also get this error, when nitroshare is installed with the installer from download page. If I checkout source from git repository and compile it with mingw32 compiler against Qt 5.8, the error doesn't appear. Don't know, if this helps.

@tomkater68 did you also build QHttpEngine (one of NitroShare's dependencies)? Without QHttpEngine, the HTTP API won't work at all.

Hi Nathan,
you're right - I didn't link to QHttpEngine. After doing so, I also get the error.
The error is caused by SetEntriesInAclW(), which returns errorcode 1332 ( ERROR_NONE_MAPPED   No mapping between account names and security IDs was done.). Changing
ea.Trustee.ptstrName = L"CREATOR OWNER";
to
ea.Trustee.ptstrName = "L"CURRENT_USER";";
in function QLocalFilePrivate::setPermission() seems to solve the problem.

Uuh, a misstake has slipped in -it should be
ea.Trustee.ptstrName = L"CURRENT_USER";

Wow, I knew the problem had to be with the ACL code but I could never reproduce the problem to figure out what it was. Thanks so much! I'll get this fix into QHttpEngine immediately.

So, closed. As to get rid of the error message?

It's closed because the underlying issue has been fixed but the error message will not disappear until the next release.


[Python] Pyarrow fail on install and eventual run/compilation

pyarrow 3.0.0 fails on install in a clean environment created using virtualenv on ubuntu 18.04
I ran the following code inside of a brand new environment:

python3 -m pip install pyarrow

This gives the following error:

ModuleNotFoundError: No module named 'Cython'

So I run

python3 -m pip install Cython
python3 -m pip install pyarrow

which then throws another error during the pyarrow install with the following message a the end

Failed building wheel for pyarrow ... CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
 Could NOT find ArrowPython (missing: ARROW_PYTHON_INCLUDE_DIR
 ARROW_PYTHON_LIB_DIR) (found version "3.0.0")

Once I've worked my way through this and any subsequent errors, I am able to succesfully compile my pyarrow/c++ code, but get the following Python runtime error:

ImportError: <redacted>: undefined symbol: _ZN5arrow2py14import_pyarrowEv

Any thoughts?
Reporter: Travis Smith
Note: This issue was originally created as ARROW-11506. Please see the migration documentation for further details.

Going to close this issue, as this is an older issues and it is not clear if anything actionable is left.


[ALLUXIO-3204] Add Server side RPC metrics

https://alluxio.atlassian.net/browse/ALLUXIO-3204
@apc999 I decided to use the logAnyFailure flag for metrics gathering as well. AFAIK this is correct since we use the negative of some methods (ie. GetStatus for exists)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20162/Failed Tests: 2org.alluxio:alluxio-tests: 2alluxio.server.configuration.ConfigCheckerIntegrationTest.multiMastersalluxio.server.configuration.ConfigCheckerIntegrationTest.multiWorkers
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20174/
Test PASSed.


Package not up to date with the listings package

Since the last update to this package on CTAN, the listings package has seen several updates to provide various fixes and improvements. Unfortunately, this package has not yet been updated to regain parity.

You have provided no test file nor said what issue you are having. This package does not  re-implement any of the listings package it is simply a small wrapper handling encoding that then uses whatever version of listings you have, so it does not normally need to "regain parity": it simply uses the current listings package.
If an incompatibility with current versions has arisen please open an issue with a test file and log.

Understood, in that case there is no issue.


Add perspective transform support on Android

Rebased #6926 against master.
Fixes #2915
Test plan:
Check that the perspective of the flip card in UIExplorer is same on both iOS and Android
cc @kevinstumpf @brentvatne @lexs

awesome

Any news on this being merged? Know you guys probably get swamped with requests but this would be awesome

@facebook-github-bot shipit


Trained model release day?

Hi,
I've successfully rerun your code. But I found that due to the huge dataset, it takes nearly 8 hours for a train epoch and nearly 2 hours for a val epoch. It will take a long time to complete 500 epochs.
So may I ask that do you have a plan to release the trained model? It will save us a lot of time.
Thanks!

Sure. Please email me at<EMAIL_ADDRESS>I will provide the checkpoints


Please keep clone: false

I just came back to this library after a time, and I didn’t realize the default for clone had been switched. I’m glad you included it in the README at the end, otherwise I wouldn’t have found it.
This change broke my code, but I’m glad you kept the clone option. Would you consider keeping clone: false functionality, rather than deprecating it? Shallow cloning is very useful, especially in react.

The difference between clone: false and clone: true is that when true a new object is created, when false stuff is merged into the initial object passed, modifying it. Neither of them should change Shallow cloning vs deep cloning behaviour?

Ahh, thank you for the clarification 😃so I believe I should be using extend-merge instead.  I appreciate your prompt response!

@jlarmstrongiv I'm not sure but wouldn't simply using Object.assign meet your use case? eg
let objectToBeModified = { a: "cat", b: "dog" };
Object.assign(objectToBeModified, { b: "chair", c: "table" });
console.log(objectToBeModified); // { a: 'cat', b: 'chair', c: 'table' }

@macdja38 Object.assign() and ...spread work, but it starts to get tedious for deeply nested objects.  For instance,
const newState = {
  ...state,
  results: {
    ...state.results,
    some: {
      ...state.results.some,
      deeplyNestedItem: {
        ...state.results.deeplyNestedItem,
        someProp: 'changed'
      }
    }
  }
}

I always try to keep my data structures flat, but I’m looking for a library to shallow merge it for me when that use case arrises.

How are you using the word "shallow"?  In this context, we would interpret it to mean that you only care about merging the properties of that top object, and you wouldn't be touching any of the nested objects.

@TehShrike
For my use case, shallow merging involves changing a property while keeping immutability in mind.  I care about merging the properties of the top object, but whichever nested property I change, the objects that holds that nested property need to be new objects.
The two objects I would shallow merge from the example about would be:
shallowMerge(state, {
  results: { some: { deeplyNestedItem: {someProp: 'changed'}}}
})

I wrote my own code for this operation, and fixed a few bugs for it.  I think it works, but I would rather use a more dependable library.
export const shallowMerge = (oldState, updatedProperties) => {
  let newState = { ...oldState, };
  for (let key in updatedProperties) {
    newState[key] = updatedProperties[key];
    if (updatedProperties[key] !== null && typeof updatedProperties[key] === 'object') {
      newState[key] = updateObject((oldState[key] || {}), newState[key]);
    }
  }
  return newState;
};


[3.x] Add GDNative Framework support for macOS, add Unix symlink API.

Adds ability to select, load and export (both .dmg and .zip) macOS ".frameworks" as GDNative libraries.
Adds minimal symlink API to DirAccess (frameworks usually contain multiple relative symlinks).
Framework export won't work from Windows (If there are symlinks in the framework). NTFS have support for symlinks, but I do not see any way to get relative symlink target path, all functions seems to return full path. And creating symlinks seems to require privilege elevation. Not sure what to do with it (currently it will print a warning).
Same as #46866 for 3.2.

Thanks!


[Docs] Remove deprecated adapters from toc sidebar

Signed-off-by: Lee Calcote<EMAIL_ADDRESS>

🚀 Preview for commit e579b0d5965c10177b2da55f4278edd77d0f9693 at: https://65c5a4ed7125075322afa20b--meshery-docs-preview.netlify.app


utest: graphics api in jenkins

graphics api cannot be tested on jenkins due to x11 buffer bug.
BLOCKED: fix jenkins bug, wait for updates to plugin/jenkins

Installed xvfb in Jenkns to run the graphics unit test on ubuntu server.
xvfb can instantiate but I get the following fault when trying to initialize the graphics_suite:
libEGL warning: DRI2: failed to create any config
libEGL warning: DRI2: failed to create any config
WARNING - Suite initialization failed for 'suite_graphics'.


How to debug the api responses for local model usage?

I am trying to use this extension with my custom minimalist inference server for local models (this).
I managed to make the server to process the requests correctly and run inference from the extension api calls. It responds in the OpenAi api format but the extension does not seem to understand or get the response, and is still waiting after the request is completed.
Is there a way to get the errors or debug the responses received in the extension, so that I can see what is the problem?

Yeah, error handling could be improved. Right now, errors should be shown in a notification box if they are caught.
For OpenAI responses, the response is expected be received as a stream:
https://github.com/transitive-bullshit/chatgpt-api/blob/main/src/chatgpt-api.ts#L207 (this is the lib I'm using to handle request/response formatting and send/receive)
I think it'd be pretty simple to add a configuration option for this, i.e., whether or not to expect a stream of responses or one single response.
When a stream event never arrives, I imagine the timeout will eventually trigger and that will be the only error message you see.
I took a look at goinfer and infergui - very cool. I'll definitely be checking these out.

Ok I see. I should implement sse in my OpenAi compatibility layer server side. I have it already for my normal api, but not in the OpenAi one, that I implemented recently only to use your extension with my server.
Thanks for pointing the lib, this way I can test the sse and make a compatible implementation

To be able to debug more efficiently it would be nice to be able to print the requests and responses, and see the js errors directly, maybe in some kind of debug mode if possible.
@nvms for info I added an OpenAi api compatibility layer in Goinfer, including the streaming response. So the Goinfer server version 0.2.0 is now fully compatible with Wingman

My current idea for this: once I remove chatgpt-api in favor of my own solution, it will be more simple to store the relevant parts of the request & response. Then, in the chat conversation window I can provide a way of inspecting these, e.g. the Inspect request details element below:


Portals - improve PVS tracing

The existing tracing routine for building the PVS was overly simplistic compared to the main portal tracing, and could not correctly cope with multiple portal paths between adjacent rooms, and as a result would sometimes underestimate the rooms visible.
This PR adds an improved function that can cope with entering a room multiple times during a trace. As a result it has to take care of portal directions (to prevent going back on itself) in a similar, but not identical way to the main portal tracing routine, and internal rooms, to prevent recursive loops.
Notes

The main portal culling in Partial and Full PVS mode depend on the accuracy of the PVS.
This makes the routine a bit more complex and epsilons in particular can be error prone, but it is a necessary evil.
I've left in a copy of the original PVS tracing routine (marked simple) - it is not called but may be useful for comparison for debugging.

Thanks!


adding the new pr

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please


Sanity check failed due to message output

Hi,
I've been testing the fetcher on my program and I always get a Sanity check fail in fetch(). I've added additional debug messaging to show tokenIn and tokenOut, and this is returned:
2016/09/20 08:02:18 [overseer master] sanity check failed:d57f1402568b9d42, 2016/09/20 08:02:18 INFO:EcomRate.bdb-ConfigLoad - Retry - 5
It seems that the first message that is returned on stdOUT from my code is a database load INFO message, instead of the token. This is most likely occuring due to my import load order and my defined init.
For a quick fix I'm going to comment out the tokenIn/tokenOut check. But for a longer term fix I think Overseer needs to have a init function defined that outputs the token.

It needs to be documented though, before you print anything to stdout, at the top of main run overseer.SanityCheck().

I also encountered this problem and found the error by modifying the code debug.
So, you should remove the output before starting

Delete output  before overseer.Run(overseer.Config  !

See pull-request https://github.com/jpillora/overseer/pull/72


[RFC] 11ty + plugin Vue + petite-vue

https://www.11ty.dev/ is now stable v1 and looks good 👍🏾

EJS would still supported (and other template languages);
Progressive migration to Vue 3 SFCs for server rendered components with https://github.com/11ty/eleventy-plugin-vue;
Partial hydration with petite-vue (https://twitter.com/youyuxi/status/1411405615369539590?t=rk8LX5vw_LUSyD_CiJDivA&s=19 👀 ) also compatible (re-usability) with SSRed (Vue 3) components;
https://www.11ty.dev/docs/plugins/serverless/ (demo) looks good with 3 rendering modes (SSG, ISG, SSR);

Perfectly suitable with https://docs.netlify.com/configure-builds/on-demand-builders/ , but would it be so much vendor specific ?

https://www.netlify.com/blog/2021/11/12/ship-javascript-where-it-counts-with-vite-partial-hydration/

https://twitter.com/matthewcp/status/1489277615747837956 👀

https://twitter.com/buildWithLit/status/1490809413174661122 👀 😬


Vim hangs when editing large files

HW: MacBookAir 2013
OS: MacOS High Sierra
Vim 8.1.1722
`
"========PLUGINS==============================================================
Plugin 'VundleVim/Vundle.vim'
" Appearance
Plugin 'flazz/vim-colorschemes'
Plugin 'itchyny/lightline.vim'
Plugin 'ap/vim-buftabline'
"Plugin 'octol/vim-cpp-enhanced-highlight'
"Plugin 'kendling/taghighlight'
Plugin 'jeaye/color_coded'
" Wiki
Plugin 'vimwiki/vimwiki'
"Plugin 'lervag/wiki'
Plugin 'godlygeek/tabular'
"Plugin 'itchyny/calendar.vim'
Plugin 'mattn/calendar-vim'
" Search
Plugin 'junegunn/fzf'
Plugin 'junegunn/fzf.vim'
Plugin 'Alok/notational-fzf-vim'
Plugin 'CoatiSoftware/vim-sourcetrail'
" Git
Plugin 'tpope/vim-fugitive'
Plugin 'airblade/vim-gitgutter'
" cTags
Plugin 'ludovicchabant/vim-gutentags'
Plugin 'majutsushi/tagbar'
" Code completion
Plugin 'w0rp/ale'
Plugin 'OmniSharp/omnisharp-vim'
Plugin 'Valloric/YouCompleteMe'
" Misc
Plugin 'ledger/vim-ledger'
Plugin 'sk1418/HowMuch'
"A Plugin to show a diff, whenever recovering a buffer
Plugin 'chrisbra/Recover.vim'
Plugin 'tpope/vim-dispatch'
Plugin 'Shougo/vimproc.vim'
"OmniSharp
let g:OmniSharp_server_stdio = 1
" Timeout in seconds to wait for a response from the server
let g:OmniSharp_timeout = 4
" Don't autoselect first omnicomplete option, show options even if there is only
" one (so the preview documentation is accessible). Remove 'preview' if you
" don't want to see any documentation whatsoever.
set completeopt=longest,menuone,preview
" Fetch full documentation during omnicomplete requests.
" By default, only Type/Method signatures are fetched. Full documentation can
" still be fetched when you need it with the :OmniSharpDocumentation command.
"let g:omnicomplete_fetch_full_documentation = 1
" Tell ALE to use OmniSharp for linting C# files, and no other linters.
let g:ale_linters = { 'cs': ['OmniSharp'] }
" Update semantic highlighting on BufEnter and InsertLeave
let g:OmniSharp_highlight_types = 0
" Contextual code actions (uses fzf, CtrlP or unite.vim when available)
nnoremap  :OmniSharpGetCodeActions
" Run code actions with text selected in visual mode to extract method
xnoremap  :call OmniSharp#GetCodeActions('visual')
" Rename with dialog
nnoremap nm :OmniSharpRename
nnoremap  :OmniSharpRename
" Rename without dialog - with cursor on the symbol to rename: :Rename newname
command! -nargs=1 Rename :call OmniSharp#RenameTo("")
nnoremap cf :OmniSharpCodeFormat
" Start the omnisharp server for the current solution
nnoremap ss :OmniSharpStartServer
nnoremap sp :OmniSharpStopServer
`
While editing large file when i change something or press "." for a while i can't do anything.
Key presses are registered but i se the result only after Omnisharp received the response from server. For example there is a string variable str and i press "." after str and i have to wait until it receives the autocompletion stuff but if i decide i want to start type instead i don't see anything until the autocmpletion is recieved. I know my hw is not recent, but is this a normal behavior? Isn't async task execution here to prevent this kind of hiccups? Also have to mention that i set let g:OmniSharp_highlight_types = 0 because with 2 it was even worse.

You have an awful lot going on in that .vimrc. For example, you have both OmniSharp-vim and YouCompleteMe - these both run their own copies of OmniSharp-roslyn.
Could you please comment out all plugins except OmniSharp-vim and check that it actually is OmniSharp-vim which you are having trouble with?

Note that you'll need to use standard Vim omnicompletion to trigger completions from OmniSharp-vim: <C-x><C-o>
You can also try commenting out everything except YouCompleteMe and see if it's that plugin which is causing lags. This seems more likely, since you are describing "autocompletion" occurring as you type, and OmniSharp-vim does not provide this (you can use other plugins to get this behaviour together with OmniSharp-vim, such as asyncomplete, as described in the README).

You have an awful lot going on in that .vimrc. For example, you have both OmniSharp-vim and YouCompleteMe - these both run their own copies of OmniSharp-roslyn.
Could you please comment out all plugins except OmniSharp-vim and check that it actually is OmniSharp-vim which you are having trouble with?

I tried and with all plugins disabled its working fine but hard to comapre because no autocomple after "."

Note that you'll need to use standard Vim omnicompletion to trigger completions from OmniSharp-vim: <C-x><C-o>
You can also try commenting out everything except YouCompleteMe and see if it's that plugin which is causing lags. This seems more likely, since you are describing "autocompletion" occurring as you type, and OmniSharp-vim does not provide this (you can use other plugins to get this behaviour together with OmniSharp-vim, such as asyncomplete, as described in the README).

With YouCompleteMe alone its working fine. When Both YCM and OmniSharp are enabled, its bad. The other plugins definitely add a lot of overhead but these two probably doesn't work really well together. Any sugetion for lightweight autocompletion solution? I need C/C++ C# Python

Yeah running YCM and O#-vim together is going to be heavy with the double-servers.
You could try keeping YCM for your other languages and just disable it for C#? Then use asyncomplete or mucomplete to get autocompletion with O#-vim. I use asyncomplete currently.

If YouCompleteMe uses OmniSharp why it does not do what OmniSharp VIm plugin? But thats probably question on YCM. Thank you for time, i am closing this issue.


fix: Search query logic moved to ViewModel in LocationsFragment

Fixes #2043
Changes: Moved the search query logic to the ViewModel from the Adapter for LocationsFragment.
Screenshots for the change: NA
@iamareebjamal @the-dagger Please review.

Changes: Instead of using blockingGet, now using subscribe.
@iamareebjamal Please review.


Add pyproject.toml and some more customizable parameters

Hello!
Thank you for contributing to the project.
I see you added some parameters that were default and some fixes to the code. Did you test all the functionality?
To be honest, I am not very comfortable with Github and am not sure what to do now.
I guess, after testing it should be:

merge pull request
update pip version

Is that correct?

Hey, yes that's correct. I ran the code locally and produced some figures from it using i.e. edge_color = None. To be sure that I did not introduce anything specific to my setup/platform it would be good if you run the code yourself as well.
You can for example
# if you already have clone of the repo run in its root
git remote add nielstron https://github.com/nielstron/venny4py.git
git fetch nielstron
git checkout nielstron/main
# otherwise run
git clone https://github.com/nielstron/venny4py.git
cd venny4py

# run whatever code you ran before to test that everything works to your satisfaction
...

If you agree with everything, hit merge, update the version number in pyproject.toml and upload the new version to pypi :)

Great, thank you for the instructions.
I will try to merge it after testing.

Looks like it worked.
Thank you again for providing additional parameters that had default values only and your help with merging.


Merge 3.0.01 Port for the Comp Port

Make merges cleanly happy for https://github.com/MinaProtocol/mina/pull/16008

!ci-build-me


Added description and disable-extensions

makes sense to do!
bors r+

bors r+

@matklad , I always had these setting at my local setup, maybe it makes sence to add skipFiles node iternals?

@matklad , I always had these setting at my local setup, maybe it makes sence to add skipFiles node internals?

makes sense, also we need fix duplicate https://github.com/rust-analyzer/rust-analyzer/blob/3a1c7808a423b72a2603a420518dc5daf5c7a798/.vscode/launch.json#L8 .
Sorry, I don’t quite understand how dialogue resolution works. Maybe I did something wrong.

Sorry, I don’t quite understand how dialogue resolution works. Maybe I did something wrong.

Yeah, no worries. We'll clean it up at some point.

@Fihtangolz see #3175


Stable Diffusion 2.0 support

Will this support Stable Diffusion 2.0?
https://stability.ai/blog/stable-diffusion-v2-release

Much likely yes, I only glimpsed at the code and it doesn't seem to be much different from 1.5, I'll probably wait for this to be integrated in the huggingface diffusers library before giving this a try (there are a couple PR there already that seem related).

When I opened this issue the 2.0 announcement just was released, but now with there being some feedback from people who tested 2.0 so far, supporting it really doesn't seem important. It appears to be worse than 1.5, so no need to put effort into 2.0.

The SD 2.1 release just dropped. Which may encourage the community to support 2.1 in the future.
https://www.reddit.com/r/StableDiffusion/comments/zf21db/stable_diffusion_21_announcement/

Stable-diffusion 2.1 should be supported though only for txt2img at the moment, I haven't packaged the weight on huggingface yet but there are some indications on how to create these files at the top of the example script.
Running the command below should generate the following pic:
cargo run --example stable-diffusion-2 --features clap \
    -- --cpu all  --prompt "A rusty robot holding a fire torch in its hand." --num-samples 1

Nice! Do you notice any speed difference compared to 1.5?

Well for me it's a lot slower as 1.5 could fit on my 8GB 2080 gpu but 2.1 cannot. The cpu version is also slower as the size of the unet increased since 2.1.

Ok, interesting. Hopefully soon this will be released and can also be supported by diffusers-rs then: https://twitter.com/EMostaque/status/1598408373170761728
After that 20x speedup, it will be a lot more fun :)

Closing now that stable diffusers 2 has been supported for some time.


Add soft memory limit via GOMEMLIMIT to daprd sidecar

Description
Allow to set soft memory limit to daprd sidecar via a couple of annotations:
	KeySoftMemoryLimit                  = "dapr.io/sidecar-soft-memory-limit"
	KeySoftMemoryLimitPercentage        = "dapr.io/sidecar-soft-memory-limit-percentage"

It follows certain rules:

If no user limit set:

and no soft limit set, there is no change to current behavior
and soft limit set, use soft limit
and soft limit percentage, no change to current behavior

if user limit set:

and no soft limit set, we set a default soft limit equal to 90% of the limit set by the user following Go GC doc recommendations.
and soft limit set, set it to the soft limit as long as it is between 25 and 90% of the limit set, if outside raise an error (this could be changed to not raise an error and just hard limit the values to these ranges)
and soft limit percentage set, set it to perc * hard limit. If perc outside of 25-90% range we raise an error (again we can change this behavior to cut at these values instead of raising error)

When soft limit is set depending on the rules above, we add the environment variable GOMEMLIMIT with value equal to the defined soft limit or percentage soft limit.  We try to use provided soft limit from user if possible but sometimes we need to change to a format allowed by GOMEMLIMIT (for example if they use 100Mi we need to use 100MiB).
Issue reference
Please reference the issue this PR will close: #6784
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@yaron2 just pointed me to a potential simpler solution by reusing an annotation I did not know about nicely called env https://docs.dapr.io/reference/arguments-annotations-overview/.
I'll check and test locally and if everything checks out instead of this PR just create a documentation on how to add soft limits to the sidecar using that.

I'll be closing this in favor of adding documentation to handle this.


Stream generation & localhost

{{url('theme://images/someImage.svg', true)}} in twig resolves to http://localhost/path/to/image.svg even when the site is being accessed by ip address. It should resolve to the same host name that the site is being accessed with.
Discovered while testing with a virtual machine on a local network.

@rhukster Issue is in $this->grav['uri']->rootUrl(true) returning localhost.

Not able to reproduce this.  Are you sure it's not a host entry or something on your end?


[BUG] Node & Disk tags are not restored in system backup restore

Describe the bug (🐛 if you encounter this issue)
The node and disk tags for Longhorn nodes should also get restored when user does a system backup restore.
To Reproduce
Steps to reproduce the behavior:

Go to Longhorn UI, Add some node tags and disk tags.
Create a system backup.
Delete the node and disk tags.
Restore the system backup.
Node/disk tags are not restored.

Expected behavior
The node and disk tags should also get restored.
Environment

Longhorn version: v1.4.x-head

@khushboo-rancher @c3y1huang
Should we restore nodes and their disk settings? I think they will be dynamically created by auto detection via the node controller.
If no need, because some resources relying on them like storage class, so we should have a note in the doc to remind this part as a prerequisite.

After discussing with @c3y1huang , Longhorn nodes will not be restored, because they will be automatically created based on the target cluster. This kind of prerequisite should be mentioned in the doc.
@khushboo-rancher good check :+1:


Region invalid s3 fix

Remove var.region as no resources utilize it after change
Remove region argument from all s3 buckets as region is not configurable and is inherited from provider

This is what I get for using co-pilot to generate some stuff 😵💫

Tfsec pr commenter is failing due to this bug in the github action: https://github.com/aquasecurity/tfsec-action/pull/9


std::ptr::Unique is marked as unstable and as such cannot be used in the stable release channel

I was compiling your library using rustc 1.1.0 and encountered the following message:
$ cargo build
   Compiling pcap v0.1.3
/Users/kieran/.cargo/registry/src/github.com-1ecc6299db9ec823/pcap-0.1.3/src/lib.rs:1:1: 1:26 error: unstable feature
/Users/kieran/.cargo/registry/src/github.com-1ecc6299db9ec823/pcap-0.1.3/src/lib.rs:1 #![feature(libc, unique)]
                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~
note: this feature may not be used in the stable release channel
error: aborting due to previous error
Could not compile `pcap`.

To learn more, run the command again with --verbose.

Is it your intention to wait until Unique becomes stable? Looks like they need an RFC to get to that point. I looked through your code and you seem to use Unique quite a bit so changing it might be irksome.

Thanks, I pulled a limited Unique out of std. Now everything should work on stable.


Enterprise Scale deployment to private enterprise github with self hosted runners

Describe the bug
I am tying to implement Enterprise Scale with self hosted runners in github as in private enterprise github you cannot have github managed runners.
Changed the pull.yml to have step of runs-on: self-hosted instead of  runs-on: ubuntu-20.04.
Now when running the workflow it fails with the below error in the dependencies step:
Run Install-Module -Name "AzOps" -Force
Error:File not found: 'pwsh'
Steps to reproduce

Install linux self hosted runner in Github using the link https://docs.github.com/en/actions/hosting-your-own-runners/adding-self-hosted-runners
2.change the pull.yml to have self hosted runner.
3.Execute pull.yml you will get the error

Screenshots

Thanks for opening this issue @vivek99singh. Can you check that PowerShell (7.0+) is installed on the runner?
In the meantime, give me a few days and I'll write up the configuration guide for self-hosted runners with AzOps.

Yes I got it resolved by getting JQ and Powershell Installed on a Self
hosted runner. It will be great if we can get some documentation for
configuration of self hosted for github enterprise.
On Wed, Jun 16, 2021 at 12:26 PM Lyon Till @.***> wrote:

Thanks for opening this issue @vivek99singh
https://github.com/vivek99singh. Can you check that PowerShell (7.0+)
is installed on the runner?
In the meantime, give me a few days and I'll write up the configuration
guide for self-hosted runners with AzOps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/Enterprise-Scale/issues/612#issuecomment-862202629,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKHJAJE4JYANZMYNI7K6JD3TTBU4RANCNFSM46MIGC4Q
.

Thanks for confirming, @vivek99singh.
We will add this to our backlog.


SqlServerSecureConnection: Updating docs and example for using 'SYSTEM'

…' serviceAccount
Pull Request (PR) description
An error is returned if the 'LocalSystem' service account is used with the SqlServerSecureConnection function, even though the connection is successful. This PR updates the docs and provides an example which instructs the user to use the 'SYSTEM' account instead,
This Pull Request (PR) fixes the following issues

Fixes #1300

Task list

[X] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[X] Resource documentation added/updated in README.md.
[X] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[X] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[X] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[X] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #1321 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##            dev   #1321   +/-   ##
====================================
  Coverage    98%     98%
====================================
  Files        36      36
  Lines      4830    4830
====================================
  Hits       4756    4756
  Misses       74      74

@james-flynn-ie Awesome work on this one! Thank you! 😃


Add Support for VAT rate as decimal value to support new base VAT rat…

Related tickets & documents
https://inoob.atlassian.net/browse/PP6-103
Description
Add Support for VAT rate as decimal value to support new base VAT rate in Finland JS SDK

Please check again! There is no duplicate in for class-validator in package.json


Single Quotes in playlist name.

Having an issue where it cannot find an existing playlist which has a single quote in it's name. (Possibly may have same issue with other fields?).
I have tried looking this up, but not really sure if there's anything simple I can do to change the string, tried /' '' , or is this just a limitation of xPath or js in general?

try escaping the quote something like this  \'

Hi, Yeah I've tried that.
This is the error message that I got it to print out
Error: Evaluation failed: DOMException: Failed to execute 'evaluate' on 'Document': The string '//*[normalize-space(text())='Name\'s Driving']' is not a valid XPath expression.
Where Playlist name is Name's Driving

Please refer this you might need to use concat function or something else.
Also if you can create a PR to fix this issue, I will be happy to merge it.


Replace jqBootstrapValidation

It's a very nice library, but the email pattern is outdated. It's only accepting domain extensions less than 3 chars, some the new domain names will never work.
See https://github.com/ReactiveRaven/jqBootstrapValidation/issues/185
The project is not taking PRs for years so it can't be fixed.

I'm with you on this. At some point I am going to need to update the contact form quite a bit, or just do away with the working form all-together and let folks manually set up their contact forms. It was a feature that I really wanted to have, but it's been a LOT of trouble keeping it working throughout the years, and when dependencies start getting outdated it gets a bit daunting to keep updating.
I'll think about what to do with the form, thanks for this information.

Closing this since we are moving to our new SB Forms contact forms (https://startbootstrap.com/solution/contact-forms)


SFX: Endpoint Urls are not clickable.

The endpoint urls in the details of an app are no longer clickable due to a missing href attribute.
This occurs when using the Path though the Applications menu or through the Nodes menu and navigating down to the instance and it's endpoints

Current version:

@coyesiku this should be fixed in the next update.


Add Music Player Feature

Is your feature request related to a problem? Please describe.
Users often seek an integrated and seamless music player within the platform to enhance their experience. The absence of a built-in music player can lead to frustration, as users need to switch between different apps to listen to their favorite tracks while using our platform.
Describe the solution you'd like
I propose the development and integration of a music player within the platform. This music player should support various audio formats, allow users to create and manage playlists, offer playback controls (play, pause, skip, etc.), and provide a visually appealing interface. Additionally, it should have features like shuffle, repeat, and volume control.
Describe alternatives you've considered
Using third-party music player integrations, but these may not offer a seamless user experience.
Developing a simple audio player without playlist management, but this would not meet the needs of users who want to manage their music within the platform.
Additional context
The integrated music player will enhance user engagement by providing an all-in-one platform experience. Users can listen to music without leaving the app, leading to increased time spent on the platform. Screenshots of the proposed design and UI can be found below.
What problem is this feature trying to solve?
The feature aims to solve the inconvenience of switching between apps for music playback, providing a seamless and integrated user experience.
How do we know when the feature is complete?
The feature will be considered complete when:
The music player is fully functional within the platform.
Users can play, pause, skip, shuffle, and repeat tracks.
Users can create, edit, and manage playlists.
The music player interface is visually appealing and intuitive.
Positive feedback is received from user testing and engagement metrics indicate increased user satisfaction.

Music player is already added here

You can enhance the previous one because it will be duplicate to my repository.


raidboss: p6s Exocleaver Protean + Healer Groups

Adds callout for the Exocleaver mechanic and the healer group headmarkers (013E).
Notes:

Unholy Darkness stack headmarkers are 3.8s before first Exocleavers
Exchange of Agonies headmarkers are 7s before second Exocleavers

Ah, actually need to make modification, the headmarkers and the start casting on first protean are same time.


Post v53 dev-channel on veyron_minnie

v53.0.2768.0
dev-channel veyron_minnie
When attempting to install a new chroot using sudo sh crouton -r trusty -t core,audio,cli-extra,xorg,x11,gtk-extra,extension,keyboard,touch,xfce,xiwi
Base system installed successfully.
Pruning /mnt/stateful_partition/crouton/chroots/trusty mounts...
Creating hwaudio group with GID 18...
groupadd: failure while writing changes to /etc/group
Unmounting /mnt/stateful_partition/crouton/chroots/trusty...

chronos@localhost /usr/local/bin $ sudo edit-chroot -all
name: trusty
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/trusty...
Creating hwaudio group with GID 18...
groupadd: failure while writing changes to /etc/group

yes I am facing the same issue with my asus flip,, crouton was working fine with chrome os stable channel, recently I wiped out my chrome and re accessed the developer mode and switched to dev channel - the main reason is to receive android play updates which happened - after that I have been trying to install and run crouton with no luck, I tried many distros-environments mixtures with no luck, the installation doen't complete at all, errors are:
Pruning /mnt/stateful_partition/crouton/chroots/trusty mounts...
Creating hwaudio group with GID 18...
groupadd: failure while writing changes to /etc/group
Unmounting /mnt/stateful_partition/crouton/chroots/trusty...

or
Removing x11proto-xext-dev ...
Processing triggers for libc-bin ...
ldconfig deferred processing now taking place
Please specify a username for the primary user: ahmed
Failed to complete chroot setup.
Unmounting /mnt/stateful_partition/crouton/chroots/precise...

I am guessing this is related to the recent update.

I am getting the same error on my ASUS Flipbook after upgrading to v53.0.2768.0
dev-channel veyron_minnie

Greetings,
I'm also facing similar issues when running sudo sh ~/Downloads/crouton -u (updating crouton)...
In my case, my xenial failed to launch Xorg caused by SELinux?

dbus: seems to fail to load /etc/selinux/targeted/contexts/dbus_contexts.conf?
xorg: seems to fail to load /etc/selinux/targeted/contexts/x_contexts.conf?

Anyway those configuration files are not bundled with default chroot setup, and I've tried to make those by hand, no luck (dbus error was fixed but xorg needs some more love)...
Regards.

Yes, I am also having problems with Asus flip with the upgrade to the dev channel. Used to work fine with trusty a couple of days back atleast.

I: Base system installed successfully.
Pruning /media/removable/SD Card/chroots/trusty mounts...
Creating hwaudio group with GID 18...
groupadd: failure while writing changes to /etc/group
Unmounting /media/removable/SD Card/chroots/trusty...
chronos@localhost ~ $ I: Base system installed successfully.
bash: I:: command not found
chronos@localhost ~ $ Pruning /media/removable/SD Card/chroots/trusty mounts...
bash: Pruning: command not found
chronos@localhost ~ $ Creating hwaudio group with GID 18...
bash: Creating: command not found
chronos@localhost ~ $ groupadd: failure while writing changes to /etc/group
bash: groupadd:: command not found
chronos@localhost ~ $ Unmounting /media/removable/SD Card/chroots/trusty...
bash: Unmounting: command not found
chronos@localhost ~ $
Is this a problem with Crouton? of Chrome?  Any way to proceed?

This should fix it: #2612.

drinkcat
That fix didn't work for me - after applying it, I am still getting
"Unable to Execute - Permission denied" messages
Any other suggestions?
Thanks

@rbpaul,
Are you're getting a different error message now?

"Unable to Execute - Permission denied" messages

instead of the earlier ones?

groupadd: failure while writing changes to /etc/group

Did you add the routine in the PR to enter-chroot at lines 531-534 before you tried it again?
Did the crouton install complete successfully?
Curious,
-DennisL

I just merged #2612, so the original issue here should be fixed (please reopen if it's not).
@rbpaul: if you're now getting a different error message, please open a new issue.

Thanks, but it is not yet fixed for me.
I get this error when trying to install a chroot: groupadd: "failure while writing changes to /etc/group"  The system first says the " Base system installed successfully", and I can see it on my SDCard, but I can't mount or enter the chroot either before or after adding the routine in the PR to enter-chroot at lines 531-534.  When I do try to mount or enter the chroot that is when I get the "Unable to Execute - Permission denied" messages.
So if you have anything for that, please let me know.

Can you try grabbing the latest release and running it unmodified?

fix https://github.com/dnschneid/crouton/pull/2612/commits/3454f13e4b1f1e0ae5e0db03d57c7302814fa2ea
indeed worked fine with me.

With the latest release - I have successfully installed the chroot and can mount and enter it.
Thank you


Support for Apple Silicon

I'm running MacOS 14.2.1 on an Apple Mac M3. And after running curl https://get.flashlight.dev | bash, I try:
$ flashlight measure

Then, my response is
bad CPU type in executable: flashlight

Is this due to missing support of Apple Silicon?
Note: I'm able to clone your repo and run test and report as guided in the contribution.md, but it would be nice to do it with only $ flaslight

Hi, thanks for raising this!
Turns out so far, we've been relying on people having Rosetta installed to run the Flashlight executable as an Intel executable
But we should really have a proper arm64 executable for Apple silicon as well, we'll look into this 👍

I have an M1 Max and flashlight is working on my device

I have an M1 Max and flashlight is working on my device

Without Rosetta?

yes, installed through normal iTerm session, without Rosetta

it too slow when profiler on M1

@gabimoncha I just now saw that you wrote iTerm session, so I tried to get and run flashlight on iTerm (and not the Mac terminal), but it still fails with the same message. I'm on M3 if that is different from M1?

Last update from me. I'm now using iTerm with Rosetta to run the flashlight commands, while my regular mac terminal runs as before. It works - even though supporting Apple Silicon would be nice!

@Almouro This problem deserves to be pinned

Good point @Randall71! Still not fixed on our side, it's just a bit annoying since we have to codesign the executable now, but it's underway
In the meantime I've pinned the issue and linked @Sumedh-k's helpful comment to the install docs in https://docs.flashlight.dev/


Removed DEL Version 24.07.83503 RN

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Removed DEL Version 24.07.83503 RN
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66bc3ec84adcc428247bde8b--harness-developer.netlify.app


Possibility to send experiment id and variation with track call

Google Content Experiments keeps track of experiments and variations via a separate parameter for server side hits. The way it works is exactly the same as other parameters, such as campaign info.
In order to make GA Content Experiment reporting and measurement possible for server side events, such as eCommerce transactions or revenue, it would be extremely valuable to be able to send these parameters along with server side tracking requests from Segment libraries.
GA Measurement Protocol Reference
GA Content Experiments Implementation Guide

Hi there @ericselin - thanks for writing in with this PR! I'm going to be integrating this feature into our production GA codebase this week. If you happen to see this, what's your primary use-case? I'm trying to determine if something static (like a field you'd set in your GA settings) would be ideal, as you coded, or if being able to grab from a dynamic field would be best.
Thanks!

Looks stale


Morse code

Hi there,
@banzaman and I did the following:

Created a method to decode a Morse code character.
Created a method to decode an entire word in Morse code.
Created a method to decode the entire message in Morse code.

Thanks for you time and advise @christianbiring1


Include version problem

[25/07/2021 - 22:31:23] [Pawn.CMD] DoAmxLoad: Mismatch between the plugin (334) and include (333) versions
[25/07/2021 - 22:31:23] [debug] Run time error 19: "File or function is not found"
[25/07/2021 - 22:31:23] [debug]  PC_Init
This is the errors i got in server_log... I have replaced the include with the new one but still got this errors...

Compile your script using latest include.
If you are using sampctl try ensuring without cache sampctl p ensure --update or manually delete Pawn.CMD dependency directory.

I already did that but still got this errors

@katursis Please upload the updated include.

https://github.com/katursis/Pawn.CMD/blob/master/src/Pawn.CMD.inc#L28


Media download issues

Been wrestling with this for a few weeks, but I can't seem to get this budging. Whenever i try to build / develop from my cleaned project, i always get hit by this error for many (not all) of the image files:
gatsby-source-wordpress  Fetching https://cms.me.com/wp-content/uploads/20
19/09/image.png is taking a long time time (longer
than 15 seconds). This file is 6.85 MB

RequestError: Timeout awaiting 'request' for 30000ms
    at ClientRequest.<anonymous>
(/Users/me/Repositories/me.com/node_modules/gatsby-source-wordpre
ss-experimental/node_modules/got/dist/source/core/index.js:953:65)
    at Object.onceWrapper (events.js:422:26)
    at ClientRequest.emit (events.js:327:22)
    at ClientRequest.origin.emit (/Users/me/Repositories/me.com/n
ode_modules/@szmarczak/http-timer/dist/source/index.js:39:20)
    at TLSSocket.socketErrorListener (_http_client.js:469:9)
    at TLSSocket.emit (events.js:315:20)
    at emitErrorNT (internal/streams/destroy.js:106:8)
    at emitErrorCloseNT (internal/streams/destroy.js:74:3)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
    at Timeout.timeoutHandler [as _onTimeout]
(/Users/me/Repositories/me.com/node_modules/gatsby-source-wordpre
ss-experimental/node_modules/got/dist/source/core/utils/timed-out.js:36:25)
    at listOnTimeout (internal/timers.js:556:17)
    at processTimers (internal/timers.js:497:7) {
  name: 'TimeoutError',
  code: 'ETIMEDOUT',
  timings: {
    start:<PHONE_NUMBER>803,
    socket:<PHONE_NUMBER>803,
    lookup:<PHONE_NUMBER>804,
    connect:<PHONE_NUMBER>886,
    secureConnect:<PHONE_NUMBER>028,
    upload:<PHONE_NUMBER>028,
    response:<PHONE_NUMBER>105,
    end: undefined,
    error:<PHONE_NUMBER>803,
    abort:<PHONE_NUMBER>803,
    phases: {
      wait: 0,
      dns: 1,
      tcp: 82,
      tls: 142,
      request: 0,
      firstByte: 77,
      download: undefined,
      total: 30000
    }
  },
  event: 'request'
}

i've tried killing the request concurrency using:
    {
      resolve: `gatsby-source-wordpress-experimental`,
      options: {
        url: `https://cms.me.com/graphql`,
        schema: {
          requestConcurrency: 1
        },
      }
    },

but i'm not even sure the plugin is even listening to that config as it's flying through trying to download the images. that said, the wordpress instance is running on a super fast VPS and shouldn't have any issues with the transfer. Additionally, this wordpress instance was working perfectly with a previous gatsbyjs build... so i'm out of ideas. libraries are all updated etc.

Hi @adrianhewitt the request concurrency you're setting is for GraphQL requests but the warning in your terminal is related to file requests. You want to use this setting instead https://github.com/gatsbyjs/gatsby-source-wordpress-experimental/blob/master/docs/plugin-options.md#typemediaitemlocalfilerequestconcurrency

assuming you're talking about the local file request concurrency:
    {
      resolve: `gatsby-source-wordpress-experimental`,
      options: {
        url: `https://cms.me.com/graphql`,
        schema: {
          requestConcurrency: 1
        },
        type: {
          MediaItem: {
            localFile: {
              requestConcurrency: 1,
            },
          },
        },
      }
    },

i cleaned the project and tried to compile it again and it does the same thing, still spits out a whole heap of warnings then timeout errors

@adrianhewitt can you share a reproduction of the problem? That'll help us figure out what's going on. Thanks!

Sorry to jump in with possibly irrelevant info... I had the same error upgrading today, although it came about from different circumstances. I was using Local and there were https/http clashes and self signed certificates and what not. Not enough to impact on the build until I added a post with an image in Gutenberg, then I started getting the error described as below. It was a 300kb image. Basically kept going until it errored.
gatsby-source-wordpress  Fetching https://cms.me.com/wp-content/uploads/20
19/09/image.png is taking a long time time (longer
than 15 seconds). This file is 6.85 MB

Fortunately my issue was resolved by reinstalling my WP into Local and making sure http info were all correct (in WP and Gatsby-config). I haven't needed to reinstall my Gatsby project.
If your site works locally it might be worth trying to flush the permalinks on the live one.
This plugin will allow you to have a better idea regarding what's going on at the WP database level inside the admin of your media area. https://en-gb.wordpress.org/plugins/media-library-assistant/ I used to use that for the old WP-src plugin. It may help you diagnose why some images seem to work and others don't.
Also I found this which may or may not be of interest. https://www.polynique.com/2021/01/26/fix-gatsby-crash-when-uploading-an-image-in-wordpress/
How did you copy the CMS to local? If it works locally, you could try using this plugin https://en-gb.wordpress.org/plugins/all-in-one-wp-migration/ to re-upload your local site.
Again, apologies if totally unhelpful.

For a moment I thought @CloudBop was on the right track (flushing permalinks didn't work, but i then thought about removing auto https redirect on my hosting which seemed to work), but i think my success was mostly due to tethering to my phone in a cafe and having higher burst bandwidth... now back in the office every pathy thing i try doesn't seem to make a difference. (and now at home with a faster internet connection i get the warnings but none of the timeouts)
also worth noting that with
localFile: {
   requestConcurrency: 1,
},

i get 7 30sec timeout errors (office), but the total build process takes 1min 42secs... and I would have thought with a requestConcurrency of 1 that i should have at least a 2min 10sec delay in the process? (and just incase requestConcurrency is actually extra threads on top of the main, i thought about changing its value to 0 and it's still doing the same thing)
i've moved my local working wordpress install onto my server (as cms2.me.com) and its still throwing the same errors.
I'm thinking my setup is just trying to power through and is ignoring the concurrency settings and choking... will work out how to share my repo with @TylerBarnes

Invited @TylerBarnes :) it's the v2 branch i'm having issues with. and its super rough, but its hard to work on it with the media download issues

Just got the time to pair the project back to just the queries and made it public
https://github.com/adrianhewitt/adrianhewitt.com-troubleshooting

I really hoped that the stable version will fix this one, but sadly same problems happening with the new gatsby-source-wordpress plugin. While there aren't many media files everything works fine, but when I upload more media it starts showing this error... For more than 2 months I have a separate sandbox source with fewer media, so I could develop my project...

Recently a newer contributor split out request concurrency into 2 options, one for files and one for data requests. I think a mistake was made where file requests are still partially relying on the GATSBY_CONCURRENT_DOWNLOAD env var. @Piligrimas would you mind trying to lower that env var to see if it helps?


chore: Track machine/node separately for inflight node

Fixes #
Description
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

222 of 249 (89.16%)  changed or added relevant lines in 12 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+2.5%) to 80.08%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/test/machine.go
21
22
95.45%

pkg/operator/operator.go
0
3
0.0%

pkg/apis/v1alpha1/zz_generated.deepcopy.go
1
6
16.67%

pkg/controllers/state/machine.go
19
25
76.0%

pkg/controllers/state/cluster.go
153
165
92.73%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/provisioner.go
1
85.61%

pkg/controllers/state/cluster.go
2
91.11%

Totals

Change from base Build<PHONE_NUMBER>:
2.5%

Covered Lines:
5029

Relevant Lines:
6280

💛  - Coveralls


Chaterino no longer displays channels being hosted

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Previously, the chat client would display a message when the streamer raids/hosts someone along the lines of "[Streamer] is now hosting [other streamer]"
However, recently this message does not display at all. I do not recall when this issue first arose but I want to say it was within the last 7-10 days.
Screenshots
No response
OS and Chatterino Version
Chatterino Nightly 7.3.5 (commit f19d9911c modified) built on with Qt 5.15.2, Windows SDK, MSVC 193231332 Running on Windows 10 Version 2009, kernel: 10.0.19043

Twitch deleted hosting the other day
https://www.dexerto.com/entertainment/twitch-is-removing-the-host-feature-and-streamers-are-furious-1924306/

well hosting doesn't exist anymore. it was removed October 3rd. https://twitter.com/Dexerto/status/1567220585868005378/photo/1


Fix tests

WHY?
The tests are failing
WHAT?
Add generated snapshot to git

[x] I have considered (and possibly added) tests

Changes Unknown when pulling abbd876e929c4848bd52618285019193105e0ac2 on fix/tests into ** on master**.


Run the command without being ContainerAware

The ContainerAwareCommand is currently removed from Symfony and is not needed to run this command.

Also see #15

@alexandresalome would you be so nice to also look into this PR and release it when possible? Thank you so much.

You're lucky, it's the "ho, let's merge all PRs and release them as quick as possible" day :-)

You're lucky, it's the "ho, let's merge all PRs and release them as quick as possible" day :-)

Nice :tada:
I think I should take advantage of that :stuck_out_tongue: