[HOTFOX][Branch-0.7] Fix multi dynamic select forms behaviour

What is this PR for?
This PR is same with #2154 with base branch branch-0.7.
Please refer to #2154's description for the details about what the problem is now.
What type of PR is it?
Bug Fix & Hot Fix
What is the Jira issue?
N/A
How should this be tested?

Create multiple select forms

%md
My first selection is ${my selection1=1,1|2|3}
My second selection is ${my selection2=4,4|5|6}

Create different types of dynamic form (e.g. 1 select form + 1 checkbox)

%md

My selection is ${my selection=1,1|2|3}
My check list is ${checkbox:checkboxTest=list1|list2, list1|list2|list3|list4}

There should be Run on selection change menu under the paragraph control menu in the above cases. And the select form should appear!
Screenshots (if appropriate)

When multiple select forms are created

When different dynamic forms are created (e.g. 1 checkbox + 1 select form)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

When "Run on selection change" is checked, check box change does not run paragraph. @AhyoungRyu can you check?

@Leemoonsoo  You mean the checkbox dynamic form? The Run on selection change is only for select form.
Do you think this can make user confused?

Yes, i think user will expect that same behavior dropdown and checkbox.

@Leemoonsoo Yeah it makes sense. So I updated again as you said.

When two types of dynamic form in the paragraph

Only the checkbox is in the paragraph

Could you check again please?

Tested and LGTM!

@Leemoonsoo Thanks! CI has been passed after rebasing from branch-0.7.
Will merge into branch-0.7 as a hotfix if there are no more comments on this.


[Question]  Does it support Angular 6 ?

I've tried many libraries but not yet got lucky.
Not sure this one is compatible with Angular 6 template system to read img from something like {{ image.thumbnail_256_url }} ?

        <mdb-carousel [isControls]="true" [interval]=0 class="carousel slide carousel-fade" [type]="'carousel-thumbnails'" [animation]="'fade'">
          <mdb-slide *ngFor="let image of stuff.images">

{{ image.caption }}

          </mdb-slide>
        </mdb-carousel>

There's nothing about progressive-image.js that would stop it working in any framework. However, most frameworks - including Angular - have their own ways of doing things. So getting it to work is another matter. Best of luck.
You've not included progressive-image.js classes in your code example above so it certainly won't work there.


Only download valid dSYM urls

The download_url can be nil if bitcode was not enabled which caused the whole process to fail because of an invalid uri. This now checks that the download_url is a valid URI before trying to download it :fist:

This is great, thanks @joshdholtz :+1:


Minimal set of patches to get Weathermap to work with php 8.0

When trying to use the Weathermap plugin with a LibreNMS (FreeBSD package librenms-22.2.1,1, which uses php 8.0 for its dependencies) I had to make the fixes as made in this pull request.

Although the editor crash as soon as I create a link (nodes are OK)

So using su - librenms -c  "APP_DEBUG=true /opt/librenms/html/plugins/Weathermap/map-poller.php" gives me the two attached files (one with nodes only, the other with one link added).
It looks like the links issue is related to imagefilledpolygon() and imagepolygon(), although there is although issues with strftime() , imagefilledrectangle(), imagerectangle() and imagestring().
librenms_weathermap_php81_nolinks.txt
librenms_weathermap_php81_withlinks.txt

So using su - librenms -c "APP_DEBUG=true /opt/librenms/html/plugins/Weathermap/map-poller.php" gives me the two attached files (one with nodes only, the other with one link added). It looks like the links issue is related to imagefilledpolygon() and imagepolygon(), although there is although issues with strftime() , imagefilledrectangle(), imagerectangle() and imagestring().

haven't found the fix for this, changing the link labels from bits > percentages will allow the map to be drawn.

This seems to have been adressed in #82, thanks :)


Add dependency management (dep)

It would be nice to have the (soon to be official) supported package manager integrated.

https://github.com/golang/dep

Definitely makes things easier when working on new features, and gives better support around managing dependency versions/branches/etc as required.
dep init
dep ensure

We are currently using gomodules


query: Extend test cases to the case with the same external labels.

Showcase of how state with external lset being the same for 2 peers is wrong.
Signed-off-by: Bartek Plotka<EMAIL_ADDRESS>

Anything need doing with this PR?

Nope, just super low priority PR waiting for any review (:


Update tmr-meeting-recording-change.md

Changed wording based on feedback from localizers that meaning was unclear.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@cichur PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Refactorings

I hope I didn't break anything. At least the tests in Parametrized.agda still typecheck, but I'm not sure if they cover everything.

Looks very good, thanks!


Lat Lon info in the base II data?

Is this information in the base II data? If so, is there a way to pull the lat lon for each corner of the plot?
Thanks!
David

For newer data (say after 2009), the radials of data should have a lon/lat for the radar.  However, since these are polar data (and not an image) it does not make sense to refer lon/lat for the "corners". The data generally extend 460 km in every direction from the center. The lon/lat bounding "box" for this depends upon the latitude of the station. Near the poles, even treating it as a box can be incorrect.

The VolConsts object (which is on every radial) has it:
In [4]: f.sweeps[0][0][1]
Out[4]: VolConsts(type=b'R', name=b'VOL', size=44, major=1, minor=0, lat=35.33305740356445, lon=-97.27748107910156, site_amsl=369, feedhorn_agl=19, calib_dbz=-43.72919845581055, txpower_h=185.05685424804688, txpower_v=181.45559692382812, sys_zdr=-0.08510557562112808, phidp0=25.0, vcp=12, processing_status=None)

(where f is an instance of Level2File)

So I have it plotting the files to save them out as transparent png's that are high resolution so I can overlay them into google earth. To get the coordinates for the plot I chose I just matched it up to an output from noaa weather toolkit. It works great, but only for the radar station I am using. Is there a way to plot the data radial and do the same thing? That's what I am attempting.
Thanks for the help :)

The corners in the radar coordinate system are (+/- 460km, +/- 460km). Now, you just need to convert them to lon/lat; the details of this calculation depends on which geographic projection you're using.


rename @offsetOf to @byteOffsetOf and add @bitOffsetOf

Use case: OS or embedded development, when using a packed struct to represent MMIO, ability to query a packed struct for the bit offsets of fields.
cc @skyfex

To reiterate my proposal in the chat on the other day-
Keep @offsetOf to return a byte-aligned offset, and add:
@bitShift
to return by how many bits the field is shifted relative to the offset in a packed struct (can be > 7)
This corresponds better to the way Zig manages packed struct fields.

For the case of registers in an embedded application, the structs will generally be the size of one word, and you'd want the bit offset from the start of the word.
(You generally want the bit mask as well, but that can be constructed at compile-time with the bit shift and field bit width I assume)
I'm not sure what the sensible thing would be when the struct is larger than one word. But as long as you can calculate the total bit offset from the start of the struct to the field, if you combine the information from the builtins, then it doesn't matter much.

Thanks @raulgrell for solving this issue.
I also opened #1574 for a proposal to make zig's comptime code more robust, enabling us to solve these in userland, and then delete the builtin functions.


refactor: rename EpochContext and EpochProcess

Motivation

See https://github.com/ChainSafe/lodestar/issues/2406, use simpler naming

Description

Rename EpochContext -> EpochCache: persistent data associated attached to a CachedBeaconState which is associated to a longer timeframe than a single state. EpochCache conveys the meaning better that it's actually a cache, context is weird. Could be renamed to StateCache too.
Rename EpochProcess -> EpochTransitionCache: ephemeral data used only during an epoch transition. EpochProcess is a vague name that does not convey much meaning. EpochTransitionCache conveys that it is a cache for the epoch transition

Closes https://github.com/ChainSafe/lodestar/issues/2406

:tada: This PR is included in v1.9.0 :tada:


add docs for querying Redis state store

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[x] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
add docs for querying Redis state store
Issue reference
#2187

@dmitsh - It is important here to help people understand how they can set up Redis correctly for querying with some common Redis stores and hence update https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-redis/#setup-redis section

For Selfhosted what Redis CLI commands can you run to deploy these the Redis modules yourself after Dapr init. Being able to easily do this locally is a great example. Please add the commands here.
Same for K8s, Redis CLI commands
Under Azure can you put a note" Note: Azure currently does not support the RedisJson module and cannot be used with query.
Under AWS can you put - "Note: For query support you need to enable RediSearch and RedisJson."
Under GCP can you put a note" Note: Memory Store does not modules and cannot be used with query."
Can you also add new Tab for Redis Enterprise Cloud with this link https://docs.redis.com/latest/rc/ as another option.
Can you also add new Tab Alibaba Cloud with this link https://www.alibabacloud.com/product/apsaradb-for-redis as another option

I would like to make sure that this and the query API topic https://docs.dapr.io/developing-applications/building-blocks/state-management/howto-state-query-api/ article are better aligned. Could you show the Redis queries using the employees dataset (have a link to this in this Redis component topic) and using query from Example 1, In other words, this
curl -X POST http://localhost:3500/v1.0/state/statestore/query?metadata.contentType=application/json&metadata.queryIndexName=orgIndx -d @query-api-examples/query1.json -H "Content-Type: application/json
Can you also add a link in the "Related Links" section to this Redis Component Query section?
Query Redis State Store

These changes look great! Would still like to address what Redis service can be used due to the Redis Modules dependency.
These ones.

Under Azure can you put a note" Note: Azure currently does not support the RedisJson module and cannot be used with query.
Under AWS can you put - "Note: For query support you need to enable RediSearch and RedisJson."
Under GCP can you put a note" Note: Memory Store does not modules and cannot be used with query."
Can you also add new Tab for Redis Enterprise Cloud with this link https://docs.redis.com/latest/rc/ as another option.
Can you also add new Tab Alibaba Cloud with this link https://www.alibabacloud.com/product/apsaradb-for-redis as another option

These changes look great! Would still like to address what Redis service can be used due to the Redis Modules dependency. These ones.

Under Azure can you put a note" Note: Azure currently does not support the RedisJson module and cannot be used with query.
Under AWS can you put - "Note: For query support you need to enable RediSearch and RedisJson."
Under GCP can you put a note" Note: Memory Store does not modules and cannot be used with query."
Can you also add new Tab for Redis Enterprise Cloud with this link https://docs.redis.com/latest/rc/ as another option.
Can you also add new Tab Alibaba Cloud with this link https://www.alibabacloud.com/product/apsaradb-for-redis as another option

I would prefer not to mention that in the doc because:

things can change, and this information may become inaccurate
you can still deploy Redis with modules in Azure, for example. I did that in e2e tests with AKS

Let's at least then be inclusive of other Redis hosted services and add tabs to reference Redis Cloud and Alibaba Cloud

Can you also add new Tab for Redis Enterprise Cloud with this link https://docs.redis.com/latest/rc/
Can you also add new Tab Alibaba Cloud with this link https://www.alibabacloud.com/product/apsaradb-for-redis


Add lacking features in gobgp backend

This PR adds lacking features in GoBGP backend which BIRD backend has.
List of the features

Global, Node-Specific neighbor support
Dynamic configuration support
IPv6 support

Sorry we've let this sit for so long!  @gunjan5 can you review?

@matthewdupre no problem! Thanks for the response.

@ishidawataru I tested this patch and it seems to work fine, the only thing is I want to make sure it works with one of the commits that combined libnetwork plugin into calico node image.
Can you rebase this to master so I can make sure it works with the latest changes?

@gunjan5 Thank you for testing. Rebased.

@ishidawataru besides the review comments, I noticed one issue with IPv6 setup:
Steps to reproduce the issue:

I setup 2 ubuntu nodes with your fork branch gobgp
make node_image
make binary
on node calico-01 I added an IPv6 addr by sudo ip addr add fd80:24e2:f998:72d7::1/112 dev enp0s8
on node calico-02 I added an IPv6 addr by sudo ip addr add fd80:24e2:f998:72d7::2/112 dev enp0s8
start calico/node with GoBGP on both nodes:
calico-01:

sudo ./dist/calicoctl node --ip=<IP_ADDRESS> --ip6=fd80:24e2:f998:72d7::1 --libnetwork --backend=gobgp --no-pull

calico-02:
sudo ./dist/calicoctl node --backend=gobgp --node=calico/node --no-pull --libnetwork --ip=<IP_ADDRESS> --ip6=fd80:24e2:f998:72d7::2

The issue is when I do calicoctl status --backend=gobgp I see ::1 as a peer on calico-01 which is it's own IPv6 address:

vagrant@calico-01:~/ishidawataru/calico-containers$ sudo ./dist/calicoctl status --backend=gobgp
calico-node container is running. Status: Up 55 seconds

IPv4 BGP status
IP: <IP_ADDRESS>    AS Number: 64511 (inherited)
WARNING: gobgp mode only supports node-to-node mesh type
+--------------+-------------------+-------+---------+--------+
| Peer address |     Peer type     | State |  Since  |  Info  |
+--------------+-------------------+-------+---------+--------+
| <IP_ADDRESS> | node-to-node mesh |   up  | 0:00:02 | Active |
+--------------+-------------------+-------+---------+--------+

IPv6 BGP status
IP: fd80:24e2:f998:72d7::1    AS Number: 64511 (inherited)
WARNING: gobgp mode only supports node-to-node mesh type
+------------------------+-------------------+-------+-------+--------+
|      Peer address      |     Peer type     | State | Since |  Info  |
+------------------------+-------------------+-------+-------+--------+
| fd80:24e2:f998:72d7::1 | node-to-node mesh |   up  | never | Active |
+------------------------+-------------------+-------+-------+--------+

Even more interesting thing on calico-02 is it sees calico-01 as it's IPv6 peer, but it also sees itself as it's peer:

vagrant@calico-02:~/ishidawataru/calico-containers$ sudo ./dist/calicoctl status --backend=gobgp
calico-node container is running. Status: Up About a minute

IPv4 BGP status
IP: <IP_ADDRESS>    AS Number: 64511 (inherited)
WARNING: gobgp mode only supports node-to-node mesh type
+--------------+-------------------+-------+---------+-------------+
| Peer address |     Peer type     | State |  Since  |     Info    |
+--------------+-------------------+-------+---------+-------------+
| <IP_ADDRESS> | node-to-node mesh |   up  | 0:00:45 | Established |
+--------------+-------------------+-------+---------+-------------+

IPv6 BGP status
IP: fd80:24e2:f998:72d7::2    AS Number: 64511 (inherited)
WARNING: gobgp mode only supports node-to-node mesh type
+------------------------+-------------------+-------+-------+--------+
|      Peer address      |     Peer type     | State | Since |  Info  |
+------------------------+-------------------+-------+-------+--------+
| fd80:24e2:f998:72d7::1 | node-to-node mesh |   up  | never | Active |
| fd80:24e2:f998:72d7::2 | node-to-node mesh |   up  | never | Active |
+------------------------+-------------------+-------+-------+--------+

@ishidawataru actually ignore my last comment, I was doing the testing with your master branch 😄
Tested IPv4 and IPv6 setup with gobgp branch and it seems to work fine.
calico-node container is running. Status: Up About a minute

IPv4 BGP status
IP: <IP_ADDRESS>    AS Number: 64511 (inherited)
+--------------+-------------------+-------+---------+-------------+
| Peer address |     Peer type     | State |  Since  |     Info    |
+--------------+-------------------+-------+---------+-------------+
| <IP_ADDRESS> | node-to-node mesh |   up  | 0:00:49 | Established |
+--------------+-------------------+-------+---------+-------------+

IPv6 BGP status
IP: fd80:24e2:f998:72d7::1    AS Number: 64511 (inherited)
+------------------------+-------------------+-------+---------+-------------+
|      Peer address      |     Peer type     | State |  Since  |     Info    |
+------------------------+-------------------+-------+---------+-------------+
| fd80:24e2:f998:72d7::2 | node-to-node mesh |   up  | 0:00:53 | Established |
+------------------------+-------------------+-------+---------+-------------+

👍

@gunjan5 Thanks for your review. Reflected your comments in the latest commit.

@ishidawataru thanks! Can you squash the commits? I will run some final tests and merge it  tomorrow if things look good

@gunjan5 squashed. PTAL

LGTM!


Trainz Railroad Simulator 2004: No video or no keyboard input

The game doesn't show anything when running full screen, but the keyboard/mouse input and sound work, however when I run the game with the virtual desktop on, the game works fine, but the keyboard input doesn't work.
Software information
Trainz Railroad Simulator 2004, obtained as abandonware from U7-Trainz.de
System information

GPU: AMD Radeon RX 5500 XT
Driver: amdgpu (Kernel 5.15.12)
Wine version: 7.0-rc2
DXVK version: 1.9.2

Apitrace file(s)
None at the moment, will supply later if required.
Log files

d3d9.log: trainz_d3d9.log
d3d11.log:
dxgi.log:

Does this work with wined3d? Keyboard input in particular is something we should not have any sort of control over.

Yes it does work with wined3d fully, with fullscreen and on virtual desktop.

can we have an apitrace please?

Yes of course, will send within 30 minutes

Here we go, my upload is slow today: https://drive.google.com/file/d/1ur2zobHt_bAgh6WFV3HIKKwQQVpzwe0J/view?usp=sharing
Recorded this apitrace with fullscreen and no virtual desktop.

The black fullscreen issue is also present on Windows, so that might be better to fix first.
So to sum up, without virtual desktop, the game launches with a black screen, but with sound and keyboard input working.

Is there anything more required or missing to help fix this issue?

Can confirm the issue.
 Needs virtual desktop before anything displays.
Wined3d works fine without.


Vi normal mode parser returning separated actions/motions.

Basic parser for the mayor operations in normal mode (some oddballs included)
Provides:

[x] Enums with the core functionalities expected for normal mode (some could be translated to visual mode)
[x] Tests of the basic parser
[x] Supports abort on invalid sequences as well as recognition of incomplete sequences

Not provided:

[ ] Key remapping
[ ] Parsing logic to dispatch modifying letters used both for actions and movements like more complex g or z based sequences. Parsing is just using look ahead of one char and rejects either invalid actions or invalid moves thus no gg at the same time as gu etc.
[ ] Unicode support for char replacement or char search
[ ] Logic for the key sequence buffer.
[ ] Implementation of the action or movement based editing

Superseded by more complete #211 by @elferherrera. May still be used as inspiration for test cases etc.


Remove Natural Language encoding argument

Switch to detecting the system encoding and using that instead.
Ruby's default encoding is UTF-8, and the default is API encoding is :UTF8.
Only use :UTF16 or :UTF32 if the system is explicitly set to those encodings.
[closes #1255]

@landrito, @quartzmo and I paired on this and revised all mentions of encoding in documentation. We removed mentions of encoding from everywhere except the documentation of the offset values, since those values are the only ones that will be affected by the system configuration. Can you take a look and let us know what you think?


feat(vivid templates): add login template

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@rinaok ready for review?

yes


Pynetcf 2.2 requires netcdf4>=1.4.0

Since this commit ( https://github.com/TUW-GEO/pynetcf/commit/a7ee3a90ddab5da5ab4214e4012b4f944b5d18b8 ) netcd4.num2date() is called with the kwarg only_use_cftime_datetimes. This is kwarg is only available since netcdf4>=1.4.0, if an older version is used a typeerror is thrown:
TypeError: num2date() got an unexpected keyword argument 'only_use_cftime_datetimes'
So I guess the proper course is either to update the requirements to match, or revert this commit.

the package has the requirement to use netcdf>=1.4.2
https://github.com/TUW-GEO/pynetcf/blob/master/setup.cfg#L33
if you work with an older version of netcdf please install a older version of pynetcf

I see, i apparently managed to circumvent the requirements by installing netcdf4 with with conda, and pynetcf with pip. My bad, thanks for your time!


pull request for e2e test at 12/23/2016 06:56:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: convenient meta declarations

These declarations are picked from #5938.

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.

You know what, I'm going to assume this needs no substantial revision:
maintainer merge

@kmill I would like write the tests. Thank you.

@kmill
✖ I would like write the tests. Thank you.
◯ I would like you to write the tests. Thank you.
Sorry.

Thanks!
bors r+


fix notification: applied correct position offset calculations

Fix #156

I have tested on my end and you can see the result below:


decompressing same zip file to the same dest directory more than once

Hi,
The following error occurs if an existing zip file is decompressed to the same directory more than once. Is there some setting for this? I couldnot find something in the docs or in the code.
"err": {
"errno": -4048,
"code": "EPERM",
"path": "E:\app\test\dest1\my_file.txt"
}

Check out 4.0.0 and let me know if the same problem still occurs.


Add optional filtering for Base.tags by resource type

The FE should have the ability to filter tags acc. to a resource type.
E.g. in the BoxEdit page the queries should be adjusted like:
base(id: $baseId) {
    ...
    tags(resourceType: Box) { ... }
    ...
}

Otherwise tags that are only applicable to beneficiaries could be selected.

 2.0 Add filtering for Base.tags field by object type


anima on started cannot be used

godot: 4.0rc1
anima: 0.4

Hi,
on_started is meant to be used after animation or anima_XXXX (property). Also looking at your screenshot Anima is not meant to be used like that, you always need to start with Anima.begin or Anima.begin_single_shot.
However I'll add a new keyword called event to allow you to do that, so you'll have something like:
Anima.begin_single_shot(self) \
   .event(Callable(self, "do_something"))
  .then(....)


Update DocumentDiagnosticReportKind case

Changing DocumentDiagnosticReportKind kinds to match the case convention used by other *-Kinds.

Makes perfect sense


CustomPropTypes for Components

PropType validations inside the component are done which is very cool, i want to create a centralized file that holds all these prop types which each of them will hold a separate custom name and then we can call that custom name of it inside our component for prop type validation.
Example:
The below prop validation is done in Verse component:
static propTypes = {
 isSearched: PropTypes.bool,
    verse: verseType.isRequired,
    chapter: surahType.isRequired,
    bookmarked: PropTypes.bool, // TODO: Add this for search
    bookmarkActions: PropTypes.shape({
      isLoaded: PropTypes.func.isRequired,
      load: PropTypes.func.isRequired,
      addBookmark: PropTypes.func.isRequired,
      removeBookmark: PropTypes.func.isRequired,
    }),
    mediaActions: PropTypes.shape({
      setMedia: PropTypes.func.isRequired,
      removeMedia: PropTypes.func.isRequired,
    }),
    audioActions: PropTypes.shape({
      pause: PropTypes.func.isRequired,
      setAyah: PropTypes.func.isRequired,
      play: PropTypes.func.isRequired,
      setCurrentWord: PropTypes.func.isRequired,
    }), // not required because in search it is not.
    match: PropTypes.arrayOf(matchType),
    isPlaying: PropTypes.bool,
    isAuthenticated: PropTypes.bool,
    tooltip: PropTypes.string,
    currentWord: PropTypes.number, // gets passed in an integer, null by default
    iscurrentVerse: PropTypes.bool,
    currentVerse: PropTypes.string
  };

That whole prop types will be shifted in a customPropTypes.js file as a separate shape and will look something like this
export const audioActions = PropTypes.shape({
   pause: PropTypes.func.isRequired,
      setAyah: PropTypes.func.isRequired,
      play: PropTypes.func.isRequired,
      setCurrentWord: PropTypes.func.isRequired,
});

and back inside the word Component, the customPropTypes.js will be imported and inside validation we will have only one piece of code as this:
Verse.propTypes = {
 isSearched: PropTypes.bool,
    verse: verseType.isRequired,
    chapter: surahType.isRequired,
    bookmarked: PropTypes.bool, // TODO: Add this for search
    bookmarkActions: customPropTypes.bookmarkActions,
    mediaActions: customPropTypes.mediaActions,
    audioActions: customPropTypes.audioActions,
    match: customPropTypes.match,
    isPlaying: PropTypes.bool,
    isAuthenticated: PropTypes.bool,
    tooltip: PropTypes.string,
    currentWord: PropTypes.number, // gets passed in an integer, null by default
    iscurrentVerse: PropTypes.bool,
    currentVerse: PropTypes.string
}

Why am I doing this?
This helps us first of all to have much more cleaned up components, helps us to identify similar props and avoid reusing prop validations.

Thanks for the PR!


Fix a bug with MSAL library for Node 10 runner

Task name: AzureAppServiceManageV0, AzureAppServiceSettingsV1, AzureFileCopyV2, AzureFileCopyV3, AzureFileCopyV5, AzureFileCopyV6, AzureFunctionsAppContainderV1, AzureFunctionAppV1, AzureFunctionAppV2, AzureFunctionOnKubernetesV1, AzureKeyVaultV1, AzureKeyVaultV2, AzureMysqlDeploymentV1, AzurePowerhShellV4, AzurePowerhShellV5, AzureResourceGroupDeploymentV2, AzureResourceManagerTemplateDeploymentV3, AzureRmWebAppDeploymentV3, AzureRmWebAppDeploymentV4, AzureSpringCloudV0, AzureVmssDeploymentV0, AzureWebAppContainerV1, AzureWebAppV1, ContainerBuildV0, HelmDeployV0, HelmDeployV1, JenkinsDownloadArtifactsV1, KubeloginInstallerV0, KubernetesManifestV1, KubernetesV1, PackerBuildV0, PackerBuildV1
Description: Fixed a bug with MSAL library for Node 10 runner (when AGENT_USENODE10 knob is used)
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y AB#2194313
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

/azp run

/azp run

/azp run


Add Profile Modal to Navigation without Using Backdrop

I propose to add a profile modal which will contain all the three button which will contain all the three of the action buttons
that is

profile
settings
sign out
@daccotta please assign this task to me
have raised PR #83

@sid0000007 thank you for assigning this to me i have completed this task and raise #83, kindly appove my pr


Issue with the app after updating to v0.11.1

Thats what I did:
1- sudo apt remove ipfs-desktop
2- Installed the new v0.11.1 deb file (same result with appimage)
Now when I start ipfs-desktop I think it opens 2 ipfs-desktop instance.
It wont show up in systray and it wont connect with my Galacteek app.
Everything seems broken. Although I see peers so im connected with the network.
Im a non-technical user best I can do sry. I've the terminal history for you. Plz help. Thx!
MX Linux MX x86_64 (no systemd)
Kernel: 4.19.0-6-amd64
DE: Xfce
$ ipfs-desktop
2020-04-29T19:11:03.875Z info: [meta] logs can be found on /home/danrobi/.config/IPFS Desktop
Checking for update
Error: Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'
2020-04-29T19:11:04.591Z error: [updater] Error: ENOENT: no such file or directory, open '/opt/IPFS Desktop/resources/app-update.yml'
(electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".  It will change to be "true" in Electron 9.  For more information please check https://github.com/electron/electron/issues/18397
2020-04-29T19:11:05.040Z info: [web ui] window ready
2020-04-29T19:11:05.041Z info: [web ui] navigate to /
2020-04-29T19:11:05.058Z info: [tray] starting
2020-04-29T19:11:05.101Z info: [tray] started
2020-04-29T19:11:05.103Z info: [ipfsd] start daemon STARTED
2020-04-29T19:11:06.292Z info: [daemon] PeerID is Qmbu6...
2020-04-29T19:11:06.293Z info: [daemon] Repo is at /home/username/.ipfs
Error: ENOENT, node_modules/countly-sdk-nodejs/data/__cly_event.json not found in /opt/IPFS Desktop/resources/app.asar
    at createError (electron/js2c/asar.js:111:17)
    at Object.func [as openSync] (electron/js2c/asar.js:146:27)
    at Object.writeFileSync (fs.js:1265:35)
    at storeSet (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1337:16)
    at add_cly_events (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:498:13)
    at Object.Countly.add_event (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:475:13)
    at Object.end (/opt/IPFS Desktop/resources/app.asar/src/common/logger.js:50:19)
    at startIpfs (/opt/IPFS Desktop/resources/app.asar/src/daemon/index.js:65:11)
    at async module.exports (/opt/IPFS Desktop/resources/app.asar/src/daemon/index.js:120:3)
    at async run (/opt/IPFS Desktop/resources/app.asar/src/index.js:72:5)
2020-04-29T19:11:06.296Z info: [ipfsd] start daemon FINISHED 1.189671929001808s
2020-04-29T19:11:06.315Z info: [ipfs on path] no action taken
2020-04-29T19:11:06.315Z info: [launch on startup] disabled
Error: ENOENT, node_modules/countly-sdk-nodejs/data/__cly_queue.json not found in /opt/IPFS Desktop/resources/app.asar
    at createError (electron/js2c/asar.js:111:17)
    at Object.func [as openSync] (electron/js2c/asar.js:146:27)
    at Object.writeFileSync (fs.js:1265:35)
    at storeSet (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1337:16)
    at toRequestQueue (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:985:13)
    at Timeout._onTimeout (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:354:17)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
Error: ENOENT, node_modules/countly-sdk-nodejs/data/__cly_queue.json not found in /opt/IPFS Desktop/resources/app.asar
    at createError (electron/js2c/asar.js:111:17)
    at Object.func [as openSync] (electron/js2c/asar.js:146:27)
    at Object.writeFileSync (fs.js:1265:35)
    at storeSet (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1337:16)
    at toRequestQueue (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:985:13)
    at Timeout.heartBeat [as _onTimeout] (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1007:17)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
Error: ENOENT, node_modules/countly-sdk-nodejs/data/__cly_event.json not found in /opt/IPFS Desktop/resources/app.asar
    at createError (electron/js2c/asar.js:111:17)
    at Object.func [as openSync] (electron/js2c/asar.js:146:27)
    at Object.writeFileSync (fs.js:1265:35)
    at storeSet (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1337:16)
    at Timeout.heartBeat [as _onTimeout] (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1014:13)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
Error: ENOENT, node_modules/countly-sdk-nodejs/data/__cly_queue.json not found in /opt/IPFS Desktop/resources/app.asar
    at createError (electron/js2c/asar.js:111:17)
    at Object.func [as openSync] (electron/js2c/asar.js:146:27)
    at Object.writeFileSync (fs.js:1265:35)
    at storeSet (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1337:16)
    at /opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1037:17
    at IncomingMessage.<anonymous> (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1197:25)
    at IncomingMessage.emit (events.js:215:7)
    at endReadableNT (_stream_readable.js:1183:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
Error: ENOENT, node_modules/countly-sdk-nodejs/data/__cly_queue.json not found in /opt/IPFS Desktop/resources/app.asar
    at createError (electron/js2c/asar.js:111:17)
    at Object.func [as openSync] (electron/js2c/asar.js:146:27)
    at Object.writeFileSync (fs.js:1265:35)
    at storeSet (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1337:16)
    at /opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1037:17
    at IncomingMessage.<anonymous> (/opt/IPFS Desktop/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1197:25)
    at IncomingMessage.emit (events.js:215:7)
    at endReadableNT (_stream_readable.js:1183:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
2020-04-29T19:11:52.440Z info: [web ui] window hidden
2020-04-29T19:11:57.659Z error: [web ui] crashed: [object Object]
Terminated

I refered this issue to Galacteek because Galacteek wont connect to the network since ipfs-desktop update issue.

/cc @lidel

I tested this on Debian 10 with empty profile and was unable to reproduce.
Sounds like problem specific to one user.
@danrobi11 quick feedback:

are you running go-ipfs manually, or letting ipfs-desktop take care of it? try shutting down everything, ipfs-desktop comes with go-ipfs inside.
if possible, start from scratch:

if you have important data in your repo (~/.ipfs/), back it up by compying to a safe locaiton before you remove anything
then remove everything with rm -rf ~/.ipfs ~/.ipfs-desktop ~/.config/Electron ~/.config/IPFS\ Desktop
kill all electron processes running in background: killall electron
(you may have those if you miss tray icon)
start IPFS Desktop again

missing Tray icon is a know issue on some Linux distributions. We can't do anything about it, see potential workaround  for various linux desktops in README#no-tray-icon-on-linux

Let us know if anything of this helped.

I've tried ipfs-desktop-0.11.1 with the AppImage and didn't have any issue. I had no preexisting ~/.ipfs-desktop.

killall electron give me this:
electron: no process found
Even if ipfs-desktop is running I've: 'electron: no process found'
Is this because im not running systemd?
@lidel  You might have tried to reproduce with debian 10 but debain 10 does run systemd and im not.
I installed 'xfce4-statusnotifier-plugin' and that fixed the systray issue, thx!
ipfs-desktop working now with Galacteek, thx!

This is most likely not related to systemd, i don't use systemd either

@danrobi11 don't worry about electron: no process found is okay, it means there is no IPFS Desktop running in the background (we just wanted to be sure). It is not related to systemd in any way.
It sounds like xfce4-statusnotifier-plugin  solved your original problem, so I am closing this as fixed. Thank you for letting us know it helped!

@lidel 'is okay, it means there is no IPFS Desktop running in the background'
No as I said above it gives me this result even tho ipfs-desktop is running


[jaeger-v2] Fix e2e storage integration v0.99.0 OTEL col failing

Which problem is this PR solving?

Fix failing CI at all of the v2 storage integration #5397

Description of the changes

Change the spanWriter log level to DEBUG
Enable retry to integration spanWriter

How was this change tested?

Run make jaeger-v2-storage-integration-test until it fails since it has a low probability of reproducing the same error

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[ ] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

Is this related to #5418?

Is this related to #5418?

No, I haven't figured out why cassandra v2 test is failing.

Try to add more details to the description.

What was the observable problem after upgrade? I.e. how did it manifest?
What do you believe the root cause was?
How does the change fix the root cause?

Do you think adding retry to integration spanWriter and jaegerexporter is good enough? Actually, I wasn't able to break down the cause of this issue since it is hard to replicate locally.

What was the observable problem after upgrade? I.e. how did it manifest?

My assumption was because of OTEL col changed the ToClientConn gRPC implementation from DialContext to NewClient here https://github.com/open-telemetry/opentelemetry-collector/pull/9965. Both integration spanWriter and jaegerexporter use OTLP exporter which creates the gRPC connection through the ToClientConn above.

What do you believe the root cause was?

From the #5397 PR failing CI at Badger and gRPC storages, Badger failed only at GetServices and GetOperations while gRPC failed at GetServices, GetOperations, and FindTraces.
Since both of them failed at GetServices and GetOperations, I'm assuming the "spanWriter OTLP exporter" to "OTEL col binary OTLP receiver" connection has not yet been successfully settled.
Then, the Badger storage doesn't have any issue with the FindTraces because it cleanup the storage with purge() functionality but the gRPC restarts the remote storage server. With the same assumption, the gRPC connection from OTEL col to the remote storage server probably has not been settled yet.

How does the change fix the root cause?

My intention from creating this PR is actually to try out my hypothesis since I almost can not replicate this (I created a script to loop indefinitely until the test returns other than 0). But turns out by retrying the requests passed the CI test.


Cross-targeting dispatch to inner builds should be parallelized

See https://github.com/Microsoft/msbuild/pull/1063#pullrequestreview-1059961

Related to https://github.com/Microsoft/msbuild/issues/1276.

We think this is completed. Re-open if not. Thanks!

 If that's still the case can you expand on it please?

All I'd like is that I always get the option to not run the build in parallel by default. I am currently setting $(BuildInParallel) to false.

My compiler unlike Roslyn cannot handle more than one compile in the same process.

Can you write the file to obj (that is, $(IntermediateOutputPath))? That should be unique per TFM build.

The code includes the generated file via #include so I'd have to make the compiler read it automatically instead.


560: Tombstone test fixes as a result of not clear local variable

@yuval pls review . for some reason the unit test passed on the CI but not on the mac. now it is passed on the mac as well
it must inserted to the version... no need performance test to it

toda!!!


Error in javascript code

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x ] Correction or update

Details
The code example on this page does not work, I get an error in the console. I am not able to fix it since I am a beginner javascript coder. I tested both to write it and to copy/paste it, I get the same error.

https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableRowElement/insertCell

Hi there @susanneeneroth !
I tried looking at the page, and the example on there works for me absolutely fine, no error. Do you mean that you are getting an error when you go and look at the page? Or are you getting an error when you try to use the code in one of your own examples?
If it is the latter, are you able to put your code in a codepen and then give me the URL so I can have a look at it?
What browser are you using?

Hi @chrisdavidmills !
Sorry, just realized I put the script src in the wrong place... I thought you could put it inside the .
It work when it is in the body. But the strange thing is that I get an error message that you can't insert row of null. Shouldn't the logical error message be that it can't find the source?

Cool, glad you have figured it out.

But the strange thing is that I get an error message that you can't insert row of null. Shouldn't the logical error message be that it can't find the source?

Well, it kind of does make sense if you are trying to insert a row, and the reference to the row doesn't exist (e.g. you might have put a typo in the row name variable). "Can't find source" is a kind of vague terminology that means something different depending on context, whereas saying the row is null means something very specific in the context of the JavaScript we are dealing with. There is often a balance with the error messages, between machine-reportable, and huma-readable.

Thanks for the input on that :).
But I find it illogical in this case, since there wasn't an error in the code, which it made me think it was... and since the source was not rightly put in the HTML-file, the console should not be able to find or read any of the JavaScript at all. At least that is what I think. It would at least be more helpful for a newbie :).


Duplicate constants

Many of the constants which are earlier EM related are now duplicated in two places (Autotune Constants and EM Constants) based on their usage in the project each individual constant should be placed and accessed from their appropriate location in the autotune project

Closing the issue as #507 is merged


postgres flavour - no method "returning"

I have the following code:
var squel = require("squel");
squel.useFlavour('postgres');
var sql = squel.insert()
               .into('myTable')
               .returning('id')
               .toParam();

it fails during run time with the error:
Failed: Object insert into myTable has no method `returning`

The useFlavour() call returns an instance of squel with the right flavour
setup. So you need to use that instance to build your queries with. This
was a recent change.
var squelPostgres = squel.useFlavour("postgres");

On 11 July 2015 08:29:18 "Dmitry A. Efimenko"<EMAIL_ADDRESS>wrote:

I have the following code:
var squel = require("squel");
squel.useFlavour('postgres');
var sql = squel.insert()
               .into('myTable')
               .returning('id')
               .toParam();

it fails during run time with the error:
Failed: Object insert into myTable has no method `returning`

Reply to this email directly or view it on GitHub:
https://github.com/hiddentao/squel/issues/171

it worked, thanks!


 See #1112.
@mcgibbon I think the two big work items were

Refactoring vcm.Preloaded
The BPTT code itself

1 should be easier than 2. Let me know when it is ready, and I will cherry pick the relevant commits to this branch. Then, we can merge this PR to master. At this point, #1112 will only contain changes relevant to BPTT, which can probably go into master directly as a single squashed commit. Sound good?

Preloader->OneAheadIterator refactors are ready (pending passing tests, they passed locally), should be commits a9220cc2dbde72d035abcb212faffbd6f0ce9aca and 7512d19ce39192ca8f24642080f1b25ae152dba5.

I merged the OneAheadIterator changes, and squashed them into one commit. For some reason, #1112 still shows the PreLoaded Features in the files changed tab, but ony fv3fit changes appear in the git diff:
$ git diff bptt-part-2 feature/atomic_bptt --stat                                                                                (fv3net)
 external/fv3fit/fv3fit/__init__.py                |   1 +
 external/fv3fit/fv3fit/_shared/__init__.py        |   8 +-
 external/fv3fit/fv3fit/_shared/io.py              |  18 +++-
 external/fv3fit/fv3fit/_shared/packer.py          | 202 +++++++++++++++++++++++++++++++++++-----
 external/fv3fit/fv3fit/_shared/scaler.py          |  19 ++--
 external/fv3fit/fv3fit/keras/__init__.py          |   1 +
 external/fv3fit/fv3fit/keras/_models/recurrent.py | 616 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 external/fv3fit/tests/test_bptt.py                | 292 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 external/fv3fit/tests/test_io.py                  |  15 +++
 external/fv3fit/tests/test_packer.py              | 109 +++++++++++++++++++++-
 external/fv3fit/tests/test_scalers.py             |  24 ++---
 external/vcm/vcm/cubedsphere/regridz.py           |  12 ++-
 external/vcm/vcm/cubedsphere/xgcm.py              |  21 ++++-


New Package: Resolume.Avenue version <IP_ADDRESS>81

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/110549&drop=dogfoodAlpha

[Policy] Needs Attention

@wingetbot waivers Add Validation-Domain

@wingetbot waivers Add Validation-Domain

@wingetbot waivers Add Validation-Domain

@wingetbot waivers Add Validation-Domain

/AzurePipelines run

@wingetbot waivers Add Validation-Domain

@wingetbot waivers Add Validation-Domain

https://github.com/microsoft/winget-pkgs/issues/111634

Made small update to update publisher like I did on Resolume.Arena package as that was required for meet review.
As I just pushed new version of Arena I can also do this for Avenue but as these two are tightly related wanted to get the 7.15 version in first before doing that.

@wingetbot waivers Add Validation-Domain

/AzurePipelines run

@wingetbot run

/azp run


Update import-into.md

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2e07f7bf559ba31adbdd891ea475b4e582a8a0e0/
Edited pages:

v19.2/import-into.md

@dbist thanks for the edit! Can you also edit the v20.1/import-into doc as well? Then I'll merge.

@lnhsingh updated, thanks

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e57e7d62f610e64c373cf75458617c4096ce82f7/
Edited pages:

v19.2/import-into.md
v20.1/import-into.md

LGTM


No code borders, different background color and buttons

Hi, I'm testing the Midnight theme and I can't get the colors to work.
See the colors on my website,

there are no gray borders around highlighted code,
the background linear gradient is lighter
and buttons on top look different

comparing to the Midnight theme website.
(I only changed the banner on top, by adding Testing text.)
I don't know, I built the site and tested it locally, then pushed to GitHub and built the site there, then forked the Midnight repository, and each time the resulting website has the same problem.

It was a browser related issue.


connection.end() example in npmjs.org seems to imply synchronous use

This is a newbie kind of issue.  I used mysql to communicate with a mysql instance on my local host. I followed the examples at https://www.npmjs.com/package/mysql.
When it was time for my app to close the sql connection, I followed the code example and used connection.end().  Being new to node, I was surprised when code execution marched right along after this connection.end()!  Further research, of course, showed me that I should have used a callback. I recommend that the documentation be updated to show something like this, which does close the connection gracefully:
connection.end(function(err) {
        if (err) throw err;
        console.log("BYE!");
  });

There is no reason to use a callback in connection.end(). You only need to use it if you want to know when the end has completed, as per the docs. Many things in Node.js cause an async action without providing any callback, even in Node.js core itself. This is a standard Node.js coding pattern.

Thanks, Doug. I appreciate the feedback! I really enjoyed using this package, and learned a lot from the wiki.

No problem! We try to put the examples as the simple / standard use-case to help get started. I don't think I ever use a callback with connection.end() since you don't really need to know when it ends, since it'll just automatically happen in the background once called (similar to calling .end() on Node.js core socket objects, .close() on Node.js core servers, etc.) though it's there in case you want to use it.
Some Node.js core objects (like sockets) don't even provide a callback argument to their .end() operations and require listening to an 'end' event, but we felt like having the optional callback would be slightly simpler than requiring users to register an event listener.


Feature: Documentation refactor

Motivation

Update docs to more closely match the repo-template
Add migration path diagram images
Add VS Code editor settings and recommended extensions
Disable dotnet format in CI pipeline

We can re-enable once all WIP branches have been merged and we have a single "format" PR

Update .editorconfig to match other integration repos

Checklist

[X] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[X] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
No functional changes have been made.
The README and other markdown can be previewed here.

@tkrch yup!


Fix checkstyle for spaces

Codecov Report

Merging #995 into develop will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             develop     #995   +/-   ##
==========================================
  Coverage      40.55%   40.55%
  Complexity       783      783
==========================================
  Files            158      158
  Lines           5688     5688
  Branches         806      806
==========================================
  Hits            2307     2307
  Misses          3209     3209
  Partials         172      172

Impacted Files
Coverage Δ
Complexity Δ

...icrosoft/azure/maven/function/utils/DateUtils.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...bapp/parser/V2NoValidationConfigurationParser.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...a/com/microsoft/azure/maven/webapp/ConfigMojo.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...zure/maven/function/template/FunctionTemplate.java
90.9% <ø> (ø)
7 <0> (ø)
:arrow_down:

...ven/function/template/FunctionSettingTemplate.java
70.83% <ø> (ø)
10 <0> (ø)
:arrow_down:

...ction/handlers/runtime/FunctionRuntimeHandler.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...azure/maven/webapp/parser/ConfigurationParser.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../webapp/handlers/runtime/WebAppRuntimeHandler.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...crosoft/azure/maven/spring/AbstractSpringMojo.java
46.07% <ø> (ø)
14 <0> (ø)
:arrow_down:

.../com/microsoft/azure/maven/webapp/utils/Utils.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf0c23...5e154fa. Read the comment docs.


User-defineable aliases (without writing a plugin)

It'd be nice if there was a way to add aliases without writing a plugin. For instance, in git, I can do:
$ git config --global alias.ci=commit

I could imagine something similar in Heroku:
$ heroku alias:add env=config

Basically this would require a configuration file beyond what we have now.
Perhaps ironically, this functionality could itself be a plugin, but the general point of this ticket is to consider making the alias functionality more accessible to the masses, even if it is a power user function.

Moved to DX issue tracker (seems tough to implement and want to think about it a bit first).

I should probably implement the ironical version first (do it as a plugin).

Might be a good idea actually.  That can certainly be a nice way to prove out a concept before trying to necessarily make it fit nice and work in every situation.  Happy to chat about it if you want.


Only api/**/*.rs can trigger a rebuild during dev

As repo https://github.com/Zxilly/data2image described, some files located in the src folder, update these files won't trigger a rebuild.
With debug logging
> [debug] [2024-07-19T19:56:25.493Z] Ignoring E:\Temp\imgShow\target\release
> [debug] [2024-07-19T19:56:25.493Z] Locating files E:\Temp\imgShow [2ms]
> [debug] [2024-07-19T19:56:25.495Z] Imported Builder "vercel-rust" from "E:\Temp\imgShow\.vercel\builders\node_modules\vercel-rust"
> [debug] [2024-07-19T19:56:25.495Z] Adding build match for "api/handler" with<EMAIL_ADDRESS>
Only the api/handler be set the build match.
I'm still diving into the vercel/vercel source tree. Maybe the maintainer can provide more info on these.

Might not be the prettiest solution, but you can use something like https://github.com/cortesi/modd in the meantime to trigger a rebuild based on a custom glob using vc build

I think this discussion should be moved to the other repo, feel free to raise this again once we have functionality in the custom runtime primities.

I thought there might be a way to provide the cli with what files are relevant to the project, but I didn't find an API for that, do you know anything about it?


math: Updated atanh implementation based on FreeBSD for improved accuracy and efficiency

math: Update atanh implementation based on FreeBSD for improved accuracy and efficiency
This pull request updates the hyperbolic arctangent (atanh) function in the math/base/special module. The changes are inspired by the FreeBSD implementation, aiming to improve accuracy and efficiency.
Key changes:

Improved accuracy for values close to ±1
Enhanced handling of edge cases (e.g., ±0, ±1, NaN)
More efficient computation for small input values
Better alignment with IEEE 754 standards

The updated function maintains the existing API while providing more reliable results across a wider range of inputs. Performance impact is expected to be minimal, with potential improvements for certain input ranges.
Implementation details:

Used bit manipulation techniques similar to FreeBSD's approach for improved precision
Leveraged stdlib's existing utilities (e.g., @stdlib/math-base-assert-is-nan, @stdlib/constants-float64-pinf)
Kept the function signature unchanged for backward compatibility

Testing:

Updated existing tests to cover new edge cases
Added new tests to verify improved accuracy for values close to ±1
Ensured all tests pass and maintain 100% coverage

This update addresses the concerns raised in issue #2089 and should provide a more robust implementation of the atanh function for stdlib users.
I welcome any feedback or suggestions for further improvements.

[x] Read, understood, and followed the contributing guidelines

@Deepakchowdavarapu This PR cannot be merged as is.

You have included other changes in this PR which are not related to atanh.
You did not perform what was requested in https://github.com/stdlib-js/stdlib/issues/2089. Namely, the implementation should be a port of the FreeBSD implementation.

As such, I will be closing this PR.


Tighter OS integration

Explore the options Conveyor has for native OS integration, and see if they're sufficient. If not, maybe explore Windows one-off stuff, if it's not a building/packaging nightmare. See https://github.com/paul-griffith/kindling/issues/46 for one idea.

See also Taskbar and SystemTray.

See also: Deep linking, built in to Conveyor:


Agency choice of preferred flag state should be a pull-down menu

As per the design at https://mongodb.invisionapp.com/share/VJXLVXNPGW4#/screens/424365384
Adding a preferred flag state should be picking from a country list.
We can use the country list (already localized to many languages) from:
https://github.com/umpirsky/country-list
It is an MIT license so acceptable to use.

Note that the value saved in the database should be the 2-digit country code.

Hey @Sheeri, happy to look into this one! Could you please share some context on what an agency's preferred flag states are used for throughout the app?

Absolutely! (one of the things I'm going to work on is a demo video of the app, btw, which should answer a lot of these).
Preferred flag state is used in the mobile app, when creating a boarding record. There is a field called "Flag State" which is the country the boat is registered to. Because each agency is working in a specific geographic region, there are countries that are more frequently seen than others. e.g. for the Galapagos islands, Ecuador and Panama are seen most often.
Preferred flag state is a list of up to 5 countries that will appear at the top of the menu selector in the mobile apps for Flag State. In this way, a user does not have to scroll down to Panama to select it, it is conveniently right at the top. (folks in the United States are very familiar with this - having USA and Canada right at the top of the list instead of having to scroll all the way down to select it.)
Let me know if that's not clear!

This is super helpful, thank you! Looking forward to the demo video :)
A couple questions:

If only up to 5 countries are displayed, is there a limit to how many flag states can be added?
I noticed the form data page currently looks a bit different to the designs linked above (screenshot of current page below). Is that something we're hoping to move toward, or are there updated designs somewhere?

I think a screenshot may be more clear. Here's the ios application - on the "vessel information" screen:

The "Flag State" space, when selected by the user, pops up a menu that looks like this:

ALL the countries of the world are represented, but Ecuador and Panama are given preferential treatment.
Note that they should be added in the order the user adds them, not necessarily alphabetical order. e.g. the preferred flag states might be:
United States
Canada
and they should appear like that in the list, with united states first. It just happens in this case that Ecuador is the most popular Flag State for this agency, which is in the Galapagos :D

We'd like it to look like the designs if possible. We totally understand if you keep the design elements as they are now, though. Completion of this ticket depends on the functionality, not changing the design to match; of course we'd be appreciative if things get moved towards that way!

Thanks for the clarification! This context is super useful.
I'll get the functionality for adding flag states working first! :) The design update for Agency Admins seems closely related to #176 and #177, so that'll be great to keep in mind when those get implemented.

Verified complete.


Refactor: fix spelling inconsistencies that is test pass message

Overview
All Tests Passed! and All tests passed! were mixed up.
They are used as an expected result of the test.
It was confusing when adding tests, so they were aligned to 'All tests passed!
Test

Awesome, thanks!


I210 merge

Merge the I210 network into master so everyone has access to it.

BTW! pydocstyle test has failed!

can you resolve the pep8 and pydocstyle issues?

Yes for sure, thank you for your other changes.

Pull Request Test Coverage Report for Build 5200

55 of 199 (27.64%)  changed or added relevant lines in 9 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 88.923%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flow/networks/i210_subnetwork.py
4
6
66.67%

flow/controllers/routing_controllers.py
2
8
25.0%

flow/core/kernel/vehicle/traci.py
9
20
45.0%

flow/core/experiment.py
13
25
52.0%

examples/param_sweep.py
0
20
0.0%

flow/visualize/time_space_diagram.py
9
37
24.32%

flow/envs/multiagent/i210.py
15
80
18.75%

Files with Coverage Reduction
New Missed Lines
%

flow/controllers/car_following_models.py
1
95.1%

Totals

Change from base Build 5185:
-1.2%

Covered Lines:
9039

Relevant Lines:
10165

💛  - Coveralls

I'll add some tests so that this doesn't drop coverage too much and then it looks ready to merge?

@AboudyKreidieh you down to merge this?

still need to write tests but then we can probably merge

What do you want to test before we merge this?

@AboudyKreidieh I have tests for everything but param_sweep.py


Update Angular2 version to 2.2.3

Update ng to use Angular version 2.2.3 instead of 2.2.1

I signed it!

@hansl Has the issue that made us lock the version been fixed? In that case we could change to ^2.2.3

@grizzm0 I believe so. See angular/angular@64bd672e3af793e210d876244869cb42b007e29e

@sarunint can you check the @googlebot  reply please?

OK

@googlebot I'm OK with the commit

@psantos10 I'm not sure why @googlebot is not responding.

@sarunint Did you sign the CLA at https://cla.developers.google.com/ ?

Googlebot is confused because there are multiple commits by different authors here. Can you squash to just @psantos10 please?

Otherwise I'll just make the PR myself.

@hansl squashed

@grizzm0 fix the version. We are working on making loose versions work again, but in the meantime we have to carefully update.

@psantos10 thanks for the squash. GoogleBot is happier :) Just need to fix the version and I'll get this in. Cheers!


fix(blob): typo, sumitter -> submitter

Overview

simple change in blob/service.go where a typo of sumitter existed in the Service struct, renamed to submitter

Checklist

[√] New and updated code has appropriate documentation
[√] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[n/a] Visual proof for any user facing features like CLI or documentation updates
[n/a] Linked issues closed with keywords

merged main in to hopefully fix lint ci

lint is going wild

wait what wtf i want a poap too


Block shifting columns

Hi everyone.
I wanted to know if there is a way to block the columns of a grid, so that the user cannot modify its position. I tried with the frozenColumn but the columns continue to shift.
Thanks.

as much as I know there is no native declarative way. Maybe you can try to catch something like onchage method in grid's typescript code.


Better instructions for using SDL2 ControllerMap

The README references https://github.com/gabomdq/SDL_GameControllerDB#sdl2-controllermap as a utility that can be used on all supported platforms, but the target link goes to the SDL2 download page and AFAIK there's no prebuilt version of ControllerMap included.
From there it's not obvious to figure out how to get the utility to extract controller mappings.
More importantly, I'm looking into it to retrieve mappings for Android gamepads, and the SDL2 build instructions for Android don't seem to cover generating somehow a usable version of the controllermap.c test to deploy on a phone.
CC @NY00123 who added a mapping in the past and might know what the process would be.
Cf. godotengine/godot#12696.

This DB is in service of development using SDL2, if it works in service of other software that is built on SDL2 or otherwise all the better, but support for building code from the SDL2 repo is out of scope here. If you need help building the Android utility app, you should look for support from the SDL2 project.
Here’s a direct link to the app in the SDL repo now (though it may well change location at a later date): https://hg.libsdl.org/SDL/file/1e585115ed86/test/controllermap.c
And instructions provided by the SDL2 project on building for Android: https://wiki.libsdl.org/Android

This DB is in service of development using SDL2, if it works in service of other software that is built on SDL2 or otherwise all the better, but support for building code from the SDL2 repo is out of scope here.

Well my intent is to have Android mappings contributed to this repository to better the development of SDL2 (and incidentally other applications using those bindings). So if this repository is the prime location to contribute new bindings before upstreaming in SDL2, I think it makes sense to have it document the workflow as best as possible.

And instructions provided by the SDL2 project on building for Android: https://wiki.libsdl.org/Android

Thanks, that seems good. I had looked at the README-android.md in the SDL2 repository but didn't think to look for more details in the wiki.
If I can extract a few easy steps to build test/controllermap.c specifically, I'll share them here.

This DB is informal and downstream of SDL2. If you want to “better the development of SDL2”, better to contribute directly to that project.

@akien-mga Feel free to contribute the documentation to our readme, or a new md file. I personally don't know how SDL are gathering their android mappings.
Good day


[Flink-13197] Fix Hive view row type mismatch when expanding in planner

What is the purpose of the change
This PR fix the row type mismatch for view expanding in planner, for example: row fields name and type mismatch.
Brief change log

In blink planner, add FlinkRelOptUtil#createCastRel to add cast rel based on specific conditions
Remove the type mismatch check in FlinkPlannerImpl for both planner
Add test cases for anonymous column and field type mismatch

Verifying this change
See tests in ViewExpansionTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Oops, there was check-style error, let me fix it.


Checkbox and radio - why waste "for" and "id"

Here is current checkbox from documentation:

  <input type="checkbox" class="custom-control-input" id="customCheck1">
  Check this custom checkbox

If I want to show list of checkboxes, I have to add unique id and for attributes for each input and label.  otherwise it will not be clickable. You may confuse and make mistakes when you have many checkboxes
To make it simple I suggest to replace outer div with label. No need id and "for" attributes. it is clickable
Here is it:

  <input type="checkbox" class="custom-control-input">
  Check this custom checkbox

Many reasons covered in our docs and past issues/PRs. See https://getbootstrap.com/docs/4.3/components/forms/#checkboxes-and-radios for an overview of input/label sibling elements to start.


[BUG] - ampinstmgr unable to read status of instances

Bug Report
After upgrade to newest version the ampinstmgr spits errors regarding checking of status of instances.
https://pastebin.com/EvcPA6e5
System Information

Operating System: Debian GNU/Linux 10 (buster)
AMP version and build date: 25/07/2019 15:16
Which AMP release stream you're using: Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms
See: https://pastebin.com/EvcPA6e5
Spits errors during upgrade, stop, start or any instance-operation.
Reproduction
Use newest ampinstmgr and try to upgrade all with -p or stop with -o or start with -a

Remove the ampinstmgr package, re-run apt update and reinstall the package. An update for this has just been dropped. Thanks for the report :)

My pleasure. Thanks for the support 😊
Von: PhonicUK
Gesendet: Donnerstag, 25. Juli 2019 18:14
An: CubeCoders/AMP
Cc: BenjaminBrauner; Author
Betreff: Re: [CubeCoders/AMP] [BUG] - ampinstmgr unable to read status ofinstances (#126)
Remove the ampinstmgr package, re-run apt update and reinstall the package. An update for this has just been dropped. Thanks for the report :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


StartTransactionPayload field name error

ocpp.v16.call.StartTransactionPayload 'reserveration_id' should be 'reservation_id'.

Hello @jchinnick-nuvation
Thanks for reporting  the issue! It will be fixed in the next release.


Deleting an app setting in a function app slot, clears tick for deployment slot setting in production slot

Describe the bug
I created a slot for a function app, and because of an (I think) issue, the app settings are copied from Production slot. Then I have to delete the app settings that I don't want this slot have.
After running the command for deleting the app settings from a slot, I realised that the ticks for deployment slot settings for the same config name in production slot is been cleared.
Command Name
az functionapp config appsettings delete -g MyRGName -n MyAppName --slot MySlotName --setting-names MySettingName

Errors:
no error.
To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Create a function app (MyAppName) in a resource group (MyRGName)
Add a setting (MySettingName) with a value and make it a slot setting:

az functionapp config appsettings set -g MyRGName -n MyAppName --setting-names "MySettingName=MySettingValue"

Create a slot:

az functionapp deployment slot create --resource-group MyRGName --name MyAppName --slot MySlotName

Delete the setting (MySettingName) from your newly created slot:

az functionapp config appsettings delete -g MyRGName -n MyAppName --slot MySlotName --setting-names MySettingName

Check the tick for slot setting for the MySettingName but in production slot.

Expected Behavior
Updating any configuration in a slot shouldn't affect other slots.
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.6.8
Installer: MSI

azure-cli 2.13.0 *

Extensions:
aks-preview 0.4.61
application-insights 0.1.1
azure-devops 0.13.0

functionapp

I have experienced the very same problem for appservice slots.
I have pin-pointed it to happen only if there's a single appsetting with the deployment slot setting option turned on in the production slot.
If there are more than one such appsetting, the clearing of the option does not seem to happen.
It also happens based on the name of the appsetting, i.e. if you issue a delete command on a differently name appsetting in the staging slot, the production slot is left untouched.
This happens with version 2.19.1 of Azure CLI, both when running under Azure DevOps and locally on Windows 10.

!@$%)%^)%  I just discovered the deployment slot checks were cleared on my production environment for my function apps!  THIS IS BAD!!!!!!!!!!!!  Fortunately it did not affect financial processing, but it is completely messing up other processing that are configured in a DEV/PROD scenario.
THIS IS BAD!!!!!!

function app service team should take a look


support stateful resource with create corresponding service

Description
support statefulset
Issue reference
Please reference the issue this PR will close: https://github.com/dapr/dapr/issues/4061
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[X] Created/updated tests
[X] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Please add tests to ensure it works.

In my opinion, it is unnecessary to introduce 'dapr_deployment_handler' and 'dapr_statefulset_handler', pls. try to use 'dapr_handler' to process both deployment and statefulset, and see if it works.

done. Use innerReconciler to implement multiple subscriptions for Deployment and StatefulSet.

I removed the Handler interface, because no module is directly dependent on the Handler interface.
The Reconcile() method used by k8s client but not dapr module. So the only method that makes sense in Handler interface is Init(). But the behavior of Init() is too broad to be appropriate as an interface. So I remove it directly.

/test

/ok-to-test

/ok-to-test

/ok-to-test

@artursouza can we add @beiwei30 to the list of users who can kick off cluster based tests?

Ping @artursouza

@theonefx pls. add more tests to make sure codecov/project pass.

@theonefx pls. add more tests to make sure codecov/project pass.

done

Thanks @theonefx! great PR.
Thanks @beiwei30 for reviewing.


Images and fonts not displaying from HTML

Using this code:
<?php

use Gotenberg\Gotenberg;
use Gotenberg\Stream;

require_once 'vendor/autoload.php';

$html = file_get_contents('../pdf/template.html');

$apiUrl = 'http://localhost:3000/';

$request = Gotenberg::chromium($apiUrl)
	->pdf()
	->outputFilename('test')
	->html(Stream::string('index.html', $html));

$filename = Gotenberg::save($request, '../pdf/saved/');

?>

The HTML has an img in it, as well as custom fonts, but the final PDF does not show the image nor fonts. What am I missing here?

You may have to send the assets (images, fonts) alongside your HTML content. See https://gotenberg.dev/docs/routes#html-file-into-pdf-route.

There is no documentation for how to do that in PHP, only cURL. Some instruction on proper methods or syntax would be nice. Right now I'm not even sure how to find that besides comb through the source code or just guess.

Indeed, in this case its not clear. What you're looking for is:
https://github.com/gotenberg/gotenberg-php/blob/e8bc519812349f7bd57b294b4ea41dce53693b7c/src/Modules/ChromiumMultipartFormDataModule.php#L166
For other form fields, it should be quite obvious as the methods share the same name.


Cardboard VR demo

We need a better VR demo than just the globe. I have an OK one here. It just uses a cut down version of the interpolation Sandcastle example and locks the camera behind the plane.
Maybe we could create CZML for the moving plane and keep the camera code. I can imagine use cases that people would want the camera code. For example, people could use the code to lock the camera to the cockpit of a plane.

@emackey can you get us a fighter jet or similar with a modeled cockpit? We were talking offline and it would be awesome to have the demo be a first-person cockpit view flying around the world, then you would just look out the window.  Should be a trivial amount of code and we can model the flight in STK and export a CZML file.

A hot-air balloon would also be cool.

:+1: We can always count on you @emackey!

@emackey that looks awesome!

@emackey absolutely love the new model!
Can you also donate this to the glTF sample models?

Random idea: In addition to the balloon the webVR user is riding in, have a handful of other balloons dotted around the sky to give a sense of scale and show things in the air, otherwise looking down is the only option.

@bagnell you still want to keep this open?


Polyfill detect source

Add support gated/feature detect

In the future, need to use this in PolyfillView or something when checking the gated flag.


Added ability to change location

Related Issue https://github.com/WildAid/o-fish-ios/issues/404
https://user-images.githubusercontent.com/52383559/163564377-6e097fa5-e17d-4d6b-a34b-b1b344ff9bd8.mp4
Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[x] I have commented on the linked issue
[x] I was assigned the linked issue (not required)
[x] I have tested the change to the best of my ability against the sandbox or a local build.

@Sheeri Fixed.


Finishing up

Description
This issue describes the set of tasks to complete in order to finish up work on the library.
Tasks

[ ] Touch base with the @jobarratt and @pwalsh to notify that you consider the work complete
[ ] Provide a short description / link to code for how each action is implemented, with a link to unit tests that prove each action
[ ] Tag your candidate code as v0.1
[ ] Setup travis to auto deploy tagged versions to the package management solution for your language
[ ] Ensure that the OKI account on the package management platform is an administrator/maintainer of the package, along with yourself
[ ] Receive code review from @pwalsh and address any remaining issues
[ ] Publish final version

@loleg
Ready to close?

@loleg
I'm closing meta issue as this stage is far behind us. Let's just use individual issues for everything left/reported/etc


AttributeError: 'DispatchingApp' object has no attribute 'config'

going through the tutorial on latest master, this exception is raised on flask run
(running inside a virtualenv)
>>> flask --version
Flask 0.11.2-dev
Python 3.5.2+ (default, Aug  5 2016, 08:07:14)
[GCC 6.1.1 20160724]
>>> which -v flask
/home/laerus/.venvs/flask/bin/flask (from PATH element 0)
>>> flask run
 * Serving Flask app "flaskr"
 * Forcing debug mode off
Traceback (most recent call last):
  File "/home/laerus/.venvs/flask/bin/flask", line 9, in <module>
    load_entry_point('Flask==0.11.2.dev0', 'console_scripts', 'flask')()
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/flask/cli.py", line 508, in main
    cli.main(args=args, prog_name=name)
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/flask/cli.py", line 374, in main
    return AppGroup.main(self, *args, **kwargs)
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args[1:], **kwargs)
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/home/laerus/.venvs/flask/lib/python3.5/site-packages/flask/cli.py", line 433, in run_command
    passthrough_errors=app.config['PROPAGATE_EXCEPTIONS'])
AttributeError: 'DispatchingApp' object has no attribute 'config'

git bisect points to 098ea0c8ca3b2f3c6715b1048bec6a42db6298e1


SBC Setup should use nmcli

First off my kudos for the wonderful work done with the turtlebots. That said, I think that the instruction on how to setup the network provided at https://emanual.robotis.com/docs/en/platform/turtlebot3/sbc_setup/#sbc-setup for foxy (and alike) should use nmcli to configure the WiFi -- perhaps as an alternative method.
Using nmcli it would be as simple as
$ nmcli d wifi connect WIFI-SSID password <password>
Of course this assuming that nmcli is installed -- which unfortunately is not on the image you provide. That could be solved by pre-installing it on your image or adding a reference to https://core.docs.ubuntu.com/en/stacks/network/network-manager/docs/installation
I'd be happy to contribute a pull request if that helps.

@kydos
Thank you for suggesting and contributing the nmcli. I will transfer this suggestion and my coworker will review the suggestion.
Thank you :)

@kydos
Thanks for the suggestion.
We're about to prepare the TurtleBot3 installation images for each ROS version.
This could be very useful after installing from the image then setting up the network.
Much appreciated!

Sounds good, let me know if there is anything I can help with.

This issue will be closed due to prolonged inactivity.


mixin: Scope grafana config

This PR fixes what was reported in comments in https://github.com/prometheus/prometheus/pull/8287
In its current form this configuration clashes in one of the most widely
used configurations (kube-prometheus). This patch scopes the
configuration to prevent this.
An alternative could be to revert https://github.com/prometheus/prometheus/pull/8287 until kube-prometheus can refactor the use of this mixin to not be affected. See: https://github.com/prometheus/prometheus/pull/8333
@beorn7 @paulfantom @metalmatze @roidelapluie
cc @elisiano

Yeah I referenced the issue to refactor kube-prometheus to do this, most of it is already done, just this particular issue was still possible.


Looking to help out

Hey I would like to help out can you make it so I can close issues, merge and stuff?

I cant push any of the updates im doing

tindolt, can you make PRs for now?

I cant make pull requests with github desktop

oh wait I gotta fork it dont I


Issue/8193 add new database connection pool setting

Description

[x] Add new settings for scheduler DB pool
[x] Add new setting for the server DB pool
[x] we default the new setting such that the server half of the old setting as default. Each scheduler gets 10% of the pool.
[ ] Document that every environment now needs a pool of its own
[x] add also to upgrade notes

closes https://github.com/inmanta/inmanta-core/issues/8193
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in 42830842a2e4d95cac4e19b3b090b461bcff46ef


bad_alloc in CppClient example

I installed carla via the debian package from http://dist.carla.org/carla-0.9.8/ and I built the C++ client library from source on commit 3a36b1637804bccc7b1dc82ef3dce607fd90ba14. When I try to run the C++ example from Examples/CppClient (built with make in that directory) the program crashes with:
Client API version : 0.9.8-269-g3a36b163
Server API version : 0.9.8
Loading world: /Game/Carla/Maps/Town02
WARNING: Version mismatch detected: You are trying to connect to a simulator that might be incompatible with this API
WARNING: Client API version     = 0.9.8-269-g3a36b163
WARNING: Simulator API version  = 0.9.8
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted

I built the client in debug mode and executed under GDB to get a stacktrace which shows the following:
[Switching to Thread 0x7ffff2fd1700 (LWP 11253)]
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff6c95801 in __GI_abort () at abort.c:79
#2  0x00007ffff7688957 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x00007ffff768eae6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007ffff768eb21 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff768eda9 in __cxa_rethrow () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x00005555558199ce in std::_Hashtable<unsigned int, std::pair<unsigned int const, carla::client::ActorSnapshot>, std::allocator<std::pair<unsigned int const, carla::client::ActorSnapshot> >, std::__detail::_Select1st, std::equal_to<unsigned int>, std::hash<unsigned int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_rehash(unsigned long, unsigned long const&) ()
#7  0x00005555558197f0 in carla::client::detail::EpisodeState::EpisodeState(carla::sensor::data::RawEpisodeState const&) ()
#8  0x000055555581413c in std::_Function_handler<void (carla::Buffer), carla::client::detail::Episode::Listen()::{lambda(auto:1)#1}>::_M_invoke(std::_Any_data const&, carla::Buffer&&) ()
#9  0x000055555583fd29 in boost::asio::detail::completion_handler<carla::streaming::detail::tcp::Client::ReadData()::{lambda()#1}::operator()() const::{lambda(boost::system::error_code, unsigned long)#1}::operator()(boost::system, unsigned long) const::{lambda()#1}>::do_complete(void*, boost::asio::detail::scheduler_operation*, boost::system const&, unsigned long) ()
#10 0x00005555557f6ff8 in boost::asio::detail::scheduler::run(boost::system::error_code&) ()
#11 0x00005555557f90e0 in std::thread::_State_impl<std::thread::_Invoker<std::tuple<carla::ThreadPool::AsyncRun(unsigned long)::{lambda()#1}> > >::_M_run() ()
#12 0x00007ffff76b96df in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#13 0x00007ffff7bbd6db in start_thread (arg=0x7ffff2fd1700) at pthread_create.c:463
#14 0x00007ffff6d7688f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Is this a known issue? Is there a known work-around?

Client and server versions need to match, otherwise you get this sort of errors. Client and server share a lot of raw data, it's not safe to ignore the warning unless you know for sure none of the networking code changed
WARNING: Version mismatch detected: You are trying to connect to a simulator that might be incompatible with this API

I guess I'm a little confused. Why is there a version mismatch between 0.9.8 and 0.9.8?

It is between 0.9.8 and 0.9.8-269-g3a36b163. These tags are extracted from git when you build, so 0.9.8 means the server was built at the commit pointed by that git tag, and 0.9.8-269-g3a36b163 means you built the client at commit 3a36b163, 269 commits ahead of 0.9.8. So potentially a lot of changes in between.

I was having the same issue but couldn't resolve it. The problem is when I build from source the client version never goes beyond 0.9.8

@gitmaster3000 This is probably because you have the "carla" Python package installed, so when you run the scripts this version is imported instead of the one you just built. Try
python -m pip uninstall carla

(using the same Python version you use with Carla).

OH MY GOD! You sir are jesus christ reincarnated.. THREE WEEKS, literally three weeks I have struggled with this and now it's solved. daaamn

The mismatch appears between 0.9.8 and 0.9.8-269-g3a36b163. These tags are extracted from git when you build, so 0.9.8 means the server was built at the commit pointed by that git tag, and 0.9.8-269-g3a36b163 means you built the client at commit 3a36b163, 269 commits ahead of 0.9.8. So potentially a lot of changes in between.

Oh I see. I was operating under the assumption that the extra bits were due to building from source and if there was an API change than one of the first three numbers would have changed. I understand now.
So I built the client from tag 0.9.8 and no longer see this bad_alloc, but I do see a segmentation fault when trying to use the waypoint API:
Thread 1 "carla-planner" received signal SIGSEGV, Segmentation fault.
0x0000555555815e16 in carla::client::Waypoint::GetNextUntilLaneEnd(double) const ()
(gdb) bt

Shall I describe this further here or shall I open a new issue?

@cheshirekow yeah, that looks like something else, better open a new issue.


Maintenance?

The last update was a year ago, maybe it should be marked as discontinued on pub or new maintainers should be assigned?

I have emailed him a couple months ago. No response

Sorry for the delay, I didn't take the time to answer this.
I don't have have enough time to maintain all the packages that need it for the moment and I'm currently experimenting another way to manage the state in Flutter.
I can give the repo to someone else if you want, but I would need to read how to do that on pub.dev also.

I have send you an email with the details for a transfer

I have taken over the maintenance from @letsar
kiwi 0.3.0 & kiwi_generator 0.5.0 are now available with the version fixes


xSPWebAppGeneralSettings not properly handling SecurityValidationTimeoutMinutes

Please provide the following information regarding your issue (place N/A if certain fields don't apply in your case:
Details of the scenario you try and problem that is occurring:
When specifying a value for SecurityValidationTimeoutMinutes, the value isn't making it to the Set-TargetResource and is being set to 0, breaking security validation.
The DSC configuration that is using the resource:
the issue is within the xSPWebAppGeneralSettings resource.
Version of the Operating System and PowerShell the DSC Target Node is running:
Win2012R2, WMF4
Version of the DSC module you're using:
dev branch
this is a result of changes I made to the resource in a prior pull request. I will fix and submit a new PR within the next day or so. I think I just messed up with the way I manipulate the parameter before it's passed into invoke-xSharePointCommand, should be an easy fix.
Please see the Contribution Guideliness for information on how to contribute.

All yours @MikeLacher448 - Thanks for reporting it!

Fixed in #280 - Closing this off


Remove TypeInfo::SelfType in favor of tracking the self type as a type param

Description
This PR removes the TypeInfo::SelfType variant instead uses the type parameters to contain the self type.
Blocker for #3744.
Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

- [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my feature works.

Superseded with PR #4962


URL/authservice is not exposed in istio via virtualservice for oidc-authservice

Describe the bug
In the Kubeflow 1.7 helm charts, oidc-authservice is using /authservice prefix which is not exposed via virtualservice. As a result URL/authservice is not accessible for Dex as a redirect URL .
Dex config map in helm chart:
    staticClients:
    - idEnv: OIDC_CLIENT_ID
      redirectURIs: ["/authservice/oidc/callback"]
      name: 'Dex Login Application'
      secretEnv: OIDC_CLIENT_SECRET

This will cause Dex to not return to oidc-authservice after the login and will show empty page.
Environment

Kubernetes version 1.24
Using EKS (yes/no), if so version? Yes
Kubeflow version 1.7

Closing due to no response


⚠ Bofrost.lu has degraded performance

In 8439d03, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1356 ms

Resolved: Bofrost.lu performance has improved in cf956d8 after 22 minutes.


register gcp account

@Ninolito Let's have a thorough discussion of this tomorrow. I think we can merge all vendors into one endpoint.


Use provider-specific truth literal in conditional

DefaultQuerySqlGenerator contains the following code for rendering conditionals:
if (expression.Test.IsSimpleExpression())
{
    _relationalCommandBuilder.Append(" = 1");
}

This doesn't work for PostgreSQL. We already have TrueLiteral and TypedTrueLiteral which are used elsewhere, this PR replaces the 1 with TrueLiteral.
However, it's not clear to me why a condition is necessary at all. In other words, instead of rendering WHEN x = 1 THEN y ELSE z END, why not simply render WHEN x THEN y ELSE z END? At least for PostgreSQL all the GearsOfWar tests (where a lot of conditionals happen) pass in this way.
As a workaround, I've overridden VisitConditional in Npgsql's QuerySqlGenerator.

However, it's not clear to me why a condition is necessary at all. In other words, instead of rendering WHEN x = 1 THEN y ELSE z END, why not simply render WHEN x THEN y ELSE z END?

Cool! That means in PostgreSQL Boolean values and search conditions are interchangeable. In other databases (in particular SQL Server family) we have to compensate when going both directions. It would be great if you could just override this for PostgreSQL.

@divega I don't really mind having WHEN x = 1 THEN ... if this is important for other providers. However, the current DefaultQuerySqlGenerator hardcodes the 1 rather than TrueLiteral, which might also be a problem for other providers...

This whole statement block is no longer needed 😄
With recent changes to convert bool to search conditions, we already convert simple expression into search condition so there is no longer any need to compensate anywhere in the code like this.

@divega - Should I do PR to remove this compensations happening in other places? Also need to include converting parameters to search condition. Both complemented each other and did not raise error.
Further given that PostgreSQL doesn't require conversion and we have code for converting in Relational level, what should be the strategy for provider writers to opt out of it?

The whole check is removed from DefaultQuerySqlGenerator in #5729

Great, thanks!


Hide 'Show only Brexit results' if filtering on the Brexit Topic.

When we navigate from the Brexit Topic Page, we set the 'topic'
parameter to the Brexit content_id which filters the results
accordingly.
This means that the checkbox 'Show only Brexit results' should
be removed because selecting or deselecting it will have no
effect and is likely to confuse users.
With topic parameter - does not show the checkbox

Without topic parameter - does show the checkbox

Search page examples to sanity check:

http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/search/all
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/search/research-and-statistics
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/search/news-and-communications?parent=%2Feducation&topic=c58fdadd-7743-46d6-9629-90bb3ccc4ef0
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/drug-device-alerts
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/find-eu-exit-guidance-business
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/find-eu-exit-guidance-business?keywords=eori&order=relevance
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/find-eu-exit-guidance-business?sector_business_area%5B%5D=aerospace&order=topic
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/uk-nationals-living-eu
http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/prepare-business-uk-leaving-eu

Other finders

Gee, it'd be just dandy if those links to the preview app were populated 👀 😉


Velocity is not defined when process.env.NODE_ENV === 'test'

One of the recent PRs added the following check https://github.com/twitter-fabric/velocity-react/commit/6e6d505c9556089d587b48ca531708e9ab2117e9 which breaks tests running in real browsers.
When I run tests with karma + karma-webpack(and NODE_ENV=test) I get the following exception:
TypeError: Cannot read property 'removeData' of undefined
    at Constructor._clearVelocityCache (http://localhost:9876/base/test/index.js?0bc9e53dbd6efbdb25d8eea4591af0bf094c9d64:70135:26)

because Velocity.Utilities is now undefined:
https://github.com/twitter-fabric/velocity-react/blob/614b3b2f7687888e9cf418351c243a7792178d6d/velocity-component.js#L154
I wonder if there's a better way to detect jsdom.
Maybe we could use something like https://github.com/tmpvar/jsdom/issues/1537#issuecomment-229405327 instead?

Looks like this is an issue with the new garbage collection, as it uses a Velocity API that's not shimmed out in server / test mode. Will get a new release out presently.

Thanks.
What do you think about using a different approach for detecting Node.js?
process.env.NODE_ENV is commonly used by webpack (DefinePlugin) and browserify (envify).
How about detect-node?

Oh, sorry never mind, I didn't realize that a PR has already been merged 😄
https://github.com/twitter-fabric/velocity-react/pull/130

Thanks. good way to detect node

Should be fixed in 1.1.7.

Thanks 👍