slate-lists: Cannot customize types

Because slate custom types are declared here:
https://github.com/prezly/slate/blob/master/packages/slate-lists/src/index.ts#L6-L12
I'm having trouble creating my own custom types:
Subsequent property declarations must have the same type.  Property 'Text' must be of type 'TextNode', but here has type 'CustomText'.ts(2717)
index.d.ts(9, 9): 'Text' was also declared here.
(property) CustomTypes.Text: TextNode

What's the right way to customize types when using this plugin? Maybe that module declaration shouldn't be in the package?

Hi @greypants!
You are totally right that at the current state the type system is not really extensible. It's on our ToDo list to have the package less hard-coded on the supported node types. One step towards that direction we already did with #36, but there's more work to be done.
Can you please describe your use case so I better understand what you're trying to achieve?
Thanks!

Sure - I'm building a Slate-based editor with custom features and was following the TypeScript section of their docs here: https://docs.slatejs.org/concepts/12-typescript#best-practices-for-element-and-text-types
For example, here's my Text definition:
export interface FormattedText {
  text: string;
  bold?: boolean;
  italic?: boolean;
  underline?: boolean;
  fontSize?: number;
}

export interface EmptyText {
  text: string;
}

export type CustomText = FormattedText | EmptyText;

declare module "slate" {
  interface CustomTypes {
    // Can't override - already defined in @prezly/slate-lists
    Text: CustomText;
  }
}

I had to comment out the declare module "slate" block after adding the @prezly/slate-lists library.  So now all the types are being inherited from this package, rather from my own definitions.

If the plugin requires some base types, would it make sense to export those base types and have consumers extend them?
import { CustomText as PrezlyCustomText } from "@prezly/slate-lists";

...
type CustomText = PrezlyCustomText & FormattedText

declare module "slate" {
  interface CustomTypes {
    Text: CustomText;
  }
}

My instinct says that a plugin shouldn't declare module "slate" - that's something that the editor code itself should do, right?

Also - THANK YOU FOR OPEN SOURCING THIS CODE! I was really struggling trying to get nested lists working. This plugin saved me days of work - the API is pretty perfect 👍🏽

My instinct says that a plugin shouldn't declare module "slate" - that's something that the editor code itself should do, right?

Yes, that's exactly what I had in mind :+1:
I have been handed this package over last month and still didn't get to fixing this problem. Will try to address this next month before end of year.

Hi @e1himself!
Are there any news regarding this issue? I`m currently running into the same problem and i'd very much love to use your slate-list package, as it is very well written and documented!
Thanks a lot in advance!

@wildf1r3 @greypants Please take a look at this PR I have here: #148. The plan is to merge and release it somewhere next week.

I'm super late, but finally got around to upgrading. Works great! Thanks so much 👍🏽

@greypants
Great to hear! Thanks for reporting back. :+1:
Happy coding :wink:


Roll engine dependency forward

Pick up engine dart roll as well as few other changes that were done since last engine roll yesterday.

LGTM

This is blocked on https://github.com/flutter/flutter/issues/12089.

Do we know why the aot_snapshot_size_isolate dropped by a half in Dart 2? Smaller code size is good, just want to make sure the drop was expected, that there's no regression lurking somewhere.

This is as expected: https://github.com/dart-lang/sdk/issues/30616
On Sep 16, 2017 11:34 AM, "Yegor"<EMAIL_ADDRESS>wrote:

Do we know why the aot_snapshot_size_isolate dropped by a half in Dart 2?
Smaller code size is good, just want to make sure the drop was expected,
that there's no regression lurking somewhere.
[image: screen shot 2017-09-16 at 11 33 37 am]
https://user-images.githubusercontent.com/211513/30514887-ed7e027c-9ad2-11e7-8e7a-3bbe76486826.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/pull/12087#issuecomment-329986855,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXQ0awwbOGCAUSYwemizJrr29XNf5ljks5sjBSegaJpZM4PX6Cs
.

Looks like it also regressed flutter_gallery_ios__transition_perf missed_frame_build_budget_count.


[#3132] feat(api,core):  Perform a more elegant validation of User, Group and Role NameIdentifier

What changes were proposed in this pull request?
add checkUser, checkGroup, checkRole in NameIdentifier
Why are the changes needed?
Fix: #3132
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
ut

@yuqi1129 @qqqttt123 could you please help to review it

@qqqttt123 I was wondering if we should move ofUser...  in AuthorizationUtils to NameIdentifier, which is be aligned with other nameIdentifier creation

Could you avoid the concept of NameIdentifier to users? User/Role/Group use some virtual catalog, schema. It's not visible to users. The api module will be exposed to users.

Could you avoid the concept of NameIdentifier to users? User/Role/Group use some virtual catalog, schema. It's not visible to users. The api module will be exposed to users.

got it, i will move it into AuthorizationUtils

Yeah, it is not good to expose the name identifier for user, group to the API. Even if we expose this, user may not know how to use it.


Split Install and Test for Non-From Source Runs

Look into splitting the install and test running steps for non-From Source builds as we did for the From Source builds. The non-From Source runs use the -am switch when triggering testing which will cause it to run tests for anything it have a source dependency on. Instead run install without testing using the -am then run another step of surefire:test (along with Jacoco test coverage) which only runs the modules in that pipeline.
@JimSuplizio @conniey

This was done


feature request: select into window on the right

Did you check existing requests?

[X] I have searched the existing issues

Describe the feature
Hi all,
I added a keymap that always opens Oil in a vertical split on the left. Now I want to open the selected buffer in the next split to the right and create a new split if there is none.
I know that I can pass vertical = true to oil.select() but unfortunately it doesnt check if there already is an open split on the right.
Is it possible to achieve this?
This screenshot shows my config + the opening behaviour with oil on the left site:

Provide background
I'm trying to have a similar experience to NvimTree in Oil.
What is the significance of this feature?
cannot use this plugin without it
Additional details
No response

Layouting stuff has unbounded complexity and you can code your own split behavior, so from my point of view, this does not belong into the plugin.

Vim and Neovim unfortunately offer no API for sane window positioning and the session file neither looks great (a bunch of hard to decipher splits with vimscript).


Inferno Campaign - Deal with the Devil

The dogs are too distracting. Try maybe this, inferno spell.

The dogs could land at the bottom of 2nd column on page 35.


Adjust markdown formatting for consistency

While working on #1866, I noticed that there are some Markdown inconsistencies in the articles. In this PR, I fixed some of these.
I also added uids to articles where it was not yet specified.

@riccikl - Thank you.


Sub-domain instead of IP

Why can't I use a sub-domain instead of the IP? (Example: s1.domain.com). Some servers have this.
A-Record is set, but server does not start.
Would it be possible to include this?

Why can't I use a sub-domain instead of the IP? (Example: s1.domain.com). Some servers have this. A-Record is set, but server does not start.
Would it be possible to include this?

The IP Address section on WGSM is for local network not for public IP for the router to find the appropriate machine where the server is installed


Create an executor parameter to allow for custom executors

Describe Request:
A static executor is currently defined in the check job, but this does not allow for any executor customisations. Allow for a custom executor to be used in place of this, if required
Examples:
Sample future config:
version: 2.1

orbs:
  shellcheck<EMAIL_ADDRESS>
executors:
  my-small-executor:
    docker:
      - image: cimg/base:stable
    resource_class: small

workflows:
  my_workflow:
    jobs:
      - shellcheck/check:
          dir: ./myScripts
          exclude: SC2148
          executor: my-small-executor

Supporting Documentation Links:
n/a

Adding agreement here. Another issue/scenario is that, on a CircleCI Enterprise install, I've run into issues where we're hitting image pull limits for the cimg/base image. Normally, we would handle this by mirroring the image in an internal registry and pulling from there instead, but the fact that the executor/base image is not configurable makes this not possible with the current structure of the orb.

I took a look at implementing this, but believe that doing so would require/introduce a backcompat break.
The issue I run into is that if executor is added as a parameter, a default can be set, but that default must be a static value, and this would break current uses cases where callers specify a value for image-tag.
Semantically, for backcompat, it would be necessary for the default value of executor to pass through the parameter provided to image-tag, but I don't think that's possible in the current manner that orbs are defined. As such, introducing executor as a parameter would require either breaking backcompat for the job or introducing a new version of the job that takes this parameter.
However, will note that is both #64 and #56 are resolved, that would "solve" the specific issue brought up here -- even though the executor couldn't be specified as a parameter, the image name and resource type could still be configured.


Error running joystick_ros2 on ROS2 foxy (Ubuntu 20.04)

Running ros2 run joystick_ros2 joystick_ros2 on ROS2 Foxy gives the following error. I built the package using colcon build --packages-select joystick_ros2 (with warnings about package.xml.
Traceback (most recent call last):
File "/home/slickmind/Documents/e2e/e2e_ws/install/joystick_ros2/lib/joystick_ros2/joystick_ros2", line 11, in
load_entry_point('joystick-ros2==0.0.1', 'console_scripts', 'joystick_ros2')()
File "/home/slickmind/Documents/e2e/e2e_ws/install/joystick_ros2/lib/python3.8/site-packages/joystick_ros2.py", line 273, in main
joystick_ros2 = JoystickRos2()
File "/home/slickmind/Documents/e2e/e2e_ws/install/joystick_ros2/lib/python3.8/site-packages/joystick_ros2.py", line 189, in init
self.publisher_ = self.create_publisher(Joy, 'joy')
TypeError: create_publisher() missing 1 required positional argument: 'qos_profile'
Please let me know if I am missing something here.

My fix for ROS2 Foxy:
Line 189 change from self.create_publisher(Joy, 'joy') to self.create_publisher(Joy, 'joy', 10)


Document installation requirements for minimal environments (#948)

This PR adds documentation about the dependencies bash, git, and glibc. Fixes #948.
Motivation

As per #948, there are some undocumented installation requirements worth calling out explictly.
Test plan

You need to keep this:
We use static linking on both platforms, so it should not depend on system libraries.

Sorry, didn't intend to drop that, have put it back in.

Thanks

This is excellent, thank you!
We've got some stringent linters set up for the documentation, so this currently has a non-passing build, but it's easy enough to fix: can I ask you to run ./tools/scripts/format_website.sh in the root of your branch and push the changes? That'll let it get through CI, and we can merge.

Sorted.


clip.exe copy limit

It seems that tmux-yank does not work for me in WSL with clip.exe if I am trying to copy over 1700-1800 lines.  It may be related to the number of characters I'm copying so YMMV.
I thought there may be a limit in Windows with clip.exe, but I tested copying a file with around 3 million lines with "clip.exe < file" it works even if it takes a minute or two to complete.
Is there any chance there is some sort of limit imposed when using clip.exe?

@taylankasap no I was just using that as a reference to get an idea of the approximate lines.  If I am over the limit, the clipboard just doesn't get overwritten using tmux-yank.  That is opposed to cat somefilecontaininga100klines | clip.exe which works (takes a moment).
I'm wondering if tmux-yank has some timeout limit that if the application it's passing the text to (clip.exe) takes to long to complete and then we're left with none of it.


Update toolchain to nightly 2023-08-04

Description of changes:
bump toolchain to nightly-2023-08-04
Call-outs:

disables tests/expected/slice_c_str/c_str.c because of ongoing refactor of c_str_literals https://github.com/rust-lang/rust/issues/105723

Testing:
CI tests are passing. Built and tested on Apple M1.
Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

It looks good. I was just wondering if there's any specific reason why you updated our dependencies. If there's no reason, can you please revert those changes and push a separate PR?
BTW, thanks for fixing the documentation warnings. We should probably enforce no warnings in our CI but not here.
Thanks again!

there's a clang-format-14 reports formatting error on the vec.c stub, but I could not reproduce it locally so I could not fix.


fix(icon): default icon bug fixed

What is the bug that this fixes? Please add context for review.

[test]


Updated Script.js file

Added "JavaScript Interest Calculator" project details in the script.js file.
Related Issue

Info about Issue or bug

Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots
Put any screenshot(s) of the project here.

Thanks for this awesome contribution. :star_struck:
Keep Contributing


Online music library integration - favourited albums are not displaying in New Music LMS menu

Not sure how many people use this feature, but I got used to it using the previous plugin version. When adding an album to favourites on Deezer and rescanning online library, the album gets added to the library, but is not displayed in New Music.

I was playing around with my library.db and it appears that the cause of the issue is that timestamp column values in tracks table are NULL for Deezer tracks.

Good catch, thanks! Fixed in 2.6.6

Thanks a lot Philippe. For those who also wanted this to be fixed - you’ll need to delete your cache.db for a proper refresh.


chore: update readme & examples

Description

Update README with clearer "getting started" instructions
Update the SQL example to match this gist
Update other examples to explicitly set a remote URL

Related Issue(s)

closes #14

LGTM


Suggestion: A config option that automatically makes all replies anonymous

A config option that makes all replies (using the reply command) anonymous would be useful, currently no such feature exists besides alwaysReplyAnon but that is for all messages sent. This would also include making all snippets anon even if you use the normal snippet prefix.

I have a fork that does this, but a config would have saved me some time, haha
In my fork, both the Mod messages and the User messages are anonymous.

Yeah you'd have to edit the source to do this (which I've done in the past) but every update you'll have to keep in mind to make the change, so this is just a small qol thing.

Sure, though it just makes it super unlikely that I update at all

@DarkView Is that a thing now for real?

@DarkView Is that a thing now for real?

Yes, otherwise we wouldn't have closed the issue.
See the configuration option forceAnon for more information.


fix: Use predefined sensor names

Use predefined sensor names, do not let users put arbitrary sensor names on the database. The update each service:

[ ] users
[ ] stations
[ ] messages
[ ] alerts

Not necessary, will allow users to insert arbitrary sensor data name


Feature request: modifier+drag over part of object = selection

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Is your feature request related to a problem? Please describe.
Would it be possible to allow selection of an object by dragging over a part of the object? E.g. with modifier + drag?
In my experience, both "drag across whole object to select object" and "drag over part of object to select" can be useful. Is there a way of doing that? If not, could it be implemented?

Hi,
partial selection is not possible at the moment, but "drag across whole object to select object" as described here: https://desk.draw.io/support/solutions/articles/16000052890-select-multiple-shapes
Does it help?
Regards,


new type ThreadId added

I think ::thread_id is not in Core:: ?

yes it is https://github.com/rdkcentral/ThunderTools/pull/118#pullrequestreview-2280876772 But outside namespace Core

There is no permission to update the branch in rdkcentral, so new PR created from fork: https://github.com/rdkcentral/ThunderTools/pull/130.
Hence closing this PR.


fix: use minimal image when deploying nfd chart

What problem does this PR solve?:
When deploying with the helm addon strategy i noticed that we did not deploy the minimal image.
I'm going to follow this up with a PR that automates syncing the values in the templates and hack/addons/kustomize/**/helm-values.yaml
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:

Special notes for your reviewer:

Fixing the lint-test-helm check in https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pull/779.


will not show

When A VC push to B VC, then pop back, show within A VC will not appear.
The project use the new SceneDelegate.

.


Wrong if logic in Config

https://github.com/pywren/pywren-ibm-cloud/blob/master/pywren_ibm_cloud/config.py#L102
The if logic of "A and B or C or D" here seems wrong, I assume you want to do "A and (B or C or D)"

@lchu-ibm Thanks. Fixed


[FLINK-31514][table-planner] Move query SqlNode conversion logic to SqlQueryConverter

What is the purpose of the change
Introduce SqlQueryConverter and move the conversion logic of query SqlNode -> PlannerQueryOperation to it.
Note that the conversion is complex for query SqlNodes because it's unclear what the specific query SqlNode classes are. But they should all belong to the SqlKind.QUERY. Therefore, we can introduce a new mapping path for the SqlKind.
Brief change log

Add a default method Optional<EnumSet<SqlKind>> supportedSqlKinds() for SqlNodeConverter, which returns empty by default.
SqlNodeConverters supports registering SqlNodeConverter, which implements this method.
SqlNodeConverters will first lookup SqlNodeConverter by class of SqlNode, and fallback to SqlKind of SqlNode if not found.
Introduce SqlQueryConverter which matches SqlNodes with SqlKind.QUERY and converts it into PlannerQueryOperation.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi @luoyuxia @xuzhiwen1255 , Please have a look if there are other concerns.

Merging ...


Added new Jdbc based IdempotentRepository which addresses the problem of orphan locks

Fixes issue https://issues.apache.org/jira/browse/CAMEL-16427 . Added a new Jbbc based implementation of IdempotentRepository which handles orphan locks which can be left due to jvm crash or rolling restarts

I think we need to come up with a better name of the class

Need to add documentation into the src/main/docs file

The background thread should be created via Camel's ExeuctorService API (via camel context).
And the thread pool should also be stopped in the doShutdown method


spaces

Maybe this is not an issue, but my misunderstanding of spaces in asciimath.
Consider the following AsciiMath formulas
`= 30\ 10`
`\ 30\ 10`

Now, if I run these through AMTparseAMtoTeX I get the following out
'={30}{10}'
'={30}{10}'

Is there something wrong with the spaces (I've also tried adding 2 \) Or is the space ignored by this converter for some reason?

If you are manually feeding these strings into the function, are you escaping your backslashes in your strings? I'm noticing:
AMTparseAMtoTeX("3\ 5")  outputs "{3}{5}", but
AMTparseAMtoTeX("3\ 5")  outputs "{3}\ {5}"

@drlippman I've taken the liberty to edit your post and escape the code so that the double backslash isn't lost

Ok, this one is my mistake, double slashes indeed work :) sorry


v0.7.0 crashes on Windows 7 SP1

curl-impersonate v0.7.0 crashes when making a request (e.g. if the executable is given URL input) on Windows 7 SP1.
It abruptly aborts with an error message of "This application has requested the Runtime to terminate it in an unusual way."
If the executable is run with the --help flag it does not error.
Here is a side-by-side comparison of upstream curl v8.8.0 vs curl-impersonate v0.7.0:

I can reproduce the issue with both the curl-impersonate 0.7.0 windows .exe and libcurl-impersonate 0.7.0/curl_cffi 0.7.0. See the linked issue below for an example of the crash with curl_cffi:

https://github.com/yt-dlp/yt-dlp/issues/10426#issuecomment-2223364702

I cannot reproduce this issue with curl_cffi 0.5.10 or the upstream libcurl-impersonate. Both work fine with Windows 7.

System info: fully patched Windows 7 Professional Service Pack 1 Build 7601

Note: v0.7.0 works fine if VxKex is activated.

In 0.7, zstd was added, since Chrome added it in version 123. Otherwise, I can not think of other changes that will introduce at the moment.
I'll setup a Windows 7 VM and try it later.

@perklet
Hi,
Don't want to rush you but...
The latest yt-dlp version<EMAIL_ADDRESS>has just added the following warning.
Deprecated Feature: Support for Windows 7/Server 2008 R2 has been deprecated. See  https://github.com/yt-dlp/yt-dlp/issues/10086  for details.
You may stop receiving updates on this version at any time!

I am currently using VxKex on yt-dlp to suppress the warning, but soon when yt-dlp upgrades curl_cffi this issue would become moot for non-Win7 users .
Please look into this issue soon as the unofficial yt-dlp python 3.12 builds for Win7 would likely not compile with newer versions of curl_cffi .
And I really need curl_cffi to work with yt-dlp on Win7.
Thanks!

Would be nice if curl.exe was compiled statically by the way

Would be nice if curl.exe was compiled statically again by the way, it used to be but stopped at some point and it's a pain to use in certain ways since you need all dynamic lib dll's. Now:

That's what I hoped for, too. Unfortunately, my knowledge for the Windows toolchain is very limited.

It did work with the extensions provided by vxkex.
Then I tried to put the vxkex dlls inside the curl-impersonate folder as a quick and dirty verification, but it did not work. 😂
A lot of the toolchains have ended their support for Windows 7, so this is harder than I thought. I will try to set up a msys2 environment on my Windows 7 VM and compile inside it. But even if it works, I'm not sure how can I set up the same pipeline on GitHub actions, which only provides Windows 2019 and 2022.
Please let me know if you have more information on how to build or compile on Windows 7.


Enhancement: Move current tab to another window via keyboard shortcut

I know it's possible to drag tabs from one window to another from the Tabli menu, but it would be nice to be able to do this with the keyboard. Perhaps a shortcut to start the action, then type with fuzzy search to select the window to move it to.

One idea: keep the shortcut action the same. The current tab is selected by default when tabli opens and search works as normal. When the TAB key is pressed, tabli goes into a "move tab state" with the currently selected tab. In this state the search restarts but only showing windows. When a window is selected, via search or arrow keys, and ENTER is pressed, the tab is moved there.


C++17 support for Hazelcast client

PR closed by Hazelcast automation as no activity (>6 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thanks for your contribution. I have reviewed the PR, it compiles successfully for boost::optional, probably runs as well. One required change is that the variable you added to CMakelists.txt should be an option and needs to be printed with other options. Also std::nullopt and boost::none should be handled as well.
But the question trickles my mind is that is this option really desired by user perspective?

Maybe a user could have already used std::optional so probably is not willing to mix boost::optional and std::optional and stick to one of it.
Probably optional header brings less overhead that boost/optional.h

But I don't know what is your opinion about these ?

Thanks for reviewing @OzanCansel. The main idea behind on these changes, removing Boost dependency step by step without breaking any functionality of Hazelcast library itself.
Currently, Hazelcast has huge dependency to the Boost library which cause a lot of problems when have to link Boost library statically.
First problem, if I want to update Boost library, I have to update my application as well which cause deployment and maintenance cost for me on each Boost release. Secondly, due to static linking, executable size is getting bigger and bigger which is not quite good if I want to run the executable on small IoT devices.
So, actually directly std::optional could be replaced with boost::optional as a first step to get rid of this dependency which brings C++17 on the table. Maybe, some users do not want to build Hazelcast library with the latest versions of C++ compilers which does not support C++17 clearly. IMHO, it could be kept as an option in CMakeLists.txt file.
Of course, if you have a plan to make standard C++ version of the library C++17 in the future release, we do not need to keep boost::optional. std::optional could be used as a substitute.

I also complain about boost dependency because it brings ~350k lines of code for every translation unit that uses hazelcast_client so it makes compile time longer. Also we force our user-base to use boost library. But to be honest it is the framework which the cpp-client is built on top of it and i don't think that we are able to get rid of it.

@cngzhnp I totally understand your point. We had zero dependency in very earlier releases but this is also a problem when we like to provide nice features such as continuations for futures, utilize lang. features non-existent in C++11 but in higher standard levels.
If we can get rid of all the dependencies using C++17 or C++20, it would be nice to have this optional configuration in cmake but can we really get rid of all dependent features?

verify

Linux test PASSed.

@cngzhnp This change might break some code of our clients also introduces some maintenance cost. So we will reconsider this in 6.0.0. So it can be closed.

Linux test FAILed.


AVTP Sequence number mismatch

Test Setup
Send ts video file stream from talker to Listener.
Talker- AVB enabled device via an AVB aware Ethernet switch, using ptp4l and switch acting as PTP grandmaster
Listener - Linux PC
force linux PC to act as a slave  -> daemon_cl eth -V -E -INITSYNC 0 -F gptp_cfg.ini
gst is enabled -> AVB_FEATURE_GSTREAMER ?= 1
gst command from Talker

gst-launch-1.0 filesrc location=/input_1280x720.ts ! video/mpegts, systemstream=true ! v4l2sink sync=true device=device show-preroll-frame=false

Open AVB command

./openavb_harness -I enp2s0 mpeg2ts_gst_listener.ini

I am able to capture the ts file contents at Linux PC.
We are currently facing packet loss and also noticed the following info upon execution.

[1626196957:919975666 OPENAVB Raw Socket] INFO: Using atl implementation
[1626196961:248332140 OPENAVB AVTP] INFO: AVTP sequence mismatch: expected:   1,	got:   0,	lost 255
[1626196961:248817954 OPENAVB AVTP] INFO: AVTP sequence mismatch: expected:   2,	got:   1,	lost 255

Is there any start offset to be defined for configuring the AVTP sequence start?
Based on the above message it appears that there is always a difference of 1 sequence number, between expected and got value.
Any hint to resolve this issue would be of great help.
Thanks & Regards,
Shanmathi P

Hi @ShanmathiP,
The issue you are mentioning appears to be about openavb_harness, which is part of https://github.com/Avnu/OpenAvnu repository. I guess you should open an issue there =D
This is the libavtp repo, a library for (de)encapsulating data into AVTP packets.

@edersondisouza,
Thank you for letting me know. Will close this here and open in openAvnu.


Feature flags for calico with CRDs and eventually typha

Calico feature flags for CRDs (etcdless) deployment and if that is enabled there should be the option for typha. Default should remain the etcd deployment. The option is cluster wide in the tarmak.yaml

/assign


Add a 'select all' button

Enhancement request
It would be nice to have a 'Select All' button (or icon) within the select text area, similar to, and as a complement to, the 'Remove All' '×' icon. Clicking on this would cause all items in the (currently loaded) selection list to be selected. The 'All' text (or icon) would be located next to the 'Remove' icon within the drop-down selection list area.
(I have coded my own 'Select All' button, but I had to add it outside the Select2 drop-down area, since I do not want to have to maintain my own local modified version of Select2.js. This is a less than ideal solution.)
This feature could be controlled by (yet another) configuration option:
   var opts = { ..., selectAllText: "All", ... };

Or this could even be a app-provided config function that returns an HTML element (similar to the templateResult() config function), to which an 'onclick' event handler would be attached.
This could be made to be an optional feature, such that if the selectAllText option was null or undefined, the 'All' button/text would not be shown at all.
Upon receiving a click event, the handler selects all of the child options of the Select2 element, then triggers a change event:
// Select all the options
var options = selectElem.options;    // selectElem is the <select> element
for (var i = 0;  i < options.length;  i++)
	options[i].selected = true;

// Inform Select2
select2Elem.trigger("change");       // select2Elem is the Select2 element

This code probably needs to trigger a change event for each option as it is selected, similar to the way the `Remove' button works today.
Environment

Select2 version: 4.0.2

This is a duplicate of https://github.com/select2/select2/issues/195#issuecomment-140241752.


Test the web app before deploying?

Is there a recommended way to test the web app defined in the script webhooks.py locally? Sorry if this is obvious, but I'm new to webhooks and web apps in general.

Hi,
To test your hook
You may use the GitHub REST API:
https://developer.github.com/v3/
curl --user "<youruser>" https://api.github.com/repos/<youruser>/<myrepo>/hooks

Take note of the test_url.
curl --user "<youruser>" -i -X POST <test_url>

You should be able to see any log error in your webapp.
I'll keep this issue open to remember me to add this information to the README.
Regards


can u provide the training log file?

since i want add ur code into my own and do the trainings, so i want to reproduce ur results. can u provide the training log files?

in my trainings (from the starting), the loss_maskiou is small, like 0.0107 (0.0252), compared with loss_classifier. is it normal?

in my trainings (from the starting), the loss_maskiou is small, like 0.0107 (0.0252), compared with loss_classifier. is it normal?
btw, i use r50-fpn config file.

I have updated my training log in README.md.


Problem when test example

Hi,everyone,when i follow the step in readme, I met a lot of problem.
I enter the name but it print the same thing.
It seems that I lack something. But I don't what is it. T^T

I met the same issue. I don't know what should be entered.


Use strict utm parser

We should only populate the 5 spec'd context.campaign fields when we parse the querystring. This PR adopts our utm parser's new strict mode to ensure that.
Our existing implementation will return an unbounded object with any key prefixed utm_, causing, for example, unbounded column addition in redshift. This fix is especially important because customers are not in control of their own UTM params —any referrer can populate them erroneously and we see that happen often.
@ndhoule @reinpk
cc/ @ivolo @wcjohnson11... you both were interested in seeing this fix through on slack :)

looks good to me, but no idea what people might be depending on other params downstream?

hmm yeah it totally make sense to me. But I wonder if our tools right now support utm params that are custom? and if people have ad attribution funnels set up to be depending on those custom utm params, then this would break for them. if all ad tools abide by the same context.campaign as the 5 we will listen for then I think we should be good. @reinpk @sperand-io

@sperand-io this still relevant/can we ship after conflict resolve?

Closing for staleness.


Bump framework and ldapuserstore versions

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/700692396

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/700692396
Status: success


Cache-Detail loading always showing "Save for Offline"

With the NB0902 83b215a there is a change in the progress window:
If you load cache-details (from live map or from search result) the progress window is always showing "Store for Offline" as last prompt before the details are opened.
I guess it is because it is stored in the cache-cache.
But as the cache is not really stored for offline-use I suggest to avoid showing this prompt.

It's just the wording or the fact that the caches gets saved what's not ok ?
Detailed caches are now stored in the DB (list = 0). They get deleted after three days.

The wording.

What's your recommendation ?

Its only the wording, maybe:
English: "Caching cache data"
German: "Cache zwischenspeichern" or "Cache wird zwischengespeichert"
The shorter the better to avoid having another linebreak which makes the popup "jump" in position (at least on my phone at the moment)

Ok, finally I searched a few caches again (well, only an event, but we testet a lot there). The additional storing-dialog is really confusing and should be removed. The user doesn't know that every cache is stored in an unnamed list "0".

I am not familiar enough with coding to look i up:
If "loading for viewing" can be seperated from "saving for offline" this could be different prompts as already mentioned.
If not, I also vote for removing this and instead just extend the display of "Erzeuge Darstellung".

It's another dialog as a result of the new caching / database access.

Increasing prio as this is really annoying/misleading

I think this misleading info should be gone in the next market release if possible...I set the milestone accordingly.

Would be nice if someone else could solve this ,-)

This turned out to be much easier fix than I had suspected.


New autoReveal setting for explorer

[ ] any OS
[ ] any OS

There is now a new setting to prevent the explorer (not working files) from revealing the currently active file of the editor.

verify changing this option prevents the explorer from automatically revealing the active file when you switch between files (e.g. from working files)
verify you have a global action to reveal the active file and it does just that

This is listed in the release notes for v.1.0.1-insider but it isn't working for me, on that version.

@stephenmartindale did you try explorer.autoReveal: false in settings?

This is what I have:
 "explorer.autoReveal": false,

Wait - I've worked out what is going on: The explorer is simply redrawing the selection rectangle which makes it look like it is revealing the file - it isn't actually scrolling.
To be perfectly honest, the fact that it is not scrolling is enough. Perhaps the documentation should simply be clearer - this setting disabled scrolling, not revealing of the file.


There are no commands defined in the "self" namespace.

Is there an existing issue for this?

[X] I have searched the existing issues

From Discord https://discord.com/channels/664580571770388500/1068592266752573440/1246171053257003032
Expected Behavior
After switching to go-based platform.sh CLI binary in

https://github.com/ddev/ddev/pull/5995

https://github.com/ddev/ddev-platformsh/blob/c82eabc5ae960ebe11c965bdface8f75978ff0f0/install.yaml#L295-L297
The hook should be updated with:
(sudo apt-get update &>/dev/null || true) && (sudo apt-get install -y platformsh-cli &>/dev/null || true)

And a new restriction for DDEV v1.23.0+ should be added.
Or maybe that update line should be simply removed.
Actual Behavior
platform self:update -qy --no-major || true

  [CommandNotFoundException]
  There are no commands defined in the "self" namespace.

Steps To Reproduce
Use the latest DDEV with this add-on, run ddev start.

IMO we just shouldn't be doing an upgrade.
If one were to be done, it should be in a .ddev/web-build/Dockerfile, rather than in post-start hook.


ISPN-8756 Single port protocol autodetection

https://issues.jboss.org/browse/ISPN-8756
Recycles https://github.com/infinispan/infinispan/pull/6133 and simplifies it by adding a simple Hot Rod header magic detector which automatically switches protocol without requiring an explicit HTTP Upgrade header.

I don't want to document this in detail for the legacy server: I want to make this the default configuration for ServerNG.

I don't want to document this in detail for the legacy server: I want to make this the default configuration for ServerNG.

Okay, thanks for clarification.

Integrated into master, thanks @tristantarrant !

Great work @tristantarrant !
And thank you for putting effort in amending my commits!!!


MarkdownString.supportHtml isn't in the release

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.61
OS Version: Windows 10

Steps to Reproduce:
Try accessing the supportHtml property of MarkdownString. It is in the release notes, but isn't supported yet. Attaching sample code below with screenshot.

This was a proposed api in 1.61. It will be finalized fo 1.62
See https://code.visualstudio.com/updates/v1_61#_proposed-extension-apis for how to test proposed apis

My bad. Thanks for the clarification. Appreciate it


Rest API Data in Grafana - Unable to find the data when integrated Grafana infinity Datasource with Postgres DB

Hi Team,
This is in regards to API data storing to Postgres DB when retrieving it from the cloud.
SCENARIO:
I am using Infinity Datasource to fetch JSON data from Huawei cloud using Rest API's. It worked successfully but what is happening i need to store the data to external DB "Postgres" instead of local storage. I am able to integrate it with postgres DB but it is storing only structure of the API query , i can't find the actual data stored over there , it is giving me a tough time to fix the issue.
Could you please help here how to fix the issue.
Thanks,
Shahid
DevOps Engineer

Unfortunately, we don't have the bandwidth to provide deployment/integration support here; I would suggest trying a dedicated support forum, such as the Docker Community Slack, Server Fault, Unix & Linux, or Stack Overflow.


Added donate.html & other little tweaks

Feel free to review and modify to your liking as you merge this, it won't offend me...

@rinzler100 It is very much to much liking...please go ahead and merge as you see fit.

rip github notifications


Separate Documentation Publishing Workflow for Increased Efficiency

Hello Natalia, Adam, and Artur,
We've noticed that our current GitHub Actions workflow, as defined in on_push_workflow.yml, combines multiple tasks such as publishing to Maven, managing snapshots, and building documentation, all triggered by a single push event. This setup is causing inefficiencies, particularly around documentation updates.
Currently, any minor change to the documentation requires triggering the entire pipeline, which is not only resource-intensive but also slows down the process of updating and iterating on the documentation. This is particularly cumbersome for both our team and external teams who need to work swiftly on documentation.
Suggested Change:
I propose we create a separate workflow specifically for documentation updates. This workflow would be independent of the current pipeline but could still be triggered by push events to relevant branches or directories (e.g., any changes within the docs/ directory).
Benefits:

Faster Iteration on Documentation: Changes can be published quickly without waiting for unrelated CI tasks to complete.
Reduced Resource Consumption: By isolating documentation tasks, we use fewer CI resources.
Better Organization: Separating concerns by having distinct workflows for different tasks improves maintainability and scalability of our CI/CD setup.

Extracted Workflow Section for Reference:
  build-documentation:
    needs: auth-plugins-local
    name: Build documentation
    runs-on: ubuntu-latest
    # (Include all related steps and configurations here)

Please consider this suggestion as it could significantly enhance our development workflow efficiency, especially for documentation.
Thank you!
CC - @prestonlau

Thanks Diego, good call, we will bring it up with the team and improve on in the next iteration @Nataliagros. Totally agree that we should have the ability to update documentation independently. However there's always the concern of docs/app being out of sync with separate workflows?

Thank you for considering my suggestion, Kuba. Regarding your concern about the documentation and application potentially being out of sync when using separate workflows, one effective solution could be to utilize the workflow_run event in GitHub Actions. This approach would allow you to automatically trigger the documentation generation and publishing process once the primary application deployment workflow has successfully completed. Here's an example configuration:
name: Publish Docs
on:
  workflow_run:
    workflows: ["on_push_workflow"]
    types:
      - completed
...

This setup ensures that updates to the documentation are only made after the application updates are deployed, keeping them in sync. If you're looking for more control or have specific integration needs, we can also explore more complex options like repository dispatch, which I'm open to discussing further.

Hi, I've prepared new PR with this issue resolved:
https://github.com/openmobilehub/android-omh-maps/pull/76


add unit tests

add unit tests (jest)
add e2e tests (playwright)

things to test:

hooks
components
mock network and verify different charts that we have

Hey:)
I don't have much experience with testing, little with jest, some with cypress.
That is why I would love to take this issue. Are there videos Noam posted somewhere on how to do unit tests and e2e?

Noad did very good guide about e2e palywright tests here
https://www.youtube.com/watch?v=jEWG7nYKk_0
for creating unit tests for components, i think you better look at react
testing library docs
https://testing-library.com/docs/react-testing-library/intro
On Wed, Oct 11, 2023 at 9:50 PM Amabelle Trachtenberg <
@.***> wrote:

Hey:)
I don't have much experience with testing, little with jest, some with
cypress.
That is why I would love to take this issue. Are there videos Noam posted
somewhere on how to do unit tests and e2e?
—
Reply to this email directly, view it on GitHub
https://github.com/hasadna/open-bus-map-search/issues/107#issuecomment-1758307578,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKGMHUUMEEW3Y3KZ7R5EADX63S6DANCNFSM6AAAAAA52NLXSY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
http://gs500coder.blogspot.com

Noad did very good guide about e2e palywright tests here https://www.youtube.com/watch?v=jEWG7nYKk_0 for creating unit tests for components, i think you better look at react testing library docs https://testing-library.com/docs/react-testing-library/intro
…
On Wed, Oct 11, 2023 at 9:50 PM Amabelle Trachtenberg < @.> wrote: Hey:) I don't have much experience with testing, little with jest, some with cypress. That is why I would love to take this issue. Are there videos Noam posted somewhere on how to do unit tests and e2e? — Reply to this email directly, view it on GitHub <#107 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHUUMEEW3Y3KZ7R5EADX63S6DANCNFSM6AAAAAA52NLXSY . You are receiving this because you authored the thread.Message ID: @.>
-- http://gs500coder.blogspot.com

Thx for the links:) I'll look into them. You can assign it to me if you like.

@amabelleS what kind of tests will you do? e2e/unit/component?
I'll create a separate issue

@shootermv @NoamGaash I would like to get started working on adding Unit Tests (with Jest) too. I don't have much experience with writing Unit tests. So I guess this project could be a great starting point.

@amabelleS what kind of tests will you do? e2e/unit/component? I'll create a separate issue

all kinds:) we'll start with e2e - #118 :)

sounds perfect! thank you both
let me know how I can help

@NoamGaash By the way, I am looking for a code coverage tool that can generate code reports. It will help us measure code coverage for our project.
After a bit of debugging, I got to know that we can't use Playwright to create code coverage reports yet. Here is another tool that is helpful to some extent - https://github.com/anishkny/playwright-test-coverage
But I couldn't get it working for our project and hence raised this issue - https://github.com/anishkny/playwright-test-coverage/issues/148
If we used Vitest, it would have been simpler to generate code coverage reports but with Playwright, I guess we just have to wait a bit (sigh!).

In my opinion, code coverage is a bad metric - the fact every line in the code executed at least once during your test suite has nothing to do with finding bugs and regressions. Maybe it's good for upper management in some companies, where a rough estimation of "code quality" is required from the RND department, but having 100% code coverage is not something we should be looking forward.
I do consider adding visual tests. as Applitools employee, I think we have an open source plan. I'll check that out.
Anyway, the main focus (in my opinion) should be on preventing regression, and reducing the fear factor.
When I review a pull request, I usually won't run it locally at all. I expect the test suit to test the buisiness logic of the application.
For example, I don't think anyone would break the ordering of menu items. If someone will try to change that, it will be very easy to tell that from the code, and reject their contribution.
However, if someone will break one of the maps, and it won't longer contain any bus icons, it would be infeasible to know without cloning their branch, executing the code and manually go over each page of the application.
Therefore, testing the existence of bus icon in every page would provide us more value.
That's my opinion. What do you think?

I strongly appreciate your detailed response. Thanks a bunch!
I agree with your point about the ordering of the menu items.
I would like to work on a better test scenario.
Could you please assign (or create) an issue which I can write tests for?
Happy to work on Unit Tests, Integration tests, or e2e Tests.
Note - Regarding Code Coverage, I have noticed many engineers mentioning "100% code coverage" in their resumes. As someone who is desperately looking for a job, I thought increasing code coverage in this project and then adding it to my resume could prove helpful in getting a job. But if there is something that can add even more value to the project, I will be happy to work on it.


Arducam mini 5mp plus schematic

Hi,
I would like to know if there is a way to get the schematic of the mini 5mp plus board.
thank you.

Hi，
I‘m sorry to tell you that the mini 5mp plus schematic is not open source.


can't reproduce sample in readme

We get the following error when we try to reproduce readme example, we are using scala 2.11 jar downloaded from maven. We are running from AWS EMR cluster, with the following version
Spark 2.1.1 (git revision 173acdf) built for Hadoop 2.7.3-amzn-2
val clusters: Dataset[Assignment] =
MCL.train(graph).assignments
:37: error: type mismatch;
found   : org.apache.spark.rdd.RDD[org.apache.spark.mllib.clustering.Assignment]
required: org.apache.spark.sql.Dataset[org.apache.spark.mllib.clustering.Assignment]
Error occurred in an application involving default arguments.
MCL.train(graph).assignments

Hi,
On maven there is no jar for Spark upper than 1.6.1. Indeed until this issue is not solved, I don't want to publish a new version on spark package. I have just updated the code so you can use it under 2.1.1 if you compile it locally. Let me know if it is ok for you.


Support unparsing UNNEST plan to UNNEST table factor SQL

Which issue does this PR close?

Closes #13601
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

🚀


Add an options table to toggle which emotes are used.

In commit history for reference

began work on adding options table - added skeleton framework back into code.
next steps to add slashcommands to open options panel, create options panel to include customizable list of emotes that are acceptable to use when emoting - likely will need to add a function to create each individual emote's checkbox AND individual's bool value

get/set methods are not called when attempting to toggle the options table values


i've only changed line 260-263

because you defined center points of your object in two different ways, on reapplying roation everything broke
also i can't explain why git thinks white lines are significant lines of code but whatever

Nice catch! I was wayyy too tired to see that so nice that you did :) I'll merge and Starr testing


fixing issues in books page and index.htm

Related Issue
None
Fixes:  #4341
Description
Fixed bugs in index.html file with script tag not being closed and repetitive components present in file.
fixed issues in books page as well with dark mode toggle not present in navbar and unnecessary spacing before footer.
Type of PR

[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

Checklist:

[X] I have made this change from my own.
[X] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

why u have deleted the javascript code of rate us section ?

why u have deleted the javascript code of rate us section ? explain properly .

why u have deleted the javascript code of rate us section ? explain properly .

Cause the code is repeated. The same code is present below it

@abhi03ruchi @sailaja-adapa pls review this pr


Make a logger for SCP and logging functions

The logger for SCP module is created in agora.utils.Log module.
The logging function in SCP module makes a formatted message and call a logging function in D.
Unittest code is added.
Related to #346

Ready for review.
Any suggestions would be good, especially about the name of the class or the function.

Overall looks good, just a few tiny issues I've mentioned.

I restarted the build on Travis.

Nice work.


Add notebox.fcjz.xyz

I put the icon at the bottom of the site.
You can see it no matter what.

Hi :)
I can't seem to load the website, it just loads and loads and eventually it fails, I managed to load up to 1.5mb, and nothing was showing up still. Also, at the moment, the webring needs you to have your own domain name.


POST_DEMO Add Go static analysis to pre-commit, but leave it disabled in Circle CI

Description
This PR will implement gas as a pre-commit hook. There are a good number of "findings" right now, so I've disabled running the full scan in Circle CI until we've fix the real problems or annotate the false positives.
Reviewer Notes
I shoved the gas binary in bin/. I'm not clear if that's the best place for it.
Code Review Verification Steps

[ ] All tests pass.
[ ] Request review from a member of a different team.

References

Pivotal story for this change

Added @ntwyman for review.


Add support for a python virtualenv to the build script

--python-venv should set up and use a Python virtual environment.
requirements.txt will need adding.

How is that going to interact with Docker?

Docker will set up and use a virtualenv


fix/replace links

In PR #2780, @rpetrusha noticed we had quite a few API links still going to MSDN. I found a couple more not related to the feedback he was giving, so fixing some obvious ones on this PR + a few other broken/msdn links.
Related to #2580.

An unspecified error occurred during the build; closing and reopening to restart build.

@mairaw, the build has failed twice, so I suspect that one of the changes has caused the build break. I've looked through your changes, though, and I can't identify anything that might cause a build break.


Suppressing unnecessary exception stack trace on snappy> prompt console

Changes proposed in this pull request
Only stack trace is being suppressed for display.
Patch testing
Manual.
ReleaseNotes changes
No.
Other PRs
None.

Can this be controlled using utilMain#ijExceptionTrace param? That is print the stack only when ijExceptionTrace is set to true.

As discussed, the idea of this was that non "SqlException" cases should dump the stack so that user can better know what is going on (e.g. runtime NPE or something). However, the "SqlException" class is used only by DRDA and not by thrift which is the reason it does not work for thrift driver.

Made changes as per comment from @sumwale

@dshirish I did not go through the route you mentioned for two reasons:

That system flag usage is not proper. It checks for non nullness for true, so setting it to true or false won't mean anything unless we change that too. But this is a minor reason.
The more important reason is that this problem started coming after Thrift became the driver. It still does not show with the DRDA driver. So handled this also as per how it is being handled for thrift.

Ok, good to know the real reason behinds exception being shown on shell. Agree with you. LGTM


Add non M1 Mac support

Currently non M1 Macs are not supported. Running Litr on those devices gives you:
bad CPU type in executable: litr

Could be possible in CMake via CMAKE_OSX_ARCHITECTURES=arm64;x86_64

Probably resolved via c1f9174ed2bda6e381a1de6d058091efaf9be57d, still needs clearification.

Confirmed ✅


Add completions for configurable qualifier

Purpose
This PR adds completions for configurable qualifier.
Fixes #35953
Samples
https://user-images.githubusercontent.com/61020198/168987979-34647021-1b9e-4168-9831-e51757444ade.mov
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Shall we add another test case and explore,
configurable <cursor>

It routes to ModulePartNodeContext and gets getModulePartContextItems(context) completions which also includes completions like snippet for public main function() {} which I believe are wrong. WDYT?

Those completions are given when there's a following type of scenario.
configurable <cursor>

public function main() {

}

Either way this should be fixed. Will look into it

Shall we add another test case and explore,
configurable <cursor>

It routes to ModulePartNodeContext and gets getModulePartContextItems(context) completions which also includes completions like snippet for public main function() {} which I believe are wrong. WDYT?

Can be resolved once #36215 is fixed

Shall we add another test case and explore,
configurable <cursor>

It routes to ModulePartNodeContext and gets getModulePartContextItems(context) completions which also includes completions like snippet for public main function() {} which I believe are wrong. WDYT?

Those completions are given when there's a following type of scenario.
configurable <cursor>

public function main() {

}

Either way this should be fixed. Will look into it

Your example is a different scenario. Parser identifies my initial example correctly as, and
configurable
 MISSING[] MISSING[] MISSING[=] MISSING[?] MISSING[;]

will have to handle this.

Shall we add another test case and explore,
configurable <cursor>

It routes to ModulePartNodeContext and gets getModulePartContextItems(context) completions which also includes completions like snippet for public main function() {} which I believe are wrong. WDYT?

Those completions are given when there's a following type of scenario.
configurable <cursor>

public function main() {

}

Either way this should be fixed. Will look into it

The above case will be fixed with #36323


Temporarily fix OSError/IOError maybe.

I have found that there could be multiple instances of the lsof command running simultaneously within the job-exporter container for unknown reasons. During these occurrences, the nfs-kernel-server or even the server itself may become unresponsive, leading to IOError/OSError for user tasks. Given this situation, our strategy is to remove the network data collector. Once we resolve this issue, we can then concentrate on finding an alternative approach for network collection.
Temporarily fix https://github.com/microsoft/pai/issues/5730 maybe.
Signed-off-by: siaimes<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 33.515%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1441

Relevant Lines:
3477

💛  - Coveralls


[Broken] Facebook Watch videos

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dlc version 2020.10.31
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.facebook.com/141043411701/videos/295690631678897']
[debug] Loading archive file None
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dlc version 2020.11.07
[debug] Python version 3.8.2 (CPython) - FreeBSD-12.0-RELEASE-p3-amd64-64bit-ELF
[debug] exe versions: none
[debug] Proxy map: {}
[facebook]<PHONE_NUMBER>78897: Downloading webpage
[facebook]<PHONE_NUMBER>78897: Downloading webpage
[facebook]<PHONE_NUMBER>78897: Downloading webpage
ERROR: Cannot parse data; please report this issue on https://github.com/blackjack4494/yt-dlc . Make sure you are using the latest version; see  https://github.com/blackjack4494/yt-dlc  on how to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/python3.8/site-packages/youtube_dlc/YoutubeDL.py", line 830, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/python3.8/site-packages/youtube_dlc/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/python3.8/site-packages/youtube_dlc/extractor/facebook.py", line 482, in _real_extract
    _, info_dict = self._extract_from_url(
  File "/usr/local/bin/python3.8/site-packages/youtube_dlc/extractor/facebook.py", line 380, in _extract_from_url
    raise ExtractorError('Cannot parse data')
youtube_dlc.utils.ExtractorError: Cannot parse data; please report this issue on https://github.com/blackjack4494/yt-dlc . Make sure you are using the latest version; see  https://github.com/blackjack4494/yt-dlc  on how to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.

Description
youtube-dlc doesn't download Facebook Watch videos (movies, TV shows, music videos). It still works on most other Facebook videos. The video in the example is playable without logging in.

try like this >  youtube-dlc --force-generic-extractor https://www.facebook.com/141043411701/videos/295690631678897

try like this > youtube-dlc --force-generic-extractor https://www.facebook.com/141043411701/videos/295690631678897

Thanks. Any tips for a video like https://www.facebook.com/lionsgate/videos/974855332998732 ?  That video has a "custom" audience rather than a public one, requiring login.  I tried passing cookies but got back
[redirect] Following redirect to https://www.facebook.com/watch/?v=974855332998732
...
ERROR: Unsupported URL: https://www.facebook.com/watch/?v=974855332998732

this link - https://www.facebook.com/lionsgate/videos/974855332998732
says it's expired. download may not be possible as it may be protected with DRM.

says it's expired. download may not be possible as it may be protected with DRM.

It's definitely not expired. I see webm and audio mp4 fragments but haven't found a manifest file.

says it's expired. download may not be possible as it may be protected with DRM.

It's definitely not expired. I see webm and audio mp4 fragments but haven't found a manifest file.

you might try the firefox addon called the stream detector or videodownload helper addon
did get a hit with the stream detector addon but no link showed.


[api] Unexpected error: Expected 1 but found 2 stored identities. When calling Web5.connect()

When using Web5.connect() without any options, there have been occurrences where the following error is thrown:
Uncaught (in promise) Error: connect() failed due to unexpected state: Expected 1 but found 2 stored identities.
When connect() is called and no identities are returned from the agent, a new identity is created.
There is some unknown scenario where userAgent.identities.list() is returning zero results, although there was one that existed in the past.
On a subsequent call of connect() it will then suddenly have 2 identities.
https://github.com/TBD54566975/web5-js/blob/main/packages/api/src/web5.ts#L205-L248
For the time being we will do a few things to remedy the stuck situation, as well as investigate further as to why this happens.

Check the status returned by processRequest within the DwnDidStore.getAllRecords() and throw an error along with the error detail if it does not return a 200 status. https://github.com/TBD54566975/web5-js/blob/main/packages/agent/src/store-did.ts#L48-L57
If the user passes a connectedDid and the list returns more than one identity, attempt to find the identity which matches the connectedDid, if it exists use that identity, otherwise fail.

Hopefully connectedDid is the DID identifier, not some more complex thing?

Hopefully connectedDid is the DID identifier, not some more complex thing?

Yup! It is set to the identity.did.uri further down the file if there is no agent passed.

This was partially done during the connect flow.
Currently if multiple identities exist, the first in the index is returned. Closing in favor of better-defined behavior for multi-DID management.


Ask for user account

The script will ask the user for a normal user account with sudo privilege. Enter empty to not add one.
Also, I fixed a sed bug where it made the installation unbootable.

Thanks.


Virtualenv not showing

Hi,
First thank you you for this theme, I really love it!!
However I have a problem with the virtualenv plugin that doesn't seem to work at all for me.
I have added the plugin in my .zshrc before loading geometry:
export GEOMETRY_PROMPT_PLUGINS=(exec_time git jobs virtualenv)
ZSH_THEME="geometry/geometry"

Nothing is showing in my terminal when a virtualenv is activated:
echo $VIRTUAL_ENV
>>> /Users/thms/.virtualenvs/venv_test

Doing export GEOMETRY_PROMPT_PLUGINS=(exec_time git jobs +virtualenv) displays empty parenthesis where the venv should be showing that the plugin is loaded.
I can't find any setting that could pose a problem..
Thanks for your help!

Maybe not related, but exec_time is also broken. Probably related to #160 as I'm pretty sure the problem is in zsh-async.

Related to https://github.com/fribmendes/geometry/pull/160

@kevin940726 @Threynaud It should be solved in master.

Working great indeed, thanks a lot!

Awesome! Thanks for reporting.
Closing.


Nobid version 1.2.3

Added support for COPPA
Added support for schain, supply chain object.

code was released with 3.10. I fixed the conflict and will merge.


Install location Option for Internet Plugins

I installed cask vlc-webplugin. It was installed into ~/User/Library not /Library. Do we need to add a brew cask option to install Internet plugins into /Library instead of current user? Similar to the options already existing for: Prefpane, Quicklook Plugins, Dictionaries, Fonts, Input Methods, Screen Savers.

There is one: --internet_plugindir. It’s on the man page.

Thanks, missed it. However an issue presents itself, while  running brew cask install as admin it fails to install the prePane because of Permissions.
Moving Preference Pane 'AppTrap.prefPane' to '/Library/PreferencePanes/AppTrap.prefPane'.
Error: Permission denied - (/usr/local/Caskroom/apptrap/1.2.3/AppTrap.prefPane, /Library/PreferencePanes/AppTrap.prefPane)

If we can not use sudo how do we gain permission to install into /Library?
I am admin, but apparently don't have write access to that folder without using sudo.


add alpine-keys to sdk+apko images

These are needed in order to be able to pull alpine packages, like we do when bootstrapping wolfi.

yo dawg https://github.com/chainguard-images/images/pull/196


Any plans to support Emojis?

Rendering a screenshot of a page containing Emojis doesn't seem to work:
const chromeless = new Chromeless({ remote: true })

const screenshot = await chromeless
  .goto('http://getemoji.com/')
  .scrollTo(0, 2000)
  .screenshot()

console.log(screenshot)

await chromeless.end()

Renders:

Any plans to support these or is this a limitation with Headless Chrome?

Unfortunately you have to install a slew of fonts to get things rendering just right. I'm working on a service that takes care of all this for you (https://browserless.io). Otherwise you'll have to get these installed somehow on your provider, which I don't works just yet in AWS lambdas...

@joelgriffith do you know what packages are needed to support this on Ubuntu in Docker?

The packages needed are listed here
However that doesn't fix/effect emoji's, of which there's this package which does well.


Message Sync No data

Hi, team
Thanks for your great work.
I am trying to sync hubble in k8s, after more than ten hours, looking at the log it seems to have completed the sync, but in the monitoring view, Message Sync is always No Data.
Logs:
{"message":"{\"level\":30,\"time\":1721878200024,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"GossipNode\",\"bootstrapAddrs\":[\"/dns/nemes.farcaster.xyz/tcp/2282\",\"/dns/hoyt.farcaster.xyz/tcp/2282\",\"/dns/lamia.farcaster.xyz/tcp/2282\",\"/dns/bootstrap.neynar.com/tcp/2282\"],\"msg\":\"Bootstrapping Gossip Node\"}\n","timestamp":"2024-07-25T03:30:00.024Z","type":"out","process_id":0,"app_name":"hubble"}
{"level":50,"time":1721878200024,"pid":30,"hostname":"farcasterhubble-569864c58-fn4dr","component":"GossipNodeWorker","err":{"type":"AggregateError","message":"All promises were rejected","stack":"AggregateError: All promises were rejected","aggregateErrors":[]},"msg":"Failed to connect to peer at address: /dns/nemes.farcaster.xyz/tcp/2282"}
{"level":50,"time":1721878200025,"pid":30,"hostname":"farcasterhubble-569864c58-fn4dr","component":"GossipNodeWorker","err":{"type":"AggregateError","message":"All promises were rejected","stack":"AggregateError: All promises were rejected","aggregateErrors":[]},"msg":"Failed to connect to peer at address: /dns/hoyt.farcaster.xyz/tcp/2282"}
{"level":50,"time":1721878200025,"pid":30,"hostname":"farcasterhubble-569864c58-fn4dr","component":"GossipNodeWorker","err":{"type":"AggregateError","message":"All promises were rejected","stack":"AggregateError: All promises were rejected","aggregateErrors":[]},"msg":"Failed to connect to peer at address: /dns/lamia.farcaster.xyz/tcp/2282"}
{"level":50,"time":1721878200025,"pid":30,"hostname":"farcasterhubble-569864c58-fn4dr","component":"GossipNodeWorker","err":{"type":"AggregateError","message":"All promises were rejected","stack":"AggregateError: All promises were rejected","aggregateErrors":[]},"msg":"Failed to connect to peer at address: /dns/bootstrap.neynar.com/tcp/2282"}
{"message":"{\"level\":40,\"time\":1721878200026,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"PeriodicPeerCheckScheduler\",\"err\":{\"type\":\"HubError\",\"message\":\"could not connect to any bootstrap nodes\",\"stack\":\"HubError: could not connect to any bootstrap nodes\\n    at GossipNode.bootstrap (file:///home/node/app/apps/hubble/src/network/p2p/gossipNode.ts:684:18)\\n    at PeriodicPeerCheckScheduler.doJobs (file:///home/node/app/apps/hubble/src/network/p2p/periodicPeerCheck.ts:48:20)\",\"errCode\":\"unavailable\",\"presentable\":false,\"name\":\"HubError\"},\"msg\":\"No Connected Peers\"}\n","timestamp":"2024-07-25T03:30:00.026Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878202387,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"FNameRegistryEventsProvider\",\"msg\":\"Fetched 0 fname events upto 622444\"}\n","timestamp":"2024-07-25T03:30:02.387Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878202590,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"L2EventsProvider\",\"blockNumber\":123139712,\"msg\":\"new block: 123139712\"}\n","timestamp":"2024-07-25T03:30:02.590Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878206611,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"L2EventsProvider\",\"blockNumber\":123139714,\"msg\":\"new block: 123139714\"}\n","timestamp":"2024-07-25T03:30:06.611Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878207639,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"FNameRegistryEventsProvider\",\"msg\":\"Fetched 0 fname events upto 622444\"}\n","timestamp":"2024-07-25T03:30:07.639Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878209049,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"GossipContactInfo\",\"msg\":\"starting gossip contact info job\"}\n","timestamp":"2024-07-25T03:30:09.049Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878209051,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"Hub\",\"rpcAddress\":\"<IP_ADDRESS>\",\"rpcPort\":2283,\"msg\":\"gossiping contact info\"}\n","timestamp":"2024-07-25T03:30:09.051Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878210641,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"L2EventsProvider\",\"blockNumber\":123139716,\"msg\":\"new block: 123139716\"}\n","timestamp":"2024-07-25T03:30:10.641Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878212899,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"FNameRegistryEventsProvider\",\"msg\":\"Fetched 0 fname events upto 622444\"}\n","timestamp":"2024-07-25T03:30:12.899Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878214665,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"L2EventsProvider\",\"blockNumber\":123139718,\"msg\":\"new block: 123139718\"}\n","timestamp":"2024-07-25T03:30:14.665Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878218144,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"FNameRegistryEventsProvider\",\"msg\":\"Fetched 0 fname events upto 622444\"}\n","timestamp":"2024-07-25T03:30:18.144Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878218700,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"L2EventsProvider\",\"blockNumber\":123139720,\"msg\":\"new block: 123139720\"}\n","timestamp":"2024-07-25T03:30:18.700Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878222724,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"L2EventsProvider\",\"blockNumber\":123139722,\"msg\":\"new block: 123139722\"}\n","timestamp":"2024-07-25T03:30:22.724Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878223389,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"FNameRegistryEventsProvider\",\"msg\":\"Fetched 0 fname events upto 622444\"}\n","timestamp":"2024-07-25T03:30:23.389Z","type":"out","process_id":0,"app_name":"hubble"}
{"message":"{\"level\":30,\"time\":1721878226741,\"pid\":30,\"hostname\":\"farcasterhubble-569864c58-fn4dr\",\"component\":\"L2EventsProvider\",\"blockNumber\":123139724,\"msg\":\"new block: 123139724\"}\n","timestamp":"2024-07-25T03:30:26.741Z","type":"out","process_id":0,"app_name":"hubble"}

Monitoring

Info API
curl https://xx.com/v1/info?dbstats=1
{"version":"1.13.8","isSyncing":false,"nickname":"Farcaster Hub","rootHash":"7f1ec44f8a881d93324174dae2bc6c3e9145373b","dbStats":{"numMessages":489445060,"numFidEvents":808038,"numFnameEvents":621479,"approxSize":152020335378},"peerId":"12D3KooWN5GVyXwo7SCWytrEuPzDXkjGWsjXkqv1sJmXEWGSmWpb","hubOperatorFid":0}

Sorry for the delay in response. This looks like a network connectivity issue, and not related to Hubble itself.
We highly recommend using Neynar instead of running your own hub.


NO-TICKET-normalise-tests-app-helpers

Optimise & order imports
Double to single quotes
Normalize function definitions/ signatures
Normalize variable names

So personally I think changes like just changing quote marks are a bad thing, because they make following the history of each line significantly harder. Optimising things is okay (preferably if it actually seems to need optimising) and better variable names I have no problem with at all :)


LibAUC code

I was wondering whether you could also commit the core library code to this repository? I just see examples and scripts, and no code for the actual library.
Are there plans to integrate the optimizers with other large scale training frameworks such as DeepSpeed? Have you tested the optimizers on large models? (say >500M parameters)

It appears that the actual library and code are not yet released.  Running the examples according to the provided instruction only gives an error message: AttributeError: module 'libauc' has no attribute 'losses'.  Wondering when will the library be released?

@jacobdang The source file is actually available here. You can simply download it and use pip to install. After the installation, the source code is located on your local python directory. We are currently working on a major release and expect to push this update sometime next month.
Regarding your code, it is hard to diagnose why you ran into this error without further information provided (e.g., which version, tutorials, etc.).

I think what @jacobdang means here is that the source files for the actual library are not hosted on GitHub -- the GitHub repo and the releases page only contain code for the tutorials/examples not the python module.

Seconded, I would also prefer to have the source files for the library on Github - I've been using this library quite a bit and it would be useful to be able to search the source files in a browser.

It would be nice to have source code. I'm currently struggling running one of the examples as it's extremely slow for me to download a dataset. If the source code is available, there can be flexible solutions.


PPC: Add ability to optimize video from checklist panel

Description
Give PPC "video not optimized" recommendations ability to optimize existing media. This work is already functional in https://github.com/google/web-stories-wp/pull/7130 that Jonny worked on. It's behind a feature flag. Our need here is to lift this functionality w/ the button to optimize the video into the PPC for each video in a story.
Acceptance Criteria

Ability to optimize individual videos from PPC
If an upload fails the button should update to say "Try again" with an error state.
When the optimize button is hit for a video disable the button so that users can't keep clicking it
Add tests

(ignore the arrow)
https://www.figma.com/file/1YM3jA9h4QGc4xLdyaXIJS/Stories-Sprint-1.7?node-id=7122%3A22242

Verified in QA


Images in List Dialog are overblown

Please consider making a Pull Request if you are capable of doing so.
Library Version:
2.0.0-rc10
Affected Device(s):
Nexus 5x
Describe the Bug:
When using the listdialog. If you have an image, it fills the whole dialog instead of wrapping content.
To Reproduce:

Create a list dialog using the library
Add an image to the layout
Observe image hight is extremely big.

Expected Behavior:
Expect image to be the dp size specified
My item layout for the list dialog
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:orientation="horizontal"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:gravity="center_vertical">

    <ImageView
        android:id="@+id/item_support_image"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        tools:src="@drawable/support"/>

    <TextView
        android:id="@+id/item_support_title"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:paddingStart="16dp"
        android:paddingEnd="16dp"
        tools:text="Online FAQ"/>

</LinearLayout>

<ImageView android:id="@+id/item_support_image"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    tools:src="@drawable/support"/>

You should set an explicit width and height to your view.
This isn't an issue with this library, more so how RecyclerView or the ImageView handles itself.

This was never an issue before. So it seems something did change (even if maybe with Google's library). But your suggestion is still appropriate, thanks for the quick response!


This browser or app may not be secure

When I run the demo and go to google's calendar and try to log in it won't work.
Any idea how to trick google into trusting this browser?
Couldn't sign you in
This browser or app may not be secure. Learn more
Try using a different browser. If you're already using a
supported browser, you can try again to sign in.

Hey:
Check this thread to understand why:
https://magpcss.org/ceforum/viewtopic.php?t=16764

@joaompneves thank you, that is very helpful


I got token, bug an error occurred: execution reverted: Tokens are already locked

@Negentropy247 Hi,I have encountered the same situation as you, how did you deal with?


Fixing QueryService interface.

@enisoc @sougou
And a couple other fixes too.

Start with go/vt/tabletserver/queryservice/queryservice.go for the review, the rest is mostly related.

Looks much cleaner. LGTM.


[Theme Request] Blurple Gasstron

didnt work when i did it for som reason

Glasstron was previously broken, if you try now you might get better luck.

I believe this should be good:


Introduce sass skins

Woops, i just realized sass files are not included in npm package :)
Would you ?


chore: fix build

Explicitly exclude the "examples" directory from the jsii build.

Pull Request Checklist

[x] Testing

Unit test added
CLI change?: manually run integration tests and paste output as a PR comment
cdk-init template change?: coordinated update of integration tests with team

[x] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated

[x] Title and Description

Change type: title prefixed with fix, feat will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[x] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Merging because I want master fixed.

Lgtm


🛠 [TASK] : Voices Dev Env Deployment

Summary
Deployment of Dev voices
Description
We beed to be able to deploy dev version of voices website and make sure prod is deployed only when needed
Part of #726

FYI @benbooth493 @jmgilman

Related #785


feat(datasets): Added PyTorchDataset

Description
Closes 714
Development notes
Added PyTorchDataset to use pytorch's recommended save and load methods. Added tests to kedro-datasets/tests/kedro_datasets_experimental/pytorch/test_pytorch_dataset.py
Checklist

[X] Updated the documentation to reflect the code changes
[X] Added a description of this change in the relevant RELEASE.md file
[X] Added tests to cover my changes

Hey @bpmeek, could you resolve the DCO failures following the instructions here - https://github.com/kedro-org/kedro-plugins/pull/735/checks?check_run_id=26337551853

I'm not sure what to do about the unit-test failures, none of them are related to my changes.
running pytest kedro-datasets/tests/kedro_datasets_experimental/pytorch/test_pytorch_dataset.py passes successfully.

@bpmeek Yeah the failures don't seem to be related, I'll take a look at the CI failures! Thanks for fixing the DCO check!


Add a way to intercept writes (and reads) to the context

Hi,
thanks for this great crate!
I would like to add a way to get notified when values are written to the context. For example so that I do not have to check all coils for changes after writes, but only handle changed values.
One idea how to solve this would be to have a trait Context that implements all methods that are needed by the ModbusFrame::process_write and ModbusFrame::process_read methods. Users could then provide their own context implementations, which handle writes and reads.
In a later step I would add a ContextObserver that wraps a Context and would allow you to register callback functions for the different actions that might happen.
Would you accept a PR for this?
Thanks,
tdittr

Good day,
for sure we can make Context abstract. The default structure is actually called ModbusContext anyway so you can introduce trait Context with no problem.
Just try not to make it overcomplicated.

I created a PR in #17

thank you. I am going to review it on Tuesday

by the way, could you please merge everything in a single commit? and make sure the crate examples are working. if no, I can do that later manually

Hey, sorry I did not have time to finish my proof-of-concept. And the more I think about it the less I think it is useful. In the end you would always need a buffer of u8 or bool which ModbucContext already provides. I think it might be actually easier to just return which values were changed from process_write, which also makes the implementation a lot less complex.
What do you think?

it might be useful in certain cases because some registers may be still written. anyway I have been working with Modbus for about 25 years and I'm really skeptical about write ops can trigger events in 100% cases correctly. the majority of equipment vendors used to have scheduled event loops (like in OPC-UA or TwinCAT).
you are trying to do a great job.

Yes, I think the current solution which just checks what the request wants to change leaves most control to the user so I am quite happy with it. Thanks again for the crate and helping me with the contribution :)

0.8 has been released today with the commited event engine (experimental)


Make mixnode handle bodies coming from the same source concurrently

So far, the mixnode has spawned a new async task whenever it accepts a new inbound connection from mixclients or other mixnodes. It's good for handling multiple mixclients and other mixnodes concurrently.
But, it's not enough for better performance. Mixnode also needs to spawn a new async task whenever it reads a 'body' from a inbound connection, so that it can handle bodies concurrently which comes from the same source. This is especiallly important if we set delay to Sphinx packets.
Previously, we hadn’t haven this issue since we had created one-time connections and closed them immediately. But with conn pool added recently, we have this issue.
This PR makes the mixnet.rs test much faster: 20s -> 3s
I'm opening this PR based on the PR #370 because I need #370 to make CI passed. It seems #370 is not very related to the performance issue, but it still should be done since I think we have logical issues with regard to locking.

It seems https://github.com/logos-co/nomos-node/pull/370 is not very related to the performance issue, but it still should be done since I think we have logical issues with regard to locking.

What issues?

It seems #370 is not very related to the performance issue, but it still should be done since I think we have logical issues with regard to locking.

What issues?

The issue seems that using sync version Mutex blocks the async runtime.

but we do not actually find the real reason, just found if we remove sync version Mutex, then CI pass.

The real reason seems https://github.com/logos-co/nomos-node/pull/373

but we do not actually find the real reason, just found if we remove sync version Mutex, then CI pass.

The real reason seems #373

Yes. This is the reason.

Codecov Report
Patch has no changes to coverable lines.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
:loudspeaker: Thoughts on this report? Let us know!.


Square Theme and section

Hi,
I'm having a small problem with the "Square" theme when used with sections.
Indeed, the entity is no longer centered on height.

Can you help me ?
THANKS

Hum, solved with editing theme CSS :
Layout
mush-spacing: 8px -> 12px


feat: introduce @stylistic/eslint-plugin-plus

#136

Why "plus"?

Any name suggestions?

A few in my mind:

extra - I guess it's ok, but it feels a bit "excessive" to me.
additional - I personally feel it's a bit too long.
more - "JavaScript Rules, TypeScript Rules, More Rules" feels a bit weird
plus - Short, with the meaning of additional but not as "excessive" as extra

In that regard, I am not a native speaker so my feeling could be inaccurate. Open for suggestions

I am merging this to dev branch for now so we can start work on rules. Still open for better naming until it get published in the next minor

I’m a bit confused why it needs to be a separate plugin tbh. If it doesn’t belong in the main plugin, why is it in stylistic at all?

I explained the reason in https://github.com/eslint-stylistic/eslint-stylistic/issues/136
For users who directly use @stylistic/eslint-plugin, it's not a concern. And eventually, we will merge all rules into a single plugin, but that would be a breaking change in the future.

Adding rules is semver-minor; it's only adding enabled things to a config that'd be a breaking change.
I don't find that reason compelling tbh; it just kind of seems like you're trying to move your personal rules under this quasi-official branding :-/

you're trying to move your personal rules under this quasi-official branding :-/

I found that offensive if you say so. I spend a lot of effort on migrating and maintaining this because I care. I tried hard to keep things natural, and only proposed to add rules that improve whitespace and solves long-standing issue that no one was going to fix. I don't know how I can help communicate this better. You ignore the technical reasoning and accuse me like that out of nowhere.

I don't mean to make an accusation, but you're making a ton of unilateral changes without many others weighing in.


Commander: Preflight check improvement

Improves the user feedback for preflight checks. If a sensor fails because it is not calibrated or healthy, an alarm tune will play instead of the normal startup tune. Furthermore the LED will blink rapidly red until the problem is resolved and the system will refuse to arm (with appropriate error messages).
This moves the preflight check to the commander module and effectively deprecates the old preflight_check module (I would recommend removing it to avoid having to maintain two systems which do the same).
Please do not merge into master until I have had time to verify my fixes. One potential problem is in-air reboot where the system will run pre-flight checks and fail (because of accelerations, 1.5 second delay while collecting sensor data and what-not)

Awesome! I will try to test the inflight reboot - as the preflight check is already disabled it shouldn't actually lock.

@LorenzMeier This is the line I'm talking about:
https://github.com/Zefz/Firmware/commit/a20d8ece0742f6013324651b9b21f9529824958c#diff-a2bcb238e25d8a97ab2aee48f54dbc48R182
which was part of preflight_check.c. The preflight_check.c module ran in a new thread so it didn't block the boot logic, but the commander runs this in it's main task thread.

I would suggest removing that line, I don't think it's strictly needed. In addition, the state restore logic should exclude the execution of the check completely, for this and other reasons. I did test a while back that it does, but I would indeed need to re-test.

Is there a way the Commander knows that it is doing an in-air reboot in it's startup routines? (some sort of flag set?)

@Zefz Here is the code path for in-air reboot:
https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L549-L554
This command is sent by the IO driver, which in turns uses the IO onboard state for state preservation. This will be moved to the battery-backed SRAM once available, but the command will likely remain similar.
You can see that the pre-arm checks are completely bypassed on a restore:
https://github.com/PX4/Firmware/blob/master/src/modules/commander/state_machine_helper.cpp#L153-L155

That looks good. There was some unclear code (possibly legacy?) that indicated that the entire commander could reboot in-air (in air reboot as opposed to in air arming restart). It could be that I am still confusing terminologies/functionality here. There is also a difference between pre-flight check and pre-arm check ;)

Much appreciated! I will try to get some testing done on this the coming week. If not I might have to rely on you to do the last change I suggested and testing with @kd0aij.

From the commits and diff this looks like its good to go - is this accurate?

@LorenzMeier  Yes. It might need rebasing on master again, it has been a while since it was synced.

Closing and reopening a rebased one.


Refreshtoken always returns null

First of all thanks for providing this provider.
When doing exactly as the example says I get the access token and expires too, but the refreshToken is always returned as null no matter if I set the 'access_type' to 'offline' as stated in the README.
According to the documentation of Zoho Creator it should always return a refreshToken.
Is the example on the README accurate? Am I missing something? Is this a known issue?
Thanks in advance,

Just found out it does work, but only when setting 'prompt' to 'consent'. So not an issue of the provider, but Zoho just isn't sending the refreshToken when prompt isn't set to consent.
Maybe you could add this information to the README here as it's pretty confusing that the example on itself doesn't work.


Cache interpreter versions

Intent
This PR avoids repeatedly invoking R and Python interpreters to query their versions, by caching those versions.
Draft PR because I need to think about whether we need to not cache the .pyenv/shims/python interpreter, which runs different interpreters based on pyenv settings and potentially .python-version files.
Follow-on to #1929
Type of Change

[ ] Bug Fix

[ ] New Feature

[ ] Breaking Change

[ ] Documentation

[ ] Refactor

[ ] Tooling

[x] Performance

Approach
Cache interpreter versions in agent memory, using interpreter path as the key.
Automated Tests
Existing tests have been updated.
Directions for Reviewers
Inspect projects (especially recursively). We should only request each R or Python interpreter version once.

just curious; what happens if an executable is deleted on the system after it has been added to the cache?

If it was still the selected interpreter in Positron/VSCode, the extension would succeed at creating configurations using it, but fail if dependency scanning was attempted.
It seems like we should have these cache entries expire, to handle that case as well as the case where a user removes a local virtualenv and recreates it with a different Python version (for example, because their Connect server doesn't have the prior version).


pyrsia_node fails to start service when boot.pyrsia.link is down

When boot.pyrsia.link is down Pyrsia node fails to connect or find it and then fails to start the service. Since we are a p2p network, boot.pyrsia.link status should not matter when the service starts. The service should start and then try to connect to the p2p network. If boot.pyrsia.link is down or unreachable it should have the option of connecting to other pyrsia_nodes that will still be online.

This issue should only address the situation where pyrsia node itself crashes when the network connection fails(after trying a few times). We need to make the pyrsia_node resilient to network failures and regardless of those pyrsia node should be serve all the cached content.