Samples naming vs  Samples Browser

Hi,
I noticed an issue with some examples in the samples browser. First, I give you some information about the way the sample browser works (which could be placed inside a wiki page, so that it is not lost). The real issue will come in the next comment.

In order for the samples browser to display nice legends and code like this,

Some simple rules must be followed:
Rule # 1 : File naming

The name that is stored inside _ISamplesIndex::_samples should be the name of the class, with no variation
The name of the .cpp and .h files  should the snake_cased_name_of_the_class

For example, inside src/Samples/src/samples/loaders/gltf/_loaders_gltf_samples_index.cpp one should write:
  // Animated Morph Cube Scene (glTF)
  _samples["AnimatedMorphCubeGLTFScene"] = [](ICanvas* iCanvas) {
    return std::make_unique<AnimatedMorphCubeGLTFScene>(iCanvas);
  };

Rule # 2: Documentation in the samples headers
If the header file (in the near future, it could also be the .cpp file) contains a comment block with @see and @brief sections, they will be included automatically in the samples browser.
It is important to almost always add them, with a link to the example on the BabylonJs playground (when applicable), and a link to the doc (if applicable).
In the case of @see links, there should not be a \nbetween the @see tag and the link.
/**
 * @brief Alpha Blend Mode Test Scene (glTF). Tests alpha modes and settings.
 * @see https://doc.babylonjs.com/how_to/load_from_any_file_type
 * @see https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/AlphaBlendModeTest
 */

Details about the inner working of the samples browser:
The file build\build\bin\samples_info.json contains all the information for each sample.
Example:
    {
        "header_file": "F:\\dvp\\OpenSource\\BabylonCpp/src/Samples/include/babylon/samples\\animations/animated_morph_target_scene.h",
        "source_file": "F:\\dvp\\OpenSource\\BabylonCpp/src/Samples/src/samples\\animations/animated_morph_target_scene.cpp",
        "sample_name": "animatedmorphtargetscene",
        "brief": "Animated Morph Target Scene. Example demonstrating how to morph a mesh between multiple targets.",
        "links": [
            "https://www.babylonjs-playground.com/#HPV2TZ#8",
            "https://doc.babylonjs.com/how_to/how_to_use_morphtargets"
        ]
    },
    {
        "header_file": "F:\\dvp\\OpenSource\\BabylonCpp/src/Samples/include/babylon/samples\\animations/animations_101_scene.h",
        "source_file": "F:\\dvp\\OpenSource\\BabylonCpp/src/Samples/src/samples\\animations/animations_101_scene.cpp",
        "sample_name": "animations101scene",
        "brief": "Animations 101 scene. Example demonstrating how to add animations.",
        "links": [
            "https://www.babylonjs-playground.com/#QYFDDP#1",
            "https://doc.babylonjs.com/babylon101/animations"
        ]
    },
    {
        "header_file": "F:\\dvp\\OpenSource\\BabylonCpp/src/Samples/include/babylon/samples\\animations/animations_scene.h",
        "source_file": "F:\\dvp\\OpenSource\\BabylonCpp/src/Samples/src/samples\\animations/animations_scene.cpp",
        "sample_name": "animationsscene",
        "brief": "Animations scene. Example demonstrating how to add animations.",
        "links": [
            "https://doc.babylonjs.com/babylon101/animations"
        ]
    },

This file is generated by the python script src\Samples\make_samples_info\make_samples_info.py which is called at each build by src\Samples\CMakeLists.txt:
add_custom_command(
    TARGET Samples
    PRE_BUILD
    COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/make_samples_info/make_samples_info.py
    COMMENT "make_samples_info"
    WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/build/bin
)

I noticed some issues with the Samples Browser for the GLTF examples.

Issue 1: the view codebutton fails, because the file names and the sample names are inconsistent
(for example, the sample name is AnimatedMorphCubeGLTFScene although the class name is AnimatedMorphCubeScene)

Example
  _samples["AnimatedMorphCubeGLTFScene"] = [](ICanvas* iCanvas) {
    return std::make_unique<AnimatedMorphCubeScene>(iCanvas);
  };

Issue 2: some @see links are cut by a \n and they are not displayed

For example:
/**
 * @brief Animated Morph Cube Scene (glTF). The cube contains two morph targets
 * in it:
 * * thin : moves the vertices so that it becomes super-thin
 * * angle : moves the vertices so that it forms a ramp
 * The animation loops, morphing between these two states.
 * @see https://doc.babylonjs.com/how_to/load_from_any_file_type
 * @see
 * https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/AnimatedMorphCube
 */
struct AnimatedMorphCubeScene : public IRenderableScene {

Could you have a look at this?

PS 1: I tried the GLTF samples under windows, they still give an empty rendering.
PS 2: BabylonCpp was starred by the creator of ImGui (ocornut). This is a good news!

Hello Pascal,
Thanks for the detailed explanation on how the samples_info.json file is created. Now I understand the weird issues with the Samples Browser for the GLTF examples.
Thanks to your last PR containing the headerless samples support macro and the the clang change to have a column with of 100 I could update the babylon and gltf examples to match the requirements you mentioned above.

It is a good suggestion to create a wiki page about this. I will create one with this information and then close this issue report.
About the glTF support, I am currently updating the glTFLoader code to the latest version, this should be finished tomorrow. This weekend I planned to debug the glTF examples on Windows to have the almost 40 examples glTF working by the end of the weekend. The screenshots can then also be uploaded.
Since we posted the screenshots, a lot of people starred the project (including the creator of ImGui (ocornut) like you mentioned), some people forked the project too. This is really good news! The project is now in much better shape compared to 6 months ago, thanks to your help (with all the work you did on the Windows support, GUI changes, rendering to framebuffers, resolving many code issues, code improvements etc.) and it is becoming stable enough to be used by more people :)
Cheers!
Sam

Hello,
this issue should now be resolved by running the script that made the examples headerless and repaired the headings.
I create the following wiki page with the information as mentioned above.
Cheers!
Sam


Git pull failing with "git-remote-keybase error: (1) packfile not found"

This has been happening on one of my private git repos since around the beginning of this week (only on macOS 10.13.3):
$ git pull
Initializing Keybase... done.
Syncing with Keybase... done.
git-remote-keybase error: (1) packfile not found

The first time this happened, I upgraded Keybase to Version 1.0.47-20180410052738+f705a9510f. However, I'm continuing to see this happen. I saw #11358 and tried to run keybase git delete $REPO, since I have the repo cloned locally, but that command hangs.

@telotortium please run keybase log send and we can take a look.  Having some downtime right now that might be affecting your ability to delete the repo.

Log ID: d0b6431d457ef26c9c6b771c

It's dying looking for pack-0000000000000000000000000000000000000000.idx, which seems like a problem to me, since that's not a likely packfile name (usually it's named by the hash).
@telotortium how did you create and initialize this repo?  Did you push --all an existing repo, or have you built it up commit-by-commit?
(Our downtime is over now, in case you want to retry deleting and recreating the repo.)

I started a new repo on my workstation, created the repo in Keybase, manually set the remote in my local repo to point to Keybase, and then ran git push to push changes to it. Usually I use git push --force-with-lease.

I'm just wondering if git-remote-keybase initialized the repo on the first push from a repo with a long history already, in which case the bug might have already existed in that initial repo (unrelated to KBFS).  But if you started with an empty repo and built it up commit by commit, this isn't likely.
Are you willing to share the repo with me for debugging purposes?  If so, and it's not too big, please do this:
cp -r /keybase/private/telotortium/.kbfs_git/<repo-name> /keybase/private/telotortium,strib/

(substituting your repo name for <repo-name>, I don't want to expose it publicly here.)  Then I can dig into it locally.

I've shared the repo with you.

Thanks.  I play around with it and am not having any issues cloning, pulling or pushing.  Hrm.  Are you still getting the packfile failure on a git pull?

 On KBFS HEAD is at be300d2 and has the local HEAD as a direct ancestor. Should I just try to clone the repo elsewhere locally?

Yeah a full clone from what is in KBFS worked for me, so you might want to try that.  But that's not very satisfying, I'll try to repro your issue on my own too.

I performed a full clone 2 days ago. Now I'm seeing the issue again. I know that I recently updated the repo from a Linux workstation, so maybe that has something to do with it.

Log ID from Linux: 446816aef643c4996ebee11c. However, I restarted Keybase since the push that seems to have caused the problems on macOS (due to upgrading on Linux), so I'm not sure how useful it is. Also, I ran git push from Linux just now, but I'm still seeing the same issues on macOS.

Another thought: pack-0000000000000000000000000000000000000000.idx looks a lot like it's a filename that would result if the code had forgotten to set a variable or field that should hold a Git object ref, because Go zero initializes all fields and variables.

Oh, I might see the problem.  It looks like, at the KBFS level, you once had two clients (or maybe two simultaneous git commands on the same client) updating the repo at the same time.  This led KBFS to do conflict resolution, which led to special "conflict" files in your repo/objects/pack directory.  It seems like the git library we're using isn't correctly ignoring these files, and is instead trying to treat them like regular files, leading to the zero hash.
If I'm right, this should clean it up for you (where $REPONAME is set to your repo's name):
rm /keybase/private/telotorium/.kbfs_git/$REPONAME/objects/pack/*conflicted*

Can you give that a try and see if it helps?  (Though I'm still not sure why I wasn't able to repro it myself.)

That works! It's quite possible that two clients on different computers could have tried to access the repo at the same time (I'd think less likely than 2 git commands on the same computer, because Git normally locks the repo while performing operations, doesn't it?). I wonder what could be done to prevent this in the future.

Great!  I have a fix in our code so this won't happen again, I'll put up a PR soon.
And no, git doesn't prevent you from running git push (or whatever) command more than once on the same client.  The locking happens on the remote side, but the way Keybase git works is that the lock only protects a very small part of the operation (for performance reasons).  We let the clients upload multiple copies of the same packfile if they try to do so.
Thanks for your help catching this!

Merged to master, shouldn't happen again after the next release.

I updated keybase today and now hovae this problem.

Please open a new issue and send logs.


Updates?

Hi there,
Really like your series of gitlab related docker, so thanks! I was wondering if you were planning to update the multi-runner to the latest version. It seems that the new version is 1.5.0 now. https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/master/CHANGELOG.md
Thanks!
Jun

It would be great if you'd simply make this variable configurable (passable during build-time).

@sameersbn I'd be extremely grateful for an update too, the current release is 1.6.0.
Keen to get rid of our custom runner with Docker Agent installed.

There are several pull requests for later versions up to 1.8.0. Many features have been added since 1.1.4.
Is there a specific reason why you won't upgrade the runner image?

@QuickJack @niieani @jmatsushita @Maescool @digitalLumberjack @sameersbn
This repository doesn't seem to be maintained any more. Would anyone be in favour of starting a fork?

My fork is plugged on docker hub :
https://github.com/digitalLumberjack/docker-gitlab-ci-multi-runner
https://hub.docker.com/r/digitallumberjack/docker-gitlab-ci-multi-runner/
I try to update version as soon as i see gitlab new versions. Feel free to open pr if you need a new version not yet implemented.
If anyone would like to make his own fork "official" no problemo, i'll follow.

That's great, thanks @digitalLumberjack.
Or would @sameersbn consider giving you maintainer rights?

@digitalLumberjack i would be happy to add you as a collaborator/maintainer. wdyt?

yes we could do that @sameersbn

@digitalLumberjack can you send a PR with your changes?

I'll do that before the end of the weekend.

https://github.com/sameersbn/docker-gitlab-ci-multi-runner/pull/33

@sameersbn any news on @digitalLumberjack becoming a maintainer and getting #33 merged?

Awesome @digitalLumberjack and @sameersbn! Looking forward to a newer version as well!

.... anything happening.... ?

I'm waiting for @sameersbn approval on #33 :D

@sameersbn have you changed your mind on @digitalLumberjack becoming a maintainer on this repository?


Add the possibility to run tests on specific subset of devices

One additional paramter "devices".
The script finally takes into account chosen selectors and devices.
If no chosen selectors match chosen devices script fails.

Closed in #38
2 independent filters: selectors and devices.


Fix Manganato search

This PR fixes two bugs.

Wrong base URL template
Wrong: https://chapmanganato.com/https://manganato.com/search/story/%s
Correct: https://manganato.com/search/story/%s
After digging a bit on the website I found that the JS function below is being used to parse the user searches before sending the request to the server, so I implemented the same logic here too so we get the same results

function change_alias(alias) {
    var str = alias;
    str= str.toLowerCase();
    str= str.replace(/à|á|ạ|ả|ã|â|ầ|ấ|ậ|ẩ|ẫ|ă|ằ|ắ|ặ|ẳ|ẵ/g,"a");
    str= str.replace(/è|é|ẹ|ẻ|ẽ|ê|ề|ế|ệ|ể|ễ/g,"e");
    str= str.replace(/ì|í|ị|ỉ|ĩ/g,"i");
    str= str.replace(/ò|ó|ọ|ỏ|õ|ô|ồ|ố|ộ|ổ|ỗ|ơ|ờ|ớ|ợ|ở|ỡ/g,"o");
    str= str.replace(/ù|ú|ụ|ủ|ũ|ư|ừ|ứ|ự|ử|ữ/g,"u");
    str= str.replace(/ỳ|ý|ỵ|ỷ|ỹ/g,"y");
    str= str.replace(/đ/g,"d");
    str= str.replace(/ /g,"_");
    str= str.replace(/[^0-9a-z\s]/gi, '_');
    str= str.replace(/_+_/g,"_");
    str= str.replace(/^\_+|\_+$/g,"");
    return str;
}

JS function location on the website

Hey @joao-salomao I hope you're doing well. I just wanted to ask, if mangal still working? cause its not showing any results for me


More generic id for traces and spans

Hi,
At our organization we'd like to integrate apps using this project with other technologies. We've been asked to use an UUID as in http://docs.oracle.com/javase/7/docs/api/java/util/UUID.html. An UUID is unique and generators exist for different technologies... and we're using it with other technologies.
I've been looking at different repositories and issues and I've noticed that:

Issue #106 changed from String (representing an UUID) to a long. It doesn't explain why but I guess it's because zipkin uses that format, right?
Issue #19 includes a comment saying: "64 bits is really too small and Zipkin admits it"... Are 64bits enough?
OpenTracing project defines a Span in a very generic way: https://github.com/opentracing/opentracing-java/blob/master/opentracing-api/src/main/java/io/opentracing/Span.java

Are you sure you want to define a Span as a class containing long fields for trace and span ids? Would it be possible to define Span in a more generic way? For example:

Define Span as a parametrizable class/interface and provide a default implementation using Long for the ids. I don't know, maybe sth like "DefaultSpan extends Span".
Or define an extensible SpanId class/interface as field for the ids.
Or sth more generic as using a String (like you were using before) for the ids.

the zipkin admits it thing might be a bit varied. Twitter receives more traffic than most sites and collisions have been noted, but they still use the same format today. There are other very large sites that also use this id structure.
Since ids are unique on trace id + span id, you get effectively 128 bits of uniqueness, just like htrace etc.
Are you running into collision problems? What sort of trace volume do you have?

To comment on the other points..
OpenTracing is an interface, and doesn't say anything about how ids are made or even if they exist. That's to allow different implementations, such as sleuth, to exist underneath the api. If they specified an ID format, it would likely interfere with the api goal.
Sleuth, on the other hand, is an implementation. You'll notice it has a lot of instrumentations baked in, and it takes care to make sure everything works. For this reason, we have to be careful about where volatility is introduced.
It was intentional to limit choices on IDs, not just from a technology soundness pov, but it also helps us remain compatible with other zipkin traces. IOTW, given the structure as it is, sleuth traces are explicitly compatible with those written in various languages. http://zipkin.io/pages/existing_instrumentations.html
ps if the goal is to correlate, you can always log your UUID in the span. ex. "request.id"=YOUR_UUID
zipkin will allow you to query against that. It is common to log keys such as this.

We aren't using Sleuth on production so we haven found collision problems yet. UUID gives us more guarantees and besides from our organization they are asking for that format, that's why we are asking for this "improvement".
Thank you for your answers and suggestions, Adrian.

No prob

We can't actually add this again as an improvement for all the reasons that Adrian has mentioned.
What you can do is as Adrian says

log your UUID in the span

then you can for example implement your own version of a logger and put that UUID into MDC to log it into the logs.
Is this solution acceptable for you?

It's not just logging the info of the UUID received from "legacy clients" but the capability of using UUID as the trace and span ids along all the requests.
I'll check with the other colleages involved with all this information to see if it's acceptable, I think Sleuth is a very interesting project to use in our Java apps.
Thanks again.

Ping :) So how did your discussions go?

It seems we'll give it a try as it is at the moment, using the 64bits randomly generated ids :)

Cool! :) I'm closing it then


[WIP] - chore: rubocop fixes

Thank you @Juice10 for looking this over.
There are several tests that failed, suggesting an uninteded semantic change.
> citool monitor -r 219648421
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should handle initialization with no code FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should handle initialization with no content FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should run and report an error for function not returning a json object FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should fail to initialize a second time FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should invoke non-standard entry point FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should echo arguments and print message to stdout/stderr FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should handle unicode in source, input params, logs, and result FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should confirm expected environment variables FAILED
runtime.actionContainers.Ruby25ActionContainerTests > runtime proxy should echo a large input FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should fail to initialize with bad code FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should return some error on action error FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should support application errors FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should fail gracefully when an action has a TypeError exception FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should support the documentation examples (1) FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should have mechanize and activesupport gems available FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should support large-ish actions FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should support zip-encoded packages FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should support zip-encoded packages without directory entries FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should fail gracefully on invalid zip files FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should fail gracefully on valid zip files that are not actions FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should fail gracefully on valid zip files with invalid code in main.rb FAILED
runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 should support zipped actions using non-default entry point FAILED
> Task :tests:test FAILED

Closing due to unresolved test failure & merge conflict


[JENKINS-68616] Enable field validation checks

[JENKINS-68616] Enable field validation checks
Regression in 1105 release.  The div that was added to surround the select seems to prevent calls to the attrs.checkMethod.
When using a GitHub branch source, an empty credentials field no longer displays the warning that a credential is recommended.  Other uses of credentials seem to have the same behavior.  Validation checks are no longer called.
When the div is included in the page, the credential validation callback is not invoked. When the div is removed from the page, the credential validation callback is invoked.
It is unclear to me why the addition of a div would change the validation behavior.
Review the differences with white space changes suppressed so that it is clear the difference is only in the deletion of the div tags that wrapped the select.
Not sure how to create a viable test that confirms the fix is behaving correctly.
Revert one HTML div from "Minor improvements"
This reverts part of commit 6dee9b8602f4ba355209f46ddd642d6daca3b448.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick and @basil in case you are interested.

#287 for the record

(I have merge/release permissions but would prefer to get an opinion from @timja as author of #287, since I know little about this subject.)

(I have merge/release permissions but would prefer to get an opinion from @timja as author of #287, since I know little about this subject.)

I agree that we should let this wait until @timja has had time to reply.  The missing validation is unfriendly for the user but does not break functionality as far as I know.

Looking

All Greek to me. @MarkEWaite if you can confirm the last edit preserves the bug fix and general appearance, I can get a release cut.

All Greek to me. @MarkEWaite if you can confirm the last edit preserves the bug fix and general appearance, I can get a release cut.

Confirmed that the fix the most recent change preserves the bug fix and the general appearance.

@MarkEWaite fix re-introduced the UI bug of elements touching each other.
Fix spacing, fixed the spacing so they weren’t touching.
I didn’t attempt to track down a root cause, likely due to some tree building in hudson-behaviour.js which one of the classes was affecting.

I’m unsure @janfaracik may know

There is nothing wrong with being unsure when starting out, but the goal should be to become sure through analytical reasoning, regardless of whether or not one was the original author of the code.


Investigation: How to use eBPF uprobes with Java

Acceptance criteria:

We know how to measure if a Java symbol is triggered using eBPF/uprobe.

Done via https://github.com/arvos-dev/arvos/commit/439ed677e0674ae42f3a5e71c0a064c7d2eb7890


GCLOUD_PROJECT_ID instead of GCLOUD_PROJECT_NUM

Fixes #90

@ofrobots PTAL.

Coverage decreased (-0.009%) to 92.884% when pulling 12d6b96c9c129bd9d54e44cc52ecc6065a4091c1 on matthewloring:env-var into 7f2010a1565e8425bf24fa1529a88741d587f5cb on GoogleCloudPlatform:master.

While you are in README.me, you can drop the warning about Node.js 5.2.0 not being supported.

Done.

LGTM w/ comments.


19 changed to 69 for date

---
author: Gopher
date: 19-june
paging: Slide %d / %d
---

# Welcome to Slides
A terminal based presentation tool

Hi this is now fixed with #170


Add nbutils and document workflow

[ ] Consider adding the nbutils.ipynb type thing (i.e., the thing in https://github.com/ubcecon/econ407_2019, which lets you run cells to do git operations like updating notebooks, undoing local changes, nuking all user created files and changes, etc.)

[ ] Confirm with Matt about the executable cell (i.e., can run it with shift-enter) that isn't executed by the build server (for git magic). Should it be a .. code-block:: python with :class: no-execute?

@arnavs Can you add this into (after the rename) to the root of the rst source as a dependency, and have it deployed to the notebook repository?
utilities.ipynb.txt

Actually, I have a change of heart on this.  I think the "delete and repull" workflow will be easier to use with the launch support built in.  So hold off on this for now.


[Heartbeat Logging] - Integration tests, documentation, refactoring

Add integration tests
Add documentation
Some minor refactoring for better organization
#no-changelog

Hi @ryanwilson, thanks for the second pass! Could you please take one more look at the new changes to make sure you're cool with how everything was addressed?


Cruft updates 22.03

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.775%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5069

Relevant Lines:
5775

💛  - Coveralls


#679: added *.buildinfo file to processedFile list (will be removed)

Fixes #679.
The *.buildinfo files will be added to a new string list "otherFiles".
"otherFiles" are files that are not processed to be integrated into repository (like *.deb), but taken into account when they are deleted after processing (on flag -no-remove-files=true).

done. sorry for that.


Add user-installation + DNSSEC disabling to DNS over Discord

Summary
Update docs to match the upstream DNS over Discord docs, with user-installation (https://github.com/MattIPv4/DNS-over-Discord/pull/89) + DNSSEC disabling (https://github.com/MattIPv4/DNS-over-Discord/pull/65)
Screenshots (optional)
N/A
Documentation checklist

[x] The documentation style guide has been adhered to.
[ ] If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
[ ] Files which have changed name or location have been allocated redirects.

👋Hi there, we’re going to close this PR. All PRs prior to August 12 need to be reworked due to the platform migration to Astro.

👋 @KimJ15 I had already rebased the PR based on that :)


FYI: TelegramL

Hi, I just saw your issue on mjambon/atdgen and I thought I'd reach out to let you know about https://github.com/nv-vn/TelegraML/ which is a Telegram API library in OCaml that was recently released. You can get it with opam by opam install telegraml. Maybe it's not right for your use case but I thought I'd mention it on the off chance you hadn't seen it and it would help you accomplish your goals with OCaml faster. :-)

Hi, cool! I didn't really search for bot libraries for OCaml since I was going to build something simple and I wanted to try out Async and writing a server in OCaml. I don't think I'll use a bot library since I'm mostly done, but thanks for reaching out!


QuickSort on Singly Linked List.java

added quicksort in sorting

Java directory is not for storing C++ files. Please have a look. Also, add the comments in the file too.

hey adi mohan plz accept it i had made changes to it


Expose helper functions to serialize Lson structure into JSON for using liveblocks api endpoints

Is your feature request related to a problem? Please describe.
For some endpoints in liveblocks API such as this you need to provide as the request body a serializable version of your Lson object.
Describe the solution you'd like
It would be nice if @liveblocks/client would provide a function to transform Lson objects (LiveObject, LiveMap, LiveList, etc) in the needed structure, something like:
function convertLsonToJSON(value: Lson): JSONValue {
....
}

Hi @gcrespi, thanks for opening this issue. We agree this different data format is a bit cumbersome to deal with manually. We don't have a helper in the public API because it's we may soon offer a better API to populate storage, which will require less of this juggling. In the mean time, here is a code snippet you can use to convert an LSON tree to the needed data format: https://gist.github.com/nvie/09a34a3e3b219c442a418f033ce73e3a

This has been completed


Feature request: cbreaker supports configuring a minimum number of requests

While using Traefik, we noticed that the circuitbreaker functionality within middlewares appears to be implemented using cbreaker. However, currently, cbreaker does not support configuring a minimum number of requests to determine when to trip the circuit, a feature that is available in frameworks like Hystrix.
In Hystrix, there is a configuration parameter called requestVolumeThreshold (defaulted to 20), which dictates that only when this threshold is met or exceeded within a sliding time window, will Hystrix start calculating the failure rate and decide whether to open the circuit breaker based on this rate. Even if all requests fail within the sliding window, the circuit breaker will not open if the number of requests falls below this threshold.
We would like to inquire if there are any plans to add similar functionality to cbreaker, allowing us to configure a minimum number of requests before circuit breaker decisions are made. This would prevent unnecessary circuit trips due to low request volumes and help maintain service stability under varying load conditions.

If you find this proposal reasonable, I would be willing to assist in implementing this feature.


Refactor GCS OAuth2 to use RestClient

In order to eventually remove the legacy http implementation in storage, it is necessary to transition the existing storage/oauth2 types to use RestClient as their http transport.

This is done, closing.


less hardcored homefolders

i imagine its possible to get rid of all the misterio and replace it with something like $username
https://github.com/Misterio77/nix-config/blob/e90d1153a439dae0b986308f2211f08012e32b6d/home/misterio/desktop/common/discord.nix#L8
could you give me a hint how to do it?

{ pkgs, username, lib, persistence, ... }:{
  home.packages = with pkgs; [ zoom-us ];
    home = {
    persistence = lib.mkIf persistence {
      "/persist/home/${username}".directories = [
        ".zoom"
      ];
    };
  };
}

okay i got it myself :D


Window too big and unresizable after rotating screen/using multiple screens

Sometimes I watch twitch while laying in bed so I rotate the screen by 90 degrees or 270 degrees via the display options of OS X so I can watch video without much neck pain. I also sometimes use multiple screens or both features in conjunction. After this I wanted to open the Livestreamer Twitch GUI again in normal screen but it remembered its size and everything from before, so it was so big I couldn't resize it to be actually usable (it also got more and more unresponsive the bigger I managed to drag the window).

I couldn't find any function or key combination built into OS X to resize the window to make it usable again yet (but I'm also not very experienced with it). What worked was deleting every file inside the folder ~/Library/Application Support/livestreamer-twitch-gui/Local Storage/ but maybe this is something you want to look into. (Also I'm just posting this issue if anyone has a similar problem so they can find the solution quickly.)

Thanks for reporting the issue.
Seems like the window state persistence needs some more work (missing device orientation events).

What worked was deleting every file inside the folder

Just launch the application with the --reset-window parameter. This will reset the window size and position.

Thanks, I tested the parameter and it works as expected here. If anyone on OS X how to start the .app bundle with a parameter, you can just do this in any folder:
open -a "Livestreamer Twitch GUI" --args --reset-window
(provided you didn't change the name of the .app bundle, else you'd have to modify accordingly)

Would you please be so kind and test my fixes?
See the check-screensize branch (c252dd2).
You can find the build instructions here or here.
git clone -b check-screensize https://github.com/bastimeyer/livestreamer-twitch-gui.git
cd livestreamer-twitch-gui
sudo npm install -g grunt-cli bower
npm install
grunt release

There's still a bug that needs to be fixed before I can merge this, though. Maximizing the window on OSX still remembers the window size which it shouldn't do.

@jeifour Still there? :disappointed:

@bastimeyer Unfortunately I can't test these changes as I don't have access to any OS X machines right now because of a personal issue. I should be able to report back next weekend.

Okay, thanks.
All I want to know is if the displayBoundsChanged event gets triggered when the screen rotates. Can't test this in my VM :grin:
I think I'm going to merge this anyway, since it adds the missing screen size logic of the current version. I also want to release v0.8.0 this week.


CLI jar size suddenly increased

Since two or three versions, the CLI jar increased in size by ~30 MB, please investigate.

Fixed in 4.6.3


[AutoML][Vision]  caller does not have permission

Hi,
I am trying to predict an image to my AutoML Vision Dataset, in the hope that i get the label back.
I keep getting the following error code:
Error :
{ "message": "The caller does not have permission", "code": 7, "status": "PERMISSION_DENIED", "details": [] }
Instance : Google \ ApiCore \ ApiException (7) path: vendor/google/gax/src/ApiException.php:139
Code  :
   use Google\Cloud\AutoMl\V1beta1\Image;
   use Google\Cloud\AutoMl\V1beta1\ExamplePayload;
   use Google\Cloud\Vision\V1\ImageAnnotatorClient;
   use Google\Cloud\AutoMl\V1beta1\PredictionServiceClient;

   public function recognize(string $path): Collection
   {
      $image = file_get_contents($path);
      $googleImage = new Image();
      $googleImage->setImageBytes($image);

      $predictor = new PredictionServiceClient();

      $projectId = env('GOOGLE_CLOUD_PROJECT');
      $region = 'us-central1';
      $model = 'MASKED';
      $apiPath = "projects/{$projectId}/locations/{$region}/models/{$model}";

      $payload = new ExamplePayload(['image' => $googleImage]);

      $response = $predictor->predict($apiPath, $payload);
    }

Description
I have one other API Endpoint that i use, the TEXT_DETECTION on OCR Vision API. Which works smoothly.
I have enabled all storage api's and permissions on my serviceaccount but nothing helps. The error is thrown on the last line ->predict()
All help is welcome!

Have you verified that the project ID in ENV[GOOGLE_CLOUD_PROJECT] is correct and matches the service account you are using to make requests?

Have you verified that the project ID in ENV[GOOGLE_CLOUD_PROJECT] is correct and matches the service account you are using to make requests?

Yes, and it does!

I have also enabled all these Roles on my service account.

 It seems that if the former encompassed the latter, they would not have asked for both to be granted. Try adding that role and seeing if it works.
Additionally, review all the other information on that page and be sure you've correctly configured everything.

@jdpedrie I enabled the permissions accordingly to what they stated on the link you provided

(accounts top => bottom : Account for Console UI, AutoML Service agent (google auto-created) and my own service account i use in my application via json file)
The serviceaccount i use for the API is set up properly to be used (Vision API works). Since i changed the permissions around it didn't have any effect on the AutoML API.

@jdpedrie thanks for the help. I just figured out that somehow my service account almost got duplicated. With one or two characters different. And i was using the wrong one in the IAM interface..


Bug 1811695: Add missing optional tags

This is a cherry-pick of https://github.com/openshift/api/pull/511 onto 3.11 release.
/assign @sttts

@soltysh how clean was the cherry-pick?

@soltysh how clean was the cherry-pick?

The pick was clean but I can't run go1.10 locally :sweat: and that is required to get the formatting digestible by our CI.

/bugzilla refresh

/lgtm

/bugzilla refresh


Example code - Agent error

The example code is presenting the following error:
Example code:
import gym
import rsoccer_gym

# Using VSS Single Agent env
env = gym.make('VSS-v0')

env.reset()
# Run for 1 episode and print reward at the end
for i in range(1):
    done = False
    while not done:
        # Step using random actions
        action = env.action_space.sample()
        next_state, reward, done, _ = env.step(action)
        env.render()
    print(reward)

Error message:
Exception has occurred: ValueError
not enough values to unpack (expected 5, got 4)

Error line:
next_state, reward, done, _ = env.step(action)

Solution:
pip uninstall gym
pip install gym==0.21.0


RecurrenceRule: Respect leap months

This change makes a fix to Calendar.RecurrenceRule with regards to leap months and adds a few tests to verify correctness. When constructing the base sequence, we include isLeapMonth of the start date in the date components. Before, start dates falling on a leap month would have been treated the same as dates which do fall on the non-leap month before.

@swift-ci please run

@swift-ci please test

@swift-ci please test


Crash log

Game name: (please, specify the game name)
Engine version: 2019.4.14f1
Platform: StandaloneWin64Player
File name: unity default resources
Error message: Error during reading of asset type Material
Inner message: System.ArgumentException: 同一のキーを含む項目が既に追加されています。
 In the event that AssetRipper encounters issues while ripping your files, feel free to post an issue on that repository.
AssetRipper is actively being developed with the intent to recover games as best as possible. Weekly releases are normally on Sunday or Monday. I encourage you to help out if you're able and willing. Code contributions can be submitted via pull requests.
If you like the work I've done and want to see it continue, please consider sponsoring me. It really does help with development. These are some of the notable things I've implemented since taking over development:

2020+ support
APK, XAPK, and IPA reading with SharpZipLib
Dummy shaders (so everything isn't pink when you open the project)
IL2Cpp support via an integration of Cpp2IL
Better game platform support
Full script decompilation with the ILSpy decompiler
Cross-platform support
Multiple configuration options
Numerous performance improvements
Support for all asset types

Sponsorship Links:

GitHub Sponsors
Patreon
Paypal


adding my portfolio

adding my portfolio  by  following the contribution guidlines

Hi there!
I am the Mentor of this project .
Although this repo is not part of Hacktoberfest 2024, we have some great alternatives for you. Welcome to SkillShow, a repository focused on skill enhancement!
Guidelines:
Please adhere to the existing guidelines.
No additional rules, thanks!
Check it out here: SkillShow.
Note: Start by creating an issue. Once it’s assigned to you, feel free to open a pull request (PR). Directly opening a PR will lead to an invalid label.
Looking forward to your contributions!


Remove 5D tensor reshape in attention layer implementation.

Remove 5D tensor reshape in attention layer implementation.
test on TinyLlama result, which matchs the result before removing.
BUG=b/347108294

Great, have you tested if it works for the other models (phi2 and gemma)? we need to check if this change is correct for all types of attentions (MHA, MQA, GQA). Thanks!

Great, have you tested if it works for the other models (phi2 and gemma)? we need to check if this change is correct for all types of attentions (MHA, MQA, GQA). Thanks!

TinyLlama is GQA, so it should cover for MHA and MQA. Let me test on phi2 and gemma to confirm.

Great, have you tested if it works for the other models (phi2 and gemma)? we need to check if this change is correct for all types of attentions (MHA, MQA, GQA). Thanks!

TinyLlama is GQA, so it should cover for MHA and MQA. Let me test on phi2 and gemma to confirm.

Test on phi2 and Gemma, and the results match the ones before.


Update opentelemetry-exporter-jaeger, ... to 0.16.0

Updates

io.opentelemetry:opentelemetry-exporter-jaeger
io.opentelemetry:opentelemetry-exporter-otlp
io.opentelemetry:opentelemetry-proto
io.opentelemetry:opentelemetry-sdk

from 0.15.0 to 0.16.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.opentelemetry" } ]

labels: library-update, semver-minor

Lots of breaking changes again. Will fix them soon.


[BUG] No multi-instance launching button

Acknowledgement of preliminary instructions

[x] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
When I looked in the integrations menu, the "Multi-Instance launching" option is gone. (It does not launch multiple instances now)

same here multi instance got deleted

Yea same it's no longer there


Cannot add ngtoolkit/universal

I'm submitting a...

[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request

In package

[ ] @ng-toolkit/universal

Current behavior

INFO: Project property is set to 'rush'.
ERROR: Can't find decorator NgModule in ./src/app/app.server.module.ts
ERROR: If you think that this error shouldn't occur, please fill up bug report here: https://github.com/maciejtreder/ng-toolkit/issues/new
INFO: stacktrace has been sent to tracking system.
Nothing to be done.
Expected behavior

Minimal reproduction of the problem with instructions

Example repository

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 6.0.8
Node: 8.11.1
OS: win32 x64
Angular: 5.2.9
... common, compiler, compiler-cli, core, forms, http
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/animations               5.2.11
@angular/cdk                      5.2.4
@angular/cli                      6.0.8
@angular/flex-layout              5.0.0-beta.14
@angular/material                 5.2.4
@angular/platform-server          6.0.6
@angular/tsc-wrapped              4.4.7
@ngtools/json-schema              1.2.0
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
ng-packagr                        1.7.0
rxjs                              5.5.8
typescript                        2.4.2
webpack                           4.8.3

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

Hello. Could you provide me code of your project? GitHub? GitLab? Bitbucket? :)


Improvements of the GUI

Dear all,
First of all I wanted to thank you for your work that has revolutionized image analysis in biology.
I would like to suggest new features to improve the Cellpose GUI:

a correction tool that removes some of the pixels that are not necessary in the mask (like ALT + Click in QuPath)

A possibility to load a folder for training, and a second folder with validation data

A batch prediction though the GUI (like the serial cellpose napari)  (users sometime are scared by jupyter notebook)

Possibility to see during the training the training and validation curves

Possibility to check the QCmetrics like in ZeroCostDl4Mic
"""Calculate detection/instance segmentation metrics between ground truth and predicted label images.
Currently, the following metrics are implemented:
'fp', 'tp', 'fn', 'precision', 'recall', 'accuracy', 'f1', 'criterion', 'thresh', 'n_true', 'n_pred', 'mean_true_score', 'mean_matched_score', 'panoptic_quality'
Corresponding objects of y_true and y_pred are counted as true positives (tp), false positives (fp), and false negatives (fn)
whether their intersection over union (IoU) >= thresh (for criterion='iou', which can be changed)

mean_matched_score is the mean IoUs of matched true positives
mean_true_score is the mean IoUs of matched true positives but normalized by the total number of GT objects
panoptic_quality defined as in Eq. 1 of Kirillov et al. "Panoptic Segmentation", CVPR 2019
Parameters

An annotation tool in 3D with the possibility to load  a Z-stack and copy paste annotations
best,

Thanks Alex! The easiest of these is definitely number 2, and 3 is not too bad either. I like the idea of 4, but at least the user can inspect the command line for this info (so a workaround for now)
For 5 are you referring to the statistics on the validation set? we have all of these implemented in cellpose so we could return them.
For 6, we do in fact allow annotation in 3D, by turning off single stroke. If you press enter a 3D mask is drawn which can interpolate across planes which were not annotated. Was there something missing with this or was the documentation not very clear?

Dear Carsen,
regarding point 5, using the human-in-the-loop method can make it difficult for researchers to accurately measure detection accuracy. Utilizing QC metrics can present it in an objective manner.


how to dynamically hyperlink words

context - I've content in prismic, which already have words hyperlinked, but i want to hyperlink few more words as per SEO, how can i add it using htmlSerializer  ?
currently doing this, but it removes the previously hyperlinked words. any solution to resolve this?
const htmlSerializer = function (type, children, element, content, key) {
  switch (type) {
    case Elements.paragraph:
      let paragraphContent = children.text ? children.text : '';

      element.text = paragraphContent;
      keywords.map((s, idx) => {
        if (paragraphContent.includes(s.text)) {
          paragraphContent = paragraphContent.replace(s.text, `<a href=${s.link}>${s.text}</a>`);
        }
      });
       return
;

      default:
      return null;
  }
}

Hey @abhisheknaiidu, good question! Your HTML serializer generally looks good, but I think you could move the  replacements to Elements.span rather than Element.paragraph. Elements.span is the lowest level of the serializer; paragraphs, for example, will contain spans.
The reason you are seeing other hyperlinks being removed is because you are stopping the serializer from reaching the other Element types. This is due to not including children in your return type.
Here's an example you could try:
const htmlSerializer = function (type, children, element, content, key) {
  switch (type) {
    case Elements.span: {
      if (!content) {
        return null
      }

      // For each keyword, replace the keyword with a link.
      let contentWithSEOAnchors = content
      for (const keyword of keywords) {
        contentWithSEOAnchors.replace(
          keyword.text,
          `<a href="${keyword.link}">${keyword.text}</a>`,
        )
      }

      // For each new line (`\n`) in the content, replace it with a

      // This is done in the default HTML serializer and replicated here.
      const result = []
      contentWithSEOAnchors.split('\n').forEach((line, index) => {
        if (index > 0) {
          result.push(
)
        }

        result.push(line)
      })

      return result
    }

    default: {
      return null
    }
  }
}

thanks for replying, so with this I'm able to add the anchor tags to the content tho, but not able to split the function (\n) in the content, could you see this code . ⬇

function htmlSerializer(type, element, content, children, key) {
  switch (type) {
    case Elements.paragraph:
     return React.createElement('p', { className: 'paragraph-class' }, children);

    case Elements.span: {
      if (!content) {
        return null
      }

      // For each keyword, replace the keyword with a link.
      let contentWithSEOAnchors = content;
      // console.log(content)
      for (const keyword of keywords) {
        contentWithSEOAnchors = contentWithSEOAnchors.replace(
          keyword.text,
          `<a href="${keyword.link}">${keyword.text}</a>`,
        )
      }

     // not able to split
      const result = []
      contentWithSEOAnchors.split('/n').forEach((line, index) => {
        console.log(line, index)
        if (index > 0) {
          result.push(
)
        }

        result.push(line)
      })
      // console.log(result) thi

      return result
    }
    default:
      return null;
  }
};

@abhisheknaiidu Sorry, I didn't full test out that example serializer I posted. Could you try this one instead?
function htmlSerializer(type, element, content, children, key) {
  switch (element.type) {
    case Elements.paragraph:
      return (

          {children}

      );

    case Elements.span: {
      if (!content) {
        return null;
      }

      // For each keyword, replace the keyword with a link.
      let contentWithSEOAnchors = [content];
      for (const keyword of keywords) {
        contentWithSEOAnchors = contentWithSEOAnchors.map((contentSegment) => {
          if (typeof contentSegment === "string") {
            const result = [];

            contentSegment.split(keyword.text).forEach((segment, index) => {
              if (index > 0) {
                result.push(
                  <a key={`br-${index}`} href={keyword.link}>
                    {keyword.text}

                );
              }

              result.push(
                <React.Fragment key={index}>{segment}</React.Fragment>
              );
            });

            return result.flat();
          } else {
            return contentSegment;
          }
        });
      }

      // For each new line (`\n`) in the content, replace it with a

      // This is done in the default HTML serializer and replicated here.
      const result = [];
      contentWithSEOAnchors.flat().forEach((segment) => {
        if (typeof segment === "string") {
          segment.split("\n").forEach((line, index) => {
            if (index > 0) {
              result.push(<br key={`br-${index}`} />);
            }

            result.push(<React.Fragment key={index}>{line}</React.Fragment>);
          });
        } else {
          result.push(segment);
        }
      });

      return result;
    }
    default:
      return null;
  }
}

Hey @abhisheknaiidu, I'm going to close this issue but please feel free to comment if you haven't been able to get this working.
Thanks!


feat: info if elvis operator is unnecessary

Closes partially #543
Summary of Changes
Show an info if an elvis operator can be removed.

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


bug: Hangs on large ppem (control-p) value

Press control-P to open the PPEM dialog box. Entering a stupidly large number in it will cause ygt to hang.  It probably just needs an input validation to confine input range to something reasonable.  I'm using Windows 11, python 3.11.x in case that matters.

First of all, thanks for all the bug reports and feature requests. These are mostly on my to-do list (and I'll comment and close as I deal with them), except for this one. How big a value do you have to enter to hang the program? When I put in 500 ppem, it takes several seconds to generate the image--I suppose just because we're dealing with Python here and not C. If you put in, say, 10,000 ppem, it could easily take a minute or more.
It's pretty common to cut off hinting at 200 ppem. I could allow only up to, say, 400 ppem or whereever the user cuts off hinting, whichever is higher.

The values I entered were 1200 and 2400. It may have just been processing, not hung, and I wasn't waiting long enough. I believe I waited about 10-15 seconds before killing it. I'll play with it more. 400 seems reasonable (famous last words).


Rendering issues with empty select TextFields

There seem to be a couple of problems with empty text fields, used as a select control.
Labels, overlapping and occasionally empty fields not being the right height

[X] This is not a v0.x issue.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Form labels should not overlap content.
Empty select
Current Behavior 😯
Form labels overlap content
Steps to Reproduce 🕹

Link: https://codesandbox.io/s/material-demo-ijnqr

See initial rendering issues
On field Native select initial Empty choose the value Null
Observe effect on field Select initial Empty - the height of field is incorrect.
On field Native select null choose the value Empty
On field Native select null choose the value Null
Observe effect on field Select null - the height of the field is incorrect.

Your Environment 🌎

Tech
Version

Material-UI
v4.0.1

React
16.8

Browser
Chrome / Safari 12.1.1 / IE 11

@SpudNyk A few of the patterns raise a prop types warnings, the other are a limitation of the component, the documentation works around it with the shrink prop.


Hidden bills and events raise Internal Server Error, rather than Page Not Found

The Metro Councilmatic database includes private bills (marked with "restrict_view=True") and test events. Trying to access one of these entries raises an Internal Server Error.
Example of bill
Example of event
It would be better to handle this more gracefully, i.e., with a Page Not Found (404).
I'd classify this as a very low priority issue.

I had to fix this issue on another app this morning! The problem was that I put my 404.html and 500.html templates in a directory like templates/app_name/404.html, but I needed to tell Django to look for them there by adding templates/app_name to my TEMPLATES > DIRS setting: https://github.com/confluency/stormstore-app/blob/master/stormstore_app/settings.py#L94
Maybe that's at play here?

@fatima3558 Update: I don't think my original comment is the problem, as our 404 page does work sometimes, e.g., #747. Let's deprioritize this, for now, and if it stays in the backlog after our meetings next week, let's pair on getting the app running with DEBUG = False and louder logging so you can test locally!


request.get_json() always returning None even though I followed exact instructions

All POST requests do not work anymore. Everything worked fine a month ago, and now it doesn't. Code has not changed, instructions have been followed exactly to the letter.

@zmpeterson86 I tried POST-ing new transaction. Works for me:
curl -X POST -H "Content-Type:application/json" -d '{"amount": 1, "recipient": "9e3546b87ab9433ea934d9b70d7467af", "sender": "0"}' "http://localhost:5000/transactions/new"
{
  "message": "Transaction will be added to Block 2"
}

@zmpeterson86 Can you provide details? Error messages?

Are you using get_json(force = True)?

I was only able to get it to work using force = True. I copied your code and tried it, I always get a 500 server error

Hm, that's strange.
Maybe it's flask and requests version. I'm using the latest versions, not those specified in the tutorial.

Now it is not working with either method.

I haven't changed these parts of the code and I have not updated flask or python.

This has worked reliably since I rolled back to a previous version of postman and used get_json(force=True)

Did you update your request module? I once had the same issue on an API I was working on and I had to go through my commits to see what the problem was. (Problems of using virtual env wrapper for all your projects).
Solved it by downgrading it to some older version, can't really recall but I think it was 2.10, the request module contributors claimed that it was due to security issues that they made the changes. Still, I have no clue of using the new module though.

I downgraded requests to 2.10 and works fine now.
Darmut

I had a similar problem on Python 3.8 which was fixed by upgrading Flash and Requests to the newest version.

If you change the format of your POST data in Postman, instead of Text (is pre selected) you select JSON it works fine

If you change the format of your POST data in Postman, instead of Text (is pre selected) you select JSON it works fine

Thank you! that was it

Try to set force attribute as True in get_json() method to resolve this issue.
request.get_json(force = True)

In my case the reason was that my json file had format: {'name': 'John'}. But then I found error that says "Expecting property name enclosed in double quotes". So I changed json file to {"name": "John"} and it worked.


Iteration on Capacity Utilization page

Update of the capacity utilization pages following a feature update.

@Mattp123 here's a documentation update PR. Let me know if it needs redesign, if not please feel free to merge it :)

Hello @tapanm-MSFT @Mattp123,
I have recently made changes to the Capacity Utilization page documentation as we release in the next few days a feature update. Could you please let me know if the content I inserted needs change ? If not please merge the PR when you can :)
Camille


Updated README.md

Issue: #7
Following features added

Made the heading in center
Added Badges in the readme file
Added features of the calculator
Added a tutorial in form of a GIF

Please feel free to interrupt me if you need any further modification.
Thank you very much.

As you can see in this article: https://gist.github.com/seanh/13a93686bf4c2cb16e658b3cf96807f2
and in many more, using html tags in markdown files is valid and also recommended in some cases.
I have intentionally used html tags, because they provide many more functionalities than the markdown.
But if you still want, I can remove the html tags,
please reply, what should I do


Fix trade button state

We fixed an issue where it was not indicated when the user accepted a trade:

Thank you :)


organization: icons: modal

re: #11009
adds a modal dialog to the icon picker in the organization settings view, as explained this would need to be redone for editor3 THIS IS A HACK
currently I extracted iconpicker from https://github.com/CartoDB/cartodb/pull/11292, and made a instance of it, also added a modal with the whole collection and another instance of the icon picker. Ideally they should share the same collection and not rely on global events to refresh.
I omitted the dropbox tab, and other collections tabs, as well as the upload and loading panes from https://github.com/CartoDB/design/issues/352 (see attached) in order to keep consistency and prevent bugs, nevertheless these would need to be implemented in the new version /cc @urbanphes @javierarce

finally, I tackled cartodb folder in the "pluggable frontends" at this same time https://github.com/CartoDB/cartodb/issues/11176

actually removed that unused css code (it was necessary at first for a different approach)
also, made the tests pass (shame on me for not doing this in the first place) and simplified a bit the icon picker dialog

re-test this please

retest this please

A couple of things seen in acceptance:

When selecting / deselecting icons, the list moves up / down like 1 or 2 pixels. Noticeable.

While the list is doing an operation (uploading / deleting) the others links in the page remain active. So you can open again the file selector or close the dialog via the X icon while there's an operation running. Should we disable any action?

cc @xavijam

Let's fix it.
I feel we should disable any action until the first "process" has finished. IMO.

Made a quick fix to recover the organization users tab. It dissapeared because refactors made in this PR.

CR 👍

Acceptance passing, also tested the last minor fixes @ivanmalagon reported.


Fix mozilla/thimble.webmaker.org#1340 - Fix regression caused by 305fb22 which forgets scroll position

@humphd r?

r=me

ty


room-avatar named slot

Hi,
although currently the room-header-info make me possible to open a user profile model when click room name, but it makes more sense to open the model when click the room avatar (plus room name). But it seems that there is no room avatar slot, i just want to add the   wrap the room avatar picture. thanks.

You can use roomInfo event

roomInfo event triggered when whole head bar is clicked, not just the room avatar.

Ok, I can add a room-avatar slot

thx, as it's quite annoying when i accidentally click the head bar, a modal popup, even i meant to click the menu action dots

Fixed https://github.com/antoine92190/vue-advanced-chat/commit/e5a548f7b0e9431d3f33e56e53d4ed7eb04be713


docs(Responsive): deprecate component

⚠ Deprecation
This PR marks Responsive as deprecated, we will remove it in the next major release, i.e. 2.0.0.
Fixes #4002.
❓ Why?
We did with this component two design mistakes 🚒
💅 Not CSS origin
This component does not have connection between Semantic UI CSS and our implementation. This causes mismatch our defined breakpoints (https://semantic-ui.com/elements/container.html) in CSS and JS part.
⚙ SSR support
With previous item it's possible to survive, but this item is really annoying as SSR and SSG are popular and provide great experience (Next.js, Gatsby). Numerous issues without simple solution is a sign of this failure (#3110, #3398, #3948, #4002).
➡ How to migrate?
In our example (HomepageLayout) I made a switch to @artsy/fresnel. These changes are part of this PR.
This package was chosen as a suggested replacement as it works great with Next.js & Gatsby (https://github.com/artsy/fresnel#usage-with-gatsby-or-next) and it does not use conditional rendering (https://github.com/artsy/fresnel#why-not-conditionally-render).
Before
import React from "react";
import { Responsive, Segment } from "semantic-ui-react";

const App = () => (
  <Segment.Group>
    <Responsive as={Segment} {...Responsive.onlyMobile}>
      Mobile
    </Responsive>
    <Responsive as={Segment} {...Responsive.onlyTablet}>
      Tablet
    </Responsive>
    <Responsive as={Segment} {...Responsive.onlyComputer}>
      Computer
    </Responsive>
    <Responsive as={Segment} {...Responsive.onlyLargeScreen}>
      Large Screen
    </Responsive>
    <Responsive as={Segment} {...Responsive.onlyWidescreen}>
      Widescreen
    </Responsive>
  </Segment.Group>
);

After
import { createMedia } from "@artsy/fresnel";
import React from "react";
import { Segment } from "semantic-ui-react";

const AppMedia = createMedia({
  breakpoints: {
    mobile: 320,
    tablet: 768,
    computer: 992,
    largeScreen: 1200,
    widescreen: 1920
  }
});

const mediaStyles = AppMedia.createMediaStyle();
const { Media, MediaContextProvider } = AppMedia;

const App = () => (
  <>
    <style>{mediaStyles}</style>
    <MediaContextProvider>
      <Segment.Group>
        <Segment as={Media} at="mobile">
          Mobile
        </Segment>
        <Segment as={Media} at="tablet">
          Tablet
        </Segment>
        <Segment as={Media} greaterThanOrEqual="computer">
          Computer
        </Segment>
        <Segment as={Media} at="largeScreen">
          Large Screen
        </Segment>
        <Segment as={Media} at="widescreen">
          Widescreen
        </Segment>
      </Segment.Group>
    </MediaContextProvider>
  </>
);

Examples
Preconfigured examples on CodeSandbox:

Create React App - https://codesandbox.io/s/semantic-ui-react-usage-of-artsyfresnel-f2wo9
Gatsby - https://codesandbox.io/s/semantic-ui-react-gatsby-artsyfresnel-ws5g1
Next.js - https://codesandbox.io/s/semantic-ui-react-and-artsyfresnel-26qe5

All of them can be deployed to Vercel for verification.

Codecov Report

Merging #4008 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4008   +/-   ##
=======================================
  Coverage   99.84%   99.84%
=======================================
  Files         184      184
  Lines        3233     3233
=======================================
  Hits         3228     3228
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28eee26...abed783. Read the comment docs.

I'm not sure its important: The code in after is incorrect: It still use Responsive while I believe it should be using Media?
I think also the docs should have a gentle reminder that it might not be the best solution to put the entire page under conditional render like the home page example does because it might end up duplicating data when using SSR.

@sveinse I update PR description (final version) & add a comment to HomepageLayout. Please check one more time 🐱

@layershifter looks good ✔. I've tested the after example successfully and I've glanced at the PR commit. Looks good from my humble eyes.

This might be obvious to other people, but I struggled with using the above examples with the <Button> component. Looking at the <Media> component, it always renders a div and only uses the className prop. As I was using the href prop it was producing buttons which didn't work.
To fix this I used the render-props option they document here: https://github.com/artsy/fresnel#media.
Even then it's not perfect as my responsive buttons don't neatly sit in button groups any more (as the :first and :last css selectors don't consider elements that are present but hidden), but it does at least work

This might be obvious to other people, but I struggled with using the above examples with the  component.

@charliematters There is no obvious things, thanks for rising this 👍
If you are not using SSR/SSG
<Button.Group>
  <Media at="mobile">
    {(mediaClassNames, renderChildren) => {
      return renderChildren ? <Button>Hello mobile!</Button> : null;
    }}
  </Media>
  <Button>Always</Button>
  <Media greaterThan="mobile">
    {(mediaClassNames, renderChildren) => {
      return renderChildren ? <Button>Hello desktop!</Button> : null;
    }}
  </Media>
</Button.Group>

<div class="ui buttons">
  <button class="ui button">Hello mobile!</button
  ><button class="ui button">Always</button>
</div>

This code will do exactly the same thing as Responsive component previously: borders will look properly due conditional rendering.
If you're using SSR/SSG
If you're using Next.js/Gatsby/other tool and will try to use the code above you will get this warning:
Warning: Text content did not match. Server: "Hello mobile!" Client: "Always"

Even then it's not perfect as my responsive buttons don't neatly sit in button groups any more (as the :first and :last css selectors don't consider elements that are present but hidden), but it does at least work

And this is correct, styling that is built with :last/:first does not play well with SSR and responsiveness. To avoid this warning I propose to use NoSSR and the responsive block in this case will be rendered only on client:

<NoSSR>
  <Button.Group>
    <Media at="mobile">
      {(mediaClassNames, renderChildren) => {
        return renderChildren ? <Button>Hello mobile!</Button> : null;
      }}
    </Media>
    <Button>Always</Button>
    <Media greaterThan="mobile">
      {(mediaClassNames, renderChildren) => {
        return renderChildren ? <Button>Hello desktop!</Button> : null;
      }}
    </Media>
  </Button.Group>
</NoSSR>

https://codesandbox.io/s/semantic-ui-react-and-artsyfresnel-forked-uluj1?file=/pages/index.js

Hi @layershifter ,
How can I implement responsive design for the iPad Pro Portrait/Landscape?

Hi @layershifter ,
How can I implement responsive design for the iPad Pro Portrait/Landscape?

@gb9box It's not related to this change actually... You can use interactions option in createMedia() in @artsy/fresnel.

@gb9box It's not related to this change actually... You can use interactions option in createMedia() in @artsy/fresnel.


Getting "expected element  in name space http://schemas.openxmlformats.org/spreadsheetml/2006/main but have no name space" FileOpen and SaveAs afterwards

Description
Hi! We have a problem with reading a file with Excelize, after making a copy of it with Excelize — we are getting expected element <workbook> in name space http://schemas.openxmlformats.org/spreadsheetml/2006/main but have no name space error. Detailed description below.
Steps to reproduce the issue:
Step zero:
We have a file generated by .NET solution https://github.com/ClosedXML/ClosedXML. Here is an example file (in our exact case it is much bigger, but that's doesn't matter here) - original2.xlsx. This file can be opened fine with Numbers.app, version 11.1 (7031.0.102) on macOS 14.2.1 (23C71).
Step one:
We have a small debug app to pinpoint the bug:
package main

import (
	"log"

	"github.com/xuri/excelize/v2"
)

func main() {
	f, openFileErr := excelize.OpenFile("original2.xlsx")
	if openFileErr != nil {
		log.Fatalf("OpenFile initial: %v", openFileErr)
	}

	if saveAsErr := f.SaveAs("corrupted.xlsx"); saveAsErr != nil {
		log.Fatalf("SaveAs: %v", openFileErr)
	}

	if closeErr := f.Close(); closeErr != nil {
		log.Fatalf("SaveAs: %v", openFileErr)
	}

	_, openFileAgainErr := excelize.OpenFile("corrupted.xlsx")
	if openFileAgainErr != nil {
		log.Fatalf("OpenFile again: %v", openFileAgainErr)
	}
}

If we run it we'll get an error:
2024/04/26 00:00:01 OpenFile again: expected element <workbook> in name space http://schemas.openxmlformats.org/spreadsheetml/2006/main but have no name space
exit status 1

Numbers.app also failing to open it:

Describe the results you received:
expected element <workbook> in name space http://schemas.openxmlformats.org/spreadsheetml/2006/main but have no name space
Describe the results you expected:
File opened without errors.
Output of go version:
go version go1.22.0 darwin/arm64

Excelize version or commit ID:
v2.8.2-0.20240425162310-055349d8a62e

Investingation:
Interesting thing, that this original2.xlsx has xl/workbook.xml with pretty interesting xmlns (providing only the very beginning of it, also formatted for the sake of readability):
<?xml version="1.0" encoding="utf-8"?>
<x:workbook xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships"
  xmlns:x="http://schemas.openxmlformats.org/spreadsheetml/2006/main">
  <x:workbookPr codeName="ThisWorkbook" />
  <x:bookViews>
    <x:workbookView firstSheet="0" activeTab="0" />
  </x:bookViews>

So we have requires NS http://schemas.openxmlformats.org/spreadsheetml/2006/main but it is prefixed with x, so do all elements in file.
And after the saving this XML becomes this one (again, providing only the very beginning of it, also formatted for the sake of readability):
<?xml version="1.0" encoding="UTF-8"?>
<workbook xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships"
  xmlns:x="http://schemas.openxmlformats.org/spreadsheetml/2006/main">
  <workbookPr codeName="ThisWorkbook"></workbookPr>
  <bookViews>
    <workbookView></workbookView>
  </bookViews>

Do you see have we still have or xmlns:x but all our elements have no such prefix? And there is no any sign of xmlns without prefix. That was my first though and I've decided to look at the part were Excelize saving the xl/workbook.xml.
And I found this part:
https://github.com/qax-os/excelize/blob/055349d8a62e6b4e66bcf3854c8a9086e912c409/workbook.go#L227-L229
which lead me to
https://github.com/qax-os/excelize/blob/055349d8a62e6b4e66bcf3854c8a9086e912c409/lib.go#L685-L692
replaceNameSpaceBytes in this case replaced usual xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" (which came from the XMLName field of the workbook structure) with original to namespaces, BUT we are also using the x prefixes in all elements. And that, as far as I understand, causes the errors.
I tried to remove part with finding the targetXmlns
	if attrs, ok := f.xmlAttr.Load(path); ok {
		targetXmlns = []byte(genXMLNamespace(attrs.([]xml.Attr)))
	}

and after that file started to open perfectly fine. Yes xl/workbook.xml will look awful, as it will have all possible XMLNs from the constant, but it works… But I still not sure if this is a proper fix.
Possible fix:
We probably need to always add xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main", unless it is already there. But that's just an idea, maybe you have a better solution for that.

@xuri can you take a peek on this one, really messes our system right now. Thank you in advance!

Thanks for your issue. I have fixed this, please upgrade to the master branch code, and this patch will be released in the next version. Note that, this library can't guarantee compatibility with workbooks generated by any third-party libraries and tools.


datastore: update maxIndexedProperties from 5000 to 20000

The datastore package is currently enforcing a limit of 5,000 indexed properties for entities. Unless Cloud Datastore differs from the App Engine Datastore in some subtle way, that limit was increased to 20,000 indexed properties several years ago.
When I brought up the issue on the appengine-go mailing list a few months ago, @gmlewis kindly made this commit on the golang/appengine repo. It would be great if the change could be applied on this repo too. Cheers! 🍻

@okdave I wonder why we're checking this in the client at all. If this is a server limit, let the server enforce it.

@tav interesting that you refer to a Python-specific doc and not one for the service in general. I can't find that limit in the service doc. The limits page doesn't mention it.
Not denying it exists, I just wish I could find it.

I've confirmed that this limit increase happened to Cloud datastore as well.
We don't accept pull requests on this repo, but I made the corresponding change at https://code-review.googlesource.com/#/c/5120.

Thanks for making the change @jba 👍
As to the lack of documentation, despite following App Engine changes pretty religiously, I only found out about the limit change by complete accident on a Stack Overflow comment! It's a general problem with the Google Cloud platform, but the situation has at least been improving in recent years.
In any case, is there a reason that changes aren't applied to both datastore packages simultaneously? For example, the appengine/datastore version has a ByteString type which is useful for indexed byte slices. But builtin support for that is missing from the gcloud datastore package. Is there a reason for these discrepancies?

They're separate pieces of code, maintained separately. We'll get better at aligning them.
File an issue about ByteString and anything else you miss from appengine/datastore.

@tav in the case of ByteString, that's an unfortunate wart in the appengine version of the package which we've been able to avoid here. In appengine/datastore, originally all []byte default to noindex and we couldn't go back and change that behaviour retroactively – this meant we needed to introduce ByteString as a way of expressing an indexable byte slice. In this package, we never defaulted []byte to noindex so the basic type can cover all use cases.

Thanks for pointing that out @okdave. I'd missed that difference — might be worth highlighting it for other users of appengine/datastore who are switching to gcloud/datastore. It's definitely a lot better this way. Cheers!


DomException is not an Object according to dartjs under NNBD

Take the following program:
main() {
  try {
    window.crypto.getRandomValues(Float32List(100));
  } on Object catch (e) {
    print("Caught Object");
  } catch (e) {
    print("Not Object?! $e");
  }
}

Compile it with dart2js as opted in to NNBD and run it in a browser. I would expect the first catch clause to capture the exception, but it does not. Instead, the second clause is the one that gets the thrown DomException.

Should be fixed by 7ac53f182561a35ad932f39f1183988bb23ef1ff.


The subnet does not conform to the Network Security Group (NSG) requirements during the creation of the virtual network (VNet).

We are attempting to deploy Zero Trust Architecture (ZTA) for one of our customers. However, the subnet being created as part of the deployment is not associated with a Network Security Group (NSG), causing the deployment to fail. Please refer to the attached error message for more details.

Hi @placerda @gbecerra1982 please advise.

Fixed:
https://github.com/Azure/GPT-RAG/pull/217


CS Audit, Lime 174, Improved documentation

Description
In AaveYield.sol
• The specification for the unlockShares refers to the asset as the underlying token, but the code assumes to be the Aave token.
• In _withdrawETH the comment lock collateral is incorrect.
Change Log
Erroneous documentation were corrected.
Function Signature Change
The function signature for function unlockShares was changed from
function unlockShares(address asset, uint256 amount) external returns (uint256 received);

to
function unlockShares(address asset, uint256 amount) external returns (uint256 received, address tokenReceived);

Codecov Report

Merging #260 (86e0b63) into v1-alpha (6dc2001) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           v1-alpha     #260      +/-   ##
============================================
- Coverage     39.06%   38.99%   -0.07%
============================================
  Files            16       16
  Lines          1705     1708       +3
  Branches        290      290
============================================
  Hits            666      666
- Misses         1039     1042       +3

Impacted Files
Coverage Δ

contracts/SavingsAccount/SavingsAccount.sol
27.64% <0.00%> (+0.44%)
:arrow_up:

contracts/yield/AaveYield.sol
19.38% <0.00%> (-0.20%)
:arrow_down:

contracts/yield/CompoundYield.sol
48.68% <0.00%> (-1.32%)
:arrow_down:

contracts/yield/NoYield.sol
24.39% <0.00%> (-0.61%)
:arrow_down:

contracts/yield/YearnYield.sol
13.33% <0.00%> (-0.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc2001...86e0b63. Read the comment docs.


fixed yup schema to not allow null

Oops...

Schema are non nullable by default.

https://github.com/jquense/yup#schemanonnullable-schema


Organization

estatic has a lot of branching in it. It'd be nice to manage this "better".

I reorganized a little bit, and I feel better about it.


Update references to rtyler/jenkins

Pull Request (PR) description
Updates module name references from rtyler/jenkins to puppet/jenkins in the README.
This Pull Request (PR) fixes the following issues
Fixes #934

Thank you!

womp womp


intervalstyle session variable is now supported for PostgreSQL compatibility

PR: https://github.com/cockroachdb/cockroach/pull/20274

Need to add this new session variable to SET (session variable) and SHOW (session variable)


Swipeable tab: list view accordion is not displaying properly

This is a (multiple allowed):

[x] bug
[x] enhancement
[ ] feature-discussion (RFC)
Framework7 Version: Framework7 v1.4.2 - Updated on February 27, 2016
Platform and Target: CORDOVA, IOS.

What you did
There are 2 tabs (swipeable). Both Tab1 (containing simple text) and Tab2 (containing accordion list) are seperate view which is rendered once that view's tab gets active.
There are 2 ways to go to Tab2  : 1) On click, 2) On swipe
On click, everything works perfectly fine but on swipe the accordion list of Tab2 is displayed half (which occurs randomly)
Expected Behavior
On tab swipe, the accordion shall be displayed properly i.e. all "item-title" of list needs to be displayed.
Actual Behavior

On tab swipe, Randomly some "item-title" will be missing, which will be displayed only if clicked on one of the accordion item. Sometimes it comes properly but if continuously swiped to and fro, the above issue can be seen.
On Tab2 click, everything is rendered properly.

NOTE : Same code has been used for android (CORDOVA) and it works perfectly fine.
Please help me  to fix this issue as soon as possible.

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Framework7, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


[LeftNav] swipeable only from the far left (or right) area of the page

Closes #1384.
Only swipe open the LeftNav from far left or far right.

@oliviertassinari Please check again.

@subjectix Thanks :+1:

Thank you ^.^


Short solution needed: "Get table length" (lua)

Please help us write most modern and shortest code solution for this issue:
Get table length (technology: lua)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Get table length


Cannot use TensorArray with tf.scan

I seem to be unable to use TensorArrays with tf.scan. I am running 0.10.0rc0 on Ubuntu 14.04 with Cuda Toolkit 7.5 and cuDNN v4.
Here is a minimal example:
import tensorflow as tf

array = tf.TensorArray(tf.float32, size=10)
elements = list(range(10))

def step(state, current_input):
    return state.write(current_input, tf.zeros(shape=[100]))

out = tf.scan(step, elements, initializer=array)

with tf.Session() as sess:
    sess.run(tf.initialize_all_variables())
    print(sess.run(out))

And the output is:
Traceback (most recent call last):
  File "array_test.py", line 9, in <module>
    out = tf.scan(step, elements, initializer=array)
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/ops/functional_ops.py", line 521, in scan
    a_flat = [ops.convert_to_tensor(init) for init in initializer_flat]
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/ops/functional_ops.py", line 521, in <listcomp>
    a_flat = [ops.convert_to_tensor(init) for init in initializer_flat]
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/framework/ops.py", line 628, in convert_to_tensor
    ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/framework/constant_op.py", line 180, in _constant_tensor_conversion_function
    return constant(v, dtype=dtype, name=name)
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/framework/constant_op.py", line 163, in constant
    tensor_util.make_tensor_proto(value, dtype=dtype, shape=shape))
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/framework/tensor_util.py", line 422, in make_tensor_proto
    tensor_proto.string_val.extend([compat.as_bytes(x) for x in proto_values])
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/framework/tensor_util.py", line 422, in <listcomp>
    tensor_proto.string_val.extend([compat.as_bytes(x) for x in proto_values])
  File "/usr/local/lib/python3.4/dist-packages/tensorflow/python/util/compat.py", line 45, in as_bytes
    (bytes_or_text,))
TypeError: Expected binary or unicode string, got <tensorflow.python.ops.tensor_array_ops.TensorArray object at 0x7ff0db9309e8>

@ebrevdo can correct / expand as necessary
Thanks @jeanm for filing this issue!  I can indeed reproduce the output.
I believe the purpose of TensorArray is to implement dynamic iteration primitives - e.g. scan is implemented using TensorArray:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/functional_ops.py#L506
I'm not sure whether TensorArray is itself meant to be used as you are doing.  For the simple example program above, obviously a regular tensor should be sufficient.
Can you expand a bit on what problem you're actually trying to solve?  Or were you just playing around with things?

Thanks for the quick response @tatatodd

Can you expand a bit on what problem you're actually trying to solve? Or were you just playing around with things?

I am implementing an RNN which, at time t, may need to access not just the output at t-1 but also outputs from earlier time steps. That's why I'd like to pass around a TensorArray and update it as I go along. In #2237 there are several examples of RNNs of this kind, such as this simple Tree-RNN by @lukasr0.
I can emulate a scan by using tf.while_loop instead, like in the linked Tree-RNN example, but it's a bit cumbersome and it doesn't seem to be very efficient.

Please see the new tf.nn.raw_rnn, which allows you to keep an arbitrary list of tensors and TensorArrays in the loop_state, as passed through loop_fn.
You can write the rnn output state to your loop state.

Thanks, that seems like a better solution.


Update aws-java-sdk-bundle to 1.12.517

About this PR
📦 Updates com.amazonaws:aws-java-sdk-bundle from 1.12.510 to 1.12.517
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #2814.


NullPointerExceptionTest

Added NullPointerExceptionTest running purposefully null ridden specs against all rules

Based on some full-featured specs, progressively pruned

Fixed various NullPointerExceptions

#832

Codecov Report

Merging #867 into master will increase coverage by 0.45%.
The diff coverage is 48.64%.

@@             Coverage Diff              @@
##             master     #867      +/-   ##
============================================
+ Coverage     85.36%   85.82%   +0.45%
- Complexity      932      963      +31
============================================
  Files           172      172
  Lines          2590     2589       -1
  Branches        403      413      +10
============================================
+ Hits           2211     2222      +11
  Misses          151      151
+ Partials        228      216      -12

Impacted Files
Coverage Δ
Complexity Δ

...o/zally/rule/zalando/PluralizeResourceNamesRule.kt
100% <ø> (ø)
15 <0> (ø)
:arrow_down:

...e/zalando/zally/rule/zalando/NoVersionInUriRule.kt
70% <0%> (-10%)
11 <0> (+1)

...o/zally/rule/zalando/UseStandardHttpStatusCodes.kt
80.76% <0%> (ø)
9 <0> (ø)
:arrow_down:

...zally/rule/zalando/Use429HeaderForRateLimitRule.kt
75% <0%> (-12.5%)
6 <4> (ø)

...va/de/zalando/zally/rule/zalando/MediaTypesRule.kt
80% <0%> (+10%)
5 <0> (ø)
:arrow_down:

...e/zalando/zally/rule/zalando/UseProblemJsonRule.kt
87.09% <100%> (+6.45%)
19 <0> (+4)
:arrow_up:

.../main/java/de/zalando/zally/util/ast/ReverseAst.kt
85% <100%> (ø)
20 <3> (+1)
:arrow_up:

...rule/zalando/QueryParameterCollectionFormatRule.kt
88.88% <100%> (+11.11%)
12 <0> (+4)
:arrow_up:

...lando/zally/rule/zalando/ProprietaryHeadersRule.kt
81.81% <100%> (+4.54%)
27 <0> (+5)
:arrow_up:

...zalando/zally/rule/zalando/SecureWithOAuth2Rule.kt
76.19% <100%> (+4.76%)
23 <0> (+2)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3717ba4...3b9074f. Read the comment docs.

Might be a rhetorical question ... but was there no other way to fix that than making that much stuff nullable...?

Might be a rhetorical question ... but was there no other way to fix that than making that much stuff nullable...?

Arguably it was already nullable, Kotlin just didn't realise it.
Clearly there is an alternate approach where we post-process the model and replace nulls with "empty values", either by handcoding a crawl of the model or by enhancing/copying the ReverseAst to do so automatically. For many cases an "empty value" object exists which could be used e.g. PathItem, ApiResponses but I'm not sure that always makes sense - e.g. is it acceptable to replace null Strings with ""? What about null Booleans?

Checking for empty value or for null both require an extra effort. At that point, I am OK with using nullability (which is nicely supported in Kotlin). Thanks for the explanation.

👍

:+1:


Markdown Context Variables

Add the ability to specify a Jinja variable that will render from the pages context. the context should be setup to pull from the database for use.

added 1m of time spent

marked this issue as related to #10


gyp requires Python 2.6 but Ubuntu 14.04 comes with 2.7

Document the problem (http://stackoverflow.com/questions/21155922/error-installing-node-gyp-on-ubuntu) and suggest a solution (use a Python version manager eg pyenv)

I'm going through old PRs to see if they can be salvaged or closed. I believe that the version of gyp that Atom uses now works with Python v2.7. Is this PR necessary anymore?

Since gyp uses Python 2.7 now, this shouldn't be necessary any longer.


noVNC images for access via a browser

Currently our demo's are limited to console only. However, using noVNC we can create a Docker based version with access to an X11 server. This will allow us to provide full access to the world of GUI environments with no setup required by the user.
As an example run docker run -d -p 5901:5901 -p 8080:6901 consol/ubuntu-xfce-vnc and then hit http://YOUR_DOCKER_HOST:8080/?password=vncpassword
This image does not include the AZ CLI or SimDem, but you get the idea...

I've made some experimental progress...
git pull
git checkout xterm
docker build -t rgardler/simdem:xterm
docker run -d -p 5901:5901 -p 8080:6901 --name simdem_xterm rgardler/simdem:xterm
http://YOUR_DOCKER_HOST:8080/?password=vncpassword

Now open a terminal in the UI and type simdem test test
ToDo:

[ ] Test all demo_scripts
[ ] Install AZ CLI in the Dockerfile
[ ] Test all acs-demos scripts
[ ] Update documentation

Tracking this item in https://github.com/rgardler/simdem/projects/1

PR #30 is now code complete, but testing is needed.


Function to load reference samples from google earth engine

We are now auto-publishing all reference isotopes to earth engine and this function loads the data into a dataframe for further manipulation (data validation, partitioning, etc).
@erickzul How did you create the canonical data sets for training, validation and test?  I assume this is a variation of partition(x).  Once I have that I can update XGB to grab EE, partition and create the isoscape.

In gee_datasource_test.ipynb, where is the 1000 number coming from?

That is the current count from earth engine. I am assuming that number should only increase.  I did not want to verify any specific contents because that would leak information.


HostAndPort not serializable in latest Maven dependency 2.7.3

This causes issues with Storm deployments.
I see that serializing is already implemented in GitHub.
Thus, could you please build the latest code as Maven dependency.

@mtaivalj we'll be releasing 2.8 shortly. We've been busy with other stuff in the meanwhile.
You can go ahead and build the 2.8 branch if you want as it will be the same codebase as the one that's going to be released.


fix typo in quassel readme

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test
/lgtm

/assign @mgoodness

/assign timstoop


recolor riot helmet

resolves #31256
match riot helmet to default security helmet
First-ever attempt at spriting for SS14 so I'd like any potential approver to take a close look at it, but this was a pretty straightforward color replacement.

About the PR
Recolors the riot helmet to match default security helmet colors.
Why / Balance
Resolves issue #31256
Technical details
N/A
Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Riot helmet now matches security helmet colors.

Looks fine, but front and back equipped sprites is inconsistent to the og sec helm sprites. Also, please edit the meta.json at the end to say something along the lines of “colour tweaked by saintmuntzer”.

Thanks, I'll make those changes later today or tomorrow.


Resolve "Add Support For PanixBuild 3.2.0"

Close #279
Planning on attempting to resolve #277

I'll make sure to update the wiki with X11 forwarding instructions after this.


Small designs need PL_BASIC_PLACEMENT

Description
Referring to the discussion here:
https://github.com/The-OpenROAD-Project/OpenLane/issues/1183
Many small designs need PL_BASIC_PLACEMENT, or they fail at global placement. However setting it to one is a big performance detrement to almost all other designs.
Here's a list of designs that need the option:
https://github.com/TinyTapeout/tt02-test-invert
https://github.com/argunda/tt02-TinyPFD
https://github.com/13arn/tt02_counter_steamdeck
https://github.com/NYIT-CNS/cns001-tt02-submission1
https://github.com/shaos/tt02-submission-shaos
https://github.com/mole99/tt02-1bit-alu
https://github.com/jglim/tt02-bcd-7seg
https://github.com/mmolteni-secpat/tinytapeout02_chi3shares
https://github.com/aiunderstand/tt02-4bit-tristate-loadable-counter
https://github.com/ctag/tt02-submission-ctag
https://github.com/AsmaMohsin1507/tt02-channel-coding
https://github.com/ternary-info/tt02-submission-shaos3
https://github.com/saicharan0112/tt02-submission-template
https://github.com/theFestest/tt02-4x4-ram
https://github.com/jeanthom/tinytapout-lock
https://github.com/cmu-stuco-98154/f22-tt02-qilins
https://github.com/prabaldutta/tt02-adi-demo
https://github.com/TinyTapeout/tt02-test-7seg
Here's a test case I prepared to make it easy to check:
https://github.com/mattvenn/openlane-test-invert
Expected Behavior
should work fine.
Environment report
Kernel: Linux v5.13.0-28-generic
Distribution: ubuntu 20.04
Python: v3.8.10 (OK)
Container Engine: docker v20.10.7 (OK)
OpenLane Git Version: cb59d1f84deb5cedbb5b0a3e3f3b4129a967c988
pip: INSTALLED
python-venv: INSTALLED
---
PDK Version Verification Status: MISMATCH
The version of open_pdks used in building the PDK does not match the version OpenLane was tested on (installed: 0059588eebfc704681dc2368bd1d33d96281d10f, tested: 3af133706e554a740cfe60f21e773d9eaa41838c)
This may introduce some issues. You may want to re-install the PDK by invoking `make pdk`.
---
Git Log (Last 3 Commits)

cb59d1f 2022-11-18T18:42:38+02:00 fix return values in `equally_spaced_sequence` (#1503) - Kareem Farid -  (grafted, HEAD, tag: 2022.11.19)
---
Git Remotes

origin	https://github.com/The-OpenROAD-Project/OpenLane (fetch)
origin	https://github.com/The-OpenROAD-Project/OpenLane (push)

Reproduction material
download the repo, mount openlane, then run
./flow.tcl -ignore_mismatches -design test-invert
Relevant log output
[STEP 7]
[INFO]: Running Global Placement (log: designs/test-invert/runs/RUN_2022.12.08_18.06.42/logs/placement/7-global.log)...
[ERROR]: during executing openroad script /openlane/scripts/openroad/gpl.tcl
[ERROR]: Log: designs/test-invert/runs/RUN_2022.12.08_18.06.42/logs/placement/7-global.log
[ERROR]: Last 10 lines:
[INFO GPL-0068] 2.0%RC: 0.5719298453707444
[INFO GPL-0069] 5.0%RC: 0.4985507350900899
[INFO GPL-0070] 0.5rcK: 1.0
[INFO GPL-0071] 1.0rcK: 1.0
[INFO GPL-0072] 2.0rcK: 0.0
[INFO GPL-0073] 5.0rcK: 0.0
[INFO GPL-0074] FinalRC: 0.6666667
[ERROR GPL-0306] RePlAce diverged at wire/density gradient Sum.
Error: gpl.tcl, 69 GPL-0306
child process exited abnormally

[ERROR]: Creating issue reproducible...

In the future please note:
[INFO]: Reproducible packaged: Please tarball and upload 'designs/openlane-test-invert/runs/RUN_2022.12.08_18.52.08/issue_reproducible' if you're going to submit an issue.

providing that issue_reproducible is the best way to make a test case that is independent of OL.  I've done that for myself in this case.

Apologies

np

I've fixed this case.  If there are others that still fail please reopen with a new case.