Thorium Building Discussion

The latest version 103 finally does not need to use compatibility mode to open the browser, but when searching on the settings page, the browser still crashes.
Also, is it possible to use GitHub Actions to compile source code into Thorium executable?

@gz83 Yeah they finally fixed it upstream. And yeah I know. I'm investigating. Im gonna make a Thorium build that has anything that could possibly have to do with settings code omitted. Because I think it IS something on my end, as other AVX2 releases from woolyss.com dont have this issue.

@gz83 Yeah they finally fixed it upstream. And yeah I know. I'm investigating. Im gonna make a Thorium build that has anything that could possibly have to do with settings code omitted. Because I think it IS something on my end, as other AVX2 releases from woolyss.com dont have this issue.

OK, I understand, thank you very much for your contribution!
If you encounter other problems later, I will give you feedback in time.

@gz83 And about GitHub actions, I've never used it before, and IDK how well/if at all it would work with a project on the scale of Chromium/Thorium. Compiling Thorium on my i7 4790K thats overclocked all cores to 4.6Ghz takes 3-4 hours.
If you or anyone wants a full walkthrough on how to compile it for yourself, I'm more than happy to oblige, I've guided two people so far. The releases almost always coincide with the commits, I.E. compiling it yourself your not gonna get a newer version.

@gz83 And about GitHub actions, I've never used it before, and IDK how well/if at all it would work with a project on the scale of Chromium/Thorium. Compiling Thorium on my i7 4790K thats overclocked all cores to 4.6Ghz takes 3-4 hours. If you or anyone wants a full walkthrough on how to compile it for yourself, I'm more than happy to oblige, I've guided two people so far. The releases almost always coincide with the commits, I.E. compiling it yourself your not gonna get a newer version.

I would like to dig into Thorium's compilation. If I directly pull all the source code in this repository to the local, and then compile Thorium against Chromium's official documentation, is this feasible? Or is there another way?

@gz83 Yeah for sure. There's quirks though, specific to Thorium and specific to what platform (linux, win, win-avx2, macos, raspberry pi), and you might run into snags even following the building section of the readme. I might make a wiki with more thorough instructions for every platform. It would still be best If I guide you. I'm pretty free and am on almost every platform.
Im on twitter as Alex313031, Reddit as Alex313031, facebook as Alex Frick with the thorium logo for my profile pic. Im also on IIRC, tumblr, email is<EMAIL_ADDRESS>I can call, facetime, or text. Theres other platforms im leaving out but basically no matter what you use there will be some way we can chat.

@gz83 Yeah for sure. There's quirks though, specific to Thorium and specific to what platform (linux, win, win-avx2, macos, raspberry pi), and you might run into snags even following the building section of the readme. I might make a wiki with more thorough instructions for every platform. It would still be best If I guide you. I'm pretty free and am on almost every platform.
Im on twitter as Alex313031, Reddit as Alex313031, facebook as Alex Frick with the thorium logo for my profile pic. Im also on IIRC, tumblr, email is<EMAIL_ADDRESS>I can call, facetime, or text. Theres other platforms im leaving out but basically no matter what you use there will be some way we can chat.

Thank you very much for your willingness to guide me. Since I am usually busy at work, developing software and compiling software are hobbies. I may not have time to learn to compile Thorium recently. When the time is sufficient, I will contact you through the above channels. Contact I'll include my GitHub username when you're there.

@gz83 In that case, and since I've been lazy about making said wiki, I'll start now by making a guide for you, and then just adding on to it for other platforms when I want to. What platform are you going to be compiling on, and what platform are you targeting.
Also, what are your specs i.e. cpu, ram, storage, OS version for the above question on what you would be compiling on.

@gz83 In that case, and since I've been lazy about making said wiki, I'll start now by making a guide for you, and then just adding on to it for other platforms when I want to. What platform are you going to be compiling on, and what platform are you targeting. Also, what are your specs i.e. cpu, ram, storage, OS version for the above question on what you would be compiling on.

I generally compile and use browsers including Thorium under Windows.
Also, I have two computers that I can use to compile and use, computer 1 is a desktop computer and computer 2 is a laptop.
Computer 1 Specifications
CPU: Intel i3-8100
RAM: Kingston 16G
Storage: Samsung 970EVO PLUS NVME solid state drive 256G capacity
OS: Windows 11 22000.613
Computer 2 Specifications
CPU: Intel i7-10710U
RAM: 16G
Storage: Samsung NVME solid state drive 512G capacity
OS: Windows 11 22598.200

@gz83 Ok youll def wanna use the laptop because of the 10710U and 512gb. Do you have at least 100Gb free?

@gz83 Ok youll def wanna use the laptop because of the 10710U and 512gb. Do you have at least 100Gb free?
Also, do you have visual studio installed?
And this is an example of quirks. I cross compile for windows on linux, although I've done a native compile. Compiling on windows requires visual studio, and while I'm working on some .bat in the "misc" folder in thorium, I dont have automated scripts like for linux and macos yet to do some of the stuff.

I prefer to use the laptop to compile, and I have installed visual studio.

@gz83 Ok cool ill write you up a tutorial.

@gz83 Ok cool ill write you up a tutorial.

Thanks Alex.

@gz83 Here you go >
https://github.com/Alex313031/Thorium/blob/main/misc/WIN_INSTRUCTIONS

@gz83 Yeah I tried to be as concise as possible, and get rid of ambiguity and not take anything for granted (like assuming a user knows something even though you probably know some stuff in there, because who knows who will read it). I tried to model it after the official chromium documentation, basically being like, if you read the whole thing, and do the steps top to bottom, you will get a working build.

@gz83 Yes thats literally how I amke all the windows and AVX2 releases. It's actually simpler. If you want I can make you a guide for that too!
In a sad note, my haswell motherboard died!!! So unfortunately, I wont be able to make AVX2 releases until I get a new board, or new system, as I am now using my older FX-8370, which only has AVX, and you can only compile for as high as the host system's processor supports. I am not ending this project by any means, I just simply physically cant compile them right now. As soon as I can I'll make a new release. Regular Windows, Linux, and MacOS releases will continue like normal though.

@gz83 Yes, that's literally how I make all the windows and AVX2 releases. It's actually simpler. If you want I can make you a guide for that too!
And the scripts will work for Linux, so that automates some things like copying the source over the chromium tree. It's actually my preferred way to compile the windows releases, but I do sometimes do a native compile on my Win 10 drive for debugging, as I can make .pdb files that can be analyzed in Visual Studio.
On a sad note, my haswell motherboard died!!! So unfortunately, I wont be able to make AVX2 releases until I get a new board, or new system, as I am now using my older FX-8370, which only has AVX, and you can only compile for as high as the host system's processor supports. I am not ending this project by any means, I just simply physically cant compile them right now. As soon as I can I'll make a new release. Regular Windows, Linux, and MacOS releases will continue like normal though.
Also, how did you get interested in Chromium, and do you use Thorium on debian?

Since I am learning C language and C++, I am also a loyal user of Chrome and Chromium, and the official release of Chromium lacks related components, which makes some functions unavailable, so I started to learn about Chromium compilation, and I also compared the official documents before. The compilation has been successful twice, which may be due to lack of experience. The compiled executable file has poor performance during use. For this reason, I am very distressed and have been looking for a solution.
Later, I saw the Chromium compiled and released by RobRich on the Internet, and continued to pay attention to it for a period of time. Until RobRich suspended the update due to health reasons, I learned about Thorium through the website woolyss, and I also met you in this project.
My current main operating system is Windows, and Thorium also runs on Windows. Regarding the Debian operating system, my Debian is currently only used on cloud servers and there is no graphical interface such as KDE and GNOME installed, so I have not installed and used Thorium on Debian for the time being. Let's talk about the cloud server I mentioned earlier. This cloud server is mostly idle. In order not to waste this cloud server, I want to use it to compile Thorium and learn some new knowledge by the way.
Looking forward to Alex's guidance, thank you very much.

@gz83 https://github.com/Alex313031/Thorium/blob/main/misc/WIN_CROSS_BUILD_INSTRUCTIONS

@gz83 and made new build_win.sh which I tagged you in. https://github.com/Alex313031/Thorium/blob/main/build_win.sh

@gz83 Made instructions for cross building side by side with the regular native windows instructions. > https://github.com/Alex313031/Thorium/blob/main/misc/WIN_CROSS_BUILD_INSTRUCTIONS.txt
Native instructions > https://github.com/Alex313031/Thorium/blob/main/misc/WIN_INSTRUCTIONS.txt
And made new build_win.sh which I tagged you in. https://github.com/Alex313031/Thorium/blob/main/build_win.sh
Also, you will find a section regarding the API Keys. If you want to build with API Keys, let me know, and I'll give you access to my private repo with the API Keys used in Thorium.
Since you will be building on the cloud server, it will need at a minimum 4GB ram +4GB swap or 8GB+ ram, as well as at least 80GB free space, and 2+ core processor (the more the better!!)

I have now started to build Thorium on the cloud server, and I would like to ask, is the API key used to log in to the Google account?

@gz83 Made instructions for cross building side by side with the regular native windows instructions. > https://github.com/Alex313031/Thorium/blob/main/misc/WIN_CROSS_BUILD_INSTRUCTIONS.txt
Native instructions > https://github.com/Alex313031/Thorium/blob/main/misc/WIN_INSTRUCTIONS.txt
And made new build_win.sh which I tagged you in. https://github.com/Alex313031/Thorium/blob/main/build_win.sh
Also, you will find a section regarding the API Keys. If you want to build with API Keys, let me know, and I'll give you access to my private repo with the API Keys used in Thorium.
Since you will be building on the cloud server, it will need at a minimum 4GB ram +4GB swap or 8GB+ ram, as well as at least 80GB free space, and 2+ core processor (the more the better!!)

Alex, I have a problem with the compilation process, when I run ./build_win.shd, the following error is returned, how should I solve this problem?
Building Thorium...
/root/depot_tools/ninja -C /root/chromium/src/out/thorium chrome chromedriver content_shell setup mini_installer -j4 -d stats
ninja: Entering directory `/root/chromium/src/out/thorium'
ninja: error: '../../third_party/zlib/fill_window_sse.c', needed by 'clang_x64/obj/third_party/zlib/zlib_x86_simd/fill_window_sse.o', missing and no known rule to make it
metric count avg (us) total (ms)
.ninja parse 6818 2888.6 19694.7
canonicalize str 7090982 0.2 1195.2
canonicalize path 7095148 0.1 681.4
lookup node 7095147 0.2 1467.5
.ninja_log load 1 60.0 0.1
.ninja_deps load 1 7.0 0.0
node stat 141742 4.4 621.4
depfile load 380 16.6 6.3
path->node hash load 0.61 (241586 entries / 393241 buckets)

@gz83 Did you make sure to add the target_os lines to .gclient, and to run ./setup.sh before building?

~@gz83 Did you make sure to add the target_os lines to .gclient, and to run ./setup.sh before building?~
@gz83 EDIT: Its because they just changed a file Thorium uses upstream.....after not changing it since 2021/10/20, see > https://source.chromium.org/chromium/chromium/src/+/main:third_party/zlib/BUILD.gn;bpv=1
Perfect timing lol, right when someone new wants to build!!
I'll fix it.
2nd EDIT : FIXED! > Alex313031/Thorium@3cef06b
You should be able to just copy that one file over the chromium tree after doing a git pull main in Thorium, and continue building as normal. Ninja is very good at resuming after a failure. You can also Ctrl + Z to pause or even Ctrl + C to stop it and resume compiling at a later time.

After modifying the file, the compilation can start, but at the end of the compilation, the following error is thrown.
../../chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc(369,18): error: use of undeclared identifier 'IDS_SETTINGS_MATH_FONT_LABEL'
{"mathFont", IDS_SETTINGS_MATH_FONT_LABEL},
^
../../chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc(395,16): error: no matching member function for call to 'AddLocalizedStrings'
html_source->AddLocalizedStrings(kLocalizedStrings);
../../content/public/browser/web_ui_data_source.h(76,16): note: candidate function not viable: cannot convert argument of incomplete type 'const webui::LocalizedString[]' to 'base::span< const webui::LocalizedString>' for 1st argument
virtual void AddLocalizedStrings(
             ^
../../content/public/browser/web_ui_data_source.h(80,16): note: candidate function not viable: cannot convert argument of incomplete type 'const webui::LocalizedString[]' to 'const base::Value ::Dict' for 1st argument
virtual void AddLocalizedStrings(
             ^
After the error is thrown, the compilation is interrupted, and the compilation can be resumed by re-executing build_win.sh.

@gz83 Just fixed that too. Since Thorium is based on tip-o-tree Chromium, stuff changes frequently, so I have to rebase it alot. I will upload a bookmarks.xml file that can be imported into any browser, it contains all of the files thorium uses, in alphabetical order, on source.chromium.org, and also has history to show by default. Thats how I rebase Thorium, I just open them all, and look at each tab and see in the git history if anythings changed since last time I rebased, then I can just see the diff and copy/paste changes. If I want to change something in Thorium itself, or the changes are extensive and would take alot of copy/pasting, I instead copy/paste the whole thing and rewrite it from scratch. I have links in the PATCHES.md file where patches come from, and I have info in the BUILDER file for patches I made myself.
Im gonna upload this bookmarks.xml file because it will allow other people to rebase Thorium even if Im not available, and will ease Thorium development from other people if they ever wanna help.
Anyway, it should compile for you now, just replace this file > https://github.com/Alex313031/Thorium/commit/1131e22a94218da8e39eacafd9b56f702d362b43

@gz83 See also the readme for Thorium Infra > https://github.com/Alex313031/Thorium/blob/main/misc/README.md
And just uploaded the html file. > https://github.com/Alex313031/Thorium/blob/main/misc/thorium_devel_bookmarks.html

@gz83 See also the readme for Thorium Infra > https://github.com/Alex313031/Thorium/blob/main/misc/README.md
And just uploaded the html file. > https://github.com/Alex313031/Thorium/blob/main/misc/thorium_devel_bookmarks.html

Now the compilation is almost over, but the progress is stuck in STAMP obj/chromedriver.stamp for a long time.

@gz83 That's normal.

@gz83 That's normal.

I have successfully compiled mini_installer.exe and downloaded it locally from the cloud server. In addition, I compiled the AVX2 version, how should I judge whether the compilation is correct?

@gz83 What do you mean? If it runs, it compiled correctly lol. If you mean discerning the AVX vs AVX2 versions, the AVX2 version will have a slightly larger size.

@gz83 And about your question regarding API Keys, you could create your own API Keys, and I could guide you on that (my guide would be based on the official documentation at > https://www.chromium.org/developers/how-tos/api-keys/
But it's annoying to do, and easy to mess up. It took me three trys and probably an hour to figure it all out when I created my own personal ones two years ago. When I made thorium, I made separate ones specifically for the public releases, but I paid for an increased google sync api quota since they restricted it back in Mar. 15, 2021 > https://blog.chromium.org/2021/01/limiting-private-api-availability-in.html
I have a private repo with the API Keys for Thorium, and my ChromiumOS (now with a beta build of ThoriumOS) builds > https://github.com/Alex313031/ChromiumOS
I have shared that repo with @midzer as he makes the MacOS builds for ARM64 (M1) and x64. I would be willing to share these API Keys with you so that we could continue publishing AVX2 releases. I would give you credit and commiter status in the releases.
My only thing is please do not share these API Keys with anyone else, and please do not modify anything in Thorium (for a public release, feel free to modify to your hearts content for a personal release) without prior approval/a pull request. This is to maintain consistency and trust with my users. If you wanna change something, let me know. Anyway, just let me know and I'll give you access to this repo and instructions on how to use the keys.

@gz83 What do you mean? If it runs, it compiled correctly lol. If you mean discerning the AVX vs AVX2 versions, the AVX2 version will have a slightly larger size.

Sorry, my last reply didn't express the meaning clearly, what I meant was to distinguish between AVX and AVX2 versions as you said. I've compiled two AVX2 versions now and it's working fine on my computer, I haven't compiled the AVX version yet.

@gz83 And about your question regarding API Keys, you could create your own API Keys, and I could guide you on that (my guide would be based on the official documentation at > https://www.chromium.org/developers/how-tos/api-keys/
But it's annoying to do, and easy to mess up. It took me three trys and probably an hour to figure it all out when I created my own personal ones two years ago. When I made thorium, I made separate ones specifically for the public releases, but I paid for an increased google sync api quota since they restricted it back in Mar. 15, 2021 > https://blog.chromium.org/2021/01/limiting-private-api-availability-in.html
I have a private repo with the API Keys for Thorium, and my ChromiumOS (now with a beta build of ThoriumOS) builds > https://github.com/Alex313031/ChromiumOS
I have shared that repo with @midzer as he makes the MacOS builds for ARM64 (M1) and x64. I would be willing to share these API Keys with you so that we could continue publishing AVX2 releases. I would give you credit and commiter status in the releases.
My only thing is please do not share these API Keys with anyone else, and please do not modify anything in Thorium (for a public release, feel free to modify to your hearts content for a personal release) without prior approval/a pull request. This is to maintain consistency and trust with my users. If you wanna change something, let me know. Anyway, just let me know and I'll give you access to this repo and instructions on how to use the keys.

The API used by the version I compile now is generated according to the official documentation.
In addition, I would like to ask, if I want to use the API provided by you, what should I do? I will not leak or share the API with anyone. And you mentioned earlier that you can't make AVX2 version because of motherboard problem, can I help you?
My current compiled version has not been uploaded to the Internet, just for my own use, and I have not made any modifications to Thorium.

@gz83 So you made your own API Keys?
And besides distinguishing with size, as soon as one is finished building I rename it to thorium_mini_installer.exe or thorium_avx2_mini_installer.exe to prevent confusion.
I will give you access to my private repo. In there, there is a file called THORIUM_API_KEYS, which has the three lines for the args.gn relating to API Keys, you can just copy/paste those over the lines in the args.gn

@gz83 There, I added you to the api_keys repo.
Also, can you send the two builds you've made thus far. I wanna test them, and If it has api keys then I will release the latest one here with you attributed.
I reccomend https://wormhole.app/
Encrypted, peer to peer upload/download that you can set to expire from 1 day to month. Free and open source.

@gz83 There, I added you to the api_keys repo.
Also, can you send the two builds you've made thus far. I wanna test them, and If it has api keys then I will release the latest one here with you attributed.
I reccomend https://wormhole.app/ Encrypted, peer to peer upload/download that you can set to expire from 1 day to month. Free and open source.

I am using the API that I generated myself. For the API problem you mentioned later, I will check the related content now.
I made versions 5035 and 5039. 5039 was compiled today. I am using version 5039. The installation package of version 5035 has been deleted. I can upload the installation package of 5039. The download link of the installation package is: https://wormhole.app/744XB#b16q_UMTXO9DZDR7vDVIag
By the way, the issue of the 5035 and 5039 versions needing to have compatibility mode turned on to run is still there.

@gz83 There, I added you to the api_keys repo.
Also, can you send the two builds you've made thus far. I wanna test them, and If it has api keys then I will release the latest one here with you attributed.
I reccomend https://wormhole.app/ Encrypted, peer to peer upload/download that you can set to expire from 1 day to month. Free and open source.

Alex, may I ask, is there any way to ensure the security of the api and not affect my Google account?
In addition, when I click View History in version 5039, the browser crashes and exits.

@gz83 Wdym? IDK how I could verify that, I mean I could show you screenshots of my google cloud console, what API's I have enabled, and that the key wasn't modified since the time I created it. I can view hits for an API (like how many hits per hour the sync api is getting), but can only view personal data from myself (and even at that, only the site that sent the requesting header for a certain api). To view other's data, I would have to send an invite, and they would have to sign in to their account. I made these keys specifically separate from my personal api keys, so they could be used for public consumption and use in Thorium.
Other than that, I'm not familiar with the google cloud console besides making API Keys (thats all ive ever used it for), so I don't know what to say other than "im big on security myself, and would never do anything to mess with users privacy/security". In fact that is one of the pivotal points of Thorium, hence why many of the patches came from ungoogled chromium or vanadium.
If you don't trust me, that's okay (I don't trust many companies/people in the digital world), and in that case I would recommend using your own API Keys, although If you're going to make Thorium AVX2 releases, you will need to use my api keys, or make some seperate ones (making sure it has all the api keys enabled that the thorium ones do) and pay a fee to enable a higher quota for the sync api.
And so only on that version 5039 it crashes?

@gz83 Wdym? IDK how I could verify that, I mean I could show you screenshots of my google cloud console, what API's I have enabled, and that the key wasn't modified since the time I created it. I can view hits for an API (like how many hits per hour the sync api is getting), but can only view personal data from myself (and even at that, only the site that sent the requesting header for a certain api). To view other's data, I would have to send an invite, and they would have to sign in to their account. I made these keys specifically separate from my personal api keys, so they could be used for public consumption and use in Thorium. Other than that, I'm not familiar with the google cloud console besides making API Keys (thats all ive ever used it for), so I don't know what to say other than "im big on security myself, and would never do anything to mess with users privacy/security". In fact that is one of the pivotal points of Thorium, hence why many of the patches came from ungoogled chromium or vanadium.
If you don't trust me, that's okay (I don't trust many companies/people in the digital world), and in that case I would recommend using your own API Keys, although If you're going to make Thorium AVX2 releases for public release here in this repo, you will need to use my api keys, or make some seperate ones (making sure it has all the api's enabled that the thorium ones do) and pay a fee to enable a higher quota for the sync api.
I'm actually trying to get my hands on some official google api keys like Nik (used to make stable windows releases) or Hibbiki (makes stable releases now) did. Because even with my keys, people still need to add themselves to that test account google group, instead of it "just working" like google chrome.  If they had left well enough alone, I could have just used api keys from a linux distro, instead of making my own (most linux distros were forced to remove their keys after mar. 15: you can see this in the debian and arch linux mailing list archives, for example)
And so only on that version 5039 it crashes?

Your reply answered my doubts.
I didn't mean to distrust you, I hope you don't blame me. I'm currently recompiling a new Thorium with the API from your private repository, and the compilation is still in progress.
The API limitations you mention are really annoying, and I'm deeply dissatisfied after reading them. In addition, I would like to ask, which is the specific webpage about Google Group?
Regarding the crash problem, it is only found on the 5039 version, and I have not tried the 5035 version.

@gz83 Oh no need to apologize. I dont blame you, especially with some random new guy on the block making a browser like me. And if you're like me, a majority of what you do is in the browser. (I currently have 1523 tabs in 31 windows open, consuming 14.6GB of RAM and 40% of my 8 core 4.6GHz CPU lmaoooo). Im invested in the Chromium and ChromiumOS projects, and am was just trying to make it better with compiler optimizations and patches, then decided why not share it with the world. And apparently people like it because I get around ~300 downloads per release, per platform (less so for the Mac releases, although the Mac M1 ARM64 releases seem to be getting more popular, because currently, besides official chrome, there are no Chromium based browsers besides Thorium out there for these machines. I'm so thankful to Jerry at @woolyss for adding me to chromium.woolyss.com, which I've used for years. I never thought back when I was using it to download Chromium for windows xp that I would be a part of it. And it makes me even gladder when people take an active interest like you have and want to build it themselves.

And about the API Keys. Currently, unless you have official google chrome api keys, then to sign in to google sync (other features like translate will work without doing this), you have to add yourself to https://groups.google.com/u/1/a/chromium.org/g/google-browser-signin-testaccounts
This is per this section in the api keys document. > https://www.chromium.org/developers/how-tos/api-keys/#signing-in-to-chromium-is-restricted
Its annoying because I get bug issues all the time with people saying sync isnt working. Ive posted about the above stuff in releases multiple times and might start doing it again. I personally don't use sync except on ChromiumOS/ChromeOS, but realize it is something people want in a Chromium release, hence the "sync" tag on woolyss.com

@midzer I think I made a new friend lol. And like we were talking about perhaps he can help with the AVX2 builds since my haswell board decided to go the way of the DoDo bird. Was missing these kind of discussions after @RobRich999 stopped Chromium builds. I hope he's okay. If he sees this hope he lets us know.

@midzer I think I made a new friend lol. @gz83 And like we were talking about perhaps he can help with the AVX2 builds since my haswell board decided to go the way of the DoDo bird. Was missing these kind of discussions after @RobRich999 stopped Chromium builds. I hope he's okay. If he sees this hope he lets us know.

I can help build AVX/AVX2 versions for Linux/Windows, and I'll be willing to give Thorium time and effort as long as you accept me.

@gz83 I haven't made any public AVX2 Linux releases, although I did make some personal haswell only releases before the haswell boards death. BUT they seemed popular when RobRich999 made them. So maybe I'll make a Thorium-Linux-AVX2 repo or something. I should have named this one Thorium-Win-AVX2 to match Thorium-Win, instead of Thorium-AVX2, but I wasn't thinking ahead, and assumed I would only make AVX2 releases for Windows.

@gz83 I haven't made any public AVX2 Linux releases, although I did make some personal haswell only releases before the haswell boards death. BUT they seemed popular when RobRich999 made them. So maybe I'll make a Thorium-Linux-AVX2 repo or something. I should have named this one Thorium-Win-AVX2 to match Thorium-Win, instead of Thorium-AVX2, but I wasn't thinking ahead, and assumed I would only make AVX2 releases for Windows.
Also, If you happen to have a raspberry pi 3b/3b+/4/400 I make ARM64 releases in thorium-special for it.

I originally owned a Raspberry Pi, but I sold it to someone on the second hand market a few years ago.

@gz83 Regarding the above comment about wanting official api keys, Im thinking of doing a decompile of official chrome and grepping the results for "api_key"

How long will this process take?
By the way, how is the 5039 version I sent you running on your computer, is it normal?

@gz83 Assuming it even works (Thorium and official chrome have the gn args is_debug=false and symbol_level=0, so it might not be able to decompile, or even if it does, not contain stack trace information to get individual lines like that.) IDK i've never done a chrom(ium) decompile before lol. And I haven't been able to test it. Im not on my windows 7 or 10 drive right now, and im on my ubuntu 22.04 drive rather than my normal crunchbangplusplus (minimalist openbox debian based distro > https://crunchbangplusplus.org/) which has my windows VMs I use for thorium testing.

@gz83 Assuming it even works (Thorium and official chrome have the gn args is_debug=false and symbol_level=0, so it might not be able to decompile, or even if it does, not contain stack trace information to get individual lines like that.) IDK i've never done a chrom(ium) decompile before lol. And I haven't been able to test it. Im not on my windows 7 or 10 drive right now, and im on my ubuntu 22.04 drive rather than my normal crunchbangplusplus (minimalist openbox debian based distro > https://crunchbangplusplus.org/) which has my windows VMs I use for thorium testing.
Also, I edited above comment.

It is raspberry pi 3b. Also, I am reading the article in your blog.

@gz83 Assuming it even works (Thorium and official chrome have the gn args is_debug=false and symbol_level=0, so it might not be able to decompile, or even if it does, not contain stack trace information to get individual lines like that.) IDK i've never done a chrom(ium) decompile before lol. And I haven't been able to test it. Im not on my windows 7 or 10 drive right now, and im on my ubuntu 22.04 drive rather than my normal crunchbangplusplus (minimalist openbox debian based distro > https://crunchbangplusplus.org/) which has my windows VMs I use for thorium testing.
Also, I edited above comment.

Alex, I suddenly thought of a question, when the source code of Chromium and Thorium is updated, how should I sync it to my server for subsequent version updates? Is it possible to synchronize the source code update by directly running the command in the last part of the cross-compilation tutorial you wrote?

@gz83 Chromium can be updated by runnin a ./trunk.sh, and Thorium can be updated like any other git repo, or by downloading the latest .zip

@gz83 Chromium can be updated by runnin a ./trunk.sh, and Thorium can be updated like any other git repo, or by downloading the latest .zip

I understand, I will compile a new version later.

@gz83 Chromium can be updated by runnin a ./trunk.sh, and Thorium can be updated like any other git repo, or by downloading the latest .zip

Sorry, I forgot a question.
After I run trunk.sh to update the Chromium source, do I still need to run setup.sh?

@gz83 Yes. Trunk.sh just updates the chromium source. Setup.sh is what copies all of the files from thorium over the chromium tree, and then downloads the pgo profile for all the platforms.
So you should update the thorium repo, then run trunk.sh, then run setup.sh. BTW I just rebased the whole thorium tree so now would be a good time to build. If you make an avx2 release remember to use the build dir from this repo and manually copy it over //chromium/src/build, and to use the api keys in the repo i added you to at the top of your args.gn, and of course remember the pgo profile needs to be set every time you build since it changes with every revision.

@gz83 Yes. Trunk.sh just updates the chromium source. Setup.sh is what copies all of the files from thorium over the chromium tree, and then downloads the pgo profile for all the platforms.
So you should update the thorium repo, then run trunk.sh, then run setup.sh. BTW I just rebased the whole thorium tree so now would be a good time to build. If you make an avx2 release remember to use the build dir from this repo and manually copy it over //chromium/src/build, and to use the api keys in the repo i added you to at the top of your args.gn, and of course remember the pgo profile needs to be set every time you build since it changes with every revision.

Okay, I understand.
When I was compiling the new version just now, a new error appeared.  Trunk.sh just updates the chromium source. Setup.sh is what copies all of the files from thorium over the chromium tree, and then downloads the pgo profile for all the platforms.
So you should update the thorium repo, then run trunk.sh, then run setup.sh. BTW I just rebased the whole thorium tree so now would be a good time to build. If you make an avx2 release remember to use the build dir from this repo and manually copy it over //chromium/src/build, and to use the api keys in the repo i added you to at the top of your args.gn, and of course remember the pgo profile needs to be set every time you build since it changes with every revision.

Problem report: ../../third_party/zlib/contrib/minizip/ioapi.c(224,6): error: a function declaration without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror ,-Wdeprecated-non-prototype]
void fill_fopen_filefunc (pzlib_filefunc_def)
^
The compilation can continue after manually modifying the Chromium source code, please pay attention to this problem.

@gz83 Okay fixed those files. Also, did you fix the rebase error? It shouldnt do that. Ive had that happen when a file was in thorium that wasnt in chromium.

@gz83 Okay fixed those files. Also, did you fix the rebase error? It shouldnt do that. Ive had that happen when a file was in thorium that wasnt in chromium.

Regarding the first issue above, if I modify the source code like this, will it not destroy the function of the browser?

@gz83 I fixed that. It was the zlib build.gn.
And thats weird, I would say maybe try redownloading the chromium and thoriums oruce tree and starting from scratch.
Also, check out what Ive been working on today. A simple little extension for thorium, makes the scrollbars look nice.
https://github.com/Alex313031/Thorium_ScrollBars

@gz83 I fixed that. It was the zlib build.gn.
And thats weird, I would say maybe try redownloading the chromium and thoriums oruce tree and starting from scratch.
Also, check out what Ive been working on today. A simple little extension for thorium, makes the scrollbars look nice.
https://github.com/Alex313031/Thorium_ScrollBars

I saw the changes in zlib. Thank you for your work. I have searched for rebase errors on the Internet, but I haven't found a solution yet. I personally feel that solving rebase errors is better than starting from scratch, which can save at least some time and resources.
Your new project is very good. I'll try to install it.

@gz83 I fixed that. It was the zlib build.gn.
And thats weird, I would say maybe try redownloading the chromium and thoriums oruce tree and starting from scratch.
Also, check out what Ive been working on today. A simple little extension for thorium, makes the scrollbars look nice.
https://github.com/Alex313031/Thorium_ScrollBars

Version 5045 opened the history page back to normal, but the settings search still crashed, and also required opening the browser in compatibility mode.

@gz83 Thats the most common error. Those IDS errors are related to the .grdp files in thorium, which store strings and are used for branding, i.e. they are identicle to the chromium ones except instances of "chromium" are replaced with Thorium. I'll fix it right now. Again, because Thorium is based on tip of tree stuff changes alot. Often if I havent built in a couple days I have to rebase stuff, and sometimes more often, as can be seen today since I've had to update multiple files. How about we exchange some socials, that way you can get ahold of me easier. Thats how me and @midzer do it, he'll just text or facetime me and say "hey about to do a thorium rebuild can you do a rebase" Im almost always on my computer and even if not, im usually at home and my computer is in my bedroom, so its usually no big deal for me to just check and make sure no files have been updated whenever you do a build. I have pretty much everything, we could text, call, facetime, I've got reddit, facebook, twitter, tumblr, instagram, snapchat, IIRC, etc.
Also, so this is an AVX2 release, and you used the Thorium api keys? If so, send it via wormhole or something and I'll publish it with you in the tag

I have uploaded the 5045 version in Whrmole, there are mini_installer and portable version, the API information used in this version is provided to me by you, and other content has not been modified. The link to Whrmhole is: https://wormhole.app/Lrnyz#xrFbR0Cl12fB583J0hq54Q
I can exchange twitter contacts with you, my twitter link is https://twitter.com/uioptt24 Also, I am currently following your twitter.

@gz83 Hey thanks! That really helps! You named them all correctly, and did the portable zip all correctly, great work, made it easy for me lol. I will publish and add you to the thorium repo. And I told @midzer this too so dont feel like im picking on you, maybe Im just a control freak lol, but please DO NOT make changes to the thorium repo directly. Make an issue, add to the discussions, or make a pull request.

@gz83 Made the release >> https://github.com/Alex313031/Thorium-AVX2/releases/tag/M103.0.5045.0 and mentioned you at the top. Also, I'm going to move this discussion to the main thorium discussions in the main repo.

@gz83 Hey thanks! That really helps! You named them all correctly, and did the portable zip all correctly, great work, made it easy for me lol. I will publish and add you to the thorium repo. And I told @midzer this too so dont feel like im picking on you, maybe Im just a control freak lol, but please DO NOT make changes to the thorium repo directly. Make an issue, add to the discussions, or make a pull request.

I am very happy to be able to join your team. I will continue to contribute to Thorium in the future. At the same time, I will also abide by the rules you have set. I wish Thorium better and better.

@gz83 Made the release >> https://github.com/Alex313031/Thorium-AVX2/releases/tag/M103.0.5045.0 and mentioned you at the top. Also, I'm going to move this discussion to the main thorium discussions in the main repo.

Okay, I know.

@gz83 Closing this now. Will continue it in the main repo discussions. Will also make a new discussions here too, to be used only for things that are Win AVX2 specific.


Incrementar no DER a tabela de artigos

Criei a tabela.
2017-08-25 22:14 GMT-03:00 Ronneesley Moura Teles<EMAIL_ADDRESS>:

Assigned #196 https://github.com/Ronneesley/redesocial/issues/196 to
@IgorJustinoRodrigues https://github.com/igorjustinorodrigues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ronneesley/redesocial/issues/196#event-1222329392,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZOMikjNvCR1G1Y4ViXXjK33meQXTa1jks5sb3GGgaJpZM4PDTSu
.

Ok


Available Wallets

https://developers.flow.com/concepts/flow-token/available-wallets

fixed in https://github.com/onflow/docs/commit/e38fdd5d9c05dcea61e2a4c1f7e3138435575f63


Fix drag&drop between window on Windows

Fixes #95639

I'm not sure exactly what caused this regression in 12fda2f (#91361) but I was able to find out that sometime the window_id received on WM_LBUTTONUP was not the same as the one on WM_LBUTTONDOWN. That usually happens when the button down is made on an unfocused window.
The engine is built on the fact that the button up needs to be on the same window as the button down. I saw that in DisplayServerX11::process_events the other day:
// Propagate the event to the focused window,
// because it's received only on the topmost window.
// Note: This is needed for drag & drop to work between windows,
// because the engine expects events to keep being processed
// on the same window dragging started.

So I kept the last window id (last_mouse_button_down_window) on the button down and reused it for the button up event. What is weird is that the position in the  InputEventMouseButton correspond to the position in the last window id and not the window id received on button up. Therefore, I did not have to update position in the event object when updating the window_id.
Note: This PR only fixes the problem where the drag&drop does not work between window. It does not fix the missing control cursor on the destination window. That's a hole other problem and I guess it never worked. Also, I think #67531 implemented it??
https://github.com/user-attachments/assets/17832367-2b0f-432e-ac43-67236c2c8af5

Thanks!

Cherry-picked for 4.3.1.


RuntimeError in predictor.explain - dogs and cats demo

In the dogs and cats demo, everything works well except the predictor.explain which returns a runtime error. Here's some details:
predictor.predict_filename('/content/dc/valid/cats/cat.11724.jpg') => ['dogs']
predictor.explain('/content/dc/valid/cats/cat.11724.jpg')
---------------------------------------------------------------------------

RuntimeError                              Traceback (most recent call last)

<ipython-input-45-94cd2561b0f0> in <module>()
----> 1 predictor.explain('/content/dc/valid/cats/cat.11724.jpg')

9 frames

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/ops/gradients_util.py in _GradientsHelper(ys, xs, grad_ys, name, colocate_gradients_with_ops, gate_gradients, aggregation_method, stop_gradients, unconnected_gradients, src_graph)
    489   """Implementation of gradients()."""
    490   if context.executing_eagerly():
--> 491     raise RuntimeError("tf.gradients is not supported when eager execution "
    492                        "is enabled. Use tf.GradientTape instead.")
    493   if src_graph is None:

RuntimeError: tf.gradients is not supported when eager execution is enabled. Use tf.GradientTape instead.

using Keras version: 2.2.4-tf
ktran: '0.10.1'
eli5: '0.10.1'
stellargraph: '0.8.2'

Thanks for reporting issue.  A workaround for right now is to disable V2 behavior by adding this to top of your notebook or script prior to importing ktrain:
import os
os.environ["DISABLE_V2_BEHAVIOR"]="1"

Doing the above will allow you to use predictor.explain on images.

Workaround fixes the issue. Some images have invisible explanation, though.  Not sure if color issue or no focus in the frame.

Thanks.  That's an issue best asked on the eli5 GitHub page, as predictor.explain is only a thin wrapper to that library, which just simply invokes this: eli5.show_prediction(model, x).
For now, I have added a check in ImagePredictor.explain to ensure DISABLE_V2_BEHAVIOR=True.

https://github.com/TeamHG-Memex/eli5/issues/368

Looks like the issue was resolved in the linked thread - thanks.


Can the class name of the drop-down icon of [Feature Request] el-submenu be changed to props?

Existing Component
是
Component Name
el-submenu
Description
submenu.vue文件

el-icon-arrow-down
el-icon-caret-bottom
这两个类名支持prop方式。

Sorry, we have no plan to support this.


resolves 1081

Would you mind updating the PR with a little more info? (ie. reiterating what you're resolving, the approach you took, any gotchas, etc) Also add the words resolves #1081 (make sure to include the # or GitHub won't link the issue)

This is a replacement of #1136; we had trouble squashing commits in that branch so had to create a separate branch (see here).


Installing takes wayyyyyy to long for some reason

It needs to build a lot of things for this to work. It's normal behavior. Looking at this you seem to be using docker so this step should get cached anyway.


GEOMESA-2343 Update Recommended Accumulo Version

Signed-off-by: Andrew Hulbert<EMAIL_ADDRESS>

Should we update docs/user/accumulo/install.rst as well?
(Renders to https://www.geomesa.org/documentation/current/user/accumulo/install.html)

yup, did it.


Installation issue, missing gpost

How i can resolve this issue?
`mm@srv:~/dagobah/dagobah$ dagobahd
Traceback (most recent call last):
File "/usr/local/bin/dagobahd", line 9, in
load_entry_point('dagobah==0.1.8', 'console_scripts', 'dagobahd')()
File "/home/mpeter/.local/lib/python2.7/site-packages/pkg_resources/init.py", line 542, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/home/mpeter/.local/lib/python2.7/site-packages/pkg_resources/init.py", line 2569, in load_entry_point
return ep.load()
File "/home/mpeter/.local/lib/python2.7/site-packages/pkg_resources/init.py", line 2229, in load
return self.resolve()
File "/home/mpeter/.local/lib/python2.7/site-packages/pkg_resources/init.py", line 2235, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/local/lib/python2.7/dist-packages/dagobah-0.1.8-py2.7.egg/dagobah/init.py", line 4, in
from .core import *
File "/usr/local/lib/python2.7/dist-packages/dagobah-0.1.8-py2.7.egg/dagobah/core/init.py", line 2, in
from .components import JobState, Scheduler, EventHandler
File "/usr/local/lib/python2.7/dist-packages/dagobah-0.1.8-py2.7.egg/dagobah/core/components.py", line 10, in
import post
ImportError: No module named gpost
mm@srv:~/dagobah/dagobah$
`
Best regards,
Marc

It seems like your'e using someone's fork, so you should ask the maintainer of the fork. We don't have a version 0.1.8 and I don't think my version has ever used the gpost library (I've never even heard of it before).


Updating setup.py with missing dependancies

Description
This pull request updates setup.py with missing dependancies so developers have all the tools needed to lint their code (e.g., by running pylint composer examples, or make lint, or make style). Prior to this, running linters would fail and require manual installation of dependancies. It also updates numpy to a newer version.
As an extra, it updates the string formatting of the file to use double quotes—which is used throughout the project.

@hanlint oopsies, my bad! You're totally right.
Quick one, setting up environment with pip install .[dev] works but it seemed like pyright is still missing. I'll remove the other dependencies that I added, but should I add pyright to the dev part of the setup.py?
(composer) ➜  composer git:(fresh-environment-installed-dependancies-update) ✗ pip install .[dev]
...

(composer) ➜  composer git:(fresh-environment-installed-dependancies-update) ✗ make lint
python   -m isort -c --diff composer examples tests
python   -m yapf -dr composer examples tests
python   -m docformatter -r --wrap-summaries 120 --wrap-descriptions 120 composer examples tests
pyright   composer examples tests
make: pyright: No such file or directory
make: *** [lint] Error 1

Quick one, setting up environment with pip install .[dev] works but it seemed like pyright is still missing. I'll remove the other dependencies that I added, but should I add pyright to the dev part of the setup.py?

We have found https://pypi.org/project/pyright/ to be unreliable with respect to version pinning, so pyright will need to be installed manually.

Oh, interesting. I wonder why that happens (but that's probably an unrelated issue).
Do you want to keep this PR as one just for updating the string formatting and updating numpy versions? Or you prefer to just close it?

Yeah we think it's related to the pyright pypi package, which is not an unofficial package.
If you would update the Contributing.md with the pyright install instructions, and maybe add a comment in our README, we can still merge this PR, thanks!

Sounds good! I added some comments to the README.md and CONTRIBUTING.md. The only update to the dependencies was to numpy per the TODO comment in setup.py.


Folder>>parent error with unicode pathnames

Describe the bug
There is a problem with Folder>>parent when the pathname contains some unicode chars.
I got this error using the latest version. It doesn't happens in 7.1.14. I traced the problem to 8bcdd09ce6817a668cd2a007074de21593ab6614 with the addition of UtfEncodedString>>first: but the problem seems to be related to the #parent method itself which sends size to split the path.
parent
	"Answer a <Folder> representing the receiver's parent, or nil if a root.
	Note that this will be a new object each time as currently implemented,
	but they will be equal."

	| path |
	^(path := self pathname) isEmpty
		ifFalse: [self class pathname: (File splitPathFrom: (path first: path size - 1))]

You can solve this changing size by length which seems correct to me.
To Reproduce
Steps to reproduce the behavior:
We can reproduce this trying to create a new package inside a folder named 'Camión' causing a stack overflow. The real problem can be observed evaluating in a workspace: (Folder pathname: 'camión\camión') parent

In the 7.2 branch I have changed this to:
parent
	"Answer a <Folder> representing the receiver's parent, or nil if a root.
	Note that this will be a new object each time as currently implemented,
	but they will be equal."

	| path |
	^(path := self pathname) isEmpty
		ifFalse: [self class pathname: (File splitPathFrom: (path copyFrom: 1 to: path size - 1))]

The method is just trying to strip the trailing path separator. It shouldn't be using first: any more, because that is expecting a code-point count, not a code-unit count. Changing size to length would fix it, because it means that first: is passed the correct count, but the above is more efficient since we know that the path separators can only ever be one code-unit in size.


gb fails when pwd has a symlink

Below is a reproducer script. You will see gb build work once and fail once. The second time it looks like gb is figuring out the absolute/real path of cwd and then doing ../../../ type operations in relation to the absolute path. But linux is obviously interpreting those in relation to pwd....
#!/bin/bash
set -e

export GOPATH="$HOME/gopath"

# The following should work just fine.
go get k8s.io/kubernetes
cd $GOPATH/src/k8s.io/kubernetes
mkdir -p _output/local/go/src/k8s.io
ln -s $GOPATH/src/k8s.io/kubernetes _output/local/go/src/k8s.io/kubernetes > /dev/null 2>&1 || true
ln -s $GOPATH/src/k8s.io/kubernetes/Godeps/_workspace/ _output/local/go/vendor > /dev/null 2>&1 || true

echo "Setup complete. Now to run the test where pwd does not have a symlink"

# you must explicitly tell it what to build as filepath.Walk() will not follow the src/k8s.io/kubernetes symlink  :-(
cd $GOPATH/src/k8s.io/kubernetes/_output/local/go
gb build k8s.io/kubernetes/cmd/kubelet

echo "YAY! It worked! (I knew it would), now watch it fail because pwd does have a symlink!!!"

# But this will not work  :-(
ln -s $GOPATH/src/k8s.io/kubernetes $HOME/kubernetes > /dev/null 2>&1 || true
cd $HOME/kubernetes/_output/local/go/
gb build k8s.io/kubernetes/cmd/kubelet

@eparis  I'm really sorry but gb takes the same position on symlinks that the go tool does. Symlinks are not support inside src/ directories because they permit the same source to appear more than once in the tree.
I know this isn't the whole of this issue report, but I wanted to my position on symlinks clear to set your expectations appropriately.

I found/know that symlink issue as well.  I really wanted a filepath.WalkFollowLinks() but I understand. But you're right, that's not this bug report.
In this case the problem is the symlink in pwd not in/below src. If I cd to the exact same pwd using the realpath everything works just fine.
You're right, I also have a symlink under src/ which means I can't just use gb build I have to use gb build k8s.io/kubernetes/cmd/kubelet.
I know the reproducer is kind of a pain to understand. I can do something a little cleaner/easier if you like/need, that's just obviously exactly the case I hit trying to convert kubernetes to use gb

It's not helpful because @eparis and I are trying to achieve the same goal on the same project, but I want to be on record that this position on symlinks is, IMO, wrong.  If you want to crash my computer in case of a symlink loop or turn on my webcam when I make the same source appear twice in a tree (why is that bad, really?) go right ahead.
But this is inhibiting my ability to Get Things Done.  I want to use gb and I can't do what I need to transition to it.

Any thoughts on progress on this?

I'm sorry I have not had a chance to investigate this.
On Sun, Nov 22, 2015 at 7:13 AM, Tim Hockin<EMAIL_ADDRESS>wrote:

Any thoughts on progress on this?
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-158678436.

@eparis @thockin I think #483 might improve the situation.

From a kubernetes repo:
	rm -rf _gb  #FIXME:remove
	mkdir -p _output/local/go/{bin,pkg}
	mkdir -p _gb/src/k8s.io
	ln -s ../../../ _gb/src/k8s.io/kubernetes
	ln -s ../Godeps/_workspace/ _gb/vendor
	ln -s ../_output/local/go/bin _gb/bin
	ln -s ../_output/local/go/pkg _gb/pkg
	gb build -R _gb k8s.io/kubernetes/cmd/kube-proxy  # works
	gb build -R _gb k8s.io/kubernetes/cmd/...  # FATAL: command "build" failed: no packages supplied
	gb build -R _gb ./...  # FATAL: command "build" failed: no packages supplied

Still no love.

I think this does fix my bug, where gb went off the rails when pwd had a symlink.
But agree with Tim that isn't a huge pain that pathwalk has absolutely no 'follow symlinks' option. So go won't find packages via ./...

I'm sorry but I don't think I can support that syntax, that places a
symlink inside the $PROJECT/src.
On Tue, Dec 15, 2015 at 4:04 AM, Tim Hockin<EMAIL_ADDRESS>wrote:

From a kubernetes repo:
rm -rf _gb  #FIXME:remove
mkdir -p _output/local/go/{bin,pkg}
mkdir -p _gb/src/k8s.io
ln -s ../../../ _gb/src/k8s.io/kubernetes
ln -s ../Godeps/_workspace/ _gb/vendor
ln -s ../_output/local/go/bin _gb/bin
ln -s ../_output/local/go/pkg _gb/pkg
gb build -R _gb k8s.io/kubernetes/cmd/kube-proxy  # works
gb build -R _gb k8s.io/kubernetes/cmd/...  # FATAL: command "build" failed: no packages supplied
gb build -R _gb ./...  # FATAL: command "build" failed: no packages supplied

Still no love.
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-164495934.

I don't understand the hate on symlinks?  It's inane to me that the code
layout is dictated to be laid out JUST SO and yet I can't massage my way
around it?
On Mon, Dec 14, 2015 at 4:31 PM, Dave Cheney<EMAIL_ADDRESS>wrote:

I'm sorry but I don't think I can support that syntax, that places a
symlink inside the $PROJECT/src.
On Tue, Dec 15, 2015 at 4:04 AM, Tim Hockin<EMAIL_ADDRESS>wrote:

From a kubernetes repo:
rm -rf _gb #FIXME:remove
mkdir -p _output/local/go/{bin,pkg}
mkdir -p _gb/src/k8s.io
ln -s ../../../ _gb/src/k8s.io/kubernetes
ln -s ../Godeps/_workspace/ _gb/vendor
ln -s ../_output/local/go/bin _gb/bin
ln -s ../_output/local/go/pkg _gb/pkg
gb build -R _gb k8s.io/kubernetes/cmd/kube-proxy # works
gb build -R _gb k8s.io/kubernetes/cmd/... # FATAL: command "build"
failed: no packages supplied
gb build -R _gb ./... # FATAL: command "build" failed: no packages
supplied
Still no love.
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-164495934.

—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-164603753.

At the moment gb uses the go/build package for resolving packages. go/build
prohibits symlinks inside the source directory (GOPATH, and or
PROJECT/src). Allowing symlinks inside those directories would allow the
source of one package to appear more than once inside a binary.
On Tue, Dec 15, 2015 at 12:38 PM, Tim Hockin<EMAIL_ADDRESS>wrote:

I don't understand the hate on symlinks? It's inane to me that the code
layout is dictated to be laid out JUST SO and yet I can't massage my way
around it?
On Mon, Dec 14, 2015 at 4:31 PM, Dave Cheney<EMAIL_ADDRESS>wrote:

I'm sorry but I don't think I can support that syntax, that places a
symlink inside the $PROJECT/src.
On Tue, Dec 15, 2015 at 4:04 AM, Tim Hockin<EMAIL_ADDRESS>wrote:

From a kubernetes repo:
rm -rf _gb #FIXME:remove
mkdir -p _output/local/go/{bin,pkg}
mkdir -p _gb/src/k8s.io
ln -s ../../../ _gb/src/k8s.io/kubernetes
ln -s ../Godeps/_workspace/ _gb/vendor
ln -s ../_output/local/go/bin _gb/bin
ln -s ../_output/local/go/pkg _gb/pkg
gb build -R _gb k8s.io/kubernetes/cmd/kube-proxy # works
gb build -R _gb k8s.io/kubernetes/cmd/... # FATAL: command "build"
failed: no packages supplied
gb build -R _gb ./... # FATAL: command "build" failed: no packages
supplied
Still no love.
—
Reply to this email directly or view it on GitHub
<https://github.com/constabulary/gb/issues/308#issuecomment-164495934
.

—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-164603753.

—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-164614011.

I know the argument, but I just reject the utility of it.
On Dec 14, 2015 5:48 PM, "Dave Cheney"<EMAIL_ADDRESS>wrote:

At the moment gb uses the go/build https://goto.google.com/build
package for resolving packages. go/build https://goto.google.com/build
prohibits symlinks inside the source directory (GOPATH, and or
PROJECT/src). Allowing symlinks inside those directories would allow the
source of one package to appear more than once inside a binary.
On Tue, Dec 15, 2015 at 12:38 PM, Tim Hockin<EMAIL_ADDRESS>wrote:

I don't understand the hate on symlinks? It's inane to me that the code
layout is dictated to be laid out JUST SO and yet I can't massage my way
around it?
On Mon, Dec 14, 2015 at 4:31 PM, Dave Cheney<EMAIL_ADDRESS>wrote:

I'm sorry but I don't think I can support that syntax, that places a
symlink inside the $PROJECT/src.
On Tue, Dec 15, 2015 at 4:04 AM, Tim Hockin<EMAIL_ADDRESS>wrote:

From a kubernetes repo:
rm -rf _gb #FIXME:remove
mkdir -p _output/local/go/{bin,pkg}
mkdir -p _gb/src/k8s.io
ln -s ../../../ _gb/src/k8s.io/kubernetes
ln -s ../Godeps/_workspace/ _gb/vendor
ln -s ../_output/local/go/bin _gb/bin
ln -s ../_output/local/go/pkg _gb/pkg
gb build -R _gb k8s.io/kubernetes/cmd/kube-proxy # works
gb build -R _gb k8s.io/kubernetes/cmd/... # FATAL: command "build"
failed: no packages supplied
gb build -R _gb ./... # FATAL: command "build" failed: no packages
supplied
Still no love.
—
Reply to this email directly or view it on GitHub
<
https://github.com/constabulary/gb/issues/308#issuecomment-164495934
.

—
Reply to this email directly or view it on GitHub
<https://github.com/constabulary/gb/issues/308#issuecomment-164603753
.

—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-164614011.

—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/308#issuecomment-164616819.

Since this issue is still open, I'll try provide some input here. And ask a question.
I've until now used symlinks to achieve some of the same things wrt. reproducible builds as gb does. And I've used the package github.com/valyala/ybc/bindings/go/ybc in a few projects which is a CGO package with a symlink to the ybc.h file.
(Btw: the package is perfectly go get'able and it seems like a valid use of symlinks to add go-bindings via CGO to an otherwise C-project.  ... after gvt got fixed symlink support (see https://github.com/constabulary/gb/pull/534)) it works perfectly by vendoring with gvt )
This has worked fine until now, but I'll probably have to realize that the go tool makes this increasingly difficult and there's no interest amongst tools like godef and cmd/guru and editor support to make them work with such setup.
So ... since the other tools seem to accept gb projects existence with at least rudimentary support and since I basically agree with @davecheney in all his arguments, I consider moving all my vendoring (that's "non-library") projects to gb .
However... CGO support is kind of a must and I use the YBC library in several projects, so not being able to gb vendor fetch handle symlinks is kinda of a deal breaker.
I get the rationale for not allowing symlinks under $PROJECT/src ... Now the question: What about symlinks under $PROJECT/vendor/src ?


Could not load NIB in bundle

Terminating app due to uncaught exception 'NSInternalInconsistencyException',
reason: 'Could not load NIB in bundle: '...' with name 'SSMaterialCalendarPicker''

The debugger is breaking at line SSMaterialCalendarPicker.m at line 86.
Following lines from 85to 87:
UINib *cellNib = [UINib nibWithNibName:kCalendarCellIdentifier bundle:nil];
self = [[[NSBundle mainBundle] loadNibNamed:kCalendarPickerIdentifier
                                      owner:self options:nil] objectAtIndex:0];

This is the content of my Podfile:
use_frameworks!

target 'MyProject' do

pod 'SSMaterialCalendarPicker', '~> 1.1'

end

The .xib file containing the picker view is missing, somehow. Thanks for reporting it.
I'll try to fix it this week, if I manage to free up some time; but if you find out first, please submit a Pull Request, it'll help a lot.
Also, I'm planning a big refactor of this pod, probably next month or so, it's quite slow as it is now.
Keep an eye out for a v2.0, if you decide to use another pod :)

Any updates here?
I'm still getting the same issue like nerthase

is there a solution ?

I tried to fix it on Friday, but I couldn't figure out how to fix it properly.
The problem is probably in the .pospec file, the .xib files are missing in the app's bundle.
I guess that, in the meantime, you can import it manually to your app's project. Just install it as usual, find the .xib files in the Pod folder, and import it to your project (and set its targets).
Sorry I didn't have the time to fix it. If you guys have any ideas, you're welcome to try, I'd gladly merge your pull requests :)

GUYS!!1
I finally fixed it, hahahaha! I'm sorry for the looong long wait, I've been busy with my own projects and work, but I finally got around to study this problem (aka try and try again, failing and failing until I got it) and fix it.
I don't know if you still want to use it, but if you do, give it a try :)
Thanks for the feedback, and I'll try to keep it stable. It's not the best calendar around, but I'm happy you guys were interested in the first place :)
Best regards,
Iuri Chiba.

Ok, so it worked on the simulator, but not on the device. Greeeeeeeeeeeat...

Now it's working. Sorry about that, haha :)
I also update the gif on the intro, and fixed the example.


NIFI-7737: add string array option to putcassandrarecord

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables the use of string arrays in the PutCassandraRecord processor; fixes bug NIFI-7737.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Reviewing...

+1 LGTM, tested on a live flow, verified a string array in the record was successfully inserted into Cassandra. Thanks for the improvement! Merging to main


Upgrade to remark-gfm v4

The following bug https://github.com/storybookjs/storybook/issues/24743 is preventing us from upgrading to remark-gfm v4.

no longer relevant


Update index.html

Yo.. this is bad.

no its good

ok... I will approve.
You are >the man<

the man


Update description of project using BoltDB

The description was too old so i figured i could update it

👍 thanks @asdine!


python3.pkgs.{torch,triton}: two copies of llvm in the closure

Issue description
...one brought in by mlir, and one seemingly brought it directly. E.g. on my current system (paths included only to show they're different):

python3-3.10.12-env → python3.10-triton-2.0.0 → rocm-llvm-mlir-5.4.4 → hip-amd-5.4.4 → rocm-opencl-runtime-5.4.4 → rocm-runtime-5.4.3 → rocm-llvm-clang-5.4.4 → rocm-llvm-llvm-5.4.4

Path: /nix/store/hg2nby9s72yc2lx2by4fn9smffnv0iyd-rocm-llvm-llvm-5.4.4
Added Size: 1.43 GiB

python3-3.10.12-env → python3.10-triton-2.0.0 → rocm-llvm-llvm-5.4.4:

Path:  /nix/store/j0vfk0ybphyv9398svhxz303x11aanpa-rocm-llvm-llvm-5.4.4
Added Size: 1.47 GiB

@NixOS/cuda-maintainers

IIRC triton requires its own patched version of llvm, but weird that we'd have two different patched versions somehow 🤔

I thought they had moved largely towards building LLVM HEAD (or at least trying to track it more closely). I do remember the python setup script downloading a pre-built copy of LLVM with MLIR (MLIR might not be present in the default version of LLVM most distributions make available?), but I think that was more for convenience than anything else. https://github.com/openai/triton/blob/c4bc3fd92f79a1a470f0a3a086c0fa525124bc6d/python/setup.py#L69
It looks like it supports building with arbitrary LLVM (https://github.com/openai/triton#building-with-a-custom-llvm), just not arbitrary versions due to breaking changes and whatnot.

I thought they had moved largely towards building LLVM HEAD

Well since we're bringing this up, there's actually even more divergence: upstream pytorch wheels are built against the HEAD of the fork of openai/triton, which in turn is built against the HEAD of LLVM. We're rebuilding llvm for pytorch anyway, maybe we should consider building the fork instead, to stay closer with upstream
As for the original issue, we probably just need to override llvmPackages.mlir to use this llvm: https://github.com/NixOS/nixpkgs/blob/378c0c69832c350f672a21128b5d2782a29c2d6e/pkgs/development/python-modules/openai-triton/default.nix#L31-L38

You may want to see the openai-triton changes in #258328.

Shouldn't this be fixed now?
Since openai-triton has it's own custom LLVM now?
Excluding torchWithRocm, which will probably always have rocm-llvm.

Yes, this might have been fixed. We need to inspect nix-tree (if not add an automated check...) before we close the issue

Inspected with nix-tree.
openai-triton only has one copy of LLVM.
torch has no copies of LLVM.
torchWithRocm only has an indirect copy of LLVM (rocm-llvm).

I'm afraid we may still be suffering from this issue: there's only rocm-llvm-llvm in the closure of python3Packages.torch, but there's both a rocm-llvm-llvm and an openai-triton-llvm in the closure of python3.withPackages (ps: [ ps.torch ]) which includes the propagatedBuildInputs:

https://gist.github.com/SomeoneSerge/e1688241ea9985a109bba24899834124#file-tree-txt-L550
https://gist.github.com/SomeoneSerge/e1688241ea9985a109bba24899834124#file-tree-txt-L444

Each is about 1.5GiB of added size judging by nix-tree

Ah. I didn't realize we had to use python3.withPackages for this.
Regular torch and torchWithCuda should be fine.
torchWithRocm unfortunately will have to stay with two copies, because we can't build openai-triton on rocm-llvm reliably. Thus, I don't think the issue needs to be reopened.


[WIP] pugixml: Fix pkg-config file installation and use fetchFromGitHub

Motivation for this change
Changes were merged into master after branch-off, this fixes the filezilla issues.
pugixml: Fix pkg-config file installation and use fetchFromGitHub
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

My local build is still in progress, I'll remove the [WIP] once the build is complete and I've verified that the binaries are working.

It builds, but fails to execute with a SIGSEGV. That's probably a conflict on my system, but I'd prefer if someone else could verify this.
$ LANG=C /nix/store/plac3bfdrqrmwz5ywlg6rdxwfq2pig63-filezilla-3.31.0/bin/filezilla
Reading locale option from /home/dfrank/.config/filezilla/filezilla.xml

(filezilla:10342): Gtk-WARNING **: 19:03:54.066: Unable to locate theme engine in module_path: "adwaita",

(filezilla:10342): Gtk-WARNING **: 19:03:54.070: Unable to locate theme engine in module_path: "adwaita",
Segmentation fault

@tokudan Could you maybe start this with an empty .config/filezilla?

I already tried that. I guess it's a conflict with my 18.09 installation or my specific Gnome/GTK configuration.
Since it works for @jokogr and since it's been approved by pSub, I guess it's ready for #56826 to fix the Filezilla failure.


[VideoConferenceMute] Opening Settings page crashes on master

Discovered during testing of #12372

Looks like we're using non-existing converter https://github.com/microsoft/PowerToys/blob/370e8c8574e6b5daff3e38ce75d33d8218548a13/src/settings-ui/Microsoft.PowerToys.Settings.UI/Views/VideoConference.xaml#L25

#11843 missed this

@Jay-o-Way thanks!

@yuyoyuppe there are some other things that haven't been implemented into the VCM settings page that were in the other pages due to not being part of master.
I can have a loot to make sure everything is on par with other pages in terms of XAML.

Hi @niels9001 ,
Trying to figure out https://github.com/microsoft/PowerToys/issues/12455 and this includes changing the logic that the setting page touches, as well.
Is it just the opacity change mentioned or did you notice something else?
I'll try to get it functional just to unblock testing https://github.com/microsoft/PowerToys/issues/12455

@jaimecbernardo I'll take a look at the VCM settings page tonight to make sure everything is integrated (e.g. missing converter). Then you can test that branch to see if the error goes away?

This is not what is causing https://github.com/microsoft/PowerToys/issues/12455 , it's just useful to have fixed to test.
I'll give it a quick try and get back to you if I find any issues. Thank you.

I've opened this PR: https://github.com/microsoft/PowerToys/pull/12459
It fixes just what is needed to get https://github.com/microsoft/PowerToys/issues/12455 testing unblocked for @yuyoyuppe .


iOS Amplify Cognito Auth Hosted Web UI for OIDC login does not show logo of app on iOS, but does show logo on web/browser

Describe the bug
When I open my Amplify Cognito Auth hosted web UI login screen on iOS it doesn't show a logo as I've put on there. It does show for web
How can I fix this? We'd like our users to know they're using a company approved login service by seeing the logo.

Steps To Reproduce
Setup a Cognito iOS/Amplify Auth service, launch/invoke Hosted Web UI sign in, no branding on iOS

Expected behavior
I should see a Logo of my app on iOS
Amplify Framework Version
1.9.3
Amplify Categories
Auth
Dependency manager
Cocoapods
Swift version
5.0
CLI version
not using
Xcode version
13.0 Beta 3 and 12.5.1
Relevant log output
No response
Is this a regression? (i.e. was this working before a version upgrade)
No
Device
iPad 9.7"
iOS Version
14+
Specific to simulators
No
Additional context
This ticket might belong elsewhere, please help submit this issue to the correct place if so! Thanks

where could I find assistance for this?

Thanks for reaching out, we have reached out to the service team to get more information regarding this.

Amazon Cognito does not support displaying provider logos for OIDC providers at the current time.
We have heard this request from other customers and will consider it in future updates to the service.


Insights - /metrics - DocumentDb - Metric Filter Parameter Issues

The "Consistency Level" metric only has two availabilities "PT1H" and "PT1D".  All other DocumentDB metrics have one additional availability: "PT5M".  This shouldn't be an issue, but it is.
Currently,  one must specify both a "timeGrain" and one or more "field names" (name.value eq ... ) in the $filter of an API call to get metric values.  If not for Consistency Level, I suspect this would not be required.
Moving forward, it would be preferable if only startTime and endTime were required (as is the case with SQL Database metrics).  If not possible, then it would be preferable if startTime, endTime and timeGrain were required (as is the case with web app metrics).
As it is today, to retreive all metric values of PT5M timegrain for a DocDB, there are two options:

Make one API call for each field, with a single name filter:  "...name.value eq 'Total Requests'"
Make a single API call for all fields, by creating a long filter string that includes all field names:   "...(name.value eq 'Total Requests' or name.value eq 'Http 2xx' or .... etc.) "

These are both highly inefficient.  It's worth noting that I tried using the "Not equal" filter (name.value ne 'Consistency Level'), but it returns "bad request".
I imagine that the intention is for a query featuring just the timeGrain to return all metric values that have that timegrain, and simply omitting the metrics which don't have that timegrain.  If so, it's a simple bug and fixing it will resolve this issue.  However, I could be wrong, and if so, please advise.
In any case, a working "Not Equal" (ne) filter operator would have minimized the inconvenience of issue, and provided a much more efficient workaround.
Finally, when using the powerhsell module, I discovered that it's impossible to retrieve the PT1H and PT1D metrics no matter how you filter.  You can only get them for Consistency Level.  It's probably a related side-effect, and will be fixed when the metric filtering is next updated.  However, please let me know if I should open this as a ticket on the powershell module project instead.
$endTime = Get-Date
$startTime = $endTime.AddMinutes(-20)
$timeGrain = New-TimeSpan -Hours 1
$metricNames = 'Total Requests'
$subsId = 'subscriptionidhere'
$rgId = 'resourcegroupnamehere'
$provider = 'Microsoft.DocumentDb'
$type = 'databaseAccounts'
$resourceName = 'databaseName'
$metricNames = 'Total Requests'
Get-AzureRmMetric -ResourceId $resourcePath -TimeGrain $timeGrain -DetailedOutput -StartTime $startTime -EndTime $endTime -MetricNames $metricNames

If you replace 'Total Requests' with 'Consistency Level' it works.

@asheniam can you take  alook?

Given that DocumentDb has been removed in favor of Cosmos, and the SDK has moved forward, can you please confirm this is still an issue?  If so, please provide more details on the problem, including all .NET libraries and their versions.


Uri class query parameters contains '?' char

While working on uri manipulations, see query params contains a '?' char, which should not be the case.
Not sure in when the split and assignment is happening, but seeing test failures due to this.

CC @whesse

I think https://codereview.chromium.org/2167573002/ is a fix for this.  I will land it, and cherry-pick it.

Closing as this was reverted. https://github.com/dart-lang/sdk/issues/26934 tracks bringing it back once test issues are resolved.

Could you please provide an example.

I have found the problem - it was in _SimpleUri.replace where the copy of the query includes the leading ?.


Getting API errors

First of all thanks for working on this github action - it's an amazing idea! :+1:
I'm having problems getting it to work - on most PRs it throws an API error. It looks like there's an issue generating the comments, which are sent to the github api.
Here is an example error:
Error: SyntaxError: Unexpected token ` in JSON at position 0
    at JSON.parse (<anonymous>)
    at /home/runner/work/_actions/freeedcom/ai-codereviewer/v2.1.0/webpack:/open-ai-reviewer/lib/main.js:146:1
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/freeedcom/ai-codereviewer/v2.1.0/webpack:/open-ai-reviewer/lib/main.js:28:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: RequestError [HttpError]: Unprocessable Entity: "Pull request review thread path is invalid and Pull request review thread diff hunk can't be blank"
    at /home/runner/work/_actions/freeedcom/ai-codereviewer/v2.1.0/webpack:/open-ai-reviewer/node_modules/@octokit/request/dist-node/index.js:78:1
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  status: 422,
...

This is possibly caused by an invalid file path value. There are some comments in the request with /dev/null as the path, eg:
{
  "body": "Consider adding a comment to explain the purpose of the `router` object.",
  "path": "/dev/null",
  "line": 31
},

So I guess this happens when the PR deletes a file - you should probably filter out any comments where file.to === '/dev/null'

Workaround is to add /dev/null to the exlcude setting in the yml file.

@dprentis thanks for reporting and debugging the issue! Indeed I probably haven't had yet situation where i've deleted a file so I haven't encountered the issue either. I probably check this out in the coming days. But as you already seem to be on top of the issue, don't hesitate to open a pull request!

In the spirit of this repo, I pasted the code and this issue thread to gpt-4 and let it to fix the issue for us :) btw. If you have ideas for prompt on how to discourage the bot to suggest commenting on code even more strongly, I'm all ears!

Thanks for the fix! :+1: Another solution might be to filter out directly here:
https://github.com/freeedcom/ai-codereviewer/blob/main/src/main.ts#L199
Something like:
const filteredDiff = parsedDiff.filter((file) => {
    return file.to !== '/dev/null' && !excludePatterns.some((pattern) =>
      minimatch(file.to ?? "", pattern)
    );
  });

Regarding blocking comments, possibly you could try somehow filter the bots output - but that might be a bit fragile :shrug:
Generally there are other limitations:

bot only sees the diffs, not the whole repo, so it doesn't have enough context to do an indepth review
bot processes individual diffs, and so eg. it doesn't know about the last diff when it processes the first one

Anyway, it's a great idea and likely to become really useful as the bot develops - good luck :+1: :smile:

Thanks for the fix! 👍 Another solution might be to filter out directly here:

Thanks! That could indeed be a better place, but I'm really tempted to let gpt-4 to develop this bot forward (and review it's own code along the way! 😅). Most of the bot code is actually written by gpt-4. I've only written some harder concepts (line numbers for diffs etc) and the actual prompts. Even the readme is fully generated by gpt-4 just based on the main.ts code I've pasted to it.

bot only sees the diffs, not the whole repo, so it doesn't have enough context to do an indepth review
bot processes individual diffs, and so eg. it doesn't know about the last diff when it processes the first one

This is what I've been thinking about. It is a balance between the prompt size and amount of context. Now it only reviews individual diff chunks, not even the whole pull requests at once. We could add all the diffs of the PR and pinpoint (e.g duplicate) the actual diff to review, but bigger PRs could start to fail, and too much context might actually be harmful and I've seen gpt-4 to get lost in the woods with too much context as well. Also, the bigger the prompt, the more costly it gets. gpt-4 is surprisingly pricey.
First stab was to include the PR description as a context. I'm also thinking on adding e.g some sort of dependency-graph or file structure in the prompt but not sure if they are much help. Somehow including more, if not all, from the PR could also make sense.

Hello, I am getting this error as well with v2.7.0
Run<EMAIL_ADDRESS>Error: SyntaxError: Unexpected token ` in JSON at position 0
    at JSON.parse (<anonymous>)
    at /home/runner/work/_actions/freeedcom/ai-codereviewer/v2.7.0/webpack:/open-ai-reviewer/lib/main.js:151:1
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/freeedcom/ai-codereviewer/v2.7.0/webpack:/open-ai-reviewer/lib/main.js:28:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)


[All OSes] Go 1.18.x will be removed on September, 18

Breaking changes
Go 1.17.x will be removed from all OSes.
Target date
Image deployment is starting on September 18 and will take 3-4 days.
The motivation for the changes
As of the software support policy only 3 latest versions of Go are supported.
Possible impact
If your builds depend on Go 1.17.x they execution time of the pipeline will become longer (as the go archive will be downloaded in runtime).
Platforms affected

[X] Azure DevOps
[X] GitHub Actions

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[X] macOS 11
[X] macOS 12
[X] macOS 13
[X] Windows Server 2019
[X] Windows Server 2022

Mitigation ways
To install any versions in runtime use:
https://github.com/actions/setup-go action for GH actions
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/go-tool?view=azure-devops task for AzDO

Could you please clarify whether Go 1.18.x (per the title) or 1.17.x (per the body) will be removed?

Fixed a typo :) 1.18 is meant to be removed

Fixed a typo :) 1.18 is meant to be removed

Thanks!

Breaking changes
Go 1.17.x will be removed from all OSes.

Still one left.

Removed


conda install dashit ?

can you please make a conda recipe for it all?
bioconda is the de facto standard system for bioinformtics software these days.
https://bioconda.github.io/contributor/index.html

Given the recent support of the Chan-Zuckerberg Initiative, I would expect all czbiohub tools to be on bioconda: https://chanzuckerberg.com/eoss/proposals/reproducibility-in-bioinformatics-by-sustaining-bioconda-development/
We are happy to help if needed... And, it will ensure a wider audience are able to take advantage of the tools.

Yes, we agree - a conda package is a priority. I tried my hand at an initial package, but couldn't successfully get it to build, seemingly because of the compiler requirements:
meta.yaml https://gist.github.com/EmperorDali/ac61e29b4bfcbfb75b90d2f5ccab1df3
build.sh https://gist.github.com/EmperorDali/8e9cf6be34b42f73b570e36a55245917
Feedback is appreciated.

Let me play around with these for a little bit. I think you are missing some important flags.

@andersgs any luck with the conda side of things?
In the meantime, I've added a Docker image with DASHit installed, which makes getting going pretty easy. Info in README.md


Passing user information to micro-services

Most recipe related payloads depend on the type of user requesting it. This is mostly because the API is used to administer entities from HQ, but also serve customer or public data. Of course, an HQ admin and a guest user won't receive the same payload when requesting the same entity, some properties are only served to admin users. Thus, we need to know what is the role of the user issuing a request to return the proper payload.
We believe we won't be the only one with this issue, managing subscriptions without user information is going to be tricky. Especially because customers can update their subscriptions, but admins too.
For performance and practical reasons, we'd rather not have to request a user service, or fetch the user's role, or id, from a database. Since the gateway is already storing the authentication token, could it store information related to the user too, or retrieve it somehow?
The ideal would be to receive X-User-Id and X-User-Role headers:
DELETE /recipes/580f10c5b0a36033a0640022 HTTP/1.1
X-User-Id: 123
X-User-Role: admin

I was checking HQ code and I think we are not using OAuth scopes properly, here is the HQ query:
return self::createClient()->login(
    "password",
    Config::get('clients.hellofresh_apiv2.username'),
    Config::get('clients.hellofresh_apiv2.password'),
    Config::get('clients.hellofresh_apiv2.client_id'),
    Config::get('clients.hellofresh_apiv2.client_secret'),
    "public,customer",
    "DE"
);

It uses "public,customer" when it should be using "admin" or something. We rely on what's in bob database for roles to determine the permission when we should be using scopes. Here is Slack documentation about scopes: https://api.slack.com/docs/oauth-scopes. They use grants such as channels:write but also perspectives such as user, bot, or admin. We should only check bob's user on authentication than store the resolved scopes with the token, and only care about them.

Solved with JWT

I can't find the user's role in JWT claims, is it in metadata? https://github.com/hellofresh/auth-service/blob/master/jwt/token.go#L17

This is probably not beeing set by API-v2 when creating a new user... If that's the case then we will need to migrate all the users again and add their roles to it. But this is not related to the gateway, please open a ticket in our Jira Dashboard


Audit for missing Cache-Control headers

All of the API endpoints use @never_cache to put explicit never-cache headers on the response.  There are a few other places which currently do not set any caching headers, but would benefit from the same set of never-cache headers, or short-term caching headers.
A couple such places are:

All of /activity/
Redirects, including the one from /login/ to the right realm (if the user has a cookie set).

Audit for all such places, and add appropriate caching headers.  For the redirects, we may want to write our own "redirect with no-cache" utility function.

@zulipbot claim

@zulipbot claim

Tagging as difficult since I think this sort of audit requires a lot of familiarity with the system to be useful.


stdlib: fix ThreadLocalStorage builds for Windows

Due to the build ordering, I didn't notice this earlier.  The inclusion
of the header would define the guard, preventing the needed definitions.
Unconditionally define the functions to ensure that they are available.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge

@swift-ci please test and merge


Replace SScript with BrewScript

This PR replaces the old and unavailable SScript with new lighter and faster BrewScript.
Old SScript scripts will not be affected as it has backwards compability plus including all features of SScript excluding conditional check support.
This PR also eliminates the need of using game while trying to access game variables.

I was joking

i'm trying to parse a chart with this new version but pushing into arrays seems to be incredibly slow, taking over 30 seconds
my code is pretty much identical to that of PlayState and this has been happening since the latest versions of SScript but never had any issue with hscript or with hscript-improved

i'm trying to parse a chart with this new version but pushing into arrays seems to be incredibly slow, taking over 30 seconds my code is pretty much identical to that of PlayState and this has been happening since the latest versions of SScript but never had any issue with hscript or with hscript-improved

please send issues specifically to this repository while providing a more general explanation of what happened, it'd be really useful for the development of brew and overall nicer to manage.

it faster than build with hscript-improved for about 8-12%, so its cool yeah (tried with pushing array by 500000 integers)
values from playstate with default types (as Int or Float) not updates, for example try (it will be return only 0), it will only work if you add game. to it:

function onUpdate() {
	debugPrint(songPercent);
}


[BUG] After revoked google drive backup and try backup again, can not choose different gmail.

Describe the Bug
After revoked google drive backup and try to backup again. The app will use gmail use last time automatically, can not choose use different gmail.
The demo video attached below.
https://github.com/Outblock/FRW-Android/assets/87978227/20277b30-7014-4e7c-9185-78f87ea3aca4
Expected experience
Allowed user choose different gmail to backup
Steps To Reproduce

Go to backup
Revoke google drive backup
Go to Backup
backup google drive again

Environment
-Android: 17

This issue already solved in Android dev version vDebug.
The demo video attached below. After revoked google backup, then backup again, the APP ask user to choose preferred google account.
https://github.com/Outblock/FRW-Android/assets/87978227/6d3b539d-5f6a-4e95-a6ea-545f9f36503f


Use better folder name for channel message exports

Libraries is what gets used for SP libraries and using channelMessages here did not look good.
Ref: https://github.com/alcionai/corso/blob/fe77c30e849307274d7d7f6570260fb6fab2a622/src/internal/m365/service/sharepoint/export.go#L49-L52

Does this PR need a docs update or release note?

[ ] :white_check_mark: Yes, it's included
[ ] :clock1: Yes, but in a later PR
[x] :no_entry: No

Type of change

[ ] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Supportability/Tests
[ ] :computer: CI/Deployment
[x] :broom: Tech Debt/Cleanup

Issue(s)

#

Test Plan

[x] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Let's hold off on this.  There's an alternative approach I'd like to try first.

@ryanfkeepers I've rebased it on top of #4282 and updated the implementation.


Replace bip32utils with our own BIP 32 public derivation

bip32utils appears to no longer exist. To replace it, I have implemented my own BIP 32 public derivation function. We only need the public derivation as we just need to derive from xpubs for getkeypool.

This will require someone more familiar with EC primitives to review the EC math.
Will test.

This will require someone more familiar with EC primitives to review the EC math.

point_add, point_mul, and point_to_bytes were taken from the Schnorr BIP.
deserialize_point was provided by sipa.

Ah.
tACK, with my noted issue fixed

tACK 2c2d1b49ac01f827b522a5ad24728f5754e2b02f


The Blank Redirection

Source information
The Blank Scanlation 1.4.37
Source language
English
Steps to reproduce
Opening source
Expected behavior
Should open source
Actual behavior
Redirects to discord invite link.
Mihon/Tachiyomi version
TachiyomiYS 1.10.5
Android version
Android 13
Other details
Tried different user agents but all direct to discord on all platforms. May be something they've done intentionally, or by accident; Unsure if that matters for the purposes of this extension.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

site is down

I was able to open the site exactly once before I made the ticket, which is what led to make to submit it. I suppose it might have loaded from cache which led to confusion. Thanks for the update.


Automated Package Upgrade

:tada: This PR is included in version 12.4.124 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add units to graphs shown on the side of images

Graphs currently do not indicate the data being shown. It would be great to have a way to show labels to the graphs and if possible the units on the graph.

Easy to do, the challenge is doing this automatically as very few tools populate NIFTI_INTENT_* so it would have to be supplied by the wrapper.
https://nifti.nimh.nih.gov/pub/dist/src/niftilib/nifti1.h
Chris Rorden, PhD
Endowed Chair of Neuroimaging
Co-Director, McCausland Center for Brain Imaging
Department of Psychology
University of South Carolina
Columbia, SC 29208, USA
email @.**
web www.mricro.com

On Oct 23, 2024, at 10:51 AM, Franco Pestilli @.***> wrote:
Graphs currently do not indicate the data being shown. It would be great to have a way to show labels to the graphs and if possible the units on the graph.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Complete move to Typescript

Our project started as a Javascript project and is gradually moving to Typescript.

[ ] Complete update of all .js files to .ts.
[ ] Fix all outstanding ESLint issues.

Just a note that issue #81 which I closed is related to this issue.

Thanks @arimus! Are you willing to submit your code as a PR?

I submitted a PR to share my code, but I have not extensively tested. I had trouble testing / setting up this project even after the successful import, but the commit shows how I was able to get a build that moves more to TS and properly works in a commonjs targeted application.