TypeError: chunk.charAt is not a function

Seems that the scxml.documentStringToModel func is somehow broken?
This code in node (latest):
var scxml = require('scxml')

var xml = `<scxml
    xmlns="http://www.w3.org/2005/07/scxml"
    version="1.0"
    profile="ecmascript"
    initial="draft">

    <state id="draft">
    </state>

</scxml>`

 scxml.documentStringToModel(xml, function(err, model) {
    if(err) {
        throw err;
    }
    console.log(model)
  })

gives the error:
bash-3.2$ node testInNode.js
/Volumes/TERA/Dropbox/code/scion-viz2/node_modules/sax/lib/sax.js:976
      result = chunk.charAt(i)
                     ^

TypeError: chunk.charAt is not a function
    at charAt (/Volumes/TERA/Dropbox/code/scion-viz2/node_modules/sax/lib/sax.js:976:22)
    at Object.write (/Volumes/TERA/Dropbox/code/scion-viz2/node_modules/sax/lib/sax.js:999:11)
    at transform (/Volumes/TERA/Dropbox/code/scion-viz2/node_modules/scxml/lib/compiler/scxml-to-scjson.js:296:12)
    at Object.documentStringToModel (/Volumes/TERA/Dropbox/code/scion-viz2/node_modules/scxml/lib/runtime/document-string-to-model.js:43:18)
    at Object.<anonymous> (/Volumes/TERA/Dropbox/code/scion-viz2/testInNode.js:15:8)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
bash-3.2$

It does the same thing in the browser. Using pathToModel seems to work ok.

ok, caused by a missing parameter in documentStringToModel
(the doco on the front page is wrong)

Thank, I added the missing parameter to the README.

while I've got you...  I'm having a lot of trouble actually getting a parsed statechart through that method - all I can seem to get are generated states.
For instance
var scxml = require('scxml')

var xml = `<scxml
    xmlns="http://www.w3.org/2005/07/scxml"
    version="1.0"
    profile="ecmascript"
    initial="draft">

    <state id="draft">
    </state>

    <state id="secondState">
    </state>

</scxml>`

 scxml.documentStringToModel(null, xml, function(err, model) {
    if(err) {
        throw err;
    }

    console.log(JSON.stringify(model))

    var s = new scxml.scion.Statechart(model)

    // what can I use to get at the states?

  })

prints
{"rootScripts":[],"module":{}}
And if I inspect in a debugger there doesnt seem to be any visible states.
I had previous code from an earlier version that would pass that model in to SCXML object (now Statechart), and list the states and transitions, how do you do that in the new API?

The SCION API changed from version 2 to 3. Please now do the following:
scxml.documentStringToModel(null, xml, function(err, model) {
  model.prepare(function(err, fnModel) {

    if(err) throw err;

    //instantiate the interpreter
    var sc = new scxml.scion.Statechart(fnModel);
  });
})

model.prepare re-downloads and injects script tags without re-parsing the SCXML.
I will update SCION so that it validates the fnModel argument and throws an error if it is invalid. I have created an issue to track this here: https://github.com/jbeard4/SCION/issues/379

Thanks, that would have helped track it down. This was a copy and paste of previous code without closely checking the new examples.
Couple of questions, if I may;

To get the states, I am using statechart_model.states.forEach and recursing through descendants.
Is _model now private, given the underscore, and is there a better way to do this?

Is there a way to relate the states and transitions back to the xml model? Eg a reference to the xml element that created the object? I'm guessing not given the compilation model.
I guess states always have to have an id, so I can just look them up in a DOM, but transitions etc don't.
The use case is I'm playing around with JointJS to make a drag-drop editor, where I want changes to the diagram to update the xml, and use that as the canonical source (not the json model etc).

From experimentation, it looks like custom attributes on elements are passed straight through, which is great. Is there any support for custom elements?
For instance, this is an example from the spec:

<scxml:transition event="email.send">
  <my:email to="data('_event')/scxml:property[@name='email']"
            cc="data('_event')/scxml:property[@name='xmlcontent']/h:headers/h:cc"
            subject="data('_event')/scxml:property[@name='xmlcontent']/h:headers/h:subject"
            content="data('_event')/scxml:property[@name='content']"/>
</scxml:transition>

And states and transitions can have any custom elements in my understanding?
The major use case for me is triggering reusable server actions, but I probably don't understand the scxml model well enough. Could possibly just use custom attributes on existing elements I guess.

To get the states, I am using statechart_model.states.forEach and recursing through descendants.
Is _model now private, given the underscore, and is there a better way to do this?
You might use this (undocumented) API to compile the SCXML to SCJSON:
scxml.ext.compilerInternals.scxmlToScjson(scxmlString)

Is there a way to relate the states and transitions back to the xml model? Eg a reference to the xml element that created the object? I'm guessing not given the compilation model.
I guess states always have to have an id, so I can just look them up in a DOM, but transitions etc don't.
You can use ids to map the states. Transitions can be mapped based on their parent state, and their order in the document.

Can you actually add states and transitions dynamically in SCION?
You can add states and transitions dynamically to an SCJSON, but once that is used to instantiate a simulator, updating the states and transitions of the SCJSON is not supported.

From experimentation, it looks like custom attributes on elements are passed straight through, which is great. Is there any support for custom elements?
This is not currently supported, but patches are welcome.


[METADATA UPDATE] Global metadata changes

This Pull Request was generated automatically as part of a global effort to improve metadata quality. Please review and merge this Pull Request within 5 days. If you have any questions or concerns about these metadata updates, please contact<EMAIL_ADDRESS>If you are not the correct contact for this content and repository, please notify<EMAIL_ADDRESS>Fixing#563840 Remove ms.prod value office365
If this Pull Request is not merged within 14 days, it will be automatically merged by our system to ensure the timeliness of the metadata update.Please notify<EMAIL_ADDRESS>if you would like Pull Requests for metadata updates to merge automatically in future.
After you accept changes of metadata used in reports and they're merged, standard dashboards and reports will reflect new values, so you'll need to use new filter values.If you have any custom dashboards or Kusto queries, you might need to update those also.
Why we make metadata updates
Metadata updates are a normal part of business.For example, we update our metadata to reflect a new product name when a product is rebranded.Metadata updates require content to be updated because some metadata values(slugs) are included in the content(YAML header).
For metadata used internally, these updates make reports cleaner, easier to use, more consistent, and more reflective of current business.For metadata exposed to Learn Platform users, these updates ensure our users are exposed to up-to-date information consistent with their overall Microsoft experience.
Frequently Asked Questions
Why does this Pull Request appear to be made by the Repository Owner? We open Pull Requests two different ways.For Git Repos with a permissioned Service Account, we open the request from our org's Service Account.For Git Repos that we either do not have Service Account permission for or the repo is in Azure Dev Ops(ADO) we are able to open the Pull Requests in an automated way, but only with the PR creator as the Repo owner.

Learn Build status updates of commit 7c336ca:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

officedocs-dev-o365-communications/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Documentation for extraVolumes option

Is your feature request related to a problem? Please describe.
I would like to see documentation or an example added showing how to use the extraVolumes configuration with the Logging CRD and fluentd.
Describe the solution you'd like
An example of how to correctly configure it similar to what is shown here: https://banzaicloud.com/docs/one-eye/logging-operator/configuration/fluentd/  for bufferStorageVolume.
Describe alternatives you've considered
I searched the source code, issues, and example and didn't find a place this is documented.  Also looked through the CRD definition file.
Additional context
I tried creating it the best I could and came up with something like below.  But when attempting to use it can't start fluentd.  I thought about filing a bug, but this isn't really a bug.  It is just a nice feature that isn't clear how to configure, so I think a documentation or example would be good.
apiVersion: logging.banzaicloud.io/v1beta1
kind: Logging
metadata:
  name: logging-demo
  namespace: logging
spec:
  controlNamespace: logging
  fluentbit:
    tls:
      enabled: true
      secretName: logging-demo-fluentbit-tls
      sharedKey: ""
  fluentd:
    logLevel: debug
    tls:
      enabled: true
      secretName: logging-demo-fluentd-tls
      sharedKey: ""
    extraVolumes:
      - path: "/data"
        containerName: fluentd
        volume:
          pvc:
            spec:
              accessModes:
                - ReadWriteOnce
              resources:
                requests:
                  storage: 30Gi
              storageClassName: logging-storage
              volumeMode: Filesystem

An helpful example could be configuring fluentd to store discarded chunks (/tmp/fluent/backup) in a PVC instead of on the host (ephemeral-config).

@aslafy-z Do you have an example of a working configuration for extraVolumes?  I never got past that point and instead started misusing the buffer volumes configuration instead.

Ow, so I misread your issue from the beginning. I thought this example was working on your side and you created this issue to track the addition of this extraVolumes key to the documentation. My bad :sweat_smile:
So I guess you hit the same issue as I reported in https://github.com/banzaicloud/logging-operator/issues/1063 isn't it? It's not working on my side either.

I ran into this as well recently. I want to add an extra volume to hold the log archives with file output. I can only create a PVC manually, along with the source directive under extraVolumes as a workaround. Here's my working example:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: log-archive
  namespace: logging
spec:
  storageClassName: longhorn
  accessModes:
  - ReadWriteOnce
  volumeMode: Filesystem
  resources:
    requests:
      storage: 1Gi

apiVersion: logging.banzaicloud.io/v1beta1
kind: Logging
metadata:
  name: default-logging-infra
  namespace: logging
spec:
  fluentd:
    disablePvc: true
    extraVolumes:
    - volumeName: log-archive
      path: /archive
      containerName: fluentd
      volume:
        pvc:
          source:
            claimName: log-archive
            readOnly: false
          #spec:
          #  accessModes:
          #  - ReadWriteOnce
          #  resources:
          #    requests:
          #      storage: 1Gi
          #  storageClassName: longhorn
          #  volumeMode: Filesystem
    fluentOutLogrotate:
      enabled: true
      path: /fluentd/log/out
      age: "10"
      size: "10485760"
  fluentbit: {}
  controlNamespace: logging

You were close but unfortunately this was a bug, should be fixed with:
https://github.com/kube-logging/logging-operator/pull/1304

@fekete-robert once this is merged, can I ask your help to include a right example in the docs?

Sure!
On Mon, 17 Apr 2023, 18:43 Peter Wilcsinszky, @.***>
wrote:

@fekete-robert https://github.com/fekete-robert once this is merged,
can I ask your help to include a right example in the docs?
—
Reply to this email directly, view it on GitHub
https://github.com/kube-logging/logging-operator/issues/1057#issuecomment-1511723583,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6AU3KWCZCCQ3MIOOELDZLXBVXJTANCNFSM54I7LJ2A
.
You are receiving this because you were mentioned.Message ID:
@.***>


Some of us hate kotlin, give us java back.

Description
So new versions of react-native have kotlin files instead of java
developers like me that rely heavily on making native modules, use java for this purpose and java has always been the go to language and will forever be the goto language. Some of us absolutely hate kotlin and we dont want to develop in kotlin. So maybe at least give us the option to choose betwen java or kotlin
and bring back create-react-native-app npm package
Steps to reproduce
yarn i
React Native Version
0.75.0
Affected Platforms
Other (please specify)
Output of npx react-native info
no react-native info neeeded

Stacktrace or Logs
No stack trace needed

Reproducer
http://localhost
Screenshots and Videos
No response

So maybe at least give us the option to choose betwen java or kotlin

You can totally use Java in your files as Java and Kotlin are interoperable. Just rename your files from .kt to .java and adapt the code to be compile for Java and you should be good to go.
We updated the default to be Kotlin, because that's where the mobile market was moving to.


Quick navigate + arrow keys moves two entries at a time

Press ctrl+tab, hold ctrl
Use arrow keys
The selection moves down two rows on each press

Probably not related to your change @Lixire but can you check if your new arrow key handler is involved somehow?

Looks like this is indeed my new arrow key handler's problem. I thought that the DOM.EventHelper.stop(e, true) would prevent things like this from happening though?

It will keep it from bubbling up to other elements but I don't think it should prevent it from calling other handlers on the same element. So I think the other listener must actually be on the same element.


Nexus 7 on win 10 won't start

..\scrcpy-win64-v1.12.1> .\scrcpy.exe
INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
..\scrcpy-win64-v1.12.1\scrcpy-server: 1 file pushed. 2.4 MB/s (26202 bytes in 0.010s)
[server] ERROR: Exception on thread Thread[main,5,main]
android.media.MediaCodec$CodecException: Error 0xfffffc0e
        at android.media.MediaCodec.native_configure(Native Method)
        at android.media.MediaCodec.configure(MediaCodec.java:1778)
        at com.genymobile.scrcpy.ScreenEncoder.configure(ScreenEncoder.java:167)
        at com.genymobile.scrcpy.ScreenEncoder.streamScreen(ScreenEncoder.java:68)
        at com.genymobile.scrcpy.Server.scrcpy(Server.java:34)
        at com.genymobile.scrcpy.Server.main(Server.java:163)
        at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
        at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:251)
[server] ERROR: The hardware encoder is not able to encode at the given definition.
[server] ERROR: Try with a lower definition:
[server] ERROR:     scrcpy -m 1024
INFO: Initial texture: 1200x1920
WARN: Device disconnected
Press any key to continue...

With the suggested extra option, it runs perfectly.
..\scrcpy-win64-v1.12.1> .\scrcpy.exe -m 1024
INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
..\scrcpy-win64-v1.12.1\scrcpy-server: 1 file pushed. 2.5 MB/s (26202 bytes in 0.010s)
INFO: Initial texture: 640x1024

See https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#i-get-an-error-could-not-open-video-stream

That's what I said. The suggested option -m 1024 works. But is there not an auto-detect system, where this exception can be mapped in?

That's what I said.

Yes, but there was no question, so I just linked to the explanation.

But is there not an auto-detect system, where this exception can be mapped in?

That's what 8a694a97855333849976bea5e558eaa45add0168 does to suggest a fix. It does not use -m 1024 automatically in that case, because it's up to the user to use the value they want (-m 1280, etc.) until the hardware decoder refuses.

Ahh, I see. My fault indeed.
Ah, but is it an option to try the different definitions for, let's say, two or three steps down? I did run it by hand (as a developer myself) to see the error and suggestion. But not every user is gonna try this.


Removed EditorHelp::_scroll_changed

Fixes #10553

This will leave a broken signal connection: https://github.com/Rubonnek/godot/blob/d250e5000a8cd39616109b8f32a03a9d4d67970e/editor/editor_help.cpp#L1705

Thanks for pointing it out.


Doxygen

Adding doxygen elements to go_fish + Doxygen file.
To generate new Doxygen files:

doxygen -f
Upload the new /html folder to Github pages: gh-pages branch

Will reopen when I have sphinx integrated


Escape & in livereload injected code

Whilst potentially valid for HTML5 under certain conditions, URLs should be encoded properly. This PR changes
<script src="/livereload.js?port=%d&mindelay=10&v=2" data-no-instant defer></script> to
<script src="/livereload.js?port=%d&mindelay=10&v=2" data-no-instant defer></script>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update testcontainers-scala-scalatest to 0.40.2

Updates com.dimafeng:testcontainers-scala-scalatest from 0.39.12 to 0.40.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.dimafeng", artifactId = "testcontainers-scala-scalatest" } ]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

Superseded by #90.


Wrong Emotions Detecting

I tried the code on my machine, and it's giving wrong emotional labels for almost every situation. If I am smiling, it will show me sad or angry etc.

When you are using the webcam mode, make sure that you are looking straight at the camera for best results. The training data is taken from KDEF dataset but I only use photos where the person is looking straight at the camera.

I was looking straight into the camera. Tried to change the lighting as well. Also, I checked the image mode, and still, it wrongly labeled a happy face as a neutral one.

You can try to add more data to training example. The model sometimes gives me wrong result too because training data is mostly white or Caucasian people. Here is an article about racial bias in facial recognition

Closed due to inactivity


Support Debian package build on ARMv7l architecture

It now does not build as debian/rules does not launch the configure script. This should fix that.

Could someone please merge that? We'll have arm build in Ubuntu PPA then.

Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.
SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

Sure, I choose 1st option. I allow to apply the same patch into PacketiX VPN.

I'll enable new build architecture for PPA today.

Thank you so much for your contribution to enrich the SoftEther VPN source code.
Your patch has been merged on the main source-tree of SoftEther VPN.
As a token of our gratitude, your GitHub username has been added on the AUTHORS.TXT file and on the header of the related source file.
Please see: https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/AUTHORS.TXT
Thanks again for your contribution.


Find all references in TS is off by 1 line in this specific case

git checkout c2d75edf8a7
open our repo in vscode
while vscode is starting up simulate doing git pull by doing git checkout 3f0f51bde08
open src/vs/editor/common/viewModel/viewModelImpl.ts and be sure not to open any other files
reload window
find all references on ViewModel ctor (line 45)
observe that the references in codeEditorWidget.ts point to 1 line above
(it was hard to reproduce)

I haven't been able to reproduce this. @alexdima are you still able to hit this using the latest TS builds?

Appologies for the slow reaction here. I have created a new issue because I could still reproduce.


Fixed systemtests

Type of change

Bugfix
Refactoring

Description
Fixed system tests

Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests testcase=shared.standard.web.FirefoxConsoleTest

:heavy_exclamation_mark: Build Failed :heavy_exclamation_mark:

@enmasse-ci run tests profile=shared testcase=web.**

obviously build failed on checkstype in GH actions too, so it does not make any sense to restart jenkins, because it will fail on same error

:heavy_exclamation_mark: Build Failed :heavy_exclamation_mark:

obviously build failed on checkstype in GH actions too, so it does not make any sense to restart jenkins, because it will fail on same error

@kornys , could you please take a look on this build.

@enmasse-ci run tests profile=shared testcase=*ConsoleTest

:heavy_exclamation_mark: Build Failed :heavy_exclamation_mark:

Again could you please tell me why do you still restart build? It will always fail until someone make a fix for checkstyle.

As we said with Ulf check checkstyle.xml output, you will see why checkstyle fails

@enmasse-ci run tests testcase=*ConsoleTest

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 82
PASS: 69
FAIL: 7
SKIP: 6
BUILD_NUMBER: 586
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testSortAddressesByName in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testFilterLinksByName in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testFilterAddressesByStatus in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testSortConnectionsBySenders in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testFilterConnectionsByContainerId in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testSortAddressesByName in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testFilterAddressSpace in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest

@enmasse-ci run tests testcase=*ConsoleTest

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 82
PASS: 71
FAIL: 5
SKIP: 6
BUILD_NUMBER: 594
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testFilterAddressesByName in io.enmasse.systemtest.shared.brokered.web.FirefoxConsoleTest
testFilterLinksByName in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testFilterAddressesByName in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testDeleteFilteredAddress in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testFilterAddressSpace in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest

@enmasse-ci run tests testcase=*ConsoleTest

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 82
PASS: 75
FAIL: 1
SKIP: 6
BUILD_NUMBER: 596
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testAddressStatus in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest

@enmasse-ci run tests testcase=*ConsoleTest

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 82
PASS: 76
FAIL: 0
SKIP: 6
BUILD_NUMBER: 597


fix: system default as the theme mode

resolves #726

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.706%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1257

Relevant Lines:
5082

💛  - Coveralls

My pleasure to be of help!


Unstructured lifelong learning with cloud robotics example

Future work:

Add base class of algorithm modules
Add docs
Dataset of this example
Add annotations of server.py

/lgtm

/lgtm

/approve


Renamed OpenAI class to OpenAIKit

Describe your changes

renamed OpenAI class to OpenAIKit
renamed OpenAI to OpenAIKit in Examples

Issue ticket number and link
#42  - https://github.com/MarcoDotIO/OpenAIKit/issues/42
Checklist before requesting a review

[v] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics?
[v] Will this be part of a product update? If yes, please write one phrase about this update.
"Renamed class OpenAI to OpenAIKit in order for Module to reflect Package name"

Fork is currently out of date, please pull from v2.0 and reimplement the PR

Nevermind, seems like you already did the rename, thanks for reviewing :)


Monkey Madness II Missing info

In "Defeating Trolls and Ogres" it does not say that you need to bring 20gp to get to Keef if your agility is under 71.

Fixed in 6fe9c0e78b2f65235310c546cd9c2db1a6bbee81


[WIP] Add WDYR kill some inline anonymous functions

Details

Adds WYDR for analyzing unnecessary re-renders
Eliminates some anonymous functions and unnecessary component re-renders
Random maintenance like missing docs, typos, etc

Fixed Issues

Fixes GH_LINK
Tests
QA Steps
Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

I might bring this back with the WDYR changes only but want to propose it first. Not a priority right now.


Feature request: Add option to always show Tags option

Using Linkwarden I normally sort what I'm saving into a collection, but I always select a tag. For my workflow, it would be a lot more seamless if I wasn't required to select 'More Options' every time I want to add a tag. Here's some potential solutions sorted by most ideal solution first.

Add toggles in the extensions 'Options Configuration' menu for each extra field (e.g. Tags, Name, Description). To enable or disable what is shown by default and not hidden in 'More Options'.

Add a toggle in the extensions 'Options Configuration' menu to always show the 'More Options' settings (e.g. Tags, Name, Description).

Remember the 'More Options' visibility state. If a user has previously selected 'More Options', the next time the user interacts with the extension, 'More Options' settings should already be visible. Less ideal solution.

Solved on fc67def50167a6cbacb6cd990ad52ba226cfd9eb


How to analyse this log with GoAccess?

How I can use this log format:
head -n 10 core.20180322.log

Mar 22 00:00:00 (info) appsse[49343] [localhost] [ E ] [14c9606a2d485027] [vapp07] Started GET "/status/gesundheit" for <IP_ADDRESS> at 2018-03-22 00:00:00 +0100
Mar 21 23:59:59 (info) appsse[838] [localhost] [ E ] [6c39814e49c0394d] [vapp04] Started GET "/wlw/status/health" for <IP_ADDRESS> at 2018-03-21 23:59:59 +0100
Mar 21 23:59:59 (info) appsse[38988] [localhost] [ E ] [05c4da4cf117810c] [vapp03] Started GET "/wlw/status/health" for <IP_ADDRESS> at 2018-03-21 23:59:59 +0100
Mar 22 00:00:00 (info) appsse[19100] [localhost] [ E ] [ddba40121fa4b56a] [vapp02] Started GET "/wlw/status/health" for <IP_ADDRESS> at 2018-03-22 00:00:00 +0100
Mar 22 00:00:00 (info) appsse[49343] [localhost] [ E ] [0513631c23dfdb23] [vapp07] Started GET "/wlw/status/health" for <IP_ADDRESS> at 2018-03-22 00:00:00 +0100
Mar 22 00:00:01 (info) appsse[41883] [localhost] [ E ] [7e104f61dbaa756f] [vapp01] Started GET "/status/gesundheit" for <IP_ADDRESS> at 2018-03-22 00:00:01 +0100
Mar 22 00:00:01 (info) appsse[43253] [localhost] [ E ] [3b7615971bd6041c] [vapp08] Started GET "/status/gesundheit" for <IP_ADDRESS> at 2018-03-22 00:00:01 +0100
Mar 22 00:00:01 (info) appsse[43253] [localhost] [ E ] [4919ac5690f0f3ae] [vapp08] Started GET "/wlw/status/health" for <IP_ADDRESS> at 2018-03-22 00:00:01 +0100
Mar 22 00:00:00 (info) appsse[8607] [localhost] [ E ] [9bae56272e91a0ba] [vapp05] Started GET "/status/gesundheit" for <IP_ADDRESS> at 2018-03-22 00:00:00 +0100

Please try this:
goaccess access.log --log-format='%^) %e[%^] %^[ %^[ %^[ %^[%v] %^ %m "%U" %^ %h %^ %d %t %^' --date-format=%Y-%m-%d --time-format=%T --ignore-panel=OS --ignore-panel=BROWSERS --ignore-panel=REFERRING_SITES --ignore-panel=STATUS_CODES --http-protocol=no

Closing this. Feel free to reopen it if needed.


if second struct's field is float64, then define float64

input

[{
	"UserId" : [ 10 ]
}, {
	"UserId" : [ 12.3 ]
}]

current output:

type AutoGenerated []struct {
	UserID []int `json:"UserId"`
}

expected output:

type AutoGenerated []struct {
	UserID []float64 `json:"UserId"`
}

This shares the same cause as #26 : the parser only considers the first instance of a key-value pair it encounters. This is time- and space-efficient.
I've been playing with solutions, but they're all complicated.
The way I see it, we need an intermediary AST-like layer (probably) represented as native JavaScript objects/arrays) that contains only type information. As the parser traverses the rest of the available data, it would update/narrow that intermediary type layer, which would then be used to generate the final struct{}s.
Implementing that is probably not trivial.
This requires type precedence rules. In the case of this issue, float wins over int clearly, as would int64 over int, because that information is lost when converting even a well-defined structure to JSON. I suppose interface{} would be needed in the case of #26 because Go can't unmarshal a string into a numeric type, making that the fall-through case.


Several Suggestions on "Localsend"

Dear Localsend software developer, I am an ordinary user who is not very familiar with software programs. I would like to make a few suggestions to you: (This article was translated into English through translation software, so some content may not be accurate)
Firstly, I would like to add the feature of "automatically connecting and transferring files" in localsend. The specific operation of this function is: when using computer hotspots as a network, the local send of different devices can be connected to each other, and the information of other devices can be saved and remembered in the local send. This information can be kept in the local send of all connected devices at all times. At some point in the future, when transferring files from a mobile phone to a computer (when the phone is not connected to a computer hotspot), when selecting a file from the phone, select the device you want to transfer the file to from the different device information saved before localsend, such as selecting a computer. At this time, localsend on the phone will automatically connect to the computer hotspot and transfer the file to the computer. After transferring the files to the computer, a pop-up window will appear on localsend, allowing us to choose whether to continue connecting to the computer hotspot or restore the network status before transferring the files (this can also be set in advance in the settings).
Secondly, it is hoped that the local send computer can add a floating transparent status bar function, so that file transfer status can be checked at any time.
Thirdly, we hope that the local send computer can be equipped with a transparency function to enhance the aesthetics of the UI.
Fourthly, in certain circumstances. When transferring files from a mobile phone to a computer, there may occasionally be cases where the transferred files are damaged. Sometimes, the file name received by the computer may be displayed as "114090" (the number here is an example), and the files may be damaged. I hope this type of problem can be improved.
Fifthly, due to the existence of numerous mobile phone brands in the market, sometimes selecting files from the built-in file management software of the phone and sharing them through LocalSend may cause LocalSend to crash. I hope that future versions can optimize different mobile phone brands and improve stability. For example, vivo, IQOO, Oppo, Realme, Xiaomi, Redmi, Oneplus, Huawei, etc.
Here, we would like to express our gratitude once again to the developers of the LocalSend software for their efforts. We hope that LocalSend can continue to optimize and thank all the software developers in the open source community!!!

Thank you. Because your issue is a set of smaller issues, developers are less likely to fix this.
The damaged files is important to fix. However, we need more information like kind of files, sending device, receiving device

希望开发者能在应用里面直接添加一个检查更新 这样可以直接联网更新希望开发者能够采纳

I hope that the ability to send directly using the context menu in Windows will be added soon.


[hotfix][config][docs] Deprecate taskmanager.numberOfTaskSlots in mesos_task_manager_configuration.html

What is the purpose of the change
Deprecate taskmanager.numberOfTaskSlots in mesos_task_manager_configuration.html

cc @TisonKun

Close as stale. The problem seems vanished.


Missing escape/unescape ?

TypeScript Version:
1.8
Code
var a = escape("&#");
var b = unescape(a);

Expected behavior:
no error
Actual behavior:
can not find name 'escape'
can not find name 'unescape'
by the way, typescript playground  experience is terrible when use Microsoft Edge (input  chinese charactors , click a new line , select code)

The global escape and unescape are deprecated, please use encodeURI instead. see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape.
If you want to use them, just add the definitions:
declare function escape(s:string): string;

The global escape and unescape are deprecated, please use encodeURI instead. see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape

@mhegazy It seems nothing refer to that they are deprecated ?

@k8w those pages used to refer to it being deprecated, and it was.  It does not appear to be deprecated in the current standard though, and I can't find a specific reference to why the change was made. I suspect they were retained in the specification to not break code, but you shouldn't be using them for new code as they don't handle Unicode URIs properly, and so IMO they are best to leave out and people can add them back in if they are supporting old code.

those pages used to refer to it being deprecated, and it was. It does not appear to be deprecated in the current standard though, and I can't find a specific reference to why the change was made.

That is my recollection as well.. good that i am not crazy :)
I checked with @bterlson, and seems that back then there was a proposal to deprecate Annex B (where all previous mistakes have lived), but then that did not happen. i am assuming that why the deprecation notice was added, then removed.
That said, i do not think we should be in the business of policing ppl's use of APIs. the library should be an accurate model of the JS engine at runtime.. reopening.

That is the intention of Annex B, but node supports it as well as all main browsers.. so it is really a standard..
we can have a @deprecated message on it in a comment.

A pragmatic viewpoint is better than one informed by the letter of the standard IMO. I came down on the side of supporting escape/unescape in lib.d.ts because in practice these APIs are supported universally across script engines and used heavily across the web and, despite what Annex B hoped, aren't going anywhere afaict. On the other hand, not having these APIs in lib.d.ts is likely to cause friction and may not prevent people from using it, and may not be effective at driving people toward better APIs.
I also note that we have other things from Annex B in lib.d.ts already, including my best friend String.prototype.blink! I feel like encode/decode should be in too unless we really want to stand on the principle that these APIs are just so bad they should not be used. Annex B shouldn't really factor in to this decision.

Compromise at #19299

We could also split the baby again by making people write window.escape 🤷♂

My opinion is that it is a good compromise with #19299.  Splitting the baby again with window.escape feels a bit anti the spirit.  For greenfield development, people will (should) be none the wiser of AnnexB.  Those supporting legacy code or wanting 👣 🔫  can do so with a little bit of work.  window.escape might appropriately annoy those proactively using 👣 🔫  but the poor souls trying to support there legacy code bases without a huge amount of friction would be disserviced.

@mhegazy @RyanCavanaugh escape / unescape are useful exactly because they don't support UTF-8. decodeURIComponent(escape(s)) and unescape(encodeURIComponent(s)) are, even if imperfect, very common and established "patterns" to decode / encode UTF-8 across all browsers including pretty ancient ones.

escape / unescape are useful exactly because they don't support UTF-8.

Apart from older browser support, can you explain why that makes it useful? 😄

@DanielRosenwasser Now I'm not sure what you mean, but yeah, it's possible we're talking about the same thing 😄

In Angular, if the spliced routing parameter contains '(', ')', encodeURI/encodeURIComponent is not properly encoded, but escape can encode it.

This was already fixed by https://github.com/microsoft/TypeScript/pull/19015 , cc @jakebailey

Makes me sad actually 🥲

Well they're marked as @deprecated if it makes you feel any better!


[RFE]  Adding support for Web assembly with sysext

Adding support for Web assembly with sysext using the leanest Flatcar image
there is already a a "recipe" for an image using wasmtime
https://github.com/flatcar/sysext-bakery/blob/main/create_wasmtime_sysext.sh
notes: wasmtime = mozilla/fastly 12-15Mb, wamr = Intel, 3MB

For containerd to start wasm containers we would also need some shim like https://github.com/containerd/runwasi

We should first improve the sysext-bakery image to include all that's needed.
Then we can explore building an official Flatcar extension: Build the runtime and shim as part of the image build and publish as release artifact and as signed update payload.

I'm busy building out a ton of layers for use with the wasm ecosystem now. Over the weekend we can see about PRing back here.


upstream sync 180607

This is the PR to hold upstream sync on 180607.

@parallelo Let's use this upstream sync PR to once again test how CI works.

Sounds good.  Btw - PR#16 dropped our build+test time from ~2hrs to down under 1 hr.  Will be looking at utilization to see if there are other tweaks we can make improvements on.

Looking at build error:
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/util/Memory.h:168:37: error:  'Eigen::internal::handmade_aligned_malloc':  no overloaded function has restriction specifiers that are compatible with the ambient context 'aligned_malloc'

Strangely speaking Eigen used in develop-upstream branch is the same as the current tip, but we are only bumping into this issue here. Looking into it now.

@parallelo CI says:
Executed 471 out of 471 tests: 462 tests pass and 9 fail locally.

Could you guide me how to siphon out failures from CI build logs?

Here's the crude way of looking deeper.

Go to the full log:  http://<IP_ADDRESS>:21096/job/tensorflow-upstream-unit-tests/83/consoleText
Find the 462 tests pass and 9 fail locally metric at the bottom
Search for 'failed' and do some manual filtering

//tensorflow/python:function_def_to_graph_test                           FAILED in 105.3s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/function_def_to_graph_test/test.log
//tensorflow/python:gradient_descent_test                                FAILED in 92.0s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/gradient_descent_test/test.log
//tensorflow/python:momentum_test                                        FAILED in 133.1s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/momentum_test/test.log
//tensorflow/python/keras:models_test                                    FAILED in 82.1s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/keras/models_test/test.log
//tensorflow/python/keras:training_test                                  FAILED in 96.4s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/keras/training_test/test.log
//tensorflow/python/kernel_tests/distributions:beta_test                 FAILED in 50.4s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/kernel_tests/distributions/beta_test/test.log
//tensorflow/python/kernel_tests/distributions:dirichlet_test            FAILED in 116.2s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/kernel_tests/distributions/dirichlet_test/test.log
//tensorflow/python/kernel_tests/distributions:student_t_test            FAILED in 78.2s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/kernel_tests/distributions/student_t_test/test.log
//tensorflow/python/keras:cudnn_recurrent_test                           FAILED in 2 out of 2 in 114.8s
  Stats over 2 runs: max = 114.8s, min = 114.2s, avg = 114.5s, dev = 0.3s
  /var/lib/jenkins/workspace/tensorflow-upstream-unit-tests/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/testlogs/tensorflow/python/keras/cudnn_recurrent_test/shard_2_of_2/test.log

Would be useful if we could create this summary without having to spend time digging.  I'm sure other folks have already done it -- will look around for improvements here.

As a follow-up, to reproduce an individual issue using the same setup, you could run the following from the top of the tensorflow-upstream repo:
tensorflow/tools/ci_build/ci_build.sh ROCM bazel test -c opt --config rocm //tensorflow/python/keras:training_test

This command will start a docker container and kick off the test.

initial analysis:
| //tensorflow/python:function_def_to_graph_test |
| //tensorflow/python:gradient_descent_test |
| //tensorflow/python:momentum_test |
| //tensorflow/python/keras:models_test |
| //tensorflow/python/keras:training_test |
| //tensorflow/python/kernel_tests/distributions:beta_test |
| //tensorflow/python/kernel_tests/distributions:dirichlet_test |
| //tensorflow/python/kernel_tests/distributions:student_t_test |
| //tensorflow/python/keras:cudnn_recurrent_test |

@sunway513 per discussion with @dagamayank, will need your help to continue look into failing TensorFlow unit tests. I think reviewing failing tests introduced in this PR could be a good start.

@whchung sounds good.

@parallelo I modified ci_build to mask 9 failed cases introduced in this PR:
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/commit/bdc94ff54ceb72ae075d3537d69ab2f51194c30f
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/develop-upstream-sync-180607/tensorflow/tools/ci_build/linux/rocm/run_py3_core.sh
But it seems the very latest CI build didn't pick it up:
http://<IP_ADDRESS>:21096/job/tensorflow-upstream-unit-tests/86/
http://<IP_ADDRESS>:21096/job/tensorflow-upstream-unit-tests/86/consoleFull
Could you help shed some lights on this? Would CI server use the run_py3_core.sh supplied in the PR, or it uses its own copy?

@parallelo moreover is it possible to force trigger a build for this CI?

retest this please

retest this please

retest this please

retest this please


[benchmark] Disable inlining of wCSIA in benchmark

... which gives us a better feel for when contiguity is unknown at the
call site.

@swift-ci please benchmark

@swift-ci please smoke test

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

String.data.Small
26
28
+7.7%
0.93x (?)

PrefixArrayLazy
13
14
+7.7%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

ObjectiveCBridgeStubToNSDate2
350
320
-8.6%
1.09x (?)

ObjectiveCBridgeStubToNSDateRef
2280
2120
-7.0%
1.08x (?)

Code size: -O
Performance: -Osize
Code size: -Osize
Performance: -Onone
Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB


cmd: Allow to filter metrics with regexp

This change adds the --matchpattern/-p argument to the cilium metrics list commands which allows to filter metrics by names.
Example:
$ cilium metrics list -p nodes
Metric                                        Labels                                Value
cilium_nodes_all_datapath_validations_total                                         37.000000
cilium_nodes_all_events_received_total        eventType="add" source="kvstore"      1.000000
cilium_nodes_all_events_received_total        eventType="add" source="local"        1.000000
cilium_nodes_all_events_received_total        source="kvstore" eventType="update"   4.000000
cilium_nodes_all_num                                                                2.000000
cilium_unreachable_nodes                                                            1.000000

Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>cmd: Allow to filter metrics with regexp

test-me-please

Coverage increased (+0.001%) to 36.998% when pulling a640d3b2adf9e6c08e714d49fc14d24fe9ec5f3f on mrostecki:cmd-metrics-filter into 2aae98893851b4248271218d438758250f9dd8c2 on cilium:master.

test-me-please


Make FluentSQLite usable on iOS

The two most popular options for persistence on iOS (Realm and Core Data), both rely heavily on Objective-C, however, SQLite is available. I think there is a good opportunity to not only have a Swift based persistence layer on iOS, but also promote code sharing between Vapor servers and iOS clients.
Concept:
// Shared models package, imported by both client and server
class User: Codable {
  let id: Int?
  let name: String
  let age: Int
}

// Client
extension User: SQLiteModel, Migration {}

// Server
extension User: PostgresModel, Migration {}

I haven't heavily investigated what is keeping users from utilizing FluentSQLite in their iOS apps, but the first thing that comes to mind is the Console package's use of Process()

Would also need to support CocoaPods and Carthage unless we want to hold this off until WWDC and make a bet that SPM will finally be integrated into Xcode

Technically it's possible to use SPM with iOS apps if we wanted to for testing, but it's really hacky and I'd definitely advise against it in production
https://www.ralfebert.de/ios-examples/xcode/ios-dependency-management-with-swift-package-manager/
Got a macOS Cocoa app running with FluentSQLite using that method

Good news! Process was the only thing preventing this package from being compiled for iOS. It's used in one method in Console and extended in Core, and neither that method nor that extension are used in this package. After wrapping those two in #if os(OSX), the package compiles just fine. Trying  to figure out how to import it into an iOS project now.

Well, that’s simple ... convert this and all subsequent projects (might not be necessary) and make them each an xcode project ... adding that I think will be the biggest challenge to get through the NIO guys and Tanner ... ;) unless we’ll get lucky this WWDC

Its a swift wrapper around a c library so that one might be tricky, you might have to do some header/modulemap magic to get that to work

vapor/sqlite now uses the SQLite3 module available on iOS and macOS (still uses CSQLite on Linux).

Tests appear to be passing when run on iPhone X simulator. Let me know if you guys manage to get it working in a real iOS project. Closing this issue for now. 👍

Were you also seeing these warnings?

@twof I didn't see those in my build. Maybe the NIO guys would know more.

@kdawgwilk

Would also need to support CocoaPods and Carthage unless we want to hold this off until WWDC and make a bet that SPM will finally be integrated into Xcode

looks like they did it 🎉🎉🎉
I've been able to use it in an iOS project, and it just works! (Well, there is one slight edit I needed to make)
cc @tanner0101

Does anyone have the steps of getting this to work on iOS? Is there official support for it now? I looked in the swift package and the platform only specifies Mac_os ?
Any ideas @broadwaylamb @twof  ?
Thanks!

Does anyone have the steps of getting this to work on iOS? Is there official support for it now? I looked in the swift package and the platform only specifies Mac_os ?
Any ideas @broadwaylamb @twof ?
Thanks!

I managed to add https://github.com/vapor/fluent-sqlite-driver.git as a package dependency to a new iOS single-view application project and import FluentSQLite. The build was successful, but after that I'm not sure what to do.
I tried SQLiteDatabase() but I'm guessing we need some way to connect to the database in order for it to work.
I think a lead to the right direction on making FluentSQLite work on iOS will be much appreciated.

@alobaili @ismyhc Check out this example: https://github.com/twof/iOSFluentExample/blob/master/iOSFluentApp/iOSFluentApp/ContentView.swift
The syntax might be slightly out of date because I created this demo while everything was still in beta, but the principles should still be correct.


feat: Add healthcheck

Adds health check to plugin, and adds types for all settings.

@jakubbortlik Take a look at this when you have a moment. It sets up types for the plugin so folks can get a nice autocomplete and warnings when configuring it, and adds a healthcheck as well!


I need to manually refresh the web page when I use the “redirect” function

When I go from a web application to a Jupyter application on a new port using the "redirect" function, I need to manually refresh the page to open it. Is there an automatic refresh method?
The following is my server key code：
def open_comment(comment_id):
    comment = Comment.query.get_or_404(comment_id)
    docker.from_env().containers.get(comment.body).restart(timeout=10)
    host = request.host.split(':')[0]
    url = "http://" + host + ':' + str(comment.port) + '/lab'
    return redirect(url)

The following is my client key code：
<form class="inline" method="post" target="_blank"
      action="{{ url_for('.open_comment', comment_id=comment.id) }}">
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
<button type="submit" class="dropdown-item">
     Open
</button>
</form>

I can't reproduce your issue on my side, the redirect() function works as expected. You can test it by simplifying your code :
from flask import redirect

@app.route('/comment/<int:comment_id>', methods=['GET', 'POST'])
def open_comment(comment_id):
    return redirect('https://github.com')

Please use Stack Overflow for questions about your own code. This tracker is for issues related to the project itself. Be sure to include a minimal, complete, and verifiable example.


Update README.md

Docs Build status updates of commit bae3083:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[SPARK-11787] [SQL] Improve Parquet scan performance when using flat schemas.

This patch adds an alternate to the ParquetRecordReader from the parquet-mr project
that is much faster for flat schemas. Instead of using the general converter mechanism
from parquet-mr, this directly uses the lower level APIs from parquet-columnar and a
customer RecordReader that directly assembles into UnsafeRows.
This is optionally disabled and only used for supported schemas.
Using a benchmark that just sums columns reading from a 1SF TPCDS store_sales table,
I measured the rates of the entire query:
For 1 Column:
Before: 11.3M rows/second
After: 18.2M rows/second
For 2 Columns:
Before: 7.2M rows/second
After: 11.2M rows/second
For 5 Columns:
Before: 2.9M rows/second
After: 4.5M rows/second

Test build #46198 has started for PR 9801 at commit b6a3b62.

Test build #46198 has finished for PR 9801 at commit b6a3b62.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * public abstract class SpecificParquetRecordReaderBase<T> extends RecordReader<Void, T> \n  *  abstract static class IntIterator\n  *  protected static final class ValuesReaderIntIterator extends IntIterator\n  *  protected static final class RLEIntIterator extends IntIterator\n  *  protected static final class NullIntIterator extends IntIterator\n  * public class UnsafeRowParquetRecordReader extends SpecificParquetRecordReaderBase<UnsafeRow> \n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46198/
Test FAILed.


Can't able to train the agent using stable baselines ?

Hello maximecb,
Thanks for this amazing repo, I'm making a custom environment using the mini-grid where I have added obstacles so that whenever an agent crosses them the reward they will get is -1 else zero and at the end when it reaches the goal the reward will be 1 and while training the agent with stable baselines(ppo and a2c) the maximum reward I have achieved till now is -50 means it is overlapping with the  obstacles instead of avoiding them and not learning properly
obstacle class:
class nfa(WorldObj):
    def __init__(self, color='purple'):
        super().__init__('ball', color)

    def can_overlap(self):
        """Can the agent overlap with this?"""
        return True

    def render(self, img):
        fill_coords(img, point_in_rect(0, 1, 0, 1), COLORS[self.color])

Custom Environment:

PPO Parameters:
l_rate = 0.0007   #0.0003
batch = 64         #64
df = 0.99         #0.99
n_steps = 2048    #2048

policy_kwargs = dict(activation_fn=th.nn.ReLU,
                     net_arch=[ 32,64,64,128])

model = PPO( 'MlpPolicy' ,
            env,
            verbose =2
            ,learning_rate = l_rate
            ,batch_size = batch
            ,gamma=df
            ,n_steps = n_steps
            ,clip_range = 0.2
            ,policy_kwargs=policy_kwargs
            )

So can you suggest me what should I do? which parameters to tune or should I use some other framework other than stable baselines3?

I would suggest starting with a much smaller environment eg 6x6 and seeing if you can get that to converge. Optimize your parameters, then move to larger environments.

If the obstacles are static then it is working fine but I'm choosing the obstacles randomly, so I tried with a smaller grid but the problem is still there.

Two things to try: give your model some recurrent memory, and try giving a positive reward for succeeding but no negative reward on failure. In my experience negative rewards work poorly. Besides that, keep experimenting with small envs like 6x6 or 8x8 until you figure out a recipe that works before moving to larger ones.


fix search

SQL used for search doesn't work with production db https://jsperf.com/search?q=test or my homebrew default-vanilla mysql

Use Google?


Build crashpad_handler as a "Windows" application

This stops the command window from being shown when it is executed.

Thanks for the PR!
This seems a bit counter-intuitive to me, though.
To recap, with WindowedApp kind it will not show the window? What will be shown instead?

WindowedApp in premake changes the subsystem to be "Windows" rather than "Console"; these are described in more detail here:
https://docs.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=vs-2019
So, to answer your question; no window will be shown unless the crashpad_handler creates one (it doesn't).
For some background
Google's crashpad build would produce two outputs,  one called crashpad_handler.exe which is against the Windows subsystem and one called crashpad_handler.com which is against the Console subsystem. From what I can tell the purpose was so that if you ran crashpad_handler from a command prompt the help text would be shown (as crashpad_handler.com would be invoked).

@icedtoast Thanks for the explanation, and sorry for the delay.
We'll revisit it this or next week.

Thanks! 🏄


payloadCreator is executed even when an Error is passed

See https://github.com/acdlite/redux-actions/issues/82.

Resolved by https://github.com/acdlite/redux-actions/commit/b9d5eb7daec5e29cb02c34dfb855c51183051f71.


Archery game

close #422
https://github.com/Vikash-8090-Yadav/Future.WebNet/assets/111994644/012a5faf-9b3a-4f56-b1ca-c669156e8ae4

@Vyshnavi21504 there are 2 projects in this pull request i.e. Archery game and Memory game. Please remove memory game from this pull request in order to merge this pull request.


Remove ca/on/city_of_waterloo

The city_of_waterloo source (https://rowopendata-rmw.opendata.arcgis.com/datasets/98e0a9aa3f8e447380f27fdc1c170d02_0) is hosted on the regional municipality of Waterloo data portal, but it is actually addresses for the city of Kitchener (which is next to, but not actually, the city of Waterloo). The city of Kitchener already exists with its own source, so this is a duplicate.

Accidentally created duplicate issues, closing this one.

Accidentally created duplicate issues, closing this one.


Basic Version of Lab Complete

I have completed the basic form of the lab in this PR. I may submit another PR if I have time to work on Extra Credit tomorrow. I believe the extra credit would be a good learning experience, however, I (and likely most of the class) lack experience with Dev Ops tools such as Docker and how to use CircleCI for automatic deployment, though I do think it would be interesting to expand my knowledge of this realm.

I am now referencing another student @joshuasimmons33


[BUG] Portal-in-portal not rendering w. Nether Portal Overlay enabled

According to your testing, does the issue occur with ONLY Immersive Portals mod and Farbic API?
Yes
Describe the issue
With netherPortalOverlay enabled other portals are not rendered through portals:

Post the log here
No response

Will be fixed in the next version


Updated label component

Description
Icons was not working in the label component, updated the method name to fix it.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] Tested in CM-Product

You did it @purnamashetty!
Thank you for signing the Anthem Opensource Software CLA.


about-networking.md

Hello there,
Fixing 1 typo : which -> with
Proposing "send" -> "send or receive" to match beginning of sentence
Best,
Didier

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Debug remnants build failure causes empty error message during production builds

Hi! Just wanted to first say thank you for creating elm-spa - I've had a super great experience building stuff with it :sparkles:
I've found that using functions from the Debug core library causes elm-spa build to fail, as expected, but without any kind of build message. For example, in basic elm:
module Main exposing (..)

import Html exposing (text)

main =
  text <| Debug.toString "Hello!"

λ elm make src/Main.elm
Success!

    Main ───> index.html

λ elm make src/Main.elm --optimize
Success!
-- DEBUG REMNANTS --------------------------------------------------------------

There are uses of the `Debug` module in the following modules:

    Main

But the --optimize flag only works if all `Debug` functions are removed!

Note: The issue is that --optimize strips out info needed by `Debug` functions.
Here are two examples:

    (1) It shortens record field names. This makes the generated JavaScript is
    smaller, but `Debug.toString` cannot know the real field names anymore.

    (2) Values like `type Height = Height Float` are unboxed. This reduces
    allocation, but it also means that `Debug.toString` cannot tell if it is
    looking at a `Height` or `Float` value.

There are a few other cases like that, and it will be much worse once we start
inlining code. That optimization could move `Debug.log` and `Debug.todo` calls,
resulting in unpredictable behavior. I hope that clarifies why this restriction
exists!

But trying the same thing with elm-spa (I'm using 6.0.4):
module Pages.Home_ exposing (view)

import Html
import View exposing (View)

view : View msg
view =
    { title = "Homepage"
    , body = [ Html.text <| Debug.toString "Hello, world!" ]
    }

Results in:
λ elm-spa build

! elm-spa failed to understand an error

Please report the output below to https://github.com/ryannhg/elm-spa/issues

-----

{}

-----

! elm-spa failed to understand an error

Please send the output above to https://github.com/ryannhg/elm-spa/issues

I suspect this might actually be a problem with node-elm-compiler since it looks like its returning an empty error from compileToString?

having the error messages from the elm compiler directly would be super good!

It is possible to use elm-live or do you recommend vite as a replacement to get error messages in this case @ryannhg?

It is possible to use elm-live or do you recommend vite as a replacement to get error messages in this case @ryannhg?

hey @Narice – elm-live is a great dev server, so i recommend using whatever you prefer.
the setup for vite, elm-live, webpack, or any other server is pretty similar so pick the one thay works for you.
i only included a vite example to demonstrate how to use elm-spa watch and elm-spa gen alongside a 3rd party tool.

@ryannhg thank you very much! I'll do that for now then!
When elm-spa server will show errors I'll probably switch back to it.


Added functionality to export update schedule for all projects, allow export instances by instance type, enable task bar icon

We have many projects, and it is hard to have visibility over the update schedule. As such, I have added this to 2LCS in lieu of API access.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nb-tergen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Not sure why task bar icon was disabled, maybe this should be parameterised??


Optimize composer.json

According to semver rules, every next minor versions should works with your project without any BC.
This configuration is more optimized to get latest version regularly.

I don't think all these libraries follow semver.

For symfony and guzzle, they do certainly.
For the rest, they should. I extremely rarely got problem with any libraries and semver on my php projects.
In any case, in this case, tests will reveal this.

thanks for this @Soullivaneuh, I do appreciate it.
I have adapted the composer.json on master as it is the intention. I know if we were to use the ^ and do a regular composer this PR would be in definitely. This is just so we can track dependency changes in a finer grain version. This is almost in the extreme of having the composer.lock persisted with the repo, just that 1 inch before just in time.

https://github.com/gushphp/gush/commit/6b3488e2fe9954cadfff62fc2ebd2d1491c3b581

I'm sorry but this make no sense to me.
It is especially hard to keep you project up to date with this kind of constraint.
If you want to lock versions for your .phar, just use the composer.lock, but not this way.
For my case, I require gush in global with composer. And because of this, I have a lot of sub-dependencies not up to date and lock for others tools. This is quite painful.

I agree with @Soullivaneuh. Especially for dependencies like Symfony it doesn't make sense to lock it at 2.7.2. This will make it more difficult to update dependencies to the latest versions later on

i see now, i do not recommend gush to be in composer global, this way was discouraged long time ago and i myself ran into so many issues like that that we discarded it from the beginning.  So please do not install gush this way. Either clone and symlink or use the phar. Those are the recommended options. You would run into problems for global not just for Gush but with any other tool like phpunit and etc. Though yes you will probably have more problems with Gush that way than anything else.
Re symfony dependency mind that gush is a project and not a library, though it has libraries/packages underneath, we keep track of dependency bumps so you don't have to.

I always installed this kind of tools through composer without any problem, phpunit included.
 :-)
At least, has gush a system for auto upgrade when a new version is available? Because this is for this part I like to install tools with composer (global mode).

symfony dependency mind that gush is a project and not a library

In this case, the composer.lock file should be commited instead of strict requirement on composer.json.

If  you read the documentation, the latter should is not a must. Is only a recommendation on getcomposer.org however there are different positions on this. See the debate on gush repo or elsewhere in composer repos as well.
Do not install gush globally, it will give you problems. Recommended ways are clone and symlink OR phar download for now.

locking the conversation. We can discuss further in gitter.


Review plugin to take into account the changes from MkDocs 1.4.0

Review the MkDocs 1.4.0 changelog and reflect any relevant changes on the plugin:
https://github.com/mkdocs/mkdocs/releases/tag/1.4.0

Superseded by https://github.com/prcr/mkdocs-meta-descriptions-plugin/issues/249.


Add Glossier as part of the companies that use Luigi

Description
Let's spread the love!

Thanks for sharing, @cabouffard ! Looking forward to the next blog in this series!


ValidationError: 1 validation error for VertexAI

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
# Generate summaries of text elements
def generate_text_summaries(texts, tables, summarize_texts=False):
    """
    Summarize text elements
    texts: List of str
    tables: List of str
    summarize_texts: Bool to summarize texts
    """

    # Prompt
    prompt_text = """You are an assistant tasked with summarizing tables and text for retrieval. \
    These summaries will be embedded and used to retrieve the raw text or table elements. \
    Give a concise summary of the table or text that is well-optimized for retrieval. Table \
    or text: {element} """
    prompt = PromptTemplate.from_template(prompt_text)
    empty_response = RunnableLambda(
        lambda x: AIMessage(content="Error processing document")
    )
    # Text summary chain
    model = VertexAI(
        temperature=0, model_name="gemini-pro", max_output_tokens=1024
    ).with_fallbacks([empty_response])
    summarize_chain = {"element": lambda x: x} | prompt | model | StrOutputParser()

    # Initialize empty summaries
    text_summaries = []
    table_summaries = []

    # Apply to text if texts are provided and summarization is requested
    if texts and summarize_texts:
        text_summaries = summarize_chain.batch(texts, {"max_concurrency": 1})
    elif texts:
        text_summaries = texts

    # Apply to tables if tables are provided
    if tables:
        table_summaries = summarize_chain.batch(tables, {"max_concurrency": 1})

    return text_summaries, table_summaries

# Get text, table summaries
text_summaries2, table_summaries = generate_text_summaries(
    texts[9:], tables, summarize_texts=True
)

Error Message and Stack Trace (if applicable)
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
[<ipython-input-6-4464722c69fb>](https://localhost:8080/#) in <cell line: 51>()
     49
     50 # Get text, table summaries
---> 51 text_summaries2, table_summaries = generate_text_summaries(
     52     texts[9:], tables, summarize_texts=True
     53 )

3 frames
[/usr/local/lib/python3.10/dist-packages/pydantic/v1/main.py](https://localhost:8080/#) in __init__(__pydantic_self__, **data)
    339         values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data)
    340         if validation_error:
--> 341             raise validation_error
    342         try:
    343             object_setattr(__pydantic_self__, '__dict__', values)

ValidationError: 1 validation error for VertexAI
__root__
  Unable to find your project. Please provide a project ID by:
- Passing a constructor argument
- Using vertexai.init()
- Setting project using 'gcloud config set project my-project'
- Setting a GCP environment variable
- To create a Google Cloud project, please follow guidance at https://developers.google.com/workspace/guides/create-project (type=value_error)

Description
I am not able to connect to Vertex AI, new to GCP.. what are the steps?
System Info
System Information
------------------
> OS:  Linux
> OS Version:  #1 SMP PREEMPT_DYNAMIC Sat Nov 18 15:31:17 UTC 2023
> Python Version:  3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0]

Package Information
-------------------
> langchain_core: 0.1.19
> langchain: 0.1.5
> langchain_community: 0.0.18
> langsmith: 0.0.86
> langchain_experimental: 0.0.50
> langchain_google_vertexai: 0.0.3

Packages not installed (Not Necessarily a Problem)
--------------------------------------------------
The following packages were not found:

> langgraph
> langserve

please, provide a projectargument during initialization of VertexAI


v1.11: Update Go to 1.17.4

v1.11 backport of #18128

/test-backport-1.11

AKS test hit #18125
k8s-1.21-kernel-4.9 failed on #18060 which will be fixed once #18133 is backported to v1.11
The k8s 1.19 and 1.20 failed but test reports seem to be missing for both of them. There are failed tests in the logs though (needs further analysis):

k8s-1.19-kernel-4.9: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.9/1928/
k8s-1.20-kernel-4.9: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.9/1190/


Fix lazy loaded monaco bundle

Currently, our build pipeline is broken because of the automatic update to the latest inscription view after the lazy moanco PR is merged: https://github.com/axonivy/inscription-client/pull/510
This should fix it.
Hi @martin-fleck-at
I quickly fixed the process client build, so it can handle the API changes from the inscription view. Do you already work on this? Or how is you current state here?

@ivy-lli I have not started looking into this! I wasn't aware that there is an automatic update to the latest version, sorry for that! How would you like to proceed?

@martin-fleck-at our build always do an update to the latest package version. We do this so that our final build product always includes the latest possible resources.
It seems to work, the only thing I'm not sure about is the isMonacoReady flag which is now "faked" with a Promise.resolve(true). But technically in the startup it waits for the init and only afterward the EnableInscriptionAction is dispatched, so it should always be initialized during the connection creation.

I quickly tested it, and it seems to work like this.
And I assume that also the vscode extension build will fail as soon as this PR is merged 🙈

I will merge it for now. Feel free to open a PR with additional changes if you like.

https://github.com/axonivy/vscode-extensions/pull/218


How to embed a custom view with xib file?

Hi there!
You can create a XIB with a UIView as root object. In your RMActionController initializer you then can load this XIB and use the UIView as your customView.


Enable testnet feature pass-through in wasm

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de4cd2b) 36.18% compared to head (35470a6) 36.18%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #282   +/-   ##
========================================
  Coverage    36.18%   36.18%
========================================
  Files           26       26
  Lines         9646     9646
========================================
  Hits          3490     3490
  Misses        6156     6156

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Firebase Example

List convertStreamResultFirebase(
{required dynamic streamResult}) {
///here you can parse the streamresult and convert to [List]
///Note that this is dynamic, so you need to know what properties are available on your result, in our case the [SportBooking] has bookingStart and bookingEnd property
List converted = []
for (var i = 0; i < data.size; i++) {
final item = data.docs[i].data();
converted.add(DateTimeRange(start: (item.bookingStart!), end: (item.bookingEnd!)));
}
return converted;
}
In this snippet of code provided in the Firebase example, I want to know where data.size comes from.
I am having issues finding a way to apply this function in my code

Actually its just a typo mybad.
Replace data with streamResult. Of course we check the size and docs of the passed parameter which is the dynamic streamResult

Thanks I appreciate it


Problem starting

Hello @vingeraycn,
Thanks for your work with this wrapper.
I was trying to get it to work but I see this issue: Uncaught TypeError: n is undefined.
This is the stack-trace:
Uncaught TypeError: n is undefined
    q index.es.js:56
    DraggableGrid index.es.js:1571
    Preact 98
    debounceRendering debounceRendering.js:13
    debounceRendering debounceRendering.js:11
    Preact 3
    React 2
    Preact 6
    reactRender app.js:49
    runRender app.js:242
    <anonymous> app.js:253
    setTimeout handler* app.js:252
    promise callback* app.js:197
    promise callback* app.js:74
    js commons.js:2334
    factory commons.js:6767
    __webpack_require__ commons.js:6101
    __webpack_exports__ commons.js:7470
    O commons.js:6150
    <anonymous> commons.js:7471

Looking at dist/index.es.js:56 I see this code: n = f.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.ReactCurrentOwner.
These are my version:
"muuri": "^0.9.5",
"react": "18.2.0",
"react-dom": "18.2.0",
"ruuri": "^0.1.7",

And, this is how I create the component:
// ----------------------------------------------------------------------------
// -------------------------------------------------------------------- Imports
// ----------------------------------------------------------------------------
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Libraries
import React, { useRef } from 'react'
import classnames from 'classnames'
import map from 'lodash/map'

// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Components
import DraggableGrid, { DraggableItem } from 'ruuri'

// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Locals
import smallKey from '../../methods/small-key'

// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Abstractions
// const { Fragment } = React

// ----------------------------------------------------------------------------
// ------------------------------------------------------------------ Component
// ----------------------------------------------------------------------------
/** Grid */
const Grid = ({
  nodes,
  Renderer = (node) =>
Need to define a renderer for {node.title}
,
  className,
  itemClassName,
}) => (
  <DraggableGrid
    containerClass={classnames('grid muuri-grid ext-image-fix', className)}
    itemClass={classnames('grid-item muuri-grid-item', itemClassName)}
    dragEnabled={false}
    dragSort={false}
  >
    {map(nodes, (node) => (
      <DraggableItem>
        <Renderer node={node} />
      </DraggableItem>
    ))}
  </DraggableGrid>
)

// ----------------------------------------------------------------------------
// -------------------------------------------------------------------- Exports
// ----------------------------------------------------------------------------
export default Grid

Could you please comment?
Thanks!

Hi @dbx834
Thanks for the detailed info, I'll take a look at the question later today

Hi @dbx834
I pasted your code on Codesandbox but it doesn't reproduce your problem, am I missing some key information? If possible, can this issue be reproduced on Codesandbox? Thank u

Thanks for checking it out. Your sandbox certainly is working. Yes I did miss some information. I didn't include the fact that I'm using preact (ref) and preact-compat(ref). I'll go more into it and write again soon, and this time with a sandbox.

So, I was able to sort it out.
I use [this gatsby plugin] (https://www.gatsbyjs.com/plugins/gatsby-plugin-preact/), which replaces or updates references to these react libraries at runtime.
The issue, as I guessed, was because of this. Precisely – because at runtime a reference couldn't be found in the code.
How I solved it was that I copied the files in your source folder and used them as the component instead of the packaged files. Then, I just added a reference to React in DraggableGrid.tsx and DraggableItem.tsx, and it works.
This is a weird, rare issue. Noting it for someone else who maybe up against it.
Thanks, once again, @vingeraycn!

So, I was able to sort it out.
I use this gatsby plugin, which replaces or updates references to these react libraries with the appropriate preact libraries at runtime.
The issue, as I guessed, was because of this. Precisely – because at runtime a reference couldn't be found in the code. How I solved it was that I copied the files in your source folder and used them as the component instead of the packaged files. Then, I just added a reference to React in DraggableGrid.tsx and DraggableItem.tsx, and it works.
This is a weird, rare issue. Noting it for someone else who maybe up against it.
Thanks, once again, @vingeraycn!

I'm glad to see the progress of the problem. I think this may have something to do with the concept of ruuri. ruuri relies on React's runtime, but does not mix React when packaging, but chooses to rely on the React version of the user's current project. It was true that Preact was not considered at first, but thank you for exposing it. @dbx834


Update transitioning state example to use greensock

As mentioned in #780, the tween.js example for this demo is very verbose, so an update using greensock is nice because it's a little more legible.
I'd be open to updating the following example as well, I just didn't have the time tonight.

Please either do this or revert #1350, because currently the example is broken with recent Tween.js and can lead to major frustration.


Text beside Image when using "imageWithText" as ViewPagerTabType

First, thanks a lot for providing this library. It helped a lot in the project. 😊
But I want to use text beside image when using "imageWithText" as ViewPagerTabType. Is there a way to do that?

Hi @Fadedglyph ,
Currently there is no built in support for this. But if you want, you would have to modify frames in ViewPagerTabView.swift file.
Thanks :)

Hey @nrlnishan , thanks for the reply!
I'd try modifying ViewPagerTabView.swift myself. Thanks for providing the privilege! :)

Hey @Fadedglyph ,
Previously , i did something similar. Here is the Link PasteBin Link
These modified functions are from ViewPagerTabView.swift file.
PS: I didn't test the code.


add option to disable remote ca verify

This is needed for #201.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Shikugawa
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Shikugawa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly
Did you forgot this RFC thing (https://github.com/istio-ecosystem/authservice/pull/126#issuecomment-934655392) ?
But nice to have this now. 👍🏻

@incfly Did you forgot this RFC thing (#126 (comment)) ?
But nice to have this now. 👍🏻

We have made it clear to the API that this feature should only be used in a test environment. (This is required for integration testing with self-signed certificates.)

@Shikugawa Sure, but result would be the same or?
And if an ODICP instance is behind an Reverse Proxy (TLS endpoint) on same host, it still makes no sense to put an certificate onto it.

@bruegth The IDP setting of authservice is implemented to accept only HTTPS, and adding an option to allow HTTP to it is not desirable. Therefore, when configuring an external IDP for integration testing, a TLS certificate should always be set. However, it is practical to use self-signed certificates in a test environment, and for that reason, we should be able to disable certificate validation.

When reviewing PR, I actually did worry about this can cause misunderstanding like this, since it's defined as part of the API proto. @Shikugawa for integration test we could provide a way to specify additional root (even if it's self signed). Istio does the similiar things for its JWKS endpoint HTTPS fetching.

I also had concerns about providing this feature as an API, so I considered several other ways (e.g., providing it as a runtime option, or switching it in a compile option), but I thought that an API would be fine as long as it is clearly documented. However, if @incfly has other concerns, we can provide a better way. We can just not include this change in the next release.


Add Support for intfloat/multilingual-e5-large-instruct :Fixes #140

Description:
This pull request addresses issue #140 by integrating the intfloat/multilingual-e5-large-instruct model from Hugging Face into the repo. This update extends capabilities, enabling it to support more diverse language embeddings and accommodate various numerical data types seamlessly.
Changes:
•Model Support: The intfloat/multilingual-e5-large-instruct model is now supported, expanding our project's multilingual
processing capabilities.
•Documentation Update: Updated the Supported_Models.ipynb notebook to include documentation and usage examples for the new model.
•Configuration Update: Modified e5_onnx_embedding.py to include configuration settings specific to the intfloat/multilingual-e5-large-instruct model, ensuring optimal performance.
•Testing: Enhanced test_text_onnx_embeddings.py with new test cases designed to validate the output embeddings of the intfloat/multilingual-e5-large-instruct model against predefined documents.
•CANONICAL_VECTOR values : Here is a reference Colab Notebook
Onnx file :
HuggingFaceHub:
https://huggingface.co/yashvardhan7/multilingual-e5-large-instruct/tree/main
Test:
All test cases have successfully passed with the inclusion of the latest intfloat/multilingual-e5-large-instruct model.

@NirantK ,other issues also intrigued me so I created #182  &  #183  accordingly

This is a fresh PR . which has only one model.

This one has passed the tests on my mac, i have also tested it on colab and there also it passed the tests.

This is the main issue,
E           AssertionError: intfloat/multilingual-e5-large-instruct
E           assert False
E            +  where False = <function allclose at 0x1022f6170>(array([ 0.01046869,  0.02897676,  0.00061903, -0.04191001,  0.02616828],\n      dtype=float32), array([ 0.01020064,  0.02367217,  0.00117697, -0.04327098,  0.02887568]), atol=0.001)
E            +    where <function allclose at 0x1022f6170> = np.allclose
fastembed/tests/test_text_onnx_embeddings.py:51: AssertionError
---------------------------------------------------------------------- Captured stderr call ----------------------------------------------------------------------
Fetching 8 files: 100%|██████████| 8/8 [00:00<00:00, 13184.45it/s]
Fetching 7 files: 100%|██████████| 7/7 [00:00<00:00, 17772.47it/s]
Fetching 9 files: 100%|██████████| 9/9 [00:00<00:00, 11466.81it/s]
Fetching 7 files: 100%|██████████| 7/7 [00:00<00:00, 26618.43it/s]
Fetching 8 files: 100%|██████████| 8/8 [00:00<00:00, 15210.53it/s]
Fetching 15 files: 100%|██████████| 15/15 [00:00<00:00, 18178.15it/s]
Fetching 13 files: 100%|██████████| 13/13 [00:00<00:00, 76473.99it/s]
Fetching 7 files: 100%|██████████| 7/7 [00:00<00:00, 68438.53it/s]
Fetching 15 files: 100%|██████████| 15/15 [00:00<00:00, 17394.13it/s]
Fetching 8 files: 100%|██████████| 8/8 [00:00<00:00, 36511.90it/s]
Fetching 10 files: 100%|██████████| 10/10 [00:00<00:00, 23484.34it/s]
Fetching 10 files: 100%|██████████| 10/10 [00:00<00:00, 20743.34it/s]
==================================================================== short test summary info =====================================================================
FAILED fastembed/tests/test_text_onnx_embeddings.py::test_embedding - AssertionError: intfloat/multilingual-e5-large-instruct
================================================================== 1 failed, 7 passed in 58.92s

Hello @Ya-shh. You've gated your model on HF, which is why https://github.com/qdrant/fastembed/pull/181/commits/a3a3e0697ab50ae287dc3cc2d7ec36a5f79cffc2 failed. Should be good after you remove it.
https://github.com/qdrant/fastembed/pull/181/commits/cc58940fba106e1b1b19d0db349c1516b55431cd won't be necessary.

Hello @Ya-shh. You've gated your model on HF, which is why a3a3e06 failed. The download should be good after you remove it.
cc58940 won't be necessary.

Thanks a lot ! @Anush008

now it's failing at allclose

Hey @Anush008 , now it won't fail . You can run it !

@Anush008 I have committed the changes .Now it's ready to go

The Torch canonical values you've shared in the notebook seem to be different from the ones in the test.

Sure,I will attach new notebook

The Torch canonical values you've shared in the notebook seem to be different from the ones in the test.

Initially I have added the same values as per my notebook but after tests the codebase was demanding other canonical values so I changed them

The Torch canonical values you've shared in the notebook seem to be different from the ones in the test.

I will upload new notebook

Due to the error that came while testing , i changed those canonical values according to the logged one but now i need to reattempt the quantization process of this model in order to match the values.I will do this asap.

Hi @Anush008, in relation to issue #190, I've pinpointed the error in this PR to the atol values. Initially, I mistakenly adjusted the canonical vector values, but I've now corrected the atol values instead. I'm also addressing the token_type_ids issue mentioned in #190. All other concerns with this PR have been addressed. Could you please take a moment to review it?

•CANONICAL_VECTOR values : Here is a reference Colab Notebook

Hi @Anush008, In reference to the issue discussed in #190, I have identified the error in this (PR) as being related to the atol values. Initially, I incorrectly modified the canonical vector values; however, I've now made the necessary corrections to the atol values. Additionally, I am addressing the token_type_ids issue mentioned in #190 (currently marked as draft). All other concerns raised regarding this PR have been resolved.

•CANONICAL_VECTOR values : Here is a reference Colab Notebook

@NirantK, All the issues with this PR have been resolved.

I have used onnx/export space to convert this model into onnx :https://huggingface.co/intfloat/multilingual-e5-large-instruct/discussions/10#6616c91ec4c0c33f79d2b482. This one has  max diff: 0.0002199709415435791 , and it should pass at all close

@Anush008 could you please run the checks ? As locally Pytest taking too much time

onnx_config.json  was already there ,now I renamed it to config.json :https://github.com/qdrant/fastembed/actions/runs/8635779617/job/23684067678?pr=181

@Anush008 now you could run the checks

@Anush008 I have quantised the onnx model further using Quantization.Unfortunately I am not able to run tests locally due to network issues. Sorry if I trouble you but the only option now is CI . Update onnx model: https://huggingface.co/yashvardhan7/multilingual-e5-large-instruct/tree/main/onnx

You can maybe remove the other models when trying the tests locally.

You can maybe remove the other models when trying the tests locally.

Thanks ,I even try that but still due to network issues none of the tests are running

@NirantK I have tried every possible way to quantise this model .Optimized it with different AutoOptimizationConfig. And the result remain the same with both 03 and 02  with an atol=1e-3
E           AssertionError: intfloat/multilingual-e5-large-instruct
E           assert False
E            +  where False = <function allclose at 0x101d18270>(array([ 0.01044647,  0.02897521,  0.00060697, -0.04193534,  0.02606635],\n  dtype=float32), array([ 0.01020065,  0.02367218,  0.00117696, -0.04327099,  0.0288757 ]), atol=0.001)
E            +    where <function allclose at 0x101d18270> = np.allclose
I have even quantized this model further but still no change in the onnx weights .It only passes for  atol=1e-2. As you said 1e-3 is already quite large . So we really can’t add support for this model.

https://huggingface.co/yashvardhan7/multilingual-e5-large-instruct

Tried with these all but still it fails at atol=1e-3. And passes at atol=1e-2
Onnx model with AutoOptimizationConfig.02
Onnx model with AutoOptimizationConfig.03
Onnx model using Onnx/export space on HF

@NirantK, locally I have also tested both Xenova/multilingual-e5-small & intfloat/multilingual-e5-small onnx models but they also fails at allclose :
E           AssertionError: intfloat/multilingual-e5-small
E           assert False
E            +  where False = <function allclose at 0x110ad0170>(array([ 0.04931236,  0.02415175, -0.0384715 , -0.08884481,  0.08710264],\n dtype=float32), array([ 0.03131689,  0.03093922, -0.03511665, -0.06727391,  0.08508426]), atol=0.001)
E            +    where <function allclose at 0x110ad0170> = np.allclose
But in this even they fails at atol=1e-2
E           AssertionError: intfloat/multilingual-e5-small
E           assert False
E            +  where False = <function allclose at 0x10456d470>(array([ 0.04931236,  0.02415175, -0.0384715 , -0.08884481,  0.08710264],\n dtype=float32), array([ 0.03131689,  0.03093922, -0.03511665, -0.06727391,  0.08508426]), atol=0.01)
E            +    where <function allclose at 0x10456d470> = np.allclose
These multilingual  models really require more investigation