Mbasiuk/tdi 38933 sf integration tests

What is the current behavior? (You can also link to an open issue here)
ITs for Salesforce Reader were unstable due to shared data.
What is the new behavior?
Create different data for every execution. Fix unstable test for session renewal.
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[x] Improve Salesforce Reader integration tests.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: failure :x:

Pull request test result: success :star:


Fix no-array-index-key rule exception

Fix #1021

Done

The appveyor build seems to have failed due to Github issues; @wKich if you can force push a new SHA (perhaps via a rebase) then it should trigger the new build. I don't think anyone but @yannickcr can initiate a rerun of the current build.


Refactor apps/bandwidth

This app is currently using an old, verbose, and deprecated coding style for async_mmap. This should be updated. Also, it is a good app to cover ap_int.h usage.

Fixed by b0560074e5f06c3c5d3bb0f3d66d316bc94819ce.


exception in get mount path

Hello.
I get this error, when try ty mount restore point

Generally this points to an issue with the credentials selected in the prior step. Be sure you're selecting credentials with admin privilege on the mount server. The credentials selected don't need to be applicable to the actual workload you're running the comparison against.


Support --local-engine when for single CPU architecture AOT builds on macOS

I'm seeing errors when I run flutter run --local-engine host_profile --profile on a Mac x64 host using the current engine and flutter_tools.
flutter_tools reports that it can't find gen_snapshot_x64 or gen_snapshot_arm64 and that the FlutterMacOS.framework binaries are x64 only.
This is related to some of the recent flutter_tools changes for enabling ARM64 support (https://github.com/flutter/flutter/commit/a618ca27a76faa546fe7704215e49b2a871e56db, https://github.com/flutter/flutter/commit/fd3c34c9d4b125b7c6bce473b7ff1bc6bcb0ac27)
@jmagman @cbracken

@cbracken looks like macOS needs to be audited for local engine single-architecture issues. https://github.com/flutter/flutter/blob/a618ca27a76faa546fe7704215e49b2a871e56db/packages/flutter_tools/lib/src/ios/xcode_build_settings.dart#L189-L201

-dDarwinArchs shouldn't hard-coded, it should come from ARCHS
https://github.com/flutter/flutter/blob/71ec251a59dd1a982107a3233fe134713437009d/packages/flutter_tools/bin/macos_assemble.sh#L73
like this:
https://github.com/flutter/flutter/blob/71ec251a59dd1a982107a3233fe134713437009d/packages/flutter_tools/bin/xcode_backend.dart#L418

Jason's logs also show:
[        ] [   +2 ms] Target compile_macos_framework failed: ProcessException: Failed to find "/Users/jsimmons/sky/engine/src/out/host_profile/./gen_snapshot_x64" in the search path.

"-dDarwinArchs=x86_64 arm64"

is also incorrect since it shouldn't build both in debug mode.

https://github.com/flutter/flutter/pull/100811 and https://github.com/flutter/flutter/pull/100917 have merged.  The last piece is to fix the gen_snapshot_x64 vs gen_snapshot.
So if you hit this issue on x64, the workaround for now is to symlink out/host_<variant>/gen_snapshot to out/host_<variant>/gen_snapshot_x64.

I'll patch that bit in the engine build rather than in the tool, as we do for iOS.

Patch is out at https://github.com/flutter/engine/pull/32326.
That said, it's important to note that the correct local engine to point to for macOS builds is a local engine built with --mac flag; e.g. mac_release_unopt_arm64 etc. Host builds will likely work for x64 targets, but not currently for arm64, where an x64 gen_snapshot is built instead, since in host builds the target is the host.

That said, it's important to note that the correct local engine to point to for macOS builds is a local engine built with --mac flag; e.g. mac_release_unopt_arm64 etc. Host builds will likely work for x64 targets, but not currently for arm64, where an x64 gen_snapshot is built instead, since in host builds the target is the host.

@cbracken can you update https://github.com/flutter/flutter/wiki/Compiling-the-engine#compiling-for-macos-or-linux to make that clear?

Will do. To be clear, https://github.com/flutter/engine/pull/32326 will get things working with a host build (as well as target builds) right now, but long-term I could imagine things diverging enough that it's no longer the case.


Create customerPayments - URL on Request Example is wrong

Hi, the URL showing under the Request example is wrong. It reads:
POST https://{businesscentralPrefix}/api/v2.0/companies({id})/customerPayment
It should read:
POST https://{businesscentralPrefix}/api/v2.0/companies({id})/customerPayments
If you use the URL on the current example, you run into the following error message:
"message": "No HTTP resource was found that matches the request URI 'https://api.businesscentral.dynamics.com/v2.0/Production/api/v2.0/companies({companyId})/customerPayment?tenant=msft1a6720t22590909&aid=FIN'."
Rgds.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3f2f3e63-0613-e710-4fac-029012b3fc29
Version Independent ID: 73c05b65-a95b-8286-8e52-acea522d5bc7
Content: Create customerPayments - Business Central
Content Source: dev-itpro/api-reference/v2.0/api/dynamics_customerPayment_create.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for catching this. Will be fixed with the next refresh of the docs.

This was closed but never fixed. Is it still tracked to be fixed? Otherwise, I'll just stop reporting documentation issues. Tks.


koordlet: Turn on pleg

Signed-off-by: Cheimu<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Turn on pleg.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/approve


Add project filter SMT "Jobs Failed Timeline"

Add a filter on projects in SMT "Jobs Failed Timeline" dashboard.
Add the possibility to select all projects

Trello card: [#155] Add project filter SMT "Jobs Failed Timeline"

Closed with https://github.com/saagie/technologies-community/pull/156


Feature/lockup logo

Summary of Changes

Add the logo lockup as a custom view
Add the logo lockup as an option for the price breakdown

Submission Checklist

[x] Documentation is changed or added.

Can the sample PNG Images/lockup-mint.png please be amended to use a dark background?

Addressed in 1c1ea9e


Add command or flag to see the SpiceDB server version

Seems like something that could be output when zed version is executed if a context is configured.

Yep!


refactor update scan concurrency for pipeline

Proposed changes
Same as #16473
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


option description mentions mautrix-telegram instead of mautrix-facebook

When copying this to make a mautrix-twitter module, I realised that this line mentions mautrix-telegram instead of mautrix-facebook..
https://github.com/NixOS/nixpkgs/blob/ce8cbe3c01fd8ee2de526ccd84bbf9b82397a510/nixos/modules/services/misc/mautrix-facebook.nix#L95
Also since all these bridges use basically/exactly? the same module anyways, maybe they could be combined somehow?

Regarding the suggestion to combine the the many bridges somehow, there is #114419, which aims to do exactly that.


Remove jailed and all references to it

Remove the first line of code in challenge-footer.jade and jailed folder.
closes #7877

I just understand the instruction for naming a branch. Will name it correctly in the future, sorry.

LGTM

Thanks @baguzzzaji


Add support for -filter_complex and/or logo overlay

Feature Request:
ffmpeg supports source overlay. It would be very nice to add this feature to Shaka-streamer.
This is very convenient for organizing branded broadcasting of a video stream (TV channel, presentation, broadcast of events, and so on)
Example:
ffmpeg -i video.mp4 -i logo.png \
-filter_complex "[0:v][1:v] overlay=64:64:enable='between(t,0,20)'" \
-pix_fmt yuv420p -c:a copy \
result.mp4

overlay=64:64 - means that we want to place the logo with a shift of 64px to the right and with a shift of 64px down, relative to the upper left corner (0:0)
enable='between(t,0,20)' - means we want to overlay the logo in the range from 0 to 20 seconds
[0:v][1:v] - means layer order. The first layer (0: v) is video.mp4, the next (1: v) is logo.png
I understand that this is not paramount. But it would be very good to have such an option in the future :)

Thanks for the request!
We already have a feature where you can specify FFmpeg filters, but nothing yet that would allow -filter_complex with an image as input.  We'll give some thought to how this would be specified in a config file.  We didn't plan for -filter_complex in general.

but nothing yet that would allow -filter_complex with an image as input

I imagined that this could be done inside input_xxx_config.yaml
In the inputs section.
Something like:
- name: logo.png
    media_type: overlay
    position_x: 64
    position_y: 64
    etc.

Yes, that could work.  If we support overlays specifically, we could do something targeted like that.
If we don't find any other compelling use-cases for -filter_complex, then we might choose to support overlays directly as you suggested.

One more filter complex use case is burning in subtitles as an overlay on the video. ie.
-filter_complex "[0:v][0:s]overlay[v]" -map "[v]"
-filter_complex "[0:v][0:s]overlay"
https://trac.ffmpeg.org/wiki/HowToBurnSubtitlesIntoVideo


Border Added, And Major Color Changes

Fixes #509
Describe the changes you've made
Added Border Colour. Changed The Different Red's To a single Green Accent (Now the color scheme looks Uniform)
Changed the logo and Favicon
Deploy your changes to github page or netlify and mention deployment link:
Add the deployment link here- https://loving-albattani-ee09df.netlify.app/home.html
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist

[ ] I have mentioned related issue number in PR description.
[ ] I have added screenshots and related demo links of my changes..
[ ] The title of my pull request is a short description of the requested changes.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

I Will send a new pull Request with only Border changes in sometime.

I Will send a new pull Request with only Border changes in sometime.

Don't change the color theme.
Or any other unnecessary changes.


Add CarbonDeFi to sei ecosystem app list

What is the purpose of the change?
To add CarbonDeFi to the Sei Ecossystem apps.

Describe the changes to the documentation

Add CarbonDeFi item to the appData object
Add CarbonDeFi 400x400 image

Target Audience: Users wanting to find DEX and trading apps can see Carbon DeFi's SEI deployment.

I will get to this but for now the eco apps page is being hidden until I get time to update all the existing apps there with mainnet versions of them.

No worries, thanks! Feel free to use this PR/modify/delete


How to call StreamingRecognize method in multi-thread, every thread with a different stream source.

In which file did you encounter the issue?

Did you change the file? If so, how?

Describe the issue

If I call StreamingRecognize method in multi-threads,  the stream in every thread sent to StreamingRecognize method is from different client.  such as many Android devices send voice stream to CDN server, then CDN server send the stream to StreamingRecognize method at the same time, for StreamingRecognize method how to differentiate the stream from which Android device?

Is SpeechClient singleton or not? if not maybe I can create a SpeechClient instance in every thread to solve this problem?

Assuming they are coming from Android Devices (or multiple threads) as long as each one is using a different client, you should be able to send multiple different streams.
The line highlighted above, is saying that before you start streaming data to the service, you must first send a config.
As seen here: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/speech/cloud-client/src/main/java/com/example/speech/Recognize.java#L659-L673
The first message sent is the config, to tell the streaming service what to expect, then all subsequent requests are the actual data.
Does that answer your question?
(I'm going to verify if you need separate clients or not)

Update: turns out I was wrong, one client should be able to open multiple streaming requests on different threads.

Update: turns out I was wrong, one client should be able to open multiple streaming requests on different threads.

OK, many many thanks!


Make sure that arrow functions can be inlined by InlineSimpleMethods pass

In https://github.com/google/closure-compiler/pull/3757, we fixed a bug where certain arrow functions were incorrectly optimized without regard to references to this/super/arguments from the enclosing scope.
In general, though, most arrow functions don't have such references, so we want to make sure that we can still inline arrow functions that don't contain references to this/super/arguments.

Since InlineSimpleMethods seems to only inline functions that access properties off this, I couldn't come up with any cases where there would be arrow functions that could be meaningfully optimized by it. So I'm no longer clear on if there is really any benefit to doing this.


Create Sign Up Design (React)

Create Sign up Page on React following the design on Figma:

A "Back Button" that redirects to the Log in Page
Email Field with icon inside it and placeholder. (Border change color to brand color when focused)
Username Field with icon inside it and placeholder. (Border change color to brand color when focused)
Password Field with icon inside it and placeholder. (Border change color to brand color when focused)
below each field, make it possible to have an error message
(maybe) Birth Date Picker (Find a react library to make it easier)
A button that on click, will call #13
Options to sign up with google and Apple, don't do anything now

Finished UI for Sign up Mobile


[Hexagon][UnitTest] Disable flaky quantization test

The test_pass_fq2i_avg_pool2d.py::test_avgpool_conv2d test is sensitive to rounding errors, and failed about a third of the time (42 / 100 tests).  This was first noticed as CI failures in unrelated PRs (e.g. https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-hexagon/detail/PR-16184/6/tests). This commit marks the flaky portions of the test with pytest.mark.xfail, to avoid causing breaking CI for other PRs.
To minimize the extent of the disabled test cases, this commit breaks up each of the unit tests.  Where previously a single test performed both hardware/simulation tests and relay graph comparisons, these are now done in separate test functions.  The hardware/simulation tests use tvm.testing.assert_allclose and have a tolerance of 1e-02, while the graph-comparison tests use tvm.ir.structural_equal, and require identical floating-point values.  Only the graph-comparison test is disabled here.
The other two test cases in test_pass_fq2i_avg_pool2d.py do not show this same sensitivity, with no failures seen in 100 executions.

@rasagna-quic Can you take a look at this test case?  It was introduced in https://github.com/apache/tvm/pull/15599, and is failing about 1/3 of the time.  This PR is a stopgap to avoid impacting other work, but it should have a better fix.

@Lunderberg Thank you for these changes, these look good to me. I will work create a new PR to fix this issue.

@rasagna-quic Can you take a look at this test case? It was introduced in #15599, and is failing about 1/3 of the time. This PR is a stopgap to avoid impacting other work, but it should have a better fix for the long-term.


Error while retrieving the device session

Hi,
I can send the Data Push join message and receive and parse its response correctly with correct mic. However, when it tries to save the session I get the following error:
ERROR - can't pickle memoryview objects
This is during self.save() operation.
Syed

Would you please show the whole error message or locate the exception position in code? I didn't encounter such an error. This may cost by a bug. I use memoryview in some process to save processing time, but when it comes to pickle (actually it shouldn't appear in pickle process), the memoryview object should be casted into bytes to be pickled.

Hi following is the error trace
 - ERROR - can't pickle memoryview objects

Traceback (most recent call last):
  File "main.py", line 98, in main
    gateway.push(udp_client, phypld, mote)
  File "/lora-motes-emulator/motes/mac.py", line 304, in push
    self.parse_pullresp(pullresp[0], mote)
  File "/lora-motes-emulator/motes/mac.py", line 372, in parse_pullresp
    self.parse_txpk(txpk, mote)
  File "/lora-motes-emulator/motes/mac.py", line 416, in parse_txpk
    mote.parse_phypld(phypld)
  File "/lora-motes-emulator/motes/mac.py", line 1189, in parse_phypld
    self.parse_joinacpt(mhdr, macpld, mic)
  File "/lora-motes-emulator/motes/mac.py", line 1125, in parse_joinacpt
    self._initialize_session(optneg)
  File "/lora-motes-emulator/motes/mac.py", line 490, in _initialize_session
    self.save()
  File "/lora-motes-emulator/motes/mac.py", line 535, in save ```

The bug has been fixed.

Thanks @houluy it seems to be fixed.
However, I've found other issues in your documentations and Join algorithm.
Do you mind if I send a pull request? Cheers

@Gillani0 Please ~ I'm very appreciated! :)


Browser freezes when all lines are uncommented

This is an interestingly specific problem. When you uncomment all lines (can be only 1 line) in the editor using the keyboard shortcut, the browser tab freezes. Any idea what might be causing this issue?
I tested this using the bundled 2.10.0 version on OS X in Google Chrome 51.0.2704.103 and Mozilla Firefox 44.0.2.

I realized this seems to a problem only when I use a custom keyboard shortcut for commenting instead of the default one. I'm closing this issue as invalid.


PHP Warning:  Cannot bind an instance to a static closure in RouteGroup.php on line 42

I'm trying Slim 3 since RC1 and I've been facing this warning ever since. Below php -v output, stack trace and sample code to reproduce.
bash
PHP 5.5.9-1ubuntu4.14 (cli) (built: Oct 28 2015 01:34:46)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.3, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.2.3, Copyright (c) 2002-2013, by Derick Rethans
```

```bash
[Mon Nov 30 21:37:12 2015] PHP Warning:  Cannot bind an instance to a static closure in /home/flavio/slim30RC3/vendor/slim/slim/Slim/RouteGroup.php on line 42
[Mon Nov 30 21:37:12 2015] PHP Stack trace:
[Mon Nov 30 21:37:12 2015] PHP   1. {main}() /home/flavio/slim30RC3/public/warning.php:0
[Mon Nov 30 21:37:12 2015] PHP   2. Sample::register() /home/flavio/slim30RC3/public/warning.php:32
[Mon Nov 30 21:37:12 2015] PHP   3. Slim\App->group() /home/flavio/slim30RC3/public/warning.php:48
[Mon Nov 30 21:37:12 2015] PHP   4. Slim\RouteGroup->__invoke() /home/flavio/slim30RC3/vendor/slim/slim/Slim/App.php:273
[Mon Nov 30 21:37:12 2015] PHP   5. Closure->bindTo() /home/flavio/slim30RC3/vendor/slim/slim/Slim/RouteGroup.php:42
```

```php
<?php

require_once __DIR__ . '/../vendor/autoload.php';

use Interop\Container\ContainerInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

$app = new Slim\App;

Sample::register($app);

$app->run();

final class Sample {
  private $container;

  public static function register(Slim\App $app) {
    $app->getContainer()[Sample::class] = function (ContainerInterface $container) {
      return new \Sample($container);
    };

    $app->group('/sample', function () use ($app) {
      $app->get('/', 'Sample:index');
      $app->get('/hello', 'Sample:hello');
      $app->get('/world', 'Sample:world');
    });
  }

  public function __construct(ContainerInterface $container) {
    $this->container = $container;
  }

  public function index(ServerRequestInterface $request, ResponseInterface $response, array $args) {
    return $response->write('Hello world!');
  }

  public function hello(ServerRequestInterface $request, ResponseInterface $response, array $args) {
    return $response->write('Hello');
  }

  public function world(ServerRequestInterface $request, ResponseInterface $response, array $args) {
    return $response->write('world!');
  }

}
```

Am I doing anything wrong or missing something..?

Interesting way of doing things.
You can see through your stack trace that PHP is throwing an error because your closure is in a static context and you cannot reliably bind an instance of an object to it.
The solution would be to make a Factory Object from your register method.
Which might look something like this ... I totally wrote this IN github so do not rely on its syntax, just its idea.

$container = $app->getContainer();
$container['SampleFactory'] = function ($c) use ($app) {
    return new SampleFactory($app);
};

$container['Sample'] = function ($c) {
   return new $c['SampleFactory']->buildSample();
};

final class SampleFactory {
    protected $app;
    public function __construct(Slim\App $app) {
        $this->app = $app;
    }
    public function buildSample() {
         return new Sample($this->app);
    }
}

final class Sample {
  private $container;
  public function __construct(Slim\App $app) {
    $this->container = $app->getContainer();

    $app->group('/sample', function () use ($app) {
      $app->get('/', 'Sample:index');
      $app->get('/hello', 'Sample:hello');
      $app->get('/world', 'Sample:world');
    });

  }

  public function index(ServerRequestInterface $request, ResponseInterface $response, array $args) {
    return $response->write('Hello world!');
  }

  public function hello(ServerRequestInterface $request, ResponseInterface $response, array $args) {
    return $response->write('Hello');
  }

  public function world(ServerRequestInterface $request, ResponseInterface $response, array $args) {
    return $response->write('world!');
  }

}

Can we tell if a the callable is a static before we try to call bindTo()?

FWiW, testing shows that this is fixed in PHP 7.0

I can't see any way to detect if a closure is static before we call bindTo().

So the choices you have are:

Use PHP 7
Change the code as per @geggleto's suggestion
Don't use statics:

Remove static from the  register() method

Register like this:
$sample = new Sample($app->getContainer());
$sample->register($app);

@geggleto: Thanks for the suggestions! I think the lack of samples took me to take that approach and the fact that it works even though it throws warnings made me feel comfortable using it. I'd love to write project samples if I have guidance.
@akrabat: I'll be moving over to PHP7 as soon as it's released as I think this approach is a bit more organized than what @geggleto suggested. I tried to use $this->get instead of use ($app), but it doesn't seem to work inside register()'s static context.
Thank you both for help! It's very much appreciated!

Just for future reference, I did some digging and found the bug fix adding supporting on PHP7: https://bugs.php.net/bug.php?id=68792


Broadcast player stream in his/her own private room when playing in a match room

Context
In traditional restreaming competition, a player streams his own gameplay with webcam with the Stencil layout, while the restreamer captures the stream, cuts it to its own layout needs, and restreams.
With nestrischamps, there is no restreaming any more. There's only hosting a game. Game data from the player goes straight to the restreamer view, saving badnwidth and latency for everyone involved.
BUT this is limiting, player still want to have their own stream at the same time, and while they can stream their webcam, they cannot stream their gameplay on windows (because the input game video feed cannot be shared by both OBS and chrome).
TODO:
When a player is attached to a host's match room, the connection should additionally be attached to his/her own private room.
That way, while the restreamer can use whatever layout they like, the player may feed his own game frame into one of the single player layouts.

Done


pretrained model

could u please upload pretrained model? thx!

Hi! I'm a bit busy at the moment due to the next paper deadline, but I'll try to train and upload this week!

Hi,
training with the rewritten code proved a bit unstable, I'm trying some improvements now. Sorry for the delay, please stay tuned!

It's ok. Thanks very much!

Hi, I uploaded the pretrained model, check out src/core/pretrained_model.py for details.


CVE-2023-4759 vulnerability in JGit <= 6.6.0

CVE-2023-4759 describes a vulnerability in JGit <= 6.6.0. The recommendation is to:

Upgrade org.eclipse.jgit:org.eclipse.jgit to version <IP_ADDRESS>309021850-r or higher.

Additional information in Snyk here: SNYK-JAVA-ORGECLIPSEJGIT-5905182
What version of OpenRewrite are you using?
I am using

OpenRewrite v8.7.3

Are you interested in contributing a fix to OpenRewrite?
I have a PR ready to go but am unable to get a fully green local build due to other issues so it's hard for me to test locally.

Thanks for pointing out that CVE; wasn't aware, possibly because our reporting didn't pick up on the "Default Status: unaffected". Could see how this could get flagged in larger organizations though, so best to resolve all the same, and we already planned to upgrade JGit in a larger coordinated effort.
I've started a PR to hopefully resolve your build issues, although it's not yet clear what's required there, and I'm traveling / presenting today, so my time to look into it is somewhat limited:

https://github.com/openrewrite/rewrite/pull/3622

As also mentioned in the below pull request comment, we need a 5.x version of JGit to support Java 8.

https://github.com/openrewrite/rewrite/pull/3621#issuecomment-1782244343

because rewrite shades in jgit, there is no way for us to manage the transitive dependency up to 6.x (if we are not using java 8 anyway). is it possible to NOT shade this dependency?

Thanks for finding that backport; I've been checking that link every couple days, but no progress as of this past month. Let me know if you spot any updates there, as I didn't immediately see a way to subscribe to updates there.. :/

@timtebeek @dawngerpony please be aware that jgit moved from being hosted on the git server of the Eclipse foundation to being hosted on gerrithub instead. You seem to be looking for this release: https://gerrithub.io/c/eclipse-jgit/jgit/+/1174313
Also available via Maven: https://central.sonatype.com/artifact/org.eclipse.jgit/org.eclipse.jgit/<IP_ADDRESS>401111512-r
It contains this fix: https://gerrithub.io/c/eclipse-jgit/jgit/+/204642 as can be seen when checking the 5.13 branch merged changes: https://gerrithub.io/q/project:eclipse-jgit/jgit+branch:stable-5.13+is:merged

So it looks like we should update our shaded JGit version.

@bryceatmoderne given your recent work on https://github.com/openrewrite/jgit would you have any insights into what's needed to close this issue?

@bryceatmoderne given your recent work on https://github.com/openrewrite/jgit would you have any insights into what's needed to close this issue?

It appears the rewrite fork of jgit already includes the patch for https://gerrithub.io/c/eclipse-jgit/jgit/+/204642 via https://github.com/openrewrite/jgit/commit/856b4c90cdf135ddf990943218e8eb394626e995

Great, thanks! I'll assume we can close this one then. Does that match your findings on the latest release @dawngerpony ?


Named report no longer listed.  Now:  PSTN & SMS (preview) usage

Did the name of the available report change?  It appears the prior is no longer present.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0ad0c889-56d5-35fe-de15-177b6d922d07
Version Independent ID: e4363647-33e1-b665-5881-169fb619a5b3
Content: Microsoft Teams PSTN usage report - Microsoft Teams
Content Source: Teams/teams-analytics-and-reports/pstn-usage-report.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Hi @billvolt, thank you for your feedback.
Currently, it's "PSTN and SMS (preview) usage" report.


Generate Project.toml and remove REQUIRE

This is in preparation of the first release.

@scls19fr @andrewadare: Any objects to merging this and doing the release? I have installed Registrator and just need to trigger the build bot.

Sorry @tknopp but I can't personally merge this PR (I'm not a JuliaIO member and I haven't write access in JuliaIO/LibSerialPort.jl repository)
but @andrewadare or @samuelpowell can probably do this.

I can so this. Just want that someone is fine with this.

Oh yes! sorry I read too quickly! LGTM

should we merge #25 prior to the release?

I think first published release should be done before merging #25

why, what is wrong with #25? The convert thing reads like a clear bugfix to me.

Hope to you... I prefer to have one more release which will add this "bugfix" (which is more a new "feature" in fact)


[HUDI-304] Configure spotless and java style

Generate .editorconfig based on current Hudi checkstyle configs
Use .editorconfig to override IDE formatter
Use mvn spotless:apply to auto format java code

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

TODO

[ ] Manually verify some diffs after spotless apply won't conflict with IDE formatter and checkstyle

TODO

[ ] Manually verify some diffs after spotless apply won't conflict with IDE formatter and checkstyle

Codecov Report

Merging #2426 (9cb1268) into master (23e93d0) will decrease coverage by 40.89%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #2426       +/-   ##
============================================
- Coverage     50.54%   9.64%   -40.90%
+ Complexity     3033      48     -2985
============================================
  Files           417      53      -364
  Lines         18725    1929    -16796
  Branches       1917     230     -1687
============================================
- Hits           9464     186     -9278
+ Misses         8488    1730     -6758
+ Partials        773      13      -760

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudiflink
?
?

hudihadoopmr
?
?

hudisparkdatasource
?
?

hudisync
?
?

huditimelineservice
?
?

hudiutilities
9.64% <ø> (-59.83%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #2426       +/-   ##
============================================
- Coverage     50.54%   9.64%   -40.90%
+ Complexity     3033      48     -2985
============================================
  Files           417      53      -364
  Lines         18725    1929    -16796
  Branches       1917     230     -1687
============================================
- Hits           9464     186     -9278
+ Misses         8488    1730     -6758
+ Partials        773      13      -760

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudiflink
?
?

hudihadoopmr
?
?

hudisparkdatasource
?
?

hudisync
?
?

huditimelineservice
?
?

hudiutilities
9.64% <ø> (-59.83%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

...va/org/apache/hudi/utilities/IdentitySplitter.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-2.00%)

...va/org/apache/hudi/utilities/schema/SchemaSet.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-3.00%)

...a/org/apache/hudi/utilities/sources/RowSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-4.00%)

.../org/apache/hudi/utilities/sources/AvroSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-1.00%)

.../org/apache/hudi/utilities/sources/JsonSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-1.00%)

...rg/apache/hudi/utilities/sources/CsvDFSSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-10.00%)

...g/apache/hudi/utilities/sources/JsonDFSSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-4.00%)

...apache/hudi/utilities/sources/JsonKafkaSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-6.00%)

...pache/hudi/utilities/sources/ParquetDFSSource.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-5.00%)

...lities/schema/SchemaProviderWithPostProcessor.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-4.00%)

... and 394 more

@vinothchandar The style can be sync'ed by

using google-java-format in spotless config and spotless:apply enforces the style that is also compatible with existing checkstyle test
IDE install google-java-format plugin to control the formatter to use the same style

I committed 2 java files to show the diffs. The total diff will be huge, which can be solved by adding .git-blame-ignore-revs to ignore the formatting commits. Do the new style and the plan look good?

@vinothchandar The style can be sync'ed by

using google-java-format in spotless config and spotless:apply enforces the style that is also compatible with existing checkstyle test
IDE install google-java-format plugin to control the formatter to use the same style

I committed 2 java files to show the diffs. The total diff will be huge, which can be solved by adding .git-blame-ignore-revs to ignore the formatting commits. Do the new style and the plan look good?

@xushiyan we should probably pick this back up sometime?


tweaking python version

Hello @ksigler7,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


WebApp - UI bugs on the Account Detail screens

Describe the bug
UI bugs on the Account Detail screens

[x] Icon warning

[x] Export account screens: Update UI follow by design

[x] Still show exported account when click on X button

Steps:

Go to the Account Detail screen
Click on Export button
Input valid data then exported account
Click on X button
Click button Export account again

Actual: Still showing previous screen

Expect: Show the export account screen Step 1 to choose the export type

[x] UI bug when export all type

[x] Update title screen by export type

Version test: https://e5887c02.subwallet-webapp.pages.dev/
Validation passed
Notes: Waiting design in case exported all options to update later


Update .travis.yml

OpenCL headers were moved to Github (https://github.com/KhronosGroup/OpenCL-Headers/) and are no longer available at https://www.khronos.org/registry/cl/api/.

I forgot about AppVeyor. I'll fix that tomorrow.

Accidentally, I made this pull-request against the master branch.


proposal: runtime/race: add const Enabled

I've seen a lot of code like this:

// +build race

package p

const race = true

// +build !race

package p

const race = false

I think it would be better to have one boolean for that, and
the most logical place for it seems to be either
runtime/debug or runtime/race.

I’ve done this in the past to skip tests that were only useful with the -race flag set.

It seems to me a more natural place for this would be runtime/race.Enabled.

Note that the standard library has this already in internal/race.

@josharian, I can send a CL with something like:

package race

import "internal/race"

// Enabled tells whether the race detector was enabled when building.
const Enabled = enabled

const enabled = race.Enabled

If the proposal is accepted.

I too, have used this method manually in the past. The main counterargument here could be that one shouldn't make code behave differently when running in race mode - but that's already possible today, and I think there are plenty of legitimate use cases such as:

skipping tests that should only run in race mode
skipping tests that can't run in race mode, e.g. if they try to do a go build on a platform that doesn't support it yet
to propagate -race, for example if a test executes go run

I also think that, long term, we could replace internal/race.Enabled with runtime/race.Enabled throughout the repository. @ainar-g I assume you want to retitle the proposal, given that it still mentions runtime/debug.Race.

Here's another valid use case, I think: https://github.com/golang/go/issues/37681
If the proposal is accepted, runtime/race.Enabled could be used by third party libraries to implement similar "leaked without being closed" finalizer checks.

The “tests that should only run in race mode” are precisely (and only) those tests that verify run-time checks that are implemented using the race detector itself and do not build a new binary using go build or similar. (Any other check can be tested using a boolean, build tag, or environment variable.) Is that set significant at the moment? If not, perhaps a build tag suffices.
Propagating the -race flag to go run seems like a similarly niche use-case.

The set of “tests that can't run in race mode” should be empty. A variable whose value is set at compile-time is too late for guarding go build (since you could reasonably build the test itself in non-race mode even on a platform for which the -race tag is fully supported). For the go build use-case, we would need a separate predicate, more like the existing cmd/internal/sys.RaceDetectorSupported.

So, I agree that this would be useful in some cases, but those cases seem pretty rare — I'm not sure that they're worth the moral hazard of using the boolean to paper over actual races.

Another use case: In the compiler, when race mode is enabled, we randomize the order in which we compile functions. This is because the optimal ordering for performance was the least likely to flush out race conditions.

Another use case: Reducing the running time of a test in race mode. I encountered a test recently that experienced a drastic slowdown when run with -race, because of the heavy use of synchronization. Reducing the iterations with -race was the only reasonable fix I saw.

@josharian, maybe? But you can also reduce the running time of a test using testing.Short, and that's more-or-less orthogonal to the race detector.
(Plus, if one of your tests fails due to memory corruption in an ordinary run, it seems unpleasant for that test to change its behavior — perhaps dramatically! — when run under the race detector.)

But you can also reduce the running time of a test using testing.Short, and that's more-or-less orthogonal to the race detector.

You can, but as you point out, testing.Short is orthogonal. It seems better to tie the solution to the actual problem; I'd rather go test -race complete in a reasonable length of time.

it seems unpleasant for that test to change its behavior

It doesn't. It just runs less long; it's a stress test that runs for fewer iterations. If I were investigating memory corruption, I'd run it in the loop. Or read the test and notice the line that says if race.Enabled { iterations /= 10 }.

Every argument in favor of this seems to be primarily for tests, not for normal code. It seems that everyone agrees that normal code should basically never do something different depending on the presence of the race detector, and that the very rare exceptions to that can be handled just fine by the build tags, as they provide enough annoyance in so implementing something that it at least discourages you from doing so.
I personally have written a manual Enabled boolean for the race detector using the build tags and I also only used it for tests. In my case, Like @josharian's case, I had tests that iterated a number of times, and the race detector degraded the performance to the point that it took a prohibitively long time to run with the race detector, as in it was timing out the CI system, but the detection of races was more than sufficient after just a few iterations, whereas the general logic test was better to run a large number of times.
I'm personally somewhat ambivalent on the presence of a boolean on top of the build tags, but, all of that being said, why not put it in something more test specific, like testing/race, or even just inside testing itself?

@DeedleFake sometimes you test without package testing. And sometimes the place you want to add the hook is not in a test file. See my comment: https://github.com/golang/go/issues/36477#issuecomment-597802657.

Another use for this flag: When the race detector is enabled, profiling could emit warnings.
(Where and how to emit those warnings will vary; package testing might print them to stderr, third party packages might return an error from some API, etc. In an ideal world, we'd be able to write a message to the pprof output itself, which cmd/pprof would then display.)

It would be great to have a flag that specifies whether race detector is enabled or not.
Plenty of projects at github use the "build flag" approach https://github.com/search?p=1&q="Package+israce+reports+if+the+Go+race+detector+is+enabled."&type=Code
And in my case I need to propagate "-race" to "go build" command I invoke from tests. See https://github.com/anatol/booster/commit/35b1dda880736e1e559059eba2780b07707b4751
But it would be convenient to have something cleaner (like runtime.race.Enabled variable).

It seems like we have a variety of use cases, including some abuse cases. All the cases are already handled, with some complexity, by using build tags. Adding race.Enabled would make all the cases easier. The question is whether we want to encourage people to change test behavior based on the race detector. Today it's clear that's not something you're supposed to do, because it's so difficult to do it. Adding race.Enabled would make it seem like something you're expected to do, at least some of the time.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Another non-test-related use case I've encountered since my last comment is tweaking resource usage.  Since programs compiled with --race generally require more RAM and CPU time, some defaults might need to be changed, such as numbers of workers or cache sizes.  I don't recall, if the race detector still has the 8192-goroutine limit, but this could be another reason.

As I noted two weeks ago, the lack of race.Enabled today implies that most people shouldn't be using it in most contexts.
That's probably the right implication, and something we should keep, which would mean we should decline this issue.
(People can still work around it if they are sure they need it, but that extra work is useful to discourage such efforts.)
Do I have that right?

I don't recall, if the race detector still has the 8192-goroutine limit, but this could be another reason.

This limitation at least has been lifted on Linux and MacOS (and we're working on lifting it on Windows).

@rsc, I do not agree that it's currently “difficult”.  It is merely annoying.  If your goal is to discourage any difference between race and non-race code, you could remove the race build tags as well, and that would really make it difficult.  And I think that neither of these approaches are right.
@mvdan, @josharian, and I provided valid examples of non-test use cases, including propagation of the --race flag value to go calls, changing the number of resources used in race mode due to increased resource usage and other limitations, metrics output, debug checks, and some others.  Some of the test-related examples in this thread are valid as well.  @anatol has provided proof that the annoying approach is currently being used.
Leaving only the annoying approach would be approximately the same as not having GOOS and GOARCH and forcing people to only use build tags and const isWindows = true/false instead, at least to me.
I have no strong feelings either way, but the decision against this proposal will merely mean that this boilerplate code will propagate by copy-paste, because nobody would want to add an external dependency for a single boolean.  (At least in the Go realm, heh.)

Another use case is working around #37233, which seems to have been around for a while now.  This fits into the “Work Around Race Detector's Issues” category of use cases, along with the goroutine limit (soon to be gone) and RAM/CPU usage.

@ainar-g thanks for the reminder about #37233. That seems like a bug that we should fix rather than a reason for race.Enabled.

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

I still mildly support this proposal because I've had to resort to //go:build race a few too many times over the years. But I also admit that I don't represent the average Go programmer, so it's hard for me to judge whether the advantage of the convenience would outweigh the potential disadvantage of misuse or overuse.

No change in consensus, so declined.
— rsc for the proposal review group

For anyone else who wants an importable package, I just tossed one up at https://github.com/josharian/race (because I had to add it to yet another project, to work around https://github.com/golang/go/issues/69995).


ECS Fargate EFS volumeMount

Feature request
ECS Fargate supports the use of EFS now, and with that it might be a lot more useful to implement the volumeMount variable in the ecs task definition

How can we improve the module?

Implement the volumeMount variable in the ECS Task Definition so as to be able to refer to EFS mounts.

#43

Just out of curiousity, do you know if the performance will be good? I have seen people warn about issues using NFS storage for Prometheus.

Afraid not! Though we don't make use of Prom on EFS. Just static data that needs to be kept out of containers 😄

Fixed by #53


Update codemirror-vim to 6.2.1 and jupyterlab to 4.2.0

References
Fixes #109, amongst other bug fixes and enhancements in codemirror-vim (https://github.com/replit/codemirror-vim/compare/v6.0.14...v6.2.1).
Code changes

Bump codemirror-vim to 6.2.1.
Bump jupyterlab packages to 4.2.0 to get updated @codemirror/view for #109.
Add guards for possible null for cm.state.vim, introduced by codemirror-vim (https://github.com/replit/codemirror-vim/pull/162).

Known issues
Not introduced by this PR, but #138 is still broken. JL 4.1, which introduced the new behavior, was already required since #135, so this PR does not (by itself) make the conflict unavoidable.

Hi @krassowski and @ianhi, can either of you help release a new version? It seems like I don't have the permissions to do so. Not sure if it's worth mentioning #138 as a known issue in the release notes.

Not sure if this has to do with your permissions, it failed for me too: https://github.com/jupyterlab-contrib/jupyterlab-vim/actions/runs/10880534712 I think the token has expired, let me set it up for the trusted publishers mechanism

Ok, after https://github.com/jupyterlab-contrib/jupyterlab-vim/pull/147 and a few tweaks in the settings the release came through: https://github.com/jupyterlab-contrib/jupyterlab-vim/releases/tag/v4.1.4 - you should be able to update the release notes manually now :)


allow options to be passed to gray-matter

@doowb please review, merge if you think this won't break the internet

resolves https://github.com/assemble/grunt-assemble/issues/16

LGTM... not sure what's wrong with travis-ci though. I'll give it a few more minutes and see what happens.


conditionally install aws-lc-rs

Motivation
There was a recent panic on our app ( https://github.com/aptakube/aptakube/issues/319 ) and it was caused by this unwrap
Solution
I suppose we should always check if there's a CryptoProvider already installed before installing another one. That's how it's done here https://github.com/kube-rs/kube/blob/ecbdafc214538aadc78ec8447f2fa12d0057492b/kube-client/src/client/builder.rs#L85-L92 but for some reason the oidc.rs did not
I'm also explicitly installing aws_lc_rs (with a fallback to ring) on my app, so I would expect kube to just skip it as it's already installed
cc @mcluseau

Hi @goenning , I agree. It triggers some "should we factorize this" questions in my mind, but that's a question for another day :)
/lgtm


Inconsistency between stack trace line and source project in JSqlParser

When analyzing features in project, we find that some specific lines in stack trace are not in source project code, for example, considering the following stack trace.
net.sf.jsqlparser.JSQLParserException: null
    at java.lang.System.arraycopy(Native Method)
    at net.sf.jsqlparser.parser.SimpleNode.jjtAddChild(SimpleNode.java:39)
    ...

and the class SimpleNode is as follows, and we can clearly see that function jjtAddChild() is between line 55 and line 64, but the stack trace says that the exception point is at line 39 in jjtAddChild(), it sounds weird, isn't it?
/*
 * #%L
 * JSQLParser library
 * %%
 * Copyright (C) 2004 - 2017 JSQLParser
 * %%
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as
 * published by the Free Software Foundation, either version 2.1 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Lesser Public License for more details.
 *
 * You should have received a copy of the GNU General Lesser Public
 * License along with this program.  If not, see
 * <http://www.gnu.org/licenses/lgpl-2.1.html>.
 * #L%
 */
/* Generated By:JJTree: Do not edit this line. SimpleNode.java Version 6.1 */
/* JavaCCOptions:MULTI=false,NODE_USES_PARSER=false,VISITOR=true,TRACK_TOKENS=true,
NODE_PREFIX=AST,NODE_EXTENDS=,NODE_FACTORY=,SUPPORT_CLASS_VISIBILITY_PUBLIC=true */
package net.sf.jsqlparser.parser;

public
class SimpleNode implements Node {  /*** Line 27 ***/
  ...
  public void jjtAddChild(Node n, int i) { /*** Line 55 ***/
    if (children == null) {
      children = new Node[i + 1];
    } else if (i >= children.length) {
      Node c[] = new Node[i + 1];
      System.arraycopy(children, 0, c, 0, children.length);
      children = c;
    }
    children[i] = n;
  }  /*** Line 64 ***/
  ...
}

It seems that all these faults reside in project JSqlParser, which uses comment generation techniques during the compilation. Hence, the line number before and after compilation should have some inconsistencies. The other inconsistent stack traces include,
at net.sf.jsqlparser.parser.CCJSqlParserDefaultVisitor.visit(CCJSqlParserDefaultVisitor.java:10)

net.sf.jsqlparser.parser.SimpleNode.childrenAccept(SimpleNode.java:72)

net.sf.jsqlparser.parser.JJTCCJSqlParserState.popNode(JJTCCJSqlParserState:57)

Above all, I suggest that we should modify the source code the same with the byte code, i.e., deleting the generated comments in such java file.

Besides the above 3 kinds of conditions, there is still another interesting exception line in InsertModifierPriority,
net.sf.jsqlparser.JSQLParserException: null
	at java.lang.Enum.valueOf(Enum.java:238)
	at net.sf.jsqlparser.statement.insert.InsertModifierPriority.valueOf(InsertModifierPriority.java:28)
	at net.sf.jsqlparser.parser.CCJSqlParser.Insert(CCJSqlParser.java:819)

package net.sf.jsqlparser.statement.insert;

/**
 *
 * @author tw
 */
public enum InsertModifierPriority {  /*** Line 28 ***/
    LOW_PRIORITY, DELAYED, HIGH_PRIORITY, IGNORE
}


Update the nexus description and other documents on master before release.

Elaborate please?

That would be /master/Documents/Nexus.md and README.md.

Im leaving this open until some things are finalized with implementations branch.


Address Arch Board feedback

This includes considerations we're tracking with the service as well as direct client API issues.

@AlexGhiondea I am moving this to May since we'll do most of this work then.

Closing this since we're addressing issues filed in https://github.com/Azure/azure-sdk/issues/2514 directly.


Validation stop firing when custom rule used together with another rule (don't know if just in the described context)

Reproduction
https://formkit.link/bb3a2667b5f23695664de9ce0fa1214d
Describe the bug
Hello,
I've a strange problem with custom rules: when using a global registered custom rules together with an input prop registered custom rule, they stop working with a strange behaviour. Used individually they work as expected.
Details:
I have two inputs:

a Select Input ("Address Mode" with two options ["Static IP", "Public IP"])
a Text Input ("IP Address").

Using the Select Input I choose which type of IP address will be used on a specific environment.
If "Address Mode" is "Static IP", "IP Address"field is required and must be a valid IPv4 address; if "Address Mode" is Public IP, "IP Address" is disabled and its value is set to undefined by a commit event configured to "Address Mode" input.
The "IP Address" input field has two validation rules applied:

addressRule, which check if the field is required based on the value of "Address Mode";
ipv4, which check for IP correctness.

Trying to use the form, I notice that if "Address Mode" is untouched, the two validation rules are correctly applied. But, if I change the value of "Address Mode" to Public IP, then addressRule correctly fire but after that no other validations are performed on the following input changes.
It is worth to note that if the ipv4 rule is removed, everything works as expected.
I also tried to switch the ipv4 rule with another rule (the embedded email rule), and the strange behaviour comes again.
If instead I remove the commit event:
onMounted(() => {
  getNode('addr_mode').on('commit', ({ payload }) => {
    if (payload === AddrMode.PUBLIC) {
      getNode('address')?.input(undefined);
    }
  });
});

in order to remove any sort of forced mutation (the IP Address field which is set to undefined), the validation continue to fire only if the "IP Address" field is modified before changing the "Address Mode" select field, but only when "Address Mode" return to the Static IP value (rules are not fired when Public IP is selected).
I hope I covered all the cases. Willing to look into the issue further.
Thank you!
Environment
• OS: MacOS 14.5 (Apple Silicon)
• Browser: Chrome 125.0.6422.61
• Version<EMAIL_ADDRESS>

I was able to isolate this and reproduce it. It is a bug.

This is fixed in 1.6.4 — thanks for the reproduction 💪

Somehow after this fix my validation stopped working:

I have a custom validator, that makes the field required when status is 1
when I click submit validator works. But when I change the status, it makes no difference, error stays
if I then change the status to unpublished, it works ONLY if I enter something in title and then delete (so it triggers the validation). Somehow status stopped working due to changes in listeners change in the commit.

There are 2 groups with same name, I know, but for a reason (some fields are translatable and get transformed into groups so we can switch and show/hide them). This works perfectly fine for months, form value and all that. Well, so did this rule until 1.6.4 was done.
Is there ANY way I get that node.at actually reacting to status field change? Note that when there are 2 languages there are 2 fields with name status, each in it's own group, that's why the call for $root.translations.en.
I'd do it without groups but sadly we cannot name elements like translations.es.title and make it work as object, so this was the only option.
Reproduction: https://formkit.link/eade881392843ffc606cf62a1af24bb4

Hey! Unfortunately that validation rule was only working due to a bug in prior versions that caused rules to run more often than they should. The only reason this doesnt currently work is that there are 2 groups with the same name. Here it is working fine when they are grouped:
https://formkit.link/8c4094cc5c88ba4f880123891f9d17f8
I understand the rational behind why you need that, however groups by the same names just wont work. Alternatively you could directly assign nodes to a group by using the parent prop.


Code release

time?

Hi,
I apologize for the delayed response. I am currently working on a new submission, and the code requires some minor modifications and organization. I will release the code as soon as possible.
Thank you for your understanding.


refactor: Make entire consent box clickable

Description of change
This PR refactors the Checkbox components to optionally accept a custom store. This custom store can be used outside the component to change styling based on the store value.
Links to any relevant issues
Fixes #221. Check the issue for a screenshot of what was implemented.
How the change has been tested

Manual testing the UI of the /welcome/terms route (onboarding workflow).
All routes that use the Checkbox component in their UI need to be tested. There should be no visible change.

Definition of Done checklist
Add an x to the boxes that are relevant to your changes.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

If we merge it like this, only the areas colored in orange would react to a click, and not the entire box, right?

If we merge it like this, only the areas colored in orange would react to a click, and not the entire box, right?

Ouch, yes.


Disable thebelab on individual pages

Is it possible to disable thebelab on individual pages?
Here is my use case: I use thebelab for most of my pages. On some however, I would like to disable the feature, because I want to demonstrate something that I know will not work using thebelab/binder: For example, I have a page that uses the microphone of the local machine. In these cases I just want to render the notebook and offer a download button so that the viewers can play around with the notebook locally.

right now, it is not, but I think it's a good idea. Perhaps a notebook metadata like disable_thebelab or thebelab: false?
Also a note you should be aware of: we're finishing up a big re-write of the Jupyter Book backend, this should make it easier to install and build books, and also opens up a lot more functionality (like citations, cross-refs, etc). Check out the new build over here: beta.jupyterbook.org. Would love your input and thoughts!

Perhaps a notebook metadata like disable_thebelab or thebelab: false?

Yes! That would be awesome.

Check out the new build over here: beta.jupyterbook.org. Would love your input and thoughts!

I like it! It looks great, can't wait for the release! How are you planning the switch to the new backend? I could try to implement the disabling of thebelab on individual pages. But for me, this can wait. So would it make sense to wait with issues like this one until after the re-write?

yeah I think it'll be most-productive to have that implemented on the new codebase. Right now the plan is:

Move this repo to ExecutableBookProject/jupyter-book
Update this repo's master branch to be the new CLI branch
Keep the current master branch as a "legacy" branch (potentially)

Hello,

right now, it is not, but I think it's a good idea. Perhaps a notebook metadata like disable_thebelab or thebelab: false?

thebelab is simply too good to miss but I would like it to be disabled in some pages. Currently, I have an issue with the "png" files that are part of the code cell (using Panel: https://github.com/holoviz/panel).
I will be using more advanced interactive tools in the book, but is there something I am missing with my current issue.
Looking forward to your new version. Juypter-book is really good. Thanks for this great stuff.


adding basic script to use on jenkins

TBR

This is cool.
I thought we decided not to use shell scripts and instead use python?
@kalman @cmasone-attic @aboodman

We definitely decided not to use shell scripts back before you joined us, Mike :-/
We have some stuff like this in Go and some other stuff like this in python, mostly because Go has very limited file and directory manipulation stuff. There's tools/run_all_build.go and also some stuff in attic.git. The Right Thing here is maybe Go? I'm not certain. But we should back this out.

why TBR?

Hm, I'm guessing because this was grabbed from the jenkins config?

because this was grabbed from the jenkins config

in which case lgtm.

"why TBR?" because it is just one step toward having the build script hosted in the repository it is building and I needed to do some more configuration in Jenkins to use the script.  I wanted to keep making progress to get it working, but I can back it out if that is the correct choice here.

You can write scripts directly in the Jenkins console if you want to play with it.
If you TBR please explain why. In this case I wouldn't have TBRd.

Yes, correct. Sorry. My goal was to ensure the build script was in the source code repository and that Jenkins was running the script from the repo. I could have done this differently - sorry for the problem.

Cool no problem. Incidentally I absolutely agree that the script should eventually be in the repo.
In fact I recently moved a script out of the jenkins console into noms - which is why it was a bash script, not a python script. Unfortunately python scripts are harder to iterate on - just ping me or whoever and I can review ASAP.
Also: much easier to test unit python than sh.


[CI] arrow-compute: ExecPlanExecution.StressSourceOrderBy may failed

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/arrow/actions/runs/3812471160/jobs/6485697443
https://github.com/apache/arrow/actions/runs/3808810467/jobs/6479699758

Seems that the case may failed. And I didn't modify the case which could cause it failed.
Component(s)
C++

Thanks for the report.  I probably introduced this with #15104


[BUG] Dataclass Initialisation argument types and defaults not detected

Describe the bug
I'm using dataclasses extensively and would like to document the parameter types and defaults for each in a table. I noticed these are not picked up. I'm new to pytkdocs/mkdocstrings and so I may not be using the right approach.
I've looked at past issues on the topic but it is not very clear to me if this is expected to work.
To Reproduce
@dataclass
class C:
    """A C dataclass

    Args:
        a: A required number
        b: An optional number with default to 0
    """
    a: int
    b: int = 0

Expected behavior
The resulting equivalent that works:
class C:
    """A C dataclass"""

    def __init__(self, a: int, b: int = 0):
        """Initialisation

            Args:
                a: A required number
                b: An optional number
        """
        self.a = a
        self.b = b

System:

pytkdocs version 0.9.0
Python version: 3.8
OS: Linux

It definitely looks like a bug! Thank you for the report.
I need to rethink pytkdocs architecture, right now there are too many uncertainties like this in the code. See #64.

This is likely solved by the new handler. Feedback appreciated!


Exporting android with mangohud enable, without using the enviroment variable, godot fails to sign the apk

Godot version
v4.0.beta.custom_build [28a24639c]
System information
EndeavourOS Linux
Issue description
If mangohud its enable with the command godot fails to sign export apk with:
WARNING: Firma del Código: All 'apksigner' tools located in Android SDK 'build-tools' directory failed to execute. Please check that you have the correct version installed for your target sdk version. The resulting APK is unsigned.
If mangohud is loaded with the environment variable (MANGOHUD=1) works just fine.
Steps to reproduce
Just start godot on a command line with
mangohud godot
and export a project to android
Minimal reproduction project
N/A

Well i tested after downgrading jdk11-openjdk to version 11.0.17.u1-1 and works as always. Appears to be the combination of mangohud + jdk11-openjdk on version 11.0.18.u10-1 and up that causes the problem...

If it works with MANGOHUD=1 godot, but not with mangohud godot, the problem lies in the mangohud script, not in Godot.
It might be ignoring / resetting some environment variables which are needed for the export workflow.

With the command line doesn't show on the editor, so it works there as it should. Maybe it's something to do with the opengl part, since using the environment variable only loads the Vulkan part. The OpenGL part it's only loaded with the command line. Also, as i put in the comment above, appears to be the combination of jdk11-openjdk on the latest version with loading mangohud using the command. In other cases works fine.


Added missing return-statement in DefaultConfiguration.

This adds return $this to the fixPermissionsWith*-methods which were missing previously.

@daFish nice catch! I was making changes on this up to the very last minute :)  Thanks for fixing it.

@javiereguiluz You're very welcome. Glad I can help making this great bundle even more useful.


CPU usage increases after repeated recordings

Firstly thank you for the great work on RecordRTC.
I have an application which requires repeated recordings, and requires me to call initRecorder to sync the audio and video stream. I am using the StereoAudioRecorder and MediaStreamRecorder
videoRecorder.initRecorder(function() {
  audioRecorder.initRecorder(function() {
    // Both recorders are ready to record things accurately
    videoRecorder.startRecording();
    audioRecorder.startRecording();
  });
});

So on each new recording, I reset and delete the recorders and then re-initialise them with the function above.
Unfortunately at each new recording, my CPU usage starts to increase, and I believe it may have something with the webWorkers in StereoAudioRecorder.
var webWorker = processInWebWorker(mergeAudioBuffers);

So on every new recording I think it adds a new Worker to do audioProcessing.
I have tried hoisting the webWorker and added a terminate function to StereoAudioRecorder, which I call after I have stopped recording.
So now webWorker sits with the recorders other variables
...
var recordingLength = 0;
var webWorker;

this.terminateWebworker = function(){
  webWorker.terminate()
}

This didn't seem to help the CPU problem at all, and it may perhaps be a bug in the browser.
The other alternative I have tried is to initialise the recorders, and on any repeated recordings, I just use the same recorders and startRecording. However, The lengths of my repeated recorded audio and video files differ from the initial recordings, and for the application I would like to get these consistent. But this does not result in increased CPU usage.
So i'm wondering if there is a way to properly terminate the webWorkers so it doesn't increase CPU usage after multiple recordings?
Thanks for your help

Is there any special reason behind preferring StereoAudioRecorder + WhammyRecorder over MediaStreamRecorder? (because MediaStreamRecorder uses MediaRecorder API, which can record all tracks+streams in single container)
BTW, did you call clearRecordedData before initiating a new recorder? main documentation ref
if (typeof videoRecorder.getInternalRecorder === 'function') {
    var internal = videoRecorder.getInternalRecorder();
    if (internal instanceof WhammyRecorder) {
        internal.clearRecordedData();
    }
}

if (typeof audioRecorder.getInternalRecorder === 'function') {
    var internal = audioRecorder.getInternalRecorder();
    if (internal instanceof StereoAudioRecorder) {
        internal.clearRecordedData();
    }
}

// now re-initate the recorders
videoRecorder.initRecorder(function() {
    audioRecorder.initRecorder(function() {
        // Both recorders are ready to record things accurately
        videoRecorder.startRecording();
        audioRecorder.startRecording();
    });
});

My use case is that I would like to play a click track alongside a recorded music segment, so syncing the start times of the recorded video with a metronome is really crucial. Here I start recording at the same time as playing a metronome.
        this.videoRecorder.recordRTC.initRecorder(() => {
        this.audioRecorder.recordRTC.initRecorder(() => {
          this.bar8.play()
          this.audioRecorder.startRecording()
          this.videoRecorder.startRecording()
        })
      })

On repeated recordings I simply do this:
      this.bar8.play()
      this.audioRecorder.startRecording()
      this.videoRecorder.startRecording()

I then play back the recorded metronome with a separate metronome beat. This allows me to see if there is any difference between the start times of the recorded music segment and a regular click track. I make sure all resources are loaded and run:
        this.recordedSound.seek(delay)
        this.videoPlayer.currentTime(delay)
        this.recordedSound.play()
        this.videoPlayer.play()
        this.bar8.play()

MediaStreamRecorder did not give me the duration of the recording until I played through the video fully. This meant I could not find the delay between the length of the bar8 audio and the recorded sample. Once I had found the duration from a full playback, I found that variation of the length of the video was also quite large, meaning I wouldn't get a full music clip.
However, StereoAudioRecorder  gave me the duration back and also consistent results. The WhammyRecorder had some variation, but I was more concerned with get the audio syncing correctly. The delay varied between initial recordings and repeated recordings by 0.1 seconds.
I was also initially using the clearRecordedData() function, but changed to the reset function to see if it would make any difference, unfortunately neither removed the webWorkers.
So getting rid of the webworkers was to try and get consistent recordings as increased CPU usage was interfering with the delay that the recordings experienced. Perhaps i'm doing the entire thing in a very bad way, and would be welcome to any suggestions you may have, with regards to syncing the start time of the recorded metronome beat.
Again, thank you for the help.


what is S (strip)?

can you tell me in the code here
what S is, I see it is set to 72, why? is it gonna be a different number for each dataset?
can you please verify what are strip_size and self.n_strips and what are their usages
Thanks

In the paper, S is named Npts.

@lucastabelini can you please verify what are strip_size and self.n_strips and what are their usages

If you divide an image in n_strips identical horizontal strips of size strip_size you'll have n_offsets horizontal lines that separate those strips.

Thank you


Docs updates

Some basic docs updates to make installation instructions more clear for novice python users (#96). Still needs some work.
1.) @NickleDave can you please add instructions for installing with "pure Python environment"?
2.) @NickleDave can you please confirm which version of Python the repo depends on?

Thanks so much @ralphpeterson for taking care of this.

1.) @NickleDave can you please add instructions for installing with "pure Python environment"?
2.) @NickleDave can you please confirm which version of Python the repo depends on?

I added the following:

A section with the single command, for people that already uderstand envs etc. and just want a single thing to copy-paste into their terminal
A section below that with what you added (thank you!) as well as the "pure Python" commands
I added an "admonition" that explains which versions of Python that VocalPy will work with. The short answer is that right now we require python>=3.9. The longer answer is that I realized we should drop 3.9, see #102. For the conda commands, I changed to python=3.11. Annoyingly, this can go stale, but at the moment I don't want to deal with automating a check for that.

I also made some other changes while I was at it. You don't need to review this but if you have comments I'm happy to hear them.
I just want to make the landing page less verbose and also restructure the docs as per The Grand Unified Theory of Documentation. Basically I am copying the style of of the numpy docs and scipy docs. Hopefully not in such a way that my PhD will be revoked for plagiarism. To achieve this I revamped the front page and moved other material around. The "user guide" is basically wishful thinking right now, I will raise an issue with what sections I think should be there; we can edit that as we figure it out more.
Note that the link to the contributing guide is also broken, will be fixed in #101
Build is here on readthedocs:
https://vocalpy--99.org.readthedocs.build/en/99/
Page you revised:
https://vocalpy--99.org.readthedocs.build/en/99/getting_started/installation.html

@all-contributors please add @ralphpeterson for documentation

looks great!

Excellent, thanks again for your help


Custom day names

Describe the solution you'd like
I'd like to be able to set the shape of the day names in the header. Although it's possible to change the day names using a locale, it isn't possible (AFAIK) to change the format in the names, something like the following:

try this:
<DatePicker
formatWeekDay={(day) => day.slice(0, 3)}
/>


Graphics issues and low fps when using the pluginloader.

when using the pluginloader I have bad graphics and low fps, when I use the default game launcher everything runs smoothly and graphics look good, can I get some help?
Thanks - endlesstonks

What system specs do you have? You might have to set the gpu in graphics settings to be your dedicated gpu.

[](/endlesstonks I will try that now, thanks!

Is the correct gpu selected in the game display settings?


python310Packages.dvc-data: 0.53.0 -> 0.54.2

Diff: https://github.com/iterative/dvc-data/compare/refs/tags/0.53.0...0.54.2
Changelog: https://github.com/iterative/dvc-data/releases/tag/0.54.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 235497 run on x86_64-linux 1

2 packages failed to build:

python311Packages.dvclive
python311Packages.dvclive.dist

10 packages built:

dvc
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist
python310Packages.dvc-data
python310Packages.dvc-data.dist
python310Packages.dvclive
python310Packages.dvclive.dist
python311Packages.dvc-data
python311Packages.dvc-data.dist


ROX-24913: Verify URLs read form dockerconfig secrets

Description
Dockerconfig secrets contain URLs of container registries. Those secrets are defined by the users on their clusters. Sensor reads those secrets and tries to dial the registries and discover whether they are TLS terminated.
We want to make sure that the URLs are valid and a call to such URL has chances of succeeding before we call it.
This PR adds such validation early in the process. If an invalid URL is found, an error is printed to the logs and processing of such secret is skipped.
Checklist

[ ] Investigated and inspected CI test results
[x] Unit test and regression tests added

N/A

[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change

[x] Unit tests
[ ] On a cluster with creation of dockerconfig secret that contains a space in the URL

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

I'm quite sure this covers the issue we've seen recently. Here is my understanding
We see URL of the following format being attempted: "tcp:// registry-dev.<acme-corp>.com:443" in the logs. The tcp:// comes from our code here. So apparently a string with a leading space was provided. " registry-dev.<acme-corp>.com:443" is rejected by url.Parse(), so apparently we added the port here.
So the problematic input that is allowed by url.Parse() but after a series of transformations becomes invalid is " registry-dev.<acme-corp>.com". With that, I'd suggest to strip leading and trailing spaces. At the very least, add this example to the test case : ).

I think this could make invalid secrets with registries like "quay.io:443/whatever/path". Are we ok with this?

Yeah, that is a problem. I guess, this validation would need to look a bit differently. Let me propose a different version

Apparently validating the host name is not so trivial (there are many more characters that are disallowed). I would close this PR in favor of #11668, which seems to be a better place to check that.


[Enhancement]: Master Typing Score Keeper

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
The game does not provide the user with data on the number of keys that were correctly or incorrectly pressed. We can also give the user information about the key that was pressed incorrectly the most number of times at the end of game.
Describe the solution you'd like
Solution steps

Changes in CSS and HTML to add new counters to keep track of the scores for correct and incorrect key presses.
Changes in JavaScript to update the counters and turn the keys red that were pressed incorrectly the most number of times at the end of the game.

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @KrishnaKalra !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @KrishnaKalra ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Update waas-delivery-optimization.md

Added support for Edge browser installations and updates.

I don't know the specifics, but would an update like this warrant an update to the metadata date field as well?

thanks for asking, no need to update the metadata field for this change.

#sign-off


Health Service: retrieving heart rate data

I have modified Measure data: health service to collect heart rate data. The app collects data properly while sitting ideally, but when I start walking app keeps updating and not collecting data.
The embedded sensor's instant data is shown in the Samsung Health app but the health service API is not collecting data while there is a movement.

Can you share what device and Wear OS version you are seeing this on? I'm unable to reproduce this on my end.
Alternatively, are you able to try using the MeasureDataCompose sample and see if that works for your use case? We will be removing the MeasureData and other views from the main branch soon in favor of the Compose versions.


Bug: timescale_peering_connection provisioned_id is null before refresh

Hi, I'm using this provider to create a timescale database for testing the saas product. Since we would like to use a private endpoint, I use the timescale_peering_connection resource to peer with our vpc.
If I place my aws_vpc_peering_connection_accepter directly next to the timescale_peering_connection I can directly use the provisioned_id as an input for the vpc_peering_connection_id
Here is some example code
resource "timescale_peering_connection" "peering" {
  peer_account_id  = var.aws_account_id
  peer_region_code = var.aws_region
  peer_vpc_id      = var.vpc_id
  timescale_vpc_id = timescale_vpcs.vpc.id
}

resource "aws_vpc_peering_connection_accepter" "accepter_to_timescale" {
  vpc_peering_connection_id = timescale_peering_connection.peering.provisioned_id
  auto_accept               = true

  accepter {
    allow_remote_vpc_dns_resolution = true
  }

  tags = {
    Name        = "timescale/${timescale_vpcs.vpc.name}"
    description = "Peer ${var.aws_account_id}/${var.vpc_id} to timescale/${timescale_vpcs.vpc.name} for project_id ${timescale_vpcs.vpc.project_id}"
    side        = "accepter"
  }
}

However this is not working, as get following error that indicates, that the provisioned-id is null.
│ Error: Missing required argument
│
│   with aws_vpc_peering_connection_accepter.accepter_to_timescale,
│   on main.tf line 14, in resource "aws_vpc_peering_connection_accepter" "accepter_to_timescale":
│   14:   vpc_peering_connection_id = timescale_peering_connection.peering.provisioned_id
│
│ The argument "vpc_peering_connection_id" is required, but no definition was
│ found.

To proof that I directly pulled the state from terraform by executing terraform console
❯ terragunt console
zsh: command not found: terragunt
❯ terragrunt console
INFO[0000] Terragrunt Cache server is listening on <IP_ADDRESS>:50798
INFO[0000] Start Terragrunt Cache server
> timescale_peering_connection.peering
{
  "error_message" = tostring(null)
  "id" = tonumber(null)
  "peer_account_id" = "0123456789"
  "peer_cidr" = tostring(null)
  "peer_region_code" = "eu-central-1"
  "peer_vpc_id" = "vpc-012345467890"
  "provisioned_id" = tostring(null)
  "status" = tostring(null)
  "timescale_vpc_id" = 1234
  "vpc_id" = tostring(null)
}
> exit

Executing the apply again I get a change on the resource and the code starts working.
  # timescale_peering_connection.peering has changed
  ~ resource "timescale_peering_connection" "peering" {
      + provisioned_id   = "pcx-0123456789"
        # (4 unchanged attributes hidden)
    }

I would expect this to work, as the resource aws_vpc_peering_connection from aws to create a vpc peering between multiple vpcs is waiting until there is the pcx-.. available.
I've tried to update my code to add a delay, unfortunately that wasn't successful.
resource "timescale_peering_connection" "peering" {
  peer_account_id  = var.aws_account_id
  peer_region_code = var.aws_region
  peer_vpc_id      = var.vpc_id
  timescale_vpc_id = timescale_vpcs.vpc.id

  # We delay here the creation of the peering, as the provisioned_id is null until aws is ready
  # and unfortunatly the provisioner directly gives us this null object back without waiting for
  # aws to be ready. Otherwise we can't use this in aws_vpc_peering_connection_accepter object.
  provisioner "local-exec" {
    command = "sleep 90"
  }
}

I also have here a log file to see the commands I've executed:
bug_timescale_provider_retracted.txt
Thanks in advance for any feedback, idea or help.
BR eddyfussel

Hello @eddyfussel,
I encountered the same issue myself when developing it, and had some issues fixing it.
IIRC, the code handling the timescale peering connection doesn't surface the provisioned-id so I think it needs wider code change on our end I didn't have the opportunity to, so released that half way done.
I'm sorry for the inconvenience.
As for when this might be fixed, I think this provider will not see some love again until Q3/4.


Bake action: overrides how to delimit different values ?

Its seems the source code is delimiting by "\n" but how to use it in the task ?
You should add that to the documentation

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72bba72b-235b-ce64-b8fd-2c6ed52a9f1f
Version Independent ID: 2ae1b3f1-e125-a9d2-a17c-d13047d69801
Content: Kubernetes Manifest task - Azure Pipelines
Content Source: docs/pipelines/tasks/deploy/kubernetes-manifest.md
Product: devops
Technology: devops-cicd
GitHub Login: @shashankbarsin
Microsoft Alias: shasb

This issue has been addressed in the recent set of updates for this document.


Waves Dex  Is it possible to create own matcher against the orders in alreay existing matcher?

Hi Waves Team,
I want to create own dex like dex ethereum. I explore the documentation then i create buy and sell order using wavekeeper.
Here i want to provide and maintain the Dex platform in waves but the problem is orders Fees is transferring to matcher keys. How could i controlled that and how can i create my own matcher key. please a give a possible solution for creating own Dex in waves platform.
Thanks.

Another one doubt the sell/buy order fees 0.003 WAVES can be reduce after each successful transaction from buyer/seller is that is default or we can modify that.

Here some options: https://github.com/wavesplatform/dex/blob/master/dex/src/main/resources/application.conf#L92


update references of search to dimension-search

What
Describe what you have changed and why.

Update references of search to dimension-search in search package

How to review
Describe the steps required to test the changes.

Check if references of search in the search package have been renamed to dimension-search
Check if the test passes

Who can review
Describe who worked on the changes, so that other people can review.
Anyone

Should the function at:
https://github.com/ONSdigital/dp-api-clients-go/blob/3e44850b678094201b8e25e38751c968c7c6d720/search/search.go#L33
be renamed to:
ErrInvalidDimensionSearchAPIResponse
Also, should the parameter at:
https://github.com/ONSdigital/dp-api-clients-go/blob/3e44850b678094201b8e25e38751c968c7c6d720/search/search.go#L61
be renamed from:
searchAPIURL
to:
dimensionSearchAPIURL

Good spot. Loving it


Add stop_emission()

Adds the stop_emission() function. I believe the function signature and code is correct, but seems very straightforward to me, so may be wrong.
I haven't gotten this integrated into my code yet as I don't know how to get the signal_id or the detail argument yet, but I figured I'd post it now and report back once I've tried it out a bit.

IMHO better implement g_signal_stop_emission_by_name.

@EPashkin I've started using stop_emission_by_name(), which I think is supposed to be called in a callback and isn't a global call done outside of the callback, but the Gtk docs aren't clear on this. Maybe you could clear this up?
Regardless I've tried to run this on my code, but it fails when I do the following:
extern crate glib;
extern crate gtk;

use glib::object::Object;
use gtk::prelude::*;
use glib::signal::stop_emission_by_name;

let text_view = gtk::TextView::new();
let buffer = text_view.get_buffer().unwrap();
stop_emission_by_name(buffer.upcast::<Object>(), "GtkTextBuffer::insert-text");

And now I end up with errors like:
$ cargo build
   Compiling gattii v0.1.0
src/main.rs:196:34: 196:40 error: the trait bound `glib::Object: gtk::StaticType` is not satisfied [E0277]
src/main.rs:196     stop_emission_by_name(buffer.upcast::<Object>(), "GtkTextBuffer::insert-text");
                                                 ^~~~~~
src/main.rs:196:34: 196:40 help: run `rustc --explain E0277` to see a detailed explanation
src/main.rs:196:34: 196:40 error: the trait bound `glib::Object: glib::wrapper::UnsafeFrom<glib::object::ObjectRef>` is not satisfied [E0277]
src/main.rs:196     stop_emission_by_name(buffer.upcast::<Object>(), "GtkTextBuffer::insert-text");
                                                 ^~~~~~
src/main.rs:196:34: 196:40 help: run `rustc --explain E0277` to see a detailed explanation
src/main.rs:196:34: 196:40 error: the trait bound `glib::Object: glib::wrapper::Wrapper` is not satisfied [E0277]
src/main.rs:196     stop_emission_by_name(buffer.upcast::<Object>(), "GtkTextBuffer::insert-text");
                                                 ^~~~~~
src/main.rs:196:34: 196:40 help: run `rustc --explain E0277` to see a detailed explanation
src/main.rs:196:34: 196:40 error: the trait bound `gtk::TextBuffer: gtk::IsA<glib::Object>` is not satisfied [E0277]
src/main.rs:196     stop_emission_by_name(buffer.upcast::<Object>(), "GtkTextBuffer::insert-text");
                                                 ^~~~~~
src/main.rs:196:34: 196:40 help: run `rustc --explain E0277` to see a detailed explanation
src/main.rs:196:34: 196:40 help: the following implementations were found:
src/main.rs:196:34: 196:40 help:   <gtk::TextBuffer as gtk::IsA<gtk::Object>>
src/main.rs:196:27: 196:52 error: mismatched types:
 expected `*mut glib::object::GObject`,
    found `glib::Object`
(expected *-ptr,
    found struct `glib::Object`) [E0308]
src/main.rs:196     stop_emission_by_name(buffer.upcast::<Object>(), "GtkTextBuffer::insert-text");
                                          ^~~~~~~~~~~~~~~~~~~~~~~~~
src/main.rs:196:27: 196:52 help: run `rustc --explain E0308` to see a detailed explanation
error: aborting due to 5 previous errors
error: Could not compile `gattii`.

To learn more, run the command again with --verbose.

I think I'm calling it correctly. Though using a string to identify the signal name that isn't checked at compile time is very not-rusty. Qt supports compile-time signal checking, which I found invaluable as having signal connection errors is very easy to do without compile-time checking. Though maybe this improvement should come after this initial implementation.

Also, appveyor is running tests on Rust 1.6 that seem to fail unrelated to my implementation (something about menu.rs using an unstable feature). Maybe the minimum rust version needs to be upped and appveyor updated accordingly? Travis is only checking on 1.9+, and gtk only checks on 1.9+ as well.

Instead upcast try .to_glib_none().0
Yes we need update same in Gtk. Can you add separate PR for this?

Also IMHO stop_emmission_by_name don't need be unsafe. What you think, @gkoz ?

@EPashkin .to_glib_none() isn't implemented for TextBuffer. Am I misunderstanding what you said?

No I don't think they need to be unsafe. Generally, since these functions are intended for the users, their APIs should be high-level, like the rest. E.g.
pub fn stop_emission_by_name<T: IsA<Object>>(instance: &T, signal_name: &str)

For the other function this means adding a conversion from str to GQuark and creating an opaque type for the signal id. But is it worth the effort when there's a by_name alternative?

Agree that stop_emission unneeded if stop_emission_by_name working with just signal names without details.

Also agree that function need generalization.
If we remove stop_emission then stop_emission_by_name better take its name

Well it's possible someone will want the real stop_emission in the future so I'd rather not rename.

Here's an updated version that provides a little bit nicer interface. I'm still getting the same errors as before about the trait bound gtk::TextBuffer: glib::IsAglib::Object not being satisfied with the following code example:
extern crate glib;
extern crate gtk;

use glib::object::Object;
use gtk::prelude::*;
use glib::signal::stop_emission_by_name;

let text_view = gtk::TextView::new();
let buffer = text_view.get_buffer().unwrap();
stop_emission_by_name(&buffer, "GtkTextBuffer::insert-text");

According to the docs TextBuffer implements the IsA<Object> trait. Am I missing something here?

I can't reproduce the error, seems all right to me. Could you please also reexport the functions in lib.rs, we only keep the "implementation detail" ones in modules.

Fixed the import path, but I don't understand what you mean about re-exporting in lib.rs. It's already exported through the signal module, or did you want me to actually move the implementation for these two functions into lib.rs directly?

Oh I've actually missed another thing. Look at this piece of code. All actual bindings functions we define keep their whole names except for the the g_, gtk_ etc. prefix (e.g. signal_stop_emission_by_name) and are reexported (pub use) at the top level of their crates. Organizing naming hierarchically like it's customary in Rust would've complicated code generation and confused experienced GTK+ users.

@gkoz I think I've fixed it. Can you tell me if this now looks right? Right now if I import gtk::prelude::* then I still can't use signal_stop_emission_by_name() without an additional import statement. And you can't use glib::prelude::* as that fails due to conflicting with gtk::prelude::*, but I can import it directly. Is that the correct/ideal behavior?

But I also have been unable to use this function, here's a complete project:
Cargo.toml:
[dependencies]
gtk = { git = "https://github.com/susurrus/gtk" }
glib = { git = "https://github.com/susurrus/glib" }

src/main.rs:
extern crate glib;
extern crate gtk;

use gtk::prelude::*;
use glib::signal_stop_emission_by_name;

fn main() {
    let text_view = gtk::TextView::new();
    let buffer = text_view.get_buffer().unwrap();
    signal_stop_emission_by_name(&buffer, "insert-text");
}

The output of this simple project is:
$ cargo build
   Compiling test_signal v0.1.0 (~/Projects/test_signal)
src/main.rs:10:5: 10:33 error: the trait bound `gtk::TextBuffer: glib::IsA<glib::Object>` is not satisfied [E0277]
src/main.rs:10     signal_stop_emission_by_name(&buffer, "insert-text");
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/main.rs:10:5: 10:33 help: run `rustc --explain E0277` to see a detailed explanation
src/main.rs:10:5: 10:33 note: required by `glib::signal_stop_emission_by_name`
error: aborting due to previous error
error: Could not compile `test_signal`.

To learn more, run the command again with --verbose.

I confirmed that error present in new project, will look at it this evening.
Strange, but if you add this code in examples\gtktest.rs it compiles fine.
May be problem with many [[package]] name = "glib" in Cargo.lock
and you need replace all gtk modules.
Or just get pull it all in same superfolder as test project and place .cargo\config in it with something like
paths = [
 "d:/eap/rust/0/sys/glib-sys",
 "d:/eap/rust/0/sys/gobject-sys",
 "d:/eap/rust/0/sys/gio-sys",
 "D:/eap/rust/0/gio",
 "D:/eap/rust/0/glib",
 "D:/eap/rust/0/cairo",
 "D:/eap/rust/0/cairo/cairo-sys-rs",
 "d:/eap/rust/0/sys/pango-sys",
 "D:/eap/rust/0/pango",
 "d:/eap/rust/0/sys/gdk-sys",
 "d:/eap/rust/0/sys/gdk-pixbuf-sys",
 "D:/eap/rust/0/gdk-pixbuf",
 "D:/eap/rust/0/gdk",
 "d:/eap/rust/0/sys/gtk-sys",
 "D:/eap/rust/0/gtk",
]

May be just one path "D:/eap/rust/0/glib" do work.

It really compiles with only glib path override in .cargo\config
.cargo
  config
glib (from github.com/susurrus/glib)
test

with deps in Cargo.Toml
[dependencies]
gtk = { git = "https://github.com/gtk-rs/gtk" }
glib = { git = "https://github.com/gtk-rs/glib" }

Is that because gtk pulls in glib as well? So once this PR is pulled this shouldn't be a problem anymore, correct?

@Susurrus, yes

@GuillaumeGomez r+?

Sorry, I wasn't following. Let me catch up before.

No doc on it?

Ignore my previous question, I got my answer. It's good for me. Really nice work @Susurrus!