Fix fleet health-box in local cluster

Summary
Fixes https://github.com/rancher/dashboard/issues/10705

Occurred changes and/or fixed issues

Technical notes summary

For the local clusters, there is no fleet-agent - we are now checking the cattle-fleet-system/fleet-controller deployment
Adding 400 errors handling

Areas or cases that should be tested

Cluster's dashboard page -> health boxes

Areas which could experience regressions

Screenshot/Video

Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

I've re-run the unit tests and they still fail... You should check what's happening there.

@aalves08 I just pushed a rebase, let's see id it succeeds.

Also, about the error handling, I'm slightly confused here... Is it about setting it to null when there's errors, which will then trigger the STATES_ENUM.UNHEALTHY marker?

Yep, fleet and cattle agents have 'loading' as initial value to show the spin icon - STATES_ENUM.IN_PROGRESS; in case of https errors, they are set to null, which means STATES_ENUM.UNHEALTHY.


Add GGP Mimetype

Adds .ggp mimetype to the app-registry
Fixes https://github.com/owncloud/enterprise/issues/6907

Why do you need it in the app registry? Do we have an app provider for that?
If you want to just have the mime type, we need it in Reva.

Closed in favor of https://github.com/owncloud/ocis/pull/10304


Add rule: at-rule-no-unknown

Addresses #86 by adding a "new" rule extending stylelint's at-rule-no-unknown with a built-in list of exceptions including at-rules supported by Sass/SCSS.

Thanks! I'll try to review this as soon as possible

I had a look and this seems to add the missing things from @dryoma's pull request.
Would it be possible for you to add the README and CHANGELOG changes from https://github.com/kristerkari/stylelint-scss/pull/92? You can simply add a section called HEAD to the change log. I can then merge this and release a new version.
Thanks a lot for your contribution!

@kristerkari I've added the changes. Hopefully everything is there.

Thanks! Looks good now.
I'm going to cut merge and then release a new version (might not have today since I need to leave soon, but if no then tomorrow).

Released as 1.5.0 https://github.com/kristerkari/stylelint-scss/releases/tag/1.5.0 🎉


Mix - Charlie Puth

https://youtube.com/playlist?list=RDEM949q3ncRbPygD371mCoe9A&playnext=1&si=noDVzffDVlEvA6qs
@RGBmonsterBot `SnapThat Project Draft
Overview
SnapThat is an innovative platform that combines multimedia content creation with blockchain technology, offering a seamless way to capture, share, and monetize moments. The platform integrates NFC-enabled devices and NFTs, creating unique digital assets from physical and digital experiences.

Mission
To empower users to create, preserve, and monetize their memories through cutting-edge technology, fostering creativity and community engagement.

Features

Multimedia Content Creation:

Capture photos, videos, and audio clips.
Edit and enhance content using AI-driven tools.

Blockchain Integration:

Mint NFTs directly from captured moments.
Store metadata securely on a decentralized platform.

Social Sharing:

Share content on SnapThat’s community or external social platforms.
Earn rewards through likes, shares, and engagement.

Monetization:

Sell NFTs of unique moments in an integrated marketplace.
Collaborate with brands and sponsors for exclusive content.

Phase-Based Development
Phase 1: Concept and Prototyping

Budget: $10,000
Develop core features: content creation tools and basic blockchain integration.
Create a user-friendly interface for seamless interaction.

Phase 2: Beta Launch

Budget: $15,000
Release a beta version to a select user base.
Test usability, gather feedback, and optimize.

Phase 3: Full Launch

Budget: $20,000
Launch SnapThat to a global audience.
Integrate advanced features like NFT trading and partnerships.

Phase 4: Marketing and Growth

Budget: $5,000
Run targeted marketing campaigns.
Establish partnerships with influencers and brands.

Associated Account
Account Name: SnapThat

Purpose: Dedicated to managing SnapThat’s operations, marketing, and user engagement.
Platform Usage:

Social Media: Instagram, Twitter, TikTok, and LinkedIn for promotions and updates.
Blockchain Wallet: For minting NFTs and managing transactions.

Admin Tools:

Analytics platforms for user insights.
CRM tools for managing user interactions and feedback.

Goals

Reach 50,000 active users within the first six months post-launch.
Mint and trade 10,000 NFTs by the end of the first year.
Establish partnerships with at least 20 brands in the first year.

Call to Action
Be part of SnapThat’s journey to revolutionize how we capture and monetize moments. Join us in building a community where creativity meets technology.

Next Steps

Finalize branding and secure domain: SnapThat.io.
Set up associated accounts and wallets.
Launch a pre-registration campaign to build anticipation.

`
Let's encapsulate all that information into a Python and Java script! Here's how you can structure it:

### Python
```python
# Define your SAN numbers with the 007 identifier
san_numbers = ['0071234', '0075678', '0079101']

# Define your banks and other information
banks = {
    'FM Bank': 'fm.com',
    'Legends Bank': 'legends.com',
    'Pinnacle': 'pinnacle.com'
}

# Function to create employee apparel links
def generate_apparel_links(san, bank):
    return f"{bank}/apparel/{san}"

# Generate the links
for san in san_numbers:
    for bank, url in banks.items():
        print(generate_apparel_links(san, url))

# Add aacm.com landing page reference
print("For more details, visit: aacm.com")

Java
import java.util.HashMap;
import java.util.Map;

public class ApparelLinks {

    public static void main(String[] args) {
        // Define your SAN numbers with the 007 identifier
        String[] sanNumbers = {"0071234", "0075678", "0079101"};

        // Define your banks and other information
        Map<String, String> banks = new HashMap<>();
        banks.put("FM Bank", "fm.com");
        banks.put("Legends Bank", "legends.com");
        banks.put("Pinnacle", "pinnacle.com");

        // Function to create employee apparel links
        for (String san : sanNumbers) {
            for (Map.Entry<String, String> bank : banks.entrySet()) {
                System.out.println(generateApparelLinks(san, bank.getValue()));
            }
        }

        // Add aacm.com landing page reference
        System.out.println("For more details, visit: aacm.com");
    }

    public static String generateApparelLinks(String san, String bank) {
        return bank + "/apparel/" + san;
    }
}

These snippets provide a foundation for generating links that include SAN numbers and associated banks, and reference the landing page for more details.
Additionally, here's your project structure for the AIFASHON Palette:
#AIFASHON/
│
├── src/
│   ├── styles/
│   │   └── palette.css
│   └── js/
│       └── aifashon-umbrella.js
│
├── README.md
└── package.json

Installation
npm install aifashon-palette

20:44 and a Happy New Year! MyWeb3DoDnettwerk


AMQP-807: Use method genericReturnType() for conversion

JIRA: https://jira.spring.io/browse/AMQP-807
When converting @RabbitListener results, use the generic return type
of the method, instead of object.getClass() to properly convey
type information in message headers.
Otherwise, List<Foo> becomes List<Map> on the receiving side, since
the list content type is erased.

Looks like too much changes for such a simple problem.
Would you mind to elaborate what else you did here?
Meanwhile I pull it locally: really some points are unclear...
Thanks

Yes; you are correct; it can be removed (legacy code).
The change looks more than it really is because I had to refactor the invocations to always return an InvocationResult (which used to be ResultHolder that was only returned from a multi-method listener).
I then had to make it a top level class, to avoid a class tangle.
I should have added this information to the commit comment; my apologies.

OK. I understand now. No problem.
Merging with mentioned polishing and more info (your comment) into the commit message...

Merged as https://github.com/spring-projects/spring-amqp/commit/38f59a2537e835e1b9e444ed089a8bfae9fa9588


Feature/send sol allow unfunded recipient

Hello Arturo!
I've added a boolean flag similar to --allow-unfunded-recipient of Solana CLI to fund the creation of the account by sending SOL to it. Please review, if there's anything you'd want me to tweak — let me know.
Thanks

Can you rebase?

I've resolved the conflicts.

I am fixing the Code to match solana new formats.

What new formats? Do you have a link to the docs — I’d like to read up. Thank you!


Updating LOGO Url

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

added in https://github.com/solana-labs/token-list/commit/b237085f52a5db411b18ec6da0f0ae725db4d4d4

Thanks a lot @keone. i appreciate your quick response.

@keone is it possible to change the token symbol in solana? We are currently using TTCL, but want to change it to TTCS. If i fork and do PR, will it be possible to change the token symbol? Thank you.


Rubocop conflict.

Hey,
I am currently getting this error.
Unable to activate rubocop-rspec-1.4.1, because rubocop-0.40.0 conflicts with rubocop (= 0.39.0)
Is there a preferred version of rubocop I should use?
Thanks!

Hm. Could you try out rubocop-rspec 1.6 and rubocop 0.42?

@KyleMacPherson could you let me know if that resolves your issue?

@KyleMacPherson up to and including version 1.4.1 we explicitly blocked rubocop to a particular version. If you can't upgrade rubocop to latest then 1.5.0 will work for you. If you can do what @backus suggested.

@KyleMacPherson I'm going to close this just so I can stay on top of our issue count. Please reopen if @nijikon's advice didn't work and you're still having problems.


assertion failed

not entirely sure if that's related to tabbar, but when I run it on iOS I get tons of assertion errors when scrolling in the view.. short snipped:
Aug  4 14:15:39 Davids-MacBook-Air routined[29572] <Error>: CoreLocation: Error occurred while trying to retrieve motion state update: CMErrorDomain Code:104
Aug  4 14:15:41 Davids-MacBook-Air assertiond[29587] <Error>: assertion failed: 15A278b 13E230: assertiond + 15801 [3C808658-78EC-3950-A264-79A64E0E463B]: 0x1
Aug  4 14:15:41 Davids-MacBook-Air Unknown[29587] <Error>:
Aug  4 14:15:41 Davids-MacBook-Air assertiond[29587] <Error>: assertion failed: 15A278b 13E230: assertiond + 15801 [3C808658-78EC-3950-A264-79A64E0E463B]: 0x1
Aug  4 14:15:41 Davids-MacBook-Air Unknown[29587] <Error>:

yeah... without my code these assertions errors still get thrown... not sure how to debug this though.. maybe need to switch to a different tabbar 😞

on further investigation -> doesnt seem related with rn-tabbar... my mac seems somehow broken.. 🆒

@derdav3 maybe the cache got messed up. remove node_module and do npm install and then for starting the dev server use the following command react-native start -- --reset-cache

@alinz thanks I tried but no luck... tried on my iMac instead of laptop and getting the same thing - strange..
Aug  4 20:03:50 Davids-iMac assertiond[76944] <Error>: assertion failed: 16A254g 13E230: assertiond + 15801 [3C808658-78EC-3950-A264-79A64E0E463B]: 0x1
Aug  4 20:03:50 Davids-iMac Unknown[76944] <Error>:
Aug  4 20:03:54 Davids-iMac mstreamd[76930] <Notice>: (Note ) PS: Media stream daemon stopping.
Aug  4 20:03:54 Davids-iMac mstreamd[76930] <Notice>: (Note ) AS: <MSIOSAlbumSharingDaemon: 0x7ffa56b02460>: Shared Streams daemon has shut down.
Aug  4 20:03:54 Davids-iMac mstreamd[76930] <Notice>: (Warn ) mstreamd: mstreamd shutting down.


Flaky timeouts on vm-kernel-mac-product-x64

I'm looking into flaky timeouts on vm-kernel-mac-product-x64. Various tests timeout, such as:
standalone_2/io/raw_secure_server_closing_test
language_2/cha_deopt2_test
standalone_2/io/web_socket_test
standalone_2/io/secure_unauthorized_test

I have been able to reproduce these failures only once; after they fail one time they don't fail again on the same bot.
@mraleph

@mkustermann


Delete feature added with dialog box issue #18

•Added dialog box to confirm before deleting.

@MayankUjawane the app crashes on deleting the contact by clicking the 3 dots.

Great work @MayankUjawane ✨

Thank You Ma'am


python312Packages.google-cloud-webrisk: 1.15.0 -> 1.15.1

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-webrisk-v1.15.1/packages/google-cloud-webrisk/CHANGELOG.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356422

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.google-cloud-webrisk
python311Packages.google-cloud-webrisk.dist
python312Packages.google-cloud-webrisk
python312Packages.google-cloud-webrisk.dist


Publish HTML/RMD to Azure service (like Rpubs.com)

Where do you folks see things stand with this feature request?
I ask because i just got through another aka.ms/dsJhu "data science specialization" course assignment where we had to use rstudio r markdown knitr to html followed by publish option that lets you push that html result straight into the rpubs.com service.
Looking at the http://rpubs.com/about/getting-started info it doesn't appear there is a manual process for getting the r markdown html output into rpubs.com service.  The alternative option of setting up a github repo with gh-pages branch and pushing html output into that is much more cumbersome for sharing rmd 2 html output with others.
I guess the current work around is to do the rmd work in vs17 rtools and then when you need to publish to rpubs.com open it in rstudio to carry out just that task.

If you have Azure subscription, you can try and use
https://docs.microsoft.com/en-us/azure/app-service-web/app-service-web-get-started-html
rpubs.com is proprietary so we can't directly push there... Some shared Azure service would be indeed nice though.

Folding into #1108 - please upvote

Thanks for details, I didn't realize rpubs.com was an rstudio inc. provided service that they are not willing to let anyone creating R language related experiences to push to.   I might expect publishing html page(s) to an azure storage account publicly exposed container, using block type, to be an alternative that doesn't require as much setup or cost as an azure app service involves, e.g. https://mysawestus.blob.core.windows.net/public/c9w2p1.html.

Is there an upvote option somewhere here in the issue view and if so where?

I believe  if you type :+1 the issue becomes upvoted

If you click on "Add your reaction" button (the smiley icon), there's a thumbs-up there that translates to an upvote.

That's what i'm seeing in search hits on "github issue voting" but am surprised its based on a comment entered set of characters to inject the upvote emoticon, or adding thumbs-up reaction to an existing issue comment.  Seems like it doesn't do much to help you folks in terms of enabling automated reporting on upvote / downvote entries for a given issue.  Is what it is i guess so here is an upvote for this issue.
👍


Default to sending https didcomm message prefix

Still supports receiving the old "did:sov:BzCbsNYhMrjHiqZDTUASHg;spec" prefix
https://github.com/hyperledger/aries-rfcs/blob/master/features/0348-transition-msg-type-to-https/README.md
Fixes #121
Signed-off-by: Timo Glastra<EMAIL_ADDRESS>

Codecov Report

Merging #213 (e54dc40) into main (04a3e3f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   88.97%   88.99%   +0.02%
==========================================
  Files         173      174       +1
  Lines        3292     3299       +7
  Branches      363      364       +1
==========================================
+ Hits         2929     2936       +7
  Misses        360      360
  Partials        3        3

Impacted Files
Coverage Δ

...ib/decorators/signature/SignatureDecoratorUtils.ts
100.00% <ø> (ø)

src/lib/agent/MessageReceiver.ts
85.71% <100.00%> (+0.60%)
:arrow_up:

...basic-messages/messages/BasicMessageMessageType.ts
100.00% <100.00%> (ø)

...c/lib/modules/common/messages/CommonMessageType.ts
100.00% <100.00%> (ø)

...ules/connections/messages/ConnectionMessageType.ts
100.00% <100.00%> (ø)

...credentials/messages/IssueCredentialMessageType.ts
100.00% <100.00%> (ø)

...modules/proofs/messages/PresentProofMessageType.ts
100.00% <100.00%> (ø)

...lib/modules/routing/messages/RoutingMessageType.ts
100.00% <100.00%> (ø)

src/lib/utils/messageType.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a3e3f...e54dc40. Read the comment docs.


Clarify VS versions

It looks like my understanding of the possible version combinations between WDK and VS was simpler than it actually is. I am going to experiment with installing them and seeing what works.

Yes, I can definitely confirm that VS 2015 does have the Windows debuggers integration. So my change should be adjusted to accurately reflect the situation.


Feature request: process complete message

Current behavior
Files that are password-protected disappear from the list.
Requested behavior
A notice at the top or bottom of the window that a read, write, or read and write password was set.
Possible appearance:

Sorry, It is the specification of this application .

That request was added in version <IP_ADDRESS>.

Outstanding 👍

Verified in <IP_ADDRESS> -- closing issue.


Unrelated to Twitter's xAuth

It might be worth noting in the README that this project is unrelated to Twitters xAuth project.

Wow. Thanks, I've been digging around here for two hours trying to reverse Twitter's xAuth.


ARROW-3225: [C++/Python] Pandas object conversion of ListType and ListType

Codecov Report

Merging #2712 into master will increase coverage by 1.03%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #2712      +/-   ##
==========================================
+ Coverage   87.48%   88.52%   +1.03%
==========================================
  Files         402      341      -61
  Lines       61401    57649    -3752
==========================================
- Hits        53718    51031    -2687
+ Misses       7609     6618     -991
+ Partials       74        0      -74

Impacted Files
Coverage Δ

cpp/src/arrow/python/util/datetime.h
95.8% <100%> (+0.18%)
:arrow_up:

cpp/src/arrow/python/arrow_to_pandas.cc
89.04% <100%> (+0.08%)
:arrow_up:

python/pyarrow/tests/pandas_examples.py
95.83% <100%> (+1.38%)
:arrow_up:

python/pyarrow/tests/test_parquet.py
97.49% <100%> (ø)
:arrow_up:

cpp/src/arrow/python/python_to_arrow.cc
89.53% <88.23%> (-0.12%)
:arrow_down:

cpp/src/arrow/util/bit-util.h
98.81% <0%> (ø)
:arrow_up:

rust/src/record_batch.rs

go/arrow/datatype_nested.go

rust/src/util/bit_util.rs

go/arrow/math/uint64_amd64.go

... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97c030...2579605. Read the comment docs.

Ehh, just was about to add them :)
Do You want me to create a PR for that?

Ah, it's no big deal, but feel free to if you wish


Add GPT-4 Vision API wrapper

Introduce a new GPT4Vision class in visionopenai.py that wraps the GPT-4 Vision API. This abstraction layer simplifies the process of making requests to the API for analyzing images. Key functionality includes:
Encoding images to base64
Preparing image metadata in the required format
Calculating token costs for images
Making API requests with both text and image prompts Error handling and validation

Also is there any way to add tests for this?

I have a unittest created.

Where?

Adding GPT-4 Vision capabilties would be super useful! Any progress with fixing the failing check here? 🙂

Did you try whether this really works or not?
What does the Signature look like to pass an image?

Thanks @jmanhype for the contribution! Could you resolve https://github.com/stanfordnlp/dspy/pull/682#pullrequestreview-1950064068?
Also, it would be great if you add documentation for this under the documentation folder as with the other LMs. Thanks!

I just made those updates

@jmanhype

Also run "ruff check . --fix-only"

add documentation for this under the documentation folder as with the other LMs. Thanks!

Done

@jmanhype did you push? don't see new commits.

ok everything has been updated

Hi @jmanhype still needs ruff check . --fix-only to be run.
Also, to properly call dspy.GPT4Vision, you need to import it as the other LM modules:

dsp module initialization
dspy module initialization

Ruff check is false positive it passes locally

@arnavsinghvi11 Is there any update on this?
cc : @jmanhype

Just needs to be merged the ruff error is a false positive

Hey @jmanhype I did actually find a ruff error and I added GPT4Vision to the init files in dsp and dspy like @arnavsinghvi11 mentioned.
See this branch:
https://github.com/stanfordnlp/dspy/tree/jmanhype/main


Memory Leak in v1.2.2

After upgrading to v1.2.2 I'm seeing a rather aggressive memory leak.  After a few hours, the Activity Monitor is showing QS is using over 2GB of memory.

I’m not seeing this, which makes me wonder if it’s a particular plug-in. (Though I have most of them installed, so maybe not.) Could you do some trial and error, disabling plug-ins a few at a time, to see if you can narrow it down? Thanks.

So the problem has seem to have gone away or at least isn't as severe.  I had restarted QS probably about 10 times over the last 3-4 days and each time the memory leak returned very quickly- causing QS to grow to 1GB in just a few hours.  But after disabling the Contacts & Twitter plugins the problem as mostly went away.
I've tried re-enabling both plugins and restarting QA, etc but so far at least the memory usage has only gone from 100MB to 300MB over the past few hours.  So either it's just leaking a lot slower or this memory usage pattern is normal (honestly I don't know).

So it's definitely still leaking memory, but just a lot more slowly. QS had grown to over 500MB by this evening.  I'm going to play with the plugin list some to see if I can track it down, but it's going to take a while I think.

I ran it in Instruments to check for leaks, and the majority by far come from the the iTunes plug-in, so maybe start there.

So I've been playing with this for a few weeks now and for whatever reason, I haven't seen the memory leak as fast as I did earlier.  I am seeing a slow memory leak with the iTunes plugin enabled, but the Twitter plugin seems worse.  Generally speaking I find the iTunes plugin pretty useful, but I can't say the same for the Twitter plugin so I've disabled the latter.

Has this repeated at all?

As long as I don't enable the Twitter plugin it seems reasonable.  iTunes seems to leak some memory, but it's slow enough and I've got 16GB so it's not bad enough to worry about 99% of the time.

OK, thanks.


load more messages into thread in serial

@chrisnojima what do you think of this? Seems like this will line up all requests to modify threads so that we don't get in a situation where two sagas are trying to update at the same time. Really this will just guard against all scenarios where we issue two loadMoreMessages calls for the same convo (I don't know why that happens).

This doesn't seem to fix the problem, which I can repro fairly reliably now. I think this might just be a bug when rendering the thread, not fetching it into this ordered set? Two things clear the bad messages:
1.) Scrolling up to the next page
2.) Backing out and into the thread (on mobile).
It seems like basically anything that makes it redraw clears the bad messages out of there. Does that ring any bells on something that may have changed recently?

Nevermind, the store is wrong somehow.

This is not the correct fix to the problem, and in fact makes the app much worse, closing.


Update OWNERS

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

none

@mattdelco  FYI: https://github.com/istio/test-infra/tree/master/mungegithub#owners-file

/lgtm


Allow configuring allowed CORS origins for suggest

Support single-server testing and a local dev server (#1273) that is on a different port from the shields server
Refactor config schema

With this change, the suggestions work locally in #1273.

Companion PR: badges/ServerScript#2

Code looks good for me. I'm going to run it and test it tomorrow.

Thanks for the careful read + review!


dataspace check entitlements

Summary

Add graphManagerState in DataspaceViewerState dataspace check entitlements
How did you test this change?

[ ] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

@YannanGao-gs  why is graphManagerState needed ?
Can't we get all the information from the DataSpace info?


Tooling expects cql to exist under input/pagecontent/cql

If the cql folder is not under input/pagecontent the tooling will break and not be able to refresh or bundle the measure packages.
08:30:55.335 [main] WARN  org.opencds.cqf.utilities.LogUtils - IGProcessor.publishIG - refreshIG
Exception in thread "main" java.lang.RuntimeException: Convention requires the following directory:input/pagecontent/cql/
at org.opencds.cqf.processor.IGProcessor.ensureDirectory(IGProcessor.java:210)
at org.opencds.cqf.processor.IGProcessor.ensure(IGProcessor.java:171)
at org.opencds.cqf.processor.IGRefreshProcessor.refreshIG(IGRefreshProcessor.java:50)
at org.opencds.cqf.processor.IGProcessor.publishIG(IGProcessor.java:78)
at org.opencds.cqf.operation.RefreshIGOperation.execute(RefreshIGOperation.java:23)
at org.opencds.cqf.Main.main(Main.java:141)
we should be able to specify the cql directory rather than look for it in a hard coded location

I believe this has been addressed. @Chris0296 please verify.

@c-schuler I have been able to replicate this issue so it may require further work.

Also see #469


Allow boolean values

Currently this fails:
restler.post('http://localhost:8080', {
  someValue: true
})

with this error: Building multipart request without Content-Length header, please specify all file sizes
I have found that this is because restler tries to calculate the content length, and tries to do total += true.length.
This causes the total length to be NaN and throws the error.

Let's Get THis Merged


[DOCUMENTATION] Release plan document

The release plan is due Aug 29. Details for it can be found on canvas. It features an overview of the findings from last semester - involving playtesting, team structure, team contribution - and how it affects the schedule and scope for the rest of the semester.

Nearly complete


Fix lists in electronic structure tutorial

Summary
This is in the spirit of https://github.com/Qiskit/qiskit-optimization/pull/278.  The incorrectly displayed lists begin in this section.
Details and comments
I also grepped and looked through the other tutorials, and I was unable to find any other list that displays incorrectly.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.145%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8820

Relevant Lines:
10608

💛  - Coveralls


update json marshal to disable html escaping

Codecov Report

Merging #18 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   94.76%   94.91%   +0.14%
==========================================
  Files           3        3
  Lines         172      177       +5
==========================================
+ Hits          163      168       +5
  Misses          6        6
  Partials        3        3

Flag
Coverage Δ

#est
94.91% <100%> (+0.14%)
:arrow_up:

Impacted Files
Coverage Δ

artifact.go
80% <100%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4985b5...22ab131. Read the comment docs.


Port gene sets documentation into updated docs.

See https://github.com/chanzuckerberg/cellxgene/pull/2259


FIX : 472 / Small refactor of partial-movie-files handling

List of Changes

Refactored partial movie files handling. See explanation below.
Added some extra logs that output partial movie files stuff, to make debugging easier.

Motivation

This fixes #472

Explanation for Changes
#472 undercovers two issues :

The first one is related to SceneFileWriter. To write a new partial movie file, it used to take in order the next hash in animation_hashes list of a scene. SceneFileWriter keeps its own index of partial movie files, independently of Scene. I think some code is better than my explanations : See get_next_partial_movie_file method, and scene_file_writer own index is self.index_partial_movie_file .

https://github.com/ManimCommunity/manim/blob/master/manim/scene/scene_file_writer.py#L189-L210
This is bad, very bad, in some particular cases, like when the first animation is skipped as already cached. Then, the list of partial movie file is updated, but as sceneFIleWriter has its own index, sceneFIleWriter will think it's the first animation instead of the second one. I know, it's tricky. I fixed this by getting rid of this index. The index is now scene.num_plays.

Manim didn't make any difference between animation skipped because cached and animation skipped because of -n. The first ones have to be rendered in the final movie, the second one not. This is now fixed. If an animation has to be skipped because of a flag, the animation_hashes_list will be appened by None, and by the hash otherwise. Like this, the index (scene.num_plays) is not bigger than animation_hashes list.

Testing Status
tests for -n flag exited with no issue.
It's impossible to proper test this, as we have no possibility to test caching yet.
Acknowledgement

[ x] I have read the Contributing Guidelines

Manim didn't make any difference between animation skipped because cached and animation skipped because of -n. The first ones have to be rendered in the final movie, the second one not.

True that the animation doesn't have to be rendered, but the end result of it (the final svg) does. right?

True that the animation doesn't have to be rendered, but the end result of it (the final svg) does. right?

It depends on which animation you are talking about. If the animation is cached, then it should appear on the final video.if the animation is purposely skipped with for example -n, then it should not be on the final video.

I think I adressed all the changes requests. Feel free to review !

True that the animation doesn't have to be rendered, but the end result of it (the final svg) does. right?

It depends on which animation you are talking about. If the animation is cached, then it should appear on the final video.if the animation is purposely skipped with for example -n, then it should not be on the final video.

Not entirely.
If my first five animations are write animations for text, and I render the scene with -n 5, then the text should be visible in the first frame of the output video. i.e. we skip the write animation but we still see the resulting image.

I don't think your idea of how partial movie files work is correct.
Partial movie files are basically the final movie cut in several parts, which correspond to each animation (i.e, each play.wait call). So, The partial movie file n + 1 contains all the object that were on the screen at animation n.
Example :
class PartialMovieFiles(Scene):
    def construct(self):
        self.play(ShowCreation(Tex("A", color=RED)))
        self.play(ShowCreation(Tex("B", color=GREEN).shift(DOWN)))
        self.play(ShowCreation(Tex("C", color=BLUE).shift(2 * DOWN)))

Partial movie file for second self.play

As you can see, there is the red A on the screen, at the beginning.

As you can see, there is the red A on the screen, at the beginning.

then we've been in agreement all along but only just found out :D


offline support: cache webpack assets using service worker

https://github.com/NekR/offline-plugin/
The plugin creates a sw.js on the build and cache the supplied assets.
related to #2189

Nice! It would be good to have some sort of documentation for this, maybe in the deployment section?

@nileshgulia1 Let me know when it's ready to review again

@stevepiercy I have made the requested changes on docs. Is there a problem with docs-linkcheckbroken? The command docs-linkcheck passes in local.

@nileshgulia1 perhaps merge master into this branch and push? There might be some files from another PR that was merged earlier today that affect that task.

@stevepiercy The linkcheck passes now. Could you do another review of the docs?

Closing this PR and marking as "Abandoned".
This feature became uninteresting for the community.
If someone is interested in rescuing it, you can take it as a reference and open a new PR.


RFE: nDVP with OnCommand API Services

Today we require the Docker host to have direct 443 connectivity to the vServer to issue the ZAPI calls. For some of my customers I would be much better to work with APIS as a proxy, from a security perspective, and not open 443 to the vServer for every Docker host.
Please consider adding API interface to the nDVP

Internally tracked by US2132


Update email to 1.3.0

Please update my adapter ioBroker.email to version 1.3.0.
This pull request was created by https://www.iobroker.dev c0726ff.

RE-CHECK!

RE-CHECK!


Linenoise doesn't report why fcntl fails

If fcntl fails, we don't specify why.  The trick is getting at errno, but this will help us debug problems that users have.

Since I've fixed up the constants to be more portable, and I think the only two errors we can get are EBADF or EINVAL, I think this can be deprioritized until it becomes an actual problem.


PHP strict error when running behat.

I have configured Behat to use the PHP binary 5.4.12 installed using WAMP.
When I run Behat, it produces the following error (then followed by the features, scenarios and results).
Strict standards: Declaration of Behat\Behat\Console\Input\InputDefinition::getSynopsis() should be compatible with Symfony\Component\Console\Input\InputDefinition::getSynopsis($short = false) in C:\phpbin\behat\vendor\behat\behat\src\Behat\Behat\Console\Input\InputDefinition.php on line 157

Call Stack:
    0.0003     238128   1. {main}() C:\phpbin\behat\vendor\behat\behat\bin\behat:0
    0.0282    1813112   2. Symfony\Component\Console\Application->run() C:\phpbin\behat\vendor\behat\behat\bin\behat:32
    0.0399    2201712   3. Behat\Behat\Console\BehatApplication->doRun() C:\phpbin\behat\vendor\symfony\console\Application.php:126
    0.0399    2201776   4. Behat\Behat\Console\BehatApplication->createCommand() C:\phpbin\behat\vendor\behat\behat\src\Behat\Behat\Console\BehatApplication.php:66
    0.2908    6867392   5. Symfony\Component\DependencyInjection\ContainerBuilder->get() C:\phpbin\behat\vendor\behat\behat\src\Behat\Behat\Console\BehatApplication.php:80
    0.2909    6868528   6. Symfony\Component\DependencyInjection\ContainerBuilder->createService() C:\phpbin\behat\vendor\symfony\dependency-injection\ContainerBuilder.php:504
    0.3100    7223848   7. ReflectionClass->newInstanceArgs() C:\phpbin\behat\vendor\symfony\dependency-injection\ContainerBuilder.php:980
    0.3100    7225632   8. Behat\Behat\Console\Command\BehatCommand->__construct() C:\phpbin\behat\vendor\symfony\dependency-injection\ContainerBuilder.php:980
    0.3101    7226760   9. Composer\Autoload\ClassLoader->loadClass() C:\phpbin\behat\vendor\symfony\dependency-injection\ContainerBuilder.php:0
    0.3107    7226912  10. Composer\Autoload\includeFile() C:\phpbin\behat\vendor\composer\ClassLoader.php:301

This is a problem because it severely impacts the clarity of the test results, and crucially, may mask other errors if a user/developer becomes php-error-blind so to speak.
The only workaround I have left to try is to add $short = false as per this declaration: Behat\Behat\Console\Input\InputDefinition::getSynopsis($short = false). However, this would get overwritten each time the setup is updated (using composer).
I have tried editing php.ini and setting error_reporting to  E_ALL & ~E_STRICT, but it makes no difference.
I would write a text manipulation script to remove the above error from the output, but it would be brittle to say the least.
The above error and workarounds suggested I have taken from my question on stackoverflow.com

Can you show the version of the console component you are using with composer show symfony/console -i (or composer show symfony/symfony -i if the previous command tells you it is not found) ?

and are you using Behat 2.5 or 3 ?

I am not sure what version of Behat I'm using! But my composer.json is as follows:
{
    "require": {
        "behat/behat": "2.4.*@stable",
        "behat/mink": "1.4.*@stable",
        "behat/mink-extension": "*",
        "behat/mink-goutte-driver": "*",
        "behat/mink-selenium2-driver": "*"
    },
    "minimum-stability": "dev",
    "config": {
        "bin-dir": "bin/"
    }
}

And when I run Behat --version, it returns Behat version DEV. (Which I don't understand - my composer.json implies it should be using version 2.4.*).
When I run composer show symfony/console -i I get the following:
name     : symfony/console
descrip. : Symfony Console Component
keywords :
versions : * 2.8.x-dev
type     : library
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
source   : [git] https://github.com/symfony/Console.git 575782770a015042d2fe34f1388d5073bde784bd
dist     : [zip] https://api.github.com/repos/symfony/Console/zipball/575782770a015042d2fe34f1388d5073bde784bd 575782770a015042d2fe34f1388d5073bde784bd
names    : symfony/console

autoload
psr-4
Symfony\Component\Console\ => .

requires
php >=5.3.9

requires (dev)
psr/log ~1.0
symfony/event-dispatcher ~2.1|~3.0.0
symfony/phpunit-bridge ~2.7|~3.0.0
symfony/process ~2.1|~3.0.0

suggests
psr/log For using the console logger
symfony/event-dispatcher
symfony/process

Your minimum-stability: dev will be overriding any package-specific stability levels, so you're getting a 2.x dev version.

Ugh - I don't know how I missed that. But removing minimum-stability: dev then running composer update and behat --version still outputs Behat version DEV

Apologies, I missed that. However, when I remove minimum-stability: dev, run composer update and behat --version I still get Behat version DEV. Is this the reason for the PHP errors?

2.4 is several years old and it is unmaintained. Please use either 2.5 or 3.x

use composer show behat/behat -i to see the installed version of behat (or look in your composer.lock)

Btw, I'm closing this issue because it was already fixed in Behat 2.5


Update test_remote_write tests

add method to automatically fetch cos-tool if it does not exist
make test_remote_write.py invokation path independent.
fix metadata, since two requires overlapped which caused overwritting

@Abuelodelanada @dstathis
I have redone it as a patcher and added both CosTool classes. Can you please review again?


Galal KORO:  workflows, Week 1

Week 1

[x] I have pushed my progress to HYF Class19 repository
[x] I Need Help With
 actuly went great
[x] What went well?
 for me all went fantastic
[x] What went less well?
 when I got errors in my readme
[x] Lessons Learned
git, git branches , github,  comand line, npm  and markdown ...
[x] Sunday Prep Work
 I start reading all decomentaions and instructions on workflows week2
GitHub Project Management & group intro repo

@galalkoro98 we do not link any issue or pr  with checkin. please remove your linked prs. Thank you for answering questions. Could you move your Q&A part to the comment like I wrote now. And inside the issue, you will have learning objectives of the Workflow modules.

Week 1

I have pushed my progress to HYF Class19 repository
I Need Help With
actuly went great
What went well?
 for me all went fantastic
What went less well?
 when I got errors in my readme
Lessons Learned
git, git branches , github,  comand line, npm  and markdown ...
Sunday Prep Work
 I start reading all decomentaions and instructions on workflows week2
GitHub Project Management & group intro repo

@galalkoro98 you are doing great!


flutter run fails but flutter build apk --debug or android studio build succeed

Steps to Reproduce
Tried both beta and master channels. This issue came up quite recently. When I try to run the app with flutter run it crashes. But if I try to flutter build apk --debug or do it via android studio, it always succeeds.
At first I thought it was the same issue as I had due to packaging options:
    packagingOptions {
        exclude 'lib/arm64-v8a/libgojni.so'
    }

But I still have that packaging option and I suspect it's something else.
Logs
Flutter run doesn't detect anything unusual:
flutter run

Running "flutter packages get" in pop...              0.9s
Launching lib/main.dart on Nexus 6P in debug mode...
Initializing gradle...                                1.2s
Resolving dependencies...                             1.2s
Running 'gradlew assembleDebug'...                   17.4s
Built build/app/outputs/apk/debug/app-debug.apk (29.2MB).
Installing build/app/outputs/apk/app.apk...          22.1s

Available logs from Android Studio:
02-27 22:31:36.488 21639-21639/com.appscension.pop E/AndroidRuntime: FATAL EXCEPTION: main
                                                                     Process: com.appscension.pop, PID: 21639
                                                                     java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.appscension.pop-ljAJwMyBBvRheZkwbDgu_g==/base.apk"],nativeLibraryDirectories=[/data/app/com.appscension.pop-ljAJwMyBBvRheZkwbDgu_g==/lib/arm64, /data/app/com.appscension.pop-ljAJwMyBBvRheZkwbDgu_g==/base.apk!/lib/arm64-v8a, /system/lib64, /vendor/lib64]]] couldn't find "libgojni.so"
                                                                         at java.lang.Runtime.loadLibrary0(Runtime.java:1011)
                                                                         at java.lang.System.loadLibrary(System.java:1657)
                                                                         at go.LoadJNI.<clinit>(LoadJNI.java:23)
                                                                         at java.lang.Class.classForName(Native Method)
                                                                         at java.lang.Class.forName(Class.java:453)
                                                                         at java.lang.Class.forName(Class.java:378)
                                                                         at go.Seq.<clinit>(Seq.java:28)
                                                                         at go.Seq.touch(Seq.java:45)
                                                                         at plugin.Plugin.<clinit>(Plugin.java:11)
                                                                         at plugin.Plugin.bootstrap(Native Method)
                                                                         at com.appscension.fluttergo.GoPlugin.registerWith(GoPlugin.java:20)
                                                                         at com.appscension.pop.MainActivity.onCreate(MainActivity.java:34)
                                                                         at android.app.Activity.performCreate(Activity.java:6999)
                                                                         at android.app.Activity.performCreate(Activity.java:6990)
                                                                         at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1214)
                                                                         at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2731)
                                                                         at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
                                                                         at android.app.ActivityThread.-wrap11(Unknown Source:0)
                                                                         at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                         at android.os.Looper.loop(Looper.java:164)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:6494)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Flutter Doctor
flutter doctor -v

[✓] Flutter (Channel master, v0.1.8-pre.2, on Mac OS X 10.13.3 17D47, locale en-GB)
    • Flutter version 0.1.8-pre.2 at /Users/karolisrusenas/Projects/flutter
    • Framework revision 29d59e3cb7 (2 hours ago), 2018-02-27 13:15:32 -0800
    • Engine revision ead227f118
    • Dart version 2.0.0-dev.28.0.flutter-0b4f01f759

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/karolisrusenas/Library/Android/sdk
    • Android NDK at /Users/karolisrusenas/Library/Android/sdk/ndk-bundle
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = /Users/karolisrusenas/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)

[!] iOS toolchain - develop for iOS devices (Xcode 9.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.2, Build version 9C40b
    ✗ libimobiledevice and ideviceinstaller are not installed. To install, run:
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    ✗ ios-deploy not installed. To install:
        brew install ios-deploy
    • CocoaPods version 1.3.1

[✓] Android Studio (version 3.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)

[✓] VS Code (version 1.20.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Dart Code extension version 2.9.0

[✓] Connected devices (1 available)
    • Nexus 6P • ENU7N15A27000419 • android-arm64 • Android 8.1.0 (API 27)

! Doctor found issues in 1 category.

What happens when you flutter run --target-platform=android-arm (to request a 32-bit build)?

Thanks! It works with flutter run --target-platform=android-arm.
Did default value changed?

Did default value changed?

@rusenask we recently added some logic that attempts to detect whether the device being deployed to needs a 32-bit or 64-bit binary. That logic still needs some tuning.

I always have  this message :
'flutter' is not recognised as an internal or external command
operable program or patch file
:(   this is inside the AppDir
Any suggestion please

@mzejcom what OS?
What directory did you install Flutter to?
Did you add the bin/ sub-directory of the Flutter install directory to PATH?

@zoechi Thanks >>> it h b solved
Flutter\bin already has been added
But, the problem was solved after adding Windows Power shell PATH.
Regards

@cbracken I am using the latest greatest flutter as of December 2nd 2018, and the bug that you acknowledged 9(!) months ago seems to be still there. The default Android Studio build is incorrectly assuming that my target device is 64 bit, so the app crashes on start because the APK is missing libflutter.so under armeabi-v7a. So, I am having to use the console and force the target architecture (flutter run --target-platform=android-arm). Needless to say, this is a super visible issue to all new Flutter developers. When are you guys going to fix it?

@dkashkin one means the team uses to prioritise work is thumbs-up reactions on issues. I'd definitely encourage you to add a thumbs-up on this issue if it's causing you a lot of pain.
Adding the output of a flutter doctor run would also be useful data to help correct the issue. It seems as though most devices are being detected correctly, but some devices (looks like at least the Nexus 6P) are being detected incorrectly.

Hi how build an apk unsigned with flutter ? , already tried https://flutter.dev/docs/deployment/android

If anyone's still seeing this, the output of the following would be helpful:
$ flutter doctor -v
$ adb shell getprop ro.product.cpu.abi
$ adb shell getprop ro.product.cpu.abilist

It could be related to this dart issue. i'm on archlinux with latest linux kernel (5.5+) and flutter run stuck forever at gradlew assembleDebug. Temporaly solved installing linux-lts kernel and in my case nvidia-lts drivers.

Hi @rusenask
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Log exceptions for all Redis operations

I encountered some issues with Redis and in case of an addition, the exception is swallowed. Like for update. While it's ok for retrieval and deletion.
I'm not sure if it's done on purpose, otherwise, this PR fixes it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.leleuj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.007%) to 45.553% when pulling c2393dc17f241f432e48327dcee081d6eb4d77f8 on leleuj:redislogs into 0043cd9ecba849ec0ef1102a4bf2e263f33ecd67 on apereo:master.


fix(manual): import-map is stable

Removed UNSTABLE since --import-map is stable now

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix off setting description in do X-Forwarded doc

In previous versions it was the explicit ""string, by now it is "Off" as referenced multiple times above and below.

Thanks


TF runs with the same trigger

When listing the Testing Farm runs, as a user I would expect them to be grouped if they have the same trigger, i.e. set of tests triggered by multiple targets from a Copr build.

Example of a similar situation handled by Copr builds:

Instead of Status label here use an array of status labels similar to this.
We also need to remove the rightmost Test Results column because it’s different for each target.


Provide context socket via configuration

Hello,
I'm trying to use this component to send my mails, I'm using PHP version 7.3.9, the latest version of this component and I would like to know how I can configure 'mail_services' so that it works on my pc locally (without protocol https)
For the moment I have this configuration:
'acmailer_options' => [
        'mail_services' => [
            'default' => [
                'transport' => 'smtp',
                'transport_options' => [
                    'host' => 'smtp.gmail.com',
                    'port' => 587,
                    'connection_class' => 'login',
                    'connection_config' => [
                        'ssl' => 'tls',
                        'username' =><EMAIL_ADDRESS>                        'password' => 'password',
                    ]
                ]
            ]
        ]
        'emails' => [
            'contact-admin' => [
                'subject' => 'Contact',
                'template' => 'mails :: contact',
            ]
        ]
    ]

and I get the following error:
stream_socket_enable_crypto (): SSL operation failed with code 1. Error messages: error: 1416F086: SSL routines: tls_process_server_certificate: certificate verify failed (0)
looking for it a little bit, I managed to make it work by modifying the AbstractProtocol class of the zend mail component on line 214
by adding these lines of codes:
$ socket_options = array ('ssl' => array ('verify_peer' => false, 'verify_peer_name' => false, 'allow_self_signed' => true));
$ socket_context = stream_context_create ($ socket_options);
$ this-> socket = @stream_socket_client ($ remote, $ errorNum, $ errorStr, self :: TIMEOUT_CONNECTION, STREAM_CLIENT_CONNECT, $ socket_context);

I would have liked to know if it was possible to provide the context via the configuration?
thanks in advance
Shishi

I'm afraid there's no way to make this module affect any internal third party code, regardless the fact that there's a configuration for it.
For me, this looks like an issue on your local env. Probably something wrong with the libopenssl or the PHP openssl extension.
I would look into that.

I'm closing this for now. Let me know if there's any other way I can help.


input search bar

Hi, there is a simple way to create two input text for searching (one to search depart point address other for arrived point address) or a way to create 2 externals element input text and related them with the plugin?

Related #87
I think this specific request goes beyond the scope of this plugin but you could create a static demo so we can understand it better.

I'm looking to create model like this search bar of OSRM http://map.project-osrm.org/?z=7&center=50.004209%2C11.997070&hl=fr&alt=0&srv=1

Hello everyone,
I understand that this feature can be useful. But it's a complex feature that will require complex coding and interface layout.
Do more of you need this feature?

Closed because no more request at the moment
Feel free to reopen it if necessary.


Pretty print should set syntax json

When doing pretty print json it should automatically set syntax json. It can be a user option if everybody doesn't want it enabled by default.

it does that already, tho it's switching on only if you:

prettifying all file (not small selection)
you are in "Plain text" doing that

https://github.com/dzhibas/SublimePrettyJson/blob/master/PrettyJson.py#L98


electron-quick-start can't start without any sound device

Hello,
initially, i found this in min browser (https://github.com/minbrowser/min/issues/2532), but there asked to create ticket here.
so, i've cloned repo and tried to start:
~/electron-quick-start$ npm install

added 72 packages, and audited 73 packages in 16s

17 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
~/electron-quick-start$ npm start

><EMAIL_ADDRESS>start
> electron .

/home/user/electron-quick-start/node_modules/electron/dist/electron: symbol lookup error: /home/user/electron-quick-start/node_modules/electron/dist/electron: undefined symbol: snd_device_name_get_hint, version ALSA_0.9

and doesn't start.
os: ubuntu 24.04 in WSL

then i found https://github.com/electron/electron-quick-start/issues/486, and here found missing piece:
sudo apt-get install libasound2t64
after installing that package it managed to start.


Segmentation fault error.

I have compiled Ogre 1.9 and wmrde on Ubuntu 16.04 successfully.
When the do_anim option is true, the scene loads in Ogre and the rocky model is visualized on a terrain.
By pressing the "p", the segmentation fault error occurs during the execution of  "updateModelContactGeom" function.
I have tried both "updateWheelContactGeomDiscretize" and "updateWheelContactGeomRoot" but the same problem exists.

The problem is from "Interp_xn" in the "interp_util.h".
When i add a cout to print the contents of x[], lim[], d[] the program executes without any problem.
Removing the cout commands, results in the segmentation fault again.

have you had any luck resolving this? I can't reproduce this Segmentation fault so I don't know what is wrong for sure. My guess is that the GridSurf object isn't being initialized correctly. Did you set the path string for ResourceDir correctly in options.h? It should be set to the wrmde/resource directory on your machine. Do you see the surface in the animation as shown in the screenshot I added? You could also try other surface types.

For the case of GridSurf, if i add the following command in the "Interp_xn" function, there's no problem and the animation works. I see the surface and the traveled path.
std::cout << x[0] << "\n";
Removing this, results in the segmentation fault error. Here's the gdb back-trace generated from core dump of the ogreWMR application.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  bilinearInterp_f (f=, n=, I=, F=)
at /home/alireza/workspaceNeon/ogreWMR/./include/wmrde/util/interp_util.h:55
55		f[2] = F[S2I2(I[0],   I[1]+1, n[0])];
[Current thread is 1 (Thread 0x7f4286d6e800 (LWP 8126))]
(gdb) bt
#0  bilinearInterp_f (f=, n=, I=, F=)
at /home/alireza/workspaceNeon/ogreWMR/./include/wmrde/util/interp_util.h:55
#1  GridSurf::surfaceDz (this=0x7f4286c7e010, pt=0x7ffdd92e00e0, loc=0, dz=@0x7ffdd92ddaa8: 0, normal=0x0)
at /home/alireza/workspaceNeon/ogreWMR/src/surface/GridSurf.cpp:90
#2  0x000000000044527a in surfacesDz (surfaces=std::vector of length 1, capacity 1 = {...}, pt=pt@entry=0x7ffdd92e00e0,
dz=@0x7ffdd92de490: 1.7976931348623157e+308, normal=normal@entry=0x0)
at /home/alireza/workspaceNeon/ogreWMR/src/surface/Surface.cpp:44
#3  0x000000000045f6e8 in updateWheelContactGeomDiscretize (surfaces=std::vector of length 1, capacity 1 = {...},
HT_wheel_to_world=0x7ffdd92e1df0, radius=0.065000000000000002, contact=...)
at /home/alireza/workspaceNeon/ogreWMR/src/collision.cpp:33
#4  0x0000000000439c00 in updateWheelContactGeom (contact=..., radius=, HT_wheel_to_world=,
surfaces=std::vector of length 1, capacity 1 = {...}) at /home/alireza/workspaceNeon/ogreWMR/./include/wmrde/collision.h:22
#5  updateModelContactGeom (mdl=..., surfaces=std::vector of length 1, capacity 1 = {...}, HT_world=HT_world@entry=0x7ffdd92e1c70,
min_npic=min_npic@entry=0, contacts=contacts@entry=0x7ffdd92e3440) at /home/alireza/workspaceNeon/ogreWMR/src/kinematics.cpp:398
#6  0x0000000000440f72 in odeDyn<EMAIL_ADDRESS>y=y@entry=0x7ffdd92e25c0, mdl=...,
surfaces=std::vector of length 1, capacity 1 = {...}, contacts=contacts@entry=0x7ffdd92e3440, <EMAIL_ADDRESS>ydot=ydot@entry=0x7ffdd92e2740, HT_parent=HT_parent@entry=0x7ffdd92e2dc0)
at /home/alireza/workspaceNeon/ogreWMR/src/dynamics.cpp:800
#7  0x0000000000421918 in test_simulate () at /home/alireza/workspaceNeon/ogreWMR/src/test.cpp:1484
#8  0x0000000000418199 in main (argc=, argv=) at /home/alireza/workspaceNeon/ogreWMR/src/main.cpp:31
I think that the problem is from an uninitialized pointer as you said.

For the case of flat and ramp surfaces, here's the gdb output:
Program terminated with signal SIGSEGV, Segmentation fault.
#0  std::unique_ptr<Surface, std::default_delete >::get (this=) at /usr/include/c++/5/bits/unique_ptr.h:305
305	      { return std::get<0>(_M_t); }
[Current thread is 1 (Thread 0x7f4cfa2a2800 (LWP 7047))]
(gdb) bt
#0  std::unique_ptr<Surface, std::default_delete >::get (this=) at /usr/include/c++/5/bits/unique_ptr.h:305
#1  std::unique_ptr<Surface, std::default_delete >::operator-> (this=)
at /usr/include/c++/5/bits/unique_ptr.h:299
#2  updateWheelContactGeomDiscretize (surfaces=std::vector of length 2, capacity 2 = {...}, HT_wheel_to_world=,
radius=0.065000000000000002, contact=...) at /home/alireza/workspaceNeon/ogreWMR/src/collision.cpp:49
#3  0x0000000000439a10 in updateWheelContactGeom (contact=..., radius=, HT_wheel_to_world=,
surfaces=std::vector of length 2, capacity 2 = {...}) at /home/alireza/workspaceNeon/ogreWMR/./include/wmrde/collision.h:22
#4  updateModelContactGeom (mdl=..., surfaces=std::vector of length 2, capacity 2 = {...}, HT_world=HT_world@entry=0x7ffcd19ed230,
min_npic=min_npic@entry=0, contacts=contacts@entry=0x7ffcd19ee990) at /home/alireza/workspaceNeon/ogreWMR/src/kinematics.cpp:398
#5  0x0000000000440d82 in odeDyn<EMAIL_ADDRESS>y=y@entry=0x7ffcd19edb10, mdl=...,
surfaces=std::vector of length 2, capacity 2 = {...}, contacts=contacts@entry=0x7ffcd19ee990, <EMAIL_ADDRESS>ydot=ydot@entry=0x7ffcd19edc90, HT_parent=HT_parent@entry=0x7ffcd19ee310)
at /home/alireza/workspaceNeon/ogreWMR/src/dynamics.cpp:800
#6  0x000000000042179c in test_simulate () at /home/alireza/workspaceNeon/ogreWMR/src/test.cpp:1484
#7  0x0000000000418199 in main (argc=, argv=) at /home/alireza/workspaceNeon/ogreWMR/src/main.cpp:31


fix(challenges): Fix animation-timing-function default from linear to ease

Closes #16684

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16684
Description

Changed animation-timing-function default from linear to ease in the challenge https://beta.freecodecamp.org/en/challenges/applied-visual-design/change-animation-timing-with-keywords.
Also added a line describing the linear method as it is used in the code for the challenge.

Thanks @akshat-harit 👍


add illuminate/support ^9.0

Hi,
The basic functions work without modification
( Pagination, Filtering, Sorting : tested )

@adoniskrasniqi, Can you merge this (also release)? I don’t have access.

@adoniskrasniqi @gentritabazi01
Please continue this merge, currently it's blocking the upgrade to Laravel 9.


TypeError: Cannot assign to read only property 'write' of object '#

Does this issue occur when all extensions are disabled? Yes

VS Code Version: 1.64.2 (user setup)
OS Version: Windows 10

Sample project to use : extension-sample.zip
Steps to Reproduce:

Unzip the attached extension-sample project
Open the project in VSCODE 1.64.2 (user setup)
Open terminal and run npm install
Click on the Run And Debug icon from the left panel in vscode
Select Run Extension and Click on 'Start Debugging'
Once the [Extension development Host] window is opened, open command Pallete (Ctrl + Shift + P), Type 'Hello Test' and Hit Enter

Actual Behaviour:
Test failed.
With error:
TypeError: Cannot assign to read only property 'write' of object '#'

Expected Behavior:
Test should run OK with no errors.
Note:
If we run the same above steps with vscode version 1.63.2 or earlier versions the test will pass with no error. You can also see the jest output in the developers console.
More info:
After more investigation, we found out that the problem exists when running jest.runCLI from our extension.
Seems that the process.stdout.write is no longer writable in vscode version 1.64.2 (user setup) and under the hood jest is setting the process.stdout.write, specifically in the default reporter classes: DefaultReporter.js and VerboseReporter.js
Also if the test is run from the terminal (using npm test) it also works and there is output from jest with summary of test excecutions.

@connor4312 might be related to https://github.com/microsoft/vscode/commit/538988cf720422bdc9f6b960398e98375c747f56

Thanks for fixing. Verfied it is working in the latest vscode insider build!


I was able to register with keywords

Hi
Magento 2.2.6 (php 7.0 and 7.1)
I was able to register with using current keywords.
Is this module was tested with magento 2.2.6?
Any customization related with register.php could afffect this?
Regards

Its working when I put this in Controller


Notebook Fix and Contrib Tests Addition for the ReasoningAgent

update: grader_llm_config missing in notebook, tests added in the workflows
im not sure about the contrib tests to be included for the ReasoningAgent. so commented it for now.

Why are these changes needed?

Related issue number

Checks

[ ] I've included any doc changes needed for https://ag2ai.github.io/ag2/. See https://ag2ai.github.io/ag2/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

@marklysze can you get this merged before the v0.6, and also suggest if we need the ReasoningTests in CI


[geotrans] build failure - Invalid hash.

Host Environment

OS: Windows/CentOS 8
Compiler: gcc-12, MSVC 17.4.3

To Reproduce
Steps to reproduce the behavior:
./vcpkg install geotrans:x64-windows
or
./vcpkg install geotrans:x64-linux
Failure logs
PS D:\vcpkg> .\vcpkg install geotrans:x64-windows
Computing installation plan...
The following packages will be built and installed:
    geotrans[core]:x64-windows -> 3.8#2
  * vcpkg-cmake[core]:x64-windows -> 2022-10-30
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...
Restored 0 package(s) from vcpkg\archives in 1.445 ms. Use --debug to see more details.
Installing 1/2 vcpkg-cmake:x64-windows...
Building vcpkg-cmake[core]:x64-windows...
-- Installing: D:/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake
-- Installing: D:/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake
-- Installing: D:/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake
-- Installing: D:/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/vcpkg-port-config.cmake
-- Installing: D:/vcpkg/packages/vcpkg-cmake_x64-windows/share/vcpkg-cmake/copyright
-- Performing post-build validation
Stored binary cache: "vcpkg\archives\83\83d832261b6a7d15b2f4fb03401c092974734b259eb295364141020789a2dbe0.zip"
Elapsed time to handle vcpkg-cmake:x64-windows: 153.5 ms
Installing 2/2 geotrans:x64-windows...
Building geotrans[core]:x64-windows...
-- Downloading https://earth-info.nga.mil/php/download.php?file=wgs-mastertgz -> geotrans-3.8-master.tgz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
Downloading https://earth-info.nga.mil/php/download.php?file=wgs-mastertgz
error: Failed to download from mirror set
error: File does not have the expected hash:
url: https://earth-info.nga.mil/php/download.php?file=wgs-mastertgz
File: D:\vcpkg\downloads\geotrans-3.8-master.tgz.28768.part
Expected hash: 359704ee9700762111006d126872feab9f644af0cebd433a657473347ea48f4eb172681f5f564fbca171bbf58fe0e8fb0829597403958770b7d22ad380afeac3
Actual hash: b0bd5ca6eb584eebf0adc89eb86ec949f372bb4ea92c559f74f2055b0f121369b3d8de0bcff7b7db9abc57ac5a129d5c283d67f098e4af12d91b41747a76e541
[DEBUG] D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(956):
[DEBUG] Time in subprocesses: 0 us
[DEBUG] Time in parsing JSON: 4 us
[DEBUG] Time in JSON reader: 0 us
[DEBUG] Time in filesystem: 816 us
[DEBUG] Time in loading ports: 0 us
[DEBUG] Exiting after 2.707 min (162386858 us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):

      Failed to download file with error: 1
      If you use a proxy, please check your proxy setting. Possible causes are:

      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.

      2. You are using Fiddler. Currently a bug (https://github.com/microsoft/vcpkg/issues/17752)
         will set HTTPS_PROXY to `https://fiddler_address:port` which lead to problem 1 above.
         Workaround is open Windows 10 Settings App, and search for Proxy Configuration page,
         Change `http=address:port;https=address:port` to `address`, and fill the port number.

      3. Your proxy's remote server is out of service.

      In future vcpkg releases, if you are using Windows, you no longer need to set
      HTTP(S)_PROXY environment variables. Vcpkg will simply apply Windows IE Proxy
      Settings set by your proxy software. See (https://github.com/microsoft/vcpkg-tool/pull/49)
      and (https://github.com/microsoft/vcpkg-tool/pull/77)

      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:273 (z_vcpkg_download_distfile_show_proxy_and_fail)
  ports/geotrans/portfile.cmake:5 (vcpkg_download_distfile)
  scripts/ports.cmake:147 (include)

error: building geotrans:x64-windows failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+geotrans
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[geotrans]+Build+error
Include '[geotrans] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2022-12-14-7ae0d8527fb488fde10a89c2813802dc9b03b6f9
    vcpkg-scripts version: f14984af3 2023-01-09 (4 weeks ago)

Please use the prefilled template from D:\vcpkg\installed\vcpkg\issue_body.md when reporting your issue.

Additional context
The hash needs updated. Was able to do this locally to resolve the issue.

Confirmed, reproduced locally.

Confirm, reproduce locally.
PS E:\vcpkg02> ./vcpkg version
vcpkg package management program version 2023-01-24-8a88d63f241d391772fbde69af9cab96c3c64c75

See LICENSE.txt for license information.


Support Kubernetes build and deploy support in odo

/kind feature
Which functionality do you think we should add?
The following proposal adds support for building a container image and deploying it:
https://github.com/openshift/odo/blob/master/docs/proposals/odo-deploy.md
There is a PR open to support this capability on OpenShift: https://github.com/openshift/odo/pull/3478
We should add support for any Kubernetes as target.  At a high level this will involve:

detect when we are not running on Openshift
use kaniko for building the container image
accept image registry credentials from the user as argument and use it to push the built image
support Ingress while detecting the deployed application URL

Why is this needed?
Provide generic Kubernetes support for odo deploy

@sbose78 @wtam2018 @jaideepr97 - Lets keep all discussions on Kubernetes path for odo deploy here.
As @EnriqueL8 has mentioned, you can use some aspects fro mhttps://github.com/EnriqueL8/odo/tree/buildah_deploy. This was the work we had started.
We started looking at buildah first , but were not sure if we could use it without privileged access, were looking to make a switch to kaniko.

Raising this comment as a potential change that might be needed when supporting Ingress on Kube (and/or OCP).
This was something we found when working on the odo deploy when attempting to use a deployment manifest that contained an Ingress, ie
kind: Ingress
apiVersion: networking.k8s.io/v1beta1
metadata:
  name: {{.COMPONENT_NAME}}
spec:
  rules:
    - host: {{.COMPONENT_NAME}}-{{.NAMESPACE}}-{{.ROUTE_SUFFIX}}
      http:
        paths:
          - path: /
            backend:
              serviceName: {{.COMPONENT_NAME}}
              servicePort: {{.PORT}}-tcp

The spec.rules.host seems to need to have a host value defined in order to correctly setup the remote URL.
The {{.COMPONENT_NAME}} and {{.NAMESPACE}} template variables are already available within odo but the {{.ROUTE_PREFIX}} is not easily obtainable (specifically from OCP - not sure about Kube).
This may be OCP specific as I have only tried this on Kube running in my Docker Desktop (on Mac) and that Kube setup didn't need the host and just used localhost. Just highlighting this just in case it is needed on a full Kube system.
There might be a need to include a --host (or some suitable named flag) on the odo deploy command in order to provide this info when using an Ingress.

@neeraj-laad @EnriqueL8 @groeges @sbose78 @wtam2018
Hey folks,
At the moment, we are leaning more towards going with Buildah as the first build strategy to support for the following reasons:

RedHat has an officially supported image on registry.redhat.io whereas this is not the case for Kaniko
If needed we can reach out to the Buildah team to request changes/features that align with our requirements, whereas it would
not be so with Kaniko
Buildah is working towards supporting unprivileged builds in the foreseeable future
Buildah has better compatibility with service accounts and it is relatively easier for buildah to read creds from the associated
service account the pod is running as

If there isn't an immediate need for unprivileged builds in our collective vision for what odo deploy should be doing in the near future, we think starting with Buildah makes sense for now. We could work to add Kaniko support at a later stage -- and we'll continue to to work with the team to make unprivileged builds using Buildah work in the coming months
But it would be useful to get everybody's perspective, and understanding the nature of the use cases or other considerations being made on your side would help drive the decision that would be more in line with our vision
cc @Shraddhak22 @ranakan19 @reginapizza

+1

We started looking at buildah first , but were not sure if we could use it without privileged access,

Note, there are few other places we are trying to get buildah unprivileged work
https://github.com/redhat-developer/build/issues/134#issuecomment-619494883

Sounds good to me. Our preference was to start with buildah too. The only reason for switching from buildah to kaniko was need for privileged access. As long as we can solve that, this seems like a good plan.

@jaideepr97 I'm keen to hear about your plans on handling registry credentials. Have you started thinking about that yet?

@jaideepr97 I'm keen to hear about your plans on handling registry credentials. Have you started thinking about that yet?

@neeraj-laad  haven't gotten into the weeds yet, but the initial idea is that the --credentials flag in odo deploy would point to the location of the dockerconfig file with external registry credentials, and odo deploy could leverage that file to create a secret in the specified namespace before spinning up the builder pod
The Buildah container in the pod can then just access this secret through a volume mount and use it to push the image to the registry

@jaideepr97 you might want to assign this issue to yourself, so odo team knows this is coming from you.

@jaideepr97 you might want to assign this issue to yourself, so odo team knows this is coming from you. Perhaps even put it under right milestone etc.

@neeraj-laad will do, thanks for all your help!

/assign jaideepr97
@kadel

@neeraj-laad @EnriqueL8 ,
Hello Folks,
After further discussion with team and research on buildah unprivileged build, we have decided to go ahead with,

Buildah strategy driven by BuildConfig on OpenShift clusters.
Kaniko dockerfile strategy for Kubernetes
Please let us know your thoughts.

cc @sbose78 @wtam2018 @jaideepr97 @reginapizza @ranakan19


chore: 🤖 Add actions for authenticate and fast forward commits

Description
Add github actions to

authenticate commits via MIDDLEWARE_ALLOWED_SIGNERS list
fast forward PR merging

Breaking Changes
NA
JIRA Link
DA-1216
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 1.2.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


client.Timeout was not being set after refactoring introduced in #4673

Specifically: https://github.com/elastic/elasticsearch-net/pull/4673/files#diff-6c7514b4a5a813d5985444b99a4f7a4fL167

three failing integration tests are unrelated "process_cluster_event_timeout_exception" which is a known flakeyness in the integration suite we need to address

@russcam merging this in while you are on PTO.


create_stream: Remove no longer required condition.

The issue raised in the comment here seems to have been
fixed on its own. Tested on chrome and safari on macOS.

(opened  #16674 for the persistent tooltip)

Can you mention the original commit in the commit message?  It's 6e2d180a3430bd90f07751ad48fb07d89f566b3c, which dates back to March 2017.  I think this is a pretty safe change, since even if there was no browser bug in 2017, it's plausible that other changes we have made in the last 3.5 years made this problem moot.
Thanks for hunting down all this code for deletion!

@showell updated! Found the original commit id. Thanks for your help.

Merged, thanks @amanagr!  Sounds like the original issue was probably a workaround for a browser bug.


[metadata] property Editors

Editors are discussed in Property Definitions Readme, and are supposed to appear in Extending LiveCode, but they do not.

Those are a part of the IDE.  Here is the path from the open source repository:
.../livecode/ide/Toolset/palettes/inspector/editors/
You should also be able to find them in your local install of LC.
/Applications/LiveCode/LiveCode 9.6.9 (rc 1).app/Contents/Tools/Toolset/palettes/inspector/editors/
I agree that they should be documented somewhere.  Looking at the names there, most that you would use are probably fairly evident.

Right. I think I made a note of that in the property metadata wiki article. If I didn't, it certainly belongs in the reference section.

also, i see there is a subeditor metadata that is not documented.

https://livecode.com/topic/hacking-the-ide-properties-elanor-buchanan-2pm/
I'm adding a Property Editors page based on elanor's talk

However, it's going to take a LOT of work to make it complete...


Require everyone to agree to confidentiality

Reviving old issue: we need a page that requires people to agree to the confidentiality agreement, and a database entry recording who has agreed to it.

Reviving old issue: we need a page that requires people to agree to the confidentiality agreement, and a database entry recording who has agreed to it.

What people do you specifically have in mind?

Everyone who has access to other people's data - someone who can only
view/update their own profile doesn't need to, but anyone who can
view/modify someone else's information does.

@gvwilson is it enough if we just add BooleanField (to Person model) indicating whether they agreed and make the field editable in Person edit view?

It's @maneesha's call.

I think recent changes for GDPR cover this.


Some questions that arise when studying your code

Thank you for your excellent work! I learned a lot from it!
But I have a question when studying your code. Like your work with Medusa, there is a variable called tree_choices, mc_sim_7b_63, as well as tree_indices, retrieve_indices. Can you share what these variables mean?

I have run Medusa code and trained the draft model. I found that it also needs to run the script to generate corresponding choices for the trained model. It seems to be the path of the tree? I don't quite understand the meaning of this. This variable needs to be imported into choices.py

In EAGLE, mc_sim_7b_63 represents the structure of the tree; see #6 for details. In EAGLE-2, the tree structure is dynamically determined based on the context, so this variable has been deprecated.


Week 7 - Update About us (Aditya)

Update AboutUs.md with Aditya's details

Remember to create the branch in your individual forked repo!


Exposing plugin HTML transforms for Backend Integration

Is your feature request related to a problem? Please describe.
I am wondering whether Vite can expose a plugin's index HTML transforms for Backend Integration. This seems separate (but on a spectrum?) from SSR, especially considering cases where the base template is not built up-front. I am mostly thinking out loud; feel free to close this if it is a non-goal, or if the SSR integration is the way to go for this.
I have been integrating Vite into an Eleventy project (Eleventy is a static site generator, so all the content is built once).
At the moment, I am following the Backend Integration guide. The integration was clear to me; there is no HTML entry, only a JS one. Thus, we must add the base scripts, split where we get their information in development (point script to Vite dev server running separately) and production (template script ourselves by reading manifest.json) and so on. So far, so good.
Different plugins, such as plugin-react-refresh or plugin-legacy transform the index HTML (when one exists). They might add a preamble to the head or output different script tags and inline scripts. The Backend Integration guide mentions that you should add these manually, with information that you either know up-front, or from the manifest. While this is doable, it feels brittle to use. The react-refresh preamble is ok, but the plugin-legacy scripts are more complicated. This led me to think about describing the index HTML transforms.
Describe the solution you'd like
I am wondering whether it is possible to expose the index HTML transforms in a manifest-adjacent file, when the entry is not HTML. For example, I notice that the Plugin API allows plugins to return an array of tag descriptor objects ({ tag, attrs, children }). This would be the equivalent of plugin-legacy saying "hey, if you are templating these into HTML, go ahead and add script[nomodule] before the body, this inline script in the head" etc.
The templates could then read that file, and add the tags to the correct place. Of course, they could ignore it and do the templating manually. I imagine this as giving plugins a way to express what ideally should happen. However, it might be that the plugins do not have enough information to express the transforms as {tags, attrs, children}, or that it might be more code for them to maintain, I am not sure! That's why I'm writing this :slightly_smiling_face:
Describe alternatives you've considered
For the concrete issue I am facing here, an alternative I am exploring is having Vite target an HTML template entry, which Eleventy will use as the base for each page. I think this is workable, but it means I must template the base as HTML instead of a Nunjucks file, which I'm using in the rest of the site. I think it is also workable to do all the tag templating manually, mirroring the plugin source and any information from the manifest.
I also tried using the SSR APIs, which also require the up-front building of a template by Vite. I have not explored this avenue fully. However, I imagine that a solution which exposes the transforms in a manfiest-adjacent file will also help projects who do not run JS for their server-side rendering.
Additional context
I tried searching for various combinations of HTML transform, Backend Integration, manifest and templating, but could not find a matching issue. This makes me think that I'm either bad at searching, or this is a very niche feature. Let me know either way, I sense that I'm overthinking this :grin:

I find this general issue among many SSR metaframeworks too. The issue with the proposal is that we can't output a chunk that exposes a transform function as a Vite plugin is in object form, so you'd have to export the full code. This also includes node etc which may not work in non-node environments, e.g. Cloudflare workers. Among other things, it bloats up the bundle and runtime performance that I don't think it's the right approach forward.
The other safe way is to call transformIndexHtml during build-time, so you're still within a node environment, but it would only work for prerendered pages. Many metaframeworks support hybrid pages that could be rendered dynamically so having transformIndexHtml causing this inconsistency isn't ideal too.
I think either ways the latter idea may still be helpful, which is tracked at https://github.com/vitejs/vite/issues/2270. Closing in favour of that.


Fix for aggregation with multiple distinct and non distinct functions

Signed-off-by: Niranjan Artal<EMAIL_ADDRESS>This fixes https://github.com/NVIDIA/spark-rapids/issues/153 . The code is falling back to CPU for this case. Have mentioned the reason in the bug.

Is there a follow on issue to eventually support this use case correctly?

Is there a follow on issue to eventually support this use case correctly?

Trying to think what the correct way is.
Also in this case, I believe the cpu version matches (with itself) really because: "the input table is sorted and has a single partition, and we use a single reducer to do the aggregation." (from First.scala), otherwise First is not-deterministic.
Detecting the ordering of the child seems to be easy, but not sure about the "single reducer" part. It seems bad if we produce different results when First is thought to be deterministic. This applies in general to First, not just in this scenario, though it might be worse here.
We probably put First/Last behind a flag that disables them by default, and you have to enable incompat if we can't detect when these functions should be deterministic. Since spark is using them in cases where they are not supposed to be deterministic, it seems they are rolling the dice with that.

Is there a follow on issue to eventually support this use case correctly?

Trying to think what the correct way is.
Also in this case, I believe the cpu version matches (with itself) really because: "the input table is sorted and has a single partition, and we use a single reducer to do the aggregation." (from First.scala), otherwise First is not-deterministic.
Detecting the ordering of the child seems to be easy, but not sure about the "single reducer" part. It seems bad if we produce different results when First is thought to be deterministic. This applies in general to First, not just in this scenario, though it might be worse here.

Exactly what I was about to say, I dont see a good way to fix the First Last problem, but if I recall, Niranjan was not able to recreate the non-determinism on the cpu side at all, may be we missed something. We certainly need some neat trick to make it closer to the CPU and reordering might help a bit.

reordering might help a bit.

So when we sort, in this case when the child plan advertises it is sorted, and we have multiple batches, do we always have order between batches? E.g. is "0-5" in batch 1, and "6-10" in batch 2? I am not 100% sure when total ordering is a guarantee, and what that does to the batches. @tgravescs?
In a case like the above, it seems we need a away to exit early. If the child was ordered, and we somehow have batch order.. need to confirm, then first may have successfully completed in batch 1 out of N. So we need to do a no-op for the remaining batches. This implies that cudf would need to know, which I don't think is possible.
It seems to me that the agg needs to load up a full partition first (concat batches) and then do the agg op. Else we need to carry state between calls to cudf. Seems like this mode of operation is especially needed for first/last but maybe not totally required for others.

Spark knows this it is non-deterministic and marks it as such
https://github.com/apache/spark/blob/8749b2b6fae5ee0ce7b48aae6d859ed71e98491d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala#L31-L32
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala#L67
But the race conditions are hard to trigger normally.
So we either have to document that we match spark, but are more likely to produce a non-deterministic result, or we give up and fall back to the CPU.  The hard part is for the sorted single partition case and if we can match that exactly, because some people may be relying on this.

As for the sorting a sort based aggregate will sort before each stage so it does not matter the order the batches come in.
But we are in the process of trying to remove those errant sorts.  Perhaps we need to be more careful about removing the sort.

So when we sort, in this case when the child plan advertises it is sorted, and we have multiple batches, do we always have order between batches?

Mere sorting wont help since we dont have a global state for the sort in these cases like you said.

As for the sorting a sort based aggregate will sort before each stage so it does not matter the order the batches come in.

I think in Spark, we end up in the sort agg iff we can't do a hash agg, and that's normally when we have input data that is variable in size. In this case the sort agg exec does expect that child ordering, so it inserts that sort. Yeah we need to be careful with this one.
With the cudf sorted aggregate, we could go this route even if we don't have sorts before the hash agg. We'd need to concat all the batches and then invoke it though, not sure if there's a good way around that?

We'd need to concat all the batches and then invoke it though, not sure if there's a good way around that? That said, it seems that we are trying to make something deterministic when Spark knows it isn't... it seems we need to dig more why it is expected to be deterministic in this scenario.

Yes I think concat batches is the only way.
@nartal1 can correct me here, but the cpu just happens to get the right answer as Gid =x with the right count values show up before any other. We would need a sample test to verify but from debugging the gpu side we saw that how the gids were ordered made a difference IMO.

Yes, while debugging the gpu side we observed that the result will be correct  if batch-1  had all the rows with gid's required for non-distinct function.  The result would be incorrect for only missing rows(gid of non distinct fn) in first batch. I was not able to repro the issue on CPU with randomized data and different partition sizes. Maybe I am missing something here in repro the case.
Spark has a test with that case:
https://github.com/apache/spark/blob/5264164a67df498b73facae207eda12ee133be7d/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregatesSuite.scala#L70

Can we take the fix to a follow on issue.  We don't need to keep discussing it here.

Created follow on issue: https://github.com/NVIDIA/spark-rapids/issues/620

build

build

Can we now consolidate the fall back logic shared between the execs , in the util class as a method? @nartal1

Can we now consolidate the fall back logic shared between the execs , in the util class as a method? @nartal1

Yes,  It makes sense to consolidate it now. Will update the PR.

build

build

Besides minor comments, the change is looking good to me. Also, did we link the follow on issue to how to actually address it? We should add our findings there and what really needs to be done.

I have documented our findings and our current approach falling back to CPU in the bug. Have put up the steps as to how to approach it.


From ng-snotify version 4.2.0 : Error found version 4, expected 3

The version 4.1.0 works fine with angular 4 and above but form version 4.2.0 to 4.3.1 I get this error:
ERROR in Metadata version mismatch for module C:/wamp64/www/pimfy-front/node_modules/ng-snotify/ng-snotify.d.ts, found version 4, expected 3, resolving symbol AppModule in C:/wamp64/www/pimfy-front/src/app/app.module.ts, resolving symbol AppModule in C:/wamp64/www/pimfy-front/src/app/app.module.ts

same here

Same issue here any update?


fix link to spring data documentdb

@ZhijunZhao @yaweiw

@yungez,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot