odc.geo does not correctly calculate/load a geobox for a 1 x 1 pixel data

It appears that odc.geo does not correctly calculate a geobox for a 1 x 1 pixel data load (.odc.geobox is returned as None). If the pixel size is increased to two or more then it return the correct geometry (courtesy of @robbibt) :
assert data.odc.geobox.crs == data.geobox.crs
assert data.odc.geobox.affine == data.geobox.affine
You can replicate this bug by running this notebook:
https://bitbucket.org/geoscienceaustralia/cultivated_model/src/main/notebooks/extract_data_for_shp_custom.ipynb
The error occurs when calling collect_training_data function but it's thrown when running the following line:
https://github.com/GeoscienceAustralia/dea-notebooks/blob/c0c7e1d73576d48063ae40d345c6fb5ca7f047e8/Tools/dea_tools/spatial.py#L276

Small example here
import datacube
from shapely.geometry import Point
from datacube.utils import geometry
import odc.geo.xr

dc = datacube.Datacube()

geom_point = geometry.Geometry(geom=Point(116.604072, -31.468834), crs="EPSG:4326")
geom_buffer = geom_point.buffer(0.0001)

ds_point = dc.load(product="ga_ls5t_nbart_gm_cyear_3",
        geopolygon=geom_point,
        time="2010")

ds_buffer = dc.load(product="ga_ls5t_nbart_gm_cyear_3",
        geopolygon=geom_buffer,
        time="2010")

print("Dimensions: ", ds_point.dims, ".geobox: ", type(ds_point.geobox))
print("Dimensions: ", ds_buffer.dims, ".geobox: ", type(ds_buffer.geobox))

print("Dimensions: ", ds_point.dims, ".odc.geobox: ", type(ds_point.odc.geobox))
print("Dimensions: ", ds_buffer.dims, ".odc.geobox: ", type(ds_buffer.odc.geobox))

Dimensions:  Frozen({'time': 1, 'y': 1, 'x': 1}) .geobox:  <class 'datacube.utils.geometry._base.GeoBox'>
Dimensions:  Frozen({'time': 1, 'y': 2, 'x': 2}) .geobox:  <class 'datacube.utils.geometry._base.GeoBox'>
Dimensions:  Frozen({'time': 1, 'y': 1, 'x': 1}) .odc.geobox:  <class 'NoneType'>
Dimensions:  Frozen({'time': 1, 'y': 2, 'x': 2}) .odc.geobox:  <class 'odc.geo.geobox.GeoBox'>

Transform is computed from coordinates, but it needs at least two elements along both dimensions to compute it. The fallback is to look at the original transform used when image was first created and extract resolution part from there. I think if you were to use odc.geo.wrap_xr or odc.geo.xr_coords  to construct xarray coordinates inside datacube it would add needed attributes into xarray to be able to guess correct resolution for a 1x1 pixel array.
I believe it just adds resolution attribute to x and y coordinates

Rasters with one of the spatial dimensions being single pixel wide can only be interpreted by odc-geo is they have necessary metadata recorded, this is done by odc-geo library, but clearly not done by datacube.

Transform is computed from coordinates, but it needs at least two elements along both dimensions to compute it. The fallback is to look at the original transform used when image was first created and extract resolution part from there. I think if you were to use odc.geo.wrap_xr or odc.geo.xr_coords to construct xarray coordinates inside datacube it would add needed attributes into xarray to be able to guess correct resolution for a 1x1 pixel array.
I believe it just adds resolution attribute to x and y coordinates

Hey @Ariana-B @SpacemanPaul - how difficult would this be to implement in datacube 1.9? The single pixel use case is an important one for machine learning/pixel drill applications, so if there's existing tools available in odc-geo to improve this it'd be great to use them in datacube-core

To be honest @robbibt I'm not sure if the issue is with datacube.load or with further processing that happens afterwards, also what version of odc-geo?


Off-model pencil icon

Since #68, transaction rows have this weird heavy, very not adwaita icon:

Any reason to ship this in the first place? a-i-t should have document-edit-symbolic.

It's actually otherwise, we removed non-adwaita icon. Screenshot from current beta:

Hm, alright - closing if fixed on beta.


Gallery View: Scaling of SVG files

What Kind of Sample (view or column format)
View. Gallery.
Sample Description (what should it do)
Images recorded on an entry are to be shown for the card. The type of images include png, jpg (which seem to work) and SVG,
The issues seems to be SVGs where the scaling does not work.

Are you Willing to Help?
Sure, testing etc.  Coding, I cannot offer.

Hi @gvSmartEnergy .
I assume you are uploading an SVG file to the image column, and the SVG previewed without any problem in my environment.

Please check again that the SVG file has been uploaded.
If an SVG file has been uploaded and the SVG file is not previewed, I suspect that the community cannot resolve it. So, I am sorry, but in that case, please submit feedback to Microsoft at the following site.
https://feedbackportal.microsoft.com/feedback/forum/ab3ad59e-6dd1-ec11-a7b5-0022481f35a4


STIX data center file loading and error propagation

PR Description
Adds more error propagation for STIX files and reformats some of how the RHESSI/STIX loader classes deal with returning many arrays.
TBH I think we should decouple RHESSI and STIX loaders as much as possible. They are similar in some ways but STIX has pixel data which we will need to handle totally separately.
Fixes #109
I need to run the tests on the updated files still
WS

Codecov Report
Patch coverage: 3.57% and project coverage change: -48.58 :warning:

Comparison is base (c40792c) 55.06% compared to head (c687106) 6.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #110       +/-   ##
==========================================
- Coverage   55.06%   6.48%   -48.58%
==========================================
  Files          19       8       -11
  Lines        3122     925     -2197
==========================================
- Hits         1719      60     -1659
+ Misses       1403     865      -538

Impacted Files
Coverage Δ

sunxspex/sunxspex_fitting/io.py
28.57% <ø> (-71.43%)
:arrow_down:

sunxspex/sunxspex_fitting/instruments.py
2.37% <1.92%> (-19.47%)
:arrow_down:

sunxspex/sunxspex_fitting/rhes_spec_code.py
9.09% <25.00%> (-5.46%)
:arrow_down:

... and 13 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Pending the style checks I think this PR is ready to be undrafted so I'll mark it as such.
Here is the example notebook: https://github.com/settwi/sunxspex/blob/stix-error-propagation/examples/stix/stix-example.ipynb

I agree. Can we move some of the very instrument-specific code to stixpy? I took the correction function directly from stixdcpy but modified the time constants with updated values I got from Hannah Collier.
Thanks for the review!
Best
William


gitup -V : invalid argument

Hello,
I remember that -V worked ok on 0.87 but not on 0.88:
gitup -V
gitup:
Cannot find a matching section in the command line arguments.  These are the configured sections:
* ports
* quarterly
* release
* stable
* current
: Invalid argument
Thanks,
Nuno Texeira

Thank you for finding this!

Thank you for finding this!


Mentorship: First pass at Track info

Should do a second pass at the wording
TEST=manual
Change-Id: Ic21be85c7eabb7377622d278a9af12c09e2390aa

Code Review comments can be found at https://gerrithub.io/q/Ic21be85c7eabb7377622d278a9af12c09e2390aa


The error "upstream server temporarily disabled while SSL handshaking to upstream" occurs when the Nginx Porxy Cilium Gateway API is used

Is there an existing issue for this?

[X] I have searched the existing issues

Version
equal or higher than v1.16.0 and lower than v1.17.0
What happened?
The error "upstream server temporarily disabled while SSL handshaking to upstream" occurs when the Nginx agent Cilium Gateway API is used

How can we reproduce the issue?
1.Configure in cilium
gatewayAPI:
  enabled: true
  hostNetwork:
    enabled: true
    nodes:
      matchLabels:
        role: infra
        component: gateway-api

Refer to the official deployment of the bookinfo application
Write and apply Gateway and HTTPRoute (Note: A certificate has been added, and the certificate is applied for on a third-party platform.)

apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: bookinfo-gateway
spec:
  gatewayClassName: cilium
  listeners:
  - name: https-bookinfo
    port: 2443
    protocol: HTTPS
    hostname: "bookinfo.youlai.net"
    tls:
      certificateRefs:
      - kind: Secret
        name: tlscred
    allowedRoutes:
      namespaces:
        from: All
---
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: bookinfo
spec:
  parentRefs:
  - name: bookinfo-gateway
  hostnames:
    - bookinfo.youlai.net
  rules:
  - matches:
    - path:
        type: Exact
        value: /productpage
    - path:
        type: PathPrefix
        value: /static
    - path:
        type: Exact
        value: /login
    - path:
        type: Exact
        value: /logout
    - path:
        type: PathPrefix
        value: /api/v1/products
    backendRefs:
    - name: productpage
      port: 9080

Use https://bookinfo.youlai.net:2344/productgpage to access is normal at the moment. (The domain name resolves to the IP address of the labeled node)
4.Proxy the above server on NGINX (Note: Certificate as above)
user nginx;
worker_processes auto;
error_log /var/log/nginx/error.log notice;
pid /run/nginx.pid;

include /usr/share/nginx/modules/*.conf;

events {
    worker_connections 1024;
}

http {
    log_format  main  '$remote_addr - $remote_user [$time_local] "$request" '
                      '$status $body_bytes_sent "$http_referer" '
                      '"$http_user_agent" "$http_x_forwarded_for"';

    access_log  /var/log/nginx/access.log  main;

    sendfile            on;
    tcp_nopush          on;
    keepalive_timeout   65;
    types_hash_max_size 4096;

    include             /etc/nginx/mime.types;
    default_type        application/octet-stream;

    include /etc/nginx/conf.d/*.conf;
    upstream cilium-pools-https {
       server <IP_ADDRESS>:2443;
       server <IP_ADDRESS>:2443;
       server <IP_ADDRESS>:2443;
    }

    server {
        listen       80;
        listen       [::]:80;
        server_name  bookinfo.youlai.net;

        location / {
          return 301 https://$server_name$request_uri;
        }
    }

# Settings for a TLS enabled server.
   server {
        listen       443 ssl http2;
        listen       [::]:443 ssl http2;
        server_name  bookinfo.youlai.net;

        ssl_certificate "/etc/nginx/pki/youlai_net.crt";
        ssl_certificate_key "/etc/nginx/pki/youlai_net.key";
        ssl_session_cache shared:SSL:1m;
        ssl_session_timeout  10m;

        location / {
          proxy_pass                              https://cilium-pools-https;
          proxy_http_version                      1.1;
          # proxy_ssl_name                        $host;
          # proxy_ssl_certificate                   "/etc/nginx/pki/youlai_net.crt";
          # proxy_ssl_certificate_key               "/etc/nginx/pki/youlai_net.key";
          # proxy_ssl_ciphers                        HIGH:!aNULL:!MD5;
          # proxy_ssl_trusted_certificate          "/etc/nginx/pki/youlai_net.crt";

          # proxy_ssl_verify                        on;
          # proxy_ssl_verify_depth                  2;
          # proxy_ssl_session_reuse                 on;
          # proxy_ssl_server_name                   on;

          proxy_cache_bypass                      $http_upgrade;
          proxy_set_header Upgrade                $http_upgrade;
          proxy_set_header Connection             "upgrade";
          proxy_set_header Host                   $host;
          proxy_set_header X-Real-IP              $remote_addr;
          proxy_set_header X-Forwarded-For        $proxy_add_x_forwarded_for;
          proxy_set_header X-Forwarded-Proto      $scheme;
          proxy_set_header X-Forwarded-Host       $host;
          proxy_set_header X-Forwarded-Port       $server_port;
        }
   }
}

At the moment when I visit https://https://bookinfo.youlai.net/productgpage, The browser reports 502 Bad Gateway, and the following error is found in the NGINX error log: "upstream server temporarily disabled while SSL handshaking to upstream"
Cilium Version
cilium-cli:  compiled with go1.23.0 on linux/amd64
cilium image (default): v1.16.0
cilium image (stable): v1.16.1
cilium image (running): 1.16.1

Kernel Version
Linux cn-cp-1 6.6.0-<IP_ADDRESS>.oe2403.x86_64 #1 SMP Wed Aug 28 15:00:00 CST 2024 x86_64 x86_64 x86_64 GNU/Linux

Kubernetes Version
Client Version: v1.31.0
Kustomize Version: v5.4.2
Server Version: v1.31.0

Regression
No response
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@jieshiyeskey this is a complicated setup. So, you have a ngninx proxy fronting your kubernetes cluster? If browser-based TLS connections work properly to the Ingress controller, but your nginx proxy does not, then I would assume the issue lies with your nginx configuration.
Can you diagram the packet flow for me, and explain exactly where you think it's not working?

Yes. There is an nginx agent in front of the kubernetes cluster. Direct access to the kubernetes cluster service is normal (using hostNetwork mode, protocol is HTTPS), if through the NGINX proxy will report a header error. The configuration is as follows.

@squeed


Sort manager simplification

This change is split up into mostly independent commits, it might be easier to review each commit rather than the whole change.
The main change is to join all the vectors of members used for each bucket, into a single vector of a struct with all the per-bucket members (bucket_t).
The convention in the rest of the code seems to use a _ suffix on members, rather than always accessing them through this, so I'm transitioning towards such naming in SortManager too (and using this is more of a Java thing and not very common in C++).
inline are redundant on member functions that are defined inline (as it's implied).
I transitioned two memory allocations to use unique_ptr<> instead of raw new and delete[].
Instead of assigning values to members in the constructor, I introduced an initializer list to initialize the members instead, as well as added const in a few places to ease reading.

Hey arvid, these changes seem good. I am prioritizing on the consensus so I have not looked at these changes in detail, and will not be working on chiapos for a while, but feel free to merge whatever changes you think are good.


docs: add Sphinx documentation generation

I added Sphinx document generation so that we can upload it to https://readthedocs.org/. I'm... not super happy with the formatting. Here's how the docs render in Chrome:

Please be ruthless with your reviews for this one!

It honestly looks like Sphinx docs to me. You could maybe use a little more white space between each function/class, but otherwise they look like docs! I don't have a whole lot of experience with the package itself, so you'll want to rely on @andrewdotn for documentation accuracy.

You could maybe use a little more white space between each function/class, but otherwise they look like docs!

Yeah, I noticed that! I'm using the defaults, and apparently that's the default spacing between elements? I'll see if I can fix it!

I changed the theme to Readthedocs and now it looks SUPER documentation-y.
Please review the docs here, and then I'd like to merge #6 in here to clean up the PyTransducerFile/TransducerFile nonsense!
This is what it renders as:

@andrewdotn I used m2r2 to include the README.
Because the README + the API documentation looked a bit cluttered on one page, I split it into three pages (the third is for the Sphinx autoindices that it always wants to include).


After conquering enemy city the square is still occupied

An enemy chariot was on the red square. After I occupied the city the chariot disappeared but the square is still marked red.

Are you sure the square is not occupied by another city?
I'll try to reproduce this.

Yes I was just thinking about this yesterday after I posted the issue. Close this one, if it turns up again we'll open it.


Fix 2FA Login

Hello,
I've just test it and it works !! Thanks so much.
I noticed 1 change and 1 issue :
in the configuration.yaml I had to put my code under quote :
code: '1234' instead of code: 1234
The issue I have is that HA detects 2 new integration :
1 named with my Verisure username which works
1 named Securitas direct which is detected new at each reboot and that we cannot ignore. It has a configure button but the 2FA check fails

@TheGui01 - Thanks for testing.
I limited my changes to just fix the Login. I believe that other changes/ fixes would be part of an ongoing work that @guerrerotook might be doing

Thanks very much!
I'm going to merge that right now and test in on my local environment to see how it works!


Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py.
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Fix validate_user to return false if the username starts with any character which isn't a letter


[Question] About LLaVA-LLaMA-2 fine tune

Question
Thanks for sharing the code and support for LLaMA-2. I wanna finetune llava-llama-2, but there is no pretrained projector released. I want to extract the projector from the provided llava-llama-2 checkpoints, but this error occurs:
ValueError: Unexpected embed_tokens_weight shape. Pretrained: torch.Size([32004, 4096]). Current: torch.Size([32003, 4096]). Numer of new tokens: 2.
Is there any method that I can train the model from the provided checkpoints? Instead of from the pre-trained model? For example,

I pretrain the model for alignment.
I finetune the model on dataset A and obtain a checkpoint.
I have another new dataset B.  Then I want to finetune this model on dataset B. How can I extract the projector from the checkpoint obtained in step 2?

Thanks in advance for your sincere help!

Hi, this issue may be due to the mismatch between the code base and the command / projector you are using.
Please try using the latest finetune script here, and corresponding projector weights here.
Please let me know if you have any other issues, thanks.


CoAP protocol support

Unreliable and low bandwidth networks require connection less modes of operation.
CoAP protocol support in Vert.x would be a great feature.

@rtv2222 would you be interested to contribute ?

yes.
-Rajesh
On Wed, Oct 12, 2016 at 6:42 PM, Julien Viet<EMAIL_ADDRESS>wrote:

@rtv2222 https://github.com/rtv2222 would you be interested to
contribute ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vert-x3/issues/issues/187#issuecomment-253209406, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMv63Ho5UBkQy-ZrIoUVeJlKTG-pCFLGks5qzNzagaJpZM4J0xjv
.

@rtv2222 have you already started to investigate ? you may want to read this issue https://github.com/vert-x3/issues/issues/187

Any progress on this issue?

no we don't have any contributor on this topic

I have read up on the RFC as well as looked up other open source implementations. However, I'd appreciate pointers on how to get started.

do you mind sending a mail to the vertx-dev group to discuss this ?

Hi
I can't promise, but maybe it's possible for me to do a contribution on this.

that would be great, server or client ?
I think client makes more sense for building IoT gateways with vertx.

I was thinking about to build it on top of califorium-core https://www.eclipse.org/californium. It's lightweight too as i saw and it's an eclipse project as well. How looks this idea to you?
They have both, server and client against the same API (one Maven dependency). Therefore i think, it would be possible to make both.
Later it maybe can sense to implement the LWM2M for it (and the MQTT as well). So Vert.x provides the most famous IoT standards

@wem vertx like califorium uses Netty, so that should be doable given the netty versions are compatible

Hello
Sorry for my late reply.
Unfortunately it's not possible for me to contribute on this issue because lack of time. I will go with MQTT as IoT protocol.


Rearrange HardwareAssetAdmin fields.

This change is

Coverage increased (+0.02%) to 52.005% when pulling 94c387d6aad00a372311ffe08c804202c1c33515 on ropable:master into 5f8f9b32723c2423b8be389a28afa1dd0f814d80 on parksandwildlife:master.


Weird summary when using "past 7 days"

When checking the "past 7 days" summary I noticed my progress from April 9 missing completely.
Last 7 days (equivalent of ?from=2021-04-05&to=2021-04-13) doesn't include my progress from April 9:

Checking April 9 (?from=2021-04-09&to=2021-04-10) shows me 5 hours spent on a project:

I've been messing with the ranges and I can't figure out a pattern. I can provide my heartbeat data and API url if needed for testing.

That's weird :thinking: Could you provide a (potentially pseudonymized) dump of your database (you can also send it to me via mail directly) and afterwards try to "Clear & Regeneration Summaries" on the settings page?

I just tried using &recompute=true when requesting my summary and it seems to show everything correctly.

I'll create a dump and send it to you via email. Will it work if I remove other users and their corresponding heartbeats+summaries? I'm using this instance with two friends and don't want to share their data.

Alright, it took me quite a while to figure out the cause of the problem. But I think I have fixed it now. Just for the record (and to speed up things in case something similar ever occurs again):

Current summary computation assumes that a summary is generated for every single day in a year, no matter if that day actually has heartbeats or not.
If a day doesn't have heartbeats, the summary's from and to dates correspond to start and end of that particular day respectively.
If a day does have heartbeats, the summary ranges from first to last heartbeat, i.e. only a subset interval of the entire day.
In your case, two unfortunate things fell together:

First, you didn't have any heartbeats in 04/08, i.e. the corresponding summary was from 2021-04-08 00:00:00 to 2021-04-09 00:00:00
Second, for some reason, no summary at all was present for 04/09. I am still not sure how this could happen. Maybe there is still some bug about time zones or so, I have to check that again.

Both events combined revealed a bug in the logic that determines missing "gaps" between two summaries, that never took effect before.

I'll still test the fix a bit more extensively on my own instance before I publish a new release.
Btw., the "Clear & Regenerate" thing should have fixed the problem anyway. Did you try it?

Do you, by chance, keep log files on your server? And if yes, does the Wakapi logs contain an entry reading like failed to generate summary ... on 04/09 or 04/10?

Found the reason why the summary was missing. There was another tiny :bug:.

Thank you for your very fast follow up!

Btw., the "Clear & Regenerate" thing should have fixed the problem anyway. Did you try it?

Yup, I used it just after creating the dump. It fixed my issue and the summary seams to be correct now.
If there is anything I could provide to further investigate this issue (if stuff happens to still break) I would be happy to do so!
Thanks again for the good work. I'm loving the project and it just keeps on giving.


install: Try apt-get update if the Ubuntu universe check fails

On a system where apt-get update has never been run, apt-cache policy may show no repositories at all. Try to correct this with apt-get update before giving up.

Merged, thanks @andersk!


Need to hide muted accounts in search results

Is your feature request related to a problem? Please describe.
Currently search results, including those for a given hashtag, will display accounts added to active mute lists and merely give them "badges" to indicate the list they are on. I find these badges perfectly useless given that a search result can easily become a mess of posts from accounts I would rather not see in either context of feed or search.
Describe the solution you'd like
I would like muted accounts to remain muted instead of having badges.
Describe alternatives you've considered
The only alternative I would find tenable would be have the moderation option to hide muted accounts from search results, and the less tenable option would be to have it as an advanced search option (better, I think, for it to be the other way around with an advanced search option to include muted accounts). I feel though that this should be default behavior, given the expectation that I myself had that muted accounts would simply remain muted in normal circumstances (search being a widely used feature), not to mention that the ability to narrow search results in this way would just make search more useful and less suceptible to spam.
Additional context
For example, #bodybuilding is riddled with thirstposting and next to useless for anyone actually interested in the practice of bodybuilding and finding folks likewise interested.

Very much agree
Related: #3234

maybe fixed by #5599 on ver 1.92


How to escape a special character?

e.g. Is it possible to search for the character '^' using the search method? I do not want it to be interpreted as a search modifier (boost).

At the moment the search string does not provide support for escaping characters. This is something that I want to add at some point.
In the mean time you can use lunr.Index#query directly to perform a search with a '^' character:
idx.query(function (q) {
  q.term("foo^")
})

Thanks @olivernn , I actually looked at that before but then I was stuck trying to get the best of both worlds, e.g. title:n^2. Any ideas as to how I can do this?

Everything that is possible with a search string is possible with the lunr.Index#query method, lunr.Index#search is implemented on top of it.
idx.query(function (q) {
  q.term("n^2", { fields: ["title"] })
})

The documentation shows how to add fields, boosts etc.

great, thanks @olivernn . Do you know how I can escape the wildcard * character? q.term('*') does a wildcard search...

Its not possible to escape the wildcard character at the moment, and I think it'll be a bit tricky to implement. I'll think about the best way to do so when implementing escape sequences in the search string, but "*" has special meaning in a number of places that might be harder to sidestep.

The latest alpha (2.1.0-alpha.2) includes support for escape query characters, e.g "12:00pm" will do a search for "12:00pm" rather than complain about a missing field called "12".
This does not include support for escaping asterisks "*", that requires some more fundamental changes that I'm not inclined to work on, yet.
As ever, try it out and let me know any feedback.

I've just published 2.1.0 which includes support for escaping special characters.

Excuse me, but I couldn't find the instruction how to use escaping for special charactes, could you please point me.
I try to search term "C#". But
idx.query(function (q) {
  q.term("C#")
});

didn't work.
I am also searching for possibility to search terms with characters: ":", "."
Thank you.

@wangpin34 I found this in our code, not sure where I got it from:
str.replace(/[~^\-+]/g, (x) => `\\${x}`)


Pod keeps restarting as the registered watcher says "Config file /config/config.yaml is updated"

1st, this project is good. I came here by chance before I wanted to write my own cluster event listener (kind of) to publish events directly to Mattermost.
Though I have deployed this bot in my Openshift cluster running on-premise, I have trouble running it.
The bug description
The deployed pod keeps restarting as the registerd watcher of the config/config.yaml says the file was modified. There is no sign of change from external source or manual.
To Reproduce
I use helm to create botkube in the botkube namespace. My Mattermost too is deployed in Openshift, but in a different namespace, mattermost.
helm install --name botkube --namespace botkube \                                                                             --set config.communications.mattermost.enabled=true \ --set config.communications.mattermost.url=http://mattermost.mattermost.svc:8065 \ --set config.communications.mattermost.token=generatedtoken \ --set config.communications.mattermost.team=my-team \ --set config.communications.mattermost.channel=cluster-stat \ --set config.settings.clustername=development-cluster \ --set config.settings.allowkubectl=true \ helm/botkube
(I have also used OCP specific route instead of svc).
Expected behavior
The bot should start with the provided configuration loaded in the /config/config.yaml.
Screenshots
Find a screenshot attached.

Let me know if you need any other detail. Also, tell me, please, if I am doing it right.

Hi @iamvvra ,
Are you using correct Mattermost URL? Because I see Mattermost is unreachable through the logs.

Yes, this log has that issue, but I fixed that by providing OCP route url - however, the initial messages reach Mattermost. See the screenshot

Are you still getting config update logs after setting OCP route url?

Yes, the get the same error even after I change it to a route, most recent deployment log for your ref. But, was that the cause of this issue?

That's strange. I hope you are using the latest release for deployment. Which cluster you are using? Also is there some process/job which might be updating the configmap? Could you please watch and tell me the status of configmap botkube-configmap?
Could you please post output of @BotKube version?

I am using the latest one v0.8.0. However, I tried to run this in my AWS EKS cluster with no restart (though the bot couldnt reach my Mattermost). There is no other jobs or process in this namespace to modify this configmap. As the pod keeps restarting I am attaching the event log.

Could you please send logs of the BotKube pod? Also please make sure that you are using the latest helm chart from v0.8.0 branch while deploying

Log attached. I configured fromm your release branch source.
botkube.log

ERRO[2019-08-06T16:03:31Z] Error in connecting to Mattermost team ngap
Error: : Invalid or expired session, please login again.,

Are you using correct token? Can you please try regenerating token?

Hi,
I guess there are some issues with mattermost latest version.

Got this same error, when tried to setup mattermost and botkube in my local (few weeks before).
Checked by generating mutiple tokens(user and bot tokens), but session was expiring instantly.
got CORS error as well due to client4 model in mattermost-server go pkg. Try adding CORS settings in mattermost config file

So it is good to check with this prespective too, by trying with privous stable version of mattermost.
@iamvvra can you check the Debug logs by setting evn LOG_LEVEL=Debug in the botkube pod to debug this error further.

@aananthraj I am running the bot in log level set to debug, also, I have provided one of the log in this thread. Moreover, I got the same error having tried with previous v0.7.0 version.
Having tried with new token today, I get the same error Error connecting to Mattermost, additionally with Segmentation violation - error below.

INFO[2019-08-07T05:07:18Z] Config file /config/config.yaml is updated. Hence restarting the Pod
INFO[2019-08-07T05:07:18Z] Config file /config/config.yaml is updated. Hence restarting the Pod

ERRO[2019-08-07T05:07:18Z] Error in connecting to Mattermost team devs
Error: : Invalid or expired session, please login again.,
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1268edc]

goroutine 96 [running]:
github.com/infracloudio/botkube/pkg/bot.(*mmBot).Start.func1(0xc0006ea080, 0xc0002d9920)
/go/src/github.com/infracloudio/botkube/pkg/bot/mattermost.go:104 +0x5c
created by github.com/infracloudio/botkube/pkg/bot.(*mmBot).Start
/go/src/github.com/infracloudio/botkube/pkg/bot/mattermost.go:101 +0x5c4

An update, I find the connectivity to Mattermost is now established, however the pod continues to restart assuming the /config/config.yaml has changed. I will see in my side if any monitoring agents or tools provokes this false change alert.

@iamvvra please don't use the older version of BotKube with newer helm charts. Which version of Mattermost you are using? We have tested it with Mattermost v5.11.1. We are trying to understand if issue is with latest version of Mattermost or from client side.

Can you please try with v5.11.1+ version?

Sure, I'll try that.

I have deployed the said Mattermost 5.11.1 app separatel. The BotKube reacts the same assuming the config.yaml was modified, keeps restarting the pod. However, the initial notification hits the Mattermost. I am not attaching logs as it was similar to one provided earlier.
Version & the channel the BotKube sends notifications. You can see multiple notifications everytime the pod restarts.

Is this have anything to do with Websockets?

@iamvvra I don't think it is a problem related to communication. Could you please verify that any other service is not updating botkube-configmap?

I'm having the same issue trying to connect Botkube 0.8.0 to slack on OpenShift.
I receive the same messages in slack, so the communication with slack is working. The pod keeps restarting because of the config.yaml change.

I suspect if this is due to Kubernetes release. What version of K8s you are using? @cyberox @iamvvra

I'm running OpenShift 3.11, based on Kubernetes 1.11.

I tried reproducing the issue on K8s v1.11 - minikube, GKE and EKS, couldn't reproduce it. I think it has to do with how Openshift manages resources. I think it updates mounted files for some reason. For now, I am opening another issue to have an ability to disable config file watcher and disable automatic restart on config change

Yes, a flag passed (helm too) on to the watcher to disable the auto reboot,  default being true.

I have tested this fix, it works!


Make it easier to change labels

Trello card
I've been working on adding/changing more labels to make the question pages more accessible. But that work is currently blocked, that's why I cherry-picked these changes which can be released without being blocked.
It's mainly rewriting tests to make them less dependent on the HTML. And it removes redundant and problematic code.
Expected changes
None.

Good work! LGTM


[SPARK-15058][MLLIB][TEST] Enable Java DecisionTree Save/Load test codes.

What changes were proposed in this pull request?
This PR enables six Java DecisionTree save/load tests since the feature is implemented in SPARK-6725. The test code already exist as comments. This issue just removes comments and amends very little. This PR also removes all TODO about SPARK-6725.

JavaDecisionTreeClassifierSuite.java
JavaGBTClassifierSuite.java
JavaRandomForestClassifierSuite.java
JavaDecisionTreeRegressorSuite.java
JavaGBTRegressorSuite.java
JavaRandomForestRegressorSuite.java

How was this patch tested?
Pass the Jenkins tests.

Test build #57527 has started for PR 12840 at commit af30f41.

Test build #57527 has finished for PR 12840 at commit af30f41.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57527/
Test PASSed.

Hi, @jkbradley .
Is there any problem in this PR?

Rebased.

Test build #57780 has started for PR 12840 at commit 25bcdfd.

Hi, @mengxr .
Could you review this PR when you have some time?

Test build #57780 has finished for PR 12840 at commit 25bcdfd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57780/
Test PASSed.

Test build #58007 has started for PR 12840 at commit b72ff73.

Test build #58007 has finished for PR 12840 at commit b72ff73.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58007/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58112 has started for PR 12840 at commit 37325a7.

Test build #58112 has finished for PR 12840 at commit 37325a7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58112/
Test PASSed.

Test build #58247 has started for PR 12840 at commit b75bf91.

Test build #58247 has finished for PR 12840 at commit b75bf91.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58247/
Test PASSed.

Test build #58260 has started for PR 12840 at commit aeb01e2.

Test build #58260 has finished for PR 12840 at commit aeb01e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58260/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58520 has started for PR 12840 at commit 2f5f76a.

Test build #58520 has finished for PR 12840 at commit 2f5f76a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58520/
Test PASSed.

Hi, @MLnick .
Could you review this PR when you have some time?
This is just about enabling the comment-outed test code according to the TODO comments.

Test build #58649 has started for PR 12840 at commit 8274cf6.

Test build #58649 has finished for PR 12840 at commit 8274cf6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58649/
Test PASSed.

Hi, @jkbradley , @mengxr , @MLnick , @rxin , @srowen .
Such a long silence definitely means I did this in a wrong way, didn't it?
There were already two PRs (this PR and #13100 ) about this.
If then, I had better close this PR and JIRA explicitly. Sorry for touching this.
If there is no comments until tonight, I will close my PR and JIRA as WONTFIX.
Maybe, someday, one of ML part committers is going to finish this correctly.
Thank you in any case.


For in array should be number index?

Bug Report
🔎 Search Terms
for in , array index
🕗 Version & Regression Information
Current 4.5.5, I think this is a common issue.
⏯ Playground Link
Playground Link
💻 Code
let arr:Array<boolean> = []
for(let key in arr){
    console.log(key)// key is string in editor, but number in runtime
}

🙁 Actual behavior
Key is string.
🙂 Expected behavior
Key is number.

But for..in gives strings, not numbers.  Even for arrays, you get string representations of numbers and not the numbers themselves:
let arr: Array<boolean> = [true, false]
for (let key in arr) {
    console.log(typeof key) // "string"
    console.log(key + key) // "00", "11"
}

Playground link
The current behavior is more correct than the behavior you're suggesting.  TypeScript doesn't currently expose a type like NumericString corresponding to strings to which numbers can be coerced, so string is what you get; see #32047 and #6346.

@jcalz There is a type error on union typeof array and string index object.
let arr:Array<any> = []
for(let key in arr){
    let value = arr[key] //OK
}

let obj:{[index:string]:any} = {}
for(let key in obj){
    let value = obj[key] //OK
}

let arrOrObj:{[index:string]:any}|...

Playground Link

There's a special rule that specifically allows
let arr:Array<any> = []
for(let key in arr){
    let value = arr[key] //OK
}

but this is only in effect when arr is exactly an array. Otherwise you get the stricter behavior.

let arrOrObj:{[index:string]:any}|Array<any>=[]
for(let key in arrOrObj){
    let value = arrOrObj[key] //Type error: No index signature with a parameter of type 'string' was found on type 'any[] | { [index: string]: any; }'
}

Is the intended behavior? Why?

Yes, this is the intended behavior as Ryan mentioned.
for...in iterates over your object using (key: string) .
When indexing the Array, the casting of the key from string to number is done,
And while looking up the property on objects (since your union type is an object {  [index: string]: any  }) we need to keep looking up with string
Hence the above behavior!
So to make it work in your case we can do -
let arrOrObj: { [index:string]:any }| Array<any>=[]
for(let key in arrOrObj){
    let value;
    if(Array.isArray(arrOrObj)){
        value = arrOrObj[Number(key)]
    }else {
        value = arrOrObj[key]
    }
}

And you should probably not use for..in for traversing array in the first place
There are other alternatives for it.
From the above case of yours, If you are not interested in key you can just iterate over the values itself
let arrOrObj_: { [index:string]:any} | Array<any>=[]
for(let val of Object.values(arrOrObj_)){
        let value = val
}

TypeScript doesn't currently expose a type like NumericString corresponding to strings to which numbers can be coerced.

Why don't we use number directly? To support early versions of typescript?

A similar issue #47636.

Why don't we use number directly?

Because TypeScript is largely just JavaScript with type annotations - and key will be a string when the loop actually runs.

TypeScript doesn't currently expose a type like NumericString corresponding to strings to which numbers can be coerced,

In particular, `${number}` (unfortunately, imo) does not correspond to strings to which numbers can be coerced, see #41893.


feat(starr): Create SDR (no WEBDL) custom formats

Pull Request
Purpose
To create custom formats which allow users to permit 4K SDR WEB releases whilst still blocking 4K SDR Remux/Bluray releases.
Approach

[x] Create new SDR (no WEBDL) custom formats for Radarr and Sonarr
[x] Add new custom formats to the collection of custom formats tables and lists
[x] Tweak SDR description in custom formats lists

Open Questions and Pre-Merge TODOs

[x] Not added to guide profiles at this time, only to the collections of custom formats

Requirements

[x] These changes meet the standards for contributing.
[x] I have read the code of conduct.

perhaps add in the description why we would allow 4K SDR WEBDL.

Added.


Respect torch.use_deterministic_algorithms

🐛 Describe the bug
Some of torchvision's backward CUDA operators (e.g., roi_align_backward) use gpu atomic add, which makes the nondeterministic. It would be great if they were coded to respect use_deterministic. The easy thing to do is just make them warn, but if we can implement a Python version of the function we can also do the same playbook as in https://github.com/pytorch/pytorch/pull/101115
cc @kurtamohler
Versions
master

Could be a way of addressing https://github.com/pytorch/vision/issues/7457
The non-determinism has been around forever - @ezyang is there a time-critical need to fix it now?

I'll submit the patch. I do kind of need it.


Document how to use dailygraphics w/o S3

Noting this b/c someone asked me about this a while back. Could just be a matter of listing which features won't work (deployment, checking against deployed files for identical slug names, assets rig) and advising folks to use render rather than deploy.

+1


Test CI (please ignore)

See #4767

@dotnet-bot test dailies please

@dotnet-bot test this please

@Penguinwizzard want to take a look at the static analysis failures?

Good things:
Forced Dev14 detection is working:
https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.8-ci/job/ci_legacy_x64_debug_prtest/1/console
16:20:49 D:\j\w\ci_legacy_x64---9dce0ce9>call .\jenkins\buildone.cmd x64 debug msbuild14
16:20:49 Skipping Dev15 and trying Dev14...
16:20:50 MSBuild located at "C:\Program Files (x86)\msbuild\14.0\Bin"


mkrd fail in rc.sysinit

I can use command mkrd -m 0 -s 512 512 correctly in NSH, but when I put it in rc.sysinit it gives nsh: mkfatfs: mkfatfs failed: 13. I am wondering if there is anything I missed?

Btw, I put this command in rcS script, it worked perfectly. Any differences between rc.sysinit and rcS file.

Hi @geniusdo are you following this Guide: https://nuttx.apache.org/docs/latest/guides/etcromfs.html ?
Look: "rcS is the start-up script, where rc.sysinit is the system-init script."
The error -13 means "Permission denied"
Both rc.sysinit and rcS are very similar, but there are some small details in the order they are called:
Look at apps/nshlib/nsh_init.c and you will see:
rc.sysinit is called early:
#if defined(CONFIG_ETC_ROMFS) && !defined(CONFIG_NSH_DISABLESCRIPT)
  pstate = nsh_newconsole(false);

  /* Execute the system init script */

  nsh_sysinitscript(&pstate->cn_vtbl);
#endif

rcS is called later:
#if defined(CONFIG_ETC_ROMFS) && !defined(CONFIG_NSH_DISABLESCRIPT)
  /* Execute the start-up script */

  nsh_initscript(&pstate->cn_vtbl);
  nsh_release(&pstate->cn_vtbl);
#endif

Maybe we should comment that rcS is better place to call user code

Thanks for ur reply.@acassis.  Yes, I followed the guide to migrate the custom start up script from an earlier version of nuttx. I am curious why I got the permission deny error. I noticed that in board/sim, there are password related files. Do I need to login as root or sth to execute this command?

@geniusdo the default nsh in sim request login (user/pass = admin:Administrator), you can modify to disable NSH_LOGIN. I think the rc script is executed before the login, read the comment above nsh_initialize(void) function.
There is also a nsh_loginscript that is executed everytime the user log in the nsh.

@acassis thx, I will check the code. Appreciate the detailed explanation. Closing this issue.


A few KW tests in v1 folder marked "acceptable" violate spec for minimum plaintext length

I found 3 KW test cases in the newer "testvectors_v1" folder that need review of the "result" flag enumeration.  These test cases are in testvectors_v1/aes_wrap_test.json, test cases tcId 12, 54 and 109.  These test cases each violate the minimum required plaintext length for KW in SP 800-38F Sec 5.2, which states KW plaintext (i.e. the key to be wrapped) must be a minimum of 2 semiblocks in length (which is 16 bytes).  I believe these test cases should update the result flag from 'acceptable' to 'invalid'.
Relevant snippet from SP 800-38F Sec 5.2:  "KW-AE and TKW-AE are defined on two or more semiblocks."

NIST does indeed not define KEY_WRAP for short inputs. However RFC 3394 does that in Section 2. The difference leads to ambiguous definitions. Some comparisons are here:
https://github.com/google/wycheproof/blob/master/doc/key_wrap.md
Also when a test vector has ambiguous definitions (i.e. is "acceptable") then there should be a flag, which is described in the header of the test vector file. Some libraries do in fact implement the behavior from RFC 3394. In these cases it is important to test the correctness of the wrapped key, since short keys are a rather strange exception.

Thanks Daniel, your explanation makes sense.  Closing the issue i created for KW and KWP would make sense, for the same reason you cite.


Enable or document shared formats

The docs show using formats like this:
attribute :uuid, :string,  format: ~r/\A\d{5}\-\d{5}\-\d{5}\-\d{5}\-\d{5}\z/

When multiple schemas use a uuid of that format, it would be less error-prone to be able to do something like:
attribute :uuid, :string,  format: Formats.uuid()

I don't see anything like this in the docs. Is it supported? If not, could it be?
So far I've attempted to use a separate module and ensure that it's compiled before the schema using require, @before_compile, and elixirc_paths, but I always get an error saying that the module is unavailable. Maybe this is because the Speck compiler runs before any of the Mix.compilers?

I don't see anything like this in the docs. Is it supported? If not, could it be?

We plan to support this is with custom attribute types, which is a feature in the backlog. I've documented it in this repo as issue #11.
A workaround to do what you wrote is to use Code.require_file in your spec:
Code.require_file "../lib/format.ex"

struct Example.Message

attribute :uuid, :string, format: Format.uuid

defmodule Format do
  def uuid do
    ~r/\A\d{5}\-\d{5}\-\d{5}\-\d{5}\-\d{4}\z/
  end
end

Please continue this thread if you run into any other issues with this approach.

Functionality will be covered by #11

Code.require_file "../lib/format.ex" does not work because the Speck compiler ignores it here.

Another workaround is to make the Format module a dependent library. It could be as simple as a path dependency in the same repo. That will cause the Format module to be compiled first, then Speck protocols, then the application code. This route also doesn't require adding any code to the header of the specs.


feat: support detecting current route

This pull request refactors the route function away from Ziggy's code to something I can work on. It introduces tests as well.
More importantly, it adds a new current function which purpose is to check if the given named route matches the current route.

[x] route tests
[x] route refactor
[x] current basic implementation
[ ] current complex selectors (eg. chirps.*)
[ ] Vue composable that returns a reactive route and current version

Will add glob support for current and reactive versions later.

@HassanZahirnia I'm warning you beforehand, current is very basic at the moment and has a lot of room from improvement. I didn't document it because I think it could have breaking changes soon. ^^


[doc]Add doc for Trino time travel query

Purpose

Linked issue: https://github.com/apache/incubator-paimon-trino/pull/43

Tests

API and Format

Documentation

This display:

Put >=368 first?


Cross Plugin Compatibility: Customizer

Work with https://github.com/creecros/Customizer
Reported Issues:

Favicon
Login logo

Forum Post:
https://kanboard.discourse.group/t/new-plugin-applicationbranding/2592/2?u=aljawaid
Issue:
https://github.com/creecros/Customizer/issues/141#issue-1570923344

Getting a bug from this override file - the rest are fine:
https://github.com/aljawaid/ApplicationBranding/blob/4f6bc9b0ac6f5e52da1ad4e100bee697d49ebfd7/Plugin.php#L16
Internal Error: SQL Error: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'db_name.customizer_files' doesn't exist

Fixed... old folder of Customizer wasnt deleted properly


Enforce google style guide through eslint

Summary
I added the --fix option to eslint in the lint script, it automatically fixes problems whenever possible I also added:

The bash shebang to test.sh
The Google style guide to eslint (taken from the contributing.md)
Editor config

Moreover, I disabled the following rules max-len, require-jsdoc, valid-jsdoc because the code is being written in the context of documentation(This can also be reverted, what do you think @samtstern?)

@IvanBila thanks for sending this request!  In general I am fine with the idea, but it seems to have introduced a lot of issues around comments+whitespace which I think are a regression from the old style.

Hi @samtstern any update here?

@IvanBila wow sorry I totally let this slip!  LGTM want to resolve merge conflicts and then we can merge?  If you don't want to handle the merge I'm happy to do it for you

Now eslint is very angry:
><EMAIL_ADDRESS>lint /home/travis/build/firebase/snippets-node
> find . -type f -name "*.js" -not -path "*node_modules*" | xargs eslint
/home/travis/build/firebase/snippets-node/functions/firestore-export/index.js
  10:1   error  Expected indentation of 2 spaces but found 44        indent
  11:1   error  Expected indentation of 2 spaces but found 44        indent
  12:1   error  Expected indentation of 4 spaces but found 2         indent
  12:23  error  Trailing spaces not allowed                          no-trailing-spaces
  15:1   error  Expected indentation of 4 spaces but found 2         indent
  16:1   error  Expected indentation of 6 spaces but found 4         indent
  17:1   error  Expected indentation of 6 spaces but found 4         indent
  18:1   error  Expected indentation of 6 spaces but found 4         indent
  19:1   error  Expected indentation of 6 spaces but found 4         indent
  20:1   error  Expected indentation of 6 spaces but found 4         indent
  21:1   error  Expected indentation of 6 spaces but found 4         indent
  21:22  error  Missing trailing comma                               comma-dangle
  23:1   error  Expected indentation of 6 spaces but found 2         indent
  23:9   error  Expected parentheses around arrow function argument  arrow-parens
  24:1   error  Expected indentation of 8 spaces but found 4         indent
  25:1   error  Expected indentation of 8 spaces but found 4         indent
  26:1   error  Expected indentation of 8 spaces but found 4         indent
  27:1   error  Expected indentation of 6 spaces but found 2         indent
  28:1   error  Expected indentation of 6 spaces but found 2         indent
  28:10  error  Expected parentheses around arrow function argument  arrow-parens
  29:1   error  Expected indentation of 8 spaces but found 4         indent
  30:1   error  Expected indentation of 8 spaces but found 4         indent
  31:1   error  Expected indentation of 6 spaces but found 2         indent
  32:1   error  Expected indentation of 2 spaces but found 0         indent
/home/travis/build/firebase/snippets-node/firestore/main/index.js
  715:11  error  Expected parentheses around arrow function argument  arrow-parens
  716:19  error  Expected parentheses around arrow function argument  arrow-parens
/home/travis/build/firebase/snippets-node/firestore/solution-scheduled-backups/app.js
  19:5   error  Inconsistently quoted property 'Authorization' found  quote-props
  22:9   error  There should be no space after '{'                    object-curly-spacing
  22:27  error  There should be no space before '}'                   object-curly-spacing
  43:9   error  There should be no space after '{'                    object-curly-spacing
  43:23  error  There should be no space before '}'                   object-curly-spacing
  52:50  error  There should be no space after '{'                    object-curly-spacing
  52:60  error  There should be no space before '}'                   object-curly-spacing
/home/travis/build/firebase/snippets-node/firestore/solution-sharded-timestamp/shardedTimestamps.js
   23:30  error  Multiple spaces found before '// add the new...'     no-multi-spaces
   27:25  error  Missing trailing comma                               comma-dangle
   32:1   error  Expected indentation of 8 spaces but found 10        indent
   32:50  error  Missing trailing comma                               comma-dangle
   35:30  error  Multiple spaces found before '// add the new...'     no-multi-spaces
   39:28  error  Missing trailing comma                               comma-dangle
   44:1   error  Expected indentation of 8 spaces but found 10        indent
   44:50  error  Missing trailing comma                               comma-dangle
   47:30  error  Multiple spaces found before '// add the new...'     no-multi-spaces
   51:26  error  Missing trailing comma                               comma-dangle
   56:1   error  Expected indentation of 8 spaces but found 10        indent
   56:50  error  Missing trailing comma                               comma-dangle
   57:6   error  Missing trailing comma                               comma-dangle
   75:33  error  Expected parentheses around arrow function argument  arrow-parens
   76:1   error  Expected indentation of 4 spaces but found 8         indent
   77:1   error  Expected indentation of 6 spaces but found 12        indent
   77:39  error  Multiple spaces found before '// new shard c...'     no-multi-spaces
   78:1   error  Expected indentation of 6 spaces but found 12        indent
   79:1   error  Expected indentation of 6 spaces but found 12        indent
   80:1   error  Expected indentation of 6 spaces but found 12        indent
   81:1   error  Expected indentation of 6 spaces but found 12        indent
   82:1   error  Expected indentation of 2 spaces but found 6         indent
   83:1   error  Expected indentation of 2 spaces but found 6         indent
   84:1   error  Expected indentation of 2 spaces but found 6         indent
   85:1   error  Expected indentation of 4 spaces but found 6         indent
   86:1   error  Expected indentation of 6 spaces but found 8         indent
   87:1   error  Expected indentation of 6 spaces but found 8         indent
   88:1   error  Expected indentation of 6 spaces but found 8         indent
   89:1   error  Expected indentation of 8 spaces but found 10        indent
   90:1   error  Expected indentation of 10 spaces but found 12       indent
   91:1   error  Expected indentation of 10 spaces but found 12       indent
   92:1   error  Expected indentation of 8 spaces but found 10        indent
   93:1   error  Expected indentation of 6 spaces but found 8         indent
   94:1   error  Expected indentation of 6 spaces but found 8         indent
   95:1   error  Expected indentation of 6 spaces but found 8         indent
   96:1   error  Expected indentation of 6 spaces but found 8         indent
   97:1   error  Expected indentation of 6 spaces but found 8         indent
   98:1   error  Expected indentation of 8 spaces but found 10        indent
   99:1   error  Expected indentation of 8 spaces but found 10        indent
  100:1   error  Expected indentation of 8 spaces but found 10        indent
  101:1   error  Expected indentation of 8 spaces but found 10        indent
  102:1   error  Expected indentation of 10 spaces but found 12       indent
  103:1   error  Expected indentation of 8 spaces but found 10        indent
  104:1   error  Expected indentation of 10 spaces but found 12       indent
  105:1   error  Expected indentation of 8 spaces but found 10        indent
  106:1   error  Expected indentation of 6 spaces but found 8         indent
  107:1   error  Expected indentation of 6 spaces but found 8         indent
  108:1   error  Expected indentation of 4 spaces but found 6         indent
  127:1   error  Expected indentation of 2 spaces but found 4         indent
  128:1   error  Expected indentation of 4 spaces but found 6         indent
  129:1   error  Expected indentation of 6 spaces but found 10        indent
  130:1   error  Expected indentation of 8 spaces but found 14        indent
  131:1   error  Expected indentation of 10 spaces but found 16       indent
  132:1   error  Expected indentation of 10 spaces but found 16       indent
  133:1   error  Expected indentation of 12 spaces but found 18       indent
  134:1   31merror  Expected indentation of 10 spaces but found 16       indent
  135:1   error  Expected indentation of 8 spaces but found 14        indent
  136:1   error  Expected indentation of 6 spaces but found 10        indent
  137:1   error  Expected indentation of 4 spaces but found 6         indent
  138:1   error  Expected indentation of 6 spaces but found 10        indent
  139:1   error  Expected indentation of 8 spaces but found 14        indent
  140:1   error  Expected indentation of 10 spaces but found 16       indent
  141:1   error  Expected indentation of 10 spaces but found 16       indent
  142:1   error  Expected indentation of 12 spaces but found 18       indent
  143:1   error  Expected indentation of 10 spaces but found 16       indent
  144:1   error  Expected indentation of 8 spaces but found 14        indent
  145:1   error  Expected indentation of 6 spaces but found 10        indent
  146:1   error  Expected indentation of 4 spaces but found 6         indent
  147:1   error  Expected indentation of 6 spaces but found 10        indent
  148:1   error  Expected indentation of 8 spaces but found 14        indent
  149:1   error  Expected indentation of 10 spaces but found 16       indent
  150:1   error  Expected indentation of 10 spaces but found 16       indent
  151:1   error  Expected indentation of 12 spaces but found 18       indent
  152:1   error  Expected indentation of 10 spaces but found 16       indent
  153:1   error  Expected indentation of 8 spaces but found 14        indent
  154:1   error  Expected indentation of 6 spaces but found 10        indent
  155:1   error  Expected indentation of 4 spaces but found 6         indent
  156:1   error  Expected indentation of 2 spaces but found 4         indent
/home/travis/build/firebase/snippets-node/firestore/solution-sharded-timestamp/nonShardedTimestamps.js
   15:25  error  Missing trailing comma                          comma-dangle
   20:1   error  Expected indentation of 8 spaces but found 10   indent
   20:50  error  Missing trailing comma                          comma-dangle
   26:28  error  Missing trailing comma                          comma-dangle
   31:1   error  Expected indentation of 8 spaces but found 10   indent
   31:50  error  Missing trailing comma                          comma-dangle
   37:26  error  Missing trailing comma                          comma-dangle
   42:1   error  Expected indentation of 8 spaces but found 10   indent
   42:50  error  Missing trailing comma                          comma-dangle
   43:6   error  Missing trailing comma                          comma-dangle
   60:1   error  Expected indentation of 4 spaces but found 6    indent
   61:1   error  Expected indentation of 4 spaces but found 6    indent
   62:1   error  Expected indentation of 4 spaces but found 6    indent
   63:1   error  Expected indentation of 4 spaces but found 6    indent
   82:1   error  Expected indentation of 2 spaces but found 4    indent
   83:1   error  Expected indentation of 4 spaces but found 6    indent
   84:1   error  Expected indentation of 6 spaces but found 10   indent
   85:1   error  Expected indentation of 8 spaces but found 14   indent
   86:1   error  Expected indentation of 10 spaces but found 16  indent
   87:1   error  Expected indentation of 10 spaces but found 16  indent
   88:1   error  Expected indentation of 12 spaces but found 18  indent
   89:1   error  Expected indentation of 10 spaces but found 16  indent
   90:1   error  Expected indentation of 8 spaces but found 14   indent
   91:1   error  Expected indentation of 6 spaces but found 10   indent
   92:1   error  Expected indentation of 4 spaces but found 6    indent
   93:1   error  Expected indentation of 6 spaces but found 10   indent
   94:1   error  Expected indentation of 8 spaces but found 14   indent
   95:1   error  Expected indentation of 10 spaces but found 16  indent
   96:1   error  Expected indentation of 10 spaces but found 16  indent
   97:1   error  Expected indentation of 12 spaces but found 18  indent
   98:1   error  Expected indentation of 10 spaces but found 16  indent
   99:1   error  Expected indentation of 8 spaces but found 14   indent
  100:1   error  Expected indentation of 6 spaces but found 10   indent
  101:1   error  Expected indentation of 4 spaces but found 6    indent
  102:1   error  Expected indentation of 6 spaces but found 10   indent
  103:1   error  Expected indentation of 8 spaces but found 14   indent
  104:1   error  Expected indentation of 10 spaces but found 16  indent
  105:1   error  Expected indentation of 10 spaces but found 16  indent
  106:1   error  Expected indentation of 12 spaces but found 18  indent
  107:1   error  Expected indentation of 10 spaces but found 16  indent
  108:1   error  Expected indentation of 8 spaces but found 14   indent
  109:1   error  Expected indentation of 6 spaces but found 10   indent
  110:1   error  Expected indentation of 4 spaces but found 6    indent
  111:1   error  Expected indentation of 2 spaces but found 4    indent


Fixing setWebsite method for SDK.

Added integration test to confirm this works with storage providers. I've tested this with GCP and updated the provider implementation. I'm just sorting out testing it on AWS before I can merge...

TDD ❤

This has been tested (and works) on AWS S3.


Verify valid UTF-8 when converting byte array (#2205)

Which issue does this PR close?

Closes #2205
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@HaoYang670 perhaps you might be able to give this one a review?

Oops good spot, will fix that one also


Replace fs with fsspec

We're currently processing your upload.  This comment will be updated when the results are available.


Add additional accessor methods to CfJsonDocumentContext

Description
Adds readStringList() and  hasNullValueAtPath() to CfJsonDocumentContext to facilitate tests, and renames the existing readList() to readLongList().
Release notes
n/a
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release | database >
[x] Created unit and/or browser tests which fail without the change (if possible)
[n/a] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[n/a] Extended the README / documentation, if necessary

User visible changes

[n/a] Followed steps to internationalize new strings
[n/a] Wrote browser tests using the validateAccessibility method
[n/a] Tested on mobile view. See mobile device mode
[n/a] Manually tested at 200% size
[n/a] Manually evaluated tab order

New Features

[n/a] Add new FeatureFlag env vars to server/conf/helper/feature-flags.conf
[n/a] Conditioned new functionality on a FeatureFlag
[n/a] Wrote browser tests with the feature flag off and on, etc.

Instructions for manual testing
n/a
Issue(s) this completes
Part of the fix for https://github.com/civiform/civiform/issues/5224

Current dependencies on/for this PR:

main

PR #5272   👈

PR #5225

PR #5263

PR #5116

This comment was auto-generated by Graphite.

Couple things:
If any of these are really only for tests, should we use @VisibleForTesting?
See if you like these changes:
https://github.com/civiform/civiform/compare/avalekse/add-read-string-list...avalekse/add-read-string-list-edited
https://github.com/civiform/civiform/compare/avalekse/add-read-string-list-edited...avaleske/add-read-string-list-edited-2
and feel free to apply them if so. Haven't cleaned up the associated tests on the second one.

See my comment on the overall PR, make changes if you want to (they're optional), then re-request review and I'll take a look.

As discussed offline, the way you suggested is what I originally tried to do, but the tests don't pass. (The tests are expecting a Long but we get an Integer, and we can't force a Long due to type erasure.)
The new methods are currently only used for testing, but there's nothing about them that requires they be restricted to tests (it wouldn't be making any abstractions leaky to use them for regular code).


Dungeonfinder flies too fast in SMP, hard to see.

Especially when using underground. should slow down at first, gradually speed up
and have more particles maybe

Rewrote the flying algorithm https://minecraft.curseforge.com/projects/cyclic/files/2412372


Added preview feature & Refactor/Changes to optimize/fix bugs in form…

1). Removed/commented the culprit calls and Called it directly in initState() to avoid problems.
2). I implement a debounce mechanism using the Timer class to optimize the method further. This ensures that the updateStyle method is called only once after a short delay, preventing rapid successive calls that could lead to performance issues.
3). Removing the temp Global Variable to Prevent Memory Leaks and Improve State Management

I call updateStyle in initState to set the initial styles when the widget is first created & using setState() instead of using temp!.updateStyle() in later code snippets.

4). Improved UI of export parameter and added fullScreenPreview via introducing a new class called: FullPreviewScree

Thank You

No need of any thank you man!
On Sun, Jul 14, 2024 at 10:29 PM Imad Laggoune @.***>
wrote:

Thank You
—
Reply to this email directly, view it on GitHub
https://github.com/Native-Bits-Team/M-Flow/pull/7#issuecomment-2227413715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZW2423Z7NRBGARBI4BIHZ3ZMKU7JAVCNFSM6AAAAABK3HVDY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGQYTGNZRGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Multiple config maps required for flagger when using config maps as property source

Is your feature request related to a problem? Please describe.
We are using flagger (https://flagger.app/) and have also implemented a way for our feature branches to be deployed using istio.
This means we have multiple versions of our app deployed with suffixes in the name such as 'app-name', 'app-name-primary', 'app-name-branch'
This will require us to deploy a separate config map and update our bootstrap.yaml dynamically based on which feature branches are being deployed.
Describe the solution you'd like
All the versions of this app should only need one config map that updates them all. A way to do this would be to add label on the ConfigMap that then could be used in the boostrap.yaml to select the single configmap.

Can you provide an example of what the ConfigMap would look like as well as what the bootstrap.yaml would look like?

Using my example of having 3 versions of the app -  app_name, app-name-primary, app-name-branch
ConfigMap
apiVersion: v1
kind: ConfigMap
name: app-name-primary
metadata:
  labels:
    spring.cloud.kubernetes.config: "true"
    spring.cloud.kubernetes.label: "app-name"
data:
  properties.yaml: |-
    {{range .Files.Lines "properties.yaml"}}
      {{ . }}
    {{ end }}

bootstrap.yaml
spring:
  application:
    name: app-name-primary
  cloud:
    kubernetes:
        sources:
          - label: app-name

This basically allows a one to many relationship between a ConfigMap and many apps. Having another look at the issues, this issue is the same as #937

At the moment, we do not have labeled support for config maps, but this is totally doable, as there is already for secrets.
@ryanjbaxter this would be kind of easy for me to add, but on top of main, on top of refactoring that is wip. wdyt?

I mentioned #937 as if you allow multiple applications to use a single ConfigMap as a property source, then the natural extension would be to refresh those apps when that ConfigMap changes.
Maybe I'm conflating multiple feature requests.

#937 is somewhat similar but it is in relation to the Spring Cloud Kubernetes Configuration Watcher.  Does #214 cover what you are requesting?

My bad, I realised I never mentioned we are also using Spring Cloud Kubernetes Configuration Watcher. This is obviously another feature request, so yeah you're right. Thanks.

Ok let's close this and use #937


React UI: Fix initial setting of past queries

Signed-off-by: Julius Volz<EMAIL_ADDRESS>

@boyskila I fixed things... too much :)

I also missed that


Update template for event hub

This is a quick update to our hub template after filling it out once for OpenScapes and finding a few places where it'd help to have extra info.

Opened a follow-up PR for something you missed from my review 😉 : https://github.com/2i2c-org/infrastructure/pull/852


Fix CC serialization problem in Scala base plugin

A lambda was not serializable.
This was probably not caught by tests, because load-after-store is currently disabled for the scala project. The test coverage will be added later as part of fixing enabling load-after-store in the tests.

@bot-gradle squash and merge

The merge queue build has started. Click here to see all failures if any.


Fix breaking OSS-Fuzz coverage build

Apologies, this is a duplicate. I was going through fixing other projects and didn't realise this was one I had already fixed.


Missing "Infinity" JS value

title — Infinity
description — Infinity is standard value from JS 1.3 but can't find it on "Can i use"
spec — https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/Infinity
status — rec - W3C Recommendation
categories — JS API
stats — a - (A)lmost supported (aka Partial support)
notes — Don't know if old IE or others support it
keywords — Math, standard
shown — false

Now has search result:
http://caniuse.com/#search=infinity


Add troubleshooting page for unsupported operations in Mountpoint

Description of change
Created a troubleshooting page in doc section for unsupported operations in Mountpoint.

Made the list of Unsupported Operations and its error code. Linked the page in README.md. Added its link in bug-report template along with instruction to provide logs.
Opened this PR as we have made the release.
NOTE - I have added the changes in PR #718 as unreleased section.
Relevant issues:
#533
Does this change impact existing behavior?
No.

This is not a breaking change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

For the overwrite error logging, I am keeping troubleshooting page as the error is logged in latest release. Changes in its setattr error logging which is merged in #718 can be reflected once we make the next release. It will just changing one error message. I do not want to block this PR till next patch release to get merged.
Also, we can have tag for documentation changes. What do you think @monthonk @dannycjones ?


[BUG] Removing Tailwind breaks HMR

Describe the bug
Updating client component nested in another client component triggers a page reload instead of hmr update.
It took ages to trace this back to removing Tailwind according to instructions below.
https://shopify.dev/custom-storefronts/hydrogen/framework/css-support#remove-tailwind
Undoing changes to package.json, src/styles/index.css and postcss.config.js fixes the issue, but obviously this project doesn't use Tailwind, so that's not ideal.
Deleting src/styles/index.css and removing it from index.html doesn't change anything.
I've been able to reproduce locally with a couple of different projects and machines.
To Reproduce
I've created a repository that reproduces this issue below.
https://github.com/typeandpixel/demo-store/tree/issue/hmr
Please note the commit history, which basically outlines the following steps:

Created project using npm init @shopify/hydrogen -- --template demo-store --ts
Created TestClientParent.client.tsx and TestClientChild.client.tsx components
Added TestClientParent.client.tsx to src/routes/products/[handle].server.tsx
Removed Tailwind

To reproduce, perform the following steps:

Run npm run dev
Navigate to /products/snowboard
Update text in TestClientParent.client.tsx
Note the hmr update logged in the console
Update text in TestClientChild.client.tsx
Note the page reload logged in the console

Updating TestClientChild.client.tsx triggers a hmr update after running git revert e24ef6ef0e3cca4e7e00567d22e80c7390e60070 to undo the Tailwind removal.
Expected behaviour
Updating client component should trigger hmr update instead of page reload.
Additional context
I strangely wasn't able to reproduce this on Stackblitz, but as mentioned was able to reproduce this across a couple of different machines.
After removing Tailwind, there's some errors in the browser console about some className differences between server and client.
react_devtools_backend.js:4026 Warning: Prop "className" did not match. Server: "bg-contrast/80 text-primary hidden h-nav lg:flex items-center sticky transition duration-300 backdrop-blur-lg z-40 top-0 justify-between w-full leading-none gap-8 px-12 py-8" Client: "bg-contrast/80 text-primary shadow-lightHeader hidden h-nav lg:flex items-center sticky transition duration-300 backdrop-blur-lg z-40 top-0 justify-between w-full leading-none gap-8 px-12 py-8"
Resolving these, for example by totally removing the offending components, doesn't actually resolve the HMR issue.

Hydrogen version1.3.1
Node version 16.14.0 16.16.01 and 18.8.0
Device details iMac (Retina 5K, 27-inch, 2017) macOS Monterey 12.4 and MacBook Air (13-inch, 2017) macOS Monterey 12.3.1

Looks like removing everything except @tailwind base; from index.css still works.

@frandiox — would #2175 fix this?


Fix: English Grammar

Corrected the subject verb disagreement in point ii of line 328.
Before changes:

After changes:

Thank you @sftim for approving my pull request and sharing the contributing guide. I will look into it and try to add more value. Thanks!


[embedded] Declare embedded-darwin and embedded-concurrency as test dependencies

@swift-ci please test


Merge HTTPlug (PHP-HTTP) factories into single class

Basically more streamlining. This addresses my own confusion with the existence of separate factory files, as mentioned in https://github.com/Nyholm/psr7/pull/55#issuecomment-409355463.
Based on #60 and should be merged after.
With this change I also noticed we are calling our own factories within methods of the PSR-7 classes… why?

Hm. Moving them to one factory makes sense. I agree. However, that will mess up php-http/discovery. They rely on these classes. We could update the discovery strategy. That would work if we assume everyone updates their dependencies.
What do you think? Is it worth changing these classes?
I think I would rather leave them and deprecate them as soon as 1.0 is released. I know that HTTPlug will deprecate these factories "soon" as well.

Rebased this now that #60 was merged.

What do you think? Is it worth changing these classes?

On the one hand I would love for the 1.0.0 release to have a minimal amount of files and think it is weird that we can’t do that because of a completely unrelated package (minus your involvement in HTTPlug in general).
On the other hand, if HTTPlug is going to pull the rug from php-http/message-factory anyway, maybe we should cut our losses and look forward to a 2.0.0 release completely without these classes instead?

Wow did my rebase get confused after you squashed #64 …


Delete duplicate MutatingProcessNode

Replaced by https://clusterhq.atlassian.net/browse/FLOC-339
In #287 (and the PR #299) I forgot to delete MutatingProcessNode from flocker.common.functional.test_ipc. It's only needed for the flocker.volume functional tests.
(318)(ssh-quoting-318 ? =)[~/.../HybridLogic/flocker]$ ack 'class MutatingProcessNode'
flocker/volume/functional/test_ipc.py
22:class MutatingProcessNode(ProcessNode):

flocker/common/functional/test_ipc.py
182:class MutatingProcessNode(ProcessNode):

We are moving our development planning to JIRA. This issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-339. You are welcome to file additional issues in GitHub if that's easier for you.


[TwigComponent] Provide form components for UX

Symfony form with twig provides many form_* functions, but that's ugly when combining with new html-like component syntax.
Maybe TwigComponent could provide generic components for these functions?
So for example we could write:
<twig:Form :form="form">
  <twig:FormErrors :form="form" />
  <twig:FormRow :form="form.fullName" />
  <div>
    <twig:FormLabel :form="form.fullName" />
    <twig:FormWidget :form="form.fullName" />
    <twig:FormErrors :form="form.fullName" />
  </div>
</twig:Form>

etc.

Not sure about that, but I want to be able to write in that syntax :wink:

PR welcome :). It does feel as simple as creating components (anonymous once we have that merged) that render, for example, {{ form_start(form) }}. It would be an interesting thing to try.

tweet linked to this PR is from @weaverryan:
https://twitter.com/weaverryan/status/1706342492612841669
Should we make a PR for this or is it specific to each project?

This issue is associated with the PR: https://github.com/symfony/ux/pull/1347


Update JSON:API from version 1.0 to version 1.1

https://jsonapi.org/format/#document-jsonapi-object

Is there any plans to do this for 1.1? I can help with this.


XML type isn't support when the tag is start with "_-"

Description:
XML type isn't support when the tag is start with "_-"
Steps to reproduce:
xml content = xml  <-DSD-ROUTEACCOUNT_CORDER002></-DSD-ROUTEACCOUNT_CORDER002> ;
ballerina run sap_idoc_producer.bal
error: .::sap_idoc_producer.bal:33:21: token recognition error at: '_' error: .::sap_idoc_producer.bal:33:22: token recognition error at: '-'
Affected Versions:
0.990.3
Suggested Labels:
Type/Improvement

@kalaiyarasiganeshalingam according to the W3C XML Recommendation a xml tag can start only from
"[a-zA-Z_] " [1].
We have allowed a tag to be started with '_' since it is allowed in the W3C XML  specification with https://github.com/ballerina-platform/ballerina-lang/pull/14164. But starting a tag with '-' is not allowed according to the W3C XML  specification.
[1] https://www.w3.org/TR/2008/REC-xml-20081126/#NT-NameStartChar


Makes sure all git hooks are installed when running bin/test

[#127226917]

We manually merged this


vscx/ms-vsliveshare-vsliveshare: 1.0.4673 -> 1.0.4836

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 137946 run on x86_64-linux 1

1 package built:

vscode-extensions.ms-vsliveshare.vsliveshare


loading data into python notebook

@maryamanuelnhsx I also deleted the github actions file as we are not using that for this project.

Beautiful work @craig-shenton. Steps taken to code is very clear and easy to follow. Thank you. Will merge to main now.
Next step is for us to document code and analysis in the notebook over the next week.
And adding a note to possibly create synthetic data for NHS App so people can follow along, but this is a very nice to have.


User build issue: undefined symbol: mlir::torch::registerTorchConversionPasses()

Reported here on Discord

When building IREE, I got an error:

[59/135] Linking CXX shared library lib/libIREECompiler.so
......
ld.lld: error: undefined symbol: mlir::torch::registerTorchPasses()
referenced by PluginRegistration.cpp:39 (iree/compiler/plugins/input/Torch/torch-iree/PluginRegistration.cpp:39)
>>>               ../compiler/plugins/input/Torch/torch-iree/CMakeFiles/torch-iree_registration.objects.dir/PluginRegistration.cpp.o:(mlir::iree_compiler::PluginSession<mlir::iree_compiler::(anonymous namespace)::TorchSession, mlir::iree_compiler::(anonymous namespace)::TorchOption
s, (mlir::iree_compiler::PluginActivationPolicy)1>::Registration::registerPasses()) in archive lib/libtorch-iree_registration.a

ld.lld: error: undefined symbol: mlir::torch::registerTorchConversionPasses()
>>> referenced by PluginRegistration.cpp:40 (iree/compiler/plugins/input/Torch/torch-iree/PluginRegistration.cpp:40)
>>>               ../compiler/plugins/input/Torch/torch-iree/CMakeFiles/torch-iree_registration.objects.dir/PluginRegistration.cpp.o:(mlir::iree_compiler::PluginSession<mlir::iree_compiler::(anonymous namespace)::TorchSession, mlir::iree_compiler::(anonymous namespace)::TorchOption
s, (mlir::iree_compiler::PluginActivationPolicy)1>::Registration::registerPasses()) in archive lib/libtorch-iree_registration.a

ld.lld: error: undefined symbol: mlir::torch::registerConversionPasses()
>>> referenced by PluginRegistration.cpp:41 (iree/compiler/plugins/input/Torch/torch-iree/PluginRegistration.cpp:41)
>>>               ../compiler/plugins/input/Torch/torch-iree/CMakeFiles/torch-iree_registration.objects.dir/PluginRegistration.cpp.o:(mlir::iree_compiler::PluginSession<mlir::iree_compiler::(anonymous namespace)::TorchSession, mlir::iree_compiler::(anonymous namespace)::TorchOption
s, (mlir::iree_compiler::PluginActivationPolicy)1>::Registration::registerPasses()) in archive lib/libtorch-iree_registration.a

Commands used:
git clone https://github.com/openxla/iree.git
cd iree
git submodule update --init

cmake -G Ninja -B ../iree-build/ -S .
They are used here:
https://github.com/openxla/iree/blob/611402e434cd10d2741deae2dcab9662bb4d94f0/compiler/plugins/input/Torch/torch-iree/CMakeLists.txt#L20-L23 https://github.com/openxla/iree/blob/611402e434cd10d2741deae2dcab9662bb4d94f0/compiler/plugins/input/Torch/torch-iree/PluginRegistration.cpp#L13-L16 https://github.com/openxla/iree/blob/611402e434cd10d2741deae2dcab9662bb4d94f0/compiler/plugins/input/Torch/torch-iree/PluginRegistration.cpp#L38-L41
That all seems correct...

This issue can be closed. I managed to build the reported target on an almost similar setup:
Clang: 14.0.0-1ubuntu1.1
Target: x86_64-pc-linux-gnu
OS: Ubuntu 22.04.1
cmake: 3.22.1
ccache: 4.5.1
ninja: 1.11.1.git.kitware.jobserver-1
Ubuntu LLD: 14.0.0

My guess is that the user encountered the build error because the contents of ccache were not properly invalidated. This propbably occurred in successive builds after rebasing and updating the LLVM submodules.

Yeah, the build setup is fairly normal and well tested on CI. We've had similar issues where dependencies were missing, leaking to flaky builds based on the order that targets were built. If that is the case here, and not just some local build configuration issue, some sort of fix could help. We can close this since it isn't very actionable without consistent reproduction steps or more user reports though.


Terrible

After 10 minutes, I still dont know how to migrate a VM. I don't want to know the differences between this or that, or what is not supported. The article fails to describe the actions necessary to DO the migration. It should START by: to migrate a VM, do this, then do that, instead of getting lost in a "deep dive" that completely misses the point.
Also, on the portal, I don't want to see a banner sending me to this useless info. I want a button saying "migrate" that sends me to the migration workflow, so I don't even need to read all this.
You are losing track of the customer. We use Azure to solve our problems. This migration is helping you overcome some shortcomings in your design and some of your own problems, I could not care less about the benefits of the resource manager, my job it not to manage VM, I use VMs to perform work for me. All I need is... nothing in terms of VM management, just keep it running, keep the OS up to date, and don't break anything, ever. That's the only reason I use Azure since 2008 or so: I don't want to be bothered. If I wanted to be bothered, I would have a server in my basement and as it stands it would probably be less trouble.
Those migrations only costs us time and pushes work on us that we never signed up for: either make it 100% automatic and stop bothering us with your internal housekeeping, or make it a one-click affair and deal with whatever limitations yourselves. At the very least, make clear step by step instructions and link them directly from the portal. Don't expect us to spend hours wading through a sea of articles to find the information.

@axelriet Apologies for all the inconvenience caused. Can you help me understand which documentation you are referring to so I can help you out better?
Thanks

@axelriet Could you please confirm if you are using https://docs.microsoft.com/en-us/azure/virtual-machines/windows/move-vm for the mentioned feedback?
Thanks

@axelriet Any update on this? Awaiting your response.

@axelriet We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.


feat/add dao financial statements

@parrot9design

There are 2 columns each representing single month. Selected time period says past month. Is this intended? What happens when I change the time period? Will there always be 2 data columns ?

There are 2 columns each representing single month. Selected time period says past month. Is this intended? What happens when I change the time period? Will there always be 2 data columns ?

Yeah this didn’t make sense to us either, until Scott broke it down. 😅
It uses a trailing time period, so when you change the time period, both columns will update to show the correct date ranges and data. The first column will always show data for the time period ending today, and the second column shows the previous period.
So if you selected past month today, the first column would show financial data for the month ending today (AUG 3 - SEP 2), and the second would show data for the previous month (JUL 3 - AUG 2).
If you were to change it to past week, the columns would show AUG 27 - SEP 2 and AUG 20 -AUG 26.  past day would show SEP 1 - SEP 2 and AUG 31 - SEP 1 (unless keeping them to single days – SEP 2 and SEP 1 – would be more accurate for reporting @bennyoptions).
We’ll always have two columns so it’s easy for people to compare the financials between the current and previous period.
As a side note, I noticed we have the $ value of Balanced Dollars under Loan fees. I’m not sure how that made it into the design we shared with you, but let’s remove that and only show the number of tokens, like under Swap fees.

Makes sense now, thanks @parrot9design
So half a year and a year periods will be available after Balanced being live for 2x the time period ?
Are APIs ready or should I contact someone about it ?

Yep, that’s correct! past 6 months and past year can be included when we get to the 1 year and 2 year mark, respectively. So past 3 months is the highest time frame we can include for now (maybe even 2 months, considering we’re only just past 4 months of operation).
I think the Geometry team are still working on the APIs, but @BennyOptions will have more insight into that.

Waiting for the APIs

Holdings are static.
Values in Earnings starting with ** are static and are missing in API response
I'm aware of some values displaying as 0 right after you reload the page
@parrot9design can you please check the numbers for loan fees ?

For the Earnings dropdown, let's use these options:

day
week
month
2 months

For the Loan fees, let's remove the $ values from the bnUSD row, so each column only displays a single number.

Current
Ideal

Also, remove the comma from the date formatting (shown in the images above, as well).

Holdings are static.
Values in Earnings starting with ** are static and are missing in API response

To clarify, only the Loan fee API is working at this stage, then? Do you need us to provide a date selector design for the Holdings section, or are you okay to try this on your own?

To clarify, only the Loan fee API is working at this stage, then? Do you need us to provide a date selector design for the Holdings section, or are you okay to try this on your own?

Yes, only loan fees are working right now. I also have data for the Holdings  current day but not for any past date.
I've contacted Pranav about the API issues.
There is no need for date picker design

@parrot9design  time picker added

The daofund balance sheet endpoint is up here: https://balanced.geometry.io/api/v1/stats/daofund-balance-sheet?timestamp=-1
You can test out different parameters with this page: https://balanced.geometry.io/api/v1/docs#/stats/get_daofund_balance_sheet_api_v1_stats_daofund_balance_sheet_get
NOTE: the timestamps are unix timestamps in microseconds. A -1 timestamp will give you the latest balance sheet
Example query to get daofund balance sheet of the last week: https://balanced.geometry.io/api/v1/stats/daofund-balance-sheet?timestamp=1631575246128000
This endpoint will only get you the bottom half of the page, the income statement endpoint are a WIP. Looking to get it finished by EOW.

@hetfly all numbers have been verified within reason.
@octocat512 if you want to review the code prior to merging, please do.
Let's merge this PR on Monday or Tuesday night US time when we announce the new roadmap.

@octocat512 @BennyOptions
I want to do some refactoring, will do so prior to Monday

@octocat512  @parrot9design
thanks for your feedback, everything is fixed


Specifying a recipe in a cookbook but not soloistrc

I would like to be able to run whatever recipe I like out of the cookbooks without adding each one I might want to run to soloistrc

Great idea.  I was way too clever with that.  Pull requests welcome, or I'll get to it with the next release.


IITC failed to extract required parameters

I am getting a dialog box in IITC called "IITC Broken" that says "IITC failed to extract the required parameters from the intel site. This can happen after Niantic update the standard intel site. a fix will be needed from the IITC developers."

Temporary issue cause by NIA throwing 404 for gen_dashboard. Has resolved itself.

Non issue.. Close @fkloft ?


Remove prerelease for OTLP exporter

@AaronMaxwell

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@cijothomas Only the author can sign off this PR.