V1.12 plus cmake

For https://github.com/transmission/transmission/issues/3274
Need to create v1.12-plus-cmake branch on this fork repo and retarget into it.

I'm closing this PR but thank you for making it anyway :green_heart: -- it's simply easier for an admin to do this from the command line by creating the new branch locally and then cherry-picking the cmake patch, then pushing.  Since I sniped you on this PR, do you want to do the honors in transmission/transmission? :smile:


add synonyms to !top [Distro OR Editor OR ...]

by mlvzk: https://github.com/unixporn/trup/issues/150
Like:
nvim => neovim
arch => Arch Linux

So that results in !top Editor don't have duplicate entries (1. nvim, 4. neovim should be joined into one)

Concept query:
WITH x AS (
    SELECT
        info ->> 'Editor' AS value,
        REPLACE(LOWER(info ->> 'Editor'), 'neovim', 'nvim') AS normalized
    FROM
        sysinfo
    WHERE
        info ->> 'Editor' != ''
),
y AS (
    SELECT DISTINCT ON (normalized)
        value,
        count(*) OVER (PARTITION BY normalized)
    FROM x ORDER BY normalized,
    count DESC
)
SELECT
    *
FROM
    y
ORDER BY
    count DESC
LIMIT 5
 value  | count
--------+-------
 Neovim |    96
 vim    |    55
 nano   |    24
 Emacs  |    10
 micro  |     8
(5 rows)

or distro, Distribution and distribution instead of Distro


Make name a required param in backend()

Summary
Details and comments
Fixes #1147

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.009%) to 83.667%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/qiskit_runtime_service.py
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
6275

Relevant Lines:
7500

💛  - Coveralls


create search controller

Did

created kanji form
created SearchController class
created kanji-visualize endpoint

Caution

I also created some static methods at GraphController and InfoController. Please check it. It's ok overwrite it if you want.

Isuues
#46
#47

I have some comments related to coding, if you have time please replace them.
Nice to do later
In backend/SearchController:

if we use if statement for logically same checks and return similar result we can use switch case instead, butas if checks only string symbol, it's possible to use regexp with one if statement, please check the # 50 pull request, I commented similar regexp for frontend checking, so you can use it here too, something like this will work for all three conditions:
/^[\u3000-\u303f\u3040-\u309f\u30a0-\u30ff\uff00-\uff9f\u4e00-\u9faf\u3400-\u4dbf]{1}$/

however, if you prefer to report 3 different messages for 3 different inputs, then I wonder why the return sends same 400 code for 3 different messages, why not to add different numbers?

as the message might appear other places or we might want to change it later, better to use const variable which will be written in one place and you can use it every time, otherwise you should grep where is it written and change the message, same logic with code number too, keep it in the constant variable than in return. Also, in the test you use similar messages, why not to have the config which contains the messages? What do you think of this, how to make it more generic?

about static methods, why do you use static instead of object method? Because you just want to connect the classes in a hurry to check your code? If so, it's fine. But later, usually it is said static method is for utility usage not the class/object specific usage, and in here we know it's not the utility.

Must follow from now

write more relative word to what is going to be sent as a response from api, such as host/get/kanjidata like we decided in Friday meeting: https://docs.google.com/document/d/1q9L0y9OQzgb0q9xUPpt3rnvNsbCtOJyu7gly8lK9lgk/edit#
or anything else which has small meaning of what is the response, but not visualize, because visualization will happen in the frontend, also that word has bigger meaning than the graph nodes json is now. This is again more easy to understand later usage and fix
about try catch logic: we should use exception in all cases when we don't expect that behavior to be happen, or we don't know how to handle that situation, but in this case we definitely know there's no kanji, and it's usual common behavior of this project (even we were considering another use case), then why not using if/else instead?
I looked at the tests at the main and SearchController, but still don't get why do we trough an multiple exception for just a wrong symbol? It's crucial for server to have always reporting an EXCEPTION when get request sent some wrong symbol. As far as I know, exception is heavy than if/else. Imagine how easy it will be to take out of order (to force to crash) the server from point of hacking? Server should skip as much as possible unnecessary cases and to proceed only necessary data. But here we not only allow the wrong input to be checked in the if statements but also throw an exception and print everything about that minor thing.
the 27th line is exceeding 80 symbol, usually methods and height to be more readable.
see the reference Maximum Line Length (I sent it on slack chat too last Friday)
print messages should always have some explanatory what is going to be printed, like a "Length of kanji", but if it's for you to track the code development, then don't commit use git add -p, or comment out it, or in bigger teams they use logging (which we don't have now :)))) :(((

Note: Please always consider your written code will be used by other developers too, so write as much as possible generic code, which is easy to debug, to enhance, to fix and find the issues.

I do refactoring at new issue
#5 7


add Java examples to graphs migration page

Companion PR to https://github.com/openmicroscopy/openmicroscopy/pull/3515. Staged at http://www.openmicroscopy.org/site/support/omero5.1-staging/developers/Server/GraphsMigration.html.
--no-rebase

Looks fine to me. I can verify when I start to do the graphs migration in Insight, but after reading this, I think I know how to do it. Good to merge.


add WithExpectFilter ConsoleOpt

In order to add a filter process to remove ANSI escape sequences from my expect statements I need a way to pre-processes the output read into the runeReader.
This patch lets you pass the ptm through any number of io.Reader filters before the runeReader will read a rune to expect on.

I am going a different direction.  It is an easier implementation to add a Filtered ExpectOpt to filter as we match the output.

@coryb By any chance do you still have your easier implementation lying around in a place you can share?

I suspect it might have been something like:
// ansiRemovedSstringMatcher fulfills the Matcher interface to match strings against a given
// bytes.Buffer, with ANSI escape codes stripped.
type ansiRemovedSstringMatcher struct {
	str string
}

func (sm *ansiRemovedSstringMatcher) Match(v interface{}) bool {
	buf, ok := v.(*bytes.Buffer)
	if !ok {
		return false
	}
	if strings.Contains(stripansi.Strip(buf.String()), sm.str) {
		return true
	}
	return false
}

func (sm *ansiRemovedSstringMatcher) Criteria() interface{} {
	return sm.str
}

// ANSIRemovedString returns an expect.ExpectOpt that checks whether the text is included
// in the console buffer after ANSI escape codes have been stripped.
func ANSIRemovedString(strs ...string) expect.ExpectOpt {
	return func(opts *expect.ExpectOpts) error {
		for _, str := range strs {
			opts.Matchers = append(opts.Matchers, &ansiRemovedSstringMatcher{
				str: str,
			})
		}
		return nil
	}
}


Support for Kubernetes v1.23

How to categorize this PR?

/area open-source usability
/kind enhancement
/exp intermediate
/topology garden seed shoot
/merge squash
What this PR does / why we need it:
Support for Kubernetes v1.23
Which issue(s) this PR fixes:
Parts of #5102
Fixes #4823
Special notes for your reviewer:

I didn't vendor new k8s.io/* Golang sources yet as we usually do this together with a new sigs.k8s.io/controller-runtime upgrade.
⚠ This PR only contains the Gardener part for supporting 1.23 - there will/must be follow-up PRs for each extension repository where individual support gets added.
Code changes have been tested with the provider-local

Create/Delete a new shoot cluster with v1.23.1
Upgrade an existing cluster to v1.23.1
Register a v1.23.1 as a seed cluster

Release note:

Gardener can now support shoot and seed clusters with Kubernetes version 1.23. In order to allow creation/update of 1.23 clusters you will have to update the version of your provider extension(s) to a version that supports 1.23 as well. Please consult the respective releases and notes in the provider extension's repository.

Gardener can now support seed and shoot clusters with Kubernetes version 1.23. Extension developers have to prepare individual extensions as well to work with 1.23.

/milestone v1.39

/assign

/assign


Merged recent updates into patch 5.2.5

Pulled in fixes and enhancements from the following to include in a 5.2.5 patch:

state-update-optimization branch
#1096
#1189
#1174

I think we're fine on the author consent question. All of these commits were already in the repo.


fix #608 make each test class loaded by separate class loader

tested on https://github.com/astafev/powermock-testng-demo and real project

Thanks a lot for trying to tackle this problem. I just have a question, won't this severely slow down the test execution??

I don't have big project on testNG to test, but with small project I don't see any difference (tests take about 40 seconds with both versions).
I think it depends on project - in current version we work with manipulated classes in all tests, as I understand, manipulated classes are slower. In new version only needed by particular test case classes are manipulated, other test cases aren't affected.

Hello, our project became bigger a bit, I still don't see difference in time of test run (66148ms with 1.6.4 vs 64448ms with patched). But I had to increase PermGen size in 2 times.
I wanted to ask: do you have some other doubts about the PR? Because I don't see here any new performance problems, except extra PermGen usage.
Found a new problem that this change can fix: if we run in parallel few tests and they use mockStatic, or just static variables, it can cause problems.
Here is a project that reproduces the problem: https://github.com/astafev/testng-methods-order

I don't see a new test in the pull request. You've added the several annotation to isClassAnnotatedWithPowerMockAnnotation but didn't add test to cover it.
If some new feature is being added, like run each class in separate class loader (By the way, I agree that it's sometime is needed), then first of all we need to think about how it could affect other users and do they really need it always. As for me, a develop should has ability to enable/disable this behaviour. Also if theatre is added to TestN module, same should be implemented for jUnit module.
Have you tested how @BeforeClass and @AfterClass works after changes? Especial, in case if some static fields are initialised in these methods?

Hi, I'll split it into 2 pull requests. Found another place where @PrepareEverythingForTest should be added.
About junit - looks, like in junit it's already used.
https://github.com/jayway/powermock/blob/0320072de8626fa984b6c60b895d12ea0e2625bb/modules/module-impl/junit4-rule/src/main/java/org/powermock/modules/junit4/rule/PowerMockClassloaderExecutor.java#L41


rancherctl os list shows v0.1.2, but that version is not in the rancher/os repo

v0.2.1
rancherctl os list shows these available versions:
[rancher@rancher ~]$ sudo rancherctl os list
rancher/os:v0.1.2 remote
rancher/os:v0.2.0-rc1 remote
rancher/os:v0.2.0-rc2 remote
rancher/os:v0.2.0-rc3 remote
rancher/os:v0.2.0 local
rancher/os:v0.2.1 local
rancher/os:v0.3.0-rc1 remote

But when I try to pull rancher/os:v0.1.2, I'm getting an error.
[rancher@rancher ~]$ docker pull rancher/os:v0.1.2
Pulling repository rancher/os
FATA[0012] Tag v0.1.2 not found in repository rancher/os

@cloudnautique  Remove v0.1.2 from list of available versions.

Should be removed @deniseschannon

Confirmed that it's removed. :)


IBM Cloud UI change

IBM Cloud Functions UI had been changed from what has described in README. There's no Manage and Develop under IBM Cloud Functions anymore.  Please update the description.
Explore IBM Cloud Functions
In IBM Cloud, look for Functions in Catalog
There you will see a UI to Manage and Monitor the service. In addition, it has information for Getting Started and even Develop actions.

Thanks @hisunah
Updated with PR #20


Flag to disable downloading subtitles

Added a -u flag (couldn't come up with a better option name) that disables downloading subtitles.

Thanks!
Nice work :+1:


Fix canvas rendering bugs

The text block issue looks like it should be solved on Canvas's side (you shouldn't need to special case it in this kind of way) and I have no idea if the text can be fixed in an easier way (or why it works correctly without canvas in the first place)
Closes #11.

Actually, I just noticed that if you have an item in the item display, then the shadow of the text will be white as well because the formatting of the text overrides the passed color >_>
Gonna have to fix that a different way

And now that I've thought about this some more, I think it's more likely both these issues are actually caused by differences in behavior on Canvas's side. I even find it likely that it comes from the same difference. My guess is that Canvas stores the camera rotation in the modelview matrix and Minecraft stores it in the projection matrix. So for example TextRenderer doesn't expect the modelview matrix to rotate anything and it hasn't been caught so far because nothing actually renders text with shadows in the world. However, I haven't checked if that's actually the case.
@grondag mind taking a look at this/the original issue, maybe you can see what's going on here?


enable sin on METAL in test_dtype_alu

This is still flaky, have seen 2 distinct failures so far for this, eg:
https://github.com/tinygrad/tinygrad/actions/runs/9818240159/job/27110533344#step:8:278


No-response bot isn't closing issues

The new incarnation of the no-response bot is doing the remove-label-on-response part correctly, but is never closing stale bugs that have the label despite the config saying that it should be doing so after 21 days. (At the time of writing, there are bugs that are 30 days stale, and the triagers have reported that they've been having to do manual sweeps regularly because it never works.)
I see recent scheduled jobs for the bot on the Actions tab, which is the run that is supposed to do this step, and it claims to have run successfully, but there's no useful output about what it did (which seems to be nothing).
/cc @godofredoc

This is actually a bug in the action:
This is the query it is executing: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A"waiting+for+customer+response"+sort%3Aupdated-desc+
And it is processing the first 30 bugs from the list only, which are the most recently updated and the oldest ones are never processed.
Seems like the fix is to just use order: updated-asc which will process the bugs with the oldest updates first. This is the line of code to change:
https://github.com/lee-dohm/no-response/blob/1ae4f8bbc8a4607bb904abc1f5f7556ea2ace95b/src/no-response.ts#L136

I sent a PR since the issue hasn't gotten a response. If that doesn't work, we could consider making a flutter-org fork of the action's repo and using that.

Thanks @stuartmorgan

@stuartmorgan did you PR got reviewed?

No; I pinged again a few days ago, but still no response. There's very little activity in the repo, so it's unclear if it will eventually get noticed or not. We should probably move forward with forking.

🎉 It landed upstream!
@godofredoc Can we get the latest version (currently caff5e7de24d19659c31dda1ff2520a3f6a88370) whitelisted and rolled out?

This is great, news. Added the new version to the allow list!

Currently blocked on https://github.com/lee-dohm/no-response/issues/211

@godofredoc Should we close this, or leave it open to track moving off the fork once upstream publishes?

Let's close this one and keep the one with the fork request open.


Slit Edge detection problem

In some special cases the slit detection method fails due to a peculiarity in the data.
Zoom image to the right.

I solved this problem with the following code
    ccd_section = master_flat.data[:, middle:middle + 200]
    ccd_section_median = np.median(ccd_section, axis=1)
    spatial_axis = range(len(ccd_section_median))

    # set values for initial box model definition
    box_max = np.max(ccd_section_median)
    box_center = len(ccd_section_median) / 2.
    box_width = .75 * len(ccd_section_median)

    # box model definition
    box_model = models.Box1D(amplitude=box_max, x_0=box_center, width=box_width)

    box_fitter = fitting.SimplexLSQFitter()

    fitted_box = box_fitter(box_model, spatial_axis, ccd_section_median)

    # the number of pixels that will be removed from the detected slit edge
    offset = 10

    # this defines a preliminary set of slit limit
    l_lim = fitted_box.x_0.value - fitted_box.width.value / 2. + offset

    h_lim = fitted_box.x_0.value + fitted_box.width.value / 2. - offset

    # Here we force the slit limits within the boundaries of the data (image)
    low_lim = int(np.max([0 + offset, l_lim]))

    high_lim = int(np.min([h_lim, len(ccd_section_median) - offset]))

    slit_trim_section = '[:,{:d}:{:d}]'.format(low_lim, high_lim)

There hasn't been any problem with this. and I think the implemented solution is the definitive one.


History Card text overlap

If the smartphone uses big fonts, History Card titles ("Full History" and "You recentely searched") overlap.


How CREAT differs from Transformer

Thank you for your work. I have a question that may seem naive, namely where is your code mainly different from a classic Transformer.

Basically, there are two major differences.

Attention block: CRATE doesn't need separate Q, K, V matrices. We instead use a unified mapping denoted as $U_{[K]} Z$ inside the attention.
Nonlinearity: CRATE uses an ISTA block to do sparsification. The role of ISTA is similar to an MLP in normal transformers.


Unknown provider: amFromUnixFilterProvider <- amFromUnixFilter

Below code produce error
{{listCtrl.createdDate | amFromUnix | amCalendar }}

please help on this.
I have installed angular-moment using bower install angular-moment --save , still i can see the difference in angular-monent.js file
In bower component file amFromUnix this filter does not exists , but on github this filter exists.

Hi, for using amFromUnix you need to install version 1.0.0-beta.2, e.g.
bower install angular-moment#1.0.0-beta.2 --save


Masquerade binding mechanism of ports

Is this a BUG REPORT or FEATURE REQUEST?:
BUG

Uncomment only one, leave it on its own line:
/kind bug
/kind enhancement

What happened:
according to the doc https://github.com/kubevirt/kubevirt/blob/master/docs/devel/networking.md#masquerade-binding-mechanism

There are 2 knobs that impact the configuration of the masquerade binding:

ports: an attribute of the interface, described in the spec::domain::interfaces subtree. Here the user indicates the white-list of ports and protocols. It is important to mention that when the list is omitted, all ports are implicitly included.

in fact, if no ports are specified, the Chain KUBEVIRT_POSTINBOUND  rule is not appended by default, therefore services inside the VM are not accessible from another pod.
Chain KUBEVIRT_POSTINBOUND (1 references)
target     prot opt source               destination

What you expected to happen:
either should add default KUBEVIRT_POSTINBOUND rule when ports spec is omitted or update the doc accordingly.
How to reproduce it (as minimally and precisely as possible):

create VM with masquerade mode and don't specify any ports
run an Nginx server inside the VM and telnet it from another pod e.g. like busybox, the Nginx server is not reachable

Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version): master
Kubernetes version (use kubectl version): 1.18
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

close as this is resolved with a build-in masquerade rule.


docs: Prepared Home, Dev Guide and About sections

Pull Request
Description
Current PR contains the first portion of changes in GH Pages documentation.
MkDocs will be used for converting MD -> HTML static pages.
Structure of the website:

Home: index.md
Getting Started: getting-started.md
User Guide: TBD
Developer Guide:

Developer guide: dev-guide/README.md
Contributing guide: dev-guide/contributing.md
Testing policy: dev-guide/testing_policy.md
Code review requirements: dev-guide/code-review-requirements.md
API reference: dev-guide/api.md
Integration guide: dev-guide/integration.md

About:

License: about/license.md
Releases: about/releases.md

Bold means that pages are included in this pull request.
Home:

Dev Guide:

About

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code cleanup/refactoring
[X] Documentation update
[X] This change requires a documentation update
[ ] CI system update
[ ] Test Coverage update

Testing
Install required dependencies:
$ pip install mkdocs
$ pip install mkdocs-material

Run MkDocs:
$ cd doc
$ mkdocs serve

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.67%. Comparing base (8a15ef5) to head (8c593ed).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #592   +/-   ##
=========================================
  Coverage     93.67%   93.67%
  Complexity      608      608
=========================================
  Files            49       49
  Lines          2104     2104
  Branches        244      244
=========================================
  Hits           1971     1971
  Misses           61       61
  Partials         72       72

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cache should be invalidated when clicking link to /members

If a gig is saved with allow signups changed, clicking the members link in the main navigation bar doesn't show the gig. This is because we are going from /members/gigs/<id>/edit to /members, so the preload function doesn't run again. This should be fixed in an ideal world.

Looks like this was caused by prefetching the members' homepage, so I'm removing the prefetch attribute in the signup summary branch.

Looks like this was caused by prefetching the members' homepage, so I'm removing the prefetch attribute in the signup summary branch.


Login is invalid

I had set docker-compose environment:
- DOCKER_ENABLE_SECURITY:"true"
- SECURITY_ENABLELOGIN:"true"
& set /configs/setting.yml
security:
enableLogin: true # set to 'true' to enable login
csrfDisabled: true
loginAttemptCount: 5 # lock user account after 5 tries
loginResetTimeMinutes : 120 # lock account for 2 hours after x attempts
but when i start up docker,the log shows:
Running Stirling PDF with DOCKER_ENABLE_SECURITY=false and VERSION_TAG=alpha
the app running without login,i read all the issues,it seems no the same question

Login not supported with alpha tag
Must use a versioned tag


Passing seed to compile does not fix output circuit

Informations

Qiskit (Python SDK) version: 0.5.4
Python version: 3.6
Operating system: OSX

What is the current behavior?
Passing a seed to the compiler should result in the same circuit being generated.  Currently this is not the case.  This is what happens in 0.5.4.  I am assuming it happens in 0.6 as well, however #680 blocks me from verifying that.
Steps to reproduce the problem

import qiskit
from qiskit.dagcircuit._dagcircuit import DAGCircuit

q = qiskit.QuantumRegister(16, name='q')
c = qiskit.ClassicalRegister(1, name='c')
qc = qiskit.QuantumCircuit(q, c)
#-----
h_list1 = [k for k in range(16)]
h_list1.pop(4)
for kk in h_list1:
    qc.h(q[kk])
qc.cx(q[3],q[4])
qc.cx(q[5],q[4])
qc.cx(q[13],q[4])
qc.cx(q[2],q[3])
qc.h(q[3])
qc.h(q[14])
qc.cx(q[3],q[14])
qc.h(q[3])
qc.h(q[14])
qc.cx(q[6],q[5])
qc.cx(q[12],q[5])
qc.cx(q[1],q[2])
qc.cx(q[15],q[2])
qc.h(q[6])
qc.h(q[7])
qc.cx(q[6],q[7])
qc.h(q[6])
qc.h(q[7])
qc.cx(q[6],q[7])
qc.h(q[6])
qc.h(q[11])
qc.cx(q[6],q[11])
qc.h(q[6])
qc.h(q[11])
qc.h(q[0])
qc.h(q[1])
qc.cx(q[1],q[0])
qc.h(q[0])
qc.h(q[1])
qc.cx(q[8],q[7])
qc.h(q[7])
qc.h(q[10])
qc.cx(q[7],q[10])
qc.h(q[7])
qc.h(q[10])
qc.cx(q[9],q[8])
for kk in range(16):
    qc.h(q[kk])

qc.measure(q[0],c[0])
#-----

seed = 123
for _ in range(10):
    out = qiskit.compile(qc, 'ibmqx5', seed=seed)
    compiled_qasm = out['circuits'][0]['compiled_circuit_qasm']
    compiled_qc = qiskit.load_qasm_string(compiled_qasm)
    CD = DAGCircuit.fromQuantumCircuit(compiled_qc)
    print('Number of gates:', CD.size())
    print('Circuit depth:', CD.depth())
    print()

What is the expected behavior?
The output circuit should be the same if the seed is fixed.
Suggested solutions

Could it just be a misconception about what the seed parameter for the compile() method represents? In your example:
qiskit.compile(qc, 'ibmqx5', seed=seed)

this seed, per the docstring (and the code), is actually
seed (int): random seed for simulators

And if memory serves it has always been the case since introduced (~0.5?) - could you trace back the point in time where we had a configurable seed for the compilation? The closest seems to be #482, but it seems those changes did not really affect the callers of the  compile_circuit() method, which might have inadvertently rendered the generation non-deterministic. I think there is value indeed in making it deterministic again one way or another, although reusing the current compile(seed) parameter might be slightly problematic depending on how the discussion about the compile() arguments as a whole evolves.

It turns out that it was an issue in 0.5.4 where the seed was not passed to compile_circuit by compile.  Since 0.6 moves to the transpiler, this bug was removed in the process.


T: ?Sized support

We have this:
/// Stores multiple DataSource capable of InstanceTitle, InstanceBaseUrl and
/// RepoListUrl
#[derive(Default)]
pub struct ConfigManager {
    // conceptually the actual objects
    bases: Vec<Arc<RwLock<dyn DataSourceBase + Send + Sync>>>,
    // conceptually just views of the above objects
    titles: Vec<Option<Arc<RwLock<dyn DataSource<InstanceTitle> + Send + Sync>>>>,
    urls: Vec<Option<Arc<RwLock<dyn DataSource<InstanceBaseUrl> + Send + Sync>>>>,
    repolists: Vec<Option<Arc<RwLock<dyn DataSource<RepoListUrl> + Send + Sync>>>>,
    durations: Vec<Duration>,
    // add_source can be called after update.
    valid: usize,
}

It is our understanding that we would be able to do something like this:
/// Stores multiple DataSource capable of InstanceTitle, InstanceBaseUrl and
/// RepoListUrl
#[derive(Default)]
pub struct ConfigManager {
    owner: QCellOwner,
    // conceptually the actual objects
    bases: Vec<Arc<QCell<dyn DataSourceBase + Send + Sync>>>,
    // conceptually just views of the above objects
    titles: Vec<Option<Arc<QCell<dyn DataSource<InstanceTitle> + Send + Sync>>>>,
    urls: Vec<Option<Arc<QCell<dyn DataSource<InstanceBaseUrl> + Send + Sync>>>>,
    repolists: Vec<Option<Arc<QCell<dyn DataSource<RepoListUrl> + Send + Sync>>>>,
    durations: Vec<Duration>,
    // add_source can be called after update.
    valid: usize,
}

And this would be much faster than both RwLock and even hypothetical Arc locking, while still giving us Send+Sync. Is that accurate?

Yes, I think that looks okay so far.  However, you're going to need a &mut  to the ConfigManager in order to get an owner reference that's suitable for obtaining mutable access to the data stored in the cells. If access is going to be from multiple threads, then you'll need some kind of mutex or lock around the ConfigManager. So you're exchanging lots of small locks for one big lock. For your app's access patterns is that going to work out better? If that does work out better, then yes this looks good.
Are you saying you need ?Sized support for this to work? I think this will probably be okay to add. If it isn't, the compiler will complain. I'll look at it soonish.

No, we're saying we're using RwLock as a hack to get Send+Sync.
We actually do have an &mut to ConfigManger where we need it. You should be able to easily add ?Sized support to at least QCell tho.

Yes, it sounds fine. I tried adding ?Sized everywhere to see how it goes, and it does look okay after fixing up a few things. It needs a few tests adding to make sure, though. I can't add ?Sized on the new call, but I think that is okay. The coercion from a sized type to an unsized type will occur in the Arc constructor. (Rc, Arc, etc use CoerceUnsized, but RwLock doesn't, so for construction the coercion should work just the same as for RwLock.)
I'll finish off the change later.

Okay, it's now published as crate version 0.4.2. All cell types now support ?Sized. There are tests with Box<QCell<dyn Trait>> so I think it should work for your purposes. Could you try it, and then I can close this issue?
Also, if it works and if you have a blog, perhaps you'd like to write about it? All the focus seems to be on GhostCell, but actually that's quite hard to use. QCell despite being less advanced in theoretical terms, can still help in a lot of situations, but people don't particularly appreciate that.

It does seem to work pretty nicely! Thanks!
We had enough trouble explaining the use case in this issue as it is, doing so in a blog post is currently beyond our skill level. We'll be sure to keep it in mind tho.

Thanks for the feedback! It would be good to document this pattern somewhere, though -- at least the QCell aspect of it. I don't advertise QCell as a replacement for RwLock. I'll have a think where I can put it.


Add simple tab completion

Does not cycle through matches, simply expands if there is a single match

+1


Add withNamespaces() API to ThriftType

This allows you to construct a new instance with modified namespaces, and also fixes a bug in the merge() logic where it assumed putAll() overwrote existing keys (it actually errors).
Would be great to get this in or pulled in to the work in #73, just putting here for reference in case.

Hi @hzsweers, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

With the proviso that this code will be going away with #73, I'm fine with this PR.  Thanks!

Thanks!


Migrate to androidx

Upgrade Gradle to 6.6.1
Upgrade Android Gradle Plugin to 4.0.1
Upgrade all dependencies
Added Material Components library
Remove old/deprecated dependencies
Extract some strings to values

This has been implemented as a part of the latest release (check out release 1.0.0)
I'm closing this MR.


1480 - Running Sum of 1d array

Description of the Problem
Given an array nums. We define a running sum of an array as runningSum[i] = sum(nums[0]…nums[i]).
Return the running sum of nums.
Example 1:
Input: nums = [1,2,3,4]
Output: [1,3,6,10]
Explanation: Running sum is obtained as follows: [1, 1+2, 1+2+3, 1+2+3+4].
Example 2:
Input: nums = [1,1,1,1,1]
Output: [1,2,3,4,5]
Explanation: Running sum is obtained as follows: [1, 1+1, 1+1+1, 1+1+1+1, 1+1+1+1+1].
Example 3:
Input: nums = [3,1,2,10,1]
Output: [3,4,6,16,17]
Constraints:
1 <= nums.length <= 1000
-10^6 <= nums[i] <= 10^6
Code
class Solution:
    def runningSum(self, nums: List[int]) -> List[int]:

Link To The LeetCode Problem
LeetCode

I would like to be assigned to this issue.


Release v0.9.17

Merged #1952 and mentioned in NEWS. I'm going to make a tag and release after merging this PR.
@matt335672 I know you're constantly updating NEWS on the Wiki. Just to be sure, is there anything we missed before making a new release?

@matt335672 Released. Feel free to merge them.


FormEncode: 1.3.1 -> 2.0.0

Motivation for this change
https://r.ryantm.com/log/2020-10-09.log
Things done
No longer available for Python because pycountry is to new.
ERROR: Could not find a version that satisfies the requirement pycountry<19 (from versions: none)
ERROR: No matching distribution found for pycountry<19

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 100194 run on x86_64-linux 1

7 packages built:

check-esxi-hardware
python37Packages.FormEncode
python37Packages.pywbem
python37Packages.sqlobject
python38Packages.FormEncode
python38Packages.pywbem
python38Packages.sqlobject

Result of nixpkgs-review pr 100194 run on x86_64-darwin 1

7 packages built:

check-esxi-hardware
python37Packages.FormEncode
python37Packages.pywbem
python37Packages.sqlobject
python38Packages.FormEncode
python38Packages.pywbem
python38Packages.sqlobject


Multiple latitude, longitude grids not supported.

I have a tried to read a .grib file that has variables defined on two different latitude on longitude grid. (link to file https://we.tl/t-varf2JJHwN ) This file has sea surface temperatures on a 0.25 degree X 0.25 degree grid and Mean wave period on a 0.5 degree X 0.5 degree grid.
This causes an error in the getone function. I am able to read the file if I simply remove this error using type piracy but this results in some warnings.
Example code
using GRIBDatasets, CairoMakie
import GRIBDatasets: getone, from_grib_date_time # type piracy to test

file_path = "multi_grid_data.grib";

# see issue https://github.com/JuliaGeo/GRIBDatasets.jl/issues/25
from_grib_date_time(date::Int32, time::Int32; epoch) = from_grib_date_time(Int(date), Int(time); epoch= epoch)

# error in getone function
ds = GRIBDataset(file_path);

# change error to warning for testing
function getone(index::FileIndex, key::AbstractString)
    val = GRIBDatasets.getheaders(index)[key]
    if length(val) !== 1
        @warn("Expected 1 value for $key, found $(val)")
    end
    return first(val)
end

# The hack works
ds = GRIBDataset(file_path)

# plot results to illustrate
fig= let
    fig = Figure(size=(1200,600))

    lat2 = 90:-0.25:-90
    lon2 = 0:0.25:359.75
    @assert (length(lon2), length(lat2)) == size(ds["sst"])[1:2]
    ax1 = Axis(fig[1, 1], title = "SST high resolution grid")
    heatmap!(ax1, 0:0.25:359.75, 90:-0.25:-90, ds["sst"][:,:,1])

    lon = ds["lon"][:]
    lat = ds["lat"][:]
    @assert (length(lon), length(lat)) == size(ds["mwp"])[1:2]
    ax2 = Axis(fig[1, 2], title = "MWP low resolution grid")
    heatmap!(ax2, lon, lat, ds["mwp"][:,:,1] )

    fig
end

Proposal
Can we allow there to be multiple lat and lon dimensions so that this case would result in.
Dimensions
   lon = 720
   lat = 361
   lon2 = 1440
   lat2 = 721
   valid_time = 3

Then lon2 and lat2 should be added as variables and the dimension of "sst" should be using the second grid.
 sst   (1440 × 721 × 3)
    Datatype:    Union{Missing, Float64} (Float64)
    Dimensions:  lon2 × lat2 × valid_time

@tcarion
I have made this issue following the discussion on https://github.com/JuliaGeo/GRIBDatasets.jl/pull/26#
I have used windows for the example code so it is definitely possible to read .grib files on windows with this package.

Hi @lupemba,
Thank you very much for this thorough report.
That's surprisingly not a straightforward issue to solve. I tried to open your file with the python cfgrib, and it appears to skip the variable in such case:
>>> import xarray as xr
>>> ds = xr.load_dataset("multi_grid_data.grib", engine="cfgrib")
skipping variable: paramId==34 shortName='sst'
Traceback (most recent call last):
  File "/home/tcarion/miniconda3/lib/python3.9/site-packages/cfgrib/dataset.py", line 660, in build_dataset_components
    dict_merge(variables, coord_vars)
  File "/home/tcarion/miniconda3/lib/python3.9/site-packages/cfgrib/dataset.py", line 591, in dict_merge
    raise DatasetBuildError(
cfgrib.dataset.DatasetBuildError: key present and new value is different: key='latitude' value=Variable(dimensions=('latitude',), data=array([ 90. ,  89.5,  89. ,  88.5,  88. ,  87.5,  87. ,  86.5,  86.

But I think the behaviour you propose is more advisable. I will try to implement it.


Replace print with logger in straxer

Use logging.info  instead of print

Coverage increased (+0.01%) to 93.801% when pulling c3109212e526066c363124ccd846611a063a441f on straxer-printing into 1be065558674cb6404bbfaaf431decc329796865 on master.

superseded by #973


Issue 1 - Stagnant

Dan, I'm opening an issue because this repo looks a little stagnant; I think it's high time you get moving!!!

Also, I wanted to contribute something... We're working together now!!!


update release versions

Preview is available here:http://soroban-docs-pr462.previews.kube001.services.stellar-ops.com/


Request: Linux ARM binaries of libsql-server

Can you please produce aarch64 arm64 binaries of the libsql server? It's increasingly popular to run things on ARM. I notice you already have ARM docker, but I prefer to just use binaries with systemd over Docker.

I would also benefit from this. Currently we use Linux ARM GitHub runners to run our CI/CD pipelines, and we're unable to start sqld in them. We ended up having to work around this by using better-sqlite3 in the CI/CD environment.
Not ideal, given that our development and production environments use @libsql/client.

Should be closed,


js-interop: WebAssembly.instantiate() throws when bundling with dart2js

Hi Dart Team,
As part of my ongoing investigation into Dart->JS interop, I have an example with the WebAssembly API that seems to work when running the output generated with dartdevc.
Sadly I get this exception thrown in the browser after generating a dart2js output:
main.dart.js:133 Uncaught TypeError: a.au is not a function
    at es.$1 (main.dart.js:2829)
    at e1.O (main.dart.js:1975)
    at dW.$0 (main.dart.js:1896)
    at Object.ap (main.dart.js:823)
    at dO.$0 (main.dart.js:1858)
    at Object.h8 (main.dart.js:853)
    at dd.hc (main.dart.js:855)
    at dF.$1 (main.dart.js:1704)
    at hs (main.dart.js:208)
    at MutationObserver.<anonymous> (main.dart.js:217)

And the second error:
Uncaught (in promise) LinkError: WebAssembly.instantiate(): Import #0 module="imports" function="imported_func" error: function import requires a callable

VM/Package details

Dart SDK version: 2.2.0
pkg/js version: 0.6.1+1

Failing code:
https://gist.github.com/graphicbeacon/a2ed9b6e39a7391a893e8fe7dac25fa0

@graphicbeacon thanks for reaching out!
I have a hunch that the issue here might be that you may need to call allowInterop before passing a closure via js-interop.
DDC and dart2js have some discrepancies in how they handle js-interop (for example, https://github.com/dart-lang/sdk/issues/33134). We have a goal to unify them, but for now these differences can be hard to spot.
A very common one is handling of closures: DDC uses regular JavaScript closures and calling conventions that are similar to JavaScript. Dart2js does not, and to interoperate closures need to be wrapped before they are passed to JS.
Let us know if this addresses your issue. If not, try passing -O1 to dart2js to make sure the code is compiled without minification, that will make the output and error message easier to debug.

Hey @sigmundch thanks for responding!
Got it working! The advice you gave really helped.
I had to use allowInterop() to wrap the closures. Disabling minification with -O1 also helped debug another issue where the .$then method was invoked but was not defined. Resolved by creating a js-interop for the Promise API and using that.
I've been able to update my post with the details.
Thanks so much.

Awesome, happy to hear! :)


#218 fix NPE for unclassified entity

Added additional null check as per #218
Looks a simple change. Works in my code. No UT on this module, so would ask whoever merges to just check carefully - thanks :-)
Signed-off-by: Nigel Jones<EMAIL_ADDRESS>

Ok will make changes.
Of note is that { on same line is the default IntelliJ style for auto-code completion/formatting, and is the form I'm seeing most other's code use, so it may be a topic for discussion and documentation of any layout standard.
That being said completely agree that consistency at the innermost level is important so will update the change here.

reformatted and PR updated

It is a common style true - but a proven less readable style.  The reasons for its original introduction no longer apply.  I have not insisted on the more readable layout throughout the project in the dev guide because I know that it is rowing uphill - just that the existing code layout is respected when making changes to existing code.


VS2015 Migration

Fixes #457 and does a bunch of other things:

[x] Update to latest Fody package - cleanup old version
[x] nuget.exe for tests updated as Fody package needs minimum version
[x] AppVeyor integration enabled - use VS2015 image
[x] address missing Microsoft.WebApplication.targets from old version of VS
[x] why isn't the build greeeeeen?

I've added the UI tests to .\run-tests.cmd and they work locally, so I'm going to close this out once the PR is green again...


Connection to database hangs after Error: read ETIMEDOUT

I'm indirectly using this library via loopback-connector-mysql. By default, that library creates a pool with 10 connections, so any time there is a database issue, my expectation would be that once the database was reachable again, any bad connections would be terminated and the pool would be filled with good connections. This is what I've observed so far in my testing with a local database. If I stop the database, I get errors such as:
Error: Connection lost: The server closed the connection.
    at Protocol.end (node_modules/mysql/lib/protocol/Protocol.js:112:13)

Or if I then start up a dummy server that times out connections, e.g.
nc -l 3306

(https://stackoverflow.com/a/37465639/399105)
I get errors such as:
Error: Handshake inactivity timeout
    at Handshake.<anonymous> (node_modules/mysql/lib/protocol/Protocol.js:160:17)

In both cases (and others I tried), after bringing the database back up, the application was able to reconnect to it without any intervention.
However, in a production application we ran into some errors where the application was hung and would not reconnect to the database until the application was restarted:
Error: Cannot enqueue Query after fatal error.
    at Protocol._validateEnqueue (/usr/src/app/node_modules/mysql/lib/protocol/Protocol.js:212:16)
    at Protocol._enqueue (/usr/src/app/node_modules/mysql/lib/protocol/Protocol.js:138:13)
    at PoolConnection.query (/usr/src/app/node_modules/mysql/lib/Connection.js:198:25)
    at runQuery (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:197:16)
    at executeWithConnection (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:239:7)
    at MySQL.executeSQL (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:248:5)
    at /usr/src/app/node_modules/loopback-connector-mysql/node_modules/loopback-connector/lib/sql.js:597:10
    at /usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:259:9
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at MySQL.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:178:5)
    at MySQL.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at MySQL.ObserverMixin.notifyObserversAround (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:228:15)
    at MySQL.SQLConnector.execute (/usr/src/app/node_modules/loopback-connector-mysql/node_modules/loopback-connector/lib/sql.js:596:8)
    at MySQL._modifyOrCreate (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:278:8)
    at MySQL.save.MySQL.updateOrCreate (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:318:8)
    at invokeConnectorMethod (/usr/src/app/node_modules/loopback-datasource-juggler/lib/dao.js:172:21)
    at /usr/src/app/node_modules/loopback-datasource-juggler/lib/dao.js:637:13
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:178:5)
    at Function.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:176:15)
    at Function.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:176:15)
    at Function.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:176:15)
Error: read ETIMEDOUT
    at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
    at TCP.callbackTrampoline (internal/async_hooks.js:126:14)
    --------------------
    at Protocol._enqueue (/usr/src/app/node_modules/mysql/lib/protocol/Protocol.js:144:48)
    at PoolConnection.query (/usr/src/app/node_modules/mysql/lib/Connection.js:198:25)
    at runQuery (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:197:16)
    at executeWithConnection (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:239:7)
    at MySQL.executeSQL (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:248:5)
    at /usr/src/app/node_modules/loopback-connector-mysql/node_modules/loopback-connector/lib/sql.js:597:10
    at /usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:259:9
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at MySQL.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:178:5)
    at MySQL.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at MySQL.ObserverMixin.notifyObserversAround (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:228:15)
    at MySQL.SQLConnector.execute (/usr/src/app/node_modules/loopback-connector-mysql/node_modules/loopback-connector/lib/sql.js:596:8)
    at MySQL._modifyOrCreate (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:278:8)
    at MySQL.save.MySQL.updateOrCreate (/usr/src/app/node_modules/loopback-connector-mysql/lib/mysql.js:318:8)
    at invokeConnectorMethod (/usr/src/app/node_modules/loopback-datasource-juggler/lib/dao.js:172:21)
    at /usr/src/app/node_modules/loopback-datasource-juggler/lib/dao.js:637:13
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at doNotify (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:155:49)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:178:5)
    at Function.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:176:15)
    at Function.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:176:15)
    at Function.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)
    at Function.ObserverMixin._notifyBaseObservers (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:176:15)
    at Function.ObserverMixin.notifyObserversOf (/usr/src/app/node_modules/loopback-datasource-juggler/lib/observer.js:153:8)

(the last error is repeated, I'm guessing for each connection in the pool).
So I have some questions:

What's so special about Error: read ETIMEDOUT at TCP.onStreamRead that prevents the pool from reconnecting to the database?
How can I reproduce this?
What does this mean: Cannot enqueue Query after fatal error.? My first thought was that the fatal error was a fatal error on the connection itself, but that doesn't seem to be the case as I get a fatal error on the connection when I stop the database, but it comes back up just fine as previously described.

Thanks!

Hello, and thank you for opening a new issue for this, so I can fix the error handling under that first ticket.

What's so special about Error: read ETIMEDOUT at TCP.onStreamRead that prevents the pool from reconnecting to the database?

That error is not actually produced from this library, rather it comes from Node.js. It is the representation of a TCP timeout on the system (OS) network stack. When it occurs, the TCP connection is no longer functional. You would need to create a new connection to the database. If you are using the pool, you would do this using .getConnection or use .createConnection if not using the pool.

How can I reproduce this?

Unfortunately I am not sure. It is poasible the Node.js project may know how, but I unfortunately do not.

What does this mean: Cannot enqueue Query after fatal error.? My first thought was that the fatal error was a fatal error on the connection itself, but that doesn't seem to be the case as I get a fatal error on the connection when I stop the database, but it comes back up just fine as previously described.

This means that you have a reference to a specific connection object in your code. That connection then emitted an error that had the .fatal property set to true, but then your code called .query on that same object after the error.
Ideally if you get a fatal error on a connection, you should either call .release on it to destroy it and call .getConnection to get a new one if you are using the pool, or just call .createConnection to create a new connection if not. Always be careful how you structure your logic, as when the TCP connection is lost from the server, ant temp tables, variables, and uncommitted transactions are lost.

Thanks so much for the feedback. I did suspect at one point that loopback-connector-mysql was not properly handling fatal errors, until I realized that when I shut down the database and try to run a query it also returns a fatal error, but works again once I bring the database back up.
I wonder if there isn't something unique about this specific error that causes this behaviour. I guess I'll keep investigating.
I'll go ahead and close this since there's no evidence the bug is in this library and not in loopback-connector-mysql.
Thanks!

So if it helps at all, though I'm not familiar with the library, and it seems more of a helper library, I noticed based on the stack trace that the executeSQL can indeed have this behavior when it is called passed in a transaction object in the options argument. In that case, the library will just run a query on the given connection and delegates the handling of the lifecycle of that connection (including handing fatal errors) to whatever is calling the library.
Both calls above stack trace as coming from the loopback-connector library. Looking there, it is just passing the data and errors back to what calls it without any real logic. Then I see that the loopback-datasource-juggler library is calling that one. I glanced over at the code there and I'm really uncertain what it is doing and how the pieces are connected just looking at the source code, unfortunately.

I wonder if it's some sort of corner case in loopback-connector-mysql that's only triggered in very specific situations, maybe even related to the timing of the error. I would settle for being able to reproduce ETIMEDOUT but I haven't even been able to get that far. Things I've tried:

Shut down the server in between queries
Shut down the server during a query
Use Node.js' net module to create a TCP server and

close the socket with socket.end
socket.destroy()
socket.pause()

Kill the database with docker kill
Set MySQL wait_timeout to a very low value

I've found a similar issue here, in which ECONNRESET seems to be another possible error that causes this: https://stackoverflow.com/q/65463097/399105
The thing that gets me is that almost every post I've seen about this mentions using a pool as the solution, which we're already doing. I guess I'll open a bug with loopback-connector-mysql and see what they say. I'm guessing it won't get very far though since I can't reproduce it.
Thanks for all of your help!

I just noticed something that can't be a coincidence; on both nodes the gap between the error and the previous log was almost exactly 8 hours
2021-08-30T00:02:46.984Z ... 200 OK 4820.96ms
2021-08-30T08:02:49.196Z Error: Cannot enqueue Query after fatal error.
    at Protocol._validateEnqueue (/usr/src/app/node_modules/mysql/lib/protocol/Protocol.js:212:16)

2021-08-30T00:02:01.217Z ... 200 OK 33.48ms
2021-08-30T08:02:48.287Z Error: Cannot enqueue Query after fatal error.
    at Protocol._validateEnqueue (/usr/src/app/node_modules/mysql/lib/protocol/Protocol.js:212:16)

That makes it seem like it's related to MySQL wait_timeout. In my testing I set it to a very short value, but maybe I set it to a value that was too short...


Agents without Output/callback

Description
I'm submitting a Feature Request
For the Router I'm writing, I'm trying to make it as ergonomic as possible. One of the Issues I have, is that in some situations, I construct an Agent that will never have its callback called; I only want to send messages to it. Having to create a bridge using a callback that will never be called could be confusing to someone using the router.
I think this would best be dealt with by creating an analogue to Agent that doesn't have an Output associated type and can have a Bridge analogue constructed without a callback.
This way, messages could be sent from a Component to an Agent-like struct which will send its own message to another Actor, without having to own the Agent. I would like a way to have my_boxed_agent_bridge.send(MyMsg::Variant) effectively instantiate the MyAgent if it doesn't exist yet, and then call a MyAgent::handle(&mut self, MyMsg::Variant), which could then pass the message along.

It should be optional for components using an agent to receive messages from it.  Components which only send messages to an agent but have no reason to receive messages from it shouldn't be required to clutter update, as is currently the case.

We currently have this:

impl<T> Bridged for T where T: Agent {
    fn bridge(callback: Callback<Self::Output>) -> Box<dyn Bridge<Self>> {
        Self::Reach::spawn_or_join(callback)
    }
}

pub trait Discoverer {
    fn spawn_or_join<AGN: Agent>(_callback: Callback<AGN::Output>) -> Box<dyn Bridge<AGN>>{...}
}

pub trait Bridge<AGN: Agent> {
    /// Send a message to an agent.
    fn send(&mut self, msg: AGN::Input);
}

What we wan't to see is:
impl<T> Bridged for T where T: Agent {
    fn bridge(callback: Callback<Self::Output>) -> Box<dyn Bridge<Self>> {
        Self::Reach::spawn_or_join(callback)
    }
    fn bridge_with_no_response() -> Box<dyn Bridge<Self>> {
        Self::Reach::spawn_or_join_without_callback()
    }
}

pub trait Discoverer {
    fn spawn_or_join<AGN: Agent>(_callback: Callback<AGN::Output>) -> Box<dyn Bridge<AGN>>{...}
        fn spawn_or_join_without_callback<AGN: Agent>() -> Box<dyn Bridge<AGN>>{...}
}

The actual implementations of Discoverer end up working with an AgentScope, which is a wrapper around Shared<AgentRunnable<AGN>>.
Lets drill down into the Context Bridge:
It works using a pool of LocalAgents.
When a bridge is created, create_bridge(callback) is called on the local agent. This creates an id so responses can be routed later to the appropriate bridge. Since we won't want that, we can eliminate that in a sister-method.
Ultimately, a ContextBridge is created like so:
        ContextBridge {
            scope: self.scope.clone(),
            id: id.into(),
        }

If this can be changed to be like:
        ContextBridge {
            scope: self.scope.clone(),
            id: Some(id.into()),
        }

With an optional Id, we can have the sister bridge method look like:
    fn create_no_callback_bridge(&self) -> ContextBridge<AGN> {
        ContextBridge {
            scope: self.scope.clone(),
            id: None
        }
}

A bunch of associated code would have to change a little to handle the case where context bridges may not have an Id, but this is the place to start when adding support for agents to have no-callback bridges.

This change doesn't make sense for Job, because without a response, you would just be sending messages into the void. Public looks to be about the same as Context and Global seems to be not really implemented in the first place.

For the Job case, you should probably override the 'without callbacks' bridge fn with a panic explaining that calling it would never make sense.

As @kellytk suggested in the gitter, dispatch() or dispatcher() would be more terse alternatives to the bridge_with_no_response() suggested above.


Layouts Auto Import

Describe the feature
Hello! I just found out that there is no Auto Import in the layouts folder so I thought I would create an Issue.
Additional information

[X] Would you be willing to help implement this feature?
[X] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

What do you mean?

When I have a layout like layouts/custom.vue components from nuxt ui or other librarys/own components arent auto imported

They should be. Could you provide a minimal reproduction?

Edited my original message

Thank you

Would you be able to provide a reproduction? 🙏

Using that link in the previous message by @github-actions would ensure that it's really a clean and reproducible state, but your instructions might just be enough

Reproduction of auto-imports working fine: https://stackblitz.com/edit/github-yq3di6. Would you modify it until the error occurs? 🙏

Okay, modified it. Stackblitz

You need to add <NuxtLayout> in your app.vue if you have a custom app.vue:
<template>
  <div>
    <NuxtLayout>
      <NuxtPage />
    </NuxtLayout>
  </div>
</template>


[$250] Sign in - OpenApp request is sent every login

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.68-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:(https://github.com/Expensify/App/issues/50076)
Issue reported by: Applause - Internal Team
Action Performed:
Precondition: Open the DevTools (3 dots -> More tools -> Developer Tools). Go to Network tab, and throttle to Slow 4G

Sign in with an existing account
Send some messages (just to add items into the queue)
Sign out
Do steps 3 and 4 a couple of times

Expected Result:
Observe that OpenApp request was fired only once in the Network tab
Actual Result:
OpenApp request is sent each time user signs in
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/7d706641-675a-4c2b-aaef-7e62b400c0ea
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021863414839450757624
Upwork Job ID:<PHONE_NUMBER>450757624
Last Price Increase: 2024-12-02

Issue OwnerCurrent Issue Owner: @suneox

Hi! I'm Bartek from Callstack - expert contributor group. I’d like to take a look at this task.

This issue cannot be reproduced on the latest staging version v9.0.72-0. The current network filter in video has Preserve log enabled, ensuring that previous requests are retained. So I think we can retest without Preserve log enabled

@suneox Just checked on dev with Preserve log disabled and the issue is still reproducible.

@suneox Just checked on dev with Preserve log disabled and the issue is still reproducible.

@burczu I’ve just verified on the latest main v9.0.72-1, and this issue cannot be reproduced. Could you please share a recording of the issue?
https://github.com/user-attachments/assets/8bc9a3c2-a396-4528-95a4-d2e961862c5d

Hey @suneox! I'm not sure if understand the issue correctly, but in your video the OpenApp request is called every login, which should not happen, based on the description of the issue. Am I confusing something?

Hey @suneox! I'm not sure if understand the issue correctly, but in your video the OpenApp request is called every login, which should not happen, based on the description of the issue. Am I confusing something?

API OpenApp is included personal data so i think it makes sense to called after sign in. Based on issue #50076 is prevented duplicate request OpenAppbut the test step doesn't match with checklist.
And the QC team has enabled the Preserve Log option during testing, which I believe is the reason behind this issue.
cc: @lanitochka17

This is not a bug.


Add a line in the docs on pmIgnore with opt-in on map creation (#950)

#950

I amended the commit so that i don't pollute git history


The log item of "Batch size per GPU" may not work as expected

🐛 Describe the bug
The call of log function in the sg_trainer is shown as below, https://github.com/Deci-AI/super-gradients/blob/15c0fe1390cc307f0a1a98e576b964f494ad1e83/src/super_gradients/training/sg_trainer/sg_trainer.py#L1385 the log function gets batch size information by using len(inputs). The inputs is expected to be an input tensor with shape B, C, H, W so that the len(inputs) can get the batch size. However, if the inputs is a dict, e.g. like:  {"image": torch.Tensor(B, C, H, W), "other_items": others}, the len(inputs) always outputs the length of the dict no matter what exactly the batch size is.
log_main_training_params(
            multi_gpu=device_config.multi_gpu,
            num_gpus=get_world_size(),
            batch_size=len(inputs),
            batch_accumulate=self.batch_accumulate,
            train_dataset_length=len(self.train_loader.dataset),
            train_dataloader_len=len(self.train_loader),
        )

Versions
NA

Currently the SG is not designed to work with dict (It will probably crash) so the incorrect batch size is a least problem here. When we will be adding dict support, we will address this for sure.
As of now I don't see any actions to be made here. However thanks for bringing this up and future-testing our code ;)


Document using yq to query configuration

Describe the solution you'd like
Small section on the new docs about how to use yq, and a few examples, to pull out data from the .changie.yaml file for use in other scripts.
Describe alternatives you've considered
Writing a config command but that's a bit more work then we need

This might help: workflow where I use yq to parse aqua file. If you give me a scenario on how I'd use with changie let me know and I'd be glad to throw a couple sample ones up here to save you the work :-)


Update .NET Docker repository names

Summary
All .NET Docker image tags have been migrated to new repository names.  These changes replace all instances of mcr.microsoft.com/dotnet/core with mcr.microsoft.com/dotnet.
Fixes #21222

@adegeo - Can you look over my latest updates since your last review?


Documentation : Adding the related tech in readme.md

Is your Documentation related to a problem? Please describe.

The tech stack in the readme.md are only html and CSS.
Describe the solution you'd like

I would like to add JavaScript, Bootstrap and, the related technologies
Prototype Screenshot/Demo Video(Mandatory )

Are you contributing under any open-source program ?

GSSOC'24

@apu52 Please assign this issue to me under GSSoC24

Hi ,
This is a good issue, please start working on this.
Regards
Project Mentor (GSSoC' 24)


Solving the bug with looping the removeDotSegments method in HttpClientTrait

Testing options:
'/a/b',
'a/b',
'a/b/',
'/a/b/',
When updating packages in one of my project, a bug was caught where sentry/sdk v 2.2.0 in the new version uses this package, for this reason, the start of checking the work of the sentry, the completion occurred with a memory overflow.

Thanks for your PR @toxaw
Can you please submit the PR against the https://github.com/symfony/symfony repository, branch 4.4?
Note that I tried your test cases, and they are green already without your patch on removeDotSegments.
We'd need test cases that fail without the patch before merging anything here.


GPU not utilized with standard llama-cpp-python

When using loading the llava models, you can see that BLAS = 0 in the information printed in the console. This is because llama-cpp-python requires a special install if you want GPU capabilities. I'm not sure if this affects linux users or not, but it does affect windows users.
To properly install llama-cpp-python for nvidia GPUs:
pip install --no-cache-dir llama-cpp-python -C cmake.args="-DLLAMA_CUDA=ON" -vv
This of course requires Visual Studio to be installed with the "Desktop development with C++" option selected or the VS C++ Build Tools.
I found the --no-cache-dir necessary in order to get it to actually build it, so I'm not sure how this can be automatically done via the requirements.txt.
Now when using the llava models, you should see BLAS = 1 in the console.

we install it with pre-built wheels, it automatically supports cuda for linux and windows. recently pre-built wheel support added for macOS, i didnt add it to repo yet.


[Citadel] [TPE] Add GetContactsFromLastStepFeature

depends on pull request #59  and pull request #60
Add TPE implementation of GetContactsFromLastStepFeature. It returns contact points generated by the CollisionDetector introduced in pull request #60
Since contacts are associated with collisions in ign-physics but TPE checks contacts on the model level, a workaround is implemented to return the first collision in the canonical link of the model.
The test added caught a bug in EntityManagementFeatures in which incorrect entity names were returned so I had to remove the static variables.

I just rebuilt ign-physics and ign-gazebo in two colcon worksapces and I can't reproduce the unresolved symbol error. I do see the component warning msgs.
Could you try clean the build dir and rebuild to see if the problem still occurs?

I just rebuilt ign-physics and ign-gazebo in two colcon worksapces and I can't reproduce the unresolved symbol error. I do see the component warning msgs.
Could you try clean the build dir and rebuild to see if the problem still occurs?

I did a clean build and the error went away. Thanks for double checking!


Suggestion: Example Repo

From the readme alone I find it hard to get a program that compiles.
Can you provide an example repo?

Hi @FranzSkuffka, thanks for dropping a line.
I'll try to find some time in the next week or two to add an examples directory with at least one solid example.
Do you have any specific questions? Or suggestions for improving the readme?

Feel free to email me in the meantime, (see my GitHub profile,) I'd be glad to work through some code with you.

Hey Paul - thank you for the prompt reply. I think I had issues importing the module. THe import statements were missing completely from the elm code example.

I just came across the API reference and I'll try to go from there. I did not see that. Sorry.

FYI Comments are not allowed in JSON.

ERROR in ./src/elm/Main.elm
Module build failed: Error: Compiler process exited with error Compilation failed
I cannot find module 'Ports.LocalStorage'.

Module 'Main' is trying to import it.

    "source-directories": [
        "src/elm",
        "../../node_modules/elm-local-storage-ports/lib/elm",
        "./"
    ],

Okey, I got it working. The problem was with elm not resolving the src dir for some reason. However I saw that this lib does not support listening to the onstorage event which I need.

@FranzSkuffka Thanks for all the feedback. Was there something inaccurate/misleading in the docs regarding the source directory? Let me know so I can fix. 🙂

So I'm grouping this and #3 as identical feature requests. Let me see if I can whip something up.

Here's something to look at @FranzSkuffka : https://github.com/paulstatezny/example-elm-local-storage-ports-app
I'll plan to add an examples folder in this repo in the future though.


errors while including JRE.framework

HEADER_SEARCH_PATHS asks for framework that doesn't exist: HEADER_SEARCH_PATHS = "${J2OBJC_HOME}/frameworks/JRE.framework/Headers"
which I managed to fix as HEADER_SEARCH_PATHS = "${J2OBJC_HOME}/include"
but still there is framework needed: FRAMEWORK_SEARCH_PATHS = "${J2OBJC_HOME}/frameworks";

Either build the j2objc base with "make frameworks", or use the latest j2objc release:
$ unzip -l /Users/tball/Downloads/j2objc-1.0.1.zip |grep frameworks/JRE.framework/Headers
       24  02-09-16 10:04   j2objc-1.0.1/frameworks/JRE.framework/Headers

Once you have the frameworks and the framework search path set, there's no need to change the HEADER_SEARCH_PATHS.

Great, thanks. The reason of this my confusion was doc in here: http://j2objc.org/docs/Building-J2ObjC.html
Is it valid to use somehow j2objc without building frameworks? If not, maybe it can be added in this doc to help confused people, who are new to approach? I would appreciate it.
Thanks for assistance!

I just updated the build doc -- thanks for letting us know it was out of date.


Endpoint for EIP-4881 Deposit Contract Snapshot

Adds the endpoint for downloading the EIP-4881 Deposit Tree Snapshot during weak subjectivity sync.

resolved conflicts. Let me know if you're interested in continuing discussion or happy to merge @arnetheduck


Regular Expression Denial of Service

normalize-url package before 4.5.1, 5.x before 5.3.1, and 6.x before 6.0.1 has a ReDoS (regular expression denial of service) issue because it has exponential performance for data: URLs.

Facing the same issue. High risk vulnerabilities

Facing the same issue.

Can this be cosed in favor of: https://github.com/facebook/create-react-app/issues/11012 ?

These warnings are false positives. There are no actual vulnerabilities affecting your app here.
To fix npm audit warnings, move react-scripts from dependencies to devDependencies in your package.json.
That will remove the false positive warnings.
I agree with the point in https://github.com/facebook/create-react-app/issues/11102 and will make this change so that new projects don't keep having these false positive warnings.
If you want to discuss this, please comment in https://github.com/facebook/create-react-app/issues/11102.

Please see https://github.com/facebook/create-react-app/issues/11174.


Not able to disable conan install method

In readme, seems minor typo.

replace cmake .. -DCMAKE_BUILD_TYPE=Release by cmake .. -DCMAKE_BUILD_TYPE=Release -DCONAN_false to not use Conan. Hope your the dependencies are found on your Linux.

which can be

replace cmake .. -DCMAKE_BUILD_TYPE=Release by cmake .. -DCMAKE_BUILD_TYPE=Release -DCONAN=false to not use Conan. Hope your the dependencies are found on your Linux.

Even though correcting that, cmake toolchain try to find conan so it's trying to install this library through conan.. so seems like disabling conan not working as expected.
While digging through root level CMakeLists.txt file, below can be found so probably that needs to be taken under CONAN macro which worked fine for me. Also didn't understand use case of empty CONAN_EXPORTED.
if (CONAN_EXPORTED)
else()
    if (NOT EXISTS ${CMAKE_BINARY_DIR}/conan_toolchain.cmake)
        include(${PROJECT_SOURCE_DIR}/cmake/conan.cmake)

        conan_cmake_autodetect(settings)

        conan_cmake_install(PATH_OR_REFERENCE ${PROJECT_SOURCE_DIR}/conanfile.py
                PROFILE ${CONAN_PROFILE}
                PROFILE_BUILD ${CONAN_PROFILE}
                BUILD missing
                SETTINGS ${settings}
                )
    endif()
endif()

include(${CMAKE_BINARY_DIR}/conan_toolchain.cmake)

which can be
if (CONAN)
    if (NOT EXISTS ${CMAKE_BINARY_DIR}/conan_toolchain.cmake)
        include(${PROJECT_SOURCE_DIR}/cmake/conan.cmake)

        conan_cmake_autodetect(settings)

        conan_cmake_install(PATH_OR_REFERENCE ${PROJECT_SOURCE_DIR}/conanfile.py
                PROFILE ${CONAN_PROFILE}
                PROFILE_BUILD ${CONAN_PROFILE}
                BUILD missing
                SETTINGS ${settings}
                )
    else()
        include(${CMAKE_BINARY_DIR}/conan_toolchain.cmake)
    endif()
endif()

Hi,
Thanks I will fix this part when conan is not used.

Done.
You can try the lastest commits, should work without Conan.

Thank you, @dfleury2.


It keeps crashing!!!

It crashed and went into safe mode, but EVERY time I turn it back, it crashes again! Im on wifi, I waited till the next day, I even reinstalled it butnit still keeps crashing.

Same with me. This is so annoying, everytime open BL pro it keeps be like that, but normal BL is still good.Hope youll fix this soon.
P/s:My BL Pro and normal BL is on version 1.12.7


Apply to be a trigger in the classifier

Nomination
GitHub User
My name is James Roy, and my GitHub username is as you see. I hope to become a trigger for zephyr, assisting maintainers with tasks such as labeling issues and merging branches. Currently, I am active in the CPython project, where my main development focus is on free-threading and the C-API. If the project plans to release Python API compatibility in the future, I believe I can be of great help.
My recent plan is to continue developing a minimal libc for zephyr. These contributions are not currently listed because I am still working on the patches. While my contributions may not be very prominent at the moment, I am confident that I will do better in the future.
Supporting Documents
https://github.com/zephyrproject-rtos/zephyr/pull/80511
https://github.com/zephyrproject-rtos/zephyr/pull/80450
https://github.com/zephyrproject-rtos/zephyr/pull/80467
https://github.com/zephyrproject-rtos/zephyr/pull/80104
https://github.com/zephyrproject-rtos/zephyr/pull/80267

There is no such role as "Trigger." Please take a look at https://docs.zephyrproject.org/latest/project/project_roles.html.

Emm It seems that his name is Triage


OCPBUGS-1736: use proxy vars when available

When set, the proxy variables will be now used by the controller to
reach OpenStack through the proxy and not directly.
Bug OCPBUGS-1736

/jira refresh

/jira refresh

/cc @dulek

/cc @andreaskaris
From my side this looks good, waiting for confirmation from Emilien that testing job passes.

/hold
this is not working: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-launch-openstack/1574764179829559296/artifacts/launch/gather-extra/artifacts/pods/openshift-cloud-network-config-controller_cloud-network-config-controller-55fc9957-xbsjf_controller.log
W0927 18:17:24.943011       1 client_config.go:617] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0927 18:17:24.943823       1 leaderelection.go:248] attempting to acquire leader lease openshift-cloud-network-config-controller/cloud-network-config-controller-lock...
I0927 18:17:24.983360       1 leaderelection.go:258] successfully acquired lease openshift-cloud-network-config-controller/cloud-network-config-controller-lock
I0927 18:17:24.984209       1 openstack.go:121] Custom CA bundle found at location '/kube-cloud-config/ca-bundle.pem' - reading certificate information
F0927 18:17:28.107164       1 main.go:101] Error building cloud provider client, err: Get "https://<IP_ADDRESS>:13000/": dial tcp <IP_ADDRESS>:13000: connect: no route to host
goroutine 13 [running]:
k8s.io/klog/v2.stacks(0x1)
	/go/src/github.com/openshift/cloud-network-config-controller/vendor/k8s.io/klog/v2/klog.go:860 +0x8a
k8s.io/klog/v2.(*loggingT).output(0x37696c0, 0x3, 0x0, 0xc000302000, 0x1, {0x2cbcbd8?, 0x1?}, 0xc000100400?, 0x0)
	/go/src/github.com/openshift/cloud-network-config-controller/vendor/k8s.io/klog/v2/klog.go:825 +0x686
k8s.io/klog/v2.(*loggingT).printfDepth(0x37696c0, 0x237798a?, 0x0, {0x0, 0x0}, 0x7ffe81e0ca74?, {0x23a20d0, 0x2d}, {0xc0001a04a0, 0x1, ...})
	/go/src/github.com/openshift/cloud-network-config-controller/vendor/k8s.io/klog/v2/klog.go:630 +0x1f2
k8s.io/klog/v2.(*loggingT).printf(...)
	/go/src/github.com/openshift/cloud-network-config-controller/vendor/k8s.io/klog/v2/klog.go:612
k8s.io/klog/v2.Fatalf(...)
	/go/src/github.com/openshift/cloud-network-config-controller/vendor/k8s.io/klog/v2/klog.go:1516
main.main.func1({0x26e5638, 0xc0000a4780})
	/go/src/github.com/openshift/cloud-network-config-controller/cmd/cloud-network-config-controller/main.go:101 +0x26d
created by k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run
	/go/src/github.com/openshift/cloud-network-config-controller/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:211 +0x11b

How is CNCC deployed? I wonder if you don't need to add the config.openshift.io/inject-proxy annotation somewhere.

CNCC is deployed by CNO, this is very likely a bug in CNO since it only add the proxy env in hypershift: https://github.com/openshift/cluster-network-operator/blob/master/pkg/platform/platform.go#L40
Once CNO adds the proxy variables they should be used without any additional changes to CNCC.
cc: @zshi-redhat

LGTM.
I tested it locally and only the CNCC fix wouldn't be enough as when using self signed certificates we have a custom transport being build and we need to specify Proxy. When not using a custom transport the env vars are read by default.

/retest

This now needs an approval, as the bot suggests:
/assign @kyrtapz

/lgtm


An apparent change in ImageProcessor.Web 4.6.6 has broken the ability to alter the URL in a module before image processing.

We use and HTTP Module that reads the query string and then sets certain defaults and changes the width based on screen resolution and breakpoints.
this worked fine in ImageProcessor.web 4.6.4 but does not work in 4.6.6
I'm not seeing an easy way to determine what all changed between these two versions (no changelog?)
Here's the beginning and ending of our HTTP Module so you can see how we are  doing it.
public void OnBeginRequest(object sender, EventArgs e)
{
	var context = ((HttpApplication)sender).Context;
	if (context.Request.RawUrl.ToLower().Contains("uploadedimages"))
	{
		string rawPath = context.Request.RawUrl;

		// Get the query string and set it to writable so we can change it later.
		NameValueCollection queryString = context.Request.QueryString;
		var readonlyProperty = queryString.GetType().GetProperty("IsReadOnly", BindingFlags.Instance | BindingFlags.NonPublic);
		readonlyProperty.SetValue(queryString, false, null);

                // Do work here, modify query string, etc, removed for brevity.

		// Set the changed query string back to the context.
		// path should end up bing the path to the image /sample.png
		var path = this.GetVirtualPath(context);

		// If there is no path or the path does not have an extension with a . then just return.
		if (string.IsNullOrWhiteSpace(path) || !path.Contains("."))
		{
			return;
		}

		context.RewritePath(path, string.Empty, queryString.ToString());
		readonlyProperty.SetValue(queryString, true, null);
	}
}

Yeah see #503 I need to do some work to reenable this kind of functionality. I had to switch to using the Request.RawUrl to handle some bizarre encoding issues that occur when people share urls on Facebook (Request.Url is corrupted and unusable,  See #478)
Creating something that defaults to Request.RawUrl that can be overwritten, or maybe just making it a configurable setting would both be possible solutions.

See #503 for a workaround.


Added patterns of the tenant url value

Added patterns of the tenant url value, this info does not exist explicitly in either MicrosoftDocs or GitHub docs

Learn Build status updates of commit 5834823:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/active-directory/saas-apps/github-enterprise-managed-user-oidc-provisioning-tutorial.md
:warning:Warning

Details

articles/active-directory/saas-apps/github-enterprise-managed-user-oidc-provisioning-tutorial.md

Line 115, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@twimmers,
Can you review the proposed changes? Note: Perhaps the enterprise account name should be changed to reflect a Microsoft-approved fictional company name?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

Due to the upcoming Ignite conference, all merging and publishing is on hold until the morning of October 12.
This PR is ready for merge on 10/12.
This repo is in lockdown for content freeze. If you need to make additional changes to these files, please submit your changes a new PR.
#label:"event-triaged-to-10AM"

Learn Build status updates of commit ecf6c6f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/saas-apps/github-enterprise-managed-user-oidc-provisioning-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Update mock.js

Fixed the mock response bug.

Summary

Test Plan

What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅❌

Android
✅❌

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Good catch, thanks


Canon Print Driver recipes are broken

Canon's changed their site again....  Which has broken my Canon Print Driver recipes again....
After some preliminary scratch work, I believe I've come up with a fix that I'm hoping will fix the issue and prevent further issues (hopefully).

Should be resolved in b4c071e.


download: HackerRank official feature

Download sample test cases ってlinkあるじゃん
気付いてなかったのか後から生えたのか

URLs are something like https://www.hackerrank.com/rest/contests/projecteuler/challenges/euler200/download_testcases .
During a contest it's Download sample test cases, but after ending it becomes Download all test cases.
Logging in is not required.
{"error":"Sorry! testcases are not available for download"} is returned for some problems. e.g. https://www.hackerrank.com/rest/contests/hourrank-1/challenges/beautiful-array/download_testcases


No more valid discord link

No more discussion

https://github.com/arne182/opeMpilot

Now I am not in trademark infringement. Thanks for letting me know. Hope other forks know about this


FormsPlot: Flickering while dragging

Now that Application.DoEvents() is no longer being called (#1906, #1913, #1919) I am noticing flickering while dragging in the WinForms control. This example is a signal plot with about 20k points. Flickering does not correspond with garbage collection.

I'll try to fix this within the next few days, but @AbeniMatteo if you have any suggestions let me know! I may try to solve this by drawing directly on the control (not a PictureBox) and manually implementing double buffering.

Check this comment.
Flickering was present before removing .DoEvents() but not after.
Are you testing with 4.1.51 or 4.1.51b?

@AbeniMatteo thanks for pointing that out! I confirmed that was the problem. I didn't push a NuGet package after that change, and calling pictureBox1.Invalidate() when the bitmap changes is what was producing the flickering. I'll issue a new release tonight.
On the up side I have some code that flickers a lot and may be useful to test against in the future:
double[] data = ScottPlot.DataGen.Sin(10_000, 3);

for (int i = 0; i < 10; i++)
{
    var sig = formsPlot1.Plot.AddSignal(data);
    sig.OffsetY = i * .1;
}

formsPlot1.Refresh();


Dimensions in vec.npy

Hi, I was running the BiLSTM baselines as described in the README file, and I got an error:
Traceback (most recent call last):
File "train.py", line 36, in
con.load_test_data()
File "/kevin.huang/DocRED/code/config/Config.py", line 158, in load_test_data
self.data_word_vec = np.load(os.path.join(self.data_path, 'vec.npy'))
File "/kevin.huang/anaconda3/lib/python3.6/site-packages/numpy/lib/npyio.py", line 440, in load
pickle_kwargs=pickle_kwargs)
File "/kevin.huang/anaconda3/lib/python3.6/site-packages/numpy/lib/format.py", line 734, in read_array
array.shape = shape
ValueError: cannot reshape array of size 3014533 into shape (194784,100)
Is the vec.npy file provided correct?

Metadata downloaded from may be ruined, you can try the google drive link


Support Reviewer Payments on My Rewards

Reviewer payments will be atomic, this means they receive a single payment for each review activity and receive it at time of action.
Reviewers do NOT need to claim payments.
Reviewers DO still need to redeem cross chain payments.

Reviewers will want to see a history of payments, even if they do not have to claim them.
As a Reviewer, I want to see a history of my payments, so that I know how much I earned.
idea / question : should we show each payment, or group them by challenge?

Reviewers will need to be able to redeem cross chain payments and will be subjected to the same 28 day period as Analysts.
As a Reviewer, I want to know what needs to be redeemed, so that I ensure I am paid for my work.
idea / question : reviewers will need to "Redeem" for each payment. This means that if they performed 50 reviews that are paid cross chain, they need to sign 50 "Redeem" transactions...
How do we present this to them? How can we reduce friction with the understanding that there will be multiple txs.

replaced with #794


Random color

Thanks for this plug-in! Use it all the time!
There is one thing I would like to have though: if word is already highlighted, applying addHighlight again changes color to the next one. Ideally to a random color, not predefined. In this case I would press addHighlight few times to get a color I like.
Thanks!

Thanks for the suggestion.  This seems beyond the intention of this plugin.  I am also considering changing the addHighlight to a toggleHighlight, which would give an easier way to remove a highlight, and this operation would be in conflict.


proxy.process.net.connections_currently_open drifting from reality in ATS 9.0.x

After running ATS 9 in our production environment for a few hours, the value of proxy.process.net.connections_currently_open did not match the number of established connections reported by "ss -s".  At one point the value was almost a factor of two off.
This is a problem because that setting is used to control the max connection throttling.  If the value stays too high, the process can get stuck in the throttled state.

Just checked one of our production boxes and the value of proxy.process.net.connections_currently_open seems consistent with the ss -s output.


replace some hard coded inline values with declared constants

These constants shouldn't be a part of template.


Fix link to M365 Developer Platform

Update the 'Request features' link on the Office Add-ins landing page to point to M365 Developer Platform.

Docs Build status updates of commit 02ad962:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/index.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update const.py

add german shipping confirmation mail
Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[ ] Adds a new shipper
[ ] Update existing shipper

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:

Wrong branch, please use the dev branch.


Export using UMD

Use Webpack to build and export for all environments using the UMD pattern

Added in b55277a7a8352aa4a3fa7903979ee966b6abf0e9


feat!: input validation

Closes #202 and closes #248

I think it would be better if you could change the TS project settings of your IDE and it would not be necessary to add the control comments in the committed file.

Well, then can I remove the .vscode folder? 🤪


update global.adoc

I think there's a small typo in "local" transformation

Thanks @jagedn I've included your commit through a cherry-pick in version 0.2.3. I wanted to create a version an merge it right away, so I thought that way was quicker.


Modify decimal regex to accept positive exponent specifier

Which issue does this PR close?

Closes https://github.com/apache/arrow-rs/issues/5648
Rationale for this change
If users have float data in scientific format with a positive exponent specifier (e.g "3.106e+04"), the current csv inference mechanism does not work correctly. This change fixes that.

What changes are included in this PR?

Are there any user-facing changes?
This causes a change in schema inference behavior -- it's possible that some user relies on the fact that the current behavior is incorrect. I'm not sure what arrow's policy is around visible changes like this, so if this is change is not allowable I understand.

Could we get a test or two for this please

Sure -- will add a couple of tests

@tustvold I've added a test asserting correctness of the result of inferring a schema on float data that includes scientific notation data. (with both positive and negative exponents)
I modeled it on adjacent tests so I don't think the test itself is likely to be controversial, but this is my first-time committing to this repository so please do let me know if there's anything else you'd like to see on this.

Thank you, looks good to me


Unable to fetch location when app is in background

Unable to fetch location when app is in background

You don't give us a lot to work with, please provide more details:

On which platform do you experience the problem?
Which version of the geolocator do you use (background support is only available from version 8.2.0)?
Include the output of flutter doctor -v

You don't give us a lot to work with, please provide more details:

What is the problem you are trying to solve? The geolocator plugin (when configured correctly) will keep the location service alive in the background but won't call any Dart code). Locations are sent to Dart when the App moves back into the foreground.
On which platform do you experience the problem?
Which version of the geolocator do you use (background support is only available from version 8.2.0)?
Include the output of flutter doctor -v

I am looking for continues user location position update while app is in background; but It is not working like so.
When app is in foreground and switch into background for first time it does return location.
I have update package to 8.2.0 but not working for continues background update.


(Feature) #1386 User should have statistics in settings menu

Description
Added new menu item to sidebar names statistics, a new icon to the gooddollar font, a new environment variable, statistics iframe component.
New Environment Variable:
REACT_APP_DASHBOARD_URL

The URL to the Dashboard
Required

About #1386
How Has This Been Tested?
Go to dashboard
Open Sidebar - see the new statistics menu item
Click on it - you should see the dashboard on screen.
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request ( for frontend tasks)
[x] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

Video: https://drive.google.com/file/d/1_t5S06JSVEctJ2zBdLQ6VZoFEiQrSZ70/view

@LiavGut @sirpy
The link provided in the task (https://dashboard.gooddollar.org) link is not available. So I used this (https://gooddashboard.herokuapp.com/admin/dashboard) for a test.

@yaroslav-fedyshyn-nordwhale What should I review? :)

@yaroslav-fedyshyn-nordwhale What should I review? :)

I attached the link to the video with changes in PR description. See if it's looking good.


editor.formatOnSaveMode: modifications reformats whole file if project is not under source control

Does this issue occur when all extensions are disabled?: Yes
VS Code Version: 1.59.1
OS Version: Debian 10
Steps to Reproduce

Set editor.formatOnSave: true and editor.formatOnSaveMode: modifications
Use a language server / extension that supports range formatting (for example, clangd for C++)
Open a project that does not use source control
Make a change to a file and save

Expected results
The file is not reformatted.
Note the description of the formatOnSaveMode options is as follows:
 // Controls if format on save formats the whole file or only modifications. Only applies when `editor.formatOnSave` is enabled.
 //  - file: Format the whole file.
 //  - modifications: Format modifications (requires source control).
 //  - modificationsIfAvailable: Will attempt to format modifications only (requires source control). If source control can't be used, then the whole file will be formatted.
 "editor.formatOnSaveMode": "file",

This suggests that if there is no source control, modifications will not reformat anything (whereas modificationsIfAvailable will reformat the whole file).
Actual results
The whole file is reformatted.
Analysis
This appears to be a regression from https://github.com/microsoft/vscode/pull/127849, which introduced the modificationsIfAvailable option. The relevant code treats modifications and modificationsIfAvailable exactly the same.
cc @kilbouri

/verified


[Usability][Feature][Tooling] PKC: Setup, Stop, Start, Backup, Restore

Allow for single point interface to run all critical actions to manage PKC
Commandline:
pkc [option] [flags]

setup [--wallet-address]
Description: setup will install the PKC with the wallet address specified
stop
Description: will gracefully stop the docker containers to e.g. safe energy
start
Description: will gracefully resume the docker containers
backup [setup]
Description: Run the backup command manually, setup exposes the configuration options e.g. how often to run the backup
restore
Description: Will fully restore the backup and !!! WARNING !!! disregard all current content in the PKC.

Fixed in 32fff7e804f2c07b3e7c26bc69955db79c3a2a87 and before.