MAINT: ckdtree codebase clean up

refactor two distance headers to distance.h and distance_box.h
move the side_distance calculation into distance.h
clean up nodeinfo
better support of 0 in boxsize (disabling the boundary) added test case.
bigger tests for query_ball_point and query_knn

The main remaining issue is that query_knn uses a queue but the rest uses recursion. Maybe they shall all be converted to queues.
The code has no major noticeable slowdowns, though

it is strange that p=1 is slower than p=2 or p=inf (has been so in master).
the periodic case is slightly slower by about 5%. I am stuck here.  boxsize=0 case has the same speed. So the difference is due to BoxDist1D::side_distance_from_min_max. But  the code is essentially the same code written in a shorter form.

Here is the benchmark; the before commit contains only bug fixes on zero boxsizes (some are from @jmbr 's branch)
· Running 2 total benchmarks (2 commits * 1 environments * 1 benchmarks)
[  0.00%] · For scipy commit hash fbdce9e4:
[  0.00%] ·· Building for py2.7-Cython0.23.4-Tempita0.5.2-numpy1.8.2-six.................................................................................................................................
[  0.00%] ·· Benchmarking py2.7-Cython0.23.4-Tempita0.5.2-numpy1.8.2-six
[ 50.00%] ··· Running spatial.Query.time_query                                                                                ok
[ 50.00%] ····
               =================== ===== ========== ============ ========== =========== ========== ===========
               --                                                  boxsize / leafsize
               ------------------------- ---------------------------------------------------------------------
                    (m, n, r)        p    None / 8   None / 128   0.0 / 8    0.0 / 128   1.0 / 8    1.0 / 128
               =================== ===== ========== ============ ========== =========== ========== ===========
                 (3, 10000, 1000)    1     1.55ms      2.85ms      1.78ms      3.16ms     2.00ms      3.45ms
                 (3, 10000, 1000)    2     1.09ms      1.52ms      1.51ms      2.81ms     1.55ms      2.41ms
                 (3, 10000, 1000)   inf    1.19ms      2.22ms      1.33ms      2.46ms     1.47ms      2.58ms
                 (8, 10000, 1000)    1    48.97ms     59.93ms     53.97ms     66.85ms    194.59ms    196.23ms
                 (8, 10000, 1000)    2    10.76ms     11.28ms     18.48ms     24.49ms    71.61ms     81.75ms
                 (8, 10000, 1000)   inf    7.28ms     10.32ms      8.19ms     11.37ms    30.08ms     38.16ms
                (16, 10000, 1000)    1    745.01ms    360.08ms    808.40ms    417.07ms    1.14s      663.14ms
                (16, 10000, 1000)    2    310.69ms    127.32ms    446.25ms    265.73ms   781.30ms    326.83ms
                (16, 10000, 1000)   inf   63.15ms     58.91ms     69.39ms     64.95ms    550.38ms    243.10ms
               =================== ===== ========== ============ ========== =========== ========== ===========

[ 50.00%] · For scipy commit hash 36e03290:
[ 50.00%] ·· Building for py2.7-Cython0.23.4-Tempita0.5.2-numpy1.8.2-six.....................................................................................................................................
[ 50.00%] ·· Benchmarking py2.7-Cython0.23.4-Tempita0.5.2-numpy1.8.2-six
[100.00%] ··· Running spatial.Query.time_query                                                                                ok
[100.00%] ····
               =================== ===== ========== ============ ========== =========== ========== ===========
               --                                                  boxsize / leafsize
               ------------------------- ---------------------------------------------------------------------
                    (m, n, r)        p    None / 8   None / 128   0.0 / 8    0.0 / 128   1.0 / 8    1.0 / 128
               =================== ===== ========== ============ ========== =========== ========== ===========
                 (3, 10000, 1000)    1     1.61ms      2.83ms      1.79ms      3.17ms     2.00ms      3.40ms
                 (3, 10000, 1000)    2     1.09ms      1.54ms      1.54ms      2.72ms     1.57ms      2.31ms
                 (3, 10000, 1000)   inf    1.24ms      2.27ms      1.36ms      2.46ms     1.49ms      2.60ms
                 (8, 10000, 1000)    1    49.61ms     59.60ms     55.11ms     67.15ms    191.33ms    186.09ms
                 (8, 10000, 1000)    2    10.68ms     11.09ms     18.48ms     23.90ms    70.76ms     77.38ms
                 (8, 10000, 1000)   inf    7.32ms     10.44ms      8.12ms     11.32ms    30.03ms     36.56ms
                (16, 10000, 1000)    1    739.27ms    360.11ms    813.93ms    419.03ms    1.11s      632.60ms
                (16, 10000, 1000)    2    308.90ms    123.74ms    448.28ms    263.50ms   776.20ms    321.78ms
                (16, 10000, 1000)   inf   64.40ms     58.74ms     69.27ms     64.03ms    540.12ms    228.59ms
               =================== ===== ========== ============ ========== =========== ========== ===========

BENCHMARK                                    BEFORE      AFTER     FACTOR
...ery((16, 10000, 1000), inf, 1.0, 128)   228.59ms   243.10ms   1.06346950x
..._query((8, 10000, 1000), 2, 1.0, 128)    77.38ms    81.75ms   1.05642608x

I wonder if the increased performance of p=2 is due to ignoring the upperbound. I think we should try to hoist all the
if (r>upperbound)
    return r;

out of the inner loop and see what happens. It might be that all these excessive conditional checks just slows things down. Maybe it makes sense for the general Minkowski distance as std::pow is slow, but probably not for the special cases.

Also for query_knnwe should get rid of the excessive run-time checks for p. This has been long due for clean-up. We can just add some static const members to the MinMaxDist template classes and branch on those instead of the run-time value of p.

It appears those early termination would help when the dimension is huge and when the nodes are very an-isotropic (is it the right word to use?). In that case the loop terminates sooner.

I've squashed most of the ifs in query_knn. The remaining is one for converting the output (one per query) and converting eps. They look sufficiently innocent in terms of efficiency -- maybe we'd merge some of those to distance.h as well, for the sake of clarity?

Good, you have squashed the important ifs from query_knn. The remaining ones are innocent, so I suggest we just leave them :)
As for the early termination: For common use cases such as 2 to 4 dimensions (e.g. computer graphics), early termination is not needed. If we manually unroll the loop it is possible to do the early termination check for e.g. every 4th dimension, and thus never for the common low-dimensional cases. This would possibly be faster even for high-dimensional data.

Actually I changed my mind on the early termination check. It prevents (auto)vectorization of the distance computation because more than one register is needed for the summation. Thus there will be no running sum during the computation, but an early termination check requires it. Using an early termination check will therefore prevent the compiler from autovectorizing with SIMD instructions.

I can't quite tell if @sturlamolden's comments on the early termination check require changes to this PR or a next one. Other than that this looks ready to go - just let me know when to hit the green button.

@rgommers It does not have to be in this PR.

In it goes then! Thanks @rainwoodman, @sturlamolden

Thanks for merging.
do we still want to port spatial's distance function to distance.h; the
qhull based routines will have to use a separate code path anyways. In that
perspective these distance functions are local in ckdtree.
On Thu, Feb 16, 2017 at 12:58 AM, Ralf Gommers<EMAIL_ADDRESS>wrote:

In it goes then! Thanks @rainwoodman https://github.com/rainwoodman,
@sturlamolden https://github.com/sturlamolden
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/6945#issuecomment-280272270, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIbTKczUQkhrN-sPLAYLPGqPkIVoqEdks5rdA_AgaJpZM4Ld7_W
.


[ISSUE #1164]Fix Consumer Instance can't consume message from slave when cluster is in the high level tps and master has been killed.

What is the purpose of the change
We use the consumer instance to consume the message from slave node when the master node has been already killed and the TPS of cluster is in the high level.
Brief changelog
The consumer instance can consume the message from slave node when the master node has been already killed and the TPS of cluster is in the high level for producing and consuming messages
Verifying this change
I have already fix the issue in my local enviroment.
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.006%) to 49.348% when pulling 344e2bdf9d47589ef50d166ea1fdb88c5c7c73d7 on zongtanghu:develop into b3384d289e12641db1628c03b40f7cc714fc99fd on apache:develop.

LGTM

LGTM


Question

how do i remove this

https://github.com/iLLeniumStudios/fivem-appearance/blob/main/client/client.lua#L1045


Refactor python operator setup

This change replaces the use of the venv and pip modules with uv. The latter is a lot faster, especially for creating new venvs, because it does not bootstrap pip implicitly.
With my local measurements I get around 0.8s - 1.0s creation overhead when not requiring additional modules. This is a large improvement compared to python -m venv && python -m pip install ..., which often takes more than 10 seconds.
Thanks to that we are able to remove the venv caching logic and make all venvs ephemeral from now on. This means that repeated startups of the operator are now slower, because a cache hit avoided venv creation and dependency installation entirely.
We still decided to remove the caching due to the recurring issues with the intricate inter process synchronization logic.
An additional benefit of this is that restarting a python operator now automatically updates the dependencies to their latest versions.

Question:

An additional benefit of this is that restarting a python operator now automatically updates the dependencies to their latest versions.

Could that become a problem if dependencies introduce changes that may break the script?

Could that become a problem if dependencies introduce changes that may break the script?

As a user you probably want to pin your dependencies to a specific version to avoid this from happening if you don't trust them not to make breaking changes.

Could that become a problem if dependencies introduce changes that may break the script?

As a user you probably want to pin your dependencies to a specific version to avoid this from happening if you don't trust them not to make breaking changes.

Yeah, I am going to explore setting version constraints in the python operator's requirements option. This will likely do the trick.


Headers missing (hyprpm)

System Info and Version
 System/Version info
Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4  (props: bump version to 0.40.0).
Date: Sat May 4 15:42:32 2024
Tag: v0.40.0, commits: 4606

flags: (if any)

System Information:
System name: Linux
Node name: ethan-hpenvydesktopte020xxx
Release: 6.9.1-arch1-2
Version: #1 SMP PREEMPT_DYNAMIC Wed, 22 May 2024 13:47:07 +0000

GPU information:
0000:01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA104 [GeForce RTX 3070 Lite Hash Rate] [10de:2488] (rev a1) (prog-if 00 [VGA controller])

os-release: NAME="EndeavourOS"
PRETTY_NAME="EndeavourOS"
ID="endeavouros"
ID_LIKE="arch"
BUILD_ID="2024.04.20"
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://endeavouros.com"
DOCUMENTATION_URL="https://discovery.endeavouros.com"
SUPPORT_URL="https://forum.endeavouros.com"
BUG_REPORT_URL="https://forum.endeavouros.com/c/general-system/endeavouros-installation"
PRIVACY_POLICY_URL="https://endeavouros.com/privacy-policy-2"
LOGO="endeavouros"

(can't upload config)

Bug or Regression?
Bug
Description
Cannot install any plugins. also yes, i cannot do hyprpm update
How to reproduce
???
Crash reports, logs, images, videos

Have you installed cpio, meson and cmake?

I think the error reporting on this is a bit odd. If you run it with -v it will give you a more detailed log, about why it failed!
For me I had to install the following packages: meson cpio cmake hyprwayland-scanner

guys i just had to insta;; hyprwayland-scanner and ran hyprpm update so yes it works


InputSpec argument ignored

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.4.0-rc4-71-g582c8d236cb 2.4.0
Python version: 3.8.5

Describe the current behavior
The ndim argument of the InputSpec of a layer seems to be ignored when the shape argument is set. The issue is illustrated in the following example with a simple custom layer.
Standalone code to reproduce the issue
import tensorflow as tf
from tensorflow import keras
from tensorflow.keras import layers
import numpy as np

class TempLayer(tf.keras.layers.Activation):
    def __init__(self):
        super(keras.layers.Activation, self).__init__()
        self.input_spec = keras.layers.InputSpec(ndim=5, shape=(1,2))
    def call(self, input_1, training=False):
        return input_1

model = keras.Sequential([TempLayer()])
x = tf.constant([[1.4392, 1.9206]])
print (np.array2string(model.predict(x,steps=1), separator=', '))

@rschumi0 ,
Please post this issue on keras-team/keras repo.
To know more refer to:
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999

@tilakrayal It's now in the keras repo: https://github.com/keras-team/keras/issues/15225

@rschumi0 ,
Please feel free to move this issue to closed status,as it  has been tracked in keras repo.Thanks!


Browser Security Something

Is this a Midori problem, or an Alpine problem, or a TowerOS problem?

hum.. works well for me on a fresh online host.
@adamkrellenstein could you check the date of the host please ?

Ah good idea—that explains it.


Update Truffle and Solium

🚀 Description
This PR is to force update to Truffle 4.1.13 and Solium 1.1.8.
I solved all warnings regarding visibility-first and max-len.
There are many warnings regarding missing require message (error-reason) that everyone should address.
I'm having a linebreak-style issue with RBACCappedTokenMock.
But I think it is a solium issue so I can't resolve it. Travis test.

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

Turns out that file had Windows-style line endings, which Solium caught. I changed them to Unix-style (same as the rest of the project).

@nventuro I merged again from master.
If we don't accept this PR we will have conflicts forever and ever because of people are not using the visibility-first rule.

Agreed, these big PRs are better not left open for too long. Thanks once again @vittominacori!


Default provider

Case:
class TokenService(metaclass=ABCMeta):
    @abstractmethod
    def authorize_token(self, auth_header: str) :
        pass

@singleton
class JWTTokenService(TokenService):
...

JWTTokenService is the default implementation for TokenService, even if it has multiple implementations.
For now I have to do:
def set_up_injector():
    def token_provider(binder):
        binder.bind(TokenService, JWTTokenService)

    return Injector([token_provider])

It would be nice to have something like @ImplementedBy(JWTTokenService) instead.
Regards, Val

Can you provide an example of how would you like your code to look?

I believe the second form is preferable - better editor support (no need to put class name in string form) and easier to provide errors.
I'd change the @default annotation to @default_for(TokenService) - without the explicit interface figuring out what the binding should be can be tricky (in case of multiple inheritance or deep inheritance). @alecthomas do you have opinion on this? I'm still not entirely sure if it's worth it.
The patch introducing this would need to:

raise errors when two classes try to register themselves as default implementations for a single interface
provide extensive test coverage, handle edge cases and various Injector configurations that could affect the dependency injection correctness

I like the convenience, it would probably eradicate the need for modules at all in many cases.
I think it would be better as an annotation on the interface, as it makes grokking the bindings much simpler. Without it, tracking down which class is bound to the interface could be quite involved, or even magic depending on imports.

While having the interface reference the implementation via an annotation is simpler to do, it does result in a circular dependency between the abstraction and the concretion (hence the need for using a string to defer the resolution of the implementing type). I would personally never do something like that. An abstraction should know nothing about its concretions.


Added section on persistence in README.md

see #17

Could you mention that the integral term is available in msg.integral in the output message please.
Also the text needs to be included in the help text in pid.html.
Thanks.

Could you mention that the integral term is available in msg.integral in the output message please.
Also the text needs to be included in the help text in pid.html.
Thanks.

@colinl Done

@colinl Done

That's great, thanks.  I will release it shortly.

That's great, thanks.  I will release it shortly.


Avoid polluting our compilation with previously installed grpc.

Fixes #1849, I think.

I'll try to test this on my Mac some time today.

Looks like this one's still problematic. :-(
Procedure: make install from checkout 097a59b2a85f98c445e19a14371b82a05edd518e, then ffw'd to master, make install and see a replication of #1849. In the same environment, in a separate directory, git clone https://github.com/nicolasnoble/grpc.git, make install, and still see #1849.

 I'll amend this one.

Amended.

Confirming this fixes #1849. Waiting for Travis to go green.


A problem occurred evaluating project ':package_info_plus'. > No signature of method: build_5kxzmcx669otroqgxt13lr0x1.android() is applicable for argument types: (build_5kxzmcx669otroqgxt13lr0x1$_run_closure2) values: [buil d_5kxzmcx669otroqgxt13lr0x1$_run_closure2@1f13bdb1]

Platform
Android
Plugin
package_info_plus
Version
4.0.0 and above
Flutter SDK
3.1.0
Steps to reproduce
Build file 'C:\src\flutter.pub-cache\hosted[pub.dartlang.org](http://pub.dartlang.org/)\package_info_plus-4.2.0\android\build.gradle' line: 28

What went wrong:
A problem occurred evaluating project ':package_info_plus'.

No signature of method: build_5kxzmcx669otroqgxt13lr0x1.android() is applicable for argument types: (build_5kxzmcx669otroqgxt13lr0x1$_run_closure2) values: [buil
d_5kxzmcx669otroqgxt13lr0x1$_run_closure2@1f13bdb1]

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Code Sample
group 'dev.fluttercommunity.plus.packageinfo'
version '1.0-SNAPSHOT'

buildscript {
    ext.kotlin_version = '1.7.22'

    repositories {
        google()
        mavenCentral()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:8.1.2'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

rootProject.allprojects {
    repositories {
        google()
        mavenCentral()
    }
}

apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
    compileSdkVersion 33

    namespace 'dev.fluttercommunity.plus.packageinfo'

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

    kotlinOptions {
        jvmTarget = '1.8'
    }

    defaultConfig {
        minSdkVersion 19
        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
    }

    lintOptions {
        disable 'InvalidPackage'
    }

    dependencies {
        implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
    }
}

Logs
Build file 'C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\package_info_plus-4.2.0\android\build.gradle' line: 28
* What went wrong:
A problem occurred evaluating project ':package_info_plus'.
> No signature of method: build_5kxzmcx669otroqgxt13lr0x1.android() is applicable for argument types: (build_5kxzmcx669otroqgxt13lr0x1$_run_closure2) values: [buil
d_5kxzmcx669otroqgxt13lr0x1$_run_closure2@1f13bdb1]
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

Flutter Doctor
[√] Flutter (Channel stable, 3.3.10, on Microsoft Windows [Version 10.0.19045.3570], locale en-US)
    • Flutter version 3.3.10 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (10 months ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at C:\Users\umerf\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.
[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
[√] VS Code (version 1.83.0)
    • VS Code at C:\Users\umerf\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.74.0
[√] Connected device (4 available)
    • 2201117TG (mobile) • c42b892d • android-arm64  • Android 13 (API 33)
    • Windows (desktop)  • windows  • windows-x64    • Microsoft Windows [Version 10.0.19045.3570]
    • Chrome (web)       • chrome   • web-javascript • Google Chrome 118.0.5993.71
    • Edge (web)         • edge     • web-javascript • Microsoft Edge 118.0.2088.46
[√] HTTP Host Availability
    • All required HTTP hosts are available
! Doctor found issues in 1 category.

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Update your Android Gradle Plugin version.
Also, would be good if you really used search in the repo or Google instead of just checking the checkmark in our template:
https://github.com/fluttercommunity/plus_plugins/issues?q=is%3Aissue+No+signature+of+method%3A+build+is%3Aclosed


Add a NOOP module with pom.xml to produce the NOOP jar

this is done its https://repo1.maven.org/maven2/net/openhft/chronicle-analytics/0.EMPTY/

Released in Chronicle-Analytics-2.20.2, BOM-2.20.171


[otp_ctrl] update ast cfg software allocation

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

LGTM

hmm looks like some of our old files are going to fail the new whitespace check.
i'll have a look at this in a bit.

@tjaychen In the real design the latches are needed (scan_mode),. In the perevious version, the scan_mode_i & scan_reset_ni,
were local and were assiged to inactive which optimized out  the latches.
Made them local again for the OS, rebase & rerun the draft.

sounds good, thanks jacob.

@tjaychen Can you please take my draft PR latest file after I fixed the FPGA issue, thanks!


Disallow changing feature type of locked feature

When a feature is locked (because of a Wikidata tag), iD disables the feature’s Name field to prevent name vandalism, a common kind of vandalism. But it’s also probably common to vandalize or accidentally break a prominent feature by changing its type. When a locked feature is selected, iD should also disable the Feature Type button and the sidebar’s back button. When the nature of a feature does legitimately change, or in case it was originally mistagged, the user would still be able to change the feature’s type using the raw tag editor or unlock the feature by removing the Wikidata tag.
Some examples of mistaken or mischievous edits to Wikidata-tagged features:

School changed to park, most likely tagging for gameplay (though this change predates Wikidata tagging and the locking feature)
Park changed to recreation ground, tagging against gameplay (though this change predated the Wikidata tag and the vandal got more clever over time)
Administrative boundary relation changed to speed limit enforcement relation, probably by mistake somehow

If I understand the implications, then the lock would prevent vandalism to city names, such as New York City was a few years ago. It would also prevent the name change to oceans and seas if they have the appropriate wikidata id. I'd support this change.

If I understand the implications, then the lock would prevent vandalism to city names, such as New York City was a few years ago. It would also prevent the name change to oceans and seas if they have the appropriate wikidata id.

The locking feature was introduced in #6389 and already disallows changes to the Name field. This feature request is about extending the protection to the Feature Type button that sits above it in the sidebar, so you can’t change a city to a convenience store, for example.

If I can change the wikidata entry, how would this impact the feature.

It is possible to unlock a feature by removing any wikidata or *:wikidata tag. The locking feature is meant to deter only the most casual of vandals. The New York City incident was carried out by a much more sophisticated JOSM user, so this locking feature would not have prevented it at all. Even so, I figure there’s some value in extending locking to protect the most basic attribute of a prominent feature.
It’s also possible to vandalize the linked Wikidata item’s labels, which some renderers use in conjunction with OSM data. But Wikidata has more robust countervandalism measures, such as semiprotection (new users can’t edit the New York City item) and IP address blocking.


Editorial updates

Docs Build status updates of commit 638c852:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/terminal, working directory: W:\ih4g-s, target branch: HEAD, target branch commit: 03c99b47165129e81ff60dad692c39a89e97de01, source commit: 638c85226ee926769d2a7a43d2c498b58e627223.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit bdda04f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/troubleshooting.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/powerline-setup.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md

Line 73: [Warning] Invalid file link: './key-bindings.md'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1faf059:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/powerline-setup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 03db0b5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/terminal, working directory: W:\lvra-s, target branch: HEAD, target branch commit: a059b26e0fb154500d4806cfe03266ad39945863, source commit: 03db0b5db569134f1da480482e2750381c369700.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9a5274e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/terminal, working directory: W:\udja-s, target branch: HEAD, target branch commit: f317a3895a5d7d47c7a484f6b3871ac5378eb946, source commit: 9a5274e2b2cb8607106c9c287b3e6e7a88485fbb.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7ba46b1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/powerline-setup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 640a304:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/powerline-setup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7c223cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/powerline-setup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


The processing and Thinking running again and again

Did anyone have this issue?
They was 110 when I post this

Yes, me too. It used up my 600 requests per hour. And its progress bar, in my case only shows 14%.


cut the number of times discovery restarts during testing

Collapses directory structure in examples
Makes examples not overlap in entity names
Only launches discovery once (except for intentional restarts)
Ensure duplicate entity definitions are caught by pytest

21% faster

or about 1 and a half minutes

This will require docs editing

updated https://github.com/finos/greenkey-discovery-sdk/wiki


Return platform name that is lower case and underscored

Fixes #191
Fixes chef/inspec#1732
This change is a remake of https://github.com/chef/train/pull/192 with the updated platform work. This change sets platform names to always return downcase and underscored.
Signed-off-by: Jared Quick<EMAIL_ADDRESS>

⚠  DO NOT MERGE ⚠
This has to go out with a corresponding inspec PR which is still to come.

This will break Windows checks, right?

The inspec PR will keep it from breaking and just warn for now till inspec 2.0

@chris-rock this is totally a breaking change for Train, but SemVer-wise we're OK since this is still 0.x.
We've got an InSpec change in the pipeline that will gracefully handle it there, giving warnings for users as we initially discussed a month or so ago.
We'll want to cut a Train release with this change, and then cut an InSpec release that pins on that with the deprecation handling @jquick is working on.


New DLSS ray reconstruction dll file in Star wars Outlaws

I noticed that in the folder of Star Wars Outlaws game there is a new version of the DLL file for the Ray Reconstruction (nvngx_dlssd.dll 3.7.20). More recent than the one given on the TechPowerUp website or in your application (3.7.10).
I tried to warn TechPowerUp by e-mail but without success.
I enclose the file just in case.
nvngx_dlssd.zip

As I'm just using the dlls from TechPowerUp, there is not much I can do here.
I guess its displaying that an update is available?

No, it's good, in your application it only displays the version number without wanting to update it. In fact, it was when I saw that Cyberpunk 2077 didn't have the same version number than Star Wars Outlaws that I noticed this. These are the only two games with Ray Reconstruction that I own.


Use sync.Once as singleton implimentation

To make singleton creation a more secure one using sync.Once.

:+1: Thank you @orsonwang !

I think you're missing this line from var ( ... ):
	once sync.Once

Sorry, have put it back. now it completes.

Cool! Thanks :rocket: :ship:


Updates virtual camera example

Updates the camera example to work with the new changes from:
https://github.com/edbeeching/godot_rl_agents/pull/158
and:
https://github.com/edbeeching/godot_rl_agents_plugin/pull/31
so it can be used with CNN.

LGTM, did you train an agent? I did long ago with a MLP based agent. But it was before onnx support was added so I never saved the weights.

I'm not sure if we support this yet with our onnx export script / plugin. If not, may need a separate set of PRs of export/plugin to see how to get it to work fully.
Option 2:
For a quick solution, we can locally modify the plugin of the env or the obs space name (I think onnx inference is currently reading obs from the "obs" key of the obs dictionary) to make it work without cnn / normalization, just to have a basic onnx that works to some degree. However, I expect it won't perform as well and may take longer to train.
Would you like me to look into the export, or should I try option 2 for this PR and we can tackle the CNN export at some future point? - I'm not yet sure that it doesn't work, but I'm just guessing we may need some additional preprocessing like sb3 does to normalize the obs, and/or other changes.

Even option two would need more work, I tried to set the dictionary key to obs but there are other errors in that case, possibly due to the obs encoding.
Exporting to onnx will need a bit more investigating, keeping things as is but just switching the key name in the onnx export script produces some errors such as (didn't look into it in-depth yet):
\site-packages\torch\nn\modules\conv.py", line 459, in _conv_forward     return F.conv2d(input, weight, bias, self.stride, RuntimeError: Input type (unsigned char) and bias type (float) should be the same
While training and inference via Python will work, we probably need to adjust more things to export properly.

@edbeeching Should we merge as is (training and Python onnx inference will work), or wait for onnx export modifications?

@Ivan-267 , lets merge as is. We can do the onnx stuff in another PR.


Update inference submission directory structure

"audit" renamed to "compliance"
also moving directory one level deeper

@christ1ne can we get this in?
https://github.com/mlperf/policies/pull/47 addresses this


urlebird.com failed with error 403

CloudFlareException: https://urlebird.com/hash/dog/ resulted in 403 Forbidden  in lib/contents.php line 108

index.php(11): RssBridge->main()
lib/RssBridge.php(110): DisplayAction->execute()
actions/DisplayAction.php(71): DisplayAction->createResponse()
actions/DisplayAction.php(106): UrlebirdBridge->collectData()
bridges/UrlebirdBridge.php(45): getSimpleHTMLDOM()
lib/contents.php(164): getContents()
lib/contents.php(108)

Query string: action=display&bridge=UrlebirdBridge&query=%23dog&format=Html
Version: 2023-09-24 (git.master.5f777d4)
Os: Linux
PHP version: 8.1.8

They are protected by cf.


Anonymous access when accessing shared documents despite being logged in

What happened:
When accessing a shared document, the user is displayed as anonymous even when they are logged in. The issue can be observed in the following screenshot:

What you expected to happen:
The user's login status should be properly recognized and displayed as logged in when accessing shared documents.
How to reproduce it (as minimally and precisely as possible):
To reproduce the issue, follow these steps:

Go to a shared document.
Log in to the platform.
Check the user status, which erroneously displays as anonymous.

Anything else we need to know?:
Please ensure that you are logged in before accessing the shared document. This issue may be related to authentication or session management.
 Please tell me if you need help.

@eastfilmm Could you share your progress? If there are any issues, I can help.

Can I try this issue?

@choidabom Sure, I'll assign you.


Create an API connector | Endpoint URL

Hello,
Would be good to add documentation with examples of how to add the Endpoint URL.
Trying to set "Perform identity verification" for any guest users that have a Microsoft account Personal/Work to make sure they do the one-time password.
Else currently the situation is that non-MS accounts do receive one-time codes,
For any MS account, if the tenant is not set to use MFA for guests and the user doesn't have MFA enabled, the user not performing MFA...

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e8f1874e-2faf-a639-022f-af09bb4a18a0
Version Independent ID: 496d4a20-dc6d-fe6e-eab9-a0491f70ff99
Content: Add API connectors to self-service sign-up flows - Azure AD - Microsoft Entra
Content Source: articles/active-directory/external-identities/self-service-sign-up-add-api-connector.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@lightupdifire
Thanks for your feedback! We will investigate and update as appropriate.

#reassign:@csmulligan

@lightupdifire , thanks for reaching out. I've moved this issue to an internal work item for tracking. I'll go ahead and close this issue, but changes to the article are in the works. Thanks again!
#please-close


should cognition term get children?

Hi,
Just visited the cognition (GO:0050890) term. It has no
child terms, however the definition states:
'The operation of the mind by which an organism becomes
aware of objects of thought or perception; it includes
the mental activities associated with thinking,
learning, and memory'
...so should terms such as learning (GO:0007612) and
memory (GO:0007613) be part-of children?
cheers,
Emily
Reported by: edimmer
Original Ticket: "geneontology/ontology-requests/3301":https://sourceforge.net/p/geneontology/ontology-requests/3301

thanks www.movied.org


Issue #5

Couple fixes on bucket filling which improves the speed in several times.

Awesome, it's really fast on my mac! It also actually looks a lot better! 👍

Before I merge this, let's wait for @bradmartin to see if #5 is resolved in this.

Don't wait on me @jakubfiala - I won't have time to test it for a while. If you update the demo I can try it out much faster than running locally right now at work :smile:

okay, I'll merge this then


Could not fetch documents count

My Environment

ArangoDB Version:        3.6.2
Storage Engine:             RocksDB -->
Deployment Mode:       Single Server
Infrastructure:               own
Total RAM in your machine:    1GB (VM) Test

I left the database running for a long time, when it gives me a "Could not fetch documents count" error  in UI. I reboot , and it's the same. I don't see any out of memory errors.

Seems to be the db is corrupted. I can add documents ,but when I delete via AQL ,it say can't be found. And the UI shows negative document.

@imtrobin Did you upgrade the database directory, and if so, from which version to which version?

This was upgraded from an older version, I think 3.5 quite a while ago (last year?).  I don't think I had a issue after the upgrade. I stopped working on it for sometime. I just left the server running.

I've seen similar corruption myself in my local test server, which I randomly upgraded (including non-release versions) over multiple years. It eventually showed a large negative number as document count.
The proper upgrade procedure is to update to the latest patch version, e.g. 3.5.1 to 3.5.6, then to the latest version of the subsequent minor versions, in this example 3.6.8 and then 3.7.3. Skipping minor versions might result in silent corruption. Or perhaps some kind of overflow issue that only occurs after several years? If the server gets shut down because the machine gets shut down, then the write-ahead log should prevent unnoticed corruption because of unexpected termination, but it's possible that there is some very race condition perhaps, which causes this issue.
I suggest that you dump all databases including system collections and restore it into a fresh instance. That should resolve the problem.

This 's a development server with fake data, so I'm not worried, but I'm concerned for production if I run into these issues. There's no detection ,and no way to recover?

I'm actually seeing this in another older test deployment which I have not even upgraded, still has 3.5.0

Hmm, I created a fresh install 3.7.3, and also seeing this

@imtrobin You say a fresh installation, as in a new database directory? How did you restore the data? Or do you mean that the issue occurs as you create new documents in the new instance?

A fresh VM centos, fresh install. No restore of data. Yes, it occurs after I create.

Okay, so fresh 3.7.3 instance with a new database folder, you create documents via the UI but the count is wrong?
What's your browser? Can you try an incognito window to rule out caching issues? (There was a bug which caused a previous collection count to show, but that was fixed quite a while ago)

Can you also check the browser console (usually F12) if there is anything reported there?
Does arangosh report the same count as the Web UI (both off and both the same value)?
db.collectionName.count()

Incognito works. The console has an error.
GET http://<IP_ADDRESS>:8529/_db/Platform/api/collection/Advertisement/count?=1605183116740 net::ERR_BLOCKED_BY_CLIENT
So it was due to the adblocker in the brower which blocks the collection with keyword Advertisement. Mystery solved.


Invoking diamond with -r (run once) doesn't actually run once

The docs say it will run the given collector once and exit, but it lies. It runs the collector forever.

Fixed by #7


Small metadata update for AS, IN & NE

American Samoa - Blue sky is now using 1-684-272 -
http://localcallingguide.com/lca_prefix.php?npa=684
examples:
168427216xx
168427252xx
India - 7210 is being used by Aircel
examples:
9172104311xx
9172104313xx
9172104348xx
Niger - Airtel introduced 88 prefix
examples:
227881204xx
227881263xx
227881333xx
227881340xx

Thanks for the report! We've updated American Samoa and Niger, so these should be fixed in the next push. Still investigating India.

Fixed by release 7.0.11.


fix: infinite app reloading in development using expo

This was causing infinite reloading in development when using expo start
Cleaned it
Removed the desktop related stuff

Still need some refactor but at least fix the infinite reloading for now

Did some tests and everything worked 🙏


Convert speech to text?

Have I misunderstood that SpecAugment could be used to convert speech to text? It seems from your Medium article that it is simply something that enhances the process of one training a model rather than converts speech to text. Am I correct on this? I'm searching for the nearest model available online (for free) with the lowest WER which I can simply give audio and get text back with probabilities. Would appreciate any tips on that!

It does not support this. It is a data augmentation technique for learning from audio data. That's all! Check out ESPNet.

It does not support this. It is a data augmentation technique for learning from audio data. That's all! Check out ESPNet.


crowbar-testbuild: Replace jenkins-job-trigger

Recently ci.suse.de enabled csrf protection so jenkins-job-trigger
is no longer working. Replace it with a python module which is already
used by jjb.

talked to @jdsn and he's going to rewrite the jenkins-job-trigger script directly with the approach I'm using here. So this PR is just a blueprint but shouldn't be merged.

Fixed with https://github.com/SUSE-Cloud/automation/pull/983


Add Application info to use

Wow! Thanks! 👍
As soon as I can, I'll continue the refactoring for Swift 3.


ENH update DECISION-MAKING.md document with new governance

This PR is an update to our DECISION-MAKING document, recognizing the current governance we are following.
I left the general GitHub workflow in the document ... but changed its name from "decision making" to "workflow". This PR is meant as a first step to improve the current state.
@effigies @franklin-feingold I added you under the Maintainer Group, I don't know your time commitments, so I left it the same as mine (~5h/week), which is a very rough estimate anyway (some weeks more, some weeks less).

thanks for putting together @sappelhoff ! LGTM other than my small comment

FWIW, linkchecked failed to connect to nitrc, restarted (I think) that workflow

@franklin-feingold can this be merged  and you follow up on it with a separate PR?

@sappelhoff yep! sounds good


New plotting function for complex eigenvalues and check for imaginary part of eigenvectors

Check for aperiodicity as well.

closed by #65


allow using distcc as compiler wrapper for builds

Feature suggestion
A detailed description of the proposed feature
Being able to tell brew to pass the distcc wrapper down as the compiler for building C/C++ projects instead of the native compiler.
The motivation for the feature
People may have several Macs, some faster than others, and being able to use compilers remotely could greatly benefit build time. distcc is a tried and tested solution, but I at least found no way to pass it down as the compiler to use.
How the feature would be relevant to at least 90% of Homebrew users
This is potentially useful to any user with more than one Mac, as they can distribute compiling of especially bigger projects among them.
What alternatives to the feature have been considered
A very weak alternative is building projects on the faster Macs and then transferring them over. This is very cumbersome, and still lacks the potential of distributing building across multiple Macs.

Sorry, we're not interested in this at that time.


add test for Is.Odd and Is.Even

Codecov Report

Merging #20 into master will increase coverage by 5.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   89.44%   94.44%   +5.00%
==========================================
  Files           8        8
  Lines         180      180
==========================================
+ Hits          161      170       +9
+ Misses         19       10       -9

Impacted Files
Coverage Δ

...c/DeclarativeContracts/Functions/Is/IsForNumber.cs
84.31% <0.00%> (+17.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a309a...343e426. Read the comment docs.


Iox #1612 Replacing string() with a conversion method

Updated  helplets.hpp to replace operator std::string() with three toStdString() method and a into template structure
Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes TBD

@NNatarajan0717 every commit message must start with iox-#?? where ?? is the issue number to that commit. This is required since we need full traceability in a safety critical environment.

@NNatarajan0717 Are you still working on this PR?

@NNatarajan0717 Just an FYI, I started worked on #1612 and will then close this PR once mine is ready.

Closing as super-seeded by #1784


chore(main): release 1.1.40

:robot: I have created a release beep boop
1.1.40 (2023-07-27)
Features

not-found.tsx: add NotFound component, this might allow next.js to skip a whole renderer process at runtime, because at the moment the 404 page is recognized as a pages app (98a2a1c)

Bug Fixes

deps: update dependency ai to v2.1.25 (03692c8)
deps: update dependency ai to v2.1.26 (c036dd7)
deps: update dependency chart.js to v4.3.1 (3f190a5)
deps: update dependency chart.js to v4.3.2 (#155) (79070de)
deps: update dependency octokit to v3.1.0 (#157) (1b5d24e)
deps: update dependency openai-edge to v1.2.2 (#150) (9b4bca3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/icoretech/airbroke/releases/tag/v1.1.40 :sunflower:


Bring back DbQuery

In EF Core 2.2, we used a query type similar to this (notice the Id property):
public sealed class Record
{
    public int Id { get; set; }
    public string Value { get; set; }
}

that wasn't mapped to anything - not a table, not a view. We only used it with FromSql(). In our DbContext we had:
public DbQuery<Record> Records { get; set; }

After upgrading to EF Core 3.0, I see that DbQuery is marked as obsolete, suggesting the use of DbSet instead. I was a little confused, because - how will EF Core then be able to tell that this isn't actually supposed to be an entity... only a query type? And of course after running this, EF Core suddenly treated it as an entity and wanted to create a table for Records.
I saw a suggestion to mitigate this by configuring the type using HasNoKey(). That didn't work. EF Core still wanted to create a table for it. So I tried a few other things - calling ToTable(null) since we don't want a table, but that threw an exception. Eventually I tried using ToView (even though we don't want to map this to any view) and calling ToView(null) finally did the trick.
My question is: why the deprecation of DbQuery<T>?
The docs says:

This change was made to reduce the confusion around the purpose of query types.

In my opinion, the previous behavior was really clear and unambiguous - in our DbContext, we had DbSet<T> and DbQuery<T> properties. You could immediately see what was an actual entity mapped to a table in the database (DbSet) and what was not (DbQuery).
Now, I can't tell by looking at the DbContext itself. Instead of a simple change in the type of a property, I have to add additional configuration for the type to prevent it from being treated as an entity and mapped to a table, in a way that's not intuitive at all. I find the current state much more confusing than before.

@Neme12 We appreciate the feedback, but I think we are going in the correct direction here.
A query type was simply an entity type without a key defined. It could be mapped to a table, or to a view, or not to anything at all. All three of these possible mappings are also valid for entity types with keys. So Migrations working differently just because a type doesn't have a key led to a lot of confusion about what query types really were. See #17270
The second part of this, which we unfortunately not able to get to for 3.0, is a general mechanism to avoid creating database artifacts for any part of the model.

in our DbContext, we had DbSet and DbQuery properties. You could immediately see what was an actual entity mapped to a table in the database (DbSet) and what was not (DbQuery)

What is the reason you need to DbSet properties for these types on your DbContext?

Want to add a scenario which worked before but broke when upgrading to EF Core 3.0:
We created a partial dbContext which is completely separated from the generated context (we use database first and scaffolding). We collect all DbQuery's for the raw sql queriers in the manually created context. DbSet forces us to add HasNoKey to them but we can't override OnModelCreating since it's allready overriden in the generated context. Is there any soulotion to this?

@loth0 Why doesn't the generated context use HasNoKey?

@loth0 just implement the OnModelCreating partial method, and make any changes there.

@ajcvickers That would mean I'd have to modify the generated context each time I scaffold, which kinda defeats the purpose of a manually handled partial context, separated from the autogenerated context. I allready have to modify it (because of the default OnConfiguring generation) but the more modifications I have to do after each scaffolding the less convinient it gets.
@ErikEJ I don't follow, the OnModelCreating method is allready implemented in the generated context, I can't implement it in the manually created context too.

@ErikEJ Sorry my bad, now I found that a OnModelCreatingPartial method is generated, that one does the trick, thanks a lot!

@ajcvickers

What is the reason you need to DbSet properties for these types on your DbContext?

We don't. I think the author wrote it that way to avoid having to use fluent configuration (which we now have to use anyway to prevent EF Core from trying to create a table for it but at the same time be able to use it in FromSql). So yes, now it's pointless, I'll remove them, thanks.

I still think it would be useful to have a separate data type for a set of keyless entities as opposed to DbSet because the API should be different. For example Find doesn't make sense on keyless entity types. DbSet could then derive from this type and add Find and maybe other methods.

@ajcvickers What about creating a new attribute then that would mark an entity as not being mapped to a table or anything in the database, similar to how there's an OwnedAttribute right now?

@Neme12 Thanks for the feedback.

I still think it would be useful to have a separate data type for a set of keyless entities as opposed to DbSet because the API should be different. For example Find doesn't make sense on keyless entity types. DbSet could then derive from this type and add Find and maybe other methods.

That's basically why we created the new type originally. However, it quickly became very apparent that understanding the difference between QueryType and EntityType (one has a key defined; the other does not) was very difficult for people. It also added code duplication which already meant we missed some API on QueryType that should have worked for both. On balance, it seemed better to use EntityType for both since the difference between them is only whether there is a key or not. The difference in behavior is still a good point, and I guess we'll see with time whether we made the right call.
I added a note to #2725 about the attribute.

Hi there, I wanted to add a vote related to a point made in @Neme12 latest comment, which is to have  some way for the compiler to understand that on a DbSet for a keyless entity, Find won't work. Currently that throws at run time. Is it technically possible? I didn't see an issue for it and am happy to add one explicitly if it's useful to track. Thanks

@julielerman Can you explain what you mean by, "the compiler to understand?"

Oh sorry for lack of clarity.
If you have a DbSet that's been configured with HasNoKey, and try
_contextInstance.ThatKeylessSet.Find(1);
which doesn't make sense but let's say it's a mistake from habit...it will compile and run but throw an exception at runtime when EF Core tries to work out the query.  Hopefully that's enough.

@julielerman We discussed this and we're wondering if just using IQueryable would work for this?

@ajcvickers

What is the reason you need to DbSet properties for these types on your DbContext?

We don't. I think the author wrote it that way to avoid having to use fluent configuration (which we now have to use anyway to prevent EF Core from trying to create a table for it but at the same time be able to use it in FromSql). So yes, now it's pointless, I'll remove them, thanks.

I'm following this thread and the exchange between @Neme12  and @ajcvickers, but I don't understand this part. Is the DbSet property still (in .net core 3.1) required if we are using .FromSql()?
I am still using FromSql, so I'll still need the DbSet item, and .HasNoKey() and .ToView(null), right?


simulation.nodes(data).on('tick', ticked) failing for large data

I am trying to generate a bubble graph for 500+ objects and it turns out that it doesn't work for data arrays of size exceeding 300 or so (this is not a hard limit, just from what I observed). Basically, if the data array size exceeds that limit, all the bubbles are concentrated on a single x, y position.
This is what I'm doing:

simulation.nodes(data)
          .on('tick', ticked);

function ticked() {
	debugger;

	circle.attr("cx", function (d: any) {
	  return d.x;
	})
	.attr("cy", function (d: any) {
		return d.y;
	});
}

The breakpoint inside ticked() doesn't get hit every time when the data size is 300+ in my case and when that breakpoint is hit, bubbles do appear distinctively instead of getting jammed at one location.
Is there a workaround for this issue?

There’s no hard limit on the number of nodes; you can have as many nodes as you like, depending on how fast your computer is.
It’s not possible to debug this without seeing your full code in a live example, but here are some things I would investigate: Are you initializing the positions of the nodes before starting the simulation? Are any of those positions invalid? Are any of them coincident? Do you have forces which vary from node to node? Probably want is happening here is that the positions or forces are invalid (NaN) due to some aspect of the data or forces you have configured on the simulation.
Please use Stack Overflow tag d3.js to ask for help. Stack Overflow provides a better collaborative forum: thousands of D3-related questions have been asked there, and some answers may be relevant to you.
When asking for help, please include a link to demonstrate the issue, preferably as an Observable notebook. It is often impossible to debug from code snippets alone. Isolate the issue and reduce your code as much as possible before asking for help. The less code you post, the easier it is for someone to debug, and the more likely you are to get a helpful response.
If you have a question about D3’s behavior and want to discuss it with other users, also consider the d3-js Google Group or joining the d3-js Slack.
Thank you! 🤗

Regarding the code you posted, I’ll repeat my previous comment:

When asking for help, please include a link to demonstrate the issue, preferably as an Observable notebook. It is often impossible to debug from code snippets alone. Isolate the issue and reduce your code as much as possible before asking for help. The less code you post, the easier it is for someone to debug, and the more likely you are to get a helpful response.

The key point here is that it must be reproducible. It’s extremely unlikely that the problem exists in the snippet you posted, since that snippet is doing very few things. As I said, my guess is that the problem exists within the definition of data, but I’d need to be able to run the code with your data to investigate any further.

Wish I could share the data but for some reasons it's confidential.


Assembler issues on old machines

While integrating simdutf to Node.js we had the following error. Full build log can be found from https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-benchmarks/1269/console
/tmp/ccw5NR61.s: Assembler messages:
/tmp/ccw5NR61.s:6141: Error: no such instruction: `vpcompressb %zmm6,%zmm9{%k2}{z}'
/tmp/ccw5NR61.s:6258: Error: no such instruction: `vpcompressb %zmm10,%zmm0{%k3}{z}'
/tmp/ccw5NR61.s:6260: Error: no such instruction: `vpcompressb %zmm9,%zmm9{%k2}{z}'
/tmp/ccw5NR61.s:6283: Error: no such instruction: `vpcompressb %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:6284: Error: no such instruction: `vpcompressb %zmm9,%zmm9{%k1}{z}'
/tmp/ccw5NR61.s:6338: Error: no such instruction: `vpcompressb %zmm7,%zmm9{%k7}{z}'
/tmp/ccw5NR61.s:6420: Error: no such instruction: `vpcompressb %zmm3,%zmm9{%k1}{z}'
/tmp/ccw5NR61.s:6501: Error: no such instruction: `vpcompressb %zmm8,%zmm9{%k5}{z}'
/tmp/ccw5NR61.s:6650: Error: no such instruction: `vpcompressb %zmm11,%zmm19{%k2}{z}'
/tmp/ccw5NR61.s:6768: Error: no such instruction: `vpcompressb %zmm18,%zmm0{%k4}{z}'
/tmp/ccw5NR61.s:6770: Error: no such instruction: `vpcompressb %zmm19,%zmm19{%k2}{z}'
/tmp/ccw5NR61.s:6794: Error: no such instruction: `vpcompressb %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:6795: Error: no such instruction: `vpcompressb %zmm18,%zmm18{%k4}{z}'
/tmp/ccw5NR61.s:6854: Error: no such instruction: `vpcompressb %zmm12,%zmm19{%k6}{z}'
/tmp/ccw5NR61.s:6939: Error: no such instruction: `vpcompressb %zmm3,%zmm18{%k6}{z}'
/tmp/ccw5NR61.s:7008: Error: no such instruction: `vpcompressb %zmm13,%zmm18{%k5}{z}'
/tmp/ccw5NR61.s:7156: Error: no such instruction: `vpcompressw %zmm1,%zmm1{%k2}{z}'
/tmp/ccw5NR61.s:7238: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:7338: Error: no such instruction: `vpcompressw %zmm1,%zmm1{%k2}{z}'
/tmp/ccw5NR61.s:7374: Error: no such instruction: `vpcompressw %zmm13,%zmm13{%k2}{z}'
/tmp/ccw5NR61.s:7437: Error: no such instruction: `vpcompressw %zmm1,%zmm1{%k2}{z}'
/tmp/ccw5NR61.s:7473: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:7804: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:7849: Error: no such instruction: `vpcompressw %zmm2,%zmm2{%k2}{z}'
/tmp/ccw5NR61.s:7928: Error: no such instruction: `vpcompressw %zmm12,%zmm12{%k2}{z}'
/tmp/ccw5NR61.s:8003: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:8361: Error: no such instruction: `vpcompressw %zmm21,%zmm21{%k2}{z}'
/tmp/ccw5NR61.s:8442: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:8540: Error: no such instruction: `vpcompressw %zmm24,%zmm24{%k2}{z}'
/tmp/ccw5NR61.s:8572: Error: no such instruction: `vpcompressw %zmm21,%zmm21{%k2}{z}'
/tmp/ccw5NR61.s:8634: Error: no such instruction: `vpcompressw %zmm1,%zmm1{%k2}{z}'
/tmp/ccw5NR61.s:8666: Error: no such instruction: `vpcompressw %zmm23,%zmm23{%k2}{z}'
/tmp/ccw5NR61.s:8907: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:8953: Error: no such instruction: `vpcompressw %zmm2,%zmm2{%k2}{z}'
/tmp/ccw5NR61.s:9033: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:9109: Error: no such instruction: `vpcompressw %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:10497: Error: no such instruction: `vpcompressb %zmm2,%zmm2{%k1}{z}'
/tmp/ccw5NR61.s:10502: Error: no such instruction: `vpcompressb %zmm3,%zmm1{%k6}{z}'
/tmp/ccw5NR61.s:10571: Error: no such instruction: `vpcompressb %zmm0,%zmm0{%k1}{z}'
/tmp/ccw5NR61.s:10885: Error: no such instruction: `vpcompressb %zmm2,%zmm2{%k1}{z}'
/tmp/ccw5NR61.s:10893: Error: no such instruction: `vpcompressb %zmm0,%zmm0{%k1}{z}'
/tmp/ccw5NR61.s:10960: Error: no such instruction: `vpcompressb %zmm0,%zmm0{%k6}{z}'
/tmp/ccw5NR61.s:38875: Error: no such instruction: `vpcompressb %zmm6,%zmm9{%k1}{z}'
/tmp/ccw5NR61.s:39036: Error: no such instruction: `vpcompressb %zmm8,%zmm9{%k4}{z}'
/tmp/ccw5NR61.s:39091: Error: no such instruction: `vpcompressb %zmm10,%zmm0{%k3}{z}'
/tmp/ccw5NR61.s:39093: Error: no such instruction: `vpcompressb %zmm9,%zmm9{%k1}{z}'
/tmp/ccw5NR61.s:39116: Error: no such instruction: `vpcompressb %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:39117: Error: no such instruction: `vpcompressb %zmm9,%zmm9{%k5}{z}'
/tmp/ccw5NR61.s:39195: Error: no such instruction: `vpcompressb %zmm3,%zmm9{%k5}{z}'
/tmp/ccw5NR61.s:39267: Error: no such instruction: `vpcompressb %zmm7,%zmm9{%k6}{z}'
/tmp/ccw5NR61.s:39891: Error: no such instruction: `vpcompressb %zmm11,%zmm19{%k2}{z}'
/tmp/ccw5NR61.s:40048: Error: no such instruction: `vpcompressb %zmm13,%zmm18{%k5}{z}'
/tmp/ccw5NR61.s:40100: Error: no such instruction: `vpcompressb %zmm18,%zmm0{%k3}{z}'
/tmp/ccw5NR61.s:40102: Error: no such instruction: `vpcompressb %zmm19,%zmm19{%k2}{z}'
/tmp/ccw5NR61.s:40126: Error: no such instruction: `vpcompressb %zmm0,%zmm0{%k2}{z}'
/tmp/ccw5NR61.s:40127: Error: no such instruction: `vpcompressb %zmm18,%zmm18{%k3}{z}'
/tmp/ccw5NR61.s:40215: Error: no such instruction: `vpcompressb %zmm3,%zmm18{%k7}{z}'
/tmp/ccw5NR61.s:40286: Error: no such instruction: `vpcompressb %zmm12,%zmm19{%k7}{z}'
make[1]: *** [/w/bnch-comp/node/out/Release/obj.target/simdutf/deps/simdutf/simdutf.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Closing due to old CI


no monthy or daily if ref_time is not '000000'

@tclune : The actual (2-dot) changes here are minimal.  Not sure why you're getting messages.  Perhaps something went wrong with Weiyuan's merge of develop into this branch.
There's no touching of CMake or anything else of note.  We're just adding a check in the job file (lenkf.j) that verifies consistency of two HISTORY parameters.

Matt and I review all changes to the CMake files.    This allows us to ensure consistency for the build system over time.
And there were changes to the CMakeLists.txt for the APP in this PR.

The CMakeLists.txt changes are already in develop branch.  This branch simply bring develop into it. So I believe the check is based on three dot comparison not two dot comparison.

GitHub clearly shows changes to CMake going into develop.    Regardless, my comment is about whether you really want/need an extra library in the App directory.   I'm going to approve now in the interest of speed.  But please think about this.

Yes, at this moment, we need an extra library in the App directory. But in the future, we may move all those preprocessing subroutines  to a new location.

@tclune , @weiyuan-jiang , @mathomp4 :
At the risk of taking out of proportion... I'm still trying to understand what Tom's concern is here:

Do you really want a new library for this? The add_executable() macro allows you to specify multiple sources.

I'm guessing this refers to the following change:

This was approved previously by Tom and Matt in PR #283.
Would it be better to have preprocess_ldas_routines.F90 live in a different directory?
If so, where should it live?
It should be easy to make further changes.  Note that we're about to make a full release of GEOSldas (after 8 beta releases), so now's a good time to make such a change.

Yes - that is the code in question, but the concern is different.    And yes, I could have caught this change in the earlier PR, but sometimes I focus a bit more than others.
There is simply no need for the  esma_add_library() command.   The add_executable() command could simply absorb the new sourcefile.   Delete lines 1-7 and change lines 20-24 to be:
   ecbuild_add_executable (
      TARGET ${prog}.x
      SOURCES ${prog}.F90	preprocess_ldas_routines.F90
      LIBS GEOSldas_GridComp mk_restarts)

We usually introduce libraries either because the source is needed in multiple executables or more commonly because the source is used by other layers of the model.

Ah - and it did not help that the GitHub diffs summary was hiding he loop over multiple executables.   So there is some rationale for the library after all.      One could still argue my change is simpler, but ... down in the weeds at this point.


Get fingerprint from key

Sorry, I didn't do a clean merge before doing this PR, but it is only for displaying the fingerprint code: really only the contents of src/packet/types/key.rs needs to be copied and pasted into a new commit.

Thank you! A lot has changed, but it should be much easier to implement this now. I have added placeholder methods here: https://github.com/dignifiedquire/pgp/commit/731edd783c3e2fbce0767f0f690fe4276a712a32 where you can fill in the details. The key now stores expiration time and creation time, and the type structure is much simpler and hopefully easier to navigate.


Implementing google_services.json in MIT App inventor System

Hello Guys is there anyone could help me add google_services.json to MIT App inventor I tried Adding it to assest and It is not fullfiling the google app id and google bucket to Strings.xml If anyone can help I will be grateful

I've replied to your thread on the community site.


Enable client-side CQL encryption in Stargate if it is configured on the cluster (fixes #722)

What this PR does:
Generate a config file to enable client encryption for Stargate's CQL module.
Adapt e2e tests (thankfully NGINX ingress forwards TCP port 9042 the same whether it uses SSL or not, so the only thing to change is client code).
Which issue(s) this PR fixes:
Fixes #722
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

If there are specific settings other than client_encryption_options which should go there instead of cassandra.yaml, we'll need to document them.

Right, there might be more than the encryption options.
The full list supported by Stargate CQL is:
rpc_address
rpc_interface
rpc_interface_prefer_ipv6
rpc_keepalive *
native_transport_port
native_transport_port_ssl
native_transport_max_frame_size_in_mb *
native_transport_max_concurrent_connections *
native_transport_max_concurrent_connections_per_ip *
native_transport_flush_in_batches_legacy *
native_transport_allow_older_protocols *
native_transport_max_concurrent_requests_in_bytes_per_ip *
native_transport_max_concurrent_requests_in_bytes *
native_transport_idle_timeout_in_ms *

For the ones I marked with *: I think it make sense to copy to stargate_cql.yaml, I will add them to the list.
RPC address / interface: unlikely to be set globally on the CassandraDatacenter, if they are set to non-default values it's unlikely that it would be something global for all nodes.
Ports: the service hard-codes port 9042, and it doesn't allow both SSL and non-SSL either. So I don't think customizing those is a use case either.

Codecov Report

Merging #733 (1a6e592) into main (237a335) will decrease coverage by 0.06%.
The diff coverage is 55.81%.

@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   54.14%   54.08%   -0.07%
==========================================
  Files          82       82
  Lines        8342     8361      +19
==========================================
+ Hits         4517     4522       +5
- Misses       3376     3386      +10
- Partials      449      453       +4

Impacted Files
Coverage Δ

apis/stargate/v1alpha1/stargate_types.go
96.15% <ø> (ø)

pkg/stargate/config.go
0.00% <0.00%> (ø)

controllers/stargate/stargate_controller.go
46.36% <60.60%> (+0.30%)
:arrow_up:

pkg/stargate/deployments.go
92.81% <100.00%> (+0.08%)
:arrow_up:

controllers/k8ssandra/stargate.go
62.90% <0.00%> (-2.42%)
:arrow_down:

controllers/replication/secret_controller.go
64.42% <0.00%> (-1.35%)
:arrow_down:


Create a Kubectl Plugin for Meshery Snapshots

See mesheryctl Command Tracker for current status of commands.
Desired Behavior

This Kubectl plugin will allow users to generate a visual snapshot of their Meshery Design directly from Kubernetes manifest files, providing an easy way to visualize and interact with their infrastructure.
Feature Overview

Meshery users may want to generate snapshots of their designs for various purposes. Meshery currently provides the ability to create snapshots and integrates with GitHub, allowing snapshots to be generated automatically when a pull request is made. This feature gives reviewers a visual representation of the infrastructure changes, simplifying the review process.
In addition to GitHub integration, users working with tools like Helm, Kubernetes, and Docker may also want to generate snapshots directly from the command line.
A Helm plugin is currently under development (tracked in this PR), which will extend snapshot capabilities to the Helm CLI.

Current Design Spec for Helm Plugin
Meshery Snapshots Sequence Diagram

Implementation

With the Kubectl plugin, users will be able to generate a snapshot from a Kubernetes manifest file.
The proposed command will be: kubectl kanvas-snapshot -f manifest.yaml
This plugin will be developed using the Kubectl Krew Plugin manager.
Additional Reference material
1. Krew, the plugin manager for kubectl
2. Reference https://docs.meshery.io/extensions/snapshot
3. Reference https://github.com/marketplace/actions/meshmap-snapshot
Acceptance Tests

Users can install the latest snapshot plugin.
Users can execute   kubectl kanvas-snapshot -f manifest.yaml and have the Meshery Snapshot workflow invoked.

After generating the snapshot:

Users will receive a URL in the terminal that they can click to view the snapshot in their browser.
Users may also choose to have the snapshot sent to them via email.

Additional options for viewing snapshots could be proposed, such as:

Downloading the image directly to their local machine.
Sharing the snapshot via messaging apps or collaboration platforms (e.g., Slack, Teams).
Embedding the snapshot into project documentation.

Contributor Resources

⌨ mesheryctl Contributing Guide
Beginner's guide to contributing to Meshery and mesheryctl
mesheryctl Command Tracker
Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

i want to solve this issue

hi i would like to help and learn from whoever will be working on this feature, currently i am trying to understand the helm plugin pr

@Alero-Awani https://docs.google.com/document/d/1WQ5ba7v2RGtjsGPwxTfIxp9xzkdJnTxpFpDZ71eFdtY/edit?usp=sharing i have created a design will this format do


Incorrect proofs with 'old' keyword?

I may have found a problem with how the 'old' keyword is implemented. I think it's best described by the following example:

data Spec = Ensures(Bool);

class Testcase {
  Int dontTouch = 0;

  [Spec: Ensures(this.dontTouch == old(this.dontTouch))]
  Unit modify() {
    this.dontTouch = 42;
    this.doNothing();
  }

  [Spec: Ensures(this.dontTouch == old(this.dontTouch))]
  Unit doNothing() { }
}

{}

This program passes verification in the current version of crowbar. The specification of method doNothing is obviously correct and verifies as expected. Method modify, however, obviously changes the value of dontTouch - but it seems like the postcondition from method doNothing is used as a premiss in the verification of modify without accounting for the fact that the old in one method refers to a different state that the old in the other.
Adding a Requires(this.dontTouch == old(this.dontTouch)) to the doNothing method fixes the problem.
Perhaps my interpretation of what old is designed to do is wrong, but I would argue that the behaviour shown in the example is very counter-intuitive.

This is indeed a bug, old must be translated differently when used in a post-condition, I will look at this next.

I think the fix in e1f2f5e has an issue in the update order: old in the postcondition of the called method points to the post-anonymization heap because the anon update is applied after the {old := heap} update. This means we can't verify the above testcase even if the modification to the dontTouch field is removed because the postcondition of doNothing essentially reads select(anon(heap), dontTouch) = select(anon(heap), dontTouch) after the updates are applied.
Suggested change to PITSyncCallAssign (l.327-337):
val postCond = repos.syncMethodEnss[call.met]?.first ?: True
val targetPostDecl = repos.syncMethodEnss[call.met]!!.second
val substPostMap = mapSubstPar(call, targetPostDecl)

val anon = ElementaryUpdate(Heap, anon(Heap))

 //XXX handle  last here as well
 val someHeap = FreshGenerator.getFreshProgVar(Heap.dType)
 val heapUpdate = ChainUpdate(ElementaryUpdate(OldHeap,Heap), ElementaryUpdate(LastHeap,someHeap))

 val updateLeftNext = ChainUpdate(input.update, ChainUpdate(heapUpdate, ChainUpdate(anon, updateNew)))


License

Hi,
I don't see any license in this repository. Could you clarify it  please?

The license is MIT.


Fixing #443 : Removing 'template': from start of $TemplateText

Root Cause Analysis:  This was creating an invalid JSON fragment, which impacted Location-Should-Not-Be-Hardcoded.  This test converted $TemplateText back from JSON to create an in-memory copy.

This also may fix #437


vscode 1.77 causes extension to fail to load

In output window with Extension Host the following is seen:

[error] Activating extension pspester.pester-test failed due to an error:
[error] TypeError: Cannot redefine property: prepareStackTrace
at Function.defineProperty ()
at [redacted]\extension.js:5:287
[redacted]
at async Promise.all (index 0)
Rolling back to version 1.76 has fixed the issue on two of two machines tested so far. Appears to be an issue with vscode-adapter rather than vscode itself as has not affected any other extensions I have installed

Same issue with VSCode 1.77.0 and 1.77.1.
When rolling back to VSCode 1.76.2 the Test Explorer and Extension work properly.

This should be fixed now, please try the latest release, I'll close this issue in 1 week if no additional feedback is seen.

Thank you.
It look like working as before 👍
Tested with VSCode Version 1.77.3

Confirmed on 1.77.3 here as well - tests are listed in explorer and runnable again. :clap:

Thanks all!


Recoverable Errors

We should add recoverable errors to the parser to recover all errors while parsing instead of terminating on encountering the first error.

@bitwalker - I think we already have this? If so, we should probably close this issue.

We've relaxed the parser a bit, and removed some of the hard errors, but a few things are still hard errors that stop parsing. We would need to use the error recovery features in LALRPOP to make parsing complete before raising errors. We're pretty much set up for it now, just requires some modifications to the grammar file and AST to store error nodes.


Fix offset time - NR-96691

Overview
Situation:
The agent sets an "offset" at the beginning of the lifecycle of the page. It uses this "offset" to determine when events happen on the page relative to the beginning of the page lifecycle.  In the old agent architecture, the reading of on-page config values happened AFTER the loader had initialized.  It's during this time, that the offset was calculated.  The new agent architecture reads the on-page configs BEFORE the loader initializes (and AFTER, if values are missing).  This means that an invalid default "offset" can now be stored on the runtime object BEFORE it has been appropriately calculated, creating an invalid offset usually by 0-200 ms.  This can cause the early-page timings to be negative.
Replication:
Build the agent locally, run npm run test-server and navigate to a page that tracks session_traces.  Check the session_traces payload, checking the first timings in the payload for negative "s" and "e" values.  You may need to refresh a few times.
AC:
The offset must be calculated and assigned to the runtime object BEFORE the rest of the agent runs.
Tests should be added to ensure that no timing values are negative in the following features:
session_traces
page_view_timing
page_view_event
Related Issue(s)
NR-96691
Testing
New tests have been added to ensure that RUM, PVT, and PVE timings do not contain negative values.

Codecov Report

Merging #431 (180094f) into main (205d4c9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #431      +/-   ##
========================================
- Coverage   3.60%   3.60%   -0.01%
========================================
  Files        120     120
  Lines       4022    4023       +1
  Branches     994     994
========================================
  Hits         145     145
- Misses      3057    3058       +1
  Partials     820     820

Impacted Files
Coverage Δ

src/common/config/state/runtime.js
0.00% <ø> (ø)

src/common/timing/start-time.js
0.00% <0.00%> (ø)

src/common/util/submit-data.js
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Before

### After

Per slack discussion, this should be updated to coalesce all timing "offset" into runtime.offset and merge in NR-57391 work.


Get back of the queue

Add function to get the back of the queue.
Equal to function peek() but for the tail on doubly & singly.
Steps to follow

Update on Doubly & Singly

Update tests Doubly & Singly

Add on Queue + test

fixed here e599ea8cc3ef2d6180cca221076e2975a4680aed


[VL][RAS] Optimize rough model to solve the regression caused by r2c large table

Description
In production, we encountered a situation where the consumption of r2c large table was far greater than the performance improvement brought by native, so I considered using RAS to solve this problem.

I assume this is closed by https://github.com/apache/incubator-gluten/pull/7686. Please reopen if needed.


Pagefind work

Thanks, Adam!
nb team, additional conversation in #819 re: activating PageFind index. @cgettings and @etorem, please take a few minutes to serve this up locally and take a look at how this search function works.


Add nullability annotations to RACSubscriber

In general, it seems helpful to have nullability annotations specified within RACSubscriber.h, though perhaps there's a strong reason for which this file hasn't already been annotated that I'm not aware of.
However, according to SE-0140:

when an Optional is intentionally passed into Objective-C as a nonnull object, we should bridge some value by bridging the wrapped value, and bridge nones to a singleton such as NSNull

With SE-0140, which has already been implemented in Swift 3.0.1 (available in the Xcode 8.1 beta 3), it is important that nullability annotations be specified on RACSubscriber. Otherwise, when RACSubscriber.sendNext() is passed an Optional.none from within Swift, Swift will (post Swift 3.0.1) be bridge this to NSNull, when previously (pre-Swift 3.0.1) it was visible within the Objective-C sendNext: implementation simply as nil. This results in a change in behavior when ReactiveObjC is compiled with the Swift 3.0.1 compiler
@raylillywhite and I observed this change in behavior in Xcode 8.1 beta 3, and have verified that adding nullability annotations restores the previous behavior that users of ReactiveObjC are relying on.
Here's the difference in the Swift generated interface before and after this change:
Previous Swift generated interface (from Xcode 8.1 beta 3 with Swift 3.0.1)
public protocol RACSubscriber : NSObjectProtocol {

    public func sendNext(_ value: Any!)

    public func sendError(_ error: Error!)

    public func sendCompleted()

    public func didSubscribe(with disposable: RACCompoundDisposable!)
}

New Swift generated interface (from Xcode 8.1 beta 3 with Swift 3.0.1):
public protocol RACSubscriber : NSObjectProtocol {

    public func sendNext(_ value: Any?)

    public func sendError(_ error: Error)

    public func sendCompleted()

    public func didSubscribe(with disposable: RACCompoundDisposable)
}

Relatedly, there seems to be a bug or limitation in the Swift compiler that causes ReactiveObjCBridging's RACSignal.toRACSignal() function to bridge Optional.none to NSNull (in next events' values) even after added the nullability annotation to -[RACSubscriber sendNext:]. @raylillywhite and I are in the process of investigating this and have created ReactiveCocoa/ReactiveObjCBridge/pull/5 to address this.

👍 @mdiep I just amended my commit to use NS_ASSUME_NONNULL_* as suggested.

@erichoracek is correct. NS_ASSUME_NONNULL_* should only have replaced the _Nonnull uses.

Yep, good catch @erichoracek. Too much rushing on my part. Updated.

Thanks!


<EMAIL_ADDRESS>uses @libsql/client, not installed in the workspace

According to the v0.21.0 release note:

For sqlite dialect, Drizzle will:

Check if the @libsql/client driver is installed and use it.
If not, try to find better-sqlite3 and use it.
If nothing is found, an error will be thrown

There seems to be a resolution error with the pnpm package manager.
Even in a workspace where @libsql/client is not installed as a (dev) dependency,
pnpm why better-sqlite3

# dependencies:
# better-sqlite3 9.6.0
# drizzle-orm 0.30.10
# └── better-sqlite3 9.6.0 peer

pnpm why @libsql/client

# dependencies:
# drizzle-orm 0.30.10
# └── @libsql/client 0.6.0 peer

The drizzle-kit commands (e.g. migrate, studio) finds it and uses it instead.
LibsqlError: URL_INVALID: The URL is not in a valid format
    at parseUri (file:///path-to-workspace/node_modules/.pnpm/@libsql+core@0.6.0/node_modules/@libsql/core/lib-esm/uri.js:9:15)

Ability to specify the better-sqlite3 driver is no longer available.

should not be an issue on latest(0.30.0+), if it's still an issue - please reopen


In version 5.0, distance replaced by point.distance

It may be fixed for version 5 by simply changing the definition of the distance Function.
Possible solution->
	enum Spatials implements FunctionDefinition {

		POINT("point"),
		DISTANCE("point.distance");

		private final String implementationName;

		Spatials(String implementationName) {
			this.implementationName = implementationName;
		}

		@Override
		public String getImplementationName() {
			return implementationName;
		}
	}

Take a look at:
https://github.com/neo4j-contrib/cypher-dsl/blob/3e5e7d5fdae1c7394a59878890d22d3f8e96f51c/neo4j-cypher-dsl/src/test/java/org/neo4j/cypherdsl/core/DialectIT.java#L61-L66
to see how to use the new syntax

Thanks Andy.
Yes, this is already supported in our Dialect
https://github.com/neo4j-contrib/cypher-dsl/blob/main/neo4j-cypher-dsl/src/main/java/org/neo4j/cypherdsl/core/renderer/Dialect.java#L48
We use this in SDN6 already to keep up with the changes in Neo4j 5.
Thanks @Andy2003 for jumping in!


UWP Renderer: Inline ShowCards are within the card margins rather than being edge-to-edge

This will be a larger task than anticipated. Relabeling from bug to task and adding estimate.


Enable/Disable steps on click

Hi,
I want to enable and disable all steps not on load but afterwards by click. How can I achieve this? Thanks.
G.

if you click on something in the first tab content area, you can enable the second step button (tab button) by doing.
enable next step
$theSteps = $('.steps ul').find('.current');
$($theSteps).next('li').removeClass('disabled');
disable next step
$theSteps = $('.steps ul').find('.current');
$($theSteps).next('li').addClass('disabled');