Agent break stage on warning state

Agent Version and Platform
Version of your agent? 2.155.1
OS of the machine running the agent? Windows Core (2016 1803)
Azure DevOps Type and Version
dev.azure.com
If dev.azure.com, what is your organization name? https://dev.azure.com/dev-traceparts-com
What's not working?
When performing a run, commands that return warning are breaking the build, (did not happen on Windows 2012 R2 nor on windows host 2019).
Agent and Worker's Diagnostic Logs
##[section]Starting: CI process using Cake
Task         : PowerShell
Description  : Run a PowerShell script on Linux, macOS, or Windows
Version      : 2.151.2
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
Generating script.
Formatted command: . 'C:\agent_work\1\s.cicd\cake\build.ps1' -Script './.cicd/cake/build.cake' -Target 'CIProcess' -ScriptArgs '--settings_skipverification=true --BUILD_NUGET_SOURCE="https://pkgs.dev.azure.com/dev-traceparts-com/_packaging/Nuget-Packages/nuget/v3/index.json" --SYSTEM_ACCESSTOKEN=*** --BUILD_SOURCEBRANCHNAME="development" --BUILD_DOCKER_LOGIN="TracePartsDockerRepo" --BUILD_DOCKER_PASSWORD="" --BUILD_DOCKER_ADDRESS="tracepartsdockerrepo.azurecr.io" --BUILD_SONAR_LOGIN="azure_devops_service" --BUILD_SONAR_PASSWORD="" --BUILD_SONAR_ADDRESS="https://dev-sonar.traceparts.com" --BUILD_DESCRIPTION="Tracks solution" --BUILD_SONAR_BUILDBREAKERQUERYMAXATTEMPS=600 --BUILD_SONAR_BREAKIFQUALITYFAILS=false --BUILD_PROJECT_NAME="TraceParts.tracks.get.api" --BUILD_VERSION="2019.261.430.32" --BUILD_DB_CONNECTION_STRINGS="./connectionstring.json"'
========================== Starting Command Output ===========================
##[command]"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'C:\agent_work_temp\92ca2303-7223-444d-9eae-798d778d53a9.ps1'"
Preparing to run build script...
Running build script...
Restore completed in 79.21 ms for C:\agent_work\1\s.cicd\minicover\minicover.csproj.
Restore completed in 212.82 ms for C:\agent_work\1\s.cicd\minicover\minicover.csproj.
Solution file C:/agent/_work/1/s/TraceParts.Tracks.sln

Setup
========================================
JobInit
Branch name: development
Version: 2019.261.430.32
Solution file: C:/agent/_work/1/s/TraceParts.Tracks.sln
Current folder: C:/agent/_work/1/s
Solution name: TraceParts.Tracks
Project description: Tracks solution
Sonar address: https://dev-sonar.traceparts.com
Sonar buildbreaker max attemps: 600
Sonar break if fails quality gate: False
Nuget source: https://pkgs.dev.azure.com/dev-traceparts-com/_packaging/Nuget-Packages/nuget/v3/index.json
Nuget Api: ***
========================================
ContainerRegistryLogin
Start docker cleanup
No container to stop !!
No images to delete
Docker environment is ready to rumble!
Cake.exe : WARNING! Using --password via the CLI is insecure. Use --password-stdin.
At line:1 char:1

& "C:\agent_work\1\s.cicd\cake\tools\Cake\Cake.exe" ./.cicd/cake/bu ...

  + CategoryInfo          : NotSpecified: (WARNING! Using ...password-stdin.:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

##[error]PowerShell exited with code '1'.
##[section]Finishing: CI process using Cake

I get the same issue with a YAML pipeline and:
pool:
  vmImage: 'windows-latest'

Do we have any workarounds for now?

I was getting this warning which was causing the build to fail:
az : WARNING: No credential was provided to access Azure Container Registry. Trying to look up...
This had no efffect:
powerShellIgnoreLASTEXITCODE: true
This fixed it:
pool:
  vmImage: 'vs2017-win2016'

That's my workaround for now.

Hey @michaelharrod sorry for the slow response. This looks like an issue with the image the agents are hosted on, not the agent itself. If its still an issue, would you mind filing it at https://github.com/actions/virtual-environments/issues?


Can't claim any reward - Wallet_address does not match user

The Issue
Steps to reproduce

Trying to claim any reward

Expected behaviour
Reward should be granted
Actual behaviour
Error Message: Wallet_address does not match user
System Configuration

LBRY Daemon version: 0.17.0
LBRY App version: 0.17.0
LBRY Installation ID: 2BXqc5xEqfBfZmfzoH2Z8hQnpDnmTfkYhzF35BtktmrkRDX5hzoq3Tg9bb2nXVCRcn
Operating system: Linux

Anything Else

I've done email verification numerous times (always same email) over the past couple of weeks since lbry app always re-requested it. "Reward Eligible" is checked on help page.
Screenshots

Can you send me your email address to<EMAIL_ADDRESS>along with screenshots of the reward / transactions screen?

Sent, thanks in advance.

Also, lbry should not re request the verification that many times. Are you using the same email on multiple installations? Or possible different emails that were once used on the same one? Move around any wallet
files?
https://lbry.io/faq/lbry-directories

Yes, I do have lbry on my desktop and on my laptop (which doesn't seem like a totally special use case to me). Since I'm also mining I want to be able to use it on multiple hosts to check/access balance, just like any other blockchain based system.
I've started back on 0.12. IIRC I've copied the wallet files because it didn't make sense to me to have two separate wallets. But it was always the same lbry client on the laptop that re-requested verification and I haven't used the desktop client for a long time.

Going to close this and we'll take care of it via email.
We don't recommend running the same wallet on multiple PCs, at least not concurrently. There may also be some discrepancies on one of the wallets when transactions are made on the other. LBRY works similar to bitcoin and because we use a light client (electron wallet), the wallet addresses it generates on each may be different (but still tied to your seed).  This may have caused some confusion in our rewards API side, I'll look into it.
Also, if you sign in on one PC, it will force you to sign in again when you load it up on another PC (if using the same email). A way around this would be to use separate emails/wallets (I know you said you don't want to maintain two wallets).

@chron0 Let me know when you get to end up checking out if the issue was fixed.

updated to lbry 0.17.1, cleared cache, re-done verification:
Rewards can be claimed and, I checked to test, cannot be
claimed more than one time (at least the single event ones).
It seems to be fixed, yay, thank you very much :)


Sync installed Plugins across multiple computers

An idea from Jared Volpe.
Could potentially link to the user's Dropbox to store a simple text file of installed plugins, which Sketch Toolbox can then reference.

Any news on this? Sketch gives me an error that it doesn't have permission to access the symlinked/aliased folder in Dropbox.

Also asking for news on this feature now that linking Sketch's plugins to dropbox is an option.


Better place for tests info

Fixes #228

Fixes #
Summary of the Fixes

Summary by CodeRabbit

New Features

Introduced a new "Testing" section under "Resources" in the menu to provide detailed information on QGIS testing practices.

Improvements

Restructured the "Releases" section to focus on a consolidated list of previous QGIS releases and plugins.
Updated the plugins link for better accuracy and accessibility.

Chores

Added installations for new VS Code extensions to enhance development productivity.

The playwright test should be fixed after merging #254 as we've updated the top bar.


fixed mouse events for border type dropdown

closes #1091

Coverage decreased (-0.08%) to 55.132% when pulling de45c3b213fb4b050aa76c75ce29fea23935cc72 on 1091-border-dropdown into 5b0b7d88078373ceec17c7d50964f6901792e100 on release2.1.


fix(auth): authController full rewrite

Closes #2957 .
Closes #2960 .
Fixes 2 bugs caused by legacy code.

@itsconquest looking at this line
 . Do you have a state param in your url ?
Invalid State error is thrown when state from URL is different from state from localstorage.
This is done to prevent CSRF.

@itsconquest was the bug only reproducible with the dev.portainer setup?

@itsconquest was the bug only reproducible with the dev.portainer setup?

Both

@itsconquest should be working as expected now.


ssh: fix server to accept rsa-sha2-256 and rsa-sha2-512 signatures

This pull request fixes serverAuthenticate() to accept "rsa-sha2-256" and "rsa-sha2-512" public key algorithm names and signature format in user auth messages. Additionally this pr adds unit tests for RSA publickey authentication using rsa-sha2-256 and rsa-sha2-512 signatures.
Fixes https://github.com/golang/go/issues/46569

@googlebot I fixed it.

@googlebot I fixed it.

I noticed the unit test had a bug: incorrect public key algorithm name was used woth rsa-sha2-* signatures. Fixed it.

@samiponkanen as I understand, the server would still not advertise support for SHA2 with your PR. Is that the case?
https://github.com/golang/crypto/blob/0c34fe9e7dc2486962ef9867e3edb3503537209f/ssh/keys.go#L338-L340

@samiponkanen as I understand, the server would still not advertise support for SHA2 during KEX with your PR. Is that the case?

You are correct, this PR does not add support for sending the server-sig-algs extension.

This pull request fixes serverAuthenticate() to accept "rsa-sha2-256" and "rsa-sha2-512" public key algorithm names and signature format in user auth messages. Additionally this pr adds unit tests for RSA publickey authentication using rsa-sha2-256 and rsa-sha2-512 signatures.
Fixes golang/go#46569

https://www.cryptocaptrades.com

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ Googlers: Go here for more info.

https://www.cryptocaptrades.com

@googlebot I fixed it.

https://www.cryptocaptrades.com

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ Googlers: Go here for more info.

https://www.cryptocaptrades.com

@googlebot I fixed it.

https://www.cryptocaptrades.com

This PR (HEAD: ab4f6d8) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/325089 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

https://www.cryptocaptrades.com

This PR (HEAD: ded2006) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/325089 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

https://www.cryptocaptrades.com

@samiponkanen as I understand, the server would still not advertise support for SHA2 during KEX with your PR. Is that the case?
https://github.com/golang/crypto/blob/0c34fe9e7dc2486962ef9867e3edb3503537209f/ssh/keys.go#L338-L340

https://www.cryptocaptrades.com


Prevent users from creating bad environments

We should do more to validate the environment.  This will help prevent invalid environments.  One idea from Steve is to block the environment at Create step until they've gotten all fields correct.

I'm not actually sure that we can block users at that stage - by design, it's meant to be a non-blocking process.
What we can do is flash red warnings at them until they've filled everything in, though that will probably be fairly offensive to everyone else who knows what they're doing. I don't think it's easy to miss what's required when you start adding a new environment, but maybe there's a window layout that hides the examples?

Its odd to let them create something that won't work.  However we maybe don't want to be completely blocking.  I'm thinking we put a little red (!) next to the field that isn't correct.  Then when they click save we save if no issues.  Same experience as today with a single click.
In the case where we've detected errors we pop a confirmation (2nd Yes click) that indeed they do want to create with the invalid values.  Lets them do it if they want while preventing users from the accidental mistake


Actifit Report Notification Shows -1 when Value is 0

Expected Behavior
The Actifit Report Notification shows a value of 0 when the value is 0.
Actual Behavior
The Actifit Report Notification shows a value of -1 when the value is 0.
How to Reproduce

Install Actifit for Android
Launch Actifit
Pull down from top of the screen
View Notification for Actifit

Test Environment

OS:  Android 8.1.0
App:  0.3beta

Recording Of The Bug
https://youtu.be/J5rkIoEOJcg

Yes we're aware of this issue, thank you


[ROCKETMQ-207]Correct spelling mistake in RouteInfoManager.java

There is several spelling mistakes, it's a little confusing and i think we should fix them,like this one :
if (null == prevBrokerLiveInfo) {
                   log.info("new broker registerd, {} HAServer: {}", brokerAddr, haServerAddr);
}

and here is the JIRA link of this issue : https://issues.apache.org/jira/browse/ROCKETMQ-207 ,thanks for your time

Coverage decreased (-0.03%) to 38.636% when pulling bfa7f1ac8bfac3334e6b307db4aabc66ad22f5e9 on aCoder2013:feature/correct-spelling-mistake into 0fe947173a85d8931b1068805713e89dbba4125a on apache:develop.

Coverage decreased (-0.03%) to 38.636% when pulling bfa7f1ac8bfac3334e6b307db4aabc66ad22f5e9 on aCoder2013:feature/correct-spelling-mistake into 0fe947173a85d8931b1068805713e89dbba4125a on apache:develop.

Coverage decreased (-0.03%) to 38.636% when pulling bfa7f1ac8bfac3334e6b307db4aabc66ad22f5e9 on aCoder2013:feature/correct-spelling-mistake into 0fe947173a85d8931b1068805713e89dbba4125a on apache:develop.

Thank you! Please relate JIRA  link in the discriptions.
Also, there are multiple typo string literal in rocektmq code base , it's welcome to fix them in this pr too.

Coverage decreased (-0.03%) to 38.632% when pulling 9422bdb38ba8871b87c4b5172f1dc08b207d901b on aCoder2013:feature/correct-spelling-mistake into 0fe947173a85d8931b1068805713e89dbba4125a on apache:develop.

Coverage decreased (-0.03%) to 38.632% when pulling 9422bdb38ba8871b87c4b5172f1dc08b207d901b on aCoder2013:feature/correct-spelling-mistake into 0fe947173a85d8931b1068805713e89dbba4125a on apache:develop.

Coverage decreased (-0.03%) to 38.632% when pulling 9422bdb38ba8871b87c4b5172f1dc08b207d901b on aCoder2013:feature/correct-spelling-mistake into 0fe947173a85d8931b1068805713e89dbba4125a on apache:develop.

LGTM @zhouxinyu @vongosling please help a review

Coverage increased (+0.1%) to 38.819% when pulling 7b256ebeb48c99494f1c1d8eddd7b58ea2039992 on aCoder2013:feature/correct-spelling-mistake into 845830865fc37d0364a19cbd89ceaf8a30b37e1c on apache:develop.

@zhouxinyu I've fixed the code style , please check it out ,thanks

Changes Unknown when pulling eabe47fd600c6e1b9f36023943d0491a5f920161 on aCoder2013:feature/correct-spelling-mistake into ** on apache:develop**.

Changes Unknown when pulling eabe47fd600c6e1b9f36023943d0491a5f920161 on aCoder2013:feature/correct-spelling-mistake into ** on apache:develop**.


Make URL(s) in Tweets Clickable

Wanted to open the link to a Covid19-related toolkit but was unable to do so as the app doesn't allow it. Hope urls become clickable in the near future.
App Version: 2.0.0
Repo: F-Droid

Okay, this issue has already been addresed (#4) so I'm closing it. Sorry.


Convert Test_DownloadKubectl tests to test table format

Task
Convert Test_DownloadKubectl tests to test table format
Benefit
More maintainable, and easier to follow now that we have a newer test format such as Test_DownloadOpa or Test_DownloandPolarisCli

Thank you @dirien - looks good to me.


i am unable to open the frontend module i tried to install all packages . please help me out how to run on local server. my email<EMAIL_ADDRESS>

Please leave detailed issue attach screenshotsof what you are facing

closing as stale


Issue parsing CSS syntax "border-radius:0 0 100px 100px / 0 0 20px 20px;"

It is a valid CSS statement for creating the bottom elliptical border.
However after less.js parses it, it becomes "border-radius: 0 0 120px Infinitypx 0 6px 6px; "
It looks like less.js try to calculate 120px / 0 but it is not the right thing to do here.
Note syntax "border-radius:200px / 100px;" is legal too in CSS.

Is this syntax finalized?  I guess it has been stable enough with font declarations.


getInfo in RediSearchUtils does not work with RediSearch 2.0

Hi Team,
The getInfo method in RediSearchUtils does not work with RediSearch 2.0 module.
It throws the below exception.
Exception:java.lang.String cannot be cast to java.lang.Double
Thank you,

Hi Team,
any updates on this?
Thank you.

Hi,
Sorry for the delay. This is a known issue that was introduced with the upgrade to Lettuce 6.0. See here for more details: #33

Hi,
Thank you for the update, is there timeframe for the fix?

Sorry this is dependent on next Lettuce release which I don't think has a date set. I'll keep monitoring the lettuce project and update lettusearch as soon as they release the fix

@koreykiran this issue was fixed in release 2.5.0

@koreykiran this issue was fixed in release 2.5.0

Thank you for the update.

Thank you for the update.

The connection pooling does not seem to work, could you please update the documentation for the connection pooling.

The connection pooling does not seem to work, could you please update the documentation for the connection pooling.

What problem are you seeing?

What problem are you seeing?


Convert metric analysis scripts into rust crate

Currently the post-processing on the collected metrics from the prover can processed using python scripts in ci/scripts/metrics_unify/. These are used to generate a markdown report and flamegraphs of cell/instruction usage. To keep everything in Rust and also to make it easier to import these tools in other repos, we should convert all the scripts into a Rust crate.

Would you mind to assign this issue to me? @jonathanpwang

Assigned, but noting that I am updating our metrics collection and will be making a first pass at porting over the summarize.py because we need it for benchmark analysis

@keroro520 to avoid overlap, you can start with the fine-grained metric collection (corresponding to metrics_unify/main.py). I will be focusing on summarize.py and flamegraph.py.
Separate from this, I would be interested in a standalone prometheus recorder for metrics.


requestAnimationFrame hanging load requests at low framerates in Chrome

In some intermittent cases, the use of SpringRoll's internal requestAnimationFrame is hanging attempts to load assets in Chrome (desktop and mobile). For instance, when an audio file is asked to load during performance intensive displaying. This causes XHR file request to show up as "pending" in Chrome's DevTools Network tab. Un-focusing the Chrome browser application (or current tab) resolves the file pending requests.
The workaround is to optimize the display by reducing the use of uncached EaselJS drawing (vectors) or to disable the use of requestAnimationFrame (it is true by default).
To disable requestAnimationFrame set the raf option on the Application:
var app = new Application();

becomes:
var app = new Application({
	raf: false
});

Closing this issue as a workaround is available for CreateJS specific games and isn't an issue in WebGL (Pixi Display). This bug is too intermittent to find a way to consistently reproduce and therefore find a permanent solution. Also, this issue has possibly been resolved in a recent Chrome update.
Keeping as reference.


PPP changes, closed issue #150, minor style/grammatical error changes…

… in DG/UG, close issue #150

Codecov Report

Merging #229 (ad25b5d) into master (f707b19) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #229   +/-   ##
=========================================
  Coverage     73.51%   73.51%
  Complexity      727      727
=========================================
  Files           114      114
  Lines          2311     2311
  Branches        272      272
=========================================
  Hits           1699     1699
  Misses          526      526
  Partials         86       86

Impacted Files
Coverage Δ

...main/java/seedu/address/model/task/FormatDate.java
88.88% <ø> (ø)

...ava/seedu/address/storage/JsonAdaptedDeadline.java
100.00% <ø> (ø)

...in/java/seedu/address/storage/JsonAdaptedTask.java
100.00% <ø> (ø)

...in/java/seedu/address/storage/JsonAdaptedToDo.java
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Signal Password Recovery after Backup

Thanks for working on signal, my main messenger :)
Now to the issue: Currently backing up signal is a bit of a pain; I cannot update it along with my other android applications using oandbackup; initially it seems to work but, when I try to restore signal on the same phone, I just get error messages.
This is a major pain, mostly because it comes so unexpected; there is no warning during backup, it just fails on restore.
The current solution is to use the signal backup feature; unfortunately this still falls short, for to reasons: (1) it is a bit of a pain to have to backup signal separately (2) the actual encryption/authentification keys are not backed up.
The latter is an issue, because at least my contacts have by now been trained to simply disregard notifications of my security number changing, because I had two phones breaking this year.
In order to remedy this situation, I suggest introducing a restore key/password; this key could be user chosen or could be issued on the first install. I could safely store it in my gpg encrypted password manager on my laptop and just use that to unlock my signal instance after any backup.

Argh. Wrong project. Disregard me.


Pin nightlies to previous night

Fixes some upstream breakage in rust-lang/rust which should get fixed
tomorrow.

Looks like https://github.com/bytecodealliance/wasmtime/issues/1813 is hitting on beta now (presumably due to the rust-lang/rust LLVM upgrade), so going to try to fix that here too.


Ansible request for Windows: Short Names for Folders enabled by default

[ ] Missing install
[ ] Bug in ansible playbook
[x] Request for new playbook addition

Details:
When passing a path into a Makefile on Windows, we need to use the shortened version of each folder name if it contains a space. Since several Windows machines (including) lack these short names for some folders, that is causing problems.
One specific case is the CUDA issue, where we (currently) can't pass configure variables into the scripts if they contain spaces, because the speech marks get excised and each continuous chunk of text is treated as a separate argument (it seems).
So if all folders on all Windows machines could have these short names automatically added by default, that'd be ideal.
If that's too big, the specific CUDA case only requires two folders (below) to have shortened names. If these could have their short names generated by default, that would solve this specific case.

C:/Program Files
C:/Program Files/NVIDIA GPU Computing Toolkit

I believe https://github.com/AdoptOpenJDK/openjdk-infrastructure/pull/1250/files already implements this on the C: drive, therefore this shold not be a problem for future machines installs.

Unfortunately, the referenced issue is only for Program Files (x86), not Program Files. While the task to enable shortnames on the C: drive will create shortnames when there's a new directory, it won't assign shortnames to directories from before it was enabled.
The other issue, is that if a Windows Machine given to us from a provider doesn't already have Shortnames enabled, the C:/Program Files can't have one assigned unless booting it into safe-mode, as something will always be using the C:/Program Files folder (or having someone manually go on the machine, stop all the processes that are running on the machine, and doing it manually). In other words, I don't think this can necessarily be done through the playbooks.

@Willsparker - Sounds like a conversation for https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1731
You're right, changing the playbooks won't fix things retroactively. Manual intervention would be required.
I didn't know you had to stop all processes accessing a folder before you could set a short name though. It may be necessary though, if we're going to enable cuda support for openj9 builds again.


Performance - Only wrap returned nodes for methods that return a subset of node's children

Methods like getChildByKind should only wrap the node that they return.
I also think that methods that use a predicate should create a temporary wrapped node if the node doesn't exist:
.getFirstChild(c => c.getName() === "some name")

This is basically already done now in the methods. It's not worth using a temporary wrapped node for the delegates because people sometimes do crazy stuff in delegates:
const nodes: Node[] = [];
node.getFirstChild(node => {
    nodes.push(node); // crazy
    return true;
});
nodes[0].getPos(); // error, if forgotten


change opt treatment and device policy to enum values

Fixes #194

Jenkins please retry a build

Jenkins please retry a build

Jenkins please retry a build

@mansishr can you please resolve the conflicts and request for review again?


purchaseUpdatedListener is always called at start-up (Amazon)

Version of react-native-iap
5.2.0
Version of react-native
0.63.3
Platforms you faced the error (IOS or Android or both?)
Android
Expected behavior
purchaseUpdatedListener should only be called when a user subscribes for in-app subscriptions
Actual behavior
purchaseUpdatedListener is called at start up (once the listener is registered)
Tested environment (Emulator? Real Device?)
Real device, GalaxyS9, Android 10
Steps to reproduce the behavior

Install an app from Amazon Store
listen to purchaseUpdatedListener events

@iaphub Do you have any idea with this?

I don't see the issue, don't think we should prevent amazon from triggering a receipt, we're just a wrapper around the library.

This works as designed, please see the SDK's documentation here: https://developer.amazon.com/docs/in-app-purchasing/iap-implement-iap.html#3-get-user-information in your code you can decide when/if you want to trigger some logic on the purchase listener. Closing for now, feel free to reopen if more information


Revert "Add example for Haskell Stack"

Reverts actions/cache#173

master branch is not active, so retaining its old state.


Java getting started more updates

This PR https://github.com/open-telemetry/opentelemetry.io/pull/2652 and https://github.com/open-telemetry/opentelemetry.io/pull/2653 create some consistency across python, java & Node.JS documentation.
Preview:
https://deploy-preview-2651--opentelemetry.netlify.app/docs/instrumentation/java/getting-started/

@chalin also here, once again thank you for your reviews:-) Any more thoughts?

... once the formatting and link issues are addressed :)


Update token-info-storage-enq.json

Added token_id, website, and description in english.

81c06ab1bf28da08d2b75493831f12390cabbbffb4b14a38a23caeae39a70424


When plugin setting is protected or set in env or meltano.yml, only text fields are disabled

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1711
Originally created by @DouweM on 2020-02-12 21:39:15

I ran into this while debugging https://gitlab.com/meltano/meltano/issues/1677, where the checkbox should be disabled when the value was set in the environment, but wasn't.

View 2 previous comments from the original issue on GitLab


Incorrect Email Notification for Payment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.76-12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation (hyperlinked to channel name): expensify_bugs
Action Performed:

Open a direct message (DM) chat.
Use the grey "+" button to send a payment (e.g., $1) to another user
Observe the email notification sent to the sender instead of the recipient.

Expected Result:
The email notification regarding the payment should be sent to the recipient
Actual Result:
The sender received the email notification intended for the recipient.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

I just got this email, which seems correct:

I agree that we shouldn't send that second email to the payment sender (Please pay my $1.00 expense), but I'm not sure if we want to send the correct email to both the sender & recipient or just the recipient. I asked for clarification on expected behavior in the original thread.
I also asked in #engineering whether this is internal or external: https://expensify.slack.com/archives/C03SSAQ7P/p1734563297141249

I got confirmation that this is an internal issue.

Adding to the expense project.


Abstract scrolling WIP

This PR extracts a "scrollable" component in for better separation of responsibilities and to prepare for alternate implementations of scrolling (JS-based virtual scrolling to support UIWebView usage in particular).
Several changes will be required for users of master once this is merged:

Update your CSS to account for an additional div. Structure is now:

div.ember-collection
    div (from ember-native-scrollable)
        div (wraps all content)
            divs (cells)

Use CSS to specify height/width of div surrounding ember-collection. ember-collection now detects and adjusts it's size based on it's container. The width and height attributes are not longer used. For initial render (including fast-boot future), you should supply estimated-width and estimated-height attributes.

offset-x and offset-y attributes have been renamed to scroll-left and scroll-top

If you have custom layouts, the expected API has changed. You should replace your contentWidth and contentHeight methods with a contentSize method that accepts and clientSize object with width and height properties, and returns an object with the same property names representing the total content size.


Cache rendered pages

Cache rendered pages of PWAs in memcache
Cache rendered detail page for each PWA in memcache
Invalidates cache when new PWA is added
Invalidates cache when PWA is updated

Fixed the comments.


Which version to use for "Yi 1080p Dome", h20m, Hardware ID 45US

Hello,
many thanks for your time.
I'm not sure which version is compatible for my camera
"Yi 1080p Dome", h20m, Hardware ID 45US
Is it compatible?
Many thanks,
Patrick

Check this:
https://github.com/TheCrypt0/yi-hack-v4
or this:
https://github.com/alienatedsec/yi-hack-v5

@roleoroleo Thanks for your answer.
I will check.
Does the backup and unbrick procedure will also work for this versions?
Best wishes,
Patrick

I don't know.


After click open button from file picker, nothing will happens, just open button disabled

After click open button from file picker, nothing will happens, just open button disabled
My library is http://js.live.net/v5.0/wl.js, and the log in console is:
Picker on inited
The picker process has completed.

If open successfully, it should be follow a '[WL]onPickerComplete' log.
I cannot find the root cause, anyone can help me to check this issue?
BTW, it works well for a long time, it's just happened in these days. I think it's caused by wl.skydrivepicker.js change.

I found if I invoke WL.getSession() after login and then invoke WL.fileDialog, this issue will always happen.

@daboxu Can you see what might be going on here?
@benjaminliugang The v5.0 picker is pretty old now. Is it possible your site can update to the v6 or v7 picker experience, which enables OneDrive and OneDrive for Business support and a more modern and robust SDK?

Thank you @rgregg, I will try to upgrade oneDrive to latest version for our product. But for our old release  versions, we still need to fix this issue with the old oneDrive(v5.0).
BTW, If I use v7.0, how to support locals? Do we have some references?

One reproduce step update: I just use WL.fileDialog to open popup dialog not OneDrive.open function.

Hi @daboxu, do you have any ideas about these issues?

Hi @benjaminliugang , do you have a fiddler trace for your call? I cannot figure out the root cause based on the context. If you have an online demo app for testing, that will be better.
For the v7.0, we do not show the user account information dialog anymore, probably what you want is making request to (GraphAPI)[http://graph.microsoft.io/en-us/docs] via  https://graph.microsoft.com/v1.0/me to get these information back.
We move the documentation to https://dev.onedrive.com/sdk/js-v7/js-picker-overview.htm for better user experience.
@rgregg I think we support locale according to users' setting right?

Hi @rgregg , today I cannot reproduce the open button disabled issue. Actually, we didn't made any change about oneDrive in our product. Is there any change about it in your part?
Since this issue cannot reproduce in our product, we still use the live SDK(https://msdn.microsoft.com/en-us/library/hh243643.aspx) in our product. So I just want to confirm, is your team always support these apis(WL.init, WL.login, WL.fileDialog ...)?

The Live SDK and the Live Connect API are still supported, but we discourage their usage. Already some scenarios relating to parts of the Live SDK are no longer functional, like access to mail, calendar, and contacts, for some users. We expect to deprecate the whole Live SDK in the future. I'd recommend finding time to migrate to the new onedrive.js in the near future.

Thanks @rgregg , we will do it in our future. Already add the upgrade task in our backlog.


src/net: net.InterfaceAddrs may return error due to a race condition when interface is deleted

Go version
all the version
Output of go env in your module/workspace:
go version go1.23.3 linux/amd64
[root@VM-137-208-tencentos golang_bin]# go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.woa.com+643d7a06+Ac5f5VOC4N8NUXdmhbm8pZSXIWfhek5JSmWdWrq7pLX4'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.3'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/root/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3294369079=/tmp/go-build -gno-record-gcc-switches'

What did you do?
kube-proxy: net.InterfaceAddrs may return error due to a race condition, causing the Nodeport Service to be inaccessible
https://github.com/kubernetes/kubernetes/issues/129146
1, syncProxyRules->GetNodeIPs->net.InterfaceAddrs()->interfaceAddrTable(which is in interface_linux.go for Linux)->syscall.NetlinkRIB(syscall.RTM_GETADDR, syscall.AF_UNSPEC) is called.
2. Then an interface is delete by CNI.
3. Then interfaceAddrTable(which is in interface_linux.go) call interfaceTable(which is in interface_linux.go)->syscall.NetlinkRIB(syscall.RTM_GETLINK, syscall.AF_UNSPEC)
The key point is that, RTM_GETADDR's return have the delete interface, but the RTM_GETLINK's return donot have the deleted interface.
4. Then in interfaceAddrTable->addrTable will return err.

5. Then the syncProxyRules will not write correct forward configuration because the GetNodeIPs's return donot have any ip.
What did you see happen?
net.InterfaceAddrs should not return err and nil when this is a lot interface on the linux operating system.
What did you expect to see?
net.InterfaceAddrs should return correct addr the exist on the linux operating system.

Duplicate of #51934

@seankhliao

This issue analyzes the cause of the problem.
The PR for this problem: https://github.com/golang/go/pull/70768


[FLINK-12029][table] Add column operations for TableApi

What is the purpose of the change
This pull request adds column operations for TableApi. Column oprations can be used to select or deselect columns. More details can be found in the google design doc.
Brief change log

Add different columns operations for TableApi.
Add Tests
Add document

Verifying this change
This change added tests and can be verified as follows:

Added integration test testColumnOperations in CalcITCase.
Add ColumnsOperationTest to test column operations in different table operations.
Add validation tests ColumnsOperationValidationTest to test exceptions.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@flinkbot approve description
@flinkbot approve consensus
Hi, @hequn8128 Thanks for the PR，before starting the detailed review, I suggest paying attention to the comments in the google doc, due to there is some detail discussing for this JIRA. (such as the comment I left above.) :)
Best,Jincheng

@flinkbot attention @twalthr

@flinkbot approve-until

@sunjincheng121 Thanks a lot for your review. I have updated the PR according to your suggestions.
Best, Hequn

@sunjincheng121 Thanks for your valuable suggestions. It makes the PR much better. I have addressed all your comments and updated the PR. Would be great if you can take another look. Thank you.

@sunjincheng121 Sounds good. I will rebase the PR once FLINK-11884 is merged. Would be great if @dawidwys can also take a look at that time.
Best, Hequn

Thank you for understanding! Will definitely look once it will be rebased on the merged changes.

Hi @hequn8128,
The commit(413e3feb786df9b0df951eae7e942ac45ba3d22a) that introduces ExpressionResolver and ResolverRules was merged. I think you can rebase those changes on top of current master now and proceed with this PR.
Also thank you again for waiting for that change!

@dawidwys Cool. Great job for the ExpressionResolver and ResolverRules.
I will rebase this PR soon. Thank you for letting me know.

@sunjincheng121 @dawidwys I have updated the PR. Would be great if you can take another look. :-)

Thanks for the contribution @hequn8128. I haven't had a look at the code but at the API again.
I still find the columns(...) vs. -columns(...) confusing. Why not making it more explicit and fluent, e.g. withColumns(...) vs. withoutColumns(...). There are a couple of advantages:

It reads nicely: "select with columns 1 to 5" or "udagg with columns 1 to 5".
When I saw the design doc the first time, I thought users can do things like columns(1 to 5)-columns(2) (so not just unary minus).
It avoids ambiguity. Because a column operation with a single column could be misinterpreted. Take select(-columns('a)) for a schema ('a, 'b) as an example. Given that a columns(...) is just defined as a replacement operation. This could be interpreted as select(-'a) or select('b).
We already need to keep a new Java DSL in mind. withColumns() and withoutColumns() can be easily expressed in Java. The current design would look like select(minus(columns(...))).

What do you think?

At the beginning of the design, we refer to the operation of the R language column, using the - flag in R, and the Scala language is also easy to support -, of course, we did not consider the upcoming new Java DSL, although columns(...) and -columns(...) are very concise, but for the description of java DSL, I agree with Timo's proposal.

@twalthr @sunjincheng121 OK. Let's do it with withColumns() and withoutColumns(). I will update this PR once FLINK-12174 is merged.
Best, Hequn

@sunjincheng121 @twalthr @dawidwys Thanks a lot for your great suggestions. I have updated the PR and rebased to the master. Would be great if you can take another look. Thank you very much!
Best, Hequn

@sunjincheng121 Thank you for the review. I have renamed these "column operation" to "column function". So in Table API, column operations means Table.addColumns()/Table.dropColumns, and column functions means withColumns/withoutColumns. I think it's more clear now.
Best, Hequn

+1 to merged..

@flinkbot approve all


[RV_DM]rv_dm_progbuf_read_write_execute_vseq

This PR is to resolve conflicts that #21544 contains.

Rather than lose the history on the original PR, I've just rebased it for you and re-opened the original. Let's stay in #21544.


Add/Fix some Korean translations

I've added more translatable strings in https://github.com/Fate-Grand-Automata/FGA/commit/ea8ebf4305cbddc6761e3450e8d3d8ac233daf70#diff-2d207ac16b141c7910606683e804e844a24ef211c6210e4f1842673f396495e8

@reconman I checked and add more translated strings.

oh, I use neovim only this time. I will check that comment next time!


Subspace pursuit sparse source localisation

Describe the new feature or enhancement
Hi, a while ago I implemented the the subspace pursuit algorithm for sparse source localisation described here:
https://www.sciencedirect.com/science/article/abs/pii/S1053811913009440
I wonder if there is interest in adding it to the already existing suite of tools for sparse source localisation?
Describe your proposed implementation
The branch is found here, if memory serves me correctly I followed the paper pretty closely:
https://github.com/jshanna100/mne-python/tree/greedy
Describe possible alternatives
The authors of the paper do state that their code is available on request, but I never had any luck getting it from them, which is why I did my own implementation.
Additional context
No response

@agramfort WDYT about adding subspace pursuit?

no strong feeling here. I just fear that the interaction with a hierarchical source space is a bit harder than the other solvers we have.


Check that PerThing valid on decode

Partly addresses https://github.com/paritytech/substrate/issues/5462
To support Compact we need some changes in scale-codec before.

This entirely address the issue, I just mixed myself when saying using compact.
also I'm not sure using compact for Perthing is very necessary as I expect as much close to ACCURACY as value close to 0


[Bug]:  Dark Mode Fixed

A bug crashing the application
When we switch between the dark and light mode while the application is running it crashes.
https://user-images.githubusercontent.com/55978642/218827336-db28bdc6-9f71-497c-9b06-73ec5178c6d4.mp4

A bug crashing the application
When we switch between the dark and light mode while the application is running it crashes.
Kindly Assign me this problem so i can start working on it
https://user-images.githubusercontent.com/55978642/218827336-db28bdc6-9f71-497c-9b06-73ec5178c6d4.mp4

@maityamit Anyone working on this issue ? If no then can I work on this issue ?

@Poras-oss any progress ?

@Poras-oss any progress ?

I have set up the working environment and I am very close to debugging it. However, I am encountering an error message that says "DEVELOPER_ERROR". I searched for a solution on Stack Overflow, and one suggestion was to add the SHA1 fingerprint. I have already done this, but I am still experiencing the error.
I want to assure you that I will fix this issue soon. I also want to mention that I have been busy preparing for Mahashivratri for the past few days, but I will be free today and will start working on the problem as soon as possible.

Update
I've identified that the issue is not with the application code, but rather with the external calendar library. As a result, I'm considering changing the library. Would that be a viable solution?

@Poras-oss No, please don't change the library.

@Poras-oss No, please don't change the library.

@maityamit Okay, I won't change the library. However, even without the library, the error should not be fixed. Additionally, the app is crashing when switching between orientations. To address this, I will set the orientation to vertical only.
I would also like to add that the CONTRIBUTION document, which includes instructions for setting up the environment, is missing an important step for adding the server-client ID.
Should I add the instruction to the CONTRIBUTION file?

@Poras-oss
ya, You can add that instruction. Please open a new issue for that.
And you can open another issue for setting orientation to vertical.

Hello @maityamit, I want to work on this issue under CodePeak23 please assign it to me


Remove Stackdriver Logs Viewer

The current version tries to emulate the cloud console too much. It should be rewritten to have easier to use filters, better working code linking, and easier to read messages.

@ILMTitan I don't know that we should remove this.  I think we may want to keep it and improve what we have or maybe re-implement?

Changed title from "Remove" to "Rewrite", removed from 2.0.0 milestone, downgraded to P2.


FastHttpUser does not pass headers correctly during a retry after a "failure exception" such as timeout

Prerequisites

[X] I am using the latest version of Locust
[X] I am reporting a bug, not asking a question

Description
Issue: We are testing a system with locust that cannot handle the intended load, and thus the system eventually starts producing timeouts and dropping some connections. During these tests, we started noticing errors where the system was complaining about us sending requests with invalid content-type (text/plain instead of application/json). We noticed that the content-type header was passed twice to the target app, once in Upper-Case and once in lower-case.
Investigation (TLDR at bottom): Here is an example entry from our locust logs:
Failure: POST <address>, code=400 - <cut content> headers: {'API_TOKEN': '<API_TOKEN>', 'Content-Type': 'application/json', 'USER_ID': '<testid>' Accept-Encoding': 'gzip, deflate', 'Accept': 'application/json', 'content-type': 'text/plain; charset=utf-8', 'content-length': 204}
FastHttpSession ~retries sending requests~ in _send_request_safe_mode after a FAILURE_EXCEPTION on fasthttp.py row 167, in case the exception has no 'response' attribute:
locust.contrib.fasthttp.py:
        try:
            return self.client.urlopen(url, method=method, **kwargs)
        except FAILURE_EXCEPTIONS as e:
            if hasattr(e, "response"):
                r = e.response
            else:
                req = self.client._make_request(
                    url,
                    method=method,
                    headers=kwargs.get("headers"),
                    payload=kwargs.get("payload"),
                    params=kwargs.get("params"),
                )
                r = ErrorResponse(url=url, request=req)
            r.error = e
            return r

However, the second call uses an internal geventhttpclient UserAgent method, _make_request. After investigating further, the underlying geventhttpclient UserAgent urlopen method takes the headers it receives, and uses a Headers object to update its internal default headers with the given headers (with the given headers containing the correct content-type in our case, application/json):
geventhttpclient.useragent.py:
    def urlopen(
        self,
        url,
        method="GET",
        response_codes=valid_response_codes,
        headers=None,
        payload=None,
        to_string=False,
        debug_stream=None,
        params=None,
        max_retries=None,
        max_redirects=None,
        files=None,
        **kw,
    ):
        """Open a URL, do retries and redirects and verify the status code"""
        # POST or GET parameters can be passed in **kw
        # self.default_headers is a Headers object, not a dict
        req_headers = self.default_headers.copy()
        if headers:
            req_headers.update(headers)
        ...
        req = _make_request(
            url,
            method,
            headers=req_headers,
            payload=payload,
            params=params,
            files=files,
            request_type=self.request_type,
        )

This works fine, since the Headers takes into consideration that we're passing content-type as uppercase, 'Content-Type': 'application/json'. The geventhttpclient Headers object tries to preserve the case of the original header, while still performingHeaders.get case-insensitively. However, the _make_request method does not convert the given dict to a Headers object, and when used directly, we bypass the conversion from dict to a Headers -object. Thus the .get below is done case-sensitively during the retry in locust's FastHttpSession.
geventhttpclient.useragent.py:
def _make_request(
    url, method, headers, payload=None, params=None, files=None, request_type=CompatRequest
):
    # Adjust headers depending on payload content
    content_type = headers.get("content-type", None)
    if files:
        ...
    elif payload:
        if isinstance(payload, dict):
            ...
        elif not content_type and isinstance(payload, str):
            headers["content-type"] = "text/plain; charset=utf-8"
            payload = payload.encode()
            headers["content-length"] = len(payload)
        elif not content_type:
            ...

    return request_type(url, method=method, headers=headers, payload=payload, params=params)

Since the dict.get cannot find the upper-case 'Content-Type', the code ends in the elif not content_type and isinstance(payload, str): block (cause the payload content has been converted to str earlier in locust). After this, headers will contain a lowercase 'content-type': 'text/plain; charset=utf-8', added by the above block of code. This was a duplicate 'content-type' header in our case, and our system picked up that one instead of the correct 'Content-Type': 'application/json'
TLDR: The problem can be solved by passing the headers to the _make_request as a Headers object. I think the problem was introduced by this geventhttpclient commit, though I think that the underlying issue is how locust utilizes geventhttpclient.
I have a commit in a fork of locust which seems to solve the problem (for some reason the python 3.10 tests failed). However, the fix feels like a bit of a hack. It may be better to make the commit to geventhttpclient.UserAgent._make_request, since that method only exists because of locust. It would be even better if locust did not depend on the internals of geventhttpclient, as discussed in this issue.
Command line
locust -f mylocustfile.py -t 10s --headless
Locustfile contents
'''
Any locustfile using FastHttpUser should be able to trigger the issue,
as long as the receiving endpoint expects json,
the headers given to FastHttpSession contain 'Content-Type':  'application/json',
and the requests results in one of the following exceptions:
'''

FAILURE_EXCEPTIONS = (
    ConnectionError,
    ConnectionRefusedError,
    ConnectionResetError,
    socket.error,
    SSLError,
    Timeout,
    HTTPConnectionClosed,
)

Python version
3.11.2
Locust version
2.35.1
Operating system
Ubuntu 20.04

Thanks for the deep analysis! We have a different ticket open for using geventhttpclient’s UserAgent https://github.com/locustio/locust/issues/2681
Do you think that would that solve this issue?

I might have been too hasty in my original analysis. geventhttpclient's UserAgent does not send a request when calling _make_request, it only builds one. However, I think the _make_request is still responsible for adding a lowercase 'content-type': 'text/plain; text/plain; charset=utf-8', since we only use json, and we pass Content-Type using capital letters, and _make_request` suspiciously enough adds it lowercase as we observed in our logs.

Thanks for the deep analysis! We have a different ticket open for using geventhttpclient’s UserAgent #2681
Do you think that would that solve this issue?

I think the problem is with FastHttpSession relying LocustUserAgent and thus geventhttpclient UserAgent's internal implementation, namely _make_request. Though as I said above, I need to investigate this further, as _make_request did not behave as I expected. This could still be my mistake in the script, even though the commit I posted above seemed to fix the problem.
On a side note, it looks like LocustUserAgent overrides geventhttpclient UserAgent's _urlopen, even though the implementation seems identical.

Yea the implementation in Locust was copied over to geventhttpclient (because it could be useful to others as well, not just Locust :)


Option for naming each run through amplfi-init

Added a parser to name each run, so the runs are contained in a parent directory defined by --directory and each run is in a subdirectory defined by --name.
I was trying to go for a structure like this:
└── amplfi-runs
    ├── data
    │   ├── condor
    │   ├── test
    │   └── train
    ├── first-run
    │   ├── cbc.yaml
    │   ├── datagen.cfg
    │   └── run.sh
    └── second-run
        ├── cbc.yaml
        ├── datagen.cfg
        └── run.sh

Though, I'm not exactly sure where the condor directory would go.

@ravioli1369 is the idea that most of your runs will be stored in this parent directory, so you don't want to have to specify that path each time? If so, let's make --directory optional, and if not passed have it read from an environment variable like AMPLFI_RUNS.

@EthanMarx yea, that makes sense. The rest is good to go?

@ravioli1369 one minor tweak but then yes this is great


fix(wizard): update styles of wizard

update the styles of the wizard to use variables where necessary, as well as overall code cleanup
closes #588

@mindreeper2420 snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1571-fabric8-ui.int.rdu2c.fabric8.io


Remove the static getters in the AI Engine class

the correct pattern is to always access properties though the instance variable

this is done


correct spelling

spelling (min, not mix!) 👍
sidenote:  kinda funny that i haven't found any other knob/ui library using hooks, since it's such a good fit. thanks for creating this!

Thanks.


Simplify ImmutableJSONData in prep for bigger change

The medium term plan is to roll ImmutableJSONData into a JSONModel type and not make it pluggable as such.  Instead make JSONModel support encodings via RegisterEncoding or some such method instead.

Codecov Report

Merging #124 into master will increase coverage by 1.06%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   90.23%   91.29%   +1.06%
==========================================
  Files          20       20
  Lines        1382     1367      -15
==========================================
+ Hits         1247     1248       +1
+ Misses         81       66      -15
+ Partials       54       53       -1

Flag
Coverage Δ

#dot
91.29% <20%> (+1.06%)
:arrow_up:

#dot_data
65.78% <ø> (ø)
:arrow_up:

#dot_sync
87.03% <ø> (ø)
:arrow_up:

#dot_undo
100% <ø> (ø)
:arrow_up:

#dot_x_db_mysql
87.5% <ø> (ø)
:arrow_up:

#dot_x_db_pg
87.95% <ø> (+2.4%)
:arrow_up:

Impacted Files
Coverage Δ

data.go
83.56% <20%> (+13.1%)
:arrow_up:

x/db/pg/pg.go
87.95% <0%> (+2.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21019a...078e72d. Read the comment docs.


Paint Example

This PR adds a paint application to the examples.
PS: I didn't expect it to get this large but I might as well make a PR for this.

Very cool! Code looks quite good as well.
I think this is worth a repository of its own, however.


Return an EventLoopFuture in IRCClient.connect

Instead of returning Void, return a future in the connect method to allow callers to perform additional operations after connecting successfully (e.g. to join specific channels).

Shouldn't joining channels happen after the user got registered in IRC, vs after the TCP connect?
E.g. using this delegate callback?:
  func client(_ client        : IRCClient,
              registered nick : IRCNickName,
              with   userInfo : IRCUserInfo)

Yeah, I guess that would be a better solution. But having the ability to schedule things after a successful connect seems useful to me still.

If we really. want to have this, we should add a delegate method for that instead (clientWill/DidConnect). But again, not sure of the actual use case.
The API is intentionally not NIO future based and I don't want to leak those to the user.
(also, if the connect API would return a future, it should reflect a successful IRC connection setup, not a TCP connect - that's what the API suggests)
If you really really want it, feel free to adjust the PR to do the delegate thing. But I guess it's not really required?

Ok, I realize this isn't really as needed as I thought it would be. I am going to close the PR for now.


Update Go to 1.18.3

https://groups.google.com/g/golang-announce/c/TzIC9-t8Ytg

Did some testing but getting inconsistent results - planning to test further.


Add WebAPI 7.5.1 release note

Docs Build status updates of commit 41372cb:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/changelog/webapi-7x.md
:warning:Warning
View
Details

Odata-docs/changelog/webapi-7x.md

Line 5, Column 12: [Warning-ms-author-invalid] Invalid value for 'ms.author', 'madansr7' is not a valid Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Electroncash 2.9.4 crashes if entering password

I downloaded the new version 2.9.4. for MacOS and tried running the wallet from my 2.9.3. file. If I enter my password and press next, the client crashes.

I also tried recovering the wallet with an existing seed, but that doesn't work also. And when I tried to use 'zbar' to scan QR back-up code, the client also crashes.

a few people have been reporting this issue.  workaround for now is to create a new wallet for 2.9.4 with the same seed.

is this 2fa?

I have already tried creating a new wallet with the same seed, but I can't press 'Next' after writing out my 12-word seed. I have already disabled 2fa through the method described in #41

Is there still anywhere a download for 2.9.3, so I can use that wallet to send my funds to another wallet? I was being too rushed and deleted the 2.9.3 version after installing 2.9.4. Thanks.

It's been solved, found a 2.9.3 version on your github. Thanks anyways!


i18n(es): Updated view-transitions.mdx

What kind of changes does this PR include?

New or updated content
Translated content

Description

What does this PR change? Give us a brief description.
Updated view-transitions.mdx based on this commit 62d78104e0a6e032acb424efa4bdac5730e275be

Muchas gracias por el review @Waxer59 😁


Error: Post "http://<IP_ADDRESS>:11434/api/chat": read tcp <IP_ADDRESS>:49192-><IP_ADDRESS>:11434: wsarecv: An existing connection was forcibly closed by the remote host.

Error: Post "http://<IP_ADDRESS>:11434/api/chat": read tcp <IP_ADDRESS>:49192-><IP_ADDRESS>:11434: wsarecv: An existing connection was forcibly closed by the remote host.

Probably duplicate of #2953

Merging this with #2555

I have the same question，Run gemma:2b is well,but if i create and run a new model by modelfile, the  question appeared
Ollama version : 0.1.29
system：WIN 11 family

I have the same question ，ollama run qwen2:7b
Ollama version : 0.3.6
system：WIN 11


SA1503 - incorrect warning with using declarations

As mentioned in https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3004

I was not able to reproduce this. A test is added in #3076.

This reproduces the warning: https://github.com/trydis/analyzers-repro
Rider JetBrains Rider 2019.2.2
macOS 10.15.1

@trydis Thanks for providing the sample repository! I'm not sure what tool is reporting those warnings, but it's not StyleCop Analyzers. I verified both the IDE and command line build scenarios.

Really confusing, but I guess it's Rider in some way, thanks for looking into it.
Rider settings:
Editor -> Code Style -> Enable StyleCop support: Disabled
Editor -> Inspection Settings -> Roslyn Analyzers -> Enable Roslyn Analyzers: Enabled
I'm able to control it using a ruleset file or #pragma:
<?xml version="1.0" encoding="utf-8"?>
<RuleSet Name="Test" Description="Code analysis rules" ToolsVersion="15.0">
    <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
        <Rule Id="SA1106" Action="None"/>
        <Rule Id="SA1501" Action="None"/>
        <Rule Id="SA1503" Action="None"/>
    </Rules>
</RuleSet>

Mentioning https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3075 for traceability.


[Feature request] Option to disable using golden frames

Golden frames are an easy and effective way to improve metrics, but in some cases the 'poppings' the periodically inserted higher quality frames are causing is quite noticable and looks pretty bad. An option to disable this technique in the command line encoder would be very appreciated.

Do you have a test case or example that exhibits the problem?

Here is an example : http://www.mediafire.com/download/lj66wlhw7chdhc5/poppings.7z
I used the command line: encoder_example -o daala.ogv -v 30 -k 100 source.y4m
The problem occurs at higher quality as well, albeit slightly less annoying. The main issue with the periodic frame-boosting is that in exchange for some efficiency gains you introduce a fairly noticable temporal artifact. Probably this is why that with the exception of the VPX codecs, these kind of techniques aren't really used anywhere else.
I definitely think that an option to disable it would be beneficial.

Enabling b-frames makes the little jumps at the golden frames even more noticeable:
http://www.mediafire.com/download/cmtczp5j3taz493/pop_b.7z
The command line was: encoder_example -o daala_b.ogv -v 28 -b 2 -k 100 source.y4m

Here are three encoded files decodable with current master: 8edf5644873182cebd75bbe294a0554611f56d80
http://jmvalin.ca/video/encodeA.ogv
http://jmvalin.ca/video/encodeB.ogv
http://jmvalin.ca/video/encodeC.ogv
Let me know which you think looks the best

Well, I prefer A, definitely. The golden-frame pops are still a bit noticeable, but much less annoying than in the other 2 videos, though admittedly at a cost of retaining less details.

Interesting. So far we have 3 people preferring C and you preferring A. I guess we need to investigate more.

Try them with b-frames enabled, i think the poppings will be even more obvious

I haven't seen an example of golden frames, yet (I might look at the ogvs)
but this sounds to me like normal I-Frame appearance (like in this video scene: https://youtu.be/BjeCQzv8BjI?t=5m2s , where the background is very noisy and becomes washed out but gets grain again once he stops or moving or an I-Frame comes)
anyways: can't this be used as an idea to give (heavily used) B-Frames a higher quality instead to improve the overall quality and save the bits that are used for that by reducing the overall quality of the I-Frames?
This is just an idea of mine, so just ignore me and my superficial knowledge if this is plain wrong
Regards


Implementing slice on feature matrix X for mean function

As a preface, I am a complete newb to GPflow -- so apologies if this question just seems so completely obvious that you may wonder if I suffer from some form of congenital mental defect -- I probably do.
That said, I want to implement a model with a non-zero mean function as follows:
X = N x D feature matrix
D can be partitioned into d1 and d2 where I want to use d1 for the mean function and d2 for the GP
y = X_d1 * B + GP(X_d2)
I can easily slice the feature matrix into different partitions when creating my kernel, can I do the same when creating the mean function?  If so, how?
Thanks!
-Gau

I request you to watch this video, I feel your concepts about GP are still inchoate . I would also suggest you to study the first two chapters of this fantastic book. I guess after that you would be able to formulate the model properly.

I think it would be quite just to add a slice to an existing mean function. E.g. something like
class SlicedLinear(Linear):
    def __init__(self, slice, A=None, b=None):
        Linear.__init__(self, A=A, b=b)
        self._slice = slice

    @params_as_tensors
    def __call__(self, X):
        return Linear(self, X[self._slice])


Implement --cpu for multi-process lwAFTR

We need to implement a new behavior for --cpu that will work with a multi-process lwAFTR.  Probably `--cpu=N-M,P,Z" or something, and the main process schedules children to CPUs in a round-robin fashion.

Needed for #953.

I think this is done now so I'm closing it.


IndexResponse Version prop is int - shouldn't it int64?

Hi olivere!
Which version of Elastic are you using?
[ ] elastic.v2 (for Elasticsearch 1.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[X] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
Please describe the expected behavior
Please describe the actual behavior
IndexResponse Version prop is int - shouldn't it int64?
type IndexResponse struct {
// TODO _shards { total, failed, successful }
Index   string json:"_index"
Type    string json:"_type"
Id      string json:"_id"
Version int    json:"_version"
Created bool   json:"created"
}
Any steps to reproduce the behavior?
Thanks!
V

Thanks for reporting. I will have to look this up in the Elasticsearch code, and if it's a long there, I'll have to see if this breaking change is worth the change. I can still change it in v6, as I've not tagged 6.0.0 yet (will probably do so over the weekend).

I changed this to int64 in v5 and v6 lately.


Feature idea: Automatically copy favicons to site root

It seems like some services, (some being Bing), only want to use favicons for indexed results if they are stored as favicon.ico in the site root. We could probably add a feature to copy this. Possibly with a config option to opt out if that is for some reason desired.

Closing for now as Bing still is not recognizing the root favicon. Here is the patch for the future.
    public function transferMediaAssets(): void
    {
        $this->needsDirectory(Hyde::siteMediaPath());

        $this->comment('Transferring Media Assets...');
        $this->withProgressBar(MediaFile::files(), function (string $identifier): void {
            $sitePath = Hyde::siteMediaPath($identifier);
            $this->needsParentDirectory($sitePath);
            copy(Hyde::mediaPath($identifier), $sitePath);
        });

        // Copy _media/favicon.ico to the root of the site if it exists
        if (file_exists(Hyde::mediaPath('favicon.ico'))) {
            copy(Hyde::mediaPath('favicon.ico'), Hyde::sitePath('favicon.ico'));
        }

        $this->newLine(2);
    }

Response from the Bing Engineers:

We have a separate engineering team dedicated to addressing favicon-related issues. Once we escalate the problems to them, they will promptly fix the favicon issues.

I can confirm that the HydePHP.com favicon now shows up in Bing after manual intervention. If you also have this issue, you should raise a ticket from the Bing Webmaster Tools and they'll fix it.


x86: uint32_t param keeps changing to 2 bytes

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Attachments
If applicable, please attach any files that caused problems or log files generated by the software.
Environment (please complete the following information):

OS: [e.g. macOS 10.14.2]
Java Version: [e.g. 11.0]
Ghidra Version: [e.g. 9.0]

Additional context
Add any other context about the problem here.

Closing, bad description.


[nodejs] Update test-sensor.js for getStreamProfiles method

Impacted tests: new 0, update 1, delete 0
Unit test platform: Ubuntu 16.04
Unit test result summary: pass 1, fail 0, block 0

LGTM
@tingshao PTAL

LGTM and merge.


proposal: cmd/go/internal/load/pkg.go: PackageList should be available for external import

Proposal Details
To assists in writing dependency tests like these without using "cmd"
https://github.com/vmware-tanzu/velero/blob/3b50436b7382d69998a9073494f5d962b3f75509/pkg/install/import_test.go
func TestPkgImportNoCloudProvider(t *testing.T) {
	_, filename, _, ok := runtime.Caller(0)
	if !ok {
		t.Fatalf("No caller information")
	}
	t.Logf("Current test file path: %s", filename)
	t.Logf("Current test directory: %s", filepath.Dir(filename)) // should be this package name
	// go list -f {{.Deps}} ./<path-to-this-package-dir>
	cmd := exec.Command(
		"go",
		"list",
		"-f",
		"{{.Deps}}",
		".",
	)
	// set cmd.Dir to this package even if executed from different dir
	cmd.Dir = filepath.Dir(filename)
	output, err := cmd.Output()
	require.NoError(t, err)
	// split dep by line, replace space with newline
	deps := strings.ReplaceAll(string(output), " ", "\n")
	require.NotEmpty(t, deps)
	// ignore k8s.io
	k8sio, err := regexp.Compile("^k8s.io")
	require.NoError(t, err)
	cloudProvider, err := regexp.Compile("aws|cloud.google.com|azure")
	require.NoError(t, err)
	cloudProviderDeps := []string{}
	for _, dep := range strings.Split(deps, "\n") {
		if !k8sio.MatchString(dep) {
			if cloudProvider.MatchString(dep) {
				cloudProviderDeps = append(cloudProviderDeps, dep)
			}
		}
	}
	require.Empty(t, cloudProviderDeps)
}

We made a decision long ago that anything that needs to look a list of packages should run the cmd/go program.  We are not going to expose the internals of the cmd/go program for direct linking.
Can you achieve your goals by running cmd/go?

via cmd.Output() yes. Is that what you meant?


Invoke sqrt

Changes to make std_sqrt instances invoke-able.

Change primitive to latch out
Update compile-invoke to allow primitives

Polybench still works with these changes.

Polybench still works with these changes.


:@ reported as an invalid plain value in some flow contexts

Describe the bug
The character sequence :@ is a valid flow plain value, but is reported as invalid in some contexts.
Other sequences involving characters that are barred from starting a plain scalar are also reported as invalid, including `, %, and probably others.
To Reproduce
yaml.parseDocument("[[], :@]")

The reported error is Plain value cannot start with reserved character @ at line 1, column 7:\n\n[[], :@]\n      ^\n
Expected behaviour
A successful parse, with document contents of a sequence with two members (one empty sequence, and the string scalar ":@").
Versions (please complete the following information):

Environment: node v10.20.1
yaml<EMAIL_ADDRESS>
Additional context
I found mixed performance on this example (libfyaml and libyaml both parse successfully, but pyyaml and others do not), so I asked in the main YAML matrix chat. ingy confirmed that the input text is valid yaml, and suggested filing an issue on the yaml test suite, which I will be doing shortly.

ingy further suggested that this might be a regression, and so it is: with<EMAIL_ADDRESS>the repro in the report here works as expected.

See https://spec.yaml.io/main/playground/javascript?input=W1tdLCA6QF0=

Discussion happened in https://matrix.to/#/#chat:yaml.io so read that too...

Thank you for spotting this! This was a lexer bug: a flag for tracking if a flow-collection key is a json-node was not being reset after the , character. The first [] set this flag, and then when parsing :@ it was still mistakenly on, leading to the : to be considered as a separator that does not need a subsequent space, and hence ending up with a mis-parsed value of @, i.e. a reserved character. And that's then the error that you actually saw.

I'm glad the report was helpful.
FWIW, I've upgraded my installation to master, and I can confirm the fix is effective. I really appreciate the super-fast turnaround, thank you for the great library. :smiley:


Amplify CLI 12.10 - No queries found to generate types for

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
18.17.0
Amplify CLI Version
12.10
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
after upgrading to v 12.10, amplify codegen is unable to create the API.ts file and returns the following error: No queries found to generate types for, you may need to run 'codegen statements' first
Expected behavior
API.ts file is generated
Reproduction steps
upgrade to cli v12.10. Run amplify codegen
Project Identifier
No response
Log output

# Put your logs below this line

Additional information
Downgrading to 12.9 resolves the issue
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @farshid1, thank you for reaching out. Could you run amplify diagnose --send-report and provide us the project identifier output from the terminal.additionally, could you provide us the .graphqlconfig.yml file present at the root of the project. transferring to the codegen repository for further assistance.

sure thing.
Project identifier: 6fb09c4a6920b8cb8fb3a5f36cd8597d
.graphqlconfig.yml:
projects:
  flowa:
    schemaPath: amplify/backend/api/flowa/build/schema.graphql
    includes:
      - app/(graphql)/**/*.ts
    excludes:
      - ./amplify/**
    extensions:
      amplify:
        codeGenTarget: typescript
        generatedFileName: app/(graphql)/API.ts
        docsFilePath: app/(graphql)
        region: us-east-1
        apiId: null
        maxDepth: 3
extensions:
  amplify:
    version: 3

Hey @farshid1, thank you for reaching out. Could you run amplify diagnose --send-report and provide us the project identifier output from the terminal.additionally, could you provide us the .graphqlconfig.yml file present at the root of the project. transferring to the codegen repository for further assistance.

sure thing.
Project identifier: 6fb09c4a6920b8cb8fb3a5f36cd8597d
.graphqlconfig.yml:
projects:
  flowa:
    schemaPath: amplify/backend/api/flowa/build/schema.graphql
    includes:
      - app/(graphql)/**/*.ts
    excludes:
      - ./amplify/**
    extensions:
      amplify:
        codeGenTarget: typescript
        generatedFileName: app/(graphql)/API.ts
        docsFilePath: app/(graphql)
        region: us-east-1
        apiId: null
        maxDepth: 3
extensions:
  amplify:
    version: 3

Removing the parenthesis around (graphql) in includes, generatedFileName, and docsFilePath will resolve the issue.
Have you modified .graphqlconfig.yml in the past? I'm not sure where the parenthesis came from.

Please re-open if the issue still exists.

@dpilch thanks for the feedback. I can confirm that removing parenthesis from the directory solves the issue.
FYI, I was using parenthesis in my Next.js project to opt a directory out of routing. But it appears that using _ is the prefer method as parenthesis preserved for route grouping.
I still wonder why this wasn't an issue in previous version of CLI but thank you nevertheless

The glob library we use was recently changed. We were not aware of this use case. Escaping the parentheses might also work here. app/\(graphql\)/**/*.ts.


InputDialog executes self.hide() twice

In gui.py InputDialog is a subclass of GenericDialog. When the OK button is pressed self.hide() is called twice. Once by InputDialog and once by GenericDialog.
This seems wrong to me.
The double hide was an additional cause of instability in #169

Fixed. Thank you so much @KenT2


don't warn on module imports that fail to resolve

As discussed in the test case, valid type-checked programs can be in
this state, so we shouldn't spam the logs about it.

Do I need to do anything to get this merged?


populate /etc/resolv.conf

rkt now provides /etc/resolv.conf in each app's chroot if it does not
exist. If the ACI provides such a file, rkt does not touch it.
The "nameserver" entries come from two sources:

as a comma-separated list from the command line (--dns=xx.xx.xx.xx)
from the selected network (--net=...)

If the 'host' network is requested, it copies /etc/resolv.conf from the
host. If another network is requested, it gets the name servers from the CNI
plugins.
Implementation detail: systemd-nspawn can overwrite /etc/resolv.conf. It
is supposed to overwrite it only when the container uses the host
network namespace.  However, the container network namespace is created
by rkt via CNI and not by systemd-nspawn, so systemd-nspawn is not aware
of the network configuration. As a consequence, we cannot use stage1's
/etc/resolv.conf. Instead, rkt write /etc/rkt-resolv.conf in stage1 and
prepare-app bind-mounts it in stage2's /etc/resolv.conf.
It works in this way:
> $ cat /etc/rkt/net.d/alban.conf
> {
> 	"name": "alban",
> 	"type": "ptp",
> 	"ipMasq": true,
> 	"ipam": {
> 		"type": "host-local",
> 		"subnet": "<IP_ADDRESS>/24",
> 		"routes": [
> 			{ "dst": "<IP_ADDRESS>/0" }
> 		]
> 	},
> 	"dns": [
> 		"<IP_ADDRESS>",
> 		"<IP_ADDRESS>"
> 	]
> }
>
> $ sudo rkt run --net=alban --dns=<IP_ADDRESS>,<IP_ADDRESS> \
> 		sha512-a2fb8f390702 --interactive
> / # cat /etc/resolv.conf
> # Generated by rkt
>
> # Name servers passed on the command line
> nameserver <IP_ADDRESS>
> nameserver <IP_ADDRESS>
>
> # Name servers from CNI
> nameserver <IP_ADDRESS>
> nameserver <IP_ADDRESS>
> / #

TODO:

[x] add parameter --dns
[x] get dns info from CNI
[ ] copy /etc/resolv.conf from host for --net=host
[ ] hard limit of 3 DNS servers (for compatibility with dns resolver)
[ ] changelog
[ ] documentation
[ ] tests

Fixes https://github.com/coreos/rkt/issues/660

Depends on https://github.com/appc/cni/pull/99

Add the dns search domains as well?

@yifan-gu good point, we might also want domain in addition to search. See http://linux.die.net/man/5/resolv.conf.

Postponing this PR: I'll prepare a separate PR for --dns=, --dns-search= etc. without changes on the CNI.

@alban @steveeJ this seem reasonable for 1.1.0?

Yes, it sounds reasonable.

Fixed by #2040


JWT access/refresh tokens implementation

Q
A

Is bugfix?
No

New feature?
Yes

Fixed issues

I've called function called by router "actionSomething", let me know if you think that's good or not

Thanks for your review ! I'll change that !

@alexisljn You can re-review 😄


Remove unused (?) codecov secret

cc @eranra @ronensc @KalmanMeth
I'm not sure who initialized the codecov action, I think Eran?
But afaik the codecov secret is only required for private repos, and moreover, I don't think it is actually set in this workflow because "GitHub’s standard pull_request workflow trigger by default prevents write permissions and secrets access to the target repository.".

Note than in ebpf agent repo, we don't use any codecov secret for that action: https://github.com/netobserv/netobserv-ebpf-agent/blob/main/.github/workflows/pull_request.yml#L26-L31

Codecov Report

Merging #400 (f903c38) into main (9740aa3) will increase coverage by 0.03%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   61.45%   61.48%   +0.03%
==========================================
  Files          91       91
  Lines        6393     6393
==========================================
+ Hits         3929     3931       +2
+ Misses       2226     2225       -1
+ Partials      238      237       -1

Flag
Coverage Δ

unittests
61.48% <ø> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/pipeline/extract/timebased/heap.go
100.00% <0.00%> (+2.17%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

/approve


Unambiguous representation of data types

I noticed that this library uses f32vectors to represent vects, rects, colours, etc. I would like to propose representing them as Scheme record types wrapping blobs.
The advantages are:

A record type allows for type checking, either by using a type predicate procedure, or by using CHICKEN type declarations. With bare f32vectors there is no way to tell the difference between a rect, a line, a RGB colour, or a HSV colour. This makes it impossible to write a polymorphic procedure that works with both RGB colours and HSV colours, for example. It also makes it harder to find bugs where you accidentally pass the wrong type of object.
A record type allows you to abstract the underlying implementation, so you can change it later if optimizations are discovered, without breaking existing user code.
A blob can be wrapped in a locative to use it as a pointer e.g. (c-pointer "cpVect"), which would simplify the function binding code in chicken-chipmunk (no type casting needed), with negligible performance impact.
A blob is guaranteed to match the memory alignment and size of the C struct, no matter the platform or compiler. (This is probably not a problem for the types in this library on most systems, but why risk it?)
A record type holding a blob performs approximately as fast as a numeric vector.

I have made a Gist with a benchmark program I used to test the performance of different ways of representing a struct: pointer to non-managed memory, blob, blob-locative, or f32vector. Instructions are at the top: https://gist.github.com/jacius/a456652332951a9a38fb
Update 2016-05-30: blob-locatives are no longer recommended because they can cause issues when using the record as a key in a hash table.

After discovering an issue in my sdl2 egg, I no longer recommend blob-locatives because they can cause issues when using the record as a key in a hash table. I have updated the issue instead to recommend using blobs, then wrapping them in a locative when passing to C function bindings.
Also, I am happy to implement this change myself, if you are open to accepting it. Just let me know whether or not this is a direction you want to go.


When testing poweroff wait for poweroff detection

Resolves #392

Maybe we should ensure this properly handled in the API?
First thought is to reject poweron requests during poweroff cycle. (Keep it simple rather than being fancy.)

I do like the idea of refusing to change a state if the instance is already in a transition state.

CI failure looks like a flakey network test to me:
shakenfist_ci.tests.test_state_changes.TestStateChanges.test_lifecycle_events
-----------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/tmp/workspace/shakenfist_PR-393/deploy/shakenfist_ci/tests/test_state_changes.py", line 65, in test_lifecycle_events
    self._test_ping(inst['uuid'], self.net['uuid'], ip, True, 10)

      File "/tmp/workspace/shakenfist_PR-393/deploy/shakenfist_ci/base.py", line 120, in _test_ping
    shell=True, check_exit_code=[0, 1])

      File "/usr/local/lib/python3.6/dist-packages/oslo_concurrency/processutils.py", line 434, in execute
    cmd=sanitized_cmd)

    oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.
Command: sudo ip netns exec 949b2aa9-1cb9-421c-b01e-3471a00f7aae ping -c 10 <IP_ADDRESS>
Exit code: 2
Stdout: ''
Stderr: 'connect: Network is unreachable\n'


Enhancement request: Purpose of packages.json is obscure after it's no longer used

After meteorhacks:npm has finished with it, the packages.json file sits empty.  On multi-team member projects, it may not be clear what this file is for since it is not possible to add a comments header to json files.
Could I suggest allowing it to be called npm_packages.json and / or allow it to be located under a subfolder such as /lib/npm.

Closing this in light of upcoming support for npm imports in Meteor 1.3


Release v1.1.4

Pushing new package json
before publishing it on npm
this lib is used from mapstore

There are official newer versions of this library available: we should check if we can just upgrade to an official release (probably yes)

no longer needed


Blacklisted problem

Hi I saw blacklisted_paths in config.yaml
I use customization content pattern, but result is not skip blacklisted_paths path
Does blacklisted_paths work on scan image mode?

Hi, I try to fix this problem
And this is my pull request
https://github.com/deepfence/SecretScanner/pull/45


get mac address for Ethernet adapter  not for wifi adapter

hello all,
Can i get mac address for Ethernet adapter  of device not for WiFi adapter its has different mac address
I want to get that for TV device build on android OS.
see the mac address of my device its different mac address.

Thanks

please i make a new function to get the mac address for the Ethernet and create new api to arrive to this function
Please this function get the Ethernet eth0 of the device
   /**      * Method to Get Device MAC Address For Ethernet       *      * @return MAC Address as String      */     public String getEhernetDeviceMacAddress() {         try {               return loadFileAsString("/sys/class/net/eth0/address")                   .toUpperCase().substring(0, 17);           } catch (IOException e) {               e.printStackTrace();               return null;           }     }
i hope to be helpfull for some body
thanks


Rename EventTypes: Task -> Rally, delete EventManaged

TODO: what to do with EventManaged-specific logic?

FRAGILE: Don't merge this yet.  I'd like to discuss how we handle the commented-out EventManaged logic before we push this into place.

For now, delete and we can always bring it back in.
Also i if you prefix the pr name with wip while it's a work in progress that's our convention to know to not merge yet

@robrich I am good with direction here and agree with @tonysurma on the delete note. If you clean up those conditional bits we should be good to go. Also +1 on the depluralization ;)

Should be good to go now.  Merge when ready.

:shipit:

How are you rebasing these as you merge?  I've not found such a button on GitHub's site.  Awesome, btw.

Will this cause stale data issues for any events currently stored in the db as EventType=1?

@robrich if you can verify no sample data is injected (I doubt it as you would have found it already) I will verify database (on my list of things to do)

I patched sample data generation as I made the changes as they're compile time errors.  :D

yep I figured as such


breaks on data uri

When using data uri's embedded in the css, it breaks stylis parsing.
Reproduction: http://jsbin.com/vetude/edit?js,output
I believe this causes https://github.com/styled-components/styled-components/issues/433

Thanks, will push a patch for this.

@wmertens pushed a patch for this in v1.0.1(supports quoted and non-quoted.), you can try to see if you can break it on the console of https://rawgit.com/thysultan/stylis.js/master/benchmark/index.html, i.e
stylis(`.abc`, `
background-image: url(data:image/png;etc); /* quoting the url doesn't help */
`)

👍 looks great, thanks for your swift response! 🎉


Building on a non-Intel MacBook produces ARM64 images which won't run in an x86_64 cluster

Describe the bug
Building sk-ctrl, sk-tracer, and sk-driver on an ARM64 MacBook builds ARM64 binaries even with the ubuntu:latest Docker build image selected.  We need to cross-compile for x86_64 in this case.
Steps to reproduce

make build img on an ARM MacBook
try to deploy the images to an x86_64 cluster

Expected behavior
It should work

@BigValen has a branch which possibly fixes this, or at least makes it easier:
https://github.com/BigValen/simkube/blob/master/Makefile
Would be nice to also have some instructions for how to use.

Also it would be nice if we can add automated tests for this in GitHub actions.


Implement a heuristic to print some floating pointer numbers more coincely

TOML++ currently forces precision to always be std::numeric_limits<T>::digits10 + 1, by using std::setprecision in its code, which overrides any precision set by user. The reason for the following change is that numbers like 0.3 become unnecessarily long with the default precision settings of 11 symbols. Since the standard already has a way to configure precision, I figured the best way to approach this is to allow to simply disable TOML++'s precision override and let users pass it to the stream themselves.
What does this change do?
Introduces a preprocessor option called TOML_FORMAT_SETPRECISION, which is enabled by default so as to make the old behaviour the default and not break anything. When this is set to 0, TOML++ will not force precision and will allow the user to set their own.
Is it related to an exisiting bug report or feature request?
No
Pre-merge checklist

[x] I've read CONTRIBUTING.md
[x] I've rebased my changes against the current HEAD of origin/master (if necessary)
[x] I've added new test cases to verify my change - no need, probably
[x] I've regenerated toml.hpp (how-to)
[x] I've updated any affected documentation
[x] I've rebuilt and run the tests with at least one of - again, there should be no need for this

[x] Clang 6 or higher
[ ] GCC 7 or higher
[ ] MSVC 19.20 (Visual Studio 2019) or higher

[x] I've added my name to the list of contributors in README.md

Thanks for the contribution but I don't think adding this is a good idea. Even though you've done the sensible thing and made this new behaviour opt-in, I'd suggest a better way to handle this in your own code is to just print the contained value directly (using .get() or similar).
The reason the library behaves this way is for round-trippability. Allowing a fallback to the standard's default precision of 6 (or, indeed, allowing any user-defined precision) just opens me up to bug reports about lost information when re-reading a previously written config file. Instead it's far more maintainable to just avoid the stream formatting state altogether.
Other minor points:

This change won't fall back to the precision set in the user's stream at all, but will instead fall back to the default precision of the local std::ostringstream created in the block inside print_floating_point_to_stream().
It seems this new feature applies only to the stringstream branch; there's a branch to select for the use of std::to_chars from <charconv> where available, too, and that would still print at full precision regardless of the setting of TOML_FORMAT_SETPRECISION.

I'd suggest a better way to handle this in your own code is to just print the contained value directly (using .get() or similar).

How do I do this if I'm printing the whole table? This is a problem that exists when there's a float value in the table, I don't think there's a way to output everything else up to key = and then output the float value in the precision that doesn't expose the flaws of IEEE 754 and make the number far too long even though I just passed 0.3 in.

You'd have to do it recursively using a hand-rolled solution unfortunately. I sympathize that it's not ideal if you want "pretty" floats.

Exactly. But this sounds like a very bad solution. I'd rather solve this problem properly somehow. Maybe introducing a variable into the formatter that controls precision would be better? I'd really like to solve this somehow because I'm probably not the only person who wants this (though there haven't been any reports about this apparently so I can't know).

If you really want to implement a solution to this then yes adding something to the formatters would be the right move. You might consider determining the precision on the fly by doing a log10 on the integral and rational components of each float (or something along those lines), instead of making it user configurable (which I'm against for the reasons I outlined above, and won't accept any PR which does that).
You'd have to pass that precision into the print method, which would mean updating it for the charconv branch, too.

I don't know if a PR can be reopened, but I have pushed a change that, for floating pointer numbers that have <3 positions after the floating point, prints them with just those, and otherwise it prints them with the usual std::numeric_limits<T>::digits10 + 1 precision.

I don't know if a PR can be reopened

Ordinarily they can, except in the specific case that a PR is closed then force-pushed to, for some reason. Not sure why ¯_(ツ)_/¯. Happy for you to submit another PR, sounds like it's heading in the right direction.

Continuation in #89


Add examples

Provide complete coverage of the benchit feature set with one example per feature. Document the examples with a readme file.
Note: don't start this work until the benchit feature set stabilizes.

@danielholanda said: https://github.com/groq/mlagility/pull/44#discussion_r1093695644


Repair setup4 hier case 1 buffer

Changes to resizer to support hierarchy for rebuffer and split load operations only
New test cases: split_load_hier.tcl (shows split load across hierarchy with factoring of nets to minimize punch through), resize1_hier.tcl (shows rebuffering and resizing with hierarchical design).
Key changes:

Journalling (dbJournal.cpp) to support hierarchical net connection/disconnection.
Propagation of modnets in rebuffering. (eg rebuffer.cc,  RepairSetup.cc)
Wherever parasitics updated make sure a modnet is not used.

This is a substantial change so marked as draft until Matt and I have gone through changes.

Matt, ready for review. This one just has split_loads and rebuffer support for hierarchy.

secure CI testing started

The CI tests all passed 😄