DependsOn ordering in tests

Migrating this issue from the taskcat/taskcat-v9 repo, as it's now archived.

A need has been identified to serialze test runs via DependsOn. The use-case involves using multiple CFN Stacks to 1) build infra, and 2) run integration tests. Running the integration tests in parallel as the infra is being built does not lead to a desired outcome.

from @jaymccon :

thinking about this, implicit dependencies should be pretty easy to do if we have a new magic parameter, something like $[taskcat_output_MyTestName_MyOutputName] would fetch the MyOutputName output from the stack created by the MyTestName test

Hi @andrew-glenn - Do you happen to know when Taskcat 1.0 might be released with this feature?

@jeffreycoe the original intent was that v1.0 would be in 2020. However, with everything else going on in the world these days, that timeline isn't something that we feel we can meet.
However - if you have a need for it, especially if it would empower production usage, I can prioritize specific features such as this ahead of v1.0. I don't have an ETA either way but context will enable me to shuffle things around.

@andrew-glenn We’re building out our CI pipelines now for our CloudFormation templates, and have been investigating using Taskcat to help drive our CI tests.  One specific use case we have is around EKS.  We were attempting to use Taskcat to test our EKS worker node stacks, but it’s dependent on having an EKS cluster deployed first. Since we don’t have this feature, we’re stuck with creating custom scripts to run our tests.
I completely understand how priorities can change, though. This would definitely assist us with our pipelines by simplifying them, and would provide some help with getting to production. As we’re just one AWS user out of the many, I would not want you to reprioritize other higher priority work for this one feature if it’s not a critical feature the rest of the community needs right now. Also, I can try to assist with this in any way I can (although my python skills are a bit rusty right now).

@jeffreycoe I'm just now seeing this, but it helps identify the pain you're experiencing without it.
In your example, your tests would first deploy an EKS cluster with a test named eks-cluster-provisioning, then when that passed, provision eks-worker-node-stacks using DependsOn?.

@andrew-glenn Yes, exactly. Also as an example, the AWS Quick Start templates use CloudFormation custom resources to do some configuration with the EKS cluster once it's online. We'd have to use DependsOn on those custom resources as we'd have to wait for the EKS cluster resource to complete its provisioning process before they can be executed.
Here are some example templates: https://github.com/aws-quickstart/quickstart-amazon-eks/tree/main/templates

We use cloudformation to do layered deployments. i.e. separate cfn templates are used to create separate layers.
DependsOn along with being able to take output and use it in the dependent test would work great for us.


[HOLD for payment 2023-12-20] [$500] Copy to Clipboard- Email displayed inconsistently in mweb and Android

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.96-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Launch app
Tap on a report
Send the mail<EMAIL_ADDRESS>Long press the message sent and note the email displayed in copy to clipboard section
Go to https://staging.new.expensify.com/
Repeat step 2 -- step 4

Expected Result:
In Copy to clipboard section, in both mweb and Android, email should be displayed in the same format in a consistent manner.
Actual Result:
Copy to clipboard section in(.com) shows till "c" in one line (applausetester+06075lsn@
applause.expensifail.c
om) in mweb and shows(.com) in second line (applausetester+06075lsn@
applause.expensifail
.com) in Android.
The displayed email format differs and it is inconsistent in mweb and Android.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/115492554/f6f3fa41-8a7d-44e9-9c08-f52264560f10

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0123a768f29d8cc1b6
Upwork Job ID:<PHONE_NUMBER>279923712
Last Price Increase: 2023-11-07

Issue OwnerCurrent Issue Owner: @kevinksullivan

Hi, I'm Artur from Callstack - expert contributor group - and I would like to work on this issue.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~014114c159b515fad8

Thanks for the interest @artus9033. Can you post a small proposal with what changes so that we're aligned.
🎀 👀 🎀 C+ reviewed.

Getting Callstack involved sounds good to me

@Julesssss thanks, however from mail notifications it seems like something strange happened and somebody assigned their Upwork details through melvinbot? It definitely wasn't me. Could you take a look at this and unassign if that's what happened?

however from mail notifications it seems like something strange happened and somebody assigned their Upwork details as mine through melvinbot?

Can you forward the email to me please, I'm not sure exactly what you mean but can take a look

Sure thing

Yeah, somebody seems to have added their details in place of Artur's. Investigating...

Daily update: issue identifed, solution found; working on a proposal

Update: I'll be ooo until Wednesday, when I am planning to submit the proposal

Proposal
Please re-state the problem that we are trying to solve in this issue.
Sliding context menu used for copying email address from chat to clipboard on Android native and Android mobile web inconsistently break words when breaking lines in case the email width exceeds screen width.
What is the root cause of that problem?
The Text component on native Android utilizes more robust word breaking mechanisms (Text's textBreakStrategy Android-only prop has a default value of highQuality) that detect individual segments of the email and split them e.g. between words. On the web, however, the default word breaking style set in src/components/ContextMenuItem.js is break-all  (CSS: wordBreak: 'break-all'), which is the cause why web splits the words in the unwanted manner:
https://github.com/Expensify/App/blob/9862a3e65393b26184369d312a02e1f7de88b64b/src/components/ContextMenuItem.js#L99
What changes do you think we should make in order to solve the problem?
The solution consists of two phases:

changing wordBreak to 'break-word' in the style of menu item description element in src/components/ContextMenuItem.js
inserting zero-width spaces (U+200B) characters, between email segment delimiters (., @):

getDescription: (selection) =>
            selection.replace('mailto:', '').replace(
                /([.@])/g,
                // below: zero-width space (U+200B) character
                '$1',
            ),

Side note: An alternative (but inferior) approach to the second point could be to use word break opportunity  tags, however these are web-only and would require reorganizing prop types and possibly the rendering method in src/components/MenuItem.js, thus making the UTF8 character solution more viable and cross-platform (according to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr#notes they behave the same on UTF-8 encoded pages). Such a move also helps ensure that other platforms than web should also behave consistently in case their word breaking mechanisms would change in future thanks to UTF8 word break opportunities being inserted manually in same places on all platforms.

Thanks for the proposal @artus9033. With adding zero-width space character we're aiming that the email will be split between any . and @, right?  But what would happen if I have a very long email with just characters before the domain.  I think the break-word will overflow right?
Digging more at my own end, I think this is a non-issue.

In Copy to clipboard section, in both mweb and Android, email should be displayed in the same format in a consistent manner.

@Julesssss @kevinksullivan Can we define what do we mean by consistent manner?

With adding zero-width space character we're aiming that the email will be split between any . and @, right? But what would happen if I have a very long email with just characters before the domain. I think the break-word will overflow right?

Thanks for the comment @mananjadhav. To answer your question: no, it should not overflow, it will wrap to a new line according to the old behaviour - zero-width spaces will serve as an additional opportunity for wrapping - here is an example with an email with an overlong local part I just tested with my approach:

No problem! Your last explanation looks great to me, I'd say we can go ahead as long as @mananjadhav agrees.

Works for me too.

Absolutely @Julesssss, I am making the last style touches to the code, will report back with the final PR today.

@Julesssss the PR is ready for review now.
CC: @mananjadhav

Hey @mananjadhav please fill out the checklist above when you get a chance. Thanks!

I don't think we have any offending PR for this one. We changed the behavior of word-break styling. I am on the fence for this one regarding regression test. It's a small feature and I don't think we need one. @Julesssss what are your thoughts?

I agree

Ready for payment

@kevinksullivan can you please post the payout summary for this one?

Summary

Contributor: @artus9033 $500
C+: @mananjadhav $500

Hi @artus9033 can you apply to the job and let me know when you've done so?
https://www.upwork.com/jobs/~0123a768f29d8cc1b6

Thanks for summary @kevinksullivan. The payout is only for me here for C+ review. @artus9033 is from Callstack (mentioned here).

That's right, thanks for the explanation @mananjadhav

$500 payment approved for @mananjadhav based on summary above.

Hey @mananjadhav has the payment been accepted?

Yes @Julesssss Payment is done. We can close this one out.


Fix VPC NAT Routing

This PR fixes #52 by ensuring the NAT resource references the private subnetwork instead.

Build passed in: https://circleci.com/gh/gruntwork-io/terraform-google-network/204

Released in https://github.com/gruntwork-io/terraform-google-network/releases/tag/v0.3.0


SB-1038: search condition fixed for artifacts within Maven-Indexer

I meant to merge this sooner, but got carried away! Thanks for this fix!
:)


Add support for Glow wallet

Currently Glow only works as a Safari extension on iOS but we are planning support for all browsers.

Thank you! For now, please scope the changes for this PR to just adding the adapter. It's easier to review and add to docs / examples as a followup after we release it. Let me know when it's ready for review!

@jordansexton this is ready to review — we're launching the Safari Extension this week. Should I invite you to the TestFlight to check it out? DM me the email you use on your Apple account :).
Also, how can I officially request your review on GitHub?

For sure, I can get this in quickly. Would you grant me the ability to push to this branch? I'll test, make any quick changes if needed, and publish tomorrow.

For sure, I can get this in quickly. Would you grant me the ability to push to this branch? I'll test, make any quick changes if needed, and publish tomorrow.

@jordansexton sent you an invite to our repo, not sure how else to do this. The GitHub docs show a checkbox that I can't find.


[Bugfix][Support] Fix copy constructor for support::OrderedSet

Prior to this commit, the support::OrderedSet<T> utility used the default copy constructor and copy assignment, which would copy both the OrderedSet::elements_ and OrderedSet::elem_to_iter_ members. While this is the correct behavior for elements_, the copy of elem_to_iter_ would contain references to the original's element_, rather than to its own.
While elem_to_iter_ is used in both OrderedSet::push_back and OrderedSet::erase, the implementation of OrderedSet::push_back only depends on the keys used in elem_to_iter_, and does not depend on the values stored.  As a result, this bug could go undetected for append-only usage, which is the most frequent use of OrderedSet.
This commit updates support::OrderedSet to have an explicit copy constructor and copy assignment.  Only the std::list<T> elements_ member may be copied, while the elem_to_iter_ must instead be rebuilt.

While I'm unaware of any way to trigger this bug from an externally-visible API, I ran across this during implementation of a debug feature.  This bug can result in segfaults when accessing elements of a support::OrderedSet.


Cloudflare Worker Deploy

Looks like a very cool project. Thanks for creating this.
Question about Cloudflare.
I pasted the contents of worker.mjs into the index.js in the cloudflare worker. I get this error when I try to deploy.
Uncaught Error: No such module "node:buffer". imported from "index.js" (Code: 10021)
Any ideas?

I think you have to replace the base64 encoding logic! See https://github.com/PublicAffairs/openai-gemini/blob/6d9241a27d53391d34cf5989410865c543bbc4a8/src/worker.mjs#L2

Thanks. Not sure what to modify as I am not a dev. But I will ask ChatGPT. 😆

Any ideas?

Thank you for pointing this out.
It seems that current version can not be "just pasted", because it depends on wrangler.toml option:
https://github.com/PublicAffairs/openai-gemini/blob/6d9241a27d53391d34cf5989410865c543bbc4a8/wrangler.toml#L4
But you can use this branch instead: https://github.com/PublicAffairs/openai-gemini/blob/resize-images/src/worker.mjs

Worked perfectly. It is responding as expected. Thanks so much for this!


enable the AI Services Opt-Out Policy type

missed a step.

blocked by https://github.com/terraform-providers/terraform-provider-aws/issues/14142, which is blocked by https://github.com/terraform-providers/terraform-provider-aws/pull/14000.
Policy has been enabled manually for now.

#6 is a workaround for the failure in deploying #3
https://github.com/terraform-providers/terraform-provider-aws/issues/14142 is to support the new AISERVICES_OPT_OUT_POLICY type for Organizations Policies. It is blocked by https://github.com/terraform-providers/terraform-provider-aws/pull/14000, which will update the provider to use a more recent version of the AWS SDK for Go, which adds that new type.
until those upstream issues are fixed, we manually enabled the type and we'll just need to ignore lifecycle changes until the terraform provider will accept the new policy type.


manage monitor: Fix premature thread exit

This pr fixes an issue with manage monitor where newly ingested data would get ignored because the commit arrived after the object/index scans started. Get the current branch HEAD before the task then when finished run again if there is no remaining work but the task HEAD is out of date.

This pr won't totally fix the race here, as there could be a commit in between the final head check and the thread exiting. Its an edge case IMHO this is good enough for now.


Replace the inspect module with sys.modules in auto_controller finder

Description
Found in api/init.py.
Replace the inspect module with sys.modules in auto_controller finder
Steps to reproduce the bug
No response
Environment
No response
Additional context
No response

Closed in https://github.com/binsync/binsync/pull/347


"neighbors" in getNodeInfo RPC should not include disconnected neighbors

Describe the bug
The getNodeInfo RPC call includes a return item called neighbors. With iri the number returned always represented the number of all connected peers as in: you had 10 peers configured in iri but 3 were down so iri only had 7 successfull connections. The number returned by getNodeInfo RPC call for neighbors would be 7.
After migrating to hornet I did add some static peers in peering.json. Some of them are successfully connected by, some aren't.
The getNodeInfo RPC call returns the number of (number of currently connected peers) + (number of disconnected peers).
To Reproduce
Steps to reproduce the behavior:

add static nodes to peering.json
restart hornet
run the following commands:

curl -sH 'X-IOTA-API-Version: 1' http://localhost:14265 -d '{"command": "'getNeighbors'"}' | jq '.neighbors[] | select(.connected==true) | .domain' | wc -l

curl -sH 'X-IOTA-API-Version: 1' http://localhost:14265 -d '{"command": "'getNeighbors'"}' | jq '.neighbors[] | select(.connected==false) | .domain' | wc -l

curl -sH 'X-IOTA-API-Version: 1' http://localhost:14265 -d '{"command": "'getNodeInfo'"}' | jq .neighbors

Expected output
10
6
10

Actual output
10
6
16

Fixed in #637


Landscape

Hi @vitali84 ,
Thank you for sharing your work. How can I make this repo work on Landscape PDF?. Can you please point to the line which can do a rotation of the PDF?.

Nevermind


HandMk5 refactor as device

This PR add couplingXCubHandMk5 device, this is used for getting quantities from the physical joints to the actuated axes domain and viceversa, following the coupling laws of the mk5 hand.
First usage:

https://github.com/robotology/gazebo-yarp-plugins/pull/671

Needs https://github.com/robotology/yarp/pull/3026

fyi @mebbaid

See:

https://github.com/robotology/gazebo-yarp-plugins/pull/671#issuecomment-1860181467

@traversaro after the update of YARP conda binaries the CI is happy, thanks!


Building on VS2019 Cl version

Can someone give me precise pointers which files i have to change so to can build myself the clBitcrack version on windows ?
By default it complains about CL/cl.h not found at first sign .
I know where are the mistakes in the current code and will fix them (main.cpp , ClUnits and so on)  , but would want to know what else i have to fix .

Install Open CL ( https://streamhpc.com/blog/2015-03-16/how-to-install-opencl-on-windows/ )

Attempted it .. failed .. tired of trying . Will wait for a fixed version of the exe .
Thanks for the help


Too soon to change to the CDN

In the future, a little warning before a deprecation would be nice. My site just completely lost its styling with your recent CDN change.

I am so sorry... I didn't realize that I made this mistake, but I did when I pushed the dev branch into heroku. I apologize, it should be fixed now.
PS, I am making the change in the following weeks, how do you think I should inform the rest of the users? I wrote a note on the main page but it is probably not enough.

I am uploading the new version next Sunday 7th, is that okay?

Will <link href="//cdn.jsdelivr.net/picnicss/3.4.2/picnic.min.css" rel="stylesheet"> still be available, or will that URL change?

That's the jsdelivr CDN, it should be available as long as jsdelivr exists (the project is unrelated to me)

So you're saying we can use either:

<link href="//cdn.jsdelivr.net/picnicss/3.4.2/picnic.min.css" rel="stylesheet"> (old)
<link href="//cdn.jsdelivr.net/picnicss/3.4.3/picnic.min.css" rel="stylesheet"> (new)

Just making sure I understand.

I am sorry but there is no version 3.4.3 currently. The next version after 3.4.2 will be the 4.0, and there will not be 3.4.2 unless there's an important bug that makes me release a fix for the 3.4.3.
On the other hand, the version 3.4.2 that you pointed (first one) will always be available in that link and you can safely use it.

Got it. Thanks for the clarification!


cert-manager cannot authenticate to vault after upgrading kubernetes to 1.21

Hello,
We've recently upgraded Kubernetes (EKS) from version 1.18 to 1.21. Before the upgrade, we've had Vault 1.2.1 and cert-manager 1.1.0 that was configured to authenticate using the Kubernetes service account (reading the secret name from spec.vault.auth.kubernetes.secretRef which is pointing to the secret holding the same service account that is assigned to cert-manager = cert-manager-token-2rz5r).
After the upgrade, we've also upgraded Vault to version 1.2.3 to add support for configuring the issuer on the Kubernetes auth backend.
cert-manager is still unable to login to Vault and the Vault issuer remains not ready. The log shows the attempt to login failed:
I0223 11:03:21.358536       1 setup.go:104] vault-issuer: Failed to initialize Vault client: error reading Kubernetes service account token from cert-manager-token-2rz5r: error calling Vault server: Error making API request.

URL: POST https://vault.default.svc.cluster.local:8200/v1/auth/kubernetes/login
Code: 500. Errors:

* claim "iss" is invalid
E0223 11:03:21.358579       1 sync.go:83] cert-manager/controller/clusterissuers "msg"="error setting up issuer" "error"="error reading Kubernetes service account token from cert-manager-token-2rz5r: error calling Vault server: Error making API request.\n\nURL: POST https://vault.default.svc.cluster.local:8200/v1/auth/kubernetes/login\nCode: 500. Errors:\n\n* claim \"iss\" is invalid" "resource_kind"="ClusterIssuer" "resource_name"="vault-issuer" "resource_namespace"="" "resource_version"="v1"
E0223 11:03:21.358620       1 controller.go:158] cert-manager/controller/clusterissuers "msg"="re-queuing item due to error processing" "error"="error reading Kubernetes service account token from cert-manager-token-2rz5r: error calling Vault server: Error making API request.\n\nURL: POST https://vault.default.svc.cluster.local:8200/v1/auth/kubernetes/login\nCode: 500. Errors:\n\n* claim \"iss\" is invalid" "key"="vault-issuer"

I added a small sidecar with shell to the pod running cert-manager so that I can use it to troubleshoot. I was able to get the token from the Kubernetes API (curl -s --cacert /var/run/secrets/kubernetes.io/serviceaccount/ca.crt --header "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" -X GET https://kubernetes.default.svc/api/v1/namespaces/cert-manager/secrets/cert-manager-token-2rz5r) and got a result (I masked the response for potentially secret values):
{
  "kind": "Secret",
  "apiVersion": "v1",
  "metadata": {
    "name": "cert-manager-token-2rz5r",
    "namespace": "cert-manager",
    "uid": "xxxxxxxxx",
    "resourceVersion": "xxxxxxxxx",
    "creationTimestamp": "2020-02-18T12:13:06Z",
    "annotations": {
      "kubernetes.io/service-account.name": "cert-manager",
      "kubernetes.io/service-account.uid": "xxxxxxxxx"
    }
  },
  "data": {
    "ca.crt": "xxxxxxxxx",
    "namespace": "xxxxxxxxx",
    "token": "xxxxxxxxx"
  },
  "type": "kubernetes.io/service-account-token"
}

The token I get (after I base64 decode it) is different than what's mounted to the filesystem (/var/run/secrets/kubernetes.io/serviceaccount/token). After taking a close look at the cert-manager pod, it becomes clear why - the volume mounted is no longer taken from the secret - but rather taken from a "projected" (not sure what that is):
  volumes:
  - name: kube-api-access-6mtdk
    projected:
      defaultMode: 420
      sources:
      - serviceAccountToken:
          expirationSeconds: 3607
          path: token
      - configMap:
          items:
          - key: ca.crt
            path: ca.crt
          name: kube-root-ca.crt
      - downwardAPI:
          items:
          - fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
            path: namespace

Finally - when I test the Vault login using the locally mounted token - it works (curl -s -X POST "https://vault.default.svc.cluster.local:8200/v1/auth/kubernetes/login" -d "{\"jwt\":\"$(cat /var/run/secrets/kubernetes.io/serviceaccount/token)\",\"role\":\"cert-manager\"}" -k). When I try to do the same with the token stored in the secret - it doesn't work (curl -s -X POST "https://vault.default.svc.cluster.local:8200/v1/auth/kubernetes/login" -d "{\"jwt\":\"$(curl -s --cacert /var/run/secrets/kubernetes.io/serviceaccount/ca.crt --header "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" -X GET https://kubernetes.default.svc/api/v1/namespaces/cert-manager/secrets/cert-manager-token-2rz5r | jq -r .data.token | base64 -d)\",\"role\":\"cert-manager\"}" -k)
My conclusion is that something changed in how Kubernetes handles service account tokens, but I can't find anywhere how to reflect that change in cert-manager.
Anyone had this problem before? Am I missing something? Any insights would help.
Thanks,
Yosi

OK - I found the solution [this issue|https://github.com/cert-manager/cert-manager/issues/4144#issuecomment-960632662]. I changed my issuer to kubernetes/serviceaccount to fix it. Since I don't have any other application (yet) authenticating to Vault using the bound service account token - we don't even need to create the second auth backend to support that...


Added me.inbox() function for getting messages in inbox

this adds me.inbox(). It can't automatically merge

ohh it's because you changed api/submit to api/compose for submit_text

Also adds me.comment for replying to comments and PMs


level 51 error when use git v2.5.0

Name: revert
Level: 51
Difficulty: ****
You have committed several times but want to undo the middle commit.
All commits have been pushed, so you can't change existing history.

git revert HEAD~1 --no-edit

Sorry, this solution is not quite right!

I think this PR would fix it
https://github.com/Gazler/githug/pull/189

Closed via https://github.com/Gazler/githug/pull/194

Closed via https://github.com/Gazler/githug/pull/194


modify subtract, multiply and divide methods for the variant

What is the purpose of the multiply and divide changes?


Maintenance State as subclass of BFO:Process

As per comments from Barry Smith on the Maintenance Reference Ontology, MaintenanceState should be a sibling of MaterialState (subclass of BFO:Process) with CCO:stasis as a synonym.
This should be actioned after the Maintenance Reference Ontology comments period (before going to a vote).

Completed.


Add support for only skip and failing annotations in GraphQLSpec

Currently there is no way for a developer to control which spec to run, ignore or expect to fail.
 struct GraphQLSpec {
   path: PathBuf,
   client_sdl: String,
   server_sdl: Vec<String>,
   merged_server_sdl: String,
   sdl_errors: Vec<SDLError>,
   test_queries: Vec<GraphQLQuerySpec>,
+  annotation: Option<Annotation>
 }

+ enum Annotation {Skip, Only, Fail}

The annotations will contain skip or only or failing
Technical Specifications

only: If any spec contains only only that spec should be executed. Eg:
#> spec-only

#> server-sdl
schema { query: Query }

#> client-sdl
schema {query: Query}

skip: if a spec contains skip then that should be skipped, and a warn log should be printed. Eg:
#> spec-skip

#> server-sdl
schema { query: Query }

#> client-sdl
schema {query: Query}

fail: Expect the spec to fail. Panic incase it doesn't fail. Eg:
#> spec-fail

#> server-sdl
schema { query: Query }

#> client-sdl
schema {query: Query}

Sure @tobihans !

@tobihans did u get a chance to work on it or can we release it for others to try?

IDK if it is possible, but a desirable behavior it'd be cargo test name-of-test.graphql, as we have this kind of experience in lots of frameworks, so it'd be kind of familiar to new contributors.

IDK if it is possible, but a desirable behavior it'd be cargo test name-of-test.graphql, as we have this kind of experience in lots of frameworks, so it'd be kind of familiar to new contributors.

Can you elaborate more, please ?

Surely I can.
so I came from the Node.js ecosystem, and popular libraries like jest and test have an interesting standard for selecting which test you want to execute.
You can go to the root of a project with Jest and type jest <pattern-of-your-file>, and jest will execute only files with that pattern. Bringing it to our context, we would type, for example, cargo test http, which would run all tests with http on their name.
Note that this is nice to have (in my opinion), but it's not part of @tusharmath's description of what needs to be done, so I don't recommend implementing it now.

Ok, I get you now. Yeah, cargo provide test filtering AFAIK. It's not related to the description as you said. Thanks


Use close watcher when supported in place of escape key handlers

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
This library should use the CloseWatcher API [1][2] in place of escape key listeners where it's supported. This allows components such as dialog to be dismissed using extra close signals (e.g. Android back gesture).
[1] https://html.spec.whatwg.org/multipage/interaction.html#the-closewatcher-interface
[2] https://developer.chrome.com/blog/new-in-chrome-120#close-watcher
Examples 🌈
No response
Motivation 🔦
The native html dialog (when modal) and popovers have this behaviour in supported browsers (Chromium), using the close watcher API would align with the platform.
It also provides increased accessibility as on top of the back gesture/ button the Talkback back gesture (and potentially other screen readers) also triggers a close watcher.

This imo is a progressive enhancement where you'd fallback to the existing escape key handlers in supported browsers. So the caniuse data isn't as relevant as something that couldn't be polyfilled.


ceph-csi 3.12.0 installed with helm charts not able to provision RBD PVC.

          > @iPraveenParihar can you please check above?

https://github.com/ceph/ceph-csi/pull/4776 should fix the CSI NodePlugin with v.3.12.0 driver fails when missing domain labels deployed via helm.

this does indeed "fixes" the mentioned problem, however, on new pvc, there's new one :D

We yet to decide on how to enable/disable topology aware provisioning (https://github.com/ceph/ceph-csi/pull/4726).
For now, the workaround is to add --feature-gates=Topology=false for csi-provisioner in csi-rbdplugin-provisioner deployment pod.
@ypyly, Can you please try with above workaround and see if that helps you?
Originally posted by @iPraveenParihar in https://github.com/ceph/ceph-csi/issues/4775#issuecomment-2295910213

as commented in the original issue adding upper-mentioned arg to the  provisioner does solve the issue.
P.S> for the helm installation, you need to add
provisioner:
  provisioner:
    extraArgs:
      - 'feature-gates=Topology=false'

to your values

well its actually for both helm/manual deployment.
let me summarise this -
v3.12.0 Ceph-CSI uses csi-external-provisioner: v5.0.1 which has topology aware provisioning enabled by default.
And the csi-external-provisioner will need topologyKeys (domain labels passed to csi-rbdplugin in csi-rbdplugin daemonset pod) to generate AccessibilityRequirements and pass it to CreateVolume request.
I made changes in https://github.com/ceph/ceph-csi/pull/4726 to add an option enable/disable topology from Ceph-CSI. But it isn't good as users  would want some StorageClasses to use topology based provisioning, others not which is handled by the same Ceph-CSI driver.
other solution is that we could have --immediate-topology=false set in csi-external-provisioner.

If topology based provisioning is not needed - set volumeBindingMode as Immediate in StorageClass
If topology based provisioning is needed - set volumeBindingMode as WaitForFirstConsumer  in StorageClass and pass --domainlabels

@Madhu-1 @nixpanic, WDYT of above?

well its actually for both helm/manual deployment.
let me summarise this - v3.12.0 Ceph-CSI uses csi-external-provisioner: v5.0.1 which has topology aware provisioning enabled by default. And the csi-external-provisioner will need topologyKeys (domain labels passed to csi-rbdplugin in csi-rbdplugin daemonset pod) to generate AccessibilityRequirements and pass it to CreateVolume request.
I made changes in #4726 to add an option enable/disable topology from Ceph-CSI. But it isn't good as users would want some StorageClasses to use topology based provisioning, others not which is handled by the same Ceph-CSI driver.
other solution is that we could have --immediate-topology=false set in csi-external-provisioner.

If topology based provisioning is not needed - set volumeBindingMode as Immediate in StorageClass
If topology based provisioning is needed - set volumeBindingMode as WaitForFirstConsumer  in StorageClass and pass --domainlabels

@Madhu-1 @nixpanic, WDYT of above?

IMO above 1, 2 is the right options when to use and when not to use topology based provisioning. we need to avoid introducing new flags to enable and disable as in same cluster we need to support both, i am fine to make domainLabel as mandatory if required. but we also need to consider how it will impact non-k8s as well.


Can't create new workspaces in Continuous Delivery

Go to Continuous Delivery
Create workspace
Add a member and try to create a new workspace

Results: Can't create new workspaces in Continuous Delivery.  Error saying namespace doesn't exist.

This happened when a cluster other than local was selected before you went into fleet view, it was talking to that cluster instead of the management one.

Fixed and closing.


The ADLS Gen2 folder displays as a soft-deleted block blob after soft deleting it

Storage Explorer Version: 1.21.0-dev
Build Number: 20210710.1
Branch: main
Platform/OS: Windows 10/ Linux Ubuntu 18.04/ MacOS Big Sur 11.4
Architecture: ia32/x64
How Found: Exploratory testing
Regression From: Not a regression
Steps to Reproduce

Expand one ADLS Gen2 storage account -> Blob Containers.
Create a blob container -> Create a new folder.
Soft delete the new folder -> Switch to 'Active and deleted blobs' view.
Check whether the soft-deleted folder displays.

Expected Experience
The soft delete folder displays.
Actual Experience
The folder displays as a soft-deleted block blob.

Additional Context
Here is the screenshot from Portal:

I think we can make our datatable can hide the details of this blob and display it as a directory instead.

@JasonYeMSFT Verified this issue on the build 20210719.1. Fixed.

One question needs to confirm. No blob displays after opening one soft-deleted folder which contains active blobs. Is this expected?

No blob displays after opening one soft-deleted folder which contains active blobs. Is this expected?

Yes.

@JasonYeMSFT On the build 20210720.1. The 'open' action is disabled for one soft-deleted folder. It seems expected, right?
BTW, I logged a new bug 4693 for the action items against soft-deleted blob.


react-redux mapDispatchToProps.js module map error

After cloning our remote React Native project, that was previously working no problem, we're running into the following error when building the project. I don't know if the problem originates from react-redux or not, I'm guessing it does not- and is rather an issue with NPM and Yarn (we've tried both), but I thought I'd ask just in case.
Unable to resolve module `redux` from `path/to/node_modules/react-redux/lib/connect/mapDispatchToProps.js`: Module does not exist in the module map
This might be related to https://github.com/facebook/react-native/issues/4968
To resolve try the following:
  1. Clear watchman watches: `watchman watch-del-all`.
  2. Delete the `node_modules` folder: `rm -rf node_modules && npm install`.
  3. Reset Metro Bundler cache: `rm -rf /tmp/metro-bundler-cache-*` or `npm start -- --reset-cache`.
  4. Remove haste cache: `rm -rf /tmp/haste-map-react-native-packager-*`.
+ [[ false != true ]]
+ [[ ! -f /Users/wbattel4607/Library/Developer/Xcode/DerivedData/myapp-cvscqhbhrcowbrfzfirwmdiuyvfc/Build/Products/Release-iphoneos/myapp.app/main.jsbundle ]]
+ echo 'error: File /Users/wbattel4607/Library/Developer/Xcode/DerivedData/myapp-cvscqhbhrcowbrfzfirwmdiuyvfc/Build/Products/Release-iphoneos/myapp.app/main.jsbundle does not exist. This must be a bug with React Native, please report it here: https://github.com/facebook/react-native/issues'

I've also opened an issue on the react-native repository. For more details on the issue, see here https://github.com/facebook/react-native/issues/18931

That's the RN bundler, as far as I can tell.


Unique keys on data types

Need to be able to define unique keys on a datatype using a JSON path to target the part of the datatype that needs to be unique across the whole dataset.
Allow for multiple values to be included within indexes so multi-value unique keys can be defined.

Added in commit 241cb01a900518068fd8158b83df5645700fe3ff


[ADP-3229] Merge conversions lib into primitive lib

[x] integrate conversions lib into primitive as needed by read conversions

ADP-3229

👍🏻


Export typing information

This commit adds the flag that the package contains typing
information. Therefore other packages can use the typing data to check their
code by mypy.
Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages
Signed-off-by: Jan Luca Naumann<EMAIL_ADDRESS>

@googlebot I signed it!

Thanks for the PR! I'll fix the build and merge this.

Codecov Report

Merging #923 (357f430) into master (20dc783) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   98.04%   98.04%
=======================================
  Files         129      129
  Lines       22394    22394
=======================================
  Hits        21957    21957
  Misses        437      437

Impacted Files
Coverage Δ

setup.py
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20dc783...357f430. Read the comment docs.


fix: helm repository support ca file

Description of your changes
see issue https://github.com/kubevela/kubevela/issues/6362
move caFile field from data to stringData,and  no longer need the base64 encode.

How has this code been tested?

Checklist

I have:

[ ] Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
[ ] Updated/Added any relevant documentation and examples.
[ ] New addon should be put in experimental.
[ ] Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

[ ] This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
This addon must have some basic but necessary information.

[ ] An accessible icon url and source url defined in addon's metadata.yaml.
[ ] A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
[ ] Also provide an introduction in KubeVela documentation.
[ ] It's more likely to be accepted if useful examples provided in example dir.

@FogDong,have a look,and do we need upgrade the version of fluxcd addon,i see the check failed by this.

Please upgrade the fluxcd addon version in: https://github.com/kubevela/catalog/blob/master/addons/fluxcd/metadata.yaml#L2


bug: checkWorkspace doesn't display the appropriate error

The first err check results in true and subsequent err checks never happen:
https://github.com/hbagdi/deck/blob/master/cmd/common.go#L54-L65

Fixed in https://github.com/hbagdi/deck/commit/90722b61e6f32222b7230240f96dd9302bc95376


No wifi is showing, esp8266 is just blinking after some interval..

I've tried the code but there is no wifi is showing and esp8266 is blinking led after approximately 5 sec interval.. What do i do now?

It may be something wrong with the SD card connection, make a new .ino file and check if your ESP board can access the info, try also setting the variables manually


Unexpected identifier 'Hero'. import call expects one or two arguments.

Filament Version
3.2.2
Plugin Version
3.2.20
PHP Version
8.2
Problem description
When trying to load a custom extension the module doesn't load correctly.
I followed the Hero example in the documentation, but loading it through the extension.js file produces the attached error.

Expected behavior
I expected the extension to load correctly and trigger correctly from the toolbar.
Steps to reproduce
I followed the Hero example in the documentation. Performed every step.
Reproduction repository
No response
Relevant log output
No response

Sounds like you missed a step or the extensions.js isn't getting loaded. If you can share a repo I can look more in depth. But I don't have an answer for based on just that error.

Hi - the extensions.js is getting loaded, you can see it in the screenshot of the browser I attached. The error looks like the browser is struggling with the import "Hero" line. The only thing I can think of is that it is not being compiled by Vite correctly or your app is picking up the raw file rather than the compiled one?

I've just tried the process in a fresh install and I've got the same error.
You can see the repo here: https://github.com/edstevo/tiptap-test
Can you let me know if you have any issues finding the right bits? I'm sure everything is in the right directories as per the documentation.

Honestly, I'm not sure what's going on here. If you look at the demo repo, it's working correctly there.
https://github.com/awcodes/tiptap-demo

Ok, it looks like I have something working now. I'm building vite on each change (npm run build). It doesn't seem to work when using "npm run dev".

Interesting. I'll make a note to look into it. Thank you for debugging.


nix: substrate depends on openssl

I noticed if I didn't do this I sometimes hit compile errors so we must depend on openssl at the moment.

Interesting, maybe ring could replace openssl in some dependency.

I'd certainly trust rustls given that google's security people are keen on using that inside curl.
All the usages of openssl are from jsonrpc-client-transports.

(Hopefully jsonrpsee will be dependent on rustls.)

(Hopefully jsonrpsee will be dependent on rustls.)

Yes, it is currently at least :)

bot merge

bot merge force


Accessibility:MAS42A: Disabled Icons appears as Enabled on mouse hover in High Contrast Mode.

VS Code Version:1.6.1
OS Version:1607
Pre-Requisite:
1.Open visual studio code editor.
2.Using "Ctrl+Shift+P" key Open the command Pallete.
3.Type Theme, Navigate to Preferences: Color Theme and Hit Enter.
4.Navigate to High Contrast and Hit Enter.
Steps to Reproduce:
1.Open visual studio code editor.
2. Using "Ctrl+Shift+D", key navigate to the Debug side view bar option.
3. Open the launch.json file under the "Configure or Fix: launch.json"button and select "Node.js" from the drop down list.
4. Start debugging by pressing F5.
5. Observe the Disabled options like "Step Over", "Step Into" and "Step Out" on mouse over.
Expected Result:
Disabled Icons should appears as Disabled on mouse hover even in High Contrast Mode.
Actual Result:
Disabled Icons appears as Enabled on mouse hover in High Contrast Mode.
User Impact:
Low Vision users might not be knowing that these options are disabled and they will be expecting a change after Invoking these options.

fyi @bpasero we introduced a wrong rule for hover feedback in hc mode that I removed with this commit - all seems good now.

@isidorn The issue is fixed in vs code editor insider build but still able to reproduce in vs code editor 1.8.1

@WiproPSAccTest insider is what matters, that will become stable soon.

Title has been changed to a common format to perform data population.


Allow for sinopia:hasRemark value at RT-level

Allow for providing an RT-level remark (text) in sinopia_maps.xml
Also, can confirm that sinopia:hasRemarkUrl is not a thing at the RT-level, only hasRemark

^^^ testing

@pan-zhuo you can add RT-level remarks in sinopia_maps.xml

@pan-zhuo see guidance for rt_remark in wiki


Finalize the design for Attribute (or propose/decide on an alternative) and implement it

From the doc:
Uncorrupted values x may be observed, but may also be unobserved,
in which case they are now possible targets of inference. The system
will need to track which uncorrupted values are targets of inference, and
include updates to them as a part of inference. One possible design
(not fully thought out, may have holes!) is to create an Attribute
base class, whose subclasses (e.g. BetaBernoulliAttribute) are asso-
ciated with both a Distribution subclass (e.g., BetaBernoulli) and an
EmissionDistribution subclass (e.g., BetaBernoulliEmission). An in-
stance of an Attribute subclass would store a true value x of an attribute,
a Boolean recording whether x is observed or must be inferred, and all
noisy observations  ̃x of this value. It would also track the Distribution
into which x is currently incorporated, and the EmissionDistributions
into which the  ̃x’s are incorporated. A key method of each Attribute
subclass would be transition x, which updates the current hypothesis of
x’s value (if it is not directly observed)

This class is expanded upon in Model 6, where it must track multiple corrupted versions and EmissionsDistributions.


Move to Pipenv

What? and Why?

What does this pull request change/fix? Why was it necessary?

Checklist

[ ] CHANGELOG.md updated? (if required)

Do we need to do something to check whether there's already an environment, because right now the travis build fails to make one?
And if we are moving to pipenv should we look to move to pyenv at the same time?

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   90.45%   90.45%
=======================================
  Files           6        6
  Lines         220      220
=======================================
  Hits          199      199
  Misses         21       21

Impacted Files
Coverage Δ

app/response_processor.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ed3cc...5a26ead. Read the comment docs.

Will reopen once we get to this work


get_responses() return options

hey @1papaya
Currently if i run this code:
student_eval <- get_responses(ea_midterm_design, metadata = TRUE)

It returns a "melted" gathered data frame where the metdata are stacked UNLESS i chose melt == FALSE.
I think we should

have a core function get_responses() that returns the survey with the metadata unmelted. Thus melt defaults to FALSE unless you set it to TRUE and metadata defaults to TRUE unless you set it to false.
Then provide the OPTION to melt or remove the metadata if you want.

Right on, makes sense. Implemented change in 9b0a577.


Author start of article

Merged in https://github.com/AdvisorySG/dawn-advisory-theme/commit/913e21d0579ff47c05512d6aba49d57bf642bdc2.


formatted data being sent to syslog

When using the packaged syslog hook, the data being sent to syslog uses the format sent to the default destination. This means that syslog is receiving a payload with the severity level in the message content, when it already has severity as part of the syslog headers. It has a timestamp when syslog has a timestamp. It has ANSI color escape codes, and alignment formatting.
Basically each output destination needs its own formatter.

The model I think that makes most sense is an interface such as:
logger.AddOutput("syslog",
  logrus_syslog.NewSyslogOutput("udp","localhost:514", syslog.LOG_INFO, "",
    &logrus.TextFormatter{
      DisableColors: true,
      DisableTimestamp: true,
    }
  )
)

The default formatter would be automatically added, and equivalent to:
logger.AddOutput("stdout",
  logrus_iowriter.NewIOWriter(os.Stdout,
    &logrus.TextFormatter{}
  )
)

The idea is that each output would be added with a name (so that it could be identified later to change or remove it), and where the message will be sent to.
The formatter is part of the destination, and not the logger or even the registered "output" we just created. This is because for some logging destinations, formatting doesn't make sense. For example, if you're logging to a database, you wouldn't format the message at all, the fields would go in as is.

Just bumped into this issue as well. Here a sample line from a syslog logfile:
Oct 15 01:21:42 local0.error localhost go-dnsmasq[5258]: \x1b[31mFATA\x1b[0m[0000] listen udp <IP_ADDRESS>:53: bind: permission denied

The timestamp and severity in the msg text duplicate information already available in syslog's structured data fields. Additionally, ANSI escape codes are printed in the syslog message which makes them less readable and require extra work to parse them.
Since we only want entry.Data and entry.Message in the syslog msg string i don't think there is any reason to invoke the logger.formatter in the first place. There are only so many ways one can format a string consisting of one text string and some optional key:value pairs:
"This is the message key1=value key2=value"

The fundamental problem here, is that formatters and hooks are really the same thing. The 1.0 design will address this issue, unless someone has a shorter term solution.

One can get rid of the colors in syslog by using DisableColors set to False.
Also, there is an other issue, inherited from the standard syslog module, the name of the logging process is suffixed with [pid].
In my opinion this should be configurable at logging init.

One can get rid of the colors in syslog by using DisableColors set to False.

So to disable colors one has to set DisableColors to False? Really? :smirk:

@janeczku Thanks for spotting the mistake. Fix it.
Anyway, the core issue here is that we were not able to use logrus due to its behaviour described above by @phemmer .

@phemmer so DisableColors is behaving as it should or is this another issue thats needs fixing? :confused:

I can confirm it is working properly:
This is how I receieve messages on the syslog end:
time="2015-12-11T11:49:03Z" level=info msg="overall update results" batch=0 fail=0 not-found=0 success=0

I'm seeing this now:
2017-03-17T17:40:11.117046+00:00 HOSTNAME.REDACTED Watchdog Send[8767]: #033[34mINFO#033[0m[0030] Packet sent                                   #033[34mcustomer_ip#033[0m=REDACTED #033[34mfunction#033[0m="sendICMP()" #033[34mpop#033[0m=TEST #033[34msrc_ip#033[0m=REDACTEDIP

So the solution should be to use disablecolors?


Update MVC/Routing Startup Experience

This is mostly simplification along the lines that we've already discussed.
The main change here is to split and refactor the MVC data source into a few pieces. In addition to that I updated our tests to cover what we're going to ship in 3.0.
Next I'll do templates.
Individual commits have some additional details, as this kinda touches a lot of stuff
/cc @JamesNK

@JamesNK - ready for a second look. I'm not sure what this comment is about so it would be helpful if you could clear that up. https://github.com/aspnet/AspNetCore/pull/7425#discussion_r255428711

Make sure you hit the bell to get notifications.

This change didn’t touch templates right?

It super does!

I know I said that I'd do that next, but I already did it. Removing MapApplication would break stuff


Update Upload Widget to the latest CLD version

https://github.com/cloudinary-community/next-cloudinary/issues/363

This was already done in rc.1


Aryan

New distributions implemented

I should be able to merge this in once my question is answered.

Both pi and pi() worked but I changed it to pi because it makes more sense for it to be a constant

distributions added to the std lib

So why did you close this? It hasn't been merged.

@JacquesCarette
I thought something was wrong with it because it was open for a long time but wasn't merged. I reopened it.

I'm just behind on some of these things. If something is wrong, I will explicitly comment.

It looks like you've added a bunch of files that don't belong here. Remove them

It's really much better to do smaller pull requests...  but I'll merge it in anyways.


BOX BASEN 280 ah BMS Tianpower

Hi,
I installed the project on HA, changed the mac address, the BT of the box is TP_123456, the log cannot connect.
The BOX BASEN 280/300 ah is as follows
https://www.basengreen.com/it/PRODOTTI/custodia-fai-da-te-per-accessori-per-contenitori-per-batterie-48v-300ah/
I attach the log.
logs_esp32-bms-basen_logs.txt
Thanks for your answer

Could you increase the log level and provide another log? Thanks in advance!
https://github.com/syssi/esphome-tianpower-bms?tab=readme-ov-file#debugging

hi,
the debugger log has been increased, the BT does not connect to the BMS, I attach the updated log.
last night it was connected for a few minutes, then it disconnected, see image.
Thanks in advance!
logs_esp32-bms-basen_logs (1).txt

would there be the possibility of connecting the BMS with the RS485 port and therefore with the modbus? I have already connected the inverter this way.

Note for myself:

Tianpower TP-LT55AT used in BASEN 48V 280Ah Bluetooth battery bank
Advertised via BLE as TP_123456

would there be the possibility of connecting the BMS with the RS485 port and therefore with the modbus? I have already > connected the inverter this way.

I must admit: I don't know much about this BMS. Could you ask your seller about some RS485 protocol details? Do you have a RS485 converter and could you sniff some data?

What's the distance between the BMS and the ESP32? Which ESP32 model/version do you use? Could you try to replace the ESP32 or change some more parameter (f.e. more distance vs. less distance to the BMS).

I purchased an ESP32-WROOM-32D board purchased on AliExpress, I can try to install the integration on another ESP32, for now I have tried moving it further away (always in the same room) but it cannot connect.

I must admit: I don't know much about this BMS. Could you ask your seller about some RS485 protocol details? Do you have a RS485 converter and could you sniff some data?

the seller of the box basically mounts the Tianpower BMS but doesn't know anything else.
I have a RS485 converter and I could read the parameters, if you tell me which program to use, I can try to sniff the data.

What's the distance between the BMS and the ESP32? Which ESP32 model/version do you use? Could you try to replace the ESP32 or change some more parameter (f.e. more distance vs. less distance to the BMS).

I purchased an ESP32-WROOM-32D board purchased on AliExpress, I can try to install the integration on another ESP32, for now I have tried moving it further away (always in the same room) but it cannot connect.

I did the test with another ESP32 but it still doesn't connect to the BT of the BMS, at this point I think the problem is with the BT card and for this reason I would like to try to read the data with the RS485 port.

HI
I wanted to let you know that I was able to make the integration work.
I used an ESP32 board with CP2102 and restarted the box in order to associate the BT of the BMS.
There are some parameters that give me zero and small things to fix, if you want I'm available to send you the logs, you could make an integration calling it specific for the BASEN bms installed on the BOXES.

Cool! Thanks for your feedback. Feel free to create a new issue and provide some logs + contribute improvements if you can.


Populate source rule targets to trigger the global retrieval function

Couple notes:

I wouldn't consider the way this synchronizes our state with AWS resources to be particularly "hardened." For instance, if our putTargets call fails following a putRule call, we'd probably want to rollback the rule creation. This isn't a now problem -- can do this hardening later.
Now that the test AWS integration is a bit more in depth, I streamlined the way we configure the mock package. Sorry to include this in one change, but thought it was the lesser of two evils as compared to sending a dedicated PR for this.

 Write/deploy a retrieval Lambda with support for the example source content type


Overall Performance

Reacto is slow when dealing with big files. I believe the current pain points lay inside Editor.jsx:

expensive this.props.updateCode which slow everything down as it is updating the redux store with a massive new value, many times in a row (despite it is actually debounced right now).
this.parseCode as it generates an ast and pass everything down to the bricks (even it is wrapped inside perf.debounce as well).

The problem is that both are necessary. Unless we manage to find another way to call them in a smarter way, or simply rethink about the current workflow.
Has anyone any idea about this? That would be really helpful.

Little improvement: it used to update twice in a row as .state.code and .state.cursor would be updated separately (as it was attached to two different listeners). Now do both at once.

I found the main issue: the editor code zone is controlled for now. I will make changes that will incredibly boost the editor speed performance. Stay tuned, it'll soon be much better. :)

@lachlanjc, I've just pushed a new build for the project. It is supposed to be way faster than before.
Whenever you have time, could you please download the new release and tell me if the performance has improved?
Download new version
I remember you mentioned the first release was kind of laggy on your side.
That would help, thank you. :)

@eveningkid Performance is much better in that build! Thank you!


Support new .bazelignore file

Bazel 0.17.1 introduced a .bazelignore file that lets you ignore a list of directories. How about marking these as excluded on sync?

Perhaps something like this? https://github.com/mtsgrd/intellij/commit/0e0034eae38a356a80357d4f6dbad9718044d23b

@brendandouglas this sounds useful. WDYT? We have people who need this .bazelignore but I'm not sure they use intellij. I think we'll have that intersection soon.
@mtsgrd are you seeing a slowdown due to intellij trying to index these directories?

@ittaiz I added this to my own fork such that intellij doesn't index a node_modules folder I keep in the workspace. Interestingly, even though I have this folder excluded I can still jump to definitions inside of it from my angular code. Is this expected behaviour? The angular app I am working on is largely based on https://github.com/alexeagle/angular-bazel-example.


AcceptDialog children not affected by light mask

Godot v2.1.4
Description
Setting a light mask to an AcceptDialog does not reflect on its children
Step by step
1- Create an empty scene
2- add an AcceptDialog node
3- in the inspector pane, set the light mask as follow : un-check the first box and check the last box
4- add a script to the AcceptDialog node, and paste the following code
extends ConfirmationDialog

func _ready():
	print("dialog mask: ", get_light_mask())
	for c in get_children():
		print("child (", c.get_name(), ") mask: ", c.get_light_mask())
		for d in c.get_children():
			print("sub-child (", c.get_name(), "-", d.get_name(), ") mask: ", d.get_light_mask())

5- run the project, the ouput shows that the light mask was not reflected to the children of the Dialog:
dialog mask: 524288
child (@@8) mask: 1
child (@@9) mask: 1
child (@@10) mask: 1
sub-child (@@10-@@15) mask: 1
sub-child (@@10-@@14) mask: 1
sub-child (@@10-@@11) mask: 1
sub-child (@@10-@@12) mask: 1
sub-child (@@10-@@13) mask: 1

Workaround
For the meantime, a simple workaround could be:
var popup = get_node("my_dialog")
var mask = popup.get_light_mask()
for c in popup.get_children():
	c.set_light_mask(mask)
	for d in c.get_children():
		d.set_light_mask(mask)

Can't test in 4.0 because dialogs don't seem to show in the editor, but this is likely fixed or no longer valid.


feat: Add getTransaction method to BlockchainClient

This commit adds a getTransaction method to the BlockchainClient class, which provides a consistent structure for fetching transaction details across different data providers (Bitcoin Core, Blockstream, Mempool).
Changes:

Add TransactionDetails interface for unified transaction data
Implement getTransaction method
Add normalizeTransactionData to standardize response

#116  This method was added to help add fee-bumping methods RBF/CPFP to caravan-coordinator

#116  This method was added to help support adding RBF and CPFP fee-bumping methods to caravan/coordinator


Update changelog for manifest lists

wondering if I should also update the plugin changelogs?

Yeah, it's a new feature for plugins too.


Voting poll on NEAR SOCIAL

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

How can I implement voting poll widget on near social

Duplicated with #155 . Also if you considering to implement a poll widget on NEAR Social, here is a better place to discuss: https://t.me/NEARisBOS


Hand Detection (desktop) : Build did not complete successfully

I have an issue while building the hand tracking example
Could you please help ?
OS: ubuntu1~16.04.12
gcc version : 5.4.0
/home/ailac/Downloads/mediapipe-master/mediapipe/calculators/image/BUILD:332:1: C++ compilation of rule '//mediapipe/calculators/image:image_cropping_calculator' failed (Exit 1) gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 74 argument(s) skipped)
Use --sandbox_debug to see verbose messages from the sandbox
mediapipe/calculators/image/image_cropping_calculator.cc: In member function 'mediapipe::Status mediapipe::ImageCroppingCalculator::RenderCpu(mediapipe::CalculatorContext*)':
mediapipe/calculators/image/image_cropping_calculator.cc:205:8: error: expected unqualified-id before '[' token
auto [target_width, target_height, rect_center_x, rect_center_y, rotation] =
^
mediapipe/calculators/image/image_cropping_calculator.cc:212:46: error: 'rect_center_x' was not declared in this scope
const cv::RotatedRect min_rect(cv::Point2f(rect_center_x, rect_center_y),
^
mediapipe/calculators/image/image_cropping_calculator.cc:212:61: error: 'rect_center_y' was not declared in this scope
const cv::RotatedRect min_rect(cv::Point2f(rect_center_x, rect_center_y),
^
mediapipe/calculators/image/image_cropping_calculator.cc:213:45: error: 'target_width' was not declared in this scope
cv::Size2f(target_width, target_height),
^
mediapipe/calculators/image/image_cropping_calculator.cc:213:59: error: 'target_height' was not declared in this scope
cv::Size2f(target_width, target_height),
^
mediapipe/calculators/image/image_cropping_calculator.cc:214:34: error: 'rotation' was not declared in this scope
rotation * 180.f / M_PI);
^
mediapipe/calculators/image/image_cropping_calculator.cc: In member function 'void mediapipe::ImageCroppingCalculator::GetOutputDimensions(mediapipe::CalculatorContext*, int, int, int*, int*)':
mediapipe/calculators/image/image_cropping_calculator.cc:389:8: error: expected unqualified-id before '[' token
auto [crop_width, crop_height, x_center, y_center, rotation] =
^
mediapipe/calculators/image/image_cropping_calculator.cc:392:28: error: 'crop_width' was not declared in this scope
const float half_width = crop_width / 2.0f;
^
mediapipe/calculators/image/image_cropping_calculator.cc:393:29: error: 'crop_height' was not declared in this scope
const float half_height = crop_height / 2.0f;
^
mediapipe/calculators/image/image_cropping_calculator.cc:398:38: error: 'rotation' was not declared in this scope
const float rotated_x = std::cos(rotation) * corners[i * 2] -
^
mediapipe/calculators/image/image_cropping_calculator.cc:403:48: error: 'x_center' was not declared in this scope
transformed_points_[i * 2] = ((rotated_x + x_center) / src_width);
^
mediapipe/calculators/image/image_cropping_calculator.cc:404:52: error: 'y_center' was not declared in this scope
transformed_points_[i * 2 + 1] = ((rotated_y + y_center) / src_height);
^
In file included from ./mediapipe/framework/calculator_base.h:24:0,
from ./mediapipe/framework/calculator_framework.h:54,
from ./mediapipe/calculators/image/image_cropping_calculator.h:5,
from mediapipe/calculators/image/image_cropping_calculator.cc:15:
mediapipe/calculators/image/image_cropping_calculator.cc: At global scope:
./mediapipe/framework/calculator_registry.h:24:39: warning: 'mediapipe::calculator_registration_54__' defined but not used [-Wunused-variable]
calculator_registration, name,
^
./mediapipe/framework/deps/registration.h:371:51: note: in definition of macro 'REGISTRY_STATIC_VAR_INNER'
#define REGISTRY_STATIC_VAR_INNER(var_name, line) var_name####line##__
^
./mediapipe/framework/deps/registration.h:381:16: note: in expansion of macro 'REGISTRY_STATIC_VAR'
static auto* REGISTRY_STATIC_VAR(var_name, LINE) =
^
./mediapipe/framework/calculator_registry.h:23:3: note: in expansion of macro 'REGISTER_FACTORY_FUNCTION_QUALIFIED'
REGISTER_FACTORY_FUNCTION_QUALIFIED(::mediapipe::CalculatorBaseRegistry,
^
mediapipe/calculators/image/image_cropping_calculator.cc:54:1: note: in expansion of macro 'REGISTER_CALCULATOR'
REGISTER_CALCULATOR(ImageCroppingCalculator);
^
./mediapipe/framework/calculator_registry.h:28:7: warning: 'mediapipe::access_registration_54__' defined but not used [-Wunused-variable]
access_registration, name,
^
./mediapipe/framework/deps/registration.h:371:51: note: in definition of macro 'REGISTRY_STATIC_VAR_INNER'
#define REGISTRY_STATIC_VAR_INNER(var_name, line) var_name####line##__
^
./mediapipe/framework/deps/registration.h:381:16: note: in expansion of macro 'REGISTRY_STATIC_VAR'
static auto* REGISTRY_STATIC_VAR(var_name, LINE) =
^
./mediapipe/framework/calculator_registry.h:26:3: note: in expansion of macro 'REGISTER_FACTORY_FUNCTION_QUALIFIED'
REGISTER_FACTORY_FUNCTION_QUALIFIED(
^
mediapipe/calculators/image/image_cropping_calculator.cc:54:1: note: in expansion of macro 'REGISTER_CALCULATOR'
REGISTER_CALCULATOR(ImageCroppingCalculator);
^
cc1plus: warning: unrecognized command line option '-Wno-ignored-attributes'
Target //mediapipe/examples/desktop/hand_tracking:hand_tracking_gpu failed to build
Use --verbose_failures to see the command lines of failed build steps.

Have you already solved this problem? I met the same error as you.

Thanks for pointing this out.
Looks like the way the GetCropSpecs() function is written requires  a c++17 capable compiler.
It probably should be rewritten to not require c++17.
I will look into updating this, and have the output parameter be part of the function call or something.
Meanwhile if you want it to work now, then you can upgrade gcc to one that can handle c++17, or rewrite the function to be
void GetCropSpecs(const CalculatorContext* cc,
                  int src_width, int src_height, RectSpec* spec);

I solved the above issue by reinstall gcc and g++ to the new version, which match C++17. Agree with that.

Glad to hear you got things working.
The recent update
https://github.com/google/mediapipe/commit/a3d36eee32999290c1461d469dc33cf63ccdf03a
has removed the need for c++17


Not displaying what I'm listening to, when Last.fm is says I have something scrobbling now

Hi there, when I go on Descent and enter my lastfm username (AndrewRobinson1), it shows "Nothing in the air...", even when there is something showing as scrobbling now on my lastfm page. Hopefully it's just something I'm messing up somehow, but the site used to work for me.

Is your profile/history set to private? It looks like the API request for your recent tracks is failing with error Login: User required to be logged in, so that's my first guess.

It was, must've changed that one day without realizing

Glad that fixed it!


Use AssertJ to provide more informative test failure messages

PR Checklist

[X] A description of the changes is added to the description of this PR.
[X] If there is a related issue, make sure it is linked to this PR.

Description of changes
Resolves #260.
Use AssertJ to ensure that test failure messages are informative, as suggested by @nastra's [comment]https://github.com/unitycatalog/unitycatalog/pull/256#discussion_r1683894084.

Replace boolean assertions on collections
Migrate away from using TestUtils#contains() in combination with boolean assertions on collection elements
Replace size/count checks on collection elements
Use AssertJ's fluent API to replace equality checks on Spark query row values

If there are any concerns or suggestions for further improvements regarding the changes introduced in commit  9d45725, please feel free to share.

@filipovskid could you resolve the conflicts please? It seems that unrelated formatting changes are included in this diff

@haogang  Can you merge this PR?


Implementation of different sorting algorithms using CPP

Description
Description
there are many sorting algorithms with different time , space complexity .
I will implement counting sort and explain it's complexity .
I am participating in gssoc'22. please assign this to me.
Domain
Algorithm
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

You can only contribute one sorting algorithm at a time in one issue not many and it will be good for you to because once your PR is created you'll be able to create new issue for next sorting algorithm , having different prs will give you more points
Edit your Desc. and come up with only one which is not present in repo and is not raised as an issue of other contributors.

I have edit the description , can you check it now  ?


（iOS）加载列表的时候怎么给他图片的占位符？

已经解决了，就是在没有加载出来前给一张默认图片

解决了你还不把解决方法写下来 = =！

以下是我的做法，在重写图片加载器的类中  使用sdwebimage的方法-(id )downloadImageWithURL:(NSURL *)url
options:(SDWebImageOptions)options
progress:(SDWebImageDownloaderProgressBlock)progressBlock
completed:(SDWebImageCompletionWithFinishedBlock)completedBlock；
在progressBlock回调中加载占位图片，下面是实现源码

以下是我的做法，在重写图片加载器的类中使用sdwebimage的方法- (id )downloadImageWithURL:(NSURL *)url
options:(SDWebImageOptions)options
progress:(SDWebImageDownloaderProgressBlock)progressBlock
completed:(SDWebImageCompletionWithFinishedBlock)completedBlock；
在progressBlock回调中加载占位图片，下面是实现源码  IMAGE_NAME 宏是： [UIImage imageNamed:name]

(id)downloadImageWithURL:(NSString *)url imageFrame:(CGRect)imageFrame userInfo:(NSDictionary *)userInfo completed:(void(^)(UIImage *image,  NSError *error, BOOL finished))completedBlock
{
NSString *placeholderName;
float imageRatio = imageFrame.size.width / imageFrame.size.height;
if (imageRatio > 3) {
placeholderName = @"place_holder_wide";
}else {
placeholderName = @"place_holder";
}
__block BOOL startDownload;
return (id)[[SDWebImageManager sharedManager] downloadImageWithURL:[NSURL URLWithString:url] options:0 progress:^(NSInteger receivedSize, NSInteger expectedSize) {
if (!startDownload && completedBlock) {
completedBlock(IMAGE_NAME(placeholderName), nil, NO);
startDownload = YES;
}
} completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, BOOL finished, NSURL *imageURL) {
if (completedBlock) {
if (error) {
completedBlock(IMAGE_NAME(placeholderName), error, finished);
}else {
completedBlock(image, error, finished);
}
}
}];
}

This PR/issue doesn't received response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


NSH: ps command broken between release 12.0 and 12.1

I noticed, that the ps command of the NSH library broke between release 12.0 and 12.1.
Specifically, I am testing the nucleo-h743zi2:nsh config, where I enabled CONFIG_FS_PROCFS and CONFIG_NSH_ARCHINIT to get the ps command in NSH. When executing the command (sometimes only on the second try) I get a hardfault. This starts happening with release 12.1 (still apparent with 12.3) and works as expected on 12.0.
Before debugging this in more detail. maybe somebody can help pointing in the right direction? I see that the LR points to tls_get_info and the PC to getumask during the hardfault.
Thanks!

@maxikrie I faced similar issue helping @JorgeGzm with witte board powered by stm32h753bi. I think it could be some issues related to STM32H7, because in other boards the issues doesn't happen

I tracked it down to changes introduced in nsh_console.c, nsh_console.h, nsh_proccmds.c between 12.0 and 12.1. If I revert only these files to 12.0, I don't see this issue.
I haven't reviewed these files in detail, but isn't the nsh library hardware agnostic? So how could this be STM32H7 specific issue?

@maxikrie so maybe this is not the same issue we are seeing in our board.
Confirming that ps on stm32f4discovery still working:
nsh> uname -a
NuttX 12.3.0 ffc7a192a0-dirty Dec 23 2023 17:58:59 arm stm32f4discovery

nsh> free
                   total       used       free    maxused    maxfree  nused  nfree
        Umem:     193400       7832     185568       9336     125008     37      3

nsh> ps
  PID GROUP PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK           STACK COMMAND
    0     0   0 FIFO     Kthread   - Ready<PHONE_NUMBER>000000 001008 Idle_Task
    2     2 100 RR       Task      - Running<PHONE_NUMBER>000000 002008 nsh_main
nsh>

Hi!
PTAL at https://github.com/apache/nuttx/pull/11425
On ESP32-S2, the problem with the ps command was related to the NSH's task stack size. The error didn't occur every time the command was run, but eventually. Increasing the stack size fixed the problem. My guess: TCB increased and requires more space depending on the arch.

Yes, I noticed this as well.
So, I increased the stack size for NSH task
CONFIG_SYSTEM_NSH_STACKSIZE=4096
but I also had to increase the stack size of the init task
CONFIG_INIT_STACKSIZE=4096
Does this make any sense or is this simply obfuscating the problem? In any case, so far I am not witnessing any crashes.

@maxikrie good question, I think more investigation will be needed. Note that I'm using the default stacksize in stm32f4discovery board.


521 notif is resolved

Adds is_resolved to the notification model, and resolve_on_read to the NOTIFICATION_CONFIG dict, denoting which notification_types automatically resolve when you read them. The notification PATCH checks this and updates is_resolved when setting is_read for those types. Behavior tested in test_notification_patch.
Subsequent work on branch 732-notif-collab-resolve sets is_resolved for collaboration requests when they are approved/denied (not included in this PR).

/rebase


[AutoPR logic/resource-manager] Microsoft.Logic - Don't make ResourceReference id readonly

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4491

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/507


Update akka community page

You might want to update the community page with some more info.
http://akka.io/community/

we should add badge

see https://github.com/scalacenter/scaladex/wiki/FAQ

I guess we can tick this off now...

Tags added and it's properly indexed now https://index.scala-lang.org/altoo-ag/akka-kryo-serialization/akka-kryo-serialization
badge added https://index.scala-lang.org/altoo-ag/akka-kryo-serialization/akka-kryo-serialization/latest.svg  (but it takes some time until github reverse proxy is up to date...)


Narrow time-machine to one resource

Use case:
There are thousand resources, but I am looking when and how was changes a specific  config map

hi @korjavin, this is definitely very useful. This was added to Kubevious SaaS. Because of differences in the way storage layer is implemented in SaaS vs open-source this capability is not easily portable.
For the time being I'd recommend trying it out with Kubevious SaaS, which is currently free, until we get bit more bandwidth and implement it for open-source. Here is an article and walkthrough about this: https://kubevious.io/blog/post/kubernetes-gremlins-what-broke-my-cluster

@korjavin, we have released the new Kubevious open-source version and the Change History capability is now ported to the open-source project. A quick how it works below (sorry for the poor gif quality, GitHub significantly reduces the image size):

Please try installing again using the latest chart and let us know how it works for you.
kubectl create namespace kubevious

helm repo add kubevious https://helm.kubevious.io

helm repo update

helm upgrade --atomic -i kubevious kubevious/kubevious --version 0.9.27 -n kubevious

For more details on installation options, visit Deployment Repository.


Startin UI with Landing and Project Index

This PR begins the initial layout of the app. The landing page should be visible when loading the app, and the /projects route should also be set up. This is very basic, and I chose this as a stopping point before the code got too bloated so I could get feedback on how things are set up in Grommet before proceeding further. I use mock data here.

@wgranger the Zooniverse Grommet v2 theme is available on npm at version 2.1.0. yarn add @zooniverse/grommet-theme and then there's an example on use in its readme on the repo.

I believe I'd addressed all comments from the initial review. This should be good for another look.


Create maintainance branch for Quarkus 3.2 LTS

Now the new LTS 3.8 of Quarkus is out, we need to create a new long term maintenance branch for this extension.

done


Vulkan: assert if Filament asks to resolve depth in the render pass.

Rather than asserting, we decided that backends should offer a query to let Filament know if this is supported.
Since that work is still WIP, I changed this PR back to a draft.


python3Packages.libpyvivotek: init at 0.4.0

Motivation for this change
Python Library for Vivotek IP Cameras
https://github.com/HarlemSquirrel/python-vivotek
This is a Home Assistant dependency.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146796 run on x86_64-linux 1

2 packages built:

python38Packages.libpyvivotek
python39Packages.libpyvivotek

@ofborg eval


arch-install-scripts: 24 -> 26

Description of changes
Taking over arch-install-scripts.
To make pacstrap work, a valid pacman.conf should be either placed in /etc or passed to pacstrap using -C option.

Closes https://github.com/NixOS/nixpkgs/pull/180031

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Thanks for taking over the maintainership.

Thank you so much :heart:


fix: use import instead of require for vite.config.js

I'm getting [ERR_REQUIRE_ESM]: require() of ES Module from not supported. errors if vite.config.js is required. Using import fixes this. Not sure if this is a good general solution though, so let me know if it has any unwanted side effects.

Never mind this does not do what I thought it does, I'll think of something else.

ESM is not supported by eslint-import-plugin right now, so the plugin must be written using CJS. There's no way around it.

Yeah, just looked through the repo issues, shame.

@musjj Have you solved this issue? I'm also facing the same problem.
In my case, I configured vite config as ESM and eslint as CJS. When using the vite.config.ts(js) file written in ESM for this plugin, I encounter an "out of module" error.
@pzmosquito I saw that you are using without any problem, do you happen to have a publicly accessible repository I can refer to?
Additionally, it would be great to have best practices or examples included in the package as well. :)

@musjj Have you solved this issue? I'm also facing the same problem.
In my case, I configured vite config as ESM and eslint as CJS. When using the vite.config.ts(js) file written in ESM for this plugin, I encounter an "out of module" error.
@pzmosquito I saw that you are using without any problem, do you happen to have a publicly accessible repository I can refer to?
Additionally, it would be great to have best practices or examples included in the package as well. :)

The How to use section in the README file is pretty much the simplifed version of my set up. I'd suggest that you set up an empty project with no other packages except eslint related ones. If you still see problem, please let me know; otherwise, gradually add more packages and see where the problem is.

@musjj Have you solved this issue? I'm also facing the same problem.
In my case, I configured vite config as ESM and eslint as CJS. When using the vite.config.ts(js) file written in ESM for this plugin, I encounter an "out of module" error.
@pzmosquito I saw that you are using without any problem, do you happen to have a publicly accessible repository I can refer to?
Additionally, it would be great to have best practices or examples included in the package as well. :)

The How to use section in the README file is pretty much the simplifed version of my set up. I'd suggest that you set up an empty project with no other packages except eslint related ones. If you still see problem, please let me know; otherwise, gradually add more packages and see where the problem is.

I'll retry soon. and if I can't solve the problem, I'll leave a message. Thanks to your kindness and your works.


Sort dependencies before saving package.json

Sorts the dependencies, devDependencies and
optionalDependencies properties.
Fixes #2

Nice work @zkochan :)


Maven shade plugin

Hi Jeremy,
I have updated pom.xml with maven shade plugin. Could you please take a look at the PR ?
https://github.com/jcustenborder/kafka-connect-solr/pull/5
Thank you.

@evolv34 Maven shade isn't a good idea with connectors. This is also controlled in a parent pom. Use on the the installation packages.


Proposal: link to extra data for packages and resources

In https://github.com/SomethingNewUK/finances/blob/gh-pages/datapackage.json, we have extra info resources out on the web for the package and resources, namely CSVlint validations for each file, and an Open Data Certificate for the package.
I don't think we need special fields to link to these, so I've added an optional links field to both the package itself and each resource which can contain a list of extra links, with URL and name.
I'd like to propose that as an addition to the spec. Any thoughts? Addition would be something like:
(in the optional section for package and resource)

links MUST be an array. Each entry MUST be a hash with a url and name property linking to external information related to the (package|resource).

Examples from the above link:
"links": [
  {
    "name": "Open Data Certificate",
    "url": "https://certificates.theodi.org/datasets/2254/certificates/14550"
  }
]

"links": [
  {
    "name": "CSV Validation",
    "url": "http://csvlint.io/validation/545c0a1363737645490a0000"
  }
]

WONTFIX. Good suggestion and my sense is that people should just add these in for the moment - as you have done. Once we have critical mass we can think about an extension to the spec.

As long as the addition of the link field doesn't violate the spec, then fine :)

@Floppy no additional fields are allowed - see note at bottom of http://dataprotocols.org/data-packages/#optional-fields

Is that missing a comma after the "no"? My reading is that additional fields ARE allowed :)

Fixed comment ;-)


Implement second type of rectangle node

Have 2 types of rectangles... one with border and rounded corners (already implemented, rounded corners separate issue) and one without border but nice shadow beneath.

This can be re-opened if someone wants to work on it.


how to enable inflight batching, parallel embedding, rope for new trt-build?

System Info
.
Who can help?
@juney-nvidia
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
.
Expected behavior
.
actual behavior
.
additional notes
previously there were options for the following in build.py
i've been able to translate most of the build options to the new system but i can't seem to figure out the following options:
        --use_parallel_embedding \
        --use_inflight_batching \
        --rotary_base 1000000 \
        --rotary_scaling dynamic 2.0 \

is it somehow in the build config or plugin config files passed in? those seem like just file versions of the params.

i understand inflight batching is part of gpt attention plugin which i have enabled - does it now do it automatically?

Yes, to use inflight batching, you need to enable gpt_attention_plugin, paged_kv_cache and remove_input_padding


Build fails due to transitive dependencies

Description
Build fails due to transitive dependencies
Issues Resolved
Closes https://github.com/opensearch-project/opensearch-sdk-java/issues/857
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @reta!

Folks, backport to 1.x may not be need, the opensearch-java does not bring Apache HttpClient5 / HttpCore5 by default - this is opt-in only


DEV: Barf more usefully on empty string for docker status.

One of my containers died violently on startup and docker started returning an empty string for a status.  Not sure yet what causes this, but throwing an explicit error here is more useful than an IndexError, which was the previous behavior.

:+1: always good to have more useful barf.

Thanks @ssanderson.


schema.graphql support

Hi!
Along with support for .json schemas, will there be support for .graphql schemas?

Absolutely! If you have the time to give it a shot that would be great - the schema loading logic lives here. Should be relatively straight forward to check the filepath's extension and call the right function from graphql-js

Alright! I'll try it in about 8 hours. Thanks!

Closing this since #77 went in


Updating to JsonWebKey

Fixes - https://github.com/TBD54566975/web5-spec/issues/73

@nitro-neal are we removing JsonWebKey2020 or also supporting JsonWebKey in addition? i asked about this in our internal slack and @frankhinek said we should support both for a while, so that's what my PR had
slack thread with frank's comment here
my PR here

@jiyoontbd yup I'm getting this one in: https://github.com/TBD54566975/web5-kt/pull/233 then once it works with jsonwebkey2020 and jsonwebkey I can merge this one in and it will work with both

looks like this one can be merged now @nitro-neal ?

Closing as ion is going away and this will need a large refactor, will revisit in the future


doc(spec/geo-path): 修改不明语意

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.39%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10400

Relevant Lines:
11660

💛  - Coveralls


feat: Publish this extension to Open VSX

Description
Currently VSCodium, Eclipse Theia, Code - OSS by default uses openvsx, for the users of those product including me can use this extension.
Requirements

[ ] Publish the extension on openvsx

Additional Context
More details at :-

https://github.com/eclipse/openvsx/wiki/Publishing-Extensions
https://www.eclipse.org/legal/open-vsx-registry-faq/

Dear extension author,
Please publish this extension to the Open VSX marketplace.
Context
Unfortunately, as Microsoft prohibits usages of the Microsoft marketplace by any other products or redistribution of .vsix files from it, in order to use VS Code extensions in non-Microsoft products, we kindly ask that you take ownership of the VS Code extension namespace in Open VSX and publish this extension on Open VSX.
What is Open VSX? Why does it exist?
Open VSX is a vendor neutral alternative to the MS marketplace used by most other derivatives of VS Code like VSCodium, Gitpod, OpenVSCode, Theia-based IDEs, and so on.
You can read on about Open VSX at the Eclipse Foundation's Open VSX FAQ.
How can you publish to Open VSX?
The docs to publish an extension can be found here. This process is straightforward and shouldn't take too long. Essentially, you need an authentication token and to execute the ovsx publish command to publish your extension. There's also a doc explaining the whole process with an example GitHub Action workflow.

Thanks @mrhyperbit for opening this issue!
For the time being we're actively working on support for just VS Code. I would personally love to get the extension on as many IDEs as possible but there might be a maintenance cost associated to it (we would like to ensure the best support).
We will reconsider publishing the extension outside VS Code Marketplace once version one is released or if there is enough community interest.
For the time being, are you able to download the latest executable here by clicking Download and installing it in your IDE?

Absolutely, I've got the extension up and running flawlessly.
The maintenance cost is very low since we could have a github actions workflow to effortlessly publish updates on both the Visual Studio Code Marketplace and OpenVSX Marketplace.
More Details :- Publishing Extension To Open VSX


PhysFS considers some .zip files modified by Windows Explorer corrupted

This has been affecting VVVVVV, which uses PhysFS, and which uses a data.zip file with the game's assets (found here, via [Desktop data file]). Whenever people would add/remove any file in the zip with Windows Explorer, the entire zip would become (seemingly) completely unreadable to the game.
Digging into this deeper, this is caused by a validity check in PhysFS. These are some reproduction steps:

Start a zip file with 2 files with software that sets the Extract OS in file's headers to something other than 00 'MS-DOS' (I used Engrampa which came with my Linux distro, apparently zip from the terminal does not qualify.) Here's my version: test-2unix.zip

Observe the headers with zipdetails:

0000 LOCAL HEADER #1       04034B50
0004 Extract Zip Spec      0A '1.0'
0005 Extract OS            03 'Unix'
[...]

0037 LOCAL HEADER #2       04034B50
003B Extract Zip Spec      0A '1.0'
003C Extract OS            03 'Unix'
[...]

006E CENTRAL HEADER #1     02014B50
0072 Created Zip Spec      3F '6.3'
0073 Created OS            03 'Unix'
0074 Extract Zip Spec      0A '1.0'
0075 Extract OS            03 'Unix'
[...]

00C5 CENTRAL HEADER #2     02014B50
00C9 Created Zip Spec      3F '6.3'
00CA Created OS            03 'Unix'
00CB Extract Zip Spec      0A '1.0'
00CC Extract OS            03 'Unix'
[...]

In Windows Explorer (tested with Windows 10 and 11), drag and drop a third file into the zip. My result: test-2unix-1ms.zip

Observe the new headers with zipdetails:

0000 LOCAL HEADER #1       04034B50
0004 Extract Zip Spec      0A '1.0'
0005 Extract OS            03 'Unix'
[...]

0037 LOCAL HEADER #2       04034B50
003B Extract Zip Spec      0A '1.0'
003C Extract OS            03 'Unix'
[...]

006E LOCAL HEADER #3       04034B50
0072 Extract Zip Spec      14 '2.0'
0073 Extract OS            00 'MS-DOS'
[...]

00A5 CENTRAL HEADER #1     02014B50
00A9 Created Zip Spec      14 '2.0'
00AA Created OS            00 'MS-DOS'
00AB Extract Zip Spec      14 '2.0'
00AC Extract OS            00 'MS-DOS'
[...]

00FC CENTRAL HEADER #2     02014B50
0100 Created Zip Spec      14 '2.0'
0101 Created OS            00 'MS-DOS'
0102 Extract Zip Spec      14 '2.0'
0103 Extract OS            00 'MS-DOS'
[...]

0153 CENTRAL HEADER #3     02014B50
0157 Created Zip Spec      14 '2.0'
0158 Created OS            00 'MS-DOS'
0159 Extract Zip Spec      14 '2.0'
015A Extract OS            00 'MS-DOS'
[...]

PhysFS now considers the first two files corrupted and refuses to process them.

So what Windows Explorer apparently does when it modifies the zip file is update the version numbers/OS for all existing files in the central headers, but it leaves them as-is in the local headers.
The check in PhysFS which fails is in zip_parse_local in physfs_archiver_zip.c, specifically ui16 != entry->version_needed. ui16 being Extract Zip Spec/Extract OS in a local header, and entry->version_needed being Extract Zip Spec/Extract OS in the corresponding central header.
Adding this printf demonstrates it:
diff --git a/src/physfs_archiver_zip.c b/src/physfs_archiver_zip.c
index 9972628..99d4dbc 100644
--- a/src/physfs_archiver_zip.c
+++ b/src/physfs_archiver_zip.c
@@ -833,6 +833,9 @@ static int zip_parse_local(PHYSFS_Io *io, ZIPentry *entry)
     BAIL_IF_ERRPASS(!readui32(io, &ui32), 0);
     BAIL_IF(ui32 != ZIP_LOCAL_FILE_SIG, PHYSFS_ERR_CORRUPT, 0);
     BAIL_IF_ERRPASS(!readui16(io, &ui16), 0);
+    printf("ui16: 0x%04x, entry->version_needed: 0x%04x\n",
+        ui16, entry->version_needed
+    );
     BAIL_IF(ui16 != entry->version_needed, PHYSFS_ERR_CORRUPT, 0);
     BAIL_IF_ERRPASS(!readui16(io, &ui16), 0);  /* general bits. */
     BAIL_IF_ERRPASS(!readui16(io, &ui16), 0);

The output from my "minimal" test program (main.c) is as follows for the Unix-only zip:
$ ./main test-2unix.zip
ui16: 0x030a, entry->version_needed: 0x030a
ui16: 0x030a, entry->version_needed: 0x030a
File a.txt: 20/20 bytes
File b.txt: 20/20 bytes

And this for the Explorer-modified zip:
$ ./main test-2unix-1ms.zip
ui16: 0x0014, entry->version_needed: 0x0014
ui16: 0x030a, entry->version_needed: 0x0014
Cannot enumerate files! corrupted

So, I don't know whether Explorer is in the wrong here by updating one type of header and not the other, or whether PhysFS makes an incorrect assumption that this is invalid, but other software seems to have no problems with these zips.

Explorer is wrong here, but this is easy to workaround; we'll stop treating it as corruption and just favor the info in the local header for that field.


Add white background color to native dropdown

background property overrides background-color set in vanilla-text-field()

:tada: This PR is included in version 4.5.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixed Broken Link

Fixed Broken Link Mapping

@ronakbanka
I have rised a PR for this issue.
You can check
https://github.com/cloudfoundry-incubator/diego-design-notes/pull/13

@savitaashture Ahh okk..!! closing this one.