Unable to improve advisory database for C / C++ packages

Indeed it is documented in the README that contributions are not accepted for advisories outside the supported ecosystems. But some of the most high-impact vulnerability bulletins that need improvements are in C and C++ packages that don't have an "ecosystem" as such. They are part of all the ecosystems.
I would really like to be able to improve https://github.com/advisories/GHSA-mq29-j5xf-cjwr in light of all the confusion seen in https://github.com/madler/zlib/issues/868#issuecomment-1821577241. But there's no way to do this.
What could possibly be done to improve these bulletins?

An important ticket!

They are part of all the ecosystems.

That's kinda the problem actually. Our ecosystems provide a one to one mapping between some package namespace and an advisory. We don't have false positives as a result and it results in more actionable advisories and better outcomes for developers receiving alerts.

What could possibly be done to improve these bulletins?

It's an open question and one that we're thinking about.
For what it's worth we do have plenty of advisories which are about C/C++ code which has been bundled into a package in one of our ecosystems
eg. https://github.com/advisories?query=tensorflow+type%3Areviewed+ecosystem%3Apip

Big part of the C/C++ ecosystem relies either on git-submodules or CMake built-in functionality.
The first must be trivial to track for GitHub, the second one can probably be decently solved using RegEx.
A typical CMakeLists.txt may start like this:
cmake_minimum_required(VERSION 3.14)
project(MyProject VERSION 1.0)

include(FetchContent)
FetchContent_Declare(
  SomeLibrary
  GIT_REPOSITORY https://github.com/username/SomeLibrary.git
  GIT_TAG        main # or specific version tag
)
FetchContent_MakeAvailable(SomeLibrary)

include(ExternalProject)
ExternalProject_Add(
  OtherLibrary
  GIT_REPOSITORY https://github.com/username/OtherLibrary.git
  GIT_TAG        main # or specific version tag
  SOURCE_DIR     "${CMAKE_BINARY_DIR}/_deps/otherlibrary-src"
  BINARY_DIR     "${CMAKE_BINARY_DIR}/_deps/otherlibrary-build"
  CONFIGURE_COMMAND "" # Custom configure command
  BUILD_COMMAND     "" # Custom build command
  INSTALL_COMMAND   "" # Custom install command
  TEST_COMMAND      "" # Custom test command
)
include_directories(${some_library_SOURCE_DIR}/include)

In that case, matching GitHub-hosted dependencies is probably as easy as:
(?:FetchContent_Declare|ExternalProject_Add)\s*\([^)]*\bGIT_REPOSITORY\s+https:\/\/github\.com\/[^\s)]+

This would cover a huge part of the ecosystem and will be invaluable for dependency analysis and security audits of low-level infrastructure.

Thanks all for the feedback here! We at GitHub are actively exploring what we can do in this space, so all ideas welcome! I'll keep this issue open in case more folks want to chime in and share thoughts/ideas.

I understand the narrow ecosystem support argument (the data is incredibly high quality)
Perhaps there could be a way to discuss some community support for non supported ecosystems. For example this could be related to
https://github.com/github/advisory-database/issues/2900
Now that Grype relies on the GitHub data, there are some instances where we need to modify data in order to provide users with the best experience possible (we don't really want to do this, but there's no way around, especially for NVD data)
https://github.com/anchore/grype/issues/1607
The GitHub Advisory Data is considerably easier to modify than other data sources, but there are times we cannot submit updates here, usually because the ecosystem is unsupported.

There was a proposal from Oliver at https://github.com/github/advisory-database/discussions/568#discussioncomment-3330460, on how to potentially mark unsupported ecosystems in OSV. What are folks' feelings on adopting that?

I would much rather we figure out a useful way to map the data rather. Accepting and validating contributions on a multitude of undefined/undefinable ecosystems is not exactly viable.

in case there's confusion about the advisory, after I opened this issue https://github.com/advisories/GHSA-mq29-j5xf-cjwr was essentially somewhat repurposed for a supported ecosystem: Python.


ServiceBus Track2 AsyncReceiver  receiveDeferredMessage(Iterable

Reference : https://apiview.azurewebsites.net/Assemblies/Review/5df407a05bd74cd1a485bd46a55600a3
JonathanGiles
What is the use case for a user to call this method? How would they get the Iterable of sequence numbers to pass into this?

Closed in favour of #4506


transport: Add a pure Go AX.25 implementation

It would be nice to be able to support AX.25 platform-independent.
This will probably be a project on it's own.

I stumbled across a promising node project that implements the full stack:
https://github.com/echicken/node-ax25
It could be a nice starting-point. Maybe we could port it to Go?

How hard would it be to just bundle node-ax25 and call it directly?

@LightAxe - I don't know if anyone have attempted to call node/javascript code from Go, but it would require bundling a js/node engine with the library and a rather complicated wrapper I presume. I think our best bet is to port an existing and well tested implementation to Go.
I've opened a new issue for future discussions on this topic: Issue #56.

I have just finished implementing an AX25 library in C.  It's part of the gensio library at https://github.com/cminyard/gensio and it's portable to Windows, MacOS, and Linux.  It has C++ and Python bindings at the moment.  I assume Go wouldn't be very hard.
I would really like to avoid having to deal with the Linux kernel AX25 stack.  I don't know Go, though.  I could learn it if you are interested.
The gensio library can do a lot of other things that might be useful, too.
Obviously it hasn't been around that long, but I'm planning to keep working on it.  I have my own uses for it.


Fix README.md

Thanks for the fix. I also fixed the same mistake in the rrbot README.md and updated the MuJoCo version requirements while I was there.


Files "migrate" out of folders while editing them.

Shared Program: Program was unshared.
Description
I saw this in code.world/haskell, but I'm positive I've seen the same phenomenon on 'plain' code.world.
-I created a subdirectory "Directory".
-I created a new empty file, saved it to a name "My Program", and began editing it.
-I save fairly regularly as a matter of habit.
At some point, and I don't know when, I logged in on another machine and noticed that it seemed like my changes were gone.  Upon inspection, what I saw was that a new copy of "My Program" (with the 'missing' changes) was now living at the root level of code.world, and the file in the subfolder was an older revision.
In the past I've always assumed that I somehow created the file in the wrong place, but today I literally logged in to a single machine, created a file, and saw this phenomenon happen while I was editing.

I think this and #1219 are the final straw.  This world that was created by the folder migration isn't sustainable.  There are separate states for the selected file and the currently open file, and they are kept in sync with a bunch of ad hoc rules.
This weekend, I'll take a crack at rewriting this to keep one unified state for the open project, and a single adapter to keep the UI updated with respect to that state.


Remove some vertical white space from the home page

Quite a few people (including several of the experienced admins) don't realize that there is more to the home page than the Read and Listen boxes because that is all that shows when the page opens on some screens - so it isn't obvious that you should scroll down for more content. In particular folks don't realize that the new releases are lower down on this page.
It does seem like some of the vertical spacing could be removed so that a bit more of the lower part of the page was visible.
https://forum.librivox.org/viewtopic.php?p=939217#p939217 (post in the admin area)
Priority: 1-2

Looks like this one would best be fixed from the Wordpress theme repository.  Closing and re-opening there.  :+1:


Update DG and ppp

Added summary use case
Added effort appendix

Addresses https://github.com/AY2122S1-CS2103-T14-1/tp/issues/202
Closes https://github.com/AY2122S1-CS2103-T14-1/tp/issues/203

Codecov Report

Merging #207 (7760148) into master (1836268) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage     70.68%   70.68%
  Complexity      629      629
=========================================
  Files            90       90
  Lines          1958     1958
  Branches        235      235
=========================================
  Hits           1384     1384
  Misses          482      482
  Partials         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1836268...7760148. Read the comment docs.


feat: Java graphql IAM template

Description of changes
The PR is to add Java template example that allow Lambda function to make a GraphQL request to a AppSync API.
created in chain with https://github.com/aws-amplify/amplify-cli/pull/10997.
Changes include:

adding Lambda templates for IAM model types
Checks to add template if Apsync API and IAM auth are present.
add e2e tests for different scenarios

Issue #, if available

Description of how you validated changes
Checklist

[X] PR description included
[X] yarn test passes
[X] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #11020 (61de5e0) into dev (3c39eba) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #11020   +/-   ##
=======================================
  Coverage   47.82%   47.82%
=======================================
  Files         669      669
  Lines       32678    32678
  Branches     6608     6608
=======================================
+ Hits        15627    15628    +1
+ Misses      15419    15418    -1
  Partials     1632     1632

Impacted Files
Coverage Δ

...li/src/domain/amplify-usageData/getUsageDataUrl.ts
100.00% <0.00%> (+12.50%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ykethan what's the status of this?


Use the new formatted issue templates

You can test this at https://github.com/nicolo-ribaudo/pdf.js/issues, and https://github.com/nicolo-ribaudo/pdf.js/issues/1 is an example of the generated issue. It's unfortunate that all the small questions (such as "Operating system and its version") get their own header, but hopefully it will help with getting all the necessary info filled in properly.

It seems like there is no way to have a yes/no required option whose default value is "unselected". I made the questions about "does this happen in the latest version" and "is this relevant to Firefox" default to no.

I have requested a review from myself and @calixteman as additional sign-off on this. I'll try to have this reviewed tomorrow.

LGTM!
Question: should we have "Is the bug present in the latest PDF.js version?" be "Yes" by default since that should be the most common answer?

Default updated 👍

Now that all four approvals are in and the discussed feedback is addressed, let's do this. This should increase the quality of the bug reports, and if need be we can always tweak it further. Thank you for doing this!


question about whammy

if whammy is based on canvas, it means whammy can't capture cross domain images??

That's correct.


Add MapPredicate

Add a MapPredicate type that maps one type to another type before applying an inner predicate. Specifically useful for extracting fields from a struct before evaluating the predicate.

This API generally feels odd to me, it took me a bit to understand what was happening.
First, I think it's odd (although not unprecedented in rust) that you have a top-level map. I think it would be better to attach this to the existing predicates so you'd have something like eq(2).map(|x| x.number). Although that's still kinda odd, since it's backwards since you're not mapping across the eq(2), you're mapping across later input. Maybe 'map' wouldn't be the right word then, maybe 'mapper' which more implies it takes a 'map' function, but isn't directly mapping over the preceding statement's value.
If you don't agree with that, I'd at least suggest that it'd make more sense if you transposed the function parameters to have map<P, F, T, U>(predicate: P, transform: F) to make it match the order of things like https://doc.rust-lang.org/std/cell/struct.Ref.html#method.map and make it easier to read in the case that you have a long function.
Feel free to tell me I'm wrong, you've probably thought about this more than I have.

This API generally feels odd to me, it took me a bit to understand what was happening.

I agree that this feels odd and I've wracked my brain trying to figure out something more ergonomic. I went with map because it is literally maps a predicate over A into a predicate over B. It also kind of aligns with the map function from the futures library, and I've taken a lot of inspiration from the design of that library.
But there's got to be a better way. I'm going to leave this unmerged for now and hopefully figure out what the better way is.

See #4 - I think it provides a way nicer way of accessing member fields of a struct and gives a lot of flexibility in general. I'm going to close this PR in favor of that.


Make specification of SDK version clearer

(Related to https://github.com/microsoft/MSBuildSdks/issues/108)
This PR doesn't add information. It tries to make it easier to discover when reading quickly.
I'll admit to skim-reading this page and missing the syntax for specifying a version on the Sdk attribute. I should/could have read it, but was in a hurry and just read the code blocks looking for guidance.

@drewnoakes : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Ping @Mikejo5000

@drewnoakes Thanks! LG2M

#sign-off


[SPARK-18356] [ML] KMeans should cache RDD before training

What changes were proposed in this pull request?
According to request of Mr. Joseph Bradley , I did this update of my PR https://github.com/apache/spark/pull/15965 in order to eliminate the extrat fit() method.
@jkbradley
How was this patch tested?
Pass existing tests

Can one of the admins verify this patch?

Test build #3508 has started for PR 16295 at commit 7c4883f.

CC @jkbradley for approval

Test build #3510 has started for PR 16295 at commit 7c4883f.

Test build #3510 has finished for PR 16295 at commit 7c4883f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master

This looks fine, thanks!


Fix Swift 'protocol' keyword

Change Protocol to protocol.

@ileitch Would you be able to make the change suggested by @Golmote? If not, I'd be happy to pick this up. Let me know.

@mAAdhaTTah You're welcome to take it. Prism is also missing the extension keyword.


Error out of the box

I installed the generator and started a new project, i chose express and sequlize, after installation of dependencies, i tried to start the app with npm start, but there was an error:
TypeError: Cannot read property 'warn' of undefined     at SequelizeTrailpack.validate (/home/hamid/Projects/Personal/trails/node_modules/trailpack-sequelize/index.js:18:34)     at app.after.then.then (/home/hamid/Projects/Personal/trails/node_modules/trails/lib/Core.js:191:24)     at <anonymous>     at process._tickCallback (internal/process/next_tick.js:188:7)     at Function.Module.runMain (module.js:686:11)     at startup (bootstrap_node.js:187:16)     at bootstrap_node.js:608:3 Error: config.web.express is absent, please npm install your express version (4 or 5) and uncomment the line under config.web.express     at Express.validate (/home/hamid/Projects/Personal/trails/node_modules/trailpack-express/index.js:29:9)     at app.after.then.then (/home/hamid/Projects/Personal/trails/node_modules/trails/lib/Core.js:191:24)     at <anonymous>     at process._tickCallback (internal/process/next_tick.js:188:7)     at Function.Module.runMain (module.js:686:11)     at startup (bootstrap_node.js:187:16)     at bootstrap_node.js:608:3 (node:9643) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): TypeError: Cannot read property 'warn' of undefined (node:9643) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. (node:9643) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 4): Error: config.web.express is absent, please npm install your express version (4 or 5) and uncomment the line under config.web.express

Also tried Hapi with sequlize and here is the error:
TypeError: Cannot read property 'warn' of undefined     at SequelizeTrailpack.validate (/home/hamid/Projects/Personal/trails/node_modules/trailpack-sequelize/index.js:18:34)     at app.after.then.then (/home/hamid/Projects/Personal/trails/node_modules/trails/lib/Core.js:191:24)     at <anonymous>     at process._tickCallback (internal/process/next_tick.js:188:7)     at Function.Module.runMain (module.js:686:11)     at startup (bootstrap_node.js:187:16)     at bootstrap_node.js:608:3 (node:10403) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'warn' of undefined (node:10403) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Then i chose Hapi + waterline, there is no error but nothing happens when a start the server

Basically nothing works, at all

Tnx


Add when directive

This PR adds a when directive, which can be used to efficiently switch between templates.
Based on the condition, either the 'if' or the 'else' value is rendered. When switching between conditions, the previously rendered DOM is cached and re-used instead of recreated.
Caching is done by reparenting the the rendered content into a detached dom node when the condition switches. I didn't change any code in the actual library itself, but I think might be useful to create some extra helper functions for moving around part contents. Repeat could also make use of this.
I think this concept could be extended further by creating a 'switch' directive which switches between dom content and caches nodes.

Yeah, I agree. Lazy evaluation is something we will need in other places, it'd be nice to handle this in the core somehow. Currently functions are rendered as a string, maybe lit could just unpack the function when passed as a value. Would that introduce much overhead for regular rendering?

I think lazy evaluation is only necessary in a context where multiple results are possible.
If lit is to assume that all functions return results, should it always just call the function and render the results instead? What if the function returns another function? There's a lot of corner cases to handle here, and I don't think it should be the responsibility of core to do this.
The issue can easily be solved in the relevant directives, in this case:
if (condition) {
  value is ifValue();
} else {
  parts.reverse();
  value = elseValue();
}

Which changes the API to:
html`${when(condition, () => html`

`, () => html``)}`

It's just a question of what API you want the directive to have. As I mentioned above, I think any directive with multiple options should always be lazy-evaluated by default, because it is easy for developers to make mistakes otherwise.

Don't assume that consumer will be using TypeScript. You can rely on the type as much as you want to assert that the docs have to be followed exactly. In this case, JS users are so used to "truthiness" that we should support it.

condition = !!condition is a fine way to do this, and you could even type condition as unknown. Make sure you test initial render in both the true and false cases.
I for one will be using this lib when it his 1.0 and WILL NOT be using Typescript to save my life. :)

@LarsDenBakker #436 is submitted, so please rebase to master now.

I rebased onto master


Update code of conduct

Incorporated code of conduct from the Brain Networks in Python project.
Updated to be specific to Mental Hues and to include text relating to mental health disorders.

Thank you, Kirstie! I will merge your changes, and will make sure the links to different pages work.


Angular 5 Prod Build fails with AOT for relative paths

"dependencies": {
"@agm/core": "1.0.0-beta.3",
"@angular/animations": "^5.2.11",
"@angular/common": "^5.2.11",
"@angular/compiler": "^5.2.11",
"@angular/core": "^5.2.11",
"@angular/forms": "^5.2.11",
"@angular/http": "^5.2.11",
"@angular/platform-browser": "^5.2.11",
"@angular/platform-browser-dynamic": "^5.2.11",
"@angular/router": "^5.2.11",
"@compodoc/compodoc": "^1.1.3",
"@ng-bootstrap/ng-bootstrap": "^1.1.2",
"@ngx-translate/core": "^9.1.1",
"@ngx-translate/http-loader": "^2.0.1",
"@swimlane/ngx-charts": "^7.4.0",
"@swimlane/ngx-datatable": "^12.0.0",
"angular-calendar": "^0.24.1",
"angular-plotly.js": "^0.1.13",
"angular-split": "^1.0.0-rc.3",
"angular-tree-component": "^6.1.0",
"angular2-text-mask": "^9.0.0",
"bootstrap": "^4.1.1",
"cesium": "^1.46.1",
"classlist.js": "^1.1.20150312",
"core-js": "^2.5.6",
"d3": "^5.4.0",
"d3-collection": "^1.0.4",
"d3-ng2-service": "^2.2.0",
"date-fns": "^1.29.0",
"dragula": "3.7.2",
"intl": "^1.2.5",
"ng-sidebar": "7.2.0",
"ng2-dragula": "1.5.0",
"ng2-file-upload": "1.3.0",
"ng2-toasty": "^4.0.3",
"ng2-validation": "4.2.0",
"ngx-logger": "^2.2.4",
"ngx-toastr": "^8.7.3",
"npm": "^5.10.0",
"plotly.js": "^1.38.2",
"quill": "1.3.6",
"resize-observer-polyfill": "^1.5.0",
"rxjs": "5.6.0-forward-compat.5",
"satellite.js": "^2.0.2",
"screenfull": "^3.3.2",
"spinthatshit": "^1.0.4",
"text-mask-addons": "^3.7.2",
"web-animations-js": "^2.3.1",
"zone.js": "^0.8.21"
},
"devDependencies": {
"@angular/cli": "1.7.4",
"@angular/compiler-cli": "^5.2.11",
"@angular/language-service": "^5.2.11",
"@types/d3": "^5.0.0",
"@types/jasmine": "~2.8.8",
"@types/jasminewd2": "~2.0.3",
"@types/lodash": "^4.14.109",
"@types/node": "~6.0.112",
"angular-ide": "^0.9.41",
"codelyzer": "^4.3.0",
"jasmine-core": "~3.1.0",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~2.0.2",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "^2.0.1",
"karma-jasmine": "~1.1.2",
"karma-jasmine-html-reporter": "^1.1.0",
"protractor": "~5.3.2",
"ts-node": "~6.1.0",
"tslint": "~5.10.0",
"typescript": "~2.5.3"
}

ng build - Everything works fine
ng build --prod --aot --progress --verbose --base-href=/SPACEOPS/ --app SPACEOPS      This fails to resolve relative paths
ng build --prod --aot=false --progress --verbose --base-href=/SPACEOPS/ --app SPACEOPS     This works fine

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

Closing as no reproduction was provided


DD-1458 Fix Uncontrolled data used in path expression - Part-2 A

Fixes DD-1458 Fix Uncontrolled data used in path expression
Description of changes
How to test
Related PRs
(Add links)

Notify
@DANS-KNAW/core-systems

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.15%. Comparing base (ea3d041) to head (be224f1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #50      +/-   ##
============================================
+ Coverage     80.11%   80.15%   +0.04%
  Complexity      415      415
============================================
  Files            73       73
  Lines          1418     1421       +3
  Branches        118      120       +2
============================================
+ Hits           1136     1139       +3
  Misses          239      239
  Partials         43       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use a higher version of lua-resty-openidc to support 4096 bit keys

Hello!
Currently when using 4096 bit keys (with specifically hydra oauth2 server) lua-resty-openidc returns the following error:
public key decode error: RSA lib: nested asn1 error: bad object header: too long
Upgrading to the latest version of lua-resty-openidc fixes this.
If you need more information, please advice.

Pull Request Test Coverage Report for Build 123

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.296%

Totals

Change from base Build 121:
0.0%

Covered Lines:
130

Relevant Lines:
135

💛  - Coveralls


Can't assign folder path on Chrome OS with Crouton

When creating a new project on my Chromebook running Linux via Crouton, I can't add an associated path to a project.
When I select a different folder, the default path stays in the input box. I'll have to create the project and edit the config-file manually to assign the correct path. After that it works like it should.

hey there. sorry for the delay. will check the behaviour in my environment. cannot test in yours but i guess it ain't from env.

Thanks, if you need me to try something let me know!

Hi @Duncank, please can you describe better this issue?
What I understand:

Project create model opens
You add the first folder path (and it will automatically fill the input as the folder name for convenience)
You add another root path (this will not change the input).
Input will only change if it's empty and the folders is also empty.

Please give me a walkthrough on this.
Thanks

Project Create model opens
I enter the project name and select a group
The associated path field is empty and I can't type in it, so I hit the "Add paths" button.
I select a folder or create one and select that, for example /home/duncan/testproject
Only /home/duncan shows up in the associated paths line

So now I need to save this new project, and edit the project viewer file to update the path to the correct one. Once again, it is possible this is due to how Crouton works on Chrome OS, maybe they do something weird to access the disk partitions used by Chrome OS or something.

sorry for not checking this in a fast way but just didn't manage to get the time to it. Please be patient. Will appreciate it.

No worries, take your time! I know the workaround so I can do my work. Just trying to help you improve this.

haven't forgot you! tomorrow i will be releasing the new version, if you still use this plugin @Duncank, please give me feedback if this still occurs.
Thanks

please validate

It took some time before Atom discovered the update on my ChromeOS, but I managed to install it just now.
The update does not seem to fix my problem, but I've found some more info that might clear things up, and make it easier for me in the mean time:
If I click "add a root path" and browse to the folder I want in the explorer window:

if I create a directory "test" and go into it and press "OK", the root path becomes "/home/duncan".
if I create a directory "test" and go back up and select the folder (not go into it) and press "OK", the root path becomes "/home/duncan/Downloads/atom/test". So that works.

hummmm, ok, that clears any doubts, really don't know if this is an OS problem, of not detecting the newly created folder. thanks, will investigate more

it doesn't only happen with newly created folders, it also happens with existing folders. Once I go into the final folder I want to select, it doesn't add the right path. If I just select it in the folder list, it works.

Hi @Duncank,
Can you please try to mimic the behavior by File -> Open...? Could not replicate it on my machine :(

I'm back at my Chromebook today so I could test this;
When I open a folder that way it behaves the same, so I guess this is an Atom problem and not a plugin-problem. Sorry to bother you with this!

No problem @Duncank!
We never know what is the source right? Thanks once again for testing it.
Will close this.


Create xatu

Xi'an Technological University

@whitexatu Please rename lib/domains/cn/edu/xatu to lib/domains/cn/edu/xatu.txt
Thank you.

@whitexatu I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and rename the file or submit a new request with correct name. Thank you for the understanding!


Dense does not flatten inputs with rank >2 and behaves exactly like TimeDistributed(Dense)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS 10.13.6
TensorFlow installed from (source or binary): from pip install
TensorFlow version (use command below): v2.0.0-beta0-16-g1d91213fe7 2.0.0-beta1
Python version: v3.6.7:6ec5cf24b7, Oct 20 2018, 03:02:14

Describe the current behavior
A note in Dense documentation says that

Note: If the input to the layer has a rank greater than 2, then it is flattened prior to the initial dot product with kernel.

I don't see this happening in real life. Instead, Dense behaves on a 3-rank tensor as it would behave if it was wrapped in a TimeDistributed layer, making me question the utility of TimeDistributed at all.
Describe the expected behavior
Dense should flatten its input like the documentation says. In the first example bellow, the shape of the kernel weights of dense should be (5 * 3, 2) = (15, 2) instead of (3, 2), which is the shape of dense2 (as expected in the case of dense2).
Code to reproduce the issue
First example:
import tensorflow as tf
import numpy as np

print('Using Tensorflow version {} (git version {})'.format(tf.version.VERSION, tf.version.GIT_VERSION))

tf.random.set_seed(12)
np.random.seed(12)

init = tf.keras.initializers.GlorotUniform(seed=12)

inp = tf.constant(np.random.normal(0, 1, (1, 5, 6)))
inp = tf.cast(inp, dtype=tf.float32)

gru = tf.keras.layers.GRU(3, return_sequences=True)(inp)
print(gru.shape)
#(1, 5, 3)

dense = tf.keras.layers.Dense(2, kernel_initializer=init, bias_initializer=init)
print(dense(gru))
#tf.Tensor(
#[[[ 1.5456871  -0.5280464 ]
#  [ 0.11647969 -0.20553198]
#  [ 0.58126366 -0.16031623]
#  [-0.22882831 -0.22649539]
#  [ 0.62777793 -0.32470667]]], shape=(1, 5, 2), dtype=float32)

for w in dense.weights:
    print(w.shape)
#(3, 2) instead of (5 * 3, 2) if Dense indeed flattened its input
#(2,)

tddense = tf.keras.layers.TimeDistributed(dense)
print(tddense(gru))
#tf.Tensor(
#[[[ 1.5456871  -0.5280464 ]
#  [ 0.11647969 -0.20553198]
#  [ 0.58126366 -0.16031623]
#  [-0.22882831 -0.22649539]
#  [ 0.62777793 -0.32470667]]], shape=(1, 5, 2), dtype=float32)
# if Dense kernel had shape (15, 2), this should result in the following error:
# InvalidArgumentError: Matrix size-incompatible: In[0]: [5,3], In[1]: [15,2] [Op:MatMul]
# but instead what we get is the same output
# than without TimeDistributed, without error

dense2 = tf.keras.layers.Dense(2, kernel_initializer=init, bias_initializer=init)
tddense = tf.keras.layers.TimeDistributed(dense2)
print(tddense(gru))
#tf.Tensor(
#[[[ 1.5456871  -0.5280464 ]
#  [ 0.11647969 -0.20553198]
#  [ 0.58126366 -0.16031623]
#  [-0.22882831 -0.22649539]
#  [ 0.62777793 -0.32470667]]], shape=(1, 5, 2), dtype=float32)

for w in dense2.weights:
    print(w.shape)
#(3, 2) as expected
#(2,)

Second example, with a rank even larger than 3:
import tensorflow as tf

print('Using Tensorflow version {} (git version {})'.format(tf.version.VERSION, tf.version.GIT_VERSION))

inp = tf.keras.Input(shape=(10, 25, 25, 3))
dense_layer1 = tf.keras.layers.Dense(78)
x = dense_layer1(inp)
print('Output shape without TimeDistributed:')
print(x.shape)

dense_layer2 = tf.keras.layers.Dense(78)
y=tf.keras.layers.TimeDistributed(dense_layer2)(inp)
print('Output shape with TimeDistributed:')
print(y.shape)

print('Weight shapes without TimeDistributed:')
for weight in dense_layer1.trainable_weights:
    if len(weight.shape) == 2:
        print('    kernel shape:')
    else:
        print('    bias shape:')
    print(weight.shape)

print('Weight shapes with TimeDistributed:')
for weight in dense_layer2.trainable_weights:
    if len(weight.shape) == 2:
        print('    kernel shape:')
    else:
        print('    bias shape:')
    print(weight.shape)

which outputs is:
Using Tensorflow version 2.0.0-beta1 (git version v2.0.0-beta0-16-g1d91213fe7)
Output shape without TimeDistributed:
(None, 10, 25, 25, 78)
Output shape with TimeDistributed:
(None, 10, 25, 25, 78)
Weight shapes without TimeDistributed:
    kernel shape:
(3, 78)
    bias shape:
(78,)
Weight shapes with TimeDistributed:
    kernel shape:
(3, 78)
    bias shape:
(78,)

We see, in this example, that Dense and TimeDistributed(Dense) behave the same in that they only touch to the last dimension of the input.

Issue replicating with TF version-2.0.0beta1, please find the gist of collab. Thanks!

@anush-o  It says access denied. Please change your settings to enable it.

The issue is still here in tf2.0.0.

The note is incorrect, we will update the note to reflect the code behavior.

Commit https://github.com/tensorflow/tensorflow/commit/2e6a3c58e4b96cac864f244e4886ef00b3184986#diff-5fb1fa5fa46d0ec9a01d5a60b7d8acc8

I appreciate how the new note is comprehensive @pavithrasv .
But now I don't get the purpose of TimeDistributed anymore, as I don't see the difference between Dense and TimeDistributed(Dense).

They are the same, TimeDistributed  doesn't just apply to Dense layers but i see that the main example in the TimeDistributed docs is using Dense layer. i'll update that.

The change to TimeDistributed docs have also been submitted. Thank you!


fix: no need to compress further when using bitshuffle encode

Proposed changes
As title

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

This PR is temporarily closed due to lack of reviewers.


[DO NOT REVIEW] CI testing only

PLEASE DO NOT REVIEW THIS PR.
IT IS ONLY FOR CI TESTING FOR ISSUE #4816

Closing because the test results looks same to what I expected.


Update barretenberg-sys to 0.1.3

This will allow us to remove the global test_threads=1 setting in .github which should also speed up other crates like acvm.

This needs nix changes too, but I'm updating this stuff now and multi-threaded causes composer tests to fail.

Hmm will need to check for further thread-unsafe code

Do we need to wrap each test individually? The docs seem like you can wrap the entire suite in one go.


AJV - Error: unknown format "date-time" ignored in schema at path "#/properties/timestamp"

So i want to make my own list. I've created a react project to start with. This is the function i made to validate a list.
 const generateMyTokenList = (tokenList: TokenList) => {         // Your list         const myList = tokenList;         // Creating a new Ajv object         const validator = new Ajv();         // Validating if the scheme is a valid scheme         const validateScheme = validator.validateSchema(schema);         // If the validateScheme returns true it is a valid scheme than validate my list         if(validateScheme) {             let validatedList = validator.validate(schema, myList);          }     }
whenever i pass my list to the function it validates the list and it works. But it gives me back 2 errors:
"Error: unknown format "date-time" ignored in schema at path "#/properties/timestamp" AND
"Error: unknown format "uri" ignored in schema at path "#/properties/logoURI".
Everything that takes the parameter: format gives me an error back. And whenever i take that json scheme and remove the 'formats' it will no longer return errors. So am i doing something wrong or is there something wrong?
This is the list i am using: https://github.com/Uniswap/token-lists/blob/master/test/schema/example.tokenlist.json

Check the version of your ajv, these are part of the json schema spec. Not an issue with token-lists.
https://json-schema.org/understanding-json-schema/reference/string.html#built-in-formats


Unable to persist fileId through instance recreation

Hello to everyone.
I'm trying to keep a persistent chat feed and stumbled across a unknown behavior. The goal is to retrieve chat content via getChatHistory, store its content in database, then retrieve and show it. Right now I'm retrieving chat history, then serialize message content and store it in db;
And sometimes later the Invalid file identifier comes into play. I'm guessing the local fileId becomes outdated for some reason while still containing file on disk.
But how do you retrieve fileId without fetching message and it's content again from telegram? I see no functions that can resolve remoteId to fileId. And downloadFile only accepts local id;
Is there a possibility? Or what would be the correct approach?

File identifiers aren't persistent and are valid only until TDLib instance is closed. Apps supposed to save nothing between TDLib restarts.
The correct approach is to fetch the message from TDLib using getMessage, get file identifier from the message content and download the file using the identifier. There is no way to download the file without having access to the message.

Hm.
Will getMessage use network request or assemble result from local copy?
Supposedly I've got chat history and stored message ids. And when user will be browsing the history I must getMessage one by one as they appear? Is this correct? Won't this be a heavy load on telegram?

Will getMessage use network request or assemble result from local copy?

If a request is possible to complete locally, it will be completed locally.

And when user will be browsing the history I must getMessage one by one as they appear?

In fact, ordinary apps almost never need to use getMessage. See https://core.telegram.org/tdlib/getting-started and https://core.telegram.org/tdlib/getting-started#getting-chat-messages in particular.


ISPN-9511 Expired event is not fired when modifying an expired entry

https://issues.jboss.org/browse/ISPN-9511

Upon thinking about this further, the fix for ISPN-9530 is not correct.
The following line https://github.com/infinispan/infinispan/blob/master/server/hotrod/src/main/java/org/infinispan/server/hotrod/ClientListenerRegistry.java#L206 should really use regular registerFilterListener. I need to look into fixing it when a converter is passed, why it didn't work before. My guess is that it applied the encoding is done twice. I will have to look further.

I will need to rebase this after #6263 is integrated. However it should hopefully pass CI now.

Tests passing, rebased to latest master and added some more docs

Integrated, thanks Will!
The build failure was caused by ISPN-9588.


.tgz downloaded to directory from which helm is run

Running helm install or upgrade --install downloads .tgz file to current directory when you use a helm repo for charts. This is somewhat annoying (and tedious to clean up) as we don't want to accidentally commit these files to our source control or have them dirtying up our filesystem out in the open.
Maybe they could be downloaded to a central location like ~/.helm/repository/cache/archives or something similar so they aren't spread out in whatever directory helm happened to be ran.

I'd be okay with storing these somewhere in $HELM_HOME. It's necessary to store them in a non-temp space because of the plugin toolchain. But storing them in CWD is truly annoying.
There's an existing PR that defines a new $HELM_HOME/cache directory. It will hold $HELM_HOME/cache/plugins. That would be a good place to put a $HELM_HOME/cache/archive or something like that.

big +1


Typo/spelling on 'configuration'.

Non-important change, but it was causing me to twitch whenever I saw it :grin:

:abc: :+1:


support key value data-sets

This would allow fzf to process data-sets of the form:
KEY1 SEPARATOR VALUE1
KEY2 SEPARATOR VALUE2
KEY3 SEPARATOR VALUE3
...

fzf would present the list of values to the user, and allow the user to do fuzzy finding on this list. The output of fzf would be the key(s) of the corresponding selected values.
This would be particularly useful to handle tags inside vim, but there might be other legitimate use cases.

What you have in mind (and more) is already possible with --with-nth, --delimiter, and a post-processor. See the man page for the details.
ls -al | fzf --with-nth 6.. | awk '{print $1}'

great! closing this issue!
I had seen the man page, but somehow the description led me to believe this wasn't what I wanted (somehow Transform each item using index expressions within finder didn't quite explain to me that this would only print certain fields.. make sense now though).


Group Settings Update

Summary
Update the Group Settings page to separate updates to path and parent namespace into the Advanced section.
Implementation Guide

Remove path and parent namespace updates from Name and description section.
Add Change group URL under Advanced section and only allow changing the path

Make POST request to group_path (normal update endpoint)

Add Transfer group under Advanced section and allow user to select any group, subgroup, or personal namespace they have access to

Add groups/transfer_service.rb (can use projects/transfer_service.rb as an example).
Add transfer method to groups_controller.rb and call the groups/transfer_service.rb
Add transfer endpoint to routes/groups.rb using PUT method

@ericenns @josh I have a small question. It looks like at one point the accordion was used to organise the group advanced settings. I also see that the card is being used in the WIP: Project settings update #92 PR. Do I continue to use the accordion or use the card for consistency? Thanks.

Done.


Add exception callbacks as releated pages

Hi,
It may need some discussion about what pages may contain such link but; I think pages that talk about how to handle exception in C# (like the releated content page in this issue) should also link to pages like AppDomain.FirstChanceException or AppDomain.UnhandledException.
Maybe in the see also part.
Giving that trying to search for catch handler (or similar keywords) usually end up on the try-catch and nowhere close to those two callbacks, it may add a nice visibility to those two callbacks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f8cde2a6-1c92-8b1e-a795-4b1e04510575
Version Independent ID: 3b8f6b0d-08a9-0730-3241-da241f8444b4
Content: try-catch - C# Reference
Content Source: docs/csharp/language-reference/keywords/try-catch.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks @Suisse00
That's a great suggestion. We'll add that.
I've added the "up for grabs" label as well, if anyone wants to submit a PR before we make that update.


feat: move schemas to accounts plugin

The AddressType and AddressConnection schemas were created in the address-validation plugin, but only used in the accounts plugin.
This PR moves these schemas to that plugin, where they are used.
https://github.com/reactioncommerce/api-plugin-accounts/pull/3

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


buffer of stream grows beyond limit

After upgrading to newer release of yamux with https://github.com/libp2p/rust-yamux/pull/176 I get frequent reports from users that they see errors like this in logs:
ERROR yamux::connection: 5dadd7e9/87: buffer of stream grows beyond limit

Yamux in libp2p is configured with 256 max streams and receiving window of 1310816 bytes.
Everything else is set to defaults.
Is this a known issue or maybe configuration is wrong on my end?

Thanks for reporting @nazar-pc.
Can you reference the concrete rust-yamux version and link to your code using rust-yamux?

We're using yamux 0.13.2 through libp2p-yamux 0.45.1, both of them are releases on crates.io, here is the configuration of it: https://github.com/subspace/subspace/blob/d159452bf4cd480837770d83c4f0cab3a28da048/crates/subspace-networking/src/constructor.rs#L306-L310

Do you see the same error without:
        yamux_config.set_receive_window_size(YAMUX_RECEIVING_WINDOW as u32);

Will give it a try, but since I don't see it myself will have to ask users to test a custom build without it. The default seems unnecessarily large though.

According to a single user's feedback issue disappeared once I removed it

Note that without setting the configuration option, you are using the newer yamux version, i.e. v0.13:
https://github.com/libp2p/rust-libp2p/blob/a8888a7978f08ec9b8762207bf166193bf312b94/muxers/yamux/src/lib.rs#L339-L351
With v0.13 the buffer limit is managed at the connection level, no longer at the stream level.
In other words, the fact that users no longer see the log line when removing the configuration set_receive_window_size, hints at the bug being in v0.12 and not in v0.13.

Hm... but we are not setting options to fall back to 0.12 :thinking: Can 0.12 on the other end of the connection cause this?


Replace small 0.1u caps

They're too small and hand-solder correctly only about 60% of the time.

Make sure they're at lease 10v rated.


Initial action commit

Co-authored-by: esulej<EMAIL_ADDRESS>

@Bucknalla is this PR still relevant?

@ab77 nope, closing


tests: instantiate everything

instead of just listing, instantiate each plugin in turn

first pass in 94b31407c60712fef1ccba2f87b7927885915029
todo: don't accept failed plugin loads (requires some test scaffolding)

completed in fdaaaa2ccea368c443705496556a98512d481b40


ci(renovate): add renovate configuration

using simplabs' preset

Thanks for merging this.
@mansona @marcoow let me know if the PRs opened are the kind of PRs you expect or we need to tweak simplabs' renovate config


Support "--js closure-library/closure/goog/deps.js"

https://code.google.com/p/closure-library/wiki/FrequentlyAskedQuestions#When_I_compile_with_type-checking_on,_I_get_warnings_about_
When I compile with type-checking on, I get warnings about "Bad type annotation. Unknown type" from closure library files.
The raw compiler option would look something like:
--js closure-library/closure/goog/deps.js.

NOTE: If you're using closurebuilder.py (or calcdeps.py), it is not sufficient to simply specifiy "--root closure-library". You have to specifically add the deps file by passing a compiler option:
-f "--js closure-library/closure/goog/deps.js."

closing due to inactivity, feel free to re-open if the issue persists.


Windows Docker image available?

Following the instructions from the README causes a Linux docker image to be obtained. Any chance of a Docker image for Windows?

We're looking at all feature requests from the community right now! If we can get significant interest in this we're happy to prioritize it.

Just to update -- recently we have provided IDE support for InferSharp in VS and VSCode extensions.


add pacmans to saltern

About the PR

a few jr and normal pacmans in maints
super pacman replacing the 2 3kw gens in engi

A super is overkill for replacing 2 3kW generators. A super can power up to 50kW.

wait before this gets merged can you add more glasses in sci because this map only has one pair (in the morgue) and it makes me sad

pacmans require fuel whereas the 3kw generators just made 6kw forever which was useless, at least with 50kw you might be able to power a good chunk of the station in an emergency where ame and singulo and teg are unavailable


Create sman1brebes

SMAN 1 Brebes

Add Domain SMAN1brebes.sch.id

@ONNYHENDRATANA lib/domains/id/sch/sman1brebes: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@ONNYHENDRATANA Please provide us with:

the school official full name
the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@ONNYHENDRATANA I have to close this request without merging, because you requested to add a non-existent domain to this repository: `` Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Add USWDS colors and grid structure

So I still have to get the callout boxes ("Paranoia Alert", etc.) to be different colors, and I need to put in the JS that highlights your current place on the page in the TOC. But this is looking good, I think.

PR #23 removes more extra hair spaces


Back and forward bug

load a page
click browser back button
click browser forward button

then i see double every javascript enhanced elements (example twice the drowp down field, twice the RTE...). Can anyone else reproduce this problem?
i'm using
$(document).on("pjax:end ready", function(){
 ...
}

with pjax:complete or pjax:success I don't get duplicate dropdowns, but i can't select them after going back and forth.
thanks for the help!

The same issue I have with flickity carousel. On first load slider is initialized  on document:ready. But if I go to another page and then go back using 'browsers back' button slider doesn't work or initialized twice

One workaround that worked for me is to let the page refresh on back/forward buttons. Here is the (I guess) ugly solution I came up with:
$(document).ready(function(){
    initializePage(); // Contains the initialization scripts for the plugins.
});

var pjax_called = false; // Executes on page load.
$(document).on("pjax:complete", function() {
    initializePage();
    pjax_called = true; // Prevent the reload
});

$(document).on("pjax:end", function() {
    if(!pjax_called)
        window.location.reload();
    pjax_called = false; //reset
});

The idea is that the complete event is called when there is a pjax request whereas the end event is called on both pjax requests and back/forward button clicks.
Any suggestions? Please let me know.

I use pjax:beforeSend event to destroy slider & reinitialize after pjax:end

I'm setback by this back-forward issue too.
When using 'complete' my js stops working.
When using 'end' my js gets doubled.
(datatables.js in my case)
There's gotta be something less hackier / taylored to each plugin.

First I tried:
$(document).on('pjax:popstate', function (event) {
    event.preventDefault();
    location = event.currentTarget.URL;
});

But for some reason event.preventDefault() doesn't work. So the result is a regular cached back/forward behaviour that messes up js plugins (in different ways, depending on the use of complete/end as I described above), and briefly thereafter the reload occurs. Blechs.
Then I found out we can just use:
$.pjax.defaults.maxCacheLength = 0;
And now back/forward behave just like clicking a link. Unless I am missing something, this solves the back/forward issues.
P.S.
Mind the fact that you have to declare it as a default: #593

Did someone found a solution for this? I am searching for 3 hours and found nothing good related. I have the same problem with back button, js plugins like dropdowns , menu`s etc are stuck.

I was having doubled content when clicking back button (had two pjax containers), and @legshooter's suggestion worked for my case - $.pjax.defaults.maxCacheLength = 0;

l hiiiiiiiiiii

l hiiiiiiiiiii


processing tools - plugin system

@bendichter @luiztauffer
I started to put together a plugin system for processing tools. Right now, the plugins are included directly in the neurobass repo, but later we can separate them out into their own repos, and provide an easy recipe for users to contribute their own processing tools. Each compute resource can have its own set of processing tools.
I am using pydantic (thanks Luiz for pointing me to that) to define the schema for each tool. Those schemas get automatically uploaded to the neurobass database when a compute resource starts up, and then they are viewable in the tools tab:
https://neurobass.vercel.app/project/erjytuke?tab=processing-tools
Here are the definitions of the mountainsort5 and kilosort3 processing tools
https://github.com/scratchrealm/neurobass/blob/main/python/neurobass/processing_tools/spike_sorting/Mountainsort5ProcessingTool.py
https://github.com/scratchrealm/neurobass/blob/main/python/neurobass/processing_tools/spike_sorting/Kilosort3ProcessingTool.py
And here is the plugin that includes them
https://github.com/scratchrealm/neurobass/blob/main/python/neurobass/processing_tools/spike_sorting/SpikeSortingPlugin.py
To create a custom processing tool, the user would:

(a) create a new python package
(b) create the processing tools and the plugin class as in the above example and make sure the plugin is exported in the main __init__.py of the package
(c) configure the compute resource to register plugins from the new package
(d) restart the compute resource

A nice feature is that everything is defined in one place, in Python.
I haven't finished gluing this all together, so the web app is still using the old system for the actual processing.

This looks like a good framework! I'd like to have logic that can constrain the input parameters. For example, for spike sorting the electrical_series_path should be a drop-down of all the ElectricalSeries in the file. Would it be possible to refactor this so that the parameters form could be informed by the file?

This looks like a good framework! I'd like to have logic that can constrain the input parameters. For example, for spike sorting the electrical_series_path should be a drop-down of all the ElectricalSeries in the file. Would it be possible to refactor this so that the parameters form could be informed by the file?

Pydantic has a way to contrain fields. For example, constraining an integer to be between 1 and 10:
class MyModel(BaseModel):
    value: int = Field(..., ge=1, le=10)

So I plan to support that in the GUI. Of course this doesn't handle the case where we want a dropdown with names of valid paths within the NWB file. For that I was thinking of hard-coding something on the front-end (for all spike sorters) until we can figure out a better way to specify this.

Could we have a function for determining if an NWB file is appropriate for a given analysis?

Could we have a function for determining if an NWB file is appropriate for a given analysis?

I think we should hold off on that until we see more clearly the need emerging. For now, tools can be tagged as "spike_sorter" which signals to the front-end that it can be used in situations where the nwb file has an ElectricalSeries object in /acquisition.

BTW note: all jobs have been deleted from the database, and processing won't work again until I emerge from this refactoring.

OK. This is going to come up for nearly every processing tool. Image segmentation only makes sense on data that have a OnePhotonSeries or a TwoPhotonSeries. Pose estimation only make sense on inputs that have behavioral video in an ImageSeries object. I'm fine with putting this off though and building the app specifically for spike sorting for now so we can build a solid user experience for a particular use-case.

Also, there are other tools that have built this sort of analysis plugin system, e.g. FlyWheel Gears. Here is an example gear: https://github.com/flywheel-io/exchange/blob/master/gears/flywheel/example-gear.json This seems like a decent system for registering different analyses with a platform, and I think it makes sense to follow the neuroimaging community where it is convenient to do so

That is looking really cool, @magland !
I have a few ideas, would like to hear your opinion on these:
Tools as pip packages vs containers:

Each compute resource can have its own set of processing tools.

Does that mean that the processing tools will need to be installed in the compute resource? That approach would be difficult to maintain and very quickly create incompatibilities between tools, I believe.
What if we had the tools being built, distributed and used as containers? That would solve a couple of problems:

the developer of the tool is able to define the whole running environment, including system level dependencies. This was one of the main selling points of NeuroCAAS
guarantees environment isolation, no risk of dependencies change
easy to just pull and run, no risk of dependencies conflicts as there’s no need to install
we could skip steps c) and d)

Our template repository for tools could have a workflow actions that auto builds and publishes the images in GHCR, for free. The NeuroBAAS job definitions would then include the tool ghcr url as the source to be pulled from. To add a new tool to be used, all the user would have to do is to paste a github url in a "Add tool" field within the Tools page, or something like that...
Define NWB data types required by a tool
As @bendichter  pointed out, this would be a very important feature. With the data-centric approach, it would be easy to, once the user selects its source data, parse its metadata and check which data types are present and, as consequence, which of the available tools could be applied to it. This would also highlight one of the main strengths of the NWB format, which is the standard data types, and indirectly encourage best practices when saving experimental data.
From the tools development perspective, we already need to write arguments such as electrical_series_path, so it wouldn’t be much more hassle to explicitly define the required (and eventually optional as well) NWB data types for running that tool, in a metadata file for example. I believe this would also encourage the tool developers to think in a data-centric manner, at least when writing the wrappers of their original tools to be used by this system.
I believe that eventually we might also want the tools to define the model of that data it produces, but it's not so clear in my head how that would go.
Tools vs plugins
What would be the advantage of grouping tools in plugins, e.g. SpikeSortingPlugin? Is there something specific about the way they are read by the system, or shared functionality that we’re leveraging, that requires them to be grouped?
For example, if someone publishes a new sorting algorithm and wants to wrap it up and publish as a new neurocaas tool, would it need to be included in the SpikeSortingPlugin and, therefore, in the central tools repository?
I think I’m imagining a system were tools can be developed and used independent from others, although they could definitely be grouped in the frontend by tags, keywords, etc…

@luiztauffer I like your idea for distributing tools as containers instead of Python packages. IMO, the package approach is much more convenient during development and testing, for creating quick wrappers to new or existing tools, which is why the current implementation is the way it is. However, I can see there is a big advantage of distributing the plugins as containers, for the reasons you listed. But I feel like there needs to be a way to create and test tools without needing to push to github or prepare a container at each iteration. What I was imagining was to enable the package plugin mechanism, but then provide a recipe for converting that into a container image and publishing in order to become a more official and distributeable tool.
Regarding tools vs plugins, I was roughly following the pattern of other plugin/extension systems, such as VS code. I like to avoid having something like a json spec that needs to be kept in-sync with the implementation code and that requires following a particular format which might break over time. The alternative I am using here is to register the tools as part of a Python class. But I'm open to revising this system. It's difficult to settle on a particular design, because there are so many different ways this could be done.
I agree, it will be important to specify which NWB types are appropriate for a given tool. I guess we'll need to develop a spec for how this would be included in the meta data for the tools. I think we should be cautious about allowing an arbitrary Python function to determine this because that's not easy to access on the front-end. Rather it should be specified in some metadata -- but of course that presents a challenge of how to define that.


Block swiping in Deck Swiper

Issue Description
I want to block swiping in some cases, so I wonder when using onSwipeLeft or onSwipeRight, is there a way to untrigger swipe listners.
It would be better if there's these props disableLeftSwipe disableRightSwipe
Thank you

I find this library very interesting, I'll make you a PR soon in order to fix this.

+1

Hi @HamadaBrest , it would be grateful, if create PR for this soon.
Thanks


Ingestion max concurrency fix

/azp run python - monitor - tests

API change check
API changes are not detected in this pull request.


NumberFormatException when casting out of range float to decimal type

Description:
$title
Steps to reproduce:
public function main() {
    io:println(<decimal> 9.99E+6111f);
}

[2021-09-28 10:19:18,306] SEVERE {b7a.log.crash} - Infinite or NaN
java.lang.NumberFormatException: Infinite or NaN
at java.base/java.math.BigDecimal.(BigDecimal.java:923)
at io.ballerina.runtime.internal.values.DecimalValue.valueOf(DecimalValue.java:577)
at floating-point-literal.main(floating-point-literal.bal:35)
at $_init.$lambda$main$(.)
at io.ballerina.runtime.internal.scheduling.SchedulerItem.execute(Scheduler.java:597)
at io.ballerina.runtime.internal.scheduling.Scheduler.run(Scheduler.java:327)
at io.ballerina.runtime.internal.scheduling.Scheduler.runSafely(Scheduler.java:295)
at java.base/java.lang.Thread.run(Thread.java:834)

@chiranSachintha, can you check this with the literal changes also? The behaviour for this should be the same as
decimal d = 9.99E+6111f;

@chiranSachintha, can you check this with the literal changes also? The behaviour for this should be the same as
decimal d = 9.99E+6111f;

Edit: we need to verify this.

Depending on the conclusion for this, may be the same as https://github.com/ballerina-platform/ballerina-lang/issues/34997 if this needs to be handled at runtime.

Works as expected in 2201.1.0. Added tests via https://github.com/ballerina-platform/ballerina-lang/issues/32938. Hence closing the issue


Publishing doesn't pack angular files

I followed this tutorial, and can run the project in visual studio, but if I try to publish the project, following the instructions, angular files are not packed in the deploy. I have tried publishing to a folder, also publishing to a remote IIS server (built a publish file).

@Mihajlovski -- Vladimir, thank you for your feedback!  Which learn.microsoft.com tutorial are you following?

This one:
https://learn.microsoft.com/en-us/visualstudio/javascript/tutorial-asp-net-core-with-angular?view=vs-2022
On Tue, Feb 28, 2023 at 1:30 AM William Anton Rohm @.***>
wrote:

@Mihajlovski https://github.com/Mihajlovski -- Vladimir, thank you for
your feedback! Which learn.microsoft.com tutorial are you following?
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/visualstudio-docs/issues/8999#issuecomment-1447338351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABFMYU4QZXFOJQYOORGAOTWZVBI7ANCNFSM6AAAAAAVINLDAM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Mihajlovski -- Vladimir, thank you for your followup.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

@Mikejo5000 -- Mike, please look into this issue.

Yes, I've googled and checked wherever I could. I also tried changing
angular.json to set the build output to wwwroot folder, but still nothing.
I've tried like 10 things.
I've seen one stack overflow question with the similar problem. But, this
tutorial seems relatively new, so I guess there's something unwritten here,
that I can't implicitly figure out.
On Tue, Feb 28, 2023 at 10:46 PM William Anton Rohm <
@.***> wrote:

@Mihajlovski https://github.com/Mihajlovski -- Vladimir, thank you for
your followup. Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A
https://learn.microsoft.com/en-us/answers/tags/176/vs page for
Visual Studio.
Check the Visual Studio MSDN Forum
https://social.msdn.microsoft.com/Forums/vstudio.
Stack Overflow
https://stackoverflow.com/search?q="visual+studio"
Reddit https://www.reddit.com/r/VisualStudio

@Mikejo5000 https://github.com/Mikejo5000 -- Mike, please look into
this issue.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/visualstudio-docs/issues/8999#issuecomment-1448965859,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABFMYWRLZBOIEPP2XKXO2LWZZW4LANCNFSM6AAAAAAVINLDAM
.
You are receiving this because you were mentioned.Message ID:
@.***>


markdownlint extends sub-file of dependency

With this config:
{
  "extends": "markdownlint/style/prettier",
}

markdownlint/style/prettier is detected as the dependency instead of just markdownlint resulting in:
Unlisted dependencies (1)
markdownlint/style/prettier  .markdownlint.json

Wait no, not a bug. The error message just confused me.
I didn't have markdownlint as dependency, only markdownlint-cli.

It reports the whole specifier so it's easier to find


Poor name choice

It only supports ACP, not all AMD microphones. Change it.

@VisualEhrmanntraut I have just published an experimental fix for non-ACP microphones today.
https://github.com/qhuyduong/AppleALC
If it is verified to work and accepted by Acidanthera, so this repo is gonna serve the ACP world, it may be renamed then.
Otherwise, I will bring that fix here.

We saw. Your fix doesn't apply to all macOS versions btw. We adjusted it and it seems to work for a lot of people. A technical overview of it would be nice.

Yeah I know. It's just experimental. There're still some issues. It doesn't work for someone. And 3.5mm microphone may not work yet.
For more details, in the function in the function AppleHDAController::getAudioStreamLinkPositionInDMABuffer(IOHDAStream*, uint64_t*), it expects bit 0 of register 0x70 to be cleared before reading DMA position.
.
However, for an unknown reason, it is not cleared by AMD, hence DMA position is incorrect, hence no input at all.
This is just the assumption. I don't have HDAC spec of AMD.
The workaround at the moment is not setting that bit at all. No warranty for side effects.
This is the register 0x70.

Another "safer" solution is skipping that bit check in getAudioStreamLinkPositionInDMABuffer

Interesting, thanks for the insight. We're investigating to develop a proper fix instead of your hack. Good catch, btw.

Oh, and uh, here's the universified-ish version of your hack:
Find: 83 7E 0C 00 75
Replace: 66 90 66 90 EB
Please don't steal it.

Thank you. If you want let just merge it to my fork.
However I'm thinking that place is not the root cause. Still not working for someone.

Hence why I'm calling this a hack. There's likely some workaround macOS doesn't have


Add Database

Adds database
Parses json

Got a module not fount error when trying to run. requirements.txt
Module needs updating with module==version

All comments and concerns addressed. Can now be merged into develop.


Cannot save .zap project on Windows

In version 2022.10.18, when you try to save the *.zap project, the following error is generated:

{"level":50,"time":1666270034874,"pid":15484,"hostname":"XXX","name":"zap","msg":"Unable to save project.","err":{"type":"Error","message":"ENOENT: no such file or directory, open 'C:\\Users\\USER\\Desktop\\zap\\UsersUSERDesktopzap-test\test.zap'","stack":"Error: ENOENT: no such file or directory, open 'C:\\Users\\USER\\Desktop\\zap\\UsersUSERDesktopzap-test\test.zap'","errno":-4058,"code":"ENOENT","syscall":"open","path":"C:\\Users\\USER\\Desktop\\zap\\UsersUSERDesktopzap-test\test.zap","alert":"⛔"},"msg":"ENOENT: no such file or directory, open 'C:\\Users\\USER\\Desktop\\zap\\UsersUSERDesktopzap-test\test.zap'"}

In my test, the zap application is placed in C:\Users\USER\Desktop\zap and the project directory is 'C:\Users\USER\Desktop\zap-test.
This issue occurs only on Windows.

Any progress on this show-stopping bug from six months ago?

yes, we are fixing it now - will make a PR

@zacwbond @mauro-girotto https://github.com/project-chip/zap/pull/1064


Error executing "VD Examples.ahk"

When I try to execute "VD examples.ahk":

Any fix or suggestions?
Thank you

Hi, I have fixed it!
At line 63 just change into:
#Include %A_ScriptDir%\VD.ahk


ENH: integrate: add 'initial' kw to cumtrapz, which makes len(out) == le...

...n(in).
Default is initial=None, to be backwards compatible
(meaning len(out) == len(in - 1) along axis of integration.
Also add tests and a decent docstring.
Trac ticket is http://projects.scipy.org/scipy/ticket/1574

All fixed.

What needs to be done for this to be merged?   This looks pretty good.

Hmmm... I was thinking initial would be the initial condition for the accumulation, not just the value to put at the beginning.  E.g.  cumtrapz(y, x, initial=99) is the same as 99 + cumtrapz(y, x, initial=0).  But I don't have a particularly compelling use-case for this, and it makes the use of initial slightly harder to explain.  Anyone else see any advantage in that alternative?

I can see your point, Warren.  However, I'm more persuaded by "initial" as just a mechanism to keep the output and the input the same length.  This has more to do with the "initial" region (i.e. the area under the curve between the non-existent previous value of x and x[0]).   Thus, it really should be limited to the number to place in the first element of the output rather than essentially corresponding to a bias in the entire curve.

Sure, that's fine with me.
Ralf, I just noticed a typo in a docstring (noted in a line comment); other than that, this looks ready to go.

Okay, I'll fix the typo and merge this in ~2 weeks. If anyone wants to do it before then, please go ahead.

Pushed in commit 6eb2da0.


[LightGBM] [Warning] Unknown parameter: data_sample_strategy

Description
above error message appears when I pass the parameter in the params dictionary
Reproducible example
lgb.train(params={'data_sample_stragety':'goss'},train_set=lgb.Dataset(data=np.random.rand(100,100), label=np.random.rand(100,1)))
Environment info
LightGBM version or commit hash:
python package, train api, version 3.3.5

data_sample_strategy was added to LightGBM in #4827, which hasn't made it into a release yet.
To take advantage of it, you'll have to build from source. You can also subscribe to notifications on #5153 to be notified when the v4.0 release goes out.

thank you very much. I just wonder then why it is listed in the official documentation

You won't find it in the docs for the latest release (v3.3.5).
https://lightgbm.readthedocs.io/en/v3.3.5/Parameters.html
That link you've shared, https://lightgbm.readthedocs.io/en/latest/Parameters.html, is built from this repo's master branch.
Sorry for the confusion.

My bad. I mistook the "latest" in the URL for the latest release. No idea why I am surfing that version!


Gdx.net.sendHttpRequest not work after  Package for App Store/Ad-Hoc distribution...

Gdx.net.sendHttpRequest working (eclipse choose): run as ios Simulator, run as ios device.
but when i Package for App Store/Ad-Hoc distribution, run on device and Gdx.net.sendHttpRequest  does not working.
libgdx version 1.5.3
RoboVM 1.0.0 beta 3
this is my code:
public void F_GetMoreApp() {
try {
HttpResponseListener httpResponseListener = new HttpResponseListener() {
			@Override
			public void handleHttpResponse(HttpResponse httpResponse) {
				// TODO Auto-generated method stub

				if (httpResponse.getStatus().getStatusCode() == HttpStatus.SC_OK) {
					try {

						String str = httpResponse.getResultAsString();
						Element root = new XmlReader().parse(str);
						try {
							Array<Element> array = root.getChildByName(
									"MOREAPP").getChildrenByName("APP");
							if (array != null && array.size > 0) {

								F_ShowMoreApp(array);

							}

							else
								F_LoadFail();
						} catch (Exception e) {
							F_LoadFail();
						}
					} catch (Exception e) {
						F_LoadFail();
					}
				} else {
					F_LoadFail();
				}
			}

			@Override
			public void failed(Throwable t) {
				// TODO Auto-generated method stub

				F_LoadFail();
			}

			@Override
			public void cancelled() {
				// TODO Auto-generated method stub

				F_LoadFail();
			}
		};

		String linkmoreapp = "http://www.huesoft.com.vn/huesoftmobile/hsmoreapp";
		if (mGame.mOSType == MyOSType.ANDROID)
			linkmoreapp = "http://www.huesoft.com.vn/huesoftmobile/moreapp/android";
		if (mGame.mOSType == MyOSType.IOS)
			linkmoreapp = "http://www.huesoft.com.vn/huesoftmobile/moreapp/ios";

		HttpRequest mHttpRequest = new HttpRequest(HttpMethods.GET);
		mHttpRequest.setHeader("Content-Type",
				"application/xml;charset='UTF-8'");
		mHttpRequest.setUrl(linkmoreapp);

		Gdx.net.sendHttpRequest(mHttpRequest, httpResponseListener);
	} catch (Exception e) {
		F_LoadFail();
	}
}

Former: I use libgdx 1.4.1 and robovm 1.0.0-alpha-04. it does working all

Duplicate #2761

thank you!
On 24 January 2015 at 10:33, Tomski<EMAIL_ADDRESS>wrote:

Closed #2773 https://github.com/libgdx/libgdx/issues/2773.
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2773#event-224098038.


restrict rule snippets to single turn user inputs

Proposed changes:

restrict rule snippets to single turn user inputs
check rules with other rules and stories
fix loop unhappy path prediction
fixes https://github.com/RasaHQ/rasa/issues/6557

Status (please check what you already did):

[x] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

@erohmensing I didn't find the description of RulePolicy config in the docs where I should include the parameter

Will have a look at this asap. I'm a bit swamped at the moment, sorry

@wochinge types failed after merging master

re type checks: https://rasa-hq.slack.com/archives/C0125DKLBEW/p1599727956128700

@wochinge since they are related, I added checking rules to this PR (also to avoid multiple merge conflicts resolving created by. decoupling)

@Ghostvv any info about configuring a specific policy should go under that policy on the policies page

@erohmensing updated

@erohmensing @b-quachtran Could you please give the docs and parameters name a quick review? 🙌

@Ghostvv I think we shouldn't model this as exception. The stack trace makes it look very ugly. I think we should rather use print_error_and_exit.

Another thing: When rules contradict the RulePolicy will always predict action_default_fallback which makes the error message confusing. Also, it will print two errors although the rules are contradicting with each other. Means it would be enough to print just one error (e.g. Rule x contradicts with rule y instead of Rule x contradicts with rule y. Rule Y contradicts with Rule x)

Also, it will print two errors although the rules are contradicting with each other. Means it would be enough to print just one error

we cannot do it. We don't know which rule contradicts what

When rules contradict the RulePolicy will always predict action_default_fallback which makes the error message confusing.

that's what RulePolicy predicts by default. It could be action_listen or custom fallback depending on the settings. Do you have a suggestion for better phrasing?

that's what RulePolicy predicts by default.

mhm, but there are rules and even they are contradicting none of them is predicting action_default_fallback. If the contradicting rules result in the RulePolicy predicting action_default_fallback then it doesn't much sense to add that information to the error message.

but we test not what rules (as if rule snippets predict) we test what the whole rule policy predicts including all the complicated loop prediction system and fallback and default predictions. That's why I call predict_action_probabilities but if you think it'd be better to say:
utter_chitchat was not predicted by RulePolicy
I can change to that

That's why I call predict_action_probabilities but if you think it'd be better to say:

I think that's indeed better because users will intuitively look for action_default_fallback in their rules / stories and then not find it which is likely to be confusing.

the exception is actually fine. We can't do a exit() because that would break server mode .


Dead Rising Deluxe Remaster: Parse app.solid.npc.NpcPhysical.PhysicalStatus

RE_RSZ is able to parse files from Dead Rising Deluxe Remaster, but it seems to have trouble parsing a value for app.solid.npc.NpcPhysical.PhysicalStatus. Could you look into this?  I think that might be what I'm trying to edit.

That asterisk means it's a pointer to somewhere else, and that may not be the field I'm looking for anyway.


[StdLib] Re-add runAllTests call to Runtime tests

I accidentally omitted the call to runAllTests() in 6e0d832 when moving the Objective-C portions to their own file. I will take care to explicitly verify that UnitTests run in the future.
Thank you @gribozavr for spotting this.

@ezephir Thank you!


Update "Services using this pattern"

This PR updates the "Services using this pattern" markup from an <h4> to <strong> and <br>'s
This fixes https://github.com/alphagov/govuk-design-system/issues/604

You can preview this change here:
Built with commit 186b7251a15d9e831a777a892028ff5511b4ea77
https://deploy-preview-650--govuk-design-system-preview.netlify.com

@nickcolley Agreed. We'll check it out when Amy is back. I think we may need to use HTML with some overrides as the markdown rendered will spit these out as bullets. Will merge this for now for consistency with other pages that use this markup.


PAL-390 resource-service persistence

Resource-service persistence was made easier by working entirely with streams. This sees an update to the HadoopResourceService to support this new interface (see common)

On hold - DO NOT MERGE - until other repos are ready


ImageLoader uses bg thread for processing

Modifies ImageLoader's load function to use background threads for the image decoding work. This avoids blocking the main thread that is especially noticeable when loading many images at once.
This was modelled after the other loader implementations that also use threads.

fixed the cranky errors. Will look at making this optional and disabled for Wasm.


⚠ Bofrost.lu has degraded performance

In 39bb411, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1754 ms

Resolved: Bofrost.lu performance has improved in a836f44 after 1 hour, 35 minutes.


(FACT-1364) Add test for int value larger than 32-bits

To ensure that facts with bignum integer values continue to work on
windows, add a test.

Seems like it should work.

I made sure this failed on Windows with my fix commented out, so hopefully it should work!

CLA signed by all contributors.


Standalone components

Feature Description
As Angular v17 is released with stable standalone component APIs, is there any plan for migrating material components to standalone components. If yes, Are we planning for automatic migration of modules to standalone components?
Use Case
No response

Check the code, the Material components are already migrated to standalone. What exactly are you missing?

All components are standalone in the 17.1 release.

All components are standalone in the 17.1 release.

Thanks for the reply.
I just checked the latest codebase and I saw no new generators added to automatically migrate existing modules to standalone components. Can we expect automatic migration scripts in future release?

Unfortunately I don't expect we'll have the resources available to set up any automatic migration scripts

There's a schematic in @angular/core that migrates to standalone automatically: https://angular.io/guide/standalone-migration

All components are standalone in the 17.1 release.

I think it would be great to mention this on material.angular.io


Configuration to get Amazon MQ metrics using YACE

Hi, I am trying to get amazon mq metrics using the YACE exporter. Does it support amazon mq metrics? If yes, can someone please help me with the configuration to get them?

Sorry we are not supporting this currently but it is supported by the resourcegroupstagging api
https://docs.aws.amazon.com/resourcegroupstagging/latest/APIReference/Welcome.html
So it can be implemented. You are interested to PR?

Hello Thomas, thank you for your answer. Yes, am interested to PR. Can you give some examples?
Thank you in advance.

Any news here, guys?
@Alexander-ac @thomaspeitz

I submitted the PR #358 for adding theses metrics :) . hope it helps