Patterns for mobx-react@rc

Decided to try out the v6 rc today as I'm starting a new project (100% hooks codebase 🤤 ).
Just wanted to check in and make sure I'm correctly replacing Injector/Provider functionality - and hopefully serve as a little example for people looking to migrate 😃
Demo Store:
class Store {
  @observable
  someValue: boolean = false

  @action
  toggle = () => {
    this.someValue= !this.someValue
  }
}

const store = new Store()

export const initializeStore = {
  store,
}

Store Context
import {initializeStore} from '../stores/test'

export const StoreContext = React.createContext(initializeStore)

Demo functional component
const Toggle = observer(() => {
  const {store} = React.useContext(StoreContext) // Replacing Inject
  return (
    <>
      <button onClick={store.toggle}>toggle!</button>
      <Consumer />
    </>
  )
})

The only thing I'm not sure about is manually recreating the Provider (never had the opportunity to use Context until now.) The docs show usage without a Consumer but I assume it is implied that you use a Consumer to Connect the root/routes of your app.. Making injection unnecessary?
import {initializeStore} from '../stores/test'

export const StoreContext = React.createContext(initializeStore)

const App = () => {
  <StoreContext.Provider> // Replacing the Provider component?
    <StoreContext.Consumer> // Needed for the child components to consume the provider?
      {routes} // Will have access to Store as a prop?
    </StoreContext.Consumer>
  </StoreContext.Provider>
}

Consumer is only needed if you can't use useContext:
import {initializeStore} from '../stores/test'

export const StoreContext = React.createContext()

const App = () => {
  const [store] = useState(initializeStore);

  // Like mobx Provider but accepts only single prop "value"
  <StoreContext.Provider value={store}>
    // value (store) isn't passed as prop, it must be consumed with <Consumer> or useContext
    <Toggle>
  </StoreContext.Provider>
}

// with hooks
const Toggle = observer(() => {
  // context value (the store) is returned from hook
  const store = React.useContext(StoreContext)

  return <button onClick={store.toggle}>toggle!</button>
})

// without hooks
// note, we have to use `Observer` instead of `observer`
const Toggle = () => {
  return (
    <StoreContext.Consumer>
      // context value (the store) is exposed as argument to the callback
      {store => (
        // we have to use `Observer` instead of `observer`
        <Observer>
          {() => <button onClick={store.toggle}>toggle!</button>}
        </Observer>
      )}
    </StoreContext.Consumer>
  )
}

// the avoid this callback madness you can abstract the consumer as HOC:
// you could do the same with hook, but there is no need to
const withStore = Component => {
  return props => (
    <StoreContext.Consumer>
      // pass the store as prop "store"
      // Component
      {store => <Component ...props, store={store}/>}
    </StoreContext.Consumer>
  )
}
const Toggle = withStore(observer(({ store } => <button onClick={store.toggle}>toggle!</button>))

@urugator Thanks for the detailed reply! Appreciate the time you took for this 🍻
@mweststrate Feel free to close this if you see fit – My question was answered but leaving it open may help with discoverability?


after update minus 30 entities and no map

Hello
sorry for my english ;-(
My Device is an "Dreame L10s_Ultra" ModelID: dreame.vacuum.r2228o
Codename: p2228
today i have updated and now i have no map anymore on all card´s after a little check and reinstallation... now i have minus ca. 30 entities (only 82). 17 entities not available, 24 de-activated
"camera.dreamebot_l10s_ultra_map" not available
"camera.dreamebot_l10s_ultra_map_data" not available
"camera.dreamebot_l10s_ultra_map_data_1" completly gone
and now is the name of my device "dreame.vacuum.r2228o"
before was the name of my device "dreame.vacuum.r2228" i think ? maybe
HA is up to date.
HACS is up to date.
any ideas ? wat i can do?
cu eumel7

Yes, I hit the same issue, but now after the latest update all is back in normal. Thanks!

Hi

ok now thanks


use_tracing_allocator=True can be used only with local=True

it's not a fundamental restriction, but for now it's just a missing functionality. Currently it works this way:

the TracingAllocator records the allocations on the remote side (where the code is exectued)
the LeakDetector checks whether the TracingAllocator leaked anything inside a with: statement around a call site, which happens on the local side

To make it working with local=False, we would need to implement one or more thrift calls so that the TracingAllocator and the LeakDetector can communicate. I even started to do it, but then I realized that it was becoming unnecessarily complex and that for the sake of running our own tests local=True works well enough and it's much simpler to implement.
Originally posted by @antocuni in https://github.com/xnd-project/rbc/pull/380#discussion_r772358000

The tracing allocator was removed in #458, as https://github.com/heavyai/heavydb-internal/pull/6424 implements the auto memory management of buffers for runtime functions.


foreignColumns with multiple columns validation error

When I try and use foreignColumns with multiple comma separated keys I get the following error.
'There should be the same number of columns and foreignColumns in property customFields'
I've spent hours trying to get this to work and then found this in the source which may be related.
Could be related to this statement in MapperBuilderAssistant.buildResultMapping
List<ResultMapping> composites = parseCompositeColumnName(column);
if (composites.size() > 0) {
  column = null;
}

I cannot find that text! Can you post the stacktrace?

I don't have the stackctrace. The exception is thrown in ResultMapping.validate below. The bug is probably caused when the variable column is set to null in MapperBuildAssistant shown above.
Thanks
private void validate() {
...
    if (numColums != numForeignColumns) {
      throw new IllegalStateException("There should be the same number of columns and foreignColumns in property " + resultMapping.property);
    }
  }
}

Hi @soaringhill ,
Could you provide a test case or an example project to reproduce the issue?
It might be easier to copy and modify the existing test case using single foreignColumn.
Thank you!

Hi @soaringhill , Could you provide a repro project ?

No reply.


how to add this radio button group into uitableview cell

i want to add this group in each cell in uitableview cell
how to do this ??

i got the same question D: did u do it ?

@alexviquez , unfortunately this would require a lot of code on user's side, which somewhat defeats the purpose of the API. If you tableview is not reusing the cells, then the same API would work for you.

Hello, can you please tell me what changes i have to do in order to put the radio button to right of the text? Thanks a lot

@KhaledAld @alexviquez
Added UITableView support:
https://github.com/Abadii/SSRadioButtonsController


[CU-brre51] remove unused scripts and CircleCI config

This PR removes the last circleci config in Saturn, to close https://app.clickup.com/t/brre51.
Based on this Slack conversation (https://saturn-cloud.slack.com/archives/CL4C5HF88/p1599839178102700), it seems that the existing config was unused already. This PR also proposes removing other unused code, like the scripts in scripts/ and the Make recipe that calls them.

 Just pushed the Makefile changes


CPP-642 migrate from circleci/* to cimg/*

These images will be EOL from Dec 31st, and we should migrate to the modern cimg/* equivalents.

automatically closed 🤖

automatically closed 🤖

automatically closed 🤖


Update chaos-engineering.md

Found a typo changed "exasperates" to "exacerbates"

@doherty100 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The typo fix looks good. I added missing article (a, the).


[5.3] IRGen: ObjC method lists are not const.

Explanation: We incorrectly placed method lists in __DATA,__objc_const, causing us to dirty pages in the shared cache that are intended to remain clean
Scope: Performance issue
Issue: rdar://problem/66630432
Risk: Low. Should be no impact to end user code
Testing: Swift CI
Reviewed by: @mikeash

@swift-ci Please test

@swift-ci Please nominate


[FEATURE REQUEST] callback function when user tap the player

i want to make custom action when user tap the player.
i made the player playing ads video and i want to when user tap the player that time, user is taken to a website with webview in a new page.

If i get you correctly, then you can simply wrap GestureDetector to do that.
This is not a common use case, so can't be added to the package itself.

i want to make custom action when user tap the player.
i made the player playing ads video and i want to when user tap the player that time, user is taken to a website with webview in a new page.

How did you fixed it? I want also show ads.

If i get you correctly, then you can simply wrap GestureDetector to do that.
This is not a common use case, so can't be added to the package itself.

i have tried to wrap into a gesture detector, but onTap function wasn't called..

Will wrap player into GestureDetector show ad? now it is black screen.


The build analysis tab is not showing good results for some SDK failures

[ ] This issue is blocking
[x] This issue is causing unreasonable pain

This doesn't happen every time but here's an example where someone from another team was struggling to track down the test results failure for an SDK PR:
https://github.com/dotnet/sdk/runs/19545260835
You'lll see on the page that it lists the specific test that failed but didn't include the stack trace from the failure. BTW, it should really not show the helix work item failure as that's not generally useful data. Is there a way to remove that from the results (either something the SDK can do in how we publish test results or how build analysis analyzes the results).
Also, the details links into AzDO do not show the test results (the error message and stack trace sections are blank). This has been a bug in AzDO for months if not longer. Has it been reported to them and can we get them to take a look?

Hi Marc,
Build Analysis relies on the error message and stack trace from AzDO to show this information, if this information is not present on AzDO we are not gathering this information from any other place, so this is the reasons the information is not in there.
We haven't reported this to AzDO as is not a widespread issue, could this be specific to some tests? I am mentioning this because I was looking at this build: Pipelines - Run 20240118.65 (azure.com) and in different queues the test that were not reporting result any additional information were the same.

I don't think there is any action that build analysis can take on this, there reason the information is not showed is because is because the data is not on AzDO.
The question is because why the information is not reported to AzDO, is an AzDO situation or something happening with the test, I will remove this issue from build analysis epic

this doesn't seem to be a problem in our side, closing, please feel to reopen


Add support for cat segments

https://www.elastic.co/guide/en/elasticsearch/reference/2.2/cat-segments.html

Closed via #1934


Unify coverage and profiling handling and semantics. Fixes #81.

pantsbuild travis queue way behind.  this merges cleanly / passes at https://travis-ci.org/wickman/pex/builds/58804067


Multiple DNS and Host as Adress

Hi,
let me start saying thanks for this utility you have written, saved me a lot of time!
I have two question, not sure if they are issues of I have not configured it properly:

in options.cfg I'm not able to specify an array of "DefaultNameServer" for example something like this. Is it my syntax wrong or it is not supported yet?
{
"HideOnStart": false,
"ListenOn": "<IP_ADDRESS>:53",
"DefaultNameServer": ["<IP_ADDRESS>","<IP_ADDRESS>","x.x.x.x"],
...
}

I think would be nice ( at least in my case it would be) to be able to do something like in the rules:
{
"Pattern": "^(.*\.google\.com\.au)",
"Address": "google.com.au" <- resolve this  and use the IP
},
Is it possible? is it hard to implement?

Thanks for your help
Emilio

Currently using multiple DNS server is not supported. It can only use one DNS server.
https://github.com/stackia/DNSAgent/releases/tag/v1.4.5771 Enjoy yourself :-)

e.g.
    {
        "Pattern": "^www\\.google\\.com\\.hk$",
        "Address": "www.google.com",
        "NameServer": "<IP_ADDRESS>"
    },
    {
        "Pattern": "^www\\.google\\.com\\.tw$",
        "Address": "www.google.com",
        "NameServer": "<IP_ADDRESS>"
    },
    {
        "Pattern": "^www\\.google\\.co\\.jp$",
        "Address": "www.google.com"
    },
    {
        "Pattern": "^www\\.google\\.com$",
        "Address": "<IP_ADDRESS>"
    }

www.google.com.hk will be resolved using www.google.com with name server <IP_ADDRESS>.
www.google.com.tw will be resolved using www.google.com with DNSAgent itself.
www.google.com.co.jp will be resovled using www.google.com with default name server specified in options.cfg.

Amazing! it works perfectly!!!
Thanks :)


pschnayder: Updating the StreamWriterClosedException to include client side mitigation suggestions from the public documentation

Improved error message allows end users to have actionable remediation for encountered com.google.api.gax.rpc.UnavailableException based on https://cloud.google.com/java/docs/reference/gax/latest/com.google.api.gax.rpc.UnavailableException
The feature request is created here -> https://github.com/googleapis/java-bigquerystorage/issues/2783

/gcbrun

kokoro:run


Installing older versions of ant fails because they don't have a sha512 sum, but only a sha1

This plugin assumes you can verify all versions with sha512. This is unfortunately not the case for older versions of ant (I need one that is said works for the jdk8 build).
❯ asdf install ant 1.6.5
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 7835k  100 7835k    0     0  19.0M      0 --:--:-- --:--:-- --:--:-- 19.0M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   196  100   196    0     0   2177      0 --:--:-- --:--:-- --:--:--  2177
Authenticity of package archive can not be assured. Exiting.
tar: Error opening archive: Failed to open '/Users/wessel/.asdf/downloads/ant/1.6.5/archive.tar.gz'

Listing on https://archive.apache.org/dist/ant/binaries/
[   ] apache-ant-1.6.5-bin.tar.bz2           2005-06-02 13:43  6.4M
[TXT] apache-ant-1.6.5-bin.tar.bz2.asc       2005-06-02 13:43  194
[TXT] apache-ant-1.6.5-bin.tar.bz2.md5       2005-06-02 13:43   32
[TXT] apache-ant-1.6.5-bin.tar.bz2.sha1      2005-06-02 13:43   40
[   ] apache-ant-1.6.5-bin.tar.gz            2005-06-02 13:46  7.7M
[TXT] apache-ant-1.6.5-bin.tar.gz.asc        2005-06-02 13:46  194
[TXT] apache-ant-1.6.5-bin.tar.gz.md5        2005-06-02 13:46   32
[TXT] apache-ant-1.6.5-bin.tar.gz.sha1       2005-06-02 13:46   40
[   ] apache-ant-1.6.5-bin.zip               2005-06-02 13:49  9.6M
[TXT] apache-ant-1.6.5-bin.zip.asc           2005-06-02 13:49  194
[TXT] apache-ant-1.6.5-bin.zip.md5           2005-06-02 13:49   32
[TXT] apache-ant-1.6.5-bin.zip.sha1          2005-06-02 13:49   40

I pushed a fix, can you update your plugin and try again?


k8swatch: fix a race condition in pod change events

Hello @landism, @maiamcc,
Please review the following commits I made in branch nicks/ch4899/update:
75cbac9610e01c610b205d1b2c03faa296ef99dd (2020-02-27 17:41:14 -0500)
k8swatch: fix a race condition in pod change events
Sometimes pod events would show up in the wrong order due to goroutine scheduling
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

i think this is what's causing some of the weird integration test failures from time to time

IIUC, this fixes the potential for dispatching pod events out of order, but it replaces out-of-order pod events with duplicates of the latest pod event? This is mostly fine for the purposes of ensuring that the engine state has the latest pod state, but seems bad when we care about intermediate state, e.g., maybe we skip logging one of the stages of pod rollout.
Would it be unreasonable to fix the race condition by dropping the go when calling dispatchPodChange? (or, if we don't want to block goroutines, having a chan of pod events that we dispatch in order)

Ya, this is the same API guarantee that the informers make:
https://godoc.org/k8s.io/client-go/tools/cache#ResourceEventHandler

OnUpdate is called when an object is modified. Note that oldObj is the
last known state of the object-- it is possible that several changes
were combined together, so you can't use this to see every single
change. OnUpdate is also called when a re-list happens, and it will
get called even if nothing changed. This is useful for periodically
evaluating or syncing something.

in other words, the underlying informer APIs also dispatch duplicate events, and also expect that intermediate states will get collapsed together. So I don't think this is something we can prevent.


Regression of #7218: Backspace does not handle certain emoji correctly

This is the same issue as #7218. It seemed to be fixed at that time, but it has appeared again.
I searched duplicated issues in https://github.com/Microsoft/vscode/issues?utf8=✓&q=is%3Aissue+emoji+label%3Aeditor+
Thank you.

VSCode Version: 1.21.1
OS Version: Windows 7 Pro 64bit

Steps to Reproduce:

Input emoji.
Type backspace key.

Does this issue occur when all extensions are disabled?: Yes

I can confirm this behavior. I'm already working on it.

@mysticatea I believe this depends from emoji to emoji. For example, I cannot reproduce using the "💩" or "👍" emojis. What specific emoji are you having trouble with ?

At that time, I had used 👍 (U+1f44d). I will check again later.

It doesn't reproduce in VSCode 1.23.0-insider (1fdf60b882f0edc6753fc964b253783eb46d56ef).

I can't reproduce it anymore in 1.23. Bug was still there about 3~8 days ago.

@mysticatea @usernamehw I cannot reproduce the problem using "👍". Did you perhaps install an extension that reimplements backspace? You can look for keybindings via ctrl+k ctrl+s

By default, our command is deleteLeft.

Did you perhaps install an extension that reimplements backspace?

No. It happens with --disable-extensions CLI option.

Ok, I was able to reproduce. It has to do with a method validateRange getting corrupt output after certain edit patterns. Duplicate of #47733. The insiders release contains the fix already.


Fix tests for updated clang and lldb to 5.0.1

SSIA
@tstellar Please take a look and merge.

Sorry, I've missed that this fix is already included in https://github.com/sclorg/llvm-container/pull/1


Map Visualization

UNICEF is a co-champion of the Digital Public Goods Alliance (DPGA), a multi-stakeholder initiative to facilitate the discovery, development, use, and investment in digital public goods. Endorsed by the UN Secretary General’s Roadmap for Digital Cooperation, the DPGA defines digital public goods as: “open source software, open data, open AI models, open standards and open content that adhere to privacy and other applicable laws and best practices, do no harm, and help attain the SDGs.”
For the last two years, we have been building a registry of digital public goods compiling nominations for digital public goods (a.k.a. nominees), and screening those goods against the Digital Public Goods Standard, after which they become digital public goods. We have been compiling all this information in an open repository, and there is a wealth of data that we want to make more readily available, and explore additional ways to get insights from that growing dataset.
One aspect of this dataset that remains untapped is its geographical dimension. We have already compiled the lists of countries where digital public goods have been developed and implemented, but we have yet to visualize all this data.
The goal of this project is to build a map visualization of multiple dimensions of data related to the geographic extent of digital public goods. The multiple dimensions come from aspects like:

countries in which a good was developed
countries where the good has been implemented
countries participating in the Pathfinder activities of the Digital Public Goods Alliance (think of early adopters)
countries with implementations of goods part of the DPGA communities of practice: Digital Health, Climate Adaptation, Financial Inclusion

Proposed Implementation Plan

The map should be developed using Mapbox, and preferably as a React app (using the react-mapbox-gl library).
Country data from existing digital public goods will be pulled from this existing (and growing) set of JSON files, which has a very clear data schema defined.
The map should also be able to pull data from a Google Spreadsheet to allow for non-developer program staff to update data about their current programmatic activities within the DPGA
A similar implementation that can be used as a reference for a subset of the features required for this project can be found on this repository, alongside the live website.
At the end of the project the map should be accessible at a location like https://digitalpublicgoods.net/map (this link does not exist yet!). This is a static HTML website (a daily snapshot of a Wordpress site that gets subsequently processed to add React components), so some tweaks will have to be made to mold it into the existing infrastructure. Again, there is similar already existing functionality that can be leveraged in this other repository.

An initial implementation by Edil can be found here and a design here, and repo here. Map is able to pull data from JSONs in publicgoods-candidates and Google Spreadsheets. It uses react-mapbox-gl to render the map.
Here is Edil's proposed timeline for this project:
Week 1:

get to know the UNICEF Innovation team 👋🏽
discuss and improve the design of the map I have developed. Exported jpg version
invite team to collaborate in Figma design
show the team my prototype and repo with current implementation
discuss new ideas, workflows and how we will reveal the story through digital goods map.
align colors, fonts and styles with UNICEF brand guidelines

Week 2:

improve my standalone prototype of the map 👨🏽💻
add links to repo and data,
improve Info component,
improve select box (need to change string of the parent search box when user clicks on the good),
add styling that follows UNICEF brand guidelines
work on README and CONTRIBUTING files in repo
nominate digital public goods

Week 3:

add storytelling components to the map with react-scrollama (see visual reference https://pudding.cool/2021/04/music-bubble/ or https://pudding.cool/2018/12/3d-cities-story/)
add ESlint, husky, prettier
create function that will pull information with text from googlesheets or googledoc to storytelling components
add reviews for digital public goods 👀

Week 4:

add an additional layer of visualization with 3d polygons on a pitched map to graphically show how many goods were developed and implemented in each country. (visual reference https://pudding.cool/2018/12/3d-cities-story/ and the last component at the bottom in my design of the map https://drive.google.com/file/d/1WuWEdKEhhEbZkAiaWqbfuCsjqGxsOnql/view?usp=sharing)
add responsive design to the map
add reviews 👀

Week 5:

improve initial rendering of the map. Now it re-renders each time when json is loaded. One of the workarounds is to add loading component that will be shown until all files are loaded.
add nominees

Weeks 6-7:

finish a story (or a guide) of the map
seek and fix bugs
deploy map to the https://digitalpublicgoods.net/map . I guess I'll make script in publicgoods-scripts repo that will create a new path in publicgoods-website repo.
add reviews 👀

Weeks 8-13:

add new features if have any
seek and fix bugs after deployment to the main site
improve layouts and fix bugs in other sections of the digitalpublicgoods.net site:
fix issues I added here
make site mobile friendly
add JS linter to all repos
add nominees
add reviews 👀

Technologies for the digital goods map project: JavaScript, React, react mapbox-gl, JSON, react-scrollama, g-sheets-api, github-api, eslint, husky, prettier, figma

Based on discussion with comms and pathfinders teams we agreed to develop 2 separate maps for DPGs and Pathfinders with 2 different stories. They will suit use cases like advocacy presentations for governments and organizations, investors, private sector, potential DPGs, tell success stories and will not overwhelmingly overlap with each other.
Current design and repo for the map visualization.
Proposed steps:

[ ] develop a flexible reusable map component which will be suitable for Pathfinders and DPGs sections and also could be a standalone visualization with all layers of data.

[ ] add responsiveness
[ ] update the design according to the DPGa guidelines
[ ] add a storytelling component
[ ] add a ability to mix storytelling with images and videos
[ ] develop integration with google doc. We need an ability to parse the text from doc into structured jsons so non-technical staff can edit text for storytelling components. (Or use google spreadsheets)
[ ] graphically show how many DGPs are implemented and developed in each country
[ ] develop an info component with information about selected DPG
[x] show popups with information on countries
[x] show countries in which a good was developed
[x] show countries where the good has been implemented
[x] show countries participating in the Pathfinder activities of the Digital Public Goods Alliance (think of early adopters)
[x] show countries with implementations of goods part of the DPGA communities of practice: Digital Health, Climate Adaptation, Financial Inclusion
[x] pull data from set of JSONs
[x] pull data from google spreadsheets

[ ] integrate standalone map visualization

[ ] integrate map for DPG story (in registry section?)

[ ] create story and text

[ ] integrate map in Pathfinders Countries section to improve heavy text mixing it with images and videos (technical idea like in this Washinghtonpost article)

[ ] create a story and text

[ ] create documentation on how to update stories

A couple of screenshots from the latest update are below. 3D bar graph visualizations.

MVP is ready.
But before moving forward I want to add an ability to select country from a dropdown list and display summary information with charts about DPGs activity in each country.
Proposed feature

[ ] add list of countries in searchBox
[ ] clicking on countries from list zooms to country
[ ] clicking on countries displays information about country

[ ] How many goods are deployed and developed
[ ] Pathfinder data
[ ] How many deployed DPGs are related to each SDG in country
[ ] which and how many types of DPGs are deployed in country
Related issue, current implementation


The reconstructed image is strange

When I tried to use the PTI optimization model and run the inference_on_Videos. py file, the adhesion effect of the video result was too obvious, like pulling gum. In a single frame of the picture, this effect could be reflected in the afro, and the viscous effect in the two frames of the afro could be seen, which was very average in the video performance. This phenomenon also exists in reconstructed video.
The image below shows the original, reconstructed, and edited afro.

I have a feeling that there is something wrong with the inversion since the reconstruction is quite poor, perhaps leading to the poor editing you got on the right.
If you did everything correctly, you should be able to get a very good reconstruction of the original video.


Make comments extra column

Fixes #618. Torrent name column is small due to there being no s/l/d data. It'll get bigger when those fill.

Forgot image!


Added siren trigger functionality to cameras

Added siren trigger functionality to cameras

Do NOT add news sectoion to io-package.json and do NOT change version numbers at io-package.json and package.json. Version numbers will be updated by release scripz

Do NOT add news sectoion to io-package.json and do NOT change version numbers at io-package.json and package.json. Version numbers will be updated by release scripz

sorry, first time helping with a community adapter! Should be fixed now!

Will look at it later this evening👍


Clips - When/where are the objects populated?

I am attempting to understand this code better. I really appreciate the effort to make an example project, but its convoluted and the code is too terse for an reference/example project. Someone really likes destructuring assignments. I think it would have been better to sacrifice the latest and greatest language features and focus more on readability.
I am currently stuck on the block below. I see these objects instantiated, but I don't see where the values of each array are populated. Look at the first item below, for example, "idleClips1".  If I inspect the object after instantiating here, it contains the stand_idle_clip, which is great, BUT, how and where was it populated? Any insight will be appreciated.
        const [
          idleClips1,
          lipsyncClips1,
          gestureClips1,
          emoteClips1,
          faceClips1,
          blinkClips1,
          poiClips1,
        ] = clips1;

https://github.com/aws-samples/amazon-sumerian-hosts/blob/46f44174b264e0bc134c7ad9f548eee99586dcfc/packages/amazon-sumerian-hosts-three/examples/three.html#L299

I figured it out, so I'll go ahead and close this issue. Thanks!

@AdonousTech I agree with you that our Three.js sample application is too complex and too difficult to understand. That said, we recently made some major ease-of-use improvements to the core Sumerian Host API and to many of the sample applications. This includes reducing the amount of required boilerplate code down from ~360 lines of code to just 7 lines of code and providing new sample applications that narrowly focused in demonstrating individual features in a clear, easily digestible way. Unfortunately, we only updated the Babylon.js sample applications with these ease-of-use improvements. We haven't gotten around to doing the same for Three.js.
Until we have an opportunity to apply the same simplification to the Three.js sample application(s), you may find it helpful to use the Babylon.js samples as a reference. The way you implement code to interact with the Hosts and the new Amazon Lex functionality we've added should be identical (or very similar) between Three.js and Babylon.js even if some of the other 3D framework interaction code is not.


Mismatch is size of tensor while using eval_Bread.py

Error:
RuntimeError: The size of tensor a (1365) must match the size of tensor b (1364) at non-singleton dimension 2.
Reason:
Basically there is the main input texture size texture_in extracted directly from image then there is the texture illumination, in which dimension reduction is done first and then restored back to normal.
first F.interpolate to calculate texure_in_down with scale factor 0.5 halves 1365 and gives 682 (since it has to be an integer, so 682.5 becomes 682)
second F.interpolate to calculate texture_illumi restores the dimension by doubling it(previously halved) - 682 * 2  is 1384 which is 1 less than 1385 the actual dimension.
Can you help me fix this?

It is a common problem that UNet-based models can only process the images with scales multiplied by 2^N, where N represents the number of downsampling layers in the network. So, please round the size of your input image into 1365//(2^N)2^N, e.g., 32 in our case, and thus the new size is 1365//3232=1344.

Since there are no further questions, we'll go ahead and close this issue for now. If you have additional questions in the future, feel free to open a new issue.


WIP: openjdk: 10.0.2 -> 11

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Major TODOs:

[ ] JRE is deprecated, they recommend using jmod
[x] ARM doesn't build openjdk but uses oraclejdk

~get them building~

~need bootstrap jdk for ARM~

~update oraclejdk to 11 too~
[x] realize that 10 wasn't working on ARM anyway (#48649)

[ ] Consider reusing some of the AdoptOpenJDK build scripts? https://github.com/AdoptOpenJDK/openjdk-build

It probably fixes https://github.com/NixOS/nixpkgs/issues/37364

We'll need a bootstrap jdk for arm before we can build openjdk for that architecture.

Squashed some of my WIP comments ... I think I need someone who has access to darwin to make that update, though?

Okay, I've tested that eclipse runs with jdk11 locally.  I think once someone can confirm that the darwin jdk11 is basically working, this is ready to merge!

  I just followed the Referer:https://www.azul.com/downloads/zulu/zulu-linux/ link, which points to linux, and cut-n-pasted away.  :(
Fixed in https://github.com/NixOS/nixpkgs/pull/48326/commits/1bd7b98c7975136ddd6183a155e90688fd5b3e43, please try again!

All good, bazel_jdk11 builds and runs correctly with 1bd7b98c7975136ddd6183a155e90688fd5b3e43. I wasn't able to test building java 11 code with it because your branch doesn't have bazel-0.18.0 from current master, but only bazel-0.17.1 from an older point, but I think it should be ok as far as the jdk is concerned.


chore(ci): test dev shell building

For future reference, this job should prevent these types of issues: https://github.com/fedimint/fedimint/issues/4217

Thanks @dpc!


Add inbox emoji

This could be enabled/disabled.
I have emojis on most of my projects, but since you can't customize Inbox, it doesn't display.
Add option to display Inbox as "📥 Inbox" instead of "Inbox"

Ok, now I might be overcomplicating this, I think the ideal way to do this would be to split the array into two values, one for "Icon", and one for "Name", (or "Display Name" and "Name").
Then I could display as Icon + name (📥 Inbox) but interact with it still as "Inbox"
As it stands, if I enter "tod project inbox" it doesn't work (since I am not entering the exact name), but if I navigate to the "select project" menu, I get the Icons shown.

Hm. Right now I am just storing projects as key value pairs, but I could see us improving on this by making it a list of objects in the config. We would need to put it under a new key and figure out the new structure. It's important to me that we make the importing process easy so perhaps keep that simple and have people customize their projects with tod project edit later.
The keys for each project could be name display_name id and is_inbox off the top of my head

I'm all ears for any good way to approach this, I think any of the above would work.

This problem is likely resolved for you now @stacksjb
Projects are now stored as vector of Project structs, which means that the order in the config is the order in the selection dialog. So you can change the name of the project and it won't change the ordering.


Invalid required PHP version.

In composer.json we see that lib requires php >= 5.4 version.
    "require": {
        "php": ">=5.4"
    },

But in code I see some features that requires at least PHP 7.1 version:
[$type, $value] = [key($xml), current($xml)];

https://github.com/Shardj/zf1-future/blob/master/library/Zend/XmlRpc/Value.php#L489
https://github.com/Shardj/zf1-future/blob/master/library/Zend/XmlRpc/Value.php#L495

Let's either rewrite code to be compatible with PHP 5.4 or set minimal required version to PHP 7.1

Thanks, good spot there

@Shardj would you accept pull requests to make it compatible with older versions? My project currently runs at php 7.0, 7.2 and 7.4 / ubuntu 16,18,20 LTS

Okay @Jimbolino go for it


Add class slots

Add all necessary classes needed to add and store lessons in schedule.
Fixes #70

Will resolve conflicts, do not merge yet


Update "Getting started" in project wiki

The main README has a link to the wiki for "Getting started", but it doesn't tell you anything about how to set up the project.
Add a page in the wiki to include "Getting started" instructions on how to get the project set up and running locally.

"Getting started" wiki page created and available here


Normal export seems incorrect (Blender 2.79 and 2.8)

Importing a gltf file exported from Blender 2.79 or 2.8, normals do not conform to the one of the created object.

On the left the object created in Blender, on the right the same object exported and reimported.
Same result imported into Godot: normals are not correct.
It seems that the vertex and face normals are ok, but not the edge normals.

Attached the blend file and the gltf file.
BlendAndGltf.zip

Because I needed custom normals for a project, I tested different glTF exporters for Blender 2.79.
This one https://github.com/Kupoman/blendergltf exported them correctly.
Maybe it could be some inspiration.
Testfile: https://github.com/aframevr/assets/blob/gh-pages/controllers/microsoft/default/right.glb

Thanks to @pjoe this problem seems to be fixed in #414.
My tests with the mentioned glTF file result in correctly exported custom normals.

export obj file instead fbx worked for me , but fbx export still wrongly export vertex normal

Hello,
This repository is about glTF, not obj or fbx.
If you have an issue with glTF, please do not comment an old (already solved) issue : Create a new one, and follow guideline, providing all necessary information to be able to reproduce (including an example file). Thanks!


Allow overriding the server-side generated AllowedIPs for a device.

This would allow topologies where a connected device may be set up to route packets to one of its connected networks (e.g. site to site).

Hello,
Do you know when this feature will be available?
Thanks

This area will be changing quite a lot in 0.8, so I'll add it to the 0.8 milestone to revisit then.

Hello, ok, thank you
Do you have an approximate release date for version 0.8?
Thanks

No ETA just yet, still working on it :-).

Ok, thank you

This would be perfect for managing devices at home that doesn't allow installing Wireguard. A TCP tunnel isn't always possible because of a required app on a Client PC.

Have added my own hacky support for this -- DO NOT RUN on anything production-like or otherwise sensitive!!
https://github.com/xAiluros/firezone/tree/site-to-site
Requires variable in .env, example (this will route that net through wireguard device):
WIREGUARD_IPV4_SITES=<IP_ADDRESS>/8
And then you could set (subnet of) that in device configs:

I have only tried with a single connected IPv4 subnet to a device. This could then be successfully communicated to from another device.
Of course the client to which the site is connected, needs to have routing enabled (I only did 1 "test" from Linux client).
Not sure to what extent it works with the rules. Possibly saw some strange behavior. But playing around with the rules a bit I could get it setup fine for my lab environment.
Note: this is NOT TESTED properly at all!

As I understand, this is for site-site VPN which will be irrelevant in 1.0 with the introduction of Gateway instance groups.
You will be able to deploy multiple Firezone Gateways to your private networks, and use the Firezone clients to access those. NAT traversal will be performed automatically to achieve the best path for packets to route.


Pylake Version 13.1 does not display the tracking widget

I recently update the pylake version to 13.1 but the tracing window is not dispalyed. I tried to update and downgrade matplotlib which did not help. Downgrading the pylake to version 12 however seems to solver the issue.
Here is the screenshot.
Note:scripts are run in latests version of the VS Code.

Hello, thanks for bringing this to our attention. I just tested again on my system and the widget works as expected using jupyter notebook (browser based) and also displays when I use VS Code, although the layout is not what it should be.
Would you mind trying v0.13.1 with the browser version to see if it works? This could help us pinpoint where exactly the problem might be. I suspect it might be specifically with the %matplotlib widget backend versus %matplotlib notebook

How did you install Pylake? Did you use conda or pip? Starting with v0.13.0 the notebook dependencies have been marked as optional (if you are using pip). This should do the trick:
$> pip install lumicks.pylake[notebook]

More details here: https://lumicks-pylake.readthedocs.io/en/stable/install.html

i do use conda for the installation.I have no issue in the browser as well. Issue seems to be VS code specific. Notebook backend also does not help. I am simply switching to the browser while I troubleshhot the VS code.Thanks

Perhaps VS Code is not picking up the correct conda environment? See https://code.visualstudio.com/docs/python/environments#_conda-environments

Another thing that may be worth checking is which version of ipywidgets you are running. VSCode only supports ipywidgets up to 7.x at the moment. See: https://github.com/microsoft/vscode-jupyter/issues/8552


Refactor cable_car to eliminate duplication

2 files added:

operation_builder.rb

Holds all duplicate code between channel and cable_car. This class is solely responsible for building the operations hash, and returning the required values for transmitting and such

operational.rb

Operational is a module included by classes using OperationBuilder. It exposes a operation_builder method that creates or returns a single instance of OperationBuilder. It forwards all missing methods to OperationBuilder should it respond to it, as well as implicitly returns self from missing methods (allowing method chaining).

I also added tests!

Hey Josh, I finally had a proper opportunity to go over this PR and it's really great. I have some questions and requests but I'm 100% going to merge this once it's sorted.

Nate changed the way the finalizers are handled. Could you fix the merge conflict and make sure all of the classes follow the pattern he set out? (Specifically, I think operation_builder.rb will need to be adapted.)
What's the purpose of the method missing construct in operational.rb - that is, why is this necessary?
What is the purpose of the _ = nil parameter definition in the to_json method of operation_builder.rb?
Any chance you'd be up for implementing the custom ApplicationController Renderer in cable_ready.rb? You expressed a confidence that I just don't have, and I fully believe you're probably right about how it could work.
I see that you rolled back my proposed deep_transform_keys! fix for the options hash. You're probably right about this not being necessary since my tests today show that the JSON generated is consistent even without the deep_transform_keys! call. You can see in the example below that the @enqueued_operations has bonusRound and bonus_round keys, but it all seems to come out fine:

Thanks Josh! This makes the whole PR even more transformative.

@leastbad
The method_missing in the operation module forwards calls to the underlying operation builder. Lets you use the operations directly on cable_car/channel. It's basically a generic way to delegate methods to the operation builder.
to_json accepts a single parameter, so when we're defining our own we should respect that standard. Really I should be forwarding `args to the underlying to_json, so I'll do that when I work out those merge conflicts and check out the custom renderer.

You rock, sir! I was very impressed with your implementation.

@leastbad
Nate's changes threw a wrench in the works, so I've made OperationBuilder a class that cable car and channel inherit. It's functionally the same as it was, except now cable_car has an identifier of "CableCar".
I've added the custom renderer you were looking for as well.

That's awesome, thank you very much.
I'm sorry that the finalizer changes were more dramatic than I had realized. That's also precisely why I left it for you.
When you say that "cable_car has an identifier of 'CableCar'", where does that come into play? What I'm really asking/picturing is that developers will include CableReady::Broadcaster and be able to use either cable_ready or cable_car depending on their goals. Is that still true? In what scenario might a developer need to access the CableCar class?

Doesn't effect the developer, it's just for the finalizers.
https://github.com/leastbad/cable_ready/pull/3/files#diff-3b00f39afd756a369ec89f2e16eacefb3e10e6b423cc3e96fcfd294ae436e1f7R10

channel.rb is now broken because there's no operation_builder in scope.
I'm pretty sure this would fix it:
    def broadcast(clear: true)
      ActionCable.server.broadcast identifier, {"cableReady" => true, "operations" => operations_payload}
      reset! if clear
    end

    def broadcast_to(model, clear: true)
      identifier.broadcast_to model, {"cableReady" => true, "operations" => operations_payload}
      reset! if clear
    end

@leastbad Thanks for the catch.
Had trouble getting tests working for those methods due to not running in a rails context. We should really cover those if we can figure out how.

Just being honest, @marcoroth is about 850x more likely to know how to help with that. It's a major hole in my capability.
Anyhow, thanks for helping to make cable_car and CableReady better!


matching: fix crash on task list shutdown

This patch fixes a crash that can happen during taskListMgr shutdown. The matching engine is responsible for adding new tasks to a task list and this addition is an async process today:
AddTask() -> taskWriter.appendTask() -> [req-channel] -> taskWriter.writerLoop() -> TaskList
/\
|
------------------   [ resp- channel ]  -----------------------
So, during shutdown, writerLoop() exits and closes the request channel, but tasks can still come in through. This can cause a panic due to send on closed channel. This patch fixes this by never closing the request channel. In addition, the patch contains a few more changes to the shutdown to avoid duplicate tasks in the task list.

Coverage increased (+0.09%) to 67.548% when pulling 41f4ab91ffcd24aed2dcf29c86dc6840d4a3044d on crash into 5530fac266cdaad370442a6aa57e8f59051a24fb on master.

Coverage decreased (-0.01%) to 67.448% when pulling d3493d2fffb4c93d43ecdf0668bb918867d6d54f on crash into 5530fac266cdaad370442a6aa57e8f59051a24fb on master.


Migration to Nuxt 3

Fixes

Fixes #411 by @obulat
Description

This PR migrates the frontend app from Nuxt 2 to Nuxt 3. The following functionality works well:

search
single result pages
related items
collection pages
analytics
Playwright tests (visual regression and e2e)
unit tests
auth

Fetching changes
Fetching media on search, single-detail and collection pages is done in useAsyncFetch. Previously, we were splitting the fetching between middleware for the server and the useFetch for the client fetching, to make sure that the server finishes fetching before sending the page to the client, and there are no client-server mismatches. While working on this PR, I realized that Nuxt requires some data (payload) returned from the useAsyncFetch function to cancel re-fetching of the same data on the client when hydrating (which was actually causing the mismatch).
We cannot call showError from inside the useAsyncFetch, so there's an error watcher that redirects to the error page after the useAsyncFetch in the components.
The search results are now fetched in the search layout. The reason for moving it from the child search.vue page was the fact that the server-rendered page would not update the result count in the header after the server fetches the media. This was causing the server-client mismatch.
Global audio player
The global audio component is moved to the app.vue, the base component for all pages. The global audio would either keep playing on navigation, or stop playing when navigating from one single result page to the other. Previously, we were getting the active audio properties from media store or from the related media store. If the item wasn't found in the store, it would be set to null, and the player would be closed until the new item is fetched from the API. To fix this, I added the detail property to the activeAudio store, so that if there is an active audio, we always have its properties and can show it in the global player.
API proxying
The API calls are now proxied through the Nuxt server route (/api/...). This allows us to send the auth credentials with all of the Nuxt requests.
TODO:

[x] add tests for the API token flow #d5716a4
[x] add tests for fetching media #9aa194c
[ ] #3664 add Storybook
[ ] #3694  fix the Playwright Docker build on a Mac (currently, it does not build because a rollup platform-dependent dependency is not installed)
[ ] #3665 re-add Prometheus
[ ] check that Sentry works correctly
[ ] Ensure that the .env template file has all necessary variables
[ ] Check that the Docker build sets the .env variables correctly.
[ ] Add a note to increase the memory locally if there's an error.

Testing Instructions

Go to https://staging.openverse.org and check that the deployed version works correctly. Read through the code and see that it makes sense.
Locally

Remove the node_modules folder and re-install packages:

rm -rf frontend/node_modules && just node-install

Run the project with the following modified option:

export NODE_OPTIONS=--max-old-space-size=8192 && just frontend/run dev

Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat Can we close this PR in the meantime, until we get ready to attempt this again (or do something else entirely)?
I'll close it proactively, but please reopen it with a note why we need to keep it drafted long-term, if that is the case.


Bridge CLI updates for production environment

Summary

RFCs: Link to RFC, Link to RFC, or $\emptyset$.
Categories: any of protocol-units, networks, scripts, util, cicd, or misc.

Changelog

Testing

Outstanding issues

The CLI is for the bridge operator to do any call, such as refunding and aborting and also starting the bridge service. It runs as a separate process completely to the service so it needs a way to communicate with the ETH and Movement Clients, the best way is via gRPC.
The CLI is not for users, but for the bridge operator (us).

Users make calls to the Bridge via the  Front End.

When I run cargo run -p bridge-cli  I get:
Command line interface to perform atomic bridge transfers

Usage: bridge-cli <COMMAND>

Commands:
  eth-to-movement  Ethereum to Movement bridge commands
  movement-to-eth  Movement to Ethereum bridge commands
  help             Print this message or the help of the given subcommand(s)

But then when I run bridge-cli or  ./target-debug/bridge-cli I get:
zsh: command not found: bridge-cli

This is what we expect. Not sure about running it from the target I didn't test that. Is it the correct path?
Command line interface to perform atomic bridge transfers

Usage: bridge-cli <COMMAND>

Commands:
  eth-to-movement  Ethereum to Movement bridge commands
  movement-to-eth  Movement to Ethereum bridge commands
  help             Print this message or the help of the given subcommand(s

I think so (see screenshot). Should the subcommands run in general?
Or should it be expected to return command not found: bridge-cli?

One thing, I'm going to remove all the calls that the relayer will call automatically, I can't think of any reason why the CLI would need to support them. Let me trim this down to remove bloat and I'll check your issue.

A command I run with the executable that works:
./target/debug/bridge-cli eth-to-movement initiate "0x8bcdbe40eeb01c7451f359318e5709c16ab2f23c3a9fa71531cca57920aa828c" 100 "2bb80d537b1da3e38bd30361aa855686bde0b2f16f48e5b536b0f7625a529f33"

We are missing config still but the args get sent to the client correctly. The client currently does not connect to anvil it. Once https://github.com/movementlabsxyz/movement/pull/640 is in, it will just look to the config to initialise the EthClient and Movement Client.
I created a README.md with some instructions also.

Admin CLI can be useful, but draft for now as this is for the HTLC protocol.


Improve logging

The artifact resolver is not giving any information about which artifact from which source and with which version it is trying to resolve before actually performing the actions. This should be fixed.

Solved in https://github.com/aservo/docker-artifact-resolution/pull/5


GitHub actions

Integration with github actions.
Compared to Travis it is faster, but the UI seems a little clunky at the moment.
Thought we could have both running for a while to see which works better.

Just noticed on pull requests it doesn't do a rebuild.

Hi, we don't even need to pull the image ourselfs.

I just created a PR with my comments. #146 Maybe you like them. ;)


Touchscreen does not work unless I disable SSDT-DTPD.aml

Hello,
I saw there were touchscreen/multi touch functions advertised in your EFI but it seems like I couldn't get it working with the latest EFI unless I disable the SSDT-DTPD.aml - is this by design?

lol yeah my bad, it’s meant to be disabled by default and if you want to save power you can turn it on. it was meant to be in the instructions :)

Awesome! Thanks just making sure


Python 3 compatibility integration

I've converted the scripts to Python 3 over at https://github.com/NPCai/oie-benchmark. Let me know if and how you'd want this integrated @gabrielStanovsky, whether into master or a new branch potentially.

Hi @jbecke, thank you very much!
I'd be glad to integrate this into a separate "Python 3"  branch on the main fork.
Can you try to open a pull request for that?
Please let me know if you can do that, or if you need me to open a branch for that on my fork first.
Thanks again!

I opened one, called python3
https://github.com/gabrielStanovsky/oie-benchmark/tree/python3

Addressed in PR #11 .


Architecture options

Hello!
Currently the options/arch can contain just one architecture value. It would be a helpful feature for arch to accept a list of values, such as: ["arm64-v8a", "universal", "noarch"], and the app would download the first one found.

Now the downloader will fallback to universal if selected arch is not found, universal and noarch are now interchangeable.

Awesome! Thanks! :)


MetadataValues' list doesn't respect ordering after been modified

References

Fixes #8736

Description
Whenever a metadata is added inside the metadata-list of a DspaceObject, the default order used while loading them from Hibernate will be lost. Thus, in some point (like the replaceMetadata  method) we are wrongly accessing this list using indexes that are not respecting the place of the MetadataValue.
Instructions for Reviewers
Added few checks inside the DspaceObjectServiceImpl::getMetadata that verifies that some changes occurred on the metadata-list and then sorts it only after it has been filtered by a target MetadataField.
Introduced a common class MetadataValueComparators that will contain all the usable comparators for the MetadataValue instances.
Extended ITs of the RestRepositories to fully test the replacement of multiple values all at once.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[x] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

The IT errors here were on main and have been fixed in #8746.  If you rebase on main they should go away.


Wrong Index number of images being returned

If we move from start till end the index number that is returned is write but for example if we are at index 3 and flip 1 page back then instead of 2 the index returned is 1.
I am reading the index in log in getBitmap(int width, int height, int index) in CurlActivity.java file.
            public Bitmap getBitmap(int width, int height, int index) {
		Bitmap b = Bitmap.createBitmap(width, height,
				Bitmap.Config.ARGB_8888);
		b.eraseColor(0xFFFFFFFF);
		Canvas c = new Canvas(b);
                    Log.i("index",index+"");                                  // using to print the index

Or please tell me at which place in source code I can get the correct index number.Actually I need the correct index number of images while flipping on both sides.

Firstly, sorry for being lazy on commenting on issues here. Been busy on other things.
Anyway, do use CurlView.getCurrentIndex() instead. BitmapProvider.getBitmap callback asks for Bitmaps in more/less "random" order and it is not guaranteed to be directly related to page indices being shown.


SensorManager output logged to console, even after dispose

Steps to Reproduce
Open screen with CameraAwesome.
Expected results
Nothing spectacular, working camera.
Actual results
Somewhat working camera and a bunch of
D/SensorManager( 5105): TYPE_LIGHT (5): 377.000000

in the output.
Happens even when you dispose the screen with the camera.
Sign of a leakage?
About your device

Brand
Model
OS

any
any
Android

I have the same issue

I, too

This should be fixed with the reworked version #150


Markdown typo fix

Docs Build status updates of commit 7a15c27:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerquery-docs/HandlingDataAccess.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @bgribaudo
Thanks for the feedback!

Docs Build status updates of commit 7a15c27:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerquery-docs/HandlingDataAccess.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


AMBARI-24516 - Default value for LDAP type

What changes were proposed in this pull request?
same as #2181

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3893/
Test PASSed.


Enable MacOSX Apple Silicon release

Fix deprecation warnings from release job, opt out musllinux by default in pyproject.toml, fix issue with insufficient permissions when building using macos-14 GitHub runner.
To install Python package for MacOSX Apple Silicon from test PyPi:
python3 -m pip install --index-url https://test.pypi.org/simple/ hyperon

Version <IP_ADDRESS> should be installed.

@Necr0x0Der already tried to install it on M1 so I am merging it.

One thing that's worth mentioning.  My changes moved the C lib tests from testing the static lib to testing the dynamic hyperonc lib.  Meaning I switched the BUILD_SHARED_LIBS argument to ON.  But that has no bearing on this change.

Meaning I switched the BUILD_SHARED_LIBS argument to ON in the install-hyperonc script. But that has no bearing on this change.

Actually it means we completely don't support musllinux platform, so the comment in https://github.com/trueagi-io/hyperon-experimental/blob/14bf9ee36467ee391f5b96d4bd61b3bda1e47af7/python/pyproject.toml#L39-L40 should be changed. @luketpeterson do you mind doing it in your branch then?

Do you think I should go back to testing the static lib?  My reason for switching the tests to the dynamic lib was a thought that the C users are likely to use the dynamic lib so it provides a cleaner test (closer to the user's config) and I figured it didn't harm anything because I thought we didn't support musl linux anyway.
But if there is a reason we might want to keep musl linux in the future, I can put the tests back to testing the static lib.
Otherwise I will do as you say and remove the comment entirely.

But if there is a reason we might want to keep musl linux in the future, I can put the tests back to testing the static lib.

I don't think supporting musl is critical, thus I am ok switching to the using of dynamic libraries in tests. Anyway if something will change we can return to this question. The only thing which bothers me is to have nice clue in comments to understand what exactly is not support on musl platform.


semver: do not support upload() from url

Remove the upload() from url functionality. Instead, use
File.createWriteStream.
For performance reasons, nodejs-storage should not require the request
module. As we are currently exposing request as part of the public
API for upload(), not using request is a breaking change. Instead of
using a different dependency for the http requests, we leave this decision
to the users.
If you were using upload() from a url, replace it with the following:
const request = require('request');
let readStream = request(url).createReadStream();
const file = bucket.file(name)
const writeStream = file.createWriteStream();
readStream.pipe(writeStream)

Use node-fetch instead of request in system tests.

Sorry, didn't include the reasoning, see updated commit message.

Heads up @Kiricon-- we're going to be removing the feature you added for us. Do you think it's a mistake? The dilemma is that it forces us to keep a dependency on request, which we are trying to avoid (it's big, and it has introduced some security concerns).
We have a couple of options:

Get rid of the feature. The user can handle fetching the data themselves, and pipe it into a file.createWriteStream(). This is definitely not as easy as "put this remote file in my bucket". The user will have to create a File object, and familiarize themselves with the streaming APIs that both our library and their possibly-new HTTP-fetching library.
Use a different request library, but somehow remain library-agnostic when accepting common HTTP options, like headers.

Thoughts and ideas welcome!

It's been a week with no objections, can we merge this?

I consider this as a mistake. There are no "perfomance reasons" to do this. It's now harder to upload files, without any benefits performance-wise. Welp.


JHU-USA deaths > cases

Does anyone know anything about JHU-USA deaths > cases for the unassigned counties? Can someone ask them about it?
AK cases: 0 deaths: 1
AZ cases: 0 deaths: 6
CA cases: 0 deaths: 1
FL cases: 0 deaths: 2
MD cases: 0 deaths: 1
MN cases: 0 deaths: 4
NY cases: 0 deaths: 159
VA cases: 0 deaths: 5

Yes, I believe they've tracked deaths, but don't know where the deaths occurred. It's ok that there are more deaths than cases in unassigned regions.


Rework build commands

Preparatory work for #693
No change in generated site files

Build is green. Merging.


Error message system

We want an error message system as the one in Rust. For every possible error by the user, we should output an error message which explains what went wrong concisely, as well as an error code such as E1032, which users can use in a call to Tissue.describe_error(:E1032) in the REPL, and get a verbose description of the errors, common mistakes related to it, examples on how to fix it, etc.
This will be especially useful when writing macros, to help the user use the correct syntax.

Note: for the error of binding a calculator's input stream to an output stream of a different type, we can use Core.Compiler.return_type(function, args_tuple) to check, in the graph constructor, if types works.


Is complex number supported in OptimKit?

For complex optimization, there is an error for missing method isless(::ComplexF64, ::ComplexF64). Is the complex number supported in OptimKit?

Thanks for the quick reply. My cost function is real. I figured it out as I needed to define the inner function by taking the real part.


DINO vs DINOv2

Is there any reason why you guys utilized DINO instead of DINOv2? Was performance worse when using DINOv2?

Hi,
The aim of this paper was not to achieve strong performance on Camelyon16 (even though we get very high AUC) but rather to compare Vim and ViT under a similar self-supervised framework, specifically DINO, given the robust performance and appealing properties of ViTs trained with that framework. We wanted to show that Vim can outperform ViT models in a framework that favors ViT encoders.
We haven't tested DINOv2, and it could be a framework to explore. However, note the following from the second DINOv2 paper:

When used to extract features, it delivers disappointing performance, only on par with supervised alternative backbones in this scenario. This suggests that DINOv2 behaves differently than DINO. The investigation described in this work notably exposes the presence of artefacts in the feature maps of DINOv2 that were not present in the first version of this model.

Hence, a model trained with DINOv2 might not have similar properties as discussed in section "5.4. Explainability" of our paper.
Let me know if you have any questions.

Thank you for your comment, really appreciate it! Yes, I am aware of your purpose of the paper, which was to compare and contrast Vim and ViT. I was just wondering because many other vision foundational models in pathology and other vision modalities utilize DINOv2 for self-distillation and achieve good performance.
I overlooked the explainability part, thank you for mentioning that. If using the CLS tokens to create the attention maps like you guys, maybe we can utilize the register tokens (from the paper that you mentioned) during training? Maybe I will try to work with DINOv2 and see how it does with and without registers. Thank you for your response!

Thank you for your interest in our work! Since Vim models are new types of encoders, they have yet to be explored in many self-supervised settings. Training them within DINOv2 with/without registers is an exciting topic. Since their behavior differs from ViT models, they might work fine without registers or, in contrast, greatly benefit from them.
Looking forward to seeing your results!


romulan does not support reading "Dragon Range" UEFI/PSP firmware

Hello,
It appears romulan does not support reading/extracting/etc. the attached UEFI ROMs from ASUS GX650PY (7945HX) and G733PYV (7945HX3D), two devices with Zen 4 "Dragon Range" CPUs. The ROM images/PSP data within appears to be intact/undamaged, as AM5 SMU Checker v0.8 and IOActive's efs_parser.py can read them. Please see the attached files and the error output:
noellemercer@Noelles-MacBook-Pro Downloads % romulan GX650PY319.rom
GX650PY319.rom
romulan: GX650PY319.rom: Flash descriptor not found
noellemercer@Noelles-MacBook-Pro Downloads % romulan G733PYV323.rom
G733PYV323.rom
romulan: G733PYV323.rom: Flash descriptor not found

GX650PY319.rom.zip
G733PYV323.rom.zip

Thank you.

Hey, I've forked Romulan to https://github.com/fiedka/romulan and heavily extended it already - will be happy to take a look at this!


Errors when trying to build with mocha-loader

I'm trying to build test files with webpack using mocha-loader and babel-loader and when I try running webpack I get these warnings/errors:
WARNING in ./~/mocha-loader/EnhancedMocha.js
Critical dependencies:
29:24-37 the request of a dependency is an expression
 @ ./~/mocha-loader/EnhancedMocha.js 29:24-37

WARNING in ./~/mocha/lib/mocha.js
Critical dependencies:
167:20-37 the request of a dependency is an expression
199:17-30 the request of a dependency is an expression
219:26-39 the request of a dependency is an expression
 @ ./~/mocha/lib/mocha.js 167:20-37 199:17-30 219:26-39

WARNING in ./~/mocha/~/minimatch/minimatch.js
Critical dependencies:
6:5-12 require function is used in a way in which dependencies cannot be statically extracted
 @ ./~/mocha/~/minimatch/minimatch.js 6:5-12

WARNING in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'markdown' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 66:11-30

WARNING in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'discount' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 69:13-32

WARNING in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'markdown-js' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 72:15-37

WARNING in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'marked' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 75:17-34

ERROR in ./~/mocha/index.js
Module not found: Error: Can't resolve './lib-cov/mocha' in '/Users/calebmer/Projects/pbx.me/node_modules/mocha'
 @ ./~/mocha/index.js 2:4-30

ERROR in ./~/jade/index.js
Module not found: Error: Can't resolve './lib-cov/jade' in '/Users/calebmer/Projects/pbx.me/node_modules/jade'
 @ ./~/jade/index.js 3:4-29

ERROR in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'sass' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 24:15-30

ERROR in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'stylus' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 35:17-34

ERROR in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'less' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 50:4-19

ERROR in ./~/jade/lib/filters.js
Module not found: Error: Can't resolve 'coffee-script' in '/Users/calebmer/Projects/pbx.me/node_modules/jade/lib'
 @ ./~/jade/lib/filters.js 94:13-37

Can you re-open at Stack Overflow?


When I click on the eye, <g> target fly out of the viewport

awesome project!

I use voyager in create-react-app, she is very beautiful and useful when I open her in browser. But when I clicked on the eyes, <g> disappeared, I found <g> style transform: matrix() was wrong.
can anyone help me?  this is my voyager file code.
import React from 'react'
import {Voyager} from 'graphql-voyager'
import fetch from 'isomorphic-fetch'
// import { VoyagerWrapper } from './style'

function introspectionProvider (query) {
  return fetch('http://localhost:3333/graphql', {
    method: 'post',
    headers: { 'Content-Type': 'application/json' },
    body: JSON.stringify({query: query})
  }).then(response => response.json())
}

export default function GraphqlVoyager (props) {
  return (
    <Voyager
      introspection={introspectionProvider}
      workerURI={process.env.PUBLIC_URL + '/voyager.worker.js'}
    />
  )
}

@txbo Can you please try to reproduce it using online demo: https://apis.guru/graphql-voyager/

@IvanGoncharov yep, My results are working fine here, and I tried the koa server is also pretty good. This is an example demo of recurring the problem, and css.

Yeah, somewhat if it was used as a child component that if Voyager doesn't have full control over that rendering element, the offset is completely invalidated, resulting in a huge viewport shift if you click/teleport on to something.
In other words, it looks like GQLVoyager must be used in ReactDOM.render(<Voyager ...>, document.getElementById('root')), unless we can have observable and responsive viewport.

@vshelke It looks like we fixed this issue in v1.0.0-rc.27.
I tried it on your demo but used http://swapi.apis.guru as GraphQL Server and updated all dependencies:
https://github.com/txbo/voyager-demo


Seeds are broken (because of diffusers)

Need to either submit a patch to diffusers to find a workaround

https://github.com/pcuenca/diffusers-examples/blob/main/notebooks/stable-diffusion-seeds.ipynb

Seeds are fixed


Make tbb requirement optional

As discussed in #1060, makes tbb an optional dependency that will only be installed manually, and adds a documentation section describing it.

Thank you @mithaler for an excellent contribution. 🙏

Thanks!

Cool! Can we get a release with this change? 🙏

Leland and I agreed to do a maintenance release. Might happen before the week ends.

Leland and I agreed to do a maintenance release. Might happen before the week ends.
👋
Friendly reminder that a maintenance release would be most welcome 💐

👋 Friendly reminder that a maintenance release would be most welcome 💐

Hey! We have identified some errors in unrelated tests that warrant further investigation and fixing before we go ahead with this maintenance release. I hear your pain, but if you can bear just a little while longer, our whole community will benefit. :-)

Finally, 0.5.5 has been released. Rejoice 🙆♂


Can't start a new project

🐛 Bug Report
When I try to scaffold a new project with @docusaurus/init it's giving me the following error:
Couldn't find an alternative telinit implementation to spawn.

Have you read the Contributing Guidelines on issues?
Yes
To Reproduce

Open the terminal and run npx @docusaurus/init init my-website classic

Expected behavior
The project should be created.
Actual Behavior

Your Environment

Docusaurus version used: v2.0.0-alpha.69
Environment name and version: Node v12.18.3, yarn v1.22.5
Operating system and version: WSL v2 Ubuntu-18.04

Hi,
You can't be on alpha 69 because it's not released yet 😅
Can you run npx @docusaurus/init --version ?
Are you using Docker ou Kubernetes? Your error seems related to these technologies  according to Google.

Might be related to https://github.com/facebook/docusaurus/issues/3799
Can you try npx @docusaurus/init@latest init my-website classic ?

Hi,
You can't be on alpha 69 because it's not released yet 😅
Can you run npx @docusaurus/init --version ?
Are you using Docker ou Kubernetes? Your error seems related to these technologies according to Google.

Sorry, I didn't saw the unreleased tag 😑.
Not using either.

Might be related to #3799
Can you try npx @docusaurus/init@latest init my-website classic ?

That worked for me, thanks!


[libb2] Build error for x86-android

Host Environment

OS: Fedora 36 x86_64
Compiler: Android (8075178, based on r437112b) clang version 14.0.1 (https://android.googlesource.com/toolchain/llvm-project 8671348b81b95fc603505dfc881b45103bee1731)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libb2:x86-android
./configure fails with following error:
configure:3826: /home/alexey/Android/Sdk/ndk/24.0.8215888/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -fPIC  -avoid-version -L/home/alexey/projects/tremotesf-android/libtremotesf/vcpkg_installed/x86-android/debug/lib conftest.c -latomic -lm -l-static-libstdc++ >&5
clang-14: warning: argument unused during compilation: '-avoid-version' [-Wunused-command-line-argument]
ld: error: unable to find library -l-static-libstdc++
clang-14: error: linker command failed with exit code 1 (use -v to see invocation)

I suspend that issue is caused by this: https://github.com/microsoft/vcpkg/blob/88b1071e39f13b632644d9d953738d345a4ac055/scripts/cmake/vcpkg_configure_make.cmake#L576
Vcpkg adds value VCPKG_DETECTED_CMAKE_CXX_STANDARD_LIBRARIES (which is " -static-libstdc++ -latomic -lm" in this case) to LIBS environment variable, transforming it to add "-l" prefix for each flag. However it causes compilation error because "-l-static-libstdc++" flag is invalid.

It seems that issue is gone in NDK r25 (probably because they switched back to their own toolchain instead of using CMake's builtin Android support). -static-libstdc++ now appears in VCPKG_DETECTED_RAW_CMAKE_SHARED_LINKER_FLAGS/VCPKG_DETECTED_RAW_CMAKE_EXE_LINKER_FLAGS/VCPKG_DETECTED_RAW_CMAKE_EXE_LINKER_FLAGS/VCPKG_DETECTED_CMAKE_EXE_LINKER_FLAGS_DEBUG variables instead.
Though the root issue with all_libs_list in vcpkg_configure_make.cmake remains of course.
However there is another issue with this package now: it is always built for x86_64 architecture with all android triplets.
Here is logs for arm64-android:
autoconf-arm64-android-err.log
autoconf-arm64-android-out.log
build-arm64-android-dbg-err.log
build-arm64-android-dbg-out.log
cmake-vars-arm64-android-dbg.cmake.log
config-arm64-android-dbg-config.log
config-arm64-android-dbg-err.log
config-arm64-android-dbg-out.log
get-cmake-vars-arm64-android-dbg-CMakeCache.txt.log
get-cmake-vars-arm64-android-dbg-err.log
get-cmake-vars-arm64-android-dbg-out.log
.

This issue hasn’t been updated in 1 month, if it is still an issue, please reopen this issue.


[DOCS-328] Customizable Attestation Letters

Changelog
Updated

Page
Deploy Preview
Comment

Reports
https://deploy-preview-237--cobalt-docs.netlify.app/platform-deep-dive/pentests/reports/
Customizable Attestation Letters

Glossary > Attestation Letter
https://deploy-preview-237--cobalt-docs.netlify.app/getting-started/glossary/#attestation-letter
Definition of Attestation Letter

Customize Your Pentest Report
https://deploy-preview-237--cobalt-docs.netlify.app/platform-deep-dive/pentests/reports/customize-report/
List of customizable reports + minor updates

Preview This Change
To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/
Variables
Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:
{{% asset-categories %}}
You’ve found a shortcode that we include in multiple documents.
You’ll find the content of the shortcode in the following directory:
https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes
That shortcode has the same base name as what you see in the PR, such as asset-categories.html.
Checklist for PR Author
[ ] Did you check for broken links and alt text?
Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.

Hi @yogipetkar, I updated docs to show that we allow customizing Attestation Letters. Please see a summary of changes in the Changelog above.
To distinguish between the Summary of Findings as a separate section and an overall list of findings in the Executive Summary, I use different wording. So for Attestation Letters it's "an overall list of findings."


[BUG]Network error

我知道一种方法解决网络错误，将node_modules的openai/dist/base.js中的exports.BASE_PATH改为镜像地址后可以连通，但是即使我用了全局的梯子，连原来openai的地址，就无法连通，这究竟是为啥啊，nodejs发送的请求为啥不走本地的梯子
I know a way to solve network errors, which is to change exports.BASE_PATH in openai/dist/base.js of node_modules to the mirror address, but even if I use the global ladder, even the original openai address can not be connected, why? Why don't requests sent by nodejs go to the local ladder

https://github.com/FlowiseAI/Flowise/issues/8

possibly related - #8

thank you，I know this way to solve，but I want to use vpn instead of changing url to use openai‘s api


Does it use boost?

Hi. I am considering moving my project over to this. Just curious if any of the components employ highcharts' boost functionality? Its not explicitly documented anywhere.

Hi @yniknafs, no there is no explicit use of Boost, but you can add the functionality yourself (I think) by...
import Highcharts from 'highcharts';
import Boost from 'highcharts/modules/boost.js';

Boost( Highcharts );


Improving search (pagination & filters)

What type of PR is this? (check all applicable)

[x] Refactor
[x] Feature
[ ] Bug Fix
[x] Optimization
[ ] Breaking Change
[ ] Documentation Update

Description

Add search pagination
Only use filters that exist on the current search

Related Tickets & Documents

Related Issue #
Closes #28

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[ ] No, and this is why: please replace this line with details on why tests
have not been included
[ ] I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Implementing filtering and improving ui/ux on mobile


Offcanvas multilevel  open current level

It would be nice to open the menu in the current node.

Thanks for added detail. The multi level off-canvas does not have an event handler for this. In the next version which we are working on now, we'll have better event handling for this.
You can remove this line as a work-around.
We added this to our "known issues" section in our planning board for the next version. A PR would be valuable to the community, otherwise It will be addressed then. You can see and vote on the proposed updates here: https://trello.com/b/QBPKlQqf/foundation-sites

+1 I am working on a project that needs this functionality as well.


Doesn't show list of repositories contributed to

The extension hides the Repositories you contribute to list in the sidebar of the GitHub front page. It also hides the (convenient) header from the Your repositories list with the New repository button.

That's a feature:
https://github.com/sindresorhus/refined-github/blob/2ba0840b852bebfc881b8bf50db7182287047a70/extension/content.css#L15-L18
Use Stylish to undo that feature with:
.dashboard-sidebar > .boxed-group[role="navigation"]:not(.repos) {
	display: block !important;
}

It also hides the (convenient) header from the Your repositories list with the New repository button.

It's already available from the top navbar. The + button.

It seems inconvenient to require another extension to undo feature with CSS.

@fnky Why and how do you use the "Repositories you contribute to list"? I removed it as I never used it and the below box has mostly the same information.

@fnky it is inconvenient, but that's convenient to avoid adding a hundred options:
https://github.com/sindresorhus/refined-github#contribute

@sindresorhus I use it to quickly access private repositories and those I've contributed to.
@bfred-it I understand that adding a bunch of options for everything would be undesired.

I would have agreed it was useful as I see daily other people navigating to their everyday repos from there. However, I use the Chrome omnibox so much for navigating to recent repos based on name and autocompletion that I've stopped looking at the box altogether.

Also, if the repos you constantly access are in an organisation, just use the account switcher above. Then the repo list changes to the last updated repos of the org you have selected.

Also, if the repos you constantly access are in an organisation, just use the account switcher above.

This quickly gets annoying if you work on repositories across different organisations during the day.

You no longer need an extra extension to undo this. #1193


Running from NPX is broken after latest antlr4 release

After latest antlr4 release, a fresh install from ksql-lint is broken:
npx ksql-lint
file:///Users/gerson/.npm/_npx/2f8f8ae7b291844e/node_modules/ksql-lint/lib/SqlBaseParser.js:820
const sharedContextCache = new antlr4.PredictionContextCache();
                           ^

TypeError: antlr4.PredictionContextCache is not a constructor
    at file:///Users/gerson/.npm/_npx/2f8f8ae7b291844e/node_modules/ksql-lint/lib/SqlBaseParser.js:820:28
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)

Node.js v19.6.0

After some investigation, that is due to a incompatibility between antlr4 4.10.x and 4.12.x versions. The code generated from generate.sh is using 4.10 whereas npm is fetching 4.12.
Possible fixes are bumping up antlr4 version on package.json or just rebuilding it.

Good spot, thanks for the contribution! I've merged your PR. I've also pinned the Docker image version to 4.12 to match the NPM version. A new version (1.0.1) has been published on NPM.


PLAT-7359 - Block empty comments

Jira REST API returns 400 when the comment (trim) is empty. Therefore this check must be made before sending it to Jira's API
However, we can't always trim the comment, to avoid erasing the user comment format

Codecov Report

Merging #131 into dev will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##             dev    #131   +/-   ##
=====================================
  Coverage   88.9%   88.9%
=====================================
  Files         36      36
  Lines        820     820
  Branches      88      88
=====================================
  Hits         729     729
  Misses        59      59
  Partials      32      32

Impacted Files
Coverage Δ

...s/integration/jira/services/CommonJiraService.java
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee4eb5...465911a. Read the comment docs.


Dynomadb is now read/write global

Can we use it instead of cassandra for token storage?

This seems to be a duplicate of #28. Therefore, closing and we can continue the conversation in that one.

great!
On Wed, Dec 26, 2018 at 10:58 AM Ioannis Papapanagiotou <
<EMAIL_ADDRESS>wrote:

This seems to be a duplicate of #28
https://github.com/Netflix/dynomite-manager/issues/28. Therefore,
closing and we can continue the conversation in that one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/dynomite-manager/issues/106#issuecomment-450009230,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAxN23JNKKd9AGdB3t3s1Vy1eUV_g5gOks5u88a_gaJpZM4ZgnUf
.

--
4045076749
Alex Newman


No longer runs Python scripts

Issue Type: Bug
For the third time in last two months VS code suddenly stops running Python.  The only solution seems to be a fresh install of WIndows.  Removing VS Code and reinstalling changes nothing.
VS Code version: Code 1.28.0 (431ef9da3cf88a7e164f9d33bf62695e07c6c2a9, 2018-10-05T14:58:53.203Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6800K CPU @ 3.40GHz (12 x 3400)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
63.91GB (51.75GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

anaconda-extension-pack
ms-
1.0.0

python
ms-
2018.9.0

team
ms-
1.136.0

vscode-yaml
red
0.0.17

Please report the issue against the python extension.


UIScrollView decelerationRate default should be 'normal' instead of 'fast'

Environment
React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
      Memory: 6.41 GB / 32.00 GB
      Shell: 2.7.1 - /usr/local/bin/fish
    Binaries:
      Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
      Yarn: 1.12.3 - ~/.yarn/bin/yarn
      npm: 5.6.0 - ~/.nvm/versions/node/v8.9.4/bin/npm
    SDKs:
      iOS SDK:
        Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.0/10L213o - /usr/bin/xcodebuild
    npmPackages:
      react: 16.6.3 => 16.6.3
      react-native: 0.57.7 => 0.57.7

Description
The default scrollview deceleration rate for the WebView in iOS was changed from 'fast' to 'normal' in iOS 11 (prompted by the emergence of Google AMP-powered sites which used a workaround to enable 'normal' deceleration to make scrolling feel more native), but React Native still defaults to 'fast', which is the higher-friction, less native feeling deceleration.
See UIScrollViewDecelerationRate docs and webkit changelog. More info on this history of this change: https://www.macobserver.com/analysis/apple-plans-change-scrolling-safari/
Happy to submit a PR to update this if it's a welcome change.

The new repo for webview is over here: https://github.com/react-native-community/react-native-webview

@ericlewis Thanks! I believe this is an upstream issue in the RN scrollview component. Could be wrong.


Error when using xarray where that results in zero dimensions.

Xarray 0.17.0
Executing the following code:
import xarray as xray

ncurl='http://tds.coaps.fsu.edu/thredds/dodsC/samos/data/intermediate/ZMFR/2021/ZMFR_20210303v20001.nc'
dat =xray.open_dataset(ncurl)
#dat=dat.where(dat.lat>-90.0,drop=True)
dat=dat.where(dat.lat>-11.0,drop=True)
dat=dat.where(dat.lat<30.0,drop=True)
dat=dat.where(dat.lon>91.0,drop=True)
dat=dat.where(dat.lon<139.0,drop=True)
print(dat)

Results in the error:
Traceback (most recent call last):
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/backends/netCDF4_.py", line 98, in _getitem
    array = getitem(original_array, key)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/backends/common.py", line 53, in robust_getitem
    return array[key]
  File "src/netCDF4/_netCDF4.pyx", line 4397, in netCDF4._netCDF4.Variable.__getitem__
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/netCDF4/utils.py", line 467, in _out_array_shape
    c = count[..., i].ravel()[0] # All elements should be identical.
IndexError: index 0 is out of bounds for axis 0 with size 0

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./test_xarray_error.py", line 7, in <module>
    dat=dat.where(dat.lat>-11.0,drop=True)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/common.py", line 1273, in where
    return ops.where_method(self, cond, other)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/ops.py", line 195, in where_method
    return apply_ufunc(
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/computation.py", line 1116, in apply_ufunc
    return apply_dataset_vfunc(
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/computation.py", line 428, in apply_dataset_vfunc
    result_vars = apply_dict_of_variables_vfunc(
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/computation.py", line 373, in apply_dict_of_variables_vfunc
    result_vars[name] = func(*variable_args)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/computation.py", line 628, in apply_variable_ufunc
    input_data = [
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/computation.py", line 629, in <listcomp>
    broadcast_compat_data(arg, broadcast_dims, core_dims)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/computation.py", line 542, in broadcast_compat_data
    data = variable.data
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/variable.py", line 374, in data
    return self.values
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/variable.py", line 554, in values
    return _as_array_or_item(self._data)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/variable.py", line 287, in _as_array_or_item
    data = np.asarray(data)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/numpy/core/_asarray.py", line 102, in asarray
    return array(a, dtype, copy=False, order=order)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/indexing.py", line 693, in __array__
    self._ensure_cached()
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/indexing.py", line 690, in _ensure_cached
    self.array = NumpyIndexingAdapter(np.asarray(self.array))
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/numpy/core/_asarray.py", line 102, in asarray
    return array(a, dtype, copy=False, order=order)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/indexing.py", line 663, in __array__
    return np.asarray(self.array, dtype=dtype)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/numpy/core/_asarray.py", line 102, in asarray
    return array(a, dtype, copy=False, order=order)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/indexing.py", line 568, in __array__
    return np.asarray(array[self.key], dtype=None)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/coding/strings.py", line 236, in __getitem__
    return _numpy_char_to_bytes(self.array[key])
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/coding/strings.py", line 193, in _numpy_char_to_bytes
    arr = np.array(arr, copy=False, order="C")
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/indexing.py", line 568, in __array__
    return np.asarray(array[self.key], dtype=None)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/backends/netCDF4_.py", line 85, in __getitem__
    return indexing.explicit_indexing_adapter(
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/core/indexing.py", line 853, in explicit_indexing_adapter
    result = raw_indexing_method(raw_key.tuple)
  File "/home/hunter/miniconda3/lib/python3.8/site-packages/xarray/backends/netCDF4_.py", line 108, in _getitem
    raise IndexError(msg)
IndexError: The indexing operation you are attempting to perform is not valid on netCDF4.Variable object. Try loading your data into memory first by calling .load().

It seems to be related to the fact that:
dat=dat.where(dat.lat>-11.0,drop=True)
results in a zero dimension (time).
However, if I uncomment one line and run:
import xarray as xray

ncurl='http://tds.coaps.fsu.edu/thredds/dodsC/samos/data/intermediate/ZMFR/2021/ZMFR_20210303v20001.nc'
dat =xray.open_dataset(ncurl)
dat=dat.where(dat.lat>-90.0,drop=True)
dat=dat.where(dat.lat>-11.0,drop=True)
dat=dat.where(dat.lat<30.0,drop=True)
dat=dat.where(dat.lon>91.0,drop=True)
dat=dat.where(dat.lon<139.0,drop=True)
print(dat)

There is no error, even though the line with dat=dat.where(dat.lat>-11.0,drop=True) still results in a zero dimension.
Perhaps this is not a bug, but maybe I am misunderstanding how where() works in xarray. But it seems inconsistent.
Eli Hunter
Rutgers University

Hi @imcslatte  — after following the suggestion to call .load(), the example works for me.
If that's not sufficient — e.g. it's a lot of data — please could you fill out the issue template?

Similar to  #4524

Hi @max-sixty Yep, that worked fine. Should have paid more attention to the error message I suppose.
Thanks,

Thanks @imcslatte please reopen if your issue is unresolved.


[Feature Request] GitHub Actions Output

Hi, there! Gitify seems cool, but it would be nice to be able to see GitHub actions outputs/runs for my repos in the menu bar as well. Right now, I use hukum to do this. But it would be nice to have this in the menu bar instead of a CLI.

Try my app

@ospfranco please remove color from the menu bar icon

Thanks for raising this @karimsa.
Unfortunately, due to the current limitations of the GitHub Public APIs, it's not feasible for us to find a workflow run based on the notification alone.
As these limitations are relaxed, we'll be sure to include the new features into Gitify.  For now, I'm going to close as not planned

I think you are mistaken @setchy. I built a Menu Bar app that could get access to CI steps some years ago.
https://github.com/ospfranco/cidemon


Added robotListView option for columns

Adds "Robot Results" summary in List View

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests