Use SensitiveParameter class

In PHP now you can mark parameters as Sensitive, which prevents them from being logged. This is good practice with things such as passwords and 2FA secrets.
I would suggest using this any time the 2FA Secret is passed to a function as a  parameter, such as in TwoFactorAuth->getQRCodeImageAsDataUri()
https://www.php.net/manual/en/class.sensitiveparameter.php

So:
public function getQRCodeImageAsDataUri(string $label, #[\SensitiveParameter] string $secret, int $size = 200): string

good idea, would you like to make a PR?

Note that this is only available in PHP 8.2. I'm not sure it's worth adding while we still support 8.1. It seems to be harmless, but might have side effects in static analysis for instance. Otherwise I'm all for it, of course!
PHP 8.1 end of security support is in 7 months, active support ended 4 months ago, so we could even go forward and require 8.2 along with this change. Users of PHP 8.1 will simply not update this library, and should already start planning upgrading their PHP version.

so this might have to thoroughly get stuck on the back burner

Given the stable state of this library (we don't commit bugfixes every day), going with it earlier is no issue. I've recently (6 hours ago) upgraded my app to use PHP 8.3, so I would benefit from this change. Users stuck on 8.1 will simply continue using the current version, until they upgrade, and then they'll already have a fresh version with this change waiting for them!

Users stuck on 8.1 will simply continue using the current version

But if we change/fix something they will be forced to upgrade first before they can use the newer version, right? And since 8.1 might get another year of support I guess we have to consider if the attribute is worth  it.
Having said that it does look like a cool feature.  And should any issues arise we can always backport to the attribute-less version, right?

they will be forced to upgrade first before they can use the newer version, right?

No. We'll emit a bugfix on the 8.1 supported branch.

That's what I meant with "And should any issues arise we can always backport to the attribute-less version, right?"

PR opened #119

Yeah we'd probably forget to close when v3 is actually released


"Attempt to read property "expiresIn" on null" i am getting this error

@Thanzeer22 can you put some more details and stack trace from which file error is originated and in which operation you are getting this error?

i am getting this error when i am calling API . sir i am new to this can u give me some demo code please

@Thanzeer22 I think there was a typo in docs here: https://github.com/InfyOmLabs/laravel-envato#load-auth-session
Try with an updated doc and it should work.


Document job service in compact architecture

Create a README.md explaining how job service work.

https://github.com/apache/incubator-kie-kogito-apps/pull/2001


[GSoC Project Proposal]: Take ocean auto-reporting to the cloud

Project Description
With the rapid increase in collection and dissemination of ocean data the use of automated data processing and reporting is gaining popularity. Reports are currently generated manually and locally, however to create fully automated reports the use of cloud services is required. The intern will work on migrating and adapting existing python code used for data reporting, so that reports are generated automatically when new oceanographic data sets are added to the repository.
Expected Outcomes
Migration of oceanographic data set auto-reporting scripts to the cloud, and automatic report creation. The intern will gain knowledge in python, cloud services, and various ocean data sets.
Skills required
Python, Git
Mentor(s)
@mphemming, @moninya
Expected Project Size
175
What is the difficulty of the project?
Intermediate

@mphemming Thank you for your project idea contribution to IOOS' GSoC application.
Unfortunately, GSoC is targeted towards existing open source software projects that have an established code base and active developer community, rather than ideas for new projects or packages.  More information about this can be found in this public GSoC slide deck that describes the expectations for organizations looking to apply.
I'd recommend getting this project idea going on your own and consider re-submitting it next year once there is a public code base available.

Perhaps this idea can be modified to use existing tools like quarto + github actions? That stack is how our best Marinebon reports are made.

thanks for the suggestion. We have already created a python package using LaTeX, so will investigate whether we can use github actions with the existing code.


Add links to social media on contact page

As we have them, might as well flaunt them?
twitter
bluesky
YouTube

please do

as above


Force to close FIFO buffers instead of waiting for garbage collector

Bump to 2.1.3

Pull Request Test Coverage Report for Build 255

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 99.503%

Totals

Change from base Build 251:
0.003%

Covered Lines:
1002

Relevant Lines:
1007

💛  - Coveralls

Pull Request Test Coverage Report for Build 255

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 99.503%

Totals

Change from base Build 251:
0.003%

Covered Lines:
1002

Relevant Lines:
1007

💛  - Coveralls

Pull Request Test Coverage Report for Build 255

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 99.503%

Totals

Change from base Build 251:
0.003%

Covered Lines:
1002

Relevant Lines:
1007

💛  - Coveralls

Pull Request Test Coverage Report for Build 255

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 99.503%

Totals

Change from base Build 251:
0.003%

Covered Lines:
1002

Relevant Lines:
1007

💛  - Coveralls

Pull Request Test Coverage Report for Build 255

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 99.503%

Totals

Change from base Build 251:
0.003%

Covered Lines:
1002

Relevant Lines:
1007

💛  - Coveralls


Enable Hive impersonation as default

Enable impersonation (hive.server2.enable.doas = true) to facilitate access to external tables (without having to rely on multiple ranger policies).
Reasons to favor external tables:
- Convenient to organize data
- Convenient to apply access rights (less ranger policies)
- With the appearance of new table-formats, like Iceberg, Delta and Hudi,  HIve ACID has lost footing as a reason for favoring managed tables.
With this change, managed tables will also be accessible to users by simply adding ranger access to /warehouse/tablespace/external/hive in hdfs.
On the other-side, if components like Sentry were added this change would become unnecessary.
Cheers,

This parameter hive.server2.enable.doas is by default set to true=> impersonation is by default enabled in TDP
You can use beeline_auto from edge and check user via yarn-ui

You are right. Closing and moving the changes to  getting-started as they are declared to false there. Thanks


Fixing ability to override max ttl

Prior this would fail because we didnt set max ttl for vault temp. This would cause vault temp to fail to start since default ttl would be greater than max ttl.

ci check this


Github release does not include dist/ files

Spin off from discussion https://github.com/Leaflet/Leaflet/discussions/8491 .
Expected behavior
The github release for 1.8.0 has a .zip file containing the dist/ files (the rolled-up leaflet-src.js, etc):

Current behavior
The 1.9.x release does not:

...and thus is confusing some users.

I recall some (old) release instructions that included branching and tagging for the release - and including the dist/ files in that git branch+tag. Unfortunately my memory of that is a bit vague.
Not sure if we want to follow that model, or if we want to amend the release instructions to add the "put a .zip in the github release" instead.

@mourner @jonkoops

We never had any automation to upload these artifacts, I believe that @mourner added these manually. These artifacts are exactly the same as the ones uploaded to the site.
I've uploaded the files for the latest releases, which should avoid confusion for now. That said, I think we should stop doing this for the 2.0+ releases.

If anyone can update the release instructions with this extra step, I think we can then close this issue.

That said, I think we should stop doing this for the 2.0+ releases.

What are the contra of adding it to the release, so that we don't want this anymore?
In my eyes the pros are:

Each Github Release has any information which is needed to work with the release. The build files and the source files of the project
Users are still using it for importing. (Is this bad practice?)

What are the contra of adding it to the release, so that we don't want this anymore?

It's a manual step that duplicates something that already exists on the website.

Users are still using it for importing. (Is this bad practice?)

If that works for them that's fine, even if there are better methods available.


Fix benchmark level discrepancy reported in messages.

Here are some facts about this issue:

The messages that are selected are correct.
The issue is that the value for goal benchmark  is shown instead of the value of the top 10% or peer average benchmarks in some messages
The issue was there since the start of the trial
It might not happen for all cases because of the nature of the problem
It might not be noticeable if the value of the goal benchmark is still higher than the performer's value which in most cases is

The issue assises from having multiple labels for some URIs in the Graph.
The graph has 4 comparators like the following
{
"@id": "http://purl.obolibrary.org/obo/PSDO_0000129",
"@type": [
"http://purl.obolibrary.org/obo/PSDO_0000093",
"http://purl.obolibrary.org/obo/PSDO_0000095"
],
"http://www.w3.org/2000/01/rdf-schema#label": [
{
"@value": "Peer Top 10%"
}
]
}
But we also have labels for is_abouts in message templates like the following
{
"@id": "http://purl.obolibrary.org/obo/PSDO_0000129",
"rdfs:label": "peer 90th percentile benchmark"
}
Therefore we have multiple labels defined for the same IRI http://purl.obolibrary.org/obo/PSDO_0000129 in the graph and when we query for the labels of this IRI one of these multiple labels seem to be selected randomly so we may get "peer 90th percentile benchmark "or "Peer Top 10%" as the label of it. Consequently, Pictoralist gets confused and instead of using the right comparator value in the message and image it uses the goal comparator value which is the last one.
Potential solution:
A possible solution is to remove the is_about labels which needs a complete check of the code to see if that does not affect anywhere else.
Another alternative solution could be to use the same labels like "Peer Top 10%" or "Peer Average" in the message templates as well.

Here is an input example
{
  "message_instance_id": "ce50241e-b28c-405a-8a46-15df4e6f2e78",
  "performance_month": "2024-05-01",
  "Performance_data": [
    ["staff_number","measure","month","passed_count","flagged_count","denominator","peer_average_comparator","peer_75th_percentile_benchmark","peer_90th_percentile_benchmark","MPOG_goal"],
    [1,"GLU11","2023-06-01",1,0,1,50.9,100.0,100.0,90.0],
    [1,"GLU11","2024-05-01",92.3,1,100,90.0,100.0,100.0,91.0]
  ],
  "History": {},
  "Preferences": {}
}

and  the candidates generated are
"candidates": [        ["staff_number","measure","score","motivating_score","history_score","preference_score","coachiness_score","name","acceptable_by","selected"],
[1, "GLU11","2.34","0.077","1.0","0.20322977528179223","1.0","Not Top Performer","Social Worse",true],
[1,"GLU11","2.34","0.077","1.0","0.20322977528179223","1.0","Opportunity to Improve Top 10 Peer Benchmark","Social Worse",false]
    ]

Here is the wrong message:
"You are not a top performer this month for the measure GLU-11: Hyperglycemia Treatment, Periop (>180 mg/dL). Your performance was 92.3% (92.3/100.0 cases) and the top 10% peer benchmark was 91.0%."

Here is another example
{
  "message_instance_id": "ce50241e-b28c-405a-8a46-15df4e6f2e78",
  "performance_month": "2024-07-01",
  "Performance_data": [
    ["staff_number","measure","month","passed_count","flagged_count","denominator","peer_average_comparator","peer_75th_percentile_benchmark","peer_90th_percentile_benchmark","MPOG_goal"],
[12, "SUS02", "2024-04-01", 25, 10, 35, 65.2, 81.4, 92.1, 90.0],
[12, "SUS02", "2024-05-01", 41, 7, 48, 66.7, 81.9, 90.9, 90.0],
[12, "SUS02", "2024-06-01", 29, 7, 36, 68.1, 83.3, 92.3, 90.0],
[12, "SUS02", "2024-07-01", 13, 9, 22, 64.7, 80.6, 89.5, 90.0]
  ],
  "History": {},
  "Preferences": {}
}

the selected candidate was
[12,"SUS02","3.36","0.20156000000000002","1.0","0.888476944451279","1.0","Drop Below Peer Average","Social Loss",true]

and the output message (should be "...and the peer average was 64.7%.")
"message": {
        "text_message": "Your performance dropped below the peer average this month for the measure SUS-02: Global Warming Footprint, Maintenance. Your performance was 59.1% (13/22 cases) and the peer average was 90.0%."
}


please consider making Shift-R a QWERKEY

I have a hard time hitting the left side QWERK modified keys because
of not having a QWERKEY modifier key on the right side.
Since I have moved "?" to the "]" labelled key, having "?" on the Right-"Shift" labelled key is a bit redundant,
so instead I use it as a QWERKEY modifier.
I am attaching a script called rightShiftIsQwerkeyModifier.txt along with a cheatsheet called
qrk-right-and-left.png that does this:
rightShiftIsQwerkeyModifier.txt

Please note that it may be necessary to run a webbrowser in the background if this script makes the modifiers keys require double presses, as explained in my comments to Issue #1.

I configured xmonad in a way that is very close to the default config, but works well with QWERKEY, because it only binds a few keys (right-ALT, control-. and control-/.
I am attaching my xmonad.hs (but i had to rename it to xmonad.hs.txt to attach it,
you should rename it back if you want to try it out) and a cheatsheet.
xmonad.hs.txt


contiguous time axis

What is your issue?
I have a dataset I created using xarray.  When I am using netcdf-java to read the time axis, I am getting edges that aren't the same values as the time axis coordinates.
The xarray-developed dataset looks like:

From netcdf-java I see the CoordinateAxis1DTime axis with the following attributes:

The edge array is offset by -0.5 days.  After a little digging through the java docs, I found the CoordinateAxis1DTime.edge array will only be the same as the CoordinateAxis1DTime.coords array when the ContiniousAxis1DTime.isContiguous() evaluates as True.  But the java docs indicate:

How can I write a netcdf file using xarray where the time axis would be considered contiguous?

@ethanrd @haileyajohnson @tdrwenski any thoughts on the above question?

If cell bounds/edges are not provided with a coordinate variable, the coordinate values are assumed to represent the center points of a set of contiguous cells. In this default case, the cell edges can be represented as an (n+1) sized array with all but the first and last values shared between neighboring cells. In the non-contiguous case, the bounds/edges must be represented as an (n,2) sized array.
Looks like there's already an xarray issue (#1475 ) on handling cell bounds.

So, I believe the results you are seeing above are the expected results with the edge value half way between neighboring coordinate values.

Thanks @dopplershift and @ethanrd . It seems like it's interpreting the absence of an attribute (!).

Hey!
Thanks for the thoughts.  Took me a wile to realize the edge array and the time coordinates aren't the same thing.  The time coordinates are really labels and the edge array is calculated from it.
Not sure I agree with the default calculation as the mid point of the time coordinate labels, but I think that is a battle I won't take up.
+1 for supporting this kind of coordinate attribute in xarray.  Based on the other issues linked here, it seems it still has not been implemented?


build: bump Angular to 15

What this PR changes/adds
Bump angular to version 15
Why it does that
dependency update
Further notes

had to adapt some css here and there, there could be other outdated stuff we're using, but the layout is pretty stable now.

Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

I cant build the docker images with the docker compose command.
Error:
25.49 Error: bundle initial exceeded maximum budget. Budget 1.20 MB was not met by 142.00 kB with a total of 1.34 MB.
Solution should be to set up the budget Values in the angular.json file. Reference https://stackoverflow.com/questions/53995948/warning-in-budgets-maximum-exceeded-for-initial
Current ErrorBudget is set to 1.2 MB.

@janpmeyer fixed, I also took the opportunity to add the first e2e with cypress, for the moment it just verifies that the test environment spins up correctly.

@janpmeyer removed the underline from the menu


Abstract API calls into separate services

Summary of changes
Asana Ticket: Abstract API calls into separate services
Create a new folder for AWS location service specific implementation. Rename files and env variables to specify source of geocode, map data, etc.

I added a tiny commit so that it'll compile, and I'm going to deploy it to dev-green to confirm it works as expected in the prod Mix environment. Nice work!! I will add a proper review shortly.


Participate in polls

Polls! https://github.com/snarfed/bridgy-fed/issues/395 is for just rendering them; the next step would be to let people actually post and vote in them.
Sadly, as of 9/2023, they're mostly incomplete across Bridgy Fed's protocols:

ActivityPub: done, pretty commonly used; example poll
IndieWeb: incomplete, not much ongoing development
Bluesky: not yet designed
Nostr: NIP-69 isn't yet in the main NIPs repo, depends on zaps 🫤, very little adoption

Filed this just in time, looks like we're already receiving Updates for poll votes that are spamming webmentions. Original report in https://github.com/snarfed/bridgy/issues/1550. Here's an example activity from mastodon.social, below. It seems fine.
The problem is probably that the Update id has a fragment in it, which we include that in our webmention source URL, https://ap.brid.gy/convert/web/https:/mastodon.social/users/Edent/statuses/111069219037380638%23updates/1694783012 . The mf2 correctly has u-url set to the reply post itself, https:/mastodon.social/users/Edent/statuses/111069219037380638 , but I'm guessing most wm receivers don't de-dupe aggressively enough to use u-url as a key instead of source URL. Hrm. cc @dshanske
{
  "@context": "...",
  "id": "https://mastodon.social/users/Edent/statuses/111069219037380638#updates/1694782685",
  "type": "Update",
  "actor": "https://mastodon.social/users/Edent",
  "to": [
    "https://www.w3.org/ns/activitystreams#Public"
  ],
  "object": {
    "id": "https://mastodon.social/users/Edent/statuses/111069219037380638",
    "type": "Question",
    "summary": null,
    "inReplyTo": "https://shkspr.mobi/blog/2023/09/using-selenium-chrome-to-automatically-download-blob-files/",
    "published": "2023-09-15T12:43:04Z",
    "url": "https://mastodon.social/@Edent/111069219037380638",
    "attributedTo": "https://mastodon.social/users/Edent",
    "to": [
      "https://www.w3.org/ns/activitystreams#Public"
    ],
    "cc": [
      "https://mastodon.social/users/Edent/followers"
    ],
    "sensitive": false,
    "atomUri": "https://mastodon.social/users/Edent/statuses/111069219037380638",
    "inReplyToAtomUri": "https://shkspr.mobi/blog/2023/09/using-selenium-chrome-to-automatically-download-blob-files/",
    "conversation": "tag:mastodon.social,2023-09-15:objectId=536321548:objectType=Conversation",
    "content": "
Can you see this post?
If so, can you see the post it is in reply to?
",
    "contentMap": {
      "en": "
Can you see this post?
If so, can you see the post it is in reply to?
"
    },
    "endTime": "2023-09-22T12:43:04Z",
    "votersCount": 6,
    "attachment": [],
    "tag": [],
    "replies": {
      "id": "https://mastodon.social/users/Edent/statuses/111069219037380638/replies",
      "type": "Collection",
      "first": {
        "type": "CollectionPage",
        "next": "https://mastodon.social/users/Edent/statuses/111069219037380638/replies?only_other_accounts=true&page=true",
        "partOf": "https://mastodon.social/users/Edent/statuses/111069219037380638/replies",
        "items": []
      }
    },
    "oneOf": [
      {
        "type": "Note",
        "name": "I see this post and what it is replying to.",
        "replies": {
          "type": "Collection",
          "totalItems": 6
        }
      },
      {
        "type": "Note",
        "name": "I see this post, but not what it is in reply to.",
        "replies": {
          "type": "Collection",
          "totalItems": 0
        }
      },
      {
        "type": "Note",
        "name": "I cannot see this post \ud83d\ude43",
        "replies": {
          "type": "Collection",
          "totalItems": 0
        }
      }
    ]
  }
}


project is broken: novena-sd.data directory is not present in repo

the novena-sd.data/ directory appears to have been excluded from this repo, so trying to open the project in PlanAhead just returns a "ERROR: [Common 17-70] Application Exception: Missing default src set in load ProjectHDMgr" error.

added fileset.xml


Custom/Stakeholder role

Adding a custom and/or stakeholder role to tags for easy external access.

I think this is best up to those using the tags to add into their solution according to their business needs. Even if useful for some, we add complexity that might not be wanted by others.


simplified generation of LINQ Expression for AutoFilter

@denis-tsv this branch is subject to change soon. Please wait until we deploy a new version. We don't support external pull-requests yet.


a new theme

It's already pass the unit test.

@yunfeihe The website http://yunfeihe.me seems to be  no longer available. See https://github.com/hexojs/site/issues/1844


Some way of making entities wet (fscript or command)

.... you want a way to make entities perma / coditionally wet? why?

Well it could be useful, but to be honest it needs tridents to be usable while wet to be useful for my server. So at the moment I don't really need it. Maybe it confuses you why i opened the issues in this order and not in reverse and to be honest i'm not sure why I did it.
To answer your question: there is a special (unique item) trident in my server that i wanted to be able to be used anywhere, because it is supposed to keep you "watery". I had this design before i started using fabrication, but it was just aesthetic.

The ordering doesn't confuse me as much as openening this issue after the first one was rejected. as i understand it you're requesting a feature that you won't use...
(p.s. i think you're the 1st person to directly request fscript in a fabrication issue, so neat to see it's getting use (i assume))

Yeah lol when i opened this I didn't notice you rejected the other, sorry for the confusion, I was playing and talking with friends while making the issues


Add coverage generation to Makefile.ius

This adds the following arguments to EXTRA_ARGS in Makefile.ius when COVERAGE=1 is set.

-coverage ALL: generate all types of code coverage data.
-covoverwrite: overwrite coverage data from previous runs.

Currently it looks like setting COVERAGE=1 in Makefile.aldec will generate coverage data. This commit adds similar functionality for Cadence users.

Failure seems to be unrelated:
$ if [ $( python -c "from __future__ import print_function; import sys; print(sys.version_info.major)") -eq 3 ]; then ln -s /opt/python/3.4.4/bin/python3.4-config /home/travis/virtualenv/python3.4/bin/python-config; fi
ln: failed to create symbolic link ‘/home/travis/virtualenv/python3.4/bin/python-config’: File exists

this change should get the travis python3 tests to run: https://github.com/potentialventures/cocotb/pull/576/commits/6c4320ee732b2af11faee17de57b9f40a4a5662c

Should all those parameters be controlled from a rather local makefile?

Should all those parameters be controlled from a rather local makefile?

As opposed to being in the main cocotb makefiles, you mean? Yes, perhaps.
I think I decided to open this pull request because, after adding coverage support to my Makefile, I realized the COVERAGE environment variable already did something in cocotb, and that Makefile.aldec respected it. It seemed weird that this was only used in one simulator. But thinking more about it, I'm not sure this is something cocotb needs to know how to do by itself.
I do wonder if it would be nice to have a cocotb extension (not something in the "cocotb core" project) that knows how to use a tool like pyucis to parse the output of coverage data from all the major simulators. But I had a lot of trouble trying to use pyucis to read coverage data from Cadence... so I ended up just using the standard Cadence tools instead.

I think it is better to keep this in local (project) makefile and remove COVERAGE control from cocotb at this point.

As just written in #682, I'm also for a removal, and
"We could still have example Makefiles showing how do extend the *_ARGS variables for the single simulators as a starting point for the user."

Yeah, I think this makes sense. I'll close this then. :)


download_strategy: remove redundant conditional

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

https://github.com/Homebrew/brew/pull/12172#pullrequestreview-770504656

Review period skipped due to critical label.


⚠ Bofrost.de has degraded performance

In 6da6b57, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1592 ms

Resolved: Bofrost.de performance has improved in c3b7fd0 after 6 minutes.


Issue in sending context path in influxDB URL

Hi,
Our influxDB is hosted with a context path as an example [platform.cloud.abc.net/influxdb2], as per the current implementation setting context path to the influxDB URL is not supported. As currently this is a blocker we are ready to implement a solution but after an analysis identified following different approaches that can be used;

Separate the context path from influxDBHost parameter and build the URL accordingly
Provide the option to send the full influxDB URL through one parameter
Add a separate parameter to send the context path

I would like to know the preferred solution from above approaches or any other suggestions to overcome this issue, and would like to contribute to the plugin based on preferred approach.
Thanks

Hello, @MalshaUdani,
Option 2. is a good thing.
BR,
Mike

Thanks @mderevyankoaqa,
With the new approach there will be one field to enter influxDB URL as below,

Thanks @mderevyankoaqa,
With the new approach there will be one field to enter influxDB URL as below,

@MalshaUdani looks good, I think we can take this improvement and make the new release once PR is merged.
BR,
Mike


Azure details kebab "All accounts" option

Fix missing i18n key for Azure details kebab "All accounts" option
Fixes https://github.com/project-koku/koku-ui/issues/1110

Codecov Report

Merging #1154 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1154   +/-   ##
=======================================
  Coverage   75.24%   75.24%
=======================================
  Files         228      228
  Lines        4408     4408
  Branches      833      833
=======================================
  Hits         3317     3317
  Misses        973      973
  Partials      118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe7a7f...fb36c00. Read the comment docs.


feat: use flag library instead of custom flag parser

Can be used to extend further as well, I am thinking of also adding custom shell flag so we can use zsh for example by passing a flag.

Hey, thanks for the review, will push the changes in a while.

As to a custom flag for a replacement shell, it's totally something I'm interested in. Just not exactly sure how to design the interface, especially to take the final shebang into account. Please see #2 for some initial discussion; would you care to jump in with some thoughts and ideas?

@akavel I've pushed the changes.
I'll create another PR for the AUTHORS file as it does not exist as of now.
Also, will read #2 and jump in.
Thanks :smile:

Thanks for your contribution!

@akavel :+1:


Error installing lgi via luarocks

Hi I get this while trying to install:
luarocks install lgi
Installing https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/lgi-0.9.2-1.src.rock...
Using https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/lgi-0.9.2-1.src.rock... switching to 'build' mode
make -C lgi
make[1]: Entering directory '/tmp/luarocks_lgi-0.9.2-1-9083/lgi/lgi'
pkg-config --exists 'gobject-introspection-1.0 >= 0.10.8' --print-errors
Package gobject-introspection-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gobject-introspection-1.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gobject-introspection-1.0' found
Makefile:53: recipe for target '.depcheck' failed
make[1]: *** [.depcheck] Error 1
make[1]: Leaving directory '/tmp/luarocks_lgi-0.9.2-1-9083/lgi/lgi'
Makefile:16: recipe for target 'all' failed
make: *** [all] Error 2

Package gobject-introspection-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gobject-introspection-1.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gobject-introspection-1.0' found

So, what do you now expect from me that this error message does not already tell you? You do not have the development files for gobject-introspection installed. When pkg-config --modversion gobject-introspection-1.0 starts to work, compiling lgi will also start to work.


[WIP] Cypress test. Collapse sidebar/apperance.

Cypress test. Collapse sidebar/apperance.
Add cssSelector for element.
Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

This test will fail on new AntDesing version in branch upstream/bs/antd4_migration due to background does not  fitted when hide sidebar.

Coverage increased (+0.04%) to 61.833% when pulling bcae6493e7430414102c3b233e1e34c85db6275f on DmitriyOparin:upstream/do/cypress_test_case_30_collapse_sidebar_apperance into 473d69991cf800ec1141dac18ee718dce3225fd7 on openvinotoolkit:develop.

@DmitriyOparin Please recheck the test for the current develop branch.

@bsekachev
Test failed for the current develop branch due to background is not fitted when hide sidebar.
Is bug or feature? Should remake test?

@DmitriyOparin
Probably is is a bug, let me look into the issue.

Fixed in #2561

Fine. I will recheck this test on bs/some_fixes branch and will talk results.

Test is pass on bs/some_fixes branch. I will wait when fix will be in develop branch.

Test is sucsess on develop branch.


🤖 Update one or more manifest files in the .ci directory

This includes:

https://github.com/JuliaRegistries/General/pull/85286


WIP: SPI_4 and SPI_5 definitions

Missing SPI definitions on STM32 common drivers. See issue #2385

@rafacouto is this PR still in work in progress state?

@rafacouto is this PR still in work in progress state?

I've tested that prebuilt macros are generated but I couldn't check if SPIs are operatives. Please, give me some more days to do a full test on board. I'll post the results in this thread.

Hi @rafacouto changes were good, I tested it and since commit message was also nice I though that little WIP in PR name will not be a problem. Thanks for you contribution.


Offer default constructors for Jackson serialization

Please offer default constructors, setting data to null, so that TreeNode's can be JSON serialized with Jackson.

Sure. Let you know once done


Unable to install on Ubuntu 20.04

Is it possible to install the SDK on Ubuntu 20.04?
I did not find any guideline on  how to do it, so I tried using the guides for Ubuntu 16.04 / 18.04:
sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys CE7709D068DB5E88
sudo add-apt-repository "deb https://repo.sovrin.org/sdk/deb (xenial|bionic) {release channel}"
sudo apt-get update
sudo apt-get install -y libindy

I am getting the following error:
The following packages have unmet dependencies:
 libindy : Depends: libsodium18 but it is not installable
           Depends: libssl1.0.0 but it is not installable
E: Unable to correct problems, you have held broken packages.

This (Dockerfile) works, and installs the indy-sdk on  Ubuntu 20.04:
FROM ubuntu:20.04
RUN apt-get update -y && apt-get install -y \
    gnupg \
    ca-certificates

RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys CE7709D068DB5E88
RUN echo "deb https://repo.sovrin.org/sdk/deb bionic stable" >> /etc/apt/sources.list
RUN apt-get update -y && apt-get install -y \
    libindy

Hello @WadeBarnes.
Thanks for the reply. This does does install libindy correctly.
The problem I was having was due to incorrect APT data sources in /etc/apt/sources.list pointing to a source specific for the xenial distribution.

Great.  If your issue is resolved please close the issue.  Thanks


Saving changes to a FEED causes the filters in the data browser to be cleared

To reproduce:
create a feed
go to data browser
change filter (add something like Status = "Deleted")
go to settings, change feed stats to reject, then save
data browser will have dropped the previous filters

Fixed in v6.0-beta.12


Callback not firing

Hi, I am currently trying to use this Strategy with next-auth. I logged an issue on next-auth because the callback didn't seem to be firing for keycloak-passport. Wondering would you maybe have any insight on why it wouldn't be firing?

Hi @garmeeh, I just read through the issue that you posted in next-auth. I'm not familiar with that project directly, however, I vaguely remember dealing with the req argument issue when I was building keycloak-passport... You can get a sample of how we implement the strategy over here
We use the signature req, accessToken, refreshToken, profile, done which requires this line in the config https://github.com/exlskills/auth-server/blob/master/src/config/index.js#L23. Although as discussed in the next-auth issue, it seems as though you're also setting that...
Beyond that, I'm not exactly certain what the cleanest solution is, given that this is largely handled by the oauth2 boilerplate.

No worries @svarlamov, thanks for the looking into it for me. The auth server is great for reference 👍

Sure, let me know if there's anything that I can do in the mainline keycloak-passport to support next-auth. Would be happy to do that as I'm sure it would benefit other users

@garmeeh Where you able to find the solution to this issue? Also, any luck re: #2 ? Thanks!

Hi @svarlamov sorry about the delay in replying.
I'm working with @woppers to try resolve #2.
In regards to my original issue, the only chagne we had to make to keycloak-passport was to change this line
this.name = 'Keycloak';

to
this.name = 'keycloak';

I'm pretty sure this is something we could open a PR for on next-auth to add an option to not .toLowerCase() the provider name option. If we get the flow working I will add comment back here for anyone finding the issue later. I would be happy to consider this issue closed if that suits you.

I see... I'm concerned that mainlining a name change might break other implementations. Is there a particular reason why it needs to be lowercase for next auth?

I agree, making that change would probably break other implementations. I am not sure if there was a particular reason for the lowercase, but I would hope that I could open a PR for next-auth and add an option to disable the lowercase.

@svarlamov seems they pick a strategy by name and they get it from url /auth/oauth/<strategyName>
not sure why they need .toLowerCase() though...

@aol-nnov Thanks for clarifying the use case in next-auth. I'm not sure what specifically I can add here, but if we get clarity on the requirements for compatibility with next-auth I would be happy to mainline the changes so long as they don't break other impls

So, I browsed a handful of strategies, all of them have their name in lower case. Seems like a policy to me..
https://github.com/jaredhanson/passport-local/blob/master/lib/strategy.js#L53
https://github.com/jaredhanson/passport-openid/blob/master/lib/passport-openid/strategy.js#L78
https://github.com/jaredhanson/passport-browserid/blob/master/lib/strategy.js#L52
https://github.com/jaredhanson/passport-facebook/blob/master/lib/strategy.js#L55
https://github.com/jaredhanson/passport-google/blob/master/lib/passport-google/strategy.js#L47
https://github.com/jaredhanson/passport-twitter/blob/master/lib/strategy.js#L54
https://github.com/AzureAD/passport-azure-ad/blob/dev/lib/oidcstrategy.js#L334
https://github.com/jaredhanson/passport-http-bearer/blob/master/lib/strategy.js#L65
https://github.com/auth0/passport-auth0/blob/master/lib/index.js#L55
For the sake of brevity I won't paste all 480 policies here, lol!

Anyway, I've opened a PR on that, because no rules enforcing strategy name to be lower case were found.
https://github.com/iaincollins/next-auth/pull/51


tensorflow-gpu version

What version of tensorflow-gpu version was used?

Sorry, My bad. It in the Readme.md


[INFINITY-1370] Download cli once and only once in test.sh & test.py

This is essentially a step towards cleaning up how temp dirs and the dcos cli are managed across test runs.
Here we have one working dir for the whole run, and download the cli once (though it's copied a few times).
It's not exciting alone, but it felt like a necessary preamble to gathering diagnostics on test failure; since we have to do that in test.py  (or test.sh) to make it make sense, which means we need the dcos cli ensured available at that level (the alternative is to just increase the undesirable action pile in CI).

Totally unrelated build failure; merged master and retesting.

cli_install is quite new, so no real traditions there.  we could readily require 'python cli_install' for direct invocation.  I felt that the idea of "a script that fetches the right cli" had legitimate utility standalone, which is why i added the invocation interface.


Revert "Adding depth=1 in the git clone options"

Reverts litmuschaos/litmus#3776

We should only clone a single branch to reduce unnecessary data being downloaded. This clone option should force only the required branch data to be cloned :
SingleBranch:  true,

@AmitKumarDas - Will it work with the git pull in go-git?

We should only clone a single branch to reduce unnecessary data being downloaded. This clone option should force only the required branch data to be cloned :
SingleBranch:  true,

@amityt - Will it work with the git pull in go-git?

It already works and is tested. I did the same with gitops feature ref: https://github.com/litmuschaos/litmus/blob/45693e9b31804a8d6dc3adb4020c57399fe16499/litmus-portal/graphql-server/pkg/gitops/gitops.go#L178

@imrajdas LGTM, but lint check and dco is failing, please fix before merging


move to grpc-dotnet

grpc Csharp Future
grpc-dotnet (the Grpc.Net.Client and Grpc.AspNetCore.Server nuget packages) is now the recommended gRPC implementation for .NET/C#. The original gRPC C# implementation (the Grpc.Core nuget package) will enter maintenance mode and won’t be getting any new features and will only receive important bug fixes and security fixes going forward. The ultimate plan is to phase out Grpc.Core completely at some point in the future. This announcement describes the reasons why we have decided to do so and lays out the plan in more detail.

Yes, we're aware of this (and helped write that blog post). We're expecting to move to the Grpc.Net.Client as the default dependency in the next major version of GAX, then migrating all the client libraries to that version too. I don't have an ETA for that, but it's on our radar so I'll close this issue now.

i think we can use SDK also in UWP app if it moved to grpc-dotnet

@xanscale: While that may be technically possible, I doubt that we'd want to make UWP a fully supported environment without spending significant resources in testing it.

Is there any temporary workaround for this? Because a compiled app for linux-arm seems to fail to run because of this (using the Speech API).
See https://github.com/grpc/grpc/issues/23566#issuecomment-662479880

You can add a dependency on Google.Api.Gax.Grpc.GrpcNetClient, and then when you build a client, use the client builder and specify the GrpcAdapter property to be a GrpcNetClientAdapter.
I don't know for sure whether that will avoid Grpc.Core being initialized (and thus failing), but it may do...

@jskeet unfortunately Google.Api.Gax.Grpc.GrpcNetClient requires .NET Standard 2.1 but UWP support up to 2.0
so there isn't any workaround for UWP ?

@xanscale: Not for the APIs in this repo, no. To reiterate: UWP is not a supported platform for these libraries. You could potentially use the Google.Apis.* NuGet packages, which don't use gRPC, but again, UWP isn't a supported platform for those either.

Just in case anyone was wondering, the above works for Linux arm.
var builder = new Google.Cloud.Firestore.V1.FirestoreClientBuilder();
builder.GrpcAdapter = Google.Api.Gax.Grpc.GrpcNetClient.GrpcNetClientAdapter.Default;

db = FirestoreDb.Create("XXX", builder.Build());


More badge options

Would be nice to have the same style options like on https://shields.io/

Also would love to be able to extend color range as seen here..
https://img.shields.io/badge/style-flat-green.svg?logo=appveyor&longCache=true&style=flat&colorA=212121&colorB=007BFF
?colorA=212121&colorB=007BFF

I would like to work on this.


number representation in JSONLD

(split off from https://github.com/Sveino/Inst4CIM-KG/issues/49)

in JSONLD it must be 1.23 and not "1.23" for a float.

I wrote in https://github.com/3lbits/CIM4NoUtility/issues/278 about the dangers of JSON numbers.
JSON doesn't define its numbers:

It doesn't define int, float, double: there's just "number".
And it doesn't specify whether a number should be represented as float, double or even infinite precision big decimal.
That is implementation specific.

https://json-ld.org/playground/

Convert this to NQuads :

{
  "@context": {
    "cim": "http://iec.ch/TC57/CIM100#"
  },
  "@graph": [{
    "@id": "urn:uuid:9d58e5bb-834c-4faa-928c-7da0bb1497d9",
    "cim:Equipment.normallyInService": true,
    "cim:Reactance.value": [0.123, 1.00000000000]
    }]}

The result is "0.123"^^xsd:double and "1"^^xsd:integer.
So depending on the specific value, it's treated as different datatype!

Only if we add specific datatypes (in the context):

{
  "@context": {
    "cim": "http://iec.ch/TC57/CIM100#",
    "xsd": "http://www.w3.org/2001/XMLSchema#",
    "cim:Equipment.normallyInService": {"@type": "xsd:boolean"},
    "cim:Reactance.value": {"@type": "xsd:float"}
  },
  "@graph": [{
    "@id": "urn:uuid:9d58e5bb-834c-4faa-928c-7da0bb1497d9",
    "cim:Equipment.normallyInService": true,
    "cim:Reactance.value": [0.12345678901234567890, 1.00000000000]
    }]}

We get what we want: "1.234567890123457E-1"^^xsd:float and "1"^^xsd:float.
But 1.234567890123457E-1 has too many decimals for a float. What happened is that internally it was processed as double, and only spit out with float datatype.

More importantly, you cannot control whether to enclose numbers in quotes on output.
I made tests with some tools (I'll commit the details to git):

tool
reactance
normallyInService

GraphDB
"0.123" xsd:float
"true" xsd:boolean

Jena riot
"0.123" xsd:float
"true" xsd:boolean

ttl2json
"0.123" xsd:float
true

Virtuoso context
0.1230000033974648
true

Virtuoso plan
0.1230000033974648
true

GraphDB and Jena output @value in quotes and always attach a datatype
Virtuoso outputs only @value without quotes (and adds some fake decimal digits due to internal conversions)
ttl2json outputs the number as @value in quotes with datatype, but the boolean without quotes

Note: in all cases we didn't specify a context to use (because it's not ready).
If we do, then more tools may output values in quotes.

What is the harm if JSON numbers are enclosed in quotes?

Does this example not show that we "must" allow for both?
My understanding is:
The JSON-LD standard specifies that datatype declarations can be used to define the type of literal values, such as integers, dates, or custom data types, by adding a "@type" key within the context or within each value. This is optional in JSON-LD, as JSON-LD tries to be flexible with datatypes to accommodate varied data structures and maximize compatibility with JSON.
From this we have the following option:

Requiring Datatype Declarations
Not Allowing Datatype Declarations
Allowing Both With and Without Datatypes

As we have the context as part of the profile I do not see that we have to require it (1). However, interoperability is fundamental so that is pointing to requiring it. For me I would recommend (3) - Allowing both.
Virtuoso behaviours is generally not accepted. However, I think we have in CIM standard defined some tolerance that this would be inside.


Fix column order in basen inverse_transform

fixes column order for basen inverse transform

BaseN is fixed. OneHot is not working yet.
Regarding a parameterized test:
There is already one for 'BaseNEncoder', 'BinaryEncoder', 'OneHotEncoder', 'OrdinalEncoder'. Are there other encoders that to inverse_transform? or what kind of additional test do you have in mind?

It looks like test_inverse_transform covers it.


[Feature Request] Allow inclusion of alignment in formatting

FormatWith currently handles only format strings {name:formatString}, but there's an optional alignment section {name,alignmentValue:formatString} that should be handled.  I've started by adding a test and some test values in pull 35 (https://github.com/crozone/FormatWith/pull/35), along with a description of what needs to happen in the parsing to allow for it.
For example: for a date variable named 'test', to format it yyyy-MM-dd and left-pad it to 15 characters, the tag should read: {test,15:yyyy-MM-dd}, and the standard format string would be {0,15:yyyy-MM-dd}.  To right-pad it, use a negative number.

@crozone I've gotten a full changeset complete with new tests put together in the linked Pull (#35).


Enable low memory footprint migration with Isomalloc via RDMA

Original issue: https://charm.cs.illinois.edu/redmine/issues/1829

Using zero copy direct API, we can use RDMA to reduce the memory footprint of AMPI programs during LB. When migrating, we can only PUP the sizes and addresses, but not the buffers themselves, then when unpacking create CkNcpy{Source,Destination} and copy the buffers via rget's. This will reduce the memory overhead during migration from potentially 4x down to 2x.
I have a proof-of-concept implementation that needs to be cleanup up and posted to gerrit.

Integrated via the pup_buffer API in Isomalloc


[Bug] Calling a macro in a disabled model causes RuntimeError

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I now have the test
{% test no_hash_collisions( model, column_name, base_fields ) -%}

and I call it in a model -in the test folder- like below
{{
  test_no_hash_collisions(
                      model  = ref('GROUP_CUSTOMER')
                     , column_name  = 'CUSTOMER_HDIFF'
                     , base_fields = 'CUSTOMER_CODE, CUSTOMER_NAME'
  )
}}

Then I get
Server error: Runtime Error
got an update_rpc call with an unrecognized rpc: rpc.fds_dw.request

Expected Behavior
As the model is disabled I suppose an erro should not be thrown (and possibly the macro should not even be called).
At the very least, the error should be more explicative.
Steps To Reproduce

Create the following macro

{% test no_hash_collisions( model, column_name, base_fields ) -%}

WITH
all_tuples as (
    SELECT distinct {{column_name}} as HASH_FIELD, {{base_fields}}
    FROM {{ model }}
),

validation_errors as (
    SELECT HASH_FIELD, count(*)
    FROM all_tuples
    GROUP BY HASH_FIELD
    HAVING count(*) > 1
)

SELECT * FROM validation_errors

{%- endtest %}

create a test model (in the test folder) and call the macro as below (with some existing ref and column names)

{{ config(enabled=false) }}
{{
  test_no_hash_collisions(
                      model  = ref('GROUP_CUSTOMER')
                     , column_name  = 'CUSTOMER_HDIFF'
                     , base_fields = 'CUSTOMER_CODE, CUSTOMER_NAME'
  )
}}

run the project (or just the disabled one) to see the error

Relevant log output
No response
Environment
- dbt: dbt cloud 0.20.0

What database are you using dbt with?
snowflake
Additional Context
Enabling the test, i.e. removing {{ config(enabled=false) }}, removes the error.

Going to close in favor of https://github.com/dbt-labs/dbt-rpc/issues/79, which is the same issue in the right repo to make an improvement in the error message


copr: Improve BitVec perf

Signed-off-by: Vishnunarayan K I<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #8504
Problem Summary:
What is changed and how it works?
What's Changed:

[x] use u64 instead of u8
[ ] maunually inline usage of BitVec::replace in BitVec::push because
the assert seems to be not inlined (ref: https://rust.godbolt.org/z/Y5bb8d)

The perf measurements on my system shows improvements but it is fluctuating too much to be of any use. Opening PR to macro bench the changes.
Check List
Tests

[x] Unit test
Integration test
[ ] Manual test (add detailed scripts or steps below)

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Please merge latest master so as to solve the build issue.

/bench +tpcc +tpch

/bench +tpcc +tpch +sysbench

On master
running 2 tests
test codec::data_type::chunked_vec_sized::benches::bench_append                           ... bench:      44,518 ns/iter (+/- 6,718)
test codec::data_type::chunked_vec_sized::benches::bench_append_option_vec                ... bench:      24,067 ns/iter (+/- 5,985)

With this patch
running 2 tests
test codec::data_type::chunked_vec_sized::benches::bench_append                           ... bench:      30,713 ns/iter (+/- 4,102)
test codec::data_type::chunked_vec_sized::benches::bench_append_option_vec                ... bench:      24,949 ns/iter (+/- 3,722)

    #[bench]
    fn bench_append(b: &mut test::Bencher) {
        b.iter(|| {
            let mut chunked_vec_int = ChunkedVecSized::with_capacity(10000);
            for _i in 0..5000 {
                chunked_vec_int.push(Some(233));
                chunked_vec_int.push(None);
            }
        });
    }

    #[bench]
    fn bench_append_option_vec(b: &mut test::Bencher) {
        b.iter(|| {
            let mut vec: Vec<Option<i32>> = Vec::with_capacity(10000);
            for _i in 0..5000 {
                vec.push(Some(233));
                vec.push(None);
            }
        });
    }

One more optimisation that can be done is that when pushing a null, we don't have to set the mask.
That change makes bitvec push practically free. But that also means that additional logic has to be introduced in BitVec::truncate for correctness. Therefore I'm not very sure about whether it is worth it. (I also haven't done extensive testing, maybe it may have unforeseen consequences).
running 2 tests
test codec::data_type::chunked_vec_sized::benches::bench_append                           ... bench:      25,864 ns/iter (+/- 460)
test codec::data_type::chunked_vec_sized::benches::bench_append_option_vec                ... bench:      24,675 ns/iter (+/- 655)

diff --git a/components/tidb_query_datatype/src/codec/data_type/bit_vec.rs b/components/tidb_query_datatype/src/codec/data_type/bit_vec.rs
index d72116273..1bf8ae6ef 100644
--- a/components/tidb_query_datatype/src/codec/data_type/bit_vec.rs
+++ b/components/tidb_query_datatype/src/codec/data_type/bit_vec.rs
@@ -32,8 +32,6 @@ impl BitVec {
         self.length += 1;
         if value {
             self.data[idx] |= mask;
-        } else {
-            self.data[idx] &= !mask;
         }
     }

@@ -59,7 +57,17 @@ impl BitVec {
     pub fn truncate(&mut self, len: usize) {
         if len < self.length {
             self.length = len;
-            self.data.truncate(Self::upper_bound(len));
+            let idx = Self::upper_bound(len);
+            self.data.truncate(idx);
+            if idx != 0 {
+                let rem = self.length % BITS;
+                let mask: u64 = if rem == 0 {
+                    0
+                } else {
+                    0xffffffffffffffff << rem
+                };
+                self.data[idx-1] &= !mask;
+            }
         }
     }

You can open another PR to add this optimization it after this PR gets merged. Thanks for your work!

/bench +tpcc +tpch +sysbench

@skyzh Is this PR ready to merge?

@skyzh Is this PR ready to merge?

Yes

/merge


[CI][Python] Some verification tasks on Ubuntu 20.04 fail because we have dropped support for Python 3.8

Describe the bug, including details regarding any error messages, version, and platform.
Since we merge the drop python 3.8 PR:

https://github.com/apache/arrow/issues/43518

There has been some verification jobs on Ubuntu 20.04 that have started failing:

verify-rc-source-integration-linux-ubuntu-20.04-amd64
verify-rc-source-python-linux-ubuntu-20.04-amd64

Ubuntu's 20.04 Python version is 3.8 and we do not support it. We should not test pyarrow verification on Ubuntu 20.04.
Component(s)
Continuous Integration, Python

Do we care about running release verification on such an old Ubuntu LTS? @kou


Column-wise DB encryption

Closes #69
Encrypt String and Date fields with AES-128 for users in the DB
Switch from flyway to programmatic DB init (pre-register a single admin user only)

Is there a reason why we are changing Date to LocalDate? PR looks good otherwise

No justifiable reason, made minor changes to make encryption strategy to use Date instead of LocalDate


[Bug] Desktop icons are not movable!

Description
The Desktop icons can't be moved!
Budgie version
10.8.2
Operating System
Fedora Linux 39 (Budgie)
Steps to reproduce the issue

Install Fedora Linux 39 budgie spin (iso image)
Budgie Desktop Settings -> Desktop -> Desktop Icons (enable)
Create or place some files under ~/Desktop
Try to move them with the mouse
Confirm that they can't be moved

Actual result
The Desktop icons can't be moved!
Expected result
I would expect to move my desktop icons around the desktop surface and place them based on my background image (so the icons don't overlap some areas of the background image).
Additional information
No response

Moving icons within budgie-desktop-view which some distros use out of the box is not available.  That's by design.
Budgie also supports other desktop icon solutions - nemo and desktopfolder.  Obviously you can't run both budgie-desktop-view and another app providing desktop icons.
The gsettings key com.solus-project.budgie-wm desktop-type-override can be updated (use dconf-editor for a GUI method) to change between different implementations that budgie supports.

Umm... what an awkward situation.
Would it be possible to create a feature request and have this implemented in the future?
If not, could we have some solution that does not involve hack-ish ways like gsettings?
I'm trying to install Fedora on 200 desktop PCs, I'm between the Budgie spin and the Cinnamon spin, but having a fully working desktop (with real icons, not fake ones) is important to us. We would rather avoid having to hack the default system to add some functionality if that was possible.
Thank you!

Would it be possible to create a feature request and have this implemented in the future?

I don't have any plans on experimenting with this until I port it to another toolkit and still no guarantee that I'll actually do it then. The current implementation leverages GtkFlowbox and the logic required for arbitrary locations is quite complex and not something I desire in BDV's current form.

If not, could we have some solution that does not involve hack-ish ways like gsettings?

The gsettings is not a hackish solution, it's an internal option intended for distributors of Budgie Desktop. Upon changing it, assuming the other program is installed, we actually expose several settings that the application does.


Broken layout on SD Submit Summary page

Describe the bug
The summary page layout is broken.
To Reproduce
Steps to reproduce the behavior:

Go to  Summary page with Next button
See broken layout

Expected behavior
Layout needs to be readable
Screenshots

Will be replaced with new layout


Go to definition (right-click or Cmd+G) not working on Mac

Issue Report Checklist

[ x] Searched the issues page for similar reports
[x ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ x] Could not reproduce inside jupyter qtconsole (if console-related)
[ x] Tried basic troubleshooting (if a bug/error)

[x ] Restarted Spyder
[ x] Reset preferences with spyder --reset
[ x] Reinstalled the latest version of Anaconda
[ x] Tried the other applicable steps from the Troubleshooting Guide

[ x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Go to definition (by right-clicking and selecting or with Cmd+G) does not work.
What steps reproduce the problem?

conda install spyder
Cmd+G (or right-click and select option)

What is the expected output? What do you see instead?
Go to definition. No action.
Versions

Spyder version: 3.3.2
Python version: 3.6.7
Qt version: 5.9.7
PyQt version: 5.9.2
Operating System name/version: macOS High Sierra 10.13.6

Dependencies

IPython >=4.0     :  7.2.0 (OK)
cython >=0.21     :  0.29.2 (OK)
jedi >=0.9.0      :  0.13.2 (OK)
matplotlib >=2.0.0:  3.0.2 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
numpy >=1.7       :  1.15.4 (OK)
pandas >=0.13.1   :  0.23.4 (OK)
psutil >=0.3      :  5.4.8 (OK)
pycodestyle >=2.3 :  2.4.0 (OK)
pyflakes >=0.6.0  :  2.0.0 (OK)
pygments >=2.0    :  2.3.1 (OK)
pylint >=0.25     :  2.2.2 (OK)
qtconsole >=4.2.0 :  4.4.3 (OK)
rope >=0.9.4      :  0.11.0 (OK)
sphinx >=0.6.6    :  1.8.2 (OK)
sympy >=0.7.3     :  1.3 (OK)

Please report what object are trying to inspect its source code with Cmd+G.


SendTransfer should return the sequence of the packet back in return arg

Summary

Problem Definition

Proposal

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

@charleenfei, I believe this would be a duplicate of #1969?

ah yes that looks right! We need to pick up this issue 🙈 I'll close this one then


Hard crash on preflop.

In a 2 player game, before the flop, after the hand has started (only small and big blinds on the table). Raise, re-raise, fold will hard-crash the game with no error thrown.

This is actually fixed if you update the poker submodule to the current version.

@sam-kelly-dev
Was this ever resolved?
Am trying to use this package but even updating the poker submodule doesn't seem to work.


Problem authenticating the mvc app users with identity server

I know that this is very primitive but everything has a starting point.
I'm trying to use the IdentityServer3 therefore I'm going over the official examples. I have created an authorization server which is very simple:
namespace SimpleIdentityServer
{
    public class Startup
    {
        public void Configuration(IAppBuilder app)
        {
            var options = new IdentityServerOptions
            {
                Factory = new IdentityServerServiceFactory()
                                .UseInMemoryClients(Clients.Get())
                                .UseInMemoryScopes(Scopes.Get())
                                .UseInMemoryUsers(Users.Get()),
                RequireSsl = false
            };
            app.UseIdentityServer(options);
        }
    }
}

This is my in memory user:
new Client
{
    ClientName = "MVC application",
    ClientId = "mvc",
    Enabled = true,
    AccessTokenType = AccessTokenType.Jwt,
    Flow = Flows.Implicit,
    ClientSecrets = new List<Secret>
    {
        new Secret("secret".Sha256())
    },
    AllowedScopes = new List<string>
    {
        "openId",
        "profile"
    },
    RedirectUris = new List<string>
    {
        "http://localhost:12261/"
    }
}

Now, I want to use the aforementioned server to authenticate the users of an MVC application, so I have done this:
  public void Configuration(IAppBuilder app)
   {
       app.UseCookieAuthentication(new CookieAuthenticationOptions
       {
           AuthenticationType = "Cookies"
       });
       app.UseOpenIdConnectAuthentication(new OpenIdConnectAuthenticationOptions
       {
           Authority = "http://localhost:47945/",
           ClientId = "mvc",
           RedirectUri = "http://localhost:12261/",
           ResponseType = "id_token",
           SignInAsAuthenticationType = "Cookies"
       });
   }

And this is a sample controller action annotated with the Authorize attribute:
[Authorize]
public ActionResult About()
{...}

But when I go to home/about in my mvc application it shows me 401 error and it seems (from the serilog) that it doesn't even call the authorization server.

The problem was that I didn't add the  Microsoft.Owin.Host.SystemWeb package so my Owin pipeline was not executing.


Refactor agent classes

Agent - it's clearly a Monoid itself but we happen to wrap it in Option[] monoid which does not seem to make sense. Option[Agent] could be flattened everywhere to be just Agent (with values of either a working agent or Agent.empty).

We don't have to check ifSupported every time we define a new agent instance we can do it at the beginning and then short-circut if the agent is not supported. None of the  implementations of ifSupported methods they do not rely on a specific instrumentation. They only take jar versions into account. Moreover, after we migrate to otel extension, classpath scanning will not be needed at all so this will become redundant.

Note there is also https://github.com/ScalaConsultants/mesmer-akka-agent/issues/301 that should simplify how the config is checked. So it seems that this issue should be done after #301 is done/together with it.

@worekleszczy let's discuss the above findings before implementing #301

Closing - a satisfactory refactor was made along the way while we were adding config and otel extension support


NEXT-10849 - Add console command to change the system default language

add console command to change the system default language
add selection of a default language when installing Shopware using the cli
shopwareBoostday/platform#202
1. Why is this change necessary?
Currently the only way to change the system default language is by the install GUI.
2. What does this change do, exactly?
add a console command to change the system default language
3. Describe each step to reproduce the issue or behaviour.
try to configure the system default language , via cli.
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@J-Rahe as mentined in the boostday repo

@breaker92, thanks : )

Hey @breaker92, would you mind adding an changelog and add to /change the notice about possible data loss to tell the user to make an database backup before?

Hey @breaker92, would you mind adding an changelog and add to /change the notice about possible data loss to tell the user to make an database backup before?

@J-Rahe done

Hi @breaker92,
To merge this PR you have to the following things first:

test if this command works on the different hosts (the INFORMATION_SCHEMA DB is accessed).
much more tests. You test only the output of the command. Whether the data is migrated is not tested at all.
the code must be completely formatted and optimized (early-returns, no one line criterias, ...).
please have a look at the FieldResolver in the DAL then you see how you should build "plain" sql together.
transaction safety, i.e. what happens if a table cannot be migrated?
why did you disable foreign key checks?
fetch the entities via plain sql if you want to return a name => code map

Hi @breaker92 , please complete your PR otherwise I will close it within the next days.


ASM Injection Findings

RenderGlobal:
If FastCraft enabled it injects callback at the front that might hinder rendering. Should execute render call even if returned prematurely.
aload_1
aload_2
fload_3
invokestatic #523 [Method boolean fastcraft.HC.al(net.minecraft.client.renderer.RenderGlobal, net.minecraft.entity.EntityLivingBase, net.minecraft.client.renderer.culling.ICamera, float)]
ifeq 11
// TODO: inject here
return```

Injected calls (working)
HETessalator.onRenderChunkUpdate() 	from WorldRenderer.setPosition()
HELightSMPHooks.onChunkDataLoad()	from Chunk.fillChunk()
HELightSMPHooks.onSetBlock() 		from World.setBlock()


[dfyn-staked-in-farms] dfyn-staked-in-farms strategy added

Fixes # .
Changes proposed in this pull request:

new strategy to calculate score for dfyn tokens staked in dfyn farms

@vatsalgupta13 Please resolve conflicts :)

@vatsalgupta13 Please resolve conflicts :)

Done.

Strategy is live: https://snapshot.org/#/strategy/dfyn-staked-in-farms


Possibility to add multiple model, not only Stable Diffusion v1

Describe the feature you'd like to see:
So I noticed that the addon use only stable diffusion v1, add the possibility to use sdxl and flux, thanks
Additional information
No response

Actually, I added SDXL support on the day it came out (about 18 months ago, I think!) https://github.com/benrugg/AI-Render/releases/tag/v0.7.6
I've been trying to keep AI Render updated with everything available through DreamStudio (StableDiffusion's API), but you can also use any model you want if you run it locally with something like Automatic1111.


Edit Vessel module

Add a new module called Edit vessel. For now, it will allow user to remove a tube. It will use a mask input image that has the tube IDs. The user will be able to click in this image and select a tube (the tube should change color to appear selected). The user will then be able to click a button to remove the selected tube.

Duplicate of #86


Excessive amount of requests when opening the expenses page of a collective.

Describe the bug
When you open the expenses page of a collective, too many requests are fired to the GraphQL api.
To Reproduce
Steps to reproduce the behavior:

Go to https://opencollective.com/webpack
Open the DevTools and go to the network tab.
Click on View all expenses

See all the requests that are fired.

Expected behavior
Should fire only one request.
Screenshots

Duplicate of https://github.com/opencollective/opencollective/issues/2519.
It's ugly, but we don't want to fix it since we'll be revamping the expenses feature entirely very soon.

Duplicate of #2519.
It's ugly, but we don't want to fix it since we'll be revamping the expenses feature entirely very soon.

Alright. Closing this one 🙂


Provide feedback after submitting "create configuration" form

When submitting the infura id, the process of generating the files and obtaining the private key to be presented on the next screen is taking a significant amount of time. We should present a spinner screen to provide some visual feedback to the user.

Implemented


Fix for underscope issue

Fix for https://github.com/upptime/upptime/issues/352

I have read the CLA Document and I hereby sign the CLA

recheck


Add leading / to src path for build.js

:+1:

Also needed to add ../vendor to the controller or else you'll get GET /spa/js/build.js 500 153.442 ms - -
How it should look in controller.js:
'use strict';

var Backbone = require('../vendor/index').Backbone;
var $ = require('../vendor/index').$;
var Model = require('./learning-resource.model');
var View = require('./learning-resource.view');

It looks like this has 0 changes that aren't in master yet.  Closing.


Agenda: cancelling one part of a multi-group meeting doesn't cancel all

Describe the issue
ACE/LAKE were a combined WG meeting that was cancelled. As seen in the attached image, only one is really marked as cancelled.

Related: ACE was originally schedule later in the week, then moved. It is still shown as "rescheduled".
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

You misinterpreted what is happening, and what is currently showing is confusing.Ace is meeting jointly with Lake.
I'll work with the secretariat to change the configuration of the meeting to make this more obvious.
The issue here is that "Joint-with" is a bit of a hack still.

Oooooh, I can see that now. LAKE/ACE is meeting, but ACE is not. (And ACE was moved.)
Proposal for this circumstance: just don't mention ACE in the WG name field anywhere in the agenda, and rely on ACE people to do a search of the body to find it. That is not optimal, but I don't see a non-confusing way to list LAKE/ACE without duplication of the whole row.


Method snippet follow-up

List of follow-up items from #46370 that were easier to put in separate PR(s). I tried to sort these by priority order, and the last couple I don’t think we’ll schedule at all for now. We can close this issue when we’ve done everything worth scheduling for a milestone.

[ ] Add $0 tabstop at the same location as $1 tabstop (in method body)

Should be fairly easy
Should be low-risk
Let's try to get this in 4.5 if possible

[ ] Make auto-imported types work

Moderate effort
Sending this back as part of getCompletionsAtPosition would require a protocol change and corresponding update in typescript-language-features. There are some workarounds we could implement by sending the back as part of getCompletionEntryDetails instead, which would work with no VS Code update. Maybe we should discuss this at next week's editor sync. My feeling is this qualifies as a bug fix, but if we need a VS Code update, we’ll need to coordinate with @mjbvz, and we’re also nearing the end of our own release cycle, so I’m not sure what the best strategy is here.

[ ] From @amcasey at https://github.com/microsoft/TypeScript/pull/46370#issuecomment-949024813: public must precede abstract.

Maybe 4.6?

[ ] From @amcasey at https://github.com/microsoft/TypeScript/pull/46370#issuecomment-949015685:

if you name the method to be overridden "abstract", "async", etc, the completion clobbers the keyword completion. It did this before the change too, but then it would insert the same text either way - now it inserts a whole function declaration.

This can be backlog / help wanted / when you have time for it.

[ ] Improve addMissingMember codefix’s generated implementation signature for overloads (currently all parameters are any)

Let's listen for feedback about this. Unless you feel strongly about it or we hear a lot of complaints, I think this can be backlog / help wanted.

Two more things:

[ ] Get rid of empty replacementSpan https://github.com/microsoft/TypeScript/pull/46370#discussion_r739482895
[ ] Maybe show more than just the name in the completion list; I think a display of method(p1: string, p2: number, ... (probably the whole first line of the insertText, maybe truncated at some number of characters?) would be better, but we can discuss this at an upcoming editor sync.

[ ]  Maybe show more than just the name in the completion list; I think a display of method(p1: string, p2: number, ... (probably the whole first line of the insertText, maybe truncated at some number of characters?) would be better, but we can discuss this at an upcoming editor sync.

I have found I don't miss this when I have completions preview turned on. Also, at least in VSCode there is a truncated preview of the insert text next to the name of the completion, but I don't know how other editors display this.

I have found I don't miss this when I have completions preview turned on

100%. I think this is why I didn't notice this in my initial review of #46370. But it's still not the default.

Also, at least in VSCode there is a truncated preview of the insert text next to the name of the completion

This is actually the detail text that we’ve always generated in completion details. It does help, but the fact that it's the same as it's always been for completions that just insert the name (and the same as it will continue to be if a user disables the member completion snippets) makes me feel like maybe it should be more obvious that we're going to insert additional text... but this is definitely worth gathering feedback on; I don't feel like I have the perfect answer.


🏁 Windows: pwd not available

pwd is not available on Windows, so
https://github.com/shnizzedy/cpac-python-package/blob/9c3dcd6a2102b49fc7014a50a8043d7e4c97485b/src/cpac/backends/platform.py#L59
won't work on Windows.

Can make Windows low priority, at least for now.
(Sorry Windows)

Transferred to https://github.com/FCP-INDI/cpac/issues/15


[Docs] Add LocalNet issues and solutions to FAQ

Description
Fix errors with the Makefile by removing the --build flag from the incorrect position in the client_start command, and add the rebuild_client_start command as well.
Add a description of an issue relating to starting the LocalNet with SELinux and its solution to docs/development/FAQ.md. This will be useful when make compose_and_watch throw errors, these have also been included in the file..
Issue
No issue documentation update
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[x] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[x] Documentation
[ ] Other

List of changes

Add issue and solution to FAQ for SELinux blocking the docker container from accessing local files to start the LocalNet
Remove the --build flag from the client_start command in the Makefile and add the rebuild_client_start command with the --build flag in the correct position

Testing

[x] make develop_test
[x] LocalNet w/ all of the steps outlined in the README

Required Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my changes using the available tooling
[x] I have updated the corresponding CHANGELOG

If Applicable Checklist

[x] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law Make sure to update these in the future:

@h5law Make sure to update these in the future:

Yeah completely passed my mind sorry. I'll make sure to do it all next time.

@Olshansk Removed the FAQ question and updated the Makefile (removed --build and added the rebuild_client_start command). Should be all good to go 😄

LGTM!
@h5law Do you have permissions to squash & mege yourself? If so, go ahead and do so. Our team's pattern is to copy-paste the PR description into the squashed commit message.

Do you have permissions to squash & mege yourself?

@Olshansk No, I don't have permission to merge the PR myself. But I'll remember the pattern for when I can 😄


The integrity of the extension is compromised. There is NO guarantee that the extension will work as designed.

[ ] I'm sure this issue is not a duplicate.

[ ] I'm submitting an icon request:

Type: ``
Icon Name: ``
Sample original Icon:
Extensions: ``
Filenames: ``
Language ids: ``

Language Extensions:

More info:

#2165


Preparing metadata (pyproject.toml) ... error   error: subprocess-exited-with-error

While installing" pip install google-colab", I faced this problem:
Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [4 lines of output]
      <string>:12: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
      error in pandas setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
          pytz >= 2011k
               ~~~~~~~^
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

What should I do?

@Anitajahani could you please help with the fix for this issue? What did you do to resolve this issue?

@Anitajahani Facing same issue here. Can you point to solution? Issue I am encountering has snippet below:
Using cached pandas-0.19.2.tar.gz (9.2 MB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Installing backend dependencies ... done
Preparing metadata (pyproject.toml) ... error
error: subprocess-exited-with-error
× Preparing metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [4 lines of output]
:39: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
error in pandas setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
pytz >= 2011k
~~~~~~~^
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

I have the same issue, while installing google-colab
Installing backend dependencies ... done
Preparing metadata (pyproject.toml) ... error
error: subprocess-exited-with-error
× Preparing metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [4 lines of output]
:12: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
error in pandas setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
pytz >= 2011k
~~~~~~~^
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
any solutions guys? @Anitajahani


Allow raw nt conc over 100

Replace valid_range with valid_min
Stop setting values > 200 to np.nan. This is old code to remove flags that are not present in the NT field anyway.

We probably want to raise an error if values >200 occur. Something for us to investigate further.

Values > 200 do occur. We may need a different solution.
E.g., NH 2022-02-24.
ipdb> nt_conc[nt_conc > 200]
array([227.91939591,<PHONE_NUMBER>7,<PHONE_NUMBER>6])

Updated code to only set a valid_min. Now we log a warning if values > 200 are found.


[Koalas] Make Koalas optional dependency

Allow for Koalas to be an optional dependency:

instead of importing directly, try to import and return None if we fail
custom is_instance function which returns False if the module passed in is None, otherwise proceeds with this isinstance check as normal

See issue #1037

We could also add pyspark and koalas as extras_require in the setup.py file.


fix: remove private kernel hack that adds tx.nonce as nullifier

We already include the TX hash as nullifier in the private kernel, so we should be able to remove the nonce nullifier now.
Discussion here: https://discourse.aztec.network/t/transaction-nonces/227
PR that added TX hash nullifier: https://github.com/AztecProtocol/aztec-packages/pull/541

@spalladino mentioned:
"... now that we're emitting the whole tx hash as a nullifier, should we remove the horrible hack around the tx nonce? That'll remove one unnecessary modifier, though it'll change the semantics of nullifiers as the same nonce could be used more than once for the same sender." He then linked the above discourse discussion.
What will be the side effects of this? Some broken TS tests?

Relevant code that should be removed
https://github.com/AztecProtocol/aztec-packages/blob/82a3d8635de9394fa1a31097db191216efb9137a/circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit.cpp#L204-L210

Step 1: figure out what has already been done, and what has been decided (sync with Santiago)
Step 2: do the task

We should be emitting the tx hash as the first nullifier already, so we can remove the nonce from the set of nullifiers altogether. Should an account want to additionally use nonces for replay protection or handling cancellations, they will be able to do so in the account contract logic (see #660).


pyzotero.zotero_errors.HTTPError: Code: 500

I have a script running every night which automatically creates various bibliographies from my Zotero library.
To do so I get the HTML citation for every library item individually (more than 200 items) using the example code below (where i corresponds to a zotero item and the second line is executed multiple times, i.e. for each of the >200 items individually):
zot = zotero.Zotero(library_id, library_type, api_key)
html = zot.item(i['key'], content='bib', style='ieee')

This often works fine. However, sometimes it fails (without me or anyone else having changed anything at the library or the code) with an HTTP Error 500 and the following traceback:
  File "/builds/div-e/tools/zotero_service/src/zotero_service/bibliography_converter.py", line 134, in _add_item_to_biblio
    html = self._zot.item(i['key'], content='bib', style='ieee')[0]
  File "/usr/local/lib/python3.7/site-packages/pyzotero/zotero.py", line 204, in wrapped_f
    retrieved = self._retrieve_data(func(self, *args))
  File "/usr/local/lib/python3.7/site-packages/pyzotero/zotero.py", line 439, in _retrieve_data
    error_handler(self, self.request)
  File "/usr/local/lib/python3.7/site-packages/pyzotero/zotero.py", line 1653, in error_handler
    raise ze.HTTPError(err_msg(req))
pyzotero.zotero_errors.HTTPError:
Code: 500
URL: https://api.zotero.org/groups/2334655/items/NFRNSS9H?content=bib&style=ieee&format=atom&limit=100
Method: GET
Response: An error occurred

If I then restart the script (without changing anything in the code or in the library) it often works.
Therefore I suspect that this is an issue either with timings or the Zotero server blocking too many requests.
Could this be possible?
Is there an option of setting a number of retries or something to avoid this problem?
Besides, it would probably make sense to query the citation of all library items at once instead of querying item by item, right?

Unfortunately the 500 error isn't particularly informative, and you'll receive a specific error if you're being rate-limited, but there's no reason for you to call zot.item individually. If you want to retrieve every item in your library, you can use zot.everything(zot.item(content='bib', style='ieee')) which should be a lot faster and less error prone, and far less likely to get you rate-limited.

I guess you meant zot.everything(zot.items(content='bib', style='ieee')) (with itemS) at least that is the only working thing for me.
However, in my scenario I do not have all library items but a subset of them. Is there a way to do this request for a specific set of library items (e.g., using their keys as index in the request). Or is there at least a way of associating the output of the aforementioned command (returning the citation in HTML format) to the keys of different library items?
One could use the itemKey parameter to pass a list of key for the items of interest but this is limited to 50 items, right?

As you say, the itemKey parameter is the only way to do this with arbitrary keys. You can either put them into a group, or manually split your list into sub-lists of 50 (with the last one potentially being shorter) and pass each one to your items call. That would still be more efficient than what you're doing now.

Actually this seems to work fine even for more than 50 items (tested with 320 items):
zot.everything(zot.items(itemKey=','.join(keys), content='bib', style='ieee'))
Where keys is a list with the keys of all items of interest.

Thanks!

Here I am stuck with another problem.
Even though the command html = zot.everything(zot.items(itemKey=','.join(keys), content='bib', style='ieee')) works for >50 items the order in which they are returned is not the same as they are requested.
In other words the items in html are ordered differently than in keys so it is impossible to link the generated html to specific keys if I only want to extract a subset of items.
If we could sort the result by itemKey the problem would be resolved but I couldn't find this in the API documentation.
Any other idea how this could be fixed?
Sorting them by dateAdded might result in issues when two items were added exactly at the same moment...

Hi,
I am getting the same 500 error.
My use case is the following:
I am making some items with:
item=zot.item_template('videoRecording')
I then fill in the fields with info, and finally check the item and try to upload it:
zot.check_items([item])
zot.create_items([item],parentID=ID)
However, I get the following error:
pyzotero.zotero_errors.HTTPError:
Code: 500
URL: https://api.zotero.org/users/2999351/items/4VMRHBV2
Method: PATCH
Response: An error occurred

I believe the key at the end is created automatically.
Anyway - any insight would be much appreciated.

It's hard to know what's going on here. A 500 error is (of course) a server-side application error, so unless Pyzotero is sending malformed input (which seems unlikely, but not impossible) there isn't much I can do. Are you creating large numbers of items in sequence? Can you reproduce the error by trying to recreate the item in question?

Yes, so first I tried it with ~200 items, got the ~50 limit prompt.
I tried with 25 items, the limit prompt went away. but I got the above 500 error.
Now I am trying it with a single item (i.e. list with a single zotero item) - again: I get the 500 error...
import pandas as pd
from pyzotero import zotero

zot = zotero.Zotero(USER_ID, 'user', key)
items = zot.top(limit=5)

collectionShlishiKey='MNV4UAR3'
collectionMotzashKey='32INT4JY'

df = pd.read_csv(filename ) # can also index sheet by name or fetch all sheets
df.insert(1, "DATE",0)
for index, row in df.iterrows():
    DATE=extractDate(row['link'])
    df['DATE'][index]=DATE

TITLES=[]
for index,row in df.iterrows():
    TYPE=zot.item_template('videoRecording')
    TYPE['title']=row['name']
    TYPE['url']=Reisha+row['link']+'v'
    TYPE['extra']= row['rawDate']
    TYPE['runningTime']= row['dur']
    TYPE['language']= 'Hebrew'
    TYPE['place']= 'ירושלים'

    try:
        year=5760+int(row['DATE'][0])
        month=int(row['DATE'][1:3])
        day=int(row['DATE'][3:])

        hebdate=dates.HebrewDate(year,month,day)
        TYPE['date']=str(hebdate.to_greg())

    except Exception as e:
        print('error')
        TYPE['date']='error'
    TITLES.append(TYPE)

while TITLES:
    tit=[TITLES.pop()]
    zot.check_items(tit)
    zot.create_items(tit,parentid=collectionMotzashKey)

Where I replaced the user number with the string USER_ID and the key with the string 'key' in the Zotero object instantiation for privacy reasons.
Output:
HTTPError:
Code: 500
URL: https://api.zotero.org/users/USER_ID/items/XNCRQEAA
Method: PATCH
Response: An error occurred

Maybe I am doing something wrong?

Sure:
{'itemType': 'videoRecording',
  'title': 'הלכות הימים הנוראים ותפילותיהן',
  'creators': [{'creatorType': 'director', 'firstName': '', 'lastName': ''}],
  'abstractNote': '',
  'videoRecordingFormat': '',
  'seriesTitle': '',
  'volume': '',
  'numberOfVolumes': '',
  'place': 'ירושלים',
  'studio': '',
  'date': '2004-03-12',
  'runningTime': 'כ-75 דקות',
  'language': 'Hebrew',
  'ISBN': '',
  'shortTitle': '',
  'url': 'http://maran1.com/winmedia/41219YsuccaW.wmv',
  'accessDate': '',
  'archive': '',
  'archiveLocation': '',
  'libraryCatalog': '',
  'callNumber': '',
  'rights': '',
  'extra': 'ליל ה אלול תשס"ד ',
  'tags': [],
  'collections': [],
  'relations': {}}

When I run the check_items() method with [TITLES.pop()] there is no error, so according to the docs it should be ok right?

Check only ensures that there are no missing or extra fields, it doesn't check content. I'll see whether I can reproduce the error here.

The error is occurring because you're using the create_items call wrong: the parentid parameter is intended to be used for adding an item to an existing item using its id, but you're passing it a collection id. Instead, add the collection id directly to the item when you create it:
add a line to your for index,row in df.iterrows(): loop as follows:
TYPE['collections']= collectionMotzashkey
and modify zot.create_items(tit,parentid=collectionMotzashKey) to omit the parentid parameter.

Thanks!
It works.
Still need to work out the kinks with regards to creating in the correct directory/subdirectory
but at least its uploaded correctly :)


[Bug]: Installation not possible

What happened?
I am just getting this window when trying to add the integration:

Version
0.0.11
What device are you seeing the problem on?
AC200M
What bluetooth connection are you using?
USB dongle
Have you changed the integration settings?
false
Integration settings (if you changed them)
No response
Relevant log output
No response

@chaoszone Can you please test Release 0.1 to check if this issue still exists?

@Patrick762 I just updated to your latest release 0.1.1 and I suspect my the AC200Max is not polling after about 20 mins post restarting HA.
I don't see anything in my Home assistant logs, I've restarted HA several times and all AC200M entities go unavailable. 0.1 seemed stable in that regards.
Your efforts are greatly appreciated.


[PKM-29] feat: Api client & service setup

initial setup of Handler
create initial Pokemon Model

@yohancai may I ask where is your separation of ApiClient & ApiService for this?

@yohancai may I ask where is your separation of ApiClient & ApiService for this?


[web] VirtualScroll and AutoScroll helper

Implement virtual scroll and auto scroll with helper functions.

Thanks for the high quality PR again.
I hate to say it, but it's at the border of being reviewable - we should really try to make PRs as small as possible.

This looks good to me - huge... but good. I think the ES7 transform is OK. Let's rebase and merge.

@mhils @cortesi Alright, done. :wink:

:+1: :cake:


Use snake case for struct field names

Serde gives us the ability to have a Rust struct with snake case field names, but serialize them to JSON that uses camel case names, for use with the AWS API or other external tools. Snake case fields for structs is the standard style in Rust, and it feels foreign to have them be camel case. I know botocore gave some thought to this issue, as Python generally uses snake case for dict keys. They decided it was better to use camel case for easier conversion between JSON and Python types. Since Serde can handle this for us in Rust, I think it may be a better choice to prefer Rust's style for Rust code.

Done!


Generate the javascript to validate the client only when really necessary

When we use the RequiredValidator->when and RequiredValidator->whenClient, we want to decide whether the field is required or not.
However, the generation of validation javascript code does not respect the rule when we have only the RequiredValidator->when set. Then the client will always validate the field as required.
In this PR, the validation on the client is only done when there is no RequiredValidator->whenClient rule and, having the RequiredValidator->when rule, the field is mandatory.

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#7540 #7546

I've tried to apply similar patch in #9983, but it was rejected. Than I've found, that it's not a good idea becuase:

Often when property is used without whenClient just because there is no way to determine on the client side whether this rule is applicable. But the attribute must be validated normally on the client side.
During development, it's always better to see an error in a form and think about it, rather than do not see it and think that validation works as expected.
Indeed it breaks BC by changing client-side behavior that is not covered by tests usually and can hurt.

Thank  you for your effort

@samdark @SilverFire
Use case: A field is required only when a condition, regardless of the model, is true.
For example, the field is required if there are already 30 records in the database.
Expected implementation: use the when to test if there are already 30 records. No matter what the user input. The field is required.
The way the code is now, the solution ends up making a ugly hack, creating a hidden field for example.
What makes no sense is set by default the field required on the client, regardless of the when condition.
It is worth asking the opinion of other members?

@thiagotalma why not use whenClient ?
[['attribute'], 'required', 'whenClient' => self::find()->count() > 30 ? 'return true' : 'return false'],

@Faryshta
Thanks for the suggestion, but my problem is more complex than the example I cited.
My rule is something like this:
public function rules()
{
    return [
        [
            [
                'contactName',
                'contactEmail',
                'contactPhone',
                'contactMobile',
            ],
            'required',
            'when' => function ($model, $attribute) {
                $form = $model->profile->form;
                if ($form) {
                    switch ($attribute) {
                        case 'contactName':
                            $required = $form->isNnameRequired;
                            break;
                        case 'contactEmail':
                            $required = $form->isEmailRequired;
                            break;
                        case 'contactPhone':
                            $required = $form->isPhoneRequired;
                            break;
                        case 'contactMobile':
                            $required = $form->isMobileRequired;
                            break;
                        default:
                            throw new InvalidParamException('Attributte unknow');
                    }

                    return $required;
                }

                return false;
            }
        ]
    ];
}

Uggly solution:
public function rules()
{
    return [

        [
            'contactName',
            'required',
            'when' => $checkRequired,
            'whenClient' => 'function() { return ' . ($checkRequired($this, 'contactName') ? 'true' : 'false') . '; }'
        ],
        [
            'contactEmail',
            'required',
            'when' => $checkRequired,
            'whenClient' => 'function() { return ' . ($checkRequired($this, 'contactEmail') ? 'true' : 'false') . '; }'
        ],
        [
            'contactPhone',
            'required',
            'when' => $checkRequired,
            'whenClient' => 'function() { return ' . ($checkRequired($this, 'contactPhone') ? 'true' : 'false') . '; }'
        ],
        [
            'contactMobile',
            'required',
            'when' => $checkRequired,
            'whenClient' => 'function() { return ' . ($checkRequired($this, 'contactMobile') ? 'true' : 'false') . '; }'
        ]
    ];
}

I think the first solution is just as ugly as the second one.
I would change the database schema since it doesn't follow normalization rules.
Anyway a way to solve it
public function rules()
{
    $rules = [];
    $form = $this->profile->form;
    foreach(['contactName', 'contacEmail', 'contactPhone', 'contactMobile'] as $attribute) {
        $attributeRequired = 'is' . str_replace('contact', '', $attribute) . 'Required';
        if ($form->$attributeRequired) {
            $rules[] = [$attribute, 'required'];
        }
    }

    return $rules;
}

@thiagotalma i simplified my example. check it please.