LyX should support more spellcheckers

Issue description
The lyx recipe uses hunspell, but hunspell is not very good
Steps to reproduce

nix-env --install --attr nixpkgs.lyx nixpkgs.hunspell nixpkgs.hunspellDicts.en-us
configure LyX to use Hunspell
be annoyed by Hunspell's limitations

The recipe in question is pkgs/applications/misc/lyx/default.nix.

LyX supports Hunspell, GNU Aspell, and Enchant.


List of default binaries files for GIT-LFS

Is there a predefined list of GIT-LFS files for UE4 projects that are binaries?
Stuff like:

.uasset
.mp4
ETC

Maybe if the file is bigger than 300 KB it'll prompt to add it to LFS.

Not that I am aware of, but will probably work on this sometime later

I will try to work on this if I can get Git LFS to work correctly (issue #35)

Default ".gitattributes" file will contain just one line:
Content/** filter=lfs diff=lfs merge=lfs -text -lockable

The "lockable" part is new to Git LFS 2.0.0 (see #36) but is retro-compatible with LFS 1.x (tested with Git LFS 1.5.5)

@fire @SRombauts I'm working on a new UE4 Git LFS Template project which I'll be uploading to GitHub once it's better defined but if you'd like to check out the earlier revisions please see: https://bitbucket.org/BinarySword/ue4-git-template/src
Just note that I will probably not be accepting any Pullback requests on Bitbucket Cloud, so you'll either have to wait until it's uploaded to GitHub or message me directly with your suggestions.


Add signal support for async

Please add Signal playhouse support on insert method to work with await objects.create()

OK, this is up to discuss. Unfortunately, implementation could be tricky because signals are designed to be sync and we need async. And also if someone added sync signals they won't be called from async code. This could be even worse than having no support for signals at all.

However, we could try calling sync signals with run_in_executor().

There is small problem to call run_in_executor() - await objects.create() uses insert, and in playhouse peewee said:
Peewee signals do not work when you use the Model.insert(), Model.update(), or Model.delete()

Why signals with async is a bad idea?

I'm not saying this is a bad idea. I just point that it may cause unexpected behaviour and need to be designed properly. Consider someone has added signals in their sync codebase. Should we trigger those signals or not? If we do that, than we have to use run_in_executor(). And yes, we should replicate the logic from sync version as close as possible.


Crash on Android: TypeError: Cannot read property 'bubblingEventTypes' of null

The application crashes on Android with the following error:
Warning: TypeError: Cannot read property 'bubblingEventTypes' of null

Environment
Zeego Version: [2.0.4]
Expo Version: [52.0.23]
Any suggestions or possible solutions would be greatly appreciated. Thank you for your help!

Hey, I haven't seen this before, it is likely a react-native-menu issue. New arch?

Thanks for the reply. newArchEnabled is false.


Flutter github codelabs issue with getPlatformVersion and WindowToFront plugin

I'm trying to go through the google codelabs project for creating a Flutter github desktop app.  I'm on step 6 of that codelabs project which is detailing how to create the window_to_front plugin.  That plugin is supposed to make it so that after authentication the app comes back to the forefront and is active.
I'm the type that usually manually types out every bit of code in a tutorial as I tend to learn best that way.  However when I started having this current issue and I couldn't find the problem by comparing my code to what's in the codelabs project I decided to do a copy and paste sort of thing.  However I'm still getting the following issues.
The codelabs doesn't say to do any editing of the window_to_front plugin's main.dart file, yet I'm getting this issue in that file...
[{ 	"resource": "/c:/Projects/window_to_front/example/lib/main.dart", 	"owner": "_generated_diagnostic_collection_name_#0", 	"code": { 		"value": "undefined_method", 		"target": { 			"$mid": 1, 			"external": "https://dart.dev/diagnostics/undefined_method", 			"path": "/diagnostics/undefined_method", 			"scheme": "https", 			"authority": "dart.dev" 		} 	}, 	"severity": 8, 	"message": "The method 'getPlatformVersion' isn't defined for the type 'WindowToFront'.\nTry correcting the name to the name of an existing method, or defining a method named 'getPlatformVersion'.", 	"source": "dart", 	"startLineNumber": 35, 	"startColumn": 38, 	"endLineNumber": 35, 	"endColumn": 56 }]
For reference here's that main.dart file...
import 'package:flutter/material.dart';
import 'dart:async';

import 'package:flutter/services.dart';
import 'package:window_to_front/window_to_front.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  String _platformVersion = 'Unknown';
  final _windowToFrontPlugin = WindowToFront();

  @override
  void initState() {
    super.initState();
    initPlatformState();
  }

  // Platform messages are asynchronous, so we initialize in an async method.
  Future<void> initPlatformState() async {
    String platformVersion;
    // Platform messages may fail, so we use a try/catch PlatformException.
    // We also handle the message potentially returning null.
    try {
      platformVersion =
          await _windowToFrontPlugin.getPlatformVersion() ?? 'Unknown platform version';
    } on PlatformException {
      platformVersion = 'Failed to get platform version.';
    }

    // If the widget was removed from the tree while the asynchronous platform
    // message was in flight, we want to discard the reply rather than calling
    // setState to update our non-existent appearance.
    if (!mounted) return;

    setState(() {
      _platformVersion = platformVersion;
    });
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Plugin example app'),
        ),
        body: Center(
          child: Text('Running on: $_platformVersion\n'),
        ),
      ),
    );
  }
}

Since I can't figure out what the problem is and googling the issue didn't seem to help me at all (maybe I wasn't googling correctly I don't know), I thought that maybe there's an issue with that codelabs project?  Some step that I should have done but am not seeing?  Any help would be greatly appreciated.

The codelabs doesn't say to do any editing of the window_to_front plugin's main.dart file

The plugin itself doesn't have a main.dart file, only its nested example project does.
@domesticmouse Perhaps the codelab should include changing that file even though it's not used, just to avoid this potential confusion?

I'm getting this issue in that file

What's the context where you are getting that error? You shouldn't ever need to build that file in the codelab.

@stuartmorgan well I wasn't trying to build the plugin.  I had performed all the things in step 6 of that codelabs down to where I needed to rerun the main app that I making.  When I tried to run that app to test everything I've done so far I got the following error message...
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\memory(3423,35): error C2512: 'window_to_front::WindowToFrontPlugin::WindowToFrontPlugin': no appropriate default constructor available [C:\Projects\github_client\build\windows\plugins\window_to_front\window_to_front_plugin.vcxproj]
When I went back to the window_to_front plugin code I noticed eslint giving me the error about the getPlatformVersion method.  So I figured that because that eslint error was there the plugin didn't fully build correctly when I tried to build/run the main app.  However if that's not the case then can someone tell me what the problem is with error I posted above that came from trying to build/run the main flutter github app that I'm building in this codelab?

That's unrelated, but it looks like it's an actual bug in the codelab.
@domesticmouse This line looks like it should be passing the registrar, but isn't:
  auto plugin = std::make_unique<WindowToFrontPlugin>();

@stuartmorgan thanks for the assist!  I passed the registrar in that line you mentioned and it seems to have worked.

@stuartmorgan then again I may have spoke too soon.  I was able to run the main flutter github app but as soon as I clicked on the login to github button to test it all out I got an error.  At this time I can only assume the error still has to do with the window_to_front plugin code.  because before trying to implement that part I was able to login to github through the app.  Also, the error mentions the activate() method from that plugin...
The following UnimplementedError was thrown building GithubLoginWidget(dirty, state: _GithubLoginState#20044): activate() has not been implemented
Any ideas on this one?

Can anyone help me with the following error I'm getting, still on step 6 of the flutter github codelab.  I'm at the very end of that step where I try out the part of logging in to Github and then when it's done logging in the app window comes to the front again.  Even though the error happens it does appear to actually go through the logging in to Github.  So it does appear to have something to do with the window_to_front plugin...
The following UnimplementedError was thrown building GithubLoginWidget(dirty, state: _GithubLoginState#20044): activate() has not been implemented

@Seanmyr please see https://github.com/domesticmouse/codelabs/tree/github-client-fix-windows-window_to_front for a fix to get window_to_front working on Windows.


⚠ PrivateHD has degraded performance

In 5d25e9d, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 596 ms

Resolved: PrivateHD performance has improved in 4eaf921.


Proper submodule commands need to be added for setup

The Setup development environment and deployment instructions don't include instructions for initializing and updating the submodules (kibana).
I believe all that needs to be run is -
git submodule update --init --recursive

Or you could instruct users to clone the repo using the command -
git clone --recursive

Done. The README.md has been updated.


CSM: Add missing skip logic to gamma.affinity_test

Add logic to skip the test unless it's cpp/python >= v1.62.x.

[ ] grpc/go/master/branch/psm-csm
[ ] grpc/core/v1.63.x/branch/linux/psm-csm


Double sign gets errors in algebra.parse()

This:
algebrea.parse('12 -- 3');
Results in an error:
SyntaxError: Missing operand
After trying some other stuff, it appears it just can't handle negative signs after the operator. E.g. this also fails:
algebra.parse('-1 * -5');

Any workaround for this issue?

What version are you on? When I try this in the browser console at http://algebra.js.org/ it gets parsed and evaluated to "9" - which is not the correct evaluation but also not the Syntax Error you get.

Any workaround for this issue?

The workaround would be to wrap the negative number in brackets: algebra.parse('12 - (- 3)');

0.2.6

@timrach I wrapped them in brackets. Thanks


fix bugs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lishicheng1996 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


before configuration and before invocation should be 'SKIP' when beforeMethod is 'skip'

TestNG Version

Note: only the latest version is supported
7.6.1

Expected behavior
16:02:12.583 [main] INFO  TestNgDemoListener - after invocation executed, method:beforeClass,testResultStatus:FAILURE/2
java.lang.ArithmeticException: / by zero
16:02:12.631 [main] INFO  TestNgDemoListener - before configuration executed, method:beforeMethod,testResultStatus:SKIP/3
16:02:12.631 [main] INFO  TestNgDemoListener - before invocation executed, method:beforeMethod,testResultStatus:SKIP/3
16:02:12.632 [main] INFO  TestNgDemoListener - after invocation executed, method:beforeMethod,testResultStatus:SKIP/3
16:02:12.633 [main] INFO  TestNgDemoListener - Skip Config Method,beforeMethod,testResultStatus:SKIP/3
14:03:16.659 [main] INFO  TestNgDemoListener - onTestStart executed, method:issueTest,testResultStatus:STARTED/16
14:03:16.661 [main] INFO  TestNgDemoListener - onTestSkipped executed, method:issueTest,testResultStatus:SKIP/3
14:03:16.660 [main] INFO  TestNgDemoListener - before invocation executed, method:issueTest,testResultStatus:SKIP/3
14:03:16.660 [main] INFO  TestNgDemoListener - after invocation executed, method:issueTest,testResultStatus:SKIP/3
Actual behavior
16:02:12.583 [main] INFO  TestNgDemoListener - after invocation executed, method:beforeClass,testResultStatus:FAILURE/2
java.lang.ArithmeticException: / by zero
16:02:12.631 [main] INFO  TestNgDemoListener - before configuration executed, method:beforeMethod,testResultStatus:STARTED/16
16:02:12.631 [main] INFO  TestNgDemoListener - before invocation executed, method:beforeMethod,testResultStatus:STARTED/16
16:02:12.632 [main] INFO  TestNgDemoListener - after invocation executed, method:beforeMethod,testResultStatus:SKIP/3
16:02:12.633 [main] INFO  TestNgDemoListener - Skip Config Method,beforeMethod,testResultStatus:SKIP/3
14:03:16.659 [main] INFO  TestNgDemoListener - onTestStart executed, method:issueTest,testResultStatus:STARTED/16
14:03:16.661 [main] INFO  TestNgDemoListener - onTestSkipped executed, method:issueTest,testResultStatus:SKIP/3
14:03:16.660 [main] INFO  TestNgDemoListener - before invocation executed, method:issueTest,testResultStatus:SKIP/3
14:03:16.660 [main] INFO  TestNgDemoListener - after invocation executed, method:issueTest,testResultStatus:SKIP/3
Is the issue reproducible on runner?

[ ] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse
[ *] IntelliJ
[ ] NetBeans

Test case sample

Please, share the test case (as small as possible) which shows the issue
Simply use listener:
public class TestNgDemoListener implements IInvokedMethodListener, IConfigurationListener, ITestListener
`
import org.slf4j.LoggerFactory;
import org.testng.IConfigurationListener;
import org.testng.IInvokedMethod;
import org.testng.IInvokedMethodListener;
import org.testng.ITestListener;
import org.testng.ITestNGMethod;
import org.testng.ITestResult;

public class TestNgDemoListener implements IInvokedMethodListener, IConfigurationListener, ITestListener {
org.slf4j.Logger logger = LoggerFactory.getLogger(TestNgDemoListener.class);
@Override
public void beforeInvocation(IInvokedMethod method, ITestResult testResult) {
    logger.info(
            "before invocation executed, method:" + testResult.getMethod().getMethodName() + ",testResultStatus:"
                    + getStatusString(testResult.getStatus()));

}

@Override
public void beforeConfiguration(ITestResult testResult) {
    logger.info(
            "before configuration executed, method:" + testResult.getMethod().getMethodName() + ",testResultStatus:"
                    + getStatusString(testResult.getStatus()));
}

@Override
public void onConfigurationSkip(ITestResult testResult, ITestNGMethod method) {
    logger.info("Skip Config Method," + testResult.getMethod().getMethodName() + ",testResultStatus:"
            + getStatusString(testResult.getStatus()));
}

@Override
public void afterInvocation(IInvokedMethod method, ITestResult testResult) {
    logger.info(
            "after invocation executed, method:" + testResult.getMethod().getMethodName() + ",testResultStatus:"
                    + getStatusString(testResult.getStatus()));
}

@Override
public void onTestStart(ITestResult result) {
    logger.info(
            "onTestStart executed, method:" + result.getMethod().getMethodName() + ",testResultStatus:"
                    + getStatusString(result.getStatus()));
}

@Override
public void onTestSkipped(ITestResult result) {
    logger.info(
            "onTestSkipped executed, method:" + result.getMethod().getMethodName() + ",testResultStatus:"
                    + getStatusString(result.getStatus()));
}

public static String getStatusString(int status) {
    return switch (status) {
    case -1 -> "CREATED/" + status;
    case 1 -> "SUCCESS/" + status;
    case 2 -> "FAILURE/" + status;
    case 3 -> "SKIP/" + status;
    case 4 -> "SUCCESS_PERCENTAGE_FAILURE/" + status;
    case 16 -> "STARTED/" + status;
    default -> "Others/" + status;
    };
}

}
import org.slf4j.LoggerFactory;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.BeforeGroups;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.BeforeSuite;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Listeners;
import org.testng.annotations.Test;
@Listeners({ TestNgDemoListener.class})
public class TestNgDemoTest {
org.slf4j.Logger logger = LoggerFactory.getLogger(TestNgDemoTest.class);
@BeforeClass
public void beforeClass() {
    logger.info("beforeClass");
    int i = 5/0; // throw an exception
}

@BeforeMethod
public void beforeMethod() {
    logger.info("beforeMethod");
}

@BeforeTest
public void beforeTest() {
    logger.info("beforeTest");
}

@BeforeSuite
public void beforeSuite() {
    logger.info("beforeSuite");
}

@BeforeGroups
public void beforeGroups(){
    logger.info("beforeGroups");
}

@Test
public void issueTest() {
    logger.info("Test BeforeConfiguration behavior");
}

}
`
Contribution guidelines
Incase you plan to raise a pull request to fix this issue, please make sure you refer our Contributing section for detailed set of steps.
Description
After one of our test project uplift TestNG from 7.5 to 7.6 version, there are some unexpected behavior from before. the related issue is:
beforeConfiguration() listener method should be invoked for skipped configurations as well · Issue #2729 · cbeust/testng · GitHub

@bobshie -Please include a sample (preferably a sample project) that can be used to reproduce the problem

@krmahadevan , Thanks, I add an example and there is conflict with:
it should be the same status in before invocation of 'beforeMethod' and 'issueTest'
16:02:12.631 [main] INFO  TestNgDemoListener - before invocation executed, method:beforeMethod,testResultStatus:STARTED/16
14:03:16.660 [main] INFO  TestNgDemoListener - before invocation executed, method:issueTest,testResultStatus:SKIP/3

@krmahadevan Hi, in order to simply reproduce this problem, I did some simple code and drew a flow of the issue that is being discussed now:
If there are three methods:
`
@BeforeClass
public void beforeClass() {
int i = 5/0; //throw an exception
}
@BeforeMethod
public void beforeMethod() {

}

@Test
public void issueTest() {
    System.out.println("Test BeforeConfiguration behavior");
}

``
And a customized listener:
`
public class DemoListener implements IInvokedMethodListener, IConfigurationListener,ITestListener {
@Override
public void beforeConfiguration(ITestResult testResult) {
    System.out.println(
            "before configuration executed, method:" + testResult.getMethod().getMethodName() + ",testResultStatus:"
                    + testResult.getStatus());
}

@Override
public void beforeInvocation(IInvokedMethod method, ITestResult testResult) {
    System.out.println(
            "before invocation executed, method:" + testResult.getMethod().getMethodName() + ",testResultStatus:"
                    + testResult.getStatus());
}

@Override
public void onConfigurationSkip(ITestResult testResult, ITestNGMethod method) {
    System.out.println("Skip Config Method," + testResult.getMethod().getMethodName() + ",testResultStatus:"
            + testResult.getStatus());
}

@Override
public void onTestStart(ITestResult testResult) {
    System.out.println("OnTestStart Status:" + testResult.getMethod().getMethodName() + ",testResultStatus:"
            + testResult.getStatus());
}

}
`
The execution process is performed as shown in the figure:

In my opinion,since a config method(just like beforeMethod in this demo) has been determined to be skipped, the status obtained in beforeConfiguration() and beforeInvocation() for config method should be skip. In this way, config method and @Test method are consistent.
And I also found a phenomenon in which @OnTestStart and beforeInvocation for @Test method also behave inconsistently. I’m not sure if TestNg’s definition of these two methods is different.
As you know, since this issue was solved: https://github.com/cbeust/testng/issues/2729. If there is a situation in the demo, beforeConfiguration() will also be invoked, and we will get the status as STARTED, which will add a lot of changes for our project.

@Hkh9966 - Since you have spent time on analysing this, would you be willing to help fix it by raising a PR?

@krmahadevan , I'll try to do it.
Can we fix it as:
the expected status in beforeConfiguration & beforeInvocation should be 'SKIP' when beforeMethod is 'SKIP'.
and the expected status in onTestStart & beforeInvocation should be 'SKIP' when test method is 'SKIP'.

@bobshie sure. It also goes without saying that this fix should not cause regression and all existing tests work fine.
@juherr what do you think ?

If we can change it to:
"The status in beforeConfiguration & beforeInvocation should be 'SKIP' when beforeMethod is 'SKIP'."
It is enough to solve our problems.
For "onTestStart & beforeInvocation should be 'SKIP' when test method is 'SKIP'", it may be that the changes will be large.

@Hkh9966

For "onTestStart & beforeInvocation should be 'SKIP' when test method is 'SKIP'", it may be that the changes will be large. And I'm not sure if this change is justified.

In that case, can we please file do the following ?

Update this defect's description to explicitly track configuration methods discrepancy
Create a new github issue for the other one ?

@krmahadevan , I think there is clear description in this thread, we only need to change the first one:
The status in beforeConfiguration & beforeInvocation should be 'SKIP' when beforeMethod is 'SKIP'."
about the next issue, testng has onTestStart() and onTestSkip() when test method is skipped:
12:02:55.353 [main] INFO  TestNgDemoListener - onTestStart executed, method:issueTest,testResultStatus:STARTED/16
Test ignored.
12:02:55.354 [main] INFO  TestNgDemoListener - before invocation executed, method:issueTest,testResultStatus:SKIP/3
12:02:55.354 [main] INFO  TestNgDemoListener - after invocation executed, method:issueTest,testResultStatus:SKIP/3
12:02:55.355 [main] INFO  TestNgDemoListener - onTestSkipped executed, method:issueTest,testResultStatus:SKIP/3
so we can't change onTestStart(STARTED/16) to onTestStart(SKIP/3). it's also very confusing.
I can just fix the first one if it's agreed.

In that case, can we please file do the following ?

Update this defect's description to explicitly track configuration methods discrepancy
Create a new github issue for the other one ?

@krmahadevan I agree with you.


Adding HomelessArmy HOMY crypto token

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

Adding HomelessArmy Homy crypto token

Already ticked auto-merge box

Hi!! If you need somebody to save you time and merge it for you, i'm your guy!!
https://github.com/SolanaTokenMerger

you have a bunch of fields in the 'extensions' dict that are not allowed, such as:
        "telegram channel": "https://t.me/homelessarmy",
        "telegram group": "https://t.me/HomelessArmy_HOMY",
        "guthub": "https://github.com/Homelessarmy"

see https://github.com/solana-labs/token-list/blob/main/automerge/schema.cue#L105 for a list of allowed extensions


Uncaught TypeError: event.target.getModel is not a FUNCTION

[Enter steps to reproduce below:]

Run formatter.

Atom Version: 1.0.15
System: Windows 7
Thrown From: markdown-table-formatter package, v2.5.3
Stack Trace
Uncaught TypeError: event.target.getModel is not a function
At C:\Users\%username%\.atom\packages\markdown-table-formatter\lib\markdown-table-formatter.coffee:33

TypeError: event.target.getModel is not a function
  at atom-text-editor.<anonymous> (C:\Users\%username%\.atom\packages\markdown-table-formatter\lib\markdown-table-formatter.coffee:31:47)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\src\command-registry.js:245:29)
  at C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\src\command-registry.js:3:61
  at CommandPaletteView.module.exports.CommandPaletteView.confirmed (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\node_modules\command-palette\lib\command-palette-view.js:159:32)
  at CommandPaletteView.module.exports.SelectListView.confirmSelection (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\node_modules\atom-space-pen-views\lib\select-list-view.js:338:21)
  at space-pen-div.atom.commands.add.core:confirm (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\node_modules\atom-space-pen-views\lib\select-list-view.js:109:19)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\src\command-registry.js:245:29)
  at C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\src\command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (C:\Users\%username%\AppData\Local\atom\app-1.0.15\resources\app.asar\src\window-event-handler.js:184:20)

Commands
     -1:05.0 core:undo (input.hidden-input)
     -1:00.9.0 core:backspace (input.hidden-input)
     -1:00.2.0 editor:newline (input.hidden-input)
     -0:59.6.0 core:move-up (input.hidden-input)
     -0:53.9.0 editor:newline (input.hidden-input)
     -0:49.6.0 core:backspace (input.hidden-input)
     -0:46.4.0 core:move-up (input.hidden-input)
  6x -0:43.4.0 core:backspace (input.hidden-input)
     -0:19.8.0 core:copy (input.hidden-input)
  2x -0:18.9.0 core:paste (input.hidden-input)
  2x -0:12 editor:newline (input.hidden-input)
     -0:11.1.0 command-palette:toggle (input.hidden-input)
     -0:08.2.0 core:confirm (input.hidden-input)
     -0:08.2.0 markdown-table-formatter:format (input.hidden-input)
     -0:05.2.0 command-palette:toggle (input.hidden-input)
  3x -0:03.1.0 core:backspace (input.hidden-input)

Config
[...]
Installed Packages
# User
[...]

# Dev
No dev packages

Can't reproduce given your instructions. I'm afraid you'll have to be a little bit more specific...

It shows this every time I execute it. Try it on a part where there is no table and maybe you'll see it.

Look, I just tried. And this error suggests that you're executing command, specifically locked to editor, on non-editor elements, which doesn't really make much sense.
Which leaves us with a couple options. Either this is a bug in Atom, some weird conflict with another package, or some strange configuration. Now you omitted both list of packages and your config, so I can't test for last two. So you'll have to work with me on this.
You can try a couple things:

Restart Atom
Disable all other user packages
Reinstall markdown-table-formatter
Reinstall Atom (well, maybe not yet)

Now you omitted both list of packages and your config, so I can't test for last two.

You won't image how long the package list is.
My config:
{
  "core": {
    "projectHome": "D:\\Users\\%username%\\GitHub",
    "disabledPackages": [
      "metrics",
      "autocomplete-emojis",
      "highlight-column",
      "character-table",
      "placeholder-text",
      "ask-stack",
      "tree-view-breadcrumb",
      "tree-view-background",
      "markdown-scroll-sync"
    ],
    "themes": [
      "atom-dark-ui",
      "one-dark-syntax"
    ]
  },
  "markdown-table-formatter": {}
}

I#ll test the other things soon.

Strange - after reinstalling Atom and all my previously installed packages I could not reproduce this bug any more...

I'll just chalk it up to corrupted installation -- it can happen sometimes, thankfully rarely enough. Thanks for testing!


Used managed entries for data bags, make resources responsible for referencing their object and entry

Hey @jkeiser - I'm up to date with https://github.com/chef/chef-provisioning-aws/commit/9a00c2b73de0e92af8313d4a1ce438e9622c3308 and I'm seeing an error with the following recipe (slimmed down version of my ref.rb recipe, with custom names):
require 'chef/provisioning/aws_driver'
with_driver 'aws::us-west-2'

aws_vpc 'vpc-tball-vpc' do
  cidr_block '<IP_ADDRESS>/24'
end

aws_subnet 'subnet-tball-subnet' do
  vpc 'vpc-tball-vpc'
  map_public_ip_on_launch true
end

machine_image 'tball-machine_image3' do
  machine_options bootstrap_options: {
    subnet_id: 'subnet-tball-subnet'
end

The stacktrace I am seeing is:
1) NoMethodError -  machine_image[tball-machine_image3] (test-provisioning::default line 47) had an error: NoMethodError: undefined method `chef_provisioning' for nil:NilClass
/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/aws_resource.rb:21:in `block in <class:AWSResource>'
/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/super_lwrp.rb:15:in `instance_exec'
/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/super_lwrp.rb:15:in `block in attribute'
/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/aws_resource.rb:65:in `get_aws_object'
/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/aws_resource.rb:71:in `get_aws_object_id'
/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/aws_resource.rb:51:in `block in lookup_options'
/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/aws_resource.rb:43:in `each'

But the reason this is happening is because the Subnet is being initialized with a nil run_context - when I put require 'pry'; binding.pry if run_context.nil? at https://github.com/chef/chef-provisioning-aws/blob/b8359be5aaf7b503181f3072634ef9bfd5b70c93/lib/chef/provisioning/aws_driver/aws_resource.rb#L9 the run_context is passed in as nil when trying to create the machine_image resource.  The subnet is created successfully from its own resource.

@tyler-ball I have fixed all issues there.  Sometimes the resources do get initialized with nil run_contexts (particularly when the driver opens it up, it has no run_context to pass).  The code we have here shouldn't be relying on it, only using driver and managed_entry_store.

Also added a full destroy recipe, and verified launch_configuration and auto_scaling_group.

All resources verified to:

Create the first time (ref.rb)
Reference each other (all known references to other objects in the system are in ref.rb).
Do nothing and display (up to date) the second time (except security group due to a known issue with a separate PR)
Successfully destroy (destroy_ref.rb)

I'mma leave it now :)

I had 1 minor issue that I added a fix for, but otherwise the ref.rb and destroy.rb recipes work!  I think there is some cleanup we could do but I'm going to go ahead and merge this - thanks for the awesome work, @jkeiser!


Add change logging for relationship changes

Closes: #2951
What's Changed

Changes to RelationshipAssociation objects will now trigger an ObjectChange to be created for the source and destination related objects

TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
n/a Attached Screenshots, Payload Example
[x] Unit, Integration Tests
n/a Documentation Updates (when adding/changing features)
n/a Example Plugin Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

Should this be incrementing counters like the generic change logging signal?

Should this be incrementing counters like the generic change logging signal?

Example:

Device1 is related to IPAddress1 through Device-to-IPAddress1
Device1 is deleted and cascades to Device-to-IPAddress1
Should django_prometheus.models.model_updates.labels(IPAddress) be incremented?

Aware that this exacerbates #3015 but not trying to fix in this issue.

Just to be sure - is develop the right target for this or does it belong in next?


Github Pages Workflow

Added gh_pages rake task that generates Yard docs for the current versions of all gems. The task also generate an index.md to be consumed by Github Pages.
Added a workflow to run the above rake task, commit the docs to main branch (To preserve the different versions of the docs), and push the docs to gh_pages branch to be consumed by Github Pages.

Signed-off-by: Theo Truong<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I like it. finish it up?

I like it. finish it up?

Thanks. It's basically done. Just waiting for the Sigv4 PR to be merged.

Preview of the generated docs on my repo: https://nhtruong.github.io/opensearch-ruby/

@nhtruong Want to baseline maintainers, maybe add @VachaShah and get some PRs here going?


TimeOutError: Did not manage to upload package.  Failing

Issue: Azure tests fail because of lack of upload to anaconda.

Environment : `Azure linux_64_r_base3.6` and R4

The error was mentioned by the bot: https://github.com/conda-forge/r-plnmodels-feedstock/commit/a08e87d8e2f94055bd085f050e033a0673a1d3d1#commitcomment-43842366
The package was correctly installed and loaded but from what I understand, the issue comes from the upload of the package to anaconda.org (link). They were 9 trys, all failed and Azure quitted on error.
I will upgrade the build number (as per the README and this issue) to try to solve

I think I've fixed this and retriggered the build in https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=235552&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e
I'll check back later but feel free to ping me if you notice it has failed again.

Great thanks @chrisburr ! @dpryan79 in #4 triggered also the build and it seems to run fine (waiting for win64 as we write)

Success! https://anaconda.org/conda-forge/r-plnmodels/files
If you're generally interested, the process which was failing is described here. The issue was caused by me making a mistake yesterday when moving the staged-recipes feedstock creation job to Azure Pipelines. If you see more issues like this let me know.

Perfect! Thank you for the fix and the doc! I'll close the issue, but to be sure, there's nothing to be done rn (merge #4 or bump the build number)?

Nope, you shouldn't need to bumpy the build number or merge anything else until you have actual changes.

Ok thank you @chrisburr and @dpryan79


Edited pipeline-descriptor to check new ibm-semeru-dependency action …

…for binaries

Summary
Changed action to new dependency to retrieve binaries from https://github.com/ibmruntimes/semeru*-binaries
Also removed JVMKill mentions
Use Cases

Checklist

[ ] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[ ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Looks good. You'll have to admin-merge since there's an expected test failure.


Ziggy generates URL with a double leading slash

Ziggy version
v2.1.0
Laravel version
v10.48.4
Description
We have a route whose sole parameter comes from the DB:
Route::get('{catalog_uri}', fn() => view('pdp'))
    ->where('catalog_uri', '^/p/.+$')
    ->name('catalog.pdp');

It's admittedly non-standard as you would usually move /p/ as part of the route, but this prefix is part of the data provided by the catalog.
In Laravel, creating a URL to this route works as you would expect:
route('catalog.pdp', ['catalog_uri' => '/p/test']); // http://example.com/p/test

Yet if generated by Ziggy, a URL with a double-slash is generated:
route('catalog.pdp', { catalog_uri: '/p/test' }); // http://example.com//p/test

Ziggy call and context
We use Ziggy in Vue, so its route method is called like:

Link to catalog

Ziggy configuration
{
    "url": "https:\/\/example.com",
    "port": null,
    "defaults": {},
    "routes": {
        "catalog.pdp": {
            "uri": "{catalog_uri}",
            "methods": ["GET", "HEAD"],
            "wheres": {
                "catalog_uri": "^\/p\/.+$"
            },
            "domain": "example.com",
            "parameters": ["catalog_uri"]
        }
    }
}

Route definition
Route::get('{catalog_uri}', fn() => view('pdp'))
    ->where('catalog_uri', '^/p/.+$')
    ->name('catalog.pdp');

What's your actual route path? Is it at the root of your app's domain, so the entire URI is literally {catalog_uri}?
I'm adding tests for this to Ziggy and testing it in a real app too and I actually can't reproduce your exact examples. Laravel and Ziggy are behaving the same way for me, but they both behave differently if the route parameter is right at the root of the domain:
Route::get('{catalog_uri}', fn() => '')->where('catalog_uri', '^/p/.+$')->name('catalog1');

Route::get('catalog/{catalog_uri}', fn() => '')->where('catalog_uri', '^/p/.+$')->name('catalog2');

Both Laravel and Ziggy produce the same output for these:
route('catalog1', '/p/test'): http://example.com/p/test

route('catalog2', '/p/test'): http://example.com/catalog//p/test

@bakerkretzmar The catalog routes are bound to a different domain, which is why these routes existing at all, so we can generate them correctly with the alternate domain.
Route::domain('catalog.example.com')->group(function () {
    Route::get('{catalog_uri}', fn() => view('pdp'))
        ->where('catalog_uri', '^/p/.+$')
        ->name('pdp');
});

Does that answer your question?

Yeah it does, thanks. I can't reproduce this at all then. When I add a route with the exact configuration you shared to Ziggy's tests or to one of my own apps, Ziggy's route('catalog.pdp', { catalog_uri: '/p/test' }) returns http://example.com/p/test as expected. Tried on Laravel 10 and 11. Can you reproduce it in another app or a fresh install?

@bakerkretzmar apologies...in my attempt to simply this for the ticket I actually removed the component that causes the issue. You're right that the scenario above works as expected.
I'm able to reproduce it with this slightly different route setup:
// catalog.php
Route::domain('{storefront}.example.com')->name('test.')->group(function () {
    Route::get('{catalog_uri}', fn() => view('pdp'))
        ->where('catalog_uri', '^/p/.+$')
        ->name('pdp');
});

Calling it like this in Vue:

test pdp: {{
    route('catalog.test.pdp', {
        storefront: 'me',
        catalog_uri: '/p/test',
    })
}}

Yields test pdp: https://me.example.com//p/test
For context, we run a multi-tenant site with multiple storefronts, each with its own subdomain.

Thanks, I can reproduce that. Will investigate!

I'll tag another release for this shortly. Thanks for your help @tmannherz!


Remove CHIP_CONFIG_SENDING_BATCH_COMMANDS_ENABLED

Now that we have CommandSender::ExtendableCallback, we can rely on that to make sure anything using CommandSender is capable of sending batch commands

With https://github.com/project-chip/connectedhomeip/pull/32105, this CONFIG is now required


Zaproxy Birthday Tweet

tweets/bdaytweet.py > Simplified version of tiptweets/rndtweet.py to facilitate tweeting about Zap's birthday. (Added generic tweet directory to separate from tips)
crontab.i18n > Updated with new entry to tweet once a year (based on https://www.freeformatter.com/cron-expression-generator-quartz.html)

Updated the message to align more with: https://mobile.twitter.com/zaproxy/status/1170006606051983365

Should I (we) be genericizing this more? So that we could just pass sys.argv for consumption in the script so that it can more easily be used for other stuff? (Or am I over thinking it?)
Ex:
 0 1 0 6 SEP ? 2010/1 cd /home/ubuntu/zap-mgmt-scripts/tweets; /usr/bin/python tweet.py "Happy Birthday Zaproxy!  https://seclists.org/bugtraq/2010/Sep/38 Thank you to all of our contributors and supporters! #owasp #zaproxy"

tw = sys.argv[1]
print('Tweeting: ' + tw)

api.PostUpdate(tw)


Simplify code coverage builds

This PR:

[x] Closes #68.
[ ] Adds and passes relevant tests.
[ ] Has well-formatted code and documentation.

Notes:

It is essential that you add a test when making code changes.
This keeps the code coverage level up, and helps ensure the changes work as intended.
When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
Docstring additions must render correctly, including escapes and LaTeX.

This'll probably involve a bit of tinkering with Codecov because I don't fully understand what they need to see to generate accurate coverage reports.


[JOSS Review] Show documentation page prominently

Great that you have updated your documentation page. Could you now refer to it prominently, for example in the Readme and/or in the project description on github (upper right corner of the github repository page).

Hi @FlorianK13 reference already exists in README.md in the section: Documentation

Thanks for the suggestion @FlorianK13 . Find out that you can add a website in the Settings of the project. Now docs, also appear as a direct link of the project.

@FlorianK13 do you consider this one as completed?

Yes, sure. Then I will close issues when I think they are completed?


⚠ Community has degraded performance

In d5b5139, Community (https://community.wrk.com/health) experienced degraded performance:

HTTP code: 200
Response time: 230 ms

Resolved: Community performance has improved in 7b379b6.


Can not find CasperJS Laravel 5.2

Hello,
I have casperjs and phantomjs installed globally.
I run Laravel 5.2 with nginx - ubuntu 16.04
I have tried everything, even setting the path manually and installing casperjs in the public folder. All i get is Can not find CasperJS error.
The path to the executable is correct, i verified through php file exists and is writeable.
Both phantom and casper work from the command line.

Hello, are you executing your script with the command line or using a browser?
If you use a browser (firefox, chrome...), then you trigger the script via apache or nginx and the script is then executed with your www-data user, you will then need to make casperjs available to this user.


set match_arm_leading_pipes to Always in  .rustfmt.toml

as without it, formatting is broken on the first element, making it misaligned, and difficult to move around.

I wouldn't call it "broken" but rather it encodes when the pattern starts and as such is different from the following alternatives, so not entirely useless or "bad" (it's actually helpful).
I can understand the rationale and I've wanted that a couple of times myself but I feel like this optimizes for the wrong thing, which is writing rather than reading, and looking at the changes made, in the vast majority it just adds to the noise as the patterns are almost always in a single line.
I'd rather we not diverge from the default unless we have a very good reason. The resulting syntax is very ML-like (good and bad; since we're writing a compiler it might feel just a bit more at home), so I'd wait until we do a lot more of the structural/pattern matching down the line to see if the pros of this outweigh the cons but for now I don't think that's the case.
We can discuss f2f.

l like this optimizes for the wrong thing, which is writing rather than reading

discussed f2f. I'm convinced. Will close this for now.


--service-objective  Basic no longer works

What is the correct syntax for the Basic --service-objective?
This recently stopped working in my script and instead, autoprovisions a $403/mo. SQL Server Instance with the error: ./createAzureSQLServerAndDB.sh: line 56: --service-objective: command not found
I have to go into portal.azure.com and manually set the pricing tier.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c1bdd674-b454-e863-c943-9c979b466a92
Version Independent ID: b15341f9-3f1b-00e0-a1c2-970f25a6ab03
Content: az sql db
Content Source: src/azure-cli/azure/cli/command_modules/sql/_help.py
Service: sql-database
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Here is the failed --service-objective Basic in action: https://youtu.be/otzx-d3NhSw?t=540. Results in a ~$400 sql server instance instead of $4.99.
Please advise on the proper syntax as the docs are not correct.
Thank you

Any status on this?

Thank you for reporting! Can you please share a minimal repro? My assumption is that there is a syntax issue in createAzureSQLServerAndDB.sh.

hi @SeaDude - please respond by 1/10 otherwise we will go ahead and close this issue.

Hello,
Here is the script. Last line is the one in question.
#!/bin/bash

# Source:https://docs.microsoft.com/en-us/azure/sql-database/scripts/sql-database-create-and-configure-database-cli?toc=%2fcli%2fazure%2ftoc.json
# Install Azure CLI: https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-apt?view=azure-cli-latest
# Login to Azure CLI using `az login`
# Enter variables below. Examples shown in comments "< >".
# Change script file to executable.
# Run (on Linux) with ./createAzureServer-DB.sh > serverSetup.txt
# See video tutorial here:

# Set Azure location <westus>
export azureLocation=

# Set Azure resource group name <rgwhatever-$RANDOM>
export resourceGroup=

# Set SQL server name <srvwhatever-$RANDOM>
export serverName=

# Set SQL server admin login and password
export adminUserName=
export adminPassword=

# IP address range to whitelist for SQL Server access <curl ifconfig.me>
export startIp=
export endIp=

# Set SQL database name <dbwhatever-$RANDOM>
export databaseName=

# Create a resource group
az group create \
	--name $resourceGroup \
	--location $azureLocation

# Create a logical server in the resource group
az sql server create \
	--name $serverName \
	--resource-group $resourceGroup \
	--location $azureLocation  \
	--admin-user $adminUserName \
	--admin-password $adminPassword

# Configure a SQL Server firewall rule to allow this IP access
az sql server firewall-rule create \
	--resource-group $resourceGroup \
	--server $serverName \
	-n initialSetupIP \
	--start-ip-address $startIp \
	--end-ip-address $endIp

# Create a SQL database
az sql db create \
	--resource-group $resourceGroup \
	--server $serverName \
	--name $databaseName \
# See https://docs.microsoft.com/en-us/azure/sql-database/sql-database-dtu-resource-limits-single-databases#standard-service-tier for pricing
	--service-objective Basic

@SeaDude you have a comment just above --service-objective Basic. This is will break your sh script and will treat --service-object Basic as a new command - as per the error message: ./createAzureSQLServerAndDB.sh: line 56: --service-objective: command not found. Simply removing the comment makes the command work as expected.


Different results when merging LORA weights into the base model vs. when not

System Info
peft, transformers, pytorch, python (3.8)
Who can help?
@BenjaminBossan
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction
I modified Nvidia's BERT fine-tuning example from here by adding support for distributed data parallel during finetuning, using Pytorch DDP.
My code is here:
https://github.com/ankur6ue/distributed_training/tree/master
I'm now trying to add LoRA, which I did as follows.
# load base BERT model:
model = modeling.BertForQuestionAnswering(config)
# Create peft config
peft_config = LoraConfig(
  task_type=TaskType.QUESTION_ANS,
  inference_mode=False,
  r=16,
  lora_alpha=16,
  lora_dropout=0.1,
  bias="all", # will train the bias matrices.
  target_modules=["key", "query", "value"],
  modules_to_save=["qa_outputs"],
)
# Load model from checkpoint and apply LoRA
model.load_state_dict(checkpoint, strict=False)
lora_model = get_peft_model(model, peft_config)
lora_model.print_trainable_parameters()
lora_model.to(device)

# Run training loop. In the forward pass, I'm using the original model (which seems to have been modified in place), rather than the lora_model. If I call the below on the lora_model, I get an error.
start_logits, end_logits = model(input_ids, segment_ids, input_mask)

The training seems to run ok, and I get nearly the same final value of loss as I do without using LoRA.
Now to save the LoRA weights, I can either save them separately like this:
 lora_model.save_pretrained('results/bert_small_lora.bin')

or by merging into the base model:
 merged_lora_model = lora_model.merge_and_unload()
output_model_file = os.path.join(args.output_dir, modeling.WEIGHTS_NAME)
torch.save({"model": merged_lora_model.state_dict()}, output_model_file)

Now if I run evaluation using the merged model, I get the expected F1 scores. However if I use the saved adaptor weights as follows:
model = modeling.BertForQuestionAnswering(config)
peft_model = PeftModel.from_pretrained(model_, lora_model_location, is_trainable=False)
peft_model.cuda(0)

Run evaluation on the model
Then I get terrible results, indicating the LoRA weights are somehow not being applied..
What is the right way to do this?? There are so many questions about how to properly save and apply LoRA adapters, that it would be nice to have a proper example that explains how to do it comprehensively (without using the trainer, because that hides too much complexity and only seems to work on hugginsface models.. and when it doesn't work, it is next to impossible to debug..)
Expected behavior
The evaluation output should be identical for when LoRA weights are merged with the main model vs. when they are not..

Another question is that during fine-tuning using LoRA, the GPU memory used is only slight smaller than while doing full-tuning, even though < 1% of the number of parameters are being trained.. I expected the memory consumed to be a lot smaller. Any tips?
lora_model = get_peft_model(model, peft_config)
lora_model.print_trainable_parameters()
trainable params: 989,186 || all params: 110,374,660 || trainable%: 0.8962
My training code is here: https://github.com/ankur6ue/distributed_training/blob/master/bert_finetuning_squad_peft.py

In the forward pass, I'm using the original model (which seems to have been modified in place), rather than the lora_model. If I call the below on the lora_model, I get an error.

Could you please elaborate on that, what is the error message that you get?

Now if I run evaluation using the merged model, I get the expected F1 scores. However if I use the saved adaptor weights as follows:
model = modeling.BertForQuestionAnswering(config)
peft_model = PeftModel.from_pretrained(model_, lora_model_location, is_trainable=False)

In the code further above, you additionally call model.load_state_dict(checkpoint, strict=False) before applying the LoRA adapter. Here, you're not doing that. Could you try what happens when you add this line before calling PeftModel.from_pretrained?

Another question is that during fine-tuning using LoRA, the GPU memory used is only slight smaller than while doing full-tuning, even though < 1% of the number of parameters are being trained.. I expected the memory consumed to be a lot smaller. Any tips?

Hmm, it's hard to tell, as many factors could come into play here. The script you're linking is using FSDP, right? Did you find the same lack of memory savings when not using FSDP?

In the forward pass, I'm using the original model (which seems to have been modified in place), rather than the lora_model. If I call the below on the lora_model, I get an error.

Could you please elaborate on that, what is the error message that you get?

Now if I run evaluation using the merged model, I get the expected F1 scores. However if I use the saved adaptor weights as follows:
model = modeling.BertForQuestionAnswering(config)
peft_model = PeftModel.from_pretrained(model_, lora_model_location, is_trainable=False)

In the code further above, you additionally call model.load_state_dict(checkpoint, strict=False) before applying the LoRA adapter. Here, you're not doing that. Could you try what happens when you add this line before calling PeftModel.from_pretrained?

Another question is that during fine-tuning using LoRA, the GPU memory used is only slight smaller than while doing full-tuning, even though < 1% of the number of parameters are being trained.. I expected the memory consumed to be a lot smaller. Any tips?

Hmm, it's hard to tell, as many factors could come into play here. The script you're linking is using FSDP, right? Did you find the same lack of memory savings when not using FSDP?

I also face this problem.
I use this code to save the lora adapter weights
`training_args = TrainingArguments(
output_dir=args.output_dir,
evaluation_strategy="epoch",
save_strategy="epoch",
learning_rate=args.learning_rate,
per_device_train_batch_size=args.per_device_train_batch_size,
per_device_eval_batch_size=args.per_device_eval_batch_size,
num_train_epochs=args.num_train_epochs,
weight_decay=0.01,
logging_steps=10,
report_to=[],
save_total_limit=2,
load_best_model_at_end=True,
metric_for_best_model="eval_accuracy",
gradient_accumulation_steps=args.gradient_accumulation_steps
)
trainer = Trainer(
model=model,
args=training_args,
tokenizer=tokenizer,
train_dataset=processed_train_dataset,
eval_dataset=processed_val_dataset,
compute_metrics=compute_metrics,
)
trainer.train()
trainer.save_model(args.best_model_path)
tokenizer.save_pretrained(args.best_model_path)the eval_accuracy during training is ‘0.965’ but when I use this code to merge the stored lora weights and eval again, I get the '0.496' model = AutoModelForSequenceClassification.from_pretrained(base_model_path)
model = PeftModel.from_pretrained(model, checkpoint_path, is_trainable=True)
model = model.merge_and_unload()  # Merge the LoRA layers and unload the PeftModel wrapper
model.eval()`
I tried so many times and the scores are all different.

In the forward pass, I'm using the original model (which seems to have been modified in place), rather than the lora_model. If I call the below on the lora_model, I get an error.

Could you please elaborate on that, what is the error message that you get?

Now if I run evaluation using the merged model, I get the expected F1 scores. However if I use the saved adaptor weights as follows:
model = modeling.BertForQuestionAnswering(config)
peft_model = PeftModel.from_pretrained(model_, lora_model_location, is_trainable=False)

In the code further above, you additionally call model.load_state_dict(checkpoint, strict=False) before applying the LoRA adapter. Here, you're not doing that. Could you try what happens when you add this line before calling PeftModel.from_pretrained?

Another question is that during fine-tuning using LoRA, the GPU memory used is only slight smaller than while doing full-tuning, even though < 1% of the number of parameters are being trained.. I expected the memory consumed to be a lot smaller. Any tips?

Hmm, it's hard to tell, as many factors could come into play here. The script you're linking is using FSDP, right? Did you find the same lack of memory savings when not using FSDP?

I also face this problem.
I use this code to save the lora adapter weights
`training_args = TrainingArguments(
output_dir=args.output_dir,
evaluation_strategy="epoch",
save_strategy="epoch",
learning_rate=args.learning_rate,
per_device_train_batch_size=args.per_device_train_batch_size,
per_device_eval_batch_size=args.per_device_eval_batch_size,
num_train_epochs=args.num_train_epochs,
weight_decay=0.01,
logging_steps=10,
report_to=[],
save_total_limit=2,
load_best_model_at_end=True,
metric_for_best_model="eval_accuracy",
gradient_accumulation_steps=args.gradient_accumulation_steps
)
trainer = Trainer(
model=model,
args=training_args,
tokenizer=tokenizer,
train_dataset=processed_train_dataset,
eval_dataset=processed_val_dataset,
compute_metrics=compute_metrics,
)
trainer.train()
trainer.save_model(args.best_model_path)
tokenizer.save_pretrained(args.best_model_path)the eval_accuracy during training is 0.965 but when I use this code to merge the stored lora weights and eval again, I get the 0.496 model = AutoModelForSequenceClassification.from_pretrained(base_model_path)
model = PeftModel.from_pretrained(model, checkpoint_path, is_trainable=True)
model = model.merge_and_unload() # Merge the LoRA layers and unload the PeftModel wrapper
model.eval()`
I tried so many times and the scores are all different.

@RDXSun I'm not sure if you are really facing the same issue or if it's something different.
Since you're only showing part of the code, this is hard for me to analyze. Ideally, you could show the whole training code, as well as how you evaluate the model.
As for potential solutions, first of all, could you please ensure that the path you're using to save the model, args.best_model_path, is really the same as checkpoint_path? Second, do you face the same issue if you remove the line model = model.merge_and_unload()?

@BenjaminBossan , thanks for looking at this issue.
The errors I get when I run forward pass on the original model are:
(see line 318, here: https://github.com/ankur6ue/distributed_training/blob/master/bert_finetuning_squad_peft.py)
File "/home/ankur/dev/apps/ML/learn/llms/fsdp/bert/bert_finetuning_squad_peft.py", line 317, in fsdp_main
start_logits, end_logits = lora_model(input_ids, segment_ids, input_mask)
File "/home/ankur/miniconda3/envs/dev/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/ankur/miniconda3/envs/dev/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
return forward_call(*args, **kwargs)
File "/home/ankur/miniconda3/envs/dev/lib/python3.8/site-packages/peft/peft_model.py", line 2132, in forward
return_dict = return_dict if return_dict is not None else self.config.use_return_dict
AttributeError: 'BertConfig' object has no attribute 'use_return_dict'

Regarding memory savings, when I change the r in LoraConfig, the memory is lower by about 10%, so LoraConfig has some effect, just not as big as I expected it to be, given that far fewer gradients are being calculated and stored in the backward pass. I verified that requires_grad = False for all layers other than Lora layers and some bias layers.
peft_config = LoraConfig(
task_type=TaskType.QUESTION_ANS,
inference_mode=False,
r=8,
lora_alpha=16,
lora_dropout=0.1,
bias="lora_only", # will train the bias matrices.
target_modules=["key", "query", "value"],
modules_to_save=["qa_outputs"],
)

@BenjaminBossan Re evaluation, here's what happens.
If I just load the original bert_base checkpoint and don't apply any LORA, as follows:
dllogger.log(step="PARAMETER", data={"loading_checkpoint": True})
checkpoint = torch.load(args.init_checkpoint, map_location='cpu')
checkpoint = checkpoint["model"] if "model" in checkpoint.keys() else checkpoint
model.load_state_dict(checkpoint, strict=False)
and run evaluation, I get very poor F1 score (0.5), as expected
If I apply the LORA adapter saved during training as follows:
lora_model_location = 'results/bert_small_lora.bin'
peft_model = PeftModel.from_pretrained(model, lora_model_location, is_trainable=False)
I get much better F1 score: 6.99
But then if I load the merged model (without applying LORA on top of that), I get better F1 score: 8.42
This is odd, because the result of applying LORA adapter on top of original model should be identical to the merged model?

@BenjaminBossan : Also, I'm not using FSDP, just DDP. I took Nvidia's BERT training code and significantly simplified it, as described here:
https://github.com/ankur6ue/distributed_training/tree/master

AttributeError: 'BertConfig' object has no attribute 'use_return_dict'

It appears that you're using your own custom bert model classes, which don't work with classes such as PeftModelForQuestionAnswering, which assumes that the model is a transformers model (or at least behaves like one). This is why you get the error. Maybe it would go away if you remove the task_type=TaskType.QUESTION_ANS from the config.

Regarding memory savings, when I change the r in LoraConfig, the memory is lower by about 10%, so LoraConfig has some effect, just not as big as I expected it to be, given that far fewer gradients are being calculated and stored in the backward pass.

This depends on many factors. Bert is a relatively small model and it could be that you find that the memory savings in absolute terms are not that large. Depending on your data and other factors, memory required for activations, which are not reduced by PEFT, could take up a significant amount of space.

But then if I load the merged model (without applying LORA on top of that), I get better F1 score: 8.42
This is odd, because the result of applying LORA adapter on top of original model should be identical to the merged model?

Results should be very similar, albeit not exactly the same. There is always a bit of imprecision when merging weights. Maybe you could inspect the outputs of the model directly and check if they are very different are close. Also, F1 scores > 1 should not be possible, so there could also be an issue with how you calculate the scores.

Hi @ankur6ue, I face the same issue with Mistral model. I fine tune with QLora, then when I do model.merge_and_unload() I get different - worse results. Have you find a solution for that?

I fine tune with QLora, then when I do model.merge_and_unload() I get different - worse results

How different are the results? Please compare the logits, not the generated tokens, to get a clear picture. Note that merging will always result in a loss of precision, especially with quantized models.

Hi, I compared perplexity, it was like 8 vs 11.
Anyway, finally when I dequantized base model as descibed here merged model was correct.


rendering search box throws error

when rendering standalone search box throws this error:
./src/components/SideBar.js
Module not found: Can't resolve 'react-google-maps/lib/components/places/StandaloneSearchBox'
my code is as mentioned in the docs: Please help!!
import { compose, withProps, lifecycle } from "recompose";
import {
  withScriptjs,
} from "react-google-maps";
import { StandaloneSearchBox } from "react-google-maps/lib/components/places/StandaloneSearchBox";

export  const PlacesWithStandaloneSearchBox = compose(
  withProps({
    googleMapURL: "https://maps.googleapis.com/maps/api/js?key=AIzaSyC4R6AN7SmujjPUIGKdyao2Kqitzr1kiRg&v=3.exp&libraries=geometry,drawing,places",
    loadingElement: <div style={{ height: `100%` }} />,
    containerElement: <div style={{ height: `400px` }} />,
  }),
  lifecycle({
    componentWillMount() {
      const refs = {}

      this.setState({
        places: [],
        onSearchBoxMounted: ref => {
          refs.searchBox = ref;
        },
        onPlacesChanged: () => {
          const places = refs.searchBox.getPlaces();

          this.setState({
            places,
          });
        },
      })
    },
  }),
  withScriptjs
)(props =>

    <StandaloneSearchBox
      ref={props.onSearchBoxMounted}
      bounds={props.bounds}
      onPlacesChanged={props.onPlacesChanged}
    >
      <input
        type="text"
        placeholder="Customized your placeholder"
        style={{
          boxSizing: `border-box`,
          border: `1px solid transparent`,
          width: `240px`,
          height: `32px`,
          padding: `0 12px`,
          borderRadius: `3px`,
          boxShadow: `0 2px 6px rgba(0, 0, 0, 0.3)`,
          fontSize: `14px`,
          outline: `none`,
          textOverflow: `ellipses`,
        }}
      />
    </StandaloneSearchBox>

      {props.places.map(({ place_id, formatted_address, geometry: { location } }) =>

          {formatted_address}
          {" at "}
          ({location.lat()}, {location.lng()})

      )}

); ```

Does is help importing it without the curly braces?
import StandaloneSearchBox from "react-google-maps/lib/components/places/StandaloneSearchBox";
That's what it shows directly below the StandAloneSearchBox section here: https://tomchentw.github.io/react-google-maps/#standalonesearchbox

@nileshgulia1 what's your version?

thanks @ping4tucker  and @tomchentw  the issue have been solved after removing the {} from import statement


[BUG] BulkRequest with scripted noop upsert UpdateOperation fails with "missing required property"

What is the bug?
Similar to Elasticsearch bug: https://github.com/elastic/elasticsearch-java/issues/403.
When you do a scripted upsert with a script that does a "noop", there is no source in the response. But the InlineGet has source as a required field.
https://github.com/opensearch-project/opensearch-java/blob/main/java-client/src/main/java/org/opensearch/client/opensearch/_types/InlineGet.java#L141-L146
A bulk request with an update operation set to do scripted upsert where the script chooses to set ctx.op = 'none' currently fails with
Missing required property 'InlineGet.source': org.opensearch.client.util.MissingRequiredPropertyException
org.opensearch.client.util.MissingRequiredPropertyException: Missing required property 'InlineGet.source'
	at org.opensearch.client.util.ApiTypeHelper.requireNonNull(ApiTypeHelper.java:89)
	at org.opensearch.client.opensearch._types.InlineGet.<init>(InlineGet.java:87)
	at org.opensearch.client.opensearch._types.InlineGet.<init>(InlineGet.java:55)
	at org.opensearch.client.opensearch._types.InlineGet$Builder.build(InlineGet.java:326)
	at org.opensearch.client.opensearch._types.InlineGet$Builder.build(InlineGet.java:205)
	at org.opensearch.client.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:92)
	at org.opensearch.client.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:81)
	at org.opensearch.client.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:185)
	at org.opensearch.client.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:146)
	at org.opensearch.client.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:97)
	at org.opensearch.client.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:60)
	at org.opensearch.client.json.JsonpDeserializerBase$ArrayDeserializer.deserialize(JsonpDeserializerBase.java:343)
	at org.opensearch.client.json.JsonpDeserializerBase$ArrayDeserializer.deserialize(JsonpDeserializerBase.java:308)
	at org.opensearch.client.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:87)
	at org.opensearch.client.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:81)
	at org.opensearch.client.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:185)
	at org.opensearch.client.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:146)
	at org.opensearch.client.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:87)
	at org.opensearch.client.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:91)
	at org.opensearch.client.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:55)

How can one reproduce the bug?
BulkResponse response = client.bulk(
        BulkRequest.of(bulkRequest -> bulkRequest
                .index("test-index")
                .operations(bulkOperation -> bulkOperation
                        .update(updateOperation -> updateOperation
                            .index("indexName")
                            .id("myId")
                            .script(new Script.Builder()
                                .inline(new InlineScript.Builder()
                                    .lang("painless")
                                    .source("ctx.op = 'none';")
                                    .build())
                            .scriptedUpsert(true)
                            .upsert(ImmutableMap.of())
                        )
               )
        )
);

What is the expected behavior?
This should succeed.
The response from Opensearch that reaches the Transport  is
{
    "took": 2,
    "errors": false,
    "items": [{
        "update": {
            "_index": "test-index",
            "_id": "myId",
            "_version": -1,
            "result": "noop",
            "_shards": {
                "total": 3,
                "successful": 3,
                "failed": 0
            },
            "get": {
                "found": false
            },
            "status": 200
        }
    }]
}

Do you have any additional context?
Similar to Elasticsearch bug: https://github.com/elastic/elasticsearch-java/issues/403.

I think this will also require a change in the api spec:
https://github.com/opensearch-project/opensearch-api-specification/blob/33aa91a95dcb2155cc05b9917a790ca46aa7c35e/spec/schemas/_common.yaml#L1258

I think this will also require a change in the api spec: https://github.com/opensearch-project/opensearch-api-specification/blob/33aa91a95dcb2155cc05b9917a790ca46aa7c35e/spec/schemas/_common.yaml#L1258

Yes, please! With a test.

@dblock I have sent the following requests:

https://github.com/opensearch-project/opensearch-java/pull/1043
https://github.com/opensearch-project/opensearch-api-specification/pull/349

Please let me know if anything else needs to be done.

Closed the previous pull requests. Here are the updated requests:

https://github.com/opensearch-project/opensearch-api-specification/pull/351
https://github.com/opensearch-project/opensearch-java/pull/1044

Closed the previous pull requests.

You can amend and force push btw, less work.

This fix was released in v2.11.1


test_node_failed_merge_before_succeed_merge could fail

Question
PTAL https://internal.pingcap.net/idc-jenkins/blue/rest/organizations/jenkins/pipelines/tikv_ghpr_test/runs/45110/nodes/203/steps/694/log/?start=0.

This issue has become out-of-date. Given that no further feedback regarding this issue has been reported, it can be safely closed.


Fixing HLSL compiler resource binding remap bug

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Johannes Deligiannis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Are you sure this is a bug? The check is supposed to be inverted.

Not sure, I was hoping to get clarification on the bug I was seeing in my app. This change solved my problem. But I suppose it could possibly be my application incorrectly configuring the compiler object (or the bug is somewere else)

If you want to let the HLSL compiler decide on bindings for you, i.e., you reflect the resulting DXBC yourself, then you need to add the AUTO flags to the compiler first, otherwise, the bindings will come directly from the SPIR-V.

Closing this. If you have further issues on HLSL autobinding, you can open an issue.


docs(components): Update Screen documentation to reflect maverick changes

CI issues aren't this PR, good to merge.


feature/research

Features Created:
Dummy Your Projects Tab
Dummy All Projects Tab
New projects Tab (connected to Firebase)

Also, attaching an image or video would be helpful

Image - Nitin mentioned that it is quite difficult to implement independently, but will look into extracting from user's image, even so, it will be seen in the Project Details Page (not implemented yet)
Video - is there any reason that you can suggest for implementing this? Because usually research projects don't have a set prototype unless the staff would want to describe their projects through video.

@CheeMinHao What I meant was the video or image of your Pull Request, to let us see how your work is

@Blaise1030 the changes can be viewed in the staging site. Saves the need to attach screenshots

Connected All Projects Tab with Firebase
To answer Nitin's comments:

I am confused why the name you chose to go with is "Project" and not something more accurate like "Research". Is this intentional? (Yes it's intentional, "Research wouldn't make sense as an independent word hence the name "Project", would continue to look for better words due to its formality)
I would recommend you use Composition API with TypeScript instead of Options API with JS. (Will be resolved soon but would want to get the sub-features working first, as I'm still learning TS)
Please ensure all static styles are stored as variables. (Resolved)
When creating a new research project, there is no need for setting ID as the timestamp. Instead, Firebase will automatically auto-assign an ID and you can store the timestamp as an attribute. (Resolved)

Hi Min Hao,
Can we call it something like ResearchProjects then? For other developers, this name would allow them to associate the title with the research as Project could even mean student projects, etc. as we expand our scope of features.
About TS, you need not worry that much right now. It takes barely 2 minutes to convert a file to TS since the only things to be added are types. Try to make use of composition API if possible.. In the case you're more comfortable with options API, then its fine. I can help you refactor later.

Changed file names

Backlog 13/9:

createProject and deleteProject function implemented in Blaise's API code base for research recruitment
- Both functions can be found in src/modules/recruitment/recruitmentAPI.ts
- involved web pages are src/modules/recruitment/NewProject.vue and src/modules/recruitment/YourProject.vue
cleaned up old 'project' instance related code on store/index.ts

Bugs to mention

For my account, if i remove the student role and I reload the page, it will regenerate the student role back on my firebase document. Not sure if it applies to other users.
This bug will cause me to sometimes get 'All Projects' tab or some other times get 'Create Project', since I have both staff and student role.
will consult @Blaise1030 on this matter

Backlog 16/9

updateProject implemented in Blaise's API code base for research recruitment and can be found in src/modules/recruitment/recruitmentAPI.ts
Cleaned up some redundant code and console.logs
Modified UI to allow project editing under src/common/List.vue, will require someone to maybe take up the task on polishing the button positioning

Current Bug
After creating a project and reloading the page, "Create New Project" tab will be replaced with "All Projects" as the user has both staff and student roles. If an attempt to delete the role off of the database, the student role will regenerate after reload. Only when a new section tab is clicked (e.g. Events) and then clicking back to "Research" it will turn back to normal
https://user-images.githubusercontent.com/65438002/133885659-74431547-90df-42ed-93a5-32afa370cf81.mp4

Backlog 24/9

Fixed merge conflict while merging develop branch to research branch

I've performed a review of all the FRs to ensure that everything is covered. I love how the feature is coming together with the UI, logic, and everything. I also noticed how long abstracts are trimmed in the list view. So cool! Here is some feedback I have for now:

Can we add form validation? It is not crucial for now but something that is important to eventually add.
Staff are not able to view the All Projects tab. We should consider showing this tab to them.
Actions such as edit, delete, reject, approve, etc. should have popups to confirm that the user really wants to perform the action. For example, "This action will delete the project permanently. Are you sure that you want to proceed?"
As a student, when I showed interest in one research project (and got rejected), all other research projects by that supervisor were no longer visible whether or not I have indicated an interest in them. There might be some issue with the logic in !state.userInvolvements.find(findProject(p)) from my limited exploration.
When a document is being uploaded there is no user feedback on the screen to indicate that the upload is being processed. In my case, I was urged to press the upload button twice.
The interest button is visible for a project that the student already registered their interest for. This could be a bit misleading. We could look into a way to improve that UX?
Can we improve the responsiveness of the pages?

We can look into these improvements for the time being. With regards to the FRs:

A feature to perform preliminary checks for the documents before it is sent to the supervisor was discussed but I'm not too sure how much it has been integrated into the platform. We could also get feedback from the stakeholders on whether that feature must be included in the coming deployment.
Notifications for important events, such as a new application, are yet to be added.
EOI form link is not integrated yet too.

Backlog 4/10

Integrated EOI Form as a button under src/common/List.vue. Would require some testing on the logic to ensure that the button is correctly displayed ONLY if the student has his/her interests approved.


compiling...

webgpufundamentals.org
Browser: Falkon
OS: Ubuntu
The site is stuck at "compiling..." and not showing any information. Would it be possible to host a pre-built version?
Thanks!

it's super alpha so please be patient but I started writing articles. Many of the articles, where relevant from WebGL Fundamentals will be ported.


Delegate Data source - Be able to get all delegates in a condition

Expected Behavior
What should have happened?
Be able to get all delegates running in kubernetes that are enabled!
data "harness_delegate" "example" {
  type   = "KUBERNETES"
  status = "ENABLED"
}
Actual Behavior
What actually happened?
name is required, so it is not possible!

closed by https://github.com/harness-io/terraform-provider-harness/commit/d03b836d22751dbb83529bef524503a6f63454d0


Fixes write to use set and expire_ttl vs setex directly

This is based off of someone else's code. I'm making a formal pull request so future redis-rack-cache users don't have their memory eaten up by never ending TTLs.
https://github.com/SamSaffron/redis-rack-cache/blob/master/lib/rack/cache/redis_entitystore.rb

Hey @jasonreposa, after the recent v1.2.3 release of this gem I noticed that my rack-cache keys were getting normally evicted and had increasing expires_in times. It might solve your problem as well.

thanks for the update. i'll try the new version


Fix background colors margin + fix dark mode

https://ambroise-dhenain.vercel.app/about (WIP, started playing with it only yesterday, lots of copycat)

The margin fix is probably an old typo mistake
119 > 90 deg, makes it take less space (left/right), but might go against what you intended
I used the same colors as in https://github.com/transitive-bullshit/nextjs-notion-starter-kit/pull/201, noticed that PR after creating my own

Before, backgrounds were entirely disabled in dark mode.

The colors are more of a custom design that I took from some design blog awhile back. They're not supposed to be notion-specific.
I could definitely see this being confusing for people, though, since it's clearly surprising. This may be one of those things that I customize for my branch and leave the notion defaults for the main branch.
Let me noodle on it a bit.


Prerequisites

[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.

Criteria

[X] Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)
[X] English interface (or at least English documentation)
[X] Latest stable version
[X] Full version (i.e. not a trial version)
[X] Fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Name
OpenCppCoverage
Description
OpenCppCoverage is an open source code coverage tool for C++ under Windows.
Homepage
https://github.com/OpenCppCoverage/OpenCppCoverage
Download Link(s)
https://github.com/OpenCppCoverage/OpenCppCoverage/releases
Some Indication of Popularity/Repute
It's a unit-test coverage tool for c/c++ projects.

Duplicates #12613.


MINOR: [Docs] Fix typo in docs for dense union data type

Rationale for this change / What changes are included in this PR?
Fixed typo in Columnar.rst.
I think this typo may have crept in from an older version of the docs when validity bitmaps were allowed for Union types.
Are these changes tested?
N/A
Are there any user-facing changes?
Only in the docs.

@AlenkaF Apologies for the notification, I wasn't sure how else to add a reviewer.
Please do let me know if this not good behaviour, and what I should do in future.
Thanks for all your work!

Thank you for the contribution @nenb, pinging me like this is fine for sure 👍
I think the change is correct. The null count is now added to the first child array (field f), so the length of this array has to be increased by 1.
Will merge.


Update doc links to docs.redhat

https://issues.redhat.com/browse/RHOAIENG-13596
Description
Documentation links have changed from access.redhat.com and docs.openshift.com to docs.redhat.com.
How Has This Been Tested?
Confirmed that the new links are valid.

Note that these links will not be live until 2.14 docs are published:
https://docs.redhat.com/en/documentation/red_hat_openshift_ai_cloud_service/1/html/managing_openshift_ai/enabling_accelerators#enabling-nvidia-gpus_managing-rhoai
https://docs.redhat.com/en/documentation/red_hat_openshift_ai_cloud_service/1/html/managing_openshift_ai/managing-users-and-groups
https://docs.redhat.com/en/documentation/red_hat_openshift_ai_cloud_service/1/html/managing_openshift_ai/managing-users-and-groups#adding-users-to-user-groups_managing-rhoai


Request to document the credentials parameter

When using the GCF UI to generate a key for google vision I am provided with a JSON file. However, this repository doesn't state how to use the JSON file.
I believe the documentation for this repo would increase greatly by adding the following code sample to the README:
const vision = require('@google-cloud/vision');
const credentials = require('./vision-grpc-test-google-api-keys-3aa2156ccb74.json');

// Creates a client
const client = new vision.ImageAnnotatorClient({
  credentials
});

Without this code sample the example in the README would fail as the user isn't authenticated. One needs to either install and configure gcloud, use the GOOGLE_APPLICATION_CREDENTIALS environment variable (another great README candidate), or hunt down the credentials parameter (I discovered it in #63).
One can eventually come across the above documentation, but adding it to the README would help reduce friction for new users.

Thank you. It's silly this is not documented on the platform or the official documentation.

@JustinBeckwith how could we do this? Across the repos, the readme should at least show the keyFilename option (PS @tlhunter, credentials is fine, but keyFilename: './vision-grpc-test-google-api-keys-3aa2156ccb74.json' works, too).

@crwilcox @theacodes how do you document this for the Pythons?

Python typically points toward the cloud docs for set up info.

This issue has been open for awhile and since then the docs have improved quite a bit here. Both the README in this repo and the intro text before each sample on cloud.google.com point pretty quickly to https://cloud.google.com/docs/authentication/getting-started which is a good guide for auth.
I'm going to close this out, but if I'm not understanding the problem correctly, please feel free to reopen.


Application crashes when 'stop analysis' is pressed after stream input disappears

Steps to recreate:

Run the application,
select Tools->play a random sample for testing
press 1. Load LSL streams
check display connectivity values
press 2. start analysis
select Tools->stop generating
press stop analysis

result: application hangs and then crashes
I can stop this behavior by not signalling to kill the Display thread in fun_stop. Commenting out the signal emitter in the display object (this line: https://github.com/RhythmsOfRelating/HybridHarmony/blob/master/src/main_GUI.py#L1071) seems to do the trick.
@phoebsc, unless there is a need to emit this signal that I am not seeing, I think we can make this change.

Thanks for spotting the issue! My only concern is whether restarting the analysis ("start"-->"stop"-->"start") would work after you make this change.

Yes (surprisingly)! At least on Windows, it seems to be fine.


Add terraform for federation services

Two federation services on Cloud Run: federationin and federationout
federationin is invoked on a schedule (e.g., hourly) and must be accessible only to the scheduler (e.g., Cloud Scheduler)
federationout is a gRPC endpoint that can be called by external parties. It requires an OIDC token, so it should be "self-guarded" already.

Added in https://github.com/google/exposure-notifications-server/issues/246


vite build static assets are inlined

Describe the bug
Because of how svelte kit is passing the entry file as lib: in vite build
https://github.com/sveltejs/kit/blob/5416bd7ea935a9db22d95b0c57ae6e119869c002/packages/kit/src/core/build/index.js#L58-L62
all static files, ie: *.png, *.mp4 are inlined in the build, due to this logic in vite:
https://github.com/vitejs/vite/blob/5d4e82d90238b0d52ded1eea6359947eefc5e054/packages/vite/src/node/plugins/asset.ts#L200-L207
Expected behavior
Honour assetsInlineLimit in vite.config.js and emit as a separate assets if it exceeds the inline limit.
I can understand why vite is implemented that way, at the same time, I'm not sure what other apis / ways we could do on svelte kit side alone. I believe this requires changes on both sides

I just stumbled upon this issue. All assets are inlined - images, fonts, etc. For example, I was trying to use a @fontsource package and the font files referenced by the css file in the package were all inlined into the generated css files. Images that are referenced from components are inlined in the respective javascript (and html in case of adapter-static) files.
I'd very much like to explicitly import assets from js/css to benefit from hashed file names (infinitely cachable) and maybe other pipeline steps (e.g. image optimizations).

The problem is actually not the assetsInlineLimit, but rather the fact the build.lib configuration option is set by Svelte Kit:
https://github.com/sveltejs/kit/blob/17bb699a4f4fc6e9331d8874bc7d56c8c81babbe/packages/kit/src/core/build/index.js#L122-L129
If that is set, assets are never exported as files. Without the lib option, the compiler runs into an issue with the dynamic import polyfill as mentioned in the comments.

I found that disabling lib mode and explicitly disabling the dynamic import polyfill gives practically identical results, but causes imported assets to be properly emitted.

closed via #741


mvn central ref

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)


dwm: add _JAVA_AWT_WM_NONREPARENTING=1

dwm is not in Java's internal list of non-reparrenting window managers. Running Java GUI programs without this variable on window managers (eg. jd-gui) causes the window to be blank.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250761 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test


placement="top" not working for Tootip component

Same exact problem as this issue 👉 https://github.com/gluestack/gluestack-ui/issues/1011 except with Tooltip instead of Menu.

Never mind. I think this might be an issue with my app not working properly with {...TrigerProps}.
I'll reopen if this turns out to actually be an issue.


Add admonition re terminology to reference section

Codecov Report

Merging #8 (bd75a42) into master (9803f64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   27.50%   27.50%
=======================================
  Files           5        5
  Lines          80       80
=======================================
  Hits           22       22
  Misses         58       58

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


SMPL Transfer

I tried transferring the smpl parameters on my video,
but I don't want to change the camera parameters (--view_transfer was not stored), the blender results are wrong.
The result of depth map is as shown in the figure

Thanks @ougan for pointing out the bug. I have fixed it, it's on PR reviewing now.


Generates  [object Object][object Object][object Object][object Object]   for any code

VS Code Version: 1.85.0-insider

OS Version: Linux x64 6.2.0-36-generic snap

Logs:
2023-11-14 19:48:37.857 [info] [auth] Logged in as kdcllc
2023-11-14 19:48:39.902 [info] [chat] copilot token chat_enabled: true
2023-11-14 19:48:39.902 [info] [gitCommitMessageProvider] Initializing Git commit message provider.
2023-11-14 19:48:39.902 [info] [githubTitleAndDescriptionProvider] Initializing GitHub PR title and description provider provider.
2023-11-14 19:48:39.903 [info] [auth] Got Copilot token for kdcllc
2023-11-14 19:48:39.927 [info] [gitCommitMessageProvider] Successfully activated the vscode.git extension.
2023-11-14 19:48:39.927 [info] [gitCommitMessageProvider] Enablement state of the vscode.git extension: true.
2023-11-14 19:48:39.927 [info] [gitCommitMessageProvider] Successfully registered Git commit message provider.
2023-11-14 19:48:39.927 [info] [githubTitleAndDescriptionProvider] Successfully activated the GitHub.vscode-pull-request-github extension.
2023-11-14 19:48:39.927 [info] [githubTitleAndDescriptionProvider] Successfully registered GitHub PR title and description provider.
2023-11-14 19:48:40.234 [info] [auth] Logged in as kdcllc
2023-11-14 19:48:40.238 [info] [chat] copilot token chat_enabled: true
2023-11-14 19:48:40.238 [info] [auth] Got Copilot token for kdcllc
2023-11-14 19:48:53.662 [info] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-14 19:48:53.662 [info] [chat fetch] modelMaxTokenWindow 4096
2023-11-14 19:48:53.662 [info] [chat fetch] chat model gpt-4
2023-11-14 19:48:55.620 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1956 ms
2023-11-14 19:48:59.978 [info] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-14 19:48:59.981 [info] [streamChoices] request done: headerRequestId: [677da090-ed30-49a8-a55e-993c45fd90c6] model deployment ID: [x3b0892d9e5fc]
2023-11-14 19:49:00.003 [info] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-14 19:49:00.003 [info] [chat fetch] modelMaxTokenWindow 8192
2023-11-14 19:49:00.003 [info] [chat fetch] chat model gpt-3.5-turbo
2023-11-14 19:49:00.392 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 388 ms
2023-11-14 19:49:00.395 [info] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-14 19:49:00.396 [info] [streamChoices] request done: headerRequestId: [f7a32c6d-a651-49ba-9605-df8a1fb57eaf] model deployment ID: [x2191bfb807ec]
2023-11-14 19:49:02.167 [info] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-14 19:49:02.168 [info] [chat fetch] modelMaxTokenWindow 4096
2023-11-14 19:49:02.168 [info] [chat fetch] chat model gpt-4
2023-11-14 19:49:03.442 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1273 ms
2023-11-14 19:49:07.416 [info] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-14 19:49:07.417 [info] [streamChoices] request done: headerRequestId: [5e395897-9512-46a3-9b78-ec8daffa6d3c] model deployment ID: [x3b0892d9e5fc]
2023-11-14 19:49:07.423 [info] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-14 19:49:07.423 [info] [chat fetch] modelMaxTokenWindow 8192
2023-11-14 19:49:07.423 [info] [chat fetch] chat model gpt-3.5-turbo
2023-11-14 19:49:07.815 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 391 ms
2023-11-14 19:49:07.817 [info] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-14 19:49:07.818 [info] [streamChoices] request done: headerRequestId: [677dcc0d-6063-4224-941d-982df9a11366] model deployment ID: [x2191bfb807ec]
2023-11-14 19:50:06.544 [info] [asyncCompute] Failed to compute async parser based result: (Error) Unrecognized language: yaml
2023-11-14 19:50:38.301 [info] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-14 19:50:38.301 [info] [chat fetch] modelMaxTokenWindow 4096
2023-11-14 19:50:38.301 [info] [chat fetch] chat model gpt-4
2023-11-14 19:50:40.276 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1973 ms
2023-11-14 19:50:51.755 [info] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-14 19:50:51.757 [info] [streamChoices] request done: headerRequestId: [27e420c5-56e9-4901-b2d5-d97a86341000] model deployment ID: [x3b0892d9e5fc]
2023-11-14 19:50:51.766 [info] [chat fetch] engine https://api.githubcopilot.com/chat
2023-11-14 19:50:51.766 [info] [chat fetch] modelMaxTokenWindow 8192
2023-11-14 19:50:51.766 [info] [chat fetch] chat model gpt-3.5-turbo
2023-11-14 19:50:52.209 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 442 ms
2023-11-14 19:50:52.211 [info] [streamMessages] message 0 returned. finish reason: [stop]
2023-11-14 19:50:52.212 [info] [streamChoices] request done: headerRequestId: [81d9708c-c9ff-4f00-8b0f-fdbdeefed4bd] model deployment ID: [x2191bfb807ec]

Steps to Reproduce:

Selected code and @workspace /explain ->

  - task: Docker@2 # Builds and pushes Docker images
    displayName: Build an image
    inputs:
      repository: $(imageName)
      command: build
      Dockerfile: ./WebApp.Dockerfile
      tags: |
        $(shortHash)

As a matter of fact any other code returns just bunch of instead of code

[object Object][object Object][object Object][object Object]

Hi @kdcllc ,
Thank you for patience with this!
This should be fixed in latest VS Code Insiders (from 2023-11-14 12:58:56 onward). Please, let us know if you can still reproduce after upgrading.


Operating table add

About the PR
in Discord 3 votes for Tau

and 3 votes for TG style
toss a coin and port tg sprite
Screenshots

before

after

Changelog

:cl:

add: Added operating table

Probably, done.


Add Quarkus as a MicroProfile runtime for Starter

Please add Quarkus to the list of "MicroProfile servers". Quarkus is "in progress" under the MicroProfile implementations page:
https://wiki.eclipse.org/MicroProfile/Implementation
Thank you,
Cesar

Our procedures state that an implementation must pass all TCK and be fully compatible before it can be added. (indicated by the MicroProfile implementations page)
Until then, this issue will be on hold.

@rdebusscher Certainly. This just for me to track that I will be looking into it. Nothing gets merged until it passes.

Quarkus 1.1.0.Final passed TCK for MP 3.2: https://wiki.eclipse.org/MicroProfile/Implementation
I will prepare a PR....