Get siteKey from env variable

It's common practice to store API keys in environment variables so they aren't versioned. This PR fallbacks to an env variable when siteKey is not explicitly set.

Hi @dword-design
Thank you for the PR, I think #70 will actually do the same work with the advantage or working when changing .env without having to run nuxt build again

Hi @dword-design
Thank you for the PR, I think #70 will actually do the same work with the advantage or working when changing .env without having to run nuxt build again

@Atinux I'm not too deep into the runtime config feature, so if it does the same I'd be fine with closing the PR. Also, I've changed my convention to directly pass environment variables, so it's not that important for me anymore.


Accept gzip-encoded content in GetBytesForSpec()

This follows visitor.FetchSpecContents() in accepting spec contents as gzipped when available, but because callers expect uncompressed bytes, it also uncompresses them. It fixes problems that appear when callers try to work on specs that are over message size limits when uncompressed.
Arguably, one of GetBytesForSpec() and FetchSpecContents() should be eliminated.
#1110 for general discussion of content sizes.

OK, tested


Elm initial stage

What was that?

Sorry about that - quick fingers 😉
It was meant to be a pull request to our fork: https://github.com/ScalaConsultants/Scorex/pull/1
We will contact you about that soon via another channel.


feat: add deposit via solana

This PR introduces deposit integration with the Solana network, enabling users to make direct deposits via the Phantom wallet using the sendTransaction method.
Changes Made:

Added Private Solana RPC: Integrated a private RPC endpoint for improved transaction handling and reliability.
Implemented Deposit Solana Machine: Created a state machine to manage the deposit process for Solana, ensuring robust transaction management and error handling.
Updated Background Balance and Estimation Actors: Enhanced the background balance and estimation actors to support - - Solana transactions, ensuring accurate balance tracking and cost estimation.
Created Deposit Solana Transaction: Developed the functionality to create and send deposit transactions specifically for the Solana network.

Visual Example:

:tada: This PR is included in version 2.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


GetConnect PATCH method

Describe the bug
Flutter web. Trying to make PATCH request thru Google Chrome, but getting error: "Access to XMLHttpRequest at '...' from origin '...' has been blocked by CORS policy: Method patch is not allowed by Access-Control-Allow-Methods in preflight response."
CORS is well configured for using PATCH method (Access-Control-Allow-Methods: *).
Flutter Version:
Flutter 3.7.7 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 2ad6cd72c0 (3 недели назад) • 2023-03-08 09:41:59 -0800
Engine • revision 1837b5be5f
Tools • Dart 2.19.4 • DevTools 2.20.1
Getx Version:
GetX 4.6.5
Solution
The only way to solve the problem was to write the word 'patch' in upper case ('PATCH') in
get_connect/http/src/http.dart (line 332).
As a temporary measure (until a package update comes out), I rewrote the method in my child class like this:
class MyChildClass extends GetConnect { @override   Future<Response<T>> patch<T>(String url, dynamic body, {     String? contentType,     Map<String, String>? headers,     Map<String, dynamic>? query,     Decoder<T>? decoder,     Progress? uploadProgress,   }) {     return super.request<T>(       url,       'PATCH',       body: body,       headers: headers,       contentType: contentType,       query: query,       decoder: decoder,       uploadProgress: uploadProgress,     );   } }

You need enable cors in your server

@jonataslaw I'm having the exact same issue. The funny fact is that the problem only occurs with the patch method (get, post, put, delete all work fine) in a browser environment (aka flutter web). I don't get why

Same issue here. Seems like the package is using patch instead of PATCH, which is why @Artel-Studio 's fix to PATCH works.
https://fetch.spec.whatwg.org/#methods
https://stackoverflow.com/questions/73985866/the-mystery-of-patch-request-and-cors-headers

Here we can see that the request is a patch request, resulting in a CORS error as the server returns PATCH as one of the allowed methods
The strange thing is, this seems to not be an issue in Safari, probably due to how the different browsers implement CORS checking.

Same issue here. Seems like the package is using patch instead of PATCH, which is why @Artel-Studio 's fix to PATCH works.
https://fetch.spec.whatwg.org/#methods https://stackoverflow.com/questions/73985866/the-mystery-of-patch-request-and-cors-headers
 Here we can see that the request is a patch request, resulting in a CORS error as the server returns PATCH as one of the allowed methods
The strange thing is, this seems to not be an issue in Safari, probably due to how the different browsers implement CORS checking.

You have to allow, cross origin in your server. It is not getx problem

Same issue here. Seems like the package is using patch instead of PATCH, which is why @Artel-Studio 's fix to PATCH works.
https://fetch.spec.whatwg.org/#methods https://stackoverflow.com/questions/73985866/the-mystery-of-patch-request-and-cors-headers
 Here we can see that the request is a patch request, resulting in a CORS error as the server returns PATCH as one of the allowed methods
The strange thing is, this seems to not be an issue in Safari, probably due to how the different browsers implement CORS checking.

You have to allow, cross origin in your server. It is not getx problem

No, this is getx's issue, the patch method needs to be all caps. I'm sure since my pure JavaScript code is working perfect with the same API and the same method, payload and headers.
https://github.com/JakeChampion/fetch/issues/254#issuecomment-169838138

My code is also experienced the patch CORS issue, and I'm sure that I enabled CORS for every method (see the OPTION request result)
After I change the code from GetConnect.patch to GetConnect.request('PATCH', ...) it fixed.

Result: (the flutter we choose the chrome as dev browser, but the firefox part is also fixed)

No more CORS issue.


cmd/go: non-reproducible build causes spurious staleness

After CL 73212:
./make.bash
go list -f '{{.Stale}}' runtime/internal/sys
go install -a std cmd
go list -f '{{.Stale}}' runtime/internal/sys

The first go list says false, but the second go list says true. The extra install should not cause problems, yet it does. The implication appears to be that rebuilding runtime/internal/sys is not idempotent even though it appears up to date.
This can manifest as:
./make.bash
./run.bash

failing (but ./run.bash --no-rebuild is OK).
/cc @dr2chase

This appears to be the root cause:
$ ./make.bash
Building Go cmd/dist using /Users/rsc/go1.4.
Building Go toolchain1 using /Users/rsc/go1.4.

Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for darwin/amd64.
---
Installed Go for darwin/amd64 in /Users/rsc/go
Installed commands in /Users/rsc/go/bin
$ go tool buildid $(go list -f '{{.Target}}' runtime/cgo)
OUVe-ybZwJmCm_pggG7n/qIfGDvQfYfzrCamYpIlK
$ go install -a runtime/cgo
$ go tool buildid $(go list -f '{{.Target}}' runtime/cgo)
OUVe-ybZwJmCm_pggG7n/y44aQ68tiged52VYgNT-
$

I thought I'd eliminated all of those but apparently not.


some clarifications to SE-0168 multiline string literals.

Hi Joe, thanks for picking this up. If it’s accepted procedure I’ve made a few clarifications to the proposal in response to the discussion on SE.

This PR is still settling down. I’ll close it for now since we can’t change the proposal mid review and raise a new one if we get the chance to re-submit with modifications.

Hi @jckarter, the SE-0168 review on swift-evolution is nearing convergence on a revised version of this document (the original being woefully inadequate) https://github.com/johnno1962a/swift-evolution/blob/master/proposals/0168-multi-line-string-literals.md. How would you like to proceed from here? File a new PR with the modifications to start second review? The document is just about tied down bar a small change related to whitespace trimming with a good chance of getting consensus if it becomes the actual review doc in your repo.
Cheers.
John

The core team didn't get a chance to look at the original proposal yet. Hopefully we'll get to it next week.


feat: pre rendering upgrade

:tada: This PR is included in version 0.117.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[depdive] output analysis metrics in CSV/JSON format

output generated in JSON format.
A json file then can be converted to a CSV file by the user.


Does not validate a route with 3 required parameters in url

Hi,
When I try to validate a url with 3 url parameters which is required I get an error saying that I have to include the urlparameter.
Example:
/foo/{fooId}/bar/{barId}/foobar/{foobarId}

swagger.file:
/v1/foo/{fooId}/bar/{barId}/foobar/{foobarId}:
parameters:
  - $ref: '#/components/parameters/fooIdPathInput'
  - $ref: '#/components/parameters/barIdPathInput'
  # - $ref: '#/components/parameters/foobarIdPathInput'  // does not work with required with 3 params
  - name: foobarId
    in: path
    required: false   # <---- Only works if I set this to false (this is the 3. parameter)
    schema:
      type: string
      format: uuid

Tried reproducing the issue with this test case but couldn't: https://github.com/Hilzu/express-openapi-validate/commit/09032d7b360efb6354b40a2ccad7d8e4d748894b There's probably something more complicated happening. Can you make that test case fail somehow?

Also tried to reproduce the issue using an integration test but still can't get it to fail: https://github.com/Hilzu/express-openapi-validate/compare/issue/43

Thanks for looking into it. I have forked a version and did some changes in the tests which I could not get to run green. Please have a look at it here: https://github.com/cmartin81/express-openapi-validate/tree/issue/43

With your changes only the integration test is failing.
  ● Integration tests with real app › several path parameters are validated -- POST

    expect(received).toBe(expected) // Object.is equality

    Expected: 200
    Received: 404

      90 |
      91 |     const res = await request(app).post(`/parameters/several/${uuid1}/a/${uuid2}/b/${uuid3}`).send({bar: 'foobar', baz: 'foobaz'});
    > 92 |     expect(res.status).toBe(200);
         |                        ^
      93 |     expect(res.body).toEqual({ a: uuid1, b: uuid2, c: uuid3 });
      94 |   });

The status code is 404 because the integration test app at test/integration/app.ts is only setup to handle GET requests to that URL. If you copy the route handler starting from line 50 and change app.get to app.post the tests passes.

Thank you! I have tried to reproduce my problem without any luck.... So thanks for excellent help and I'll close this issue.


Refine design process map

User story
As a ReportStream team member, I need to understand our design process, so that I know what steps are involved, and who is responsible for driving each step.
Background & context
After reflecting on how our process worked for the first few features we worked on as a team, we have ideas about how to improve our process so our collaboration starts earlier, is more efficient, and is documented.
Open questions

What's the best format to document this process so others can reference it?
How can we indicate required vs optional steps depending on the feature or piece of work? Keeping in mind that this should work for our service design teams' work as well
What is the best way to gather feedback from others? (Knowing all discipline leads from Webex have already been consulted) i.e., should we share in the all team sync on Wed?

Working links
Mural
Acceptance criteria

[x] Take an initial pass at refining the existing process (See mural above)
[x] Document open questions
[x] Review with design team
[x] Create a plan for sharing with the wider team

I made a few minor revisions based on feedback from the design team at crit.
The design team would like to add additional detail to the "Design" process section, and split out the "Implementation" section to be inclusive of non-technical/feature work. This will happen at a future design sync.
Next steps: Share with PMs early next week, and again at All Teams Sync on 4/5.
Going to close since ACs are completed, and happily pass the baton to the design team to complete while I'm OOO.
cc @lizzieamanning


fix: errors when converting meter data from histogram and summary

This PR fixed:

[x] The labels in the meter are not right.
[x] The *_sum metrics are missing.

Is there an issue to link or close?

Sorry, there is no issue related before. Should I create an issue for this?

You don't have to. But please update the change log.

We really need Prometheus e2e for covering this case. Currently, it seems we are testing manually every time.

Hi @gxthrj , I tested my case and found a mirror issue. There is a +Inf bucket in Histogram, then satellite would convert it to a numeric. Like -9.223372036854776E18. That causes OAP exception.

That is the difference between skywalking and prometheus.
For example
In Prometheus , get histogram
# HELP http_request_duration_seconds A histogram of the request duration.
# TYPE http_request_duration_seconds histogram
http_request_duration_seconds_bucket{le="0.05"} 1100
http_request_duration_seconds_bucket{le="0.5"} 1600
http_request_duration_seconds_bucket{le="1"} 2100
http_request_duration_seconds_bucket{le="+Inf"} 2600
http_request_duration_seconds_sum 5050
http_request_duration_seconds_count 2600

When translating to Meter in skywalking, it will be like this
http_request_duration_seconds_count [] 2500
http_request_duration_seconds_sum [] 5000
http_request_duration_seconds [] [bucket:-9.223372036854776e+18  count:1000 bucket:0.05  count:1500 bucket:0.5  count:2000 bucket:1  count:2500]

The representation of the bucket is different.
In proemtheus, the first bucket is le=0.05 histogram if from <= 0.05 in this example. -- (minNum, 0.05 ]
In skywalking, the first bucket is the minInt64, the second bucket is 0.05.  -- (minNum, 0.05]
But they are the same.

There is a +Inf bucket in Histogram, then satellite would convert it to a numeric. Like -9.223372036854776E18.

The minimal number is translating to this, but I am not sure whether it is necessary(@gxthrj ), or what is the exception you facing? (@dmsolr )

I think it is necessary.
I can use math.Inf(-1) instead of minInt

use math.Inf(-1) instead of minInt

Does anyone verify this in the backend? I don't think this could be changed randomly.

use math.Inf(-1) instead of minInt

Does anyone verify this in the backend? I don't think this could be changed randomly.

OAP can read this. @dmsolr

    /**
     * The element in the buckets represent the minimal value of this bucket, the max is defined by the next element.
     * Such as 0, 10, 50, 100 means buckets are [0, 10), [10, 50), [50, 100), [100, infinite+).
     *
     * The {@link Long#MIN_VALUE} could be the first bucket element to indicate there is no minimal value.
     */
    private long[] buckets;

This is bucket definition. @gxthrj I think what you posted is not mapping to it.

I refer to this description: https://github.com/apache/skywalking-goapi/blob/main/collect/language/agent/v3/Meter.pb.go#L103-L107

No matter what @dmsolr is facing about bug in the OAP, it should be fixed.
My point is, -Inf is really necessary? Because histogram in SkyWalking is not expected to have such small value. It is better to set minimal value as 0 or user setting.

Yeap. In fact, -Inf/+Inf is a symbol, so I wanna confirm whether Satellite keeps this symbol. If not, we need to define a key.

I talked with @mrproliu. The infinite- as bucket is not supported actually. We will update the proto and implement this in the OAP first.


add Germany phone number pattern

@wyatt89 Please, add tests for your regex and resend PR. Thanks!


[FEATURE]: Publish estimates as TwistWithCovarianceStamped to support estimators

Feature Type
Adding new functionality to the project
Problem Description
The current implementation publishes the state information using the marine_msgs DVL message. This should continue to be used. However, this message is not accepted by various estimators supported by ROS.
Feature Description
Create a new second publisher, which publishes the velocity estimates transformed into the appropriate coordinate frame and as a TwistWithCovarianceStamped. This will ensure that estimators such as the robot_localization and fuse can interpret the message.
Alternative Solutions
I need to verify that the model used by fuse will accept this message type. The message type supported by fuse should be preferred over the robot_localization message type as the robot_localization package has been deprecated in favor of fuse.
Additional Context
No response

@evan-palmer is the expected coordinate frame for the estimators base_link or base_link_fsd?

This would be base_link

Also, TwistWithCovariance is part of Odometry. Do we still need a separate publisher?

Oh I completely forgot that I added that. Maybe we should put the existing publisher on the odom_fsd frame and the new one on odom. We should double check how Fuse handles transforms. If it expects everything to be at the base frame, we might also want to think about a way to apply the adjoint transformation to that frame

Makes sense!


Updated index.js Korean features and did some translating

Translated fetchRebase.js & pushManyFeatures.js
Updated index.js which was out-dated in Korean. and fixed some indentations in it.

looks great! thanks @JuhoKang :tada: :+1:


Plugin not working if asset source path contains environment variable

If asset source settings uses an environment variable inside path setup, then the plugin won't read the file as the path isn't parsed. In EmbeddedAssetsService function readAssetFile local asset path isn't parsed before calling realpath function. The issue is fixed by passing the path through craft()->config->parseEnvironmentString($path) before realpath.

Thanks for the report, fixed now 👍


Misc cleanups

Do you mind scoping only the wrapped field to texture_gl in your last commit ? I will provide a commit to make use of external_storage / bytes_per_pixel in texture_vk if that's ok with you ?

Do you mind scoping only the wrapped field to texture_gl in your last commit ? I will provide a commit to make use of external_storage / bytes_per_pixel in texture_vk if that's ok with you ?

Is this going to be set in the common path or every backend is going to have the responsibility to keep these fields consistent?

Is this going to be set in the common path or every backend is going to have the responsibility to keep these fields consistent?

I guess yes but after a third thought, you can keep your commit as is. Sorry for the noise.


Add colours

Adding some strategic colours to make it quicker to find start, end of request for example

I like the idea, it's pretty cool.


feat: add shutdown timeout

Hey @rfyiamcool,
Please do not open such PRs. You should first have to create an issue if you find a bug or want to offer an improvement. Olric is not your pet project. Random PRs without a description are not acceptable.

😅


select * from prevention and auto-resolution based on upstream raw schema and/or model definition

Everyone understands that it's best practice to avoid select * from by default, but it's the easiest way for users to keep moving fast. In plain terms, people will bias towards this whether we like it or not. This will also mess with impact analysis as non-breaking changes won't be taken advantage of in sql models. The goal of this is to make the developer experience enjoyable for the boring and tedious bits.
It'd be nice to have a config in config.yaml that inserts a behavior before running sqlmesh plan <dev env> that prompts the user to write out the columns by hand OR if possible, ask for permission to overwrite * with all the columns and then simply overwrites it using the @STAR macro behind the scenes: https://sqlmesh.readthedocs.io/en/stable/concepts/macros/sqlmesh_macros/?h=@star#star
gateways:
    tobiko_cloud: # this will use the config in tcloud.yaml for state_connection
        connection:
            type: bigquery
            method: service-account-json
            concurrent_tasks: 5
            register_comments: true
            keyfile_json: {{ env_var('GOOGLE_SQLMESH_CREDENTIALS') }}
            project: sqlmesh-public-demo

default_gateway: tobiko_cloud

prevent_select_star: true # a config like this

this is kind of a duplicate of #3322 . if we implement a strict mode, this would be part of it


License file

Hello,
Under what license angular-no-captcha is published?
Could you add license file?

Licese file is added.


Webpack 5 support, deprecation warning: DEP_WEBPACK_COMPILATION_ASSETS

(node:33508) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.

I'm still getting this with   "html-webpack-plugin": "^5.2.0", and   "webpack-pwa-manifest": "^4.3.0"
any news?

Hello everyone. Do we have any news? or maybe this plugin unsupported ?


FEATURE REQUEST: true offline write mode for ipyvolume embed_html

The offline=True kwarg in embed_html() allows only for offline viewing, not writing, of the html file. (Found this out the hard way while preparing for a conference where I'd been warned not to rely on the wifi!)
It would be fairly straightforward to bundle the extra javascript dependencies in the site-packages/ipyvolume/static/ directory. If I did that, would you want the offline=True keyword argument to use these local files exclusively?

dev=True does take ipyvolume's js file, though not the fontawesome icons. How is this issue different from #199?

It's different from https://github.com/maartenbreddels/ipyvolume/issues/199 because this would still spend time writing files to the js directory that goes with the html.
Yes, devmode=True does do some of this, but you can't currently unplug your internet connection and then write a html file with ipyvolume (because the html still needs some dependencies like font-awesome, pythreejs, etc. that are only downloaded via an internet connection).


Airy Create AWS: Use existing VPC

When creating a new Airy instance, we need to make it possible to also use an existing VPC instead of creating a new one.
Specifying the vpc and other needed resources should be done through the --provider-config flag, for example:
airy create --provider aws --provider-config "vpcId=..."

Implemented.


Hide "Complete" Buttons

Currently appears like bugs to deal with in Tasklist:
https://forum.camunda.org/t/hidecompletebutton-being-reset-in-recent-camunda-versions/16302/4
https://forum.camunda.org/t/camsdk-can-you-hide-the-start-button/22301

done


App is crashing after updating my gradle build to 3.2.1 and applying google gms plugin

when i launch the app i get this error 'com.google.android.gms.ads.identifier.advertisingidclient not found'
i made a search and i found that google has moved all its libraries to gms plugin i think your library needs an update.
thnx

Hi! I assume this happens with the sample app in this repo, right ? Does the error happen at runtime or compiletime ?


Pornhub extractor expects URLs that contain /video/get_media as json and fails to parse JSON: Expecting value in '': line 1 column 1 (char 0)

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Europe
Provide a description that is worded well enough to be understood
One of the URLs that  pornhub extractor collects is matched against /video/get_media. Contents of this page is expected to be json and expected to contain video URLs and their formats. While that URL is still present on the site it doesn't seem to be usually loaded (could it be a trap?)  when playing content. URL is now served as html instead of json and yt-dlp prints a WARNING: Failed to parse JSON: Expecting value in '': line 1 column 1 (char 0).
While users might find that disturbing it still makes it possible to download videos for them. For developers of the extractor that means failing tests.
This code was originally introduced in yt-dlp as 10db0d2f573af31bdaea8e7a010476d896d90f88. Please note that that commit has a typo and it should point to https://github.com/ytdl-org/youtube-dl/commit/7dc513487fb0babb5257fa72df87c3f24967f2a1
I believe there are couple of approaches depending on how you would suggest to gracefully degrade:
a) Completely remove this section without any replacement. Extractor still works for random URL.
b) Replace with a warning of future removal and wait for users to report that they cannot download their content and hope they include this warning.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://www.pornhub.com/view_video.php?viewkey=ph5e79d0527ffae']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.11.11 [8b644025b] (source)
[debug] Lazy loading extractors is disabled
[debug] Plugins: ['SamplePluginIE', 'SamplePluginPP']
[debug] Git HEAD: 7ff2fafe4
[debug] Python 3.10.8 (CPython x86_64 64bit) - Linux-6.0.8-200.fc36.x86_64-x86_64-with-glibc2.35 (OpenSSL 3.0.5 5 Jul 2022, glibc 2.35)
[debug] exe versions: ffmpeg 5.0.1 (setts), ffprobe 5.0.1
[debug] Optional libraries: sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1726 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.11.11, Current version: 2022.11.11
yt-dlp is up to date (2022.11.11)
[debug] [PornHub] Extracting URL: https://www.pornhub.com/view_video.php?viewkey=ph5e79d0527ffae
[PornHub] ph5e79d0527ffae: Downloading pc webpage
[PornHub] ph5e79d0527ffae: Downloading m3u8 information
[PornHub] ph5e79d0527ffae: Downloading m3u8 information
[PornHub] ph5e79d0527ffae: Downloading m3u8 information
[PornHub] ph5e79d0527ffae: Downloading m3u8 information
[PornHub] ph5e79d0527ffae: Downloading JSON metadata
WARNING: [PornHub] ph5e79d0527ffae: Failed to parse JSON: Expecting value in '': line 1 column 1 (char 0)
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] ph5e79d0527ffae: Downloading 1 format(s): hls-1862
[debug] Invoking hlsnative downloader on "https://ev-h.phncdn.com/hls/videos/202003/24/296184861/,1080P_4000K,720P_4000K,480P_2000K,240P_400K,_296184861.mp4.urlset/index-f1-v1-a1.m3u8?validfrom=1669067088&validto=1669074288&ipa=<IP_ADDRESS>&hdl=-1&hash=Qp35ZaSjle09AMm165nQ1x5vKm8%3D"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 248
[download] Destination: This Lego forklift has the power to lift your coronavirus depression [ph5e79d0527ffae].mp4
[download]  73.8% of ~ 226.24MiB at    2.43MiB/s ETA 00:29 (frag 183/248)[download] Got error: The read operation timed out. Retrying (1/10)...
[download] 100% of  229.98MiB in 00:02:03 at 1.86MiB/s
[debug] ffprobe command line: ffprobe -hide_banner -show_format -show_streams -print_format json 'file:This Lego forklift has the power to lift your coronavirus depression [ph5e79d0527ffae].mp4'
[FixupM3u8] Fixing MPEG-TS in MP4 container of "This Lego forklift has the power to lift your coronavirus depression [ph5e79d0527ffae].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:This Lego forklift has the power to lift your coronavirus depression [ph5e79d0527ffae].mp4' -map 0 -dn -ignore_unknown -c copy -f mp4 -bsf:a aac_adtstoasc -movflags +faststart 'file:This Lego forklift has the power to lift your coronavirus depression [ph5e79d0527ffae].temp.mp4'

How confident are you that this code branch no longer works for any URL? If you are reasonably sure, u can remove the branch (in #5617). Otherwise, just add a errnote=False in the _download_json to suppress the warning

How confident are you that this code branch no longer works for any URL? If you are reasonably sure, u can remove the branch (in #5617). Otherwise, just add a errnote=False in the _download_json to suppress the warning

I went through opened/closed issues and tried to download all URLs with pornhub.com. I have tested this only on Fedora Linux and to lower a chance that Pornhub does this per user-agent I used Safari one.
All of those downloads worked and in the end I'm fairly certain so I opened PR #5624.
I'm not able to test this in other geo locations so I hope they don't do this only in Europe.


User and developer should be able to choose the output directory

As a User and as a Developer
I want to be able to choose where do I want the translated files to be stored
Because I don't want to be looking where they have been generated

Up to know, the interface HermesTranslator does not receive any parameters indicating the output directory (directory where the generated ShExC file will be generated) as can be seen here:
https://github.com/weso/hermes/blob/893781a24d68530b16cf6357f35a61e1c2d3a04d/hermes-core/src/main/java/es/weso/hermes/HermesTranslator.java#L33
It is required to modify this interface so that it receives a parameter indicating the output directory.


Binding to sort order

Hi,
I wont to save the sort order in the model list.
Hoe can i do so please?
it is be nice is changing the order of the array...

Hey @yantrab,
At the moment the grid doesn't sort the items at all and stores them in the order that they were originally added to the grid. I'd like to update the cascade functionality to actually have some concept of item order, but I can imagine that being a long way off, I'm afraid. In the mean time, if you bind to the positions of your items, you can sort using a variant of the following:
items.sort((a, b) => {
	if (a.row == b.row) {
		return a.col == b.col ? 0 : (a.col < b.col ? -1 : 1);
	} else {
		return a.row < b.row ? -1 : 1;
	}
});

Hey,
I just bind the id of the first child to the sort prop in the model, and add this:
    onDragStop(item) {
    var id = item._ngEl.nativeElement.children[0].id;
    this.products.filter(a => a.id == id)[0].sort = item._row;
    this.products = this.products.sort(function (a, b) { return (a.sort > b.sort) ? 1 : ((b.sort > a.sort) ? -1 : 0); });
  }

tenks for the great repo!

Hey Ben.
Finally i found the way:

  onDragStop(item) {
    item._ngGrid._items.forEach((e) => {
      var id = e._ngEl.nativeElement.id;
      this.categories.filter(a => a.id == id)[0].sort = e._row;
    });

    this.categories = this.categories.sort(function (a, b) { return (a.sort > b.sort) ? 1 : ((b.sort > a.sort) ? -1 : 0); });
  }

tenks for the great package!

If you wanted to simplify that a bit there's a payload property for the items, meaning you could just do:
  onDragStop(item) {
    item._ngGrid._items.forEach((e) => {
      var id = e.payload;
      this.categories.filter(a => a.id == id)[0].sort = e._row;
    });

    this.categories = this.categories.sort((a, b) => a.sort - b.sort);
  }

Alternatively, there's also an onItemChange in the grid which returns all items after a drag or resize which you could bind to using the following:
  onItemChange(items) {
    items.forEach((item) => {
      this.categories.filter(a => a.id == item.payload)[0].sort = e._row;
    });

    this.categories = this.categories.sort((a, b) => a.sort - b.sort);
  }


[CORE] Review LCD support for PiStorms

It is necessary to add LCD support on PiStorms.
Related question:
https://www.mindsensors.com/forum/topic/258_pistorms-v2-ev3dev-graphics-programming
Related Issue:
https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/69
http://www.ev3dev.org/docs/platform-comparison/

[x] Add the feature in the class LCD.java
[ ] Test on the Brick
[ ] Notify users in the forum

Related issue on ev34j:
https://github.com/ev34j/ev34j/issues/1

I think that this issue requires more research. I will move to next iteration.

https://github.com/ttww/JavaFrameBuffer

https://github.com/ev3dev/ev3dev/issues/961#issuecomment-330002582

This might be solved by the new DIsplay API.

Device with poor support.
Rejected by LEAN


Tags / Releases page don't contain binaries

Hello,
It is mentioned in the README file to use prebuilt binaries for CI. However, the artifacts created with github actions for a specific commit / tag / release are not attached to the release in the releases page.
Therefore, it's currently only possible to use cachepot by installing it via cargo install --git.
Are prebuilt binaries going to be provided soon?

Hey @rakanalh , that's unfortunately correct and we are currently working on getting things in order to get our first release out. It might be a few weeks though until we get all the remaining papercuts resolved.

@drahnr any list of TODO things remaining until release?

@drahnr any list of TODO things remaining until release?

Primarily https://github.com/paritytech/cachepot/issues/89 is a blocker, but not limited to. This is something that would fit better into the discussions section of the project :)


anything like ActionFilterAttribute that applies to async callbacks?

Working on a chat game and I'm having trouble finding anything that can inject into callbacks similar to an ActionFilterAttribute would in MVC/Web API apps.
Use case: a user could be at any phase of a dialog (multiple callbacks deep,) and I'd like one or more commands to be available without having to insert if-statements all over the place. Not sure what's required here.
I found AttributeString that LuisIntentAttribute inherits, but its namespace looks like it might be intentionally named "internal." Not even sure if that's the solution here, since I would need something to consistently intercept a single phrase e.g. inventory which would display the players inventory even if they're in the middle of another dialog.

We generally recommend scorables for pervasive interruption scenarios - for example, here is the DeleteProfileScorable:
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Microsoft.Bot.Builder/Dialogs/DeleteProfileScorable.cs#L49
Sorry for the delay in response - somehow I missed this item.


Result always comes back as "YES"

I followed the directions and it looks like Kaldi and the asr-server are installed correctly, however, whenever I test the API using ether the web interface or uploading a raw file the result is always:
{"status":"ok","data":[{"confidence":0.916982,"text":"YES"}],"interrupted":"endofspeech","time":900}
The actual text is never transcribed.  Where would I start debugging this type of issue?  I tried increasing the verbosity of the asr-server but that didn't really provide any useful output to me of what the issue could be.

I have the same problem.  Maybe 2 out of 20 times it came back with something besides YES or NO.
The recognize_wav script in the Kaldi distrubution under the api.ai egs recipe works great, but it takes 6 seconds to transcribe a 3 second clip.  I've been trying to get that sped up, by compiling with CUDA and MKL, but nothing I have tried has worked.

Always getting YES indicates, that there is something wrong. Most likely you are not using  16kHz, 16 bit little-endian format for wav files.

Hi, thank you for the awesome project!
I am currently facing the same problem but in my case it seems to appear randomly for different files with the same format. Maybe the length of the file may cause this problem.
Any progress in debugging this issue?

Unfortunately I can not help with debugging this. You can try to use vanilla kaldi first using this  https://github.com/kaldi-asr/kaldi/tree/master/egs/apiai_decode/s5 . Then if it does not work ask more active kaldi community for help.


Add request assertion feature to server

Implements #845
The server tracks all handled requests and provides an API to allow
users to check whether a request matching the given parameters has
been made since the server was started.
  server.received.get.to('/contacts', { name: 'Darth Vader' })
  server.didNotReceive.post.to('any');
  server.received.get.to(/\/secrets.*/);
  server.didNotReceive.request.to('/robot/5');
  server.received.put.with({ name: 'Jack' });

I ended up adding RegExp support mostly because it was simpler than adding support for paths like "/posts/:id".
There is also a getter for the last request made to the server:
  server.lastRequest

Comments and suggestions are welcome!

A few other things I'd like to do/consider/I missed:

Add an option to cap the number of requests that the server holds on to
Add support for comparing POST payloads with nested attributes
Have the feature report the number of matching requests instead of a boolean -- might want to rework the DSL a bit if this idea is pursued -- server.received.post.to('/posts') doesn't look like it would return a number

Sorry about delay, hoping to get to this soon.
Just glancing over, will folks want to assert against content type or other things? Should we
assert.ok(this.server.received.post.to('/contacts', {
  with: {
    body: { name: 'Bilbo', age: 111 },
    headers: {
      'ContentType': 'foo'
    }
  })
);

Don't have to change right now, just a quick thought.

I like the idea. I'm on vacation until the 4th, so I won't be able to update the PR until then. Glad to hear any other feedback you may have when you get to it. Thanks!

Few suggestions:

Make _requests public: server.requests. This way folks can inspect during dev, or even use w/their assertions (assert.equal(server.requests.length, 3);)
Move server.lastRequest to server.requests.last (I think you can define a property on the array)
I think the DSL currently doesn't allow server.received.post, right? You have to specify a url? ... thinking about this, I think it's okay.
Originally I said enable only in testing by default, but I think we should enable in all envs by default, and maybe add an option to disable if memory gets out of hand. (We can do this in a new PR).

Great feedback -- I should have time to make those changes tomorrow evening.

All right, this is ready for another peek.
server.received... returns the number of matching requests, while server.didNotReceive returns a boolean. So you can do things like
// Two GETs are made to '/contacts', then...
assert.equal(server.received.get.to('/contacts'), 2);
assert.ok(server.received.get.to('/contacts'));
assert.ok(server.didNotReceive.post.to('/contacts'));

You can assert against any FakeXHR attributes:
assert.ok(server.received.get.to('/contacts', { requestHeaders: { 'Foo': 'Bar' } }));

Also made requests a public property and added a last property.

I think the DSL currently doesn't allow server.received.post, right? You have to specify a url? ... thinking about this, I think it's okay.

I don't see how we could make that syntax work while still allowing further chaining with 'to'. That aside, I did have a mechanism for allowing any URLs but I removed it because I didn't like the API (server.received.request.to('any')), but it could easily be added back in some form.

@samselikoff -- any further changes you'd like to see on this? I can write up some documentation once you give it the 👍

Closing this as stale, but keeping a reference to it in https://github.com/miragejs/miragejs/issues/217 in case we want to reference these APIs.


[BEAM-1401] Allow unbounded windowed PCollections for FileBasedSinks

retest this please

R: @kennknowles

Changes Unknown when pulling d4f7b882c6c9e42d53662ea054c4a16629faadee on reuvenlax:streaming_gcs_output into ** on apache:master**.

Coverage decreased (-0.2%) to 69.15% when pulling 18f48ba51306a2a2a3c7469fee7d61d64320702b on reuvenlax:streaming_gcs_output into 0d639e63d635903df949a09186d1a6f2c0d9b0ae on apache:master.

Coverage decreased (-0.1%) to 69.188% when pulling d474d6d0dd2eb5a13a985d891e92cd9d848930f6 on reuvenlax:streaming_gcs_output into 0d639e63d635903df949a09186d1a6f2c0d9b0ae on apache:master.

Coverage decreased (-0.1%) to 69.188% when pulling d474d6d0dd2eb5a13a985d891e92cd9d848930f6 on reuvenlax:streaming_gcs_output into 0d639e63d635903df949a09186d1a6f2c0d9b0ae on apache:master.

retest this please

retest this please

Coverage decreased (-0.2%) to 69.14% when pulling ba849faaf9ee5ba953ac213c2e182a9f5b473f95 on reuvenlax:streaming_gcs_output into 0d639e63d635903df949a09186d1a6f2c0d9b0ae on apache:master.

Coverage decreased (-0.2%) to 69.137% when pulling c914487b2fb39ed226e91d8cc3244f4168c70097 on reuvenlax:streaming_gcs_output into 0d639e63d635903df949a09186d1a6f2c0d9b0ae on apache:master.

Coverage decreased (-0.2%) to 69.121% when pulling f8616f81a12724d03132ce864640d2442315cb14 on reuvenlax:streaming_gcs_output into 0d639e63d635903df949a09186d1a6f2c0d9b0ae on apache:master.

Coverage decreased (-0.1%) to 69.175% when pulling c437776d38774fe14ab5fabedd9484c9fbbafee3 on reuvenlax:streaming_gcs_output into 2c71354d0a337151fd53dc7eaeace439bcbd41ef on apache:master.

Coverage decreased (-0.1%) to 69.172% when pulling 96b3e64f0bf9766316d4ba99441190750e158908 on reuvenlax:streaming_gcs_output into 2c71354d0a337151fd53dc7eaeace439bcbd41ef on apache:master.

retest this please

Coverage decreased (-0.1%) to 69.196% when pulling 78392fc5d8259410b4657d7a419448e848e16dfb on reuvenlax:streaming_gcs_output into 2c71354d0a337151fd53dc7eaeace439bcbd41ef on apache:master.

Getting this patched up. There's pretty epic conflicts (all easy) due to style guide driven revision.

What's the status of this?
On Thu, Mar 9, 2017 at 9:53 AM, Kenn Knowles<EMAIL_ADDRESS>wrote:

Getting this patched up. There's pretty epic conflicts (all easy) due to
style guide driven revision.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/1926#issuecomment-285427805, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1TJqBbphz-nNbHuachTn8h0FCAsFks5rkDy0gaJpZM4L34x2
.

I took these commits, rebased them and resolved the conflicts and squashed them. I then did a little fixup to use it in the example in a different way. This is all in #2212. I didn't push the tests over the finish line, though the failures look unrelated at first glance. I will be at Strata SJC this week so probably won't make much progress. If you want to push it further I recommend starting from that point (if you follow our contributor guide, this is git reset --hard github/pr/2212) so you don't have to resolve conflicts.

@kennknowles Reset to your PR, and changed the interface to more cleanly separate between the windowed and unwindowed cases.

retest this please

Coverage decreased (-0.1%) to 69.973% when pulling e519c773ee5677fe2151a68656a7215494fbe12d on reuvenlax:streaming_gcs_output into 87c8ef049c6a6cde23bb6ed0948cbe8196e000cf on apache:master.

Coverage decreased (-0.1%) to 70.042% when pulling b683cdf1eb64a1d61a1dd6a7e0287c9b3d00c2b1 on reuvenlax:streaming_gcs_output into 99056df36efccba26f4853912ffca41e12147949 on apache:master.

Coverage decreased (-0.1%) to 70.044% when pulling b683cdf1eb64a1d61a1dd6a7e0287c9b3d00c2b1 on reuvenlax:streaming_gcs_output into 99056df36efccba26f4853912ffca41e12147949 on apache:master.

Coverage increased (+0.04%) to 70.2% when pulling 42f34c5729eb7485c30729e5a7e0d08884556252 on reuvenlax:streaming_gcs_output into 99056df36efccba26f4853912ffca41e12147949 on apache:master.

Changes Unknown when pulling 0bf33e80b57fe4ddbf0eb64b20c878e179130e33 on reuvenlax:streaming_gcs_output into ** on apache:master**.

Coverage decreased (-0.2%) to 69.889% when pulling f02793eaabd1f2ad3029cd8a5066b0c1eb51c253 on reuvenlax:streaming_gcs_output into de36e8398ecb37b9826175c4723f94d127e63d03 on apache:master.

Coverage decreased (-0.2%) to 69.891% when pulling f02793eaabd1f2ad3029cd8a5066b0c1eb51c253 on reuvenlax:streaming_gcs_output into de36e8398ecb37b9826175c4723f94d127e63d03 on apache:master.

I'm thinking of -XX:MaxJavaStackTraceDepth needs to be cranked up or -1 even.

retest this please

Coverage decreased (-0.3%) to 69.888% when pulling 6c60a0eb1ccc0258f4f4e409d10ec77e06198200 on reuvenlax:streaming_gcs_output into de36e8398ecb37b9826175c4723f94d127e63d03 on apache:master.

Coverage decreased (-0.3%) to 69.845% when pulling 6c60a0eb1ccc0258f4f4e409d10ec77e06198200 on reuvenlax:streaming_gcs_output into de36e8398ecb37b9826175c4723f94d127e63d03 on apache:master.

Coverage decreased (-0.3%) to 69.829% when pulling<PHONE_NUMBER>261b555770c46b6581e234da84c169 on reuvenlax:streaming_gcs_output into de36e8398ecb37b9826175c4723f94d127e63d03 on apache:master.

OK LGTM with followups on the way.


Building APK

Does this software only work when a application has been written in Java on Android or can I use any of the development environments in Termux?

pkg up
pkg install aapt apksigner dx ecj findutils git
cd && git clone https://github.com/sdrausty/buildAPKs
./buildAPKs/scripts/build/buildMyFirstAPK.sh

Upon completion, output as follows will print onto the screen:

Your moon.apk was copied to /sdcard/Download/moon.apk
It is ready to be installed.
Install moon.apk from /sdcard/Download

It is a moon clock that depicts the faze of the Moon.
$ ~/buildAPKs/sources/buildAll.sh

$ cat ~/buildAPKs/scripts/maintenance/fa.sh
#!/data/data/com.termux/files/usr/bin/sh -e
# Copyright 2017 (c) all rights reserved
# by S D Rausty https://sdrausty.github.io
# Used to compare attempted builds to actual builds compiled.
#####################################################################
find . -name AndroidManifest.xml > a
find . -name step2.apk > s
cat a s > t
sort t > u
vi a s u

fa.sh can help diagnose attempted builds compared to actually built apps.  You can use wc as well.  Good luck!  Let us know if you have any favorites.


pysonofflan discover: too any open files

pySonoffLAN version: 0.3.0
Python version: Python 2.7.10
Operating System: MacOS

Description
Exception in thread Thread-486:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/threading.py", line 926, in _bootstrap_inner
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/threading.py", line 870, in run
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pysonofflan/discover.py", line 69, in probe_ip
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/socket.py", line 151, in init
OSError: [Errno 24] Too many open files
What I Did
pysonofflan discover

Try increasing the ulimit from it's default value of 256
e.g. ulimit -n 10000


[CI] Update ci-cpu to latest

NOTE: previously ci-cpu was not updated because the break of rust related builds, sync to the latest script in the upstream

cc @mshawcroft @u99127
We stage the docker updates using binary tags https://docs.tvm.ai/contribute/pull_request.html#ci-environment to make sure we can fix the errors during an update while not affecting the rest of the tests(as they run on an old CI image that was stable)


Catch Exception instead of Throwable

This pull request is focused on resolving occurrences of Sonar rule squid:S1181 - “ Throwable and Error should not be caught”. You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1181
Please let me know if you have any questions.
Ayman Abdelghany.

Thank for taking the time to create this pull request.
Unfortunately, I'm going to have to reject it on the basis that although Sonar kicks it out as suspicious it is in there as a Throwable for a specific reason: it is the final error handling code that must catch everything (including Error) and offer the user a chance to upload an error report indicating what went wrong before bombing out.
See http://stackoverflow.com/a/2274116/396747 for further rationale.
Please don't be disheartened by this, we do welcome input of this kind.


UI: Test Data and TEE Data_Export Functionality - Add Year and Quarter columns

For Test Data:
Add Year/Quarter before the Begin Date/Time column  (For both Global and Workspace)
Add the new column Year/Quarter before FuelCode

Pull Request: https://github.com/US-EPA-CAMD/easey-ecmps-ui/pull/1048

Year and Quarter Global

Year and Quarter Workspace

Year and Quarter added to Global and Workspace in Export


python311Packages.azure-synapse-artifacts: 0.17.0 -> 0.18.0

Changelog: https://github.com/Azure/azure-sdk-for-python/blob/azure-synapse-artifacts_0.18.0/sdk/synapse/azure-synapse-artifacts/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 268672 run on x86_64-linux 1

6 packages built:

azure-cli
azure-cli.dist
python310Packages.azure-synapse-artifacts
python310Packages.azure-synapse-artifacts.dist
python311Packages.azure-synapse-artifacts
python311Packages.azure-synapse-artifacts.dist

Result of nixpkgs-review pr 268672 run on x86_64-linux 1

6 packages built:

azure-cli
azure-cli.dist
python310Packages.azure-synapse-artifacts
python310Packages.azure-synapse-artifacts.dist
python311Packages.azure-synapse-artifacts
python311Packages.azure-synapse-artifacts.dist


Db contrib/waltz 4176 surveys

#4176

This pull request introduces 2 alerts and fixes 2 when merging eb652e9bf6d23b68063ea40ca7f0646798f7a21e into 85c024a673283f0f21feefb6fb68913a7aee2602 - view on LGTM.com
new alerts:

2 for Unused variable, import, function or class

fixed alerts:

2 for Use of AngularJS markup in URL-valued attribute

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com


[netcat] Create integration tests for netcat

We initially intended to create integration tests for netcat, however due to issues with CI I've postponed it for now. My current (not working) code can be found here

Fixed by #149


301 redirect loop

There's an easy to reproduce redirect loop:
curl -v https://pypi.org/pypi/Pillow/json
...
HTTP/2 301
...
location: https://pypi.org/pypi/Pillow/json

Visiting this URL in any web browser should explain the problem, if the above description is not clear: https://pypi.org/pypi/Pillow/json

Sorry, duplicate.


Ensure we're not using semantic commits

Ensure we're not using semantic commits for Renovate PRs

Closed in favor of #67


ZeroClipboard breaks IE8 when included

Before I get shouted down an told "We don't support IE8 since v2.0.2", let me explain my situation first.
In our application, I'm happy to let IE8 users suffer a severely degraded experience. However, simply including the ZeroClipboard script on the page (without calling any functions), breaks the scripts (as _defineProperty is not supported).
In our Rails app, assets are bundled together, so a failure in one script will fail the entire script. The effect for us is that IE8 users have NO Javascript.
While it's fine to remove support for IE8 and below, my preference would be to avoid breaking the browser if someone does include the script for IE8 users.
Some options I'd like to put forward:

If the user is running an unsupported browser, do nothing; or
Wrap function calls like _defineProperty in a try/catch block; or
Delay global function calls until a ZeroClipboard object is initialised. This would at least allow including the script in an unsupported browser and would only fail once new ZeroClipboard was called.

Point well taken. I'll have to do a review of all the ES5.1 and DOM Level 2+ features we're leveraging to see what makes the most sense.
Ideally, I think the API should appear usable but be emitting a new error event, e.g. error[name = "browser-unsupported"].

I have patched my local version of ZeroClipboard and can confirm that changing:
  _defineProperty(ZeroClipboard, "version", {
    value: "2.2.0",
    writable: false,
    configurable: true,
    enumerable: true
  });

to
  ZeroClipboard.version = "2.2.0"

fixes the issue and avoid breaking IE8. To test for IE8 before calling the ZeroClipboard constructor, I have simply used if (document.addEventListener === undefined) { return; }

The fix will be forthcoming in the next release. Thanks!


Expensify card - Clicking back from issue cards RHP takes to wrong page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.13-0
Reproducible in staging?:* Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Navigate to staging.new.expensify.com
Create a workspace
Enable Expensify Cards on more features for that workspace
Go to members page on workspace
Select on one member
Click on New card
Click on the back icon twice

Expected Result:
The app navigates user back to the workspace members page
Actual Result:
The app navigates user to the wrong page which is Expensify card page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/f7476321-0a4d-4592-b254-14f07beb29d9
View all open jobs on GitHub

We think that this bug might be related to #wave-collect - Release 2

@kevinksullivan I believe all the Expensify Card in NewDot stuff is still in beta, is that right? Trying to see if this should really be a blocker.

Discussed 1:1, this project is still in implementation phase with multiple open issues open. Going to recategorize as internal since I believe it's being taken care of by agency contributors, but feel free to change labels if needed.

@Gonals I would imagine this can be tracked in https://github.com/orgs/Expensify/projects/155

added to the project it'll be taken care of soon

Thanks!

will be addressed asap

Not overdue, we will tackle this, the project is behind beta

I'm working on it

PR opened https://github.com/Expensify/App/pull/47844

This is done


Toast prevent from pressing button event if it's hidden

I have button positionned at the bottom, and when show the toast, and then hide it, I can't press on the Button.
With element inspector I found that event if Toast is hidden, it's still one the screen. I tried to set an elevation for the button higher than the toast, not working
Any ideas ?
Tried on snack, there's no problem, but on IOS simulator, it's not working
https://snack.expo.io/@simbasnack/nativebase?&preview=true&platform=ios&iframeId=fr2udn44xn&theme=light

Hi, @MarcHbb , we found no such issue. We are able to press Button whether Toast is visible or not on iOS simulator as well. Can you explain more and provide few more details like version?

It's happening to me as well.
The Toast disappears, but it stills cover the area where it used to be.

@crava-logico-srl Can you share a code snippet that causes the issue for you. As we couldn't reproduce this from the earlier expo code.

@crava-logico-srl Can you share a code snippet that causes the issue for you. As we couldn't reproduce this from the earlier expo code.


Render arxiv Preprints as HTML

What
Render arxiv preprints as HTML by integrating with https://ar5iv.labs.arxiv.org/ or similar alternative.
The above is an alternative / supplement to PDF extraction. Our PDF extraction mechanism has the following issues

Formulas and equations do not extract properly. These typically render as odd unicode characters.
Figures such as graphs and images do not extract properly.

The above issues lead to bad UX and reduced confidence in the content of the paper. Due to this, many users leave ResearchHub and read the paper externally. As a result, we turned off the PDF extraction.
The ar5iv project can allow us to render preprints as HTML which can help add a lot of value to RH given that arxiv does not offer good reading UX. In addition, rendering content as HTML will help us achieve inline highlighting.
Acceptance Criteria

Visiting a paper page which includes a PDF should render the PDF content as HTML
Mathematical equations and figures should render properly

Important

There is an endpoint pdf_extract in paper/views which fetches extracted content.

Hi. I am interested to take up the work. Before doing that, I wanted to check on how the bounty works ? What is the bounty amount, how shall you pay for the same and how to ensure that payment shall happen once work is completed .


Bundler not finding 1.7.1 nokogiri

Our app was using
gem 'nokogiri', '~> 1.6.8'

and today I had to update nokogiri to resolve
Name: nokogiri
Version: <IP_ADDRESS>
Advisory: CVE-2016-4658
Criticality: Unknown
URL: https://github.com/sparklemotion/nokogiri/issues/1615
Title: Nokogiri gem contains several vulnerabilities in libxml2 and libxslt
Solution: upgrade to >= 1.7.1

Vulnerabilities found!

when I tried bundle update nokogiri with gem 'nokogiri,
it installed <IP_ADDRESS> which is not what I need
I tried specifying version from what was listed rubygems.org,
gem 'nokogiri', '~> 1.7', '>= 1.7.1' and this threw me
Bundler could not find compatible versions for gem "nokogiri":
  In Gemfile:
    nokogiri (>= 1.7.1, ~> 1.7)

    anemone was resolved to 0.7.2, which depends on
      nokogiri (>= 1.3.0)

    haml-rails was resolved to 0.9.0, which depends on
      html2haml (>= 1.0.1) was resolved to 2.0.0, which depends on
        nokogiri (~> 1.6.0)

    quickbooks-ruby (~> 0.4.2) was resolved to 0.4.6, which depends on
      nokogiri

I tried the installation tutorial and troubleshooting guide and
it correctly installs the latest version of nokogiri(1.7.1) when I run gem install nokogiri
I also noticed that if I run bundle update
it does install nokogiri (1.7.1) but I need to stay away from updating all other gems just to have nokogiri update to required version.
Should I also include Gemfile.lock for reference?

Hi @caseykim, we are running into the same issue right now, did you manage to resolve it? If so how?

@kamalalteris I had to replace the nokogiri version in the Gemfile.lock file

@srmeile thank you!


Failed with: quic-go doesn't build on Go 1.18 yet.

xcaddy: from development branch
go version go1.18 linux/amd64
The same issue as it was in 4216
xcaddy successfully compiled, but command xcaddy list-modules failed with error on following:
go/pkg/mod/github.com/lucas-clemente/quic-go@v0.23.0/internal/qtls/go118.go:5:13: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration

The latest stable version of Caddy was released before Go 1.18 was released, so it doesn't support it. We made fixes on the master branch to support Go 1.18, so if you absolutely need to build with 1.18, you should build from master for now. Otherwise, please downgrade to 1.17 in the meantime until Caddy's next stable release.

If you build with docker and can't easily downgrade your go version, caddy:2.4.1-builder worked fine


Docker build failing with "failed to adjust OOM score for shim"

My company uses summerwind/actions-runner-controller to handle self-hosted runners for our deployment workflow. Our main reason for doing this is that our database lives in a private-IP Cloud SQL instance, and we want knex database migrations to run as part of the workflow.

We have two runners set up-- one deploys to a development environment, and the other deploys to production. The production runner continues to work, even though it was installed and set up in exactly the same way. The only differences between the two as are in GCP project names and whether the run on push to master or on release creation.
 I'm sort of at my wits end with this and would appreciate some assistance. :)
Installed with:
kubectl apply -f https://github.com/summerwind/actions-runner-controller/releases/v0.13.1/download/actions-runner-controller.yaml

Runner manifest:
apiVersion: actions.summerwind.dev/v1alpha1
kind: Runner
metadata:
  name: development-runner
spec:
  repository: Batterii/api
  image: summerwind/actions-runner:v2.274.2
  labels:
    - vurvey-development-cluster
  env: []
  volumes:
    - name: secret-volume
      secret:
        secretName: deployer-api-service-account-key
  sidecarContainers:
    - name: cloud-sql-proxy
      image: gcr.io/cloudsql-docker/gce-proxy:1.17
      command:
        - "/cloud_sql_proxy"
        - "-ip_address_types=PRIVATE"
        - "-instances=vurvey-development:us-central1:vurvey-development-postgres=tcp:5432"
        - "-credential_file=/secrets/service-account-key.json"
      securityContext:
        runAsNonRoot: true
      volumeMounts:
        - name: secret-volume
          mountPath: /secrets/
          readOnly: true

Deployment workflow:
name: Deploy to api.vurvey.dev
on:
  push:
    branches:
    - master
jobs:
  deploy:
    runs-on: [self-hosted, vurvey-development-cluster]
    steps:
    - name: Checkout
      uses: actions/checkout@v2

    - name: Set up node and npm
      uses: actions/setup-node@v1
      with:
        node-version: 12.x
        registry-url: https://registry.npmjs.org

    - name: Connect npm cache
      uses: actions/cache@v2
      env:
        cache-name: npm-cache
      with:
        # npm cache files are stored in `~/.npm` on Linux/macOS
        path: ~/.npm
        key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
        restore-keys: |
          ${{ runner.os }}-build-${{ env.cache-name }}-
          ${{ runner.os }}-build-
          ${{ runner.os }}-

    # Skipping post-install scripts so they can't steal NODE_AUTH_TOKEN.
    - name: Install dependencies
      run: npm ci --ignore-scripts
      env:
        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

    # Running post-install scripts, now without the NODE_AUTH_TOKEN set.
    - name: Run post-install scripts
      run: npm rebuild && npm run prepare --if-present

    - name: Build the dist directory
      run: npm run build

    - name: Build the docker image
      run: |-
        docker build . \
          --tag gcr.io/vurvey-development/batterii-api:$GITHUB_SHA \
          --build-arg NPM_TOKEN=${{ secrets.NPM_TOKEN }}

    - name: Set up gcloud
      uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
      with:
        version: '290.0.1'
        project_id: vurvey-development
        service_account_key: ${{ secrets.DEV_DEPLOYER_KEY }}
        export_default_credentials: true

    - name: Configure glcoud as docker credential helper
      run: gcloud auth configure-docker

    - name: Push the docker image to the project's container registry
      run: docker push gcr.io/vurvey-development/batterii-api:$GITHUB_SHA

    - name: Set up kubectl
      uses: azure/setup-kubectl@v1
      with:
        version: 'v1.19.3'

    - name: Set up kustomize
      uses: imranismail/setup-kustomize@v1
      with:
        version: '3.1.0'

    - name: Get GKE credentials
      run: |-
        gcloud container clusters get-credentials "vurvey-development-cluster" \
          --zone "us-central1-c"

    - name: Run any new database migrations
      run: npm run migrate
      env:
        DB_USER: postgres
        DB_PASS: ${{ secrets.DEV_DB_PASSWORD }}
        DB_NAME: vurvey

    - name: Rollout GKE changes
      working-directory: gke/development
      run: |-
        kustomize edit set image API_IMAGE=gcr.io/vurvey-development/batterii-api:$GITHUB_SHA
        kustomize build . | kubectl apply -f -

    - name: Wait on rollout to finish in deployments.
      run: |-
        kubectl rollout status deployment api-deployment
        kubectl rollout status deployment mailer-deployment
        kubectl rollout status deployment image-transcoder-deployment
        kubectl rollout status deployment video-transcoder-deployment

Dockerfile:
FROM node:12 as build
ARG NPM_TOKEN
WORKDIR /build
COPY dist package.json package-lock.json ./
RUN chown node:node /build
USER node
RUN echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc && \
	npm ci --prod && \
	rm -f .npmrc

FROM node:12
RUN apt-get update && apt-get install -y ffmpeg
WORKDIR /usr/local/src/vurvey-api/
COPY --from=build --chown=root:root /build ./
USER node
ENTRYPOINT ["node"]
CMD ["bin/batterii-api.js"]

For your runner, try adding cpu/memory requests/limits

Just for anybody who comes across this issue.
Setting a resource limit worked. I'll be honest that I'm not 100% sure why, as by not having a limit I was under the impression that all resources could be consumed, but anyway that fixed the issue.

Happy to hear of a fix, though I actually ended up replacing these runners with something more simple set up directly in a GCE machine. This works fine for our use case (for now) since we are only doing builds a couple times a day at most.
If and w hen we grow and need to scale more easily, this will definitely be the first solution I come back to, though. Thanks for the help! :+1:

For your runner, try adding cpu/memory requests/limits

How do you specify that in the Runner spec above? Thanks.


Provide artifacts without JDK naming scheme

Sorry if that was discussed before. But the naming scheme makes upgrading painful. For example: we are currently depending on the -jdk15on artifacts as that is what our dependencies depend on (we are using maven, btw). So without manual work we are stuck at 1.70 as that was the last version with that naming scheme. Later releases use -jdk18on as is documented on the homepage.
Without that naming scheme we could just update the managed version and our transitive dependencies would also pull the updated artifact. Easy and also the standard maven way of managing complex dependencies.
But today if we want to upgrade we have to exclude the -jdk15on dependencies (from all our dependencies, there is no way to do that globally!) and introduce -jdk18on dependencies at the appropriate places of our build. At the time of writing our main product consists of nearly 300 artifacts and each of those has to be checked. Of course we are using tools like the maven-enforcer-plugin but that is still a big overhead to manage.
And in a couple of years  when BC moves to e.g. jdk-11 as a base we have to review everything again.
As BC is security critical that is especially annoying as just using an older version is clearly not an option.
So I propose to create additional artifacts without a JDK version suffix. Those would always be the latest JDK base (so bcprov-1.78.jar would be identical to bcprov-jdk18on-1.78.jar today).
Also, I am not sure if artifacts with JDK specific names have any advantages at all. Because at build time there will be  a compile error anyway - either because the artifact does not exist (as today) or because there is a bytecode version mismatch. And swapping binaries in installed programs would also just give a class loading error.

This has never come up, probably because previously it was such a rare event, but I'll admit I see your point. One of the issues with jdk15on to jdk18on was we couldn't use the maven redirect as it did depend on what people were doing as to whether jdk18on was the right choice of jdk15to18on was.
If anyone else feels like weighing in feel free, for the moment I'll ponder it.

IMHO this is a major annoyance and I'm surprised it hasn't come up before.
There's probably a gazillion projects out there still using old versions and even duplicate jars due to some libraries using jdk15on and others jdk18on.
So yes, I'm all in favor of eliminating this problem.

Sorry, bad wording. What I meant was that projects are having both jars on the classpath, which is even more of a problem when they are not duplicates. Often, projects will end up with different versions if they don't carefully manage their dependencies (which, of course one should, but...).

Bump :)
@dghgit did you come to a conclusion yet?


Installation error

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

React: 16.14.0
ReactDOM/React Native:
Redux:4.0.5
React Redux:

What is the current behavior?
View the react Redux source code through the warehouse.
An error is reported when installing the official master warehouse

What is the expected behavior?
normal setup
Which browser and OS are affected by this issue?
No response
Did this work in previous versions of React Redux?

[ ] Yes

This isn't an issue with React Redux.


Replace flat file system with DB

Replace the flat file system with database.

Mongo
PostgreSQL

So you guys did decide to move away from a flat file system.  Fun.
Just as a note:  Postgres doesn't work well on windows (do we have any windows devs??). (MySQL does though)

None of the project leads are here, but Gudrun K is interested in making this happen so I opened up the issue for discussion and gave her the greenlight.

Hi guys.
Sorry for not tuning in earlier. Holiday cheers started at Kokoszka family with arrival of grandma.
Regarding db to choose, let me know what you decide on. MySQL is fine with me too.
By the way, ever thought about using something other than a db or flat file system ? How about Apache Kafka - a distributed commit log supporting steaming ?
Suggested approach for modern application development is to "unbundle the database".
If realtime updates are of interest facilitated by change data capture, precomputed data similar to materialized views as well as ease of subscription to data services, Apache Kafka might just fit the bill. Interesting read is "Making Sense of Stream Processing" from Confluent.
Making_Sense_of_Stream_Processing_Confluent_1.pdf
Some sample code can be found here: https://scotch.io/tutorials/build-a-distributed-streaming-system-with-apache-kafka-and-python.
For implementation what resources are actually made available for this on heroku from our stakeholders ?  And if we do operate on a zero budget what disk space as well as memory can be made available for free ?
Gudrun

Heroku gives us a good amount for free, I wouldn't bet on solutions that cost money long term. (@JordanMajd can correct me if I'm wrong - I usually am)
I know it's been a few weeks since I've dropped in.  But the data is the very opposite of real-time, we're dealing with government records which are updated on a yearly bases.  If anything, we should take the data, move it into a DB once, then use the DB for easier querying of the records.  (I assume that's why you moved away from flat file)

So we narrowed it down to mysql or mongodb it appears. Both have community editions - one is a relational db the other a nosql db.

Why are you wanting to move it from a flat file system? What are the current issues you are having, and how can a DB of any sort help resolve them? Once you know why you are moving the data, determining which type of DB should become easier.
Cost wise, all three things mentioned have a free tier on heroku.
Postgres (free):
https://elements.heroku.com/addons/heroku-postgresql
Mongo (free):
https://elements.heroku.com/addons/mongolab
Karafka (free - beta):
https://elements.heroku.com/addons/cloudkarafka

I agree. The initial reason for proposing moving away from a flat file
system is to allow for a faster website startup.
It would allow for precomputed values as well as a more flexible data
schema going forward.
Generally it appears response time needs to be improved. However, a more in
depth analysis of causes may need to be done.
On Sun, Dec 17, 2017 at 11:14 PM, Matthew Harris<EMAIL_ADDRESS>wrote:

Why are you wanting to move it from a flat file system? What are the
current issues you are having, and how can a DB of any sort help resolve
them? Once you know why you are moving the data, determining which type of
DB should become easier.
Cost wise, all three things mentioned have a free tier on heroku.
Postgres (free):
https://elements.heroku.com/addons/heroku-postgresql
Mongo (free):
https://elements.heroku.com/addons/mongolab
Karafka (free - beta):
https://elements.heroku.com/addons/cloudkarafka
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CodeForFoco/CERP-backend/issues/30#issuecomment-352335278,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgfsCADI6tFh33123oszc7yM5TX7Hrp-ks5tBgKsgaJpZM4RC6HO
.

--
Gudrun Kokoszka
Email<EMAIL_ADDRESS>Cell:<PHONE_NUMBER>

Hi everyone
Response time is up. Since switchover to db or other does not bring any
needed benefits at this point given response heard so far
please consider the suggested request on my part removed. Let me know how
else one could contribute ? At the moment I think I am just starting to
build the app from instructions provided. For the uninitiated a bit
incomplete....so probably will start with this.
Happy Holidays
Gudrun
On Mon, Dec 18, 2017 at 9:31 AM, Gudrun Kokoszka<EMAIL_ADDRESS>wrote:

I agree. The initial reason for proposing moving away from a flat file
system is to allow for a faster website startup.
It would allow for precomputed values as well as a more flexible data
schema going forward.
Generally it appears response time needs to be improved. However, a more
in depth analysis of causes may need to be done.
On Sun, Dec 17, 2017 at 11:14 PM, Matthew Harris<EMAIL_ADDRESS>
wrote:

Why are you wanting to move it from a flat file system? What are the
current issues you are having, and how can a DB of any sort help resolve
them? Once you know why you are moving the data, determining which type of
DB should become easier.
Cost wise, all three things mentioned have a free tier on heroku.
Postgres (free):
https://elements.heroku.com/addons/heroku-postgresql
Mongo (free):
https://elements.heroku.com/addons/mongolab
Karafka (free - beta):
https://elements.heroku.com/addons/cloudkarafka
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CodeForFoco/CERP-backend/issues/30#issuecomment-352335278,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgfsCADI6tFh33123oszc7yM5TX7Hrp-ks5tBgKsgaJpZM4RC6HO
.

--
Gudrun Kokoszka
Email<EMAIL_ADDRESS>Cell:<PHONE_NUMBER> <(970)%20581-5577>

--
Gudrun Kokoszka
Email<EMAIL_ADDRESS>Cell:<PHONE_NUMBER>


Pass 0 instead of null to preg_match()

Q
A

Documentation
no

Bugfix
yes

BC Break
no

New Feature
no

RFC
no

QA
no

Description
The $flags parameter of preg_match() should be an integer, but DocBlockScanner passes null when calling the method. PHP 8.1 will be stricter about that and trigger a deprecation warning. This PR proposes to pass 0 instead, which is the actual default value of that parameter.

LGTM, but beware that this library does not allow installation with 8.1
yet, so that will be a question for ~ october, when the first RC releases
can be verified
On Sat, Jun 5, 2021, 11:51 Alexander M. Turek @.***>
wrote:

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no Description
The $flags parameter of preg_match() should be an integer, but
DocBlockScanner passes null when calling the method. PHP 8.1 will be
stricter about that and trigger a deprecation warning. This PR proposes to
pass 0 instead, which is the actual default value of that parameter.
You can view, comment on, or merge this pull request online at:
https://github.com/laminas/laminas-code/pull/87
Commit Summary

Pass 0 instead of null to preg_match()

File Changes

M src/Scanner/DocBlockScanner.php
https://github.com/laminas/laminas-code/pull/87/files#diff-c4c83894994b99bcf34e5afcb09abac8d8b0213812beb0ea7df64f0645ebfbbe
(2)

Patch Links:

https://github.com/laminas/laminas-code/pull/87.patch
https://github.com/laminas/laminas-code/pull/87.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/laminas/laminas-code/pull/87, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABFVEDCLQM3ZZSQJY65DG3TRHXTLANCNFSM46EK5FIA
.

Thanks @derrabus!


FEA add a ConstantThresholdClassifier instead of strategy="constant"

As discussed with @jeremiedbb, let's try to make a specific estimator for the constant case.
TODO:

[x] need to move strategy test to testing ConstantThresholdClassifier
[x] rewrite documentation for the constant case with new changes.

Alternative name FixedThresholdClassifier, not sure which one is better

Merging. Now I'll try to manage the remaining comment regarding pos_label.


feat: Add Twilio Verify API Integration for OTP and 2FA (POC, DNM)

Which Problems Are Solved
Twilio supports a robust, multi-channel verification service that notably supports multi-region SMS sender numbers required for our use case. Currently, Zitadel does much of the work of the Twilio Verify (eg. localization, code generation, messaging) but doesn't support the pool of sender numbers that Twilio Verify does.
How the Problems Are Solved
To support this API, we need to be able to store the Twilio Service ID and send that in a verification request where appropriate: phone number verification and SMS 2FA code paths.
This PR does the following:

Adds the ability to use Twilio Verify of standard messaging through Twilio

Adds support for international numbers and more reliable verification messages sent from multiple numbers

Adds a new Twilio configuration option to support Twilio Verify in the admin console

Sends verification SMS messages through Twilio Verify

Provides guide for how to implement Twilio Verification Checks

[ ] Call Twilio Verify endpoint to confirm verification code in human_user_otp.go where we use VerifyTOTP

Additional Changes
Additional Context
This is a POC and not necessarily how we expect to ship this feature. Notably, we highjacked the current SMS-entity persistence and API patterns, but it might make more sense to split this into a new notification integration entirely that stands alone from the existing Twilio integration. There are a variety of other settings that could be configured by the end user that we may want to support in the future (like custom message and code generation preferences), but not required for MVP.

closing this as it is implemented in #8678


Encoder calibration current ramp-up

When odrive is used by a little bit heavier machines, the calibration can be complicated. Making the motor calibrate reliable requires calibration current close to the motor's limit. However, the open loop control established by calibration instantly ties the rotor to the origin phase angle.
I would suggest that there should be a short current ramping-up sequence for all open-loop controlled parts of the calibration process (motor winding and encoder offset calibration).

This is implemented as part of #472: https://github.com/madcowswe/ODrive/blob/89f07226549312a7e311cae823d7cc0f15a8ae5f/Firmware/MotorControl/encoder.cpp#L225-L227
Half a second is allocated for the current to ramp up and an additional half of a second is allocated for the motor to snap to the zero-position.


Explore ways how to make Electron adoptions less painful

Upgrading Electron is currently more difficult than we would like. The August release is a great illustration of the issues we can encounter, we were still on v1.6.6 which was done in the May release so we were jumping ahead several months worth of versions. We had previously done some testing in v1.7.x and found that there was a debug-related regression (https://github.com/electron/electron/issues/9696) which was only fixed in v1.7.4.
Here's roughly what happened:

Upgraded Insiders to use Electron v1.7.4
Upgraded Insiders to use Electron v1.7.5 when it became available
After several days on v1.7.5 we discovered that closing VS Code actually crashed it on Windows (#10188), this regressed in v1.7.4 which was required due to the debug regression
We built Electron v1.7.3 with the fix for the debug regression backported

Maybe we could have caught these issues sooner, or even better have reported upstream and got them fixed faster.
One idea we've been throwing around is to set up a branch that upgrades it's Electron version and then CI builds and runs our test suites. This would encourage us to build out the smoke test suite. When and who would start testing these new versions, ie. when does it land in Insiders?
We should also try accepting new patch Electron versions more aggressively (1.6.6 -> 1.6.latest) as these should be lower risk updates.

/cc @bpasero

New release process we came up with: https://github.com/electron/electron/pull/10558
The main idea I was pushing for was moving to SemVer and making minor and patch versions as low risk as possible to update.


What is the situation of the Privacy Sandbox on Android?

@n-aggarwal brought up this good point.

Is it already implemented?
Can people opt out?
How does it work?

Here is a starting point.

“Privacy Sandbox will introduce new technology that operates without cross-app identifiers – including Advertising ID. This helps apps remain free through ads while your data stays protected.” Privacy Sandbox
Here is the GitHub for Privacy Sandbox: https://github.com/privacysandbox ; might be a good idea to keep an eye on it.
Here is an overview of Topics API and its implementation. The big idea here is that the API intends to provide callers with coarse-grained advertising topics of interest based on the user's app usage, which can then be used by the apps to show relevant ads.
Here is an overview of Fledge API and its implementation. The big idea here is custom audience targeting. The Audience information is stored on-device and can be associated with relevant candidate ads for the audience and arbitrary metadata, such as bidding signals.
At the bottom of both the Topics and Fledge API pages, the user side control overview is given. It seems that they are going to make it harder, reduce usability as users would have to go into Topics API and Fledge API settings separately and then disable them. I am not sure even if there will be a “clear all interests” or a similar button; from what I am reading it might be a tedious one by one deletion process.
There seem to be two early release programs— beta (for user side testing) and Developer program (for developer side testing). Both the beta and developer program require the client to sign up in order to participate. It might be beneficial to enroll into these programs to see the upcoming changes.
Google also seems to have started beta testing for Privacy Sandbox on the user side for a small number of phones with android 13.  As of right now, there doesn't seem to be any Privacy Sandbox for android 14 which is being released in August this year.


Where is the segementaion json file for demonstration

Hi, I'm trying to replay the demo with action primitive, but in the code, it needs the JSON file path to Path of the segmentation of the demo.
Can you please let me know where can i find these files?

This issue is not completed.


python3Packages.spacy_models: add updateScript

Description of changes

Adds an update script to update all spacy models and updates all models to 3.4.0 using the update script.
Closes #186217
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build python310Packages.spacy_models

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1178

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1843


Add tintColor support

it is very usefull when show icon in navigation header

Yes, please add a tint color. It is very useful for images.


Parts remain allocate to a completed sales order after a return order and back to stock.

Please verify that this bug has NOT been raised before.

[X] I checked and didn't find a similar issue

Describe the bug*
Hi all, thanks for your amazing job,
Here is the situation.
I have some serialized parts which has been assigned to a sale order for a client. Sales is done and shipment completed.
then the parts were returned to our facility so, after creating a return order, assigned to parts, complete the return order and assigned the parts back to stock.
Now I need to assign this part to a new sale order, but the part is currently locked as it is still assign to the first sale order. Even if it is now back to my stock.
Steps to Reproduce

assigne a serialized part to a sale order
complete shipment and sail order
create a return order for this part
complete the return order and return the item back to stock
change the status of the part to "ok" as it is in "quarantine"
create a new sale order and try to allocate the part.
check in stock and see that this specific part is still allocate to the first sale order created.

Expected behaviour
Once bake to stock, we should keep in the history this part was shipped and returned, but it should be available again to a new order.
Deployment Method

[X] Docker
[ ] Bare metal

Version Information
Version Information:
InvenTree-Version: 0.13.5
Django Version: 3.2.23
Commit Hash: 0804ecf
Commit Date: 2024-02-05
Database: postgresql
Debug-Mode: False
Deployed using Docker: True
Platform: Linux-4.19.0-25-cloud-amd64-x86_64-with
Installer: DOC
Active plugins: [{'name': 'InvenTreeBarcode', 'slug': 'inventreebarcode', 'version': '2.0.0'}, {'name': 'InvenTreeCoreNotificationsPlugin', 'slug': 'inventreecorenotificationsplugin', 'version': '1.0.0'}, {'name': 'InvenTreeCurrencyExchange', 'slug': 'inventreecurrencyexchange', 'version': '1.0.0'}, {'name': 'InvenTreeLabel', 'slug': 'inventreelabel', 'version': '1.0.0'}, {'name': 'InvenTreeLabelSheet', 'slug': 'inventreelabelsheet', 'version': '1.0.0'}, {'name': 'DigiKeyPlugin', 'slug': 'digikeyplugin', 'version': '1.0.0'}, {'name': 'LCSCPlugin', 'slug': 'lcscplugin', 'version': '1.0.0'}, {'name': 'MouserPlugin', 'slug': 'mouserplugin', 'version': '1.0.0'}, {'name': 'TMEPlugin', 'slug': 'tmeplugin', 'version': '1.0.0'}]
Please verify if you can reproduce this bug on the demo site.

[ ] I can reproduce this bug on the demo site.

Relevant log output
No response

Related issue: https://github.com/inventree/InvenTree/issues/4590

I have another comment, but might need a new bug or feature request.
For items not serialized it is not possible to assign them to a return order. It would be nice to be able to assign the same way we can do it in the sale order. Also when the client have more than one of the same item we cannot return to stock only part of them. Either all of them or none. Being able to use the return order to return a certain number of not serialized item would be a great plus.
Thanks again for your great job.

@SchrodingersGat It seems this is not a problem anymore.
I had the issue with a previous version of inventree. I Updated to the last version and the issue was still here. But probably because I did the return order before the update. I had to do a new return order with the new version and everything seems ok. Sorry for that. You can probably close this issue.

Thanks for reporting back @Mimosa-oceanis


Made some refactor, fix some bugs

Hi Michael,
I found out and fixed the bug that caused the serious performance of filtering logs.
Please review and merge my PR, thanks :)
Alex

thanks! :beers:


Firebase_Auth, PhoneVerificationFailed is triggered with 'Invalid token' when using phone auth on iOS 13.5.1

Describe the bug
Using firebase_auth version 0.16.1, the phone_auth on iOS 13.5.1 keeps failing all the time (Using iPhone 7 with development certificate). The PhoneVerificationFailed is triggered with the error message invalid token along with code verifyPhoneNumberError.  I also see this error in XCode:
Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service

It seems to be trying to open up the Recaptcha. But that should not be the case.
This only occurs on iOS. Works as expected on debug Android builds.
To Reproduce
Steps to reproduce the behavior:
Run the following code:
await FirebaseAuth.instance.verifyPhoneNumber(
        phoneNumber: phoneNumber,
        codeAutoRetrievalTimeout: autoRetrieve,
        codeSent: smsCodeSent,
        timeout: const Duration(seconds: 5),
        verificationCompleted: verifiedSuccess,
        verificationFailed: verificationFailed);
  }

The following method gets triggered:
   final PhoneVerificationFailed verificationFailed =
        (AuthException exception) {
      print("exception ${exception.message}");
    };

Expected behavior
The device should be able to receive the text message with the code.
Additional context
What I have tried:

Tried adding the APNS auth key under the cloud messaging tab in the Firebase console. Same result.

Tried adding the APNS development certificate (p12) under the cloud messaging tab in the Firebase console. Same result.

I have the background mode and push notification enabled on the Runner project as well.

Flutter doctor
Run flutter doctor and paste the output below:
[✓] Flutter (Channel stable, v1.17.3, on Mac OS X 10.15.4 19E287, locale en-US)
    • Flutter version 1.17.3 at /Users/test/flutter/flutter
    • Framework revision b041144f83 (7 days ago), 2020-06-04 09:26:11 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/test/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] Connected device (1 available)
    • Test’s iPhone • xxxxxxxxxxxxxxxxxx • ios • iOS 13.5.1

! Doctor found issues in 1 category.

Am I missing something here? Thanks!

Hi @pkhivesara
Calling recapach from AppDelegate , i can receive the code
    PhoneAuthProvider.provider().verifyPhoneNumber("your phone number", uiDelegate: nil) { (verificationID, error) in
      if let error = error {
//        self.showMessagePrompt(error.localizedDescription)
        print(error)
        return
      }
      // Sign in using the verificationID and the code sent to the user
      // ...

        // Change language code to french.
        Auth.auth().languageCode = "inr";
        UserDefaults.standard.set(verificationID, forKey: "authVerificationID")
        let verificationID = UserDefaults.standard.string(forKey: "authVerificationID")
        print(verificationID)
    }

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-0.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-0.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision d9653445f4 (6 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10 (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.5.1
    • macOS         • macOS                     • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome 83.0.4103.97

• No issues found!