'Linear4bit' object has no attribute 'compute_dtype'

System Info
Instance: T4 (Colab)
Occured while running the example notebook bnb-4bit-training-with-inference.ipynb forQLora training.
Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction
Error occured while running the notebook bnb-4bit-training-with-inference.ipynb on free T4 colab instance.
lora_config = LoraConfig.from_pretrained('outputs')
peft_model = get_peft_model(model, lora_config)

AttributeError                            Traceback (most recent call last)
[<ipython-input-11-30f3e82a4451>](https://localhost:8080/#) in <cell line: 2>()
      1 lora_config = LoraConfig.from_pretrained('outputs')
----> 2 peft_model = get_peft_model(model, lora_config)

8 frames
[/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py](https://localhost:8080/#) in __getattr__(self, name)
   1693             if name in modules:
   1694                 return modules[name]
-> 1695         raise AttributeError(f"'{type(self).__name__}' object has no attribute '{name}'")
   1696
   1697     def __setattr__(self, name: str, value: Union[Tensor, 'Module']) -> None:

AttributeError: 'Linear4bit' object has no attribute 'compute_dtype'

Expected behavior
the model successfully loaded.

Hi @d1pankarmedhi
Thanks for the issue, can you paste the full traceback of the error? Also how do you load the base model?
Can you also try to run that script with the latest version of bitsandbytes ? pip install -U bitsandbytes

Hi @d1pankarmedhi Thanks for the issue, can you paste the full traceback of the error? Also how do you load the base model? Can you also try to run that script with the latest version of bitsandbytes ? pip install -U bitsandbytes

same issue here, bitsandbytes 0.41.2.post2

Can you share a full reproducer of the issue? ideally with a small snippet

Been having the same issue.
The complete traceback for the code.
`AttributeError                            Traceback (most recent call last)
[<ipython-input-10-fba3e7b63116>](https://localhost:8080/#) in <cell line: 2>()
      1 lora_config = LoraConfig.from_pretrained('outputs')
----> 2 model = get_peft_model(model, lora_config)

8 frames
[/usr/local/lib/python3.10/dist-packages/peft/mapping.py](https://localhost:8080/#) in get_peft_model(model, peft_config, adapter_name, mixed)
    131     if peft_config.is_prompt_learning:
    132         peft_config = _prepare_prompt_learning_config(peft_config, model_config)
--> 133     return MODEL_TYPE_TO_PEFT_MODEL_MAPPING[peft_config.task_type](model, peft_config, adapter_name=adapter_name)
    134
    135

[/usr/local/lib/python3.10/dist-packages/peft/peft_model.py](https://localhost:8080/#) in __init__(self, model, peft_config, adapter_name)
   1039
   1040     def __init__(self, model: torch.nn.Module, peft_config: PeftConfig, adapter_name: str = "default") -> None:
-> 1041         super().__init__(model, peft_config, adapter_name)
   1042         self.base_model_prepare_inputs_for_generation = self.base_model.prepare_inputs_for_generation
   1043

[/usr/local/lib/python3.10/dist-packages/peft/peft_model.py](https://localhost:8080/#) in __init__(self, model, peft_config, adapter_name)
    121             self._peft_config = None
    122             cls = PEFT_TYPE_TO_MODEL_MAPPING[peft_config.peft_type]
--> 123             self.base_model = cls(model, {adapter_name: peft_config}, adapter_name)
    124             self.set_additional_trainable_modules(peft_config, adapter_name)
    125

[/usr/local/lib/python3.10/dist-packages/peft/tuners/lora/model.py](https://localhost:8080/#) in __init__(self, model, config, adapter_name)
    117
    118     def __init__(self, model, config, adapter_name) -> None:
--> 119         super().__init__(model, config, adapter_name)
    120
    121     def _check_new_adapter_config(self, config: LoraConfig) -> None:

[/usr/local/lib/python3.10/dist-packages/peft/tuners/tuners_utils.py](https://localhost:8080/#) in __init__(self, model, peft_config, adapter_name)
     93             self.config = {"model_type": "custom"}
     94
---> 95         self.inject_adapter(self.model, adapter_name)
     96
     97         # Copy the peft_config in the injected model.

[/usr/local/lib/python3.10/dist-packages/peft/tuners/tuners_utils.py](https://localhost:8080/#) in inject_adapter(self, model, adapter_name)
    250                 "current_key": key,
    251             }
--> 252             self._create_and_replace(peft_config, adapter_name, target, target_name, parent, **optional_kwargs)
    253
    254         if not is_target_modules_in_base_model:

[/usr/local/lib/python3.10/dist-packages/peft/tuners/lora/model.py](https://localhost:8080/#) in _create_and_replace(self, lora_config, adapter_name, target, target_name, parent, current_key, **optional_kwargs)
    198             )
    199         else:
--> 200             new_module = self._create_new_module(lora_config, adapter_name, target, **kwargs)
    201             if adapter_name != self.active_adapter:
    202                 # adding an additional adapter: it is not automatically trainable

[/usr/local/lib/python3.10/dist-packages/peft/tuners/lora/model.py](https://localhost:8080/#) in _create_new_module(lora_config, adapter_name, target, **kwargs)
    284             fourbit_kwargs.update(
    285                 {
--> 286                     "compute_dtype": target.compute_dtype,
    287                     "compress_statistics": target.weight.compress_statistics,
    288                     "quant_type": target.weight.quant_type,

[/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py](https://localhost:8080/#) in __getattr__(self, name)
   1693             if name in modules:
   1694                 return modules[name]
-> 1695         raise AttributeError(f"'{type(self).__name__}' object has no attribute '{name}'")
   1696
   1697     def __setattr__(self, name: str, value: Union[Tensor, 'Module']) -> None:

AttributeError: 'Linear4bit' object has no attribute 'compute_dtype'

This is an issue where the bnb dependency upstream. Try doing this as a interim solution until a new bitsandbytes>0.41.3
! pip install git+https://github.com/TimDettmers/bitsandbytes.git

Here's a working example https://colab.research.google.com/drive/1u22vX37cCYNKjtI9bkgz-LmaqEVjVOJv?usp=sharing

Hi everyone,
bnb recently release the 0.41.3 version which should fix the bug, can you try:
pip install -U bitsandbytes

cc @Titus-von-Koeller
In case this does not fix your issue, can you try to reproduce the issue with a small snippet, e.g. the script below:
from transformers import AutoModelForCausalLM
from peft import LoraConfig, get_peft_model

model_id = "facebook/opt-350m"
model = AutoModelForCausalLM.from_pretrained(model_id, load_in_4bit=True)

lora_config = LoraConfig(
    r=8,
    peft_type="CAUSAL_LM"
)

model = get_peft_model(model, lora_config)

Works fine for me

Yeah, I could verify with bnb-4bit-training-with-inference.ipynb - Colab, as provided by @d1pankarmedhi in his issue description, that:

bitsandbytes 0.41.2.post2 reproduces the bug
bitsandbytes==0.41.3 fixes the bug

This was likely caused by @poedator 's recent 4-bit serialization refactor for which we just merged and released his recent follow-up PR, which seems to fix this.
Thanks everyone for raising this and thanks @poedator for the useful refactor.

Yeah, I could verify with bnb-4bit-training-with-inference.ipynb - Colab, as provided by @d1pankarmedhi in his issue description, that:

bitsandbytes 0.41.2.post2 reproduces the bug
bitsandbytes==0.41.3 fixes the bug

This was likely caused by @poedator 's recent 4-bit serialization refactor for which we just merged and released his recent follow-up PR, which seems to fix this.
Thanks everyone for raising this and thanks @poedator for the useful refactor.

Hi, I upgraded to bitsandbyte 0.41.3 but my code still cannot work, the error was the same "'Linear4bit' object has no attribute 'compute_dtype'", I have tried restart kernel, uninstall and install but all failed.

Hi, @pod2c, thank you for testing!
I tried to run your example in Colab, but it went OOM.
So I went with a smaller model mrsteyk/openchatgpt-neox-125m and was able to reproduce the error.
https://colab.research.google.com/drive/1Pu190aLnw9WHkGgfjdPsMIFgq0FU9fv5
Then I tested it locally on A100 with bnb==0.41.3 and observed no error.
Let me try to figure out what goes wring in Colab. Suggestions welcome.

Hi, @pod2c, thank you for testing! I tried to run your example in Colab, but it went OOM. So I went with a smaller model mrsteyk/openchatgpt-neox-125m and was able to reproduce the error. https://colab.research.google.com/drive/1Pu190aLnw9WHkGgfjdPsMIFgq0FU9fv5
I tested the packages versions and it appears that the error happens with peft==0.7.0 It was not happening with peft==0.6.2 and 0.6.0
Then I tested older bnb releases and found that the error still happens with bitsandbytes==0.40.2 and 0.41.1. So this issue seems to be related not to my recent quantization PRs but rather to something on PEFT side. @Titus-von-Koeller what do you think?

Hi, thank you for helping! I have tried peft 0.6.2 and it worked.

@younesbelkada I think we have to reopen this, due to @poedator's comment. It would be good to cook up a minimal example of the issue and validate

I tested the packages versions and it appears that the error happens with peft==0.7.0
It was not happening with peft==0.6.2 and 0.6.0

Then I tested older bnb releases and found that the error still happens with bitsandbytes==0.40.2 and 0.41.1. So this issue seems to be related not to my recent quantization PRs but rather to something on PEFT side.

I won't have time to look at this right away, so if this is urgent, happy if someone else takes the lead.

What's strange is that I could reproduce the issue and then it went away with the bnb version change. It's true however, that I didn't pin the PEFT version, but that was within minutes of each other (so would have expected them to be the same). This needs further verification.

Hi, maybe I'm out of the loop, but when I ran the notebook, I saw there was a mistake where the model is loaded as:
model = get_peft_model(model, lora_config)

First of all, the model should be loaded using PeftModel.from_pretrained, second, the model that is being passed should be the base model, not the PEFT model. So when I make this change, the notebook runs for me:
- model = get_peft_model(model, lora_config)
+ base_model = AutoModelForCausalLM.from_pretrained(model_id, quantization_config=bnb_config, device_map={"":0})
+ peft_model = PeftModel.from_pretrained(base_model, <PATH>)

If this used to work with an older PEFT version, it was almost surely not doing what the intent was.

I think we should fix the notebook source code then, since this is the entrypoint of many new users to using BNB.
@younesbelkada, do you know where the NB source code is hosted? I couldn't find it in the bnb or qlora repos.


Add semistandard as a dependency

Thanks @dizcology for reporting!

Edit: talked with @jmdobry offline. This tool isn't 100% specific to Node.js, so I'm closing this PR for now.


Tekton functionality

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign larsks after the PR has been reviewed.
You can assign the PR to them by writing /assign @larsks in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
7e9351c15c9f3fcbc31a733ee53884a41f408e3f
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ah, I've just noticed this is a follow up PR to #9, next time please share that information in PR description as "Depends on: #pr_number", so.. discard my comments on the app.ts, that should be a review on #9.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
6fdd1ae583d528e1a653c6428c920b89c3fa1a72
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
6fdd1ae583d528e1a653c6428c920b89c3fa1a72
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
9996d0f38e316c2a289cc911ea07b918c68aa83d
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
073582a7c0d69b8bbbd7f96af0b57b76e4808da5
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
7d4683a98fe60c69e8546b259f81ce320316e5b6
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
56766f0f77080143cf50a48a72319c660ccb3033
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
3bab0771714f24f733e96bd36a89354aa528c5e3
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssala23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

pre-commit
0d0e6413d85a2c8a84d668ed185aa48ebe677570
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: larsks
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [larsks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@larsks can I get a lgtm tag on this PR

@tumido Can this PR get a lgtm tag?

Can someone share the original issue that this PR addresses?

Can someone share the original issue that this PR addresses?

@Gregory-Pereira I don't think there is a one this was part of basic functionality which was created in PR #9 and this one

I found an internal google doc which I think describes the issue. If we do plan on continuing with open source collaborators to this project, then we should make a public facing issue with that same information. After all the point of a PR is to address an issue / bug, implement new functionality, or preform maintenance tasks on a repo.

@tssala23 can you please squash these commits.


CoreValidation: dynamicStateCount not checked to be greater than zero

The spec of the field VkPipelineDynamicStateCreateInfo::dynamicStateCount states:

dynamicStateCount must be greater than 0

The core validation layer does not give an error when setting this field to zero to indicate that a pipeline has no dynamic state, even though one should set the VkGraphicsPipelineCreateInfo::pDynamicState field to NULL instead:

pDynamicState is a pointer to VkPipelineDynamicStateCreateInfo and is used to indicate which properties of the pipeline state object are dynamic and can be changed independently of the pipeline state. This can be NULL, which means no state in the pipeline is considered dynamic.

Sorry, my mistake. The parameter validation layer does check for this case.


implement a "deis pull" test

So the three main mechanisms of buildpack, dockerfile, and deis pull are all tested. Currently this test is marked Pending.

This is actually the main workflow under test currently, so I'm closing this.


Fix some deprecation warnings on the unsafe_test_runner/stable code

compare_and_swap got deprecated last year. WriteExecute also renamed WRITE_EXECUTE, probably to match libc. Whatever.

Closing as subsumed under #30


Incomplete messages issue

Pixhawk connected with raspi through ttyS0 port
My raspi connected to wifi and transmit information to AWS cloud
My laptop running Qgroundcontrol and also connect with the AWS server
My QGC use Mavlink-router 1 (telem 1) baudrate 57600
I use this command line: mavlink-routerd -p <IP_ADDRESS>:5760 /dev/ttyS0:57600
Then i got this reply:

mavlink-router version v4
Error while trying to write serial port latency on /dev/ttyS0: Operation not permitted
Opened UART [4]alpha: /dev/ttyS0
UART [4]alpha: speed = 57600
Error while trying to write serial port latency on /dev/ttyS0: Operation not permitted
Opened UART [5]CLI: /dev/ttyS0
UART [5]CLI: speed = 57600
Opened UDP Client [6]charlie: <IP_ADDRESS>:5760
Opened UDP Server [8]bravo: <IP_ADDRESS>:5760
9 Error connecting to <IP_ADDRESS>:5760 (Connection refused)
Could not open <IP_ADDRESS>:5760, re-trying every 5 sec
10 Error connecting to <IP_ADDRESS>:5760 (Connection refused)
Could not open <IP_ADDRESS>:5760, re-trying every 5 sec
Opened TCP Server [11] [::]:5760
Opened TCP Client [13]delta: <IP_ADDRESS>:5760
TCP [9]dynamic: Connection accepted
Opened TCP Client [14]CLI: <IP_ADDRESS>:5760
UART Endpoint [5]CLI: 94 incomplete messages in the last 5 seconds
TCP [10]dynamic: Connection accepted
UART Endpoint [4]alpha: 57 incomplete messages in the last 5 seconds
UART Endpoint [4]alpha: 98 incomplete messages in the last 5 seconds
TCP [15]dynamic: Connection accepted
UART Endpoint [4]alpha: 141 incomplete messages in the last 5 seconds
UART Endpoint [5]CLI: 2 incomplete messages in the last 5 second

Thanks in advance
Sorry for any misinformation, im quite new to raspi and pixhawk.

I'm quite curious how your config file (/etc/mavlink-router/main.conf) looks like. Because it seems like you also have some configuration in there, which leads to two endpoints on the same UART device and doesn't work.
(I really recommend to configure everything in the config file. This way you can use the provided systemd unit file as it is to let mavlink-router run as a service.)

I'm quite curious how your config file (/etc/mavlink-router/main.conf) looks like. Because it seems like you also have some configuration in there, which leads to two endpoints on the same UART device and doesn't work.
(I really recommend to configure everything in the config file. This way you can use the provided systemd unit file as it is to let mavlink-router run as a service.)

[UartEndpoint alpha]
Device = /dev/ttyS0
Baud = 57600
[UdpEndpoint bravo]
Mode = Server
Address = <IP_ADDRESS>
Port = 5760
[UdpEndpoint charlie]
Mode = Normal
Address = <IP_ADDRESS>
Port = 5760
[TcpEndpoint delta]
Address = <IP_ADDRESS>
Port = 5760

Here my etc/mavlink-router/main.conf
Thanks for your help

Two points:

If you have a UART endpoint in the config file you can't use the same device in the CLI options
Your UDP and TCP endpoints don't make sense. You have an UDP endpoint (bravo) listening on <IP_ADDRESS>:5760, but also one (charlie) sending to this port via localhost (<IP_ADDRESS>:5760). So this is your first message loop. But you also try to open a TCP connection to port 5760 where UDP endpoint "bravo" is listening.

We encountered the same issue. We established the connection between the QGC and the RPi through the default TCP port, but no data was transmitted. In our case, it was because we were using RPi zero, and it didn't have enough RAM or other weird issues, but when  we switched to raspberry pi 4 and did everything again, it worked, and QGC and RPi4 could connect seamlessly with MAVlink data transmitted between the two.

Two points:

If you have a UART endpoint in the config file you can't use the same device in the CLI options
Your UDP and TCP endpoints don't make sense. You have an UDP endpoint (bravo) listening on <IP_ADDRESS>:5760, but also one (charlie) sending to this port via localhost (<IP_ADDRESS>:5760). So this is your first message loop. But you also try to open a TCP connection to port 5760 where UDP endpoint "bravo" is listening.

I would recommend to have a config file like this (and not use any endpoints in the CLI params):
[UartEndpoint pixhawk]
Device = /dev/ttyS0
Baud = 57600

[TcpEndpoint aws]
Address = <ip of AWS endpoint>
Port = <port of AWS endpoint>

Or do you have some "bridge" application on your Raspi? Then use a TCP or UDP endpoint to send to that code and it will upload the data to AWS.

My aws ip address require an aws.pem key to authentical. Because of that i can't access to our sever. Therefore to access sever i have to ssh to AWS server both my Laptop and the raspberrypi. So how should i configurate my main.conf. I tried to use this config
[UartEndpoint pixhawk] Device = /dev/ttyS0 Baud = 57600 [TcpEndpoint aws] Address = <IP_ADDRESS> Port = 5760
here is the reply:
dronepi@raspberrypi:/etc/mavlink-router $ sudo mavlink-routerd mavlink-router version v4 Opened UART [4]pixhawk: /dev/ttyS0 UART [4]pixhawk: speed = 57600 5 Error connecting to <IP_ADDRESS>:5760 (Connection refused) Could not open <IP_ADDRESS>:5760, re-trying every 5 sec Opened TCP Server [6] [::]:5760 Opened TCP Client [8]aws: <IP_ADDRESS>:5760 TCP [5]dynamic: Connection accepted 6 messages to unknown endpoints in the last 5 seconds 12 messages to unknown endpoints in the last 5 seconds TCP [9]dynamic: Connection accepted 2 messages to unknown endpoints in the last 5 seconds
I see TCP [9]dynamic: Connection accepted but i can't see my qgc stay disconnected and can't received any data.
Thanks for your help

We encountered the same issue. We established the connection between the QGC and the RPi through the default TCP port, but no data was transmitted. In our case, it was because we were using RPi zero, and it didn't have enough RAM or other weird issues, but when we switched to raspberry pi 4 and did everything again, it worked, and QGC and RPi4 could connect seamlessly with MAVlink data transmitted between the two.
What was your setup in raspi and pc, i can use dev/TTYACM0 and also have a good connection between QGC and my Pi but my teacher require me to use dev/TTYS0 and im really struggle with it.
Really appreciate your replied

We encountered the same issue. We established the connection between the QGC and the RPi through the default TCP port, but no data was transmitted. In our case, it was because we were using RPi zero, and it didn't have enough RAM or other weird issues, but when we switched to raspberry pi 4 and did everything again, it worked, and QGC and RPi4 could connect seamlessly with MAVlink data transmitted between the two.

What was your setup in raspi and pc, i can use dev/TTYACM0 and also have a good connection between QGC and my Pi but my teacher require me to use dev/TTYS0 and im really struggle with it.
Really appreciate your replied


Fix tokenEndpoint

Domain was added twice

Can you create a changeset?
https://github.com/pilcrowOnPaper/arctic/blob/main/CONTRIBUTING.md

@pilcrowOnPaper Done, let me know if that works

Thanks!


add resource-intensive attr to 4-node tests

See CASSANDRA-12415. followup to #1204

+1

Cheers, merging.


Add TravisCI integration

Since we have tests now, it would be great to add a Travis CI integration with badge and PR check.

Hey! Any chance to do that soon? Would be cool to have a CI step, keeping in mind the recent count of PRs.


PDF font choice missing many useful characters

Roboto is missing useful characters, many unicode sub and superscripts. Another font would make the generated Tarsia puzzles more suitable for scientific and mathematical puzzles.

Thanks for the suggestion. I don't have much time to work on the generator at the moment so it's unlikely I'll get to that any time soon unfortunately.
If I do find time, any suggestions for a better font?


add example dapp

Need to add an exampl dapp that shows how this library is used with  Starknet + React

Yo man, I literally now See your Issue and I'm sending you an example of the code for a simple Starknet+React decentralized voting application( Following this General code Steps You can Solve Your problem) :
Smart Contract (VotingContract.cairo):
VotingContract.cairo
var votes : map(eoa : felt) => felt
function init() -> pass
public function vote(candidate : felt) -> ():
self.votes[eoa()] += candidate
pass
public function getVotes() -> (votes : felt) :
votes := self.votes[eoa()]
React App Components (src/App.js):
import React, { useState } from 'react';
import { StarkWareProvider } from '@starkware/starkware-provider';
function App() {
const [candidate, setCandidate] = useState(0);
const [voteStatus, setVoteStatus] = useState('');
const handleVote = async (starkProvider) => {
try {
const contract = starkProvider.getContract('<CONTRACT_ADDRESS>');
const tx = await contract.vote(candidate);
await tx.waitReceipt();
setVoteStatus('Vote successful!');
} catch (error) {
console.error('Error voting:', error.message);
setVoteStatus('Error voting. Check console for details.');
}
};
return (

Voting App

Choose candidate:
<input
type="number"
value={candidate}
onChange={(e) => setCandidate(parseInt(e.target.value))}
/>

Vote
{voteStatus}

);
}
export default App;
Using this Codes, Be safe of :
Write the Cairo smart contract (VotingContract.cairo),compile the contract using the StarkWare compiler,deploy the compiled contract to the Starknet testnet,set up a React app with the @starkware/starkware-provider library,create a simple UI to allow users to vote for a candidate, connect the React app to the Starknet testnet by providing necessary StarkNet node endpoint, contract address, and key information and run the React app and interact with the Starknet-powered voting dApp.
Finalli replace placeholders like <CONTRACT_ADDRESS>, <STARKNET_NODE_ENDPOINT>, <YOUR_STARK_PUBLIC_KEY>, and <YOUR_STARK_PRIVATE_KEY> with your actual contract address, StarkNet node endpoint, and key information.
I hope that this guide will be Helpful for you. If you Have any Questions, Don't be scared and text me :).
Have A nice day :)


Partial put - enhance content range verification

per rfc 9110 - 14.4

ContentRange - add isValid(), more length check.
ContentRange - parse(): make sure the not-null return of parse() is valid.
force content-range unit in lowercase internally.
TestDefaultServletPut - cover issues by adding 2 sets of parameters.

-1
Other that the lower case range, the shuffling around of the checks introduces a much more serious bug (&& length > end).

Ok, that's correct, the end is also inclusive.


Add opt-in for nightly builds using update_fastlane(nightly: true)

Make it easy for people that use update_fastlane to opt-into nightly fastlane builds
Tell people about how to enable it
Thank people for using it

Nightly builds not enabled yet

Enabled nightly builds

Context: we're already automatically shipping nightly builds: https://rubygems.org/gems/fastlane

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

Tests:

Name
File

Spaceship::Tunes::IAPDetail modification saved with changed versions
iap_detail_spec.rb

Spaceship::Tunes::IAPFamilyList IAP FamilyDetail can change versions
iap_family_details_spec.rb

  Generated by :no_entry_sign: Danger

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

Tests:

Name
File

Spaceship::Tunes::IAPDetail modification saved with changed versions
iap_detail_spec.rb

Spaceship::Tunes::IAPFamilyList IAP FamilyDetail can change versions
iap_family_details_spec.rb

  Generated by :no_entry_sign: Danger

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

Tests:

Name
File

Spaceship::Tunes::IAPDetail modification saved with changed versions
iap_detail_spec.rb

Spaceship::Tunes::IAPFamilyList IAP FamilyDetail can change versions
iap_family_details_spec.rb

  Generated by :no_entry_sign: Danger

Fixed tests, did some more testing, ready to merge from my side 👍


IE11 svg-paint is massively slower than in 0.7.3

Paint-times in IE11 are much slower than 0.7.3, when using thousands of  elements, because for every change to a path the whole svg-hierarchy is relayouted and repainted.
If I add a single group to the  and add all the pathes in there it works perfectly.

While this is a weird bug, I don't think there's anything wrong with putting a <g> around the <path> elements, as this allows some degree of encapsulation to the SVG that may prove useful later / to the end developer (other SVG elements may be included alongside the paths).

Yeah, I think we can add g back for both VML and SVG.


[Feature] record http status codes >= 300

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
As for now, all http status codes < 400 will not be recorded.
#5327 was closed because status code 200 is usually not of interest to users.
However, status codes such as 301, 302, etc., which imply redirections, belong to a different class than 2xx, and users may be interested in them.
Maybe we should record status >= 300 instead of status >= 400
Use case
No response
Related issues
#5327
Are you willing to submit a pull request to implement this on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sorry to say, different people have different use cases.
3xx, e.g. 302, is not a special case for many people. If you want to build metrics for it, please fo ahead to use OAL, and aggregate at OAP side.


Run tests with HOMEBREW_DEVELOPER unset.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

@reitermarkus What's the motivation; just better clean up the code?

What's the motivation

Yeah, just code cleanup.


Add support for excel files with patients in columns

Typical supplemental files can have patients in columns or in rows....

The notebooks now sow how to do this by transposing a dateframe


SCSS breakup

Hi @vjeantet, @W-Floyd,
Here's SCSS broken up into logical parts. Tried to keep as few commits as possible. Technically resulted CSS should be doing the same, just order of CSS rules have changed. For example #sidebar has it's own file, because it got so many rules.
There's definitely more to do depending on ambitions, but this should cover foreseeable groundwork to start actually improving things without breaking whole page.
As far I checked, it looks good and clear, let me know if you find any regressions.

Cool, thanks for going over this!
I'll test shortly.

Not that it matters, but do the SCSS files need to be in the static folder? Seeing as browsers can't do anything with them natively.

Nothing I'm seeing that's broken, and everything is better than how I had it before.
Might be considered nitpicking , but$main_link_color might be better placed in _colours.scss. Though currently mapped to $side_back_color, that assumes the side is a solid colour and the main background is light. I often have it mapped to its own colour (when running a dark theme), so keeping it with the other primary colours might be useful.
But everything looks good to me!

Hi @W-Floyd, sorry for the delay, a lot of work to do. Just feeling like I am missing a reply.
Yes, sure there's a lot to improve, especially, there are a lot of variables, which can make custom styling a little pitty. This was just to kick-off code layout to do that.
Even though SCSS can do complicated styles and layouts with ease, I believe, the goal would that it is possible to create a custom colour theme with simple theme-custom.css setting only bg, line, border and foreground colours for grouped classes etc. There is something already, but together with SCSS, it is not very transparent. Again, it could be huge work, but very rewarding in long-term.


Jesse: Watch vod.bluejeans.com

Jesse requests the watch of the watch_keyword vod\.bluejeans\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vod\.bluejeans\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


RPC methods should exclude Jinja comments from compiled SQL

Describe the bug
The compile_sql and run_sql methods of dbt rpc currently include Jinja comments {# #} in their compiled SQL.
Steps To Reproduce

Run an RPC server per docs

Send a request (method compile_sql or run_sql) where the SQL contains a Jinja comment

{
    "jsonrpc": "2.0",
    "method": "compile_sql",
    "id": "2db9a2fe-9a39-41ef-828c-25e04dd6b07d",
    "params": {
        "timeout": 60,
        "sql": "c2VsZWN0IHsjIDEgKyAxICN9IGFzIGlkCg==",
        "name": "my_first_query"
    }
}

Poll for result

...
"raw_sql": "select {# 1 + 1 #} as id\n",
"compiled_sql": "select {# 1 + 1 #} as id\n",
...

Expected behavior
"raw_sql": "select {# 1 + 1 #} as id\n",
"compiled_sql": "select  as id\n",

The output of dbt --version:
$ dbt --version
installed version: 0.17.1-rc4
   latest version: 0.17.0

Your version of dbt is ahead of the latest release!

Plugins:
  - bigquery: 0.17.1rc4
  - snowflake: 0.17.1rc4
  - redshift: 0.17.1rc4
  - postgres: 0.17.1rc4

I missed this until just now, but this is in fact the same as #2707 - closing as it's fixed by #2718


Kueue workloads admitted but jobs remain suspended

What happened:
Kueue workloads correctly show admission, but jobs remain suspended and no pods are created.
What you expected to happen:
Job should be unsuspended, and pod created to begin work.
How to reproduce it (as minimally and precisely as possible):
My nodes are labeled individually to match my ResourceFlavor labels:
kubectl label nodes node1 flavor-label=flavor-label-1
kubectl label nodes node2 flavor-label=flavor-label-2
kubectl label nodes node3 flavor-label=flavor-label-3
kubectl label nodes node4 flavor-label=flavor-label-4

resourcelabels.yaml
apiVersion: kueue.x-k8s.io/v1alpha2
kind: ResourceFlavor
metadata:
  name: flavor-1
  labels:
    flavor-label: flavor-label-1
---
apiVersion: kueue.x-k8s.io/v1alpha2
kind: ResourceFlavor
metadata:
  name: flavor-2
  labels:
    flavor-label: flavor-label-2
---
apiVersion: kueue.x-k8s.io/v1alpha2
kind: ResourceFlavor
metadata:
  name: flavor-3
  labels:
    flavor-label: flavor-label-3
---
apiVersion: kueue.x-k8s.io/v1alpha2
kind: ResourceFlavor
metadata:
  name: flavor-4
  labels:
    flavor-label: flavor-label-4

ClusterQueue references the same resource flavors, and includes resource limits.
clusterqueues.yaml
apiVersion: kueue.x-k8s.io/v1alpha2
kind: ClusterQueue
metadata:
  name: shared-clusterqueue
spec:
  cohort: my-cohort
  namespaceSelector: {}
  queueingStrategy: BestEffortFIFO
  resources:
  - name: "cpu"
    flavors:
    - name: flavor-1
      quota:
        min: "1.15"
    - name: flavor-2
      quota:
        min: "2"
    - name: flavor-3
      quota:
        min: "2"
    - name: flavor-4
      quota:
        min: "2"
---
apiVersion: kueue.x-k8s.io/v1alpha2
kind: LocalQueue
metadata:
  namespace: default
  name: shared-queue
spec:
  clusterQueue: shared-clusterqueue

1.1-job.yaml
apiVersion: batch/v1
kind: Job
metadata:
  generateName: job-1.1-
  annotations:
    kueue.x-k8s.io/queue-name: shared-queue
spec:
  backoffLimit: 0
  parallelism: 1
  completions: 1
  suspend: true
  template:
    spec:
      containers:
      - name: dummy-job
        image: gcr.io/k8s-staging-perf-tests/sleep:latest
        args: ["3600s"]
        resources:
          requests:
            cpu: 1.1
      restartPolicy: Never

Anything else we need to know?:
Notes: I have attempted to simplify my setup a little bit by only including one resource type, though we are hoping to use both CPU and memory constraints.
Environment:

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.2", GitCommit:"8b5a19147530eaac9476b0ab82980b4088bbc1b2", GitTreeState:"clean", BuildDate:"2021-09-15T21:38:50Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}

Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.6", GitCommit:"f59f5c2fda36e4036b49ec027e556a15456108f0", GitTreeState:"clean", BuildDate:"2022-01-19T17:26:47Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}

Kueue version (use git describe --tags --dirty --always):
kubectl describe -n kueue-system deployment.apps/kueue-controller-manager:

  Containers:
   manager:
    Image:      gcr.io/k8s-staging-kueue/kueue:v0.2.1

Cloud provider or hardware configuration:
On-prem cluster including 4 identical VMs.  Each has 2 CPUs and 15.5G RAM
OS (e.g: cat /etc/os-release):
CentOS 7.9.2009 Core
Kernel (e.g. uname -a):
I don't have direct access to the host machines, but if more details are relevant here I will work to get them.
Install tools:
Others:

Apologies, I forgot to include my log findings in the original report!  I'm a little new at this, obviously.
The first sign of trouble in the kueue controller logs comes after the "CreatedWorkload" event is logged:
"caller":"scheduler/scheduler.go:353",
"msg":"Could not admit workload and assigning flavors in apiserver",
"workload":{"name":"job-1.1-5v4q7","namespace":"default"},
"clusterQueue":{"name":"shared-clusterqueue"},
"error":"Incorrect version specified in apply patch. Specified patch version: , expected: kueue.x-k8s.io/v1alpha2"

Next the workload is re-queued, followed by "Workload successfully admitted and assigned flavors".
Trouble begins again when the controller attempts to reconcile the workload after admission:
"caller":"job/job_controller.go:191",
"msg":"Unsuspending job",
"controller":"job",
"controllerGroup":"batch",
"controllerKind":"Job",
"job":{"name":"job-1.1-5v4q7","namespace":"default"},
"namespace":"default",
"name":"job-1.1-5v4q7",
"reconcileID":"a67d8f03-46c5-422c-90e7-f579101af06e",
"job":{"name":"job-1.1-5v4q7","namespace":"default"},
"error":"Job.batch \"job-1.1-5v4q7\" is invalid: spec.template: Invalid value:
core.PodTemplateSpec{<<full spec definition removed for brevity>>}: field is immutable",
"stacktrace":"sigs.k8s.io/kueue/pkg/controller/workload/job.(*JobReconciler).Reconcile\n\t/workspace/pkg/controller/workload/job/job_controller.go:191\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:320\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:234"}

Kernel (e.g. uname -a):
[kglenn@apcvlp02399 ~]$ uname -a
Linux apcvlp02399 3.10.0-1160.31.1.el7.x86_64 #1 SMP Thu Jun 10 13:32:12 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
[kglenn@apcvlp02399 ~]$

Next the workload is re-queued, followed by "Workload successfully admitted and assigned flavors".

It looks like the first problem is transitory. Still, I think it shouldn't happen. I'll try to debug further.
The second problem seems to be because the feature JobMutableNodeSchedulingDirectives is disabled. This is expected in a 1.22 cluster, where the feature is alpha. Either upgrade to 1.23 or enable JobMutableNodeSchedulingDirectives.

Thank you for your attention on this.  An update to k8s 1.23 appears to have resolved the issue in our testing.


Cluster Labels

Hey guys,
first of all thanks for the excellent work! The amount of data you provide is really on another level.
I recently downloaded most of the data myself, but was curious about one thing: Can you provide the original n-centroid labels i.e., for the audio/visual clusters?
I only found the download .csv files with the youtube-ids but not the corresponding cluster ids for most samples.
Did I miss something?
Kind regards,
Heinrich

Hi!
First of all, we are sorry that we no longer have access to the intermediate cluster labels.
With that said, I will leave some quick reminders to check we are on the same page.

The cluster labels are not necessary for the downstream usage of our dataset.
While we show in the paper that some clusters align with human semantics, we do not recommend using them for downstream tasks.

If necessary, you can use our feature extraction -> clustering code on the downloaded videos to get cluster labels. However, these new labels would not be the same as the original labels since the original clusters are computed on the uncurated set of videos.
Just in case you are also looking for ways to videos given the csv files, I suggest using the following library.
https://github.com/iejMac/video2dataset/blob/main/dataset_examples/ACAV.md

Hey @JiwanChung ,
thanks for the quick answer !

The cluster labels are not necessary for the downstream usage of our dataset.

Yeah, we are on the same page, I was aware that these labels are only an "intermediate" output of your method.

While we show in the paper that some clusters align with human semantics, we do not recommend using the cluster labels for the downstream tasks.

Yeah, I agree that they might not align with human semantics.
My initial thought here was simply to check if a "self-supervised" version of my pretrained models using ACAV100M are better than models trained on the cluster_id.
Since my compute is far more limited than yours, I can't imagine possibly computing embeddings, storing them and then running a clustering algorithm :(.

If necessary, you can use our feature extraction -> clustering code on the downloaded videos to get cluster labels. However, these new labels would not be the same as the original labels since the original clusters are computed on the uncurated set of videos.

Alright, thanks for the info!
I close the issue, thanks again for clarification!


Implement missing PrimaryKey trait for CanonicalAddr

The cw_storage_plus Map requires PrimaryKey implementation for its keys, which is implemented for Addr but not CanonicalAddr. However, CanonicalAddr are stable and unique and keys should be stored using that type instead of Addr.

Workaround is using addr.as_bytes() for the key.
In fact, you should never use CannonicalAddr as a key, but rather &CanonicalAddr, it is more efficient and does the same work. The only reason we support Addr in addition to &Addr was for backwards compatibility to not randomly break some older contracts.


Cmd Showing That scrcpy.server.jar is pushed but phone is not mirrored.

Device Used - Samsung Galaxy s8
OS- Mac

adb logcat

Any related error?
What if you reduce the definition:
scrcpy -m1024

?

adb logcat

Any related error?
What if you reduce the definition:
scrcpy -m1024

?

It doesn't work . on further debugging , i realised that whenever i run "scrcpy" , my device got disconnected. Following are the images for the same. Left Side is "adb logcat" . Right side is terminal . As soon as i executed "scrcpy" command my device got disconnected

Try with another USB cable or use another USB slot. See #281 #283.


Use SharedInformer

https://github.com/kubernetes/client-go/blob/7c69e980210777a6292351ac6873de083526f08e/tools/cache/shared_informer.go#L41
https://github.com/jbeda/tgik-controller/blob/master/tgik-controller.go#L42

We don't need this.


Dataset pull fixes

Fixing various issues regarding dataset pull after recent feature based schema changes:

Adding UInt32 type as it's needed for Clickhouse random column as UInt64 is too big for SQLlite
Removing casting dataframe data to string - it seems it's not needed anymore
Fix parsing empty string as json

test_row_random looks like a genuine failure.

I am getting the error as below when using the pull using datachain pull ds://02jpg_files -o jpf -vv
Version not specified, pulling the latest one (v1)
Saving dataset ds://02jpg_files@v1 locally: 100%|█████████████████████████████████████████████████████████████████████| 5.00/5.00 [00:00<00:00, 10.2 rows/s]
Dataset ds://02jpg_files@v1 saved locally
_request non-retriable exception: Anonymous caller does not have storage.buckets.get access to the Google Cloud Storage bucket. Permission 'storage.buckets.get' denied on resource (or it may not exist)., 401
Traceback (most recent call last):
  File ".../datachain/.venv/lib/python3.12/site-packages/gcsfs/retry.py", line 126, in retry_request
    return await func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../datachain/.venv/lib/python3.12/site-packages/gcsfs/core.py", line 440, in _request
    validate_response(status, contents, path, args)
  File ".../datachain/.venv/lib/python3.12/site-packages/gcsfs/retry.py", line 113, in validate_response
    raise HttpError(error)
gcsfs.retry.HttpError: Anonymous caller does not have storage.buckets.get access to the Google Cloud Storage bucket. Permission 'storage.buckets.get' denied on resource (or it may not exist)., 401
Error: Dataset lst__gs://datachain-demo/ not found.
Traceback (most recent call last):
  File ".../datachain/src/datachain/cli.py", line 1016, in main
    catalog.pull_dataset(
  File ".../datachain/src/datachain/catalog/catalog.py", line 1454, in pull_dataset
    _instantiate_dataset()
  File ".../datachain/src/datachain/catalog/catalog.py", line 1324, in _instantiate_dataset
    self.cp(
  File ".../datachain/src/datachain/catalog/catalog.py", line 1563, in cp
    node_groups = self.enlist_sources_grouped(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File .../iterative/datachain/src/datachain/catalog/catalog.py", line 703, in enlist_sources_grouped
    listing = Listing(st, client, self.get_dataset(dataset_name))
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../datachain/src/datachain/catalog/catalog.py", line 1090, in get_dataset
    return self.metastore.get_dataset(name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../src/datachain/data_storage/metastore.py", line 704, in get_dataset
    raise DatasetNotFoundError(f"Dataset {name} not found.")
datachain.error.DatasetNotFoundError: Dataset lst__gs://datachain-demo/ not found.
Telemetry is disabled by environment variable.

The datasets were created using:
from datachain import DataChain, C

ds = DataChain.from_storage("gs://datachain-demo")
ds1 = ds.filter(C('file.path').glob('*.jpg')).save("jpg_files")
ds2 = ds.filter(C('file.path').glob('*.png')).save("png_files")
ds4 = ds1.union(ds2)
ds5 = ds4.save("jpg_png_files")

dsf1 = ds.filter(C("file.path").glob("*02.jpg")).limit(5).save("02jpg_files")

ds6 = ds5.union(dsf1)
ds6.save("all_files")

datachain pull ds://02jpg_files -o jpf -vv

Thanks for finding the issue.
This is more related to instantiating dataset for which I will create a separate issue as it's not so trivial to fix atm. I would merge current PR to at least have dataset pull without instantiation working fine (which is enough in majority of use cases for clients)

test_row_random looks like a genuine failure.

I've fixed the test. Eventually I decided to use 64 bit for random number but limit it to 2^63 - 1 which is the largest possible value that can be stored in SQLite as it only supports signed numbers. Clickhouse supports unsigned ones, so the largest value is 2^64 but as I mentioned, 2^63 - 1 is largest possible value supported in both DBs. This gives us much larger number "pool" then changing this to 32 bit int.


Docker action seems to be broken on linux/arm64

My docker jobs fail with
#9 [linux/arm64 builder 3/9] RUN pip install virtualenv
#9 sha256:924183bb3976255e589a1df7ef91b3b006ac69f2a5b7081ade29918a0a423721
#9 1.228 /usr/local/bin/python: can't open file '//pip': [Errno 2] No such file or directory
#9 ERROR: executor failed running [/dev/.buildkit_qemu_emulator /bin/sh -c pip install virtualenv]: exit code: 2

Fixed by running it again.

Fixed by running it again.


Preserve aspect ratio on quick update images

Ref: https://kitsu.canny.io/bugs/p/quick-update-images-look-distorted
Changes proposed in this pull request:

override object-fit on quick update images

/cc @hummingbird-me/staff

Thanks!


[formrecognizer] Unskip mgmt tests

API change check
API changes are not detected in this pull request.


Wrong installer, new installs all dependencies.

[y] Have you signed the Contributor License Agreement?
[y] Have you checked that there aren't other open pull requests for the same manifest update/change?

[y] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

There is no need to delete the DigiDoc4 manifest because this install differently

The ShortDescription says its a Estonian e-ID middleware not the whole package.
Also you should add more metadata which the other manifest does have.


[minor bug report] code block syntax highlighting

the 3 backticks code block syntax highlighting with keyword 'python' will correctly highlight code block as python code; but 'py' does not perform any syntax highlighting as it should;

Bug reports about Obsidian should go to the forum. This repo is specifically for issues with the plugin API. Thanks!


Using SQL Server as DataSource Type

In the project [03.Host Layer].[SimpleIdentityServer.Startup].Startup.cs, under public void ConfigureServices, when DataSource is changed to be DataSourceTypes.sql (rather than DataSourceType), the server no longer starts.
Things I have done (Windows 7 x64 with RC 1.0.1 and 1.0.2)

Changed the connection string but the database SimpleIdentityServer does not get created nor could I find a db file for me to restore within the projects.
The code looks to find translation support, but will error out because the value returned is null.

Open a command prompt
Navigate to the project "SimpleIdentityServer.DataAccess.SqlServer"
In "appsettings.json" Update the connection string
Execute the command "dnx ef database update", the table will be created via entity framework migration.

Is-it working ?

This is working now.  Passing in the argument "database update" was the step I was missing.  I tested this from command line and within visual studios by changing the launchSettings.json file.    By setting the HostingOptions.IsDataMigrated = to true, a default client (as well as other OpenId values) were inserted into the database.
Thanks


Tutorial Revision

Revised tutorial to use function-based components instead of class-based, and hooks instead of lifecycle methods. I don't expect this PR to be accepted, but I do hope the React team will release something similar to this in the near future, as the current tutorial seems to be somewhat outdated, and not very user friendly.

Hi! We're in the middle of rewriting the docs from scratch. It's not clear that we'll keep this tutorial there, at least in the initial revision. In the current old docs, the main content is all classes. So it's confusing either way. If the tutorial is Hooks, why does the main content use Classes? At least for now it's consistent: we teach Classes first, then Hooks. And in new docs it will be the reverse order. Hope that explains why we're not doing changes to docs now.

(But—really appreciate the effort. It pains me to see the old docs every day. I hope we can get at least the beta out as soon as possible.)


Add "closing labels" to API spec.

@bwilkerson Proposed spec changes for #30285.
Note: This does not include experimental="true" because it didn't seem to work on notifications:
Exception: analysis.closingLabels: Unexpected attribute in notification: experimental
#0      ApiReader.checkAttributes.<anonymous closure> (file:///Users/danny/Dev/Google/sdk/pkg/analysis_server/tool/spec/from_html.dart:127:9)

It also doesn't include a change to the spec version yet (makes most sense to do this at the end in case other work increases it before this lands) nor the re-generation of files.
If you want to keep these out of master until complete, it may be worth creating a branch and re-targeting this PR there to allow smaller PRs for reviewing.

@bwilkerson Does it need to be in the same commit, or is pushing another changeset to this PR enough (I don't know how your build/testing works or how small you like commits).
Will sort out when back, thanks!

A separate commit added to the PR is fine. When the merge is performed it will squash all of the commits, so it doesn't matter how many there were before the merge.

@bwilkerson Cool; I forgot you have the option to quash from PRs too. Files regenerated and pushed.

Do you have permission to merge, or should I do it?

@bwilkerson I do not have permission, I'm just an outsider! (and probably I don't want the responsibility ;-))


fix(assets): add spans to glyphs

This PR adds the spans recently introduced for glyphs in the current PR webern-unibas-ch/awg-app#2053.

@masthom Made a PR directly to your PR-branch, so the changes would be included there.


:bug: Fixes no content response on task poll

This PR fixes an unexpected behaviour when polling for tasks on an empty task queue observed with conductor-python version 1.0.56
In ApiClient.deserialize method, the following code is executed:
try:
    data = response.resp.json()
except Exception:
    data = response.resp.text

When there is no task to be fetched, the exception is raised and data variable will be an empty string data = ''. After that, ApiClient.__deserialize method is called, were this check is performed:
if data is b'' or data is None:
    return None

In this case, as data is an empty string, the if clause is False and an invalid task will be created generating errors in the workers.
This PR expands the analysis of the mentioned if clause and will return None for this case.

It looks like this PR is converting all the falsy values in the json response by the Conductor API to the None values.

It looks like this PR is converting all the falsy values in the json response by the Conductor API to the None values.

@v891 The latest SDK release doesn't have this issue as we changed the logic to explicitly check for None. Please see this.


⚠ ClamAV has degraded performance

In fd27494, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 100 ms

Resolved: ClamAV performance has improved in 7bbd6c3.


Ninetails v2.0.0 build for Windows x64

I've built v2.0.0 of Ninetails for x64 versions of Windows.
https://github.com/CocoTheMii/miscellaneous/releases/tag/v1
Built and tested on an Intel Core i7-6600U running Windows 11 build 22000.348; seems to run just fine.

Thank you for contributing! I'll add this to the releases page. 😸

Would you mind building a release for version 2.1.0? It would be quite helpful! Don't feel like you have to, though; it's totally up to you.

Absolutely! I've updated the release page to contain a build of 2.1.0.
Built on the same computer as before, using Windows 10 build 19044.1288. I'm currently trying out Kubuntu on my main laptop, so I'm using a VM for Windows stuff.

Wow, thank you!


error on DB migration

I'm getting the following error on the DB migration step.
(venv) ------------------------------------------------------------
[root@netbox] # python3 manage.py migrate
Traceback (most recent call last):
  File "/opt/netbox-3.5.8/netbox/manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/opt/netbox-3.5.8/venv/lib/python3.9/site-packages/django/core/management/__init__.py", line 446, in execute_from_command_line
    utility.execute()
  File "/opt/netbox-3.5.8/venv/lib/python3.9/site-packages/django/core/management/__init__.py", line 420, in execute
    django.setup()
  File "/opt/netbox-3.5.8/venv/lib/python3.9/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/opt/netbox-3.5.8/venv/lib/python3.9/site-packages/django/apps/registry.py", line 116, in populate
    app_config.import_models()
  File "/opt/netbox-3.5.8/venv/lib/python3.9/site-packages/django/apps/config.py", line 269, in import_models
    self.models_module = import_module(models_module_name)
  File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 790, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/opt/netbox-3.5.8/venv/lib/python3.9/site-packages/netbox_powerdns_sync/models.py", line 17, in <module>
    from .utils import get_ip_host, make_canonical, is_reverse
  File "/opt/netbox-3.5.8/venv/lib/python3.9/site-packages/netbox_powerdns_sync/utils.py", line 15, in <module>
    def get_ip_host(ip:IPAddress) -> Device|VirtualMachine|None:
TypeError: unsupported operand type(s) for |: 'ModelBase' and 'ModelBase'

Netbox 3.5.8.
Python 3.9.2

Whoops. It seems like we're using some type hinting syntax that is only supported from python 3.10. I'll take a look how much code needs to be fixed and decide whether to remove problematic syntax or mark the plugin as compatible with python=>3.10.

Thank
I'll look into bumping the version of python on my end, now that I know that's the issue.


Windows compatibility

Thanks a lot! It seems to me that almost every line of the repository has been changed, for some reason. Could there be an issue with line endings...? (For example, the README is mostly completely rewritten, even though as far as I can see, there have been no changes to it).

I actually added a Windows section to the readme, but yeah, I guess it's the line endings (+ cargo format on the build.rs). I'll try to fix this.
I think we should also add a test that does basically nothing (or some MKL hello world) just to check that linking etc. works. This can then be run in Github Actions (testing this right now in a different branch).


Add support for setting sysctls

- What I did
- How I did it
- How to verify it
- A picture of a cute animal (not mandatory but encouraged)
This patch will allow users to specify namespace specific "kernel parameters"
for running inside of a container.
Signed-off-by: Dan Walsh<EMAIL_ADDRESS>

@runcom PTAL

just waiting on CI to finish for this and the 1.11 branch then I'll merge and open another PR for rhel7-1.11 branch which is missing, I'll take care of it


feat(auditlog): add auto moderation actions and options

https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object-audit-log-events
https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object-optional-audit-entry-info

Thanks for your contribution!


Some fixes

👷 Deploy Preview for semanticclimate processing.

Name
Link

🔨 Latest commit
c612c4baafd97d2f7c9875573ddd09d4e4ebe87b

🔍 Latest deploy log
https://app.netlify.com/sites/semanticclimate/deploys/635552005299e30008b4406f


Tested Device Victron SmartSolar MPPT 100/15

I tested th Victron SmartSolar MPPT 100/15, it works perfectly

BlueSolar MPPT 100 | 30 as well (at least the sensor which are defined in the example here

Tested a BlueSolar 75/15. All works correctly in the advanced example.


Support multiple namespaces

The current configuration allows for watching one or all namespaces, but it would be nice to be able to specify a list of namespaces to watch, or perhaps even a list of namespaces not to watch.

Please merge this PR

By "this" I guess @colegatron means https://github.com/davidpristovnik/kubewatch/pull/1


is ddp valid in training code?

i want to ask whether DDP stragegy is valid in training code. In train, the function save_model_checkpoint seemed only save model that global_rank equals to 0. The training code is like training two model parallelly using different data, but only save the first model when using two gpus

DDP replicates the model across all GPUs, but during the backward pass, the gradients are synchronized across all these copies, ensuring that the models remain identical. Since all model copies are synchronized and identical, saving the model on only global_rank == 0 avoids saving redundant checkpoints from other ranks and is valid.


Exporting as managed solution is unavailable and importing the solution in another environment fails

On this site page it's implied that you can export the solution as managed. This is not available at the moment. Please notity the readers when this will become available.
It's also stated on this page that solutions can be moved between environments via exporting and importing. This fails with the reason that the environments have different publishers even though the both are Dataverse for Teams environments. Please check this out and reconcider the information stated about this on the page.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 998b6a1a-a578-f7ce-52e6-1d504e55bbd1
Version Independent ID: 0189e16d-f8af-e510-3b01-939dd6afd84a
Content: Move customizations between environments - Power Apps
Content Source: powerapps-docs/teams/import-solution-in-teams.md
Service: powerapps
GitHub Login: @wimcoor
Microsoft Alias: wimcoor

Thanks for reaching out @timothybohte.
The goal of the Power Apps app in Teams and Dataverse for Teams is to simplify some of the more advanced concepts that come with Power Apps and Dataverse. We consider solution management as one of those more advanced concepts.
You probably noticed that the Power Apps client embedded in Teams does not even expose solutions explicitly. Therefore, we also provided a simplified export mechanism which allows you to simply select customizations and export. Behind the scenes we compose an unmanaged solution for you that gets exported into the zip file that is then downloaded. I believe the current documentation specific to Dataverse for Teams does not mention you can export a managed solution. However, I can certainly make a change to explicitly mention that this type of export always creates an unmanaged solution.
Note that it does mention you can import managed solutions into Dataverse for Teams, which you can, and they land under the "Installed Apps" tab in the Build hub.
Additionally, I can share that "solution-aware" makers can still leverage all their favorite solution concepts, like creating solutions and exporting them as managed, using the full Power Apps or Power Automate maker portals. In the coming weeks we'll provide an easy way for makers to navigate from the Teams client to the Power Apps web portal (https://make.powerapps.com) for the selected environment.
Finally, I am sorry to hear that your export/import failed from one Dataverse for Teams environment to another. This should not be an issue and you should not be getting errors for a publisher mismatch. Can you share the detailed error message and maybe your session details so that we can further investigate and resolve this? Alternatively, please create a support case.

Thanks for reaching out @timothybohte.
The goal of the Power Apps app in Teams and Dataverse for Teams is to simplify some of the more advanced concepts that come with Power Apps and Dataverse. We consider solution management as one of those more advanced concepts.
You probably noticed that the Power Apps client embedded in Teams does not even expose solutions explicitly. Therefore, we also provided a simplified export mechanism which allows you to simply select customizations and export. Behind the scenes we compose an unmanaged solution for you that gets exported into the zip file that is then downloaded. I believe the current documentation specific to Dataverse for Teams does not mention you can export a managed solution. However, I can certainly make a change to explicitly mention that this type of export always creates an unmanaged solution.
Note that it does mention you can import managed solutions into Dataverse for Teams, which you can, and they land under the "Installed Apps" tab in the Build hub.
Additionally, I can share that "solution-aware" makers can still leverage all their favorite solution concepts, like creating solutions and exporting them as managed, using the full Power Apps or Power Automate maker portals. In the coming weeks we'll provide an easy way for makers to navigate from the Teams client to the  Power Apps web portal (https://make.powerapps.com) for the selected environment.
Finally, I am sorry to hear that your export/import failed from one Dataverse for Teams environment to another. This should not be an issue and you should not be getting errors for a publisher mismatch. Can you share the detailed error message and maybe your session details so that we can further investigate and resolve this ? Alternatively, please create a support case.

@timothybohte - the article has been updated to specifically state the the solution packages you export or unmanaged.
Closing issue.


Feat/publish moc on docs

Closes #140
📑 Description

✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[x] I have updated the documentation as required
[ ] All the tests have passed

ℹ Additional Information

@alv67 I did not merge this PR in dev-cw07 since it was not passing tests, sorry...

Need to exclude check for two md files… these files does not have Title but only include so they do not pass the linter
Il 20 feb 2022, 21:54 +0100, Gianpaolo Macario @.***>, ha scritto:

@alv67 I did not merge this PR in dev-cw07 since it was not passing tests, sorry...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Need to exclude check for two md files…

Donw

You have already merged this
[.github/linters/.markdown-lint.yml](https://github.com/B-AROL-O/ARNEIS/pull/185/files/775295f828d9dd2e7d5dd3526a327c60a95e135f..714d4cdc03c12178e0bfae80f865a0f3d94717e9#diff-2fd3619d2b7372123257bc21645edb90c24293e66babbc6053033a89e21bab34)[](https://github.com/B-AROL-O/ARNEIS/pull/185/files/775295f828d9dd2e7d5dd3526a327c60a95e135f..714d4cdc03c12178e0bfae80f865a0f3d94717e9#diff-2fd3619d2b7372123257bc21645edb90c24293e66babbc6053033a89e21bab34)
Viewed
@@ -28,6 +28,7 @@ MD026:
MD029: false                  # Ordered list item prefix
MD033: false                  # Allow inline HTML
MD036: false                  # Emphasis used instead of a heading
MD041: false                  # First line in a file should be a top-level heading

Making it work for ALL the repository content. I think it would have been better to disable the rule just for the single files .md and not for ALL the repository.

Good point @gteti.
Would you like to try and improve the code with the PR as you suggested?

Good point @gteti.
Would you like to try and improve the code with the PR as you suggested?
Otherwise just create a Bug and assign it to me so I will not forget. Thanks!

See #189


Check for correct Voctocore-Version in Voctogui

fixed in ca6c7f5de37e44c36eed7fb0581866c9d385703b

It would be important to backport this fix to the 1.0 GUI, so that it will correctly report back, when it is started against a 2.0 core.


style(model-based): fix mypy and polish api docstring

Description

Clean useless argument.
Specify typing. For example: list -> list[float].
Fix api docstring. For example, some argument docs is np.ndarray but actually it is torch.Tensor.
Clear redundant code. Some methods simply unused, so I delete it.

Motivation and Context
Some codes and docs exist problems and need to be polished.
This pull request solves issue #230

[x] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[x] My change requires a change to the documentation.
[x] I have updated the tests accordingly. (required for a bug fix or a new feature)
[x] I have updated the documentation accordingly.
[x] I have reformatted the code using make format. (required)
[x] I have checked the code using make lint. (required)
[x] I have ensured make test pass. (required)

Codecov Report

Merging #240 (898348d) into dev (d853ad8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Current head 898348d differs from pull request most recent head 839c117. Consider uploading reports for the commit 839c117 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##              dev     #240      +/-   ##
==========================================
+ Coverage   96.99%   97.00%   +0.01%
==========================================
  Files         134      134
  Lines        6867     6890      +23
==========================================
+ Hits         6660     6683      +23
  Misses        207      207

Impacted Files
Coverage Δ

omnisafe/algorithms/model_based/planner/cap.py
100.00% <ø> (ø)

omnisafe/algorithms/model_based/planner/cce.py
100.00% <ø> (ø)

omnisafe/algorithms/model_based/planner/rce.py
93.33% <ø> (ø)

...isafe/algorithms/on_policy/base/policy_gradient.py
100.00% <ø> (ø)

omnisafe/common/logger.py
97.50% <ø> (ø)

omnisafe/envs/core.py
90.62% <ø> (ø)

omnisafe/envs/mujoco_env.py
93.33% <ø> (ø)

omnisafe/envs/safety_gymnasium_env.py
97.96% <ø> (ø)

omnisafe/utils/config.py
99.36% <ø> (ø)

omnisafe/utils/plotter.py
91.38% <ø> (ø)

... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


I can not get denite support in airline.

here is my screenshot

and my denite config is
let s:denite_options = {'default' : {
      \ 'winheight' : 15,
      \ 'mode' : 'insert',
      \ 'quit' : 'true',
      \ 'highlight_matched_char' : 'MoreMsg',
      \ 'highlight_matched_range' : 'MoreMsg',
      \ 'direction': 'rightbelow',
      \ 'prompt' : '➭',
      \ }}

function! s:profile(opts) abort
  for fname in keys(a:opts)
    for dopt in keys(a:opts[fname])
      call denite#custom#option(fname, dopt, a:opts[fname][dopt])
    endfor
  endfor
endfunction

call s:profile(s:denite_options)

Did you update denite? CC @thatsmydoing who contributed denite support

both denite ad airline is on the master. as I know denite support two mode, normal mode and insert mode, but it is not same as vim's mode, so I think airline color should be changed when the mode is changed.

If the mode is different from Vims mode, why would you expect airline to detect it?

It should support it. Are you using vim or nvim? Which version?
Maybe something else in your config conflicts with it? Can you try with vanilla denite and airline?

any update here?

I test in vim and neovim, both has same issue

I will add mini vimrc latter

a screenshot might also help

set rtp+=~/.cache/vimfiles/repos/github.com/vim-airline/vim-airline/
set rtp+=~/.cache/vimfiles/repos/github.com/vim-airline/vim-airline-themes/
set rtp+=~/.cache/vimfiles/repos/github.com/Shougo/denite.nvim/
set rtp+=~/.cache/vimfiles/repos/github.com/morhetz/gruvbox/
colorschem gruvbox
set bg=dark
let s:denite_options = {
      \ 'default' : {
      \ 'winheight' : 15,
      \ 'mode' : 'insert',
      \ 'quit' : 'true',
      \ 'highlight_matched_char' : 'MoreMsg',
      \ 'highlight_matched_range' : 'MoreMsg',
      \ 'direction': 'rightbelow',
      \ 'statusline' : 'false',
      \ 'prompt' : '➭',
      \ }}

function! s:profile(opts) abort
  for fname in keys(a:opts)
    for dopt in keys(a:opts[fname])
      call denite#custom#option(fname, dopt, a:opts[fname][dopt])
    endfor
  endfor
endfunction

call s:profile(s:denite_options)

I have set statusline option of denite as false, but it still does not work. I have tried both true and false. But if I remove call s:profile(s:denite_options), everything works well, I think it is a bug.
cc @Shougo

I think you should be using v:true or v:false instead of 'false'. Also, the plugin automatically switches off the statusline, so setting it again is counterproductive. If you remove the 'statusline': 'false' line it actually works correctly.

Tanks, I will have a try

I just remove it
✔ wsdjeg:SpaceVim [ dev | ✚ 1 ] ➭ git diff
diff --git a/config/plugins/denite.vim b/config/plugins/denite.vim
index dd033cf..cceff88 100644
--- a/config/plugins/denite.vim
+++ b/config/plugins/denite.vim
@@ -12,7 +12,6 @@ let s:denite_options = {
       \ 'highlight_matched_char' : 'MoreMsg',
       \ 'highlight_matched_range' : 'MoreMsg',
       \ 'direction': 'rightbelow',
-      \ 'statusline' : 'false',
       \ 'prompt' : '➭',
       \ }}

but the status line is just looks like:

Given your minivimrc, it looks fine

I think it is issue of let g:airline_skip_empty_sections = 1
here is my minivimrc:
set rtp+=~/.cache/vimfiles/repos/github.com/vim-airline/vim-airline/
set rtp+=~/.cache/vimfiles/repos/github.com/vim-airline/vim-airline-themes/
set rtp+=~/.cache/vimfiles/repos/github.com/Shougo/denite.nvim/
set rtp+=~/.cache/vimfiles/repos/github.com/morhetz/gruvbox/
colorschem gruvbox
set bg=dark
let s:denite_options = {
      \ 'default' : {
      \ 'winheight' : 15,
      \ 'mode' : 'insert',
      \ 'quit' : 'true',
      \ 'highlight_matched_char' : 'MoreMsg',
      \ 'highlight_matched_range' : 'MoreMsg',
      \ 'direction': 'rightbelow',
      \ 'prompt' : '➭',
      \ }}

function! s:profile(opts) abort
  for fname in keys(a:opts)
    for dopt in keys(a:opts[fname])
      call denite#custom#option(fname, dopt, a:opts[fname][dopt])
    endfor
  endfor
endfunction

call s:profile(s:denite_options)
let g:airline_skip_empty_sections = 1

I think it's another issue caused by the delayed evaluation of airline with denite. I'm not exactly sure how to fix that problem.

How am I supposed to test this? I used your minivimrc, denite didn't load. Okay, apparently, I need a vim with +python3 support, so I compiled my own new vim which has +pyhton3. restarted. Tried :Denite got back [denite] empty source and now what? The documentation is not very helpful.

Denite needs the source names.
I think file_rec is better to test.
Denite file_rec

The documentation is not very helpful.

The PR is wellcome.

Found the problem. The denite statusline functions returned the content of some b: variables, which are not set the first time the statusline is evaluated. And because of g:airline_skip_empty_sections they wouldn't be evaluated anymore. I fixed it by overriding the variable in the denite window. please check.

@chrisbra with the latest version of airline,
let g:airline_skip_empty_sections = 1 can not hidde empty neomake info.
you can see it in the picture below:

yeah it is explicitly disabled for denite.


Test Again

Your app is deployed at launch-92.southindia.azurecontainer.io

Your app is deployed at launch-94.southindia.azurecontainer.io

Your app is deployed at launch-95.southindia.azurecontainer.io


Sharedata

regarding #2681 I think that 'share_data' is part of the public API in 1.13 and should be preserved
this PR reimplements #2549 with respect to master, a fairly simple exercise
I think this should be included in iris 2.0

@marqh there are still many outstanding issues with this PR that need to be addressed.

there are many levels of comment in this, it is difficult to follow a coherent train of thought.
Rather than post on all, I will pick out a small part, which has implications for all the rest.

then it seems that this functionality was not properly thought through before being added to v1.13, despite numerous requests that it was.

I do not think this is a fair reflection on attempts to carefully implement this functionality.

This puts you in a difficult situation because this PR is not getting merged in its current form. This behaviour will not be retained in its current form, so your proposed API will have to change, as per the recommendations elsewhere in the review of this PR.

I don't think this level of response is within your remit.  According to http://scitools.org.uk/iris/docs/latest/developers_guide/deprecations.html
If you need to make a backwards-incompatible change to a public API [1] that has been included in a release (e.g. deleting a method), then you must first deprecate the old behaviour in at least one release, before removing/updating it in the next major release.
Whether you agree or disagree with the implementation, this functionality and public API has been included in a release, and it is in active use within our user community.
As a developer community, we can look to migrate this functionality to a different API over time, but we have signed up to not simply removing API functionality without deprecation warnings.  We have also signed up to
Where possible, your deprecation warning should include advice on how to avoid using the deprecated API.
So a replacement methodology should be provided as part of deprecation.
as @lbdreyer points out in #2681

share_data is a property of a public object (iris.cube.Cube) and therefore surely needs to be deprecated - it can't just vanish.

There are views shared on that issue about this change and alterations to change management processes, but applying these retrospectively to this case is a fairly dubious tactic, I feel.

The approach proposed simply does not adhere to how Iris makes these sort of runtime changes, which needs to be done using a new options class added to iris.config

It is far from clear to me that this is a useful and suitable approach for this particular case, this is about the behaviour of an individual cube, and in particular giving experienced developers the space to optimise their code for specific cubes without Iris trampling all over their careful implementation.
Perhaps there is an opportunity to investigate this in the future, but I am wary of making a jump to this approach when all I am trying to do is preserve the limited and useful behaviour from v1.13.
I am happy to to engage with detailed discussions about how to implement this API feature for master and Iris 2.0.
The strong language (in bold typeface) about API decisions and data loading is not helping this, in my view.
@dkillick are you prepared to engage in a discussion with me about how to implement this API feature as per our API maintenance statements and focus review efforts on fine details of coding an appropriate levels of testing, or are you firmly attached to your positions on API, loading data, implementing shared lazy data and so on?

I don't think this level of response is within your remit

Of course it is, and it's in your remit, and it's in the remit of all Iris devs. If something isn't working we all have the remit to fix it, otherwise Iris will never improve. The change management whitepaper is (a) a part of Iris and changeable, and (b) not the final word on how change will occur – it works for us, not we for it. If it is not working for us then it is within our remit to fix it, which has already been identified as being necessary. This v2 release is the first real test of the change management whitepaper, and it has been shown to just be too strict in its requirements, of which this proposal is a good example.
Our change management is based on SemVer. This states that "MAJOR version[s are] when you make incompatible API changes" (maintaining original emphasis), which must happen in this case.

in particular giving experienced developers the space to optimise their code for specific cubes without Iris trampling all over their careful implementation

limited and useful behaviour

Problem: you have proposed this unprecedented behaviour change to help a limited subset of Iris users who are also experienced developers. This excludes the majority of Iris users, who frequently are inexperienced developers. They may not expect the behaviour that you propose to introduce, and there is no evidence that they need it either. The proposed solution for the experienced developers is too prominent within Iris (as a cube-level API) so introduces a risk that inexperienced developers will encounter unprecedented behaviour (a cube's data unexpectedly being loaded) through mis-application of this API.

are you firmly attached to your positions

There is no movement: there is general team intention that this PR will not go into Iris in its current implementation.

are you prepared to engage in a discussion

There will be a team discussion to determine how to retain the behaviour, which while limited in requirement is undoubtedly useful, and will determine the most appropriate implementation of the required behaviour.

The shared data feature is perhaps the single most divisive/controversial iris feature in recent memory. I'm putting together the iris 2.0.0 release candidate, and whilst it is clear that we all seem to support the idea of shared data, we certainly don't agree on the implementation.
There are some serious and legitimate API concerns with the changes here (and released in iris 1.13) that make me reluctant to accept this change as part of the v2.0.0 release preparation. Fortunately, as with any new feature, we do have the capacity to introduce this change slowly through keyword arguments / the FUTURE mechanism during any minor release.
For that reason, I'm going to keep the PR open with a Status: Decision needed label, but move it out of the v2.0.0 milestone. In practice, we will therefore need to document the breaking change that not re-adding this feature introduces. My apologies to those waiting on this feature - we all want to see the performance boosts that not always copying the data brings, but it is clear that we don't yet agree on the maintenance/API costs we pay for gaining them.

i will not be putting any further work into this pull request

Ultimately, I still think this is needed.
IMHO we should aim to be "like numpy".
In this context, that means  in the worst cases (e.g. indexing) :  "sometimes we copy, it's too complicated to explain exactly when"

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@pp-mo is quite right that this topic needs to be on our radar, but re-opening a rejected PR is not the best way to ensure this. I've raised #3172 to make sure the fact there's a problem is recorded so that it can be fully addressed.

I've raised #3172 to make sure the fact there's a problem is recorded

Thanks + agreed that is probably better ...


[FR] Loading/disabling plugins conditionally

Is your feature request related to a problem? Please describe.
I'm integrating Cython.Coverage in the @aio-libs projects. It works fine for CPython but crashes on PyPy. This is because CoverageWarning is emitted and pytest is configured with filterwarnings = error (coveragepy is integrated through pytest-cov).
In projects, where we use Cython, we normally maintain a fallback pure-python implementation. So in CI we run tests with and without C-extensions to cover these cases. Cython.Coverage is added to .coveragerc statically and gets picked up even when we test pure-python builds.
That works fine on CPython, there's just no matches for PYX files since they aren't measured.
It explodes on PyPy, though. For PyPy, we always disable building C-extensions, so it's always pure-python.
But since the config is static, and the plugin is needed for other envs, we're stuck with coveragepy picking it up when it's undesired.
Describe the solution you'd like
I think, there's a need for dynamically enabling and disabling plugins:

a CLI arg
a public API interface arg (so things like pytest-cov could integrate it seamlessly)
an environment variable

Describe alternatives you've considered

Putting a no-op module with the same import signature shadowing the actual plugin into $PYTHONPATH and auto-injecting that on PyPy, using some wrapper.
Using sed -i 's/^plugins = .*//g' in CI.

Additional context
The failing CI job: https://github.com/aio-libs/yarl/actions/runs/6971527253/job/18972275042?pr=961#step:9:82
I extracted the traceback since GHA logs get garbage-collected over time:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/runpy.py", line 200, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pytest/__main__.py", line 5, in <module>
    raise SystemExit(pytest.console_main())
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/_pytest/config/__init__.py", line 192, in console_main
    code = main()
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/_pytest/config/__init__.py", line 150, in main
    config = _prepareconfig(args, plugins)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/_pytest/config/__init__.py", line 331, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_hooks.py", line 493, in __call__
    return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_manager.py", line 115, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_callers.py", line 130, in _multicall
    teardown[0].send(outcome)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/_pytest/helpconfig.py", line 104, in pytest_cmdline_parse
    config: Config = outcome.get_result()
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_result.py", line 114, in get_result
    raise exc.with_traceback(exc.__traceback__)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_callers.py", line 77, in _multicall
    res = hook_impl.function(*args)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/_pytest/config/__init__.py", line 1075, in pytest_cmdline_parse
    self.parse(args)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/_pytest/config/__init__.py", line 1425, in parse
    self._preparse(args, addopts=addopts)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/_pytest/config/__init__.py", line 1327, in _preparse
    self.hook.pytest_load_initial_conftests(
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_hooks.py", line 493, in __call__
    return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_manager.py", line 115, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_callers.py", line 152, in _multicall
    return outcome.get_result()
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_result.py", line 114, in get_result
    raise exc.with_traceback(exc.__traceback__)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pluggy/_callers.py", line 77, in _multicall
    res = hook_impl.function(*args)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pytest_cov/plugin.py", line 152, in pytest_load_initial_conftests
    plugin = CovPlugin(options, early_config.pluginmanager)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pytest_cov/plugin.py", line 203, in __init__
    self.start(engine.Central)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pytest_cov/plugin.py", line 225, in start
    self.cov_controller.start()
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pytest_cov/engine.py", line 44, in ensure_topdir_wrapper
    return meth(self, *args, **kwargs)
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/pytest_cov/engine.py", line 241, in start
    self.cov.start()
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/coverage/control.py", line 631, in start
    self._init_for_start()
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/coverage/control.py", line 562, in _init_for_start
    self._warn(
  File "/opt/hostedtoolcache/PyPy/3.9.18/x64/lib/pypy3.9/site-packages/coverage/control.py", line 434, in _warn
    warnings.warn(msg, category=CoverageWarning, stacklevel=2)
coverage.exceptions.CoverageWarning: Plugin file tracers (Cython.Coverage.Plugin) aren't supported with PyTracer

I just noticed that there's a feature to suppress warnings that have unique identifiers @ https://coverage.readthedocs.io/en/latest/cmd.html#warnings. But this specific warning isn't listed there.
I located the _warn() call @ https://github.com/nedbat/coveragepy/blob/184dc78/coverage/control.py#L562-L569 and realized that it doesn't pass a slug= argument. I suppose it could be useful to set it as well.


Refactoring #3, #4, and #7.

There were some inconsistencies where multiple elements would have the same ID and such. I will switch from styling by ID to styling by class. And adopt suggestions my team members gave.

[x]  refactor html and css

[x]  use static assets for hobby images

[x]  changed our root path to render "main.jinja"


[1419] Update SERVE_STATIC to RAILS_SERVE_STATIC_FILES

Resolves #1419

fixes in .env.example and app.json

Very simple, worth a double-check for typos though.

didn't see any issues!

great, thanks!


Example doesn't work

I am trying to run the following example. Keep getting 404 error. I can send a message with curl using the same (my) credentials. Not sure what's going on. Thanks.
mg.messages.create('sandbox-123.mailgun.org', {     from: "Excited User<EMAIL_ADDRESS>    to<EMAIL_ADDRESS>    subject: "Hello",     text: "Testing some Mailgun awesomness!",     html: "
Testing some Mailgun awesomness!
"   })   .then(msg => console.log(msg)) // logs response data   .catch(err => console.log(err)); // logs any error

Hi @rotexhawk
I used it the next way and it works OK:
try {
    const res = await mg.messages.create(domain, {
      from: fromEmail,
      to: toEmail,
      cc: undefined,
      subject: 'Hello 3',
      // text: 'Testing some Mailgun awesomeness!',
      html: `

Test email header

Test email body

      `
      // attachment: [rackspaceLogo]
    });

    console.log(res);
  } catch (err) {
    console.error(err);
  }

Maybe you don't have such a domain in a region you use, could you check it, please?

I'm closing this one, if you still have such issue please open a new one.

Having 404


Items in Place type list in Nearby become unreadable on unselecting

Summary:
Background of items in Place type list in Nearby becomes white on unselecting. Since the text is also white, the item becomes unreadable. This only happens in the dark theme.
How can we reproduce the issue?
Enable dark theme. Open Nearby. Tap on the search option in front of Place type. If you tap once on any item, the background becomes light grey. Tap the same item again, i.e., unselect it, and the background becomes completely white.
What did you expect the app to do, and what did you see instead?
I expected the item's background colour to change to what it was before I had selected it, i.e., black.
Device and Android version:
Redmi Note 5 Pro
MIUI version 11
Android 9
Commons app version:
2.12.3-debug
master and betaDebug
Screen-shots:
Default

Tap once to select item

Tap again to unselect

Would you like to work on the issue?
Yes, I'd like to work on this.

@6point022 Go for it!


Made a simple change in the syntax

** Brief Description of Fix**
I made a simple change in the syntax of the program.
** Detailed Description including  steps taken and any changes made**
I changed the command written as ' else if ' to 'elif'
linked issue
closes #6

!bounty 20