JDK9: define a stable automatic module name with Automatic-Module-Name entry in MANIFEST

See https://github.com/ReactiveX/RxJava/issues/5618
Currently java 9 attempts to automatically name super-csv "super.csv". As super is a keyword, that obviously just fails.

Has anyone found a solution for this?

I'll work on a solution.

Pull request #152 should fix the issue for everything except super-csv-java8 which appears to introduce package conflict which is a whole other issue.

Could this please be addressed? SuperCsv is still impossible to use in any modular application or compile into a runnable image. I love SuperCsv, but am upgrading my application to Java 12. I will need to find another solution if I cannot use this one. Appreciate all the work done so far!

Yes, +1 on this one.

Good idea. I need help with ideas on how best to solve this.

I'll pull the repo tomorrow and see what I can do. I recently just pulled my whole project up from J8 to J12 with modules, so I might be able to spot some stuff. Is there any document I should be aware of or quirks I should know before trying to build?

@DraqueT great news!
Yesterday I made some commits fixing the javadoc
I was also forced into upgrading 1.5 to 1.6 not sure why. I haven't coded java in a while. I installed java11 and the latest mvn
Going to 1.6 i guess won't hurt much. What are the problems with java 8 and later releases? Changes in the module system ? Do we need special releases for java 5, 8, 9+ or what is your strategy?

Sorry for the long absence there. I'm currently playing around with this and trying to get a better feel for how much work it would take to pull the whole shebang farther up. The setup is a bit more complex than what I've done in the past, but anything I find I'll post here.

Any update here?


Export to CSV File

The file does not contain the admins for the group connected sites, which limits its usefulness. Please add that data.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a532bd5d-9109-6b31-8b1c-be3c066a672a
Version Independent ID: adf7fd35-a09d-2d4c-de62-bc1273554200
Content: Manage sites in the new SharePoint admin center
Content Source: SharePoint/SharePointOnline/manage-sites-in-new-admin-center.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

@DeanGross , thanks for trying the new SharePoint admin center preview, and for sharing this feedback. I have passed it along to the team. If you have additional feedback, please click the Feedback button in the lower-right corner of the new SharePoint admin center. The team is monitoring this feedback closely, and working to add more functionality for managing group-connected team sites.


[formrecognizer] Add continuation token overload

Fixes #25228
TODO changelog

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-formrecognizer


Can wpapi client work with OAuth out of the box?

I'm not getting the Basic Authentication to work with wpapi client library.
The wpapi instructions recommend using the Basic Authentication plugin but the Basic Authentication plugin recommends using OAuth 1.0 plugin.

To authenticate with your WordPress install, Download and install the Basic Authentication handler plugin on your target WordPress site. (Note that the basic auth handler is not curently available through the plugin repository: you must install it manually.) - http://wp-api.org/node-wpapi/authentication/

Without SSL we strongly recommend using the OAuth 1.0a authentication handler in production environments. - https://github.com/WP-API/Basic-Auth

Since I'm not getting the Basic Auth to work and OAuth is recommended I'd like to setup OAuth.
But if I install the OAuth plugin do I need to changing anything in the code?
Here's what I have so far:
var wp = new WPAPI({
	endpoint: apiRoot,
	username: username,
	password: credential,
	auth: true
});

var test = wp.posts().create({
	title:'test',
	content:'test content'
})
.then(function(response) {
	console.log("complete");
	console.log(response);
})
.catch(function(err) {
	log("error:", err);
})

// error
{ code: 'rest_cannot_create',
	message: 'Sorry, you are not allowed to create posts as this user.',
	data: { status: 401 }
}

FYI I'm using the download of wpapi.js (7/6/2017) here:
http://wp-api.org/node-wpapi/installation/
I'm not on node. I'm on a client environment that runs ES6.

It cannot work with OAuth yet. We hope to add it eventually, but the priority currently is the long-delayed rewrite of the internals to permit new transport methods.


"short paint" (boundedNonWhitespaceSequence?) is undocumented

"short paint" (boundedNonWhitespaceSequence?) is undocumented; even a very short blurb in the reference would be great

Duplicate of #839


initial mysql version

This is not yet in shape good enough for using, but I've got select version() works,
so we can start discussing merging.
Main issue is that unlike existing drivers, mysql driver requires mutable connection object,
which requires to propagate mutability everywhere through the api.
I'm new to rust, so perhaps there is better way to do it, but for now I've added mut almost everywehe.

Thank you for the patches,
I see the mutable Database trait. This could be a problem later on when Database will be borrowed more than once. Is there something we could do for the mysql driver project itself, to make the connection immutable by default?
I'll try to merge your changes later this week, may take a while since I am as well new to git/github merge tools.
Also, it would have been great if you have the test database dumps in ./script to work for mysql as well, I haven't really been working with mysql database for soo long.

@Fiedzia
I have merged your changes to the master branch, I did the changes manually though, therefore the commits in this git tree, may not appropriately trace back to your code changes.
I put examples for mysql platform
https://github.com/ivanceras/rustorm/blob/master/examples/mysql_show_version.rs
https://github.com/ivanceras/rustorm/blob/master/examples/mysql_create_product_table.rs
https://github.com/ivanceras/rustorm/blob/master/examples/mysql_show_product.rs

Thanks. I'll look into mysql driver and ask its author about it. I'll add some mysql scripts.


[fastlane_core] Version bump

Added new option to hide timestamps in fastlane outputs using FASTLANE_HIDE_TIMESTAMP (#4838)
Fix PkgFileAnalyser to shell escape xar arguments
Helper.fastlane_enabled? improvements (#4889)
Continuing work on #3843
Ads Apple Developer Id to itunes_transporter.rb - allows deliver to work with multiple iTunes Providers

I just noticed that that should actually be a minor version bump, since we added new options

Alright, updated the PR, waiting for the build

Just found out that we should actually wait for https://github.com/fastlane/fastlane/pull/4722/ to be merged, because there are some fastlane_core changes there as well 👍

Ready go to be merged 👍

👍


Fix #20 - nullable semantics with $ref, oneOf, anyOf, and allOf

Hi,
Thank you for the fantastic work on a schema validator. This project has helped me significantly in validating dynamically generated openapi schemas.
Please consider merging this small improvement in handling nullable behavior.
The root of #20 seems to be that if a schema node is a meta node ($ref, allOf, anyOf, or oneOf), nullable shouldn't be checked.
The tests added validate both that null is allows when nullable:true the destination schema, and not allowed when nullable:false is on the destination schemas.

Re-implemented nullable based on OAS 3.0.3 definition.


The text color of Travel Itineraries Heading is now visible in both light and dark mode

Related Issue
Fixes:  #473
Description
I have changed the font color of the Travel Itineraries heading such that it is now visible in both light and dark modes.
Type of PR

[x] Bug fix

Screenshots / videos (if applicable)
Before change:

Both modes after change:

Checklist:

[x] I have made this change from my own.

[x] My code follows the style guidelines of this project.

[x] I have performed a self-review of my own code.

[x] My changes generate no new warnings.

[x] I have tested the changes thoroughly before submitting this pull request.

[x] I have provided relevant issue numbers and screenshots after making the changes.
Please review the PR and assign necessary labels

@PriyaGhosal I have resolved the conflicts


"error: requested alignment is not an integer constant" when make install

When I compiled and installed ngraph on CentOS7.5, I executed "make && sudo make install" command. And some errors occur below:
[root@localhost build]# make && sudo make install
[  2%] Built target ext_json
[ 40%] Built target ngraph
[ 42%] Built target ext_mkl
Move mkldnn libraries to ngraph build directory
[ 45%] Built target ext_mkldnn
[ 47%] Built target ext_clang
[ 49%] Built target ext_openmp
[ 51%] Built target ext_llvm
[ 53%] Built target ext_eigen
[ 54%] Built target resource_generator
[ 54%] Built target header_resource
[ 55%] Built target codegen
[ 56%] Built target interpreter_backend
[ 56%] Building CXX object src/ngraph/runtime/cpu/CMakeFiles/cpu_backend.dir/builder/reduce_function.cpp.o
In file included from /opt/libraries/ngraph/src/ngraph/runtime/cpu/builder/reduce_function.cpp:17:0:
/opt/libraries/ngraph/src/ngraph/runtime/cpu/kernel/reduce_function.hpp: In member function ‘void ngraph::runtime::cpu::kernel::Reducer::reduce(ElementType, ElementType*)’:
*/opt/libraries/ngraph/src/ngraph/runtime/cpu/kernel/reduce_function.hpp:58:94: error: requested alignment is not an integer constant
ElementType p attribute((aligned(CPUTensorView::BufferAlignment))) = v;
^
/opt/libraries/ngraph/src/ngraph/runtime/cpu/kernel/reduce_function.hpp:59:94: error: requested alignment is not an integer constant
ElementType q attribute((aligned(CPUTensorView::BufferAlignment))) = R;
^
/opt/libraries/ngraph/src/ngraph/runtime/cpu/kernel/reduce_function.hpp:60:94: error: requested alignment is not an integer constant
ElementType r attribute((aligned(CPUTensorView::BufferAlignment)));
^
make[2]: *** [src/ngraph/runtime/cpu/CMakeFiles/cpu_backend.dir/builder/reduce_function.cpp.o] Error 1
make[1]: *** [src/ngraph/runtime/cpu/CMakeFiles/cpu_backend.dir/all] Error 2
make: *** [all] Error 2
How can I solve this problem?

I have solved this error.
This is a compiler bug. CPUTensorView::BufferAlignment is a constant defined in src/ngraph/runtime/cpu/cpu_tensor_view.hpp:
static constexpr size_t BufferAlignment=64;
For some ungodly reason aligned(CPUTensorView::BufferAlignment) does not evaluate as compilation constant. A workaround is to replace it with 64 and hope nothing breaks (if it does, provide larger alignment values until it stops :-) ).


i18n(pt-BR): update tutorial/2-pages/3.mdx file

Description (required)
update i18n/docs/pt-br/tutorial/2-pages/3.mdx

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

pt-br
tutorial/2-pages/3.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Translatable string list option

I may be missing something, but is there a solution for string list option to be translatable?
defineField({
  name: 'categories',
  title: 'Categories',
  type: 'string',
  options: {
    // This should be translatable
    list: [
      'Shirts',
      'Shorts',
      'Shoes',
    ]
  }
})

@SimeonGriggs but that means we get English choices only even for the other languages

Got it. In that instance, perhaps rethink the content model. If you need "the same value, but in different languages," perhaps the field only needs to be set once, and your consuming applications display the right language value.
Instead of having the same value set in different languages, independently in separate fields.

Hmm, yes, that would be an alternative approach. Not quite the same experience with the other translatable resources but we could try that if there's no built-in solution. Thanks


Syg public holiday

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@696f7a3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   96.24%
  Complexity      ?       41
=======================================
  Files           ?       21
  Lines           ?      133
  Branches        ?        0
=======================================
  Hits            ?      128
  Misses          ?        5
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696f7a3...f960a22. Read the comment docs.


attempt to write a readonly database

after updating to 1.2.0 im getting this error for whaterver im trying to run:
➜  ~ pkgx deno --version
× unexpected error attempt to write a readonly database
│ Error: attempt to write a readonly database
│     at unwrap (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/util.ts:27:11)
│     at new Statement (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/statement.ts:110:5)
│     at Database.prepare (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/database.ts:138:12)
│     at Database.sql (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/database.ts:185:23)
│     at provides (https://deno.land/x/libpkgx@v0.19.0/src/hooks/useSyncCache.ts:84:18)
│     at eventLoopTick (ext:core/01_core.js:168:7)
│     at async _which (https://deno.land/x/libpkgx@v0.19.0/src/plumbing/which.ts:31:20)
│     at async which (https://deno.land/x/libpkgx@v0.19.0/src/plumbing/which.ts:10:20)
│     at async default (file:///tmp/deno-compile-pkgx/pkgx/src/prefab/resolve-arg0.ts:7:14)
│     at async find_arg0 (file:///tmp/deno-compile-pkgx/pkgx/src/modes/x.ts:96:15)
╰─➤ https://github.com/pkgxdev/pkgx/issues/new

Works again after uninstall and reinstall :)

Thanks for the heads up, we'll monitor. Nothing occurs for why this would happen currently, especially since reinstall worked unexpectedly.

For me it started happening right after I interrupted an installation with Ctrl+C

Just started experiencing this as well. Can fix with pkgx --sync but it keeps coming back from time to time.

I have yet to experience it. If I do I'll be able to figure it out. Until then I’ll keep noodling.

currently experience the same thing with a slightly different log message in pkgx version 1.2.1
❯ dev
× unexpected error attempt to write a readonly database
│ Error: attempt to write a readonly database
│     at unwrap (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/util.ts:27:11)
│     at new Statement (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/statement.ts:110:5)
│     at Database.prepare (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/database.ts:138:12)
│     at Database.sql (https://deno.land/x/libpkgx@v0.19.0/vendor/sqlite3@0.10.0/src/database.ts:185:23)
│     at companions (https://deno.land/x/libpkgx@v0.19.0/src/hooks/useSyncCache.ts:119:18)
│     at eventLoopTick (ext:core/01_core.js:168:7)
│     at async Object.companions (https://deno.land/x/libpkgx@v0.19.0/src/hooks/usePantry.ts:72:16)
│     at async Promise.all (index 0)
│     at async default (file:///tmp/deno-compile-pkgx/pkgx/src/prefab/install.ts:9:25)
│     at async default (file:///tmp/deno-compile-pkgx/pkgx/src/modes/internal.activate.ts:26:25)

a pkgx --sync seemed to fix it. We'll see for how long

I can reproduce the issue now. It happens when I request a package which is not existing and canceling the process mit syncing.
After deleting the ~/.pkgx directory the issue is gone.
Log is attached.
log.txt

Unfortunately I cannot reproduce, but this does give me ammunition to try and figure it out. Thanks.,

Unfortunately I cannot reproduce, but this does give me ammunition to try and figure it out. Thanks.,

You are on Mac, right? Is the cleanup/signal handling different then on Linux?


[Windows] Fix deadline exceeded in daemon restart

Windows needs a bit more time to finish the restarting containerd. With the current 2 second timeout, we run the risk of exceeding that deadline.

/ok-to-test

@dcantah - I thought this was already solved by parallel reconnect?

@dcantah - I thought this was already solved by parallel reconnect?

Is this PR just Containerd on Windows takes > 2 seconds to startup and that's failing the test? I'd done some work to try reconnecting any task IO if containerd restarted, but not sure this is the reason for the failure in this test. https://github.com/microsoft/hcsshim/blob/master/internal/cmd/io_npipe.go#L77-L159

Is this PR just Containerd on Windows takes > 2 seconds to startup and that's failing the test?

Yes,

I'd done some work to try reconnecting any task IO if containerd restarted, but not sure this is the reason for the failure in this test.

It hink it's just a matter of timing. The wait time is just 2 seconds. If containerd takes longer to start on Windows, the test will fail. It's not an issue with hcsshim. The client tries to reconnect to containerd within 2 seconds after restart and sometimes (not always) fails.


Feature: Focusing on editor in IDE on Escape press

Feature: Focusing on editor in IDE on Escape press

Description

Problem: To switch back to IDE you need to click with mouse inside of editor.
Solution: Implementation of new handler will enhance user experience by providing an ability to switch between chat and code just with one press of Escape character.
[vscode] Esc in chat input box -> set focus back on IDE editor

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, only code improvements)
[ ] Documentation update

How to Test

Step 1: Open a new chat
Step 2: Press Escape on your keyboard (important note: you should be focused on textarea)
Step 3: See how your active tab switched from UI to actual editor (if it exists)

Checklist

[x] My code follows the code style of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.

Is it only when the user is interaction with the <textarea> that we want it to emit this event?

as I understood the task, then yes


Pass through non-pino lines

Fixes #94

I would leave the discussion about "pino" property to another PR/issue. However, I think we should just have a chops thing that also works with bole, bunyan etc.


2.0.14

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.66%. Comparing base (155170a) to head (0026e22).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   66.66%   66.66%
=======================================
  Files           1        1
  Lines           3        3
  Branches        1        1
=======================================
  Hits            2        2
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add ability to use secrets

Hi there, thanks so much for providing this Helm chart!
I have a feature request: it would be awesome if there was some way to pass SealedSecrets to the Vouch helm chart, so that I can take mine out of plain text. Specifically,

config.vouch.jwt.secret - https://github.com/halkeye-helm-charts/vouch/blob/master/values.yaml#L59
config.oauth.client_id & .client_secret - https://github.com/halkeye-helm-charts/vouch/blob/master/values.yaml#L66:L67

e.g. how the MongoDB Replica Set Helm Chart implements auth.existingKeySecret, auth.existingMetricsSecret, and auth.existingAdminSecret.
I could maybe take a stab at a PR in a couple of weeks, if you're open to that.
Cheers!

Always open to PRs. I'll see what I can do though. Existing is probably doable

Let me know if there's anything I can do to help.
FYI env var config is about to drop later the week.  Not sure if that would
be helpful in this situation.
On Tue, May 19, 2020, 2:15 PM Gavin Mogan<EMAIL_ADDRESS>wrote:

Always open to PRs. I'll see what I can do though. Existing is probably
doable
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/halkeye-helm-charts/vouch/issues/1#issuecomment-631086262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJUV267XM62KOH2FFP34QTRSLZF5ANCNFSM4NFK5ZMQ
.

I use helm secrets (sops) myself, so not a high priority for me, but it shouldn't be that hard to make all of https://github.com/halkeye-helm-charts/vouch/blob/master/templates/configmap.yaml a secret (i've learned a lot since this chart was made), and then if existingSecretName is set, just let you use existingSecretName instead of the chart populating it.
Just that new terraria dropped and I'm easily distracted :)

FYI - @bgehman offered this writeup including some details of his helm chart implementation using Secret instead of ConfigMap
https://github.com/vouch/vouch-proxy/pull/263#issuecomment-628297832

@halkeye I don't have much experience with SealedSecrets (what OP is asking for), but I can submit a PR for moving the existing ConfigMap to Secret (very minor changes needed).

Yea i'm not going to support sealedsecrets directly, cause its a custom resource descriptor that will break on some installs, but migrate from configmap => secret (👍 ) and supporting existingSecretName (👍) should handle the requested case

This should be fixed via 92aeca90d4491a56ea16ed0bafec4b6a61b7363a
I added existingSecretName if you want to completely override the secret the chart generates

closed via #


Error when using custom events

Example: trying Drab and using it with Bootstrap eonasdan datetimepicker. That component fires a dp.change event instead of a pure change event when date is changed.
If we add on a .drab template:
 <%= text_input @f, :start_date, drab: "dp.change:start_date_changed", class: "form-control datepicker", "data-date-format": "YYYY-MM-DD" %>

The event dp.change is fired but it's not picked up by Drab
This is probably because now Drab defines client side events in a very naive way. Actually it is:
function update_event_handler(node, event, func) {
  // TODO: learn more about event listeners
  // node.removeEventListener(event, func)
  // node.addEventListener(event, func)
  node["on" + event] = func;
}

So the node["on" + event] = func; is only suited to standard events like onchange, onclick etc.
This is happening with elixir 1.6.1, phoenix 1.3.0 and drab 0.7.7

Thanks for reporting!

@grych I submitted a PR to fix it.

Reopening, as it misbehaves in Firefox. Observe the first example from https://tg.pl/drab


qcelemental: 0.20.0 -> 0.21.0

Motivation for this change
Version upgrade. Contains the fixes, that required fetching extra patches for the previous version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.qcelemental


Expose number of bytes processed by StreamDeserializer

Fixes #183.
The byte offset is the number of bytes so far deserialized into a successful T. If a stream deserializer returns an EOF error, new data can be joined to old_data[stream.byte_offset()..] to try again.
let data = b"[0] [1] [";

let de = serde_json::Deserializer::from_slice(data);
let mut stream = de.into_iter::<Vec<i32>>();
assert_eq!(0, stream.byte_offset());

println!("{:?}", stream.next()); // [0]
assert_eq!(3, stream.byte_offset());

println!("{:?}", stream.next()); // [1]
assert_eq!(7, stream.byte_offset());

println!("{:?}", stream.next()); // error
assert_eq!(8, stream.byte_offset());

// If err.is_eof(), can join the remaining data to new data and continue.
let remaining = &data[stream.byte_offset()..];

cc @vorner @ShepMaster who were interested in #212.

I will also add a link to #70 saying that in the future I would like to change this method to return the number of bytes so far deserialized into a successful T or syntactically valid JSON skipped over due to a type error. I do not consider that a breaking change.
let data = b"[0] {"k":"v"} [";

let de = serde_json::Deserializer::from_slice(data);
let mut stream = de.into_iter::<Vec<i32>>();
assert_eq!(0, stream.byte_offset());

println!("{:?}", stream.next()); // [0]
assert_eq!(3, stream.byte_offset());

println!("{:?}", stream.next()); // type error
assert_eq!(13, stream.byte_offset());

As I'm one of the potential users of this, I can probably comment on the interface. I believe this would solve my use case (or make it significantly easier to solve, the is_eof was the crucial part and the number of bytes could be extracted by using a custom iterator ‒ possible, but complex and tedious).
One question, though. If I hit the EOF, I can take the remainder of the data, append more to it and create a new deserializer on top of it (obviously). But is there a way to reuse the existing one? Or is the deserializer lightweight enough so the creation of a new one doesn't matter?

Constructing a deserializer is lightweight enough.
In the future I see this being used in something like tokio-serde-json which would handle the EOF checking and juggling of the deserializer for you. For serde_json I would like to focus on providing the foundational pieces to make something like that possible.


How to fork?

I've forked your code in order to force TypeScript 1.5.0-beta.
Problem is when I reference my fork in my project package.json, the resulting typescript-register does not contain index.js nor index.ts (and thus it fails).
I guess there is a small step that I'm missing.
I was expecting that typescript-register index.ts would be listed inside package.json and that a postinstall npm task would be run each time a npm install/update is performed in order to generate the true index.js.

You need to compile it and check the compiled code in to fork.

How did you managed to not have to include index.js inside your own repo?

It's git ignored but included when I publish to npm, See Asana/typescript-starter for more information

I see. I'm so used to Bower where the package IS the Git repo. npm stores its own version (most of the time the files from the Git repo - not the case here).


Update webhook CLI docs

Signed-off-by: Shivam Mukhade<EMAIL_ADDRESS>
Changes

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

GTM

cluster restarted ! 😄 thats why pr keep running ..

/retest

Codecov Report

Merging #685 (7f29fa6) into main (9c17948) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
- Coverage   70.04%   70.03%   -0.01%
==========================================
  Files          61       61
  Lines        3769     3768       -1
==========================================
- Hits         2640     2639       -1
  Misses        869      869
  Partials      260      260

Impacted Files
Coverage Δ

pkg/cli/webhook/github.go
54.45% <100.00%> (-0.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c17948...7f29fa6. Read the comment docs.


[identity] 4.5.0-beta.2 release

Packages impacted by this PR
@azure/identity

API change check
API changes are not detected in this pull request.


Fixed disabled menu items bug on macOS

Fixes an issue where menu items were getting disabled by successive message box popups generated by the modal_msg and modal_err methods. See #8 for a more in-depth explanation.

Guessed that the focus issue might also be caused by the other popup windows created by open_file, save_file, and open_folder, which turned out to be a good hunch. Added a second commit to fix those as well.

Good find! I'll try to have a look at it on Windows and Linux and see if it breaks anything. I should also see if libui-ng has some examples on using those functions. I can't give you a time frame right now however.

As far as I can tell, that the behaviour under Windows and Linux is still good. I am not too concerned with this seemingly being a band-aid solution and will consider merging it.

It looks like the PR for a potential fix on the libui-ng repo to this issue might get approved soon, in which case this PR might become obsolete. Might be worth keeping an eye out for them to merge it and updating the libui-ng version to see if that fixes it.

I noticed and might revert the workaround when the time comes. Thanks!


Make a couple simplifications to the Kubernetes scaling docs

As called out in #3558.

Simplify explanation of the number of nodes in a Kubernetes cluster

Provide link to instructions for resizing GKE cluster.
There's also a single command that we could simply show the user:
gcloud container clusters resize cockroachdb --size=4
...but I'm not sure how to fit it in next to the links for GCE and AWS
without it looking out of place. Suggestions appreciated.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f2467a949bcb5d6cb14f0088aabd3772ae909d42/


#ifdef DEBUG indentation

I would like this kind of preprocessor defines to be indented on their expected level (maybe the inside line codes get an extra tab?) because this interferes with bracket folding mechanism

Closing it myself as I have found it indent-preproc-cond


Fixed typo in docs v5 (Utilities/API) page

Seems like there is a typo in : https://v5.getbootstrap.com/docs/5.0/utilities/api/
$utilities: (
  "opacity": (
    property: opacity,
    values: (
      0: 0,
      25: .25,
      50: .5, // This should be 75: .75
      100: 1,
    )
  )
 );

Since the generated class is :
.opacity-75 {
  opacity: .75;
}

@MohammadxAli please add the 2 cases @MartijnCuppens suggested :)


Update package to 5.1.2

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

It seems that for some versions of pip when using data_files it will store leap-seconds.list inside into a PythonVirgoTools-5.1.1.data/data/virgotools/leap-seconds.list directory rather than the installation directory. This leads to the leap-seconds.list not being found. To make this more consistent package_data is used in the setup.py instead to ensure the leap-seconds.list is stored in the correct directory.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[Awaiting Payment 2nd Sept] [Workspace Feeds] [$250] Spanish - "Hidden" is not translated to Spanish when going to card details in WS menu

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.16
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:
PreCond: App is in Spanish

Access New Expensify app
Sign into a valid account (Beta Enabled)
Go to a WS > Members > Invite a beta member
Click on Member name > Click on Assigned Cards section > Observe the CardHolder section

Expected Result:
User expects "Hidden" to be translated to Spanish
Actual Result:
Hidden shows in English, although the app is in Spanish
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/edec20b9-93db-4fad-a1d2-81e0ffe63abd
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dce39aec75aaa4cf
Upwork Job ID:<PHONE_NUMBER>160123531
Last Price Increase: 2024-08-05
Automatic offers:

DylanDylann | Contributor | 103492615

Issue OwnerCurrent Issue Owner: @slafortune

@slafortune  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@getusha is there a proposal here that will work?

@getusha What do you think about https://github.com/Expensify/App/issues/46709#issuecomment-2269246743

I think it’s better to avoid initiating a new Onyx connection just for this, if we have a simpler solution.
@Krishna2323 @daledah, how did you manage to assign the cards? Could you please share the steps, if possible?

@Krishna2323I don't think we have the correct root cause in your proposal. The translation was moved outside the function for performance reasons. https://github.com/expensify/app/commit/5ec39eb2117584f611031e1c8f659c5d6b447d3d
The root cause is that the default locale is being used because the function is called before the selected locale is updated in BaseLocaleListener.
https://github.com/Expensify/App/blob/93dc1c91437ea8cb9bd48a2a65f395e6da3c678b/src/libs/Localize/LocaleListener/BaseLocaleListener.ts#L7

We don't want to trigger the translate function every time getDisplayNameOrDefault gets called.

@getusha Sorry for the trouble but as this is part of the workspace feeds project, I think @allgandalf or @DylanDylann should handle this one as C+
Who can take it?

@mountiny I can take it as C+

We don't want to trigger the translate function every time getDisplayNameOrDefault gets called.
@daledah's proposal LGTM
🎀👀🎀 C+ reviewed

@techievivek I can handle this one since this is part of the workspace feeds project

This is being worked on, it will have a 7-day regression period, so I don't feel the need to add another BZ person to this.
I'll be out until 8/21 and will check in on this then.

Deployed to staging, not production yet

Hit prod 2 days ago, updating labels and titles.

Not overdue - Awaiting Payment Sept 2

@daledah please accept the invite to this job - https://www.upwork.com/ab/applicants/1820464850160123531/pending

No need checklist. This belong to workspace feed project

@DylanDylann Paid ✅

bump @daledah - please accept the invite so we can get this paid out 👍

@daledah I want to pay you 👍

@slafortune Ops, this bug is in the Workspace Feed Project. So I think I am not eligible for payment here. I already made a refund request on Upwork. So sorry about my mistake before
cc @mountiny

@slafortune This bug is in the Workspace Feed Project. So I am not eligible for payment here. I already made a refund on Upwork for the mistakenly paid amount.
We only need to pay for @daledah
cc @mountiny

@daledah I can redo this - but it was done for that same profile -

Resent - https://www.upwork.com/nx/wm/offer/103898558

Paid!


Prerender tries to render outgoing link

Describe the bug
First off, sorry if this is the wrong place, I am fairly new to all the things going on here.
I have been trying to create a blog which uses SvelteKit, mdsvex and a static adapter.
Everything works smooth until I start adding links inside the markdown files.
If any .md file has any outgoing link, it seems the prerender tries to find those sites on my site.
This causes it to fail ofcourse.
The issue can be resolved by setting onerror for the prerenderer into continue
but I would like to avoid that since now any missing posts will also be continuned.
Reproduction
Clone the repository and try running the build command
git clone https://github.com/percybolmer/pp-blog-svelte/tree/bug/prerender-outgoinglink
cd pp-blog-svelte
npm install
npm run build

Logs
percy@pc038:~/private/blog/pp-blog-svelte$ npm run build

> build
> vite build

vite v3.1.8 building for production...
✓ 75 modules transformed.
vite v3.1.8 building SSR bundle for production...
✓ 81 modules transformed.
Generated an empty chunk: "hooks"
.svelte-kit/output/server/vite-manifest.json                          4.99 KiB
.svelte-kit/output/server/index.js                                    69.60 KiB
.svelte-kit/output/server/entries/endpoints/rss/_server.js            1.42 KiB
.svelte-kit/output/server/entries/endpoints/api/posts/_server.js      0.43 KiB
.svelte-kit/output/server/entries/pages/_layout.svelte.js             1.58 KiB
.svelte-kit/output/server/entries/pages/_layout.js                    0.15 KiB
.svelte-kit/output/server/entries/fallbacks/error.svelte.js           1.50 KiB
.svelte-kit/output/server/entries/pages/_page.svelte.js               0.65 KiB
.svelte-kit/output/server/entries/pages/about/_page.svelte.js         0.38 KiB
.svelte-kit/output/server/entries/pages/blog/_page.svelte.js          2.57 KiB
.svelte-kit/output/server/entries/pages/blog/_page.js                 0.16 KiB
.svelte-kit/output/server/entries/pages/blog/_slug_/_page.svelte.js   0.81 KiB
.svelte-kit/output/server/entries/pages/blog/_slug_/_page.js          0.87 KiB
.svelte-kit/output/server/entries/pages/contact/_page.svelte.js       0.38 KiB
.svelte-kit/output/server/entries/pages/uses/_page.md.js              0.45 KiB
.svelte-kit/output/server/chunks/paths.js                             0.17 KiB
.svelte-kit/output/server/chunks/index.js                             3.53 KiB
.svelte-kit/output/server/chunks/index2.js                            0.97 KiB
.svelte-kit/output/server/chunks/index3.js                            0.79 KiB
.svelte-kit/output/server/chunks/hooks.js                             0.00 KiB
.svelte-kit/output/server/chunks/2.js                                 0.91 KiB
.svelte-kit/output/server/chunks/thumbnail.js                         0.12 KiB
.svelte-kit/output/server/chunks/preview-ide-of-the-future.js         23.67 KiB
.svelte-kit/output/server/chunks/test.js                              0.54 KiB
Error: Unknown variable dynamic import: ../posts/www.jetbrains.com.md
    at file:///home/percy/private/blog/pp-blog-svelte/.svelte-kit/output/server/entries/pages/blog/_slug_/_page.js:7:92
    at new Promise (<anonymous>)
    at __variableDynamicImportRuntimeHelper (file:///home/percy/private/blog/pp-blog-svelte/.svelte-kit/output/server/entries/pages/blog/_slug_/_page.js:6:10)
    at load (file:///home/percy/private/blog/pp-blog-svelte/.svelte-kit/output/server/entries/pages/blog/_slug_/_page.js:11:22)
    at load_data (file:///home/percy/private/blog/pp-blog-svelte/.svelte-kit/output/server/index.js:626:39)
    at async file:///home/percy/private/blog/pp-blog-svelte/.svelte-kit/output/server/index.js:1416:18
  500 /pp-blog-svelte/blog/www.jetbrains.com (linked from /pp-blog-svelte/blog/preview-ide-of-the-future)

System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.5 LTS (Focal Fossa)
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
    Memory: 1.99 GB / 15.36 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 17.9.1 - ~/.nvm/versions/node/v17.9.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v14.17.6/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v17.9.1/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 106.0.5249.61
    Firefox: 105.0
  npmPackages:
    @sveltejs/adapter-static: ^1.0.0-next.46 => 1.0.0-next.46
    @sveltejs/kit: 1.0.0-next.516 => 1.0.0-next.516
    svelte: ^3.52.0 => 3.52.0
    vite: ^3.1.8 => 3.1.8

Severity
annoyance
Additional Information
Hopefully it is not just me being dumb!

I think the reason is that one of your links in the Jetbrains Fleet blog post is missing the protocol: I've been waiting a long time for [JetBrains](www.jetbrains.com) to release ...
SvelteKit therefore treats it as an internal relative link and then fails.
Technically this "works as expected" but I'm wondering if we could make the error message more clear in this instance.

I've confirmed that you are right @dummdidumm
Adding https does in fact solve it.
Now that you mention it, it does make sense, but I recommend we either make it more clear in the docs that prerender will treat any URL without a protocol as internal. (Maybe its just me who is dumb, but I am gonna guess others will face this also)
Or as you say, make the error message a bit more clear, however that might be harder?:)
I remved continue on error and it is now building

make it more clear in the docs that prerender will treat any URL without a protocol as internal

It's not prerendering that's doing that, really. It's how links in HTML work. You have a link to a local URL .../www.jetbrains.com in your HTML.

@dummdidumm I'm not sure what we could do to make the error message clearer here. There is a dynamic import of this module in https://github.com/percybolmer/pp-blog-svelte/blob/bug/prerender-outgoinglink/src/routes/blog/[slug]/%2Bpage.js which is getting called for the catch-all route for all of the blog posts, and I don't think there's anything we could be doing here to notice that this is being rendered because of a link that is accidentally same-domain.

Ideally we could backtrack the error to invoking prerender on that link, and wrap that error message with something that gives it the proper context. Something like "error while trying to prerender link X" and we could even check if X starts with www. to say "if you expect this to be an external link, make sure to prefix it with the proper protocol (http or https)"

We can't solve this in the general case — the repro above no longer exists but from the clues still available it looks like the issue was that the crawler was trying to render /blog/www.jetbrains.com, which caused a non-existent module to be dynamically imported. Aside from very unwise regex hackery, there's no way we could figure out that the error resulted from a missing protocol.
I'm going to close this because as @Conduitry says, this is just how links work — it's not specific to prerendering or even to SvelteKit, so there really isn't a place that it would belong in the documentation.


Add example CLTK scaffold

Example code scaffold that illustrates two ideas:

An access-point for the CLTK's primary API interface. It accepts an entire document, in the way that spacy and similar allow (cltk = CLTK('Itaque metu.', language='la').
How language features could be built into the CLTK object, to run as default or by user parameter. In this example, CLTK.sentences() and CLTK.words() are both properties (@property) which illustrate how we can import functionality from specialist, hierarchical functions (here, cltk.tokenize.Tokenize.tokenize_text(), which itself imports the particular tokenizer_latin()). See the docstrings in cltk.py for examples.

What it DOES NOT show:

Each property generates its own new strings. So for example CLTK.words internally stores new output (['Quo', 'tibi,', 'imperator.']) whereas in the final version, I imagine, we will want to use string indices to the original document, then convert this to a list of strings upon user request. But I have only seen something like this done, never coded myself.
No pipeline here of any sort (other than the order in which the properties are declared in the __init__ of the CLTK class). I honestly don't know how to start with this, other than hard coding something and figuring out later how to abstract and parameterize it. Help needed.

There are a few new features, like a Makefile, that are the result of what we are or should be doing, to standardize the code base (mypy, uploading with twine, doctests).
cc @todd-cook #7
cc @free-variation #5
cc @diyclassics
This code is intentionally simplifying, so as not to distract from my point, which is to clearly explain the core notion I have had in mind for the API (what the user consumes and how the rest of the library is composed to all for its consumption). Please, do not hold back in your criticisms!

A few comments on miscellaneous updates:

The main API example is now at: cltk/nlp.py
Example of how we could stash away particular functionality, then call particular versions of it through chosen parameters or through default pipeline of a language: cltk/tokenize/tokenize.py
In the __init__.py files, I have done like from .utils import * -- I have resisted doing this for a long time, however when it's kept this simple, imports are cleaner. (eg, from cltk.tokenize import Tokenize instead of from cltk.tokenize.tokenize import Tokenize.
Just messing around in cltk/wrappers/stanford.py and getting my head around how it works. I still need your help in this, I am not trying to go this one alone.

My previous commit had some mistakes, breaking the docstrings, but they run OK now. I don't know how to auto download the stanford models, for the build server, so I don't expect them to build properly there yet.
To reproduce what I have done:
$ <mk and source virtualenv>
$ pip install -r requirements-dev.txt
$ python cltk/wrappers/stanford.py  # this will prompt you to download the greek models
$ make test

Coverage report (not that it's so important right now, but nevertheless):
$ make test
nosetests --no-skip --with-coverage --cover-erase --cover-html-dir=htmlcov --cover-html --cover-package=cltk --with-doctest
...................
Name                            Stmts   Miss  Cover
---------------------------------------------------
cltk/__init__.py                    1      0   100%
cltk/codes/__init__.py              0      0   100%
cltk/codes/glottolog.py             4      0   100%
cltk/nlp.py                        35     20    43%
cltk/tokenizers/__init__.py         1      0   100%
cltk/tokenizers/tokenizers.py      16      0   100%
cltk/utils/__init__.py              1      0   100%
cltk/utils/exceptions.py            1      0   100%
cltk/utils/utils.py                31      0   100%
cltk/wrappers/__init__.py           0      0   100%
cltk/wrappers/stanford.py         105     51    51%
---------------------------------------------------
TOTAL                             195     71    64%
----------------------------------------------------------------------
Ran 19 tests in 24.675s

OK

Other options in Makefile:
$ make typing
mypy --html-report .mypy_cache cltk
Generated HTML report (via XSLT): /Users/kyle/cltkv1/.mypy_cache/index.html
$ make lint
pylint --errors-only cltk


Getting Plinder-PL50 subdataset

Great work!
Is there any available way to fetch Plinder-PL50, which is utlized to test diffdock in your paper, without runing your pipeline?
I will be very grateful.
Best,
Liang

For example, can you provide a parquet file similar to "splits_metaflow_config_split_v2_split_multi_graph_yaml.parquet"

Yes, for all main splits please. It is quite difficult to use this data at the moment.

@VectorShi  - please, see the reply here:
https://github.com/plinder-org/plinder/issues/20#issuecomment-2283932341
We will keep updating on the improvements for data loading and further splits in the ISSUE https://github.com/plinder-org/plinder/issues/20 , hence will close this for now.

Thank you!
It's really a great help.


PHP_INI_SCAN_DIR env variable ignored by php binary

Since https://github.com/NixOS/nixpkgs/commit/82cd2fbbf470b0b53005737e8fd833a77cf2f38c it's not possible to use PHP_INI_SCAN_DIR variable to pass additional php configuration. That breaks https://github.com/symfony/cli https://symfony.com/doc/current/setup/symfony_server.html#overriding-php-config-options-per-project tools also.
To Reproduce
Steps to reproduce the behavior:
1 . Install php74
2. php -i | grep scan
Scan this dir for additional .ini files => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib
PHP_INI_SCAN_DIR => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib
$_SERVER['PHP_INI_SCAN_DIR'] => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib
$_ENV['PHP_INI_SCAN_DIR'] => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib

echo 'memory_limit = -1' > /tmp/php.ini
env PHP_INI_SCAN_DIR=/tmp php -i | grep -i scan

Scan this dir for additional .ini files => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib
PHP_INI_SCAN_DIR => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib
$_SERVER['PHP_INI_SCAN_DIR'] => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib
$_ENV['PHP_INI_SCAN_DIR'] => /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib

Expected behavior
env PHP_INI_SCAN_DIR=/tmp php -i | grep -i scan
Scan this dir for additional .ini files => /tmp
PHP_INI_SCAN_DIR => /tmp
$_SERVER['PHP_INI_SCAN_DIR'] => /tmp
$_ENV['PHP_INI_SCAN_DIR'] => /tmp

Notify maintainers
@globin @etu @ma27
Metadata
 nix-shell -p nix-info --run "nix-info -m"
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
  /nix/store/ajidkqg53y0zvh0m5cjgqiw3pf9cvlf0-bash-interactive-4.4-p23-dev
copying path '/nix/store/ajidkqg53y0zvh0m5cjgqiw3pf9cvlf0-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 5.9.16, NixOS, 20.09.2577.808b5dd5cbb (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.10`
 - channels(root): `"nixos-20.09.2577.808b5dd5cbb, nixos-legacy-20.03.3324.929768261a3, nixos-unstable-21.03pre262347.257cbbcd3ab"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

 cat /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/bin/php
#! /nix/store/a3fc4zqaiak11jks9zd579mz5v0li8bg-bash-4.4-p23/bin/bash -e
export PHP_INI_SCAN_DIR='/nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib':$(PHP_INI_SCAN_DIR)
exec -a "$0" "/nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/bin/.php-wrapped"  "$@"

Env variable concatenation should fix it

 cat /nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/bin/php
#! /nix/store/a3fc4zqaiak11jks9zd579mz5v0li8bg-bash-4.4-p23/bin/bash -e
export PHP_INI_SCAN_DIR='/nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/lib':$(PHP_INI_SCAN_DIR)
exec -a "$0" "/nix/store/1khli85mg6g0mrl66fnpy6wlm90m8qsh-php-with-extensions-7.4.12/bin/.php-wrapped"  "$@"

Env variable concatenation should fix it

This was intentional to avoid impure state, IIRC.
The php expressions we have now are very flexible. You can create a php executable to include any configuration desired on the fly like so:
nix-shell -p 'php.buildEnv { extraConfig =  "memory_limit = -1"; }'.
Also keep in mind you can pass configuration via -d memory_limit=-1 to any php instance.

This was intentional to avoid impure state, IIRC.
The php expressions we have now are very flexible. You can create a php executable to include any configuration desired on the fly like so:
nix-shell -p 'php.buildEnv { extraConfig =  "memory_limit = -1"; }'.
Also keep in mind you can pass configuration via -d memory_limit=-1 to any php instance.

By the way... are you familiar with direnv? Combine nix with direnv and you have a really powerful combo that accomplishes what you want and more.

By the way... are you familiar with direnv? Combine nix with direnv and you have a really powerful combo that accomplishes what you want and more.

@aanderse sure, I'm working on this kind of setup for my long running projects and I love it. Just migrated from 20.03 where we haven't soo much options.
However, for some short term scenarions (like clone, patch, test, remove) creating nix config is not an option. Most of projects maintain their own php.ini and symfony tool use them both for cli and web/fpm without any additional setup and cost.
I'm ok to use php -d / php -c php.ini, but https://symfony.com/doc/current/setup/symfony_server.html#enabling-php-fpm still ignores custom ini files on 20.09

@aanderse sure, I'm working on this kind of setup for my long running projects and I love it. Just migrated from 20.03 where we haven't soo much options.
However, for some short term scenarions (like clone, patch, test, remove) creating nix config is not an option. Most of projects maintain their own php.ini and symfony tool use them both for cli and web/fpm without any additional setup and cost.
I'm ok to use php -d / php -c php.ini, but https://symfony.com/doc/current/setup/symfony_server.html#enabling-php-fpm still ignores custom ini files on 20.09

I didn't know that HP_INI_SCAN_DIR can have multiple directories, but if that's the case, prefixing it in makeWrapper is fine.
I mean, we also do that for many other env vars such as PATH, LD_LIBRARY_PATH etc.

I didn't know that HP_INI_SCAN_DIR can have multiple directories, but if that's the case, prefixing it in makeWrapper is fine.
I mean, we also do that for many other env vars such as PATH, LD_LIBRARY_PATH etc.

Yeah I think that should be fine. I would like @etu and @talyz to give a thumbs up first, just to make sure the idea is congruent in their minds.
You're still happy if we don't automatically import /etc/php.d though, right?

Yeah I think that should be fine. I would like @etu and @talyz to give a thumbs up first, just to make sure the idea is congruent in their minds.
You're still happy if we don't automatically import /etc/php.d though, right?

Most of projects maintain their own php.ini and symfony tool use them both for cli and web/fpm without any additional setup and cost.

This claim seems interesting to me, I have, probably never seen a project provide a php.ini. And I've  been working professionally with PHP for about 10 years. And from what I can recall I haven't ever seen this before. Even working with symfony components along that way. So maybe some does, but I wouldn't say that "most projects does".

I didn't know that PHP_INI_SCAN_DIR can have multiple directories, but if that's the case, prefixing it in makeWrapper is fine.

I wasn't aware of this either, but from reading the documentation again: https://www.php.net/manual/en/configuration.file.php#configuration.file.scan
It's kinda clear that it allows the variable to be : separated as any other PATH like variable.
I'm fine with introducing the possibility for such impurity just for flexibility for usages such as @dxops

Most of projects maintain their own php.ini and symfony tool use them both for cli and web/fpm without any additional setup and cost.

This claim seems interesting to me, I have, probably never seen a project provide a php.ini. And I've  been working professionally with PHP for about 10 years. And from what I can recall I haven't ever seen this before. Even working with symfony components along that way. So maybe some does, but I wouldn't say that "most projects does".

I didn't know that PHP_INI_SCAN_DIR can have multiple directories, but if that's the case, prefixing it in makeWrapper is fine.

I wasn't aware of this either, but from reading the documentation again: https://www.php.net/manual/en/configuration.file.php#configuration.file.scan
It's kinda clear that it allows the variable to be : separated as any other PATH like variable.
I'm fine with introducing the possibility for such impurity just for flexibility for usages such as @dxops

@talyz there is backported version also https://github.com/NixOS/nixpkgs/pull/125407
can we merge it too?


LightningCLI does not overwrite optimizer defined in LightningModule

🐛 Bug
Hi,
First of all, thanks for the great work creating pytorch lightning. Lately I've been using the LightningCLI functionality and it really cut down a lot of boilerplate code and made the CLI easier to use. So thanks for that!
Unfortunately I found one detail where I either don't understand the documentation well, or the behaviour is not as intended: the optimizer defined in configuration file does not seem to overwrite one defined in LightningModule. configure_optimizers.
To Reproduce
Initially I used a hardcoded optimizer and scheduler defined in my LightningModule, like:

class MyBoringModel(LightningModule):
  ...
 def configure_optimizers(self):
        optimizer = torch.optim.RMSprop(
            params=[p for p in self.model.parameters() if p.requires_grad],
            lr=self.hparams.initial_lr,
        )

        lr_scheduler = torch.optim.lr_scheduler.ExponentialLR(
            optimizer, gamma=self.hparams.scheduler_gamma
        )

        return [optimizer], [lr_scheduler]

Then I decided I wanted to change to a different optimizer, so I added the following to the config I pass in to the LightningCLI:
# my_config.yaml
...

optimizer:
  class_path: torch.optim.SGD
  init_args:
    lr: 0.0001
    momentum: 0.9

...

A dummy example of the script I run:
# cli.py

trainer_defaults = {
        "callbacks": [
            LearningRateMonitor(logging_interval="epoch"),
            # Default latest model checkpoint
            ModelCheckpoint(),
            # Best performing model checkpoint
            ModelCheckpoint(
                filename="best-epoch={epoch}-loss={total_loss/test_epoch:.3f}",
                monitor="total_loss/test_epoch",
                auto_insert_metric_name=False,
            ),
        ]
    }

cli = LightningCLI(
        model_class=MyBoringModel,
        datamodule_class=MyIrrelevantDataModule,
        trainer_defaults=trainer_defaults,
        run=True,
)

When running the code python cli.py fit --config my_config.yaml I get the following warning:
UserWarning: `MyBoringModel.configure_optimizers` will be overridden by `LightningCLI.configure_optimizers`.

so I, incorrectly, assumed it would take the optimizer from the config, and either take the scheduler from my model's method, or no/a default scheduler. Instead, it seems to have just taken both the optimizer and the scheduler from my model's method. Is this intended? If so, should the documentation of LightningCLI regarding optimizers and schedulers be expanded to clarify this?
Small detail: the reason I assume the optimizer isn't being overwritten, is because LearningRateMonitor is still logging the learning rate of the optimize defined in the LightningModule, so I guess there is a chance the training is happening with the new optimizer, but the callback is logging the wrong optimizer.
Expected behavior
Overwrite the optimizer and scheduler from the LightningModule with whatever is provided from the config file, even if it's only the optimizer, or only the scheduler.
Environment

PyTorch Lightning Version: 1.6.0
PyTorch Version: 1.11.0
Python version: 3.8
OS (e.g., Linux): Linux
CUDA/cuDNN version: / (happens both cpu-only runs and gpu runs)
How you installed PyTorch (conda, pip, source): pip

Thanks!
cc @carmocca @mauvilsa

I am not able to reproduce the issue:
import torch

from pytorch_lightning.callbacks import LearningRateMonitor
from pytorch_lightning.utilities.cli import LightningCLI
from tests.helpers import BoringModel

class MyBoringModel(BoringModel):
    def configure_optimizers(self):
        optimizer = torch.optim.RMSprop(
            params=[p for p in self.layer.parameters() if p.requires_grad],
            lr=0.1,
        )

        lr_scheduler = torch.optim.lr_scheduler.ExponentialLR(optimizer, gamma=0.1)

        return [optimizer], [lr_scheduler]

lr_monitor = LearningRateMonitor(logging_interval="epoch")
cli = LightningCLI(model_class=MyBoringModel, run=True, trainer_defaults={"fast_dev_run": 1, "callbacks": lr_monitor})

print(lr_monitor.lrs)
print(cli.trainer.optimizers)
print(cli.trainer.lr_scheduler_configs)

Prints
{'lr-SGD': [0.0001]}
[SGD (
Parameter Group 0
    dampening: 0
    foreach: None
    lr: 0.0001
    maximize: False
    momentum: 0.9
    nesterov: False
    weight_decay: 0
)]
[]

which are the values from the config, as expected.


rebase on docusaurus

Preview screenshots:

So much love here... ❤ and LGTM

@usrbinkat attempted to build and run the container and hit the following error
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /src/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/src/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-08-25T21_16_41_885Z-debug-0.log

@sabre1041 I was able to reproduce the same err using the podman commands. Root caused it as an issue of podman (on my mac) not mounting the local directory into the container at all. this is a new behavior in the last 24 hours, I will look into it.
Alternatively, docker compose up works still and uses the pre-built image from ghcr.io/uor-framework/site


Allow to rename untitled buffers

Hello,
Can new and unsaved files be renamed? For when you just need a throw away buffer for what ever and there's no reason to save it. It's difficult to remember what you had in there when all are named Untitled-1, 2, 3
Thanks.

Is there any update to this feature? It would be immensely helpful for when you're dealing with a lot of scrap code.

Duplicate of https://github.com/Microsoft/vscode/issues/37414


Fix flaky tests on FreeBSD

Not sure if these are actual problems or simply flaky tests, but the following list of tests have problems on FreeBSD:

[ ] examples::4_sync_actor (#323)
[ ] examples::7_restart_supervisor (#323)
[ ] actor_ref::rpc_waking
[x] tcp::stream::try_recv
[ ] tcp::stream::send
[ ] tcp::stream::send_all
[ ] regression::issue_145

Following #374 and #442 I can't reproduce any of the failures anymore, so closing.


Use standard UnpackMessageOutput struct until finally needing to transform.

As suggested in review of #992

Codecov Report

Merging #1002 (bfa96b1) into main (ac35fdd) will increase coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head bfa96b1 differs from pull request most recent head ea89152. Consider uploading reports for the commit ea89152 to get more accurate results

@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   30.00%   30.00%
=======================================
  Files         416      416
  Lines       26929    26926    -3
  Branches     5244     5244
=======================================
  Hits         8080     8080
+ Misses      16653    16650    -3
  Partials     2196     2196

Flag
Coverage Δ

unittests-aries-vcx
30.00% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

aries_vcx/src/common/signing.rs
51.85% <ø> (+2.72%)
:arrow_up:


calico never rejects packets which belong to the kubernetes service without any endpoint

When I delete all the endpoint pods which bind to a kubernetes service,calico never rejects packet which belongs to the kubernetes service without any endpoint in the iptable rule "cali-FORWARD" in filter table.At the same time,kubernetes rejects the packet in iptables rule "KUBE-SERVICES" in filter table.
[root@node55 ~]# iptables -t filter -nvL KUBE-SERVICES
Chain KUBE-SERVICES (3 references)
 pkts bytes target     prot opt in     out     source               destination
    0     0 REJECT     tcp  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>        /* default/etcd-test: has no endpoints */ tcp dpt:2379 reject-with icmp-port-unreachable

But the "cali-FORWARD" just accepts the packet in filter table FORWARD chain,so the packets will not reject by the kubernetes iptable rule above.
[root@node56 ~]# iptables -t filter -nvL cali-pro-kns.kube-system
Chain cali-pro-kns.kube-system (6 references)
 pkts bytes target     prot opt in     out     source               destination
 471K   28M MARK       all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* cali:-50oJuMfLVO3LkBk */ MARK or 0x10000
 471K   28M RETURN     all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* cali:ztVPKv1UYejNzm1g */ mark match 0x10000/0x10000

Then if anther pod wants to connects the service,it will create a nf_conntrack without any DNAT.This action may leads a problem because the wrong nf_conntrack will be alive for 2 minutes.If the pod retries to connect within 2 minutes,the wrong nf_conntrack will refresh the alive time for another 2 minutes even if the endpoint pods come back.
ipv4     2 tcp      6 118 SYN_SENT src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=23344 dport=2379 [UNREPLIED] src=<IP_ADDRESS> dst=<IP_ADDRESS> sport=2379 dport=2334
4 mark=0 secctx=system_u:object_r:unlabeled_t:s0 zone=0 use=3

Expected Behavior

calico rejects packets which belong to the kubernetes service without any endpoint in "cali-FORWARD" chain in filter table.
Current Behavior

calico never rejects packets which belong to the kubernetes service without any endpoint in "cali-FORWARD" chain in filter table.
Possible Solution

Steps to Reproduce (for bugs)

1.deploy kubernetes with calico as its CNI
2.create a kubernetes service which binds to some healthy endpoint pods
3.delete all the endpoint pods
4.try to connect the kubernetes service in a client pod.
Context

Your Environment

Calico version
v3.7.4
Orchestrator version (e.g. kubernetes, mesos, rkt):
kubernetes v1.15
Operating System and version:
CentOS 7.5
Link to your project (optional):

I think this is a duplicate of the following issues (and a couple others I don't have links handy for):

https://github.com/projectcalico/calico/issues/1055
https://github.com/kubernetes/kubernetes/issues/78994

It should be fixed by this PR: https://github.com/projectcalico/felix/pull/2424
Which, will be included in the upcoming Calico v3.16.0 release.


Request for settings.properties file

Hello HighVolt-Dev,
May I request for a .properties file where we can specify static information like gateway type. It will eliminate the need for selecting values from a drop-down.
Another option can be to have a settings page, where the user can set values to various parameters from a drop-down value and those can be stored as browser cookies.
Thanks.

@CapabaleSpecimen I was planning on either having the configuration be specified in a file or saving the user's selections to LocalStorage in the browser. I have not yet added those enhancements as I needed to publish a proof of concept for the Carrier Aggregation and Cellmapper.net features which required the User login and also to quickly add support for the Arcadyan gateway. Your suggestion will make the application have a better user experience and I do plan to implement it when I have the time.

@CapabaleSpecimen your requested feature is now supported. See the updated README file


Integrating Youtube Playlists

Some clients of ours like to include Youtube playlists. However the js rewrites the embed code removing the ?list id. Is this a possible implementation in a future update?

try the newer version https://github.com/ashleydw/lightbox/tree/v4_0_1_jquery3_bootstrap4


haxelib versions

hello
everytime i reinstall ufront ( which i've just done now )  i have to erase dependencies version in the multiple haxelib.json of ufront , ufront-mvc etc ... like
"dependencies": {
"ufront-mvc": "",   // here
"ufront-orm": "1.1.0",
"ufront-easyauth": "", //or here
"pushstate": "2.1.0"
}
to make it compile .
is it a bug from haxelib or ufront ?

Discussed here https://github.com/ufront/ufront/issues/24#issuecomment-169520801


Update API resources with fleets rename

Change-type: patch
Signed-off-by: Chris Crocker-White<EMAIL_ADDRESS>

@balena-ci rebase


Bootstrap Migration For About Pages Card

This issue is meant to track the remaining work needed to close out the migration from css modules to react-bootstrap/styled components/typescript. This issue covers the AboutPagesCard component.
Success Criteria:

[ ] Refactor components to integrate Bootstrap and styled components while removing CSS modules.
[ ] When called for, find or create reusable (sub)components to reduce repetition and ensure uniformity.
[ ] Create or revise the Storybook story for these components, and any new sub-components.
[ ] Convert from js to tsx

This card just covers this work for the AboutPagesCard component.

Hello! I can take this.


luci-app-battstatus

For battery powered routers (currently only one, but easy to add more!), to show battery status. Screen shots attached. Only visible if router is a supported model.

Thanks for the pullrequest.
It's a cool feature.
Never the less I would suggest to abstract the queries in an ubus call.
That has a lot of advantages.

The HTML page becomes more clearer, because no cryptic commands are executed in the template.

And if other components in the system want to have this information, they would have to implement the same commands again duplicate code. If we have an ubus call, other components in the system could use this too for example prometheus/grafana monitoring stack.

An additional I am not sure if we want to have this polling in every page. Since only one system currently uses this feature the other 99.9% of the device does not have this. But maybe @jow could say more.

Thanks for the comments! A couple thoughts,

"I would suggest to abstract the queries in an ubus call" - likely not an issue, but not quite sure what you mean. LOL! Can you clarify?
"I am not sure if we want to have this polling in every page" - completely understand where you're coming from. I initially thought about making this a separate page, but as it's such a key item for a battery powered device, I concluded that it should be at the top of the / any page. But by all means disagree! Perhaps I could set the polling up to only happen for a supported device? Not sure about this, but I can dig more if desired.

Thanks again.

"I would suggest to abstract the queries in an ubus call" - likely not an issue, but not quite sure what you mean. LOL! Can you clarify?

I mean that this whole block
https://github.com/openwrt/luci/pull/3603/files#diff-270c8e9816cf971df35214112e003e15R13-R18
should be implemented in a separate ubus call. Look at this, for example.
https://github.com/openwrt/luci/blob/master/applications/luci-app-ddns/root/usr/libexec/rpcd/luci.ddns
The name could be hwmon.bat and the function could be status.
If we do this that way, then other packages could also benefit from this information.
For example:
-Polling thei info with another script ands end a notification to a backend if we have not enough power anymore

Watch the battery power with prometheus grafana checkmk or collectd

only some examples

@arrmo Hi, could you correct this?

"I would suggest to abstract the queries in an ubus call" - likely not an issue, but not quite sure what you mean. LOL! Can you clarify?

I mean that this block:
https://github.com/openwrt/luci/pull/3603/files#diff-270c8e9816cf971df35214112e003e15R13-R18
This should be implemented in a separate ubus call.
Look at this, for example:
https://github.com/openwrt/luci/blob/master/applications/luci-app-ddns/root/usr/libexec/rpcd/luci.ddns
The name could be hwmon.bat for example and the function could that get called should be named status. If we do this that way, then other packages could also benefit from this information.
For example:

Polling the info with another script ands end a notification to a backend if we have not enough power anymore
Watch the battery power with prometheus grafana checkmk or collectd

I like this idea - thanks! Let me give it a go. BTW, where does the resulting executable show up ... is it in (in the case you note), /usr/libexec/rpcd/luci.ddns?

I think this should be implemented in luci-app-statistics and then provide "show statistics on top bar" function.

And it would be great to implement as /sys/class/power_supply, so that collectd is supported out-of-box.
https://collectd.org/wiki/index.php/Plugin:Battery

I think this should be implemented in luci-app-statistics and then provide "show statistics on top bar" function. Because people may also want to see temperature of their devices.

Hi,
That could be an alternative of course, no issue here - but likely a bit more extensive than this ... agreed? And temperature - not currently supported, at least as far as I know.
Thanks!

And it would be great to implement as /sys/class/power_supply, so that collectd is supported out-of-box.
https://collectd.org/wiki/index.php/Plugin:Battery

Yes, agreed - but I don't know how to turn those i2c commands in to /sys/class/power_supply ... do you? Open to help, but that's past my pay grade :smile:

@arrmo Hi, could you correct this?

Sorry, to understand - pull in that PR to this one? Not sure I should be doing that, rather let that PR capture the updates for all apps ... right?

I ask if you could fix this error, not correct it in this Pull Request, because I see that you can modify luci-theme-material.

I ask if you could fix this error, not correct it in this Pull Request, because I see that you can modify luci-theme-material.

OK, got your point now. Let me take care of this PR (and the other I have open), then I can try to take a look at that one. Thanks!

I ask if you could fix this error, not correct it in this Pull Request, because I see that you can modify luci-theme-material.

OK, got your point now. Let me take care of this PR (and the other I have open), then I can try to take a look at that one. Thanks!

I understand you and can wait since it is not urgent. Regards!

Hi,
Just following up - anything more to do here, or is this looking OK (to pull in)?
Thanks!

Thanks for your work on this! To be honest, I don't like the implementation at all. The main problems I see are that a) themes need to be modified to work with it  b) a fork/exec happening on every page rendering.
I agree with @feckert that the actual battery query commands should be factored into an rpcd ubus plugin so that we can asynchronously query the data without blocking the render process.
I'll see if I can come up with a somewhat generic solution to put header notification badges.

themes need to be modified to work with it
Yes, agreed! I didn't like that either, but was trying to work with the current structure. We can evolve, no issue here at all.

come up with a somewhat generic solution to put header notification badges
That would be great - thanks! We can work through this together, no issue. Just yell, let me know what I can do to help.

Sorry, just checking in - any thoughts / updates on this? I'm more than happy to try to work on this, but not sure I'm the right person to try to define the (bigger) approach 🤣
Thanks!

I added a generic mechanism to add arbitrary notification labels, that is the first half of the solution. What is missing yet is a way to register code that should be executed with each view rendering, I'll hopefully get to it during the next days.

I added a generic mechanism to add arbitrary notification labels, that is the first half of the solution. What is missing yet is a way to register code that should be executed with each view rendering, I'll hopefully get to it during the next days.

NP, really appreciate it - thanks!!!

BTW, to the comment above - while you are working on the display mechanism here ... should I be trying to convert my code into a function (i.e. command line, returns result)?
Thanks!

Hi,
Sorry, just not sure what to do here, to get this included. Do you want the status / information collected via a script? But also, how to add it to the header (for battery display)?
Thanks!!!

HI @arrmo - sorry, I forgot about this open PR. So a while back I added a generic indicator mechanism which allows to add arbitrary badges to the top right notification area and implemented a proof of concept for GSM signal indication. I think you can adapt that for the battery level.
You need three parts for that: a client side JavaScript class which fetches raw values from ubus and renders them in an appropriate way, a server side ubus rpc applet to expose one or more procedures which provide the raw data, and an ACL specification which grants ubus access for the current user session.
After all three files are placed, you do need to log out of LuCI and issue an /etc/init.d/rpcd restart to pick up the new applet.

A preload class in /www/luci-static/resources/preload/cellsignal.js - any class in /www/luci-static/resources/preload is automatically instantiated for each page load.

'use strict';
'require ui';
'require rpc';
'require poll';
'require baseclass';

var callSignalInfo = rpc.declare({
	object: 'luci.cellsignal',
	method: 'getSignalInfo',
	expect: { '': {} }
});

var devices = {};

return baseclass.extend({
	__init__: function() {
		this.updateIndicator();
		//poll.add(L.bind(this.updateIndicator, this), 5);
	},

	handleDetails: function(ev) {
		var dev = ev.currentTarget.getAttribute('data-indicator').replace(/^signal-/, ''),
		    info = devices[dev];

		if (!info)
			return;

		ui.showModal(_('Signal details'), [
			E('ul', [
				E('li', [ E('strong', [ _('Device: ') ]), dev ]),
				E('li', [ E('strong', [ _('Signal: ') ]), '%s (%d)'.format(info.bar, info.signal) ]),
				E('li', [ E('strong', [ _('Type: ') ]),   info.type.toUpperCase() ]),
				E('li', [ E('strong', [ _('IMEI: ') ]),   info.imei ])
			]),
			E('div', { 'class': 'right' }, [
				E('button', { 'click': ui.hideModal }, [ _('Close') ])
			])
		]);
	},

	updateIndicator: function() {
		return callSignalInfo().then(L.bind(function(devs) {
			for (var dev in devs) {
				var info = devs[dev],
				    type = info.type,
				    rssi = info.signal;

				if (rssi == 0 || rssi < -85)
					info.bar = '▯▯▯';
				else if (rssi < -75)
					info.bar = '▮▯▯';
				else if (rssi < -65)
					info.bar = '▮▮▯';
				else
					info.bar = '▮▮▮';

				ui.showIndicator('signal-%s'.format(dev),
					'%s %s'.format(type.toUpperCase(), info.bar),
					L.bind(this.handleDetails, this));

				devices[dev] = info;
			}

			for (var dev in devices) {
				if (!devs.hasOwnProperty(dev)) {
					ui.hideIndicator('signal-%s'.format(dev));
					delete devices[dev];
				}
			}
		}, this));
	}
});

An ubus rpc applet /usr/libexec/rpcd/luci.cellsignal providing the luci.cellsignal getSignal call:

#!/bin/sh

. /usr/share/libubox/jshn.sh

case "$1" in
	list)
		printf '{ "getSignalInfo": {} }'
	;;
	call)
		case "$2" in
			getSignalInfo)
				json_init

				for dev in /dev/cdc-wdm*; do
					eval $(/sbin/uqmi -d "$dev" --get-signal-info 2>/dev/null | jsonfilter -e 'SIGNAL=@["signal"||"rssi"]' -e<EMAIL_ADDRESS>					eval $(/sbin/uqmi -d "$dev" --get-imei 2>/dev/null | jsonfilter -e 'IMEI=@')

					if [ -n "$TYPE" ] && [ -n "$SIGNAL" ]; then
						json_add_object "$dev"
						json_add_int signal "$SIGNAL"
						json_add_string type "$TYPE"
						json_add_string imei "$IMEI"
						json_close_object
					fi
				done

				json_dump
			;;
		esac
	;;
esac

An ACL definition in /usr/share/rpcd/acl.d/luci-mod-cellsignal.json - allowing access to the signal info procedure

{
	"luci-mod-cellsignal": {
		"description": "Grant access to cellular signal info",
		"read": {
			"ubus": {
				"luci.cellsignal": [ "getSignalInfo" ]
			}
		}
	}
}

No worries! Let me do some digging - my head is spinning a bit, but I'll figure it out ... LOL!
The example above seems to show where to put the files on the router, for development (i.e. to get it working). Once it's doing what it needs to => where do the files go in the LuCI source code (i.e. to push to the repository, so this app can then be made available in the builds)?
Thanks!

On the router, these three files should go into /www/luci-static/resources/preload/battstatus.js, /usr/libexec/rpcd/luci.battstatus and /usr/share/rpcd/acl.d/luci-mod-battstatus.json respectively.
Once things are functioning as desired, create the following directory structure in the repo:

modules/luci-mod-battstatus/

Makefile  (copy from e.g. modules/luci-mod-network/Makefile)
htdocs/

luci-static/

resources/

preload/

battstatus.js

root/

usr/

libexec/

rpcd/

luci.battstatus (make sure it is executable - chmod 0755)

share/

rpcd/

acl.d/

luci-mod-network.json

Will do, thanks! Once I have this working, will update this PR (or yell if you'd rather I close this one, open a new one - I can do it however you prefer).

Wow! That really works well, all up and running 😄. Just a couple questions,

I looking in ui.js, and the last parameter seems to be style, but only active or inactive? Is there a way to color the text I display (e.g. yellow or red, as the battery gets low)?
As the new method is really completely different - close this PR, open a new one? They are the same basic function, but really not all that similar in terms of the code or files.

Thanks!

Right, there is no style apart from active / inactive. However, after enabling the indicator you can obtain its node and place arbitrary contents. Example:
ui.showIndicator('foo', '');
document.querySelector('[data-indicator="foo"]').innerHTML = '10%';

Perfect, thanks! All working (on the router), now to build it. Put the files in the correct locations, but it's not showing up in make menuconfig ... I recall there was a trick to get it to show up?

Did you run the following commands?
./scripts/feeds update luci
./scripts/feeds install luci-mod-battstatus

Did you run the following commands?

I did! But I think I see the problem - because I'm on my branch, the update is failing => but if I stash my changes, to be able to go back to master, then the update won't detect of course. Catch 22 it seems 😞.
Hmmm, but I also see,
* (HEAD detached at origin/luci-app-battstatus) ac58fd8f5 Initial release, luci-app-battstatus
  master                                        2e2ab59ea [upstream/master] Merge pull request #4219 from rkkoszewski/rkkoszewski/feat/luci-proto-sstp

Not sure if detached is the issue (nor how I resolve that ... I'm a git-idiot 😆).

OK, I can't explain it, but re-did the git checkout, and now I get it working. Sorry for the hassle!
Building now 😄.

Woohoo! All working 😄. Pic below (and updated the commit),

Do you need anything else from me here? If so, just yell.
And BTW, the new approach ... ubus/rpcd in shell, JavaScript for updates - it's much nicer to debug, really easy in the browser debugger. Thanks!

Woohoo! All working 😄. Pic below (and updated the commit),

Do you need anything else from me here? If so, just yell.
And BTW, the new approach ... ubus/rpcd in shell, JavaScript for updates - it's much nicer to debug, really easy in the browser debugger. Thanks!

Out of curiosity, can you change where you get the information about the battery values?

Out of curiosity, can you change where you get the information about the battery values?

Yep! The code is part of modules/luci-mod-battstatus/root/usr/libexec/rpcd/luci.battstatus ... it could be extended, to execute different commands for different HW. Pretty straightforward really to extend it. And just return the same information / JSON object, no changes need to other files to get it to display.

Hi,
Sorry, just not sure if this is waiting on me - which is entirely possible, and I may just not know it ... LOL.
Thanks!

It looks almost perfect, just a  detail left - in the Makefile, please remove the copyright notice or set it to yourself

Wy did you delete  the file themes/luci-theme-rosy/luasrc/view/themes/rosy/header.htm  in this pullrequest?

It looks almost perfect, just a detail left - in the Makefile, please remove the copyright notice or set it to yourself

Done! Will push in a few minutes 😄.

Wy did you delete the file themes/luci-theme-rosy/luasrc/view/themes/rosy/header.htm in this pullrequest?

I wasn't necessarily meaning to, but when I tried to revert my changes, it removed this file. I did ask, and was told that this theme is no longer supported, and it doesn't show up in my menuconfig build. I can restore it if needed. Thanks!

Yes, please restore themes/luci-theme-rosy/luasrc/view/themes/rosy/header.htm, it should not be touched by your PR.

Yes, please restore themes/luci-theme-rosy/luasrc/view/themes/rosy/header.htm, it should not be touched by your PR.

Done - restored! Hopefully all good now 😄.
Thanks!

Hi,
Please just yell if I missed (or messed up) something - always possible, even probable 🤣.
Thanks!

Merged with some adjustments in dcac704b3d6bc3c4ad2ccacb3d79fc67d900087f - thank you for your time and effort!

Thanks! BTW, I have some thoughts how to add more (different) HW in the future, storing needed commands in JSON. Just yell if that comes up 😄.


attach_file doesn't attach the file

I'm trying to use the code from #342 but I cannot get attach_file to work. It works fine in selenium, but not poltergeist.
pry(#<RSpec::ExampleGroups::SellerManagesProducts::EditsAProduct>)> attach_file("seleniumUpload#{index}", files[index])
=> true

pry(#<RSpec::ExampleGroups::SellerManagesProducts::EditsAProduct>)> evaluate_script('console.log($("#seleniumUpload0").get(0).files.length)')
0

The file does exist and this same code results in 1 being logged in selenium. I am using capybara 2.4.4 and poltergeist 1.6.0 with phantomjs 2.0.0.
I found the phantomjs uploadFile method, which I think is how I need to fix this problem but I can't figure out how to call a phantomjs method through poltergeist.

File uploading is broken in PhantomJS 2.0 you can downgrade to 1.9 or wait when they fix it

Thank you for your time, I thought it might be an incompatibility between 2.0 and poltergeist but I didn't think it would be 2.0 by itself.

No problem =) it's known issue https://github.com/ariya/phantomjs/issues/12506

FYI -- this should be fixed via PR #686 - now merged into master

Thank you @twalpole !


Outline on objects that have multiple materials

When I use this script with an object with two different Uv maps ( two materials)but only one mesh I have this:

This is how it looks like in the editor:

How can I modify the shader to have all the obj outlined?

For everyone that stumbles across this, here is the solution to this issue.

This functionality is now built into the latest version. Thank you!
(Please note that the solution referenced above, on Unity Answers, has a memory leak when running in the editor.)


Books

Add https://github.com/Killkitten/Thinkerview-Recommandations-lecture to the app.

Hello @PierreBresson, 3 weeks ago, I started to build an app to organise and share valuable & organised content as collections.
My first idea & contribution was to index Thinkerview books recommendation, then I found out this great github list! I still did it to show how my app could be used : https://tottem.app/thinkerview
I did not share this link yet because I would like to inform Thinkerview team (you?) before, and ask for permission (and feedback). I tried to use contact form on thinkerview.com but it did not work: that's why I looked for this github issue :) I also sent facebook message!
Could be nice if we discuss about it, I think you could find my email somewhere!

Let me know if I should properly open an issue about my contact issue


issue with RS density fit for periodic systems

Hi all,
I was testing the range-separated density fits on calcium oxychloride, copied here. I found that SCF, while it converges for GDF, does not converge at all for RS-DF, which was surprising to me. If we run with a kmesh of 111, they both run, converge the same,  and agree on energy. I could not reproduce this on a simpler example system unfortunately.
test_rs.tar.gz

Thanks, we'll take a look. Sometimes the improved precision of RSDF actually amplifies numerical issues, e.g. linear dependencies in the basis set or the aux basis. In these cases, the success of GDF is somewhat fortuitous. Not sure if that's what's going on here though.

Hi Lucas, the issue is with the AFTDF code in PySCF which is independent of RSDF. Particularly, if you replace this line with
bvk_kmesh=None

RSDF converges to the same answer as GDF (For the SCF energy, I got -1314.89735407836 with RSDF which matches your GDF number -1314.89735374591 to about 1e-7 Ha).
I haven't managed to pinpoint exactly which part of the AFTDF code caused this issue (@sunqm any thoughts?). But for now, changing the line I mentioned above is enough to get RSDF to run.

@sunqm Particularly, the issue is with the BvK code in the AFT module. I found in quite a few systems that when the unit cell is large, the AO-pair AFTs are not accurate when using BvK. The system Lucas used is a good example: even a k-point mesh as small as 2x2x1 shows this problem.

Thanks for looking into this so quickly! I'll be excited to use it when it's resolved.

@lkwagner will let you know when the bug with AFT is resolved!
But as I said, there's no bug related to RSDF at this point. So if you don't minding hacking a tiny bit, the one line change I mentioned earlier is sufficient for now.

Maybe sth to do with _estimate_overlap?
in
https://github.com/pyscf/pyscf/blob/290413d451c3b5b10d16a1d49b90285ef2c9bfd7/pyscf/pbc/df/ft_ao.py#L188

@lkwagner Which branch do you use? I tried this system with branch https://github.com/pyscf/pyscf/tree/rsjk-rsdf. Your script gives -1314.89737363138. Although slightly different to Hongzhou's results, it does not get any convergence problem.
I'm not particularly sure what is the main cause of the accuracy problem. bvk_mesh and overlap estimation might be two sources. However, relevant estimations are treated very conservative. Each quantity itself should be converged tightly to the precision required (or at least very closed to the required precision).  I'd suspect the discrepancy is caused by the accuracy of the 2-center Coulomb integrals. Because it's basically the denominator in density fitting errors may be enlarged. In this regards, tuning the density fitting auxiliary basis may be able to change the accuracy. Many possibilities have to be tested.
For the moment a quick workaround is to tighten the accuracy parameter cell.precision=1e-12 . It will slow down the RSDF construction but it should still be faster than the GDF implementations on the main branch.

@sunqm , I used the main branch. To be clear, we are fine just using GDF for the moment; we don't need a workaround. We just found behavior that we thought you'd like to address and so reported it.

This problem is caused by the numerical issues in the eigenvalue solver and other matrix decomposition procedure for complex matrix. Even every quantity is converged to the desired precision, I can still observe non-negligible errors in the 3-index tensor cderi. Error becomes especially big when linear dependency is found in the auxiliary basis because the overlap of aux basis has contribution to the denominator in DF tensor decomposition. GDF does not cure the issue. It just happens to be stable in some tests due to the GDF implementation in v2.0. In this version quantities are converged far more tightly than the required precision and this leads to relatively small errors (and this is also the reason GDF is slow in v2.0). When "better" integral screening was used similar numerical problems are also observed in GDF. It seems quite difficult to overcome the issue simply by the implementation or the algorithm. Aux basis suitable for periodic systems needs to be developed.

Hi @sunqm were you talking about specifically Lucas' example? I asked bc in his example script, he used cell.exp_to_discard = 0.2, which is very conservative and essentially removes any linear dependency issue in the basis set (for example, the AO basis overlap matrix has a condition number of only 300, while the usual "problematic" case I found has a condition number close to 1e10) and the corresponding fitting ETB.

Yes. I'm talking about the error in the 2-center 2-electron integrals for the auxiliary basis. Errors are more significant than other treatments. Even each quantity (the 2-center integral matrix, the 3-center integral tensor) converges to the required accuracy, the generated 3-index tensor has larger errors which causes uncertainty in SCF results at the more significant decimal place.

This issue is caused by the aft module bug of pyscf v2.0.0 but in version 2.1.0 the bug has fixed. So the fastest way to solve this problem is to use pyscf of the lastest version(>=2.1.0) or you can set bvk_kmesh=None to use the non bvk algorithm as hongzhou suggested. If you insist on using the bvk_kmesh version of pyscf v2.0.0 ,you can fix the bug as following:
File:pyscf/lib/pbc/ft_ao.c(pyscf v2.0.0)
Two function have the same issue(_ft_bvk_k and _ft_bvk_nk1),the offset of ovlp_mask is wrong.
/*
 * Multiple k-points for BvK cell
 */
static void _ft_bvk_k(int (*intor)(), int (*eval_aopair)(), void (*eval_gz)(),
                      void (*fsort)(), double complex *out,
                      int nkpts, int comp, int nimgs, int bvk_nimgs, int blksize,
                      int ish, int jsh, int *cell_loc_bvk, char *ovlp_mask,
                      double complex *buf, double *env_loc, double *Ls,
                      double complex *expkL, int *shls_slice, int *ao_loc,
                      double *sGv, double *b, int *sgxyz, int *gs, int nGv,
                      int *atm, int natm, int *bas, int nbas, double *env)
{
        const int ish0 = shls_slice[0];
        const int jsh0 = shls_slice[2];
        const int jsh1 = shls_slice[3];
        const int njsh = jsh1 - jsh0;
        ovlp_mask += (ish * njsh + jsh) * nimgs;
...
}

The shape of ovlp_mask is (nbas,nbas,nimgs),and shls_slice[:4] = (ish0,ish1,jsh0,jsh1)[ish0,ish,jsh0,jsh1 \in (0,nbas)] means that we calculate the slice (ish0-ish1,jsh0-jsh1).So the code above should be corrected:
{
        const int ish0 = shls_slice[0];
        const int ish1 = shls_slice[1];
        const int jsh0 = shls_slice[2];
        const int jsh1 = shls_slice[3];
        int offset_ish = ish0 + ish;
        int offset_jsh = jsh0 - nbas + jsh;
        ovlp_mask += (offset_ish * nbas + offset_jsh) * nimgs;
...
}

as the same the _ft_bvk_nk1 function also needs to be corrected.
Before correction:converged SCF energy = -1378.44207434398(wrong result)
After correction:converged SCF energy = -1314.89735407836, which matches hongzhou's result.

@ElonDormancy thank you for analyzing the problem and finding the bug! Could you please create a PR to fix the bug?

Hi @lkwagner , thanks for raising this issue. @hongzhouye @sunqm @ElonDormancy has it been fixed now with PR #1622 ?

Feel free to reopen the issue if errors persist in pyscf-2.6 and newer.