chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-06-23)
Features

update csv for 2024 (e8dbb31)

Documentation

update readme (bf828bf)

Miscellaneous Chores

release 1.0.0 (e185c7c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/pythoninthegrass/oklahoma_cooling_centers/releases/tag/v1.0.0 :sunflower:


feat: SDS EDV format provider

This new provider type allows for data to be stored in an underlying provider using the EDV document models.
Signed-off-by: Derek Trider<EMAIL_ADDRESS>

Note for reviewers: I recommend you start by looking at the edvformatprovider.go file. Then dig in to the other pieces referenced there.


Add id field to Identification Service Area

The previous version of the API accidentally omitted the id field for Identification Service Area, but that has now been corrected.  Whenever an IdentificationServiceArea is returned, its id field should be populated.

This seems to be fixed now.


After Certain Number of Auto Restart Server Dont allow connection

Server Stop Accepting Connections after certain number of auto restart :|

Wait, do you want this as a feature, or is that in issue you've ran into?

@Agarian It's a issue that he has run into.

yup its an issue

@ZfsrGhS953 and @cowpits Pls Halp :  |

Is the server running on codeanywhere? If it is set your serverIpLimit = 0 default is 4.
reason you do that on codeanywhere or some other VPS is because the external IP is NAT'd to an internal IP so all connections are coming from the same internal IP.

nope I use a dedicated server and I didnt change the ip limit

can you set your serverIpLimit to 0
also who's your hosting company and share your site link if you want to.

how many servers? and are they all set to auto restart?
because i do auto restart and i never run into issues with people not reconnecting. I restart every 7 minutes on one server and the other every 60.
so really check your serverIpLimit and set it to 0

i tested your servers
http://agar.io/?ip=game.fzogar.xyz:4000  and http://agar.io/?ip=game.fzogar.xyz:4001
i spawn frozen but shows me twice on leaderboard
http://agar.io/?ip=game.fzogar.xyz:5000 couldn't connect with agar client but could with mine
http://agar.io/?ip=game.fzogar.xyz:5001 was fine
http://agar.io/?ip=game1.fzogar.xyz:4000 and http://agar.io/?ip=game1.fzogar.xyz:4001 were fine but game play is sluggish
the 1st 4 servers are on this VPS IP = <IP_ADDRESS>
the last 2 are on this VPS IP = <IP_ADDRESS>
What are the number of CPU Cores and RAM for each?
Here test them on my test client here if you like http://www.tutorialscow.96.lt/tutorial/

@cowpits sorry for the late reply. Those are running on 8 core and 16 gb vps and I didnt update all the servers to auto restart update.. was checking with only one server atm.
Lemme check with serveriplimit=0 and tell you what happends
Thanks

@cowpits how to overcome the sluggish, I almost made it to match the agario vanilla setting :|

That was my bad on the typo for the 5000 port.
Anyway, 8 cores and 16g ram is enough to run 6 servers but you are sharing the Nick.
I always tell people to get 1 core and 2gig ram VPS and run one server, rather than a loaded VPS and many servers. There's a lot of traffic in the game and client. Also location plays a big role as far as connection.
Try running a couple of servers and see if it improves performance instead of running them all at once.
I'm testing my BOTS server on a VPS 1vCPU and 2Gig ram with unmetered bandwidth. $3.49/month. Seems to be doing ok and no complaints about lag. At that price I'll get 2 more if I need to.

@cowpits setting serveriplimit=0 Worked Tysm and about the vps I will try to change next time : )


Windows-based containers

Docker allows users to run both Windows-based and Linux-based containers.
Currently, werf build process is based on local Docker daemon and works only with Linux containers.

With the active development of Windows Subsystem for Linux we don't see a value in Windows-based containers anymore.


[ignoreWhitespace] are newlines equal to spaces?

I'd like to use html-differ to write a test system for marked, where generated html output is to be compared to pre-written html code, to determine if the two are equivalent, so I would like to ignore whitespace differences, when they are not meaningful (as in
 tags), but I noticed that newlines are treated differently than spaces:

A link. Not anymore.

is not considered equal to

A link.
Not anymore.

when, IMO, they should be.
I've tracked this to be probably determined by this line of code (line 39 on the right).
I'm aware this issue is related to CSS, and not HTML itself. According to CSS specification, when the white-space property is not pre, pre-wrap, or pre-line, segment breaks (i.e. newlines) are usually converted to a space U+0020.

Ah, now I see what went wrong there.
Since you strip all newlines in ignoreWhitespace(), the following two paragraphs are equivalent:

wrapped
paragraph

wrappedparagraph

HtmlDiffer = require('html-differ').HtmlDiffer;
htmlDiffer = new HtmlDiffer();
first = '
wrapped\nparagraph
';
second = '
wrappedparagraph
';
console.log(htmlDiffer.isEqual(first, second));
> true

I think you should replace them with a space to adhere to the segment break transformation rules for non-pre white-space CSS styles. Multiple adjacent spaces are then collapsed to a single one in the next step, so the following two paragraphs will be equivalent, instead:

wrapped
paragraph

wrapped paragraph

which looks correct to me!


Adds PageInfo support to QueryExpression.

@mbhnyc  I saw you requested PageInfo support in #55.  I took a shot at it.  What do you think?

@mbhnyc I've figured it out.  See the updated README for the example.

resolves #48


First draft of a new "ui" module (WIP)

This module contains a convenience layer to display various widgets,
such as windows, buttons etc. It also manages these elements' alignment,
size and all.
This is a squash commit of a WIP branch I have been maintaining for a
couple of weeks to support the development of another projet. Until now,
I had no idea where I was going with the UI module, but now things are
starting to take shape and I'm gearing up for a first PR.
In addition to the new UI modules, a couple of changes have been made to
core:
Coordinate removal: The purpose of Coordinate was exactly the same
as Option. Replaced usage of Coordinate with Option.
Cursor un-traiting: The Cursor struct had an overly complex trait
structure that it was te only one to use. I moved in all directly in
Cursor.
Positioning and size consolidation: With the UI module, position and
size take a new, heightened importance. I renamed Pair type to Pos,
added a new Size type and added HasSize and HasPosition traits.
Only HasSize is used in core (HasPosition is used in ui), but it
felt weird to have both these traits at difference places, so all in
core...
New CellAccessor trait: With the new ui module, we need a common
interface to "write cells to an arbitrary surface", with that surface
being either a sub-window or the terminal itself.
On the "ui" side, we have (for now):
widget: a surface with a size and position in an arbitrary parent. We
draw in it like we would in a terminal, and then draw the widget itself
in another CellAccessor.
painter: A convenience trait that applies to any CellAccessor with
useful methods for easily painting multiple cells, such a printline()
or draw_box().
button: a widget that draws its text wrapped around <> brackets and
highlights a chosen accel char.
layout: Helpers to easily align widgets inside each other.
All of this is heavily WIP, but I think it's advanced enough to open a
PR to start a discussion about the API design.

(I'm working on new examples right now to showcase the new module)

I think I have to insist that this is very much a work in progress and that I don't find the API particularly elegant. I'm just banging around some code to make my things work and, being relatively new to Rust, I often fight the borrow checker which in turn influence the way I design the API.
The reason I open this PR is to get a first impression from you, @cpjreynolds and see what we can do to improve it for an eventual merge upstream.

This is fantastic, thank you so much for the time you have put into this! I have to admit I haven't been able to give this project as much attention as I would like as of late, college applications have been taking up almost all of my time. As soon as the rush is over I should be able to devote a more significant proportion of my time working on this.
Abstracting over any drawable surface (like windows, panels, screens etc) will be great, and allow us to implement the same painting algorithms/logic for all surfaces.
This PR looks great, I like a lot of what you have done. The biggest issues we're going to encounter in getting this merged upstream are merge conflicts from my own local changes. In the coming week or so there will most likely be some internal api changes that affect this PR. Apart from that, this looks like a good direction to be going in. Thanks again for your work!

Is there any movement to get this merged soon? I just submitted https://github.com/cpjreynolds/rustty/pull/18 , which can be rewritten with these new features if it makes it into rustty

I'm wondering if we should not be more liberal with merging unfinished stuff to master. @cpjreynolds seems to have little time to devote to rustty lately and PRs are blocking each other (I myself have other ideas of stuff to implement, but I'm kind of lost in WIP branches). This is a very young library, maybe we shouldn't needlessly stifle its development with premature quality standards.

Agreed @hsoft , this library is really cool and I'd love to see it develop. Introducing widgets is a big setup up and would be super beneficial imo. This should be merged asap, otherwise I'll be forced to use hsoft's fork for my projects

@hsoft and @Syntaf, the more I think about it the more I agree with you. There's no reason not to get beneficial patches like this and others merged in a faster manner. Apologies for my relative absence, and thank you for the PR!


element.py: Include weak cache key in cache key calculation.

This should eliminate a class of issues related to strict/non-strict
discrepency.
This also updates the cache key test.
Fixes #1270

This PR replaces #1421 as discussed here, it is insufficient to consider only the Element.BST_STRICT_REBUILD flag, since dependencies can themselves be considered strict individually.


Update free-courses-en.md

Next.js update

Next.js update

Are you sure? Why then is TOC fragments refactored and Bootstrap moved without move section items?
Please! Try to scope the PRs to it contents. E.g. all new resources joint in one and apart from listing structures

As @davorpa says, please try to scope your PRs to one issue at a time.

Are you sure? Why then is TOC fragments refactored and Bootstrap moved without move section items?

@eshellman too fast! After merge 271d67f4d993225e3049d753dd95db4538f7ad3a, the Bootstrap resources are out of sync with it place in TOC. Needs a hotfix PR to move them as HTML and CSS subsection

sorry about that. will hotfix if its still needed after reviewing all the other PRs.

sorry about that. will hotfix if its still needed after reviewing all the other PRs.

Fixed by #7019


Foundation: correct Thread.callStackSymbols on Windows

We would previously print invalid strings due to invalid memory
pointers.  This corrects that and takes the opportunity to simplify some
of the deallocation handling by using a temporary allocation.

@swift-ci please test


[Feature Request] Check That Pokemon Storage Is Full Before EvolvePokemon Action

It would be nice to put a condition on the EvolvePokemon action to only run when the pokemon storage is full. Something like this:
		{
			"type": "EvolvePokemon",
			"config": {
                "evolve_when_storage_full": true,
	            "evolve_all": "Pidgey, Weedle, Caterpie",
	            "first_evolve_by": "cp"
	        }
		}

You can try out my pull request and give me your comments about it.
https://github.com/PokemonGoF/PokemonGo-Bot/pull/2956

This looks promising. Can you update the config file with an example of the new task and it's parameters?

@JonnyBoy333 can this be closed now that the PR has been merged?

I'd say so. Just updated to the latest commit so I'm eagerly testing the new feature out.


Adding documentation for loss functions.

Initial pull request for documenting loss functions. Feel free to make suggestions as still figuring out how to contribute.

Thanks @marii-moe - merged. I have also added a title to the notebook called "Loss Functions" :)

Thanks @marii-moe - merged. I have also added a title to the notebook called "Loss Functions" :)


no hot reload when changing scss file

I have two files in assets/css namely main.scss and _custom.scss. The main.scss will import _custom.scss and ~bootstrap/scss/bootstrap.scss(bootstrapv4). The _custom.scss have some customized bootstrap variables.
In the nuxt.config.js, I can just import ${__dirname}/assets/scss/main.scss to include a customized bootstrap4 globally.
But when I change the variable defined in _custom.scss, the page doesn't automatically reload. May I know how to make it hot reload when changing _custom.scss file?
I'm on<EMAIL_ADDRESS>

Sorry to bother, it actually can do hot reload.


Code snippet truncated in documentation (".NET Core - New Database" tutorial)

On the page at https://github.com/aspnet/EntityFramework.Docs/blob/live/entity-framework/core/get-started/netcore/new-db-sqlite.md#create-your-model there are instructions to paaste code into Model.cs, however the only code shown is:
using System.Collections.Generic;
using System.IO;
using Microsoft.EntityFrameworkCore;

namespace ConsoleApp.SQLite
{

And then I realize that snippet is meant to be truncated as later snippets are meant to be added to this.
(Maybe include some ellipses and the closing namespace brace in this so it's obvious it's not just cut off)


Reducing buffer size to 1400

Were using the NonBlockingStatsDClient to push to a statsD_exporter endpoint that prometheus picks up from.
We've noticed that we were dropping a lot of data, although we were sending it correctly.
Looking into it it seemed to be that the size of the packets was too big.
Given how the message buffer gets filled up; in the case where it was getting close to the 1500 mark, the addition of the ethernet/udp headers was pushing it past the MTU size causing fragmentation.

Nice catch @KotaiVictor thanks!
Will try to bake a new release before the end of the week.

Shouldn't the DummyStatsDServer be updated to use a 1400 byte length buffer too?


Updates for uploading ISMIR18 to Zenodo

major refactor of data models, introducing more strict field definition (value checking is left out though)
shards the one proceedings JSON database into one per year
proceedings database uses the IsmirPaper entity type

couple nits before this is merged, but perhaps worth a test or two...

Yeah, nice work here, Eric!
Got pretty big after all :)
I think this will be a "test-in-practice" thing and see if it breaks. :)

closes #20

closes #15

closes #14

closes #12, via changes to upload_file

closes #13


Increase maximum profile

Firstly, thank you for useful extension.
Issue type
Feature request
What problem does this feature solve?
Maximum profile is about 40.
Beyond that, the role does not increase.
I would like to add about 100 profiles.
Version:

AWS Extend Switch Roles: 0.8.0
Chrome 65.0.3325.181

Steps to reproduce

Open Configuration
Add profiles

[profile base]
output = json
region = ap-northeast-1
aws_account_id =<PHONE_NUMBER>00

[profile dev-readonly]
output = json
region = ap-northeast-1
role_arn = arn:aws:iam::100000000000:role/role-readonly
source_profile = base
color = B7CA9D
...

Save
Refresh browser

The sync storage size limitation of Chrome extension causes this problem.

Is there a way to go around this? e.g. disable Chrome extension sync?

Is it possible to separate the profiles into categories to limit what profiles are visible at a single time?, or have the extension read from a config file stored in the cloud or locally?

I found an example of a workaround for the storage limit in Chrome - clearly it's not a complete solution, but it could extend the size of the data that could be stored locally: https://github.com/kdzwinel/Context/blob/master/js/classes/HugeStorageSync.class.js
The class allows you to store multiple QUOTA_BYTES_PER_ITEM  size items.

Same plugin works on Firefox, that was my solution.

Experiencing this same issue, needing to have many accounts/profiles. Firefox is working as a workaround, thanks @Hount, but I'd love to have this working in Chrome.

Same plugin works on Firefox, that was my solution.

Only thing about firefox is, you don't seem to be able to Ctrl+F to find items in the drop down quickly.

New verion 0.9.0 supports up to 200 profiles.


a little modification, this is a start...

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

plz describe what you did in your pr


Add: Rede Mundo [BR]

Channel Name
Rede Mundo
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
Rede Mundo de Comunicação
Country
BR
Subdivision (optional)
No response
City (optional)
No response
Broadcast Area
c/BR
Languages
por
Categories (optional)
Entertainment
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://www.redemundotv.com.br/
Logo
https://www.redemundotv.com.br/assets/images/logo-rede-mundo-tv6.png
Notes
https://video01.logicahost.com.br/mundotvbrasil/mundotvbrasil/playlist.m3u8

Thank you for the stream: it will be included in the next release.


V pakoshti/update demo manifest

Executed build pipe line:
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/10249008592


Server and client RDMA write not happening

Pyverb  builded correctly, But the rdma write not happening , the completion queue has no any entries and before data and after data is sam in the server side print,. i just add few lines to the code to debug the issue but all the queried outputs are fine . Iam using mlx5_0 on both system and i can do rdma write using c code. can you please help me  to test the pyverbs functionality.

I have the same question

I solved this problem in IB scenario. The problem was that IB scenario was addressing with lid instead of GlobalRoute and gid as in RoCE. My modification method:
gid = ctx.query_gid(port_num=1, index=args['gid_index'])
lid = ctx.query_port(port_num=1).lid
# remote_info = conn.handshake(gid=gid, qpn=qp.qp_num)
remote_info = conn.handshake(gid=gid, lid=lid, qpn=qp.qp_num)

# gr = GlobalRoute(dgid=remote_info['gid'], sgid_index=args['gid_index'])
# ah_attr = AHAttr(gr=gr, is_global=1, port_num=1)
ah_attr = AHAttr(dlid=remote_info['lid'], is_global=0, port_num=1)

The problem is solved.

I also found a very practical debugging method, which is to enable ibdump -d mlx5_0 on both the client and server machines, so that you can check whether the packets are sent and received correctly.


🐞[Bug]: add hover effects to footer

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
add hover effects to links in footer section in service page
Expected behavior
underline text on hovering
Add ScreenShots
No response
What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Soujanya2004 I think a issue is open for this. Can you verify and tag me?

@varshith257 issue is not open for this, I have checked

please add level for the PR @varshith257


Add env option to shell provisioner

addressed in 0049afc3aa010870e41f001401acc6309b7e9772, to be released with 0.38.0


Ip dont update in UI

The IP one of my servers has changed, however in ui the displayed IP remains the older one.
It should not be automatically updated??

Duplicate of https://github.com/rancher/rancher/issues/388


full support for Canvas inside Web Worker?

Hi,
Is it possible, or feasible to create a Canvas, get its context and do some rendering all inside a web worker (then send the data back to the main thread via canvas.toDataURL(), or such like), using e2d?
(I'm using a js lib for morphing images which uses canvas (morpher-js), but it's a bit slow for smooth animation, so I'm using it to create a cache of between images which I'm then blending using another canvas, but the pre-comp is obviously still blocking the main thread. So I want to shift it all off to a web worker if possible.)
I saw in Canvas.js that the Renderer is set to null if inside a worker, so I'm guessing using canvas in this way is not currently possible, unless I'm missing something..

Hi.  The code that does the rendering is here:
Line 45 of Canvas.js:
if (isWorker) {
    postMessage({ type: 'canvas', value: { id: this.id, width: this.width, height: this.height, children: result } });
  } else {
    this.renderer.render(result);
    this.fillPattern = this.renderer.ctx.createPattern(this.renderer.canvas, 'no-repeat');
  }

Two things are happening.
The worker determines the draw logic, and the browser does the actual drawing.  The truth is it's hard to do image manipulation inside a web worker.  Until someone can actually code a canvas 2d context inside a web worker, we must rely on the main thread to do drawing.
To help you with your problem: You don't have access to the pixels exactly from the web worker.
If you think there is a use case for getting the drawn pixels and doing a manipulation inside a worker, I could probably help you with that.
Cheers,
-Josh

Thanks Josh.
I think I broadly understand how to transfer ctx.getImageData to workers using transferable objects (to  save copying), do the processing in worker, then send back to the main thread be put in the canvas and drawn again.
But I'm not too sure how to use e2d to make that job easier.

I forgot about transferables!  I use structured cloning, so I don't have an API that makes it simple.
Easy peasy, though!
browser side:
renderer.worker.postMessage({
  type: 'message-type', //choose something very unique here
  value: data
}, [data]);

worker side:
renderer.on('message-type', function(data) {

//call postMessage({ type: 'message-type-result', value: whatever });
});

Also, I suppose an API addition is in order:
r.getImageData(width, height, function(imageData) {
   //{ width: width, height: height, data: Uint8ClampedArray }
});
//or
r.getImageData(sx, sy, width, height, function(imageData) {

});

@joe312213 I think I would be happy to implement the following functions for you!
Also, I suppose an API addition is in order:
r.getImageData(width, height, function(imageData) {
   //{ width: width, height: height, data: Uint8ClampedArray }
});
//or
r.getImageData(sx, sy, width, height, function(imageData) {
  //this is the easy part
});

Probably followed up by the dream API:
r.render(
  e2d.putImageData(UintClampedArray), //dx and dy default to 0
  e2d.putImageData(data, dx, dy),
  e2d.putImageData(data, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeight)
);

The problem with using this method is that it slows down the process because of structured cloning.
I might have to implement a new class for this to prevent the slow down.
Proposed new API example
r.getImageData(params..., function(imageData) {
   //imageData.constructor === e2d.ImageData
   //imageData is referenced on the browser side and must be cached/disposed
   imageData.cache();
   var data = imageData.data;

   for(var i = 0; i < data.length; i += 4) {
      //do some manipulation the array
   }
   imageData.save();
   r.render(
     e2d.putImageData(imageData, ...params)
  );
  imageData.dispose();
})

@joe312213
I wanted to answer one final question, because I already gave you the ability to create offscreen canvases using the Canvas constructor.
var offscreenCanvas = e2d.Canvas.create(width, height).cache();

offscreenCanvas.render(
  //e2d commands
);

var img = offscreenCanvas.toImage(); //exports the canvas to a png and stores it in Img object

r.render(
   e2d.drawCanvas(offscreenCanvas)
);

Hi Josh,
Thank you for all the options. Very kind of you to take the time!
I've made a closer study of the morphing script and from what I can tell, due to its complexity there's no straightforward way (for me) of adapting it to put enough of its work into a worker to prevent noticeable main thread slowdown. So I think on this occasion I will do the processing offline and probably use a video element :)
I will keep a close eye on your rendering engine for future use though, thanks again!

It seems like I don't understand what your needs are. I probably should implement getImageData and putImageData though as a side project.

I assume I am unable to help with this issue.  I would be more than happy to reopen the issue and put in some work, but it seems unnecessary right now.
Cheers,
-Josh

Hey @joe312213, I have removed support for canvas inside a web worker and was curious what happened with your project?
Thanks,
-Josh

Hi Josh,
Thanks for your message, and interest in my project. I found even with
better operating multi-threading, the JS code I was using would still
likely introduce unacceptable delays in the UX. So I went a different route
and used some video sections for my animation instead.
Regards,
Joe
On 18 March 2016 at 17:47, jtenner<EMAIL_ADDRESS>wrote:

Hey @joe312213 https://github.com/joe312213, I have removed support for
canvas inside a web worker and was curious what happened with your project?
Thanks,
-Josh
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jtenner/e2d/issues/5#issuecomment-198468165

--
http://joe-hudson.blogspot.co.uk
http://littlecog.net http://pepol.net
http://pepol.net
http://www.tangolingua.com


Fix duplicated data points in a writing batch

Fix the bug in apache/skywalking-banyandb#508 that fails to deduplicate data in multiple series containing duplicate data points.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.07%. Comparing base (59c3968) to head (82da389).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #536       +/-   ##
===========================================
+ Coverage   39.79%   51.07%   +11.27%
===========================================
  Files         165      165
  Lines       20299    20296        -3
===========================================
+ Hits         8079    10366     +2287
+ Misses      11589     9137     -2452
- Partials      631      793      +162

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


All versions for 1.19.4 crash

Versions 0.6.5 and 0.6.4 crashes after pressing "E".
All the versions before 0.6.4, the game crashes before opening.
Here is the crash report for version 0.6.5:
latest.log

Thanks for report, it seems that it is CC:T incompitablity, I would try to fix it ...


[BUG] fix IT dockerfile arguments [skip ci]

Signed-off-by: Peixin Li<EMAIL_ADDRESS>simple fix for args out of scope

Going to merge this directly to unblock IT


Adds warning re performance of prune

I went pretty loud with this, but I think the performance is bad enough that it's really worth highlighting, especially since it locks the index during the prune.

What is the purpose of this change? What does it change?
Adds warning re prune performance
Was the change discussed in an issue or in the forum before?
Forum, here:  https://forum.restic.net/t/pruning-multiple-snapshots-simultaneously-fasters/837/2
Checklist

[x] I have read the Contribution Guidelines
[x] I have added tests for all changes in this PR
[x] I have added documentation for the changes (in the manual)
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Codecov Report

Merging #1915 into master will decrease coverage by 4.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
- Coverage   50.97%   46.54%   -4.44%
==========================================
  Files         169      169
  Lines       13087    13087
==========================================
- Hits         6671     6091     -580
- Misses       5414     6042     +628
+ Partials     1002      954      -48

Impacted Files
Coverage Δ

internal/backend/b2/b2.go
0% <0%> (-78.54%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-78.45%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-73.61%)
:arrow_down:

internal/backend/azure/azure.go
0% <0%> (-69.46%)
:arrow_down:

internal/backend/swift/config.go
36.95% <0%> (-54.35%)
:arrow_down:

internal/archiver/file_saver.go
85.96% <0%> (-2.64%)
:arrow_down:

internal/backend/s3/s3.go
59.39% <0%> (-0.76%)
:arrow_down:

internal/checker/checker.go
68.4% <0%> (+3.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3151978...5cc5592. Read the comment docs.

Can you please squash the two commits? Then I can merge it.

Not to be a pain, but git makes me crazy and I'm curious: Any reason you can't use Github's "Squash and Merge" button? I don't even have this repo init'ed on my laptop since I did this through the Github website.

Ah, sorry, I can just do it for you (I'm fluent in git, and yes, it can be a major pain). I'm not using the GitHub interface for merging PRs, instead I'm doing that on my local machine with the CLI commands, and I'm checking the code again after merging but before pushing it to GitHub. I always fear that somebody makes a change right before I press "Merge" on the UI, and then I merged some code I never saw. Not sure if that's a real issue, but it feels much better looking at the code again before pushing it, instead of using GitHub's web UI. I'm a bit peculiar, I know ;)
Thanks for your contribution!

It's done, thanks!

I always fear that somebody makes a change right before I press "Merge" on the UI

That's a good point. I should re-read the git manual again rather than muddle through forever. Thanks again for getting it done.

Let me say again that I very much appreciate such small PRs! Sure, it does cost you a little time, and sure, I just could have done it myself, but the sheer number of such small issues sum up to quite a lot of weeks of work. So I'm very grateful for everything people contribute. If it's a small change then it's very easy to review and accept :)


Add hint and displayName in parameters

What this PR does:
Add hint and displayName in parameters
Which issue(s) this PR fixes:
Fixes Jira C2-3587
Checklist

[x] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Corresponding changes in EGW: https://github.com/riptano/embedding-gateway/pull/69

Corresponding changes in the deployment: https://github.com/riptano/serverless-platform-charts/pull/1105


rename process to verdaccio

The process still named sinopia, that might be confuse.
Juans-MBP:verdaccio jpicado$ ps -ef |grep verdaccio
  501 19904 18047   0  8:34PM ttys001    0:00.00 grep verdaccio
Juans-MBP:verdaccio jpicado$ ps -ef |grep sinopia
  501 19906 18047   0  8:34PM ttys001    0:00.00 grep sinopia
  501 19875 19616   0  8:30PM ttys003    0:01.05 sinopia
Juans-MBP:verdaccio jpicado$

Thanks this is cool I didnt know you could do that

There are other stuff using the sinopia name, worth it to change it? @trentearl

@juanpicado i avoided it to prevent breakage, but I am 100% ok for renaming everything


CASMCMS-7993 Add procedure to customize iPXE binary names

Summary and Scope
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
Add procedure to customize iPXE binary names
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CASMCMS-7993

Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

/backport release/1.2

Eric, I'll try to help you out and make the backport PR for this

I'm going to try to see if I can fix this up for you, Eric, since the problem is just with the index file, and I believe you just wanted to add an entry to that.,

The master branch has been updated for spelling and style changes that now conflict with the changes I have made in this PR. I'm going to close this PR and try again with a fresh PR.


RO-1087 - [BE] remove coupon from Stripe after is_deleted is set to True

Coverage decreased (-0.3%) to 88.931% when pulling d67eeb7af32ddfe3aa7ece6acc2cc6627051e31a on feature/RO-1087 into 30211512a1a01dfd631bffa26d790f8538609ae1 on feature/RO-1085-coupon.

Coverage decreased (-0.3%) to 88.931% when pulling d67eeb7af32ddfe3aa7ece6acc2cc6627051e31a on feature/RO-1087 into 30211512a1a01dfd631bffa26d790f8538609ae1 on feature/RO-1085-coupon.

Coverage decreased (-0.3%) to 88.931% when pulling d67eeb7af32ddfe3aa7ece6acc2cc6627051e31a on feature/RO-1087 into 30211512a1a01dfd631bffa26d790f8538609ae1 on feature/RO-1085-coupon.

Coverage decreased (-0.2%) to 88.994% when pulling d316f990df57174f8db7290c3867a7eaeccfbdfe on feature/RO-1087 into 30211512a1a01dfd631bffa26d790f8538609ae1 on feature/RO-1085-coupon.

retest this please

test this please

Coverage decreased (-0.2%) to 88.994% when pulling 642f05eacb31b9233a0af00bb92d7924cd879782 on feature/RO-1087 into 30211512a1a01dfd631bffa26d790f8538609ae1 on feature/RO-1085-coupon.

Coverage increased (+0.2%) to 89.388% when pulling cf9d8ab08f70df26f2c4ea2880f02e03f69ff401 on feature/RO-1087 into 30211512a1a01dfd631bffa26d790f8538609ae1 on feature/RO-1085-coupon.


DocCount is reported incorrectly by NEST library for nested aggregations

Elasticsearch version:
7.6.0
NEST  version:
7.6.1
Elasticsearch.Net version:
7.5.1
Description of the problem including expected versus actual behavior:
The DocCount property of the KeyedBucket object overestimates the number of documents in the bucket likely including the count of all nested subdocuments. There seems to be no way in NEST to get the count of documents in the bucket without including nested documents
Steps to reproduce:

This behavior is observed when the IncludeInParent property is set to true for nested fields but may also occur if the property is set to false

Expected behavior
DocCount property in NEST should return the correct number of documents in the bucket similar to the doc_count property returned by the REST API
Provide ConnectionSettings (if relevant):
Provide DebugInformation (if relevant):

Hey @elkhiyarih Did you mean to close this?

Yes, this issue can be closed. It turned out that NEST was not using the default index and was searching all indices on the server which explains the higher than expected count. By specifying the index name in the query, the issue was resolved.
From: Martijn Laarman<EMAIL_ADDRESS>Sent: Tuesday, October 6, 2020 11:38 AM
To: elastic/elasticsearch-net<EMAIL_ADDRESS>Cc: elkhiyarih<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [elastic/elasticsearch-net] DocCount is reported incorrectly by NEST library for nested aggregations (#5047)
Hey @elkhiyarih https://github.com/elkhiyarih  Did you mean to close this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/elastic/elasticsearch-net/issues/5047#issuecomment-704357561 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTVE622TF4VQHW2LKQOANTSJM2T7ANCNFSM4SDYYR6A .  https://github.com/notifications/beacon/ADTVE64X2A7IIQNO3IMEL6TSJM2T7A5CNFSM4SDYYR6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFH52JOI.gif


edits to data_statistical_packages.rst

I think the lecture could have a more specific overview or a summary of what's covered in the lecture

maybe something like this for the overview-
This lecture explores some of the key packages for working with data and doing statistics in Julia

In particular, we will examine the ``DataFrame`` object in detail (i.e., construction, manipulation, querying, visualization, and nuances like missing data)

While Julia is not an ideal language for pure cookie-cutter statistical analysis, it has many useful packages to provide those tools as part of a more general solution

Examples include ``GLM.jl`` and ``FixedEffectModels.jl``, which we discuss

This list is not exhaustive, and others can be found in organizations such as `JuliaStats <https://github.com/JuliaStats>`_, `JuliaData <https://github.com/JuliaData/>`_, and  `QueryVerse <https://github.com/queryverse>`_

Great, merging now


BUG in algorithms/CSharp/readme.md

Bug detail
The bug is present in algorithms/CSharp/readme.md on line number 3.

Additional context
Finddle is a typo. It is supposed to be Fiddle.

Hi there, Can I take this issue?


Update install.rst

Backport #6610

Coverage remained the same at 78.189% when pulling b412969da8f1141907779a2ac1fa85ed209a991f on vThaian:backport/3.6.x/6610 into dc9ac2bdf7a27a0cf3fe5e18174044d56556dd33 on divio:release/3.6.x.


ignoring .aar files may cause to loose the files if libs are manually imported

Desc: Comment next line if you have manually imported libs with .aar files.
Reasons for making this change:
ignoring .aar files may cause to loose the files if libs are manually imported
Links to documentation supporting these rule changes:
https://developer.android.com/studio/projects/android-library
If this is a new template:

Link to application or project’s homepage: TODO

it' sounds so good,man


bugfix(LIVE-11047): swap llm issue when trying to swap from sol with delegated account

📝 Description
Show Spendable account balance in swap account selection in LLM

Before
After

❓ Context

JIRA or GitHub link: LIVE-11047

✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

[x] npx changeset was attached.
[ ] Covered by automatic tests.
[ ] Impact of the changes:

...

🧐 Checklist for the PR Reviewers

[ ] The code aligns with the requirements described in the linked JIRA or GitHub issue.
[ ] The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
[ ] There are no undocumented trade-offs, technical debt, or maintainability issues.
[ ] The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
[ ] Any new dependencies have been justified and documented.
[ ] Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

May you provide screenshots of the change?

Screenshot attached to PR


Update Sample File Upload and upgrade buttons to Shadcn button

Proposed Changes

Fixes #9153
Updated File Upload process to match with existing FileUpload
Updated regular Button and ButtonV2 to Shadcn button

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

Summary by CodeRabbit

New Features

Introduced a new file upload mechanism in the UpdateStatusDialog, enhancing user experience with improved error handling and progress indication.
Added a new label for report uploads in the localization files.
Introduced a new primary button variant for enhanced visual options.

Bug Fixes

Restructured file upload handling to ensure smoother functionality and user interaction.

check the code rabbit suggestion

Done

@nithish1018 The design looks inconsistent compared to our file upload component in the screenshot below. Please implement a similar design for consistency.

@nithish1018 The design looks inconsistent compared to our file upload component in the screenshot below. Please implement a similar design for consistency.

I made the requested changes, please review it

[ ] only keep the discard button on the bottom and remove the other button

[ ]  Only keep the discard button at the bottom and remove the other button next to the file name to maintain consistency with the existing file upload.

@nithish1018 make sure to do a basic QA before requesting a review

Actually the existing File Upload has that extra option to clear image , so I've added that here aswell.

Now I've updated the PR as per your suggestions, please review it

LGTM


Fix unset query tag in view materialization

resolves #456

Description

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

Thanks for finding this and submitting a fix @NiallRees !
Would you be willing to add a changelog entry by running the following?
changie new

Some things for the PR reviewer to assess:

Are the tests here working as expected? It looks like there is a view model included, and I would have expected this test suite to include a test to catch bugs like this.
Are the duplicated lines here intentional? If so, it seems like a comment should be added to clarify why running the same exact thing twice in a row is necessary.

Thanks for finding this and submitting a fix @NiallRees !
Would you be willing to add a changelog entry by running the following?
changie new

Done! Thanks!


Maven: openrewrite should support AddModule / RemoveModule

What problem are you trying to solve?
OpenRewrite has recipes that add and remove plugins / dependencies / etc.    Openrewrite should also be able to add or remove a <module/> to a pom's <modules/>
What precondition(s) should be checked before applying this recipe?
Describe the situation before applying the recipe
For AddModule - the situation before applying the recipe might be
<modules>
    <module>foo</module>
</modules>

Describe the situation after applying the recipe
For AddModule - the situation after applying the recipe to add a "bar" module would be
<modules>
    <module>foo</module>
    <module>bar</module>
</modules>

Have you considered any alternatives or workarounds?
Any additional context
Are you interested in contributing this recipe to OpenRewrite?

hi @cunningt ! What kind of recipes are you looking to compose using any Add/RemoveModule recipes?
By themselves any such Add/RemoveModule recipes are unlikely to produce anything that meaningfully works; those modules would need to be matched up with recipes to add/remove the associated pom files, as well as potentially other associated sources. The targeting for any such recipes would also have to be very specific, as you'd likely only want to add this to a root pom.xml, not any nested sub pom.xmls.
Taking the above into account, those constraints then quickly morph into an imperative recipe that as a small part changes a pom.xml, in likely restricted cases, as opposed to something that can easily be composed in a declarative recipe and be of reusable value.
Any details you can provide about your intended use would be helpful to shape any recipes to build, or perhaps nudge towards an imperative recipe for the specific use case you're after.

Use case : applying frequent changes and enhancements downstream to a pom.xml file where the pom.xml file is quite volatile upstream.      Managing the changes through a .patch file doesn't work well because of frequent and inevitable merge conflicts.
rewrite provides 90% of what I'd need here.    It can add properties, dependencies, plugins, and dependencyManagement entries without having to worry about merge conflicts.    I know use as a patching tool isn't really the intended purpose of rewrite, but it can do it pretty well.
Add/Remove modules would really be helpful in this -  and I agree that by itself it wouldn't completely solve the issue, I still would need to copy the module directory - but I'd love it if rewrite could handle more of the pom.xml changes I'm trying to make and the ability to add/remove modules would help.

Thanks for that added context! In this case I'd perhaps then still lean towards at least starting out those recipes outside openrewrite/rewrite, as any such recipes by themselves are not yet something anyone can run in isolation and expect to work well. The potential then to have to field support questions on a recipe that requires knowledge of what it can and can't do is not ideal. Do you already have a place for any such custom recipes? I know colleagues of yours for instance maintain apache/camel-upgrade-recipes separately.


Wrong UI language detected on Windows

Describe the bug
I am trying to use lazydocker on Windows with English Language and German Region.
What I am seeing is a UI that is half German/half English.
To Reproduce

Set Windows Language to English and Region to German
Launch lazydocker.
See a Language mix.

Expected behaviour
Everything is in English.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Lazydocker VersionVersion: 0.20.0
Date: 2022-11-12T04:29:12Z
BuildSource: binaryRelease
Commit: 530dbbe57009f4596bfeedba1c8169becd98b9a8
OS: windows
Arch: amd64

Additional context
Looking through the source code I can see that cloudfoundry's jibber_jabber library from 2015 is used to detect the user language. That library is abandoned. Maybe there exists a better library to determine the UI language?
If there is no better way to detect the effective UI language, maybe an environment variable can be set to force a certain language in the app?
Btw. all other language sensitive apps I am using correctly display in English.

I don't think it's the wrong language detected, but that not everything is translated, and the things that aren't fallback to English.

If there is no better way to detect the effective UI language, maybe an environment variable can be set to force a certain language in the app?

You could try setting it explicitly to english through the config:
gui:
  language: 'en' # one of 'auto' | 'en' | 'pl' | 'nl' | 'de' | 'tr'


⚠ SkyfallMC Minecraft Server has degraded performance

In f8d5717, SkyfallMC Minecraft Server (play.skyfallmc.ga) experienced degraded performance:

HTTP code: 200
Response time: 1198 ms

Resolved: SkyfallMC Minecraft Server performance has improved in 0fd8d27.


istio blocking ports

Describe the bug
{{ Succinctly describe the bug }}
using ISTIO-proxy the system port is not working.
Expected behavior
{{ What did you expect to happen? }}
remove ISTIO-Proxy the system port is working
Steps to reproduce the bug
{{ Minimal steps to reproduce the behavior }}
GKE Kubernetes with simple SAP HANA database
Version
istio 1.0
{{ What version of Istio and Kubernetes are you using? Use istioctl version and kubectl version }}
Installation
{{ Please describe how Istio was installed }}
we follow GKE link https://cloud.google.com/kubernetes-engine/docs/tutorials/installing-istio
Environment
{{ Which environment, cloud vendor, OS, etc are you using? }}
SUSE Linux
Cluster state
{{ If you're running on Kubernetes, consider following the
instructions
to generate "istio-dump.tar.gz", then attach it here by dragging and dropping
the file onto this issue. }}

Do not get what you are asking?

basically our Container (which is SAP HANA database) has the same hostname and IP address with ISTIO-proxy container ? and this cause our HANA database connectivity issues. IF we run without ISTIO Proxy this works and with ISTIO-PROXY this breaks connectivity on the container ? does it make understand now ?

The application container and the istio-proxy container MUST have the same address.
For Istio to work properly the app container (your HANA database) must accept localhost connections.  I am not familiar with your database but I have used other database middleware with Istio.
kubectl exec -it <pod> bash to get into your container.  Once in, test it in the usual way for the service it offers, for example:

curl localhost:5984/_all_dbs (for CouchDB)
mysql -p -h localhost -P 3306 (for MySQL).

localhost connections should not be affected by Istio.  If you have a problem here, fix it here.
Because svcB and its sidecar share a single network so talking to localhost should be the same
on the sidecar as within svcB.
If your application cannot talk on localhost because it explicitly binds listening sockets
to an IP address it will not work under Istio.
Run netstat -tulpn and make sure the Local Address is <IP_ADDRESS> or <IP_ADDRESS> for all listeners.  Applications that explicitly listen on their external address (e.g. <IP_ADDRESS>) will not work under Istio.  This is because the Envoy proxy traffic does not come from off-pod
and will appear to your application as if it arrived via localhost.


[WIP] Add HttpClient extensions

This PR explores the possibility to provide all OAuth/OIDC client libs as extension methods for HttpClient. This allows for external HttpClient lifetime management (e.g. via the HttpClientFactory) and better composability.

👍 I feel this is a better approach.


Theme -> Add item -> Type Icons does not work because p_icon.is_null()

hi,
custom build of few days ago, win64.
i'm trying to add custom icons to my theme. But when I Theme -> Add item -> Type Icons, the console says :
ERROR: Theme::set_icon: Condition ' p_icon.is_null() ' is true.
At : scene\resources\theme.cpp:212
and no icon is added into the Inspector, not even after I Theme -> Add Class Items -> Type Icons to try to refresh the Icons list.

Can you still reproduce this issue in the current master branch / nightly builds?

Ping :)

Yes, issue still present into 2.0.2.stable official release.

Tested in 2.1-beta / the current master branch and I don't see this error message anymore. I have no clue how to use the theme editor though so I can't confirm if the bug is fixed :)

Assuming this got fixed with the 2.1 changes to the theme editor.

Not able to replicate this, myself.


Creating new datastore on startup of HDS

I use sudo docker run -p 8085:8085 linksmart/hds to start my HDS service. But every time that HDS starts and I call /registry API, a new datastore gets created. How can I reuse the ones that already are created?

I forgot to mention that I use it on Raspbian OS on a Raspberry pi. I installed my HDS by running docker build -t linksmart/hds  in the directory of downloaded image.

Hi Amin,
docker run creates and starts a new container. Since the data within the container is not mounted, you are creating a new database every time you run it, without removing the old containers.
You need to mount the /data volume to host in order to add persistency. E.g. to mount on ./mydata relative to execution path:
docker run -p 8085:8085 -v $(pwd)/mydata:/data --name hds linksmart/hds

You may add -d argument to run it in detached mode.
Then, you can stop|start|restart it this way:
docker stop|start|restart hds

Get the logs and follow:
docker logs hds -f

These are the basics but you need to read more about docker if you want to run HDS in long term.

@dschowta please document how to persist the HDS data.


Adding anchor-spl causes anchor build to fail

With a fresh anchor init, then running anchor build, everything builds fine. Then immediately after I added anchor-spl = "0.26.0" to the programs Cargo.toml. Run anchor build again, and I get the below error:
❯ anchor build
BPF SDK: /Users/mdustries/.local/share/solana/install/releases/stable-46fde27b3dd95a4d06020150ab3e1c0e93746db7/solana-release/bin/sdk/bpf
cargo-build-bpf child: rustup toolchain list -v
cargo-build-bpf child: cargo +bpf build --target bpfel-unknown-unknown --release
    Updating crates.io index
error: failed to select a version for the requirement `toml_edit = "^0.18"`
candidate versions found which didn't match: 0.14.4, 0.14.3, 0.14.2, ...
location searched: crates.io index
required by package `proc-macro-crate v1.3.0`
    ... which satisfies dependency `proc-macro-crate = "^1"` (locked to 1.3.0) of package `num_enum_derive v0.5.9`
    ... which satisfies dependency `num_enum_derive = "^0.5.9"` (locked to 0.5.9) of package `num_enum v0.5.9`
    ... which satisfies dependency `num_enum = "^0.5.4"` (locked to 0.5.9) of package `spl-token v3.5.0`
    ... which satisfies dependency `spl-token = "^3.5.0"` (locked to 3.5.0) of package `anchor-spl v0.26.0`
    ... which satisfies dependency `anchor-spl = "^0.26.0"` (locked to 0.26.0) of package `test-deps v0.1.0 (/Users/mdustries/Workspace/mdustries-corp/test/test-deps/programs/test-deps)`

Here are my versions:
❯ rustup --version
rustup 1.25.1 (bb60b1e89 2022-07-12)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.67.0 (fc594f156 2023-01-24)`
❯ rustc --version
rustc 1.67.0 (fc594f156 2023-01-24)
❯ solana --version
solana-cli 1.13.7 (src:46fde27b; feat:1322523751)
❯ anchor --version
anchor-cli 0.26.0

Here is an example repo with the issue.
I have been stuck on this issue for DAYS. Thanks for any help in advance.

Tried this locally and couldn't replicate. Currently chatting about this on discord with @mdustries

Solution is to upgrade from 1.13 to the 1.14 versions of the CLI.


replace one accounts iter with scan_pubkeys

Problem
moving to not mmapping append vecs. We need to remove calls to accounts_iter
Summary of Changes
Replace one with scan_pubkeys
Fixes #

i am measuring that now.

i am measuring that now.

I thought this was a different pr. There will be no perf impact from this.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (c7a5199) to head (b1b27ce).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage    81.8%    81.8%
=======================================
  Files         853      853
  Lines      231791   231851   +60
=======================================
+ Hits       189784   189846   +62
+ Misses      42007    42005    -2


[backend]Ensure coalescing for every memop in a slice by using minimum vector width.

This is changing the current memory coalescing heuristics which uses the narrowest data type for the layouts of all memops in a slice. This patch is changing it to use the widest data type instead.
We have seen an issue with the current heuristics (https://github.com/pytorch/pytorch/issues/120667) where a full vectorization of a narrower memop breaks memory coalescing of a wider memop. This occurs in a way that the wider memop will end up fulfilled by two consecutive memop ops, and each is not consecutive across threads. It seems that in general full memory coalescing should always be ensured (within or across threads). And on top of that, maximizing vectorization for each memop is a plus.
No significant perf movement seen with the inductor nightly perf testing.

cc @shunting314

Looks like a test is failing?

Looks like a test is failing?

Yes, I'm trying to repro it locally. Looks like an assert failure about the number of add instructions.
BTW, do you know which version of Pytorch is used in the lab?

BTW, do you know which version of Pytorch is used in the lab?

I don't know offhand, but it should all be (effectively) specified by the pip install and similar commands inside the .github folder.  There's no "magic" or pre-installed stuff afaik.

This is changing the current memory coalescing heuristics which uses the narrowest data type for the layouts of all memops in a slice. This patch is changing it to use the widest data type instead.

If so, shouldn't we consider the number of bytes instead of the number of elements?

This is changing the current memory coalescing heuristics which uses the narrowest data type for the layouts of all memops in a slice. This patch is changing it to use the widest data type instead.

If so, shouldn't we consider the number of bytes instead of the number of elements?

I think that's what it does. Number of bytes for the data type is used to compute the number of elements that each thread should own consecutively (getNumElementsPerThread).

This is changing the current memory coalescing heuristics which uses the narrowest data type for the layouts of all memops in a slice. This patch is changing it to use the widest data type instead.

If so, shouldn't we consider the number of bytes instead of the number of elements?

I think that's what it does. Number of bytes for the data type is used to compute the number of elements that each thread should own consecutively (getNumElementsPerThread).

Oh, I see it. getNumElementsPerThread actually refers to getNumBytesPerThread.

We'll have to to try this heuristic on our internal workloads. I wonder if for some sub-byte types this is going to be a problem, also I wonder if some cases where the we have 16bytes load in a loop and 32 bytes store outside this is going to be suboptimal. Were you able to try out such scenarios?

That's a good point. I haven't specifically checked for those cases. Also the number of memops in different dtypes may also matter.

@ThomasRaoux  It looks like the test failure is due to an unhandled case in wgmma to LLVM lowering, where the accumulator was zero. The zero accumulator was introduced by a layout optimization triggered by this patch:
dot(a, b, load(ptr)) -> add(load(ptr), dot(a, b, 0))
This optimization seems good. I tried to fix the compiler error but then I hit the assert in the test which I need some help to understand:
https://github.com/openai/triton/blob/38cc733efd1262dc6c81a1862247c09e9d982350/python/test/unit/language/test_core.py#L3090
BTW, have you got a chance to try this heuristric with your workloads?

I'll try to run this tomorrow

@ThomasRaoux It looks like the test failure is due to an unhandled case in wgmma to LLVM lowering, where the accumulator was zero. The zero accumulator was introduced by a layout optimization triggered by this patch:
dot(a, b, load(ptr)) -> add(load(ptr), dot(a, b, 0))

I'm surprised we don't support zero accumulator, I'm pretty sure we have cases like that already. Where is the problem?

Basically I hit an AV when d is null because zeroAcc==true:
https://github.com/openai/triton/blob/38cc733efd1262dc6c81a1862247c09e9d982350/third_party/nvidia/lib/TritonNVIDIAGPUToLLVM/DotOpToLLVM/WGMMA.cpp#L451

This optimization seems good. I tried to fix the compiler error but then I hit the assert in the test which I need some help to understand:
https://github.com/openai/triton/blob/38cc733efd1262dc6c81a1862247c09e9d982350/python/test/unit/language/test_core.py#L3090

This is checking that we do the accumulation outside of the tensorcores. Not sure what would cause this.

With my workaround, I was seeing h.asm["ptx"].count("add.f32") == 128 while the other values was 256.

I'll try to run this tomorrow

Thanks!

@ThomasRaoux It looks like the test failure is due to an unhandled case in wgmma to LLVM lowering, where the accumulator was zero. The zero accumulator was introduced by a layout optimization triggered by this patch:
dot(a, b, load(ptr)) -> add(load(ptr), dot(a, b, 0))

I'm surprised we don't support zero accumulator, I'm pretty sure we have cases like that already. Where is the problem?

Basically I hit an AV when d is null because zeroAcc==true:
https://github.com/openai/triton/blob/38cc733efd1262dc6c81a1862247c09e9d982350/third_party/nvidia/lib/TritonNVIDIAGPUToLLVM/DotOpToLLVM/WGMMA.cpp#L451

This optimization seems good. I tried to fix the compiler error but then I hit the assert in the test which I need some help to understand:
https://github.com/openai/triton/blob/38cc733efd1262dc6c81a1862247c09e9d982350/python/test/unit/language/test_core.py#L3090

This is checking that we do the accumulation outside of the tensorcores. Not sure what would cause this.

With my workaround, I was seeing h.asm["ptx"].count("add.f32") == 128 while the other values was 256.

This should be fixed in the latest version.

So one example should be easy to reproduce, for sub-bytes type (for example f16), if there are multiple loads/stores and one of them cannot be vectorized then all of them are not vectorized. And reading less than 4 bytes per thread would tank the perf. You should be able to reproduce that with a simple kernel.
I assume the heuristic will have to consider sub-bytes types

Thanks a lot for measuring perf for this change. At this point it appears that the heuristics needs more tweaks.

So one example should be easy to reproduce, for sub-bytes type (for example f16), if there are multiple loads/stores and one of them cannot be vectorized then all of them are not vectorized. And reading less than 4 bytes per thread would tank the perf.

What is the rationale behind this? Is that because less-than-4-byte load per thread would result in a waste of a 128-byte memory transaction per warp?

What is the rationale behind this? Is that because less-than-4-byte load per thread would result in a waste of a 128-byte memory transaction per warp?

yes that's one way to see it. In general threads accessing unaligned addresses (not aligned on 4B) or accessing less than 4B of data per thread won't be able to saturate the bandwidth.

What is the rationale behind this? Is that because less-than-4-byte load per thread would result in a waste of a 128-byte memory transaction per warp?

yes that's one way to see it. In general threads accessing unaligned addresses (not aligned on 4B) or accessing less than 4B of data per thread won't be able to saturate the bandwidth.

Just send out a new iteration. I'm experimenting a new heuristics based on equivalent class. I'm making sure two things:

  Ensure cross-thread coalescing for every memop.

  Ensure bandwidth saturation and correct alignment for every memop.

I'd like to get your thoughts on it. The code isn't polished much though.

I scan quickly through the code, could you add a high level comment explaining the heuristic as I'm not sure I fully understand from the code.

Ensure cross-thread coalescing for every memop.

what does that mean when there is a chain of memop? Do we just want to pay for convert everytime?

I scan quickly through the code, could you add a high level comment explaining the heuristic as I'm not sure I fully understand from the code.

Thanks for taking a lot and sorry about missing a high-level description. I'll add it.

what does that mean when there is a chain of memop? Do we just want to pay for convert everytime?

We try to compute a unified perThread without losing cross-thread coalescing for every memop. The vectorization of memop may not be guaranteed though.

Summary updated to reflect the new heuristic.

closing this PR due to no activity. Feel free to reopen.

@htyu @ThomasRaoux is the optimization still on the menu. I am just learning how to auto coalesce global access to (to make sure data load store continuously). Is there an overview of the Coalesce transform cpp ? Could we illustrate the algorithm with the classic example tranposeOp ?

@htyu @ThomasRaoux is the optimization still on the menu? I am just learning how to auto coalesce global access to SMEM (to make sure data load store continuously).

The specific optimization implemented by this PR doesn't seem to work well across the board, i.e, perf regression seen in some cases, so it's put on hold for now.

Is there an overview of the Coalesce transform cpp ? Could we illustrate the algorithm with the the classic example tranposeOp ?

I'm not sure about an overview anywhere, but if you have specific case you like to study, feel free to share. The transposeOP is a good example to start with.


Clean up TSC repo references to simplify adding projects

I will take this on, and do a series of editorial PRs to accomplish this.

Done!


Maximum topic lengths in model definition and validation differ

Gitea version (or commit ref): 1.13.0+rc1
Git version: 2.26.2
Operating system: Docker on Ubuntu 18.04
Database:

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No

Description
The ValidateTopic method in models/topic.go as well as the UI specify a maximum length of 35 characters for topics:
https://github.com/go-gitea/gitea/blob/c5020cff3df0a7d77ff7a453a2007edc7e5c3667/models/topic.go#L58-L60 https://github.com/go-gitea/gitea/blob/c5020cff3df0a7d77ff7a453a2007edc7e5c3667/options/locale/locale_en-US.ini#L1855
The Topic model's Name column however is specified to have a maximum of 25 characters:
https://github.com/go-gitea/gitea/blob/c5020cff3df0a7d77ff7a453a2007edc7e5c3667/models/topic.go#L29

Because of this, assigning a topic with 26-35 characters to a repository fails with this error:
...outers/repo/topic.go:50:TopicsPost() [E] SaveTopics failed: Error 1406: Data too long for column 'name' at row 1

Trying to migrate a repository from GitHub with topics that are within GitHub's limit of 35 characters but longer than 25 characters (e.g. https://github.com/vtil-project/VTIL-Core) fails with a similar error:
...ules/task/migrate.go:64:func1() [E] DeleteRepository: repository does not exist [id: 40, uid: 1, owner_name: , name: ]
modules/task/task.go:51:handle() [E] Run task failed: Error 1406: Data too long for column 'name' at row 1

I assume that it isn't reproducible on try.gitea.io because it uses SQLite, which would treat VARCHAR like TEXT and therefore would not enforce the specified maximum length.

We should alter the column to 35

duplicated with #14108


Preserve data

school library: preserve data:

On exit from the app save all the data (books, people, and rentals) into JSON files. One type of data is stored and named accordingly.
On startup of the app load all data from files.

Hello @EricMbouwe 👋🏼 ,
Thank you for taking out time to review and approve this PR. You are awesome 💯


[FEATURE] Rename command / CSCLSROZ-360

could be done quite easily as part of pre-deployment step. the upsert method doesn't look at the key inside of the metadata anymore but only at the key in list of metadata that identifies each metadata object to add object id and do other stuff. therefore, we could have a rename command hook into the deploy routine with some sort of twist here.


use imageloader load picture appear black border

@hdodenhof
my case is : enter Activity use imageloader to load testUrl_1 for CircleImageView , then use imageloader to load testUrl_2 for CircleImageView over and over again , then the CircleImageView appears black border.
my code is :
public static void displayImageAndInvalidate(String uri, ImageView imageView) {
        ImageAware imageAware = new ImageViewAware(imageView, false);
        ImageLoader.getInstance().displayImage(uri, imageAware,
                getCustomOptions());
// use invalidate , does't work
        imageView.invalidate();
    }

if Activity through onPause , then enter Activity , black border disappear,but if i operate change url ,it also .appear black border.
I don't why it happened , sorry for my bad english and please help me!!!

I'm sorry, but I don't quite understand the events leading to your issue. Could you provide screenshots or a screencast?

@hdodenhof
if i change the url many times ,the problem can appear,and the screenshots is below

the normal is below

and i find the solution , my code is :
public static void displayImageAndInvalidate(String uri,
			final ImageView imageView) {
		ImageAware imageAware = new ImageViewAware(imageView, false);
		ImageLoader.getInstance().displayImage(uri, imageAware,
				getCustomOptions(), new SimpleImageLoadingListener() {
					@Override
					public void onLoadingComplete(String imageUri, View view,
							Bitmap loadedImage) {
						// add this for the reason
						imageView.setImageBitmap(null);
						imageView.setImageBitmap(loadedImage);
					}
				});
	}

before setImageBitmap(loadedImage) add setImageBitmap(null)
but i did't know why it happened.

I can see this issue when i use Picasso or Glide.
And I set image Url in this image vi

ew.
And this is my code part.
Picasso.with(this).load(imageurl).centerInside().placeholder(R.drawable.photo).noFade().fit().into(profileimage);
Sorry for my bad english.
Please give me solution of this issue

I found the reason of this issue in my case.
This issue was be occurred when i added click event on this image view.
And also i found solution from following link.
https://github.com/hdodenhof/CircleImageView/issues/153
if you check this solution carefully, you will solve your issue.
I hope this will be help you.
Thank you.

Closing this as the original issue is most likely resolved by now (sorry for not getting back at all) and I can't reproduce it. Please reopen, if this still is an issue.


Feature Request: Ability to configure implicit provider types/scalars for a project (to support AWS AppSync's scalers)

Hi,
First of all, thanks for the great plugin.
I'm developing an AppSync project, and AWS provide a bunch of scalars such as AWSJSON, AWSTimestamp, etc.
https://docs.aws.amazon.com/appsync/latest/devguide/scalars.html
These appear as errors when I'm editing my graphql schema, unless I define them in my schema — e.g.:
scalar AWSTimestamp

This fixes the error, but I need to comment that out before pushing the schema to AppSync.
So, my feature request would be a plugin configuration option to define some provider types/scalars that are implicitly included in the IDE but are not part of the schema.
This would help developers working with AWS AppSync.
Thanks again, great plugin!

@sc0ttdav3y hi, thank you for the report! We're thinking about a convenient generic mechanism to provide some sort of "type definitions" for different frameworks in the future releases. Now we are focused on fixing issues and some architectural improvements to begin active feature development.

@sc0ttdav3y also, I would like to know how Amplify chooses which schema files to send? If it sends a specific single file, you could create a separate .graphql file somewhere in a project with all the required definitions, they should be picked up by the plugin without any additional efforts.

Hi there!
I'm having a similar issue. In my case, I'm using the serverless framework + serverless-appsync-plugin. Luckily in the configuration, we can explicitly specify one file to use as a schema.
So until the issue is fixed on the plugin level here's what I do.
I simply create another file called scalars.graphql and put the following content in there:
scalar AWSTimestamp
scalar AWSURL
scalar AWSDate
scalar AWSDateTime

With this setup, the plugin recognizes the missing types but serverless-appsync-plugin ignores it during the deployment (which is what you need).
I hope this helps someone.
Cheers!

I've combined all the feedback from the contributions here and in linked posts to create a gist that you can place outside your schema folder to give you AWS AppSync scalars and directives.
This has worked for me in both Amplify and Serverless Framework + serverless-appsync-plugin environments.
https://gist.github.com/sc0ttdav3y/76e370ecf7047c036b19d57b419fb126
Thanks everyone for their contributions to this.


no more TFA for OVH

Following up on #870.
It really looks like OVH doesn't offer TFA anymore. The section on their website that used to advertise TFA has been wiped out some time ago.
I think the time has come to revert their state to tfa: No.

Have you actually contacted them and asked about this?

I just sent them a question asking if they still support TFA and in what countries.
I'm marking this PR as pending until they reply.

See #870, I've got no news since then.

Okay here's my response:
Hello,

Thank you for reaching OVH support team, regarding your 2FA question. My name is Rachid, I will be answering you today.

Unfortunately we do not suport 2FA, and I am not being aware that we are planning to in a near future, otherwise it would be advertised on our web page.

On the OVH North America we did not have the double authentication method it was only on Europe,.

I hope this answers your questions. Don't hesitate if you have further questions.

Thank you for contacting OVH. Have a great day!

Rachid Y.
Customer Advocate

So I guess you're good to go. Please wait while another collaborator confirms everything is okay.

@qrawl perhaps their twitter for public shaming.

@mxxcon
et voilà

Says the Italian ^_^

Change the Twitter handle to ovh_support_en

@Carlgo11 Looks like regular ovh account has more tweets and followers than the support account, so it could be higher profile. However, support account does reply to people.
Can we list 2 accounts so that when you press that button it generates message with both?

@mxxcon we usually send to the twitter account that replies. Otherwise they probably don't see the tweets.


Fine tuning dataset size

Hi! I want to try and fine tune the model for ID OCR. The distribution is fairly homogenous (what varies the most is sharpness and brightness of the images).

How many real annotated images would be a good number to start?
Would it be beneficial to train on each section of the ID independently or train on all sections at the same time?

Thank you very much.

Unless you need to support new characters, I would suggest using the model as-is first in order to have a baseline. Honestly, nobody knows how many annotated images you'd need in order to finetune. Just try it with your current dataset and adjust the learning rate accordingly.
Note that STR typically deals with single lines of cropped text. If you're using STR as the last stage in your pipeline, it's better to train on all sections at the same time (as long as you're feeding the cropped images independently).


Game Crashes

latest.log
Game crashes with the latest 1.20.1 version

Currently the latest version of this mod is for 1.20.1, which is incompatible with 1.20.4

i tried on 1.20.1 still didnt work

latest.log Game crashes with the latest 1.20.1 version

In the previous log I see the fabric api version is 0.96.4+1.20.4
If you have already replaced it with a version for 1.20.1, please provide the latest log

Currently the latest version of this mod is for 1.20.1, which is incompatible with 1.20.4

Any plans to support 1.20.4 ?

latest.log Game crashes with the latest 1.20.1 version

It looks like you didn't install dependencies:
 - Mod 'Leawind's Third Person' (leawind_third_person) 2.0.8-beta.3 recommends version 11.1.118 or later of cloth-config2, which is missing!
	 - You should install version 11.1.118 or later of cloth-config2 for the optimal experience.
 - Mod 'Leawind's Third Person' (leawind_third_person) 2.0.8-beta.3 recommends version 7.2.2 or later of modmenu, which is missing!
	 - You should install version 7.2.2 or later of modmenu for the optimal experience.
 - Mod 'Leawind's Third Person' (leawind_third_person) 2.0.8-beta.3 recommends version 3.2.2 or later of yet_another_config_lib_v3, which is missing!
	 - You should install version 3.2.2 or later of yet_another_config_lib_v3 for the optimal experience.

could you try the newest version 2.0.9-beta.1 and see see if it crash again ?


ENH: Setup prep

Added basic features to allow pysatModelUtils to function independently with pysat as a requirement.  Features include:

setup file
travis config (not currently functional)
Documentation for contributing to the code

@rstoneback, I don't think I have permission to set up Travis CI for this account.

unit tests are passing locally using pytest -vs.

Install using python setup.py install

Thanks Jeff. I’ll try to get to this today after class and in between meetings.

Travis is back!  It is currently not running the code because the pysat dependency fails when installing pysatMagVect.

Running into all errors within Travis CI environment.  Tests run fine locally.  Keep getting this on Travis:
ModuleNotFoundError: No module named 'pysat.instruments.pysat_testing'

We still have a few more months on 2.7...
Incidentally, it is still listed as supported in setup.py

Yeah, this is in flux.  Been turning things on and off to try to fix.

OK, no worries then.
I also don't see pysat.instruments.pysat_testing
on my local install of branch calc_freq_fix

Friendly fyi that pysat_testing isn't listed in instruments.init, so I wouldn't see it by default in the loaded methods.

Current working theory is that this is related to the pysat install.  Using pip install python simply grabs an old version that is not compatible with travis.  Doing a manual install from the develop branch leads to a billion dependency issues.  Trying again with a simplified version that removes sgp4 and its extra dependencies.

The pysat Travis file used conda to create the python environment. Or at least it used to. You’ve been busy. May be worth using again. I remember I had to grab a template Travis file from the internet to get things going initially with pysat.

Back to green!

OK, so we've hit a catch-22.  We need the core pysat in order to run unit tests on codes that have pysat as a dependency.  This is because the dependencies are complex enough that something is likely to go wrong, resulting in the test files being unable to load a test instrument.
Since we can't (or at least shouldn't) remove these functions from pysat yet, I've created a separate branch where pysat_sgp4 and its dependencies have been removed.  This takes pyglow, apexpy, etc, out of the equation.  It's a temporary solution, but it will help get everything sorted out.

OK, this one is done.  pytest and coverage are both working, as are Travis CI and Coveralls.  Let me know if you have comments!