meshcat-server command not working

Whenever I run meshcat-server, the page that opens up says error 404 not found and this is what is displayed in my command window:
zmq_url=tcp://<IP_ADDRESS>:6000
web_url=http://<IP_ADDRESS>:7000/static/
Firefox hook launcher starting up
run-parts: executing /usr/lib/amazon/firefox-hooks/00amazon-firefox-certs
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
Notice: Trust flag u is set automatically if the private key is present.
run-parts: executing /usr/lib/amazon/firefox-hooks/10firefox-disable-bad-prefs
Firefox hook launcher finished
WARNING:tornado.access:404 GET /static/ (<IP_ADDRESS>) 1.37ms
WARNING:tornado.access:404 GET /favicon.ico (<IP_ADDRESS>) 0.33ms
(/usr/lib/firefox/firefox:3427): Gtk-WARNING **: Theme parsing error: gtk-main.css:18:33: Invalid number for color value
^CTraceback (most recent call last):
File "/usr/local/bin/meshcat-server", line 11, in
load_entry_point('meshcat==0.0.13', 'console_scripts', 'meshcat-server')()
File "/home/me/meshcat/servers/zmqserver.py", line 177, in main
bridge.run()
File "/home/me/meshcat/servers/zmqserver.py", line 159, in run
self.ioloop.start()
File "/usr/local/lib/python2.7/dist-packages/tornado-5.1.1-py2.7-linux-x86_64.egg/tornado/ioloop.py", line 1048, in start
event_pairs = self._impl.poll(poll_timeout)
any ideas on this?

I fixed the issue by running python meshcat-server instead of just meshcat server

The only thing I can think of is that perhaps Firefox is being opened before the server is actually ready. Does refreshing the page have any effect?

I'm facing a similar issue. Here is the output I get from running meshcat-server:
zmq_url=tcp://<IP_ADDRESS>:6000
web_url=http://<IP_ADDRESS>:7000/static/
WARNING:tornado.access:404 GET /static/ (<IP_ADDRESS>) 1.80ms

The last line shows up when I open the URL (http://<IP_ADDRESS>:7000/static/). Do you have any thoughts on what may be causing this tornado issue and the 404 error? I get the same issue when I run the demo notebooks.

I'm facing a similar issue. Here is the output I get from running meshcat-server:
zmq_url=tcp://<IP_ADDRESS>:6000
web_url=http://<IP_ADDRESS>:7000/static/
WARNING:tornado.access:404 GET /static/ (<IP_ADDRESS>) 1.80ms

The last line shows up when I open the URL (http://<IP_ADDRESS>:7000/static/). Do you have any thoughts on what may be causing this tornado issue and the 404 error? I get the same issue when I run the demo notebooks.

I have the same problem as you. Have you solved it ？

I'm facing a similar issue. Here is the output I get from running meshcat-server:
zmq_url=tcp://<IP_ADDRESS>:6000
web_url=http://<IP_ADDRESS>:7000/static/
WARNING:tornado.access:404 GET /static/ (<IP_ADDRESS>) 1.80ms

The last line shows up when I open the URL (http://<IP_ADDRESS>:7000/static/). Do you have any thoughts on what may be causing this tornado issue and the 404 error? I get the same issue when I run the demo notebooks.

I have the same problem as you. Have you solved it ？

I ran into the same problem when working on submitting a patch for meshcat-python: so I had cloned the meshcat-python repo and run pip install . inside.
The issue was that I had forgotten to checkout the submodules ! git submodule update --init --recursive solved the problem for me

I am facing such an error
RuntimeError: the meshcat server process exited prematurely with exit code 1
what should i do?

Looks like you can start it with python -m meshcat.servers.zmqserver.


Renaming follow-up changes

A very important and life-changing submission
Before submitting (must do checklist)

[x] Did you read the contribution guide?
[ ] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Proposed Changes

Fixed the naming and link to the company after renaming from tinkoff to t-bank

Closing issues

Hi! What do you think about updating the license?
https://github.com/etna-team/etna/blob/master/LICENSE#L178

tbh me too, this is a question for the IP lawyer. But my guess would be that yes, it should also be updated

I have in mind some other places to update:

pyproject.toml

Description field
Emails for the initial developers

docs/source/conf.py

copyright
author

docs/source/index.rst

Fixed

I also found some other places to update:

pyproject.toml

Description field
Emails for the initial developers

docs/source/conf.py

copyright
author

docs/source/index.rst

Fixed


[ENH] Add pyspark clean_names

PR Description
Please describe the changes proposed in the pull request:

Added clean_names to pyspark. The function is identical except preserve_original_columns.
Added documentations.
Refactored change case in clean_names and _strip_underscores_func in janitor.utils so that the pyspark clean_names can share the same function.
Added spark testing DataFrame so that it is similar to pandas testing DataFrame.
Added  --cov-report html to test in Makefile so that the html report is generated automatically.
Added both and None to test_clean_names_strip_underscores. The branch was not included in the test suite.

PR Checklist

Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.rst.

[x] Add a line to CHANGELOG.rst under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[x] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
pycodestyle checking
running the test suite
docs build

Once done, please check off the check-box above.
If make check does not work for you, you can execute the commands listed in the Makefile individually.
Code Changes

If you are adding code changes, please ensure the following:

[x] Ensure that you have added tests.
[x] Run all tests ($ pytest .) locally on your machine.

[x] Check to ensure that test coverage covers the lines of code that you have added.
[x] Ensure that all tests pass.

Documentation Changes

If you are adding documentation changes, please ensure the following:

[x] Build the docs locally.
[x] View the docs to check that it renders correctly.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

@zjpoh, the PR involves quite a number of files, but at first glance this morning, I don't think I can see any issues here! Impressive work! :smile:. I'm going to hit merge!


CancellationToken for DownloadObject

It'd be nice to be able to pass a CancellationToken to DownloadObject(Object, Stream).  And possibly return true/false if the download was successful/interrupted.
The download for us can take some time and when we stop the Windows Service (triggering the CancellationToken), the only option we have is to kill the app.
I'd prefer to be able to clean up the file in progress.
When stopping the Windows Service, we have a 30s wait for it to finish naturally, so stopping our service can take some time if it's in the middle of downloading a file.

Is there any reason you don't want to use DownloadObjectAsync, which already takes a CancellationToken? It's fairly rare to accept a CancellationToken in a synchronous API call.

I guess I could "go async" for the one call. Or make everything async.
I'll probably do the async method for the one call. Though, I'm not totally comfortable switching back and forth from sync to async (catching exceptions for instance)

haha, know anyone who knows C# really well?  I just realised who I'm talking to. :)


Discrepancy in NL Solutions

Something wrong with mid-level solution BM velocity.
No further information.

Cannot reproduce w/o additional test input from George.

50dB, reproduced with RadauIIA5(autodiff=false) solver.
dxFENonLinearVector3! matches MATLAB exactly.
Workaround: use Rosenbrock23(autodiff=false) solver for now.

Hotfixed in v0.2.1

RadauIIA5 appears to work with longer sim time (takes longer to converge than ODE45)

This is a user-centric convergence issue, not a solver issue. Closing in favor of a rigorous convergence study.


Mobile number portability was launched in Armenia

On April 1, 2014 Mobile number portability was launched in Armenia, which means that subscribers of mobile Operators can have any mobile network code by porting in from the host operator.
from Wikipedia
I recomend adding information in readme or in documentation about mobile portability in general.

Thanks for letting us know @armleo!
We have documentation about number portability at https://github.com/googlei18n/libphonenumber/blob/master/FAQ.md#what-is-mobile-number-portability.
PhoneNumberUtil's isMobileNumberPortableRegion("AM") returns true, so the library's working as intended.

I mean add inormation about mobile portability in readme.md not in faq.md. And may be add link to faq.md. also please update demo cuz i cant see any usage of this function. (Maybe its just me)

Hi @armleo - would you mind opening separate new requests for all these in order for us to triage each separate issue separately?


[parcel-sourcemap] Source out of range

When trying to build this minimal example (using npm run dev), I get the following error:
🚨 Build failed.

parcel-transformer-svelte3-plus: [parcel-sourcemap] Source out of range

  Error: [parcel-sourcemap] Source out of range
  at NodeSourceMap.addVLQMap (/Users/marcel/Sites/sveltest/node_modules/@parcel/source-map/dist/node.js:37:28)
  at extendSourceMap (/Users/marcel/Sites/sveltest/node_modules/parcel-transformer-svelte3-plus/index.js:27:7)
  at Object.transform (/Users/marcel/Sites/sveltest/node_modules/parcel-transformer-svelte3-plus/index.js:214:14)
  at async Transformation.runTransformer (/Users/marcel/Sites/sveltest/node_modules/@parcel/core/lib/Transformation.js:627:5)
  at async Transformation.runPipeline (/Users/marcel/Sites/sveltest/node_modules/@parcel/core/lib/Transformation.js:376:36)
  at async Transformation.runPipelines (/Users/marcel/Sites/sveltest/node_modules/@parcel/core/lib/Transformation.js:253:40)
  at async Transformation.run (/Users/marcel/Sites/sveltest/node_modules/@parcel/core/lib/Transformation.js:173:21)
  at async Child.handleRequest (/Users/marcel/Sites/sveltest/node_modules/@parcel/workers/lib/child.js:217:9)

The problem disappears when I remove the import of Nested.svelte in assets/src/App.svelte (and the corresponding <Nested/> tag), so this is somehow what triggers the error.

The problem also disappears when using the parcel build command (not the serve or watch subcommand)

Thanks, but this way there are no source maps written, so I can't add breakpoints and the like in the browser's developer tools, can I?

I have reverted the last change, BUT now, the relative path to the original source us used.
I hope the SorceMaps are working properly now.

Alas, the same error as above, after updating to 0.2.5.

Ok, found out, that I probably had outdated versions inside my node_modules.
After updating, I was able to repsoduce this again.
I probably found the root-cause: The SourceMap of the preprocessed scss includes two paths to source-files: an absolute path, and a relative path to the same Nested.svelte file (only when not building a production-build).
These paths are now rebased to the project-root.


fix(chat): fix prompts select mode in search mode (Issue #1874)

Description:

fix checkboxes behaviour in search mode
fix delete selected prompts behaviour in search mode

Issues:

Issue #1874

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Difference between listening to actions in componentWillMount and componentDidMount

Just quick question, the Reflux documentation states:
Register your component to listen for changes in your data stores, preferably in the componentDidMount lifecycle method ...
What is the practical differences between listening to actions in componentDidMount as opposed to componentWillMount? Alternatively, why is it preferable to do it in componentDidMount?
I know componentWillMount is called before React renders but I don't see any practical difference between the two.

if you didn't use getInitialState it might save rerender, and getInitialState doesn't easy to use in ES6 React component, as in React.createClass

For questions please use the following communication channels:

StackOverflow with the refluxjs tag
#reflux channel on Reactiflux Slack group. Sign up here for an account.

Please only use the issue tracker for bugs and feature requests only.


[Docs][Table] Refresh Example: Customizing Columns

https://www.figma.com/file/N84ebgxXVKZTMVClV2x0VP/Pattern-guideline?type=design&node-id=21449-114185&mode=design&t=GEcYw5fN5iSbRSTF-0

There is a bug in the customizing columns modal. The Save button remains disabled even after adjusting the column order.


update shellerror on newer nushell versions

Hi.
Currently, if you try to cargo install --path . you will get a build error. This fixes it.

Thanks @dmatos2012 !!


KerasClassifier problem when a label is not present in a particular split

This is an issue with Keras scikit-learn wrapper which I am using with sklearn.model_selection.RandomizedSearchCV(...).
KerasClassifier.fit(self, x, y, ...) assumes that all labels that a model can predict exist in the training data (i.e. in 'y'):
line 203
self.classes_ = np.unique(y)
However, in my case the model has three outputs but a particular split sometimes contains only two labels because the third label is rare. Because the model sometimes still predicts that label that's not in self.classes_, I get an error causes by this line in KerasClassifier.predict(...):
line 234
return self.classes_[classes]

I verified that replacing the line:
self.classes_ = np.unique(y)
with this line:
self.classes_ = np.array([0, 1, 2])
fixes the problem.

I would look into a Stratified KFold  routine instead of the typical KFold CV. With RandomizedSearch you can specify your own CV routine.

@liebscher Thanks. This may or may not help. In some cases there's only one example of the third class, so one of the folds will unavoidably contain only two classes. It seems like this is a bug that should be addressed. Maybe KerasClassifier should have a way to specify the number of classes in the data or something like that.

@dmitriydligach you're right, when there's only one sample under the label even Stratified KFold will throw an exception. If there are cases where there's only one sample in the data set with a certain label, you may be very hard pressed to train a model to learn it. Hopefully someone else sees this issue and has a more optimistic solution!


VerifyAccessToken doesn't work because  DecryptToken not implemented yet

Describe the bug
VerifyAccessToken doesn't work because  DecryptToken has not been implemented yet
To Reproduce
Steps to reproduce the behavior:
To use VerifyAccessToken functionality. it supposed to decrypt the access token and add values in claims. Then claims can be verified based on the validations. since DecryptToken not implemented so it doesn't. work
Expected behavior
VerifyAccessToken to work, and claims have as per the claims in Access token
Screenshots

Desktop (please complete the following information):

OS: Mac OS

Hey @esumit
Thanks for the issue. You're right, at the moment the library does not handle de/encryption of tokens, whether RP nor OP.
The intention is to add this in the future. But we haven't had a use case ourselves yet. So I'd be interested to hear what yours is.
From your screenshot I believe you're trying to verify the access token on the OP. Is this correct?
If so, could you tell me more about your case. As far as I can see, the OP will only have to validate tokens issued by himself. So decrypting will only be necessary if he encrypted the token himself, which is not possible by the library at the moment.

Closing this issue as it looks inactive

@livio-a Sorry on the delay in my response. In my case - I tried to use VerifyAccessToken function !  on that flow I assumed that output of Decrypt function would be utilized by ParseToken (As ParseToken given the error)
func DecryptToken(tokenString string) (string, error) {
return tokenString, nil //TODO: impl
}
then I thought  may be something supposed to  get implemented on DecryptToken ? so reported the issue. (it was my first time using go oidc library for some of the APIs to have access token way of access when called from another internal service)


MWPW-141918 Blog Template & Blog Posts

Gets blog working with template flow from milo.
Important for testing: please do not bother testing the marquee, how-to-steps or template-lists on the blog pages. The marquee & how-to-steps, etc. will be migrated later and template-lists are deprecated, which is why we will not be investing much effort into them anymore (unless you see something super critical)
Resolves: MWPW-141918, MWPW-143330
Test URLs:

https://blog--express-milo--adobecom.hlx.live/express/learn/blog?martech=off

https://www.adobe.com/express/learn/blog?martech=off

https://blog--express-milo--adobecom.hlx.live/express/learn/blog/instagram-stories?martech=off

https://www.adobe.com/express/learn/blog/instagram-stories?martech=off

DE Pages

https://blog--express-milo--adobecom.hlx.live/de/express/learn/blog?martech=off

https://www.adobe.com/de/express/learn/blog?martech=off

https://blog--express-milo--adobecom.hlx.live/de/express/learn/blog/new-mobile-app?martech=off

https://www.adobe.com/de/express/learn/blog/new-mobile-app?martech=off

FAQ Block

https://blog--express-milo--adobecom.hlx.live/br/express/learn/blog/how-to-make-a-living-blogging?martech=off
https://www.adobe.com/br/express/learn/blog/how-to-make-a-living-blogging?martech=off

Columns Block

https://blog--express-milo--adobecom.hlx.live/de/express/learn/blog/101-brilliant-color-combinations?martech=off
https://www.adobe.com/de/express/learn/blog/101-brilliant-color-combinations?martech=off

Link List Block

https://blog--express-milo--adobecom.hlx.live/express/learn/blog/tags/design?martech=off
https://www.adobe.com/express/learn/blog/tags/design?martech=off

Codecov Report
Attention: Patch coverage is 22.36842% with 59 lines in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (f8f8497) to head (d1279bc).

Files
Patch %
Lines

express/scripts/scripts.js
22.36%
59 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   60.42%   58.21%   -2.22%
==========================================
  Files          23       23
  Lines        3694     3769      +75
==========================================
- Hits         2232     2194      -38
- Misses       1462     1575     +113

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@vhargrave - Over this looks good to me. All of the pages I looked at seemed to look "identical" to the adobe.com pages. There were a few things in the blog-post.js that looked like they could be enhanced, but I assume these are copied over from express and we can optimize later.


IGAPP-963: Fix passing of build config to android builds and metro

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

@Cmd190 replaceAll should be available with a node version > v15, please check what version you have installed. Node v15 is required for the project anyway.
@Taggotty any reason why you split it in two commands? This does not work as the envs are not persisted across steps.
Also from the docs:

The rule of thumb is: if you want to pass to cross-env a command that contains special shell characters that you want interpreted, then use cross-env-shell. Otherwise stick to cross-env.

@Cmd190 replaceAll should be available with a node version > v15, please check what version you have installed. Node v15 is required for the project anyway.
@Taggotty any reason why you split it in two commands? This does not work as the envs are not persisted across steps. Also from the docs:

The rule of thumb is: if you want to pass to cross-env a command that contains special shell characters that you want interpreted, then use cross-env-shell. Otherwise stick to cross-env.

Yes in windows, cross-env was not able to spawn the follow up command. After splitting it in two it worked. Therefore, I didn't think more about it. But the first one must have had an impact, as it did not work with only the second. I'll test this one later this day on a windows PC, but I don't really get my hopes up, as I think this will not work. I am definitely fine with it, but @Cmd190 might not be please with this solution :D

Can you please explain, what was the problem here and how you fixed it. I do not really understand whats going on here, therefore I can not really review.

So the problem was that android builds (and the metro packager) did not receive the build config we supplied. Therefore always the default (integreat for yarn android and integreat test cms for metro) was used. This leads to building integreat when you want to bulid malte, aschaffenburg... The reason why the build config was not supplied is that cross-env does not persist the envs across multiple commands. Therefore I merged the two commands (cross-env and the actual command) together.

Tested on windows and seems to work fine now. Maybe the problem was that the second command was not prefixed with yarn?
Previous implementation:
    const command = `react-native run-android --no-packager --appId ${applicationId} ${productionFlag}`
    execSync(`yarn cross-env ${buildConfig} ${command}`, { stdio: 'inherit' })

Nice! Perhaps the missing yarn was the reason yes. Hopefully all cases handled now.


[release-0.44] back port :Bump the version of go-restful to 2.16.0

Original PR: #8092
Because of a security issue in go-restful v2.15.0
Original PR: #8553
To fix compilation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Bump the version of emicklei/go-restful from 2.15.0 to 2.16.0

/approve

/lgtm

/retest-required

/retest-required

The network lanes are failing on a known flaky test (and only that). Overriding.
/override pull-kubevirt-e2e-k8s-1.19-sig-network
/override pull-kubevirt-e2e-k8s-1.20-sig-network
/override pull-kubevirt-e2e-k8s-1.21-sig-network


Jeff Schaller: Watch bestvacuuming.com

Jeff Schaller requests the watch of the watch_keyword bestvacuuming\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

bestvacuuming\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by double-beep in Charcoal HQ


Move token tables to module porting layer

Pass the compilation of bg96, hl7802, and sara_r4.
There is only one cellular_api.h change. Other changes are module codes.


ARROW-602: [C++] Provide iterator access to primitive elements inside an Array

Create Iterator method in stl for Array and ChunkedArray

I suggest we add begin/end methods to ChunkedArray

That wouldn't work, because there are no specialized subclasses of ChunkedArray. We want the iterator to yield raw C values whose type is datatype-specific.

There is an experimental MultipleChunkIterator that seems to not be used in the codebase.

It's used by ApplyBinaryChunked.

That wouldn't work, because there are no specialized subclasses of ChunkedArray. We want the iterator to yield raw C values whose type is datatype-specific.
...I still think it can work for the Array types that currently support iteration (std::enable_if magic). The ChunkedArrayIterator in this PR can extract raw C values from a ChunkedArray so I am not suggesting something different.

It's used by ApplyBinaryChunked.
My mistake, did a grep and thought only declaration/definition were in chunked_array.h/cc

That wouldn't work, because there are no specialized subclasses of ChunkedArray. We want the iterator to yield raw C values whose type is datatype-specific.

...I still think it can work for the Array types that currently support iteration (std::enable_if magic). The ChunkedArrayIterator in this PR can extract raw C values from a ChunkedArray so I am not suggesting something different.

Er, you simply can't implement begin right? It would have to be
template <typename Type>
ChunkedArrayIterator<Type> begin() const;

which is a little clumsy

...I still think it can work for the Array types that currently support iteration (std::enable_if magic).

begin() and end() must return a well-known iterator type and it cannot depend on the datatype.

I am not fully convinced but no need on continuing this rant. I will wait for this PR to be merged and try something out.
Thanks for the all the great feedback!

@pitrou @lidavidm I see now the issue with typing and ChunkedArray. Related to this, @AlvinJ15 attempted to add ChunkedArrayIterator as a friend class to ChunkedArray, but ChunkedArrayIterator requires the ArrayType template parameter.
ChunkedArray is agnostic of the Array type which ChunkedArrayIterator requires. Nevertheless, we can get the ArrayType via TypeTraits if we have the data type at compile-time. Specialized Arrays have the TypeClass attribute which would work, but this attribute is not part of the base Array class which is what ChunkedArray works with.
If we could add a TypeClass attribute to base Array then I think we are good, but what value would it have?
Other ideas?

If we could add a TypeClass attribute to base Array then I think we are good, but what value would it have?

How would this work? The value would vary at runtime, but we need it to be compile time.

A solution is to have the factory MakeIterator not be templated and check the type of the chunked_array at runtime, and use a switch-case to dispatch the correct ChunkedArrayIterator.

@pitrou @lidavidm I apologize for all the unnecessary comments/discussion I made, I thought this was a new JIRA issue and had no idea of all the discussions that had happened in the JIRA comments.

@lidavidm @pitrou @edponce How can I check why it is failing just in Windows?

@AlvinJ15 Well, I think the error log explains it:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/43442933/job/21gmmvnmdmdjvsh5#L996

Hmm, I think my Iterate suggestion was a bit too vague. To satisfy the requirements for iteration and for call STL algorithms, we need "begin" and "end" iterators. Basically, I would suggest something like:
/// Return an iterator to the beginning of the chunked array
template <typename Type, typename ArrayType = typename TypeTraits<Type>::ArrayType>
ChunkedArrayIterator<ArrayType> Begin(const ChunkedArray& chunked_array) {
  return stl::ChunkedArrayIterator<ArrayType>(chunked_array);
}

/// Return an iterator to the end of the chunked array
template <typename Type, typename ArrayType = typename TypeTraits<Type>::ArrayType>
ChunkedArrayIterator<ArrayType> End(const ChunkedArray& chunked_array) {
  return stl::ChunkedArrayIterator<ArrayType>(chunked_array, chunked_array.length());
}

template <typename ArrayType>
struct ChunkedArrayRange {
  const ChunkedArray* chunked_array;

  ChunkedArrayIterator<ArrayType> begin() {
    return stl::ChunkedArrayIterator<ArrayType>(*chunked_array);
  }
  ChunkedArrayIterator<ArrayType> end() {
    return stl::ChunkedArrayIterator<ArrayType>(*chunked_array, chunked_array.length());
  }
};

/// Return an iterable range over the chunked array
///
/// This makes it easy to use a chunked array in a for-range construct.
template <typename Type, typename ArrayType = typename TypeTraits<Type>::ArrayType>
ChunkedArrayRange<ArrayType> Iterate(const ChunkedArray& chunked_array) {
  return stl::ChunkedArrayRange<ArrayType>(&chunked_array);
}

This way you can write:
for (util::optional<int64_t> : Iterate<Int64Type>(chunked_array)) {
  ...

as well as:
// Find the first item that's non-null and at least 42
auto it = std::find_if(
    Begin<Int64Type>(chunked_array), End<Int64Type>(chunked_array),
    [util::optional<int64_t> item]() { return item.has_value() && *item >= 42});

@westonpace @lidavidm Feel free to leave any comments on the API even after this is merged.


Errors creating or updating service are swallowed

They are not reported or propagated

Thanks - I'm not sure what the original intention was with this. I expect a typo!


File.current_offset is private to the crate and there is no tell()

The File object provides handy seek_*() methods to move to a specific position, but there is no tell() method to get the current position. This forces client applications to track file offsets themselves or use f.size() - f.left().

Oops. Feel like sending a PR?

Sure! I guess even Rust newbie like me can handle this one. :-)

Oh… current git version is different than the released on – there are no File methods at all.
I guess this has to wait until  #99 is resolved.

Oh… there already is VolumeManager.file_offset() method. So I guess that has been already solved.

Oh, nice. I'd forgotten about that.


Which version of Flash Attention has been used in this project?

Hi,
I find the project is very interesting. Can I ask which Flash Attention has been used in this project?
From the official flash attention project, they have provided flash attention and flash attention v2.
https://github.com/Dao-AILab/flash-attention
Kind regards,
Qiming

@14H034160212 Thank you for your interest. I used PyTorch's Scaled Dot-Product Attention to speed up inference speed instead of Dao's implementations.

Do you use the Flash attention 2 that implemented here? There are three supported implementations of scaled dot product attention.


Fixing swift3 syntax and auto layout issues

The code don't conforms to current swift 3 syntax. And the Constraints with visual format create a auto layout issue.
Refactored code to latest swift 3 syntax and changed the constraints to a modern way.

@iLem0n
Very thanks! and .. sorry.
I do not want to add branch processing according to iOS version, so please close this pull request once.


Support targeting Node

💡 Feature description
I was trying @xtuc's wasm-node-loader, but noticed the output of wasm-pack is not compatible to Node 10.
Three things I noticed:

the file ending of the generated JS file is .js, but node will require a .mjs ending.
import of the wasm file not ending with .wasm.  e.g. import * as wasm from './app_bg'; . With the node loader it should be import * as wasm from './app_bg.wasm.
after I changed them manually node was still complaining it can't fine "./app.js", but not sure where this was coming from.

I'm not sure what's the best way forward. wasm-pack could support a commnand line flag for wasm-pack build to target node. On the other hand maybe it needs a different node loader.

Hey @nikgraf so this is doable. However, the major blocker is wasm-bindgen until that gets support for Node modules we won't be able to move this forward, because otherwise we'd be parsing JS files to do the transform rather than wasm-bindgen spitting them out automatically as .mjs files with the correct import statements.

Thanks for the clarification 👍

hey @nikgraf - so wasm-pack can support node by exporting CommonJS. would this work for you? we aren't currently of the impression that es6 modules on node are stable enough to support. you would need nodejs with a flag, which also still has bugs and edgecases, and we don't have a way to give reliable commonjs fallback either, which is frustrating.
let me know if the CommonJS use case works for you! you can use it by running wasm-pack init --target nodejs

This isn't blocking to me.
The issue is that the current ESM implementation in bundler and the future one in Nodejs, will have some differences, .mjs is an example.
I wouldn't work on making ESM for bundler also compatible for Nodejs.

@ashleygwilliams just tried it and works like a charm. I thought loading WASM won't work with CommonJS, but I does just fine. Thanks!

Great to hear! Glad it worked for you :)


Error importing carla map from roadRunner. "ERROR: buildNavigation: Could not create solid heightfield"

Hi,
I am working on custom map. I have made the map in roadrunner. Unfortunately, I am experiencing "ERROR: buildNavigation: Could not create solid heightfield." error after last step in build from source [build.sh "my custom map"].
CARLA version: 0.9.13
Platform/OS: linux
Problem you have experienced: I am experience error while importing carla map exported from Raodrunner.
What you expected to happen: I want to import custom map made in roadrunner. However, I am getting  "ERROR: buildNavigation: Could not create solid heightfield."

the same problem i encounter ,have you resolve the problem


Quick diff source drop down does not show on the mac

Testing #174853
I don't see a drop down widget to select source:

Also, after clicking on the gutter for local changes, the quick diff does not appear in line with the gutter position for local change. Also seen the screenshot above.

Did you modify any files locally (not just in the PR)? You'll only get the drop down when there are multiple providers, so if you only have pull request changes and no git changes then you wont see it.

Also, after clicking on the gutter for local changes, the quick diff does not appear in line with the gutter position for local change. Also seen the screenshot above.

@bhavyaus which line did you click on? It should appear on the line that you clicked on.

I did modify the file locally. I cant seem to repro this any more. closing.


Error when < appears in description

If a theorem has the '<' character in its description (such as wlkres), mm-lamp gives the error 'Attribute "style" is not supported.' when displaying the description.

For now, as a workaround, you may type < instead of <. This will result in showing < on the Editor tab correctly, but < will be showed in the completed proof, so you'll have to replace it manually if you want to put the proof to an MM database.
I am thinking on how to fix this bug.


Hybrid mode in a single cluster: services + batch

What would you like to be added:
The ability to account for quota usage coming from service pods (Deployment, Daemonset, Statefulset, etc).
Why is this needed:
In on-prem clusters or cloud clusters with reservations, organizations want to schedule jobs on the valleys of usage by services.
Completion requirements:
This enhancement requires the following artifacts:

[x] Design doc
[x] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

/assign

So currently we assume that queuing is only valid for finite jobs but is there a consideration that we would want Kueue to work for services also?
ie have other apps objects have a suspend field?
I know that yunikorn/MCAD allow for queuing/scheduling of services in addition to batch workloads

Not necessarily queuing, but accounting for their usage.
The use case is hybrid clusters where you are running most services during the day, and there are valleys at night that can be used by jobs.
This is useful in fixed size clusters. But on the cloud, you could just have 2 separate clusters (one for services and one for jobs) and have autoscaling in both.

/remove-lifecycle stale


Threaded HTTP server

Use threads to allow for concurrency so that server is more efficient. If users have to wait a long time for things to load, the app won't be very well-liked.

Closed in recent commit. I found the library ThreadingHTTPServer and used it instead of HTTPServer. It's supposed to be identical, except that it uses threads. I haven't tested it that much so we'll see.


DeepSpeedStrategy integration

Description & Motivation
Hi, I would like to ask when the fabric DeepSpeed Strategy will be released in a stable version.
We are trying to finetune LLama2-70B-hf distributed with QLoRA.
Pitch
No response
Alternatives
No response
Additional context
@morettif and I tried to use the DeepSpeed Strategy for distributed training of a LLM (LLama2-70B-hf) and faced the following issues:

For the precision management it was not possible to define it in both Fabric and DeepSpeed configs. Below the configs used are reported.

{
  "zero_optimization": {
    "stage": 2,
    "contiguous_gradients": true,
    "overlap_comm": true,
    "zero_quantized_weights": true,
    "zero_quantized_gradients": true
  },
  "zero_allow_untested_optimizer": true,
  "gradient_accumulation_steps": 8,
  "train_batch_size": 32,
  "train_micro_batch_size_per_gpu": 2,
  "wall_clock_breakdown": false,
  "bf16": {
    "enabled": "auto"
  },
  "fp16": {
    "enabled": "false",
    "auto_cast": false,
    "loss_scale": 0,
    "initial_scale_power": 32,
    "loss_scale_window": 1000,
    "hysteresis": 2,
    "min_loss_scale": 1
  },
  "zero_hpz_partition_size": 16
}

After resolving the precision problem, we setup the model and the optimizer (bnb.optim.PagedAdamW from bitsandbytes) with the fabric.setup() function. The optimizer returned by the setup function is not compatible with the torch schedulers (see below).

scheduler1 = torch.optim.lr_scheduler.LambdaLR(
    optimizer, lambda step: step / warmup_steps
)
scheduler2 = torch.optim.lr_scheduler.CosineAnnealingLR(
    optimizer, T_max=(max_steps - warmup_steps)
)
return torch.optim.lr_scheduler.SequentialLR(
    optimizer, [scheduler1, scheduler2], milestones=[warmup_steps]
)

Fabric was instantiated with the following configs:

devices = 4
plugins = BitsandbytesPrecision("nf4-dq", "bf16-true")
precision = None

cc @borda

Hey @michele-milesi
The DeepSpeed integration in Lightning exists since 2 years and has been maintained for a while. However since a few months now we haven't had the bandwidth to keep up with it. Our CI testing has the version of DeepSpeed at 0.9.3. The problem is the DeepSpeed project itself doesn't see good maintenance, and they are not writing tests for most of their commits. This poses challenges also for us as it is just a large effort to keep up resolving the issues. So the future is very uncertain.
For sharded training (ZeRO) our FSDP support is the best for this at the moment, and is actively maintained.
The main limitation for you will be that precision plugins like BNB won't compose with the precision settings of the FSDP and DeepSpeed strategy. So in other words, you can't use BNB +  FSDP or DeepSpeed. We are aware of this and tracking the effort here: #18679. But it's not easy.
Sorry that I don't have better news.

Thanks for your feedback


chore: adding upgrade handler for 09-localhost removal

Description

Adding upgrade handler for pruning of 09-localhost client and consensus states
Adding migration docs

closes: #1201

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

I think this PR also requires some migration docs added to instruct devs to wire up the upgrade handler.
I will add some!
I've added a new directory upgrades/v5 under core. I am open to suggestions on moving this to somewhere else but I think this is a nice pattern to use for upgrade handlers for ibc core logic. Inspired from osmosis here

Which approach should we take with naming?

I like migrations. Typically this functionality would be run by SDK's RunMigrations function. It isn't only because most chains don't have a localhost thus making the extra computation unnecessary. I also want to avoid confusion with client/connection/channel upgrades

Which approach should we take with naming?

I like migrations. Typically this functionality would be run by SDK's RunMigrations function. It isn't only because most chains don't have a localhost thus making the extra computation unnecessary. I also want to avoid confusion with client/connection/channel upgrades

Sounds good, that's a compelling enough argument for me! I'll update this today with the naming changes throughout 👍


To get some clarifications about using V2e events ..

Hi,
we are planning to use v2e to generate events for static images and videos(collected as 6Hz frames by a drone). Herewith i am requesting your support to understand following things related to v2e.

Normally event camera has a temporal resolution of 1us (microsecond). Can we have 1us temporal resolution for a video of 1 second period with v2e event synthesizer?

If the timestamp step is 1ms, then that means we can have 1000 time bins/steps for a one second video?
if it is we can maximum of 1000 events for one pixel for a video of 1s.Isn't it?

In the v2e paper, it is mentioned that 'The upsampled frames corresponds to timestamps'.  So, if then the time stamp step is 1ms, then  it  should have 1000 time stamps for 1 second video, isn't it?
If it is, That means it should contain 1000 upsampled frames. But according to the example given in the paper (60Hz video with DVS timestamp step 1ms) the number of upsampled frames is 17 (not 1000 as i thought it should be). So could you please explain where my understanding went wrong?

is it still possible to generate events when we have only one image (still image) by simulating some kind of virtual camera movement with v2e? Could you please share the code which how still images are converted to a small video using the saccade motion so that it can be fed for event generation?

Is there anyway that we can refer the code that you used to generate events for N-Caltech 101, MVSEC data sets using v2e? Because, with that we can comfortable understand how to access the v2e event database, how to compose voxel grids by organizing the v2e events accordingly and also how to synthesize events for static image with v2e.
Thank you so much.

Rgds,
Udayanga

You could in principle generate 1us timestamp resolution v2e output, but it would be terribly slow because you would be upsampling to 1MHz frame rate.... would take forever.  More realistic is either 100us or 1ms for real input. The timestamp jitter under most lighting conditions is on the order of 100us to 1ms (see the plot in the original DVS128 paper at Fig. 10 of Lichtsteiner, Patrick, Christoph Posch, and Tobi Delbruck. 2008. “A 128×128 120 dB 15 μs Latency Asynchronous Temporal Contrast Vision Sensor.” IEEE Journal of Solid-State Circuits 43 (2): 566–76. https://doi.org/10.1109/jssc.2007.914337.)
No, you can get a larger number of events than 1 event per timestamp resolution if the contrast change is large enough. But note that the refractory period will also limit the number of events and 1kHz event rate per pixel is unrealisitically high. Typically we can get at MOST a few hundreds events per second from individual pixels when small parts of the sensor are stimulated.
the respeated events will have timestamps linearly interpolated between the the upsampling times. See the code for how this works. v2e computes the max number of events from any one pixel in each frame, then assigns the interframe timestamp interval to be that number of timestamps for that frame. I.e. if the upsampled timestamp interval is T and there are N max events from some pixel, then the timestamps will be T/N for that frame.  But note there may also be some interaction with the refractory period; see the code for how that works.
You could write such saccade generator pretty easily using synthetic input module, but we don't have one now. If I were to do it, I would just copy one of the synthetic input classes and then modify it to take an image as input argument, and some other possible parameters, then transform this image using OpenCV methods and supply these frames to v2e along with their times.  I could try to write this but don't have time now. I suggest starting from moving_dot.py since it takes arguments already https://github.com/SensorsINI/v2e/blob/master/scripts/moving_dot.py
We can look for MVSEC and Caltech101 code but Yuhuang would be the guy for this.

hope this helps.

A saccade generator synthetic input class could be useful for reproducing datasets like N-Caltech101. I'll take a look next time working on v2e. In the meantime, I think someone else could write such class and suggest a push with it.

Thank you so much for all the valuable information and guidelines !!

Hi,
Further, could you please help me to understand the following concerns regarding saccade camera trajectory?
-In the v2e paper it is mentioned that "Each image in the Caltech 101 dataset was
recorded by a DVS for 300 ms using three 100 ms-long tri-angular saccade".
-As i expect to generate events for static images (which is related to structural damages), since it is required a set of frames for the event generation, I checked out the code for ESIM ( (https://github.com/uzh-rpg/rpg_esim) and was able to get some frames for a static image with random camera motion. But according to the paper i also want to use the saccade motion for the camera. In the original paper also it is said that "three micro-saccades tracing out an isosceles triangle was used on each (static) image" to generate set of from a static image.
If i want to do this same thing in ESIM , Normally, how should i provide the corresponding trajectory for the camera for saccades tracing out an isosceles triangle?
In the original paper three micro saccades are mentioned as in the table in shown in the following link. Here it seems there are no translations of the camera and only rotations. starting and end orientations of the camera is related to a one micro saccades is for example (-0.5 deg,0.5 deg,0) to (0.5,0.5,0) degree).
https://www.frontiersin.org/files/Articles/159859/fnins-09-00437-HTML/image_m/fnins-09-00437-t001.jpg

I have provided the following trajectory to ESIM, where first entry is the time, second three entries are the position of the camera and third  four entries are the quarternion which related to the orientation. Is that correct? however in this way i cannot provide the speed for each micro saccade. Is the speed can also be fed? If it is,could you please tell me how should i do that?

#time  x y z qx qy qz qw
0                                            0     0   0        -0.0044    0.0044    0.0000     1
100000000                             0    0    0      -0.0044        0                 0       1
200000000                            0    0     0     0.0044    0.0044   -0.0000   1.0000
300000000                             0   0     0     0.0044   -0.0044    0.0000 1
Thank you !!

I'm sorry I can't help with this issue, hope you worked it out.


Make sure timezone is initialized

Timezone is not initialised if none of use_server_time_zone and use_time_zone is set.
As consequence client gets parser exception when retrieving dates. See https://youtrack.jetbrains.com/issue/DBE-7776

Thanks


Enable running basic system tests without requiring whisk.properties

Enables running the basic system test without requiring a whisk.properties file to be present. This would be useful to run test against a remote setup which is not configured via local ansible playbooks
Description
See updated readme for details. In brief for a local default setup basic system test can be run just via
$ ./gradlew :tests:testSystemBasic -Dwhisk.auth="23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP" -Dwhisk.server=https://localhost -Dwhisk.ssl.relax=true

Related issue and scope

[x] I opened an issue to propose and discuss this change (#4003)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[x] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[x] I updated the documentation where necessary.

Codecov Report

Merging #4004 into master will decrease coverage by 4.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
- Coverage    85.8%   81.14%   -4.67%
==========================================
  Files         146      146
  Lines        7096     7096
  Branches      441      441
==========================================
- Hits         6089     5758     -331
- Misses       1007     1338     +331

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.1%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-81.82%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
0% <0%> (-58.83%)
:arrow_down:

...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala
92% <0%> (-4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1515e41...acbb722. Read the comment docs.

PG1 3350 🏃


SimpleGUI missing

Many of these demos depend on SimpleGUI, which doesn't appear available in OpenFL.
Any plans to either substitute or port that over?
If I recall SimpleGUI is built on top of MinimalComps, which I think has already been ported.  Any interest in porting SimpleGUI?  There's a version circa 2011 that I have, which looks portable.
Unless there's direction on this, I'd take a stab at porting SimpleGUI and/or MinimalComps.

There were a couple version of MinimalComps, though dated and only partially operational.  As well, none were available via haxelib.
Still alpha, my port of MinimalComps is coming together, and submitted to haxelib.
SimpleGUI will follow soon.
Once complete, this will be an option if you're interested.

That sounds great and will certainly make these samples more complete.

Close, but there are still some issues across targets.

Pull request might be a week or so out for you to review.

Totally dropped the ball on this - MinimalComps is in relatively decent shape, but suffers some cross platform issues with web.  SimpleGUI is there, but ceased at a RegEx exec call.
Intermediate monster head is cool, but all other demos experience unique issues.
Fractal Trees is broken, when you submit the form the app fails to render.
Shallow Water implementation seems distant, leveraging pixel bender if I recall - not sure when / if roadmaps will ever introduce that functionality.
So, I've lost some steam on this; however, I'd still like to complete this, even if only with partial functionality.


Task/add modal

Added a modal that would prompt the user to leave the current form they are on, and discard the changes they have been working on.

Features

Added modal to handle when user is switching from a form (create/update) to a different view.
Prompts user to stay on current view, or discard changes and go to the selected view.

Still needs addressing

Location of modal
Styling of modal

Tests Done

View: Dashboard Calendar
[ ] Displays Subscription List, shows dashboardCalendar
View: Subscription Detail
[ ] Clicking Edit button shows Update Subscription form (no modal)
[ ] Clicking Close shows Dashboard Calendar (no modal)
[ ] Clicking Delete shows Dashboard Calendar (no modal)
[ ] Clicking Edit Pen shows Update Subscription Form (no modal).
View: Update Subscription Form
[ ] Clicking close button shows modal

[ ] Clicking stay, returns to form
[ ] Clicking discard changes, directs to Subscription Detail

[ ] Clicking Edit Pen

[ ] Shows modal
[ ] Stays in form if user click's 'Stay In Page'
[ ] Directs to correct form if user click's 'Discard Changes'

[ ] Clicking Delete in subscription list deletes correct subscription

[ ] Stays on Update Subscription Form is deleting different subscription
[ ] Redirects to Dashboard Calendar if deleting the subscription that is being updated.

View : Create Subscription Form

[ ] Close Button Shows Modal
[ ] Same tests as other Modal tests.
[ ] Clicking subscription from subscription list should show modal.
[ ] clicking Edit Pen from subscription list should show modal.
[ ] Clicking Delete icon should keep create subscription form as is.

Changes

Changed dashboardModal component to modalComponent, for reusability. If we need more modals, we can utilize modalComponent.

Changes

Changed dashboardModal component to modalComponent, for reusability. If we need more modals, we can utilize modalComponent.

this is good in practice, but the content is still static to just navigation right now. if we. could dynamically render the header, body, and footer content then this reusability would be more applicable. But until then, keeping this isolated to a modal that specifically is used for confirming the navigation for the user is fine and can be named applicable to that functionality


CODING: C++ Tutorial

Coding entry, a link that sends you to w3schools C++

I also fixed this entry, I hope this was also correct, thank you!


User story: specify opportunity frequency

Opportunities need a frequency specification that can allow setting the frequency unit (day, week, month, year) and a frequency modifier (1st, 2nd, 3rd, 4th).

@stevenabadie I think you added this in the api branch? I do need to do this on the front-end still.

Working on this now...

We should close this issue. It is done in my /react branch.


Revert "Fix make_report_error_api usage of Client._project."

To fix https://github.com/GoogleCloudPlatform/google-cloud-python/issues/3233

@DizzeePascall see my response on #3233, this issue should be fixed / the PR does not need to be reverted (though I may be mistaken).

This PR is filed on behalf of Spotify, which I believe has filed the CLA as a corporation

This LGTM. It's nice that reverting did exactly what was needed.
@lukesneeringer @jonparrott Any idea where the CLA check went?
@DizzeePascall Once this is merged I can push 0.23.3 today. SG?

@dhermes I hadn't joined the Google group until just now, which explains why the CLA check failed. It'd be absolutely great if you could get this merged and pushed by the end of the day 👍

I will push a tag (which automatically pushes to PyPI) once https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1413 passes

This is finally going out (as 0.24.0) and will be pushed by this build:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1575
Thanks for the patience!


Create and use selectSlice as top level selector

Closing, re https://github.com/near/near-wallet/pull/2108


[AA-1168] remove deprecated updates tab

This removes the deprecated Updates tab, which was only visible for Cloud ODS deploys, performed no changes, and displayed information which was in fact inaccurate. Rather than maintain it further, it is meant to be removed.
This involved touches to the Home screen button display logic, which was found to be needlessly complex (some decisions of item inclusion was handled in the intended service class, while some was being handled in the view). This simplifies the logic to one place so that it is easy to map code to item visibility requirements.

Developer testing

Went through the individual commits
Local build testing (including different configurations for Home Screen testing)
Unit tests pass successfully


Outliers in prediction score

What does the outliers in prediction score mean. For example:
       datetime instrument     score
1944 2021-12-31       TADS  3.052688
242  2021-12-31       CBSE  0.212113
255  2021-12-31        CHB  0.209660
545  2021-12-31       EWCO  0.207444
1884 2021-12-31       SPQQ  0.193577
...         ...        ...       ...
63   2021-12-31       ARKG -0.665926
1695 2021-12-31       RIGZ -0.673914
64   2021-12-31       ARKK -0.675445
1342 2021-12-31       MJXL -0.705074
1970 2021-12-31       THCX -0.834564

The TADS is apparently an outlier. Should it be considered as unreliable for TADS?

As far as I know, I don't find a general solution to explain these predictions with extreme values.
It depends on your data and model.
Maybe there are similar examples in your training data and your model overfits these examples.


Add doc coverage information

This PR adds the usage of the --show-coverage option of rustdoc. It currently looks like this:

A few things I think remains to be done (to be debated for some of them I guess?):

Add tests
Add this score in crates search results?
Add color code (like if it's 100% it's green and the closer to 0, the whiter?)

Not sure to understand the issue with clippy here:
error: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
##[error]   --> src/docbuilder/rustwide_builder.rs:550:43
    |
550 |               .process_lines(&mut |line, _| {
    |  ___________________________________________^
551 | |                 if line.starts_with('{') && line.ends_with('}') {
552 | |                     json = line.to_owned();
553 | |                 }
554 | |             })
    | |_____________^
    |
    = note: `-D clippy::blocks-in-if-conditions` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions

Looks like a false-positive from the lint.

And I think I forgot to add something in the migration tests, but not sure what exactly...

Updated!

Updated! I updated the screenshot as well.

This says '50 out of 52 items documented' in the screenshot - does it have a subpage that shows which items are documented and which aren't? And if not, could you add that? Maybe /crate/:crate/:version/coverage or something, you could have it as one of the tabs after 'Builds'.

Updated! I also added it into the "popup" as @jyn514 said. :) Screenshots updated.

Updated! :)

This says '50 out of 52 items documented' in the screenshot - does it have a subpage that shows which items are documented and which aren't? And if not, could you add that? Maybe /crate/:crate/:version/coverage or something, you could have it as one of the tabs after 'Builds'.

I ran this locally and it turns out rustdoc doesn't output this info! Maybe at some point rustdoc could add this and you could make a follow-up PR? No need to block on it though.
{"src/fpformat.rs":{"total":2,"with_docs":2},"src/lib.rs":{"total":17,"with_docs":17}}

It might be nice to break down the coverage by file, though.

I had something different in mind: just using this coverage as a "grade" and maybe link people to how they can improve it. I don't think that docs.rs should provide such information. After all, it sounds like it's something only the maintainer would be interested in, no?

Well, it's hard to improve it if you don't know what items are missing documentation 😆

it sounds like it's something only the maintainer would be interested in, no?

Sure, but docs.rs is just as much for crate maintainers as it is for end-users. This is the same reason we have the build logs instead of just 'this crate failed to build'.

They can run the doc coverage themselves or even use warnings to see which items aren't documented. I actually don't know how to display such information. Also: it only shows modules, not items themselves. So not sure how useful it would be...

Ok, we can leave it for later if you're not sure how to implement it. I do think it would be nice to have so you don't have to mess around with unstable flags locally.

it only shows modules, not items themselves. So not sure how useful it would be...

Right, this is also a feature request for rustdoc :P I'll open a separate issue so we don't lose the discussion.

Ok, we can leave it for later if you're not sure how to implement it. I do think it would be nice to have so you don't have to mess around with unstable flags locally.

I think it'll take a little while before we can actually know for sure how it should look like and where to put it. I'm not convinced that docs.rs should provide such information directly though but if we want to do it, we'll have to think where to put this information. Maybe a new tab?
Anyway, what remains to be done for this PR?

I fixed the nit and added a TODO. I can take a look at this issue after this PR is merged if you want?

That would be great!

Ok, will do then!

Add tests

Whoops, I forgot about this one. The builds will be hard to test (#822) but you can test the frontend using kuchiki. See https://github.com/rust-lang/docs.rs/blob/master/src/web/mod.rs#L665 for an example - you'll also have to update FakeRelease to include the coverage.

Ok! Thanks for the directions. :)

https://github.com/rust-lang/rustwide/pull/36 will fix the rustwide issue.

Blocked on rustwide publishing a new version.

Pushed two commits to this branch, bumping rustwide to 0.10.0 and removing the macro.

:confetti_ball:

Hey @GuillaumeGomez, thanks for taking the time to add this feature. :)
I was wondering if we could move the Coverage section to a metrics page or something? I'm not sure if it makes sense to display this so prominently in the crate information dropdown. Documentation coverage is a great thing to know, but it doesn't indicate the quality of the crate or even the quality of its documentation. (It has the same downsides as using code coverage as the only metric for how good your tests are.)
I think having access to this information is good for library authors, but we should really find a proper place for it where we can make sure it's as useful as possible. If we have a separate page or tab or something, we can keep adding more things to it to help library authors while avoiding overpopulating the crate information dropdown.
I think it's great that you added it to the Crate tab as well as the dropdown. Maybe we could remove it from the dropdown for the timebeing while we figure out how to best go about displaying this information? :)

Thanks for the feedback @sunjay!
For now, the feature itself is pretty limited, and we agree: in some cases, the doc coverage isn't an important information (pure FFI bindings for examples). However, for everything else, we've been trying in the documentation team to enforce people to document all items by adding lints (missing_docs and missing_doc_code_examples) to help crates' maintainer in this task. Putting this information forward is just the next step and I really think that it's an important information for anyone that is comparing multiple crates. Documentation quantity isn't an insurance for good documentation, but no documentation is also a good factor.
For now it's only about how many items are documented, but I intend to modify this value by also adding more checks like "how much doc comments are actually providing examples". So this is just a first step, and I am curious to see how it'll be used by users. The "hidden" goal being to force people to document more of course. :3

The "hidden" goal being to force people to document more of course. :3

I agree with this goal but not the approach. This feels like negative re-enforcement to me and I think this will have negative impacts on maintainers emotionally when they're being guilt-tripped into adding docs. I'm not sure it should be removed but I think you should tread carefully here and be sure you've considered the emotional impact of this change.

I wanted to add this information in the crate results directly, but for now I think it's too early for that and that we should let maintainers get to know how it works before putting everything in place. For now, I think the display is quite discrete: when browsing through docs.rs, it's "rare" to take a look at those places, which is why we think it's fine for the moment.
The goal isn't to shame anyone for their work. Everyone should be thankful for the incredible work of all rustaceans. We're just trying to help the crate maintainers by giving them tools to improve their crate even more, and to users to help them to have a crate that matches what they need better. Some crates are not meant to be used by "external" users, which is perfectly fine, but in this case, it's "normal" (still think it's a good thing to have documentation in any case, if not others at least for yourself :p) to have less documentation and it's a good indicator that this crate might not be the one you want.
However, once again: we didn't promote this display more specifically because we want to help people understand and adjust to the system. It'll also allow us to provide even more information and tools for both crate's owners and users.

Maybe we could make it less prominent?

@pietroalbini Might be a bit hard to get what it's talking about, no? Not really sure... However, maybe we could move the documentation coverage block under "dependencies" and "versions" blocks. What do you think?

For now, I think the display is quite discrete: when browsing through docs.rs, it's "rare" to take a look at those places, which is why we think it's fine for the moment.

I looked more carefully and you're right, I had mistakenly assumed it was in the sidebar on the landing page for the crate docs when you navigate to something like docs.rs/foo, so things are already not as bad as I'd assumed.

We can add it later on, but for now (and the next months in fact...) it's not scheduled. Next step will be to provide a page to help crates' maintainers to understand how this score is computed.

Might be a bit hard to get what it's talking about, no?

@GuillaumeGomez tried moving it at the bottom and making the text more clear:

But still not keeping what the number is about? :p

I don't think the exact number of items documented is that important. We can make that field a link to the about page though, which already shows the detailed data.

Saying what it is seems quite important from my point of view. But as you prefer...

Opened https://github.com/rust-lang/docs.rs/pull/961 with my proposed change


Issue in implementing Delegate

Issue in implementing Delegate 'ABVideoRangeSliderDelegate'. Not found error is shown when trying to implement the delegate in objective c code.

i have also same issue, i am using swift 4


Trying to use user:glfs with vmware

Hello,
Not sure this is even supported but trying to connect VMware ESX to an iscsi target that uses user:glfs. Just an FYI I was able to mount this volume on a windows 10 system to test but it continues to fail on VMware ESXi (version 5.5 and 6.5). Please let me know of anything else you would want me to collect.
Here is the entry in the targetcli:
| o- user:glfs ............................................................................................. [Storage Objects: 1]
| | o- vol1<EMAIL_ADDRESS>(100.0GiB) activated]
The only output I see on the Linux server side is:
Jul 17 18:14:05 media1 tcmu-runner[15156]: generic_handle_cmd:284 : unknown command 16
and on the ESX server side I see this:
2017-07-17T22:18:36.605Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500b02d00) 0x1a, CmdSN 0x12ad from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.614Z cpu3:66120)NMP: nmp_ThrottleLogForDevice:3546: last error status from device naa.6001405fc65b3e55557495ba9c92bda3 repeated 20 times
2017-07-17T22:18:36.614Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500bd9d80) 0x1a, CmdSN 0x12af from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.615Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500bd9d80) 0x1a, CmdSN 0x12b3 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.753Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500b6af00) 0x1a, CmdSN 0x12b5 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.754Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500b6af00) 0x1a, CmdSN 0x12b9 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.754Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500b6af00) 0x1a, CmdSN 0x12bb from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.756Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500b6af00) 0x1a, CmdSN 0x12bf from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.762Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500b72600) 0x1a, CmdSN 0x12c1 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.763Z cpu3:66120)ScsiDeviceIO: 2962: Cmd(0x439500b72600) 0x1a, CmdSN 0x12c5 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.872Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500b67a80) 0x1a, CmdSN 0x12c7 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.873Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500b67a80) 0x1a, CmdSN 0x12cb from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.905Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bc2700) 0x1a, CmdSN 0x12cd from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.907Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bc2700) 0x1a, CmdSN 0x12d1 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.907Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bc2700) 0x1a, CmdSN 0x12d3 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.908Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bc2700) 0x1a, CmdSN 0x12d7 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.914Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bea780) 0x1a, CmdSN 0x12d9 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:36.915Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bea780) 0x1a, CmdSN 0x12dd from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.066Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500b06c00) 0x1a, CmdSN 0x12df from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.068Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500b06c00) 0x1a, CmdSN 0x12e3 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.068Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500b06c00) 0x1a, CmdSN 0x12e5 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.069Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500b06c00) 0x1a, CmdSN 0x12e9 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.075Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500bb1980) 0x1a, CmdSN 0x12eb from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.076Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500bb1980) 0x1a, CmdSN 0x12ef from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.179Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500bc8c80) 0x1a, CmdSN 0x12f1 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.180Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bc8c80) 0x1a, CmdSN 0x12f5 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.529Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bff780) 0x1a, CmdSN 0x12fa from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.530Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bff780) 0x1a, CmdSN 0x12fe from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.531Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bff780) 0x1a, CmdSN 0x1300 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.532Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bff780) 0x1a, CmdSN 0x1304 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.532Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bff780) 0x1a, CmdSN 0x1306 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.533Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500bff780) 0x1a, CmdSN 0x130a from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.534Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500b2ad80) 0x1a, CmdSN 0x130c from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.535Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500b2ad80) 0x1a, CmdSN 0x1310 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.535Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500b2ad80) 0x1a, CmdSN 0x1312 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.536Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500b2ad80) 0x1a, CmdSN 0x1316 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.536Z cpu0:67775 opID=865547b)World: 12230: VC opID A49E068B-000001BE-4cd2 maps to vmkernel opID 865547b
2017-07-17T22:18:37.536Z cpu0:67775 opID=865547b)LVM: 12525: LVMProbeDevice failed with status "Device does not contain a logical volume".
2017-07-17T22:18:37.537Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500acb780) 0x1a, CmdSN 0x1318 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.538Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500acb780) 0x1a, CmdSN 0x131c from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.538Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500acb780) 0x1a, CmdSN 0x131e from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.539Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500acb780) 0x1a, CmdSN 0x1322 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.539Z cpu2:66120)ScsiDeviceIO: 2962: Cmd(0x439500acb780) 0x16, CmdSN 0x1323 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.539Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500acb780) 0x1a, CmdSN 0x1325 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.540Z cpu0:66120)NMP: nmp_ThrottleLogForDevice:3546: last error status from device naa.6001405fc65b3e55557495ba9c92bda3 repeated 40 times
2017-07-17T22:18:37.540Z cpu0:66120)ScsiDeviceIO: 2962: Cmd(0x439500acb780) 0x1a, CmdSN 0x1329 from world 0 to dev "naa.6001405fc65b3e55557495ba9c92bda3" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0x2 0x8 0x0.
2017-07-17T22:18:37.540Z cpu0:67775 opID=865547b)LVM: 10306: LVMProbeDevice failed on<PHONE_NUMBER>, naa.6001405fc65b3e55557495ba9c92bda3:1): Device does not contain a logical volume
2017-07-17T22:18:37.540Z cpu0:67775 opID=865547b)FSS: 2295: Failed to create FS on dev [naa.6001405fc65b3e55557495ba9c92bda3:1] fs [wef] type [vmfs3] fbSize 1048576 => I/O error

I'm guessing this has more to do with glusterfs and their runner "module" or whatever it is called rather than tcmu-runner itself. If that's the case then just close this out.
thanks,
Mike

Yes, for some handlers this also need the them to do some adapt.
And What's the Kernel version you are using for tcmu-runner ?
" Cmd(0x439500acb780) 0x16, CmdSN"
" Cmd(0x439500acb780) 0x16, CmdSN"
But I see the error logs above as I had encounterd months ago when I first try to use VMWare with rbd and file_example backends, and Byrant's Kernel PGR patch has resolved this.
So you can have a try using the target-pending git kernel repo.
Thanks,

I'm running latest fedora 26:
[root@media1 ~]# uname -a
Linux media1 4.11.9-300.fc26.x86_64 #1 SMP Wed Jul 5 16:21:56 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
would I have to recompile the entire kernel if I pulled the repo you are talking about?

url = https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
commit:
4ec5bf0ea83930b96addf6b78225bf0355459d7f
target/user: PGR Support
[root@wzy-3 target-pending]# git tag --contains 4ec5bf0ea83930b96addf6b78225bf0355459d7f
v4.12-rc1
[root@wzy-3 target-pending]#
So I think you should.

The patch lxbsz pointed will fix the errors you saw.
But, we do not yet support ESX. We are working on it, so there might be other issues you hit.

Yes, there still needs more works to support ESX.

@mikeciccarelli You will prob need to recompile the kernel if you pulled the repo unless you DKMS build LIO, but that can take alot of work too. I'd recommend maybe getting on a kernel that has the patch. For example on Ubuntu Zesty already has it pulled in.

I was using my main server since that is where most of my disk resides. I'm running Fedora 26 on there now and it wouldn't be an easy migration to Ubuntu.
In the past I used fileio for a backstore within gluster and I had some serious slowness issues. This was using glusterfs 3.7. Now in glusterfs 3.10 I'm running fileio and it doesn't seem as bad.. actually have an ok go at it. I just wanted to try user:glfs as I heard it might make it even quicker and cause less server load? Not sure how true that is.
By the sounds of it this might not make it into fedora for awhile so I'll stick with using fileio for now I guess.

@mikeciccarelli
Does it work for you?

What version of vmfs are you guys using that are you seeing it need RESERVE/RELEASE support?
I just tested 6.5 with vmfs 6 and I do not see ESX send those commands, and so it is working ok for me on older kernels.

If I remember correctly, my environments are 6.5 and 5.5 with vmfs 5.

The #108 is my old investigation about this.


Update guide on git branching strategies

Combine content from multiple sources:

Current guide
CodeRefinery lesson: https://coderefinery.github.io/git-branch-design/02-branch-hygiene/
Turing Way Chapter: https://the-turing-way.netlify.app/reproducible-research/vcs/vcs-workflow-branches
Guide for AWE group: https://hackmd.io/@tud-awe/rkQtnzy1C

Should be addressed when:

#169


ARROW-17102: [R] Test fails on test-r-offline-minimal nightly build

@github-actions crossbow submit test-r-offline-minimal

@github-actions crossbow submit test-r-offline-minimal

@github-actions crossbow submit test-r-minimal-build

LGTM, thanks!


Discussion: Examples for mowing automations with this integration

I think it helps all (specialy new users) if we collect and discuss automations (here for mowing control) and rerequisits for those. For irrigation we discuss this here -> #30

Target:
Notification over HomeAssistant Companion App or as Telegram Messenger message or over Amazon Alexa with the help of Alexa Media Player Integration
Why not with the Gardena App:
It is not possible to get Messages from the status of the Gardena Mowers.
It is not possible to get this notifications over Amazon Alexa from the App
** Requirements **

Installed hass-gardena-smart-system integration
Home Assistant Compagnion iOS or Android App
Gardena Mower
(optional) Telegram Messenger Integration
(optional) Alexa Media Player Integration you can find and install this Integration over HACS

Configuration:
to get the activity Statuscode as sensor for the automation trigger you need the activity attribut as seperat template sensor in the configuration.yaml
  - platform: template
    sensors:
      sileno_activity:
        value_template: "{{ states.vacuum.sileno.attributes.activity }}"
        friendly_name: "Sileno Aktivität"

Automation example:
- alias: "Docked with Autotimer"
  trigger:
    platform: state
    entity_id: sensor.sileno_activity
    to: 'PARKED_AUTOTIMER'
  action:
    - service: notify.notify
      data:
        title: "Mower docked"
        message: "Lawn mower was parked due to autotimer"
    - service: notify.telegram_[TELEGRAM_CHANNEL]
      data_template:
        title: '*Mower docked!*'
        message: "Lawn mower was parked due to autotimer -> https://[HA_URL]/lovelace/terrasse"

- alias: "Lawnmower mows"
  trigger:
    platform: state
    entity_id: sensor.sileno_activity
    to: 'OK_CUTTING'
  action:
    - service: notify.notify
      data:
        title: "Mower Status"
        message: "Lawnmower mows"
    - service: notify.telegram_[TELEGRAM_CHANNEL]
      data_template:
        title: '*Mower Status*'
        message: "Lawnmower mows -> https://[HA_URL]/lovelace/terrasse"

- alias: "Lawnmower loads"
  trigger:
    platform: state
    entity_id: sensor.sileno_activity
    to: 'OK_CHARGING'
  action:
    - service: notify.notify
      data:
        title: "Mower Status"
        message: "Lawnmower loads"
    - service: notify.telegram_[TELEGRAM_CHANNEL]
      data_template:
        title: '*Lawnmower loads*'
        message: "Lawnmower loads -> https://[HA_URL]/lovelace/terrasse"

- alias: "Mower Error"
  trigger:
    - platform: state
      entity_id: vacuum.sileno
      to: 'error'
  action:
    - service: notify.notify
      data:
        title: "Mower Fehler"
        message: "Error: {{ states.sensor.sileno_error_status.state }}!"
    - service: notify.telegram_[TELEGRAM_CHANNEL]
      data_template:
        title: '*Mower Error*'
        message: "Error: {{ states.sensor.sileno_error_status.state }}! -> https://[HA_URL]/lovelace/terrasse"

This has been added to a RECIPE.md
Thanks @northpower25


VictorOps: Set state_message and entity_display_name from rule

This change adds all data gathered from ElasticSearch to VictorOps's payload, which then can be used easily with transmogrifier.
If victorops_entity_display_name is not set then entity_display_name is taking value of alert_subject. Or randomized by VictorOps.

It has changed its original behavior and will not be merged unless you modify the test code.

I noticed that. Maybe I'll have a look some other day to correct it.

@nsano-rururu Can you re-run the tests?
I tried to execute them locally with make test and make test-docker but all are passing properly.
642 passed, 4 skipped in 46.04s

Hi @nsano-rururu  I've updated the tests for the new payload content.

Isn't it necessary to modify the document?
https://github.com/jertel/elastalert2/blob/master/docs/source/ruletypes.rst#splunk-on-call-formerly-victorops

You're right. I've added there also information about the default behaviour.

I think I need to add some test code if victorops_entity_display_name is not set

Added it as well now. Sorry, it's 2 AM and I'm working for 18 hours already so my mind is shutting down...

Done. Added as breaking changes, since the subject could change.

@jertel
The review is over. Is there anything else I can point out?

This was added to the Breaking Changes section of the changelog. But is this really a breaking change? For users that have VictorOps in use today, how will upgrading to the next version break their alerts?

Depending on transmogrifier configuration, if it reads alert subject might not trigger notification if the subject was changed.


Add the endpoint /clean to the client.

Description coming soon.

I'll take the /clean and /crawl issue as I already wrote these scripts for my own banks/validators


Maint/70 translate class names and ids to english

Description

Translated code (class names, IDs, comments) to english
Translated constants (e.g. messages) to english
Translated templates to english

Reference
Issues #70

Info: Still have to do formatting here.


question - is there something holding up releasing latest version here?

Spago install gives you 0.4.3 but (i think, maybe i'm making big mistake here) that all the examples and so on are already updated to use the big changes from September ("single index for hook types") and so you can't use those examples as a basis for explorations via the low-effort route of spago install halogen-hooks
Obviously, there are workarounds, but i just thought i'd ask here in case i've either misunderstood or something failed to get published that should have been published.

I intended to release the next version of Hooks along with the related 0.14 updates for the PureScript compiler. That's because the 0.14 version of the compiler doesn't require the weird workarounds with HookNewtype in order to write your hook types and I'd rather not have anyone write those if they can avoid it.
0.14 is right around the corner, and Hooks will be updated alongside Halogen. So I would anticipate a new release of this library soon. In the meantime I'd recommend either adding Hooks as an override to your packages.dhall file or browsing this repository at the 0.4.3 tag.
Sorry about the hassle!

I intended to release the next version of Hooks along with the related 0.14 updates for the PureScript compiler. That's because the 0.14 version of the compiler doesn't require the weird workarounds with HookNewtype in order to write your hook types and I'd rather not have anyone write those if they can avoid it.
0.14 is right around the corner, and Hooks will be updated alongside Halogen. So I would anticipate a new release of this library soon. In the meantime I'd recommend either adding Hooks as an override to your packages.dhall file or browsing this repository at the 0.4.3 tag.
Sorry about the hassle!

that's totally fine with me

that's totally fine with me


set up build environment using Cmake

set up build environment using Came for both building and testing using google test

marking complete after 0bef8fcf56768b6b432836673817e04979670151


chore(deps): :arrow_up: update dependency aws-cdk-lib to ^2.106.1

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

aws-cdk-lib
^2.106.0 -> ^2.106.1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm WARN cli npm v10.2.3 does not support Node.js v20.2.0. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-11-14T06_56_04_488Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-11-14T06_56_04_488Z-debug-0.log


Added Eway_Direct to readme

:+1:

@kayladnls Could you please tag the current version 2.2.0 - thank you :+1:


Rubocop --- don't merge until tests pass.

All the rubocop cops pass.
But not all the feature specs pass.
Some of the specs fail because it seems that the @current_organization variable is getting unset (the Organization records are all getting blown away). This doesn't apply to all the features, just some of them. I spelunked a bit and was only able to verify that indeed the Organization.all comes up empty, as does StorageLocation.all. The test.log did not indicate that any data was getting dusted in the process.
I'm at a loss, and it's very late.
One major change that I had to make to appease RuboCop was that the iVar @organization had to be changed to @current_organization. I used sed and I believe I got it in all the places. I did a git diff --changed | grep organization to verify that they were indeed changed.
I also had to add dependent: :destroy to pretty much all the associations. It's possible that's affecting things, but DatabaseCleaner is supposed to be wiping the DB in between tests ANYWAYS, so shrug

i paired with my co-worker this morning and still no luck, but i'm not giving up on it, just wanted to let you guys know i'm still working on this - thanks.  :)

worked on this again, it's definitely a database cleaner issue.  we resolved the issue by putting
  config.before(:each, js: true) do
    DatabaseCleaner.strategy = :deletion
  end

in the rails_helper file; however, we're getting the same Poltergeist issue that i mentioned above.  will keep trying.

Closing to use the incremental solution.

This is being superseded by the "ratcheting" rubocop approach. A bunch of bugfixes have been extracted from this PR already.


Item Stats plugin has incorrect magic attack for Bloodbark Legs

Type
Incorrect behavior
Operating System
Windows
OS Version
Windows 11
Bug description
Item Stats plugin is showing bloodbark legs as having +13 magic attack, when they have +16 as of June 21.
Screenshots or videos
SS from wiki of June 21 patch changes:

SS from in-game with incorrect value from Item Stats plugin on hover

RuneLite version
Runelite Version 1.10.5
Oldschool version: Rev 214
Launcher Version: 2.4.5
Logs
No response

It looks like the wiki scraper had broken, it is fixed now.