Update httpclient dependency

Is there any traction on this PR? I would love to be able to use a new Apache HTTP Client.

I think the failure is a problem with a test (and not this code) that was doing I/O that ideally shouldn't. I already have a change that improves the test. Once I get it merged in I'll re-run Travis and see if it fixes the tests for this PR.

It looks like this code will work just fine with the old version. I may want to keep the HttpClient version at 4.0.1 and just update the code to support 4.5.1. There are some other users of this library that seem to be on old version of the library and I think they may need to be updated to support the newer version as well.
Supporting both 4.0.1 and 4.5.1 looks pretty easy and would help those other users.

Is there anything that I can do to help move this forward?

@dekobon, you could look into the failing ApacheHttpTransportTest.testRequestsWithContent(). I'm actually confused on how it worked before.

I dug pretty deeply into this. It turns out that the com.google.api.client.testing.http.apache.MockHttpClient is quite an insufficient implementation of a mocking layer for Apache Http Client. It attempts to allow for the internal mechanism of the DefaultHttpClient call stack to be executed without actually calling out to the network.
This causes problems because internal implementation has changed since version 4.1 and there are methods that are part of the underlying implementation that are being called now.
A much better mock would be an interface mock of org.apache.http.client.HttpClient. However, even that interface was deprecated in 4.0 of the Apache HTTP Client. That said, it is still API compatible, so it may be viable for the time being until we can get most of the consumers of this library bumped up to version 4.5. Once we have reached that point, we should rip out the deprecated calls and do things the new way.
I can submit a new PR with suggested changes. However, I'm unsure about the etiquette for this particular project.

Done.

On 18 Nov 2015, at 09:38, googlebot<EMAIL_ADDRESS>wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.
—
Reply to this email directly or view it on GitHub.

It looks like the Travis failure is noticing the mock going away. It seems it is safe to override it. I'll have to look into that.

@ejona86 Could you take a look at overriding the failed travis check?

Any update on this?

Who's CLA is failing now? It shouldn't be me.

@dekobon It should not be me.

It looks like you've already signed this CLA.

@googlebot Reply here to confirm.

Looking at the commit history, I don't see any committers other than dekobon and dkocher. Is the googlebot confused?

Confirm.

On 07 Mar 2016, at 21:01, googlebot<EMAIL_ADDRESS>wrote:
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.
—
Reply to this email directly or view it on GitHub.

@ejona86 Anything required on our side?

@dkocher, no nothing more required from your side. The change has implications on my side and I've not had time to address them.

@ejona86 Ping.

Hi,
Can you tell if this will be merged (or support for httpclient-4.5.X) be added in the foreseeable future?
There's a dependency clash with httpasyncclient-4.1.2 (requires httpclient-4.5.2). Even the lowest available in mvncentral (4.0) requires httpclient-4.3.1 which is incompatible (throws UnsupportedOperationException on InternalHttpClient.getParams (https://github.com/google/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java#L129)
Thanks
--Gilles

@gilles I override my Apache HTTP Client dependency version with 4.5.2 manually in Maven with no ill effects. However, there are some serious improvements to the codebase in the newer classes using in the 4.5.x library that would be very advantageous to use. Not to mention all of the nasty deprecation warnings that end up all over your code.
In fact, I wonder if we could just make a new transport layer that uses the latest features of Apache 4.5.x and call it something like Apache45HttpTransport. This may accommodate the legacy support needs that have been blocking @ejona86.

If I override the dependency I run into https://github.com/google/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java#L129 throwing UnsupportedOperationException. But only if I create the client using HttpClientBuilder and then inject it (it creates an instance of InternalHttpClient)
If you use the default provided by google it works because it creates an instance of DefaultHttpClient which is deprecated.
A new HttpTransport would probably work. I'll try that.

@ejona86 Ping.

Any chance this would get some love?

@ejona86 it looks like you were looking at this and had context on it.

@garrettjonesgoogle, I've not looked at the mock changes to figure out how to fix the failures. The Mock is public API, so I'd have needed to check internally how rampant usage was, because existing usages would need to be updated.

according to owasp dependency checks there are also some CVEs related to 4.0.1
httpclient-4.0.1.jar (cpe:/a:apache:httpclient:4.0.1, org.apache.httpcomponents:httpclient:4.0.1) : CVE-2015-5262, CVE-2014-3577, CVE-2011-1498

@vam-google could you take a look?

Any chance this would get (finally) some love?

FYI: continued at https://github.com/google/google-http-java-client/pull/377

Please reopen this. The crucial changes in https://github.com/google/google-http-java-client/pull/306/files#diff-49e1fb3250d450c22d6683f3aef021ddL129 are still not applied. Very tiresome contribution process here. The current dev branch will throw an exception in
java.lang.UnsupportedOperationException 	at org.apache.http.impl.client.InternalHttpClient.getParams(InternalHttpClient.java:211) 	at com.google.api.client.http.apache.ApacheHttpTransport.<init>(ApacheHttpTransport.java:126)


Cannot get feedback from QLAB.

Cannot get any feedback from Q-Lab. In companion, TCP is checked. In Q-Lab, OSC is set. I can send any commands from companion to qlab without any issue. Just cannot get any feedback. In connection, got ERROR instead of OK as soon as I enable TCP. Tried with Local IP, WIFI and Ethernet. Any ideas?

What is in the log? Make sure all filters are off to see everything.
Hover over the 'ERROR' box, you should see a pop-up with more details.

Looping in @Julusian.
The QLab module has no OSC10 element so this error is coming from another module.
The only module that has OSC10 is the EOS module, which needs to handle this error.

Just FYI, I do have the ETC-EOS module installed. Connection show as OK. And didn't had any issue with it..
Guys, thanks again for your help! :)

I do not use the EOS module so it hasn't been an issue.
There seems to be some variable overlap with some cross-module interaction that should not occur.
It is probably on the QLab side so I'll look into this soon.

No, I think it’s on the EOS side because they modify the osc module that’s imported, which shouldn’t occur globally but definitely seems to be @SteveTherrien

Thanks for the ping. A quick skim looks like etc-eos is patching the osc lib, but they are directly modifying the imported osc object mensing their changes will be leaking into any other usage of osc.
I'll look into it more in the morning

I think I've found the bug in the etc-eos modification of osc that is causing this. It looks like originalPacketRedirected was changed to originalReadPacket at some point, but one reference was missed.
Please try the latest beta build, I have fixed this typo there. Hopefully that will fix things well enough for now.
I have raised a PR to avoid leaking the modified osc lib, but I need that to be tested before merging, as it is likely to easily break etc-eos if I did something wrong https://github.com/bitfocus/companion-module-etc-eos/pull/15

Hi @Julusian Thanks so much for the quick fix, so appreaciated!
Unfortunately, I am not sure where to put the new file. I am using the MAC (Intel) version of companion, witch normaly have a install package, so I am not sure where to put the individual files. I looked into the app content, made a search for index.js but could'nt find it. Where can I find more info on instaling that version for mac?
Thanks! :)

This was fixed, Closing.


showPaymentViewController not showing payment method selection options

I have manage to show the drop in payment form using showPaymentViewController and successfully made payment in sandbox.
However, I am not sure why the "Select Payment Method" dialog is not shown. This library is using drop in UI as in https://developers.braintreepayments.com/start/hello-client/ios/v4 right? I integrated it natively in Android and able to see the "Select Payment Method" dialog correctly. However in react native using this library, the payment UI looks different and there's no "Select Payment Method" dialog.
Am I missing something here? showPaymentViewController is implemented using drop in UI, BTDropInViewController right? I tried to check in Android version, but cant find how showPaymentViewController is implemented. There is only a "paymentRequest" method there. I can't understand how react native call and show drop in UI here.
Thanks

Ok. I figure out that it's using the older version of drop in UI. Upgraded myself and it's showing up now.

@darren1982 can you please explain or PR on how you upgraded the version of the UI


Support changing Service resource type with "kubectl set"

What would you like to be added:
Implement the ability for the kubectl set command to change the type of a Kubernetes v1\Service resource.
kubectl set service argocd-server --type LoadBalancer

Why is this needed:
At the moment, the process for changing the type of a Service resource is confusing for newcomers, as you have to resort to using the kubectl patch command and pass in some specific JSON text that's hard to remember.
kubectl patch svc argocd-server -n argocd -p '{"spec": {"type": "LoadBalancer"}}'

Set is an imperative command and we want to avoid expanding it in this way. We recommend using apply.
We would consider a generic solution but deeply setting values akin to kubectl config set.
/triage unresolved


Pages should say indicate that Apache OpenWhisk is incubating

As raised on the mailing list: http://mail-archives.apache.org/mod_mbox/incubator-openwhisk-dev/201612.mbox/browser

Bertrand Delacretaz wrote

Hi,
Unless I missed something, I don't see any mention of incubation
status at http://openwhisk.org/
That website should say "Apache OpenWhisk (incubating)", at least once
in a visible place on every page - ideally in the page header or
footer and also in the main titles of the the homepage and
http://openwhisk.org/about, IMO.
The incubation disclaimer, below, is also required.
http://incubator.apache.org/guides/branding.html has more details, the
goal is to avoid any confusion as to the incubating status of
OpenWhisk.
Can someone fix this soon?
-Bertrand
The disclaimer is:
Disclaimer: Apache OpenWhisk is an effort undergoing incubation at The
Apache Software Foundation (ASF), sponsored by the Apache Incubator.
Incubation is required of all newly accepted projects until a further
review indicates that the infrastructure, communications, and decision
making process have stabilized in a manner consistent with other
successful ASF projects. While incubation status is not necessarily a
reflection of the completeness or stability of the code, it does
indicate that the project has yet to be fully endorsed by the ASF.


ListView content visible outside of ListView

Details
If you set ListTile -> selected to true and set selectedTileColor, this will be visible outside the list on any transparent Wiget. Same applies to the highlight/splash effect on Inkwell Items inside ListView - the aren't cut at the border of the Listview.
Tested under Win 11, Web and Desktop app.
Actual result
The background color of the selected ListTiles/Inkwell is visible outside of my ListView. Same applies with a Inkwell highlight on hover/splash effect.
Expected result
No element of the list should ever be visible outside the list.
Assets

Image showing the problem

minimal Source code
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        children: [
          Container(
              height: 150,
              child: Center(
                child: Text(
                    'Container without color ->listtile background visible!'),
              )),
          Container(
              color: Colors.green,
              height: 150,
              child: const Center(
                child: Text(
                    'Container with color ->no listtile background visible'),
              )),
          Expanded(
            child: ListView.builder(
              itemCount: 100,
              itemBuilder: (context, index) {
                return ListTile(
                  title: Text('Item nr. $index'),
                  selected: index % 2 > 0 ? true : false,
                  selectedTileColor: Colors.red,
                );
              },
            ),
          )
        ],
      ),
    );
  }
}

Flutter doctor -v
[√] Flutter (Channel stable, 2.10.2, on Microsoft Windows [Version 10.0.22000.493], locale de-CH)
    • Flutter version 2.10.2 at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 097d3313d8 (10 days ago), 2022-02-18 19:33:08 -0600
    • Engine revision a83ed0e5e3
    • Dart version 2.16.1
    • DevTools version 2.9.2

[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at C:\Users\Martin\AppData\Local\Android\sdk
    • Platform android-32, build-tools 32.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.0.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.0.32112.339
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[√] VS Code (version 1.64.2)
    • VS Code at C:\Users\Martin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.34.0

[√] Connected device (4 available)
    • BLA L29 (mobile)  • AQH7N18927003547 • android-arm64  • Android 10 (API 29)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.22000.493]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 98.0.4758.102
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 98.0.1108.62

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

See https://github.com/flutter/flutter/issues/86584
Try wrapping the ListView in a Material widget.

Closing as duplicate of #86584

Thanks @jason-simmons  & @maheshmnj -> Wrapping my Listview inside Material() widget solved both problems. I really appreciate your support :)


Enable multiline directive options

directive options are basically field lists:
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#directives 'Directive options are indicated using field lists; the field names and contents are directive-specific.'
Field list options can have multiple lines:
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#field-lists

Thanks this is great!


ceylon promise fails with 50 or more Conjunctions

This program:
shared void promiseTest() {
    variable Completion<Integer, Integer[]>? completion = null;
    for (i in 0:51) {
        value deferred = Deferred<Integer>();
        completion = if (exists c = completion)
                then c.and(deferred.promise)
                else deferred.promise;
        //completion?.completed((Integer *xs) => print("done"));
        deferred.fulfill(0);
    }
    completion?.completed((Integer *xs) => print("done"));
}

produces no output.
Lowering the iteration count to 50 causes done to be printed immediately. (The program doesn't exit for a while though. Is that normal?)
Uncommenting the commented line results in a runtime type error (with 51):
...
done
done
done
ceylon run: possible undecidability: typechecker detected possible
nontermination and aborted algorithm
com.redhat.ceylon.model.typechecker.model.DecidabilityException: possible undecidability: typechecker detected possible nontermination and aborted algorithm
	at com.redhat.ceylon.model.typechecker.model.Type.checkDepth(Type.java:1653)
	at com.redhat.ceylon.model.typechecker.model.Type.isExactlyInternal(Type.java:178)
	at com.redhat.ceylon.model.typechecker.model.Type.isExactlyTuple(Type.java:452)
	at com.redhat.ceylon.model.typechecker.model.Type.isExactlyInternal(Type.java:337)
	at com.redhat.ceylon.model.typechecker.model.Type.isExactlyInternal(Type.java:208)
	at com.redhat.ceylon.model.typechecker.model.Type.isExactlyTuple(Type.java:462)
	at com.redhat.ceylon.model.typechecker.model.Type.isExactlyInternal(Type.java:337)
...

This sounds like @vietj is using tuples of size proportional to the number of promises? Surely that's wrong.

nobody's going to write such code in real life :-)

it could be resolved by adding an and() function that takes an arbitrary number of promise and returns a single promise. typesafety would be lost though.

Well I would say that this is probably a bug in ceylon-model. We're supposed to have hardened our algorithms to handle long tuple types.

nobody's going to write such code in real life :-)

Why not? What's the maximum reasonable number of parallelizable tasks per processing stage? No doubt, it does seem awkward to do this with and(), but this came up in real code.

A secondary problem is the this fails silently without an attempt to call completion?.completed() on exactly the fiftieth iteration. Or, at least I wasn't able to coax an error out if it.

@jvasileff please open an issue against ceylon-model, with as much of a stack trace as you can get hold of.

OK, I've investigated this, and I think it should slip to 1.3.


How to import contents and data into my mdx documents

Is there a way to directly import components in the mdx files ? Could not find anything related in the docs but looking at issue #266 it seems like import statements are supported. Unfortunately, I haven't been able to get this working. Please see below for more info about the error and what works.
The Error
when importing a component in a markdown file like index.mdx, it throws an error - unexpected "<"
For example the import statement as below:
import { Button } from "../components/Button"

gives the following error:
 > ../../templates/default/components/Button.js:14:4: error: Unexpected "<"
    14 │     <Link href={href}>
       ╵     ^

Error: Found 1 problems in 1 documents.

 └── Encountered unexpected errors while processing of 1 documents. This is possibly a bug in Contentlayer. Please open an issue.

     • "index.md": UnexpectedMDXError: Error: Build failed with 1 error:
     ../../templates/default/components/Button.js:14:4: error: Unexpected "<"

SourceFetchDataError: {
  "_tag": "HandledFetchDataError"
}

But this works
If the return statement of the component is a string, then it renders without any errors.
for example if the following is the component:
export function Button () {
  return "This is a button component"
}

and we import it in md like below:

Thanks for opening this issue. Can you please provide a reproduction repo with instructions how to reproduce the problem you're experiencing? Thank you!

Hey @schickling Thanks for the reply.
Project repo
The repo can be found here - https://github.com/flowershow/flowershow
This repo has a template folder templates/default which is a Nextjs project and it is where contentlayer is setup.
It can be run by doing the following:
cd templates/default
npm install
npm run dev

Within templates/default is the content folder which is the contentDirPath in contentlayer.config.js.
Also note that the content directory is symlinked to site/content which lives at the root of the project.
Related to our issue
I have setup test pages and test components that include a working component and another one that reproduces the error.
Pages
There are two test pages which can be found at:

templates/default/content/test/page-1.md

This is a page with a working component <Test />

templates/default/content/test/page-2.md

This is a page with the error component <Button></Button>
Note that I have commented this out as all the pages fail to build. After doing npm run dev you can uncomment them and see the error reproduced.

Components
The components can be found at templates/default/components/ directory. There are two test components I have created to reproduce the error which are as follows:

Test.js This is the component that works when imported in page-1.md
Button.js This is the component that throws the error when imported in page-2.md. The button component basically is a Nextjs <Link> component but I have tried with other elements as well eg. <div>.

Thanks again for looking into this and appreciate your help!

Thanks for the further information @khalilcodes. I've taken a brief look but couldn't yet identify the problem. I suspect this to be rather a problem in your project than a problem with Contentlayer. As a first step I'd suggest using the .tsx or .jsx extension for JSX files - this might otherwise confuse various parts of the stack.
Also feel free to join the Contentlayer discord where some community members might be able to help you.

As a first step I'd suggest using the .tsx or .jsx extension for JSX files - this might otherwise confuse various parts of the stack.

Thank you so much for your help, @schickling 🌻! We've changed .js files to .jsx (with @khalilcodes) and it worked 🎊!


Create an automatic release when a tag is created

Provide an own Github workflow that does create a Release when a tag is created.

own workflow
build on Unix (since the code  is Java the platform is not really important)
upload the shaded jar

That one looks promising: https://github.com/softprops/action-gh-release


Adding the gerbil package

This package is cursed.... CI is again stuck in some infinite loop, I have no idea what to do about it.

Is there any way to see the results of the CI? Is it possible for me to run any of the checks manually? It is a hybrid package (binary + library), I'm not sure if that would have anything to do with it.

Is there any way to see the results of the CI?

There would be a way, if CI had finished its job.

It is a hybrid package (binary + library), I'm not sure if that would have anything to do with it.

I doubt.

Now when we're out of reasonable solutions, I would try some desperate moves: try to insert your package at some other place in packages.json, and put more tags.

I've opened https://github.com/nim-lang/packages/pull/1523 to see if maybe I'll have more luck.

Wooohooo, gerbil is finally merged! :)

Thank you for doing that!!


Crash importing a specific playlist

I imported all of my playlists fine, however this one generates an error.
https://open.spotify.com/playlist/37i9dQZF1DWVY4eLfA3XFQ
I simply ran: python3 YouTube.py https://open.spotify.com/playlist/37i9dQZF1DWVY4eLfA3XFQ
Traceback (most recent call last):
  File "YouTube.py", line 190, in <module>
    main()
  File "YouTube.py", line 182, in main
    videoIds = ytmusic.search_songs(playlist['tracks'])
  File "YouTube.py", line 70, in search_songs
    result = self.api.search(query)
  File "/home/cappyt/.local/lib/python3.8/site-packages/ytmusicapi/mixins/browsing.py", line 179, in search
    search_results.extend(self.parser.parse_search_results(results, type, category))
  File "/home/cappyt/.local/lib/python3.8/site-packages/ytmusicapi/helpers.py", line 126, in _impl
    return method(self, *method_args, **method_kwargs)
  File "/home/cappyt/.local/lib/python3.8/site-packages/ytmusicapi/parsers/browsing.py", line 39, in parse_search_results
    parse_menu_playlists(data, search_result)
  File "/home/cappyt/.local/lib/python3.8/site-packages/ytmusicapi/parsers/utils.py", line 5, in parse_menu_playlists
    watch_menu = find_objects_by_key(nav(data, MENU_ITEMS), 'menuNavigationItemRenderer')
  File "/home/cappyt/.local/lib/python3.8/site-packages/ytmusicapi/parsers/utils.py", line 155, in nav
    raise err
  File "/home/cappyt/.local/lib/python3.8/site-packages/ytmusicapi/parsers/utils.py", line 149, in nav
    root = root[k]
KeyError: 'menu'

Hope this helps.

Are you using an old version of ytmusicapi? Make sure your dependencies are up to date. It's working fine for me.
https://music.youtube.com/playlist?list=PL528pVfw3ao1z-U8b17y4PoTB1caMTHIW

pip install -U -r requirements


Not getting falure response if mail failed to sent

Hi,
I am able to send mail if email ID is correct but I am NOT getting any error message in case email id is wrong.
Can you please advice?
Thanks,
Shripad

Hi, Shripad,
Can you, please, provide code example?

Hi Alexander,
Thanks for quick reply.
I used same example code given by you:
var send = require('gmail-send')({
user: credentials.user,           // Your GMail account used to send emails
pass: credentials.pass,           // Application-specific password
to:   credentials.user,           // Send to yourself
subject: 'ping',
text:    'gmail-send example 2'   // Plain text
})();
My question is, in case if TO_ADDRESS is wrong, is it possible to get failure delivery message.
Please correct if I am wrong.
Thanks,
Shripad

Google does not check recipient address when accepting the email through SMTP protocol (I think,same for other servers)
It accepts email, assigns id and returns id back to the application, then tries to deliver.
If it can't deliver, it sends error notification in form of 'unable to deliver' email to the sender.
So, if you need to know if the message was not delivered, the only way is to wait for this message.
However, delay for this message may be long enough (for example, if remote server does not responds).

Hi Alex,
Yes. Agree. Thank you for your reply.

The error callback is not triggering for me when failing to connect to Gmail (firewall issues).


Can't install the tensorflow version

Hello, I know it's still in alpha, but I tried to install the tensorflow version as per instructions
and I got the following error after running the pip install:
error: package directory 'deeplift/backend' does not exist
And yes, I don't see the "backend" folder, though it is used by util.py

Hi, thanks a lot for flagging this. I just pushed a fix removed the reference to deeplift.backend from setup.py and from util.py. I also updated the code to work with tensorflow 1.0.1. I ran the unit tests and they passed except for minor numerical inaccuracy in the batchnorm case (results are within E-3 instead of E-5). This may be due to a change in the batchnorm implementation between 0.12rc and 1.0.1. Let me know if this E-2 discrepancy is a problem for you and if so, I can look into it. And please do let me know if you run into any other issues!


fix(common): GetServiceUserValidateFunc

About this change—what it does

fixes GetServiceUserValidateFunc

Why this way

it didn't match the error message it threw

Could you please provide any tests for those changes?

Could you please provide any tests for those changes?

there are tests, the unit tests and the acceptance tests


Typo

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ea19ca3-9587-e7d0-2b47-5255911eeffc
Version Independent ID: 50fa187c-94cb-6c82-e2ff-193dd0f0f762
Content: Embed Power BI report in a Power BI embedded analytics application for your customers - Power BI
Content Source: powerbi-docs/developer/embedded/embed-customer-app.md
Service: powerbi
Sub-service: powerbi-developer
GitHub Login: @mberdugo
Microsoft Alias: monaberdugo

Thanks for pointing out this typo, @ChessGeekBoy . I fixed it and it should be published in the next day or so.


Feature/oasim

Description
Add initial code to develop. (I take zero credit for doing this!)
Required by:

https://github.com/JCSDA-internal/ufo/pull/2339
https://github.com/JCSDA-internal/ufo-bundle/pull/83

Dependencies
None: can be merged at any time, does not require coordination.
Testing
when built as part of the ufo-bundle, the ctest oasim_test passes (with the below mentioned uncommitted change added)

@danholdaway, There is one bug fix to get the ctest to work. I don't have write permission on this repo so I can't push it. (and I can't request reviewers either :man_shrugging: )

@travissluka I just made you an admin


debuginfo: Remove retry limit

Why?
There are two major fixes in this PR:

The Parca server sometimes restarts; if we don't ask the server constantly, we miss debuginfo files. Therefore, I'm removing the retry limit, and we will ask the server always if it has the necessary debuginfo.

Avoid any possible race conditions while reading the object files.
Fixes https://github.com/parca-dev/parca-agent/issues/1614

How?

🤖 Generated by Copilot at a62d7f9

Add a new flag --debuginfo-upload-max-parallel to control the maximum number of parallel uploads of debuginfo files (link,link,link,link,link,link)
Refactor the DebuginfoManager interface and the Manager type to return the debuginfo object file instead of modifying the source object file, and to remove the retry logic and use a singleflight mechanism instead (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)
Refactor the ObjectFile type to hide the underlying file descriptor and elf file, and to provide methods for concurrent access to the file with proper locking (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)
Add a new type SeekReaderAt that combines the io.ReaderAt and io.Seeker interfaces, and modify the Extract function to take a SeekReaderAt instead of an *os.File as the source parameter (link,link,link)
Modify the readDebuglink function to take an *elf.File instead of an *os.File as the parameter, and use the cached value if available (link,link,link,link,link,link)
Modify the Mapping type to rename the open method to init, and to call the computeKernelOffset method from the openObjFile method (link,link,link)
Add a new field debuginfoSrcCache to the InfoManager type, to cache the debuginfo object files by their build IDs (link,link,link)
Modify the type of the mtx field of the Manager type in the pkg/discovery package to be a pointer to a sync.RWMutex instead of a value (link,link)
Remove the noopDebuginfoManager type and its methods, as they are no longer needed (link)
Remove the import of the github.com/cenkalti/backoff package, as it is no longer used (link)
Add tests for the Upload method of the Manager type in the pkg/debuginfo package (link,link,link)
Modify the error message and the panic message in the readDebuglink function and the pkg/objectfile/pool.go file to include the type of the unexpected value in the cache (link,link)
Modify the condition to check for a successful status code in the uploadViaHTTP function to allow any 2xx status code instead of only 200 (link)
Update the documentation of the --debuginfo-upload-max-parallel flag in the README.md file (link)

Test Plan
Relevant tests are added.

make test
Run scripts/local-run.sh
Run make dev/up

🤖 Generated by Copilot at 07d7cda

Debuginfo manager
Simplifies and improves code
No more backoff

I will handle  https://github.com/parca-dev/parca-agent/issues/1617 in another PR

There's a race detected. I trying to understand if it's the actual code or the tests I have added.

Also, this has been running since yesterday without a crash. That being said, I will still continue to improve with subsequent PRs.


A suggestion about finding useless repositories and deleting them

From swagger.yaml, I find GET /repositories/top API to get public repositories which are accessed most.
And I need such a feature that getting public repositories which are accessed least. So I can delete them manually at least.
Maybe LRU strategy is OK for me too.
tks in advance.

The same requirement with #4209, let's use that one to track the requirement.
Close this one.


404 on link

Welcome! Please use this template for reporting documentation issues on https://developers.google.com/web/.
For questions about Chrome DevTools, checkout the
google-chrome-devtools tag on StackOverflow.
For questions about Chrome, check the google-chrome
tag. If you think you've found a Chrome bug, check out our
feedback page for more details on how to file it.
Page Affected: https://developers.google.com/web/TODO
What needs to be done?
Please provide description of what's needs to be done here. Please be sure to include the link to the original page
and any supporting links/data.
This link is broken (it lands on a 404 page):

[ ] Appropriate type-something label has been added.
[ ] Appropriate section-something label has been added.

https://developers.google.com/web/TODO is an invalid link

Currently, the link url is: https://developers.google.com/web/fundamentals/payments/basics/payments/basics/how-payment-request-api-works

We can close this issue, it is fixed.
Thanks


Editor history cleared when state change from outside editor.

Updating the code in the editor by updating the variable the code is stored in clears the editor history (no ctrl+z :cry: ).
https://codesandbox.io/s/interesting-sky-6nvrv?fontsize=14&hidenavigation=1&theme=dark

I am interested as a co-maintainer.

@sukrut-gs - happy to help see this through if you have a PR or any ideas here? Offhand I wonder if this might help based on the description https://github.com/scniro/react-codemirror2/pull/146
fyi I have the same issue where I'm using the Controlled component and undo doesn't "work"

I have a suspicion that what's missing is the performance of an "operation" in codemirror speak, ala
cm.operation(function () {
        cm.replaceRange(out, from, to);
    });

yup, just tested this - in your paste handler if instead of calling setValue or whatnot you instead compute the values for cm.replaceRange and call that it works as intended (and automatically calls onBeforeChange for you thereby hitting your setValue call


Inserts extra characters in Escape.

I have been seeing this issue recently where when I escape from insert mode to normal mode, the cursor will add extra characters to the end and sometimes the beginning of a line. It doesn't happen all the time, but often enough that I have tried to see if anyone knows of a fix. Here is a screenshot of what it looks like:

I am currently using the latest neovim nightly (as of a few minutes ago) and v0.0.78 of the vscode plugin. If anyone has any tips how this might be solved, I would greatly appreciate it.

Same here with:
v0.0.78

and
NVIM v0.5.0-dev+1211-g6db3ba9df
Build type: Release
LuaJIT 2.1.0-beta3

seems like it happens mostly by hitting escape after typing special chars though
< >  " "  ' '  { } ()

just discovered that this issue happens only with v0.0.78
previous versions are working fine
@asvetliakov

I can confirm this issue with:
Neo Vim: v0.0.081

and
NVIM v0.5.0-dev+1055-g8950f4e94
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

If I were to guess, it has something to do with VSCode and Neo Vim fighting over auto-closing characters. While the characters noted by @nrdlab seem to be a consistent way to cause the issue, I have had the issue happen with other characters, including new lines and deletions, in no repeatable manner.
It is incredibly annoying and makes the extension borderline unusable.

I cannot reproduce this issue.

did you try with empty init.vim
do you have any vim auto-closing plugins
what is your editor.autoClosingQuotes setting?
do you have any vscode auto-closing extensions

@theol0403 I tried everything I could think of to isolate the issue with no success. Including:

Disabling all other extensions
Disabling init.vim and deleting (temporarily renaming) my entire ~\AppData\Local\nvim\ folder
Removing default VS Code settings / keybindings
Disabling all VS Code editor closing settings

My VSCode settings currently look like this:
{
    "vscode-neovim.neovimExecutablePaths.win32": "C:\\tools\\neovim\\Neovim\\bin\\nvim.exe",
    "editor.autoClosingBrackets": "never",
    "editor.autoClosingDelete": "never",
    "editor.autoSurround": "never",
    "editor.autoClosingOvertype": "never"
}

I can then open a plain text file, enter insert mode, and type:
test()

But after hitting escape, I get:
test()test()

Unless I hit u (undo), at which point, it goes back to how I typed it. If editor.autoClosingBrackets is enabled, the extra test() is placed inside the parentheses.
One thing of note is that although I have experienced all of the characters that @nrdlab noted, I only got the issue with:
( ) [ ] { }

It could be a bug with an older version of Neovim. I am currently running on the latest pre-release version installed via Chocolatey, but I know there are more recent versions that have just seemed a bit more intimidating to install.

@Antyos Thanks for the detailed report. I have no idea what is wrong, I can only suggest trying a newer version of neovim.
Have you by chance tried to build the extension yourself? It's possible that a patch you made which differs from the officially released version causes the issue? One mistake that is easy to make is that vscode uses a cached version of the plugin even if you uninstall it - uninstalling and then installing from the marketplace will still use your local build of the same version number.

I have more information to add to the weirdness that is this issue:

I run VS Code on a laptop with a docking station. When undocked, I cannot repeat the issue. When docked (using another keyboard and mouse), I always get the issue.
I updated to nvim v0.5.0-dev+1429-gb585f723b (most recent as of an hour ago). This did not fix the issue.
Since updating my installation of nvim, the issue cannot be repeated on files that have never been saved, i.e. doing a ctrl+n to open a new blank file
About 1 out of 5 times when typing test() or foo() in a file, I don't get the issue. This is more frequent if it is the first thing I type when switching to a file, but not always.
The issue does not occur when recording a macro. I also noticed that the parentheses did not auto-close either, but I already noted that editor.autoClosingBrackets isn't the issue.
I thought it might have something to do with the suggestions box popping up. I set editor.quickSuggestionsDelay to a really large number to avoid the popup, but it didn't help. That doesn't mean the suggestions aren't related, but it doesn't mean the are either.

I have not had a chance to build the extension myself, but I may try that if I get a chance tomorrow.
Something also worth noting, I have never had this issue when using Neovim on its own (via a terminal); only when using it through VS Code.

I recently had to reinstall Windows on my computer (which has become all too common for me). When I put VSCode and NeoVim back on my computer, I found that I was no longer experiencing this issue!
While I don't suggest reimaging your computer for this reason, it may be worth uninstalling the extension (and making sure the extension files are really gone under %userprofile%\.vscode\extensions\, and reinstalling the extension. I feel a bit dumb for not thinking of trying that earlier.

I think this is a conflict between any extensions neovim has included and VSCode autocomplete/suggestion behavior. I seem to have noticed less of this behavior when I disable more of VSCode's auto closing stuff, but it still doesn't completely fix it. It seemed to happen for me without fail with more complex syntaxes like Vue, which has JS/TS, CSS, and XML all in one file.
But, disabling pretty much all plugins, syntaxes, everything in Neovim and being careful about what I enable, as well as upgrading to neovim 0.6.0 seems to have fixed the problem, even in the more complex Vue files. It could also be worth making sure that if you use Neovim with Python enabled, you're only using Python3, and have the latest of everything else. Really seems to be an issue where neovim gets a little slow and causes conflicts, not as much of a problem with the VSCode plugin itself (reinstalling that didn't help for me).

Closing as I still can't reproduce.

Same issue with Neovim v0.10.1, vscode-neovim v1.18.9, vscode v1.92.2， ubuntu v20.04.2. When I input (, ), [, ], {, } before switching to normal mode, what I entered in insert mode will be repeated.

Same issue with Neovim v0.10.1, vscode-neovim v1.18.9, vscode v1.92.2， ubuntu v20.04.2. When I input (, ), [, ], {, } before switching to normal mode, what I entered in insert mode will be repeated.

@LawrenceLiu023 With vscode-neovim.neovimClean enabled?

I am facing this same issue on version 1.18.13. It has made the plugin unusable. I tried everything suggested in the discussion here but was still unable to resolve it. I'm on Ubuntu 22.04.5, nvim v0.11.0-dev-965+gfb74fd295  and vscode 1.94.2. Tried downgrading versions and removing other plugins, init.vim etc... the problem still persists. I can provide any further info for debugging if requested.

@abhijithanandan removing init.vim is not enough, make sure you try with neovimClean

Thank you, it is working. But all the Neovim plugins are now disabled. Is there a way to fix that?


Update analyzer to automatically build binaries using github actions

Hi! I'm a Support Engineer at Saleae and we’ve made improvements to our analyzer build process. Specifically, we cleaned up the build system, and switched to cmake, so there aren't multiple project files anymore. By implementing the changes outlined here you will be able to provide the community automatic builds in addition to a simplified build system. Let us know if you think you can make the changes or if you’d like us to make the changes for you.
Additionally, if you would like to update your analyzer so that results appear in Logic 2’s data table you can follow the steps outlined here. Note that if you upgrade your analyzer to FrameV2 it will not be backward compatible with Logic 1.
We really appreciate your time and effort! Please let us know if you have any feedback or questions. Thanks!

Hello,
I didn't realize that the SDK had changed, I will update the analyzer, as well as the one for CAN 2.0B.
Thanks for the links.  I will also use FrameV2.
Pierre

Le 21 juil. 2022 à 00:43, timreyes @.***> a écrit :
Hi! I'm a Support Engineer at Saleae and we’ve made improvements to our analyzer build process. Specifically, we cleaned up the build system, and switched to cmake, so there aren't multiple project files anymore. By implementing the changes outlined here https://github.com/saleae/SampleAnalyzer/#updating-an-existing-analyzer-to-use-cmake--github-actions you will be able to provide the community automatic builds in addition to a simplified build system. Let us know if you think you can make the changes or if you’d like us to make the changes for you.
Additionally, if you would like to update your analyzer so that results appear in Logic 2’s data table you can follow the steps outlined here https://support.saleae.com/saleae-api-and-sdk/protocol-analyzer-sdk/framev2-hla-support-analyzer-sdk. Note that if you upgrade your analyzer to FrameV2 it will not be backward compatible with Logic 1.
We really appreciate your time and effort! Please let us know if you have any feedback or questions. Thanks!
—
Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/canfd-plugin-for-saleae-logic-analyzer/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVDSJBMVE4PXXKUUYRDVVB6IDANCNFSM54FNAGNQ.
You are receiving this because you are subscribed to this thread.

Hi, it is done.
I have updated the CANFD analyzer, added the workflows/build.yml, and made a release. I think all is ok, I have checked that an analyzer.zip is available with the release, and it contains the dynamic libraries for Windows, Linux and Mac.
I have also updated my CAN 2.0B analyzer i n the same way (https://github.com/pierremolinaro/can20B-plugin-for-saleae-logic-analyzer https://github.com/pierremolinaro/can20B-plugin-for-saleae-logic-analyzer), can you add it to the Community Shared Low Level Analyzers list ?
Using Logic2 is very pleasant, I really appreciate it. The only drawback is the simulation mode enabling method (we have discussed about that one year ago). If your are interested, I have written a little launch agent for Mac that permanently enables simulation. It is described in the readme.md of both aalyzers, feel free for using it if you are interested.
Best regards,
Pierre

Le 21 juil. 2022 à 00:43, timreyes @.***> a écrit :
Hi! I'm a Support Engineer at Saleae and we’ve made improvements to our analyzer build process. Specifically, we cleaned up the build system, and switched to cmake, so there aren't multiple project files anymore. By implementing the changes outlined here https://github.com/saleae/SampleAnalyzer/#updating-an-existing-analyzer-to-use-cmake--github-actions you will be able to provide the community automatic builds in addition to a simplified build system. Let us know if you think you can make the changes or if you’d like us to make the changes for you.
Additionally, if you would like to update your analyzer so that results appear in Logic 2’s data table you can follow the steps outlined here https://support.saleae.com/saleae-api-and-sdk/protocol-analyzer-sdk/framev2-hla-support-analyzer-sdk. Note that if you upgrade your analyzer to FrameV2 it will not be backward compatible with Logic 1.
We really appreciate your time and effort! Please let us know if you have any feedback or questions. Thanks!
—
Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/canfd-plugin-for-saleae-logic-analyzer/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVDSJBMVE4PXXKUUYRDVVB6IDANCNFSM54FNAGNQ.
You are receiving this because you are subscribed to this thread.

@pierremolinaro Thanks so much! I'll go ahead and close this Issue now.
I've also added your CAN 2.0B analyzer to our list of community analyzers below:
https://support.saleae.com/community/community-shared-protocols
You're right about making simulation mode enabled by default. Sorry for the hassle with that. I've added that to the backlog to discuss with the team. I personally haven't had any issues with the feature, so from my point of view, it should be safe to get included by default in upcoming relases.


project_json_capabilites is very messy

I have had issues when I have been trying to edit the project_json_capabilites.py file due to the nature that it has been coded. PyCharm really dislikes the code because it is full of bad style coding:

37 warnings and 57 weak warnings!!!

overriding a builtin name!!

How is this readable?!?!?!?!?!?!? It's almost like a poem with its references that go to the left and right
Regardless of that, the methods are filled with 'potentially non-existent' attributes like self.sprite which are not defaulted to None , which makes code completion extremely unhelpful as these attributes are not listed, and it makes it very ugly as there are yellow underlines everywhere.
I have my own project json capabilites library called sbeditor and have a decent amount of experience with project json editing using scripts. the project_json_capabilites file is one I would really like to contribute to however these issues are making it really hard for me to edit. I may make a pr in response to this issue to address this
sorry if this seems like a rant

i have now encountered severe fundamental issues in the system of sbeditor and will restart the project. i will probably integrate it directly into a branch of scratchattach in my own fork. if it becomes significantly more powerful than the current json capabilities, then i will open a pr

I would suggest you maybe take a look at custom json decoders

wdym? can you send link

This might help: https://stackoverflow.com/questions/48991911/how-to-write-a-custom-json-decoder-for-a-complex-object
With that, you could have it be decoded directly into the needed classes

ok. i think i might have an idea what to do

i feel there may be issues with things like the lists which do not contain any identifying Information - the one that store numbers will be hard to differentiate from other lists. if youre unlucky, jt may be exactly equivalent to a scratch list. so afaik the to json and from json methods seem like an easier/potentailly cleaner way of programming it

bad wordong but hmm

i am now working on a branch of scratchattach to do this

see scratchattach/editor

Parsing sb3 is now complete. Now we need exporting. Then editing, then come 'plugins'

theyre not really plugins, just idk what to call them. ill talk about them more when i get to that point in development

So, in summary, you are making a python scratch project editor

sbedutir v2


[Snyk] Upgrade uswds from 2.10.1 to 2.13.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade uswds from 2.10.1 to 2.13.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 12 versions ahead of your current version.
The recommended version was released 8 months ago, on 2022-04-11.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Cross-site Scripting (XSS) SNYK-JS-USWDS-1656800
484/1000  Why? Has a fix available, CVSS 5.4
No Known Exploit

Regular Expression Denial of Service (ReDoS) SNYK-JS-MINIMATCH-3050818
484/1000  Why? Has a fix available, CVSS 5.4
No Known Exploit

Regular Expression Denial of Service (ReDoS) SNYK-JS-GLOBPARENT-1016905
484/1000  Why? Has a fix available, CVSS 5.4
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Release notes

Package name: uswds

2.13.3 - 2022-04-11What's new in USWDS 2.13.3
Improvements and bug fixes

All components support High Contrast Mode and forced colors. All our components now support proper display when users have a forced colors mode set in their operating system. (#4610)
Big Footer includes more accessible disclosure buttons. Now the Big Footer variant uses more accessible disclosure buttons for showing and hiding submenus at mobile widths. Thanks @ mherchel! (#4476)
Allow default value in Time Picker. If the enhanced Time Picker input has a value, the value is now respected during initialization. Thanks @ aduth! (#4488)

Dependency updates

dependency
old
new

mocha
6.2.0
6.2.3

Note: We're now pinning our dependencies to exact versions to be more intentional about the dependencies we use.
0 vulnerabilities in regular dependencies (dependencies for USWDS projects installed with npm install uswds)
Internal only: 4 low, 8 moderate, 19 high, 1 critical vulnerabilities in devDependencies (development dependencies)
Release ZIP SHA-256 hash: ee183c713841b49f13e6ca7082b81cfd4b75ceff4d8ee4d6ea2cc61241139e68

2.13.2 - 2022-03-07

2.13.1 - 2022-01-20

2.13.0 - 2021-12-14

2.12.2 - 2021-11-01

2.12.1 - 2021-08-18

2.12.0 - 2021-06-16

2.11.2 - 2021-04-28

2.11.1 - 2021-03-17

2.11.0 - 2021-03-17

2.10.3 - 2021-03-15

2.10.2 - 2021-03-03

2.10.1 - 2021-02-19

    from uswds GitHub release notes

Commit messages

Package name: uswds

974f976 Merge pull request #4619 from uswds/release-2.13.3
80e90c5 Create uswds-2.13.3-zip-hash.txt
ef87a9c 2.13.3
b546756 Revert version and security hash to prep for re-output
54da400 Update references to 2.13.3
0952fe6 Create uswds-2.13.3-zip-hash.txt
a503ef0 2.13.3
641a6ed Update `mocha` to resolve minimist vulnerability
cfee857 Merge pull request #4620 from uswds/develop
8349ad2 Merge pull request #4618 from uswds/dependabot/npm_and_yarn/moment-2.29.2
01af019 Merge pull request #4488 from aduth/aduth-time-picker-initial-value
f12565a Bump moment from 2.29.1 to 2.29.2
fc6df77 Revert "Use data attribute for default value"
88b648e Merge pull request #4476 from mherchel/4475-footer-buttons
731748f Use data attribute for default value
32efd2a Merge branch 'develop' of github.com:uswds/uswds into pr/mherchel/4476
c997096 Merge pull request #4548 from uswds/jm-update-security-email
a91c817 Merge pull request #4572 from uswds/jm-update-tablet-lg-comment
ab9ad6c Merge pull request #4615 from uswds/dw-pin-deps
1acc8d1 Merge pull request #4610 from uswds/cm-high-contrast-a11y
8801626 Only look to change header element if using big footer variant
95ed2df Fix mistake :)
9dd0615 Remove unnecessary usage of template literals
a9c6ce6 Linting and unnecessary button id

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@snyk-bot rebase


Deprecated Geocoder endpoint and lifecycle badge

Removed the deprecated Geocoder endpoint and added a Lifecycle Badge to the readme.

This PR can be deleted. Changed have been made in the bcgov/ols-devkit repo.


[CT-2902] [Bug] No-op changes cause coverage to go down

Example PR: https://github.com/dbt-labs/dbt-core/pull/8258

@aranke Is this fixed now?


Great Project!

Hi!
This looks like an awesome project! LibreTranslate is great but I'm partial towards the minimalist style.
Feel free to pass relevant support requests my way, I'm normally pretty responsive on GitHub and the LibreTranslate Forum.
Best,
P.J.

Thank you for checking out this project!
We are aiming towards more minimal / lightweight infrastructure for our service to fit on very light machines.
As an example, we have a small demonstration API running entirely in Flask (using selected models)
We are soon going to experiment with temperature, top p, etc. to see how well we can use it in specific applications, like https://github.com/dothq/dialect
Awesome work on ArgosTranslate!!! See you around hopefully.


Add Nix Flakes to the project

This should prepare everything you need for development of the project when you run:
nix develop .

This will be part of #14 as this do not work in that form with Elixir.


CI: check if demos can be built

Added 'demos' and  targets to the Makefile
Added 'make demos' to the TravisCI configuration file
@swatisehgal I excluded crypto-perf from the build due to the issue #81. Please, include it back after fixing the issue. Thanks.

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   77.24%   77.24%
=======================================
  Files          10       10
  Lines        1090     1090
=======================================
  Hits          842      842
  Misses        230      230
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f236d5...6f82168. Read the comment docs.


Snapstart for ACK Lambda

Lambda just came out with Snapstart to reduce cold start times on Java lambdas by 90%. I'd love to see a new attribute added to the Lambda CRD to be able to support that.

/good-first-issue
/help-wanted


Port tests in aggregates.rs to sqllogictest

Is your feature request related to a problem or challenge?
Part of https://github.com/apache/arrow-datafusion/issues/6195. We are trying to

keep the DataFusion code base clean and easy to contribute to and modify
Understand what features are covered and what are not

Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily
Describe the solution you'd like
Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/aggregates.rs to
aggregates.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files
Note you can create catalogs and schema via SQL now
Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema
Notes:

Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest

Describe alternatives you've considered
No response
Additional context
I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.

@alamb I was starting to look into this, and I see an https://github.com/apache/arrow-datafusion/blob/main/datafusion/sqllogictest/test_files/aggregate.slt already existing. Can I assume that all tests that are still in https://github.com/apache/arrow-datafusion/issues/8194#:~:text=main/datafusion/core/tests/sql/aggregates.rs have not been migrated to SQL Tests?

Can I assume that all tests that are still in https://github.com/apache/arrow-datafusion/issues/8194#:~:text=main/datafusion/core/tests/sql/aggregates.rs have not been migrated to SQL Tests?

I think you'll need to check the tests individually to see if they have already been ported

Can I assume that all tests that are still in apache/arrow-datafusion/issues/8194#:~:text=main/datafusion/core/tests/sql/aggregates.rs have not been migrated to SQL Tests?

I think you'll need to check the tests individually to see if they have already been ported

Leaving here as a reference the current Rust test lists:

[] csv_query_array_agg_distinct
[] aggregate
[] aggregate_empty
[] aggregate_avg
[] aggregate_max
[] aggregate_min
[] aggregate_grouped
[] aggregate_grouped_avg
[] aggregate_grouped_empty
[] aggregate_grouped_max
[] aggregate_grouped_min
[] aggregate_min_max_w_custom_window_frames
[] aggregate_min_max_w_custom_window_frames_unbounded_start
[] aggregate_avg_add
[] case_sensitive_identifiers_aggregates
[] count_basic
[] count_partitioned
[] count_aggregated
[] count_aggregated_cube
[] count_multi_expr
[] count_multi_expr_group_by
[] simple_avg
[] simple_mean
[] run_count_distinct_integers_aggregated_scenario
[] count_distinct_integers_aggregated_single_partition
[] count_distinct_integers_aggregated_multiple_partitions
[] aggregate_with_alias
[] test_accumulator_row_accumulator

I think we have ported all the tests that make sense here so claiming victory


Split up DataTable component and add column click handler (v2)

Part of https://github.com/weaveworks/weave-gitops-enterprise/issues/2609
Save until after the release
Breaks up the DataTable component without affecting the modules that import it. Also adds some sort skipping logic for when we want to sort elsewhere.
I had originally intended to break up DataTable further but it was too high-risk.

LGTM, What do you think of moving Props type to type and create a style file that contains all related styles to Datatable ?
I believe it's good to follow the same structure as it's in this PR clap .

It still made sense to keep Props with the DataTable I think. As far as styles go, I would need to see what that looks like with styled-components. Typically, we would want to couple styles with their components, so a centralized style file might be odd?


Could you convert hdf5 to pd?

Could you convert hdf5 to pd?

@onexuan What is pd?

tensorflow model file, or how to convert it to onnx file

I provided some code on how to convert .hdf5 to .pb models here https://github.com/idealo/image-quality-assessment/issues/7#issuecomment-437293398


Rig Spam

When I do a rig spam, my sensitivity goes really high, why is that?
Video showing that:
https://gofile.io/d/CQDbk3

Its how the game works, there's not much you can do about it really.


Sourcemaps

Does this tool support sourcemaps? If not can it be implemented? Are there other options for .NET 5 SASS compilation that already support sourcemaps?

I tried disabling enableTagHelperBundling but it doesn't seem to traverse imports. In the above project linking this issue, we set up all imports in a single file and fix intellisense with ///   so that imports aren't duplicated. We also have some imports inside media queries that we can't pull up into the defined bundles, like the auto dark mode stylesheet's importing of the forced dark mode. So we really need true sourcemaps.


Initial implementation of https://github.com/blish-hud/Blish-HUD/issues/452

Added the ability to get the current command line from Gw2InstanceIntegration and used that as the mumble link file name.
The mumble link file name will prefer the one defined in settings then fall back to the command line, then the default, though I'm not sure if the way I'm swapping between IGw2MumbleClient instances is best practice(?). They're not disposed immediately, but they should get disposed when the gw2 client is disposed or they get collected - it looks like there's a weakreference-based cache in gw2sharp.
I thought it may be nice to leverage the EntryPoint package to parse the command line for gw2, however it doesn't appear to support long-form args with a single - (as in -mumble), so this is using a regex to determine the mumble file from the command line.
P/Invoke is used to get the command line info, with a slightly different pinvoke fallback method for Windows 8.0 and 7 machines, as it it much faster than querying WMI.

This is looking fantastic!  I'll need to do a bit of testing but I'm already pretty excited to do that.  I'm glad you found an alternative to querying WMI.
@Archomeda could you comment on the method used here for swapping IGw2MumbleClient instances?

@dlamkins Ah, technically it should be fine. Of course it's always better to dispose of the custom names yourself, but Gw2Sharp should dispose all of them as a catch-all.
You'll be the first to use this feature to my knowledge, and definitely the first in this way. There are a few tests in Gw2Sharp to make sure that it's working as intended, but I haven't tested it myself extensively and I don't trust this combination of WeakReferences, caching, indexer and disposing myself completely. There's the possibility to get infinite recursion with the indexer, and I have no clue whether disposals are handled perfectly, and whether the cache is correctly used. Let me know if any bugs creep up.

Works for me. 👍

Looks great!


Remove sensitive data from log files

Overview
There are cases where sensitive data can leak into a log file. This PR makes a first stab at the problem. The sensitive data can end up in the log when process implementing gen_server or gen_event behavior crashes. The erlang implementation of a gen_server support a format_status/2 callback to remove sensitive data from state term. However the last message (LastMsg) recveived by the process is still logged. In order to solve this problem this PR modifies couch_log_formatter to remove LastMsg in case when formatted state is a tupple with arity 2 and second element of a tuple is map containing sensitive key with value true. This allows us to remove sensitive information from both LastMsg and State via format_status/2 callback. Here is an example:
format_status(_Opt, [_PDict, State]) ->
    #state{
        url = Url,
        proxy_url = ProxyURL,
        limit = Limit
    } = State,
    {[
        {url, couch_util:url_strip_password(Url)},
        {proxy_url, ProxyURL},
        {limit, Limit}
    ], #{sensitive => true}}.

Testing recommendations

Make sure all dependent PRs are pulled
Run make eunit
Run make elixir

Related Issues or Pull Requests
This PR depends on the following:

https://github.com/apache/couchdb-config/pull/30
https://github.com/apache/couchdb-ibrowse/pull/3
https://github.com/apache/couchdb-mochiweb/compare/master...iilyak:implement-format-status?expand=1 <-- I need an advise which base branch to use.

Checklist

[x] Code is written and works correctly
[x] Changes are covered by tests
[ ] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

close in favor of https://github.com/apache/couchdb-config/pull/30


Add Spring web operation name handler

1.Support Spring RequestMapping
2.HandlerUtils.requestMapping，if use .path()can not get anything when use @Requestmapping
so change to value()

any update on this?

any update on this?

Do you want to use this feature?

any update on this?

Do you want to use this feature?

Yes, Currently I just copied your code in my application. It would be nice if this is made available as part of the library.

any update on this?

Do you want to use this feature?

Yes, Currently I just copied your code in my application. It would be nice if this is made available as part of the library.

Ok, I tried to finish this feature in this week. @pavolloffay


Deployment is always done on the same branch refs/heads/develop

Hi there,
I'm trying to set up the deployment of my develop branch and my master branch.
Despite the -m githubCommitRef=refs/heads/master parameter which appears in the command passed by Vercel-Action, it is the refs/head/develop branch which appears in the Vercel dashboard.
As a result, Vercel does not build the application and only change the domain of the previous deployment from develop -..... vercel.app to master -..... vercel.app
Here is the part of Yaml that interests us:
cd:
    needs: ci
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: amondnet/vercel-action@v19
        with:
          vercel-token: ${{ secrets.VERCEL_TOKEN }} # Required
          vercel-org-id: ${{ secrets.ORG_ID}}  #Required
          scope: 'slinkcorp'
          vercel-project-id: ${{ secrets.PROJECT_ID}} #Required
          working-directory: ./
          alias-domains: |
            {{BRANCH}}-slink-front.vercel.app

And the vercel.json too:
{
  "version": 2,
  "github": {
    "enabled": false
  },
  "builds": [
    {
      "src": "nuxt.config.js",
      "use": "@nuxtjs/vercel-builder"
    }
  ]
}

Any idea of what I'm doing wrong?

@mathieucollet
Is there any change in files?
https://vercel.com/docs/api#endpoints/deployments/create-a-new-deployment/force-a-new-deployment

Deploying again with the same request would yield the same response, with the same ID and URL due to no differences to the files or configuration.

https://vercel.com/docs/cli#options/global-options/force

The --force option, shorthand -f, is used either to force a deployment where there have been no changes or to forcibly replace an existing local directory.

Try using the --force option.
      - uses: amondnet/vercel-action@v19
         with:
           // your config
           vercel-args: --force // use --force option

Indeed, there were no changes in the files, because it was a merge of develop by hand. But I was trying to keep the two branches deployed.
Thanks for the -f trick, it does the job indeed!


Controls on MediaPlayerElement MTC Volume flyout are not vertically aligned

Here's the volume flyout from the Media Transport Controls of the MediaPlayerElement:

The mute button and the volume slider are not vertically aligned. Ideally they should be.
This can be illustrated by drawing a line from the slider to the left – it passes through the mute button below its center:

Also, when hovering the mute button, its highlight box is clipped at the bottom:

Good eye @dan-jac! @kaiguo is this template in WinUI now?

Yes, should be in WinUI now, I'll fix the alignment.


keep prev. search string

I hope there is already existing case on such simple issue/feature
is it possible to add a drop down with list of previously completed search strings
sometime search strings are quite lengthy and i hate simply to lose it and being forced to retype it.
as a workaround i have Notepad++ open on a side with all my searches and it just odd situation.
Pretty much any test editor out there has such feature as built-in option.
Thanks,

VSCode Version: 1.16.0
OS Version: Windows 10
Shell 1.7.3
Renderer 58.0.3029.110
Node: 7.9.0
Arch: x64
Hardware: Surface Pro 3

Steps to Reproduce:

open any text file
click Ctrl+F, type in string to find, Close / ESC
keep editing the file
open another tab to edit
click Ctrl+F, last search is gone and string to find now populated with current word from the second tab.

Suggestion: in step 5 i would like to have a drop down so i can select from history of prev. completed searches.

Reproduces without extensions: Yes

You can use alt+up/down to get earlier search strings :)

Or as you have suggested i can simply do Alt+Up/Down :-)
Thank you!


functional test sync_multiple_client_test fails intermittently

Describe the bug
sync_multiple_client_test functional test fails on first run but passes on re-run
sample failure runs
https://github.com/atsign-foundation/at_client_sdk/actions/runs/10175572645/job/28143281156
https://github.com/atsign-foundation/at_client_sdk/actions/runs/10176267126/attempts/1
https://github.com/atsign-foundation/at_client_sdk/actions/runs/10175572645/attempts/1
Steps to reproduce
github actions run after PR is raised
Expected behavior
test should pass on first run
Screenshots
No response
Smartphones

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Were you using an atApplication when the bug was found?
No response
Additional context
No response

another example https://github.com/atsign-foundation/at_client_sdk/actions/runs/10179182431/job/28154382069?pr=1371


Example files for Server + client

Hi, besides the API - are those files exist?
It would be really helpful to have a plug & play solution which compiles on a server/client and just holds until it gets those probes.
Should I just follow the API steps you recommended in order to create it right?
Also, what's the threshold for about 50 computer networks? will the delta be less than 1ms?
Thanks,
Ido

Hello- This is designed for 1:1 time sync like NTP.  I suppose one computer
could be elected as the central time server.  As a protocol it is under
specified so it can be used to build protocols including time sync such as
custom UDP based game protocols.
I haven’t released any netcode examples yet.
The delta should be within 1 ms for a moderately or lightly loaded LAN
-Chris
On Thu, Jul 5, 2018 at 7:28 AM idomic<EMAIL_ADDRESS>wrote:

Hi, besides the API - are those files exist?
It would be really helpful to have a plug & play solution which compiles
on a server/client and just holds until it gets those probes.
Should I just follow the API steps you recommended in order to create it
right?
Also, what's the threshold for about 50 computer networks? will the delta
be less than 1ms?
Thanks,
Ido
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/catid/TimeSync/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPZIb31jMdwZJ0UZNGiikl_2l6VkCtkks5uDiJ9gaJpZM4VD_XU
.

Thank you Chris

Can I use this library for time syncing in distributed smartphone connected over wifi?


hyperterm-blink has been renamed to hyper-blink

Checklist for submitting an awesome plugin, theme, or resource:

[x] The title for my package or theme uses its npm title (hyper-plugin-example)
[x] The link for my package or theme uses the npmjs.com link (https://www.npmjs.com/package/hyper-plugin-example)
[x] There is a visual representation of what my plugin or theme does in the repo. (Plugin: screenshot or gif || Theme: screenshot of the theme applied to Hyper)
[x] Put your awesome item at the BOTTOM of the correct (plugin, theme, or resource) list.
[x] VERY IMPORTANT: I've written a short (one sentence) description for my package or theme as the description of the awesome plugin, theme, or resource in the README.md file I'm submitting in the PR.

https://www.npmjs.com/package/hyperterm-blink => https://www.npmjs.com/package/hyper-blink

Awesome! Thanks for the fix - merged!


3rd party native library for Flutter package

If I need to create a flutter package for an existing library OR pod I am interested in some clarifications:
In the case of a new package for a library (.framework) ... will I add this in the Pods/Development Pods/hello/Classes/ location? I suppose not in the Runner project since the code to implement the channels and extra native implementation is in that location, as mentioned in the flutter package documentation.
In the case of a new package for a pod ... I suppose I add the new pod in the podfile and then should I run pod update? or?
Some additional resources I have gone through and maybe missed something:
This medium article that prompts me to a git repo.
This stack answer which is very android oriented.

You mean there's an existing non-Flutter library and you want to create a Flutter plugin that wraps the same calls?  In that case you would make a Flutter plugin with flutter create -t plugin as described here https://docs.flutter.dev/development/packages-and-plugins/developing-packages#step-1-create-the-package-1.  Your native iOS files wrapping the library go in ios/Classes as that doc says.
An example directory is created at the top level which is a Flutter app that uses the plugin.  You would flutter run it like a normal app to debug the dart side, hot reload, etc.  To debug the native side you can run at least once, or the simplified flutter build ios --config-only to set it up, and then open the Xcode project at ios/Runner.xcworkspace and set breakpoints.
https://docs.flutter.dev/development/packages-and-plugins/developing-packages#step-2c-add-ios-platform-code-swifthm
Do not manually edit anything in Pods, or run pod install, or do anything with CocoaPods.  Just pretend the example project is a normal Flutter project using your plugin.
If you need examples, check out the plugins that Flutter maintains: https://github.com/flutter/plugins/tree/main/packages
Is there something that could have been added to https://docs.flutter.dev/development/packages-and-plugins/developing-packages to make this clearer?


CF Dev guide - show output for running commands

Sample output for commands could be useful – if there’s a lot of output then a snippet showing what users should look for when a command completes successfully could be useful.  This doesn't have to be done for every command or for simple ones, but where a task is more involved or takes a long time, it would be useful to see what to expect.

Thanks for your feedback, I think it would be hard to capture output samples (some are very long as you noted) and to even maintain that per release in the guide.... I think adding a test at the end of major steps to show success or failure would be clearer and more maintainable. I will add something to help with that.


Dimension reasoning

System information

TensorFlow version (you are using): Tensorflow2.0
Are you willing to contribute it (Yes/No):

Describe the feature and the current behavior/state.
Will this change the current api? How?
No
Who will benefit with this feature?
No
Any Other info.
`
def roi_align_one_layer(feat, bbox, s, align_c):

            s_y, s_x = s
            num_bbox = tf.shape(bbox)[0]
            feat_shape = tf.shape(feat)

tensorflow know c_i here, for example, [None, None, 256]
        h_i, w_i, c_i = feat_shape[0], feat_shape[1], feat_shape[2]

        h_f, w_f = tf.cast(h_i, tf.float32), tf.cast(w_i, tf.float32)
        bbox_y1 = bbox[:, 0:1]
        bbox_x1 = bbox[:, 1:2]
        bbox_y2 = bbox[:, 2:3]
        bbox_x2 = bbox[:, 3:4]
        bbox_h = bbox_y2 - bbox_y1
        bbox_w = bbox_x2 - bbox_x1
        if align_c:
            off_y = 0. if s_y > 1 else bbox_h / 2.
            off_x = 0. if s_x > 1 else bbox_w / 2.
            grid_y = tf.linspace(0.0, 1.0, s_y)
            grid_x = tf.linspace(0.0, 1.0, s_x)
        else:
            off_y = bbox_h / (2. * s_y)
            off_x = bbox_w / (2. * s_x)
            grid_y = tf.linspace(0.0, 1.0, s_y + 1)[:-1]
            grid_x = tf.linspace(0.0, 1.0, s_x + 1)[:-1]
        grid_y = tf.expand_dims(tf.matmul(bbox_h, tf.expand_dims(grid_y, axis=0)) + off_y + bbox_y1, axis=-1)
        grid_x = tf.expand_dims(tf.matmul(bbox_w, tf.expand_dims(grid_x, axis=0)) + off_x + bbox_x1, axis=-1)

        grid_y = tf.where(grid_y < 0., 0., grid_y)
        grid_x = tf.where(grid_x < 0., 0., grid_x)
        grid_y = tf.where(grid_y > h_f-1., h_f-1., grid_y)
        grid_x = tf.where(grid_x > w_f-1., w_f-1., grid_x)
        grid_y = tf.tile(grid_y, [1, 1, s_y])
        grid_x = tf.tile(grid_x, [1, 1, s_x])
        grid_y = tf.reshape(grid_y, [num_bbox, -1])
        grid_x = tf.reshape(grid_x, [num_bbox, -1])
        grid_y1 = tf.math.floor(grid_y)
        grid_y2 = tf.math.floor(grid_y+1.)
        grid_x1 = tf.math.floor(grid_x)
        grid_x2 = tf.math.floor(grid_x+1.)
        wey1 = tf.expand_dims(grid_y - grid_y1, axis=-1)
        wey2 = tf.expand_dims(grid_y2 - grid_y, axis=-1)
        wex1 = tf.expand_dims(grid_x - grid_x1, axis=-1)
        wex2 = tf.expand_dims(grid_x2 - grid_x, axis=-1)
        grid_y2 = tf.where(grid_y2 > h_f - 1., h_f - 1., grid_y2)
        grid_x2 = tf.where(grid_x2 > w_f - 1., w_f - 1., grid_x2)
        grid_y1 = tf.cast(grid_y1, tf.int32)
        grid_y2 = tf.cast(grid_y2, tf.int32)
        grid_x1 = tf.cast(grid_x1, tf.int32)
        grid_x2 = tf.cast(grid_x2, tf.int32)
        grid_11 = grid_y1 * w_i + grid_x1
        grid_12 = grid_y1 * w_i + grid_x2
        grid_21 = grid_y2 * w_i + grid_x1
        grid_22 = grid_y2 * w_i + grid_x2
        feat = tf.reshape(feat, [h_i*w_i, c_i])
        feat_11 = tf.gather(feat, grid_11)
        feat_12 = tf.gather(feat, grid_12)
        feat_21 = tf.gather(feat, grid_21)
        feat_22 = tf.gather(feat, grid_22)
        feat_bilinear = wey2 * (feat_11 * wex2 + feat_12 * wex1) + wey1 * (feat_21 * wex2 + feat_22 * wex1)

tensorflow don't know c_i here,   [None, 14, 14, None]
        feat_bilinear = tf.reshape(feat_bilinear, [num_bbox, s_y, s_x, c_i])

        return feat_bilinear

`
the data_format is the 'channels_last'
when enable eager or disable_enger
when I use y = roi_align_one_layer(feat, bbox, s, align_c) the tensorflow2.0 know the number of channels of feat but don't know the number of channels of y,
when I use tf.keras.layers.Conv()(y), tensorflow2.0 raise error that tensorflow2.0 don't know the number of input channels
how to let tensorflow  know it automatically

@Stick-To ,
Thanks for reporting the issue, Can you share standalone code to reproduce the issue?


Case sensitive directories on Windows

Describe the bug
When using this repo/package on a Windows host machine, leveraging WSL2, the directory imported is @fontsource/manrope but the package itself is configured to be at @fontsource/Manrope.
After running npm install, if I rename the manrope directory to Manrope, everything works.
If I don't do this, the package can't be found on my local machine.
Steps to Reproduce

install the package
run the app
change manrope to Manrope

Expected behavior
As a user, I shouldn't have to worry about directory names and their case-sensitivity.
Version
5.0.4
OS
Windows WSL2
Browser
Chrome
Additional context
No response

Can you give me an application reproduction? I use WSL2 and haven't experienced this.

Closing due to lack of reproduction.


fix(onlineManager): listen to 'offline' events

Fixes #1654

:tada: This PR is included in version 3.5.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.5.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fatal error: Uncaught Error: Class "Dotenv\Dotenv" not found in

Fatal error: Uncaught Error: Class "Dotenv\Dotenv" not found in projectdb.php Stack trace: #0 {main} thrown in
I was following github phpdotenv tutorial
I am using latest php and latest composer version available
php 8.2.2
composer 2.5.3
on Arch linux
When the problem is expected to solve?
by the way I have tried clearing composer cache and try again? which was mentioned 2 years ago someone faced the issue

I have this same problem


Optimize code size

Check production code size. If size is an issue can make some simple changes:

[ ] replace URL validation with a regexp

closing


Support digital alarm blocks

Right now only ACNET analog alarms are support.  Extend support to digital alarms.

This is new functionality for the parameter page. This is currently handled in a separate application.
Just documenting for context.


Deploy the application on GitPages

Deploy on git pages

Need to rethink cannot deploy the application on GitHub pages as it only supports static application


Reference Lines do not show

Hi guys,
I'm current using v4.6.2 and OhifViewer. Im currently working to add reference lines feature to the Viewer and i got this issue

This is the study
https://drive.google.com/file/d/1jj0q_ySklAHNcoAM1-DBXHlFJBVS6Weq/view?usp=sharing

Have you compared the behavior in a "known good" viewer?

@dannyrb
This is screen of RadiAnt

Not sure if it my issue is related, but I also have a problem with reference lines not showing up between multiple images: https://github.com/cornerstonejs/cornerstone-nifti-image-loader/issues/13 (in addition to a more severe problem with mapping coordinates between those images).

@jussimattila, is this problem solved?  I have facing issues in normal dicom loader with latest versions. The images working fine with Radiant viewer. But in cornerstonejs viewer not showing reference line. If this fails my implementation to use cornerstone based viewer will be void. I fear about it. Please help


react-google-charts Timeline not rendering anything

I was able to create some timelines already.
I'm getting a "Cannot read property 'datefield' of undefined" on this CSB. I checked if there is a missing datefield and there aren't any.
https://codesandbox.io/s/countries-timelines-if1tc?file=/src/App.js

I figured what the bug was. It seems that for long timelines you need to increase the width of the chart or you will get this error message.


[Tag group] Create the Tag group design specs

User story

As a [user role below]:
developer on the DDS Squad

I need to:
have the Tag group design specs

so that I can:
correctly create the Tag group component

Additional Information

Carbon for ibm.com epic (#5987 )

Acceptance Criteria

[ ] A Sketch file is created or updated with the Tag group design and specs
[ ] Create a Box folder for the ?component name? (if not already there)
[ ] The design specs and pdf version are added to the Box folder
[ ] Add Box folder link to the website content if it exists

Done! :tada:
https://ibm.box.com/s/t2njzzny00mgy67cxj0r420nacvpvc83


Code snippet for signature generation

Hi!
Could anybody provide a code snippet in C# for Recurly signature generation/verification?
I can't find this code in sources...
Any help will be greatly appreciated. Many thanks in advance!

Please see my fork at https://github.com/kayh/recurly-client-net, this contains the RecurlyVerification class, whcih provides everything in order to use recurly-js.

This is great!
Don't have enough words to express my gratitude. Thank you very much!

Just make sure you merge the latest changes into my fork. I hope it will be included in the master branch soon.

Thanks. I also hope it will be included.


[lit-html] Gesture system support / declarative synthetic event generators

We'd like it to be easier to integrate gesture systems into lit-html templates.
Many gesture libraries work on a similar overall structure, where they listen to several native events, and synthesize their own events for the gesture, once the gesture is recognized. These events aren't always DOM Events, but they're similar in spirit.
For example, Hammer.js:
const el = document.querySelector('#el');
const hammer = new Hammer(el);
const onPan = (e) => {
  //
});
hammer.on('press', onPan);

The onPan function passed to on() receives a Hammer Event object.
We already have a nice way to listen to arbitrary DOM Events. So if Hammer worked slightly differently and instead of accepting listeners via the on() method, it just fired DOM Events, we could write something like this:
html`<div @pan=${onPan}`>
`

THis is nice, but we would still need a way to attach the gesture recognizer to the element - in Hammer, what the new Hammer(el) and hammer.on('pan', ...) calls do.
We could do this now with a directive:
import {hammer} from 'hammer-lit';

// ...

html`<div @pan=${hammer(onPan)}`>
`

Where the hammer directive gets the name of the event, constructs a Hammer object if necessary, and registers the Hammer listener.
This isn't so bad, and we should consider that we could just document this approach and implement a few adapter directives for gesture libraries. But ideally we'd do this without any extra ceremony at the event listener binding site. These synthetic events should have a similar DX as native events.
So another option is to use RenderOptions to allow gesture systems to hook event listeners across a whole render tree. A custom element base-class like LitElement could wire this together, much like it does for eventTarget:
import {pan} from 'hammer-lit';

class MyElement extends LitElement {
  static gestures = {
    pan
  };

  render() {

  }

  _onPan(e) {
    // ...
  }
}

Here the hammer-lit module would adapt the APIs. The pan gesture hook would be called only when listeners are attached for the pan event, so there's no cost if the hook isn't used. The hook would do whatever setup is necessary to attach the gesture library's native event listeners, and would fire a DOM Event matching the gesture name.
This is obviously more general than just gestures, and would amount to a kind of render-root-scoped implicit directive. Is that a good thing? Render-root-scoped behavior might be tricky when composing templates from multiple sources, as the behavior of the template changes based on where it's rendered. We could also consider an approach where the hooks are registered with the template tag, and so are scoped to the template that uses them...

cc @straversi @azakus

Thank you so much for the clear documentation above demonstrating current capabilities. I'm interested in adding gesture support to my components soon. Any updates on this proposed enhancement? Otherwise, I guess I can start implementing hammer like in the first example.

This should be an RFC, and with element directives and reactive controllers, probably doesn't need to have built-in support in LitElement or lit-html. We could do a labs package.