Navigate out of a nested Memory router

I have a nested MemoryRouter inside a BrowserRouter. Question is, how do I navigate out of a MemoryRouter?
Basically, I have a link in a page in my MemoryRouter that takes the user to a route listed in my BrowserRouter, yet this simply leads to an empty page as it thinks the page is inside my MemoryRouter when it isn't.
I have implemented a solution where I pass a higher-level callback into my MemoryRouter that executes when I call this in the MemoryRouter, yet this seems a bit laborious to say the least.
Is there something I'm missing from the docs or is this simply a limitation that I will have to work around as I want to have specific routes that do not change the URL.

You have to create your own history instance and use Router. You'll have to get access to that history instance to be able to change the route.

Thanks for the reply.
I've had a look at this solution but can't seem to get it working. Can you provide an example as there just does not seem to be any clear examples of how to do this without providing a nested callback which seems a bit hacky?

Something like this:
const history = createBrowserHistory()
window.browserHistory = history

ReactDOM.render(<Router history={history}> //...

// elsewhere, underneath a <MemoryRouter>

<a href="#" onClick={e => { e.preventDefault(); window.browserHistory.push('/foo') }} />

Thanks for the reply. I've just managed to figure it out also after rethinking how I can achieve this and came up with a very similar solution whereby I simply pass the top-level history instance as a prop to my MemoryRouter component, allowing all nested routes access to this instance of 'appHistory' to be able to navigate out of the MemoryRouter, which works exactly the way I want it to. Thanks for the fast reply either way though as it turns out I was on track after looking into this more : )


Warnings when reading .spef file for Element when trying to do mock-array read_power_activities

Describe the bug
Based on https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/2120
I don't know why the .spef file is read in, but I get warnings when I try to read in the .spef file for Element.
untar mock-array-sta-warnings.tar.gz
./run-me-mock-array-asap7-base.sh

Result:
OpenSTA 2.5.0 1c7f022cd0 Copyright (c) 2024, Parallax Software, Inc.
License GPLv3: GNU GPL version 3 <http://gnu.org/licenses/gpl.html>

This is free software, and you are free to change and redistribute it
under certain conditions; type `show_copying' for details.
This program comes with ABSOLUTELY NO WARRANTY; for details type `show_warranty'.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13178, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13211, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13244, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13277, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13310, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13343, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13376, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14772, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14805, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14838, timing group from output port.
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10511, net _0000_ not found.
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10513, instance io_outs_down\[0\]$_DFF_P_ not found.
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10514, instance _0835_ not found.
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10547, net _0001_ not found.
[delete]
Group                  Internal  Switching    Leakage      Total
                          Power      Power      Power      Power (Watts)
----------------------------------------------------------------
Sequential             3.26e-04   0.00e+00   1.03e-08   3.27e-04   8.2%
Combinational          1.37e-13   8.30e-14   2.36e-07   2.36e-07   0.0%
Clock                  1.78e-03   1.86e-03   1.50e-08   3.64e-03  91.8%
Macro                  0.00e+00   0.00e+00   0.00e+00   0.00e+00   0.0%
Pad                    0.00e+00   0.00e+00   0.00e+00   0.00e+00   0.0%
----------------------------------------------------------------
Total                  2.11e-03   1.86e-03   2.61e-07   3.96e-03 100.0%
                          53.2%      46.8%       0.0%
Annotated 46598 pin activities.
Group                  Internal  Switching    Leakage      Total
                          Power      Power      Power      Power (Watts)
----------------------------------------------------------------
Sequential             3.26e-04   0.00e+00   1.03e-08   3.27e-04   8.2%
Combinational          1.51e-14   9.19e-15   2.86e-07   2.86e-07   0.0%
Clock                  1.78e-03   1.86e-03   1.50e-08   3.64e-03  91.8%
Macro                  0.00e+00   0.00e+00   0.00e+00   0.00e+00   0.0%
Pad                    0.00e+00   0.00e+00   0.00e+00   0.00e+00   0.0%
----------------------------------------------------------------
Total                  2.11e-03   1.86e-03   3.12e-07   3.96e-03 100.0%
                          53.2%      46.8%       0.0%

Expected Behavior
No warnings
Environment
OpenSTA 2.5.0 1c7f022cd0

To Reproduce
See above
Relevant log output
No response
Screenshots
No response
Additional Context
No response

Two problem:

You should not load Element.lib as doing so makes it a black box and hides the internals
You have to load the parasitics for each element:

for {set x 0} {$x < 8} {incr x} {
  for {set y 0} {$y < 8} {incr y} {
    read_spef -path ces_${x}_${y} results/asap7/mock-array_Element/base/6_final.spef
  }
}

FYI report_parasitic_annotation is helpful to check

I will fix this, but can we merge this as a baseline?
This way there is a shared baseline in master for the various efforts and parties involved...

report_parasitic_annotation

I tried the following:
$ git diff
diff --git a/flow/designs/asap7/mock-array/power.tcl b/flow/designs/asap7/mock-array/power.tcl
index d80bee9f..505fc42c 100644
--- a/flow/designs/asap7/mock-array/power.tcl
+++ b/flow/designs/asap7/mock-array/power.tcl
@@ -10,9 +10,14 @@ link_design MockArray

 read_sdc $::env(RESULTS_DIR)/6_final.sdc
 read_spef $::env(RESULTS_DIR)/6_final.spef
-# FIXME lots of warnings
-#read_spef results/asap7/mock-array_Element/base/6_final.spef
+for {set x 0} {$x < 8} {incr x} {
+  for {set y 0} {$y < 8} {incr y} {
+    puts "Reading ces_${x}_${y}"
+    read_spef -path ces_${x}_${y} results/asap7/mock-array_Element/base/6_final.spef
+  }
+}

+report_parasitic_annotation

and got:
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14838, timing group from output port.
Reading ces_0_0
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10511, net _0000_ not found.
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10513, instance io_outs_down\[0\]$_DFF_P_ not found.
[deleted]
Reading ces_0_1
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10511, net _0000_ not found.
Warning: results/asap7/mock-array_Element/base/6_final.spef line 10513, instance io_outs_down\[0\]$_DFF_P_ not found.
[deleted]
Found 7622 unannotated drivers.
Found 0 partially unannotated drivers.

I'm guessing you missed "You should not load Element.lib "

I'm guessing you missed "You should not load Element.lib "

What about the PDK .lib files?

When I change from LIB_FILES to TC_NLDM_LIB_FILES, the warnings go away as you explained:
foreach libFile $::env(TC_NLDM_LIB_FILES) {
read_liberty $libFile
}

vars-mock-array-asap7-base.sh:export LIB_FILES="${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_INVBUF_RVT_FF_nldm_220122.lib.gz ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_OA_RVT_FF_nldm_211120.lib.gz ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_SEQ_RVT_FF_nldm_220123.lib  ./results/asap7/mock-array_Element/base/Element.lib"
vars-mock-array-asap7-base.sh:export TC_NLDM_LIB_FILES="${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_AO_RVT_TT_nldm_211120.lib.gz ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_INVBUF_RVT_TT_nldm_220122.lib.gz ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_OA_RVT_TT_nldm_211120.lib.gz ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_SEQ_RVT_TT_nldm_220123.lib ${FLOW_HOME}/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_TT_nldm_211120.lib.gz"

Probably you can just unset ADDITIONAL_LIBS

So you mean I should read the .lib files from the PDK, but not from the macros?

Yes.  It will get the power data for any std cell from the .lib

And the reason this works with pdk .lib files and not elements is that the pdk .lib files are sufficiently detailed as the std cells are small whereas too much detail is lost for Element....
So it is not turtles all the way down...

I still get unannoted things.
Untar  mock-array-element-unannoted.tar.gz
./run-me-mock-array-asap7-base.sh

OpenSTA 2.5.0 1c7f022cd0 Copyright (c) 2024, Parallax Software, Inc.
License GPLv3: GNU GPL version 3 <http://gnu.org/licenses/gpl.html>

This is free software, and you are free to change and redistribute it
under certain conditions; type `show_copying' for details.
This program comes with ABSOLUTELY NO WARRANTY; for details type `show_warranty'.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13178, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13211, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13244, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13277, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13310, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13343, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 13376, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14772, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14805, timing group from output port.
Warning: /home/oyvind/OpenROAD-flow-scripts/flow/platforms/asap7/lib/NLDM/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz line 14838, timing group from output port.

Group                  Internal  Switching    Leakage      Total
                          Power      Power      Power      Power (Watts)
----------------------------------------------------------------
Sequential             1.95e-01   0.00e+00   4.89e-06   1.95e-01  57.8%
Combinational          2.98e-14   1.99e-14   5.93e-06   5.93e-06   0.0%
Clock                  6.98e-02   7.25e-02   6.48e-07   1.42e-01  42.2%
Macro                  0.00e+00   0.00e+00   0.00e+00   0.00e+00   0.0%
Pad                    0.00e+00   0.00e+00   0.00e+00   0.00e+00   0.0%
----------------------------------------------------------------
Total                  2.65e-01   7.25e-02   1.15e-05   3.37e-01 100.0%
                          78.5%      21.5%       0.0%

I'm guessing clock_load cells have floating output so there is nothing to extract in spef.  Are the others similar?

Yes... Verilator picks up on it too....
%Warning-PINMISSING: /home/oyvind/OpenROAD-flow-scripts/flow/designs/src/mock-array/test_run_dir/MockArray_should_Wiggle_some_wires/MockArrayFinal.v:68344:22: Cell has missing pin: 'Y'
68344 |  INVxp67_ASAP7_75t_R clkload0 (.A(clknet_3_1_0_clock_regs));
      |                      ^~~~~~~~
                     ... For warning description see https://verilator.org/warn/PINMISSING?v=5.012
                     ... Use "/* verilator lint_off PINMISSING */" and lint_on around source to disable this message.
%Warning-PINMISSING: /home/oyvind/OpenROAD-flow-scripts/flow/designs/src/mock-array/test_run_dir/MockArray_should_Wiggle_some_wires/MockArrayFinal.v:68345:21: Cell has missing pin: 'Y'
68345 |  BUFx4f_ASAP7_75t_R clkload1 (.A(clknet_3_2_0_clock_regs));
      |                     ^~~~~~~~
%Warning-PINMISSING: /home/oyvind/OpenROAD-flow-scripts/flow/designs/src/mock-array/test_run_dir/MockArray_should_Wiggle_some_wires/MockArrayFinal.v:68346:22: Cell has missing pin: 'Y'
68346 |  INVxp67_ASAP7_75t_R clkload2 (.A(clknet_3_3_0_clock_regs));

In that case I'm not sure there is anything to fix.

In that case I'm not sure there is anything to fix.

That is one group of warnings, but there are one or two other kinds that I dont understand yet....

Do you need help or are you investigating?

Do you need help or are you investigating?

Could you do a run locally and categorize the warnings?
Can we get rid of them somehow by indicating somewhere that this is OK?
It would be satisfying to have no warnings and no wires or pins left unannotated by .vcd and also easier to write a test....

report_parasitic_annotation covers spef annotations not vcd.  I'll take a look.

The partially annotated drivers come about because the top level abutment.  The extractor doesn't write anything at the top level and sta warns about the partial annotation.  In practice everything is ok but sta doesn't know that.  I'll see if I can convince rcx to write a dummy connection.

The partially annotated drivers come about because the top level abutment. The extractor doesn't write anything at the top level and sta warns about the partial annotation. In practice everything is ok but sta doesn't know that. I'll see if I can convince rcx to write a dummy connection.

👍

@maliberty opened #5411 to track the feature request(reduce warnings).


Double extend a component

Is it possible to override styles from grandparent in a child component?
Example:

ComponentB extends ComponentA with extendStyles.
ComponentC extends ComponentB with extendStyles.

ComponentC styles can only override styles from componentB and no longer change styles from componentA

@nunoliveira12 A few things here.

Extending doesn't override styles, so perhaps the verbiage is wrong?
ComponentC would have access to A & B styles, since B inherits everything (it's a deep merge that happens recursively: https://github.com/milesj/aesthetic/blob/master/packages/core/src/Aesthetic.tsx#L135)

@milesj It does override for the parent component
For example BaseChip.tsx:
export const styleSheet: StyleSheetFactory<Theme> = theme => ({
  chip: {
    backgroundColor:"blue",
    color:"white"
  }
});

const BaseChip: React.FC<WithStylesProps> = ({
  styles,
  cx
}) => {
  return (
    <div
      className={cx(styles.chip)}
    >
      base chip
    </div>
  );
};

export default withStyles(styleSheet, { extendable: true })(BaseChip);

and DerivedChip.tsx:
const DerivedChip: React.FC = () => {
  const AlteredBaseChip = BaseChip.extendStyles(theme => ({
      chip: {
          backgroundColor:"red"
      }
  }));

  return (
    <AlteredBaseChip/>
  );
};

export default DerivedChip;

It does override the first style:

Now if they were more complex than these examples and I wanted to extend the styles of the DerivedChip, how would I do it? And If I do similar to what was done, it will only extend the styles on the parent and couldn't, for example, change this backgroundColor because it was from the grandparent.
Anyway, from your bullet points, it does inherit the style from A & B but can only change the styles from B

@nunoliveira12  In your second example, it would just be this.
const DerivedChip = BaseChip.extendStyles(theme => ({
  chip: {
      backgroundColor:"red"
  }
}));

export default DerivedChip;

Extending styles creates a new component, so you can just render <DerivedChip />. And with the example above, you can extend yet again.
const DerivedChipAgain = DerivedChip.extendStyles(theme => ({
  chip: {
      backgroundColor: "green"
  }
}));

export default DerivedChipAgain;

@milesj Thanks!
But If we want to change something on the render / add some props.
Let's imagine it accepts a prop derived and I wanted to enable it (that's why I used the example before).
Should we do it another way than this?
const DerivedChip: React.FC = () => {
  const AlteredBaseChip = BaseChip.extendStyles(theme => ({
      chip: {
          backgroundColor:"red"
      }
  }));

  return (
    <AlteredBaseChip derived={true}/>
  );
};

export default DerivedChip;

but if I do this, I cannot extend again the same way

@nunoliveira12 Just moved the altered outside.
const AlteredBaseChip = BaseChip.extendStyles(theme => ({
  chip: {
    backgroundColor: 'red',
  },
}));

const DerivedChip: React.FC = () => {
  return <AlteredBaseChip derived={true} />;
};

export default DerivedChip;

@milesj Thanks for your help so far,
And sorry for not explaining what I wanted from the beginning.
Your example does allow to extend the styles, but If I wanted to extend the style while also extend the component.
These examples are quite simple, but I wanted to have a ComplexComponent extending a BasicComponent, and then having a ComplexWithStyleComponent that changes the ComplexComponent.
const AlteredBaseChip = BaseChip.extendStyles(theme => ({
  chip: {
    backgroundColor: 'red',
  },
}));

const DerivedChip: React.FC = () => {
  return <AlteredBaseChip derived={true} />;
};

const AlteredBaseChipAgain = AlteredBaseChip.extendStyles(theme => ({
  chip: {
    backgroundColor: 'green',
  },
}));

const DerivedChipAgain: React.FC = () => {
  return <AlteredBaseChipAgain  />;  // This one doesn't enable the derived={true} prop, that's what I wanted , while changing the styles.
};

Sorry, probably I'm just overlooking something, but couldn't get this to work

@nunoliveira12 Yeah, that's not supported. Extending only changes the styles, it doesn't extend component classes or copy props over.
It just reuses the same base component over and over again: https://github.com/milesj/aesthetic/blob/master/packages/react/src/withStyles.tsx#L77

@milesj Thanks for your answer! That's what I was afraid of.
Is there any plan on including this in future releases?

@nunoliveira12 Probably not. It would cause far too many layers of nested components.
I'm also moving towards hooks, which may make this API easier to use in the future.

The entire API has been rewritten from the ground up. This pattern is no longer possible, but with the new API, it should be much easier to use. Closing for now, will write docs soon.


Add a source for HyVee

This is based on VaccineSpotter's code. It’s a very incomplete work-in-progress; I need to step away for the day and am pushing this up in case I don’t get to it by Monday, at which point I may not be able to do any more.
Fixes #422.

P.S. great branch name!


Improve e2e execution time

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR reduces the time it takes to run the singlecluster e2e tests by removing the need to use long runtime containers in two tests
Which issue(s) this PR fixes:
Fixes #1449
Does this PR introduce a user-facing change?
NONE

/assign @mimowo
Let me know your opinion Michał 😊 Besides, I think there are some other tests than can be further simplified.
Thanks so much!

/lgtm
/approve
In case @alculquicondor would like to add something:
/hold

/hold cancel


Add shim for Microsoft Teams

This shim will post messages to a Microsoft Teams channel.  I mostly used the Slack shim for reference.

Coverage increased (+0.1%) to 86.057% when pulling eb041c8ddf12d4d13909233f044e1e424550ea01 on doogleit:feature/msteams into 37659bcbf79f3da543a7b46167009ccd754eddb1 on vmw-loginsight:master.


fmt: error in the documentation for fmt.Formatter?

What version of Go are you using (go version)?

$ go version
go version devel go1.21-40bdc56180 Tue May 23 13:22:25 2023 +0000 linux/arm64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/myitcv/gostuff/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/dev/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/dev/go/pkg/tool/linux_arm64"
GOVCS=""
GOVERSION="go1.20.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build697360160=/tmp/go-build -gno-record-gcc-switches"

What did you do?
$ go doc fmt Formatter

What did you expect to see?
Documentation that is consistent with the intended use of fmt.Formatter
What did you see instead?
package fmt // import "fmt"

type Formatter interface {
        Format(f State, verb rune)
}
    Formatter is implemented by any value that has a Format method. The
    implementation controls how State and rune are interpreted, and may call
    Sprint(f) or Fprint(f) etc. to generate its output.

It's unclear to me how a call to Sprint(f) can possibly work with with a fmt.State value.
A call to Fprint(f) yes, but not Sprint(f).
Am I missing something obvious, or is this a mistake in the docs?

Could "may call Sprint(f)" mean "may call Sprint or Sprintf" instead of "may call Sprint with f"? I can't remember where I've seen the syntax before but I associate ab(c) with matching ab and abc.
Even if that match is the intent of the comment, I agree that it's confusing in this context where Sprint and Fprint are functions and f is a defined parameter.

Yes, it's an error. It should read "Sprint() or Fprint(f)".

So is a call to Sprintf dangerous? Is it because Sprintf is not reentrant?
If this was allowed before by the documentation, but not anymore, this not just a bug fix but a breaking change.

So is a call to Sprintf dangerous? Is it because Sprintf is not reentrant?

@dolmen - what does the call Sprint(f) actually do to your understanding?

@dolmen To be clear, calling fmt.Sprintf is fine.  The comment was confusing.


[DOCFIX] Update FAQ about Alluxio book

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10313/
Test PASSed.

alluxio-bot, merge this please


mWeb - Workspace - Multiple windows are opened at once before redirecting to workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: https://github.com/Expensify/App/pull/47459
Issue reported by: Applause Internal Team
Action Performed:

Open the app
Log in with a new Gmail account
Click on FAB - New workspace

Expected Result:
I should be redirected to the workspace settings page.
Actual Result:
Multiple windows are opened at once before redirecting to workspace settings page.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e710d59a-af29-4d03-bac0-f8462bfbf372

View all open jobs on GitHub

We think that this bug might be related to #wave-collect - Release 1

@dylanexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

reproducing today!


Eloquent eager loading causes SQL error when sorting and models returned do not have relationship

Using Laravel 5.1.12 and Laravel Datatables 5.11.6, attempting to use an Eloquent model retrieval as the source where there are no related models returned in the subset of records, results in invalid SQL:
$devices = Device::with('assigned_user',
    'completed_by_user')
    ->select('*');

Results in the following SQL when attempting to sort by assigned user name:
select top 10 * from [prefix_devices] order by [name] asc

The SQL above does not join in the necessary table for the sort, using the requisite [alias].[column] convention considering the user model is being related twice.

Are you trying to sort on eager loaded model column? If yes, it's currently not supported. You can only sort relations using join statement.

Yes, correct. Thanks for the clarification. Once I switched to fluent with left joins, I was able to do accomplish what I was trying to do.


Xcode compilation error with 1.7.2

Current bug behavior
I have upgraded my flutter project and receiving an error while compiling in Xcode (versions see below).
The error states:
Failed to build iOS app
Error (Xcode): ../../../../../.pub-cache/hosted/pub.dev/flame-1.7.2/lib/src/components/core/recycled_queue.dart:23:7: Error: 'Iterable' can't be used in both 'extends' and
'implements' clauses.

Expected behavior
I would expect, that this error does not get thrown.
Steps to reproduce
Sadly, I am not sure how to reproduce. Maybe the versions are a better clue.
Flutter doctor output
[✓] Flutter (Channel master, 3.10.0-5.0.pre.33, on macOS 13.3.1 22E261 darwin-x64, locale de-DE)
    • Flutter version 3.10.0-5.0.pre.33 on channel master at /usr/local/Caskroom/flutter/3.0.5/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b95cd931ae (38 minutes ago), 2023-04-14 13:20:49 -0400
    • Engine revision ea0e1b1700
    • Dart version 3.1.0 (build 3.1.0-4.0.dev)
    • DevTools version 2.23.1

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] VS Code (version 1.76.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] VS Code (version 1.72.0-insider)
    • VS Code at /Applications/Visual Studio Code - Insiders.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.3.1 22E261 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 112.0.5615.49

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

More environment information

Flame version: 1.7.2
Platform affected: ios
XCode: 14.3
Flutter 3.10.0-5.0.pre.33 • channel master • https://github.com/flutter/flutter.git
Framework • revision b95cd931ae (41 minutes ago) • 2023-04-14 13:20:49 -0400
Engine • revision ea0e1b1700
Tools • Dart 3.1.0 (build 3.1.0-4.0.dev) • DevTools 2.23.1

More information
I recently upgrade from version 1.6.0 to 1.7.2 (along with other dependency updates).
Maybe this issue is related to the upgrade from dart: ">=2.19.0 <4.0.0" to dart: ">=3.0.0-134.0.dev <4.0.0".
I hope you can help me!

It's because you're on Flutter beta or master, switch to Flutter stable and it will work. :)

Sadly, this error remains with version 1.7.0:
Error (Xcode): ../../../../../.pub-cache/hosted/pub.dev/flame-1.7.0/lib/src/components/core/recycled_queue.dart:23:7: Error: 'Iterable' can't be used in both 'extends' and 'implements' clauses.

Downgrading to 1.6.0 works for now... not sure if you want to close this bug or need further details for fixing it. please let me know

It's not Flame that you have to downgrade, it's Flutter.

This is solved to work with Flutter Beta in Flame v1.7.3


ACCUMULO-4496 Update user manual and error messages for FATE upgrade …

…failure.
Updated the user manual and the log message generated when outstanding
FATE transactions cause upgrade to fail.

@EdColeman, this looks good.  Do you want me to merge it?


Update ko.yaml to use different base image

Switching to static since libssl and glibc are not needed, and removing debug since a shell is not needed.

Summary

Release Note

Documentation

@cpanato Just wanted to double check, I removed the comment saying we need a shell, this is no longer needed, correct?

yes, but let me run a couple of tests :)


Revise copyright section of README.md

We should revise the copyright section in the LICENSE file as it's currently says the following: Copyright {yyyy} {name of copyright owner}

Thanks, just fixed it


cluster_telemetry_server_name missing from the configuration reference page

Where is the problem?
https://docs.konghq.com/gateway/2.7.x/reference/configuration/#hybrid-mode-data-plane-section
What happened?
For PKI mode clustering there is an option to set the expected cluster_telemetry_server_name, however this setting is not documented in the configuration reference page
What did you expect to happen?
In the hybrid-mode-data-plane-section we should document the cluster_telemetry_server_name setting
Code of Conduct and Community Expectations

[X] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

This is now documented: https://docs.konghq.com/gateway/3.1.x/reference/configuration/#cluster_telemetry_server_name


Technical documentation steps

What steps do we need to do to make our technical documentation happen?

[X] Decision: Q: Which repo? A: This one.
[ ] Update README template by updating READMEs on 3 components.  (@TODO Pick 3 components & schedule collaborative writing session)
[ ] Get a design / content requirements (in progress)
[ ] Add a docs generating script that grabs all the READMEs and applies them to whatever layout Design creates
[ ] Decision: is site going to use our design system components?
[ ] sample.html injection into auto documentation. Aaron has a note on this - connect this idea to the documentation generator.

This is underway and handled elsewhere.


When Verzend MQTT Berichten (Sec.) is set to 0 no messages are send to MQTT

When Verzend MQTT Berichten (Sec.) is set to 0 no messages are send to MQTT. I would expect that when 0 is configured there is no rate limit active and all messages are send without any limit instead of nothing.

correct
0 = off
1 = fastest (direct after p1 data has been successfully read) ... for v5 meters
10s is fastest for v2/3/4 meters


Unexpected behaviours after a screen orientation change (reported by activity)

I developed an automatic test case generation tool and it detected these problems in your app.
I would like to know if you consider them as failures and, if not, why. Thanks for your collaboration.

When I change the orientation of the device screen, ViewTaskActivity changes its state. Below there are different examples: the screenshots were taken before and after the screen orientation change and they are paired (before, after), (before, after) ...

-- first case --
The "Confirm delete" textView disappears.

-- second case --
The menu disappears

-- third case --
"123test123" bar becomes larger

-- fourth case --
"X" becomes "="

When I change the orientation of the device screen, TaskListActivity changes its state. Below there are different examples: the screenshots were taken before and after the screen orientation change and they are paired (before, after), (before, after) ..

-- first case --
It changes from "Task progress" to "Search"

-- second case --
The menu disappears.

When I change the orientation of the device screen, SyncSettingsActivity changes from "Syncronized Lists" to "Displayed Lists" .

ManageListActivity,  when I change the orientation of the device screen, changes its state. Below there are different examples: the screenshots were taken before and after the screen orientation change and they are paired (before, after), (before, after) ..

-- first case --
The "Delete my tasks" Dialog disappears.

-- second case --
The symbol "+" in the background disappears

EditTaskActivity,  when I change the orientation of the device screen, changes its state. Below there are different examples: the screenshots were taken before and after the screen orientation change and they are paired (before, after), (before, after)

The "Cut, Copy, Paste" bar disappears

The Dialog with the clock disappears

The activity doesn't keep the scroll position

Thanks for the reports. I consider most of them bugs, but not all of them, for instance in Google's own apps an open overflow menu disappears when you rotate the device.
At present I'd give this a pretty low priority though, because the user pain is probably not that high. We've certainly bigger issues to fix.
That being said, any help with these is certainly appreciated nevertheless.

OK thank you very much!


⚠ Bofrost.fr has degraded performance

In 89d197c, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1358 ms

Resolved: Bofrost.fr performance has improved in 7dd5879 after 10 minutes.


Fix typo in customToJSON documentation

This pull request fixes Issue #7337.
It fixes a typo in the customToJSON section of the Sails.js documentation. The word action2 was corrected to action.

Hey @dushmanta05 thanks for the PR on first look it may look like a typo but actions2 is an actual concept in Sails and that line in the docs was referring to whether you use res.send with classic(Express-like) actions or the modern machine implementation of actions called action2.
You can see here for more on actions2.
You can also see this reference in the docs for actions2

@dushmanta05 I am closing this PR now thanks for taking out the time for submitting this. 💯

@DominusKelvin Thanks for the confirmation.


Can we not cluster the current location Marker?

I have a current location maker

but when clustering, this marker is wrapped and disappear

Can we not cluster the current location Marker?

I had the same issue, i resolved it by passing an additional prop to the User Location Marker.:
 <Marker           // Disabling ts check here on purpose for the clustering library to not           // eslint-disable-next-line @typescript-eslint/ban-ts-ignore           // @ts-ignore           cluster={false}           .......         >           <LocationMarkerIcon />         </Marker>

I had the same issue, i resolved it by passing an additional prop cluster={false} to the User Location Marker.:
 <Marker // Disabling ts check here on purpose for the clustering library to not // eslint-disable-next-line @typescript-eslint/ban-ts-ignore // @ts-ignore cluster={false} ....... > <LocationMarkerIcon /> </Marker>

cluster={false} is not working
my version of react-native-map-clustering is 3.4.2

I had the same issue, i resolved it by passing an additional prop cluster={false} to the User Location Marker.:
 <Marker // Disabling ts check here on purpose for the clustering library to not // eslint-disable-next-line @typescript-eslint/ban-ts-ignore // @ts-ignore cluster={false} ....... > <LocationMarkerIcon /> </Marker>

cluster={false} is not working
my version of react-native-map-clustering is 3.4.2

cluster={false} it's working for me and my version of react-native-map-clustering is 3.4.2 @abhatia-lix and @VladRDV

I use 3.4.2 @marchiartur but it's not working.

Hi, are there any workarounds?

Hi, are there any workarounds?

try to update to 3.4.2

cluster={false} it's working for me, tks @abhatia-lix


100% mem and disk usage, when use "save" cmd

Describe the bug
when use "save" cmd in Another Redis Desktop Manager, 100% mem(from 6.1G up to 15.1G) and 100% disk usage(write c:\windows\system32\store\checkpointxxx,c:\windows\system32\objectstore\xxx).
my config：
{
"Port" : 6379,
"MemorySize" : "1g",
"LogDir": "c:\temp\_garnet\",
"EnableStorageTier": true,
/"EnableAOF": true/
}
use nuget v1.0.8 ,in .net 8 woker service project, host in windows service.
Is that my config error or bug?
Steps to reproduce the bug
1,start garnet service.the cache is empty.
2,open Another Redis Desktop Manager V1.5.2.
3,input cmd "set ka aaa" enter,"set kb bbb" enter,then input “save" enter。
4,garnet process write c:\windows\system32\stroe\checkpoint** crazy ,and memory up to the max.
Expected behavior
No response
Screenshots
No response
Release version
V1.0.8
IDE
No response
OS version
windows 10 pro 22h2
Additional context
No response

The default hash table size is unfortunately set to very high (8g) so this is an expensive flush operation. Please use --index to reduce the hash table size to a reasonable size such as 1m. See this link for how to configure hash size for your workload. We will update Garnet to use a better default.
You have not specified checkpointdir so the checkpoint will get written in the default location. Suggest you use --checkpointdir to specify the checkpoint folder.

Very Thanks..I try it.
It would be even better to give a default configuration file for diffrent usage scenarios。


Too Long README & Wiki Request

Wiki pages can be created by separating the important parts instead of the too long readme file. I think that's absolutely necessary for better understanding and life-saving. :)
Thanks!

The README will stay. If you’d like the book separated by pages you can buy the PDF/Ebook version.
Thanks 👍


Add log/exp table based implementations for fields up to 16 bits

I haven't looked at the code but I think it will be helpful to have a separate file for only the huge tables.


add timezoneid to request

@jay-lee00 wrong branch. Parent base commit should have been v1.20.7. Going to merge and then cherry-pick.


Nodeport GCE e2e fixes

Big thing is that we need to tell the test scripts to open the firewall rules for NodePorts for e2e tests.  This is in the test-specific bit of gce/gke utils.sh.  I expect these should be moved so that the NodePort range is always opened for users (unless they directly ask otherwise), but I think that warrants more consideration, and I know we want to get e2e passing again.
WIP while I test myself with a full -down & -up.
The other issue is that I lost a line in my git-work that puts the NodePort to 0, which is required when changing from NodePort -> ClusterIP.
cc @dchen1107

Just got this to work, so no need to manually open any NodePort ranges for e2e tests!

so no need to manually open any NodePort ranges for e2e tests

Does that mean we don't need the extra firewall rule?

Sorry, what I mean is that previously I had set up this rule manually, and I was concerned that this would be problematic for automated testing.  I don't know that we're ready to have these ports be opened up for everyone that runs cluster/kube-up.  However, it seems pretty safe to do it only for e2e testing.
Expect a follow up PR to open it for all users, but we'll want to think that one through pretty carefully.  I don't think the security threshold needs to be as high for our e2e setup!

LGTM

LGTM. @justinsb I am merging this one to run jenkin for tonight. Will let you know the result tomorrow.

Expect a follow up PR to open it for all users, but we'll want to think that one through pretty carefully.

Agreed that we'll need to consider this carefully. FYI, this is going to break GKE's e2e testing since these extra ports will not be opened on the GKE cluster where the e2e tests run.

I'm not at all sure that we want to open these ports in general.  We
usually err on the side of caution regarding opening up firewalls.
On Fri, May 22, 2015 at 9:15 PM, Robert Bailey<EMAIL_ADDRESS>wrote:

Expect a follow up PR to open it for all users, but we'll want to think
that one through pretty carefully.
Agreed that we'll need to consider this carefully. FYI, this is going to
break GKE's e2e testing since these extra ports will not be opened on the
GKE cluster where the e2e tests run.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/8728#issuecomment-104833599
.

Justin: Something we may want to change for more compat (short term): We
currently retain publicIPs but don't use it.  Maybe we should reinstate the
kube-proxy support for public IPs, until we kill off that field along with
v1b3.  Not sure how I missed that before.
On Fri, May 22, 2015 at 9:16 PM, Tim Hockin<EMAIL_ADDRESS>wrote:

I'm not at all sure that we want to open these ports in general.  We
usually err on the side of caution regarding opening up firewalls.
On Fri, May 22, 2015 at 9:15 PM, Robert Bailey<EMAIL_ADDRESS>wrote:

Expect a follow up PR to open it for all users, but we'll want to think
that one through pretty carefully.
Agreed that we'll need to consider this carefully. FYI, this is going to
break GKE's e2e testing since these extra ports will not be opened on the
GKE cluster where the e2e tests run.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/8728#issuecomment-104833599
.

@thockin OK, I can do that.  I know some people would want the ability to totally prevent public IP specification, but if it is going away I will reinstate it until we are ready to remove support for it.  Sorry for removing it!

As for the need for firewalls - can we do e2e to node ports without
traversing outside the GCE project?  That should dodge the need for
firewalls.
On Fri, May 22, 2015 at 9:28 PM, Justin Santa Barbara <
<EMAIL_ADDRESS>wrote:

@thockin https://github.com/thockin OK, I can do that. I know some
people would want the ability to totally prevent public IP specification,
but if it is going away I will reinstate it until we are ready to remove
support for it. Sorry for removing it!
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/8728#issuecomment-104839169
.


Different namn on project id and project name don't update files

I have a project where the project id (in the url) is  nicon2-q22kwn and the project name is nicon. This result in the strange behavior that the catalogs is created/updated but the files inside is not, and if starting from a clean project, there will be no files.
After I changed the project name to nicon2, all the files was updated.

Yep, there seems to be a bug in the extension. When the project name is different than the project id, the getProjectFolder() function returns a different folder name than what is actually created by flutterflow_cli, and the files aren't properly copied over.
Would love to see a fix for this, I would definitely start using the extension! For now I'm defaulting back to using a chain of commands to automate the code download and doing a hot reload.


nixos/top-level: pass activation scripts as files

This stops Bash from complaining "Argument list too long" due to very large activation scripts.  Related: ryantm/agenix#227.
Description of changes
This PR updates the activatable system derivation to pass activationScript and dryActivationScripts via files rather than via environment variables.  Activation scripts are liable to grow large enough to make Bash/Linux complain about illegally large argument lists; see the above-linked agenix issue for one such example.
Incidental change: move the passAsFile definition, previously in the body of the baseSystem system derivation definition, into system.systemBuilderArgs, making it possible to extend it with [ "activationScript" "dryActivationScript" ] elsewhere.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Cargo-culting some OfBorg stuff from a recent-ish PR touching the same areas...:
@ofborg test switchTest
@ofborg test simple
@ofborg test nixos-rebuild-specialisations


Move docs test out of functional test buckets

Since long time ago, docsTest are part of functional tests, but actually it's quite different:

We don't want to run docsTest with different executors.
We have to handle docs specially in bucket split.
It's hard to create new ConfigCacheDocsTest.
docs:checkSamples was running in every split.

This PR moves docs out of functional tests and creates a DocsTest build type. This way, we handle docsTest independently.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge


Recipe conflict

Well, sort of. Refined Storage autocrafting upchucked massively when it came to Mekanism steel and Refined Storage silicone. I had setup my autocrafting furnace to input one sand and get out one silicone. After installing the mod that changed to one sand for one silicone ingot. Same with every other recipe for silicone. Though, through trial and error, I figured out that a silicone ingot can be substituted for the silicone and I changed both the autocrafter pattern on the furnace so Refined Storage would recognize it was finished making silicone, and had to change the autocrafting recipe on the Solderer to accept one silicone ingot in to get one printed silicone. I had to do something similar so that the autocrafter would know that it had gotten the steel from autocrafting it though Mekanism. The final step was one steel dust in and get one steel ingot out and the autocrafter sat there waiting to get the steel and would not complete until I changed the recipe to be one AR steel ingot out then it started to work again.

if this issue still occurs please comment and reopen the issue.


calling out concat version

Fixes #66
There was at some point a concat 2.0.1 pushed accidentally. It was in the repos and librarian was trying to pull it down automatically despite it having been deleted.
This forces the version.

The fix must be added to slave and repo as well, otherwise it will fail for them.

@ipa-mdl Thanks added in c3f3716c1db11fae1469ccdbc0eec61b72a27aec


[BEAM-8647] delete .mailmap

side note: if you really need this file  (like for the website) maybe use a private asf repo and ensure it is not in a public deliverable

R: @kennknowles

R: @iemejia

I think we are not using this file any more so ok to remove can you confirm @kennknowles

For extra info the discussion on privacy-discuss@ on how to handle these cases (conclusion nothing is clear and we do not have real ASF recommendations yet)
https://lists.apache.org/thread.html/ra3dc372d3bcbcfa675e1e68867fceebc00aec0562d4c787a36f42562%40<privacy-discuss.apache.org>

@iemejia yes and no, 1. it is quite clear in europe and affects US based entities + 2 ASF can't justify to need this file (side note: it can trivially be replaced by GH API nowdays).
Lastly the overall PR was "by fun" and rather -1 (https://github.com/apache/beam/pull/1925) than +1 so I think it confirms it is just not used and it does not hurt to drop so no real need to discuss for year on that. If a better mapping is needed I suspect gh API can be used, a small script can be added to beam and .mailmap can be generated locally and added to .gitignore instead of explicitly exposing it (to scrappers/crawlers).

I do not believe we are using this file. I could not find a reference to it in any process documents. I agree that, it does not make much sense to keep this information in the repository. Also noting that removing this does not add much to the level of privacy, the same information is already publicly available in git log, or github apis.

@rmannibucau Do you need more help to move this forward? Or did you find an alternative way, if so can this PR be closed?

@ajamato I just need somebody hitting merge button ;). The side note to @aaltay comment is that it is easier to bulk clone that to bulk GET (api) due to the rate limits, so often scrappers use clone rather than the API.

This file is very useful for producing the release notes and integrating with various git stats tools. It is just a reformatting of information available in the git log. I will read the linked thread.

FWIW I am not sure everyone on this PR is familiar with the file. It is a config file to help git pretty print the log.
See the "List Of Contributors" on https://beam.apache.org/blog/beam-2.22.0/. Without this file, the list will have duplicate entries like Kenneth Knowles<EMAIL_ADDRESS>and Kenn Knowles<EMAIL_ADDRESS>and possibly some that are just<EMAIL_ADDRESS>etc. The file is a hint to git to de-dupe these when printing the log.
If anything, using GitHub APIs is worse, because it associates actual registered accounts that are connected to other information. All this file does is associate strings that already exist in the log.

I see now that the thread link that Ismaël provided is the root discussion that we should follow to resolve this. I want to emphasize that also individual requests to remove information from this file I would of course support. Anyone removing their information should be warned that it does not protect the information or make it less public.

@kennknowles the argument that it is public for github so it can be made public in the git repo is wrong, when you have a github account you ack or not that and you can request to drop it due to GPDR so this file should be regenerated each time github changes anything (I assume once a day would work). Also, project must request authorization to use these data there and track ack+enable to change it to be legal. AFAIK none of both is done (right?) so this workflow does not work and can trivially be replaced by a github request - with a falling back on "unknown" or anything you like when the email is no more available- companies can request github to  become GPDR compliant which means data can be missing. You can also reverse the pattern and just list duplicates instead and handle the name in a case insensitive manner maybe? This reduces the number of entries a lot AFAIK.

I am not arguing that "it is public for GitHub so it can be made public in the git repo". This file is not based on any GitHub data. It is based entirely on the git history itself.

Can it be done reopen and fixed please?

up


Package.json not working

ok so i got all the stuff downloaded, NodeJS 5.5.0 stable, HellsAngle github and all that.
Windows 10, japan local so i can play japanese games as well.
I did npm install at the game folder and it messes up when I run npm start
here is the log
http://pastebin.com/UVghsU12
also only using command prompt

Oh my, I wonder how long that has been a thing...
Anyway, there was definitely a problem in package.json, so I just committed a fix for that... Could you try again with the most recent commit and see if that works?

That fixed it, thank you.

Hey, no prob. Thanks for reporting the issue..!
Everything is still so early in development that I'm not sure how long it would have been until I looked at package.json.


How to add drawer navigation to tabs navigation

💬 Question
I am a fairly new React-Native developer. I still have not picked up TypeScript, so I'm struggling to convert your TS code into plain RN code. I have read all of your get started docs and gone through it step by step. I also read your entire blog post on React-Navigation 5 and UI kitten. I downloaded the code repo for that too. But since it is using TS, I'm finding it difficult to convert it to plain RN(JS) code.
Here is my navigation.component.js file:
`
import React from 'react';
import {NavigationContainer} from '@react-navigation/native';
import {createBottomTabNavigator} from '@react-navigation/bottom-tabs';
import {
BottomNavigation,
BottomNavigationTab,
Layout,
Text,
Icon,
Tab,
} from '@ui-kitten/components';
import {HomeScreen} from '../screens/home.component';
import {DetailsScreen} from '../screens/details.component';
import {RequestScreen} from '../screens/request.component';
const HomeIcon = (props) => <Icon {...props} name="home" />;
const DetailIcon = (props) => <Icon {...props} name="list" />;
const RequestIcon = (props) => <Icon {...props} name="clipboard" />;
const {Navigator, Screen} = createBottomTabNavigator();
const BottomTabBar = ({navigation, state}) => (
<BottomNavigation
selectedIndex={state.index}
onSelect={(index) => navigation.navigate(state.routeNames[index])}>

);
const TabNavigator = () => (
<Navigator tabBar={(props) => <BottomTabBar {...props} />}>

);
export const AppNavigator = () => (

);
`
In reading and watching React-Navigation 5 tutorials I should be able to add a drawer navigator by simply creating a drawer navigator and then referencing the Tab navigator in one of the Drawer.Screen entries.
How can I do the same with UI Kitten components and React-Navigation5 components?
UI Kitten and Eva version

Package
Version

@eva-design/eva
2.0.0

@ui-kitten/components
5.0.0

I created a new component with this code:
drawer.navigation.component-js.txt
And it leads to this error:

@exlnt you're missing the concept of object destruction usage.
There is no TNavigator and TScreen in object returned by createBottomTabNavigator


(Migrated) Euclidean Distance Algorithm for Recommender (lorna)

Add TODO to html to include the top 5 recommendations
Add minor formatting corrections
Add import statements for List and Entity

note: I made a separate branch so that Rania has all of the approve/comment etc. options as otherwise, if it was onto the algorithm branch, this isn't possible as you can't request changes on your own branch etc.

UI:

Migrated to another branch due to more complicated commit issues.


crash when getting list of snapshots

Description
I have deployed k8up via helm chart version 4.3.0 with no custom values. I have then set up a simple hourly backup schedule for a namespace with several volumes.
Restic backup itself seems to work fine but it seems that backup pod crashes after "restic backup" step at the "restic snapshots" step.
Due to this crash at the end, the whole backup is considered to have failed.
Due to pod crashloop, I end up with 6 new restic snapshots for each volume and each backup invocation :)
Restic repo is healthy, I can run "rest snapshot", "restic check" and "restic check --read-data" from local restic cli with no issues.
I can also run
restic snapshots --option "" --json

locally without crash.
Additional Context
k8s is AWS EKS 1.24
Logs
2023-07-03T19:04:00Z    INFO    k8up.restic.restic.backup.progress      restic output   {"msg": "Warning: at least one source file could not be read"}
2023-07-03T19:04:00Z    INFO    k8up.restic.restic.backup       backup finished, sending snapshot list
2023-07-03T19:04:00Z    INFO    k8up.restic.restic.snapshots    getting list of snapshots
2023-07-03T19:04:00Z    INFO    k8up.restic.restic.snapshots.command    restic command  {"path": "/usr/local/bin/restic", "args": ["snapshots", "--option", "", "--json"]}
2023-07-03T19:04:00Z    INFO    k8up.restic.restic.snapshots.command    Defining RESTIC_PROGRESS_FPS    {"frequency": 0.016666666666666666}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x141887e]

goroutine 1 [running]:
github.com/k8up-io/k8up/v2/restic/kubernetes.filterByRepo(...)
        /home/runner/work/k8up/k8up/restic/kubernetes/snapshots.go:123
github.com/k8up-io/k8up/v2/restic/kubernetes.SyncSnapshotList({0x1a42388, 0xc0002f6380}, {0xc000876000, 0x286, 0x0?}, {0xc000048009, 0xa}, {0xc00004c012, 0x2d})
        /home/runner/work/k8up/k8up/restic/kubernetes/snapshots.go:29 +0x35e
github.com/k8up-io/k8up/v2/restic/cli.(*Restic).sendSnapshotList(0xc000174000)
        /home/runner/work/k8up/k8up/restic/cli/backup.go:116 +0x19b
github.com/k8up-io/k8up/v2/restic/cli.(*Restic).Backup(0xc000174000, {0x17bcee5, 0x5}, {0x0, 0x0, 0x0})
        /home/runner/work/k8up/k8up/restic/cli/backup.go:46 +0x2da
github.com/k8up-io/k8up/v2/cmd/restic.doBackup({0x1a423c0?, 0xc00004e020?}, 0xc000456360?, {{0x1a44e50?, 0xc000456360?}, 0xc00014a2a0?})
        /home/runner/work/k8up/k8up/cmd/restic/main.go:234 +0x105
github.com/k8up-io/k8up/v2/cmd/restic.run({0x1a423c0, 0xc00004e020}, 0x1a44e50?, {{0x1a44e50?, 0xc000456360?}, 0x1a30ec8?})
        /home/runner/work/k8up/k8up/cmd/restic/main.go:129 +0xbf
github.com/k8up-io/k8up/v2/cmd/restic.resticMain(0xc0004af700)
        /home/runner/work/k8up/k8up/cmd/restic/main.go:113 +0x2a7
github.com/urfave/cli/v2.(*Command).Run(0x2598960, 0xc0004af700, {0xc00014db90, 0x1, 0x1})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.7/command.go:271 +0xa42
github.com/urfave/cli/v2.(*Command).Run(0xc000002f00, 0xc0004af000, {0xc00003e060, 0x2, 0x2})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.7/command.go:264 +0xc97
github.com/urfave/cli/v2.(*App).RunContext(0xc0003d8000, {0x1a423c0?, 0xc00004e020}, {0xc00003e060, 0x2, 0x2})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.7/app.go:333 +0x665
github.com/urfave/cli/v2.(*App).Run(...)
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.7/app.go:310
main.main()
        /home/runner/work/k8up/k8up/cmd/k8up/main.go:30 +0x45

Expected Behavior
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x141887e]

should not occur :)
Steps To Reproduce
apiVersion: v1
kind: Secret
metadata:
  name: backup-repo
type: Opaque
stringData:
  password: XXX
---
apiVersion: v1
kind: Secret
metadata:
  name: s3-credentials
type: Opaque
stringData:
  username: XXX
  password: XXX
---
apiVersion: k8up.io/v1
kind: Schedule
metadata:
  name: schedule
spec:
  backend:
    s3:
      endpoint: http://minio.svc-minio:9000/
      bucket: k8s-pv-backups
      accessKeyIDSecretRef:
        name: s3-credentials
        key: username
      secretAccessKeySecretRef:
        name: s3-credentials
        key: password
    repoPasswordSecretRef:
      name: backup-repo
      key: password
  backup:
    schedule: '0 * * * *'
    failedJobsHistoryLimit: 2
    successfulJobsHistoryLimit: 2
  check:
    schedule: '0 1 * * 1'
  prune:
    schedule: '0 1 * * 0'
    retention:
      keepLast: 5
      keepDaily: 14

Version of K8up
4.3.0
Version of Kubernetes
1.24
Distribution of Kubernetes
AWS EKS

Whoops, sorry,  I also saw it a couple of minutes ago.
I blindly copied
kubectl apply -f https://github.com/k8up-io/k8up/releases/download/v2.2.0/k8up-crd.yaml

from
https://k8up.io/k8up/tutorials/tutorial.html
Now using the latest version 4.3.0 of the CRDs and everthing is fine :) Thanks :)

But that's a good point, we should probably have the command there point to the latest tag :)


Add swagger api integrations

Integrate swagger for api documentation

@harshmangalam  Assign to me please

Thanks assigned

Any updates @corners2wall on swagger ?


refactor(dao/utils): Move general createRelationshipFilter from Neo4jUtil to QueryUtils

These methods are not Neo4j-specific so they can be moved out of Neo4Util. This removes Neo4jUtil imports from classes (in datahub), that have no other reference to neo4j.
Besides moving these two methods into QueryUtils, this renames them to match existing methods in the target utils class.
This breaks datahub, which is fixed in linkedin/datahub#3010.

@jplaisted @gabe-lyons what do you think?

@jjoyce0510 this is required by linkedin/datahub#3010

I'm no longer on this project, this seems like a good idea to break the coupling here. Since this a breaking change maybe bump the semi major version here
https://github.com/linkedin/datahub-gma/blob/master/version.properties

maybe bump the semi major version here

@jplaisted Thanks for the pointer. You probably mean the minor version like 0.2.* -> 0.3.*.


Use Issues for feature requests instead of Github Discussions

I'm doing that here though.....no? I'm confused :)

bah! ignore me.


Add metadata to routes and apps

closes #789

seems sane to me, some minor comments

Have dealt with most of the comments  I think -
I've ended up doing a bit of refactoring in the API tests to try and simplify the test harness a bit, and remove the "global delete everything" step in favour of requiring a defer s.Cleanup() in each test.  There is more to do there.
I've ended up puting the bulk of the e2e testing in the API tests  - getting veracity on validation is hard anywhere else (which is fine, I think).
The SDK dep for testing is a) inconvenient as you have to round trip  fn_go  to test new API features, and also a bit fluffy w.r.t. API semantics - would prefer a pure JSON model client in the API tests for correctness, might look at this in future.
I'm knowingly not validating pure deltas on patch which (validate irrespective of current values) - this  allows poisoned /bad existing values in the DB to block all updates.   Thought about this but I think this entails some more contract "ValidateChange(patch)" sort of thing on the data objects which i stopped at.

one niggle, otherwise LGTM

Just spoke to @tteggel  and @shaunsmith  - they prefer "annotations" here - vs "metadata" - I think I agree - will make that change now

this should be merged along-side https://github.com/fnproject/fn_go/pull/6 (I've naively pushed that version into vendor for builds sake in this PR)


Provide Support for "Map color scheme" to display map in Dark Theme

Provide support for Map color scheme as implemented in the non-compose version of the Maps SDK.
Is your feature request related to a problem? Please describe.
I am unable to display Google Maps in Dark Theme.
Describe the solution you'd like
To be able to configure a google maps to display in Light Theme or Dark Theme.
Describe alternatives you've considered
A possible workaround is to render with a custom styled Map; however, this is compatible only with a map set with mapType = MapType.NORMAL.
Additional context
My application allows the user the choose Light Theme, Dark Theme, or to follow the System's UI Theme.

#591

@RyeGordo please close the issue


Update TouchFrameLayout.java

 Issue by viyski
Tuesday Apr 02, 2019 at 03:42 GMT
Originally opened as https://github.com/android/android-ConstraintLayoutExamples/pull/73

to fix the TouchFrameLayout mothod getMotionLayout() comes be null

viyski included the following code: https://github.com/android/android-ConstraintLayoutExamples/pull/73/commits

 Comment by googlebot
Tuesday Apr 02, 2019 at 03:42 GMT

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.


Question/Gap - Availabilities on offer stage?

Should the standard support availability searches at offer stage? (Currently a reservation is needed as context) We see a use case for it, but also recognise the potential difficulty in providing the data.

This might be a flow problem. Specifically for night trains, we will not have the place preferences set before the offer is requested. Before booking the journey, the number of places in gendered compartments is needed. There are of course ways of working around this, so let us discuss.


Should signin view redirect to / if already logged in

Currently, it is possible to go to the login page even if a user is already logged in. Should it redirect if someone goes it while already logged in?

No, It wont go. No user can visit the login page after the successful login.

Then maybe I have some incorrect implementation since I can still the login page:
…/accounts/signin/
…/accounts/signin/?next=/ […]

So yeah this is funny issue. In my opinion no one can say for sure what is the best approach for this case. For some it may be surprising behaviour but for others it may be a desirable feature in some projects:

Tired of signing out your wive's session just to log into your account? Now you can just put your credentials while she is logged in and forget about "sign out" button!

But now let's be serious. In my personal opinion it's not a really big deal and depends on UX you are planning to provide. Probably you definitely should hide "sing in" button link for logged users if you don't want them to easily access this view. But what is the purpose in being so picky on limiting users freedom to access urls?
It is better to leave default behaviour that gives more flexibility than make opinionated decision. Also, this is already the default behaviour of django.contrib.auth.login view (see code). It is easily configurable through settings passed in urlconf. Userena signin does not have such parameter but you can easily decorate it:
from userena.views import signin

def my_signin_view(request, **kwargs):
    if request.user.is_authenticated():
        # do whatever you want
        return HttpResponseRedirect('whatever')
    else:
        return signin(request, **kwargs)

We can of course add this to signin view as an option but the default behaviour will most likely stay as is now for the following reasons:

It is also the Django's contrib.auth default behaviour.
Some developers may want being able to "sign in while being signed in" so such option must stay anyway
What to do in that scenario is purely a matter of developer's/designer's preference so it is better to leave old behaviour as default than break backwards compatibility (IMHO)

If we consider adding such configurable option to signin view then we need to make few decisions:

How to handle such attempts to view login page of signed users? Error? Redirect? Redirect where?
Should we make it configurable through view params in url conf or maybe through custom userena settings variable?

I leave this discussion open because I would like to hear your opinion.


Population size max number

Hi!
I am generating health records, but I would like to generate a big sample. Which is the maximum number of population it could generate? (living patients) is it any restriction?

No individual run of Synthea can produce more than<PHONE_NUMBER> patients (that's over 2 billion), but you can certainly run multiple times using different seeds to produce a larger aggregate patient set if that's not enough.
If you're using FHIR or CCDA each patient record can be up to several MB in size, especially for older patients that have a lifetime of medical history, so be aware that the storage requirements for large patient datasets is very substantial. As one data point, we recently generated a population of roughly 6 million patients, and the FHIR data is nearly 20 TB uncompressed.

Thank you for your reply. Excuses if my next question is a bit silly. The seed number could be any random value? or is it specified in a file?

The seed is a number that is used to setup the randomness in the simulation. The idea is that using the same seed means the same numbers always get picked in the same order, so in a simulation like Synthea, using the same seed and all the same settings for 2 runs means you get 2 identical populations. In your case I mention the seed just to make sure you don't specify the same seed twice and then get the same population twice.
You can either specify a seed using the -s flag, and yes it's allowed to be any random value, or if you don't specify one synthea will pick one automatically based on the current time in milliseconds, so if you run 2 in a row they will have different seeds.
Ex,
java -jar synthea-with-dependencies.jar -s 12345
or
run_synthea -s 12345


iCubSingapore01 migration from MotioncontrolVersion 4 to 6

see commit dda90b9a0bf2a59fe389294a95a0f8992913d04b

the files seems ok.
i have however spotted some differences in a very few PID values.
For example, in file head-eb21-j2_5-mc.xml  some values in POS_PID_DEFAULT have slightly changed.
+ <param name="kp">                       1100.00     -1000       3500        3500        </param>
- <param name="pos_kp">                   1100.00     -200       3500        3500        </param>

and
+ <param name="ki">                       0.0         -100        600.0       600.0       </param>
- <param name="pos_ki">                 0.0         -300         600.0       600.0       </param>

The variation in the joint number 3 of the head is small and probably would not affect performance, but it is wise to keep values absolutely equal, hence please correct them.

@marcoaccame fixed

Hi @davidetome, thanks for your changes.
I have spotted some other minor issues and i have committed myself.
I believe that now we can merge.


A method to know center item

Contact Details
No response
Is your feature request related to a problem? Please describe.
Yes
Describe the solution you'd like
Hello, i want to get the center item index in carousel as i has youtube player with autoplay enabled so i  want to play videos only if widget is in center else pause
Describe alternatives you've considered

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi @nixrajput,
I’m facing the same issue with getting the center item index in the carousel and really need this feature. Any updates would be appreciated!
Thanks!


Chatterino crashes when opening any emote link

Describe the bug

Chatterino crashes when opening any emote link.
To reproduce

Right click any emote.
Select the open option and then any size.
The link opens in the default browser, but chatterino crashes.

Screenshots

Chatterino version

Chatterino Nightly 2.1.7 (commit 682caf6b6, )
Operating system

Windows 10
Additional information

This seems to be a Windows specific bug. Bug was reproduced on another Windows 10 machine. Chatterino didn't crash on linux manjaro/arch/artix.

Can reproduce. Windows 10 2004 Nightly 2.1.7 (commit 682caf6b6, 05.07.2020)

bug was introduced in cdf85c50840825ed64bfae97fb4a25b8b11c6860

@pajlada https://github.com/Chatterino/chatterino2/commit/d25dee10b2f5d9491bdc32ed2e224b2066f6c647 seems to have resolved the issue


Problem definition examples conflict with application contexts

Deleted or substituted the examples with generic values.
The problem definition is generic and we guide to use it in all error return situations -- see https://opensource.zalando.com/restful-api-guidelines/#176
Concrete example values in the problem definition lead to confusion because the examples are used in the generated documentation, and then don't fit with the values valid in the application context of specific http status response definitions.

:+1:

👍


bug? interaction between multiple pipenv shells

I'm working on multiple projects at once, all using pipenv. I've noticed that if I start pipenv shell in project A root, and then move to project B and try to start pipenv shell again, it tells me that the shell for B is already activated. So pipenv is automatically switching between shells? Is this the desired behavior?
More concerning is that when I pipenv install an external package in project A, and then move to project B root and pipenv install it again I get something like:
$ pipenv shell
Shell for ws-storage-5jC_NMuk already activated. No action taken to avoid nested environments.
$ pipenv install --dev toml
Installing toml...
Requirement already satisfied: toml in /home/bob/.local/share/virtualenvs/ws-sheets-server-rkQt47xA/lib/python3.5/site-packages

Adding toml to Pipfile's [dev-packages]...

pipenv says its already installed, but references another project's virtualenv directory. Are my projects sharing their locally installed packages?

Further investigation...
$ mkdir A
$ mkdir B
$ cd A
$ pipenv shell
Creating a Pipfile for this project...
Creating a virtualenv for this project...
⠋Using base prefix '/usr'
New python executable in /home/bob/.local/share/virtualenvs/A-TaiTb0IT/bin/python3
Also creating executable in /home/bob/.local/share/virtualenvs/A-TaiTb0IT/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /home/bob/.local/share/virtualenvs/A-TaiTb0IT
Launching subshell in virtual environment. Type 'exit' or 'Ctrl+D' to return.
$ cd ../B
$ echo $PATH
/home/bob/.local/share/virtualenvs/A-TaiTb0IT/bin:/home/bob/bin:/home/bob/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/bob/.rvm/bin:/home/bob/.rvm/bin
$ pipenv shell
Creating a Pipfile for this project...
Shell for B-E3lxBntI already activated. No action taken to avoid nested environments.
$ echo $PATH
/home/bob/.local/share/virtualenvs/A-TaiTb0IT/bin:/home/bob/bin:/home/bob/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/bob/.rvm/bin:/home/bob/.rvm/bin

When you switch from project A to project B and run pipenv shell, pipenv says its in the B shell, but PATH tells us otherwise.
Side note, as you might have guessed, my use case involves frequently switching between projects and needing to be in the pipenv shell in each one. Before I realized the above was happening I was getting very confused. Now I at least know whats going on, but it takes an annoyingly long time to switch back and forth and make sure I'm always in the right shell...

Hey @chuck1, thanks for taking the time to dig into this.
So first off, that error message was definitely not what we intended. I've added 467c593 to address this by checking the environment variable set by virtualenv rather than assuming the activated shell is for your current project. This will be available in the next release.
Secondly, regarding the workflow you're using. What operations are you performing that require you to be inside the shell? Is it specifically because pipenv run doesn't work, or that you're running many commands and trying to avoid using pipenv run for each? I don't think we want to try guessing which virtualenv people want to use based on directory for the time being. That means whatever project you run pipenv shell in will be the active virtualenv used until you exit the session.
I'm going to close this out as resolved with 467c593, but feel free to answer the above questions or ask any others you may have. Thanks!

THank you for your response, @nateprewitt! I was running alot of commands and trying to avoid using pipenv run each time. But one simple solution would be to keep multiple terminals open. I agree that once a pipenv shell for one project is entered, it should remain the active shell until the user exits. To switch shells automatically seems like a bad idea.


Error 500 when trying to save any page

Describe the Bug
Saving a page makes a Post request returning a 500 reponse because of uninitailized property.
The page is not saved
In laravel.log the stak trace start with:
production.ERROR: Typed property DOMDocument::$documentElement must not be accessed before initialization {"userId":3,"exception":"[object] (Error(code: 0): Typed property DOMDocument::$documentElement must not be accessed before initialization at /var/www/html/bookstack/app/Entities/Tools/PageContent.php:181)
Steps to Reproduce

go a page as admin, or editor role
edit it
click on save

Expected Behaviour
The page should be saved without an error
Screenshots or Additional Context
No response
Browser Details
Firefox 106.0.5
Exact BookStack Version
v22.10.2
PHP Version
8.1
Hosting Environment
Debian 11 + nginx

Hi @AlbanDCX,
Can you confirm if this only happens on certain page content, or does it occur all the time, regardless of page content being saved? If it's dependant on content, could you share an example?
Also, could you confirm the exact output of running php -v on the command line on the system used to host BookStack.

@AlbanDCX Thanks for the info. Since you're on php8.1, are you using the deb.sury packages to get that?
Also, would you be able to share your nginx config?

Hi,
Packages come indeed from deb.sury
Here is the nginx conf
server {
listen 80 default_server;
listen [::]:80 default_server;
    index index.php index.html

    server_name docs.docaxess.com;

    location / {
            try_files $uri $uri/ /index.php?$query_string;
    }

    location ~ \.php$ {
             include snippets/fastcgi-php.conf;
             fastcgi_pass unix:/run/php/php8.1-fpm.sock;
    }

}
server {
    # SSL configuration
    #
    # listen 443 ssl default_server;
    # listen [::]:443 ssl default_server;
    #
    # Note: You should disable gzip for SSL traffic.
    # See: https://bugs.debian.org/773332
    #
    # Read up on ssl_ciphers to ensure a secure configuration.
    # See: https://bugs.debian.org/765782
    #
    # Self signed certs generated by the ssl-cert package
    # Don't use them in a production server!
    #
    # include snippets/snakeoil.conf;

    root /var/www/html/bookstack/public;
    index index.php index.html
    server_name docs.docaxess.com; # managed by Certbot

    location / {
            try_files $uri $uri/ /index.php?$query_string;
    }

    location ~ \.php$ {
             include snippets/fastcgi-php.conf;
             fastcgi_pass unix:/run/php/php8.1-fpm.sock;
    }

    listen [::]:443 ssl ipv6only=on; # managed by Certbot
    listen 443 ssl; # managed by Certbot
    ssl_certificate /etc/letsencrypt/live/docs.docaxess.com/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/docs.docaxess.com/privkey.pem; # managed by Certbot
    include /etc/letsencrypt/options-ssl-nginx.conf; # managed by Certbot
    ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem; # managed by Certbot

}
server {
if ($host = docs.docaxess.com) {
return 301 https://$host$request_uri;
} # managed by Certbot
    listen 80 ;
    listen [::]:80 ;
    server_name docs.docaxess.com;
    return 404; # managed by Certbot

}

Hi @AlbanDCX,
I just created a replica debian 11 setup with the exact same PHP version and I used your nginx config as a basis, but could not reproduce this issue and saving worked fine.
Not really sure what's going on at this stage.
Have attempted a couple things to attempt to force this error without success.
Can only find one other recent reference to something similar, and it sounds like it was a case of updating from an old php version, and having mixed packages.
Did you install another version of PHP previously on this system before installing PHP8.1? Could make sense that requirements get mismatched across different installed versions.

Hi Dan,
Thx for the clue: it's working now.
I removed php and all its packages and reinstalled them, I had some packages not prefixed by "php8.1"
Best,
Alban

Great! too to hear things are now working. Will therefore close this off.


Transition TypeError with multiple listeners

Version
3.0.5
Reproduction link
https://codepen.io/kaelwd/pen/poNNMQN?editors=1010
Steps to reproduce
Click the toggle button
What is expected?
The grey square should hide
What is actually happening?
Uncaught (in promise) TypeError: onLeave is not a function

Worked in Vue 2: https://codepen.io/kaelwd/pen/poNNMBe?editors=1010

The current implementation allows to receive an array of callbacks but calls it like a function, without checking for an array:
I assume onLeave should be called with callHook like the other hooks, but right now I'm not sure if there's any side effect with callHook's async error handling that should be taken into consideration, will need to take a closer look tomorrow after some sleep.

callHook was removed from Transition in #1145 bf84ac8.
Error handling is done by BaseTransition but callHook wasn't replaced with something that can call an array of functions if that's what it is given.
I'm happy to look at this but I'm just unclear on this condition if (!(onLeave && onLeave.length > 1)) which has to be true to call whenTransitionEnds. Not calling that means the transition never completes. But since onLeave doesn't mutate there seems to be no reason to check it's length to call or not call whenTransitionEnds?


Please auto-expand Calculation Items when opening a Calculation Group

I know there are still some outstanding requests for tree control improvements, but something that I thought would be useful and possibly easy to implement is when expanding a Calculation Group 99% of the time you want to edit a calculation item but you have to click expand twice to get there. Any chance you can give my RSI a break? :)

Fixed in 2.9.7


CommitFailureTests are flakey/order-dependent

I sometimes get errors like this when runnin all tests:

Test 'System.Data.Entity.Interception.CommitFailureTests.BuildDatabaseInitializationScript_can_be_used_to_initialize_the_database' failed:
Assert.Empty() failure
TestHelpers\DbDispatchersHelpers.cs(24,0): at System.Data.Entity.TestHelpers.DbDispatchersHelpers.AssertNoInterceptors()
Interception\CommitFailureTests.cs(857,0): at System.Data.Entity.Interception.CommitFailureTests.BuildDatabaseInitializationScript_can_be_used_to_initialize_the_database()

But then running the tests again on their own passes. This often indicates that there is an order-dependency. It seems likely that some other test is leaving an interceptor registered.

Also: DatabaseLogFormatterTests.DatabaseLogFormatter_is_disposed_even_if_the_context_is_not


Emulator bug :  NMI should be generated when accessing an unmapped address.

This may be different for writes vs reads.

NMI generation is currently implemented as timer actions generated by peripherals. NMI generation for an access that is not occupied by any peripheral is tricky.  The CaliptraRootBus is the system bus which needs to catch the access and convey that no peripheral is mapped to that address.

Hello @rusty1968 , I'm working on this issue. As of now, when you input an unmapped address(an address that is not related to any peripherals), you get an Error(of type BusError). So do we need to keep that error reporting and add NMI on top of that (or) should NMI replace that error reporting?

Hello @rusty1968 and @korran , As an initial move, I've added a dummy peripheral that generates NMI while reading from/writing to an unmapped address. I've done so by extending the proc-macro "Bus" to include NMI support.
Please let me know if you have other ideas that can further refine this design.

Hi @rusty1968 I assume what happens after NMI is not part of this issue. However, we need to trap the address that caused the NMI in a seperate register (mdseac) which will be cleared once the core gets reset (as part of NMI handling). Is this correct? If so I need to update the implementation with capturing the address that caused the NMI.


Save uris

New Feature:

Writes URIs on Publish

Tests work.  Circle is broken.

looks good :+1:


add dependency

Checks fail?

hmm, it seems the source of the problem is rworkflows. The version of mia used is outdated(not devel) with our current changes. I initially assumed it was the magick package but it seems not. However I have bumped the required devel version for now. In the next release cycle, we can restore the workflow.

This is good to go.


chore: bdd-spring-1576244425 to 0.0.1

chore: Promote bdd-spring-1576244425 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Name of package in galaxy

The name in galaxy is atosatto.docker-swarm, on your README it is a different value in your example playbook.

Thank you for reporting this. It should be now fixed.


Prefer github source for slack module to fix path bug

Purpose
Using GitHub as source for Slack terraform module to fix the path bug referenced here.

I threw some changes on here to fix an issue with nightly jobs


Add gcm in job api

Hi tkanteck,
I tried adding GCM while suppressing the change of job scheduler.

Thanks! This patch looks reasonable. I need to get my head around one of the future features and slightly adjust the patch accordingly. I need about one week to close it.

I am looking forward to it.

Merged slightly slimmed down version of the patch. GCM is available under JOB API now https://github.com/01org/intel-ipsec-mb/commit/7f176aae3e2924f1f8aed7ba2639ca2edea2445d
Thanks,
Tomasz


managed node groups with alb.ingress.kubernetes.io/security-groups annotation

When using managed eks node groups, there is no option to specify the security group used by the nodes.
When specifying the annotation alb.ingress.kubernetes.io/security-groups to use a pre-made security group for the ALB, the ingress-controller doesn't automatically create a rule to allow all traffic from the ALB security group.
How can I use managed node groups and a pre-defined security group so the limit of SGs per instance isn't reached.

Hi,

you can now use a custom securityGroup with managed node groups: https://docs.aws.amazon.com/eks/latest/userguide/launch-templates.html#launch-template-security-groups
You need to create the securityGroup for nodes and a securityGroup for LB and allow access from the LB securityGroup into the node securityGroup.
we'll add a support to use a managed LB sg(by the controller) and pre-made securityGroup together as well(https://github.com/kubernetes-sigs/aws-alb-ingress-controller/issues/1352)

closing this in favor of #1352 :D


Bugfix(Logging): Adding missing LogLevel and correct args handling in logf_* functions

Describe your changes

Adding missing Loglevel in set_logging_callback
Fixing handling args in logf_* functions

Issue ticket number and link
see title
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] I read the contribution documentation and made sure that my changes meet its requirements

I am currently writing unit tests for logging and these bugfixes. After pushing the tests I would then merge


Treat API key like a password field

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e734a29) 80.44% compared to head (ce2a433) 80.34%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

backend/similarity_webservice/app.py
75.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   80.44%   80.34%   -0.10%
==========================================
  Files           4        4
  Lines         225      229       +4
==========================================
+ Hits          181      184       +3
- Misses         44       45       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


crypto/tls: bogo suite on Windows is flakey

See e.g. https://ci.chromium.org/ui/p/golang/builders/ci/gotip-windows-amd64-longtest/b8750306255775534897/test-results?sortby=&groupby=
Seems like another case of Windows just not liking creating a lot of connections, unclear what a real solution here is. Probably just disabling it on windows builders?

I think it would be a good idea to skip it on Windows for now.

Yup, will send a CL. I have a possible plan to make bogo skip the network stack entirely and use in-memory connections, but that will require a bunch of work in boringssl.


Does not take Extra's into account

If you add extras to the cart for shipping etc, the payment provider does not take them into account when calculating the total

@IncreaseComputers Yes you are correct, looks like I've missed that.
I will look to add the charges from extra_rows to the line_items as well.
This can also be done manually by overriding the get_stripe_session_data method on the payment provider.

This is fixed and released in v0.1.5


Open Source : 6.32 Explain everything related to Flask

Description 📜
added all the information regarding Flask
Fixes #4901

Type of change 📝

[x] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Open #Source

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@Aryamanz29 done


Add REQUEST_URI to simulate_request

When testing api the REQUEST_URI header in request is missing. But when running on uWsgi the header is present. Please add REQUEST_URI to the simulate_request methods.

Can use req.uri instead.


Use multi-stage dockerfile for ya-build/ytsaurus ya package build

Conditional base stages aren't very pretty, but it is not that bad and seems to work alright.

Shipped!


feat: add aws ancillary resources

📲 What
Creates supporting backend in AWS to store terraform state file remotely

🤔 Why
To prevent local storage of state file and race around conditions if module is executed parallelly
🛠 How
Configure backends in AWS
👀 Evidence
Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR.
🕵 How to test
Run terraform apply by setting up correct input values follow the example directory
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[ ] Documentation has been updated to reflect the changes?
[ ] Passing all automated tests, including a successful deployment?
[ ] Passing any exploratory testing?
[ ] Rebased/merged with latest changes from development and re-tested?
[ ] Meeting the Coding Standards?

I do not think that we need to sub divide the infra for AWS into another folder as it is only for TF Storage

I do not think that we need to sub divide the infra for AWS into another folder as it is only for TF Storage

Hi @russellseymour updated the dir structure now


Ensure batched plots respect parameters set on (Nd)Overlay

In batched mode the OverlayPlot exists only as an intermediate layer and is not responsible for creating the axes or the actual plot object. This means this is all delegated to the batched ElementPlot, but this also means that any options set on the OverlayPlot are ignored, which is inconsistent and confusing. Since the options this applies to already propagate upwards from ElementPlots to the OverlayPlot we can use the same mechanism to pass those options back down to the batched ElementPlot, ensuring that they are respected.
This is particularly import for things like grids where options should propagate downwards from the gridplot to all the subplots, e.g. here's an example from a GridMatrix plot with batched subplots
Before:

After:

Looks good and the tests are passing. Merging.


[vcpkg_configure_meson] Fix append host path

ENV{PKG_CONFIG_PATH} shouldn't be added again.
Fixes #22812.

@jcc10 Can you please test this PR?
Thanks.

I think we need to decide whether we want to prepend or to append. The current behaviour is to append, but normally vcpkg packages should be preferred over system packages AFAIU.

https://github.com/microsoft/vcpkg/blob/5962cf5a3bfc2124e8de991a4e45a8edcb3b4c69/scripts/cmake/vcpkg_configure_make.cmake#L770
PREPEND it should be.

but really. The pkgconfig setup should be turned into its own function to make it consistent everywhere.

but really. The pkgconfig setup should be turned into its own function to make it consistent everywhere.

Agreed.

but really. The pkgconfig setup should be turned into its own function to make it consistent everywhere.

Agreed.

ncurses: mismatched debug and release lib count. Related: https://github.com/microsoft/vcpkg/issues/23476
python2 / python3: Missing installation of bz2 dynamic library in debug mode.
libgnutls:
In procedure dynamic-link: file: "/mnt/vcpkg-ci/buildtrees/libgnutls/x64-linux-dbg/guile/src/guile-gnutls-v-2", message: "file not found"

Depends on https://github.com/microsoft/vcpkg/pull/23478.

Depends on https://github.com/microsoft/vcpkg/pull/23553.

/azp run

/azp run

This should be done with a private z_ name, so that we can change it in the future.

The x86-windows failures don't look related to this so I'm going to azp run this again as soon as the other platforms finish building...

/azp run

/azp run

Thanks!


[DO NOT MERGE] Test NEW GA FAILURE

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Test build #137362 has started for PR 32171 at commit 6b468f1.

Test build #137362 has finished for PR 32171 at commit 6b468f1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137362/