Failed to load netstandard.dll on net462 environment

After 1.0.8 release nunit console fails with "Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, ..." on Windows 2012R2 build agent with .net Framework 4.6.2.
Fuslog shows that calling assembly is teamcity-event-listener <IP_ADDRESS> and that it's not possibile to locate netstandard.dll file in ConsoleRunner nor EventListener directories.
Using ConsoleRunner 3.11.1 called from cake.

Depends on:
https://github.com/nunit/nunit-console/issues/842
https://github.com/nunit/nunit-console/issues/843
https://github.com/nunit/nunit-console/issues/844

@duck-dot-net please try updating a file like "NUnit.Extension.TeamCityEventListener\1.0.8\tools.addins":
net20/
netstandard2.0/

@NikolayPianikov still the same error

@duck-dot-net please remove netstandard2.0/

@NikolayPianikov with .addins file:
net20/

works fine.

@ChrisMaddock looks like ExtensionSelector.IsBetterVersionOf works wrong for this case.
There are 2 assemblies net20 and netstandard2.0 and ExtensionSelector.IsBetterVersionOf selects a version by TargetFramework.FrameworkVersion. For net20 it is 2 and for netstandard2.0 it is 4. Thus ExtensionSelector.IsBetterVersionOf selects netstandard2.0.
Microsoft recommends to update .NET 4 to .NET 4.7.2 for netstandard2.0.
I could add netstandard.dll to NUnit.Extension.TeamCityEventListener nuget package for this case to support previous versions of nunit-console.  But I am not sure it will work for NET 4.0, 4.5, 4.5.1 ...
@ChrisMaddock do you have any ideas?

Hi @NikolayPianikov - I'll need to have a look into what's going on here. Looking back at the pull requests from the time, turns out the original implementation was only written to handle multiple version of the .NET Framework, which is why we're seeing these issues now. Sorry, I'd forgotten that as it was so long ago!
Thanks for filing the issues in the engine repo. Will take a look when I can.

Thinking about this - whilst the engine logic isn't exactly right here, the end result is correct. Between these two options, we'd expect the the engine to choose the .NET Standard 2.0 package. This issue here that .NET 4.6.2 doesn't quite support .NET Standard properly as Microsoft says it does - do you agree? I presume including the NETStandard.Library NuGet package acts as a bit of a filler for that - but I'm not familiar with what's necessary to make .NET Standard work on .NET 4.6.X.
Going back to the problem in have - Nickolay, am I right that the behaviour you want is for the net20 to be used on all .NET Framework platforms, and the netstandard20 build on .NET Core? And you're not looking to support any other .NET Standard platforms at this point in time? (e.g. Xamarin, UWP)
In that case, maybe it would be better to have the two version of the extension target net20 and netcoreapp2.1, rather than bringing .NET Standard into it at all. That should ensure that all runs on .NET Framework still use the net20 build. (Pending possible fixes to the other issues you've filed on the engine repo.)

cc @CharliePoole - this discussion is very relevant to our emails earlier today. ☝

Seems like I have to test extensions under multiple versions of the framework as well!

@ChrisMaddock Shouldn't the extension service be checking compatibility against the target runtime of the engine rather than the execution runtime?

Going back to the problem in have - Nickolay, am I right that the behaviour you want is for the net20 to be used on all .NET Framework platforms, and the netstandard20 build on .NET Core? And you're not looking to support any other .NET Standard platforms at this point in time? (e.g. Xamarin, UWP)
@ChrisMaddock yes I supposed it
In that case, maybe it would be better to have the two version of the extension target net20 and netcoreapp2.1, rather than bringing .NET Standard into it at all. That should ensure that all runs on .NET Framework still use the net20 build. (Pending possible fixes to the other issues you've filed on the engine repo.)
Yes, it would be a possible scenario. Should we create an extensions assembly for all app core versions? I mean 1, 2, 3, 5. Is it ok?

I think just one netcore version would be enough? An engine running on .NET Core 3.1 should just load the netcoreapp21 version of the extension.

@CharliePoole - not sure I understand your last question, sorry?


Bad Request when trying to get Authorized

Opened https://accounts.spotify.com/authorize?scope=user-library-read+user-modify-playback-state+user-read-currently-playing+user-read-playback-state+user-read-recently-played&redirect_uri=http%3A%2F%2F<IP_ADDRESS>%3A5000%2Fcallback&response_type=code&client_id=6a73223799534df0ae6e0547c0324255 in your browser

Enter the URL you were redirected to: Using PPAPI flash.
--disable-new-tab-first-run --enable-user-scripts --ppapi-flash-path=/usr/lib/adobe-flashplugin/libpepflashplayer.so --ppapi-flash-version=
Created new window in existing browser session.
p7dftiRNE44fYVHrvXAT3YoXU35xrhCOipuz5mVFU7LGcfVzdQinao4l9BGcqFLry2el85tG6mTA3hAib4R_gq_vnNNnw6L8pyfrw6SbLMzy3BCfyd9dRi_b_0yYNNxH1zVP3KdKUcPKQTo_ooUiufb0UgnvJOFwSrXSp

Traceback (most recent call last):
  File "spot.py", line 11, in <module>
    redirect_uri=settings.REDIRECT_URI)
  File "/home/gawaine/workspace/git/v2/local/lib/python2.7/site-packages/spotipy/util.py", line 86, in prompt_for_user_token
    token_info = sp_oauth.get_access_token(code)
  File "/home/gawaine/workspace/git/v2/local/lib/python2.7/site-packages/spotipy/oauth2.py", line 217, in get_access_token
    raise SpotifyOauthError(response.reason)
spotipy.oauth2.SpotifyOauthError: Bad Request

This happens when I use the util.prompt_for_user_token() function with client_id, client_secret etc and then try to paste the redirect URL with the code into the terminal.

The typo in the documentation might be tripping you up. Look at my post #232 - it might help you.

I'm also having this issue:
import spotipy
import spotipy.util as util

username = 'username_of_my_account' #placeholder value here
client_id = 'ID' #placeholder value here
client_secret = 'SECRET' #placeholder value here
redirect_uri = 'http://localhost:8888/callback/'

token = util.prompt_for_user_token(username, client_id, client_secret, redirect_uri)

I have checked a trillion times to make sure that the redirect_uri is exactly the same in my code and in my whitelisted uri's. When it wasn't in my whitelisted uri's yet I got Invalid URI, now I'm getting Illegal URI

@Loewkie Notice the order of parameters in util.prompt_for_user_token():
https://github.com/plamere/spotipy/blob/4c2c1d763a3653aa225c4af848409ec31286a6bf/spotipy/util.py#L9-L10
In your example, you are providing client_id instead of scope and so on..
You should use something like:
token = util.prompt_for_user_token(username, scope, client_id, client_secret, redirect_uri)

If you're not familiar with scopes, check out these official docs.
For example, if you want read access to your private playlists. Your scope should be:
scope = 'playlist-read-private'

Note: You can gain additional information using scopes only for the user whose client_id and client_secret you used.

OK that solved it for me at least. Thank you. Silly that it was something this simple really.

I'm having related problems. Just trying to get off the ground with Spotipy by retrieving data from my personal account but running into authentication errors. Following this example and setting environmental variables for the client ID, secret, and redirect URI but getting this error:
"OSError: [Errno 48] Address already in use"
I'm currently using "http://localhost:8888/callback/" as my redirect URI. Not sure if that might be causing problems.
Any ideas here?

I switched to using "http://www.google.com/" which solved that particular issue for me.

@seeess1 "OSError: [Errno 48] Address already in use" means that there is another process already using port 8888. You need to find it and kill it. See https://stackoverflow.com/a/39557155/12394554

Thank you very much for the reply. An alternative suggestion was given to me, which was to essentially ignore the error messages that appear in the browser, copy the URL that appears, and paste that URL into the cell in my Jupyter Notebook. That worked and I'm now able to retrieve my personal data from the API. Not sure if that's how it's supposed to work but it did nonetheless.

Thank you very much for the reply. An alternative suggestion was given to me, which was to essentially ignore the error messages that appear in the browser, copy the URL that appears, and paste that URL into the cell in my Jupyter Notebook. That worked and I'm now able to retrieve my personal data from the API. Not sure if that's how it's supposed to work but it did nonetheless.

Yes, you can ignore the actual content of the page that you are redirected to. All that matters is the URL itself. If you look at the query string of the URL, you will see a code parameter. That's what spotipy needs to complete the authorization process.

Awesome thank you. Much appreciated.


Map dragging doesn't work for the example on https://leafletjs.com for Firefox 71 on Windows 7

When I open https://leafletjs.com, I cannot move the map by dragging in Firefox 71 on Windows 7. Moving by using the arrow keys works.
In Chrome I can move the map by dragging.

Interesting! Can you try out the example locally and see which versions are affected? Is it only 1.6.0, or 1.5.1 too?

I have made a local copy of https://leafletjs.com/examples/quick-start/example.html and tried it with both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Both have the same behaviour described in my opening post: No dragging in Firefox, fully working in Chrome.

I went back a "little" further:

0.7.7 works fine!
1.0.1 - same broken behaviour as described in my opening post.

Dragging works in Firefox 71 on Mac for me, so likely Windows Firefox specific.

No issues with Firefox 74 + Leaflet 1.6.0 on Windows 10.

Still doesn't work in with Firefox 82 + the current example on https://leafletjs.com (which might be Leaflet 1.7.1) on Windows 7 for me.

For what it's worth, with Firefox 86 on Windows 10, the current example on https://leafletjs.com (still 1.7.1, I assume?) works for me.

@johnd0e Considering that it was working fine on Windows 10 Firefox versions earlier too, it might be a weird Windows 7 FF vs Windows 10 FF thing.

Sure, feel free to debug that on windows 7, and reopen this issue if you need.


Error message when switching between predefined styles

I'm not sure if it only happens to me or not, to reproduce this, type something in the Quick search input field at the top left, for example, Align. then try to switch between Google and LLVM in the Select Style dropdown. You'll get a strange error message box that doesn't make sense:

 Alt: Object reference not set to an instance of an object.
Offtopic: What's the timeline like, for upgrading to .NET 7 and LLVM/ClangFormat 15?

Same error here when changing option values.

Hi @ifarbod, @ix-anemoff,
A fix for this issue is available in Clang Format Editor v2023.4.2
Thank you for reporting this problem
Kind regards,
Marina


Searching on size / ratio doesn't work by anime planet

What steps will reproduce the problem?
When you try to search for tags with size or ratio on anime planet it doesn't give any results. when you seach for example tail res_x=1920 it doesn't give back any results. The generated link by grabber with it looks like this: https://anime-pictures.net/pictures/view_posts/0?search_tag=tail res_x%3D1920&lang=en&type=json inside the browser, but when you replace %20 with a & like https://anime-pictures.net/pictures/view_posts/0?search_tag=tail&res_x%3D1920&lang=en&type=json it does give back results. The & is only needed for the tags for sizes and ratio and a space (%20) for normal tags.
What is the expected behavior? What do you get instead?
I am not getting back any results while I aspect to get back results.
How often does this problem occur? On which sources?
Always on anime planet
What version of the program are you using? On what operating system?
Version 6.0.3 with windows 10
Please provide any additional information below

As of 6.0.5, you'll be able to use:

width:N
width:<=N
width:>=N
width:<N
width:>N
height:... (same as width)
ratio:N
order:X where X is one of date, date_r, rating, views, size, tag_num
filetype:X where X is one of jpg, png, gif


Pin apps at the top.

Hello.  Your application can become a replacement for the system partition "apps".
The only thing missing is the ability to pin frequently used applications to the top of the list (or to sort applications: alphabetically, recently installed, frequently used).
Also, it would be more convenient for the application settings to open when you click on the name of the application, and not just on the application image.
Thank you for your attention.

In the next release I will  add a sort feature, and enabling clicking the name of the app.
I will look into most recent and frequent - I am not sure Android exposes these. And if it does might require some admin permissions.


Can't make longRunningRecognize to work

Environment details

OS: Windows 10 and Linux
Node.js version: 6.9.1
npm version: 3.10.8
@google-cloud/speech version: 1.0.1

Steps to reproduce

Using :

    var config = {
        encoding: 'FLAC',
        languageCode: 'en-US',
        sampleRateHertz: 32000
    };
    // The name of the audio file to transcribe
    var audio = {
        uri : 'https://nofile.io/f/pDrSFMuSfVh/2f996778-cc3e-496f-a4fb-9e97bb34a040.flac',
    }
    var speechRequest = {
      config: config,
      audio: audio,
    };
    clientSpeech.longRunningRecognize(speechRequest)
        .then(function(transcript) {
            console.log("success transcript",transcript);
        }).catch(err => {
            console.error("transcript error", err);
        });

Here is the output :

transcript error { Error: Request contains an invalid argument.
    at C:\wamp\www\video-recorder\node_modules\grpc\src\client.js:554:15 code: 3
, metadata: Metadata { _internal_repr: {} } }

When I test with a local file (less than 60 seconds), and using recognize it's working.
NB:  I posted here the audio file in nofile.io where you can download the file, to not include the real location of the file.
Thanks!

I think I got the origin of the issue (although the error message is super vague...)
uri parameter only accepts  Google Cloud Storage URLs :

Why such a limitation ?
Any plan to support external storage in the short-term ?
That means that for now, if an audio file is longer than 1 minute, there is no way to process it at all if not hosted on GS ?

One good thing would be to have the detail of all parameters in the reference page : https://cloud.google.com/nodejs/docs/reference/speech/0.11.x/v1.SpeechClient
Thanks !

Regarding the docs, there's an issue with the template. It's not showing any options that our methods allow (issue opened here: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2783)
For the other questions, I can't answer those, unfortunately. We're just a slim wrapper around the API. You can find members of that team through the recommended channels on the Support page.
However, it does seem that we could accept a uri and download it for you, then pass it as a data blob to the API. I'm not sure that will solve many cases, though, as we're still limited by the 1 minute rule.
@alexander-fenster what do you think?

We should probably not do any special handling of a uri before the upstream API does. In theory, if we can do it here, they can do it, too. And the fact that they're not is probably telling enough to stay back from implementing ourselves.
If anyone disagrees, or sees another way we can improve, let me know.

Never mind.  Just found anwer in the docs

@AlexanderKozhevin what was the answer? I tried to return the promise, but no dice..

@shamoons Response contains only metadata - name:<PHONE_NUMBER>46795740
It's an id which you have to use to request final result.
Like
https://speech.googleapis.com/v1/operations/${ID?key=your_google_api_key


Default controller value

Not right an issue, but please when i can set default controller? It's not easy for children to select everytime right controller.

I finally respond to this issue. It's sort of impossible to set the default controller. There is no way to differentiate between two controllers of the same type, thus saving the last controller wouldn't do much. Obviously if you had two different controllers this would work fine but it would then be a partially working feature. I have plans to have a controller selection pop up when you plug a controller in. Is that something that would make it easier?


Deployment failure with minikube v1.19

With minikube v1.19.0, the deployment fails with following error (macOS and linux). This works fine on v1.18.0

Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "validate.nginx.ingress.kubernetes.io": an error on the server ("") has prevented the request from succeeding

This works fine in minikube v1.20


normals_gt.tgz issues

I can't find normals_gt.tgz in website.

It seems the website from the original authors faces some issues currently.
You should be able to access the file using an archive of the Wayback Machine for example.


I0Error

Hey, seems like I've gotten the module installed correctly but when trying to run some sample code just to check if it will compile:
`from time import sleep
import RPi.GPIO as GPIO
from mpu6050 import mpu6050
sensor = mpu6050(0x68)
while True:
accel_data = sensor.get_accel_data()
gyro_data = sensor.get_gyrp_data()
temp = sensor.get_temp()
`
I get this error:

Any ideas what that may be referring to / how to fix?
Looking into that directory it seems like all the files are properly placed.
Using Pi 3 if that changes anything.
Thanks!

Run code with sudo.

Thank you for using my module!
As @Jimit04 stated, you need to run the code using sudo to get access to the I2C bus.

Thanks for the quick response!
However, trying to run the code with sudo I'm getting the same error.
I did notice that I didnt do the pip install using sudo (seems like that would need elevated privileges?) so I went back through the whole process using sudo and I got the same error.

Check if you have enabled I2C with raspi-config.

There it is!
Thanks for the help and the great module!

No problem.


fix(chat): fix application logs displaying (Issue #2534)

Description:
fix application logs displaying
Issues:

Issue #2534

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


MAAS fails at database migrations

Problem
Ansible Playbooks fail to migrate MAAS database.
Error
(Error message cut down for brevity, raw error is accessible here)
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": true, "cmd": ["maas-region", "migrate"],
...
"django.db.utils.OperationalError: could not connect to server: Connection timed out", "\tIs the server running on host \"<IP_ADDRESS>\" and accepting", "\tTCP/IP connections on port 5432?"], "stdout": "", "stdout_lines": []}

Config
[maas_postgres_primary]
<IP_ADDRESS> ansible_user=ubuntu

[maas_postgres_secondary]

# DO NOT MODIFY this group
[maas_postgres:children]
maas_postgres_primary
maas_postgres_secondary

[maas_proxy]
<IP_ADDRESS> ansible_user=ubuntu

[maas_region_controller]
<IP_ADDRESS> ansible_user=ubuntu

[maas_rack_controller]

Command
ansible-playbook site.yaml  -i hosts --extra-vars "maas_version=3.2 maas_postgres_password=test maas_postgres_replication_password=test maas_installation_type=deb admin_username=admin admin_password=admin maas_url=http://<IP_ADDRESS>:5240/MAAS"

Steps to replicate

create two lxd containers
assign maas_postgres_primary and maas_proxy roles to one, and maas_region_controller to the other.
run ansible-playbooks with required variables
process will hang and eventually fail at TASK [maas_region_controller : Migrate MAAS database]

Additional Testing
Cursory testing suggests this problem only occurs when the MAAS proxy is in use and on the same host as another role.

Host Configurations
MAAS install
Failure

1: postgres + proxy, 2: region
Deb
Yes

1: postgres + proxy, 2: region
Snap
Yes

1: postgres, 2: proxy + region
Deb
Yes

1: postgres, 2: proxy, 3: region
Deb
No

1: postgres, 2: region
Deb
No

I didn't see an apt failure when rerunning the test on the latest branch, could be a hit-or-miss error?
I did have an apt failure when I didn't specify the maas_version, it defaults to latest so snap installs correctly, but ppa:maas/latest might not be a valid url for deb installs.


System.StackOverflowException caused by Newtonsoft.Json v9.0.1

When adding TMDbLib nuget packet to an empty C# console application using .NET Framework 4.6.1, a System.StackOverflowException (HResult=0x800703E9) is thrown when the following line gets executed: https://github.com/LordMike/TMDbLib/blob/5b9e93e581c348fb0289929fd0469227df21239f/TMDbLib/Utilities/Serializer/TMDbJsonSerializer.cs#L14
The test application is copied from the example:
internal static class Program
{
    /// <summary>
    /// The main entry point for the application.
    /// </summary>
    private static void Main()
    {
            TMDbClient client = new TMDbClient("apiKeyRemoved");
            Movie movie = client.GetMovieAsync(47964).Result;
            Console.WriteLine($"Movie name: {movie.Title}");
    }
}

This issue seems to be related to Newtonsoft.Json v9.0.1 and is gone as soon as any newer version (starting with v10.0.1 up to v13.0.1) is used.

Fixed by #439


AspNetCore Model property values null on POST only when action parameter is called “model”

Is this a Bug or Feature request?:
Bug
Steps to reproduce (preferably a link to a GitHub repo with a repro project):

Using built-in scaffolding, create a new CRUD controller binding to model.
Change parameter name on POST action to "model"
Attempt to post data back to the controller

Description of the problem:
Did something change in AspNetCore that no longer allows you to use the parameter name "model" on POST actions?
If I do this, the DeviceModel property values are populated on postback:
[HttpPost]
public IActionResult Create(DeviceModel **device**)

However if I change the parameter name from "device" to "model" the property values are null.
[HttpPost]
public IActionResult Create(DeviceModel **model**)
Is this a bug in AspNetCore or did they change something?

I can't find anything saying that the parameter can't be called "model" and in previous MVC versions this worked fine.
Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:
CompatibilityVersion.Version_2_1

https://stackoverflow.com/questions/51735929/model-property-values-in-aspnetcore-2-1-are-null-on-post-when-action-parameter-i
Seems having a property in my model called "Model" breaks the postback data. I removed the property and the postback works. Why would a property being named "Model" in my model break the postback action?

Unfortunately this is by design. See https://github.com/aspnet/Mvc/issues/3735. We're going to try using an analyzer to provide some tooling guidance in this scenario.


[BUG] - No next page / more results button for data series indexes

Describe the bug
No next page button / bad default filter applied for data series index types.
When using lots of aliased datastream indexes there is no next page on the managed indicies.
We have 160 backend indexes and about 15 aliases for them. They have names like linux, ldap, testing, win-events etc etc
On the 'Managed Indices' page /app/opensearch_index_management_dashboards#/managed-indices
I would enable 'show data stream indices' and what is shown is a mix of testing indexes and a handful of others.
Now if I change rows per page to 50 it will show only 20 indexes - a mix of testing and a handful of others and no page 2,3,4 etc button/hyperlink.
In fact if I type in the filter/search bar a letter than spans like 's' then maximum results that get returned is 20. Rows = 50 - still 20 results and no page 2,3,4 etc button/hyperlink. (I have 157 indexes with the letter 's').
If I select a data stream from the drop down filter (next to show data stream indices slider) once again max results is 20.
To Reproduce
Steps to reproduce the behavior:

Create a data stream index and template (template below)
Rollover data store 25-50+ times
Observe the limits imposed

Expected behavior
Show all indicies.
Plugins
default opensearch docker image 1.1.0
Screenshots
Desktop (please complete the following information):
Windows 10 v21H1
Firefox v93.0
Additional context
Index Template:
{
  "index_patterns": [
    "testing-*"
  ],
  "template": {
    "settings": {
      "plugins.index_state_management.rollover_alias": "testing"
    },
    "aliases": {
      "testing": {}
    }
  },
  "priority": 10,
  "data_stream": {
    "hidden": false,
    "timestamp_field": {
      "name": "@timestamp"
    }
  },
  "composed_of": [
    "field_mappings"
  ],
  "version": 1
}

Hi,
This is an UI only bug and have recently pushed a fix to correct this behavior. The fix will be included in our next release https://github.com/opensearch-project/index-management-dashboards-plugin/pull/113


Fetch

Implement fetch method. Handle http codes (correct and incorrect ones).
Make the fetch function which will sign the requests with the token

Fixed in https://github.com/pokatomnik/mrakopedia-api/pull/70


Add CI Integration

As far as I can tell, there is no CI integration with this project. May I suggest we add a CI Integration? We could use CircleCI or GitLab CI (https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/github_integration.html)

@ClemMakesApps Hi Clement. We are considering adding CI support, probably Travis.
The ECharts project depends on ZRender project. When developing locally, we use a soft link in echarts/node_modules to the local zrender project.
**When using CI, how should we specify using the latest ZRender commit (rather than ZRender npm release) when building ECharts project? **
For example, there may be a new function in the latest ZRender commit, and a new ECharts commit calls this new function. Since the function is not included in the latest ZRender release on npm, npm i zrender will not help.
npm supports something like npm install --save "git://github.com/username/package.git#commit", although I'm not sure this is helpful.
Could you please give some idea about this?

I think you can use 'npm link' to use any local non project.

Instead of
"dependencies": {
  "zrender": "4.0.6"
},

in master,
if you could do
"dependencies": {
  "zrender": "git://github.com/ecomfe/zrender.git"
},

that should pull the latest master commit for zrender. According to https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

It is possible to pull in the latest ZRender master commit but there is a risk in doing so.
If we are pulling in the latest zrender at all times, your upstream dependency could break your CI builds in this project at any moment. This could make the CI pipeline unreliable for this project

Agree. With each ci test, a determined version is useful when test failure emerges.

@ClemMakesApps Is it possible to use "zrender": "git://github.com/ecomfe/zrender.git" for master CI, while keeping "zrender": "4.0.6" for release branch and hopefully for the default package.json of ECharts project?

I understand using a specific version in CI is out of the consideration of reliability. But in our situation, upstream is fully under our control and ZRender should be updated before ECharts. So depending on the latest commit should have no problem.

Even though ZRender is currently under the control of ECharts core team, I still don't think it's the most optimal approach for this project. The core team for both projects could change over time, especially since one project is still under Baidu's organization while this is going through the Apache incubation process. This also makes it more difficult for contributors to contribute to ECharts because their builds may fail in the event ZRender has a breaking commit/change. In addition, this in my opinion complicates the release process (for both projects) more than it needs to be.
If we really need to add ZRender master branch as a dependency, I would recommend adding a CI job on ZRender to check for breaking changes on ECharts on each commit. In the very least, that will ensure that each commit on ZRender doesn't indirectly break ECharts.

@ClemMakesApps Thanks Clement for the details!
We also have an internal discussion. And the conclusion is, we are going to use the npm release version on zrender in echarts project, for both master and release branch. And if there's a breaking change in zrender that echarts relies on, we will publish a non-latest version of zrender first, and then merge the related logic of echarts from a feature branch into master or release branch.
Besides, I'm working on a full doc for developing workflow so that people from the community can understand how to help.


docs: contribution guidelines: add a note about using bash when configuring git

Problem

I run macOS, and my default shell is configured as zsh
When attempting to copy and paste the script from the textbox on the "Configure git" page (https://www.googlesource.com/new-password) I get a shell error stating that history and tr are not found
When I exec bash and run the script again, it works perfectly

Suggested solution
On https://tip.golang.org/doc/contribute.html#config_git_auth, under section Step 2: Configure git authentication, there are 3 list items.
The 3rd item in the list states the following:

Copy and run this script locally in your command line terminal to store your secret authentication token in a .gitcookies file. If you are using a Windows computer and running cmd, you should instead follow the instructions in the yellow box to run the command; otherwise run the regular script.

Perhaps we can add a note about switching to bash before running the script, if the user happens to be configured to a different shell?

/cc @rasky

I don't see this as a Go documentation issue. We are just mirroring what is mentioned on https://www.googlesource.com/new-password.
While it is fine to make the change, I think the script itself should be modified to run on most common shells. Or if that is not feasible, then the instructions should be changed on that page first. And then reflected on golang.org.

@agnivade it does look like the current script is fairly Bash-specific. For example, on another POSIX Shell, dash:
$ set -o history
dash: 4: set: Illegal option -o history

The rest of the script, including tr and the heredoc, look portable enough.

By which I mean - if we want to fix this by changing the shell code that Gerrit gives, that also seems like a good option to me. We would have to figure out what that would look like, though.

By which I mean - if we want to fix this by changing the shell code that Gerrit gives, that also seems like a good option to me.

Yea that's what I would prefer.
A tangential question though - What are we gaining by doing this "disable bash history" business ? Is it a security issue ? Are there more portable ways of disabling shell history ?

@bradfitz @ianlancetaylor do we know where the source for https://www.googlesource.com/new-password is, or exactly why the history options are necessary? Ideally, the fix would be there to make the script portable, instead of telling our contributors to use Bash.
For example, I imagine that replacing set +o history with set +o history || true should work, to only disable the history if that is possible. Although if the script really cares about security, perhaps it's best to tell the user to use Bash on the googlesource page.

I filed an internal bug to track this.

We've made some changes to the new-password page which should roll out next week:

Tweaked the history options to work in zsh as well as bash. (Unfortunately, there is no actual portable way to suppress history recording that we could find.)
Added the sentence: "This script is designed to work in bash and zsh. It ensures that the password is not saved in your shell history."

Thanks for the report.

Thanks @dborowitz, and team, for the quick response to this.
The outcome of this simple doc request is incredible to witness, and a testament to this community 🎉

@dborowitz - drive-by question here, but does temporarily unsetting (then resetting) HISTFILE not work in both shells, and indeed others?

I didn't personally do the investigation, but here's what Jonathan Nieder
said about HISTFILE:
"This is pretty widely portable (to bash, zsh, and ksh) but only affects
what happens when history is flushed to disk; it doesn't affect the history
shown before then with "fc -l". Since HISTFILE can change after our command
sequence and before history is flushed, this is not reliable or intuitive
enough to count on."
On Fri, Jun 22, 2018, 09:53 Paul Jolly<EMAIL_ADDRESS>wrote:

@dborowitz https://github.com/dborowitz - drive-by question here, but
does temporarily unsetting (then resetting) HISTFILE not work in both
shells, and indeed others?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/25788#issuecomment-399449622, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAL5bwFOw7KyYRWnHEwPumUQpFcANKbZks5t_PbYgaJpZM4Ue9ZW
.

For those following along at home, the changes have been rolled out.
This may have not been clear from my prior comment, but this update also included a change to the script itself to ensure that it is indeed compatible with zsh:
set +o history 2>/dev/null || setopt HIST_IGNORE_SPACE 2>/dev/null
 touch ~/.gitcookies
# etc.

Awesome, thanks.
Going to close this issue since I believe the documentation from our side is correct now -

Copy and run this script locally in your terminal to store your secret authentication token in a .gitcookies file.

Explicitly mentioning the valid shells to run on (bash,zsh) might be overkill when it is already mentioned on the googlesource page. Feel free to comment if you disagree.


Add ability to control plugin visibility from the outside

yarn run v1.22.4
$ eslint .
/home/jenkins/workspace/n-create-inventory-records_PR-11/project/src/CreateRecordsPlugin.js
11:10  error  CreateRecordsModal not found in './components'  import/named
✖ 1 problem (1 error, 0 warnings)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-create-inventory-records/job/PR-11/1/


WIP: clarify docs license to CC-BY

Needs to be paired with docs generator update to ignore LICENSE.md file.

LGTM


Allow word download

Allow both word and pdf downloads so we can add steps while we customize our own 365 setup checklist

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a6b63155-715a-14bf-c3bb-31b52ffcf8ec
Version Independent ID: d274ba6f-50f2-a4ff-5981-f53561b7e438
Content: Get started with Microsoft 365 Business
Content Source: microsoft-365/business/microsoft-365-business-overview.md
Service: o365-administration
GitHub Login: @Sirkkuw
Microsoft Alias: sirkkuw

Hi,
Thank you for your feedback. Unfortunately our build system only allows producing a PDF downloadable.
Sirkku


Revert "Fix disableSandboxForPluginCommands"

Reverts apple/swift-package-manager#5855

@neonichu

@swift-ci please test

Just a note, if we revert this we'll break the package compatibility suite again.

Closing this PR; it does not appear to be related to the CI failures we're seeing.


e2e: fix kind cluster apiserver port only for kubefed

This change is

I did this to bypass error Reason: Get http://<IP>:6443/version: dial tcp <IP>:6443: i/o timeout which I was getting when running make ci e2e status=keep

This change breaks CI:
https://travis-ci.com/submariner-io/submariner/builds/136954091#L1738
Can you report a Github issue with the details to reproduce what you were experience?, then we can get @dimaunx to help us with the fix.

@hunchback how this can reproduced locally? It never happens to me when running make ci e2e status=keep multiple times.

@hunchback how this can reproduced locally? It never happens to me when running make ci e2e status=keep multiple times.

Was not able to reproduce (after rebasing), thus closing


Feature/thread safety

StitchClient was not thread safe. It was pretty easy to make it thread safe, by synchronizing access to the properties of the Buffer object. I refactored the Buffer object to reduce the scope where the private properties (queue and availableBytes) are accessed, and then made those methods synchronized.
Testing
It's not an exhaustive test, but I added a test that at least attempts to exercise concurrent calls to push(). Please see docs in the test class for details.

Approved


The query with limit does not return the lowest tag points

Describe the bug（Bug 描述）
The query with limit does not return the lowest tag points
To Reproduce（Bug 复现步骤）
1.insert such datas:

2.query "select * from mst1 limit 1"
3.result point is not the lowest.

Expected behavior（期望结果）
The query with limit should return the sorted tag points of the equal minimum time points.
Screenshots（屏幕截图）
No response
Logs（完整的错误日志）
No response
Additional context（其他的一些补充内容）
No response

In standard SQL, a SELECT statement without ORDER BY may return the rows in any order.
Did openGemini design and document that the rows are ordered by the timestamp in ascending order,
even when there is no "ORDER BY ts" clause?

In standard SQL, a SELECT statement without ORDER BY may return the rows in any order. Did openGemini design and document that the rows are ordered by the timestamp in ascending order, even when there is no "ORDER BY ts" clause?
Yes, queries without “ORDER BY” clause in openGemini return data sorted in ascending time by default.


tests: Quick-fix VkImageCopy aspectMask test on 1.1

This is also a problem in Vulkan 1.0 when the sampler_YCbCr extension is enabled, not strictly a 1.1 issue.  Also the test should remain but expect a different VUID, post-YCbCr.
I have these fixes already in a large-ish sampler_YCbCr PR that will go up later this week, so I recommend abandoning this PR.

This is also a problem in Vulkan 1.0 when the sampler_YCbCr extension is enabled

If by "problem" you mean that such cases are not tested (nor validated by layers).
It is not a problem here, since the test does not enable any extensions.
I went with a guard that was used previously, but it's bit of a larger problem.
We ideally want to test both 1.0 and 1.1 (not either-or).

I'd be in favor of this temporary quick fix going in now even if it will be replaced soon by a better fix.  It is in line with other tests that had to be disabled for 1.1 and it looks like this one just got missed.
My CI machine with 1.1 drivers is flagging this error continuously which is annoying and hiding actual new problems that might show up.

Sorry if I was unclear, as I think we're both saying the same thing.  The test should be run regardless of API version, but for API >= 1.1 the VUID should be VALIDATION_ERROR_09c00c1e.
But, 09c00c1e isn't implemented on master yet, it's sitting on my dave-ycbcr branch.  If time is of the essence I'm not opposed to this PR now.

Sorry if I was unclear, as I think we're both saying the same thing. The test should be run regardless of API version, but for API >= 1.1 the VUID should be VALIDATION_ERROR_09c00c1e.

Sure, but I was making a larger point about the if(m_device->props.apiVersion <=> VK_API_VERSION_1_1) we started using.
I mean on API >= 1.1 the VUID should ideally be both cases, as 1.1 implementation is capable running both 1.0 and 1.1 based on VkApplicationInfo::apiVersion.
Ideally I should not add the if and the test should be run with VkApplicationInfo::apiVersion = 1.0.

VkApplicationInfo::apiVersion is set according to the installed driver, and is read-only to the test.
Closing this PR in favor of #2531.


cwa-verification-iam + docker + keycloak

If we try to install cwa-verification-iam using the docker instructions provided , when we try to open the admin console, we get 403,/auth/admin, it's possible is necessary any others instructions

Thanks for your question. Let me move it to the cwa-verification-iam and let the developers comment on that.


remove sar & master from main

This PR:

removes MAGC & SAR & MASTER and the related parts in documentation/references from main branch

motivation:

SAR & MASTER implementations are broken on both frameworks and build currently a blocking part to continue with other things so i think we have to take the time to reimplement both maybe the other things are more stable :)

ATTENTION: sar-master-backup branch is created !
@frgfm @charlesmindee
Any feedback is welcome ! :)

Before removing all of those, perhaps we should quickly check that magc_resnet is working?
The feature extractor of both models are likely to be working (and thus we could keep those)

@frgfm sure let me take a bit more time before we remove this -> DRAFT :)

Closed take the time and fix it :)


Too much bad fast5

Hi,
I am calling methylation with nanopolish and one of my samples' output after calling methylation is only 3.6G, out of a 69G fastq (using only pass reads).
The out of the job was: [post-run summary] total reads: 10315886, unparseable: 0, qc fail: 1457, could not calibrate: 506, no alignment: 12754, bad fast5: 4309496
And the indexing seems fine:
[readdb] indexing /data/gpfs/projects/punim1048/allbarcoded/CORT/CORT12/barcode06/
[readdb] num reads: 5601511, num reads with path to fast5: 5601511
[coracollar@spartan-login3 fastq_pass]$ ls -lh
total 80G
-rw-r--r-- 1 coracollar punim1048  69G Aug  3 10:10 CORT12.fastq
-rw-r--r-- 1 coracollar punim1048 9.9G Aug  4 05:26 CORT12.fastq.index
-rw-r--r-- 1 coracollar punim1048 317M Aug  4 05:30 CORT12.fastq.index.fai
-rw-r--r-- 1 coracollar punim1048 8.6M Aug  4 05:30 CORT12.fastq.index.gzi
-rw-r--r-- 1 coracollar punim1048 730M Aug  4 10:19 CORT12.fastq.index.readdb
-rw-r--r-- 1 coracollar punim1048  150 Aug  4 10:19 nanopolishindex.out
-rw-r--r-- 1 coracollar punim1048  312 Aug  3 10:14 nanopolishindex.slurm
Any idea what might be happening?
When I called methylation before in other samples (using an older version of nanopolish though) I obtained 83G methylation calls file out of a 102G fasq file with "[post-run summary] total reads: 14143878, unparseable: 0, qc fail: 10190, could not calibrate: 4544, no alignment: 217499, bad fast5: 53033" . Although the sample giving the error has fewer coverage the difference is just too big.

Hi,
The usual reason for 'bad fast5' reads is that the fast5 is unaccessible (the path is wrong, file permissions are incorrect). Rarely the signal data in the file can be corrupted in some way (unlikely if the reads basecalled). Also reads with length <20bp will be skipped (unlikely). It is hard to diagnose what the case is here - in future versions I'll try to put in more informative messages since this is a common issue.
Jared


Added ReadOnlyCursor to ManagedLedger

Motivation
Added a read-only cursor that can be used to read data out of a managed ledger without interfering with the managed ledger instance that is active in the Pulsar broker that owns a particular topic.
Modifications

Added ReadOnlyCursor that can be obtained directly from a ManagedLedgerFactory
The read only cursor has only subset of the functionality of the regular ManagedCursor

retest this please

If possible, can we extend ManagedCursor here and probably add docs to the method skipEntries .

@rdhabalia the ReadOnlyCursor is much more limited in scope compared to ManagedCursor because it only allows to read entries but not to delete them (or move mark-delete position).
As @ivankelly pointed out, logically it should be ManagedCursor  that extends ReadOnlyCursor, though there is the problem of "skipEntries" which, for ReadOnlyCursor is just a bumper pointer operation while for ManagedCursor requires to update the mark-delete position.

retest this please

retest this please


Mouseover Talk Thumbnail and Show PDF | PPTX Download Options

When you mouseover talk thumbnail, have the thumbnail go dark (with opacity layer) and show PDF | PPTX overlaid text as download options.

This is related to https://github.com/jonfroehlich/makeabilitylabwebsite/issues/287. Assigning @lstearns86 as he will be addressing both simultaneously.

Added in #325

@lstearns86 added the functionality for this in pull request https://github.com/jonfroehlich/makeabilitylabwebsite/pull/325 (now merged into master); however, this is still not hooked up. So, I don't want to close this Issue until it's hooked up on landing page and talks.html page. Unassigned @lstearns86 for now so he can work on his other assigned hackathon issues.

OK, looks like it's implemented on talks.html but not landing page. Fine. We can create another issue for landing page.
However, before we close this, I think that when there is only one link in the thumbnail, that the entire thumbnail should be clickable not just the button. So the behavior should be like: https://www.awwwards.com/websites/portfolio/. I realize this is not possible if two or more buttons are overlaid as clicking outside the button in that case is ambiguous.

We now have pop-up links that come up below the thumbnail (e.g., see HandSight thumbnail below), which seems to work well for now. So, closing this.


ESP-AT Master compile error

I want to compile ESP8266_1MB  ESP-AT, configution use PLATFORM_ESP8266   ESP8266_1MB
compile log as follow
/mnt/hgfs/esp8266-share/esp-at/components/at/lib/libesp8266_at_core.a(at_pingCmd.c.obj):(.literal.esp_at_ping_process+0xc): undefined reference to ping_init' /mnt/hgfs/esp8266-share/esp-at/components/at/lib/libesp8266_at_core.a(at_pingCmd.c.obj): In function esp_at_ping_process':
(.text.esp_at_ping_process+0x78): undefined reference to `ping_init'
collect2: error: ld returned 1 exit status
make: *** [/mnt/hgfs/esp8266-share/esp-at/esp-idf/make/project.mk:510: /mnt/hgfs/esp8266-share/esp-at/build/esp-at.elf] Error 1
root@ubuntu:/mnt/hgfs/esp8266-share/esp-at#
root@ubuntu:/mnt/hgfs/esp8266-share/esp-at# git branch

master

@jack685 could you please provide detailed compile log?

hello ustcct,
My platform choose PLATFORM_ESP8266 and module_name choose ESP8266_1MB. esp-at checkout to Master version. export then make menuconfig and log as follow.
root@ubuntu:/mnt/esp8285/esp-at# make menuconfig
Python requirements from /mnt/hgfs/esp8266-share/esp-at/esp-idf/requirements.txt are satisfied.
MENUCONFIG
Traceback (most recent call last):
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1128, in _open
return open(filename)
FileNotFoundError: [Errno 2] No such file or directory: '$ESP_AT_PORJECT_PATH/main/interface/uart/Kconfig'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1158, in _enter_file
self._file = self._open(filename)
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1141, in _open
raise IOError(
OSError: Could not open '$ESP_AT_PORJECT_PATH/main/interface/uart/Kconfig' (ENOENT: No such file or directory). Perhaps the $srctree environment variable (which was unset) is set incorrectly. Note that the current value of $srctree is saved when the Kconfig instance is created (for consistency and to cleanly separate instances).
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/confgen.py", line 553, in
main()
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/confgen.py", line 225, in main
config = kconfiglib.Kconfig(args.kconfig)
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 653, in init
self._parse_block(None,           # end_token
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1632, in _parse_block
self._parse_block(_T_ENDMENU,
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1584, in _parse_block
prev_node = self._parse_block(None,            # end_token
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1632, in _parse_block
self._parse_block(_T_ENDMENU,
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1681, in _parse_block
self._parse_block(_T_ENDCHOICE,
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1583, in _parse_block
self._enter_file(sourced_file)
File "/mnt/hgfs/esp8266-share/esp-at/esp-idf/tools/kconfig_new/kconfiglib.py", line 1167, in _enter_file
.format(self._filename, self._linenr, e.message))
AttributeError: 'OSError' object has no attribute 'message'
make: *** No rule to make target 'menuconfig', needed by '/mnt/esp8285/esp-at/build/include/config/auto.conf'.  Stop.
root@ubuntu:/mnt/esp8285/esp-at#

but I compile it sucessfull when i checkout  to release/v<IP_ADDRESS>_esp8266 .

@jack685 please build the esp-at project according to https://github.com/espressif/esp-at/blob/master/docs/en/Compile_and_Develop/How_to_clone_project_and_compile_it.rst
Moreover, it it recommended that keep the default sdk version.

Closing as this question appears to be answered. Please reopen if the issue persists and you can supply more details. Thanks.


Sluggish when working over an ssh connection

Hi, This is less of a specific bug and more of a performance issue.
This morning I started giving Hyper 2 a try and for the most part, I really like it. However, I have found a big issue when working over SSH Hyper really starts to struggle, doing things as simple as opening an editor (emacs or nano in this case) Hyper starts to become really unresponsive. to the point where I'm waiting 5-10 seconds for a simple key press to happen.
I have compared doing the same things with Terminal on the mac there is no issue using Terminal. I will be keeping my eye on Hyper and continuing to use it when working locally. it's just a shame that I can't replace Terminal completely at the moment.

Please fill in the https://github.com/zeit/hyper/blob/canary/.github/issue_template.md
with steps to reproduce, we need to know your OS, how you're connecting etc to be able to reproduce.


Prevent accidental cluster deletion

Before this commit, the hosted cluster controller treated a missing
hostedcluster the same as a deleted one. This is incorrect, because any cache or
other transient weirdness from the apiserver for a hostedcluster which actually
still exists will result in that cluster being accidentally destroyed. Absence
of the hostedcluster being reconciled isn't the same as deletion intent.
This commit fixes the problem by short-circuiting reconciliation if the
requested hostedcluster doesn't exist. If on a subsequent event the resource can
be fetched, we'll reconcile it as usual. If we continue to get queued events for
a resource the apiserver says isn't found, that could be some other cache or
connectivity issue we want to surface and resolve. What we should not do is
infer a deletion event from it.

I'm observing this right now. My hypershift-operator is misidentifying a non-deleted hostedcluster as "missing" and so deleted its nodepools and service endpoints, and only stopped short of deleting the entire control plane namespace because an empty HostedCluster struct is fed through to delete() causing an HCP lookup failure with an empty name. Something must be very wrong here...

Manifests as:
{"level":"error","ts":1642194257.0969057,"logger":"controller.hostedcluster","msg":"Reconciler error","reconciler group":"hypershift.openshift.io","reconciler kind":"HostedCluster","name":"dmace-hyper-4e6d","namespace":"clusters","error":"failed to delete cluster: error deleting HostedControlPlane \"\" in namespace \"clusters-dmace-hyper-4e6d\": resource name may not be empty","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/Users/dmace/Projects/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/Users/dmace/Projects/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}

To be clear, there's still a bug to run down even with this change. Whatever is happening to cause the client to return notfound is unresolved, but now it'll result in the cluster not being reconciled, instead of the cluster being inappropriately deleted.

/lgtm


feat: enable new homepage

This PR enables logged in gateway view as a logged out view (other words makes this view by default). At this moment, this view enabled via NEXT_PUBLIC_SIDEBAR_LAYOUT env variable.
Closes https://github.com/near/near-discovery/issues/1145

thanks @shelegdmitriy. How should we test this PR?

Good question! According to your comment here this layout change shouldn't affect current near.org. To achieve this approach, I use  NEXT_PUBLIC_SIDEBAR_LAYOUT  feature flag presented by @calebjacob. To test this PR you need this:

near-discovery and near-discovery-testnet preview links should not differ from current near.org.
dev-near-org preview link should be different from current near.org and near-discovery and near-discovery-testnet preview links because I've added a NEXT_PUBLIC_SIDEBAR_LAYOUT  env variable for this preview link.

Sidebar itself includes a couple of minor changes:

Adding <i class="ph-bold ph-arrow-square-out" /> for every external link;
Adding some css improvements for Resources section;

If we all good with this changes (I'd like to wait for @calebjacob approval) then here is the next steps:

Merge this PR, so this will be promoted into production;
I'll add NEXT_PUBLIC_SIDEBAR_LAYOUT=true for all environments on dev-near-org;

Any objections/additions?
cc @charleslavon @calebjacob

Hey @vanessadespain! I think you'd like to take a look at the result of this task. Checkout the dev-near-org preview link at the top

Hey @shelegdmitriy is there an access that needs to be granted to view? I get an error when I click through.

Hey @shelegdmitriy is there an access that needs to be granted to view? I get an error when I click through.

Try this one https://dev-near-org-git-feat-enable-new-90a755-near-developer-console.vercel.app

As per our discussion with @charleslavon, this links will be opened in a new tab:

/blog -> https://near.org/blog;
/events -> https://near.org/events;
/founders -> https://near.org/founders;
/ecosystem -> https://near.org/ecosystem;


Num properties

Instead of using magic number literals when searching for the smallest or largest number in a list, I figured it might be nice to have some of the underlying double properties exposed via the Num class.

Sorry I got so behind on PRs. :( Too many projects, not enough hours.
I think exposing these constants is a great idea. I'm not sure if -DBL_MAX should be exposed separately. (I'm not even sure if that evaluates correctly? Floating point behavior near boundaries confuses me.)
How about we just define getters for DBL_MAX and DBL_MIN? Users can always negate them if they want. Naming is a little tricky. Java calls them MAX_VALUE and MIN_VALUE, respectively. Dart calls them MAX_FINITE and MIN_POSITIVE... which is kind of weird. Ruby just calls them MAX and MIN.
What do you think about largest and smallest?

As far as I know, the floating point number is symmetrical, and since DBL_MAX should be exactly representable, then -DBL_MAX should be as well. But yeah, I'm not 100% sure on that, and my only backing claim is that it works on my machine™. I guess the lowest property is redundant anyway :smiley:
largest and smallest works for me! I'll get around to revising the pull request a bit later.

Groovy, thanks!


Adds the ability to attach files

Adds the ability to attach files to a SendGrid email (https://github.com/sendgrid/sendgrid-php/blob/main/USE_CASES.md#attachments) with new attach() function.
attach() accepts an array of attachments, allowing for multiple files. Each attachment array should contain the content, type, filename, and (optionally) the disposition.
The file content should be base64 encoded prior to attaching. I found that without doing this, the queued jobs were unable to json_encode the payload and failed.
Example:
// At this point $content has been created using file_get_contents, by generating a PDF, or another means.
// Pass this $attachments array into a Notification class with the payload, templateId, etc.
$attachments = array(
    array(
        'content' => base64_encode($content),
        'type' => 'application/pdf',
        'filename' => 'filename.pdf'
    )
);

// In Notification class, pass them to SendGridMessage's attach function.
public function toSendGrid($notifiable)
{
    $email = ( new \NotificationChannels\SendGrid\SendGridMessage($this->templateId) );
    $email->payload($this->payload);

    if ($this->attachments && !empty($this->attachments)) {
        $email->attach($this->attachments);
    }

    return $email;
}

Thank you for the contribution @timstl. Attachments is a nice addition! I'm seeing some potential improvement like supporting the Laravel File object etc. I'll merge this to dev and work on it a bit as well.


Testing pagination off

Removed the paginationStyle attribute

Not required. Completed as part of https://github.com/hmcts/em-ccd-orchestrator/pull/379

Not required. Completed as part of https://github.com/hmcts/em-ccd-orchestrator/pull/379


fix: file uploads FP from Windows client

closes #46

@mhastu the uri path you provided in your issue should match, is a different uri path not matching?
https://regexr.com/7q35l
or is the if header is sent twice?
I'll change the regex to \.file$ at the end if your sure that all requests end with that, it just seems a bit strange

Apologies, I misread the regex and didn't notice that [a-z0+9\.] will match .file. And you're right, there's no need to be overly restrictive with the ending. But in that case, I would handle it like the username and change [a-z0-9\.] to [^/], so it can match any filename.

but have you actually seen requests to remote.php/dav/uploads/ ending in a filename? I'm happy to change the regex to check if it's ending in .file or to a negated set [^/]+ if it's a filename.

No, all the requests of FPs on my system ended in .file.

ok, thank you!
If you encounter another FP where the request uri doesn't end in .file then let me know and we can improve the regex.


BW - 1.5.0 - Release test

Browser Wallet 1.5.0
Feature/regression tests:
Full screen

Switch to full screen
Create account -> simple tx
Wrap CCDs
Dark/Light modes
Close the fullscreen tab -> wrap CCDs -> wallet pops up again

Full screen - observation: While full screen is open, if the user tries to sign tx (wrap CCDs), it could look as if nothing is happening if the user forgot that fullscreen is on or the user has many tabs open.
Identity proofs check for EU nationality is incorrect

Proof explorer -  try to get proof where the set is 27* DK
Tried all the fields for sets to get the proof where the attribute is in the set and attribute is not in the set

Smoke test

Install new version -> recover from seed phrase -> switch to full screen -> create new account -> simple transfer
Install wallet 1.4.2 -> update wallet -> get proofs constructed by proof explorer
Set up new wallet -> create CCD identity -> create account -> create DTS identity -> create account -> make simple transfer

Full screen

Create identity -> add account
Add web3 credentials so that scroll on view activates - > scroll works ok
Import web3 credentials
Import already existing web3 cred
Attempt to import from other file types -> error message
Export web3 credentials
Revoke credentials
Full screen on Chrome on Mac

Import web3 credentials
Revoke web3 credentials


High Rent

Mod

No mod
I get much more high rent complaints from low residential after installing mod.

My setting is too conservative, resulting in too high landvalue, it'll be fix in next version.
ps. connect the low res area with no-block road(highway or use pedestrian to "cut" the roadside block) will do a little better.


Add new variables to support typography tokens

Figma released support for typography variables. We have the font size variables added already, so we should apply those to the styles, but we also need to add in the additional type tokens and update our styles.
They also released support for gradients -- should look into this for our skeleton loaders and brand logo

ready to be exported once the figma-only filter PR is merged! @srambach


Replace email address for public comment

On Meeting/Agenda pages, please replace the email address for submitting public comments via email. Remove<EMAIL_ADDRESS>and replace with<EMAIL_ADDRESS>

Done and deployed. Cc: @shrayshray


[FLINK-13100][network] Fix the bug of throwing IOException while FileChannelBoundedData#nextBuffer

What is the purpose of the change
In the process of FileChannelBoundedData#nextBuffer, the implementation is based on the assumption that there always has an available buffer, otherwise an IOException is thrown. But in the case of pending flush operation that means the socket channel is not writable sometimes while netty thread calling writeAndFlush method, the first fetched buffer from FileChannelBoundedData has not been recycled while fetching the second buffer to trigger next read ahead. Then it would cause this problem to break above assumption.
In order to fix this problem, we could make the assumption that the read ahead is not always available for FileChannelBoundedData. If there are no available buffers to read the next data, we could retrigger the read ahead while recycling buffer via ResultSubpartitionView#notifyDataAvailable.
Brief change log

Move private NoOpResultSubpartitionView class out of PartitionRequestQueueTest
Make BoundedBlockingSubpartitionType configurable in ResultPartitionBuilder for tests usage
Pass BufferAvailabilityListener in the constructor of BoundedBlockingSubpartitionReader
Implement the logic of notifyDataAvailable in BoundedBlockingSubpartitionReader
Fix the logic of FileBufferReader#nextBuffer
Fix the logic of FileBufferReader#recycleBuffer

Verifying this change

Added FileChannelBoundedDataTest#testReadNextBuffer for verifying the logic of nextBuffer
Added FileChannelBoundedDataTest#testRecycleBufferForNotifyingSubpartitionView for verifying the notification of ResultSubpartitionView
Added FileChannelBoundedDataTest#testRecycleBufferForNotifyingBufferAvailabilityListener for verifying the notification of BufferAvailabilityListener

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot attention @pnowojski @StephanEwen
I would add a new ITCase for the code path of BoundedBlockingSubpartitionType#file in a hotfix commit later.

Looking at this now...

My first thought is that it would be great if we could avoid making the bounded data readers aware of the subpartition views.
The way that this pull request changes the code, we do not have the property any more that we gain an abstraction level when going from bounded data to subpartition view.

I will try and see if I can suggest a way to decouple this...

@pnowojski @StephanEwen I have rebased the codes and made some modifications:

Adds the unit tests Stephan provided in his branch.

Make BoundedBlockingSubpartitionType configurable in ITCase/tests.

Add a new ITCase for verifying this fix. This case would throw IOException frequently before fixing, and after fixing it could run correctly.

Also addressed the commit message and constructor issue for Piotr's comments.

@pnowojski I have squashed the commit and addressed the javadoc comment.

Thanks for merging @pnowojski . I would update the ticket.


Adding SEEG electrodes's info in 3D

Hi, recently I've been thinking that showing some info about the SEEG electrodes may be very useful when you move your mouse to the electrode in the figure produced by plot_alignment, for example, the name, the MNI coordinates, and which brain area the electrode is in.
Suggestion:
Adding some info of SEEG electrodes to the figure produced by plot_alignment.
For now, I think these may be useful:
(1) the channel name
(2) the MNI coordinates
(3) the brain area that the electrodes belong to
Now I have figured out how to distinguish the brain area of each electrode belongs, but I don't know how to add the info to the 3D figure when moving the mouse to the electrode.

This is a sample of the info on the brain area.

May be like this

zone_test.zip

can you show an example maybe from another software?
how would you interact with it?
would you use colors? show a text in 3D?

can you show an example maybe from another software? how would you interact with it? would you use colors? show a text in 3D?
Sorry, I just heard from the Pi in my lab, but brainstorm should have this kind of function.
Here is the detail: When you move your mouse to a specific electrode and click on it, the circle that represents the electrode will be highlighted, and in a sub-window, there will be some detailed information of it.

hum... not so easy to do... but I see what you mean

hum... not so easy to do... but I see what you mean

Yes

hum... not so easy to do... but I see what you mean

While the key to implementing this function is  recognizing which electrode the mouse is pointing, then we just extract the info from the table we calculate and show them on a sub-window

So I think if we can show the electrodes' name in this 3D viewer, then what we need to do is simple.

do you think you can give it a try?
Unfortunately I don't have funded projects using sEEG data now to be able
to support this.

do you think you can give it a try? Unfortunately I don't have funded projects using sEEG data now to be able to support this.

I was trying. I didn't find any API or demo that showed that pyvista(or pyvistaqt) could support the move_mouse,  while I have some sample seeg data and its MNI file and the script that decodes where the electrode is. If you could give me some advice like a basic protocol would be great.

I think we can get this almost for free once we allow showing sensors / sensor data in _Brain, so I'll close this for #8382


intermittent issue: events emitted multiple times to single client in seeming infinite loop

nginx reverse proxy
single node (currently)
redis backend to socket-io (this package)
custom pub/sub client
redis cluster (3 instances)
affected client:
socket.io swift client.
issue: on some occasions the client emits/receives events multiple times until stackoverflow on the client. this issue doesn't occur in the simulator, but when compiling the app and testing on the phone it occurs intermittently.

ok, so we eliminated the dupe connections in swift, and now what we are seeing is this:
1 connection, 1 emit
2 received emits at the client.
This seems to indicate the local server is emitting to the room directly, then pub to redis, which is then picked up by the redis sub and emitted again.

Hi! Could that be linked to https://github.com/socketio/socket.io-redis/pull/76?

This seems to indicate the local server is emitting to the room directly, then pub to redis, which is then picked up by the redis sub and emitted again.

Seems weird, it should be prevented by: https://github.com/socketio/socket.io-redis/blob/master/index.js#L110

@darrachequesne you have to publish a release for people to benefit from it. a release hasn't been published since december

Did the last release fix your issue? Else, could you provide a simple test case reproducing the behaviour please?

Closing for now, please reopen if needed.


Speed up with inspect.signature

should instead use inspect.signature to suport *args and **kwargs

added and uses now inspect.signature


[Bugfix] Fix C Jenkinsfile

Checklist

[x] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I followed the [coding and design guidelines](https://artemis-platform.readthedocs.io/en/latest/dev/guidelines

Motivation and Context

Resolves #3484.
Description

Replaces the XML escape code with one that is valid.
Steps for Testing

This PR should be tested on TS2.

Log in to Artemis
Navigate to Course Administration
Create a C Programming Exercise
The process should complete and not fail

From #3491

I looked into the issue and the reason the exception is happening is because the template Jenkinsfile contains the � code on line 87 which cannot be read by Jenkins: sed -i 's/�//g' test-reports/tests-results.xml. It looks like it's trying to replace ESC characters with an empty string. I'm not too sure why it's there and how we can encode the ESC so that it's readable in Jenkins but I would assume that we could just remove the line?

Just my two cents from the analysis of #3499:
The problem is not the XML-file. It contains valid XML. The problem is in the source code that reads back the config.xml from jenkins in JenkinsJobService.getJobConfig. It reads it correctly into an org.jsoup.nodes.Document, however seems to set the output-Options incorrectly. Thus serializing it back with doc.toString() returns a faulty XML with an unencoded ESC-character.
Thus, just correcting the jenkins template will not guarantee that the problem is solved for any other templates.
Michael

Thus, just correcting the jenkins template will not guarantee that the problem is solved for any other templates.

Hm, indeed. I had a further look with the original Jenkinsfile if just changing lines 132 and 194 in JenkinsJobService to document.outputSettings(xmlDocumentOutputSettings()); would fix the issue by applying different OutputSettings as you suggested.
/**
 * Creates a formatting settings object to be used with XML documents sent from/to Jenkins.
 * @return a common format how the XML documents should be formatted.
 */
private org.jsoup.nodes.Document.OutputSettings xmlDocumentOutputSettings() {
    return new org.jsoup.nodes.Document.OutputSettings()
        .syntax(org.jsoup.nodes.Document.OutputSettings.Syntax.xml)
        .escapeMode(Entities.EscapeMode.extended)
        .indentAmount(0)
        .prettyPrint(false);
}

Extended escape mode should escape the problematic character and all similar ones. Updating the permissions however again fails with the same error as before.
If I open the config.xml (successfully created before the failing updatePermissions) in the browser via http://[url.to.jenkins]/job/[folder]/job/[jobname]-BASE/config.xml (just appending the /config.xml when looking at the job in the Jenkins-UI) all problematic characters are properly escaped.
sed -i 's///g' test-reports/tests-results.xml
sed -i 's/<skipped/<error/g' test-reports/tests-results.xml
sed -i 's/<\\/skipped>/<\\/error>/g' test-reports/tests-results.xml

I’m assuming that they are as well when the config.xml is queried in Artemis (though I have not yet checked). When parsing the file they seem to be getting unescaped by the parser, but not re-escaped when writing it back.
There is no issue with other special characters like <, >, and quotes. So in principle the escaping works for all characters that can be reasonably put into and are needed in the Jenkinsfile template with a standard keyboard and should therefore not really be a problem for any exercises. I agree however, that of course it would be nice if the creation does not crash when someone (accidentally?) enters such characters.
Maybe you’ve got another idea where the issue could originate from, @ivanchimeno.

@b-fein I agree with you, your solution should work but for some reason it doesn't. I checked the docs and apparently the output settings should be applied when I use document.html() instead of document.toString(). Sadly, the problem still occurs.
I checked the code and apparently we manually replace characters like <,> when just before creating the build plan and uploading it to Jenkins. This is done in JenkinsBuildPlanCreator lines 127-131.
The crash actually comes from Jenkins which returns a  500 internal error so it's hard to differentiate between errors coming from the user and from the server.


[ExpandableBar]: Adding ExpandableBar.qml + 2 examples + doc

Useful object to create list as tree view

I feel like this is too specific. The way item are layout is just a specific case.
You should simply create a Expandable object with a header and content property. And create an example with your custom header.
I also think your should base your custom header on ItemDelegate where the whole header is clickable. Not just de AppBarButton


code does not compile

Hello there I was following the tutorial for flutter offered by code labs and if you copy the code step by stem it would not compile due to a missing '}' at the last line of code as for the code included at the end it works perfectly

Unfortunately there isn't enough information on this bug to reproduce the issue. Closing for now.
If you are still experiencing this issue, you're welcome to reopen it. Please tell us exactly how to reproduce the problem you're running into. In particular, please include the specific code lab that you're using and the step that gave you the error.
Thank you for using Flutter!


How to deploy EF Migration at Release Time With Azure Pipelines

Is there any documentation for doing EF Migration at release time?  We are using the Azure Pipeline builds and could do it at build time, but that doesn't work because we need to to build once and deploy to each environment.
We do not want to do it at app runtime either.  We want it to be a part of the release.
The only way that I've found to do it is to create a script 'dotnet ef migrations script..' during the build against a *.db file in the repo (which isn't ideal) and then ru nthat sql file during the release.

This is essentially a duplicate of #9841. @BertCotton There is some good information in the discussion on that issue, including a link to a post by Ben Day that should be quite useful.

That's unfortunate.  Maybe some good information but not a solution.  Crazy that has been requested for over 6 months and still no solution.  Definitely not something that would be production ready.


Add anime topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Anime has become really popular over the years. There are many projects with this topic, so some information should be added.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Added the anime topic. This topic's description was taken from Wikipedia.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Sorry im the creater of blockchain and bitcoin i am satoshi nakamoto
On Sun, Oct 2, 2022, 1:03 AM Neki @.***> wrote:

Please confirm this pull request meets the following requirements:

I followed the contributing guidelines:
https://github.com/github/explore/blob/main/CONTRIBUTING.md.
I have no affiliation with the project I am suggesting (as a
maintainer, creator, contractor, or employee).

Which change are you proposing?

Suggesting edits to an existing topic or collection
Curating a new topic or collection
Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

Image (and my file is *.png, square, dimensions 288x288, size <= 75
kB)
Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these
changes should be made.
Curating a new topic or collection

I've formatted my changes as a new folder directory, named for the
topic or collection as it appears in the URL on GitHub (e.g.
https://github.com/topics/[NAME] or
https://github.com/collections/[NAME])
My folder contains a *.png image (if applicable) and index.md
All required fields in my index.md conform to the Style Guide and
API docs: https://github.com/github/explore/tree/main/docs

Anime has become really popular over the years. There are many projects
with this topic, so some information should be added.
Something that does not neatly fit into the binary options above

My suggested edits are not about an existing topic or collection, or
at least not a single one
My suggested edits are not about curating a new topic or collection,
or at least not a single one
My suggested edits conform to the Style Guide and API docs:
https://github.com/github/explore/tree/main/docs

Added the anime topic. This topic's description was taken from Wikipedia
https://en.wikipedia.org/wiki/Anime.

Please note: we will close your PR without comment if you do not check
the boxes above and provide ALL requested information.
You can view, comment on, or merge this pull request online at:
https://github.com/github/explore/pull/3320
Commit Summary

eba1ee2
https://github.com/github/explore/pull/3320/commits/eba1ee2efef58eb41149dd743df4dfca427054c6
Create index.md
e7de91e
https://github.com/github/explore/pull/3320/commits/e7de91e7f67e595c8f77b2046991bdd7d9e3c0bd
Added image
6285246
https://github.com/github/explore/pull/3320/commits/62852468c7a2f9073cdf2903185620b1907664b0
Renamed image
e2c65a2
https://github.com/github/explore/pull/3320/commits/e2c65a20048897b5dce26a342170076c0c81c330
Changed image format

File Changes
(2 files https://github.com/github/explore/pull/3320/files)

A topics/anime/anime.png
https://github.com/github/explore/pull/3320/files#diff-24a9335f4ba0c13ece51c82cc37165e36757c6565cf6736a2483e08d736c348c
(0)
A topics/anime/index.md
https://github.com/github/explore/pull/3320/files#diff-7de2888a56902f332b887ca32082881afccd5d12487285ec81417084b734ee63
(8)

Patch Links:

https://github.com/github/explore/pull/3320.patch
https://github.com/github/explore/pull/3320.diff

—
Reply to this email directly, view it on GitHub
https://github.com/github/explore/pull/3320, or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2JHXLGIZT3MESYSTTX3RWLWBE6W7ANCNFSM6AAAAAAQ2ZOKCM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.

[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection

[x] Curating a new topic or collection

[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)

[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])

[x] My folder contains a *.png image (if applicable) and index.md

[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Anime has become really popular over the years. There are many projects with this topic, so some information should be added.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one

[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one

[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Added the anime topic. This topic's description was taken from Wikipedia.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

bundle install
bundle exec rubocop


fix potential race condition in ALTS integrity-only extra-copy mode

In extra-copy integrity-only mode, the data buffer may be modified by another thread. In current implementation, we compute MAC, then copy. It is not safe. In this PR, we copy data, and compute the MAC on copied data.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

code revised. thanks much for review @yihuazhang

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


TuyaOpenAPI response: {"code":28841101,"msg":"No permissions. This API is not subscribed.","success":false,"t":1632568755009}

TuyaOpenAPI response: {"code":28841101,"msg":"No permissions. This API is not subscribed.","success":false,"t":1632568755009} path = /v1.0/iot-01/associated-users/devices
Failed to get device information. Please check if the config.json is correct.
Please, i need some help.

my api authorized

Hi @telespectadorhd ,
Please refer to this document: https://github.com/tuya/tuya-homebridge/wiki/Tuya-IoT-Platform-Configuration-Guide-Using-Smart-Home-PaaS?_source=d8fba44feeef4757f7f22a14c2295f3f#create-a-project
Authorization、Data Service API missed

Please see https://github.com/tuya/tuya-homebridge/issues/108#issuecomment-958749710

Data Service API doesn't exist in the project, this issue should not have been closed. The info does not resolve the problem. Furthermore, if you're API can't specify the problem in the response to the user, there's no realistic expectation that a user can debug

Following up here, I'm having this issue. But i don't see a fix

i added data dashboard service api and its fixed

I was able to solve the issue by deleting and recreating the Project in the Tuya Developer Platform


(PUP-2573) Make agent locker raise LockError if we fail to aquire lock

This fixes a possible raise condition in the puppet agent where it first
checked if the lock was taken and then later on aquired it, possibly
having some other agent taking the lock in between with no handling of
that situation.
Also it updates the description of the lock method to actually match
what it does, namely return the value of the block itself. Not
true/false based on if lock was acquired. That was in fact impossible to
find out previously.

CLA signed by all contributors.

Hi @dalen.  Thanks for the contribution!  Nice catch on the race condition.
This looks good to me.  I checked any other places we might be calling Agent::Locker#lock and not expecting the new exception being raised and couldn't find any.  We'll get some more eyes on this in the meantime before merging it in.

minor nit, typo in commit subject, should be "acquire"

@richardc will raising an exception break mcollective's puppet-agent plugin? I didn't see the method referenced in https://github.com/puppetlabs/mcollective-puppet-agent/blob/master/util/puppet_agent_mgr/mgr_v3.rb so I think it's ok, but wanted to get your thoughts.

@joshcooper though the plugin loads the puppet library, it triggers runs by sending signals or invoking the cli, so these internal changes shouldn't impact the mcollective agent's operation.

@dalen Looks like this will be good to merge once Josh's latest feedback is addressed.  Thanks!

Hi @dalen.  Just checking in to see if you saw @joshcooper's feedback.  Thanks!

Hi @dalen.  Just checking in again from the PR triage.  We're hoping to merge this after we unfreeze (we have an upcoming release).  Thanks!

Fixed the deprecation of Puppet::Agent::Locker.running? and the call to that from the daemon reload method.

Thanks @dalen! We're getting ready to release 4.2 and are holding off on PRs until after the release. Once that happens we'll get this merged. Thanks again!

@dalen Thanks again for the contribution.  This has been merged into master and should appear in Puppet 4.3.


Add init.py to MAE directory

Codecov Report
Patch and project coverage have no change.

Comparison is base (4c1cf86) 72.09% compared to head (f388674) 72.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   72.09%   72.09%
=======================================
  Files         187      187
  Lines       13108    13108
=======================================
  Hits         9450     9450
  Misses       3658     3658

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Views count on a user should be based on unique visitors

Description
I just tried checking for a user's profile and realized that the view count and kept counting on every refresh.
Screenshots

Additional information
I was wondering if a cookie or some identification can be used to prevent this or is this a feature

should be based on unique visitors

I personally I prefer on total views. Unique could be added but it is very difficult to get accurate.

@damian-wevue I'd work if there were a login feature you know, then we could differentiate between the users by their profile id, but here we can't differentiate between the viewers as it's completely open to view

We have a login feature coming soon, but not everyone will always be logged in - so it helps but still is inaccurate to calculate unique
There are other options like sessions or cookies or ip, but again not accurate. I might close this for now as we have so many other things going on at the moment. We can revisit this in the future
Thank you for the idea @damian-wevue, please keep them coming 👍
Thanks @Aadarsh805 for sharing your thoughts also 👍
Great collaboration everyone 💪


iStore Order - Permissions Access for Service Account to PROD LAN

Title of ticket: iStore Order - Permissions Access for Service Account to PROD LAN
Description
Grant read/write access to production LAN to recently created service accounts.
IDIR: IAOAGILT
IDIR: IAOAGILP
Dependencies
n/a
DOD

[ ] Read/Write Access Granted to IAO Production Fileshare

iStore order submitted 06/16

Access confirmed to all folders today, closing task.


Add continuous mode for X axis

Codecov Report

Merging #151 (60245a5) into main (0a2d192) will increase coverage by 0.07%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   97.74%   97.82%   +0.07%
==========================================
  Files          11       11
  Lines        1198     1242      +44
  Branches      312      316       +4
==========================================
+ Hits         1171     1215      +44
  Misses         23       23
  Partials        4        4

Flag
Coverage Δ

unittests
97.82% <100.00%> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/types.ts
100.00% <ø> (ø)

src/c2mChart.ts
96.38% <100.00%> (+0.21%)
:arrow_up:

src/utils.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Internal: remove lingering mentions of debian-9

We are not running builds or tests on debian-9 anymore. This PR and https://github.com/GoogleCloudPlatform/ops-agent/pull/784 (which could be combined into one PR) clean up all remaining references to debian-9.

LGTM pending the conflicts being resolved.


Range-ify std.string.entab() by adding entabber()

Added entabber() which takes a range as input and and returns a lazy range.
Rewrote entab() to use entabber().
Added support for nelSep.
Fixed bug where trailing spaces followed by newlines were not removed.
Added unittests to fill in missing cases.
100% unittest coverage
Improved documentation.

I think it would be helpful if you didn't mix your GC changes with a crusade against autodecode.
At many places you could probably avoid duplicating code by using std.string.representation.
You'll have to decode anyhow, because a dchar range can't return UTF-8 codeunits and a char range isn't usable as string (e.g. writeln).

I think it would be helpful if you didn't mix your GC changes with a crusade against autodecode.

The original did not autodecode, either, it returned a string in the same encoding as the input.

At many places you could probably avoid duplicating code by using std.string.representation.

byCodeUnit would be better, but I prefer a separate path because the arrays don't require use of .save.

You'll have to decode anyhow, because a dchar range can't return UTF-8 codeunits

entabber is designed to return the same char type as its input. A dchar range would return a dchar range. If you want to convert the output to UTF-8, tack on .byChar.

and a char range isn't usable as string (e.g. writeln).

That would be a bug in writeln, and is not part of the charter of entabber.

LGTM

Let me repeat an important point though. You're introducing a new type of narrow strings here, but at this point, almost no function in phobos can deal with a range of chars. This makes entabber unusable without byDchar, and everyone trying to use it would have to find that out by itself.

So either we autodecode here like in any other range algorithm, or we change all the rest of phobos to handle such ranges (e.g. find), or we tell people to use byDchar.

I know that other algorithms, like std.algorithm.equal, currently fail if presented with a range of chars or wchars. The only solutions are:

fix the algorithms
not have ranges of chars or wchars

I choose option (1). (2) would severely compromise Phobos' utility.


Add spatial transformer sampler

This PR adds a bilinear interpolation of an image, which is described in a paper "Spatial Transformer Networks" (https://arxiv.org/abs/1506.02025).

Hi, thank you very much for sending this nice PR! The shortened names like spatial_tf_sampler and SpatialTfSampler and some other abbreviation for transformer, possibly, seem not to be so necessary for me. Could you consider to replace them with the original verbose name?

Thanks for your comments.
The abbreviation followed cudnn API.
I agree that it is somewhat inconsistent there are mix of functions with and without abbreviation.
I didn't change names of functions that wrap cudnn. Is that O.K.?

Thank you for your PR. This PR is a little long, so I would like to review the test code at first.
About the output array, the current test code checks only its dimension, but I'm afraid that this is insufficient. I believe that it would be better to contain a test code that checks the values of the output array as well.
One way for this is to pass a trivial transformation (identity, 90 degree rotation) for the grid argument, then check if each pixel is correct.
Another way may be to create a hand-created input and compute the correct output (the result of bilinear interpolation) manually, then check if the output of the function matches to the intended output. But this may be too much.

Just for check, I applied the current function implementation to an image with manually set transformation (grid), and got a desired result.
Input:

Output:

For 2x2 image in wikipedia of bilinear interpolation, I got a similar result.

So, although I haven't checked the code thoroughly yet, the code seems to work correctly.

Thanks for reviewing.
I will add tests for forward pass in some simple cases.
Note that the tests for backward pass somewhat guarantee the correctness of the forward pass.

Here is an example code to check spatial transformer if someone wants to try out quickly.
import matplotlib.pyplot as plt
import numpy as np
from skimage.data import astronaut

import chainer.functions as F

img = astronaut()
img_c = img.transpose(2, 0, 1)[None].astype(np.float32)  # (1, 3, H, W)

mesh = np.meshgrid(
    np.linspace(-1., -0., num=128), np.linspace(-1., 0., num=128))
grid = np.stack(mesh)[None]  # (1, 2, h_o, w_o)

out = F.spatial_transformer_sampler(img_c, grid)
out_img = out.data[0].transpose(1, 2, 0)  # (H, W, 3)

plt.subplot(1, 2, 1)
plt.imshow(img)
plt.subplot(1, 2, 2)
plt.imshow(out_img.astype(np.uint8))
plt.show()

@ir5
I added test cases checking forward map that should result in the identity map and the counter clockwise rotation.

@ir5
Thanks for commenting.
Sorry for the Travis error.
I reflected your comments to the code.

Thank you, but there seems to be still some errors... (Maybe PEP8 related things?)

I noticed that this is the problem of autopep8, not this PR. https://github.com/pfnet/chainer/pull/2363

To solve autopep-1.3.0 issue, we need to merge or rebase current master branch. Could you do this?

Thank you. LGTM.

@ir5
I found inefficient code in backward pass of cudnn mode.
I am sorry, but could you check the fix?

Thanks for reviewing. I updated the code

Here is a benchmark code for forward pass.
result
original: 13.65(ms)
changed: 13.59(ms)
import numpy as np
from skimage.data import astronaut

import chainer.functions as F
import time
import cupy

img = astronaut()
img_c = img.transpose(2, 0, 1)[None].astype(np.float32)  # (1, 3, H, W)
img_c = np.repeat(img_c, 36, axis=0)
print img_c.shape

mesh = np.meshgrid(
    np.linspace(-1., 1., num=128), np.linspace(-1., 1., num=128))
mesh = [np.rot90(mesh[0]), np.rot90(mesh[1])]
grid = np.stack(mesh)[None]  # (1, 2, h_o, w_o)
grid = np.repeat(grid, 36, axis=0)

for i in range(5):
    out = F.spatial_transformer_sampler(
        cupy.array(img_c), cupy.array(grid))
    out.data.get()

start = cupy.cuda.Event()
end = cupy.cuda.Event()
start.record()
out = F.spatial_transformer_sampler(
    cupy.array(img_c), cupy.array(grid))
end.record()
end.synchronize()
time = cupy.cuda.get_elapsed_time(start, end)  # milliseconds
print time

Sorry, I found a mistake in my benchmark. I was using cuDNN mode in the benchmark code I used in the previous comments.
The updated benchmark showed some improvement in the performance of code after reducing kernel calls.
On my laptop with Quadro M2000M, here are the time it took to execute the benchmark.
Before reducing number of kernels (before cf74099):   67.4360641479  (ms)
After reducing number of kernels :  63.8747703552(ms)

import numpy as np
from skimage.data import astronaut

import chainer.functions as F
import time
import cupy

img = astronaut()
img_c = img.transpose(2, 0, 1)[None].astype(np.float32)  # (1, 3, H, W)
img_c = np.repeat(img_c, 36, axis=0)
print img_c.shape   # (36, 3, 512, 512)

mesh = np.meshgrid(
    np.linspace(-1., 1., num=128), np.linspace(-1., 1., num=128))
mesh = [np.rot90(mesh[0]), np.rot90(mesh[1])]
grid = np.stack(mesh)[None]  # (1, 2, h_o, w_o)
grid = np.repeat(grid, 36, axis=0).astype(np.float32)   # (36, 2, 128, 128)

# dry run
for i in range(5):
    out = F.spatial_transformer_sampler(
        cupy.array(img_c), cupy.array(grid), use_cudnn=False)
    out.data.get()

times = []
for i in range(5):
    start = cupy.cuda.Event()
    end = cupy.cuda.Event()
    start.record()
    out = F.spatial_transformer_sampler(
        cupy.array(img_c), cupy.array(grid), use_cudnn=False)
    end.record()
    end.synchronize()
    times.append(cupy.cuda.get_elapsed_time(start, end))  # milliseconds)
print np.mean(times)

@beam2d Could you approve this PR? I confirmed that this PR has already passed all Jenkis tests: https://ci-chainer.pfidev.jp/job/chainer-sakura/1326/

Sorry for being late. Approved.


add tag to untagged struct

Add tag to struct to view in uvision watch windows or PcLint output

Unused tags are intentionally left out to be compliant with MISRA C:2012 Rule 2.4.:
"A project should not contain unused tag declarations"