HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length(addendum)

Open this addendum PR to  incorporate @ndimiduk  's suggestions in #2034  and other minor changes.
I did not  use the AtomicLong.getAndAccumulate to replace AtomicUtils.updateMax because
https://issues.apache.org/jira/browse/HBASE-24625?focusedCommentId=17155993&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17155993

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
master passed

+1 :green_heart:
checkstyle
1m 15s
master passed

+1 :green_heart:
spotbugs
2m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
checkstyle
1m 16s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 31s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

35m 39s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c4bfb0d14fd1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3bd54217a0

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
5m 39s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-asyncfs in the patch failed.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
129m 40s
hbase-server in the patch passed.

158m 52s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d0b18669abae 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3bd54217a0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/testReport/

Max. process+thread count
4422 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
6m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 44s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
shadedjars
6m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 43s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
228m 52s
hbase-server in the patch passed.

258m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 04aebd49a52e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3bd54217a0

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/testReport/

Max. process+thread count
3066 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9  @ndimiduk

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
spotbugs
2m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

-0 :warning:
checkstyle
1m  5s
hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 49s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

37m  0s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 9fa3fae695c0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 12s
master passed

+1 :green_heart:
compile
1m 31s
master passed

+1 :green_heart:
shadedjars
6m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  4s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 25s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

+1 :green_heart:
shadedjars
6m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 44s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
216m 25s
hbase-server in the patch passed.

249m 12s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2350e6e60a68 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/testReport/

Max. process+thread count
3075 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 13s
the patch passed

+1 :green_heart:
compile
1m 45s
the patch passed

+1 :green_heart:
javac
1m 45s
the patch passed

+1 :green_heart:
shadedjars
7m 10s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-asyncfs in the patch failed.

-0 :warning:
javadoc
0m 45s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 44s
hbase-asyncfs in the patch passed.

-1 :x:
unit
219m  2s
hbase-server in the patch failed.

255m 46s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 97014b589767 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/testReport/

Max. process+thread count
2992 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
checkstyle
1m 24s
master passed

+1 :green_heart:
spotbugs
2m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

38m 16s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 6d0e4ebc0716 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
5m 48s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-asyncfs in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 26s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
129m  4s
hbase-server in the patch passed.

158m 41s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1b3d18e6402b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/testReport/

Max. process+thread count
4290 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
6m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
6m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
203m 35s
hbase-server in the patch passed.

233m 12s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 01330bad0ec0 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8191fbdd7d

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/testReport/

Max. process+thread count
3642 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 42s
master passed

+1 :green_heart:
checkstyle
1m 15s
master passed

+1 :green_heart:
spotbugs
2m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

-0 :warning:
checkstyle
1m  1s
hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

35m 17s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 502e03105f54 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 11ac0a1ba6

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 21s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
5m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  5s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
151m 34s
hbase-server in the patch passed.

182m  1s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2055

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e46f77754026 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 11ac0a1ba6

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/testReport/

Max. process+thread count
4460 (vs. ulimit of 12500)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2055/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Ordering.Union for IEnumerable

Closed via https://github.com/siroky/FuncSharp/commit/77318802f77aeacb1bec6d01e131796fb0479473


Add EvaluationRunner

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (c43603d) to head (0c2a0d6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #202      +/-   ##
===========================================
+ Coverage   99.36%   100.00%   +0.63%
===========================================
  Files          73        74       +1
  Lines        1720      1743      +23
  Branches      170       170
===========================================
+ Hits         1709      1743      +34
+ Misses         11         0      -11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unittests

Current coverage is 77.40% (diff: 75.45%)

Merging #11 into master will increase coverage by 3.40%

@@             master        #11   diff @@
==========================================
  Files             7         11     +4
  Lines           700       1080   +380
  Methods           0          0
  Messages          0          0
  Branches         56        107    +51
==========================================
+ Hits            518        836   +318
- Misses          158        210    +52
- Partials         24         34    +10

Powered by Codecov. Last update 879b813...a782fe8


Versioning of clientlibs fails on 6.3 author

When we enable versioning on 6.3 author, we are able to see the clientlibs appended with md5. But if we try to edit any component, the overlay edit dialog doesn't close and throws a javascript console error ( can't clear history).

Hey Siva
Is this 6.3 with no Hotfix or Service Pack?
What version of ACS did you install?

it's 6.3.0 without any SP.
And ACS 3.11.0

I cannot reproduce this with 6.3 GA and ACS Commons 3.12.0.
Please provide the precise steps to reproduce and the exact error message seen.

this is the error I get.
core.min.js:21709 Uncaught TypeError: Cannot read property 'clear' of null
at ns.edit.Dialog.onSuccess (core.min.js:21709)
at execute (core.min.js:20817)
at HTMLDocument.handleDialogSuccess (core.min.js:20794)
at HTMLDocument.dispatch (jquery.min.ACSHASHfb50358df4c2bd6aa6e1dd5b0d9b9d29.js:103)
at HTMLDocument.k.handle (jquery.min.ACSHASHfb50358df4c2bd6aa6e1dd5b0d9b9d29.js:96)
at Object.trigger (jquery.min.ACSHASHfb50358df4c2bd6aa6e1dd5b0d9b9d29.js:101)
at HTMLDocument. (jquery.min.ACSHASHfb50358df4c2bd6aa6e1dd5b0d9b9d29.js:115)
at Function.each (jquery.min.ACSHASHfb50358df4c2bd6aa6e1dd5b0d9b9d29.js:28)
at c.fn.init.each (jquery.min.ACSHASHfb50358df4c2bd6aa6e1dd5b0d9b9d29.js:24)
at c.fn.init.trigger (jquery.min.ACSHASHfb50358df4c2bd6aa6e1dd5b0d9b9d29.js:115)
ns.edit.Dialog.onSuccess @ core.min.js:21709
execute @ core.min.js:20817
Steps to follow are

Install 3.11 ( or 3.12 of ACS commons)
create a node of rewrite
Used the default node (/libs/cq/config/rewriter/default) to create http://localhost:4502/apps/XXXX/config/rewriter/versioned-clientlibs following is the json. md5 is being added but edit functionality is broken.
( http://localhost:4502/apps/XXXX/config/rewriter/versioned-clientlibs.json)
{
"jcr:primaryType": "nt:unstructured",
"enabled": true,
"serializerType": "htmlwriter",
"transformerTypes": [
"linkchecker",
"versioned-clientlibs"
],
"order": "1",
"contentTypes": [
"text/html"
],
"generatorType": "htmlparser"
}

There must be other steps you have done. This shows that minimization and MD5 enforcement have been enabled. It is also odd that you would see a line number of 21709 (or 20817) on core.min.js. This file is about 8500 lines minified. And it is obviously odd that this JavaScript request doesn't have the md5 in it.
Please start with a clean 6.3 instance and provide the full steps to reproduce.

Thank you. Just checked a clean instance, doesn't have this issue.  Have to figure out what in our code is causing this issue. Will look into it. Thanks.

ok. I'm going to close this. feel free to reopen if you figure out if it is an issue.


drivers: sensor: lsm303dlhc_mag: Fix gain factor

The magnetometer on the LSM303DLHC has a different gain conversion
factor for LSB to Gauss for the Z axis than it does for X, Y. This
commit takes into account the different conversion factors, and
adds the correct coefficients for each gain setting and axis.
Signed-off-by: Kevin Townsend<EMAIL_ADDRESS>

See table 3 in the datasheet for details:


local deployment configuration

Hi Laurens,
I worked past days to configure YASGUI for a local development setup on a virtual machine containing Virtuoso. I like to share some items that might be useful for other users.
A) CORS enabling
In order to query my Virtuoso on localhost:8890 I needed to enable CORS support on the sparql endpoint of Virtuoso. More info see: http://enable-cors.org/server_virtuoso.html
B) reduction of the default list of SPARQL endpoints
It would be nice if the function  getCkanEndpoints  in endpointCombi.js is configurable with a list. I had to rewrite the list to include the localhost:8890/sparql as default.
C) ability to add pre (and/or post) information to the SPARQL query.
It would be nice if I could configure the following in yasgui-yasge/sparql.js
YASQE.getUrlArguments = function(yasqe, config) {
var queryMode = yasqe.getQueryMode();
/** bert - virtuoso specific **/
var data = [{
name: yasqe.getQueryMode(), //either 'update' or 'query'
value: "define input:default-graph-exclude http://www.openlinksw.com/schemas/virtrdf#, http://localhost:8890/DAV/, http://www.w3.org/2002/07/owl#, http://localhost:8890/sparql, http://www.w3.org/ns/ldp# "+ yasqe.getValue()
}];
Virtuoso allows some additional parametrization beyond the SPARQL syntax. In this case I can avoid to get the content of "system graphs".
D) It is for me unclear what the role is of the server code. It seems dangling around and I wonder if I need it on a pure local install (with no internet connection). Can you enlighten me here?
kind regards,
Bert

Hi Laurens,

I worked past days to configure YASGUI for a local development setup on a virtual machine containing > Virtuoso. I like to share some items that might be useful for other users.

Excellent, thanks for sharing

B) reduction of the default list of SPARQL endpoints
It would be nice if the function getCkanEndpoints in endpointCombi.js is configurable with a list. I had to > rewrite the list to include the localhost:8890/sparql as default.

Good point, I've added a ticket for this (#73)

C) ability to add pre (and/or post) information to the SPARQL query.

Makes sense as well. I've added a YASQE issue for this: https://github.com/YASGUI/YASQE/issues/72

D) It is for me unclear what the role is of the server code. It seems dangling around and I wonder if I need it on a pure local install (with no internet connection). Can you enlighten me here?

The server code is used in the following ways:

Enable URL shortening
Proxy server for CORS-disabled SPARQL endpoints

As you noticed, YASGUI works fine without the server-side part though. A related topic is this one #67 , to split the server and client code.
I'm short on time as I'm busy with other projects as well, so I'll have to prioritize these issues. The smaller issues (B and C) I can probably do in the next few days.

I did some work on this. B Should be configurable now, and in YASQE you should be able to configure the query string before sending the ajax call. The distinction between the YASGUI client and server is now stronger as well, as they are now two different npm modules. (see above links for the related tickets)
Closing this ticket now, but thanks again for providing the feedback


[Feature Request] ADD Notes column to Player List

Explain in detail what your suggested feature would be used for.
Our group moderates instances by age to keep minors safe from adults.  We run solely 18+ Group Public instances.  All of our moderators utilize VRC's Note feature to verify users ages.  If Notes could be added to the Player List tab, this would allow our moderators to quickly locate people who have no data and have not been verified.
Describe how it would look if it requires a UI.
This would simply be one additional Tab in the Player List view.  Preferably sortable and close to Username.  Between Username and Status would be ideal.
Explain why people would want to use it.
This would allow people to sort friends by their notes for a User.  Or in the case of moderation / age verification which has become more prevalent with the addition of Group Instances, would allow a simple tool to assist in verifying and sorting by age or other criteria the Group may wish to track.

Came here to request this feature! It would help me a lot when trying to remove people I don't really know from my friends list


[Suggestion]: import/no-restricted-paths allow exception for dynamic imports

Suggestion
For the import/no-restricted-paths it would be nice to allow a rule or zone to have exceptions for dynamic imports.
Reasoning
I am working on using import/no-restricted-paths to build clear boundaries in a react web-application. As it stands I can handle probably 95% of what I'm trying to achieve, but there are some instances where I need to cross these boundaries. I do so by using the dynamic import and webpack chunks, this ensures the code is not added to my initial bundle.
An example application structure:

/script

/core - Directory for global code use by all features and pages

/layout - Directory holding all components necessary to render a standard application layout
/utilities - Directory for shared utilites that all features and pages can use

/features - Directory for features that pages will use

/feature1
/feature2

/pages - Directory for full applications. The root component of a page will be rendered as a child of the root layout component

/page1
/page2

There are some instances where a subset of logic in a feature would be good to include in the /core/layout components. For example, there's a fullblown feature that lives on page1, but on the layout I want to render a paired down version of this.
Since they share functionality (state management, render logic, etc) duplicating this feature in /core/layout doesn't make sense.
I can ignore these lint errors and warnings, but it would be nice if the lint rule had an option to ignore dynamic imports. I would assume it's not uncommon for this rule to be in place to prevent unwanted dependencies, and in the case of dynamic imports it's not an issue.
I plan on building an example repo to demonstrate my plans, and am willing to look into addressing this if anyone thinks it's not a terrible idea.
Alternative approach
An alternative option would be to simply find a new folder structure to expose "public" features. In the features directories there are many that should not be used publicly, and perhaps just notating as such would solve this problem.

How difficult is this fix? What does the contributor think about such rule setting?


Fixed bug which palo can't compiled by JDK 10, added the compile parameter CPPFLAGS of ncurses-6.0, prevent compilation error

Doris team here is an open Pull Request

Yes, we already accepted this pull request on our private code repo. We are currently trying to find a better way to merge our private code to the apache repo, to avoid chaos on merging code. it may take a while.

Please discuss this process and structure on the dev list. I'd like to understand what the challenges are so that the solution worked out is the best. Keep in mind that the Baidu/palo repository was what was granted to the Apache Software Foundation and one task will be to make sure that all source files have all the proper headers, etc.


Proxy Tickets Are Already Used/Expired Immediately After Being Issued

I have included the following in my report:

CAS server version: 5.0.0.RC1-SNAPSHOT
Container/environment type/version: Tomcat 8.0.32 on MacOSX
Steps to duplicate the problem:

Post a user name and password to /cas/v1/tickets and get a Ticket Granting Ticket.

Post the Ticket Granting Ticket and registered service you want to access (in this case "/protected-web-app") to "/cas/v1/tickets/" where TGT is the Ticket Granting Ticket and obtain a Service Ticket.

Send a GET request to "/cas/serviceValidate" containing the service to access, the Service Ticket, and the proxy URL of the service (in this case "/protected-web-app/proxyUrl" which is the CAS client).  A Proxy Granting Ticket IOU will be issued.

Send a GET request to the proxy URL of the service (in this case "/protected-web-app/proxyUrl" which is the CAS client) and get a Proxy Granting Ticket.

Send a GET request to "/cas/proxy" containing the Proxy Granting Ticket and get a one-time use Proxy Ticket.

Send a GET request to "/cas/proxyValidate" containing the service to access (in this case "/protected-web-app"), the Proxy Ticket, and the proxy URL (in this case "/protected-web-app/proxyUrl" which is the CAS client).  You should get the corresponding Proxy Granting Ticket and proxy URL that was issued for this Proxy Ticket.

Step 6 is where it fails and says the Proxy Ticket was already used.

Stacktraces and CAS logs where appropriate: Link to the log: https://raw.githubusercontent.com/wcrowell/cas-functional-tests/5.0.x/logs/catalina.out

Look at the 2 lines around 4:04:44pm:
2016-08-22 16:06:44,605 DEBUG [org.apereo.cas.ticket.support.MultiTimeUseOrTimeoutExpirationPolicy] - <Ticket usage count 1 is greater than or equal to 1> 2016-08-22 16:06:44,606 DEBUG [org.apereo.cas.ticket.registry.DefaultTicketRegistry] - <Removing ticket [ST-1-pbhtA5brbBiYabVpygfn-192] from the registry.>

The 2 lines you outlined are fine. I am lots more concerned about this:
WARN [org.apereo.cas.web.ProxyValidateController] - <Service ticket [PT-2-f96UqRibdLcYREKZhh9N-192] does not satisfy validation specification.>

Find this line:
https://github.com/apereo/cas/blob/master/cas-server-support-validation/src/main/java/org/apereo/cas/web/config/CasValidationConfiguration.java#L198
Change it to:
c.setValidationSpecification(cas20ProtocolValidationSpecification);

Rerun tests.

Needless to say, if that works submit a PR please :)

Will do.  No problem.

That appears to have fixed it.  Running more tests.


Different configuration per built type

I might be missing something, but judging by the provided samples so far, I don't see a way to set different NDK configuration per build type.
Examples:

Depending on prebuilt library, I'd like to use the debug version of the prebuilt lib when in a debug build type, etc.
Having different cflags per build type, etc.
@ph0b has previously provided a temporary solution using the old-DSL:
Check out http://stackoverflow.com/questions/28878689/android-ndk-and-gradle-different-android-mk-per-build-type for what I am trying to achieve.

might try this:

in module gradle, set build flag for specific build flavor
android.productFlavors {
create("x86-release") {
ndk.abiFilters += "x86"
ndk.CFlags += "-DNO_DEBUG"
}
create("x86-debug") {
ndk.abiFilters += "x86"
ndk.CFlags += "-DDEBUG_ENABLE"
}
}
inside Android Studio, choose the right one to build  with "Build Variant"
if you build from command line, I think you could find the right target to build and build specific one you like and build it etc.

We should have a sample that show this, renaming the issue to track this.

should be possible by adding cFlags into android.buildTypes block.

/cc @rschiu is the new dependencies system capable of resolving debug vs release prebuild?

Yes, if the build type is not specified, it will try to find one that matches the build type of the application


Map our data at county, state, federal level

Context
We want to use maps to:

visualize the work we want to do
track our progress
show close-up views

First experiment: https://github.com/Police-Data-Accessibility-Project/data-source-map/issues/5
Mapping requirements

[ ] We should be able to display the API query and its results in some form near the map for troubleshooting and transparency; See results in a table or Download CSV or at least a link to the raw JSON
[ ] Make sure we pick a mapping library that works well with our stack: Python, Vue, Tailwind

[ ] We need to be able to display

U.S. map (example)

Baseline: represent some metric about each state by making it a color; start with quantity of data sources or something dimple

State-level map

[ ] Simple selector for state
[ ] Like the U.S. map, but color each county

County-level map

[ ] simple selector for state, county
[ ] zoom in on the county
[ ] put a dot for each agency on the map
[ ] when an agency is clicked, show some basic data in a popup

Docs

[ ] A README.md file local to this project, or an entry in /docs
[ ] A link to that README from the app

Long-term ideas for representing our progress:

Phase 1

We think we know about all the agencies in the county.

For the county/each municipality in the county, we have documented

police
courts
corrections

We can point to state-specific rules about police data publishing and access.

These can be in documentation or a database of legislation
Can we include Openstates for relevant legislature?
- Consider: any other helpful integrations to data sources

Phase 2:

See Agencies table

For each of the known agencies from Phase 1, we should have all the required information.
- We need to improve our tools for tracking parent-child relationships and jurisdiction.

Phase 3:

We have combed each state for agencies with a recently-updated counties table.
For the most important record_types, we either have a data source or a records_not_online=TRUE entry
We have contact info for records requests.
similar to Vera's PDTI

Phase 4:

We are publishing tools to normalize, combine, analyze, or otherwise work with local data in the state.

Phase 4 is never really "complete".

@josh-chamberlain I feel like we've already done a lot of this -- is this still a valid issue?


[Select] asChild breaks SelectContent positioning

The SelectContent has a SelectContentContextProvider that wraps its children inside the primitive part, therefore, positioning is breaking because asChild is replacing the provider.
The children need to be wrapped in Slottable or the provider needs to be moved to wrap the primitive.
https://codesandbox.io/s/crimson-meadow-65bzrl?file=/App.js

Hey @jjenzz, awesome work on the quick turn around on the patch. Do you have any idea what a temporary fix could be in the mean-time?

For anyone that comes across this: It seems that the work-around for the time being is simply setting a default value. Not sure what the options are when you don't want a default value.

@JeromeIllgner

For anyone that comes across this: It seems that the work-around for the time being is simply setting a default value. Not sure what the options are when you don't want a default value.

This sounds like a separate issue to the one this one resolves. Your issue sounds related to these #1235 #1231.


how to save the audio data to file with C++ after calling text to speech service?

Hi, I try to modify the sample code quickstart/text-to-speech/cpp-linux/helloworld.cpp to save the audio data to file, but the wav file can't be displayed.
`
void synthesizeSpeech()
{
// Creates an instance of a speech config with specified subscription key and service region.
// Replace with your own subscription key and service region (e.g., "westus").
auto config = SpeechConfig::FromSubscription("xxxx_key", "eastasia");
//config->SetSpeechSynthesisLanguage("zh-CN");
config->SetSpeechSynthesisVoiceName("Microsoft Server Speech Text to Speech Voice (en-US, ZiraRUS)");
// Creates a speech synthesizer using the default speaker as audio output. The default spoken language is "en-us".
auto synthesizer = SpeechSynthesizer::FromConfig(config);

// Receive a text from console input and synthesize it to speaker.
cout << "Type some text that you want to speak..." << std::endl;
cout << "> ";
std::string text;
getline(cin, text);

auto result = synthesizer->SpeakTextAsync(text).get();

// Checks result.
if (result->Reason == ResultReason::SynthesizingAudioCompleted)
{
    cout << "Speech synthesized to speaker for text [" << text << "]" << std::endl;

    auto audiolen = result->GetAudioLength();

    cout << "The audio length is " << audiolen;

    auto audiodata = result->GetAudioData();

    ofstream fout("test.wav", ios::out | ios::binary);
    fout.write((char*)&(*audiodata)[0], audiolen);
    fout.close();
}
else if (result->Reason == ResultReason::Canceled)
{
    auto cancellation = SpeechSynthesisCancellationDetails::FromResult(result);
    cout << "CANCELED: Reason=" << (int)cancellation->Reason << std::endl;

    if (cancellation->Reason == CancellationReason::Error)
    {
        cout << "CANCELED: ErrorCode=" << (int)cancellation->ErrorCode << std::endl;
        cout << "CANCELED: ErrorDetails=[" << cancellation->ErrorDetails << "]" << std::endl;
        cout << "CANCELED: Did you update the subscription info?" << std::endl;
    }
}

// This is to give some time for the speaker to finish playing back the audio
cout << "Press enter to exit..." << std::endl;
cin.get();

}
`

The API creates a raw PCM stream by default.  So by default it is not in wav format.  If you want wav, change the output format to riff.  https://docs.microsoft.com/en-us/dotnet/api/microsoft.cognitiveservices.speech.speechconfig.setspeechsynthesisoutputformat?view=azure-dotnet#Microsoft_CognitiveServices_Speech_SpeechConfig_SetSpeechSynthesisOutputFormat_Microsoft_CognitiveServices_Speech_SpeechSynthesisOutputFormat_


No feedback/notification after seemingly succesful message

Dear all,
I'm trying to implement firebase-php for Cloud Messaging.
After following the instruction and trying to send the message to 1 (my) device, and returning/printing the output of $messaging->send($message) I get this:
a:1:{s:4:"name";s:71:"projects/words-in-progress/messages/0:1577098824177447%f118c3d3f9fd7ecd";}
No notification is coming in, and I don't see the result in the Reports section of the Firebase console. If I validate the message it doesn't throw an exception but returns this:
a:1:{s:4:"name";s:51:"projects/words-in-progress/messages/fake_message_id";}
Which, after reading stuff online seems like the expected result when it's validated.
I'm not sure how I would go about debugging this issue, and I can't find anything online that could help me/direct me to the issue at hand. I've also tried looking in the issues section for a similar issue but couldn't find it.
Can anybody help me with this issue?
Thanks in advance.
Matti

Unfortunately, there‘s not more feedback than the message ID on success, or an exception on error... but perhaps https://firebase.google.com/docs/cloud-messaging/understand-delivery is a good start for the investigation 🤞

In case someone else runs into this problem:
It seems that the way I create the message didn't work as expected, my code was:
$token = $this->GetDeviceTokenByUserID($myId);
$title = "Test title";
$description = "Test description.";
$notification = Notification::create($title, $description);
$fcmOptions = FcmOptions::create()->withAnalyticsLabel('pn_test');
$message = CloudMessage::withTarget('token', $token);
$message->withNotification($notification);
$message->withFcmOptions($fcmOptions);
$resp = $this->GetService()->send($message);
After var_dumping the "message" object I saw NULL values in the Notification object inside Message.
I changed it to:
$token = $this->GetDeviceTokenByUserID($myId);
$title = "Test title";
$description = "Test description";
$notification = Notification::create($title, $description);
$fcmOptions = FcmOptions::create()->withAnalyticsLabel('pn_test');
$message = CloudMessage::withTarget('token', $token)->withNotification($notification)->withFcmOptions($fcmOptions);
$resp = $this->GetService()->send($message);
And now It works as a charm. Thanks jeromegamez for your time and help.

Thank you for adding the code that included the issue as well as the fix, this will hopefully help others.
Just to reconfirm: withers always return a new object, seters change the internal state of an object. (the SDK uses withers almost everywhere ^^)


Add support for v1 AdmissionReview

As pointed out in #55, kubewebhook does not support v1 AdmissionReview, but I assume at some point it will be inevitable to add support for it.

Indeed, Some months back I started adding support for it, but supporting both versions increased the complexity in the code and the API (a lot).
On the other part, supporting v1 instead of v1beta1 doesn't add almost anything. So I decided to stick to v1beta1.
Having said that, I'll not support both versions at the same time, I'll release a v2.x.x of Kubewebhook when v1 is supported, the question is when.
I've been thinking about this, this past month and maybe I update Kubewebhook to Kubernetes v1.19 and then on the next version v1.20 remove support for v1beta and use v1 instead.

On the other part, supporting v1 instead of v1beta1 doesn't add almost anything.

That may have been the case back then, but I think it will make it harder for users (and I mean both end users and consumers of your library) to reliably move between versions (both webhook and Kubernetes), so I'd reconsider adding support for both versions. Otherwise, webhook developers and their users have to time their upgrades perfectly which might leave some of them stuck on older versions with potential bugs or unpatched security versions.
Anyway, my two cents. Thanks for the library!

Hi, @sagikazarmark!
I started working on this, I'll try supporting both as you said, but for that, I need to refactor the library. This will be an v2 of Kubewebhook (I'll be merging on this branch).

Hi @slok, thanks for handling it. Is there any update when this be available?

Hi @akpsgit!
Sorry for the delay, I've been moving to a new house this past month, so... my plan is at Christmas, retake this and spent some part of the holidays on this, hoping in January will be ready.

We''re also interested since returing warnings seems to be part of v1

@slok thanks for the update!

Hi all!
Just to let you know, this weekend I had some time and continue the work.
I'm already handling webhooks in both versions with the same Mutators and Validators, just small tests, but progress is being made. Need to implement stuff, clean up, and polish things because has been a huge refactor.
It will be a breaking change as I said (is v2), however, your mutator/validator logic should be isolated and shouldn't change, just how you set up, configure and communicate with kubewebhook. hope this new API is easier to use.
Also, knowing that v2 will break the API (in favor of a better API and open to support N versions of webhooks), I've refactored also the Prometheus metrics with better insights (e.g tell what is the version of the webhook, warnings...).
On the release, I'll also provide Grafana dashboards for Kubewebhook V2 and some Prometheus alerts examples.
I have some doubts about supporting also tracing on V2. Could you give me feedback about this feature, could you tell me if you use it or provides value?
Besides that, When v2 Is ready for a beta, I'll ask you if you can test it. so it helps to release a faster and more reliable v2 from day one.
Many thanks!

Hello there!
I merged v2 into master and publish a new beta release. If you want you can start testing it! I've tested myself and seems to be working correctly (examples, app running for days in a cluster, integration tests...), however, I'm sure I don't have all the use cases identified. so if you could test it would be awesome.
You can import with:
require (
    // ...
	github.com/slok/kubewebhook/v2 v2.0.0-beta.1
    // ...
)

Apart from the examples and the godocs you can check k8s-webhook-example that has been already updated to use kubewebhook v2.
I've didn't add support for tracing (Maybe I'll add it later) and Prometheus metrics aren't compatible anymore, better metrics but the old Grafana dashboard will break, I need some more time to get some dashboards and alerts.
Thanks for all your help!
cc/ @sagikazarmark @akpsgit @tpihl @sstoner @frimidan @florisvdg

I just published a Grafana dashboard for v2: https://grafana.com/grafana/dashboards/13685

I just published a Grafana dashboard for v2: https://grafana.com/grafana/dashboards/13685

Hello there!
Anyone had the chance to check v2 since I released v2.0.0-beta.1?

Hello there!
Anyone had the chance to check v2 since I released v2.0.0-beta.1?

V2.0.0 released.
Closing


utils use export default and merge d.ts cause code hinting

resolve methods

keep merge d.ts methods
use export function xxx
Forced to use one ts file only export one function named same sa dir
eggs:

all fix, see detail commit 5489781b


feat: set err.headerSent before app error event emit

More of a feature than a fix but 👍

@fengmk2 make a PR to v1.x please.

@dead-horse ok


Add missing edge kinds to the Java EdgeKind enum.

The buildbot failures are unrelated (see #2873) but I'm going to fix those first, hopefully.

Hm. Now I can't get to the buildbots at all. I'm going to merge this for now, and then I'll continue beating on the buildbot issue separately.


What is the index_fill_() functions role??

It's hard to find information about this function.
Can anyone give me some link??
Thanks

https://pytorch.org/docs/stable/tensors.html#torch.Tensor.index_fill_


Arbie & Yin - Solved Issue #4

We edited tests for the cflat compiler so that it passed all the tests when we run make test.
Basic compiler setup
  ✔ Should not crash on instantiation

cflatp parsing
  ✔ Parses simple class with one method

This all makes sense and looks good to me, except the name of this test and the suite it's in:
cflatp parsing
  ✔ Parses simple class with one method

Please use meaningful names for this test (the test is not for parsing, and there are no classes or methods in Cflat, you can say "compiles a simple LIR program" instead), then you can merge this. I'm approving it ahead of time to speed up merging it.

changed "cflatp parsing" to "cflat compiling"
changed "Parses simple class with one method" to "Compiles a simple LIR program"


How to set-up The Graph with Hedera

A guide that describes how to set up The Graph with Hedera.

Follow-up with Smart Contracts team

Example is available in the relay repo

Demo presented and outline provided. Recording available for review.

Tutorial is now live: https://docs.hedera.com/hedera/tutorials/smart-contracts/deploy-a-subgraph-using-the-graph-and-json-rpc


Android Web View - 3rd party cookie testing

Hi, I have gone through the videos and documentation regarding 3rd party cookie deprecation, But I don't find information regarding android web view which is embedded within the app, what are some of the ways to enable "Test Third Party Cookie Phaseout" flag in web view component and test for the deprecation.
Thanks
Vignesh

The third-party cookie phaseout effort is not currently targeting webview and the flag is not available in webview.  The chromestatus.com entry says:
"Third-Party Cookies will be deprecated on Windows, Mac, Linux, Chrome OS, Android. The deprecation will not affect Android WebView for the time being, where 3PCs are already blocked by default, but can be re-enabled by the embedding application."

I found a flag related 3rd pc in webview dev tools, is the something used as testing


reorganize the slider half to fit everything better

started this with PR #8

I'm happy with the current layout. I had gotten suggestions to shift to a vertical stack, with strat on top and sliders below, but I didn't like the look.
I've shifted around the sliders and I like the spacing. If more sliders are added, I may have to make more changes again...


Race condition in Active Events

See PR https://github.com/aol/micro-server/pull/121

Fix in 0.79


Crash upon opening Custom Book

Hey joshiejack! I was testing out your mod and make a custom guide book for my modpack using it. It was going fine until all of a sudden it crashes everytime I open the book, giving me this crash report: http://pastebin.com/tcQnN5jE If you need to survey what the .json file of the book says I also pasted that: http://pastebin.com/5TGMpzkZ

Are you opening the book when held in your hand, or in the library?

Book in my hand

Okay. I will see if I can reproduce later.

From what I can see the crash happens when you enter page number 4, is that correct?

I am getting a crash when opening a custom book in hand as well. The crash happens as soon as the book is opened.

It would have to be caused by something you have added to the custom book. The question is just what.
Does it happen if you try to open the custom book in edit mode too?

It was crashing when I attempted to open the book outside of edit mod.

Are you the one who made the book? If you are, can you try to open it in edit mode?

I made the book for my pack. I am using it for the same reason that the OP is. I have just uploaded a copy of the crash log
http://pastebin.com/6xjPeA5H

I'm sorry I can't use the log for much, since I can't reproduce it. Is there somewhere I can download the modpack, so I can test your book?

I will see what I can do

My crash is unrelated to vagaprime's. It crashes upon opening the book on any page, both in edit mode or normal mode. The only thing I can think of is my custom logo/image on page 1

@SkullyGamingMC try to remove line 5 to 14 in your book .json. That's where it gets the logo from :)


Bug: 'Edit' button is not visible when :delete_with is false

Fixed to show the edit button unless update_with is false.

It happens! No problem.


feat: Add keda, image cleaner, and storage profile configuration support

This PR is included in version 1.2.0 :tada:


finer grained block_synchronizer latching

As discussed with @alsrdn , a finer grained latching mechanism for block_synchronization.

bors r+

bors r+


Autocomplete function

The autocomplete function gives results with no alphabetical order. To make the search optimal it would be very useful that the results were shown ordered.
Example:

Autocompletes are intentially not alphabetic, but rather (very) predictive.  Given the input we predict, with multiple (in taxon name over 20) different queries, which name you are interested in.  For example G alba searches for alba names that start with the genus G.   Notice in your example we put the most probably name first, the exact match, taking spelling into account.


Change inbox cell iconography to show notification type

Move PR/Issue to smaller icon, more info gained from knowing if you’re mentioned or what not.

Bug Report Dump (Auto-generated)

Version 1.11.0 (1943)
Device: iPhone 7 Plus (iOS 11.0.1)
TestFlight: false

Nvm here. The reasons aren't what triggered the notification, only why you are getting the notification. Sort of an origin for your subscription. I saw "mention" and thought "you were mentioned" but it literally means you were mentioned in the thread. Kind of lame.
https://developer.github.com/v3/activity/notifications/#notification-reasons


Fixes #530 NF90 string support

Description

NetCDF still does not provide a proper interface for NF90_String.
As a workaround, this PR introduces a C wrapper that is then accessed
from Fortran.
Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[x] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang I tried your latest push to the branch. I was the print you added that is the attribute name you are trying to get, but this and then another silent failure of the code:
Conventions passed in
NetCDF error: NetCDF: Attribute not found

It should be working now. but still need to test...

I pulled again and tried running. It got past the initial file open, but now threw a strange error later in the server:
 Reading HISTORY RC Files:
 -------------------------
   EXTDATA: EXTDATA::Initialize_: ACTIVE

   EXTDATA: *******************************************************
   EXTDATA: ** Variables to be provided by the ExtData Component **
   EXTDATA: *******************************************************
   EXTDATA: ---- 00001: VAR2D
   EXTDATA: *******************************************************

   EXTDATA: Updating L bracket for VAR2D
   EXTDATA:  ... file processed: /discover/nobackup/projects/gmao/merra2_gmi/work/ExtData/FEER/2009/FEERv1.0-G1.2_so2_20090201.nc4
   EXTDATA: Updating R bracket for VAR2D
   EXTDATA:  ... file processed: /discover/nobackup/projects/gmao/merra2_gmi/work/ExtData/FEER/2009/FEERv1.0-G1.2_so2_20090202.nc4
forrtl: severe (408): fort: (7): Attempt to use pointer I_PTR when it is not associated with a target

Image              PC                Routine            Line        Source
ExtDataDriver.x<PHONE_NUMBER>5EAE7F  Unknown               Unknown  Unknown
libMAPL.pfio.so    00002AAABE273FF2  pfio_serverthread         468  ServerThread.F90
libMAPL.pfio.so    00002AAABE2A8F49  pfio_serverthread        1098  ServerThread.F90
libMAPL.pfio.so    00002AAABE0B3CB8  pfio_messagevisit          87  MessageVisitor.F90
libMAPL.pfio.so    00002AAABE0B14BA  pfio_abstractmess         112  AbstractMessage.F90
libMAPL.pfio.so    00002AAABE12FD74  pfio_simplesocket         105  SimpleSocket.F90
libMAPL.pfio.so    00002AAABE2E01E2  pfio_clientthread         413  ClientThread.F90
libMAPL.pfio.so    00002AAABE30FAF2  pfio_clientmanage         353  ClientManager.F90
libMAPL.ExtData.s  00002AAABA51DAE6  mapl_extdatagridc        1537  ExtDataGridCompMod.F90

Not sure what is going on, maybe I have a mistake in my ExtDataDriver setup but I don't think so. I'll dig in to this when I get back.

I wonder if this is the attempt to write said string back out as metadata in the file?    I'd not properly anticipated that.
One approach might be to convert to NF90_CHAR when reading NF90_STRING.   OTOH, I suspect @weiyuan-jiang can readily construct analogous wrappers for the write phase and then pf90 is a more fully functioning companion for netcdf.

I wonder if this is the attempt to write said string back out as metadata in the file? I'd not properly anticipated that.
One approach might be to convert to NF90_CHAR when reading NF90_STRING. OTOH, I suspect @weiyuan-jiang can readily construct analogous wrappers for the write phase and then pf90 is a more fully functioning companion for netcdf.

@tclune @weiyuan-jiang
This is during read it is like it got a bad address for the data pointer it is reading to...
 466                  ! (1) get address where data should put
 467                  offset    = this%containing_server%prefetch_offset%at(i_to_string(q%request_id))
 468                  address   = c_loc(i_ptr(offset+1))
 469                  ! (2) read data
 470                  call this%get_DataFromFile(q, address, rc=status)
 471                  _VERIFY(status)

I have a very simple test program for read and write. It seems fine. I will double check pfio's conversion.
program main
use pFIO_NetCDF4_FileFormatterMod
use pFIO_FileMetadataMod
use pfio_NetCDF_Supplement
use pFIO_ConstantsMod
implicit none
character(*), parameter :: filename= "test.nc4"
type (NetCDF4_FileFormatter) :: formatter
type (NetCDF4_FileFormatter) :: formatter1
type(Filemetadata) :: cf
! Open file
call formatter%open( filename, pFIO_READ)
cf = formatter%read()
call formatter%close()
call formatter1%create( 'testout.nc4')
call formatter1%write(cf)
call formatter1%close()
end program

@bena-nasa , How does extdata send the request?

@bena-nasa , How does extdata send the request?

@weiyuan-jiang this ultimately happens in request_data_from_file in griddedio/GriddedIO.F90, however, something is going wrong as I put a print right before the 2D datareference (this is a 2D varible) is created which I do not see. I'll have to keep tracing this back and see what is causing it to not enter the correct branch here.

And that is a configuration error, my setup for the tester was defining a 3D variable (should I have been 2D) so when it actually goes to read it was reading to null data reference. When I fix this it is able to ingest the file.

I suspect it goes wrong  when pFIO is preparing for serializing or deserializing of the metadata with string attribute.

I suspect it goes wrong when pFIO is preparing for serializing or deserializing of the metadata with string attribute.

@weiyuan-jiang  All is good as far as ingesting that file via ExtData is concerned. The error today was my setup. As far as I'm concerned the draft status can be removed from this PR.

@bena-nasa Do we need a more informative error when there is a 2D vs 3D mismatch?   Or is that not even possible?

@bena-nasa Do we need a more informative error when there is a 2D vs 3D mismatch? Or is that not even possible?

@tclune Yes, possible, can be done in ExtData. Actually surprised this didn't throw an error so I need to check what is going on.

Should we have @mmanyin test this again before we merge into develop?

Ideally we wait for @mmanyin, but if he's too busy today, let's be optimistic and get this off the to-do list.

@tclune @mathomp4  Yes, this PR finally allows us to use files w/ nc4 strings. Very good!  (Thanks to @mathomp4 for explaining that it also requires ESMA_env v3.5.0 ).

As @mmanyin seems happy, I've removed the blocking label and updated the branch.


Corrected readme

added real time

Testing plan:
GIFs or screenshots:

@rpremOfficial can you talk about why you wanted to make this change?  That feedback is helpful, though I'm not going to merge this PR since we should instead do a broader rewrite of this paragraph since it uses old language rather than just changing this detail; @alya can you make that happen?

Sure, I submitted #20705.


materials project properties

skipping on the total magnetization (https://huggingface.co/datasets/kjappelbaum/chemnlp-mp-magnetization) as, when reading up on it, it seems not super consistent


[Icons] Improve cache warmup by looking at every string

Q
A

Bug fix?
no

New feature?
yes

Issues
n/a

License
MIT

Improve working with dynamic icon names (inspired by https://v2.tailwindcss.com/docs/optimizing-for-production#writing-purgeable-html)
{# This will be cached #}
{{ ux_icon('flag-fr') }}

{# This will NOT be cached #}
{{ ux_icon('flag-' ~ locale) }}

{% set flags = {fr: 'flag-fr', de: 'flag-de'} %} {# both "flag-fr" and "flag-de" will be cached #}
{{ ux_icon(flags[locale]) }}

@smnandre made some fair points about performance/security.
Regarding security: I want to clarify that only strings that match 'foo:bar' will be used to make http requests to iconify. 'foo:bar' will create an http request with this value in the request path but 'something-sensitive' will not. However, 'something:sensitive' would create an http request with this value in the request path.
I'd like to find a compromise that we're all ok with, some thoughts:

opt-in to this much looser string check
configure specific paths/globs (like tailwind does)

We can add a failsafe: store locally the list of available icon prefixes.
Then we reverse the logic:

collect all the icons as you do now
list the prefixes
download the list of icons for each prefix

--> finally download the icons.
It can be even faster in the end, because we can group parallelize + group icon downloads (up to 500 per request)

I'm reading the doc

During development, if you modify an icon, you will need to clear the cache (bin/console cache:clear) to see the changes.

Could we add a isFresh / mtime check about that ? What do you think ?

I believe the security concerns have been alleviated. I now only make the http request if the prefix is valid. 'something:sensitive' will no longer create a request.

I love this!


made MQTT_CALLBACK_SIGNATURE for esp32 functional

#331
Added functional MQTT_CALLBACK_SIGNATURE to enable binding a object method to the callback handler.

Can confirm that this works nicely on an ESP32.  Thanks @jaecktec!


Expose World IO

One liner to expose a very useful IO module for World.
Additionally fixed things that cabal check complained about.

many thanks @dpwiz !


MCMC takes a long time

In my test runs it takes ~ 6 hr for a full MCMC run to complete for the dipole mode parameters. Aside from shrinking the prior volume, what would accelerate this?

I'll have to take a look at the code, but Jax might be a solution.
Otherwise, there's a "new" nested sampler called JaxNS, which seems to function in a similar fashion to Dynesty, but where all the backend stuff is Jaxed. In principle it should be faster, but I haven't really tried it that much.

I would leave JaxNS alone for now - I don't think it is mature enough.


[stable/ambassador] Please add me as repo-collaborator

I am currently an OWNER of the stable/ambassador chart. However, since I am currently not a repo collaborator people are unable to request reviews from me directly.
Could you please add me as a collaborator to resolve this.
Thanks!

@unguiculus Is there anything you need from me to move forward with this?

I would still like to be add as a collaborator. Who should I contact about this?
/reopen

I will add you, was checking the contributions.

I appreciate it! Thanks!


Bigview in inbox when only one message

Currently when there is only one message in the inbox and that message is quite long we can only see the begginning of the message.
With this PR the user can expand the notification by unwraping it and can read the full message

Oh sorry for the 6 commits. I'm creating a new one just wait


More documentation.

Yet another PR for documentation.

Should we use the style adopted in the actual RedPRL output, that is, horizontal lines?

@favonia I don't think it's analogous; the horizontal lines in RedPRL's output distinguish a context from a conclusion within a sequent; but in a presentation of rules, we need a compact way to show a sequent on a single line, so >> or something analogous seems to be what we need there.
Sorry if I misunderstood your suggestion!

Oh, indeed. My suggestion did not make sense. That said, I am worried about |---are we using the pipe in the tactic language?

@favonia The pipe here is to distinguish the subgoals, as a notational convention. It's kind of like how indentation is used in the Nuprl rule presentation.
I think it's irrelevant whether we are using it in the tactic language, because there is no chance of ambiguity.

Unless you are just worried about using the same lexer for both! That's a valid concern, but I'm confident that we can resolve the problem easily if it becomes a problem. Personally, I may not even want to document the ORELSE tactical, seeing as we don't use it in any developments (outside the internals).

If it becomes a problem we can easily fork the lexer. However, I am currently matching only against | when it is the first character of a line.

By the way, #k type at #l is no longer accurate. You are either a member of some universe, or just #k type. (Most (all?) rules handle both uniformally.)

I think that's unnecessarily confusing. Maybe we should have a remark at the top saying that there are also "omega" versions of the rules.

I synthesized the Overview page and redprl.org in a first cut at making the front page of the documentation into a suitable replacement for redprl.org. Please edit as you see fit.
I think it would help to apply some graphic design: it looks incredibly ho-hum right now. Ideas?

@cangiuli  Re: the ho-hum-ness, I'm not sure it's a huge problem? Certainly not against making it better, but I am hoping that we can turn down the propaganda a bit in relation to the old page...

I want "We can prove it!" even without the reference to communist propaganda.


\chordmode vs. \figuremode

What should be the logic for distinguishing what <harm> elements belong to \chordmode and which ones belong to \figuremode?
I think the guidelines and sample set are quite clear that for figured bass, <fb> markup inside <harm> should be used. Therefore I'd use \figuremode for everything with <fb> and \chordmode on everything else.
It has to be kept in mind that both \chordmode and \figuremode might be required in parallel.

I left it out, because <harm> for itself is totally unstructured (unlike in MusicXML). So there is no straight way to convert those to lilypond's \chordmode.
Instead for converting <harm> without <fb> we should use given @startid and treat it as simple \markup (similar to <dir>).
For a more structured approach in MEI you should open a bug over there.


Add a SplashScreen.

Add a Splash Screen which will be shown for 2 seconds.

Hey @aniketsen123
I want to work on this issue under JWOC

I want to work on this issue under JWOC

Please assign me this issue

sure @tusharsh21


API documentation

Add commentaries to each class and method according to Javadoc specification.
See here an example.

30-45 mins. story


Fix templates with only escaped razor

Codecov Report

Merging #84 into master will increase coverage by 0.68%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   55.27%   55.95%   +0.68%
==========================================
  Files          62       62
  Lines        4675     4675
==========================================
+ Hits         2584     2616      +32
+ Misses       1920     1874      -46
- Partials      171      185      +14

Impacted Files
Coverage Δ

template/template_handler.go
66.66% <100%> (+18.23%)
:arrow_up:

collections/implementation/base_helper.go
79.5% <0%> (-1.64%)
:arrow_down:

template/template.go
74.31% <0%> (+2.75%)
:arrow_up:

template/template_process.go
18.75% <0%> (+6.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c06a1...ccb8d8c. Read the comment docs.


Release 4.14.1

Warning: this PR targets master branch, and not dev branch. This is a hotfix, so it branched out to master branch and will need to be backported to dev branch after the merge.

Questions
Answers

Description?
Release 4.14.1. This release only contains the 2 commits needed for 1.7.x -> <IP_ADDRESS> upgrades, nothing more.

Type?
improvement

Context
When the time to do a new release for upgrade module came, we found possible issues (see https://github.com/PrestaShop/autoupgrade/pull/481). In order not to delay anymore the release of PrestaShop <IP_ADDRESS> I submit this hotfix PR for master branch that contains only the needed items for 1.7.x -> <IP_ADDRESS> . The goal is to un-block the <IP_ADDRESS> release.
How to test
I provided below a list of the changes between 4.14.1 and 4.14.0
https://github.com/PrestaShop/autoupgrade/pull/455
https://github.com/PrestaShop/autoupgrade/pull/474

Hello @matks
Thanks for the release!
Tested by @marwachelly & @khouloudbelguith
Autoupgrade <IP_ADDRESS> to <IP_ADDRESS> Mysql 5.7+php 7.1 => (Check BO & FO ) => OK
Rollback <IP_ADDRESS> to <IP_ADDRESS> => (Check BO & FO ) => OK
Autoupgrade <IP_ADDRESS> to <IP_ADDRESS> mysql 8.0 + php 7.2 => (Check BO & FO ) => OK
Rollback <IP_ADDRESS> to <IP_ADDRESS> => (Check BO & FO ) => OK
we detected an error when upgrading from <IP_ADDRESS> (php7.2) to PS<IP_ADDRESS> (release from the branch 1.7.8.x)
Fresh install of Ps <IP_ADDRESS> and installed with arabe language

Tested by me
<IP_ADDRESS> -> <IP_ADDRESS>
The upgrade is success :heavy_check_mark:

But I encountred some issues on FO:

1st issue: modal bad displayed for the new products (not pre-install added) and the product image are bad displayd

https://user-images.githubusercontent.com/23308427/165981280-4e6522d8-0388-493b-8a86-b25ba5040c97.mp4

2nd issue: in my account, the blockwishlist and My alerts are bad displayed

3rd issue: when you try to click on My alerts or Favorites( block wish list) => error 500

https://user-images.githubusercontent.com/23308427/165981525-d0afc534-d6be-4209-9d82-1c0711b96c37.mp4
<IP_ADDRESS> -> <IP_ADDRESS>
The upgrade is success :heavy_check_mark:

But, I encounter some issue on FO:

1st issue: searchbar is bad displayed (known issue) :wink:

2nd issue: modal bad displayed

<IP_ADDRESS> (Arabic install) -> <IP_ADDRESS>
Upgrade Succes :heavy_check_mark:

I encountred some issues:

1st issue: bad display of module

2nd issue: the logo in Delivery Slip and Invoice run away :grin: I encounter this issue only with this shop installed in Arabic

BTW, I didn't encounter the issue of searchbar with this version :sweat_smile:

@Robin-Fischer-PS it's your call if we need to investigate more the issues that we encountred or not?
Thanks!

@hibatallahAouadni When you say "known issues", do you mean there is already a bug report?

@matks Yesss!

@hibatallahAouadni If I read through your report, I focus on X -> <IP_ADDRESS> upgrades and I ignore the known issues it looks like only blocking issue is an error when upgrading from <IP_ADDRESS> (php7.2) to PS<IP_ADDRESS> ; using fresh install of Ps <IP_ADDRESS> and installed with arabe language.
Is that correct?
(I created a bug report for this https://github.com/PrestaShop/PrestaShop/issues/28394)

This problem with the logo is related to tcpdf issues, I remember it was this or deleting images from the server 😕 (two bugs from tcpdf on a different versions)

Hello @matks

only blocking issue is an error when upgrading from <IP_ADDRESS> (php7.2) to PS<IP_ADDRESS> ; using fresh install of Ps <IP_ADDRESS> and installed with arabe language.

This issue is reproduced by @marwachelly, I tried to reproduce it but I didn't encountred :disappointed:
The only issue that I encountered and it's kind of a regression is when I upgraded from <IP_ADDRESS> to <IP_ADDRESS>:

2nd issue: in my account, the blockwishlist and My alerts are bad displayed

3rd issue: when you try to click on My alerts or Favorites( block wish list) => error 500

https://user-images.githubusercontent.com/23308427/165981525-d0afc534-d6be-4209-9d82-1c0711b96c37.mp4
Thanks!


fix: allow running CSVDiff without options

:tada: This PR is included in version 1.2.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: The returned value queried is not necessarily blockBlot

Hi @luin
When I setContents, the table cannot be displayed properly.
You can enter this demo quill-table-better Codepen Demo by following the steps below.

When the formats function is defined in the Container, such as:

TableCell was mistakenly identified as blockBlot.


Bug: Beacon charts from the spreadsheet force the interval, which breaks tables.

Short term solution: Don't add an interval to queries even if loaded from the spreadsheet.
Long term solution: Don't use the spreadsheet any more.

Moved to https://github.com/Financial-Times/next-beacon-dashboard/issues/284


add polar stereo projection

Description
This PR adds polar stereo projection to plot polar regions, such as north and south pole.
Issue(s) addressed
Link the issues to be closed with this PR

fixes #55

Here is the plot using L4 sea-ice thickness from Copernicus. You can find more plots in https://github.com/NOAA-EMC/godas/issues/394

Can you please add an example of using this feature to the tests? I.e. add a new plot to https://github.com/JCSDA-internal/eva/blob/develop/src/eva/tests/config/testIodaObsSpaceAmsuaN19.yaml that uses the polar stereographic projection. Then upload said plot to the PR so we can see it.

Here is the plot using AmsuaN19 data:

@mjhossen this all looks good. However you've caught us at a time where EMCpy is being split off from Eva. Some of the changes here therefore need to be made to EMCpy instead of Eva. Once the split is complete we'll let you know to update the PR.

@kevindougherty-noaa @CoryMartin-NOAA can you help @mjhossen with transferring these changes to EMCpy. I will close this PR since it can no longer be merged with the new structure.


Avoid using hardcoded oauth information when possible

I haven't tested authentication in this branch yet -- I think it will work with arbitrary authentication information, but I'm not 100% certain.

Nevermind -- it looks like there is a context.preauth option that will work. Still probably a good idea to not hardcode the values though.

oh yeah, closing here as preauth is the way it's done in iD also.


Prepare for new azdev

Check if CI works in new azdev https://github.com/Azure/azure-cli-dev-tools/pull/359

Thank you for your contribution! We will review the pull request and get back to you soon.

In this PR, we found that the extension style check is not working for a long time.
It uses
- bash: pip install wheel==0.30.0 pylint==1.9.5 flake8==3.5.0 requests
displayName: 'Install wheel, pylint, flake8, requests'
- bash: python scripts/ci/source_code_static_analysis.py

, which raises
File "/usr/local/lib/python3.6/site-packages/pylint/checkers/imports.py", line 712, in _check_imports_order
    isort_obj = isort.SortImports(
AttributeError: module 'isort' has no attribute 'SortImports'

This is fixed in #6509


issue=#462 python sdk supports batch write/read and delete all versions of a column

#462

supports batch write/read
supports delete all versions of a column

注释用中文好吗？现在不是倡导国际化

新增代码注释不多，注释总量还是挺大
建议注释翻译单开一个issue
中文注释可以抽出来做详细版中文文档

LGTM


FormatException on TextColumn

After migrating to Drift 2.7.0 and WasmSqlite3.loadFromUrl, occasionally getting the below error in Sentry on production on Chrome. This is new.
FormatException: 1234 Blahblahblah Road, Qwertyqwerty, Asdfasdf 12345, United States

Field is defined as:
TextColumn get location => text()();

Implementation:
Future<Database> openDatabase({bool logStatements = false}) async {
  IndexedDbFileSystem fs = await IndexedDbFileSystem.open(dbName: 'db');

  WasmSqlite3 sqlite = await WasmSqlite3.loadFromUrl(
    Uri.parse('sqlite3.wasm'),
    environment: SqliteEnvironment(fileSystem: fs),
  );

  return Database(
    WasmDatabase(
      sqlite3: sqlite,
      path: '/app.db',
      logStatements: logStatements,
    ),
  );
}

minified:lj: FormatException: 1234 Blahblahblah Road, Qwertyqwerty, Asdfasdf 12345, United States
  at A.e(org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart:1128:37)
  at A.dr(org-dartlang-sdk:///lib/_internal/js_runtime/lib/core_patch.dart:174:5)
  at A.bK.prototype.ca(../../../../../../.pub-cache/hosted/pub.dev/drift-2.7.0/lib/src/runtime/types/mapping.dart:147:20)
  at A.lT.prototype.r8(../../../lib/core/database/database.g.dart:2704:12)
  at A.lT.prototype.H4(../../../lib/core/database/database.g.dart:2682:8)
  at A.c_o(org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart:2236:9)
  at MapAndAwait|mapAsyncAndAwait.{<anonymous function>#2}.aRD.prototype.$0(../../../../../../.pub-cache/hosted/pub.dev/drift-2.7.0/lib/src/utils/async.dart:10:53)
  at A.QD(org-dartlang-sdk:///lib/async/future.dart:302:20)
  at A.aRE.prototype.$1(../../../../../../.pub-cache/hosted/pub.dev/drift-2.7.0/lib/src/utils/async.dart:10:35)
  at MappedListIterable.length.V.prototype.cQ(org-dartlang-sdk:///lib/internal/iterable.dart:415:31)

That exception indicates that drift attempted to interpret a string column as an integer.
Looking at lib/core/database/database.g.dart:2704:12, does it seem correct to you that the column gets interpreted as an integer there? Essentially, the question is whether this is a bug in the generated code or another form of the corrupted database problem.

@simolus3 :2704 is indeed an int column, but it's one column after the right column. The correct column for this to be inserted in was the one before, at line :2702, a string column. There is no possible way we tried to insert it to the :2704 column, so no idea how it's getting out of order like that.

Without the source code to reproduce this we have no way to fix it.
I'm closing this issue for now, we'll reopen if we can get something to help us fix it


TextArea Required in Chrome and IE11 not shown has-danger

In my angular page I have a text area input in a modal dialog

when the dialog is shown the textarea is focused. In Firefox the text area is correctly marked with a red outline has-danger.

In Chrome and IE11 the red outline is missing.

When I inspect the dom element however I see in both cases that the text area is nested in a div with class=has-danger but it seemlingy just has no effect.

When I type I see it changing to has-success, when I delete all input and leave the textarea it changes to has-danger again but the display does not change.

- Windows
- IE11, Chrome61, FF55
- bootstrap-4.0.0.beta

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin and report back with your link, Bootstrap version, and specific browser and OS details.

https://github.com/twbs/bootstrap/issues/23391


Incremtental test

This is a:

[ ] bug fix PR with no breaking changes
[X] new functionality
[ ] a breaking change

Description & motivation
Hello!
I have tried to implement at feature to solve https://github.com/mjirv/dbt-datamocktool/issues/40
I have chosen to to make the unit test of incrementality in a separate test metod from the existing unit test functionality.
To use the incremental test the mocked "current state" of the incremental model is to supposed to be delivered to the function in the input mapping at the key of "this".
I have tried to break out some methods from both get_unit_test_incremental_sql and get_unit_test_sql to DRY up the code but am not always sure of what i have done.. However integration tests works.
I have changed some models in the integration tests to also test incremental unit test capability.
So - how is  unit_test_incremental intend to work?

The test creates a copy of current state and creates a table.
The test then creates a merge statement to the table created in step 1.
The test compares output of merged table to expected.

Checklist

[x] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[x] BigQuery
[ ] Postgres
[ ] Redshift
[ ] Snowflake

[ ] I have updated the README.md (if applicable)
[ ] I have added tests & descriptions to my macros (and models if applicable)

@pettersoderlund thanks for submitting this! I'll review and get back to you

I've only taken a quick look, but don't see anything related to incremental strategy. Do you think that supporting the model's strategy (should be at ns.graph_model.config.incremental_strategy) is within the scope of this PR?

I've only taken a quick look, but don't see anything related to incremental strategy. Do you think that supporting the model's strategy (should be at ns.graph_model.config.incremental_strategy) is within the scope of this PR?

I'd say that would be out of scope of this PR @gwalterr  - only merge strategy is supported. However it is not a bad idea to have an incremental_strategy check in the beginning of the test to be explicit about that it is only "merge" strategy that is currently supported. Additional strategies can then be gradually if we get this working.


Error: Unrecognized logical operator: $text

Here's the error:
33jma
2021-02-11 19:40:47+02:00Exception while invoking method 'getResetPasswordEmail' Error: Unrecognized logical operator: $text33jma
2021-02-11 19:40:47+02:00 at packages/minimongo/common.js:579:1533jma
2021-02-11 19:40:47+02:00 at Array.map (<anonymous>)33jma
2021-02-11 19:40:47+02:00 at compileDocumentSelector (packages/minimongo/common.js:572:48)33jma
2021-02-11 19:40:47+02:00 at packages/minimongo/common.js:560:1233jma
2021-02-11 19:40:47+02:00 at Array.map (<anonymous>)33jma
2021-02-11 19:40:47+02:00 at compileArrayOfDocumentSelectors (packages/minimongo/common.js:555:20)33jma
2021-02-11 19:40:47+02:00 at Object.$and (packages/minimongo/common.js:260:7)33jma
2021-02-11 19:40:47+02:00 at packages/minimongo/common.js:583:1433jma
2021-02-11 19:40:47+02:00 at Array.map (<anonymous>)33jma
2021-02-11 19:40:47+02:00 at compileDocumentSelector (packages/minimongo/common.js:572:48)33jma
2021-02-11 19:40:47+02:00 at Matcher._compileSelector (packages/minimongo/matcher.js:116:12)33jma
2021-02-11 19:40:47+02:00 at new Matcher (packages/minimongo/matcher.js:52:29)33jma
2021-02-11 19:40:47+02:00 at hook.findOne (packages/zegenie:redis-oplog/lib/mongo/extendMongoCollection.js:154:27)33jma
2021-02-11 19:40:47+02:00 at MethodInvocation.getResetPasswordEmail (server/methods/users.jsx:534:37)33jma
2021-02-11 19:40:47+02:00 at MethodInvocation.methodMap.<computed> (packages/mdg:meteor-apm-agent/lib/hijack/wrap_session.js:161:30)33jma
2021-02-11 19:40:47+02:00 at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12)33jma
2021-02-11 19:40:47+02:00 at packages/ddp-server/livedata_server.js:719:1933jma
2021-02-11 19:40:47+02:00 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)33jma
2021-02-11 19:40:47+02:00 at packages/ddp-server/livedata_server.js:717:4633jma
2021-02-11 19:40:47+02:00 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)33jma
2021-02-11 19:40:47+02:00 at packages/ddp-server/livedata_server.js:715:4633jma
2021-02-11 19:40:47+02:00 at new Promise (<anonymous>)33jma
2021-02-11 19:40:47+02:00 at Session.method (packages/ddp-server/livedata_server.js:689:23)33jma
2021-02-11 19:40:47+02:00 at packages/mdg:meteor-apm-agent/lib/hijack/wrap_session.js:52:3833jma
2021-02-11 19:40:47+02:00 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)33jma
2021-02-11 19:40:47+02:00 at Session.sessionProto.protocol_handlers.method (packages/mdg:meteor-apm-agent/lib/hijack/wrap_session.js:51:44)33jma
2021-02-11 19:40:47+02:00 at packages/ddp-server/livedata_server.js:559:43

And here's the code firing that error:
Meteor.users.findOne({
  $and:[
    {$text:{$search:string}},
    {$or:[
      {'username':{$regex:value, $options: 'i'}},
      {'profile.name':{$regex:value, $options: 'i'}},
      {'registered_emails.address':{$regex:value, $options: 'i'}},
     ]}
  ]
})

It seems Mini-Mongo also does not support $text. I never personally used it so didn't face it.
I think the way around it since MDG will unlikely do any further development on it is to have a check before any finds for fields we cannot support and revert to the DB

This might help -- had the same issue with redis-oplog: https://github.com/cult-of-coders/redis-oplog/issues/229


Add missed other default case when parsing/inferring XML documents

This PR adds the support for skipping multiple white spaces.
This should have been added but missed. As COMMENT is always skipped here and here but it seems it is possible to have the COMMENT is between white spaces.
In this case, factory.setProperty(XMLInputFactory.IS_COALESCING, true) does not coalesce both white spaces.
In more details,
<a>
  <!-- comment -->
  a
</a>

in this case, <!--comment --> is surrounded with whitespaces.
This produces the events as blow:
XmlEvent.CHARACTERS  # whitespace
XmlEvent.COMMENT     # comment
XmlEvent.CHARACTERS  # whitespace
XmlEvent.CHARACTERS  # "a"

Current codes always filter XmlEvent.COMMENT so it ends up with
XmlEvent.CHARACTERS  # whitespace
XmlEvent.CHARACTERS  # whitespace
XmlEvent.CHARACTERS  # "a"

which does not happen in normal cases because we are coalescing multiple XmlEvent.CHARACTERS into single one.

Current coverage is 90.27% (diff: 50.00%)

Merging #166 into master will decrease coverage by 0.11%

@@             master       #166   diff @@
==========================================
  Files            14         14
  Lines           677        679     +2
  Methods         614        619     +5
  Messages          0          0
  Branches         63         60     -3
==========================================
+ Hits            612        613     +1
- Misses           65         66     +1
  Partials          0          0

Powered by Codecov. Last update 617a31e...a430bca

I am going to merge this.


update Gherkin documents url in README

Summary

just one line change link of gherkin utils
Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[ ] The change has been ported to Java.
[ ] The change has been ported to Ruby.
[ ] The change has been ported to JavaScript.
[ ] The change has been ported to Go.
[ ] The change has been ported to .NET.
[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the CHANGELOG accordingly.

Thanks for pointing this out. You've got us in the middle of a migration.
Gherkin has moved to https://github.com/cucumber/gherkin
I've updated the documentation in 7edaa354ed6c0e1f4f42f23f0406dd37905e1815 to address this.


DDP Support in Notebooks when Launching SLURM (or similar) Jobs

🚀 Feature
For ddp, set _SubprocessScriptLauncher.is_interactive_compatible() to True when multiprocessing is handled by SLURM.  This will allow users to launch jobs from the notebook.
Motivation
Currently a user cannot launch jobs from a notebook because of this check.  If I hard code the True value I am able to launch jobs via notebooks without any issues.
Pitch
class _SubprocessScriptLauncher(_Launcher):
    ...
    @property
    def is_interactive_compatible(self) -> bool:
        if multiprocessing_handled_by_slurm:
           return True
        return False

I am unsure when _SubprocessScriptLauncher.is_interactive_compatible is called if the processing environment is known.
cc @borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7

Hi
I am a bit perplexed by this request. How exactly are you executing your jupyter notebooks in slurm?

Currently a user cannot launch jobs from a notebook because of this check

This is very well the intention. When multiprocessing is handled by SLURM, it means you, the user, and Lightning, should not launch any processes.
I'm pretty sure we won't do what you are pitching. The _SubprocessScriptLauncher does what it says, it can launch a script from within itself and the emphasis here is on script.
The only ddp support we have in interactive environments is through the multiprocessing launcher and the fork start method Trainer(strategy="ddp_notebook" | "ddp_fork").

I use Submitit.  I can load a notebook on the cluster and launch jobs via the notebook.  Really great feature and something I utilize quite a bit.
But yeah, I wasn't sure if you detected that "multiprocessing is handled by slurm" (from the logs) before checking if you could run in interactive mode.  I can check out ddp_notebook, I remember trying that awhile ago and it did not work.

  It does work, I had a bad settings.

@jgbos Glad you found this out yourself. Let us know if you have any further questions.


Collision Prevention No working.

Hi Devs,
First thanks for making this mod.
I tried to config the cfg file.
Below is my setting.
Prevents physics clanking by disabling palmed item collision while moving above CollisionPreventionVelocity. Only for smooth locomotion
Setting type: Boolean
Default value: true
CollisionPrevention = true
Threshold for CollisionPrevention to kick in for palmed items. Lower to 0 to never have collision on the palmed item
Setting type: Single
Default value: 1.5
CollisionPreventionVelocity = 0
I have tried to reload and restart the game but the palming mag still collide with holding mag & gun when moving. Better Hands version 1.1.1 latest H3vr(no alpha)  Index set and locomotion is twin sticks(it is a smooth locomotion right?)

Thank you for the details.
Yes, twin stick is smooth loco. What specific magazine/gun where you trying this on? I made an optimization change in 1.1.1 to collision prevention, but it is possible some magazines are set up differently than others and thus do not work with the change.

All kind of the mags I tried are collided, first I thought was the mod change no taking effect, but I can change the position of the palming item and the key mapping.
Anyway here is my mod list, do you think could be any of the other mods causing this issue?

No, it doesn't look like anything in there would cause an issue.
Are you testing this by moving in the game or just rotating/spinning in place? Right now it uses positional velocity, so rotating/spinning won't actually activate the collision prevention (something I want to change).
Either way, I haven't been able to replicate this yet but I'm also in the process of rewriting much of BetterHands. I'll try to continue investigating and see if I can find the issue. Thanks!

I tested it with normal gameplay, moving around and shooting with left hand palming a mag and holding a fore grip at the same time. The palming mag keep knocking things off my gun.
No problem take your time. If you needed I would happy to provide a video. Just let me know.
Thanks again.

If you are up for it, would you mind giving this new updated version a try whenever you jump in H3VR next? This is an early build of BetterHands 1.2.0 which is largely rewritten and has a different method for CollisionPrevention now.
This new update requires Deli's supplemental H3VR library, Deli.H3VR, if you don't already have it.

Closed for inactivity and due to new releases. Feel free to reopen this if versions 1.2 or 1.3 still have the issue you described.


Replace 1 usage of ULID library with NSUUID

I propose we remove [[ULID new] ulidString] (last usage of ULID), which is in ARTLocalDevice.m.
@ricardopereira, I wanted to see what your thoughts are about this. There might be a good reason its being used instead of the built-in NSString *randomId = [NSUUID new].UUIDString;?
┆Issue is synchronized with this Jira Uncategorised by Unito

See also: https://github.com/ably/ably-cocoa/issues/949

At that time, ULID was the to-go solution defined in the spec. As far as I know, it is safe to use NSUUID. Toni can give you more details on that.

Thanks, @ricardopereira.
@tcard has since responded internally with:

I'm the person who originally introduced ULID for push. there's no need for it, UUID4 is fine