[ENH] Avoid shadow variables

We would like to use the -Wshadow C compiler flag to discover mistakes in our code. However, applying that flag across the board gives warnings from cython-generated code.
Here's an example
# cython: language_level = 3

def a(x):
    pass

def b():
    a(1)

With Cython version 0.29.17 it generates code that shadows local variables:
$ cython cythonshadow.pyx && gcc -Werror=shadow -I/usr/include/python3.8 cythonshadow.c  -c
cythonshadow.c: In function ‘__Pyx_PyObject_Call2Args’:
cythonshadow.c:1903:19: error: declaration of ‘args’ shadows a previous local [-Werror=shadow]
 1903 |         PyObject *args[2] = {arg1, arg2};
      |                   ^~~~
cythonshadow.c:1900:15: note: shadowed declaration is here
 1900 |     PyObject *args, *result = NULL;
      |               ^~~~
cythonshadow.c:1909:19: error: declaration of ‘args’ shadows a previous local [-Werror=shadow]
 1909 |         PyObject *args[2] = {arg1, arg2};
      |                   ^~~~
cythonshadow.c:1900:15: note: shadowed declaration is here
 1900 |     PyObject *args, *result = NULL;
      |               ^~~~
cc1: some warnings being treated as errors

If more people thinks this is desirable, I can prepare a pull request. Vote thumbs up! If people vote thumbs down and prefer readable generated code, let's just close the bug without action.

__Pyx_PyObject_Call2Args has simplified considerably for Cython 3 so in the long-term this specific warning will go away. However, I think we're generally trying to remove as many C warnings as is reasonably possible, so a PR against the 0.29.x branch would be welcome.

a PR against the 0.29.x branch would be welcome.

… if it shows a very low risk of breaking other people's code. If this is already fixed in the latest Cython releases, then the arguments for backporting (or creating) a fix need to be weighed off against the risk of breakage in a (very) stable release series.
Also, I'd rather like to avoid making 0.29.x diverge itself from the master branch, rather than only the other way round. That increases the risk of difficult to resolve merge conflicts and unnoticed merge accidents (such as: still works but generates dead/duplicate/useless code).

No worries, let's do it in measter.
However, I found that the code purposedly uses shadowed variables in the  __PYX_MARK_ERR_POS() macro. If this macro is expanded on a module level, it sets global variables __pyx_filename and __pyx_lineno. However, in a node level, it writes to local variables instead.
This was the first error in the test suite ran with CFLAGS="-Werror=shadow", maybe there are more places where shadowing is used as a feature.
I'll give up for now on this bug.

it sets global variables __pyx_filename and __pyx_lineno. However, in a node level, it writes to local variables instead.

Yes, local variables are the right thing to use here. I think we tried removing the global variables as part of the PEP-489 / module-local state changes. Probably still lingering in an unmerged PR somewhere, but I guess it could just be done independently.

(In case it wasn't clear: PR welcome.)


Update tezedge-client URL

Fix #191
Use URL mentioned in https://github.com/spruceid/ssi/issues/191#issuecomment-847163948

The following tests fail in CI run https://github.com/spruceid/ssi/runs/2659576251:

credential_prove_verify_did_tz1
test_derivation_tz1
test_derivation_tz2


[WIP] support for ingesting metadata in STAC format

Hi @matthewhanson , will use this to keep you updated on the work I'm doing.

The sat-api-lib code is now all in the sat-api repository: https://github.com/sat-utils/sat-api


Add in ability to view custom error props in Bugsnag UI

To do:

[x] Add in support for automatically raising custom attached properties for sub-classed error types.
[x] Add them in as a "Custom Exceptions" error tab.
[x] Fix/Add tests.

Gotchas:

Potentially will cause problems with JSON serialisation when notifying bugsnag, but guessing this is a client consumer anyway so haven't done anything to prevent this.

Fixes: https://github.com/bugsnag/bugsnag-node/issues/101

Cool thanks @kattrali I think you've satisfied what I need to achieve my goals via #103


(PUP-8588) Support multiple implementations for a single task

Previously, tasks could only have a single executable and a metadata
file. Any task with more than one executable would fail to load. In
order to support cross-platform tasks, we now allow tasks to have
multiple implementations, differentiated with the new 'implementations'
key in the metadata.
The 'implementations' key is a list of executable files, along with a
set of 'requirements', which are implementation-defined features that
necessary to run that version of the task. A task can have multiple
executables, so long as the implementations key is present and lists
them. If there are multiple executables but no implementations key, the
task will fail to load as before.
Any task executables that aren't mentioned in the implementations list
are ignored. This helps avoid the scenario where swap files, etc could
cause a task to fail to load. It is an error for the implementations
list to specify an executable file that doesn't exist.
A task with a single executable may have an implementations list, but
doesn't need one. If not specified, the single executable will be
used as the only available implementation, and will be considered
suitable on all targets.

CLA signed by all contributors.

Closing this until we decide exactly how we're talking this feature.


Medison - Clicking the company's name returns "Page Not Found" error

COMPANY: Medison
URL: Medison peviitor.ro
Browser: Google Chrome
Device: laptop
OS: MacOS
Precondition:
The site must be open in browser.
Steps:

Scroll down and locate the "Firme" link button.
Click the "Firme" link button.
Type "Medison" in the search bar.
Click on the company's name under the logo.

Expected results:
Clicking the company name should lead to the company's peviitor scrapers webpage.
Actual result:
Clicking the company's name leads to a "Page Not Found" error.

Thank you!


Reduce size of headings in generated HTML of markdown reviews

@guyus15 thank you for tackling this issue! (https://github.com/world-class/compass/issues/73)
Let me know if the feedback makes sense - essentially we just need to account for all 6 heading sizes and make sure we only change it in the reviews.
I found this stack overflow post entitled How to update a pull request from forked repo? helpful, in case you had any questions on how to submit changes to your PR.

Got you! Will do

Looks good, merging.


add Du & Howison poster submission

Hi,
@jameshowison and I are submitting a poster.
Thanks,
Fan

Thank you!


Write export script for the data to export from Firebase

Link to the pull request: https://github.com/North-Seattle-College/ad440-winter2022-tuesday-repo/pull/17
Time to complete:

This was trickier than it looked - Google has not produced good documentation on how to access firebase in this manner, and how to traverse the tree of collection - documents for a given schema. I tied a few approaches, which worked, such as writing a bash script with username/password auth, but it would not have been reuseable for floop, so I attempted to work out something in python.

Outcome:

Floop has run this script in their production environment, and it did what it was supposed to do - pulled data and saved it to a json file.

Documentation:

go to the floop firebase account and generate a cert file
run the script, and input the path to the cert file you generated in the previous step
the script will generate a file, floop_data.json upon completion

It will be good to know where the exported file can be found. We can create a restricted bucket in S3 and upload the file there. People who need the data can either download to their machines and use it or if they are developing automation scripts for import, they can read from the bucket itself.

HI @toddysm I shared this on Slack, but not here. I created a restricted access bucket when I merged the script https://floop-dataset.s3.us-west-2.amazonaws.com/floop_data_15k.json


z-index value in Vue component changed on build

Hey everyone! First of all, thank you for the great work on this project.
I just found out that if there is a z-index property defined in the style section of a Vue component, it will be changed to 1 after it has been built. I was able to reproduce this behavior on Nuxt.js v1.0.0-rc4.
Example:
components/Nav.vue
<template>
  <nav class="c-nav"></nav>
</template>

<style>
  .c-nav {
    position: fixed;
    z-index: 3; /* will be changed to 1 */
  }
</style>

Setting up the scope attribute doesn't fix the mentioned issue.
Another example is the built-in nuxt-loading component. It has z-index: 999999 which is then changed to 1 once it's built.
My assumption is that there is an issue with the webpack configuration and more specifically the unsafe style optimizations :)

I am unable to replicate this

Please re-open with a reproduction repo

@Atinux I just updated Nuxt.js to v1.0.0-rc6 and the issue is no longer reproducible.


使用一键修复更换<崩坏：星穹铁道 >会导致UnityPlayer.dll丢失

Checklist

[X] My issue was not mentioned by others, and it is not a duplicate issue.

Description
在切换版本后使用一键修复更换<崩坏：星穹铁道 >会导致UnityPlayer.dll丢失
Reproduction Steps
添加其他版本
选择一键更新
下载更新途中会创建UnityPlayer.dll
校验完成后UnityPlayer.dll丢失
Expected Behavior
No response
Screenshots

Starward Version
0.12.0
Windows Version
19045.4651
Log
.

Additional Context
No response

不只是星穹铁道,崩三也会丢失,最麻烦的是,崩三和崩铁的UnityPlayer.dll版本不一致


[Katas] Update README to build katas

Add instructions about building katas locally by building playground

@tcNickolas need advice on following points:

Do you think we should have a README for samples folder? Currently, I don't see any README there.
How about a short section of how to migrate katas from old repository to the new one? I think following things will help:

Sample PR
Dont include images for now, since they need redesign.
Look out for API name changes, if any.
Change link to new QDK documentation.
Get away with relative links for mentioning other katas or previous tasks, describe the things instead

@tcNickolas need advice on following points:

Do you think we should have a README for samples folder? Currently, I don't see any README there.
How about a short section of how to migrate katas from old repository to the new one? I think following things will help:

I would not add it for now - the samples folder is rather self-descriptive and doesn't have any special build instructions or knowledge associated with it. The one sub-folder that is a bit trickier to navigate is estimation, but that one already has its own readme with more details about different samples.

Katas migration is going to be a very short endeavor - the Classic QDK is going to be deprecated in June, so we need to complete migration in about two months. (Plus a lot of katas will need a much more significant rework than that, some even won't be migrated.) So I wouldn't elaborate on it in the readme - the readme should focus on using the new katas and developing them, not on getting them from one specific source.

This information can be good to add to the migration issue, since it is focused specifically on migration and will be closed once that's complete.

Urgh, looks like Prettier is not happy with one of the files, can you take a look to fix? Probably a missing newline somewhere

Todo: update hyperlinks because of header change

Urgh, looks like Prettier is not happy with one of the files, can you take a look to fix? Probably a missing newline somewhere.
Done

Thank you for the updates!


Cannot use with noServer: true

Description
StompServer has mandatory argument of HttpServer. However if multiple websocket connections are needed at one http server, the websocket server needs to be setup with noServer: true as described here:
https://github.com/websockets/ws#multiple-servers-sharing-a-single-https-server
Expectation
This should be possible, so these args are passed further to ws Server constructor:
const stompServer = new StompServer({
        noServer: true
});

Workaround
There is a workaround available to pass an http server which will not be used later:
const stompServer = new StompServer({
        path: '/any-path',
        // this is a fake server passed because stomp-broker-js does not want to pass
        // { server: undefined, noServer: true } to ws library, which is supported and totally should work.
        server: http.createServer()
});

Then websocket server is available anyway at stompServer.socket, and the instruction for multiple socket connection is still able to be followed.

+1


why is this built w/ styled-components instead of cxs?

I've been playing around with this for a while but recently discovered cxs. (awesome work btw)
It seems like the only thing that'd need to be changed is the hoc.
Is there a reason you didn't do this?

I would love a separate version of this with cxs! I think the only reason is that styled-components is widely used and cxs, though I much prefer it, isn’t used by so many apps.
@jxnblk actually built a branch in December using cxs: https://github.com/jxnblk/rebass/tree/cxs

it seems that rebass has come a long way since then.  His current tooltip is a lot cleaner.
I ported the current one to cxs and it only took a tiny bit of changing.

I'll be supporting other libraries in addition to styled-components in a future version. Currently styled-components is probably the most widely used one, so wanted to start there.

yeah but cxs > styled components...
No need to be humble when your work is fantastic, @jxnblk


Improved handling of iOS notifications permissions

In the past, we used "silent" push notifications. These were unreliably delivered to the application. In the event they were actually delivered, they allowed Phoenix to receive a payment as long as:

Phoenix was running in the background
"Background app refresh" was enabled for Phoenix

However, we recently switched to the more reliable method of using notification service extensions (#280). Interestingly this doesn't rely on "background app refresh" permissions. Instead it relies on the Notification Settings:

In order for Phoenix to receive payments in the background, iOS must launch and run our notification service extension (UNNotificationServiceExtension) when it receives a push notification.

If notifications are disabled, iOS will NOT launch our extension
If notifications are enabled, but all 3 options are disabled (lock screen + notification center + banners), then iOS will NOT launch our extension
If ONLY "banners" are enabled, then iOS will NOT launch our extension when the screen is locked

The only reliable configuration is when:

notifications are enabled
either "lock screen" or "notification center" is enabled

What's more, if we don't properly request permission for notifications within the app, then permissions are implicitly disabled.
Traditionally, asking for permission means a screen like this is displayed to the user:

You're only allowed to ask the user once. Further requests are ignored by iOS - nothing is displayed to the user, and your permissions don't change. Because of this Apple has recommended that you ask the user for permission when it's related to an action they're taking within the app.
That is the traditional way to get notification permissions. But there is another way that I think works better for us: provisional permission.
If instead you ask for provisional permission to display notifications, iOS will immediately grant your request, and you will be given the following permissions:

(You'll notice that we're granted permission to run our notification service extension.)
And the first time you display a notification, the user will see something like this:

So to summarize the situation on iOS:

the only way to reliably receive payments in the background is with a notification service extension
iOS will only launch your extension if the user allows a minimal subset of notifications
you can get this minimal subset for free with provisional notifications (it doesn't even prompt the user)
or you can try to get the full set of permissions by prompting the user and hoping they tap "Allow"
but you have to decide between the 2 options, because you're only allowed to ask for authorization once (subsequent requests are ignored by iOS)

What to do ... ?
I think the most important thing is actually receiving the payment in the background. If the user receives the payment, but the app icon doesn't have a badge... well that's better than NOT receiving the payment. If they receive the payment, but the notification wasn't on the lock screen, but only in the notification center... well that's also better than NOT receiving the payment.
Apple's decisions have made things difficult for us, and a bit confusing for the users. Take another look at the screenshots from the Notification settings above. It looks like you're just controlling where the little push notification window is allowed to be displayed. Except you're actually not - you're turning on & off background payments. Because you're controlling whether or not Phoenix is allowed to run in the background.
So probably the most elegant solution for now is to request provisional permissions. This means we won't have to prompt the user for permission when they first start using the app. And by default our extension has permission to run.
If the user disables "background payments" then we'll warn them:
&npsp;
We'll add a new "Background payments" configuration:

Tapping on "Customize in iOS settings" takes the user directly to the proper screen. Also the user can remove the amount from the notification:

And if they fully disable background payments, we explain the problem and how to fix it:

The root of the problem we're trying to solve is this:

^ This is the screen within iOS Settings that allows the user to control notifications.
If I turn off notifications for Signal, I still receive the messages within Signal. I'm only turning off the little push notification windows. I quickly learn that the iOS notification settings simply control what gets displayed in iOS. (E.g. banners, badges, etc).
And it's the same for Facebook. If I disable notifications for Facebook, I still see the posts in my feed. I'm only disabling notifications on iOS.
It's the same for WhatsApp, or Twitter, or Yahoo Finance, or any other app that I can think of.
The problem is that it's not the same with Phoenix. If the user disables notifications, they do not receive the payments within Phoenix. And this is not what they expect.
(I believe this problem is solved with async payments. But those are still a work in progress. What we have right now is the best we can do at the moment.)
So we have to explain to the user:

disable notifications ==> disable background payments

The settings > display options > background payments Screen lists several options that can be checked by the user ; are those options in addition to the iOS settings for Phoenix?

I'm trying to use this screen to explain the above. Tapping  any of those checkboxes takes you to the iOS settings. (Note that it's not possible to programmatically change those settings within Phoenix. The user must make these changes within iOS.) So the effect is something like this:
Video Demo
I think my goal with this design was simply to link the two things mentally: notification settings <=> background payments
They're related. They're in the same screen. I have to enable the "notification center" to enable background payments. And if I'm worried about privacy: there's an option right there to hide amounts.
I don't know if I accomplished my goal. The screenshots can be confusing. But interacting with the UI is more intuitive, and easier to grok.
Maybe I should clearly explain on that screen that "show in notification center" is required.

Ok I understand now. I was not able to test on a device so I was just looking at the screenshots and they made me think that you need to fiddle with those settings within Phoenix. But it's just an information screen.
And by the way, we don't have to detail why background payments are enabled. My suggestion is:

if background payment is enabled:

remove the checkboxes;
state that background payment is enabled 👍 ;
have a button redirecting to the iOS setting screen.

if background payment is disabled, keep what you already have. The screen is a bit intense but that's not a bad thing.

Maybe I should clearly explain on that screen that "show in notification center" is required.

It's already done in the "disabled" scenario so I think you're good.


Feature: scalastyle plugin

Added ScalaStyle XML config to a project and a corresponding section in pom.xml.

As Iulia is not in Avira team here (why?) I assign the code review to Călin.


interface for sipp

@andreabat Did you have a question/description for this issue?

sorry my mistake! bad cut n paste!


add theme Dearmsdan

Check List
Please read and check followings before submitting a PR.

[x] I want to publish my theme on Hexo official website.

[x] I have read the theme publishing doc.
[x] name is unique.
[x] link URL is correct.
[x] preview URL is correct.
[x] preview URL web site is rendered correctly.
[x] Add a screenshot to source/themes/screenshots.
[x] Screenshot filename is same as value of name.
[x] Screenshot size is 800 * 500.
[x] Screenshot file format is png.

[ ] I want to publish my plugin on Hexo official website.

[ ] I have read the plugin publishing doc.
[ ] name is unique.
[ ] link URL is correct.

[ ] Others (Update, fix, translation, etc...)

Languages:
[ ] en English
[ ] ko Korean
[ ] pt-br Brazilian Portuguese
[ ] ru Russian
[ ] th Thai
[ ] zh-cn simplified Chinese
[ ] zh-tw traditional Chinese

... sorry ，I can't handle it very well，git 我不太会玩

在之前的一个空格影响了 netlify- 部署，我以为是图片的大小问题，我把图片压缩大小重新上传了一次，然后发现是theme 的空格问题

The link of the preview image is incorrect. Please rename it.


<EMAIL_ADDRESS>hash check failed

Tried it a few times.  Fails every time.

Same issue for me


Setup Event and Block filters

This creates and installs eth filters for new Blocks and for the RegisteredService event.
This is another step for completion of #2

@karlb I assigned you for review since this has no autoassign setup yet. Feel free to forward the review to other team members :)


Remove unused imports in cython files.

I just removed unused imports in the Cython files and polished them a bit.

Codecov Report

Merging #119 (87431a2) into main (3fd2c6b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           39        39
  Lines         3723      3706   -17
=========================================
- Hits          3723      3706   -17

Impacted Files
Coverage Δ

blacksheep/ranges.py
100.00% <0.00%> (ø)

blacksheep/client/cookies.py
100.00% <0.00%> (ø)

blacksheep/client/session.py
100.00% <0.00%> (ø)

blacksheep/server/routing.py
100.00% <0.00%> (ø)

blacksheep/server/openapi/ui.py
100.00% <0.00%> (ø)

blacksheep/server/application.py
100.00% <0.00%> (ø)

blacksheep/server/normalization.py
100.00% <0.00%> (ø)

blacksheep/server/openapi/common.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd2c6b...87431a2. Read the comment docs.

@myusko thank you! :)


SDK page copy changes

📝 Changed routes:

/auth
/sdk

(view full size)
(view full size)

/solutions/gaming

(view full size)

Commit 17329018bf35cd03ff6ba59c53a9a2a943528969 (https://thirdweb-evkf5bjd5.thirdweb-preview.com).


Add a template for AIAA formatted papers to the list.

I'm not completely sure where the most appropriate location for this template is. It's not an "official quality" template, but handles the vast majority of the tricky legwork for getting AIAA formatting working. It took quite a while to write, so I'd like to save everyone else's time in the future.
PR Source Repo:
https://github.com/waterlubber/awesome-typst
Template Repo:
https://gitlab.com/waterlubber/aiaa-typst-template
If there are any other criteria for templates, or any other places people frequently check, please let me know. There's no point making a template if I'm not going to share it!

Thanks for the awesome contribution @waterlubber !


ci: add libm to nightly C example

CI is failing when building C examples on nightly:
/usr/bin/ld: /home/runner/work/quiche/quiche/examples/build/debug/libquiche.a(std-363511a59ca6fedb.std.2k3kczsj-cgu.0.rcgu.o): undefined reference to symbol 'fmaf@@GLIBC_2.2.5'

stable is ok without it, so I think it's nightly issue.

It's a band-aid so need to find a solution. since we use libm, this should not happen.

Mrged as part of https://github.com/cloudflare/quiche/pull/977.


[Bug]: Site is not filtered by site group in add access list form

NetBox access-list plugin version
1.0.0
NetBox version
3.2.7
Steps to Reproduce

Go to add access list page
Select an existing site group
Open the site drop and notice the results
Remove the site group selection
Open the site drop and notice the results

Expected Behavior
Sites should be filtered by site group
Observed Behavior
Full list of site is displayed

Thanks! I'll take a look hopefully this weekend. Also happy to collaborate.

I'll raise a PR for this today. It's quite an easy fix.


Need accelerator key to open the Yarn Diagram

In the "Yang Diagram" navigator, double click open the "code editor", but there is other way to open the diagram directly from the navigator and open the "Yarn Diagram" than selecting through the menu selection. There is no accelerator key.

Seems to be more Theia related: Allow to choose among openers with a certain keybinding. We should discuss that in Theia.


Added Amr Abouelleil to Contributors.md

-Also fixed Shohre Mansouri's entry (had a space between name and url)

I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Add conceptual docs for react-aria

This adds high level conceptual docs to react aria, including a getting started guide, a document about why react-aria exists and the problems it solves, and documentation about accessibility, interactions, and internationalization. Also adds docs for all of our i18n hooks.

@majornista / @jnurthen -- may be good for you to take a look here if you have a sec!
https://github.com/adobe-private/react-spectrum-v3/pull/471/files#diff-9376b743cd990602084d70eec58dfe43R10

(or the rendered page: https://reactspectrum.blob.core.windows.net/reactspectrum/3f832e7e926a1e5bc71a7d813e461b75d8a134bc/docs/react-aria/accessibility.html)


[Spike] [terra-form-select] Investigate focus to return to select when clicked outside

Feature Request
Investigate whether to focus the select when the menu is closed by clicking outside.
Description

Currently, after opening the menu, when we try to close it by clicking outside, it transfers the focus to the root element.
Mostly all our components put the focus on the element triggering the modal or the menu in this case.
Do we want similar behavior for this as well?
Additional Context / Screenshots

@ Mentions

@StephenEsser @ShettyAkarsh

As I'm looking at examples of accessible selects, the native HTML variant returns focus to the select if a user selects outside of the list. So, we should do the same with our component.
Sources:

https://www.coolfields.co.uk/2011/05/accessible-forms-selects-dropdowns/
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select
https://css-tricks.com/styling-a-select-like-its-2019/

We should look into the drop down component and make sure that it doesn't also have the same problem when we work oon this.

I have a question regarding the mobile view of searchable select variants.

On putting the focus to the input element, the on-screen keyboard pops open in mobiles. Is this a behaviour we want?
On putting the focus on the div wrapping the input, it looks like this-

Which of the two approaches should I go ahead with? Your thoughts @StephenEsser .


Eliminated reDoS progress through font-list

Fix redos, got rid of the entire section there.
Uses built in .font_list routine instead of rolling up it's own.
Accounts for three or more potential fonts in the font-family.

This works for the thing I needed it for, and better references the other things. Corrects a couple errors in svgelements, so I'll need to update that but, I think this mostly is positive overall and corrects some harder to read stuff in fonts.py and gets rid of a wx4.0.7 incompatibility, which is still nominally supported.


Update filter operators usage docs

Fixed the usage example of the filter field with operators
Clarified some documentation about the defaults of the operators filtering feature

In future, I want to deprecate _operators or somehow rewrite them.
I recommend using more flexible and controlled thing Resolver.addFilterArg:
https://github.com/nodkz/graphql-compose/issues/22
Also will be useful read about sorting arguments Resolver.addSortArg:
https://github.com/nodkz/graphql-compose/issues/26

Thanks for PR!

@yoadsn if you will want to make some crazy changes in future and test it with your app.
This will be useful starting point (how to spin up libs on localhost for development): https://github.com/nodkz/graphql-compose-mongoose/issues/4#issuecomment-261262315

Awesome, I was already experimenting locally with integrating DataLoader as a middleware. Figured if it would work nicely for me could be useful as a plugin.. Thanks!


Image get cropped when I try to resize image using Sharp

I faced a problem when I try to resize an image and I tried to keep an aspect ratio but the image get cropped.
Below is the original Image :

When I tried to resize my image with
.resize(401, 300).toFormat('jpg').toBuffer(function(err, data) {
}
then resized image will become :

As, you can see the image got cropped.
Thanks

Hello, did you see the various resize options in the documentation?
http://sharp.dimens.io/en/stable/api-resize/

Hi,
Yes I went through it but didn't get a much idea like what values to select for different resize options when I want to resize my image.
Although I tried with below content but it still provided me cropped image, please let me know if I am doing something wrong.
sharp(imageData).resize(401, 300,{
kernel: sharp.kernel.lanczos2,
interpolator: sharp.interpolator.bicubic
}).toFormat('jpg').toBuffer(function(err, data) {
}
Also the original image is of 585x329 dimensions but with above data, it still getting cropped.
Thanks

The ratio of the widths 585:401 is different to the ratio of the heights 329:300 so by specifying both width and height the image will be cropped as per the docs: "By default, the resized image is centre cropped to the exact size specified."
Perhaps you meant to use max?
sharp(imageData)
  .resize(401, 300)
  .max()
  .toFormat('jpg')
  ...

I tried using max(), although image didn't get cropped which is fine but it get resized on 226 height instead of 300 height.
I used below :
sharp(imageData)
.resize(401, 300)
.max()
.toFormat('jpg')
But it resized to 401,226 dimensions.

Did you see "Use null or undefined to auto-scale the width to match the height"?
sharp(imageData)
  .resize(null, 300)
  ...

Well I tried using null or undefined in .resize(null,300), and it has auto scale the image dimensions to match the height and it becomes 533x300 dimension but this is not required in my scenario.
I am creating On demand Image Resize and the resize image dimensions will be provided dynamically and the image should be resize to the provided dimensions.

Sorry, I don't understand what you're expecting as output.
Perhaps ignoreAspectRatio, which will stretch the image to fit the specific dimensions?
sharp(imageData)
  .resize(401, 300)
  .ignoreAspectRatio()
  .toFormat('jpg')
  ...

I'll need fully-worked input and expected output image dimensions and behaviour to be able to help further.

Hi,
I tried with below parameters and yes it works, its not cropping my image and also resizing my image to provided dimensions.
sharp(imageData)
.resize(401, 300)
.ignoreAspectRatio()
.toFormat('jpg')
Thanks for help.

Glad to hear we got there in the end!
(I was confused by the initial "tried to keep an aspect ratio" comment, which I understood to mean you wanted to maintain the same aspect ratio.)

Sorry, I don't understand what you're expecting as output.
Perhaps ignoreAspectRatio, which will stretch the image to fit the specific dimensions?
sharp(imageData)
  .resize(401, 300)
  .ignoreAspectRatio()
  .toFormat('jpg')
  ...

I'll need fully-worked input and expected output image dimensions and behaviour to be able to help further.

We have upgraded sharp to version 0.23.0. It seems that ignoreAspectRatio() is removed in this version. Is there any workaround to get same functionality that ignoreAspectRatio() function offers?

@Subham115 See https://sharp.pixelplumbing.com/en/stable/api-resize/ especially { fit: 'fill' }


create table posts_customs is using the wrong FK reference

Environment

Elixir version (elixir -v): Elixir 1.3.1
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): SnappyData 1.6-snapshot
Ecto version (mix deps): Problem exists in master.
Database adapter and version (mix deps): custom build
Operating system: centos 7

Current behavior
Errors on statement because database doesn't support FK on non PK columns.
CREATE TABLE APP.POSTS (
	"id" BIGINT NOT NULL,
	"uuid" VARCHAR(36),
	PRIMARY KEY ("id")
);

CREATE UNIQUE INDEX POSTS_UUID_INDEX ON APP.POSTS ("uuid");

CREATE TABLE APP.POSTS_CUSTOMS(
			"post_id" VARCHAR(36) CONSTRAINT "POSTS_CUSTOMS_post_id_fkey" REFERENCES APP.posts("uuid")
)

-- SQL Error [X0Y44]: SQLSTATE=X0Y44,SEVERITY=-1: (Server=snappydata.<IP_ADDRESS>.nip.io[1528],Thread[DRDAConnThread_32,5,gemfirexd.daemons]) Constraint 'POSTS_CUSTOMS_post_id_fkey' is invalid: there is no unique or primary key constraint on table '"APP"."POSTS"' that matches the number and types of the columns in the foreign key.

Expected behavior
https://github.com/elixir-ecto/ecto/blob/599d4a666ccbb7af48988349611938b6ff1606ab/integration_test/support/migration.exs#L65
create table(:posts_customs, primary_key: false) do
  add :post_id, references(:posts, column: :uuid, type: :uuid)
  add :custom_id, references(:customs, column: :bid, type: :binary_id)
end

becomes
create table(:posts_customs, primary_key: false) do
  add :post_id, references(:posts, column: :id, type: :id)
  add :custom_id, references(:customs, column: :bid, type: :binary_id)
end

UUID is not the PK of the posts table, ID is.
create table(:posts) do
      add :title, :string, size: 100
      add :counter, :integer
      add :text, :binary
      add :bid, :binary_id
      add :uuid, :uuid
      add :meta, :map
      add :links, {:map, :string}
      add :public, :boolean
      add :cost, :decimal, precision: 2, scale: 1
      add :visits, :integer
      add :intensity, :float
      add :author_id, :integer
      add :posted, :date
      timestamps null: true
    end

Thank you, however I am thinking I am missing something. A foreign doesn't
need to point to the primary key, it can point to any column. Which
database are you using? I am afraid we are using UUID on purpose but I
would need to double check.
--
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

I've been trying to write an adapter for SnappyData for the last few months.
This database has a limitation that its Foreign Keys must match the Primary Key in the other table as it's   is scalable across multiple machines. I believe other databases allow you to match the FK on the candidate key.
In this case I think the test has a logic error. post_id is referring to entire row in posts.  post_customs looks like some sort of many to many relationship. UUID is just an attribute and does not uniquely identify the row.
I'm on irc in #elixir-lang as iFire if you want to chat.

@fire ok, thank you! I will apply your changes tomorrow, I just need to investigate if we need to port some test over because of the change. :)


Draft+ for SDXL  [draft]

What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog

Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"
Pre checks:

[ ] Make sure you read and followed Contributor guidelines
[ ] Did you write any new necessary tests?
[ ] Did you add or update any necessary documentation? Make sure to also update the NeMo Framework User Guide which contains the tutorials

Checklist when contributing a new algorithm

[ ] Does the trainer resume and restore model state all states?
[ ] Does the trainer support all parallelism techniques(PP, TP, DP)?
[ ] Does the trainer support max_steps=-1 and validation?
[ ] Does the trainer only call APIs defined in alignable_interface.py?
[ ] Does the trainer have proper logging?

Additional Information

Related to # (issue)

Requires https://github.com/NVIDIA/NeMo/pull/9543


为什么首页不是摘要信息呢？

Expected behavior (预期行为)
Actual behavior (实际行为)
Steps to reproduce the behavior (重现步骤)
NexT Informations
Add the  ✔  sign before an item which is affected by this behavior.
NexT Version:

Master
Latest Release
Old version -

NexT Scheme:

All schemes
Muse
Mist
Pisces

Other Informations (Like Browser, System, Screenshots)

你没有提供任何有效的信息。

http://theme-next.iissnan.com/faqs.html#read-more


Homebridge-Wink3 compatibility

If I use this plug-in, either Homebridge or Homebridge-wink3 is not going to be happy with the version of node I'm running. In other words, if I "nvm use 4" then Homebridge starts up fine. If I install the Wink3 plugin, it will not load, unless I "nvm use 8" -- but Homebridge fails. MacOS High Sierra.
I'm using the Homebridge-Wink plugin instead. Not sure which Wink plugin to use?

This is the latest and will be continued to be supported Wink Plugin. . Please post an output of the terminal failure message to further examine the issue

I gave up and started running it on MacOS instead of my Pi3.


Update projects.json

@Sumukha87 you have not added your project in the array
This

should go between line number 112-113

make sure to add a comma(,) on line 112 ( },)


Stop ruff warning about ignore-init-module-imports

This setting was deprecated, so we now no longer specify it. The default behavor is now the same as what the setting gave us.

Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

[ ] Documentation has been updated to reflect change.
[ ] New code has tests, and affected old tests have been updated.
[x] All tests and CI checks pass.
[x] Ensured the pull request title is descriptive.
[ ] Conda lock files have been updated if dependencies have changed.
[ ] Attributed any Generative AI, such as GitHub Copilot, used in this PR.
[x] Marked the PR as ready to review.

As this is a minor development tooling change, I'm going to merge without review.


Default topomap interpolation a bit uglier than some time before

I noticed that current topomap interpolation with extrapolate='head' produces more artifacts at the edges than in the previous version. Take a look at this:
before

now

Now the topos look ok only in extrapolate='local' mode (so I've learnt to like the non-circular convex hull mask).
I think I may be partly responsible for this. I have a vague memory of adding more extrapolation points some time ago to extrapolate='head', but I can't find the PR now.
I'll try to take a look at this in the upcoming week.

@mmagnuski we're making a push to release in a couple of weeks, do you have time to look into this in that time?

I might have some time for this next week, I'll try to look into it!

I still remember about this issue, I might find some time for it tomorrow.

I finally got to it. It turns out my intuition was correct, plot_topomap creates too many extrapolation points:

you can also see that the whole circle was not divided evenly (the red arrow), which was the cause of the funny extrapolation artifacts on the right side of the topos.
I reduced the number of points in the PR (#8645) and fixed the uneven circle division:

It is better, but still could be improved (left: master, right: PR)

I'll see how increasing the distance of extrapolation points and further reducing their number helps, but I would prefer not to overfit to my specific cap layout :), so I would appreciate if other EEG users that experienced this problem let me know.
extrapolate='box' works good in these cases so increasing the distance between the extrapolation points and channels positions should help.

PR on the way?
I would be great if the default could be the best option... just saying

@agramfort Yes, its in progress, I linked it in the post above (#8645).


[4.x] - Remove Microprofile dependencies from SE Telemetry

Resolves #6996

Actually no need to run the server. We need only the config module.


How to send async response?

I can't seem to send an async response. For example, I'm trying
for (const route of routes) {
    Picker.route(`/${route}`, function(params, req, res, next) {
        console.log(' ---- route: ', route)
        const appDir = getAppPath()
        const html = fs.readFileSync(path.resolve(appDir, 'public', 'pages', route, 'index.html'), function() {
            console.log('  -- sending response.')
            res.writeHead(200, {'Content-Type': 'text/html'})
            res.end(html)
        })
    })
}

The async logic fires, but the client doesn't get the response. I'm guessing this is because the res.writeHead and res.end calls are happening after the route handler has returned.
How do we make this work?
The reason I want async is because I think it may perform better with multiple requests (any thoughts on that?). For example, here's the sync version, which works:
for (const route of routes) {
    Picker.route(`/${route}`, function(params, req, res, next) {
        console.log(' ---- route: ', route)
        const appDir = getAppPath()
        const html = fs.readFileSync(path.resolve(appDir, 'public', 'pages', route, 'index.html'))
        console.log('  -- sending response.')
        res.writeHead(200, {'Content-Type': 'text/html'})
        res.end(html)
    })
}

I know I can use wrapAsync, but I think that defeats the purpose of intentionally doing things async.


Wrong information on Service remoting in C# with Reliable Services

The document states The Microsoft.ServiceFabric.Services.Remoting.Runtime namespace contains the extension method CreateServiceRemotingInstanceListeners for both stateless and stateful services that can be used to create a remoting listener by using the default remoting transport protocol. which is not true.
It also does not explain how to communicate with service remoting when service proxying to statefull service.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8902374b-b631-9d50-16ef-1899ea2dd29d
Version Independent ID: 55351e69-aa2a-901c-a563-106b62e3d6ac
Content: Service remoting by using C# in Service Fabric - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-reliable-services-communication-remoting.md
Service: service-fabric
GitHub Login: @vturecek
Microsoft Alias: vturecek

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, we can help redirect you to the right support channel to get an answer to your question: [reference to alternative product/service or community endpoint]. Because this issue does not relate to documentation, we are closing this issue. #please-close


log_processing_rules ignored in ECS task definition

Describe what happened:
I'd like to launch an ECS task on AWS, having the following task def.
[
  {
    "name": "web-service",
    "image": "${webapp_docker_image}",
    "memoryReservation": ${ecs_memory_reservation},
    "memory": ${ecs_memory},
    "essential": true,
    "logConfiguration": {
        "logDriver": "json-file",
        "options": {
            "max-size": "20m",
            "max-file": "1"
        }
     },
     "healthCheck": {
        "command": ["CMD-SHELL", "curl -f http://localhost:$(cat /opt/app/management_port_file)/health || exit 1"],
        "interval": 10,
        "timeout": 3,
        "retries": 3,
        "startPeriod": 30
    },
    "dockerLabels": {
        "com.datadoghq.ad.logs": "[{\"source\": \"java\", \"service\": \"web-service\", \"log_processing_rules\": [{\"type\": \"multi_line\", \"pattern\": \"\\d{4}\\-(0?[1-9]|1[012])\\-(0?[1-9]|[12][0-9]|3[01])\", \"name\": \"new_log_start_with_date\"}]}]"
    },
    "command": [],
    "links": [],
    "mountPoints": [],
    "volumesFrom": [],
    "environment" : [
         { "name" : "CONSUL_HOST", "value" : "${consul_host}" }
       ]
  }
]

Please note that the pattern's \ characters are escaped adding an additional \.
The configuration is not taken into account at all, the other settings (source, service) are ignored as well and the service starts by having docker both for source and service (default).
If I change the pattern to the following, then the source/service name is correctly reported, but the multi-line configuration is still ignored.
"com.datadoghq.ad.logs": "[{\"source\": \"java\", \"service\": \"web-service\", \"log_processing_rules\": [{\"type\": \"multi_line\", \"pattern\": \"\\\\d{4}\\\\-(0?[1-9]|1[012])\\\\-(0?[1-9]|[12][0-9]|3[01])\", \"name\": \"new_log_start_with_date\"}]}]"

This issue was originally reported in https://github.com/DataDog/datadog-agent/issues/1736#issuecomment-395330253
Describe what you expected:
The service should have started correctly, reporting the defined source and service values, and the multi-line log parsing should work as defined in the pattern.
Steps to reproduce the issue:
Define a task with the previous example ECS task definition.
Run the task and observe the aforementioned anomalies in the Log Explorer.
Additional environment details (Operating System, Cloud provider, etc):
Our Amazon infrastucture is managed using Terraform, so the above described ECS task def is interpolated using standard Terraform interpolation first. (Note the ${var} notation on some variables).
The pipeline in DataDog is a clone of the Standard Java pipeline with modifiing the extraction step (1st step) to have the following GROK pattern:
java_smartup %{_date_slf4j}\s+%{_status}\s+\[%{_thread_name}\]\s+\[%{_request_id}\]\s+\[%{_logger_name}\]\s+%{data:message}((\n|\t)%{data:error.stack})?

Also a sample log line from our system is as follows:
2018-06-07 10:58:29.266 ERROR [main] [] [o.s.boot.SpringApplication] Application startup failed
java.lang.IllegalStateException: Failed to execute CommandLineRunner
    at org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:735)
    at org.springframework.boot.SpringApplication.callRunners(SpringApplication.java:716)
    at org.springframework.boot.SpringApplication.afterRefresh(SpringApplication.java:703)
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:304)
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1118)
    at org.springframework.boot.SpringApplication.run(SpringApplication.java:1107)
    at io.smartup.cloud.DiscussionServiceApplication.main(DiscussionServiceApplication.java:16)
Caused by: java.lang.RuntimeException: Stacktraced exception
    at io.smartup.cloud.DiscussionServiceApplication.lambda$clr$0(DiscussionServiceApplication.java:22)
    at org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:732)
    ... 6 common frames omitted

In the Java app, the following Spring Boot configuration (in application.yml) defines the log pattern:
logging:
  level:
    root: WARN
    liquibase: INFO
    io:
      smartup: INFO
  pattern:
    console: "%date{yyyy-MM-dd HH:mm:ss.SSS} %-5level [%thread] [%X{X-B3-TraceId}] [%logger{30}] %msg%n%ex{full}"

This is now working with the following configuration:
    "logConfiguration": {
        "logDriver": "json-file",
        "options": {
            "max-size": "20m",
            "max-file": "3"
        }
    },
    "dockerLabels": {
        "com.datadoghq.ad.logs": "[{\"source\": \"java\", \"service\": \"api-gateway\", \"log_processing_rules\": [{\"type\": \"multi_line\", \"pattern\": \"\\\\d{4}\\\\-(0?[1-9]|1[012])\\\\-(0?[1-9]|[12][0-9]|3[01])\", \"name\": \"new_log_start_with_date\"}]}]"
    },

Another issue we faced is if you have the max-file set to 1 the agent can get stuck in tailing the log file.
Probably a longer term optimization would be to give up if the log file can not be tailed anymore and move on after a while(e.g. it was rotated by logrotate).
It makes sense after all, but maybe you guys want to add it to the docs.
Thanks for the quick fix.

Thanks @matelang for testing out and your feedback, we'll have a look at this limitation.
Cheers


syntax error, unexpected '=', expecting ',' or ';'

I've got the following test code:
proc vertexShade(position: Vec3, in_color: Vec4, color: var Vec4, gl_Position: var Vec3) =
    color = in_color
    gl_Position = position

const vertexShader = toGLSL(vertexShade, "300 es")

Trying to use the generated code results in the following error:
0:12(7): error: syntax error, unexpected '=', expecting ',' or ';'
#version 300 es
precision highp float;
// from vertexShade

in vec3 position;
in vec4 in_color;
out vec4 color;

void main() {
  vec4 = in_color;
  gl_Position = position;
}
 wasn't compiled.
0:12(7): error: syntax error, unexpected '=', expecting ',' or ';'

It looks like vec4 is being treated like a variable name instead of a type

I think color is a function to create colors, so it probably gets confused. Does it work if you use any other name?

I have added this as a test case. This issue appears to have been fix. Please use #head version of vmath for now.


Bad checking of the --pattern argument

First of all, the --pattern argument description is giving very little
information: "used for files globbing"??  I had to try it out to see
how it's used.
Second, the way that it's implemented is probably going to be surprising
for most people.  I'm guessing that almost everyone would expect a
pattern like x* to match all files that begin with x, but it looks
like the pattern is actually matched against the full path that is
copied, and therefore a pattern like x* will either copy a whole
toplevel directory that starts with x or nothing at all if there is
none.
Related to this, it should be clear exactly what gets matched.  In an
attempt to avoid bogus matches in a list that iterates over a list of
globs, I prepended */ to each one (yes, that was a mistake) which
resulted in skipping a toplevel index.html file, and this is
regardless of specifying a full path as my --source or cding into
the directory and using a --source ..  So I'm guessing that this
pattern is matched against the full path without the prefix --source
directory (which is the same as the full container + / + blob name
without the part that is specified in --destination).  Summarizing
this in a short CLI description is going to be difficult, but it is
very needed.
Yet another bit that must be documented is the fact that * matches
any character, including /.  It would have been much better to
have * not match /s, and instead add a ** pattern for that.
Given that there are probably scripts that rely on this behavior of
--pattern (at least the script that I wrote does so), a way to resolve
this would be to add some new --file-pattern that gets matched only
against the basename of files, and not against any directories.  Maybe
also another --path-pattern flag with * not matching /s, and **
that does.

@troydai can speak to more detail, but you can use the --dryrun flag to see what files/blobs would be targeted with --pattern without actually performing the operation.

add to S165.

Hi @elibarzilay, thanks a lot for your feedback. Have you tried --dryrun flag to see the summary of target files?
I will add more detailed description and additional examples for --pattern usage. If you have any suggestion, feel free to let me know.

@juhee0202: first, a dryrun flag is useful, but shouldn't come at the expense of documenting things.  Second, I think that it should be very clear how the match is done, see my comments in the original issue text.  For example, saying that * matches anything including / is useful -- but would ? match / too?  What about [!x]?  Will there be a match if the pattern matches any part of the name, or must it match from the start, from the end, or maybe it must match the whole thing?
I see in your PR that you added some text and some examples, but IMO it's still not answering many of these important questions?
(Extended note: the reason dryrun is insufficient: when you write some script to do something, you want to know that it will continue to behave as it should in the future.  So a dry run on some patterns with some current state of my storage will not be sufficient.)


Corpus size

In the first homework, what is "large enough text data"? Would one book (1 MB) be enough?

Yes, 1 MB of text is enough for this task.


soc: intel_adsp: fix linker script for cavs_v20

Apply a similar fix for cavs_v20 as was done for other cavs platforms in
commit ee7773fb462b ("soc: intel_adsp: fix linker script for XCC").
Without this fix, cavs_v20 build with fail with 0.13.0 Zephyr SDK.
Fixes: 74cc8bee7c56 ("xtensa: cavs_v20: use uncached addresses to support SMP")
BugLink: https://github.com/thesofproject/sof/issues/4703
Signed-off-by: Kai Vehmanen<EMAIL_ADDRESS>

@andyross @nashif @dcpleung The https://github.com/zephyrproject-rtos/zephyr/pull/36055 was a bit stale I'm afraid and merging it caused immediate issues picked up by SOF CI. It seems Daniel's fixes are needed also for the gcc linker in Zephyr SDK 0.13.0.
Here's a quick fix PR that brings cavs20 aligned to rest of the platforms and fixes the build in SOF CI.

@andyross  @nashif this fix unblocks the SOF CI

I confirm either cherry-picking this (c9e73aa32967) or reverting 74cc8bee7c569 addresses ICL compilation failure https://github.com/thesofproject/sof/issues/4703 and unblocks SOF CI. Could this be expedited?


chore: release 4.1.3

:robot: I have created a release *beep* *boop*
4.1.3 (2021-07-17)
Bug Fixes

ava config not work in esm (b5f20bf)
ava tsconfig not work for esm (890f14a)
tests file be overwrite on upgrade and update (b93fca0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mili-project-manager/mtpl-component/releases/tag/v4.1.3 :sunflower:


fix: add lastModified to creation of models

:tada: This PR is included in version 0.297.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixed product screenshot for NPM + GitHub

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
Additional Fix for Readme Screenshot Image

:rocket: PR was released in v0.2.1 :rocket:


Cannot collapse @if blocks in razor files

In any .cs file it's possible to collapse an if block. In a razor file that isn't possible:
@if (foo) {
  <div>
    ...
  </div>
}

When the document is collapsed, that code block remains expanded.
It would be nice to be able to collapse that if to have the same behaviour for both code and markup files.
Interestingly, the html within the block can be collapsed, but not the if block itself.

Thanks @lonix1 for filing. I'm not seeing this behavior locally. Do you have a repro here? This is what I'm seeing for what is available to be folded

Turns out we don't support this, but VS does all on its own, presumably based on TextMate scopes or something. That at least explains why it works in VS not VS Code

Turns out we don't support this, but VS does all on its own, presumably based on TextMate scopes or something. That at least explains why it works in VS not VS Code

Interesting. Is this hard to add because of complexities in @if single vs multiline?

Nah, just a matter of finding the right nodes in the tree. PR in 5.


missing cordova.js file

Tested activity with Sugar0.116 , the activity wasn't starting showing error as-
Traceback (most recent call last):
File "/usr/lib/python3.7/dist-packages/sugar3/activity/webactivity.py" in line 166, in _app_cheme_cb
request.finish(Gio.File.new_for_path(path).read(None),
gi.repository.GLib.Error: g-io-error-quark: Error opening file /usr/share/sugar/activities/PhysicsJS.activity/cordova.js: No such file or directory (1)
Fixed error by adding required file.

Hmmm. The cordova.js file is not supposed to be include in the activity.
It's provided by Sugarizer. See in index.html :
<script type="text/javascript" src="../../cordova.js"></script>
Do you add it at the root of the activity or in ../.. ? guess it's in /usr/share/sugar

I tried adding to the root of the activity. I have no file named cordova.js in /usr/share/sugar. I am running on 0.116 Sugar .

The file doesn't exist because it's a file specific for Android/iOS devices.
When you said:

Fixed error by adding required file.

Did you copy it into /usr/share/sugar ?

Did you copy it into /usr/share/sugar ?

@llaske No I have copied it inside /usr/share/sugar/activities/PhysicsJS.activity ,

File "/usr/lib/python3.7/dist-packages/sugar3/activity/webactivity.py" in line 166, in _app_cheme_cb
request.finish(Gio.File.new_for_path(path).read(None),
gi.repository.GLib.Error: g-io-error-quark: Error opening file /usr/share/sugar/activities/PhysicsJS.activity/cordova.js: No such file or directory (1)

As error is about not getting file there.

Ok, could you try to add it into /usr/share/sugar instead of into the activity directory.
This file is need for several activities.

Okay Sure.

Closing


Panic while shutting down Cilium agent where some fields were not initialized

2022-09-08T22:48:24.759005350Z [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x268f542]
2022-09-08T22:48:24.759007649Z
2022-09-08T22:48:24.759009565Z goroutine 407 [running]:
2022-09-08T22:48:24.759011375Z github.com/cilium/cilium/daemon/cmd.NewDaemon.func5()
2022-09-08T22:48:24.759013104Z 	/go/src/github.com/cilium/cilium/daemon/cmd/daemon.go:839 +0x22
2022-09-08T22:48:24.759014773Z github.com/cilium/cilium/daemon/cmd.(*cleanupFuncList).Run(0xc0000733c0)
2022-09-08T22:48:24.759016549Z 	/go/src/github.com/cilium/cilium/daemon/cmd/cleanup.go:44 +0x9d
2022-09-08T22:48:24.759018212Z github.com/cilium/cilium/daemon/cmd.(*daemonCleanup).Clean(0xc000b1b710)
2022-09-08T22:48:24.759019875Z 	/go/src/github.com/cilium/cilium/daemon/cmd/cleanup.go:51 +0x35
2022-09-08T22:48:24.759021812Z github.com/cilium/cilium/daemon/cmd.registerDaemonHooks.func2({0x2977a40, 0x353ae80})
2022-09-08T22:48:24.759023510Z 	/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:1579 +0x30
2022-09-08T22:48:24.759025313Z go.uber.org/fx/internal/lifecycle.(*Lifecycle).runStopHook(0xc000146630, {0x3568240, 0xc00012d5c0}, {0xc000b284b0, 0xc000a67488, {{0xc000a3da00, 0x3a}, {0x3e638eb, 0x31}, 0x14c}})
2022-09-08T22:48:24.759034482Z 	/go/src/github.com/cilium/cilium/vendor/go.uber.org/fx/internal/lifecycle/lifecycle.go:195 +0x208
2022-09-08T22:48:24.759036452Z go.uber.org/fx/internal/lifecycle.(*Lifecycle).Stop(0xc000146630, {0x3568240, 0xc00012d5c0})
2022-09-08T22:48:24.759038148Z 	/go/src/github.com/cilium/cilium/vendor/go.uber.org/fx/internal/lifecycle/lifecycle.go:160 +0x348
2022-09-08T22:48:24.759039870Z go.uber.org/fx.withTimeout.func1()
2022-09-08T22:48:24.759041616Z 	/go/src/github.com/cilium/cilium/vendor/go.uber.org/fx/app.go:784 +0x85
2022-09-08T22:48:24.759043288Z created by go.uber.org/fx.withTimeout
2022-09-08T22:48:24.759044969Z 	/go/src/github.com/cilium/cilium/vendor/go.uber.org/fx/app.go:772 +0xec

It looks that we might be trying to access some fields that are not initialized when the daemon is shutting down. The code that panic is
	// This is done in preCleanup so that proxy stops serving DNS traffic before shutdown
	cleaner.preCleanupFuncs.Add(func() {
		proxy.DefaultDNSProxy.Cleanup()
	})

cc @joamaki

Looks like proxy.DefaultDNSProxy is nil if --enable-l7proxy=false and this wasn't checked. Surprising we didn't have a test catching this. PR coming in a sec..


add b-nova to service provider

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

LGTM

@taylorwaggoner can you verify

@bnova-stefan could you please update the homepage to be https://b-nova.com/en/home/kompetenzen/kubernetes?    Thanks!

LGTM @caniszczyk

@caniszczyk please go ahead and merge, thanks!


Issue: No longer able to use the run_ids argument of the list_runs function

Issue you'd like to raise.
I am no longer able to retrieve runs by using the run_ids argument of the list_runs function. The following example
    runs = list(
        client.list_runs(
            project_name=project_name,
            start_time=start_time,
            end_time=end_time,
            filter=f"and(eq(metadata_key, 'organisation'), eq(metadata_value, '{organisation}'))",
            is_root=True,
        )
    )
    child_run_ids = [
        child_run_id
        for run in runs[:num_root_runs]
        for child_run_id in run.child_run_ids
    ]
    child_runs = list(
        client.list_runs(
            project_name=project_name,
            child_run_ids=child_run_ids,
        )
    )

raises the following error
Server error caused failure to POST /runs/query in LangSmith API. HTTPError('500 Server Error: Internal Server Error for url: https://api.smith.langchain.com/runs/query', '{"detail":"Internal server error"}') requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: https://api.smith.langchain.com/runs/query

This worked this morning. If I execute the above code the part
    child_runs = list(
        client.list_runs(
            project_name=project_name,
            child_run_ids=child_run_ids,
        )
    )

raises the 500 exception. The following part runs fine
    runs = list(
        client.list_runs(
            project_name=project_name,
            start_time=start_time,
            end_time=end_time,
            filter=f"and(eq(metadata_key, 'organisation'), eq(metadata_value, '{organisation}'))",
            is_root=True,
        )
    )

Suggestion:
No response

Hm. Your code runs fine for me so long as the "child_run_ids" is changed to "run_ids"
child_runs = list(
        client.list_runs(
            project_name=project_name,
            run_ids=child_run_ids,
        )
    )

Will flag this to the infra folks, since obviously a 500 error is an issue.

@hinthornw Awesome thanks! Sorry about the child_run_ids argument that was a typo:)


Updating the Setting up a Sailfish Phone document

Superseded by https://github.com/sailfishos/docs.sailfishos.org/pull/301


NPS-8457 Replace travis with Github actions

Each push, pull_request, workflow_dispatch will trigger build
Each push with tag with trigger build and issue a draft release with name of "flink-tools $(tag_name)" and empty body

This works well. Release package is now available at: https://github.com/pravega/flink-tools/releases/tag/v0.2.15


Android Paste Button doesn't appear when pressing on phone or email text input login

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Break down in numbered steps

Open new expensify android app for the first time.
Pressing on email or phone input box

Expected Result:
Context menu or paste button should appear and cursor should visible
Actual Result:
Context menu or paste button doesn't appear and cursor is not visible.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Input some character and pressing that characters, to show paste button.
Platform:

Where is this issue occurring?

Android

Version Number:
Reproducible in staging?:
**Reproducible in production?:yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Close it.... Direct issue creation is not allowed.

Where is the guideline?

Could you please join slack @K4tsuki ? and you can report the issue there. Write an email to join the channel. Thanks.


nc

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 86f7187f-7e2e-da7f-6f46-46568be43db7
Version Independent ID: 49714e7e-ecfb-dba3-f43a-17b6ca677fa6
Content: Remote Desktop clients for Remote Desktop Services and remote PCs - Windows Server
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/remote-desktop-clients.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @Heidilohr
Microsoft Alias: wscontent

vd

User feedback is incomplete and unspecified/unrelated to documentation. Closing thread.
#please-close

#assign:christking246


Adapter-static not working with my prerendered [[page]] and article/[slug]

Describe the bug
My repo is using Sveltekit, Strapi, houdini graphql, tailwindcss, daisyui
Basically, or my routes [[page]] and article/[slug], it'll load slowly (and display the loading animation i've put) even when previewing npm run preview, sometimes it happens on my PC browser, mostly it happens when I browse my site using mobile (even on npm run preview --host to expose the network to my home network so i can access it by phone)
I just made my home page load data from strapi locally, and it also shows the same error, could be my handling with the loading animation?
Reproduction
My website repo
my repo is a monorepo run by (turbo)[https://turbo.build/], you can reproduce this by:

at root directory
npm run local-cms to boot up strapi locally
npm run build-frontend to build frontend
npm run preview (it has --host) to be able to run what you built
you will either see the issue mentioned happening on your browser or most likely mobile, that the loading is slow

Logs
No response
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 AMD Ryzen 7 7840HS with Radeon 780M Graphics
    Memory: 13.60 GB / 31.19 GB
  Binaries:
    Node: 20.14.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.8.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (126.0.2592.81)
    Internet Explorer: 11.0.22621.3527

Severity
serious, but I can work around it
Additional Information
I can work around it on both PC and mobile by hard reloading while the loading doesn't end, it will show the pages i made

Please provide a minimal reproduction and clearly describe what is not working: what error is shown?. Do not link your entire project as the number of dependencies makes it difficult to properly diagnose.


fixing the match as it wouldn't work with a wildcard

Currently the _bind.erb template isn't matching the expected wildcard so the match will fail if this is used, however, it is expected as a use case elsewhere, so added in the match correct so it will handle both.

that whole mess should be a function…

I have opened https://tickets.puppetlabs.com/browse/MODULES-1741 which touches on this problem as well. HAProxy's bind directive is just too complex to be properly validated inside an ERB template. I'll submit a PR that simplifies things and allows for greater flexibility.

I have created #154.

@antaflos @igalic Do we still want to convert this into a function, or are the changes in this PR and #154 enough.

@tphoney I think there is no need to convert this into a function, and the changes in this PR are obsoleted by #154, which completely removes the inflexible validation code when processing the bind parameter.
Going forward I think still think the best way to handle HAProxy config validation is through the newly introduced validate_cmd parameter for concat in version 1.2.0 (see https://github.com/puppetlabs/puppetlabs-concat/pull/243). We can use it like this and get all the validation we want for free:
  concat { $config_file:
    owner        => '0',
    group        => '0',
    mode         => '0644',
    validate_cmd => '/usr/bin/haproxy -c -f %'
  }

Granted, this only works with Puppet >= 3.5.0 and puppetlabs-concat >= 1.2.0 (but concat will silently ignore the validate_cmd parameter when Puppet < 3.5.0), so config validation in this manner should probably remain optional and disabled by default for the foreseeable future.

Thanks for the response. Can you rebase this please.

@tphoney I think this PR here can be closed, there is no need to merge it since it touches code that no longer exists.

Thanks for the work and effort you both put in. @antaflos and @igalic. Closing


Fixed tests target in SPM

Small fix to SPM building. Hopefully this should fix the Travis pipeline.
#6

Thanks @kondratk !


Use TE extended properties to create PE object

http://www.w3.org/TR/touch-events-extensions/
Properties including force and radiusX is implemented in Firefox/Chrome and can be used to create PE object.
Note: The default value of force is 0, not 0.5.

Support for force value requires support for Mouse Events button value. which always is 1 so this doesn't help.


fix(category-sync): Fix generating delivery update actions

Summary
Fixes #229
When adding a new parcel to a delivery, the script goes through all deliveries to find proper deliveryId. It also ignores all diffs items starting with an underscore _ because those items were removed and we do not currently support removed deliveries/parcels.
This PR also improves code coverage:

[x] should generate correct update actions when a new delivery is added to the new object
[x] should be agnostic of the index(position) of the deliveries in both new and old order object
[x] should generate correction update actions a new parcel has been added
[x] should work when no deliveries was existing in old order
[x] should work when only new deliveries are provided without providing existing deliveries in the old order object (this is possible for orders because it's currently not possible to remove deliveries from an order)
[ ] should throw if there is no deliveryId in the new order object (check if consistent with similar implementations in other entities)

Here I discovered that the deliveryId has to be always present when adding new parcel because if it is missing, the script will add whole delivery instead of just a parcel.

[x] should be idempotent, passing the same object should return empty actions

Coverage increased (+0.01%) to 97.575% when pulling c1adb3f15a003302d8de4885e0e2ba4912af4ebc on 229-fix-adding-parcels-in-order-sync into 08c63833d07da32da9ce2bb043841459419e6b9a on master.

Coverage decreased (-0.03%) to 97.532% when pulling 03d2a43bd8d9d27faa1c2567ba5297f2b8fec9f7 on 229-fix-adding-parcels-in-order-sync into 08c63833d07da32da9ce2bb043841459419e6b9a on master.

Coverage decreased (-0.03%) to 97.532% when pulling 0b52a39137450df966e34f461f7eccfcce43a0ab on 229-fix-adding-parcels-in-order-sync into 08c63833d07da32da9ce2bb043841459419e6b9a on master.

Coverage increased (+0.02%) to 97.581% when pulling<PHONE_NUMBER>2c1cf8955cf0e562f80ac13c9b9647 on 229-fix-adding-parcels-in-order-sync into 08c63833d07da32da9ce2bb043841459419e6b9a on master.

This "coveralls thing" is getting more and more painful :-I

Nitpick: I think you meant to write order-sync not category-sync in the commit message

@hisabimbola I used amend to change it.

Coverage increased (+0.02%) to 97.581% when pulling b34b31eca66af70fe5f1bd96256b5aa78bd29756 on 229-fix-adding-parcels-in-order-sync into 08c63833d07da32da9ce2bb043841459419e6b9a on master.

Coverage increased (+0.02%) to 97.581% when pulling 9c1d30013b875cc7d73b7dc9c64bec3273da9ad5 on 229-fix-adding-parcels-in-order-sync into 08c63833d07da32da9ce2bb043841459419e6b9a on master.


[Apple Notes] ...

Extension
https://www.raycast.com/tumtum/apple-notes
Description
I beg you to add search throughout the whole note bodies instead of just title.
This is 1 of the 2 things in Raycast that are still implemented worse than in Alfred.
Who will benefit from this feature?
No response
Anything else?
No response

Sure. A few people have asked recently.  I will get this in place before the end of the year.

This is a duplicate of #3207 and can be closed.


Yarn v2

[x] migrate to yarn v2, in #1045

Followups:

[x] dependabot issues

it generates v1 yarn.lock files
workaround currently is to manually pull the dependency, run yarn, amend the commit

function update_wm_dependabot_branch() {
    cd `git rev-parse --show-toplevel`
    git fetch origin
    git checkout $1
    git checkout HEAD^ -- yarn.lock
    yarn
    yarn dedupe
    git add `git rev-parse --show-toplevel` && gc --amend --no-edit --reset-author --no-verify
    git push -f
}

people have created Github Actions to automate this process

https://github.com/dependabot/dependabot-core/issues/1297#issuecomment-671131912

[ ] sjcl

currently using a fork, with the built sjcl.js committed to the repository (previous was 3 years old)

[ ] over-specified devDependencies

currently using the yarn upkeep command to push all devDependencies from the root to the workspace package.jsons

slightly annoying to have so many packages obfuscating the list of unique dependencies in a workspace

Could be improved by keeping a list of the obvious root only packages
Could automate something in packageExtensions, but that would probably require some kind of yarn plugin so it would integrate nicely with CI and cli usage of yarn.

[x] @types/chrome completions don't seem to be working in IntelliJ

workaround seems to be to specify arg = chrome form to imply the chrome type, rather than arg: typeof chrome, e.g.  constructor(a: number, b: string, @inject(tokens.WextApi) api = chrome)

long completed


Add kernelCTF CVE-2023-31436

Hey. Thanks for the update. My Makefile was using a slightly different target, so I fixed that. The exploit is using side channels for KASLR bypass. This does not appear to be working on the runner, does however work on the real instances. (tbh I haven't checked in a while, where there any infra changes?). Any suggestions on how to proceed here? I can have a closer look in a week or so.

So I checked again, the cache timing side channel works fine on the real instance. Both use QEMUs -cpu host, not sure what is underneath here.
Would KASLR disabled be an option for the CI job? As far as the CTF is concerned KASLR bruteforce is a valid strategy anyway, so you probably do not want such submissions to spam your runner too.
Also the CLA check is failing because apparently you (@koczkatamas  are not approved as a contributor and we shared some commits.

Hey!
Yeah, we will provide an option to disable KASLR. When it's ready (ETA:
next week), I will comment here.
On Fri, Sep 1, 2023, 15:38 liona24 @.***> wrote:

Reopened #34 https://github.com/google/security-research/pull/34.
—
Reply to this email directly, view it on GitHub
https://github.com/google/security-research/pull/34#event-10257437128,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT4XUTUVAZVKQ5EL4DERJDXYHQN5ANCNFSM6AAAAAA2VGHKII
.
You are receiving this because you were mentioned.Message ID:
@.***>

Implemented, KASLR base will be supplied as the first argument to ./exploit. Example full command line: su user -c '/tmp/exp/exploit ffffffff8a000000'.
You need to change to the v3 metadata schema and modify the exploits node to this:
    "exploits": {
        "mitigation-6.1": {
            "uses": ["userns"],
            "stability_notes": "5% success rate",
            "requires_separate_kaslr_leak": true
        }
    }

See the full modified file here: https://github.com/koczkatamas2/security-research/pull/1/files#diff-a3e5b8f8744c0ae7ff2ed99f0c28cb0a940bf5b6964a86eeecc0fa42d19bdd6d

Alright thank you very much. The only thing missing now is the CLA check because of the co-authored commits.


Fix order in MockDownloadManager.iter_archive

Currently, MockDownloadManager.iter_archive yields paths to archive members in an order given by path.rglob("*"), which migh not be the same order as in the original archive.
This PR fixes the order of the members yielded by MockDownloadManager.iter_archive so that it is the same as in the original archive.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Bug in Nora - Odd audio glitch

Describe the bug
The audio sometimes rewinds a couple of seconds. Not on the timeline, just the audio. This also results in the song ending before the audio does.
Note: This does not get fixed after rewinding back on the timeline manually, it kind of corrupts the temporarily loaded version of the file.
To Reproduce
Steps to reproduce the behavior:

Play a song
Occasionally, the audio rewinds for no reason.

Expected behavior
No rewinding.
Screenshots
Video attached
https://github.com/Sandakan/Nora/assets/73738591/608db78a-de83-4f3c-8fcc-0d4763c3cf79
Log File
Nothing related, just window resizing logs.
System Information:

OS: Windows 10
2.3.0-stable

@RichardKanshen, Did you modify song metadata while playing that song?

Nope, it just randomly happens for no reason sometimes. It does get fixed after restart, but it is annoying. Maybe it is a glitch in the file system? Electron? Loading files temporarily into memory?

@RichardKanshen,
Are those lyrics automatically downloaded during the playback?
Did you enable the option to save downloading lyrics automatically?

Are those lyrics automatically downloaded during the playback?
Nope, I downloaded these before and saved them into the tags.

Saw some signs like you are describing in the app and added a fix for the next update.
Hope that it fixes this problem too.


Install-Module navcontainerhelper fails

An error message is triggered when trying to install a new version of the navcontainerhelper (see screenshot). Any idea what could cause the problem? Thanks in advance.

Are you running CMD as admin or should you by any chance be running Powershell v7?
Powershell v7 gives the same error but running CMD as admin does work.

Thank you for feedback! I am running it from PowerShell ISE (Run as administrator).

you should try to run a command prompt as administrator and do the following (this worked for me)
Set-ExecutionPolicy -ExecutionPolicy RemoteSigned
Set-PSRepository -Name 'PSGallery' -InstallationPolicy Trusted
Install-Module -Name navcontainerhelper -Force

I am getting the same error message,, if trying to run the Install-Module command from Windows PowerShell CMD, as Administrator (see screenshot).

Run Set-ExecutionPolicy -ExecutionPolicy RemoteSigned as administrator
EXIT the command prompt
Start a new command prompt as administrator and then run
Set-PSRepository -Name 'PSGallery' -InstallationPolicy Trusted
EXIT
and then finally do a
Install-Module -Name navcontainerhelper -Force (without the requiredversion)

Thanks for Your help! However this is the outcome of you recommendations.
The first command results in an error message (see below). Apparently the command executes, but is overridden.

If I igore that message and opens a new cmd window and execute the 2:nd command, this is executed without any message.
However, executing the 3:rd command, the very same error occurs again. (see below)

wouldn't you have to use
Set-ExecutionPolicy -ExecutionPolicy unrestricted
NavContainerHelper is not signed.

Thanks for your feedback! Now, I tried once more, with the new suggested ExecutionPolicy. This is the outcome: The execution policy now seems to be honored, but the "Powershellgallery" source location is still considered "not valid". Please view screenshots below. As requested, I have also attached a "systeminfo.txt"-file.

systeminfo.txt

Maybe it is a TLS 1.2 problem?
https://techcommunity.microsoft.com/t5/windows-powershell/warning-source-location-https-www-powershellgallery-com-api-v2/m-p/1294648

Spot on, it solved the problem. Thank you all for helping!
This is the command for installing Tls12 support:

After installing Tls12, it was no problem to execute the command for installing the new navcontainerhelper module:

Verifying that the module is installed:

you can uninstall-module navcontainerhelper a number of times and then install the latest to avoid version number confusion

thanks for your help! yes, I noticed that several versions were installed and were thinking about whether to clean them up. but glad to have solved the first problem, I did not want to ask more questions ... However, a few commands later, it looks better...

Problem solved. Thanks all for helping!


Provide pre-compiled downloadable releases for popular systems (Linux, Windows)

Will be good to have pre-compiled downloadable releases for popular systems - Linux (.deb file for Debian/Ubuntu, .rpm for Red Hat, etc), Windows (if supported), Mac, etc.

Hello @MurzNN. I provide cross-distribution flatpak builds for Linux. Mac and Windows are not supported.

Thanks, I don't see this link in project readme and try to install it manually via Installation section. Please add this link in top of readme.md file for regular users, that wants only install and use it.

Good idea. Reticketed as tiliado/nuvolaruntime#407.


Generate JAVA sdk from typescript provider error

Getting error while generating Java SDk from typescript provider
cd provider/cmd/pulumi-gen-abc && go run . java ../../../sdk/java /pulumi-abc-sdk/schema.json
Failed: Unrecognized language "java"%

@bala-auvaria Thank you for confirming, I moved this issue to the boilerplate repo. Indeed, we need to add Java here.


Move optimize plugins to production-only

  new webpack.optimize.OccurrenceOrderPlugin(),
  new webpack.optimize.DedupePlugin(),

should both be production-only.

Resolved w/ https://github.com/davezuko/react-redux-starter-kit/pull/479


[v1.13] bgpv1: skip invalid node selector config in policy selection

Manual backport for

https://github.com/cilium/cilium/pull/26365

/test-backport-1.13


I am using the llama2/7B_lora template provided by torchtune to fine-tune the llama2 7B model, and below is my customized yaml content. However, I encountered a 'KeyError: num_key_value_heads' error. I checked the original yaml template and it also does not include this parameter.
my log:
(mj) ubuntu@ubuntu-7002-r8424-g12:~/mj$ tune run --nnodes 1 --nproc_per_node 2 lora_finetune_distributed --config ./custom_config.yaml
Running with torchrun...
W0507 15:51:14.198941<PHONE_NUMBER>82176 torch/distributed/run.py:757]
W0507 15:51:14.198941<PHONE_NUMBER>82176 torch/distributed/run.py:757] *****************************************
W0507 15:51:14.198941<PHONE_NUMBER>82176 torch/distributed/run.py:757] Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.
W0507 15:51:14.198941<PHONE_NUMBER>82176 torch/distributed/run.py:757] *****************************************
INFO:torchtune.utils.logging:Running LoRAFinetuneRecipeDistributed with resolved config:
batch_size: 2
checkpointer:
component: torchtune.utils.FullModelHFCheckpointer
adapter_checkpoint: null
checkpoint_dir: /home/ubuntu/smyin/open_llama_7b_V2
checkpoint_files:

pytorch_model-00001-of-00002.bin
pytorch_model-00002-of-00002.bin
model_type: LLAMA2
output_dir: /tmp/Llama-2-7b-hf
recipe_checkpoint: null
dataset:
component: torchtune.datasets.alpaca_cleaned_dataset
train_on_input: true
device: cuda
dtype: bf16
enable_activation_checkpointing: false
epochs: 1
gradient_accumulation_steps: 32
log_every_n_steps: 1
log_peak_memory_stats: false
loss:
component: torch.nn.CrossEntropyLoss
lr_scheduler:
component: torchtune.modules.get_cosine_schedule_with_warmup
num_warmup_steps: 100
max_steps_per_epoch: null
metric_logger:
component: torchtune.utils.metric_logging.DiskLogger
log_dir: /home/ubuntu/mj/alog
model:
component: torchtune.models.llama2.lora_llama2_7b
apply_lora_to_mlp: false
apply_lora_to_output: false
lora_alpha: 16
lora_attn_modules:
q_proj
v_proj
lora_rank: 8
optimizer:
component: torch.optim.AdamW
lr: 0.0003
weight_decay: 0.01
output_dir: /home/ubuntu/mj/alog
resume_from_checkpoint: false
seed: null
shuffle: true
tokenizer:
component: torchtune.models.llama2.llama2_tokenizer
path: /home/ubuntu/smyin/open_llama_7b_V2/tokenizer.model

DEBUG:torchtune.utils.logging:Setting manual seed to local seed 649868757. Local seed is seed + rank = 649868757 + 0
DEBUG:torchtune.utils.logging:Setting manual seed to local seed 649868758. Local seed is seed + rank = 649868757 + 1
Writing logs to /home/ubuntu/mj/alog/log_1715068277.txt
[rank0]: Traceback (most recent call last):
[rank0]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 615, in
[rank0]:     sys.exit(recipe_main())
[rank0]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/config/_parse.py", line 50, in wrapper
[rank0]:     sys.exit(recipe_main(conf))
[rank0]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 609, in recipe_main
[rank0]:     recipe.setup(cfg=cfg)
[rank0]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 203, in setup
[rank0]:     checkpoint_dict = self.load_checkpoint(cfg_checkpointer=cfg.checkpointer)
[rank0]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 148, in load_checkpoint
[rank0]:     checkpoint_dict = self._checkpointer.load_checkpoint()
[rank0]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/utils/_checkpointing/_checkpointer.py", line 387, in load_checkpoint
[rank0]:     num_kv_heads=self._config["num_key_value_heads"],
[rank0]: KeyError: 'num_key_value_heads'
[rank1]: Traceback (most recent call last):
[rank1]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 615, in
[rank1]:     sys.exit(recipe_main())
[rank1]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/config/_parse.py", line 50, in wrapper
[rank1]:     sys.exit(recipe_main(conf))
[rank1]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 609, in recipe_main
[rank1]:     recipe.setup(cfg=cfg)
[rank1]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 203, in setup
[rank1]:     checkpoint_dict = self.load_checkpoint(cfg_checkpointer=cfg.checkpointer)
[rank1]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py", line 148, in load_checkpoint
[rank1]:     checkpoint_dict = self._checkpointer.load_checkpoint()
[rank1]:   File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/utils/_checkpointing/_checkpointer.py", line 387, in load_checkpoint
[rank1]:     num_kv_heads=self._config["num_key_value_heads"],
[rank1]: KeyError: 'num_key_value_heads'
E0507 15:51:19.237765<PHONE_NUMBER>82176 torch/distributed/elastic/multiprocessing/api.py:826] failed (exitcode: 1) local_rank: 0 (pid: 2754906) of binary: /home/ubuntu/.conda/envs/mj/bin/python
Traceback (most recent call last):
File "/home/ubuntu/.conda/envs/mj/bin/tune", line 8, in
sys.exit(main())
File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/_cli/tune.py", line 49, in main
parser.run(args)
File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/_cli/tune.py", line 43, in run
args.func(args)
File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/_cli/run.py", line 177, in _run_cmd
self._run_distributed(args)
File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torchtune/_cli/run.py", line 88, in _run_distributed
run(args)
File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torch/distributed/run.py", line 870, in run
elastic_launch(
File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 132, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 263, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
/home/ubuntu/.conda/envs/mj/lib/python3.8/site-packages/recipes/lora_finetune_distributed.py FAILED
Failures:
[1]:
time      : 2024-05-07_15:51:19
host      : ubuntu-7002-r8424-g12.local
rank      : 1 (local_rank: 1)
exitcode  : 1 (pid: 2754907)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
Root Cause (first observed failure):
[0]:
time      : 2024-05-07_15:51:19
host      : ubuntu-7002-r8424-g12.local
rank      : 0 (local_rank: 0)
exitcode  : 1 (pid: 2754906)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
my yaml:
Config for multi-device LoRA finetuning in lora_finetune_distributed.py
using a Llama2 7B model

This config assumes that you've run the following command before launching
this run:
tune download meta-llama/Llama-2-7b-hf --output-dir /tmp/Llama-2-7b-hf --hf-token <HF_TOKEN>

To launch on 2 devices, run the following command from root:
tune run --nnodes 1 --nproc_per_node 2 lora_finetune_distributed --config llama2/7B_lora

You can add specific overrides through the command line. For example
to override the checkpointer directory while launching training
you can run:
tune run --nnodes 1 --nproc_per_node 2 lora_finetune_distributed --config llama2/7B_lora checkpointer.checkpoint_dir=<YOUR_CHECKPOINT_DIR>

This config works best when the model is being fine-tuned on 2+ GPUs.
For single device LoRA finetuning please use 7B_lora_single_device.yaml
or 7B_qlora_single_device.yaml
Model Arguments
model:
component: torchtune.models.llama2.lora_llama2_7b
lora_attn_modules: ['q_proj', 'v_proj']
apply_lora_to_mlp: False
apply_lora_to_output: False
lora_rank: 8
lora_alpha: 16
tokenizer:
component: torchtune.models.llama2.llama2_tokenizer
path: /home/ubuntu/smyin/open_llama_7b_V2/tokenizer.model
checkpointer:
component: torchtune.utils.FullModelHFCheckpointer
checkpoint_dir: /home/ubuntu/smyin/open_llama_7b_V2
checkpoint_files: [
pytorch_model-00001-of-00002.bin,
pytorch_model-00002-of-00002.bin
]
adapter_checkpoint: null
recipe_checkpoint: null
output_dir: /tmp/Llama-2-7b-hf
model_type: LLAMA2
resume_from_checkpoint: False
Dataset and Sampler
dataset:
component: torchtune.datasets.alpaca_cleaned_dataset
train_on_input: True
seed: null
shuffle: True
batch_size: 2
Optimizer and Scheduler
optimizer:
component: torch.optim.AdamW
weight_decay: 0.01
lr: 3e-4
lr_scheduler:
component: torchtune.modules.get_cosine_schedule_with_warmup
num_warmup_steps: 100
loss:
component: torch.nn.CrossEntropyLoss
Training
epochs: 1
max_steps_per_epoch: null
gradient_accumulation_steps: 32
Logging
output_dir: /home/ubuntu/mj/alog
metric_logger:
component: torchtune.utils.metric_logging.DiskLogger
log_dir: ${output_dir}
log_every_n_steps: 1
log_peak_memory_stats: False
Environment
device: cuda
dtype: bf16
enable_activation_checkpointing: False
/
/
### Tasks
- [ ] Add a draft title or issue reference here

So IIUC, that particular config that's being looked up for num_key_value_heads is not the actual training config, but the HF config associated with the checkpoint, and it appears to be missing that particular key. It does look like in general we do assume that key is there: https://github.com/pytorch/torchtune/blob/main/torchtune/utils/_checkpointing/_checkpointer.py#L402.
cc @kartikayk for more context.

Thanks for filing this issue!
Unfortunately, the repo (https://huggingface.co/openlm-research/open_llama_7b_v2/tree/main) seems to have a config which is missing the num_key_value_heads (we depend on this config file to give us information needed to correctly convert checkpoints). If you modify the config.json file and add "num_key_value_heads": 32 to it, things should work. I tested this locally. Let me know if you run into issues.

@mj2688 I'll close this issue for now since it seems to address the failure. But please feel free to reopen if we should be following up on this.


GUI doesn't seem to be updated?

Just saw the new update about apply to all colours, really waited a long while for this as it makes not having to slide it each time far better. However, after following install instructions it doesn't seem to update or get the latest? The GUI is still the same as before without the Apply to all colours bit?

Ah after reading more I guess the new version has not yet been released?

That's right. I can send you a build with the latest changes, though.
Release.zip

That's right. I can send you a build with the latest changes, though.
Release.zip

Thank you very much man, you've created something amazing here! Wish you the best and thank you again :)