telemetry: use native stats by default

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>Follow up to https://github.com/istio/istio/pull/41441 but for non-telemetry API installation (default), until a plan to default to telemetry API emerges. This should give sufficient burn time in CI, and avoid support for rarely used Wasm version.

@kyessenov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test release-notes

integ-telemetry-istiodremote_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test release-notes

integ-telemetry-istiodremote_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test release-notes

integ-telemetry-istiodremote_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry

integ-telemetry-mc_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn What exactly do you mean by overrides? Some CEL expressions that refer to Wasm attributes are not compatible, because it's not Wasm. Those are not documented, so unlikely to actually be in-use.

I mean the .Values.telemetry.v2.prometheus.configOverride.outboundSidecar. I think we had established all fields exposed via Telemetry are compatible, but the configOverride can access arbitrary fields in the internal proto.

The schema is the same for wasm and stats filter, but I marked some fields removed. Seems like istio fails on the removed xDS fields, so we need to set the flag.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry

integ-telemetry-mc_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-mc

gencheck_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-mc

gencheck_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test gencheck

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
c544a2f60101fb951db0b77fd760c8a8f84c01b1
link
true
/test integ-telemetry-mc

gencheck_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test gencheck

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test gencheck

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test gencheck

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

integ-security-multicluster_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

integ-security-multicluster_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-security-multicluster

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

integ-security-multicluster_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-security-multicluster

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-security-multicluster

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zirain argh, another metric for istio version needs to be added. not sure why this test fails now only.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
e71daffaef03e638c1afc54b50b9b8e69ebd7de8
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain argh, another metric for istio version needs to be added. not sure why this test fails now only.

IC
istioctl x es sleep-69cfb4968f-h72rz | grep .istio_build
wasmcustom.component.proxy.tag.1.15.3;.istio_build: 1

/retest

@hzxuzhonghu We may not need this if https://github.com/istio/istio/issues/37645 gets done, but noone is assigned to that issue, so until then, this will give us some burn time with EnvoyFilters.


[MRTK3] Using OculusXR feature in the OpenXR Feature Group causes quest controller visuals to be glitched

Describe the bug
When I enable the "OculusXR Feature" in OpenXR Feature Groups (to enable Quest specific things like Passthrough, OVRInput, etc) the controller gets visual gets bugged, and the Far interaction ray looks bent.
The controller model seems to be stuck in the air (as seen in screenshot)
The controller does seem to respond ingame though to rotations. But movement seems to not work.
Hand tracking seems to work fine without any issues.
To reproduce
Steps to reproduce the behavior:

Configure the project as mentioned in the Microsoft's guide
Goto ProjectSettings/XR Plugin Management/Open XR, and select android operating system.
Enable "OculusXR Feature" in OpenXR Feature Groups.
Build and deploy to device

Expected behavior
Normally I would expect this feature not to interfere with the controllers.
Screenshots

Your setup (please complete the following information)
Unity 2021.3.8f1
MRTK3 Repo (as of commit https://github.com/microsoft/MixedRealityToolkit-Unity/commit/87ae775470952d28f0d459e9abeb6b95102505ff)
Target platform (please complete the following information)

Quest 2

Additional context
I'm not sure if its helpful or not, but OVRPlugin.GetSystemHeadsetType() returns OVRPlugin.SystemHeadset.Oculus_Quest instead of OVRPlugin.SystemHeadset.Oculus_Quest_2 on Quest 2

@keveleigh , are we supporting this path at all?

Oh hmm...I haven't done much with Oculus' feature here since it's a little heavy 😅 but it seems weird to me that it'd affect our own input! I can see about testing this today

I dont know if this info could be useful or not,
but from as what I can think of, it seems like the Ray is always coded to originate from the controller model prefab.
When I added OVRManager prefab in the script with "Disable Eye Anchor Cameras" I noticed that hand tracking was still fine and unaffected, but with controller, I could see the Quest controller model (of Quest1 instead of Quest2) on screen which was moving and following my movement.

I haven't been able to get Oculus's OpenXR feature to work properly at all, it seems very early still. Is this really an MRTK bug?

I haven't been able to get Oculus's OpenXR feature to work properly at all, it seems very early still. Is this really an MRTK bug?

It seems so because MRTK Inputs should not be affected by enabling Oculus XR OpenXR feature.

This is sort of tricky because we're not explicitly supporting using OVR APIs or OVRManager with MRTK3. However, as it stands, things probably shouldn't be interfering.

I did some research on it and i think the root cause is the rotationAction and the positionAction in the action based controller.
They do work normally but for reason with Oculus XR enabled, it doesn't work.
I did find a workaround for it.
There are two requirements for it are:

Detect if hand tracking or controller
I'm doing this using Unity Input System's Oculus Touch Left/Right controllet presence.
Create new Input Asset which will use Oculus Touch Controller Left and Right device position and rotation respectively.

Now create a new script, attach it to Mrtk XR rig prefab.
i) when the controller mode is detected, get reference to left and right action based controller. save references to old position and rotation action. Then apply the new position and rotation action which we created from Oculus Touch Controller.
ii) when hand tracking is back, restore back the old position and rotation action.
I don't know if I my steps were clear or not, but using this workaround I am now able to use controllers in quest normally.
PS:
I will gladly respond to anything if required, but i still hope this workaround becomes a part of core mrtk itself since now I'm able to use all the Oculus XR specific features with MRTK3 which is a huge plus for me. It would be a bonus for many other quest developers who would like to use quest specific features like Passthrough, etc

@akash14darshan thanks for the extra info here. There should be a way we can get around this without doing funky runtime input action swapping... Pinging @keveleigh  here :)

Confirmed repro over Link 😡 will dig in to see why this feature is causing issues!

Hey @akash14darshan! I was previously able to repro, I believe with the 46.0 version of Meta's Oculus Integration package. After updating to 47.0, I can no longer repro. Are you able to update and give this another shot without your workaround?


Numeric sorting seems bugged again. Eg. 0px -> 12px -> 16px -> 4px -> 8px

There is a closed issue about this, but it seems risen again.
The old issue is here: https://github.com/sonburn/symbol-organizer/issues/59

Same on this end (Sketch Version 68 (102490).
See example where progress bar symbols are ordered:
10%
100%
20%
30%
40%
50%
60%
70%
80%
90%
Ideally, they would be ordered 10-100.
Cheers 🍻


drop nulls and drop zeros returns incorrect timestamp

Maybe I am missing the intention but if I use --drop nulls the outputted times are wrong as t does not account for the time position of the value in the original list. The result is a sequential list of times with no gaps and the timestamps are wrong.
rather  than using the drop function I using the hacky fix below
 if value is None:
     t += step       <===== making sure we account for the removed value
    continue

Hi @ninelocks,
Well, agree - but that's how drop is implemented by its author - https://github.com/graphite-project/whisper/pull/57

Hi @ninelocks, @deniszh
For what it's worth, I think the current behaviour is pretty clearly a bug in the current implementation.
I've just wasted a whole morning checking my code which processes whisper-fetch.py --drop nulls … output.  I suspected I had a buffer problem with a subprocess pipe.  Only finally did I discover that the whisper-fetch.py --drop option simply culls the null (or zero, whatever is specified) entries from the  values list, without in any way adjusting the calculation of t variable, (which is formatted into the timestr variable) in the final output for loop.
t is just incremented by step after each iteration of the for loop, which means that all timestr values will become progressively more incorrect, each time a null or zero value is dropped.


Should _script in Tokenizer.cs be ReadOnlyMemory instead of string?

From what I have read, it seems like using ReadOnlyMemory<char> instead of string could potentially offer some performance gains in the tokenizer if we use it for the _script:
https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/parser/tokenizer.cs#L519
(N.B.: This would obviously require much more extensive changes than just that. We'd need to make more use of the .Span and .Span.Slice() instead of stringbuilder as the tokenizer currently does, for example.)
However, I lack sufficient understanding of how {ReadOnly}Memory<T> functions in practice to be able to say if it's just... better off as it is currently. Given what I have been reading thus far, it seems like it might be worth the change. However:

Unlike {ReadOnly}Span<T>, {ReadOnly}Memory<T> cannot be directly indexed into; its .Span property must be accessed in order to be able to index into the contained memory / values.

Continually pulling the .Span from Memory<T> as the tokenizer might need to for its successive indexing may incur more overhead than allocating strings, building new strings via StringBuilder, etc.; I don't know enough of its behaviour to really grok how they'd compare just yet, or if there's a better way to lay out the tokenizer's processes in general to minimise this potential issue.

This would require changing several significant portions of how the tokenizer functions to .Slice the spans and pass them along instead of utilising StringBuilder objects, which should be more efficient at least in those areas once the initial ReadOnlySpan<char> has been allocated.

I have had a bit of a play around with how the code itself would look, and I have yet to get it working completely with ReadOnlyMemory
The changes that are required are more extensive than I've presently been able to figure out. I think I can make it work, but I've yet to get a working prototype branch.
I would be interested in the opinions of you folks who've been working on this project for a long time and/or have much more experience with Memory<T> and Span<T> than I do.

Is this worth the time investment to figure out, in your opinion?

Would you expect it to be more efficient than the current method (allocating a potentially huge string and indexing one character at a time)?

Would it just be a lot better to simply have _script be turned into char[] instead of string?

Look forward to your feedback! ❤
cc @daxian-dbw @iSazonov as y'all have been enormously helpful as I've been tinkering already and you probably know this much better than I!

I've looked at this before and found that this code (parser and tokenizer) is extremely optimized.
Before trying to improve this code, we need performance tests. I know that @daxian-dbw  had plans about this.

StringBuilder was optimized in .Net Core 2.0. It is very efficient.

Yeah, I've no doubt StringBuilder is insanely fast, but -- if we didn't need to build the string? Just .Slice() the existing Span<char> or Memory<char> by indexes? I get the impression that it could be faster, potentially. Needs some careful planning, though, for sure. 😁

I looked at this code in PerfView and found it very efficient. I do not think that we will get a noticeable win here. There are much less effective parts in our code that need improvement.
We had an idea to implement Trivia (and also enhancements in classes). In this case, it was possible to combine this with improvements in parser and tokenizer.

Yes, we'll have Trivia RFC.


How to make raid queue work?

I tried the Leech sample scenario but it doesn't do anything at all, tried on raid page quest page, home page, and support summon page.
Edit: nevermind, figured it out. Thanks for the awesome work. Let me know how we can donate :)

Yeah I haven't documented the raid queuing yet. You basically need to send a POST request with the raid code inside the request body to the command server at /raid. It's highly modular as it allows other applications or chat bots to interact with the command server's raid queue. You can check the example of using my own raidfinder to queue a raid into the autopilot.


MINOR: Seek to beginning instead of relying on LIST_OFFSET in BrokerCompatibilityTest

In BrokerCompatibilityTest.java, when older versioned broker is used (0.10.1, 0.10.2), LIST_OFFSET is not supported as well. Hence in the verification phase, there is a possibility that consumer hit the UnsupportedVersionException earlier than Streams actually hits it:
rg.apache.kafka.common.errors.UnsupportedVersionException: The broker does not support LIST_OFFSETS with version in range [2,3]. The supported range is [0,1].

While the test is waiting for
ATAL: An unexpected exception org.apache.kafka.common.errors.UnsupportedVersionException: Cannot create a v0 FindCoordinator request because we require features supported only in 1 or later.

Call seek with specific offset would avoid sending LIST_OFFSET.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mjsax @vvcephei @bbejeck
The recent commit of using new poll() seems have increased the likelihood of this issue.

https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1783

A little unclear to me. The consumer should be backward compatible and not throw any UnsupportedVersionException... otherwise we broke something using the new poll(Duration) call (ie, poll(Duration) does something invalid introducing a regression). Or do I miss something?

Interesting... Why do you say the new poll call increases the likelihood of the issue? Or is that just empirical?
FWIW, the change looks good to me.

@mjsax @vvcephei Here is what I'm suspecting: first of all, this race condition should have been existed since day one because there is no synchronization between streams.start and the loopUntilRecordReceived call. I.e. either Streams' leader failed to create topic during the rebalance, and printed the expected error message, or the Consumer failed to list offsets when starting up and printed the unexpected error message.
In the old API, we will call ensureCoordinatorReady with Long.MAX_VALUE as the timeout, and hence we are effectively doing long polling on the underlying network client, while with the new API we set a relatively low timeout in ensureCoordinatorReady and will fallback and retry the request pretty quickly. My un-validated suspicion is that this caused the consumer to 1) joined the group and 2) refreshed metadata quicker than before, and hence continue to updateFetchPositions and hence hit the error quicker, and that's why we now see this error more often than before.

After some further discussion with @hachikuji I've decided to change the test, to relax the expect error message so that both producer's error:
[2018-06-08 01:24:55,313] DEBUG [Producer clientId=kafka-streams-system-test-broker-compatibility-bc8152cd-22b7-437f-8f19-7c56a7d40075-StreamThread-1-0_0-producer, transactionalId=kafka-streams-system-test-broker-compatibility-0_0] Version mismatch when attempting to send (type=FindCoordinatorRequest, coordinatorKey=kafka-streams-system-test-broker-compatibility-0_0, coordinatorType=TRANSACTION) with correlation id 2 to -1 (org.apache.kafka.clients.NetworkClient)
org.apache.kafka.common.errors.UnsupportedVersionException: Cannot create a v0 FindCoordinator request because we require features supported only in 1 or later.

and consumer's error
[2018-06-08 01:24:55,316] DEBUG [Consumer clientId=kafka-streams-system-test-broker-compatibility-bc8152cd-22b7-437f-8f19-7c56a7d40075-StreamThread-1-consumer, groupId=kafka-streams-system-test-broker-compatibility] Version mismatch when attempting to send (type=ListOffsetRequest, replicaId=-1, partitionTimestamps={brokerCompatibilitySourceTopic-0=-2}, isolationLevel=READ_COMMITTED) with correlation id 29 to 1 (org.apache.kafka.clients.NetworkClient)
org.apache.kafka.common.errors.UnsupportedVersionException: The broker does not support LIST_OFFSETS with version in range [2,3]. The supported range is [0,1].

are expected.

Yes, https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1785/ has just passed (ran 5 times).


Getting examples by device kinds is broken

SyntaxError: Unexpected token o in JSON at position 1

This is unexpected - we have tests for this.
What server, which API endpoint (v1 or v3), which device, and with what Accept header?

https://almond.stanford.edu/doc/thingpedia-api/#api-Cheatsheet-GetExamplesByKinds
production, v3, com.bing, tested on the documentation page

Oh. The problem is the API tester. The API does not return JSON by default: you need to pass Accept: application/json if you want JSON, otherwise you get ThingTalk. The API tester does not like that...


by my dataset with ./run.sh script run without error but it didn't create any folder

i create my csv file with (229 lines and its 229 wavs) i know its not enough for quality .
and i replaced my data with LJSpeech downloads data.
after i use ./run.sh ,script run without any error but it didn't create any dir like ( data,dump,exp).
i check my gpu and its working very hard ! but where is directories!
note1: my data text and wavs are in Persian language ( csv is utf-8)
note2: i run script with LJSpeech own orginall data and its work perfect without any problem.
(base) ai@ai-Z390-GAMING-X:~/ParallelWaveGAN/egs/ljspeech/voc1$ ./run.sh
Stage -1: Data download
Already exists. Skipped.
Stage 0: Data preparation
Successfully split data directory.
Successfully split data directory.
Successfully prepared data.
Stage 1: Feature extraction
Feature extraction start. See the progress via dump/train_nodev/raw/preprocessing..log.
Feature extraction start. See the progress via dump/eval/raw/preprocessing..log.
Feature extraction start. See the progress via dump/dev/raw/preprocessing..log.
Successfully make subsets.
Successfully make subsets.
Successfully make subsets.
Successfully finished feature extraction of dev set.
Successfully finished feature extraction of eval set.
Successfully finished feature extraction of train_nodev set.
Successfully finished feature extraction.
Statistics computation start. See the progress via dump/train_nodev/compute_statistics.log.
Successfully finished calculation of statistics.
Nomalization start. See the progress via dump/train_nodev/norm/normalize..log.
Nomalization start. See the progress via dump/dev/norm/normalize..log.
Nomalization start. See the progress via dump/eval/norm/normalize..log.
Successfully finished normalization of eval set.
Successfully finished normalization of train_nodev set.
Successfully finished normalization of dev set.
Successfully finished normalization.
Stage 2: Network training
Training start. See the progress via exp/train_nodev_ljspeech_parallel_wavegan.v1/train.log.

What was the problem?
If you found the solutions, please note here.

its my mistake & Careless in paths,
sorry :)
but now after traning my persian data set i have a big problem, i create new ticket about that
thanks a lot


Fix misc. issues for plotly v4.

I tried to fix some issues for plotly v4.
chart_studio https://github.com/santosjorge/cufflinks/pull/195 https://github.com/santosjorge/cufflinks/pull/198

only replace plotly.plotly to chart_studio.plotly

subplots https://github.com/santosjorge/cufflinks/issues/196#issuecomment-526695267

Variable axe would be SubplotRef in Plotly 4.

Cufflinks Tutorial - Offline.ipynb

Bottom end online plot try to find filename from figure title. It still has text key under title. I don't have plotly account, has not test publishing.

Cufflinks Tutorial - Quantfig.ipynb

up_color default's java is missing.

How did you figure out the _.update(axe.trace_kwargs) part?

@nateGeorge Just classic print debug by comparing plotly 3 and 4 :tada:

@santosjorge this one looks good to merge, and then I may have a couple of extra fixes to layer on. Shall I merge?

(In the interest of time, I'll go ahead and ask for forgiveness later if required ;)

Thanks very much @eholic and my apologies for not reviewing much sooner 🙏

Thank you for the helpful mentenances today, @nicolaskruchten . It's for me to say thank you guys for providing plotly and cufflinks!


Shared state for cv

This fixes a potential race wrt condition_variable[_any] destructor.
This relies on #4512 being merged first (only the last commit is unique to this branch)

Once the tests have cycled this is good to go.

This is still a problem: https://cdash.cscs.ch//viewBuildError.php?buildid=104881. Although I'm not sure it's a real problem. We may just have to ignore that warning.

This is still a problem: https://cdash.cscs.ch//viewBuildError.php?buildid=104881. Although I'm not sure it's a real problem. We may just have to ignore that warning.

I thought, the NOLINTNEXTLINE would take care of this. I'll add a (void*) to cast away the type as well. As the comment says, the code is UB on purpose, so we can safely work around the error.

I thought, the NOLINTNEXTLINE would take care of this. I'll add a (void*) to cast away the type as well. As the comment says, the code is UB on purpose, so we can safely work around the error.

NOLINTNEXTLINE is only for clang-tidy warnings. This is a plain compiler warning (oddly enough only with nvcc...).

Darn, the very test that is supposed to verify the proposed fix is segfaulting :/ Can anybody reproduce this (as it works for me)?

Darn, the very test that is supposed to verify the proposed fix is segfaulting :/ Can anybody reproduce this (as it works for me)?

The cmake option of the CI which triggers the seg fault for me is -DHPX_WITH_THREAD_LOCAL_STORAGE=On

Unfortunately, that does not reproduce it for me. :/

Darn, the very test that is supposed to verify the proposed fix is segfaulting :/ Can anybody reproduce this (as it works for me)?

The cmake option of the CI which triggers the seg fault for me is -DHPX_WITH_THREAD_LOCAL_STORAGE=On

Unfortunately, that does not reproduce it for me. :/

Yeah I can't reproduce it anymore either..

I can try to reproduce this but I need some time for it.

@sithhell, @msimberg this looks clean now. Do you have any objections to go ahead and merge this?

Thanks for looking into this @hkaiser!


ConfigMap, missing unit tests

We made some significant changes in yaml files handling.
New unit tests are required for:

ConfigMap
CodeMirror

Closed because it's a duplicate of https://github.com/rancher/dashboard/issues/8753


zsh: add system packages completion paths to fpath

Good point, I haven't thought about non-NixOS users. Fixed by using the same code as in zsh module from nixpkgs.

Cool! I can't say whether this actually works or not but looks good to me ;-)

Merged into master: https://github.com/rycee/home-manager/commit/2304c145f342ae98968c1ea295f02c1183539ea3. Thanks for the review :)


SASS Division and its deprecation notices

Description
Their is now a lot of "deprecation notices" when compiling the scss files...
Read this : https://sass-lang.com/documentation/breaking-changes/slash-div
Acceptance criteria
It could be easy to launch the command sass-migrator division **/*.scss and fix it.

Most of the affected Sass is really an upstream issue in MDC. I'll move the issue there.


Use -[GRPCCall setResponseDispatchQueue]

... to dispatch GRPC callbacks directly onto the Firestore worker queue.
This saves a double-dispatch and simplifies our logic.

PTAL. I've merged your changes from #812 and updated comments. I started into removing writeValue: and writesFinishedWIthError: from FSTStream but ultimately decided against it because those methods know too much about how the stream behaves to make them really good candidates for separation. As it stands now FSTCallbackFilter is just a filter and that's okay.


Add help via Cobra for check_cpu

Resolves #101

Codecov Report

Merging #116 into master will increase coverage by 0.16%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   81.43%   81.59%   +0.16%
==========================================
  Files          16       16
  Lines         544      538       -6
==========================================
- Hits          443      439       -4
+ Misses        101       99       -2

Impacted Files
Coverage Δ

lib/app/nagiosfoundation/check_cpu.go
88.88% <50%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bdb3e...223a04f. Read the comment docs.

LGTM


Fix ESLint warnings

I'm just pushing this through, it has no conflicts with the main so all should be fine?

 The plugin won't even check every file in a project, just open ones...
@Gum-Joe, this is going to be a wontfix, I'm not opening each file individually to check them.

This is done. I'm not changing it anymore. I hate ESLint and I've always been right to do so. *drops mic*


Making the project depend on swift-format hurts development velocity

Every  clean build, causes a re-fetch of the repository and a build of all the sources for swift-format.
Making sure everyone is using exactly the same version is not worth the the cost and there should at least be a way to bypass it.
I think this tool really doesn't belong in Package.swift but if there's no better alternative, Package.swift contains a use of docGenerationDependency that could serve as a template.  In that case, it is necessary because there appears no good way to do documentation extraction without injecting this dependency.

/cc @lucteo

The main difference I see between swift-format and docGenerationDependency is that we DO require contributors to run swift-format for every PR.
Is there a way to clean just the "hc" target instead of cleaning everything?

we DO require contributors to run swift-format for every PR.

Yes.  You also require them to run the swift compiler, but you don't make them download the sources and rebuild it for every clean build.  Just like the swift compiler, the behavior of swift-format is sufficiently stable that trying to enforce the exact version developers use is a very bad trade-off.
It's not justhc that needs cleaning when cleaning is needed.  SPM/swift-llbuild is not great about tracking dependencies and when you need to start fresh, you often don't know which targets are at issue.  Every dependency we have to download and rebuild affects CI energy use and turnaround time as well.  It would be better to use homebrew to install swift-format for CI, because that will download cached binaries.

SInce there's been no counterargument, I'm probably going to remove this dependency soon unless someone raises an objection here.

This will become a non-issue to the extent that we stop using SPM.  However, the documentation will still need to be updated.  See #1300


Fail to run example (secp256k1-transfer)

Describe the bug
Failed to run the example: secp256k1-transfer
To Reproduce

cd examples/secp256k1-transfer
pnpm install
pnpm start
Error occured:

 pnpm start

><EMAIL_ADDRESS>start projects/lumos/examples/secp256k1-transfer
> parcel index.html

(node:72368) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Server running at http://localhost:1234
⠹ Building index.tsx...
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
Server running at http://localhost:1234
🚨 Build failed.

@parcel/core: Failed to resolve '@ckb-lumos/lumos/codec' from './lib.ts'

  projects/lumos/examples/secp256k1-transfer/lib.ts:2:35
    1 | import { Indexer, helpers, Address, Script, RPC, hd, config, Cell, common
  > 2 | import { bytes, blockchain } from "@ckb-lumos/lumos/codec";
  >   |                                   ^^^^^^^^^^^^^^^^^^^^^^^
    3 |
    4 | // export let { AGGRON4 } = config.predefined;

Expected behavior
NO error.

Sometimes, we may forget to build Lumos, which could be the reason for the issue.

after pnpm start, it reports
❯ npm start

><EMAIL_ADDRESS>start
> parcel index.html

(node:74116) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Server running at http://localhost:1234
⠹ Building index.tsx...
Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#read
@parcel/resolver-default: Auto installing polyfill for Node builtin module
"process"...
Server running at http://localhost:1234
🚨 Build failed.

@parcel/core: Failed to resolve 'process' from
'/Users/xjd/projects/lumos/packages/config-manager/lib/manager.js'

  /Users/xjd/projects/lumos/packages/config-manager/lib/manager.js:92:15
    91 |     const data = require("fs").readFileSync(configFilename);
  > 92 |     const loadedConfig = JSON.parse(data);
  >    |               ^^^^^^^
    93 |     validateConfig(loadedConfig);
    94 |     config = (0, _deepFreezeStrict.default)(loadedConfig);

@parcel/resolver-default: Failed to install process: Yarn failed to install
modules:Child process failed

With solution  https://github.com/parcel-bundler/parcel/issues/7697#issuecomment-1044632099
it works.


Updated search API to make use of Textacular full text search gem

Looks good to me.  Did you want to perform a local merge with master before pushing it back?


Move methods into class pages for docs

Summary
Moved all the methods and attributes into class pages to speed up the building process of the documentation with the new ecosystem sphinx theme.
This PR continues the work done by @Eric-Arellano in https://github.com/Qiskit-Extensions/qiskit-experiments/pull/1231.
See https://github.com/Qiskit/qiskit/pull/10455 for more information.

Thanks for working on this! You'll have to modify some of the other template files under autosummary/ as well—currently the experiment and analysis classes still have their methods on separate pages.
Another issue is that when you click into an actual class page, the sidebar doesn't highlight where you are in the tree:

Hi @coruscating! Thanks for comment! I have added the changes in the other templates as well. With these changes, it seems like we achieve a speed up building the documentation. Right now, in the main branch it takes 10min 53s to build the documentation vs. the 6min 49s in this last commit.
As for the highlight in the sidebar, when scrolling further than the class title it should highlight where we are (see the screenshot), maybe you mean something different, just let me know and I'll check it and fix it :)

@arnaucasau thanks, I meant the left sidebar. When you navigate the class pages in the Qiskit docs, the left sidebar expands and shows where you are in the navigation. But this PR currently has the left sidebar fully collapsed when you navigate to a class as shown the screenshots above.

I just tried it with the most recent build in the main branch and it has the same behaviour. This is because we are currently removing the stubs from the toctrees for non-production build to achieve a speed up. This change was introduced in https://github.com/Qiskit-Extensions/qiskit-experiments/pull/1237. Due to the fact that in this PR we are improving the time as well, I'll open another pull request to study if we can remove that change in the left sidebar without increasing the time a lot.

Oh right, I forgot I made that change 😅. I think it's fine to turn off the production vs. test build distinction in this PR since it was made to deal with the slow build problem, but you can also make a separate PR if you'd like. I tested it locally and a full production build is now ~250 seconds, versus ~200 seconds for the old test build and over an hour for the old production build, so I think the new production build is acceptable to run in all CI.
One issue is that individual pages are still rather large at ~1 MB, I don't know if there's an easy fix for this.

I have been checking the sizes of the pages and I didn't see any page bigger than 100 KB, but if you give me an example of page with that issue I can investigate if its possible to reduce its size in another PR as well 👍. Right now, comparing the size of the whole documentation built in this PR vs the one in the main branch, we achieve a reduction of 1.20 MB + the speedup in time.

Hmm you're right, the files themselves are not large. I was saving them as complete webpages in Chrome during testing, which for some reason balloons them to 1 MB+. Are you still planning on turning off the test build settings in a separate PR? If so I think this PR can be merged.

One minor issue is that headings with no members are still rendered, like Attributes below:

Previously there was logic in the template page to not render Attributes or Methods if there are no members.

@coruscating you're right. The problem was that in reality we had attributes but starting with "__". With the logic in the original templates, those attributes were avoided. So, I've recovered that logic and made the minimum changes possible like in the other template files. I mark the PR as a draft for the moment until I solve the increasing in time using the original template logic.

Are you still planning on turning off the test build settings in a separate PR? If so I think this PR can be merged.

Yes, I will explore that option in another PR  :+1:

Hi @coruscating! I have changed the templates to not show the title Attributes or Methods if we don't have elements to show. The first approach was to use the same logic that we have in the main branch, but we don't have any improvement in the time building the documentation using the count. Instead, in this PR, we store beforehand all the elements we want to show, and then check if there are elements or not. Doing this, the time building the documentation is 8 minutes vs. 20 minutes with the first approach.

Thanks @arnaucasau, the pages look good but it's unfortunate that the docs CI is still 20+ minutes. That doesn't seem faster than the original logic, or am I missing something?

Great! Thanks a lot @coruscating, and I apologise to not answer you before, I was looking at the increasing in time as well. When I uploaded the current version of this PR, the building was 9 minutes, but after merging the main branch into this branch, the time increased a lot. I think it can be helpful to know when this happened and I found out that in the main branch it happened something similar after the commit #1306.

Thanks for pointing this out, I've temporarily pinned the Aer version in #1312 and now the docs CI is back to 5 minutes. The docs deploy job for this PR was only 18 minutes compared to 1-2 hours before and the new docs are live 🎉


Yotpo Reviews Connector Update

Is your feature request related to a specific problem?
Currently Yotpo Reviews requires using an external ID, which is linked to the email address.
This requires a user to have this data stored locally and then used when requesting user data. Via their Privacy API this should not be required any more and an email should be used.
Describe the solution you'd like
Change the Yotpo connector to instead:

Generate a utoken via api.yotpo.com/oauth/token
Check if data exists via api.yotpo.com/privacy/data/exists
If data exists, submit access request via api.yotpo.com/privacy/data

Describe alternatives you've considered, if any
Continue using the external id and providing instructions for clients on how to set up these connectors and infrastructure for required metadata
Additional context
This may have been changed recently, but haven't been able to determine exactly when the change here was made.

It looks like this only returns data to the admin email, and not the user itself, so the endpoints above are a non-starter at this point. Closing


Taxonomy modern picker - add new terms to open term set

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version 1.13
Node.js version 12
etc

Issue description
Hello there,
I'm wondering if there is any functionality to add new terms to open term set in taxonomy modern picker, somehow simulating the enterprise keyword functionality. The enterprise keyword add a new term if does match with any at the moment the user press enter or tab key.
Kindly let us know.

@RubenHerrera86 This feature is at the moment not available out of the box but can be accomplished using the advanced example available here. You will not get exactly the same functionality with the inline input box but you could use your own input method like a dialog or a panel.

This issue doesn't seem to be related to this repo as it either a UI request, or references PnP React Controls component.


bug(Compile): compile failed use SDK 7.0.302

compile failed use SDK 7.0.302

Description
close #1273

link issue dotnet/razor#8718


Request to Expose build_resumable_session_simple as a Public Function in google-cloud-storage

The function build_resumable_session_simple in the google-cloud-storage crate is currently marked as pub(crate), making it inaccessible to users outside the crate. This function provides crucial functionality for creating resumable upload sessions, which aligns with Google Cloud Storage's recommended practices for handling large uploads.
Use Case
Developers implementing resumable upload functionality are currently forced to either:

Re-implement the logic of build_resumable_session_simple which introduces redundancy and potential inconsistencies.
Use higher-level abstractions that may not fully align with specific use cases requiring direct control over resumable session creation.

For example, in our project, we need to initiate resumable uploads using minimal metadata (similar to the media upload type). However, the crate does not expose a public API for this specific operation, and the existing build_resumable_session_metadata function is too restrictive for our needs.
Proposed Solution
Expose build_resumable_session_simple as a public function. This change would:

Provide developers with more flexibility when implementing resumable uploads.
Prevent the need for duplicating code within external projects.

Alternatives:
If making build_resumable_session_simple public is not feasible, consider introducing a new public API specifically for initiating resumable upload sessions with minimal metadata requirements.

@yoshidan Anything can I contribute here?


Authentication process does not go through with latest TestCafe version (1.15.0/1.16.0)

TestCafeJSScript.txt
We were using TestCafe 1.10.1 where scripts used to work fine. Scripts also works fine with 1.14.0. If we upgrade to latest version of TestCafe then TestCafe scripts stops working as it gets stuck at authentication step.<!--
If you have all reproduction steps with a complete sample app, please share as many details as possible in the sections below.
Make sure that you tried using the latest TestCafe version (https://github.com/DevExpress/testcafe/releases), where this behavior might have been already addressed.
Before submitting an issue, please check CONTRIBUTING.md and existing issues in this repository (https://github.com/DevExpress/testcafe/issues) in case a similar issue exists or was already addressed. This may save your time (and ours).
-->
What is your Test Scenario?

What is the Current behavior?

What is the Expected behavior?

What is your web application and your TestCafe test code?

Your website URL (or attach your complete example):

Your complete test code (or attach your test files):

Your complete configuration file (if any):

Your complete test report:

Screenshots:

Steps to Reproduce:

Execute attach script using version 1.10.1/1.14.1 (where it works fine)
Execute attach script using version 1.15.0/<IP_ADDRESS> (where it stopped working)

Your Environment details:

testcafe version:
node.js version:
command-line arguments:
browser name and version:
platform and version:
other:

You can also try reproducing the issue with the attached script as earlier one had an
TestCafeJSScript_6566.txt
issue.

Hello aarti315,
Thank you for the code samples.
I have tried to reproduce the issue but without success.
I have exactly the same result with the following testcafe versions: 1.14.0, 1.15.0, 1.16.0.
The fixture from the TestCafeJSScript.txt file has the following output:
Using locally installed version of TestCafe.
 Running tests in:
 - Chrome 93.0.4577.82 / Windows 10

 Link Verification
 √ Usermenu Dropdown - Security Overview
undefined
undefined
ERROR The Chrome 93.0.4577.82 / Windows 10 browser disconnected. If you did not close the browser yourself, browser performance or network issues may be at fault.

Type "testcafe -h" for help.
undefined

The fixture from the TestCafeJSScript_6566.txt file has the following output:
Using locally installed version of TestCafe.
 Running tests in:
 - Chrome 93.0.4577.82 / Windows 10

 Link Verification
 √ Usermenu Dropdown - Security Overview

 1 passed (40s)

So, since I have the same results with different versions of testcafe, it seems like the issue may be related to some specifics of your environment. Can you try to reproduce the issue in another environment/on another machine?

Thanks for your response. I will check again on my side and come back in case of any issues.

I check and found the issue is only observed in case of internal user and not for external/third party user. There is difference in authentication method user for different users. For internal user, ADFS is used and we also use SSO. I need to investigate more on authentication details to find the difference.
Just in case if there is any such issue reported earlier then let me knw.

Hello,
Thank you for the clarification.
We have a similar issue with ADFS \ SSO authentication, but we did not manage to get the required information to reproduce and further research it from the customer.
Please share the results of your research with us.

I ran into the same issue. ADFS redirection ends up with a GET request status 400 and a blank page. Works fine with 1.14.0 but updating to 1.14.1 or anything above that causes the issue to occur. I can't provide you with an environment to reproduce it so I'm in just to let you know this might be a widespread problem regarding ADFS redirection during authentication.

omnidevZero,
Thank you for letting us know the results of your research.
The issue with the --disable-http2 CLI option is already fixed. The fix is available in<EMAIL_ADDRESS>Regarding, the initial issue with the ADFS, it would be helpful if we could get an environment where this issue is reproducible for further research.


SCMF test failures

I've been getting some weird behaviour in the SCMF tests on master. I get consistent failures which obviously aren't replicated on the CI- specifically, when running test_scmf.py I get
============================================================================================= short test summary info =============================================================================================
FAILED vayesta/tests/core/scmf/test_scmf.py::SCMF_Test::test_brueckner - AttributeError: 'EWF' object has no attribute 'diis'
FAILED vayesta/tests/core/scmf/test_scmf.py::SCMF_UHF_Test::test_brueckner - AttributeError: 'UEWF' object has no attribute 'diis'
===================================================================================== 2 failed, 2 passed, 3 warnings in 3.36s =====================================================================================

These trace back to the SCMF kernel, l79 of vayesta/core/scmf/scmf.py
        diis = (self.get_diis() if self.diis else None)

What seems to be happening here is that since the SCMF kernel is called via the command (in qemb.py, with self as the Embedding class)
        self.kernel = self.with_scmf.kernel.__get__(self)

which seems to result in calling with_scmf.kernel but with self equal to the embedding object (I'm not hugely familiar with the expected behaviour here, maybe @maxnus knows?).
I'm basing this off the result of running a calculation on the branch debug_scmf, which adds logging at the start of SCMF.kernel
        self.log.warning("In SCMF, self is: %s", str(type(self)))
        self.log.warning(f"self.with_scmf.diis: {self.with_scmf.diis}")
        self.log.warning(f"self.diis: {self.diis}")

and gives me the result when running any SCMF calculation of
[WARNING] |  In SCMF, self is: <class 'vayesta.ewf.ewf.EWF'>
[WARNING] |  self.with_scmf.diis: True
EWF(mf: DensityFitting-RHF object of <class 'pyscf.df.df_jk.density_fit.<locals>.DensityFitting'>, solver: 'CCSD') <vayesta.core.scmf.pdmet.PDMET_RHF object at 0x7f710d6c9310>
True
Traceback (most recent call last):
  File "/home/charlie/calc/bugfix/scmf/test.py", line 24, in <module>
    rewf.kernel()
  File "/home/charlie/code/Vayesta/vayesta/core/scmf/scmf.py", line 81, in kernel
    self.log.warning(f"self.diis: {self.diis}")
                                   ^^^^^^^^^
AttributeError: 'EWF' object has no attribute 'diis'

If this is what's going on, an obvious fix is just to ensure that all statements within the SCMF kernels correctly anticipate that self is an EWF object. However, I have no idea why this isn't showing up for me in the pDMET tests or just in general- @abhishekkhedkar09 can't reproduce this behaviour on that branch. I'm using python 3.11, which might have changed some behaviour affecting this maybe?

assuming it's a change to the behaviour of this:
https://github.com/BoothGroup/Vayesta/blob/be227313c17c10d183e3dc9c7a522099cc426b6a/vayesta/core/qemb/qemb.py#L1634C1-L1635

Sorry, I should have referred to there- that's where the expression
        self.kernel = self.with_scmf.kernel.__get__(self)

which I think is problematic is.
Exactly the same expression is used in the pDMET code, so something that was confusing me was how those tests were passing. This was answered when I noticed this https://github.com/BoothGroup/Vayesta/blob/be227313c17c10d183e3dc9c7a522099cc426b6a/vayesta/tests/core/scmf/test_scmf.py#L32C5-L35 ; the pDMET test just returns without running anything, so will always pass.
We should either remove the test entirely or fix whatever issue made this necessary in the first place; from the look of it this shortcircuit of the test was added in the same commit as the rest of the test, so I guess we've never actually been testing the pDMET functionality?
Also, I don't understand the use of __get__(self) in the first place; if we want self to be the SCMF object within SCMF.kernel  then replacing the above with
self.kernel = self.with_scmf.kernel

accomplishes that while being (I would argue) much clearer, and avoids this issue in testing. If we want self within SCMF.kernel to be the Embedding object having SCMF objects as subclasses of Embedding (which could be initialised similarly and use multiple inheritance to combine with EWF, DMET etc) seems a more natural solution, though definitely harder to implement.

Running a few more tests I can confirm that the issue here is python 3.11 related, and that the above fixes these test failures. Our options are either to fix this behaviour, or change our requirements to not support python 3.11. Pyscf already supports 3.11 since v.2.2.1, so updating might actually be surprisingly straightforward (as shown by these being the only test failures I encountered).
The main issues are for pybind11/ctypes based code which @obackhouse has discussed, but I think our main (possibly only?) such code  is kao2gmo which we already have a pure python driver for. We could just change this to use the python driver if 3.11 is being used as a fix for now- if this seems reasonable after some discussion I'd be happy to implemented a quick PR doing this along with the above change to SCMF.

I had wondered what on earth that code was doing, as the only reason I could see for the presence of self in the assignment was trying to rebind it from with_scmf to Embedding. Python 3.11 made a lot of changes under the hood, so I'm guessing get respecting passage of the full signature of bound functions (aka requiring specification of self and passing this along) is one of them. A quick test trying __get__() in this call returns an error supporting this.
So, given that the current code is written to expect self to remain as an SCMF object and pyscf uses callable attributes the whole time I don't see an issue for now with just using self.method = func. It's better than the current situation as even if inelegant it should at least work on it's own terms.
A reimplementation at some point sounds plausibly essential if we want to support SCMF in any robust sense going forward. I have some general thoughts on this and will put up an issue for discussion after some more experimentation with code structures.
I'll put together a PR to apply this patch for now.

This was fixed in #99 so closing issue; a full rewrite is out of scope for now.
Given the overwrite functionality seems unused and untested I'll mention it in #95.


ValidationError when converting Decimal('10000000000000000000') to int

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Hello :wave: :nerd_face:
Pydantic throws a ValidationError when converting a Decimal of an int to int. Not sure if this is the expected behavior.
from decimal import Decimal
from pydantic import BaseModel

class A(BaseModel):
    a: int

A(a=10000000000000000000)  # this works

A(a=Decimal('10000000000000000000'))  # this doesn't

ValidationError: 1 validation error for A
a
  Unable to parse input string as an integer, exceeded maximum size [type=int_parsing_size, input_value=Decimal('10000000000000000000'), input_type=Decimal]
    For further information visit https://errors.pydantic.dev/2.3/v/int_parsing_size

Example Code
from decimal import Decimal
from pydantic import BaseModel

class A(BaseModel):
    a: int

A(a=Decimal('10000000000000000000'))

Python, Pydantic & OS Version
pydantic version: 2.3.0
  pydantic-core version: 2.6.3
    pydantic-core build: profile=release pgo=true
            install path: ****/.venv/lib/python3.10/site-packages/pydantic
          python version: 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0]
                platform: Linux-5.19.0-50-generic-x86_64-with-glibc2.35
optional deps. installed: ['typing-extensions']

Selected Assignee: @lig

It looks like what's happening here is that the Decimal is getting converted to a float first and then trying to be pushed into a float64. We'll need to fix this on the pydantic-core side.

This will be fixed in the next release. Thank you for reporting it!

Thank you @adriangb, you guys are amazing :heart:


Persistent personalized views of dashboards

It would be really useful if users could easily save the state of their filters on a dashboard, which would then be loaded by default every time they view the dashboard.  These would be user specific so other users would see the default provided by the dashboard author or their own saved settings.

Note that the URLs are stateful so if someone bookmarks a filtered dash it captures the filter.

That is handy, but it requires that they always access the page via bookmark.  If someone is jumping between dashboards within the UI it doesn't solve the problem.

It's not clear to me that users would expect a sticky filter that would go beyond the browser session. I doubt other tools like Tableau would do this.

Tableau has views to save dashboard filter state among others.


✨ fix a quickstart.test failure

Summary
The quickstart.test was somehow missing a SM_CONTEXT define.
Related issue(s)
Fixes #

/lgtm
/approve


Created separate SCSS/LESS files for different weights

Hello, in response to https://github.com/choffmeister/roboto-fontface-bower/issues/19 I've created separate  SCSS/LESS files for different weights

Hi, thx for your PR. Giving the possibility to only include the font/weight one needs, is a good addition. But with your commit there are dozen files to that are almost the same.
You might want to take a look here (https://github.com/choffmeister/roboto-fontface-bower/pull/23#discussion_r44274573). Do u think u could use the mixin style so that we only have 4 files (main less, mixin less, main scss, mixin scss) to keep the duplication as low as possible?

@choffmeister I implemented your suggestions

Thx! I merged it and added a small test suite, that less/sass compiles every file. Will enable circleci testing on it and then release as 0.4.4


Fixed broken link to ToolsAndDebugging.md

Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:

[NA] Run bundle exec rspec from the subdirectory of each tool you modified. Alternatively, run rake test_all from the root directory.
[NA] Run bundle exec rubocop -a to ensure the code style is valid
[X] Read the Contribution Guidelines
[X] We currently don't accept new actions, please publish a plugin instead, more information in Plugins.md

Before submitting a pull request, we appreciate if you create an issue first to discuss the change :+1:
Fixed broken link to ToolsAndDebugging.md

I see it is already fixed in
https://github.com/fastlane/fastlane/pull/7416

Thanks, yeah, let's merge #7416 👍


[HOLD for payment 2023-03-31] IOU and Split Bill chats not showing as unread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Account A and account B have never chatted
Account B sends account A a IOU request
The chat with the money request shows up in the LHN but is not unread

The same thing happens if it's a split money request to multiple people.
Expected Result:
The chat would be unread
Actual Result:
The chat shows up as read
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01580c91187cf88b1f
Upwork Job ID:<PHONE_NUMBER>892919808
Last Price Increase: 2023-02-10

Gonna put this on hold until we finish the transition to sequence numbers. Then will see if this is still an issue.

Still on hold. Should be able to work on it soon though.

Will look into this this week if it is still happening.

Job added to Upwork: https://www.upwork.com/jobs/~01580c91187cf88b1f

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

Woof, it took me forever to figure out and I was sure the issue was on the API side, but it turns out to be a one-line change on the client 🤦🏾.

@puneetlath, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Yep, working on a fix.

@puneetlath, @parasharrajat Eep! 4 days overdue now. Issues have feelings too...

@puneetlath, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Auth PR is in review. Will be able to ask for a re-review on the App PR once that one is deployed.

@puneetlath, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath, @parasharrajat Huh... This is 4 days overdue. Who can take care of this?

@puneetlath, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.88-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15052

If no regressions arise, payment will be issued on 2023-03-31. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@parasharrajat / @puneetlath] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@parasharrajat / @puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@parasharrajat / @puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@puneetlath] Determine if we should create a regression test for this bug.
[ ] [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@parasharrajat could you help with the checklist?

@parasharrajat I've also sent you a contract here: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/23878831

Thanks for the bumps @parasharrajat and sorry for the delay. That all looks good to me. I've gone ahead and paid out the contract. Thank you!


Initial MPS support

This PR adds initial support of MPS extension for Metal that unlocks ray tracing functionality (I plan to add more as I go along). All APIs are hidden behind mps feature toggle.

CI fails on Select Rust channel

Something weird is going on with CI
The PR is ready to land though


Support host option to serve app on local network

Description

Support custom hosts (via a host option) to serve the website on the local network (e.g., <IP_ADDRESS>).
Motivation

Having a host option makes it easy to test your website on your local devices (mobiles, tablets, laptops, desktops, etc.). This enables good DX and empowers people to try their websites on different real devices connected to the same local network.
Most development server services offer this feature and I was frustrated not being able to try the website I'm working on on a real touch device.
Solution

Introduce a host string option that defaults to localhost
Document that <IP_ADDRESS> can be set to open the website on your devices connected to the local network

Additional context

Webpack Dev Server host option
Parcel host option

Fixed in https://github.com/algolia/frontman/pull/36. This will be available when we release v0.0.5


Added UDP listen command

I chatted about this with @dmiddlecamp this morning (morning of 2016-02-24).  It's fleshing out a "stub" at https://github.com/spark/particle-cli/blob/master/commands/UdpCommands.js#L49 to give users an easy way to broadcast UDP messages from their devices and monitor them without resorting to complicated tools like tcpdump or Wireshark.

Have you tried nc -ul 5549? That is pretty simple.

@brycekahle - I have (it's what I used for testing before this PR), but utilities like netcat, tcpdump, and ngrep aren't something many Windows users will have installed (and know how to use).  This is a simpler, user-friendlier alternative.  ;-)


chore: add setVault to note trait template

chore: add setVault to note trait template
This PR:

adds the new setVault onCreate method as an example to the note trait template

Hmm, I kinda don't want to expose this until we have a further discussion on this part of the API (I know we already released it though).

Hmm, I kinda don't want to expose this until we have a further discussion on this part of the API (I know we already released it though).

Hmm... do we want to omit it from the release notes too then?


Input binding does not update when styled with Materialize CSS

Vue.js version
1.0.26
Reproduction Link
https://jsfiddle.net/b766b0ep/1/
Steps to reproduce

Implement the select binding as given in the Vue guide.
Add the Material design styling framework.
Apply the select element styling.

What is Expected?

The "selected" binding in the model should update to reflect the value the user selects from the drop-down.

What is actually happening?

The bound value stays stale, it does not reflect the value the user selected.

Workaround

Material offers a ".browser-default" class which overrides the style of the control to the default. Using this style on the select fixes the Vue binding.

This is demonstrated in the fiddle provided.
Notes
Apparently the value of the underlying select element is updated differently when the material style is used, and this bypasses the Vue change detection.

Vue cannot detect changes made by other libraries.
And also, vue works under the assumption that you do not modify dom yourself (or with other libs).


density vs number

Hi,
MP should have a look at "decreased skeletal muscle fiber number”, "increased skeletal muscle fiber density”, and related terms. All of them use PATO-amount, i.e. on the basis of logical definitions these are treated equally. If those terms are indeed equivalent, they should maybe merged, if they are different, the definitions should be updated.
Seb

The issue is with the logical definitions. You can have an increase in cell number without an increase in cell density and vice versa. I spent some time looking for an accurate PATO term for cell density but I'm having trouble finding one.


Periodically refresh timestampPeriod for better GPU timestamp calibration on macOS

This PR is specific to MoltenVK on macOS, where Vulkan timestampPeriod calibration is dynamic for non-Apple GPUs, and needs to be refreshed periodically by calling vkGetPhysicalDeviceProperties().  nvrhi currently calls this only once during initialization and therefore timestamps (e.g. GPU timings shown in the RBDooom3BFG HUD) may not be accurate on macOS for AMD and Intel GPUs.  This is not an issue for Apple Silicon GPUs where timestampPeriod is locked to 1.0.
On macOS for non-Apple GPUs only, this fix periodically calls m_Context.physicalDevice.getProperties() during nvrhi timestamp queries not more than once per second to refresh timestampPeriod.  Note that we cannot refresh timestampPeriod every timestamp query or frame since Metal's sampleTimestamps() has overhead on macOS and this would reduce performance.  The not more than once-per-second update implemented here does not seem to affect performance and is an acceptable compromise.
This change is purely an #ifdef addition to Device::pollTimerQuery()  and does not modify existing code.  Future nvrhi merges and maintenance should not be a problem.

Rebased onto updated nvrhi main...

I merged all your NVRHI pull requests manually because of the rebase.

Thanks very much Robert.


fix:修复OnReceivedResult CallbackId

Brief Description of the PR
Checklist

Demo:
Documentation:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: katherine95s:x: Huiying JiangHuiying Jiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: katherine95s:x: Huiying JiangHuiying Jiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Updates the docs regarding replica size

The wording around replica size in the high availability docs varies from "exactly 4" to "at least 4". Since this document is rather high level, the suggestion is to keep the wording consistent to 4. A link is added to the more in depth document discussing data distribution under the hood.
Addresses issue #81120 (see full discussion there)

@spygi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off


[Report Fields] Ensure we use correct default for the areReportFieldsEnabled when the flag is not defined in getAsOnyxUpdate

[Main tracking issue].(https://github.com/Expensify/Expensify/issues/365155)
Design doc link.
Implement the following section of the design doc: https://docs.google.com/document/d/10b7pTVvgpB6_O8sRTKaCzZEVM3Ba6hxnIwyyQSSXCLY/edit#bookmark=id.wdwsqekhx2rr
Issue OwnerCurrent Issue Owner: @mountiny

Looking into this one today

PR is up in a review

Merged

Should this issue be closed?

Yes this can be closed


Implement Integer/show

Relates to #49

I also did the other conversion, so I am closing this pr in favour of another one that has both Integer/show and Double/show, avoiding 2 prs

The new one is #54


SSH with (outdated) JSch plugin can't connect to Ubuntu 2022

Description
Hi,
I'm not able to create SSH tunneling connection using private key to one Ubuntu 2022 server. I get error "Auth failed" with correct key.
I had the same issue with Filezilla, Putty ... and issue was solved with the latest version.
I see that DBeaver is using https://mvnrepository.com/artifact/com.jcraft/jsch , last update 4 years ago (or modification 3 years old). I assume that issue is in outdated plugin.
DBeaver Version
<IP_ADDRESS>208051447 Community Edition
Operating System
Windows 10
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

@matke2002, have you tried to use SSHJ?

Hi @E1izabeth,
with SSHJ I get connection timeout.

DBeaver uses the latest Jsch version. JSch seems not to be updated anymore.
I guess this issue is a duplicate of https://github.com/dbeaver/dbeaver/issues/14749


Worker.postMessage missing optional options parameter

TypeScript Version:  3.5.0-rc

Search Terms:
Worker MessagePort postMessage
Code
let worker: Worker;
worker.postMessage("test");

let port: MessagePort;
port.postMessage("test");

let either: MessagePort | Worker;
either.postMessage("test"); //  error TS2554: Expected 2 arguments, but got 1.

Expected behavior:
No error. There is no error in 3.4. I'm not sure if this is a bug in the compiler or due to the changes to MessagePort.postMessage in lib.dom.d.ts. Should Worker.postMessage also be updated to have the optional options parameter?
Reference: https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-worker-interface
Actual behavior:
error TS2554: Expected 2 arguments, but got 1.

The problem is that MessagePort has two overloads for postMessage, the second of which has transfer, but transfer isn't optional there. If you change it to optional in the second overload, there's no error.
On the other hand, reading through the spec leads me to this interface:
interface DedicatedWorkerGlobalScope : WorkerGlobalScope {
  [Replaceable] readonly attribute DOMString name;

  void postMessage(any message, sequence<object> transfer);
  void postMessage(any message, optional PostMessageOptions options);

  void close();

  attribute EventHandler onmessage;
  attribute EventHandler onmessageerror;
};

sequence<object> transfer doesn't look optional to me, especially in comparison to the optional PostMessageOptions options on the next line. Perhaps the spec is wrong here?

I'm confused though: despite the non-optional transfer, shouldn't the call with only one argument still match the postMessage(any message, optional PostMessageOptions options) case?

@fatcerberus I believe the code that creates a signature from a union of signatures is stricter about the number of required parameters in the resulting signature.
Here's a standalone version that's easier to paste into the playground:
interface Terable {
    a,b,c
}
interface PostMessageOptions {
    transferable: Terable[]
}
interface MsgPort {
    postMessage(message: any, options?: PostMessageOptions): void;
    postMessage(message: any, transfer: Terable[]): void;
}
interface Wrkr {
    postMessage(message: any, transfer?: Terable[]): void;
}
declare let either: MsgPort | Wrkr;
either.postMessage('test')

This is a regression from 3.4. Is there a reason that MessagePort was updated but Worker was not?
3.4:

MessagePort: https://github.com/microsoft/TypeScript/blob/release-3.4/lib/lib.dom.d.ts#L10283
Worker: https://github.com/microsoft/TypeScript/blob/release-3.4/lib/lib.dom.d.ts#L17165

3.5:

MessagePort: https://github.com/microsoft/TypeScript/blob/release-3.5/lib/lib.dom.d.ts#L10350-L10351
Worker: https://github.com/microsoft/TypeScript/blob/release-3.5/lib/lib.dom.d.ts#L17351

The error goes away if Wrkr has the same two signatures as MsgPort.

@sandersn Oh I see - Worker is missing the options overload.  My comment above was based on a reading of the spec in which Worker and MessagePort have the same two overloads for postMessage.  So yeah, same question as @dasa above me - why was that second overload removed?

Looks like @saschanaz just missed it in https://github.com/microsoft/TSJS-lib-generator/pull/679. That PR has overrides for MessagePort, ServiceWorker and DedicatedWorkerGlobalScope, but not Worker.
I think it's correct to add it for Worker too, but I want to find out how @saschanaz determined those 3 were the ones that got the overrides before I do.

Here's the link for Worker. I'll go ahead and add it in TSJS-lib-generator.

@sandersn Maybe the transfer param should be optional? I found this in the spec:
dedicatedWorkerGlobal.postMessage(message [, transfer ])
dedicatedWorkerGlobal.postMessage(message [, { transfer } ])

And now I still got an error while pass only one param, I have to change it to
worker.postMessage('message', undefined);

that is not a good practice


[5.2] Trigger a "Lockout" event when authentication is throttled

Would be very useful to have an event fired when a user is throttled for logging / audit purposes.

Please squash to one commit.

Ah I knew I forgot something. Done!


iOS 15?

It seems to connect to VPN ok.  But does not Mount support files. I’ve tried the iOS 15 support files as well, still won’t mount

Are you asking if Jitterbug runs on iOS 15 or if it can launch apps on another device running iOS 15?

I figured it out. Had to rebuild using a beta version of Xcode and update libraries. Works fine now.


Add an example using aesara and aeppl

Aeppl is a very expressive PPL written in aesara. Aehmc implements a NUTS sampler identical to blackjax's and it would be interesting for me to have a benchmark. It would also be a nice example for this PPL.

Currently working on a personal project that builds the model's logpdf using aeppl. Will add a simplified version to the repo.

Closed with #255


JS heap size increase not working (--max_old_space_size)

Issue
While build or run my project with create-react-app. It throws js heap out of memory error.
`

yarn build
yarn run v1.6.0
$ react-scripts build
Creating an optimized production build...
<--- Last few GCs --->
[8792:0000021D06B28B70]  1492086 ms: Mark-sweep 1401.7 (1716.2) -> 1401.7 (1716.2) MB, 1474.4 / 0.0 ms  allocation failure GC in old space requested
[8792:0000021D06B28B70]  1493542 ms: Mark-sweep 1401.7 (1716.2) -> 1401.5 (1658.7) MB, 1455.7 / 0.0 ms  last resort GC in old space requested
[8792:0000021D06B28B70]  1494983 ms: Mark-sweep 1401.5 (1658.7) -> 1401.5 (1636.7) MB, 1439.7 / 0.0 ms  last resort GC in old space requested
<--- JS stacktrace --->
`

After searching on internet, i found a few suggestions and have added the following lines to my package start and build lines.

"start": "node --max_old_space_size=4096 node_modules/.bin/react-scripts start",
"build": "node --max_old_space_size=4096 node_modules/.bin/react-scripts build"

Now when i run "npm start" or "npm build" i get the following error.
`

npm start
<EMAIL_ADDRESS>start D:\my-apps
node --max_old_space_size=4096 node_modules/.bin/react-scripts start
D:\my-apps\node_modules.bin\react-scripts:2
basedir=$(dirname "$(echo "$0" | sed -e 's,\,/,g')")
^^^^^^^
SyntaxError: missing ) after argument list
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Module._compile (module.js:599:28)
at Object.Module._extensions..js (module.js:646:10)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)
at Function.Module._load (module.js:489:3)
at Function.Module.runMain (module.js:676:10)
at startup (bootstrap_node.js:187:16)
at bootstrap_node.js:608:3
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: node --max_old_space_size=4096 node_modules/.bin/react-scripts start
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!
Yes, the issue exists after deleting node_modules folder and reinstalling through npm
Environment

Environment:
OS:  Windows 10 Pro
Node:  8.9.3
Yarn:  1.6.0
npm:  6.1.0
Watchman:  Not Found
Xcode:  N/A
Android Studio:  Not Found
Packages: (wanted => installed)
react: ^16.2.0 => 16.4.0
react-dom: ^16.2.0 => 16.4.0
react-scripts: 1.1.4 => 1.1.4

Does this help? https://github.com/nodejs/node/issues/8117#issuecomment-239954661

@Timer Big thanks. This has really worked.  Is this documented anywhere?

No, PRs welcome! :)

@Timer this is working, build successfully, but the output files are not correct.

@Timer @andyliu-417 @bugzpodder is this a viable solution? Or is your bundle acctually getting wrong @andyliu-417 ?


Make all DNS and HTTP URL comparisons case insensitive

Fixes more interactions such as FOO.EXAMPLE.COM that were previously being missed due to case-sensitive comparison.
Switches URL suffix matching to case-insensitive as a belt & braces measure to try and get more possible interactions.

Good catch! Happy to fix this up today as well and will add to the PR.


Add readme.txt file

To submit a plugin to the WordPress store, we need to add a readme.txt file to project, which contains all the information that will be listed on the storepage for the plugin.
Link: https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/

<EMAIL_ADDRESS>is used for komoju.com contact form and live application, so maybe you meant this one?
<EMAIL_ADDRESS>does not exist.

@takeshi-d Thanks for letting me know 😄 I'll update the PR

@jdgc I believe so. According to this section in the docs the data for the readme is just taking from the SVN repository, so we should be able to update readme file there and see the changes be reflected in the store.


Add table map initializer

This PR fixes the issue with missing table registration when using PHP 7.4 preloading (see #1695).
This is a big one, and I am not sure how much I like it. But there is probably no way around it.
tl;dr

Instead of relying on automatic registration of tables, which does not work with preloading, the tables are now registered explicitly through a script.
Script creation and importing is done in a way where it does not impact existing projects.
However, users have to rebuild their configuration and their models with the config:convert and model:build command.
If they are not aware of that, exceptions will tell them what to do.

Background
The metadata for tables is stored in table map files, which are generated by the model:build command (i.e. BookTableMap.php). They are registered in database maps in the global ServiceContainer. Every reference to a table in Propel is resolved through these files. Without the table map files, Propel knows nothing about the table and will not be able to work with it.
Currently, the table map files register themselves when being loaded. This is done through a static call, which is inserted after the class declaration in each table map file:
class BookTableMap extends TableMap
{
    ...

     /**
     * Add a TableMap instance to the database for this tableMap class.
     */
    public static function buildTableMap()
    {
        $dbMap = Propel::getServiceContainer()->getDatabaseMap(BookTableMap::DATABASE_NAME);
        if (!$dbMap->hasTable(BookTableMap::TABLE_NAME)) {
            $dbMap->addTableObject(new BookTableMap());
        }
    }
} // BookTableMap
// This is the static code needed to register the TableMap for this table with the main Propel class.
//
BookTableMap::buildTableMap()

This approach is often used to bridge the issue of missing static class initializers in PHP. It is pretty nice, because no additional structure is needed - the classes just make themselves known to the ServiceContainer.
The problem
When using PHP 7.4 preloading, the static call is executed during preloading, but the result is removed when preloading finishes. The static calls are not run again when restoring from cache (see for example here or #1695), leading to an empty database schema. This means that it is currently impossible to preload the table map files.
Proposed solution
So, there is an easy part and a hard part to fixing this.
The easy part is to extract the static table map initialization calls into a standalone script, which can be run manually during Propel initialization. This can easily be done during the 'model:build' command.
The hard part is figuring out how to run the script without having users to adjust their code base. Because while it would be easy to have them import the file manually, like the configuration, it means that they have to be aware of the change and know what to do, which will lead to endless bug reports.
I think the least annoying approach is to add an import statement at the end of the configuration. It is the only file directly imported into a Propel project, making it the only candidate for piggybacking. It is also auto-generated, so we can change it in a structured manner.
Very nice, however, creating the configuration and creating the table loader script is done in different commands - config:convert  and model:build. So after building the configuration, it contains an import statement for a file, which is yet to be created. And  model:build needs to know where the configuration expects the table loader script, but doesn't even know where the configuration file is. Also, the process has to work without users necessarily being aware of it.
Long story short, this is what I came up with:

running config:convert creates an updated configuration which imports the table loader script, and creates a dummy file at the expected location
running model:build will create the actual table loader script at the expected location
The expected location is either shared through the paths property of the raw configuration (like propel.json), or by passing a value via parameter to both commands:

either the parameter --loader-script-dir has to be passed to both commands for manual setup
setting the new paths.loaderScriptDir property in the raw configuration allows to set a custom location
if none of the above is given, the script will be put at the location of paths.phpConfigDir (which default to ./generated-conf/)

if a user updates Propel without rebuilding the configuration, an exception is thrown upon reading it, telling them to run config:convert
if a user has updated the configuration, but has not rebuild the models, the service container will throw an exception when accessing the database map, telling him to check the script, and if it is the dummy script, it will tell them to run model:build

So this changes some substantial mechanisms in Propel, and I a bit anxious about that. Probably why the topic was gracefully dropped in #361. Then again, I don't think there is a way around it. I have looked for easier ways, like fiddling with the composer autoload mechanism, or just searching for all table map classes during initialization, but those introduce performance issues among other problems.
Of course, I am always happy to discuss.

Alright, test look better on my machine... This will take some time to fix

Codecov Report

Merging #1742 (0a9f42e) into master (f86b4e6) will decrease coverage by 14.55%.
The diff coverage is 96.59%.

@@              Coverage Diff              @@
##             master    #1742       +/-   ##
=============================================
- Coverage     88.34%   73.79%   -14.56%
- Complexity     7753     7780       +27
=============================================
  Files           263      265        +2
  Lines         22244    22202       -42
=============================================
- Hits          19652    16384     -3268
- Misses         2592     5818     +3226

Flag
Coverage Δ

5-max
73.79% <96.59%> (-14.56%)
:arrow_down:

7.4
73.79% <96.59%> (-14.56%)
:arrow_down:

agnostic
73.79% <96.59%> (+0.10%)
:arrow_up:

mysql
?

pgsql
?

sqlite
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Propel/Generator/Manager/ModelManager.php
89.77% <88.23%> (-6.01%)
:arrow_down:

...time/ServiceContainer/StandardServiceContainer.php
84.82% <93.75%> (+0.38%)
:arrow_up:

.../Propel/Generator/Command/ConfigConvertCommand.php
86.66% <95.00%> (-6.67%)
:arrow_down:

src/Propel/Common/Config/PropelConfiguration.php
99.35% <100.00%> (+<0.01%)
:arrow_up:

...rc/Propel/Generator/Builder/Om/TableMapBuilder.php
95.37% <100.00%> (-0.24%)
:arrow_down:

...nerator/Builder/Om/TableMapLoaderScriptBuilder.php
100.00% <100.00%> (ø)

...ator/Builder/Om/templates/tableMapLoaderScript.php
100.00% <100.00%> (ø)

src/Propel/Generator/Command/ModelBuildCommand.php
73.62% <100.00%> (+1.21%)
:arrow_up:

...rc/Propel/Generator/Command/TestPrepareCommand.php
59.25% <100.00%> (-35.75%)
:arrow_down:

...rc/Propel/Generator/Config/ArrayToPhpConverter.php
95.23% <100.00%> (-0.77%)
:arrow_down:

... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86b4e6...0a9f42e. Read the comment docs.


Data Replication

Data should be replicated to other servers as it is being written. This will create a more reliable system and allow nodes to fail.
To ensure data is being replicated safely, we will use raft. coreos/etcd has a solid raft implementation that we can use.
Each buffer will be a unique raft cluster. Meaning when a buffer is created via the scheduler, a new raft cluster will be initialized. Doing so should allow for chatty buffers to be isolated from each other by moving the cluster around servers.

Raft could hurt throughput performance. Here is a snapshot of the current benchmarks (pre raft):
BenchmarkSingleBufferWrite-8     	   20000	     57910 ns/op
BenchmarkSingleBufferRead-8      	   20000	    144192 ns/op
BenchmarkCreatingBuffers-8       	   10000	    228086 ns/op
BenchmarkMultipleBuffersRead-8   	    2000	    658063 ns/op

These measurements are for a raft cluster of size one:
BenchmarkSingleBufferWrite-8     	   20000	    121557 ns/op
BenchmarkSingleBufferRead-8      	   10000	    197640 ns/op
BenchmarkCreatingBuffers-8       	    5000	    402571 ns/op
BenchmarkMultipleBuffersRead-8   	     300	   4323034 ns/op

After a first pass with raft (3 nodes):
BenchmarkSingleBufferWrite-8     	   20000	    150796 ns/op
BenchmarkSingleBufferRead-8      	   10000	    177707 ns/op
BenchmarkCreatingBuffers-8       	      20	  67413347 ns/op
BenchmarkMultipleBuffersRead-8   	    1000	   1290024 ns/op