make test on Windows 10 under MSYS fails to compile the code

Running make test on Windows 10 results in this failure:
gcc_libinit_windows.c: In function ‘x_cgo_sys_thread_create’:
gcc_libinit_windows.c:57:12: error: implicit declaration of function ‘_beginthread’ [-Werr
or=implicit-function-declaration]
   57 |  thandle = _beginthread(func, 0, arg);
      |            ^~~~~~~~~~~~
cc1: all warnings being treated as errors

That is apparently due to go test -race ./... requiring the tdm-gcc rather than the gcc compiler provided by MSYS. As a consequence every unit test fails. Running go test ./... succeeds.
This leads me to several questions. For example, this seems to work on AppVeyor CI. However, I can't tell if that's because it runs go test ./... or tdm-gcc is being installed and used so as to allow make test to work. I can't tell which is true because I can't figure out how the Elvish CI environment on AppVeyor is configured. Nor is there any documentation on how to configure Windows to support building and testing Elvish on that platform.

Also, it's not clear if tdm-gcc is a prerequisite for building the Windows elvish binary that is available at https://elv.sh/get/. In other words, which toolchains are supported? While MSYS appears to be required, as a practical matter, to use Elvish on Windows it appears only the standard Go toolchain is needed to build it -- albeit with tdm-gcc as a prereq in order to execute go test -race ./....

Hmm, AppVeyor uses a plain go test - the config file is .appveyor.yml. And that's exactly because I had problems with go test -race on Windows.
https://github.com/golang/go/issues/27089 mentions that go test -race on Windows requires (some) GCC, and presumably some GCC builds are compatible with Go while others are not (I didn't find any specific reference to tdm-gcc there).
I'll just remove windows from the make test rule as we can't reliably determine whether the Windows environment has a suitable GCC binary.

Also, this isn't really an Elvish-specific problem, but a Go toolchain issue.


ISL tutorial names are not "informative"

One has to click and view the tutorial to know what it is about. The same could be argued about the end-to-end tutorials as well as ensembles (1), (2) and (3).

Just a short note that we will also need to update this page.

Will self-assign to soon update names for all tutorials

Time to close.


kweishaar: add readme for KPA docs

@cs-pvyas
Please review. Our console docs guide users through the console set up after cloud account registration so we'll probably want to adjust the install agent section. I included some of the extra info around the agent: proxy and resource consumption.

Version bumped to 0.43.9


Populate node status transition timestamp and reason

Post node last transition time and status reason.

PTAL

LGTM.


[Bug] Custom Menu Swaps not working in instance

As an ironman when I'm standing outside zilyana room the plugin is working perfectly. I can use the custom shift swap for Starlight to attack it if I have attack options hidden and I can use the Custom Swap to prioritise attacking Zilyana. When I enter the boss room as an ironman(Ironman Instance) Nothing is working. When I enter on my normie(Non instance) Everything is working fine. Didnt try private instance on my normie though.

Issue fixed with disabling an option in the runelite plugin named “Opponent Information” that puts a * on monsters you have tagged. Thanks to @geheur for figuring this out :)


How to set properties previously set via UriQueryParameter ?

We are using Java SDK and trying to upgrade from 1.31.0 -> 1.34.0.

In 1.31.0, we are setting property setfeature to value multichannel2 with below code to handle stereo streams
speechConfig.setServiceProperty("setfeature", "multichannel2", ServicePropertyChannel.UriQueryParameter);
which passes the value as uri query parameter in the endpoint
wss://eastus.stt.speech.microsoft.com/speech/recognition/dictation/cognitiveservices/v1?...setfeature=multichannel2...
this gives us 2 channels transcribed separately as expected:

hi thanks for contacting the store how can i help you (role = INTERNAL)
hi good morning i have couple of questions regarding my recent order (role = EXTERNAL)

After upgrading to 1.34.0, we are not getting transcription separated into two channels as before, instead transcription is just for one channel

hi thanks for contacting the store how can i help you hi good morning i have couple of questions regarding my recent order (role = INTERNAL)

[The release notes for 1.34.0](https://learn.microsoft.com/en-us/azure/ai-services/speech-service/releasenotes?tabs=speech-sdk ](https://learn.microsoft.com/en-us/azure/ai-services/speech-service/releasenotes?tabs=speech-sdk#speech-sdk-1340-november-2023-release) say

Breaking changes:
SpeechRecognizer has been updated to use a new endpoint by default (i.e. when not explicitly specifying a URL) which no longer supports query string parameters for most of the properties. Instead of setting query string parameters directly with ServicePropertyChannel.UriQueryParameter, please use the corresponding API functions.

Which corresponding API functions this is referring to and how to accomplish using multichannel2 with sdk 1.34.0 ?

Hi @kokovoj , thank you for using the SDK. I will get back to you with more details on this. I have forwarded your question to people more directly involved in this part of the project.

@M-Hietala What do you recommend here?

Possibly the same question as<PHONE_NUMBER>009007 on Speech Services support channel.

@pankopon, that sounds like an internal channel that I don't have access to. If/when there is a solution there, could you please let me know.

Closing this item as processing continues on another support channel.


Pub get failed

flutter pub add -d tailwind_cli
    Because tailwind_cli <0.2.1 depends on dcli ^1.12.4 and tailwind_cli >=0.2.1 <0.5.5 depends on dcli ^1.31.2, tailwind_cli <0.5.5 requires dcli ^1.12.4.
    And because tailwind_cli >=0.5.5 <0.5.6 depends on dcli ^1.36.2 and tailwind_cli >=0.5.6 depends on dcli ^1.31.2, every version of tailwind_cli requires dcli ^1.12.4.
(1) So, because dcli >=0.51.0 <2.0.0-beta.13 depends on validators2 ^3.0.0 which depends on vin_decoder ^0.2.0-nullsafety, every version of tailwind_cli requires vin_decoder ^0.2.0-nullsafety.

    Because no versions of vin_decoder match >=0.2.0-nullsafety <0.2.0-nullsafety and vin_decoder >=0.2.0-nullsafety <0.2.1-nullsafety depends on http ^0.13.0, vin_decoder >=0.2.0-nullsafety <0.2.1-nullsafety requires http ^0.13.0.
    And because vin_decoder >=0.2.1-nullsafety depends on http ^0.13.3, vin_decoder >=0.2.0-nullsafety requires http ^0.13.0.
    And because every version of tailwind_cli requires vin_decoder ^0.2.0-nullsafety (1), every version of tailwind_cli requires http ^0.13.0.
    So, because app depends on both http ^1.1.0 and tailwind_cli any, version solving failed.

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.13.9, on Microsoft Windows [Version 10.0.22621.2506], locale he-IL)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.5.5)
[√] Android Studio (version 2022.2)
[√] VS Code (version 1.83.1)
[√] Connected device (4 available)
[√] Network resources

• No issues found!

@thewh1teagle
As i checked by creating a new project and adding tailwind_cli as a dependency i am able to install and use the tailwind_cli package in my project.

And here is my flutter version:

You might getting the error because of some package in your project which is not compatible with tailwind_cli.

@thedevsbuddy 1stly This is an amazing package. I liked this better compared to other ones like velocityx and stilo. Thank you so much for this.
I am also facing similar problem
    Because dcli >=1.5.0 <1.31.3 depends on ffi ^1.1.1 and dcli >=1.30.3 <1.33.2 depends on win32 ^2.6.1, dcli >=1.5.0 <1.33.2 requires ffi ^1.1.1 or win32
      ^2.6.1.
    And because dcli >=1.33.2 <1.35.7 depends on win32 ^2.7.0 and dcli >=1.35.7 <2.0.0-beta.5 depends on win32 ^3.0.0, dcli >=1.5.0 <2.0.0-beta.5 requires
      win32 ^2.6.1 or ^3.0.0 or ffi ^1.1.1.
(1) So, because share_plus >=6.0.0 depends on ffi ^2.0.1 and share_plus >=7.0.1 depends on win32 >=4.0.0 <6.0.0, share_plus >=7.0.1 is incompatible with dcli
      >=1.5.0 <2.0.0-beta.5.

    Because tailwind_cli <0.2.1 depends on dcli ^1.12.4 and tailwind_cli >=0.2.1 <0.5.5 depends on dcli ^1.31.2, tailwind_cli <0.5.5 requires dcli ^1.12.4.
    And because tailwind_cli >=0.5.5 <0.5.6 depends on dcli ^1.36.2 and tailwind_cli >=0.5.6 depends on dcli ^1.31.2, every version of tailwind_cli requires
      dcli ^1.12.4.
    And because share_plus >=7.0.1 is incompatible with dcli >=1.5.0 <2.0.0-beta.5 (1), share_plus >=7.0.1 is incompatible with tailwind_cli.
    So, because zoop depends on both share_plus ^7.2.1 and tailwind_cli any, version solving failed.

I understand share_plus package seems to be causing this issue because of some dependency conflict. But my point is share_plus seems to be a very common package which most of the apps might need.
And I think tailwind_cli should be compatible with it.
From the looks of it, I think if the packages in tailwind_cli are updated, this should fix it. But I can be wrong.
And I dont know if it is supposed to be tailwind_cli responsibility to make sure it is compatible or not. But just brining this to your notice in case if it helps.
Again thank you so much for this wonderful Package. 🎉

@SachinAgarwal1337
Thanks for your feedback about the project.
And i will look into the issue that you are facing i am working on the new version, In new version i am also updating the packages it uses. I think it will solve the issue.

@thedevsbuddy That sounds amazing!!! Looking for for it

@SachinAgarwal1337 Can you please share the Flutter SDK version you are using?

@thedevsbuddy
Flutter 3.16.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 78666c8dc5 (6 days ago) • 2023-12-19 16:14:14 -0800
Engine • revision 3f3e560236
Tools • Dart 3.2.3 • DevTools 2.28.4

@SachinAgarwal1337 Can you please check now as i checked in newly created flutter project it was successfully installed.
$ flutter pub add -d tailwind_cli
Resolving dependencies...
+ archive 3.4.9
+ args 2.4.2
+ chunked_stream 1.4.2
+ circular_buffer 0.11.0
+ completer_ex 4.0.0
+ convert 3.1.1
+ crypto 3.0.3
+ csv 5.1.1
+ dart_console2 3.0.0
+ dcli 3.2.3
+ dcli_core 3.2.3
+ dcli_terminal 0.2.0
+ equatable 2.0.5
+ ffi 2.1.0
+ file 6.1.4 (7.0.0 available)
  flutter_lints 2.0.3 (3.0.1 available)
+ fsm2 3.0.0
+ functional_data 1.1.1
+ glob 2.1.2
+ globbing 1.0.0
+ ini 2.1.0
+ intl 0.18.1 (0.19.0 available)
+ js 0.6.7
+ json2yaml 3.0.1
  lints 2.1.1 (3.0.0 available)
+ lists 1.0.1
+ logger 2.0.2+1
+ logging 1.2.0
  matcher 0.12.16 (0.12.16+1 available)
  material_color_utilities 0.5.0 (0.8.0 available)
  meta 1.10.0 (1.11.0 available)
+ mime 1.0.4
  path 1.8.3 (1.9.0 available)
+ pointycastle 3.7.3
+ posix 6.0.1
+ pub_semver 2.1.4
+ pubspec_lock 3.0.2
+ pubspec_manager 1.0.0-alpha.11
+ scope 4.1.0
+ settings_yaml 7.1.0
+ simple_logger 1.9.0+3
+ sprintf 7.0.0
+ stacktrace_impl 2.3.0
+ strings 2.0.3
+ sum_types 0.3.5
+ synchronized 3.1.0+1
+ system_info2 4.0.0
+ tailwind_cli 0.7.2
  test_api 0.6.1 (0.7.0 available)
+ tree_iterator 3.0.0
+ typed_data 1.3.2
+ unicode 0.3.1
+ uuid 4.2.2 (4.3.1 available)
+ validators2 5.0.0
  web 0.3.0 (0.4.0 available)
+ win32 4.1.4 (5.1.1 available)
+ yaml 3.1.2
Changed 49 dependencies!
12 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.

My flutter version
$ flutter --version
Flutter 3.16.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 9e1c857886 (4 weeks ago) • 2023-11-30 11:51:18 -0600
Engine • revision cf7a9d0800
Tools • Dart 3.2.2 • DevTools 2.28.3

@thedevsbuddy The new version worked like a charm. Thank you so much for quick response and fix.
Although there was this one small issue, not sure if it is from my end.
when I ran flutter pub add dev:tailwind_cli it dint work. It gave me same error.
But when I added the tailwind_cli in pubspec.yaml directly and ran flutter pub get it worked like a charm

@SachinAgarwal1337 Actually it was the issue on both side code in this package was having issue according to new flutter SDK and also the dcli package was outdated.

Fixed with 3c03ce77845e995ba9716883d6afb06bda9849fb commit

@thewh1teagle Thank you. Also I wanted to share a suggestion. Could not find the right place to share this so sharing it here.
It will be best if the package is usable without its core widgets also. Like If I can just get the values by calling methods.
Eg: TwRounded.sm() will return RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(2.0))
or
If it can be used in following way:
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(TwRounded.sm()))
This will make it more robust. And we will be able to set default theme as well


Debugging with VSCODE

I'm trying to use json-translator with a JSON that shows that the process is done, but without any translations. So, I hope to get help with debugging, but I don't have experience with this kind of structure to run and debug the CLI.
Can anyone help me with a launch.json to run TypeScript watch while running it in VS Code for debugging?

Hey @edelciomolina  apologies, completely missed your issue 😲.
Unfortunately, debugging is always a headache on CLI.
There are some helpful commands on makefile to build and run cli on your local machine with using npm link.

windows
mac

You can run these make commands (for ex: make run-cli-mac) and that will build and link cli. Now you are running the cli from your local machine.


SceneInfoUtils pokes every ScriptableObject in project on load, causing Awake to be called

Describe the bug
It seems like a potential editor perf concern that all scriptable objects are loaded any time the asset database is reloaded. It also might cause unexpected behavior, if Awake is expecting to be called when it's actually in a valid use context instead of at database reload.
Microsoft.MixedReality.Toolkit.Input.MixedRealityControllerMappingProfile:Awake() (at Assets/MixedRealityToolkit/Definitions/Devices/MixedRealityControllerMappingProfile.cs:129)
UnityEditor.AssetDatabase:LoadAssetAtPath(String)
Microsoft.MixedReality.Toolkit.Editor.ScriptableObjectExtensions:GetAllInstances() (at Assets/MixedRealityToolkit/Extensions/EditorClassExtensions/ScriptableObjectExtensions.cs:65)
Microsoft.MixedReality.Toolkit.Editor.SceneInfoUtils:RefreshSceneInfoFieldsInScriptableObjects() (at Assets/MixedRealityToolkit/Inspectors/PropertyDrawers/SceneInfoUtils.cs:296)
Microsoft.MixedReality.Toolkit.Editor.SceneInfoUtils:InitializeOnLoad() (at Assets/MixedRealityToolkit/Inspectors/PropertyDrawers/SceneInfoUtils.cs:229)

To reproduce
Steps to reproduce the behavior:

Create a scriptable object that does something noticeable in its Awake
Open your project
View the action / log

Related to https://github.com/microsoft/MixedRealityToolkit-Unity/issues/8188

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


hub compare does not work when head is detached, even if a full range is specified

The following sequence of commands make hub fail:
$ git checkout --detach
HEAD is now at 978a908... <redacted>
$ hub compare release..master
Aborted: not currently on any branch.

This would be understandable if I would have omitted the upper boundary, in which case according to --help the current branch would be used, but I would expect it to work correctly when full ranges are specified.

Thanks for reporting!


DAFT for graphical models

FYI, you might want to consider DAFT for graphical models
http://daft-pgm.org

We looked into it at one point. The problem is that it doesn't currently support automatic layout (see dfm/daft#81).

Looks good, but Graphviz works fine for our purposes. And supports automatic layout. :)


Get exit status from command running on child

Hi there! Thanks for this crate – it's really cool.
I was wondering if there's a way of getting the exit status of whichever command runs on the forked process.
For example, here (from the README):
fn main() {
  let fork = Fork::from_ptmx().unwrap();

  if let Some(mut master) = fork.is_parent().ok() {
    let mut output = String::new();

    match master.read_to_string(&mut output) {
      Ok(_nread) => println!("child tty is: {}", output.trim()),
      Err(e)     => panic!("read error: {}", e),
    }
  }
  else {
    // Child process just exec `tty`
    let cmd  = CString::new("tty").unwrap().as_ptr();
    let args = [cmd, ptr::null()].as_mut_ptr();

    unsafe { libc::execvp(cmd, args) };
  }
}

I'd like the exit status of the tty command that runs on the child. I see that waiting for the fork to exit returns the PID, but not any exit status. Do you think this is possible?

Thinking about this more, I guess it's harder than in Ruby because there is no way to raise/rescue errors in Rust. I had thought about doing something with waitpid and WIFEXITED but it's beyond my systems knowledge really. If anyone wants help investigating that, let me know and I'll do my best. :)


Error occurred during build-start.

Error:
* What went wrong:
Execution failed for task ':newpurpur-server:compileJava'.
> Could not resolve all files for configuration ':newpurpur-server:compileClasspath'.
   > Could not find mapping-io-0.3.0.jar (net.fabricmc:mapping-io:0.3.0).
     Searched in the following locations:
         https://papermc.io/repo/repository/maven-public/net/fabricmc/mapping-io/0.3.0/mapping-io-0.3.0.jar

I'm unable to reproduce this issue.
Send the contents of your build.gradle.kts and settings.gradle.kts files, the issue may originiate from them.

I somehow solved it.


Fix build when FEATURE_WIN32_REGISTRY disabled.

This allows block registry request on Windows for better toolset isolation.

@rainersigwald: I made this change because we wanted to make our build process less dependent on differences of local machine configurations and have it more xcopy-configurable. Thanks to the new msbuild.exe.config toolsets feature, it's now possible to define paths to the tools with global properties, either to the portable locations or to select tools from the local machine. This works, more or less, with the standard .targets files shipped for building C#/XAML/C++/etc, though there're problems with unexpected local machine settings leaking into the build process.
Registry access is one such spot, and the major one. Even Program Files locations lookup often starts with a Registry read. Some .targets would use Registry either as the first chance to look for the tool, or as the last chance if a global property is not set. Either way, this breaks the isolation in a very covert fashion.
So I wished to try the MSBuild conditional compilation symbols for turning off Registry access. This promised to solve the Registry problems. However, the stock implementation which errors on any Registry read proved useless for our scenario — it's not possible to tell the whole lot of the standard .targets files to keep off the Registry (this includes targeting older .NET FX versions and C++ builds ver vc100 and later, not just the latest bits), so no build would ever finish successfully.
But there's the Linux example for which Registry reads would act as if the Registry is empty, and it works pretty good for builds. We wanted to have the same for Windows in this mode — build scripts just think they got only what is defined in the global properties, nothing in the Registry, and that allows for well-isolated builds. We have already successfully used such customized MSBuild packages for our builds.
Are there scenarios for building MSBuild with errors on Registry access? It seems that not many of the standard .targets would be usable that way. Moreover, when we started playing with these conditional compilation flags, the code wouldn't even compile for some of them because the conditioned-out code were out of sync, so I'm not sure they're much used at all.

@rainersigwald defaultValue fixed

@rainersigwald ping

@rainersigwald @AndyGerlicher ping

@rainersigwald @AndyGerlicher any updates about this pull request?
It will be really nice to have it in the master branch. I already checked this PR as a patch locally; everything works great. Do you have any blockers which prevent merging?

@dotnet-bot test this please


Update version to 1.0.79-6 on staging

Update version to 1.0.79-6

🚀 Deployed to staging         in version: 1.0.79-6🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production         in version: 1.0.80-2🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


npm: no such module in node 0.6.5

since i installed node 0.6.5 for mac os x (10.7) i get this npm error:
can't install any package..
markus-imac:Spielwiese markus$ npm --version
node.js:201
throw e; // process.nextTick error, or 'error' event on first tick
^
Error: No such module
at Object. (/usr/lib/node_modules/npm/lib/utils/config-defs.js:5:21)
at Module._compile (module.js:432:26)
at Object..js (module.js:450:10)
at Module.load (module.js:351:31)
at Function._load (module.js:310:12)
at Module.require (module.js:357:17)
at require (module.js:368:17)
at Object. (/usr/lib/node_modules/npm/lib/utils/ini.js:43:18)
at Module._compile (module.js:432:26)
at Object..js (module.js:450:10)
markus-imac:Spielwiese markus$

I have the same, tried installing from macports and the one liner.  If you "sudo npm yada yada yada" it will work for you, milage may vary.

same here

same for me....

me too.

problem solved.
i had an old installation from npm in /usr/bin/
the new nodejs package installs it in /usr/local/bin/
so there was a conflict with the old one...


k_is_in_isr() behaves inconsistently across arches

In the context of fatal error handling, we would like to be able to determine if the kernel was servicing an interrupt or exception (aka interrupt context) when the fatal error occurred.
However, on some arches, if k_is_in_isr() is called from the fatal error handling code, it always returns true. I am seeing consistently on x86_64 and ARC. I see this happening sporadically on xtensa.
k_is_in_isr() is also used in kernel object APIs to detect whether we are currently in IRQ or exception context. In this case, behavior is also inconsistent.
What we need is:

k_is_in_isr() to always return true if we are currently in ISR context, regardless of how we got there (some arches only report it if we are servicing an IRQ and not an exception). The only exception should be when handling a system call, this should still be considered thread context.
Need a new API z_was_in_isr(), only to be called in exception context, to return whether we were in IRQ context when the exception happened, and use that in the fatal error handling logic instead. This should also not return true if we were handling a system call.

Rationale:

Kernel object APIs need to work properly when in IRQ context, including when handling exceptions
Fatal error handling needs to know whether we crashed when handling an interrupt, so this can be clearly communicated to the user, and I think when this happens we should treat it as a kernel panic (i.e. never try to recover from it, instead reboot or shut down)

tests/kernel/fatal should be updated to prove that this works, including a case which triggers an exception during irq_offload().

@andrewboie shall we try to address this for 2.0?

@andrewboie I am trying to solve this for ARM and I 'd like tto double-check with you.

k_is_in_isr() to always return true if we are currently in ISR context, regardless of how we got there (some arches only report it if we are servicing an IRQ and not an exception). The only exception should be when handling a system call, this should still be considered thread context.

System Calls in ARM are executed in thread context. Except for the System-Call-Entry code, that is executed in SVC handler (effectively, that is an exception that elevates privileges and returns to the the system call function). So: what do you want the k_is_in_isr() to return during this SCV handler? I would recommend TRUE

Need a new API z_was_in_isr(), only to be called in exception context, to return whether we were in IRQ context when the exception happened, and use that in the fatal error handling logic instead. This should also not return true if we were handling a system call.

Again, system calls are thread level, so z_was_in_isr will return false except if we are in the SVC handler which is preparing for the system call (system-call-entry code). Is this fine?

@andrewboie

k_is_in_isr() to always return true if we are currently in ISR context, regardless of how we got there (some arches only report it if we are servicing an IRQ and not an exception). The only exception should be when handling a system call, this should still be considered thread context.

Can a system call be invoked inside an ISR handler? If so, and an exception occurs during the call handling, is this an ISR context?

Can a system call be invoked inside an ISR handler?

System calls are only made if a privilege elevation needs to take place, so no.
I think k_is_in_isr() should return true or false depending on whether the current stack pointer falls within the bounds of K_THREAD_STACK_BUFFER(_interrupt_stack).
The check in z_fatal_error() should check if the faulting stack pointer in the ESF is within the interrupt stack buffer.

I think k_is_in_isr() should return true or false depending on whether the current stack pointer falls within the bounds of K_THREAD_STACK_BUFFER(_interrupt_stack).

The check in z_fatal_error() should check if the faulting stack pointer in the ESF is within the interrupt stack buffer.

I think these might be both problematic for ARM @andrewboie , particularly, in case of stack overflows. I believe we need a more reliable way than checking the stack pointer values.

Cross-linking as related: https://github.com/zephyrproject-rtos/zephyr/issues/21923

Removing the stale, once more, I guess we'd like to address this soon (hopefully already for 2.5 and not LTS)

@ioannisg, I assigned this to @dcpleung as one of the common arch collaborators.

@dcpleung - any luck with this one? I wonder if k_is_in_isr() should return true when handling a syscall. If so, it might be possible to construct a test case that defines a custom __syscall.

@nashif do we still want this in v2.7?


WIP Reduce the number of intra modes searched for chroma

Limit the intra modes searched for chroma to the colocated luma
mode plus the DC mode if different from the first mode

Related to the goal of this patch (i.e. improving speed), I again figure out that if more than one chroma intra modes are tested as previously, luma prediction in encode_block_b() is called duplicated among different chroma intra modes though luma work as context for chroma?

@ycho Yes, I recently opened #463 on this topic

At default speed setting (3):

PSNR
PSNR Cb
PSNR Cr
PSNR HVS
SSIM
MS SSIM
CIEDE 2000

-0.5450
1.1756
1.2647
-0.7288
-0.4745
-0.5919
-0.0551

Runs about 40% at default speed setting

That's nice speed up. Also, I am sure that improving Y psnr while losing small in UV will be much appreciated by @tterribe.


Footer breaking in Ipad (potrait) & Iphone X/XS (landscape)

Describe the bug
Refer screenshot
Screenshots
If applicable, add screenshots to help explain your problem.

Are you working on this issue? (Yes/No)
No

Similar to #1019 . I am working on it to get it fixed soon .

This can be closed @tachyons


[PID] sanitize gains

ran into division by zero in numpy_fast.py in selfdrive:process-replay
it was empty lists from the capnp list builder being passed into the pid controller for the gains.
for me it happened because I had a kd term and the toyota interface calls a tune list that invokes the lateraltuning.init() function clearing the values from cars/interfaces.py.
Although I'm not sure what changed since I last updated that caused this since it looks like the toyota stuff was there on by branch before I updated.
if you were to exclude BP's or V's for Ki / Kp from the interface for a vehicle it would crash here as well.
I'm inclined to say "who cares" but I see some sanitation was getting added here for passing values in the wrong format already so I moved it to a dedicated function and added sanitation for missing BP's or excluded gains.

Don't think we should solve this in the PID controller. If this is an issue we should enforce the values are set to something sane here: https://github.com/commaai/openpilot/blob/master/selfdrive/test/test_models.py#L111

Agreed, I was curious why we had some input sanitation merged here


nbconvert to html does not export widgets with hvplot - does with holovies

a holomap widget will be exported  with nbconvert into the static html if I use a holoviews dataset
ds with kdims ["x", "a"] and vdims ["y"]
and then ds.to(hv.curve, "x").
If I use an xarray y with dims ["x","a"] then y.hvplot(groupby="a") is plotted in the notebook succesfully, but not if I nbconvert to html.
versions:
hvplot 0.2.1
holoviews 1.10.7
xarray 0.10.7
pdf has minimal working example
Untitled.pdf

I should have noticed, y.hvplot(groupby="a") returns a DynamicMap instead. Not a holomap as ds.to(hv.Curve, "x")

You can pass in dynamic=False to get a HoloMap.

OK, I found from the online examples the y.hvplot(groupby="a", dynamic=False) that returns a holomap.
This is not a bug. More about my impatience.

Yes, thanks!

However, when we try to use the hvplot interactive plot in a panel e.g. pn.Row(df.hvplot(x,groupby='A'))) and export it as html_embd. In the HTML file, the interactive is not working. Any thoughts?


[vue3] Props type inference breaks, if custom-validator is present

Version
3.0.4
Reproduction link
https://github.com/MarcRoemmelt/vue-lost-proptypes
Steps to reproduce

Clone project
Install dependencies
Check App.vue intellisense for props-typings in setup(props) or this.$props

What is expected?
Type inference for all props should work regardless of custom-validator
What is actually happening?
If a validator function is present in any prop, the type inference breaks. Interestingly,  if the validator is an arrow-function without parameters it it works.

This is a known issue and is a limitation of TypeScript handling circular inference of ThisType (which is only present if using a non-arrow function).
There is currently no fix for this (will have to be upstream in TS) so using arrow function is the recommended workaround.


Allow disabling preprod snapshots

When the voting node is run without the TESTNET_DBSYNC_URL present, the main thread continually throws an exception:
{"timestamp":<PHONE_NUMBER>.262538, "level": "INFO", "message": "Taking snapshot now", "source": "/usr/local/lib/python3.11/site-packages/voting_node/importer.py:201", "extra": {}}
{"timestamp":<PHONE_NUMBER>.262832, "level": "DEBUG", "message": "|---> Starting DBSync snapshot now", "source": "/usr/local/lib/python3.11/site-packages/voting_node/importer.py:202", "extra": {}}
{"timestamp":<PHONE_NUMBER>.263015, "level": "INFO", "message": "Importing snapshot data for event 11", "source": "/usr/local/lib/python3.11/site-packages/voting_node/importer.py:113", "extra": {}}
{"timestamp":<PHONE_NUMBER>.263169, "level": "WARNING", "message": "X-> RESET: 'TESTNET_DBSYNC_URL'", "source": "/usr/local/lib/python3.11/site-packages/voting_node/service.py:71", "extra": {}}
{"timestamp":<PHONE_NUMBER>.264446, "level": "INFO", "message": "SCHEDULE RESTART", "source": "/usr/local/lib/python3.11/site-packages/voting_node/tasks.py:137", "extra": {}}
{"timestamp":<PHONE_NUMBER>.264759, "level": "INFO", "message": ">> TASK event_snapshot_period", "source": "/usr/local/lib/python3.11/site-packages/voting_node/tasks.py:148", "extra": {}}
{"timestamp":<PHONE_NUMBER>.264874, "level": "DEBUG", "message": "| event_snapshot_period START", "source": "/usr/local/lib/python3.11/site-packages/voting_node/tasks.py:149", "extra": {}}
{"timestamp":<PHONE_NUMBER>.265124, "level": "INFO", "message": "Execute snapshot runner for event in row 11.", "source": "/usr/local/lib/python3.11/site-packages/voting_node/tasks.py:472", "extra": {"event_id": 11}}

We need to be able to disable preprod snapshots and only run mainnet snapshots for the prod deployment.

The snapshot importer uses the env var SNAPSHOT_NETWORK_IDS to list the networks from which to import data. Removing the preprod network there should be sufficient for the importer to only run on mainnet.


something discuss for the results

First, thanks for your amazing work.
# Copy samples
copy_any(path/f'original/{case}/train/good', case_folder/'train')
copy_any(path/f'original/{case}/test/{sub}', case_folder/'train')
copy_any(path/f'original/{case}/test/good', case_folder/'test')

for the line50: https://github.com/daisukelab/metric_learning/blob/master/mvtecad_test.py#L50
copy_any(path/f'original/{case}/test/{sub}', case_folder/'train')

which means the training data also appeared in the test set, and I double-checked the images:

so I think the result of self-supervised is not correct.

Hello @BIGBALLON, thanks for feedback. It would look like data leakage, I'm sorry for confusing design.
First, I show that self-supervised sub-test uses only good samples for training by the code below:
    if subtest_type == 'self_supervised':
        data = artificial_image_list_cls.databunch(path/f'{subcase}/train/good',
                                                   size=img_size, tfms=tfms)

You can find it at mvtecad_test.py#L50.
And you can confirm by running followings in the notebook:
mvtecad.set_test(0, 0)
db = mvtecad.databunch()
db.train_ds.items

Output will be like:
array(['/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/173.png',
       '/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/173.png',
       '/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/139.png',
       '/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/139.png', ...,
       '/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/041.png',
       '/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/041.png',
       '/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/039.png',
       '/mnt/dataset/mvtec_ad/case0-0-bottle-broken_large/train/good/039.png'], dtype='<U69')

I guess it would be clear for you now:

Yes everything is copied to sub-case folders.
But what is used for training is selected when creating databunch.

I hope this answers your question, please feel free to ask anything unclear. :)

@daisukelab  thanks for your answer, I get it now.


Help wanted packaging for Linux distributions

Help wanted packaging for Linux distributions. https://repology.org/project/git-credential-oauth

@shyim yes please. I started at https://github.com/NixOS/nixpkgs/pull/235073

https://github.com/NixOS/nixpkgs/pull/235464

Do you maybe want to link:
[![Packaging status](https://repology.org/badge/vertical-allrepos/git-credential-oauth.svg)](https://repology.org/project/git-credential-oauth/versions)

in the readme?

Good idea, done. https://github.com/hickford/git-credential-oauth/commit/a7fd2a4c2121b96fb218e3ebdc9c16a991b90048

Void Linux https://github.com/void-linux/void-packages/pull/44237

Are there any plans to publish packages to EPEL so git-credential-oauth can be installed conveniently on RHEL and its rebuilds? I noticed that a SPEC file is there already, but probably not hooked up to produce and publish RPMs.
I recently attempted to build that SPEC and had no luck on RHEL 9.4 due to issues in the RPM Go infrastructure. Those seem to have been fixed as of RHEL 9.5, however, and the SPEC file now builds successfully (with some small modifications to bring it in line with the SPEC files for more recent versions of git-credential-oauth in Fedora).

@bsteinb I'd like to but I don't have the necessary app fedpkg installed. Can you help?

https://src.fedoraproject.org/rpms/git-credential-oauth and https://src.fedoraproject.org/rpms/golang-x-oauth2
https://fedoraproject.org/wiki/SIGs/Go
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Update_Guide/
https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/

No, sorry. The fedpkg tool itself seems to only be a dnf install away, but that looks like the smallest step in becoming a package maintainer. Skimming the pages you linked it also involves getting multiple accounts to various services, signing up to mailing lists and introducing oneself to the packager community, getting sponsored, reading a bunch of guidelines, etc.


Dataset for 10 day forecast

Hi there,
I'm trying to run GraphCast for the 10 day forecast like it was done in the paper. Unless I'm mistaken the example data that was provided in the Google Cloud Bucket only datasets for up to 3 days. Where can I find the dataset that was used for the 10 day run?

Hi, thanks for your reply.
Those inputs are only provided as dataset samples to replicate training in the paper which only goes to 3 days.
For producing 10 day forecasts, I would recommend to obtain data directly from ERA5, which you may be able to obtain via WeatherBench2.
Hope this helps!


Getting started: low contrast for activity bar image

Refs: https://github.com/microsoft/vscode/issues/117313
Notice how the picture shows the activity bar, but due to low contrast it is impossible to see it

New SVG is used instead now.


Where to report issues about very slow plugin downloads?

It seems like trunk upgrade -v is very very slow here.

I've tested it much longer as well.
Anyone can help with that?
Infos about my system:
OS: Manjaro Linux Sway Edition
CPU:  AMD Ryzen 9 5900X 12-Core Processor
RAM: 48093 MiB

Works on my ArchLinux box as intended.

Hi @jochumdev! Sorry you're having this issue. This is definitely a good place to report this, although it may be easier to join our Slack channel.
Just to clarify, is it usually the prettier install that takes a long time? Is it always prettier or sometimes other tools?
If you could provide 2 other things, it would help us investigate:

Your .trunk/trunk.yaml file
After enabling a new version of prettier, run trunk check --debug and grab the full log output. Feel free to upload as a gist or via DM in Slack.

Hey @TylerJang27 thanks for answering. I found the root cause. It was half working IPv6. Once I disabled IPv6 on my link everything worked as intended.
So with broken IPv6 trunk doesn't work as intended.

Thanks for investigating. We'll take a closer look and get to the bottom of this

Could you try setting:
export NODE_OPTIONS=--dns-result-order=ipv4first

Then running:
trunk daemon shutdown
# if necessary, clear ~/.cache/trunk/tools
trunk check

It appears this issue can result from certain misconfiguration of IPv6 and the npm package registry. We'll look into documenting this appropriately.


Consolidate category/product page functions

Right now, each category has its own function; a second function is also present for category/product. This results in 6 total functions, to perform 2 tasks. Reduce this into 2 functions, using dynamic category matching.

Addressed in push https://github.com/Matthew-OCM/Canbotics-Smithy/commit/4b3fd8a0c8c47c290d78ce64ff4e3b7375758486.


Update ProtocolServer's exceptions to be more specific

Within ProtocolServer inside dataloader2/communication/protocol.py, the exceptions being raised inside are generic Exception. Ideally, we should change the exceptions to be more specific, such that they can be handled easily elsewhere.
cc: @ejguan

Yeah. This is going to be important for us to differentiate the source of Error from next(dp_iter) or Error related to Request/Response


No destroy/teardown/cleanup function for single-page apps

When using frameworks for single-page apps like emberjs, we need the ability to destroy the plugin when leaving the view due to memory leaks.

+1

+1


⚠ Fortnite has degraded performance

In 1f58082, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1610 ms

Resolved: Fortnite performance has improved in e58d5dd.


invite request form

Do you guys have a public invite request form, like slackin?
The only place I could find to request an invite was at http://slackchats.hellobox.co/za-developers/2014-12-18, but with only a few requests I'm unsure of its activity.

Hi Larry, we don't have a slackin form. We decided to stick to invite only, and direct messages on Twitter, to keep recruiters out.
I'll get your invite processed, and will chat to @gee-forr about the hellobox site so we can process those requests in a timely manner.
Thanks!

awesome, thanks :)


Feature add variant type

Proposed changes

add proto and thrift definition
add type desc in FE and BE

Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


adding exporter test

fixes #777

scrape.go:56: Unexpected call to *mocks.MockResultCollector.GetResultList([{0xc0003d06e0 0xc0003d0790 <nil>}  0xc000014140]) at /home/ibuntu/go/src/github.com/Its-Maniaco/chaos-exporter/controller/scrape.go:56 because: there are no expected calls of the method "GetResultList" for that receiver
How should I proceed from here?

Hey @Its-Maniaco, the unit test has already been addressed through this PR.
Thanks for the contribution :)


Release a new version with GitHub Actions

Motivation:
If releases are performed through an automated task, mistakes can be reduced and more validation can be added.
Modifications:

Add tag-new-release.yml to tag a new version with GitHub Actions dispatch UI.

Result:
Automated release process

Give credit to @AmosDoan since the workflow was inspired by his work at LINE.

The job was tested at the forked repo.

https://github.com/ikhoon/armeria/actions/runs/6653695760

Thanks for the quick review. 🙇♂🙇♂

The job failed because gpgconf wasn't installed on self-hosted runners.
Unable to locate executable file: gpgconf. ...

gnupg2-full has been installed to install gpgconf.
$ sudo dnf install --allowerasing gnupg2-full


Incorrect Link

The Code42 hyperlink in the first paragraph leads to https://www.crashplan.com/. It should take users to https://www.code42.com as crashplan.com points at their small business homepage which doesn't support Scim.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aff0b40a-c77d-36ba-9a65-2bef5483a4b1
Version Independent ID: 29fc7788-91ca-6bfb-e491-9cbcea25e505
Content: Tutorial: Configure Code42 for automatic user provisioning with Azure Active Directory
Content Source: articles/active-directory/saas-apps/code42-provisioning-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @twimmers
Microsoft Alias: thwimmer

@brandonternes
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Thanks @brandonternes for the feedback. I have made a doc change to address this issue. The change should be live by 10/17.
#please-close


Fix bug of argument of type "NoneType" is not iterable detected on Windows

This PR addresses issue inductiva/tasks#144 where Windows machines were not being able to terminate their resources or kill their tasks from the CLI.
This bug arises from the usage of the localization module only on the CLI and just being prompted in Windows machines.
The reason was that when translations had a None value, we were still checking if a key was inside a NoneType.
Apparently, if I understood correctly, Windows doesn't handle this cases properly and throws the error to the user. At least according to this: https://stackoverflow.com/questions/6762446/typeerror-argument-of-type-nonetype-is-not-iterable-in-python.
Check first if it is None fixes the bug.

Do we have a QA procedure for windows?


Inconsistent language system tag names for 'NSO ' and 'SOT '

It would be nice if, for consistency with other language systems’ names, 'NSO ' and 'SOT ' were “Northern Sotho” and “Southern Sotho” instead of “Sotho, Northern” and “Sotho, Southern”.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 662c6f54-f90c-52ed-dca2-0f0a0a49fee5
Version Independent ID: 6aa33924-d45e-60c3-a9fd-e317ff662993
Content: Language system tags - Typography
Content Source: typographydocs/opentype/spec/languagetags.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: PeterCon

Changed for next version.


Send event infos to HA

Hello
Does anyone thought of using events detected by the ESP's application to propagate them to HA (send cover ID + remote ID + key ID) ?
For example, it could be used as a trigger in an automation: kind of human overlap/bypass.
Regards

There are a full set of services in the integration for control.  I haven't messed around with the events but they are all the ones that are available to the cover domain.

Hello,
Normally, HA manages the shutter's position (heatwave, heliotropy, open in the morning, close in the evening). There are even a few comfort options for watching TV: in short, everything in automatic mode.
Now that the position of the shutters is always synchronized with the actual position (which wasn't the case with my rfxcom box), I'm very happy.
I'm now thinking of disabling automatic management of individually shutters, when the user has changed their position using the physical remote control (the others would still be managed in automatic mode). To do this, I'd need to be able to tell the difference between :

pressing the physical remote control
a call via the api

When it's a call via the api, it means HA is managing the shutters. When it's a call via the remote control, there's human intervention and so HA deactivates automatizations for this shutter.
Additionnaly, I'd need to know the identity of the shutter and, optionnaly, the command sent (up/my/down).
A simple json (which would simply be converted into an HA sensor, with attributes) like :
{
state:"remote",
"remote_id": "1234ABCD",
"event_key": "up",
"timestamp":<PHONE_NUMBER>
}
or
{
state:"api",
"remote_id": "5678ABCD",
"event_key": "my",
"timestamp":<PHONE_NUMBER>
}
Do you see what i'm mean ?
Regards

ESPSomfy RTS knows whether it triggered the movement or something else triggered its movement.
How do you want to pull this information?  Would attributes on the HASS entity give you the function you need?  That way you would not need to have a bunch of sensors floating around and it would get tagged specifically to the target entity.  It could then also be in sync with the internal HASS clock.  I suspect that would also make the automation as simple as looking at the attribute on the entity.

There may also be some weirdness with the my command.  This is because my is also stop but I do know whether the my actually performed movement or simply stopped the motor at a position.  Most of the time the actionable key is actually a stop command being issued but perhaps I can set this to only commands that created movement.

In addition to the state data that I have added to the entities, I will also forward the events to the hass event bus.  I just need to figure out what to send.  At a minimum I think I can send the event structure you have above.

Sorry for my late reply. I'll look at the version 2.0.1 and will report ASAP.
I think you last comment is quitte i have in mind. No need to have 1 sensor for 1 cover. Just 1 sensor is enough, and updated with the latest event informations

Wonderfull !
Here is test automation
alias: espsomfy-rts_event
description: ""
trigger:
  - platform: event
    event_type: espsomfy-rts_event
    event_data:
      source: remote
condition: []
action:
  - service: notify.notify
    data:
      title: "{{ trigger.event.data.event_key }}"
      message: >-
        Cover {{ trigger.event.data.name }} with ID {{
        trigger.event.data.entity_id }} received command {{
        trigger.event.data.command }}
mode: single

IMO issue can be closed, as feature is working perfectly.
Many thanks !!!!

You are welcome.  Closing issue.


disable weekends from the calendar

how can I disable certain days in the calendar?  As an example, i want to disable all the weekends.
here is my code
<input time="false" date="true" mdc-datetime-picker type="text" id="date" placeholder="Date" ng-model="date" min-date="minDate" max-date="maxDate" disable-dates="dates">

Current implementation is for specific date object in an array:
 $scope.dates = [new Date('2016-11-14T00:00:00'), new Date('2016-11-15T00:00:00'),
        new Date('2016-11-30T00:00:00'), new Date('2016-12-12T00:00:00'), new Date('2016-12-13T00:00:00'),
        new Date('2016-12-31T00:00:00')];

One can use the following npm datetimepicker for disabling all weekend:
https://www.npmjs.com/package/extended-datetimepicker

Now you can with this release:
https://github.com/beenote/angular-material-datetimepicker/releases/tag/v1.7.2


Fix broken link in docs

I don't know the past page but I guess this is it...

[x] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Thanks! Sorry for the long delay.  Looks like we got this in https://github.com/sghall/react-move/pull/72


LiT and Pool CLI update to v0.5.0 testing sidecar channels

This CLI release is the first to test sidecar channels.
LiT will be uninstalled (with the data preserved) if installing the Pool CLI to avoid interference with the accounts.
(careful here and please report problems with using the accounts with Pool CLI and LiT interchangeably)
Sidecar channels documentation: https://github.com/lightninglabs/pool/blob/master/docs/sidecar_channels.md
Quickest way to test:
# download the update Pool install script
wget https://raw.githubusercontent.com/openoms/raspiblitz/pool-v0.5.0/home.admin/config.scripts/bonus.pool.sh -O /home/admin/config.scripts/bonus.pool.sh
# download the updated LiT install script
wget https://raw.githubusercontent.com/openoms/raspiblitz/pool-v0.5.0/home.admin/config.scripts/bonus.lit.sh -O /home/admin/config.scripts/bonus.lit.sh
# inspect
cat /home/admin/config.scripts/bonus.pool.sh
# run
/home/admin/config.scripts/bonus.pool.sh on

Merged https://github.com/rootzoll/raspiblitz/pull/2276 to make sure to avoid https://github.com/rootzoll/raspiblitz/issues/2266#issuecomment-831411475 on Pool uninstall.
Also using the updated LiT install script.

Do you want to merge this directly into the v1.7 or into dev first?

I think these fixes should be in the RC1 so whichever get used for that. Will be  the dev I presume?

Could go to pre-1.7.1 as well or is the plan to merge it all to dev?

Best would be to merge into dev which will be the branch the RC1 will be based on.

OK ready to merge after rebase


internal server error 500

server return an error regarding the query from the database
Error: error running query,Error: getaddrinfo ENOTFOUND,SELECT ST_AsGeoJSON(geom) as the_geom_geojson FROM kenya_coverage WHERE ST_Intersects(geom, ST_Transform(ST_SetSRID(ST_MakeBox2D(ST_MakePoint(-10801469.341034826, 3757032.814272983), ST_MakePoint(-10723197.824070806, 3835304.331237002)), 3857), 4326)),
this is the query statement i used based on the example provided
'SELECT ST_AsGeoJSON(geom) as the_geom_geojson FROM kenya_coverage WHERE ST_Intersects(geom, !bbox_4326!)

Looks like it's failing to connect to your database server. Can you share the javascript code you're using to set up Tilesplash?


matrix: remove BspSet dev docs (code already removed)

When removing unused the BspSet and ProductSet data structures, I missed some developer notes hiding in the benchmark directory.

Thanks, @tylerbutler !


Terrible lag in large communities

Filtering and initial renders seem to be basically lethal in communities with hundreds of users.

Obsolete as of ExtPlug/ExtPlug@26c3afe.


Billing open and paid notifications

Approved. But still a few minor comments.

ut tests are failing but for some permission issues (403 errors) whcih are not related to this PR.


new function to add problem properties using strings

update!(body.properties, "finite_strain" => "false", "geometric_stiffness" => "false")

and so on.

Coverage decreased (-0.07%) to 90.337% when pulling 0d88392e7bee2edb978c31c152ee9761396bfbde on update_properties into 5731d590abd16c50a87ac3a6d6ae31058d01936f on master.

Coverage increased (+0.008%) to 90.415% when pulling ec07210aaafe66e58a5aec2770415b4518fcb4c2 on update_properties into 5731d590abd16c50a87ac3a6d6ae31058d01936f on master.


Upgraded to Vaadin 8 and pom cleanup

The only neccesary changes for a Vaadin 8 version, and a little pom cleanup #48

Hi @chrosim, we forked the repo for further development here: https://github.com/parttio/Google-Maps-for-Vaadin
Please submit your PR there as well.
Thanks!

Thank you, @hezamu!
I'M FREE!

You're welcome @thinwire :)

@hezamu Done :)


Fixed up things caught by linter

Fixed up all errors reported by linter. Also, linter only reports 6 warnings (all about console.log usage) now.

this is fine, but let's just keep this open to debug the cypress test run on circle ci which is currently hanging: see #66


Invalid argument crash in IE11 & Edge

Description
There is an Invalid argument crash in IE11 & Edge that causes a dialog not to appear and on IE11 seems to cause CSS problems.

Live Demo
Visit this website with Edge or IE11 https://yrpri.org/
Steps to Reproduce
Not known, only happens in IE11 or Edge
Expected Results
No crash should happen
Actual Results
Invalid argument error
Browsers Affected

[ ] Chrome
[ ] Firefox
[X] Edge
[ ] Safari 9
[ ] Safari 8
[x] IE 11

Versions

Polymer: v2.6
webcomponents: v1.2.0

It would be great if you could create a minimal reproducible case. That would significantly ease our debugging process :smile:

Sure, but then I would most likely also find the cause of the problem myself ;) I will continue to debugging this but creating minimal reproducible cases are hard from big apps. In the meantime if anybody has any hints then that would be great!

I have tracked it down to my new and edit dialogs for example to create and edit communities. They work without an error when I add a new community but get this error when I edit the community with the same dialog so must have something to do with data bindings. Here is an example of a dialog that is broken. https://github.com/CitizensFoundation/your-priorities-app/blob/master/client_app/src/yp-community/yp-community-edit.html

Another clue is that if I first fire up the dialog in new mode and then I use it in edit mode then the error does not happen. This is especially strange as yesterday I wrapped all our dialogs in dom-if restamp so they would only be a part of the dom when being used.

@TimvdLippe I tracked it down and its fixed! Turns out that this was really an invalid argument in IE11. I was trying to set method to PUT on an native form element. I have my own version of iron-form that uses PUT for my restful APIs and I accidentally had added this parameter also to the native form in the new Polymer 2 iron-form setup. Thanks again for all your help.

Glad to hear it is not an issue with polymer or the polyfill :)


How do we customize?

Can you give some more info about customization? I write /crap and it opens a preview of a full raid but I cant figure out how to move it or do any adjustments at all.
Thanks

You should see the available customization options printed in the chat after typing /crap. To move around just drag with the mouse, hold shift to resize.


Fix uneven-indent rule reporting last comment with invalid indent

Fixes #675

Codecov Report
Base: 96.92% // Head: 96.92% // No change to project coverage :thumbsup:

Coverage data is based on head (2a4c1a2) compared to base (f60596b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   96.92%   96.92%
=======================================
  Files          24       24
  Lines        3089     3089
=======================================
  Hits         2994     2994
  Misses         95       95

Impacted Files
Coverage Δ

robocop/checkers/spacing.py
99.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Associated detectors flyout through UI actions

Description
This change adds the associated detectors flyout as part of the feature-anywhere project. This flyout allows you to view all the detectors associated with a particular visualization. From the flyout a user can unlink a detector from a visualization or search up their associated detectors and click on it to view the detector details on the AD plugin.
In this PR the "Associate Detector" button doesn't do anything, the reason for this is that it relies on some other changes in the CreateAnomalyDetector flyout that aren't merged yet. I will add this functionality on another PR.
This code also might have some build failures because it relies on files such as public/action/ad_dashboard_action.tsx to run correctly. The reason this file as well as some of the CreateAnomalyDetector files aren't included is because it will be merged first by Jackie's PR.
This PR also requires additional testing that I will be adding.
Screenshot of flyout:

Issues Resolved
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #449 (353a720) into featureAnywhere (23c8142) will decrease coverage by 1.39%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@                 Coverage Diff                 @@
##           featureAnywhere     #449      +/-   ##
===================================================
- Coverage            51.59%   50.20%   -1.39%
===================================================
  Files                  152      159       +7
  Lines                 5080     5254     +174
  Branches               978      999      +21
===================================================
+ Hits                  2621     2638      +17
- Misses                2200     2357     +157
  Partials               259      259

see 9 files with indirect coverage changes

LGTM! Will wait to fully approve when rebased after #482 is merged first.

Cool, this lgtm. Won't approve until dependent PRs merged


CryptoProviderFactory.Create methods should throw consistent exceptions when algorithm is not supported

When an algorithm is not supported:
CreateHashAlgorithm, CreateKeyedHashAlgorithm throw InvalidOperationException
CreateSignatureProvider, CreateKeyWrapProvider throw ArgumentException
In all cases we should throw:
InvalidOperationException when the CustomCryptoProvider returns an invalid type after indicating support
NotSupportedException when our default runtime does not support the algorithm

@lovemaths lets wait until after we merge WsFed to fix this.

https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/638


open modal to enable the reactive account option when user is logging in

Solve by https://github.com/eoscostarica/lifebank/pull/817


Recipient groups: Filtering fails for SBL fields

When an SBL field is used to filter a section, preview breaks with a Symphony Fatal Database Error:
Unknown column 't333_1.value' in 'where clause'
An error occurred while attempting to execute the following query
SELECT SQL_CACHE `e`.id, `e`.section_id, e.`author_id`, UNIX_TIMESTAMP(e.`creation_date`) AS `creation_date` FROM `sym_entries` AS `e` LEFT JOIN `sym_entries_data_333` AS t333_1 ON (e.id = t333_1.entry_id) LEFT JOIN sym_entries_data_170 AS `d` ON `e`.`id` = `d`.`entry_id`LEFT OUTER JOIN `sym_entries_data_168` AS `ed` ON (`e`.`id` = `ed`.`entry_id`) WHERE 1 AND `e`.`section_id` = '27' AND t333_1.value IN ('4009') AND `d`.`value` IS NOT NULL GROUP BY `d`.`value` ORDER BY `ed`.`value` asc LIMIT 0, 17

Using "value" on an SBL table can not work, since SBL has a relation_id column instead.

Found the problem. Indeed it's in the SBL field which still uses the typo'd function name buildDSRetrivalSQL, which has been changed to buildDSRetrievalSQL a while ago. (Do you remember? The old function name is mapped to the new one in class.field.php.)
I fixed the function name in the SBL field. Should I send a pull request? I am not sure about side effects and compatibility problems. (The implications of the changed function name are a bvit over my head at the moment.)
Hell, I noticed that many extensions still use the old (deprecated) function name. That makes my head spin.
What can we do here?


The property ContentMD5 allows to edit

Storage Explorer Version: 1.11.0
Build: 20191106.4
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 19.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one Non-ADLS Gen2 storage account -> Blob Containers.
Select one blob container which contains blobs.
Select one blob then open its Properities dialog.
Check the ContentMD5 textbox.

Expect Experience:
It doesn't allow to edit.
Actual Experience:
It allows to edit.

More Info:

This issue doesn't reproduce for one HNS blob.
This issue reproduces for files under one file share.

@MRayermannMSFT Is this field supposed to be editable? For HNS enabled accounts, the SDK returns a Uint8Array, which is decoded from the base-64 encoded string retrieved from Azure. Because of that, I disabled being able to edit it. I don't think we should be letting users edit the MD5 hash for regular blobs either...at least until we have a better scenario planned out?

I'm fine either way.

Let's make it read only for now and figure out a better experience around editing sensitive properties. And if people need it to be writable earlier than that, then we can just ship undoing making it read only.

Merged with commit 5ff2fb66.


Name Alignment and Mainstem Discovery Order

Goal
The aim of the PR is to help users find the n number of upstream and down stream segments from an input COMID. It does this by ordering the returned integer vector from get_UM and get_DM by Pathlength.
It also adds a function to align other NHD datasources to the naming convenctions of nhdplusTools:
The end results is a work flow like this:
# External Data source downloaded from CIDA server
cida = sf::read_sf(system.file("extdata", "cida_flowlines.gpkg", package = "nhdplusTools"))

# Align attribute names to package conventions with new function:
network = cida %>% align_nhdplus_names()

# Isolate random COMID
comid <-  network$COMID[33]

# Trace
UM_COMIDS = get_UM(network, comid)

DM_COMIDS = get_DM(network, comid)

# plot by element distance
gifski::save_gif({
  for(t in 1:length(DM_COMIDS)) {
    plot(network$geom, col = 'gray', lwd = network$StreamOrde)
    plot(network$geom[network$COMID %in% comid], col = "red", lwd = 2, add = T)
    plot(network$geom[network$COMID %in% UM_COMIDS[1:min(floor(t/2), length(UM_COMIDS))]], col = "darkgreen", lwd = 3, add = T)
    plot(network$geom[network$COMID %in% DM_COMIDS[1:t]], col = "blue", lwd = 3, add = T)
}}, gif_file = "./upstream.gif", width = 800, height = 600, delay = .25, loop = TRUE)

Notes
- All tests run as expected
- Package builds on Travis

Additions:
- a new vector called ‘good_names’  has been added to nhdplusTools.R (names taken directly from petapsco_flowlines.gpkg)

- a new function called `align_nhdplus_names` has been added to `nhdTools.R`.

- a new dataset, from the CIDA server has been added to './extdata/cida_flowlines.gpkg'

- a new test set has been added under tests (`test_align_nhdplus_names.R`)

Changes
- `get_UM` and `get DM` have been changed to retuned COMIDs in order based on Pathlength from the input COMID

- A filter has been added to `get_UM` and `get_DM` to exclude the input COMID from the returned set

- All tests have been changed to expect a result length of n-1 due to the dropping of the input COMID

👍 Thanks @mikejohnson51
See comments in line. I'm generally supportive of the addition of upstream/downstream ordering.

Can you add an input, sort that defaults to FALSE that allows bypassing the sort? These navigations can get huge and I want to make sure these functions stay as lean as possible using default.
I'd prefer having the navigation be inclusive of the starting catchment. If you have a strong argument against it, I'm happy to entertain.
I think we can get upstream / downstream sorting as you desire using hydrosequence, right? That would improve memory use of the functions and eliminate the requirement of pathlength. I say this because I want these functions to work with the lowest common denominator and hydrosequence can be calculated for any dataset using nhdplusTools functions.
I like the names alignment function. I think I'll just merge that in as is, but I want to see how it aligns with the renaming I'm doing for NHDPlus HiRes. This is the list of currently used attributes: https://github.com/USGS-R/nhdplusTools/blob/master/R/nhdplusTools.R#L35 and their NHDPlusHiRes counterparts.

Update

sort and inlcude are now parameters in get_UM and get_DM
test have been implemented for both
Hydroseq vs Pathlength is now the sort parameter! Didnt even think about that...
the 'good_names' vector is now built within the align_nhdplus_names function and is generated from the nhdplus_attributes list.

The resulting workflow can now be:
# External Data source downloaded from CIDA server
cida = sf::read_sf(system.file("extdata", "cida_flowlines.gpkg", package = "nhdplusTools"))

# Align attribute names to package conventions with new function:
network = cida %>% align_nhdplus_names()

# Isolate random COMID
comid <-  network$COMID[33]

make_gif = function(network, comid, UM, DM, path, name){

  gifski::save_gif({
    for(t in 1:length(DM)) {
      plot(network$geom, col = 'gray', lwd = network$StreamOrde)
      plot(network$geom[network$COMID %in% comid], col = "red", lwd = 2, add = T)
      plot(network$geom[network$COMID %in% UM[1:min(floor(t/2), length(UM))]], col = "darkgreen", lwd = 3, add = T)
      plot(network$geom[network$COMID %in% DM[1:t]], col = "blue", lwd = 3, add = T)
    }}, gif_file = paste0(path, name,".gif"), width = 800, height = 600, delay = .1, loop = TRUE)
}

# Trace
UM_unsort = get_UM(network, comid, sort = F, include = F)
DM_unsort = get_DM(network, comid, sort = F, include = F)
make_gif(network, comid, UM_unsort, DM_unsort, "./", "no_sort")

UM_sort = get_UM(network, comid, sort = T, include = F)
DM_sort = get_DM(network, comid, sort = T, include = F)
make_gif(network, comid, UM_sort, DM_sort, "./", "sort")

Great work @mikejohnson51 !! Thanks for this.


[Suggestion] Building Skill

This has probably been suggested in the past but I thought I'd mention it anyway.
New Skill - Building
Experience earned from placing certain blocks such as planks and bricks, they'd have to be very low amounts of xp, but would be a cool new skill to have.

Thanks for the suggestion.  Ill most likely implement this somewhere in the next week or 2.

what purpose could this skill have? after all it shouldn't just be a counter of how many blocks you placed.
the only not out of place yet useful thing i can think of right now, would be something like an ability to harden all blocks you place while your ability is active (maybe a couple of minutes time, or the ability could be limited by the amount of blocks you place and not time.)
those hardened blocks could then take longer to break by players. this would however require that everytime such a hardened block is set, the plugin has to remember it and i'm not sure if there's any good way for checking for hardened blocks without having the plugin check every block that gets broken..

I can't help but agree with @KevinAT here. What purpose does this serve? Just a counter how much you actually build? XD
An alternative, would to turn this into a "crafting" skill. Where crafting certain blocks would increase this skill and give you a chance at crafting an increased number of them.
For example, instead of getting 4 plank blocks from a log, at a certain point you could get 5 and so on and so forth.
So rather than "place a block and build random junk", you're gaining skill for crafting the blocks used to build instead.

Who said it had to have a purpose? One of the main functions of AdventureMMO is to compete with your friends, at the moment that's literally all it's doing on my servers (Had to disable skills due to the enchant issue)


Make createCall function and related functions return an error message to be shown at a higher level

Summary
Before we were showing the errors in place for the parse, which could show several alert boxes. Now we return a error message string that will be rendered (as an alert box most cases) at the highest level.
Ticket Link
https://mattermost.atlassian.net/browse/MM-34138

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14580
https://circleci.com/gh/mattermost/mattermost-mobile/14579

Artifact links:
https://14580-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa
https://14579-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk


Velocyto crashes just by starting...

omendivi$ velocyto
/anaconda3/lib/python3.6/site-packages/h5py/init.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
Traceback (most recent call last):
File "/anaconda3/bin/velocyto", line 11, in
load_entry_point('velocyto', 'console_scripts', 'velocyto')()
File "/anaconda3/lib/python3.6/site-packages/pkg_resources/init.py", line 572, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/anaconda3/lib/python3.6/site-packages/pkg_resources/init.py", line 2755, in load_entry_point
return ep.load()
File "/anaconda3/lib/python3.6/site-packages/pkg_resources/init.py", line 2408, in load
return self.resolve()
File "/anaconda3/lib/python3.6/site-packages/pkg_resources/init.py", line 2414, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/local/bin/velocyto.py/velocyto/init.py", line 13, in
from .estimation import fit_slope, _fit1_slope, clusters_stats
File "/usr/local/bin/velocyto.py/velocyto/estimation.py", line 7, in
from .speedboosted import _colDeltaCor, _colDeltaCorLog10, _colDeltaCorSqrt
ImportError: dlopen(/usr/local/bin/velocyto.py/velocyto/speedboosted.cpython-36m-darwin.so, 2): Symbol not found: _GOMP_parallel
Referenced from: /usr/local/bin/velocyto.py/velocyto/speedboosted.cpython-36m-darwin.so
Expected in: flat namespace
in /usr/local/bin/velocyto.py/velocyto/speedboosted.cpython-36m-darwin.so

The warning is not velocyto it is just thea version of h5py (should be fix in the latest), try to update both h5py and loompy to latest version.


Don’t replace existing discontinuity event

Make CHA-RL4b1 consistent with CHA-RL4a3.

Following our discussion here, we agree that only one discontinuity event will be stored per contributor. The remaining question is whether we should override it with the latest error.
I suggest we either override the discontinuity event with the latest error or store the discontinuity event with a list of unique errors. This approach would prevent overwhelming users with excessive notifications while providing relevant information about the discontinuity. This will also help users to identify discontinuity if caused by message rate limitations as per second point mentioned here or any other app limitations.

The original proposal is that we store and emit the original error, and only the original. From a user perspective - telling them about multiple discontinuities isn't particularly helpful in the case that the original event wasn't emitted immediately due to a lifecycle operation in progress. If anything, it could be more confusing - do we expect them to handle all the errors in some way, some of the discontinuities won't be important / something they should worry about, and are simply because of the room lifecycle atomicity.
I think we should merge this PR as-is, as it represents the current state-of-play (so-as not to block impeding releases), then we can discuss changes / improvements to the room lifecycle more broadly on the road to GA.

I think we should merge this PR as-is, as it represents the current state-of-play (so-as not to block impeding releases), then we can discuss changes / improvements to the room lifecycle more broadly on the road to GA.

Okay, I don't want to block PR as such. Added few suggestions for better rephrasing the spec.
Also, had a last question, if we have an existing discontinuity with errorInfo as null, do we still not override with a new error?
Or do we set some default error when statechange.reason is null?

Okay, I don't want to block PR as such. Added few suggestions for better rephrasing the spec. Also, had a last question, if we have an existing discontinuity with errorInfo as null, do we still not override with a new error? Or do we set some default error when statechange.reason is null, to maintain original error : ?

@AndyTWF do we set discontinuity error as null if  statechange.reason is null, like for first discontinuity detected?


Installation should create a .gitconfig for zulip user

For installs which use the upgrade-zulip-from-git process, this means the deployment directory is a git checkout.  This means that one can, as an emergency tool during deploys, run git revert and similar commands -- assuming there is a ~/.gitconfig set up for the user.
We should create such a file at installation time.  It should consist of:
[user]
        email = ZULIP_ADMINISTRATOR
        name = Zulip Server (HOSTNAME)

...where ZULIP_ADMINISTRATOR is settings.ZULIP_ADMINISTRATOR, which is also the --email passed to the installer.  The HOSTNAME should be the hostname of the server at installation time.
It may be easier to do this in scripts/lib/installer (rather than in puppet) because the administrator email is more accessible there.

@zulipbot claim


Include CRS axis units in CRS routes

Example of response:
{
    "area_of_use": "Europe between 6\u00b0E and 12\u00b0E: Austria; Belgium; Denmark - onshore and offshore; Germany - onshore and offshore; Norway including - onshore and offshore; Spain - offshore.",
    "bounding_box": [
        6.0,
        38.76,
        12.0,
        84.33
    ],
    "country": "DK",
    "srid": "EPSG:25832",
    "title": "ETRS89 / UTM Zone 32 Nord",
    "title_short": "ETRS89/UTM32N",
    "v1": "Easting",
    "v1_short": "x",
    "v1_unit": "metre",
    "v2": "Northing",
    "v2_short": "y",
    "v2_unit": "metre",
    "v3": "Ellipsoideh\u00f8jde",
    "v3_short": "h",
    "v3_unit": null,
    "v4": null,
    "v4_short": null,
    "v4_unit": null
}

The data response from /v1.2/crs/ is now sorted by it's keys for
better human readability.
Closes #43

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

46 of 48 (95.83%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 95.014%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tests/test_api.py
21
22
95.45%

webproj/api.py
25
26
96.15%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
343

Relevant Lines:
361

💛  - Coveralls


Make a call using In-App voice via JS SDK.

We need a good example which demonstrates how to make a call using the JS SDK and C# web api.
Also, since the existing Nexmo chsarp library does not support JWT generation directly we need a sample for the same. So far following the vue.js sample on the Nexmo blog did help. But it takes up a lot of time translating it all into a Microsoft stack.

Closing issue as it's been discussed elsewhere (StackOverflow and Community Slack)


Fix/415 log command before sudo pw

Fixes: #415
implements:

Added a method that will inform the user for what process he will need to enter his sudo- password

note: [cli/src/main/java/com/devonfw/tools/ide/tool/vscode/Vscode.java] hasn't been changed, idk why it shows here, just ignore it :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
39 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 66.646%

Files with Coverage Reduction
New Missed Lines
%

com/devonfw/tools/ide/tool/GlobalToolCommandlet.java
39
1.92%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.07%

Covered Lines:
6283

Relevant Lines:
9083

💛  - Coveralls

Needs to be closed because it was not branched from main


Replace set_last_error with set_last_error_and_return

Took care of the simple patterns. Other patterns involved setting an error and then using write_int or setting metadata and returning -1. Unsure if those are in the scope of this change
Looks like this has conflicts with #3779, so I can update when how to handle that is decided.

Ignore my PR, i'll rebase at some point

Not sure why the comments above have all been marked as resolved -- in the PR they are definitely still unresolved.
@rustbot author

Not sure why the comments above have all been marked as resolved -- in the PR they are definitely still unresolved.

Yes, sorry for the wait. How do you want to handle the InterpResult<'tcx, i64> vs . InterpResult<'tcx, Scalar> issue in my comment above? Once I fix that I'll push the update.

Which comment?

Again sorry about the wait and the careless mistakes, but I added two commits, one a small formatting fix, and in the other I added set_last_error_and_return_i64 and fixed the type issues I introduced. Diff is smaller now too so hopefully this will be easier to re-review.

There are unfortunately conflicts with the master branch, could you take care of them?
Then write @rustbot ready  to initiate the next round of review.

There are unfortunately conflicts with the master branch, could you take care of them with a rebase? Then write @rustbot ready to initiate the next round of review.

Of course. All the conflicts are something like this:
<<<<<<< unix_shims
            return this.set_last_error_and_return_i32(ErrorKind::PermissionDenied);
=======
            this.set_last_error(ErrorKind::PermissionDenied)?;
            return interp_ok(Scalar::from_i32(-1));
>>>>>>> master

I can wrap interp_ok(this.set_last_error_and_return_*(e)) where these all occur, and we'll have an interp_ok(InterpResult<'tcx, Scalar>). Does that sound alright for the resolution?

return this.set_last_error_and_return_i32(ErrorKind::PermissionDenied); looks like the right resolution for that example.

return this.set_last_error_and_return_i32(ErrorKind::PermissionDenied); looks like the right resolution for that example.

I agree, after seeing the new changes while rebasing. @rustbot ready

@rustbot author

Thanks, this all looks correct but there is one spot where we can make it a bit more compact. :)

Good catch. Thank you for the close reviews, this should have been much simpler. If I'm still welcome, I'll make sure my next PR goes more smoothly

Looks good, thanks for the PR!
@bors r+

Thank you for the close reviews, this should have been much simpler. If I'm still welcome, I'll make sure my next PR goes more smoothly

Sure thing, hickups happen. :) Just be careful and ask us rather than making guesses if you're not sure about something. :D When submitting a PR, it is a very good idea to list which things in the PR you are least sure about -- that greatly helps focus the review effort.

:pushpin: Commit ca5c26df2960fa993898b8fc0527ae88b989648f has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit ca5c26df2960fa993898b8fc0527ae88b989648f with merge 0a916c547074d03804245d1d89d2d84417d1e577...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 0a916c547074d03804245d1d89d2d84417d1e577 to master...

:eyes: Test was successful, but fast-forwarding failed: 422 1 review requesting changes by reviewers with write access.

That's odd... @rust-lang/infra bors has a problem if we leave a "changes required" review, and then the changes are done? CI is green but the PR has not been pushed to master.

@bors retry

Wtf, I never saw this error before.. Anyway, what do you think about switching miri from bors to merge queues? xD

@bors r+

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit ca5c26df2960fa993898b8fc0527ae88b989648f has been approved by RalfJung
It is now in the queue for this repository.

Wtf, I never saw this error before.. Anyway, what do you think about switching miri from bors to merge queues? xD

Yeah someone just needs to put in the work for that and I don't currently have the time.^^

:hourglass: Testing commit ca5c26df2960fa993898b8fc0527ae88b989648f with merge 652e860cd660fa3b1d1d2bbb5a59a6b6760ab6af...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 652e860cd660fa3b1d1d2bbb5a59a6b6760ab6af to master...

:eyes: Test was successful, but fast-forwarding failed: 422 1 review requesting changes and 1 approving review by reviewers with write access.

@oli-obk I think we need to you to send an "approving" review or so, otherwise this PR can't land...
Is that really how github reviews work? Nobody else can approve a PR after a team member left a "changes required" review? That's a complete disaster.

you should be able to dismiss my review in the github ui (i approved it now, but for the future)
@bors r+

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit ca5c26df2960fa993898b8fc0527ae88b989648f has been approved by oli-obk
It is now in the queue for this repository.

Where is the "dismiss review" button?

Ah I think I found it. That's quite well-hidden...

:eyes: Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.


Wrong horizontal padding on api 17, 18 and 19

Doesn't affect 15, 16, 21, 22

Fixed, see the latest commit.


Import Model and Mapping Informations from Moose

To prevent the necessity to maintain the FAMIX structure twice: It shall be possible to import a FAMIX model from Moose into the extractor.
This requires also the import of mapping informations.

Will not be done


FreeBSD ppc64 and ppc64le aren't supported (yet?)

Hello,
of cause, this is a go-lang issue, so I asked there also: https://github.com/golang/go/issues/59614
Just for info.

AlmaLinux 8 (xx86_64) has problems with the 'static' go binary:
[runner@amd64-almalinux-8 ~]$ ./github-act-runner
./github-act-runner: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by ./github-act-runner)
./github-act-runner: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./github-act-runner)

There are aware of this: https://github.com/golang/go/issues/58550 (and others)

AlmaLinux 8 (x86_64) has problems with the 'static' go binary:
[runner@amd64-almalinux-8 ~]$ ./github-act-runner
./github-act-runner: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by ./github-act-runner)
./github-act-runner: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./github-act-runner)

There are aware of this: golang/go#58550 (and others) - so maybe an upcoming version will fix this.

When build with CGO_ENABLED=0 for linux (https://github.com/ChristopherHX/github-act-runner/commit/10c214d650176d89ae493531ec4a32854e533609) - it will work also on older linux boxes. The binary size is nearly the same.

I have added CGO_ENABLED: 0 as default job env variable, the android cgo step set it to 1 for android ndk.
Seems like golang is playing with default values, with cgo is the binary not 'static' and linked to glibc of ubuntu-latest

The go env within "Setup go" in this build sets CGO_ENABLED="1" ...
And of cause: ignore the other changes in my commits... I did this just for fast rebuilding...

Could we try to use gccgo for this arch?
Have you tried this alternative go compiler somewehre?

The default gcc package on FreeBSD does not include the gccgo part, so I need to build this myself I think.
But in some first try, I would test this on amd64 platform first... when when this works, I would test it on ppc64.
FreeBSD on amd64,ppc64 and ppc64le is build with --enable-languages=c,c++,objc,fortran,jit
I can give you full access to those systems if you want.... (FreeBSD on arm64, ppc64, ppc64le and amd64)
Porting golang to freebsd/ppc64 seems more complicated, and I do not have the time for getting into this....  :(

Cool, I will try and give feedback


Xiaomi_gateway.by adds custom accessories but cannot find action for home assistant automation

from custom_components.xiaomi_gateway3.core.devices import *
DEVICES = [{
    19641: ["PTX", "PTX Wall Switch", "AK Ultra Mesh2.0", "090615.switch.akult2"],
    "spec": [
        BaseConv("Channel 1", "switch", mi="2.p.1"),
        BaseConv("Channel 2", "switch", mi="3.p.1"),
        MapConv("Channel 1 Mode", "select", mi="2.p.2", map={0: "有线和无线模式", 1: "无线模式"}),
        MapConv("Channel 2 Mode", "select", mi="3.p.2", map={0: "有线和无线模式", 1: "无线模式"}),
        MapConv("backlight_level", "select", mi="16.p.2", map={0: "节能", 1: "柔和", 2: "高亮"}),
        MapConv("backlight_mode", "select", mi="16.p.3", map={0: "默认", 1: "自动", 2: "勿扰模式"}),
        BaseConv("action", "sensor"), # 每个键单独设置一个sensor
        ConstConv("action", mi="5.e.1", value=BUTTON_1_SINGLE),
        ConstConv("action", mi="5.e.2", value=BUTTON_1_DOUBLE),
        ConstConv("action", mi="5.e.3", value=BUTTON_1_HOLD),
        ConstConv("action", mi="6.e.1", value=BUTTON_2_SINGLE),
        ConstConv("action", mi="6.e.2", value=BUTTON_2_DOUBLE),
        ConstConv("action", mi="6.e.3", value=BUTTON_2_HOLD),
    ],
}] + DEVICES

Action not found in automation

You right. Actions will only work with devices from main devices.py file.

You right. Actions will only work with devices from main devices.py file.

thanks

It's better to keep issue open until I add converter.

It's better to keep issue open until I add converter.

This series contains multiple products, and I have re edited the code

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v4.0.8


VDC/ROMS: Failed to get camera parameters

To reproduce:

Build on main and cd into /glade/p/cisl/vast/vapor/Bugs/3134
Issue the following VDC conversion on Casper

cfvdccreate snapshots_00030005.nc nw2_0.25deg_N15_baseline_hmix5_interpolated.nc quarter.vdc
cf2vdc -numts 1 snapshots_00030005.nc nw2_0.25deg_N15_baseline_hmix5_interpolated.nc quarter.vdc

Open the file in Vapor and the following error will be issued.  Vapor will crash after interacting with the visualizer.

Failed to get camera parameters
Note: This error does not occur when importing the aforementioned files as NetCDF-CF.

This error is occurring because the "snapshots" data set's z dimension length is 15, which, after undergoing a VDC wavelet transform, is coarsened to 1. VAPOR is not handling the degenerate case.


Getting the end event

Hi.
Is it possible to get the 'end' event when the user stops moving the slider?
Only found a way to get the events while moving.
Thanks a lot.
Daniel

Oh yes, I think it's easily doable adding the end (maybe start as well, see doc) events forwarding here.
Do you want to try a PR @d-winter?

Hi @redox .
Yes, I can do. Have not made any pull requests before.
Thanks for your feedback!

Has been released in 1.12.0. Thank you for your help @d-winter 👍

Hey @redox,
thanks for the fast merge and release 👍
Have a nice day!


error  GoogleDriveLoader uthorized user info was not in the expected format

a 2nd load (call to GoogleDriveLoader) giveme this error:
Authorized user info was not in the expected format, missing fields refresh_token, client_id, client_secret.

in your jupyter show the same error
docs/extras/integrations/document_loaders/google_drive.ipynb

Hello,
I've fixed the bug in the latest published version


Extraction of Generated Cousins?

Hi, thanks for your great work!
I just run this code and it works smoothly. I might want to extract the scene into Mesh representation. Is it possible?
Thanks!

Hi @xiahongchi ,
Great question! Yes, you can technically extract all the ground-truth meshes from all the objects. The code should be something like this:

# Assumes extracted digital cousin scene has already been loaded using `SimulatedSceneGenerator.load_cousin_scene`

import omnigibson as og
from omnigibson.utils.usd_utils import mesh_prim_to_trimesh_mesh

# We traverse over all objects in the scene, and iterate over all their meshes (can be collision or visual) and extract their trimesh mesh representations
meshes = []

for obj in scene.objects:
    for link_name, link in obj.links.items():
        # Choose either of the following, using visual meshes for now
        # for mesh_name, mesh in link.collision_meshes.items():
        for mesh_name, mesh in link.visual_meshes.items():
            print(f"Extracting mesh for {obj.name} : {link_name} : {mesh_name}")
            tm_mesh = mesh_prim_to_trimesh_mesh(mesh.prim, world_frame=True)
            meshes.append(tm_mesh)

# Then your output is in `meshes`

Closing this issue for now as there's been no response for a few weeks. Feel free to re-open if you continue to run into issues!


💡 [FEATURE] -  Enhancement: Add "Interest in Working on the Issue" Checkbox to Issue Template

Idea Contribution

[X] I have read all the feature request issues.

Explain feature request
We're constantly striving to improve our project's workflow and collaboration experience. One of the aspects we're looking to enhance is the clarity around contributors' interest in actively working on the issues they raise. Additionally, for those participating in programs like GSSOC (Global Summer of Code), we'd like to know if you're part of the organization.
Explain your solution
To achieve this, we're proposing the addition of a new feature to our issue template: a checkbox indicating your interest in working on the raised issue and whether you're part of the GSSOC organization. This will help us prioritize and assign tasks more efficiently, ensuring that contributors who are willing to contribute get the opportunity to do so.
The proposed changes include:
Adding a checkbox labeled "I'm interested in working on this issue" to the issue template.
Adding a checkbox labeled "I'm part of GSSOC organization" to the issue template.
By including these checkboxes, contributors can explicitly communicate their intentions regarding the raised issue, facilitating smoother collaboration and task allocation.
Any alternative approaches/features
No response
Additional Context
No response

It seems like you opened a PR into your forked repository instead of in this project.
This link might be helpful for solving the problem:
It seems like you opened a PR into your forked repository instead of in this project, please check it
If you need help, please dont hesitate to ask me, so we can fix this together,, thank you!

Hii, PA I would like to make this to make a webpage, not only in the readme.md form.
would you like to assign this task to me

I would like to work on this issue. Please assign it to me

i have done a pull request into main branch of your repo. sorry for the inconvenience that i merged it to my forked repo at first.


Class that has a custom format is not respected in grid

factors, dates
View() this and you'll see the dates as integers.
vector.date <- as.Date(c("2015-01-01", "2014-01-01", "2013-01-01", "2012-01-01"))

When we deal with 1D data, we use matrix() to convert it to single-column 2D data first, so that the rest of the code can deal with it in a uniform way. It seems that this process strips the S3 class off the value, and so dates become integers (since a date is just a double with class "Date").


Virtaul keyboard in Login

Hi i am a newbie to serene ... How can I integrate a virtual keyboard at Login screen.?
Please help... Thanks in advance .

https://mottie.github.io/Keyboard/

Thanks for the help

Can anyone help out ? Struggling since 3 days

This is not a Serenity issue.


Extend possible registration period to 10 months

Currently it's set to 9.

@KaitCrawford @rudigiesler ready for review

:+1:

@smn @rudigiesler this needs an updated voice file for the voice part doesn't it?
Any idea of what that file would be called?

Looking quickly through the code, PREBIRTH_MAX_WEEKS defaults to 42, suggesting that 10 months is an okay value. At the maximum of 42 weeks, with PREBIRTH_MIN_WEEKS set to the default of 10, it means that they will start at a sequence number of 32. @bruskiza How many messages do we have in the message sets? Looking at QA, the max I can see is 66, at 2 messages per week that means that the max that the sequence number can be is 33, so starting at 32 should be okay?

Thanks @rudigiesler, I'm talking about the IVR playback of the response.
If we add a "July 2014", there's no "July 2014" voice file in https://github.com/praekelt/hellomama-registration/tree/develop/registrations/static/audio/registration/eng_NG/year.mp3
Yes?

@bruskiza This PR only addresses the USSD line, not the IVR line, so I don't think that that will be an issue (at least for the changes that I see in this PR)

yeah this only touches USSD


Trivial Int32/Int64 constant folding for WASM/asm.js (1-class IntConstantValueInfo version)

Doug suggested that I should open another PR w/ one-class implementation of int64 constants.
This is almost identical to https://github.com/Microsoft/ChakraCore/pull/2597 except for the implementation of int64 constants.
Please disregard this one until it passes all the CI tests

@dotnet-bot
test Ubuntu ubuntu_linux_debug please
pretty-pretty please 😄

Overall looks good, just couple nits. And let's go with the 2 class version.

@MikeHolman Should I close this one since we decided to go w/ the 2-class version?


scripts/readium-js-viewer_all.js" is not available.

Hi,
We are trying to use readium-js-viewer in html for that we downloaded the code from  https://github.com/readium/readium-js-viewer as per the given instruction from develop branch.
But the "scripts/readium-js-viewer_all.js" folder and "readium-js-viewer_all.js" file is missing in our local working directory.
Can you please suggest and help us to resolve this issue.
Best Regards,
Ashish.

Hello, you can either build the cloud reader app as per the instructions in the README:
https://github.com/readium/readium-js-viewer/blob/develop/README.md
...or you can download prebuilt packages from the release area:
https://github.com/readium/readium-js-viewer/releases/tag/0.25.0


Home screen refreshing

Is your feature request related to a problem?
Home screen doesn't refresh until I reopen the app entirely.
Describe the solution
The refresh button and f5 hotkey should be enabled for it.
Describe alternatives you've considered
When ever a user goes on the home screen it refreshes.

Thanks for the feedback. Which widgets on the home screen you think need to be refreshed?

Drives mostly

@josh-65 Thanks for the additional info. I believe this can be merged with #2242.


Link to Youtube Playlist in README.md is incorrect.

The current link in README.md for the youtube playlist takes to the Project Management playlist on your channel.
The corrected link is: https://www.youtube.com/watch?v=jYeZuaLt7nI&list=PLaIsQH4uc08zjutyoBOtoa6fnxzrCQK2Q&index=1&ab_channel=YegorBugayenko

@MusaToTheMoon fixed in 3863fa6 thanks!


On the deployed app, error is thrown when trying to load the swagger schema from non-https servers

ERROR: zone.js:101 Mixed Content: The page at 'https://jsonforms-swagger.herokuapp.com/' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://petstore.swagger.io/v2/swagger.json'. This request has been blocked; the content must be served over HTTPS.

Try to run the deployed editor using this url instead: http://jsonforms-swagger.herokuapp.com/

@hecforga Works! I'll close this