refactor: Extract Instrumentation Registry Gem

This change is the first in many steps that will allow us to move instrumentation gems into the contrib repo.
It copies the existing Registry into its own gem and will allow us to release it without breaking the SDK
or Instrumentations.
Once published we can update existing dependencies to use the opentelemetry-registry gem.
See https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/1
See https://github.com/open-telemetry/opentelemetry-ruby/discussions/776

Leaving the base gem in the main repo means any changes to the Base class would require coordination with the contrib repo. That isn't necessarily true for the registry, which hasn't changed much.
The tight coupling between the instrumentations and the Base class made me think isolating the registry would make maintenance easier for us.

Why this change makes sense from my perspective

Having the registry decoupled from the sdk allows a hypothetical third party sdk to make us of it, and by extension all the instrumentation.
The registry has little to no churn, and is more closely related to the SDK than anything else.
I think it'll improve ease of development for instrumentation packages (in the contrib repo) if some changes need to be made in the base class and you want to see if they’re compatible immediately as part of ci, and not when you do a gem bump.

@robertlaurin It looks like there are intermittent test failures in Linux JRuby. Has that come up before?
https://github.com/open-telemetry/opentelemetry-ruby/runs/5853687205?check_suite_focus=true


callisto release: release v0.56.0 and update docs with new version

Mind pushing these directly to main? Our rebase-and-merge PR settings could conceivably break the tag/commit association, and we want to make sure the tag is long-lived and stable.

https://github.com/penumbra-zone/penumbra/commit/a43b5944dfac702fd76fee6aab81de05f97de898


[otbn] Get performance numbers for ECDSA P-256

PR #5247 provides us with an end-to-end sign/verify test for ECDSA P-256. We can now use this test to get performance numbers for ECDSA P-256.
To make the numbers slightly more accurate, it would be nice to get answers to two questions. (If we don't have them right now that's fine as well, it won't make that much of a difference.)
Currently, the test uses a hardcoded random value k, which must be generated on the fly in a real-world scenario. For the verify test the final comparison (r == r') is done on Ibex (and not included in the performance numbers right now).
To make the performance numbers we get from this test close to reality I have two questions:

Should we produce the random value k on OTBN, or on Ibex?
Should we perform the final comparison in verify on OTBN (returning only "verify passed" back to Ibex), or on Ibex?

(Doesn't matter is a valid answer, in that case I'll go for OTBN, as it will be faster.)
@moidx @felixmiller

Re k: This number should be generated on OTBN in the future. The requirement here is guaranteed fresh and high entropy, since this number is part of the algorithm specification.
Re comparison: Also here I don't see a reason why this shouldn't happen on OTBN (which is faster here). Result encoding shouldn't be a single bit obviously but a 32 bit magic number probably.
We can tackle both as soon as #4000 is through.

With the current code in the OpenTitan source tree we get the following performance numbers for ECDSA P-256:

Signing: 788 us (initialization) + 6604 us (signing) = 7392 us
Verification: 788 us (initialization) + 4650 us (verification) = 5438 us

The initialization part is primarily loading the instruction code into OTBN, which of needs to be done only once for consecutive operations.
Things to note:

The current OTBN assembly code isn't optimized, but is also missing some small features (as discussed in this issue). Expect an error margin of around +- 20% (with a tendency towards decreasing the runtime actually).
These numbers are for ECDSA P-256, not for P-384. Expect numbers for P-384 to be roughly 6x as large, based on current very rough estimates.

@mateenfaisal @felixmiller @moidx


[G7T5-42] Edit BE API for skill

Description
Edit backend API for skill to call DB
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Not Applicable
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Can you add the unit tests as well? Following this:

Endpoint test
Crud test (to database)
Utils if necessary


[2.8] Remove dependency on rancher-machine module

What this PR does / why we need it:
We have to drop rancher-machine module dependency, because it was deprecated.
Add FindTenantID and NewSubscriptionsClient functions.
FindTenantID function is used to find the tenant ID for the subscription ID. It will send an unauthenticated request to the Azure Resource Manager endpoint to get the tenant ID from the WWW-Authenticate header.
Which issue(s) this PR fixes
Issue https://github.com/rancher/aks-operator/issues/214

@mjura this probably needs a rebase? https://github.com/rancher/aks-operator/pull/311 is already merged and should fix scan problems in CI


[collab-galley] Add Filesystem source support.

Refactoring of the filesystem source on the new config source model.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Do you mean testing related code? They are used in the tests.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
450ee64ed3bc49528d167de9c6bac8673e69df49
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
450ee64ed3bc49528d167de9c6bac8673e69df49
link
/test istio-unit-tests

prow/integ-security-k8s-presubmit-tests.sh
450ee64ed3bc49528d167de9c6bac8673e69df49
link
/test integ-security-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests


Test failures on Kubuntu 21.04

After building gperftools 2.9.1 on Kubuntu 21.04 its unit tests fail:

stacktrace_unittest
sampling_test.sh
sampling_debug_test.sh

Here is a full build log, where you will find configure/build options and the failed test logs:
build_log.txt
Additionally, I'm attaching a backtrace for stacktrace_unittest as it is failing with SIGABRT:
stacktrace_unittest.bt.txt

Apparently, the test failures are caused by the fact that LTO is enabled by default in Kubuntu 21.04. If I disable LTO by adding export DEB_BUILD_MAINT_OPTIONS = optimize=-lto to the packaging scripts, the tests succeed.
You might want to explicitly disable LTO in gperftools build scripts, if it is not compatible with the optimization.

thanks for reporting this and apologies for delay. We should now handle lto. (issue was tests-only)


Update README based on docker-library/docs#172

This PR updates README.md based on docker-library/docs#172.

LGTM now :smile:


robyn_allocator - What's the difference between expSpendUnitTot & optmSpendUnitTotal?

Project Robyn
In robyn_allocator, What's the difference between expSpendUnitTot & optmSpendUnitTotal?
with   scenario = "max_response_expected_spend", shouldn't be the same number?
In my example i have optmSpendUnitTotal= 14769, expSpendUnitTotal = 2500
Environment & Robyn version
Make sure you're using the latest Robyn version before you post an issue.

Check and share Robyn version: packageVersion("Robyn")
‘3.9.0’
R version (Please, check and share: sessionInfo() or R.version$version.string)
R version 4.2.2 (2022-10-31 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

Matrix products: default
locale:
[1] LC_COLLATE=Spanish_Spain.1252  LC_CTYPE=Spanish_Spain.1252
[3] LC_MONETARY=Spanish_Spain.1252 LC_NUMERIC=C
[5] LC_TIME=Spanish_Spain.1252
attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods
[7] base
other attached packages:
[1] Robyn_3.9.0  rjson_0.2.21
loaded via a namespace (and not attached):
[1] Rcpp_1.0.10        rpart.plot_3.1.1   lubridate_1.9.1
[4] lattice_0.20-45    tidyr_1.3.0        png_0.1-8
[7] lares_5.1.4        glmnet_4.1-6       digest_0.6.31
[10] foreach_1.5.2      utf8_1.2.2         R6_2.5.1
[13] plyr_1.8.8         ggridges_0.5.4     httr_1.4.4
[16] ggplot2_3.4.0      pillar_1.8.1       rlang_1.0.6
[19] lazyeval_0.2.2     nloptr_2.0.3       rpart_4.1.19
[22] Matrix_1.5-1       reticulate_1.28    splines_4.2.2
[25] stringr_1.5.0      igraph_1.3.5       RCurl_1.98-1.10
[28] munsell_0.5.0      compiler_4.2.2     pkgconfig_2.0.3
[31] shape_1.4.6        rPref_1.4.0        tidyselect_1.2.0
[34] tibble_3.1.8       codetools_0.2-18   fansi_1.0.4
[37] crayon_1.5.2       withr_2.5.0        dplyr_1.1.0
[40] bitops_1.0-7       grid_4.2.2         jsonlite_1.8.4
[43] gtable_0.3.1       lifecycle_1.0.3    magrittr_2.0.3
[46] pROC_1.18.0        scales_1.2.1       RcppParallel_5.1.6
[49] zip_2.2.2          cli_3.6.0          stringi_1.7.12
[52] doRNG_1.8.6        doParallel_1.0.17  xml2_1.3.3
[55] generics_0.1.3     vctrs_0.5.2        openxlsx_<IP_ADDRESS>
[58] iterators_1.0.14   tools_4.2.2        prophet_1.0
[61] glue_1.6.2         purrr_1.0.1        rngtools_1.5.2
[64] parallel_4.2.2     survival_3.4-0     yaml_2.3.7
[67] timechange_0.2.0   colorspace_2.1-0   h2o_<IP_ADDRESS>
[70] rvest_1.0.3        minpack.lm_1.2-3   patchwork_1.1.2

Hi, you're not using the latest version. We've improved the allocator a lot since then.
In general, optmSpendUnitTotal is the daily or weekly (whatever your time grain is) spend recommendation after the optimisation. expSpendUnitTotal is before.

feel free to reopen if necessary

hi,
coming back to this. My old repo was with 3.9. And i would now to replicate results using same version.
But this issue, still bothers me to understand the results


[Bug-9829][Api] Fix schedule timezone

Purpose of the pull request
this pr close #9829
Brief change log
transform timezone for scheduler time.
Verify this pull request

Manually verified the change by testing locally.

Codecov Report

Merging #9830 (168d7e0) into dev (d3c53af) will decrease coverage by 0.01%.
The diff coverage is 5.71%.

:exclamation: Current head 168d7e0 differs from pull request most recent head 49dfd06. Consider uploading reports for the commit 49dfd06 to get more accurate results

@@             Coverage Diff              @@
##                dev    #9830      +/-   ##
============================================
- Coverage     40.41%   40.39%   -0.02%
- Complexity     4525     4528       +3
============================================
  Files           834      834
  Lines         33639    33657      +18
  Branches       3721     3725       +4
============================================
+ Hits          13594    13596       +2
- Misses        18761    18776      +15
- Partials       1284     1285       +1

Impacted Files
Coverage Δ

...che/dolphinscheduler/api/python/PythonGateway.java
9.23% <0.00%> (-0.52%)
:arrow_down:

...cheduler/api/service/impl/ExecutorServiceImpl.java
42.68% <0.00%> (ø)

...heduler/api/service/impl/SchedulerServiceImpl.java
7.85% <0.00%> (-0.51%)
:arrow_down:

...eduler/service/quartz/impl/QuartzExecutorImpl.java
0.00% <0.00%> (ø)

...pache/dolphinscheduler/common/utils/DateUtils.java
78.87% <66.66%> (+1.56%)
:arrow_up:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c53af...49dfd06. Read the comment docs.


xbr requirements

can you tell me step by step how to extract a xbr file with the requirements?

forget it, i finally knew how to do it.


Add observations to ADF via variable defaults file

New feature type
New infrastructure or infrastructure enhancement
What is this new feature?
The variable defaults file (adf_variable_defaults.yaml) could be used to indicate which observational datasets a particular model variable should be compared against.  This would allow for full model vs. obs capabilities in the ADF, at least until Intake-ESM is brought into the framework, and provides an avenue for a user to access an observational dataset without having to immediately add it to an Intake catalog in the future.
Finally, please note that this will likely result in the removal of the obs_type_list from the ADF config file.
Assistance required?
No, I will make a PR when the feature is ready
Extra info
No response

I think this is a good idea, and Jesse and I have discussed it.
I think that all we would need is attributes for each variable to specify:

Observation file name
Observation variable name
Observation unit conversion

Regarding time samples:
Right now we mostly have 2D (single level) or 3D (multi level) climatologies with only 1 time sample per file (monthly, seasonal or annual). Could we just make a monthly file and have the software deal with seasonal and annual? OR: we just assume the previous convention and look for a month (01-12) season (DJF, JJA, etc) or 'ANN').
I guess software needs to assume we are interpolating horizontally and vertically (in pressure)?


Show all city names when zoomed in

Is this still needed?
I worked on a fix for this, but I need to do some collision detection (I think) to make sure the labels are readable. Right now, it creates situations like this:

Would be a nice to have, but not as important now since zooming in filters
the list of cities below the map.  I wouldn't try too hard on it.
On Mon, Jun 27, 2016 at 12:13 AM Patrick McElwee<EMAIL_ADDRESS>wrote:

Is this still needed?
I worked on a fix for this, but I need to do some collision detection (I
think) to make sure the labels are readable. Right now, it creates
situations like this:
[image: screen shot 2016-06-27 at 12 11 47 am]
https://cloud.githubusercontent.com/assets/808015/16368389/e05c4d6a-3bfb-11e6-830f-fcb39546ad60.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BrandNewCongress/website/issues/12#issuecomment-228650527,
or mute the thread
https://github.com/notifications/unsubscribe/AAFHRlNYXr4C79GkLZia4GgQw4tB99wAks5qP03qgaJpZM4Ij6Vm
.


end if

Is it possible to disable the autocompletion of the if statement if it is proceeded by an end? Every time I type end if and hit Enter, it does the following, and then I have to undo.

I haven't touched the snippets in a long while (maybe ever). So I'm not sure exactly what can be done with these other than to remove them. But I'll look into it and see if I can prevent them from triggering in these cases.

OK. After a few minutes playing with the rules it doesn't look like you can add regex to these rules. So place detecting doesn't seem possible. However I did learn that you can change Atom's autocomplete package autocomplete-plus to trigger using the tab key rather than enter (see this post). That's probably the simplest solution.

That works for me. Thanks!


Update shell code to avoid whitespace confusion

The existing code would fail in sad ways if the current directory contains whitespace characters.

Thanks


Score Percentage

Describe the Bug
So... every time I play into a map the score percentage does not show
I attached the counterplus.json file if that helps.
CountersPlus.zip

Try enabling the base game Advanced HUD option within the Player Settings menu.


Does not work inside Nested scrollviews

Height is not calculated correctly. Items get hidden if the recycleview is at the bottom of a nested scrollview

@breakline87 - Any solution? I am also getting same issue

I forgot which project I needed this but we just wrote a custom solution in the end I believe

I have
<ScrollView>
  ...
      <androidx.recyclerview.widget.RecyclerView
                android:layout_height="wrap_content"
                android:clipToPadding="false"
                android:nestedScrollingEnabled="false"
</ScrollView

flag android:nestedScrollingEnabled="false" causes childrens of the most bottom group to be swallowed if they don't fix screen height

Closing this as this library is deprecated: https://github.com/thoughtbot/expandable-recycler-view/pull/235


TypeError: init() takes from 1 to 4 positional arguments but 5 were given

Fix for #89.

Coverage remained the same at 98.366% when pulling 13213dfcb9d18a6ba41ef1cb8e3700a712ceef81 on fix/missing-args-in-mocket into 79eaa7b0568aadf17905185cbbb4ed19979e040d on master.

Coverage remained the same at 98.366% when pulling 13213dfcb9d18a6ba41ef1cb8e3700a712ceef81 on fix/missing-args-in-mocket into 79eaa7b0568aadf17905185cbbb4ed19979e040d on master.

Coverage remained the same at 98.366% when pulling 13213dfcb9d18a6ba41ef1cb8e3700a712ceef81 on fix/missing-args-in-mocket into 79eaa7b0568aadf17905185cbbb4ed19979e040d on master.


docs(readme): add halbot

Adding my own project that using node-chatgpt-api.
My project is a telegram bot have these features:

Telegram Bot (Telegram Bot token required)
ChatGPT (OpenAI API key required)
Bing Chat (Bing Chat user token required)
Speech-to-text (Google Cloud API key required, or your own engine)
Text-to-speech (Google Cloud API key required, or your own engine)
Support private and public mode, with multiple authenticate methods.
Middleware style workflow, easy to extend.
Realtime stream-style response, no more waiting.
Markdown rendering for GhatGPT
Reference rendering for Bing Chat
Code block rendering, developers friendly.
ESM from the ground up

Very nice, thanks for sharing!

Thanks for the merge and thanks for your work :)


some way to pass in the cabal files extensions?

i'm not entirely sure if this is the job of ghcid, but i'm using the NoImplicitPrelude extension, and thus my ghcid command starts off like ...:
ghcid --command="stack ghci --ghci-options -XNoImplicitPrelude ...

it'll get more crazy as i care about more extensions. but shouldn't we just be able to load with the extensions that are found in the cabal file? am i missing some reason that this isn't a good idea?

actually this isn't a problem with ghcid; this happens with stack ghci itself; my bad.

If stack ghci doesn't start with all the appropriate extensions in your .cabal file then that's a stack bug - and I would encourage you to report it. It's probably relatively easy to fix, and the stack devs are quite responsive.

stack ghci does load the extensions specified in the cabal file.  Perhaps you have extensions specified in benchmark or test stanzas?  These will not be loaded unless test / bench targets are specified.

yeah, sorry, it's just when i tried stack exec -- ghci app/Main.hs i noticed this; but that's just me not understanding what ghci does when i pass it arguments. i don't think it should be trying to load the extensions there, so it doesn't.
my mistake; sorry for the noise :)


Add license to dubbo-migration.yaml

What is the purpose of the change
Add license to dubbo-migration.yaml
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

fixed in #7394


Build Error on MacOS M1

error: unknown target CPU 'cyclone'

Details:
/ffmpeg-android-maker/sources/libmp3lame/lame-3.100/mpglib'
/bin/sh ../libtool  --tag=CC   --mode=compile /Users/shabinder/Library/Android/sdk/ndk/25.2.9519653/toolchains/llvm/prebuilt/darwin-x86_64/bin/i686-linux-android21-clang -DHAVE_CONFIG_H  -I. -I.. -I../include -I. -I../libmp3lame -I..    -O3 -march=i686                                 -mtune=native -Wall -pipe  -fno-common -MT common.lo -MD -MP -MF .deps/common.Tpo -c -o common.lo common.c
libtool: compile:  /Users/shabinder/Library/Android/sdk/ndk/25.2.9519653/toolchains/llvm/prebuilt/darwin-x86_64/bin/i686-linux-android21-clang -DHAVE_CONFIG_H -I. -I.. -I../include -I. -I../libmp3lame -I.. -O3 -march=i686 -mtune=native -Wall -pipe -fno-common -MT common.lo -MD -MP -MF .deps/common.Tpo -c common.c  -fPIC -DPIC -o common.o
error: unknown target CPU 'cyclone'
note: valid target CPU values are: i386, i486, winchip-c6, winchip2, c3, i586, pentium, pentium-mmx, pentiumpro, i686, pentium2, pentium3, pentium3m, pentium-m, c3-2, yonah, pentium4, pentium4m, prescott, nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, rocketlake, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, lakemont, k6, k6-2, k6-3, athlon, athlon-tbird, athlon-xp, athlon-mp, athlon-4, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, geode
make[1]: *** [Makefile:443: common.lo] Error 1

It would be better to attach a command that you execute and get this error instead of just the error message.
I know there are some issues with executing all this stuff on Apple Silicon. To be honest, I still wait for NDKr26 that should address most of the issues.

A quick test shows that this problem happens when you try to build the x86 version of the mp3lame.
A arch -x86_64 zsh command before the ffmpeg-android-maker.sh execution seems to fix the issue. Though I didn't test this approach thoroughly.

That worked, closing this, probably a future version of ndk support m1 natively as you suggested.


[Feature request] Support the experimental

Is your feature request related to a problem? Please describe.
When using the experimental <script setup> feature in the Vue 3.0.4, the context is not set correctly when checking types in the template.
=> ./src/App.vue:3:4
Error :: Cannot find name 'SiteFooter'. (code 2304)

<template>
  <router-view class="flex-1" />
  <SiteFooter />
</template>

<script lang="ts" setup>
import SiteFooter from "./components/SiteFooter.vue";
</script>

Describe the solution you'd like
The Vue type support should handle the implicit setup() wrapping.
Describe alternatives you've considered
N/A
Additional context
N/A

There is partial support for <script setup>. I'll wait for https://github.com/vuejs/rfcs/pull/227 to reach the final comments stage before further implementation.

I wish


goma, demander

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[d,g]

/trunk merge


M3-1881 fix regression with action menu button

Coverage remained the same at 31.49% when pulling 88e9838893f93c96262a77163ac3946fa57fac68 on alioso:M3-1881 into c5c4512d9bf4bd3674363aba9ccbcfa336cce566 on linode:develop.


Updating  Files w/ New  Flags

Summary of the Pull Request
What is this about?
Update ./contrib examples such that they use the correct --client_id, --client_secret, etc. flag updates.
PR Checklist

[ ] Applies to work item: #1968
[ ] Closes #1968
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Codecov Report

Merging #2861 (0a224ae) into main (b38ab5d) will increase coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
+ Coverage   28.08%   28.97%   +0.89%
==========================================
  Files         302      177     -125
  Lines       35651    22237   -13414
==========================================
- Hits        10012     6444    -3568
+ Misses      25639    15793    -9846

Impacted Files
Coverage Δ

...Service/ApiService/onefuzzlib/WebhookOperations.cs

...ice/ApiService/onefuzzlib/NodeMessageOperations.cs

...Service/ApiService/onefuzzlib/notifications/Ado.cs

src/ApiService/ApiService/Log.cs

...piService/ApiService/onefuzzlib/ImageOperations.cs

...c/ApiService/ApiService/Functions/NodeAddSshKey.cs

src/ApiService/ApiService/Program.cs

...c/ApiService/ApiService/OneFuzzTypes/Converters.cs

src/ApiService/ApiService/Functions/Negotiate.cs

src/ApiService/ApiService/OneFuzzTypes/Requests.cs

... and 115 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Scope shouldOverrideBuilder flag for Cancun

Successor of https://github.com/ethereum/execution-apis/pull/395 suggesting to scope shouldOverrideBuilder flag for Cancun.

Apparently there was a comment in ACD that this proposal allows greater control by validators, but I'm not sure that I see how that is the case.  Please could someone expand a little on the rationale behind this flag, and how it would work as part of the builder flow?

@mcdee here is the original thread https://github.com/ethereum/execution-apis/pull/388
This is the way for EL to make a suggestion to use locally built payload in the case when according to some heuristics (which are not strictly specified as we favour client diversity here) censorship is detected. CL is free to ignore this flag even if it's set to true, also, CL can employ its own heuristics to detect censorship.
All the above is up to implementation. If EL doesn't implement any heuristics it should simply return false all the time.

Sure, but there was a comment about greater control by validators.  I don't see where the validator is even informed about what's going on here, let along able to increase its control, with this flag.
The block building process where a local execution payload is required by the validator is already pretty well-defined, in that the validator client asks for a block proposal.  The block building process where a remote block is requested is also pretty well-defined, in that the validator client asks for a blinded block proposal.  But validators don't have control, in that if the beacon node decides that it wants to use a locally-generated payload and put it in a blinded block proposal it is free to do so and the validator client is unaware that this has occurred.
This proposal appears to be a way of informing the CL of the EL's current view of potential censorship on the network.  If this is the case, would it not make sense for this to be a separate call that can be made to the EL by either the beacon node or the validator client to find out the state of the network, so that the validator can act accordingly?

If this is the case, would it not make sense for this to be a separate call that can be made to the EL by either the beacon node or the validator client to find out the state of the network, so that the validator can act accordingly?

Do we have any restrictions that the current proposal does have vs a separate method, or clear benefits of the latter? Separate method requires addition engineering complexity which needs justification.

It pretty much boils down to control.  At current a validator client can ask for and receive a block with a local execution payload by requesting a block proposal.  However, if asking for a blinded block it has no control of (or visibility into) the provenance of the execution payload (header) returned.  Ultimately this means that validator clients do not have control of the execution payload of the block they wish to publish, regardless of what they have told the beacon node.  If this is the desired result then it would be good to make this explicit, as there was a comment on the last ACD to the effect of this being a change that increased control for validators.
As for the idea of a separate method: with the current proposal the CL cannot know if the EL has detected censorship without requesting the payload.  I am assuming that censorship detection  is an on-going process, and as such would be faster to return than building and returning the complete payload.  With the current suggestion I believe the flow of the CL that wanted to use this flag when being asked for a blinded block would be roughly as follows:

CL is asked for a blinded block
CL fetches execution payload header from MEV relay / MEV boost
CL fetches execution payload from locally attached EL
EL receives flag from EL and returns either payload accordingly

The concern is that the CL will wait for item 3 to complete even if that is significantly after item 2 has completed, resulting in the return of the payload to the VC being possibly delayed.  With the recent changes made to the blinded block path that has resulted in later blocks and more orphans, would this potentially further increase the delay for block publication?
This is where the idea of a separate API call comes from: it can be called out of the critical path (for example 1s before the end of each slot) so that the CL can be aware, and then if asked for a blinded block can either go to the MEV relay or the locally attached EL, but not be required to do both (at least, in the happy path).

The concern is that the CL will wait for item 3 to complete even if that is significantly after item 2 has completed

I don't think this is true. In a normal case CL should request its local EL for a payload at the beginning of a slot after it has confirmed that the head hasn't been changed since the latest build request. I would assume that (2) and (3) happens roughly at the same time. The usage of a new flag should be quite similar to already existing blockValue in that regard. cc @potuz

At current a validator client can ask for and receive a block with a local execution payload by requesting a block proposal.

According to this proposal a VC won't have access to this flag and can only defer the decision making to BN or ignore existence of this flag entirely. Do we have a VC that would benefit from the direct access to this information? Maybe Vouch?

I would assume that (2) and (3) happens roughly at the same time.

They would start at roughly the same time, but 2) could complete well ahead of 3), which would be the concern.

Do we have a VC that would benefit from the direct access to this information? Maybe Vouch?

Very much so.  If Vouch knows that the EL believes that transactions are being censored it could avoid a chunk of time-consuming work.  At current it has to go through a relatively painful loop of "fetch bids from relays, ask beacon nodes for blocks, find out that beacon nodes aren't using relay execution payloads" before going back to beacon nodes to ask for unblinded blocks because it's only in the third step (when Vouch received blinded blocks from beacon nodes with execution payload headers that don't match what it was expecting) that it (implicitly) finds out the status of this flag.

They would start at roughly the same time, but 2) could complete well ahead of 3), which would be the concern.

In a normal case fcU triggering a build process is sent seconds in advance to a slot where validator is proposing a block and then when payload gets requested by the call to getPayload EL instantly responds with a built payload it has upon request.

They would start at roughly the same time, but 2) could complete well ahead of 3), which would be the concern.

do you have data on this? our testing shows this never ever happens. Even less so now that relayers have an extra delay in returning the payload to the proposer while the local EL returns one immediately.
Regardless of this, at least Prysm (and presumably other CLs as well) will still wait for the local block to compare values for example.

do you have data on this?

Nope.

...our testing shows this never ever happens. Even less so now that relayers have an extra delay in returning the payload to the proposer while the local EL returns one immediately.

This is a different bit of the process.  This is the request to the relay to obtain the execution payload header, not to unblind the block, so before the signing process starts.

This is a different bit of the process. This is the request to the relay to obtain the execution payload header, not to unblind the block, so before the signing process starts.

Right, but still the delay in computing the state root is always orders of magnitude more than the EL providing the block.

The concern is that the CL will wait for item 3 to complete even if that is significantly after item 2 has completed,

I think most clients are currently already waiting for local EL before accepting the Builder Bid. The reason is the withdrawals root validation.

One thing that will be good to have is when EL returns true, also log something out could be a warning or debug verbosity on why the reason true was returned. CL won't really be able to explain anything except "we got an override signal" from EL and surely operators will ask for more reasoning

One thing that will be good to have is when EL returns true, also log something out could be a warning or debug verbosity on why the reason true was returned. CL won't really be able to explain anything except "we got an override signal" from EL and surely operators will ask for more reasoning

Do you mean conveying e.g. the name of triggered heuristic to CL when true is returned?

One thing that will be good to have is when EL returns true, also log something out could be a warning or debug verbosity on why the reason true was returned. CL won't really be able to explain anything except "we got an override signal" from EL and surely operators will ask for more reasoning

Do you mean conveying e.g. the name of triggered heuristic to CL when true is returned?

I don't think it needs to send a string for reason, but certainly EL can log something for greater visibility. I don't think that's something to specified in the spec, but just making a mental note


Rework of examples

[x] Ignore output of example
[x] Simplify installation instructions
[x] Add an example for Java and Gradle
[x] Add a NetLogo example
[x] Add a Python example

Fixes #68
Fixes #69

I would be glad if we could merge the default_setup and features_demo examples into a single rust example.

I would be glad if we could merge the default_setup and features_demo examples into a single rust example.

As default_setup is just what is created with init, I would simply delete it. What do you thinkabout activating the reverse mode in the then rust example, and describe it like in the netlogo example (except for the netlogo complications)?

As default_setup is just what is created with init, I would simply delete it. What do you thinkabout activating the reverse mode in the then rust example, and describe it like in the netlogo example (except for the netlogo complications)?

Done. Moved remarks on dreverse mode in the netlogo example to the borrom

Done. Moved remarks on dreverse mode in the netlogo example to the borrom

What do you thinkabout activating the reverse mode in the then rust example

Yes, I think reverse mode makes most sense for languages like Rust and Java which provide good native tooling like formatters and IDE which one would want to use, but which cannot handle the literate program.

What do you thinkabout activating the reverse mode in the then rust example

Yes, I think reverse mode makes most sense for languages like Rust and Java which provide good native tooling like formatters and IDE which one would want to use, but which cannot handle the literate program.

Ok, thanks for letting me know. I will see. I case I venture to give the restructuring that you suggested a try, I would prefer to utilize your capacity for that.

Ok, thanks for letting me know. I will see. I case I venture to give the restructuring that you suggested a try, I would prefer to utilize your capacity for that.


remove @angular/http in package.json

why "@angular/http": "~4.4.4" is in DevDependencies of package.json of master? if it is deprecated
https://github.com/angular/material2/blob/master/package.json

It is still needed for one of our CI checks. Since it’s a dev dependency consumers don’t have to install it anyway.


[Select] component with multiple prop does not display placeholder

When using a Select component along with the multiple and displayEmpty props, the placeholder is not shown when no values have been selected. My guess is that this is because when multiple is true, value is always truthy (since it must be an array).

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
When there are no values selected then the placeholder value should be shown.
Current Behavior
The placeholder is not shown and the input is empty
Steps to Reproduce
To see the issue see this codesandbox example: https://codesandbox.io/s/2zkv6q17yj

Tech
Version

Material-UI
v1.5.0

@jbgarr You can workaround by providing an empty string to the array. However, I believe we could apply a change like this one to handle the case out of the box:
      if (multiple) {
        if (!Array.isArray(value)) {
          throw new Error(
            'Material-UI: the `value` property must be an array ' +
              'when using the `Select` component with `multiple`.',
          );
        }

        selected = value.indexOf(child.props.value) !== -1;
-       if (selected && computeDisplay) {
+       if (computeDisplay && (selected || (child.props.value === '' && value.length === 0))) {
          displayMultiple.push(child.props.children);
        }
      } else {

Hey @oliviertassinari, i would like to tackle this one if thats okay! :)

@rfbotto With a unit test, it would be perfect :)

@oliviertassinari Thanks for the reply. I tried adding an empty string to the array as you suggested, and the result isn't what I'm looking for either. Here's an example: https://codesandbox.io/s/2zkv6q17yj
Is that what you were suggesting, or did I misunderstand?


Save settings in local storage

How to do it: https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API/Using_the_Web_Storage_API

Should save:

Interval time
Volume
Sound

After #2

Opt-in for notification


Add Welsh localization

I don't speak Welsh myself, but I've done some research... 😅

Coverage remained the same at 69.498% when pulling 3d6fc5158eb6028aa72d9d29390f6bb0d1a039fe on eveoh:l10n-welsh into 92813b3f5f8da83ddcea75e51c2a913e1fad0a2e on chmln:master.

awesome :taco:

Wow, that was quick. Thanks.


Remove calls to deprecated instance endpoint

We are currently offering InstanceMethods.getInstanceV1(), which will get instance information using a deprecated V1 endpoint. Accessing the V2 endpoint is implemented in InstanceMethods.getInstance() already.
The V2 endpoint exists since Mastodon server 4.0.0, and all server versions <4.1 are considered to be EOL / unsupported according to https://github.com/mastodon/mastodon/security/policy

[x] remove getInstanceV1() function
[x] remove InstanceV1 entity
[ ] simplify instance version detection in MastodonClient - probably the whole function cascade between getInstanceVersionViaApi() and versionedInstanceRequest() can be removed

Do you know if we can rely on getInstanceVersionViaServerInfo() for all 4.0.0+ server versions or should we still keep the API call?

I assume that we can safely remove the API call. The existence of the Nodeinfo 2.0 endpoint is mentioned in Mastodon's "Routes" documentation, even predating any 4.0 updates to the docs.

@bocops Ah, nice, that makes it a bit easier to reduce code yet again. Thanks! Will remove it in #452 then.


check mode

Can we create a check mode, to fail in CI if this makes changes (when using it outside of pre-commit)?

It's not really designed to work outside of pre-commit, though I believe it already exits nonzero when making changes

(that said, it probably works fine outside!)

Works for me, other than returning non-zero when making changes. 🤔

Oh indeed, woops I was thinking of another repo, that should probably happen here too


Extra space on header when in Full Screen

OS/Platform
macOS
Installed
OS/Platform's package manager
Version
Version 107.0.5304.88 (Official Build, ungoogled-chromium) (arm64)
Have you tested that this is not an upstream issue or an issue with your configuration?

[X] I have tried reproducing this issue in Chrome and it could not be reproduced there
[X] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[X] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile and it could not be reproduced there

Description
Sometimes when I use ungoogled chromium on full screen an extra empty space on the header is added
How to Reproduce?

Open the Browser
Click on the green circle on the header

Actual behaviour
The application goes full screen, but empty space is added to the header.

Expected behaviour
The application goes full screen without the empty space added to the header.
Relevant log output
No response
Additional context

Installed using homebrew
macOS Monterey 12.6 (Apple M1 pro)
Sometimes, going out of the full screen and clicking to go full screen again fixes the problem
It also happened in older versions

[x] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile and it could not be reproduced there

If that's the case your profile is broken, you could transferring only the data you care about to a new profile.

@networkException I also can't reproduce this on my profile. It only occasionally happens. I'll try your suggestion and see if it happens again.

So, how is it doing?


JSDoc or similar documentation for inferred types?

Is there a way to provide JSDoc (or some kind of documentation) attached to the inferred types?

I'm afraid I'm not very familiar with JSDoc or how to use it with TypeScript

After doing some reading on the subject it's doesn't appear that JSDoc and TypeScript are compatible at all. Looks like TypeDoc might be a better solution. Though it appears TypeDoc also doesn't support annotating type aliases, only interfaces... 🤷♂
Anyway, I'm gonna close this since this is out of scope for Zod.

It would be nice to have pop-up documentation for interface properties in VS Code. Typically we use the format shown in examples on the TypeScript web site (what I thought was JSDoc, but might actually be TSDoc). VS Code recognizes that, and it is included in exported modules. Anyway, it sounds like this isn’t possible right now. Thank you for looking into it.

The TypeScript does understand JSDoc (not TSDoc), but you won't find it in the language specification.   This mostly in the TypeScript language service, rather than in the compiler itself, but the compiler and language service ship in the same package.   The language service is used by IDEs (including Visual Studio Code and others) to provide IntelliSense at code editing time to enhance the developer experience when writing in javascript or TypeScript
In my initial experiments with zod, the IntelliSense experience was less than good, and this could be enhanced by adding some fairly simple JSDoc comments to the zod source code, this would mostly help when someone is trying to write a zod schema, e.g. when I type "z.", it would enhance the list of hints provided.   Adding these JSDoc comments to zod's source code would be fairly simple.  I can provide a PR that gets that started adding JSDoc comments to frequently-used members like z.string() and, z.object().
But this issue seems to be asking for more than that, adding IntelliSense to the infered types seems like a much trickier proposition.

Any updates on this one since 2020? This is one of the main thing that holds me back from moving everything to zod - inability to have comments associate with types.

@tonyxiao A workaround that has worked well for me is defining interfaces that extend types extracted from  zod types and then documenting them through typedoc. This post has a few examples. It has caveats but mostly works well in practice - this library has its documentation generated in this manner.

@lorefnon thanks for the very helpful post. I wandered in here and was hoping your solution might work for me. I don't use a doc generator such as TypeDoc, but hoped your approach might enable intellisense in VS Code, which is what I'm after.
Perhaps TypeDoc uses a different mechanism from the VS Code language server? Anyway, here's my trivial reproduction, with intellisense failing to show inline documentation for the name property. Can you confirm this is / is not what you'd expect here?

Before seeing your post, I was in the habit of doing this:
type User = z.infer<typeof UserSchema>

... Which as you know, also doesn't work 😏
Thanks for any extra commentary you can provide.

@ian-schu That is strange because it does work for me.

z.infer is fine too. Only reason I used interfaces is because typedoc skips arbitrary type aliases by default.
If you could share this snippet in a gist/repo I can try to reproduce locally.

Thanks @lorefnon for the quick reply, and sorry it's taken me so long to get back to this. Good news: I think you're right. I cannot reproduce the original problem. When I try, my TSDoc gets replicated to the inferred type without any problem:

@tonyxiao A workaround that has worked well for me is defining interfaces that extend types extracted from zod types and then documenting them through typedoc. This post has a few examples. It has caveats but mostly works well in practice - this library has its documentation generated in this manner.

Has there been any advance on this? I am trying to export zod using typedoc but as it mentions in the post it doesnt work with unions or intersections

Yes but when you have some case like this:
const age = registry.register('age',
  /**
   * Info about age
   */
  z.number()
  .min(15)
  .max(20)
  .openapi({
    example: 18,
    'x-faker': 'number.int({ "min": 1, "max": 20 })',
    description: 'some desc here'
  })
)
export type Age = z.infer<typeof age>

const UserSchema = registry
.register('User', z.object({
  name,
  age
}))
export type User = z.infer<typeof UserSchema>

as you can see the age is referenced in the UserSchema object. Then you won't get the comment of typedoc/jsdoc.
Can we do something to make it work as well?

Since this comes up as the top google result for zod jsdoc, I thought I would add the actual answer here.
Given a schema:
export const TaskSchema = z.object({
    ...
});

Define the inferred type with:
/** @typedef { z.infer<typeof TaskSchema> } Task */

@JacobDanton This is fine if you are using jsdoc comments for typechecking in js files.
But for documentation generation (the primary purpose of jsdoc) it is not useful at all because it does not convey anything about the shape of the expected structure to the API consumer looking at the generated documentation.

@lorefnon  It does in my testing. For example, if I have:
export const MyTestSchema = z.object({
  /** This is a foo */
  foo: z.string(),
});

/** @typedef { z.infer<typeof MyTestSchema> } MyTest */

/** @type {MyTest} */
const test = { foo: "foo" }

Then on hovering over test.foo, I get:


GUACAMOLE-220: Add database support for user groups.

These changes add support within the guacamole-auth-jdbc-* schema for user groups, providing group-based inheritance of permissions. There are a number of changes involved, though most significant schema refactor is the switch from guacamole_user to guacamole_entity as the basis for assigning permissions. Each entry in guacamole_user and guacamole_user_group has a corresponding entry in guacamole_entity, allowing permissions to be assigned to each without duplicating the structures involved.
Upgrading MyBatis was also necessary in order to make use of features which allow reuse of SQL fragments, which required a corresponding upgrade of Guice and Guava.
To facilitate testing, I have written WIP tests for the REST API which exercise the various queries involved, including a utility script which forces creation of the database using the schema scripts of the previous release plus the upgrade script for the current release. Not part of this change, but may come in handy:
https://github.com/mike-jumper/guacamole-client/tree/rest-test

Will try to go through the mere 8,000 lines this weekend...
@ceharris @jmuehlner @flangelo @darchons, please feel free to jump in and review if you're so inclined!

@mike-jumper There are some issues merging these changes back to master - specifically, a conflict in the RemoteAuthenticatedUser.java file.  Should I manually resolve issues and continue it, or do we need to do anything special?

I don't believe there's anything special needed. What is the conflict?

First:
<<<<<<< HEAD
import java.util.HashMap;
import java.util.Map;
=======
import java.util.Collections;
import java.util.Set;
>>>>>>> staging/1.0.0

And then:
<<<<<<< HEAD
     * Arbitrary attributes associated with this RemoteAuthenticatedUser object.
     */
    private Map<String, String> attributes = new HashMap<String, String>();

    @Override
    public Map<String, String> getAttributes() {
        return attributes;
    }

    @Override
    public void setAttributes(Map<String, String> attributes) {
        this.attributes = attributes;
    }
=======
     * The identifiers of any groups of which this user is a member, including
     * groups inherited through membership in other groups.
     */
    private final Set<String> effectiveGroups;
>>>>>>> staging/1.0.0

When I finish resolving the conflict I end up with this at the top of my "git log":

commit 658ce7884695cbe0c04b29f0b6fa365312dbe2fd
Merge: 3ff5812 8283135
Author: Nick Couchman<EMAIL_ADDRESS>Date:   Mon Oct 1 13:51:56 2018 -0400

Merge 1.0.0 changes back to master.

Conflicts:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/RemoteAuthenticatedUser.java

If the conflict can be easily resolved, it should be safe to move forward. If you're worried about resolving the conflict, there is actually an issue with the GUACAMOLE-524 changes with respect to RemoteAuthenticatedUser for which I was about to reopen the issue in JIRA. There's a chance that resolving that problem will remove the conflict.

The conflict is pretty easily resolvable, so I'll just move forward with that, and then we can fix the -524 changes separately.

Sounds good to me.

Done.


Closes immediately after launching on W10

Version
1.13.0
Platform
Windows 10
Steps to reproduce

Download v1.13.0 (I think mine self-updated from an older version; I did replace the whole folder with a manually downloaded release in an attempt to fix the issue)
Double-click on the .exe
Wait
For a few seconds the border of the app appears

Then the app closes immediately without trace

Details
The app should start.
The app should not close.
Checklist

[X] I have looked through existing issues to make sure that this bug has not been reported before
[X] I have provided a descriptive title for this issue
[X] I have made sure that this bug is reproducible on the latest version of the application
[X] I have provided all the information needed to reproduce this bug as efficiently as possible
[ ] I have sponsored this project
[ ] I have not read any of the above and just checked all the boxes to submit the issue
[X] I have sacrificed a rubber duck to the coding gods, but my prayers were unanswered
[X] I have consulted with my cat, who also couldn’t solve the issue
[X] I am 90% sure this bug is related to the alignment of the planets
[X] I have questioned if this bug is just a feature in disguise
[X] I have asked ChatGPT for help, and now we’re both confused
[X] I have consistently maintained the belief that pineapple does not belong on pizza

Might be related to #455

Did the previous release work?

Did the previous release work?

I am sure it worked as I used it right before it updated.
Not sure what version it was though. It's been a while but I doubt it was too old.

Windows 11 here. 1.12.2 works. 1.13 doesn't.

Same problem happens here, Win 11 with 1.13.0.
But solved when I start it with administrator privileges.

I still can't reproduce the error, and I don't see anything in the commit history since last release that could potentially be responsible for this.
Are there any messages in the event log after the crash?

Are there any messages in the event log after the crash?

If I knew where the logs were, I would have checked them.
Actually, it was the first thing I tried to do.

But solved when I start it with administrator privileges.

I can confirm that this works.

If I knew where the logs were, I would have checked them.
Actually, it was the first thing I tried to do.

Press the Win key, type "Event Viewer", then go to "Windows Logs" -> "Application", and look for anything related.

Okay so there are three events, one of which is an error.
Log Name:      Application
Source:        Windows Error Reporting
Date:          06/09/2024 22:33:49
Event ID:      1001
Task Category: None
Level:         Information
Keywords:      Classic
User:          N/A
Computer:      [Redacted]
Description:
Fault bucket<PHONE_NUMBER>411740047, type 5
Event Name: BEX64
Response: Not available
Cab Id: 0

Problem signature:
P1: YoutubeDownloader.exe
P2: <IP_ADDRESS>
P3: 66960000
P4: ntdll.dll
P5: 10.0.19041.4522
P6: 8a1bb6f3
P7:<PHONE_NUMBER>08cc5f
P8: c0000409
P9:<PHONE_NUMBER>00000a
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER957E.tmp.WERInternalMetadata.xml

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_YoutubeDownloade_d0292095a9fbdee3d4df18c1a2f81e524a3c4db_d274d6a5_734398c6-15f9-4f76-8ac3-c7c0e356fcba

Analysis symbol:
Rechecking for solution: 0
Report Id: 83d77eef-892b-446d-850c-1cc33eb003ef
Report Status: 268435456
Hashed bucket: 3cfc5dcbf6f0e29700cf3d99c3e3f58f
Cab Guid: 0
Event Xml:

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Windows Error Reporting" />
    <EventID Qualifiers="0">1001</EventID>
    <Version>0</Version>
    <Level>4</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-09-06T20:33:49.6205495Z" />
    <EventRecordID>333283</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>[Redacted]</Computer>
    <Security />
  </System>
  <EventData>
    <Data>1211254555411740047</Data>
    <Data>5</Data>
    <Data>BEX64</Data>
    <Data>Not available</Data>
    <Data>0</Data>
    <Data>YoutubeDownloader.exe</Data>
    <Data><IP_ADDRESS></Data>
    <Data>66960000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.19041.4522</Data>
    <Data>8a1bb6f3</Data>
    <Data>000000000008cc5f</Data>
    <Data>c0000409</Data>
    <Data>000000000000000a</Data>
    <Data>
    </Data>
    <Data>
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER957E.tmp.WERInternalMetadata.xml</Data>
    <Data>\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_YoutubeDownloade_d0292095a9fbdee3d4df18c1a2f81e524a3c4db_d274d6a5_734398c6-15f9-4f76-8ac3-c7c0e356fcba</Data>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>83d77eef-892b-446d-850c-1cc33eb003ef</Data>
    <Data>268435456</Data>
    <Data>3cfc5dcbf6f0e29700cf3d99c3e3f58f</Data>
    <Data>0</Data>
  </EventData>
</Event>

Log Name:      Application
Source:        Windows Error Reporting
Date:          06/09/2024 22:33:48
Event ID:      1001
Task Category: None
Level:         Information
Keywords:      Classic
User:          N/A
Computer:      [Redacted]
Description:
Fault bucket , type 0
Event Name: BEX64
Response: Not available
Cab Id: 0

Problem signature:
P1: YoutubeDownloader.exe
P2: <IP_ADDRESS>
P3: 66960000
P4: ntdll.dll
P5: 10.0.19041.4522
P6: 8a1bb6f3
P7:<PHONE_NUMBER>08cc5f
P8: c0000409
P9:<PHONE_NUMBER>00000a
P10:

Attached files:

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_YoutubeDownloade_d0292095a9fbdee3d4df18c1a2f81e524a3c4db_d274d6a5_734398c6-15f9-4f76-8ac3-c7c0e356fcba

Analysis symbol:
Rechecking for solution: 0
Report Id: 83d77eef-892b-446d-850c-1cc33eb003ef
Report Status: 4
Hashed bucket:
Cab Guid: 0
Event Xml:

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Windows Error Reporting" />
    <EventID Qualifiers="0">1001</EventID>
    <Version>0</Version>
    <Level>4</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-09-06T20:33:48.3136258Z" />
    <EventRecordID>333282</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>[Redacted]</Computer>
    <Security />
  </System>
  <EventData>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>BEX64</Data>
    <Data>Not available</Data>
    <Data>0</Data>
    <Data>YoutubeDownloader.exe</Data>
    <Data><IP_ADDRESS></Data>
    <Data>66960000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.19041.4522</Data>
    <Data>8a1bb6f3</Data>
    <Data>000000000008cc5f</Data>
    <Data>c0000409</Data>
    <Data>000000000000000a</Data>
    <Data>
    </Data>
    <Data>
    </Data>
    <Data>\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_YoutubeDownloade_d0292095a9fbdee3d4df18c1a2f81e524a3c4db_d274d6a5_734398c6-15f9-4f76-8ac3-c7c0e356fcba</Data>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>83d77eef-892b-446d-850c-1cc33eb003ef</Data>
    <Data>4</Data>
    <Data>
    </Data>
    <Data>0</Data>
  </EventData>
</Event>

Log Name:      Application
Source:        Application Error
Date:          06/09/2024 22:33:47
Event ID:      1000
Task Category: (100)
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      [Redacted]
Description:
Faulting application name: YoutubeDownloader.exe, version: <IP_ADDRESS>, time stamp: 0x66960000
Faulting module name: ntdll.dll, version: 10.0.19041.4522, time stamp: 0x8a1bb6f3
Exception code: 0xc0000409
Fault offset: 0x000000000008cc5f
Faulting process ID: 0x72bc
Faulting application start time: 0x01db009c11e389d8
Faulting application path: G:\Programs\YoutubeDownloader\YoutubeDownloader.exe
Faulting module path: C:\Windows\SYSTEM32\ntdll.dll
Report ID: 83d77eef-892b-446d-850c-1cc33eb003ef
Faulting package full name:
Faulting package-relative application ID:
Event Xml:

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" />
    <EventID Qualifiers="0">1000</EventID>
    <Version>0</Version>
    <Level>2</Level>
    <Task>100</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-09-06T20:33:47.5796265Z" />
    <EventRecordID>333281</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>[Redacted]</Computer>
    <Security />
  </System>
  <EventData>
    <Data>YoutubeDownloader.exe</Data>
    <Data><IP_ADDRESS></Data>
    <Data>66960000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.19041.4522</Data>
    <Data>8a1bb6f3</Data>
    <Data>c0000409</Data>
    <Data>000000000008cc5f</Data>
    <Data>72bc</Data>
    <Data>01db009c11e389d8</Data>
    <Data>G:\Programs\YoutubeDownloader\YoutubeDownloader.exe</Data>
    <Data>C:\Windows\SYSTEM32\ntdll.dll</Data>
    <Data>83d77eef-892b-446d-850c-1cc33eb003ef</Data>
    <Data>
    </Data>
    <Data>
    </Data>
  </EventData>
</Event>

Thanks.

Faulting module name: ntdll.dll, version: 10.0.19041.4522, time stamp: 0x8a1bb6f3

Looks like the same issue as reported in #493.
I've checked the file details on my own nldll.dll and it has the following version: 10.0.22621.3733 instead. Although I doubt that it matters.
The 0xc0000409 exception code seems to indicate he system detected an overrun of a stack-based buffer in this application. This overrun could potentially allow a malicious user to gain control of this application, according to this.
My only guess so far is that a 3rd party package update caused this. I've created a test branch where I rolled back Avalonia and Avalonia-related packages to the version they were referenced at in version 1.12.2 of YoutubeDownloader. Please let me know if that has any effect.
https://github.com/Tyrrrz/YoutubeDownloader/actions/runs/10745256915

Nope, same issue.
Log Name:      Application
Source:        Windows Error Reporting
Date:          06/09/2024 23:52:40
Event ID:      1001
Task Category: None
Level:         Information
Keywords:      Classic
User:          N/A
Computer:      [Redacted]
Description:
Fault bucket<PHONE_NUMBER>555590815, type 5
Event Name: BEX64
Response: Not available
Cab Id: 0

Problem signature:
P1: YoutubeDownloader.exe
P2: 9<IP_ADDRESS>
P3: 66960000
P4: ntdll.dll
P5: 10.0.19041.4522
P6: 8a1bb6f3
P7:<PHONE_NUMBER>08cc5f
P8: c0000409
P9:<PHONE_NUMBER>00000a
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERC347.tmp.WERInternalMetadata.xml

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_YoutubeDownloade_6854b539c9db64528d1c5311f637c2517db_daa7cbb5_6557de66-cffe-45dd-95fe-f072ceda5a74

Analysis symbol:
Rechecking for solution: 0
Report Id: c0affed1-8400-4c39-b461-41ad97dea0aa
Report Status: 268435456
Hashed bucket: 2658abb4fdf1568a33e3a4d15d5f369f
Cab Guid: 0
Event Xml:

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Windows Error Reporting" />
    <EventID Qualifiers="0">1001</EventID>
    <Version>0</Version>
    <Level>4</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-09-06T21:52:40.2206471Z" />
    <EventRecordID>333290</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>[Redacted]</Computer>
    <Security />
  </System>
  <EventData>
    <Data>1433170325555590815</Data>
    <Data>5</Data>
    <Data>BEX64</Data>
    <Data>Not available</Data>
    <Data>0</Data>
    <Data>YoutubeDownloader.exe</Data>
    <Data>9<IP_ADDRESS></Data>
    <Data>66960000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.19041.4522</Data>
    <Data>8a1bb6f3</Data>
    <Data>000000000008cc5f</Data>
    <Data>c0000409</Data>
    <Data>000000000000000a</Data>
    <Data>
    </Data>
    <Data>
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERC347.tmp.WERInternalMetadata.xml</Data>
    <Data>\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_YoutubeDownloade_6854b539c9db64528d1c5311f637c2517db_daa7cbb5_6557de66-cffe-45dd-95fe-f072ceda5a74</Data>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>c0affed1-8400-4c39-b461-41ad97dea0aa</Data>
    <Data>268435456</Data>
    <Data>2658abb4fdf1568a33e3a4d15d5f369f</Data>
    <Data>0</Data>
  </EventData>
</Event>

Log Name:      Application
Source:        Windows Error Reporting
Date:          06/09/2024 23:52:38
Event ID:      1001
Task Category: None
Level:         Information
Keywords:      Classic
User:          N/A
Computer:      [Redacted]
Description:
Fault bucket , type 0
Event Name: BEX64
Response: Not available
Cab Id: 0

Problem signature:
P1: YoutubeDownloader.exe
P2: 9<IP_ADDRESS>
P3: 66960000
P4: ntdll.dll
P5: 10.0.19041.4522
P6: 8a1bb6f3
P7:<PHONE_NUMBER>08cc5f
P8: c0000409
P9:<PHONE_NUMBER>00000a
P10:

Attached files:

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_YoutubeDownloade_6854b539c9db64528d1c5311f637c2517db_daa7cbb5_6557de66-cffe-45dd-95fe-f072ceda5a74

Analysis symbol:
Rechecking for solution: 0
Report Id: c0affed1-8400-4c39-b461-41ad97dea0aa
Report Status: 4
Hashed bucket:
Cab Guid: 0
Event Xml:

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Windows Error Reporting" />
    <EventID Qualifiers="0">1001</EventID>
    <Version>0</Version>
    <Level>4</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-09-06T21:52:38.6319023Z" />
    <EventRecordID>333289</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>[Redacted]</Computer>
    <Security />
  </System>
  <EventData>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>BEX64</Data>
    <Data>Not available</Data>
    <Data>0</Data>
    <Data>YoutubeDownloader.exe</Data>
    <Data>9<IP_ADDRESS></Data>
    <Data>66960000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.19041.4522</Data>
    <Data>8a1bb6f3</Data>
    <Data>000000000008cc5f</Data>
    <Data>c0000409</Data>
    <Data>000000000000000a</Data>
    <Data>
    </Data>
    <Data>
    </Data>
    <Data>\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_YoutubeDownloade_6854b539c9db64528d1c5311f637c2517db_daa7cbb5_6557de66-cffe-45dd-95fe-f072ceda5a74</Data>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>c0affed1-8400-4c39-b461-41ad97dea0aa</Data>
    <Data>4</Data>
    <Data>
    </Data>
    <Data>0</Data>
  </EventData>
</Event>

Log Name:      Application
Source:        Application Error
Date:          06/09/2024 23:52:37
Event ID:      1000
Task Category: (100)
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      [Redacted]
Description:
Faulting application name: YoutubeDownloader.exe, version: 9<IP_ADDRESS>, time stamp: 0x66960000
Faulting module name: ntdll.dll, version: 10.0.19041.4522, time stamp: 0x8a1bb6f3
Exception code: 0xc0000409
Fault offset: 0x000000000008cc5f
Faulting process ID: 0x1710
Faulting application start time: 0x01db00a7119eea76
Faulting application path: G:\Programs\YoutubeDownloader.win-x64-test\YoutubeDownloader.exe
Faulting module path: C:\Windows\SYSTEM32\ntdll.dll
Report ID: c0affed1-8400-4c39-b461-41ad97dea0aa
Faulting package full name:
Faulting package-relative application ID:
Event Xml:

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" />
    <EventID Qualifiers="0">1000</EventID>
    <Version>0</Version>
    <Level>2</Level>
    <Task>100</Task>
    <Opcode>0</Opcode>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2024-09-06T21:52:37.7854069Z" />
    <EventRecordID>333288</EventRecordID>
    <Correlation />
    <Execution ProcessID="0" ThreadID="0" />
    <Channel>Application</Channel>
    <Computer>[Redacted]</Computer>
    <Security />
  </System>
  <EventData>
    <Data>YoutubeDownloader.exe</Data>
    <Data>9<IP_ADDRESS></Data>
    <Data>66960000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.19041.4522</Data>
    <Data>8a1bb6f3</Data>
    <Data>c0000409</Data>
    <Data>000000000008cc5f</Data>
    <Data>1710</Data>
    <Data>01db00a7119eea76</Data>
    <Data>G:\Programs\YoutubeDownloader.win-x64-test\YoutubeDownloader.exe</Data>
    <Data>C:\Windows\SYSTEM32\ntdll.dll</Data>
    <Data>c0affed1-8400-4c39-b461-41ad97dea0aa</Data>
    <Data>
    </Data>
    <Data>
    </Data>
  </EventData>
</Event>

What about this build? https://github.com/Tyrrrz/YoutubeDownloader/actions/runs/10761260851

“start as administer” works for me

“start as administer” works for me

Also works for my condition in windows 11.

Does this build work for anyone without admin privs?
https://github.com/Tyrrrz/YoutubeDownloader/actions/runs/10761260851

Does this build work for anyone without admin privs?
https://github.com/Tyrrrz/YoutubeDownloader/actions/runs/10761260851

Works for me.

Does this build work for anyone without admin privs?
https://github.com/Tyrrrz/YoutubeDownloader/actions/runs/10761260851

It works, but now i have the error Video watch page is broken. Please try again in a few minutes

It works, but now i have the error Video watch page is broken. Please try again in a few minutes

My bad, I didn't test it that far.
The same is happening for me.


Feat: Implement DepositEvents functions in the EventEmitter contract.

Description
Implement emit_deposit_created function in the EventEmitter library.
File: src/event/event_emitter.cairo.
Function signature:
   fn emit_deposit_created(
        ref self: TContractState,
        key: felt252,
        deposit: Deposit,
    );

Implement emit_deposit_executed function in the EventEmitter library.
File: src/event/event_emitter.cairo.
Function signature:
    fn emit_deposit_executed(
        ref self: TContractState,
        key: felt252,
        long_token_amount: u128,
        short_token_amount: u128,
        received_market_tokens: u128,
    );

Implement emit_deposit_cancelled function in the EventEmitter library.
File: src/event/event_emitter.cairo.
Function signature:
    fn emit_deposit_cancelled(
        ref self: TContractState,
        key: felt252,
        reason: felt252,
        reasonBytes: Array<felt252>,
    );```

## Acceptance criteria

- Function is implemented and well commented.
- Associated unit tests (nominal and failure) are implemented and passing.

## Resources
- [emitDepositCreated function in GMX repo](https://github.com/gmx-io/gmx-synthetics/blob/77a2ff39f1414a105e8589d622bdb09ac3dd97d8/contracts/deposit/DepositEventUtils.sol#L22)
- [emitDepositExecuted function in GMX repo](https://github.com/gmx-io/gmx-synthetics/blob/77a2ff39f1414a105e8589d622bdb09ac3dd97d8/contracts/deposit/DepositEventUtils.sol#L62)
- [emitDepositCancelled function in GMX repo](https://github.com/gmx-io/gmx-synthetics/blob/77a2ff39f1414a105e8589d622bdb09ac3dd97d8/contracts/deposit/DepositEventUtils.sol#L85)

Assigned


Not forcing to load lemmas for models without them

Trying to use tagger.py to annotate a new string using a model without lemmas caused an error, because tagger.load forced loading them. Just added an if clause.
PS: seems I messed the history again. Only last commit is an actual modification from current code…

you need to work differently basically : you need to branch out of the master branch of this repository instead of branching out of your own. Where upstream is hipster-philology, where origin is jbc
git checkout upstream master
git pull
git checkout -b my-new-branch

:)

Sure, I'll do that next time. Or does it prevents us from squashing and merging this time ?


Arrays in query strings with cross-fetch

"request" used the "qs" query string manipulation package and exposed its options in the requestOptions object.  One of these, the "arrayFormat" setting,  supported a variety of formats for an array parameter { a: [ "b", "c"] }
'indices'        a[0]=b&a[1]=c    (the default)
'brackets'      a[]=b&a[]=c
'repeat'         a=b&a=c
'comma'        a=b,c
With the switch to cross-fetch this flexibility was lost, as query parameters are handled by resolver_builder code that only implements the first format.

@thomsonbw I've also stumbled on this problem, the unfortunate issue is there is no standard way of handling arrays in query strings, there's a whole discussion about this here https://stackoverflow.com/questions/6243051/how-to-pass-an-array-within-a-query-string. I wonder if it might make sense to have a config that allows the end user to specify how they'd like their arrays processed

@eokoneyo we effectively had a config option before cross-fetch.  You could set the arrayFormat in the o2g requestOptions object and it would be passed through to the underlying package, but the current code doesn't provide similar flexibility.

@thomsonbw Sorry for the very late reply. I'm also sorry that this functionality was lost. I'll try to look into this but if any of you have suggestions on how this could be resolved, I'd love to know.

@thomsonbw, I have opened a Pull request that adds an option for one of the other formats https://github.com/IBM/openapi-to-graphql/pull/453

It's true that there are many ways to define arrays in query strings, but URLSearchParams API uses the "repeat" format:
const q = new URLSearchParams()
q.append("test", "one")
q.append("test", "two")
q.append("test", "three")
q.toString() === "test=one&test=two&test=three"

It should at the very least support that.


Fibonacci Search in Julia | GSSoC'21 | Searching

💥 Proposal
Fibonacci Search in Julia
Have you read the Contributing Guidelines on Pull Requests?
YES

/assign


Artifact seems to be missing

Looks like the artifact for this repository is gone:
[error] sbt.librarymanagement.ResolveException: Error downloading wolfendale:scalacheck-gen-regexp_2.13:0.1.2
[error]   Not found
[error]   Not found
[error]   not found: /home/runner/.ivy2/localwolfendale/scalacheck-gen-regexp_2.13/0.1.2/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/wolfendale/scalacheck-gen-regexp_2.13/0.1.2/scalacheck-gen-regexp_2.13-0.1.2.pom
[error]   forbidden: https://dl.bintray.com/wolfendale/maven/wolfendale/scalacheck-gen-regexp_2.13/0.1.2/scalacheck-gen-regexp_2.13-0.1.2.pom

Has this been transitioned to another area?
I'm happy to fork this and host it under my mavencentral. Not sure if this is getting updates anymore 😕

@etspaceman I think this might be an issue with jfrog sunsetting bintray related things. I believe they still intend to host jcenter permanently as a read only store and this should be available there. Does this work if you remove the specific resolver for my bintray repo?

@wolfendale it does not work:
https://github.com/etspaceman/scalacheck-faker/pull/173/checks?check_run_id=2511186943

@etspaceman that error looks like it's for another library? scalac-scoverage-runtime?

@etspaceman I've gone through the process to get this onto Sonatype OSSRH, it's published but I'm waiting for the sync to maven central. Will keep an eye on it and at you when I notice it's there. It's published under a new version + groupId so you'll have to update that in your project but the code is identical.
I'm updating the README now to reflect the updated groupId and removed the resolver from the example.
Thanks for kicking me into doing this, it was sheer laziness that I'd never gotten around to publishing to maven central :)

Awesome! Thanks!

@etspaceman Looks like it's synced to the repo no although it doesn't appear in the search quite yet (apparently should show up in the next couple of hours) so I'm going to close this issue.
Thanks again


Support for [Range] attribute, or ability to easily support custom drawing attributes

It seems that to support built in attributes like this, I would need to override and re-implement most of the drawing logic in BaseNodeView.
It would be great if there is support for builtin attributes such as Range, Min, Max, etc.
Alternatively, if there's an easy way to make a custom attribute which allows us to override how it is drawn, that would be very useful.

Hello, this is the same issue as #87.
So same state: I'm making progress, but not there yet (still have the reload graph issue when a property is modified from a SerializedField inside a node)

Support of all builtin unity attributes have been added with the latest master, they will be available in the next published package version (1.3.0)
Note that to use the range attribute, you'll need a fairly large node as the default inspector only shows the slider on fields with a certain min width:

Otherwise, you can remove the label of the field using [InspectorName("")] on the field like so:


Not able to target World Props

Hello,
as described in the Descriptions i struggle to get most world props like "prop_veg_crop_orange" to register via ox_target:addModel.
Honestly i don't know if it's a GTA thing or a script thing as i can target others like "prop_truktrailer_01a" just fine.
Would love to know if it's a fixable bug, an error on my end or GTA being GTA, cheers!
example:
local models = {'ch1_09b_vines_38','ch1_09b_vineslmbs_39'}
local options = {}
table.insert(options, {     event = "restart_fruitfarm_oranges:harvest",     icon = "fas fa-seedling",     label = "Orangen Pflücken"   })
exports.ox_target:addModel(models, options)

love the new solution so far tho <3

ch1_09b_vines_38 doesn't seem to have a hitbox / collision, raycasts go right through it. Nothing I do can change how that works.

ch1_09b_vines_38 doesn't seem to have a hitbox / collision, raycasts go right through it. Nothing I do can change how that works.

so the best solution probably be a boxZone i guess, thanks for the answer!

Zones still require collision with something.


Update the Modrinth API to v2

Updates the usage of the Modrinth API to v2.
The relevant documentation can be found here.

Warnings

:warning:
This PR modified service code for modrinth but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @Insprill!

  Generated by :no_entry_sign: dangerJS against 3686b75d21ae48f83fc861419b1eecd2ca6e8799


Consider upgrading the code to be supported by AsyncAPI Parser-JS v2

Reason/Context
Parser-JS 2.0 (released as rc at this moment) is a completely new parser, with a lot of changes. The bigger ones are:

Completely rewritten to TS.
Implements the new parser-api, in particular, the version found in this PR.
Uses Spectral as parser/linter with the AsyncAPI ruleset.
Lots of other improvements, especially around Developer Experience.

Considering that Spectral now validates the documents before parsing, we had to update the interface for Schema parsers to separate validation from parsing. This change also introduced better errors and the way we handle them. (see this issue and related).
Description

Implement the new Parser-JS 2.0 Schema Parser Interface.

Note that Parser-JS v2 uses TypeScript so feel free to use it as well.

parser-js 2.1.0 is already supported.
PR for integration in react component is open: https://github.com/asyncapi/asyncapi-react/pull/758
Or do i miss something to do?

Yeah, I just was moving the issue from https://github.com/GreenRover/proto-schema-parser/issues/2 to here without even checking. Can be closed.

@GreenRover I created to crucial issues I consider should be done asap if we want to let people adopt the new protobuf schema format:

https://github.com/asyncapi/cli/issues/785
https://github.com/asyncapi/generator/issues/1033


WFS3 Update docstring should use "datetime" rather than "time" search parameter

Currently the WFS3 client collection_items method docstring lists time as a search parameter.
https://github.com/geopython/OWSLib/blob/d04d57f8ad3fa95bbfe5f166caf616095b6395b1/owslib/feature/wfs300.py#L134-L135
This, however, does not match the WFS3 spec which uses datetime as the parameter key.
http://docs.opengeospatial.org/is/17-069r3/17-069r3.html#_parameter_datetime
No code change is needed since collection_items accept any parameters via kwargs, but the docstring should be updated for clarity's sake.

Thanks @mattfung !


Error: uninitialized constant ActionMailer

After updating from 2.0.0 to 2.1.0 I get this error message when running the specs.
Before hook at vendor/bundle/ruby/2.6.0/gems/cucumber-rails-2.1.0/lib/cucumber/rails/hooks/mail.rb:3

Message:

    uninitialized constant ActionMailer
Did you mean?  ActionView (NameError)

Do you mean v2.1.0?
Do you use ActiveRecord.
A couple of bugs are currently fixed in master. I will cut a release soon, that affects people using rails but not AR

Do you mean v2.1.0? Do you use ActiveRecord?
A couple of bugs are currently fixed in master. I will cut a release soon, that affects people using rails but not AR

Yes, ActiveRecord is used and yes, I meant v.2.1.0 - updated description too.
Alright then, thanks for now.

If you're using AR then you shouldn't hit these bugs.
Can you follow the template and provide something reproducible.

I'm facing the same issue. Looks like this change is affecting: https://github.com/cucumber/cucumber-rails/pull/441/files#diff-d09a3470ddd8f22434f9777cfdaf3c0f
So if you don't require action_mailer in "config/application.rb":
# Pick the frameworks you want:
require "active_model/railtie"
 :
# require "action_mailer/railtie"

you will get the error.
Maybe it's good to bring back defined?(ActionMailer::Base) check.

This is a good point. But if you're using all the rails standards, then you shouldn't hit this error.
To my knowledge some of these were reverted a bit ago due to people having issues. The person who reverted some said at the time some could remain as forced and some optional. Making them optional again isn't a big issue. I'm just trying to understand if something else is going on here.
If the OP can paste us maybe his gemfile / stack it would help triage.

ActionMailer dependency should be optional (just like it is on Rails).
We're also hitting this issue, since our app doesn't use ActionMailer.
Could we wrap the hook in an if defined?(ActionMailer) conditional?

Fixed in master. Will be released in v2.2.0 available from tomorrow.


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.354

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.354


Implement filterIfDefined

Fixes #2282
Problem
Implement filterIfDefined to optionally filter compile-time queries
Solution
Followed directions on the ticket
Checklist

[x] Unit test all changes
[ ] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes
[x] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

Hey @chriseteka. I approved the review and you're good to merge.
Could you please also filterIfDefined to the documentation so people know about it? (right under ### filter probably)
You can do this as part of this PR or in a separate one.


Code of conduct

It was mentioned on the BOSC Discord chat that the project needs a code of conduct. A relatively hidden feature in GitHub is a tool to add a Code of Conduct for you - see https://github.com/fastqe/fastqe/community/code-of-conduct/new?template=contributor-covenant (or click through from Insights > Community > Code of Conduct).
This is probably a task for @lonsbio as owner of the project. Once added it's just a regular file so anyone can go to down on the customisation 😉 💥

Thanks for the tip @ewels  👏  - done!
https://github.com/fastqe/fastqe/blob/master/CODE_OF_CONDUCT.md


Add extra step to enable the Google+ API

If the Google+ API is not enabled for your web application client in the Google Developers Console, you will receive the message: Access Not Configured. The API (Google+ API) is not enabled for your project. Please use the Google Developers Console to update your configuration.
This is the only API needed for logcabin to work.

:+1:  Thanks


buildDirectory parameter doesn't work

Vite Plugin Version
0.8.0
Laravel Version
10.10
Node Version
18.17.1
NPM Version
10.1.0
Operating System
Windows (WSL)
OS Version
11
Web browser and version
Edge 116.0.1938.81 (Official build) (64-bit)
Running in Sail?
No
Description
buildDirectory parameter in vite.config.js (laravel({ buildDirectory: 'assets', ...} ...) is ignored for manifest.json, when trying to access website, it searches for manifest.json in the wrong location, it still uses the default location which is 'build' ignoring the 'assets' i defined.
the only way i found for it to change default build location was changing it at app boot (AppServiceProvider):
public function boot(): void
{
Vite::useBuildDirectory('assets');
}
Steps To Reproduce

change buildDirectory in vite laravel plugin / vite.config.js
npm run build
try to access website on a route which uses vite assets
problem: server can't find manifest.json (wrong location)

@xmoki as you have already noted, if you customize the build directory in your config...
mport { defineConfig } from 'vite';
import laravel from 'laravel-vite-plugin';

export default defineConfig({
    plugins: [
        laravel({
            buildDirectory: 'assets', // Customize the build directory...
            // ...
        }),
    ],
});

You need to tell Vite in Laravel about the new build directory in a service provider...
Illuminate\Support\Facades\Vite::useBuildDirectory('assets');

This is intentional behaviour and how we intend it to work.


git-repo: Add action to validate signing event PRs

This should use the same validation code that the signing event uses to produce a check for the PR
Validate that:

metadata is valid TUF metadata, correctly signed
the repository is historically coherent (version numbers etc)
metadata follows the playground rules (approved delegations, contains the custom fields we expect)
targets changes and metadata changes match

oops wrong repository


Weird use of enum in GeometryWidget.

https://github.com/NCAR/VAPOR/blob/d4d9fa403d20a9e9f4c372406d7596b472f3179d/apps/vaporgui/GeometryWidget.h#L21-L25
The use of enum is looking weird to me in GeometryWidget. This is because there are generally 2 usages of enum, and this code is sitting in between.
More specifically:

Enums are used for exclusive properties:

enum Color{ Black, Red, Yellow};

Here one item cannot be Black and Red at the same time.

Enums are used for mutually inclusive properties:

enum BoxProperty{ Clickable, Editable, Highlightable };

Here one box could be clickable and editable at the same time.
The usage in GeometryWidget seems to imply that this widget must be either 2D or 3D just like enum usage 1. At the same time no matter it's 2D or 3D, it could have a VECTOR property, just like enum usage 2. How to use this Flags is then very confusing.

Interesting.  I spent a little bit of time looking for information on this, but I didn't see anything that enumerators have 2 strict use cases.  Is there a style guide that you're referencing?
I'm adding John to the conversation because  the VariablesWidget works in the same regard, but with its enumerator containing {SCALAR, VECTOR, HGT, COLOR}.  I believe that SCALAR and VECTOR are mutually exclusive,  while HGT and COLOR are mutually inclusive.

There are certain benefits of following the 2 use cases.
With use case 1, you define the color of an item with syntax:
item.Color = Color::Yellow;

and you'll never give a color to item that is not previously defined.
With use case 2, you can manipulate bit values on every property and every combination is valid.
Using Enums sitting in between of case 1 and 2 will result in loss of these benefits.

I'm feeling that we should talk about this as a group at our next round-table.  We didn't consider this as a requirement when we wrote our first promoted widgets over the summer.
I believe this implies having two sets of flags in each of our promoted widgets; supporting exclusivity and inclusivity.


[FLINK-24251][table-common] Make default constructor of BinaryStringData construct an empty binary string again

What is the purpose of the change
In FLINK-23289 we add a not null checking for BinarySection. After the change the default constructor of BinaryStringData will now construct a BinaryStringData with null Java object and null BinarySection. This is different from the behavior before where the default constructor constructs an empty binary string.
Although BinaryStringData is an internal class, it might confuse some developers (actually I myself have been confused) if they build their programs around this class. So we should make the default constructor construct an empty binary string again without breaking the not null checking.
Brief change log

Make default constructor of BinaryStringData construct an empty binary string again

Verifying this change
This change added tests and can be verified by running the added tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure


Changed plot

Changed: opening text
Added:

Text about soup
ASCII art about soup

I was really out of ideas with these fairytale characters!

Did some minimalist change, did you want something else?


(node-resolve plugin) Could not resolve import "bwip-js"

Describe the bug
bwip-js could not be resolved in a fresh install of a Directus extension.
To Reproduce
npx create-directus-extension@latest
Choose the extension type :  hook
Extension : my-extension
Language : Typescript
Auto install dependencies : Yes
cd my-extension
npm i @pdfme/generator @pdfme/common

Change the content of src/index.ts by :
import { defineHook } from "@directus/extensions-sdk";
import { generate } from "@pdfme/generator";
import { Template, BLANK_PDF } from "@pdfme/common";

export default defineHook(({ filter, action }) => {
  const template: Template = {
    basePdf: BLANK_PDF,
    schemas: [
      {
        a: {
          type: "text",
          position: { x: 0, y: 0 },
          width: 10,
          height: 10,
        },
        b: {
          type: "text",
          position: { x: 10, y: 10 },
          width: 10,
          height: 10,
        },
        c: {
          type: "text",
          position: { x: 20, y: 20 },
          width: 10,
          height: 10,
        },
      },
    ],
  };

  const inputs = [{ a: "a1", b: "b1", c: "c1" }];

  generate({ template, inputs }).then((pdf) => {
    console.log(pdf);
  });

  filter("items.create", () => {
    console.log("Creating Item!");
  });

  action("items.create", () => {
    console.log("Item created!");
  });
});

Then run :
npm run build
The output :

<EMAIL_ADDRESS>build
directus-extension build

⠼ Building Directus extension...(node-resolve plugin) Could not resolve import "bwip-js" in<EMAIL_ADDRESS>using exports defined in D:\Projets\XXX\Extensions\my-extension\node_modules\bwip-js\package.json.
⠋ Building Directus extension...(node-resolve plugin) Could not resolve import "bwip-js" in<EMAIL_ADDRESS>using exports defined in D:\Projets\XXX\Extensions\my-extension\node_modules\bwip-js\package.json.
"bwip-js" is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency.
✔ Done
Expected behavior
An installation without problems of Pdfme in a Directus extension
Your Environment
- pdfme package(@pdfme/generator or @pdfme/ui): @pdfme/generator
- pdfme version: 3.2.2
- Operating system: WIndows 10
- Node.js version or Browser name & version: nodejs v 20.11.0

Your Error Log
⠼ Building Directus extension...(node-resolve plugin) **Could not resolve import "bwip-js"** in<EMAIL_ADDRESS>using exports defined in D:\Projets\XXX\Extensions\my-extension\node_modules\bwip-js\package.json.
⠋ Building Directus extension...(node-resolve plugin) **Could not resolve import "bwip-js"** in<EMAIL_ADDRESS>using exports defined in D:\Projets\XXX\Extensions\my-extension\node_modules\bwip-js\package.json.
"bwip-js" is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency.

Additional context
No response

The import of bwip-js need to be changed to bwip-js/generic, otherwise tsc is unable to resolve bwip-js.
https://github.com/metafloor/bwip-js/issues/306#issuecomment-1789669912

i have the same problem, because the schema uses bwip-js and not bwip-js/generic.
PS: @Kamalito75 i was implementating the same thing in directus lol

To resolve this issue, i did the following steps:
Clone the repository and install the bwip package from @bwip-js/node.
You may encounter some type-related issues, but those can be easily resolved.
Link the local version of the packages to your project using the following commands:
`
cd /path/to/your/project
pnpm link /path/to/pdfme/packages/schema
or
npm link /path/to/pdfme/packages/schema
`


Switch to use an encoded path for gltf-dataUri uris.

A uri.authority part can be legally lowercased and then will no longer
match actual filenames on case sensitive platforms.
Also update client and server npm packages because they are initially mismatched (breaks on clean clones).

Version 2.1.9 is published.


GUC - Solution Development

Solution Development:

[ ]  SA - Complete RS Mapping & Client Signoff
[ ]  SA - Complete RS Schema
[ ]  SA - Complete Sender Specific Development (eg. Task Scheduling, Automation of CSV File Creation, VBScript Automated CSV File Upload)
[ ] Integration Testing (if needed)
[ ] RS - Feature Request Testing (if needed)
[ ] Sender Acceptance Testing & Training

Completed initial draft of RS Mapping

Completed initial draft of RS Schema.


CT3 database not compatible with the newest mmseqs version

Description:
I am encountering an issue where the tool execution stops and works endlessly ('time update: running mmseqs2 against CDD with ORFs not annotated with HMMs') when using versions 15-6f452 and 14-7e284 of mmseqs2. However, the issue does not occur when using version 13-45111, where everything works as expected.
Steps to Reproduce:

Install mmseqs2 version 15-6f452 or 14-7e284.
Run the tool with the same input data that works with version 13-45111.
Observe that the tool execution stops and does not proceed further, effectively hanging indefinitely.

Expected Behavior:
The tool should complete execution successfully, similar to how it behaves with version 13-45111.
Actual Behavior:
The tool execution hangs indefinitely with no error message, requiring a manual termination.

Hi thanks for opening this issue.
I'm going to look into this more in depth later, but I wanted to give a quick answer based on a hunch.
I noticed that mmseqs2 will not work unless the database is created and queried with the same version of mmseqs2.
If you want to use the newer version of mmseqs2, try reinstalling/creating the Cenote-Taker 3 DBs with that new mmseqs2 version (change -o ct3_DBs to your database directory).
get_ct3_dbs -o ct3_DBs --hallmark_tax T --refseq_tax T --mmseqs_cdd T

It works! It turns out I was downloading a database with an older version of mmseqs than CT3 was using... After reinstalling it correctly everything runs as supposed to! Sorry for bothering you

No bother at all. I'm glad it worked! I'm considering opening an issue on mmseqs2, so they are aware.


Fixed escaping issues for LaTeX and added support for bibitem formatting depending on the output format

Hi, it seems that the project is already quite massive. I fixed some LaTeX rendering issues in this PR. In the original, some HTML formatting was hardcoded, it should work correctly now.

Thanks for you PR! They aren now correctly fixed.


Update - Added details of keyboard mapping

Just added the details onto the main Read Me under Optional adjustments!