It failed when I convert my own model

Before you open an issue, please make sure you have tried the following steps:

Make sure your environment is the same with (https://mace.readthedocs.io/en/latest/installation/env_requirement.html).
Have you ever read the document for your usage? Yes
The form below must be filled.

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
NDK version(e.g., 15c):r15c
GCC version(if compiling for host, e.g., 5.4.0):I don't know
MACE version (Use the command: git describe --long --tags):v0.8.1-143-gfc1c855
Python version(2.7): 2.7
Bazel version (e.g., 0.13.0):I don't know

Model deploy file (*.yml)
library_name: test
target_abis: [arm64-v8a]
model_graph_format: file
model_data_format: file
models:
mobilenet_v1:
platform: tensorflow
model_file_path: /home/user/wuyajun/model/output_graph.pb
model_sha256_checksum: a123ab19fc3048ac7a4fd5e37d819cc369cff8a80f55b5fdac25144ca0c5625c
subgraphs:
- input_tensors:
- Placeholder
input_shapes:
- 1,224,224,3
output_tensors:
- final_result
output_shapes:
- 1,6
runtime: cpu+gpu
winograd: 0
Describe the problem
It failed when I convert my own model
To Reproduce
Steps to reproduce the problem:
1. cd /path/to/mace
2. python tools/converter.py convert --config_file=/path/to/your/model_deployment_file

Error information / logs
Please include the full log and/or traceback here.
Logs as follow:

**********************************************
          Convert mobilenet_v1 model
**********************************************

INFO: Analysed target //mace/python/tools:converter (0 packages loaded).
INFO: Found 1 target...
Target //mace/python/tools:converter up-to-date:
  bazel-bin/mace/python/tools/converter
INFO: Elapsed time: 0.342s, Critical Path: 0.01s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action

Traceback (most recent call last):
  File "/home/user/wuyajun/mace_success/bazel-bin/mace/python/tools/converter.runfiles/mace/mace/python/tools/converter.py", line 300, in <module>
    main(unused_args=[sys.argv[0]] + unparsed)
  File "/home/user/wuyajun/mace_success/bazel-bin/mace/python/tools/converter.runfiles/mace/mace/python/tools/converter.py", line 145, in main
    output_graph_def = converter.run()
  File "/home/user/wuyajun/mace_success/bazel-bin/mace/python/tools/converter.runfiles/mace/mace/python/tools/converter_tool/tensorflow_converter.py", line 214, in run
    self.convert_ops()
  File "/home/user/wuyajun/mace_success/bazel-bin/mace/python/tools/converter.runfiles/mace/mace/python/tools/converter_tool/tensorflow_converter.py", line 256, in convert_ops
    % tf_op.type)
  File "/home/user/wuyajun/mace_success/bazel-bin/mace/python/tools/converter.runfiles/mace/mace/python/tools/convert_util.py", line 18, in mace_check
    raise Exception(msg)
Exception: Mace does not support tensorflow op type PlaceholderWithDefault yet
Traceback (most recent call last):
  File "tools/converter.py", line 1580, in <module>
    flags.func(flags)
  File "tools/converter.py", line 785, in convert_func
    convert_model(configs)
  File "tools/converter.py", line 711, in convert_model
    ",".join(model_config.get(YAMLKeyword.graph_optimize_options, [])))
  File "/home/user/wuyajun/mace_success/tools/sh_commands.py", line 530, in gen_model_code
    _fg=True)
  File "/usr/local/lib/python2.7/dist-packages/sh.py", line 1413, in __call__
    raise exc
sh.ErrorReturnCode_1:

  RAN: /usr/bin/python bazel-bin/mace/python/tools/converter -u --platform=tensorflow --model_file=/home/user/wuyajun/model/output_graph.pb --weight_file= --model_checksum=a123ab19fc3048ac7a4fd5e37d819cc369cff8a80f55b5fdac25144ca0c5625c --weight_checksum= --input_node=Placeholder --output_node=final_result --runtime=cpu+gpu --template=mace/python/tools --model_tag=mobilenet_v1 --input_shape=1,224,224,3 --dsp_mode=0 --embed_model_data=False --winograd=0 --obfuscate=0 --output_dir=mace/codegen/models/mobilenet_v1 --model_graph_format=file --data_type=fp16_fp32 --graph_optimize_options=

  STDOUT:

  STDERR:

Additional context
Add any other context about the problem here, e.g., what you have modified about the code.

Exception: Mace does not support tensorflow op type PlaceholderWithDefault yet

Have you ever optimized your model using TF tools transform_graph? please refer to https://mace.readthedocs.io/en/latest/user_guide/basic_usage.html

See #104 , close this issue now


Background color support for notebook cells

Hi Experts,
I'm using the notebooks in VS Code for lots of Data and ML work. Yes, we always have to create lots of cells in the notebook and edit them at the same time. So I think that it is possible to set up the cells using different background colors. For example, use light green as the Python code cell and use light blue as the Markdown cell, etc.
It may help us more rapidly locate the cell which needs to edit and can be used with cell tags together.

This can be customized by settings
"workbench.colorCustomizations": {
    "notebook.cellEditorBackground": "#fff"
  },


📅Weekly meeting (2020-02-10)

This is wg-outreach's regular quad-weekly meeting with varying agenda, usually presented by wg-outreach members. Mostly meant for wg-outreach regulars, but open for anyone who'd like to contribute to AMP outreach.
Meeting date/time (UTC)
17:00 (10am PT)
Instructions for joining the meeting
Please join us on Google Meet with this link.
Notetaker
@mrjoro
Agenda
Note: Add a comment on this issue to propose items for the agenda.

Nothing yet!

not urgent. But, if there's time:

Upcoming AMP Roadshows and the like

amp.dev in 2020

Migrate validator.ampproject.org
Normalize component reference docs
Localization
Modularize AMP Start templates

what else?

Project Upsilon - proposal for localizing amp.dev + co


Trim output diff on conditional bulk fields

What version of CUE are you using (cue version)?
Bisected from v0.2.2 to master, ended up with this being introduced in 7f52c107b61980629c4c0d6751386a8ce360ddb9 which I don't quite understand.
Does this issue reproduce with the latest release?
Yes
What did you do?
Tried to cue trim something that boiled down to this:
if true {
	test: [string]: _
}

test: test: _

or the very similar
for _ in ["ignored"] {
	test: [string]: _
}

test: test: _

What did you expect to see?
That the trim finished successfully
What did you see instead?
  {
      test: {
-         test: _
      }
  }
Aborting trim, output differs after trimming. This is a bug! Use -i to force trim.
You can file a bug here: ...

Just checked in a reimplementation of trim that happens to fix this (and many other issues).

Just checked in a reimplementation of trim that happens to fix this (and many other issues).

This issue has been migrated to https://github.com/cue-lang/cue/issues/649.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Fix pedantic C++ compiler warning

Not sure if this happens for anyone else, but it will probably at some point in time due to compiler upgrades.

From the commit message:
"warning: type qualifiers ignored on function return type [-Wignored-qualifiers]"
It pops up very often as transaction.h is included in so many places.

closing due to #1647


all: Correct use of time

Means the config is readable, and should fix dead-machine-monitor.
r? @danielg0
cc @Euphoride

Let’s do that in a follow up, this is already kinda big


[otel hooks] add functional means of adding custom attributes to metrics and tracing hooks

Currently it's possible to map flag metadata values to custom OTel attributes (see here). However this approach has limitations, as it can only map values 1:1.
We should implement something similar to the JS implementation, which allows consumers to provide a function that takes the flag metadata and returns OTel attributes.
We should add the same functionality to the Tracing hook.

Hi @toddbaert. I can try giving this a shot if that is okay?

@craigpastro than you for the interest 🙌
However, I already attempted this - https://github.com/open-feature/go-sdk-contrib/pull/311 Sorry for not referencing this in the PR 😞

Oh, whoops. I should have looked at the open PRs.


Slider not iniating

I'm using a slider and it won't initiate unless I reload while on the page. A alert will run but the script won't start until I reload the page.
I've tried embeding the javascript on the page on ready().
I've tried embed the javascript on page ready.
Barba.Dispatcher.on('newPageReady', function() { ..slider do things..
This also didn't work. Only on load will the slider
var work = Barba.BaseView.extend({
namespace: 'work',
onEnter: function() {
},
onEnterCompleted: function() {
$('.portfolio-slider').slick({ ....
Any help would be much apreciated.

Try using Barba.Dispatcher.on:
Barba.Dispatcher.on('newPageReady', function(currentStatus, oldStatus, container, rawHTML) {
    $('.portfolio-slider').slick({
        ...
    });
});

@kjbrum Thank you very much. You saved my life!

@dmcshehan It's listed on the events page. http://barbajs.org/events.html

I have another question. When I use Barba js on my website, php WordPress functions like "body_class()" isn't working. I think it's because ajax. What do you suggest?

@dmcshehan add body_class on your barba-container, instead of the body.


Why's it not working?

So after installing gef-extras, how am I supposed to know it worked?
There is no difference in gef. Just the same as before. Also is gef-extras supposed to colorize ASM source?

Issues are for reporting bugs.
If you can't set it up, ask on the Discord.


Does this allow for constant readings?

Looking for something that can do constant weight readings of a water cooler jug. Does this allow for that?

Sure, but you might want to take a look at the auto-tare stuff since that might interfere with the measurement if the weight you are measuring is very small (below 10 Kg). I would suggest either removing it completely or modifying it to never actually run (f.ex. by setting the limit to a negative number).

@daleyjem , could you publish here your results and modifications please?


ESM and jsdoc

Builds on PR #7, so I'd appreciate a review of that first, and I can rebase this as needed; but you can see just these changes by looking at its latest commit:

Enhancement: ESM distribution and point to source via package.json module
Refactoring: ESM in source; change Bezier functions to individual exports
Docs: Fix jsdoc item; Add jsdoc config
npm: Add rollup script; add jsdoc script and scripts/server for opening docs; update deps

I havent yet refactored to ES6 (with Babel) besides the modules (as proposed in my previous PR), as wanted to get your approval first.
I only converted the Bezier functions to individual exports (the ESM equivalent of exports instead of module.exports), though I could have done so in some other cases. If you are open to it, I believe that should probably be done as well so that importers only need import those functions/classes they want, but I can revert even the Bezier functions if you want.

Thanks for accepting the last pull... FWIW, it seems the owner of kld-intersections has given a lot of feedback on my initial PR, so we can see what comes out of it as far as meeting your needs. I have rebased this PR too though, if you do care to take these changes now.

kld-intersections has since integrated my linting and ESM changes, so if you end up utilizing their code, this PR should not be necessary (though there'd still need to be a simple Rollup routine).
As far as working on top of the UI, I still think svg-intersections' approach would be warranted, but the kld-intersections author did not want to include this, so I think there is indeed still a need for svg-intersections, whose API has the following advantages in making explicit the properties:

Ensure calling code is more readable and with a lesser burden on memory of argument order (e.g., shape('circle', {cx: 50, cy: 100, r: 300})), also possibly allowing for aliases (e.g., accepting radius or r).
Where arguments are optional, allows for only those arguments actually used to be passed in (no need for passing null to skip over an argument, for example).
When passing back objects, object destructuring allows for getting out only the properties desired (more cleanly and with less burden on the memory than array destructuring, e.g., const {radius} = circleProperties; rather than const [, , radius] = circleProperties).

I think you could even simplify further by allowing for just:
circle({cx: 50, cy: 100, r: 300});

I made my own shim for your approach as below, but it is not complete.
function shape ({shape, props}) {
  let args;
  switch (shape) {
  default:
    throw new TypeError('Unexpected shape ' + shape);
  case 'rect': {
    const {x, y, width, height} = props;
    args = new IntersectionArgs('Rectangle', [
      new Point2D(x, y),
      new Point2D(x + width, y + height)
    ]);
    break;
  } case 'circle': {
    const {cx, cy, r} = props;
    args = new IntersectionArgs('Circle', [new Point2D(cx, cy), r]);
    break;
  } case 'polygon': {
    const {points} = props;
    args = new IntersectionArgs('Polygon', [points]);
    break;
  }
  }
  return args;
}

Also I'd hope you could continue to expose Intersections.intersect as just intersect.
In short, I'd recommend taking a look at https://github.com/thelonious/kld-intersections/blob/development/lib/AffineShapes.js and https://github.com/thelonious/kld-intersections/blob/development/lib/Shapes.js to see if you think it is enough to just continue to follow the IntersectionArgs approach as I did above, or whether you want to ask of more hooks from the kld-intersections author.
Btw, he has already provided https://github.com/thelonious/kld-intersections/blob/development/lib/SvgShapes.js , so there is no need for a new shim for supplying SVG elements, unless you wanted an SVG-element version of intersect, e.g.:
svgElementIntersect(
    svgElementShape1,
    svgElementShape2
);

Intersection.intersect(
    SvgShapes.element(svgElementShape1),
    SvgShapes.element(svgElementShape2)
);


Fuse mount for regrid

Hey @internalfx please how possible is to add a fuse mountable point in regrid.
Going through this issue https://github.com/rethinkdb/rethinkdb/issues/2647  . I think there is a possibility of making rethinkdb mountable as fuse filesystem.  Please can you add a fuse mount point to it. We are not familiar with nodejs and c-sharp which are the two drivers available now for regrid . But i think with fuse it would be more easier and will adapt to most applications

@lavvy A regrid fuse driver is an interesting idea, but there are some issues.

Regrid does not follow the same "rules" as a traditional filesystem
A fuse driver is not currently something I can dedicate time to.


New exhibition status: temporary closure

Problem to be solved
Medicine Man is closing temporarily for refurbishment (from 21/5 to 24/6). We need to have a status that allows for this.
Example:

Acceptance Criteria

[ ] The status should appear on the promo and header
[ ] The status should use a different colour indicator to the 'Now on' status
[ ] Temporary closure info should display in a SERP
[ ] The reopen date should be changeable (in case work overruns and exhibition doesn't reopen on stated date)
[ ] The exhibition should not appear on What's On list while it is closed

Questions :question:

Would it be better to have generic status (Temporarily closed for refurbishment) than a specific one, and then put the specific dates in the Exhibition page itself?

Message should say Temporarily closed between 21 May-25 June 2018

SERP

There isn't a clear way to do this as far as I can tell.
https://github.com/schemaorg/schemaorg/issues/819
https://schema.org/OpeningHoursSpecification
There is some hint that not specifying the times of opening and closing implies shut for a period, but I'm not sold.
@gestchild how did we handle this for other closing dates?
Also as an FYI - are you aware you can specify opening hours in this format?
https://schema.org/openingHours


Adding dynamic (style-)classes to accordion

Could you away to parse (dynamic/template thingies with filters) classes from the accordion-group or accordion-heading to the compiled HTML?
I've hacked my way to add this feature by adding a attribute binding and added this to the template.
@@ -232,7 +232,8 @@ angular.module('ui.bootstrap.accordion', ['ui.bootstrap.collapse'])
     scope: {
       heading: '@',               // Interpolate the heading attribute onto this scope
       isOpen: '=?',
-      isDisabled: '=?'
+      isDisabled: '=?',
+      styleClass: '@'
     },
     controller: function() {
       this.setHeading = function(element) {
@@ -3801,8 +3802,8 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.position', 'ui.bootstrap

 angular.module("template/accordion/accordion-group.html", []).run(["$templateCache", function($templateCache) {
   $templateCache.put("template/accordion/accordion-group.html",
-    "
\n" +
-    "
\n" +
+    "
\n" +
+    "
\n" +
     "
\n" +
     "      {{heading}}\n" +
     "
\n" +

@cfrost You can accomplish this by creating a CSS class that targets the elements you want to style by class.  For example, to style a panel-heading you would do:
.my-panel-heading .panel-heading {
   background-color: blue;
}

and Implementation would be:
<accordion-group class="my-panel-heading"

Closing for now.


Adding example for DocumentList

A case came up on the discord where there would be a need to use the DocumentList, and it took a bit of time to get how to work with it in tandem with tool preferences so that Renoise would correctly load each item.
I've created an example from the solution and added it to the DocumentList definition.
Maybe this example would be better in the guide? Personally, I'd like having it here from a search standpoint, as this would be the first place I'd look for details on the DocumentList.
Also, I couldn't figure out how to supply constructor arguments to the custom Entry class here while also having Renoise be able to deserialize the document from disk using it, maybe there is a cleaner way than this create_entry helper?
I also found a type-typo on the ObservableStringList hint.

By the way, is there any way to achieve this exact document loading without having to define a class?

A version without class would need to use renoise.Document.create and renoise.Document.instantiate:
-- define a class model for our complex type for document items in the list
-- so that Renoise knows how to load it later our entries will have
renoise.Document.create("Entry") {
  name = renoise.Document.ObservableString(),
  path = renoise.Document.ObservableString(),
}

-- create new entry instances with the given data
---@return Entry
function create_entry(name, path)
  local entry = renoise.Document.instantiate("Entry")
  entry.name.value = name
  entry.path.value = path
  return entry
end

-- define a class model for our preferences which is using a list of entries
renoise.Document.create("MyPreferences") {
  list = renoise.Document.DocumentList()
}

-- assign a fresh instance of our main document as preferences
local preferences = renoise.Document.instantiate("MyPreferences")
renoise.tool().preferences = preferences

-- insert elements into the list using :insert(index, element)
-- we call our helper to create an instance of Entry
preferences.list:insert(1, create_entry("some name", "some/path"))

-- access entries by using :property(index)
print(preferences.list:property(1).name)

-- get the size of the list (you can use :size() as well)
print(#preferences.list)

-- loop over the list to print all entries
for i = 1, #preferences.list do
  local entry = preferences.list:property(i)
  print(i)
  print(entry.name)
  print(entry.path)
end

Re constructor, this should work:
-- implement a constructor that adds two optional string properties
-- note that while loading the document all arguments will be nil
function Entry:__init(name, path)
  renoise.Document.DocumentNode.__init(self)
  self:add_properties({
    name = name or "",
    path = path or ""
  })
end

The class version is a bit more verbose. also, the preferences should be a class then too?
-- define a class for our complex type for document items in the list
-- so that Renoise knows how to load it later
class "MyEntry" (renoise.Document.DocumentNode)
  -- implement a constructor that sets two string properties
  -- NOTE: when the document gets loaded, all arguments are nil!
  function MyEntry:__init(name, path)
    renoise.Document.DocumentNode.__init(self)
    self:add_properties({
      name = name or "",
      path = path or ""
    })
  end

-- define a preference class for our tool, which has a list of document nodes
-- we'll later add "MyEntry" instances to it
class "MyPreferences" (renoise.Document.DocumentNode)
  -- constructor creates a persistent list of document nodes as member
  function MyPreferences:__init()
    renoise.Document.DocumentNode.__init(self)
    self:add_properties({
      list = renoise.Document.DocumentList()
    })
  end

-- create our main document with a DocumentList element to hold the entries
local preferences = MyPreferences()
-- and assign it to our tool, so it gets loaded and saved with the tool
renoise.tool().preferences = preferences

-- somewhere later in your tool you may insert an entry to the preferences
preferences.list:insert(MyEntry("path", "name"))

-- loop over the list to print all entries
for i = 1, #preferences.list do
  local entry = preferences.list:property(i)
  print(entry.name, entry.path)
end

-- remove all but the last entry
while #preferences.list > 1 do
  preferences.list:remove(#preferences.list)
end

This doesn't look like lua anymore, so I vote for the class free version as example.

Makes sense, I modified the example to use the class-less solution. Think it can be merged now then.


Time out again and again

When I run /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
I get this error
fatal: unable to access 'https://github.com/Homebrew/brew/': Operation timed out after 0 milliseconds with 0 out of 0 bytes received Failed during: git fetch origin master:refs/remotes/origin/master -n --depth=1
I have open the vpn,what should I do?

@liuzexin Run git clone https://github.com/Homebrew/brew/ manually and speak to GitHub if it doesn't work as Homebrew cannot fix that.


Would you support Scala?

If draft support Scala as well, draft will be more Awesome.
Would you support Scala?

Yes! We're focusing on other efforts at this time, but we plan to have more language packs available, including Scala. Please feel free to write up a pack for Scala if you feel up to the task! :)

@applideveloper Here is some more information on creating packs: https://github.com/Azure/draft/blob/master/docs/packs.md

@michelleN Did you mean this https://github.com/Azure/draft/blob/master/packs/README.md ?
I can see #287  being discussed too and can see some details on https://github.com/Azure/draft/blob/master/docs/reference/dep-003.md as well!
But would like to understand better on how we could create custom packs for language-ecosystem like scala-sbt ?
Any reference for newbies ?
I would like to create a custom pack for scala (sbt-akka ecosystem)

DEP 003: Draft Pack Format goes into detail on how to create custom language packs. :)


Update Documentation

Fixes: #294
Proposed Changes

Updated index.md( I have added the Gifs & NWOC as Open Source Program)
Updated contribution.md

Additional Info

I haven't update team.md. Because it looks like

@anushbhatia May I change team.md or not ? Review my PR !! @smaranjitghose

make changes in this pr with team members

make changes in this pr with team members

Sure Sir !!

@smaranjitghose @anushbhatia Now documentation branch is updated as README

Fixes: #294
Proposed Changes

Updated index.md( I have added the Gifs & NWOC as Open Source Program).
Updated contribution.md.
Updated team.md. (Adding dynamic contributors no need to do it manually & deleting all contributors images and save some memory as well)

@anushbhatia May I change team.md or not ? Review my PR !! @smaranjitghose

Sure. Feel free to add your name brother!


Show focal distance or autofocus target input form interactively.

autofocus_target shows when autofocus_enabled is checked, and focal_distance shows when unchecked.

Thanks man!


Keep track of changes as CHANGELOG

I'd be nice to keep track of changes as CHANGELOG.
Thanks,
Hiromu

I found release notes in README (https://github.com/HazyResearch/metal#release-notes).
However, please consider to put these kinds of information into CHANGELOG.md as IMO it is the common practice.

Hi @HiromuHota, that's a great suggestion. The good news is that we're currently migrating MeTaL into a major revision of the main Snorkel project repo (v0.9 coming out at the end of July), and that repo is being written from the ground up with maintainability in mind. There will be automatic type checking, more comprehensive code coverage with unit tests, pip and conda installations, etc. And we'll also be more rigid about release schedules and documenting what changes between major and minor versions. Stay tuned! :)


Mistake in documentation

Under the Custom Configuration Loader section the following line -
task resque:pool:setup do
should probably be -
task "resque:pool:setup" do

Fixed, thanks.


Zero should go away when user starts typing

https://user-images.githubusercontent.com/68264080/144958184-d6d6b556-fd5a-40a3-b335-50220717b1ff.MP4

Verified this issue on dev app v2.0.68(410)


Fixed NoMethodError map for NilClass error on runkeeper.fitness_activities options

@coop : First, thanks for the awesome work :+1:
Recently, I ran into this issue when I do something like the following steps:
runkeeper = RunkeeperProfile.get_runkeeper_client '<some token>'
finish=Time.now
start=2.days.ago
options = {start: start, finish: finish}
runkeeper.fitness_activities options

I get the following error:
irb(main):007:0* options = {start: start, finish: finish}
=> {:start=>Wed, 11 Mar 2015 01:43:20 CET +01:00, :finish=>2015-03-13 01:43:20 +0100}
irb(main):008:0>
irb(main):009:0* runkeeper.fitness_activities options
NoMethodError: undefined method `map' for nil:NilClass
	from /Users/pareshsharma/Workspace/CRunkeeper/vendor/bundle/gems/run_keeper-0.0.5/lib/run_keeper/activity_request.rb:18:in `request'
	from /Users/pareshsharma/Workspace/CRunkeeper/vendor/bundle/gems/run_keeper-0.0.5/lib/run_keeper/activity_request.rb:34:in `request'
	from /Users/pareshsharma/Workspace/CRunkeeper/vendor/bundle/gems/run_keeper-0.0.5/lib/run_keeper/activity_request.rb:8:in `get_activities'
	from /Users/pareshsharma/Workspace/CRunkeeper/vendor/bundle/gems/run_keeper-0.0.5/lib/run_keeper/request.rb:18:in `fitness_activities'

P.S.
Also, I am working on using Time Scope while fetching activities from RunKeeper, hopefully I'll create a pull request sometime soon.

Hi @coop and @tatey !
Any chance this can be merged?

I'm sorry for not getting to this earlier - I haven't used this gem for quite some time. Glad to know that you're getting use out of it.

Thanks!


Added more resources to the article

I have added link to a genuine article regarding how to write good documentation

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Hey @ritulsriva
According to the style guide :

We won't accept a PR that only adds links to the "More Information:" section.

So I'll be closing this PR, feel free to open another PR though! 👍


Update final output for Hello world

closes #1434

@frankharkins @Eric-Arellano
I was super confused when re-running the notebook because I came across this cell in the notebook that I downloaded:
"# Check there are six observables.
If not, edit the comments in the previous cell and update this test."
After getting everything updated, I was going to ask about that cell and realized that it's not in the published version.  So that cell is clearly one that just exists to verify that everything gets updated when we make changes.
The problem is that it's in the downloaded version of the notebook and was super confusing to me as a user.  Is there any way we can fix that?  Clarify that that cell is for notebook verification and isn't actually part of the tutorial?

The problem is that it's in the downloaded version of the notebook and was super confusing to me as a user. Is there any way we can fix that? Clarify that that cell is for notebook verification and isn't actually part of the tutorial?

FWIW: I noticed in the Challenge this year that the intro lab does a nice job explaining the grader cells that appear in all notebooks -- they look like they aren't doing anything but are important and can't be altered. We should find the right language that goes along with each of the verification cells

The current plan is to remove the cells from the download, tracked by https://github.ibm.com/IBM-Q-Software/iqp-channel-docs/issues/1351.

The current plan is to remove the cells from the download, tracked by https://github.ibm.com/IBM-Q-Software/iqp-channel-docs/issues/1351.

OK - when that happens it'll be important that we don't use those to update anything.  It's probably obvious and maybe I'm the only one doing it, but it seemed so handy :)

when that happens it'll be important that we don't use those to update anything. It's probably obvious and maybe I'm the only one doing it, but it seemed so handy :)

Yeah, these testing blocks should solely be to verify, like "read-only".


[FEATURE] Improved resource reservation

Is your feature request related to a problem? Please describe.

Currently Harvester via RKE2 seems to reserve CPU / Memory based on percentage of total node capacity.
We should introduce logic to leverage a combination of minimum CPU / Memory count or percentage based on the node size.
Describe the solution you'd like

We should ideally have a minimal reservation for CPU and Memory in actual metric count.
If the node is smaller than the minimal requirements, then we should switch the reservation to using percentage of total capacity available on the node.
This should make the resource reservation more consistent across multiple clusters / nodes with different sizing.
Describe alternatives you've considered

Additional context

Verified this feature has been implemented.

Test Information

Environment: Baremetal DL160G9 5 nodes
Harvester Version: master-96b90714-head
ui-source Option: Auto

Verify Steps:

Install Harvester with any nodes
Login and Navigate to Hosts
CPU/Memory/Storage should display Reserved and Used percentage.
Navigate to Host's details
Monitor Data should display Reserved and Used percentage, and should equals to the value in Hosts.


Alt text on images opening from lightbox links

When a link is created that opens an image in a lightbox, there is no way to add alt text for that image. There needs to be a new field in the link dialog:

@JohnSmith-LT I think that works fine but I'll keep open until Ron has tested. Thanks

Thanks @FayCross

@JohnSmith-LT @FayCross have just tested this. John's fix is definitely an improvement given the Alt text option when choosing image from the menu didn't exist before and I can't see this breaking anything however a couple of things I noticed in testing...
Firstly if I wanted an image to open in a lightbox I would rarely link to an image in this way e.g. from a text link. I would typically just add the image to the text area at a reduced percentage, which then obviously provides an alt text option by default and opens the same image in a lightbox by default. I would also usually add the lightbox optional property and change the caption option to above or below image instead of none.
However I can see reasons authors might want to just use a text link to open an image in lightbox and I guess Fay added the issue based on real world examples too. So this raises the question if an author want to use a text link to an image in this way and then adds the alt text should we/can we also check if the lightbox optional property has been added to show captions and if so show the caption like it does when an image link is used instead?
Also if an author uses a text link to an image and chooses Lightbox but doesn't change the Type menu to Image and leaves it as the default of iFrame then that link to the image still works but obviously doesn't have the alt text and doesn't resize the image to fit the lightbox either. So is there a way to add help text/tooltip? e.g.

Finally this must be something I just haven't noticed before and is just a bit odd - when I click around in the link window I get a flashing cursor in different places depending on where I click e.g. see circled cursor above. Not a major problem just a bit odd?

@ronm123 good point about grabbing the optional property info about whether a caption should be used - that would be good to have too. I also agree about needing to make it clearer that you need to change from iframe to image to make sure the image is responsive etc. I initially forgot this last week when testing and it took a while to work out why it wasn't working as expected.

Rolled codebase back to 29th April and that strange flashing cursor still appears so it's not something introduced by new code @ronm123 but I've never noticed it before either... it happens all over the plugin. I will take a look to see if I can figure out why it is happening...

Figured out the flashing cursor @ronm123
Presumably, like me, you have accidentally hit F7 or have turned on this accessibility feature in Chrome:

Let's keep this open until I can get the Tip: in screen in the box as I think that's a very good idea.

I've added this tooltip now to the plugin so if you are both happy with this @FayCross and @ronm123 then feel free to close now.

@JohnSmith-LT That's great - works really well.


[Bug] All/Some anime episodes do not show or the sources...

It would be nice to add more sources or places to stream it fom servers, just in case some are down.

That's a very good Idea

thank you


mtlregion constructors

This was originally #165 but I pushed more than I wanted so here we go again.

Merging with a note that we want to revisit the naming for consistency with Metal.


Issue: Run Count and Total Tokens not updating

Issue you'd like to raise.
After a few hours, the number of runs and the token count stopped increasing in all my apps. New requests are being traced correctly and perfectly (langsmith is really helpful, I don't think I can use something else).
This might be caused by the fact that the 0.0.56 was released in the meantime.
Still after updating, I see no changes on the run & tokens count.
Any Idea about where this might come from ?
Thank you
Suggestion:
No response

Hi @EliasGit2017 thank you for raising. We had to temporarily pause aggregations like token counts to make some large infrastructure improvements and better scale to support all our users. We hope to resume this functionality this weekend

Makes sense, thank you and good luck with the improvements 👍🏻

Why is the Total Tokens in the project on my Langsmith still not updating?


Only set repo configuration on init

Setting the repository policy calls policy.SetPolicy in Kopia which involves repository scan. This is an
expensive operation if the repository has a lot of snapshots.
This commit changes Corso behavior to only call this on repository init and not on every connect.
Does this PR need a docs update or release note?

[ ] :white_check_mark: Yes, it's included
[x] :clock1: Yes, but in a later PR
[ ] :no_entry: No

Type of change

[ ] :sunflower: Feature
[x] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Test
[ ] :computer: CI/Deployment
[ ] :broom: Tech Debt/Cleanup

Test Plan

[ ] :muscle: Manual
[x] :zap: Unit test
[ ] :green_heart: E2E

we may need to revisit this later. It now means we can't update the config values at all because we never try to set them once the repo is created

Yep you're right. Didn't want to design that yet till we had a use case - but we could trigger "on-demand" as needed (either as a connect option or a new CLI option)


Update sbt to latest version

It was reverted due to problems with example applications startup. When updating check if the applications do work and if not - fix them.

due to some reason, starting from sbt v.1.8.0, slf4j logger class is not included into the jar-file...


Add sftp implementation

With OpenSSH 9.0 scp is now actually sftp under the hood. We should implement that.
The work around currently is to use the -O flag on scp.

This has now been added


OS std 测试集结果

测试的os 结果文件中，几乎都没有“commit” 类别的结果，如果使用bash的能够正常执行结束作为回答正确的标准，很难保证能够是正确回答了原始的问题比如下面的情况

原始问题
As a student, you are given a directory named log_files containing log files from multiple servers. The log files are named as "server1.log", "server2.log", etc. Each log file contains a list of errors observed on that server.
The error messages have a specific format: a timestamp followed by an error code and error message, separated by colons. For example:
2022-02-28T10:30:23Z:ERR0001:Permission denied.
2022-02-28T10:31:42Z:ERR0003:Failed to connect to the database.

Your task is to calculate the total number of errors with the error code 'ERR0003' found in all log files present in the log_files directory.
The answer must be an integer representing the total count of the 'ERR0003' error code in all log files.
init bash
echo "2022-02-28T10:30:23Z:ERR0001:Permission denied." > log_files/server1.log
echo "2022-02-28T10:31:42Z:ERR0003:Failed to connect to the database." >> log_files/server1.log

echo "2022-02-28T10:40:12Z:ERR0002:Invalid input." > log_files/server2.log
echo "2022-02-28T10:45:19Z:ERR0003:Failed to connect to the database." >> log_files/server2.log
echo "2022-02-28T10:50:28Z:ERR0003:Failed to connect to the database." >> log_files/server2.log"

这个任务的设计是多轮的，如果操作为 bash，agent 会得到 os 的 output；理想的解决方案应该是第一轮 echo，第二轮 commit。
假想一个情景，如果让一个人来做这个任务，最终你的目标应该是让他告诉你答案，而不是仅仅在 terminal 中打印一个数字。


PR: Convert optparse to argparse

Fixes #5639.
I tried to minimize the changes by keeping the return value from cli_options.py the same as it was before, even though parse_args returns one value instead of two.

@rlaverde, please review this one.

Thanks @csabella for your contribution!
Could add a simple test for this? I mean, like testing that running in a terminal that spyder --help returns part of a given string?

@ccordoba12   I added some tests for get_option.  I'm not sure if this is what you were looking for.  There is already a test_mainwindow which calls get_option.


remove -p in integration test in readme

we don't support run scheduler-scalingengine integration test in parallel

LGTM


nixos/screen: fix assertion to actually execute, noting confusing mkIf semantics

This PR is very ugly. Is there a better to do this?
Fixes https://github.com/NixOS/nixpkgs/issues/312194.
See https://github.com/NixOS/nixpkgs/issues/312194#issuecomment-2115239401 for explanation why the assertion currently fails to run.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

#312187 (comment) has a better suggested alternative. I'll do that.

No, that is worse. Using throw will abort the evaluation completely and not collect all assertions.

The code was before broken and didn't do what we expected it to do and we silently ignored peoples configs unlike what is written in the release notes.

I just got hit by this assertion, why does it need to exist?
Per convention, module settings are always guarded behind the enable option's value. We usually don't assert this.


ValidationError when calling the AssumeRole operation

Hi,
when I wanted to apply a request, I got the message "An error occured" Internal Server Error. I checked the Cloudwatch logs and saw the following error:
`
| 2021-09-24T12:09:39.481+02:00 |  HTTPServerRequest(protocol='http', host='xxxxx', method='PUT', uri='/api/v2/requests/b4d36699-ac14-44ea-a08e-2d9316472c01', version='HTTP/1.1', remote_ip='<IP_ADDRESS>')
  | 2021-09-24T12:09:39.482+02:00 | Traceback (most recent call last):
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/site-packages/tornado/web.py", line 1704, in _execute
  | 2021-09-24T12:09:39.482+02:00 | result = await result
  | 2021-09-24T12:09:39.482+02:00 | File "/apps/consoleme/consoleme/handlers/v2/requests.py", line 734, in put
  | 2021-09-24T12:09:39.482+02:00 | response = await parse_and_apply_policy_request_modification(
  | 2021-09-24T12:09:39.482+02:00 | File "/apps/consoleme/consoleme/lib/v2/requests.py", line 2612, in parse_and_apply_policy_request_modification
  | 2021-09-24T12:09:39.482+02:00 | await apply_changes_to_role(
  | 2021-09-24T12:09:39.482+02:00 | File "/apps/consoleme/consoleme/lib/v2/requests.py", line 882, in apply_changes_to_role
  | 2021-09-24T12:09:39.482+02:00 | iam_client = await sync_to_async(boto3_cached_conn)(
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/site-packages/asgiref/sync.py", line 444, in call
  | 2021-09-24T12:09:39.482+02:00 | ret = await asyncio.wait_for(future, timeout=None)
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/asyncio/tasks.py", line 455, in wait_for
  | 2021-09-24T12:09:39.482+02:00 | return await fut
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
  | 2021-09-24T12:09:39.482+02:00 | result = self.fn(*self.args, **self.kwargs)
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/site-packages/asgiref/sync.py", line 486, in thread_handler
  | 2021-09-24T12:09:39.482+02:00 | return func(*args, **kwargs)
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/site-packages/cloudaux/aws/sts.py", line 157, in boto3_cached_conn
  | 2021-09-24T12:09:39.482+02:00 | role = sts.assume_role(**assume_role_kwargs)
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/site-packages/botocore/client.py", line 386, in _api_call
  | 2021-09-24T12:09:39.482+02:00 | return self._make_api_call(operation_name, kwargs)
  | 2021-09-24T12:09:39.482+02:00 | File "/usr/local/lib/python3.8/site-packages/botocore/client.py", line 705, in _make_api_call
  | 2021-09-24T12:09:39.482+02:00 | raise error_class(parsed_response, operation_name)
  | 2021-09-24T12:09:39.482+02:00Copybotocore.exceptions.ClientError: An error occurred (ValidationError) when calling the AssumeRole operation: 1 validation error detected: Value<EMAIL_ADDRESS>at 'roleSessionName' failed to satisfy constraint: Member must have length less than or equal to 64 | botocore.exceptions.ClientError: An error occurred (ValidationError) when calling the AssumeRole operation: 1 validation error detected: Value<EMAIL_ADDRESS>at 'roleSessionName' failed to satisfy constraint: Member must have length less than or equal to 64
  | 2021-09-24T12:09:39.482+02:00Copy2021-09-24 10:09:39,482 - ERROR - tornado.access - [web.py:2239 - log_request() ] - 500 PUT /api/v2/requests/b4d36699-ac14-44ea-a08e-2d9316472c01 (<IP_ADDRESS>) 3161.34ms | 2021-09-24 10:09:39,482 - ERROR - tornado.access - [web.py:2239 - log_request() ] - 500 PUT /api/v2/requests/b4d36699-ac14-44ea-a08e-2d9316472c01 (<IP_ADDRESS>) 3161.34ms
`
It seems like my host-name in combination with the default admin is to long.
To Reproduce
Steps to reproduce the behavior:

Have a long domain / host-name?
Create a Self Service Request
Try to approve
See error

Expected behavior
to work
Additional context
Add any other context about the problem here.

duplicate of 9156

PR submitted: https://github.com/Netflix/consoleme/pull/9254


[GSSOC'23] Add Contribution Guidelines and Setup Procedure to README

Proposed Method: Add Contribution Guidelines and Setup Procedure to README
Description
This issue proposes adding a dedicated section in the README file to guide contributors on how to contribute to the GirlScript Summer of Code (GSSoC) project. The section should provide clear and concise instructions on how to make contributions, along with guidelines for coding style, documentation, and testing. Additionally, include a setup procedure outlining the necessary dependencies and steps to run the project locally.
To what class it belongs?: README File
Example Usage
Contributing
Thank you for your interest in contributing to the GSSoC project! To ensure a smooth and collaborative development process, please follow the guidelines below:
Getting Started

Fork the repository and clone it to your local machine.
Install the necessary dependencies by running npm install or pip install -r requirements.txt, depending on the project.
...

Guidelines

Follow the coding style and conventions specified in the project's style guide.
Ensure all code changes are well-documented and accompanied by appropriate test cases.
...

Testing

Run the test suite using the command npm test or python manage.py test.
Make sure all tests pass successfully before submitting your contribution.

Submitting Contributions

Create a new branch for your feature or bug fix using a descriptive branch name.
Commit your changes with clear and concise commit messages.
Push your branch to your forked repository.
Open a pull request with a detailed description of your changes and the problem it addresses.

We appreciate your contributions to the GSSoC project and look forward to your valuable input. Happy coding!

Hi , I am a contributor in GSSOC'23, Can you assign this issue to me


feat(useQuery): add reset method to returned useQuery object

Hello @TkDodo, is there any update on the state of this PR? Seems it was validated but not merged, is there anything left on which I can contribute to push this functionality forward? Thanks!

I'm not sure we should merge this tbh. The implementation is not the same as queryClient.resetQueries. I just called refetch directly, but that would bypass queries that are enabled: false for example.
Apart from "we have it for everything else", what's the use-case of getting reset returned from useQuery?

Hi again @TkDodo and thanks for the fast response :)
Use-case would be when a controlled error happens in the application, for example when a request fails and we want to reset the query without an error boundary. Also to avoid importing useQueryClient all over the application for it.
This is the implementation we have right now:
`const useResettableQuery = (...args) => {
const query = useQuery(...args)
query.reset = () => {
query.remove()
query.refetch()
}
return query
}`
Do we need to respect the enabled: false when calling explicitly a reset() method?
What would be the advantage of using queryClient.resetQueries against this reset() method?
Thanks again for the time and work!

Use-case would be when a controlled error happens in the application, for example when a request fails and we want to reset the query without an error boundary.

I don't quite understand that. If an error happens because a request fails, the query goes in to error state. You can decide if you show that error or not. If you reset the query, it will just refetch immediately. If you want to show a refetch button, I think you can just call refetch() because a query that has no data (because it error'd) will just go to hard loading state again ...

Do we need to respect the enabled: false when calling explicitly a reset() method?

yes, both ways (queryClient.resetQueries and reset) need to behave the same.

I think you can just call refetch() because a query that has no data (because it error'd) will just go to hard loading state again

This assertion has worked for me, didn't know that a query that has error'd forces the loading state of it. Looked around the documentation but couldn't find a [reference to it](https://react-query.tanstack.com/reference/useQuery#:~:text=the query succeeds.-,refetch,-%3A (options%3A { throwOnError%3A boolean)
Anyways, thanks again for the time! :)

Looked around the documentation but couldn't find a reference to it

A query that is fetching and has no data yet is in loading state - that's how loading state is defined. That it has an error or not is irrelevant for that definition :)
As it stands, I'm gonna close that PR because I don't see a good use-case for it, and it's not trivial to implement correctly for all cases.


[5.9] PackageModel, CoreCommands: fix build flags not passed

Motivation:
When computing SwiftTool/_buildParameters, command-line options that customize BuildFlags values are not merged with BuildFlags from the computed toolchain/destination.
rdar://106077959
Modifications:
Added mutating func append(_: BuildFlags) on the BuildFlags type for easier merging of multiple values into one, which is then used in SwiftTool/_buildParameters.

@swift-ci smoke test

@swift-ci test windows

@swift-ci test windows


Changing Socks Shop to Sock Shop

I'm changing Socks Shop to Sock Shop in apcera.md to conform to today's decision to standardize usage of "Sock Shop".  I am also updating files in microservices-demo repository under deploy/apcera to conform in separate pull request in that repository.

Please note that the conflicts should all be resolved to use singular "sock" instead of "socks"

@rberlind this PR has conflicts

Hi @jasonrichardsmith.  I saw that, but don't understand why they occurred.  I'm the only one to have edited the Apcera.md file and the conflicts should be resolved to use singular "sock" instead of "socks".  Is that something you can manually do?  Or can you suggest the procedure for me to fix it?
Thanks,
Roger

will close and re-open to see if the conflicts are resolved.

OK.  I was able to fix it.  Please go ahead and merge when you have time.
Thanks.


USB cable support

In the future, it would be great if you could implement USB cable support in addition to Bluetooth. Not everyone has a Bluetooth adapter on their desktop PCs, but everyone has a USB cable. Just a suggestion. Great project!

Hi @leonsk29, thank you for your suggestion. Unfortunately, there are currently no plans to add USB support in v1.0, but it could be considered in the future (no guarantees).
Just in case someone is interested in implementing USB support: Currently, the main functionalities rely on standard Bluetooth protocols, which provide built-in support for calling, SMS, and phonebook access. However, USB doesn't have the equivalent feature. To add USB support, we must develop a companion app and a USB driver on PC.


Prototype pollution - merge

When running an npm audit, the following vulnerability was discovered;
https://www.npmjs.com/advisories/1666
Overview
Versions of merge before 2.1.1 are vulnerable to Prototype Pollution via _recursiveMerge .
Remediation
Upgrade to version 2.1.1 or later

Ran into the same issue. Would be great if anyone could look into this.

The dependencies have been updated multiple times since this was reported. I can't see any issues when running npm audit so it seems like it's been solved 😄


Add threshold support to BinaryAccuracy

Hi,
I've recently found out that Keras V3 is missing support for threshold in BinaryAccuracy,
in contrast to old tf_keras (https://github.com/keras-team/tf-keras/blob/master/tf_keras/metrics/accuracy_metrics.py#L113)
The docstring was already present
threshold: (Optional) Float representing the threshold for deciding
        whether prediction values are 1 or 0.

Changes

[x] Add threshold argument
[x] Add test case for threshold argument

P.S. I did not create an issue for this, since this is a tiny one 🤷

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (5536dc5) 77.58% compared to head (d7218be) 57.29%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18538       +/-   ##
===========================================
- Coverage   77.58%   57.29%   -20.30%
===========================================
  Files         334      334
  Lines       32211    32305       +94
  Branches     6286     6298       +12
===========================================
- Hits        24992    18508     -6484
- Misses       5635    12377     +6742
+ Partials     1584     1420      -164

Flag
Coverage Δ

keras
57.29% <100.00%> (-20.21%)
:arrow_down:

keras-jax
?

keras-numpy
57.29% <100.00%> (+<0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

keras/metrics/accuracy_metrics.py
79.25% <100.00%> (+0.47%)
:arrow_up:

... and 181 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you for the PR!
To format the code, run sh shell/format.sh.

done


Use references for multiple used data Fields (refactoring)

We have several data fields which are used for multiple endpoints/object. These data fields are multiple times specified which causes redundancies and may result in inconsistency if only one data field is changed and the other is has been forgotten.
The following fields are affected:

duration / durationType
interestRateType
interestRate / rate
saronperiod
amortizationType / amortizationAmount / amortizationStart / amortizationPeriodicity / amortizationAccountNr (this should additionally solved as one object instead of many single data fields)
validFrom / payoutDate
validTo / maturityDate

Feedback SFTI Mortgage meeting:

lead Dominik together with MP.

Decicion:

implement with API spec refactoring in Q1/202


Fix project mining step name in README

The project mining step was called "Project Mining", but this was not consistent with the other steps, which follow the pattern "[verb] [noun]".

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #242   +/-   ##
========================================
  Coverage      78.1%   78.1%
  Complexity      467     467
========================================
  Files            59      59
  Lines          1338    1338
  Branches        219     219
========================================
  Hits           1045    1045
  Misses          201     201
  Partials         92      92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834de12...ef4e7e4. Read the comment docs.


Extension opens new terminal although its terminal still exists

Bug
Expected behavior
GIVEN a vscode-jest-runnter terminal is open
WHEN running tests through the extension
THEN the existing vscode-jest-runnter terminal gets used
Actual behavior
Under certain conditions vscode-jest-runner creates a new terminal
Steps to reproduce

Open a terminal
Run a tests through the extension -> a vscode-jest-runner terminal gets created
Close the terminal from step one
Run a test through the extension -> a new vscode-jest-runner terminal gets created, although the one from step 2 still exists

Thanks saying
Thanks in general for this nice extension! It improves my workflow :)

thx mate


no requirements file

a requirements file would be super helpful

As of right now, the only requirement is matplotlib, which has been added to the requirements.txt file.


Help: MaxSim/Colbert Calculation

First of all, really appreciate your work and this library. It's a tremendous help.
Following this example here: https://github.com/pgvector/pgvector-python/blob/master/examples/colbert/exact.py
I modified it a bit - and had embeddings be its own table, instead of an Array. Here are the django models.
class Page(models.Model):
    document = models.ForeignKey(
        Document, on_delete=models.CASCADE, related_name="pages"
    )
    page_number = models.IntegerField()
    content = models.TextField(blank=True)
    img_base64 = models.TextField(blank=True)
    created_at = models.DateTimeField(auto_now_add=True)
    updated_at = models.DateTimeField(auto_now=True)

    def __str__(self) -> str:
        return f"{self.document.name} - Page {self.page_number}"

class PageEmbedding(models.Model):
    page = models.ForeignKey(Page, on_delete=models.CASCADE, related_name="embeddings")
    embedding = HalfVectorField(dimensions=128)

I am wondering if you can give you a little guidance and confirmation that our implementation is correct?

from django.db import migrations

class Migration(migrations.Migration):

    operations = [
        migrations.RunSQL(
            """
            CREATE OR REPLACE FUNCTION max_sim(document halfvec[], query halfvec[]) RETURNS double precision AS $$
                WITH queries AS (
                    SELECT row_number() OVER () AS query_number, * FROM (SELECT unnest(query) AS query)
                ),
                documents AS (
                    SELECT unnest(document) AS document
                ),
                similarities AS (
                    SELECT query_number, 1 - (document <=> query) AS similarity FROM queries CROSS JOIN documents
                ),
                max_similarities AS (
                    SELECT MAX(similarity) AS max_similarity FROM similarities GROUP BY query_number
                )
                SELECT SUM(max_similarity) FROM max_similarities
            $$ LANGUAGE SQL
            """
        )
    ]

Really appreciate it!

Hi @Jonathan-Adly, I'd recommend checking the results against the results from the example script to check the implementation.


HAPI-129 review fields & add more tests

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (5cce0fc) 86.31% compared to head (05e0031) 92.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   86.31%   92.32%   +6.00%
==========================================
  Files          93       94       +1
  Lines        1483     1771     +288
==========================================
+ Hits         1280     1635     +355
+ Misses        203      136      -67

Files
Coverage Δ

hdx_hapi/db/dao/admin1_view_dao.py
88.00% <100.00%> (+17.62%)
:arrow_up:

hdx_hapi/db/dao/admin2_view_dao.py
89.65% <100.00%> (+19.28%)
:arrow_up:

hdx_hapi/db/dao/age_range_view_dao.py
84.21% <100.00%> (+10.29%)
:arrow_up:

hdx_hapi/db/dao/location_view_dao.py
85.00% <100.00%> (+13.00%)
:arrow_up:

hdx_hapi/db/dao/operational_presence_view_dao.py
93.18% <100.00%> (+31.81%)
:arrow_up:

hdx_hapi/db/dao/org_view_dao.py
86.36% <100.00%> (+14.36%)
:arrow_up:

hdx_hapi/db/dao/population_view_dao.py
94.73% <100.00%> (+34.21%)
:arrow_up:

hdx_hapi/db/dao/sector_view_dao.py
85.71% <100.00%> (+13.71%)
:arrow_up:

hdx_hapi/db/models/views/db_admin1_view.py
100.00% <100.00%> (ø)

hdx_hapi/db/models/views/db_admin2_view.py
100.00% <100.00%> (ø)

... and 36 more

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Flagging data for believable range for CLP

I have been making some summary tables for PWQN sites and have noticed that new sites (Tamasag and River Bluffs) have a bunch of erroneous data getting past QAQC. A lot of these data seem to be related to when a sonde was buried in sediment or out of the water.
Below is an example of pH data in April from Tamasag (points) and Legacy (black line). Some of the data is successfully being flagged (blue) but a considerable amount is getting past (red)

My guess is that because these sites are newer, the seasonal flag is rendered ineffective and since is does not violate the slope or sd flags, these data are allowed to pass.
Possible solution: We could create Poudre wide sensor spec ranges based on our four years of data and create some simple bounds for some parameters. ie pH in the Poudre is generally between 6 and 10 across all sites
Alternatively, these data just need to be flagged manually and these issues should be resolved for future years when the seasonal flag has better bounds.

I like the idea of creating a flag from parameter bounds based on our understanding of the system as you suggest here!

Did some investigating into this and found three parameters that I think this could be valid for: pH, SC and temp.
Overall, I have learned that most of these data occur when the sonde is out of the water but is either missed by site visit flag, was recording during storage or was not properly deployed in the stream.
pH is definitely the most obvious and I'm proposing the bounds 6 to 10. The plots below show all the pre 2023 data (raw) and 2023 data (current QAQC applied). We could be more aggressive on the bounds (see timeline) but hopefully this flag will cause the slope flag to actually flag more data.

For SC, I'm proposing the bounds 30 to 2500. Few sites in the PWQN get above 2200 unless they are logging when being stored with pH 4. However, boxcreek (ag trib) gets above 2200 so I think 2500 is conservative enough to remove the really erroneous data while not removing possible data. On the lower end, our most upstream sites usually hover around 40 SC. I also checked the City's sonde data up the canyon (final plot in the SC section) and it never got below 30 unless there was an outlier.

For Temp, I am proposing the bounds -5 C to 30 C. I opted to make the lower bounds the same as the sensor spec range but we could certainly consider making it 0 C if we wanted to. Our current QAQC seems to be good at removing this data already but may be a good thing to add for cleaning up former years of data (fewer/no field notes).

Thoughts? My thought for implementation is to add this anywhere where add_spec_flag is used. This appears to be the following sections of the targets workflow: make_threshold_table and all_data_flagged


fix bug in prepare relaease

This handles cases where the package is beign released for the first time. i.e there is no previously existing versions.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Verify integration with Vaadin Router

https://github.com/vaadin/vaadin-app-layout/tree/add-router-demo working app-layout demo with vaadin router.
The only thing is that router is not distributed via bower. Not sure if it should be merged.


cargo-edit: init at 0.1.6

Motivation for this change
cargo-edit is a tool that adds cargo add which is similar to npm install --save
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The darwin build fails, is that platform supported?

Looks like it was compiling rust:
The job exceeded the maximum time limit for jobs, and has been terminated.

Ah, so this is related to the Hydra-not-building rust thing. Then I think we can safely ignore it :)

It seems to require curl on darwin: https://hydra.nixos.org/build/51727976/nixlog/6


Move cross arch fix to v4

This is working on release/v3.0, needs to get ported to 4.0 (and then 5.0)

The diff makes no sense.


How to add extraplugins

Hi,
I want to add imageuploader https://ckeditor.com/cke4/addon/imageuploader
How can I do this?

Please have a look at the following answer https://github.com/chymz/ng2-ckeditor/issues/159. I'm sure that will help.

Hi @kzimny thx for answering but I got a problem when implements this
CKEDITOR.plugins.addExternal('imageuploader', './imageuploader/', 'plugin.js');
I already put the plugin into specific folder but it not accesible by ckeditor.
then I change my code into
CKEDITOR.plugins.addExternal('imageuploader', '/src/app/pages/article/imageuploader/', 'plugin.js');
still  not work

You are going to use a plugin written in php and that will not work with angular. Please look at https://github.com/chymz/ng2-ckeditor/issues/144


Thermal-only input files don't work

Due to issues with inlet verifiers, thermal-only input files currently do not work.

It looks like this will be fixed by https://github.com/LLNL/axom/pull/481

Yeah, I looked into fixing this, and decided it was worth it to just wait for this to come down the pipe and do it right.

Tested + confirmed to work with:

[ ] https://github.com/LLNL/axom/pull/495


dropdown not loading with images and phonenumbers

i am trying to implement ng-intl-tel-input  plugin but dropdown not loading with images and phonenumbers, no erros are showing.. please help

Pay close attention to the example implementation demonstrated in index.html:
https://github.com/hodgepodgers/ng-intl-tel-input/blob/master/index.html
The various css and js files are key for full operation, however, you will only need to use our minified distribution file instead of the inidividual source files for this module.

Pay close attention to the example implementation demonstrated in index.html:
https://github.com/hodgepodgers/ng-intl-tel-input/blob/master/index.html
The various css and js files are key for full operation, however, you will only need to use our minified distribution file instead of the inidividual source files for this module.


f-lte io and BGK Collision Restructuring

Design Review:
This was branched from dg_10m, and I propose to merge this new branch, dg_10m_f_lte_io-prototyping, back into dg_10m.
Description:
This branch primarily does the following:

Creates a new structure vm_lte, used within gkyl_vm_species to store moments/projection object/f_lte
Used in two places currently: (NEW) io of f_lte, and in the BGK collision routine to create f_lte.
New io flag (in the vm_species): output_f_lte

Additions:
New file: vm_species_lte. This contains the functions: (no gkyl_... since they are private to vm)
// Initialize species lte object.
void vm_species_lte_init(…);

// Compute necessary moments for f-lte creation
void vm_species_lte_moms(…);

// Compute f-lte
void vm_species_lte(…);

With the new struct:
struct vm_lte {
  struct gkyl_array *f_lte;

  struct vm_species_moment moms; // moments needed in the equilibrium

  // LTE distribution function projection object
  // also corrects the density of projected distribution function
  struct gkyl_vlasov_lte_proj_on_basis *proj_lte;

  long self_niter; // total number of iterations correcting self collisions

  // Correction updater for insuring LTE distribution has desired LTE (n, V_drift, T/m) moments
  bool correct_all_moms; // boolean if we are correcting all the moments
  struct gkyl_vlasov_lte_correct *corr_lte;
  gkyl_dynvec corr_stat;
  bool is_first_corr_status_write_call;
};

Tests:

The regression test has been added: rt_can_pb_neut_bgk_sodshock_1x1v_p2, this outputs f_lte

Other Notes:

Moments for f_lte are now calculated inside the f. This is to guarantee the moments are always populated and updated before creating f_lte. (So I removed the moment calls before the bgk routines)
No longer accumulated for BGK since this is done by the f_lte: species_coll_mom_tm : 0

Extra checklist:
[X] Does prototype PR Work?
[X] Unit test passes? (Checked ctest_canonical_pb_equilibrium  and ctest_corr_mj_integrated which are quite sensitive)
[X] Regression test passes?
[X] Is memory freed?

I think we just call the iteration count niter instead of self_niter.

I think we just call the iteration count niter instead of self_niter.

We originally named it this way to differentiate with eventual cross collisions. I'm hoping this will be soon added! Do we still want to change this?

I take your point, though this redesign does beg the question of how we should handle cross species collisions. It would be a lot more memory if you made another one of these objects for cross-species collisions, but would that be better? This object is nice and self-contained and it doesn't feel like it should know anything about cross-BGK moments. Or are you thinking cross-BGK will not use this object?


Shadow anomaly returns

About the PR

The inky haze exuded by a new anomaly is a new nuisance that the passengers of Space Station 14 may encounter. A new Shadow Anomaly that scientists may encounter is constantly generating puffs of black fog, through which it is impossible to see anything. Apparently, the fog itself is harmless, but what happens inside it is...
The only way to disperse the darkness is to use security flashes. Anything from stationary flash to flashbangs will do.
During the pulses, the anomaly gradually surrounds itself with a faint haze that barely grows. But once the anomaly reaches the supercritical phase, the haze will begin to rapidly take over everything it can reach, plunging it into impenetrable darkness.
And you will not be alone in this darkness.

in territory overrun by darkness you can find cute shadow cats, flora from another dimension, and shadow rifts - unstable points in space that teleport you not far from yourself. Portals you likely won't see face-to-face, as they're scattered by flashes, so they're designed to make trying to travel blind or across the map more confusing. But, even they will be identifiable by the eerie whispering sound they make.

 It does not spawn aggressive creatures that deal damage, but it greatly hinders movement on the station. If you let the darkness take over the territory, you will either have to navigate by map or by memory and pray you don't get lost.
Why / Balance

more anomalies to the god of anomalies.
Technical details
A new type of creature that can't be killed by anything other than flash exposure.
Create BaseKudzu prototype, and parented all type of kudzu to it.
Media
appearance and animations of the anomaly
https://github.com/space-wizards/space-station-14/assets/96445749/04950cdf-e0c7-43de-a8ba-5e445b97b699
darkness cleansing process
https://github.com/space-wizards/space-station-14/assets/96445749/ed7c66b6-1628-420e-99fc-cb1f62fce5d0

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

add: Darkness is coming. A new shadow anomaly added.

Reopened #20840 with fixes all bugs

Absolutely love the design and concept of this one, very good

This looks amazing

Prise the Ed, The Shadow BRINGER!

alan wake

On Discord the concern was raised that the cloudy shadow/smoke animations might be problematic for some people. Could you make it so the "reduced motion of visible effects" accessibility checkbox (accessibility.reduced_motion CVar) selects a static sprite instead?

This seems to require working with a visualizer, to change the state of the sprite depending on a parameter in the settings. I don't want to do that in this pr, as I don't have the knowledge and desire to do so. I will open a issue that describes this problem for the future.


Support custom description separator in full_description

Hi,
Here's a little piece of Quality Of Life improvement.
Hopefully both the feature and its implementation get a positive review :) As far as a feature spec goes, I wasn't sure about where to add it, so I'd like for the reviewer(s) to make a suggestion.

Thank you for the suggestion! What would you use this for? What's a typical value?
We're generally pretty reluctant to add surface area to our config, since it's already pretty wide, so we have a pretty high bar for new configuration settings we accept. And then, we generally want to see config succeed in a plugin first before pulling into core.
I'm closing for now, but feel free to re-open with further justification!

Hi,
Well, the way RSpec displays nested examples by default is just not that great. The space separator makes it very hard to read through the output. From my experience, on many non-trivial code bases, one will have multiple nested meta-examples (describe, context) and it comes in handy "separating" them visually in the "Failures:" summary.
Instead of an option, I had considered proposing changing the default separator from " " to ", " but that seemed a little bold.
What do you think about the default separator, what has been your experience with nested contexts? I know of several people who agree with me but then, that's not a good case for the feature :)

we generally want to see config succeed in a plugin first before pulling into core.

Now I've been quick at submitting a PR and didn't consider coming up with a plugin. It sounds like a nice solution, so I'll explore that meanwhile you hopefully get back at me with more insights :) Thank you!

Sorry I haven't replied yet, will take a look in the next couple of days!

Interesting, this hadn't occurred to me as a problem before, probably because I match on line numbers rather than spec names.
Definitely sounds like a good candidate for a plugin!

Hi, I totally missed your feedback from 7 months ago! Anyway, haven't had time for this but it still is a nice idea that might happen some day...


Release missing reference to <system_error>

Download package, convert to VS2019 and current 142 tools, build solution fails, pch appears to be missing #include <system_error>

Thanks for the report.
Fixed in this commit: https://github.com/walbourn/directxtkmodelviewer/commit/8adfe53b854abf8dff4ddf1bbd90a6ff65f52220


[BUGFIX] deleting product from tab

Tasks:

[x] done
[x] got feedback

Informations:

Q
A

Bug fix?
yes

New feature?
no

Tests pass?
none

Fixed tickets
none

Doc
none

ack


$TRANS_PROGRAM has grown too large for OS X

For the latest commits on the develop branch, I get the following error on OS X 10.10.3 with bash 4.3.33(1) installed via Homebrew:
line 3449: /usr/local/bin/gawk: Argument list too long

After a quick bisect, I found the culprit to be 467a56d:
> git checkout 467a56d  # develop~7
> make &>/dev/null && build/trans -b hello
build/trans: line 3449: /usr/local/bin/gawk: Argument list too long
> sed -nr "/'EOF'$/,/^EOF/{ /'EOF'$/b; /^EOF/b; p }" build/trans | wc -c  # get the length in bytes of $TRANS_PROGRAM
134262
> git checkout HEAD~1  # develop~8
> make &>/dev/null && build/trans -b hello
hello
> sed -nr "/'EOF'$/,/^EOF/{ /'EOF'$/b; /^EOF/b; p }" build/trans | wc -c
133861

The problem appears to be along the line of MAX_ARG_STRLEN (not sure about the OS X equivalent), limiting the max length of a single argument, which was once 2^17=131072 on Linux, but apparently the kernel moved on since I couldn't reproduce the bug on Ubuntu 15.04. The field-tested limit seems to be between 133861 and 134262, which is a little bit mysterious since 131072 is smaller than both. (Did I forget some heredoc quoting rule? Probably). At any rate, there's clearly a limit on the length of a single argument on OS X around 2^17, and $TRANS_PROGRAM is on the edge of exceeding it.

Thanks for bringing this issue up - system specific limit is something I wasn't aware of before.
On Linux kernel, the length limitation of a single argument is indeed MAX_ARG_STRLEN (131072) and this has never increased. You can test this easily with the following program:
#include <stdio.h>
#include <unistd.h>

#define LEN 131071

int main()
{
    char s[LEN + 1];
    int i;
    for (i = 0; i < LEN; i++)
        s[i] = 'x';
    s[LEN] = 0;
    return execl("/usr/bin/expr", "expr", "length", s, (char *)NULL);
}

Change LEN to 131072, the execl() call shall fail.
Just like you doubted, your estimation of $TRANS_PROGRAM isn't very correct. The actual lengths are 122233 and 122634 respectively, both did not exceed the MAX_ARG_STRLEN limit on Linux.
$ git checkout 467a56
$ make &>/dev/null && . build/trans -V &> /dev/null && expr length "$TRANS_PROGRAM"
122634
$ git checkout HEAD~1
$ make &>/dev/null && . build/trans -V &> /dev/null && expr length "$TRANS_PROGRAM"
122233

While Linux kernel does check for validity of erch argument length (https://github.com/torvalds/linux/blob/master/fs/exec.c#L477), the OS X kernel, XNU, as well as other BSD derivatives, does not perform such check for each single argument, so there is no real equivalent to MAX_ARG_STRLEN. XNU however, has a limitation on the maximum length of arguments, which is
#define	ARG_MAX		   (256 * 1024)	/* max bytes for an exec function */

as defined in <syslimits.h>.
It may seem a bit weird that the argument of length 122233 is fine but the one of length 122634 crashes, since both are far less than 262144, even if you count in all other arguments 'gawk', '-f'. However, every OS has its quirks. I did a simple grepping into XNU's source, it seems these spaces are reserved not only for argv[], but also for envv[] (http://www.opensource.apple.com/source/xnu/xnu-2782.1.97/bsd/kern/kern_exec.c , see L#3137-3330). I guess that's why we can't have a lengthier argument in its execve() call.
(Not familiar with BSD implementation, so far it's really just a guess. Any experts?)
I cannot tell at exactly what length $TRANS_PROGRAM could break on OS X; it is not solely about a single argument length, unlike Linux, as I explained above. Two straightforward solutions I can think of at the moment:

Abandon the lengthy argument wrapping; use shell built-in print to pipe the whole program to gawk. (I bet shell can take infinite arguments, as long as it's not a system call)
Reduce the size of the core program and keep it to 100KB or below.

Thanks for the clarification; I didn't expect env vars to be counted against ARG_MAX. Given that I'd go for shell builtins (yeah, as far as I know they are not limited by ARG_MAX). Speaking of limiting the program size, it's still possible to exceed ARG_MAX if a user in addition exports some long env vars (albeit unlikely).

Due fix in develop. Closing.


fix: Refactor Inline Styles of App.tsx to global.css

Pull Request
Description
This pull request addresses the issue of inline styles used in the App.tsx file. To improve maintainability and adhere to best practices, I've refactored these inline styles to use styles defined in global.css. This not only enhances readability but also promotes consistency across the application.
Changes Made

Moved inline styles from App.tsx to corresponding styles in global.css.
Updated references in App.tsx to use the new global styles.

Checklist

[X] Code compiles correctly
[X] Tested changes locally
[ ] Updated documentation if necessary
[ ] Code follows project style guidelines

Related Issues
Closes #77

@jordan-pieces MAde the changes


fix(aws): aws-ebs-csi-driver_kms, when addon is disabled

Pull request title
Fix aws-ebs-csi-driver_kms, when addon is disabled
Description
When setting enabled to False for aws-ebs-csi-driver addon, it's resource aws-ebs-csi-driver_kms still gets evaluated and fails
Checklist

[ ] CI tests are passing
[x] README.md has been updated after any changes to variables and outputs. See https://github.com/particuleio/terraform-kubernetes-addons/#doc-generation

Thanks for the fix !


[qnnpack] create a new port

What does your PR fix?
There was no port request for this project.
This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the libtorch port.
Related Works

nnpack #16344: has same dependencies
xnnpack #17064: has same dependencies

Which triplets are supported/not supported? Have you updated the CI baseline?
The project's CI only considers linux and osx.

x64-osx
x64-linux

Does your PR follow the maintainer guide?
Yes.

Applied vcpkg-cmake in 75e1f3608181c388900420dba6187202dc64eef6. But #17063 may break this port.
I will take care of it if this PR is merged first.

We should rerun this PR after PR https://github.com/microsoft/vcpkg/pull/17063 merged.

Thanks for your contribution!


Update credential_authorization.md

Current behavior

Proposed changes
just a small word change. that's it .

Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
[x] I have read and accept the Ockam Community Code of Conduct.
[x] I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@bhargavshirin while we still have to review this change. I'm adding the HACKTOBERFEST-ACCEPTED label so the contribution is counted by hacktoberfest bots before the end of October. Thank you for taking time to contribute 🎉


Trying out the ML.Net Tutorial - Get Started in 10 minutes and faults out when Training the Model Builder - Data Classification

System Information (please complete the following information):

Model Builder or CLI Version: Data Classification
Visual Studio Version (if applicable): 17.5.3

Describe the bug

On which page of the tutorial did you run into an issue (URL):
Clear description of the problem:
Attached is the log file. Trying "Get Started in 10 minutes Tutorial". Errors out when Training Model Builder - Data Classification

@beena26g Can you re-upload log file? It seems not appear under this issue

SentimentModel-IGYMET.txt

The log error indicates it can't obtain lock file access. Did you run as admin?
In the meantime, this error is not fatal error and you can resolve it by installing nuget packages manually. While we are working on resolving this issue, you can just install Microsoft.ML v2.0.0 via nuget manager as a work-around


Fix for field error handling bug

This is a fix to a bug when error handling resulting from serializing fields containing closure values.
@dgsb, this should be ready to review now. This is a replacement for #847. It has two distinct commits intentionally:

The first commit adds tests to identify the discovered issue in go test used in Travis CI.

This commit intentionally fails Travis CI to prove the bug is identified correctly.

The second commit is a minimal fix to the issue.

I removed the refactoring from #847 where the bug was identified.

@dgsb, this should be good to go... I intentionally kept it simple. Let me know if you'd like any changes.

@dgsb, @sirupsen, @stevvooe, want to let me know if this is what you wanted. It just adds a test for the newly-found bug, and then adds a fix for it.
The fix is simply string manipulation.
(FYI, my previous refactor of the big had been inaccurate... The old behavior was that if there was a new error, it appended only the last new error to the previous error list, otherwise, it emptied the error list.)

Hello @loren-osborn, thanks for your contribution. The fix looks correct to me. However I find the test case too complicated to be easily maintainable in the future. May I request a few changes on it ? Please look at the review.

I am working on an additional commit to add more granular independent tests, rather than removing the outer loop.

@dgsb, I believe I addressed all of your concerns with my test code. Please let me know if you would like me to change anything else.

@loren-osborn the fix is correct, but the test you've added is way too complicated to be usable when a modification on the source code cause its failure.
We really need to have simple (even simplistic) unit test so that we can easily identify what needs to be fixed when they are broken.

I’m sorry to learn my tests are so fragile. I will work on making simple, clear, concise tests for this

@dgsb, I don’t think I was able to simplify this very much, but think I made it a bit more clear. I also wasn’t able to find the fragility you alluded to. If you can tell me how the tests are failing, i’m happy to make them more robust.

Just a note, the three failing commits are supposed to be failing, since the fix isn’t applied until the final commit.

@dgsb, I took two more shots at clarifying, simplifying and fixing any fragility.

I think it is definitely more clear than before.
I did simplify the test some, by removing tests that are impossible to fail. but I also abstracted out some stuff, so I'm unsure if you feel it's an improvement.
I'm still unsure how these tests are fragile. Please point me to something that breaks them, and I'm happy to improve them.

I'm open to any suggestions, but at this point I feel a bit like I'm going in circles. I'm happy with the state of the PR now, but please offer more specific feedback if you think it needs more work.
Thank you,
@loren-osborn

I just noticed I left SlowTestWriter in this set of commits... it’s part of other pending changes i’m working on... Please review everything else, and I will have SlowTestWriter removed from this test series shortly.

Rebased this on master.
@dgsb, I would really appreciate any suggestions on how to make this suitable for merging. I made the tests as clear and simple as I was able, and am unaware of anything making them fragile. Please point any specifics you'd like me to change, and I'm happy to.

@loren-osborn the fix itself is something like 10 lines, and all the tests around are something like 400 hundreds lines. I think it is too wide and not needed for this fix. Can you write the tests with something like 50 lines ?
We need somehow to new test functions, one which ensures the error field is kept upon a call to WithTime and one which checks the error field is kept after another WithField with correct parameter is called.
I think that's really all we need here.


Fix machine creation from imageName

/kind bug
/kind regression
Fixes #48
Release note:

A regression in Machine creation from imageName is now fixed.

/assign @kon-angelo @dkistner


Fix #981, implement better filename parser

Describe the contribution
Implemements a new function in FS to parse an input file name from a user - CFE_FS_ParseInputFileName()
The new function produces fully-qualified output where the input may omit either a pathname or an extension.  These items will be  added from the specified defaults, if missing, and a complete fully-qualified filename will be output.
If the input is already a fully qualified filename, then the output is the same as the input (basically a copy).
This initially is used to provide better cross-platform startup  script processing, where module suffix may differ across platforms.  Only the "basename" of the filename needs to be specified in the startup script - everything else can come from defaults.
Fixes #981
Testing performed
Build and sanity test CFE.
Check startup with all combinations of filename in script - fully qualified, basename only.
Check startup with new default startup script that has basename only - works on both Linux (.so) and RTEMS (.obj) with no change.
Expected behavior changes
Easier switching between platforms - startup script does not need to change to account for the different suffix that different platforms use.
System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 (i686, QEMU)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

This also needs a rebase when next baseline is ready.  Commit for pre-review is in cc5c9689.

CCB 2021-02-17

This should be good to merge now.


Fix comparison order of train loss

If batch size > 1 and all of the losses are less than threshold,
RuntimeError raised from loss comparison block.

For example,
if loss is [ -10.1, -11.1 ] and threshold is -10.0
-> if loss < self.hparams.loss_upper_lim block raise error.
RuntimeError: Boolean value of Tensor with no values is ambiguous

@pplantinga could you have a look please?


Lanscape mode on iPad

Hello!
Can ECSlidingViewController be always shown in landcape mode on iPad and topViewController resized automatically like with standart splitViewController?
Thank you!

Hi @ghost, were you able to do this?? Thanks!


⚠ Samsung has degraded performance

In 3a40038, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2240 ms

Resolved: Samsung performance has improved in cf2640c.


CWL Secondary Files import not working for ../

If you have a primary descriptor in one folder, and then the secondary file is defined as something like ../another-folder/importedfile.cwl then we cannot find the secondary file due to some weird relative import issue.

Looks like some form of regression.
Can test by forking https://dockstore.org/workflows/github.com/NCI-GDC/gdc-dnaseq-cwl/GDC_DNASeq:master?tab=info and then refreshing

Two related issues here:

Github does not understand relative paths
Our recursive parsing code does not properly set the initial working dir

It is likely that WDL and nextflow would have this same issue.

This seems fixed in 1.5.2 at https://staging.dockstore.org/my-workflows/github.com/denis-yuen/gdc-dnaseq-cwl


Review binary numbers topic description and other resources

This involves checking the binary numbers topic description and other resources is correct.
Created after splitting #217.

Update the following paragraph from:
This unit and lesson explores how the binary system works and why it’s important to understand how data is represented.
To be:
This unit and lessons explore how the binary system works and why it’s important to understand how data is represented.


[DEV-10311] Storybook update

Updated Storybook to Version 7.

@iz-podpolja As discussed, I refactored the vite config a bit, splitting them into two separate ones. Could you have a quick look again?


CMake build error on Windows

I'm trying to build Box2D but I got this message while configuring:
You have called ADD_LIBRARY for library glfw without any source files. This typically indicates a problem with your CMakeLists.txt file
When I click to generate I get this error message:
CMake Error at Testbed/CMakeLists.txt:84 (add_executable):
Cannot find source file:
Framework/imgui.h
Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
CMake Error: Cannot determine link language for target "glfw".
CMake Error: CMake can not determine linker language for target: glfw
Any ways to fix this?

Turn off the option to build example.

Solved, thank you. But if I wanted to build the examples, how can I fix this?

You must install glfw.

But I have glfw installed on my computer.

Then you must in cmake option set where is installed glfw in your computer.

http://blog.csdn.net/sinat_23185975/article/details/53323241

No I'm pretty sure this is a bug in the CMakeLists.txt. It clearly tries to add these files:
# Define the framework files.
set(Testbed_Framework_SRCS
	Framework/DebugDraw.cpp
	Framework/DebugDraw.h
	Framework/imgui.h
	Framework/imgui.cpp
	Framework/Main.cpp
	Framework/RenderGL3.cpp
	Framework/RenderGL3.h
	Framework/Test.cpp
	Framework/Test.h
)

When only these files exist in the repo:
Framework/DebugDraw.cpp
Framework/DebugDraw.h
Framework/Main.cpp
Framework/Test.cpp
Framework/Test.h

I guess these tests haven't actually been run in a while!
You can remove those files from the Testbed_Framework_SRCS but it still fails in some glfw/CMakeLists.txt anyway. I think the CMake support hasn't been maintained.

Box2d is not maintained long time.

I didn't know that. There are still commits... Anyway is there a newer alternative?

By newer alternative do you mean that are you specifically looking for a fork that's has CMake support working for the Testbed for your platform, or are you looking for a newer alternative that has more general updates?
Just my two cents worth...
I ask because for the former, I think it's impressive that Erin's put together as much cross-platform support for the Testbed as he has. It's not as easy a thing to do IMO as supporting a cross-platform library especially since the Testbed depends on other projects like GLFW and GLEW. One certainly doesn't have to have the Testbed compiled and built in order to use the Box2D physics library. Erin could make the choice to just cut the Testbed out of the Box2D distribution and save himself the headache that it creates with keeping things like this up-to-date. I have no idea if he's considering that but I am for my fork.
As to the latter possibility, looking for more general updates, I've seen requests asking for new updates before but none that elaborated on what they'd like from the new updates. Erin seems like an incredibly smart guy who could potentially deliver a lot of other incredible things and I do myself wonder what sort of new things he might be considering. Perhaps the thing that impresses me the most about what he's done so far with the Box2D library however, is how few things I've been able to find that I'd consider bugs. It's a pretty solid library that way and I could see people arguing to leave good-enough alone. So if by updates one were looking for general bug fixes, then what would those be if not for building the Testbed?
Anyways, while I have opinions about this, I would sincerely like to hear more from other people about what their perspectives are on these things and what they'd like to see done for addressing them.

You can now build the testbed using Premake5. Please see Building.txt.

@louis-langholtz: I just had a vague recollection of a newer library that supported deformable bodies. Must have been thinking of LiquidFun but that is just an extension of Box2d anyway so never mind!


Updated credits for sample Remove wiki tab of teams

Updated credits for sample Remove wiki tab of  teams to include authors who inspired this sample.

Coverage remained the same at 100.0% when pulling a6cca5a3a11ec93948dbfab0f6be37bd5aee8f87 on rabwill:update/doco-sample into 9b70527cc776495e73e5644b2b271cb120a26871 on pnp:master.


Replace Github -> GitHub (Spanish)

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

After we merge all those.. I'll do a final check on the whole project again :)

@lynxlynxlynx It would be very helpful if you could review the following PRs which make changes to one or more of the same files on this PR.  Once all of those have been closed/merged, then we can resolve any merge conflicts that result on this PR.  We would really like to get this PR merged quickly since it affects so many files (43).  Thanks in advance.
https://github.com/freeCodeCamp/freeCodeCamp/pull/20857
https://github.com/freeCodeCamp/freeCodeCamp/pull/25138
https://github.com/freeCodeCamp/freeCodeCamp/pull/26280
https://github.com/freeCodeCamp/freeCodeCamp/pull/26477
https://github.com/freeCodeCamp/freeCodeCamp/pull/26611
https://github.com/freeCodeCamp/freeCodeCamp/pull/30207
https://github.com/freeCodeCamp/freeCodeCamp/pull/30715
https://github.com/freeCodeCamp/freeCodeCamp/pull/31763
https://github.com/freeCodeCamp/freeCodeCamp/pull/31778
https://github.com/freeCodeCamp/freeCodeCamp/pull/31927
https://github.com/freeCodeCamp/freeCodeCamp/pull/34099

Most are done, one requiring further work from the author and 3 being the ones touching how-to-setup-freecodecamp-locally.md: #31927 #30715 #25138 . Those need someone with a better command of the language.

@lynxlynxlynx Thanks for the fast turn-around for these.  Also, whoever reviews those 3 how-to-setup-freecodecamp-locally.md should validate the English master version has not changed enough to make any of the changes obsolete.

@lipis Don't worry about any merge conflicts until the other 4 PRs we are waiting on have been closed/merged.  I want to take care of any merge conflicts.

@raisedadead There are still 3 outstanding earlier PRs (#31927 #30715 #25138 ) which have changes to one or more of the same files as this PR.  They all already have merge conflicts and many of the documents' English version have changed significantly since these PRs have been created, so the translations may not even be relevant anymore.  My question is, can we go ahead merge this PR?

Yes please.


Fix for expired profile when token lifetime isn't used.  issue #1679

Before submitting any pull request, please read the contribution guide: http://www.pac4j.org/docs/contribute.html

Thanks for your contribution. You may want to open the same PR for the 4.2.x branch as well.