Modularize emscripten build.

By default, emscripten's generated javascript modules lives in the global object "Module'.
This makes it impossible to load multiple emscripten modules on the same page if they are all built using this default.
In attempt to avoid namespace collision, this change modularizes the emscripten build so the Module is instead called 'BASIS'. See the emscripten FAQ for more info: https://emscripten.org/docs/getting_started/FAQ.html
Many of the  target applications for Basis are possibly using other emscripten modules, so this change will reduce friction of adding Basis(assuming any of their existing modules are not modularized)
This will require existing consumers of this package to change how they load Basis when they next upgrade their Basis build.
Testing:
The existing webgl/(texture|gltf) pages have been updated to use the new name and seem to operate as before
(Built/tested on OS X with emscripten  sdk-1.38.29-64bit)

How was basis_transcoder.wasm rebuilt? It looks like in this build the settings from CMakeLists.txt from #7 aren't picked up, so the transcoder is back to being large.

Hmm, I'm not sure why this is.
I built using the instructions in the README(pretty much just emcmake ../ && make) and this change is off HEAD.
I noticed my version of emscripten is behind latest. I've upgraded to sdk-1.38.31-64bit but I'm not seeing any change to the output size.
Checking out origin/master and rebuilding also gives me the larger size so possibly something else is going on.
I'll continue investigating, thanks!

Ok this is my fault; my change in #7 didn't update CMakeLists correctly :( I'll make a patch for this.

Added #27, sorry about that!

No worries! I will rebase and update this PR once #27 is merged

This PR has been rebased with HEAD after #27's merge

Just want to make sure everything is fine with #27 - was the .wasm file rebuilt after rebase? GH seems to say that the .wasm file in this PR is still very large, but when I locally do this on a fresh Linux box:
$ git clone https://github.com/emscripten-core/emsdk
$ cd emsdk
$ ./emsdk install latest
$ ./emsdk activate latest
$ source ./emsdk_env.sh
$ cd ..
$ git clone https://github.com/prestomation/basis_universal
$ cd basis_universal/webgl/transcoder/build
$ emcmake cmake ..
$ make

I get this:
$ ls -la
-rw-rw-rw- 1 zeux zeux  61521 Jun 11 17:53 basis_transcoder.js
-rw-rw-rw- 1 zeux zeux 219388 Jun 11 17:53 basis_transcoder.wasm
$ cat basis_transcoder.js | head -n 2

var BASIS = (function() {

(the 200-ish KB .wasm file is what I'd expect, whereas this PR still has a ~500 KB file)

Sorry! I'm not used to checking in binaries. I had rebuilt, confirmed the size change,but did not checkin updated binaries. Will do so early tomorrow.

third time is the charm: updated binary now included

Could we please review and merge this? It's important for modularity of Basis Universal's WebAssembly build. Thanks!

Got it, thanks!


Docs?

Hello contributors.
Seeing as this repo is growing in size, I think it would be good to add a Documentation page that explain all the available BlogSettings or how to syntax highlight other files and whatever. Owing to the minimalist nature of this, a single DOCS.md page would be enough for me. RFC

author?: string; // your name
avatar?: string; // path to your photo
avatarClass?: string; // CSS classes to add to the avatar
canonicalUrl?: string; // how should your blog's URL look like to search engines
cover?: string; // path to your background cover
coverTextColor?: string; // color of the text on your background covor
dateStyle?: [DateStyle](https://doc.deno.land/https://raw.githubusercontent.com/denoland/deno_blog/main/types.d.ts/~/DateStyle); // self-explanatory
description?: string; // your blog's description
favicon?: string; // href to rel='icon'
footer?: [VNode](https://doc.deno.land/https://raw.githubusercontent.com/denoland/deno_blog/main/deps.ts/~/VNode); // footer JSX element
header?: [VNode](https://doc.deno.land/https://raw.githubusercontent.com/denoland/deno_blog/main/deps.ts/~/VNode); // header JSX element
hostname?: string; // your blog's hostname, e.g. localhost
lang?: string; // your blog's language code
links?: { // social links
title: string; // the link title
url: string; // the link URL
icon?: [VNode](https://doc.deno.land/https://raw.githubusercontent.com/denoland/deno_blog/main/deps.ts/~/VNode); // the link icon
target?:
| "_self"
| "_blank"
| "_parent"
| "_top";
}[];
middlewares?: BlogMiddleware[]; // the middleware you can setup to modify your experience, content and etc. before the blog is loaded
ogImage?: string; // path to open graph image
port?: number; // port to listen on
section?: VNode; // a JSX element, but idk what it is for
showHeaderOnPostPage?: boolean; // self-explanatory
style?: string; // custom CSS styles
theme?: "dark" | "light" | "auto"; // self-explanatory
title?: string; // <title>
unocss?: [UnoConfig](https://doc.deno.land/https://raw.githubusercontent.com/denoland/deno_blog/main/deps.ts/~/UnoConfig); // UnoCSS configuration

@roj1512 can you update the interface definition with these comments so it shows up on doc.deno.land?

Thanks, but I don't believe a newcomer might be able to discover all of that once by looking into the typescript types. maybe a link to deno docs

@vixalien here you are then:
https://doc.deno.land/https://raw.githubusercontent.com/denoland/deno_blog/main/types.d.ts/~/BlogSettings#Properties


networkmanager: 1.26.0 -> 1.30.0

Motivation for this change
Version bump.
I don't have the time/will right now, but it might be worth upstreaming the paths patch as build flags would probably make this a little easier to bump every time.
Notable changes: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/a592617717305943c129d63bc947fdeb00b431b0/NEWS
Fixes #115137.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I don't have the time/will right now but might be worth upstreaming the paths patch as build flags would probably make this a little easier to bump every time.

Sounds like a good idea, and I'm also fairly certain they wouldn't have a problem with that.

/rebase staging

Can do, will do it when I'm back near my laptop. Should it still be networkmanager, or NetworkManager to match VPN plugins and upstream mirror naming?

Can do, will do it when I'm back near my laptop. Should it still be networkmanager, or NetworkManager to match VPN plugins and upstream mirror naming?

ehh, those should be changed to NetworkManager -. networkmanager eventually, since I believe our manual states to convert that to lowercase. For now I'd be fine with just correcting what's networkmanager.

Cool, I moved the path/changed the pname and reworded the original commit.

Can't build this right now because git is broken on staging:
builder for '/nix/store/yamjspq1y07ck9b3wzwn513j46ixwrjf-git-2.30.1.drv' failed with exit code 2; last 10 log lines:                                                                          Test Summary Report                                                                                -------------------                                                                                t5319-multi-pack-index.sh                        (Wstat: 256 Tests: 66 Failed: 1)                                                                                Failed test:  11                                                                                Non-zero exit status: 1                                                                                Files=913, Tests=22275, 75 wallclock secs ( 4.76 usr  1.07 sys + 301.60 cusr 362.52 csys = 669.95 CPU)                                                                                Result: FAIL                                                                                make[1]: *** [Makefile:53: prove] Error 1                                                                                make[1]: Leaving directory '/build/git-2.30.1/t'                                                                                make: *** [Makefile:2811: test] Error 2

@SuperSandro2000 I have the same problem on master, and it's also preventing me from fully rebuilding my system to test #115436 (and I assume my nixpkgs-review run for that will face the same problem at some point during the night). I've actually ran into it for a while now (at least a month or so), and I usually just waited until I could pull git from the nix cache...

@SuperSandro2000 I have the same problem with git on master, and it's also preventing me from fully rebuilding my system to test #115436 (and I assume my nixpkgs-review run for that will face the same problem at some point during the night). I've actually ran into it for a while now (at least a month or so), and I usually just waited until I could pull git from the nix cache...

I disabled the test in https://github.com/NixOS/nixpkgs/pull/115847

copying path '/nix/store/nrnk4ryzlkr1g0dkvlmz2knk4gz83di5-ModemManager-1.14.10.tar.xz' from 'http://martha:5000'...
copying path '/nix/store/419gcpmbk6g2jvsnwxxhs2wdpns2dc6m-libqrtr-glib-1.0.0' from 'http://martha:5000'...
copying path '/nix/store/rbkmampbxn0xix6khzjx1j5yxy99nnmm-libmbim-1.24.6' from 'http://martha:5000'...
copying path '/nix/store/z6y4c4syszchwyg7mnki08wjxlqa1nzq-ppp-2.4.8' from 'http://amy:5000'...
error: --- SubstituteGone --- nix-daemon
file 'nar/z6y4c4syszchwyg7mnki08wjxlqa1nzq.nar' does not exist in binary cache 'http://amy:5000'
copying path '/nix/store/z6y4c4syszchwyg7mnki08wjxlqa1nzq-ppp-2.4.8' from 'http://clara:5000'...
copying path '/nix/store/ijgfynv8djgibj0q55mi8sirnnv6gsff-libmbim-1.24.6-dev' from 'http://martha:5000'...
copying path '/nix/store/vx8c4lbwnh924s69akb21a0kxsyylfh4-libqmi-1.28.2' from 'http://martha:5000'...
copying path '/nix/store/v7z9g44i2qr7lhzmmmxb5fbqz4zmnv14-libqmi-1.28.2-dev' from 'http://martha:5000'...
unpacking sources
unpacking source archive /nix/store/nrnk4ryzlkr1g0dkvlmz2knk4gz83di5-ModemManager-1.14.10.tar.xz
source root is ModemManager-1.14.10
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file ModemManager-1.14.10/docs/reference/libmm-glib/libmm-glib.types
patching sources
configuring
fixing libtool script ./ltmain.sh
configure flags: --disable-static --disable-dependency-tracking --prefix=/nix/store/mmxkpgc36y8r6qkhjcv8pfky9n3v0h30-modem-manager-1.14.10 --with-polkit --with-udev-base-dir=/nix/store/mmxkpgc36y8r6qkhjcv8pfky9n3v0h30-modem-manager-1.14.10/lib/udev --with-dbus-sys-dir=/nix/store/mmxkpgc36y8r6qkhjcv8pfky9n3v0h30-modem-manager-1.14.10/share/dbus-1/system.d --with-systemdsystemunitdir=/nix/store/mmxkpgc36y8r6qkhjcv8pfky9n3v0h30-modem-manager-1.14.10/etc/systemd/system --sysconfdir=/etc --localstatedir=/var --with-systemd-suspend-resume --with-systemd-journal
checking for a BSD-compatible install... /nix/store/9fkdn82nzxgkxyax3m9qdh2knj7apaa5-coreutils-8.32/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /nix/store/9fkdn82nzxgkxyax3m9qdh2knj7apaa5-coreutils-8.32/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1000' is supported by ustar format... yes
checking whether GID '100' is supported by ustar format... yes
checking how to create a ustar tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... yes
checking whether make supports nested variables... (cached) yes
checking whether make supports the include directive... yes (GNU style)
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... none
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /nix/store/ia1dn8zyi07phxkx02c0wwqc7v7c54nl-gnugrep-3.6/bin/grep
checking for egrep... /nix/store/ia1dn8zyi07phxkx02c0wwqc7v7c54nl-gnugrep-3.6/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) none
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /nix/store/ij7k48dhdrda13gcp3lbpi507b2awnmr-gnused-4.8/bin/sed
checking for fgrep... /nix/store/ia1dn8zyi07phxkx02c0wwqc7v7c54nl-gnugrep-3.6/bin/grep -F
checking for ld used by gcc... ld
checking if the linker (ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... nm
checking the name lister (nm) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse nm output from gcc object... ok
checking for sysroot... no
checking for a working dd... /nix/store/9fkdn82nzxgkxyax3m9qdh2knj7apaa5-coreutils-8.32/bin/dd
checking how to truncate binary pipes... /nix/store/9fkdn82nzxgkxyax3m9qdh2knj7apaa5-coreutils-8.32/bin/dd bs=4096 count=1
./configure: line 8148: /usr/bin/file: No such file or directory
checking for mt... no
checking if : is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking whether C compiler accepts -Werror=unknown-warning-option... no
checking whether C compiler accepts -Wno-suggest-attribute=format... yes
checking whether C compiler accepts -fno-strict-aliasing... yes
checking whether C compiler accepts -Wnested-externs... yes
checking whether C compiler accepts -Wmissing-prototypes... yes
checking whether C compiler accepts -Wstrict-prototypes... yes
checking whether C compiler accepts -Wdeclaration-after-statement... yes
checking whether C compiler accepts -Wimplicit-function-declaration... yes
checking whether C compiler accepts -Wold-style-definition... yes
checking whether C compiler accepts -Wjump-misses-init... yes
checking whether C compiler accepts -Wall... yes
checking whether C compiler accepts -Wextra... yes
checking whether C compiler accepts -Wundef... yes
checking whether C compiler accepts -Wwrite-strings... yes
checking whether C compiler accepts -Wpointer-arith... yes
checking whether C compiler accepts -Wmissing-declarations... yes
checking whether C compiler accepts -Wredundant-decls... yes
checking whether C compiler accepts -Wno-unused-parameter... yes
checking whether C compiler accepts -Wno-missing-field-initializers... yes
checking whether C compiler accepts -Wformat=2... yes
checking whether C compiler accepts -Wcast-align... yes
checking whether C compiler accepts -Wformat-nonliteral... yes
checking whether C compiler accepts -Wformat-security... yes
checking whether C compiler accepts -Wsign-compare... yes
checking whether C compiler accepts -Wstrict-aliasing... yes
checking whether C compiler accepts -Wshadow... yes
checking whether C compiler accepts -Winline... yes
checking whether C compiler accepts -Wpacked... yes
checking whether C compiler accepts -Wmissing-format-attribute... yes
checking whether C compiler accepts -Wmissing-noreturn... yes
checking whether C compiler accepts -Winit-self... yes
checking whether C compiler accepts -Wredundant-decls... (cached) yes
checking whether C compiler accepts -Wmissing-include-dirs... yes
checking whether C compiler accepts -Wunused-but-set-variable... yes
checking whether C compiler accepts -Warray-bounds... yes
checking whether C compiler accepts -Wreturn-type... yes
checking whether C compiler accepts -Wswitch-enum... yes
checking whether C compiler accepts -Wswitch-default... yes
checking whether C compiler accepts -Wduplicated-cond... yes
checking whether C compiler accepts -Wduplicated-branches... yes
checking whether C compiler accepts -Wlogical-op... yes
checking whether C compiler accepts -Wrestrict... yes
checking whether C compiler accepts -Wnull-dereference... yes
checking whether C compiler accepts -Wdouble-promotion... yes
checking whether C compiler accepts -Wno-error=unused-parameter... yes
checking whether C compiler accepts -Wno-error=missing-field-initializers... yes
checking whether C compiler accepts -Werror=unknown-warning-option... (cached) no
checking whether the linker accepts -Wl,--as-needed... yes
checking whether the linker accepts -Wl,--as-needed... yes
checking whether the linker accepts -Wl,-z,relro... yes
checking whether the linker accepts -Wl,-z,relro... yes
checking whether the linker accepts -Wl,-z,now... yes
checking whether the linker accepts -Wl,-z,now... yes
checking whether the linker accepts -Wl,-z,noexecstack... yes
checking whether the linker accepts -Wl,-z,noexecstack... yes
checking whether the linker accepts -Wl,--no-as-needed... yes
checking whether the linker accepts -Wl,--fatal-warnings... yes
checking whether the linker accepts -Wl,-fatal_warnings... no
checking whether the linker accepts -Wl,--no-as-needed... yes
checking whether C compiler accepts -Werror=unknown-warning-option... (cached) no
checking whether C compiler accepts -Wno-suggest-attribute=format... (cached) yes
checking whether C compiler accepts -fno-strict-aliasing... (cached) yes
checking whether C compiler accepts -Wnested-externs... (cached) yes
checking whether C compiler accepts -Wmissing-prototypes... (cached) yes
checking whether C compiler accepts -Wstrict-prototypes... (cached) yes
checking whether C compiler accepts -Wdeclaration-after-statement... (cached) yes
checking whether C compiler accepts -Wimplicit-function-declaration... (cached) yes
checking whether C compiler accepts -Wold-style-definition... (cached) yes
checking whether C compiler accepts -Wjump-misses-init... (cached) yes
checking whether C compiler accepts -Wall... (cached) yes
checking whether C compiler accepts -Wextra... (cached) yes
checking whether C compiler accepts -Wundef... (cached) yes
checking whether C compiler accepts -Wwrite-strings... (cached) yes
checking whether C compiler accepts -Wpointer-arith... (cached) yes
checking whether C compiler accepts -Wmissing-declarations... (cached) yes
checking whether C compiler accepts -Wredundant-decls... (cached) yes
checking whether C compiler accepts -Wno-unused-parameter... (cached) yes
checking whether C compiler accepts -Wno-missing-field-initializers... (cached) yes
checking whether C compiler accepts -Wformat=2... (cached) yes
checking whether C compiler accepts -Wcast-align... (cached) yes
checking whether C compiler accepts -Wformat-nonliteral... (cached) yes
checking whether C compiler accepts -Wformat-security... (cached) yes
checking whether C compiler accepts -Wsign-compare... (cached) yes
checking whether C compiler accepts -Wstrict-aliasing... (cached) yes
checking whether C compiler accepts -Wshadow... (cached) yes
checking whether C compiler accepts -Winline... (cached) yes
checking whether C compiler accepts -Wpacked... (cached) yes
checking whether C compiler accepts -Wmissing-format-attribute... (cached) yes
checking whether C compiler accepts -Wmissing-noreturn... (cached) yes
checking whether C compiler accepts -Winit-self... (cached) yes
checking whether C compiler accepts -Wredundant-decls... (cached) yes
checking whether C compiler accepts -Wmissing-include-dirs... (cached) yes
checking whether C compiler accepts -Wunused-but-set-variable... (cached) yes
checking whether C compiler accepts -Warray-bounds... (cached) yes
checking whether C compiler accepts -Wreturn-type... (cached) yes
checking whether C compiler accepts -Wswitch-enum... (cached) yes
checking whether C compiler accepts -Wswitch-default... (cached) yes
checking whether C compiler accepts -Wduplicated-cond... (cached) yes
checking whether C compiler accepts -Wduplicated-branches... (cached) yes
checking whether C compiler accepts -Wlogical-op... (cached) yes
checking whether C compiler accepts -Wrestrict... (cached) yes
checking whether C compiler accepts -Wnull-dereference... (cached) yes
checking whether C compiler accepts -Wdouble-promotion... (cached) yes
checking whether C compiler accepts -Wno-cast-function-type... yes
checking whether C compiler accepts -Wno-packed... yes
checking whether C compiler accepts -Wno-error=unused-parameter... (cached) yes
checking whether C compiler accepts -Wno-error=missing-field-initializers... (cached) yes
checking whether C compiler accepts -Wno-error=cast-function-type... yes
checking whether C compiler accepts -Wno-error=packed... yes
checking pkg-config is at least version 0.9.0... yes
checking for gtk-doc... no
configure: WARNING:
  You will not be able to create source packages with 'make dist'
  because gtk-doc >= 1.0 is not found.
checking for gtkdoc-check... no
checking for gtkdoc-check... no
checking for gtkdoc-rebase... no
checking for gtkdoc-mkpdf... no
checking whether to build gtk-doc documentation... no
checking for GTKDOC_DEPS... yes
checking whether NLS is requested... yes
checking for msgfmt... /nix/store/4w5immj9jfwzajr1lzwxsa09ydgri8vg-gettext-0.21/bin/msgfmt
checking for gmsgfmt... /nix/store/4w5immj9jfwzajr1lzwxsa09ydgri8vg-gettext-0.21/bin/msgfmt
checking for xgettext... /nix/store/4w5immj9jfwzajr1lzwxsa09ydgri8vg-gettext-0.21/bin/xgettext
checking for msgmerge... /nix/store/4w5immj9jfwzajr1lzwxsa09ydgri8vg-gettext-0.21/bin/msgmerge
checking for ld used by gcc... ld
checking if the linker (ld) is GNU ld... yes
checking for shared library run path origin... done
checking for CFPreferencesCopyAppValue... no
checking for CFLocaleCopyCurrent... no
checking for GNU gettext in libc... yes
checking whether to use NLS... yes
checking where the gettext function comes from... libc
checking for MM... yes
checking for LIBMM_GLIB... yes
checking for MMCLI... yes
checking for xsltproc... no
checking whether to build with code coverage support... no
checking for gobject-introspection... yes
checking pkg-config is at least version 0.9.0... yes
checking for vapigen... yes
checking for GUDEV... yes
checking for LIBSYSTEMD... yes
checking for LIBSYSTEMD_LOGIN... no
checking for POLKIT... yes
checking for MBIM... yes
checking for QMI... no
configure: error: Couldn't find libqmi-glib >= 1.26.0. Install it, or otherwise configure using --without-qmi to disable QMI support.

@SuperSandro2000 I don't think the ModemManager failure is related to any changes. I get the same problem on staging, reverting 53bf5c322d89912ed157ebbd2617ed9190bf801 fixes building.

Should be fixed by 6eed4a89f6feaa0797418626619562ec287c7ed6.

could someone update modemmanager?

Rebased to resolve merge conflicts.

Thanks @maxeaubrey, hope this will go smoothly through staging :sparkles:


ccxt.exchange call error (ver 1.9.163)

I just updated to the latest ccxt (1.9.163) and now I'm getting errors such as this whenever I try to initialize an exchange:
Code:
import ccxt
southxchange = ccxt.southxchange()

Result:
Traceback (most recent call last):
  File "C:/Users/Phinix/Desktop/Crypto/CCXTtests.py", line 3, in <module>
    southxchange = ccxt.southxchange()
  File "C:\Python27\lib\site-packages\ccxt\exchanges.py", line 17538, in __init__
    super(southxchange, self).__init__(params)
  File "C:\Python27\lib\site-packages\ccxt\exchange.py", line 163, in __init__
    for attr in self.__dir__():
AttributeError: 'southxchange' object has no attribute '__dir__'
>>>

This is a bug due to one of recent commits, it will be fixed right away! Thx for reporting!

Thanks, Igor!
I'll be sure to include the Python version in my Issue titles moving forward for you too. :)

@PhinixPhire I can see it from the output, no worries ) Fixing it.

I've uploaded the fix for it, but GitHub and Travis now say:

Have to wait a little (

Ok, this is fixed in version 1.9.165+. Sorry for the inconvenience. It was a leftover minor bug. Thanks for your patience! Let us know if you have any other questions or difficulties. Best wishes!

No problem at all. I appreciate the quick response, sir!


Document that __fastfail is noreturn

@TylerMSFT
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Note that if I'm not mistaken, there's a bug with the C compiler (not C++ !), which seems to ignore the  noreturn annotation during unreachable code analysis.
https://developercommunity.visualstudio.com/t/C-Code-Analysis-should-understand-that/10665570

#sign-off


[Do-not-merge] Add manual shoot cleanup documentation

Signed-off-by: Swapnil Mhamane<EMAIL_ADDRESS>This PR adds the link to manual cleanup doc to gardener webisite.
This PR should be merged after: https://github.com/gardener/gardener/pull/1626

ping @swapnilgm - what is the status of this PR?

I'm no more working no this PR. The original PR on gardener/gardener is also dropped. Will keep this is backlog. And open the PR once i get a time over other priority task.


Issues related to patch merging implementation

In this repository, patch merging is implemented with nn.Unfold, but it is expected to behave differently than the official implementation.
https://github.com/microsoft/Swin-Transformer/blob/6ded2577413b68cbbd89f08391465788ed73030e/models/swin_transformer.py#L291
Is there something I'm missing out on?

In this repository, patch merging is implemented with nn.Unfold, but it is expected to behave differently than the official implementation.
https://github.com/microsoft/Swin-Transformer/blob/6ded2577413b68cbbd89f08391465788ed73030e/models/swin_transformer.py#L291
Is there something I'm missing out on?

Also confused about this question. Do you have the answer?


Windows 10 SDK version for ARM

In our wiki to build arm we point to https://dev.windows.com/en-US/downloads/windows-10-sdk to download the sdk.
First of all, that page only show the latest SDK which we don't use, ChakraCore uses SDK 10.0.10240.0 (https://github.com/Microsoft/ChakraCore/blob/master/Build/Chakra.Build.Default.props#L6) and latest is 10.0.14393.0.
Not having the exact sdk version will make the compiler complain.
Also, when looking in the archive page https://developer.microsoft.com/en-us/windows/downloads/sdk-archive, I can't find the version we're using.
The versions I can find are

10.0.14393.0 (August 2016)
10.0.10586.0 (November 2015)
10.0.26624.0 (July 2015)

Where does version 10.0.10240.0 come from ?
I think we should either update our Wiki page to point directly to the right version of the sdk that we use and/or update the version that we use for something more recent.

10.0.26624.0 (July 2015)

Where the heck did this version string come from...? Maybe it's a mistake in documentation, because I'd expect the version to match the July 2015 Windows 10 version (10.0.10240.0).

@dilijev
You're right, the July 2015 version is 10.0.10240.0
I tried to install it and everywhere it said 10.0.26624.0, but once installed I checked and the install path is C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0
This is probably a problem in the Windows documentation.
Is there a way to report that?
Also, we probably should mention it in our wiki and point to the archive page instead

I think 26624 might be the phone version, TH1 on mobile.  They may not have been able to sync version numbers until TH2, since TH1 mobile didn't make it to market.  This is just a guess though.

@ianwjhalliday my understanding of the mobile versus desktop build number unification was that the 14000s were chosen as a number which was ahead of both systems' current numbers so they wouldnt go back, in which case 26xxx doesn't track, but I could be mistaken about that.

I updated the wiki to point to the archive page and indicate that we should use version of July 2015 to avoid confusion with the version number


Offline Playing: What is possible?

In the readme you write:
While certain playback controls work offline and playback can happen offline for offlined content, apps cannot connect and start communicating with Spotify unless there is an internet connection

What does that mean?
I am thinking about making a Spotify alarm clock that must work offline. What would that mean for the apps possible offline capabilities?

Hey again @maracuja-juice - you should only keep the connection open when you need it, and disconnect accordingly. Keeping it open when it's not needed by the user/app is bad practice as it will prevent the Spotify app from going idle when it's inactive. Check out this guide for more info.

Okay, thanks. So in short there always needs to be an internet connection on the startup of the app. (or alarm)

Hi i get the same type of error but when i have no internet connection at all,
One of my goals is to use the sdk playerApi when i got no internet too, beacause i have spotify premium and i can play song going offline, so i think it could be reasonable to spect that.
regards


Need help to query an stake address's delegation amount

I am trying to add two columns to the delegations table

previous_pool_hash_id  --- The pool from which the delegator moved. Null, if this is first delegation transaction for a stake address.
stake_amount        ---  total balance present in the stake address during the delegation transaction.

I've already made required change to include previous_pool_hash_id, It's ordered by Id instead of transaction order, but it still works.
cardano-db-sync/src/Cardano/DbSync/Era/Shelly/Query.hs
+  queryLastDelegatedPoolHash :: MonadIO m => StakeAddressId -> ReaderT SqlBackend m (Either LookupFail (Maybe  PoolHashId))
+  queryLastDelegatedPoolHash addr = do
+    res <- select . from $ \ d -> do
+              where_ (d ^. DelegationAddrId ==. val addr)
+              orderBy [desc (d ^. DelegationId)]
+              limit 1
+              pure (d ^. DelegationPoolHashId)
+    case res of
+      [] -> do
+          pure $ Right Nothing
+      x -> do
+          pure $  Right $ Just $ unValue $ head  x

cardano-db-sync/src/Cardano/DbSync/Era/Shelley/Insert.hs
    insertDelegation
        :: (MonadBaseControl IO m, MonadIO m)
        => Trace IO Text -> DbSyncEnv -> DB.TxId -> Word16 -> EpochNo
        -> ShelleyStakingCred -> ShelleyStakePoolKeyHash
        -> ExceptT DbSyncNodeError (ReaderT SqlBackend m) ()
    insertDelegation _tracer env txId idx (EpochNo epoch) cred poolkh = do
      addrId <- firstExceptT (NELookup "insertDelegation")
                    . newExceptT
                    $ queryStakeAddress (Shelley.stakingCredHash env cred)
+
+     previousPoolHashId <-  firstExceptT (NELookup "insertDelegation")
+                                           . newExceptT
+                                           $ queryLastDelegatedPoolHash addrId
      poolHashId <- firstExceptT (NELookup "insertDelegation")
                      . newExceptT
                      $ queryStakePoolKeyHash poolkh
      void . lift . DB.insertDelegation $
        DB.Delegation
          { DB.delegationAddrId = addrId
          , DB.delegationCertIndex = idx
          , DB.delegationPoolHashId = poolHashId
+         , DB.delegationPreviousPoolHashId = previousPoolHashId
          , DB.delegationActiveEpochNo = epoch + 2 -- The first epoch where this delegation is valid.
          , DB.delegationTxId = txId
          }

How do I query the total balance in stake address at that instant?

I am trying to add two columns to the delegations table

Why? You do realize that this would make you modified version incompatible with this version.

previous_pool_hash_id

That can be obtained with an SQL query on the existing database.

stake_amount

That can also be obtained with an SQL query on the existing database.

@mesudip Is this issue resolved? If so, please close the ticket.

@mesudip Is this issue resolved? If so, please close the ticket.

I was aware of the epoch_stake table. I was just confused when actually does the insertion occur.
So the value is updated every block and not at the end of epoch during reward calculation?

I was aware of the epoch_stake table. I was just confused when actually does the insertion occur.
So the value is updated every block and not at the end of epoch during reward calculation?

The epoch_stake table is updated at the start of each epoch.
If we are in epoch N the values in the epoch_stake table for epoch N are the values from when the stake snapshot was taken at the start of epoch N - 1.

The epoch_stake table is updated at the start of each epoch.
If we are in epoch N the values in the epoch_stake table for epoch N are the values from when the stake snapshot was taken at the start of epoch N - 1.

That data should be available in the ledger state. How do query the value from  ledger state in haskell?

That data should be available in the ledger state. How do query the value from  ledger state in haskell?

you can get a JSON dump of the ledger state from the node using a command something like cardano-cli shelley query ledger-state .

you can get a JSON dump of the ledger state from the node using a command something like cardano-cli shelley query ledger-state .

@mesudip Can this be closed?

@mesudip Can this be closed?

Let's say somebody registered a new stake address stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u
Where can I find the balance for that address? Do I have to wait until the end of epoch?
cardano-cli provides only the stake distribution for active pools, and balance of reward address of the stakeAddress.

Where can I find the balance for that address?

The balance is not stored directly anywhere. Instead db-sync stores deposits and withdrawals from the rewards account.

Do I have to wait until the end of epoch?

db-sync only adds rewards to the reward table when the rewards can actually be spent. Rewards for epoch N are calculated in the cardano-node 2 days after the start of epoch N + 1 but those rewards cannot be spent until after the start of epoch N + 2. Its is at the start of epoch N + 2 that the rewards are added the database.
To get the rewards for a specific stake address:
select * from reward inner join stake_address on reward.addr_id = stake_address.id
    where stake_address.view = 'stake1.....' ;

To get the withdrawals for the same address:
select * from withdrawal inner join stake_address on withdrawal.addr_id = stake_address.id
     where stake_address.view = 'stake1...' ;

To get the current balance of the reward account it is simply the first minus the second.

@mesudip Have you sorted this out yet?

Closing.

To get the amount delegated and which pool it was delegated to:
> select stake_address.view as stake_address, pool_hash.view as pool, amount as lovelace, epoch_no
      from epoch_stake inner join stake_address on epoch_stake.addr_id = stake_address.id
      inner join pool_hash on epoch_stake.pool_id = pool_hash.id
      where stake_address.view = 'stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u'
      order by epoch_no asc;
                        stake_address                        |                           pool                           | lovelace  | epoch_no
-------------------------------------------------------------+----------------------------------------------------------+-----------+----------
 stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u | pool1calq8kjzrvp83l80rtvgmulausl99q4tjfkz2lp227vkymd5wgg | 142725567 |      250
 stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u | pool1calq8kjzrvp83l80rtvgmulausl99q4tjfkz2lp227vkymd5wgg | 142725567 |      251
 stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u | pool1calq8kjzrvp83l80rtvgmulausl99q4tjfkz2lp227vkymd5wgg | 142725567 |      252
 stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u | pool1calq8kjzrvp83l80rtvgmulausl99q4tjfkz2lp227vkymd5wgg | 142805683 |      253
 stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u | pool1calq8kjzrvp83l80rtvgmulausl99q4tjfkz2lp227vkymd5wgg | 142885847 |      254
 stake1uxwt57g5k59805exsla94smwdhy8uy748fadeua77pdr5mglnft2u | pool1calq8kjzrvp83l80rtvgmulausl99q4tjfkz2lp227vkymd5wgg | 143001638 |      255
(6 rows)


typo

@guibulator : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @guibulator


resolves #9 - added a simple prefix search

dumps the results into an array

@fredim I haven't worked out why, but this prefix search logic fails (in fact crashes with an out-of-bounds error) when you search for certain prefixes. Specifically, it crashes for prefixes for which all strings that share that prefix also share a longer prefix. Simple example: in TestPrefixSearch, searching for the prefix "a" will crash, since all strings starting with "a" start with "ab".

I'm still seeing the crash, although your fix works for that specific case. I can repro a crash with search words {"ab", "abc"} and prefix "a".

@fredim, another failing case with the latest code: {"foo:bar", "a", "foo:baz"}, with prefix "foo:b".

I took a stab at writing some testing/quick black box tests, but mostly this appeared revealed that this library doesn't handle arbitrary unicode strings.

closing in favor of #11


Look into using Gmail API for sending emails

Google does provide an API for Gmail, so we could just skip the whole setting up an email server step. I could implement this similar to how I implemented Google Calendar, making functions to abstract the whole process.

We can just use regular SMTP protocol with gmail. We just need to have<EMAIL_ADDRESS>to have 2 factor authentication in order to use it. For debugging, we can always just use the console backend like we always have done.


Run on server(tomcat) return white empty page.

In development, you should go to localhost:3000 to see the frontend dev server.
It creates a proxy to localhost:8080 so you can access everything from here.
It can be a little bit confusing at first, because in production, you add the static resources in the jar and use the SinglePageAppConfig to resolve them.
At the moment, the big advantage of doing this is we do not have to write anything to disk when we run in dev.
This could be fixed if we decide to write the generated files of the frontend dev server to disk and use the SinglePageApp config to use this directory in dev.
This would probably make the build process less 'magical'.
I'm keeping this open for now.

I also get an empty page and I don't know what to expect! I created a pull request that upgrades this project to the latest and greatest. Please review and use and help out!

Well I guess one way to solve this would be including a controller that redirects to localhost:3000 in dev...

This is what I did to get 8080 to serve the production build. This way works with development and also gets in Spring Boot assembled JAR.
backend/build.gradle
classes.dependsOn(':frontend:assemble')

frontend/build.gradle
task bundle(type: YarnTask) {
  args = ['build']
}

task start(type: YarnTask) {
  args = ['start']
}

task test(type: YarnTask) {
  args = ['test']
}

task copyBackend(type: Copy) {
    from 'build'
    into project(':backend').file('src/main/resources/static')
}

//check.dependsOn(test)
bundle.dependsOn(yarn_install)
assemble.dependsOn(copyBackend)
copyBackend.dependsOn(bundle)

I just got this working and don't know if it's the best solution.

@MikeSuiter Correct me if I am wrong but, I think the point of having a front-end with port 3000 server was to support React-hot-reloading. If you run the gradle task in production mode, it should create a fat jar which is then accessible on localhost:8080.
@oakstair could you check the console, for some errors. If you upgraded to the latest and greatest. There were a lot of methods in webpack.config that are now deprecated. So that might break some workings.


fix: fixing tensorflow lite android link

Hi all,
Your link are broken because points to a 404 url.
I dont know how to report this issue so I thought it was a good idea to do a PR to create attention to this problem.
PS: The link is broken in all languages.
please fix it.
PS2: I will try to sign the CLA but if you read this please fix it for me.

Hi @joefernandez
I saw it was assigned automatically to you.
I will try to sign the CLA but if you can fix it by yourself its better for me because I don't have enough time to do it.
Thanks in advance.

Fix is in flight in the original source. Closing this PR.

@joefernandez Thanks for fixing it. :)


list validator can be bypassed

Expected Behavior
list validator must be applied
Actual Behavior
list validator can be bypassed sometime
Steps to Reproduce the Problem

apply a list(Email) validator on a input value of type Vec
send request with corresponding arg of value "not a email". (not ["not a email"])
validator is bypassed

Specifications

Version: 2.11.3 on rustc 1.56.0 (09c42c458 2021-10-18)
Platform: wsl1 ubuntu 18.04 on windows 10 20H2

Since the validators has been reworked in the v3 version, I will close this issue. 😁


Collect postal address of appointment attendee

I've reviewed the GDS Service Manual guidance on addresses here - https://www.gov.uk/service-manual/user-centred-design/resources/patterns/addresses
Opted for the simplest approach initially which is a text box to collect the address. We may need to break this down into individual address lines later on when we establish requirements with the print provider.
Needs to be rebased once #21 has been merged.

Looks good. Only thing to keep in mind is that database migrations happen after application deployment but in this instance we can likely get away with manually restarting the app for the new schema to take effect.

I should have looked at #21 beforehand, ignore what I said about the db ;)


Rss feed?

Hey I was browsing your site while looking for articles about coliving. Really enjoyed yours. I was wondering if you could add a rss feed for the blog?
Something like https://ramonmorcillo.com/blog/feed.xml and adding RSS feed autodiscovery to the page head tag

Hey @sethidden thanks for the feedback.
I will take a look at it before writing the next one :)

This will suffice for me for now (rsshub can generate rss feeds for gh issue lists on a repo, and since you add an issue for each article with a link to it, it's good enough fro me https://rsshub.app/github/issue/reymon359/gatsby-personal-site/all

Happy you found a way, I didn't know about that. Thanks for sharing!


Implement aspects

Implement aspects in order to reduce boilerplate code and closures and improve performance.
Possible candidates: Fody

Removed aspects, as will be implemented in a different project.


Redirects: Uncaught Error: Not running

I'm having this error when using 1 or more redirects.
This error occurs in supertest v0.11.0.
supertest v0.10.0 doesn't have this error.
node version 0.11.12.
Test case:
describe('Redirects', function() {
    it('should work', function(done) {
        var app = express();
        app.get('/', function(req, res) {
            res.redirect('/r1');
        });
        app.get('/r1', function(req, res) {
            res.send(200);
        });

        request(app)
            .get('/')
            .redirects(1)
            .expect(200, done);
    });
});

Error log:
  1) Redirects should work:
     Uncaught Error: Not running
      at Server.close (net.js:1344:11)
      at /home/action/workspace/app/node_modules/supertest/lib/test.js:126:36
      at Test.Request.callback (/home/action/workspace/app/node_modules/supertest/node_modules/superagent/lib/node/index.js:660:30)
      at Test.<anonymous> (/home/action/workspace/app/node_modules/supertest/node_modules/superagent/lib/node/index.js:132:10)
      at Test.EventEmitter.emit (events.js:104:17)
      at IncomingMessage.<anonymous> (/home/action/workspace/app/node_modules/supertest/node_modules/superagent/lib/node/index.js:818:12)
      at IncomingMessage.EventEmitter.emit (events.js:126:20)
      at _stream_readable.js:895:16
      at process._tickCallback (node.js:339:11)

+1, So when pull will be merged? I am facing same issue...

Added pull request with fix and test. Please merge #286. Thanks.

:+1: It would be uber handy for this to be fixed.


Question: How to create instance of service that has constructor parameters.

Environment: .NET  4.6.1 (Not Core)
I'm trying to use the new Microsoft.Extensions.DependencyInjections classes with .NET 4.6.1.
I have that has this signature:
public class RabbitMqConnection : IMessagingConnection`
{
     public RabbitMqConnection(ILogger<RabbitMqConnection> logger, string connectionString)
     {
     }
}

In my test harness, I'm creating an instance of the ServiceCollection, registering my interface and implementation.

[TestFixture]
    public class ConnectionTests
    {
        private readonly Uri AmqpUri = new Uri("aqmp://renscribe:Helium2@dwerecrq01.hq.bn-corp.com:5672/v.pds.ren.scribe");
        private readonly string ConnectionString =
            "host=dwerecrq01.hq.bn-corp.com;port=5672;virtualHost=v.pds.ren.scribe;requestedHeartbeat=30;prefetchcount=100;timeout=12" +
            "maxScribeLocalQueue=800;scribeMessageSerializeVersion=3;maxMessageSize=4194304;maxExceptionSize=4194304;getUserOnEveryMessage=true;";

        private static IServiceProvider _services;

        [SetUp]
        public void Setup()
        {
            var serviceCollection = new ServiceCollection();
            ConfigureServices(serviceCollection);
            _services = serviceCollection.BuildServiceProvider();
            var lf = _services.GetRequiredService<ILoggerFactory>();
            lf.AddConsole().AddDebug();
        }

        private void ConfigureServices(IServiceCollection serviceCollection)
        {
            serviceCollection.AddLogging();
            serviceCollection.AddTransient<IMessagingConnection, RabbitMqConnection>();
        }
        [Test]
        public void Should_correctly_parse_connection_string()
        {
            var connection =
                ActivatorUtilities.CreateInstance<IMessagingConnection>(_services, ConnectionString );
                //_services.GetRequiredService<IMessagingConnection>();

            var logger = _services.GetRequiredService<ILogger<ConnectionTests>>();

            using (logger.BeginScope($"=>{nameof(Should_correctly_parse_connection_string)}"))
            {
                logger.LogInformation("Test starting");
                logger.LogInformation("Test completed");
            }
        }
    }

The call to ActivatorUtilities.CreateInstance fails with the error:

A suitable constructor for type 'bn.pds.tools.Messaging.IMessagingConnection' could not be located. Ensure the type is concrete and services are registered for all parameters of a public constructor.

If I remove the string parameter to the constructor, and use _services.GetRequiredService<>(), everything works as expected.
How can I create an instance of a service that requires additional parameters for the constructor?
Thanks
marc

If there are examples, documentation, kb, wiki pages available that answer my questions, please point me in the correct direction.
Thanks

You need to add ILogger<T> to the container. See https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging/LoggingServiceCollectionExtensions.cs#L28

Hi, thank you for your response.  I tested that approach, I still get the same error.  I also changed my constructor to expect an ILoggerFactory instead of an ILogger, the same issue.
Also, if I just have my constructor expect an ILogger, and use the IServiceProvider::GetRequiredService method, my object is created, and the constructor is called.
Further, this call in my code resolves file when a Logger<> is registered:
var logger = _services.GetRequiredService<ILogger<ConnectionTests>>();

Sorry, I just noticed your AddLogging statement. That said, the issue is here that ActivatorUtilities.CreateInstance<TVal> works similar to how Activator.CreateInstance works - it creates an instance of TVal by filling in values passed in or from the service container when there isn't an equivalent argument. In this case, you have to do Activator.CreateInstance<RabbitMqConnection>() as opposed to Activator.CreateInstance<IMessageConnection>().

thanks. that resolved the issue and made me realize, I have a design problem.


Broken link to Prerequisites

On the main page the link to Prerequisites points to https://github.com/microsoft/Broadcast-Development-Kit/blob/main/docs/prerequisites/readme.md which renders a 404.
https://github.com/microsoft/Broadcast-Development-Kit/blob/main/docs/prerequisites brings the content expected.

Thanks! Got it cleared up now.


Hw/master

Not finished debugging yet, but starting on cucumber tests for editing categories.  Would like feedback on if I fixed previous PR issues correctly : )

When you create a PR you should include a more meaningful title rather than the name of the branch


Chore/8299 trim compatibility patch versions

Test only the latest patch version of every minor 1.x release
For any minor version, only the latest patch version needs to keep running
with with lakeFS.  After all: suppose a new lakeFSFS version does not work
with a lakeFS minor version.  If this were an issue, then we would release
some patch release for that lakeFS version.
This brings lakeFSFS support closer to that of any other lakeFS client: we
keep compatibility through the API and to fix any server-side breakages, a
new patch release.
Part of #8299, but not all of it.

Tips for future would-be reviewers: please review each commit separately.  The first commit only reformats YAML, making the second commit easier to review.


Missing module

Hi, thanks a lot for the fix !
I've just tried it and it seems that a package is missing from the requirements, packaging.
This is the error I got (and that dissapeared after a pip install) :
  File "/home/marceau/PycharmProjects/tksel/venv/bin/tksel", line 5, in <module>
    from tksel.main import auto_main
  File "/home/marceau/PycharmProjects/tksel/venv/lib/python3.11/site-packages/tksel/main.py", line 10, in <module>
    from chromedriver_autoinstaller_fix import install as install_chrome
  File "/home/marceau/PycharmProjects/tksel/venv/lib/python3.11/site-packages/chromedriver_autoinstaller_fix/__init__.py", line 7, in <module>
    from . import utils
  File "/home/marceau/PycharmProjects/tksel/venv/lib/python3.11/site-packages/chromedriver_autoinstaller_fix/utils.py", line 19, in <module>
    from packaging import version
ModuleNotFoundError: No module named 'packaging'

Have a nice day !

had the same yesterday on py 3.10
pip install packaging solved the problem, but it would be better when this package would be installed by itself when autoinst fix get installed :)

Fixed


Error retrieving RPKI information from Routinator

BGPAlerter error retrieving RPKI information from Routinator http service.
BGPalerter appends ?client=ntt-bgpalerter to the url, which is not accepted by Routinator.
Testing with curl shows http://<IP_ADDRESS>:8323/json results in RPKI data, while http://<IP_ADDRESS>:8323/json?client=ntt-bgpalerter results in a "Bad Request" response.
Find the relevant log attached. log.txt
config.yml
rpki:
vrpProvider: api
preCacheROAs: true
url: http://<IP_ADDRESS>:8323/json
Versions
Debian 10
BGPalerter 1.28.1
Routinator 0.9.0
Is it possible to prevent bgpalerter from appending the client part?
Let me know if more info/logs/testing is needed.
Thomas Verschuren
IP Visie Networking (AS198089)

Hi @tverschuren,
Thanks for reporting this. I'm not sure since when this started to happen.
I pushed a patch but I don't know when I can release it in production.
In the meanwhile, you can:

create a cronjob to download the api output of Routinator and use a vrpFile configuration in BGPalerter; or
deploy/compile the patched version currently available in the dev/release branch.

released in v1.28.2


Tests & eslint

Basic tests and eslint gulp task that I didn't get in before release.

@cmichaelgraham Can you take a look at the TS issues that Bryan mentions above?

@bryanrsmith How is the lint setup working for you? If it's working out well, perhaps we should update our other repos. Let me know what you think.

For the config issue, you can create an interface and then reference that in your config function. The babel compiler will filter out interfaces but they will still get picked up in the d.ts that is generated.
For the IInterceptor interface, I think the definition should be as follows:

export interface IInterceptor {
	request?(request: Request):  Request|Response|Promise<Request|Response>;
	requestError?(error: any): Request|Response|Promise<Request|Response>;
	response?(response: Response): Response|Promise<Response>;
	responseError?(error: any): Response|Promise<Response>;
}

However, it may be that there's an issue in the d.ts generator. @cmichaelgraham Can you take a look at this?

Regarding the objects with string key/values, I'm not sure about that. It would work with a Map object, but that's not actually correct in this case. We may just need to go with using Object and provide a bit of documentation.

@EisenbergEffect The lint setup is working fairly well, but I just realized I hadn't checked it with some of the TS changes. It doesn't seem to like the interfaces. I will look at it further tonight, and probably pull out the TS stuff into a separate PR so we can merge the rest of the changes.
I think we could start rolling it out in other repos if you're happy with the rules (I just stole Airbnb's config, removed the react bits, and adjusted one or two rules that didn't work for us). Since we already have failing lint tasks in all the repos, we can probably just swap it out & then get everyone to contribute to cleanup until everything passes.

For the config issue, you can create an interface and then reference that in your config function

I don't think I can use an interface because it's a union type. I think what I want is type aliases, but I can't get that to work with the generator. /cc @cmichaelgraham
export type ConfigOrCallback = IRequestInit|(config: HttpClientConfiguration) => void|string;

...

configure(config: ConfigOrCallback): void {
}

It compiles, but the ConfigOrCallback type definition is missing from the output.

For the IInterceptor interface, I think the definition should be as follows:

Me too, but the generator rejects that syntax.

We may just need to go with using Object and provide a bit of documentation.

Sounds fine to me. Headers|{ [key:string]: string; } does seem to be valid TS, though, so maybe we should look into that with the generator.

@EisenbergEffect @cmichaelgraham I moved the type annotation changes to #5. This one should be good to go.

I'll merge momentarily.


Haptic feedback when closing issue?

Bug Report Dump (Auto-generated)

Version 1.12.0 (1079)
Device: iPhone 7 Plus (iOS 11.0.3)
TestFlight: false

Warning / error / success?

Success I think
Sent with GitHawk


self-contained debuggable scripts

Consider merging this topic branch. This adds the ability to easily debug from a test module by simply adding require('nodeunit').test() to end of file.

+1

I might easily be missing something but the stack updates look like they could be useful for lots of reporters.....so why not put them into utils#betterErrors?


[Feature] Improve the search_owner when query the app list

[Feature] Improve the search_owner when query the app list
Contribution Checklist

If this is your first time, please read our contributor guidelines: Submit Code.

Make sure that the pull request corresponds to a GITHUB issue.

Name the pull request in the form "[Feature] Title of the pull request", where Feature can be replaced by Hotfix, Bug, etc.

Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

If the PR is unfinished, add [WIP] in your PR title, e.g., [WIP][Feature] Title of the pull request.

-->
What changes were proposed in this pull request
Issue Number: close #1827

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (yes / no)

@1996fanrui PTAL

Hi @wolfboys , I have a question.
There are some applications belong to admin. Should we show all app owner for current team?

Hi @wolfboys , I have a question.
There are some applications belong to admin. Should we show all app owner for current team?

In other word, if user_a is admin, he doesn't belong to team1, and he has some apps in team1, should we show the user_a here?
If user_b isn't admin. he belongs to team1. He doesn't have any apps. Should we show user_b here?

In other word, if user_a is admin, he doesn't belong to team1, and he has some apps in team1, should we show the user_a here?

if usertype is admin, the range of users: Himself + members of the team

If user_b isn't admin. he belongs to team1. He doesn't have any apps. Should we show user_b here?

yes

hi fanrui:

In other word, if user_a is admin, he doesn't belong to team1, and he has some apps in team1, should we show the user_a here?

if usertype is admin, the range of users: Himself (has app) + members of the team (members has least one app)

If user_b isn't admin. he belongs to team1. He doesn't have any apps. Should we show user_b here?

yes, but user_b must be has least one app, else no.


cadvisor: Fresh install fails with read only file system

Steps to reproduce:
helm repo add ckotzbauer https://ckotzbauer.github.io/helm-charts && \
  helm repo update && \
  helm upgrade --install cadvisor ckotzbauer/cadvisor \
    --namespace monitoring \
    --create-namespace \
    --set metrics.enabled=true \
    --version v2.2.4

I get the same error with 2.2.3/2.2.2
Daemonset is deployed with the error on all worker nodes:
Error: container create failed: time="2023-04-15T14:58:20+10:00" level=error msg="runc create failed: unable to start container process: error during container init: error mounting \"/run/containers/storage/overlay-containers/5e99476e2d47dc1d78f6c6de64793a6b7d0651780a21ce8802b20827da85b40c/userdata/run/secrets\" to rootfs at \"/run/secrets\": mkdir /var/lib/containers/storage/overlay/15210da1c05500b6f951ba387c617dcf88d74133bf9bb1d6abe93ffe2f2d54f3/merged/run/secrets: read-only file system"

I think I'm missing something in the set up. CRIO is read_only = false in the config.

This actually looks like a cadvisor thing, same issue when installed with kustomize.


[CI] Add pytest & codecov

Change Log

Add codecov
Add pytest

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@9e637b2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage        ?   51.21%
=======================================
  Files           ?       24
  Lines           ?     1599
  Branches        ?        0
=======================================
  Hits            ?      819
  Misses          ?      780
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e637b2...597a957. Read the comment docs.


docs: Fix the "currently open accessibility issues" link.

In the Current Doc, the link to "currently open accessibility issues" is not correct.
Updated Doc

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @prakhar1144!


Replace addPlugins with addSerializer and expose as method of expect

Summary
Fixes #2647
In plugins.js enclosed the body of arrow function in braces to keep from leaking the updated array. I assume API for new method of expect doesn’t intend to expose the plugins directly.
exports.addSerializer = (plugin: any) => {
  PLUGINS = [plugin].concat(PLUGINS);
};

Test plan

The existing tests for foo and bar in integration_tests/snapshot_serializers verify that replacing addPlugins with addSerializer works for config.snapshotSerializers of package.json
Added 2 tests to integration_tests/snapshot_serializers in which expect.addSnapshotSerializer add

first serializer that overrides foo serializer in config.snapshotSerializers of package.json
second serializer that overrides both the first and foo

Updated plugins-test.js in jest-snapshot and replaced one occurrence of arbitrary initial length also mutating splice with non-mutating concat
Removed attempted mock and test in jest-jasmine2 because as far as I could discover, calling setup({config}) is not an effective simulation: the plugins array affected by addSerializer was different from the array returned by getSerializers so the only reason it passed in original test was config.snapshotSerializers always set to [] by mistake.

Oh yeah, because of work in progress on docs, I didn’t update them yet. Will write a first draft.

If there is a step to add or update snapshots in the integration_tests/__tests__/__snapshots__ directory, then I missed it. Because the ordinary npm test -- -u doesn’t do it, I edited directly.
Do we need a step in CONTRIBUTING.md or somewhere else?

This looks good. Do you mind:

Moving expect.addSnapshotSerializers to jest-jasmine2.
Adding documentation for expect.addSnapshotSerializers? We published the new website and it is on master again, now, so it can be done in the same PR.

Added a section following the asymmetric methods and preceding ordinary assertions.
What you say about the extension point makes sense. However, I reverted my attempted change in the doc commit, because tests passed after I merged changes from master, but then the 2 new integration tests failed after I moved expect.addSnapshotSerializer = addSerializer to follow the following line:

https://github.com/facebook/jest/blob/master/packages/jest-jasmine2/src/jest-expect.js#L59

Here is a naive thought from inexperience with stateful modules. What if jest-snapshot exports a method that returns an object which encapsulates plugins by closure, similar to Redux store: https://github.com/facebook/jest/blob/master/packages/jest-jasmine2/src/jest-expect.js#L59
() => ({
  let plugins = [ReactElementPlugin, ReactTestComponentPlugin];

  return {
    addSerializer: (plugin: any) => {
      plugins = [plugin].concat(plugins);
    },
    getSerializers: () => plugins,
  };
});

Nice work @pedrottimark

Are you sure it is okay to leave the extension point in jest-matchers, though?

Ohhh, no actually we have to fix that. I missed the comment I guess, I was too hasty.

Your thoughts on what is happening now are welcome. Why tests pass one way but not the other.
I was just now studying what it would look like if plugins was explicit part of SnapshotState. Include snapshotSerializers config as an arg to the constructor is as far as I got so far.

Here is another observation:

serialize function could use plugins from SnapshotState at https://github.com/facebook/jest/blob/master/packages/jest-snapshot/src/State.js#L120
if the function definition is moved inline from https://github.com/facebook/jest/blob/master/packages/jest-snapshot/src/utils.js#L61-L67


_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 57s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed

+1 :green_heart:
shadedjars
5m 23s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
233m 28s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

258m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6485/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6485

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux fbfe91a00e51 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4cf28e05f0dc4527f34f111f9ea80a0d9e58be6f

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6485/1/testReport/

Max. process+thread count
5029 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6485/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Hi, sorry if I ping the wrong person, but could you help to have a look at this PR?
Without this fix, the client could get org.apache.hadoop.hbase.security.AccessDeniedException when the table is being altered due to the race condition.

There are tests failing but they do not seem to be related to my changes.


Please, actualize the article and all screenshots- modern azure UX- is lood different from what's shown here

Please, actualize the article and all screenshots- modern azure UX- is lood different from what's shown here

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d56ecb14-9e66-5313-a381-d2824ec3d1e2
Version Independent ID: ff056ac8-ae76-be10-6895-757333a28e05
Content: Azure Application Insights for JavaScript web apps
Content Source: articles/azure-monitor/app/javascript.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@SychevIgor Thanks for bringing this to our attention! I have assigned the issue to the content author to evaluate and update as appropriate.

Would love to see this as well. I haven't been able to find similar views in the new UI.

The change to address this PR is now merged internally it will go live between 3-4 PM (UTC-7). Thanks again for bringing this to our attention.

#please-close


seems like synapse should just run an inefficient query very slowly and not throw an exception

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/d365community/forum/79b1327d-d925-ec11-b6e6-000d3a4f06a4.

@fullerpc - Thank you for your question.
Can you please share with us the URL of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

@fullerpc - Thank you for your question.
Can you please share with us the URL of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

@fullerpc - Since we have not heard back from you, we will now proceed to close this thread.
However, if you can share additional information regarding the documentation, you are referring and circle back on this thread, we will gladly reopen the issue and continue the discussion. Thank you.


Godot 1.1

Thank you for the contribution. It needed some fixes, so they were made in the below referenced pull request. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

@vitorgalvao Did you mean to push a commit, or has this comment ended up on the wrong pull request?

Yep. Thank you.


Conditions are not displayed.

Challenge Waypoint: Iterate Through an Array with a For Loop has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
conditions are not displayed ... not abele to continue.

Able to reproduce on
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36
It does still pass if the correct code is provided. Your code uses the variable named myTotal when the instructions ask for a variable called total.

ou that's right, i passed, but i only see conditions after i passed...
tanks sludge256


Create multi-line data for Secret object

How can I enter multi-line data in the cdk8 Secret object?
new Secret(this, 'secret', {
      metadata: {
        name: 'rabbitmq-load-definition'
      },
      data: ??
    });

Actually, I think I need stringData, but it' still the same issue

I'm aiming for a manifest similar to:
stringData:
load_definition.json: |-
{
"vhosts": [
{
"name": "/"
}
],

Should just the standard way you specify multiline strings in typescript.
Have you tried:
new Secret(this, 'secret', {
      metadata: {
        name: 'rabbitmq-load-definition'
      },
      stringData: {
        'key': `this is a
multi-line string` // notice the backtick (`)
      }
    });

Also, if you just need a serialized json as the value you can do:
new Secret(this, 'secret', {
      metadata: {
        name: 'rabbitmq-load-definition'
      },
      stringData: {
        'key': JSON.stringify(object) // or maybe fs.readFileSync() if you are reading a file.
      }
    });

Another common idiom would be:
new Secret(this, 'secret', {
      stringData: [
        'line1',
        'line2',
        'line3',
      ].join('\n')
}

Thank you, much appreciated, I'm new to both typescript and cdk8s. I'm going to try this again today and I'll update this issue.

Thank you for the solutions, all of them are working.


Progressively enhanced combobox for developer specialties (#820)

Demo
Desktop - Javascript enabled

Desktop - Javascript disabled

Mobile - Javascript enabled

Mobile - Javascript disabled
Filtering functionality is not working, because opening the filter sidebar requires Javascript
PR Summary 🌟
This PR is addressing issue #820.

Introducing a new dropdown component!
I created a shiny new component for displaying dropdowns featuring various specialties. Now, both query_component and query_mobile_component make use of it, instead of rendering them separately. 🎉

Magical new controller for pills! 💊
I crafted a powerful controller that takes care of adding and removing specialties, displaying them as pills above the Specialty search field. It'll also ensure the seamless syncing of checkboxes and their states. Because of this, the search URL can be reloaded/bookmarked, and the pill state is restored correctly. 🧙

Form autosubmit refactoring for better control! 🎛
By enhancing the forms-autosubmit, I enable you to debounce form submissions in other instances. This way, we reduce code duplication and give you more control over submission frequency! 🚀

Easier developer filtering experience! 🔍
Your life just got easier!  The search results have also received an upgrade, leading to a refreshing new interface. 🥳

Pull request checklist

[x] My code contains tests covering the code I modified
[x] I linted and tested the project with bin/check
[x] I added significant changes and product updates to the changelog

Hey @MiaSinek - thanks again for your patience on this PR. I'm enabling developer specialties BETA soon and am hoping to address this PR very soon.


Error loading CTI locally

To replicate:
from mitreattack.navlayers import MatrixGen
MatrixGen(source='local', local='cti/enterprise-attack/enterprise-attack.json')

matrix_gen.py, line 123:
self.collections['enterprise'] = hd.load_from_file(local)
hd.load_from_file(local) returns None
self.collections['enterprise'] = hd
should work as per normal
https://stix2.readthedocs.io/en/latest/api/datastore/stix2.datastore.memory.html#stix2.datastore.memory.MemoryStore.load_from_file

Thanks for pointing this out! I'll look into it and see what I can find.

I've made a patch and put it in the pipeline to be released. Thanks for bringing this to our attention!

This has been patched as of v1.2.1. Thanks for reporting this, and don't hesitate to let us know about any other issues you may encounter.


Paginators not supported for pages of type "page"

How do I solve the problem of paging content page templates?

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.


CLOUD-430: [JDG] Don't setup SSL in the basic template.

By setting the env var DISABLE_SSL. This tells the image we don't
want SSL, so that it doesn't emit a warning about SSL not being configured
due to lack of some parameters.

This is not necessary anymore. The proposed solution no longer requires an additional variable.


io_uring?

io_uring?

Not linux io_uring mode, based on rawEpoll mode

yes i know. i'm asking if you guys will implement as io_uring?

It is a very good suggestion. The team has communicated some time ago and will consider doing some experiments in the future.


Can no longer use Docker OUTSIDE of Docker

This doc specifies that it is no longer possible to do docker-in-docker because of the loss of /var/run/docker.sock. This is technically Docker outside of Docker, not docker in docker. Docker in docker is still possible despite your advisory not to do so. The document should be updated to reflect this.
Also if I may ask what is our alternative?  This requires docker in docker. While it seems we can continue to do so I don't have faith that you wont somehow remove this functionality as well. You must have known that docker in docker via CI/CD tools is a popular implementation so it would be good to see some docs on other methods to achieve this within Azure.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e1e42fdb-aa59-786b-ba0d-659f67db3cf3
Version Independent ID: cc199e1d-6737-5f52-f2a2-b6c0b603dbdc
Content: Cluster configuration in Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/cluster-configuration.md
Service: container-service
GitHub Login: @palma21
Microsoft Alias: jpalma

@darren-mcdonald Thanks for reaching out. IWe will investigate and update this thread.
@palma21 Hi Jorge, could you please look into this and add your thoughts

#reassign:Nickomang

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue and creating an internal work item to incorporate your suggestion as time allows. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


netdata: 1.43.2 -> 1.44.0, nixos/netdata: truly opt-out from analytics by default

Description of changes
https://github.com/netdata/netdata/releases/tag/v1.44.0
The /etc/ patch was updated for the log management subsystem.
Fixes #260035.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

As you interacted with netdata @pkel, please take a look to this PR.

As you interacted with netdata @pkel, please take a look to this PR.

Referring to #260035. Looks good to me, thanks!


FR: Different sound for breaks and other for microbreaks

Prerequisites

[X] I'm using latest version: v
[x] I've checked Known issues
[x] I've checked Open issues

Description
Until #524 is fix in electron. I propose as kind of workaround to option to have different sound at break and different sound at microbreak.
There could be a checkbox:
"different sound at break" which will enable option to choose different sound for "break". microbreak will have current selected sound.

Hi @mwoz123 , I am not sure what you mean, how it is supposed to help?
There is advanced option to have also sound at the beginning of the breaks https://github.com/hovancik/stretchly#play-sound-at-the-start-of-the-break-
In general, I would prefer not to make changes to break/mirobreak sounds at this time. In future I would like to have some sort of "plugin" system for breaks, where people can do own break behavior.

Thank you for this request. I suggest avoiding the "FR" acronym. It is highly ambiguous and I have never seen it in use before.
Workrave is one Stretchly equivalent which allows such a distinction. In fact, it is built-in, and I would recommend to build it in Stretchly too. As indicated in ticket #910, the signal for longer breaks needs to be louder. The current sound for microbreak ends is way too prominent/distracting.

Is this possible currently? I am also interested in this one.

in general, if issue is still open, it means it has not been implemented, yet.
Related: #1084


IntelliJ 2024 Code Completion broken

The new Version of IntelliJ brings also some GitHub workflow features which now overrides every code completion and shows no suggestions The variables are highlighted but not completed by code completion anymore.

Not sure I can replicate this issue, at least not after #63

I just upgraded to 2024.1 and found code completions broken as well. Let me know if there's any information I can provide, but I imagine everyone is experiencing this. Hopefully there is a decent fix because I tried their "native" support and it is vastly inferior to your plugin!

@erichiller, so you think this plugin is not needed anymore?

@erichiller, so you think this plugin is not needed anymore?

They were saying the opposite :P
@erichiller I am curious, how is the code completion in this version? (There's Github-Workflow-Plugin-3.2.1 archive there and you should be able to install manually with install from disk option in Plugins. Not sure if the version needs to be consistent) On my limited testing, it seems some completion works, but I haven't written any tests or dug deeper to verify what I did in that PR makes sense.

@erichiller, so you think this plugin is not needed anymore?

No! This plugin is far superior / much better then the functionality included in default Jetbrains (Rider in my case).
@LecrisUT I will check as soon as possible and get back to you

I went to try the workflow built version you linked to - I went to my IDE and it required a reboot for updating some other plugin. I did that and when it came back up all the completions in github actions worked as they should. I guess this is solved for me. Sorry to create a non-issue, I'll you know if it re-occurs.

For me the issue still exist, telling me no suggestion


Basic cluster management

An analyst can click a button to create or destroy a simple cluster. This is quick-and-dirty work to support initial cluster localization. It represents the fastest path to get a notebook running on a cluster launched from Saturn.

Pre-existing API in place.


Custom PCB instructions missing

I'm not sure if I'm not looking for the right terms, but the instructions for ordering/fabricating the custom PCB/s seem to be missing. I can't find it on the parts list, or in the main README. I do see some relevant files in the electrical/pcb folder, but can't find any instructions on how to use them. The PCB assembly instructions seem to start by assuming one already has the PCB available.  Pointers appreciated if I've just missed some part of the documentation.

You're right, with the latest merge they got deleted instead of moved by accident. You can find instructions here. I'll add them back in.


Handle write-perm on LOCATE correctly

Summary of changes
Override the error code to LTFS_LOCATE_ERROR when tape backend's locate() call returns write-perm error.
Description
On #232, LTFS could remove files automatically when tape backend's locate() call returns write-perm error even if It is not necessary. But I believe this is so rare like breaking H/W.
Fixes #232
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have confirmed my fix is effective or that my feature works

Cherry picked to branch v2.4-stable


[Task] Expose DID trait in bindings.

Description
Expose DID trait in bindings.
Motivation
Allow users to add their custom DID implementation.

The comment https://github.com/iotaledger/identity.rs/pull/968#discussion_r940741266 was specifically on adding the DID trait methods to the WasmCoreDID struct (scheme(), authority(), method(), etc.) to match the methods of WasmIotaDID and WasmStardustDID. It's still unclear how we would achieve custom DID implementations in Wasm.

Solved in #994.


Option to set quadkey zoom when creating mosaic

It looks like the current options accepted by cogeo-mosaic create are:
Options:
  -o, --output PATH       Output file name
  --minzoom INTEGER       An integer to overwrite the minimum zoom level
                          derived from the COGs.
  --maxzoom INTEGER       An integer to overwrite the maximum zoom level
                          derived from the COGs.
  --min-tile-cover FLOAT  Minimum % overlap
  --tile-cover-sort       Sort files by covering %
  --threads INTEGER       threads
  -q, --quiet             Remove progressbar and other non-error output.
  --help                  Show this message and exit.

(Note, the README should be updated to reflect new options additions)
As you know, version 0.0.2 of the mosaicJSON spec accepts a quadkey_zoom that is > minzoom. I think it would be helpful to have an option for this in the cogeo-mosaic CLI.
Questions:

quadkey_zoom must be >= minzoom. When is the default minzoom computed? I.e. do all the files need to be ingested before a minzoom is known? If so, quadkey_zoom validation might be hard.

I suppose a workaround to do this currently is to define a higher --minzoom through the CLI, which presumably calculates quadkeys at that zoom, and then change the value of minzoom and quadkey_zoom in the resulting mosaicJSON.


Readme improvement in Blurring image across face

add some more information about Blurring image across face

Thanks for assigning the issue. I'll get this done by tmr evening 😊👍🏻


fix: outstanding occurrences of reblock replaced with rechunk

I was just exploring the code and noticed the occurrence of reblock in
https://github.com/dask/dask/blob/master/dask/array/learn.py#L71
https://github.com/dask/dask/blob/master/dask/array/learn.py#L101
... I looked for the implementation and couldn't find any, and later found out that it was replaced with rechunk.
See: https://github.com/dask/dask/pull/3570

Thanks, this apparently isn't tested. Could you add a test that hits it? Something like
X, y = make_classsification(chunks=20)
X = X.rechunk({1: 10})

assert X.numblocks[1] > 1

clf = SGDClassifier()
inc = Incremental(clf)
inc.fit(X, y)

Hi, sorry, I'll get to this at some point. I've been using my spare time to do stuff in dask/dask/linalg.

Done. =)

Thanks @convexset!


CT5 - Explore how to learn on massive 6k images

This is really more of a story, but I am going to peruse the triple model approach for now.

see #CT6, this will be  resolved by following methods found here: https://apsjournals.apsnet.org/doi/full/10.1094/PHYTO-11-16-0417-R


Add Query dialects and pagination support

This PR extends the core query classes in RedisVL to support a few new constructs:

dialect is not an optional arg on each query. Defaults to 2.
pagination is now supported by using the set_paging method which will override the default num_results and fetch results between the offset and limit.
new index.query_all() func exposes a convenience method for retrieving ALL items that match a particular query, using pagination and batching under the hood. Yields batches of results in a generator. Required for LlamaIndex and likely others.

Addresses https://github.com/RedisVentures/redisvl/issues/90

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (dev@da9c57a). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #94   +/-   ##
======================================
  Coverage       ?   78.08%
======================================
  Files          ?       21
  Lines          ?     1323
  Branches       ?        0
======================================
  Hits           ?     1033
  Misses         ?      290
  Partials       ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Access and rewrite parameters of @bst.SystemFactory from another script

In the "systems"-script of the cornstover-biorefinery @bst.SystemFactory gets used to create systems and default their parameters.
Example:
@bst.SystemFactory(
    ID='hot_water_pretreatment_sys',
    ins=[cornstover],
    outs=[dict(ID='hydrolyzate'),
          dict(ID='pretreatment_wastewater')],
)

Is there any possibility to access @SystemFactory from outside of the "systems"-script and rewrite its parameters without touching the actual system definition? I imagine that one has to clear the "old" definition at first before rewriting

Dear Matthias,
Do mean to change the default ID, ins, outs parameters? In practice, the user would pass their own values during system creation:
>>> from biorefineries import cornstover as cs
>>> sys =

Dear Matthias,
Do mean to change the default ID, ins, outs parameters? In practice, the user would pass their own values during system creation:
>>> import biosteam as bst
>>> from biorefineries import cornstover as cs
>>> bst.settings.set_thermo(cs.chemicals)
>>> feed = bst.Stream('miscanthus', Water=0.7, ..., total_flow=1000, units='kg/s')
>>> sys = cs.create_hot_water_pretreatment_system(ID='pretreatment_sys', ins=feed, outs=['hydrolysate', 'wastewater'])

While I don't recommend it, it is also possible to change the defaults with:
>>> import biosteam as bst
>>> from biorefineries import cornstover as cs
>>> bst.settings.set_thermo(cs.chemicals)
>>> SF = cs.create_hot_water_pretreatment_system
>>> feed = bst.Stream('miscanthus', Water=0.7, ..., total_flow=1000, units='kg/s')
>>> SF.ins = [feed] # Change attribute

Checkout this chapter for more help on system factories:
https://biosteam.readthedocs.io/en/latest/tutorial/Creating_a_System.html


Run user supplied onChangeText callback when component mounts

When the component mounts it runs _onChangeText but does not run textInputProps.onChangeText

@guilhermepontes Can you please look at this PR?


Fix a false positive for Lint/SuppressedException

This PR fixes a false positive for Lint/SuppressedException when empty rescue with comment in def.
% cat example.rb
def foo
  do_something
rescue
  # noop
end

% bundle exec rubocop --only Lint/SuppressedException
(snip)

Inspecting 1 file
W

Offenses:

example.rb:3:1: W: Lint/SuppressedException: Do not suppress exceptions.
rescue
^^^^^^

1 file inspected, 1 offense detected

The above code should not be warned because AllowComments: true by defualt.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Looking forward to this 🎉
Can you make sure that inline comments are also ok? (See #7999) E.g.:
def foo
  bar
rescue # ignore
end

Certainly! Also the following code seems to be able to do the same.
begin
  bar
rescue # ignore
end

I think that these cases can be extended separately from this PR.


Issue with wiredep

Hi,
I have been encountering a problem with using wiredep with this package, the main paths in the bower.json files are wrong. I believe they should be dist/ prefixed for wiredep and other bower packages to work normally.
Could you please push a fix for that issue ?
Thanks

Hi @MaximeBrt,
You are correct. The package.json file points to the dist folder. Fixed and released in v1.0.3


fix chromecast platform

Describe the bug
Command rnv run -p chromecast in template starter folder  opens template starter web page instead of chromecast page.
To Reproduce
Steps to reproduce the behavior:

Go to template starter folder
Run command: "npx rnv run -p chromecast"
Go to http://localhost:8095
See error

app-harness tested on fix/chromecast_template_view branch

no available devices found on android
nothing happens on ios
more info here -> https://github.com/flexn-io/renative/pull/1459#issuecomment-2051070086


eksctl: 0.172.0 -> 0.173.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/weaveworks/eksctl/releases.
meta.description for eksctl is: A CLI for Amazon EKS
meta.homepage for eksctl is: https://github.com/weaveworks/eksctl
Updates performed

Golang update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.173.0 with grep in /nix/store/r5afnvmnz0ghdg6gavp1kzmzxsiy03yz-eksctl-0.173.0
found 0.173.0 in filename of file in /nix/store/r5afnvmnz0ghdg6gavp1kzmzxsiy03yz-eksctl-0.173.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
eksctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/r5afnvmnz0ghdg6gavp1kzmzxsiy03yz-eksctl-0.173.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A eksctl https://github.com/r-ryantm/nixpkgs/archive/1048982ea126aadd3aee8730813c4e6873360b19.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1048982ea126aadd3aee8730813c4e6873360b19#eksctl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/r5afnvmnz0ghdg6gavp1kzmzxsiy03yz-eksctl-0.173.0
ls -la /nix/store/r5afnvmnz0ghdg6gavp1kzmzxsiy03yz-eksctl-0.173.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

eksctl

Maintainer pings
cc @xrelkd @Chili-Man for testing.

Hmm seems review comments still don't work

@Lassulus
The similar situation occurred here: https://github.com/NixOS/nixpkgs/pull/292486#pullrequestreview-1910933880 .
I tried to call @NixOS/nixpkgs-merge-bot when I was approving the PR.

Yeah it seems we registered to the wrong event. A normal comment should work though

@NixOS/nixpkgs-merge-bot merge

@Lassulus It works now, does @nixpkgs-merge-bot merge the PR after all the CI checks passed?

ah thats because the other ones were review comments and we don't react on them right now. but the bot also waits for the CI checks to pass, except for darwin.

@Lassulus Thanks for the reply! I get it now.