an unknown crash happened in libflutter.so

#1. raster(208)

SIGILL(ILL_ILLOPC)

#00 pc<PHONE_NUMBER>1aee00 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#01 pc<PHONE_NUMBER>1aee3c /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#02 pc<PHONE_NUMBER>14d3e4 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#03 pc<PHONE_NUMBER>159b68 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#04 pc<PHONE_NUMBER>15986c /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#05 pc<PHONE_NUMBER>16a680 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#06 pc<PHONE_NUMBER>16b344 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#07 pc<PHONE_NUMBER>16aca8 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#08 pc<PHONE_NUMBER>134d00 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#09 pc<PHONE_NUMBER>057da4 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]11
#10 pc<PHONE_NUMBER>05117c /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#11 pc<PHONE_NUMBER>0516f4 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#12 pc<PHONE_NUMBER>08d4f8 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#13 pc<PHONE_NUMBER>087b90 /vendor/lib64/egl/libGLES_mali.so [arm64-v8a::b42cce7f4baef04af5a570791e7fb4c1]
#14 pc<PHONE_NUMBER>24a540 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#15 pc<PHONE_NUMBER>250584 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#16 pc<PHONE_NUMBER>24aef8 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#17 pc<PHONE_NUMBER>24d9f4 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#18 pc<PHONE_NUMBER>24e408 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#19 pc<PHONE_NUMBER>219680 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#20 pc<PHONE_NUMBER>1c37ec /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#21 pc<PHONE_NUMBER>1c41dc /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#22 pc<PHONE_NUMBER>0df18c /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#23 pc<PHONE_NUMBER>359394 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#24 pc<PHONE_NUMBER>282cc0 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#25 pc<PHONE_NUMBER>282cf8 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#26 pc<PHONE_NUMBER>291f54 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#27 pc<PHONE_NUMBER>291aa8 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#28 pc<PHONE_NUMBER>292c60 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#29 pc<PHONE_NUMBER>29266c /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#30 pc<PHONE_NUMBER>29bc1c /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#31 pc<PHONE_NUMBER>02c3a4 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]
#32 pc<PHONE_NUMBER>02f994 /data/app/~~I4FAtkvdoaXI0GnL6i4bvA==/com.speediance.faraday-9h8m9s9fkt_2TRth9Esw0Q==/lib/arm64/libflutter.so [arm64-v8a::cc1b92198b920deeaf629d449ffa9b9b]

Originally posted by @jkl705 in https://github.com/flutter/flutter/issues/114133#issuecomment-1296498943

doctor Info:
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.0.3, on Microsoft Windows [版本 10.0.19044.2130], locale zh-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
X cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
X Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[√] Chrome - develop for the web
[!] Visual Studio - develop for Windows (Visual Studio 15 生成工具 2017 15.9.35)
X Visual Studio 2019 or later is required.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2021.2)
[√] IntelliJ IDEA Community Edition (version 2021.2)
[√] Connected device (4 available)
! Device emulator-5554 is offline.
[√] HTTP Host Availability
the app is run on our devices but the common phone , and it's original android system(9 or 11)
cpu: aarch64(Android 11) or armeabi-v7a(Android 9)

Hello @jkl705. Are these errors you are getting in production apps?

hi @exaby73
yes there are,we get it from "bugly", a production like firebase crashlytics,
does the infomations help?

@flutter-symbolizer-bot flutter#v3.0.3 release arm64 android force https://github.com/flutter/flutter/issues/114341#issue-1429548224

From your doctor info, you don't seem to have the Android SDK set up properly. Is this the same machine you use to build your production apps?

backtrace:
#00  pc 0x00000000004e9f16  /data/app/com.ezviz-Z__Y6hx7aJt7vowgMvJ65g==/lib/arm/libflutter.so

Android SDK is set up already , we can build apk and run the apk

@jkl705 The format of your crash is missing some information. Please read flutter-symbolizer-bot on how these crash logs are supposed to look like. If possible, please do provide the logs in this format:

Crashes on Android should start with *** *** *** ... *** *** ***
A backtrace line that looks like 4  Flutter                        0x106013134 (Missing)

@flutter-symbolizer-bot flutter#v3.3.6 release arm64
#00  pc 0x0000000000c16a4c  /vendor/lib64/egl/libGLES_mali.so (cutils_uintdict_lookup_key+64)
#01  pc 0x00000000008497c4  /vendor/lib64/egl/libGLES_mali.so (cframep_frame_shaders_build_dcd+2132)
#02  pc 0x0000000000857240  /vendor/lib64/egl/libGLES_mali.so (cframep_mfbd_set_frame_shaders_information+120)
#03  pc 0x0000000000869c8c  /vendor/lib64/egl/libGLES_mali.so (cframep_fbd_build+2420)
#04  pc 0x000000000084d8c4  /vendor/lib64/egl/libGLES_mali.so (cframep_manager_fbd_create+228)
#05  pc 0x000000000085086c  /vendor/lib64/egl/libGLES_mali.so (cframep_enqueue_new_fragment_job+968)
#06  pc 0x000000000084ea08  /vendor/lib64/egl/libGLES_mali.so (cframe_manager_complete_flush+448)
#07  pc 0x000000000084fa40  /vendor/lib64/egl/libGLES_mali.so (cframep_manager_flush+400)
#08  pc 0x00000000007de590  /vendor/lib64/egl/libGLES_mali.so (gles_surfacep_converter_copy_on_gpu+600)
#09  pc 0x00000000007de040  /vendor/lib64/egl/libGLES_mali.so (gles_surface_convert_pixels_to_surface_internal+632)
#10  pc 0x00000000007dd89c  /vendor/lib64/egl/libGLES_mali.so (gles_surface_convert_pixels_to_surface+108)
#11  pc 0x00000000007f4e94  /vendor/lib64/egl/libGLES_mali.so (gles_texturep_upload_3d+1368)
#12  pc 0x00000000007f5638  /vendor/lib64/egl/libGLES_mali.so (gles_texturep_upload_2d+60)
#13  pc 0x00000000007e802c  /vendor/lib64/egl/libGLES_mali.so (gles_texture_tex_sub_image_2d+984)
#14  pc 0x00000000007a49a0  /vendor/lib64/egl/libGLES_mali.so (glTexSubImage2D+84)
#15  pc 0x00000000005593ec  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.m yapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#16  pc 0x000000000055592c  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#17  pc 0x00000000004e0fdc  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#18  pc 0x00000000004e2eb4  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#19  pc 0x00000000004daabc  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#20  pc 0x00000000004daa70  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#21  pc 0x00000000004e2c54  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#22  pc 0x00000000004dc338  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#23  pc 0x00000000004dce00  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#24  pc 0x00000000003f9aa4  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#25  pc 0x0000000000694488  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#26  pc 0x0000000000592ba4  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#27  pc 0x00000000005a34e0  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#28  pc 0x00000000005a40e4  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#29  pc 0x00000000005a3af8  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#30  pc 0x00000000005ad3b0  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#31  pc 0x00000000003460cc  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#32  pc 0x0000000000349658  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#33  pc 0x0000000000019da8  /system/lib64/libutils.so (android::Looper::pollInner(int)+916)
#34  pc 0x00000000000199ac  /system/lib64/libutils.so (android::Looper::pollOnce(int, int*, int*, void**)+112)
#35  pc 0x0000000000012c74  /system/lib64/libandroid.so (ALooper_pollOnce+100)
#36  pc 0x0000000000349764  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#37  pc 0x0000000000347d8c  /data/app/~~xfU50K_1ytNe9DQ3tlrN1A==/com.myapp.app-W0NvdxH_YvegDMWA8Q6TFw==/split_config.arm64_v8a.apk!libflutter.so
#38  pc 0x00000000000eb7a8  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+64)
#39  pc 0x000000000008bc8c  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64)


some fdd floppy images are not working

I noticed a couple of games from Mame software list such as dna, amidacho (Amida ChonChon), bbalfin (Battle Block Alfin), inthedun (In the Dungeon) are not working and they are all in fdd format.
But some are working such as atlantia.
Is there something to fix here or are they just bad images?

NP2 can't read .fdd files.
But it can convert .fdd to raw image(BKDSK, .HD4 file) with VFIC(Virtual Floppy Image Converter).
I can read converted .HD4 files on NP2kai.
To play games, it needs tune some files in .HD4 file.

I added applying to 1.44MB FDD image code.
Please try next buildbot’s output core.

It's working, I can play all 3 fdd games I mentioned before! 👍
Thank you, closing this now.
Fixed with https://github.com/AZO234/NP2kai/commit/79e8698eb5471a0e99ba5b8abb8eb44eefd0de03


I2C breadboard PNG update

The CS pin should be connected to 3.3v  This is required to enable the I2C interface.   This must be connected to 3.3 volts before the VCC pin is connected to 3.3v.  The connection order is documented in the Datasheet, not sure if you want to make any mention of this detail in this location, failure to do this could be frustrating debug.            Also, the SDO pin determines the chips I2C address.  If this example remains with 0x77 as the default address the SDO pin should be connected to 3.3v                                     I decided I would not attempt this artwork update, although I should update my environment to do so.

Thanks & fixed!


Robotcode debuger - GitHub Actions

Hello Daniel,
have you tried your debuger with GitHub Actions?
Thank you

Hi Marta,
No, not with Github Actions, but with Gitlab Pipelines. However, the procedure should be the same. Depending on where your test is running, you need to have network access to this machine to reach the debugger.
The easiest way to do this is with your own Github Actions Runner in your own network in a VM or a dedicated computer. You can find descriptions of how to set this up on the web.
Have you already tried it?

Thank you for your quick reply.
No, I have not yet.


Feature/725 admin recurring donation person select

Motivation and context
Improve #708
Made the selection of a user for the recurring donation more user friendly and is now not a text field.
Added a useConfirm hook which according to the discussion here #697.
Added a <FormFieldButton /> component which mimics the look of a material field, but acts as a button.
Added a <PersonSelectDialog /> component which renders a dialog with an autocomplete where you can choose a person and get his information shown so that you are sure what you are selecting.
Notes for the reviewer:
The API call for the personList would be a very heavy one and I don't think it's worth it just to populate an Autocomplete. It would be a better idea to only fetch like a list of the  {id, firstName, lastName} or paginate that call in some way.
However this is an admin platform and maybe it's not that big of a deal. I am not sure :|
Screenshots:

Before
After

:tada:


Backport two test fixes/changes to chef-14

Backports #8359 and #8352

travis failure was an unrelated timeout.


Fix code analysis errors

Add static when possible
Remove unused private members
Remove unused out parameters

I don't know who owns all these areas so I added GH suggested reviewers 😋

My understanding is they're IDE* diagnostics that only show in VS. I don't know why that's the case. They only appeared for me after updating VS.


implement semantic-release

implement semantic release and automate releases based on commits since last release

implemented in #24

implemented in #24


Invoking deepspeed with HF token converts flags to literal values

I've modified the CLI in this script to accept a repo and an HF token, so I can push to the hub from the script. (I'm integrating PEFT, so the resulting artefacts are a bit different.)
However, it seems as though the token is masked, but it breaks the CLI, as the {foo} flags are passed literally, and the dollar-values are completely omitted.
This is the command in the notebook I modified (note the two extra params at the end):
!deepspeed {num_gpus_flag} \
    --module training.trainer \
    --input-model {input_model} \
    --deepspeed {deepspeed_config} \
    --epochs $epochs \
    --local-output-dir {local_output_dir} \
    --dbfs-output-dir {dbfs_output_dir} \
    --per-device-train-batch-size $batch_size \
    --per-device-eval-batch-size $batch_size \
    --logging-steps 10 \
    --save-steps 200 \
    --save-total-limit 20 \
    --eval-steps 50 \
    --warmup-steps 50 \
    --test-size 100 \
    --lr $lr \
    --repo-name $repo_name \
    --hf_token $huggingface_token

Here's a clue from the log that those bracketed values are passed literally:

/local_disk0/.ephemeral_nfs/envs/pythonEnv-437fc41d-a20b-4579-bf72-9fbfcb02b73f/bin/python: can't open file<EMAIL_ADDRESS>[Errno 2] No such file or directory

This issue continues the discussion in #158

Is num_gpus_flag actually set in your modification?

Yes. The command stops working when I add --hf_token $huggingface_token.

Yeah should both work. It really seems like num_gpus_flag isn't set. Can you print it in Python above this command to be sure?

I'm trying to recreate this in a new notebook.

Also from faulty notebook, just to show the token works:

Ah, I found the issue.
After the above code where I set the token, I do a pip install, which does:

Python interpreter will be restarted.

...which wipes the token variable.
So sorry to have wasted your time with this! Thanks for your help, as always :)

I've added this as an idea here for developer experience: https://ideas.databricks.com/ideas/DBE-I-1116

Are you using the latest runtime? it does not restart the python interpreter - leaves it up to you. If that's the idea, it is done already

Are you using the latest runtime? it does not restart the python interpreter - leaves it up to you. If that's the idea, it is done already

Thanks for the tip - I'll look into getting interpreter restart disabled.


Swagger Doc not reachable

Hi, the link http://localhost:8080/swagger-ui.html only gives back:
Whitelabel Error Page

This application has no explicit mapping for /error, so you are seeing this as a fallback.
Wed Oct 21 18:44:52 UTC 2020
There was an unexpected error (type=Not Found, status=404).
No message available

Dropping swagger support in the next release, it is dead in this regard anyway - either will adopt the openapi way or anything else.


Issue36 include class coverage

Added showclassnames parameter to add class names and class code coverage results to output. It defaults to false.
Updated README.md to reflect changes.

@Schnitzkin Thank you!
@irongut Any ideas how to continue on this?


Added "Readonly" flag for readonly properties

Readonly reflection flag for readonly properties is added.
This PR is related to #611
The way, the abstract flag is added to the reflection is changed. It fixes the issue that abstract accessors weren't considered so far.
To extend the discusson on #611:
Does it make sense to remove the Const flag in favor of the Readonly flag?

Const flag is added to const enumerations.

Thanks for the PR. This would close #585

@makana
TypeScript has a clear separation between Const and Readonly as so it is better that we follow their logic. When we are aligned with the language it's easier to understand the code and less chance of getting surprised.
When creating the UI it's easier as well, you want to show readonly on classes and const on variables and if they are consolidated you have to do some logic which is not optimal.
It's better to stick to the same path as TS and not create local terminology...

@shlomiassaf
Agreed. At least with my last commit (add const flag to enumerations) removing the const flag option is obsolete.
@aciccarello
Since the flag is added to the "relevantFlags" array, it will be automatically rendered in the default themes.

#1268 made these changes and has been merged in.


Call Results

Design an algorithm to call the contributed "Results.jsx" at the very moment the user enters the last word of the fetched paragraph without clicking any button.
Also implement a code to ensure that the actual results are being displayed as well. This can be done by modifying the Results.jsx file to replace the static values with the data fetched.
Update the display to reflect actual user statistics such as typing speed and accuracy.

Is this issue still up for grabs / part of 2023 HacktoberFest? If so, I would like to work on it  :-) I Saw your post in discord, but this issue is kind of old and doesn't have the HacktoberFest label, so not sure!

This is a Hacktoberfest task, and I've assigned the issue to you, so you can begin working on it. Please provide progress updates every 2-3 days.

@KaviyaKumarr I have created a PR for this first part of the issue to automatically have call results. The 2nd part I will add in another PR


Make $.rails.confirm() function event-based

This is an enhancement request for the confirm dialog override logic:
// Default confirm dialog, may be overridden with custom confirm dialog in $.rails.confirm
confirm: function(message) {
  return confirm(message);
},

The current implementation requires the use of the browser's native confirm dialog box, as the user's response value must be returned at the end of the $.rails.confirm function.
Native browser dialogs are not that nice (they are modal and cannot be styled) so often a custom dialog or overlay is used.  In that case, the user's response comes in asynchronously and the overridden $.rails.confirm function can no longer return the user's response value immediately.
If the responsibility of firing the response event is added to the "confirm function override" contract, this would be possible.
In other words, this issue is a request to move to a more event-based confirmation logic, making the base implementation something like:
// Default confirm dialog, may be overridden with custom confirm dialog in $.rails.confirm
// Make sure to fire the confirm:complete event once the user's response is known
confirm: function(message) {
  var answer = confirm(message);
  rails.fire(element, 'confirm:complete', [answer]);
},

Now complete freedom is given as long as once the user has made a choice, the confirm:complete event is fired.
Unfortunately it looks like the allowAction() usage logic will also need to become event based, making this a non-trivial change, but I hope you'll find this a worthwhile enhancement to make.

Oops, I didn't see a pull request was already made for this.  Closing.

https://github.com/rails/jquery-ujs/pull/196

I don't know if you saw this in the comments in that other pull request, but I have a separate branch that allows this. It was a fairly significant rewrite to get it working, and it relies on some undocumented features of jquery, so I'm trying to get as many people using it to make sure everything works and that there are no weird side effects.
https://github.com/JangoSteve/jquery-ujs/tree/async-confirm

Hi Akzhan,
I need the fix for https://github.com/rails/jquery-ujs/issues/222 which your branch version does not contain yet.
Would it be possible to update the branch with the latest code on master so I can test with an "official" version rather than a hand-merged version?

@symve, good point to do. Will do until 10th Jan.


inception_v3

Hi, would you know the setting used to train inception_v3 (for example, do you have something like the sample scripts on this page https://rwightman.github.io/pytorch-image-models/training_hparam_examples/ )
Thanks.

it's PyTorch weights which I believe were converted from original TF models way back


Added example

@pascalbros How about moving it to examples/ ? I think it would be better to have a little wrapper in main. A little abstraction around the Keccak etc. What do you think?

Sorry, don't have time for that.
If you can do that, just approve it, pull, update and push it again.
Thanks

@pascalbros I can also move it to example :) I will later take a look into an abstraction layer. Was just the question what you think about a wrapper. :)


How to find out what MCU to delete/copy/add

I have some damaged JPG files. Probably from bitrot. I think your tool would be able to fix them easily, but how do I find the numbers to put into the command? I can see in the image viewer where the messup is, but I do not know what number MCU it is. Is there some kind of a scan command? Do you use other software to analyze the JPEGs before repair?
Thanks

I have some damaged JPG files. Probably from bitrot. I think your tool would be able to fix them easily, but how do I find the numbers to put into the command? I can see in the image viewer where the messup is, but I do not know what number MCU it is. Is there some kind of a scan command? Do you use other software to analyze the JPEGs before repair?
Thanks

Can you upload jpg file zipped to here?

Sorry, I found a program that lets me do it graphically. Thanks.

@phirestalker , glad you found a solution.
If you wish to try again with this tool,
You first need to find the MCU block dimensions. With no arguments, you will see how to do this.
Show block dimensions using 'dest' with no other arguments
./jpegrepair before.jpg after.jpg dest
which will print something like this:
mcu blocks HxW = 260x125
Since this is not graphical, you would need to guess to find the location of interest,  but the block dimensions are small, so it should not take many guesses.
Try to insert or delete a block to see the location change.
./jpegrepair before.jpg after.jpg dest 100 0 insert 5
You could see the change. Once you find the location, then you can make the desired modifications.


use shell-quote.quote(args) instead of args.join(" ")

What this PR solves / how to test:
Follow-up to #4080, prompted by https://github.com/cloudflare/workers-sdk/pull/4211#issuecomment-1768101260
In my previous PR introducing shell-quote, I searched for instances of split(" ") and changed them to shellquote.parse(cmd)
In this PR, I searched for instances of join(" ") and changed them to shellquote.quote(args)
Author has included the following, where applicable:

[ ] Tests
[x] Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

Checked for inclusion of relevant tests
Checked for inclusion of a relevant changeset
Checked for creation of associated docs updates
Manually pulled down the changes and spot-tested

Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

Noticed the C3 E2E pnpm test failings with the Nuxt framework. I'm rebasing from main in hopes the test is fixed there


[IA-2746] Update Calhoun URLs to k8

These changes cannot be merged until there is a monolith release
Calhoun now lives in the terra k8s cluster, as opposed to google app engine.
https://ap-argocd.dsp-devops.broadinstitute.org/applications?search=calhoun
These changes work in dev (if you swap the value of calhounUrlRoot in public/config.json to the value in config/dev.json, you can verify)

(just a comment on your PR description)
FYI, public/config.json is actually symlinked to config/dev.json, so it shouldn't be possible to change one without changing the other, unless you've made a local change to the link.


Cancel Old Strike Jobs

Scale tries to queue strike jobs that were running so if a legacy strike job is running when upgrading scale, it will fail to queue due to a key error on "Strike_ID".  We should check for that key and raise an exception if it is not there and the queue job message handler should catch such exceptions and cancel the job so we don't have queue job messages clogging up the queue with jobs that can't be queued.

Fixed by #1650


docs: fix broken BackendTLSPolicy samples

What this PR does / why we need it:
Fix BackendTLSPolicy samples in docs so they will be aligned with Gateway API v1.1.0.
Which issue(s) this PR fixes:

Fixes #

Thanks for fixing this!
BTW, since the GRPCRoute also got updated to v1, can you send another PR to fix all the example around it in the doc? TIA!

No API changes have been introduced in GRPCRoute besides addition of new sessionPersistence field under GRPCRouteRule, so no changes are required in docs.

Thanks for fixing this!

BTW, since the GRPCRoute also got updated to v1, can you send another PR to fix all the example around it in the doc? TIA!

No API changes have been introduced in GRPCRoute besides addition of new sessionPersistence field under GRPCRouteRule, so no changes are required in docs.

Thanks for confirming this！


Providing policy_arn_count is redundant.

Since the v0.12 update, providing policy_arn_count alongside policy_arns as a list since is can be extrapolated with length(var.poliy_arns). Doing it this way also mitigates user error in the case of a mismatch between policy_arn_count and the actual count of items in policy_arns.

Thanks for the suggestion. It has been pushed in the latest release.


"guild"-less users aren't caught in regex

Users that aren't in a guild can't get through the filter, since the regex requires  to be matched

vladimir, the wizard gave me this:
/.+?(?:@From)\s+(?:<(.+)>\s+)?(.+):\s+(.*)/i
will return guild as undefined if there is none...


AB#5099 fixed sorting devices by os

Proposed changes

Related issues

Checklist

[ ] I consider the submitted work as finished
[ ] I tested the code for its functionality
[ ] I wrote test cases for the relevant uses case
[ ] I added/update the relevant documentation (either on github or on notion)
[ ] Where necessary I refactored code to improve the overall quality

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

This looks good locally, @r-joyce please review and merge into develop.


Diamond Helper Functions

Summary
EIP2535 is a standard quickly growing in popularity and adoption. While Diamonds offer a great pathway for scaling contracts there are not many tools for managing deployments or upgrades. This PR introduces utility functions that provide developers with a consistent and reliable way of maintaining their contracts. The key goal here is to offer tools that perform the minimal changes necessary to add, replace, or remove facets from a Diamond.
Usage
General

diamondCut - calls Diamond.diamondCut
printDiamond - prints a table containing the registered and unregistered selectors

Deployment

addUnregisteredSelectors - adds unregistered selectors to the Diamond.

Upgrade

replaceRegisteredSelectors - replaces any selector which is registered to a different target address
removeRegisteredSelectors - removes the registered selector from the Diamond

Examples
// TestFacets.sol

contract Test1Facet {
    function test1Func1(bool) public returns (bytes32[] memory) {}
    function test1Func2(int128) external view returns (address) {}
    function test1Func3(address, address, address) external {}
}

contract Test1Facet1 {
    function test1Func1(bool) public returns (bytes32[] memory) {}
    function test1Func2() external view returns (address) {}
}

contract Test2Facet {
    function test2Func1() external pure returns (uint8) {}
    function test2Func2(bytes8) external view returns (bool) {}
}

// deploy.ts

// deploy Diamond
// registers selectors from Test1Facet and Test2Facet on Diamond
let facetCut = await addUnregisteredSelectors(Diamond, [Test1Facet, Test2Facet]);
await diamondCut(Diamond, facetCut);

// upgrade Diamond
// adds Test1Facet1.test1Func2, since the signature has changed
facetCut = await addUnregisteredSelectors(Diamond, [Test1Facet1]);
await diamondCut(Diamond, facetCut);

// replace Test1Facet.test1Func1 with Test1Facet1.test1Func1
facetCut = await replaceRegisteredSelectors(Diamond, [Test1Facet1]);
await diamondCut(Diamond, facetCut);

// removes Test1Facet.test1Func2 and Test1Facet.test1Func3
facetCut = await removeRegisteredSelectors(Diamond, [Test2Facet, Test1Facet1]);
await diamondCut(Diamond, facetCut);

Actions

[ ] Add tests to repo

@NouDaimon thanks for the feedback! I have a bunch of changes on my local which I plan on pushing this week. I will update the description with my checklist of things before this is ready to come out of draft.

Any recommendations on where I should add tests and contracts?
cc @ItsNickBarry

In https://github.com/solidstate-network/solidstate-solidity/pull/158/commits/3d9d4568e952998dafc71baacaf4103b93bf1319 I introduced the concept of filters.  The exclude filter will ignore all selectors defined in the exclude filter for that contract, all other selectors will get added/replaced/removed.
await d.addUnregisteredSelectors(Diamond, [Test1Facet1])

// [{
//   target: '0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0',
//   action: 0,
//   selectors: [ '0xc2985578', '0x0716c2ae' ]
// }]

await d.addUnregisteredSelectors(
  Diamond,
  [Test1Facet1],
  [{ contract: Test1Facet1.address, selectors: ['0xc2985578'] }],
  [],
);

// [{
//   target: '0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0',
//   action: 0,
//   selectors: [ '0xc2985578' ]
// }]

await d.addUnregisteredSelectors(
  Diamond,
  [Test1Facet1],
  [],
  [{ contract: Test1Facet1.address,selectors: ['0xc2985578'] }],
)

// [{
//   target: '0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0',
//   action: 0,
//   selectors: [ '0x0716c2ae' ]
// }]

The only and exclude filters must not overlap, therefore a contract may define selectors in the only or exclude filter, not both.

Hey, anything happening with this PR? Does anyone need some help and getting it finished? I saw a lot of promise in it.

@jhubbardsf  I've shifted focus to a WIP plugin that manages diamond upgrades.  It's easier to add the functions I need there first, and then determine how to structure what's been added here.  This will be merged eventually.


Add variant QC pipeline functions from gnomad_qc code

This PR is a bit big, but most of it is generalizing or adding functions from gnomad_qc that we will also be using in other pipelines

One more thing, seems like we've lost generate_final_rf_ht in the process -- was this on purpose?

Yeah I removed generate_final_rf_ht intentionally #224 (comment)

All right. Let's revisit once we have a plan for the finalization script in general.


Token expired & failure to update email cron

Hi, First of all I wanted to thank you for your “creation,” it is really saving me since we switched to microsoft 365
Unfortunately, I've been stuck on two points for a few days, the first one:
I realized that after about a day the token used to connect to the mail account expires:
I, [2024-12-18T08:02:26.564560 #1]  INFO -- : Started GET "/admin/mail_job_schedules/start_mail_sync/1" for ... at 2024-12-18 08:02:26 +0100
I, [2024-12-18T08:02:26.567132 #1]  INFO -- : Processing by Admin::MailJobSchedulesController#start_mail_sync as HTML
I, [2024-12-18T08:02:26.567233 #1]  INFO -- :   Parameters: {"id"=>"1"}
I, [2024-12-18T08:02:26.575188 #1]  INFO -- :   Current user: ... (id=7)
E, [2024-12-18T08:02:27.018287 #1] ERROR -- : Access token expired, refreshing...
E, [2024-12-18T08:02:27.021524 #1] ERROR -- : Token refresh failed: {}
I, [2024-12-18T08:02:27.022861 #1]  INFO -- : Completed 500 Internal Server Error in 455ms (ActiveRecord: 4.3ms (10 queries, 1 cached) | GC: 0.4ms)
F, [2024-12-18T08:02:27.025355 #1] FATAL -- :
ArgumentError ('3' is not a valid sync_status):

Causes:
OAuth2::Error ({})

plugins/redmine_mail_ticket_sync_pro/app/services/outlook_mail_service.rb:137:in `rescue in refresh_access_token'
plugins/redmine_mail_ticket_sync_pro/app/services/outlook_mail_service.rb:126:in `refresh_access_token'
plugins/redmine_mail_ticket_sync_pro/app/services/outlook_mail_service.rb:112:in `refresh_token_if_expired'
plugins/redmine_mail_ticket_sync_pro/app/services/outlook_mail_service.rb:14:in `initialize'
plugins/redmine_mail_ticket_sync_pro/app/controllers/admin/mail_job_schedules_controller.rb:84:in `new'
plugins/redmine_mail_ticket_sync_pro/app/controllers/admin/mail_job_schedules_controller.rb:84:in `start_mail_sync'
lib/redmine/sudo_mode.rb:78:in `sudo_mode'

If i re-atuthenticate the mail the manual sync-mail run correctly, is a my error?
The second question is for the cron,

If you look at the image you will see that I have set the cron to check emails every minute, however, this does not happen.
Could I have made a mistake here too? do you think there is maybe a script that I can make myself and start from my server?
For example in the past I simply did:
cd /usr/src/redmine/
rake redmine:email:receive_imap \
        RAILS_ENV=production \
        host=imap.gmail.com port=993 ssl=true \
<EMAIL_ADDRESS>password="app-password" \
        project=assistenza tracker=support \
        unknown_user=accept no_permission_check=1

there are no failure or attempt logs.
I return the thanks towards you for your work done

@othin1 Did you pulled my latest changes?
If yes then new token will be automatically updated using the refresh token from cron or manual sync
Regarding the crontab
Check your system is blocking to update crontab or crontab is updated
using the below command
crontab -e

hello, thank you in the meantime for your reply
I did subsequently pull but a parameter in routes.rb changed so now I am trying to solve that part (I need to figure out the callbackurl, before it was https://mysite/auth/callback
Now is different
For the crontab i've a redmine in docker, so the crontab is outside

Yes, now i have added support to gmail & outlook so you need to build callback url like below
https://mysite/auth/callback/gmail
https://mysite/auth/callback/outlook
you need to pass the provider in the url like above

May be that cause issue in running cron as it couldn't find the application path

YEah thanks

Now I understand how it works, basically failing to call the cron also expires the token...clear the problem now I have to find a way to call the cron from outside...
Maybe I can do as I used to do in the past :
docker exec -i deployment_redmine_1 /bin/bash /usr/src/redmine/path-of-cron
what do you think, could I do it?

meanwhile i', working on this call: "curl -s https://mysite/admin/mail_job_schedules/start_mail_sync/2"
maybe i can simulate the manual call

Yes it should work for running cronjob, okay

unfortunately calling that url from within the server doesn't help, without the token it's no use...I'll keep trying to make it docker compatible, I'm so close to it now

i've two way now:
1: use this command: RAILS_ENV=production project=assistenza email=myemail bundle exec rake emails:fetch_and_create_issues But I need to fix something...I'm starting it in /usr/src/redmine
second way, stupid not to think of it earlier, install cron in the docker with the classic “apt install cron”

I hope it is working as expected

I realized two things, the first is that probably if I in docker had installed and activated “cron” maybe everything would have gone as it should (in the official redmine docker it is inactive). I should do some testing but I can't right now, in case I will write you.
Second thing you can do cron externally with this command:
* * * * * * docker exec deployment_redmine_1 /bin/bash -l -c 'cd /usr/src/redmine && RAILS_ENV=production bundle exec rake emails:fetch_and_create_issues project=assistance<EMAIL_ADDRESS>--silent >> /usr/src/redmine/app/log/assistance_services-it.log 2>&1'
The only issue (there is never peace...) is that it does not send emails to every ticket generated.
I will investigate this aspect at my leisure.
thanks for the patience


copy() on LabelMultisetType re-uses the underlying access, but should not

The desired behavior for copy() on a type is to keep the value independant of the value that was copied. For example, we should expect this type of test to work:
final FromIntegerTypeConverter<IntType> intToLmt = new FromIntegerTypeConverter<>();

final LabelMultisetType one = LabelMultisetType.singleEntryWithSingleOccurrence();
intToLmt.convert(new IntType(1), one);

final LabelMultisetType two = one.copy();
intToLmt.convert(new IntType(2), two);

Assert.assertEquals(1, one.getIntegerLong());
Assert.assertEquals(2, two.getIntegerLong());

however, it fails, since one.getIntegerLong() now is set to 2.
Making them independant will require copying the access over that LabelMultisetType, but is more consistent with how copy() is expected to be able to be used by other Imglib2 libraries. Specifically, Converters and OutOfBounds values expect to be able to copy the type instance that was provided, and when setting them later (if done), can cause odd behavior, particularly when multithreading.

closed by #27


[WIP] Ref conv kernel for Quantized conv

Not mature yet. Needs generalizing and some edge case handling.

I created some more unit tests for QLinearConv in PR #2705 .  Let's plan to merge the changes here through that PR.

#2840


Migration issues from 1.14.4 to 1.15.0 on task table

Unfortunately, I mistakenly deployed my team's instance of Gitea using the 'latest' tag of the official Gitea docker image around 3-4 months ago (I believe it was around version 1.14.2 at that time) thinking it was the latest stable release rather than an unstable dev version. I upgraded to the stable gitea/gitea:1.14.4 about 2 months ago. It required me to force migrate the underlying sqlite db in order for it to take. My hope was that some of the extra fields it added, but didn't use yet, would simply be used properly upon upgrade to the next release version. Yesterday I backed up my volume and attempted to upgrade to 1.15.0 but it failed during db migration.
What is the simplest way to ensure I'm back to the correct db schema version? Should I just blast away the volume, start with a fresh install, re-configure, and re-push all local repos to the new installation?

Gitea version (or commit ref): 1.14.4 -> 1.15.0
Git version:
Operating system: official docker image
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No

Log gist:

1.14.4 (Current warnings relating to current db schema)

2021/08/26 12:26:49 routers/init.go:150:GlobalInit() [I] SQLite3 Supported
2021/08/26 12:26:49 routers/init.go:68:initDBEngine() [I] Beginning ORM engine initialization.
2021/08/26 12:26:49 routers/init.go:75:initDBEngine() [I] ORM engine initialization attempt #1/10...
2021/08/26 12:26:49 ...om/urfave/cli/app.go:524:HandleAction() [I] PING DATABASE sqlite3
2021/08/26 12:26:49 ...rfave/cli/command.go:173:Run() [W] Table mirror has column lfs_enabled but struct has not related field
2021/08/26 12:26:49 ...rfave/cli/command.go:173:Run() [W] Table mirror has column lfs_endpoint but struct has not related field
2021/08/26 12:26:49 ...rfave/cli/command.go:173:Run() [W] Table email_address has column lower_email but struct has not related field
2021/08/26 12:26:49 ...rfave/cli/command.go:173:Run() [W] Table email_address has column is_primary but struct has not related field
2021/08/26 12:26:49 ...rfave/cli/command.go:173:Run() [W] Table task has column message but struct has not related field
2021/08/26 12:26:49 routers/init.go:155:GlobalInit() [I] ORM engine initialization successful!
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: update_mirrors
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: repo_health_check
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: check_repo_stats
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: archive_cleanup
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: sync_external_users
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: deleted_branches_cleanup
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: update_migration_poster_id
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: cleanup_hook_task_table
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: delete_inactive_accounts
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: delete_repo_archives
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: git_gc_repos
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: resync_all_sshkeys
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: resync_all_sshprincipals
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: resync_all_hooks
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: reinit_missing_repos
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: delete_missing_repos
2021/08/26 12:26:49 ...odules/cron/tasks.go:120:RegisterTask() [D] Registering task: delete_generated_repository_avatars
2021/08/26 12:26:49 ...er/issues/indexer.go:142:func2() [I] PID 18: Initializing Issue Indexer: db
2021/08/26 12:26:49 ...er/issues/indexer.go:221:func3() [I] Issue Indexer Initialization took 22.5µs
2021/08/26 12:26:49 ...xer/stats/indexer.go:38:populateRepoIndexer() [I] Populating the repo stats indexer with existing repositories
2021/08/26 12:26:49 ...ueue_disk_channel.go:162:Run() [D] PersistableChannelUniqueQueue: repo_stats_update Starting
2021/08/26 12:26:49 ...ue/queue_bytefifo.go:96:Run() [D] unique-level: repo_stats_update-level Starting
2021/08/26 12:26:49 ...xer/stats/indexer.go:84:populateRepoIndexer() [I] Done (re)populating the repo stats indexer with existing repositories
2021/08/26 12:26:49 ...ueue_disk_channel.go:162:Run() [D] PersistableChannelUniqueQueue: pr_patch_checker Starting
2021/08/26 12:26:49 ...ue/queue_bytefifo.go:96:Run() [D] unique-level: pr_patch_checker-level Starting
2021/08/26 12:26:50 ...ueue_disk_channel.go:137:Run() [D] PersistableChannelQueue: task Starting
2021/08/26 12:26:50 ...ue/queue_bytefifo.go:96:Run() [D] level: task-level Starting
2021/08/26 12:26:50 cmd/web.go:189:listen() [I] Listen: http://<IP_ADDRESS>:3000
2021/08/26 12:26:50 cmd/web.go:192:listen() [I] LFS server enabled
2021/08/26 12:26:50 ...s/graceful/server.go:62:NewServer() [I] Starting new Web server: tcp:<IP_ADDRESS>:3000 on PID: 18
2021/08/26 12:26:50 ...s/graceful/server.go:75:func1() [D] Starting server on tcp:<IP_ADDRESS>:3000 (PID: 18)

1.15.0 (Errors seen during attempted migration from 1.14.4 w/ schema discrepancies)

2021/08/26 11:57:38 routers/init.go:93:GlobalInit() [I] SQLite3 Supported
2021/08/26 11:57:38 routers/common/db.go:20:InitDBEngine() [I] Beginning ORM engine initialization.
2021/08/26 11:57:38 routers/common/db.go:27:InitDBEngine() [I] ORM engine initialization attempt #1/10...
2021/08/26 11:57:38 ...om/urfave/cli/app.go:524:HandleAction() [I] PING DATABASE sqlite3
2021/08/26 11:57:38 ...ations/migrations.go:419:Migrate() [I] Migration[178]: Add LFS columns to Mirror
2021/08/26 11:57:38 routers/common/db.go:28:InitDBEngine() [W] Table mirror has column id but struct has not related field
2021/08/26 11:57:38 routers/common/db.go:28:InitDBEngine() [W] Table mirror has column repo_id but struct has not related field
2021/08/26 11:57:38 routers/common/db.go:28:InitDBEngine() [W] Table mirror has column interval but struct has not related field
2021/08/26 11:57:38 routers/common/db.go:28:InitDBEngine() [W] Table mirror has column enable_prune but struct has not related field
2021/08/26 11:57:38 routers/common/db.go:28:InitDBEngine() [W] Table mirror has column updated_unix but struct has not related field
2021/08/26 11:57:38 routers/common/db.go:28:InitDBEngine() [W] Table mirror has column next_update_unix but struct has not related field
2021/08/26 11:57:38 ...ations/migrations.go:419:Migrate() [I] Migration[179]: Convert avatar url to text
2021/08/26 11:57:38 ...ations/migrations.go:419:Migrate() [I] Migration[180]: Delete credentials from past migrations
2021/08/26 11:57:38 ...ations/migrations.go:419:Migrate() [I] Migration[181]: Always save primary email on email address table
2021/08/26 11:57:38 routers/common/db.go:28:InitDBEngine() [W] Table email_address Column lower_email db nullable is true, struct nullable is false
2021/08/26 11:57:40 ...ations/migrations.go:419:Migrate() [I] Migration[182]: Add issue resource index table
2021/08/26 11:57:40 ...ations/migrations.go:419:Migrate() [I] Migration[183]: Create PushMirror table
2021/08/26 11:57:40 ...ations/migrations.go:419:Migrate() [I] Migration[184]: Rename Task errors to message
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column id but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column doer_id but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column owner_id but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column repo_id but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column start_time but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column end_time but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column payload_content but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column message but struct has not related field
2021/08/26 11:57:40 routers/init.go:97:GlobalInit() [W] Table task has column created but struct has not related field
2021/08/26 11:57:40 routers/common/db.go:33:InitDBEngine() [E] ORM engine initialization attempt #1/10 failed. Error: migrate: do migrate: error in table task after rename: duplicate column name: message

I think my issue might be related.
I had one failed migration attempt. After rolling back I attempted it again, and received this:

2021/08/28 21:16:30 ...ations/migrations.go:49:Migrate() [I] [SQL] SELECT `INDEX_NAME`, `NON_UNIQUE`, `COLUMN_NAME` FROM `INFORMATION_SCHEMA`.`STATISTICS` WHERE `TABLE_SCHEMA` = ? AND `TABLE_NAME` = ? [gitea task] - 1.345881ms     2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column id but struct has not related field                                         2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 doer_id but struct has not related field
2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 owner_id but struct has not related field
2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 repo_id but struct has not related field
2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 start_time but struct has not related field
2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 end_time but struct has not related field
2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 payload_content but struct has not related field
2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 message but struct has not related field
2021/08/28 21:16:30 routers/init.go:97:GlobalInit() [W] Table task has column
 created but struct has not related field
2021/08/28 21:16:30 ...ations/migrations.go:422:Migrate() [I] [SQL] ALTER TAB
LE `task` CHANGE errors message text [] - 19.307246ms
2021/08/28 21:16:30 ...ations/migrations.go:422:Migrate() [I] [SQL] ROLLBACK
[] - 162.84µs
2021/08/28 21:16:30 routers/common/db.go:33:InitDBEngine() [E] ORM engine ini
tialization attempt #6/10 failed. Error: migrate: do migrate: Error 1060: Dup
licate column name 'message'
2021/08/28 21:16:30 routers/common/db.go:34:InitDBEngine() [I] Backing off fo
r 3 seconds

I stopped Gitea and inspected the database...
The gitea.tasks table looked like this:
mysql> SHOW COLUMNS FROM task;
+-----------------+--------+------+-----+---------+----------------+
| Field           | Type   | Null | Key | Default | Extra          |
+-----------------+--------+------+-----+---------+----------------+
| id              | bigint | NO   | PRI | NULL    | auto_increment |
| doer_id         | bigint | YES  |     | NULL    |                |
| owner_id        | bigint | YES  |     | NULL    |                |
| repo_id         | bigint | YES  |     | NULL    |                |
| type            | int    | YES  |     | NULL    |                |
| status          | int    | YES  | MUL | NULL    |                |
| start_time      | bigint | YES  |     | NULL    |                |
| end_time        | bigint | YES  |     | NULL    |                |
| payload_content | text   | YES  |     | NULL    |                |
| message         | text   | YES  |     | NULL    |                |
| created         | bigint | YES  |     | NULL    |                |
| errors          | text   | YES  |     | NULL    |                |
+-----------------+--------+------+-----+---------+----------------+
12 rows in set (0.01 sec)

The message column seems to be empty on all rows:

mysql> SELECT id, message FROM task;
+----+---------+
| id | message |
+----+---------+
|  5 |         |
|  8 |         |
| 11 |         |
| 14 |         |
| 17 |         |
| 20 |         |
| 23 |         |
| 26 |         |
| 29 |         |
| 32 |         |
| 38 |         |
| 41 |         |
| 44 |         |
| 47 |         |
| 50 |         |
| 53 |         |
+----+---------+
16 rows in set (0.00 sec)

Hence I removed the "ghost"-column, as suggested:
mysql> ALTER TABLE task DROP COLUMN message;
Query OK, 0 rows affected (0.08 sec)
Records: 0  Duplicates: 0  Warnings: 0

... and started Gitea again.
The migrations continued and Gitea started back up with 1.15.0.
My "500 issue" from #16725 came back into action however.
I hope I do everyone a favor by using a Pastebin for the trace-log instead of extending this already long comment:
https://pasta.lysergic.dev/?6c1b79c0de06b567#7cqeueQrpzupubyJk6nbz5UiAwj4bN1nq7yAHH4Mdx1C

Migration appears successful however I still notice a few quirks that still exist:

in-line code review comments are not seen by anyone other than the author & no notification is sent that an in-line code review has started
one user shows with the same exact email

I just attempted the upgrade again with v1.15.2. Out of the box, similar errors about the column message appeared:
...
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column id but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column doer_id but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column owner_id but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column repo_id but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column start_time but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column end_time but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column payload_content but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column message but struct has not related field
2021/09/11 02:09:08 routers/init.go:97:GlobalInit() [W] Table task has column created but struct has not related field
2021/09/11 02:09:08 routers/common/db.go:33:InitDBEngine() [E] ORM engine initialization attempt #9/10 failed. Error: migrate: do migrate: Error 1060: Duplicate column
 name 'message'
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column id but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column doer_id but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column owner_id but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column repo_id but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column start_time but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column end_time but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column payload_content but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column message but struct has not related field
2021/09/11 02:09:11 routers/init.go:97:GlobalInit() [W] Table task has column created but struct has not related field
2021/09/11 02:09:11 routers/init.go:100:GlobalInit() [F] ORM engine initialization failed: migrate: do migrate: Error 1060: Duplicate column name 'message'
...

I again applied the "patch" from my last comment. It again allowed the database migrations to finish running, but this time did not cause any 500 errors.
Since it seems to be working this way, I will not downgrade a gain, but can someone confirm if this "patch"ed database is fine to be used, or if there is something possible trying to use this message column I removed in the future / in some feature?

It's fine.
The message field shouldn't have been present in the task table in the first place. I'm not sure how it got there - did you run a dev version on this db at some point? The Errors field in that task table has now been renamed to message and everything will work fine from now on.
Similarly the primary key problem coming back doesn't make any sense at all. Did you migrate using 1.15.0 and 1.15.2? You should just migrate using version 1.15.2 - once we release 1.15.y you shouldn't use 1.15.x where x<y. If you use 1.15.0 you're not going to get any of the fixes we make to migrations in say 1.15.6.
You're fine though. Just run the doctor recreate-table command for the issue_index primary key problem and you're done.

But for anyone else watching:

If we have versions up to 1.14.7 and 1.15.2.
and your current version is 1.14.2
just update to 1.15.2 or do 1.14.7 then 1.15.2 only.
DO NOT DO 1.14.3, ..., 1.14.7, 1.15.0, 1.15.1, 1.15.2

If you are on 1.14.3-1.14.6 because there was a bug in the dump command in these versions: if you backup your db using dump then you need to migrate to 1.14.7 to get a dump before you upgrade to 1.15 - but even then do not do 1.14.3,1.14.4,1.14.5,1.14.6,1.14.7 just go straight to 1.14.7 - make the dump and thence straight to 1.15.2.

So what do you do if you are on 1.13.x or lower?
Backup your db and go straight to 1.15.2 (or 1.15.x where X is the largest point release). That's it.
You can if you prefer go via 1.14.7 but you don't need to and from 1.15.3 that's a dead branch. Do not go via 1.14.0 etc - because if you do that you are needlessly exposing yourself to any bugs in migrations in 1.14.0 (which IIRC there were).
You get one shot at each migration.
We will mitigate bugs in migrations but better will fix them in the code so future users don't experience them. By going via out of date point releases you are needlessly exposing yourself to old bugs in these and preventing us from fixing things.


random uniform with dtype bfloat16 crashes on TPU backend

repro:
from jax import numpy as jnp
from jax import random
x = random.uniform(random.PRNGKey(0), (3,), dtype=jnp.bfloat16)

observation:
 - crashes on TPU backends (both internal and cloud TPU as far as I can tell)
 - CPU and GPU backends don't seem to crash
expect:
even if bfloat16 isn't supported by random.* on TPU it would be better to error-out rather than crashing

Google internal bug b/156977343.

I should add that it would be possible to workaround this bug by avoiding U16/S16 types on the JAX side. Since we have larger integer types available (U32, S32) this is possible if slightly annoying to do.

I think this should work now.

Thanks, @majnemer! I just double-checked on an internal TPU colab and indeed it works. Thanks to your team for the fix.


Update solution readme

This PR updates the README.md for the solutions. It adds a link to the binder for solutions, and it updated the full repository to open ut a binder for the solutions branch. The links to the "exercises" and "lectures" are not changed.

whops, wrong branch!

whops, wrong branch!


TSX intellisense does not initially show suggestions for properties when the tag is a dotted reference

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

perforce
slevesque
2.1.1

Steps to Reproduce:

Enter this code:

import * as React from 'react';

class F extends React.Component<void, void> {
    render() {
        <React.DOM.div
    }
}

With the cursor at the end of 'React.DOM.div' press control-space to bring up intellisense suggestions.

I see generic suggestions. I expect to see the props (properties, attributes) of div.

add to the code by typing className='abc' as below:
import * as React from 'react';

class F extends React.Component<void, void> {
render() {
<React.DOM.div className='abc'
}
}

Place cursor at the end of 'abc'. Press control-space to get suggestions. Now you get suggestions for the props of div

This is the expected result in step 2 above. The issue is that the suggestions are not made until you have specified an initial attribute.
This same issue occurs for custom react components that are imported in a way that requires a dotted path. This can also be demonstrated by assigning to a local variable:

Enter this code:

import * as React from 'react';
interface FooProps {
name: string;
value: number;
}
class Foo extends React.Component<FooProps, void> {
render() {
return
}
}
// This is atypical, but models import * as lib from 'mylib', and shows same behavior
let lib = {Foo: Foo};
class Usage extends React.Component<void, void> {
render() {
return <lib.Foo
}
}

Press control-space after lib.Foo. I expect to see props suggestions, but again just get generic suggestions.

Add a property after lib.Foo (e.g. name='abc'), and then press control-space. This behaves as expected, showing suggestions for children, key, ref, and value.

If instead of using 'lib.Foo' in step 5 you just reference 'Foo' directly, then the suggestions are as expected:

This is a major issue for our developers that are relying on intellisense for property suggestions with TSX, as many of our react components are imported using import * as vdl from 'VDL' and then referenced as vdl.VBox, vdl.Table, etc
Thank you for considering this issue.

What version of TS are you using? Here are the suggestions I see with TS 2.3.4 and TS 2.4:

That's it. I had Visual Studio Code locked to the TS 2.1.5 used by the build process for this code branch. When I switched to the VSC built-in TS 2.3.4 the intellisense behaved as expected. The issue can be closed.
Turns out this code branch is moving to TS 2.3 next week, so we won't see the problem much longer.
Thank you.


Implement docusaurus build, deployment and CI hooks

Initial implementation of docusaurus and CI infrastructure for SPL docs.  Docs content are just copies of the READMEs at the moment.
Currently served to both:
spl.docs.solana.com
spl-docs.solana.com
Does someone have an opinion on which domain to use?
CI will publish to the final domain each time the docs dir is touched on any commit to master.

I like spl-docs.solana.com more than spl.docs.solana.com (not a fan of the spl.docs.solana.com subdomain)
program-library.solana.com?

How about spl.solana.com?

I hear three options above from the two of you @mvines and @garious  :)  What'll it be?

I hear three options above from the two of you @mvines and @garious :) What'll it be?

This PR is not blocked by a choice or change of the domain, so we can pick one separately. Any feedback on the changes?

CI is happy, docs are now live on spl.solana.com


Context Provider API broke down

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: linux-arm64
- Continue: main/dev/preview
- IDE: vscode - code-server

Description
Seems in the recent versions of Continue preview, the context providers are not working anymore.
I implemented context providers through the API connection and they show in the list, but when I try to run them unfortunately they show no results.
@fry69 mentioned that there were recent changes to ESM for config.ts, might be a cause?
Discussion here: https://discord.com/channels/1108621136150929458/1273194528513458248
This wasn't the case a few builds ago.

here's an older build that runs the command with results

and here's a newer build:

To reproduce

Develop a Context Provider with submenu through extension handling
Verify if the submenu loads correctly

Hi @samir-abis-everest , thanks for opening this. To clarify, you have a context provider with submenu items, but when you select the context provider, the submenu is empty?
Could you clarify what you mean by this?

might be? I'm not sure if it's related because I build the configurations in my extensions instead of Continue

There was a bug with config.ts related to us moving to a newer Typescript target but that was resolved and I don't believe would have an impact here.

Hi @Patrick-Erichsen.

you have a context provider with submenu items, but when you select the context provider, the submenu is empty?

Correct

Could you clarify what you mean by this?

I just tried out with a context provider directly in the config.ts (the example one of the documentation, reading .md files) and it works on the older build, while on the new build it still doesn't work.

Got it - mind sharing your config.ts as well?

I've digged more through this in the debugger and this is the current status:
new version:
[2024-08-28T11:06:38] [DEBUG] Executing getSubmenuContextItems. Provider: lotse-context Query:  Limit: 70
[2024-08-28T11:06:38] [DEBUG] Executing getSubmenuSearchResults. Provider: lotse-context Query:
[2024-08-28T11:06:38] [DEBUG] Current minisearches: []
[2024-08-28T11:06:38] [DEBUG] No minisearch found for provider: lotse-context
[2024-08-28T11:06:38] [DEBUG] Using fallback results: 0

old version:
[2024-08-28T11:08:46] [DEBUG] Logging initialized
[2024-08-28T11:09:12] [DEBUG] Executing getSubmenuContextItems. Provider: lotse-context Query:   Limit: 70
[2024-08-28T11:09:12] [DEBUG] Executing getSubmenuSearchResults. Provider: lotse-context Query:
[2024-08-28T11:09:12] [DEBUG] Current minisearches: ["everest-nodes","everest-docs","lotse-context","markdown"]
[2024-08-28T11:09:12] [DEBUG] Search results for lotse-context: 0
[2024-08-28T11:09:12] [DEBUG] Using fallback results: 8

https://github.com/continuedev/continue/pull/2124


nixos/modules/system/boot/luksroot.nix: fallback on invalid keyfile

Description of changes
This changes the behavior of the
boot.initrd.luks.devices..fallbackToPassword to not only ask for
password when file is missing but also if the open fails. This covers
cases such as when invalid key file is provided or when slot is not
present in Luks for it.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@dasJ ping? Is there anything I could do to bump this review up?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1750

If I read the code correctly then this was implemented in the meantime as part of cccc3f8a8e2cd68830f479a418dc0d5c208aee83.
/close


actions: new cfg for pr labeler

Applied mkpr on .github/pr_labeler.yml
cat .github/pr_labeler.yml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.807%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
436

Relevant Lines:
461

💛  - Coveralls


Not working with Google Chrome

I've just installed Prax under Ubuntu 13.04. I've noticed that I can't reach myapp.dev under Google Chrome, but it works with Firefox. How is this possible?

This was working for me, however, suddenly it stopped working on Chrome version 39.0.2171.95 (64-bit), ubuntu.
Now it shows default apache page

I'm afraid I have no idea what's happening. Is libnss_prax.so.2 still in /lib?

I don't think so. Here is the contents of `/lib' http://gyazo.com/9f7db5eaa8ccf18fd0e233e48a3c618d

I meant the system /lib not prax/lib

Sorry, my bad. Yes, I have /lib/libnss_prax.so.2

It must Chrome's asynchronous DNS then. I had to disable it for Chromium 39.0.2171.65 to work.

:+1: thanks man!, it worked!

Ubuntu 15.04, Chromium 41 none of these suggestions work.


added build images and inlined links in README

Thanks. Looks great.

@nickaversano The release widget doesn't seem to be working. Any idea why?

@plivesey Just needed to click the "add a release button" in the Github UI. Apparently an annotated tag is not sufficient.

Got it. Done.


Installation with nginx already installed

Hi.
But can the module be installed when nginx is already installed?
Thanks

need to recompile nginx

./configure --add-module=../ngx_http_proxy_connect_module
# or
./configure --add-dynamic-module=../ngx_http_proxy_connect_module

Thank

think it resolved. thanks for @jingjingxyk 's assitance.


Document integration of Scala plugin with toolchains and problems with target flag

In the current toolchain docs it says that toolchains work with Scala:
https://docs.gradle.org/current/userguide/toolchains.html#sec:consuming
However, there is a problem with the target flag of the Scala compiler, that has been discussed here:
https://github.com/gradle/gradle/issues/19456#issuecomment-1004460716
As such, toolchains do not work with Scala as smoothly as expected and these complications should at least be documented.

Is there at least a known workaround for this issue other than going back to java 8?

Is this same issue as https://github.com/gradle/gradle/issues/20180 ?

Fixed by #23926


use awscni_ip_max to alert on available IPs in EKS node

Hey - quick one hopefully...
tl;dr - awscni_ip_max is how many IPs a node can support based on instance type whereas awscni_total_ip_addresses is how many IPs are available based on currently attached ENIs (which can change at any time). The latter is probably not what we want to base this alert off.
As we can see below we are alerting on the fact that when a node has less than the desired amount of IPs to dish out there is a problem:
https://github.com/prometheus-operator/kube-prometheus/blob/52827617108b222c3fed65192121b73dab0ffcaf/jsonnet/kube-prometheus/kube-prometheus-eks.libsonnet#L75
I think that instead of awscni_total_ip_addresses we should use awscni_max_ip. Take this scenario for example
node-a is an r5.large with a maximum of 3 ENIs to attach. The ENIs can support 9 pods each (1 is used for the host). In our scenario we have 9 pods allocated to this node.
awscni_assigned_ip_addresses: 9
The CNI aws-node  keeps a single ENI worth of IPs available on standby, so..
awscni_total_ip_addresses: 18
And finally - let's say we want to alert on when we have less than 10 IPs available. So the alert below would fire advising that we have less than 10 IPs available to allocated when in reality we have 18
sum by(instance) (awscni_total_ip_addresses) - sum by(instance) (awscni_assigned_ip_addresses) < 10
The above isn't really correct - we have 18 IPs available, not 9.

A fix would be very welcome if you want to contribute it! (I and I believe all other kube-prometheus maintainers don't use kube-prometheus on EKS so it's difficult to verify for us, but we'd be more than happy to accept a contribution!)

Alright, I'll whip something up soon.
On Mon, 30 Nov 2020, 11:03 pm Frederic Branczyk<EMAIL_ADDRESS>wrote:

A fix would be very welcome if you want to contribute it! (I and I believe
all other kube-prometheus maintainers don't use kube-prometheus on EKS so
it's difficult to verify for us, but we'd be more than happy to accept a
contribution!)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/prometheus-operator/kube-prometheus/issues/817#issuecomment-735744602,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AILMHNRX657ZCIYMYFIDX5TSSOCX7ANCNFSM4UHDWL4Q
.

https://github.com/prometheus-operator/kube-prometheus/pull/819

I am happy to think of extra alerts and contribute/verify them also.

I am closing this as the main issue was fixed, but @alam0rt don't hesitate to add new alerts :)


Overall Software Usage - Request

Hi, this is more of a request than a bug/problem.  I want to make sure that I understand the use case for Cheetah-Software.  I've installed it, and by using closed bugs and some experimentation, I think I have it running (for some value of run).
This is using MIT_Controller (mini cheetah and simulator)

Is there a list of allowed control modes and their legal transitions, or is this a "read the code"?
When running, if I transition to 4 (trot), I end up with a light blue screen and no robot.  Sitting (0) and standing (1) seem fine.  Is there a setting I'm missing?
Is there a cheat sheet on what the game controller should do, and when you can/should use it?
Is there an "output" of running the simulation?  Some type of data (not sure what it would be)?  Our goal is to change values and see what changes.  Other than watching the screen, is there another way to capture this?

Thanks for your time!

I think this is definitely a "read the code" type project. I sat down over a couple of days and mapped it all out, I don't think you can get around that and use this work.
If I ever get my hands on a robot, I'll likely fork it and severely refactor it to be crystal clear.

The communication is through LCM. If you run lcm-spy in your terminal, it should list all the signals and provide a basic data streaming plot.

@SteveMacenski  @xdaumich
Hello Together,
I am working on using MIT cheetah software on a real robot. I am able to generate torque and position values. But unable to  understand different modes and how I should initialize the robot. Eg I am testing with one leg, for now my intention is to make the leg go to init, and stand up.
Any hints would be nice.


Updated extrude leads to artefacts in small Euler bends

Describe the bug
As a result of the introduced rounding to nm in the extrude function (commit 94e7b076f9a5ad13978c649c073cbb7a94564dcd), artefacts appear for small angle Euler bends (and potentially more features).
To Reproduce
Example code:
from gdsfactory.components import bend_euler
import gdsfactory as gf

gf.clear_cache()
bend = bend_euler(0.2, 15, width=0.04)
bend.show()

Example behaviour:

Expected behavior
No artifacts should be present.
Suggested fix
This is caused as a result of the rounding of the path points before the extrusion. Can be fixed by doing the rounding on the polygon points instead:
Remove line 842:
points = np.round(points, 3)
Introduce new line 904:
points_poly = np.round(points_poly, 3)
This might probably lead to poor snapping, however.

thank you for the fix Nico!
yes, that makes it look much better while keeping the ports on grid


When start c++ gdb debug, not launch externalConsole

When I run debug, console(cmd) don't launch. And same time, not stop at breakpoint.
I expect launch cmd, stop break point.
This issue have appeared since today. yesterday, there was no problem. I did't touch setting.
I would appreciate it if you help this issue.
[my settings]
launch.json
{
"version": "0.2.0",
"configurations": [
{
"name": "(gdb) 起動",
"type": "cppdbg",
"request": "launch",
"program": "${fileDirname}/${fileBasenameNoExtension}.exe",
"args": [],
"stopAtEntry": false,
"cwd": "${workspaceFolder}",
"environment": [],
"externalConsole": true,
"MIMode": "gdb",
"miDebuggerPath": "C:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/bin/gdb.exe",
"setupCommands": [
{
"description": "gdb の再フォーマットを有効にする",
"text": "-enable-pretty-printing",
"ignoreFailures": true
}
],
"preLaunchTask": "g++.exe build active file"
}
]
}

/extCpp


added Tainan University of Technology

Institution/School Name
Tainan University of Technology
Instiution/School Website
http://www.tut.edu.tw
http://www.tut.edu.tw/bin/home.php?Lang=en
Email Users
Please place an x between the square brackets if yes

[x] Students
[x] Academic/Teaching Staff
[ ] Other/Support Staff

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[x] Graduate School
[x] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

@Filitov You have accidentally submitted too many changes in the repository. Could you please make a new pull request containing a single file? If you wish to add a domain of tut.edu.tw, you need to submit the file lib/domains/tw/edu/tut.txt. I am closing this request now, because it does not follow this repository rules regarding adding new domains. Thank you!


[remix-tests] assign sender in userdoc

this PR https://github.com/ethereum/remix/pull/1004:

allow to specify the sender in the solidity user doc,
a solidity library (remix_accounts.sol) allow to access list of registered accounts directly from solidity contract.

unfortunately, the way sender is declared is just using the array index, we should find a proper semantic for that.

Can you please explain or give me a link of "specify the sender in the solidity user doc" @yann300 ?

currently one has to specify the index in the userdoc like in the following tests https://github.com/ethereum/remix/blob/master/remix-tests/tests/various_sender/sender_test.sol#L9 , and account can be retrieved from solidity using the index too: TestsAccounts.getAccount(1)
for the userdoc part at least we should find a better way.
so instead of having to write /// 1
I propose /// sender : account-1
but open to suggestion
having /// {sender: 'account-1', ... } (like inline json) might be better
what do you think?
@0mkara @iurimatias


AndroidX compatibility : Migrating to AndroidX

As we are not sure when this will be merged, you can adjust your pubspec.yaml in the meantime:
flutter_full_pdf_viewer:
    git:
      url: https://github.com/faisalramdan17/flutter_full_pdf_viewer.git
      ref: android-x

Originally posted by @faisalramdan17 in https://github.com/CaiJingLong/flutter_photo_manager/pull/41#issuecomment-465924587

Are you sure this issue submission location is correct?

Yes, I have tested in my code..
It was working..
On Thu, Feb 21, 2019, 4:32 PM C<EMAIL_ADDRESS>wrote:

Are you sure this issue submission location is correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CaiJingLong/flutter_photo_manager/issues/42#issuecomment-465927704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aqk-Tygjz7WGqnH8hJpQV1x8nQSNZJdVks5vPmebgaJpZM4bG_jZ
.

Merged your PR #41 , You will see changes in the next version.


⬆ Migrate from Poetry to uv

⬆ Migrate from Poetry to uv

Been learning about uv a bit in the past few weeks, is there a thread where you shared your opinion on why moving to UV was better that I might have missed, curious to learn more.
PS,
Thanks for all of your opensource contributions


Why golang's map iterates slower than slice?

Why golang's map iterates slower than slice? A reddit is also created: https://www.reddit.com/r/golang/comments/ayoi1q/why_golangs_map_iterates_slower_than_slice/

Communitites like Reddit or golang-nuts is where you should ask these questions; see https://github.com/golang/go/wiki/Questions. I don't see the need to also have a thread here, unless you have a particular idea in mind to speed up map iteration.


refactor core structure

@smn I'm going to land this - the next PR will add a Docker controller and should be a lot clearer on the approach I'm taking

:+1: just left minor comments mostly because I was reading to  see what had changed, pls ignore :)


Publish v3 fall out

[x] "The file is still being processed. Check back later after a few minutes."

Shouldn't be displayed as an error because it is not.
Maybe loop forever (instead of 2 minutes) if the status remains the expected 202, and only stop on error?
Show "last checked" timestamp so users are assured it is still alive and don't need to worry.
Improve logging -- we still want some insight, but probably not for every call.

[x] Some errors not logged to Sentry. Can get more insight from the breadcrumbs there.
[ ] "The upload does not exist.".  Not expecting this.

Confirm that item exists in server even long after claim is confirmed (it was during initial testing). ==> still does, so that's not it
Should be due to unhandled v2 to v3 transition.

[ ] "The upload does not exist.".  Not expecting this.

Confirm that item exists in server even long after claim is confirmed (it was during initial testing).

Guessing you guys don't need end-user input but I'm seeing this error/msg today.

Related upload: lbry://safe-and-effective-a-second-opinion-2022-oracle-films-2022-09-28

--- close ---
I think this is closed.


Fixes to make things work with the new module system

@yav Are there any more bottlenecks to getting this merged? My interest is in having CI function / also because our PQ specs work with the new module system.

The new module system is not yer merged in master, so if we were to merge this, we'd have to somehow modify the CI to run against the functors-merge branch of Cryptol

The new module system is not yer merged in master, so if we were to merge this, we'd have to somehow modify the CI to run against the functors-merge branch of Cryptol

Got it. Do you have a rough idea of when functors-merge will be ready? I'm trying to get an idea of how/when this will all fit together. I know funding for these things is spread across multiple projects/PDI so it's just not clear to me


support arbitrary search method in fast_gicp

There is nothing in the code that assumes more than the pcl::search::Search interface of the search objects. So one might use others such as OrganizedNeighbor which is much faster for organized clouds.
The code distinguishes between source and target methods, but since swap() is called on their pointers, I think in practice only PointSource == PointTarget is supported.

Thanks for your PR! I'll take a quick look at the updates.

I've restored align.cpp and added the SMID flags based on PCL, which I believe is necessary as you don't know how the user installed PCL.
I also realized that OrganizedNeighbour does not in fact work for all organized point clouds, but just for image-like ones such as from depth cameras. Still useful to have this templated though I think, hopefully some day PCL will add an organized search method for rotating LIDARs.

Thanks a lot for your contribution. All changes look good now. I'll merge this PR once the conflict caused by https://github.com/SMRT-AIST/fast_gicp/pull/134 is resolved.

Fixed.

Thank you a lot!


⚠ Bofrost.es has degraded performance

In e88b50b, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1540 ms

Resolved: Bofrost.es performance has improved in b6946f5 after 6 minutes.


Bump version

@JuliaRegistrator register()

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

Looks like this needs to merge before I can get registrator to work it's magic @oxinabox ?


Generate Muco-Temp

Hi, first of all thank you for sharing your great work.
I wanted to recreate the frames of the Muco-Temp dataset, generated from mpii-3dhp. When I launch the "generate_muco_temp.py" program, I get some images then it crashes before finishing.
I have this error:
_**img = chair_mask * img + (1 - chair_mask) * pose_img
TypeError: unsupported operand type(s) for *: 'float' and 'NoneType'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "scripts/generate_muco_temp.py", line 77, in
p.starmap(generate_vid_frames, params)
File "/usr/lib/python3.6/multiprocessing/pool.py", line 274, in starmap
return self._map_async(func, iterable, starmapstar, chunksize).get()
File "/usr/lib/python3.6/multiprocessing/pool.py", line 644, in get
raise self.value
TypeError: unsupported operand type(s) for *: 'float' and 'NoneType'**
Could you please help me with that?
Thanks for your time in advance.

Hello, I also had problems running this code. Have you solved this problem?


openjdk: fix build for !enableGnome2

Motivation for this change
This OpenJDK packaging has a headless build configuration controlled by the minimal flag, which is regularly build-tested by Hydra, and a non-headless configuration based on pure Xlib libraries without Gnome features, which is not normally tested.
Sometime before OpenJDK 8, the !enableGnome2 case broke, because it needs to link against libXrandr but that wasn't included in the buildInputs.
It might be nice to add packages with this flag set to all-packages.nix so Hydra tests this configuration regularly. This would be analogous to jre_headless and similar, but I couldn't decide what the best package name would be (jre_gnomeless?) so I haven't written such a patch. I also wasn't sure if it would be desirable since obviously most people aren't using this package with the Gnome support turned off, so it's kind of a waste of CI compute time...
If this patch is backported to NixOS 18.03 or earlier, the same fix needs to be applied to OpenJDK 9.
I tested openjdk9.override { enableGnome2 = false; } with an application I care about on NixOS 18.03 using .overrideAttrs to patch the buildInputs. I tested openjdk10 the same way against Nixpkgs commit 44f3a1dd41bc6ec78d827bb2aa5997a4cb67be70.
Before submitting this pull request, I ran:
nix-build --expr \
  '(import ./. {}).openjdk10.override { enableGnome2 = false; }' \
  '(import ./. {}).openjdk8.override { enableGnome2 = false; }'

and tested result/bin/java -version and result-2/bin/java -version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I didn't understand what the rebuild-* tags meant before. Should this PR go through staging as well?
It's kind of unfortunate to rebuild everything since this change shouldn't make any difference whatsoever for any packages that were building successfully before, but so it goes, I guess...


Auto docblock-update by Rails 5

running rails s -b 0 auto-updates a few files
also auto-cd into hpi-swt2 folder (@ekrebs5)
and remove RUBY VERSION from Gemfile.lock

Coverage decreased (-31.0%) to 69.018% when pulling 359ed6ca44de6c5c8b13486194f6d61c089b9ac6 on cmfcmf:docblock-update into 9be043c5665671b5f489001a4c0e01346f0b4c10 on hpi-schuelerklub:dev.


Environment Variable Init: HOME

Using youki as the runtime will missing the env HOME:
$ docker run --rm --runtime youki busybox env
HOSTNAME=efff650756b1
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

Expected (as using runc):
$ docker run --rm busybox env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=2ec2c9640467
HOME=/root

Where is environment variables initialized? I tried but not found in code of the repo.

@mitnk Thanks for your report. We set the environment variables here.
https://github.com/containers/youki/blob/a8e4003bc67b0eef7fcd59ec89928f7436d5c439/crates/libcontainer/src/process/container_init_process.rs#L415-L419
I couldn't find where the HOME environment variable gets, and I couldn't find it in the runtime-spec.
https://github.com/opencontainers/runtime-spec/blob/main/config.md
I'll do some more research. Do you know anything about it?

I found that runc has been implemented here.
https://github.com/opencontainers/runc/blob/eddf35e5462e2a9f24d8279874a84cfc8b8453c2/libcontainer/init_linux.go#L309-L398

Hi, @mitnk. If you have interested in this implementation, I'll leave this implementation to you. Of course, if you don't have time to do it, feel free to ask me to implement it 🙏

Thanks for the info, I'll have a try :)

Thanks for the info, I'll have a try :)

Awesome! If you have any questions, please do not hesitate to contact me.

@utam0k Question 1: I tried adding a syscall.get_pwdir(proc.user().uid()) before setting envs, but the file passwd seems empty (all fields are null-like). So I cannot get the home of user like this. Any ideas?

Draft PR: #681

Another question: how to see the logs printed by code like xxx.with_context(|| "some msg"), while using docker run --runtime youki ...? Do we have a doc on this anywhere (I haven't read all the docs yet).

The file /etc/passwd exists. It's libc::getpwuid_r() returning 2 (No such file/dir?). still checking the reason.
Content of /etc/passwd (via fs::read_to_string() after chroot()):
root:x:0:0:root:/root:/bin/sh
daemon:x:1:1:daemon:/usr/sbin:/bin/false
bin:x:2:2:bin:/bin:/bin/false
sys:x:3:3:sys:/dev:/bin/false
sync:x:4:100:sync:/bin:/bin/sync
mail:x:8:8:mail:/var/spool/mail:/bin/false
www-data:x:33:33:www-data:/var/www:/bin/false
operator:x:37:37:Operator:/var:/bin/false
nobody:x:65534:65534:nobody:/home:/bin/false

Not sure why, but a re-build fixed the issue. It just works now..

Another question: how to see the logs printed by code like xxx.with_context(|| "some msg"), while using docker run --runtime youki ...? Do we have a doc on this anywhere (I haven't read all the docs yet).

It is hard to see the log while using docker. If you want to see the log, it would be good to use the youki directory without using docker.

@utam0k Question 1: I tried adding a syscall.get_pwdir(proc.user().uid()) before setting envs, but the file passwd seems empty (all fields are null-like). So I cannot get the home of user like this. Any ideas?

Did you resolve this question by yourself?

Yes, resolved.

fixed in #681 Thanks!

@mitnk Nice work!


ENCODE

EI type 189 size 1776 truncated at 26
SEI type 0 size 144 truncated at 1
sps_id 32 out of range
sps_id 32 out of range
(repeated 12 more times)
sps_id 14 out of range
sps_id 32 out of range
sps_id 32 out of range
sps_id 14 out of range
sps_id 32 out of range
FMO
is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
FMO
is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
(repeated 6 more times)
no frame!
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
missing picture in access unit with size 11
Invalid NAL unit 0, skipping.
no frame!
missing picture in access unit with size 11
Invalid NAL unit 0, skipping.
no frame!
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
(repeated 9 more times)
no frame!
non-existing PPS 3 referenced
Invalid NAL unit 0, skipping.
no frame!
SEI type 8 size 88 truncated at 40
Invalid NAL unit 0, skipping.
SEI type 71 size 1256 truncated at 40
SEI type 134 size 1696 truncated at 40
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
SEI type 197 size 1208 truncated at 40
sps_id 32 out of range
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
sps_id 32 out of range
sps_id 32 out of range
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
sps_id 32 out of range
reference overflow (pps)
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
sps_id 1 out of range
sps_id 8 out of range
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
(repeated 97 more times)
illegal reordering_of_pic_nums_idc 32
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
(repeated 3 more times)
no frame!
missing picture in access unit with size 11
missing picture in access unit with size 11
(repeated 2 more times)
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
no frame!
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
(repeated 7 more times)
non-existing PPS 215 referenced
Invalid NAL unit 0, skipping.
no frame!
SEI type 3 size 1384 truncated at 40
SEI type 68 size 288 truncated at 40
Invalid NAL unit 0, skipping.
Invalid NAL unit 0, skipping.
SEI type 133 size 1696 truncated at 40
SEI type 197 size 1872 truncated at 40

[Android12

API可以正常运行  但是滑屏一会  就会一直报这个输出   画面就卡住不动了

您先试试 scrcpy-client 3.7 版本, 4.* 好像和 pyav 的兼容有点问题

Sorry for late replay, this problem is solved in the newest version


merge develop to master

Short description

merge develop to master
Proposed changes

Resolved issues

Fixes: #

will merge to staging first


Ignore object formatting option?

If I have an array of objects that looks like this:
var methods = [
  { name: "to" },
  { name: "step" },
  { name: "move" },
  { name: "min" },
  { name: "max" },
  { name: "center" },
  { name: "sweep" },
  { name: "stop" },
  { name: "clockWise" },
  { name: "cw" },
  { name: "counterClockwise" },
  { name: "ccw" },
  { name: "write" }
];

It will be transformed into this:
var methods = [{
  name: "to"
}, {
  name: "step"
}, {
  name: "move"
}, {
  name: "min"
}, {
  name: "max"
}, {
  name: "center"
}, {
  name: "sweep"
}, {
  name: "stop"
}, {
  name: "clockWise"
}, {
  name: "cw"
}, {
  name: "counterClockwise"
}, {
  name: "ccw"
}, {
  name: "write"
}];

Which is almost twice the number of lines and arguably less readable. Is there an existing solution to this problem?

:+1:

+1
This would be much friendlier than
/beautify preserve:start/
and
/beautify preserve:end/


Custom Build Script Not Included In Bower Package

I'm new to Bower so excuse me if my question is misplaced. I think it would be nice to include the necessary scripts to do a custom build within the bower package. What say y'all?

Hi, so really sorry for the long delays. v2.0.0 is going to be released finally and I've had a long look at how the package building will work and re-worked the bower.json file for Sugar.
That said, I still don't know what you mean by "custom build within the bower package". If you want the different packages to be separated (array, string, etc), I'm having a look at that right now for the npm package, and based on that decision this might happen.
If you mean creating custom builds, then this will be possible in the npm package using gulp. However bower is a different ecosystem, so I'm not quite sure how that would work.
Anyway I'm going to close this one out for now, but feel free to re-open if you like.


R2.1 Update fixes #38075

Update kernel_size zero for value error

Can you make it on master first and then cherry-pick here please?
We don't update release branches except when doing releases. After a final release the release branch gets updated only for patch releases (which are only done for security purposes)

The master brach already has this fixed ,user requested it on tf2.1 so i did it on this branch

In this case, it will have to wait for until we do a patch release (due to security issues). At that point we will run the CI and investigate if we can safely pull this in.

In this case, it will have to wait for until we do a patch release (due to security issues). At that point we will run the CI and investigate if we can safely pull this in.

Ok and Thank you.

This is invalid
FAIL: Found 1 non-whitelisted pylint errors:
tensorflow/python/keras/layers/convolutional_test.py:170: [E0001(syntax-error), ] expected an indented block