bug(bidi): latest 10.1.2 fail to compile due module resolution

Expected Behavior
What behavior were you expecting to see?
In version 10.1.1
In NPM package @angular\cdk\esm2015\bidi\directionality.js
import * as i1 from "./dir-document-token";

Which resolve correctly
Actual Behavior
What behavior did you actually see?
In NPM package @angular\cdk\esm2015\bidi\directionality.js
import * as i1 from "@angular/cdk/bidi/dir-document-token";

which does not resolve
Environment

Angular: 10.0.7
CDK/Material: Specified above
Browser(s): does not affected
Operating System (e.g. Windows, macOS, Ubuntu):  does not affected

This code hasn't changed in a long time so it's probably something related to the build.

@crisbeto I think the same. Look at this file history. No changes for last version

Interestingly it doesn't show up in the snapshot builds. On NPM it looks like the last two patch releases are fine, but the release from yesterday (i.e. v10.1.2 has the incorrect import again).

Looked into it. It's a bug that happens with the @bazel/typescript workers. That also explains why it only surfaces in a few releases, while others are good. The issue surfaces when one built e.g. the CDK package in devmode before building the NPM packages in prodmode.
The TypeScript worker caches the AMD/UMD module name for the dir-document-token file in the devmode compilation. In prodmode, the AMD/UMD module names are re-used from the devmode compilation. This causes the Angular compilation to output differently/unexpectedly as the dir-document-token file has an explicit AMD/UMD name that the Angular compiler uses to refer to the file (when compiling the @Injectable definition in directionality).

@Delagen Out of curiosity: Do you have a custom build pipeline? This is a valid issue. Thanks for reporting it! I'm just wondering how you are affected by this. Angular CLI projects by default use the fesm2015 output that is not affected by this issue.

Proposed fix: https://github.com/bazelbuild/rules_typescript/pull/504. I'm going to wait how difficult it will be to get this merged. Otherwise we'll just patch this change into this repository and into rules_nodejs (like they already do for other changes).


Disable Oni errors?

Oni version 0.3.9.
Is it possible to disable Oni errors completely as they are producing false positives?

I don't think we have an explicit way to disable a language server currently, though I have used "language.python.languageServer.command": "", in some projects where I've not bothered to set it up properly to disable it.
Its less "disable the errors" and more "lie to Oni and tell it the wrong command to get the errors, so it can't get any", but the result should be the same. Just swap the language to whichever language you need.

@CrossR Thanks for the response -- I actually forgot to mention I tried doing "language": {}, and "language.typescript.textMateGrammar": {} before with no luck, I just tried "language.typescript.languageServer.command": "" and the errors still show...


Widget tests overriding HTTP to return 400 is incredibly confusing and unintuitive

I’ve just lost several hours of debugging to this issue.
If you have a test file like this, the HTTP test passes:
import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart';

void main() {
   test("HTTP request", () async {
    final result = await get(Uri.http("flutter.dev", "/"));
    expect(result.statusCode, 200);
  });
}

But adding even an empty widget test in the same file causes the HTTP test to fail - even if you just run the HTTP test:
import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart';

void main() {
   test("HTTP request", () async {
    final result = await get(Uri.http("flutter.dev", "/"));
    expect(result.statusCode, 200);
  });

  testWidgets("Empty widget test", (tester) async { });
}

There’s nothing in the log or the faked HTTP response to indicate that Flutter in intercepting the response. It’s deeply unintuitive that just the presence of testWidgets - without the widget test even being run - would cause HTTP intercepting.
I also can’t find anything in the documentation about the intercepting.
Suggestions:

Don’t do the HTTP intercepting by default - make it so developers explicitly enable it
If that’s too much of a breaking change, at the very least document it
If possible, log that the HTTP interception is enabled
Add a message to the faked HTTP response explicitly saying it’s a fake response, why it’s been faked, and how to disable it

I want to piggy back on this to add: there doesn't seem to be a way to actually do the HTTP request at all. I understand why you would want to discourage it, but in my team's case, we are using mock_web_server and we would rather mock the server than the client – we are already doing that with the Driver and Unit tests without issue, so it only seems confusing that we can't do it for Widget tests.
Now we are faced with either not having Widget tests that do HTTP requests, moving everything we already have to mockito (which we would rather not since it involves a lot of boilerplate), or having 1/3 of the tests using mockito and the other 2/3 using mock_web_server.
I hope the Flutter team will allow devs to enable actual HTTP requests for Widget test so that we can decide between mocking the server or the client, and document how to do it.
Btw, we are adding Widget tests since Driver tests don't have the option to generate coverage reports – if we had coverage with Driver tests we could live with those for now.

+1, just got bit by this. Wasted an evening. This is extremely Surprising, Flutter at minimum should be complaining very loudly that this is happening.

I also found this problematic, in my app I moved from widget test to integration tests to be able to fake the server. However searching for a way to handle image loading in widget tests I found this answer on SO.
Looking in the library code I found that the HTTP interceptor can be overridden (code here] and is possible to mock the http response without injecting the "mock client" in the app.
This, at least to me, could allow to revert back my integration tests to widget tests.

Uff, the same for me (spent hours of debugging). No documentation, no warning :-(

+1, just got bit by this. Though now that I stomped it via HttpOverrides.global = null, I'm starting to understand why they did it. Because everything async is mocked in testWidgets (see https://stackoverflow.com/questions/49581157/flutter-tests-waiting-for-a-certain-duration), it's actually not easy to wait for the request to complete properly

Where to put this ```  HttpOverrides.global = null;

@dnfield HttpOverrides.global = null; solution no longer works, I think issue should be re-opened.

Let's track this in the new bug you filed.

This should be much improved now, but please feel free to ping this issue if you're seeing cases where this isn't working right (or if you think the message should include more information somehow).

In the past I also lost hours to this issue - as I had no idea, I was just wondering why all my network tests failed
In my case, I used the unit test framework to have an easy way to literally "test out" my network calls and models before firing up a user interface and an emulator - I used the unit tests as a way to run a small piece of code headless.
This use is clearly a hack and wasn't intended for that, but it would have been super useful. If it worked. Alas it doesn't work.
So now at least there's a very clear error message that explains that all network calls will fail. That's good.
I will find another way to run small pieces of my app in headless mode....


Add syntax highlighting for type

Type is already highlighted; although I imagine it depends on your theme. I don't think it really belongs with proc/method/iterator/etc


Refactoring timedelta aliases (dateAliases)

Remove copypasta (eddd51d25247cb8a1dc8bee1302850e2bff13753) and add tests.
First, let's merge #1910. Then I'm doing here rebase.

@vsn4ik can you rebase the branch? PR is ready for merge after!

@acrobat Done!

Thanks @vsn4ik


Adjust incorrect spacing in README

Minor spacing error causing "file" to read as "f ile". Fixed.

Thanks @ggamel


Fix #11 issue, changing LatLongCoordinatesFacet class

@ajnelson-nist I changed also the WirelessNetworkConnectionFacet class and even though the case_validate went well, I'm not completely sure of the definition of the wirelessNetworkSecurityMode: the global range is owl:Thing but the OWL definition is vocabulary:WirelessNetworkSecurityModeVocab xsd:string.

@ajnelson-nist I changed also the WirelessNetworkConnectionFacet class and even though the case_validate went well, I'm not completely sure of the definition of the wirelessNetworkSecurityMode: the global range is owl:Thing but the OWL definition is vocabulary:WirelessNetworkSecurityModeVocab xsd:string.

Where did you see owl:Thing as the global range of observable:wirelessNetworkSecurityMode?  The definition I see is here in UCO 1.3.0.
With what I see of the regenerated JSON-LD, your patch is fine as-is, so I'll merge it now.  Please feel free to ask follow-up questions here.


[Event Request] Table 36 - OnAfterUpdateBillToCust

Although we have the events OnAfterUpdateBillToCont, OnAfterUpdateSellToCont and OnAfterUpdateSellToCust on the SalesHeaderTable,  I am missing the event OnAfterUpdateBillToCust(VAR SalesHeader : Record "Sales Header";Contact : Record Contact) and request the implementation of this event.
Thank you for your attention.
[Request based on BC14CU4. I didn't check newer versions but could not find any event request here on github.]

You have event OnUpdateBillToCustOnAfterSalesQuote(Rec, SearchContact); for this purpose

Sir,
your mentioned event is only triggered if the "Document Type" = "Document Type"::Quote.
In the local function "UpdateSellToCust" the event OnAfterUpdateSellToCust(Rec,Cont); is correctly implemented.
I still request to implement the event OnAfterUpdateBillToCust(VAR SalesHeader : Record "Sales Header";Contact : Record Contact) at the end of the local function "UpdateBillToCust"
Thank you.

OK

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


K8SPS-220: fix backups when storage parameters have special characters

https://jira.percona.com/browse/K8SPS-220
Backups could fail if storage credentials or parameters like destination, containerName, or  endpointUrl contained special characters.
The reason for this is build/run-backup.sh. In this script, we send a json request, in which we insert environment variables without escaping them. This way, if a variable contained a character like " or \n  it could break a json format or provide an invalid value to a parameter.

Test name
Status

auto-config
failed

demand-backup
failed

init-deploy
failed

gr-init-deploy
failed

monitoring
failed

gr-demand-backup
failed

semi-sync
failed

service-per-pod
failed

config
failed

sidecars
failed

limits
failed

scaling
failed

version-service
failed

one-pod
failed

users
failed

haproxy
failed

tls-cert-manager
failed

We run 17 out of 17

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/9c3973633908ba1188217de0b7379b5786720f48
image: perconalab/percona-server-mysql-operator:PR-258-9c39736

Test name
Status

demand-backup
failed

auto-config
failed

init-deploy
failed

gr-init-deploy
failed

monitoring
failed

gr-demand-backup
failed

semi-sync
failed

service-per-pod
failed

config
failed

sidecars
failed

scaling
failed

limits
failed

users
failed

version-service
failed

one-pod
failed

haproxy
failed

tls-cert-manager
failed

We run 17 out of 17

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/9c3973633908ba1188217de0b7379b5786720f48
image: perconalab/percona-server-mysql-operator:PR-258-9c39736

Test name
Status

init-deploy
failed

auto-config
failed

demand-backup
failed

gr-init-deploy
failed

monitoring
failed

semi-sync
failed

gr-demand-backup
failed

service-per-pod
failed

config
failed

sidecars
failed

limits
failed

version-service
failed

tls-cert-manager
failed

scaling
failed

one-pod
failed

haproxy
failed

users
failed

We run 17 out of 17

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/9c3973633908ba1188217de0b7379b5786720f48
image: perconalab/percona-server-mysql-operator:PR-258-9c39736

Test name
Status

init-deploy
passed

auto-config
passed

demand-backup
passed

gr-init-deploy
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

config
passed

sidecars
passed

gr-demand-backup
passed

limits
passed

one-pod
passed

version-service
passed

haproxy
passed

tls-cert-manager
passed

scaling
passed

users
passed

We run 17 out of 17

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/02125d8ea875931eb705650fd976135cbcd58c1e
image: perconalab/percona-server-mysql-operator:PR-258-02125d8

Test name
Status

auto-config
passed

demand-backup
passed

init-deploy
passed

gr-init-deploy
passed

monitoring
passed

config
passed

semi-sync
passed

gr-demand-backup
passed

service-per-pod
passed

one-pod
passed

sidecars
passed

haproxy
passed

limits
passed

version-service
passed

scaling
passed

users
passed

tls-cert-manager
passed

We run 17 out of 17

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/e192a6765b4e41ae8d22047d019afd3c8a082508
image: perconalab/percona-server-mysql-operator:PR-258-e192a67

Test name
Status

auto-config
passed

demand-backup
failed

init-deploy
passed

gr-init-deploy
passed

monitoring
passed

semi-sync
passed

config
passed

gr-demand-backup
failed

service-per-pod
passed

sidecars
passed

one-pod
passed

limits
passed

haproxy
passed

version-service
passed

tls-cert-manager
passed

scaling
passed

users
passed

We run 17 out of 17

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/944f2c3b98c66cec73be77db88afdbaf55362876
image: perconalab/percona-server-mysql-operator:PR-258-944f2c3

Test name
Status

init-deploy
passed

demand-backup
passed

auto-config
passed

gr-init-deploy
passed

monitoring
passed

semi-sync
passed

config
passed

service-per-pod
passed

sidecars
passed

limits
passed

gr-demand-backup
passed

one-pod
passed

haproxy
passed

version-service
passed

tls-cert-manager
passed

scaling
passed

users
passed

We run 17 out of 17

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/486ae583f1f45ffb1694e564b379987bb4e72c13
image: perconalab/percona-server-mysql-operator:PR-258-486ae58

Test name
Status

demand-backup
failed

auto-config
passed

init-deploy
passed

gr-init-deploy
passed

config
passed

gr-scaling
passed

monitoring
passed

one-pod
passed

semi-sync
passed

haproxy
passed

service-per-pod
passed

gr-demand-backup
passed

sidecars
passed

limits
passed

version-service
passed

scaling
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 21 out of 21

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/ae3a2fc69addddc75dfa3ac923799e3f2d004d0a
image: perconalab/percona-server-mysql-operator:PR-258-ae3a2fc

Test name
Status

demand-backup
failed

auto-config
passed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

config
passed

semi-sync
passed

service-per-pod
passed

one-pod
passed

haproxy
passed

sidecars
passed

limits
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

gr-demand-backup
passed

scaling
passed

users
passed

async-ignore-annotations
failed

gr-ignore-annotations
passed

We run 21 out of 21

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/d020ce51ee887b5d394a930e0fa1fda8dbec7976
image: perconalab/percona-server-mysql-operator:PR-258-d020ce5

Test name
Status

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

limits
passed

demand-backup
failed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

auto-config
passed

config
passed

one-pod
passed

haproxy
passed

gr-demand-backup
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 21 out of 21

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/d020ce51ee887b5d394a930e0fa1fda8dbec7976
image: perconalab/percona-server-mysql-operator:PR-258-d020ce5

Test name
Status

auto-config
passed

demand-backup
failed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

config
passed

sidecars
passed

limits
passed

version-service
passed

config-router
passed

tls-cert-manager
passed

gr-demand-backup
passed

one-pod
passed

gr-tls-cert-manager
passed

haproxy
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/0d0ae8846b4bc7598dd88b3d9267a8cb27236cbe
image: perconalab/percona-server-mysql-operator:PR-258-0d0ae88

Test name
Status

auto-config
passed

demand-backup
failed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

config
passed

monitoring
passed

semi-sync
passed

config-router
passed

service-per-pod
passed

one-pod
passed

sidecars
passed

haproxy
passed

limits
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

gr-demand-backup
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/446774c1abebcd06be13433e6b0ca3940390a056
image: perconalab/percona-server-mysql-operator:PR-258-446774c

Test name
Status

auto-config
passed

config
passed

config-router
passed

one-pod
passed

haproxy
passed

demand-backup
failed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

limits
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

gr-demand-backup
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/446774c1abebcd06be13433e6b0ca3940390a056
image: perconalab/percona-server-mysql-operator:PR-258-446774c

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
failure

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/c47ae4a95bf0bc89c19892300ed50187552ec32a
image: perconalab/percona-server-mysql-operator:PR-258-c47ae4a

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
failure

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/c47ae4a95bf0bc89c19892300ed50187552ec32a
image: perconalab/percona-server-mysql-operator:PR-258-c47ae4a

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/258/commits/777766133c02d44b7957a195c98ffadaf1f0e128
image: perconalab/percona-server-mysql-operator:PR-258-7777661


Dependabot breaks CI at "Ensure generated files are up-to-date"

@brandonchinn178 You introduced a new check to CI in https://github.com/haskell-actions/setup/pull/21/commits/906b3bf78367868c0922be04809e68a7ef7eb477 testing whether the generated JS is in sync with the TS.
This check seems to break when dependabot updates a dependency, see e.g. the bump of compare-versions:
-https://github.com/haskell-actions/setup/pull/28

https://github.com/haskell-actions/setup/actions/runs/6044741804/job/16403764725?pr=28

Either CI or dependabot is off here.  Not sure we can dependabot, but I don't know.
Could you have a look?

Sure; if the dependency is bundled in the generated files, then changing the dependency requires changing the files. If you still want dependabot PRs, youll need to check out the branch, regen the files, and push. If you have multiple dependabot PRs, perhaps you can merge as admin (override the check) and regen on master all at once.
This is a good thing; it means that the generated code is in sync with the project. And it means that someone checking out the repo fresh doesnt have out of sync files. For example, if someone makes a README-only change while generated files are out of sync from a dependabot bump, then their PR would be broken due to something unrelated.
If you dont want dependabot PRs at all, you can disable them in the settings. Or perhaps a better alternative is to not commit the generated files and just generate them at release, on a separate branch

Could be fixed by running something similar to
...$ git fetch upstream dependabot/go_modules/github.com/99designs/gqlgen-0.17.33
...$ git switch dependabot/go_modules/github.com/99designs/gqlgen-0.17.33
...$ make generate
...$ git add ....
...$ git commit ....
...$ git push ....

(tested on another repo, https://github.com/guacsec/guac/pull/953#issuecomment-1599090212)
Alternatively, the CI could be made to update the files on a specific comment (as the files should be updated automatically only when actually desired)

@mihaimaruseac wrote:

...$ # regenerate the files

What is the magic incanation to regenerate them?
I thought keeping the files up to date was the job of the husky scripts invoked with git commit and git push.  However, they do not seem to do this: https://github.com/haskell-actions/setup/actions/runs/6130024354/job/16638735185

So in this commit https://github.com/haskell-actions/setup/commit/0cab6f57ca63e907d25895e0242c529282f1cdc8, notice that dist/index.js changed a lot more than just the version that you changed. That should be an indication that your environment probably isnt up to date and is generating with out of date files.
Specifically, the extra changes made in that commit reverts the changes made here: https://github.com/haskell-actions/setup/commit/3622c430bca14224ad73e009ac126ac1c890a432
That commit explains that this is due to having the wrong version of @actions/io installed. Did you run npm install before regenerating the files? The changes that were generated in your commit come from a different version of @actions/io than the version specified in package-lock.json

Can the regenerate be made to run as a self-contained script that covers all cases? I'm not yet up to date with all the code in the repo, so I'm unsure


Updated so that bad phone numbers no longer stop the message from bei…

…ng sent.
This PR allows messages to be sent even if the phone number is bad.
Test Steps:

Update the phone number in prime-router/src/testIntegration/resources/datatests/FHIR_to_HL7/sample_truncate_CA_20230406-0001.fhir to 1<PHONE_NUMBER>
Run ./prime fhirdata --input-file src/testIntegration/resources/datatests/FHIR_to_HL7/sample_truncate_CA_20230406-0001.fhir -s metadata/hl7_mapping/receivers/STLTs/CA/CA.yml --output-format HL7 --output-file src/testIntegration/resources/datatests/FHIR_to_HL7/testhl7.hl7
Make sure it runs without error

Changes

try/catch added to allow messages to be sent even if the phone number is bad.
tests updated

Checklist
Testing

[x] Tested locally?
[x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[x] Added tests?

Yep, updated. I left it as a generic message since I am unsure if adding the phone number would be violating PII rules. Normally it would be but if it is a bad phone number I am unsure. Back to you @jack-h-wang thank you for the quick review!

@arnejduranovic over to you!

Looks good.
Please make sure to link the relevant ticket in the PR, will approve once that's done.

I thought we weren't supposed to do that because it would auto mark it as done once it was merged?

Looks good.
Please make sure to link the relevant ticket in the PR, will approve once that's done.

I thought we weren't supposed to do that because it would auto mark it as done once it was merged?

We're just not supposed to put "Fixes" in front, that's the magic that closes the ticket. For example, if you just put the ticket number by itself in the section titled "linked issues" or whatever it wont auto close the ticket, like so:
#XXXX

Got it, done.


Don't retire load balancers

Presently system_context retirement only checks to see if the evm_owner_id is present on the object, it doesn't check that that id is that of a valid user. In order to make the check run on evm_owner we will need to remove load balancers from the list of things to retire in the retirement manager per https://github.com/ManageIQ/manageiq/pull/18437#discussion_r254874102 since load balancers don't have owners.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1673143. (it doesn't fix it but the related PR does and this is required for the related PR)
related to
https://github.com/ManageIQ/manageiq/pull/18437

@miq-bot add_label bug
@miq-bot add_reviewer @bdunne
@miq-bot assign @gmcculloug

We should also remove https://github.com/ManageIQ/manageiq/blob/master/app/models/load_balancer.rb#L5 and check for other retirement references on this object.

@d-m-u if this can be backported, can you add the hammer/yes label.

@miq-bot add_label hammer/yes

Hammer backport details:
$ git log -1
commit 2aa3228428546cfd16f4d67319fb5aac01b7d25e
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Mon Feb 11 12:04:57 2019 -0500

    Merge pull request #18443 from d-m-u/remove_lbs_from_retirement_check

    Don't retire load balancers

    (cherry picked from commit d8a6ba00be00d215a44af0f71e27f7ad364967ba)

    https://bugzilla.redhat.com/show_bug.cgi?id=1678476

sorry, i messed up, this should be hammer/no
@miq-bot add_label hammer/no

Reverted the backport:
commit 7a4a22b59ea8598b431488d0f68d70bad456cf59
Author: Satoe Imaishi<EMAIL_ADDRESS>Date:   Tue Feb 19 10:10:07 2019 -0500

    Revert "Merge pull request #18443 from d-m-u/remove_lbs_from_retirement_check"

    This reverts commit 2aa3228428546cfd16f4d67319fb5aac01b7d25e.


Allow pytest to return success when no tests are collected for flaky test suite

* Manage no tests collected exit code 5 from pytest for flaky test suite and master (not flaky)
* Manage passing additional -m arguments to pytest in e2e test
* Pass `all` to pytest for e2e tests

By default e2e tests are checked for None as environment provided in command line args to
set it to all. With additional args for pytest passed with -m flag,
ddev cli misinterprets this as an environment name whereas it should be
selecting all environments
What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Failure with GlusterFS is not PR specific. Ignoring it and proceeding with merge.


Bananas Cream Pies when thrown delete the pie tin all together

Description explained in title.
Reproduction
Become Chef or have access to kitchen
Make a bananas cream pie in the microwave
Throw banana cream pie at someone, deleting the tin once it lands
Screenshots

Additional context
No other context my only suggestion is to make the pie tin drop when thrown, or something like that.

Could take it a step further, the tin gets equipped on the face unless they have a mask or something, temporarily blinding them. Then the tin could either fall off after a few seconds or the player can unequip it as quick as they can.

with the new pie recipes it would be good if the pie tins didn't get deleted upon being thrown

Could take it a step further, the tin gets equipped on the face unless they have a mask or something, temporarily blinding them. Then the tin could either fall off after a few seconds or the player can unequip it as quick as they can.

I'd go with this, for anyone planning to tackle the issue.


Show the raw location in the subscriber example app

We can receive both enhanced and raw locations from the publisher SDK. Currently, the subscriber example app only displays the enhanced ones. We should add a second map marker that will show the raw locations on the map, if they are being received. On Android, the raw map marker icon is the same as the enhanced one, but its alpha (transparency) is lower and the marker color is red.
┆Issue is synchronized with this Jira Uncategorised by Unito

Attaching Android example app screenshots


getFirstObjectKey function should not work correctly

There is getFirstObjectKey function in the source, but isn't it going to fail sometimes since order of the object keys is not guaranteed?

My bad. This issue is not meant for this repo


Re-do structure population

The flexmeasures add structure command basically is an opinionated take at what structure should be on a (fresh) FM server.
I get that we want some default GenericAssetType instances to be there. So that is what this could become - default types. I'm open to adapt the name, as well if that is the case.

Perhaps flexmeasures add example, which creates an example organisation, a few user accounts, a few asset types and assets with sensors, and optionally some time series data, too?

Also, some basic roles. For users, admin, for accounts, Prosumer, MDC etcetera

@Flix6x  The example idea should be another ticket, I think.

The example idea should be another ticket, I think.

Okay, I get that. I made #340.

Solved by #349


Update add-a-text-alternative-to-images-for-visually-impaired-accessi…

…bility.english.md
I changes H2 to H1 in lines 9, 17, 22.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi,
Thanks for this pull request (PR).
Unfortunately, we are marking this PR invalid for hacktoberfest. We believe it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details


p is resized on desktop like there is a sidebar

Removing that css rule (min-width:640px) now the width is the same of the container:
.post p, .post ul, .post ol, .discussion, .promo { {
    max-width: 65ch;
}

and in that way is showed

I am thinking to do a userstyle for stylish until the fix is not available

Uploaded https://userstyles.org/styles/157746/mozilla-hacks-full-width

To explain better the issue

(pardon the drive-by comment) Most sites converged to a centered main element these days (Medium as reading example; but also other layouts like github, facebook, twitter, etc). Maybe this decision can be reconsidered now as it might solve the problem of "looking cut off".

Now github is more organized and doesn't have a sidebar useless like before.


Does this package assume git repo URLs with always have ".git" in them?

I'm using AWS CodeCommit and the repo ssh URLs do not have ".git" on the end and will respond with repo not found if you append one to the URL. Is there anyway to disable the suffix being added?

What responds with repo not found? AWS CodeCommit or caddy-git?

Caddy-git is giving me the error on caddy restart that the repo is not found. When I looked at the caddy logs I saw it was appending a suffix of ".git" onto the repo URL I provided. I then manually tried to fetch the same git repo (using the .git suffix) over ssh using the same key, etc as the caddy server does. Git told me the repo was not found. I did see that it auth'd over SSH just fine though (I originally thought it might be a permissions error.). I then retried the request without ".git" and it worked fine.
I poked around the source code quickly for caddy-git it does seem like there's a spot in the function where the repo URL is constructed where it is appending ".git" but I couldn't see a means of controlling that behavior.

Oh, I understand your situation now. Yes, caddy-git appends .git to the URL if it's not there.
This was actually intentional, since git hosts generally honour the .git suffix.
I'll look at introducing a config to make that optional.

Fixed with https://github.com/abiosoft/caddy-git/commit/c2dcbb48de985127ac44b94f507230de5daf7520.
I've triggered a new release and should be available soon on caddyserver.com/download. If you build from source, your new build should have the fix.
Feel free to re-open if the issue is still not fixed.

Thanks so much for the quick response, Abiola. Apologies for not filing a pull-request with my initial issue...my work day didn't allow me to explore a bit more to submit that.


[Feat]: Scale-out cluster support for independent per-instance storage deployments

Is your feature request related to a problem? Please describe.
The current implementation of scale-out cluster is supported on shared-storage deployments - many instances and one reliable shared storage such as S3.
Currently, some REST APIs will not work for deployments where the image storage for each instance is isolated (for example, one zot instance per VM with independent disk storage).
Describe the solution you'd like
In a scale-out cluster deployment using isolated per-instance storage, APIs such as /v2/_catalog as well as GraphQL endpoints will need to fan-out requests to all the members and aggregate the received data before returning results.
Describe alternatives you've considered
N/A
Additional context
No response

/v2/_catalog is easier to handle as the logic is entirely implemented using data structs.
For this, we can simply detect a scale out cluster in non-shared storage mode and then fan-out + aggregate.
However, the GQL APIs are handled via a GQL server handling auto generated GQL - the implementation of which cannot be changed.
Additionally, there is a need to support pagination.
extRouter.Methods(allowedMethods...).
		Handler(gqlHandler.NewDefaultServer(gql_generated.NewExecutableSchema(resConfig)))

One approach might be to look into the Resolver code (resolver.go) and modify the data read to include proxied results before the response is taken for pagination.
For example:
func (cveinfo BaseCveInfo) GetImageListForCVE(ctx context.Context, repo, cveID string) ([]cvemodel.TagInfo, error)

This function must ask all other nodes for images having this CVE before returning the TagInfo objects.
That logic could be introduced as a wrapper on top of these functions that will do the following:

Call the function locally
Call the function for all other members (this can be done using GQL potentially to promote re-use)
Return the result to client

To facilitate this, the GraphQL requests would need to be proxied. Since the request data does not flow to the resolver, there would be a need to bring that logic to the resolver so GetImageListForCVE knows to call GetImageListForCVE on all other hosts via the GraphQL API. Each zot instance will become a GQL client as well.

@vrajashkr do you want to start with paginated result (aggregate) of paginated results (fanout)? The second part is what needs to redesigned? Maybe we simply add a pagination=off param.

Separately, keep an eye on sync as a means to "heal" after a cluster resize.

There are 2 major items to handle:
/v2/_catalog
The approach for this would be fairly straightforward as there is no pagination for this.

The other zot instances will not re-proxy the requests as the proxied request will contain a custom zot header that the instances will read and use as a reference to prevent a re-proxy. This avoids a proxy storm.
The client-serving instance of zot (zot 1 in the image) will merge the deserialized responses with the local data in struct form. This keeps things simple and reliable.

/v2/_zot/ext/search
Here's a diagram representing the approach we discussed:

The existing 99designs route handler gqlHandler.NewDefaultServer(gql_generated.NewExecutableSchema(resConfig)) will be wrapped by a custom handler which handles the proxy logic.
The other zot instances will not re-proxy the requests as the proxied request will contain a custom zot header that the instances will read and use as a reference to prevent a re-proxy. This avoids a proxy storm.
When the request is seen with the custom zot proxy header set, the other instances will ignore pagination and should return their full dataset. The instance serving the client will merge the results and then apply pagination. We can probably optimize this later, but it probably requires a decision to address issues such as results truncation - do we want results from a subset of instances or a paginated subset of results from each instance? Additionally, the results will need to be consistent in each query for the given scale-out cluster.

Challenges with this approach:

Since this approach is proxying at a level above the GQL handler, the new code needs to be able to read GQL schemas in order to form the right structs and merge the response data. (Need to figure out how to do this).
Pagination queries will pay a penalty as they fetch all the data before paging it (kind of defeats the point of pagination), but this is needed for consistency of response for the cluster as a whole.

@andaaron @rchincha
It would be great to get your thoughts on the approaches detailed above! Thanks!

GQL Query behaviours:
reference: pkg/extensions/search/schema.graphql
Proxy-once to target member or handle locally
CVEListForImage
ImageList - only if there is a repo specified in the arguments
ExpandedRepoInfo
GlobalSearch - when searching for a tag inside a repo
Image
Referrers
Fan-out proxy to all other members
ImageListForCVE
ImageListWithCVEFixed
ImageListForDigest
RepoListWithNewestImage
ImageList - when the repoName is sent as ""
GlobalSearch - when searching for repos
DerivedImageList
BaseImageList
Depending on meta storage strategy
If the metadata DB is shared, then they can be processed locally, but if the metadata DB is not shared, this request needs to be fanned out:
StarredRepos
BookmarkedRepos
Handler logic change to dynamically query other zot instances
CVEDiffListForImages - the data for each image (subtrahend and minuend) are both available from their respective single zot instances. Depending on where the request lands, there may be 2 requests made to other zot instances (if both repos are not on the current instance), one request (if either of the images are not available locally), or no requests (if both images are available locally). Note: this requires a change in the handler itself as there is no logical way to proxy the incoming request to get the required data.


changed function name from PathByMaskDetect to PathByParamDetect

Checklist:

[x] Tests for the changes have been added (for bug fixes / features / refactoring)

Thanks @hackpk  🙏


test: add a test to prevent weak symbol leakage

The Swift standard library should not export weak symbols.  Ensure that
no public weak symbols are defined in the standard library by adding a
test case.  This would have identified the issue introduced by the
recent changes for the runtime.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @edymtt

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - aa41c17d634654a86a9de62228457a1cbf313b78

@swift-ci please test macOS platform

Build failed
Swift Test Linux Platform
Git Sha - aa41c17d634654a86a9de62228457a1cbf313b78

Build failed
Swift Test OS X Platform
Git Sha - aa41c17d634654a86a9de62228457a1cbf313b78

Re-testing to make sure that the test passes.  This needs alteration to address feedback from @edymtt still.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - aa41c17d634654a86a9de62228457a1cbf313b78

Build failed
Swift Test Linux Platform
Git Sha - aa41c17d634654a86a9de62228457a1cbf313b78

@swift-ci please smoke test

@swift-ci please smoke test

@edymtt - I removed the swiftDemangling checking as that is built as a static library, not dynamic library.  The checks of swiftCore and swiftRemoteMirror implicitly test that library as it is incorporated into those two libraries.  I left a note in the test about that, because it took me a bit of re-reading the tree to remember that.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test Windows platform

@swift-ci please smoke test Linux platform

@swift-ci please test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 44df151e81bb71d35107a5b609947c14e01d1e66

@swift-ci please test Windows platform

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 44df151e81bb71d35107a5b609947c14e01d1e66

Build failed
Swift Test OS X Platform
Git Sha - 44df151e81bb71d35107a5b609947c14e01d1e66

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 1219c4875556bbe62678a60b292651a9a061499b

Build failed
Swift Test OS X Platform
Git Sha - 1219c4875556bbe62678a60b292651a9a061499b

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - f3f5644589060cf0c50e203b34da6d5d60e555dd

Build failed
Swift Test Linux Platform
Git Sha - f3f5644589060cf0c50e203b34da6d5d60e555dd

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 11be999b4b4ef181b42c1ba50e9785343c034fa4

Build failed
Swift Test OS X Platform
Git Sha - 11be999b4b4ef181b42c1ba50e9785343c034fa4

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - d60db72063c12685e140f865691c8b711c18deca

Build failed
Swift Test OS X Platform
Git Sha - d60db72063c12685e140f865691c8b711c18deca

@swift-ci please test macOS platform

@swift-ci please test Windows platform

@compnerd do you have any idea why this test would be failing on Linux Ubuntu 18.04 aarch64?


added favicon and changed head-title

This is how it looks now.
Can you please merge it ?

How can I squash my commits ?

@Himanshu16Singh
https://levelup.gitconnected.com/how-to-squash-git-commits-9a095c1bc1fc


Update head.py

-Use tf.metrics instead of contrib version
-Use core lookup instead of contrib version (Nvm, another PR)
-Remove TODO in tensorflow/contrib/lookup/init.py since already done

Can one of the admins verify this patch?

Jenkins, test this please


issue with recreating certificates.

issue with recreating certificates. its shwoing like this
[15:58:58] [inf] obtaining and setting up 20 TLS certificates - please wait up to 60 seconds...
[15:58:58] [err] failed to set up TLS certificates: accounts.google.: obtaining certificate: [accounts.google.] Obtain: [accounts.google.] creating new order: attempt 1: https://acme-v02.api.letsencrypt.org/acme/new-order: HTTP 429 urn:ietf:params:acme:error:rateLimited - Error creating new order :: too many certificates already issued for "". Retry after 2024-03-24T11:00:00Z: see https://letsencrypt.org/docs/rate-limits/ (ca=https://acme-v02.api.letsencrypt.org/directory)
[15:58:58] [err] run 'test-certs' command to retry
and also

how to fix this

Let's Encrypt provides a limited number of certificate requests per week or month. You have exceeded the limit, so you must wait or obtain a new domain. Additionally, you should investigate why you are making such a large number of requests.

**Hi 👽 ! If you are interested in ⚙Advanced Phishing⚙ and the ✨Evilginx3✨ tool then I offer you Google Gmail and Custom Phishlets with a ✅Free Tutorial✅ which arrives if the 📈Telegram reaches 50 Subscribers📈
⏳ GOOGLE GMAIL PHISHLET 2024 WITH PROOF ⏳
->
⛔https://www.youtube.com/watch?v=nA47UknIE6A⛔
🔓 Ask your questions and a free tutorial from 50 subs on telegram !!!
->
📩https://t.me/Noremorse1011📩**


Dynamic module loading as attributes

Another alternative to #71 that is a bit more sophisticated than #74.
A couple ideas going on here
i. Define a general utility method for safely importing a module if it is installed and giving a more informative error message to perform the installation if not. This method could be used to reduce code around the repo any time we use that type of lazy import logic.
ii. Define two new attributes internal to any DataInterface - the user would not even need to know they are there. The first is the modules_to_import, which is just a list of all the names of modules that one would need to load for the interface. The second is loaded_modules (should maybe be renamed to 'imported_modules'?) which is a dictionary mapping from all those strings in modules_to_import to the actual modules themselves. The loading of the modules is performed as a generic step in the __init__ common to all data interfaces, though this part may need small adjustments for appropriate behavior depending on how customized the most downstream initialization is for any particular interface. This workflow adjustment could also be done a bit more effectively by making the __init__ of any interface focus on module loading and setting up other class attributes, with a __post_init__ steep for the recording/sorting/imaging/segmentation interfaces where we actually initialize the extractor after successfully loading the required modules.
Benefits

No break to back compatibility. All previous code imports will work in the same manner, and will also be faster due to less global overhead.

Acts at the same level as our lazy installation assertions (during interface __init__), so any problems with either will be caught after importing the NeuroConv library but before running the conversion. (errors should trigger during initialization of interface)

References to imported modules are readily available to a downstream user. Even using the current main branch, when I import a DataInterface I do not automatically import any associated modules, just the classes/objects of that module that have been attached to the interface. To use any of those modules I would have to re-import them in the script I'm using the data interface in to establish a reference. But this approach allows immediate use without re-establishing the reference since the reference is attached to the interface itself. Granted, there aren't too many situations you'd actually want to use this in.

Drawbacks
a. Goes against a spirit of PEP8 import styling

Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants.

which is in place to detect any import errors prior to attempting to run any code. Though another common exception to this PEP standard is to do what is suggested here as a measure to avoid circular dependencies (not our issue, but tangentially related).
b. Unsure as of yet, but could be a bit 'touchy' as a generic property of every data interface. Also a more sophisticated thing to have to teach in the tutorials of creating custom data interfaces.

Only test failing right now for linux is a strange stdout that is unexpected by the doctest gallery. Actual behavior of the interface is as expected.
@h-mayorquin is there no way to tell the doctest for the gallery to ignore verbose output from a certain line? Or otherwise capture it or test that is satisfies a certain regex?

Only test failing right now for linux is a strange stdout that is unexpected by the doctest gallery. Actual behavior of the interface is as expected.
@h-mayorquin is there no way to tell the doctest for the gallery to ignore verbose output from a certain line? Or otherwise capture it or test that is satisfies a certain regex?

@CodyCBakerPhD
It seems to be coming from deep lab cut, right? One of the drawbacks of verbose by default options.
You can try the ellipsis notation:
https://docs.python.org/3/library/doctest.html#doctest.ELLIPSIS

It seems to be coming from deep lab cut, right? One of the drawbacks of verbose by default options.

Yeah it's coming from the initial import of DLC, which has some stuff about version number, looks like this:
    Loading DLC <IP_ADDRESS>...
    DLC loaded in light mode; you cannot use any GUI (labeling, relabeling and standalone GUI)

which could be useful if we were actually using DLC as a tool. I wouldn't actually call it a drawback of the package but rather a drawback of the sensitivity to output that doctest has - in this case it even depends on which platform of the CI it runs on: https://github.com/catalystneuro/neuroconv/runs/7725840103?check_suite_focus=true

It seems to be coming from deep lab cut, right? One of the drawbacks of verbose by default options.

Yeah it's coming from the initial import of DLC, which has some stuff about version number, looks like this:
    Loading DLC <IP_ADDRESS>...
    DLC loaded in light mode; you cannot use any GUI (labeling, relabeling and standalone GUI)

which could be useful if we were actually using DLC as a tool. I wouldn't actually call it a drawback of the package but rather a drawback of the sensitivity to output that doctest has - in this case it even depends on which platform of the CI it runs on: https://github.com/catalystneuro/neuroconv/runs/7725840103?check_suite_focus=true

Is not about usefulness of the information provided by verbose is about an unintended side effect of sending information to the standard output by default in downstream use.

Closing in favor of approach https://github.com/catalystneuro/neuroconv/pull/74 that preserves all possible auto-parsing effects across IDEs and interactive consoles


svelte-kit package $lib reference conflicts with outer svelte project $lib

Describe the bug
I generated a package, copied it into another svelte project, but all the references to $lib inside the package look for files in the outer svelte project's $lib rather in itself - any way around that?
I get the error:
failed to load module for ssr: /src/lib/utils/fullscreen

Because the file is correctly at:
/src/MY-PACKAGE/utils/fullscreen

Reproduction
Make a project that includes some $lib imports.
Package the project with svelte-kit package.
Rename and copy the package into another svelte project.
Load one of the packages entry points in the new project.
Notice that the entry point is trying to find its dependency in the outer project's $lib folder rather than its own.
Logs
No response
System Info
System:
    OS: Windows 10 10.0.19043
    CPU: (16) x64 Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
    Memory: 6.49 GB / 31.92 GB
  Binaries:
    Node: 14.17.3 - C:\Program Files\nodejs\node.EXE
    npm: 6.14.13 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.71)
    Internet Explorer: 11.0.19041.1
  npmPackages:
    @sveltejs/adapter-vercel: ^1.0.0-next.0 => 1.0.0-next.0
    @sveltejs/kit: next => 1.0.0-next.132
    eslint: ^7.22.0 => 7.31.0
    eslint-config-prettier: ^8.1.0 => 8.3.0
    eslint-plugin-svelte3: ^3.2.0 => 3.2.0
    less: ^4.1.1 => 4.1.1
    prettier: ~2.2.1 => 2.2.1
    prettier-plugin-svelte: ^2.2.0 => 2.3.1
    svelte: ^3.34.0 => 3.38.3
    svelte-preprocess: ^4.7.4 => 4.7.4

Severity
serious, but I can work around it
Additional Information
No response

Duplicate of #1950 . Aliases need to be resolved when packaging.


run linkchecker on the html docs

Now that we build the doc in TravisCI, we could also check the links in the html docs. Maybe this is something we can borrow from matplotlib, https://github.com/matplotlib/matplotlib/pull/5797

There's also cd doc && make linkcheck

I am on it . Please check the PR . :)

pip install linkchecker is broken, it's possible this will be fixed soon.
I spent more than an hour reading the tale (https://github.com/linkchecker/linkchecker/issues/136) of @anarcat & co's effort over two+ years to secure PyPi access for the linkchecker name. It was a frustrating journey (the process seems to have changed out from under them at least twice)
Hopefully soon they will have a pip package at which time I'll investigating reopening #6736

linkchecker seems to be different from the Sphinx built-in tool you can invoke with make linkcheck. Is a separate tool needed/better?

Both attempt (#5932 and #6736) make use of the pip package lintchecker which doesn't currently install.
Let me try to test with Sphinx's built in tool.

note that it's possible to install linkchecker from source with:
pip install<EMAIL_ADDRESS>
drop the @ to get the latest HEAD which works in python 3.. sorry about the delays in release, i'm swamped... :(


Set check as the default when running without parameters

Just found your script this morning, it's very complete (best one of the various I found). Only thing ia bit scary si that it installs packages directly, I created a patch so the default is to do only the check so nobody has packages installed before wanting it.
bash deghost.sh  | grep ^dss:isv

I know that changing the default is not really polite from me,  but seems reasonable this time.

good call!  thank you for contributing back.  I committed a change.  default=check, --fix-vuln and anything else => usage.

Perfect, I'm closing this since you've implemented it now :)


WIP: wasm:Enables Interop.GetRandomBytes for wasm

@morganbr @MichalStrehovsky I've made this PR to enable GetHashcode for strings as it uses Marvin.DefaultSeed and hence Interop.GetRandomBytes.  However, I don't know where this should go as where I've put it I think is wrong as I believe this file src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.GetRandomBytes.cs is shared with Corefx/CoreCLR.  Where should this go?  Perhaps its not even necessary as the Unix implementation in Interop.Libraries.SystemNative may will be enough with a different DllImport?  If it is required could you comment on whether we can safely assume sizeof(int)==4 in wasm?
Thanks

Implementation for this comes from the CoreFX repo: https://github.com/dotnet/corefx/blob/a10890f4ffe0fadf090c922578ba0e606ebdd16c/src/Native/Unix/System.Native/pal_random.c#L23
We should be able to use that, but we'll need to finish build and packaging for the WASM CoreFX NuGet packages. @morganbr has been working on this on and off.

I see, I didn't realise but emscripten does have /dev/random and /dev/urandom support so that may just work.  As this WIP PR is likely not going to be useful, I'll close it and further discussion can continue on #5777.


query from kylin4 raise exception

When make a query from kylin4, I got error like blow.
Error: From line 2, column 24 to line 2, column 30: Expression 'VIRTUAL_TABLE.VDATE' is not being grouped while executing SQL: "SELECT "DOMAIN" AS "DOMAIN", CAST(FLOOR(CAST("VDATE" AS TIMESTAMP) TO DAY) AS DATE) AS "VDATE", count(*) AS "count" FROM (Select VDATE, DOMAIN from STG.S_HAPROXY_LOG) AS virtual_table WHERE "VDATE" < '2022-02-15 00:00:00.000000' GROUP BY "DOMAIN", CAST(FLOOR(CAST("VDATE" AS TIMESTAMP) TO DAY) AS DATE) ORDER BY "count" DESC LIMIT 10000"

superset version: 1.3.2
kylin version: 4.0.1
spark version: 2.4.7

How to reproduce the bug

# sql generate by superset
SELECT "DOMAIN" AS "DOMAIN",
       CAST(FLOOR(CAST("VDATE" AS TIMESTAMP) TO DAY) AS DATE) AS "VDATE",
       count(*) AS "count"
FROM
  (Select VDATE,
          DOMAIN
   from STG.S_HAPROXY_LOG) AS virtual_table
WHERE "VDATE" < '2022-02-15 00:00:00.000000'
GROUP BY "DOMAIN",
         CAST(FLOOR(CAST("VDATE" AS TIMESTAMP) TO DAY) AS DATE)
ORDER BY "count" DESC
LIMIT 10000;

THINKING
kylin4 use spark as engine only，but spark not support FLOOR function like hive
spark sql

hsql

So, any suggestion to fix this? ☺

Hi @wuyue92tree, I remember that Kylin uses Apache Calcite for SQL Parser and FLOOR is Calcite function. This seems like a backport issue and you probably file in Kylin community.

Hi @wuyue92tree, I remember that Kylin uses Apache Calcite for SQL Parser and FLOOR is Calcite function. This seems like a backport issue and you should file it in Kylin community.

Thanks for reply! in fact when doing query, superset generate sql for kylin base on https://github.com/apache/superset/blob/59b811ac5bf6ea64da8e9343fed28676001b9015/superset/db_engine_specs/kylin.py#L30-L40
So, I make a change here and It's work. Wait for a better solution ^_^
_time_grain_expressions = {
        None: "{col}",
        "PT1S": "TIMESTAMPADD(SECOND, -(SECOND(CAST({col} AS TIMESTAMP))), CAST({col} AS TIMESTAMP))",
        "PT1M": "TIMESTAMPADD(SECOND, -(MINUTE(CAST({col} AS TIMESTAMP))*60+SECOND(CAST({col} AS TIMESTAMP))), CAST({col} AS TIMESTAMP))",
        "PT1H": "TIMESTAMPADD(SECOND, -(HOUR(CAST({col} AS TIMESTAMP))*60*60+MINUTE(CAST({col} AS TIMESTAMP))*60+SECOND(CAST({col} AS TIMESTAMP))), CAST({col} AS TIMESTAMP))",
        "P1D": "CAST(CAST({col} AS TIMESTAMP) AS DATE)",
        "P1W": "CAST(TIMESTAMPADD(DAY, -(DAYOFWEEK(CAST({col} AS TIMESTAMP))-1), CAST({col} AS TIMESTAMP)) AS DATE)",
        "P1M": "CAST(TIMESTAMPADD(DAY, -(DAYOFMONTH(CAST({col} AS TIMESTAMP))-1), CAST({col} AS TIMESTAMP)) AS DATE)",
        "P0.25Y": "CAST(TIMESTAMPADD(MONTH, (QUARTER(CAST({col} AS TIMESTAMP))-1)*3, CAST((CAST(YEAR(CAST({col} AS TIMESTAMP)) AS VARCHAR) + '-01-01 00:00:00') AS TIMESTAMP)) AS DATE)",
        "P1Y": "CAST(TIMESTAMPADD(DAY, -(DAYOFYEAR(CAST({col} AS TIMESTAMP))-1), CAST({col} AS TIMESTAMP)) AS DATE)",
}

make spark support floor function like hive is hard for me, orz~

Closing this since the thread has gone inactive. It also sounds like there's a workaround, and the real fix might not be in Superset. If I'm misinterpreting, let me know, and I'll happily re-open the issue.


Bepwap chaosnet down for maintenance?

How long is Bepswap going to be down for maintenance? I use Trust wallet to access Bepswap and have no access to my account except through the Bepswap website so curious how long site will be down and when we will be able to trade again.
Lastly, I provided liquidity to an Injective protocol LP and it was showing up in the total on my wallet summary but never showed up on the Bepswap website summary even 48 hours later.

chaosnet.bepswap.com just came back to "normal" (no maintenance anymore)


perf (AlgebraicGeometry.Properties): Speed up one declaration

This speeds up on declaration by breaking up a defeq check into a single task.

!bench

!bench

bors merge


Top Navbar

Slight bug where it won't let you hover over home, news, etc and always reverts to opening the "About" dropdown. I know it's something I did. It's some dirt code at the bottom of jkit.css where I had to refer to a lot of ul, li and a's. But putting the issue here since I don't have time to fix it right now.

I removed it for now. Going to implement a cleaner way to do it.


Renamed image correction routines and xrt_teem

xrt_deconvolve and xrt_remove_lightleak were moved from the util directory to a new directory named image_correction and the xrt_ parts of their names were removed. xrt_teem was renamed to temperature_from_filter_ratio. All the tests and notebooks were fixed to reflect the name and directory changes.

Wow, this PR looks fantastic! 🚀 It's clear you put a lot of effort into this, glad test are passing!


⚠ Quirk Club Argentina (SSR) has degraded performance

In 4cf6384, Quirk Club Argentina (SSR) (https://quirkclub-dev.web.app/ssr-check) experienced degraded performance:

HTTP code: 200
Response time: 5006 ms

Resolved: Quirk Club Argentina (SSR) performance has improved in 84d3a76 after 11 minutes.


Support for deferred parsing of HTML event handlers.

Support in the ChakraCore repo for deferred parsing of HTML event handlers.

@curtisman @Yongqu

otherwise Looks good to me.

agree don't need to make that change now. LGTM.


Really useful page

This page brings me through a really useful new technique, which I need to use. I think I now understand how the construct handles the Pagination. Sadly, not enough detail or link to how to setup the Authentication, so I will need to research that elsewhere. Thanks for a clear overview on the Pagination. JK

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9da1816-3f64-bd45-443f-5bdb48bacc24
Version Independent ID: e649f787-62da-fc97-2e9a-ba89765beed4
Content: Copy data from a REST source by using Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/connector-rest.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@Joe8908  : Thanks for the great feedback . @linda33wj  for visiblity


chore: reorganize changelog

This PR fixes #859
Reorganizing changelog in such a way:

split major version into separate files: CHANGELOG.v{N}.md
configured scripts/changelog-builder.sh to generate the changelog for v4 version

NOTE: for v5 release the scripts/changelog-builder.sh have to be tuned. Or if you have a suggestion - I'll appreciate your contribution on how to define:  git tag --list "list only tags after v3.1.38"

@yhattav hmmm don't know should I do something with Test / deploy, looks unrelated to my changes?


[AutoPR] redis/resource-manager

Created to accumulate context: redis/resource-manager

(message created by the CI based on PR content)

@AutorestCI rebase

Rebase done and pushed to the branch

Codecov Report

Merging #2091 into master will decrease coverage by <.01%.
The diff coverage is 42.34%.

@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
- Coverage   53.08%   53.07%   -0.01%
==========================================
  Files        4774     4777       +3
  Lines      119517   119605      +88
==========================================
+ Hits        63440    63485      +45
- Misses      56077    56120      +43

Impacted Files
Coverage Δ

...ure-mgmt-redis/azure/mgmt/redis/models/__init__.py
100% <100%> (ø)
:arrow_up:

...is/azure/mgmt/redis/operations/redis_operations.py
29.2% <28.81%> (+0.36%)
:arrow_up:

.../mgmt/redis/operations/linked_server_operations.py
21.69% <50%> (+3.07%)
:arrow_up:

...mgmt/redis/operations/firewall_rules_operations.py
21.97% <50%> (+3.58%)
:arrow_up:

...mt-redis/azure/mgmt/redis/operations/operations.py
43.75% <50%> (+1.81%)
:arrow_up:

...is/azure/mgmt/redis/models/upgrade_notification.py
55.55% <55.55%> (ø)

...gmt/redis/operations/patch_schedules_operations.py
27.14% <57.14%> (+4.41%)
:arrow_up:

...redis/models/check_name_availability_parameters.py
57.14% <57.14%> (ø)

...re/mgmt/redis/models/notification_list_response.py
62.5% <62.5%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f262d80...a05884c. Read the comment docs.


CP: Update Vaadin and collaboration-engine

cherry-pick: #51

Revert "Fix memory leak (#48)"
This reverts commit 5fb94e6d542e38936afd6fef496614aebf9ebec6.

Updated versions in pom
Use vaadin 21 stable
Force collaboration-engine version to 3.2.1

Updated generated files

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: tulioag:x: anezthes:x: PeppeYou have signed the CLA already but the status is still pending? Let us recheck it.

Seems like I was accidentally commenting on the wrong PR. Those changes that I suggested should go to master first rather than being applied directly to production.

Reverted. PRs created for master.

Would it be clearer to instead recreate the merge instead of having reverts in it?

Recreated the branch.

Outdated.


Kenna - Prisma integration stopped working Aug. 20th

Thank you for taking the time to help us improve our documentation! Please describe the problem and a suggested fix below and we'll get back to you as soon as we can. --DevRel
These Prisma runs are not ingesting any data because the API is returning a 404 when we attempt to retrieve current projects from Prisma.
Endpoint: https://europe-west3.cloud.twistlock.com/eu-2-143540008/api/v1/current/projects
Response: 404 NotFound
The public Prisma API docs mention newer versions, but testing these new endpoints also resulted in the same response as above: https://prisma.pan.dev/api/cloud/cwpp/current/#operation/get-current-projects

The documentation may need to be updated with more accurate URLs or some possible network related issue between Prisma and Kenna is occurring.

@ssugandh , PTAL

There's a missing cURL example and description in our docs. Working on it.


[BUG] Sharing images in reading page causes a crash & Clearing gallery history doesn't work

Device: iPad Pro 11 gen3
OS: iPadOS 15.2.1
App Version v1.5.4_b125

Screen Record
https://user-images.githubusercontent.com/53338814/149611144-5c78168e-2f61-4b30-8f3b-ed78025afb4b.mov

Thanks for your feedback!
This probably will be fixed by refactoring.

I've released EhPanda 2.0. Please feel free to reopen this issue if anyone finds out this bug is reproducible in the new version.


After formatting comments disappear

The parser currenlty only acknowledges comments ( //, /* ... */ ) but doesn't add them to the AST.
Fixing this problem probably by moving the jsjavaparser java language definition into this project and updating it.

finally solved!!! :)

Yay!


build timed out while kubectl --wait

waiting for SPIRE server to be ready.
error: no matching resources found
waiting for SPIRE agent to be ready.
error: timed out waiting for the condition on pods/spire-agent-9vncl
next

From docs "The kubectl wait command by default waits forever until the specified condition is met. However, you might be experiencing this timeout due to an implicit default timeout within the system or a network interruption between your client and the server."
This is likely something to do with my harness.
I haven’t been seeing it for a long time.
Closing this.


Crypto subsets:  AES128 + AES256 always  come together ?

PROPOSAL  -  POR
AES 128 and AES 256 come together, they cannot be separated.
If an implementation implements AES 128 it must implement AES 256, and vice versa.
(Placing my understanding  of consensus in meetings here in the issue statement.  Should be corrected if I have misunderstood.)

Related issues:
#38 <-- combination of #36 and #37

As decided at meeting 23/oct/2020 - closing all feature-group related issues and tracking in Jira.


Make the parsers and the serializers lazy

Implemented without coroutines in a Tcl 8.5-compatible way in 544e4180d26a71a3db59dd813606507d84ac7e6c (serialization), f77a75aacdf24c201032f17e9c7e2b45b8ad21e0 (parsing), fc137fbd40be7f60cdab22271969a9959330e62a (reading the input in the awk parser).


[MLPERF] Retinanet

With BEAM=2 and BS=52, 2s step time - https://wandb.ai/schlimeszn/RetinaNet/runs/vl05ksdl
Trained .75 of 1 epoch and got eval score of 0.12 (target 0.34) - https://wandb.ai/schlimeszn/RetinaNet/runs/0i6fu2u2/logs
Tested on 4xA100_40gb
Testing BEAM=3 - https://wandb.ai/schlimeszn/RetinaNet/runs/sr6gf6va
Testing BEAM=2 BS 100 FP16 - ~~https://wandb.ai/schlimeszn/RetinaNet/runs/i0m5pf1r~~ https://wandb.ai/schlimeszn/RetinaNet/runs/5afh53lc
7h15m epoch time. Need 4 epoch to train to completion
4/24/24:
ON 3080 10gb
MODEL=retinanet CUDA=1 BS=2 DEFAULT_FLOAT=float16 SPLIT_REDUCEOP=0 TRAIN_BEAM=3 IGNORE_JIT_FIRST_BEAM=1 BEAM_UOPS_MAX=1500 BEAM_UPCAST_MAX=128 BEAM_LOCAL_MAX=1024 BEAM_MIN_PROGRESS=50 DEBUG=2 python3 examples/mlperf/model_train.py RESULTS .5s step time
BEAM=4 - .35s
BEAM=5 - .37s (regresses?)
REF IMPL - .15s step time
TODO:

[x]  Add float16 support
[ ] Fix float16 save, float32 works
[ ] Add bfloat16 support
[ ] Speed up validation loop
[ ] Fix val loop memory bloat (holding grads)
[ ] Cleanup anchor gen code
[x] Remove old retinanet code
[ ] Add random hflip to image and boxes
[x] Fix OOM after 1 train and val loop
[ ] Add lr_step to jit funcs (On second run, went back to 1.9s step (from 2.3s))
[ ] Combine openimages and openimages_new (and both batch_loaders)
[ ] move relevant code to mlperf dataloader
[ ] condense encode_boxes()

INSTRUCTIONS:
DOWNLOAD
pip3 install fiftyone
Go to extra/datasets and run python3 openimage_download.py
TRAIN
MODEL=retinanet CUDA=1 BS=24 GPUS=6 DEFAULT_FLOAT=float16 WANDB=1 python3 examples/mlperf/model_train.py - step time 3s
BEAM worked on personal machine with 1 gpu, but still searching 6 hours in on 6x2080ti. Testing BEAM=3 on 1 gpu of the 6, and then restarting train with 6 gpu (2080 cluster is dogshit)
4/26: READY TO RUN
MODEL=retinanet CUDA=1 BS=24 GPUS=6 DEFAULT_FLOAT=float16 SPLIT_REDUCEOP=0 BEAM=3 IGNORE_JIT_FIRST_BEAM=1 BEAM_UOPS_MAX=1500 BEAM_UPCAST_MAX=128 BEAM_LOCAL_MAX=1024 BEAM_MIN_PROGRESS=50 WANDB=1 python3 examples/mlperf/model_train.py

Beam 3 BS 52 OOM
Beam 3 BS 32 1.3s but 37, 28, 28, 28 gb used in gpu
This is still proportional to BEAM 2 BS 52 step 2s

to lock the bounty, show a wandb link or equivalent that this trains to mlperf required target in 24 hours

School is on a training run rn, no available compute. Can you do a run on a tiny tn for atleast 1 epoch?
Expected scores:
Epoch 1: 0.23
Epoch 2: 0.29
Epoch 3: 0.334989
Epoch 4: 0.3463

@chenyuxyz can you run to get a step-time for me to compare to?

getting NANs, need to bisect

Current WINO(1.2s step):
MODEL=retinanet CUDA=1 BS=32 GPUS=4 DEFAULT_FLOAT=float32 PYTHONPATH=. WANDB=1 TRAIN_BEAM=3 IGNORE_JIT_FIRST_BEAM=1 BEAM_COMPARE=0 BEAM_TIMEOUT_SEC=240 UOPS_REWRITE=0 BEAM_UOPS_MAX=0 BEAM_MIN_PROGRESS=20 WINO=1 LAZYCACHE=0 python3 examples/mlperf/model_train.py

Has this succeeded in producing a qualifying model?

After the merge, getting NAN. Doing a run on a pre merge branch: https://wandb.ai/schlimeszn/RetinaNet/runs/0xl12h6e?nw=nwuserschlime. It's on epoch 3/4 and the first 2 epochs match Nvidia's submission. This is fp32, batch 32, 1.2s step time, 12h epoch time. On the same branch I tried fp16, batch 64, 1.1s step time, 6 hr epoch time. The problem with this is I think I have gradient underflow(or resnet load not liking the casts) as the loss isn't going down properly: https://wandb.ai/schlimeszn/RetinaNet/runs/yo1kg8ou?nw=nwuserschlime


fix eslint for node app

fix: https://github.com/Azure/azure-dev/issues/2139
eslint fixes for node app

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/2148
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/2148

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks
Remote: azure-samples-staging
Branch: pr/2148
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/2148

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/2148
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/2148

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/2148
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/2148

View Changes | Compare Changes

Project: todo-nodejs-mongo-terraform
Remote: azure-samples-staging
Branch: pr/2148
You can initialize this project with:
azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/2148

View Changes | Compare Changes


Duplicates leak to remote-write

What did you do?
Per docs prometheus works in this order:

scrapes target
do relabel
drop duplicates (logs them: https://github.com/prometheus/prometheus/issues/11725)
ingest the rest, there cannot be duplicates in tsdb by design
replicate local tsdb from WAL via remote-write to target endpoint

Unfortunately we see that duplicates also leak to remote-write.
Way to reproduce:

We will start prometheus, which would scrape nginx and remote-write to mimir:

version: '2'
services:

  prometheus:
    container_name: prometheus
    hostname: prometheus
    image: prom/prometheus:v2.43.0
    command:
      - --config.file=/cfg/prometheus.yml
    volumes:
      - ./prometheus.yml:/cfg/prometheus.yml
    ports:
      - '9090:9090'

  nginx:
    container_name: nginx
    hostname: nginx
    image: nginx
    volumes:
      - ./metrics:/usr/share/nginx/html/metrics
      - ./metrics2:/usr/share/nginx/html/metrics2
    ports:
      - '8081:80'

  mimir:
    container_name: mimir
    hostname: mimir
    image: grafana/mimir:2.7.1
    command:
      - -auth.multitenancy-enabled=false
      - -ingester.ring.replication-factor=1
    ports:
      - '8080:8080'

prometheus config:

global:
  scrape_interval: 1s
scrape_configs:
  - job_name: own
    static_configs:
      - targets:
          - prometheus:9090
          - mimir:8080

  - job_name: duplicates
    static_configs:
      - targets:
          - nginx:80

remote_write:
  - url: http://mimir:8080/api/v1/push

duplicate metrics:

$ for i in `seq 100000`; do echo "same_metric_name $i"; done > metrics
$ head metrics
same_metric_name 1
same_metric_name 2
same_metric_name 3
same_metric_name 4
same_metric_name 5
same_metric_name 6
same_metric_name 7
same_metric_name 8
same_metric_name 9
same_metric_name 10

start this via docker-compose, and let's see prometheus metrics:

same_metric_name{instance="nginx:80", job="duplicates"} 1 # all lines deduplicated to just one metric, correct
prometheus_tsdb_head_series{instance="prometheus:9090", job="own"} 5169 # no 100k series in tsdb, correct
scrape_samples_scraped{instance="nginx:80", job="duplicates"} 100000 # hm, ok
scrape_samples_post_metric_relabeling{instance="nginx:80", job="duplicates"} 100000 # shouldn't it be just 1 here?
# sending speed via remote-write in samples/s
rate(prometheus_remote_storage_samples_total[1m]) 102902 # why? there are only 5k samples in head
# mimir failed samples/s
rate(cortex_ingester_ingested_samples_failures_total[1m]) 6883.5292321782945 # that actually matters, see below

logs on mimir side:

mimir       | ts=2023-04-12T18:02:44.403379149Z caller=push.go:130 level=error user=anonymous msg="push error" err="rpc error: code = Code(400) desc = failed pushing to ingester: user=anonymous: the sample has been rejected because another sample with the same timestamp, but a different value, has already been ingested (err-mimir-sample-duplicate-timestamp). The affected sample has timestamp 2023-04-12T18:02:44.39Z and is from series {__name__=\"same_metric_name\", instance=\"nginx:80\", job=\"duplicates\"}"

That seems as a bug on prometheus side for me. If there cannot be duplicates in tsdb, how do they appear when tsdb is being replicated via remote-write?
What did you expect to see?
I would expect that all duplicates issues would be handled on prometheus side, and then only data passed all validations would be replicated further via remote-write.
What did you see instead? Under which circumstances?
That does not sound like a big issue, but unfortunately it is harmful for people writing to mimir in distributor/ingester mode (i believe thanos-router/receive scheme would have the same issue).

one of tenants got around 20 targets in his prometheus, exposing 400k duplicated metrics each. Not a big deal as we can ingest 9M ok-series easily
any non-ok remote-write request starts to increase latency on incoming processing in mimir. In this case it has been 9M tainted samples, so large amount of incoming packets start to get 4xx
usual incoming latency in our cluster 10-30ms, in this case it spiked to 1-3s
mimir distributor component reads incoming http request to memory, parse remote-write proto and then replicates request to ingesters, awaits quorum number write confirmation and only then answers to incoming http request
in case of increased latency it has to hold 3s of incoming 150Mbit/s flow in memory, it does back-pressure with currently established connections from prometheuses, but proms just spawn new shards if current slows down. Customers manage their prom configs, we cannot dictate remote_write.queue_config to them
distributors start massively die of OOM, affects other. It even has context_deadline_timeout of 2s, so if we scale mem and replicas quickly, we anyway getting massive amounts of 5xx because ingester latency grows even higher than that. And 5xx triggers re-sends from prometheuses, so situation escalates quickly

System information
No response
Prometheus version
No response
Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Can you post your Prometheus logs please?  I expect there are error messages about the data.

Note that a sample with the same labels and same timestamp but different value is not a "duplicate", it is an error.

That seems as a bug on prometheus side for me. If there cannot be duplicates in tsdb, how do they appear when tsdb is being replicated via remote-write?

If I understand the architecture correctly, remote write replicates the unprocessed data from the WAL, not the successfully processed data, which means that any receiver would have to perform the same checks on their end.

I am collecting similar format error logs from prometheus.
My Config:
Distributed with helm,
targetRevision: 47.5.0
agentMode: true
prometheusSpec:
replicaExternalLabelNameClear: true
prometheusExternalLabelNameClear: true
replicas: 1
shards: 2
remoteWrite: [ MY MIMIR SERVER ]
Part of the config is as above, and you can see that the following error occurs due to overlapping writing in each shard. This is causing the memory usage of the prometheus pod to skyrocket.
ts=2023-11-15T03:31:17.310Z caller=dedupe.go:112 component=remote level=error remote_name=a72022 url=https://MY-MIMIR-gateway.SAMPLE.com/api/v1/push msg="non-recoverable error" count=2000 exemplarCount=0 err="server returned HTTP status 400 Bad Request: failed pushing to ingester: user=smaple-tenant: the sample-tenant has been rejected because another sample with the same timestamp, but a different value, has already been ingested (err-mimir-sample-duplicate-timestamp). The affected sample has timestamp 2023-11-15T03:31:04.37Z and is from series {__name__=\"http_client_duration_milliseconds_count\", app=\"MY-SAMPLE_SERVER\", endpoint=\"metrics\", env=\"test\", http_method=\"POST\", http_status_code=\"200\", instance=\"<IP_ADDRESS>\", namespace=\"default\", net_peer_name=\"smaple.SAMPLE.com\", net_protocol_name=\"http\", net_protocol_version=\"1.1\", pod=\"MY-SAMPLE_SERVER-rollout-12345-12345\", service=\"MY-SAMPLE_SERVER-svc\"}"
Values such as ip, url, tenant, etc. were replaced with sample values for security.

Hello from the bug-scrub!
I believe this is still an issue.  #12933 disallowed duplicates in the scrape itself, but it does not check whether relabeling creates a duplicate.


Updates styles on needs page to center header and filters

standardizes mobile media query to 411 px across some components
switches flex direction (column -> row) for mobile on header and filter list
fixes width of filter buttons on mobile so it appears in an orderly column
wraps all content if too large for screen using flex-wrap

addresses #21

regarding wrapping -- How do we want all these to be displayed on desktop and up? One simple way is to just fix button size and make it a grid under search.

regarding wrapping -- How do we want all these to be displayed on desktop and up? One simple way is to just fix button size and make it a grid under search.

Makes sense to me. I actually think the new request action probably belongs on the right and the filters on the left. Not sure why but it makes more sense to me to have the majority of the controls left aligned. Also the button should be a different color or in some way indicate that it is different from the filter buttons.

just added a grid + flexbox fallback situation. looking at the commit its clear i'm not following whatever style guidelines are there (my editor has its own defaults) so happy to change if there's a guide somewhere

just added a grid + flexbox fallback situation. looking at the commit its clear i'm not following whatever style guidelines are there (my editor has its own defaults) so happy to change if there's a guide somewhere

Please use prettier. See https://github.com/mmoutenot/mamas-needs-offers/blob/master/.prettierrc for our ruleset.

sorry about the mess. should be up to date. here's how it looks.
desktop

tablet:

mobile (wide)

mobile

Looks good to me. Definitely better than what we have now. @mewtaylor any feedback you want to add? If anything I think the search bar belongs above the other filters rather than with the new button because it’s kind of a filter.

@dcalacci do you mind rebasing this when you get a chance?


Add fastify-compression and fastify-cors

This change lets web apps call Formidable on behalf of the user (a browser fetch call). This change also adds fastify-compression which from my testing reduces response sizes by 2x-3x.
To test the cors change, I used this snippet in an app I'm working on:
  const id = 147
  const detail = await fetch(`http://localhost:8080/ships/id?code=${id}`, {
      headers: { "content-type": "application/json" },
    }).then((r) => {
      if (r.ok) {
        return r.json();
      }
    });
    console.log(detail);

I tested the compression change by looking at the sizes on the Network tab of Chrome Devtools.

Did you add something other than the fastify compression and cors in the recent commits?

No. I forgot that pull requests work like that — sorry. I can get rid of those changes if you’d like. But they let you build this into a container, which is nice.

You could include the docker support on an another branch then re-open a pr if you feel Formidable should have it built in. This pr should deal with fastify-compression and fastify-cors only for consistency

Ok - I'll open a new PR with just the relevant changes. Please excuse my naiveté 🥴


Documentation missing for sap.ui.model.type.String

The documentation for the constructor of sap.ui.model.type.String is missing oConstraints.minLength
OpenUI5 1.32.9

This has already been fixed via 47660e12a898b6d86c4a0293894c9e00d30849b3 which is only part of 1.34.
I will do a down-port to 1.32 as 1.34 is not officially released, yet.
But you can already see it in the openui5 beta deployment:
https://openui5beta.hana.ondemand.com/#docs/api/symbols/sap.ui.model.type.String.html#constructor

Fixed via 4b2d0693dfbd022d854c096669a86392235435ec in branch rel-1.32. It will be part of 1.32.10.


Implement image uploading on backend

We need to implement image uploading on the backend, so that we can implement the Browse and Upload page. The following needs to be implemented:

Image upload and persistent storage
On image upload, create a thumbnail for it (resolution to be determined)
Uploaded image should be stored in full detail (we aren't facebook)
Max image upload of 10MB
Give images unique names
Store URL's in the database along with meta data

It is possible that there are more that needs to be implemented, i might have forgotten something.

Image upload has been implemented with auth, although tests are still needed to be made for that part.
Next step is retrieving images etc.

Requirements fulfilled. Closing issue.


Restore window to size and location when starting app

VSCode Version: Code 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b, 2017-05-04T21:18:32.269Z)
OS Version: Darwin x64 16.3.0
Extensions:

Extension
Author
Version

vscode-css-formatter
aeschli
0.0.2

theme-hop-light
bubersson
0.0.2

theme-jsfiddle-like-syntax-vscode
davidmart
0.0.6

Theme-Dawn
gerane
0.0.2

vs-color-picker
lihui
0.6.0

FlatUI
lkytal
1.1.0

By default, the app should start with the main window the size and location when it was shut down. This is standard in many if not most apps.

@JohannBlake restoring the size and location is the expected and implemented behaviour, can you describe what doesn't work for you.

Related: https://github.com/Microsoft/vscode/issues/24227
@JohannBlake can you please explain in detail what you are doing and how the window does not restore? Best, share a video recording.

Actually it does work if you click on the menu item "Visual Studio Code close". But if you right click on the app's icon when the app is running (on Mac's app bar at the bottom of the screen) and then click on Quit, it will not save the size or location. This appears to be inconsistent.

@JohannBlake I cannot reproduce, what are you doing differently?

Ok, I think I've managed to see where it's not working. Move and resize the window. But don't quit the app. Just close it by tapping on the red close button in the upper left part of the window. Then open the app again by tapping on the app icon at the bottom of the screen. The app window reverts to the location and size where you last saved it.

@JohannBlake thanks I see it!

Verify:

macOS only, move a window around
close the window (do not quit the app)
quit
restart and the dimension and location is restored


c++ code samples

Hello, where can I find the full working codes of cpp samples ? They are not on Github and the website only gives the code in parts. I tried assembling one of the samples and it didn't work. Thank you for your help!

I just found them. They are in the examples directory: "librealsense/examples/"


EAS build not working on expo managed workflow

Description
Hello.
I've tried to use this package for kakaotalk login with Expo managed workflow.
Steps to reproduce
When I use eas build -p android --profile development command, it's showing this error.

Here's my app.json

React Native Kakao Login version
5.3.0
React Native version
0.72.5
Platforms
Android
JavaScript runtime
None
Architecture
None
Build type
Debug mode
Device
Android emulator
Device model
No response
Acknowledgements
Yes

@kAutoman
Did you solve this issue?

@kAutoman
But, I have a problem.
Do you know this problem?
iOS build is fine, but it's only happening on Android.

show me package.json and app.json

@kAutoman
This is my setup
app.json
{
  "expo": {
    "name": "Haeboda App",
    "slug": "haeboda-app",
    "scheme": "haeboda",
    "version": "1.0.0",
    "orientation": "portrait",
    "icon": "./assets/icon.png",
    "userInterfaceStyle": "light",
    "splash": {
      "image": "./assets/splash.png",
      "resizeMode": "contain"
    },
    "assetBundlePatterns": ["**/*"],
    "ios": {
      "supportsTablet": true,
      "bundleIdentifier": "com.coffsun.haebodaapp",
      "usesAppleSignIn": true
    },
    "android": {
      "adaptiveIcon": {
        "foregroundImage": "./assets/adaptive-icon.png",
        "backgroundColor": "#ffffff"
      },
      "package": "com.coffsun.haebodaapp"
    },
    "web": {
      "favicon": "./assets/favicon.png",
      "bundler": "metro"
    },
    "plugins": [
      "expo-router",
      "expo-apple-authentication",
      [
        "@react-native-seoul/kakao-login",
        {
          "kakaoAppKey": "6ca652258b77e55a2c0955aa33f9e451",
          "overrideKakaoSDKVersion": "2.9.0",
          "kotlinVersion": "1.8.22"
        }
      ]
    ],
    "extra": {
      "router": {
        "origin": false
      },
      "eas": {
        "projectId": "c83b805e-ba57-4c6f-8983-3e8f9aa95385"
      }
    }
  }
}

package.json
{
  "name": "haeboda-app",
  "version": "1.0.0",
  "main": "expo-router/entry",
  "scripts": {
    "start": "expo start",
    "android": "expo run:android",
    "ios": "expo run:ios",
    "web": "expo start --web",
    "lint": "eslint ."
  },
  "dependencies": {
    "@expo-google-fonts/noto-sans-kr": "^0.2.3",
    "@expo/webpack-config": "^19.0.0",
    "@react-native-async-storage/async-storage": "1.18.2",
    "@react-native-seoul/kakao-login": "^5.3.1",
    "@rneui/base": "^4.0.0-rc.7",
    "@rneui/themed": "^4.0.0-rc.8",
    "axios": "^1.5.1",
    "expo": "~49.0.5",
    "expo-apple-authentication": "~6.1.0",
    "expo-auth-session": "~5.0.2",
    "expo-blur": "~12.4.1",
    "expo-constants": "~14.4.2",
    "expo-crypto": "~12.4.1",
    "expo-dev-client": "~2.4.12",
    "expo-font": "~11.4.0",
    "expo-image": "~1.3.5",
    "expo-linking": "~5.0.2",
    "expo-router": "^2.0.0",
    "expo-splash-screen": "~0.20.5",
    "expo-status-bar": "~1.6.0",
    "expo-system-ui": "~2.4.0",
    "expo-web-browser": "~12.3.2",
    "firebase": "^10.5.2",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "react-native": "0.72.6",
    "react-native-gesture-handler": "~2.12.0",
    "react-native-safe-area-context": "4.6.3",
    "react-native-screens": "~3.22.0",
    "react-native-svg": "13.9.0",
    "react-native-web": "~0.19.6",
    "react-query": "^3.39.3"
  },
  "devDependencies": {
    "@babel/core": "^7.20.0",
    "@types/react": "~18.2.14",
    "eslint": "^8.47.0",
    "eslint-config-universe": "^12.0.0",
    "react-native-svg-transformer": "^1.1.0",
    "typescript": "^5.1.3"
  },
  "overrides": {
    "metro": "0.76.0",
    "metro-resolver": "0.76.0"
  },
  "eslintConfig": {
    "extends": "universe/native"
  },
  "private": true
}

@kAutoman
Thank you!
I solved the problem this way (https://github.com/crossplatformkorea/react-native-kakao-login/issues/392)


1.x backport abstract type fix

pulls up __resolveType functions to the parent to fix abstract type issue

simplifies the import loop in the GraphQLComponent constructor

minor variable/function renaming for readability

removes some resolvers module functions and simplifies getImportedResolvers()

adds/modifies supporting unit tests

going to close this PR and put up a new one that is simpler/easier to follow


UHF-3268 News item

How to test / install:

Make sure your instance is up and running on latest dev branch, preferably Strategia & Talous instance.
Update the modules/themes

composer require drupal/hdbt:dev-UHF-3268_news_item && composer require drupal/helfi_platform_config:dev-UHF-3268_news_item && composer require drupal/hdbt_admin:dev-UHF-3268_news_item

Go to shell make shell

In shell, type drush en -y helfi_news_item
Exit shell

Run updates, import translations and clear caches make drush-updb drush-locale-update drush-cr
Log in to the site and go to create few news tags: https://strategia.docker.so/fi/paatoksenteko-ja-hallinto/admin/structure/taxonomy/manage/news_tags/add

No need to add anything else than just the Name field and hit
Hox! The news tags are themed, but not visible until the news tag pages are built

Go to create news item(s) https://strategia.docker.so/fi/paatoksenteko-ja-hallinto/node/add/news_item

Tip: Try copying real content from https://www.hel.fi/uutiset/fi
Add the following fields:  Title (Otsikko), Lead-in (Johdanto), Main image (Pääkuva), Content (Pääsisältö), Links (Linkit) and select News tags (Uutistagit) and from sidebar Short title (Lyhyt otsikko)

After you have enough content, test that:

Publish and unpublish works (disappears from the latest news list)
Translations works (only current language content is listed)
Short title works (shows short title in lists, url and breadcrumb but not in the news item itself)

Check the specs from https://helsinkisolutionoffice.atlassian.net/browse/UHF-3268 as the task itself is already done.
This PR also has the theming included. Check that the layout looks and works as designed: https://share.goabstract.com/1d0a8fe1-a4e6-4160-8a5d-95e3c66b7cf1?collectionLayerId=d329ae36-624f-4a7a-b75c-ef37f2194376&mode=design&sha=latest

Bonus

Explore the site and inspect images. Check that the images have width and height attributes set, like so:

Check also:

https://github.com/City-of-Helsinki/drupal-hdbt/pull/210
https://github.com/City-of-Helsinki/drupal-hdbt-admin/pull/98

External links have the same icon as the internal ones - was this by design since if I read correctly they should have different ones according to the original specs:

This issue is noted and will be addressed in future tasks.


affected/package: net/http

What version of Go are you using (go version)?

$ go version
go version go1.20.3 darwin/arm64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/caster/Library/Caches/go-build"
GOENV="/Users/caster/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/caster/go/pkg/mod"
GONOPROXY=""
GONOSUMDB="gitlab.ustock.cc/*"
GOOS="darwin"
GOPATH="/Users/caster/go"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="0"
GOMOD="/Users/caster/go/src/github.com/lxzan/go-websocket-testing/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/q0/5vn9xlns1cd70d3mzcdg3jv00000gn/T/go-build966805946=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

upgrade http to websocket
What did you expect to see?
After hijacking the http connection, the bufio.Reader/Writer in the connection is garbage collected
What did you see instead?
They have never been released

which bufio Reader / Writer are you referring to?
Do you have code to demonstrate the issue?

Hi @seankhliao, the returning of a write buffer you likely pointed at, http.response.w, is for the buffer used in chunked-encoding. It is one of two write buffers that are used as part of the request/response life cycle.
https://github.com/golang/go/blob/35222eeb78ddb84f5787729c5f149cfd73d63ef8/src/net/http/server.go#L2118
The other write buffer is attached to the connection, http.conn.bufw, and it remains unused after hijacking.
https://github.com/golang/go/blob/35222eeb78ddb84f5787729c5f149cfd73d63ef8/src/net/http/server.go#L288-L289
As part of the hijack process, the connection read buffer, http.conn.bufr, will be re-used and returned to the hijack caller. A new write buffer will be allocated and returned to the caller.
https://github.com/golang/go/blob/35222eeb78ddb84f5787729c5f149cfd73d63ef8/src/net/http/server.go#L325
I do not see a need for allocating a new write buffer as part of the hijack process. After hijacking a connection, no further writes can be made via the http.response methods.
So we might as well re-use the connection write buffer and return it to the hijack caller. WDYT @seankhliao?
The net/http unit tests are happy with the following patch and BenchmarkServerHijack records a reduction of two allocations worth 4172 bytes per operation (the 4096B buffer slice and a struct for the buffer).
Patch: 25b0691cf41bcf5a8d9a0446e93f5eb6ab3f90b8
diff --git a/src/net/http/server.go b/src/net/http/server.go
index<PHONE_NUMBER>..0ba55e8ee5 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -322,7 +322,7 @@ func (c *conn) hijackLocked() (rwc net.Conn, buf *bufio.ReadWriter, err error) {
        rwc = c.rwc
        rwc.SetDeadline(time.Time{})

-       buf = bufio.NewReadWriter(c.bufr, bufio.NewWriter(rwc))
+       buf = bufio.NewReadWriter(c.bufr, c.bufw)
        if c.r.hasByte {
                if _, err := c.bufr.Peek(c.bufr.Buffered() + 1); err != nil {
                        return nil, nil, fmt.Errorf("unexpected Peek failure reading buffered byte: %v", err)

 BenchmarkServerHijack stats
goos: linux
goarch: amd64
pkg: net/http
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
               │   old.txt   │               new.txt               │
               │   sec/op    │   sec/op     vs base                │
ServerHijack-8   13.28µ ± 2%   10.84µ ± 3%  -18.36% (p=0.000 n=10)

               │   old.txt    │               new.txt                │
               │     B/op     │     B/op      vs base                │
ServerHijack-8   15.84Ki ± 0%   11.77Ki ± 0%  -25.70% (p=0.000 n=10)

               │  old.txt   │              new.txt              │
               │ allocs/op  │ allocs/op   vs base               │
ServerHijack-8   50.00 ± 0%   48.00 ± 0%  -4.00% (p=0.000 n=10)

I can open a PR with the patch in case you are happy with the approach, @seankhliao.


fix: udpate ui and restore memkey check

:tada: This PR is included in version 0.274.5 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Travis upgrade

Upgrades to .travis.yml to upgrade to their latest config recommendations.
Also constrains the testing to the tests/ directory to avoid a naming clash with a test_ file in the main package which isn't for automated testing.

I think we can try making h5py a dependency again (we will revert it if we start seeing issues pop up again). Can you rebase to turn your commits into a single commit, or at least into a list of commits that will make the history more readable?

I'll rebase this into a single commit, hopefully tomorrow.

Squashed the excessive commits.