Dismiss Keyboard on route change

This affects cases where the focused input may still exist but be
offscreen w/ the React Navigation CardStack, such as the signup success
paper key display screen.

will this result in the keyboard hiding and coming back right away?

@MarcoPolo It does, but this also happens if you submit an input using the keyboard return button, or if you tap a button on iOS. Let's get this to fix the buggy behavior for now and defer polishing the keyboard interactions to a later ticket.

I need this and this is pretty old so i'm having login issues w/ the daemon. merging


feat: update all_lint_rules

🙌 What's Done

Several rules have been removed or added according to https://dart.dev/tools/linter-rules/all!

Added
https://dart.dev/tools/linter-rules/missing_code_block_language_in_doc_comment
https://dart.dev/tools/linter-rules/unintended_html_in_doc_comment
https://dart.dev/tools/linter-rules/unnecessary_library_name
Removed
https://dart.dev/tools/linter-rules/always_require_non_null_named_parameters
https://dart.dev/tools/linter-rules/avoid_returning_null
https://dart.dev/tools/linter-rules/avoid_returning_null_for_future
https://dart.dev/tools/linter-rules/list_remove_unrelated_type
https://dart.dev/tools/linter-rules/iterable_contains_unrelated_type
https://dart.dev/tools/linter-rules/avoid_unstable_final_fields
✍ What's Not Done

🖼 Image Differences

📝 Additional Notes

@k-nkmr
Please approve 😼


How can I remove myself from an organization while I'm locked and therefore cannot login?

Can you please explain how I can leave an organization that has locked my account? As I cannot login, the "leave" will not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b448cfd0-b673-7d04-047b-71aa62bebc27
Version Independent ID: 75118bff-94de-c9f9-7666-d2a6f4253b11
Content: Leave an organization as a guest user - Azure Active Directory
Content Source: articles/active-directory/b2b/leave-the-organization.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@chaelli Thank you for your query . We will investigate and update the thread.

@chaelli Currently you cannot remove yourself from an organization where  your account has been locked out.
You can raise a uservoice feedback request for this behavior. Our PG keeps checking these in regular intervals and ideas with high votes has more chances of going through implementation.
Let me know if you have any questions.

seems more like a but than a feature.. but I created a uservoice entry anyway: https://feedback.azure.com/forums/34192--general-feedback/suggestions/40885105-allow-leaving-an-organization-where-the-account-is

@chaelli Thanks for creating a user voice and sharing us the link. We will close this now.


README

README
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

I did not complete this README fully and did not deploy my webpage. Unfinished repo.


Loading SVGs when needed

I don't think that loading a lot of SVGs is a good idea. Firefox is currently using 3Gb of RAM for this page only, that's ridiculous.

@treisska Over a year late, but it only takes 200mb on Chrome / Chromium on Linux with 6GB RAM

Now uses the iconfont, so this is fixed.


Markdown custom styles can't handle quotes in e.g. font property

Describe the Bug
This will spit out literal quotes into the HTML, thereby ending the style attribute and producing invalid HTML and broken styles:
<Markdown markdownCustomStyles={{ h1: { font: "700 23px / 32px \"Roobert PRO\", system-ui, sans-serif" }}}># Hello</Markdown>
Producing

Which package is affected (leave empty if unsure)
@react-email/components
Link to the code that reproduces this issue
See above
To Reproduce
See above
Expected Behavior
Quotes should be escaped/replaced.
What's your node version? (if relevant)
No response

Identify the affected package version and update it to the latest version, as this issue may have been addressed in newer releases.

If updating the package doesn't resolve the issue, consider the following workaround:

Manually escape quotes:Escape the quotes inside the font property to ensure they are not treated as literal quotes in the HTML.

 <Markdown markdownCustomStyles={{ h1: { font: "700 23px / 32px "Roobert PRO", system-ui, sans-serif" }}}># Hello</Markdown>

Alternative syntax:Use single quotes for the font property to avoid conflicts with double quotes in the HTML.
 <Markdown markdownCustomStyles={{ h1: { font: '700 23px / 32px "Roobert PRO", system-ui, sans-serif' }}}># Hello</Markdown>

Reopening until we get the fix released at least on canary.

Fix released under<EMAIL_ADDRESS>or<EMAIL_ADDRESS>


Security & !RESTfulness

This branch focuses on making certain resources "owner protected", while also touching on nested vs non-nested resources.

What remains in this PR is mainly refactoring use of zod to be similar to this:
https://github.com/G0maa/my-school-server/blob/7fb0cc4694a124f06baeca20c53fd000ff870b98/src/controllers/teacher.ts#L32-L51


Fix OpenConext deploy template

This issue is imported from pivotal - Originaly created at May 20, 2019 by Bart Geesink
The OpenConext deploy template secrets file contains specific oidc secrets (the key signing material). All other secrets are generated using a script when the an install from template is run, but not these specific secrets. The script should be changed to generate the oidc specific secrets as well.

@bartgeesink the key rollover is implemented. The remaining secret is for symmetric encryption / decryption of the signing keys and user-info in the access token claim. The remaining private / public key is for SAML signing. The first one we can generate on the fly if not present in the database. The public SAML certificate needs to be stored in Manage, but could be easily generated in the script when an install is run from the template. (Okke Harsta - May 26, 2019)


v2 alpha.9 release

Codecov Report

Merging #346 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #346   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines         423    423
  Branches      133    133
=====================================
  Hits          423    423

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5975c...03557b7. Read the comment docs.


StaticRoute.sendfile incorrectly uses add_writer/remove_writer

See https://github.com/python/asyncio/issues/372 for more details.
It seems that on modern OSes, aiohttp's implementation of sendfile always hits a fast path, i.e. first call to os.sendfile succeeds. On Mac OS 10.10, though, it sometimes does not, so the code calls add_writer on the underlying transport's socket.
This is a wrong thing to do, as the status of the writer callback (and the active callback itself) is the private state of the transport. It also seems that StaticRoute.sendfile may not work at all when add_writer is used.
I suggest to duplicate the socket that get_extra_info returns before adding/removing readers/writers.

Alright, so in the next asyncio release, using add_reader/add_writer on a socket that transport.get_extra_info('socket') returns will be an error. I'll also fix uvloop to do that too. This issue has to be fixed asap.

Alright, so in the next asyncio release, using add_reader/add_writer on a socket that transport.get_extra_info('socket') returns will be an error.

@1st1 could you point on source code change for the fix? I miss it.

Aaah, it's not implemented still.


a question

if i have 10000more rows in  DATA ,
change the number in vba  still can'r work ,
have u alternative way to solution ?

I don't know why I didn't see this issue earlier. I'm sorry!
Unfortunately I do not have another solution. My guess is that to handle something like that, you'd be best finding an Excel extension that can handle bulk data or perhaps export the data as a CSV file and then use another tool to convert it to JSON. Also, I think Excel might have a built in tool for exporting JSON, but I'm not sure it's immediately clear how it's best used.


[ocaml] Support for OCaml 4.10

Ok @gasche , I've refined the compatibility support; can you confirm the 4.10 stubs are correct?


Unable to set temperature using lovelace or scheduler component

I have been using the Dual Smart Thermostat since a few months ago and I really love it. Recently I noticed something changed but I haven't been able to figure out what the problem is.
I have been using the custom scheduler component to set different temperatures at different times. It was working fine, but now I am not able to set temperature, only to choose the mode. I am not sure if it is a problem of the Dual Smart Thermostat component or the scheduler component to be honest, or even if it was a change on Home Assistant which made start showing this behaviour.
However, I also have found that if I don't set target_temp_low or target_temp_high in the config, I cannot make any changes on the temperatures later on using lovelace.
I tried installing previous versions of this component and the scheduler component as well, but the issue still remained, so I'm guessing that there may be a change within Home Assistant that now changed the behaviour of one of these components.

Ther have been a few release. If you still using the component, could you check if it's still an issue for you?


Zetta-to-Zetta Protocol Changes

Note: These changes are not backwards-compatible.  All previous versions will need to be upgraded.

Remove zetta-forwarded-server header:  This information can be parsed out of the request URL.
Remove zetta-message-id header: This information can be obtained by passing around response references.
Change X-Event-Encoding header to Content-Type: Instead of using json and buffer as the values, favor application/json and application/octet-stream.
Change Host header from fog.argo.cx to {{server-id}}.unreachable.zettajs.io.

+1

:+1:


Add role_arn keyword argument to Session()

Currently Session() can be instantiated with a manual profile argument, which forces the use of a profile in your local config, and can be used to get boto to assume a role for you.
This PR takes this one step further and adds a role_arn argument which can be used the same way, but does not require config files to exist on the machine.
If role_arn is provided, a session will be attempted to be created by assuming role_arn from the otherwise default credentials (env vars, config, instance role, etc).
This was done by modifying the AssumeRoleProvider.
Questions:

is this an acceptable feature to add? It would eliminate the need to call sts.assume_role and manually instantiate a session in any usage of botocore that I've ever come across.
Is this an OK way to go about it? AssumeRoleProvider isn't named like it should be restricted to only assuming roles from profiles, but this does add a few different paths through it. It also has had to be extended a little as it was written with the assumption that it would never have to guess an appropriate credential source.

if the above two questions are fine, then see my github comments in the code itself for more specific questions.
Still to do:

[ ] integration tests
[ ] functional tests
[ ] more unit tests to get coverage up (or to ensure quality code, or something I guess :) )
[ ] docs
[ ] allow for role_session_name as well

I just want to wait on some indication that this is acceptable before I undertake these.
As is, botocore with this pr can be used by:
   # default session
    botocore.session.Session()

    # assume a role with the credentials inferred as with the default session:
    botocore.session.Session(role_arn='arn:aws:iam::00000000:role/test-role'),

    # assume a role on top of a manually selected profile (I expect this is a corner case)
    botocore.session.Session(profile='some-profile', role_arn='arn:aws:iam::00000000:role/test-role')

still happy to work on this if I was to get even a hint of interest from a maintainer.


Patch - corrupted image file proof

when a corrupted image file is uploaded onto the server, it sometimes bypasses the validation (e.g. by a customised form, or extended file uploader), and get stored into the asset directory, becomes an image object. Then, when SilverStripe tries to use this corrupted image, it breaks and displays below error message:

[Error] Uncaught ImagickException: corrupt image `[PATH]/Screenshot-2017-02-21-at-18.53.31-AM.png' @ error/png.c/ReadPNGImage/3728 [PATH]/framework/filesystem/ImagickBackend.php:25

To resolve this issue, my patch does below steps:

Recovery - the precondition is: the corrupted images are already in your assets and DB. when a corrupted image is being handled by SS image backend, SS will catch the error,  wipe the file's existence from both DB and the file system, and then reload the page silently - so the frontend users won't even notice.

Prevention - when the user uploads an image file, Silverstripe will check if the file can be handled by the image backend. This is a proactive approach to trigger the error - the corrupted file will be stopped at the validation, and nothing harmful will be brought into SS's assets and DB.

Sure, will do the improvement. Thanks for your suggestions.
Cheers
Leo
On Thu, Feb 23, 2017 at 4:31 PM, Damian Mooyman<EMAIL_ADDRESS>wrote:

@tractorcow requested changes on this pull request.
In filesystem/ImagickBackend.php
https://github.com/silverstripe/silverstripe-framework/pull/6646#discussion_r102632776
:

@@ -22,7 +22,25 @@ class ImagickBackend extends Imagick implements Image_Backend {
*/
public function __construct($filename = null) {
if(is_string($filename)) {

	parent::__construct($filename);

	try {

		parent::__construct($filename);

	} catch (Exception $e) {

		if (file_exists($filename)) {

			unlink($filename);

		}

		$filename = str_replace(Director::baseFolder() . '/', '', $filename);

Removing the image record is risky; It could damage data records.
Also, making image resizing responsible for routing is extremely outside
of the scope of this class. we should probably be catching errors at a much
higher level.
In filesystem/Upload.php
https://github.com/silverstripe/silverstripe-framework/pull/6646#discussion_r102633035
:

@@ -131,7 +131,26 @@ public function load($tmpFile, $folderPath = false) {
$this->errors[] = _t('File.NOFILESIZE', 'File size is zero bytes.');
return false;
}

if (!empty($tmpFile['type'])) {

       $type = $tmpFile['type'];

       if (strpos($type, 'image/') !== false) {

           $tmp_name = $tmpFile['tmp_name'];

           try {

               $test = new ImagickBackend($tmp_name);

           } catch (Exception $e) {

			SS_Log::log($e, SS_Log::ERR);

               if ($controller = Controller::curr()) {

                   if ($controller->request->isAjax()){

                       return $controller->httpError(500, 'Image corrupted');

load() should not be responsible for prompting a routing redirect. This
should be caught at the validation level, and have this bubble up to the
user via a field error, rather than redirecting the user. That way the user
doesn't have a redirect reset their unsaved form.
Do you want to try moving this to the validator class?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/silverstripe/silverstripe-framework/pull/6646#pullrequestreview-23392623,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIQsHLwBSKXdWLrtRvkA_VFmsqdBlz5pks5rfP2YgaJpZM4MJflk
.

--
Leo Chen
Senior Developer
E<EMAIL_ADDRESS>M:<PHONE_NUMBER>8

We already have a hasImageResouce() method which Image::generateFormattedImage() will check, currently it’s hard-coded to return true - could instead we change that behaviour to return false if the image is corrupted? It’s a much less intrusive change for a patch release

Thanks for pointing this out - I didn't think that carefully! I will make
changes to check imagebackend beforehand
Cheers
Leo
On Thu, Feb 23, 2017 at 10:32 PM, Loz Calver<EMAIL_ADDRESS>wrote:

@kinglozzer requested changes on this pull request.
In filesystem/Upload.php
https://github.com/silverstripe/silverstripe-framework/pull/6646#discussion_r102671923
:

@@ -131,7 +131,26 @@ public function load($tmpFile, $folderPath = false) {
$this->errors[] = _t('File.NOFILESIZE', 'File size is zero bytes.');
return false;
}

if (!empty($tmpFile['type'])) {

       $type = $tmpFile['type'];

       if (strpos($type, 'image/') !== false) {

           $tmp_name = $tmpFile['tmp_name'];

           try {

               $test = new ImagickBackend($tmp_name);

What if I use GD and don’t have Imagick installed? Won’t this remove all
of my images?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/silverstripe/silverstripe-framework/pull/6646#pullrequestreview-23431973,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIQsHJcj1iKpsISW4IW-VSOVICenN4sBks5rfVJKgaJpZM4MJflk
.

--
Leo Chen
Senior Developer
E<EMAIL_ADDRESS>M:<PHONE_NUMBER>8


Adding ability to highlight YAML

Wanted to add the ability to support YAML.
I did this by:

Added YAML as an option in the menubar in index.html
I  updated highlight.pack.js by getting a  version of the file that included YAML support  from highlight.js's website(https://highlightjs.org/download/).

Look really good! I'll submit it to the Mac App Store and keep you posted ;)
Thanks a lot!

Sweet! Thank you so  much!

Submitted to the App Store! Waiting for review...

It's in review...........

Live! Thanks again!


SF: Pretranslating for reviewing existing translations

This would be used for creating a pretranslation as a review aid for an existing draft already in the target project.
Note, that for Serval, if there is any text in the target for the specific segment (verse), it will not create a pretranslation.  The target verses would need to be cleared out of the incoming texts before it got into Serval.
Would there be a checkbox to say "draft everything vs. draft only stuff that has not already been drafted"?

See https://jira.sil.org/browse/SF-2634


Require new swift-nio versions

New NIO versions enforce Sendability. We want to always pick those up. Also this fixes another import warning.

Codecov Report

Merging #343 (419ff1a) into main (18a60ef) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   41.27%   41.27%
=======================================
  Files         115      115
  Lines        9572     9572
=======================================
  Hits         3951     3951
  Misses       5621     5621

Impacted Files
Coverage Δ

...es/PostgresNIO/New/Data/UUID+PostgresCodable.swift
96.96% <ø> (ø)

Sources/PostgresNIO/New/PostgresCodable.swift
93.87% <ø> (ø)


docs: add plugin comparison table

I put n/a for cells that are dependent on another cell being true that was not; could change this to :x: if desired

I think just :x: instead of n/a is fine
For some things where dink has a checkmark, it's not necessarily just "click enable & it works", it would be interesting to have links to documentation as part of the :heavy_check_mark: . not necessary as part of this PR

Should we abbreviate the column names?


Add SSL CA bundle option

Letsencrypt serts give me errors on firefox. ERR_CERT_AUTHORITY_INVALID , to fix it, it needs a CA bundle file. Currently, lounge does not accept this, so i made one.

Changed as requested, can test it on nightime.

For my case, its working.

Changed, I could change other ssl file paths too, so they use same style.

Squash the commits and then 👍

Also @metsjeesus, mind rebasing with master to fix the conflicts on src/server.js?

Thanks!

Hey @metsjeesus, we have sticker packs for our contributors now!
If you're interested, go fill the form at https://goo.gl/forms/f5usqAEp5DWoeXC92 🙂


Python authentication example doesn't work

The code in your example doesn't work:
swagger_client.configuration.access_token = 'YOUR_ACCESS_TOKEN'
api_instance = swagger_client.AthletesApi()

I kept getting auth errors saying the token was invalid.
To get it to work I had to do the following:
config = strava_api_v3.Configuration()
config.access_token = 'YOUR_ACCESS_TOKEN'
api_client = strava_api_v3.ApiClient(config)
api_instance = strava_api_v3.AthletesApi(api_client)
athlete = api_instance.get_logged_in_athlete()

Hi @sshevlyagin, please feel free to submit a pull request with your workaround for review.
Apologies for not spotting this issue sooner, we're trying to move away from github issues.  In light of that, please email<EMAIL_ADDRESS>if you have further comments or questions!


[cherry-pick][release-2.38.0][BEAM-14172] Update tox.ini for pydocs (#17176)

(cherry picked from commit 0c93be1098290fc79de832f1333dbe7bd56972a9)
Missed this cherry-pick earlier and I need it for RC creation, so I might merge this in before it gets approved and hope for a retroactive approval, just in order to unblock myself. It's a very small change anyway.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @TheNeuralBit @aaltay

Run Python_PVR_Flink PreCommit

Again, merging this without approval to unblock, will need to get some retroactive approval.


python3Packages.simplisafe-python: 11.0.5 -> 11.0.6

Motivation for this change
Update to latest upstream release 11.0.6
Change log: https://github.com/bachya/simplisafe-python/releases/tag/11.0.6
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 136759 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.simplisafe-python
python39Packages.simplisafe-python


Release candidate information multi unit type

I would wait until PR#100 is done

its not compatible, with release-candidate, I get incorrect coupon values


How to refresh symlinks mounted to a docker data volume?

I'm running a docker data volume as per the method documented at https://docs.docker.com/userguide/dockervolumes/#creating-and-mounting-a-data-volume-container
One of the volumes I'm mounting is a symlinked folder linking to the latest version of a codebase. Currently I destroy the container and run it again to refresh the mounted folder but is there a more graceful method to deal with this?
So I have the following directory structure:
drwxr-xr-x release_2015-04-08-145116_HEAD/
drwxr-xr-x release_2015-04-08-145223_HEAD/
drwxr-xr-x release_2015-05-20-160620_HEAD/
lrwxrwxrwx  live -> /var/www/mysite/release_2015-05-20-160620_HEAD/

And the docker data volume runs with docker run --name mydata -t -v /var/www/live:/data/www mydata
Destroying the container has the downside of losing the non external data of course.
Another method I suppose would be to mount a level above the symlink although then really I'm exposing more to the data container than I really need to and it seems sloppy.
Thanks for any ideas.

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

This won't work because docker is resolving this symlink when it mounts it in.

OK, so my only choice is to mount the parent?
Alternatively would it be possible to image/run the original data container so that the --volume switch can be reapplied but the internally stored changes are maintained?

Hmm, this might work.

Glad to hear you're confident :D, I'll give it a whirl then, thanks!

I'm going to close this issue, because this is more of a "question" than a bug in Docker, but feel free to continue the discussion.

I am experiencing similar issue using data volume container and symlinks but not sure if @carn1x's workaround would work for me...
It seems to me that Docker de-references symlinks pointing to data volume container at second run.
Goal: I wanted to set up an application container and store the applications' data in a data volume container.
Installation of softwares is done in Dockerfile, and I have a small script (init.sh) that moves configurations files and data folders to specific locations (eg. /conf, /data) and place strategic symbolic links in the application container.
I find it cleaner to let the softwares uses their default config/storage locations, move it where I want it to (id. /conf, /data) and put symlink in-place.
The data volume container have the volume /data, so when I run application container with the data volume container using --volumes-from for the first time, the data volume container should be empty.
My init.sh script will move some stuff into it and create the symlinks.
At second run, symlinks in application container should still be there and data volume container should contain the data produced by the application.
The issue is that content of /data (path to my volume) seems to be copied to the application container, overwriting the symbolic link /opt/app1/storage.
Steps to Reproduce:
Here is "context creation" code (this will create Dockerfile, the run.sh docker container start point and the demo.sh that builds and highlights the issue) :
#!/bin/bash

# Create files
cat >> Dockerfile <<EOT
FROM debian:jessie

RUN apt-get update && apt-get install tree

RUN mkdir -p /opt/app1/conf
RUN echo "foo" > /opt/app1/conf/main.cfg
RUN mkdir -p /opt/app1/storage
RUN echo "bar" > /opt/app1/storage/datafile-bar
RUN mkdir -p /opt/app2

RUN mkdir -p /conf
# Will also be done from run.sh for when data-volume container is used
RUN mkdir -p /datas/app1

COPY run.sh /run.sh
RUN chmod u+x /run.sh
EOT

cat >> run.sh <<EOT
#!/bin/bash

mkdir --parents /datas/app1

if [ ! -e "/conf/main.cfg" ] ; then
    echo "Symlink to \"/conf/main.cfg\": CREATING..."
    mv --no-target-directory /opt/app1/conf/main.cfg /conf/main.cfg
    ln --symbolic --no-target-directory /conf/main.cfg /opt/app1/conf/main.cfg
else
    echo "Symlink to \"/datas/app1/storage\": OK"
fi

if [ ! -e "/datas/app1/storage" ] ; then
    echo "Symlink to \"/datas/app1/storage\": CREATING..."

Symlink to "/datas/app1/storage": CREATING...
/conf
`-- [-rw-r--r--           4]  main.cfg
/opt
|-- [drwxr-xr-x        4096]  app1/
|   |-- [drwxr-xr-x        4096]  conf/
|   |   `-- [lrwxrwxrwx          14]  main.cfg -> /conf/main.cfg
|   `-- [lrwxrwxrwx          19]  storage -> /datas/app1/storage/
`-- [drwxr-xr-x        4096]  app2/
/datas
`-- [drwxr-xr-x        4096]  app1/
    `-- [drwxr-xr-x        4096]  storage/
        |-- [-rw-r--r--           4]  datafile-bar
        `-- [-rw-r--r--           4]  datafile-baz

6 directories, 4 files
Without data-container (2nd time):
Symlink to "/conf/main.cfg": CREATING...
Symlink to "/datas/app1/storage": CREATING...
/conf
`-- [-rw-r--r--           4]  main.cfg
/opt
|-- [drwxr-xr-x        4096]  app1/
|   |-- [drwxr-xr-x        4096]  conf/
|   |   `-- [lrwxrwxrwx          14]  main.cfg -> /conf/main.cfg
|   `-- [lrwxrwxrwx          19]  storage -> /datas/app1/storage/
`-- [drwxr-xr-x        4096]  app2/
/datas
`-- [drwxr-xr-x        4096]  app1/
    `-- [drwxr-xr-x        4096]  storage/
        |-- [-rw-r--r--           4]  datafile-bar
        `-- [-rw-r--r--           4]  datafile-baz

6 directories, 4 files

With data-container (1st time):
Symlink to "/conf/main.cfg": CREATING...
Symlink to "/datas/app1/storage": CREATING...
/conf
`-- [-rw-r--r--           4]  main.cfg
/opt
|-- [drwxr-xr-x        4096]  app1/
|   |-- [drwxr-xr-x        4096]  conf/
|   |   `-- [lrwxrwxrwx          14]  main.cfg -> /conf/main.cfg
|   `-- [lrwxrwxrwx          19]  storage -> /datas/app1/storage/
`-- [drwxr-xr-x        4096]  app2/
/datas
`-- [drwxr-xr-x        4096]  app1/
    `-- [drwxr-xr-x        4096]  storage/
        |-- [-rw-r--r--           4]  datafile-bar
        `-- [-rw-r--r--           4]  datafile-baz

6 directories, 4 files
With data-container (2nd time):
Symlink to "/conf/main.cfg": CREATING...
Symlink to "/datas/app1/storage": OK
/conf
`-- [-rw-r--r--           4]  main.cfg
/opt
|-- [drwxr-xr-x        4096]  app1/
|   |-- [drwxr-xr-x        4096]  conf/
|   |   `-- [lrwxrwxrwx          14]  main.cfg -> /conf/main.cfg
|   `-- [drwxr-xr-x        4096]  storage/
|       |-- [-rw-r--r--           4]  datafile-bar
|       `-- [-rw-r--r--           4]  datafile-baz
`-- [drwxr-xr-x        4096]  app2/
/datas
`-- [drwxr-xr-x        4096]  app1/
    `-- [drwxr-xr-x        4096]  storage/
        |-- [-rw-r--r--           4]  datafile-bar
        `-- [-rw-r--r--           4]  datafile-baz

6 directories, 6 files

Output analysis:

The two first trees (no data volume container used) seems about right :
I have a symlink from /opt/app1/conf/main.cfg to /conf/main.cfg and another one from /opt/app1/storage/ to /datas/app1/storage/
The third one (with data volume container) is also OK.
But the fourth one (second run on the same data volume container) is missing the /opt/app1/storage/ symlink (the /opt/app1/conf/main.cfg is present).

I am clearly missing something here that makes Docker, at second run, overwrite the symlink and/or copy files from data volume container /datas/app1/storage to application container?
docker version:
Client version: 1.7.1
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 786b29d
OS/Arch (client): linux/amd64
Server version: 1.7.1
Server API version: 1.19
Go version (server): go1.4.2
Git commit (server): 786b29d
OS/Arch (server): linux/amd64

docker info:
Containers: 153
Images: 1514
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 1820
 Dirperm1 Supported: false
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.13.0-57-generic
Operating System: Ubuntu 14.04.3 LTS
CPUs: 4
Total Memory: 15.54 GiB
Name: mybox
ID: 2OQQ:3X7V:BE2M:WPL5:WLWX:DRFF:X3G6:4MIJ:MY3N:FCUF:NSYF:YLSO
WARNING: No swap limit support

uname -a:
Linux mybox 3.13.0-57-generic #95-Ubuntu SMP Fri Jun 19 09:28:15 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

@carn1x, can you expand on your workaround? I am trying to solve the same problem, but I do not understand how you achieved this:

Alternatively would it be possible to image/run the original data container so that the --volume switch can be reapplied but the internally stored changes are maintained?

@hcpss-banderson I did not achieve it, sorry to say. I ended up maintaining live/ as a mounted folder and then rsync changes on-top of it.

Hello,
I am trying to achieve the same.
@carn1x did you mean that you tried to mount the parent and both changing the symlink on the host or in the container failed?
So the only solution to this problem is to mount the live/ and on each code update, remove live folder content and update with the new one (with rsync or other commands)? With the inconvenient that the update is not atomic and introduces a downtime.


NO MERGE: Open browser tab from command

Description
This is just a spike on opening a browser tab in response to command defined in the app model executing. The biggest issue with this so far is that opening the tab is blocked by the popup blocker (for good reason).
To solve this problem, I think we are going to want to define a kind of ResourceUrlCommandAnnotation or something like that which results in the tab being opened in response to the user initiated click in a browser.
Another issue this PR has which is specific to codespaces it that the URL we insert isn't Codespace forwarding URL aware. So we'll need to be able to inject the URL command annotations after endpoints have been allocated.
Fixes # (issue)
Checklist

Is this feature complete?

[ ] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[ ] Yes
[ ] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[ ] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[ ] No

Does the change require an update in our Aspire docs?

[ ] Yes

Is this introducing a breaking change?

[ ] Yes

Link to aspire-docs issue (please use this breaking-change template):

[ ] No

Link to aspire-docs issue (please use this doc-idea template):

[ ] No

Microsoft Reviewers: Open in CodeFlow

We could choose violence and just call Process.Start("http://theurl.com"); in the command. That launches a new browser with the URL.
(I think doing it in the browser is probably better, even if it requires showing a dialog with the link)


feat: add full report

fixes https://github.com/codecov/uploader/issues/123

@drazisil-codecov tests added, but it's giving me some trouble as it thinks the diff is huge


SFrame.read_json() treats boolean values as strings

It appears that SFrame.read_json() really just is a thin wrapper around SFrame.read_csv() with some parsing logic which cannot handle all cases. In particular, it does not parse boolean values in JSON correctly and instead treats them as strings. E.g.,
In [1]: cat test.jl
{"a": true}
{"a": false}
{"a": null}
{"a": false}
In [2]: import turicreate
In [3]: turicreate.SFrame.read_json('test.jl', orient='lines')
Out[3]:
Columns:
	a	str
Rows: 4
Data:
+-------+
|   a   |
+-------+
|  true |
| false |
|  null |
| false |
+-------+
[4 rows x 1 columns]

It's the same for records orientation:
In [4]: cat test.json
[{"a": true},
{"a": false},
{"a": null},
{"a": false}]
In [5]: turicreate.SFrame.read_json('test.json', orient='records')
Out[5]:
Columns:
	a	str
Rows: 4
Data:
+-------+
|   a   |
+-------+
|  true |
| false |
|  null |
| false |
+-------+
[4 rows x 1 columns]

Expected result is this:
In [6]: turicreate.SFrame({'a': [True, False, None, False]})
Out[6]:
Columns:
	a	int
Rows: 4
Data:
+------+
|  a   |
+------+
|  1   |
|  0   |
| None |
|  0   |
+------+
[4 rows x 1 columns]

Tested on Turicreate v5.1, Python v3.6.6, macOS v10.14.2

I think one easy way to treat JSON Lines files correctly is this:
import json, turicreate
turicreate.SFrame.read_csv('test.jl', header=False, column_type_hints=str)['X1'] \
    .apply(json.loads) \
    .unpack(column_name_prefix=None)

Thanks for the issue @MarkusShepherd.
Turi Create doesn't even have a boolean column type. So that's probably the more fundamental issue here. Boolean column types is a feature I've wanted for a very long time.

@znation - I agree, in the absence of having a boolean type, "true"/"false" JSON values should be parsed as 0/1. Looks like we're already tracking the boolean feature request in #1069. So let's limit this issue to correctly parsing "true"/"false" JSON values.

Since bool is a subclass of int in Python, I'd say the lack of explicit boolean columns in TC might not be so bad, unless there is some performance to be gained.
Also, I've realised SArray reads in files line by line, so my above workaround can be shortened:
import json, turicreate
turicreate.SArray('test.jl') \
    .apply(json.loads) \
    .unpack(column_name_prefix=None)

I have added some parser features in #1266 that should help fix this.


Website/Content Strategy Development

Problem statement
As users increasingly rely on the site for their work with ReportStream, we need a comprehensive strategy that will guide content and design work on needed updates and new additions. With an eye on the goals of ReportStream being pandemic-ready, user-centered, and eventually owned by the CDC, this strategy will also support scalable, sustainable, transferable, and user-centered content throughout the RS experience
Approach

My approach prioritizes stakeholder involvement for alignment, user knowledge, and ownership.
Work is planned around phases that answer the following questions: where are we, what are our users' needs, are we meeting them, and what needs to change to better meet them?
A robust discovery phase leads to more effective and efficient planning and execution.
It will take a holistic view of the web experience, rather than narrowing in on one user or feature.
This approach takes a content-first design mindset in focusing on implications of these questions on content that will set a foundation for further design work.
It will stay agile with the goal of moving quickly while not sacrificing being thorough and being flexible about how we are answering those primary questions.
Activities current planned and the desired outcomes are details more thoroughly in the Mural linked below.

Assumptions

We have access to SMEs and stakeholders for their feedback and engagement throughout the process.
This work is a priority feeding into the goal of being user-centered.
These activities will gradually influence smaller pieces of work that will happen concurrently throughout the quarter.
An implementation plan will be able to be completed for application next quarter.

Out of scope

More than one or two hours of research engagement with external users
Content considerations outside of what is on/will be on the website (e.g. emails)
Specific visual design decisions

Dependencies & risks

Engagement availability from necessary stakeholders

Open questions

CDC stakeholders/future owners to involve in the process for foundation of future ownership

What you need to know

Mural of general work roadmap/misc notes
#7999 feeds into this work
...

Definition of done/Acceptance criteria

[ ] Work is planned around answering the questions:

Where are we?

What are our users' needs?

Are we meeting them?

What needs to change to better meet them?

[ ] Artifacts reflecting the findings have been created and shared with the wider team

[ ] Action plan created based on answers to the above questions.

To do

[ ] ...

@lizzieamanning @chris-kuryak I'll begin adding tickets to this for this sprint.

@audreykwr Curious if you'd find value in adding any of the categories below:

Approach
Assumptions
Out of scope
Dependencies & risks
Open questions
Links and resources
Definition of done

I think some may be covered:

I think I have links that are relevant at the moment in there, but I'll try to add as more documentation is created along the way.
The broad definition of done seems like the ACs to me, but maybe those are too vague?
Would approach be adding some more details to planned activities? Or let me know more about what you're thinking for that one.
Assumptions, scope, dependencies are good to think about, so I can add those when I can as a start

@audreykwr I like it!
I see you two are discussing perhaps a bigger question of "what info is required to be in an epic." Happy take that to a verbal forum for quicker disposition if easier, as we as a team have not defined hard guardrails yet.
We will keep this epic in the "New" column until you have finished putting all of the necessary issues into it.
Regarding Lizzie's comments above, I agree with those bullets and also feel like Acceptance Criteria should be a definition of "done". However, I would also say that the epic may not need Acceptance Criteria as the issues should have all of the AC's to describe "done". So happy to chat this out with y'all at your convenience.

@lizzieamanning @chris-kuryak added some things. Let me know what you think or what could be added/clarified.

Looks good to me @audreykwr !
The details (above the basics) of what Design wants to include is up to y'all.
Also, it appears that the Synthesis ticket could still use some work.

All issues complete.


[usbdev,env] DV env changes to avoid csr_test failures

This draft pull request introduces changes to the ubsdev environment to facilitate the CSR tests failures, specifically the csr_bit_bash and mem_walk.
Changes include:
Addition of the driver_enable task in usb20_block_if to manage the driver by enabling and disabling it. The driver is now set to a disabled state by default, ensuring it remains inactive when not required, such as during CSR tests. To activate the driver when necessary, the driver_enable function can be called in a specific sequence, within the pre_task method, enabling the driver for USB transactions.

@rswarbrick please review this draft PR

Looking at the failing CI, it is reporting a problem with this PR. Specifically, the DV smoke test is failing on usbdev items. Specifically, usbdev_csr_hw_reset and usbdev_csr_rw both fail.

Looking at the failing CI, it is reporting a problem with this PR. Specifically, the DV smoke test is failing on usbdev items. Specifically, usbdev_csr_hw_reset and usbdev_csr_rw both fail.

I have tested both are passing on my end.

Hmm, I've just read this more carefully and thought about #22199, which does something similar. I think we'll probably merge that change (in some form). Since you're touching roughly the same lines, would it make sense to rebase this change over that one?

Hmm, I've just read this more carefully and thought about #22199, which does something similar. I think we'll probably merge that change (in some form). Since you're touching roughly the same lines, would it make sense to rebase this change over that one?

Yes, Its similar to #22199 and you can merge that first and i will do these left changes after that one is merged.  Thanks


chore: add Apache 2.0 license

I'm in doubt about this line:
      Copyright 2019-2023 Cartesi Pte. Ltd.

Don't include the copyright notice yet.

The package.json files also have license we need to change


Only format on save if prettier is in the dependencies

I have projects that use prettier and adhere to the style standard, but I also have projects that neither use prettier nor adhere to the style. (they enforce some other styleguide with eslint)
It'd be great if the "Format on save" option only took effect in projects that have prettier in their package.json or something like that!

I was thinking in https://github.com/jlongster/prettier-atom/issues/41 that it might be good to do a blacklist glob, that might be better because that would cover cases where people still want to use prettier for their files even though the project might not have it listed in the dependencies.

it might be good to do a blacklist glob

That seems very manual. I create new projects almost everyday, and updating a custom glob every time based on "do I want to use prettier or not" seems pretty tedious. I'm not sure I'd even enable that option just based on the fact that I'll probably forget about it.

Why not both?
I think this could be fixed by a Use global installation setting, like in the linter-eslint package.
And the blacklist could solve prettier#787 for example

I'm with @mxstbr here. I came here to raise this issue. Glad to see I'm not the only one facing this. I personally do not create a new repo every day, but I'm even just thinking organizationally as I try to introduce prettier to my company, asking every person in the company to set up their blacklist creates friction points to adoption.

Sorry if I've been unclear on this, we are definitely going to get this addressed. Right now the plan is we are going to look for prettier/prettier-eslint (depending on your eslint integration setting), and if we don't find it, we will have an option in the settings where you can specify if you want us to fall back to the included packaged version or just not do anything. https://github.com/jlongster/prettier-atom/issues/59#issuecomment-287848381


Fix check for python-config. Refs #647

Fixes fa1b098cc4c29f8e8d6fe2a8089d58e3ecde6c81.

OK I have a funny feeling there will be other renamed executables but if this works I'm fine with that :smile:.


Improve ServerName rule

What's changed?

Updated ServerName recipe to consider additional methods
What's your motivation?

The migration rule for this recipe flags other cases which this recipe was not considering.
Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek
@rlsanders4
Have you considered any alternatives or workarounds?

Any additional context

Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've read and applied the recipe conventions and best practices
[x] I've used the IntelliJ IDEA auto-formatter on affected files

Thanks for the fixes here folks! Catching up after a few days away; great to see you're cross reviewing and merging. I've pushed up a quick polish as suggested by the bot above:

https://github.com/openrewrite/rewrite-liberty/pull/25

Thanks Tim


Define Catalog Manager improvements & next steps

Relates to: https://github.com/newrelic/nr1-catalog-manager/issues/6
General Observation of the Can't-alog Manager flow
The current process requires a lot of toil. Pulling down the nerdpack, manually testing it, using the nr1-catalog-manager, merging into the nr1-catalog, and then notifying platform services. Breakages at any point require creating a new release of the nerdpack and starting at the beginning.
Quick improvements could be made to test and validate the nerdpack before creating a release, removing the need to do this before adding it to the nr1-catalog. This should also verify that the catalog requirements are met, such as screenshot aspect ratio and size.
After the improvements above, the nr1-catalog-manager could be phased out in favor of the nerdpack itself controlling releases to the nr1-catalog repository.
Another option is to remove the nr1-catalog and the nr1-catalog-manager, allowing each nerdpack to handle its own release process.
Publishing Pain
If the nr1-catalog must stick around to manage the current prod versions of the nerdpacks, then moving it away from git submodules and over to a semantic version based system (think package.json dependencies) will reduce a lot of headaches. Notably avoiding issues around merging a new PR before an older one.
nr1 nerdpack:publish pushes to artifactory, which is 1 global instance for all envs. Enabling it in US is the default behavior. Staging/EU require manual effort to do the same.
Given there's no API built to push apps to EU and Staging so Platform Services has to manually update entries in some system/DB they have access to to push app updates on these environments.
Marking as global ain't easy
The other thing holding up self-service publishing, is marking an app as GLOBAL is done via an API that's only exposed behind CHI VPN So we can't automate that from public GitHub action.
Acceptance Criteria

[ ] meet with @jbeveland27 and talk through our findings to get his insights
[ ] decide on what approach we'll take and create new tickets for the work
[ ] prioritize that work in an upcoming sprint.

@aswanson-nr / @zstix I pulled this feedback out and will schedule a chat with @jbeveland27. This will go in Sprint 2.

added some more insights & observations  from @jbeveland27

Results of our conversation with Justin.
We propose the following workflow:

When an application is updating and versioned, we automatically run checks on that app on build and deployment to main.
If these checks pass, we kick off a PR to the NR1-Catalog repo to update the application's version in the US:Prod.
We then review the PR and merge it in, thus updating the app with the  catalog manager.
We no longer use the catalog manager to these updates, so we'll want to move this project to either experimental or archived it's currently set to community.

@jbeveland27 / @aswanson-nr  / @zstix what do you think of the above proposal?

Other considerations:
Request from nr1- platform-services

APIs to auto publish version updates to Staging  and EU environments as that's manual today.
Allow a easier way to change the subscription state of an application to GLOBAL as that is currently manual.


added user-agent header to prometheus remote write exporter

Description:
Added User-Agent header to Prometheus Remote Write Exporter's outgoing http request. This allows endpoints to identify whether an incoming metric has come from an OTel Collector instance.
Testing:
Unit tests added conforming with existing tests to check headers.
Documentation:
No documentation has been added as it is for internal usage rather than customer usage.
-- cc @alolita

the upstream pr got merged


Not able to get the node having attribute as numeric name

Please describe the bug
I am parsing a file Xml file as below
<tag1 <IP_ADDRESS>>
  <tag2 *>
      bounce-after 4h
  </tag2>
</tag1>

My requirment is, i have  these lot of files containing above tags and i get very frequent request to add the tag and the following text for a matching tag1 and ip combo. I am trying to write a script to do that. But while searching the nodes using xpath, i am not able to get the node as it has the ip as attribute. Have tried lot of things but couldnt able to find any work around. Please let me know if i am missing somthing

Help us reproduce what you're seeing
Here is my code

file = 'abc.xml'
f = File.open(file)
node = Nokogiri::XML(f)
f.close
puts node.xpath('tag1 <IP_ADDRESS>')

Expected behavior
It should return the children nodes.

Hi, @dsinghsf, thanks for asking this question.
Unfortunately, the markup you've provided is not valid! Let's take a look at how it gets parsed by libxml2:
#! /usr/bin/env ruby

require "nokogiri"

xml = <<~XML
  <tag1 <IP_ADDRESS>>
    <tag2 *>
        bounce-after 4h
    </tag2>
  </tag1>
XML

doc = Nokogiri::XML(xml)
doc.to_xml # => "<?xml version=\"1.0\"?>\n<tag1/>\n"

If we look at the errors on the document, we can see what's happening:
doc.errors
# => [#<Nokogiri::XML::SyntaxError: 1:7: FATAL: error parsing attribute name>,
#     #<Nokogiri::XML::SyntaxError: 1:7: FATAL: attributes construct error>,
#     #<Nokogiri::XML::SyntaxError: 1:7: FATAL: Couldn't find end of Start Tag tag1 line 1>,
#     #<Nokogiri::XML::SyntaxError: 1:7: FATAL: Extra content at the end of the document>]

The problem here is that the "attribute" which is <IP_ADDRESS> or some other numeric IP address doesn't start with a valid NameStartChar.
Unfortunately, because this is not valid XML, you're going to have a hard time using any standard XML tools to parse and manipulate it.
An alternative might be to make this a proper attribute, something like ip=<IP_ADDRESS>:
#! /usr/bin/env ruby

require "nokogiri"

xml = <<~XML
  <tag1 ip="<IP_ADDRESS>">
    <tag2 ip="*">
        bounce-after 4h
    </tag2>
  </tag1>
XML

doc = Nokogiri::XML(xml)
doc.to_xml
# => "<?xml version=\"1.0\"?>\n" +
#    "<tag1 ip=\"<IP_ADDRESS>\">\n" +
#    "  <tag2 ip=\"*\">\n" +
#    "      bounce-after 4h\n" +
#    "  </tag2>\n" +
#    "</tag1>\n"

doc.errors
# => []

in which case you can use an xpath query like this:
<EMAIL_ADDRESS># => [#<Nokogiri::XML::Element:0xb4 name="tag1" attributes=[#<Nokogiri::XML::Attr:0x3c name="ip" value="<IP_ADDRESS>">] children=[#<Nokogiri::XML::Text:0x50 "\n  ">, #<Nokogiri::XML::Element:0x8c name="tag2" attributes=[#<Nokogiri::XML::Attr:0x64 name="ip" value="*">] children=[#<Nokogiri::XML::Text:0x78 "\n      bounce-after 4h\n  ">]>, #<Nokogiri::XML::Text:0xa0 "\n">]>]

Hope this helps?

Hi @flavorjones
Yeah, seems like that the issue. The thing is this is legacy design in our system to store the data in this format, will plan some major revamp for below

proper attribute, something like ip=<IP_ADDRESS>

Anyways, Thanks for help.. seems like i have to by old regex way for short term and plan for the permanent fix.


custom_components/multimatic/sensor.py:127 - AttributeError: 'NoneType' object has no attribute 'unit

Running HA DC 2021.6.2, python 3.8.9, multimatic integration custom component v1.7.0b
`Logger: homeassistant
Source: custom_components/multimatic/sensor.py:127
Integration: Multimatic (documentation, issues)
First occurred: 21 juni 2021 15:46:34 (1 occurrences)
Last logged: 21 juni 2021 15:46:34
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 134, in _handle_refresh_interval
await self._async_refresh(log_failures=True, scheduled=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 265, in _async_refresh
update_callback()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 325, in _handle_coordinator_update
self.async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 368, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 438, in _async_write_ha_state
device_class = self.device_class
File "/config/custom_components/multimatic/sensor.py", line 127, in device_class
return UNIT_TO_DEVICE_CLASS.get(self.report.unit, None)
AttributeError: 'NoneType' object has no attribute 'unit'
`

#56

Sorry for the duplicate. Searched for it but didn't an obvious match with an existing issue.


Incorrect Currency Displayed in Contributions

When looking at the contributors to a collective it shows their contribution in USD regardless of the currency they actually paid in. For example, a user in the Insurgo Initiative collective donated $50 CAD. You can see this in the transaction history at https://opencollective.com/insurgo/transactions however if you go to the collective's homepage the same transaction will show 50 USD.
Screenshot of contributions:
Transaction in CAD:
URL: https://opencollective.com/insurgo
Logged in as (username or profile URL):
Error message if any:
Expected result:
Browser: Chrome

We're normally not supporting switching currency when a collective has already an history.
To avoid that, the history should be reset and the collective should only have USD transactions.


Support --nolegacy_external_runfiles bazel flag

@alexeagle Hmmmm. This works on OSX/Linux but fails on Windows. Do we make an exception for Windows?


Values does not get updated in Property Editor

Pioneer build on linux is affected. Used the installer version by @yurii-litvinov
Please see the gif for visual problem description.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.2 LTS
Release:	16.04
Codename:	xenial
Kernel: 4.8.0-56-generic

I'm almost certain that @ZiminGrigory has fixed something like this in the past. Should he be the assignee or @yurii-litvinov ?

Fixed in #1799


The dita-ot-action should fail the GitHub action build, if the DITA-OT fails

Expected Behavior
In my particular case, the gen-list stage fails on my local Oxygen XML (which is expected), because the structure is to valid according to the grammar. It looks like this:
gen-list:
[gen-list] Using Xerces grammar pool for DTD and schema caching.
[gen-list] Processing file:/C:/Users/eike/workspace/com.dometic.dita-ot-pdf/test-files/constraint-conflict/ConstraintConflict.ditamap
Error: Failed to run pipeline: [DOTJ012F][FATAL] Failed to parse the input file 'file:/C:/Users/eike/workspace/com.dometic.dita-ot-pdf/test-files/constraint-conflict/ConstraintConflict.ditamap'.: file:/C:/Users/eike/workspace/com.dometic.dita-ot-pdf/test-files/constraint-conflict/ConstraintConflict.ditamap Line 8:element "critdates" not allowed here; expected element "author", "authorinformation", "change-historylist", "linktext", "metadata", "prodinfo", "searchtitle", "shortdesc" or "source"

BUILD FAILED
C:\Program Files\Oxygen XML Editor 25\frameworks\dita\dita_project\build_dita_project.xml:18: exec returned: 1

I expect GitHub Action to also fail.
Actual Behavior
It does not fail.
Possible Solution
No idea.
Steps to Reproduce
Add an invalid XML element to a DITA Map or Topic and publish this with the dita-ot-action.
GitHub Action YAML
      # Install all plugins and build the test files
      - name: 🚀 Build PDF using DITA-OT 3.7.4
        uses: dita-ot/dita-ot-action@master
        with:
          dita-ot-version: 3.7.4

          install : |
            dita install com.dometic.dita-doctypes.zip --force
            dita install com.dometic.dita-technical-data.zip --force
            dita install https://github.com/dita-community/org.dita-community.split-page-sequences/archive/refs/heads/develop.zip --force
            dita install com.dometic.dita-ot-pdf.zip --force
          build: |
            dita --project=test-files/test-files.xml --processing-mode=strict --verbose

Environment

DITA-OT version: 3.7.4
Operating system and version: Ubuntu GitHub action worker
How did you run DITA-OT? dita command
Transformation type: Custom PDF

@stefan-jung I suggest you add the relevan GitHub Action fragment from https://github.com/orgs/dita-ot/discussions/4286. I think it makes a difference that you're using build.

@stefan-jung -  I can't reproduce your behaviour - can you supply a full failing test case?When I run an action with:
build: |
            dita --project=.github/dita-ot/html.xml --processing-mode=strict --verbose

The action fails for me with:
gen-list:
 [gen-list] Using Xerces grammar pool for DTD and schema caching.
 [gen-list] Processing file:/github/workspace/flowers/flowers.ditamap
 [gen-list] Processing file:/github/workspace/flowers/concepts/autumnFlowers.dita
Error: ror: Failed to run pipeline: [DOTJ013E][ERROR] Failed to parse the referenced file 'file:/github/workspace/flowers/concepts/autumnFlowers.dita'.: file:/github/workspace/flowers/concepts/autumnFlowers.dita Line 3:Document root element "conceptx", must match DOCTYPE root "concept".

see: https://github.com/jason-fox/test-dita-build/actions/runs/6341148875/job/17224131988

@jason-fox, the code is proprietary, so I don't want to upload it to GitHub. What I could do is, that I send you the build script together with a recorded video in which I reproduce the issue by e-mail, if you would accept that.

I took the flowers dita, and amended a single  <concept> to <conceptx> which resolved to a  [DOTJ013E][ERROR] and a failed action due to a DITA-OT grammar error. It would be helpful if you could fork https://github.com/jason-fox/test-dita-build/ and create a minimal test case since the action is correctly erroring as far as I can see.

@jason-fox, I forked your test-dita-build project, and it fails as expected. It seems to me that the devil is a completely different detail, and I don't really understand the situation. And probably this is not related to dita-ot-action. I'll leave some explanations here, if others should stumble over this issue as well.
I'm building locally with a DITA-OT, which is based on the Oxygen XML Publishing Engine, because we also build Oxygen webhelps locally. On GitHub Actions, I fiddle the DITA-OT together during the build, install all the plugins, and so forth, as it is common practice. We currently do not need the Oxygen publishing engine on GitHub action, because I only want to build PDFs.
SyncroSoft has patched the DITA-OT heavily, which is nice, and it seems to me, that SyncroSoft also altered original DITA-OT files. For example, when you download a fresh Oxygen XML ZIP archive from oxygenxml.com/InstData/Editor/Windows/VM/oxygen.zip, expand it and look at the file oxygen\frameworks\dita\DITA-OT3.x\plugins\org.dita.pdf2\build_template.xml, you will see that the Oxygen XML Publishing engine, which is build on the DITA-OT 3.7.4, still uses preprocess.
<target name="dita2pdf2" depends="dita2pdf2.init, build-init, preprocess, map2pdf2, topic2pdf2"/>

But if you download a fresh DITA-OT 3.7.4 distribution package from github.com/dita-ot/dita-ot/releases/download/3.7.4/dita-ot-3.7.4.zip, you will see that the file dita-ot-3.7.4\plugins\org.dita.pdf2\build_template.xml is using preprocess2
<target name="dita2pdf2" depends="dita2pdf2.init, build-init, preprocess2, map2pdf2, topic2pdf2"/>

This was not clear to me yet.
So, my local build (Oxygen XML Publishing engine) fails here in the gen-list target:
preprocess.init:
[echo] *****************************************************************
[echo] * input = file:/C:/Users/eike/workspace/com.dometic.dita-ot-pdf/test-files/constraint-conflict/ConstraintConflict.ditamap
[echo] * resources = ${args.resources}
[echo] *****************************************************************

ditaval-merge:

gen-list:
[gen-list] Using Xerces grammar pool for DTD and schema caching.
[gen-list] Processing file:/C:/Users/eike/workspace/com.dometic.dita-ot-pdf/test-files/constraint-conflict/ConstraintConflict.ditamap
Error: Failed to run pipeline: [DOTJ012F][FATAL] Failed to parse the input file 'file:/C:/Users/eike/workspace/com.dometic.dita-ot-pdf/test-files/constraint-conflict/ConstraintConflict.ditamap'.: file:/C:/Users/eike/workspace/com.dometic.dita-ot-pdf/test-files/constraint-conflict/ConstraintConflict.ditamap Line 8:element "critdates" not allowed here; expected element "author", "authorinformation", "change-historylist", "linktext", "metadata", "prodinfo", "searchtitle", "shortdesc" or "source"

BUILD FAILED
C:\Program Files\Oxygen XML Editor 25\frameworks\dita\dita_project\build_dita_project.xml:18: exec returned: 1

But GitHub Action with a "normal" DITA-OT, does not call this target after ditaval-merge.
2023-09-29T09:56:38.3851449Z preprocess2.init:
2023-09-29T09:56:38.3851705Z      [echo] *****************************************************************
2023-09-29T09:56:38.3852196Z      [echo] * input = file:/github/workspace/test-files/constraint-conflict/ConstraintConflict.ditamap
2023-09-29T09:56:38.3852589Z      [echo] * resources = ${args.resources}
2023-09-29T09:56:38.3852881Z      [echo] *****************************************************************
2023-09-29T09:56:38.3853050Z
2023-09-29T09:56:38.3853171Z ditaval-merge:
2023-09-29T09:56:38.3853312Z
2023-09-29T09:56:38.3853421Z map-reader:
2023-09-29T09:56:38.3853789Z [map-reader] Using Xerces grammar pool for DTD and schema caching.
2023-09-29T09:56:38.3854568Z [map-reader] Processing file:/github/workspace/test-files/constraint-conflict/ConstraintConflict.ditamap to file:/opt/app/temp/temp20230929055638368/5d64977634c01eea5c3da6f6bd828089b76cac39.ditamap
2023-09-29T09:56:38.5588449Z [map-reader] Processing file:/github/workspace/test-files/constraint-conflict/topics/en-US/CTR_ConstraintConflict.ditamap to file:/opt/app/temp/temp20230929055638368/90019db9fbe6689e6d197637b9031ed001bac486.ditamap
2023-09-29T09:56:38.6252479Z [map-reader] Serializing job specification
2023-09-29T09:56:38.6276753Z
2023-09-29T09:56:38.6277160Z map-mapref:
2023-09-29T09:56:38.6733078Z    [mapref] Processing file:/opt/app/temp/temp20230929055638368/5d64977634c01eea5c3da6f6bd828089b76cac39.ditamap

To explain what I am trying to achieve in general: I want to publish a few DITA test scenarios to test my PDF plugin. But it now seems to me, that I have to work top-down (take an Oxygen XML Publishing engine on GitHub Action and kick-out everything, what I am not allowed to use on the server) instead of building bottom-up from a naked DITA-OT, because I don't know what else SyncroSoft has modified in the original code. I would simply get different results on GitHub actions, which do not help me to identify bugs in my plugin code.

@jelovirt and @jason-fox, I'll close this now, because the dita-ot-action seems to work as normal. The "problem" seems to me, that preprocess2 does not fail where it should (IMHO). But I'm currently in the stage of "guessing", not "knowing".

@stefan-jung - I think I know the reason behind your preprocess/  preprocess2 behaviour - my test case was using DITA-OT 4.1.1, not DITA-OT 3.7.4 - Unfortunately for you, when I do fix the engine version to 3.7.4.  the Action runs preprocess and fails as expected and the GitHub Action fails - so the functionality from "raw" DITA-OT preprocess and  the DITA-OT GitHub Action is running as expected even on 3.7.4


[RFR] added and modified methods for disks

added some methods ~needed for https://github.com/ManageIQ/integration_tests/pull/9565~
Tested locally with these changes

This PR is no longer needed for the test.


Questions about runDESC in the integration part

Hi, I found that for my dataset, if I use runDESC via scIB, I will receive such error:

However, I can successfully run my method based on the tutorial of DESC
https://eleozzr.github.io/desc/tutorial.html
The code is:
adata_desc = desc.train(adata, dims=[adata.shape[1], 32, 16], tol=0.005, n_neighbors=10,
batch_size=256, louvain_resolution=[0.8],
save_dir="result_pbmc3k", do_tsne=True, learning_rate=300,
do_umap=True, num_Cores_tsne=4,
save_encoder_weights=True)
I wonder why. Thanks.

Are you running both scripts in the same environment? We had some difficulties getting a consistent environment set up for DESC and scGen, which have clashing dependencies. It might be worth checking if the dependencies are not consistent in your scib environment.


Add TextMate grammar support back to VSCode extension

This PR adds TextMate grammar support back to VSCode extension, using grammar from michidk, @michidk.
There is a problem drop at the begin of PR: what's the relationship between tm grammars and semantic tokens providers? The short answer is we need both of them.
From some comment and commit, a language support would like to provide both of them to gain a best syntax and semantic language support.

Dark ships syntax definitions in their extension.

VSCode maintains a TextMate grammar for rust and enables it even if a semantic tokens provider is added.

We don't host the TextMate grammar for rust, that is upstreamed in VSCode.

In https://github.com/rust-lang/rust-analyzer/issues/14985#issuecomment-1577478634
This is why we don't see "grammar" contribution in package.json of rust-analyzer's extension.

In #252, @nvarner commented:

If TextMate and semantic token highlighting are both enabled at once, the semantic tokens appear on top of TextMate (this is the intention behind semantic tokens; the stated purpose is to highlight just a few things based on semantics that TextMate can't do by syntax, like based on if a variable is mutable or not). However, the TextMate grammar is out of date; I don't think it's been updated since it was pulled from an early version of Typst (but see https://github.com/nvarner/typst-lsp/issues/256 for a possible small update). It's hard to maintain the TextMate grammar because Typst's syntax is still in flux, whereas semantic token highlighting "just works" because it's based on Typst's own parser. If the TextMate grammar makes up the background of the semantic tokens, errors in it could highlight the code wrong, and it would have some cost for VS Code to perform TextMate highlighting.

It is correct that "the TextMate grammar is out of date", but there are two direction rather than avoid using TextMate grammar.

simplify TextMate grammar to avoid conflict with semantic token highlighting.
fix them if users report them.

I prefer to point 2, since we community also needs a nice TextMate grammar for syntax highlighting on GitHub. It would be nice if we can contribute one.
What does it fix?

Close #252
Fix by providing highlighting by TextMate grammar in default.

Close #256
Fix by reintroducing it.

Close #260
Fix by providing highlighting by TextMate grammar for memory files.

Close #264 and close #401
Fix by correct scope from TextMate grammar. But I doubt there is another bug in semantic highlighting.

Close #314
Fix by allowing unbalanced bracket in scopes. See VSCode Update April 2022 (version 1.67) and issue development

To make bracket pair matching and colorization more robust, TextMate grammar contributions can now express that brackets in certain tokens should not be matched. In the contributes section of an extensions package.json, provided grammars can use the properties balancedBracketScopes (defaults to ["*"]) and unbalancedBracketScopes (defaults to []) to include or exclude scopes for bracket matching.

Close #375
Fix by providing tm scopes by TextMate grammar in default.

Results are following:

I've done similar research and come to similar conclusions, and I have started work on this in the readd-textmate branch.
In particular, I've been writing a new textmate grammar based on the Typst lexer/parser. This is because any incompatibility between the grammar and Typst could cause worse bugs than we have without textmate. For example, if a region of markup was incorrectly highlighted by TM as code, it would be hard for users to see why only certain brackets are wrongly highlighted (or not highlighted). Moreover, because users can't opt out of TM highlighting, a bug like this would affect all users.
While writing this grammar, I've come to believe that it's likely impossible, or at least very difficult, for TM to correctly give a complete highlighting of Typst code (in summary, it has very poor support for syntactic structures which run across multiple lines, and Typst has these). This has led me to a few other ideas:

Try again with a much simpler grammar. It would mostly split a Typst file into markup/code/math regions, then enforce correct bracket matching within each region. We could also provide injection grammars if desired to provide better highlighting. I plan to try this soon.
Change the VS Code config so it doesn't even attempt bracket highlighting, and don't provide a TM grammar. This is certain to resolve the bracket highlighting issue, but comes with a number of downsides, so I'd rather not take this approach unless no other will work.

I also have a few relevant thoughts on the scope of this project. In particular, I think #252, #260 and #375 are strictly out of scope. I view this project as primarily a language server with associated extensions for language clients when needed, so VS Code's behavior when it does not use the LSP, and the reliance of other extensions on TM scopes, isn't a core part of our requirements. So, even if it would resolve these issues, if TM causes problems, I would rather not add it. That said, I'd like to resolve those issues if possible, since it would improve the user experience with Typst.
Similarly, I don't think of it as the responsibility of this project to provide a TextMate grammar for Typst. It's also possible for other VS Code extensions to provide a TM grammar for Typst in case users would like non-LSP highlighting. If we provide a very simple grammar, other extensions (or even a second extension sourced from this repo) could provide injection grammars, and could easily be disabled if they cause problems for users. Again, I'd like to provide a grammar because it would be good to, but not if it comes at a high cost.
(On the topic of linked issues, #264 and #401 are the result of incorrect handling of multiline semantic tokens. It may be superficially hidden by TM, but the fundamental issue will remain. I'm aware of this and understand the underlying problem, but haven't gotten to fixing it yet.)
Ultimately, I think we shouldn't, and that we don't need to, ship an incorrect TM grammar. If we do include one, I'd prefer it be simple so that we have a lowered maintenance overhead.

As I recall, the original TM grammar from Typst was subtly wrong, and these bugs were the original reason I sought to replace TM highlighting by semantic highlighting. The Typst language has also changed over time, but the grammar doesn't seem to have been regularly updated. Do we know that this grammar is correct?
Do your views or priorities differ from mine on the scope of the project, expected maintenance requirements from TM grammars, or similar? Under different assumptions, we certainly would want to maintain a high-quality TM grammar.

My consideration is following:
You position is totally correct and your comment brings me many new points. This repository is all about typst LSP, rather than typst language support. If we maintainers find a bug in TextMate grammar (doesn't ship in LSP extension), we have no responsibility to resolve them, but close them as unplanned.
However, as a part of community, if we don't have a way to redirecting them, it would be frustrated. for regular document writers, who don't quite know coding, it is hard to let them distinguish a LSP and a fully language support. When they find a syntax highlighting error, they consider a bug in LSP, come here, and open an issue, for example, Brackets are colorized inside strings and comments https://github.com/nvarner/typst-lsp/issues/314.
Consider that, imo the most correct decision is removing language-configuration.json and create a new vscode extension repository named "Typst Language Support".

We focus on providing semantic highlighting, and don't get bother by textmate syntax highlighting or bracket colorizing. When some user report a related issue, we tell that we have no responsibility to resolve them, but close them as unplanned or (more smartly) transfer the issue to the language support repository. To me, I feel more comfortable on transferring issues than closing them as unplanned.

When users activate the LSP extension, we recommend them installing "Typst Language Support", so to teach them install some extra extension to gain a best experience. To me, I feel more comfortable on whatever contributing to user experience.

Considering that TM grammar is error prone, if we would like to we add it, we have better to isolate it in another extension, so that we can disable them separately.

It brings more complexity to users but more correct to me. As for writing a new tm grammar, I'm happy that you have restarted it, we can move discussion then.

The create a new "Typst Language Support", there are two options:

Keep them in current repository and put them in somewhere.
Pros: our community is still small, we can aggregates issues and discussions.
Cons: It is not a LSP thing.

Create a new repository and move syntax files to the new repo.
Pros and Cons: conversely.

Experiment, we extension can contribute a language without https://github.com/nvarner/typst-lsp/blob/0d5b9330a1d515fa47456e755f751ea4056282b8/editors/vscode/language-configuration.json

Result with only LSP extension:

Result with only Language Support extension (TextMate grammar to add):

Result with only Both extension:

If we consider removing the language-configuration file, we can change this PR and still close/transfer these 7 issues.

I like your suggested approach. I think it's best to keep the Typst Language Support extension within this repository, since it will likely be closely related to the LSP extension. I'll do some more experimentation and find the best way to split the extension and make users aware that they'll need to install two things.


Add failing test for xhtml code escape in tsx

This PR adds a breaking test illustrating a bug in printing of transformed tsx code where html escape sequenced in source tsx are not unescaped in the compiled code when compilation target is > ES5.
It looks like the difference in behaviour for target <= ES5 and the newer versions is here: https://github.com/swc-project/swc/blob/master/ecmascript/codegen/src/lib.rs#L2497
I'm not sure I really understand this logic so maybe @kdy1 can clarify it and advise what would be the right way to fix it. I'm happy to include the fix into this PR if so

@kdy1 sorry for bothering you but this bug affects us quite severily, I'd love to contribute a fix, just need a bit guidance here

I fixed it with https://github.com/swc-project/swc/pull/1501 :)

Thanks a ton, you are a great human! 🙌


Firewall dose not support FQDNs with special character.

When I tried to add following FQDNs in Application rule, the FQDNs were invalid. It seems to be by design. Could you add this limitation into this document ?

test.*.testcom.com
test--a.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 474ba3cb-afa1-4ec5-37df-6553a5523dbb
Version Independent ID: 56096558-1943-3f6b-9609-7722200272fb
Content: What is Azure Firewall?
Content Source: articles/firewall/overview.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

I want you to add the limitation into this document.

I want you to add the limitation into this document.

@hisasima, Thanks for reaching out. We will investigate and update this thread.

@hisasima, Thanks for reaching out. We will investigate and update this thread.

@hisasima, Appreciate your patience. The doc has been edited accordingly and it would take some time for the changes to get reflect over the doc.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


"Illegal instruction" when trying to run the server using a precompiled docker image

Expected Behavior
I am trying to execute this:
docker run --rm -it -p 8000:8000 -v /home/xxxx/models:/models -e MODEL=/models/gpt4-alpaca-lora_mlp-65B/gpt4-alpaca-lora_mlp-65B.ggmlv3.q5_1.bin ghcr.io/abetlen/llama-cpp-python:latest
and I expect the model to load and server to start. I am using the model quantized by The Bloke according to the current latest specs of llama.ccp ggml implementation
Current Behavior
llama.cpp: loading model from /models/gpt4-alpaca-lora_mlp-65B/gpt4-alpaca-lora_mlp-65B.ggmlv3.q5_1.bin
Illegal instruction

Environment and Context
Linux DESKTOP-xxx <IP_ADDRESS>-microsoft-standard-WSL2+ #2 SMP
$ python3 3.10.9
$ make GNU Make 4.3
$ g++ (Ubuntu 11.3.0-1ubuntu1~22.04.1) 11.3.0

Steps to Reproduce
Please provide detailed steps for reproducing the issue. We are not sitting in front of your screen, so the more detail the better.
docker run --rm -it -p 8000:8000 -v /home/xxxx/models:/models -e MODEL=/models/gpt4-alpaca-lora_mlp-65B/gpt4-alpaca-lora_mlp-65B.ggmlv3.q5_1.bin ghcr.io/abetlen/llama-cpp-python:latest

MLP models aren't supported by llama.cpp AFAIK

Wow fast reply. I am using alpaca-lora-65B.ggml.q5_1.bin with llama-cpp-python directly inside a python app and it works well. I tried to load this model using the docker server path and it gave me the same error: "Illegal instruction"
So the incompatibility is not with llama.cpp

The standalone server is running well, so the error has something to do with either the docker image or what it is trying to do and what my environment (WSL2) is letting it do:
gpt4-alpaca-lora_mlp-65B/gpt4-alpaca-lora_mlp-65B.ggmlv3.q5_1.bin
llama_model_load_internal: format     = ggjt v3 (latest)
llama_model_load_internal: n_vocab    = 32000
llama_model_load_internal: n_ctx      = 2048
llama_model_load_internal: n_embd     = 8192
llama_model_load_internal: n_mult     = 256
llama_model_load_internal: n_head     = 64
llama_model_load_internal: n_layer    = 80
llama_model_load_internal: n_rot      = 128
llama_model_load_internal: ftype      = 9 (mostly Q5_1)
llama_model_load_internal: n_ff       = 22016
llama_model_load_internal: n_parts    = 1
llama_model_load_internal: model size = 65B
llama_model_load_internal: ggml ctx size =    0.18 MB
llama_model_load_internal: mem required  = 50284.21 MB (+ 5120.00 MB per state)
warning: failed to mlock 196608000-byte buffer (after previously locking 0 bytes): Cannot allocate memory
Try increasing RLIMIT_MLOCK ('ulimit -l' as root).
....................................................................................................
llama_init_from_file: kv self size  = 5120.00 MB
AVX = 1 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 0 | SSE3 = 1 | VSX = 0 |
INFO:     Started server process [2244388]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://localhost:8000 (Press CTRL+C to quit)

On further thought "illegal instruction" could be due to the fact that the Docker image was compiled on another computer that supports vector instructions not supported on your current hardware. Did you build the Docker image locally?

Entirely likely then.
There's sample Dockerfiles in the root dir, or I just created a pull request #270 that needs some smoke testing, if you have the time :wink:

Im getting this issues as well.
I have manually built 'llama-cpp-python'  and it fails similarly Illegal instruction (core dumped) as soon as you load from llama_cpp import Llama
Has anyone else have this issue to ?
Im on Almalinux 9 with python 3.11

I have manually built 'llama-cpp-python'

On the same hardware without any virtualisation?

I have manually built 'llama-cpp-python'

On the same hardware without any virtualisation?

Yes, Im using virtualization, Im using a Dell R820 with Proxmox 7.
I have a VM running Almalinux 9
What the point is, Im having a Illegal instruction (core dumped) errors everytime im trying to use "
llama-cpp-python" However, If I used llama-cpp directly I have no issues. Its only when I use this python binding with cuBLAS being built. CMAKE_ARGS="-DLLAMA_CUBLAS=on -CMAKE_CUDA_ARCHITECTURES=native" FORCE_CMAKE=1 pip install llama-cpp-python  --no-cache-dir or even manually building it from source.
I have no idea what logs to even collect, I checked journalctl and found nothing of intrest other than
May 27 15:29:46 localhost.localdomain kernel: traps: python3.9[84283] trap invalid opcode ip:7f3cec006c2a sp:7ffdbd2a9920 error:0 in libllama.so[7f3cebff2000+45000]
May 27 15:29:46 localhost.localdomain systemd[1]: Started Process Core Dump (PID 84284/UID 0).
May 27 15:29:47 localhost.localdomain systemd-coredump[84285]: Resource limits disable core dumping for process 84283 (python3.9).
May 27 15:29:47 localhost.localdomain systemd-coredump[84285]: [🡕] Process 84283 (python3.9) of user 1000 dumped core.
May 27 15:29:47 localhost.localdomain systemd[1]<EMAIL_ADDRESS>Deactivated successfully.

Any Ideas?

You're going to need to compare the AVX1 / AVX2 / AVX512* compilation options between the working build and the one throwing the illegal opcode.
If you're compiling in a VM, sometimes the virtualisation "lies" about what Intel extensions are available to the VM, when in fact they're only available on the host. Someone logged a ticket a while back where HyperV security settings was preventing the use of AVX512 by programs running in the VM.

Gjmulder, that's interesting, why would it fail within the python binding VS from the vendor source?
Do you know if when we build the python binding does it build the llama-cpp application with other cpu instructions that are hard-coded?
There has to be something different from
Installing normally VS installing from source in llama-cpp-python.
Mind you llama-cpp works fine with cuBLAS it just doesn't work for me in llama-cpp-python.

Maybe try building llama-cpp-python from source with the --verbose option? It will then pull in a specific commit of llama.cpp.
Next compare the output of a test programming using that uses the source build llama-cpp-python package with the output of ./main.
There's significant amount of change occurring in llama.cpp to the point where new features are being introduced faster than I can keep track of them. Best to assume nothing at this point. :man_shrugging:

@gjmulder  I tried building with verbose and there isnt significan of value.
I tried building with or with out  -DLLAMA_AVX2=off for fun both gave me the same result.
However, after doing some more digging I think this issue opened on llama-cpp might be our issue.
https://github.com/ggerganov/llama.cpp/issues/1583
I suspect, that building "llama.cpp" directly works fine for me since I dident use cmake to build it. however since llama-cpp-python uses cmake and from what issue (https://github.com/ggerganov/llama.cpp/issues/1583) by default its building it with AVX2 built in is causing my compiled library to have support for instructions that are not supported.
I think I would be able to replicate this issue directly on llama.cpp if I built it from source using cmake.

@gjmulder and @vmajor
Great news I was able to fix this issue.
It required me to modify /vendor/llama.cpp/CMakeLists.txt  In  the lines 56 and 70 I had to turn off LLAMA_AVX2 and turn on LLAMA_CUBLAS
Once that was done I was now able to build "llama-cpp-python" from source and install with pip natively and also import it in python no issues.
(.venv) [ai00@localhost llama-cpp-python]$ python -c "from llama_cpp import *; print(llama_print_system_info())" b'AVX = 1 | AVX2 = 0 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 0 | NEON = 0 | ARM_FMA = 0 | F16C = 0 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | VSX = 0 | '1
@vmajor I think if you were to do the same modification you should be able to build llama-cpp-python with the correct cpu instructions.

Thanks for the hard work. I can in fact run llama-cpp-python locally without any issue. It was just the docker image that would not run. I had not spent time trying to make a new docker image as I changed my workflow to use llama-cpp-python locally. There are many other toolchains that are more broken for me so I need to pick and choose what I focus on.

ggerganov/llama.cpp#1583

I'm a Collaborator to llama.cpp so I labeled it with build + bug + high priority, given the llama-cpp-python dependency.

CLosing please reopen if the problem is reproducible with the latest llama-cpp-python which includes an updated llama.cpp

CLosing please reopen if the problem is reproducible with the latest llama-cpp-python which includes an updated llama.cpp

What update are you referring to?
I upgraded to a new version of llama-cpp-python and still keep getting this error.
Maybe there are some flags or presets that I have to do when I install  llama-cpp-python?

@chen369's solution works, but for some environments, you may also have to set LLAMA_FMA = off.

I am running on old E5645 (Westmere) Xeons that do not support AVX at all. I can confirm that the below command works for me:
CMAKE_ARGS="-DLLAMA_CUBLAS=1 -DLLAMA_AVX=OFF -DLLAMA_AVX2=OFF -DLLAMA_F16C=OFF -DLLAMA_FMA=OFF" FORCE_CMAKE=1 pip install --upgrade --force-reinstall llama-cpp-python --no-cache-dir
So CMAKE_ARGS seems to work at this time.
https://github.com/ggerganov/llama.cpp/issues/1027

I am running on old E5645 (Westmere) Xeons that do not support AVX at all. I also ran into "Illegal instruction". But I can confirm that the below command works for me:
CMAKE_ARGS="-DLLAMA_CUBLAS=1 -DLLAMA_AVX=OFF -DLLAMA_AVX2=OFF -DLLAMA_F16C=OFF -DLLAMA_FMA=OFF" FORCE_CMAKE=1 pip install --upgrade --force-reinstall llama-cpp-python --no-cache-dir
Not a problem with CMAKE_ARGS.
ggerganov/llama.cpp#1027

At first, I used this command to compile the wheel. However, after completion, when I tried to load the model, it returned None. I meticulously checked multiple times and noticed that its version had changed from 0.1.77 to 0.1.83. To address this, I specified the version by appending ==0.1.77 to the package name, recompiled, and reinstalled. After this adjustment, everything worked as expected. thanks.


Update the issue templates to account for source of issue

:white_check_mark: Checklist

[x] This pull request has a meaningful title.
[x] If your changes are not yet ready to merge, you have marked this pull request as a draft pull request.

:ballot_box_with_check: Maintainers' checklist

[ ] This pull request has had the appropriate labels assigned
[ ] This pull request has been added to the SATRE backlog project board
[ ] This pull request has been assigned to one or more maintainers

:arrow_heading_up: Summary
Adding an optional field for the source of issues so we can track e.g. which issues come from SATRE survey, or Collab Cafes, or personal contributions, or somewhere else!
:closed_umbrella: Related issues
Closes #47
:raising_hand: Acknowledging contributors

[x] All contributors to this pull request are already named in the table of contributors in the README file.
[x] The following people should be added to the table of contributors in the README file:

@martintoreilly is this what you had in mind for sourcing where things came from?

CONTRIBUTING.md has also made it's way into this PR (I did exactly the same on #44 - shouldn't have so many VSCode windows open....)


add getRoutes with onEnter test case

Add test cases for use getRoutes with onEnter. One of them is a failed test.

duplicate of #62


NativeLink Should Not Start if CAS and AC are the Same

If users try to start NativeLink configuring CAS and AC to use the same store, it should fail and provide a helpful error.

It is related to: https://github.com/TraceMachina/nativelink/issues/744

I'd like to work on this issue. cc: @allada , @MarcusSorealheis

I resolved the issue , but as @aleksdmladenovic raised a pr already , I am not raising my pr now without your permission @MarcusSorealheis .
But while reviewing his PR , I just want to suggest the modifications needed:

to reduce time complexity I created a HashMap called cas_store_map from the CAS configuration, where the key is the instance_name and the value is a reference to the cas_store.

then iterate over the AC configuration and check if the instance_name exists in the cas_store_map.

we compare the store names, and if they match, we return an error.

I have added  a integration test file also in my solution simple_store_conflict_test.sh in the integration_tests directory
Want to know what I have written in my script?
1)A function check_store_conflict to simulate checking for conflicts between CAS and AC configurations.
2)Two test cases:
test_conflict_when_cas_and_ac_use_same_store to verify that a conflict is detected when CAS and AC use the same store.
test_no_conflict_when_cas_and_ac_use_different_stores to verify that no conflict is detected when CAS and AC use different stores.
The script runs both test cases and prints the result of each test.
@MarcusSorealheis need your permission to raise my PR , otherwise I can assist @aleksdmladenovic in his PR as being an active contributor , I always respect opensource rules

Raise a PR
Marcus Eagan
On Fri, Jul 19, 2024 at 11:33 DEBANJAN MUKHERJEE @.***>
wrote:

I resolved the issue , but as @aleksdmladenovic
https://github.com/aleksdmladenovic raised a pr already , I am not
raising my pr now without your permission @MarcusSorealheis
https://github.com/MarcusSorealheis .
But while reviewing his PR , I just want to suggest the modifications
needed:

to reduce time complexity I created a HashMap called cas_store_map
from the CAS configuration, where the key is the instance_name and the
value is a reference to the cas_store.
2.
then iterate over the AC configuration and check if the instance_name
exists in the cas_store_map.
3.
we compare the store names, and if they match, we return an error.
I have added a integration test file also in my solution
simple_store_conflict_test.sh in the integration_tests directory
Want to know what I have written in my script?
1)A function check_store_conflict to simulate checking for conflicts
between CAS and AC configurations.
2)Two test cases:
test_conflict_when_cas_and_ac_use_same_store to verify that a conflict is
detected when CAS and AC use the same store.
test_no_conflict_when_cas_and_ac_use_different_stores to verify that no
conflict is detected when CAS and AC use different stores.
The script runs both test cases and prints the result of each test.
@MarcusSorealheis https://github.com/MarcusSorealheis need your
permission to raise my PR , otherwise I can assist @aleksdmladenovic
https://github.com/aleksdmladenovic in his PR as being an active
contributor , I always respect opensource rules
—
Reply to this email directly, view it on GitHub
https://github.com/TraceMachina/nativelink/issues/768#issuecomment-2239882290,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR6TSHAYJYK2IRY7BS4N5TZNFLXVAVCNFSM6AAAAABEZQZK7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZHA4DEMRZGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


[REVIEW] Initial version of devel images with BlazingSQL added

This also include the "Welcome to BlazingSQL" notebook repo and updates to /test.sh to run the welcome NB.
Note: There are other NBs in the Welcome repo, but those are not being run since they require additional dependencies. When the runtime images are using the updated RAPIDS meta-packages (specifically an updated notebook deps package), this can be revisited if it's decided the additional dependencies for the extra Blazing NBs are to be included.
@ajschmidt8 - I left the "clean" option in the updated generate script if you ever find that useful. I can remove that if you don't want that code in there.

@mike-wendt there's a long internal email thread that ended with "let’s get the devel containers good to go while we work on improving the conda packaging situation", which I interpreted to be what's in this PR. I didn't realize the original request was still what we wanted after that. I can make the change you're asking for, but like you said, it'll now have to wait for 0.16.

Let's ask clarifying questions more, and get sign off. This mistake only cost BlazingSQL a few dozen thousand downloads :(

Let's ask clarifying questions more, and get sign off.

Agreed. Unfortunately, clarification and sign off was the intent of the PR :(  but we'll figure out a different way.

closing this in favor of #179


Community Recognition 🎉

Want to recognize someone in the community? Let us know and we'll add them to the README.md!

@all-contributors please add @mhittle for ideas, maintenance, and projectManagement.

@all-contributors please add @aamirrasheed for content and video.

@all-contributors please add @vishnuravi for code

@all-contributors please add @PSchmiedmayer for code


added initial support for extra argument metrics

Before submitting

[x ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements) https://github.com/PyTorchLightning/metrics/issues/136
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?   (does it apply?)
[ ] Did you write any new necessary tests?   (well it is in the tests ...)

What does this PR do?
Fixes # (issue).
Adds support for extra arguments during testing (using a dictionary interface)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
I did have fun :3
Make sure you had fun coding 🙃

Hello @jspaezp! Thanks for opening this PR.

In the file tests/helpers/testers.py:

Line 112:1: W293 blank line contains whitespace
Line 123:22: E231 missing whitespace after ':'
Line 123:33: E231 missing whitespace after ','
Line 131:34: E231 missing whitespace after ':'
Line 131:88: E231 missing whitespace after ','
Line 132:1: W293 blank line contains whitespace
Line 149:24: E231 missing whitespace after ':'
Line 149:76: E231 missing whitespace after ','
Line 186:60: E231 missing whitespace after ':'
Line 186:71: E231 missing whitespace after ','

Do see the Hitchhiker's guide to code style


[ENHANCEMENT]: Heatmap visualization config panel features v1

Implementation of Heatmap config panel features as mentioned in #787 .
Features to implement:

Panel options

Use common panel options.

Data configurations

Use common data configurations for heatmap, but supports only 2 dimensions.

Graph styles

Colors

Scheme

Legend placement (filter buttons)

bottom
right

Hi @mengweieric
For data configurations you have mentioned to support only 2 dimensions, but the in the current implementation of heatmap we have only one value option as z-axis. So are you referring to z-axis as dimensions or is there some other term for it. Also do we have to implement x-axis, y-axis and z-axis as data configurations for heatmap?
Thanks!
CC: @abasatwar @spattnaik

Hi @mengweieric @anirudha
I started working on legend for heatmap that is colorbar as per plotly's documentation. The current version of plotly that we are using(2.4.1), changing colorbar orientation is not supported yet. The Plotly provides support for colorbar orientation after version 2.8.0. So I have implemented show/hide of legend only. Let me know if that is okay.
Thanks!
CC: @abasatwar @spattnaik

Hi @mengweieric
Just wanted to confirm with you if we should move the value options for this graph to the right or let them be as in screenshot.

Thanks!

Hi @mengweieric
Just wanted to confirm one thing about this graph, as per our Thursday's call we would display no graph. Following will be the view on the initial load. Please let me know if this is expected.

Thanks!

yes, graph only works if we the relevant data and config

This has been merged to the main branch in the PR: https://github.com/opensearch-project/observability/pull/824.
Legend placement is remaining for which a separate ticket will be created and will be linked to this one.