HDFS-15732 EC client will not retry get block token when block token …

2558

 Quality gate: Passed
 Everything looks good
Details


PubSub/Feeds

Using flooding for now
@whyrusleeping mentioned that some pubsub support was shipped in libp2p?

No flooding needed, and we have persistence requirements. Plus it's really straightforward to implement the network parts with libp2p streams, we don't need anything special.
Overall approach:

Feeds are advertised to the directory
Feeds are subscribed by directly connecting to the peer, syncing and keeping a stream open for updates
The synchronization happens with per peer timestamp, ntp is a reasonable dependency. It takes a simple query for messages by publisher id and timestamp > last peer  sync time.
When the publisher disconnects, the subscribers will keep polling with exponential backoff by looking up the peer in the directory.

I think we want to limit the scope on this, as it is a big topic and not quite necessary for v1.
What we need instead for v1 is the query protocol (#22 ) and merging of remote data sets (#25 ).
Couple this with published namespace announcements and we already have a usable system without the complexities of pubsub.

I think we should implement it totally in RSS way, with polling and merging.
There is no urgency for push publishing until we have real-time feeds to distribute.

That's fine by me. I think the most lightweight implementation is best right now, and poll + merge (or just merge on demand, really) is that

Implementation suggested by Matthew Roberts on top of kad: https://github.com/kadtools/kad-quasar (paper)

Another thought... The nice thing about https://github.com/libp2p/go-floodsub is that it establishes the interface, so higher-level development can proceed with assumption the underlying implementation will be come performant at some point w/o worrying about details.
We can do something similar with polling..

@denisnazarov not sure the iface would be the same for non-flooding impl

@parkan wanted to revisit this, since we've made lots of progress on mediachain foundations since opening this issue.
after speaking to @haadcode earleir, he suggested it would be fairly trivial to implement pubsub features from orbit-db to notification features to our namespaces.
goal is to implement this as a prototype to showcase the potential of the tech (not meant to be production grade), as well as to bridge our communities and show how mediachain and orbit-db/ipfs are collaborating, and that the sum of the technologies is something really cool
ideal demo would be something like a "decentralized instagram" where two people publish to the dinstagram.* and see their data update in real time.
also down to consider an api that uses polling under the hood and could be switched out for more robust pubsub in the future?

Basically participating nodes can instantiate a corresponding orbit-db-eventstore
Documentation on how they implement the linearization is sparse and last I saw it was based on attaching to last known head with no clear way to resolve forks, so need to read through the code to see how that works.

Hey,
I'll want to provide you a clear documentation on how ipfs-log works, both
generally and in terms of linearization. I don't think I'll have time
before Monday, so hopefully you can wait till then. However, if you're in
rush to understand it, take a look at the open PR "immutable log" in
haadcode/ipfs-log, entry points are append() and join(), play with the
tests and use log.toString() to see what it outputs and how it behaves.
Essentially ipfs-log sorts the forks on join deterministically, and upon
join EventStore will update its index ("view") as a last write wins crdt.
It's a partial order as opposed to absolutely order (for which consensus or
coordination would be required in order to produce a sequence nro or
similar)
Hope this helps! Looking forward to see what we can do and dinstagram
sounds like an amazing demo to put our tech together! :)
Samuli
On Jan 13, 2017 00:01, "Arkadiy Kukarkin"<EMAIL_ADDRESS>wrote:

Basically participating nodes can instantiate a corresponding
orbit-db-eventstore https://github.com/haadcode/orbit-db-eventstore
Documentation on how they implement the linearization is sparse and last I
saw it was based on attaching to last known head with no clear way to
resolve forks, so need to read through the code to see how that works.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mediachain/concat/issues/13#issuecomment-272311633,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHJvruh0aWb5YCnUtTsSlgjBDg6G9l4Hks5rRrDRgaJpZM4J_F9-
.

Ooops apparently I left these unposted somehow yesterday? @haadcode addressed this somewhat already so posting as a separate comment for the record
Basically participating nodes can instantiate a corresponding orbit-db-eventstore and ping it for each statement written to the corresponding namespace.
Unclear things:

linearization (sounds like there's a deterministic join semilattice)
connectedness/scaling: it seems like currently floodsub keeps complete (?) peer and topic lists on all nodes so there's (n/k)((n/k)-1)/2 edges, is that correct? at what point is this expected to fall over?
channel creation/control/permissions: what does orbitdb.eventlog(foo.bar) actually do? I am guessing at this point anyone is allowed to write to anywhere and this just creates an entry in the topics map -- sounds like this is the biggest integration point

@haadcode thanks for chiming in, looking forward to exploring this together! No rush, let us know when you have a chance for a more in-depth technical discussion.


NoUselessElseFixer - Add option to convert useless elseif into if

Implements #2695.
I'm pretty sure we can add more test cases, I'm open to suggestions :)

for the record; I disagree this being a bug fix as I left it out by design. I think adding it to the fixer is a break on the single responsibility principle, same as why I always said no to request of letting the fixer as fix the identification afterwards.
That being sad I would like to hear what cases this PR is supposed to fixed;
<?php
if ($a) {
    echo 1;
} elseif ($b) {
    echo 2;
}

<?php
if ($a) {
    die;
} elseif ($b) {
    echo 2;
}

<?php
if ($a) {
    die;
} elseif ($b) {
    echo 2;
} else {
    echo 3;
}

<?php
if ($a) {
    die;
} elseif ($b) {
    die;
} else {
    echo 3;
}

<?php
if ($a) {
    echo 1;
} elseif ($b) {
    die;
} else {
    echo 3;
}

<?php
if ($a) {
    die;
} elseif ($b) {
    die;
} elseif ($c) {
    echo 1;
} else {
    echo 3;
}

For the record; I disagree this being a bug fix as I left it out by design.

Ok so let's keep it as new feature.

I think adding it to the fixer is a break on the single responsibility principle, same as why I always said no to request of letting the fixer also fix the identification after removing the else.
i.e. I think this should be a new fixer.

IMO adding this behavior to the current fixer makes sense. As most of the logic is shared, I'd like to hear more opinions about this before refactoring.

About the cases you listed, here are the changes the fixer should apply:
 <?php
 if ($a) {
     echo 1;
 } elseif ($b) {
     echo 2;
 }

 <?php
 if ($a) {
     die;
-} elseif ($b) {
+}
+if ($b) {
     echo 2;
 }

 <?php
 if ($a) {
     die;
-} elseif ($b) {
+}
+if ($b) {
     echo 2;
 } else {
     echo 3;
 }

<?php
 if ($a) {
     die;
-} elseif ($b) {
+}
+if ($b) {
     die;
-} else {
+
     echo 3;
-}
+

 <?php
 if ($a) {
     echo 1;
 } elseif ($b) {
     die;
 } else {
     echo 3;
 }

I think those cases are already covered though.

+}
+if ($b) {

I would rather it inserted a newline inbetween those.

IMHO there is a big diff. between the fixer and that is why they should be separated;
the use else fixer starts at an T_ELSE and only analyzes up to see if all paths lead to a stop.
Your fixer should, IMO, also look down. I.e. not fix:
<?php
if ($a) {
    die;
} elseif ($b) {
    echo 2;
} else {
    echo 3;
}

here the else statement is not useless, so should not be touched by the useless else fixer.
If people want to change these cases that is fine by me, but it would consider it a feature loss if we force people to also change elseif statements.

@GrahamCampbell I would rather it inserted a newline inbetween those.

What you want is #2384.
Adding this empty line would be an assumption that most people would add it, which is not true IMO. I guess we could say the same about moving the if to the next line but I don't think most people write something like
if ($a) {
    // ...
} if ($b) {
    // ...
}

@SpacePossum here the else statement is not useless, so should not be touched by the useless else fixer.

In your example the else would not be removed. The fixer would only convert the elseif into an if, which looks valid to me, unless I am missing something.

If people want to change these cases that is fine by me, but it would consider it a feature loss if we force people to also change elseif statements.

Current implementation requires to enable an option to fix your example, nothing will change for people that don't want to fix it.

In your example the else would not be removed. The fixer would only convert the elseif into an if, which looks valid to me, unless I am missing something.

I'm saying nothing should be touched in the sample by the no-useless_else-fixer at all, so no convert of elseif as well no matter what.I.e. the fixer is not called no_useless_else_and_elseif_to_if_splitup_fixer

Current implementation requires to enable an option to fix your example, nothing will change for people that don't want to fix it.

With above in mind I'm -1 on adding this to the fixer, including using configuration.
So I'm -1 on https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2885#discussion_r124260965 where a RFC is done on the PR and agreed on by for this PR to always apply the new elseif fixing, even more the comment is incorrect as just a next case we didn't spot before is simply not true, it was left out by design.

Adding this empty line would be an assumption that most people would add it, which is not true IMO.

I think that most people would, actually.

@SpacePossum For me the elseif contains an useless else in your sample. So it should be removed by a NoUselessElseFixer.

Thank you @julienfalque.


New version: Zen-Team.Zen-Browser.Optimized version 1.0.2-b.0

Pull request has been created with komac v2.8.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Installs correctly on a VM

See https://github.com/microsoft/winget-pkgs/pull/197533#issuecomment-2532656673


Unable to scroll to last item on TableView

I have downloaded the sample then I changed numberOfRowsInSection to 20. there is an issue on the last cell of table view (Hidden).

Thank you for #1 report of this library!  I acknowledge this issue and  I'm working to fix it now.

@faris-mobile89
I fixed this issue on v1.0.0. Could you please try it?

Hi! I've also been following this (pretty awesome btw) and I can confirm that we are able to scroll to the last item now. I have a question though, how could we avoid having extra blank space at the bottom when using a tabBar in iPhones X and up? It works fine in square screen devices.

Hello, @jaimeealmanza!
Thank you for your report. I didn't know the layout issue. I try to investigate that.
If possible, I would like you to attach a screen shot when the issue happens. it will be much helpful for me.

@jaimeealmanza  Could you try to use 'fix-surface-view-height' branch?
pod 'FloatingPanel', :git => 'https://github.com/scenee/FloatingPanel.git', :branch => 'fix-surface-view-height'

@SCENEE  I'm afraid that branch makes it clip the last cell under the tab bar. Attached screenshots for the current release and for 'fix-surface-view-height' branch.

@jaimeealmanza Thank you for your screen shots! I will fix it.

Thanks, @faris-mobile89 and @jaimeealmanza.

I'm currently having a similar problem.
I open a panel in 'half' size without tracking the tableview, so it stays at half, when scrolling.
Then it is not possible to scroll to the last tableview items.
When I open the panel in 'full' everything is fine...

What event should I use to handle the "Height change"?


ValueError: Images of type float must be between -1 and 1.

This bug happens with float32 data.
Trying to reproduce using sct-4.0.0-beta.2 (does **not** reproduce)
# INSIDE TERMINAL
cd sct_example_data/t2
source ~/sct/python/bin/activate  # activate SCT python
python

# INSIDE PYTHON
import nibabel as nib
import numpy as np
img = nib.load('t2.nii.gz')
img.set_data_dtype(np.float32)
nib.save(img, 't2f.nii.gz')
quit()

# BACK TO THE TERMINAL
sct_deepseg_sc -i t2f.nii.gz -c t2
sct_label_vertebrae -i t2f.nii.gz -s t2f_seg.nii.gz -c t2

# FULL OUTPUT (no error)
julien-macbook:~/sct_example_data__old/t2 $ sct_label_vertebrae -i t2f.nii.gz -s t2f_seg.nii.gz -c t2
Create temporary folder (/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8)...

Copying input data to tmp folder...

Straighten spinal cord...
Reusing existing warping field which seems to be valid
cp /Users/julien/sct_example_data__old/t2/warp_curve2straight.nii.gz warp_curve2straight.nii.gz
cp /Users/julien/sct_example_data__old/t2/warp_straight2curve.nii.gz warp_straight2curve.nii.gz
cp /Users/julien/sct_example_data__old/t2/straight_ref.nii.gz straight_ref.nii.gz
sct_apply_transfo -i data.nii -w warp_curve2straight.nii.gz -d straight_ref.nii.gz -o data_straight.nii # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8

Resample to 0.5mm isotropic...
sct_resample -i data_straight.nii -mm 0.5x0.5x0.5 -x linear -o data_straightr.nii # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8

Apply straightening to segmentation...
/Users/julien/sct_4.0.0-beta.2/bin/isct_antsApplyTransforms -d 3 -i segmentation.nii -r data_straightr.nii -t warp_curve2straight.nii.gz -o segmentation_straight.nii -n Linear # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8
sct_maths -i segmentation_straight.nii -thr 0.5 -o segmentation_straight.nii # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8

Create label to identify disc...
Creating temporary folder...
Run C2-C3 detector...
C2-C3 detected...
Remove temporary files...
rm -rf /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165632.976741-uvlvng81
WARNING: File /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8/labelz.nii.gz already exists. Will overwrite it.

Done! To view results, type:
fsleyes /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8/labelz.nii.gz &

And apply straightening to label...
/Users/julien/sct_4.0.0-beta.2/bin/isct_antsApplyTransforms -d 3 -i labelz.nii.gz -r data_straightr.nii -t warp_curve2straight.nii.gz -o labelz_straight.nii.gz -n NearestNeighbor # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8

Get z and disc values from straight label...
.. [307, 2]

Look for template...
Path template: /Users/julien/sct_4.0.0-beta.2/data/PAM50

Open template and vertebral levels...

Disc values from template: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]
Z-values for each disc: [962, 939, 908, 871, 834, 801, 770, 736, 693, 647, 601, 552, 501, 450, 397, 343, 290, 232, 169, 106, 56]
Distances between discs (in voxel): [23.0, 31.0, 37.0, 37.0, 33.0, 31.0, 34.0, 43.0, 46.0, 46.0, 49.0, 51.0, 51.0, 53.0, 54.0, 53.0, 58.0, 63.0, 63.0, 50.0]

Detect intervertebral discs...
Current disc: 2 (z=307). Direction: superior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
Current disc: 1 (z=338). Direction: superior
.. correcting factor: 1.0
.. Switching to inferior direction.
Current disc: 3 (z=270). Direction: inferior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
.. correcting factor: 1.0
Current disc: 4 (z=233). Direction: inferior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
.. correcting factor: 1.0
Current disc: 5 (z=200). Direction: inferior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
.. correcting factor: 1.0
Current disc: 6 (z=169). Direction: inferior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
.. correcting factor: 1.0
Current disc: 7 (z=135). Direction: inferior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
.. correcting factor: 1.0
Current disc: 8 (z=92). Direction: inferior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
.. correcting factor: 1.0
Current disc: 9 (z=46). Direction: inferior
.. WARNING: Data contained zero. We probably hit the edge of the image.
.. WARNING: Correlation vector only contains zeros. Using adjusted template distance.
.. correcting factor: 1.0
Adding top disc based on adjusted template distance: #0
.. approximate distance: 23

Un-straighten labeling...
/Users/julien/sct_4.0.0-beta.2/bin/isct_antsApplyTransforms -d 3 -i segmentation_straight_labeled.nii -r segmentation.nii -t warp_straight2curve.nii.gz -o segmentation_labeled.nii -n NearestNeighbor # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8

Clean labeled segmentation (correct interpolation errors)...
WARNING: File /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8/segmentation_labeled.nii already exists. Will overwrite it.

Label discs...

Generate output files...
  WARNING: File ./t2f_seg_labeled.nii.gz already exists. Deleting it...
sct_convert -i /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8/segmentation_labeled.nii -o ./t2f_seg_labeled.nii.gz
  File created: ./t2f_seg_labeled.nii.gz
  WARNING: File ./t2f_seg_labeled_discs.nii.gz already exists. Deleting it...
sct_convert -i /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8/segmentation_labeled_disc.nii -o ./t2f_seg_labeled_discs.nii.gz
  File created: ./t2f_seg_labeled_discs.nii.gz
  WARNING: File ./warp_curve2straight.nii.gz already exists. Deleting it...
  File created: ./warp_curve2straight.nii.gz
  WARNING: File ./warp_straight2curve.nii.gz already exists. Deleting it...
  File created: ./warp_straight2curve.nii.gz
  WARNING: File ./straight_ref.nii.gz already exists. Deleting it...
  File created: ./straight_ref.nii.gz

Remove temporary files...
rm -rf /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190426165627.020460-label_vertebrae-j_ww7mp8

Done! To view results, type:
fsleyes /Users/julien/sct_example_data__old/t2/t2f.nii.gz -a 100.0 ./t2f_seg_labeled.nii.gz -cm subcortical -a 50.0 &

--> cannot reproduce: asked user to provide data.
Also see: http://forum.spinalcordmri.org/t/sct-label-vertebrae-error-images-of-type-float-must-be-between-1-and-1/63

Error can be reproduced with user data (shared in private). It is fixed in https://github.com/neuropoly/spinalcordtoolbox/pull/2238.


Fix off-by-one error in upserts

There are two off-by-one errors in the upsert functions for message ID and message type.
UpsertMessageId should allow a value of 65535, while UpsertType should allow 255.
Without this fix, a device sending a confirmable message to the server will receive an ACK message back with an incorrect Message ID.
FYI: @mniestroj @vitprajzler

Codecov Report

Merging #423 (b7514f4) into master (2e2c858) will increase coverage by 0.16%.
The diff coverage is 88.88%.

:exclamation: Current head b7514f4 differs from pull request most recent head a620e34. Consider uploading reports for the commit a620e34 to get more accurate results

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   71.34%   71.50%   +0.16%
==========================================
  Files          68       68
  Lines        5255     5275      +20
==========================================
+ Hits         3749     3772      +23
+ Misses       1122     1117       -5
- Partials      384      386       +2

Impacted Files
Coverage Δ

udp/coder/coder.go
68.62% <0.00%> (+4.52%)
:arrow_up:

message/getmid.go
83.33% <100.00%> (+3.33%)
:arrow_up:

message/message.go
80.00% <100.00%> (ø)

message/pool/message.go
75.63% <100.00%> (ø)

message/type.go
85.71% <100.00%> (+5.71%)
:arrow_up:

tcp/client.go
71.15% <0.00%> (-2.99%)
:arrow_down:

dtls/server/server.go
77.03% <0.00%> (-1.46%)
:arrow_down:

net/dtlslistener.go
69.38% <0.00%> (ø)

udp/client/conn.go
72.92% <0.00%> (+0.55%)
:arrow_up:

net/conn.go
89.06% <0.00%> (+1.56%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Deleted messages (on phone) are restored as well

When running a restore ALL messages with the corresponding label (in my case the default SMS) are restored onto the device. Even when they have been previously deleted on the phone.
The optimal solution in my eyes would be something like this:
When a SMS is deleted on the phone add a deleted label to the backed up SMS in Gmail.
On restore on the messages without the deleted filter would be restored.
A first step could be that a label could be specified that is then used to filter out the messages. This label had to be applied manually in gmail.
In general this issue arises since I pretty much never deleted any messages. Often they contain business relevant information, even though I do not have to access that information every day.

Hello,
It is a very old issue but I have a little question:
If I delete messages SMS on my phone and then I restore all messages with SMS Backup+: all is restored, including the deleted message: ok.
But today I tried to delete messages on my Gmail backup, and then I did a restore: I hoped I would have the "cleaned" version of my messages but the deleted messages are always here.
I think it is because the SMS phone database hasn't been deleted before the restoration? Am I right?
If yes, should I delete it manually (if possible), before the restoration, or do you have any other recommendations?
What I would like is to clean my message by deleting which I don't want anymore. I found doing the cleaning on Gmail (or Thunderbird), easier, but is it possible?
Thanks


Avoid putting function declarations in .then()

Example
d3.xml(data).then((document) => {
   ...

    node = node.data(nodes).enter().append("circle")
      .attr("r", 20)
      .attr("fill", nodeColor)
      .on("mouseover", function(d) {
        div.transition()
            .duration(100)
            .style("opacity", .9);
        div.html( "
Div Title
"... )
            .style("left", (d3.event.pageX) + "px")
            .style("top", (d3.event.pageY - 50) + "px");
      })

Why is this an issue?
There are several anonymous functions written in .then(), after the d3.xml promise. This is bad practice for several reasons:

Using inline, anonymous functions make your code hard to read and understand for others.

These function declarations now depend on the d3.xml promise. In other words: if the XML-data somehow fails to be loaded, these functions won't be declared either. If you have other code depending on these functions, this code won't work anymore.

It's better to turn anonymous functions into named functions, so they can be re-used later without having to copy code. DRY coding is happy coding! 😉

What's a better option?
Use named functions that you can reuse. Declare these functions in the destined section of the code, and call them by their name when you need them anywhere else in your code.
d3.xml(data).then((document) => {
   ...

    node = node.data(nodes).enter().append("circle")
      .attr("r", 20)
      .attr("fill", nodeColor)
      .on("mouseover", showDetailsPopup)
}

// Functions declarations
function showDetailsPopup() {
    div.transition()
        .duration(100)
        .style("opacity", .9);
    div.html( "
Div Title
"... )
        .style("left", (d3.event.pageX) + "px")
        .style("top", (d3.event.pageY - 50) + "px");
}

This commit Fixed the issue.


Fix storage.config path issue for runroot

We want to switch back to the old logic and make people to change storage.config for runroot themselves.

We need to make a new PR to add documentation on this behavior

Will do. @dragon512


pre-training with LAION

Hi, thanks for your awesome work.  I have a question about pre-training with LAION 115M dataset.  I found you add more LAION dataset when increasing epochs(https://github.com/salesforce/BLIP/blob/main/data/pretrain_dataset.py#L39). I guess you want to speed up training, am i right? And how many LAION files do you split for 20 epochs. I think if training with full 115M LAION dataset from the beginning, maybe it can get more good results but consumes more days. Look forward your reply, thanks.

Hi, thanks for your question.
As mentioned in our paper (footnote for section 4.1), we split LAION-115M into 5 splits and load one split per epoch. The purpose is indeed to speed up training. I agree that using more data per epoch could further improve result.

Got it. Thanks a lot.


Demo is completely broken - can't log in

Same
ProgrammingError at /
permission denied for relation django_session

Still broken same error


Aggregate pod removal errors at both levels, so everything is best-effort

Please provide a description of this PR:
Follow-on from https://github.com/istio/istio/pull/52320/files/e12db068d33674d333193fcaf468f437348ec264#r1690613692

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
cc7306afcd9de266504c8c166f4c2c570bfd14f0
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test release-notes

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4b0eae0873e557666927a885391700e48a15f51d
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4b0eae0873e557666927a885391700e48a15f51d
link
true
/test unit-tests-arm64

unit-tests_istio
4b0eae0873e557666927a885391700e48a15f51d
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name 	Commit 	Details 	Required 	Rerun command
unit-tests-arm64_istio 	4b0eae0 link 	true 	/test unit-tests-arm64
unit-tests_istio 	4b0eae0 link 	true 	/test unit-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Nice - we had a behavior change and the tests caught it, good.
The test is asserting that if there is a remove error we leave the ambient enabled annotation on the pod - I think this was because since the pod could be in an undefined state, we don't want to "let go" of it.
Whether we actually want to do that or not behaviorally is maybe debatable so I'm going to mimic current behavior here for now - if we have an error removing the pod, we will not un-annotate the pod.

In response to a cherrypick label: #52331 failed to apply on top of branch "release-1.22":
Applying: Aggregate errors so everything is best-effort
Using index info to reconstruct a base tree...
M	cni/pkg/nodeagent/server.go
Falling back to patching base and 3-way merge...
Auto-merging cni/pkg/nodeagent/server.go
CONFLICT (content): Merge conflict in cni/pkg/nodeagent/server.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Aggregate errors so everything is best-effort
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #52334

In response to a cherrypick label: #52331 failed to apply on top of branch "release-1.23":
Applying: Aggregate errors so everything is best-effort
Using index info to reconstruct a base tree...
M	cni/pkg/nodeagent/server.go
Falling back to patching base and 3-way merge...
Auto-merging cni/pkg/nodeagent/server.go
CONFLICT (content): Merge conflict in cni/pkg/nodeagent/server.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Aggregate errors so everything is best-effort
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #52335


Introduce ProcessApplication deployment

Using a ProcessApplication will solve some existing problems:

allow setting servletContextPath = "/" to resolve "embedded.app,..." form keys correctly, see #39
simplify and unify deployment of bpmn/dmn/cmmn resources by using camundas default #53

Also, this allows settings from processes.xml like deleteOnDeploy, useful for devellopment.
To achieve this, we need:

[x] A SpringBootProcessApplication extending  the SpringProcessApplication (we do not need the Servlet variant)
** application provides a servletContextPath property, default ""
[x] We need to register the build process engine to the Container, see https://forum.camunda.org/t/error-when-using-processapplication/500
[x] CamundaBpmProperties get an extra application supproperty to set the processes.xml properties (deleteOndeploy, ...)
[ ] adjust documentation

Moved processes.xml configuration to follow up


[WebChat] Passing user info securely through webchat by using default webchat channel?

SDK Platform:  .NET
SDK Version: 3.11.0
Active Channels: webchat
Deployment Environment: Azure App Service

Hello
I know that the userid information can be passed as a query string parameter to the Bot. But if somebody intercepts the url and changes the user id then that may result into security violation. How can I securely pass user information to bot using webchat.

Answer from @EricDahlvang -

The site that hosts the page with WebChat can exchange the secret for a token before serving up the page itself.  In a .net bot, this can be done with an mvc setup.

I’ve created an example here: https://github.com/EricDahlvang/TokenBotExample
The code that exchanges the secret for a token is as follows:
string botChatSecret = ConfigurationManager.AppSettings["BotChatSecret"];

var request = new HttpRequestMessage(HttpMethod.Get, "https://webchat.botframework.com/api/tokens");
request.Headers.Add("Authorization", "BOTCONNECTOR " + botChatSecret);

using (HttpResponseMessage response = await new HttpClient().SendAsync(request))
{
   string token = await response.Content.ReadAsStringAsync();
   Token = token.Replace("\"", "");
}

Then the view uses the model’s token:

BotChat.App({
directLine: {
token: @Model.Token,
      webSocket: false
});

@neetgupta7 this is similar to if you are passing a security token using HTTP cookie and someone intercept the URL. You can look for the potential solution at https://github.com/Microsoft/BotFramework-WebChat/issues/840. Thanks!


Create External Holdings at Risk widget

epic: #18

comment from @ashachaf
consider updating the flow:
maintain a list of all pool tokens (taken on chain) for supported portals (currently uniswap v2 and sushiswap)
search if the connected wallet has any of these pool tokens
check apy.vision api
IF exist there -> bring the imp loss value
ELSE -> indicate "at risk"
USD value can always be calculated based on the "known" token in the pool and multiple by 2. (for example, ETH/CCC, if we know the ETH value and not CCC, we can use the ETH->USD rate we have in our system)


Fix typo

I'm going through these tutorials now. Thanks so much for creating these! They are great


Problem deploying

The process bombs out when I run 'vagrant up' inside my local ansible8env directory (which I cloned today). It only gets as far as creating the rhce8env_repo box (presumably incomplete),  and this is the output I get:
repo:   Downloading https://files.pythonhosted.org/packages/ca/31/b88ef447d595963c01060998cb329251648acf4a067721b0452c45527eb8/pip-21.2.4-py3-none-any.whl (1.6MB)
repo: Installing collected packages: pip
repo: Successfully installed pip-21.2.4
repo: Collecting pexpect
repo:   Downloading pexpect-4.8.0-py2.py3-none-any.whl (59 kB)
repo: Collecting ptyprocess>=0.5
repo:   Downloading ptyprocess-0.7.0-py2.py3-none-any.whl (13 kB)
repo: Installing collected packages: ptyprocess, pexpect
repo: Successfully installed pexpect-4.8.0 ptyprocess-0.7.0
repo: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
repo: Collecting ansible
repo:   Downloading ansible-4.5.0.tar.gz (35.5 MB)
repo: ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device: '/tmp/pip-install-pc8ssms0/ansible_26333633eb0c4eb095af1a425b8b0e70/ansible_collections/ansible/utils/tests/integration/targets/get_path/tasks/include/examples_lookup.yaml'
repo:
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

Known issue with the vagrant image. SSH into the repo box and delete the EMPTY file under root / dir, then rerun 'vagrant up'


potential logo?

Hey! I haven't had time to write a schema, but I did have a couple of minutes to whip up this logo.

:100:  I struggled on the train to come up with something, and this is it :)
I added you as a collaborator - feel free to add it as you want to the site!

Okay, I added a few things here:

the logo (and favicon) to the website. see screenshot below
a .env.example template
a quickstart to the readme
the logo on the readme

Just want to doublecheck with you before I merge this branch.

awesome - :shipit:


setup.py installation issue (missing version.py)

When attempting to install this package, the following error is received. There seems to be an issue with the reference when looking for the version.py file. Unusually enough, I was able to install it on my macos just fine, but install on a linux server (Ubuntu) fails. This is an amazing project and any help would be greatly appreciated.
`user:~$ pip install py-AutoClean
Defaulting to user installation because normal site-packages is not writeable
Collecting py-AutoClean
Using cached py-AutoClean-1.1.2.tar.gz (10.0 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [6 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/tmp/pip-install-dur0zqvq/py-autoclean_38a9561f558e44998731363c207c9b15/setup.py", line 9, in
exec(open('autoclean/version.py').read())
FileNotFoundError: [Errno 2] No such file or directory: 'autoclean/version.py'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.`

Hi @rroline,
Thanks a lot for your feedback!
I fixed this issue in the new release v1.1.3. Now the version.py file dependency is completely removed, so there should be no more issues coming up with that.
Again thanks and all the best
Elise

Hi @rroline, Thanks a lot for your feedback! I fixed this issue in the new release v1.1.3. Now the version.py file dependency is completely removed, so there should be no more issues coming up with that. Again thanks and all the best Elise

You are a rockstar! Thank you so much! This is such a great project - I just couldn't stand to not use it. Appreciate the responsiveness and willingness to help!


docs: add latest version number to doc landing

Add the npm version badge to the documentation landing page.

Coverage remained the same at 88.578% when pulling<PHONE_NUMBER>07ebcd097619307f9385f3069678d4 on abutterworth/add-version-to-landing into 008292812e0eda89d10be7fb206954f21ec13589 on master.

:tada: This PR is included in version 11.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Run CI with frozen-string-literals enabled

As mentioned in #590 and should probably also be applied to simplecov-html. I'm not 100% sure if we should just run all 2.4+ with this seeting or if we should run 2.4 with both. As we also CI against 2.3 etc. without the setting it should be ok though.
@pat mentions how to do this:

I would recommend adding the following to your .travis.yml file to ensure regressions aren't introduced:

before_script:
- if (ruby -e "exit RUBY_VERSION.to_f >= 2.4"); then export RUBYOPT="--enable-frozen-string-literal"; fi; echo $RUBYOPT

This will add the flag when the tests are run on MRI 2.4 or newer (while the feature was introduced in 2.3, it doesn't seem to work reliably until 2.4). However, at this point in time for the tests to pass, you'll need to use the latest RSpec commits, along with submitted patches to simplecov-html, test-unit, and parser (for rubocop):

https://github.com/colszowka/simplecov-html/pull/56
https://github.com/test-unit/test-unit/pull/149
https://github.com/whitequark/parser/pull/354

Regarding the dependencies: obviously, simplecov-html is now sorted (at least in git), and test-unit's 3.2.5 release is frozen-string-literal friendly as well.
Parser is trickier, as it depends on racc, which isn't yet happy about frozen string literals. There are existing PRs there (made in January), but the test suite isn't green and I've not been able to figure out why.
https://github.com/tenderlove/racc/pull/80
https://github.com/tenderlove/racc/pull/81

We enforce the pragma comments on freezing strings so I believe this is good enough as we make sure it works for our project.


I'm having real trouble getting chameleon to actually do anything.

Hi,
The config is as follows:

#global settings
pid_dir: '~/.pg_chameleon/pid/'
log_dir: '~/.pg_chameleon/logs/'
log_dest: file
log_level: info
log_days_keep: 10
rollbar_key: ''
rollbar_env: ''
#type_override allows the user to override the default type conversion into a different one.
type_override:
"tinyint(1)":
override_to: boolean
override_tables:
- "*"
#postgres  destination connection
pg_conn:
host: "localhost"
port: "5432"
user: "developer"
password: "my_pg_password"
database: "move_uat"
charset: "utf8"
sources:
mysql:
db_conn:
host: "<IP_ADDRESS>"
port: "3306"
user: "developer"
password: "my_mysql_password"
charset: 'utf8'
connect_timeout: 10
schema_mappings:
public: public
skip_tables:
grant_select_to:
- developer
lock_timeout: "120s"
my_server_id: 1
replica_batch_size: 10000
replay_max_rows: 10000
batch_retention: '1 day'
copy_max_memory: "300M"
copy_mode: 'file'
out_dir: /tmp
sleep_loop: 15
on_error_replay: continue
on_error_read: continue
auto_maintenance: "disabled"
gtid_enable: No
type: mysql
The commands I issue:
chameleon create_replica_schema
chameleon add_source --config default --source mysqlprovided in config yml
chameleon init_replica --source mysql
The response:
Init replica process for source mysql started.
When I issue the command: chameleon start_replica --source mysql
The response is : The replica process is already started or is syncing. Aborting the command.

You have to wait for the init replica to finish. Can you please run init replica with - -debug and post the output?
Thanks

root@FO-PGSQL01:~/.pg_chameleon/configuration# chameleon init_replica --debug
2018-08-16 10:40:41 MainProcess DEBUG pg_lib.py (617): Changing the autocommit flag to True
You must specify a source name with the argument --source
After this, I supplied the --source option as requested, and this is what follows:
root@FO-PGSQL01:~/.pg_chameleon/configuration# chameleon init_replica --debug --source mysql
2018-08-16 10:41:27 MainProcess DEBUG pg_lib.py (617): Changing the autocommit flag to True
2018-08-16 10:41:27 MainProcess DEBUG pg_lib.py (617): Changing the autocommit flag to True
2018-08-16 10:41:27 MainProcess DEBUG mysql_lib.py (1328): starting init replica for source mysql
2018-08-16 10:41:32 MainProcess DEBUG pg_lib.py (617): Changing the autocommit flag to True
2018-08-16 10:41:32 MainProcess DEBUG pg_lib.py (3029): Collecting schema mappings for source mysql
2018-08-16 10:41:32 MainProcess INFO pg_lib.py (1843): deleting all the table references from the replica catalog for source mysql
Traceback (most recent call last):
File "/usr/local/bin/chameleon", line 5, in
exec(compile(open(file).read(), file, 'exec'))
File "/usr/local/bin/chameleon.py", line 58, in
getattr(replica, args.command)()
File "/usr/local/lib/python2.7/dist-packages/pg_chameleon/lib/global_lib.py", line 327, in init_replica
self.__init_mysql_replica()
File "/usr/local/lib/python2.7/dist-packages/pg_chameleon/lib/global_lib.py", line 337, in __init_mysql_replica
self.mysql_source.init_replica()
File "/usr/local/lib/python2.7/dist-packages/pg_chameleon/lib/mysql_lib.py", line 1335, in init_replica
self.__build_table_exceptions()
File "/usr/local/lib/python2.7/dist-packages/pg_chameleon/lib/mysql_lib.py", line 202, in __build_table_exceptions
limit_tables = self.source_config["limit_tables"]
KeyError: 'limit_tables'

Hi Federico,
Thanks to your suggestion above I was illuminated by the debug statements to finally figure out the various stumbling blocks.  I'm having a timeout issue on large data, but I'll deal with that.  Thank you for your help.  The replicator is now working until it reaches too-big data.

you are using python 2.7. this system is compatible with python 3.3+ only. I suspect you downloaded the old version 1.8 which I'm no longer developing.

I suppose you were able to make it work. I'm closing the ticket


✨ Added some angular exercises 🙅🏻

Signed-off-by: Jonas Reitmann<EMAIL_ADDRESS>

@ummahusla, I adopted the new structure and added some new exercises. Hope it fits your needs. :)


feat: implement firebase analytics provider

@bweissbart The ignoring of node_modules in webpack.config.js doesn’t work with build:storybook. Maybe someone could help me and suggest something to solve this issue?

@romaniukua - since RN Firebase has native dependencies, we'll have to create a .web version of the Analytics provider that basically stubs out the methods with no-ops instead. Place in the same folder as your existing provider:
FirebaseProvider.web.ts
// tslint:disable-next-line:no-implicit-dependencies
// import firebase, { ReactNativeFirebase } from '@react-native-firebase/app';
// tslint:disable-next-line:no-implicit-dependencies
import AnalyticsProviderConfiguration from '../types/AnalyticsProviderConfiguration';

import AnalyticsProvider, {
  App,
  Checkout,
  CheckoutAction,
  ClickGeneric,
  ContactCall,
  ContactEmail,
  Generics,
  ImpressionGeneric,
  ImpressionProduct,
  LocationDirections,
  Product,
  ProductAction,
  Promotion,
  Screenview,
  SearchGeneric,
  Transaction,
  TransactionAction,
  TransactionRefund
} from '../AnalyticsProvider';

export interface FirebaseAnalyticsProviderConfiguration {
  appId: string;
  apiKey: string;
  authDomain: string;
  databaseURL: string;
  projectId: string;
  storageBucket: string;
  messagingSenderId: string;
  measurementId: string;
}

export default class FirebaseAnalyticsProvider extends AnalyticsProvider {
  configuration: FirebaseAnalyticsProviderConfiguration;
  client: null;

  constructor(commonConfiguration: AnalyticsProviderConfiguration,
              configuration: FirebaseAnalyticsProviderConfiguration) {
    super(commonConfiguration);
    this.configuration = configuration;
    this.client = null;
  }

  async asyncInit(): Promise<void> {
    console.warn('Firebase Provider currently not supported on web');
  }

  addProduct(properties: Product): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  checkout(properties: Checkout, action: CheckoutAction): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  checkoutOption(properties: Generics, action: CheckoutAction): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  clickGeneric(properties: ClickGeneric): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  clickProduct(properties: Product, action?: ProductAction): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  clickPromotion(properties: Promotion): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  contactCall(properties: ContactCall): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  contactEmail(properties: ContactEmail): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  detailProduct(properties: Product, action?: ProductAction): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  impressionGeneric(properties: ImpressionGeneric): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  impressionProduct(properties: ImpressionProduct): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  impressionPromotion(properties: Promotion): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  lifecycle(properties: App): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  locationDirections(properties: LocationDirections): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  pageview(properties: Screenview): void {
    // do nothing
  }

  purchase(properties: Transaction, action: TransactionAction): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  refundAll(properties: Generics, action: TransactionAction): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  refundPartial(properties: TransactionRefund, action: TransactionAction): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  removeProduct(properties: Product): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  screenview(properties: Screenview): void {
    console.warn('Firebase Provider currently not supported on web');
  }

  searchGeneric(properties: SearchGeneric): void {
    console.warn('Firebase Provider currently not supported on web');
  }
}

@bweissbart Thanks) Done


Resolved Bug : Cancel button height changed

Description
cancel button height issue resolved from input-group.css
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Save Cancel button height issue still exist on stage.


Fix offset on doughnut charts

Fix https://github.com/chartjs/Chart.js/issues/10465
Adding another half offset can fix the cropped graphics error.
Reproducible sample
I use the examples that doc-code-hub gave in the issue
https://stackblitz.com/edit/web-platform-dr6rsv?file=js%2Fdata.js,index.html

Do you think the solution is correct, or should I look for a different one?

@Zivangu9 sorry, I didn't have internet yesterday
I think I understand where this is coming from. Would it be possible to add a test for the 2 arcs that are each 180 degrees? I'd be curious to see how this performs

I was testing with two 180 degree arcs and now I understand a little better.
The center offset is always 1/4, but the radius increment is 1/2 for 180 degree arcs, so when it's 2 180 arcs it's just 1.5 offset. When it is only one arc greater than 180 it becomes 1.25. And if there are no arcs greater than 180, the increment is 1 offset.

It almost looks like the angle changes should only apply to arcs that are not 180 degrees exactly.

There is a jump at the end of the animation, when the arcs reach 180 degree circumference. That is another problem.
I think a proper fix would be getting rid of this kind of condition in the arc element.

I experimented a little with it.
Replaced
https://github.com/chartjs/Chart.js/blob/7432b609c487e1b17c8000fe9f94c58fa65936b8/src/elements/element.arc.js#L340-L342
with
      const fix = 1 + Math.sin(-Math.min(PI, circumference));
      radiusOffset = offset / 2 * fix;

to make the animations smooth for large arcs. @etimberg any thoughts?
https://stackblitz.com/edit/web-platform-ayr13m?file=js%2Fdata.js

I experimented a little with it. Replaced
https://github.com/chartjs/Chart.js/blob/7432b609c487e1b17c8000fe9f94c58fa65936b8/src/elements/element.arc.js#L340-L342
with
      const fix = 1 + Math.sin(-Math.min(PI, circumference));
      radiusOffset = offset / 2 * fix;

to make the animations smooth for large arcs. @etimberg any thoughts?
https://stackblitz.com/edit/web-platform-ayr13m?file=js%2Fdata.js

The animation in that version looks really good 👍

That seems like a better solution to the problem, do I make the changes in the PR?

sorry if I'm jumping in the thread. Issue #10220 was addressing the issue about hover offset (similar of the offset one).
I didn't check the PR in deep, but I was thinking if make sense to address hoverOffset option and not only the offset one.

@stockiNail probably the same issue.

Since this can drastically change how some charts are shown I am not sure if this should be considered a bug fix or a breaking change

That is true, but since we want to start working on V4 after 3.9 I think it will be the safer option to postpone it till V4

Fair, if we aim to get a 3.9 out quickly this won't have to sit around for a while


LineEdit with clear button: clear button is rendered over existing content

Godot version:
3.1.stable.official
OS/device including version:
Mac OS High Sierra (latest)
Issue description:
Add a LineEdit control to a scene and set clear button to true. Next, enter a default text for the control or just leave it empty.
Steps to reproduce:
Run the project. Now enter some text that will fill up all of the available space.
As you can see, the clear button will be rendered over the available content, making it difficult to be recognised by the user.

I think that a suitable solution for this problem would be to internally split the LineEdit into two components, contained in a for example horizontal box container or even grid container, what do you think?

I have to reopen this as the fix does not include the adjustment of ofs_max in the handling code for the NOTIFICATION_DRAW notification, but only the compensation for the scroll window.
There, ofs_max must be reduced by the width of the icon as well, e.g.
insert before line 725
724:   }
   ofs_max -= r_icon->get_width();
725: }

Without this correction, the clear button still gets drawn over the text, or rather the other way around as the text will be drawn last.

@akien-mga issue has only partly been fixed, see previous comment

@YeldhamDev FYI -> issue is not completely fixed, see previous comment.


force:apex:execute does not respect author apex permissions

I have found that using $sfdx force:apex:execute does not respect the author apex permission for the authenticated user.  In my dev org, I created a new user and assigned them the Standard User profile.  I verified that author apex was not assigned to this profile.  I authenticated the CLI with the new user and the ran,
$sfdx force:apex:execute
>insert new Account(Name='Testing Execute Anonymous from the CLI');

This produced the following output
Compiled successfully.
Executed successfully.

50.0 APEX_CODE,DEBUG;APEX_PROFILING,INFO
Execute Anonymous: insert new Account(Name='Testing Execute Anonymous from the CLI');
11:35:23.26 (26519028)|USER_INFO|[EXTERNAL]|0055b00000NFjIt|standard.user@|(GMT-05:00) Eastern Standard Time (America/Indiana/Indianapolis)|GMT-05:00
11:35:23.26 (26550313)|EXECUTION_STARTED
11:35:23.26 (26557012)|CODE_UNIT_STARTED|[EXTERNAL]|execute_anonymous_apex
11:35:23.26 (272277576)|CODE_UNIT_STARTED|[EXTERNAL]|01q0a000000iAMn|AccountTrigger on Account trigger event BeforeInsert|__sfdc_trigger/AccountTrigger
11:35:23.283 (283994883)|CUMULATIVE_LIMIT_USAGE
11:35:23.283 (283994883)|LIMIT_USAGE_FOR_NS|(default)|
  Number of SOQL queries: 0 out of 100
  Number of query rows: 0 out of 50000
  Number of SOSL queries: 0 out of 20
  Number of DML statements: 1 out of 150
  Number of Publish Immediate DML: 0 out of 150
  Number of DML rows: 1 out of 10000
  Maximum CPU time: 0 out of 10000
  Maximum heap size: 0 out of 6000000
  Number of callouts: 0 out of 100
  Number of Email Invocations: 0 out of 10
  Number of future calls: 0 out of 50
  Number of queueable jobs added to the queue: 0 out of 50
  Number of Mobile Apex push calls: 0 out of 10

11:35:23.283 (283994883)|CUMULATIVE_LIMIT_USAGE_END

11:35:23.26 (285053691)|CODE_UNIT_FINISHED|AccountTrigger on Account trigger event BeforeInsert|__sfdc_trigger/AccountTrigger
11:35:23.26 (479177237)|CODE_UNIT_STARTED|[EXTERNAL]|Workflow:Account
11:35:23.26 (786645164)|CODE_UNIT_FINISHED|Workflow:Account
11:35:23.823 (823776158)|CUMULATIVE_LIMIT_USAGE
11:35:23.823 (823776158)|LIMIT_USAGE_FOR_NS|(default)|
  Number of SOQL queries: 0 out of 100
  Number of query rows: 0 out of 50000
  Number of SOSL queries: 0 out of 20
  Number of DML statements: 1 out of 150
  Number of Publish Immediate DML: 0 out of 150
  Number of DML rows: 1 out of 10000
  Maximum CPU time: 0 out of 10000
  Maximum heap size: 0 out of 6000000
  Number of callouts: 0 out of 100
  Number of Email Invocations: 0 out of 10
  Number of future calls: 0 out of 50
  Number of queueable jobs added to the queue: 0 out of 50
  Number of Mobile Apex push calls: 0 out of 10

11:35:23.823 (823776158)|CUMULATIVE_LIMIT_USAGE_END

11:35:23.26 (823848478)|CODE_UNIT_FINISHED|execute_anonymous_apex
11:35:23.26 (823866690)|EXECUTION_FINISHED

I would have expected this to fail if the user did not have the proper permissions to execute anonymous which according to the documentation is Author Apex.

@jhawk-4, Justin thank for reporting this issue.
However, the behavior you are seeing is correct. Executing anonymous apex via the API does not require Author Apex. Please refer to Anonymous Blocks documentation for details.
Please let us know if you have any further concerns.

@jhawk-4, Justin thank for reporting this issue.
However, the behavior you are seeing is correct. Executing anonymous apex via the API does not require Author Apex. Please refer to Anonymous Blocks documentation for details.
Please let us know if you have any further concerns.


Support Kafka client 2.1.0+  Closes #5730

Support Kafka client 2.1.0+

[x] Add a test case for the new plugin, refer to the doc
[x] Add a component id in the component-libraries.yml. NO NEED
[x] Add a logo in the UI repo. NO NEED
[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #5730.
[x] Update the CHANGES log.

Hi @hsoftxl , thanks for you contribution, can you please follow the pull request template(I edited that for you) and check the items so that we can start reviewing, thanks.

testcase
org.apache.skywalking.apm.plugin.kafka.ProducerConstructorPropertiesInterceptor
added change log

@kezhenxu94


migrate non pages components: /activity

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3977   👈

This comment was auto-generated by Graphite.

@wraeth-eth started a stack merge that includes this pull request via Graphite.

@wraeth-eth merged this pull request with Graphite.


Lines missing from coverage report

I would be happy to investigate this and see if I can find the issue but I wasn't sure if I was just implementing this incorrectly.
Here's the html coverage report for my chromewut extension: https://rawgit.com/natedsaint/chromewut/master/reports/coverage.html
As you can see, each class looks good except that the line that contains the method definitions after the first one appear to be cut off. I'm not sure if it's that my code is formatted in such a way it doesn't know how to generate the report, or if there's a config I'm missing, or it's simply a bug.
Let me know if I can be of any assistance.

Updated, confirmed it looks good: https://rawgit.com/natedsaint/chromewut/master/reports/coverage.html
Thanks for the quick response!

Actually, it looks like it is now duplicating lines

I realized it last night right after I commented. Thanks for your diligence. I'll mess around locally now that I've seen where you made the change and see if I have any ideas to help.


Scaling of circles

Hi! Awesome program. I am curious though - the circles representing the haplotypes seem to scale by the diameter of the circle, rather than the area of the circle like how most people are used to seeing haplotype networks. This means that a haplotype with double the frequency is a circle with twice the diameter, but this makes the circle more than twice as large in area, Is there any way of making the circle area, rather than the circle diameter proportional to the frequency of the haplotype?
Many thanks!

Hi
You are right! I really don't know how this never crossed my mind! I already corrected the code in my 'local' repository to compute a radius (d3 needs a radius) of an area which is proportional to the number of haplotypes. However, since I've done other minor changes related with the data download buttons (which are still not working, eventually related with a change in browser security policies) I'll have to check again how git works just to submit this particular modification! This may take a while since I don't use git/github that much.
Best regards
Antonio

Oh yay! Thank you so much Antonio, for fixing it so fast! Looks great and works wonderfully, can't wait to use it on my data. You've saved my PhD - it's so hard finding a program that will make nice looking haplotype networks!


[feature suggestion] Whisper.cpp integration

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2022.11.11 (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
propose optional integration of Whisper.cpp into yt-dlp,
to be able to use its srt output directly for embedding subs.
offline, supports translating other languages to English, alternative to other machine-translated.
tiniest dataset was able to accurately transcribe 20 seconds of English audio (5 sentences, 50 words), in just 6 seconds.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Out of scope


how to get ttl from leaseID?

In clientv3, I Get kv pairs, there is a Lease in KeyValue, how to get ttl from Lease? I did not find the interface to use.

Try https://github.com/coreos/etcd/tree/master/etcdctl#lease-timetolive-leaseid-options?

Closing this since @gyuho provided the correct answer.

@gyuho Is there an api interface?

@YuleiXiao https://github.com/coreos/etcd/blob/master/clientv3/lease.go#L80. You need to use both etcd 3.1 + client 3.1 though.

@xiang90 OK, I need upgrade version. I use 3.0 now. Thanks all of you.


Propel synthesised classes don't understand when they return self

Example:
No accessible identifier \Propel\Runtime\ActiveQuery\Criteria->find
Accessible properties are: __clone,__construct,__toString,_and,_else,_elseif,_endif,_if,_or,add,addAlias,addAnd,addAsColumn,ad
dAscendingOrderByColumn,addCond,addDescendingOrderByColumn,addGroupByColumn,addHaving,addJoin,addJoinObject,addMultipleJoin,ad
dOr,addSelectColumn,addSelectModifier,addSelectQuery,addUsingOperator,aliases,asColumns,buildParams,clear,clearGroupByColumns,
clearOrderByColumns,clearSelectColumns,combine,conditionalProxy,containsKey,createSelectSql,dbName,defaultCombineOperator,doCo
unt,doDelete,doInsert,doReplaceNameInExpression,doSelect,doUpdate,equals,forgeSelectQueryAlias,get,getAliases,getAsColumns,get
ColumnForAs,getColumnName,getComment,getComparison,getCriterion,getCriterionForCondition,getDbName,getGroupByColumns,getHaving
,getJoin,getJoins,getLastCriterion,getLimit,getMap,getNewCriterion,getOffset,getOrderByColumns,getPrimaryKey,getPrimaryTableNa
me,getSelectColumns,getSelectModifiers,getSelectQueries,getSelectQuery,getTableForAlias,getTableName,getTableNameAndAlias,getT
ablesColumns,getValue,groupByColumns,hasJoin,hasSelectClause,hasSelectModifier,hasSelectQueries,hasSelectQuery,hasWhereClause,
having,identifierQuoting,ignoreCase,isIdentifierQuotingEnabled,isIgnoreCase,isSingleRecord,isUseTransaction,joins,keyContainsV
alue,keys,limit,map,mergeWith,namedCriterions,needsSelectAliases,offset,orderByColumns,originalDbName,primaryTableName,put,put
All,queryComment,quoteIdentifier,quoteIdentifierTable,remove,removeAlias,removeSelectModifier,replaceNames,replacedColumns,sel
ectColumns,selectModifiers,selectQueries,setAll,setComment,setDbName,setDistinct,setIdentifierQuoting,setIgnoreCase,setLimit,s
etOffset,setPrimaryTableName,setSingleRecord,setUseTransaction,singleRecord,size,toString,useTransaction

This is technically correct - find() is on the subclass ModelCriteria - but since in fact self was returned, find() is available in context.

This is from FooQuery::create()->add(...)

create() as synthesised claims to return ChildFooQuery which ultimately means FooQuery, which is fine.

     * @return $this|Criteria A modified Criteria object.
     */
    public function add($p1, $value = null, $comparison = null)

Well, that doc is not helping.

Ultimately this is because the class is evaluated with $this being the current class rather than each possible child class.

Well, pretty much the only way to deal with this is...

[ ] Re-evaluate superclasses whenever a subclass is evaluated, using the subclass $this

Naïve substitution after the fact won't correctly detect when a new object of the parent type is explicitly returned; more complex retention of a sense of "return $this" will work for most cases, but in fact this also rubs against a related problem: that the practical return of a subclass method may be completely different to the superclass to the extent allowed by the prototype, and where a superclass method depends on that you'll get a misleading result. In short: at runtime it evaluates in the subclass context, so this needs to evaluate in the subclass context.

(protection aside)

So, this needs to go all the way up, which means that all ancestor classes need to be re-evaluated each time, but they still need to be separate so that parent:: has meaning

[ ] Fix test crash in async mode

So, it looks like what's happening is:

Test A starts (WD is null or appropriate)
Test A loads include from lib (WD is now "lib", but this doesn't break the test)
Test B starts
Test B tries to load from lib -> lib/lib, fails
Test B include expectations fail

Essentially everything on the global context except the WD needs to stay in recursive calls, but should not be present across separate top-level actions

So this comes down to a logic race, where null -> directory happens on test A before test B

You can no longer drop the global context between calls on the same singleton, which fixes this.

It's now:
No accessible identifier \Propel\Runtime\ActiveQuery\BaseModelCriteria->find
Accessible properties are: __clone,__construct,__construct,__toString,_and,_else,_elseif,_endif,_if,_or,add,addAlias,...

I'm not sure if that's better.

This might actually come down to comprehension of "self" via "new self"

Must still be return $this, from the code in BaseModelCriteria.

Ok, it looks like \Propel\Runtime\ActiveQuery\ModelCriteria wants to warm \Propel\Runtime\ActiveQuery\Criteria but can't because \Propel\Runtime\ActiveQuery\BaseModelCriteria has already warmed it

[ ] Fix "Error: No accessible identifier \FF->f; Accessible properties are: ff"

Quite a lot slower, but this is working.


IOS Build issue after upgrade plugin to latest

I upgrade the plugin and run the CI. CI is failed on IOS. I checked manually and it's because of the latest version of this plugin.
Log
 While building module 'FirebaseMessaging' imported from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Headers/Public/
    Firebase/Firebase.h:66:
    In file included from <module-includes>:1:
    In file included from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Target Support
    Files/FirebaseMessaging/FirebaseMessaging-umbrella.h:13:
    In file included from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FirebaseMessaging.h:18
    :
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionH
    elper.h:37:38: warning: 'UNMutableNotificationContent' is only available on
    iOS 10.0 or newer [-Wunguarded-availability]
    - (void)populateNotificationContent:(UNMutableNotificationContent *)content
                                         ^
    In module 'UserNotifications' imported from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionH
    elper.h:22:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Devel
    oper/SDKs/iPhoneOS15.0.sdk/System/Library/Frameworks/UserNotifications.frame
    work/Headers/UNNotificationContent.h:97:12: note:
    'UNMutableNotificationContent' has been marked as being introduced in iOS
    10.0 here, but the deployment target is iOS 9.0.0
    @interface UNMutableNotificationContent : UNNotificationContent
               ^
    While building module 'FirebaseMessaging' imported from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Headers/Public/
    Firebase/Firebase.h:66:
    In file included from <module-includes>:1:
    In file included from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Target Support
    Files/FirebaseMessaging/FirebaseMessaging-umbrella.h:13:
    In file included from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FirebaseMessaging.h:18
    :
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionH
    elper.h:37:1: note: annotate
    'populateNotificationContent:withContentHandler:' with an availability
    attribute to silence this warning
    - (void)populateNotificationContent:(UNMutableNotificationContent *)content
    ^
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionH
    elper.h:38:47: warning: 'UNNotificationContent' is only available on iOS
    10.0 or newer [-Wunguarded-availability]
                     withContentHandler:(void (^)(UNNotificationContent
                     *_Nonnull))contentHandler;
                                                  ^
    In module 'UserNotifications' imported from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionH
    elper.h:22:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Devel
    oper/SDKs/iPhoneOS15.0.sdk/System/Library/Frameworks/UserNotifications.frame
    work/Headers/UNNotificationContent.h:37:12: note: 'UNNotificationContent'
    has been marked as being introduced in iOS 10.0 here, but the deployment
    target is iOS 9.0.0
    @interface UNNotificationContent : NSObject <NSCopying, NSMutableCopying,
    NSSecureCoding>
               ^
    While building module 'FirebaseMessaging' imported from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Headers/Public/
    Firebase/Firebase.h:66:
    In file included from <module-includes>:1:
    In file included from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Target Support
    Files/FirebaseMessaging/FirebaseMessaging-umbrella.h:13:
    In file included from
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FirebaseMessaging.h:18
    :
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/FirebaseMessagi
    ng/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionH
    elper.h:37:1: note: annotate
    'populateNotificationContent:withContentHandler:' with an availability
    attribute to silence this warning
    - (void)populateNotificationContent:(UNMutableNotificationContent *)content
    ^
    2 warnings generated.
    2 warnings generated.
    ../../../../dev/flutter/.pub-cache/hosted/pub.dartlang.org/webview_flutter-2
    .3.1/lib/src/webview.dart:432:7: Error: The non-abstract class
    '_PlatformCallbacksHandler' is missing implementations for these members:
     - WebViewPlatformCallbacksHandler.onUrlChanged
    Try to either
     - provide an implementation,
     - inherit an implementation from a superclass or mixin,
     - mark the class as abstract, or
     - provide a 'noSuchMethod' implementation.

Temp solution: downgrade plugin to 1.0.7

Thank you for reporting 🙇 I will take look tomorrow!

@bhanuka96 I tried to compile the example and a private project that uses the library. Both compiled without any issue on iOS. Also your error log doesn't mentioned the library with any word, I assume the error is hidden somewhere else on your side :(


[Feature Request] Plugin to remove CSS variables

CSS variables are supported by web browsers so if an SVG that uses CSS variables is displayed in a browser, it will look fine. However, if the SVG is given to an SVG editing program (like Inkscape for example), the stylesheet won't be parsed (because of the --). CSS variables aren't part of standard SVG. They're an extension provided by web browsers.
Removing CSS variables while still ensuring that the resulting SVG looks the same is not a trivial task (unless there's a similar feature in SVG that I'm not aware of). It will make the resulting file larger but also make it more compatible with programs that aren't web browsers. I'm currently in the process of doing this by hand and it would be awesome if there was a tool that did it for me!

@Kerndog73: postCSS comes to mind, the SVG styles could be just passed to it for processing.
CSS variables in inline styles are possible, too, so these have to be interpolated, too (even before using postcss on the external/element styles).

@strarsis Looks good! This sort of thing probably doesn’t make sense for svgo because CSS variables are just a way of avoiding a big copy-and-paste in hand-written SVGs. Editors don’t use them.


Refactor Loader interface

The Loader interface adds New(root) -> Loader method to clone new Loaders
The factory becomes an internal implementation of loaderImpl
Removes fakefileloader, since we can just create a loader with a fake filesystem.
TODO: Implement better filepath calculation

Somebody changed the tide configuration? This should have been merged already ...

I didn't change that.
@apelisse Where can I find the tide config for our repo?

I'm looking at it, but it's completely different from what we had before. They refactored everything I think :-)

https://github.com/kubernetes/test-infra/blob/master/prow/config.yaml#L79-L80
OK. This PR doesn't have the CL label. I don't know if the label is missing, or if we should remove this constraint.

@apelisse Why the bot doesn't automate the CLA process for us?

Maybe it missed a hook and didn't apply the cla label. I don't know. I can't generalize out of this one event :-)


JBPM-5970: Adjust table height to display the configured number of rows

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

ok to test

jenkins retest

@ederign Test added


Game logic

Pac-man eats food.
The score is updated.
Ghosts can move in random directions
If the Pacman collides with a ghost, the game is ended.
Note: This requires refactoring & optimization.

@shivangg Please let me finish the work which I am doing. You can do the refactoring later. Dont refactor while I am working on it.


Set self.app in init_app()

fix init_app lazy not work

Changes like this have been rejected several times now because it is against the Flask extension guidelines. See #319 #360 and #195 for details


[BUG] Blog Posts After the Year 2022 Are Not Processed

Describe the bug
When creating a blog post that is after the year 2022, the site doesn't build a page for that post. However, no error is outputted to the logs, and this could also be my error.
To reproduce
Steps to reproduce the behavior:

Go to content/en/blog/
Write a blog post with any year after the year 2022.
Go to Blog or Tags page on website
No page is listed for that post

Log file
No error is outputted, only the following:
Change detected, rebuilding site.
2023-02-10 11:43:45.013 -0700
Source changed WRITE         "[REDACTED]/content/en/blog/2023/lorum-ipsum.md"
Total in 59 ms

Environment (please complete the following information):

Host OS: Ubuntu 22.10
Node version: node v18.7.0
Hugo version: hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended linux/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio
Browser: Version 109.0.5414.119 (Official Build) (64-bit)

This is an awesome project and Hugo theme, and I hope to make it better!

Great to hear your like the theme. Looking at your example, it appears you would like to list content for a specific year. By design, Hinode lists all content within the same section, regardless of any subfolders. So the url /blog would list all blog posts. The order can be specified in the list configuration.
Pending on your intent, you might want to revise the permalink configuration. For example, you could add the following code to config/_default/config.toml:
[permalinks]
    blog = '/:year/:month/:title/'

If you still intent to create a subfolder 2023, you should make sure it is configured as a list page. Add a file _index.md to the 2023 folder, for example with the following content:
---
author: Mark Dumay
title: Blog
---

You would still need to create a custom list page template in layouts/_default though.

I'm closing the issue for now, let me know if you'd like to reopen it.


Example for Google Optimize CSS Delivery

Hello, please add example for google recommend optimize css delivery as here : https://developers.google.com/speed/docs/insights/OptimizeCSSDelivery
I need use two separate css file , one for critical.css and second for non-critical.css.
critical.css render as minifi  to Head and non-critical.css would be loaded asynchronously as

Hello, world!

      <link rel="stylesheet" type="text/css" href="non-critical.css"/>

This is going to be up to you to determine what is "critical" css and what is non critical. I'm not sure this warrants an example though. Importing css files automatically compiles, optimizes and places them where they should be. If you wanted to alter that process, you would need to use some combination of webpack loaders or build hooks.


Brush Tool Can NOT Label one Pixel

We want to draw segmentation using BrushTool, the problem is that the pixel can not be labeled unless the brush scrolls over the center of the pixel, as the following video displays.
https://user-images.githubusercontent.com/17982206/234795004-cd84c715-b2b7-44d4-bab2-34eb8fd98ad2.mp4
When I change the brushSize to 0, the problem disappears.
https://user-images.githubusercontent.com/17982206/234798384-81454abc-a01b-498b-91c8-7ef311aa9676.mp4
We think if the mark of the BrushTool was fixed to be aligned to the pixel, it will be much more convenient. Just like what the ITKSnap did as shown in the following video.
https://user-images.githubusercontent.com/17982206/234798418-c58ad56e-e931-43be-bdc5-61b1ef757843.mp4

interesting finding, I guess I didn't expect our brush to behave that way

Also, the brush tool doesn't work properly when the image orientation is unusual, i.e. oblique orientation.  The pixels on the border which is caused by the orientation correction cannot be colored by the brush tool.


HBASE-22986 Add documentation for hbtop

Add images for documentation of hbtop.

Sure. Will do that.

Thank you! @petersomogyi


TELEWORK: Text updates to TEST version

User Story
A short, simple description of a feature or issue told from the perspective of the user.
“As a form owner I want to tweak some text on the telework form we have been working on in TEST so I can release it before new changes to policy are finalized.”
Tasks
Remove the crossed out sentence from the wording in Section 2.
2. Headquarters Location
The official office location where you work (or would work) when not teleworking and your headquarters location for business travel.
Your supervisor must approve your headquarters location. All travel costs will be calculated from this location. If your headquarters location is outside of your home ministry, approval is required by the hosting ministry’s Facilities Management Unit.
Acceptance Criteria
"If your headquarters location is outside of your home ministry, approval is required by the hosting ministry’s Facilities Management Unit." is no longer in the content of Section 2

Need to sync up with the ODS team
Test the new DMN workflow in PROD

@chriscaldwell-psa could you do this text update so we can look at push this out next Monday?

@Stella-Archer  - All changes finished in dev, just waiting for devs to inform me if its Ok that I upload to  test.

Looks good. Done. [Uploading... image.png]

Opps client had more text changes > nix the line re “all travel costs will be calculated from this location”

@Stella-Archer  - Changes have been made. :)

Thanks @chriscaldwell-psa Looks great - I've run the by Sean G and have an a-ok form them as well

Done & LIVE - closing tix


Update README.md

Fixes #65

What do you think @gitcnd?

Looks way better - I obviously now know what these things are, so my ability to try and remember what it was like when this page was the first one I'd ever seen about this topic is now in play!
You mention "already have" (for USB_VID) - this was (still is) also new to me, so making that maybe link someplace to explain what those are would be useful.  Related ,and probably mandatory - some way for us to search or look those up is needed - how am I supposed to know (for example) if "Freenove" (the possible designer of a board I'm porting now) has such a thing?  Keep in mind that it's super-really-extra-hard to work these things out, when they're new.  It's easy to find "Apple" or "Espressif" because those already exist, so you know you're in the right place when you find it.  If you're looking for something new, you won't find it, so you don't know if you've found where it belongs and it's missing, or, you're looking in the wrong place...
I'm assuming USB_VID is some other thing, right? Not codes defined and stored inside this repo itself?
Also keep in mind that people don't always know how to do PR's - git is massively difficult for experts, and utterly beyond the capabilities of most new contributors... are there ways to make a basic web UI to go with this system?  For the sake of adding one or two lines to some text files, making folks jump through git PR hoops to accomplish that is not the best idea :-)

It's easy to find "Apple" or "Espressif" because those already exist, so you know you're in the right place when you find it. If you're looking for something new, you won't find it, so you don't know if you've found where it belongs and it's missing, or, you're looking in the wrong place...
I'm assuming USB_VID is some other thing, right? Not codes defined and stored inside this repo itself?

I've added a link to the README. https://usb.org/developers has a link to all vendor IDs they've assigned. They administer them.

Also keep in mind that people don't always know how to do PR's - git is massively difficult for experts, and utterly beyond the capabilities of most new contributors... are there ways to make a basic web UI to go with this system? For the sake of adding one or two lines to some text files, making folks jump through git PR hoops to accomplish that is not the best idea :-)

I know. This is a free service and it is expected that git is a skill folks will need to use the ID anyway.


use container - #3479

with https://github.com/vespa-engine/vespa/issues/3479 the sample apps should use container, not container-dev - lets try basic search first, compiles and run unit tests - the doc tests will fail if this breaks - @gjoranv or @bratseth please merge

Thanks!


PDCL-6554 - return empty array when no view decisions for a specific view

Description
The issue is caused because the viewCache promise gets resolved with undefined. I would let viewCache return empty array when there are no decisions for a specific view, rather than returning undefined and then have to check for undefined everywhere we trigger viewCache.getView.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[ ] I have made any necessary test changes and all tests pass.
[ ] I have run the Sandbox successfully.

👏🏻
Nina, is there a test we can add? Can we also search for similar situations in the library and make sure they are covered?

yes, I have added some checks in the current tests and have removed another guard from createViewChangeHandler.js.


Test_openjdk8_j9_sanity.external_x86-64_linux fails No such property: ‘DOCKERIMAGE_TAG’

Platform:
xLinux
Build fails: https://ci.adoptopenjdk.net/job/Test_openjdk8_j9_sanity.external_x86-64_linux/255/console
[Pipeline] // parallel
[Pipeline] End of Pipeline
Also:   hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: ‘DOCKERIMAGE_TAG’ for class: WorkflowScript
Also:   hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: ‘DOCKERIMAGE_TAG’ for class: WorkflowScript
Also:   hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: ‘DOCKERIMAGE_TAG’ for class: WorkflowScript
hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: ‘DOCKERIMAGE_TAG’ for class: WorkflowScript

I have updated that job to use a DOCKERIMAGE_TAG default value of "ubuntu" which should address this problem (as DOCKERIMAGE_TAG is now an expected parameter to all external test jobs).
Can monitor the next run to see that its resolved.

Possibly related failure on jdk11: https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.external_x86-64_linux_openliberty-mp-tck/304/consoleFull
02:06:30  /home/jenkins/workspace/Test_openjdk11_j9_sanity.external_x86-64_linux_openliberty-mp-tck/openjdk-tests/TKG/../external/external.sh --run --tag  --version 11 --impl openj9 --dir openliberty-mp-tck --reportsrc /testResults/surefire-reports --reportdst "/home/jenkins/workspace/Test_openjdk11_j9_sanity.external_x86-64_linux_openliberty-mp-tck/openjdk-tests/TKG/../TKG/test_output_15861351898577/openliberty_microprofile_tck_0" --docker_args  ; \
02:06:30  	if [ $? -eq 0 ] ; then echo ""; echo "openliberty_microprofile_tck_0""_PASSED"; echo ""; cd /home/jenkins/workspace/Test_openjdk11_j9_sanity.external_x86-64_linux_openliberty-mp-tck/openjdk-tests/TKG/..;  else echo ""; echo "openliberty_microprofile_tck_0""_FAILED"; echo ""; fi; \
02:06:30  	/home/jenkins/workspace/Test_openjdk11_j9_sanity.external_x86-64_linux_openliberty-mp-tck/openjdk-tests/TKG/../external/external.sh --clean --tag  --version 11 --impl openj9 --dir openliberty-mp-tck; } 2>&1 | tee -a "/home/jenkins/workspace/Test_openjdk11_j9_sanity.external_x86-64_linux_openliberty-mp-tck/openjdk-tests/TKG/../TKG/test_output_15861351898577/TestTargetResult";
02:06:30  Unable to recognize DOCKER_OS from DOCKERIMAGE_TAG = --version!
02:06:30  Unable to find image 'adoptopenjdk-derby-test:11-jdk-ubuntu-openj9-full' locally
02:06:31  docker: Error response from daemon: pull access denied for adoptopenjdk-derby-test, repository does not exist or may require 'docker login'.
02:06:31  See 'docker run --help'.
02:06:31
02:06:31  openliberty_microprofile_tck_0_FAILED

Updated jdk11 now in the same way jdk8 updated (I see that the jdk8 "no such property" failure has resolved, will await to see jdk11 resolved, then close this issue).

Should be addressed by https://github.com/AdoptOpenJDK/openjdk-tests/pull/1782

Looks like this is resolved. https://ci.adoptopenjdk.net/job/Test_openjdk8_j9_sanity.external_x86-64_linux/315/ is unstable but not for this reason


Very very long... How I can increase speed?

I use TreeTaggerWrapper and russian.par model.
But I need wait at least 3 seconds for find 100 lemm!!!
My PC can caluclate 2.7*10^9 operation per seconds, but I got only 100 words per 3 second!
Can I change something for speedup?
Sorry for my English.

Starting up takes a while. The question is: how long does it take to process a single long text? If you process many small texts, make sure you re-use the TreeTaggerWrapper and do not create a new one every time.

@reckart I'm don't create a new every time. My code:
`System.setProperty("treetagger.home", Util.basePath + "/TreeTagger");
TreeTaggerWrapper tt = new TreeTaggerWrapper<>();
try {
StringStringMap ssm = new StringStringMap();
        tt.setModel(modelPath + ":" + encoding);
        logger.info("model are read");
        AtomicInteger ai2 = new AtomicInteger();
        tt.setHandler((token, pos, lemma) -> {
            if (ai2.incrementAndGet() % 10_000 == 0) logger.info("ai={}", ai2.get());
            if (!token.equals(lemma)) ssm.put(new LightString(token), new LightString(lemma));
        });
        logger.info("start process");
        tt.process(words);
        logger.info("end process. try write result");
        ssm.write(Util.basePath + "lemmtt4j.ssm");
        logger.info("OK");
    } finally {
        tt.destroy();
    }`

There is a large-volume unit test in DKPro Core which uses TT4J to run TreeTagger. On my machine, this test generates document with 4249999 characters and 1250000 tokens and it takes around 12 seconds to process it using a TreeTagger model for English.
Have you tried commenting out your ssm lines to see if your slowness is really from TreeTagger and not from you own code?


The Select component shows outdated docs.

Change Type
Correction
Proposed Changes
The docs for select show invalid usage of the component.
I added the select component with the CLI but there is no exported type for Select.Value like suggested in the usage. I checked the repo. The previous version does include it but not the next version
New version without the Value type: https://github.com/huntabyte/shadcn-svelte/blob/next/sites/docs/src/lib/registry/new-york/ui/select/index.ts
Old version that includes it https://github.com/huntabyte/shadcn-svelte/blob/main/sites/docs/src/lib/registry/new-york/ui/select/index.ts

Was actually about to open a P.R fixing this. Should be only one line removed.

Cool I was just about to use it, but didn't know how it worked.
After some thinkering I saw that type is no longer required, but I thought it was broken.


GitPitch 4.0 - deprecated syntax -> "Upgrade Guide" link is broken

Describe the bug
The link describing deprecated syntax / "upgrade guide" is broken : https://docs.gitpitch.com/#/upgrading-to-40
--> Page Not Found
To Reproduce
Try opening "https://gitpitch.com/markustiede/about/master?p=slides/intro" -> click "GitPitch 4.0 Upgrade Guide" link
Expected behavior
Clear migration path is shown.
Browser (please complete the following information):

Safari

Operating System (please complete the following information):

MacOS

Additional context
It's quite sad that (IMHO) instantly all of my presentations broke (due to unknown / unclear reasons); without being able to fix them.

Hi Markus,
First, thanks for reporting this problem. Just FYI I announced I was testing new software on gitpitch.com yesterday on Twitter, see here.
The fact that your slide deck is being blocked today is a bug in that new software. It is not intentional. And now that you have brought this to my attention I will investigate. Also that link is to docs that have not yet been published.
Anyway, once I understand the reason your deck is not rendering I will update this thread. Thanks for your patience.
David

Btw, you mentioned that all your presentation broke. Can you provide links to one or two more examples of broken presentations so I can use them for testing. Thanks.

Hi David - thanks for the instant feedback and the reference: I've missed that.
Sure - what I've noticed so far:

broken: https://gitpitch.com/baloise/open-source/master?p=docs/slides/baloise-open-day
major difference in rendering: https://gitpitch.com/dinacon/awards/master?p=2020/slides/kickoff

Thanks for the additional links. I'll update here when I know more.

Some more broken ones:

https://gitpitch.com/baloise/open-source/master?p=docs/slides/ch-open-obl-2020-02
https://gitpitch.com/baloise/open-source/master?p=docs/slides/ch-open-obl-2020-08

OK, I've just looked over all the same decks that you shared and they all have one thing in common...none of them are using a PITCHME.yaml file for custom settings. I now have the problem in focus. I will patch, test, and then push a fix and then bump this thread one more time when you can test. More news from me when that's all in place.

OK. A patch is now live on gitpitch.com. Markus can you please re-test your slide decks and let me know how it goes. Cheers, David.

Thanks @gitpitch  - impressive: looks way better / working again: however the font's size is still quite small compared to before.
E.g. this is a screenshot from my intro slide from before:

<--> https://gitpitch.com/markustiede/about/master?p=slides/intro

I guess this problem is no longer covering the broken link :-) - thanks for addressing anyway!

I'll keep this issue thread open and look into the font issue next. Realistically, probably sometime tomorrow or Friday before I can get to this.

@MarkusTiede another update for you here. A further patch has been pushed to gitpitch.com. Can you please test your slide decks one more time and let me know if all issues are now resolved. Thanks, David.

I believe both of the issues reported on this thread (1) deck access and (2) font sizes have been fixed. Closing issue as resolved. If you have additional feedback please feel free to update or even re-open the thread if needed. Cheers, David.

Indeed - I can't tell any difference anymore: everything working again as expected 🙏


Allow sink developers to easily test their transform functions

Is your feature request related to a problem? Please describe.
It's not a problem per say, but sink developers don't have any way to test if their transform function is doing exactly what they want it to do
Describe the solution you'd like
First, we should generate the test data using the filter and transform configuration in their script.js file, they have to run a command like:
apibara test new script.js --num-blocks 100
The generated test data will include:

the filter and transform configuration, to be used to check we're testing against the same script
the raw data got from DNA
the data returned from their transform function

The data will be stored in a JSON file, maybe in the target/ directory
The idea is that, the dev will look at the file and check if that's exactly what he expects to see, if not he should edit the transform function and run again until he gets what he want. Then, that file will be used to test that the transform function is always doing what it's supposed to do, for that the dev will run a command every time he want to make sure his transform function is working as expected:
apibara test check script.js or apibara test check target/test/script-test-case-xxx.json
This will feed the input data to the transform function and assert that it returns the expected output
Describe alternatives you've considered A clear and concise description of
any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature
request here.

I think this is a great idea! A couple of comments:

we should add a way to override the starting block so that devs can generate the data for specific events
maybe new should have a --name option to override the test script name?
tests should go in the tests folder by default, target is often associated with build outputs because of rust
apibara test check maybe should look for all *.json files in tests/ by default?

Ideally, long term we would have a nice cli like insta does.
So the development flow I envision is:
$ tree .
.
└── src
    └── indexer.ts

$ apibara test new src/indexer.ts --name approval
$ tree .
.
├── mkdir
├── src
│   └── indexer.ts
└── tests
    └── approval.json

$ apibara test new src/indexer.ts --name mint
$ tree .
.
├── mkdir
├── src
│   └── indexer.ts
└── tests
    ├── approval.json
    └── mint.json

$ apibara test check
Collecting tests from `tests/`. Found 2.
test approval... ok
test mint... ok

insta's CLI looks great, I think we can make the CLI simpler and have a single test command instead of both test  and check, the command will first check if there is a test with the same name as the script or --name if provided, if so, it runs the input through the transform function in the script and assert the output, if the test does not exist, it creates it and then run it.

OK for the --name argument

tests folder has special treatment in many languages/frameworks, I'd advice to get away from it or at least make a subdirectory

Yeah, I think apibara test (if we go with one command) or apibara test check should run all the tests

I agree with using a single command that either generates a new test case or runs existing tests.
Maybe we can call the folder with tests snapshots/?

snapshots/ is already used by insta.rs, so that'd cause conflicts if we use it alongside and it's not self explanatory for case, I'd go with something like apibara-tests ?