getParameterSync results in Runtime.UserCodeSyntaxError: SyntaxError: Unexpected end of JSON input

This happens on AWS lambda Node 14.x. Running the same code on our ECS service did not result in this error. Not sure exactly what is causing it, but switching to the async call getParameter fixed the error for us, so seems like there is a bug in the sync version of getParameter.
Here's the full stack trace, but it's not very helpful:
{
    "errorType": "Runtime.UserCodeSyntaxError",
    "errorMessage": "SyntaxError: Unexpected end of JSON input",
    "stack": [
        "Runtime.UserCodeSyntaxError: SyntaxError: Unexpected end of JSON input",
        "    at _loadUserApp (/var/runtime/UserFunction.js:98:13)",
        "    at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)",
        "    at Object.<anonymous> (/var/runtime/index.js:43:30)",
        "    at Module._compile (internal/modules/cjs/loader.js:1063:30)",
        "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)",
        "    at Module.load (internal/modules/cjs/loader.js:928:32)",
        "    at Function.Module._load (internal/modules/cjs/loader.js:769:14)",
        "    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)",
        "    at internal/main/run_main_module.js:17:47"
    ]
}

Thought I'd check out the 4.0.0-Beta1 tag since I saw it reworked the sync calls, but alas I got another error:
{
  "errorType": "Error",
  "errorMessage": "internal/modules/cjs/loader.js:888\n  throw err;\n  ^\n\nError: Cannot find module '/var/task/1807'\n    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)\n    at Function.Module._load (internal/modules/cjs/loader.js:730:27)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47 {\n  code: 'MODULE_NOT_FOUND',\n  requireStack: []\n}\n",
  "trace": [
    "Error: internal/modules/cjs/loader.js:888",
    "  throw err;",
    "  ^",
    "",
    "Error: Cannot find module '/var/task/1807'",
    "    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)",
    "    at Function.Module._load (internal/modules/cjs/loader.js:730:27)",
    "    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)",
    "    at internal/main/run_main_module.js:17:47 {",
    "  code: 'MODULE_NOT_FOUND',",
    "  requireStack: []",
    "}",
    "",
    "    at findPort (/var/task/index.js:138794:11)",
    "    at start (/var/task/index.js:138763:16)",
    "    at sendMessage (/var/task/index.js:138864:17)",
    "    at createClient (/var/task/index.js:138904:27)",
    "    at Object.<anonymous> (/var/task/index.js:111186:17)",
    "    at __webpack_require__ (/var/task/index.js:20:30)",
    "    at Object.<anonymous> (/var/task/index.js:82354:24)",
    "    at __webpack_require__ (/var/task/index.js:20:30)",
    "    at Object.<anonymous> (/var/task/index.js:77604:73)",
    "    at __webpack_require__ (/var/task/index.js:20:30)"
  ]
}

This is my code for reference:
    import paramStore from 'aws-param-store'

    const param = paramStore.getParameterSync(key)

I've hit the problem very similar to yours, and I think I know the reason.
Look here: https://github.com/vandium-io/aws-param-store/blob/00c426239376c3b0ec901e971af9fb96c601b96f/lib/param_query.js#L125
What the code tries to do is to spawn another node process and communicate with it over stdin/stdout. Basically, the library tries to run node ssm_sync and read the output. When you run the code locally, there's ssm_sync.js inside node_modules, so it just works. However, webpack has no idea that this file has to be added, and node ssm_sync in lambda just crashes with Error: Cannot find module blah-blah-blah. All that output goes to stderr; stdout is empty. But param_query.js does this: https://github.com/vandium-io/aws-param-store/blob/00c426239376c3b0ec901e971af9fb96c601b96f/lib/param_query.js#L131 without checking for error conditions, and as a result calls JSON.parse() on empty string, which produces exactly the error message we see.


markdownlint also uses node so requires the latest versions

Q
A

Documentation
no

Bugfix
yes

BC Break
no

New Feature
no

RFC
no

QA
no

Description

After merging https://github.com/laminas/laminas-continuous-integration-action/pull/155, https://github.com/laminas/laminas-continuous-integration-action/pull/133 should have passed checks, however it appears that I missed the fact that markdownlint has its own docker stage.
This PR adds the nodesource repositories for the latest versions of node to the install-markdownlint stage also, in order to fix that.

Thanks @internalsystemerror!


Drop 2to3 in setup.py

@efiring I'm not sure of the tests are comprehensive enough to give us 100% confidence on this PR but it was actually quite simple and not a lot of code change to eliminate 2to3.
Closes #399

@WeatherGod anything left to do here? I sent #401 to update the example, following this one, and I have another PR to update setup.py a little bit.


Packages aren't updated

Atom 1.18.0 x64 on Windows 7 x64.
Updating to<EMAIL_ADDRESS>failed.Hide output…
Unable to download https://www.atom.io/api/packages/linter/versions/2.2.0/tarball: unable to verify the first certificate.
The same in updating attempt linter-ui-default to 16.2
The same with other packages too

Thanks for the report!  This might be a better issue for https://github.com/atom/apm, can you re-open this issue there?  When you do, please completely fill out the issue template and share any more details that might be helpful to know (e.g. are you behind a firewall or using a proxy?).


ARROW-7328: [CI] Github Actions should trigger on changes to Github Actions configuration

dumb idea, can we move this into ci/github-workflow and symlink .github there? That would fall under the ci/** rule.

@fsaintjacques The nice thing with the current approach is that changes to a YAML file doesn't trigger unrelated builds, only the builds backed by that YAML file.


flow ls command does not exist in 0.25.0

I downloaded 0.25.0, and it seems the binary doesn't contain ls command

hm, indeed. looks like it landed after the 0.25 release branch was cut but made it into the release notes by mistake. it'll be in 0.26 soon, though!
@gabelevi should/can we edit the release notes?

the release notes look like they were updated and we forgot to close this


Test cluster upgrading on VCD - Test Release KubeOne 1.6

[x] v1.24 -> v1.25
[x] v1.25 -> v1.26

#works


sysfs: return st instead of accepting it

Hopefully, this can help reduce references that escape to heap, but needs to be checked.
@achille-roussel can you quickly check if this is on the right track?

I found that returning a value was a lot better overall, so if this is cool, let's go with it!
$ go test -run='^$' -bench '^Benchmark_pathFilestat/sysfs.DirFS.*$' ./imports/wasi_snapshot_preview1 -count=6 > old.txt
$ benchstat old.txt return-pointer.txt return-val.txt
goos: darwin
goarch: arm64
pkg: github.com/tetratelabs/wazero/imports/wasi_snapshot_preview1
                                          │   old.txt   │        return-pointer.txt         │          return-val.txt           │
                                          │   sec/op    │   sec/op     vs base              │   sec/op     vs base              │
_pathFilestat/sysfs.DirFS_fd=root-12        4.235µ ± 2%   4.146µ ± 1%  -2.10% (p=0.009 n=6)   4.139µ ± 1%  -2.27% (p=0.009 n=6)
_pathFilestat/sysfs.DirFS_fd=directory-12   4.499µ ± 1%   4.460µ ± 1%  -0.86% (p=0.009 n=6)   4.434µ ± 1%  -1.44% (p=0.004 n=6)
geomean                                     4.365µ        4.300µ       -1.48%                 4.284µ       -1.86%

                                          │  old.txt   │         return-pointer.txt         │          return-val.txt           │
                                          │    B/op    │    B/op     vs base                │    B/op     vs base               │
_pathFilestat/sysfs.DirFS_fd=root-12        384.0 ± 0%   384.0 ± 0%       ~ (p=1.000 n=6) ¹   304.0 ± 0%  -20.83% (p=0.002 n=6)
_pathFilestat/sysfs.DirFS_fd=directory-12   416.0 ± 0%   416.0 ± 0%       ~ (p=1.000 n=6) ¹   336.0 ± 0%  -19.23% (p=0.002 n=6)
geomean                                     399.7        399.7       +0.00%                   319.6       -20.04%
¹ all samples are equal

                                          │  old.txt   │         return-pointer.txt         │          return-val.txt           │
                                          │ allocs/op  │ allocs/op   vs base                │ allocs/op   vs base               │
_pathFilestat/sysfs.DirFS_fd=root-12        7.000 ± 0%   7.000 ± 0%       ~ (p=1.000 n=6) ¹   6.000 ± 0%  -14.29% (p=0.002 n=6)
_pathFilestat/sysfs.DirFS_fd=directory-12   8.000 ± 0%   8.000 ± 0%       ~ (p=1.000 n=6) ¹   7.000 ± 0%  -12.50% (p=0.002 n=6)
geomean                                     7.483        7.483       +0.00%                   6.481       -13.40%
¹ all samples are equal

smidge faster changing to pointer receiver for writeFilestat. nice eagle eyes @achille-roussel

Thanks for idea @achille-roussel!


Multiple failed test runs on unstable branch

Describe the bug
E2E are unstable and fail randomly due to different reasons
https://github.com/ChainSafe/lodestar/actions/runs/6544810359/job/17772581931#step:6:4013
@lodestar/beacon-node: ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
@lodestar/beacon-node:  FAIL  test/e2e/network/reqrespEncode.test.ts > reqresp encoder > assert correct handler switch between metadata v2 and v1
@lodestar/beacon-node:  Test Files  1 failed | 15 passed | 7 skipped (23)
@lodestar/beacon-node: CodeError: Transport (@libp2p/tcp) could not listen on any available address
@lodestar/beacon-node:       Tests  1 failed | 93 passed | 84 skipped (178)
@lodestar/beacon-node:    Start at  09:09:32

https://github.com/ChainSafe/lodestar/actions/runs/6517197158/job/17701469723#step:6:4037
@lodestar/beacon-node: ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
@lodestar/beacon-node:  FAIL  test/e2e/api/impl/lightclient/endpoint.test.ts > lightclient api > getOptimisticUpdate()
@lodestar/beacon-node:  Test Files  1 failed | 15 passed | 7 skipped (23)
@lodestar/beacon-node: AssertionError: expected 3 to be 4 // Object.is equality

https://github.com/ChainSafe/lodestar/actions/runs/6517197158/job/17701499293#step:6:1483
@lodestar/beacon-node: Segmentation fault (core dumped)
@lodestar/beacon-node: @lodestar/beacon-node: error Command failed with exit code 139.

Expected behavior
No failures, stable tests
Steps to reproduce
Run E2E on unstable branch
Additional context
No response
Operating system
Linux
Lodestar version or commit hash
unstable (c06f4e5e019df44b640839e65ea385fa39310a18)

Tests are really flaky right now

unit tests fail almost 50% of the time with @lodestar/beacon-node: Segmentation fault (core dumped) (vitest related?)
spec tests consistently run into timeouts (maybe related to running them in parallel)
sim tests fail due to timeout (this was always an issue)
e2e sometimes fail due to invalid assertions (seems to happen since we switched to vitest)

Maybe we should consider setting up a server to run a self-hosted runner?
That should get more consistent test results and have a better debugging story, eg for collecting core dumps, logs, etc.

Maybe we should consider setting up a server to run a self-hosted runner?

That could definitely improve the situation as it is quite noticeable that the CI get less stable if there are multiple concurrent runs

If we can get some metrics about the runner jobs, on how much does it take in terms of cpu/mem during the multiple executions(maybe disk i/o as well if there's any disk writes), it will certainly help on accurately sizing the self-hosted runner.

Closed in favor of https://github.com/ChainSafe/lodestar/issues/6358


Single Page Mode

Can it be used in single page mode?

i have the same problem, how can I make it single page?

you can make it single page by setting a width higher than half of the available width


Generic notification component

Something we can display errors in, such as image encode/decode errors.
A material snackbar would do https://material.io/design/components/snackbars.html#anatomy.

do we want this one to be a web component?

Initially I thought this would just be a preact thing, since the problem is mostly state management and events. But yeah, I guess it could be a custom element. A bit messy without shadow dom though.

Could just use this:
https://material.preactjs.com/component/snackbar

Our snackbar will need to be able to contain buttons. Eg "New version available [refresh]".


Add option to disable multi cursor "spread" paste

When having multi line text in the clipboard and pasting, VS Code will check if the clipboard text line count matches the cursor count, and if it does, it will "distribute" each line to a cursor.

Copy the following text to the clipboard:

Line 1
Line 2
Line 3

Create 3 cursors (to match the line count)
Paste

Add an option to disable this "distributed" paste:

The options is called editor.multiCursorPaste and can have the value spread or full. spread is the default to maintain compatibility with the current behavior.

Hi, seem like spread in Multi Curso Paste does not work any more as of 1.39.2.
Any option behaves like full. Could you please check it?

@rshakerov Can you please open a new issue with precise steps? I have checked and IMHO the spread behaves fine.

@rshakerov Did you solve your issue? @alexandrudima I have the same issue: multiCursorPaste "spread" is not working in 1.39.2 (Windows).

@randre70 Please open a new issue with precise steps.

@rshakerov Did you solve your issue? @alexandrudima I have the same issue: multiCursorPaste "spread" is not working in 1.39.2 (Windows).

Yes, after restarting VS Code it came back to normal.


adding additional object on form submit?

Please excuse my ignorance.
I'm trying to submit a simple form with two different field.
if you want to patch more information from your reducer to the form, what would you do?
should i make additional invisible html field or dynamically patch them to initialValues?
or is there different approach?

I usually prefer to do this with initialValues.

@gustavohenke thanks for sharing your knowledge.
however, i want to attach an metadata object from reducer to initialValues outside of the class like this body.metadata.
how does that exactly work? its definitely mapStateToProps function...

Using initialValues is a pretty good approach for attaching extra data. This could be done in mergeProps if mapStateToProps doesn't make sense in your situation. However, if you could post some sample code, it would be possible to provide a more detailed response.

Okay, so this is pretty much an usage question.
My suggestion (and @pcgilday's as well) is to use initialValues. StackOverflow is usually the best place for this instead of GitHub issue tracker; so please ask there, including some code that demonstrates what you tried and why it didn't work.


Update README.md to mention testing with 1.11

Travis configuration includes 1.11 as well but in the README file it was not mentioned.

[x] The purpose of this PR is explained in this or a referenced issue.
[x] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[x] The PR targets the latest branch.
[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] Apache v2 license headers are included in each file.

Can one of the admins verify this patch?


feat(firestore-stripe-subscriptions): added stripe configuration collection.

Currently shipping_countries must be added in the products collection.
This PR proposes a new location for collection based Stripe configuration.
shipping_countries is now selected from the new config collection and falls back original products collection if config does not exist.

LGTM, just fixed a linter error


Who'd like to take over this module?

Hi folks, I don't use this module any more and am really busy with work / other open source work and this module deserves far better maintainership than I've been giving it.
I'm tagging everyone who's contributed to this module in the past or who has an open PR. I'm willing to give out push access to everyone interested and if one of you would like to take on chief maintenance responsibility for owning the repo + NPM, I'll hand those over to you.
The main work that needs done here is to pick a solution for the array merging issue and release a 1.0.
Thanks.
@nhocki @nrf110 @anthonator @JoeStanton @nileshchavan @kodypeterson @gilbertwat @vvo @gyzerok @vyorkin @substack @SimenB @OscarGodson @rsolomo @phuu

@dadambickford and I may be able to take it over under our Yorkshire Interactive org (https://github.com/YorkshireInteractive/). We're going to release two other modules next week too and trying to do a lot more open source. Which array merge ticket were you talking about? I see 2. I can try to fix the array merge issue and if I can fix it we can take over :)

@OscarGodson and you're the winner! I've made you and @dadambickford collaborators so you can create the PR and merge it. Once that's in, I'll turn over NPM and transfer this repo to you. Thanks!

@kyleamathews which deepmerge array ticket needed to be taken care of?

#22 and #21 and #20 and #18

Is it dead? I was just going to use this but it seems in limbo.

It won't be dead if you decide to maintain it ;-)
deepmerge is a happy healthy puppy just looking for some owners.
On Fri, Mar 18, 2016 at 12:18 PM Kurt Koller<EMAIL_ADDRESS>wrote:

Is it dead? I was just going to use this but it seems in limbo.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/KyleAMathews/deepmerge/issues/25#issuecomment-198504161

I'd need to make sure that @OscarGodson and @dadambickford lost interest, and then I have to decide if I want to take care of a puppy. It seems like a small, low-maintenance puppy.

@KyleAMathews @InsidiousForce @OscarGodson @dadambickford Did you guys figure out anything in regards to finding a maintainer? Recently found a need to use a deep-merge function and would rather help maintain something lightweight rather than compare endlessly or build my own.

Sorry guys, I ended up refactoring this out of my project and am now using a few custom functions I wrote for my specific use case. @SohKai it's all yours if no one else replies.

Another option I've been thinking about is to just deprecate this module and push people to use lodash's merge function which is very similar to this https://lodash.com/docs#merge
Lodash's team is doing a killer job and they have far more eye balls and talent working on these things. Given there recent push for modularization there's not as much point for indie functions like this.
But it's up to you @sohkai. If you want to make a strong push on this and clean things up if be happy to give you the maintainer bit here and on NPM.

@KyleAMathews That's a good point, ever since you could pick and choose your lodash imports there's been less and less reason to maintain these standalone utilities and I guess I forgot to look through there first. I'm leaning towards seconding your thoughts about deprecation as well, seeing how similar _.merge is, although I've noticed these differences when going through the code and using _.merge on this module's tests:

_.merge mutates the first argument; although debatable, I see this as a plus since it's similar to the Object.assign interface that most people are aware of.
_.merge replaces all arrays entirely, requiring _.mergeWith and a custom array merge function to merge them; I see this as an area where this module (or another) might have an opportunity to provide useful defaults and a friendlier API. Note that this module's current implementation can be confusing in regards to #14 (it flip-flops between concating arrays and replacing them depending on where the array is) and notably this line causes subtle differences in regards to handling null or undefined values from sources.

I think in the end, it would be nice if there was a nice wrapper around _.mergeWith that incorporated #14's suggestions for an options parameter that supported regular use cases (but also keeping the option to pass through custom handlers to _.mergeWith), but at that point the changes would be so radical I'm not sure they belong here. At best, maybe under a 1.0 change?

Sorry never answered this. My 2 cents: I am only using lodash.merge theses days if I need it. And if I want to merge array values then a simple customizer function and union or concat will do it.
I would deprecate the module and ask people to use:
import {merge, union} from 'lodash';
var t = merge({}, {arr:[1]}, {arr: [2]}, function(a, b) {
  if (Array.isArray(a) && Array.isArray(b)) {
    return union(a, b);
  }
})

@SohKai let me know in the next couple of days if you want to take over this module and go ahead with your plan. Otherwise, let's just deprecate this on NPM and add your code @vvo to the README + point people to lodash.
Also, relevant https://twitter.com/jdalton/status/754474672977096704

@KyleAMathews Sorry it's taking a bit for me to get back to you about this; I'm planning to have a look through some of the other options to double check how they've been built but in the event none of them just wrap _.merge, I'll take this over and go with what I've mentioned for a 1.0 release.

Had a chance to look through a number of other repos and it seems like they've all chosen to re-implement everything themselves without providing as much flexibility. Sign me up for the work!

Ok! Awesome! Thanks! Down with unmaintained code! I just added you as a contributor here. Once you're ready to make a new NPM release, I'll figure out how to make you a contributor there :-)

Or alternatively, mark it for final release.

Sure, I'd be willing to maintain.
I maintain a good number of small modules like so:

if there's a test and the pull request looks good, I publish right away after merging.  I don't like leaving unpublished code in master.
I don't have a bower account or anything, so I don't publish to there

If that sounds good, then feel free to add me as a contributor on Github and npm.

@TehShrike awesome! Added here on Github — what's your NPM username?

I am tehshrike on npm.

Added you as owner on NPM.

By the way, if anyone's curious, I'm a big fan of the open governance style Rod Vagg describes in this episode of the Changelog podcast.

Me too :-)

I would definitely love to help out maintaining this module, I've found it extremely useful and I want to make sure it remains around for as long as possible.

@macdja38 great Jacob! Added you as a collaborator on Github? What's your NPM username? I'll add you as an owner there as well.

@KyleAMathews same as here macdja38

@TehShrike @macdja38 Thanks for picking up this as well! My original intent was to sprint towards the changes I proposed in https://github.com/KyleAMathews/deepmerge/issues/25#issuecomment-232044909 and close PRs/issues after, but obviously this hasn't happened yet 😣.
With #37, and a lot of good work already done by @TehShrike, my proposed probably don't make sense anymore, since we've got maintainers who would like to keep the current behaviour as-is 😄.
  I'm fine maintaining this module!

@KyleAMathews would you be willing to head over to https://travis-ci.org/profile/KyleAMathews and toggle this repo on?  It looks like since it's a public non-org repo in your name, you'll have to be the one to enable it.  I think that should be all you have to do going forward, though.

@macdja38 added you as owner
@TehShrike activated deepmerge on travis.ci

Closing for now, but if anyone else wants to contribute, post here or ping me anywhere else!

👏👏👏 great work @TehShrike!


Known ordering for RollupCalculateJob records

Hey there, I'm a huge fan of the tool and recommend it to anyone that needs rollups (virtually everyone).
I think there might be a feature missing to ensure there is a known order of records when using the "Calculate" or "Schedule Calculate" feature. It appears that RollupCalculateJob is getting the query locator from RollupService.masterRecordsAsQueryLocator, though I do not see where this is implementing an ORDER BY clause.
If the user were to start a calculation for a rollup, it does not seem that the user should need to wait until that calculation finishes to begin the next rollup (provided the same parent object exists).
If the query returned from RollupService.masterRecordsAsQueryLocator were to use an ORDER BY clause as part of the query string, the order would be predictable, and thus the rollups could be staggered to start by a few minutes.

Is the statement above correct (re: predictable order)?
If so, would you like me to submit a PR with the proposed changes?

I do not think the below solves for this, but figured I'd include it (in the event that it does)
https://releasenotes.docs.salesforce.com/en-us/summer15/release-notes/rn_apex_maps_and_sets_iteration_order.htm

Another resource suggests that there is no guarantee of query result order without the inclusion of an ORDER BY clause in the query string.
https://salesforce.stackexchange.com/questions/7667/soql-result-ordering-in-the-absence-of-an-order-by-clause

Great idea, thanks for sharing! 👍 Marked as enhancement.

My pleasure, thank you for your work on the project @afawcett! Do you want me to submit a PR with the change?

@renatoliveira Yes please! 👍

@afawcett I think you meant that to @rogeramitchell ? 😆

;-) I did, thanks @renatoliveira 👍

@afawcett submitted #536 as PR, looks like CI failed due to username being blank for the build. Not sure whether this is something I can resolve. Mind taking a look?

Yeah thats an issue with the way the CI works in pull requests, don't worry. I'll have a look at your PR now, thanks for the submission! 👍

This looks great, just merged. I will get it out in the next release. I will look to carve out some person time for some popular fixes/enhancements and include your work in this. Thanks again! 👍

Fixed in v2.10


Package not working on all website

The package seems not to work with some website.
for exemple this one :
https://www.udemy.com/formation-a-la-photographie-pour-les-debutants/
I tried with other package and it seems to be a 403 error ...
any clue on this ?

Hi @vtibo thanks for pointing this out. I tried with the same URL. Looks like this URL as well as some other urls doesn't allow the scripts to fetch the data. The fix is to add the user-agent in the request headers. This issue is now fixed.

Fixed in PR #31

Big THX @shweshi


Shame for demonstration example and support.

It is better to close this repo than to keep it alive with this poor tutorial and support.

@qsdnino oh, your first issue on Github is so strict. There are a lot of open-source projects maintained by Ramotion on Github and it's very time consuming work.
Keep in mind that you can contribute to open-source projects & ask for help, but you can't demand something.
We was very busy and missed a lot of issues here, but now we'll try to figure out all of them.

Sorry for inconvenience. I had deadline for one project and found your cell very intresting for implementation in my app. I lost some time trying to make cell works. I was under stressa with deathline and dissapointed with cell code deprecation and lack of documentation and better example tutorial. I think you could have many many more users if you make better tutorial and swift 3 support.
Sorry once again for inconvenience. If I could contribute in some way please say me how.
Regards
Nikola Jovic
iOS Developer
QSD BiH d.o.o.
Dr. Ante Starčevića bb, zgrada "Integra"
88000 Mostar
Tel:+387 (0) 36 316 571 (in process)
Mob:+387 (0) 63 492 521
<EMAIL_ADDRESS>www.qsdbih.com (under construction)
This email and any files transmitted with it are confidential. If you have received
this email in error please notify the sender and then delete it immediately.
Please note that any views or opinions presented in this email are solely those
of the author and do not necessarily represent those of Company.
The recipient should check this email and any attachments for the presence
of viruses. Company accepts no liability for any damage caused by any virus
transmitted by this email.
Company may regularly and randomly monitor outgoing and incoming emails
(including the content of them) and other telecommunications on its email
and telecommunications systems. By replying to this email you give your
consent to such monitoring.
Save resources: think before you print.
Sent from my iPhone

On 30 May 2017, at 17:13, Abdurahim Jauzee<EMAIL_ADDRESS>wrote:
Closed #110.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


proposal: create a package runes with functionality similar to bytes to work with rune slices

Working with and manipulating non-English data requires us to use runes slices. If we want to do operations like comparing two rune slices, replacing, indexing etc, we have to cast to string, do those operations and cast back or write custom functions.
I would like to therefore propose creating a package runes mirroring the package bytes with functionality to work directly with rune slices rather than bytes to support international language use cases

This would not be necessary once (if) generics are implemented.

On 9/16/19, Burak Serdar<EMAIL_ADDRESS>wrote:

This would not be necessary once (if) generics are implemented.

You could also claim (I do) that if something like this came along,
there would be less justification for "generics".
Frankly, generics require a much shallower boundary between intrinsic
and user-defined objects or, perhaps more usefully, but much more
difficult to do right, a much richer "type" mechanism with open-ended
attributes.
Go with generics then becomes either a beautiful academic artifact or
a Frankenstein monster of a language. Guess which is more likely to
happen first.
Incidentally, even knowing that the Go Team's efforts put the
integrity of the language very high on the list of objectives, it is
still quite revealing that there is no "Go with Generics" in the wild,
whether to be disparaged or to be revered.
Lucio.

On Sun, Sep 15, 2019 at 10:00 PM lootch<EMAIL_ADDRESS>wrote:

On 9/16/19, Burak Serdar<EMAIL_ADDRESS>wrote:

This would not be necessary once (if) generics are implemented.

You could also claim (I do) that if something like this came along,
there would be less justification for "generics".
Frankly, generics require a much shallower boundary between intrinsic
and user-defined objects or, perhaps more usefully, but much more
difficult to do right, a much richer "type" mechanism with open-ended
attributes.
Go with generics then becomes either a beautiful academic artifact or
a Frankenstein monster of a language. Guess which is more likely to
happen first.

I disagree. I think the latest generics proposal has a chance to be useful
without becoming a monster. The idea that in order to implement generics
you have to define the semantics of the generic types precisely is what
created c++/Java generics. Defining generics in terms of existing types has
a better chance of being used correctly because it demands less from the
author and from the reader.

Incidentally, even knowing that the Go Team's efforts put the
integrity of the language very high on the list of objectives, it is
still quite revealing that there is no "Go with Generics" in the wild,
whether to be disparaged or to be revered.

I think the reason for this is the experience with the c++/java generics,
and despite all the efforts, many counter-proposals ended up offering
similar solutions.

Lucio.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/34313?email_source=notifications&email_token=AA4AGDNAYJ6EF3SDURKWZDDQJ4AEDA5CNFSM4IW4YTDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YBNGQ#issuecomment-531633818,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4AGDIJ6DIY2LM72MIKAXLQJ4AEDANCNFSM4IW4YTDA
.

I have trouble with your opening sentence: Working with and manipulating non-English data requires us to use runes slices. That is presented as a fact but is an opinion, one I just don't think is true.
I speak only English but I have spent a lot of time working with text that is not ASCII and, although it can be attractive to work with rune slices, they are not really a good solution. In fact, I think they are a trap: they don't answer most of the questions that persist with multilingual text because, despite what many want to believe, a rune is not a character. (See blog.golang.org/strings for an explanation of this.)
I would therefore prefer not to add such a package as it would promote bad practice.

@robpike I hear you but now I'm really puzzled. My take away from your blog post (which I have revisited many times over the years including just before making this proposal today) is that runes are a better way to deal with non-english characters and smileys ad what not vs. bytes. Ranging over a string gives runes.
Now I do recall from reading the article linked to in your blog that some Unicode code points are modifiers and what not and some characters can be made with multiple combination of Unicode code points and they can mess things up but what's a better way to deal with mutable collections of Unicode code points than a slice of runes that's made available in Go?

Runes are code points, from which characters are made. Bytes are also things from which characters are made. Why use both?
Sometimes we need the code points themselves, but providing a package that handles slices of them will encourage the poor practice of converting back and forth between rune slices and bytes slices/strings rather than the more efficient method of just iterating the bytes appropriately.

May I share an example use case? Suppose we're building a simple text editor. When people enter text, the enter unicode code points to make characters. If we use rune slices, we can simply insert the required rune at the right position.
If we are using byte slices, for each insertion or deletion, we would have to iterate the slice through a function to parse Unicode, find the right position to insert or delete & make the change. Since this iteration can throw an error, we'd have to check for error. If we are using strings, we'd have to reallocate for every single insertion or deletion & then again run iterations.
Essentially if we want to work with mutable sets of unicode characters, then neither the bytes solution nor the strings solution seems efficient

off topic, but I thought to mention Perl6 here
https://www.evanmiller.org/a-review-of-perl-6.html
cf: Strings and Regexes
caveat, see footnote 2
a contributor to Perl6
https://perlgeek.de/
also wrote this module
https://metacpan.org/pod/Perl6::Str

the idea of using rope data structures in an editor intrigued me at one point
but I've never taken the time to look into it

Essentially if we want to work with mutable sets of unicode characters, then neither the bytes solution nor the strings solution seems efficient

And the runes solution is misleading and incorrect. Text is hard, and rune slices solve almost none of what makes text hard.

on a side note
A Philosophy of Software Design
by J. Ousterhout
The book includes commentary on a student project of writing a text editor.

Using runes in a text editor seems like a good idea at first, but it fails badly once you get to Unicode compose sequences, like e + composing acute vs é. The former is two runes while the latter is one. And for some sequences there's not even a single-rune sequence. In general Unicode text processing requires considering largish sequences of input, not just a single byte and not just a single rune either. There's little benefit to []rune as the representation, and there are real drawbacks to having two representations. So Go has standardized on []byte/string and UTF-8.
If you find that []rune works really well for your editor somehow (maybe you ignore all the multirune characters), that's fine. A "runes" library forked from "bytes" could easily be maintained as a go get-able package outside the standard library.
Note that generics are not going to help here, because the encoding stored in the underlying data is different between []byte and []rune.
This is a likely decline. Leaving open for a week for final comments.

Hopefully my comment won't be interpreted as cultural bias.
I'm opposed to this on linguistic reasons.
Rune, is used in Plan 9, and also appears in Golang.
The suggested use diverging excessively from the original North Germanic languages' use of the word.
D. Mendeleev used एक (eka) and द्वि (dvi) for certain postulated elements.
экаалюминій, экаборъ, экасилицій
двимарганец

There have been no comments objecting to declining this issue. Declined.


restore hidden states added

This PR adds two features to the DRQN agent:
1- Restoring hidden states from the replay buffer
2- Burn-in frames to warm up the rnn module.


[Do not merge][AdaptiveUiCodelab] merge codelab updates to main

(Please do not merge until updated codelab content has been published.)


update golang version in github actions

What this PR does / why we need it:
update golang version in github actions
github actions will now use golang 1.17
Release note:
NONE

Signed-off-by: Karel Šimon<EMAIL_ADDRESS>

/lgtm
/approve

/retest
/approve


[Multi-step] Remove redundant CPU to GPU transfer for non-last rank PP/TP

cc @zhuohan123 @comaniac
FILL IN THE PR DESCRIPTION HERE
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

/ready

/ready

Unfortunately not. The reason is the first PP rank still requires the sampled_token_ids from previous step, and passing it through execute_model_req is still the best way I believe.

Currently looking into the multi-step test

Going to let CI run to see if it passes tests. Meanwhile I will benchmark TP to see if there are perf changes.

Very slight perf improvement on 8xH100 TP=8 70B. Not much change with TP=4. @zhuohan123
Without this PR:
Successful requests:                     1000
Benchmark duration (s):                  46.31
Total input tokens:                      215196
Total generated tokens:                  200977
Request throughput (req/s):              21.59
Input token throughput (tok/s):          4646.89
Output token throughput (tok/s):         4339.85
---------------Time to First Token----------------
Mean TTFT (ms):                          13131.67
Median TTFT (ms):                        12550.41
P99 TTFT (ms):                           30058.03
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          53.18
Median TPOT (ms):                        46.86
P99 TPOT (ms):                           191.89
---------------Inter-token Latency----------------
Mean ITL (ms):                           335.84
Median ITL (ms):                         330.54
P99 ITL (ms):                            683.05
==================================================

With this PR:
Successful requests:                     1000
Benchmark duration (s):                  44.25
Total input tokens:                      215196
Total generated tokens:                  200977
Request throughput (req/s):              22.60
Input token throughput (tok/s):          4862.74
Output token throughput (tok/s):         4541.44
---------------Time to First Token----------------
Mean TTFT (ms):                          13175.04
Median TTFT (ms):                        12298.81
P99 TTFT (ms):                           30367.29
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          53.16
Median TPOT (ms):                        46.11
P99 TPOT (ms):                           203.35
---------------Inter-token Latency----------------
Mean ITL (ms):                           333.06
Median ITL (ms):                         325.30
P99 ITL (ms):                            614.94
==================================================

I'll need to take a look at this patch again. It may be real failures


pieChart: How to write click event handle function?

Hi Krispo,
I am using you library for creating interactive pie chart but It looks it doesn't have ready function for handling click event: It has growOnhover and I need to have exact same behavior for click event too.
I have this code so far:
app.controller('MainCtrl', function($scope) {
$scope.options = {
chart: {
type: 'pieChart',
height: 500,
growOnHover: false,
showLegend: false,
                pie: {
                    dispatch: {
                            chartClick: function(e){// what code should i put here to make it works same as growOnHover? }

.......................
........................
Thank you,
Seyf.

+1, i need same

@Seyfi1977, I know this is really old. But in case anyone else is looking for it:
this should work:
....
               pie: {
                    dispatch: {
                        elementClick: function(e){
                            console.log(e.data.label);
                        }
                    }
                }
....

Other methods supported, include:
elementDblClick, elementMousein?, elementMouseout, elementMouseover

So, you may want to do something like this within your elementClick function:
....
                       elementClick: function(e){
                            console.log(e.data.label);
                            $state.go('my.state.path', {someParam: e.data.label});
                        }
....


[Feature] synchronize the application in cluster to db

Feature description
KubeVela introduces the API server + DB module to help users versioning management application configuration and distribution.
The API module assembles the Application CR during the publishing process and publishes them to the cluster. The application configuration will be based on the data stored in the DB.
Two scenarios are produced here:

How to connect existing applications in the cluster to the API server for management on the UI?
How to notify the developer in the UI if the user changes the application configuration in the cluster.

First of all, we need to keep the model consistent in both DB and CR forms, Of course, DB objects may iterate faster in practice, but they need to support interconversion with CR objects. If users are using KubeVela UI, the DB configuration should be their baseline configuration. Configuration changes discovered from the cluster should be part of a differentiated configuration for different environments.

implemented in 1.5


UG/C-61  and some death flags

death flags,   if you put it you cant compile it (builds until LIINK ./CHROME after...errors)
examples

'enable_service_discovery=false'

'enable_mdns=false'

idk why this gn flags didnt work with chromium 61 + your patches

Fixed in 91a96717f6e5a2b1ee191c0c94dd8eb6aef8fe92


regen iam with gRPC

Fixes https://github.com/googleapis/gapic-generator/issues/2865 and other issues
CC: @crwilcox

Per offline discussion with @lukesneeringer, the moving of the grpc code to the new files is not a concern, it shouldn't have been used anyways. I will regen with the protoc-docs-plugin and it should be good-to-go. Furthermore, CI can be ignored here.

Pinning the nox version fixed the python-related CI. Moving forward with this change.


[Improvement][Style] Expand all static imports and add CI check to block wildcard static imports

Purpose of the pull request

Expand all static imports and add CI check to block wildcard static imports
This PR closes: #13018

Brief change log

Stated as above.

Verify this pull request

Verified by manual check.

Codecov Report

Merging #13067 (702d33e) into dev (a0eb45b) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##                dev   #13067      +/-   ##
============================================
- Coverage     39.33%   39.33%   -0.01%
  Complexity     4276     4276
============================================
  Files          1069     1069
  Lines         40187    40149      -38
  Branches       4613     4593      -20
============================================
- Hits          15809    15793      -16
+ Misses        22600    22579      -21
+ Partials       1778     1777       -1

Impacted Files
Coverage Δ

...uler/api/controller/ProcessInstanceController.java
70.21% <ø> (ø)

...r/api/controller/WorkflowInstanceV2Controller.java
84.61% <ø> (ø)

...olphinscheduler/plugin/task/linkis/LinkisTask.java
0.00% <ø> (ø)

...r/api/service/impl/ProcessInstanceServiceImpl.java
63.96% <88.88%> (ø)

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...erver/worker/runner/WorkerTaskExecuteRunnable.java
38.51% <0.00%> (-1.23%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
51.19% <0.00%> (-1.20%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.69% <0.00%> (-0.35%)
:arrow_down:

... and 19 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Green accents everywhere

Why is half the app green when my Windows accent is purple?

Good one 👍


activerecord: Fix type of #merge

The #merge method can take the relation object for other models:
Account.joins(:articles).merge(Articles.where(...))

It looks like ActiveRecord::SpawnMethods#merge will also accept Array, Hash, and #to_proc
    def merge(other, *rest)
      if other.is_a?(Array)
        records & other
      elsif other
        spawn.merge!(other, *rest)
      else
        raise ArgumentError, "invalid argument: #{other.inspect}."
      end
    end

    def merge!(other, *rest) # :nodoc:
      options = rest.extract_options!
      if other.is_a?(Hash)
        Relation::HashMerger.new(self, other, options[:rewhere]).merge
      elsif other.is_a?(Relation)
        Relation::Merger.new(self, other, options[:rewhere]).merge
      elsif other.respond_to?(:to_proc)
        instance_exec(&other)
      else
        raise ArgumentError, "#{other.inspect} is not an ActiveRecord::Relation"
      end
    end

https://api.rubyonrails.org/classes/ActiveRecord/SpawnMethods.html#method-i-merge

Thank you for reviewing. Updated!

It looks good but this change conflict with the default branch. Could you resolve the conflict?

The conflict is resolved now.


Fix dtsgen relative paths

In some files the generated .d.ts code has relative paths, but these must resolve to the full package name.
e.g. in @ui-schema/dictionary/en/errors.d.ts:
import { ERROR_ENUM_MISMATCH } from "../../../ui-schema/src/Validators/ValueValidator/valueValidatorEnum";

! or how to disable them, as they are not used in the typing?

After the latest adjustments (webpack5 + build tools upgrade; fix esm module paths in build), there are no relative paths anymore.

can't confirm that it was caused by the wrong esm build.
for the other points it would be too much effort to validate it.


[prop types] fix an assignment to prop

fixes issue #1288

@ljharb updated

@ljharb I stumbled upon this test case and traced to this PR. Why should it not fail? Is assignment to a prop not considered usage? I'd expect this to fail with missing prop type for bar prop.
function Foo(props) {
  props.bar = 'bar';
  return <div {...props} />;
}

Ah I see your point. Although the presence of an assignment doesn't necessarily mean that this prop wasn't passed as well. But I guess it's not enough to mark this as usage.

Right, I don't consider it usage, or an untyped prop.
It's weird, but it should still work :-)


How to get  in body text using plain ASCII input from file

I have a CR/LF terminated text file and do not want to use HTML as a body but stick to plain text:
PS C:\users> Get-Content -path 'd:\foo.txt' -raw
hello
world
Sending out with Send-MailMessage results in 2 lines as needed in my email client but using Send-EMailMessage results in 1 line only:
hello world
CMD used:
$StrBody = (Get-Content -Path 'd:\foo.txt' -raw) ; Send-EMailMessage -SmtpServer 'w.x.y.z' -Body $StrBody  -from<EMAIL_ADDRESS>-To<EMAIL_ADDRESS>-port 25
I'm a Windows user and the result is the same using PS 5.1 and PSCore 7.2.1 (on Mailozaurr 0.0.21)

@jstedfast Do you have any idea what would not be stripped by [MimeKit.BodyBuilder]::new() that we're using when it comes to new lines for text?

I'm thinking that this may be more likely to be an issue with passing the body as a string on the command-line? I'm not sure, though.
Keep in mind that when sending a message, message bodies are ALWAYS formatted with DOS line endings (aka CRLF).
Is the body base64 encoded? That might cause issue if the input has LF instead of CRLF, but otherwise it shouldn't be an issue.

^^ It's CRLF

The BodyBuilder class just takes the TextBody and/or HtmlBody string property values and sets them as the Text property on a TextPart when it constructs the message body.
TextBody.Text calls SetText() which just does Encoding.UTF8.GetBytes(). There's no line-ending conversion.
Also note that SmtpClient.Send/Async() makes sure that line endings are CRLF format (mostly needed when running on Linux) since SMTP specifies line endings must be CRLF.

In order to be sure I saved the email as TXT in Thunderbird. Send-MailMessage (upper) preserves the CRLF (and adds 3 more at the end?) compared to Send-EMaillMessage (lower) which converts it to a space (0x20)

I can't think of anything in MimeKit/MailKit that would replace CRLF with a space.
Would it be possible to dump your message to a file (before sending via SMTP) so that we can see the raw message being sent before any other software has a chance to modify it?
Ideally it would use the MimeMessage.WriteTo() method.

I'm not a programmer and would need guidance on that.

Basically just about here:
https://github.com/EvotecIT/Mailozaurr/blob/5aeaf9d40e27495f07f81844743f796ce954cfac/Public/Send-EmailMessage.ps1#L684
You would need to do:
$Message.WriteTo($PathToFile)

So you either modify the module a bit, reimport it with Import-Module -Force and try again or I guess we could add some sort of debug method to Mailozaurr.

Here's the code responsible for using BodyBuilder to build HTML/Text and then assign that Body to $Message.Body
https://github.com/EvotecIT/Mailozaurr/blob/5aeaf9d40e27495f07f81844743f796ce954cfac/Public/Send-EmailMessage.ps1#L549-L561

So I just did some testing:

So it seems to work. I've not tested it with old version but after upgrading to 3.1.0 which will be used in next release (hopefully).

Looks promising - and sorry that I was not yet able to get the dump. During week time I hardly have time for such things and my plan was to deal with it on the upcoming Saturday. But now I wait for the next release.

Added MimeMessagePath string which allows saving the message request if we ever need to troubleshoot it

@stethos give new version a try

Sorry, still not working for me in my email client (Outlook and Thunderbird)

what if you use the example, with the file i prepared that's on github?

Ohhh, you're using body.... that's for HTML, you should use Text :-)

Gosh, -Text works like a charm!
Did not think about this one as I just replaced the SendMailMessage by SendEMailMessage withoug digging more deeply into every parameter.
Thank you for all your help and time you have spend on that one.


Adds better handling for dotted notation fields in is_expanded

Basically implements the proposed behaviour in #48 with some small tweaks:

utilizes WILDCARD_VALUES instead of hardcoding "~all"
receives a request as the argument
converts tests from pytest notation to django notation

Most of the credit to @mitchelljkotler for actually implementing the solution

Ping @rsinger86


Fix non-transparent border on newly spawned urxvt terminals

This PR uses {background.alpha} for URxvt*borderColor in the Xresources template so that urxvt terminal borders share the same transparency as the terminal background.
For example, this is xrdb -q on an affected terminal:

LGTM 👍
Thanks!


chore: enable dependabot

Purpose
Dependabot is used to keep dependencies up to date.
Approach
Configuring Dependabot based on: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates
Testing
We will have to wait and see if PRs are being opened.
Risks
N/A

Just curious, did you find something you disliked?

What do you mean, when shaping up the script? It was pre-filled TBH, I only added the GitHub Actions one.
Well, comparing to what we had previously, have a setting on repository itself is so much better!

What do you mean, when shaping up the script? It was pre-filled TBH, I only added the GitHub Actions one.

I mean Dependabot works well even without that file .github/dependabot.yml, i.e. it's zero-config.

I mean Dependabot works well even without that file .github/dependabot.yml, i.e. it's zero-config.

Really? But it shows this: https://github.com/onfido/castor-icons/network/updates

Really? But it shows this: https://github.com/onfido/castor-icons/network/updates

Ah, it needs the config for Insights then, makes total sense.
It does create PRs without it though, I'm sure.

It does create PRs without it though, I'm sure.

I looked this up a little, seems like previously it was an app you had to install and setup, but now after Dependabot was integrated directly into GitHub I believe having a config is recommended way of enabling it.


Page goes blank after keydown on first load

I know this sounds weird but...
Upon performing a hard reload of the site, one can click in any cell, and as soon as any key is pressed, the entire page goes white. The "reason" is clear: the inspector shows that div#root has display: none on it. Upon reloading the page, this doesn't happen anymore!
However, upon hard reloading the page, the issue happens again, and can only be fixed with a (regular) reload.
I've managed to produce this in Chrome and Firefox.

This isn't going to be very useful but I have determined a few things. Unfortunately I can't reproduce it locally. However from poking around on the live site it appears to be a MathJax issue. In particular, on the first keydown event in a grid cell MathJax fires up and tries to load a font. For some reason, this fails only in the conditions described above and MathJax is trying to set/clear its error message, and somehow sets the entire div.root to display: none instead of... whatever div its error message is supposed to live in (maybe this has to do with turning errors off in MathJax?).
Seems likely that it's a MathJax bug. Currently the app is loading 2.7.6, and there don't appear to be any releases past that before 3, and migrating to 3 would be a moderately substantial task given the high use of the MathJax API.

Just for information, in case someone wants to pick this up: I believe the only place that uses MathJax substantially is GridCell and GridArrow for typesetting the labels and integrating into the Preact framework.


Board Review: Event Hubs

The Basics

Service team responsible for the client library:   Azure Event Hubs
Link to documentation describing the service:

Azure Event Hubs in general
Azure Event Processor Track 1

Contact (if service team, provide PM and Dev Lead): SeongJoon Kwak, Javier Fernandez & Shubha Vijayasarathy

About this client library

Name of the client library: Event Hubs
Languages for this review: C#, TypeScript, Java, Python
Link to the service REST APIs: None
Link to the reference documentation

Typescript API ref docs
Python API ref docs for Event Hubs
Python API ref docs for Event Processor
.Net API ref docs for Event Hubs
.Net API ref docs for Event Processor
Java API ref docs

Link to several samples:

Typescript Samples
Java Samples
.Net Samples
Python Samples

Scenarios to review

Scenario 1:

Send data to Azure Event Hubs using a "batch"

Supports the creation of a "batch" that lets you add events until the max size supported after which you can the send the entire batch at one go.

Link to the code sample

Scenario 2:

Receive data from a single partition of a consumer group in an Event Hub instance starting from a given position in the partition.

Has the option to track the last enqueued event in the partition so that the customer is aware of the lag between the current event being processed and the number of events left to be processed in the partition

Link to the code sample

Scenario 3:

Use the concept of a EventProcessor that can be instantiated over multiple machines in order to scale the event processing up or down.

Allows users to checkpoint events so that new Event Processor instances that are coming up will know where to start processing from.

Link to the code sample

Agenda for the review
Since we have had one round of reviews for Event Hubs before, this time we want to focus on the specific scenarios listed above

Brian - can you get this scheduled for next week?

Scheduled for 9/5

Gist with .Net API for Event Processor: https://gist.github.com/ramya-rao-a/f1d95a86b2c70598575b9eab77231c88


Fix logic in assert! statements

Fixes incorrect logic introduced in 0ceca4f89 and d41a06c78 where assert! statements were added.

LGTM! I hit these asserts too earlier today (commit) while working on arm7 assembly. It looks like we've arrived at the same solution.

Sorry for the typos in these; I would've thought they'd be caught in testing.  Any others like these should at least be easily caught by just searching for assert!(!( where I accidentally left in the original ! not.


Add GET /ip handler to return all IPAM mappings.

Scope needs to know the IP addresses of containers.

Scope needs to know the IP addresses of containers.

...but what you have implemented only returns the automatically allocated addresses.
What's wrong with weave ps?

I don't want to repeatedly invoke a shell script; the idea would be for IPAM to also record the IP addresses of non-allocated containers.  Its already told about them by the weave script and the proxy, so 'all' thats needed is for IPAM to not ignore the requests, as it does in https://github.com/weaveworks/weave/blob/master/ipam/claim.go#L34
What do you think?

the idea would be for IPAM to also record the IP addresses of non-allocated containers.

IPAM should not get involved in anything outside its range. Introduces an artificial coupling.

I don't want to repeatedly invoke a shell script

That doesn't strike me as all that bad.

I don't want to repeatedly invoke a shell script
That doesn't strike me as all that bad.

NB in the case of e.g., the docker plugin, the interfaces are not named (exactly) "ethwe"; i.e., weave ps assumes interfaces are assigned by the weave script. It might be a reasonable assumption for the minute, but probably won't remain so.

Using the output of weave ps was a pain.  Had to include the weave script and the docker cli in the scope image.  And have to parse the output of the script.  Yuk.
https://github.com/weaveworks/scope/pull/386

Using the output of weave ps was a pain

doesn't look all that painful.

Had to include the weave script and the docker cli in the scope image

That is somewhat annoying, but otoh it means you can now also invoke any other weave commands.
Can we close this?

I need a function like this for debugging, reasonably often.


Application cannot be started. Contact the application vendor Error

I was trying to use the Web (VS Code, WSL, Multiple Browsers), and I got this error:
PLATFORM VERSION INFO
	Windows 			: 10.0.17115.0 (Win32NT)
	Common Language Runtime 	: 4.0.30319.42000
	System.Deployment.dll 		: 4.7.3053.0 built by: NET472REL1
	clr.dll 			: 4.7.3053.0 built by: NET472REL1
	dfdll.dll 			: 4.7.3053.0 built by: NET472REL1
	dfshim.dll 			: 10.0.17115.1 (WinBuild.160101.0800)

SOURCES
	Deployment url			: file:///C:/Users/test01/Downloads/Boxstarter.WebLaunch.application

IDENTITIES
	Deployment Identity		: Boxstarter.WebLaunch.application, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=6b092740f7261cd0, processorArchitecture=msil

APPLICATION SUMMARY
	* Online only application.
	* Trust url parameter is set.
ERROR SUMMARY
	Below is a summary of the errors, details of these errors are listed later in the log.
	* Activation of C:\Users\test01\Downloads\Boxstarter.WebLaunch.application resulted in exception. Following failure messages were detected:
		+ Deployment and application do not have matching security zones.

COMPONENT STORE TRANSACTION FAILURE SUMMARY
	No transaction error was detected.

WARNINGS
	There were no warnings during this operation.

OPERATION PROGRESS STATUS
	* [5/9/2018 7:42:20 AM] : Activation of C:\Users\test01\Downloads\Boxstarter.WebLaunch.application has started.
	* [5/9/2018 7:42:20 AM] : Processing of deployment manifest has successfully completed.
	* [5/9/2018 7:42:20 AM] : Installation of the application has started.

ERROR DETAILS
	Following errors were detected during this operation.
	* [5/9/2018 7:42:20 AM] System.Deployment.Application.InvalidDeploymentException (Zone)
		- Deployment and application do not have matching security zones.
		- Source: System.Deployment
		- Stack trace:
			at System.Deployment.Application.DownloadManager.DownloadApplicationManifest(AssemblyManifest deploymentManifest, String targetDir, Uri deploymentUri, IDownloadNotification notification, DownloadOptions options, Uri& appSourceUri, String& appManifestPath)
			at System.Deployment.Application.ApplicationActivator.DownloadApplication(SubscriptionState subState, ActivationDescription actDesc, Int64 transactionId, TempDirectory& downloadTemp)
			at System.Deployment.Application.ApplicationActivator.InstallApplication(SubscriptionState& subState, ActivationDescription actDesc)
			at System.Deployment.Application.ApplicationActivator.PerformDeploymentActivation(Uri activationUri, Boolean isShortcut, String textualSubId, String deploymentProviderUrlFromExtension, BrowserSettings browserSettings, String& errorPageUrl, Uri& deploymentUri)
			at System.Deployment.Application.ApplicationActivator.PerformDeploymentActivationWithRetry(Uri activationUri, Boolean isShortcut, String textualSubId, String deploymentProviderUrlFromExtension, BrowserSettings browserSettings, String& errorPageUrl)
--- End of stack trace from previous location where exception was thrown ---
			at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
			at System.Deployment.Application.ApplicationActivator.PerformDeploymentActivationWithRetry(Uri activationUri, Boolean isShortcut, String textualSubId, String deploymentProviderUrlFromExtension, BrowserSettings browserSettings, String& errorPageUrl)
			at System.Deployment.Application.ApplicationActivator.ActivateDeploymentWorker(Object state)

COMPONENT STORE TRANSACTION DETAILS
	No transaction information is available.

this is my Windows 10 version

And this is my Hyper-V version

Any Ideas?

I realize that if I click on the script from IE it works, not if you try to do it from Chrome.

@ddieppa ah, that is a good point.  Perhaps we need to add a mention of that in the readme.  There are some extensions that used to allow ClickOnce to work in Chrome, but I haven't played with any of them recently.

@gep13 yes, I think to add that part to the readme will be a quick solution to this. Anyways, there is no other solution that can be accomplish within the same boxstarter script?

No, not within the Boxstarter Script itself.  This error is occurring before the script is invoked, so there is nothing that can be done from a Boxstarter side of things.

Am adding a comment about this in the Readme's known issues


[test] issues with myst build of docs

Using the docs as a simple conversion test case here are the following issues
docs/build/myst  master ✗                                                                                7m ⚑
▶ make html
Running Sphinx v3.1.0+/3303230
making output directory... done
WARNING: html_static_path entry '_static' does not exist
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 2 source files that are out of date
updating environment: [new config] 2 added, 0 changed, 0 removed
reading sources... [100%] issues
sphinxcontrib-rst2myst/docs/build/myst/index.md:6: WARNING: Directive 'image' cannot be mocked: MockingError: MockState has not yet implemented attribute 'parse_target'

---
alt: Documentation Status
target: https://sphinxcontrib-rst2myst.readthedocs.io/en/latest/?badge=latest
---
looking for now-outdated files... none found
pickling environment... done
checking consistency... /Users/matthewmckay/repos-collab/sphinxcontrib-rst2myst/docs/build/myst/issues.md: WARNING: document isn't included in any toctree
done
preparing documents... done
writing output... [100%] issues
sphinxcontrib-rst2myst/docs/build/myst/index.md:32: WARNING: None:any reference target not found: genindex.myst
sphinxcontrib-rst2myst/docs/build/myst/index.md:33: WARNING: None:any reference target not found: py-modindex.myst
sphinxcontrib-rst2myst/docs/build/myst/index.md:34: WARNING: None:any reference target not found: search.myst
generating indices...  genindexdone
writing additional pages...  searchdone
copying static files... ... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded, 6 warnings.

[ ] move from .myst extension to .md extension as per myst_parser expectation
[ ] review reference linking and remove extension to be just docname

[ ] Look into :target: option for .. image:: directive in myst_parser


Configuring UI in NodeJS with ReactJS

Cannot configure UI in NodeJS app with ReactJS. Cannot find UI classes. I want to add quality change button.
import React from 'react';

import shaka from 'shaka-player';

class Tutorial extends React.PureComponent{

    constructor(props){

        super(props);

        this.video = React.createRef();
    }

    componentDidMount(){

        var manifestUri = 'https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd';
        var licenseServer = 'https://cwip-shaka-proxy.appspot.com/no_auth';

        let video = this.video.current;

        var player = new shaka.Player(video);

        player.configure({
            drm: {
              servers: { 'com.widevine.alpha': licenseServer }
            }
          });

        const onError = (error) => {
            // Log the error.
            console.error('Error code', error.code, 'object', error);
        }

        player.load(manifestUri).then(function() {
            // This runs if the asynchronous load is successful.
            console.log('The video has now been loaded!');
          }).catch(onError);  // onError is executed if the asynchronous load fails.
    }

    render(){

        return(
            <video id="video" ref={this.video}
            width="640"
            poster="//shaka-player-demo.appspot.com/assets/poster.jpg"
            controls autoplay></video>
        );

    }
}

export default Tutorial;

Worst documentation I ever found. Cannot understand a single implementation its just confusing.

@amit08255, I'm a little confused about what you're trying to accomplish.  I see code that resembles the "Basic Usage" tutorial for the non-UI build of Shaka Player.  (eg, player = new shaka.Player(video);)  Have you seen our UI-specific tutorial?  https://shaka-player-demo.appspot.com/docs/api/tutorial-ui.html
Because the Shaka Player UI is an optional component, you need to opt-in by loading the correct build, and you need to add the correct data attributes to the video element.  Instead of constructing the Player object, you get a reference to it from the video element.  You'll find all of this in the tutorial.
Though the library is designed to auto-setup the UI based on a scan of the DOM, you can also create the components explicitly after the DOM is set up if needed.  (I am not familiar with ReactJS, so I'm guessing you might need this.)  This is not mentioned in the tutorial, but you could use this API instead of the declarative setup:
  // Here "videoContainer" is a simple div that wraps the video element.
  // Add this to your HTML, and make sure you drop the "controls" attribute from video.
  // UI controls will be created inside videoContainer and overlay video.
  player = new shaka.Player(video);
  ui = new shaka.ui.Overlay(player, videoContainer, video);
  controls = ui.getControls();

We aren't experts in ReactJS, so you'd be on your own to determine how best to fit this into the ReactJS paradigm.
Does this help?

Hello Joey,
Thank you for your quick response.
I am working on a project in ReactJS, for which I need to implement saka player. I have been looking around the docs and tutorials, but couldn't find the exact solution which to help me configure saka player with UI configuration.
The NPM page doesn't explain how to configure it in NodeJS and also there is no information in README or in docs.
After spending all day, and experimenting for several hours, I found the solution (which was taken from different issues).
Finally, its working. Thank you for your help.
Can I please request you to add a docs or tutorial for NodeJS users, so that it could help them?
I will love to help with this. I love shaka player, but I think its NodeJS implementation need to be documented for newbies like me.

Shaka Player isn't meant to run in NodeJS at all.  It runs in a browser, because it depends heavily on things provided by browsers and not by NodeJS (HTML5 video, MediaSource, EME, etc.)

Yes I agree. I was using shaka player in ReactJS and yes it was used to be executed on client-side. I mistakenly tried to execute it on server side which didn't work.
I learnt a lot about shaka player today. I was just requesting to add docs or tutorials for implementing Shaka player for frameworks like ReactJS since there isn't much solution available (especially with things like UI configuration).

I filed #2163 to track the creation of a tutorial for Shaka+ReactJS.  Note that my team has no experience with ReactJS, and docs concerning other frameworks have never been in scope of this project.  So I can't promise when we will work on this.
In the mean time, I highly recommend you spend time with the docs for ReactJS and the docs for Shaka Player itself.  If you can understand how to use the APIs of both projects, then you should be able to fill in the gap between the two.
Thanks!

Thanks. Sure, I will work on this so that it can help other beginners.

https://github.com/amit08255/shaka-player-react-with-ui-config
This is still work under progress.
It explains how to configure shaka player for ReactJS using simple projects.
It also explains basic UI configuration of shaka player with ReactJS.


Dropdown for selecting header

Is your feature request related to a problem? Please describe.
Icons with text like H1, H2, H3 is not user-friendly. The "bigger heading" and "smaller heading" buttons aren't very user-friendly either.
Describe the solution you'd like
A toolbar button that when pressed presents the user with a dropdown containing "Header 1", "Header 2", "Header 3", "Header 4", "Header 5" and "Header 6".

See https://github.com/Ionaru/easy-markdown-editor/issues/437

These are different issues.
This issue is about providing a toolbar button that has a dropdown containing headers.
That issue is about adding EasyMDE "actions" for header 4, 5 and 6.


RD suit recolor

About the PR

michelin man more inline with his own department, edit by noctyrnal
Why / Balance

its shiney
Technical details

sadly doesnt make the suit better at sustaining bomba
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: noctyrnal

tweak: RD's suit got a new paint job.

awesome sauce now rd looks like they're actually from sci

i think the shininess is visually kinda distracting and makes the suit look really high-contrast. I also think the old color is just more unique looking in general, especially for a department as monochrome as Sci.

sadly doesnt make the suit better at sustaining bomba

blud its literally the most bomb resistant suit on the station, what do you mean lmfao
(also i validate this new suit change, wanna see in-game for a full opinion)

i love the new palette

I really like the design. It makes sense that something that's 'experimental' would be shiny like that. Also it's the suit of a head so it also makes sense that it pops out more.

I love the new colors and how shiny it looks. It activates the "ooh shiny" neurons for me. Plus I think it fits the sci pallet a bit more than the old one


context store

can anyone explain when redux store is set to context?
is it meaning that any component can use this.context.store to dispatch action?
thanks.

Hey @mtiger2k
I'm sorry but I really don't understand what you're asking.
If you are reporting an issue with the boilerplate, please open a new issue and make sure you fill in the Issue Template.
If you are asking a general question about context or redux, please send it to StackOverflow instead. This isn't a help forum.


Resizing window seems to cause division by zero

The culprit seems to be: UiRender
This occurs because of convertion from float to int, when our ratio is < 1.
Easiest way to fix it would be to just add
let pixelRatio = pixelRatio === 0 ? 1 : pixelRatio;
But I am not sure if that's the best solution. I would be happy to submit a PR for it.

Thanks @WhoAteDaCake ! Yes, I saw this come up a few times too, but haven't narrowed it down.

Easiest way to fix it would be to just add

let pixelRatio = pixelRatio === 0 ? 1 : pixelRatio;

Seems reasonable to me. I suspect that during the resize - the callbacks for getting the screen window size and framebuffer size occur at different times - and depending on when render is called (if the screen size is updated, but not framebuffer), we could hit this.
Alternatively - now that I think about it - perhaps it would be best to just support a float pixel ratio? I believe there are some cases where the pixel ratio gets reported as a fractional value, like 2.5, so that seems like the best long-term fix.

I think using float might be a good alternative. I imagine that would give more accurate results. don't think, that it would make performance worse, as we would only need 2 conversions for sizes instead of 1 (In order to pass style sizes)

How would that affect the performance?

Good question @WhoAteDaCake , thanks for thinking about perf!
I don't think switching this from int to float will introduce a new bottleneck in our rendering - worst case, if we find that it does, we could cache the value on the Window.t instance. 👍


EnsureTags injecting erroneous tag values

In generating latest RDS controller for ACK runtime v0.19.0, I am seeing the following errors in the controller logs during tests:
 1.6548499531724842e+09	ERROR	controller.dbparametergroup	Reconciler error	{"reconciler group": "rds.services.k8s.aws", "reconciler kind": "DBParameterGroup", "name": "pg13-standard", "namespace": "default", "error": "InvalidParameterValue: Tag values may only contain unicode letters, digits, whitespace, or one of these symbols: _ . : / = + - @\n\tstatus code: 400, request id: dc460d16-2f8f-4b73-bff8-232ea1aff41e"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227

If I had to guess, what is happening is that the %K8S_NAMESPACE% and similar interpolation variables inside ensured tag values are not being properly interpolated or the EnsureTags is not ensuring that in the case of a missing environment variable or needed interpolation target, that the end tag value is actually valid...

It looks like we need to update the test-infra/scripts/kind-build-test.sh script to use the new different AWS_RESOURCE_TAGS


fix(ui):Popover should be on the right side

Describe your changes:

I worked on the subtask of issue #10543

[x] Popover should be on the right side

Type of change:

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My PR title is Fixes <issue-number>: <short explanation>
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya we need to adjust the placement too
@devyani-kaushik can you help here, It's looks overlapping with feed details


New benchmark: Gesture semantics

Description
This PR adds a new benchmark that tests the performance of GestureDetector. It uses a new app, "Button Matrix", which contains 30 buttons on the screen, and repeatedly press buttons to update the screen.
It also adds a new parameter semanticsEnabled to benchmarkWidgets in order to enable semantics, which defaults to false to avoid breaking existing benchmarks.
Open issues

Is the new app at its correct directory?

Related Issues

It blocks https://github.com/flutter/flutter/pull/33936 in order to test performance.

Tests
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

For archaeologists, perf benchmark regressions triggered by this PR were filed at https://github.com/flutter/flutter/issues/35294


slm does not have a help command

Command line utilities without a help sub-command or -h/--help flag are very difficult to use. We should add a help listing that explains how to use the tool.

Further - if you try to pass -h to slm init you get kind of cryptic help message that is confusing:
➜  lbstanza-pcre2 git:(main) $SLM init -h
usage: git init [-q | --quiet] [--bare] [--template=<template-directory>]
                [--separate-git-dir <git-dir>] [--object-format=<format>]
                [-b <branch-name> | --initial-branch=<branch-name>]
                [--shared[=<permissions>]] [<directory>]

    --template <template-directory>
                          directory from which templates will be used
    --bare                create a bare repository
    --shared[=<permissions>]
                          specify that the git repository is to be shared amongst several users
    -q, --quiet           be quiet
    --separate-git-dir <gitdir>
                          separate git dir from working tree
    -b, --initial-branch <name>
                          override the name of the initial branch
    --object-format <hash>
                          specify the hash algorithm to use

slm: error: 'git init -h' failed!

It just passes the -h directly to git init which causes the command to fail. The directory -h still gets created with various values in it.

Complete


What are you using to combine & minify your js?

I'm starting to dig into the js for image/attachment plugins, and I don't see any obvious build process to turn public/js/src/* into public/js/all.js.

Check out gulpfile.js

Got it, thanks..


MAGIC WP4 Hydroclimatic intensity and extremes

Namelist to calculate a set of 6 indices (among which the hydroclimatic intensity) to evaluate the response of the hydrological cycle to global warming with a joint view of both wet and dry extremes (Giorgi et al. 2011/2014). The tool also ingest ETCCDI indices from DLR extremeEvents namelist to perform additional and joint analysis.
Latest version for ESMValTool v2:
https://github.com/ESMValGroup/ESMValTool/tree/fix_hyint
Namelist
https://github.com/ESMValGroup/ESMValTool/blob/fix_hyint/esmvaltool/namelists/namelist_hyint.yml
R script:
https://github.com/ESMValGroup/ESMValTool/blob/fix_hyint/esmvaltool/diag_scripts/hyint.r
Auxiliary R routines:
https://github.com/ESMValGroup/ESMValTool/tree/fix_hyint/esmvaltool/diag_scripts/aux/hyint
Wiki reference:
https://github.com/ESMValGroup/ESMValTool-private/wiki/Namelist-MAGIC_HyInt
Current status: the ESMValTool v2 script works and was tested on CMIP5 models. It needs some final refinements.
Open issues:

regridding and model ensemble capabilities to be performed at pre-processor level
auxiliary routines to be placed following new diag_scripts structure
output file structure to be revised to be ingested by portal
the tool can/should ingest data from DLR extremeEvents namelist but that namelist is currently not working in ESMValTool2 (see related issue).

@earnone @jhardenberg Now that  #754 is merged, can this issue be closed?


Fix for WFLY-13906 and WFLY-13907

Issues:
https://issues.redhat.com/browse/WFLY-13906
https://issues.redhat.com/browse/WFLY-13907
Galleon diff:  https://github.com/wildfly/galleon/compare/4.2.5.Final...galleon-parent-4.2.6.Final
Bootable JAR diff: https://github.com/wildfly-extras/wildfly-jar-maven-plugin/compare/2.0.0.Beta7...2.0.0.Beta8

retest this please!

@jfdenise so https://ci.wildfly.org/viewLog.html?buildId=224572&buildTypeId=WF_PullRequest_GalleonLinuxJdk11 demonstrates that this isn't the fix for https://issues.redhat.com/browse/WFLY-13910.

@jfdenise Don't worry about WFLY-13910 -- see https://issues.redhat.com/browse/WFLY-13910?focusedCommentId=15185515&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15185515


Extract "Decision Under Appeal" data from structured metadata

For example: https://www.caselaw.nsw.gov.au/decision/5a1b6d49e4b058596cbac6af is a case appealing an earlier case with metadata as follows:

Court or Tribunal:    Supreme Court of New South Wales
Jurisdiction: Equity
Citation: [2016] NSWSC 360
Date of Decision: 01 April 2016
Before: Slattery J
File Number(s): 2013/359058

Where this metadata is available it should be read into the decision (and be included in the CSV output)

Note that a case will have its own values for the above metadata (jurisdiction, court/tribunal, etc) which will still need to be available


Issues running multiple instances

If you have two instances they cannot run in parallel as the values are not unique

Resolved


Add TextColor parsing to the Gutter

Just like event listeners and how IntelliJ ultimate will show off java.awt.Color instances in the gutter, and Icons, we should be able to parse over PsiElements that contain references to some various color based classes from different platforms.
Perhaps optionally make it where they are explicit to only show the first color instance found in a line if there are multiple colors in play?
It'd be very similar to how the ListenerLineMarkerProvider is handled.

That would be a good option, though by default we should probably show up to 3 icons if there's 3 or more in a row. Seems to me that's about how Ultimate behaves.

IntelliJ already has a hard limit on how many gutter icons can show, so we don't need to worry about that.


Appstudio update test-component-pac-zvcp

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-zvcp-on-pull-request has failed.

StatusDurationName

✅ Succeeded
17 seconds
init

✅ Succeeded
30 seconds
clone-repository

🏃 Running
---
build-container

Pipelines as Code CI/test-component-pac-zvcp-on-pull-request has failed.

StatusDurationName

✅ Succeeded
17 seconds
init

✅ Succeeded
30 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

Pipelines as Code CI/test-component-pac-zvcp-on-pull-request has failed.

StatusDurationName

✅ Succeeded
17 seconds
init

✅ Succeeded
30 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

Pipelines as Code CI/test-component-pac-zvcp-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
17 seconds
init

✅ Succeeded
30 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
17 seconds
sanity-inspect-image

✅ Succeeded
2 minutes
clair-scan

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
19 seconds
sanity-optional-label-check

✅ Succeeded
17 seconds
sanity-label-check

✅ Succeeded
7 seconds
show-summary


XML attributes with < symbol in value breaks syntax highlighting

What steps will reproduce the problem?
1. Set language to XML
2. Use attribute value with greater than or less than symbol
2. Syntax highlighting will break

Here's an example of a code snippet which breaks prettify.

    <Person AgeCategory="<3" ></Person>

Here's a fiddle with the same code:
http://jsfiddle.net/KyleMit/qpEhr/

What is the expected output?  What do you see instead?
Here's a screenshot of the current output vs. my expected output:
http://i.imgur.com/016JEsw.png

What version are you using?  On what browser?
https://google-code-prettify.googlecode.com/svn/loader/run_prettify.js
Running in Chrome (same for all browsers)

Please provide any additional information below.
Since the < or > symbol exists inside of quotes, it should be treated as a
string and should not affect the way that the code sample is parsed.

This is particularly an issue when attempting to use ASP.NET code (which
usually passes as XML) because of the use of inline script tags.
Here's an asp.net example:
http://jsfiddle.net/KyleMit/qpEhr/0/
http://i.imgur.com/wiuQDoK.png

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 2 Apr 2014 at 7:47

I think there is some confusion here..
Let say you want to end up with this XML document:
<?xml version="1.0"?>
<Person AgeCategory="<3" ></Person>

On one hand, if you want valid XML, you must escape special characters inside attribute values (i.e <3 inside the attribute value becomes <3). So the file would contain this:
<Person AgeCategory="<3" ></Person>

You can verify this fact using W3C Markup Validation Service.
On the other hand, if you want to include the above code inside
 , you must in turn escape those special characters (< turns to <, > into >, and & into &), meaning you have to use

<Person AgeCategory="&lt;3" ></Person>

So there is really escaping on two levels here!

Here is a live demo showing the correct way of writing this:
https://jsfiddle.net/amroamroamro/fqbxur91/1/


You can only play the video once

Example: https://www.instagram.com/p/B5dfbYegAnf/

Seems IG plays videos without 'loop' property now. Added it back.
Thank you for your feedback.

I wasnt talking about the loop feature. Sorry, my fault for not explaining it.
Im guessing you didnt play the video to the end. There is an image that covers the player when the video have reached the end.

I saw that cover picture, it was fixed when i added loop attribute.
Is it still reproducable for you? Also please make sure you have latest script version.


Add tests to ensure that Lightning is compatible with the specified version of PennyLane

Currently we say that Lightning is compatible with a specific version of PennyLane or higher, specified here and in requirements.txt.
We should add a test to make sure that this is the case.

Should this issue be closed?

Hi @trbromley; What are the acceptance criteria for this issue? I couldn't get what exactly the test must check.

With PR #353,  PennyLane-Lightning dependence with PennyLane will be set to the last available PennyLane version.