some mwdt compiler options can't be recognized by zephyr_cc_option

Describe the bug
some mwdt compiler options (-Xll64 -Xmpy_option=qmpyh -Xfpud_div) can't be recognized by zephyr_cc_option.
To Reproduce
Steps to reproduce the behavior:

west build -b hsdk -d build.mwdt tests/lib/sprintf/
See error

Logs and console output
 west build -b hsdk -d build.mwdt tests/lib/sprintf/-- west build: generating a build systemIncluding boilerplate (Zephyr base): /SCRATCH2/Watson/zephyrproject/zephyr/cmake/app/boilerplate.cmake-- Application: /SCRATCH2/Watson/zephyrproject/zephyr/tests/lib/sprintf-- Zephyr version: 2.6.0-rc1 (/SCRATCH2/Watson/zephyrproject/zephyr), build: v2.6.0-rc1-320-g374629af906a-- Found Python3: /depot/Python/Python-3.7.0/bin/python3.7 (found suitable exact version "3.7.0") found components: Interpreter -- Found west (found suitable version "0.10.1", minimum required is "0.7.1")-- Board: hsdk
-- Cache files will be written to: /u/zhiwei/.cache/zephyr
-- Using toolchain: zephyr 0.12.3 (/SCRATCH2/svc-arcoss_auto/tools/zephyr-sdk/0.12.3)
-- Found dtc: /SCRATCH2/svc-arcoss_auto/tools/zephyr-sdk/0.12.3/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.5.0", minimum required is "1.4.6")
-- Found BOARD.dts: /SCRATCH2/Watson/zephyrproject/zephyr/boards/arc/hsdk/hsdk.dts
-- Generated zephyr.dts: /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/zephyr.dts
-- Generated devicetree_unfixed.h: /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/include/generated/devicetree_unfixed.h
-- Generated device_extern.h: /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/include/generated/device_extern.h
Parsing /SCRATCH2/Watson/zephyrproject/zephyr/Kconfig
Loaded configuration '/SCRATCH2/Watson/zephyrproject/zephyr/boards/arc/hsdk/hsdk_defconfig'
Merged configuration '/SCRATCH2/Watson/zephyrproject/zephyr/tests/lib/sprintf/prj.conf'
Configuration saved to '/SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/.config'
Kconfig header saved to '/SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/include/generated/autoconf.h'
-- The C compiler identification is Clang 10.0.1
-- The CXX compiler identification is Clang 10.0.1
-- The ASM compiler identification is unknown
-- Found assembler: /global/apps/mwdt_2021.03/MetaWare/arc/bin/ccac
-- Warning: Did not find file Compiler/-ASM
CMake Warning at ../../../cmake/linker/arcmwdt/target.cmake:137 (message):
  MWDT toolchain does not support

             CONFIG_LINKER_ORPHAN_SECTION_WARN
Call Stack (most recent call first):
  ../../../CMakeLists.txt:246 (toolchain_ld_baremetal)

-- Configuring done
-- Generating done
-- Build files have been written to: /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt
-- west build: building application
[1/134] Preparing syscall dependency handling

[53/134] Building ASM object zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/switch.S.obj
FAILED: zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/switch.S.obj
/global/apps/mwdt_2021.03/MetaWare/arc/bin/ccac -DBUILD_VERSION=v2.6.0-rc1-320-g374629af906a -DKERNEL -D__ZEPHYR_SUPERVISOR__ -D__ZEPHYR__=1 -I../kernel/include -I../arch/arc/include -I../include -Izephyr/include/generated -I../soc/arc/snps_arc_hsdk -I../subsys/testsuite/include -I../subsys/testsuite/ztest/include -I../lib/libc/minimal/include -I/global/apps/mwdt_2021.03/MetaWare/arc/../../MetaWare/arc/inc -Os -imacros /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/include/generated/autoconf.h -Hnocrt -fno-common -g -Hnocopyr -HL -Hnosdata -Hoff=Stackcheck_alloca -Hasmcpp -imacros /SCRATCH2/Watson/zephyrproject/zephyr/include/toolchain/zephyr_stdint.h -D_ASMLANGUAGE -Wno-sometimes-uninitialized -Wno-shift-overflow -Wno-missing-braces -Wno-self-assign -Wno-address-of-packed-member -Wno-unused-function -Wno-initializer-overrides -Wno-section -Wno-unknown-warning-option -Wno-unused-variable -Wno-format-invalid-specifier -Wno-gnu -Wno-tautological-compare -ffunction-sections -fdata-sections -arcv2hs -core2 -Xatomic -Xunaligned -Xcode_density -Xdiv_rem=radix4 -Xswap -Xbitscan -Xshift_assist -Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc -Xfpu_mac -Hno_default_include -Hnoarcexlib -o zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/switch.S.obj -c /SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/switch.S
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] "/SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/switch.S",Line 96: error: This instruction cannot be encoded.
Memory or auxiliary register loads must have a register destination.
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] "/SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/switch.S",Line 96: error: This instruction cannot be encoded.
Memory or auxiliary register loads must have a register destination.
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] 2 errors generated.
[56/134] Building ASM object zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/regular_irq.S.obj
FAILED: zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/regular_irq.S.obj
/global/apps/mwdt_2021.03/MetaWare/arc/bin/ccac -DBUILD_VERSION=v2.6.0-rc1-320-g374629af906a -DKERNEL -D__ZEPHYR_SUPERVISOR__ -D__ZEPHYR__=1 -I../kernel/include -I../arch/arc/include -I../include -Izephyr/include/generated -I../soc/arc/snps_arc_hsdk -I../subsys/testsuite/include -I../subsys/testsuite/ztest/include -I../lib/libc/minimal/include -I/global/apps/mwdt_2021.03/MetaWare/arc/../../MetaWare/arc/inc -Os -imacros /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/include/generated/autoconf.h -Hnocrt -fno-common -g -Hnocopyr -HL -Hnosdata -Hoff=Stackcheck_alloca -Hasmcpp -imacros /SCRATCH2/Watson/zephyrproject/zephyr/include/toolchain/zephyr_stdint.h -D_ASMLANGUAGE -Wno-sometimes-uninitialized -Wno-shift-overflow -Wno-missing-braces -Wno-self-assign -Wno-address-of-packed-member -Wno-unused-function -Wno-initializer-overrides -Wno-section -Wno-unknown-warning-option -Wno-unused-variable -Wno-format-invalid-specifier -Wno-gnu -Wno-tautological-compare -ffunction-sections -fdata-sections -arcv2hs -core2 -Xatomic -Xunaligned -Xcode_density -Xdiv_rem=radix4 -Xswap -Xbitscan -Xshift_assist -Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc -Xfpu_mac -Hno_default_include -Hnoarcexlib -o zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/regular_irq.S.obj -c /SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/regular_irq.S
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] "/SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/regular_irq.S",Line 277: error: This instruction cannot be encoded.
Memory or auxiliary register loads must have a register destination.
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] "/SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/regular_irq.S",Line 277: error: This instruction cannot be encoded.
Memory or auxiliary register loads must have a register destination.
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] 2 errors generated.
[57/134] Building ASM object zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/fast_irq.S.obj
FAILED: zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/fast_irq.S.obj
/global/apps/mwdt_2021.03/MetaWare/arc/bin/ccac -DBUILD_VERSION=v2.6.0-rc1-320-g374629af906a -DKERNEL -D__ZEPHYR_SUPERVISOR__ -D__ZEPHYR__=1 -I../kernel/include -I../arch/arc/include -I../include -Izephyr/include/generated -I../soc/arc/snps_arc_hsdk -I../subsys/testsuite/include -I../subsys/testsuite/ztest/include -I../lib/libc/minimal/include -I/global/apps/mwdt_2021.03/MetaWare/arc/../../MetaWare/arc/inc -Os -imacros /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt/zephyr/include/generated/autoconf.h -Hnocrt -fno-common -g -Hnocopyr -HL -Hnosdata -Hoff=Stackcheck_alloca -Hasmcpp -imacros /SCRATCH2/Watson/zephyrproject/zephyr/include/toolchain/zephyr_stdint.h -D_ASMLANGUAGE -Wno-sometimes-uninitialized -Wno-shift-overflow -Wno-missing-braces -Wno-self-assign -Wno-address-of-packed-member -Wno-unused-function -Wno-initializer-overrides -Wno-section -Wno-unknown-warning-option -Wno-unused-variable -Wno-format-invalid-specifier -Wno-gnu -Wno-tautological-compare -ffunction-sections -fdata-sections -arcv2hs -core2 -Xatomic -Xunaligned -Xcode_density -Xdiv_rem=radix4 -Xswap -Xbitscan -Xshift_assist -Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc -Xfpu_mac -Hno_default_include -Hnoarcexlib -o zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/fast_irq.S.obj -c /SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/fast_irq.S
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] "/SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/fast_irq.S",Line 255: error: This instruction cannot be encoded.
Memory or auxiliary register loads must have a register destination.
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] "/SCRATCH2/Watson/zephyrproject/zephyr/arch/arc/core/fast_irq.S",Line 255: error: This instruction cannot be encoded.
Memory or auxiliary register loads must have a register destination.
[/global/apps/mwdt_2021.03/MetaWare/arc/bin/asac] 2 errors generated.
[66/134] Building C object zephyr/arch/arch/arc/core/CMakeFiles/arch__arc__core.dir/arc_connect.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /depot/Python/Python-3.7.0/bin/cmake --build /SCRATCH2/Watson/zephyrproject/zephyr/build.mwdt

Environment (please complete the following information):

OS: (Linux)
Toolchain (arcmwdt)
Commit SHA: 374629af906a24add294b1c3b945128cb6a486e8

Additional context
we add some MWDT compiler options using zephyr_cc_option, which will call cmake function check_c_compiler_flag for each option. check_c_compiler_flag will check whether the C compiler supports the given option. If the option is supported, then cmake will use these options as compile options.
https://github.com/zephyrproject-rtos/zephyr/blob/374629af906a24add294b1c3b945128cb6a486e8/soc/arc/snps_arc_hsdk/CMakeLists.txt#L13-L19
Then if you check the compile options in the error log:
-arcv2hs -core2 -Xatomic -Xunaligned -Xcode_density
-Xdiv_rem=radix4 -Xswap -Xbitscan
-Xshift_assist -Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc
-Xfpu_mac

you will find we miss these options: -Xll64 -Xmpy_option=qmpyh -Xfpud_div

@IRISZZW it would be interesting to figure out why these particular options don't work nice with check_c_compiler_flag. My guess it they are not "self-contained", i.e. first require "top-level" option like CPU family (AKA -arcv2hs or -arcv2em) to exist. Though these are just y guesses which would be good to prove or dismiss.

@IRISZZW it would be interesting to figure out why these particular options don't work nice with check_c_compiler_flag. My guess it they are not "self-contained", i.e. first require "top-level" option like CPU family (AKA -arcv2hs or -arcv2em) to exist. Though these are just y guesses which would be good to prove or dismiss.

you are right, they are not "self-contained":
$ cat main.c
int main(void)
{
        return 0;
}

$ ccac -Xll64 main.c
[ccac] Argument `-Xll64' is invalid: This feature only applies to AV2HS and AV3HS
Aborting...

$ ccac -Xfpud_div main.c
[ccac] Argument `-Xfpud_div' is invalid: This feature only applies to AV2HS
Aborting...

$ ccac -Xmpy_option=qmpyh  main.c
[ccac] Argument `-Xmpy_option=qmpyh' is invalid: The "MPY OPTION" value for the ARC EM processor is limited to 1 through 8 and w,wlh1,wlh2,wlh3,wlh4,wlh5,mpy16,mpy,mac,mpyd
Aborting...

@evgeniy-paltsev @tejlmand any hints on how can we test options which have dependencies?
I.e. if option -option1 is only being recognized when -option2 also passed to the compiler.

Actually I don't see any purpose of this options test - given that we don't provide any kind of alternate options if the original options are not supported by compiler. So in my point of view the replacement of zephyr_cc_option by zephyr_compile_options looks valid.


Generate doc-comment for syntax node initializers

As discussed in #1598:

if the child's documentation is nil parameter is skipped,
only the first line of the child's documentation is shown,
to all nodes leadingTrivia and trailingTrivia documentation (with static text) is added.

@swift-ci Please test

@swift-ci please test

@swift-ci Please test


Add default timeouts for SMTP

I get lots of reports of "stuck" Sidekiq jobs due to email delivery. SMTP servers in the wild are notoriously unreliable, e.g. spam honeypots can leave TCP connections lingering. We need network connection timeouts by default.

See also rails/rails#41248

@jeremy Looks fine to me


Add-ExcelName with formula parsing

Hi,
I have enjoyed your module and was wondering if it's possible to add a formula parameter to the Add-ExcelName function and parsing similar to Set-ExcelRange in order to make it more dynamic, instead of a fixed range evaluated only once the named range is defined.
Let me know if there's better ways to achieve this.

Thanks. Could you say a bit more about what you're trying to do? Post and small would be great too.

For example,
I want a named range of a constant value:
Name: tax_rate
Value: =1.0725
And be able to use it the named range in formulas like
=275*tax_rate
The more complicated example includes defined a ranged of cells which I vaguely know the limits:
Name: range1
Value:
=OFFSET(INDIRECT(ADDRESS(1,1,1,1,
"Sheet1"
)),0,0,COUNTA(OFFSET(INDIRECT(ADDRESS(1,1,1,1,
"Sheet1"
)),0,0,1300)),COUNTA(OFFSET(INDIRECT(ADDRESS(1,1,1,1,
"Sheet1"
)),0,0,,25)))
and be able to use it in formulas like
=OFFSET(range1,0,0,,1)
I would prefer to define the names from powershell using this module instead of relying on VBA to define the named ranges

@MikeyBronowski wanted to get your thoughts on this when you have time

Looking thru StackOverflow answers and the EPPlus docs (https://epplussoftware.com/docs/5.7/api/OfficeOpenXml.ExcelNamedRangeCollection.html) I found the solution:
You just need to access the Names property inside the workbook and use the respective Add() method:
Set-Location $env:TEMP
$excelFiles = "~/ImportExcelHowTo_v1.xlsm"
Remove-Item $excelFiles -ErrorAction SilentlyContinue
$excelPackage = Get-Process | Export-Excel -Path $excelFiles -PassThru
$wb = $excelPackage.workbook
$sh = $wb.worksheets['sheet1']
$null = $wb.Names.Add('range1', $sh.cells['A1'])
$null = $wb.Names.AddValue('value2', 53)
$null = $wb.Names.AddFormula('formula3', 'MAX(5,3)')
Close-ExcelPackage $excelPackage

@darg2012 Thanks! Would you be up to doing a PR and adding this in the Examples folder? \Examples\AddExcelName.

Yes, I saw it but since the sheets I used for the named ranges are querytables to external files I needed a dynamic formula instead of a static range.
@dfinke Of course, let me just finish this semester and I'll learn github's collab tools and do the contributions early next year.
Thanks for your time and help!


server error when downloading mods

When downloading some mods it returns an error. Example:
Mod 'Notifications v5.1' could not be installed: java.io.IOException: Server returned HTTP response code: 400 for URL: http://content.faforever.com/mods/Notifications v5.1.v0005.zip
When pasting the URL in Firefox the zip file can be downloaded without issues.
This does not happen on all mods. Tested it with TA music mod and that one works.
Supreme Economy even got bad reviews because people can't download it.

See fixes in newest release candidate https://github.com/FAForever/downlords-faf-client/releases

I would close, seems like duplicate to https://github.com/FAForever/downlords-faf-client/issues/1373
@axel1200 what do you think?

woops, should have also searched the closed issues, my bad.
I am fairly certain that this is the same issue.

@BlackYps Feel free to download the latest RC version, and test it. You can help us make product better.

The RC releases are invisible now, so if anybody reads wondering where to get the RC:
https://content.faforever.com/dfc_windows-x64_1_0_0-RC10.exe


imagej-utils dependency

@K-Meech
I added the imagej-utils dependency to your repository (pom).

Please try to remove the copied code from you repo and let me know whether that works.
We have to discuss how to ship the imagej-utils to your update site (this is different from having it work locally for you).

Thanks @tischi - I'll try this out later in the week, and let you know how it goes

I can't seem to find the imagej-utils dependency - it errors with 'Dependency de.embl.cba:imagej-utils:0.5.3 not found'.  Do I need to list another repository in the pom?

Adding the repository https://dl.bintray.com/tischi/snapshots resolves this - as in the mobie pom https://github.com/mobie/mobie-viewer-fiji/blob/master/pom.xml#L122

Spoke too soon - still has issues finding the pom. Errors with 'Failure to find de.embl.cba:imagej-utils:pom:0.5.3 in https://dl.bintray.com/tischi/snapshots'. Any ideas @tischi?

Jar is in maven.scijava.org - changing name to -SNAPSHOT works: https://github.com/K-Meech/crosshair/commit/2dbc1b11e5c41c32aa5645d1444514c7626348e8

@K-Meech wrote:

changing name to -SNAPSHOT works

This is because @tischi didn't cut a new release since it is deployed to the scijava maven repo.
@tischi once you cut a release (using release-version.sh as usual), this repo can depend on a non-SNAPSHOT version without having to skip the enforcer.


How can I write console.log outputs on the terminal?

Hi, I'm working on a package and I would like to know if is posible to write the the outputs on the terminal.
some thing like this, for example.
{CompositeDisposable} = require "atom"

configSchema = require "./config-schema"
introAudio = require "./play-intro"

module.exports = activateBackgroundMusic =

  config: configSchema
  subscriptions: null
  active: false

  activate: (state) ->
    @terminal = new terminal-plus
    @terminal.text += "this plugin is activated"
    @subscriptions = new CompositeDisposable
    @subscriptions.add atom.commands.add "atom-workspace",
      "activate-background-music:toggle": => @toggle()

    @terminal.text += (introAudio.title+ ": is playing.")
    @introAudio.play()

instead of using console.log.

I found a different way.


Android - TrackPlayer.add() is not stable

Describe the Bug
To reproduce, just select and play a song
When doing a TrackPlayer setup, we have this code below which works consistently on iOS but fails ~60% of the time on Android:

await TrackPlayer.reset();
console.log('tracksTemp.length: ', tracksTemp.length);  // tracksTemp.length: 3
console.log('selectedTrackIndex: ', selectedTrackIndex); // selectedTrackIndex: 2
await TrackPlayer.add(tracksTemp);
console.log('TrackPlayer.getQueue: ', (await TrackPlayer.getQueue()).length); // TrackPlayer.getQueue: 2
await TrackPlayer.skip(selectedTrackIndex);`

Error:

Environment Info:
Paste the results of npx react-native info
info Fetching system and libraries information... System:     OS: macOS 12.6     CPU: (10) arm64 Apple M1 Max     Memory: 117.20 MB / 32.00 GB     Shell: 5.8.1 - /bin/zsh   Binaries:     Node: 18.10.0 - /opt/homebrew/bin/node     Yarn: 1.22.19 - /opt/homebrew/bin/yarn     npm: 8.19.2 - /opt/homebrew/bin/npm     Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman   Managers:     CocoaPods: 1.11.3 - /opt/homebrew/bin/pod   SDKs:     iOS SDK:       Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0     Android SDK: Not Found   IDEs:     Android Studio: 2021.3 AI-213.7172.25.2113.9014738     Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild   Languages:     Java: <IP_ADDRESS> - /usr/bin/javac   npmPackages:     @react-native-community/cli: Not Found     react: 18.0.0 => 18.0.0      react-native: 0.69.6 => 0.69.6      react-native-macos: Not Found   npmGlobalPackages:     *react-native*: Not Found info React Native v0.70.3 is now available (your project is running on v0.69.6). info Changelog: https://github.com/facebook/react-native/releases/tag/v0.70.3. info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.69.6. info To upgrade, run "react-native upgrade".
Paste the exact react-native-track-player version you are using
"react-native-track-player": "2.2.0-rc3",
Real device? Or simulator?
Simulator
What OS are you running?
Android 33

@iboxgithub
First, you're using a super old version of RNTP (v2.2.0-rc3), please upgrade to the latest version.
If you're still getting this issue on the latest version then these are my thoughts:
it looks like the issue is that one of your tracks is failing to add and then you're attempting to access an index that doesn't exist (which makes sense that it's throwing an exception, although it should probably not crash your app, but bubble up through the error event api).

@iboxgithub if I don't hear anything back soon, I'm going to close this issue.

Apologies, so we manage to upgrade to 3.1.0 which solves the issue. Otherwise too many missing dependencies with expo 46. Thanks for your help!


Rename EndpointResult to Result

Description

Rename EndptResult to Result.
Motivation and Context

https://github.com/rustasync/tide/issues/235
How Has This Been Tested?

Compile all and run test code
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@prasannavl In the example, I think it is more intuitive to return a simple Result. However, for tide developers, it may not be desirable to change "EndpointResult" to "Result".
I have this idea. By defining tide :: Result as an alias of EndpointResult, user use  'Result', tide developer use EndpointResult.  What do you think?

@prasannavl  ?

Hi @k-nasa - Sorry, been a bit busy. I'm keen to see that others think of this. Meanwhile https://github.com/rustasync/tide/issues/235#issuecomment-495981039.

@prasannavl Ok. thanks!  And sorry to rush


python3Packages.clickhouse-driver: 0.2.2 -> 0.2.5

Description of changes
Please see https://github.com/mymarilyn/clickhouse-driver/blob/0.2.5/CHANGELOG.md for the changes
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.clickhouse-driver
python311Packages.clickhouse-driver

@ofborg build python3Packages.clickhouse-driver

Result of nixpkgs-review pr 213944 run on aarch64-darwin 1

2 packages built:

python310Packages.clickhouse-driver
python311Packages.clickhouse-driver


Write out current route's commit/id in the overlay

https://api.commadotai.com/v1/route/fe18f736cb0d7813|2022-11-13--17-35-24/

Done


Calling getBuildings() for minecolonies-1.0.200-ALPHA crashes

Descripe
Looks like some incompatibly happens when you use minecolonies-1.0.200-ALPHA and advancedperipherals-1.16.5-0.7.5r. My code that worked in minecolonies-1.0.0-RELEASE, now crashes the game. Minecolonies does recommend running the lastest alpha. Update to the latest alpha if you are not running the latest. (Alpha does not mean it’s unstable, it just means it’s a relatively small release.)
colony = peripheral.find('colonyIntegrator')

mon = peripheral.wrap("left")

function Test()
    term.redirect(mon)

    line = 1
    for k, v in ipairs(colony.getBuildings()) do
        num = k

        if num < 10 then
            num = "0" .. num
        end

        name = ''

        if v.citizens[1] ~= nil then
            for i, t in ipairs(v.citizens) do
                name = name .. ' ' .. t.name
            end
        else
            name = " Empty"
        end
        print(num .. ": " .. v.name .. ' ' .. name)

    end
end

while true do
   mon.clear()
   mon.setCursorPos(1, 1)

    Test()
    sleep(1)
end

Steps to reproduce
Have and be inside of a colony
Get peripheral colony = peripheral.find('colonyIntegrator')
Call getBuildings()
Crash to  desktop
Multiplayer?
false
Version
<IP_ADDRESS>b (Latest)
Minecraft, Forge and maybe other related mods versions
Forge 36.2.19 1.16.5
Screenshots or Videos
No response
Crashlog/log
https://pastebin.com/FZzqcd1J

Also I don't know if its possible, but you should try to keep compatibility with minecolonies-1.0.0-RELEASE, as that is what curseForge downloads by default

1.0.200-ALPHA is currently not on their maven repo(https://github.com/ldtteam/minecolonies/issues/7837)
So I'll for now use cursemaven until their fix that
I will release a fix in the next days

Fixed in 1.16.5-0.7.6r


add: function to get the metadata property of the AVFrame

[Current coverage][cc-pull] is 29.26%

Merging [#19][cc-pull] into [master][cc-base-branch] will increase coverage by 2.07%

File avutil/avutil.go was modified. more

Misses -1
Partials -7
Hits +8

File avcodec/avcodec.go (not in diff) was modified. more

Misses 0
Partials -6
Hits +6

File avfilter/avfilter.go (not in diff) was modified. more

Misses 0
Partials -5
Hits +5

File avformat/avformat.go (not in diff) was modified. more

Misses 0
Partials -23
Hits +23

@@           master        #19   diff @@
========================================
  Files           4          4
  Lines        2369       2379    +10
  Methods         0          0
  Branches       84          0    -84
========================================
+ Hits          644        696    +52
+ Misses       1684       1683     -1
+ Partials       41          0    -41

Powered by Codecov. Last updated by [922dcf9...7575942][cc-compare]
[cc-base-branch]: https://codecov.io/gh/imkira/go-libav/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/imkira/go-libav/compare/922dcf97b3111642a749b7c2b4e23a37be1529c0...757594290289a4ac64b4c22f4ab0480f0473879e
[cc-pull]: https://codecov.io/gh/imkira/go-libav/pull/19?src=pr

Thanks


[Consensus] Add MinBlockTime to delay mempool reaping

Description
This PR implements delaying mempool reaping by MinBlockTime, resetting the timer at every new height
All the logic lives in consensus/pacemaker/module.go, and the actual delay is happening consensus/hotstuff_leader.go
The mechanism ensures:

Block proposal is made only once per block
If the timer expires before having a block candidate, the first call to this method will trigger the block proposal
If a late message is received after a block is proposed by another call, the late message is discarded
Decoupling timer registration and signaling

Concurrent requests
sequenceDiagram
  participant ReapMempool
  participant BlockPrepare
  participant Delay

  ReapMempool->>BlockPrepare:RequestPrepare (id=1)
  BlockPrepare->>+Delay:Start delay
  Note right of Delay: Wait for minBlockTime
  ReapMempool->>BlockPrepare:RequestPrepare (id=2)
  BlockPrepare--xReapMempool:doNotPrepare (id=1)
  Delay->>-BlockPrepare:End delay
  BlockPrepare->>ReapMempool:doPrepare (id=2)
  ReapMempool->>BlockPrepare: Prepare block

Late requests
sequenceDiagram
  participant ReapMempool
  participant BlockPrepare
  participant Delay

  BlockPrepare->>+Delay:Start delay
  Note right of Delay: Wait for minBlockTime
  Delay->>-BlockPrepare:End delay
  ReapMempool->>BlockPrepare:doPrepare (id=1)
  BlockPrepare->>ReapMempool:RequestPrepare (id=1)
  ReapMempool->>BlockPrepare: Prepare block

Summary generated by Reviewpad on 02 Aug 23 18:00 UTC
This pull request introduces several changes across multiple files:

The cli-client.yaml file includes the addition of a new environment variable, POCKET_IBC_HOST_PRIVATE_KEY, and changes to existing environment variables related to Postgres.
The block.go file has changes related to package imports and modifications to various functions.
The uow_leader.go file includes changes to import statements and modifications in the CreateProposalBlock and reapMempool functions.
The ibc/module.go file has a small modification relating to a function call change.
The ibc_handle_event_test.go file has a change related to the substitution of a method call.
The db.go file has changes related to comments, function additions, and modifications.
The utility/unit_of_work/block.go file includes changes to function implementations and comments.
The ibc_handler.go file introduces a new interface and associated methods.
The transaction.go file has changes related to the HandleTransaction function and import statements.
The pacemaker_test.go file introduces new unit tests.
The Tiltfile file includes changes relating to configurations and values.
The consensus_config.proto file has an addition of a new field.
The persistence_module.go file has changes relating to method modifications, interface additions, and a TODO implementation.
The runtime/manager.go file includes a comment regarding technical debt.
The manager.go file has import statement additions and a new function.
The bsc.go file has changes related to function renaming and updates to function calls.
The README.md file has information regarding the disabling of pre-commit changelog verification.

Please review these changes in detail to ensure they meet the requirements of the codebase.

Issue
Fixes #705
Type of change
Please mark the relevant option(s):

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Change #1
Change #2
...

Testing

[x] make develop_test; if any code changes were made
[ ] make test_e2e on k8s LocalNet; if any code changes were made
[ ] e2e-devnet-test passes tests on DevNet; if any code was changed
[ ] Docker Compose LocalNet; if any major functionality was changed or introduced
[ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@red-0ne Please make sure to update the issues & PR meta fields in the future. Updated it in this one for reference.

Just want to see if we can make it a bit simpler.

We can. True that this implementation is intricate. It's coupling timer registration with the client/listener logic which should not. I will split this into a timer registration function and a listening one. It would be much simpler to reason about.

@Olshansk the logic should be more readable and ready to review now. Which makes me think about the nature of the delay.
We are currently enforcing it at the leader level. Which means that if the leader wants to prepare the block earlier, there's nothing enforcing it not to do so.
But if we place the delay at the new round message emission point. All (honest) replicas will delay their new round messages so that the leader could not reach the consensus and build the block earlier. This would mean that each block proposal time is enforced by the whole network instead of by its leader only. We could floor the delay imposed by replicas (eg. -10%) and let the leader that window to fine grain the timer.
The problem I see with it, is that it makes reaching consensus always a hurry task, an adjustable offset could do the trick and even be dynamic. Also choreographing the replicas to distribute their deadlines over MinBlockTime period may also be worth digging.
This should not be that much of a change :smile: Since at the new round construction level, any node knows if it's the leader of that round or not:

If it is a leader

Registers the timer at that exact moment (the earliest a node knows there's a new round and that it's the leader)
Sends the new round to itself (acts like a replica)
If it reaches new round quorum it prepares the block by applying the delay logic according to its local timer

If it's a replica

Registers the timer at that exact moment (the earliest that replica commits for the new round --should be same as leader)
Delays broadcasting new round message to the leader by MinBockTime - AdjustableOffset ± (Randomness or distribution function)

--
This way, for a 15minutes block time the whole network could eg. enforce that a block is proposed no earlier than 14minutes, and leader makes sure it lands at the 15minutes mark
This may be overprotocoling too :rofl:

You have great diagrams in the github description, but it'll get lost and forgotten. Can you add it to a README either in this PR or another one?

I will create pace maker documentation along the requested changes.

I will create pace maker documentation along the requested changes.

Sounds great!

Please re-request the review when I should take another look
For comments that are tended to and don't need an action, go ahead and resolve them. If more conversation is needed, leave them open and we will keep the discussion going.

Note to self: Add the above to the code review guidelines.

I will create pace maker documentation along the requested changes.

PaceMaker documentation added to PR#915

@red-0ne Just a couple more lingering edits/suggestions.
Also, I wanted to confirm that you tested this with Localnet and everything worked fine end-to-end? 👍
?

@red-0ne

The delay is effectively applied when running in non-manual mode.

That makes sense. This is intended for non-manual mode only. Wdyt of adding an assertion for this?

Even if I had issues with block building (which seems to be coming from somewhere else).

Consider trying to revert to the main branch and seeing if you see the same issues in that context. If that's the case, and it's an issue on main, I'll jump in to debug immediately. If not, let me know if/when I should dive deeper into the code in this PR.

@Olshansk

That makes sense. This is intended for non-manual mode only. Wdyt of adding an assertion for this?

The only way I see to test this is through real clock (and wait for consensus on new round to happen). Any ideas?

Consider trying to revert to the main branch and seeing if you see the same issues in that context. If that's the case, and it's an issue on main, I'll jump in to debug immediately. If not, let me know if/when I should dive deeper into the code in this PR.

Created an issue for that #965, it is not blocking this work.

You mean enable the feature only when manual is false ?

Yes.
If manual == true  => skip code path for minBlockTime


PGAdmin4 failed to start on Windows

Hi,
I cannot start the extension on my machine:

Windows 11
Docker Desktop 4.15.0
PGAdmin4-docker-extension 6.17.0

Note: it works on mac
When opening the extension, I receive this message:

PGAdmin4 failed to start, please close the extension and reopen/reinstall to try again.

Debugging:
I have opened debugger using docker extension dev debug mochoa/pgadmin4-docker-extension. This is the error:

cmd: "docker exec mochoa_pgadmin4-docker-extension-desktop-extension-pgadmin-1 python3 -c "import sqlite3;c=sqlite3.connect('/var/lib/pgadmin/pgadmin4.db');u=c.cursor();u.execute('insert or replace into user_preferences (pid,uid,value) values ((SELECT id from preferences where name=?),1,?)',('theme','dark'));c.commit();u.close();c.close()" || true"
stderr: "Traceback (most recent call last):\n File "", line 1, in \nsqlite3.IntegrityError: NOT NULL constraint failed: user_preferences.pid\n'true' is not recognized as an internal or external command,\r\noperable program or batch file.\r\n"

Hi @ivan-curkovic
Try checking if PGAdmin container is running properly with:
$ docker exec -ti mochoa_pgadmin4-docker-extension-desktop-extension-pgadmin-1 pwd
/pgadmin4

Next try connecting using an external browser using http://localhost:9080/
Once you connect for the first time the sqllite user preference is defined and the extension should work.
6.17 release have a fix at the end of the exec command with || true as fallback action if sqllite fail, but seem that on Windows doesn't work.
Marcelo.
PD: I just released 6.18 version. I tested it on Windows and open the URL with any browser solve the initial setup problem of the sqllite database.

Fixed on commit, by default first run will start on light mode, to proper align with Docker Desktop UI mode just close and open again.
Marcelo.

hi @marcelo-ochoa, it works now. Thank you for the fast response and happy new year :)


add tdf-prm import

add import option for prm-PASEF data
stored as regular PasefMsMsInfo so it can be dealt with in regular workflows

<3


Create new activity page

Review / Update mockup to fit into materialize guide lines.
Need mockups for both Desktop and Mobile version.
ilya to provide current screenshot of page

Current View:

IN Progress View:

Another in progress: https://cloud.githubusercontent.com/assets/3118211/6474455/e88741c0-c1a4-11e4-8f4d-e282b53f25f3.jpg
We need to finalize this ;)

I like same page

How to create new baby - how is it handle by material design

What I have done:

checked all metrics and keylines according material diz
created drop-down menu

Hi, yes this should be good for now!
Looks like simple menu from here: http://www.google.com/design/spec/components/dialogs.html
Can we display icons inside simple menu? or bad practice? such as person icon and for new (+)

Check this out:

Title: Select person
person1
person2
Add person

looks nice.. suspect it will be great if we add avatars next to their names..
what about cards with avatars?

looks nice.. suspect it will be great if we add avatars next to their names..
what about cards with avatars?

I took it from here http://www.google.com/design/spec/components/menus.html
I think we can use dialog instead. Need to make a little research first

here is how is dialog looks like

It also can be like that

more information here http://www.google.com/design/spec/components/dialogs.html#dialogs-simple-dialogs

Time picker http://www.google.com/design/spec/components/pickers.html#pickers-time-pickers

If you need drop down menu you can find it above. You also can find all rules for that here http://www.google.com/design/spec/components/menus.html#menus-behavior

Anastasia, can u provide me with basic action pictures like bottle, poop, pee ... ?


[FEATURE REQUEST] wlr/taskbar let the cursor over the icon

I had to install the module wlr/taskbar because some times my wife sits on my computer and she can't even figure how to open anything. So I've used to use that module myself.
I find annoying to click in the icon and the cursor disappearing from there and placing itself in the middle of the clicked application. I know this is a normal behavior in hypraland (and perhaps others), but feels unnatural when clicking on a taskbar item.
I see in the waybar-wlr-taskbar man page there are just some click actions, like activate, close, maximize, etc... I would love to see an option let the cursor just there, where I just clicked above that icon.
I've been playing with hyprctl cursorpos to obtain the coordinates and screen of the cursor, and hyprctl dispatch movecursor to move the cursor where I want, so if in the wlr-taskbar would be an action "execute_command" and we would be able to run our custom command on-click, on-click-middle, and on-click-right, we would be able not just to do exactly that, but extend functionality of the events way a lot more.

Some background info: right now, the action handling in wlr/taskbar is a bit broken, because the on-clicks are evaluated by both wlr-taskbar on the individual buttons and AModule on the whole module. PR #3240 would fix that. If it's merged, you could theoretically do something like
{
    "layer": "top", // Waybar at top layer
    "position": "top", // Waybar position (top|bottom|left|right)
    "height" : 50,
    "modules-center": ["wlr/taskbar"],
    "wlr/taskbar": {
      "format": "{icon}",
      "icon-size": 24,
      "all-outputs": false,
      "unknown-action-is-command" : true,
      "actions" : {
          "on-click": "activate",
          "on-click-middle": "maximize",
          "on-click-right": "close",
      },
     "on-click": "module-wide-action.sh",
      "on-click-middle": "module-wide-action.sh",
      "on-click-right": "module-wide-action.sh",
    },
}

and both the wlr window action and the script should be executed. For actually moving the cursor back, this is no option, because you can't run a script before and after and generally it'd probably race anyway.
I suppose it would be nice to create a followup PR to allow custom commands to be run INSTEAD of the window action, and then the user can do whatever they want, e.g. run hyprctl to retrieve cursor position, activate or close a window and then move the cursor back to the original position. But I think this is still not going to work. wlr/taskbar is using wlr foreign toplevel handles, see https://wayland.app/protocols/wlr-foreign-toplevel-management-unstable-v1 . AFAIK, this handle does not translate into anything you can use with hyprctl (or swaymsg, for that matter).
BTW, on sway, the cursor does NOT jump to the window in question. And the protocol does not say anything about cursor handling for the individual action. My best suggestion is to ask the Hyprland people why it does.


Storybook

Goals

Extract component documentation out of catalog
Catalog is only kept for "application user guide" right now. It could be completely moved to storybook in a second step.

Comments

Tried to use vite but it did not work well
Used where applicable .mock.ts files that are used inside stories. In the future, we should take a look at how we could
share more mocks between components
Storybook can be sometimes a bit unstable and hang, see "Common errors" section
Could reuse the "theme.stories.tsx" from "uis" :+1:
I tried to follow the components / organisms / pages nomenclature
Storybook is built separate from the main application. It is built into the public/ folder so that it is available via /storybook.

Common errors when developing on Storybook

Providers do not work

Need to wrap to use Story or Canvas so that they are wrapped by the decorators configured in preview.ts

Canvas' of does not work

Need to use  in the docs file
Story need to be loaded in main.ts (beware of tsx/mdx extension). This error was because during developement, I manually added one by one each story, otherwise there were errors. Now that there is a glob for all *.docs.mdx and *.stories.tsx, it should be OK.

At least one component must be exported otherwise the story file can be reported missing ()

Sometimes, loading a story hangs. Restarting storybook, and sometimes the browser helps.

Very cool @ptbrowne 🎉 Thanks for this!


Test usage of hostPath PersistentVolume

Bluemix Container service got its Kubernetes server version upgraded to v1.7.4 recently. After this upgrade, we started seeing issues with hostPath PersistentVolumes (PV) as reported in https://github.com/IBM/deploy-graph-db-container/issues/3 (we had no such issues with the older v.1.5.x Kubernetes server version). Since this repo also uses hostPath PV, please test it out once and see if you need similar fix.

hostPath works with new clusters. Tested on 1.7 and 1.8


Not receiving phone call when ICMP is down

Hi I have configured the Cabot and added by Twilio phone number from my account, when the server is down, Cabot is clearly identifying it is down, but I am not receiving any phone call, HELP wanted.

Is the alert CRITICAL? Phone calls will not trigger for other severities.

Yes the alert is kept critical only

Steps I followed to get the phone call.
1 - created account in Twilio.
2 - configured SID, token, and phone number I have in my Twilio account into production.env
3 - entered the Twilio phone number in the alert subscriptions section in Cabot GUI.
Am I missing anything else ?

What I am unable to figure out is Twilio gave me a number, now how do I get the call if Cabot makes the call to Twilio phone number, do I need to map my personal phone number to Twilio number.

Do I need to upgrade my Twilio i.e pay some amount, to get phone calls?

yes

also the phone number should be the number you want Twilio to call, not the Twilio number itself. (i.e. your mobile)

Hi, I have configured Twilio phone number, SID, token in production.env and in Cabot GUI>alert subscription> Twilio phone number (here I kept my actual mobile number) also I have 15$ credit in my Twilio account, but I am not getting a phone call when the ICMP is down, need help.
in Twilio usage, I can see some money has been cut for

Now I am confused, what phone number should I use in production.env and what phone number should I use in Cabot GUI

Hi, finally getting call now, it's due to country code,
what to configure if I had to check the ICMP for each second in ICMP checks because I am getting a phone call very late.


Sample code for a downstream device that connects to an IoT Edge device

Checklist

[x ] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-python/blob/master/.github/CONTRIBUTING.md).
[ x] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
If this is a modification that impacts the behavior of a public API

[ ] I edited the corresponding document in the devdoc folder and added or modified requirements.

I submitted this PR against the correct branch:

[ ] This pull-request is submitted against the master branch.
[ ] I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
[ ] I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)
Description of the problem

Providing a sample to make it easier for users to connect downstream devices to an Azure IoT Edge device,
Description of the solution

Added a sample that highlights how a developer should put together a connection string for the Edge and install the relevant CA certificate required to authenticate the Azure IoT Edge server certificate. The sample was based off simple_sample_device.js with the required pieces to connect to an Edge.

Thanks reporting this, I have added the copyright notice.


set unread

Testing Plan:
GIFs or Screenshots:

@victorphoenix3 this PR doesn't follow our version control guidelines; can you redo it?
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages


Add additional explanation to color schemes page

Add a "Adding a color scheme to a profile" section to the color schemes. This should help further explain how to add color scheme to a profile.
Closes #129
Closes #130

Docs Build status updates of commit b4948e5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/customize-settings/color-schemes.md
:warning:Warning
View
Details

TerminalDocs/tips-and-tricks.md
:warning:Warning
View
Details

TerminalDocs/get-started.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/global-settings.md
:warning:Warning
View
Details

TerminalDocs/dynamic-profiles.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/frosted-glass-theme.md
:warning:Warning
View
Details

TerminalDocs/command-palette.md
:warning:Warning
View
Details

TerminalDocs/index.md
:warning:Warning
View
Details

TerminalDocs/command-line-arguments.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/powerline-in-powershell.md
:warning:Warning
View
Details

TerminalDocs/cascadia-code.md
:warning:Warning
View
Details

TerminalDocs/panes.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/key-bindings.md
:warning:Warning
View
Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/tutorials/tab-title.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/profile-settings.md
:warning:Warning
View
Details

TerminalDocs/tutorials/ssh.md
:warning:Warning
View
Details

TerminalDocs/troubleshooting.md
:warning:Warning
View
Details

TerminalDocs/search.md
:warning:Warning
View
Details

TerminalDocs/tutorials/powerline-setup.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/retro-command-prompt.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/raspberry-ubuntu.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/color-schemes.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tips-and-tricks.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.
Line 31, Column 233: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.
Line 35, Column 263: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.

TerminalDocs/get-started.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/customize-settings/global-settings.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/dynamic-profiles.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/custom-terminal-gallery/frosted-glass-theme.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/command-palette.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/index.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/command-line-arguments.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/custom-terminal-gallery/powerline-in-powershell.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/cascadia-code.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/panes.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/customize-settings/key-bindings.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/new-terminal-arguments.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tutorials/tab-title.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/customize-settings/profile-settings.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tutorials/ssh.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/troubleshooting.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/search.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tutorials/powerline-setup.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.
Line 48, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/scripting/gallery/getting-started?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 58, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/psreadline/?view=powershell-6 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 62, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/microsoft.powershell.core/about/about_profiles?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.

TerminalDocs/custom-terminal-gallery/retro-command-prompt.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/custom-terminal-gallery/raspberry-ubuntu.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 9b8f535:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/customize-settings/color-schemes.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/frosted-glass-theme.md
:warning:Warning
View
Details

TerminalDocs/dynamic-profiles.md
:warning:Warning
View
Details

TerminalDocs/search.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/retro-command-prompt.md
:warning:Warning
View
Details

TerminalDocs/get-started.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/global-settings.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/powerline-in-powershell.md
:warning:Warning
View
Details

TerminalDocs/custom-terminal-gallery/raspberry-ubuntu.md
:warning:Warning
View
Details

TerminalDocs/troubleshooting.md
:warning:Warning
View
Details

TerminalDocs/tips-and-tricks.md
:warning:Warning
View
Details

TerminalDocs/command-palette.md
:warning:Warning
View
Details

TerminalDocs/tutorials/tab-title.md
:warning:Warning
View
Details

TerminalDocs/tutorials/ssh.md
:warning:Warning
View
Details

TerminalDocs/index.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/profile-settings.md
:warning:Warning
View
Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/tutorials/powerline-setup.md
:warning:Warning
View
Details

TerminalDocs/command-line-arguments.md
:warning:Warning
View
Details

TerminalDocs/panes.md
:warning:Warning
View
Details

TerminalDocs/cascadia-code.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/key-bindings.md
:warning:Warning
View
Details

TerminalDocs/customize-settings/color-schemes.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/custom-terminal-gallery/frosted-glass-theme.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/dynamic-profiles.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/search.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/custom-terminal-gallery/retro-command-prompt.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/get-started.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/customize-settings/global-settings.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/custom-terminal-gallery/powerline-in-powershell.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/custom-terminal-gallery/raspberry-ubuntu.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/troubleshooting.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tips-and-tricks.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.
Line 31, Column 233: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.
Line 35, Column 263: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.

TerminalDocs/command-palette.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tutorials/tab-title.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tutorials/ssh.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/index.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/customize-settings/profile-settings.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/new-terminal-arguments.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/tutorials/powerline-setup.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.
Line 48, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/scripting/gallery/getting-started?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 58, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/psreadline/?view=powershell-6 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 62, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/microsoft.powershell.core/about/about_profiles?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.

TerminalDocs/command-line-arguments.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/panes.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/cascadia-code.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

TerminalDocs/customize-settings/key-bindings.md

Line 8, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'terminal'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

I just realized this is a total dupe of #103


Checkbox.Control not displaying properly in Solidjs (and React)

Description
when I tested the basic check box example I expected to see a checkbox input with the label of "Checkbox", however I only see the label. When I inspect the elements the checkbox input exists, however it has a height and width of 1 px. It also has an absolute position which overlaps with the label when I try to adjust the height and width. I am using this incorrectly somehow?
seems to have the same issue in react. the reproduction link is using react.
here is the example I was testing:
import { Checkbox } from '@ark-ui/solid'

const Basic = () => (
  <Checkbox.Root>
    <Checkbox.Control />
    <Checkbox.Label>Checkbox</Checkbox.Label>
  </Checkbox.Root>
)

Link to Reproduction (or Detailed Explanation)
https://codesandbox.io/p/devbox/young-paper-rh85g9?layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clu0kvl4000073b6fi2dbh76t%2522%252C%2522sizes%2522%253A%255B70%252C30%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clu0kvl3z00023b6f7z1vqt6b%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clu0kvl4000043b6fmw0es5i4%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clu0kvl4000063b6fz3h03akb%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B50%252C50%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clu0kvl3z00023b6f7z1vqt6b%2522%253A%257B%2522id%2522%253A%2522clu0kvl3z00023b6f7z1vqt6b%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clu0kxqvf005n3b6f9dciu7hd%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A8%252C%2522startColumn%2522%253A7%252C%2522endLineNumber%2522%253A17%252C%2522endColumn%2522%253A19%257D%255D%252C%2522filepath%2522%253A%2522%252Fsrc%252FApp.tsx%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%252C%2522activeTabId%2522%253A%2522clu0kxqvf005n3b6f9dciu7hd%2522%257D%252C%2522clu0kvl4000063b6fz3h03akb%2522%253A%257B%2522id%2522%253A%2522clu0kvl4000063b6fz3h03akb%2522%252C%2522activeTabId%2522%253A%2522clu0l80s400cv3b6hey7adlo8%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clu0kvl4000053b6fx8d8qy4y%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TASK_PORT%2522%252C%2522taskId%2522%253A%2522dev%2522%252C%2522port%2522%253A5173%252C%2522path%2522%253A%2522%2522%257D%252C%257B%2522type%2522%253A%2522UNASSIGNED_PORT%2522%252C%2522port%2522%253A5173%252C%2522id%2522%253A%2522clu0l80s400cv3b6hey7adlo8%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522path%2522%253A%2522%252F%2522%257D%255D%257D%252C%2522clu0kvl4000043b6fmw0es5i4%2522%253A%257B%2522id%2522%253A%2522clu0kvl4000043b6fmw0es5i4%2522%252C%2522activeTabId%2522%253A%2522clu0l69uv00a63b6hfa66hh9y%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clu0l69uv00a63b6hfa66hh9y%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TERMINAL%2522%252C%2522shellId%2522%253A%2522clu0l6ai0004bdbhr8t6z7oak%2522%257D%255D%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Atrue%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D
Steps to Reproduce

open link
"Welcome to Ark" page shows "Checkbox" label with no input

Ark UI Version
2.2.3
Framework

[X] React
[X] Solid
[ ] Vue

Browser
Chrome
Additional Information
No response

@monlovesmango
Thanks for taking your time to report this issue. Ark UI is a headless component library meaning we have no opinion how you style a checkbox. You could use the classic check icon with a square or sth completely different. That is the reason you have to style the Checkbox.Control
In our CodeSandBox simply add a app.css import it and add the following styles:
[data-scope="checkbox"][data-part="control"] {
  border: 2px solid;
  border-radius: 9999px;
  display: flex;
  align-items: center;
  justify-content: center;
  width: 16px;
  height: 16px;
}

[data-scope="checkbox"][data-part="control"][data-state="checked"] {
  background: black;
  color: white;
}

[data-scope="checkbox"][data-part="control"][data-state="indeterminate"] {
  background: blue;
  color: white;
}

You can also bring in Icons etc. Feel free t o check a more visual example here: https://park-ui.com/docs/panda/components/checkbox

wow that makes so much more sense! thank you!!


Add note about location of tilde key in /run help

I've seen a lot of people confused about the character used for code blocks in Discord, so adding a note to /run should make it easier to use.

The Problem with that is, that for a good number of people, the key is not there.

What kind of keyboard do you have? If the tilde key isn't present at all, like on ios, then it might be a good idea to remove the need for a codeblock.

Doesn't matter what keyboard I have, I have a tilde key - it's nowhere near the back tick key that is required here. Replacing a missing information that confuses some people with an information that is just plain wrong and extra confusing for a potentially sizeable portion of people is just not a good option.
And removing the codeblock requirement is a terrible idea.

Why is the codeblock necessary?

To make it readable for others mainly.

Maybe just telling people that the backtick is not the same as the single quote could be helpful.

It's quite simple in my mind. We have an explanation with an example that works. People who use discord can be asked to learn /look up how to use the codeblock feature (which is really just markdown). If someone struggles with this so much that he can't use the bot, maybe it's not the right field of work /study for them.

i mean, it's not the rest of the world's fault that europeans have weird keyboards


Translate

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, there. We find you are trying to translate this doc from English into Arabic. Are you a first-time user of StarRocks or you want to introduce StarRocks to your company? Is there anything we can help?


How to use Redshift as a data source on Appsmith

Please cover the following topics in this guide -

Integrating the data source into Appsmith.
Fetching data from the connected data source.
Binding the data to a widget.
For documentation guidelines, click here.

Can you assign this to me?
@Pranay105

@Pranay105 Hey, can you assign me this issue?


WIP: Close attach readers

What type of PR is this?
/kind bug
What this PR does / why we need it:
We now close outstanding Read() operations on CopyDetachable for each attach session. The conmon client collects all attach sessions and also closes them on Shutdown.
Which issue(s) this PR fixes:

Fixes #534
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Cleanup attach sessions to not leak any goroutine.

Codecov Report

Merging #694 (b4971e3) into main (98d420b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   33.15%   33.15%
=======================================
  Files          13       13
  Lines        1104     1104
  Branches      404      404
=======================================
  Hits          366      366
  Misses        464      464
  Partials      274      274

/lgtm


[$500] Chat - Hover menu is not dismissed after opening emoji picker

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to any chat
Hover over any message
Click Add reaction icon
Hover away from the message

Expected Result:
Hover menu is dismissed after opening emoji picker
Actual Result:
Hover menu is not dismissed after opening emoji picker
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/b74ca732-3467-43c8-a4df-0ed846f1ad10
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c51a081dafada031
Upwork Job ID:<PHONE_NUMBER>343419392
Last Price Increase: 2024-02-16

BTW, This is not a regression from the overflow menu PR as the hover menu was not dismissed even before the PR
https://github.com/Expensify/App/assets/77237602/d7bce24a-0f57-4965-96c5-eb79fe44b096

Proposal
Please re-state the problem that we are trying to solve in this issue.
Hover menu is not missed after opening emoji picker
What is the root cause of that problem?
in the onPressOpenPicker we dont close the context menu
https://github.com/Expensify/App/blob/c884245e7204abad57e01752ec54e4011c1e43e9/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L139
What changes do you think we should make in order to solve the problem?
define a new function openPickerAndCloseMenu

            const openPickerAndCloseMenu = () => {
                openContextMenu();
                closeContextMenu();
            };

then inside then change onPressOpenPicker to
                        onPressOpenPicker={openPickerAndCloseMenu}

Proposal
Please re-state the problem that we are trying to solve in this issue.
The message context menu does not close when leaving the focus area of the message, after you have selected the Add emoji reaction button. This is inconsistent with other buttons such as the Menu button from the context menu, hence an inconsistent experience.
What is the root cause of that problem?
The root cause is that each context button is responsible for it's own calling of the closePopover callback. And is left out in the emoji reaction button. Causing an inconsistent behavior within the app.
What changes do you think we should make in order to solve the problem?
In order to solve this problem I looked at both Slack and Discord to see how they handle this. They both will keep the hover context menu open, if you are in an unfinished interaction such as having selected the emoji button but not having chosen one yet. Even after leaving focus of the message that triggered the context menu.
This means that the current behavior for the Emoji reaction button is a standard one, and we should actually change the behavior of how the Menu button behaves ( last one in the hover context menu ), for consistency within the app, and across other popular messaging apps for the best customer experience.
What alternative solutions did you explore? (Optional)
I explored hiding the context menu, by calling closePopover. Simple, but will deviate us from industry standards.

Thanks guys!

This means that the current behavior for the Emoji reaction button is a standard one, and we should actually change the behavior of how the Menu button behaves ( last one in the hover context menu ), for consistency within the app, and across other popular messaging apps for the best customer experience.

I agree with @JeremyCroff that we have an inconsistency on the context menu popup open from the hover context menu.
https://github.com/Expensify/App/assets/25520267/95d3b999-c283-4fa2-8e7a-2a9287ddadf4
@JmillsExpensify I'm not sure if it's a bug.

Thanks guys!

This means that the current behavior for the Emoji reaction button is a standard one, and we should actually change the behavior of how the Menu button behaves ( last one in the hover context menu ), for consistency within the app, and across other popular messaging apps for the best customer experience.

I agree with @JeremyCroff that we have an inconsistency on the context menu popup open from the hover context menu.
Screen.Recording.2024-01-22.at.22.06.27.mp4
@JmillsExpensify I'm not sure if it's a bug.

My proposal is temporarily hidden - while I am recovering my github account it's in a suspended state.
My summary of the proposal was that after reviewing Discord and Slack, we should keep the toolbar open like it currently is. And introduce a clicked state for the icon. Further more, we should make the three dots for the Menu button behave the same, as currently it dismissed the toolbar when clicking on it.
I can write up another formal proposal if necessary, but maybe some one has the logs for it.

Yeah, I agree that both of you have inconsistency, and the behavior should be similar to what Slack does.
But I don't know if we want to fix it here or create a new issue since the OP is expected.
@JmillsExpensify Can we fix the inconsistency and update this issue's title and description?

Friendly bump @JmillsExpensify

My summary of the proposal was that after reviewing Discord and Slack, we should keep the toolbar open like it currently is. And introduce a clicked state for the icon.

I agree with this though I'd also like to confirm with @Expensify/design on the clicked state for the icon. Thoughts?

I personally don't think we need a clicked/active state for the icon, but I 100% agree that the menu should stay open (and just for clarity, I'm saying the way the "add reaction" option behaves right now is the correct behavior imo).

Got it, I'm down with that approach, so sounds like we can close this?

Got it, I'm down with that approach, so sounds like we can close this?

Is the plan to close this and open a different ticket for the three-dot menu (which currently does not follow this behavior)?

Ah, I missed that part. I think we could just update this ticket with the correct report then.

Good point—I personally don't think it's a HUGE deal, but yes, it would be ideal if it stayed "focused/hovered" like when you have the context menu open.

Good point—I personally don't think it's a HUGE deal, but yes, it would be ideal if it stayed "focused/hovered" like when you have the context menu open.

Let me know if we end up going ahead with this as I worked on the original implementation of the overflow menu

I'll re-reviewing the proposal in the morning!

To clarify we will fix a few issues here.

Add a hovered/focused background on the report action while the emoji picker opens from the context menu or mini context menu
Retain the mini context menu while opening the menu

@JmillsExpensify @dannymcclain Is this correct?

Thanks @dannymcclain for the confirmation!
@JmillsExpensify I think we need to update the issue title and description to match up with the new expectation.

@JmillsExpensify Could you update the issue title and description for the summary? Thank you!

Friendly bump @JmillsExpensify

I'll make this move forward! Meanwhile we still need to update the title and issue description.
The proposal from @tienifr has what the issue we will solve and I think it's on the correct path.
🎀 👀 🎀 C+ reviewed!

I think Melvin doesn't notice the assignment because we missing the External label 👀
@tienifr Let me know when the PR ready? Thank you!

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR was found. The issue expanded to be improved and aligned on highlighting the report action and keeping the context menu open.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression test should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

We have a good place here on the test rail to add more step.

Hover over any message (right-click on the action or add any reaction)
Click the Add reaction icon to open the emoji picker
Hover away from the message
Verify that the background is retained
Verify that the mini context menu is open if users open the emoji picker from the mini context menu
Select any emoji or click outside to close the emoji picker
Verify that the background has disappeared and the mini context menu is close
Click three dot/ menu icons to open the popover
Hover away from the message
Verify that the background is retained and the mini context menu is open
Click outside to close the popover
Verify that the background has disappeared and the mini context menu is close

@JmillsExpensify Could you create the payment summary? Thank you!

Looks like we don't have an automatic Upwork issue. Created one just now and sent an offer to @tienifr. @trjExpensify Another one, can you please confirm the summary above?

Payment released via Upwork.

Payment summary here looks good!

$500 approved for @mollfpr based on summary.

Regression test request created. Closing.


styletts2 inference pip package

Hi, big fan of the project here. I required a pip installable package of StyleTTS 2 for inference (and specifically with a fully MIT licensed stack). I went ahead and put one together (also under MIT license). Just thought I would let the authors and community know. Feel free to try it out too, feedback is welcome!

Added to README.


Consider getting rid of keyword objects like types and text.

The table public.types is always generated as public."types".
Buuuut, if you say "select * from types", it works fine.
And the column text is generated DDL as files."text" BUUUUUT it works to say update files set text = '';

type table no longer part of design.


docker_vcs: copy function is duplicating, nesting a directory in  a directory

E.g. You see 2 src folderes and one of them is nested.
/tmp$ tree -L 3 docker_vcs_20220415134036/
docker_vcs_20220415134036/
├── Dockerfile_ros-melodic
├── entry_point.bash
└── src
    ├── 130s
    │   ├── docker_vcstool
    ├── src
    │   ├── 130s
:

Turned out the source dir contained the duplicate folder. So this is no-issue.


Feature/callen/238  fix duplicate oppts when creating r dwith campaign

This fixes an issue where if a Recurring Donation is created in BDI with a campaign defined, but no initial Donation defined it still creates an initial donation.  This was occurring because the code that checks to see if any Opportunity Object mapping fields were populated was including the DonationCampaignImported__c field (Which is used by both RD and Oppts) in the populated field check that determines whether or not the Opportunity attempts to be created.
We are creating a field mapping because Donation Campaign Source was missed when we originally converted the help text mappings to the custom metadata "advanced" mappings.  It has been getting created automatically during advanced mapping enablement so it hasn't directly caused problems, but the fact that it is missing meant that the unit tests for Recurring Donation didn't catch this bug earlier. Adding it means that the default mapping is more accurate and we can now catch regressions for this bug.  It does not need to be added to any install scripts because an equivalent mapping has already been created for all orgs during enablement.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

Changed branch name and opened new PR: https://github.com/SalesforceFoundation/NPSP/pull/6768


Fix NoAlias Attributes for older LLVM versions

Properly add noAlias for older LLVMs (tested on 3.8).
Requesting someone do a sanity check on 4.0 and 5.0+

@pgoodman, The changes look good to me. Approving this PR.


UI for setting sendmail-path

There appears to be no sendmail-path setting in Setup | Config.

Very belated, but you it seems must select to "Expose Hidden Config" in the config before the sendmail-path setting becomes visible.


Company Page - when we update relationship manager it is not reflect immediately

Describe the bug

when we add/remove relationship manager  we can not see any change we have to refresh the page to see change

@dharmendraecb api response required? agar kuch chahiye to batana

https://www.berrycast.com/conversations/6b620b8c-f5c2-5589-ba96-9b40cd79dba6


Perf parse params decode text

Based on the work of mscdex regarding the decodeText. Pretty smart how he did it.

Checklist

[ ] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

@Uzlopak Can you resolve the conflicts?

@Uzlopak what are the benchmarks agains the master?

@kibertoad
PTAL

@Uzlopak can you run benchmark to see the perf difference?

@kibertoad
I dont know... tbh photofinish is a little bit complicated. I maybe rewrite the new benchmark in tinybench. Or can you rewrite that benchmark from benchmark to photofinish?

@Uzlopak We can rewrite to tinybench, photofinish main strength is that it allows running easily across Node versions, which is an overkill here.

@kibertoad
can we just merge? I have no motivation to rewrite the benchmarks. Maybe create an issue to rewrite the benchmarks and slab a 'good-first-issue' label to it.


Performance of some dart2js array store operations.

See https://stackoverflow.com/questions/58211830/performance-of-dart-code-in-browser-vs-vm/
There seems to be a case here where dart2js generates a very large overhead due to slow array-store operations. Since the majority of the code is array updates, that causes an orders of magnitude slowdown over optimal code.

Parametric covariant type checks are expensive. We are currently working on making them less expensive. You could try the dart2js flag --experiment-new-rti to see how much of an improvement it provides. It is a work in progress.
To get really good code here we need to eliminate the parametric covariant type check. This is an interprocedural analysis. List<T>.generate returns an list implementation type (JSArray) with the same T, in this case T is double, so x[j]= has a check against double, which can be removed since the assigned value is double (via double+int --> double). This makes it worth inlining/reducing JSArray.$indexSet to get the JavaScript [] operation. Much of this analysis could be performed on kernel IR and shared between dart2js and AOT @alexmarkov @mraleph)
When I compile the example with -O3 or -O4 (which omits the parametric covariant type check), I get results very close to the ES6 results, both about 30ms.

The tax for doing a parametric covariant type check on array store is now much less for numeric types.

Dart version, DartVM: 99ms
Dart version, dart2js compiled in 'spec' mode, old type system: 4055ms
Dart version, dart2js compiled in 'spec' mode, new type system: 154ms
Dart version, dart2js compiled -O4: 29ms
JavaScript version: 44ms

JavaScript times are running on a stand-alone V8. In my experience, the browser is a little slower (maybe takes and additional 50%).
I'm closing the issue since the 'orders of magnitude' problem has been fixed.


Fix broken translation feature

It is necessary to provide a translation provider, the way is being done it doesn't work.
Let's follow: https://wtforms.readthedocs.io/en/2.3.x/i18n/

Working fine on 2.3.3. Something is broken on 3.x for translations.


support juicefs cloud service

Signed-off-by: zwwhdls<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
support juicefs cloud service in JuiceFSRuntime
fix https://github.com/fluid-cloudnative/fluid/issues/1682
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@zwwhdls Please fix conflict issue. Thanks.


Install generator needs better tests

We just ran into an issue where the fix for #88 caused the install generator to break for new applications. It was requiring the user_class configuration option to set and was giving a non-trivial error message to users.
I think that we should have a test for the install generator which is more of an "integration" test than the current "unit" test that lives in spec/generators. This integration test should use the wonderful Aruba to create a brand new Rails application and walk through the install steps for Forem, running checks on the output of the content of the installer.
Without this, there's a chance that any change to Forem could again break the install generator, and when that happens anybody who's trying out Forem for the first time will see this and think bad things about Forem. The install generator (and the installation process) should amaze people at what it did for them and how easy it was.
Let's not break this again, ever.
Massive thanks to Aston J for pointing this out.

There's now also #102 which is caused by problems with the way that this is being tested. Perhaps fakefs should be looked into as a possible alternative to this.

This is fixed by #149.


Major refactoring: moving each check into its own function

The benefits of this are:

better organization
reducing indentation level helps to make it easier to read & understand
also reduces namespace polution
functions get as parameters just the bits of really needed info, thus making the code clearer
also helps to facilitate fitting it all within 80 columns
individual functions per-check seem to be one pre-requisite (of many) for issue #681 It is also the main task at issue #891
a very good side effect of this refactoring is the ability to grasp the full list of checks that are performed by simply looking at the sequence of function invocations for each of them
once checks are separated out in their own functions, we can invoke them more than once, which is a pre-requisite for issue #971

Marc and lasse, what do you think? Should Felipe continue this?

I'd like to mention here that I am putting this effort because I think this will make my work easier. The lack of structure in this giant script has been a pain for a while already. I think the refactoring suggested here (45% of which was already implemented today and probably the rest to be done on my next work day) will have a positive impact not only on the overall code readability, but also in its reliability.

I agree with Felipe here.
I used a similar approach for my glyphsapp QA scripts. Many tests rely on other tests to work properly. By having every test as a function, we'll cut down on the duplication.
Cheers,
Marc

Cool! I'll move on and finish this today. Thanks, @m4rc1e

Thanks both

DONE! :-D


Add a Github issue template

This is a much better way to do this vs. the copy / paste issue template
in the contributing doc
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

:100:

+1

@chef/client-dev-tools this is ready for review

👍