[py-icon4py, icon] Modifications for merge of advection

Adapt the icon4py spack recipe to test the advection component. These changes are valid for icon4py releases higher than v0.0.8. The arguments  '-m',  'not slow_tests' are added to the pytest  command  to ignore the four slow advection stencils for the testing.

launch jenkins py-icon4py icon

tsa
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec :green_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:Icon-install_2_6_6_nvhpc :green_circle:Icon-install_nwp_gpu :green_circle:PyIcon4py-install_version_0_0_5 :green_circle:PyIcon4py-install_version_0_0_6 :green_circle:PyIcon4py-install_version_0_0_7

launch jenkins py-gt4py py-icon4py icon

tsa
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-gt4py-spack_info :green_circle:py-gt4py-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec :green_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:PyIcon4py-install_version_0_0_5 :green_circle:PyIcon4py-install_version_0_0_6 :green_circle:PyIcon4py-install_version_0_0_7 :green_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc :green_circle:daint_dsl_nvhpc

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-gt4py-spack_info :green_circle:py-gt4py-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec :red_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:Icon-install_2_6_6_nvhpc :green_circle:Icon-install_nwp_gpu :green_circle:PyGt4py-install_version_1_1_1 :green_circle:PyGt4py-install_version_1_1_2 :green_circle:PyGt4py-install_version_1_1_3 :green_circle:PyIcon4py-install_version_0_0_5 :green_circle:PyIcon4py-install_version_0_0_6 :red_circle:PyIcon4py-install_version_0_0_7 :green_circle:PyIcon4py-install_version_0_0_8
WARNING: Serial tests did not run for system tests

launch jenkins py-gt4py py-icon4py icon

balfrin
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-gt4py-spack_info :green_circle:py-gt4py-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec :green_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:Icon-install_2_6_6_nvhpc :green_circle:Icon-install_nwp_gpu :green_circle:PyGt4py-install_version_1_1_1 :green_circle:PyGt4py-install_version_1_1_2 :green_circle:PyGt4py-install_version_1_1_4 :green_circle:PyIcon4py-install_version_0_0_5 :green_circle:PyIcon4py-install_version_0_0_6 :green_circle:PyIcon4py-install_version_0_0_7 :green_circle:PyIcon4py-install_version_0_0_8

launch jenkins py-gt4py py-icon4py icon daint

balfrin
:green_circle: unit testTest:green_circle:summary

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-gt4py-spack_info :green_circle:py-gt4py-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec :green_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:PyGt4py-install_version_1_1_1 :green_circle:PyGt4py-install_version_1_1_2 :green_circle:PyGt4py-install_version_1_1_4 :green_circle:PyIcon4py-install_version_0_0_5 :green_circle:PyIcon4py-install_version_0_0_6 :green_circle:PyIcon4py-install_version_0_0_7 :green_circle:PyIcon4py-install_version_0_0_8 :green_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc :green_circle:daint_dsl_nvhpc

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:dace_icon.-O1-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:py-gt4py-spack_info :green_circle:py-gt4py-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec :red_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:PyGt4py-install_version_1_1_1 :green_circle:PyGt4py-install_version_1_1_2 :green_circle:PyGt4py-install_version_1_1_4 :green_circle:PyIcon4py-install_version_0_0_5 :green_circle:PyIcon4py-install_version_0_0_6 :green_circle:PyIcon4py-install_version_0_0_7 :green_circle:PyIcon4py-install_version_0_0_8 :red_circle:daint_cpu_cce :red_circle:daint_cpu_gcc :red_circle:daint_cpu_nvhpc :red_circle:daint_cpu_nvhpc_out_of_source :red_circle:daint_gpu_nvhpc :red_circle:daint_dsl_nvhpc
WARNING: Serial tests did not run for system tests


Azure Arc Implementation Requirements

Some Ministry users/teams have expressed interest in testing Azure Arc.
In order to support this use case, we need to research the requirements for this Azure service, especially networking and connectivity.
Potentially, we could create (and deploy) a "sample app" pattern for Azure Arc, onboard a few on-premises/hybrid agents (potentially also from other cloud providers like AWS), as part of validation for networking, DNS, security, connectivity to on-premises, etc.
Acceptance Criteria

Generated by Zenhub AI

[ ] Scenario: Researching Azure Arc requirements

Given the need to support testing Azure Arc

When researching the requirements for this Azure service

Then identify networking and connectivity requirements

[ ] Scenario: Creating a sample app pattern for Azure Arc

Given the need to create a "sample app" pattern
When creating an example application for testing purposes
Then deploy the sample app on Azure Arc

[ ] Scenario: Onboarding hybrid agents from different cloud providers

Given the need to test connectivity with other cloud providers
When onboarding a few on-premises/hybrid agents (e.g., AWS)
Then validate networking, DNS, security, and connectivity to on-premises environments

The primary needs to support Azure Arc are:

An Azure subscription
A Log Analytic Workspace

The following documentation and guidance had been provided to the Ministry team(s) that are interested in using Azure Arc:

Plan and deploy Azure Arc-enabled servers
Azure Arc, Azure Monitoring and Azure Workbooks
Azure Policy built-in definitions for Azure Arc-enabled servers


[MAID-2835] chore/ci: update scripts to Rust stable 1.26.2

Could you rebase off the latest changes? :)


ENH: Better verbosity for MF and anatomy

This makes the messaging better for maxwell_filter, as well as for run_subprocess calls (now just freesurfer).

If verbose='info' stdout and stderr of the process are printed
if verbose='warning', just stderr is printed
if verbose='error' nothing is printed

This is most consistent with our own internal behavior. Doing verbose=None makes nothing get printed, verbose='info' gives the logger.info messages plus FreeSurfer output. This is much nicer when doing reconstructions. If there is an error, the stdout and stderr get printed before an error is raised.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2a98e81). Click here to learn what that means.
The diff coverage is 38.88%.

@@            Coverage Diff            @@
##             master    #4656   +/-   ##
=========================================
  Coverage          ?   87.66%
=========================================
  Files             ?      351
  Lines             ?    66613
  Branches          ?    11550
=========================================
  Hits              ?    58397
  Misses            ?     5260
  Partials          ?     2956


Model works better, when I use only subset of all points

Hi, thanks for great job! I have several questions about number of points which I should use to get the best results.

I have a cloud of points of room and trying to find walls, floor and ceiling with pretrained on s3dis dataset model. Room in my example has ~900k points and I have ran model with different subset of points. On first image you can see a visualization of full subset of points and on the second image only 500k subset of points. Of course, if i use too smaller subset (for example only 100k) of my data, than results will worse than in case of 500k. So, i want to ask why my results changing so strange when use a different subset of data: results(100k) < results(500k) and results(500k) > results(900k)? And which number of points should I use for predict to get the best results?

Also I saw the parameter max_point in config, but it seems to change nothing. What does it do and how should i change it in dependence on size of my cloud?

At testing time, we should use the whole scene without subsample. We cannot compare results of 500k point with results of 900k point since it is unfair comparison.
max_point has effects at training for random cropping only. At test time, all points will be used.


Ui of rate us page improved.✨

improved the Ui and added a storage feature which will store user data.
@apu52 can you review this please.
#1253 sovled.

i have one more PR to make , can you please review this .thank you!
@apu52

i have one more PR to make , can you please review this .thank you!
@apu52

@apu52 i have another PR to make , can you please review this .
thank you

@apu52 i have another PR to make , can you please review this .
thank you

@apu52 i have another PR to make , can you please review this .
thank you

apu52 i have another PR to make , can you please review this .
thank you

apu52 i have another PR to make , can you please review this .
thank you

apu52 i have another PR to make , can you please review this .
thank you


Bug: Validation permit_empty does no work together with required_with and required_without

Describe the bug
I'm working on admin form for MythAuth where user password can be changed. The form also updated other user data. So requirement for changing password is to enter current password in cases where password is not being changed it should be possible to submit the form with empty current password so I have validation rules it the following format
'currentPassword'=>'permit_empty|required_with[newPassword]|valid_password[{id}]'

This makes validation pass when currentPassword is empty and newPassword is set which should not be possible
CodeIgniter 4 version
git - 85cd56a79d02ca720af32ede381f3166482fc256
Affected module(s)
Validation Library
Expected behaviour, and steps to reproduce if appropriate
If newPassword is not empty validation should not pass with empty currentPassword field.
Context

OS: MacOS 10.15.4
Web server Apache 2
PHP version 7.4.2

Dude your modification works with other rules like
permit_empty|uploaded[image]|is_image[image]
I have tested with 4.0.3
and it is like skipping the entire rule set.


Add spoved releases

Added:
https://github.com/spoved/vcr.cr
https://github.com/spoved/kube-client.cr
https://github.com/spoved/crafana.cr

Looking good to me. Please confirm there are periodical CI builds.

Set up for weekly builds


Katas preview images can use the wrong theme

The svg images in the katas use colors based on the OS theme preference. However, the playground and kata preview page always use a white background. These means if your OS theme is set to dark, those preview pages have hard to read images.
Either the katas preview pages should use the OS theme (and thus support light and dark mode rendering), or the images should be forced to light mode colors on the preview pages. (Probably should do the former, so that we can preview in both modes for correctness).

This has been fixed.


Varlib iup

I ended up redoing this on my own.  It's similar in functionality to Jens's work in https://github.com/fonttools/fonttools/pull/943
I haven't implemented the mutator part and will borrow from his code, but probably won't add those methods in GlyphCoordinates themselves but keep in varLib, and later move all IUP-related code into varLib.iup modules.
Tests should be ported from his branch as well.
I plan to implement full IUP optimization soon.  Maybe I work on that instead of the mutator part first.
WIP.

cc @jenskutilek

I've implemented IUP in mutator as well.  I think this can be merged and makes Jens's PR obsolete.  I'll work on optimal packing of contours in a few days or weeks.  Have to tend to some bugs now.


Add devstack plugin

This PR adds a devstack plugin. This makes it possible to deploy sg-core in a container while deploying devstack.
Example of working local.conf used while testing this (remove the "jwysogla-devstack") once this is merged. This local.conf will result in a running container with sg-core and ceilometer configured to send metrics to that container:
[[local|localrc]]
ADMIN_PASSWORD=secret
DATABASE_PASSWORD=$ADMIN_PASSWORD
RABBIT_PASSWORD=$ADMIN_PASSWORD
SERVICE_PASSWORD=$ADMIN_PASSWORD

CEILOMETER_BACKEND=sg-core

USE_PYTHON3="True"

VERBOSE="True"

VERBOSE_NO_TIMESTAMP="True"

LIBS_FROM_GIT=aodh,ceilometer,cinder,devstack,devstack-gate,dib-utils,diskimage-builder,glance,heat,keystone,neutron,nova,placement,requirements,swift,sg-core

enable_plugin aodh https://opendev.org/openstack/aodh
enable_plugin ceilometer https://opendev.org/openstack/ceilometer refs/changes/87/898087/1
enable_plugin heat https://opendev.org/openstack/heat
enable_plugin sg-core https://github.com/infrawatch/sg-core jwysogla-devstack

There is another change, that's worth to mention: https://review.opendev.org/c/openstack/ceilometer/+/898087 That will add support for a sg-core backend to ceilometer as can be seen in the example local.conf

Looks like the work is already starting to pay off. I think I can see the same error, which is caught by our CI during my testing in devstack. With the recent rewrite of the TCP publisher in ceilometer, it looks like it fails to properly connect if ceilometer is started before sg-core. Restart of the notification-agent seems to fix the issue. I'll investigate the issue further and propose a fix on the ceilometer side.

Also another thing. I tested a full devstack deployment using the local.conf mentioned above to test with centos stream 9 and with debian bookworm.

@vyzigold this looks great! In future it would be nice to curl sg-core for some metrics after we've created some resources on the cloud (images, volumes).

@yadneshk This is my next step. I have an addition to the telemetry-tempest-plugin almost ready, which makes use of all of this and it queries sg-core.

Since I mentioned it here. Here is a fix for the ceilometer issue. We should be able to merge it once the ceilometer CI is fixed sometime next week probably. After that the sg-core CI here should start succeeding.
https://review.opendev.org/c/openstack/ceilometer/+/898215

Gr8 work, thanks a lot Jaromir.

It's been awhile since I've used devstack. I'm hoping to try this out today; I'll let you know how it goes.

I followed the instructions and got myself a working devstack with a running sg-core container and a set of ceilometer processes:
[stack@stream9 devstack]$ podman ps
CONTAINER ID  IMAGE                              COMMAND     CREATED         STATUS         PORTS       NAMES
3a231c4a1b7a  quay.io/infrawatch/sg-core:latest              30 minutes ago  Up 30 minutes              sg-core

[stack@stream9 devstack]$ ps ax | grep ceil
 248393 ?        Ssl    0:01 ceilometer-polling: master process [/usr/local/bin/ceilometer-polling --polling-namespaces central --config-file /etc/ceilometer/ceilometer.conf]
 248872 ?        Sl     0:01 ceilometer-polling: AgentManager worker(0)
 249237 ?        Ssl    0:01 ceilometer-agent-notification: master process [/usr/local/bin/ceilometer-agent-notification --config-file /etc/ceilometer/ceilometer.conf]
 249581 ?        Sl     0:12 ceilometer-agent-notification: NotificationService worker(0)
 249583 ?        Sl     0:09 ceilometer-agent-notification: NotificationService worker(1)
 249979 ?        Ssl    0:01 ceilometer-polling: master process [/usr/local/bin/ceilometer-polling --polling-namespaces compute --config-file /etc/ceilometer/ceilometer.conf]
 250269 ?        Sl     0:00 ceilometer-polling: AgentManager worker(0)

I tried running tempest to get some ceilometer activity, but my VM ran out of storage and OSP is borked. Whoops.
Anyways, I can hit the sg_core instance.
[stack@stream9 devstack]$ curl localhost:3000/metrics
# HELP sg_total_ceilometer_metric_decode_count
# TYPE sg_total_ceilometer_metric_decode_count counter
sg_total_ceilometer_metric_decode_count{source="SG"} 0
# HELP sg_total_ceilometer_metric_decode_error_count
# TYPE sg_total_ceilometer_metric_decode_error_count counter
sg_total_ceilometer_metric_decode_error_count{source="SG"} 0
# HELP sg_total_ceilometer_msg_received_count
# TYPE sg_total_ceilometer_msg_received_count counter
sg_total_ceilometer_msg_received_count{source="SG"} 0

I'll try to revive my devstack to see if I can get actual metrics flowing, but for now I'm gonna say this is good since it's headed in the right direction and doesn't break anything.

If you deploy devstack and have some image there (I noticed, there is usually a cirros and fedora image right after I deploy), then ceilometer will start sending metrics about the image size without the need to run anything else. (So just stack.sh and wait enough time). The issue is, that ceilometer needs a restart after stack.sh is finished to work, which is wrong and there is a fix already proposed upstream, which is waiting for CI to work. This is also the reason why the CI doesn't work here.

I'll wait until the end of the day. If I don't see a change in pyparsing, which is the first step for our CI to start succeeding and if nobody minds me doing this, I'll just merge this. I think we all agreed, that this is an isolated change and it won't break anything.


v0.23.0 Release Tracking Issue

Status: Active
Current RC CLI: v0.23.0-rc.0
Release Criteria

[x] All builds passing
[x] Change Log prepared
[ ] QA Checklist Complete
[ ] All bugs fixed or triaged
[ ] Deployed and Released
[ ] KB & WWW on latest version of the CLI

Commits
Federico Ruggi (11):
      fetch updates in background and get them in user cli
      fixed download url
      return error if actual call fails
      added godoc lines
      added godoc, moved `apitypes.Updates` to `apitypes.UpdateInfo`
      removed unused tabwriter, added godoc for cmd.checkUpdates
      added documentation for `check_updates` preference
      use UTC timezone
      use semver for versions comparison, ignore race condition on readfile
      better update check logic, added tests
      added godoc, simplified error detection in `updates.getLastCheck`

Ian Livingstone (4):
      Fix machine name check
      Add security note regarding named pipes

James Bowes (38):
      organize worklog keyring items by user, not keyring
      Implement unmarshaling keyring membership revocation reasons
      Update changelog with updates checking support
      Install released versions of glide only
      Re-add keyring membership correction for machines
      Expose the claims causing the need for credential rotation
      Populate rich worklog details
      Make attributes and default icons public in promptui
      Allow prompts to have indent characters
      Different types for keyring membership
      New worklog UI
      Remove the worklog result type; its unused
      Fix the org flag help for invites accept
      Teach the ui package to spawn indented children
      Use ui.Child for indenting prefs output
      use ansiwrap
      Use the ui package for worklog output
      Check in our generated code, so we can go get it
      Fix padding addition for base32 when divisible by 8
      Use the external base64 dep
      Use our new external base32 package

Jeff Andersen (5):
      Use roundtripper instead of http.transport
      Extract validation methods for common types to be reused
      Remove dependency of config from logic engine
      Add database interface for logic engine to allow for use in additional client

Jelmer Snoeck (22):
      Config: encapsulate windows root path behaviour.
      Compile: easily compile to windows executable.
      Daemon: Windows specific daemon spawning.
      API/Daemon: Unix Socket/Windows TCP.
      Dirprefs: windows and unix have different roots.
      Styler: windows specific styler.
      Appveyor: add build file.
      Windows: set homedrive accordingly.
      Config: TransportAddress instead of SocketPath.
      Glide: add npipe.
      Windows: implement npipe.
      Appveyor
      Promptui: use readline.Stdout.
      Styles: fallback to latin characters on Windows.
      Makefile: set up to build binaries for Windows.
      README: add Windows install instructions.
      Readme: proper formatting for Windows installation.
      WindowsSocket: don't use backslash in address.
      WindowsSocket: add default security behaviour.
      Transport: use DialTimeout.
      HTTPClient: set up Timeout.
      Timeouts: bump client timeout to 1 minute.

Patrick LaRoche (1):
      Update release-issue.md

================================================================================================================================================================================================================================================================================
Release 0.23.0-rc.1 is ready for stage

zips: https://prerelease.torus.sh/0.23.0-rc.1/

npm:  npm install -g https://prerelease.torus.sh/npm/0.23.0-rc.1/torus.tar.gz
brew: brew install https://prerelease.torus.sh/brew/0.23.0-rc.1/torus.rb

yum:
sudo tee /etc/yum.repos.d/torus.repo <<-'EOF'
[torus]
name=torus-cli repository
baseurl=https://prerelease.torus.sh/rpm//
enabled=1
gpgcheck=0
EOF
sudo yum install torus # or dnf

deb:
DISTRO=$(lsb_release -i | awk '{print tolower($3)}')
CODENAME=$(lsb_release -c | awk ‘{print $2})’
sudo tee /etc/apt/sources.list.d/torus.list \
    <<< "deb https://prerelease.torus.sh/$DISTRO/ $CODENAME main"
sudo apt-get update
sudo apt-get install torus

================================================================================================================================================================================================================================================================================

Installation and Signup
If you have torus installed, start fresh npm uninstall -g torus-cli

[ ]   npm install -g torus-cli installs torus
[ ]   torus help displays the help prompt after an
npm install -g torus-cli
[ ]   torus prefs list displays the path to your public_key_file
[ ]   torus signup prompts you for an verification code username, name and
email, before verifying and authenticating you
[ ]   A user cannot perform any writes without verifying their account
[ ]   torus status displays your current working context
[ ]   torus logout logs you out
[ ]   torus login prompts you for an email and password, before
authenticating you
[ ]   You can login using environment variables (TORUS_EMAIL and
TORUS_PASSWORD)

Account

[ ]   torus profile view displays your current identity
[ ]   torus profile update allows you to change your name, email and
password.
[ ]   Changing email generates a new verification code
[ ]   A user cannot perform any writes without verifying their account

Teams

[ ]   torus teams list --org [username] displays owner admin and
member teams, and you are a member of each
[ ]   torus teams create [name] --org [org-name] creates an org.
[ ]   torus invites send [email] —org [org-name] generates an access code
and sends it to the user
[ ]   torus invites accept —org [org] [email] [code] prompts a user to
sign-up or login
[ ]   The user cannot manage resources in this org
[ ]   torus invites list —org [org] lists the outstanding invite
[ ]   torus invites approve [email] —org [org] approves the users invite
[ ]   The user is now a member of the members team
[ ]   torus teams add [name] [username] —org [org-name] adds the user to a
team
[ ]   torus teams remove [name] [username] —org [org-name] removes the user
from a team
[ ]   Users cannot remove themselves from system-teams

Context

[ ]   torus status will not display a context outside of a linked directory
[ ]   torus link prompts you to select or create an org, and project
[ ]   torus link -f will over-write a previous torus link
[ ]   torus status now displays a valid: org, project, environment, service,
instance and path
[ ]   Commands can now be executed without the —org and --project flags

Access Controls

[ ]   torus policies list --org [org] displays three system-default
policies attched to the owner , admin , and member teams
[ ]   torus allow crudl [path] [team] generates a policy, displays an
allow effect, appropriate actions, the correct resource. and attaches
it to [team]
[ ]   Members of [team] have appropriate access
[ ]   torus deny crudl [path] [team] generates a policy, with a deny
effect, appropriate actions, the correct resource, and attaches it to
[team]
[ ]   Members of [team] are denied access to the appropriate resource
[ ]   torus policies list —org [org] displays the generated policies
attached to the appripriate [team]
[ ]   torus policies detach [name] [team] —org [org] detaches the policy
from the team
[ ]   Members of [team] have appropriate access
[ ]   System policies cannot be detached
[ ]   torus policies view [name] displays statements contained within the
policy

Worklog/Keyring Versioning

[ ]   Keyring Versioning

[ ]   prerequisite: Create an org, and invite another user.
[ ]   prerequisite: Create a team, add the other user to it, and give it
access to a project (projA)
[ ]   prerequisite: Create a second project (projB) that the other user
does not have access to.
[ ]   prerequisite: Set two secrets in both projects
[ ]   torus orgs remove [username] —org [org-name] removes the user from
the org.
[ ]   torus worklog list shows the secrets from projA as needing to be
changed, but does not show the secrets from projB.
[ ]   torus worklog view <id> shows a worklog entry by id.
[ ]   After each secret from projA is changed, it no longer appears in the
worklog.
[ ]   torus view can display a mixture of old and new secrets (ie after a
single new set in projA).

[ ]   Keypair revocation

[ ]   prerequisite: Create an org, and invite another user.
[ ]   prerequisite: Create a team, add the other user to it, and give it
access to a project (projA)
[ ]   prerequisite: Set a secret in the project
[ ]   Run torus keypairs revoke as the other user, to revoke your keypairs
[ ]   The other user now cannot see any secrets with torus view
[ ]   As the first user, torus worklog list should show a secrets item
to rotate the secret.
[ ]   Run torus set as the first user, to set a new secret. It should
not error (the revoked keypairs should cause no issues).
[ ]   Run torus keypairs generate as the other user.
[ ]   The first user should now see keyring entries in the worklog, to
encode the other user's new keypairs.
[ ]   torus worklog resolve should resolve the keyring entries.
[ ]   The other user should be able to torus view the original secret,
and the new secret.

List

[ ]   torus ls, in an unlinked directory, list all orgs
[ ]   torus ls works in a linked directory, showing all paths for the
context
[ ]   torus ls / lists all orgs
[ ]   torus ls "/*" lists all projects
[ ]   torus ls "/*/*" lists all environments
[ ]   torus ls "/*/*/*" lists all services
[ ]   torus ls "/$org/$proj/*/*" lists all secrets for /$org/$proj/*/*/*

Machines

[ ]   Only admins and owners can create machines
[ ]   torus machines create works with context
[ ]   torus machines create supports flags (e.g. -o, -t etc)
[ ]   torus machines create allows you to select an existing org and team
[ ]   torus machines create allows you to create a new machine team
[ ]   You can login using TORUS_TOKEN_ID and TORUS_TOKEN_SECRET
environment variables
[ ]   A machine can read but not write (e.g. view, run, ls, envs list,       services list, projects list, orgs list, status)
[ ]   torus machines list displays all machines
[ ]   torus machines list --role [role] shows machines belonging to that
team
[ ]   torus machines list --destroyed shows destroyed machines
[ ]   torus machines view [identity] shows a single machine's details by id
[ ]   torus machines view [name] shows a single machine's details by name
[ ]   torus machines destroy [identity] destroys a machine by id after
confirming
[ ]   torus machines destroy [name] destroys a machine by name after
confirming
[ ]   torus machines list --destroyed shows only destroyed machines
[ ]   torus machines roles create creates a machine role
[ ]   torus machines roles lists lists all machine roles (including the
machine team)

Critical Path

[ ]   torus orgs create [name] creates an org.
[ ]   torus projects create [name] —org [org] creates a project.
[ ]   torus services create [name] —project [project] —org [org] creates a
service.
[ ]   torus set [key] [value] —service [service] will set the variable
[ ]   You can set using environment variables (e.g. TORUS_ORG)
[ ]   You can not set variables in services that do not exist
[ ]   torus set [path] [value] will set the variable
[ ]   torus view —service [service] will list secrets
[ ]   A secret can be set across services
[ ]   A secret can be set across environments
[ ]   More specific paths win
[ ]   Latest set wins
[ ]   torus run <command> —service [service] will inject secrets and execute
the command
[ ]   torus run <command> without a service defaults to "default" service
[ ]   torus unset [key] —service [service] will unset the variable


Parsing errors

Something not quite right here:
$ taskcluster-proxy -h
Usage: taskcluster-proxy [(-p|--port) <port>] [--client-id <clientId> --access-token <accessToken> [--certificate <certificate>]] ([-a|--all-scopes]|([-t|--task-id <taskId>] [-s|--scopes <scope>...]))
$ taskcluster-proxy -p 4 --access-token 43434

2018/03/01 19:44:01 {
  "--access-token": true,
  "--all-scopes": false,
  "--certificate": false,
  "--client-id": false,
  "--port": false,
  "--scopes": false,
  "--task-id": false,
  "-a": false,
  "-p": true,
  "-s": false,
  "-t": false,
  "\u003caccessToken\u003e": null,
  "\u003ccertificate\u003e": null,
  "\u003cclientId\u003e": "43434",
  "\u003cport\u003e": "4",
  "\u003cscope\u003e": [],
  "\u003ctaskId\u003e": null
}

As you see, the parsing should not succeed, since --access-token is specified without --client-id, yet the parsing succeeds, and assigns the access token to the <clientId> property.

From what I gather from the website you need to wrap the innards of [] with ()

Many thanks @fenollp, indeed it does seem to work with: taskcluster-proxy [((-p|--port) <port>)] [(--client-id <clientId> --access-token <accessToken> [(--certificate <certificate>)])] ([(-a|--all-scopes)]|([((-t|--task-id) <taskId>)] [((-s|--scopes) <scope>...)])).
Certainly this makes it a lot less readable - it would seem reasonable to me if docopt was to internally replace the innards of [] with (). I appreciate this is just the go implementation, so the responsibility probably lies with the parent project.
In any case thanks for highlighting the issue for me, and hopefully one day this requirement will be dropped.


add angular devcontainer

Angular actually has its own definition now, so I suspect we should just remove this one.
https://github.com/angular/angular/tree/master/.devcontainer

@Chuxel thanks for sharing :)


Detect if schema has been added or overwrite a schema without errors ?

I have a case with the latest Ajv (4.9.0) where I need to add multiple schemas lazily with multiple separate calls to ajv.addSchema. Unfortunately, there seem to be no easy way to detect if a schema has been added already (regardless of compilation status). If I call addSchema twice with the same id I get an exception and from the docs the getSchema method appears to work with compiled schemas only so I can not use this method to simply check if addSchema has been called already ?
It would be nice if addSchema could take an option where it would ignore or overwrite an existing schema OR if there could be a method to check if a schema has been added already (compiled or not).

getSchema compiles schema, you don't have to compile it separately.
So you can use addSchema to add and getSchema to retrieve (and compile, if it wasn't compiled before). If the schema doesn't exist, getSchema should return undefined.
Does it just need clarification in the docs or it is not sufficient for your use case? Some context would be helpful. Also, have you seen compileAsync method?
In any case, as a temporary workaround you can use ajv._schemas[id] || self._refs[id] to check the schema.

Thank you very much for the explanation. I think it is sufficient. Maybe a bit clarification of the docs for getSchema would be a good idea. I thought getSchema would only return something if already compiled.

I thought getSchema would only return something if already compiled.

@mmc41 thank you for the reply and closing. I will clarify in docs.


add option to toggle dark theme

here is an example that works without js.
https://codepen.io/oahehc/pen/OJPjZXB

neat

I know the argument against javascript I hate HTML5 too, but I made a javascript/userscript plugin to add this pull :)
no bs, just niceness :)
// ==UserScript==
// @name        New script - based.cooking
// @namespace   Violentmonkey Scripts
// @match       https://based.cooking/
// @grant       none
// @version     1.0
// @author      -
// @description 3/20/2021, 7:09:37 PM
// @run-at   document-start
// ==/UserScript==

////// CUSTOM 90's JS fun :)
//Why Javascript could be based too
document.querySelector("body > div > h1").textContent = "--> BasedN'Redpilled, no BS! ;) <--"; //I got this querySelector value -> // -> https://i.imgur.com/IUq4NXZ.png
//document.documentElement.style.cursor="wait";//Old school :) just have the wait cursor until you hover the thing :) I use it, I suggest you to try it

////////////////////
function GM_addStyle (cssStr) {
    var D               = document;
    var newNode         = D.createElement ('style');
    newNode.textContent = cssStr;

    var targ    = D.getElementsByTagName ('head')[0] || D.body || D.documentElement;
    targ.appendChild (newNode);
}

GM_addStyle ( `
	body {
		background: #F2F4F3 ;
		color: #1F1E1F ;
	}
	a {
		color: tomato ;
	}
	a:visited {
		color: gray ;
  }
`);

Please check https://github.com/LukeSmithxyz/based.cooking/pull/261#issuecomment-803429684
I made a whole userscript for counter this javascript need issue :) dont take me wrong I think its really cool to have this HTML sites again1!!!

#212

There is already a dark mode. In fact, it is default unless you have set your browser to want a light theme.

Chromium with the dark GTK theme in Linux and FreeBSD shows up as light. Is there any way to fix this?


Add feature to rate the talks

Please make it easier to rate talks, because only a few people will go back to the website to give feedback.

Right now there is a "Send feeback" link below every talk description which links to the website. I don't want to spam users with popups either. To make the feedback process easier you may want to make the website more responsive so the UI is better suited to phones.

Sure, nobody wants popups. I actually meant just having the feedback form in the app instead of just a link to the website. I don't know if the forms could be filled with a REST API or something similar though. If not, it would require some changes on the FOSDEM website as well.

The app can call a REST API, but if you use reCAPTCHA to prevent spamming the web form, you also need to provide a way to prevent spamming the API.

I added a dedicated "Submit feedback" button in 212faa8d7c44180757d8d72214f609cb859df166
This button is tied to feedback_url, a new field in the XML data.

Thanks for adding the feedback button. It took a while 😆, but it is still very much appreciated.


[unstable option] trailing_semicolon

Tracking issue for unstable option: trailing_semicolon

Setting this option to false is the only remaining reason one of my projects is using Nightly.

Related #3197

Note that this should probably match the behavior of Clippy's [semicolon_if_nothing_returned]


Remove Mac from Supported Destinations for the FreeAPS target

It was noted that Trio can be installed to Mac from TestFlight, and that this might be undesirable. This PR is an attempt to block that.

This does work for blocking building to your Mac from Xcode:

dev
this PR

But it seems to still show up in TestFlight:

Loop
this PR

So it doesn’t look like this PR does what it set out to do (block TF install on Mac).
I did look a little further into this, but it wasn’t successful:
https://github.com/bjornoleh/Trio/commit/2ae0fa1618aa7306e44f040c983f5808a38eca24
It was probably on the right track, but in fact blocked all installs from TF, including install to iPhone, when I limited the device family to only support iPhone.
The problem is probably related to this:
https://developer.apple.com/library/archive/qa/qa1623/_index.html
I think I’ll just close this PR for now.

I would prefer that we not block users from doing this.
I deployed Trio to my Mac just yesterday. I needed to develop a rather in-depth Shortcut. Being able to deploy Trio to my Mac meant that Trio Shortcuts became available to me to plug in to the complex Shortcut I was developing on my Mac. This of course only happens if we can build Trio to the Mac.
I created the shortcut on my Mac with a full keyboard, mouse, and large screen. Once I was finished, I sent the Shortcut from my Mac to the phone running Trio for live usage.
Trio being deployed to my Mac saved me many hours of much frustration in this use case.

@aug0211 , that’s a great use case, and I don’t see any immediate issues with allowing to install Trio on Mac. Closing this for now, and will let others pick this up later if needed.


"No such file or directory - bosh"

No such file or directory - bosh

I am getting this error with Concourse v3.6.0.

This was a very simple fix, by upgrading to:
https://github.com/cloudfoundry/bosh-deployment-resource

Added the resource to the yaml
username -> client
password -> client_secret


This repo is closed and not maintained again

For all mr Robot lovers who were hyped up to try this tool sorry to inform you this has been closed and if you want to restart this  project please reach out to me i would love to contribute

Fsociety

can i try and contribute

Please do not use this version, this repo has been EOL (End-of-life) for many years. Update to the new repo -> society

For all mr Robot lovers who were hyped up to try this tool sorry to inform you this has been closed and if you want to restart this project please reach out to me i would love to contribute

This repo was updated by team around 4 years ago now. We do not accept any contributions. Please do not advertise your own tools.


404 not found

my connection is not stable,so when there is a disconnecting,  I restart it ,now I download 56 packages ,according to the json, I think total packags is 216。 Today when I restart it, there is a error:

./utils/download_gigaspeech.sh: Downloading from the Tsinghua University host...
utils/internal/download_gigaspeech_from_tsinghua.sh: Start to download GigaSpeech user agreement
--2021-07-20 10:18:48--  http://www.tsinghua-ieit.com/dataset/GigaSpeech/TERMS_OF_ACCESS
Resolving www.tsinghua-ieit.com (www.tsinghua-ieit.com)... <IP_ADDRESS>
Connecting to www.tsinghua-ieit.com (www.tsinghua-ieit.com)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2021-07-20 10:18:48 ERROR 404: Not Found.

I don't know what's wrong ,does access term have time limits? like a month ?  thanks in advance.

the same wrong, waiting for answer

Tsinghua server is under maintenance because somebody used multi-thread downloader which generates too many requests,  please try to resume downloading in 3-4 hours or so.


'aframe-daydream-controller-component' is not in the npm registry

Done and done. Sorry about the delay!


Support tmux 3.2

Is your feature request related to a problem? Please describe.
tmux 3.2 was releases on 13.04.2021: https://github.com/tmux/tmux/releases and is already present in ArchLinux repos. Tmuxinator seems to work with this version, however it emits the warning:

WARNING: You are running tmuxinator with an unsupported version of tmux.

Please consider using a supported version:
(3.1c, 3.1b, 3.1a, 3.1, 3.0a, 3.0, 2.9a, 2.9, 2.8, 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1, 2.0, 1.9, 1.8, 1.7, 1.6, 1.5)
Press ENTER to continue.

Describe the solution you'd like
Tmux 3.2 should be added to the list of supported versions

There is already a PR for this #779

And that one is closed now, great news!

A tmuxinator release, even a bugfix one, to account for that, would still be helpful!


New tracking service

Opps. Though this had been merged in, already. Well have some syntax errors in your additions to the link/tracking attributes


Component attributes

Hi!
Is it possible to prefix the component attributes to a fixed value?
example
export default {
  name: 'app',
  components: {
    ComponentFixture,
    Editor,
    component
  },
  data: () => ({
    value: 'my value'
  })
}

and then
<component-fixture class="content">

  <component v-model="value">
  </component>

  <Editor slot="control" slot-scope="scope" v-bind="scope"/>

</component-fixture>

Thanks!

Hello @Garito this is a very good question. This is not possible right but this is a feature that I intend to deliver very soon. Stay tuned!!

I added defaults props to provide default props values
<component-fixture :defaults="{value: 45}">

Man, that has fast, thanks!
Upgrading already, will comment if necessary
Thanks again

Hi, again
I've installed it (yarn upgrade ComponentFixture) but I can't make it work
It doesn't raise any error but doesn't make any effect
Did I installed it correctly?
Should I paste here the actual code?

Open another issue.
Describe the scenario and share the mark-up


Support for elastic-oss

Hi there!
with version 6.3.0 of elastic's suite they split the repository in 2 variants: normal and open source
The main difference is shipping x-pack in the 'normal' variant while the oss branch stays bare as before.
For more details this article explains it: We Opened X-Pack
These packages can be downloaded from artefacts.elastic.co/packages/oss-6.x/apt | package-list
Problem is that these packages have an '-oss' suffix
As for implementing the support i could think of 2 variants on the spot:

Allow to configure the package name in manifest/install/[os].pp and let users configure the elastic-oss repo outside the module
similar to puppet/puppet-elasticsearch: package_name

Add full support for elastic-oss repository: a new bool variable similar to how puppet-elasticsearch solved this, which affects:
repository name: prefix 'oss-'
package name: suffix '-oss'
example: elastic/puppet-elasticsearch: oss

Thank you for your time and keep up the good work :)

Hi, I see a PR was created for this, which failed, can it be resurrected? We're unable to use anything past v 6.6.2 when using AWS Elasticsearch Service as a target.

I think that some of the changes to support Chocolatey in #237 have the potential to fix things here too - my plan is to get that one merged and then re-visit this issue.

I think since then (or at least for 7.x) they've named the packages the same, but now have split the OSS repo separately to the  non-OSS one. (At least, looking at the apt installation instructions, that's the case for the apt packages/repos.)
Which means the work in #237 to allow overriding the package name doesn't work anymore, because we need to be able to override the repo url (location in apt) to point at the OSS url.
I was thinking of adding an explicit $open_source => [Boolean] parameter to the filebeat class, and then we can change the logic internally depending on what's needed between major versions/OS' to install the correct version. What do you think about that as an approach @pcfens? 😄

Ha, turns out @UiP9AV6Y had a similar idea many moons ago in https://github.com/UiP9AV6Y/puppet-filebeat/commit/258bcb52650cc693c1679fa11623416ec177af06 referenced above. I'll likely rebase that on current master at some point soon 😀
For now I've worked around this in our puppet profile with the following:
  require filebeat::repo
  Apt::Source <| title == 'beats' |> {
    location => "https://artifacts.elastic.co/packages/oss-${filebeat_major_version}.x/apt",
  }

Let's do that - unfortunately I got sidetracked with other things and never made it back to this.
It seems like supporting the OSS package is becoming a lot more common instead of the edge case since we last looked at this too.


Flaky test: Page.setRequestInterception should cooperatively abort by priority

  1) request interception
       Page.setRequestInterception
         should cooperatively abort by priority:
     Error: expect(received).toBe(expected) // Object.is equality
Expected: 1
Received: 2
      at Context.<anonymous> (test/src/requestinterception-experimental.spec.ts:100:38)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

See https://github.com/puppeteer/puppeteer/runs/7232582574?check_suite_focus=true
Latest failure: "npm run test:chrome:headless", Linux, Node 18

Still flaking :(


"this" not reflecting inheritance for static methods

VSCode Version: 1.20.1
OS Version: OSX 10.13.3

Steps to Reproduce:

Create a class with a static method on it that returns "this"
Create a class that inherits from the previous class
Check the IntelliSense on the inherited class when calling the static method
3a. IntelliSense shows the returned value as the base class rather than the inherited class
3b. When following this same flow for an instance method IntelliSense correctly shows the returned
value as the inherited class

Does this issue occur when all extensions are disabled?: Yes

@benjaminmillhouse please provide a snippet that illustrates the problem and also mention what language you are using when the problem happens.

class C {
    static m() {
        return this;
    }
}
class D extends C {
    static n() {}
}
D.m().n(); // Works at runtime, fails in TS

Sorry - the language is JavaScript.
Here is some example code:
class SomeClass {
    static returnThis() { return this; }
    returnThis() { return this; }
}

class SomeOtherClass { }

SomeClass.returnThis() // IntelliSense detects the returned type as the SomeClass constructor
SomeOtherClass.returnThis() // IntelliSense still detects the returned type as the SomeClass constructor

new SomeClass().returnThis() // IntelliSense detects the returned type as a SomeClass instance
new SomeOtherClass().returnThis() // IntelliSense detects the returned type as a SomeOtherClass instance

This issue was moved to Microsoft/TypeScript#22000


Managed data revisited

This PR fixes these issues:

Using session_context() with literals instead of binding parameters
Before, a query like that:
UPDATE(Books,201).with({stock:111})

... endet up in a SQL query like that:
UPDATE
  sap_capire_bookshop_Books AS Books
SET
  stock = 111,
  modifiedAt = coalesce(ISO(NULL), session_context(?)),
  modifiedBy = coalesce(NULL, session_context(?))
WHERE ID=201;

... with these binding parameters:
[ '$now', '$user.id' ]

With this fix, the session variables are sent as inline literals instead:
UPDATE
  sap_capire_bookshop_Books AS Books
SET
  stock = 111,
  modifiedAt = coalesce(ISO(NULL), session_context('$now')),
  modifiedBy = coalesce(NULL, session_context('$user.id'))
WHERE ID=201;

Apply Input Converters before coalesce() for managed data elements
Before, expressions for writing managed data elements looked like that in the SQL output:
modifiedAt = ISO(coalesce(NULL, session_context('$now'))),

With this fix, the Input Converters, i.e. ISO() function is applied before the coalesce(<>,$now)
modifiedAt = coalesce(ISO(NULL), session_context('$now')),

Allow pseudo vars everywhere
With this fix queries like that are supported now, which wasn't the case before:
SELECT.from(Books).where(`createdAt = $now`)

Simplify UPDATE of managed data (todo)
Before, a query like that:
UPDATE(Books,201).with({stock:111})

... endet up in a SQL query like that:
UPDATE
  sap_capire_bookshop_Books AS Books
SET
  stock = 111,
  modifiedAt = coalesce(ISO(NULL), session_context('$now')),
  modifiedBy = coalesce(NULL, session_context('$user.id'))
WHERE ID=201;

With this fix this is optimised to that SQL:
UPDATE
  sap_capire_bookshop_Books AS Books
SET
  stock = 111,
  modifiedAt = ?,
  modifiedBy = ?
WHERE ID=201;

... with binding parameters like that:
[
  req.data.modifiedAt || req.timestamp,
  req.data.modifiedBy || req.user.id,
]

@BobdenOs we need to follow up on this: Fragile xtra condition for streaming in PostgreSQL
→ we can't keep that like that.
If I remove this extra condition about leading '$', postgres test/streaming.test.js will fail

I gave default and generated values a try with HANA, but it is very limited in which functions are allowed. Additionally it rejects any sub select as an invalid "user defined function". Which greatly reduces the chances of circumventing any limitations.


Add support for typia/ttsc

Closes https://github.com/checkdigit/github-actions/issues/37

@adcreare given recent news, I say we park this back into draft status.  will remove myself as a review for now.

Closing PR - ttsc probably isnt going to be the solution for us moving forward.


Fix the complete task feature

There is a bug when I complete a task, it adds more task. Please fix it.

There also is a new bug, it adds more than 1 task when you try to add 1

I will try to correct this for you


How to define gesture direction in component?

I have a FluidNavigator where I need to set two different directions in the gesture to go back to the page. Is it possible to define the desired direction dynamically?

Hi @FelipeBohnertPaetzold!
The Onboarding.js example has a setup that changes the direction to horizontal:

const Navigator = FluidNavigator({
  screen1: { screen: Screen1 },
  screen2: { screen: Screen2 },
  screen3: { screen: Screen3 },
}, {
  mode: 'card',
  navigationOptions: {
    gesturesEnabled: true,
  },
});
´´´


Unable to get-SPOTermGroup

I am getting the following error when i try to any of the term groups in my SPO tenant.
get-spotermgroup -GroupName People -TermStoreName Taxonomy_Ts8fW26l0Djlw4kzlbO1dg==
format-default : The collection has not been initialized. It has not been requested or the request has not been executed. It may need to be explicitly requested.
+ CategoryInfo          : NotSpecified: (:) [format-default], CollectionNotInitializedException
+ FullyQualifiedErrorId : Microsoft.SharePoint.Client.CollectionNotInitializedException,Microsoft.PowerShell.Commands.FormatDefaultCommand

Hi Dean,
It is most likely returning the the termgroup, however, due to the way the client side object model (which is being used behind the scenes) works you receive this message the moment a certain property has been been loaded from the server.
If you execute the cmdlet like this:
$group = get-spotermgroup -GroupName People -TermStoreName Taxonomy_Ts8fW26l0Djlw4kzlbO1dg==

and then
$group | Get-Member

Do you see a list of possible properties and methods? If so, it succesfully retrieved the termgroup. If a certain property is not available you can load that property for instance like this:
Get-SPOProperty -ClientObject $group -Property "<propertyname>"

alternatively
$ctx = Get-SPOContext
$ctx.Load($group.<PropertyName>) # for instance $group.Name
Execute-SPOQuery

Hi Dean, I will close this issue, but do not hesitate to reopen it if you still find this is an issue.


Modifiable Camera movement speed

Add an adjustment for the camera movement speed (WASD) similar to the mouse sensitivity feature.

If this isn't added by tomorrow I'll explain on Discord how to modify these values yourself, as well as the control scheme.


Protect against reorgs.

Although it's rare, we experienced some losses due to recycled payout transactions from reorgs.
We should analyze possible solutions and implement one.
More details on: https://github.com/flashbots/rbuilder/blob/develop/docs/REORG_LOSSES.md

You can find an example contract that implements reorg protection at https://github.com/0xmichalis/builder-reorg-protect


client cant connect to server?

It seems that my server is deployed:

but it occured something wrong when I running client:

could you please check it for me?

my fault, the first pic is vague...

the same problem.How to connect to the server?Or to say,I cant give  the request to the server...Did I wrongly operated?The server looked like deployed successfully,but I cant give the client request to the server..Thanks for your addressment!!!Appreciate!!

Hi! Was there any error on the server side when you sent your request?
Please also make sure to run json_numpy.patch() on the client side so you can json encode numpy arrays -- it seems that you are currenty converting the numpy array to a list, which isn't ideal. Probably you did this to prevent the error that the missing of json_numpy.patch() triggered.
https://github.com/openvla/openvla/blob/7f9467a4880162276f5ef95c047845c08b33960d/vla-scripts/deploy.py#L18

@kpertsch Thanks a lot! I found my problem that I use the wrong client IP when connecting to server, which should be <IP_ADDRESS> instead of <IP_ADDRESS>, because I run the server and client in the same machine. And the program runs well later, appreciating it!
BTW, I'd like to know the parameter about unnorm_key when I using requests.post() at the client. I did not set unnorm_key, which should be None I think, by browing the code. My code is as follow:

But the server side telled me I should select one of the followings as unnorm_key value:
AssertionError: Your model was trained on more than one dataset, please pass a unnorm_key from the following options to choose the statistics used for un-normalizing actions: dict_keys(['austin_buds_dataset_converted_externally_to_rlds', 'austin_sailor_dataset_converted_externally_to_rlds', 'austin_sirius_dataset_converted_externally_to_rlds', 'bc_z', 'berkeley_autolab_ur5', 'berkeley_cable_routing', 'berkeley_fanuc_manipulation', 'bridge_orig', 'cmu_stretch', 'dlr_edan_shared_control_converted_externally_to_rlds', 'dobbe', 'fmb_dataset', 'fractal20220817_data', 'furniture_bench_dataset_converted_externally_to_rlds', 'iamlab_cmu_pickup_insert_converted_externally_to_rlds', 'jaco_play', 'kuka', 'nyu_franka_play_dataset_converted_externally_to_rlds', 'roboturk', 'stanford_hydra_dataset_converted_externally_to_rlds', 'taco_play', 'toto', 'ucsd_kitchen_dataset_converted_externally_to_rlds', 'utaustin_mutex', 'viola'])
And I just use the franka arm for simulation, and I dont konw which scene should it belong to and how to choose a unnorm_key? I'm appreciate it if you could help me solve my problem.

Glad you figured it out!
Re unnorm_key: it's unlikely the model will work out of the box, so ideally you'd fine-tune it on your custom dataset (see some explanations here: https://x.com/KarlPertsch/status/1810698405192323088 , instructions for finetuning in the README also) and then set the unnorm_key to the name of your custom dataset.
If you really really want to use the model out of the box you should set the unnorm_key to the dataset that's closest to your test time camera & control stack setup, but again, it would be unlikely to work out of the box.

@kpertsch Thanks a lot！So nice job!


1.5.2

1.5.2
June 13, 2018
New Features

Updated SDK targets to Xcode 9.4 recommended settings, pod update'd third party Cocoapods used by the 2 demo apps, and eliminated Xcode 9.4 Build and Analyze warnings for SDK targets.

TEST

sh ./Scripts/build_all.sh PASSED
4 Analyze *.framework's PASSED
2 Analyze demo apps PASSED
8+1 iOS test suites PASSED
7+1 tvOS test suites PASSED
2 demo apps<PHONE_NUMBER>) run PASSED
2 demo apps<PHONE_NUMBER>) predicted results on OPTIMIZELY.COM PASSED

                   iOS     tvOS
    variation_a    0/11    0/6
    variation_b    6/6     4/4

2 "iTunes Connect" "Validate..." PASSED
Carthage installation into ~/OptimizelyCarthageTest app PASSED

    github "optimizely/objective-c-sdk" "a12c3e7901c0cd7ae3609e5fc29c25594e33f466"
    default       0/19
    treatment     17/20

~/OptimizelyCarthageTest app "iTunes Connect" "Validate..." PASSED

TEST: 1.5.2 SDK somehow fed a V4 datafile intended for 2.x SDK

Experimentation indicates that specifying projectId of a V4 datafile
will provoke 1.5.2 SDK to request older style
https://cdn.optimizely.com/public/PROJECTID/datafile_v3.json
instead of a newer style, such as
https://cdn.optimizely.com/json/PROJECTID.json
The result is AccessDenied from OPTIMIZELY.COM .
Experimentation indicates if we build app with a downloaded V4 datafile,
then runtime will report:
[OPTIMIZELY SDK][ERROR]:Provided OPTLYBuilder object is invalid

CONCLUDE: These are tolerable outcomes for attempting to use a V4 datafile
in a 1.5.2 SDK which doesn't support V4 datafiles with Optimizely Feature Management .
Users should upgrade to objective-c-sdk 2.x to gain support for V4 datafiles.

TEST VariablesTest, ManualTest, Xcode 9.4.1

VariablesTest PASSED

    default       0/43
    treatment    39/43

ManualTest PASSED

    default       0/49
    treatment    46/46

Xcode "Version 9.4.1 (9F2000)" released June 13, 2018 PASSED
No ill effect on already obtained 0 Build and 0 Analyze warnings on framework and demo app targets.


fetch_one_opt to retrieve zero-or-one rows as an Option

fetch_one retrieves exactly one row, with anything else being an error. fetch_all retrieves zero-or-more rows as a Vec. But sometimes, the database schema makes "more than one" an error, but either zero or one are possible.
I'd love to have a helper fetch_one_opt that retrieves zero-or-one rows via an Option.

...and somehow, I didn't find fetch_optional until moments after I filed this. Sorry for the noise.


Support for ActiveRecord

I am attempting to use ActiveRecord against a PG database that has the pg_vector extension.  I have a table that has a field named "embeddings" of type VECTOR.  When I attempt to create a new record in the table using a Ruby Array of Float as the value that I want to put into the embeddings field.  I get a type error in that AR can not typecast my source.

Hi @MadBomber, check out Neighbor for this.

Thank you @ankane   I dropped the pgvector gem and became neighborly.  program is seeding the db as I type.


Try that again

This reverts commit 68b82d973ed4cf48ea59260871754a57416240c2.

:tada: This PR is included in version 2.1.2 :tada:
The release is available on:

v2.1.2
v2.1.2
GitHub release

Your semantic-release bot :package::rocket:


enable test only when build as a root project.

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   80.36%   80.36%
=======================================
  Files           7        7
  Lines         163      163
=======================================
  Hits          131      131
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83885c...ec8505f. Read the comment docs.


Respect stability configuration file (stabilityConfigurationPath setting)

Projects can setup a Compose Stability configuration file which define packages & classes that the compose compiler will mark as stable types:
https://developer.android.com/develop/ui/compose/performance/stability/fix#configuration-file
Is there any way for these lint rules to respect these same settings? Removing @Immutable from types and adding the package to this file seems to cause the lint rules to produce false positives for those types.

Not against it but not sure how to propagate this file to a lint without duplicating configurations. They also allow for sharing config files as resources (similar to R8).


Require Node 18

This bumps our minimum supported version of Node.js from 16 -> 18.
Node 16 reached End-of-Life (EOL) on 2023-09-11:

https://github.com/nodejs/release#end-of-life-releases
https://nodejs.org/en/blog/announcements/nodejs16-eol

A number of our dependencies can't be updated because of this:

https://github.com/gadget-inc/ggt/pull/1060
https://github.com/gadget-inc/ggt/pull/1038
https://github.com/gadget-inc/ggt/pull/1090
https://github.com/gadget-inc/ggt/pull/1022
https://github.com/gadget-inc/ggt/pull/1095

/cc @airhorns I'm hoping to ship this in January.

Do you have usage stats on the node version from the field? How many folks are using node 16 right now?

Do you have usage stats on the node version from the field? How many folks are using node 16 right now?

Answered this here: https://linear.app/gadget-dev/issue/GGT-5384/require-node-18#comment-a8090b12


unmerging

Hi,
I'm posting multiple issues, but I have to say this is a great software. Thanks for developing it!
At the moment, it doesn't seem possible to unmerge objects. Is that a feature that you plan to add at a later point?
Thanks,
Vincent

Hi Vincent, thank you for the comment on HERBS. I am glad that I can help in the field :-) about the unmerging, may I ask the purpose to do so? I never thought about it before. I have a long list about all kinds of requests. If you can convince me this is a useful feature, I am willing to modify the code and add it as a feature 😄

Let me try to convince you then 😄 (and please let me know if we missed something).
Registering labeled cells to the atlas is often a multi-rounds process. After completing the registration and reviewing the results, we usually find regions that require further adjustments (each brain is unique and deviate somewhat from the atlas). However, if the Cells objects have been merged, they cannot be updated (e.g, by deleting the faulty slices, doing a new alignment). Yet to view the cells in the 3D window, the individual Cells objects have to be merged. So, what we do at the moment is to save the project before merging, so that we can go back to the un-merged version. Having the option to un-merge would remove the need to use this workaround.

Let me see. are you saying you want a functionality that after loading a merged cell object, you want to delete some of the cells from that object? According to the re-overlay images? that means you know which of the slices are wrong in the saved object, right? Do you usually match histological images to un-rotated atlas or rotated atlas?
I mean you click cells on 2D images, after adding pieces, the 2D coordinates are already gone, instead 3D coordinates of cells are generated. To un-merge an object, I need to know how many steps I have to go back. but according to what you said, you are not trying to un-merge, but trying a way to modify the object, right? please correct me if I misunderstood you.

you want to delete some of the cells from that object? According to the re-overlay images?

you are not trying to un-merge, but trying a way to modify the object, right?

Yes, essentially, we're looking for a way to modify the 3D object. I understand this might be somewhat complicated to implement in HERBS. This request comes from our current workflow, where we can load and scroll through all the histology images from a given experiment. After doing the atlas registration and cell counting, if we find labeled regions that need adjusting, we can go back to those slices and modify either the registration or the cell marker location. In HERBS, I figured the way to do that would be to delete the corresponding 2D cell object and replace it. That is not an option if the cell objects are merged into a 3D object.
Maybe what could be done is to allow users to preserve the 2D objects when merging, and just switch off their visibility?

Do you usually match histological images to un-rotated atlas or rotated atlas?

We first do the atlas registration (using the "Matching Histological Images with the Atlas" recipe), then we do the "Cell Body registration" step.

hmmmm, I mean normally we assume the cutting plane (coronal, sagittal, horizontal) is perfect, but it is not always true. In HERBS users can do the virtual cutting by any angle on atlas, then match the histological images to the arbitrary angle cut atlas slice. I wonder when you match the histological images to the atlas slice, do you rotate the slice first and then match? Or totally no rotation on the cutting plane? I have to ask this, because if you match a histological image with rotated slice, you have to remember how you rotate the atlas slice, so that you can trace back which cells are from the same slice (if I make a cell object can be modified, but not undo merging). The 2D and 3D are related, I can go back and forth between these coordinates. But for 2D coordinates, there are a lot more different situations to consider about. So the more I know what you usually do, the easier for me to think about how to modify code.

I see. We do rotate the slices, and keep records for each section. Something like this:
Slice		AP (25um)		Coronal Left/Right angle	Coronal Top/Down angle
K3M2_1_1	396 (2775.98)	        8							0
K3M2_1_2	393 (3250)		8							0

Thanks for the explanation, then either undo merging or modify cell objects. I have to think a bit more 'which is the best solution'. One thing needs to be noted, only recording the angle is not enough. So far I give users so much flexibility that the rotation origin is changing when you slicing through the atlas. The rotation origin is at the intersection of 3 planes when there is no rotation. so besides the angles, you have to record all AP, ML, DV page number.

Sounds good. Happy to chat or provide more feedback if needed.

Hi @vncntprvst , un-merging is on GitHub, not PyPI yet, but will be soon. The first button will do un-merging on a merged object.

Hi @vncntprvst, sorry for such a late reply. I finally updated the code on GitHub and PyPI. I will close this issue and please do open a new issue if there is something wrong or not clear!
Thank you for the interesting request and your clear explanation about the request. I wish you a happy holiday season and see you in 2023!


:seedling: Improve search commit e2e tests

Add 2 tests for searching commits in e2e/searchCommits_test.go
Fix errors in e2e/searchCommits_test.go when not using HEAD or when user does not exist

[e2e/searchCommits_test.go]

Add 2 tests for searching commits
Fix error when not using HEAD
Fix error when user does not exist

What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)

[ ] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
What is the new behavior (if this is a feature change)?**

[ ] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Alternatively, these could probably be hooked up to a stub http.RoundTripper and avoid the need for downloading altogether.
Similar to what we do in the webhooks test:
https://github.com/ossf/scorecard/blob/cc55b364b90bee78cd816a781b79b74cac5969e5/clients/githubrepo/webhook_test.go#L71-L89


Added a scan into the workflow

@my0373 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


setting element reference in setStore modifies the values in the array

Describe the bug
I have a store just like this:
const [store, setStore] = createStore({
  items: [] as Item[],
  current: null as Item | null,
})

If I use setStore("current", items[index]) to change current into another element in array, the source array will be changed by this call, see the example below.
Your Example Website or App
https://stackblitz.com/edit/solidjs-issue-vgcaxz
Steps to Reproduce the Bug or Issue

Click the Item 1, and the current will change from null to item 1.
Click the Item 2, the current will change from item 1 to item 2, but it also changes the item1 element to item2.

Expected behavior
I expected the current will change without the array changes.
Screenshots or Videos
No response
Platform

OS: Linux
Browser: Edge
Version: 123.0.2420.81

Additional context
No response

A temp solution for users maybe using deep copy:
setStore('current', JSON.parse(JSON.stringify(items[index])))

But this looks ugly...

 Objects passed into setStore being mutated has cost the company where I'm working at hours of frustration and debugging but it's been happening so deeply nested in our stack that we hadn't reached the breaking point of actually finding the issue. We're using reconcile and I initially thought that was the issue, good to see it's just with stores.
Also, a nicer temp solution than JSON.stringify is using structuredClone (that's how we temp fixed it):
setStore('current', structuredClone(items[index]))

I would change the workflow à little to adress your problem by normalising the state à little:
const [store, setStore] = createStore(() => {
  items: [] as Item[],
  currentIdx: null as number | null,
})

const current = () => store.items[store.currentIdx]

Now you just setStore("currentIdx", index) and current update reactively. It has the advantage of having a single source of truth.

https://www.solidjs.com/docs/latest#getters
If you want everything in the same place you can also write it :
const [store, setStore] = createStore(() => {
  items: [] as Item[],
  currentIdx: null as number | null,
   get current() {
        return this.items[this.currentIdx]
   }
})

It's great that there's a workaround for @Reverier-Xu's case but I still think createStore should be fixed, because I don't think there's any possible workaround for my usecase except for structuredClone right now

@Reverier-Xu try this setStore({current: item});

@elite174 That seems a better & elegant way for this case and do not require copy'hacks, I forked the example site and find it worked well, but this usage is not introduced in Solid Docs umm...
but @danieltroger's issue still happens, weird that.

I wouldn't recommend using syntax from the example (setStore("current", items[index]))
The point is that it's quite dangerous.
I described an issue with it in my article here: https://vladislav-lipatov.medium.com/solidjs-pain-points-and-pitfalls-part-2-175aca906e98

Personally, I think it's better use objects or produce

Yes.. this is due to shallow object merging. It was a call to be consistent with top level but it is an idiosyncrasy of this path API. So while it is confusing it is documented and by design. This dates back to when React was still on class components and it was very common to call setState with an object. Merging was expected. hope to move away from this API as the default in future versions of Solid. But it is what it is now. Closing as by design.
The answer is not to structured clone at least in the simple case. It's to use the object syntax to set. You can always go up a level and use an object and it will not merge.
Ie
// don't
setStore("current", something)

// do
setStore({ current: something });

// don't
setStore("a", "b", something);

// do
setStore("a", { b: something });

@danieltroger
My guess though your issue is that reconcile or any state changes in stores do mutate. This way reactivity is transitive (same reference in multiple stores etc)... So if you keep external references to objects that have been passed into stores previously then yes you will in some cases find them changed. This also makes sense from the perspective that we close over variable references that don't change so something has to mutate along the way.

@ryansolid thanks for your explanation. I don't quite understand everything ("transitive reactivity", "close over variable references") but it seems plausible - we do pass an object down into the store, clone parts of it and add/remove things to the clone, pass that out (to react) and pass it back into the store.

Is it desired behavior then that stores mutate the object being passed into it, and not a bug? (Maybe mention this in the docs because I would not expect it)
Would calling unwrap on all values before passing them back up to "react world" stop this behavior from happening? Because structuredClone doesn't work on functions so it's not a "scalable" solution to this problem

Hi, I ran into this same issue 2 months ago see: https://github.com/solidjs/solid/issues/2063
And trying figuring it out was kind of like @danieltroger describes :)
The problem I've noticed is that switch from "data-type" null to object.
The first object passed will be used as the object for future mutations.
Another way to "solve" it is to not switch from null to item so:
const [store, setStore] = createStore({
  items: [],
  current: {},
})

See my playground example: https://playground.solidjs.com/anonymous/89aecb87-da00-4fa8-bfc3-72794555d630.
You can change the current: null to current: {}
However if (store.current) { } will now always be truthy.
And if it where to get set to null at some point and re-set again we introduce the issue again.
So probably best to just follow what @elite174 and ryansolid wrote :)


Documentation: Tidy up of Lucene.Net.Join

Fixing broken links referring to Lucene.Net.Search.Join. Namespace is Lucene.Net.Join in the other docs.
Breaking what looks like it was supposed to be bullets into bullets rather than a single bullet
Making code sample render as code sample

Hi @stevetemple thanks for this. The way that the docs are produced goes through quite a process of converting the docs from the java source to the .net source through various processes of transformation. In order to get this fixed we'll need to adjust the transformation process to make sure this is output correctly otherwise these changes will just get overwritten next time we build the docs.
That said, this is a great start for me to know what needs changing and to document how this process works. For this fix, we'll need to adjust this project: https://github.com/apache/lucenenet/tree/master/src/dotnet/tools/JavaDocToMarkdownConverter
which is the tool that is run against the java source (zip output) https://github.com/apache/lucene-solr/releases/tag/releases%2Flucene-solr%2F4.8.0

Oh wow, I thought there was something odd about the docs.
This just got more fun... will take a look in the morning

Have created another PR https://github.com/apache/lucenenet/pull/233 that should fix the namespaces that 404

Great stuff @stevetemple , should this PR be closed then?

@Shazwazza I think there are two more things I've spotted which would be nice to get working before closing this as matching the output of the automated conversion:

New paras appear to be starting with a space which messes up formatting following the list
The code samples aren't getting tripple back ticked

Now we're on latest Html2Markdown I think they will be trivial to solve

OK, i uploaded the build output of the docs but i don't think it fixed the issues expected but maybe i did something wrong. I'll need to run locally and test too but won't be able to till next week.

Oh, where did you upload them?

Just to the main docs site https://lucenenetdocs.azurewebsites.net/

Oh that looks disappointly unchanged, even the namespace update hasn't happened

yeah i think i must have deployed it incorrectly, i'll test, etc... this week

@stevetemple ah it was because i just didn't re-run the docs migrator and commit the changes 🤦♂ I've done that now and things look much better. I've deployed those changes to the site  https://lucenenetdocs.azurewebsites.net/

That looks a look a lot better. Any idea how best to tackle method names being different casing between java and C# getTopGroups -> GetTopGroups etc.

Just FYI, the original idea behind the Javadoc to Markdown converter was to clean up the "namespace" documents to a level of around 80-90% and then do the rest of the work manually. Generally speaking, that would not include the code samples. The idea was that it would only be run one time per Lucene port to Lucene.NET manually, not be put into a pipeline.
 The code samples in the "namespace" documents are probably simple enough to do automation on by setting up specific rules. Short of that, we could probably rig up something with a hash code to alert us to when the code changes in the pipeline so they can be manually dealt with.
Of course, in the code examples we should try to put our best foot forward. We have managed to take advantage of some of .NET's type initializers to significantly improve the readability/reduce verbosity of the code (for an example, the "Add to the Index" section of the home page), and we should try to make our documents reflect those changes rather than just a carbon copy of the Java code.
Speaking of which, the "Construct a Query" section on the home page could also be simplified from:
// search with a phrase
var phrase = new MultiPhraseQuery();
phrase.Add(new Term("favoritePhrase", "brown"));
phrase.Add(new Term("favoritePhrase", "fox"));

to:
// search with a phrase
var phrase = new MultiPhraseQuery
{
    new Term("favoritePhrase", "brown"),
    new Term("favoritePhrase", "fox")
};

I think we could get this pretty close. The code samples being the most difficult part.
I agree that at some point it would make sense to say this is as good as it's going to get and switch to manual updates then a notification of something changed and put in a queue to review.

Hi all, i'll close this PR as many things have been resolved in the #235 changes and many of those changes have already been applied to the live docs site. I'll try to get some final changes in to #325 and merge and start a new one with any pending changes. I have ideas for the code snippets too, i think we can still get quite far with the automation side of things before we have to start thinking of modifying the docs directly.


Use releases to provide pacakages

Instead of committing apk in git It would be much more  simpler if you use releases feature and publish apk on it.
Multiple binaries can be upoaded so a zip of Labserver and a apk of mobile component could be made available.

And fixed this one too :) Thanks for pointing it out.


The blob name is incorrect when opening one blob which name contains ':'

Storage Explorer Version: 1.27.0
Build Number: 20221201.1
Branch: rel/1.27.0
Platform/OS: Windows 10
Architecture: ia32
How Found: Ad-hoc testing
Regression From: Previous release (1.24.3)
Bug Description

If there is one letter in the front of the ':' in the blob name. The letter and the colon will not show.
If there is more than one letter in the front of the ':' in the blob name. The ':' will show as '%3A'.

Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Upload .txt file.
Right click the uploaded blob -> Clone it with a new name f:ile.txt.
Open the file with notepad.
Check whether the file name is correct.

Expected Experience
The file name is correct.
Actual Experience
The file name is incorrect.

Additional Context
On 1.24.3 release.

The security dialog pops up when trying to open the blob which name contains ':'.

Click 'Yes'.
Will open a temporary path.

Fix merged into main

Verified this issue on the build main 20221203.4. Fixed.


Add 'address build-*' commands

Issue

This PR results in breaking changes to upstream dependencies.

Checklist

[ ] This PR contains all the work required to resolve the linked issue.

[ ] The work contained has sufficient documentation to describe what it does and how to do it.

[ ] The work has sufficient tests and/or testing.

[ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[ ] I have added the appropriate labels to this PR.

Once the names are decided upon I can add a test for the new command

bors merge

bors r+

bors merge


Initialize PersistentCollection typeClass from targetDocument when possible

Set typeClass once owner information is passed to collection
-> this does not require any change outside of the Persistent Collection
-> also fixed usage of ODM in https://github.com/sonata-project/SonataAdminBundle/pull/2985

@wodka: Good approach! You need to check if targetClass is set as ODM doesn't require that property, I think it's best to throw an exception saying that getTypeClass() is not available for mixed document references. Given that I'd also add a test :)

well, looks also better on travis now :)

@wodka I was about to write about my notes but I see you've already adjusted that :) Could you also add a test case if the exception is thrown when targetDocument is not set?

Done :)

Merged manually in https://github.com/doctrine/mongodb-odm/commit/5b30e0f7a677c8a7494d82176bb8a747f4e82fb9 - thanks @wodka!

@wodka, @malarzm: Was this method present in an interface, or is it just something in ORM that we're implementing for compatibility?
Since this is a new feature, it may be worth adding a changelog entry for it.

Scratch that. I thought this was adding a new method for some reason. It is definitely just a bug fix :)


[M2] Avoid allowing user to connect bank account before Finclusive KYC complete

As an end-user, I need to be able to connect my bank account with Plaid (step 2 in the "link bank account" UI) ONLY once it's possible to do so, i.e. once my Finclusive compliance check has completed.
One way we could do this:

upon finishing the Persona flow and navigating back to the link bank account screen, query IHL for the user's finclusive compliance check status
if pending, set a timeout to query again in a few seconds and show the "pending" status in the meantime
do this for every subsequent visit to the link bank account screen (just try twice... we probly don't need continuous polling since if it isn't done in a few seconds, it's probly held up for manual review)

AC:

step 2 visible in link bank account flow only once Finclusive KYC is complete
Settings screen also updated
Finclusive KYC rejected case is handled
the UI is still reasonably responsive (doesn't require app restart to update, for instance)

Notes:

Could do this polling from IHL or a cron job (like, while user is in pending finclusive state query every N minutes)

Hey @MuckT we have commented our observations in #2059
CC : @cajubelt
Thanks.!!


UI: Move the GPS privacy notice at the bottom of the screen

Is your feature request related to a problem? Please describe.
Yes: the text is non-clickable and made me confused when I wanted to select again the Weather Location.
Plus, the text is too long to be in the middle of the screen, it makes UI odd (screenshot 1 in blue).
Plus, the word ''use.'' is alone in a single row, but making the UI with the circlee-info-icon (i) will be okay beacause it makes the text more in the left.
Describe the solution you'd like
If GPS activated (like you programmed), display the notice in the bottom of the screen (like for Clock and Glance: screenshot 2 in red).
Alternative
Make the notice permanent at the bottom of the screen, but add the text ''When GPS is on, ...''.

I have to change back the UI due to a Google Play Store policy that forces me to show that warning near the "Geolocalization" feature. I'll keep the updated string and increase the font size.

I have to change back the UI due to a Google Play Store policy that forces me to show that warning near the "Geolocalization" feature. I'll keep the updated string and increase the font size.

Google Weather official app does not display any warning anywhere. So who cares? 😂

I have a new idea: make the GPS notice as a subtitle for Provider section, just like drag-and-drop notice for Glance.


shell_plus doesn't accept input

I really have no idea what's happening here:
$ ./manage.py shell_plus
# Shell Plus Model Imports
from allauth.account.models import EmailAddress, EmailConfirmation
from allauth.socialaccount.models import SocialAccount, SocialApp, SocialToken
...
# Shell Plus Django Imports
from django.utils import timezone
from django.conf import settings
from django.core.cache import cache
from django.db.models import Avg, Count, F, Max, Min, Sum, Q
from django.core.urlresolvers import reverse
from django.db import transaction
Python 2.7.6 (default, Jun 22 2015, 17:58:13)
Type "copyright", "credits" or "license" for more information.

IPython 3.2.1 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.

In [1]:

At this point, the cursor is where we expect, but it doesn't accept input. Anything I type (including ctrl-c) just gets queued, and when I finally kill the process then all my typing arrives at the bash prompt.
If I use ./manage.py shell_plus --ipython (instead of the default ptpython) then it works fine. Also if I run ptpython at the command-line, that works fine too.

I have a very similar issue.
python manage.py shell_plus --ipython
python manage.py shell_plus --ptpython
are not responsive.

Seems to work me.
./manage.py shell_plus --ipython
# Shell Plus Model Imports
from django.contrib.admin.models import LogEntry
from django.contrib.auth.models import Group, Permission, User
from django.contrib.contenttypes.models import ContentType
from django.contrib.sessions.models import Session
# Shell Plus Django Imports
from django.urls import reverse
from django.utils import timezone
from django.conf import settings
from django.core.cache import cache
from django.contrib.auth import get_user_model
from django.db.models import Avg, Case, Count, F, Max, Min, Prefetch, Q, Sum, When
from django.db import transaction
Python 2.7.13 (default, Dec 17 2016, 23:03:43)
Type "copyright", "credits" or "license" for more information.

IPython 5.3.0 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.

In [1]: settings
Out[1]: <LazySettings "testsetup.settings">

In [2]:

Version of IPython seems old have you tried updating ?
Test cases in the django_extensions test suite would be best. Then we are forced to fix it since there is a test for it :)
Otherwise please see if a reproducible test case can be made.
Without those this is very hard to work on for a contributor...
Thanks !

FYI I filed this almost two years ago and I'm no longer interested in it, so I'm unsubscribing from the conversation.

Then we will close the issue and consider it solved.
For future reference; If somebody finds this and has a similar problem please open a new ticket with a PR for a test case.


NSM have high CPU usage when errors happen

When running scalability tests I found out that when heal starts, NSM consume roughly 1 core for each of the connections to heal for several seconds.
CPU profiles, that can be found here, suggest that the CPU load is caused by log (*groupLogger) Errorf → debug Stack.
The likely reason for this is the following line:
https://github.com/networkservicemesh/sdk/blob/92b282404ca12856deffaa8ddc91b6ba76cd8375/pkg/tools/log/spanlogger/spanlogger.go#L68
In this line we create a new stack snapshot each time we log anything as error, and when a chain element at the end of the chain returns an error, almost all of previous elements also return errors.

I deleted debug.Stack() part from span logger and rerun the tests, and it seems to have fixed the CPU load.

Seems like fixed by https://github.com/networkservicemesh/sdk/pull/1053


Improve 'data-html' conditional in select2.js

With widget=autocomplete.ModelSelect2(attrs={"data-html": True}) an empty attribute, data-html, is set on the relevant html node telling the javascript to render the get_result_label text out as html rather than text.
However, when it comes to the test if (element.attr('data-html') !== undefined) the value being assessed is the empty string and so that test is failing and the markup we want to render is just coming out as a string, tags and all.
This diff improves that conditional so that the test passes on the empty string and the html is correctly rendered out as we would expect.

As for me looking in this code, the old condition should've worked properly.
With widget=autocomplete.ModelSelect2(attrs={"data-html": True}) we have HTML for widget like <select data-html ... dal-autocomplete-function="select2">...</select>
element.attr('data-html') for this select returns "". Because "" !== undefined is true in JS (check it in the browser console) the if branch is executed and HTML is rendered in Select2 items.
With widget=autocomplete.ModelSelect2(attrs={"data-html": False}) (or no attrs at all) we have HTML like <select ... dal-autocomplete-function="select2">...</select>
element.attr('data-html') for this select returns undefined. undefined !== undefined is false in JS, we're going to the else branch and rendering text in Select2 items.
I rechecked this just now: it works as intended in the following cases:

widget=autocomplete.ModelSelect2(attrs={"data-html": True}) renders items as HTML;
widget=autocomplete.ModelSelect2(attrs={"data-html": False}) renders items as plain text;
widget=autocomplete.ModelSelect2(attrs={"data-html": "true"}) renders items as HTML (old client code is unaffected).

Could you please explain me where am I wrong?  Or provide an example where old code works incorrectly?

Ah, my apologies, it looks like the conditional was updated in commit https://github.com/yourlabs/django-autocomplete-light/commit/32097207e10d0dfff4c3a0c046f997237815e6bf a couple of days ago.  I was working around the previous (element.attr('data-html')) which is no longer the case.
Feel free to close this, sorry for the static. Thanks for the effort.

@jhrr yeah, previously you had to write {"data-html": "true"} in Python code. It was stated in the docs but writing "true" instead of True Python code seemed ugly, so I fixed it.

It's better! Thanks very much.


Atom will be unresponsive during the loading of very large files.

Prerequisites

[ ] Can you reproduce the problem in safe mode?
[ ] Are you running the latest version of Atom?
[ ] Did you check the debugging guide?
[ ] Did you check the FAQs on Discuss?
[ ] Are you reporting to the correct repository?
[ ] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
[Description of the bug or feature]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Versions
You can get this information from executing atom --version and apm --version at the command line. Also, please include the OS and what version of the OS you're running.

Duplicate of https://github.com/atom/atom/issues/8864 tracking it there.


Training dataset structure

Hi!
How should I structure my training dataset in order for this implementation to work?
Also, what does IMAGE_SIZE refer to? Why the default is 96?
Thank you

Reference from origin paper Photo-Realistic Single Image Super-Resolution Using a Generative Adversarial
Network
# 3.2
3.2. Training details and parameters
We trained all networks on a NVIDIA Tesla M40 GPU using a random sample of 350 thousand images from the ImageNet database [44]. These images are distinct from the testing images. We obtained the LR images by downsampling the HR images (BGR, C = 3) using bicubic kernel with downsampling factor r = 4. For each mini-batch we crop 16 random 96 × 96 HR sub images of distinct training images. Note that we can apply the generator model to images of arbitrary size as it is fully convolutional. For optimization we use Adam [35] with β1 = 0.9.

Reference from origin paper Photo-Realistic Single Image Super-Resolution Using a Generative Adversarial
Network
# 3.2
3.2. Training details and parameters
We trained all networks on a NVIDIA Tesla M40 GPU
using a random sample of 350 thousand images from the
ImageNet database [44]. These images are distinct from the
1https://github.com/xiph/daala (commit: 8d03668)
2https://github.com/jbhuang0604/SelfExSR
3http://cv.snu.ac.kr/research/DRCN/
4https://twitter.box.com/s/
lcue6vlrd01ljkdtdkhmfvk7vtjhetog
5https://github.com/david-gpu/srez
testing images. We obtained the LR images by downsampling the HR images (BGR, C = 3) using bicubic kernel
with downsampling factor r = 4. For each mini-batch we
crop 16 random 96 × 96 HR sub images of distinct training
images. Note that we can apply the generator model to
images of arbitrary size as it is fully convolutional. For
optimization we use Adam [35] with β1 = 0.9.

Reference from origin paper Photo-Realistic Single Image Super-Resolution Using a Generative Adversarial Network
# 3.2
3.2. Training details and parameters
We trained all networks on a NVIDIA Tesla M40 GPU using a random sample of
350 thousand images from the ImageNet database [44]. These images are distinct
 from the testing images. We obtained the LR images by downsampling the HR
images (BGR, C = 3) using bicubic kernel with downsampling factor r = 4. For
each mini-batch we crop 16 random 96 × 96 HR sub images of distinct training
images. Note that we can apply the generator model to images of arbitrary size
as it is fully convolutional. For optimization we use Adam [35] with β1 = 0.9.

Thank you. As for the structure, I've also figured out I have to name the folders train and test, not train and valid (for DIV2k)


Register

When you register, and it is successful, then the fields to enter information should no longer be shown.
When you register and the user is already existing, the current message is "Form is not valid".  The message should be "Already Existing, please create new registration or reset your password." IN RED.

I will get it done @heldyboy

Thanks sir!

Hey,
I just pushed the modifications you suggested.
I am closing the issue.
If you need more changes feel free to reopen the issue again.


Add some safety limits

It is not clear to me why we are limiting the size of strings at this level? Shouldn't that be done at the application layer and not in the crud mutators?

Yeah I ended up doing this a different way. Closing this.


Remove Eureka Service

@nkocsis I see no description as to what this is about - please provide some context/description.

Included in Zowe V1.3


Pokemon naming not working correctly

Just noticed something odd, I just saw my bot catch a Jigglypuff with an IV of 0.8. I'm using the Task:
{
"type": "NicknamePokemon",
"config": {
"nickname_template": "{name}_{iv_pct}"
}
}
but the bot renamed it to:
Jigglypuff_8
Shouldn't it rename to Jigglypuff_80 ? or is there something wrong with my config ?

Niantic imposes a 12-character limit on all pokemon nicknames, so any new nickname will be truncated to 12 characters if over that limit. Thus, it is up to the user to exercise judgment on what template will best suit their need with this constraint in mind.

use
"nickname_template":"{name:.8s}-{iv_pct}"
and it should make
Jigglypu_80

Ah right, thanks makes perfect sense.
I'll use that.
Cheers
Mat

or you could also change the template to
{iv_pct}_{name}
to have the IV first and name of fitting size after


Cannot install into a directory with spaces

mkdir needs to quote everything: "$(DESTDIR)$(PREFIX)/bin"
https://github.com/unInstance/untldr/blob/d8d35bb00228152fc6d4c3179b94db2bee1facd3/Makefile#L40

Thank you for the involvement! I have enabled e-mail notifications from GitHub, so further reviews of contributions will, hopefully, not take that long.


docs/AboutUs: add Ngo Wei Lin's details

About Us.adoc does not include details of all team members in team T09-1.
Let's update the documentation to include Ngo Wei Lin's details by:

adding his personal project portfolio template
adding his avatar image
updating his roles and responsibilities

Coverage remained the same at 93.754% when pulling f0e168ff5e8c67a2bdc3e3a15bcdeb5229252bee on Creastery:update-about-us-creastery into 5a22be6c5de705a1aff6f9982418717e2b667ac9 on cs2113-ay1819s2-t09-1:master.

Coverage remained the same at 93.754% when pulling f0e168ff5e8c67a2bdc3e3a15bcdeb5229252bee on Creastery:update-about-us-creastery into 5a22be6c5de705a1aff6f9982418717e2b667ac9 on cs2113-ay1819s2-t09-1:master.

Thanks for the quick review!


FIX - failing if admin name is not 'Administrator'

Pull request
Describe your changes
The check, remediation and rollback were failing if the Admin user was renamed to something else than "Administrator".
Now the admin name is found and given as a parameter to the command.
Checklist

[ ] I have performed a self-review of my own code
[ ] I have added tests to prove that my code is effective
[ ] I have made the corresponding changes to the documentation

Additional notes

One of the tests-windows test was failing because of that. This should solve it

This couldn't be fully tested on windows because our test VM is down. Needs some more test before merge.