Change assert in NamespacedID.from() to throw IllegalArgumentException instead

Fixes #1097.
Java programs have assertions turned off by default, and therefore you can register invalid namespaces with Minestom if you do not have assertions on.
This PR fixes it by replacing the assertions with exceptions instead.

Re:

Java programs have assertions turned off by default
it is the original reason why these were assertions

I also think that it depends a lot on the context, if we're witnessing a misunderstanding about Assertions or not (but I also don't know Minestom's Codebase enough):
Assertions are off by default so that they show now runtime overhead, but assert semantic failures in development builds (e.g. similar to how other languages have Debug and Run configurations)
It now depends on the context of this failure on whether we should rather push Assertions and basically build some documentation, showing how to run the server with assertions enabled (and to use that on QA/Testing environments, in case you don't run the server from the IDE).
Since using an invalid namespace does not cause any major fuck-up in unrelated parts (??), one could argue that an assert is still the right thing. You'll also immediately get feedback by the client when using such a namespaced key illegally.
But then, those IDs are probably cached, so the code path is not too hot and Minestom doesn't seem to use asserts very widely anyway.
Pick your Poison: Learning Curve of running with -ea or a runtime overhead in code bases that do it right.


ripemd160 is not supported

Hi, when doing :
var randomSeed = lightwallet.keystore.generateRandomSeed(extraEntropy)
it throw :
Error: ripemd160 is not supported (we accept pull requests) Trace de la pile : module.exports@http://localhost:8080/app.js:151561:19 module.exports@http://localhost:8080/app.js:151550:11 Hash.ripemd160@http://localhost:8080/app.js:198294:11 Hash.sha256ripemd160@http://localhost:8080/app.js:198299:11 HDPrivateKey.prototype._buildFromBuffers@http://localhost:8080/app.js:207826:22 HDPrivateKey.prototype._buildFromObject@http://localhost:8080/app.js:207714:11 HDPrivateKey@http://localhost:8080/app.js:207469:6 HDPrivateKey.fromSeed@http://localhost:8080/app.js:207760:11 Mnemonic.prototype.toHDPrivateKey@http://localhost:8080/app.js:208956:11 KeyStore@http://localhost:8080/app.js:170272:19 newWallet/<@http://localhost:8080/app.js:143693:24 KeyStore.deriveKeyFromPassword/cb@http://localhost:8080/app.js:170628:8 scrypt/</<@http://localhost:8080/app.js:210140:10 scrypt/interruptedFor/<@http://localhost:8080/app.js:210099:12 onNextTick@http://localhost:8080/app.js:78599:10 Item.prototype.run@http://localhost:8080/app.js:2340:6 drainQueue@http://localhost:8080/app.js:2310:18
As it is no (longer ?) supported, does anyone use it or everyone has forked eth-lightwallet to use another hash ?
Thank you

Is this related to https://github.com/webpack/webpack/issues/1568 ?

Hi @hitchcott, yes, thank you for the pointer, but the node-libs-browser workaround does not work for me (I have the same error)

Related to https://github.com/bitpay/bitcore-lib/issues/34
Any thoughts ?

I've encountered same error, but change to use webpack 2 instead of 1 solved my issue.

Awesome @tmyjoe! Worked like a charm for me too!

I have encountered the same problem once I tried to use eth-lighwallet in a create-react-app . This is the solution I am using now.
// monkeypatch (see: https://github.com/bitpay/bitcore-lib/issues/34)
import crypto from 'crypto'
const sourceCreateHash = crypto.createHash
crypto.createHash = function createHash(alg) {
if (alg === 'ripemd160') {
alg = 'rmd160'
}
return sourceCreateHash(alg)
}

For people who are still having this issue.
Update: node-libs-browser
(npm i node-libs-browser)
This package pulled in an old version of createHash within crypto-browserify.


Upgrade to latest django / django CMS

Description

Upgrade to Django 3.2+
Upgrade to django CMS 3.9+
Remove support for aldryn-search
Upgrade github actions

References
Fix #720
Checklist

[x] I have read the contribution guide
[x] Code lint checked via inv lint
[x] changes file included (see docs)
[ ] Usage documentation added in case of new features
[ ] Tests added

Fix #721


Use parameter_types instead of thread_local for test-setup

PR for: #12020
WIP

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - cargo-check-benches
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1746777

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - cargo-check-benches
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1746778

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1746999

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1746998

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - cargo-check-benches
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1748220

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - cargo-check-benches
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1748335

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - cargo-check-benches
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1748405

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1750233

So I'm noticing some of the checks are failing because I haven't changed the variables to camel case, but on changing the variables to camel case I'm getting errors. How do I work around this? @kianenigma

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1750594

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1754151

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1754150

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1754152

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1756360

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1756436

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1756438

The CI pipeline was cancelled due to failure one of the required jobs.
The job name - test-linux-stable
The job logs - https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1756477

Hey @shawntabrizi. The PR isn't finished actually. Just wanted all the checks to pass before I slept off yesterday. Will be done probably today or tomorrow.

I think the PR is done after this.

The PR should be done after this.

Please review @shawntabrizi @kianenigma

Having an issue:
the trait bound `for<'r> fn(&'r tests::Call) -> bool: std::default::Default` is not satisfied
   --> frame/contracts/src/tests.rs:342:1

/tip large

Wow. Really appreciate the tip! Will round up immediately ❤

@tifecool please merge master

@athei please review

Let's do @bkchr's suggestion in https://github.com/paritytech/substrate/pull/12036#discussion_r962948064 and use $value, not Default.

Ok, let me try.

Are we sure this closes https://github.com/paritytech/substrate/issues/10479 too?

bot merge

Are we sure this closes #10479 too?

It still uses thread local under the hood. So I don't think so.


TOC shows escape backslash

As in the subject line, this is a problem when you gender your stuff in German.

thank you for reporting, that is a bug, I am not sure if I find the time to fix it in version 1 but will be fixed in version 2 for sure

fixed for next release, will be published soon

Awesome, thanks!


Terminal failed to respond and reopen after resizing VSCode

Issue Type: Bug

Open VS Code to the right half of the window
Create a terminal
Resize the window, we can no longer type in the terminal
Hide the panel
Show the panel, it throws error

  ERR Cannot read property 'size' of undefined: TypeError: Cannot read property 'size' of undefined
    at l (file:///C:/Users/penlv/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:448:862)
    at file:///C:/Users/penlv/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:448:440
    at e.fire (file:///C:/Users/penlv/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:81:312)
    at HTMLBodyElement.r (file:///C:/Users/penlv/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:87:1001)

and buffer is broken
C:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\bootstrap-window.js:5 TypeError: Cannot read property '_data' of undefined
    at BufferLine.copyCellsFrom (c:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\BufferLine.js:165)
    at Buffer._reflowSmaller (c:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Buffer.js:242)
    at Buffer._reflow (c:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Buffer.js:170)
    at Buffer.resize (c:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Buffer.js:152)
    at BufferSet.resize (c:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\BufferSet.js:78)
    at Terminal.resize (c:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\Terminal.js:1096)
    at Terminal.resize (c:\Users\penlv\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\node_modules.asar\vscode-xterm\lib\public\Terminal.js:53)
    at D._resize (workbench.main.js:3809)
    at D.layout (workbench.main.js:3808)
    at e.layout (workbench.main.js:3904)
    at Object.layout (workbench.main.js:445)
    at workbench.main.js:453
    at Array.forEach (<anonymous>)
    at t.layoutViews (workbench.main.js:453)
    at t.layout (workbench.main.js:448)
    at e.layout (workbench.main.js:3902)
    at t.layout (workbench.main.js:3908)
    at workbench.main.js:5744
    at Array.forEach (<anonymous>)
    at t.layout (workbench.main.js:5744)
    at o.t.layout (workbench.main.js:5319)
    at o.layout (workbench.main.js:5368)
    at t.layout (workbench.main.js:4938)
    at t.layout (workbench.main.js:5813)
    at t.layout (workbench.main.js:5868)
    at t.onWindowResize (workbench.main.js:5867)
    at workbench.main.js:5867

VS Code version: Code - Insiders 1.31.0-insider (9606490e26f8cbe4d615305389d45e9b144ded7c, 2019-01-30T15:20:25.145Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.92GB (12.49GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (12)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.8.0

gitlens
eam
9.4.1

tsl-problem-matcher
eam
0.0.4

tslint
eg2
1.0.42

vscode-pull-request-github
Git
0.3.2

Angular2
joh
7.0.1

graphql-for-vscode
kum
1.13.0

vscode-typescript-tslint-plugin
ms-
0.4.0

vsliveshare
ms-
0.3.1151

debugger-for-chrome
msj
4.11.1

toggle
reb
0.0.1

vscodeintellicode
Vis
1.1.2

(4 theme extensions excluded)

You were the Jan 30th build here https://github.com/Microsoft/vscode/issues/67439


Speed up proveBottomUp

The bottom-up proof mechanism is quite useful, but slow. I believe it starts here: src/metamath/mm-utils/MM_provers.res.
There will always be limits to it, but I suspect it can be sped up:

Run matches in parallel. This might significantly speed things up, since this is compute bound and (mostly) embarassingly parallel. However, I fear it'd take a non-trivial amount of code to do. Parallel.js might help do this (especially if the loaded database can be passed as a read-only global environment), which builds on the web worker API. Some JavaScript parallel mechanisms requires copies of large data in each thread; that would require a copy of the expanded database in each one; that would use up fast amounts of memory, so only a few threads could be run in parallel. But it looks like there are ways to share read-only data, and I think that's all you need for the big data structures.
Quickly identify & discard things that can't match. IIRC, metamath-exe and mmj2 also do bottom-up searches, and they use some heuristics to quickly identify "can't match" cases before doing a full unification.

Regarding number 2...
Metamath-exe source file mmunif.chas some optimizations to skip impossible unifications. It precomputes some values, and then uses them to skip some options. It says:
  /* Quick scan to reject some impossible unifications: If the
     first symbol in a substitution is a constant, it must match
     the 2nd constant of some earlier $a statement (e.g. "<" matches
     "class <", "Ord (/)" matches "class Ord A").  Same applies to
     last symbol. */
  /* This prefilter is too aggressive when empty substitutions
     are allowed.  Therefore added "g_minSubstLen > 0" to fix miu.mm theorem1
     Proof Assistant failure reported by Josh Purinton. */

Similarly, its file mmpfas.c has some ideas that might be useful:
  /* Speedup:  if first or last tokens in instance and scheme are constants,
     they must match */
  if (firstSymbol) { /* First symbol in mString is a constant */
    if (firstSymbol != stmtMathPtr[0]) {
      if (g_MathToken[stmtMathPtr[0]].tokenType == (char)con_) return 0;
    }
  }

  schemeLen = nmbrLen(stmtMathPtr);

  /* ...Continuation of speedup */
  if (secondSymbol) { /* Second symbol in mString is a constant */
    if (schemeLen > 1) {
      if (secondSymbol != stmtMathPtr[1]) {
        /* Second symbol should be tested only if 1st symbol is a constant */
        if (g_MathToken[stmtMathPtr[0]].tokenType == (char)con_) {
          if (g_MathToken[stmtMathPtr[1]].tokenType == (char)con_)
              return 0;
        }
      }
    }
  }
  if (lastSymbol) { /* Last symbol in mString is a constant */
    if (lastSymbol != stmtMathPtr[schemeLen - 1]) {
      if (g_MathToken[stmtMathPtr[schemeLen - 1]].tokenType ==
         (char)con_) return 0;
    }
  }

  /* Speedup:  make sure all constants in scheme are in instance (i.e.
     mString) */

There's no rush for this, since it clearly works. But I thought I'd record this idea now.

Quick hypothesis: I suspect you can get a small speedup, with little code, by simply checking if there's a constant at the end of the "statement to be unified" & the "statement to be unified to". If they're both constants, but different, you don't need to compute further. I suspect you're unifying left-to-right, and so this sort of mismatch might not be detected until there was a lot of wasted work.

I've added such checking of a constant at the begin and the end of statements. But it doesn't seem to improve performance. Probably because currently implemented unification algorithms is already optimized in this direction (it is not a full left-to-right scan). But such checking looks pretty reasonable, so I added it.


Add MIT License

Type: Missing
Summary:
Add MIT License
Details:
No info package files. Meta data link did not work. Source repo points to MIT.
Resolution:
https://github.com/Azure/azure-cosmos-dotnet-v2/blob/master/LICENSE
Affected definitions:

Microsoft.Azure.DocumentDB 2.11.0

I have opened an issue to get the license link fixed.
https://github.com/Azure/azure-cosmos-dotnet-v2/issues/793

Link has been fixed and now points to MIT. I updated https://github.com/clearlydefined/service/issues/746.


Unable to run gam info org command

The issue tracker is for reporting product deficiencies. How do I questions should be posted to the discussion forum at https://groups.google.com/group/google-apps-manager. When in doubt, start at the discussion forum and return here only when instructed to do so.
Please confirm the following:

[x] I have upgraded to the latest GAM release from http://git.io/gamreleases and I still have this issue.
[X] I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/GAM/wiki
[X] I am using a Google Apps for Work, Unlimited or EDU account (Google Apps Standard / Free is not supported)

Full steps to reproduce the issue:

gam info org employees

Expected outcome (what are you trying to do?):
See information about the org in my gfw account called employees
Actual outcome (what errors or bad behavior do you see instead?):
den:gam dre$ gam info org employees
Traceback (most recent call last):
  File "/Users/dre/gam/gam.py", line 33, in <module>
    import httplib2
  File "/Users/dre/gam/httplib2/__init__.py", line 34, in <module>
    import gzip
  File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/gzip.py", line 10, in <module>
    import io
  File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/io.py", line 51, in <module>
    import _io
ImportError: dlopen(/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib-dynload/_io.so, 2): Symbol not found: __PyCodecInfo_GetIncrementalDecoder
  Referenced from: /usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib-dynload/_io.so
  Expected in: flat namespace
 in /usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versions/2.7/lib/python2.7/lib-dynload/_io.so

I'm sorry, it appears something just broke in my Python install while I was in the middle of running different gam commands.  I'll sort it out.


Add /keys GET endpoint.

This will fix #3.
Signed-off-by: Masaki Muranaka<EMAIL_ADDRESS>

I close this as https://github.com/diamondhands-dev/shiro-backend/issues/3#issuecomment-1280108066


[Feature Request] Support for custom templating for "/describe"

I've been running the "/describe" on a lot of PRs, and the output is excellent. With reviews automatically being created by the PR Agent, this one has been my primary shortcut. One usability issue I'm running into, however, is that the "/describe" replaces the entire PR description section and title.
The "/describe -c" option for posting the description as a comment works as expected, but what I'd really like to do is automate the process of manually filling out Github pull request templates.
For a possible implementation, it seems like trying to automatically map the LLM response to a dynamically configured pull request template would have too many edge cases. Instead, what if there was support for short-code or variable expansion mechanisms such as: pr_agent:describe, and then the AI could substitute the variable with the description?

Yes! I've been thinking about similar things. Many of our repos include a .github/PULL_REQUEST_TEMPLATE.md. I was thinking about experimenting with a separate command/prompt that would pull that template for a repo (if it exists) and attempt to generate a description based on that format.
The short-code expansion is also interesting. This is similar to the "markers" that Copilot for Pull Requests uses.

agreed! this will be great!
for example, we always put a link to the related ticket in the PR description, but the /describe is removing it 😅

I will also add an option to template the title of the PR, again, we always add the related ticket number to the PR title, and the /describe removes it

I spotted a possible problem with the /describe -c feature for the generated PR description. I had some screenshots in my PR descriptions before adding the /describe -c. But it seems to have replaced the screenshots with the generated description. Don't know if that's a bug or if that was intended.
Thanks!

I'm not sure when it was added but I found the "pr_description.add_original_user_description" and "pr_description.keep_original_user_title" PR agent config options and it's helping a lot with this issue.
Example:
/describe --pr_description.add_original_user_description=true --pr_description.keep_original_user_title=true

Github action version (defaulting "add_original_user_description" as true for repo using /describe):
PR_DESCRIPTION.ADD_ORIGINAL_USER_DESCRIPTION: true

Some kind of templating / short-code expansion support would still be useful for more advanced customization but these options are helping a lot already!


Make sure settings.other is defined before accessing .wordcount

I hadn't saved my settings in /settings/strapi-tiptap-editor, meaning that settings.other was null, and therefore it crashed due to trying to read wordcount from null.
Fixes #22

Thanks for the PR, it is now merged. Will push this to npm soon.


Changes for migration on zephyr-v3.3.0-xt branch

Changes, needed for main branch to make it buildable with new zephyr-v3.3.0-xt branch of Zephyr OS.

Acked-by: Leonid Komarianskyi<EMAIL_ADDRESS>

Reviewed-by: Dmytro<EMAIL_ADDRESS>


Potential memory leak with Chem.Atom() constructor

The following bit of code quickly gobbles up all available memory. Maybe I'm missing something but it looks like a memory leak.
from rdkit import Chem

while True:
    atom = Chem.Atom(0)

RDKit version: 2019.03.3.
Platform: Ubuntu (release 18.04)
I'm trying to use this code to create pseudoatoms. Is there perhaps any alternative?

This is an unfortunate by product of wrapping a c++ library.  An Atom is designed to be cleaned up when a molecule is destructed.  The overhead of bookkeeping if an atom is "owned" by a molecule hasn't been implemented in Python since the basic design of RDKit implies that an Atom really should be managed by a molecule.  To do this in python, you'll need to add the atom to a molecule.
>>> from rdkit.Chem import RWMol, Atom
>>> while True:
...   m = RWMol()
...   _ = m.AddAtom(Atom(6))

We probably should have a function:
  atom = m.AddAtom(6)

for quality of life.

Thank you for your swift reply!
The usage example you provided is very similar to what I would like to do: create an Atom and add it to a RWMol. But even when the RWMol is destructed the memory associated with an explicitly constructed Atom doesn't seem to be recovered. For instance, when running the code you provided I run into the same memory issue.
By contrast, when adding an Atom from a different source (e.g. another Mol) this doesn't happen:
from rdkit import Chem

benzene = Chem.MolFromSmiles("c1ccccc1")

while True:
    mol = Chem.RWMol()
    mol.AddAtom(benzene.GetAtomWithIdx(0))

I also tried wrapping the molecule creation in a function and manually deleting the reference to the molecule just to make sure that the refcount drops to 0 and that the Mol is destructed, but I can't seem to free up the memory.

Atoms are definitely leaking.  I'm just unsure of why.  The reason that adding an atom from another molecule is working, is that the other molecule has ownership and deletes the atom.
This is a silly stop gap for now, I'll file it as a bug and investigate it.

Thanks for the follow up.
In the meantime, if anyone else runs into this problem, it seems to be possible to initialize only one ownerless Atom and then use this Atom whenever needed. The downside is that if one needs to use different types of Atoms for each molecule it requires some extra function calls. It isn't very elegant but it gets the job done.
from rdkit import Chem

atom = Chem.Atom(0)

while True:
    mol = Chem.RWMol()
    atom_idx = mol.AddAtom(atom)
    mol.GetAtomWithIdx(atom_idx).SetAtomicNum(6)

@AlanKerstjens
Yeah, that's suboptimal :) Although you could do:
C = Atom(6)
N = Atom(7)

mol.AddAtom(C)

which might be more literal.
I think I'll pass this by Greg:
mol.AddAtom(6)

to avoid creating a leaky atom at all.

I don't think Chem.Atom(6) should be something that leaks. The change to avoid it (#2639) is straightforward.


Feature 49

This PR changes the following:

Adds function imshow_fluxlike_quantities to close issue #49

Looks great! I added a test for it
def test_imshow_fluxlike_quantities():
    s = SimulatedRainbow(signal_to_noise=500).inject_transit()
    for k in "abcde":
        s.fluxlike[k] = np.random.uniform(4, 5, s.shape)
    s.imshow_fluxlike_quantities(maxcol=1, panel_size=(8, 2))
    plt.savefig(os.path.join(test_directory, "imshow-multiples-demonstration.pdf"))

which produces a result like

The first version of this didn't show titles labeled which quantity was which, so I added a titles to each panel (and made a few other superficial changes too).

Thanks so much, @lcmayor ! This is amazing!


python3Packages.time-machine: 2.4.1 -> 2.5.0

Motivation for this change
https://github.com/adamchainz/time-machine/blob/main/HISTORY.rst#250-2021-12-14
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 152990 run on x86_64-linux 1

7 packages built:

home-assistant
python38Packages.aioswitcher
python38Packages.bimmer-connected
python38Packages.time-machine
python39Packages.aioswitcher
python39Packages.bimmer-connected
python39Packages.time-machine


#25 Don't resolve unresolvable configurations

Gradle 3.3+ introduces unresolvable configurations by default
(https://github.com/gradle/gradle/pull/1351). Don't try to resolve these
cnofigurations.
Still being built against 2.x for backwards compatibility, but tested
against 3.4-rc1.

This is great. Thank you. Can we merge this?


Investigate implicit excludes

Today, TypeScript will implicitly set exclude to ./node_modules and something like .*/**/* to avoid dot files.
Unfortunately, there are two problems I believe I've found from chatting with users.
First, users often end up setting exclude which overrides the defaults. This often means that users accidentally over-include files, and that can cause performance issues.
Next, these defaults don't work out well enough, and end up going a bit off the rails in certain scenarios. For example, consider the following .js monorepo.
packages
+- package-aaa
|  +- node_modules    <- the cute tiny 10MB node_modules
|
+- jsconfig.json
+- node_modules        <- the slightly bigger 10GB node_modules
                         shared by each package

Notice that jsconfig.json or not, one of these node_modules is going to be crawled through unless exclude is set appropriately. And regardless of whether exclude is implicitly or explicitly on, it's usually wrong. In this case, it should (probably) be **/node_modules/**/*. For example, check out https://github.com/IBM/report-toolkit/pull/44/files
What I'm suggesting is to harden exclude to always contain the following paths regardless of whether exclude is set.

**/node_modules/**/*
.*/**

To disable this, users will have to turn off a setting like enableImplicitExcludePatterns.

While using the compiler API, I haven't observed that TS adds any implicit excludes over what's mentioned in the tsconfig (which has caused me more than a few surprises, e.g. not automatically excluding dist such that I end up with distception unless I special-case it).  Is this something tsc does itself?

@fatcerberus I'm not totally sure - @rbuckton and @sheetalkamat might know more there.


Add langchain4j+quarkus to clients

Closing as seemingly unrelated.

LangChain4j integrates a MCP client (to be precise, version 0.37.0 will)
See https://github.com/langchain4j/langchain4j/blob/main/docs/docs/tutorials/mcp.md

It's released as 1.0.0-alpha1 after all.
Quarkus is a platform that integrates LangChain4j and adds some stuff on top and is the recommended way to use LangChain4j. If you want, we could adjust the descriptions a bit.


Card with list breaks on mobile

Describe the bug
On the doc, the example on mobile breaks by pricings are out of the card container.
Reproduction
See the doc.
Flowbite version and System Info
Android mobile.

I can't see that. Can you please attache the screen shot?

This is what I see after the patch #358

Also padding is different with ecommerce card.

Should that still be open?

Thanks. Fixed.


Add OpenBazaar v2.0.11

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses:
A maintainers is required to verify both the url and homepage, as they differ.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] sha256 changed but version stayed the same (what is this?).
I’m providing public confirmation below.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Whats the difference between this and openbazaar? Is this just a newer version?

This seems to be a beta version of a new app that will replace openbazaar.
Please submit this to caskroom/versions

Moved to cask-versions: https://github.com/caskroom/homebrew-versions/pull/4498


BIGTOP-3883: add smoke test for openeuler

Description of PR
Add support smoke test:

The docker compose version on openeuler 22.03 should upgrade to 2.6.0.
The bigtop-deploy/provisioner directories's file need to be modified to support openEuler, including jdk.pp, site.pp, params.pp and docker-hadoop.sh etc., add setup-env-openEuler.sh and config_openEuler-22.03.yaml files.

How was this patch tested?
execute the smoke testcase of hadoop, the command:
./docker-hadoop.sh -C config_openeuler-22.03.yaml -c 3 -s
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (BIGTOP-3883)
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

merged, thanks @MacChen01

merged, thanks @MacChen01

Thanks for the code review work you have done and the professional suggestion. @guyuqi


Palindrome linked list

Description
Program will check if the given linked list is palindrome or not.
my approach will be to find the middle of the node by fast and slow pointer (two pointer technique) and then putting all the elements after the middle element into to the stack and then comparing the elements of the linked list with the top element of the stack and then poping that element.
I have submitted the pr of my previous issue #97
Domain
Data Structure
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


wrong wait_for(..) call in browser.should(..)

I found the following in the browser.py:
def should(webdriver_condition, timeout=None, polling=None):
    return wait_for(webdriver_condition, timeout, polling)

I think it should be:
def should(webdriver_condition, timeout=None, polling=None):
    return wait_for(driver(), webdriver_condition, timeout, polling)

At least I found such a call in the wait_to(..) method.

Hm,
should was considered to be an alias for wait_to
so probably the implementation was meant to be:
def should(webdriver_condition, timeout=None, polling=None):
    return wait_to(webdriver_condition, timeout, polling)

can you make a pull request for this? ;)


Ensuring all code examples in Stacks.js > Feature Guides are correct

(Twin issue to https://github.com/hirosystems/docs/issues/519)
For purposes of avoiding duplicate effort, this Issue is to signify that @ryanwaits is working through "Feature Guides" portion of the Stacks.js documentation to ensure code validity, and make any further changes or issues as needed.

adding https://github.com/hirosystems/docs/pull/528 for reference here


Add Mercurial Gauntlet

It isn't currently possible to access Mercurial Gauntlet. Support for this should be added, and progress should be tracked.
It doesn't have to tie into the as-yet nonexistent mission system yet.
Existing data should also be added during the save import process

making some progress on implementing this


Compatability with origins?

It would be really cool if this mod could make Water Protection enchantment from the mod Origins compatible with the other Protection enchantments.

Merge Enchantments v3.1 is compatible with every enchant and with other mods enchants


Switch to https links for extraLibs

Codecov Report

Merging #1488 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1488     +/-   ##
=========================================
- Coverage   61.53%   61.43%   -0.1%
=========================================
  Files         188      188
  Lines        4071     4071
  Branches      949      949
=========================================
- Hits         2505     2501      -4
- Misses       1566     1570      +4

Impacted Files
Coverage Δ

wherehows-web/app/utils/api/datasets/schema.ts
83.33% <0%> (-16.67%)
:arrow_down:

wherehows-web/app/utils/api/datasets/compliance.ts
70.27% <0%> (-8.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b86c0...5fe7d1e. Read the comment docs.

Coverage remained the same at 22.946% when pulling 5fe7d1e5ee4b1ad5e7064dd0b4a2e46a780813de on https-fix-branch into 80b86c0d605c208b22983edce0e49cb5310ef345 on master.


Error: Method not found: 'ImageStreamListener'.

Launching lib/main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...
Resolving dependencies...
Running Gradle task 'assembleDebug'...
Compiler message:
file:///Users/jiumeng/Documents/Flutter/flutter_sdk/.pub-cache/hosted/pub.flutter-io.cn/flustars-0.2.5+1/lib/src/widget_util.dart:86:26: Error: Method not found: 'ImageStreamListener'.
.addListener(new ImageStreamListener(
^^^^^^^^^^^^^^^^^^^
file:///Users/jiumeng/Documents/Flutter/flutter_sdk/.pub-cache/hosted/pub.flutter-io.cn/flustars-0.2.5+1/lib/src/widget_util.dart:86:45: Error: Too many positional arguments: 0 allowed, but 1 found.
Try removing the extra positional arguments.
.addListener(new ImageStreamListener(
^
file:///Users/jiumeng/Documents/Flutter/flutter_sdk/.pub-cache/hosted/pub.flutter-io.cn/flustars-0.2.5+1/lib/src/widget_util.dart:117:26: Error: Method not found: 'ImageStreamListener'.
.addListener(new ImageStreamListener(
^^^^^^^^^^^^^^^^^^^
file:///Users/jiumeng/Documents/Flutter/flutter_sdk/.pub-cache/hosted/pub.flutter-io.cn/flustars-0.2.5+1/lib/src/widget_util.dart:117:45: Error: Too many positional arguments: 0 allowed, but 1 found.
Try removing the extra positional arguments.
.addListener(new ImageStreamListener(
^
Compiler failed on /Users/jiumeng/Documents/Flutter/flutter_wanandroid/lib/main.dart
FAILURE: Build failed with an exception.

Where:
Script '/Users/jiumeng/Documents/Flutter/flutter_sdk/packages/flutter_tools/gradle/flutter.gradle' line: 529

What went wrong:
Execution failed for task ':app:flutterBuildDebug'.

Process 'command '/Users/jiumeng/Documents/Flutter/flutter_sdk/bin/flutter'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 5s
Finished with error: Gradle task assembleDebug failed with exit code 1

Duplicate of #10


Increase timeouts in some tests for travis builds

Thanks for your pull request.  Please review the following guidelines.

[ ] Title includes issue id.
[ ] Description of the change added.
[ ] Commits are squashed.
[ ] Tests added.
[ ] Documentation added/updated.
[ ] Also please review CONTRIBUTING.md.

Still need to fix CircuitBreakerBidiFlowSpec failure


Add check for addEventListener before attaching onStorageChange event

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           69        70    +1
  Branches        15        16    +1
=========================================
+ Hits            69        70    +1

Impacted Files
Coverage Δ

src/common.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a4f77...14fd5b5. Read the comment docs.

@soyguijarro Any chance we can get this merged? Thanks!

@jgornick Thank you for this!
I wonder if we could add a test file with a react native-like test environment, similar to what we already have in place for node (see @jest-environment comment at the top of state.node.test.ts, for example). I'd be happy to accept a PR with that if you feel like investigating it. I'll merge this for now anyway :smile:


Jenkins 3430

As discussed in JENKINS-3430.
I ported the patch attached to that issue to the latest development version pretty much as-is; I took the opportunity to split it into a few smaller commits. Finally, I implemented the additional triggers requested by hanys (cf. JENKINS-5282).
I should stress that I haven't had the chance to test the patch; in particular the implementation of hanys' triggers may require careful review.

Please update to master and resubmit the pull request.

For what it's worth, I'm unlikely to have the time to do this within the next few days.

Half of the functionality in this pull request is now present in https://github.com/jenkinsci/email-ext-plugin/pull/21 anyway.


Update passthrough access logs doc

Purpose
Fixes related to https://github.com/wso2/api-manager/issues/3091

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Naduni Pamudika seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Bug in the tronGrid.account.account.account.getTransactions method

Hello!
I wanted to point out a bug in the tronGrid.account.getTransactions method (or endpoint /v1/accounts/{address}/transactions)
In the response with transaction history for the wallet, the incoming REVERTED internal_transaction comes with "rejected": false
But if you request the transaction history for the wallet from which this transaction (outgoing) occurred - the answer will be "rejected": true (which is correct).
Example:
Transaction -https://nile.tronscan.org/#/transaction/98a7dbe13b5dfc6cec27ed756e6e4c790ee4458cb3a20b1ee30b032311f3b902/internal-transactions
Recipient wallet for internal_transaction - TC4soJtqg5umgebs6UKeZ9XeNJM3FdYyRm
When retrieving the transaction history using the query endpoint: https://nile.trongrid.io/v1/accounts/TC4soJtqg5umgebs6UKeZ9XeNJM3FdYyRm/transactions.
In the response, I get:
{
            "internal_tx_id": "9cab089ab589c520f817f46d50444b8ea0e362efc21c73e1f75e5be425f691df",
            {
              "data": {
                {
                  "note": {
                     "call",
                     "rejected": false, // which is not true
                },
                "call_value": {
                    "_": 1
                }
            },
            "block_timestamp":<PHONE_NUMBER>000,
            },
            "to_address": "411702b7c3cb32c95d134754b8db39585d1113d90d",
            "tx_id": "98a7dbe13b5dfc6cec27ed756e6e4c790ee4458cb3a20b1ee30b032311f3b902",
            "from_address": "41730407093e6927dd1a0a4b90735244b46ae07780"
}

Wallet sender for internal_transaction - TRURXG7kZ1WfDxptA5pUgGt3g2SYFwLze9
When retrieving the transaction history by querying endpoint: https://nile.trongrid.io/v1/accounts/TRURXG7kZ1WfDxptA5pUgGt3g2SYFwLze9/transactions
In the response, I get:
{
           "internal_tx_id": "9cab089ab589c520f817f46d50444b8ea0e362efc21c73e1f75e5be425f691df",
            {
              "data": {
                 {
                   "note": "63616c6c",
                   "rejected": true, // which corresponds to validity
                 },
                 "call_value": {
                    "_": 1
                 }
              },
            },
            "to_address": "411702b7c3cb32c95d134754b8db39585d1113d90d",
            "from_address": "41730407093e6927dd1a0a4b90735244b46ae07780"
},

Same issue, any updates?


First-order approximation of reachable set

This PR adds the functions to compute a first-order over-approximation of the reachable set. It also contains some related tests (further tests would be welcome though). Application to the path-planning problem remains to be done. See https://drive.google.com/drive/folders/1Czz9RnDp8r8DRRJHIMOt3jvGIMwLpsem for the mathematical justification of the approach.

J'ai ajouté l'exemple example_pathplanninglinearized. Il y a bcp d'allocations pour le moment, je dois voir comment fixer cela. Si tu as des idées, n'hésite pas ;-)

I fixed most of the allocation problems (also in the previous compute_symmodel_from_controlsystem!): here are the new benchmarks:
Simple:
->"growth":
compute_symmodel_from_controlsystem! started
13081981 transitions created
  3.688377 seconds (142 allocations: 356.183 MiB, 1.22% gc time)
compute_controller_reach! started
compute_controller_reach! terminated with success
  1.919806 seconds (98 allocations: 164.054 MiB)

->"linearized":
compute_symmodel_from_controlsystem! started
10619803 transitions created
  5.457309 seconds (338 allocations: 356.187 MiB, 0.85% gc time)
compute_controller_reach! started
compute_controller_reach! terminated with success
  1.537087 seconds (98 allocations: 135.876 MiB, 0.90% gc time)

Hard:
->"growth":
compute_symmodel_from_controlsystem! started
23784452 transitions created
  8.348577 seconds (144 allocations: 681.539 MiB, 0.57% gc time)
compute_controller_reach! started
compute_controller_reach! terminated with success
  3.643554 seconds (99 allocations: 301.117 MiB)

->"linearized":
compute_symmodel_from_controlsystem! started
20082942 transitions created
 12.199161 seconds (340 allocations: 518.865 MiB, 0.38% gc time)
compute_controller_reach! started
compute_controller_reach! terminated with success
  3.044619 seconds (100 allocations: 258.757 MiB, 0.70% gc time)

Forgot to submit the reviews, they may be a bit outdated


Is there a description of gfx-hal differences from Vulkan?

People keep asking what exactly the differences between gfx-hal and Vulkan are.  Is there an authoritative list somewhere I can refer to?  Beyond simple rust-ification such as turning pointers into iterators and so on, is there a set of features that are added/unsupported, minor differences in how things are structured, etc?
Thanks in advance.
Short info header:

GFX version: 0.3
OS: n/a
GPU: n/a

If only that was described somewhere, right?
https://github.com/gfx-rs/gfx/wiki/Deviations-from-Vulkan
😃

Awesome, thanks! Now I know!


Disable editor.acceptSuggestionOnCommitCharacter by default

In JavaScript when typing:
run(

I end up with:
return()

Because return is the first suggestion and ( is considered a commit character. This happens any time I call a function that is not imported yet (it will grab the first suggestion which is never good).
This happens very very often. Over the last two months I came across this pattern a lot (which becomes very annoying) because I'm calling a function before actually importing it (I want to stay in the flow of what I want to write and I fix the imports afterwards).
The alternative would be to remove ( from the list of commit characters.

Is there any use case at all where it would be better for the text editor to automatically guess and automatically type the coder's intention, rather than the coder manually pressing one TAB key?


Is "fmtp:102 profile-level-id=4D0029" supported?

Hi
It's seems that it cannot understand something like this:
Media Description, name and address (m): video 6200 RTP/AVP 102
Media Type: video
Media Port: 6200
Media Protocol: RTP/AVP
Media Format: DynamicRTP-Type-102
Media Attribute (a): rtpmap:102 H264/90000
Media Attribute Fieldname: rtpmap
Media Format: 102
MIME Type: H264
Sample Rate: 90000
Media Attribute (a): fmtp:102 profile-level-id=4D0029; packetization-mode=1
Media Attribute Fieldname: fmtp
Media Format: 102 [H264]
Media format specific parameters: profile-level-id=4D0029
Profile: 4d0029
0100 1101 = Profile_idc: Main profile (77)
0... .... = Constraint_set0_flag: 0
.0.. .... = Constraint_set1_flag: 0
..0. .... = Constraint_set2_flag: 0
...0 .... = Constraint_set3_flag: 0
.... 0000 = Reserved_zero_4bits: 0
0010 1001 = Level_id: 41 [Level 4.1 50 Mb/s]
Media format specific parameters: packetization-mode=1
[Packetization mode: Non-interleaved mode (1)]
Media Attribute (a): ex_fmtp:102 2CIF=1
Media Attribute Fieldname: ex_fmtp
Media Attribute Value: 102 2CIF=1
Has anybody experienced troubles of this kind?
Thanks in advance

Hi,
Now we only support Constrained Baseline Profile (profile_idc 66), the Main profile (profile_idc 77) has not been supported.


Liuboff/History of search queries and ability to delete previous search result

It was implemented the Business Rules:

The system allows the user to enter a maximum of 64 characters. If the allowed characters in the search bar are exceeded, the system stops entering characters further.
The history of old queries should be stored in the list of old queries under the search bar from newest to oldest. The maximum number of queries in the list is 10 queries. The user should be able to delete a query/s by clicking the cross on the right side of the old query.

The next part of task is to investigate and perform the Bonus AC:

Search without spelling errors: the system should offer correct results even if there are spelling errors in the query (for example, "drwin" should display results for "drawing").
Query autocomplete: when entering a query, the system offers autocomplete options that help the user find the correct terms or the most popular search queries.

Coverage - 100%
Reliability - Isn't possible to properly use and implement a 'onKeyPress|onKeyDown|onKeyUp' attribute to .
(I've tried to reproduce this in application without success.
When I press Tab, the focus moves from the previous search result to the next search result.
Accordingly, the close button cannot be handled by pressing the keyboard keys.
So I decided not to implement it.)


Investigate algorithm for selection which coins to send

It occurs to me that a wallet holder typically wants to send their newest coins when they spend them. This is so that they keep their older coins and can continue to use them to mint.
This may be the algorithm that is used now, but it should be confirmed.
If it is not the algorithm, we should change it to work that way.

Okay, I had a look and see that the coins selected are random:
bool CWallet::SelectCoinsMinConf(int64 nTargetValue, unsigned int nSpendTime, int nConfMine, int nConfTheirs, vector<COutput> vCoins, set<pair<const CWalletTx*,unsigned int> >& setCoinsRet, int64& nValueRet) const
{
    setCoinsRet.clear();
    nValueRet = 0;

    // List of values less than target
    pair<int64, pair<const CWalletTx*,unsigned int> > coinLowestLarger;
    coinLowestLarger.first = std::numeric_limits<int64>::max();
    coinLowestLarger.second.first = NULL;
    vector<pair<int64, pair<const CWalletTx*,unsigned int> > > vValue;
    int64 nTotalLower = 0;

    random_shuffle(vCoins.begin(), vCoins.end(), GetRandInt);

    BOOST_FOREACH(COutput output, vCoins)
    {
        const CWalletTx *pcoin = output.tx;

This may have been done in order to maximize privacy, or maybe it was just done without much deeper thought.
I propose an method that works like this:

Separate all coins that can be minted from all coins that cannot
Sort the coins that cannot be minted by how long until they can be minted, and try to get the send amount by adding one at a time
If we do not have enough yet, then randomize the coins that can be minted, and add from them until the needed amount is reached

This will mean that we prefer to send the newest coins, since they are worth the least to us (they will take the longest before they can be minted). If we want to send more coins than we can with coins that cannot be minted, then it does not matter and we can choose at random from the remaining coins.
I would like some discussion about this proposed algorithm before implementing it.

Since coins mint pro-rated amounts until they are 40 days old, it probably just makes sense to simply sort the coins and spend the newest coins first.


Enable builds for Python 3.13

Thx for your contribution, just two missing spot
$ git grep -in "\b312\b"
tools/docker/Makefile:209:PYTHON_VERSIONS := 38 39 310 311 312
tools/docker/python/build-manylinux.sh:38:\t* PYTHON_VERSION: 3 38 39 310 311 312

Thx for your contribution, just two missing spots
$ git grep -in "\b312\b"
tools/docker/Makefile:209:PYTHON_VERSIONS := 38 39 310 311 312
tools/docker/python/build-manylinux.sh:38:\t* PYTHON_VERSION: 3 38 39 310 311 312

added


Redirect while the modal form is opened

Describe the bug

To Reproduce

In Homepage clicking on "Ricevi aggiornamenti" modal form will be shown correctly but at same time a redirect to /updates is happening that result in a 404 page.
Expected behavior

Screenshots

https://user-images.githubusercontent.com/11008116/140419929-d382ea20-fbe3-496e-95b3-a541ceae9714.mov

closed by #112


ScrollView>Scrollable>RawGestureDetecor>behavior can't modify

  Widget result = _ScrollableScope(
      scrollable: this,
      position: position,
      // TODO(ianh): Having all these global keys is sad.
      child: Listener(
        onPointerSignal: _receivedPointerSignal,
        child: RawGestureDetector(
          key: _gestureDetectorKey,
          gestures: _gestureRecognizers,
          **behavior: HitTestBehavior.opaque,**
          excludeFromSemantics: widget.excludeFromSemantics,
          child: Semantics(
            explicitChildNodes: !widget.excludeFromSemantics,
            child: IgnorePointer(
              key: _ignorePointerKey,
              ignoring: _shouldIgnorePointer,
              ignoringSemantics: false,
              child: widget.viewportBuilder(context, position),
            ),
          ),
        ),
      ),
    );

I need to modify it  > HitTestBehavior.translucent

@JDongKhan
Can you provide flutter doctor -v and elaborate on what exactly are you trying to achieve along with expected vs actual behavior ?
Thanks.

@darshankawar  [✓] Flutter (Channel unknown, 2.0.6, on macOS 12.0 21A5248p darwin-x64, locale zh-Hans-CN)
• Flutter version 2.0.6 at /Users/jd/Documents/sdk/flutter/flutter
• Framework revision 1d9032c7e1 (4 个月前), 2021-04-29 17:37:58 -0700
• Engine revision 05e680e202
• Dart version 2.12.3
• Pub download mirror https://pub.flutter-io.cn
• Flutter download mirror https://storage.flutter-io.cn

我有一个地图在scrollview下面

I have a map under the Scrollview，so hope the map can handle gestures in a transparent place

Please provide a complete minimal reproducible code sample that we can directly use to verify the issue.
Thanks.

@darshankawar   https://github.com/JDongKhan/flutter_demo.  onPanUpdate can't print log.

@darshankawar https://github.com/JDongKhan/flutter_demo.
onPanUpdate can't print log.

tks.

@JDongKhan
Check if this open issue is similar to yours.

It seems different，My problem is  the scroll widget handle gesture  in a transparent place。
I need to set behavior:HitTestBehavior.deferToChild for ScrollView instead of HitTestBehavior.opaque.

@JDongKhan
Does it not work if you use behavior:HitTestBehavior.deferToChild ?
In which case would you need to use HitTestBehavior.opaque and not behavior:HitTestBehavior.deferToChild ?

um...
It looks a little problem.

@JDongKhan
So If I understand correctly, using behavior:HitTestBehavior.deferToChild it doesn't work properly when you try to slide fast ?
And works as expected if you use HitTestBehavior.opaque ?

I cloned your repo and ran it on simulator and played around with scrollview screen, so not sure what exactly is the issue being faced here ?
https://user-images.githubusercontent.com/67046386/131640560-3ed7ef54-0585-4a20-920b-b9ab619cb1d9.mov

I hope the map widget to handle  gestures in a transparent place of ScrollView.
 ///map, but onPanUpdate can't print log
  Widget _buildMapWidget() {
    return GestureDetector(
      onPanUpdate: (detail) {
        print('detail:$detail');
      },
      child: Container(
        height: double.infinity,
        width: double.infinity,
        alignment: Alignment(0, -0.3),
        child: Text(
          'Map',
          style: TextStyle(color: Colors.blue),
        ),
        color: Colors.white,
      ),
    );
  }

So if I scroll up the menu content up, it'll go on top of the map placeholder and you are looking to capture taps on the map which is now hidden behind the scrollview ?

yes


Custom staging dir functionality migration

Changelog Description
The functionality of the staging directory has exceeded its original purpose of publishing. Considering its increased usage in the creation process, we need to migrate it to a dedicated module within the pipeline parent.
resolve https://github.com/ynput/ayon-nuke/issues/21
Additional info
Migrated development from https://github.com/ynput/OpenPype/pull/5207

adding functionality to Creator base class
consistency of naming across all features
making sure backward compatibility to older names and locations remain in settings and api
anatomy templates with Staging Dir category
Support {version} in template regex when Follow workfile version is enabled

Testing notes:

all should be working as it was before

Been testing in nuke with this branch.
I am struck at setting up custom staging directory, I adjust the settings for the custom staging like below

But I got the error below.

Otherwise, if I set no custom staging directory, the local pre-render or workfile published successfully. The screenshot below is for publishing pre-render.

@moonyuet I'm sorry I cannot reproduce your error locally.
It looks like the "Custom Staging Dir" entry is properly recognized out of the project settings but the additional anatomy entry is not. Your screenshots looks all-right to me, and I have tried different things but cannot find the issue.
Out of curiosity, could you please run the following code from within Nuke and check out the result ?
from ayon_core.pipeline import Anatomy, get_current_project_name

anatomy = Anatomy(get_current_project_name())
anatomy.get_template_item("staging", "nuke_staging")

@moonyuet I'm sorry I cannot reproduce your error locally. It looks like the "Custom Staging Dir" entry is properly recognized out of the project settings but the additional anatomy entry is not. Your screenshots looks all-right to me, and I have tried different things but cannot find the issue.
Out of curiosity, could you please run the following code from within Nuke and check out the result ?
from ayon_core.pipeline import Anatomy, get_current_project_name

anatomy = Anatomy(get_current_project_name())
anatomy.get_template_item("staging", "nuke_staging")

My bad, looks like this error happened mainly because my ayon server isn't at the latest.
I will approve right away.

All my comments were marked as resolved without any changes...

Thanks @moonyuet and @iLLiCiTiT  for the approvals, all remaining comments have been addressed.
I'm waiting for further testing and approval on this one https://github.com/ynput/ayon-nuke/pull/19 to merge it.

I'm waiting for further testing and approval on this one https://github.com/ynput/ayon-nuke/pull/19 to merge it.

I guess that is dependent on this PR, so we may merge this now, or?


dynamic biosphere builder adds dynamic_biomatrix entries multiple times if time-mapped producer is multiple times in the timeline

it would the same entries twice with DynamicBiosphereBuilder.add_matrix_entry_for_biosphere_flows() twice and dynamic_biomatrix = sp.coo_matrix((self.values, (self.rows, self.cols)), shape) would add up the amounts for these row-col pairs:

This is not a problem as soon as the time-mapped producer is occurring at a different time, because it gets it's own column then.

#67 not quite the same but related issue.


SLU16 - Learning Curve

sklearn version installed in the environment seems to be different changed from the evaluators' one.
sklearn version in environment is 0.21.2, which outputs a warning if no cv is selected in learning_curve function. Default for this version is cv=3 which does not pass the asserts. Changing to cv= 5 solves that problem.

Later in the exercise, the plot for the learning curves seem to indicate that the value for min_train_set_size should be around 430. However, the value expected in the asserts is much lower than that.
This can again suggest that the versions of sklearn used by the evaluators were different from the ones that we have installed in the environment (....or that I'm doing something wrong ;) ).

The grader also creates an environment using the environment.yml so it's improbable that it has a different version.
Let's se what @hershaw has to say and we'll revisit that hypothesis later.

I'm not hearing about anyone else having this issue. Did you get it worked out @n-loureiro?

Closing this issue as it is now over 1.5 years old. Feel free to reopen it.


Add 'show tables' to autocomplete for Flink

Best is probably to start with a simple SHOW TABLES|VIEWS|DATABASES, similarly to 'sql_show' in https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/ksql and add it to the generic https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/generic
Then import it in the structure.json. That way it would kickstart a basic reusable SHOW grammar, and then we can see for the dialect/Calcite specific as we go deeper.

Flink 'SHOW' statement https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/sql/show.html
ksql example https://github.com/cloudera/hue/commit/04ab447238e63ce5ee736e4fc0b2aba013a7c3f3#diff-f0a0b26331f281bf8942ef9ce306371934fc02988fdad643f73c94a1aac7b39b
Dask SQL https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/js/parse/jison/sql/dasksql/show/show.jison

Best is probably to start with a simple SHOW TABLES|VIEWS|DATABASES, similarly to 'sql_show' in https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/ksql and add it to the generic https://github.com/cloudera/hue/tree/master/desktop/core/src/desktop/js/parse/jison/sql/generic
Then import it in the structure.json. That way it would kickstart a basic reusable SHOW grammar, and then we can see for the dialect/Calcite specific as we go deeper.

Flink 'SHOW' statement https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/sql/show.html
ksql example https://github.com/cloudera/hue/commit/04ab447238e63ce5ee736e4fc0b2aba013a7c3f3#diff-f0a0b26331f281bf8942ef9ce306371934fc02988fdad643f73c94a1aac7b39b
Dask SQL https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/js/parse/jison/sql/dasksql/show/show.jison

docker-compose to easily boot a Flink DB https://gethue.com/blog/tutorial-query-live-data-stream-with-flink-sql/

docker-compose to easily boot a Flink DB https://gethue.com/blog/tutorial-query-live-data-stream-with-flink-sql/

@romainr  assigning this to myself.

@romainr  assigning this to myself.


Corrupt serialized resolution result fix

Another dependency resolution bug fixed.
When we restart an edge due to capability conflict or module version selection change, we may encounter an edge where the source node is not selected.
Previously, we would skip restarting (retargeting) this node in that case, but it may be possible that the source node re-enters the graph. In this case, Gradle expects the node and its children to still be vaild subgraphs, unless it otherwise deconstructed that subgraph.
So, we update the edge-restart code to maintain the state of these detached subgraphs when edges are re-targeted.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test rfr

I've triggered the following builds:

Ready for Release (Trigger) (Check)

Build Scan

The following builds have failed:

Ready for Release (Trigger) (Check)

Build Scan

@bot-gradle test rfr

I've triggered the following builds:

Ready for Release (Trigger) (Check)

Build Scan

The following builds have failed:

Ready for Release (Trigger) (Check)

Build Scan

@bot-gradle test RfR

I've triggered the following builds:

Ready for Release (Trigger) (Check)

Build Scan

The following builds have passed:

Ready for Release (Trigger) (Check)

Build Scan


Missing License

Can you please add licenses to your NPM packages?
Our CI is failing because your packages are unlicensed as in Angular CLI we do not allow un-licensed packages to be consumed.

I am happy to open PRs if you let me know which license you’d like to use.
PS: I also, tried to reach out via twitter: https://x.com/alanagius4/status/1785922108909813824?s=46&t=knjEp6bF9s747yZwI_PLmw

done

Thanks for this @streamich, when should we expect a release of these packages with the fix? Thanks.


MovieClip frame bug

var frames = [];
for (var i = 0; i < 30; i++) {
  frames.push(PIXI.Texture.fromFrame(i + '.jpg'));
}
movie = new PIXI.extras.MovieClip(frames);
movie.animationSpeed = 0.5;
movie.play();

All on android device & same codes.

Please describe the problem.
We have no idea what the movieclip should look like, so these screenshots don't really add much at the moment.

closing as this is a little vague! 👍


Row select delayed after scrolling when using virtual scrolling

**I'm submitting a ...
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
I have a table with 40 rows using virtual scrolling and paging client side. I click a row and it becomes selected. Then I scroll to the bottom of the table and back up to the top 5 consecutive times. Now when I click a row it becomes selected, but only after more than 1 second. This delay is a problem, because we use that selection to control other components.
Expected behavior
Instantly select the clicked row without delay, also after any amount of scrolling.
What is the motivation / use case for changing the behavior?
We want to be able to quickly select a row and execute some other action based on that instantly after.
Please tell us about your environment:
Windows 7 Enterprise, Visual Studio Code

Table version:
11.1.7

Angular version:
5.0.5
CLI 1.7.4

Browser:
Chrome 65.0.3325.181

Language:
TypeScript 2.4.2

I'm having the same issue. Any work around?

Found a workaround using the zone:
    public onSelect(event: any): void {
        // "Zone" needed to fix ndx-datatable slow selection after scrolling
        this._zone.run(() => {
            this.selectionChanged.emit(event);
        });
    }

Found resolution in issue #1264 by downgrading to version 11.0.4 .

Have the same problem.

Below workaround worked for me in version 11.0.4. A mouse click on anywhere in screen solves the problem. So you can click to container div or directly on table.
document.getElementById().click();

We are facing the same issue, using virtual scrolling. It seems to me like the events that are attached on each row don't get cleaned up when the element gets removed and reattached to the DOM? It will get worse over time. The above hints don't help us in fixing the problem unfortunately.
This makes virtual scrolling a neat feature, but practically unusable.


Add endpoint information to the README

📚 Context
The node exposes several endpoints, but our documentation does not mention which they are, potentially confusing users.
✔ Solution
Modify the README file to include information about the node's endpoints: /graphql, /inspect, /healthz, /rollup, '/metrics'.

All endpoints are defined in this file.


GUI improvement: filter torrent list

Input field in upper-right corner with ability to filter torrent list. Keyboard shortcut to focus on the field.

There's now a filter function available in 0.17


[GLUTEN-4917][CI][VL] adding basic Velox unit tests

What changes were proposed in this pull request?
Adding basic Velox unit tests
How was this patch tested?
pass GHA

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_5501_time.csv
log/native_master_04_25_2024_8ade7a9cb_time.csv
difference
percentage

q1
38.41
36.23
-2.173
94.34%

q2
23.70
23.67
-0.025
99.89%

q3
37.75
39.09
1.340
103.55%

q4
37.08
37.31
0.229
100.62%

q5
71.40
69.05
-2.345
96.72%

q6
7.48
5.64
-1.834
75.47%

q7
86.10
84.14
-1.966
97.72%

q8
86.32
85.57
-0.754
99.13%

q9
120.15
123.29
3.139
102.61%

q10
45.37
46.88
1.506
103.32%

q11
20.49
20.38
-0.115
99.44%

q12
26.73
28.18
1.456
105.45%

q13
54.83
55.46
0.631
101.15%

q14
20.63
17.25
-3.383
83.60%

q15
30.08
31.27
1.193
103.97%

q16
13.85
13.89
0.041
100.29%

q17
104.91
104.73
-0.176
99.83%

q18
145.42
145.71
0.299
100.21%

q19
14.86
13.71
-1.152
92.25%

q20
28.82
27.47
-1.355
95.30%

q21
293.26
286.10
-7.163
97.56%

q22
15.92
14.41
-1.507
90.53%

total
1323.56
1309.44
-14.115
98.93%


apache-airflow==1.10.9 incompatible with sqlalchemy==1.3.16

Changing common.setup.sh to install apache-airflow==1.10.10 or pinning sqlalchemy to 1.3.15 solves the issue.

Geez, breaking change on a minor version. Thanks for reporting, will try to upgrade to 1.10.10.


endingShape / Stroke bar chart

Round end on bar chart
Hi my code for bar chart is.
let option = {
chart: {
type: 'bar',
width: 200,
height: 150,
sparkline: {
enabled: true
}
},
plotOptions: {
bar: {
columnWidth: '40%',
endingShape: 'rounded',
dataLabels: {
position: 'top',
}
}
},
series: series,
labels: labels,
dataLabels: {
enabled: true,
offsetY: -15,
style: {
fontSize: '8px',
fontWeight: 'bold',
fontFamily: 'sans-serif',
colors: ['#000']
},
dropShadow: {
enabled: false,
top: 1,
left: 0,
blur: 1,
opacity: 0.45
}
},
stroke: {
show: true,
width: 1,
colors: ['transparent']
},
xaxis: {
crosshairs: {
width: 1
},
},
tooltip: {
fixed: {
enabled: false
},
x: {
show: false
},
y: {
title: {
formatter: function (seriesName) {
return ''
}
}
},
marker: {
show: false
}
}
}
Explanation

I would like a bar with rounded border on end
But with the current version, it doesn't work, if I try with this version https://cdnjs.cloudflare.com/ajax/libs/apexcharts/1.4.6/apexcharts.min.js" it works fine!

The endingShape property has been deprecated, and soon a new property borderRadius will be implemented.

so with version 3.6.3 I can't get bar rounded?.
Now I'm trying the 3.0.0 version and it works!

It was removed recently in 3.6.0.
You may use 3.0.0 until borderRadius is released

Closing as related to #414

any update on borderRadius?

+1

Btw, I went to recharts.  I can define my own shape.  Wanted to share in case anyone else was looking for alternatives.

@rileylnapier how?

The endingShape property has been added again.

Any updates on the release of 'borderRadius'?

Released v.3.17.0
A new property plotOptions.bar.startingShape added.
So, using plotOptions.bar.startingShape & plotOptions.bar.endingShape, you can have the desired effect of rounded borders in bar/column charts.
plotOptions: {
  bar: {
    startingShape: 'rounded',
    endingShape: 'rounded'
  }
}

Codepen

@junedchhipa Just wondering, was the idea of a border-radius property scrapped? I have been looking for a way to make the corners only slightly rounded.

This rounded shape is a little bit "abnormal" - it´s possible to be really rounded instead a "sausage" bars ?

Decreasing the height of the bars (in case of a horizontal bar chart) would provide some improvements in the rounded.
plotOptions: {
  bar: {
    barHeight: '30%'
  }
}

while in case a vertical column chart,
plotOptions: {
  bar: {
    columnWidth: '30%'
  }
}

Thanks @junedchhipa :

I´m using 30% for barHeight - less than that the legend inside the bars will be unreadable.

In that case, there is no other alternative, sorry.
The rounded shape is drawn with path instead of rect, so it's difficult to get that natural border-radius.

Ok, no problem !!!
Thanks for your support, the ApexCharts is amazing, this is a minimal detail guys!
Cheers,

Is this working also with pie charts?


Normalize internal spelling of metadata

This PR focuses on internal types of dependency-management but also applies the normalization to docs, comments and strings everywhere.

@bigdaz, could you take a look at this one, please?

@bamboo You might want to see if someone else can help get this merged. The changes don't look contentious to me. We'll just need to be aware of the impact on existing clones on case-insensitive filesystems, if any.

FTR I've merged this branch locally on two different case-insensitive file systems on two different operating systems (osx and windows) and there was no issue.

In that case, I would recommend merging. We don't use pre-commit review for other work, and this seems a fairly straightforward change, if pervasive.

@bamboo is this merged already? If yes, can we close it so it doesn't clutter the backlog?

Sure thing!


Allow ḅ to work on strings.

When I tried my hand at http://codegolf.stackexchange.com/questions/90711/what-base-is-this-number-in, I thought Ṁḅ26 should work, but it doesn't because e.g. "11"ḅ2 evaluates to nothing (1,1ḅ2 evaluates to 3).
Would it be reasonable to extend ḅ to convert string representations as well? Is there an atom that does something similar that I've missed?

@ruds I don't think that's applicable at all for bases over 250, but, for [2, 250], it would have surely been handy.


Fix issue #208: parse the correct scheme of URL in Python26

If python version is 2.6 or older, check if scheme is one of “http" or "https".

Thanks!


Alt + RMB lets you list select in any tool mode in 3D

Tested versions
v4.2.1.stable.mono.official [b09f793f5]
v4.3.dev.custom_build [677bd9783]
System information
Windows 10.0.22631 - Vulkan (Forward+) - integrated AMD Radeon(TM) Graphics (Advanced Micro Devices, Inc.; 31.0.23013.1023) - AMD Ryzen 7 PRO 6850U with Radeon Graphics (16 Threads)
Issue description
This is either a bug or needs a description for all the tools.

Steps to reproduce
Select any tool that isn't the 'Select Tool' and ALT + RMB on a position with multiple nodes.
Minimal reproduction project (MRP)
N/A

This seems to be by design, and very old, it allows any modes except transform:
https://github.com/godotengine/godot/blob/f427d2f0d35f27273e856871f8588652632d8ac2/editor/plugins/node_3d_editor_plugin.cpp#L1662-L1671

I couldn't find it documented anywhere (besides the code being it is what it is). It also doesn't match 2D behavior or what the tooltips say.

Hmm, after playing around with it just now I actually agree. Personally, I think you should always be always to select other things such as in the draft I made that I linked above, but that's a different topic.


Upgrade jwt_authorizer to axum 0.7

This is some work done to update jwt_authorizer to axum 0.7. In the process, the ReqBody generic was removed in several places, as axum::extract::Request now has a default associated type.

Thx for the PR, tonic (feature) is not compiling, I think the update of tonic to  hyper 1.0 is needed.
Waiting for hyperium/tonic#1579

Thanks! The other thing is that you will notice your test minutes have mysteriously vanished... in oidc.rs line 27 calls discovery_url(issuer)?, which actually results in
Ok(Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Ipv4(<IP_ADDRESS>)), port: Some(44281), path: "/.well-known/openid-configuration", query: None, fragment: None }). This leads to a hang when calling send() on client. I thought that this was part of the ci, but I guess it isn't...

It appears that tonic has been upgraded. I'll see about upgrading this feature

It seems like the upgrade in tonic is slow progress...https://github.com/hyperium/hyper/issues/3461 is blocking https://github.com/hyperium/tonic/issues/1579, which can't occur until the next version of hyper is released. Wondering if you would consider feature gating the axum version based on use of tonic, or is that a horrible idea?

I am not sure to understand  what you mean by feature gating (tonic is already behind a feature switch).
I tried to move the tonic dependent code into a separate crate but I am blocked by the fact that From cannot be implemented for types from another crates. (impl From<AuthError> for Response<tonic::body::BoxBody> {...}).

My mistake! What I meant to say is you could make the version of axum dependent on whether the tonic feature is enabled. You've made more sense of the situation than me. If you choose to make a separate crate for tonic, then that would basically mean you'd have to ctrl+c/ctrl+v large swathes of the implementation, including AuthError. The alternative (and what I meant) is to set axum = 0.6.20, etc. when the tonic feature is enabled. However, that solution basically would result in the same costs you've described, just in the same crate.
Alternatively, could just wait another month or so hahaha...I'll do what I can to get tonic to http 1 in the meantime.


Tag the source

Could you please tag the source? This allows distributions to get the complete source from GitHub if they want. Instead of working with commits to track the changes.
Thanks

Indeed, you're correct. It's a priority on my roadmap.


HMC5883L Driver

Hello,
I have a library written about 2 years ago. It's in my profile HMC5883L. Now I add it on my local repo and forked repo for AndroidThings. I want to merge it. If it is ok, I will create pull request.
Thank you.
Good work.

Hi @cagdasc, we are happy to take contributions for new features or bug fixes on our existing drivers. For new drivers we generally suggest to host it on your own repo since it is entirely your work, so there is no need for a pull request. As was mentioned in #1, we do have future plans for indexing the various Android Things drivers to help aid discoverability. Thanks for your work :)


Clear or terminated from task manager issue

I have purchased plugin. When I cleared or terminated from the task manger so background location plugin not get a location in vivo or mi phones and background service are also closed.  But in Samsung mobile it is working proper.

Wrong repo.  See the README


User accounts

If as mentioned in #29 we plan to have user owned cards, we need to establish user accounts.
Integrate the following options:

[ ] No account (demo)
[ ] Email / Password
[ ] Google Authentication

User accounts will be handled in subsequent version of this app.


shaderObject: Fix object name crash

Closes #403

CI Vulkan-ExtensionLayer build queued with queue ID 249625.

CI Vulkan-ExtensionLayer build # 955 running.

CI Vulkan-ExtensionLayer build # 955 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 249644.

CI Vulkan-ExtensionLayer build # 956 running.

CI Vulkan-ExtensionLayer build # 956 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 249678.

CI Vulkan-ExtensionLayer build # 957 running.

CI Vulkan-ExtensionLayer build # 957 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 249914.

CI Vulkan-ExtensionLayer build # 958 running.

CI Vulkan-ExtensionLayer build # 958 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 249929.

CI Vulkan-ExtensionLayer build # 959 running.

CI Vulkan-ExtensionLayer build # 959 passed.


[5.0] Improve the middleware generated by make:middleware.

Just a quick addition to the middleware stub with return $next($request); as this line is (and will be) present in most middlewares.

Wrong branch. Please send to 5.0.


Hardcode in AttentionBlock

Hi! Thanks for this fantastic work!
I am little confused about the forward function of AttentionBlock in unet.py.
The corresponding codes are shown as blew:
 def forward(self, x):
        return checkpoint(self._forward, (x,), self.parameters(), True)

I just wonder why we should hardcode the flag parameter to True instead of usingself.use_checkpoints?
Thanks!

I think it is because this is a pixel-wise self attention implementation, which considered one pixel as a token. This implementation will be extremely memory comsuming when input resolution is relatively high (e.g. 256^2).


Use Pathname instead of File

patch#new_file_full_path returns Pathname instances which are sufficient
and possibly preferred for Flay.
This also makes reading errors much more readable.
Before:
#<File:0x00000009279170>:4 :: parse error on value ":" (tCOLON)
skipping #<File:0x00000007d3cff0>
After:
/home/..{OMITED}../credit_cards_controller_spec.rb:4 :: parse error on value ":" (tCOLON)
skipping /home/..{OMITED}../credit_cards_controller_spec.rb
Fixes rolled into single commit.

@redross I've added an integration spec to master, could you rebase? :smile:

Done :)


Switch to downstream names in templates

Downstream templates should be using downstream
projects names in order to functional properly.

Thanks!


[Feature]: Enable Image editor in file picker widget

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Enable Image editor in file picker widget using the uppy's image editor which is already implemented in the User Profile Image.
Why should this be worked on?
Enabling Image editor in file picker widget using the uppy's image editor enhances the usage of the file uploader and it will help enforcing the size and form factor restrictions in images that are being uploaded.

Internal
@dilippitchika to review how important this problem is and get back on the priority better

When is this feat moving up on project's priority? This would improve a lot Appsmith's suitability as most projects need standardized photos in the backoffice.

Hey @Nuno1123 we haven't got a lot of requests around this, we have to validate if this is actually need for majority of our users. If so we can focus on implementing it.

Our use-case is to be able to validate and standardized all photos uploaded by users
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: dilippitchika @.>
Sent: Tuesday, December 27, 2022 1:01:23 PM
To: appsmithorg/appsmith @.>
Cc: Nuno Monteiro @.>; Mention @.>
Subject: Re: [appsmithorg/appsmith] [Feature]: Enable Image editor in file picker widget (Issue #17951)
Can you please explain your use-case here? It would help me understand if this is absolutely essential in all image based flows.
—
Reply to this email directly, view it on GitHubhttps://github.com/appsmithorg/appsmith/issues/17951#issuecomment-1365884579, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD77UXWR5RJAFBV4GPB3ITTWPLSCHANCNFSM6AAAAAARRXNUFY.
You are receiving this because you were mentioned.Message ID: @.***>

Can you help me understand, What are these photos being used for and why do you need to standardize them?

The app we are populating from this backoffice is very high quality photo driven so we want to have final decision into each submited photo from our users. We want to apply a standard type of photo with customization on our end.


Better documentation

Clean up current documentation. For instance ?coord_distance feels verbose and clunky
Ensure all major functions are taking advantage of the built in system
Set up a readthedocs page

Holding off on readthedocs, latest round of commits improved a lot of current documentation needs.


Option to use a single skia surface

Adds the ability requested in #97 to use a single skia surface for every Renderer.draw() call until the next window_size or scale_factor change.

After looking at this change, I'm wondering if this new behavior should be the way it always works. I originally implemented this with one skia image per swapchain image because I believed this was necessary for correctness. (Apologies if you're already aware of this, but just in case not, it's typical to make one resource (i.e. command buffer, command pool, etc.) per swapchain image because it is undefined behavior to modify them while they are being processed by the GPU, and the command buffer submission (and things it points to) are processed async from the CPU.)
However, the skia image is copied to the swapchain image, so as long as we don't modify frame N+1's skia image concurrently to frame N doing that blit, I think we can reuse the image every frame. (If this is not the case, then we'd have to rethink this PR.) I need to look at the code a bit more to confirm we finish the blit for frame N before rendering frame N+1, and try running this myself with validation enabled, but wanted to leave a comment in the meantime.

I spent some time looking at this tonight. I didn't get any validation errors (although I found a bug that was preventing validation errors from showing up! So that was good to find!) I think my concerns about multiple frames being in flight sharing the same texture that is being modified was a risk, but there are memory barriers before/after modifying the texture. This might be sufficient to avoid the race conditions and force any reads/writes (which are all happening on the GPU) to be serialized.
Given this, I would be in favor of making this the default (and only) behavior. Do you want to make the change or should I? Thanks!

I've never done graphics programming before so I guess I was lucky that using a single surface works in this case. Do you want to have the option to use multiple skia surfaces or should the option be removed entirely?

I think we should always use a single surface. (assuming it works properly, which from what I can tell, it does)

Thanks, looks great! Will merge once it's passing CI :)

Forgot fmt^^


relaunch browser when browser has not captured

Expected behaviour
should just remain the status
Actual behaviour
12 12 2016 20:01:14.476:INFO [karma]: Karma v1.3.0 server started at http://localhost:9876/
12 12 2016 20:01:14.476:INFO [launcher]: Launching browser android with unlimited concurrency
12 12 2016 20:01:14.478:DEBUG [launcher.browserstack]: Establishing the tunnel on localhost:9876
12 12 2016 20:01:14.501:INFO [launcher]: Starting browser Android Browser (android 5.0) on BrowserStack
12 12 2016 20:01:22.389:DEBUG [launcher.browserstack]: Tunnel established.
12 12 2016 20:01:30.311:INFO [launcher.browserstack]: Android Browser (android 5.0) session at https://www.browserstack.com/automate/builds/{build}/sess
ions/{session}
12 12 2016 20:01:30.312:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job with id 67855688 in queue.
12 12 2016 20:01:38.455:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job started with id 67855688
12 12 2016 20:02:38.453:WARN [launcher.browserstack]: Android Browser (android 5.0) has not captured in 60000 ms, killing.
12 12 2016 20:02:38.454:DEBUG [launcher.browserstack]: Killing Android Browser (android 5.0) (worker 67855688).
12 12 2016 20:03:07.565:DEBUG [launcher.browserstack]: Android Browser (android 5.0) (worker 67855688) successfully killed.
12 12 2016 20:03:07.568:DEBUG [launcher]: Finished all browsers
12 12 2016 20:03:10.317:INFO [launcher.browserstack]: Android Browser (android 5.0) session at https://www.browserstack.com/automate/builds/{build}/sessions/{session}
12 12 2016 20:03:10.319:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job with id 67855817 in queue.
12 12 2016 20:03:15.505:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job started with id 67855817
12 12 2016 20:04:15.501:WARN [launcher.browserstack]: Android Browser (android 5.0) has not captured in 60000 ms, killing.
12 12 2016 20:04:15.502:DEBUG [launcher.browserstack]: Killing Android Browser (android 5.0) (worker 67855817).
12 12 2016 20:04:42.706:DEBUG [launcher.browserstack]: Android Browser (android 5.0) (worker 67855817) successfully killed.
12 12 2016 20:04:46.925:INFO [launcher.browserstack]: Android Browser (android 5.0) session at https://www.browserstack.com/automate/builds/{build}/sessions/{session}
12 12 2016 20:04:46.925:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job with id 67855877 in queue.
12 12 2016 20:04:49.561:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job started with id 67855877
12 12 2016 20:05:49.558:WARN [launcher.browserstack]: Android Browser (android 5.0) has not captured in 60000 ms, killing.
12 12 2016 20:05:49.558:DEBUG [launcher.browserstack]: Killing Android Browser (android 5.0) (worker 67855877).
12 12 2016 20:06:16.831:DEBUG [launcher.browserstack]: Android Browser (android 5.0) (worker 67855877) successfully killed.
12 12 2016 20:06:19.427:INFO [launcher.browserstack]: Android Browser (android 5.0) session at https://www.browserstack.com/automate/builds/{build}/sessions/{session}
12 12 2016 20:06:19.428:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job with id 67855980 in queue.
12 12 2016 20:06:29.775:DEBUG [launcher.browserstack]: Android Browser (android 5.0) job started with id 67855980
12 12 2016 20:07:29.771:WARN [launcher.browserstack]: Android Browser (android 5.0) has not captured in 60000 ms, killing.
12 12 2016 20:07:29.771:DEBUG [launcher.browserstack]: Killing Android Browser (android 5.0) (worker 67855980).
12 12 2016 20:07:57.265:DEBUG [launcher.browserstack]: Android Browser (android 5.0) (worker 67855980) successfully killed.

Environment Details

Karma version: 1.3.0
Relevant part of your karma.config.js file

// to avoid DISCONNECTED messages
browserDisconnectTimeout: 60*1000,    // default 2000
browserDisconnectTolerance: 0,        // default 0
browserNoActivityTimeout: 60*1000,    // default 10000
captureTimeout: 60*1000,              // default 60000

customLaunchers: {
    android: {
        base: 'BrowserStack',
        "os": "android",
        "os_version": "5.0",
        "browser": "Android Browser",
        "browser_version": null,
        "device": "Google Nexus 9"
    }
}

browsers: ['android']

autoWatch: false,
singleRun: false

Steps to reproduce the behaviour
run karma start karma.conf.js
The relaunch process will repeat 4 times and then exit
below is the screenshot of browser stack log:

same behavior here :(

Same here. On OS X.

I noticed that the tests that kept retrying had durations longer than Karma's default captureTimeout value of 60000. Raising it to 120000 solved the problem for all but Nexus 5, which needed 180000.

in the latest doc, the captureTimeout has raised to 120000, does the captureTimeout contains the virtual device launch time ? @stevenvachon
If yes, the description of captureTimeout confused me, maybe you can clear the description.

It says that, but in the code it uses the Karma default, which is 60000.

I'm seeing the same issue -- and I've tried supplying extra config options, e.g.,
    browserNoActivityTimeout: 3e5,
    browserDisconnectTimeout: 3e5,
    browserDisconnectTolerance: 3,
    captureTimeout: 120000,

And I'm still seeing OP's issue.

@petermikitsh are you trying to test on the Nexus 5? Apparently it doesn't (or didn't) support local tunnelling. What errors do you see in the video recordings on BrowserStack?

I tried again with these settings:
    bs_android_5: {
      base: 'BrowserStack',
      os: 'android',
      os_version: '5.0',
      browser: 'Android Browser',
      browser_version: null,
      device: 'Google Nexus 9'
    }

And it worked. Not sure what I did wrong the first time.


changed default logspace timestretch bounds

Should fix #32

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Coverage remained the same at 97.917% when pulling 9f3102d9bdbd77dbb8d6f40703aef5d997ccd982 on logstretch-defaults into 7738a6ed113b92eb3ac6503ff62b417354c4e7ff on master.


(HTTP code 500) server error - {"message":"Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:49355-><IP_ADDRESS>:53: i/o timeout"}

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

Please make sure that you're on a stable connection and use a solid DNS such as Google DNS.


Continuous Deployment

Commits to the master branch should automatically update the live site without any other actions. This allows GitHub to be used as an editing interface.
This is unrelated from continuous integration and/or integration tests.

The site has now been rebuilt with Vuepress which allows functionality.


Print syntax errors when they exist.

I'm pretty sure this is correct, since ParserInfo.printSyntaxErrors has an explicit if statement where it doesn't do anything if the collection of syntax errors is empty.
(Also, my IDE reminds me that since getSyntaxErrors is varargs, it doesn't need an array created to be passed as a parameter.)

Oops :-D  Good catch. Thanks!
I clearly need a better IDE... I assume you use IntelliJ IDEA? I'm still on Eclipse, which is feeling more and more antiquated...


Andro

loaded data....dropped irrelevant columns as agreed...summary stats

Dropped irrelevant columns, and summarized statistics of the dataset


Update JDK to 17 LTS

Tool name
JDK
Tool license
GNU General Public License, version 2, with the Classpath Exception
Add or update?

[ ] Add
[X] Update

Desired version
17 LTS
Approximate size
No response
Brief description of tool
Please update JDK from 11 to 17 LTS.
I requested for Ubuntu 22, but I guess all images could benefit from this request.
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
java --version

Platforms where you need the tool

[ ] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
sure!

This issue relates to #8336 where @4brunu requested the update to JDK 21.
as mentioned by @erik-bershel, JDK 21 is not available in [Adoptium](@4brunu JDK 21 is not yet available in Adoptium yet but JDK 17 is!

Hey @Eclion! Java 17 is available on Ubuntu images. Please, use Java related actions or environment variables.
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#java
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#java

Hello @erik-bershel !
I am really sorry, I didn't realise the versions were installed, and I just have to update my JAVA_HOME env variable to the corresponding JAVA_HOME_{version}_X64 env var.
Thank you very much for your explanation!


[Request] Remove Empty Directories (aka RED)

Haven't find a duplicated Request and is conformed by XEL
Package Request
Information
Name: RED aka "Remove Empty Directories"
Description: [clear and concise details of what it is]
Quoting from the summary Below:
RED searches and deletes empty directories recursively below a given start folder and shows the result in a well arranged tree. Further you can create some custom rules for keeping and deleting folders. Empty files in directories can also be ignored.
Homepage: [a URL/link]
RED Home
Download link(s): [URL(s)/link(s)]
Download From Github
Some indication of popularity/repute: [GitHub stars/software reviews etc.]
SourceForge Review

Just a note:
There are another program also called:

There is a reason why i add the full name "Remove Empty Directories" aka RED which is "Extra" and the other is in main bucket

https://github.com/ScoopInstaller/Extras/commit/0b6b214a9bd9a1d184a1b5279b8b3ba21ca28f75


Add "polling" feature for configuration file

The use case is when you are fine tuning writing of queries, it would be really nice to be able to turn on "polling" of the configuration file, for the configuration to be picked up at runtime instead of just once at startup. This would be similar to the polling feature in logback.
I will probably add this at some point, I just wanted to get the issue out here so we can see if there is any support for it.

Implemented in 1.0.14.
https://github.com/jmxtrans/embedded-jmxtrans/releases/tag/embedded-jmxtrans-1.0.14


[MRT Reference App] @W-13153758 Enable cache for /cache endpoint

Description
Updates template-mrt-reference-app/ssr.js to enable caching when sending a get request to the /cache endpoint. This will allow us to write smoke tests for the CloudFrontDistrbution's cache behaviour
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001Qmt1DYAR/view

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

set response header to Cache-Control: s-maxage=60 when the endpoint is /cache

How to Test-Drive This PR

Clone this repo and run npm ci
Start the mrt-reference-app: cd packages/template-mrt-reference-app && npm start
navigate to http://localhost:3000/cache and verify

timestamp is in the response body
"cache-control": "s-maxage=60" in the response headers

navigate to any other URL e.g., http://localhost:3000 and verify

timestamp is in the response body
"cache-control": "no-cache" in the response headers

@hajinsuha1 a bunch of your commits are not verified which is likely to cause a problem for this PR

PR checks are not running properly (missing all of the actual CI runs / checks) so this will "hang" indefinitely in pending. A no-op / whitespace commit or similar is needed

PR checks are not running properly (missing all of the actual CI runs / checks) so this will "hang" indefinitely in pending. A no-op / whitespace commit or similar is needed

@bfeister i tried an empty and an update to the commits but looks like it's still hanging. Any ideas?


fix: disk-resize sync guest status cause deadlock

这个 PR 实现什么功能/修复什么问题:
修正：disk-resize中调用guest.syncstatus出现dead lock。改为如果disk挂载到guest，则调用guestResizeDiskTask，并且取消diskResizeTask中对guest.syncStatus的调用
是否需要 backport 到之前的 release 分支:

release/2.10.0
release/2.11
release/2.12

/area region
/cc @yousong @zexi @wanyaoqi @ioito

Codecov Report

Merging #2469 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2469      +/-   ##
=========================================
- Coverage    7.08%   7.07%   -0.01%
=========================================
  Files         456     456
  Lines       71806   71845      +39
=========================================
- Hits         5085    5083       -2
- Misses      66303   66343      +40
- Partials      418     419       +1

Flag
Coverage Δ

#aFlag
7.07% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/hostdrivers.go
18.18% <ø> (ø)
:arrow_up:

pkg/compute/models/disks.go
0.73% <0%> (-0.01%)
:arrow_down:

pkg/compute/models/guest_actions.go
0% <0%> (ø)
:arrow_up:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286754e...bbfae85. Read the comment docs.

/approve
/lgtm