Update Ref/Box example on property wrappers proposal to compile

It seems like there is a set of typos in the property wrappers proposal, specifically in the Ref/Box example.
The Ref property wrapper has no projected value. Yet, the example code uses the $ syntax.
I copied the Ref property wrapper code into a playground and wrote up something very similar to the example (I couldn’t copy the flow of the example directly since property wrappers are not allowed for top-level properties). It does not compile, as evidenced in this screenshot from the Playgrounds iPad app.

It seems like the intention here is to access the backing storage value? I made an update to that effect.
Alternatively, I may be missing something. If that’s the case, I figured I’d learn from this PR.

Tagging @rjmccall who is listed as the review manager of the proposal. This is my first PR to this repo, so trying to figure out the right process 👍

I failed to update this example through the revision process. Thank you!


Licence

We can add licence tag to all our files,
I am not sure how to go through the process of licencing.
But it's needed as an open source project

What if we put the MIT License in the root of the project?

I think we should add it in all files on header section as other projects are also having it.

Info on MIT license -
https://opensource.org/licenses/MIT
To add it to github -
https://help.github.com/articles/open-source-licensing/

Thank you. I think for the first version an addition of the MIT license is sufficient (as Meteor does it). We can add the headers later on if we need to.

Oh thats perfectly fine. Can someone use this source code and use it for commercial propose will it be ok?

Yes. I think we should use the MIT license which permits this!

PR successfully submitted
https://github.com/GravityProject/gravity/pull/110


searching for author:"Abbott, R B"

Originally by cdickins on 2011-08-24
Current behavior
Requesting /search?p=author:"Abbott, R B" returns:
Boolean query returned no hits. Please combine your search terms differently.
85	 	and
1	 	Abbott, R B
Requesting /search?p=author:"Abbott, R* B" returns 1 hit (recID 16).
-Expected behavior*
Requesting /search?p=author:"Abbott, R B" returns 1 hit (recID 16).
Presumably this is due to "r" (i.e. the "R" in "Abbott, R B") being a key in _SPIRES_TO_INVENIO_KEYWORDS_MATCHINGS (search_engine_query_parser.py).

Fixed in 2.1 since dc74feff.


Mocks are serialized as functions in snapshots

Describe the bug
Coming from a Jest background, I would expect that mock serialization in any type of snapshots testing returns details of the current state of the mock.
Reproduction
Test file:
import { vi, test, expect } from "vitest";

const mock = vi.fn();

test("something", () => {
  mock(1, "whatever");
  expect(mock).toMatchSnapshot();
});

Snapshot produced:
// Vitest Snapshot v1

exports[`something 1`] = `[Function]`;

System Info
System:
    OS: macOS 12.4
    CPU: (8) arm64 Apple M1 Pro
    Memory: 726.98 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.14.0/bin/yarn
    npm: 8.3.1 - ~/.nvm/versions/node/v16.14.0/bin/npm
  Browsers:
    Chrome: 103.0.5060.134
    Safari: 15.5
  npmPackages:
    vite: ^3.0.2 => 3.0.2
    vitest: ^0.18.1 => 0.18.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

wow That was fast ! Thanks @sheremet-va 🙏🏻


Integrate SWAT insights (EPIC)

Work closely with Fearghal's team - AgroScience might need similar predictions, will maybe collaborate with them.
We need to figure out to get Anas assigned for some of his team

Create development and testing environment for SWAT AI/ML models

Ilse will set up a meeting with Fearghal to identify what data will be provided first - for advice page.


Observation: confused by code in compiler/crystal/macros/macros.cr

Since I might have misunderstood the workings, I simply report my observation. It might just be the comments confusing me because I consider args with no splat to be "pre-splat", which of course isn't a truth by definition.
According to comment the following should process pre-splat args, but is never run if no splat:
https://github.com/crystal-lang/crystal/blob/master/src/compiler/crystal/macros/macros.cr#L165
It of course works, because the loop that should do post-splat args will run through the args:
https://github.com/crystal-lang/crystal/blob/master/src/compiler/crystal/macros/macros.cr#L191
The only difference in practice I guess, is that args ends up in vars after named_args etc. which doesn't change the workings in any way.
Well, better report when confused then not :-)

Is there a simpler way to express this logic?

 A loop for pre-splat args, a loop for splat-args and a loop for post-splat args.

No, I got a bit confused about the intentions of the code, so I thought it was better with a checkup than not. I simply expected the first loop to iterate all the args when there was not splat instead of the "post splat args"-loop. Closing.


az help displayed the result with an error: psutil.AccessDenied

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az help
az -help
az --help
Errors:
psutil.AccessDenied (pid=7580)
Traceback (most recent call last):
Temp\pip-unpacked-wheel-eja79zsp\psutil\_common.py, ln 449, in wrapper
AttributeError: _cache

...

Temp\pip-unpacked-wheel-eja79zsp\psutil\_pswindows.py, ln 750, in name
Temp\pip-unpacked-wheel-eja79zsp\psutil\_pswindows.py, ln 681, in wrapper
psutil.AccessDenied: psutil.AccessDenied (pid=7580)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az --help

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.6.8
Installer:

azure-cli 2.20.0 *

Additional Context

@jiasli for awareness

Hi @ekotera, what is the terminal you are using to call Azure CLI? Also, could you share the full call stack?


Return a timezone feild

Is there a way to add a timezone field in the JSON responses?
I would like to be certain that I am pulling prices in gmt-0 and can't find that info anywhere.

@finnhubio can you answer this?


add to support for block's title in confluence converter

Most asciidoc block support title using the following syntax
.The title of my block
the content of my block

When possible, the title should be displayed in the confluence output.

Resolved via #146 by @gleroi


⚠ Turnos 24x7 has degraded performance

In bede8f0, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 958 ms

Resolved: Turnos 24x7 performance has improved in 97a0062.


Further idiot-proof the kernel update process

Use a two-phase commit to update the token for a particular loader without crippling the automated boot after some common classes of errors by: preserving the old token while creating a new token from the new loader written to a different filename; moving the new loader over the original loader, ensuring both are bootable regardless of which "wins"; and then deleting the old token once the new loader is definitely in place.

Similarly, seal a loader to counter+1 and put it in place prior to actually incrementing the counter.

Keep in mind that +1 doesn't actually work because for a TPM "increment" really means "highest value of any counter + 1", and could be arbitrarily higher.


Large integer values in aln_length and mismatch output columns

Hi,
we just run an easy-search of a lncRNA database (FASTA) against a large indexed genome (FASTA) with default parameters and got the following output:
`└─> head mlu.aln
lnc-SEMA6A-5:1	MLU_1_162	0.679	575	176	0	197	746	49406	49980	3.015E-45	189
lnc-TPCN2-6:1	MLU_8_38	0.780	99	21	0	44	142	32699	32796	1.421E-10	71
lnc-TPCN2-6:1	MLU_29_27	0.776	76	17	0	45	120	43884	43959	1.365E-07	62
lnc-TPCN2-6:1	MLU_336_6	0.791	67	14	0	35	101	56475	56541	8.884E-07	59
lnc-TPCN2-6:1	MLU_1044_0	0.783<PHONE_NUMBER><PHONE_NUMBER>	0	144	62	48340	48415	1.658E-06	58
lnc-TPCN2-6:1	MLU_185_31	0.760<PHONE_NUMBER><PHONE_NUMBER>	0	144	50	16903	16995	5.779E-06	56
lnc-TPCN2-6:1	MLU_36_80	0.840	50	8	0	44	93	21998	22047	1.079E-05	55
lnc-PLCD3-1:14	MLU_593_1	0.776<PHONE_NUMBER><PHONE_NUMBER>	0	627	1	30011	30633	2.583E-130	472
lnc-PLCD3-1:14	MLU_593_1	0.823<PHONE_NUMBER><PHONE_NUMBER>	0	826	636	29811	30000	1.599E-41	177
LINC00658:1	MLU_54_59	0.764<PHONE_NUMBER><PHONE_NUMBER>	0	767	632	26985	27124	2.375E-18	99`
What are the large numbers in the aln_length and mismatch columns?
Thx!
EDIT: Maybe this occurs because we tried to search nucleotide queries against a nucleotide database, what the tool is maybe not intended for?

Yes, the nucl/nucl search is still experimental. We do not support indexed nucleotide sequences yet. Do you want to align nucleotide/nucleotide or six-frame/six-frame?

ok, we wanted to align a multi-fasta nucleotide file against another multi-fasta nucleotide file. Therefore, we indexed nucleotide sequences and maybe due to this we got this strange high integer values in the output columns

you can just try to run it without the index.

will give it a try, thanks!

We do have indexed nucleotide searches now

Great, thanks for the Info!
Martin Steinegger<EMAIL_ADDRESS>schrieb am Sa., 20. Apr. 2019,
00:57:

We do have indexed nucleotide searches now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/soedinglab/MMseqs2/issues/138#issuecomment-485033209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADN2CZZNUSLIYFIHPSMWQC3PRJE5NANCNFSM4GHOTK2Q
.


【功能需求】解析文章，希望能支持markdown的纯文本格式，甚至是单词列表的md纯文本

Thank you for the requirement.
I will consider supporting the parsing of Markdown plain text format, including the MD plain text of the word list, also the pure text English article.


Drop-in UI not showing default payment

This has been identified as an issue and fixed in the Android SDK. Any updates on when it is going to be fixed in the JavaScript Drop-In UI?

+1

This fix is planned to go out with the next JS SDK release.

This feature has been added in version 2.24.0
The docs will be released shortly, but in the meantime, here's how you would configure it:
var clientToken = "client_token_from_server"; // this client token must have the customer id parameter configured
braintree.setup(clientToken, 'dropin', {
  defaultFirst: true
});

How would I use defaultFirst for v3 drop-in?

defaultFirst is the only way payment methods are shown: https://github.com/braintree/braintree-web-drop-in/blob/39ca485487ea4107288e32b8a0b1fb368474d138/src/dropin-model.js#L286

Is this true for https://js.braintreegateway.com/web/dropin/1.11.0/js/dropin.min.js as well?
As a side note, why are the dropin files versioned seperately from the whole client SDK? Does 1.11 of the dropin correlate to the most recent v3 Client SDK?

Here is what I am doing to set the dropin up:

braintree.dropin.create({
                authorization: client_token_server,
                container: '#dropin-container',
                defaultFirst: "true",
                vaultManager: true,
                venmo: {}, paypal: {flow: 'vault'}, paypalCredit: {flow: 'vault'},
              }, function (createErr, instance) { [...] })

Please open a new issue on Drop-in's repo and we'll dig into it: https://github.com/braintree/braintree-web-drop-in
Drop-in uses version 3 of braintree-web, but is itself it's own product. Which is why it has a separate repo and version.

@crookedneighbor
Here is what I am doing to set the dropin up:
braintree.dropin.create({
authorization: client_token_server,
container: '#dropin-container',
venmo: {}, paypal: {flow: 'vault'}, paypalCredit: {flow: 'vault'},
}, function (createErr, instance) { [...] })
Is there something I'm missing in the setup?

Did you manage to solve this?

I've been out of office. It's been added as a feature on master, but has not been released yet. Hoping to get a release out next week or so.
https://github.com/braintree/braintree-web-drop-in/pull/675

I've been out of office. It's been added as a feature on master, but has not been released yet. Hoping to get a release out next week or so.
https://github.com/braintree/braintree-web-drop-in/pull/675


Micro is not very "lightweight"

In the readme it says "micro" and "lightweight", but doesn't say what the installed size is. So I went ahead and did my own tests.
mkdir micro-example
cd micro-example
npm init -y
npm install --save micro
du -sh node_modules

This shows 9.2M for<EMAIL_ADDRESS>and all it's dependencies.
Now lets try with the popular express framework.
mkdir express-example
cd express-example
npm init -y
npm install --save express
du -sh node_modules

This shows 1.8M for<EMAIL_ADDRESS>and all it's dependencies.
I also repeated the same steps for<EMAIL_ADDRESS>(2M) and<EMAIL_ADDRESS>(1.3M) which are also popular web frameworks.
That means micro is the largest of the frameworks one might use to make microservices.
Is this expected?

micro is not just a framework, but also comes with a development CLI. But yes, we're already working on splitting it out!

we're already working on splitting it out!

Splitting what out?

The CLI

The code running is a lot less than express / koa, who cares about installed space in 2017?

@albinekb Yea, that's my opinion. But sadly, a bigger package also means longer installation times in production (which makes deployments slow).

@albinekb My assumption is that micro was designed for implementing microservices.
If you add micro as a dependency to a 1000MB mono-repo, then it's only a 1% increase.
If you add micro as a dependency to 500 individual microservices, that's a 5000MB (5GB) increase in size.

I'm getting 17mb now. @leo what's the status of splitting out the cli?

@aafrey https://github.com/zeit/micro/pull/260

@timneutkens thanks! what are you using to measure package size? the printout looks really nice!

@aafrey this one https://github.com/siddharthkp/cost-of-modules

thanks!

Very close!

The split happened:
https://zeit.co/blog/micro-8

I just checked v9.0.0 and it reports 747K.
That's significantly smaller now, thanks!


Does not support packages that require the user to accept licenses.

Good day.
I love this package; it's really awesome. I'm currently having an issue with the SqlChangeAutomation module.
It's giving me an error and not performing the accept license operation.
Is there any option to do that in this action?

- name: Install and cache PowerShell modules
          id: psmodulecache
          uses<EMAIL_ADDRESS>          with:
            modules-to-cache: dbatools:1.0.0, SqlChangeAutomation
            shell: powershell

Good catch !
Indeed I haven't tested this case, like others...

Is there any option to do that in this action?

No, for the moment the installation of this type of module must be done upstream in a dedicated step.
I think the default for all modules to install should be -AcceptLicense:$true
I also need to test a module which does not require license acceptance but which has a dependency requiring acceptance. I'm not sure if this setting is propagated for all dependencies.

Done.
See


Release ibc-rs v0.10.0

Closes: #1648
TODOs:

[x] As part of combing the guide, we should probably apply these changes https://github.com/informalsystems/ibc-rs/pull/1576/commits/2690ba8094cc15f15af5d6de195a2f207c4dec99
[x] https://github.com/informalsystems/ibc-rs/pull/1664

Description

[ ] Create a new release in the changelog, using unclog.
[x] Bump all crate versions to the new version.
[x] Reassign unfinished issues of previous milestone to the next milestone.
[x] Update Cargo.lock file (if re-publishing ibc-relayer-cli)

To prevent confusion, will close this until we're ready (most likely in 2022).

Blocked by a potential regression documented in #1715. Once that is clarified, we resume this work.


Mistake / old information in Readme for command-line arguments

I think I found another piece of information in the Readme that doesn't match the actual command-line parameters (perhaps you forgot to update those when you switched to the new cmdline options module).
Readme says:

Command line: python -m Scyland3D.Scyland3D -v False for removing the display of information to the console.

Output:
python -m Scyland3D.Scyland3D -v False
usage: Scyland3D.py [-h] [-i INDIR] [-o OUTDIR] [-m MIRROR_FACTOR] [-r ORDER]
                    [-f ORDER_FACTOR] [-n FEATURE_NAMES] [-v]
Scyland3D.py: error: unrecognized arguments: False

Could you also check all the other examples in the readme please whether they work as expected?

I updated all examples from command line and from python. Could you tell me if everything is ok on your side?

A couple more questions:

This is only valid if the keyword upper is present in the file name.

I'm a bit confused what that exactly means. In the filename? Or within one of the .pts files in the directory given with -i? In case of the latter, I am still confused because none of these files contains the string "upper" (or I am not finding it / looking in the wrong place?)
Also when I run the given command, python -m Scyland3D.Scyland3D -i "path/" -f "upper" -r "36, 35, 34, 33, 32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, 37", on the example/ directory, a file landmarks_reordered.csv gets written.
If I replace -f "upper" by -f "lower", it writes a file landmarks.csv. Why this unexpected and (for me) unintuitive difference?
The other commands exhibit the same behaviour, e.g. with landmarks_reversed.csv etc.

Command line: python -m Scyland3D.Scyland3D -i "path/" -m "upper" will mirror in 3D the files containing the keyword upper before processing them with the remaining lower items as depicted in the figure below:

The figure is no longer below that text.  Is that expected?
The text description is also not 100% clear to me. "will mirror in 3D the files containing the keyword upper before processing them with the remaining lower items"? "...before processing them with the remaining..."?

AssertionError: The order_factor (asdf) provided has not been found in any file names.

I'm a bit confused what that exactly means. In the filename? Or within one of the .pts files in the directory given with -i? In case of the latter, I am still confused because none of these files contains the string "upper" (or I am not finding it / looking in the wrong place?)

The folder https://github.com/ybayle/Scyland3D/tree/master/Scyland3D/example/ contains three pts files with the keyword upper and two with the keyword lower.

Also when I run the given command, python -m Scyland3D.Scyland3D -i "path/" -f "upper" -r "36, 35, 34, 33, 32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0, 37", on the example/ directory, a file landmarks_reordered.csv gets written.
If I replace -f "upper" by -f "lower", it writes a file landmarks.csv. Why this unexpected and (for me) unintuitive difference?

Thanks for finding this bug in the outputfilename. This is now fixed.

 Is that expected?

The error message AssertionError: The order_factor (asdf) provided has not been found in any file names. was displayed for an invalid order_factor but not for a mirror_factor. This is a bug that is now fixed.

The text description is also not 100% clear to me. "will mirror in 3D the files containing the keyword upper before processing them with the remaining lower items"? "...before processing them with the remaining..."?

The word remaining has been removed for clarity. Indeed all files are processed but a preprocessing is applied to the upper ones.

Command line: python -m Scyland3D.Scyland3D -i "path/" -m "upper" will mirror in 3D the files containing the keyword upper before processing them with the lower items as depicted in the figure above.

I am still not sure the second part (after the "before...") is clear. If I understand correctly, what you want to say is "...before processing the remaining files (without mirroring them).". Correct? And the figure depicts the mirroring, so it only applies to the first part of the sentence?

If you specify part of a string, e.g. ... -f "u", then it runs as well. I guess because it matches the "u" to "upper"? Is this expected, or would it not be better to search for an exact match?
Also I understand now that you're really referring to the filename, and not to the file content. Encoding information in the filename is a tricky business, in my opinion. It might be unavoidable though if you don't have control over the content of the .pts file / format. In that case, you should just document it better that the filename of the files actually matter and that they have to have a specific format (e.g. separated by _ or - or something so that exact matches can be produced).
An even better solution might be that you take as input to the script not a whole folder, but only a single file (usually this is better practice anyway), and then the order arguments can be given directly, without having to parse filenames. If someone then needs to process a whole folder, they would write their own script around yours that handles the folder processing and filename convention. (You could also supply this, separately).
Anyway this decision I would leave up to you, just some input to consider from my side.

I am still not sure the second part (after the "before...") is clear. If I understand correctly, what you want to say is "...before processing the remaining files (without mirroring them).". Correct? And the figure depicts the mirroring, so it only applies to the first part of the sentence?

I have updated the sentence as follow:
Command line: `python -m Scyland3D.Scyland3D -i "path/" -m "upper"` will mirror in 3D -as depicted in the figure above- the landmarks stored in `.pts` file with the keyword `upper` in their filename. Then, it will export to a `.csv` file those processed landmarks and also the unprocessed landmarks from  `.pts` file that do not contain the keyword `upper` in their filename.

If you specify part of a string, e.g. ... -f "u", then it runs as well. I guess because it matches the "u" to "upper"?

Yes, indeed.

Is this expected, or would it not be better to search for an exact match? Otherwise if a file contains lower in the filename but contains an u somewhere else (maybe you're procesing mouths and not teeth!), it would match it and reorder as well? Also I understand now that you're really referring to the filename, and not to the file content. Encoding information in the filename is a tricky business, in my opinion. It might be unavoidable though if you don't have control over the content of the .pts file / format. In that case, you should just document it better that the filename of the files actually matter and that they have to have a specific format (e.g. separated by _ or - or something so that exact matches can be produced).

You're right, I have added a warning in the ReadMe to document it better. The user should be careful when typing keywords, and I consider this less dangerous than having a typo in a command line like rm filename.txt.

An even better solution might be that you take as input to the script not a whole folder, but only a single file (usually this is better practice anyway), and then the order arguments can be given directly, without having to parse filenames. If someone then needs to process a whole folder, they would write their own script around yours that handles the folder processing and filename convention. (You could also supply this, separately). Anyway this decision I would leave up to you, just some input to consider from my side.

The user can currently process a single file and call the script multiple times for each of his file. Or the user can use the ability to process multiple files.

Command line: python -m Scyland3D.Scyland3D -i "path/" -m "upper" will mirror in 3D -as depicted in the figure above- the landmarks stored in .pts file with the keyword upper in their filename. Then, it will export to a .csv file those processed landmarks and also the unprocessed landmarks from .pts file that do not contain the keyword upper in their filename.

I think this sentence is more clear but a bit convoluted now. I am not a native speaker either but how about this slight modification?

Command line: python -m Scyland3D.Scyland3D -i "path/" -m "upper" will mirror in 3D the landmarks stored in .pts files with the keyword upper in their filename. Then, it will export to a .csv file those mirrored landmarks and also the unprocessed landmarks from .pts files that do not contain the keyword upper in their filename. The figure above depicts the mirroring.

I consider this less dangerous than having a typo in a command line like rm filename.txt.

Well certainly deleting files by accident can be dangerous, especially if one doesn't have a backup ;-)
But I would argue that these sort of "silent mistakes" like here, are potentially more dangerous, particularly in research environments. You will run a command, often on several files, you will not hand-check all the resulting files usually, and you may never discover that some points that you thought got mirrored actually didn't, or the other way round.
Personally, I think the Scyland3D documentation is still not clear enough to allow someone not already familiar with it to understand how all this filename-stuff and the order-factor etc. works, and what the potential gotchas are. If we didn't have this discussion, I don't think I would be able to confidently use it, just from reading the Readme.
Anyway I will leave it at that - I feel like some of that might just be my personal opinion/preference, and I feel like my job as reviewer is done. It might be perfectly clear to other people and I know that A) reviewers aren't always right and B) authors can't (or don't want to) always fully please all reviewers :-).
Thanks for all the explanations and I'm sure they'll be helpful to your other users!

I think this sentence is more clear but a bit convoluted now. I am not a native speaker either but how about this slight modification?

Thanks for the suggestion that is clearer thanks to the sentences being split up. I have updated accordingly the readme.

Well certainly deleting files by accident can be dangerous, especially if one doesn't have a backup ;-) But I would argue that these sort of "silent mistakes" like here, are potentially more dangerous, particularly in research environments. You will run a command, often on several files, you will not hand-check all the resulting files usually, and you may never discover that some points that you thought got mirrored actually didn't, or the other way round. Personally, I think the Scyland3D documentation is still not clear enough to allow someone not already familiar with it to understand how all this filename-stuff and the order-factor etc. works, and what the potential gotchas are. If we didn't have this discussion, I don't think I would be able to confidently use it, just from reading the Readme. Anyway I will leave it at that - I feel like some of that might just be my personal opinion/preference, and I feel like my job as reviewer is done. It might be perfectly clear to other people and I know that A) reviewers aren't always right and B) authors can't (or don't want to) always fully please all reviewers :-). Thanks for all the explanations and I'm sure they'll be helpful to your other users!

I'll discuss more with people using Scyland3D to see how we can improve and avoid these kind of silent bug.
Thank you very much for all your advices, suggestions, and the bug you found that helped improve the software and its usability!

You're welcome, and all the best! :)


Regarding repackaging AEPP to a simplified interface for the end user.

Is there any consideration for implementing a module-based design for AEPP enhancement in the future? A module-based design, similar to packages like Pandas, would allow importing the entire AEPP package and making all its modules and contents accessible. For instance, when importing Pandas as 'pd', it provides access to all the functions. This design choice allows you to perform various operations without explicitly calling different classes under the pandas library. I'm curious if there are plans to explore such a design approach for AEPP. (In the case of Pandas library, it imports all the classes in the init.py file for the end user. Which makes the library so popular with even Python beginners. Although I'm uncertain about the level of development effort this would require for AEPP).

Thanks @yoyo6022 for this idea.
This is not in the current roadmap but there are works planned that could align with this objective. We will let you know if we ever start working on this.


fix: slippage is in bps and other fields fixes and add

Some minor cleanup to properly use slippage_bps everywhere and expose some potentially other useful fields

thanks, I'll publish a 0.5.0 crate maybe tomorrow with this PR and your earlier one


Helm file update fails when tags are marked as string

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
docker
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
No response
dependabot.yml content
No response
Updated dependency
No response
What you expected to see, versus what you actually saw
The following config works:
image:
  repository: nginx
  pullPolicy: IfNotPresent
  tag: 1.17.7

But following does not (note the quotes around the tag):
image:
  repository: nginx
  pullPolicy: IfNotPresent
  tag: "1.17.7"

While running dependabot with this configuration it does recognize that the version needs to be updated (from logs):
Checking if nginx 1.17.7 needs updating
Requirements to unlock own
Updating nginx from 1.17.7 to 1.23.3

But actual update fail (from logs):
...file_updater.rb:158:in `updated_yaml_content': Expected content to change! (RuntimeError)

Is this expected?
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
No response

cc @jeffwidman
@sozercan @ritazh fyi

Thanks @nilekhc
Can you try running it with the dry-run script locally while adding some puts statements or debugger statements to see where it's actually breaking?

@jeffwidman
Well, that dry-run script is not for anyone, especially in docker without debugger support.
Since the issue originated from the extension I maintain, I took the liberty to find the issue. The regex used to replace the content does not seem to account for the presence of single/double quotation marks. https://github.com/dependabot/dependabot-core/blob/3304cb60fb0e0774248c1cd45e085f6c3e09a7d1/docker/lib/dependabot/docker/file_updater.rb#L171
This can be resolved using by changing that line to include ["']{0,1} hence:
old_tag_regex = /^\s+(?:-\s)?(?:tag|version):\s+["']{0,1}#{old_tag}["']{0,1}(?=\s|$)/

With this sample, my output contains the following text, indicating it is fixed.
=> updating oss/azure/secrets-store/provider-azure from v1.3.0 to v1.4.0

    ± values.yaml
    ~~~
    20c20
    <     tag: "v1.3.0"
    ---
    >     tag: "v1.4.0"
    ~~~


Price checking doesn't work anymore.

Price checking doesn't work anymore.
I use to work like yesterday, but suddently stop working.
It gives the error of incorrect league, even so the correct league is checked
[16/03/2020 20:55:43] [warn] Failed updating poe.ninja prices, Error: The data from the requested Currency API (League: Delve) could not be processed because the format is invalid or the response is empty. Possible reasons: 1) Invalid league name, 2) poe.ninja is down, 3) poe.ninja changed their API structure
I am running Xernontrade on Manjaro, with the app.image.
I have tried deleting the locale folder of Xenontrade, check parameter again, but same issue.

Seems to be related to netwaord issue.. Issue not present anymore


Some minecraft bug that really doesn't want me playing minecraft

bug doesnt let me play minecraft or something lol
desktop is dell precision  its a laptop
windows 10 pro
JRE version: OpenJDK Runtime Environment Microsoft-22300 (16.0.1+9) (build 16.0.1+9)

A fatal error has been detected by the Java Runtime Environment:

EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x000000005fa32bfa, pid=4880, tid=12132

JRE version: OpenJDK Runtime Environment Microsoft-22300 (16.0.1+9) (build 16.0.1+9)
Java VM: OpenJDK 64-Bit Server VM Microsoft-22300 (16.0.1+9, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, windows-amd64)
Problematic frame:
C  [nvoglv64.DLL+0xf52bfa]

No core dump will be written. Minidumps are not enabled by default on client versions of Windows

If you would like to submit a bug report, please visit:
https://github.com/microsoft/openjdk/issues
The crash happened outside the Java Virtual Machine in native code.
See problematic frame for where to report the bug.

---------------  S Y S T E M  ---------------
OS:
Windows 10 , 64 bit Build 19041 (10.0.19041.1348)
Steps to reproduce the behavior:

be me
open minecraft
press play
See error

Expected behavior
not being able to play minecraft
Screenshots, Logs etc

fug u
On Sun, Nov 28, 2021 at 2:13 PM github-actions[bot] <
@.***> wrote:

Closed #173 https://github.com/microsoft/openjdk/issues/173.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/openjdk/issues/173#event-5681485559, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWWG63SLHSPRXZULKYE3D4TUOJ5PJANCNFSM5I5TUL6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@memesdealor mind to confirm whether you are using mods or a custom launcher?

i was using normal java launcher

Thanks @memesdealor for confirming. In that case, can you please submit this bug to Mojang's bug tracker?


fix: support install_rke2_version param for ubuntu

What type of PR is this?
(REQUIRED)

[x] bug
[ ] cleanup
[ ] documentation
[ ] feature

What this PR does / why we need it:
Before this small change install_rke2_version was ignored for non RH/Rocky.
Which issue(s) this PR fixes:
No listed issue as I've seen.
Special notes for your reviewer:
Change is very simple.
Testing

Run playbook with declared var install_rke2_version and without it on my ubuntu 20.04 farm.

Release Notes
Stops ignoring install_rke2_version for non RH based machines.

Thank you for the contribution @3sky, should be fixed in #155 . Please open a new issue/PR if it's still not working for you


Bitbucket CI Pipeline for TestContainers

Hello,
I have read the previous issue https://github.com/HofmeisterAn/dotnet-testcontainers/issues/333 regarding integration of TestContainer in CI Pipeline. I have a similar problem.
I use Bitbucket to run tests, here is my pipeline:
image: mcr.microsoft.com/dotnet/core/sdk:3.1

options:
  docker: true

pipelines:
  default:
    - step:
        script:
          - docker ps
          - dotnet restore
          - dotnet test ModelRunnerSvc.Tests
        services:
          - docker
        caches:
          - docker

Notice that I run docker ps in order two check if docker is available and it seems Ok.
When I run the pipeline, here is the result:
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:01.42]     ModelRunnerSvc.Tests.JobControllerTest.SubmitModel_GetJob_WhenCalled_ReturnsJob [FAIL]
[xUnit.net 00:00:01.46]     ModelRunnerSvc.Tests.JobControllerTest.Submit3Models_GetJobs_WhenCalled_Returns3Jobs [FAIL]
[xUnit.net 00:00:01.53]     ModelRunnerSvc.Tests.JobControllerTest.GetJob_WhenCalled_ReturnsEmptyResult [FAIL]
  X ModelRunnerSvc.Tests.JobControllerTest.SubmitModel_GetJob_WhenCalled_ReturnsJob [479ms]
  Error Message:
   System.Net.Http.HttpRequestException : Connection failed
---- System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Cannot assign requested address /var/run/docker.sock
  Stack Trace:
     at Microsoft.Net.Http.Client.ManagedHandler.ProcessRequestAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.Net.Http.Client.ManagedHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at Docker.DotNet.DockerClient.PrivateMakeRequestAsync(TimeSpan timeout, HttpCompletionOption completionOption, HttpMethod method, String path, IQueryString queryString, IDictionary`2 headers, IRequestContent data, CancellationToken cancellationToken)
   at Docker.DotNet.DockerClient.PrivateMakeRequestAsync(TimeSpan timeout, HttpCompletionOption completionOption, HttpMethod method, String path, IQueryString queryString, IDictionary`2 headers, IRequestContent data, CancellationToken cancellationToken)
   at Docker.DotNet.DockerClient.MakeRequestAsync(IEnumerable`1 errorHandlers, HttpMethod method, String path, IQueryString queryString, IRequestContent body, IDictionary`2 headers, TimeSpan timeout, CancellationToken token)
   at Docker.DotNet.ImageOperations.ListImagesAsync(ImagesListParameters parameters, CancellationToken cancellationToken)
   at DotNet.Testcontainers.Clients.DockerImageOperations.ByPropertyAsync(String property, String value, CancellationToken ct)
   at DotNet.Testcontainers.Clients.DockerImageOperations.ExistsWithNameAsync(String name, CancellationToken ct)
   at DotNet.Testcontainers.Clients.TestcontainersClient.RunAsync(ITestcontainersConfiguration configuration, CancellationToken ct)
   at DotNet.Testcontainers.Containers.Modules.TestcontainersContainer.Create(CancellationToken ct)
   at DotNet.Testcontainers.Containers.Modules.TestcontainersContainer.StartAsync(CancellationToken ct)
   at ModelRunnerSvc.Tests.JobControllerTest.SubmitModel_GetJob_WhenCalled_ReturnsJob() in /opt/atlassian/pipelines/agent/build/ModelRunnerSvc.Tests/JobControllerTest.cs:line 96
   at ModelRunnerSvc.Tests.JobControllerTest.SubmitModel_GetJob_WhenCalled_ReturnsJob() in /opt/atlassian/pipelines/agent/build/ModelRunnerSvc.Tests/JobControllerTest.cs:line 111

My test code use TestContainer, which use DotNet.Docker, which use Net.Http.Client and it fails when I try to execute:
await testContainer.StartAsync();
I suppose that the instructions given to Docker are behind...
In the previous post, you suggested:
In your first error, you are using docker socket -> /var/run/docker.sock , for this sample, you need to mount socket file.
I don't understand what you meant. Do you have a detailed suggestion to fix this behavior ?

I'm not familiar with the Atlassian Bitbucket pipeline, but I guess your example code will start a docker container based on mcr.microsoft.com/dotnet/core/sdk:3.1 and execute each script task.
Each script task is executed inside the container. It looks like the container does not provide the default Docker daemon endpoint for Unix  that Docker or Testcontainers usually use (/var/run/docker.sock). Unfortunately, the Atlassian Support documentation does not contain any further information.
It's common to expose /var/run/docker.sock to your container by mounting it. Or you configure an external Docker daemon and access it with WithDockerEndpoint.
What Docker daemon does your container use?

I'm not familiar with the Atlassian Bitbucket pipeline, but I guess your example code will start a docker container based on mcr.microsoft.com/dotnet/core/sdk:3.1 and execute each script task.
Each script task is executed inside the container. It looks like the container does not provide the default Docker daemon endpoint for Unix  that Docker or Testcontainers usually use (/var/run/docker.sock). Unfortunately, the Atlassian Support documentation does not contain any further information.
It's common to expose /var/run/docker.sock to your container by mounting it. Or you configure an external Docker daemon and access it with WithDockerEndpoint.
What Docker daemon does your container use?

Thanks for your help. I will google this case and post the issue to bitbucket. Hope I will find a workaround.

Thanks for your help. I will google this case and post the issue to bitbucket. Hope I will find a workaround.

I'll do some tests with my Bitbucket account too, when I have some time left.

I'll do some tests with my Bitbucket account too, when I have some time left.

If you take a closer look into the output of docker context ls or echo $DOCKER_HOST, you will notice that Atlassian Bitbucket exposes the daemon to tcp://localhost:2375 (in my pipeline). This is not the default endpoint. However, you can set the endpoint with WithDockerEndpoint. You should change your code to something like this:
var dockerEndpoint = Environment.GetEnvironmentVariable("DOCKER_HOST");
_container = new TestcontainersBuilder<TestcontainersContainer>()
  .WithDockerEndpoint(dockerEndpoint)
  .WithImage("alpine")
  .Build();

Notice .WithDockerEndpoint(dockerEndpoint) in the example above.

If you take a closer look into the output of docker context ls or echo $DOCKER_HOST, you will notice that Atlassian Bitbucket exposes the daemon to tcp://localhost:2375 (in my pipeline). This is not the default endpoint. However, you can set the endpoint with WithDockerEndpoint. You should change your code to something like this:
var dockerEndpoint = Environment.GetEnvironmentVariable("DOCKER_HOST");
_container = new TestcontainersBuilder<TestcontainersContainer>()
  .WithDockerEndpoint(dockerEndpoint)
  .WithImage("alpine")
  .Build();

Notice .WithDockerEndpoint(dockerEndpoint) in the example above.

I'll close this. If you need any further help don't hesitate to comment.

I'll close this. If you need any further help don't hesitate to comment.


Reward scheme for PGDrive v0.2.0

Note: This is not a normal issue and please don't close this. We use this issue to record the useful information on the reward scheme design.
Out of Road penalty and Steering Reward
(Trained with PPO, 100 envs.)

Conclusion:

Setting both of them to 0 is a good idea!
There two factors are highly coupled!

To Be Fulfilled!

Is this issue the same as #266 ?

Yes, but just leave it here.


Mod_Sharker/Cheat Engine Option

Would it be possible to add the option to use these patches with mod_sharker or cheat engine? I tried my hand at porting them myself but had little luck. They should have the same functionality and you can inject sharker using cheat engine.

Post the patches and I'll port them.

Well I meant the bitmap font, but I managed to port them to sharker myself once I figured out how your scripts worked.
Here is the ports
BitmapFont=1
NPCFastText=1
[BitmapFont]
Search1=80 BF 88 00 00 00 00 57 74 0D
Search2=80 BE 88 00 00 00 00 74 ?? B9 ?? ?? ?? ?? E8 ?? ?? ?? ?? 83 F8 01 75
Replace1=80 BF 88 00 00 00 00 57 90 90
Replace2=80 BE 88 00 00 00 00 74 ?? B9 ?? ?? ?? ?? E8 ?? ?? ?? ?? 83 F8 01 EB
[NPCFastText]
Search1=8B 08 33 FF 3B CF 76 2A
Replace1=8B 08 33 FF 3B CF EB 2A

Oh, you mean from kanan to sharker?
I took NPCFastText from sharker. As for BitmapFont, you'd need permission from Blade, since that's where it was reversed from.

Per our discussions so far, the Staff of mabimods.net and Blade want anything Abyss related removed.  I see that it was converted to mod_sharker, but being this was originally pulled from Abyss.  I'd say Blade still needs to give his blessing on this.  It's not uncommon for there to be mod_sharker versions and Abyss to have similar features.

Per this: https://github.com/cursey/kanan/issues/11
Blade's response at the bottom, and our chat:
[1:37:48 PM] Blade3575: Yeah
[1:38:17 PM] Blade3575: If someone had managed to figure it out on their own, from open source projects, I wouldn't have cared
On this basis the answer is no.  I'd suggest that you find an alternative source.  They are out there, or come up with your own please.

Closed since this isn't related to kanan.


Stable release of Front door API

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-go

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Already ARMSignedOff at private pull request 708

Automation for azure-sdk-for-js

Automation for azure-sdk-for-java

Can one of the admins verify this patch?

Automation for azure-sdk-for-net
A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/5581
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/5581/commits/0cf1d826268358f2a1d6fc2a8cf09ebe3566693b

@johsun-msft Can you please split this PR into 2 commits, one for the original API version and one for the new API version

This is already reviewed at https://github.com/Azure/azure-rest-api-specs-pr/pull/708, where the first commit is the copy, followed by few iterations. Can you look at that?

Recreated at https://github.com/Azure/azure-rest-api-specs/pull/5474


Rescue from Errno::EPIPE when sending a message

For issue #146

@jeremyevans  I am a tiny bit mixed on this, agree that eating the error is probably best, what do you think?

I agree that removing disconnected clients should probably not raise errors, but handling just EPIPE seems questionable (though it may work fine for puma).  Maybe rescuing IOError and SystemCallError?

Yeah, a wider net sounds like a good idea

Updated! Do you guys still like the spec that's there or should I try to raise anything else to verify it'll get caught?

I think this is fine, let's try it out.


Update closeOnEose example in readme

It says in the text that it makes sense to close the connection after fetching kind 0 events so we should be setting closeOnEose to true in the example

@pablof7z What @asoltys says is correct. Can you merge it?


size figures mobility flow

The size of the three individual figures in the mobility flow part is very small. It is hard to see anything. Maybe we could show the three plots one above the other instead of next to each other?
https://github.com/Ahobert/dash-oauni-oase/blob/789f6033d4610842be02433b3f0614f1f67135d8/International-Academic-Mobility/mobility_flow.Rmd#L61

I tried to put them in different rows, but it was not an observable change. Now I made the diagram higher and think it is better. Please check whether it makes sense now.
Von: Ahobert @.>
Gesendet: Mittwoch, 31. August 2022 17:33
An: Ahobert/dash-oauni-oase @.>
Cc: Momeni, Fakhri @.>; Assign @.>
Betreff: [Ahobert/dash-oauni-oase] size figures mobility flow (Issue #2)
The size of the three individual figures in the mobility flow part is very small. It is hard to see anything. Maybe we could show the three plots one above the other instead of next to each other?
https://github.com/Ahobert/dash-oauni-oase/blob/789f6033d4610842be02433b3f0614f1f67135d8/International-Academic-Mobility/mobility_flow.Rmd#L61
—
Reply to this email directly, view it on GitHubhttps://github.com/Ahobert/dash-oauni-oase/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACVMUTHQUCLWL4J4GBUA4MDV353MFANCNFSM6AAAAAAQBP2GLA.
You are receiving this because you were assigned.Message ID: @.***>

Unfortunately, I can not seem to make it well visible. I played around a bit with figure height and width and also with text size in the .R file. I think the problem is, that the figure width also affects the fontsize of the labels. I always just see the labels or nothing at all. Maybe we could change the labels to L, LM, UM, U and explain in the text what they mean? Or remove them and add labels at the very right and left of the whole plot, not for each single plot individually?

Look at this one please!

this is of course not good. I see something else from html file.

That does look better. Unfortunately, I can not include html files as subsites. A work around might be to create an image file (png for example or a vector graphic) and have a Rmd file where we just include the image. Still, it is puzzling that it does not work with the framework and navigation added. I managed by now to have the plot visible, but even if I enlarge the size, the resulting plots will not get bigger than in the image attached. I was wondering if maybe somehow there is some padding added around the single plots that prevents them from extending to the whole width of the lines below?

Actually, maybe it has got something to do with my browser (Firefox on ubuntu), because your html file look like this when I open it:

I think the problem is combineWidgets i used in the Rmd file. I changed the code a little. Changing the width in this combineWidgets could solve the problem.

This works better now. I actually think, it also might have something to do with my browser (Firefox) because when I open your html file I also seem to have this kind of box around the single figures (see image), which are therefore scaled to appear smaller than the width of the lines below would allow. There is still room for improvement, but I would leave it for now and focus on getting things online with Github actions. Maybe it appears correct there and if not we can try again then.


Using RavenDB as store

Has anyone experience of using this with RavenDB as the store?

No worries, I've implemented it using IMultiTenantStore .
Well designed and documented library  BTW, looking forward to next version

Excellent. FYI In the next version there will be a change to IMultiTenantStore to support custom TenantInfo classes. I doubt it will be major change to your implementation.


public: add analytics to explore and feed

analytics
hubspot
trackjs

close #6288
CR @xavijam, tested in ded05

:+1:

Thanks for adding trackjs too ;)

:bow: merging as soon as tests are :green_heart:


token-js: Version bump to 0.3.0

Problem
We've got loads of new functionality in the spl-token JS package, but it's not published!
Solution
Bump the version, and improve the README with some more info for people upgrading from 0.1.x and 0.2.0

cc @jacobcreech for awareness that we're publishing this new package


init openyurt chart repo

Use github as chart repo, for solve issue https://github.com/openyurtio/openyurt/issues/824.
Don't forget do the things below:

set workflow's write permission, as describe in github docs
create a branch called gh-pages

@huiwq1990 sorry, i have merged  a pull request about README at first, so please fix the README conflicting.

@huiwq1990 please fix README.md file conflict.

@rambohe-ch I create another pr solve the conflict.


Add more concurrency details to the documentation

I received a reply here regarding how concurrency works:

You can find the information about work distribution in concurrency mode in the documentation: "Tests are run concurrently against this pool, that is, each test is run in the first free instance." ... really long tests may result in one of the instances being idle

I'd like more clarification: Will one of the instances be idle only at the end of the test suite when there are n tests left, but > n instances? Or, can that happen in other situations?
What does it put in the pool and when? e.g., Does add each test in the whole suite upfront? Each test in a fixture, then move on to the next figure when it's depleted?

TestCafe will open the number of instances you specified. Tests are not pre-allocated across instances, but will be provided to each instance as they are released (test execution).
Regarding the stopping: no test will delay the execution of tests in other instances, but all instances can be closed only after the entire pool has been executed.
Tests from different files and fixtures will run in the same way as the tests inside the same fixture, if the fixtures do not have hooks. If a fixture has hooks, all instances will wait for the fixture to be completed.
You can learn more about the technical side of that issue in this conversation.

Also, we have recorded a task to update the documentation in accordance with your request: https://github.com/DevExpress/testcafe/issues/3951#issuecomment-781224586.

thank you for your reply. I want to confirm I understand the answer to this question: "Does it add each test in the whole suite upfront? Each test in a fixture, then move on to the next figure when it's depleted?" Let me ask it a different way:
Imagine you have two fixtures. Each has two tests. You run your suite with -c 3. There are no hooks involved.
When I start testcafe, will all 3 instances be executing tests, or only 2?
Thanks again!

All three instances will run tests. You can run this code to verify this as follows:
import { Selector } from 'testcafe';

fixture`Fixture 1`
    .page`http://devexpress.github.io/testcafe/example/`;

test('Test 1.1', async t => {
    await t.typeText('#developer-name', 'test 1.1').wait(1000);
});

test('Test 1.2', async t => {
    await t.typeText('#developer-name', 'test 1.2').wait(5000);
});

fixture`Fixture 2`
    .page`https://google.com`;

test('Test 2.1', async t => {
    await t.typeText(Selector('form input').nth(3), 'test 2.1').wait(5000);
});

test('Test 2.2', async t => {
    await t.typeText(Selector('form input').nth(3), 'test 2.2').wait(4000);
});


Responsive+nine-slice

It is possible to use them together? It may be very helpfull

I could make it work, but why not use Phaser's alignIn and alignTo methods that er new since 2.5?


Is there a rule for the Array.prototype.flat feature?

Hi :)
I'm missing a rule for the flat feature. Either I can't find it or there is no?
It should be part of the ES2019 set?
Other features from ES2019 are missing too?

Hi.
This plugin currently doesn't include rules for prototype methods because we cannot be sure of the object type.


Revert DnnImageHandler default dimension

Fixes profile pic image distortions and relates to #5291.  It also serves to replace pull request #5468.

This has been merged manually into the current 9.11.1 RC 3.  This will be addressed after the merge


Split Crest from Crest Examples using asmdef

Splits project into assemblies that have well-defined dependenices. This
will speed up the compile-time of things (only dependents have to be
recompiled) and will prevent us from accidentally calling-into example
code from the project.
Find more info here: https://docs.unity3d.com/Manual/ScriptCompilationAssemblyDefinitionFiles.html

Thanks dude!
Could you talk about the granularity in the examples - im wondering if only examples/scripts needs an asmdef, but interested to hear your thoughts.
Can you give a view on the below - I guess the vast majority of our users wont have asmdefs set up. Does it matter?

Note: Although it’s not required, whenever you use Assembly Definitions in a Project, you should do so for all of the code in your Project. Otherwise, when you change scripts in one of the predefined assemblies, Unity has to still recompile all the code in your Project, because the predefined assemblies automatically depend upon any assemblies you create using an Assembly Definition.

Could you talk about the granularity in the examples - im wondering if only examples/scripts needs an asmdef, but interested to hear your thoughts.

As Crest is a fairly small project code-wise, I don't think much granularity was needed beyond "put Crest in it's own assembly, and put each of the examples in their own asssemblies". Our existing folder structure was very amenable to this, I didn't need to update any code at all beyond make the helper height sampling classes public.

Can you give a view on the below - I guess the vast majority of our users wont have asmdefs set up. Does it matter? (Should there be a doc update somewhere to recommend people use them?)

Unity consider it best-practise for larger teams. But if they don't have asmdefs set-up this won't affect their workflow at all - the biggest change will be that when they make a change to their code, the crest code won't be recompiled which is a nice bonus.
People already using asmdefs will need to add crest as a reference in them, but considering they are already using them they should know how that works.


Tf-schema-gen-spp

Codecov Report
Attention: Patch coverage is 73.16017% with 186 lines in your changes missing coverage. Please review.

Project coverage is 57.85%. Comparing base (ac951f1) to head (645ee64).

Files
Patch %
Lines

py/atlas_init/cli_tf/schema_v2.py
81.51%
36 Missing and 20 partials :warning:

py/atlas_init/humps.py
44.44%
32 Missing and 8 partials :warning:

py/atlas_init/cli_tf/schema_v2_api_parsing.py
77.20%
25 Missing and 6 partials :warning:

py/atlas_init/cli_tf/schema.py
79.72%
20 Missing and 10 partials :warning:

py/atlas_init/cli_tf/app.py
19.23%
21 Missing :warning:

py/atlas_init/settings/config.py
0.00%
6 Missing :warning:

py/atlas_init/settings/rich_utils.py
0.00%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   53.38%   57.85%   +4.47%
==========================================
  Files          32       35       +3
  Lines        2510     3182     +672
  Branches      435      580     +145
==========================================
+ Hits         1340     1841     +501
- Misses       1125     1254     +129
- Partials       45       87      +42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


use setup.cfg metadata to set package version

This PR removes the code in the setup.py which grab the version form the code and use setup.cfg metadata notation
This is a personal opinion so feel free to ignore. (I also had difficulties trying to install the package using GitHub url, but not 💯 it was related to this)

can we merge this ?


Increase the default event limit to 256k

Plugin events are no longer capped at 64k, and we think 64k might be
too small for some plugins, so change the default to 256k.
Signed-off-by: Mark Stemm<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

My only concern is the memory footprint of the event batches. The default reusable event batch will allocate a memory buffer of size DefaultBatchSize * DefaultEvtSize, which until now was about ~32MBs. With this change, every source plugin would use ~132MBs of memory by default, which I think is a bit excessive.
Should we also decrease DefaultBatchSize to 64 or 128? Other than that, this looks fine to me!

My only concern is the memory footprint of the event batches. The default reusable event batch will allocate a memory buffer of size DefaultBatchSize * DefaultEvtSize, which until now was about ~32MBs. With this change, every source plugin would use ~132MBs of memory by default, which I think is a bit excessive.
Should we also decrease DefaultBatchSize to 64 or 128? Other than that, this looks fine to me!

I agree. My vote goes to decrease  DefaultBatchSize to 128 (so we will get the same memory footprint, ie. 128 x 256k = ~32MB). Although this choice is a bit conservative, we can reserve to perform an accurate benchmark and then fine-tune the defaults again.
Moreover, IMHO it is worth highlighting more in the documentation that these parameters can be easily configured by the plugin author.

Okay, I decreased the number of events and kept the event size at 256k.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, mstemm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 314c5528eb6c1febfdbe9ed1268660019a4a9ff4


Fix for sequelize >5.19

Error: TypeError: sequelize.ValidationError is not a constructor
Solved importing class Sequelize and get constructor from there instead of sequelize (without capital)

https://github.com/diosney/node-sequelize-noupdate-attributes/issues/4

@diosney any chance to look at my PR?

Merged.
Sorry it took too long, in a couple of days I should publish a new version after I do a quick refresher.

@diosney thanks, it's still relevant!


Ubuntu lucid has been deprecated

As of October 2017, Ubuntu lucid repositories have been removed, and therefore, vagrant can't  prepare the box with the required packages.

+1

+1

See PR #117 for a temporary solution


ClusterLoader - adding execute object logic

Adding handling for create and delete operations. Update operation is not a part of this PR.

/assign @shyamjvs

/lgtm


Code Release

@wenyuqing  thanks for sharing the wonderful work , cna you please elt us knw when is the code going to be released along with the pretrained weight files
Thanks in adavance

Hello, since the paper is currently under submission and there are some subsequent experimental plans, the timeline for releasing the code is uncertain. We welcome your interest and encourage you to stay updated!


Android Studio NoSuchMethodError

java.lang.NoSuchMethodError: No static method encodeBase64URLSafeString([B)Ljava/lang/String; in class Lorg/apache/commons/codec/binary/Base64; or its super classes (declaration of 'org.apache.commons.codec.binary.Base64' appears in /system/framework/org.apache.http.legacy.boot.jar)
at com.auth0.jwt.JWTCreator.sign(JWTCreator.java:330)

For Android if you just need to decode a JWT then you can use this one as the readme says.


New test scenarios

These are 4 additional tests to check that constraining to environment variables and chemical species -- as well as interpolation of the constraints -- work as intended.
At the moment the testing fails, probably because they have been created with the first-commit version.

Note: instructions in the wiki regarding .gitignore for the test suite are unclear. Should it be in the main directory of the test (foo)? what about the constraints directories and modelConfiguration?

I see - can you add another commit with the correct outputs based on the constraints files? Don't worry about copying and renaming by hand - just script it so that all the .output files get copied to the .output.cmp files, etc:
for file in *.output ; do cp $file $file.cmp ; done
run in each test folder will copy all those files, and do similarly for instantaneousRates files, e.g.
for file in *0 ; do cp $file $file.cmp ; done
Run make test again to check that all tests pass before pushing.

And on the topic of the .gitignore, it's probably best to have one per directory, if that directory ever contains things that should be ignored, e.g. the main directory of the test, and the instantaneousRates directory, as these have output files we want to ignore. As the constraints directories and modelConfiguration only ever have input files, there's not much point using a.gitignore, as all those files will always want to be part of the repo. Does that make sense?

A couple more issues to address that I've spotted so far: environmentalConstraints should be environmentConstraints.
Sometimes there are constraint files provided for environment variables that aren't constrained in the environmentVariables.config file - is this intentional?

Let me know when you want me to review this.

I am (slowly) working my way through the errors. What is the best way to proceed? put the constarints in the main directory rather than in the travis test directories and rerun them one at the time?
I also changed the gitignore in travis. I think a centralized version is easier to manage, but let me know if for some reason that's not a good idea.

The easiest way to proceed is just to run make test, as this will run all the tests, and output all the comparison files you need - you just need to rename those files, either by hand or as mentioned above.
I think the .gitignore will need work - .gitignore is not recursive, so the inclusion of *.config currently will only apply to the tests directory - you need to put e.g. !modelConfiguration/*.config. There are plusses and minuses to having only one .gitignore here, but I think it is probably a good idea actually, as each test has identical directory hierarchy.

Ok I will fix .gitignore
I am getting this error:
Running travis/tests/spec_no_env_yes2 ...
At line 735 of file inputFunctions.f90
Fortran runtime error: Bad real number in item 1 of list input

But the section of the code it is referring to is new I thinkand I am not sure what it is referring to.

Which test is this error happening in?
One thing I'd say is to remove the end lines in environmentVariables.config, as they are no longer needed. Take a look at the existing tests to see that I've removed these lines. This work isn't yet complete though, so some config files still have end and some don't. Take a look at an existing test to work out which!
Let me know if that doesn't solve this error.

Making progress....
Now I get this:
At line 760 of file inputFunctions.f90 (unit = 11, file = 'xH���*')
Fortran runtime error: File   './environmentConstraints/                                                                               BLHEIGHT' does not exist

it makes me think that it is adding extra spaces between the directory name and the file name in inputFunctions.f90
But i should not be the case as there is a trim() command on line 758

Ok, which test is this updated error occurring in?

All of them. Sometimes it gives gibberish:
(unit = 11, file = 'xH���*') Fortran runtime error: File './environmentConstraints/BLHEIGHT' does not exist

and sometimes nothing:
(unit = 13, file = '') Fortran runtime error: File './speciesConstraints/CH4' does not exist

The files do exist and the path seems correct to me. My guess is that it is not reading correctly the name of the constraint file, for some reason.

Hmm, that would seem to be the case. Can you try using file=trim(fileLocation) inside both OPEN statements?

No, it does not work.

I've just realised that this is because it's looking in the main ./speciesConstraint directory rather than a user-inputted one (which should be pointing to the test's subdirectory. Pull request wille be incoming in the next 10 minutes, once that is merged then please rebase this branch on top of that, (which will need some merge fixes, as I'll be editing some related lines) and it should hopefully then pass.

#117 is now in the master branch, so rebasing onto that should be enough. I haven't touched any of the same lines as here, so I'm hopeful the rebase won't even require merges. Let me know how you get on, and whether this fixes things!

 In any case. I get a slightly different error
At line 760 of file inputFunctions.f90 (unit = 11, file = 'xH���*')
Fortran runtime error: File 'environmentConstraintsBLHEIGHT' does not exist

There is a / missing, but apart from that the filename still appears to be gibberish.

That looks like exactly the correct procedure.
Once #118 merges (which fixes the slash, but also, importantly, actually makes the tests look in the correct directory) then I hope this will be fixed. Please rebase the same way after 118 is merged.
Sorry about the multiple rebases and slow progress - this is a completely untested part of the code, so I can't tell much of what's going on at your end!

#118 is now merged.

That's all right. Part of the idea of adding  new tests is to check and fix the code, after all!
It's almost there....
At line 760 of file inputFunctions.f90 (unit = 11, file = 'xH���*')
Fortran runtime error: File 'travis/tests/spec_yes_env_yes/environmentConstraintsBLHEIGHT' does not exist

Are you able to push your latest version? I'm losing track of what is and isn't in your version! I'm slightly surprised that the slash has been lost in that example. Does it always crash at this same spot?

Damn I made a mistake. I push to "master" not to "new_tests"! How do I go back?

Ah, hang on, you are referring to what's happening on Github rather than locally? If so, make sure you're on new_tests and then do git push origin new_test and ensure that shows up here. Then change to master, and do
git reset --soft HEAD~1,
check using git log that it all looks like you want it to, and then git push --force.

Okay, so I wanted to push new_tests to this PR, but instead of doing it from the branch, I did from master, by mistake. so now I cannot push new_tests because it is "behind the remote counterpart"

So, to clarify, you were on master and did git push new_tests ?

No, sorry, I stand corrected. I was on new_tests and did git push origin master

Ok, in that case:
git checkout new_tests
git push origin new_tests
git checkout master
git push (--force if it complains)

That's what I tried, but git push origin new_tests gives an error message: " Updates were rejected because the tip of your current branch is behind its remote counterpart"

Ok, use git push --force origin new_tests

Okay, sorry for the mess. I need to pay more attention which branch I am in!

I normally only use git push, without specifying the remote or branch, as it defaults to just pushing the current branch to the origin remote. This reduces the possibility of pushing to the wrong place! When rebasing, after git pull upstream master I do use git push origin master, but even that is probably not necessary.

Good idea. I pushed into the PR the current version (error message as in https://github.com/AtChem/AtChem/pull/116#issuecomment-298622052)

#119 should fix that issue (I've tried it on my machine and it completed, although the outputs were obviously not matching).

#119 is now merged to master.

Yes, finally! I will check the output differences before pushing. Thanks for your patience!

Based on my limited testing, I think you will need to also remove 'end' from each of constrainedFixedSpecies.config, constrainedPhotoRates.configandconstrainedSpecies.config`, in each test, otherwise you get some odd errors.

I will do that for the existing tests and base files, in a separate PR.

I think only constrainedPhotoRates, at the moment.

I think I understand all the differences between the new output and the old, except maybe for these files:
mainSolverParameters.output
sparseSolverParameters.output
stepSize.output
Can you check that the differences are due to your changes to the code?

Hi Roberto, are you able to update your master branch, and then rebase this on top of that? I have some changes I'd like to push to this branch, which fix 3 of the 4 failing tests, but can't overwrite your history in that way unless your history is up to date. Thanks!

The best way to avoid merge conflicts when you do the rebase on top of master in this context is
git checkout new_tests
git rebase -Xours master

That will prefer the master branch's changes over yours in the event of a conflict, which is what we need here.

I am surprised it failed. make test was successfull when I tried before pushing yesterday. But it fails now. I don't get it.
I have rebased as you suggested, but it fails with an error that makes me think it si not reading the filename correctly again
At line 281 of file inputFunctions.f90 (unit = 11, file = '')
Fortran runtime error: File 'travis/tests/spec_yes_env_no/environmentConstraints/                                                 end' does not exist

The issue is that in the meantime I have changed the way that the config files are read, so now the line 'end' is being read as a species to be constrained. That is one of the changes I've made to my version of your branch. Can you push the rebased branch here?

All right, but it doesn't let me push it
git push origin new_tests
To git@github.com:rs028/AtChem.git
! [rejected]        new_tests -> new_tests (non-fast-forward)
error: failed to push some refs to 'git@github.com:rs028/AtChem.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Merge the remote changes (e.g. 'git pull')
hint: before pushing again.

First ensure your master branch is updated locally with pull upstream master, then push that to origin. Then switch to new_tests branch, and push --force origin new_tests.

Let me know if it won't let you do that.

Sorry, I forgot.  I pushed it and the test has run and failed.

Ok, so I have one remaining issue - we're currently in a scenario where Linux passes but Mac fails. I'm rooting through to find the issue, but I don't think it is directly related to this test - the issue is caused because, when trying to interpolate at interpolationFunctions.f90 line 51, the routine overshoots the final data point provided for PRESS, because the final time of the simulation is 3600 but the final PRESS data point is also 3600. CVODE works by overshooting and then intepolating, but this is breaking the logic of the constraints parser here.
I think the solution here is to give PRESS a value at 3700 rather than 3600. Could you advise whether it's fine to leave the same value, or whether I should use another value?
This only skirts the issue for now, but this PR is already enormous, and this extra bit is not helpful to address here.
I'll open an issue for this, but once you let me know whether to use the same or a different value for PRESS at 3700 (this is in spec_no_env_yes2) I'll merge this PR.

@spco yes that is fine.
Actually, I did that on purpose, to check that the interpolation functions were working.  They are not necessarily related to that issue, but I think there is a problem with the interpolation. It may be as simple as a different interpolation method is needed.
I will change PRESS and push in a moment.

Yes - the issue I currently have is that OSX and Linux seem to output a different number Failed to lin int messages, and I'm not certain why - it must be doing a different number of iterations for some reason, but I'd rather merge this PR soon and treat that separately.
See #126 for the issue.

@spco Okay. I don't understand what is happening now. My master branch is even (both local and on github). My new_tests branch already has PRESS timestamp at 3700. So I have no changes to make, but the tests still fail on my machine. Am I missing something?

Is it just the one test spec_no_env_yes2 that's failing?

no. it's all of them, with the same error as this morning "Fortran runtime error: File 'travis/tests/spec_yes_env_no/environmentConstraints/                                                end' does not exist"
It looks like I am behind, but it tells me I am even. Also how did the change to 3700 ended up here?

show me git log --branches --graph --oneline --decorate

d5eb9ca (HEAD, origin/new_tests, new_tests) Correct reference outputs for new tests
dce6b0b Remove whitespace from fileLocationPrefix - 2
ab0579f Remove whitespace from fileLocationPrefix
03a3284 fac file needs to be as downloaded from MCM website
59cc1b9 Remove 'end' from config files
7e79fb9 Correct variable names
74c2d81 Rename environmentConstraints dir and delete unnecessary constaint files
756e024 Simplify .gitignore for travis directory
456b2da Add the constraints files
2cdff9a Add new tests to Makefile
3e82a58 Add 4 tests to check constraints and interpolation
e1cc1bf (origin/master, origin/HEAD, master) Remove 'end' from constrainedFixedSpecies.config, const
3a9d43c Correct the concatenation of slash to constraint filepaths.
2328246 Fix slash, and call cmd args in test_runner.sh.
3b67a3e Add parameters env_constraints_dir and spec_constraints_dir to module directories, and use.
8253d04 Add numdiff install script (#114)
| * 7ea60f0 (origin/install_numdiff, install_numdiff) Remove previous scripts
| * 81958ec Merge linux/macos scripts
| * 14f03be Version for osx; add some comments
| * e79bb81 Add numdiff install script
|/
0c4f285 Remove unnecessary explicit import.
95cf4c4 Use envVarNames and numEnvVars directly from module in getEnvVarNum, rather than passing in
8497601 Rearrange order of arguments of getEnvVarNum() to put output last.
c04e9dc Set intents within getEnvVarNum(), and comment.

Ah, we've lost the commits I put in. My fault. I'll add those on top.

But first, can you push your latest commit, with the edited PRESS value?

Just spec_no_env_yes2 PRESS value is currently at 3600, and needs to move to 3700 or something.

According to my system everything has been updated and there is nothing new to push.

Hm, ok. Leave it with me.

Hmm, I currently have the issue that the OSX and Linux versions give different results, just for spec_no_env_yes2. I think there is a sensitivity somewhere, which explodes due to rounding errors. I haven't yet got to the bottom of what specifically is causing it, or how to fix it.
What I propose is to extract that test out of this PR and into a new one, for further testing later. This PR can then just contain the 3 tests, and should pass.
Does this sound reasonable? I'll take the lead, as it will require some git-magic (and trial-and-error ;) ) to extract the necessary bits.

I've gone ahead and split the failing test off from the other three - that means we can incorporate the changes here into other PRs, as that's holding things up a bit. I'll open a PR afterwards which contains the 4th test.

Sorry, I thought I had replied, but clearly my message got lost. I think it is a good idea. I am also getting a little bit worried  about these interpolation / rounding errors.

@rs028 Never mind, I guessed as much. Thanks for bearing with us on this PR. It's been pretty epic, but exposed a number of flaws, which is what this all about!
The interpolation and rounding errors we can definitely look into. Perhaps we need another test or two, less complicated than spec_no_env_yes2, to delve deeper and work out what's going on. My current work on simplifying and unifying the code should help with that, so I propose to park this for a little while, and come back to it when the code is in better shape?

@spco All right. Yes it is good that we catch all these problems.
I will go ahead with my original task of sorting the DEC, SZA and H2O calculations.


Remove version: Bitnami.PrestaShop version <IP_ADDRESS>-0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://downloads.bitnami.com/files/stacks/prestashop/<IP_ADDRESS>-0/bitnami-prestashop-<IP_ADDRESS>-0-windows-x64-installer.exe
OK
(Automated message - build 910)

Version still available.


Visualiser for Ubuntu

How do I get the visualiser running for ubuntu? Could you please help me with this?

Hi,
The problem is the installation of openFrameworks. I think it's possible, but I'm not sure. Please refer to the following:
https://openframeworks.cc/setup/linux-install/
c.f., recently, I forked the visualizer from this repo:
https://github.com/Kei18/mapf-visualizer
Cheers,
Keisuke

Check https://github.com/kei18/mapf-visualizer


[WIP] Improve multi-file enum diagnostics

Given a setup where one file declares an enum and the other switches on it, decomposition fails because it can't get any useful interface types out of the AST.  Version 1 of this patch adds a short hack that just throws in the enum case constructor heads into the space and reports that back to the user because it's better than nothing, but there's got to be a better way to do this.
@slavapestov?

Why are there no interface types in the AST? The enum should be validated before it is referenced from inside any function bodies

Here's what I'm getting back from this setup:
// Test File 1
func f(_ x : Foo) {
  switch x {

  }
}

// Test File 2
enum Foo {
  case bar(Bool)
  case baz(Bool)
}

(lldb) p eed->dump()
(enum_element_decl "bar")
(lldb) p E->dump()
(enum_decl "Foo" interface type='Foo.Type' access=internal @_fixed_layout
  (enum_case_decl
    (enum_element_decl "bar"))
  (enum_element_decl "bar")
  (enum_case_decl
    (enum_element_decl "baz"))
  (enum_element_decl "baz"))
(lldb)

Ah, wait: This is an ordering problem.  I need everything in the other file to be type checked before I ask for the interface type of the enum decl.

Well, you don't want to type check everything in the other file -- that would be a performance problem. However, since the declaration 'Foo' is referenced here, probably all of the enum cases contained therein should also be validated. How was this working before?

You could try just calling TypeChecker::validateDecl() on the enum case decl before getting its type.

That works, but it means I have to thread an instance of the typechecker through this whole thing, and probably validate a lot of enum element declarations that will already go through validation.  Is there some later phase of semantic analysis I can stick this in to get around that?

Well, validating a decl more than once is a no-op. We validate all case members of referenced enums later anyway since we need that to compute layouts in IRGen.

@swift-ci please smoke test

@swift-ci please smoke test

Yep, that got it.
@swift-ci please test macOS platform

Yep, that got it.
@swift-ci please test macOS platform

@swift-ci please smoke test

@swift-ci please smoke test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - a0b7f57210787e1374b08d10b72d82e8e5e34669
Test requested by - @CodaFi

@swift-ci please smoke test

@swift-ci please smoke test

⛵

@CodaFi are you planning to merge this to swift-4.0-branch?

Along with your last pull request.  Just gonna take it all in that one place if that's OK.

That will be a good idea! Thank you!


Fix PyRe code.

https://github.com/cresset-template/cresset/blob/65bf29b33ac72b37da28916c795c420acf9a6c5d/Makefile#L134-L142
This code should be changed to allow it to be run from the host as well. Also create a local pre-commit hook using the Makefile command.

Add the official shellcheck pre-commit too.

Also add hist shortcut for history 1.


Mh terminate on finish

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report
Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (f6f1bc5) 46.73% compared to head (40153a4) 41.83%.

Files
Patch %
Lines

...obblin/temporal/ddm/NoWorkUnitsInfiniteSource.java
0.00%
12 Missing :warning:

...emporal/cluster/GobblinTemporalClusterManager.java
0.00%
4 Missing :warning:

...mporal/joblauncher/GobblinTemporalJobLauncher.java
0.00%
4 Missing :warning:

...cluster/ServiceBasedAppLauncherWithoutMetrics.java
0.00%
3 Missing :warning:

...bblin/temporal/joblauncher/GobblinJobLauncher.java
0.00%
3 Missing :warning:

...temporal/workflows/metrics/TemporalEventTimer.java
0.00%
3 Missing :warning:

.../org/apache/gobblin/temporal/yarn/YarnService.java
0.00%
2 Missing :warning:

...oral/ddm/launcher/ProcessWorkUnitsJobLauncher.java
0.00%
1 Missing :warning:

.../loadgen/launcher/GenArbitraryLoadJobLauncher.java
0.00%
1 Missing :warning:

...al/workflows/helloworld/HelloWorldJobLauncher.java
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
- Coverage     46.73%   41.83%   -4.90%
+ Complexity    11127     2197    -8930
============================================
  Files          2210      469    -1741
  Lines         87398    19903   -67495
  Branches       9609     2320    -7289
============================================
- Hits          40843     8326   -32517
+ Misses        42875    10693   -32182
+ Partials       3680      884    -2796

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug Fix] Fix the alias of GetV of ExpandBase in PathExpand, an…

…d the alias of PathExpand itself.

What do these changes do?

As titled. This fixes the bug in Problem 3 in issue #2757.
Related issue number

#2757

Codecov Report

Merging #2763 (a7a0f73) into main (a119c23) will decrease coverage by 31.58%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2763       +/-   ##
===========================================
- Coverage   72.96%   41.39%   -31.58%
===========================================
  Files          99       99
  Lines       10381    10381
===========================================
- Hits         7575     4297     -3278
- Misses       2806     6084     +3278

see 53 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a119c23...a7a0f73. Read the comment docs.


No getBinaryStream option for blob

Is your feature request related to a problem? Please describe.
Yes, i cannot pull in image from mysql

Hi,
Really sorry for the delay in getting this resolved for you, got a bit tied up on something and this caused some issues I hadn't realised due to larger data response being returned from the server which took me a while to pin down where the problem was.
However, I'm happy to say, this has now been resolved, so you can call getBlob(String columnName) from your MySQL row which will return you a byte[] array.
Then to get your image from the byte array in to your image view you would be able to do something similar to the following:
byte[] content = row.getBlob("ImageContent");
ImageView image = findViewById(R.id.test_image);
Bitmap bmp = BitmapFactory.decodeByteArray(content, 0, content.length);
image.setImageBitmap(bmp);

Let me know how you get on.
Thanks
Chris


TopRecommendations optimization

Make sure the TopRecommendations data structure is optimized and tested, that it maybe exported later on.

@mostafa-mahmoud I don't get what you mean by "export later on"

I meant if someone wanted to use it later in a separate project, then they can easily export your module, and it would be simple and optimized for such a purpose.