Hardwire bootstrap witnesses and key hashes to Ed25519

This patch allows the Shelley ledger to be instantiated with a DSIGN algorithm other than Ed25519. Previously, the Shelley ledger implementation was using the given DSIGN algorithm for everything, including bootstrap keys and witnesses. The algorithm had to be Ed25519 because that's the only way to validate a bootstrap (ie Byron) signature.
This PR is motivated by input-output-hk/ouroboros-network#2388 -- we'd like to continue to use MockDSIGN in the Shelley era of the Cardano TheadNet test.
I'm opening it as Draft and with an unverified commit to avoid accidental premature merge.
Please review thoroughly :) In particular, I expect that this initial diff violates some of your intended abstraction boundaries etc. I went for the straight-forward/minimal option in a few places.

I'm now going to start integrating @redxaxder 's recent changes into my related WIP branch in ouroboros-network. That'll be my first change to confirm these changes suffice for my motivation.

WARNING This PR changes the CBOR scheme. I don't understand the downstream costs of that yet.
That may very well be a reason to reject this (at least for now).

I'm now going to start integrating @redxaxder 's recent changes into my related WIP branch in ouroboros-network. That'll be my first chance to confirm these changes suffice for my motivation.

I've integrated the ouroboros-network branch to use this revision and the tests are passing! 🙌

I opened Issue input-output-hk/ouroboros-network#2488. It blocks this PR. The problem is how to handle the changes to serialization -- more details there.

Closing this PR, since it's been a draft for months. We can re-open if there's a pressing need.


Changing signature of extended input type field still casts to the old signature.

See below for a context and later I will describe result and expectation.
class FiltersFactory
{
    /**
     * @Factory
     */
    public function createFilters(?string $param = null): Filters
    {
        $filters = new Filters();
        if ($param) {
            $filters->add('param', $param);
        }
        return $filters;
    }
}

and now extended input
class FiltersDecorator
{
    /**
     * @Decorate(inputTypeName="FiltersInput")
     */
    public function addExtraFilter(Filters $previous, ?int $param = null)
    {
        if ($param) {
            $previous->add('param', $param);
        }

        return $previous;
    }
}

Query
product(filters:{param:"hello"})

Expectation without FiltersDecorator
Works well because param is of type string, so it's gonna be set through Filters factory
Result
The same
Expectation with FiltersDecorator
GraphQL throws an exception because param must by of type Int!
Result
The same

Fixed query
product(filters:{param:5})

Expectation
Works well because now type is int and param will be set through FiltersDecorat
Result
Internals throw exception String cannot represent a non string value: 5

Reporting this as a bug, but maybe overridding should not be possible in the first place, otherwise casting to old type should not happen. If I changed to int and sent int, then it's not string anymore.

@golaod I'm not entirely sure what you're looking to accomplish at the end of the day, but I'm doubtful that the Decorate annotation is best solution.  Nonetheless, I'm not sure, at least according to the docs, that it supports overriding an existing field.  I've never used the Decorate annotation, and would do my best to keep it that way.
Why not use another field here if it's of a different type?  Additionally, it's highly recommended in GraphQL to create more input types for different scenarios, as opposed to trying to do more with a single input type.

Closing til more information is provided


Refine replacement scenarios

Currently refining using this spreadsheet

The following scenarios have been selected by the team:

Default Scenario
RICS Replacement Rates
ASHRAE 240P Replacement Rates
Custom Replacement for one material with variable service life
Possibly Isuru's option, TBD after 11/5 discussion


[#166927205][Do not merge] Add PaaS-Admin Google OIDC Client ID/Secret

What

Script to migrate Google SSO users to have Google id's as usernames, given a CSV of email addresses and corresponding id's. This is a one-off script that needs to be run against each environment
Adds the paas-admin Google client ID and secret so non-GDS users to enable Google SSO
Maps the UAA username to the Google token sub

Please hold off merging until the migration work has been completed
How to review

Run the upload-google-oauth-secrets make task
~Review https://github.com/alphagov/paas-admin/pull/343~ done
~Review https://github.com/alphagov/paas-uaa-customized-boshrelease/pull/10~ done
~Deploy to your dev env~ done
~⚠ Update the paas-uaa-customized-boshrelease version~ done

Who can review
Not me

I'm now confident about everything but the upgrade script, which I'll look at tomorrow. 🚀


Update .xproj files for Microsoft.Web.AspNet.* -> Microsoft.DNX.* rename

no release branch in this repo?

will reopen on release branch


Add post-startup event mapping checks

[x] TypedEventHandler
[ ] AggregateState with explicit handlers
[x] MongoProjection when it supports registering handlers

Typed handlers will log the issue but not throw. It's because the check happens on construction, and types can be mapped later. It's not ideal but it increases visibility if the issue is there.


Blog Animation 2 - Physics

Physics Animations

This is a follow up to the first animation blog post. The first physics on more hard coded animations. This one describes working the animation stuff in the first post with a physics library like Box2D.


Metadata Wipe

Metadata should be wiped on server switch or at least the status effects the player has. At the current state, if a player gets effect on one server and switches to another server, he keeps those effects, which it seems can't be removed by plugins on downstream server after that ( ? ).

@TobiasG-DE Yeah youre right. I thought I could avoid the issue for a bit longer but it seems I need to do something about it. For now you could use the other transfer method if it bugs you too much

Turns out using the fast transfer method breaks the Players entitiy meta before the transfer as can be seen when you transfer to the Server you're already on. Only fixable by sending the clearing packets before

fixed in https://github.com/yesdog/Waterdog/commit/d45b26e40b00407db037d66ec2304be10e28e5ed


Optimize requirement list

For some not yet clear reason wheels are being built for dependencies in CI  rather than being picked up directly from pypi. (E.g scikit-learn seem to have perfectly good wheels)
Log: https://github.com/astroML/astroML-notebooks/runs/2734239271?check_suite_focus=true

Never mind, it's due to the temporary version limitation. However, we may still want to revise the requirement specifications, e.g. reconsider using conda-forge.

For now I've switched to use python3.8 to build and test as wheels exists for all dependencies.


Improve relevant search and fix bugs

Relevant search now only search according to the prefix specified.
Exception handled for invalid command input.

Codecov Report
Base: 55.99% // Head: 55.40% // Decreases project coverage by -0.59% :warning:

Coverage data is based on head (449bc79) compared to base (51ef319).
Patch coverage: 34.21% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
- Coverage     55.99%   55.40%   -0.60%
+ Complexity      663      658       -5
============================================
  Files           126      126
  Lines          2684     2702      +18
  Branches        327      328       +1
============================================
- Hits           1503     1497       -6
- Misses         1063     1086      +23
- Partials        118      119       +1

Impacted Files
Coverage Δ

...va/soconnect/logic/parser/SearchCommandParser.java
100.00% <ø> (ø)

...person/search/ContactMightBeRelevantPredicate.java
32.43% <32.35%> (-53.29%)
:arrow_down:

...n/java/soconnect/logic/commands/SearchCommand.java
70.58% <50.00%> (-7.99%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore(docs): add turbo as user in README

Add https://github.com/vercel/turbo as a user in README!
✔ Checklist:

[X] Commit messages have been written in Conventional Commits format;

Codecov Report
Base: 93.48% // Head: 93.48% // No change to project coverage :thumbsup:

Coverage data is based on head (06ad6a8) compared to base (c459ce2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   93.48%   93.48%
=======================================
  Files           9        9
  Lines         583      583
=======================================
  Hits          545      545
  Misses         38       38

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@tknickman Thank you 👍


feat: add testnet components to build

Add step for generating wasm and ci and add them to the artifacts in CI

build has to succeed

@lumir-mrkva the build has been fixed. Thank you. This PR can now be merged.


Fix GitHub Pages formating

Problem:
Some pages display the code block incorrectly. Mostly seen on the yaml and Environmental Yaml page.
Goal:
Update the pages to show the code block correctly.

Thank you!
When creating the page, we use the same convention to show a code block but it does not view the same on the GitHub page.
This is how it should look.

But this is how some code blocks look. This is what we need fixed.

Hey @npatel-cars I am working on the issue. If I am able to find a solution I will submit a Pull Request soon. Could you please assign this issue to me

Hey👋, I have made a Pull Request. I request you to review it once 😊.
Pull Request Link

Thank you @VividhPandey003! I have added a couple comments. I will continue to look through the rest.

Hey @npatel-cars just now saw your reply.
I'll make the changes. Working on it

Thank you very much. I will take a look and add more comments if needed.

Hello @VividhPandey003  it looks like the issue with the create page is still there

Sorry, i missed you comment in the PR.  Could you please apply to the other pages.


Remove I prefix from TS types

Standardizes all of the typescript types to drop the I prefix. For example IEvent is now just Event.
The only non-standard change is IInteractionMode which changed to InteractionModeMap because InteractionMode was already defined.

[!] TypeError: Cannot destructure property column of 'undefined' or 'null'.

Something collides?

Perhaps, but the TSC lint works. On the command line I see circular errors, but I think those are pre-existing.
types/core/index.d.ts -> types/platform/index.d.ts -> types/core/index.d.ts
types/core/index.d.ts -> types/platform/index.d.ts -> types/core/interfaces.d.ts -> types/core/index.d.ts
types/controllers/index.d.ts -> types/core/index.d.ts -> types/platform/index.d.ts -> types/core/interfaces.d.ts -> types/interfaces.d.ts -> types/controllers/index.d.ts
...and 9 more

I got the build working locally. I think we'll need to investigate the linter, some of these should have been caught by that. There were two bad imports (IFontSpec and IChartArea) that VSCode rename symbol had missed. No idea why the linter didn't catch that. There was also a conflict definition of FillTarget and DateAdapter became recursive.


Validation layer error in sample application

Hello
For current main (7942b798289f752dc23b0a79516fd8545febd718), I get this validation error on Windows 11 with CMake 3.26.3 and Visual Studio 17.10.3. The cube of the sample application is being rendered correctly though. The validation layer error is printed every frame (I am only showing one here in my logs).
Running VMA sample application on AMD Ryzen™ 9 7950X (AMD Radeon(TM) Graphics)
Vulkan Memory Allocator Sample 3.1.0
Vulkan API version used: 1.3
physicalDeviceProperties:
    driverVersion: 0x8000FA
    vendorID: 0x1002 (AMD)
    deviceID: 0x164E
    deviceType: 1 (INTEGRATED_GPU)
    deviceName: AMD Radeon(TM) Graphics
    limits:
        maxMemoryAllocationCount: 4096
        bufferImageGranularity: 1 B
        nonCoherentAtomSize: 128 B
physicalDeviceVulkan11Properties:
    maxMemoryAllocationSize:<PHONE_NUMBER> B (2.00 GB)
physicalDeviceVulkan12Properties:
    driverID: 1 (AMD_PROPRIETARY)
    driverName: AMD proprietary driver
    driverInfo: 22.40.40 (AMD proprietary shader compiler)

MEMORY HEAPS:
heapCount=3, typeCount=8
Heap 0: 268435456 B (256.00 MB) DEVICE_LOCAL, MULTI_INSTANCE
    Type 0: DEVICE_LOCAL
    Type 4: DEVICE_LOCAL, DEVICE_COHERENT (AMD), DEVICE_UNCACHED (AMD)
Heap 1:<PHONE_NUMBER>6 B (15.31 GB)
    Type 1: HOST_VISIBLE, HOST_COHERENT
    Type 3: HOST_VISIBLE, HOST_COHERENT, HOST_CACHED
    Type 5: HOST_VISIBLE, HOST_COHERENT, DEVICE_COHERENT (AMD), DEVICE_UNCACHED (AMD)
    Type 7: HOST_VISIBLE, HOST_COHERENT, HOST_CACHED, DEVICE_COHERENT (AMD), DEVICE_UNCACHED (AMD)
Heap 2: 268435456 B (256.00 MB) DEVICE_LOCAL, MULTI_INSTANCE
    Type 2: DEVICE_LOCAL, HOST_VISIBLE, HOST_COHERENT
    Type 6: DEVICE_LOCAL, HOST_VISIBLE, HOST_COHERENT, DEVICE_COHERENT (AMD), DEVICE_UNCACHED (AMD)

Conclusions:
- 2 heaps are DEVICE_LOCAL, total 512.00 MB.
- 2 heaps are HOST_VISIBLE, total 15.56 GB.
- 1 heaps are DEVICE_LOCAL and HOST_VISIBLE, total 256.00 MB.
- No types are HOST_VISIBLE but not HOST_COHERENT.
- No types are not DEVICE_LOCAL and not HOST_VISIBLE.
- 4 types are AMD-specific DEVICE_COHERENT or DEVICE_UNCACHED.
- No types are LAZILY_ALLOCATED.
- A buffer with VERTEX_BUFFER usage can be created in some non-DEVICE_LOCAL type.
- An image with OPTIMAL tiling and SAMPLED usage can be created in some non-DEVICE_LOCAL type.

Enabled extensions and features:
Validation layer: 1
Sparse binding: 1
VK_EXT_memory_budget: 1
VK_AMD_device_coherent_memory: 1
bufferDeviceAddress: 1
VK_EXT_memory_priority: 1
VK_KHR_maintenance5: 0

VUID-vkAcquireNextImageKHR-semaphore-01779 ║ Validation Error: [ VUID-vkAcquireNextImageKHR-semaphore-01779 ] Object 0:
handle = 0x3fbcd60000000028, type = VK_OBJECT_TYPE_SEMAPHORE; | MessageID = 0x5717e75b | vkAcquireNextImageKHR():
Semaphore must not have any pending operations. The Vulkan spec states: If semaphore is not VK_NULL_HANDLE it must not have any
uncompleted signal or wait operations pending (https://vulkan.lunarg.com/doc/view/1.3.275.0/windows/1.3-extensions/
vkspec.html#VUID-vkAcquireNextImageKHR-semaphore-01779)

Running VMA sample application on NVidia RTX 3090
Vulkan Memory Allocator Sample 3.1.0
Vulkan API version used: 1.3
physicalDeviceProperties:
    driverVersion: 0x8AD54000
    vendorID: 0x10DE (NVIDIA)
    deviceID: 0x2204
    deviceType: 2 (DISCRETE_GPU)
    deviceName: NVIDIA GeForce RTX 3090
    limits:
        maxMemoryAllocationCount:<PHONE_NUMBER>
        bufferImageGranularity: 1024 B
        nonCoherentAtomSize: 64 B
physicalDeviceVulkan11Properties:
    maxMemoryAllocationSize:<PHONE_NUMBER> B (4.00 GB)
physicalDeviceVulkan12Properties:
    driverID: 4 (NVIDIA_PROPRIETARY)
    driverName: NVIDIA
    driverInfo: 555.85

MEMORY HEAPS:
heapCount=2, typeCount=6
Heap 0:<PHONE_NUMBER>6 B (23.76 GB) DEVICE_LOCAL
    Type 1: DEVICE_LOCAL
    Type 2: DEVICE_LOCAL
    Type 5: DEVICE_LOCAL, HOST_VISIBLE, HOST_COHERENT
Heap 1:<PHONE_NUMBER>8 B (15.56 GB)
    Type 0:
    Type 3: HOST_VISIBLE, HOST_COHERENT
    Type 4: HOST_VISIBLE, HOST_COHERENT, HOST_CACHED

Conclusions:
- 1 heaps are DEVICE_LOCAL, total 23.76 GB.
- All heaps are HOST_VISIBLE.
- No types are HOST_VISIBLE but not HOST_COHERENT.
- 1 types are not DEVICE_LOCAL and not HOST_VISIBLE.
- No types are AMD-specific DEVICE_COHERENT or DEVICE_UNCACHED.
- No types are LAZILY_ALLOCATED.
- A buffer with VERTEX_BUFFER usage can be created in some non-DEVICE_LOCAL type.
- An image with OPTIMAL tiling and SAMPLED usage can be created in some non-DEVICE_LOCAL type.

Enabled extensions and features:
Validation layer: 1
Sparse binding: 1
VK_EXT_memory_budget: 1
VK_AMD_device_coherent_memory: 0
bufferDeviceAddress: 1
VK_EXT_memory_priority: 1
VK_KHR_maintenance5: 1

VUID-vkAcquireNextImageKHR-semaphore-01779 ║ Validation Error: [ VUID-vkAcquireNextImageKHR-semaphore-01779 ] Object 0:
handle = 0x3fbcd60000000028, type = VK_OBJECT_TYPE_SEMAPHORE; | MessageID = 0x5717e75b | vkAcquireNextImageKHR():
Semaphore must not have any pending operations. The Vulkan spec states: If semaphore is not VK_NULL_HANDLE it must not have any
uncompleted signal or wait operations pending (https://vulkan.lunarg.com/doc/view/1.3.275.0/windows/1.3-extensions/
vkspec.html#VUID-vkAcquireNextImageKHR-semaphore-01779)

Running VMA sample application on Intel Arc A770
Vulkan Memory Allocator Sample 3.1.0
Vulkan API version used: 1.3
physicalDeviceProperties:
    driverVersion: 0x19544A
    vendorID: 0x8086 (Intel)
    deviceID: 0x56A0
    deviceType: 2 (DISCRETE_GPU)
    deviceName: Intel(R) Arc(TM) A770 Graphics
    limits:
        maxMemoryAllocationCount: 4338804
        bufferImageGranularity: 1 B
        nonCoherentAtomSize: 1 B
physicalDeviceVulkan11Properties:
    maxMemoryAllocationSize:<PHONE_NUMBER>0 B (15.62 GB)
physicalDeviceVulkan12Properties:
    driverID: 5 (INTEL_PROPRIETARY_WINDOWS)
    driverName: Intel Corporation
    driverInfo: Intel driver

MEMORY HEAPS:
heapCount=3, typeCount=4
Heap 0:<PHONE_NUMBER>0 B (15.62 GB) DEVICE_LOCAL
    Type 0: DEVICE_LOCAL
Heap 1:<PHONE_NUMBER>8 B (15.56 GB)
    Type 1: HOST_VISIBLE, HOST_COHERENT
    Type 2: HOST_VISIBLE, HOST_COHERENT, HOST_CACHED
Heap 2: 268435456 B (256.00 MB) DEVICE_LOCAL
    Type 3: DEVICE_LOCAL, HOST_VISIBLE, HOST_COHERENT

Conclusions:
- 2 heaps are DEVICE_LOCAL, total 15.88 GB.
- 2 heaps are HOST_VISIBLE, total 15.81 GB.
- 1 heaps are DEVICE_LOCAL and HOST_VISIBLE, total 256.00 MB.
- No types are HOST_VISIBLE but not HOST_COHERENT.
- No types are not DEVICE_LOCAL and not HOST_VISIBLE.
- No types are AMD-specific DEVICE_COHERENT or DEVICE_UNCACHED.
- No types are LAZILY_ALLOCATED.
- A buffer with VERTEX_BUFFER usage can be created in some non-DEVICE_LOCAL type.
- An image with OPTIMAL tiling and SAMPLED usage can be created in some non-DEVICE_LOCAL type.

Enabled extensions and features:
Validation layer: 1
Sparse binding: 1
VK_EXT_memory_budget: 1
VK_AMD_device_coherent_memory: 0
bufferDeviceAddress: 1
VK_EXT_memory_priority: 1
VK_KHR_maintenance5: 0

VUID-vkAcquireNextImageKHR-semaphore-01779 ║ Validation Error: [ VUID-vkAcquireNextImageKHR-semaphore-01779 ] Object 0:
handle = 0xb097c90000000027, type = VK_OBJECT_TYPE_SEMAPHORE; | MessageID = 0x5717e75b | vkAcquireNextImageKHR():
Semaphore must not have any pending operations. The Vulkan spec states: If semaphore is not VK_NULL_HANDLE it must not have any
uncompleted signal or wait operations pending (https://vulkan.lunarg.com/doc/view/1.3.275.0/windows/1.3-extensions/
vkspec.html#VUID-vkAcquireNextImageKHR-semaphore-01779)

Looks like there is something wrong with swapchain management. I can't promise if I have time to look into this at the moment, but I will if I have the time.
best regards
Johannes

Adding vkDeviceWaitIdle(g_hDevice); at the end of DrawFrame() does "solve" the issue, but it should not be fixed like this in my opinion.

To make debugging of the sample application easier, we should make use of vkSetDebugUtilsObjectNameEXT, especially since it's already loaded in the current sample app, but not used yet.

By using vkSetDebugUtilsObjectNameEXT, I found out the issue is about g_hImageAvailableSemaphore, and not g_hRenderFinishedSemaphore.

Looks like this issue is also mentioned here: https://vulkan-tutorial.com/Drawing_a_triangle/Drawing/Rendering_and_presentation

Ah I think I found the problem: we need one semaphore for each swapchain image, not one semaphore for all.


[Feature Request] Add onHover to WhisperComponentType.Link

Hey @kingofclarkston, thanks for the feedback!
We've created HELPS-1699 evaluate this suggestion and will talk to our product owner about this feature request and update this ticket accordingly. Thanks for bringing this to our attention.

Hey @kingofclarkston, could you please provide more details for us? What methods/functions do you want to trigger when the link is  onHover?

@MaggieMaSS we are looking for the link to be underlined when hovering as shown in the Olive design docs.

@kingofclarkston  This feature has been released in Olive Helps 0.36.3 so I'll go ahead and close this issue! We really appreciate your feedback! Thanks!


[BUG] bottom pause/play, slider etc controls not longer responding after video started on IOS

[x] Issue does not already exist
[x] Issue observed on https://plyr.io

Expected behaviour
On iPad, after a video has been started playing using the large center play button the bottom controls should become visible after a tap anywhere on the video and the user must be able to interact with it. After 3 seconds of inactivity the bottom controls thould be hidden again.
Secondly: After having started the video using the bottom play button the bottom controls should hide after a few seconds
Actual behaviour
While a video is playing a tap on the video brings the bottom controls in view but they disappear immediately thereafter. (no 3 seconds wait) It is not possible to interact with the slider or the pause button.
secondly: after starting the video using the bottom play button the controls never hide.
Environment

Browser: Safari or Chrome
Version:
Operating System: IOS 11
Version: IOS 11 on iPad

Players affected:

[x] HTML5 Video
[not tested] HTML5 Audio
[not tested ] YouTube
[ not tested] Vimeo

Steps to reproduce

open Safari and goto https://plyr.io
start video using the large central play button
tap anywhere on the video area to bring up the bottom controls.
try to pause the video or user the slider. This won't work as the controls are immediately hidden again.

I've found a partial fix. Alter the code at line 2625 to this:
`            // If the mouse is not over the controls, set a timeout to hide them
if (show || plyr.media.paused || loading) {
_toggleClass(plyr.container, config.classes.hideControls, false);
            // Always show controls when paused or if touch
            if (plyr.media.paused || loading) {
                return;
            }
            // this is where the delay used to be.
        }

       // Delay for hiding on touch <-- moved here
       if (plyr.browser.isTouch) {
           delay = 3000;
       }

`
Basically I've moved the delay outside of the 'if' statement at line 2625. This activates the delay at all times on touch devices. This makes it possible for a user to interact with the bottom controls within 3 seconds.

Can you try this again in v3? I have a feeling this should be resolved but if not, feel free to re-open 👍


Kotlintest vs gradle

Please have a look at the individual commit messages for the details.

This change is

@mnonnenmacher, please give this some additional manual testing. I'm expecting the total number of tests on AppVeyor to be 232, and the number of skipped tests to be 42 (no kidding).


Reduce field of view of Camera

Should close #464

Bot please update snapshots.

Thanks @arjxn-py


SDK2: remove unused publicIPAddresses client

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-4665
What this PR does / why we need it:

This PR removes unused old publicIPAddresses client.
Now all publicIPAddresses clients used in cluster creation are SDK2.
Test plan for issue:

CI
Is there any documentation that needs to be updated for this PR?

just cleanup, N/A
How do you know this will function as expected in production?

cluster creation

/azp run e2e

/azp run ci

/azp run e2e


Fix repository= for failure_derive

As seen in https://github.com/withoutboats/failure_derive/issues/13,
metadata being incorrect is leading people to filing bugs in the wrong
place.

Thanks for the PR. To avoid asking you rebase, I've included your changes in https://github.com/rust-lang-nursery/failure/pull/345.


Integrate with External Wallets / Ledger

Problem
We want to support external wallets, but the current SDK doesn't provide support for it. To add external wallet support, we will likely need to update the SDK ComitClient to support providers. However, how this looks is not yet 'shaped up'.
Goal
Provide a document in coblox/spikes repo that summarises the approaches used in the blockchain ecosystem to support a variety of wallets for Ethereum and Bitcoin.
The document is structured as a Shape Up pitch: https://basecamp.com/shapeup/1.5-chapter-06
TODOs

[ ] Define current wallet interface and what functions the SDK uses
[ ] Research and summarize external wallet support / the Provider API in other projects

Liquality
Metamask
Ethers providers
0x subproviders
Ledger providers

[ ] Research what the Provider actually does and how the SDK can consume it

https://d2uvd02r4antif.cloudfront.net/docs/guides/web3-provider-explained#introduction

[ ] Recommendations for SDK

How the two implementations differ
What needs to be implemented on the SDK

Links
https://github.com/MetaMask/web3-provider-engine
https://github.com/Neufund/ledger-wallet-provider
https://github.com/liquality/chainabstractionlayer
https://github.com/blockmason/web3-provider-ledger
https://0x.org/docs/tools/subproviders

[ ] Evaluate using web3connect for Ethereum wallet integration

https://docs.metamask.io/guide/ethereum-provider.html

I would go for Ledger's JS Library. Integrating with it looks relatively straight forward.
From their readme here https://github.com/LedgerHQ/ledgerjs#basic-gist:
import Transport from "@ledgerhq/hw-transport-node-hid";
// import Transport from "@ledgerhq/hw-transport-web-usb";
// import Transport from "@ledgerhq/react-native-hw-transport-ble";
import AppBtc from "@ledgerhq/hw-app-btc";
const getBtcAddress = async () => {
  const transport = await Transport.create();
  const btc = new AppBtc(transport);
  const result = await btc.getWalletPublicKey("44'/0'/0'/0/0");
  return result.bitcoinAddress;
};
getBtcAddress().then(a => console.log(a));

Especially for Bitcoin you will need to manage the derivation paths ourselves<EMAIL_ADDRESS>
Not only that, you also need to figure out yourselves which UTXOs you want to spend and keep track of them. That is what LedgerLive is doing for you with their server APIs.
Running an Electrum server yourself instead of a bitcoind backend could be a good fit here as it allows you to query those things on-demand. Electrum's API would also work as a COMIT backend alternatively to btsieve and bitcoind.

What we want is probably a pluggable system of providers like what https://github.com/liquality/chainabstractionlayer has done.
Bitcoin ledger provider: https://github.com/liquality/chainabstractionlayer/tree/dev/packages/bitcoin-ledger-provider

Is there really so much duplication between wallet implementations that we need to abstract over that through a provider-like concept?
I think the trickier part is to actually make the whole system work.
The problem with Ledger is that we need to provide UTXOs in order to create valid transactions for funding. To do that, we would need to more or less run arbitrary queries against the UTXO database of bitcoind and that is something that the node is not really optimized for.
We would have to register the account stored on the ledger as "watch-only" account in bitcoind and have it scan the blockchain before we could use that.
Electrum-server on the other hand supports these kind of queries fairly well on-demand if I am not mistaken.
At least for the foreseeable future, we can assume that cnd is going to be running on the same machine as an application built on top of the SDK.
Hence, it makes sense to reuse the same "backend" for both services.
At the moment, this backend is bitcoind which fulfills the following needs:

providing a wallet (used via the RPC interface from the SDK)
providing blocks (used by cnd to watch the blockchain)

With Electrum-server, I believe we can also query arbitrary blocks and hence we can satisfy cnd's needs for this backend.
With the arbitrary query for addresses, we should be able to fulfill the needs to interact with Ledger.

For ledger-live-common, looks like there's an example here: https://github.com/LedgerHQ/ledger-live-common/blob/master/docs/gist-tx.md

@thomaseizinger

Is there really so much duplication between wallet implementations that we need to abstract over that through a provider-like concept?

I was thinking we need this for the SDK to support Ledger because the ComitClientright now only accepts the SDK wallets: https://github.com/comit-network/comit-js-sdk/blob/dev/src/comit_client.ts#L20-L43

@thomaseizinger

Is there really so much duplication between wallet implementations that we need to abstract over that through a provider-like concept?

I was thinking we need this for the SDK to support Ledger because the ComitClientright now only accepts the SDK wallets: https://github.com/comit-network/comit-js-sdk/blob/dev/src/comit_client.ts#L20-L43

@yosriady So the ComitClient actually just needs a very limited subset which could be hidden behind an interface that every wallet has to implement. I thought actually that we had already done that :thinking:

For ledger-live-common, looks like there's an example here<EMAIL_ADDRESS>
This is interesting! It seems like the UTXO scanning is abstracted away here, cool :)
cc @luckysori @bonomat

@yosriady

For ledger-live-common, looks like there's an example here: https://github.com/LedgerHQ/ledger-live-common/blob/master/docs/gist-tx.md

Cool, looks easier than I thought :D
@thomaseizinger

@yosriady So the ComitClient actually just needs a very limited subset which could be hidden behind an interface that every wallet has to implement. I thought actually that we had already done that 🤔

EDIT: It seems we did it for Bitcoin but not for Ethereum.

Yes, we never needed it for Ethereum. As far as I remember I initially extracted the BitcoinWallet interface so that I could build a testnet wallet :) mmhmm... bcoin... good memories 😅

wups

@yosriady So the ComitClient actually just needs a very limited subset which could be hidden behind an interface that every wallet has to implement. I thought actually that we had already done that 🤔
EDIT: It seems we did it for Bitcoin but not for Ethereum.

Yes, and we'll need to implement a 'provider' or 'adapter' for the Ledger so we can use it in the SDK.

@da-kami / @yosriady :
I gave LedgerJS a try on the weekend. Using the library is not that hard and it works pretty much out of the box.
Testnet/Ropsten support was also straight forward, I wasn't able to use a custom network (e.g. regtest on Bitcoin) with the current setup.
This shouldn't be a problem for Ethereum (we could follow this example here):  but for Bitcoin it might be a bit more complicated.
https://github.com/bonomat/ledgerjs-example

ledger integration done already, outdated.


How to reload router when on the same route?

How to reload router when on the same route?

@benag From application context call refresh() function:
this.refresh();

http://sammyjs.org/docs/api/master/all#Sammy.Application-refresh


Opposite of no_overlap

Hi, I am using python for CP solving.
I would like to know if there is constraint that does the opposite of no_overlap.
This will be like
overlap(interval, arr, n)
interval - single interval variable
arr - array of interval variables
n - positive integer less than length of arr
this will mean that atleast n interval variables from arr overlap in the interval of interval
This is for a situation in job scheduling when a job is not possible to be scheduled on a machine because there are already n higher priority jobs.

Hello, you can use the overlapLength expression to know how much overlap there are between two interval variables.  This way you can count the number of non-zero overlaps between 'interval' and all the elements of 'arr'.  Something like:
mdl.sum([mdl.overlap_length(interval, a) > 0 for a in arr]) >= n

Hello,
Thanks for the reply, but actually what I need is a bit more complex.
I need that whenever interval starts then n intervals from a set have already started or start parallelly with interval. that is something above the overlap constraint


Add setRequestDecoder to ResponseEncoder interface

Commit Message: Add setRequestDecoder to ResponseEncoder interface
Additional Description: This change was introduced in #23648 but was moved into a separate PR given its more general scope.
Risk Level: Low
Testing: No tests added.
Docs Changes: N/A
Release Notes: N/A

/assign @alyssawilk

/retest


Resume edit

👷 Deploy Preview for fancy-puffpuff-df775f processing.

Name
Link

🔨 Latest commit
caf853e3a66a31119fed537c4fc129bdc38502d4

🔍 Latest deploy log
https://app.netlify.com/sites/fancy-puffpuff-df775f/deploys/66678e371bd2d40008ab17a0


Weaken hypotheses for proof that Noetherian is an extension property

The middle term of a three term exact sequence with outer terms Noetherian is Noetherian.

Also please start the PR title with feat: or chore: etc. See https://leanprover-community.github.io/contribute/commit.html for details.

Kind reminder: this still fails CI

Sorry, I was headed into a movie and trying to get the PR fixed on my phone before it started (I did not succeed).

maintainer merge

No worries. Thanks for the contribution!

Thanks!
bors merge


Fix child / parent destructor ordering.

The order that was originally implemented here in the polyfill is precisely what the RFC specifies (see here):

Mark the destroyable such that isDestroying(destroyable) returns true
Schedule calling the destroyable's destructors
Call destroy() on each of the destroyable's associated children
Schedule setting destroyable such that isDestroyed(destroyable) returns true

However, when implementing we determined that the order should actually be slightly different:

Mark the destroyable such that isDestroying(destroyable) returns true
Call destroy() on each of the destroyable's associated children
Schedule calling the destroyable's destructors
Schedule setting destroyable such that isDestroyed(destroyable) returns true

This is specifically so that we can unify the destruction semantics between those of Ember.Object/CoreObject and what is done in the rendering engine:
<EMAIL_ADDRESS>
This updates the destruction ordering to match what was implemented (and released) in Ember 3.20.0+.

/cc @pzuraq


Generating the code behind files failed with model builder error on the Train page.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2019: <IP_ADDRESS>7301 (Main Build)
Microsoft Visual Studio Enterprise: 2019(16.11.15)
.Net Core: 5.0
Describe the bug

On which step of the process did you run into an issue:
Click the "Start training" button on the Train page.

To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window;
Choose the C# Console App and .NET Core 5.0 project template;
Add model builder by right click on the project;
Select any scenario, input the data source, then start training.
When generating the code behind files, you will see the error:
"Deserializing JSON-RPC result to type TrainResult failed with FileNotFoundException: Could not load file or assembly 'System.Text.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified."

Expected behavior
Can generate the code behind files successful.
Screenshots:

Additional context:
The bug is only repro on VS2019, not repro on VS2022.

The bug has been fixed on the latest main branch <IP_ADDRESS>7601.


distgit.py: work around OSBS bug

This is an ugly hack to work around an OSBS bug regarding multiline statements.
For now, combine into single line.
Revert this once a fix appears.
I did test this on a few rebases to see that it worked...

/lgtm
seems legit. Let's give it a shot and see if it works!


JoltC dll get not found after publish.

After publishing my project the .dll get not founded unpublished it works fine

Source code: https://github.com/MrScautHD/Sparkle

How do you publish? Send me the publish command? Is it:
dotnet publish -r win-x64 -c Release

dotnet publish -c Release -r win-x64 --self-contained -o ./PUBLISH

I tested a few pcs now and it looks like that just happans on old ones.

But wierd that it not could find the .dll

So, does it work?

For my main pc and my laptop yes for anything else that is older then 4 years not.

Is there a minimum requirement for the processor?

Well, I don't know, ask on dotnet runtime repo.


EndpointIdentifier property is missing from dms.Endpoint

Cloudformation supports this property but troposphere does not.

I opened #1117 to resolve this issue


Allow passing options to puppeteer.connect call

I wanted to trying pass a slowMo value to puppeteer.connect call. But it seems like puppeteer.connect is called with fixed values.
It would be great if the connect method took a third optional argument as extra options to be passed to puppeteer.connect call.
E.g.
  browserForPuppeteer = await pie.connect(app, puppeteer, { slowMo: 500 });

This is a great suggestion, I'll definitely add that. Sorry for the late response!

Nothing to be sorry about. It's free work you are doing for others.
I am thankful for your work. Couldn't have made my application without puppeteer-in-electron.

Sorry for taking so long. I ended up implementing this (and I still think it's a good idea to be able to pass options in that way), however the option slowMo actually causes some pretty bizarre behavior in electron and even breaks this project. I don't think that option was ever tested on electron.


Tinkers Construct Tables and TrashSlot broken

Using TrashSlot_1.11.2-7.4.5\TConstruct-1.11.2-<IP_ADDRESS>
On the crafting station, the  slot is right in the middle of the gui, and the trash icon is offset.
The other tables have even more, and the slot doesn't dock.
Tried moving it, but then everything else is messed up
Tried adjusting window size, and UI size, it's the same.

Can confirm (same mod versions)...
https://ibb.co/mNC9WQ

Turns out the "real" issue was that all GUIs shared the same settings for the TrashSlot, so moving them in one would also move them in another, and as a result, the TrashSlot would be enabled for all screens by default (even though it was meant to be 'turn on at your own risk' thing for mod GUIs).


Start as Enabled

Hi there, I'm not a JS coder.
How can I start this as already active?
I'm running some selenium test and got a CSP block of my get_har script.
This workaround works well but I need to start it as already active.
I've messed a little bit with the code but I was not able to do it :D
Any suggestion? Thanks!

Hello.Sorry to keep you waiting for so long.
So you wanna rewrite the code and make it always active but not have to click the icon at every page.Is this what you mean?
In the line 43,you have to set the urlFilter's value with *.
And you click the icon,it works at every page until you close the explorer.
In the function isCSPDisabled,remove variables urls and url.
Rewrite it to a funtion that checks the variable rules' length is 0 or not.
That's all.


Send PONG replies using the parameter sent from the client

Fixes issues with clients like hexchat not being able to correlate sent pings and displaying them as noise in the server buffer.
  irc-client Rx: PING irc.gitter.im +9s
  irc-client Tx: :irc.gitter.im PONG irc.gitter.im :irc.gitter.im +0ms
  irc-client Rx: PING LAG1489229945904 +19s
  irc-client Tx: :irc.gitter.im PONG irc.gitter.im :LAG1489229945904 +0ms

rfc1459 (but as you can see above, in practice the server2 parameter isn't used as such)

Any chance of this being merged?

@MaxLeiter This project has moved to GitLab, it will be merged over there https://gitlab.com/gitlab-org/gitter/irc-bridge/merge_requests/91 eventually (in the last few weeks, I have been working on Gitter full-time again so hopefully sooner rather than later)

@dequis We will merge over on GitLab. To restore, we can just apply https://gitlab.com/gitlab-org/gitter/irc-bridge/merge_requests/91.diff to a new branch and push it up.
Feel free to create new merge requests so that the author points back to you properly


IMBA Lifesteal items

Includes not-really-imba Morbid Mask, IMBA MoM and IMBA Satanic.
Equipping those items grants a special green particle to ranged attackers!

Merged manually


Small improvement: fix error logging in AllTransmitted test

Don't mind about errors on go/dev, they want to make it failing on their CI


Fix typo

@ofek please keep in mind this is a dynamically changing repository.
I will be adding more stuff here these days.


【Requirements for new features】Modifying and customizing the base time （which is always the current time now）

As depicted in the title, users may want to assign the base time by themselves.
One user case is that I know about the early-rejection time and I may make plans for the incoming conferences. It is convenient to set the base time to the early-reject time.

Reasonable and valuable, we plan to add this feature in the near future.


scale line control does not always show

To reproduce go to the scale-line example, choose nautical miles and type map.getView().setZoom(15) into the console.
Initially reported here:
http://stackoverflow.com/questions/29333183/openlayer3-scaleline-does-not-show-nautical
What happens is that i becomes -3 in
  var i = 3 * Math.floor(
      Math.log(this.minWidth_ * pointResolution) / Math.log(10));

and the div will be hidden. I'm guessing the code needs to be enhanced to show fractional values in this case.

You can also see this behaviour at the official example: http://openlayers.org/en/v3.12.1/examples/scale-line.html
The nautical scale-line shows up down to a scale of 1nm. If you zoom in further it disappears.

Will be fixed with #4629.

Sounds great. Thank you!


[reproducible] watch doesn't work for javascript/scss files

Submit a feature request or bug report

[x] I've read the guidelines for Contributing to Roots Projects
[ ] This is a feature request
[x] This is a bug report
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse forums

What is the current behavior?
webpack watch doesn't work for javascript/scss files.
What is the expected or desired behavior?
webpack watches javascript/scss files and recompile when these source files have been modified.

Bug report

Please provide steps to reproduce, including full log output:
Reproducing the issue
(https://github.com/roots/sage#theme-installation):
$ composer create-project roots/sage test-watch dev-master

Generating autoload files
Do you want to remove the existing VCS (.git, .svn..) history? [Y,n]? > Roots\Sage\PostCreateProject::updateHeaders
Define theme headers. Press enter key for default.
Theme Name [Sage Starter Theme]:
Theme URI [https://roots.io/sage/]:
Theme Description [Sage is a WordPress starter theme.]:
Theme Version [9.0.0-beta.3]:
Theme Author [Roots]:
Theme Author URI [https://roots.io/]:
> Roots\Sage\PostCreateProject::selectFramework
Select a CSS framework (Default: Bootstrap)
  [0] Bootstrap
  [1] Foundation
  [2] None
> 2
> Roots\Sage\PostCreateProject::addFontAwesome
Add Font Awesome? [y,N]?
> Roots\Sage\PostCreateProject::buildOptions
Configure build settings. Press enter key for default.
Path to theme directory (eg. /wp-content/themes/sage) [/app/themes/test-watch]:
Local development URL of WP site [http://example.dev]:

$ cd test-watch/
$ (nvm use v6)
$ yarn install
$ yarn run start

(Optionally clean up the dist/ folder)
Modify files in resources/assets/styles/ or resources/assets/scripts/.
Notice that webpack doesn't recompile, also notice that
nothing changed in dist/ folder / that there is still no dist/ folder.
Optionally invoke yarn run build and notice that now the files in dist/ folder have
been updated / dist/ folder together with these files has been created.
Please describe your local environment:
WordPress version: (not applicable)
OS: Ubuntu 16.04.2 LTS
NPM/Node version: v6.10.3
Where did the bug happen? Development or remote servers?
Development/workstation
Is there a related Discourse thread or were any utilized (please link them)?
https://discourse.roots.io/t/webpack-watch-doesnt-work-for-scss-js/9587

as already mentioned to you on discourse, this is not a current bug and you're probably dealing with a configuration issue. please don't use github for personal support requests.


Automated Package Upgrade

:tada: This PR is included in version 6.0.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Shubham Hadake

Due we close new issues on PR merge and voting is still possible on closed issues I will close this one.


Do not attach dragNode behavior in browse mode

Currently when in 'browse' mode (i.e. when nothing is selected) it is very easy for a user to accidentally drag a point when they are trying to move the map. This is not currently the case for lines or areas: they must be selected before it is possible to move anything.
This PR changes the browse mode so that it does not attach the DragNode behavior to points. The new behavior is that you need to select a point first before dragging to move it.
This is to reduce the possibility of users accidentally moving points without realizing when they are just trying to move the map. This is a particular issue in areas of the map where there is a high density of points, which makes it almost impossible to drag the map without accidentally moving a point. This fixes that.

This is a great idea.. I've been frustrated before too when I try to drag the map and end up dragging a node by accident.
I checked it out and one thing I noticed is that with this change, yes you can't drag points in browse mode, but you can drag any point in select mode, even a point that's not actually selected.  It's a little strange.
Maybe here in DragNode can you try to cancel the drag behavior if the entity is not in the selectedIDs array?   You might also need to expand the whitelist to include nodes that are children of way seletedIDs or members of relation selectedIDs, I'm not sure.

You might also need to expand the whitelist to include nodes that are children of way seletedIDs or members of relation selectedIDs, I'm not sure.

Pretty sure this will be necessary. When a way is selected, you should be able to move its vertices without first selecting them -- otherwise realigning roads will be extremely tedious.

This was finished in #3739


Run task just once

Is there a idiomatic way of scheduling a task to run just once? That is to say, create a schedule that is ran once and then cleared?
The only way I can think of is:
func scheduleOnce() {
  s := gocron.NewScheduler()
  s.Every(1).Day().At("10:30").Do(foo, s)
  <- s.Start()
}

func foo(s *gocron.Scheduler) {
  // My code
  s.Clear()
}

Which I haven't actually tested yet but I figured this would be a solution to my problem.

Seems that this tool is only for periodical tasks

Seems like it from the responses... I ended up not using this tool for it and found a really good way to schedule a task to run once at a specific time.

Thanks for the feedback @danhardman. I think we should add an easy way to schedule a task to run one time in the future. @puzanov is correct for now, gocron is just for recurring tasks.

Hello everybody! thid feature implemented? can i use it?

@danhardman Would you mind sharing the code if you still have it? It would help me a great deal

@danhardman Would you mind sharing the code if you still have it? It would help me a great deal

Run once:
_, _ = s.Every(1).Millisecond().LimitRunsTo(1).Do(task)
If you inspect the scheduler after this executes the task is no longer present in the scheduler.


no skip urls list - add firefox portal detection url

This PR adds the firefox captive portal detection redirect URL to the no-skip list.
Problem: currently, wifi redirect pages that use the Firefox captive portal URL in a parameter are redirected by the extension, breaking the captive portal login in many cases.

I am not sure I understand the problem. It sounds like the captive portal detection is a Firefox feature that does stuff in the background. Why would a wifi portal have the URL in their URL?

I am not sure I understand the problem. It sounds like the captive portal detection is a Firefox feature that does stuff in the background. Why would a wifi portal have the URL in their URL?

I had this case with Boingo hotspot: https://wifi.boingohotspot.net/stl.hotspot/?dst=http://detectportal.firefox.com/canonical.html&link_login_only=https://via.boingohotspot.net/login&link_login=https://via.boingohotspot.net/login?dst=http://detectportal.firefox.com/canonical.html&link_logout=https://via.boingohotspot.net/logout&link_status=https://via.boingohotspot.net/status&nas_identifier=ccg_stl-via1&hostname=via.boingohotspot.net&identity=via-2.0&ip=<>&mac=<>&GSID=<>&vlan_id=3&__c9auth=1
I guess maybe it doesn't make sense to add exclusions for this
I'm maintaining a list of exclusions at https://gist.github.com/wesinator/a1d7aeed25a17d01ccec91e1188de6fd

I am going to close this. People with the same problem should be able to find this issue and your list can help them. Thanks!


Support for GitHub Actions CI

I suspect we can get away with working out a scheme where CI systems somehow tag/label the comment they create/update. So for each PR there would be two plot comments, one for Actions and one for Pipelines, each updated by their respective job.

Annoyingly, making an Env for Github Actions is not straightforward because:

There's no way to detect an action run is for a PR
There's no way to tell what the target branch for a PR

Less critically, but still annoying, there's no human-friendly YYYYMMDD.N build number like in Pipelines, the run id seems to be a uuid while the run number is an auto incrementing integer.
I can think of some crude hacks that would work for simple repos (configure a single target branch per repo for example), but I'll do some more research first in the hope of finding something better. If anyone has ideas, I'd love to hear them.
Sources:
https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
Test run under https://github.com/jumaffre/cimetrics/pull/94/checks?check_run_id=703792019

Found https://github.com/jwalton/gh-find-current-pr but that needs an auth token. Ugh.

GITHUB_TOKEN is always available, this should just work.

@letmaik ah yes, indeed. It's annoying to have to configure this as a dependency though.
Since it's just a single request, I guess we may as well do it ourselves.


[BUG] Converting to cv::Mat causes segmentation fault

Describe the bug
I'm trying to use OIIO for reading some files OpenCV can't read.
I made a minimal example: https://github.com/abrock/oiio-bugreport
The program is supposed to read an image, convert it to cv::Mat and print its dimensions but instead I get a segfault with this backtrace:
1 __memmove_avx_unaligned_erms                                                                                memmove-vec-unaligned-erms.S 396 0x7ffff64d43d5
2 OpenImageIO_v2_2::copy_image(int, int, int, int, void const *, long, long, long, long, void *, long, long, long)                                                                                0x7ffff7bb0bcd
3 OpenImageIO_v2_2::parallel_convert_image(int, int, int, int, void const *, OpenImageIO_v2_2::TypeDesc, long, long, long, void *, OpenImageIO_v2_2::TypeDesc, long, long, long, int)                                  0x7ffff7bb35f8
4 OpenImageIO_v2_2::ImageBufAlgo::to_OpenCV(cv::Mat&, OpenImageIO_v2_2::ImageBuf const&, OpenImageIO_v2_2::ROI, int)                                                                                0x7ffff7aff1bf
5 main                                                                                main.cpp                     26  0x55555557255d
This is the relevant code snippet without debug output:
ImageBuf in(fn);
bool const read_success = in.read();
cv::Mat result;
ImageBufAlgo::to_OpenCV(result, in);
println("Size: [{}, {}]", result.cols, result.rows);

To Reproduce
git clone https://github.com/abrock/oiio-bugreport
cd oiio-bugreport/
cmake .
make
./bugreport 8bit.tif
-> segmentation fault.
Expected behavior
No segmentation fault
Evidence
https://github.com/abrock/oiio-bugreport
Platform information:

OIIO branch/version: OpenImageIO 2.2.10
OS: Debian bullseye
C++ compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)

Do you know what version of OpenCV you built OIIO against?
Do you build OIIO yourself, or can you? I'm wondering if you can quickly try to build against the current release -- we're in the 2.4 series now (and developing 2.5), so we should try to quickly find out if this is a current bug or if it's something that was fixed long ago.

for me it does not segfault but seems to output the wrong dimensions.
It seems this line does not even return a success:
ImageBufAlgo::to_OpenCV(result, in);
but
OIIO:geterror()
is also empty, so i don't know what happens.
adding the following line right after loading, shows that the ImageBuf has the right dimensions already:
println("oiio size: [{}, {}], nchannels: {}", in.spec().width, in.spec().height, in.spec().nchannels);
so maybe the to_OpenCV function can not handle an uninitialized cv::Mat ?
./bugreport 8bit.tif
Opening image 8bit.tif
Reading image 8bit.tif
Read success: true
oiio size: [100, 100], nchannels: 1
Converting image 8bit.tif to cv::Mat
Size: [0, 0]

OpenCV version 4.6.0
OpenImageIO version <IP_ADDRESS>

Do you know what version of OpenCV you built OIIO against?

4.7.0, compiled myself because I like the QT GUI elements and they are not available in the Debian package for OpenCV.

Do you build OIIO yourself, or can you?

I did that (cfaccc1609266c91aabb03470287a3ada7178cfc), and made sure that I'm including and linking the correct version. This is the compile output (ninja -v):
/usr/bin/g++  -I/home/alexander/sw/oiio/dist/include -isystem /usr/local/include/opencv4 -g -MD -MT CMakeFiles/bugreport.dir/main.o -MF CMakeFiles/bugreport.dir/main.o.d -o CMakeFiles/bugreport.dir/main.o -c /home/alexander/sw/oiio-bugreport/main.cpp
[2/2] : && /usr/bin/g++ -g -rdynamic CMakeFiles/bugreport.dir/main.o -o bugreport -L/home/alexander/sw/oiio/dist/lib   -L/usr/local/lib   -L/home/alexander/sw/oiio/ext/dist/lib -Wl,-rpath,/home/alexander/sw/oiio/dist/lib:/usr/local/lib:/home/alexander/sw/oiio/ext/dist/lib  /usr/local/lib/libopencv_core.so.4.7.0  -lOpenImageIO  -lOpenImageIO_Util  /home/alexander/sw/oiio/ext/dist/lib/libPtex.so.2.4

The issue remains exactly the same.

adding the following line right after loading, shows that the ImageBuf has the right dimensions already:

I added that to my repo and included printing the channel_bytes() value. I also tried initializing the cv::Mat before calling to_OpenCV, same result.

I believe this was fixed by #4013


[Endpoints] Navigate JSON response links to appropriate pages on click

Instead of opening links in a new tab, open links with prefilled params like in Lab v1.
Lab v1 example

Solved by PR https://github.com/stellar/laboratory/pull/956


Installing requirement and CUDA on a fresh virtual environnement

Hello,
I'm trying to use your AST for my research and to test it out, however it seems the requirements are deprecated with pip install

torchvision 0.10.0 is not compatible with torch 1.8.1
cuda installation is not implemented, while ASTmodels tries to use it

so i customed the requirement.txt file, changing torch and torchvision with these lines :

--find-links https://download.pytorch.org/whl/torch_stable.html
torchvision==0.9.1+cu111
--find-links https://download.pytorch.org/whl/torch_stable.html
torch==1.8.1+cu111

Regards,
Gildas Cozanet

yep, thats the way for me too
...
torch==1.8.1+cu101
torchvision==0.9.1+cu101
...

pip install -r requirements.txt --find-links https://download.pytorch.org/whl/torch_stable.html

yep, thats the way for me too
...
torch==1.8.1+cu101
torchvision==0.9.1+cu101
...

pip install -r requirements.txt --find-links https://download.pytorch.org/whl/torch_stable.html

Did it work for you? was trying to work with cu101, got python version issue, may I ask what version you used if it worked?


Remove Python 3.6 and 3.7 support, removing mypy_extensions dependency

The newest nornir-ansible can not be installed with the newest nornir versions because of the mypy-extensions dependencies. Nornir dropped Python 3.6 and 3.7 support, and with Python 3.8, mypy-extensions would not be needed anymore as TypedDict is part of the typing now..
(nornir_ansible) urs@DESKTOP-BM35OBL:~$ pip install nornir==3.4.1 nornir-ansible==2022.7.30
Collecting nornir==3.4.1
  Downloading nornir-3.4.1-py3-none-any.whl.metadata (5.5 kB)
Collecting nornir-ansible==2022.7.30
  Downloading nornir_ansible-2022.7.30-py3-none-any.whl (12 kB)
Collecting importlib-metadata<5,>=4 (from nornir==3.4.1)
  Downloading importlib_metadata-4.13.0-py3-none-any.whl (23 kB)
Collecting mypy_extensions<2.0.0,>=1.0.0 (from nornir==3.4.1)
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting ruamel.yaml>=0.17 (from nornir==3.4.1)
  Downloading ruamel.yaml-0.18.5-py3-none-any.whl.metadata (23 kB)
INFO: pip is looking at multiple versions of nornir-ansible to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install nornir-ansible==2022.7.30 and nornir==3.4.1 because these package versions have conflicting dependencies.

The conflict is caused by:
    nornir 3.4.1 depends on mypy_extensions<2.0.0 and >=1.0.0
    nornir-ansible 2022.7.30 depends on mypy-extensions<1.0.0 and >=0.4.1

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

If you agree to drop Python 3.6 and 3.7, it would be nice to have a new release. I am happy to update the PR or find a solution to still support 3.6 and 3.7 by maybe updating mypy-extensions if you prefer.

hey @ubaumann 👋  LGTM! ive clearly not been keeping up on things 😬 -- will merge and cut a release (and cross my fingers release pipeline is still happy 😁 )

looks like 2023.12.28 published nicely (and just in time before I have to go figure out 2fa for release pipeline things for pipit :D) holler if anything else needs doin and thanks again!

Thank you very much!!


[Relay][RFC] Improve testing infrastructure of Relay

As an implementor of multiple passes in Relay, I had noticed that we have far too little test case.
Most test_pass_*.py do not test for all program construct. For example, test_pass_dead_code_elimination do not test about adt, or test_pass_fuse_ops do not test about closure and reference. I had looked into each file, and almost all of them are 'incomplete' in this sense.
The short and obvious answer ('require people to write more test!') do not work, simply because relay will likely keep adding more and more language construct (for example, Mutual Recursion as of #2468). So, even once complete test case will also be incomplete.
I propose we create a file common.py in test, and put a list of test_case (called test_list) in there.
Each compiler pass can now loop through the test_list, and see if the transformed expression is semantically equal to the original one.
Additionally, I propose we also implement a function, semantic_equal, which take two relay expression, and do some property testing to see if they are semantically the same.
The reason is that a large portion of the test code is simply: creating an executor, creating the right amount of input, in the right type, get their output, deconstruct it to be multiple tensor, and testing that each of them is correct.
It is difficult to write a generic helper function to do all of them, because they have different input/output type. The check_eval function that sort of does the above only handle the case for a single output tensor, and the user still has to construct the input by hand.
If we implement semantic_equal, the test_list can have test of different type.
Additionally, it also mean we do test on more input, instead of the current handwritten one.

The test code has a lot of repetition and I am strongly in favor of refactoring existing tests (some of which show a fair bit of bitrot) to use common libraries. Testing error cases would also be a good thing to have shared infrastructure for.

+1 for refactoring.
BTW, we probably also need to have some discussion about adding some regression tests in CI pipeline because some passes could noticeably affect perf. But this can be a separate issue.

Realistically, infrastructure is only one way to help making better regression tests but cannot ever replace regression tests.
We do need and should write more testcases in the meanwhile :)

Can we add weekly builds for end to end test cases which takes long hours ?

+1 @zhiics Performance regression testing for compiler algorithms is essential. Too many places where a bad local decision can take the whole system down, and trying to reconstruct these cases two months after they were introduced is a waste of good engineering resources, better allocated to enhancing features.

Duplicated with #3154


Update README.md

Add Laraveles Blog and Laraveles Slack (Community Laravel in Spanish)

The link to the blog is fine.
The second URL is not correct. Remove the LinkedIn URL.


Downloads tools for .NET when trying to open launch.json for non-.NET project

Issue Description
We did a workshop on React development at my company today. As I wanted to create a new launch.json file to set up the Chrome debugger, the C# extension got activated and started downloading OmniSharp, the .NET Core debugger and the Razor Language Server.
Steps to Reproduce

Update the C# extension from an older version
The extension has to download new versions of the .NET tools the next time.

Install the Chrome debugger extension

Start a new web project

Run the "Debug: Open launch.json" command and select Chrome

Expected Behavior
A newly generated launch.json should be opened.
Actual Behavior
The C# extension kicks in and starts downloading 150 MB worth of dependencies, even though my project has absolutely nothing to do with .NET.
Logs
OmniSharp log
Nothing to see here.
C# log
Note: The output is incomplete because I had to restart VS Code. My companies Wi-Fi stopped working for some reason.

Installing C# dependencies...
Platform: darwin, x86_64
Downloading package 'Razor Language Server (macOS / x64)' (57227 KB).................... Done!
Installing package 'Razor Language Server (macOS / x64)'
Finished

Environment information
VSCode version: 1.34.0
C# Extension: 1.19.1
Mono Information
        OmniSharp using global mono :5.20.1
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   2.2.204
 Commit:    8757db13ec
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.14
OS Platform: Darwin
RID:         osx.10.14-x64
Base Path:   /usr/local/dotnet/sdk/2.2.204/
Host (useful for support):
Version: 2.2.5
Commit:  0a3c9209c0
.NET Core SDKs installed:
2.1.507 [/usr/local/dotnet/sdk]
2.1.604 [/usr/local/dotnet/sdk]
2.2.107 [/usr/local/dotnet/sdk]
2.2.204 [/usr/local/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.11 [/usr/local/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.5 [/usr/local/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.11 [/usr/local/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.5 [/usr/local/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.11 [/usr/local/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.5 [/usr/local/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

ariake-dark
wart
0.2.2

backspace-plusplus
jrieken
0.0.17

bettergitcommits
davidedmiston
0.5.0

csharp
ms-vscode
1.19.1

debugger-for-chrome
msjsdiag
4.11.3

EditorConfig
EditorConfig
0.13.0

embrace
mycelo
1.0.0

Ionide-fsharp
Ionide
3.38.0

Ionide-Paket
Ionide
1.12.0

leaper
OnlyLys
0.5.3

mono-debug
ms-vscode
0.15.8

msbuild-project-tools
tintoy
0.2.54

nord-visual-studio-code
arcticicestudio
0.8.0

path-intellisense
christian-kohler
1.4.2

rewrap
stkb
1.9.1

spaces-inside-braces
AiryShift
0.4.0

subtle-brackets
rafamel
3.0.0

theme-light-vs-mac
jamiewest
0.4.5

vscode-cil-complete
wk-j
0.0.5

vscode-icon-theme
jtlowe
1.6.5

vscode-subword-navigation
ow
1.1.5

Hi @inosik, there is currently nothing that the C# extension can do about this. The C# extension needs to register itself to provide launch.json templates, which means that when you ask for launch.json templates the C# extension will activate. In order to activate, we need to download our dependencies.
Two notes:

The VS Code team has a proposed feature to eliminate this problem (at least once the feature ships and the C# extension takes advantage of it): https://github.com/microsoft/vscode/issues/23251
You may already know this, but this is only a problem the first time you activate the C# extension following an update. The C# extension purposely doesn't update much because we know that the download experience for extensions with platform-specific dependencies isn't great.

Thank you for your reply. You're right, VS Code activates the extension when the "Open launch.json" command is executed:
...
[2019-05-23 08:17:14.848] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.csharp {"startup":false,"activationEvent":"onDebugInitialConfigurations"}
...

That's still unfortunate, though. I hope the feature you mentioned can help solving this. This blocked me for like 10 minutes. On a plane or train network this would be even worse.

This is extremely unfortunate for the reason mentioned above. It sounds like bad design to start downloading dependencies once the extension is activated as well, instead of displaying one of those popup notifications in the bottom right asking if the user would like to do so.

Aaaaand it happened again.
Waiting for 2 minutes (and counting) to debug a Python script really feels unacceptable.

This is a blocking feature for me and will cause an uninstall of the extension. Together with https://github.com/OmniSharp/omnisharp-vscode/issues/3862 this is extremely annoying. There should be no blocking network communication in performing an action in VS code because of an extension. One can run this in the background the have launch.json include C# templates only when completed (together with a notification that this is happening).


Cleancode/create new function

Create checkTurn, checkSymbol, checkFile function.
Correct checkposition to checkPosition.
Correct 'current_player == 2' to 'current_player ==player2_turn'.
Convert local variable to global variable using const.
Change if statement to for statement in checkDraw function.
Enter void if the function takes no parameter.
Fix incorrect input in leaderboard file in showResult when game_state is draw.

merge해용

잘 실행되네요. merge합시다

merge합시다!


When u are planning to update docker image for mongo 3.4.10

This project tracks the last stable mongodb version, 3.6.4 at this moment


Storage test cases improvements

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[x] C++ Guidelines
[x] Doxygen docs
[x] Unit tests
[x] No unwanted commits/changes
[x] Descriptive title/description

[x] PR is single purpose
[x] Related issue listed

[x] Comments in source
[x] No typos
[x] Update changelog
[x] Not work-in-progress
[x] External references or docs updated
[x] Self review of PR done
[x] Any breaking changes?

/azp run cpp - storage

/azp run cpp - storage

@microzchang I made some code changes, can you review this PR again?


Fix crash when trying to delete non-existent record

Fixes #355

Codecov Report

Merging #372 (6205d3a) into main (c6fb00b) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   77.64%   77.80%   +0.16%
==========================================
  Files          14       14
  Lines        1154     1158       +4
==========================================
+ Hits          896      901       +5
+ Misses        258      257       -1

Flag
Coverage Δ

unit
77.80% <100.00%> (+0.16%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aredis_om/model/model.py
86.68% <100.00%> (+0.17%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[KYUUBI #4245] [SPARK] Support UserDefinedType of spark since Spark3.2.0

Why are the changes needed?

to close issue #4245
As user-defined type (UDT) API is public since Spark 3.2.0, kyuubi should support udt schema converter.
reference:
SPARK-7768
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #4246 (80fb5b0) into master (f677848) will decrease coverage by 0.03%.
The diff coverage is 11.11%.

@@             Coverage Diff              @@
##             master    #4246      +/-   ##
============================================
- Coverage     53.55%   53.53%   -0.03%
  Complexity       13       13
============================================
  Files           560      560
  Lines         30413    30422       +9
  Branches       4082     4085       +3
============================================
- Hits          16288    16285       -3
- Misses        12620    12632      +12
  Partials       1505     1505

Impacted Files
Coverage Δ

...ache/kyuubi/engine/spark/schema/SchemaHelper.scala
83.49% <11.11%> (-6.94%)
:arrow_down:

...e/kyuubi/jdbc/hive/ClosedOrCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (-3.23%)
:arrow_down:

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
59.09% <0.00%> (-1.52%)
:arrow_down:

.../kyuubi/engine/spark/operation/ExecutePython.scala
81.46% <0.00%> (-0.87%)
:arrow_down:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
75.82% <0.00%> (+0.54%)
:arrow_up:

...apache/kyuubi/service/TBinaryFrontendService.scala
49.46% <0.00%> (+1.07%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Can you add some unit tests (including positive and negative) to ensure this won't break in lower spark version and converting correctly?


 Cc @wcy-fdu FYI, It's a gcp cluster.

may related to https://github.com/risingwavelabs/risingwave/issues/17407


Move schedules to AWS EventBridge

Use AWS EventBridge schedules in place of cloudwatch rules.

to be released in v0.26.0


fix "no pre-built binaries" error for aarch64, use x86_64 via rosetta

Adds support for installing binary deps (wasm-opt, etc) on a aarch64-apple-darwin target, via usage of the x86_64 binary run through the Apple-provided Rosetta instruction translator. As long as Rosetta 2 is installed on the target Apple device, all downloaded binaries will be executed using it automatically.
More info on Rosetta 2: https://support.apple.com/en-us/HT211861
closes: #952

[x] You have the latest version of rustfmt installed
[x] You ran cargo fmt on the code base before submitting
[x] You reference which issue is being closed in the PR text

looks like appveyor ci check is failing here:
stderr=```[INFO]: Installing cargo-generate...
error: the `--vers` provided, `latest`, is not a valid semver version: cannot parse 'latest' as a semver
Error: Installing cargo-generate with cargo
Caused by: failed to execute `cargo install`: exited with exit code: 101
  full command: "cargo" "install" "--force" "cargo-generate" "--version" "latest" "--root" "C:\\projects\\wasm-pack-071k0\\target\\test_cache\\.cargo-generate-cargo-install-latest"

doesn't like "latest" as a version, so we may need to pull the semver compliant version.

In a different failing test, an attempt is made to download a pre-built binary at this URL:
https://github.com/ashleygwilliams/cargo-generate/releases/download/v0.6.1/cargo-generate-v0.6.1-x86_64-pc-windows-msvc.tar (which would be redirected to the new org cargo-generate)
The issue is that releases haven't contained these assets since Sept. 2020 (v0.5.1, https://github.com/cargo-generate/cargo-generate/tags)
Was there a reason builds were excluded from the releases since then?


3068 deactivate kits

Resolves #3068
Description
This adds the ability to deactivate kits.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Local and unit tests.
Screenshots

@cielf sorry for the delay - pushed the fix for this!


Restore from Gist broken

@mstreit commented on Fri Nov 10 2017

Release number or git hash: deployed
Web browser version and OS: chrome

Steps to reproduce

save to gist
take link and past it in second browser window

Observed behavior

Only one item is contained in the restored table.

Expected behavior

Same items as in stored table.

Also the numerical values in the filter panel are not restored properly.

fixed, e.g. http://localhost:8080/#gist:c8380f6028cf9d06bf5679bc02418446


Minimizing the Issue Reporter locks VS Code

VSCode Version: 1.20 Insiders
OS Version: macOS

Testing #42351
Steps to Reproduce:

Bring up the Issue Reporter
Yellow button to minimize the reporter

Screen goes black. Bring up VS Code from Dock Bar and Issue Report is in front of VS Code and unresponsive. Can't close, minimize or expand.

Fix was to remove setting the workbench as the parent of the reporter window, done in https://github.com/Microsoft/vscode/commit/683fcaa92bc43629f615a1971deeafdbf63d0ef6


CORS did't work on IE，header did't sent

My custom header sets well on chrome or safari, but when it works on IE(9), my custom header did't sent to the server,
No 'Content-Type' was sent to the server,
And 'Accept' was still '/',
the XHR was 415 error if the header did't set well,
there is no problem in other browser
`import "babel-polyfill";
import axios from 'axios/dist/axios.min' //"axios": "^0.15.3",
let baseUrl = 'http://192.168.51.********/';
const axiosInstance = axios.create({
baseURL: baseUrl,
timeout: 30000,
headers: {
'Content-Type': 'application/json',
'Accept': 'application/json'
}
})
axiosInstance.interceptors.request.use(function (config) {
let temp = config.data;
config.data = {};
config.data.data = temp;
config.data.token = window.sessionStorage.getItem("token") || "";
return config;
})
export default axiosInstance;`

I'm the same problem with #764,with CROS

Have you solved this problem?

@zp1112  No，we are considering server side rendering for better SEO, this problem will no longer exit if we use SSR.

@zp1112 We are considering server side rendering for better SEO, this problem will no longer exit if we use SSR.Please tell me if you solved this problem,thank you!

hey im having same issue please see https://github.com/mzabriskie/axios/issues/365 looks like th

hey im having same issue please see https://github.com/mzabriskie/axios/issues/365

perhaps ie9 not support  CORS

So, here's the thing about this issue (because I ran into it the other day) How does jquery support CORS in ie9? because I ended up having to make a mokeypatch wrapper in IE9 so it'd use jquery to send an authorization header on a get request.

Okay so here's the fix:
in xhr.js on line 29:
    window.XDomainRequest && !('withCredentials' in request) &&

should really be:
    window.XDomainRequest && !('withCredentials' in config) &&

and here is the proof:

axios 0.17.1 broken in ie9
axios 0.17.1 with fixed line

if you run this in IE9 the fixed version will return an "Authorization" header with a token.

IE9 is no longer supported by Microsoft and I don't see any plans to fix this is axios

@zp1112 最后你的问题解决了吗?

I am going to close this issue as it is the same as the prior IE9 issue. I doubt this will be mended as IE9 and IE10 no longer receive support from Microsoft.


Atom crash at launch

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
I have downloaded the last beta version of atom 1.19.0-beta7 and when I launch for the first time Atom it doesn't display anything. After checking the console, it display some errors. (check screen in Additional information)
Steps to Reproduce

Download atom 1.19.0-beta7
Launch atom Beta on Mac OS Sierra 10.12.6 (16G29)

Expected behavior: Display welcome tab in atom
Actual behavior: Nothing display, just empty window
Reproduces how often: Always
Versions
atom 1.19.0-beta7
OS: Mac Os Sierra 10.12.6 (16G29)
Additional Information
screenshot of console http://i.imgur.com/kLx7nFD.png

Thanks for the report - was there any difference at all when you ran in safe mode or temporarily reset to factory defaults, or did you see the exact same errors in both cases?

I also just updated to 1.19.0-beta7 on macOS 10.12.6 but didn't see the same error after restarting.

Ok I have found issue, it was due to very very old package. Sorry :)


Include additional details in FATE metrics reported.

Add FATE status (new, in_progress, success,...) to metrics.
Add OpTypes (compaction, merge,...) to metrics.
Refactor concurrency test code.
The additional metrics all external metrics monitoring to better determine state and health of Accumulo by providing
visibility into FATE transaction status.
Also, trying to improve the stability of the concurrency tests (MasterMetrics, FateConcurrency and GcMetrics) that use
mini-cluster and "slow" operations to allow external testing of FATE status.  Common code has been refatored to new class.
(Additional test improvements may still be desired.)
FATE metrics testing uses curator provided test server (this was an existing test dependency for other modules). This reduces
the need for IT tests, while providing easier Mocking to exercise code paths.

Intend to work on testing - esp. the IT tests, but looking to see if there are any general comments regarding approach.

I believe this is ready for merge, just waiting to see if there are any additional comments since removing the draft status.  The some of the test improvements that were originally here have already been merged into 1.9 and brought forward with the SlowOps and FateConcurrencyIT rework.

Superseded with merge of  #1536


Mouse Reverse Scroll Wheel

Description of the new feature / enhancement
Reverse Scrolling
Scenario when this would be used?
Pretty common on the Mac side, already available.
Supporting information
https://bootcamp.uxdesign.cc/natural-scrolling-mac-vs-reverse-scrolling-windows-e48656275081

/dup https://github.com/microsoft/PowerToys/issues/6434


default version bump commit text with build number

I suppose this commit message would be much easier to read in git history

Sorry, but we can't just remove a parameter, this would fail all existing builds. Let's set change the  message parameter to optional and switch set a default message based on the version. Keep in mind, the version number might be nil.

There is a problem with default values. It's initialised before increment_build_number action can be trigged. This why I move default value into run.
We probably can just leave default value as it is, but still make a check in run. Do you have any thoughts about this approach?

It's easy, you set optional: true and then add this to the action itself
params[:message] ||= (build_number ? "Version Bump to #{build_number}" : "Version Bump")

You right, this looks much better

That's great, thanks for contributing @kohtenko :+1:

in continue of https://github.com/KrauseFx/fastlane/issues/468#issuecomment-127250625
Sometimes I need to specify my custom build number without calling increment_build_number. So do you know, is it possible to change Actions::SharedValues manually?

@skywinder No, I don't.
About your case: it looks like your failure somewhere in this lines:
build_number = lane_context[SharedValues::BUILD_NUMBER]
params[:message] ||= (build_number ? "Version Bump to #{build_number}" : "Version Bump")

I figured it out. This commit https://github.com/KrauseFx/fastlane/commit/c4828e8d7d6f5b3e2802111cfb83ebf0997ed1e8 is the reason.
@KrauseFx you can simply reverse this commit and release new version.

Already pushed a new version fixing this. Sorry! :+1:


Develop and test dynamic chunking from upstream

This has been tested in #9, but fully testing this functionality depends on #8 and the resulting fix upstream.

This now works quite well. Closing


Change schema from get view()

Hello,
I'm learning about tiptap and prosemirror.
I'm trying to change value of "draggable" option of prosemirror schema.
Any suggestions?
Maybe using toggleBlockType/setBlockType, but i'm trying to do it from

get view()

I'm not sure if this is possible in ProseMirror.


Adjust typing for forUpdate()/forShare() variant with table names

This is a followup to #2835 that became necessary with the merge of #2845. It adjust the typing of forUpdate() and forShare() to support the new call variants with table names.
It makes it possible to call forUpdate() and forShare() in either of the following three ways:

forUpdate()
forUpdate('lorem', 'ipsum')
forUpdate(['lorem', 'ipsum'])

Awesome, thanks @sgoll


Implement More Color Schemes

All you have to do is add an enum entry with the desired hex values in src/main/kotlin/gui/colors/MyColors.kt and add the name in the "themes" Map in the ArgParser at src/main/kotlin/io/ArgParser.kt, then it can be selected with -theme= as a commandline argument.

Archived Project


[Strimzi Kafka Operator] Split cluster permissions and permissions

The current version of the Strimzi Kafka operator has all the permissions it uses as clusterPermissions. That means that even when installed into only a single namespace, it will get all permissions cluster wide. This is a blocker for deploying it in some environments. This Pr splits the permissions as they should have been originally, so only the permissions actually needed as clusterwide are granted as clusterwide (such as reading nodes). The rest is done only as permissions, so a single namespace install doesn't give the operator more rights than needed.
PS: The latest version is still using the Fabric8 version which failes to authenticte on the test framework here. But the changes has been tested manually. (hopefully this is the last update on 0.14.0 - the next version of Strimzi should have this already fixed.)
Updates to existing Operators

[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

As expected and mentioned above, the  operator-scorecard-test fails on the Fabric8 error (Unexpected response(403 Forbidden), to the authorization request. Missing header:[Location]!).


adds xhrFields to $http config object

The properties of the xhrFields object is set on the XHR object making it possible to set non-standard properties. It is also possible to set the object on $http.defaults to use it globally. Please note that this will not work for certain non-standard read-only properties specified by Mozilla, such as mosSystem and mozAnon as they must be passed throught the constructor.

So, I've been talking with @petebacondarwin about a new approach for getting changes like this into the library, and this might be a good candidate.
Still waiting for a few other team members to give their inputs on whether it's a good idea or not, but what I want to do is get feedback from the community (and other core team members) on changes like this, so that we can try and steer the framework in a good direction.
Things we want to figure out:

How many users need this
How inconvenient is it to not support this
What is the simplest and most powerful way to expose the facilities needed

My view is that we should probably enable applications to control how XHR is instantiated, and let them do that during config time. But maybe an API design like that would suck, or maybe the complexity of adding this is not worth it for the number of users that need it. Or maybe it is, we really need feedback from developers to figure this out.
I think it would be worth putting together a document with a detailed plan (and maybe some alternatives) to seed discussion in the community so that we can make the right decision with this.
I'll provide a bit more info if I get feedback on this idea, so leaving this open for now

I'll try pitch in my 2 cents on this.
Our need originated from the need to disable CORS restrictions in Firefox OS app Development. In Firefox OS all apps are webapps and are restricted by the browsers normal CORS restrictions. In an packaged (installed) app, the format of the origin url is app://your.domain, which means that any ajax calls in your code will trigger the CORS restrictions. The proper solution to this is to implement the correct CORS headers server side. If that is not the option, this is where the mozSystem workaround comes to play, as it will disable the CORS restrictions.

How many users need this?

Anyone writing an Firefox OS app that does not control the server side headers.

Running on cloud service
Getting data from someone else's service (Eg. News aggregations etc)
Debugging/Prototyping

2.How inconvenient is it to not support this?
Users would need to implement AJAX requests without using $http.
3.What is the simplest and most powerful way to expose the facilities needed?
I agree that a way to control XHR is instantiated at config time would be good.
A separate benefit might be that it could be very useful for simplyfying mocking and testing of the $http service.

@pkozlowski-opensource You said you want to look into this later, right? I'll tentatively assign you for it.

Yes, I will take care of this one, thnx @Narretz

This was implemented differently in https://github.com/angular/angular.js/pull/12159


the pre-trained baseline models  were trained by VID and youtube-bb?

Dear authors!
the pre-trained baseline models  were trained by VID and youtube-bb dataset? or just VID is enough? I trained on VID and filter some large objects but the model overfits a lot. Any training details i will appreciate so much

All the baseline models trained on VID, YOUTUBE-BB, COCO and DET, please refer to SiamRPN++


firewall policy audit module (iptables.check)

We should put together a firewall policy module that will ensure that certain firewall rules are applied. Initial support for iptables; eventual support for pf. This module could leverage iptables.check execution module.
firewall:
  whitelist:

    ssh:
      data:
        table: 'filter',
        chain: None,
        rule: '-p tcp --dport 22 -m state --state ESTABLISHED, RELATED -j ACCEPT'
        family: 'ipv4'

Would it also be possible to add a check for a the default policy, maybe using iptables.get_policy to help ensure they are all set to DROP

Initial work for this (minus the default policy support) was completed in #99

@dgmorrisjr, I'd like to hear more of your thoughts on using a default policy?

security best practices is that we should set the default policy to "DROP", but really they can be set to the appropriate value for your organizationally defined value.   The DISA STIGs all specify that DROP is the appropriate value.  This helps reinforce a deny all traffic not explicitly listed type of policy.
in the iptables rules, they take the form of:
iptables -P <chain> <policy>
iptables -P INPUT DROP
iptables -P FORWARD DROP
iptables -P OUTPUT DROP

I think the rule structure for hubblestack can closely match that of the salt states for iptables.set_policy, possibly something like this:
whitelist checks only...
firewall:
    verify_INPUT_default_policy:
      data:
        Red Hat Enterprise Linux Server-6:
        - default_policy:
            table:      filter
            chain:      INPUT
            policy:     DROP
            tag:        V-38383
      description:      (High) The default policy for the input filter table should be set to DROP

Does this issue need to remain open?

@basepi, I'm currently working to support the true whitelist and the default policy in the new version of iptables.

@cedwards, should we consider supporting firewalld also?

Since the iptables modules does its job, I will close this and open a new one for the default policy and for the true whitelist.


Angular routes with custom Resolve crashes the application if using the Back button

I have a simple nativescript application with 3 routes:
const routes: Routes = [
    { path: "", redirectTo: "/route1", pathMatch: "full" },
    { path: "route1", component: Route1Component },
    { path: "route2", component: Route2Component, resolve: { test: TestResolve } },
    { path: "route3", component: Route3Component }
];

where TestResolve is defined like this:
import { Injectable } from "@angular/core";
import { Resolve } from "@angular/router";

@Injectable()
export class TestResolve implements Resolve<string> {
    resolve() {
        return new Promise((resolve, reject) => {
            setTimeout(function() {
                resolve('we are done here');
            }, 3000);
        });
    }
}

Now I navigate from route1 to route2 and finally route3 within my application using simple links in the corresponding markup:
<Button [nsRouterLink]="['/route2']" text="go to route 2"></Button>

On route3 clicking the Back button multiple times quickly will crash the application with the following:
JS: EXCEPTION: Calling startGoBack while going back.
JS: ORIGINAL STACKTRACE:
JS: Error: Calling startGoBack while going back.
JS:     at NSLocationStrategy._beginBackPageNavigation (file:///data/data/org.nativescript.repro2/files/app/tns_modules/nativescript-angular/router/ns-location-strategy.js:129:19)
JS:     at Object.<anonymous> (file:///data/data/org.nativescript.repro2/files/app/tns_modules/nativescript-angular/router/page-router-outlet.js:189:40)
JS:     at ZoneDelegate.invoke (file:///data/data/org.nativescript.repro2/files/app/tns_modules/nativescript-angular/zone-js/dist/zone-nativescript.js:190:28)
JS:     at Object.onInvoke (file:///data/data/org.nativescript.repro2/files/app/tns_modules/@angular/core/bundles/core.umd.js:4391:41)
JS:     at ZoneDelegate.invoke (file:///data/data/org.nativescript.repro2/files/app/tns_modules/nativescript-angular/zone-js/dist/zone-nativescript.js:189:34)
JS:     at Zone.runGuarded (file:///data/data/org.nativescript.repro2/files/app/tns_modules/nativescript-angular/zone-js/dist/zone-nativescript.js:97:47)
JS:     at Object.callback (file:///data/data/org.nativescript.repro2/files/app/tns_modules/nativescript-angular/zone-js/dist/zone-nativescript.js:73:29)
JS:     at Page.Observable.notify (file:///data/data/org.nativescript.repro2/files/app/tns_modules/tns-core-modules/data/observable/observable.js:149:23)
JS:     at Page.onNavigatedFrom (file:///data/data/org.nativescript.repro2/files/app/tns_modules/tns-core-modules/ui/page/page-common.js:234:14)
JS:     at Page.onNavigatedFrom (file:///data/data/org.nativescript.repro2/files/app/tns_modules/tns-core-modules/ui/page/page.js:131:42)

Hi @darind,
Thank you for reporting this issue.
I reviewed this case, unfortunately, I have to confirm that this is a real issue for both iOS and Android. The problem could be reproduced, when we navigate to the latest available Page and then navigate back to the main component. I am attaching sample project.
Archive.zip
Regards,
@tsonevn

Hi @darind @tsonevn,
Unfortunately, after we removed the usage of Resolve throughout our Application, it still crashes with the same error in our app, after navigating several times back and it reaches the Main component.
Just to let you know that the problem is not only when you use a "slow" Resolve function in the routing.

updates for this issue?

Hi @vmachuca
This issue is still under review. At this point, we could not commit to the exact time when the fix will be available.

Any clarity on timeline now? I am seeing this issue occur rather frequently in my production application. We are not using resolve. Just simple path and component.


Allow using local cache if no registry information was provided

Fix #131

Let me try a different approach.


Issues with Email

It does not add the reply email as a comment to the original ticket, instead it creates a new ticket for the reply email
It looked like your email subject was showing as the ticket subject rather than "* added new comment on ticket *" This would be why. I'm not sure if the subject wasnt sent out correctly to you from the comment email or what the issue was, but thats the string that the emailcontroller looks for in the subject line to determine that the email is an existing ticket.

It could not download and attach the email attachment
I'll take a look at this. I had mine working correctly but may have changed something since the last time I checked it.

It could not filter out the signature
Unfortunately I'm not sure how to filter out the signature. But if it correctly tags a ticket as a comment instead of a new ticket it should successfully remove all previous reply's etc....

I've got some more testing to do but I'll post updates and any further questions I may have for you in this issue here.
Thanks!

You have done a great work, and I wish I could be more helpful to you, may be couple of days and you will find me making some pushes.

I'll set up a test and see if I can help.

I'm right working on it. I'll making a commit in about 10 minutes

Nice

Sounds great! I've been swamped and havent had much time to tackle debugging it.

That's the spirit :+1:

Oh sorry guys, I thought it was the other issue... https://github.com/thekordy/ticketit/issues/122
I wan't working on this. But I'll check it tomorrow, now I have plenty of time :-)

Auto assign now works
https://github.com/thekordy/ticketit/commit/3d601cb05d16b1dcf65555b7639f0903a13b2084

I found this package: https://github.com/willdurand/EmailReplyParser
Others have already done this functionality before, maybe we could use it. What do you think?

I personally have no issues using more packages as long as they accomplish a new task or more completely fulfill a current one. It looks like it does some work with signatures in addition to replys so thats definitely a benefit.

But that package works only with emails in english language, and yet it won't connect the reply email subject with the original ticket.
I have an initial idea to resolve this:

To connect reply email with the ticket, we may add the ticket id to the subject of the first confirmation email sent to the user created the email, ex: "My issue subject [id: 123]" .. this can be checked by a simple regex .. also all communication emails should include the id in their subject.

To remove quoted text, Some providers include a static expression to show users where to write their reply, ex: ###### write your reply before this line ####### ... but I haven't thought yet about how that could be done in multilingual environment.

For 2)
We can still use some regex for ###### no-matter-what-text-is-in-here #######
Or:
######
Write your reply before the line above

In this case again, it doesn't matter what is written below the may #-s.
Or since everything is stored in language files, we can search for a translated string. There's no real difference. Even if different users have different language setup, we can always identify the necessary translation file.

And yeah, 1) would solve many issues.
However I think it's time to change from incremental ticket id's to some kind of uuid / hash / random string  solution. Users should have minimal information about tickets not created by them.

In this case again, it doesn't matter what is written below the may #-s.

You are right, that would solve it with minimum impacts and won't be affected by translations.

However I think it's time to change from incremental ticket id's to some kind of uuid / hash / random string solution

Yes, and it would help us in future when we offer guest tickets, they would follow the status of their tickets by providing only the ticket id and their email address.

I think the other thing is to make this runs automatically on intervals

I agree. My intent was to just set up the laravel scheduler to run the "getEmails" method on intervals.

I think we can make a catch-all mail. Then generate a unique ID for each ticket
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>So If he replies that unique ID we can match it with correct ticket.