Optimize the logic of ConfigConfigurationAdapter to get prefixed meta…

…data
What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10389 (b766110) into 3.0 (4195838) will decrease coverage by 0.13%.
The diff coverage is 88.57%.

@@             Coverage Diff              @@
##                3.0   #10389      +/-   ##
============================================
- Coverage     65.53%   65.39%   -0.14%
  Complexity      317      317
============================================
  Files          1234     1234
  Lines         53855    53826      -29
  Branches       8154     8123      -31
============================================
- Hits          35292    35201      -91
- Misses        14679    14742      +63
+ Partials       3884     3883       -1

Impacted Files
Coverage Δ

...n/java/org/apache/dubbo/config/RegistryConfig.java
81.95% <ø> (ø)

...va/org/apache/dubbo/config/context/ConfigMode.java
100.00% <ø> (ø)

...bbo/config/context/ConfigConfigurationAdapter.java
71.42% <50.00%> (-10.39%)
:arrow_down:

...n/java/org/apache/dubbo/config/AbstractConfig.java
81.26% <88.88%> (+4.17%)
:arrow_up:

...a/org/apache/dubbo/config/ReferenceConfigBase.java
64.49% <100.00%> (+0.25%)
:arrow_up:

...ava/org/apache/dubbo/config/ServiceConfigBase.java
60.31% <100.00%> (+0.21%)
:arrow_up:

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
50.00% <0.00%> (-33.34%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
43.47% <0.00%> (-26.09%)
:arrow_down:

.../apache/dubbo/rpc/filter/ProfilerServerFilter.java
62.85% <0.00%> (-20.00%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


Too heavy caching

Images that were missing stays missing on mobile Chrome against https://data.npolar.no/map/archive

Removed long term network caching in favour for app cache manifest browser caching


feat: Add PromiseHolder<T> to avoid expensive copies of Promise<T>

actually I'm not sure if I really want to spend the effort to build this. This is added complexity just for some minor performance gains - and in the future I'm hoping there will be a borrowing T accessor for shared_ptr, then we don't need this anyways.


Set Atkinson as global interface font

popup
settings

addressbook
website access

use different font for the rest of the interface other than addresses


Remove app configuration extension

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

As we have merged into main CLI repo. We don't want to release extension anymore.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/shenmuxiaosen/azure-cli-extensions.git@user/shuai/removeext#subdirectory=src/$EXT&egg=$EXT"


No toolchains found in the NDK toolchains folder for ABI with prefix: mips64el-linux-android

I got error:
No toolchains found in the NDK toolchains folder for ABI with prefix: mips64el-linux-android

Hey @alexd555.
There are 2 solutions:

Update your Gradle version to the latest
Rename the /sdk/ndk-bundle folder to some other name just to bypass the ndk sdk from the gradle build.


kubelet.runtime: update the import path for volume.

I noticed that the #5572 raced with #5642, caused the error build. So fix it

LGTM  I am going to merge without waiting for travis to stop building error.


Exception "The type initializer for 'WpfMath.TexFormulaParser' threw an exception."

When trying to create an instance of TexFormulaParser:
var parser = new TexFormulaParser();
getting an error with text "The type initializer for 'WpfMath.TexFormulaParser' threw an exception."
VS 2019, last version. Tried wmf 0.7.0, 0.5.0, 0.6.0. Tried to create an empty project, the error remains.

Well, which exception did it threw?

The one mentioned in the title. There was also an "inner exception" (that I found out later) about something connected with "core assembly". Sorry that I don't have the exact text of the error. Some extra info: win10, the c# program is dot net web core site.

So, are you trying to use WPF-Math with .NET Core already? Could you please upload the sample project somewhere?
If it's true, then my answer would be: we don't support WPF on .NET Core (yet), and this is planned for the nearest future.
Also, we haven't tried to run WPF-Math on .NET Core as-is, and I don't know if it's supposed to run or not. Probably you better wait for official support of WPF on .NET Core before trying that.

Thank you for the reply, that seems to be the cause. Yes, Im running it on .NET Core. I can't upload a sample project, but it is easy to make this error occur (create .Net project > type "new TexFormulaParser();" )

Okay, then I'm closing this as a duplicate of #209.


User is redirected to payment page if amount is zero and I get charged by Mollie for a 0€ payment, is this normal behaviour ?

Hi,
Thanks for this package!
I'm giving 100% discount codes for some of my users so they can get free access to the subscription part of my app, but they are redirected to the payment page and they have to add a card, which I want to avoid if possible.
Moreover, I'm charged by Mollie for the 0€ transaction which is quite annoying for me.
Is this normal/wanted behaviour ? Is there any other way to circumvent this ?
Thanks for your help !

Hi @WhereIsLucas ,
Free subscriptions are not supported by Cashier Mollie and should be handled outside the package.
Some pointers to handle your use case:

handle the free subscription coupons using your own logic, pass cashier coupons on to cashier.
apply a generic trial with an end date far far away if you want to use Cashier

Alright, thanks for your answer.
I'll follow the pointers you mentionned.


Rails 6 -  ActiveRecord::MigrationContext.new expects 2 args

https://github.com/pat/combustion/blob/master/lib/combustion/database/migrate.rb#L47
Looks like ActiveRecord::MigrationContext.new now expects to be called with 2 args (https://github.com/rails/rails/blob/master/activerecord/lib/active_record/migration.rb#L1018)
Failure/Error: Combustion.initialize! :all

ArgumentError:

wrong number of arguments (given 1, expected 2)
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activerecord/lib/active_record/migration.rb:1020:in `initialize'
# /usr/local/bundle/gems/combustion-1.1.0/lib/combustion/database/migrate.rb:47:in `new'
# /usr/local/bundle/gems/combustion-1.1.0/lib/combustion/database/migrate.rb:47:in `migration_context'
# /usr/local/bundle/gems/combustion-1.1.0/lib/combustion/database/migrate.rb:10:in `call'
# /usr/local/bundle/gems/combustion-1.1.0/lib/combustion/database/migrate.rb:5:in `call'
# /usr/local/bundle/gems/combustion-1.1.0/lib/combustion/database.rb:19:in `setup'
# /usr/local/bundle/gems/combustion-1.1.0/lib/combustion.rb:40:in `block in include_database'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:429:in `instance_exec'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:429:in `block in make_lambda'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:201:in `block (2 levels) in halting'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:607:in `block (2 levels) in default_terminator'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:606:in `catch'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:606:in `block in default_terminator'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:202:in `block in halting'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:514:in `block in invoke_before'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:514:in `each'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:514:in `invoke_before'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/callbacks.rb:134:in `run_callbacks'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/activesupport/lib/active_support/reloader.rb:88:in `prepare!'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/application/finisher.rb:113:in `block in <module:Finisher>'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/initializable.rb:32:in `instance_exec'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/initializable.rb:32:in `run'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/initializable.rb:61:in `block in run_initializers'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/initializable.rb:60:in `run_initializers'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/application.rb:363:in `initialize!'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/railtie.rb:190:in `public_send'
# /usr/local/bundle/bundler/gems/rails-c81d6448ad2d/railties/lib/rails/railtie.rb:190:in `method_missing'
# /usr/local/bundle/gems/combustion-1.1.0/lib/combustion.rb:32:in `initialize!'
# ./spec/rails_helper.rb:9:in `<top (required)>'

Ah, thanks for pointing this out!
I've just pushed a fix, but I'm going to hold off on a gem release given the change in Rails isn't part of a release yet either. So, you're welcome to use Combustion via the git repo in the meantime :)

I've recently released v1.1.1 with the previously mentioned fix - and thus supporting Rails 6.0.0.rc2 - so I'm going to consider this issue all sorted :)

Hey, I just wanted to say that I am really thankful for this issue. I tried forever on how to get a test for migrations to work. I couldn't figure out what to pass to schema_migrations. I googled and tried for hours, but there isn't really much documentation. But thanks to this issue, I finally found it!
See this stackoverflow question for more details (already self-answered):
https://stackoverflow.com/questions/60974746/what-do-i-pass-to-schema-migration-in-activerecordmigrationcontextnew/60975003#60975003


[UBS order] Incorrect confirmation page after the Fondy payment

Preconditions

The registered user is logged in.
The user goes to the UBS-order page.
The user chooses services and fulfills all required user data.
The user chooses the 'Fondy' payment.
The user clicks on the 'Order' button.

When the payment is successful:
Actual result:

Expected result:

Done - verified


[5.9][CMake] Use WMO for release builds

Explanation: CMake builds were not using WMO for release (this is fixed in 3.26+). This has a significant impact on parsing times (5x).
Scope: swift-syntax libraries included in the compiler
Risk: Very low. Just enables WMO for release builds.
Original PR: https://github.com/apple/swift-syntax/pull/1692

@swift-ci please test


Update grammar for live-share getting started

Add preposition for sentence coherence
Fix run on sentence

@stepharr Thanks for the PR!  Looks good!!

@Chuxel thanks for creating great open source software!


Novel reader/ Book reader

Describe your suggested feature
Integrating extentions and readers for novel, books and all would be good idea , manga readers also read novels and books, but we either have to download the whole book by searching it somewhere , or in case of novels we have to go to websites to read with ads
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.3.
[X] I will fill out all of the requested information in this form.

Mihon doesn’t affiliate itself with extensions. You’ll have to ask elsewhere.

Mihon doesn’t affiliate itself with extensions. You’ll have to ask elsewhere.

Then what about reader functionality, i mean if creators approve of it

Mihon doesn’t affiliate itself with extensions. You’ll have to ask elsewhere.

Then what about reader functionality, i mean if creators approve of it

The reader functionality is there, provided the book is in a supported format (e.g. .cbz). You can download it and store it locally.

https://mihon.app/docs/faq/general#can-i-read-light-novels and it has already been rejected before so won't be added.

https://mihon.app/docs/faq/general#can-i-read-light-novels and it has already been rejected before so won't be added.

Thnx for this i didn't knew it

I can recommend you "lnreader" for novels.


Add 1.30 Vsphere E2E tests

Issue #, if available:
Add E2E tests for Vsphere provider for new K8s version 1.30.
Description of changes:
Testing (if applicable):
Ran all the 1.30 quick tests against my local branch and these are the results . Out of three failures 2 BR tests fail because of the disk size validation which should be fixed once the templates are fixed in CI. The TestVSphereKubernetes129To130StackedEtcdRedHatUpgrade test failed with template /SDDC-Datacenter/vm/Templates/kubernetes-1-29-eks-10-redhat is missing tag eksdRelease:kubernetes-1-30-eks-3 which can be considered a flake because of a random race condition that happens in our controller when the template in Machine Config is updated but not actually reflected when the validations are being checked on the cluster object. The other TestVSphereKubernetes129To130RedHatUpgrade test passes which ensures that it is not related to any newly added framework function as they are being used by both the tests.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Ran all the 1.30 quick tests against my local branch and these are the results. Out of three failures 2 BR tests fail because of the disk size validation which should be fixed once the templates are fixed in CI. The TestVSphereKubernetes129To130StackedEtcdRedHatUpgrade test failed with template /SDDC-Datacenter/vm/Templates/kubernetes-1-29-eks-10-redhat is missing tag eksdRelease:kubernetes-1-30-eks-3 which can be considered a flake cos of the random race condition that happens in our controller when the Machine Config is updated but not actually reflected when the validations are being checked. The other TestVSphereKubernetes129To130RedHatUpgrade test passes which ensures that it is not related to any newly added framework function as they are being used by both the tests.

/lgtm

/approve


The task in the scheduler does not start when I unplugged the AC adapter

Thanks for the report.
Are you able to send me the output of the script when you run start-legion-watcher.bat and then unplug the adator?


Can't install through npm

Hello,
Do you intend to make this available through npm?
I like to manage all my project's dependencies through npm and don't want to have to install another package manager :cry:
Thank you.

Hi,
It's already available on npm but it's called "tingle.js" (sadly, "tingle" was already taken).
npm install tingle.js


Add internal types and mappers for cross cluster related APIs

What changed?

Add internal types for cross cluster related APIs
Add corresponding mappers for thrift and proto definition

Why?

For supporting cross-domain/cluster operation

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build caa18ab2-9b8c-4a18-97ad-d381246538bd

351 of 1071 (32.77%)  changed or added relevant lines in 5 files are covered.
180 unchanged lines in 17 files lost coverage.
Overall coverage decreased (-0.2%) to 59.94%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/types/mapper/proto/shared.go
259
319
81.19%

common/types/shared.go
0
298
0.0%

common/types/mapper/thrift/shared.go
0
362
0.0%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
1
89.64%

service/history/queue/timer_queue_processor_base.go
1
78.6%

service/history/queue/transfer_queue_processor_base.go
1
79.59%

client/history/client.go
2
44.35%

client/history/metricClient.go
2
49.43%

service/history/handler.go
2
46.67%

service/matching/matcher.go
2
91.46%

service/history/queue/timer_gate.go
3
95.83%

service/frontend/workflowHandler.go
4
58.48%

common/config/config.go
9
70.59%

Totals

Change from base Build f11df966-12d3-44d7-884d-dfc1acad4beb:
-0.2%

Covered Lines:
90219

Relevant Lines:
150515

💛  - Coveralls


React: MegaMenu iteration 1 changes - design & design specs provided by Reboot designer

Notes

The Reboot team is responsible for creating the visual designs and design specs for this design.  This issue is to track the transition of the Reboot design work to the DDS design & engineering team members.

Additional Information

See the epic for the functional specs and additional issues
Visual Designs & Design Specs Box folder link

Acceptance Criteria

[ ] Visual designs and specs received from Reboot designers
[ ]  A pdf file is created and placed in the Box folder with the updated Sketch file
[ ] Meetings conducted with DDS team members to review the designs

Presented the design in the Sept 14 engineering meeting for sizing.


The plug-in died and failed to restart

[ERR] Waiting on a conditional variable failed (sr_shmext_rpc_sub_add: Interrupted system call).
[ERR] HA: sr_module_change_subscribe error (7): Internal error
sysrepo-plugind error: Exiting without a proper cleanup
Hello, there are some problems with the plug-in. After it dies, it cannot start normally, and the above error appears. I feel like there's a deadlock（rwlock）, and when that happens, I delete /dev/shm/* and it starts. In this case, netopeer2-server will also have problems. Any request from the client cannot be answered, and it feels locked

Update sysrepo, this should be fixed in version 2.2.19.

ok,thanks.


Team batch add members

Add a new RPC teamAddMembers and call that from the gui instead of looping over teamAddMember. The motivation behind this change is to save on team sigchain links. Since each call to teamAddMember is one chain link.
This implementation of teamAddMembers takes the happy-path addees and puts them in a transaction. The more complicated additions get looped over same as before. But we should be able to fix this on the core side without further changes to the RPC interface (@zapu).
There is one user-facing downside to this. If some additions succeed and others fail, the gui no longer removes the successful addees from search. It would be possible to spruce up the return value to fix this. However I think it is more pragmatic to leave it until this method gets fixed up to be a full transaction, at which point it will not be possible for it to partially succeed.
There are a distinct lack of tests. I will write them but want to sanity check this approach with @zapu first.

@zapu this is ready for another look!
@buoyad fyi this is a transaction now which means that when an error occurs not removing anyone from the search is the right thing. Here's an example

Also for the record the stuff in the original comment is now mostly untrue.

ci fails with:
[go] Running shell script
+ make -s lint
teams/transactions.go:297:9: if block ends with a return statement, so drop this else and outdent its block
Makefile:11: recipe for target 'lint' failed
make: *** [lint] Error 1[go] Running s


Bump MTK and SciMLBase

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
[ ] Any new documentation only uses public API

Additional context
Add any other context about the problem here.

@AayushSabharwal can you check these conversions? I think something is going on with the parameter type promotion on MTKParameters when it's empty.

<EMAIL_ADDRESS>reworked the part of MTKParameters that's causing problems here. It should be fixed after that version.

That's a fun compat error

BlockArrays seems to be holding back Transducers, but I don't see a compat for the latter in the former's Project.toml

@jClugstor what's the core issue here?

It's because transducers is holding back BlockArrays

@MasonProtter is this known or fundamental? Or has it just not been bumped?


fixed the bug when the version is just a number

Fixes # .
Changes proposed in this pull request:

Can you update your commit to exclude the .sln changes?


Test hg19 bams to ensure GATK compatibility

It worked.
Protip: using the same hg19 reference for the alignment as the input to the gatk pipeline also helps.


add paperkey from devices

This PR is large because i had to fixup some assumptions of code in the old provisioning flow. We're reusing the provisioning when you add a phone/computer but those assumed they were in this container which they'd be absolutely positioned in (aka no nav, etc). In the process of fixing that up i also cleaned up the props / styles so its closer to our newer code, made the inputs a fixed width (longstanding visual tweaks ticket for this), and fixed the usercard implementation so the component 'starts' at the top of the avatar and not the start of the card

[x] Add new device has a dropdown
[x] Styling of provision flow works in signup or in device tab
[x] Styling cleanup of usercard
[x] Styling cleanup of inputs in signup flow
[x] Fixup device screen after adding is done

@keybase/react-hackers this monster is ready to be looked at

Can one of the admins verify this patch?

@keybase/react-hackers bump

@keybase/react-hackers bump

:thumbsup:


[Issue] Need Record the Bar Scaling Rate When Move to Next Page

In GitLab by @yhua123 on Aug 23, 2017, 22:56
need to be left justified in red cycle

In GitLab by @yhua123 on Nov 8, 2019, 07:35
figure error, update new one

In GitLab by @liyanq528 on Nov 8, 2019, 07:35
fixed by push request #206

In GitLab by @yhua123 on Nov 8, 2019, 07:35
LGTM

In GitLab by @sokril on Nov 8, 2019, 08:08
closed

In GitLab by @sokril on Nov 8, 2019, 08:08
assigned to @liyanq528


"There was an error!" happened while embedding a diagram saved on google drive in Google Docs

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
"There was an error!" happed while embedding a diagram in Google Docs saved on google drive.
To Reproduce
Steps to reproduce the behavior:

Go to 'diagram.net for Docs'
Click on 'Insert Diagrams'
See error

Expected behavior
No error happened.
Screenshots

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 14.1.8

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 87.0.4280.141

Should be fixed if you reload. Google just randomly changed the parent frame without notifying anywhere that we can see.

Should be fixed if you reload. Google just randomly changed the parent frame without notifying anywhere that we can see.


s/ethereumproject/ethereumclassic/

https://github.com/ethereumclassic/TokenMint/search?q=ethereumproject&unscoped_q=ethereumproject

Is ETC live at all?


CI: execute applications one by one, to prevent having hard drive full (e.g. with matrix os/app)

Fixed by #79


docs: Few points lack periods

what's wrong with the documentation?
In the contribution.md, many points lack period at the end of sentance.
Add screenshots

Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

I think it is unnecessary


Replace csv reader by sqlite reader

We will not use finally not use the csv format for our Data Reader, and keep our native versions on iOS and Android, which use sqlite.
In order to parse sqlite files with javascript, we will use http://lovasoa.github.io/sql.js/GUI/

Closed Issue


add common configuration file for testing data

Proposal
The idea is to have a common configuration file for the gin test indicating parameters such as :

The location of the data.
Whether the outputs are saved or not.
etc.

Motivation
While testing in my local machine I usually want a quick way to change the defaults from my local machine. A simple central file config.py in the tests/test_on_data directory should do the deed.
Checklist

[x] Have you checked our Contributing document?
[x] Have you ensured the PR description clearly describes the problem and solutions?
[x] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
[x] If this PR fixes an issue, is the first line of the PR description fix #XXX where XXX is the issue number?

@h-mayorquin Good idea - I would, however, make the name less general than that to avoid confusion with other less specific configuration files (codecov, black, git, etc.).
Maybe just gin_test_config would be fine. Also it probably shouldn't be a .py file but rather some text storage format like .json (which would work well too then because you just extract those two fields from calling json.load(gin_test_config.json).

@h-mayorquin Thanks for looking into this! One thing before I can approve:
The lines of test_config_dict = load_dict_from_file("./tests/test_on_data/gin_test_config.json") depend on being called from a particular working directory location. This can be relaxed by using a local path relative to each testing file, e.g., something like
test_config_dict = load_dict_from_file(Path(__file__).parent / "gin_test_config.json")

@h-mayorquin Also, can you add this new .json file to the .gitignore, thereby allowing Git to finally be able to ignore anyone's local changes to such things?


Bug spotting

No software package can be free of bugs practically, we would like you to point out the bugs you see in the package and create an issue first describing the bug.
You can also point the bugs out as a reply to this issue.

Some Bugs in Linear Search and Interpolation Search:

In Linear Search If we find our searched elements then we need to break the loop, no further traversing required, same with Interpolation Search.
In Interpolation search the condition is wrong while low <= high and array[low] <= array[high] it should be while low <= high and x >= array[low] and x <= array[high]:

Some Bugs in Linear Search and Interpolation Search:

In Linear Search If we find our searched elements then we need to break the loop, no further traversing required, same with Interpolation Search.
In Interpolation search the condition is wrong while low <= high and array[low] <= array[high] it should be while low <= high and x >= array[low] and x <= array[high]:

Your reported bugs have been forwarded to the concerned team. Thanks for reporting.

Some Bugs in Linear Search and Interpolation Search:

In Linear Search If we find our searched elements then we need to break the loop, no further traversing required, same with Interpolation Search.
In Interpolation search the condition is wrong while low <= high and array[low] <= array[high] it should be while low <= high and x >= array[low] and x <= array[high]:

@pragatipal, kindly solve this bug.

Okay I'd fix it
On Sat, 28 Nov 2020, 11:50 Abhijit Tripathy<EMAIL_ADDRESS>wrote:

Some Bugs in Linear Search and Interpolation Search:

In Linear Search If we find our searched elements then we need to
break the loop, no further traversing required, same with Interpolation
Search.
In Interpolation search the condition is wrong while low <= high
and array[low] <= array[high] it should be while low <= high and x >=
array[low] and x <= array[high]:

@pragatipal https://github.com/pragatipal, kindly solve this bug.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Abhijit2505/eduAlgo/issues/55#issuecomment-735045967,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ6RDDJO2RFYUMBJZ2HG2OLSSCJCDANCNFSM4UEKYTWA
.

In line no. 448 of sort.py.  return statement is missing in quick sort.

I have the following code:
from edualgo import algorithms as al
ping = al.search_algorithms()
arr = [10, 9, 4, 5, 7, 8]
ping.linear_search(arr, 5, True)

The script is saved as edualgo_try.py and I try to execute the script in Command Prompt as follows:
python edualgo_try.py > output.txt

As you can see, I am trying to save the output in a file called output.txt. But, I get an error which is as follows:
Traceback (most recent call last):
  File "edualgo_try.py", line 4, in <module>
    ping.linear_search(arr, 5, True)
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\site-packages\edualgo\algorithms.py", line 1254, in linear_search
    self.linear_search_hint()
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\site-packages\edualgo\algorithms.py", line 1297, in linear_search_hint
    print_msg_box(message)
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\site-packages\edualgo\__init__.py", line 13, in print_msg_box
    print(box)
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 0-99: character maps to <undefined>

However if I remove the True parameter in the linear_search() method, I am getting the output saved in the file output.txt.
Linear Search Runtime = 0.0
Please have a look into this.

I have the following code:
from edualgo import algorithms as al
ping = al.search_algorithms()
arr = [10, 9, 4, 5, 7, 8]
ping.linear_search(arr, 5, True)

The script is saved as edualgo_try.py and I try to execute the script in Command Prompt as follows:
python edualgo_try.py > output.txt

As you can see, I am trying to save the output in a file called output.txt. But, I get an error which is as follows:
Traceback (most recent call last):
  File "edualgo_try.py", line 4, in <module>
    ping.linear_search(arr, 5, True)
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\site-packages\edualgo\algorithms.py", line 1254, in linear_search
    self.linear_search_hint()
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\site-packages\edualgo\algorithms.py", line 1297, in linear_search_hint
    print_msg_box(message)
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\site-packages\edualgo\__init__.py", line 13, in print_msg_box
    print(box)
  File "C:\Users\smv1999\AppData\Local\Programs\Python\Python36\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 0-99: character maps to <undefined>

However if I remove the True parameter in the linear_search() method, I am getting the output saved in the file output.txt.
Linear Search Runtime = 0.0
Please have a look into this.

from edualgo import algorithms as al
ping = al.search_algorithms()
arr = [10, 9, 4, 5, 7, 8]
ping.linear_search(arr, 5, True)

Hey @smv1999 ,
Thank you for reaching out regarding the bug, which is actually a feature we would like to implement in our future updates.
True is passed as a parameter for the console hint methods as that method contains few characters used in the formatting of the console output, those characters need to be encoded into UTF-8 in order to get printed into a text file.
Moreover, the hint methods are designed for the console purpose only and the similar text methods will be added in our next update where you don't have to explicitly add $ python code_file.py > output.txt,
But you can just use our text function (coming in next update), and pass your file name as a parameter in order to get the work done.
Thank you for reporting this feature and as you have demanded it, out next version will have the text methods as direct applications.

from edualgo import algorithms as al
ping = al.search_algorithms()
arr = [10, 9, 4, 5, 7, 8]
ping.linear_search(arr, 5, True)

Hey @smv1999 ,
Thank you for reaching out regarding the bug, which is actually a feature we would like to implement in our future updates.
True is passed as a parameter for the console hint methods as that method contains few characters used in the formatting of the console output, those characters need to be encoded into UTF-8 in order to get printed into a text file.
Moreover, the hint methods are designed for the console purpose only and the similar text methods will be added in our next update where you don't have to explicitly add $ python code_file.py > output.txt,
But you can just use our text function (coming in next update), and pass your file name as a parameter in order to get the work done.
Thank you for reporting this feature and as you have demanded it, out next version will have the text methods as direct applications.

Some icons are not visible

Some icons are not visible

That's another repo, where the website work is present, please contribute to that one.

No output will be print on binary search when target element is present at the end of the array.
I would like to contribute to your repository under WOC'24. I have also submitted my proposal for the same.


blinky example waiting for embassy_stm32::rcc::init() on STM32H735 Discovery Kit

Hi there 👋
I recently attempted to run the blinky.rs example on an STM32H735 Discovery Kit.
I updated the .cargo/config.toml runner:
runner = 'probe-run --chip STM32H735IGKx'

and Cargo.toml embassy-stm32 features list:
embassy-stm32 = { version = "0.1.0", path = "../../embassy-stm32", features = ["defmt", "stm32h735ig", "time-driver-any", "exti", "memory-x", "unstable-pac", "chrono"] }

After inspecting the backtrace, it seems to be stuck here:
https://github.com/embassy-rs/embassy/blame/main/embassy-stm32/src/rcc/h.rs#L334
    // Validate the supply configuration. If you are stuck here, it is
    // because the voltages on your board do not match those specified
    // in the D3CR.VOS and CR3.SDLEVEL fields. By default after reset
    // VOS = Scale 3, so check that the voltage on the VCAP pins =
    // 1.0V.
    #[cfg(any(pwr_h7rm0433, pwr_h7rm0399, pwr_h7rm0455, pwr_h7rm0468))]
    while !PWR.csr1().read().actvosrdy() {}

I probed 1.3V on the the VCAP pins here:

This issue might be related:
https://github.com/embassy-rs/stm32-data/issues/260
That said, I don't have a strong grasp on how this STM32 data is generated.
I'm pretty early investigating this and plan on reading over RM0468 and studying this more.
Thanks in advance!

Hello again,
So, I think I've figured out what's wrong.
I realized the default rcc supply config doesn't match the dev kit. From the dev kit user manual:

So, I tried changing the example's rcc supply config to SupplyConfig::DirectSMPS.
    let mut config = embassy_stm32::Config::default();
    {
        use embassy_stm32::rcc::*;
        config.rcc.supply_config = SupplyConfig::DirectSMPS;
    }
    let p = embassy_stm32::init(config);

Unfortunately, this didn't resolve my issue. I also had to perform these steps as documented in the user manual:

I haven't figured out where in the reference manual this 'deadlock' state is documented.
That said, the example runs now after performing those recover steps.
Thanks!


better execute method

[ ] provide exit code
[ ] figure out a uniform interface for all the container engines (parameters (such as capabilities, env, user))
[x] provide sync and async variant

exit_code method exists, and we have stable API implemented.


Start tests of preferences.js to cover basic module structure.

Currently the src/preferences.js has no test coverage. It would be helpful to have a test class that at least loads the module and validates that the module structure matches the expected.  The first two tests covering sf_calls.js provide a pattern to work from.
Any additional test coverage is also welcome and appreciated.

I have started with this issue first and made the first test for the validation of exports. Now moving on the next one, test for getCurrentPreferences(). I am getting a error for this line Here , which is EACCES: permission denied, mkdir '/path' . Can you help me with this?

Thanks for work on this!  It's great to have more people contributing.
The existing Electron mock provides a fake response for the app.getPath call in line 6 (I had rather forgotten it was there, or would get triggered here, but clearly it does).  That's giving your an invalid path when fs-extra tries to make sure the preference file exists.
You can probably create a Jest mock for fs-extra that provides a response to this call and the readfilesync call in line 48 (which assumes the file exists because of the ensurefilesync call that's tripping you up.  It's possible there are Jest mock's around in their own library for fs-extra as well, I've never looked.  But since you're learning Jest, and there are only a couple functions that need to be mocked, it probably makes sense to give it a try.  We don't really want valid file system calls in the testing process anyway -- fs-extra has its own tests for that and would just mean this project's tests needed to do more clean up.

@imrishabh18 if you create a Pull Request with what you have so far I may be able to help you continue to move the contribution forward.

Okay, this is what I have currently.

I've merged PR #77, but there is still plenty of test coverage needed here.
As I noted in comments on that PR:

The next low hanging fruit would be to validate that the internals of the module are correct like in the SF Calls tests. You'll notice that it's using a special __get__() function provided by rewire.
With those done try tests of the action functions one at a time. Start with setWindow() since it doesn't do any type checking nothing about Electron or the existing mocks will matter. Then you will have your feet under you a bit more and can dive into trying to resolve the mock issue we discussed in the main issue.

Closed with #175


Azure-CLI-ml :  AuthenticationException. Reason: InvalidCertificate upon deployment of service

Related command
az ml model deploy
Describe the bug
Upon deploy from Azure DevOps, command exits with exit code 1 with the following error
2022-08-12T11:07:14.3500930Z ERROR: {'Azure-cli-ml Version': '1.41.0', 'Error': WebserviceException:
2022-08-12T11:07:14.3501918Z 	Message: Received bad response from Model Management Service:
2022-08-12T11:07:14.3502408Z Response Code: 400
2022-08-12T11:07:14.3503858Z Headers: {(removed)}
2022-08-12T11:07:14.3505791Z Content: b'{"code":"BadRequest","statusCode":400,"message":"The request is invalid.","details":[{"code":"KubernetesUnaccessible","message":"Kubernetes error: AuthenticationException. Reason: InvalidCertificate"}],"correlation":{"RequestId":"bd52bc7c-647b-4644-ab8c-a827cc9321c3"}}'
2022-08-12T11:07:14.3506896Z 	InnerException None
2022-08-12T11:07:14.3507264Z 	ErrorResponse
2022-08-12T11:07:14.3507611Z {
2022-08-12T11:07:14.3507928Z     "error": {
2022-08-12T11:07:14.3510066Z         "message": "Received bad response from Model Management Service:\nResponse Code: 400\nHeaders: 'removed'}\nContent: b'{\"code\":\"BadRequest\",\"statusCode\":400,\"message\":\"The request is invalid.\",\"details\":[{\"code\":\"KubernetesUnaccessible\",\"message\":\"Kubernetes error: AuthenticationException. Reason: InvalidCertificate\"}],\"correlation\":{\"RequestId\":\"bd52bc7c-647b-4644-ab8c-a827cc9321c3\"}}'"
2022-08-12T11:07:14.3512114Z     }
2022-08-12T11:07:14.3512436Z }}

Update: Same result from on-prem.
To Reproduce
Execute az ml model deploy towards K8s backed AzureML-setup
Expected behavior
Should deploy without errors.
Environment summary
Azure DevOps.
AZ CLI: Version      : 2.198.0
Additional context
Seems like it's also failing in the Azure Portal.

route to CXP team

Resolved. Issue is related to AKS-clusters created prior to auto-renewal of certification was introduced.
In order to resolve this, the AKS-certificate needs to be manually rotated.
https://docs.microsoft.com/en-us/azure/aks/certificate-rotation#manually-rotate-your-cluster-certificates

Hi
I am getting below error while deploying ML model using Azure ACI in Azure DevOps. This looks similar to the once posted above. Any advice to resolve this error would be much appreciated.
2022-08-21T14:18:28.8019137Z ERROR: {'Azure-cli-ml Version': '1.41.0', 'Error': WebserviceException:
2022-08-21T14:18:28.8021344Z 	Message: Service deployment polling reached non-successful terminal state, current service state: Failed
2022-08-21T14:18:28.8023039Z Operation ID: 619e7c5f-7543-4966-9ede-fd9571138a23
2022-08-21T14:18:28.8024222Z More information can be found here:
2022-08-21T14:18:28.8024849Z Error:
2022-08-21T14:18:28.8025363Z {
2022-08-21T14:18:28.8025914Z   "code": "EnvironmentBuildFailed",
2022-08-21T14:18:28.8027062Z   "statusCode": 400,
2022-08-21T14:18:28.8028425Z   "message": "Failed building the Environment. You can try debugging locally first. Please refer to https://aka.ms/debugimage#debug-locally for more information."
2022-08-21T14:18:28.8029354Z }
2022-08-21T14:18:28.8029910Z 	InnerException None
2022-08-21T14:18:28.8030541Z 	ErrorResponse
2022-08-21T14:18:28.8031076Z {
2022-08-21T14:18:28.8031589Z     "error": {
2022-08-21T14:18:28.8033663Z         "message": "Service deployment polling reached non-successful terminal state, current service state: Failed\nOperation ID: 619e7c5f-7543-4966-9ede-fd9571138a23\nMore information can be found here: \nError:\n{\n  "code": "EnvironmentBuildFailed",\n  "statusCode": 400,\n  "message": "Failed building the Environment. You can try debugging locally first. Please refer to https://aka.ms/debugimage#debug-locally for more information."\n}"
2022-08-21T14:18:28.8035873Z     }
2022-08-21T14:18:28.8036369Z }}
Regards,
Pradeep

Quite sure this not related. Your issue seems to be related to building of environment rather than SSL certa being invalid.


Quick fix for broken tenant commands in admin CLI

During the last merge (threading support in vmdk_ops) we accidentally broke tenant commands in admin CLI. No, they did not have unit test coverage - and this will be addressed in a separate PR (Issue #668 -  The same PR will also take care of re-using the  get_auth_mgt() function from auth.py)
This PR applies a quick bandaid by defining the missing function and moving it (and related _auth_mgr) global to admin CLI code.
// @shaominchen @lipingxue
Tested: manually. Was throwing exception before the fix. Now does the following:
[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py tenant create --name oneTenant
tenant create succeeded
[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py tenant ls
Uuid                                  Name       Description  Default_datastore  VM_list
------------------------------------  ---------  -----------  -----------------  -------
2955e3ed-fec5-4d49-b878-ab0eb493704b  oneTenant               default_ds
[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py tenant rm oneTenant
tenant rm succeeded
[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py tenant ls
Uuid  Name  Description  Default_datastore  VM_list
----  ----  -----------  -----------------  -------

[root@localhost:~]

LGTM


FEATURE - EXT - Smart Home Page - Phase 1

As a user, I would like to be presented with Guided Answer content that is relevant to me be it the last content I visited, my bookmarks or content that relevant to my development  set up so that I can quickly find content that will resolve my issues faster
Description
Phase 1 of the new smart home page will show end users

Content they last visited
Saved bookmarks
Quick Filters that is relevant to the end users dev space. ( SBAS only)

The Last Visited, Bookmarks and Quick Filters will be displayed in separate sections on the Home page.  If there is no content to be displayed in these sections they will not be displayed on the Home page.
On opening the Guided Answers extension the smart Home page will always be displayed to the end users.
When a Guided Answer is opened the Home link will always return end users to the Smart Home Page
The Step back link will always navigate the user to their previously viewed page in the Guided Answer extension.
The SAP Logo displayed in the search returned list will also navigate the end user to the Smart Home Page.
Last visited
Last visited content will only display if the end user has  used the Guided Answers extension before and has visited a Guide.
The last visited content will always be updated with the last Guided Answer node the end user visited. It will only show the last node visited. On selection of the last visited Guided Answer node the user will be navigated to that node.
Bookmarks
Bookmarks will only display if the end user has bookmarked Guided Answer content previously.
The end user can remove their bookmarks from the home page without having to navigate to the Guided Answer content. When an end user removes a bookmark it will remain listed in the bookmarked list but will no longer be marked with a book mark star. When the user navigates away from the smart home page and then return then the bookmarked content will be no longer be displayed in the bookmark list.
Quick Filters
Dependent on the end users dev space in SAP Business Application Studio Guided Answers can be filtered based on the Fiori Dev space components. On clicking a quick filter the Guided Answers content will be filtered on a set of components. The Guided Answers will be displayed in a list with the filters applied displayed.
Currently there is not quick filters for VS Code just SAP Business Application Studio
Technical Design
In the backend we will save 5 of the last visited Guided Answers nodes but only the very last visited node will be displayed.
Visual Design
The Guided Answer search is centered.
There will be up two columns displaying the different sections. Each column can display up to 2 sections.
If only 2 sections are displaying only one column will displayed and it will be centered.
https://www.figma.com/file/XSZw3w81MYY0QPe1BoUcBO/Guided-Answers?type=design&node-id=0-1&t=FLF3rPRRQoiCKIcU-0
Interaction Design
VSCODE

Users Opens GA - Smart Home Page is displayed only a centered search is displayed,
User searches for a guide
User selects a guide
User navigates through a guide
User bookmarks a node in the guide
User clicks Home - Smart Home Page is displayed with a centered search input field , a section show the last visited node and a section showing the bookmarked guide.
User closes GA
User opens GA - Smart Home Page is displayed with a centered search input field , a section show the last visited node and a section showing the bookmarked guide.
User clicks on star beside the  bookmarked guide - Bookmark section displays the bookmark but the star is no longer filled with yellow.
10 Users clicks last visited - User is navigated to the last visited node
User navigates to another node in that tree - Last updated guided is updated
User clicks 'Home' - Smart Home Page is displayed with a centered search input field , a section showing the last visited node, the bookmark section is no longer displaying.
User closes GA
User opens GA - Smart Home Page is displayed with a centered search input field, a section showing the last visited node, the bookmark section is no longer displaying.
User enters input in search input field- Search results are displayed
User clicks on the SAP logo - Smart Home Page is displayed with a centered search input field is displayed, a section showing the last visited node
16  User enters input in search input field- Search results are displayed
User clears the search input using backspace or clicks on the 'X' icon in the search in put - ??

SBAS

Users Opens GA - Smart Home Page is displayed only a centered search  and Quick filters section is displaying showing a filter for the following components.
User click on quick filter - List of guides are displayed to user with the filters applied.
User selects a guide
User navigates through a guide
User bookmarks a node in the guide
User clicks Home - Smart Home Page is displayed with a centered search input field , a section showing the last visited node ,section showing the bookmarked guide and a section showing quick filters. All sections are centered.
User closes GA
User opens GA - Smart Home Page is displayed with a centered search input field , a section showing the last visited node ,section showing the bookmarked guide and a section showing quick filters. All sections are centered.
User clicks on star beside the  bookmarked guide - Bookmark section displays the bookmark but the star is no longer filled with yellow.
10 Users clicks last visited - User is navigated to the last visited node
User navigates to another node in that tree - Last updated guided is updated
User clicks 'Home' - Smart Home Page is displayed with a centered search input field , a section showing the last visited node  and a section showing quick filters. All sections are centered. Bookmark section is no longer being displayed.
User closes GA
User opens GA - Smart Home Page is displayed with a centered search input field , a section showing the last visited node  and a section showing quick filters. All sections are centered. Bookmark section is no longer being displayed.
User enters input in search input field- Search results are displayed
User clicks on the SAP logo - Smart Home Page is displayed with a centered search input field , a section showing the last visited node  and a section showing quick filters. All sections are centered. Bookmark section is no longer being displayed
16  User enters input in search input field- Search results are displayed
User clears the search input using backspace or clicks on the 'X' icon in the search in put - ??

Acceptance Criteria

User can search for a guide using the Smart Home page
After use of the extension , the user can see their last visited guides
After bookmarking guides, the user can their bookmarked guides on the smart home page
The smart home page displays a quick filter for Fiori Dev Spaces in SBAS.
The user can un bookmark a guide from the Smart Home page
The user can navigate back to the smart home page using the Home button or the SAP logo.

Notes
Tasks

[ ]
[ ] Unit Tests added
[ ] Test Cases defined

new home layout has been merged and is behind the beta features toggle

last visited sections has been merged

@oliversberzs As part of this ticket, please make sure that in GA, after providing outcome/feedback for a particula tree, whether an issue has solved the problem or not, from the pop up, Home button should take us to new GA Home Page.


feat(FX-3325): Update the display of size filter labels for saved search M2

The type of this PR is: Feature

This PR resolves FX-3325
More context you can find in Slack
Examples
Example 1

Values

minimum width 5
minimum height 10
maximum height 15

Labels

w: from 5 in or w: from 5 cm
h: 10-15 in or h: 10-15 cm

Example 2

Values

minimum width 5
maximum width 10
minimum height 15
maximum height 20

Label

w: 5-10 in or w: 5-10 cm
h: 15-20 in or h: 15-20 cm

Example 3

Values

minimum width 5
minimum height 15

Label

w: from 5 in or w: from 5 cm
h: from 15 in or h: from 15 cm

Example 4

Values

maximum width 5
maximum height 15

Label

w: to 5 in or w: to 5 cm
h: to 15 in or h: to 15 cm

Demo
iOS
https://user-images.githubusercontent.com/3513494/134199053-8fb78eb6-692e-4136-8875-eea2430a6098.mp4

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Update the display of size filter labels for saved search M2 - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Update the display of size filter labels for saved search M2 - dimatretyak)

  Generated by :no_entry_sign: dangerJS against b05e4be214c3d37430261d8cd1fb844b908ef9d1


Provide single quote separators around missing Cargo.toml fields to improve readability

Before these changes, the CLI output would read:
[4/8] 📂  Creating a pkg directory...
[5/8] 📝  Writing a package.json...
⚠   [WARN]: Field description is missing from Cargo.toml. It is not necessary, but recommended
⚠   [WARN]: Field repository is missing from Cargo.toml. It is not necessary, but recommended
⚠   [WARN]: Field license is missing from Cargo.toml. It is not necessary, but recommended
Which confused me at first glance, as I read literally that a field description was missing.  After this change, the output would be:
[4/8] 📂  Creating a pkg directory...
[5/8] 📝  Writing a package.json...
⚠   [WARN]: Field 'description' is missing from Cargo.toml. It is not necessary, but recommended
⚠   [WARN]: Field 'repository' is missing from Cargo.toml. It is not necessary, but recommended
⚠   [WARN]: Field 'license' is missing from Cargo.toml. It is not necessary, but recommended
Which I feel reads a bit better :)

Heh, @ashleygwilliams beat me to it :-p


remove storage update from rds upgrade workflow

validate max length of dbclaim name(to accommodate for max rds name len)
default postgres version 15.3
drop prefix "dbc" from rds name
rds now provides so downtime storage update. This eliminates the need for using rds upgrade for storage update.
routed storage update through update workflow instead of upgrade workflow.
This also required crossplane 0.42 to work.

breaking change do not merge

supersedes #160


Console window on C# project

Hi,
I'm trying to create  a Godot game that has the main game window, but also the actual console window (native console). This is for accessibility purposes - blind players can use the console window naturally with a screen reader to hear descriptions of the game and type in commands.
I seem to always explain this poorly, so here's a simple video of what it looks like: https://twitter.com/nightblade99/status/1191919468882145280/video/1
I wrote this project in MonoGame, and simply edited the csproj of the default project to be a console project. I tried the same thing with Godot, but evidently it uses the compiled library, so it won't work.
Is there any way to create something like this in Godot? I'm looking for a Windows (ideally, desktop) C# project with a native (not emulated) console.

Godot in debug mode (non-release) is a console application by default. Is it different with Mono?

Godot in debug mode (non-release) is a console application by default. Is it different with Mono?

I don't know. The built-in console outputs a fair amount of debug information, warnings, etc. so it's not suitable for use by players who use a screen-reader. I also can't write Console.ReadLine or something similar and get the input back, so I can't use it as an input device.
Or did I misunderstand what you mean?

Hmmm, I don't think it's possible to have, like, another console. The console you see in Godot IS the native console, so it's impossible to use it in another way.
But if it's for accessibility purposes, you might be interested in this #14011

I suspected as much.
Thanks for the feedback. I'll look into the screen reader issue you mentioned.


Setup.sh Runs and Hangs never launches web page to get token

I've triple checked all of my Amazon credentials for this device on the developers portal and compared them with what appears in the cred file and they match.
This is the last thing I see in terminal after I run setup.sh  Alexa Error log appears below.  Any idea what's wrong here?
Object "=" is unknown, try "ip help".
[02/May/2016:18:01:56] ENGINE Listening for SIGHUP.
[02/May/2016:18:01:56] ENGINE Listening for SIGTERM.
[02/May/2016:18:01:56] ENGINE Listening for SIGUSR1.
[02/May/2016:18:01:56] ENGINE Bus STARTING
CherryPy Checker:
The Application mounted at '' has an empty config.
Alexa Error Log
Starting Alexa...
python: can't open file ' /root/AlexaPi/main.py' : : [Errno 2] Mp such file or directory
I used the installer app and the path on my pi to the main.py file is /home/pi/AlexaPi/main.py
Thanks in advance for any insights you can provide?

The setup script isn't the best in version1.0, its improved in 1.1 and should give a few more pointers.
I think there are 2 issues, firstly if you havn't completed the web oAuth process to get a refresh token from amazon into the creds.py file you'll need to do that, you can either re-run the setup or just run python ./auth_web.py  which will start the webserver then goto http://[IP OF PI]:5000 to start the oAuth.
The init.d script expects AlexaPi to be installed in /root/AlexaPi which is why its failing to autostart, you can either re-install it there or edit the path in /etc/init.d/Alexa

Sam,
Thanks for the quick response. Much appreciated.
I was able to retrieve the refresh token using your suggestion and now my creds file is complete.
I edited the initd_alexa.sh file to reflect my install path /home/pi/AlexaPi/main.py
and htis is what it looks like now.
start)
echo "Starting Alexa..."
python /home/pi/AlexaPi/main.py &
;;
stop)
echo "Stopping Alexa.."
pkill -f /home/pi/AlexaPi/main.py/main.py
Rebooted pi and ran python ./auth_web.py and I"m still getting this as a response in termnal.
pi@raspberrypi:~/AlexaPi $ sudo python ./auth_web.py
[03/May/2016:12:13:11] ENGINE Listening for SIGHUP.
[03/May/2016:12:13:11] ENGINE Listening for SIGTERM.
[03/May/2016:12:13:11] ENGINE Listening for SIGUSR1.
[03/May/2016:12:13:11] ENGINE Bus STARTING
CherryPy Checker:
The Application mounted at '' has an empty config.
[03/May/2016:12:13:11] ENGINE Started monitor thread 'Autoreloader'.
[03/May/2016:12:13:11] ENGINE Started monitor thread '_TimeoutMonitor'.
[03/May/2016:12:13:11] ENGINE Serving on http://<IP_ADDRESS>:5000
[03/May/2016:12:13:11] ENGINE Bus STARTED
Not sure what I may be doing wrong here?
Frank
----- Original Message -----
From: "Sam Machin"<EMAIL_ADDRESS>To: "sammachin/AlexaPi"<EMAIL_ADDRESS>Cc: "fskemery"<EMAIL_ADDRESS>"Author"<EMAIL_ADDRESS>Sent: Tuesday, May 3, 2016 9:31:24 AM
Subject: Re: [sammachin/AlexaPi] Setup.sh Runs and Hangs never launches web page to get token (#72)
The setup script isn't the best in version1.0, its improved in 1.1 and should give a few more pointers.
I think there are 2 issues, firstly if you havn't completed the web oAuth process to get a refresh token from amazon into the creds.py file you'll need to do that, you can either re-run the setup or just run python ./auth_web.py which will start the webserver then goto http://[IP OF PI]:5000 to start the oAuth.
The init.d script expects AlexaPi to be installed in /root/AlexaPi which is why its failing to autostart, you can either re-install it there or edit the path in /etc/init.d/Alexa
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

You don't need to run auth_web.py everytime it's only needed the first time
to sign in.
After a reboot AlexaPi should be ready to go, it auto starts on boot and
when ready you should hear a 'hello' sound through the speaker followed by
3 flashes on the playback LED.
Press and hold your button, speak a command then release.
On Tuesday, 3 May 2016, fskemery<EMAIL_ADDRESS>wrote:

Sam,
Thanks for the quick response. Much appreciated.
I was able to retrieve the refresh token using your suggestion and now my
creds file is complete.
I edited the initd_alexa.sh file to reflect my install path
/home/pi/AlexaPi/main.py
and htis is what it looks like now.
start)
echo "Starting Alexa..."
python /home/pi/AlexaPi/main.py &
;;
stop)
echo "Stopping Alexa.."
pkill -f /home/pi/AlexaPi/main.py/main.py
Rebooted pi and ran python ./auth_web.py and I"m still getting this as a
response in termnal.
pi@raspberrypi:~/AlexaPi $ sudo python ./auth_web.py
[03/May/2016:12:13:11] ENGINE Listening for SIGHUP.
[03/May/2016:12:13:11] ENGINE Listening for SIGTERM.
[03/May/2016:12:13:11] ENGINE Listening for SIGUSR1.
[03/May/2016:12:13:11] ENGINE Bus STARTING
CherryPy Checker:
The Application mounted at '' has an empty config.
[03/May/2016:12:13:11] ENGINE Started monitor thread 'Autoreloader'.
[03/May/2016:12:13:11] ENGINE Started monitor thread '_TimeoutMonitor'.
[03/May/2016:12:13:11] ENGINE Serving on http://<IP_ADDRESS>:5000
[03/May/2016:12:13:11] ENGINE Bus STARTED
Not sure what I may be doing wrong here?
Frank
----- Original Message -----
From: "Sam Machin"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
To: "sammachin/AlexaPi"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','AlexaPi@noreply.github.com');>>
Cc: "fskemery"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','fskemery@comcast.net');>>, "Author" <
<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','author@noreply.github.com');>>
Sent: Tuesday, May 3, 2016 9:31:24 AM
Subject: Re: [sammachin/AlexaPi] Setup.sh Runs and Hangs never launches
web page to get token (#72)
The setup script isn't the best in version1.0, its improved in 1.1 and
should give a few more pointers.
I think there are 2 issues, firstly if you havn't completed the web oAuth
process to get a refresh token from amazon into the creds.py file you'll
need to do that, you can either re-run the setup or just run python
./auth_web.py which will start the webserver then goto http://[IP OF
PI]:5000 to start the oAuth.
The init.d script expects AlexaPi to be installed in /root/AlexaPi which
is why its failing to autostart, you can either re-install it there or edit
the path in /etc/init.d/Alexa
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/sammachin/AlexaPi/issues/72#issuecomment-216636834

Just got back to this project and connected the buton to the GPIO board. NO leds instaled yet.
When I push the button I'm getting this error message
pi@raspberrypi:~/AlexaPi $ python main.py
Checking Internet Connection
Connection OK
Traceback (most recent call last):
File "main.py", line 151, in
start()
File "main.py", line 127, in start
rf = open(path+'recording.wav', 'w')
IOError: [Errno 13] Permission denied: '/home/pi/AlexaPi/recording.wav'
Can you tell me what's wrong with my setup?
Thanks
Frank
----- Original Message -----
From: "Sam Machin"<EMAIL_ADDRESS>To: "sammachin/AlexaPi"<EMAIL_ADDRESS>Cc: "fskemery"<EMAIL_ADDRESS>"Author"<EMAIL_ADDRESS>Sent: Tuesday, May 3, 2016 1:03:16 PM
Subject: Re: [sammachin/AlexaPi] Setup.sh Runs and Hangs never launches web page to get token (#72)
You don't need to run auth_web.py everytime it's only needed the first time
to sign in.
After a reboot AlexaPi should be ready to go, it auto starts on boot and
when ready you should hear a 'hello' sound through the speaker followed by
3 flashes on the playback LED.
Press and hold your button, speak a command then release.
On Tuesday, 3 May 2016, fskemery<EMAIL_ADDRESS>wrote:

Sam,
Thanks for the quick response. Much appreciated.
I was able to retrieve the refresh token using your suggestion and now my
creds file is complete.
I edited the initd_alexa.sh file to reflect my install path
/home/pi/AlexaPi/main.py
and htis is what it looks like now.
start)
echo "Starting Alexa..."
python /home/pi/AlexaPi/main.py &
;;
stop)
echo "Stopping Alexa.."
pkill -f /home/pi/AlexaPi/main.py/main.py
Rebooted pi and ran python ./auth_web.py and I"m still getting this as a
response in termnal.
pi@raspberrypi:~/AlexaPi $ sudo python ./auth_web.py
[03/May/2016:12:13:11] ENGINE Listening for SIGHUP.
[03/May/2016:12:13:11] ENGINE Listening for SIGTERM.
[03/May/2016:12:13:11] ENGINE Listening for SIGUSR1.
[03/May/2016:12:13:11] ENGINE Bus STARTING
CherryPy Checker:
The Application mounted at '' has an empty config.
[03/May/2016:12:13:11] ENGINE Started monitor thread 'Autoreloader'.
[03/May/2016:12:13:11] ENGINE Started monitor thread '_TimeoutMonitor'.
[03/May/2016:12:13:11] ENGINE Serving on http://<IP_ADDRESS>:5000
[03/May/2016:12:13:11] ENGINE Bus STARTED
Not sure what I may be doing wrong here?
Frank
----- Original Message -----
From: "Sam Machin"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
To: "sammachin/AlexaPi"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','AlexaPi@noreply.github.com');>>
Cc: "fskemery"<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','fskemery@comcast.net');>>, "Author" <
<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','author@noreply.github.com');>>
Sent: Tuesday, May 3, 2016 9:31:24 AM
Subject: Re: [sammachin/AlexaPi] Setup.sh Runs and Hangs never launches
web page to get token (#72)
The setup script isn't the best in version1.0, its improved in 1.1 and
should give a few more pointers.
I think there are 2 issues, firstly if you havn't completed the web oAuth
process to get a refresh token from amazon into the creds.py file you'll
need to do that, you can either re-run the setup or just run python
./auth_web.py which will start the webserver then goto http://[IP OF
PI]:5000 to start the oAuth.
The init.d script expects AlexaPi to be installed in /root/AlexaPi which
is why its failing to autostart, you can either re-install it there or edit
the path in /etc/init.d/Alexa
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/sammachin/AlexaPi/issues/72#issuecomment-216636834

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


Fix typo and remove unused import

Also the doc should be updated in
https://developers.google.com/cloud-messaging/android/start

Run the sample
First, make sure your API key is provided as the value of API_KEY in line 36 of GcmSender.java

LGTM, and I will file an issue to get the docs changed.


[ja] tralslate abstraction.md into japanese

translate ja
lang/ja
Describe your changes
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)
[x] This PR does not contain plagiarism
    don’t copy other people’s work unless you are quoting and contributing it to them.
[x] I have signed off on all commits
    signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@kaitoii11
review、ありがとうございます！


Add database options to ParseServer constructor and pass to MongoStorageAdapter

This should allow being able to pass options when connecting to MongoDB, such as setting the connection pool size.

Current coverage is 90.51%

Merging #956 into master will decrease coverage by -0.84% as of d90a9d4

@@            master    #956   diff @@
======================================
  Files           73      73
  Stmts         4324    4331     +7
  Branches       863     864     +1
  Methods          0       0
======================================
- Hit           3950    3920    -30
  Partial         10      10
- Missed         364     401    +37

Review entire Coverage Diff as of d90a9d4

Powered by Codecov. Updated on successful CI builds.

@steven-supersolid could you add a few tests there to make sure the adapter is loaded with the proper options etc...

LGTM


Error TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object.

Hi,
I am having trouble with adding a thing. Here's what I get in command line:
debug:
{ chaincodeID: 'a0ed64f9efff851b8f03b6e3fa28e4822f6bfeb2c16ca1761f3a2754a4fb0tee',
  fcn: 'update_things',
  args:
   [ '11223344',
     { id: '11223344', description: 'Piano Forte' },
     'test' ] }
Error TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object.
    at fromObject (buffer.js:262:9)
    at Function.Buffer.from (buffer.js:101:10)
    at new Buffer (buffer.js:80:17)
    at /Users/user/Documents/Work/fabric-boilerplate/node_modules/hfc/lib/hfc.js:2301:40
    at Array.map (native)
    at prepend (/Users/user/Documents/Work/fabric-boilerplate/node_modules/hfc/lib/hfc.js:2301:14)
    at TransactionContext.newInvokeOrQueryTransaction (/Users/user/Documents/Work/fabric-boilerplate/node_modules/hfc/lib/hfc.js:1564:32)
    at /Users/user/Documents/Work/fabric-boilerplate/node_modules/hfc/lib/hfc.js:1019:18
    at /Users/user/Documents/Work/fabric-boilerplate/node_modules/hfc/lib/hfc.js:1179:20
    at TCertGetter.getNextTCert (/Users/user/Documents/Work/fabric-boilerplate/node_modules/hfc/lib/hfc.js:1651:20)
info: POST /api/v1/thing/update 500 2.193 ms - 21

This happens in this line:
// Invoke the request from the user object.
        var tx = user.invoke(invokeRequest);

The debug in the first code shows invokeRequest, after that it fails.

Please nevermind the issue. This was due to incorrect passing of a parameter.


How can I replace multiple images in one pod?

I have two containers in one pod and I would like to replace images in both of them during "dev". How can I do that?
I can't replace the same pod twice using any selector and I can't define multiple "replaceImage" with "containerName".
Thanks.

You mean in replacePods? Besides replaceImage, it also supports patches that you can use to patch the spec. Does that answer your question?

You mean in replacePods? Besides replaceImage, it also supports patches that you can use to patch the spec. Does that answer your question?

Yes. Do I understand it correctly replacePods works the same as if I patched it? Or is there any difference?

@johnnypea its different in that replacePods will actually replace the whole pod, while profile patches will only replace parts of the config before deploying it.
Regarding your question to replace multiple images in the same pod, you can do that via replaceImage and patches, however in patches, you are only able to reference a static image tag and not a dynamically built one

Thanks @FabianKramm , but I can still replace only one image in pod using replaceImage, right?

@johnnypea Yes you can. You don't need profiles at all for this. You just need replacePods and the patches field that it has. See this example: https://devspace.sh/cli/docs/configuration/development/replace-pods#example-overwrite-command-and-args-of-a-pod
Instead of overwriting command and args, you can just overwrite the image for the container with index 1 (example uses container with index 0)

Closing this since the questions is answered. Feel free to reopen if there is a need for further clarifications.


Replace pydocstyle with Ruff

Pydocstyle is deprecated.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 95.231%

Files with Coverage Reduction
New Missed Lines
%

qiskit_addon_aqc_tensor/simulation/explicit_gradient.py
1
93.68%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.2%

Covered Lines:
599

Relevant Lines:
629

💛  - Coveralls

@Mergifyio backport stable/0.1


Maintain consistent IDs across the portal

User need: with users leveraging the portal to train their models, we need to make sure all IDs on the portal are staying consistent and not changing.
Current state:

dataset IDs do not change
other IDs such as run ID, tomogram ID, annotation ID, etc. may stop existing but they are not reassigned (corner case)

cc: @uermel @manasaV3 @kandarpksk

@kandarpksk perhaps we can tag this as part of API improvements to enable ML Challenge?
@manasaV3 is there a dependency on prefixes? otherwise wouldn't it be considered a change if we're going from 2480 to AN-2480?

@junxini We will support the current ids and the ids with prefix. Those will be tracked by two different fields.


Support mturk sandbox using an :endpoint_prefix option

The endpoint for mturk is composed by a prefix (mturk-requester), the region (e.g., us-east-1) and aws-elixir client's endpoint (e.g., amazonaws.com).
Since mturk supports a sandboxed mode, the final endpoint is slightly different with a prefix of mturk-requester-sandbox.
This PR makes it possible to pass an optional endpoint prefix (:endpoint_prefix) in mturk's calls. E.g.:
AWS.MechanicalTurk.list_h_i_ts(client, %{}, endpoint_prefix: "mturk-requester-sandbox")

By default the prefix is set as the previously used mturk-requester.

Thanks!


Optical flow for feature tracking

hi @cashiwamochi , Thanks for sharing such a nice work. Could you kindly provide some suggestions if I want to track two features in two images based on your code?
Currently, I want to test the feature tracking using optical flow. In other words, I would like to achieve the function as the function "calcOpticalFlowPyrLK", but I do want to use the calcOpticalFlowPyrLK function directly from the OpenCV library.
Thanks a lot in advance,
Best,
Weisong,

Hello, Weisong
If you want to use this algorithm in feature tracking, firstly we have to make sure that this optimization works with small patch (e.g. 21x21). If it works, we can track features like SVO( http://rpg.ifi.uzh.ch/docs/ICRA14_Forster.pdf, Sec4.B ).
By the way, I don't know your motivation to avoid OpenCV's LK tracker. If you want something same as calcOpticalFlowPyrLK, this implementation isn't what you want. This algorithm iteratively optimize photometric error, and ( if my knowledge is not too old ) calcOpticalFlowPyrLK doesn't do it.

Hi @cashiwamochi , Thanks for your kind reply. I am sorry that I did not correct explain my question. In fact, I do not want to direct use the function "calcOpticalFlowPyrLK " in OpenCV due to some reasons. Thanks for your great code, I expect to implement the calcOpticalFlowPyrLK for feature tracking based on your code (this package). Currently, your code is used for planar tracking. My understanding is that your code is used to track the certain planar area, kindly please correct me if I am not correct :-)
Therefore, if I want to track, for example 10 features with patch size of  (e.g. 21x21). Could you please kindly let me know roughly how should I achieve this?
Thanks a lot in advance.
Best,
Weisong,

Thanks @weisongwen for kind explanation.
Now I understand what you want to do.

My understanding is that your code is used to track the certain planar area
Yes, this is correct. Additionally let me note that, this implementation is different from the algorithm of calcOpticalFlowPyrLK. The former minimizes photometric error iteratively and the latter just solves equation. ( If my knowledge about OpenCV isn't too old )

Could you please kindly let me know roughly how should I achieve this?
As I commented, firstly we need to make sure that this implementation works with small patch.
If it works, we need to re-write API of this algorithm, because actually this program is implemented to track only one planar image to show performance of Lucas-Kanade's image alignment.

By the way, we need to think about how to use image pyramid. But this work would be done after those above action items.
If you need support, I will work on this issue when I have time.
Thanks.

Dear @cashiwamochi,
Thanks for your kind reply and sorry for my late reply as I spend some time to look into your code before replying you 👍
I find that your code does not work with the smaller patch (e.g. one pixel). I will implement the multi-layers pyramids for optical tracking in the coming week. I will let you know if I got some issues or finish this.
Best,
Weisong,

Hello @weisongwen

I find that your code does not work with the smaller patch (e.g. one pixel).
Theoretically, this algorithm never work with one pixel patch. When it tries to track a patch from frameA to frameB, patch in frameB must be overlapped partially with patch in frameA.
( Sorry, I wrote this just in case so that you never make any mistake about it )

I will let you know if I got some issues or finish this.
Let me close the issue now. When you have any topic or issue, please reopen.

Thanks

Hi @cashiwamochi ,
Thanks for your kind reply. I will let you know if I got any updates 👍
Best,
Weisong,

error:M_PI未声明的标识符


Fix buggy formula for critically-damped springs

Fixes #109675.
This formula would produce an initial velocity quite different from the one specified as an argument.
To update the test, I computed the expected results separately by using the physical formula.
Happily, the framework by default never ends up actually exercising this code.  Of the four SpringDescription call sites within the framework, two are explicitly overdamped; the other two are by design critically damped, but due to rounding they end up being treated as (very slightly) overdamped too.  Details here:
https://github.com/flutter/flutter/issues/109675#issuecomment-1423674855
So the only way an app could be affected by this bug is if it called a SpringDescription constructor itself, and managed to create a spring description where the distinguishing formula in _SpringSolution comes out exactly equal to zero.  It's likely nobody has ever shipped such an app, because the behavior this produces would be so wildly wrong that it'd be hard to miss when exercised.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I agree with your (very detailed) assessment of this and the potential impact! I am running this through some extra testing up front as well.

Thanks for the testing and reviews!
I see the "Google testing" check is pending. I'll rebase in hopes of unwedging that.


Potentially incorrect Host Name during DHCP

Hi.
There are following lines of code inside module dhcp.c in functions send_DHCP_DISCOVER() and send_DHCP_REQUEST() :
	// host name
	pDHCPMSG->OPT[k++] = hostName;
	pDHCPMSG->OPT[k++] = 0;          // fill zero length of hostname
	for(i = 0 ; HOST_NAME[i] != 0; i++)
   	pDHCPMSG->OPT[k++] = HOST_NAME[i];
	pDHCPMSG->OPT[k++] = DHCP_CHADDR[3];
	pDHCPMSG->OPT[k++] = DHCP_CHADDR[4];
	pDHCPMSG->OPT[k++] = DHCP_CHADDR[5];
	pDHCPMSG->OPT[k - (i+3+1)] = i+3; // length of hostname

This code adds the last three bytes of the MAC address to the constant DCHP_HOST_NAME, which in sum forms the full DHCP host name. The problem may occur if MAC address contains bytes smaller than 0x20. Some routers (for example, Zyxel Keenetic Omni II) in this case cease to display the page with DHCP clients list at all.
I propose to replace the above code with the following:
	// host name
	pDHCPMSG->OPT[k++] = hostName;
	pDHCPMSG->OPT[k++] = 0;          // fill zero length of hostname
	for(i = 0 ; HOST_NAME[i] != 0; i++)
   	pDHCPMSG->OPT[k++] = HOST_NAME[i];
	pDHCPMSG->OPT[k++] = NibbleToHex(DHCP_CHADDR[3] >> 4);
	pDHCPMSG->OPT[k++] = NibbleToHex(DHCP_CHADDR[3]);
	pDHCPMSG->OPT[k++] = NibbleToHex(DHCP_CHADDR[4] >> 4);
	pDHCPMSG->OPT[k++] = NibbleToHex(DHCP_CHADDR[4]);
	pDHCPMSG->OPT[k++] = NibbleToHex(DHCP_CHADDR[5] >> 4);
	pDHCPMSG->OPT[k++] = NibbleToHex(DHCP_CHADDR[5]);
	pDHCPMSG->OPT[k - (i+6+1)] = i+6; // length of hostname

and to add function NibbleToHex():
char NibbleToHex(uint8_t nibble)
{
  nibble &= 0x0F;
  if (nibble <= 9)
    return nibble + '0';
  else
    return nibble + ('A'-0x0A);
}

thank you. update it after checking.


alternative to dependsOn from v4, conditional fields

is there a way to show a field depending on value of other field?
in v4 I could do
Field.add({
  valueType: {
    type: Types.Select,
    numeric: true,
    options: [{ value: 1, label: 'String' },
              { value: 2, label: 'Blob' },
              { value: 3, label: 'Integer' }]
  },
  howMany: {
    type: Integer,
    dependsOn: { valueType: 4 }
  },
})

We don't yet have a dependsOn option, but we've captured some initial ideas in #312. I'll mention dependsOn there so we can keep track 👍


GitHub authorization has changed

Hello,
I don't know if you are aware but GitHub has changed its authentication method, on May 5, 2021: see here and here.
In fact, as I try to add my Github repo, StackEdit receives this error:
{
    "status": 400,
    "body": {
        "message": "Must specify access token via Authorization header. https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param",
        "documentation_url": "https://docs.github.com/v3/#oauth2-token-sent-in-a-header"
    }
}

Anyway...
GitLab integration is not working, GitHub is not working either now.
What should we do?
I hope in a quick fix, thank you very much.

I guess it's the same as #1724.
But it doesn't seem fixed...

{
    "status": 400,
    "body": {
        "message": "Must specify access token via Authorization header. https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param",
        "documentation_url": "https://docs.github.com/v3/#oauth2-token-sent-in-a-header"
    }
}

Anyway...
GitLab integration is not working, GitHub is not working either now.
What should we do?

Same problem here, I granted access to Github so I could sign in from StackEdit and it worked fine, but when I try to add a workspace from Github I get an "HTTP Error 400" sign and this:

Yeah, that's the exact error I get too.
It should be simple to change how the token is sent, if only some dev would reply us... @benweet

Getting the same exact error, bumping.

For the time being, I developed a workaround. I know there already is #1724  that fixes the issue, but I wanted to keep using StackEdit whilst the request is not yet merged.
Once you are on the screen asking you to  "Grant access to your private repositories," open the developer console and paste the following lines.
window.XMLHttpRequest =  class MyXMLHttpRequest extends window.XMLHttpRequest {
  open(...args){
    if(args[1].startsWith("https://api.github.com/user?access_token=")){
      // apply fix as described by github
      // https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/#changes-to-make

      const segments = args[1].split("?");
      args[1] = segments[0]; // remove query params from url
      const token = segments[1].split("=")[1]; // save the token

      const ret = super.open(...args);

      this.setRequestHeader("Authorization", `token ${token}`); // set required header

      return ret;
    }
    else {
      super.open(...args);
    }
  }
}

This overrides window.XMLHttpRequest, which StackEdit uses to send API-Requests to GitHub, and modifies requests to https://api.github.com/user. Specifically, it moves the token from query to header.
Once the repository is connected, you can remove the overridden XMLHttpRequest by reloading the page.

Thank you @mogoe1!

Thank you! Ran into this problem this morning...

@benweet Can confirm issue still persists as of today

{
  "message": "Must specify access token via Authorization header. https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param",
  "documentation_url": "https://docs.github.com/v3/#oauth2-token-sent-in-a-header"
}

Yeah, just right now

@mogoe1 thank you!!!

big up @mogoe1

Heads up to other recently-frustrated StackEdit users-
From all appearances, the project maintainer is gone. He has had 0 Github activity since March of last year: https://github.com/benweet
I've tried searching for any news items about him, checking for career changes/death announcements/ etc, but without success.
With 8+ months of silence from the solo maintainer, I recommend people start finding/creating alternatives. I know I would be very happy to support someone forking this and taking it into the future :)

also had the impression of the project being unmaintained now...  meanwhile I switched to Obsidian, which i really love.... Migration is quite easy.

This is still an ongoing issue.
Any news on this being added upstream

For the time being, I developed a workaround. I know there already is #1724 that fixes the issue, but I wanted to keep using StackEdit whilst the request is not yet merged.
Once you are on the screen asking you to "Grant access to your private repositories," open the developer console and paste the following lines.
window.XMLHttpRequest =  class MyXMLHttpRequest extends window.XMLHttpRequest {
  open(...args){
    if(args[1].startsWith("https://api.github.com/user?access_token=")) {
      // apply fix as described by github
      // https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/#changes-to-make

      const segments = args[1].split("?");
      args[1] = segments[0]; // remove query params from url
      const token = segments[1].split("=")[1]; // save the token

      const ret = super.open(...args);

      this.setRequestHeader("Authorization", `token ${token}`); // set required header

      return ret;
    }
    else {
      return super.open(...args);
    }
  }
}

This overrides window.XMLHttpRequest, which StackEdit uses to send API-Requests to GitHub, and modifies requests to https://api.github.com/user. Specifically, it moves the token from query to header.
Once the repository is connected, you can remove the overridden XMLHttpRequest by reloading the page.

Thanx a lot.  I know there already is #1724 that fixes the issue, but I wanted to keep using StackEdit whilst the request is not yet merged.
Once you are on the screen asking you to "Grant access to your private repositories," open the developer console and paste the following lines.
window.XMLHttpRequest =  class MyXMLHttpRequest extends window.XMLHttpRequest {
  open(...args){
    if(args[1].startsWith("https://api.github.com/user?access_token=")) {
      // apply fix as described by github
      // https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/#changes-to-make

      const segments = args[1].split("?");
      args[1] = segments[0]; // remove query params from url
      const token = segments[1].split("=")[1]; // save the token

      const ret = super.open(...args);

      this.setRequestHeader("Authorization", `token ${token}`); // set required header

      return ret;
    }
    else {
      return super.open(...args);
    }
  }
}

This overrides window.XMLHttpRequest, which StackEdit uses to send API-Requests to GitHub, and modifies requests to https://api.github.com/user. Specifically, it moves the token from query to header.
Once the repository is connected, you can remove the overridden XMLHttpRequest by reloading the page.

also had the impression of the project being unmaintained now... meanwhile I switched to Obsidian, which i really love.... Migration is quite easy.

Thank you - great recommendation! :)

Same here ... Above code snippet worked for me (16.02.2023). I do afraid something happened to this developer. Hope he is alive.

Same here, JS snippet worked for me (16.03.2023)
Also, the fact that I even have to do this is fvking annoying.

I still get the error despite the workaround. Any chances of fixing the issue for good by merging #1724?

Thank you @mogoe1!

It is clear that it won't be fixed, the maintainer basically left this project.
I switched to using Github itself for note taking, it has great editor features, even on mobile.
But to create new file on mobile, I use this app:
GitJournal. The version controll sounds like a nice feature in this flow :)
I tried some free tier of paid software as Obsidian/Notion, but for me is did not fit. In PM I am open for similar free software recommendations.

Should be fixed with v5.15.0.

Heads up to other recently-frustrated StackEdit users- From all appearances, the project maintainer is gone. He has had 0 Github activity since March of last year: https://github.com/benweet I've tried searching for any news items about him, checking for career changes/death announcements/ etc, but without success. With 8+ months of silence from the solo maintainer, I recommend people start finding/creating alternatives. I know I would be very happy to support someone forking this and taking it into the future :)

did you end up forking it.?
let me know I can contribute, I love this project.


Basic tests for wallet connect expected state

related to #422

I found these tests in a stash, think I started working on them before realizing we couldn't go much further with wc
Thought we might as well add these basic checks as they are.


max length option for text input

I believe there is no such option to set the max length for text input. we need to validate manually. can you please add that as an option so that developer can set?

It has been added:  https://github.com/vitalets/x-editable/pull/990/files

it's not working for me, i have created fiddle to show this. can you please tell me what i am doing wrong here?

The correct JS file is dist/bootstrap-editable/js/bootstrap-editable.js

after adding this version i am getting $.fn.popover.defaults is undefined. when this update will be available for latest CDN js?


[Bug]: After the automatic authorization document jumps, the page is blank

ODC version
ODC4.2.1
OB version
Oceanbase4.1.0
What happened?
After the automatic authorization document jumps, the page is blank

What did you expect to happen?
Jump normal
How can we reproduce it (as minimally and precisely as possible)?
After the automatic authorization document jumps, the page is blank
Anything else we need to know?
No response
Cloud
No response

fixed in dev-4.2.2

pass


Furnace Nightmare

Good Day
The furnaces are being de-registered for users if they are feeding items into the furnace from hoppers. Why is this? After each smelt or cook a player has to right click the furnace again to register it and then will get paid for that one smelt only. This is the case with normal furnaces as well as epicfurnaces. I have come across this on other servers as well, this become this way after one of your previous updates. Is there a setting somewhere where the furnace just allows people to be paid and feed in with hoppers?

In generalConfig.yml, this:

Thanks going to give a try now

I have mailed you a video so you can see :)

Oh.. Do you want to turn off the Furnace protection?
Then find out this:

Whether I have re-assign set to true or false furnaces still de-register, should I send you my yml file to your mail address?

Ok I have mailed to you.

So that is the my only issue, when you feed into furnace with hopper it de-registers the furnace and you have to right click every smelt to get it to register the furnace again. This means that you can only get paid if you don't use hoppers into furnaces.

Ok, I checked the video and the screenshot. For this furnace registration, needs to restart the server to save the furnace in the file.

Just a restart? I have done that a few times. Or do you mean a complete reset or wipe?

I don't know why not work for you. I tested it now and it's work correctly for me.
Are you using the latest version at all?

I seem to have gotten to work now, I thank you for your time and patience :)


Improved resource parsing

Hello @joshdholtz ,
this pull request adds the following features and fixes:
Features

parse and set self link on resource
add convenience method - (void)addProperty:(NSString*)name withJsonName:(NSString *)json to class JSONAPIResourceDescriptor.

Bugfixes

fix code in method - (void)inflateWithResource:(NSObject <JSONAPIResource> *)resource on class JSONAPI, current implementation resulted in a crash
update specs and fixtures for fixes above

Best Regards,
tarbrain

@tarbrain Thank you for the contribution :raised_hands: Going to merge this in This will be included in my v1.1.0 release that should hopefully be out tonight :heart:


Quick start easy development setup buttons

Suggested new feature or improvement
As someone new to development, it can be complex to get your machine up and working.  With WinGet configure DSC files, we can quickly get your system setup with a single click./
Scenario
No response
Additional details
No response

I started some of the work with:

https://github.com/microsoft/devhome/pull/1031

We have several development paths referenced at Microsoft Learn. I've been working with our documentation experts to update those to suggest using WinGet for the "manual" instructions, and to get them updated once we have sample configurations checked in here under configuration Samples for use with Dev Home.
I've also been looking at the [Windows Dev Box Setup Scripts]https://github.com/microsoft/windows-dev-box-setup-scripts project. And I believe we should include those configurations as well. We should probably mark that repository as no longer active as well, and provide a reference to Dev Home.
Crawl: Update the documentation at Microsoft Learn to use WinGet.
Walk: Get samples checked in here and directly reference Dev Home for the pages at Microsoft Learn.
Run: Some kind of lovely UI to describe the development paths and an "easy button" inside Dev Home.


Plugin will work if i click the video before

Plugin will work if i click the video before. how to resolve it?

I'm not sure I understand, do you mean it will only work if you click the video first?
If so, the video player requires focus (clicking) in order to use hotkeys.
This is the same case for other video players such as Youtube.

yes. it will work if i click the vide first?  you have solution for this? because hotkey from video  vid.me  work without click the video first. you can check this : https://vid.me/WaJr

That site is probably using something similar to:
videojs('video-player').ready(function() {
    this.el().focus();
});

Which focuses the video player upon load.
If you don't auto-play the video, you could also do something like this upon clicking the poster/play button to force focus:
videojs('video-player').ready(function() {
    videojs('video-player').on('play', function() {
        this.el().focus();
    });
});

Thank you so much.. it works... :)

this hotkey not work if the video fullscreen. right?

Yes, It should work while fullscreen.  It works fine in fullscreen in all my tests.


[IR][Bugfix] Improvements to the normalizer and well-formed checker

This PR addresses the issues discussed in https://github.com/tlc-pack/relax/issues/283. In particular:

If node and Function node bodies are always normalized into SeqExprs.
The body field of a SeqExpr must be a "leaf" node, i.e., not a nested expression (except for tuples, per the discussion in #283).
Bug fixes: The normalizer now ensures that the tuple_value field in a TupleGetItem node and the cond field in an If node are leaf expressions or are otherwise bound to a var.
The well-formed checker makes sure the above constraints are enforced.

The PR also includes some bugfixes in the debug AST printer. Namely, If nodes and TupleGetItem nodes are shared with the Relay AST and so don't have a shape_ field, so the AST printer will not check for the shape_ field (this is arguably a bad thing and a reason to decouple the Relax AST from the Relay one).

Thanks for the suggestion, Yuchen. This actually highlighted to me that I had missed a case: the op argument to Call nodes. Is there a way to construct a local function in parser right now? I am not sure how I can bind a function value to a variable right now in order to test that we normalize this case correctly.
Incidentally, I had to modify the checked_type_ check to skip OpNodes because we don't assign Op nodes a type. Not sure that we should, but just pointing it out.

Thanks for the suggestion, Yuchen. This actually highlighted to me that I had missed a case: the op argument to Call nodes. Is there a way to construct a local function in parser right now? I am not sure how I can bind a function value to a variable right now in order to test that we normalize this case correctly.
Incidentally, I had to modify the checked_type_ check to skip OpNodes because we don't assign Op nodes a type. Not sure that we should, but just pointing it out.

Yes, the parser does support local function, an example: https://github.com/tlc-pack/relax/blob/relax/tests/python/relax/test_transform_lambda_lift.py#L69-L73. Inner is a local func bound to a Var. And on line 75, the rhs is a CallNode whose op field is a Var (named "inner" that binds to the local func).
Op does not need to have a type for now, since it wouldn't need to be bound to a Var.