Using @JsProperty for properties with periods in the name causes type errors

Hi, thanks for your work on this project!
I'm not entirely sure whether this is a bug or a feature request, but definitely an interesting case I ran into.
Describe the bug
I am trying to use the (archived, yet still in prod) Settings API in B2G using JsInterop types. Very briefly, the SettingsLock#get(key) method takes a settings key (which is generally one of these), and returns a DOMRequest object. If reading from settings succeeds, the request's result object will look something like this:
"result": {
  "deviceinfo.os": "2.0.0"
}

So, in this case, the value I am interested in is "2.0.0".
Here is a very simplified version of the types I'm using:
// Navigator.java

@JsType(isNative = true, namespace = JsPackage.GLOBAL)
public class Navigator {

    @JsProperty(name = "mozSettings")
    public native SettingsManager getSettings();
}

// SettingsManager.java

@JsType(isNative = true, namespace = JsPackage.GLOBAL)
public class SettingsManager {

    @JsMethod
    public native SettingsLock createLock();
}

// SettingsLock.java

@JsType(isNative = true, namespace = JsPackage.GLOBAL)
public class SettingsLock {

    @JsMethod
    public native <T> DOMRequest<T> get(String key);
}

// Callback.java

@JsFunction
public class Callback {
    public run();
}

// DOMRequest.java

@JsType(isNative = true, namespace = JsPackage.GLOBAL)
public class DOMRequest<T> {

    @JsProperty
    public native T getResult();

    @JsProperty(name = "onsuccess")
    public native void setOnSuccess(Callback onSuccess);
}

// DeviceOSResult.java

@JsType(isNative = true, namespace = JsPackage.GLOBAL)
public class DeviceOSResult {

    @JsProperty(name = "deviceinfo.os")
    public native String getDeviceOS();
}

And then I would want to use this like so:
// DeviceSettings.java

public class DeviceSettings {

    public void getDeviceOS(Navigator navigator) {
        SettingsLock lock = navigator.getSettings().createLock();
        DOMRequest<DeviceOSResult> request = lock.get("deviceinfo.os");
        request.setOnSuccess(() -> {
            String os = request.getResult().getDeviceOS();
            // Do something with OS
        });
    }
}

This code transpiles to (simplified):
var os = request.result.deviceinfo.os;

And then instead of the value, as you may expect, I get:
TypeError: Cannot read property 'os' of undefined

You can try reproduce this with the code above.
Expected behavior
This is definitely a strange API, and indeed it was not accepted and didn't make it's way into the spec. It is still implemented in B2G, however, and there are devices in the wild using it.
That being said, ideally, I would expect this to transpile to something like:
var os = request.result["deviceinfo.os"];

However, I would be happy to hear from you all if there might be a better, simpler way of getting this value from the result object, since this is such a niche API.
So I'm happy to hear other options or discuss how to potentially fix properties like this.
Either way, thank you for you time! 💟💟💟

From my PoV this is actually a feature. You'll want to use a JsMap or similar here.

Thanks for your reply!
Could you point me to what exactly do you mean by JsMap, I couldn't find any info about apart from this class in GwtQuery. Is that what you mean?

Sorry, I actually meant JsPropertyMap, from jsinterop-base: https://javadoc.io/doc/com.google.jsinterop/base/1.0.0-RC1

I see, wasn't familiar with that.
Funnily enough, as a temporary solution, before writing this issue, I did end up implementing something very similar with the JSNI for doing return object[key];. I was hoping there would be a solution which wouldn't require JSNI though.
Either way, gonna close this issue, but happy to hear if you have any more thoughts.
Thanks again for the help!


CPU time optimalization

It seems to me that tomighty is eating CPU for no reason, it seems to me that the update function is called every second which is completely unnecessary (i have this impression from https://github.com/ccidral/tomighty/blob/master/src/main/java/org/tomighty/time/CountdownTimer.java#L37 ), the solution is simple: the update function should be called only every minute unless it is in active state (popup has been activated or time < 1m) because most of the time tomighty is in inactive state and it needs to change the time/icon in tray only once per minute. I would do this by myself but I do not have any experience with java...
Thank you for reading this.

Can you tell me a bit about your system (hardware and OS)?  On my machine (Intel i7, Windows 7) Tomighty consumes practically zero CPU time.  When the time changes it should not consume any significant amount of CPU time.

I am running Ubuntu Natty and Tomighty 0.7.1,
visgean@rewitaqia:~$ java -version
java version "1.6.0_22"
OpenJDK Runtime Environment (IcedTea6 1.10.4) (6b22-1.10.4-0ubuntu1~11.04.1)
OpenJDK 64-Bit Server VM (build 20.0-b11, mixed mode)
I have this processor http://ark.intel.com/products/42925/Intel-Pentium-Processor-T4500-(1M-Cache-2_30-GHz-800-MHz-FSB) it´s last Dual-Core according to this list http://en.wikipedia.org/wiki/List_of_Intel_Pentium_Dual-Core_microprocessors . Tomighty is eating constantly 1% of cpu time. But it does not matter my point still is that it´s useless to run the update function every second since any changes are only once per minute...


Add and test Hashie::Mash#reverse_merge

Fixes #270. I had to bump Rubocop's max class length. If that's a problem, some refactoring will be necessary.
This will define reverse_merge even when ActiveSupport is not included. One solution is to wrap the definition with if method_defined? :reverse_merge.

This is good, thanks. Can you squash these commits, please? Thanks.

Squashed. Thanks.

Merged.


Name refactoring

I left out a commit

realized I need to update docs for this. will do that real quick

actually, i would have to do it again when azure blob gets merged. I'll wait for one to be merged then update the other to have both changes


Add comments to source code

Added a comment with a TODO and changed code on typesystem.py for code quality.

I will close this PR as it doesn't makes sense anymore.


net/textproto: fails when headers contain invalid headers

What version of Go are you using (go version)?

$ go version
go version go1.18.3 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What did you do?
See example: https://go.dev/play/p/OLfq5WlWCMf (with a fake UTF colon)
What did you expect to see?
I expect that textproto.ReadMIMEHeader will return parsed headers, skip failed headers and return an error if any along with parsed headers:
Read headers: map[Date:[Mon, 23 Jun 2015 11:40:36 -0400] Subject:[Gophers at Gophercon] To:[Another Gopher<EMAIL_ADDRESS>
What did you see instead?
I see only first parsed header: Date:[Mon, 23 Jun 2015 11:40:36 -0400]
Further headers are not parsed.
See also: https://github.com/golang/go/issues/53854

In general it cannot safely skip malformed headers, since the malformation may affect the parsing of subsequent lines.
This is also consistent with the other go standard library functions that return on first error.
Closing as working as intended


Returning null in a function provided to telemetry.addData causes NPE

Calling telemetry.addData("foo", () -> null); in an OpMode will cause a NullPointerException at org.firstinspires.ftc.robotcore.internal.opmode.TelemetryImpl$Value.compose(TelemtryImpl.java:134) when telemetry is being updated.
The decompiled code doesn't make the reason immediately obvious.

When you call telemetry.addData("foo", () -> null);, you are adding a data point to the telemetry with the name "foo" and a value supplier that returns null. This means that when the telemetry tries to update and compose the data to be sent to the driver station, it will try to call the compose() method on the value supplier, which will throw a NullPointerException because the value supplier is returning null.
To avoid this error, you should make sure that the value supplier returns a non-null value or remove the call to telemetry.addData("foo", () -> null); if you do not actually need to add data with a null value to the telemetry.


Setting files.insertFinalNewline inserts final newlines into notebook cells

Type: Bug
This felt a bit unexpected to me and I can't remember this happening in earlier versions of VSCode, so I would assume this is a regression: Setting files.insertFinalNewline should not insert final newlines into every cell of a Jupyter notebook. I use that setting to make sure that all files use a final newline in accordance with Unix conventions for files and in the case of notebooks I would expect it to save the underlying JSON file with a final newline, not the code cells themselves.
VS Code version: Code 1.83.0 (e7e037083ff4455cf320e344325dacb480062c3c, 2023-10-03T16:13:10.518Z)
OS version: Darwin arm64 23.0.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
3, 3, 4

Memory (System)
16.00GB (0.06GB free)

Process Argv
--enable-proposed-api genuitecllc.codetogether

Screen Reader
no

VM
0%

Extensions (60)

Extension
Author (truncated)
Version

ruby-debug
cas
0.3.5

vscode-eslint
dba
2.4.2

java-decompiler
dgi
0.0.3

gitlens
eam
14.3.0

EditorConfig
Edi
0.16.4

prettier-vscode
esb
10.1.0

curry
fwc
0.0.15

gyb
fwc
0.0.2

kotlin
fwc
0.2.32

go
gol
0.39.1

todo-tree
Gru
0.0.226

haskell
has
2.4.1

applescript
idl
0.25.0

latex-workshop
Jam
9.14.1

language-haskell
jus
3.6.0

openscad-language-support
Lea
1.2.5

restructuredtext
lex
189.3.0

vscode-clangd
llv
0.1.24

vscode-elixir
mjm
1.1.0

vscode-dotnet-runtime
ms-
1.8.0

isort
ms-
2023.10.1

python
ms-
2023.18.0

vscode-pylance
ms-
2023.10.10

jupyter
ms-
2023.9.1102792234

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

remote-ssh
ms-
0.106.5

remote-ssh-edit
ms-
0.86.0

hexeditor
ms-
1.9.12

remote-explorer
ms-
0.4.1

ppm-pgm-viewer-for-vscode
ngt
1.1.5

vala
pri
1.0.8

prolog
reb
0.0.4

ruby
reb
0.28.1

java
red
1.23.0

vscode-xml
red
0.26.1

vscode-yaml
red
1.14.0

rust-analyzer
rus
0.3.1689

scala
sca
0.5.7

metals
sca
1.25.0

crates
ser
0.6.3

shader
sle
1.1.5

swift-lang
ssw
1.5.2

ninja
sur
0.0.1

even-better-toml
tam
0.19.2

cmake
twx
0.0.17

errorlens
use
3.14.0

vscode-lldb
vad
1.10.0

non-breaking-space-highlighter
vik
0.0.3

vscode-java-debug
vsc
0.54.0

vscode-java-dependency
vsc
0.23.1

vscode-java-pack
vsc
0.25.14

vscode-java-test
vsc
0.40.0

vscode-maven
vsc
0.42.0

vim
vsc
1.26.1

debug
web
0.26.1

vscode-ruby
win
0.28.0

cuesheet
zgm
0.3.0

I believe this is close enough to the issue mentioned just above (#195011) to be closed as a duplicate. I will be looking into bringing in an ipynb specific override, as I see the value in having more granular control over the application of these whitespace related settings to notebooks.

would expect it to save the underlying JSON file with a final newline

As for this, @fwcd, I believe that underlying JSON is already saved with a newline. Please file an issue if you are not seeing that happen.

Would it be possible to reopen this issue?
I don't believe this issue is a duplicate of https://github.com/microsoft/vscode/issues/195011, because that issue is a feature request. However, the issue described here is clearly a bug, and I'm assuming bugs and feature requests are treated with different priorities.

Hi @dime10, thanks for your input on this issue. This issue isn't treated as a regression as the behavior was introduced intentionally and is just an adjustment to the way that the files.xyz whitespace settings are being respected within the different editor types. Discussions among the notebook team landed with us wanting to align cell-editor behavior with standard file editor behavior, and this led to the files whitespace settings being used in notebooks now.
There will be a discussion in the future regarding a possible notebook-editor specific settings override, as it is clear that a number of notebook users are wanting the final newline behavior to be disabled at the minimum. If this behavior is causing any breaking behavior or is blocking anything that was previously functional, please let me know and I can take a look at this with a higher priority. For now, this will likely be addressed in a future iteration.
This closed issue and #195011 are referring to the same behavior, and this issue has been closed in favor of tracking the conversation in that central location.

This issue isn't treated as a regression as the behavior was introduced intentionally

You may not call it a regression but for many people it is.

... blocking anything that was previously functional ...

It is basically blocks me from using notebooks via vs code as I would need to constantly changing files.insertFinalNewline back and forth....

Sorry for the noise, I'm cross-linking to the workaround I posted https://github.com/microsoft/vscode/issues/195011#issuecomment-1797050133 in the tangential open issue since it's relevant there, too.

Appreciate the input from folks. Currently working to push a quick change to separate the final newline behavior into a notebook specific setting until a solution or path forward for notebook specific settings is decided upon. I will update both this and the related issue with the setting name when things are merged.

You may not call it a regression but for many people it is.

@RafalSkolasinski Hopefully this setting is able to fix your issues with newline behavior. For the sake of understanding the problem space, I would love to know what about the final newline inside code cells is becoming a blocker for you? In my mind this was a papercut as the worst behavior was a newline, but it's clear that this has a greater effect on many people's workflows.

This setting is now unreleased, so upon the next insider build you will be able to add the following to your settings json:
"notebook.insertFinalNewline": false

@Yoyokrazy By when can we expect this setting to be released? It would be really helpful

By when can we expect this setting to be released? It would be really helpful

@ratulachakraborty could you clarify what you mean by released? This setting is already active in the current insiders build, however if you are referring to the stable release, the setting will be released with the next stable build of vscode (1.85) at the end of the month. Let me know if this doesn't quite answer your question.


support consul

When using Dubbo, I use consul for service discovery, but I found that only the support of consul metadata collection is available in Dubbo admin, so I added the support for consul service discovery. Local test is right, but I'm not sure if I need to change it.

Codecov Report

Merging #545 into develop will decrease coverage by 0.18%.
The diff coverage is 2.85%.

@@              Coverage Diff              @@
##             develop     #545      +/-   ##
=============================================
- Coverage      21.52%   21.33%   -0.19%
- Complexity       303      304       +1
=============================================
  Files             84       85       +1
  Lines           3428     3463      +35
  Branches         544      547       +3
=============================================
+ Hits             738      739       +1
- Misses          2614     2648      +34
  Partials          76       76

Impacted Files
Coverage Δ
Complexity Δ

...dmin/registry/config/impl/ConsulConfiguration.java
2.85% <2.85%> (ø)
1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b976ba2...ecd5d7a. Read the comment docs.


Detect changesets that are very likely to have problems

The 2 Parts
There are two parts to the problem:

High precision

High percentage of correct vs incorrect predictions or fewer false positives.
Ex: Predictions are right about 80% of the time but it finds less than 20% of all the problematic edits.

High recall

Find all or most of the problematic edits.
Ex: Finds 80% of all problematic edits but is right only 20% of the time.

Ideally, we want a model that has both high precision and high recall. :innocent: But, practically we can only hit one at a time. And once we hit one well, we work on the other problem to hit that out too.

With this ticket, I would like to propose:

Building a model that can predict changesets that are VERY LIKELY TO HAVE PROBLEMS.
Tackle the first problem of HIGH PRECISION
Model is right about 80% of the time but finds less than 20% of all the problematic changesets.

cc: @anandthakker @geohacker @batpad

Tweaked the current just a little, instead of giving problematic changesets extra weight, gave them equal weights as the good changesets to get things going. This, is one of the ways where we tell the model to choose accuracy over recall. The following is what I found:
Validation dataset

Changesets labelled problematic + predicted problematic came down from 166 to 138 (17% :arrow_down:)
Changesets labelled good + predicted problematic came down from 71 to 10 (86% :arrow_down:)

Testing dataset

Only 47 out of 19,741 was flagged as problematic (0.24%)

This is on the lines of what we want:

Model is right about 80% of the time but finds less than 20% of all the problematic changesets

While manually reviewing the list 47 changesets, noticed quite a lot of changesets where a feature with area=yes got modified into building=yes being flagged as problematic.

Using the notebook to find similar samples, I found the following changesets where the transformation was the same, feature with area=yes got modified into building=yes and quickly, labelled all these changesets on osmcha with a :thumbsup: so that we can reuse it as training data for the classifier.

Next actions

[ ] What difference will it make when we add ^ 10 labelled dataset into model training?

First run
In the first run, the 10 changesets were part of both the testing and training datasets. Since all data in testing was part of the training dataset, the model already knew the right answers for them. Thus, none of the 10 changesets was predicted as problematic. :innocent: 40 out of 19760 (0.2%) changesets in the testing dataset was flagged problematic.
Second run
For the second run, I split up the 10 changesets, 5 went to the training dataset and the other 5 to the testing dataset.

Training: First 5 changesets: 48372925, 48372423, 48373049, 48372436, 48421312
Testing: Other 5 changesets: 48422721, 48407981, 48344660, 48422923, 48409432

This time, only 23 out of 19760 (0.12%) changesets in the testing dataset were flagged as problematic. Once the model was trained, all changesets in training and testing datasets were predicted correctly as good. :tada:
Third run
This time, I swapped the training and testing datasets, the first 5 went to testing while the other 5 were part of the training dataset.

Training: Other 5 changesets: 48422721, 48407981, 48344660, 48422923, 48409432
Testing: First 5 changesets: 48372925, 48372423, 48373049, 48372436, 48421312

This time, 36 out of 19760 (0.18%) changesets in the testing dataset were flagged as problematic. Interestingly, all changesets in the training datasets were rightly predicted as good while 4 out of the 5 changesets in testing were predicted harmful. :disappointed:

I don't clearly understand why these subtle changes in results. Will go ahead with a random mix of these 10 changesets into both training and validation.


"ps-design-system-tab": does not support href attrubute

Enhancement Request
Desired behavior
It would be great if the Tab component had support for linking to items via href. The way that we use the tabs, each tab represents a distinct page with its own route.
Today's behavior
I have to use an onClick with a redirect. I can't do things like open in a new tab. Probably not great for screen readers, either.
The Value Add
Things that behave like links should be links for accessibility.
The Tradeoffs
There now needs to be logic to render tab items as either a button or a link depending on props provided.

Triage: we think this is a good idea to expore


fix fix fix

I mean... "Fix fix fix" is an awesome professional description which is in the release description 😂


pnpm silently fails with 0 exit code after update to graceful-fs 4.2.5

I don't know how this is possible but after graceful-fs has been updated to 4.2.5, pnpm silently fails during installation. There is no error printed and the exit code is 0. Downgrading graceful-fs fixes the issue.

Hi,
I'm the author of bit
I have this issue too.
Since version 4.2.5 our app is completely broken in production.
The process exists with code 0 just in the middle of the installation process.
Please help us out here with a new patch version.
Thanks in advanced

@zkochan @GiladShoham copyFile will miss the callback function if pass a flag, you can have a look at this: #202

4.2.6 has been released, should fix this issue.


Web component: Card In Card - Card Eyebrow text "Label" is not identified for the screen reader user.

Detailed description
On JAWS FF & VO iPhone safari
Issue:
Card Eyebrow text "Label" is not identified for the screen reader user.
Additional information
- This component was developed by Putra.  @RaphaelAmadeu The issue has been assigned to you to work with Putra on this fix.  This fix has been assigned to the March release and will be included in the fix pack scheduled to be created by Ignacio by Noon ET.

Circling back on this, there was a discussion with @proeung regarding the current approach with the eyebrow treatment and its usage in other cards. This traces back to the following issue:
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/4062
From Putra:
...my understanding is that the aria-hidden attribute that you guys have right now within the <dds-card-eyebrow> (see https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/master/packages/web-components/src/components/card/card-eyebrow.ts#L30) full-fills the requirement of the ticket mentioned above. Perhaps, this is a matter of informing the decision that was made to whoever is running the screen reader tests (JAWS or VoiceOver) that this result is false positive?
From this, we have decided to pull this out of the release, and will address either via documentation or perhaps targeting the element as role="presentation" instead.
FYI @RobertaJHahn @RaphaelAmadeu @ljcarot @andysherman2121 @shixiedesign

On the call with Praveen and Ram this morning, Ram clarified that the need here is for "Tab" key to continue focus only the card title, but still allow "Up" and "Down" arrow keys to move focus to other texts to be announced. This means we need to shuffle the markup a bit and the update should be made on the Card component so all things dependent on it gets the update. This been an issue for awhile it is tracked here ---

@jeffchew Thanks for looping me in this issue thread. Personally, I think it's important to make the DOM order match the visual order of the component and have these text be readable by screen-readers, however, I do understand that this direction might result in the verbose reading issue that @shixiedesign mentioned in this thread - https://ibm-marketing-comms.slack.com/archives/G01JR9YHU3W/p1615906169004600?thread_ts=1615900683.000200&cid=G01JR9YHU3W.
Since this is an issue (<dds-card-eyebrow>) that touches a lot of card components and not just the Card in Card, I figured that the solution/fix makes more sense coming from your team. Regardless, let me know if there's anything that I can do to help out as well.

Moved this fix to the April release, but added the Card issue (#4613 ) as a blocker.  An engineer should check to see whether this bug is fixed by the Card update mentioned in issue (#4613 )

Ariella's comment posted to issue (#4613 ).  Moving this issue to sprint 21-08.
We just confirmed with the team the changes that will be made for this issue to be closed, so next sprint I will finish this issue. 5504 and mostly all the other card accessibility bugs require this fix being made.

@ariellalgilmore Ram re tested this on both JAWS and Voiceover on the  link   - Working as expected.


Sketch out the Carebot architecture

(as few external dependencies as we can :) )

Current strategy:

Slackbot using the python API wrapper
Small python library for pulling the analytics we need that talks to the slackbot
Python Script for periodically pulling and saving the analytics we need
SQLite database for simplicity; may use the graeae Postgres database later if needed; will use the peewee ORM
Deployed to an EC2 small


Enhance observer

Modify Observer to not consume any messages
The Observer instead just gets the topics and partitions information
It compares with the received messages so far and invoke consumers if new message arrives

Closing as this PR supersedes this one

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
MaybeMonad, @shkomine, @Kornisburg, @tommy-ca, @harishpariyar07, @radi-ratlh, @smaranh, @marcinosypka, @alejandrohn, @ncanrd, @dev-tronchinadam4, @obiwan96, @JFWooten4, @juanitoddd, @billyliubj, @rcerf, @heyimhere, @amhofny, @codbugs, @justahuman1, @CodeFleck, @aazizrahmat, @hawkup, @Davidagasiev, @YourCryptoDoctor, @khinshankhan, @undefined-ar, @goodcopybruh, @hellocreep, @jayuuza, @mark-wang-beep, @myaltunay, @StijnBTC, @Dev568145, @fenghaolinroix, @why8023, @Shinshin100, @radkomih, @illucent, @sriharip316, @shellhue, @fengluo, @leonardssh, @longshengtang, @dgtzm99, @nathansdev, @BarisATAK, @vae520283995, @adfelippe, @chronic-underclocking

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
DiegoJose23, @B0y1n4o4, @abhishekroushan, @awelin, @SigmaEnterprise, @geofparent, @juandm, @Tazeg, @tonnystark, @TimothyOwen, @michaeldaigler, @DelevoXDG, @DetlefDmann, @TheBestOrNothing, @jcliby, @gasbasd, @r0maaz, @Protivsporta, @yixxas, @luancsl, @rgasch, @marooo000, @renatogravino, @McooLewis, @l0kihardt, @zdrawia, @david-gorski, @pygman, @w1seguyw1seguy, @JoaoVSouto, @BreakZero, @JiqiSun, @adam2k, @babyhome, @kunljha, @dygwon, @paradooxx, @upsideout, @adyssonferreira, @tommy-ca, @ryan-harrington, @antonsergeev88, @Limsanity, @yuasabe, @compassz, @gtrapp, @tim2CF, @cmosss, @pallablitz, @wuwentong


config file permission issue

Maybe related to https://github.com/jcdickinson/codeium.nvim/issues/5, random guess.

This is weird. What does stat ~/.cache/nvim/codeium/config.json give you? You can also override config_path in setup as a workaround.

Another reading issue:
Error detected while processing InsertEnter Autocommands for "*":
                                                                                │Failed to load Codeium API key
                                                                                │[codeium] [ERROR 08:56:59] ...owry/workspace/git-repos/codeium.nvim/lua/codeium/io.lua:94:
                                                                                │could not open  /Users/towry/.cache/nvim/codeium/config.json :  EACCES: permission denied:
                                                                                │/Users/towry/.cache/nvim/codeium/config.json

This is weird. What does stat ~/.cache/nvim/codeium/config.json give you? You can also override config_path in setup as a workaround.

16777220 190157834 ---------x 1 towry staff 0 51 "Jan 30 08:56:33 2023" "Jan 30 08:56:28 202│
3" "Jan 30 08:56:28 2023" "Jan 30 08:56:28 2023" 4096 8 0 config.json

Totally my mistake, I created the file with permissions of 1! You'll need to fix this by:
sudo chmod 666 $HOME/.cache/nvim/codeium/config.json

Please let me know if that works for you. My most recent commit addresses the issue.

fixed.


fix(transformer/nullish-coalescing-operator): incorrect reference flags

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5408  👈
#5407
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite


chore: change udf vec2array to pyspark.ml.functions.vector_to_array

What changes are proposed in this pull request?
vector_to_array was introduced in Spark 3.0 which replaces the need for udf vec2array.
How is this patch tested?

[x] Through notebook test automation
[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[x] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[x] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

Codecov Report

Merging #2131 (a3f1ff3) into master (90ded80) will decrease coverage by 77.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #2131       +/-   ##
==========================================
- Coverage   85.84%   8.53%   -77.32%
==========================================
  Files         312     312
  Lines       16470   16470
  Branches     1458    1458
==========================================
- Hits        14138    1405    -12733
- Misses       2332   15065    +12733

see 285 files with indirect coverage changes

/azp run

/azp run


Feature Request: Slide and Drag to select images in multiple mode

Mimick the native Photos Album, that allows you to slide across the images and drag the screen down to select multiple images on a drag rather than having to individually select all of them.

This is a great feature, really required for our use case.
Most of the times users needs to select a lot of images and it is quite exhausting to select each one by one.
Our android users have this feature long time ago, but our IOS users gets poor user experience lacking this feature.


Theme changes to light mode

First of all, want to applaud how much Fastmate has improved my workflow. Thank you @joelekstrom !
I'm using FastMail Beta, and after the recent update to Fastmate my these is constantly changing to the light version. Any other reports of whether this is on the client or FM Beta?

Hi, thank you 😊
I think this is dependent on your theme settings withing Fastmail itself - if you don't want it to automatically change to light mode you need to turn that functionality off:

Ah, interesting.
I don't have this toggle in Fastmail inside Fastmate. But I do see this option in beta.fastmail.com and it's not enabled.

To wrap up this issue, is it possible to force beta experience in Fastmate? I don't see it mentioned in readme.

@kashura: There is a setting in Fastmate preferences to use beta.

Thank you @rajiv .
Seems to then be an issue with non beta version. Switching to beta has eliminated this issue. I just switched back to regular FM and will keep an eye and see if the issue returns.
In case it helps, I am on Fastmate 1.8.0, and Monterey 12.0.1.
As my issue is resolved, I'm glad to close this or leave it open for a bit to see if the issue returns.


appollo-codegen does not supprt default_value for graphene.Field

Hi, I think there is an issue with appollo-codegen which does not handle default_value argument properly on the graphene.Field
This command will fail:
apollo-codegen introspect-schema http://<IP_ADDRESS>:8085/graphql --output schema.json
with error: error: Errors in introspection query result: [object Object]
when I have something like this:
class OrderingOptions(graphene.Enum):
    ASCENDING = ''
    DESCENDING = '-'

class MyOrderbyInput(graphene.InputObjectType):
    order = graphene.Field(OrderingOptions, default_value=OrderingOptions.ASCENDING)

Note that when I remove default_value=OrderingOptions.ASCENDING schema generation will pass without errors.
I am sorry If this is duplicate, but I could not find similar issue reported.

I am sorry, this is false positive. Works with default_value=OrderingOptions.ASCENDING.value


Mesh load failed!

Hi Benny,
Thank you for your great tutorials, but I am having a issue with Mesh load failed as shown below. Do you have any idea why its happen?

I am using mac OS(Yosemite), Xcode6.1.1  and have installed SDL2, glew, assimp with brew and cmaked as you described.

The models haven't been moved from the res folder.
Thank you in advance,
ochos

My first guess is your working directory is wrong.
Look, you are trying to access a folder starting from the location you are started the program. Lets imagine you are in your Home folder and starting the executable like ./Project/Program and your res folder is inside the Project folder. Now the Program tries to find the res folder not in your Project folder but in your Home folder instead, because your working directory is your Home folder.
Long speech no sense, your executable and your res folder needs to be in the same folder and your have to start your program in this folder with your working directory set to this folder.
If you are starting your program with an IDE, set your working directory inside the IDE to the folder, where your res folder is located.
Hope this helps and sorry for my bad english.
zeyorama

Dear zeyorama,
Thank you for your comment. It helps a lot and works properly!
Sorry for my lateness.
Hide


Update Routing that Gorouter 14 uses

Is there any option?? because routing needs to be improved to Rival Gorouter Features

maybe this solution will solve your problem click


Relocate Build Template Wizard

I don't find this screen useful at all.  It prompts you to populate "goals" when I want to be using minimums/maximums.  The templates are certainly interesting as examples, but I've never used one.  I suggest replacing this step with a button or dropdown on the builds page that lets you load an optimization template.  The dropdown might default to "custom" but let you pick one of these other options.

In the options menu, you can disable 'Show Build Wizard'.
There is a tick-box down the bottom which will also disable it, but you need to select '' as the build.
Admittedly, there is a bug where that checkbox is disabled until you select another template, then reselect ''.
The Build Wizard is supposed to be a simplified entry point into creating builds.
So that if someone isn't comfortable with specifying everything needed for a correct build, one of the templates not only will be valid, but show a possible preview of how the scoring works.
Goals are a softer minimum, as using minimum naively will result in no builds, where using Goal will "always" result in a build.
Additionally, in the templates.json file you can specify a URL/file to load more templates from (which is where the EU2K comes from).
This would allow someone to create a 'useful' set of templates for specific monsters and share them.
Personally, I use them as a starting point when bringing in a new monster, just as a rough starting point.

I understand your point about goals, but most suggested builds (GB10, R5, etc.) have pretty hard EHP minimums.  I also don't understand what it would do if I have SPD and EHP minimums and both cannot be met at the same time.  At least a minimum will hard lock so I can either reprioritize or lower my targets.
And if I'm not confident how they'd behave (as a relatively experienced user), I have to believe the behavior would simply frustrate a new user.

The templates make more sense to me as guides.  That's why I was still trying to preserve them.  Maybe a checkbox that says "down show this screen in the future (can re-enable in settings)".

It'd be nice to add a checkbox to the bottom so you don't have to go to setting to hide, but there are more important/valuable improvements.


resolves : 97 add custom cpu parametrization

Closes #97

Changed the parameters syntax.
Supported modes are:
"linspace":{
  "min": 0.03,
  "max": 0.05,
  "n_steps": 3
}

"logspace":{
  "min": 0.03,
  "max": 0.05,
  "n_steps": 3,
  "base":10
}

"geometric":{
  "start": 8,
  "ratio": 2,
  "n_steps": 3
}

"range":{
  "min": 0.03,
  "max": 0.05,
  "step": 0.01
}

"sequence":[0.03,0.04,0.05]

"repeat":{
  "value":64
  "count"5
}

Added a "zip" parameter concept that allows to zip multiple sub-parameters given any of the previous generators :

       {
           "name": "nb_tasks",
           "zip": [
               {
                   "name":"tasks",
                   "geometric":{
                       "start":16,
                       "ratio":2,
                       "n_steps":4
                   }
               },
               {
                   "name":"nodes",
                   "sequence":[1,1,2,3]
               }
           ]
       }

The previous example will create : "nb_tasks":[{"tasks":16,"nodes":1},{"tasks":32,"nodes":1},{"tasks":64,"nodes":2},{"tasks":128,"nodes":3}]
The following (straightforward) syntax is also supported:
{
  "name": "nb_tasks",
  "sequence": [
      {"tasks" : 16, "nodes":1},
      {"tasks" : 32, "nodes":1},
      {"tasks" : 64, "nodes":2},
      {"tasks" : 128, "nodes":3}
  ]
}

@JavierCladellas  there is a conflict on the PR

@JavierCladellas how about having cartersian product as well ?


feat: Implement DownscopedClient#getAccessToken() and unit test

Implement DownscopedClient class getAccessToken() API and related unit tests.
Design Doc: link

@bojeil-google

@xil222  thank you for the contribution 👏  excited for this.


Unclosable error on discord canary update

Error: connection closed
    at C:\Users\bvoo\AppData\Local\Programs\mbcord\resources\app.asar\node_modules\discord-rpc\src\client.js:108:20
    at Map.forEach (<anonymous>)
    at IPCTransport.<anonymous> (C:\Users\bvoo\AppData\Local\Programs\mbcord\resources\app.asar\node_modules\discord-rpc\src\client.js:107:25)
    at Object.onceWrapper (node:events:642:26)
    at IPCTransport.emit (node:events:539:35)
    at IPCTransport.onClose (C:\Users\bvoo\AppData\Local\Programs\mbcord\resources\app.asar\node_modules\discord-rpc\src\transports\ipc.js:151:10)
    at Socket.emit (node:events:527:28)
    at Pipe.<anonymous> (node:net:709:12)

DEBUG INFO:
Development Mode: false
Platform: win32 (Version 10.0.22621)
Architecture: x64
MBCord version: 3.0.5
Node version: 16.16.0
Electron version: 21.2.2
Chrome version: 106.0.5249

Could you try to use the normal Discord client, and tell me if its working. Thanks

This issue will be marked as stale. If this problem is still happening you can reopen it.


393: query survey_visits to mark things completed

This isn't 100% what we want, since it can't check the survey_responses on the survey_visits. Should be removed pending #405
Related to #393

This needs to be updated to use the real value of completed now

PR now contains the proper changes for consuming completed!


ppm/encoder: Prep filtered slice before write_all

I noticed that saving an RGBA to a PPM file was taking ~620 times longer than an RGB.
It scaled linearly with # pixels. So this patch does all the filtering in one go and then writes the entire slice.
For a 2560x1700 pixel image:
rgb:       0.01916 seconds
old rgba: 11.657   seconds
new rgba:  0.05424 seconds

Test code:
extern crate image;
extern crate time;

use std::fs::File;
use std::path::Path;

fn main() {
    let mut imgbuf = image::ImageBuffer::new(2560, 1700);
    for (x, y, pixel) in imgbuf.enumerate_pixels_mut() {
        *pixel = image::Rgba([x as u8, y as u8, x as u8, y as u8]);
    }

    let ref mut fout = File::create(&Path::new("rgba.ppm")).unwrap();
    let img = image::ImageRgba8(imgbuf);

    println!("Start save");
    let start = time::precise_time_s();
    let _ = img.save(fout, image::PPM);
    println!("Save: {} seconds", time::precise_time_s() - start);
}

Please me know if I did anything wrong; thanks for the great library otherwise.

I suspect that using BufWriter would give similar improvements. We may want to use buffered writes for all encoders (similar to what #552 did for decoders).

Good point thank you. If I use BufWriter then my test from above runs in 0.146 seconds (half as fast as original patch). But if I change the 3 write_all() calls in the for-loop to be just one then  I get 0.06696 seconds (just about as fast). But nice side is that it should speed up Gray(8) as well. That alternate branch is here for reference: https://github.com/genkimarshall/image/tree/rgba-ppm-alt
Looking at the other encoders briefly, it seems only other one that has write_all() in a loop is jpeg.

Thanks for testing that. You're right that jpeg seems to be the only other one that would benefit.
Also note that for your alternate branch the rgb slice needs to be &x[..3].

What is the rationale for removing the seek calls? Ist it really giving such a big speed up? The code is much more comprehensible compared to the version with the read_uxx calls.

@philipc  Hmm for the alternate branch, if my understanding is correct, I do believe that it should be &x[..2] because for PPM it doesn't have an alpha channel so we only want to grab the RGB from the RGBA.

@genkimarshall The end of the range is not inclusive. so I think that will only give you two channels.

Ah right thank you.. was not thinking.. Force pushed change.

Hello, is there anything I could do to help move this PR along?
It's my impression that the travis build failed due to rayon not compiling successfully on nightly.

Seems the original use case is fixed. Closing.


Adding mexican Regiomontano Cumbres institute

@rubenqba First stage of verification passed, official domain is ircumbres.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


python312Packages.anyio: 4.3.0 -> 4.4.0

Description of changes
Diff: https://github.com/agronholm/anyio/compare/refs/tags/4.3.0...4.4.0
Changelog: https://github.com/agronholm/anyio/blob/refs/tags/4.4.0/docs/versionhistory.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/tiangolo/fastapi/blob/0.111.1/pyproject.toml#L44


error processing file - Version deletion

Firstly, thanks for this.
Found a bug most likely.
When it errors, it quits out.
Erroring only on xlsm files. although it has also successfully removed versions on other xlsm files.
Here is part of the log (Edited any company specific info)
The file it's erroring on has 2027 file versions
Update: Tried another location (same site) Errored on another xlsm file, that had 1453 versions, similar issue as below
2024/05/21 00:48:08 - [AppInfo] - Access Token expiration time: 21/05/2024 12:53:33 AM +00:00 2024/05/21 00:48:13 - [NPLogger] - Error processing Item '/sites/XXXXX/SharedDocs/Set Up New Item in J/BSF & TCRC/NEW GROUP DRAFT IMRF Template V2-04 PER.xlsm' 2024/05/21 00:48:13 - [NPLogger] - Exception: Unable to cast object of type 'System.String' to type 'Microsoft.SharePoint.Client.FieldLookupValue'. 2024/05/21 00:48:13 - [NPLogger] - Trace:    at NovaPointLibrary.Solutions.Automation.RemoveFileVersionAuto.AddRecord(String siteUrl, List oList, ListItem oItem, String versionsDeletedCount, String versionsDeletedMB, String remarks)    at NovaPointLibrary.Solutions.Automation.RemoveFileVersionAuto.RemoveFileVersions(String siteUrl, List oList, ListItem oItem)    at NovaPointLibrary.Solutions.Automation.RemoveFileVersionAuto.ProcessItems(String siteUrl, List oList, ProgressTracker parentProgress) 2024/05/21 00:48:13 - [NPLogger] - Error processing DocumentLibrary '/sites/XXXXX/SharedDocs/Forms/AllItems.aspx' 2024/05/21 00:48:13 - [NPLogger] - Exception: Unable to cast object of type 'System.String' to type 'Microsoft.SharePoint.Client.FieldLookupValue'. 2024/05/21 00:48:13 - [NPLogger] - Trace:    at NovaPointLibrary.Solutions.Automation.RemoveFileVersionAuto.AddRecord(String siteUrl, List oList, ListItem oItem, String versionsDeletedCount, String versionsDeletedMB, String remarks)    at NovaPointLibrary.Solutions.Automation.RemoveFileVersionAuto.ProcessItems(String siteUrl, List oList, ProgressTracker parentProgress)    at NovaPointLibrary.Solutions.Automation.RemoveFileVersionAuto.ProcessItems(String siteUrl, List oList, ProgressTracker parentProgress)    at NovaPointLibrary.Solutions.Automation.RemoveFileVersionAuto.RunScriptAsync() 2024/05/21 00:48:13 - [SPOSiteCollectionAdminCSOM] - Processing 'https://o365company.sharepoint.com/sites/XXXXX' setting<EMAIL_ADDRESS>IsSiteAdmin 'False' 2024/05/21 00:48:13 - [AppInfo] - Getting Access Token for root site https://o36company-admin.sharepoint.com 2024/05/21 00:48:13 - [AppInfo] - Adding cached token 2024/05/21 00:48:13 - [AppInfo] - Finish aquiring new Access Token with Refresh Token. 2024/05/21 00:48:13 - [AppInfo] - Access Token expiration time: 21/05/2024 12:54:06 AM +00:00 2024/05/21 00:48:14 - [NPLogger] - COMPLETED: Solution has finished correctly!

Issue fixed on new version 0.7.0


fix color in Chart cards

Chart colors were low contrast, like the first image below.
This change makes them higher contrast and easily visible, like the second image below.

@smrdotgg Looks like this is not working for light mode:


FluidKDTree kNearest returns Symbol

When I fit the FluidKDTree, my FluidDataSet identifiers were all strings, so I expected the FluidKDTree to also return strings when I call kNearest. However it returns a Symbol.  I want to take the nearest it returns and compare it to my set of identifiers, but == won't work because they're different classes.
Can we make FluidKDTree return  the same class that was used to set the points in the FluidDataSet that it was trained on?

I don't think this is something we have a great deal of control over: the encoding to Symbol takes place when SC itself parses the OSC packet.

FluidDataSet identifiers were all strings,

Not really: you may have put strings in, but these are converted to Symbols, then serialized, sent over UDP and live on the server. This is what happens in addPoint
  addPointMsg{|identifier,buffer|
        buffer = this.prEncodeBuffer(buffer);
        ^this.prMakeMsg(\addPoint,id,identifier.asSymbol,buffer);
    }

We could, I guess, convert everything back to String across the toolkit, but is the loss in efficiency justified? Symbol is much cheaper to compare, and presumably there's some overhead in making lots of new Strings?

I see. This makes sense. I will just make a note to clarify this in the docs.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_079966a0-fe09-40db-9e94-9780b1e7f379/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_079966a0-fe09-40db-9e94-9780b1e7f379.git

Docs Build status updates of commit 616c05a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Style upgrade & billing pages

This styles the billing and upgrade pages @rishig created in https://github.com/zulip/zulip/pull/9818. (It also includes his work there.)
Each page has a simple, reusable nav component (billing_nav.html). (It has no nav options right now, but can easily incorporate them if we want to add some later.)
/billing contains a quick snippet of inline Javascript (to control the tabs). Wasn't sure if best practice was to pull this out or not, so I just went with the simplest solution and left it inline for now.

Just noticed the support link is blue on one page and green on the other—will update and fix that tomorrow!

Thanks; this looks great! The one comment I have is that the Annual/Monthly tabs look big compared with the "CTA" (Add card), but it's also reasonable as is.
Though one thing I realize looking at this is that we should give the monthly rate as well for the annual billing. So maybe
$6.67/user/month
($80/user/year)
in the annual tab.

I just merged #9818, so I just pushed to this PR after rebasing it on top of that.

@maxnuss there's several little things we're going to want to fix here, but because there's ongoing work on other parts of billing that would almost certainly merge conflict with this (and regardless this is infinitely better than we had before), I went ahead and fixed the little linter/test failures and merged this.  Thanks @maxnuss!


[FEATURE] Improve Issue template

Description
Add a section to the Issue template for asking if the issue-creator can contribute to fix the issue / add features or not.
With this, we can either expect the creator will be working on the issue or not.
Expected behavior with the suggested feature
When someone is creating a new issue, show the following section:
### Willingness to contribute
[ ] Yes, I can contribute for this issue independently.
[ ] Yes, I can contribute for this issue with guidance from Recommenders community.
[ ] No, I cannot contribute at this time.

@miguelgfierro @anargyri let me know if this makes sense.

this is interesting, it might help to attract more contributors

I like your idea @loomlike

Hello @loomlike @SimonYansenZhao @miguelgfierro
I am Sumana Sree, new to this project, can I take up this issue?

@sumana-2705 absolutely.
Please make sure you have read the contribution guidelines

definitely, I will read the contribution guidelines
thank  you

@miguelgfierro
Please review the pull request and suggest me the required changes


[FEATURE]: ADD support of SLES15 SP5 in csi powerscale

Describe the solution you'd like
Currently CSI drivers a only supported on SLES14 sp4, but according to Suse Product Lifecycle, general support of sp4 ends in December 2023 and sp5 has been released 6 month ago.
Additional context
We need to upgrade our kubernetes nodes to SLES15 sp5 and we can't so far because CSI Isilon is not compatible.

Hi @SebPlv.  Please reference our revised CSI Driver support matrix here: https://dell.github.io/csm-docs/docs/csidriver/.  You'll notice our supported host operating systems have been removed.  Host operating systems must align with what is supported by the particular storage platform (PowerScale in this case).  That information can be found here: https://elabnavigator.dell.com/eln/modernHomeSSM.  Container Storage Modules (which includes CSI) will focus on support alignments with container orchestrators.


Include icon to build

An app icon shall be included to application

This package can be executed from command line and creates icons for all platforms from one original icon: flutter_launcher_icons

There is an open issue with flutter and Linux icons: Issue_53229.
But the icon can be installed by the install.ah script


Create regexp model

Story
As a developer I want to be able to perform a regexp on a parameter so I can transform an input parameter into an output parameter that is more useful to downstream plugins.
Rationale
boavizta-cpu need cpu/name to work, however cloud-metadata returns physical-processor which usually contains a long string of processors that the instance could be separated by ,, like so:
Intel® Xeon® Platinum 8272CL,Intel® Xeon® 8171M 2.1 GHz,Intel® Xeon® E5-2673 v4 2.3 GHz,Intel® Xeon® E5-2673 v3 2.4 GHz

Implementation details

Create a regexp plugin which uses the javascript regexp feature to match part of one string and extract it into an output.
For the above example the regex ^(.*), will return the name of the first CPU in the list.

For example the below will match ^(.*), and output to cpu/name
config
  regex:
    match: ^(.*),
    output: cpu/name

Priority
5/5 - Required for workshop
Scope
Not affecting anything else.
Size
1 day
What does "done" look like?
Regex plugin which allows you to match part of a string and output it to a parameter
Does this require updaes to documentation or other materials??
Yes, documentation to if-models for this plugin
What testing is required?
Unit tests and manual invocation from a manifest file
Is this a known/expected update?
For sprint 7, added after sprint planning.

@jawache Is there a missing third parameter, such as  input-parameter which would allow the parameter name to be changed?

Oh yes, I think just parameter is fine.

PR:
https://github.com/orgs/Green-Software-Foundation/projects/26/views/1?pane=issue&itemId=54945846

https://github.com/orgs/Green-Software-Foundation/projects/26/views/1?pane=issue&itemId=54945846


DONOTMERGE: test

/test build-definitions-pull-request

/test build-definitions-pull-request

/test build-definitions-pull-request

/test build-definitions-pull-request

/test build-definitions-pull-request


Implement overall UI and redefine structure

Implemeted UI to allow it to look better
closed #37

LGTM, UI looks fantansic!


Date problem

I'm used to show visitors of my website both, the creation date and the modified date. So they can see how old a post is and when it was last modified.
So I thougt "page.date" in a twig template gives back the creation date of a markdown file and "page.modified" the last modified date. But the docs says:

The date variable allows you to specifically set a date associated with this page. This is often used to indicate when a post was created and can be used for display or sort-order purposes. If not set, this defaults to the last modified time of the page.

Is it possible to change this behaviour as I thought it is? Normally there should be no need to set creation and/or modified date manually.
Currently I have to do this if I want to show both dates. So it would be better practice not to set theese dates manually for each markdown file but only for that I want to override it.

Being a flat-file system, there is no database.  What this means is that we only have the file to work with. There is a dynamic modification date available, so you can use page->modified() for that, and you can then manually set the date the file was originally published via the date: Page header, and that's accessible via page->date()

Ah, ok, I did not knew that there is no creation date on most file systems except Windows.

@rhukster
I'm sorry to bother again with this issue.
But.
Shouldn't the creation date be set automatically when creating content within GRAVCMS? It seems counter-intuitive not to register the date automatically when creating the content.
Am I missing a configuration option?

The admin tries to where to the principals of the core (without admin) as much as possible. This means that it only adds things to the frontmatter only if you explicitly tell it to do so. Automatically adding dates is one such example.

This plugin https://github.com/getgrav/grav-plugin-auto-date will add the current date when the page is created. Your theme can then render that header field.


feat: allow options.mode to be reactive

Hi @yansenlei ,
I needed the ability to switch between edit and view mode, but the editor mode was not set up to be reactive. I made a small edit that watches the original options prop passed in, and updates the editor mode when options.mode changes. Please let me know if this is acceptable, or if other changes should be made for it. Thanks!

I would also be interested by this merge.

I'm sorry I'm late. I'll see to it right away

Hi, @ferm10n
I have tried, I think it's more flexible to $refs.instance.
https://codesandbox.io/s/vjsoneditor-change-mode-r94w0?file=/src/App.vue:1121-1165
<v-jsoneditor ref="JsonEditor" v-model="json"/>

this.$refs.JsonEditor.editor.setMode('code')

😃 v-jsoneditor can also provide convenience, But need to consider scalability.
watch: {
    options: {
      handler (newValue, oldValue) {
        const diff = getDiffKeys(newValue, oldValue)
        if (this.editor && diff.includes('mode')) {
          this.editor.setMode(this.options.mode)
        }
      },
    }
}

Using $refs to access VJsoneditor's editor instance is a bad idea. As a library maintainer, you usually want to have control over how other devs interact with your lib. Some people would call these "module boundaries". While it's possible to manipulate editor with $refs, it makes it infinitely harder for you as the maintainer to determine what is and what is not a breaking change in the future. This is why Vue has props and events, it forces components to have a well defined data direction flow. Modifying component internals with $refs is too hacky IMO.
One way to fix this though might be declaring exactly what the vjsoneditor module provides, like adding an index.d.ts like this:
// src/index.d.ts
import _Vue, { ComponentOptions, PluginObject } from 'vue';
import JSONEditor from 'jsoneditor';

type VJsoneditorType<V extends _Vue = _Vue> = PluginObject<V> & ComponentOptions<V, {
    editor: JSONEditor | null;
}>;

export const VJsoneditor: VJsoneditorType;
export default VJsoneditor;

and adding the types reference in package.json
{
  "types": "./src/index.d.ts"
}

That way, you can still have the module boundaries well defined. Note, I'm not 100% sure this is the correct way to write the typescript for this. What do you think?

 I didn't know that happened, I've had my team using the fork I made this whole time 😅
So I think this pull request can be closed


Fails to render without error if name is a list

Following name will simply not show anything in preview/read mode:
name: - Progress
width: 50%
value: 10
max: 25

As opposed to something like this, which results in an error:
name: # Progress
width: 50%
value: 10
max: 25

This is a nice plugin, I wish I was able to add the bar to headings or lists, but I understand there may be limitations.

it seems not able to be implemented, sorry.


Avoid null delegate reporter

Fixes #806

Hi @som-snytt,
Thank you for your contribution! We really value the time you've taken to put this together.
We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:
https://www.lightbend.com/contribute/cla

Just a placeholder with an old commit. Needs test, etc.

Just hit this again. Maybe someone could merge it.


Wrap tex fp8 transpose in linear backward

Description
Wrap fp8_transpose and fused_cast_transpose from Transformer Engine extension to replace transpose in linear layer backward propagation.
Major Revisions

add wrapper for tex.fp8_transpose and tex.fused_cast_transpose
replace transpose in linear backward

Seems there is linting issue. BTW, have we tested the performance improvement of this optimization?


fix(AutoControlledComponent): use setState instead of an assign

Fixes #1761.
Fixes #1682.
In #1770, I suggested that the problem is in that setState is an async, I was right. AutoControlledComponent component's children such as Dropdown and  Search had own logic inside the componentWillMount method that relied on the current state.
The componentWillMount method was renamed to constructor as it's a single place where state is assignable. However, we need to have ability to assign an initial state, so I added the initialState method that accepts props as an argument.
@apiv Thanks for you suggestions in #1770.

Codecov Report

Merging #1799 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1799      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%
==========================================
  Files         144      144
  Lines        2465     2463       -2
==========================================
- Hits         2459     2457       -2
  Misses          6        6

Impacted Files
Coverage Δ

src/modules/Dropdown/Dropdown.js
100% <ø> (ø)
:arrow_up:

src/modules/Search/Search.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da73f4...7ffabf1. Read the comment docs.

Ah, assumed my solution wasn't ideal and closed my PR, guess I should have left it open 😂.
Really excited to finish our migration to React 16 now that this is fixed, thanks!

Released in<EMAIL_ADDRESS>


Inconsistent context height usage

In evmos:x/evm/keeper/grpc_query.go:407, the contextHeight variable is
defined to coincide with the requested block number. However,
rpc/backend/tracing.go:116 and 173 defines contextHeight as the one block
before the requested height (i.e., height - 1).
This inconsistency could result in difficulty when debugging Ethereum transactions.

@omritoptix we upstreamed this as bug fix from recent evmos in https://github.com/dymensionxyz/evmos/pull/18

@VictorTrustyDev
Regarding the fix u did on x/evm/keeper/grpc_query.go:407 ,
do we need to fix it in rpc/backend/tracing.go as well?

@mtsitrin no, that's enough


refactor ssm_sv_init

A question for @j-hui!
The initial code-generation scheme that I pilfered from the FDL-paper took a program like this:
f() {
  int x = var 5;
}

and turned that into
// a struct

// an enter-function

// a step-function

with the initialization of x happening inside the step-function.
void step() {
  switch pc {
    case 0:
      initialize_int32(&x);
      assign_int32(&x, 5);
      // etc...
  }
}

A problem with this is that if the initialization only happens in a conditional branch, it might be skipped altogether and then the reference might skip initialization, making any usage of it illegal. The only use we might have made of it, however, was to dequeue any outstanding event on it before we exit the step-function.
The solution was naturally to lift the initialize_int32 call to the enter-function, and leave the assignment of the initial value in the step-function.
With the new scheme in the dev branch, I am not sure that this is possible (or I am just missing it). ssm_sv_init takes as a parameter, not just the reference in question, but also the initial value of the reference. This value depends on when in time the reference is initialized, and can not be lifted to the enter-function without changing the semantics. If ssm_sv_init was split up into something like ssm_sv_init(ssm_sv_t *sv) and ssm_sv_init_assign(ssm_sv_t *sv, ssm_value_t init_val), with ssm_sv_init_assign essentially behaving like ssm_assign with the exception that it doesn't mark the value as having been updated at this point in time, we can do the same refactoring.
Of course, if we never need to chase a reference if we don't initialize it this isn't an issue, but we seem to be dropping all of them before exiting the step-function.

#define ssm_sv_init(sv, val)                                                   \
  do {                                                                         \
    ssm_to_sv(sv)->later_time = SSM_NEVER;                                     \
    ssm_to_sv(sv)->last_updated = SSM_NEVER;                                   \
    ssm_to_sv(sv)->triggers = NULL;                                            \
    ssm_to_sv(sv)->value = val;                                                \
  } while (0)

would become
#define ssm_sv_init(sv)                                                        \
  do {                                                                         \
    ssm_to_sv(sv)->later_time = SSM_NEVER;                                     \
    ssm_to_sv(sv)->last_updated = SSM_NEVER;                                   \
    ssm_to_sv(sv)->triggers = NULL;                                            \
  } while (0)

#define ssm_sv_init_assign(sv, val)                                            \
  do {                                                                         \
    ssm_to_sv(sv)->value = val;                                                \
  } while (0)

As you said, we previously had to eagerly initialize the metadata of scheduled variables in the enter function because we wanted to unconditionally call the unschedule function before leaving. However, we should now no longer store scheduled variables in the stack; instead, these are supposed to be heap-allocated. Then we simply drop them when they go out of scope.
So something like:
f() {
  // before
  int x = var 5;
  // after
}

would look like:
void step_f (ssm_act_t *act) {
  f_act_t  *cont = container_of(act, f_act_t, act);
  switch (act->pc) {
    // ...
    // before
    cont->x = ssm_new_sv(ssm_marshal(5));
    // after
    // x goes out of scope:
    ssm_drop(x);
  }
}

If allocation only happens in a conditional branch, e.g.,:
f() {
  // before
  if (c) {
    int x = var 5;
    // conditional body
  }
  // after
}

Then we drop as soon as we leave the scope of the conditional:
void step_f (ssm_act_t *act) {
  f_act_t  *cont = container_of(act, f_act_t, act);
  switch (act->pc) {
    // ...
    // before
    if (ssm_unmarshal(cont->c)) {
      cont->x = ssm_new_sv(ssm_marshal(5));
      // conditional body
      // x goes out of scope:
      ssm_drop(x);
    }
    // after
  }
}

Note that my latest commit onto dev from #20 makes it such that we no longer need a separate ssm_sv_init macro; instead, we just have an ssm_new_sv function, whose argument is the initial value. This allocates and initializes the scheduled variable all at once.
If you must allocate a scheduled variable with a garbage value, just use a dummy value:
ssm_new_sv(ssm_marshal(0xbeefcafe))

Also I forgot to note that unschedule is automatically being called by drop; the lifetime of references is not strictly tied to its scope


refactor: better readability of buildLineCore filter

Description
In this PR I solved this issue
captured test results test-results.md
Resolved

Removed nested template literals and replaced them with string concatenation

@thebedigupta please read carefully suggestions from sonarcloud. This was not what was advised, using old way of strings concatenation is not a solution.

I get your point and sorry for the mistake

/rtm


Replying from Matrix to Telegram doesn't ping the user

When somebody on Matrix replies to a user that is on Telegram, the reply addresses the Telegram user by "nickname (Telegram):", so the Telegram user is not pinged and may miss the reply.
I believe that if the Telegram room saw "@nickname" instead of "nickname (Telegram):", the user to which the reply goes would be notified about it.

Did you already try sending a manual @someone reply into a bridged room and check for its effects?

Did you already try sending a manual @someone reply into a bridged room and check for its effects?

How do we know what to put in place of @someone when we only receive Telegram firstname and lastname and not the actual username that is used for mentioning?

This can be fixed by the mention API, as proposed by #36


Fixes Windows containers with image volumes

Currently, there are few issues that preventing containers with image volumes to properly start on Windows.

Unlike the Linux implementation, the Container volume mount paths were not created if they didn't exist. Those paths are now created.

while copying the image volume contents to the container volume, the layers were not properly deactivated, which means that the
container can't start since those layers are still open. The layers are now properly deactivated, allowing the container to start.

even if the above issue didn't exist, the Windows implementation of mount/Mount.Mount deactivates the layers, which wouldn't allow us to copy files from them. The layers are now deactivated after we've copied the necessary files from them.

the target argument of the Windows implementation of mount/Mount.Mount was unused, which means that folder was always empty. We're now symlinking the Layer Mount Path into the target folder.

hcsshim needs its Container Mount Paths to be properly formated, to be prefixed by C:. This was an issue for Volumes defined with Linux-like paths (e.g.: /test_dir). filepath.Abs solves this issue.

Signed-off-by: Claudiu Belu<EMAIL_ADDRESS>

I just came across this PR due to it conflicting with changes I have WIP in #4419, and I think the changes in mount/mount_windows.go and pkg/cri/opts/container.go (except volume = strings.TrimPrefix(volume, "C:") in the latter) are incorrect.
For mount/mount_windows.go:

The "deactivate on error" codepath was lost.
os.Symlink seems like the wrong call to me, it should be SetVolumeMount since what we have here is a volume. I'm surprised os.Symlink works, but it definitely breaks when the Snapshot testsuite hits it, because the Snapshot test suite (and any caller to Mount, AFAIK) creates the target directory first, and os.Symlink fails on Windows when the target already exists.

For pkg/cri/opts/container.go:

snapshotter.Mounts on Windows will only ever return one mount, since the layering is handled internally by HCS, and not visible to the caller like it is on other platforms. This also has the nice side-effect that you can use mount.All the same way on all platforms.
The unmounter is being passed the wrong directory; It should be the mount target like on Linux. (Although before #4419, it's possible this behaviour was just broken. There was an earlier attempt by me to mount "in-place" but that was when I didn't understand the hcs/WCIFS mounting system and was probably just going to lead to surprise data loss).

So as part of #4419, I have the code that completes the mount implementation reverting the above changes, give-or-take. (I didn't actually revert them, I just changed things per the above, I did undo the refactoring of the unmounter function since it was only partly refactored (still referred to root but took mountPath as a parameter).
Now, it's possible I've overlooked something, but I think the upshot is that the first four dot-points of this PR had already been solved in #4419 in a way that didn't require changes in the above two files. I'm particularly curious if there's any circumstance I'm overlooking on Windows where you might get multiple mounts back from snapshotter.Mounts as that would invalidate a bunch of other stuff I've done, sadly. (And makes mounts.All nonsensical on Windows, given that it can't be used for layering like it is on Linux).


Hide columns in data-entry app

The data-entry app should honor the tag:misd.isi.edu,2015:hidden annotation on columns as well as the draft tag:isrd.isi.edu,2016:ignore annotation which we are designing with the next MVP in mind...

The basic hidden one should apply to both the data-entry form and any resulting record display.
The new ignore annotation should allow us more precision to omit the field from the data-entry form while including it in the resulting record displays.

When we hide/ignore a column for data-entry, we should specify it in the defaults query parameter to tell the server that we wish it to fill in the column for us.

I've created PR #378 for this issue. Description of changes and test info is on the PR.

The PR has been reviewed and merged into master.


compute_pz_b

First of all, thanks for providing such a great library! The code really helps to understand the paper.
But I am still wondering why the topic probability distribution P(z|B) for the oBTM seems different from the paper?
The paper states that:

But the actual calculation goes:
pw1k = (nwz[k][w1] + beta[k][w1]) / (2 * nb_z[k] + beta_sum[k]);
pw2k = (nwz[k][w2] + beta[k][w2]) / (2 * nb_z[k] + 1 + beta_sum[k]);
pz[k] = (nb_z[k] + alpha[k]) * pw1k * pw2k;

What did I miss?

Did you ever figure this issue out?


Burrow stops emitting metric after Kafka upgrade

Burrow Version: 1.8.0
Issue:
After upgrading Kafka from version 3.6.x to 3.7.x, we observed that the Burrow service stopped emitting the consumer lag metric. Restarting the Burrow service temporarily resolved the issue.
Logs:
The following warnings and errors were observed in the Burrow logs:
{"level":"error","ts":1720927697.84136,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":7}
.......
{"level":"warn","ts":1720927137.8406005,"msg":"error in OffsetResponse","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"kafka server: Tried to send a message to a replica that is not the leader for some partition. Your metadata is out of date","broker":3,"topic":"kafka-connect-offsets.internal","partition":4}

The Kafka upgrade was performed in a rolling fashion, one broker at a time. While communication disruptions were expected with the upgrading broker, others should have been available.
Burrow Configuration:
Here is the configuration we are using:
[client-profile.profile]
kafka-version = "3.6.1"

[cluster.local-cluster]
client-profile = "profile"
class-name = "kafka"
topic-refresh = 60
offset-refresh = 10
groups-reaper-refresh = 10

[consumer.local-kafka]
class-name = "kafka"
cluster = "local-cluster"

[consumer.local-kafka-zk]
class-name = "kafka_zk"
cluster = "local-cluster"

[httpserver.default]
address = "{{ $http_address }}"

[logging]
level = "{{ $log_level }}"

Note: The kafka-version is set to 3.6.1, but as mentioned earlier, Burrow works fine with Kafka 3.7.x after a restart, so this does not seem to be the root cause.
Request:

Has anyone encountered a similar issue, particularly after upgrading Kafka?
Are there any recommendations on how to troubleshoot this further?
Does anything in our configuration appear to be problematic?

Please let me know if additional information is required.
Thank you!

Looks like the issue is intermittent because I am not able to reproduce this when I am upgrading kafka.
During the upgrade metric does stop for a few but once upgrad has completed, it starts showing up again without having to restart burrow.

For the kafka cluster where we originally noticed the cluster, we have 9 brokers and observed EOF with all 9 brokers:
{"level":"error","ts":1720926917.8395112,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":1}
{"level":"error","ts":1720927037.8437417,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":2}
{"level":"error","ts":1720927147.84239,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":3}
{"level":"error","ts":1720927257.8391266,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":4}
{"level":"error","ts":1720927377.8412945,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":5}
{"level":"error","ts":1720927507.8451424,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":6}
{"level":"error","ts":1720927697.84136,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":7}
{"level":"error","ts":1720927887.8561947,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":8}
{"level":"error","ts":1720928077.8389344,"msg":"failed to fetch offsets from broker","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","sarama_error":"EOF","broker":9}
....
{"level":"error","ts":1720928077.8438833,"msg":"failed to get the list of available consumer groups","type":"module","coordinator":"cluster","class":"kafka","name":"local-cluster","error":"dial tcp <IP_ADDRESS>:9092: connect: connection refused"}


How to get Fig.1, is it supported by data?

The Fig.1 is very nice to explain how the inductive bias worked in CNN or convit. But how to get this, is it supported by data？

Hi ! No, Fig.1 is simply a sketch illustrating the fact that inductive biases are useful in the model>>data regime, but restrictive in the opposite regime.


Using with Typechain

Hey! This project is so great!
Wondering if anyone had any suggestions of how to use it in conjunction with typechain - would be so sweet to have useContractCall / useContractFunction typed :)
Thank you!

You could wrap useDapp hooks with something like this:
 function useContractFunction<ContractType extends Contract, Key extends keyof ContractType['functions']>(contract: ContractType, functionName:  Key) {
  }
  ```

Thank you!

Hey @jongold - so we happened to be trying to implement this when you asked the question so it was good timing. It turns out it's slightly more complex to implement, and we're about 90% there, but we're missing just one part - that's getting the correct typed params for the send() function that's returned by the useDapp hook.
There's an issue about it here with our implementation so far: https://github.com/EthWorks/useDApp/issues/328

Actually, I found the issue - here's working code for a hook wrapper that you could use with typechain:
import {
  TransactionStatus,
  useContractFunction as useDappUseContractFunction,
} from '@usedapp/core';
import { Contract } from 'ethers';

interface UseContractFunctionReturnType<
  ContractType extends Contract,
  Key extends keyof ContractType['functions'],
  Args extends Parameters<ContractType['functions'][Key]>,
> {
  send: (...args: Args) => Promise<void>;
  state: TransactionStatus;
}

function useContractFunction<
  ContractType extends Contract,
  Key extends keyof ContractType['functions'],
  Args extends Parameters<ContractType['functions'][Key]>,
>(
  contract: ContractType,
  functionName: Key,
): UseContractFunctionReturnType<ContractType, Key, Args> {
  const { send, state } = useDappUseContractFunction(
    contract,
    functionName as string,
  );
  return { send: (...args: Args) => send(...args), state };
}

export { useContractFunction };


Slimes should have their own scream sounds

Description

With #11520, the scream now defaults to male due to slimes not being able to have a defined sex. Slimes should have a blub scream instead of the human scream

do they have a blub blob scream yet i dont play slime

Nope, still human scream
It's funny tho since they talk with blub blubing but do human emote sounds clearly


add wasm32-wasi as wasi in sys.platform

closes #4539

@jhowww if you are interested in, we recently added a few more easy issues on issue page

Thanks! I'll take a look.


neovide: 0b976c3 -> 4159c47f

Neovide moved from Vulkan to OpenGL (https://github.com/Kethku/neovide/pull/655) which has better GPU support.
This version should make https://github.com/NixOS/nixpkgs/issues/123262 obsolete.
The new version has one issues on my environment:

The shift key only works for keys a-z. I can not type e.g. !@#?

If we merge this PR, Nix users can give feedback to the Neovide project.
But I am OK, when we wait for a more tested version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

The new version has one issues on my environment:

The shift key only works for keys a-z. I can not type e.g. !@#?

I've also experienced this issue the last time I tried out the opengl branch, this makes neovide pretty unusable (to be fair, the vulkan version doesn't run at all here so it would strictly speaking still be an improvement for me).
Maybe we should wait for this PR to be merged first?
https://github.com/Kethku/neovide/pull/736

We will likely make a stable release after Kethku/neovide#736 is merged and linux keyboard issues are resolved. After that neovide should become much more usable on linux. I would personally wait until the stable release, but its up to you.

Thanks for your comments. Lets wait for the keyboard issue.

FYI: https://github.com/Kethku/neovide/pull/736 has been merged, and it works pretty well on my machine.

I had to change cargoSha256 and then I got
Validating consistency between /build/source//Cargo.lock and /build/neovide-unstable-2021-06-18-vendor.tar.gz/Cargo.lock
3,4d2
< version = 3
<
1497a1496
>  "clap",

ERROR: cargoSha256 is out of date

Cargo.lock is not the same in neovide-unstable-2021-06-18-vendor.tar.gz

To fix the issue:
1. Use "0000000000000000000000000000000000000000000000000000" as the cargoSha256 value
2. Build the derivation and wait for it to fail with a hash mismatch
3. Copy the 'got: sha256:' value back into the cargoSha256 field

With this patch applied to this PR, the latest Neovide commit (https://github.com/Kethku/neovide/commit/4159c47ff4f30073b92b9d63fc6ab70e07b74b6d) works on my machine.
--- a/default.nix	2021-06-22 13:22:11.259429723 +0100
+++ b/default.nix	2021-06-22 13:23:29.360111759 +0100
@@ -15,6 +15,7 @@
 , llvmPackages
 , makeFontsConf
 , libglvnd
+, libxkbcommon
 , xorg
 }:
 rustPlatform.buildRustPackage rec {
@@ -24,11 +25,11 @@
   src = fetchFromGitHub {
     owner = "Kethku";
     repo = "neovide";
-    rev = "599dc5887d8799ae8971259bc3bdbaa7b6e2ef45";
-    sha256 = "sha256-mwIJ9kI0N6W/3km8H6TdDfSO3TdLg+A/5DSxejRg3i8=";
+    rev = "4159c47ff4f30073b92b9d63fc6ab70e07b74b6d";
+    sha256 = "sha256-XwirJGXMGxc/NkpSeHBUc16ppvJ+H4ECnrOVu030Qfg=";
   };

-  cargoSha256 = "sha256-Fg2cDwjW6Ex5uUZ8226kgNd/6EoeJddp/rULqH70NRs=";
+  cargoSha256 = "sha256-w9xpNvdUZEOUeM+nTY7RjaVTYC9AahEMt5Igq37N7Bo=";

   SKIA_SOURCE_DIR =
     let
@@ -85,7 +86,7 @@

   postFixup = ''
       wrapProgram $out/bin/neovide \
-        --prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath [ libglvnd xorg.libXcursor xorg.libXext xorg.libXrandr xorg.libXi ]}
+        --prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath [ libglvnd libxkbcommon xorg.libXcursor xorg.libXext xorg.libXrandr xorg.libXi ]}
     '';

   postInstall = ''

Thanks for the patch. The cargo hash was different, but the rest works. Regarding wayland support, please raise a separate PR.

The outdated cargo hashes came from package name changes. A dependency which I didn't know.

Thank you, it works!

Sorry, I did not recognize the draft state of my PR. Can somebody please merge this PR.

:+1: I'll send a separate PR enabling Wayland support.


Remove docker files

Let's get rid of these old docker files. I don't imagine there are a lot of people who want a docker container containing only SMP, and the installation process isn't exactly challenging.
I'm also thinking about removing the root Makefile in the future.
Closes #893

Thanks!


Hello, I hope to support failed restart.

When container A starts, the service in container A needs some startup time. At this time, service B has already started and is highly dependent on the service in container A. Therefore, service B ends due to an exception, such as the subscription dependency of Dapr sidecar. on the RabbitMQ service queue.
builder.AddRabbitMQContainer("rabbitmq")
    .WithVolumeMount("./configs/rabbitmq/enabled_plugins.conf", "/etc/rabbitmq/enabled_plugins")
    .WithVolumeMount("./configs/rabbitmq/rabbitmq.conf", "/etc/rabbitmq/rabbitmq.conf")
    .WithEndpoint(1883, 1883)
    .WithEndpoint(15672, 15672)
    .WithEndpoint(5672, 5672)
    .WithEnvironment("TZ", "Asia/Shanghai");

var apiService = builder.AddProject<Projects.AspireApp_ApiService>("apiservice");
var apiServiceDapr = apiService.WithDaprSidecar(sidecarBuilder =>
{
    sidecarBuilder.WithOptions(new DaprSidecarOptions
    {
        AppId = "apiservice",
        ResourcesPaths = ["./components"],
        LogLevel = "debug"
    })
    .WithEnvironment("AMQP_CONNECTION_STRING", "amqp://test:hellotest@localhost:5672")
    .WithEnvironment("MQTT_CONNECTION_STRING", "tcp://test:hellotest@localhost:1883");
});

In the above code, the container has been started, but RabbitMQ in the container has not yet been started. At this time, the Dapr sidecar has been started and requires the RabbitMQ service. However, because the service cannot be found, the Dapr sidecar stops working and there is nothing to set. Try the restart strategy, and then although RabbitMQ has started successfully, Dapr becomes dead.
Wish there was an option to automatically try to restart after failure, so that would solve the problem.
The container can be restarted after failure through startup parameter settings, but I don't want to containerize the Dapr sidecar, so there is no option to restart.
sidecarBuilder.WithRestartAlways()
.WithRestartAlways(10) // 10 seconds

Hopefully something like this setup.

@karolz-ms we discussed this a while ago. Since we don't have startup dependencies, we need a way to restart on fail when containers need to connect to each other, and we are unable to control retries inside of that container.

Yep, we should be able to address it sometime before GA.

+1

@karolz-ms we discussed this a while ago. Since we don't have startup dependencies, we need a way to restart on fail when containers need to connect to each other, and we are unable to control retries inside of that container.

We have also seen cases when a container starts successfully and fairly quickly, but then takes 10+ seconds to actually start responding to requests. So the startup dependencies would not help in that case.
Best solution is to make the client robust (retry connections with exponential backoff). Second best is to retry the failed containers/executables a few times before giving up, which is what this feature is about.

In fact, there are many ways to solve this problem, and you have to consider how to design it.

Try to restart continuously (number of times, exponential backoff algorithm, try time interval).
Use the health endpoint provided by the service in the container to monitor health status.
Start in sequence through certain dependency settings.

etc.


multilanguage support

Laravel Version: 5.4
Voyager Version: 0.11.1
PHP Version: 7.1
Database Driver & Version:

Description:
Hello, how to enable multilanguage support
Steps To Reproduce:

Multilang would be great!


Possible to terminate span on remote system?

I've got a data processing pipeline with spans setup for each task, and I'm properly injecting/extracting context as execution moves from node to node to run different task types. Unfortunately I'm struggling to get one span across the entire "transaction." Seems the issue is I'm starting my desired top-level parent span on one node, but I need to finish it span on a different node. Is there an API for this?
I have been able to setup a timer on the origin node to query the DB repeatedly to check if the overall "transaction" is done, and then finish the top-level parent span. This half works, although 1) it loads the database 2) total span time is always a multiple of how rapidly I query the DB, which means point (1) gets really bad if I was a decent visibility into total e2e transaction latency at a high-ish transaction volume.
Any tips you could offer?

Span represents a unit of work in a single process. You need to use two spans if they are in different processes, and link them as parent-child.

I've got parent/child linkage working, what I'm hoping to also have is a top-level "span" (or span-like?) that encompasses the entire flow, so I can easily see the end-to-end latency as well as get a nice graphical breakdown of which stages took the most processing time.
My goal is to marry distributed tracing with a data pipeline for visibility. There is not one "top-level" process where the pipeline both starts and ends. Data comes into an initial node and flows through a processing pipeline, taking different routes depending on what is contained therein. My current "parent" is the span that first received the data, but the end result is a graphic that looks like:
|------|
       |--------|
                           |------|

e.g. there is no all-encompassing span. Perhaps this is a visualization issue - I'm using DataDog, would be interesting to know if other tools automatically provide some 'wrapper' span in scenarios like this that can then be used for statistics.
If there's no concept for this then that's OK, was just hoping I have missed something. Seemed to me the closest thing to ask for was ability to terminate a span on a remote system, so I could do this:
|---------------------------------|
|------|
       |--------|
                           |------|


Proxying a docker host application

Hello,
Is there any way to proxy an application installed on the host? This application is not inside a docker container.
Obviously, <IP_ADDRESS>give
nginx: connect() failed (111: Connection refused) while connecting to upstream

Fixed, by using the external IP.


Refactor line items forms

Resolves < no issue made for this >
Description

NOTE: This branched is based off of #1983
I noticed when working on #1983 that when you pushed the "add another item" button it would place the new line item in a really weird spot (screenshot 1). This was because of code like this:
<fieldset class="form-inline justify-content-around">
  <%= f.simple_fields_for :line_items do |item| %>

      <%= render 'line_items/line_item_fields', f: item %>

  <% end %>
</fieldset>

    <%= add_line_item_button f, "#distribution_line_items" %>

The add_line_item_button function was being told to add the new line item into the first occurrence of #distribution_line_items, but each line item in the loop gets that same id so it wasn't appending the new item to the end as expected, it was adding it to the first every single time. I added an id onto the fieldset that wraps this code so that we can pass the appropriate id to the add_line_item_button function.
I also moved the div on line 3 of the above code into the _line_item_fields partial so that we have less repeated code and so that the new line items added also have that div wrapping them.
Because this same pattern is repeated so many times across the app I put all of the code to achieve these fixes in the new _line_items_form partial to reduce repeated code.
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Screenshots

screenshot 1

Now new line items are appended to the bottom

Any updates on this? It is blocking your other PR from being merged :)

@carterrwood Thanks for catching this. This isn't the first time it's happened -- usually when we re-template things, a few IDs will be overlooked and that breaks some of our JS.
There was talk a while back about changing the JS to wire-up based on some other trait (data-attributes or something) or to hook into the body id/class (it's set to the controller / action, respectively).

@carterrwood This looks really good. That red diff, especially ;)
I don't have the app set up on this machine right now, but if you've manually tested it and can verify that the line-items are added correctly and post correctly (and also are re-rendered correctly in the case of an error), it LGTM. :+1:

Looks like you need: rubocop -a
and to fix these two specs:

rspec ./spec/system/donation_system_spec.rb:406 # Donations When signed in as a normal user When creating a new donation Via barcode entry Updates the line item when the same barcode is scanned twice
rspec ./spec/system/purchase_system_spec.rb:221 # Purchases while signed in as a normal user When creating a new purchase via barcode entry User scan same barcode 2 times

Any updates on this? It is blocking your other PR from being merged :)

Hi Sean! Sorry I've had a busy week but yes I'll look into updating this now. But this branch is dependent on the other one (#1983) so even if it is merged on it's lonesome everything should be okay! Unless of course we'd want to merge both of them in together.

Thanks for the update! Merging the other one now!

Hmmm looks like the other PR made conflicts with this one :(


What does e6b mean?

E-6B was the part number given to the slide-rule computer in the U.S. Army Air Corps during WWII.
https://en.wikipedia.org/wiki/E6B


Can not use in Kotlin 1.4 in K/N

When update to Kotlin 1.4, and build with K/N.
Happen failure as below:
> Task :myLib:cinteropUICKeyChainStoreIosX64 FAILED
w: Skipping "${HOME}/.gradle/caches/modules-2/files-2.1/org.kodein.di/kodein-di-iosx64/7.0.0/ccc9ef9022eb8cf1593b92bd2c3c17bea317c157/kodein-di.klib" as it is a pre 1.4 library
e: Could not find "${HOME}/.gradle/caches/modules-2/files-2.1/org.kodein.di/kodein-di-iosx64/7.0.0/ccc9ef9022eb8cf1593b92bd2c3c17bea317c157/kodein-di.klib" in [${HOME}/project/kotlin-Denco/ios/Pods, ${HOME}/.konan/klib, ${HOME}/.konan/kotlin-native-prebuilt-macos-1.4-M2/klib/common, ${HOME}/.konan/kotlin-native-prebuilt-macos-1.4-M2/klib/platform/ios_x64].

Would you rebuild and distribute with Kotlin 1.4-M2?

Sorry, its impossible for use to release Kodein-DI on 1.4-M2, because of this https://youtrack.jetbrains.com/issue/KT-39807
it breaks the compiler on most of the code used by DI in our test suite.

Oh...
I understood it.
Thank you for respond.

Those changes have been fixed on M3, so I will certainly be able to build on top of it.


Improve current nav when changed colours

Box shadow disappears when changing colours in your browser, for example Firefox
Screenshot
Before

After

You can preview this change here:
Built with commit 9396cb1f8b28c3062b7d71b9f506c82e7aef8f20
https://deploy-preview-1002--govuk-design-system-preview.netlify.com