[SupportRequest] Angular usage impossible as app-component does not get loaded, but only in webview (?)

Heyho, I've been wanting to play around with nimview while coding an Angular frontend and am running into a bit of trouble that I don't quite understand.
When debugging with the HTTP server, my project works exactly as expected. Angular components load normally and JS gets normally executed. When running it in webview mode (e.g. by using startDesktop or by using release mode) and only then does the application refuse to render anything that isn't in the initial index.html file.
 Minimal example

Download and install Angular cli (npm install -g @angular/cli)
Create new project ('ng new', in my examples I choose to include routing and use scss )
Add the following to index.html:
 Initial tag

Remove the entire contents of app-component.html and instead put in there the following:
App component heading

Compile the project (npm run build)
Copy-paste the contents of the <FRONTEND_PROJECT>/dist folder to your nimview project
create main file of your project with the following code:

#nimproject/src/nimproject.nim
import nimview

nimview.startDesktop(indexHtmlFile = "<RELATIVE_PATH_TO_ANGULAR>/index.html, debug=true)

compile and run the nim project (I use a nimble command for this:

#nimproject/nimproject.nimble
requires "nim >= 1.6.6"
requires "nimview >= 0.4.2"

task debug_run, "Build a release for debugging and run it":
  --run
  --threads:on
  --mm:orc
  --deepcopy:on
  --outdir:"."
  setCommand "c", "src/imagestable.nim"

Expected Outcome
The window that opens up should render the large text:
Initial tag
App component heading

 Actual Outcome
The window only renders the tag directly written into the index.html file:
Initial tag
There is no error visible in the console, which is I guess where JS errors would be rendered if there were any(?).
Find below the only output on the terminal that compiled and run the nimview project:
Hint: gc: orc; threads: on; opt: none (DEBUG BUILD, `-d:release` generates faster code)
84421 lines; 2.019s; 222.352MiB peakmem; proj: src/imagestable; out: /home/philipp/dev/imagestable/imagestable [SuccessX]
Hint: /home/philipp/dev/imagestable/imagestable [Exec]
DEBUG Starting desktop with file url

I've been trying to debug this, but I'm failing to figure out where I can see the possible error here. Is the way webview works just completely incompatible with Angular for some reason?

Hey! Thx for the very detailed description.
Seems that you are using linux with gtk, right?
Can you open the a debug console (F10?) and check the output?
Maybe there was an issue with babel. Sometimes, it was also necessary to enable the debug mode of gtk.
Unfortunately, issues like this were always hard to debug. On Windows, this was mostly due to the old IE rendering engine, which couldn't render new JS and also had issues with new CSS.
I didn't work on this project for some time. If I would start from scratch again, I would probably prefer Tauri & Rust.

My goal was mostly to write backend nim (as I vastly prefer it over Rust) and Tauri doesn't have nim-bindings (yet, but I'm not holding my breath, they might be announced but that's a long way off I think).
Yeah, I am using arch with the webkit2gtk package (which... should be correct ?).
Sadly F10 does not open up a console when opening a webview window, that's mostly why I'm so stuck as I seem to have no option to debug my JS in webviews.

Sadly F10 does not open up a console when opening a webview window

:/
I have no idea why F10 doesn't work. I once had a debug console on ubuntu and assumed it would be the same on each linux.


Compatibility with Expo

Ask your Question
Does this work with an expo app or do i have to eject?

It's a native module, so you have to eject :(

Know of any good alternative?


1.0.15

Just installed version 1.0.15 on my Raspberry Pi running Node-Red 0.14.5 and I'm now getting Cannot GET /worldmap
Nothing else has changed and it was working before upgrading to 1.0.15

My apologies, I meant version 1.0.16

Funnily, it just cleared itself. Looks like an issue with node-red 0.14.5 upgrade as something similar reported elsewhere.


TypeError: An op outside of the function building code is being passed a "Graph" tensor.

Hi I got following error when I tried to include the KL loss in Flipout layers.  Any helps will be appreciated.  Thanks,
TypeError: An op outside of the function building code is being passed
a "Graph" tensor. It is possible to have Graph tensors
leak out of the function building context by including a
tf.init_scope in your function building code.
For example, the following function will fail:
@tf.function
def has_init_scope():
my_constant = tf.constant(1.)
with tf.init_scope():
added = my_constant * 2
The graph tensor has name: dense_flipout/divergence_kernel:0
A example code that would create the same error as follows:
import numpy as np
import matplotlib.pyplot as plt
import os

def f(x, sigma):
    epsilon = np.random.randn(*x.shape) * sigma
    return 10 * np.sin(2 * np.pi * (x)) + epsilon

import tensorflow as tf

from tensorflow.keras import backend as K
from tensorflow.keras import activations, initializers
from tensorflow.keras.layers import Layer
import tensorflow_probability as tfp

tfd = tfp.distributions

import warnings
warnings.filterwarnings('ignore')

from tensorflow.keras.layers import Input
from tensorflow.keras.models import Model

train_size = 32
noise = 1.0

X = np.linspace(-0.5, 0.5, train_size).reshape(-1, 1)
y = f(X, sigma=noise)
y_true = f(X, sigma=0.0)

plt.scatter(X, y, marker='+', label='Training data')
plt.plot(X, y_true, label='Truth')
plt.title('Noisy training data and ground truth')
plt.savefig('data.png')
plt.close()

batch_size = train_size
num_batches = train_size / batch_size
kl_weight = 1.0 / num_batches

x_in = Input(shape=(1,))

x = tfp.layers.DenseFlipout(20, activation='relu')(x_in)
x = tfp.layers.DenseFlipout(20, activation='relu')(x)
x = tfp.layers.DenseFlipout(1)(x)
model = Model(x_in, x)

from tensorflow.keras import callbacks, optimizers, utils

def neg_log_likelihood(y_obs, y_pred, sigma=noise):
    dist = tfp.distributions.Normal(loc=y_pred, scale=sigma)
    return K.sum(-dist.log_prob(y_obs))

kl = sum(model.losses)
loss = neg_log_likelihood + kl

model.compile(loss=loss, optimizer=optimizers.Adam(lr=0.08), metrics=['mse'])
utils.plot_model(model, to_file = 'model_flipout.png',  show_shapes = True, show_layer_names = True, show_dtype = True, dpi = 600)
model.summary()
model.fit(X, y, batch_size=batch_size, epochs=1500, verbose=0);
model.save(f'flipout.h5')

import tqdm

X_test = np.linspace(-1.5, 1.5, 1000).reshape(-1, 1)
y_pred_list = []

for i in tqdm.tqdm(range(500)):
    y_pred = model.predict(X_test)
    y_pred_list.append(y_pred)
#import ipdb; ipdb.set_trace()
y_preds = np.concatenate(y_pred_list, axis = 1)
y_mean = np.mean(y_preds, axis = 1)
y_sigma = np.std(y_preds, axis = 1)

plt.plot(X_test, y_mean, 'r-', label = 'Predictive mean');
plt.plot(X, y_true, 'b-', label='Truth')

plt.scatter(X, y, marker = '+', label = 'Training data')
plt.fill_between(X_test.ravel(),
                 y_mean + 2 * y_sigma,
                 y_mean - 2 * y_sigma,
                 alpha = 0.5, label='Epistemic uncertainty')
plt.title('Prediction')
plt.legend();
plt.savefig('result_flipout.png')
plt.close()

@ckhuangf
We see that the issue template has not been filled, could you please do so as it helps us analyse the issue.
Could you please refer the similar issues #32889, #33729, and let us know if it helps.Thanks


Can we get a self contained executeable windows installer?

Sorry if this is an improper channel but I am having great difficulty installing on windows within our corporate environment due to our stern security policies.
I've found a lot of people have similar problems and it seems a good workaround would be to have an exe that doesn't need to pull any more data from repos and just lets you get up and running with some basic features?

Hi @gigajoules. As per the issue template you were shown, please use discourse.nodered.org to discuss this sort of request.

Closing as per my comment above.

Why you don't use nexe to generate an executable?


Add ability to parse list of PR data for PRs that was created by a specified user!

an unexpected behavior that might work in our favor:
After you submit a repo name, entering any  username in the username input field, will automatically parse the entire repo's PR for PR that was created by that user. This action doesn't require fetching from github api again.  May or may not be in our benefit.

it works! i'm pretty sure this feature would be useful in the near future. thanks!

Thank you!


Fix #1037: fix or remove obsolete examples

I think these changes look good, but I am not sure structures.py had to go - the equivalent in current Numba might look like:
# -*- coding: utf-8 -*-
from __future__ import print_function, division, absolute_import
from numba import jit
import numpy as np

record_type = np.dtype([('x', np.double), ('y', np.double)])
a = np.array([(1.0, 2.0), (3.0, 4.0)], dtype=record_type)

@jit
def hypot(data):
    result = np.empty_like(data, dtype=np.float64)
    # notice access to structure elements 'x' and 'y' via attribute access
    for i in range(data.shape[0]):
        result[i] = np.sqrt(data[i].x * data[i].x + data[i].y * data[i].y)

    return result

print(hypot(a))

Although struct is gone from Numba, it works directly with structured dtypes just fine.

Good point. I've re-added your suggested example.

A couple of other things - fbcorr.py still looks odd in that it specifies arg types and sometimes uses range and xrange at other times.
findmulti.py doesn't seem to be doing anything, unless it's related to the pycc examples in a way I haven't understood. Also, are compile_with_pycc.py and pycc_example.py relevant anymore? Should they be compiled with the numba command line tool rather than pycc, for example?

I don't know about findmulti, we can probably remove it (I don't know what the function is supposed to compute).
I don't think the numba command-line tool has replaced pycc. Actually only pycc is tested AFAIK.

I just tried pycc with the pycc_example.py and it seems to work - I had made the mistake of thinking that pycc didn't exist because it wasn't in the bin folder.


Specific Useful Error when running behind firewall

Description
A very common problem when people try out ngrok is that they are behind a firewall that has blocked ngrok's outbound tunnel/session domain name ngrok.com. Simulating by turning off my wifi and restarting the pods, you just get a crash loop with these logs
2023-03-13T22:22:40Z	INFO	controller-runtime.metrics	Metrics server is starting to listen	{"addr": ":8080"}
2023-03-13T22:22:40Z	INFO	setup	found matching ingress	{"ingress-name": "ingress-consul", "ingress-namespace": "default"}
Error: unable to create tunnel driver: failed to dial ngrok server with address "tunnel.ngrok.com:443": dial tcp: lookup tunnel.ngrok.com on <IP_ADDRESS>:53: no such host
Usage:
  manager [flags]

Flags:
      --controller-name string             The name of the controller to use for matching ingresses classes (default "k8s.ngrok.com/ingress-controller")
      --election-id string                 The name of the configmap that is used for holding the leader lock (default "ngrok-ingress-controller-leader")
      --health-probe-bind-address string   The address the probe endpoint binds to. (default ":8081")
  -h, --help                               help for manager
      --metadata string                    A comma separated list of key value pairs such as 'key1=value1,key2=value2' to be added to ngrok api resources as labels
      --metrics-bind-address string        The address the metric endpoint binds to (default ":8080")
      --region string                      The region to use for ngrok tunnels
      --server-addr string                 The address of the ngrok server to use for tunnels
      --watch-namespace string             Namespace to watch for Kubernetes resources. Defaults to all namespaces.
      --zap-devel                          Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error) (default true)
      --zap-encoder encoder                Zap log encoding (one of 'json' or 'console')
      --zap-log-level level                Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
      --zap-stacktrace-level level         Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
      --zap-time-encoding time-encoding    Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

2023-03-13T22:22:40Z	ERROR	setup	error running manager	{"error": "unable to create tunnel driver: failed to dial ngrok server with address \"tunnel.ngrok.com:443\": dial tcp: lookup tunnel.ngrok.com on <IP_ADDRESS>:53: no such host"}

Use Case
Since this situation and error are so common, it would be ideal to give a very specific and detailed error message with links to docs on how to address the problem
Related issues
No response

Another option to make this error very explicit is to use a helm pre-install hook that launches a single job or pod with the ngok agent that runs the diagnose command.
To take this even further, the pod could/should actually not crash and just show that there is an error and retry. It could also launch the diagnose command on a cron to continually check

@salilsub mentioned that in addition to making the error message clear, we should also document it as a common issue people can encounter.

@nikolay-ngrok Will the k8s controller execute its reconcile loop while in the not ready state?
We're curious about reconciling deletions, updates, and other metadata on the Ingresses while the api/tunnel/etc... services are not available (like in env create/destroy locally).


How to use environment variable for brokerList in kubernetes deployment

I'm running into an issue where I'm trying to deploy a C# azure function and deploying it to kubernetes.
The KafkaTriggerAttribute.brokerList attribute seems to be what is used when building the metadata for the ScaledObject.
The only way I can get the ScaledObject kubernetes resource to generate correctly is by using the brokerlist directly in the function rather than providing any kind of app settings variable. The app settings variable does seem to work for the actual runtime, but not the KEDA trigger. The below function produces the correct ScaledObject resource
 [FunctionName("Cars")]
        public static async void Run(
           [KafkaTrigger("my-confluent-oss-cp-kafka-headless:9092", "cars", ConsumerGroup = "cars")] byte[][] kafkaEvents)
        {
            foreach (var kafkaEvent in kafkaEvents)
            {
                var car = await deserializer.DeserializeAsync(kafkaEvent, false, SerializationContext.Empty);
                Console.WriteLine($"Custom deserialised user from batch: {JsonConvert.SerializeObject(car)}");
            }
        }

  triggers:
  - type: kafka
    metadata:
      type: kafkaTrigger
      consumerGroup: cars
      topic: cars
      brokerList: my-confluent-oss-cp-kafka-headless:9092
      authenticationMode: notSet
      protocol: notSet
      name: kafkaEvents

But I don't want to have to provide my brokerList at runtime. Altering it to LocalBroker  makes the runtime work and pulling from an app settings variable work, but the ScaledObject reference breaks and it produces something the KEDA operator canot use.
        [FunctionName("Cars")]
        public static async void Run(
           [KafkaTrigger("LocalBroker", "cars", ConsumerGroup = "cars")] byte[][] kafkaEvents)
        {
            foreach (var kafkaEvent in kafkaEvents)
            {
                var car = await deserializer.DeserializeAsync(kafkaEvent, false, SerializationContext.Empty);
                Console.WriteLine($"Custom deserialised user from batch: {JsonConvert.SerializeObject(car)}");
            }
        }

 triggers:
  - type: kafka
    metadata:
      type: kafkaTrigger
      consumerGroup: cars-20
      topic: cars
      brokerList: LocalBroker
      authenticationMode: notSet
      protocol: notSet
      name: kafkaEvents

Long story short, I want to be able to use an environment variable in some way, but if I do, the ScaledObject resource is wrong. Am I missing something obvious?

Hi @tjsiron
Thank you for this issue. I realize that the issue. In this case, Kafka Trigger on C# is fine. However, The KEDA scaler configuration might be the issue. Under the hood, Kafka Trigger on this repo, substitute the LocalBroker as Environment variables.  So that there is no connection between KEDA and this Kafka Trigger. For enabling the feature, could you create an issue on KEDA repo? https://github.com/kedacore/keda/issues For example, EventHubs trigger already implement it. https://keda.sh/docs/2.0/scalers/azure-event-hub/

Thank you! I will do that. I wasn't sure which repo it fell under.

@tjsiron did @TsuyoshiUshio's suggestions resolve the issue for you?

I ran into this too with JS functions.  Most of the other plugins substitute strings like %VARIABLE% in bindings with environment variable values.  This one apparently does not.  https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-expressions-patterns


obsolete auth instance not removed from remote env

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
5.1.0
What operating system are you using?
Windows
Amplify Categories
auth
Amplify Commands
Not applicable
Describe the bug
In our project we had added auth, then we have removed it to create a new one with a different configuration.
The obsolete auth is not referenced in any file anymore, but when I do an amplify pull --restore I keep getting the files

This seems to occur only in one of the env. If I create a new env from scratch, it just won't add the obsolete stack and the issue doesn't occur.
I haven't found a way to get rid of that obsolete auth: it's not in Cognito, it's not in any cloudformation file.. I don't how to get rid of it.
Expected behavior
When running amplify auth remove xx I expect that stack to be removed locally and remotely. If I then push the changes into git, when merging into a different branch associated to another env, I would expect that env to be updated to point to the new auth (which works), but also to remove all files related to the that obsolete auth (which is the issue).
Reproduction steps

on branch 1, add auth-x to env-a, push to branch-1
checkout branch 2, merge branch-1 into branch-2 where CI/CD is configured (automatic build) with env-b
== env-b should have auth-x
remove auth-x to env-a, add auth-y to env-a, push
checkout  branch 2, merge branch-1 into branch-2 (this will update CFN for env-b removing all references to auth-x), git push to branch 2 == env-b should have auth-y and env-x should be removed  (automatic build on amplify)
checkout branch-2, checkout env-b, do an amplify pull --restore >> if the pull brings back files related to auth-x, that's the issue

I haven't found a way to get rid of that obsolete auth: it's not in Cognito, it's not in any cloudformation file.. I don't how to get rid of it.

When you say that the auth is not in any CFN file, do you mean local files only? Can you also confirm whether or not it exists in your deployed version.
In your last step, you're running amplify pull --restore. That should overwrite any local changes with what is in the cloud. If the auth still exists in the cloud, that may explain what's happening. Have you pushed the changes to env-b in the cloud?

Thanks coming back to this. I have to admit it's not easy to remember the exact steps, which I am aware it's not great to attempt reproducing the issue.
The main point is env-b is configured to build automatically in amplify upon new commits to branch-2.
While for env-a I did an explicit amplify auth remove and amplify push, for env-b I shouldn't need to that because CFN is updated with a new auth (auth-y). The pipeline build correctly introduced auth-y in env-b, the problem is that it didn't remove files and folder of auth-x (remotely), even if not referenced in CFN anymore. So when I do a pull - - restore they come back to life locally. I don't have a way to remove them remotely. If I execute amplify auth remove auth-x it gives me an error (because not in config), cut) but the folder is there.
Anyways, it's not a big deal, I think it's an edge case and not that easy to reproduce. I myself don't currently have the time to try a full reproduction of the issue.
I am fine with closing the ticket if need be.

Thanks @cfbo. If you're able to reproduce it consistently, feel free to come back to this issue.


build: avoid conflicts when publishing snapshot builds

For the past year, we've had CI failures when multiple PRs
have been merged. Since we run CI for all landed commits, the
snapshot publish job runs multiple times concurrently and could
end up pushing to the snapshot repositories out of order.
This can result in conflicts when multiple jobs push artifacts
at the same time. e.g. https://circleci.com/gh/angular/components/155407.
We intend to fix this by queuing snapshot publishing across CircleCI
builds. This is done using the CircleCI API. We constantly check the
API to check that there are no previous snapshot jobs running.
Instead of implementing this logic our own, we leverage a CircleCI
orb that provides this functionality.

Note: There is no easy way to test this on my end. The orb does not run on forked builds, so I cannot test this on my fork.
@jelbourn @josephperrott If we think this is worth trying, I think we should just merge it, and if it doesn't work, revert it immediately?

Removed merge ready label for @devversion to do testing, if it doesn't work, or you would prefer to just test it live, feel free to mark merge ready again.

I say just go for it

Yeah, I was thinking about testing this upstream, but snapshot builds do not run for arbitrary upstream branches, and CircleCI auto-cancels redundant builds on branches (except for the default one. i.e. master). I gave it a shot upstream to just see if there is any configuration issue, but looks like we should be good.


[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 7 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exec/spill/spiller.cpp
0
1
00.00%
[119]

:large_blue_circle:
src/exec/pipeline/aggregate/spillable_aggregate_blocking_source_operator.cpp
0
6
00.00%
[36, 37, 103, 105, 106, 107]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 10 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exec/pipeline/bucket_process_operator.cpp
0
3
00.00%
[54, 55, 56]

:large_blue_circle:
src/exec/spill/spiller.cpp
0
1
00.00%
[122]

:large_blue_circle:
src/exec/pipeline/aggregate/spillable_aggregate_blocking_source_operator.cpp
0
6
00.00%
[36, 38, 42, 103, 105, 106]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

https://github.com/Mergifyio backport branch-3.2


How to set md-order-by for column names created by ng-repeat

I am trying to get the md-order/md-order-by working for column names populated via ng-repeat, but not able to make any progress. The sort ordering for the data works on the default column set by vm.order, but I am not able to get the interactive sorting working once the data table is populated.
Please see my code for the view
<md-table-container class="gf-cards-table" md-progress="vm.metrics">

                         {{ c.column_name }}

                         {{ d[c.column_name] }}

             </md-table-container>

Have a look at a similar "bug" response: https://github.com/daniel-nagy/md-data-table/issues/243

@gurdeep18 I'm reposting your code, formatted for better readablity:
<md-table-container class="gf-cards-table" md-progress="vm.metrics">

				{{ c.column_name }}

				{{ d[c.column_name] }}

</md-table-container>

You added ' | orderBy: vm.order' in the th and td tags, whereas it should only be in the ng-repeat of the tbody's tr tag.
Please check below my version and let me know if it worked:
<md-table-container class="gf-cards-table" md-progress="vm.metrics">

				{{ c.column_name }}

				{{ d[c.column_name] }}

</md-table-container>


How to @import url(...)?

Description

Type: Question
The screenshot of the project below is building correctly in dev and prod.
I'm just trying to put my component and its style together in one folder. Importing with reative path works but @import '../../css/common/typography'; is an eyesore, IMO.
Can I import using @import url('...');?

Question
How to @import url(...)?

does this work?
 @import 'css/common/typography';

Nope..

wait... who cares! Moving on.


udp: implement recvfrom(2) in os_sys_calls_impl

Signed-off-by: Christopher M. Luciano<EMAIL_ADDRESS>Description: implement recvfrom(2) in os_sys_calls and use in udp_listener_impl
Risk Level: Low - same functionality but different implementation
Testing: bazel test //test/common/network:udp_listener_impl_test
Docs Changes: N/A
Release Notes: N/A

/assign @alyssawilk @conqerAtapple

LGTM.


Cannot read property 'fileOperationResult' of null

Extension version: 0.2.1
VSCode Version: 1.28.1
OS: Windows 10

Steps to Reproduce:

Click on second repo in Source Control Providers tab
Open Changes In Pull Request section open commits sub menu and a file in the commit

When trying to open a file I am getting the below error.
Unable to open 'database/seeds/PermissionsPermissionGroupsSeeder.php from 318d76cd': Cannot read property 'fileOperationResult' of null.

Same problem for me.
VSCode version: 1.28.2 (1.28.2)
OS : MacOS mojave
Extension version : 0.2.3

I still have this.
Unable to open 'xxx': Cannot read property 'fileOperationResult' of null.
When trying to open files in 'Changes in pull request'

Seems I had to uninstall, delete, install to make it work.

Recent insider update brought it in again -.-
Version 1.30.0-insider (1.30.0-insider)
456e8e64beb2dceac66743959f6802b66e18e300

Confirmed still an issue in 1.31.0 as well
Version 1.31.0-insider (1.31.0-insider)
edf1090b8546ad0d17f30bf6f8075613e37e1b37
clicking the 'open file' icon next to the file however does seem to open the file as expected.


net/http: Shutdown() may hangs forever

What version of Go are you using (go version)?

$ go version
1.18.3

Does this issue reproduce with the latest release?
seldomly reproduced
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOHOSTARCH="amd64"
GOVERSION="go1.18.3"

What did you do?
We have a program that runs a net/http server and it keeps two persistent connections with a client. Our program catches users' SIGINT signal and calls net/http.Shutdown() to terminate the server.
Yesterday, I hit Ctrl-c to terminate my program hence the http server, just as uasual, but the program just stuck, hopefully I triggered a pprof and got the full goroutines snapshot, I found my program stuck at the net/http.Shutdown() function.
After reading the documentation and the source code of net/http.Shutdown(), I realized that Shutdown() waits indefinitely for connections to become idle before closing them and returning.
So I think this is just what I encountered: the two persistent connections are too busy to become idle. But I then feel it's really low probable, since according to the source code, the http server turns the connection into idle once it sends the response and Shutdown() checks the connections in a very frequent manner.
I just post it here for some inspiration and see if I am the only lucky man who encountered this issue.
btw, the in reality issue I encountered in:
https://github.com/ethereum/go-ethereum/issues/25257

That would be working as expected, maybe you want to set http.Server.BaseContext in your code
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Upgrading to rails 5?

Since rails-api has been merged into Rails 5, is there any guidance for upgrading from an existing 4.2 rails-api application?
I assume the Rails upgrade guide is useful, and I see I should probably add config.api_only = true to my application config -- is there anything else that needs to or should be done?
Cheers!

There are instructions for applying the gem to an existing Rails application in the README. Did they not work for you?

+1. Would love to get some guidance on upgrading.

+1. I'm in the same boat and would appreciate any insight on this topic as well.

Doesn't this http://edgeguides.rubyonrails.org/api_app.html#changing-an-existing-application work for you?.
Maybe if not or if it lacks some stuff is a good starting point if any of you guys want to provide a better upgrading guide?.
Please if you want to go ahead provide PRs improving it.

@ledbettj @jbrukh @aarongray any tips if you guys did end up upgrading? I am looking to do the same!

FWIW, I tried upgrading and running into the following issue (might be an AMS 0.9x issue): https://github.com/rails-api/active_model_serializers/issues/1923
If anyone here has tried upgrading, and encountered this issue, I'd appreciate any help!

Here's a tutorial on Updating rails-api to Rails 5 in API mode.


Tentative fix to notify systemd after we startup a node

See https://issues.serokell.io/issue/CSL-1235 for context.
In a nutshell, this PR does a number of things:

It conditionally builds cardano-node with the systemd package, which is available only on environments which ships systemd and have libsystemd-dev installed. Unfortunately the systemd package doesn't enforce the library presence by default, and maybe it should.

It uses CPP (sigh!) to define a notifyReady function inside Pos.Launcher.Runner, which we call inside runServer. I had to draw a line about where to actually call this function, and when we can effectively consider a cardano-node as being READY, and that seemed the most appropriate place, but I'm totally happy to take recommendations.

On non-linux platforms, notifyReady is a noop.

I couldn't use System.Info.os and had to recur to CPP here as the entire System.Systemd.Daemon module would be in scope only on linux, so CPP that is.

@cleverca22 Uhm, running ./pkgs/generate.sh didn't help, and I might speculate that's because the systemd package is being included in build-depends only if we are on linux (flag linux in the cabal manifest). Any chance stack2nix is not taking that into account? What am I doing wrong? 😭

It appears that cabal2nix is not setting the linux flag when generating package set. Investigating.

Blocked on https://github.com/input-output-hk/cardano-sl/pull/1314

@domenkozar Oh dear 🙉  Now the Darwin/nix build is failing with:
Aug 11 08:48:06 building cardano-sl with nix
Aug 11 08:48:06 trace: using host nixpkgs
Aug 11 08:48:07 error: assertion failed at /nix/store/8h2rvq50a25gs1iasaycjlxksrqq0hbj-a905b7cd0c2dc0714195a50bf176cd8e4593502d.tar.gz/pkgs/os-specific/linux/systemd/default.nix:9:1
Aug 11 08:48:07 (use ‘--show-trace’ to show detailed location information)

Oh man, I owe you a beer with all the troubles :)
This is another bug in stack2nix when it comes to macOS. See https://github.com/input-output-hk/stack2nix/issues/56
For now I suggest we always depend on systemd haskell package and leave a comment pointing to the above stack2nix issue.

New position of notifying looks fine. I'm happy for this to be merged once it's rebased and CI is green.

For now I suggest we always depend on systemd haskell package and leave a comment pointing to the above stack2nix issue.

I don't think we can enable it willy-nilly on each platform as this package performs FFI calls and requires POSIX headers. Luckily I think we should be able to get away with this if we enable systemd for unix systems only, like:
if !flag(windows)
    build-depends: systemd

Rationale is that systemd should compile on darwin & linux and we still have CPP in the code making sure we don't invoke the package's API on nothing but linux. @domenkozar Do you think this should be enough to workaround the stack2nix bug? 😉
I will try and see what the CI has to say 😁

@adinapoli-iohk sounds good :)

This PR seems cursed. The CI yesterday on Win failed due to some network failures and on *nix a test failed. I've merged master and gave it another spin.


Incorrect warnings / errors upon first connecting to MATLAB

The MATLAB linter correctly identifies info, warnings, and errors for MATLAB files, shown below in this contrived example

However, upon connecting to MATLAB, the warnings get reloaded. They appear to be correct for the first file, but these warnings are identical for the rest of the files (incorrect).

Currently, the way to "fix" this bug is by going through and manually saving every file again.
I have seen this error on both Windows and Mac (Apple Silicon).
Visual Studio Code 1.85.1
MATLAB r2023b, r2023a
MATLAB Extension v1.1.5

I have been able to reproduce this on my end. Thanks for reporting!


[FIX] Nav bar issue fixed

Nav Bar Issue Fixed

Fixes #154
Scroll bar removed
Login and Sign up button hover effect added

Screenshot :

Pull Request Checklist

[x] I have added screenshots and videos to show before and after the working of my code.
[x] I have ensured that the screen size is set to 100% while making the video.
[x] I have synced the latest fork with my local repository and resolved any conflicts.
[x] I understand that if any the above conditions are not met , my PR will not be MERGED .

Refork and resync from latest repo as you have file having non-uniform image size

Refork and resync from latest repo as you have file having non-uniform image size

Okay

Please add level to this PR !!


Add additional extended Selectors to for networks in virtual deployments.

What would you like to be added?
I would like to add the ability to select attached networks when running in a virtual environment.
The two tags are:

NetworkID -- A string representing the unique identifier for the attach SDN network.  For example, in OpenStack this would be a UUID.
NetworkTag -- A string representing an identifying attribute/name that has been attached to the network.  For example, in OpenStack the SDN network to be attached has been tagged as radio_uplink_a.

What is the use case for this feature / enhancement?
When Kubernetes is run in a virtual environment (OpenStack, VMWare, etc...), additional SDN networks can be attached to the VM. In such environments as OpenStack, additional metadata is provided such that the UUID and tagging information
of a network is made available inside the VM running Kubernetes.  For example, a Kubernetes installer can provide
the UUID and/or additional tag information for the network that is being attached.   A proposed PR for the sriov-network-operator exposes this information via the sriovnetworknodestate CRD.   It would be desirable to allow this additional metadata be used to select the correct interface for the application.

I would like to add the ability to select attached networks when running in a virtual environment.>
The two tags are:

NetworkID -- A string representing the unique identifier for the attach SDN network. For example, in OpenStack this would be a UUID.
NetworkTag -- A string representing an identifying attribute/name that has been attached to the network. For example, in > OpenStack the SDN network to be attached has been tagged as radio_uplink_a.

So there would need to be a mapping of some sort between PCI devices and tag(s).
A couple of questions here:

who exposes this information to the VM?
how is this information exposed ?

a Kubernetes installer can provide
the UUID and/or additional tag information for the network that is being attached. A proposed PR for the sriov-network-operator exposes this information via the sriovnetworknodestate CRD. It would be desirable to allow this additional metadata be used to select the correct interface for the application.

Could the same kubernetes installer translate the platform metadata into a valid pool configuration via existing selectors ?

There is a mapping between PCI addresses and tag(s).  The format of OpenStack data is shown here.  A snippet of an example is below...
"hostname": "test.novalocal",    "launch_index": 0,    "meta": {       "priority": "low",       "role": "webserver"    },    "devices": [        {          "type": "nic",          "bus": "pci",          "address": "0000:00:02.0",          "mac": "00:11:22:33:44:55",          "tags": ["trusted"]        },
The mapping is in the meta_data.json file itself.  The tags are supplied when the VM is created in OpenStack by attaching an attribute to the -nic parameter i.e. for the above something like ...  nova boot .... -nic ...,tag="trusted".
The installer will include the user-defined tag.  An additional network_data.json file is also available which containers the following:
{     "links": [         {             "ethernet_mac_address": "fa:16:3e:9c:bf:3d",             "id": "tapcd9f6d46-4a",             "mtu": null,             "type": "bridge",             "vif_id": "cd9f6d46-4a3a-43ab-a466-994af9db96fc"         }     ],     "networks": [         {             "id": "network0",             "link": "tapcd9f6d46-4a",             "network_id": "99e88329-f20d-4741-9593-25bf07847b16",             "type": "ipv4_dhcp"         }     ],     "services": [         {             "address": "<IP_ADDRESS>",             "type": "dns"         }     ]
The network_data.json file provides the UUID of the underlying network.

Could the same kubernetes installer translate the platform metadata into a valid pool configuration via existing selectors ?

Excellent question...  Unfortunately, the target PCI address is not know by the installer before invoking the server create command.  However, the sriov-network-operator does know the target pci address.  The operator could do a match and fill in the rootDevice field with the pci address of the matching NetworkID and/or NetworkTag.   However, while the matching is done inside the network-config-daemon of the operator and is specific to a particular node, there is only one configFile for the sriov-network-device-plugin.  The pci address inside the VM would need to be guaranteed to be the same on all VMs.  This behaviour is not specified by the OpenStack API.  One solution at the sriov-network-operator level would be separate config files for each sriov-network-device-plugin.

/cc @ahalim-intel @martinkennelly

one question, how would we expect device plugin to parse the metadata file. does it need to understand the openstack metadata file structure?

regarding "sriov-network-operator level would be separate config files" maybe we should update the sriov-device-plugin also to extend the resources from local file on the node. So the configmap is globe across cluster but you can add additional file to extend it per node.
for example:
{
"resourceList": [{
"resourceName": "intel_sriov_netdevice",
"selectors": {
"vendors": ["8086"],
"devices": ["154c", "10ed"],
"drivers": ["i40evf", "ixgbevf"]
}
},
],
"extra_resources": "extra_resources.json"
}
The SR-IOV operator can create it extra_resource.json per node. The SR-IOV device plugin  merged the resourceList in the configMap with the extra_resources.json file to one resourceList.
each node will have it own extra_resources.json per the VM.

one question, how would we expect device plugin to parse the metadata file. does it need to understand the openstack metadata file structure?

The device plugin would not need to parse the metadata file if the NetworkID and NetworkTag fields are added.  A higher level process (i.e. the sriov-network-operator/sriov-network-config-daemon) would do the parsing of the metadata information (the parsing is in the current PR) and place it in the configMap for the device-plugin.  NetworkID, NetworkTag would then be used as another selector in the device-plugin logic.  The NetworkID and NetworkTag are globally consistent and since the matching is being done by the device plugin on each node, there would not need to be specific to the node.

I had made a mistake in thinking that the device plugin would not need to parse metadata.  Need to discuss the node-specific configuration method...

PR 279  Should eliminate the need to additional Selectors.  With individual config files, the correct device can be selected using the PciAddress for the specific node inside the SR-IOV operator.

Closing this for now.


Not able to connect to DevOps

Hi, i am not able to connect github to DevOps ... everytime i try i get the following error:
Failed to set events: commit_comment, content_reference, issues, issue_comment, pull_request, push, repository.
I tried with multiple GitHub accounts but always get the same error. Am i missing any configuration settings or what is going on here?
Thanks!

Hi @alex-omnipark ,
Need more information. Could you please share the screenshot or the lab which you followed.
Thanks


Correctly pass options object

This is a fix for this bug https://github.com/purifycss/grunt-purifycss/issues/7

I think it'd be nice to keep the defaults: http://gruntjs.com/api/inside-tasks#this.options
On https://github.com/purifycss/grunt-purifycss/pull/12/files#diff-56dbf8e9ec3b352cf5842d5dbaa8e1bbR18 you can add
var options = this.options({
  write: false,
  info: true,
});

Please merge this

#19 fixed this, thank you


Add Arbitrumand Polygon mainnets

Hi 👋
Thanks for the plugin, it's very useful for writing PoCs!
In this PR I'm adding Arbitrumand Polygon mainnets support.

forgot to bump version and publish, did it now


User Sessions module

Jointly made by pudquick, clburlison, and tuxudo

I loaded this branch up and took a look at the information. That's going to be a lot of info. With just two home computers I have 599 entries. Too much?
I'd like to see a simplified view of unique usernames per machine -- just a list of all users that have logged into the computer.  That was my original intention with the FR.
How about making the timestamp in the listing more precise like the tab view?  If I'm looking for login info I'd be curious as to the exact times that that happened, not the general day that it happened.

Mouseover the times in the listing for exact times.

I still think the specific time information is appropriate for this listing especially when there can be multiple entries per day.


⚠ Turnos 24x7 has degraded performance

In 99a1643, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 2859 ms

Resolved: Turnos 24x7 performance has improved in 861ea00.


Visual Studio 2012 won't build

I've been battling to get this to work with Visual Studio 2012 (plugin says that it should work with 2012), and I still can't get it to compile and run.
The problem is that the typescript compiler fails to recognise the namespace keyword.
It seems to be a feature only found in Typescript after 1.0 (and it seems that 1.0 is the last available version supported for Visual Studio 2012, am I right?).
Is there a way to get this to work with Visual studio 2012 and Typescript 1.0?

You need TypeScript 1.8.6. It doesn't look available for VS 2012. Either you need to setup VS 2015 Community, or disable TypeScript compilation from your csproj and invoke command line compiler.


Account Creation Example Failing With 0.11.1

Problem
make create account fails
Steps to Reproduce
Terminal 1
flow init
flow emulator start

Output:
INFO[0000] ⚙   Using service account 0xf8d6e0586b0a20c7  serviceAddress=f8d6e0586b0a20c7 serviceHashAlgo=SHA3_256 servicePrivKey=XXXXXXXXXX serviceSigAlgo=ECDSA_P256
INFO[0000] 🌱  Starting gRPC server on port 3569          port=3569
INFO[0000] 🌱  Starting HTTP server on port 8080          port=8080
WARN[0008] ❗  Transaction reverted                       txID=d63972b3b0ebe78dd0cef20b02ef49432faeb46af1715c9c6936c32cadbb478f
WARN[0008] ERR [d63972] invalid signature: signature could not be verified using public key with index 0 on account f8d6e0586b0a20c7

Terminal 2
cd flow-go-sdk/examples
make create-account

Output:
Waiting for transaction d63972b3b0ebe78dd0cef20b02ef49432faeb46af1715c9c6936c32cadbb478f to be sealed...

Transaction d63972b3b0ebe78dd0cef20b02ef49432faeb46af1715c9c6936c32cadbb478f sealed
Account created with address:<PHONE_NUMBER>000000

I tried this with flow v0.11.2 against HEAD and it works now.

Thanks @bjartek!
This was due to an incompatibility between the Go SDK and the emulator bundled in the latest CLI release.


Upgrade Laravel from 5.4 to 5.5

Upgrade Laravel from version 5.4 to 5.5 released on August 30th, 2017.
The upgrade guide is available in the documentation.
@hoseinz3 has already created a Pull Request for this update.

Closed by #23


Improve Close/Early Disconnect Code

My previous contribution for the rapid cycling/shutdown issue appears to have fallen down in the case where a Kafka instance is temporarily down. The code will set the _disconnected flag, but then cause all subsequent reconnect attempts to terminate.
This change does the following:

Moves the logic from disconnect to close
Renames the variable to reflect it's new home.

I also noticed this problem yesterday. I should have been more careful with merging PRs on vacation :) I fixed it in 2.5.4


Receiving Invalid request signature detected

Hey team,
So, I am receiving the Invalid request signature detected. In last few days, it has become very common!
I have made a change to my system where the event that I get is responded with ack() and then I use FastAPIs background tasks to run the business logic and processing for the message event.
Weirdly this does not happen for each event, only few events!
In the background tasks, I use the event_context to call apps.event.authorizations.list api endpoint.
I am not sure why this issue is emerging. Does the event_context also expire?
Reproducible in:
The slack_bolt version
slack_bolt==1.20.1
slack_sdk==3.32.0
Python runtime version
Python 3.11.6
OS info
Amazon Linux release 2023.5.20240903 (Amazon Linux)
#1 SMP Tue May 21 16:54:42 UTC 2024
(Paste the output of sw_vers && uname -v on macOS/Linux or ver on Windows OS)
Steps to reproduce:
Expected result:
I should not get intermittent issues with Invalid Request signature.
Actual result:
This is one log:

slack_bolt.RequestVerification INFO Invalid request signature detected (signature: v0=7701e8a900b2793475c41e3c65804eaa72c3d0dfbd1445335339adaac9c2e9ba, timestamp:<PHONE_NUMBER>, body: {"token":"6J0cNanPs4p2KjLVavCwXYBk","team_id":"<>","enterprise_id":"<>","context_team_id":"<>","context_enterprise_id":"<>","api_app_id":"<>","event":{"subtype":"bot_message","text":"Alert: Content is Passed for whatsapp request, external","type":"message","ts":"1725954555.694759","bot_id":"<>","blocks":[{"type":"rich_text","block_id":"N0ar","elements":[{"type":"rich_text_section","elements":[{"type":"text","text":"Alert: Content is Passed for whatsapp request, external "}]}]}],"channel":"<>","event_ts":"1725954555.694759","channel_type":"channel"},"type":"event_callback","event_id":"Ev07L9HBMQ7R","event_time":1725954555,"authorizations":[{"enterprise_id":"<>","team_id":"<>","user_id":"<>","is_bot":false,"is_enterprise_install":false}],"is_ext_shared_channel":false,"event_context":"4-eyJldCI6Im1lc3NhZ2UiLCJ0aWQiOiJUMTkzVFNaRkUiLCJhaWQiOiJBMDU1ME01N0NTWCIsImNpZCI6IkMwN0MwTkVSVzZSIn0"})

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi @manish001in, thanks for writing in. One possible cause might be that your web app modifies the request body before passing it to bolt-python's request verifier. The signature verification requires raw request body data. If the body data is parsed beforehand and then converted to a string again, the string data is no longer the same. This is a common pitfall with Spring Boot (Java) and your situation sounds similar. If your FastAPI web app has filters or middleware that consume the request body data before passing it to bolt’s adapter, you need to avoid using the FastAPI extension along with bolt-python to ensure compatibility with the verification requirements.

In the background tasks, I use the event_context to call apps.event.authorizations.list api endpoint.
I am not sure why this issue is emerging. Does the event_context also expire?

No, it doesn't. Also, this API call is unrelated to the signature verification failure.

Hey @seratch , To my knowledge I dont think there is any filter or middleware making any changes to the raw body.
I believe that to be true because most events that I receive do work fine and the system is able to handle it with the same logic and code.
I have been facing some issues regarding too much CPU usage in my server which I believe could be because of the extra load of requests I may be receiving which starts causing this issue along with receiving some internal_error responses from Slack.
Hence, my confusion.

The request verification logic rejects too old x-slack-request-timestamp (older than 5 minutes ago). Does timestamp:<PHONE_NUMBER> (2024-09-10T07:49:19 UTC) in your log align with the timestamp of loggging? This is the only other cause of the rejection.
With the information given so far, I am unable to guess anything further. Whenever you find anything related to the bolt-python side uncertain, please feel free to ask them.

Yes, that seems likely to be the issue. The log on my server is 2024-09-10 07:55:05 while timestamp:<PHONE_NUMBER> is (2024-09-10T07:49:19 UTC). I believe that may be the issue.
To set some context, my background task collects some information from the body and creates a webclient and then calls apps_event_authorizations_list.
I want to understand a bit better why the request signature verification happens here.
This is the code for passing the message to background tasks:
@app.event("message") def handle_message(ack, body, say, logger, context):     # background_tasks = BackgroundTasks()     background_tasks = context["background_tasks"]     background_tasks.add_task(background_handle_msg, body, logger)     ack()     return
and this is the code for handling the message:

`def background_handle_msg(body, logger):
try:
    if "subtype" in body["event"] and body["event"]["subtype"] not in [
        "message_changed",
        "message_deleted",
        "message_replied",
        "thread_broadcast",
    ]:
        return

    event_context = body["event_context"]
    team_id = body["team_id"]
    ts = body["event"]["ts"]
    channel = body["event"]["channel"]
    channel_type = body["event"]["channel_type"]
    channel_type = channel_types[channel_type]

    current_users = get_current_slack_users(team_id)

    start_ts, end_ts = get_ts_values(ts)
    auth_list = []
    auth_client = create_auth_client()
    resp = auth_client.apps_event_authorizations_list(
        event_context=event_context,
    )

    if resp.get("ok"):
        auth_list = resp.get("authorizations", [])
        while resp.get("response_metadata", {}).get("next_cursor", ""):
            next_cursor = resp.get("response_metadata", {}).get("next_cursor", "")
            resp = auth_client.apps_event_authorizations_list(
                event_context=event_context,
                cursor=next_cursor,
            )

            auth_list = auth_list + resp.get("authorizations", [])
    else:
        logger.error(f"Error in App: Slack Authorization Error-{team_id}")
        logger.error(f"{team_id}, {channel}, {channel_type}")
        return

    if auth_list:
        for auth in auth_list:
            if auth["user_id"] in current_users:
                user_channels = redis_connection.Set(
                    "{}_{}_{}-{}".format(
                        auth["user_id"], channel_type, int(start_ts), int(end_ts)
                    )
                )

                user_channels.add(channel)
                user_channels.expire(2592000)

`
Would really appreciate if you can take a quick look to find any obvious mistakes.
Otherwise, I believe it could be because of the load on the server and I will try to tackle that.
Thank you @seratch

I don't think the request verification is done when "background_handle_msg" is called. The logic runs right after receiving a request. There may be two possible causes:

Your server's system clock is not correct (I don't think this can easily happen for a server that is connected to the internet, but this is the most likely reason).
Using FastAPI's BackgroundTasks this way (your approach is pretty unusual) might cause something wrong even though I don't have any evidence.

By the way, if you're running this app as a long-running process (= not Funciton-as-a-Service platform), you don't need to do such a tricky thing. For the Events API, ack() is immediately done under the hood, and your listener function does not need to worry about 3-second timeouts. Just moving everything from "background_handle_msg" to the main function should work. If you have to enable process_before_response=True for some reason, having async task execution is necessary tho.

Yes, initially the code didn't use background tasks but the load on my server was increasing drastically causing events to be disabled. I wasn't sure if ack was working properly, so I moved it to background tasks.
My current suspicion is that the server load is getting too high which is causing the service to respond late. It is a bit surprising since I haven't had any massive uptick in usage.
I will try out few things and report back if there is any other help I may need.
Please keep the issue open for 2-3 days till then.
Thank you so much for the help @seratch ! I appreciate it.


ci: Overwrite from actions-sync

Need to update the branch protection rule too, let's review tomorrow.


[test] Workaround for NetCDF tests for CDT20.06

Addresses UES-846.

Codecov Report

Merging #1426 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1426   +/-   ##
=======================================
  Coverage   91.83%   91.83%
=======================================
  Files          82       82
  Lines       12786    12786
=======================================
  Hits        11742    11742
  Misses       1044     1044

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53604b...c75cc62. Read the comment docs.


AAD Audit Logs workbook not parsing the Service Principal ID

Describe the bug
https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/AzureActiveDirectoryAuditLogs.json
AAD workbook is parsing only the User Principal name, however there are many cases where changes are being done by a Service Principal ID.
The query is checking if the User Principal is not null, otherwise puts "unknown" for everything else. This is causing the workbook to show "unknown" for most of the cases (example below 126 Update User changes, 118 marked as Unknown)
Expected behavior
Instead of parsing the SP as unknown, the ID should be displayed.
Screenshots

Hi @OvidiuCatalan, thank you for flagging this. Apologies for the delayed response. If you still need assistance, please reply here within 5 business days.

Hi @OvidiuCatalan, Gentle Reminder: We are awaiting for your response on this issue. If you still need to keep this issue active please respond within next 2 days. If we don't receive response by 8 Feb 2023, we will close this issue.

Since we have not received a response in the last 5 days, we are closing your issue #2314 as per our standard operating procedures. If you still need support for this issue, feel free to re-open at any time. Thank you for your co-operation.


Check input_player_*() functions are behaving as expected

https://discord.com/channels/724320164371497020/725060331759730738/1164235161165115423

Remaining results for " _alternate);" appear clean so this is probably OK


docs(readme): add ngx-translate-lint

DOCS(readme): added ngx-translate-lint

Ping @ocombe :)

thanks!


Implemented settings tab for Quiz

Implemented Settings Tab for Quiz Settings
https://github.com/ita-social-projects/SpaceToStudy-Client/assets/108689551/5a220007-0686-4c3f-bdb9-d9c70950f469
#1220

Changes in issue
https://github.com/ita-social-projects/SpaceToStudy-Client/issues/1220


enable_dns_support default

I was confused by this, wondering why I could not curl google.com for example when entering an instance in my VPC. Looking further and I found this:
variable "enable_dns_support" {
  description = "Should be true if you want to use private DNS within the VPC"
  default     = false
}

Should that not be true, and false if you would be using your own authoritative DNS server? The default seems to be x.x.x.2 on the VPC, and when dig google.com I was getting timeouts until setting enable_dns_support = true.

For historical reasons this module has been uplifted from tf_aws_vpc with the goal of keeping backward compatibility, because it is NOT possible to specify not latest version of the module from Terraform registry.
I agree this should be changed and the default value for enable_dns_support should be true, as specified in the official documentation. We can do this when Terraform 0.11+ has a possibility to specify versions.
PS: Thanks for opening an issue!

v1.5.0 is released


marker label apostrophe rendered as html code `

title says it all, marker label apostrophe rendered as html code (`) rather than the actual ' character.

This seems to be an issue with Dynmap (or a Dynmap addon) where non-HTML (markup: false) markers still have HTML-y things in their labels encoded, despite the frontend already treating them as plain text and therefore requiring no encoding. Until this issue is resolved in Dynmap, LiveAtlas now decodes entities in markers with markup: false to fix any occurrences of this it comes across.

yes I did check afterwards and it appeared to be happening in legacy dynamp interface too - sorry I should have checked that before logging the issue but thank you so much for the fast turn around <3


sev-guest-get-report fails with input/output error

I was able to get one report but when trying to get another report, I get this error:
Generating report using the following hash:
<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000
<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000

ioctl: Input/output error
firmware error 29
get_report: Input/output error

I am facing exactly the same issue.

@khushboo-dfn In case you are in a hurry, I tried this tool and it seems to work.

Im facing the same issue


Notifications are missing

Definitions of notifications are missing in the VlanInterface_1.0.0-tsp.190507.1105.
Proposed solution:
Copying the notifications definitions from EthernetContainer_2.0.0-tsp.190430.1635.

Notifications added with the revised VlanInterface


could not find a package configuration file provided by "freenect2"

After  the command
catkin_make -DCMAKE_BUILD_TYPE="Release"
，there was a error:
**CMake Error at iai_kinect2/kinect2_bridge/CMakeLists.txt:22 (find_package):
By not providing "Findfreenect2.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"freenect2", but CMake did not find one.
Could not find a package configuration file provided by "freenect2" with
any of the following names:
freenect2Config.cmake
freenect2-config.cmake**.

I don't know how to fix it. Can anyone help me?

try to install libfreenect2.

I had installed libfreenect2 as the instructions. I used Kinect for windows v1 and the command ./bin/Protonect didn't work. The output message said no device connected.  Nothing else seemed wrong.

And did you do make install in libfreenect2? What path did you installed it to?
BTW: It will only work with Kinect v2.

I  did make install in libfreenect2/depends/build, and /build was a new file created followed the instructions.

Where did make install installed the files to? What is the output on the terminal?

For iai_kinect2, catkin_make -DCMAKE_BUILD_TYPE="Release" -Dfreenect2_DIR=$HOME/freenect2, this is what I have been doing.

Fixed it in fa55624ea7074ad66693582f53defb05ab14564b. {HOME}/freenect2 is now one of the paths where it searches for libfreenect2.

you should install freenect in your XX_ws instead of home, some tutorials are wrong, try another tutorials.


Mention fallback configuration file in documentation.

Changelog: None
The documentation now mentions the existence of the optional
fallback configuration file, along with a brief summary of
how it works. More documentation to come later: See MEN-2177.
Signed-off-by: Don Cross<EMAIL_ADDRESS>

Looks good to me.  @kacf please take a look

:+1:

Thanks, @cosinekitty!


CocoaPods support

Hello.
Thank you for SwiftRadix.
Added CocoaPods support.

This is great, thanks! If you've tested that the pod works, I'm happy to merge this. I don't have a system with cocoapods installed on and it's giving me trouble trying to install right now.

Hello @orchetect
It works on my MacBook.


Make ISR handlers

Write the interrupt service routine handlers.
Resources:

OSDev Wiki
BrokenThorn
Bkerndev
Wikipedia

working on it


After updating to version 1.89 my $HOME path is incorrect. And not able to change it.

Type: Bug
After updating to the version 1.89 of vscode my $HOME path is incorrect everytime for git bash on windows OS, the value should be C:\Users\USERNAME, but it shows, C:\UsersSERNAME kindly help.
 @AshfaqueAlam

For me with version 1.89.1 shell integration changes $HOME from /c/Users/<username> to C:\Users\<username>.
I don't know if the shell default working directory is related to this, but after 1.89 update with shell integration enabled, default working dir is C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code instead of project directory. Without shell integration it defaults to project directory.

I'm seeing similar behavior on 1.89.1:

shellIntegration on

$HOME = C:\Users
Default working directory = C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code

shellIntegration off

$HOME = /c/Users/<user>
Default working directory = project directory

I have a similar problem, not exactly the same, but I found that it happens when shellIntegration-bash.sh is trying to pass a username that begins with a character 't', or 'n'.  In my case my username is 'takka', so when it tries to pass the HOME=C\x3a\Users\takka the \t gets converted to a tab instead and the final result became C:\Users       akka. Which in my case resulting in unable to find a gitconfig path and so on.
My quick fix is to add a check and string replacement after this line https://github.com/microsoft/vscode/blob/f209ce35ef894bd32c12057724e8d1f1139c433f/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh#L53
to
VALUE="$(echo -e "$ITEM" | cut -d "=" -f 2-)"
# Fix bug combination with escape character
if [[ "$VARNAME" == "HOME" ]]; then
	VALUE="$(echo -e "$ITEM" | cut -d "=" -f 2- | sed "s/\t/\/t/g")"
fi

If this is unrelated and should be a new issue or is duplicated then let me know.

I'm seeing similar behavior on 1.89.1:
1. `shellIntegration` on

   * `$HOME` = `C:\Users`
   * Default working directory = `C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code`

     * Edit: This is a display issue because when I `ls`, I see my project files.

2. `shellIntegration` off

   * `$HOME` = `/c/Users/<user>`
   * Default working directory = project directory

One more point:
When shellIntegration is on (default)

Set terminal.integrated.defaultProfile.windows to Git Bash
Every time you create a new Git Bash terminal
Default working directory = C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code
When terminal.integrated.defaultProfile.windows is not Git Bash
Every time you create a new Git Bash terminal
Default working directory = project directory

One more point: When shellIntegration is on (default)

Set terminal.integrated.defaultProfile.windows to Git Bash
Every time you create a new Git Bash terminal
Default working directory = C:/Users/<user>/AppData/Local/Programs/Microsoft VS Code
When terminal.integrated.defaultProfile.windows is not Git Bash
Every time you create a new Git Bash terminal
Default working directory = project directory

I'm seeing this as well

I recently updated to the latest version 1.93.1 a few days ago, and randomly hit this issue today. Removing git bash as my default terminal and closing/opening vs code fixed it. Note I had to close/re-open, doing a reload didn't work.

I had the same issue today after activating a Python virtual environment. Turning off terminal.integrated.shellIntegration.enabled fixed it. I didn't have to close/reopen Code after changing the option.

I had the same issue today after activating a Python virtual environment. Turning off terminal.integrated.shellIntegration.enabled fixed it. I didn't have to close/reopen Code after changing the option.

I had this issue today. This workaround solved it for me.


typo in docker command description

[Enter feedback here]
There is a typo in the tutorial
docker compose up -d
should be
docker-compose up -d

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 65f634bf-2280-a093-5897-724310dafa2d
Version Independent ID: f11c0af7-bfaf-6d64-2c75-9015b0eb1f30
Content: Kubernetes on Azure tutorial  - Prepare an application - Azure Kubernetes Service
Content Source: articles/aks/tutorial-kubernetes-prepare-app.md
Service: azure-kubernetes-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@dragz
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


fix: update to eye v2.7.1

fix: update to eye v2.7.1

:tada: This PR is included in version 2.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v2.9.1

Your semantic-release bot :package::rocket:


No treesitter highlight in preview

No treesitter highligh in preview
As you can see in the following image, both are the exact same function. Left one is in active buffer and right one is in preview popup. The highlight is different because it's the popup is not using Treesitter.

This is because if we set a filetype in the hover window (to trigger tree-sitter), it causes the LSP to crash. A good solution would be to attach a tree-sitter parser to the buffer, so that's is a todo

I found this:
https://github.com/nvim-treesitter/nvim-treesitter/blob/8704b0f3882971a09a9c0e0bc1c95926bc304aea/lua/nvim-treesitter/configs.lua#L69-L73
It's called when you  do :TSBufEnable, I guess you can manually call this without changing filetype and executing a lot of autocmds like lsp

YEII! Didn't notice you updated this, so cool :D


caldb should be able to decipher between different versions of the same calibration file

In the case we reduce a calibration file multiple times (e.g., as pipeline improves), caldb needs to decide between different versions of the same calibration file.
We can choose based on either date creation time (DRPCTIME) or pipeline version (DRPVERSN). Both values are already being tracked in the calibration db. We should decide how we will pick using these two properties.

I think the filename naming is good for hinting/reinforcing to us that it is the right calibration file, but for automated selection, we should really be using header values that populate a database. String parsing is generally more clunky and more bug prone than selecting on database entries.

In addition, we should save the hash of the data to the header and track this as part of the caldb.


Problem with Vimeo Player Editor adaptive mode in Unity with AVPro player (ios)

I am working with streaming video from vimeo to my unity app. I bought the plugin avpro in unity asset store and download the plugin for unity of vimeo. I founded that the plugin works very weel in android with adaptive mode with avpro. But when I switch to ios build the vimeo editor player does not show the dropdown to select avpro media player and neither the adaptive mode. Can anyone help me?

@thiagocoradi were you able to figure out the solution for this issue?


Not Work on Android

Hi ,
IOS it ok  but android is not working
Thanks

Same here, can't make it work on android. I'm using the chrome inspector and the last event I see is 'Received Event: deviceready'.

@maldewar can you be more specific of what is not working, what do you see on screen what you try to do. logcat output.

Yes, looks like the onCompleteCallback for the PayPalMobile.init function is not being called due to these errors...
D/CordovaWebView(11448): CordovaWebView is running on device made by: samsung
D/CordovaActivity(11448): CordovaActivity.createViews()
D/CordovaWebView(11448): >>> loadUrl(file:///android_asset/www/index.html)
D/CordovaWebView(11448): >>> loadUrlNow()
D/CordovaActivity(11448): Resuming the App
D/CordovaWebViewClient(11448): onPageStarted(file:///android_asset/www/index.html)
D/CordovaActivity(11448): onMessage(onPageStarted,file:///android_asset/www/index.html)
D/CordovaLog(11448): file:///android_asset/www/index.html: Line 26 : Viewport target-densitydpi is not supported.
D/CordovaWebViewClient(11448): onPageFinished(file:///android_asset/www/index.html)
D/CordovaActivity(11448): onMessage(onPageFinished,file:///android_asset/www/index.html)
D/CordovaActivity(11448): onMessage(spinner,stop)
D/CordovaLog(11448): file:///android_asset/www/js/index.js: Line 47 : Received Event: deviceready
I/AMMetaDataParserService(28553): Resource data:Loop for running activitycom.mycompany.cordova.myshop.CordovaApp
D/CordovaActivity(11448): onMessage(spinner,stop)
W/System.err(11448): java.lang.ClassNotFoundException: com.paypal.cordova.sdk.PayPalMobileCordovaPlugin
W/System.err(11448): 	at org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:59)
W/System.err(11448): Caused by: java.lang.NoClassDefFoundError: com/paypal/cordova/sdk/PayPalMobileCordovaPlugin
W/System.err(11448): Caused by: java.lang.ClassNotFoundException: Didn't find class "com.paypal.cordova.sdk.PayPalMobileCordovaPlugin" on path: DexPathList[[zip file "/data/app/com.mycompany.cordova.myshop-9.apk"],nativeLibraryDirectories=[/data/app-lib/com.mycompany.cordova.myshop-9, /vendor/lib, /system/lib]]
I/System.out(11448): Error adding plugin com.paypal.cordova.sdk.PayPalMobileCordovaPlugin.
W/System.err(11448): 	at org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:59)

@maldewar i just checkout on the example and it run with no issues on android 5.0.2 Nexus 7 device. I am curios why your app is called activitycom.mycompany.cordova.myshop.CordovaApp rather than activitycom.mycompany.cordova.myshop.CordovaApp?
Also from the log it seems that the plugin hasn't been loaded so i wonder if you have a problem with the setup. can you check that PayPalMobileCordovaPlugin.java exists under MyCordovaShop/platforms/android/src/com/paypal/cordova/sdk and also PayPalAndroidSDK-2.8.3.jar and other *.so files in armeabi-v7a x86 armeabi mips directory are present under MyCordovaShop/platforms/android/libs ?

No PayPalMobileCordovaPlugin.java and no jar.
I had to remove the original android folder that came with the repo (cordova couldn't build the project because the JAVA_HOME wasn't properly set).
Then I added the android platform again.
cordova platform add android

then run the rm/add plugin
cordova plugin rm com.paypal.cordova.mobilesdk
cordova plugin add com.paypal.cordova.mobilesdk

The command reporter the plugin was installed, but no jar nor PayPalMobileCordovaPlugin.java files were created at the referenced paths.
I'm using cordova 4.2.0 too, deploying to a galaxy s5 with android 4.4.2, Android SDK Build-tools 17

@maldewar hmm can you also try to remove both platform and plugin first like this
$cordova platform remove android
$cordova plugin rm com.paypal.cordova.mobilesdk
$cordova plugin add com.paypal.cordova.mobilesdk
$cordova plugin add android
$ls -R platforms/android/libs

you should see a jar file and bunch of .so files

additionally also double check that ls -R platforms/android/src/com/paypal  shows java file. Thanks.

It works now!
The steps above did include all the required files. Additionally, when building the project this time the build tool complained about being too old and requiring at least v19.0.2. I updated the android build tools and now it runs smoothly :D
Thanks romk1n!

@maldewar fantastic! glad we figured it out!

Hello.
I faced the same problem.. I am using phonegap though.
I followed the above batch of commands.. but for the last one i encountered an error:
Cannot find plugin.xml for plugin "android".
Any ideas?


Add more UML diagrams to DG implementation section

Seems like you rewrite some code. Good Job!! But just need to make sure it works
LGTM!!

Yup logically nothing has been changed.


Change tint color on index changing

@spromicky steps to reproduce:

setup a step slider with 5 steps (1, 2, 3, 4, 5)
set the slider to update tint color on UIControlEvent.valueChange based on returned index value
run the app
select index 5, as the change is animating, attempt to drag the circle to a new index
crash observed

Example GIF:

EDIT:
This issue is related to the animation, when i force this to be false (line: 266 of StepSlider.m) the application does not observe this crash
My crashes mainly occur due to a isEqual dead instance EXEC_BAD_INSTRUCTION when the plugin performs its CGColorRef comparisons
Originally posted by @davcpas1234 in https://github.com/spromicky/StepSlider/issues/21#issuecomment-486695828

Will be great to support some kind of heat indicator like in gif.


Add a /metrics endpoint

This is to get base prometheus endpoint for metrics. We can build on top of this to add more metrics.

LGTM

@runcom PTAL

LGTM

I'll wait for Travis and merge


.

Being built with default (PIC) relocation model core and kernel modules are not really functional. In particular string formatting facilities like format_args!() are broken and cause machine to reset. See the corresponded bug in the rust-lang bug tracker.
This is not so important right now, since I have '-C -relocation-model=static' workaround, but in future I'll definitely need to write loadable modules which must be PIC-relocated.

There was no issue since GRUB2 doesn't support loading of PIC-binaries.


Make the threshold of dark/light color modifyable

Currently brightness thresold is calculated by brightness = 0.299 × r + 0.587 × g + 0.114 × b; if brightness > 128, then color is bright; otherwise is it dark.

But it seems, the threshold of dark/light color does not work out for everyone. For me, the contrast here isn't enough, for others it might be. So a better option could be to make a setting to set the brightness threshold of currently 128 in the settings

This feature will be added. Thanks for the suggestion.

with the dark themes, i find the contrast between active and no-active tabs is missing.  Can the contrast be increased by a user selectable slider or similar?  also the same parameters should apply to the STG or Siple Tab Groups add on for consistency and usability.  ty.

with the dark themes, i find the contrast between active and no-active tabs is missing. Can the contrast be increased by a user selectable slider or similar? also the same parameters should apply to the STG or Siple Tab Groups add on for consistency and usability. ty.

@KunjanChauhan  Please create an own issue if it's not related to tis one.

Solved in #29.


Uncaught TypeError: Cannot read property 'push' of undefined

Hi,
I wondering if you could help me with this.
Seems like the error is on line 284 subArrays[self._mainArray[i]._category[p]].push(self._mainArray[i])
I use string of category ex. data-category="Chinse, Single"
Thanks.

I'm experiencing the same issue. Can't seem to work around it, even by not using CSV.

Hello guys, this is probably happening because at the moment data-category is supposed to accept integers as an argument, you can't divide your elements into categories by strings.
You will have to categorise your items as
data-category="1, 2"
where 1 is Chinse and 2 is Single.
I might add string support in a future update.

Tried changing all values to int, such as: data-category="14, 1, 3".
Same issue still occurs. Any pointers?
Uncaught TypeError: Cannot read property 'push' of undefined

You are not skipping any numbers are you? that is you have 14 categories, 1-14?
Because the order you put them in doesn't matter but your available categories shouldn't be for example "1, 2, 3, 14, 28"

Nope. The numbers aren't ordered, but was using 0-21. Just increased the index to see if it would make a difference, no such luck.
I'm using a List, and getting the FindIndex to define the categories. (c#).
I'd love to share you the entire code, but I'm a bit under time pressure right now, so perhaps at a later point.
Here's one of the items though:
`

...

 Do not use indexes 0-21, use 1-21 instead.
I have made it so that the first category must be 1 and increase your indexes from then on!

I tried to change the index, so that it had a +1 in my code, but that didn't solve it - as i mentioned above. So no solution yet I'm afraid.

As long as you are using indexes starting from 1 and onwards (without skipping) I do not see what the cause would be, we could perhaps have a look at your code together when you have time. For many working examples of Filterizr you can also check the source code of its (website)[http://yiotis.net/filterizr]

Thanks, that's very generous. I think I'll start over a little later, see if the problem remains. Otherwise I might take you up on that. :) Have a nice day.

Sure, make sure to keep me posted and if you wish to feature your project on Filterizr's website, I'd be more than glad to do so!

Hi!
I just finished debugging a problem that has been "bugging" me for hours on end (same error as Codeshark-NET mentioned). In the end, the only problem was I didn't include a space after the comma when putting the values for the data-category attribute. Is that something you could mitigate? Or is that something we just have to watch out for and remember?

@daneloctober very nice observation danel, I actually wasn't able to figure out this might have been the problem when we were discussing this issue with @Codeshark-NET. This happens because for multiple categories filterizr parses the integers using string.split using ", " as the delimiter (with a space character).
This could be changed in an upcoming patch by giving the user the ability to override the default delimiter in the options. However, for the time being it is something that is fixed and you will have to look out for it until further notice.

Please make the data-category accept strings and be more flexible with integer input.   It makes setting up for a dynamic cms populated set of content more time consuming to have to handle the data like this with the current restrictions.

data-category="1, 2, 3" in my case not line data-category="1,2,3"
A space causing the problem :laos:

I tried to install filterizr today. I set up the items with the class filtr-item and data-category="1".
I tried $(myselector).filterizr('shuffle'); and got the error:
Uncaught TypeError: Cannot read property 'push' of undefined
at ht.fn.init._makeSubarrays

Hi there,
I am trying out filterizr in an ASP.net application. The data that I would like to sort is being pulled in from an API. Here is how I am setting up my data-category in jQuery:
$("#houseinfo-beds").attr("data-category" + data.House.Bathrooms);
^This is within a ajax success function.
I am getting the following error: Uncaught TypeError: Cannot read property 'split' of undefined
Could this error be because of how I am setting the data-category? The data is supposed to be coming in as integers.
Thank you


synovial joint cavity

Add new term:
abnormal synovial joint cavity morphology ( a child of abnormal synovial joint morphology MP:0030804 )
DEF: any structural anomaly of the minute space enclosed by the synovial membrane and articular cartilages in a synovial joint; it is the site at which the articulating surfaces of the bones contact each other; it contains synovial fluid, a highly viscous, hyaluronic acid–rich fluid that lubricates the joint surfaces
SYN: abnormal articular cavity morphology
SYN: abnormal joint cavity morphology
SYN: abnormal synovial cavity of joint morphology
SYN: abnormal synovial space morphology
SOURCE: https://opentextbc.ca/anatomyandphysiology/chapter/9-4-synovial-joints/, ISBN:978-0-323-07954-9, https://books.google.com/books?isbn=0803647204

Added new term:
abnormal synovial joint cavity morphology MP:0030865


Disable color when output to file using --out / allow --color to be a per-formatter option like --out

Summary
It seems like the default behavior should be for formatters that are output to the screen to have color enabled by default, and formatters that are directed to files to have no color by default, so that you can open them in an editor and not see gobbledeygook.
The default should be overridable, however, in case you really did want to view the saved output on a terminal later (perhaps with less -R).
Current Behavior
lib/cucumber/formatter/ansicolor.rb only disables color if you redirect stdout, as in cucumber > file:
Cucumber::Term::ANSIColor.coloring = false if !STDOUT.tty?

However, it doesn't provide any way to disable color for when directing a specific formatter to a
file with:
  --format #{format} --out #{file}

Expected Behavior
1. Default behavior
Formatters that are output to the screen (@io.tty?) should have color enabled by default
Formatters that are directed to files (@io.is_a?(File)) to have no color by default.
The help says it is based on the output destination but that is not true when using --out.
    -c, --[no-]color                 Whether or not to use ANSI color in the output. Cucumber decides
                                     based on your platform and the output destination if not specified.

2. Ability to enable/disable color on a per-formatter basis (like --out)
It would be nice if you could disable color on a per-formatter basis, like how you can direct to a
different output on a per-formatter basis.
    -o, --out [FILE|DIR]             Write output to a file/directory instead of STDOUT. This option
                                     applies to the previously specified --format,

Maybe something like this:
  --format format1 --no-color --out file --format format2 --color

but since --color/--no-color is a global state, the last flag changes it for all formatters.
So the best you can do with --no-color is turn off color for all formatters, including the one
being output to a tty STDOUT.
Possible Solution
One solution/workaround would be to strip out color in format_string:
module Cucumber
  module Formatter
    module Console
      def format_string(o, status)
        fmt = format_for(status)
        o.to_s.split("\n").map do |line|
          if @io.is_a?(File)
            line.gsub(Cucumber::Term::ANSIColor::COLORED_REGEXP, '')
          else
            if Proc === fmt
              fmt.call(line)
            else
              fmt % line
            end
          end
        end.join("\n")
      end
    end
  end
end

That seems to work for me, striping out all color except the summary at the bottom. Probably not the best solution, though.
Probably should move Cucumber::Term::ANSIColor.coloring? so that it's an instance method instead of a class method...
Steps to Reproduce (for bugs)

cucumber --format pretty --out pretty.txt --format progress features/
Observe that stdout has color (as desired).
Observe that pretty.txt contains unwanted color codes.

Your Environment

cucumber-3.1.0
cucumber-rails-1.5.0

I like this idea. WDYT @mattwynne?

Hello @danascheider long time no see!
Yes, this seems like a good idea to me.

I know! Life's been crazy. I might pick this up when I'm done with the other one I'm working on but don't want to leave a bunch of half-finished PR's lying around!

Hey, just noticed I said I'd pick this up when things calmed down. I'm taking a look at it now!

I began a PR for this #1364

Hi, looking to work on this issue. Trying to reproduce the issue in my local, but seeing this error:

Is this expected? If not, can someone help me out with where it's all going wrong? Thanks.

Hi @CrossCascade013 can you confirm you're still getting this bug / issue?
Either in v8 or v9.0.1?
I'm releasing quite a bit of patches / refactors atm so if something is broken I'd rather fix that first.


Add pre-terminal roles

Pull Request Test Coverage Report for Build 82

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 81:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


added update-if-older-than option

This option will skip files where the latest version is have been updated since the date provided on the command line.
For example this could be used to update only if the last commit for a file is newer than the latest version in confluence:
mark --space "****" -f $file -u "${MARK_USER}" -p "${MARK_PWD}" -b "${MARK_URL}" --ci --update-if-older-than "$(git --no-pager log -1 --pretty="format:%cI" $file)"

I think it would also be nice if we could record your snipped "$(git --no-pager log -1 --pretty="format:%cI" $file) somewhere in the readme :)

One question/caveat:
If my doc is older and it has a reference to another markdown file which changes the title in a later changeset, there will be an inconsistency I guess.

@danapsimer ping, do you have any interest in continuing on this change?


NPE

null value returned from native call not assignable to Object
ceylon.language.AssertionError "null value returned from native call not assignable to Object"
	at com.redhat.ceylon.compiler.java.Util.checkNull(Util.java:985)
	at com.redhat.ceylon.ide.common.completion.InvocationCompletion$impl.addSecondLevelProposal(InvocationCompletion.ceylon:215)
	at com.redhat.ceylon.ide.common.completion.completionManager_.addSecondLevelProposal(IdeCompletionManager.ceylon)
	at com.redhat.ceylon.ide.common.completion.completionManager_.constructCompletions$priv$(IdeCompletionManager.ceylon:947)
	at com.redhat.ceylon.ide.common.completion.completionManager_.getContentProposals$canonical$(IdeCompletionManager.ceylon:279)
	at com.redhat.ceylon.ide.common.completion.completionManager_.getContentProposals(IdeCompletionManager.ceylon:108)
	at org.intellij.plugins.ceylon.ide.ceylonCode.completion.IdeaCompletionProvider.addCompletionsInternal$priv$(ideaCompletionManager.ceylon:163)
	at org.intellij.plugins.ceylon.ide.ceylonCode.completion.IdeaCompletionProvider.access$000(ideaCompletionManager.ceylon:59)
	at org.intellij.plugins.ceylon.ide.ceylonCode.completion.IdeaCompletionProvider$1.$call$(ideaCompletionManager.ceylon:127)
	at org.intellij.plugins.ceylon.ide.ceylonCode.model.concurrencyManager_.withIndexStrategy$priv$(concurrencyManager.ceylon:192)
	at org.intellij.plugins.ceylon.ide.ceylonCode.model.concurrencyManager_.withAlternateResolution(concurrencyManager.ceylon:204)
	at org.intellij.plugins.ceylon.ide.ceylonCode.completion.IdeaCompletionProvider.addCompletions(ideaCompletionManager.ceylon:116)
	at com.intellij.codeInsight.completion.CompletionProvider.addCompletionVariants(CompletionProvider.java:36)
	at com.intellij.codeInsight.completion.CompletionContributor.fillCompletionVariants(CompletionContributor.java:155)
	at com.intellij.codeInsight.completion.CompletionService.getVariantsFromContributors(CompletionService.java:81)
	at com.intellij.codeInsight.completion.CompletionResultSet.runRemainingContributors(CompletionResultSet.java:135)
	at com.intellij.codeInsight.completion.CompletionResultSet.runRemainingContributors(CompletionResultSet.java:128)
	at com.intellij.codeInsight.template.impl.LiveTemplateCompletionContributor$2.addCompletions(LiveTemplateCompletionContributor.java:90)
	at com.intellij.codeInsight.completion.CompletionProvider.addCompletionVariants(CompletionProvider.java:36)
	at com.intellij.codeInsight.completion.CompletionContributor.fillCompletionVariants(CompletionContributor.java:155)
	at com.intellij.codeInsight.completion.CompletionService.getVariantsFromContributors(CompletionService.java:81)
	at com.intellij.codeInsight.completion.CompletionService.performCompletion(CompletionService.java:110)
	at com.intellij.codeInsight.completion.CompletionProgressIndicator.calculateItems(CompletionProgressIndicator.java:817)
	at com.intellij.codeInsight.completion.CompletionProgressIndicator.access$1000(CompletionProgressIndicator.java:88)
	at com.intellij.codeInsight.completion.CompletionProgressIndicator$1CalculateItems.run(CompletionProgressIndicator.java:799)
	at com.intellij.codeInsight.completion.AsyncCompletion$1$1$1.run(CompletionThreading.java:94)
	at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:950)
	at com.intellij.codeInsight.completion.AsyncCompletion$1$1.run(CompletionThreading.java:89)
	at com.intellij.openapi.progress.impl.CoreProgressManager$2.run(CoreProgressManager.java:142)
	at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:446)
	at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:392)
	at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:54)
	at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:127)
	at com.intellij.codeInsight.completion.AsyncCompletion$1.run(CompletionThreading.java:85)
	at com.intellij.openapi.application.impl.ApplicationImpl$8.run(ApplicationImpl.java:369)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Seriously? How could td.members be null??

no, it's probably one of the iterated members that is null

I prepared a proposed fix by explicitly adding Declaration? in the for loop, and checking for existence inside the loop.

no, it's probably one of the iterated members that is null

Well that should never happen. That would mean a bug in the model loader.

I prepared a proposed fix by explicitly adding Declaration? in the for loop, and checking for existence inside the loop.

Well no, that's the crap way to fix it. Please don't do it that way. Much better to fix the underlying cause.

well, it was when starting a word and having syntax errors, which made me think of an incomplete model, but not necessarily of a model loader problem.
But OK, I'll revert my commit if you prefer.

Well nothing should ever call addMember(null), and anything that does is going to cause lots of other npes.

I haven't been able to reproduce it, I'll leave a conditional breakpoint in ClassOrInterface#addMember, in case it ever happens again. For now, I'm closing the issue as "can't reproduce".


docs: Pod examples

A little instruction with examples to how run a VM with
virtlet.

This change is

Small nits - python2 and please change ip r to ip route (we should not use aliases in examples).

done

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable


Missing instruction to set ManagePackageVersionsCentrally=true?

I followed the instructions under "Enabling Central Package Management" but that did not seem to enable this feature (running VS2022 Preview 6). It wasn't until I added the following in my Directory.Packages.props file that central package management seemed to activate:

true

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d000f01-60a3-59c2-e06d-c02c8721fa76
Version Independent ID: 2d000f01-60a3-59c2-e06d-c02c8721fa76
Content: Central Package Management
Content Source: docs/consume-packages/Central-Package-Management.md
Product: nuget
GitHub Login: @JonDouglas
Microsoft Alias: jodou

Latest one shows this as fixed.

To get started with central package management, you must create a Directory.Packages.props file at the root of your repository and set the MSBuild property ManagePackageVersionsCentrally to true.


Quotations - adding text

Each of our quotations should have the line 'this offer only stands for 3 months" or Dutch "deze offerte is slechts 3 maand geldig".
This is crucial. If our prices change we can say that the offer was only valid until xxx and the new prices are in order. If not we can not say this.

In case of a quotation, rename the word "Order" (NL: Bestelling) to "Quotation" (NL: Offerte) and add the text that Maureen has mentioned.

Quotations are new in the shop, you can find a test example in the quotations tab for customer<EMAIL_ADDRESS>We built this feature such that price lists that are sent to a customer are stored in the shop as well.


[rv_core_ibex] Re-venor Ibex

This will fix #20788

This looks sensible to me. Other people might notice the line count diff as I did. But it's not as dramatic as it looks.

The are some small RTL changes
There are some UVM changes in dv/uvm/core_ibex
There's a whopping load of code that we "double vendor" from riscv-dv, which has changed.

I don't know why we have this ugly nested vendoring structure, but I just looked and it's due to me back in April 2022(!) Long term, maybe we can get rid of the silliness, but it's definitely not a problem for this PR.

This supersedes #20850 and is thus also takes care of #20715. I was thinking to also include another RTL improvement for the lockstep comparison enable (see #20779) but fixing this inside Ibex related in some tooling challenges. We'll thus do another vendor PR to get the lockstep comparison enable improvement.

Hm, most likely this PR also misses an update to the hw/ip/rv_core_ibex/lint/rv_core_ibex.waiver file. I'll include the fix in this PR.

Thanks for pushing this through, @vogelpi!


Feature: (1) list virtual preview files and (2) eject virtual files on request

#1332 & #1335
@sap-ux/preview-middleware
Exposes two new APIs:

export type PreviewUrls = {
    path: string;
    type: 'preview' | 'editor' | 'test';
};

/**
 * Returns the preview paths.
 *
 * @param config configuration from the ui5.yaml
 * @param logger logger instance
 * @returns an array of preview paths
 */
export function getPreviewPaths(config: MiddlewareConfig, logger: ToolsLogger = new ToolsLogger()): PreviewUrls[];

/**
 * Generates the preview files.
 *
 * @param basePath path to the application root
 * @param config configuration from the ui5.yaml
 * @param fs file system editor
 * @param logger logger instance
 * @returns a mem-fs editor with the preview files
 */
export async function generatePreviewFiles(
    basePath: string,
    config: MiddlewareConfig,
    fs?: Editor,
    logger: ToolsLogger = new ToolsLogger()
)

@sap-ux/create

offers new command sap-ux add html adding html files based on the preview middleware configuration to the file system.
also fixed the validateBasePath function to consider projects with a different folder than webapp being configured as source folder

Code review done, all (potentially critical) comments had been addressed


Add region tags

Add a couple of region tags for the Firebase public docs to reference.

Hmm check / check (pull_request) is failing with
Run scripts/style.sh test-only
authentication/LegacyAuthQuickstart/AuthenticationExampleSwift/MainViewController.swift needs formatting.
Proposed commit is not style compliant.
Run scripts/style.sh and git add the result.
Error: Process completed with exit code 1.

However, when I run scripts/style.sh nothing happens. I don't see anything obviously styled incorrectly in the MainViewController.swift either.

@rosalyntan Perhaps turn on set -x to see what is happening when you run style?  And/or merge #1249.
Any reason for adding the new tags to the Legacy quickstart?  Shouldn't the primary quickstart be updated with them?

Thanks! Merged #1249 into this PR.

Any reason for adding the new tags to the Legacy quickstart? Shouldn't the primary quickstart be updated with them

I added the region tags to the legacy quickstart because all the existing auth references in the snippet registry reference the legacy quickstart: https://source.corp.google.com/piper///depot/google3/googledata/devsite/_common/en/snippet_registry.yaml;l=2653-2873

Do the snippets in google3 need to be migrated?

Not sure, I figured the auth snippets were using the legacy quickstart for a reason (and it looks like analytics and remote config snippets do the same).