Issue in implementing Windows Example

Hello Maintainers,
I have tried to use packer for Windows machine and i did my best but i'm stocked by the an error when running packer with the following file:
source "osc-bsu" "windows" {
communicator = "winrm"
disable_stop_vm = true
source_omi = "ami-3e5dc2a7"
omi_name = "WINDOWS-SERVER-2019_{{timestamp}}"
ssh_interface = "public_ip"
user_data_file = "scripts/windows/userdata"
vm_type = "tinav4.c4r4p1"
winrm_insecure = true
winrm_use_ssl = true
winrm_username = "Administrator"
}
build {
sources = [ "source.osc-bsu.windows" ]
provisioner "windows-restart" {}
provisioner "powershell" {
    inline = [
        "Remove-Item -Recurse -Force C:\\Windows\\Outscale\\",
        "Remove-Item -Recurse -Force 'C:\\Users\\Administrator\\AppData\\Roaming\\Microsoft\\Windows\\Start Menu\\Programs\\Startup\\SetupComplete.cmd'",
        "Remove-Item -Recurse -Force 'C:\\Users\\Default\\AppData\\Roaming\\Microsoft\\Windows\\Start Menu\\Programs\\Startup\\SetupComplete.cmd'"
    ]
}
provisioner "file" {
    destination = "C:\\Windows\\Outscale\\"
    source = "files/windows/"
}
provisioner "powershell" {
    scripts = [ "scripts/windows/sysprep.ps1" ]
}

}
I got the following errors.
otirat@b2-7-gra3:~/packer/windows/omi-packer$ packer build windows.pkr.hcl
osc-bsu.windows: output will be in this color.
==> osc-bsu.windows: Prevalidating OMI Name: WINDOWS-SERVER-2019_1640089608
==> osc-bsu.windows: Error querying OMI: Post "https://api..outscale.com/oapi/latest/ReadImages": dial tcp: lookup api..outscale.com: no such host
Build 'osc-bsu.windows' errored after 2 milliseconds 652 microseconds: Error querying OMI: Post "https://api..outscale.com/oapi/latest/ReadImages": dial tcp: lookup api..outscale.com: no such host
==> Wait completed after 2 milliseconds 682 microseconds
==> Some builds didn't complete successfully and had errors:
--> osc-bsu.windows: Error querying OMI: Post "https://api..outscale.com/oapi/latest/ReadImages": dial tcp: lookup api..outscale.com: no such host
==> Builds finished but no artifacts were created.
I suppose this comes from an URL issues but you are the experts... I hope it will help..
Sincerely Yours
Olivier TIRAT

Hello,
It looks like you forgot to set your region.
Please set OUTSCALE_REGION environment variable accordingly (eg. eu-west-2).

Thank you very much ... It appears i add the region and it is working ......
@.:~/packer/windows/omi-packer$ export -p
OUTSCALE_REGION=eu-west-2
@.:~/packer/windows/omi-packer$ packer build windows.pkr.hcl
osc-bsu.windows: output will be in this color.
==> osc-bsu.windows: Prevalidating OMI Name: WINDOWS-SERVER-2019_1640095136
    osc-bsu.windows: Found Image ID: ami-3e5dc2a7
==> osc-bsu.windows: Creating temporary keypair:
packer_61c1dda0-2b4d-a2bd-a716-f2f08ee89131
==> osc-bsu.windows: Creating temporary security group for this
instance: packer_osc_61c1dda1-bda8-7c6c-1601-c3b7f6d1ccfc
==> osc-bsu.windows: Authorizing access to port 5986 from <IP_ADDRESS>/0 in
the temporary security group...
==> osc-bsu.windows: Launching a source OUTSCALE vm...
==> osc-bsu.windows: Adding tags to source vm
    osc-bsu.windows: Vm ID: i-82f8e919
==> osc-bsu.windows: Waiting for vm (i-82f8e919) to become ready...
    osc-bsu.windows: Adding tag: "Name": "Packer Builder"
==> osc-bsu.windows: Waiting for auto-generated password for vm...
    osc-bsu.windows: It is normal for this process to take up to 15
minutes,
    osc-bsu.windows: but it usually takes around 5. Please wait.
.......
To be continued ... Thanks again ;)
Le 21/12/2021 à 13:30, Romain Lecat a écrit :

Hello,
It looks like you forgot to set your region.
Please set OUTSCALE_REGION environment variable accordingly (eg.
eu-west-2).
—
Reply to this email directly, view it on GitHub
https://github.com/outscale/omi-packer/issues/3#issuecomment-998740147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3R5F4SIIJLNVADKE34YXDUSBXNFANCNFSM5KQBWBOQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Glad to hear that. I'm closing this issue then, feel free to reopen one if you encounter other issues.

It would be interesting to change the error of outscale packer software when there is some missing input information such as the region. It would probably lower the amount of stupid customer asking for support
;-) such as myself.
Olivier TIRAT

Thanks for the feedback!
I opened an issue about that in Outscale provider: https://github.com/outscale/packer-plugin-outscale/issues/54


Permit joins with all references filtered out

When a filter is present in the join operation, it could happen that all joined references are filtered out (although the reference attribute is present in the queried object). This will generate critical errors like Missing join result for member.
This change will make it possible to process objects where all references are filtered out whe the attribute is added to allow_missing_attributes.
Example to show the behavior:
- ldap:
    base: cn=team0,ou=groups,dc=ldap,dc=ldap2pg,dc=docker
    allow_missing_attributes: []
    joins:
      member:
        scope: base
        filter: (objectClass=groupOfNames)
  role:
    name: '{member.mail}'
    options: NOLOGIN
    parent:
    - '{cn}'

Result:
[ldap2pg.manager       INFO] Querying LDAP cn=team0,ou=groups,dc=ld... (objectClass...
[ldap2pg.ldap         DEBUG] Doing: ldapsearch -x -D cn=admin,dc=ldap,dc=ldap2pg,dc=docker -W -b cn=team0,ou=groups,dc=ldap,dc=ldap2pg,dc=docker -s sub '(objectClass=*)' member cn
[ldap2pg.manager      DEBUG] Got 1 entries from LDAP.
[ldap2pg.manager       INFO] Sub-querying LDAP cn=daniel,ou=people,dc=l...
[ldap2pg.ldap         DEBUG] Doing: ldapsearch -x -D cn=admin,dc=ldap,dc=ldap2pg,dc=docker -W -b cn=daniel,ou=people,dc=ldap,dc=ldap2pg,dc=docker -s base '(objectClass=groupOfNames)' mail
[ldap2pg.manager      DEBUG] Got 0 entries from LDAP.
[ldap2pg.manager       INFO] Sub-querying LDAP cn=david,ou=people,dc=ld...
[ldap2pg.ldap         DEBUG] Doing: ldapsearch -x -D cn=admin,dc=ldap,dc=ldap2pg,dc=docker -W -b cn=david,ou=people,dc=ldap,dc=ldap2pg,dc=docker -s base '(objectClass=groupOfNames)' mail
[ldap2pg.manager      DEBUG] Got 0 entries from LDAP.
[ldap2pg.manager       INFO] Sub-querying LDAP cn=didier,ou=people,dc=l...
[ldap2pg.ldap         DEBUG] Doing: ldapsearch -x -D cn=admin,dc=ldap,dc=ldap2pg,dc=docker -W -b cn=didier,ou=people,dc=ldap,dc=ldap2pg,dc=docker -s base '(objectClass=groupOfNames)' mail
[ldap2pg.manager      DEBUG] Got 0 entries from LDAP.
[ldap2pg.manager       INFO] Sub-querying LDAP cn=dorothée,ou=people,dc...
[ldap2pg.ldap         DEBUG] Doing: ldapsearch -x -D cn=admin,dc=ldap,dc=ldap2pg,dc=docker -W -b cn=dorothée,ou=people,dc=ldap,dc=ldap2pg,dc=docker -s base '(objectClass=groupOfNames)' mail
[ldap2pg.manager      DEBUG] Got 0 entries from LDAP.
[ldap2pg.script       CRITI] Missing join result for member.

Codecov Report

Merging #341 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   99.68%   99.68%
=======================================
  Files          12       12
  Lines        1914     1914
=======================================
  Hits         1908     1908
  Misses          6        6

Impacted Files
Coverage Δ

ldap2pg/manager.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656af8f...4fa1dc9. Read the comment docs.


Optimise multi-label quantification on rvalues

The quantify(const bdd&, const label_file&) functions are good for when the argument is an lvalue and should be kept. But if the value is the result of some other computation (i.e. is an rvalue), then we can optimise the garbage collection a bit, by accumulating onto the input bdd rather than the new variable out.

It seems it is a bit more complicated, than I thought. What we would like to do to keep code duplication down is the following
__bdd quantify(const bdd &in_bdd, const label_file &labels, bool_op &op) { ... }
__bdd quantify(bdd &&in_bdd, const label_file &labels, bool_op &op) { ... }

// ...

__bdd bdd_exists(const bdd &in_bdd, const label_file &labels) { return quantify(in_bdd, labels, or_op) }
__bdd bdd_exists(bdd &&in_bdd, const label_file &labels) { return quantify(in_bdd, labels, or_op) }

The problem is, that the recursive call to return quantify(in_bdd, labels, or_op) will create a new scope, which in turn will call the const bdd &in_bdd function. I assume it is because the compiler does not realize, that in_bdd is otherwise unused. A direct inline does not do the trick, so one probably has to get real nasty with a macro...


[HOLD #11768][$1000]  First name, last name not pre-filled on Profile page after login while trying to open that deeplink url reported by @0xmiroslav

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Logout if already logged in
Visit https://new.expensify.com/settings/profile
Login with any account

Expected Result:
Profile page shows with first name, last name pre-filled
Actual Result:
Profile page shows but first name, last name not populated
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.27-3
Reproducible in staging?: y
**Reproducible in production?:**y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
The issue occurs in Preferred pronouns , timezone settings as well
https://user-images.githubusercontent.com/43996225/201744850-a8b00d49-c610-4bcf-8957-70e0e3b23973.mov
https://user-images.githubusercontent.com/43996225/201744874-ccef2a16-0198-4d9e-8fbc-dc63af0f7e8b.mp4
Expensify/Expensify Issue URL:
Issue reported by: @0xmiroslav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668428285770109
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0186654c60152a5d3d
Upwork Job ID:<PHONE_NUMBER>247063552

Re-applied the bug label, as Matt is OOO.

Proposal
This is known issue with the TextInput's defaultValue prop, that the defaultValue will not update when the props changed. When we already logged in then navigate to ProfilePage, we already had the user personal detail information needed for the TextInput. But when we redirect it right after logged in like in this issue, it will take some time to load the current user personal detail, that's why even after personal detail information is loaded, we still can't see the defaultValue for TextInput.

Solution
Create a loading indicator while waiting for user personal detail's loaded, so the loading indicator only show if the user personal data's empty.
From 1fa331af3d1a8f30a1d54681ea7ad55adbfdf6ea Mon Sep 17 00:00:00 2001
From: Hans<EMAIL_ADDRESS>Date: Wed, 16 Nov 2022 14:45:31 +0700
Subject: [PATCH] fix first name, last name not loaded

---
 src/pages/settings/Profile/ProfilePage.js | 175 +++++++++++-----------
 1 file changed, 89 insertions(+), 86 deletions(-)

diff --git a/src/pages/settings/Profile/ProfilePage.js b/src/pages/settings/Profile/ProfilePage.js
index 84cc1db5d..207e6fdb7 100755
--- a/src/pages/settings/Profile/ProfilePage.js
+++ b/src/pages/settings/Profile/ProfilePage.js
@@ -29,6 +29,7 @@ import * as ReportUtils from '../../../libs/ReportUtils';
 import Form from '../../../components/Form';
 import OfflineWithFeedback from '../../../components/OfflineWithFeedback';
 import * as LoginUtils from '../../../libs/LoginUtils';
+import FullScreenLoadingIndicator from '../../../components/FullscreenLoadingIndicator';

 const loginPropTypes = PropTypes.shape({
     /** Value of partner name */
@@ -239,66 +240,67 @@ class ProfilePage extends Component {
                     onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS)}
                     onCloseButtonPress={() => Navigation.dismissModal(true)}
                 />
-                <Form
-                    style={[styles.flexGrow1, styles.ph5]}
-                    formID={ONYXKEYS.FORMS.PROFILE_SETTINGS_FORM}
-                    validate={this.validate}
-                    onSubmit={this.updatePersonalDetails}
-                    submitButtonText={this.props.translate('common.save')}
-                    enabledWhenOffline
-                >
-                    <OfflineWithFeedback
-                        pendingAction={lodashGet(this.props.currentUserPersonalDetails, 'pendingFields.avatar', null)}
-                        errors={lodashGet(this.props.currentUserPersonalDetails, 'errorFields.avatar', null)}
-                        errorRowStyles={[styles.mt6]}
-                        onClose={PersonalDetails.clearAvatarErrors}
+                {_.isEmpty(currentUserDetails) ? <FullScreenLoadingIndicator style={[styles.flex1, styles.pRelative]} /> : (
+                    <Form
+                        style={[styles.flexGrow1, styles.ph5]}
+                        formID={ONYXKEYS.FORMS.PROFILE_SETTINGS_FORM}
+                        validate={this.validate}
+                        onSubmit={this.updatePersonalDetails}
+                        submitButtonText={this.props.translate('common.save')}
+                        enabledWhenOffline
                     >
-                        <AvatarWithImagePicker
-                            isUsingDefaultAvatar={lodashGet(currentUserDetails, 'avatar', '').includes('/images/avatars/avatar')}
-                            avatarURL={currentUserDetails.avatar}
-                            onImageSelected={PersonalDetails.updateAvatar}
-                            onImageRemoved={PersonalDetails.deleteAvatar}
-                            anchorPosition={styles.createMenuPositionProfile}
-                            size={CONST.AVATAR_SIZE.LARGE}
-                        />
-                    </OfflineWithFeedback>
-                    <Text style={[styles.mt6, styles.mb6]}>
-                        {this.props.translate('profilePage.tellUsAboutYourself')}
-                    </Text>
-
-                    <View style={[styles.flexRow, styles.mt4, styles.mb4]}>
-                        <View style={styles.flex1}>
-                            <TextInput
-                                inputID="firstName"
-                                name="fname"
-                                label={this.props.translate('common.firstName')}
-                                defaultValue={lodashGet(currentUserDetails, 'firstName', '')}
-                                placeholder={this.props.translate('profilePage.john')}
+                        <OfflineWithFeedback
+                            pendingAction={lodashGet(this.props.currentUserPersonalDetails, 'pendingFields.avatar', null)}
+                            errors={lodashGet(this.props.currentUserPersonalDetails, 'errorFields.avatar', null)}
+                            errorRowStyles={[styles.mt6]}
+                            onClose={PersonalDetails.clearAvatarErrors}
+                        >
+                            <AvatarWithImagePicker
+                                isUsingDefaultAvatar={lodashGet(currentUserDetails, 'avatar', '').includes('/images/avatars/avatar')}
+                                avatarURL={currentUserDetails.avatar}
+                                onImageSelected={PersonalDetails.updateAvatar}
+                                onImageRemoved={PersonalDetails.deleteAvatar}
+                                anchorPosition={styles.createMenuPositionProfile}
+                                size={CONST.AVATAR_SIZE.LARGE}
                             />
+                        </OfflineWithFeedback>
+                        <Text style={[styles.mt6, styles.mb6]}>
+                            {this.props.translate('profilePage.tellUsAboutYourself')}
+                        </Text>
+
+                        <View style={[styles.flexRow, styles.mt4, styles.mb4]}>
+                            <View style={styles.flex1}>
+                                <TextInput
+                                    inputID="firstName"
+                                    name="fname"
+                                    label={this.props.translate('common.firstName')}
+                                    defaultValue={lodashGet(currentUserDetails, 'firstName', '')}
+                                    placeholder={this.props.translate('profilePage.john')}
+                                />
+                            </View>
+                            <View style={[styles.flex1, styles.ml2]}>
+                                <TextInput
+                                    inputID="lastName"
+                                    name="lname"
+                                    label={this.props.translate('common.lastName')}
+                                    defaultValue={lodashGet(currentUserDetails, 'lastName', '')}
+                                    placeholder={this.props.translate('profilePage.doe')}
+                                />
+                            </View>
                         </View>
-                        <View style={[styles.flex1, styles.ml2]}>
-                            <TextInput
-                                inputID="lastName"
-                                name="lname"
-                                label={this.props.translate('common.lastName')}
-                                defaultValue={lodashGet(currentUserDetails, 'lastName', '')}
-                                placeholder={this.props.translate('profilePage.doe')}
+                        <View style={styles.mb6}>
+                            <Picker
+                                inputID="pronouns"
+                                label={this.props.translate('profilePage.preferredPronouns')}
+                                items={pronounsList}
+                                placeholder={{
+                                    value: '',
+                                    label: this.props.translate('profilePage.selectYourPronouns'),
+                                }}
+                                defaultValue={pronounsPickerValue}
+                                onValueChange={this.setPronouns}
                             />
-                        </View>
-                    </View>
-                    <View style={styles.mb6}>
-                        <Picker
-                            inputID="pronouns"
-                            label={this.props.translate('profilePage.preferredPronouns')}
-                            items={pronounsList}
-                            placeholder={{
-                                value: '',
-                                label: this.props.translate('profilePage.selectYourPronouns'),
-                            }}
-                            defaultValue={pronounsPickerValue}
-                            onValueChange={this.setPronouns}
-                        />
-                        {this.state.hasSelfSelectedPronouns && (
+                            {this.state.hasSelfSelectedPronouns && (
                             <View style={styles.mt2}>
                                 <TextInput
                                     inputID="selfSelectedPronoun"
@@ -306,37 +308,38 @@ class ProfilePage extends Component {
                                     placeholder={this.props.translate('profilePage.selfSelectYourPronoun')}
                                 />
                             </View>
-                        )}
-                    </View>
-                    <LoginField
-                        label={this.props.translate('profilePage.emailAddress')}
-                        type="email"
-                        login={this.state.logins.email}
-                        defaultValue={this.state.logins.email}
-                    />
-                    <LoginField
-                        label={this.props.translate('common.phoneNumber')}
-                        type="phone"
-                        login={this.state.logins.phone}
-                        defaultValue={this.state.logins.phone}
-                    />
-                    <View style={styles.mb3}>
-                        <Picker
-                            inputID="timezone"
-                            label={this.props.translate('profilePage.timezone')}
-                            items={timezones}
-                            isDisabled={this.state.isAutomaticTimezone}
-                            value={this.state.selectedTimezone}
-                            onValueChange={selectedTimezone => this.setState({selectedTimezone})}
+                            )}
+                        </View>
+                        <LoginField
+                            label={this.props.translate('profilePage.emailAddress')}
+                            type="email"
+                            login={this.state.logins.email}
+                            defaultValue={this.state.logins.email}
+                        />
+                        <LoginField
+                            label={this.props.translate('common.phoneNumber')}
+                            type="phone"
+                            login={this.state.logins.phone}
+                            defaultValue={this.state.logins.phone}
+                        />
+                        <View style={styles.mb3}>
+                            <Picker
+                                inputID="timezone"
+                                label={this.props.translate('profilePage.timezone')}
+                                items={timezones}
+                                isDisabled={this.state.isAutomaticTimezone}
+                                value={this.state.selectedTimezone}
+                                onValueChange={selectedTimezone => this.setState({selectedTimezone})}
+                            />
+                        </View>
+                        <CheckboxWithLabel
+                            inputID="isAutomaticTimezone"
+                            label={this.props.translate('profilePage.setMyTimezoneAutomatically')}
+                            defaultValue={this.state.isAutomaticTimezone}
+                            onValueChange={this.setAutomaticTimezone}
                         />
-                    </View>
-                    <CheckboxWithLabel
-                        inputID="isAutomaticTimezone"
-                        label={this.props.translate('profilePage.setMyTimezoneAutomatically')}
-                        defaultValue={this.state.isAutomaticTimezone}
-                        onValueChange={this.setAutomaticTimezone}
-                    />
-                </Form>
+                    </Form>
+                )}
             </ScreenWrapper>
         );
     }
--
2.31.0

And the result:
https://user-images.githubusercontent.com/16502320/202118916-22174975-d95c-47c9-8f5f-bdd22586b693.mov

@sonialiap Are you on Bug Zero? You need to make sure you keep yourself assigned to the issue.

@hungvu193 Your proposal is on the right track, but seems to rely on currentUserPersonalDetails always having a value.  But what if it is empty / new user?

Proposal
diff --git a/src/pages/settings/Profile/DisplayNamePage.js b/src/pages/settings/Profile/DisplayNamePage.js
index cb4ebaaea..c2d8fbb75 100644
--- a/src/pages/settings/Profile/DisplayNamePage.js
+++ b/src/pages/settings/Profile/DisplayNamePage.js
@@ -90,6 +90,7 @@ class DisplayNamePage extends Component {
                     validate={this.validate}
                     onSubmit={this.updateDisplayName}
                     submitButtonText={this.props.translate('common.save')}
+                    key={Object.keys(currentUserDetails).length.toString()}
                     enabledWhenOffline
                 >
                     <Text style={[styles.mb6]}>
diff --git a/src/pages/settings/Profile/ProfilePage.js b/src/pages/settings/Profile/ProfilePage.js
index 84cc1db5d..e543481d6 100755
--- a/src/pages/settings/Profile/ProfilePage.js
+++ b/src/pages/settings/Profile/ProfilePage.js
@@ -245,6 +245,7 @@ class ProfilePage extends Component {
                     validate={this.validate}
                     onSubmit={this.updatePersonalDetails}
                     submitButtonText={this.props.translate('common.save')}
+                    key={Object.keys(currentUserDetails).length.toString()}
                     enabledWhenOffline
                 >
                     <OfflineWithFeedback

Details
Using key prop on the form will force the inputs to re-render if the key has changed.
The key has the value of the number of keys in the currentUserDetails object.
Results
Initially the inputs will appear empty then will be populated with the correct values

IMO, the main issue is that the user is navigated to the Profile page after login. We have not configured such behavior in the app. This is a kind of bug in RN. I found this https://github.com/react-navigation/react-navigation/issues/9436.
There are other such issues reported by @0xmiroslav only.
https://github.com/Expensify/App/issues/12717
https://github.com/Expensify/App/issues/12428
And this type of navigation is not called deeplink. It is clearly a bug. If a user is logged out, not authScreens should be navigated which is happening But after the user is login back it takes the user to that screen which is wrong because it is not configured into the app. Because it is not configured, it is likely to create bugs.
We should target the real issue https://github.com/react-navigation/react-navigation/issues/9436.
cc: @thienlnam
The suggested solution is to use a Logout Screen for logging out the user.

I agree this can be added to the App Navigation tracking, and that this can be solved by redoing how we do auth screens.
But this type of linking should be a consideration within the design -

Click on a link to a part of the App
If you're not logged in, you should get redirected to the auth screen
Log in, and then once logged in get redirected back to the part of the App you directed to in the first place

Maybe we should put this on hold for the react-navigation update as well. This is not urgent issue such that we would need to accept workaround if we can look into fixing this with react-navigation

@hungvu193 Your proposal is on the right track, but seems to rely on currentUserPersonalDetails always having a value. But what if it is empty / new user?

@thienlnam It won't empty if user already logged in, because it included the user email even with the new user 😄

@hungvu193 True for emails, but would have broken for all phone logins
Anyways, agree with all the above about solving this in react-navigation instead of doing a fix where ever this happens.  Going to put this on hold and add it to the tracking issue

Hi, I am an Upworker, just seen this.
This fixes it:
diff --git a/src/pages/settings/Profile/ProfilePage.js b/src/pages/settings/Profile/ProfilePage.js
index 84cc1db..8199e14 100644
--- a/src/pages/settings/Profile/ProfilePage.js
+++ b/src/pages/settings/Profile/ProfilePage.js
@@ -273,6 +273,7 @@ class ProfilePage extends Component {
                                 name="fname"
                                 label={this.props.translate('common.firstName')}
                                 defaultValue={lodashGet(currentUserDetails, 'firstName', '')}
+                                value={lodashGet(currentUserDetails, 'firstName', '')}
                                 placeholder={this.props.translate('profilePage.john')}
                             />
                         </View>
@@ -282,6 +283,7 @@ class ProfilePage extends Component {
                                 name="lname"
                                 label={this.props.translate('common.lastName')}
                                 defaultValue={lodashGet(currentUserDetails, 'lastName', '')}
+                                value={lodashGet(currentUserDetails, 'lastName', '')}
                                 placeholder={this.props.translate('profilePage.doe')}
                             />

But I'm puzzled as to why no-one thought of doing it this way.
Brini

Let's add [HOLD] here too.

On Hold.

Taking this issue over as part of the larger navigation reboot.

Removing help wanted / daily labels as this is part of the navigation reboot

Good catch. We should be doing that for all holds. Btw, still on hold for the larger initiative.

I have a simpler fix. We change 'defaultValue' to 'value' in TextInput.
`diff --git a/src/pages/settings/Profile/ProfilePage.js b/src/pages/settings/Profile/ProfilePage.js
index 6c805ade9b..cecbfcab59 100755
--- a/src/pages/settings/Profile/ProfilePage.js
+++ b/src/pages/settings/Profile/ProfilePage.js
@@ -261,7 +261,7 @@ class ProfilePage extends Component {
inputID="firstName"
name="fname"
label={this.props.translate('common.firstName')}

                           defaultValue={lodashGet(currentUserDetails, 'firstName', '')}

                           value={lodashGet(currentUserDetails, 'firstName', '')}
                           placeholder={this.props.translate('profilePage.john')}
                       />
                   </View>

@@ -270,7 +270,7 @@ class ProfilePage extends Component {
inputID="lastName"
name="lname"
label={this.props.translate('common.lastName')}

                           defaultValue={lodashGet(currentUserDetails, 'lastName', '')}

                           value={lodashGet(currentUserDetails, 'lastName', '')}
                           placeholder={this.props.translate('profilePage.doe')}
                       />
                   </View>

`

Still on hold for the larger react navigation re-write.

We're making methodical progress for navigation. This one is tricky, it's going to take time.

Still on hold for the navigation project.

Same same.

Same as above

Same again.

Same same

This is getting merged soon https://github.com/Expensify/App/pull/19263

This is fixed, lets pay @0xmiroslav for reporting and we can close it

@0xmiroslav can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b93e3b41dd53617f

@0xmiroslav paid! Sorry it took a minute.


What a Great Extension! Requesting a New Feature :)

First off, thank you for providing such a useful extension.
I've been using this VS Code extension to organize a very large project's source code.
May I request a new feature?
In the jump-graph, I would like to be able to write descriptions inside the graph nodes.
Currently, we can only write or modify a single line in each node.
It would be great if, in addition to the current node, which contains three lines (the node location, file location, and code),
there was an additional line for a user-editable description.
Upon checking https://github.com/chelproc/jump-graph/blob/main/web/types.ts,
I realized that what I thought was code is actually in the note area.
Could you please support multi-line notes?
Additionally,
Could I contribute to this awesome project by submitting pull requests?
Thank you!

Hello,
I too am very impressed with the idea you are trying to build and it servers greatly for very large project. Also If I am able to contribute to this awesome extension, I would gladly do so.


Consider adding function to retrieve file paths to the template

The following script can be used to safely retrieve file paths of (non-python) files inside the project.
This could be added to the utils.
import atexit
from contextlib import ExitStack

from importlib_resources import as_file, files

def get_file_path(package: str, file_name: str) -> str:
    """Gets the path for a file

    Args:
        package (str): The package, for instance "fillname.encodings"
        file_name (str): The name of the file with the extension

    Returns:
        str: The string for the path to the file
    """
    file_manager = ExitStack()
    atexit.register(file_manager.close)
    ref = files(package)
    file = file_manager.enter_context(as_file(ref / file_name))
    return str(file)

From Python 3.7 the library importlib.resources is also integrated into Python, however, I got an error when running the tests with nox and Python 3.9 (with 3.12 it worked fine).
ImportError: Failed to import test module: tests.test_main
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/runner/work/coom-solver/coom-solver/tests/test_main.py", line 8, in <module>
    from coomsolver.utils import logging
  File "/home/runner/work/coom-solver/coom-solver/.nox/test-3-9/lib/python3.9/site-packages/coomsolver/__init__.py", line 19, in <module>
    ENCODING = get_file_path("coomsolver.encodings", "encoding-kids.lp")
  File "/home/runner/work/coom-solver/coom-solver/.nox/test-3-9/lib/python3.9/site-packages/coomsolver/utils/__init__.py", line 22, in get_file_path
    ref = resources.files(package)
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/importlib/resources.py", line 147, in files
    return _common.from_package(_get_package(package))
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/importlib/_common.py", line 14, in from_package
    return fallback_resources(package.__spec__)
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/importlib/_common.py", line 18, in fallback_resources
    package_directory = pathlib.Path(spec.origin).parent
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/pathlib.py", line 1082, in __new__
    self = cls._from_parts(args, init=False)
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/pathlib.py", line 707, in _from_parts
    drv, root, parts = self._parse_args(args)
  File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/pathlib.py", line 691, in _parse_args
    a = os.fspath(a)
TypeError: expected str, bytes or os.PathLike object, not NoneType

This looks super complicated. Do we really need that? We should also spend some time to see why it does not work with the inbuilt library instead using an external library (even though it is just a newer version as compared to the inbuilt one).
I just skimmed the docs a bit and would expect that this can also be written like:
with as_file(files(package) / file_name) as hnd:
    return str(file)

The ExitStack is designed to work with multiple context managers. Here we have just one, so the with statement is just fine.

So you are saying not to include it at all or to include the simpler version?
I just tested this and it works, although, there was a small mistake:
with as_file(files(package) / file_name) as file:
    return str(file)

I could not really find anything about why it fails. It seems to have to do with pathlib but this is also inbuilt...

Since it is all python code, it should be possible to debug this. Could you prepare a minimal working example to reproduce the problem. Then we could have a look.

This should do it. I tested it locally now only with Python 3.9 (error) and 3.12 (no error).
import os
from importlib.resources import as_file, files

dir = "test_module"
if not os.path.exists(dir):
        os.makedirs(dir)
with as_file(files(dir) / "file_name") as file:
    print(str(file))

This should do it. I tested it locally now only with Python 3.9 (error) and 3.12 (no error).
import os
from importlib.resources import as_file, files

dir = "test_module"
if not os.path.exists(dir):
    os.makedirs(dir)
with as_file(files(dir) / "file_name") as file:
    print(str(file))

I am not sure this is enough. Is this supposed to work with modules that have not been installed? Maybe it is also due to problems with editable installs as done by our noxfile. I'll try to have a closer look next week. Have a nice weekend.

Thanks! I tested this locally in the terminal and it threw the error so I think it does not have anything to do with those things. The module can apparently just be an empty folder.

I checked and the library seems to be working as expected with python 3.9. I also understand the complicated at exit construction now and would still recommend to only do this if absolutely necessary. I experimented with this project.
The code below opens the file as expected (installed using pip install -e . and pip install .):
with as_file(files("fillname") / "test.txt") as path:
    with open(path, 'r') as hnd:
        print(hnd.read())

So getting the contents of a file is simple and depending on how you want to use the file something more complicated is required. I don't see a need to provide anything in the project template because the functionality is directly available.
I would not use at_exit. If you need the files just store the ExitManager somewhere and close it yourself (best using the with statement).

I tried to reproduce the error with python 3.9 and I cannot. Your short example above fails but I would say that this is to be expected. You need a (possibly empty) __init__.py in the folder to turn it into a package. If you add it, it works as expected. Do you have an __init__.py in your tests folder?
In my tests a call to your function:
      print(get_file_path("tests", "test.txt"))

or the code:
      with as_file(files("tests") / "test.txt") as hnd:
          print(hnd)

produce the desired results.
Note that for the tests it is fine to let the context manager exit scope and still use the path. As the tests won't be installed, no extracting of files is required; the returned path should always be an absolute path to the file in the source directory. Of course one can simply write the one additional line to always be on the safe side.
I'd like to close this as invalid. Any opinions?

There is no __init__.py in my folder. I created a new folder and only added the above script and it failed.
I am on macOS, maybe something works different because of that?
For the rest I agree that this does not need to be added if it can be expressed in such a simple way, so go ahead and close it from my side.

Okay, just one last note. You should not even have to add an __init__.py file to the encodings folder. I think that
with as_file(files("test_module") / "encodings" / "test.txt") as path:
    print(path)

should work.

with as_file(files("test_module") / "encodings" / "test.txt") as path:
    print(path)

Just make sure to put the encodings folder into the test_module folder. (I think that any package_data should go into the module folder that is using the data.)


container-kosmos fails after mac installation

@coeneivan is having issues with the container installation.
Steps:
/tmp/jsx container-install
/tmp/jsx container-kosmos

Its working fine now

@coeneivan can you confirm the issue is solved for you ?

@zaibon It is indeed solved. Had a conversation with @siddiquagig before he closed it :)


Typo?

On this page:
https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/containedag
Not sure if you meant "not" or "now" in this section:
Demo Steps
The following are steps to create a contained AG, create a database to be part of the AG, create a SQLAgent Job, and observe the agent job is replicated to the secondary. Then you will execute a manual failover to see how the agent job is not available as part of the new primary.

thanks for the catch Fixed


Community Chatroom?

I would love to connect with other Langium users and discuss ideas on how to make things work better. Perhaps we could setup a chat room of some kind and start a small community? It might be helpful for beginners too.

A Gitter or Slack channel would be great.
On Sun, Feb 26, 2023 at 6:34 PM jtenner @.***> wrote:

I would love to connect with other Langium users and discuss ideas on how
to make things work better. Perhaps we could setup a chat room of some kind
and start a small community? It might be helpful for beginners too.
—
Reply to this email directly, view it on GitHub
https://github.com/langium/langium/issues/963, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVJKXKCALLGBR4DIQFMFRDWZPSAJANCNFSM6AAAAAAVIXYQRY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I've set up a Gitter channel.


Add training env data

Signed-off-by: Niels Thykier<EMAIL_ADDRESS>

Moved this to DCSA-Cluster-Utils


fix(consumer): allow the consumer to specify its exchange type

Codecov Report

Merging #28 (2ad83ce) into master (6cd1ccb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          403       405    +2
=========================================
+ Hits           403       405    +2

Flag
Coverage Δ

tests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pyrmq/tests/test_publisher.py
100.00% <ø> (ø)

pyrmq/consumer.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd1ccb...2ad83ce. Read the comment docs.


Fix issue with '$' in parse_single_key_value

When issuing the following command:
GETINFO ns/id/$some_fingerprint

The Tor control socket returns a response like:
250+ns/id/$some_fingerprint=\r\n
r nickname identity digest ... \r\n
[...] \r\n
\r\n
250 OK\r\n

But we got the error ConnError::InvalidFormat because
parse_single_key_value does not include '$' as a valid character in
the key part.

I've merged PR. Looks like it should work now.


CSS issues on SilverStripe 4.0

To start of I am fully aware 4.0 is unreleased and perhaps its a problem on my end. Although I did everything from caching clearing to double checking my composer settings etc...
I am using composer to get the latest changes but since day one I got problems with the admin panel. For some reason loads of CSS issues.

Batch Actions is using the font settings of:
.ui-widget input, .ui-widget select, .ui-widget textarea, .ui-widget button {     font-family: Verdana,Arial,sans-serif;     font-size: 1em; }

Perhaps the above is valuable information.

Yeah, those buttons are not supposed to be like that. It smells like a bug in the compilation of CSS from SCSS.
I see it too on master w/ Chrome

Recompiling the SCSS didn't fix It. @clarkepaul @flashbackzoo, one for you?

Maybe from the reorganisation by @chillu

I can have a look today

Git bisect tells me https://github.com/silverstripe/silverstripe-framework/commit/3a778f23bfdc6d00a716da1fdc18c847129ab2eb

Oh dear, that's not going to tell us much. Looking at the parent commits, my guess would be this one: 35e062d9f32df475eb41c78bd709059b417b8b01

Paul and I will sit down and nut it out now :smile:

https://github.com/silverstripe/silverstripe-framework/pull/5371

Related fix https://github.com/silverstripe/silverstripe-cms/pull/1460

The icons are fixed, but how about the other things? Such as the font on Batch actions or the way Edit page looks:


docs(root): add line to readme to say that only signed commits can be…

Summary of the changes
Added line to readme to say that only signed commits can be merged
Related issue
mi6/ic-ui-kit#13

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


added backend code and modified code Structure

File Structure modified and easy to Read codes

@PARKHI277 #6


Is this library available in Maven Central or Bintray JCenter

Hi. Just found out this library as a very approachable resource for executing HDBSCAN. I was just wondering if there were binaries available in either Maven Central or Bintray.
Thanks again for such an awesome library!

@jjzazuet Just getting around to revisiting this. It is not currently, but I'm certainly open to it. I've never put anything on Maven Central before, so I'll look into how that's done.

Thanks!

Do you still plan to do it ? It could simplify a lot the way to depend on this project...


Added docgen info to Vite output for SFC components

Fixes #46
Added docgen info to Vite (via a custom plugin) output to automatically generate controls and docs for SFC components
Note: This is a really basic implementation and will likely require further refinement.

@andrewcourtice thanks for the PR.  It looks like there are merge conflicts.  I think it's okay to add vue-docgen-api to the dependencies list, since it's not going to cause conflicts with storybook frameworks like what https://github.com/eirslett/storybook-builder-vite/pull/42 was intended to fix.
Long term, I wonder if we're going to need to come up with a better, pluggable architecture to support various frameworks. 🤔

@IanVS We're working on a metadata server in 6.4 that should handle this kind of stuff independently from webpack/vite etc. so i expect this problem to go away soon.

I fixed the conflict and merged this manually!


BUG: log reports error and says updated even when resource hasnt been updated

2022/01/06 15:23:50 azure.AzureFrontDoor.update():frontdoor.PoliciesClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="Conflict" Message="The requested operation cannot be executed on the entity as another operation is in progress."
2022/01/06 15:23:50 azure.AzureFrontDoor.update(): updated 'rg/policy'

This also seems to cause client connection to die/get stuck


[AzureOpenAi] Unable to create a AIClient() with the right parameters

Package Name and Version:

azure-ai-ml = "1.15.0"
azure-ai-generative = "^1.0.0b8"

Operating System:
MacOs Sonoma 14.5

Python Version:
3.12.4

Describe the bug
I'm trying to create an AIClient object to interact with my Azure OpenAi deployments (and get their quotas for example)

But I can't find what I'm suppose to put as project_name or ai_ressource_name
When trying to call ai_client.azure_open_ai_deployments.list() or ai_client.azure_open_ai_deployments.get("deployment_name") methods, I get the following error :
Message: The Resource 'Microsoft.MachineLearningServices/workspaces/project_name' under resource group 'ressource_group' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
A lot of the docs seems to fit the AI Azure Studio, but I'm working with the Azure Openai Studio
Expected behavior
Be able to interact with my Azure OpenAi deployments
Could you please show me screenshots of where I could find such project_name ?
Thanks a lot

@Lucas-Simonet for interacting with Azure OpenAI deployments, I suggest using the azure-mgmt-cognitiveservices library since I believe azure-ai-resources to be deprecated.
This doc shows how to install the library and get a deployment: https://learn.microsoft.com/en-us/rest/api/aiservices/accountmanagement/deployments/get?view=rest-aiservices-accountmanagement-2023-05-01&tabs=Python#getdeployment. Note that it returns a Deployment object which has information about call quota under the properties. Let us know if that works for you!

It worked 🥳
Thanks a lot @kristapratico


React 15.5 compatibility

https://github.com/cerner/terra-core/issues/203

6 of the 5 Jest tests are failing with the following warning:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

The following packages from terra-core need released with the 15.5 update to remove the warning:

[ ] terra-arrange
[ ] terra-button
[ ] terra-button-group
[ ] terra-icon
[ ] terra-responsive-element

Running site results in the same warning within the console:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

The follow packages from terra-core (not listed above) need to be released with the 15.5 update to remove the warning:

[ ] terra-grid
[ ] terra-list
[ ] terra-markdown
[ ] terra-props-table

We'll want to get this PR landed before releasing all the terra-core components with compat for react 15.5. That PR should be ready pending the fix for heroku deployment lands soon.

The following packages have been released with the react 15.5 compat code:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>


Saleor 3906/add deletion to gift cards list

I want to merge this change because...

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

Task linked: SALEOR-3906 Add deletion and modal to Gift Cards list


Minor linting updates

This PR makes a few small JavaScript linting/ styleguide updates:

Made it so that require-flow allows @flow to appear in a line comment (which is apparently allowed now).
Removed the requirement to omit the braces for arrow functions that have only a return statement and updated the guidance for them to suggest (but not require) omitting the braces for simple return-only arrow functions.
Turned off linting rules that enforced sorting of properties in React components. This was annoying in my experience and doesn't have the granularity to make it work well with class properties.
Turned off a rule that required you to use a default export when your module exports only one identifier. IMO some modules make more sense as groups of named exports (usually utility-like things), even if you currently only have one export from that group.

Thoughts? @GoodForOneFare @bouk @tessalt @Shopify/fed

👍 LGTM.

can we get this released?

@tessalt 13.0.0 released with all the linting changes, let me know if you have nay issues!


August-16

What type of PR is this? (check all applicable)

[x] 🚀 Add Any Lang Solutions. (e.g., C++, Java, Python)
[x] 📝 Documentation Update (.md File update)
[ ] 🌟 ed the repo
[ ] 🚩 Other
[ ]  Readme.md file

Write Full Code with header & Footer of Code in Solution
Description

write proper things see i have more optimize code if u want to merge you can do one thing directly write code with doing changes in whole all files like

16(Aug) Maximize The Cut Segments1.md
August-16(1).cpp
August-16(1).java
August-16(1).py
add do changes in Readme.md file also
do all things correctly or just do commit in main with August-16.cpp,August-16.java,August-16.py
with 16(Aug) Maximize The Cut Segments.md no changes or add in readme also

I see that changes have already been made to the repository . I will keep
an eye on all the changes you recommended for the next time .
Also just wanted to ask , do you allow for two solutions of the same
question . (Referring to the file name (1))
On Fri, Aug 16, 2024 at 10:09 AM Het Patel @.***> wrote:

write proper things see i have more optimize code if u want to merge you
can do one thing directly write code with doing changes in whole all files
like

16(Aug) Maximize The Cut Segments1.md
August-16(1).cpp
August-16(1).java
August-16(1).py
add do changes in Readme.md file also
do all things correctly or just do commit in main with
August-16.cpp,August-16.java,August-16.py
with 16(Aug) Maximize The Cut Segments.md no changes or add in readme
also

—
Reply to this email directly, view it on GitHub
https://github.com/Hunterdii/GeeksforGeeks-POTD/pull/12#issuecomment-2292792759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUVTSFCMZTYI7BKIKEIL6VDZRV66XAVCNFSM6AAAAABMTK6IJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSG44TENZVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

yes but it more complicating for viewers seeing answer but yes i can but if u want directly merging to main than 1 solution more optimize code is better option with 1 solution only


Handle login/register of user

As a customer I want to be able to seamlessly login or register an account on the platform

Done ✅


[BUG] Hide settings button overlapping text

The button to hide the settings overlaps with the last char in config label as pictured below. Thanks for the hard work :)

Thanks for raising this, I've fixed it in #129 :)


Hide desktop when closing game over Steam In Home Streaming

When running a game over Steam In Home Streaming, the exit process of the PowerShell script displays the desktop.
Is there a way to make this cleaner so that perhaps it remains a black screen, or even better, an "exiting" fade screen like you see in many arcade emulator setups (i.e. RocketLauncher).
Just a bit of polish to the start/end process.

There's a lot of cases when streaming that can show the desktop, and as somebody who uses this feature a lot, I would love to see my desktop a lot less. I'm not sure how this can be done, but it would be nice to see. If anybody has any ideas, please get in touch.

There's a lot of cases when streaming that can show the desktop, and as somebody who uses this feature a lot, I would love to see my desktop a lot less. I'm not sure how this can be done, but it would be nice to see. If anybody has any ideas, please get in touch.


Checkpoint, then log

Hail lazy-loads operations
by logging mt.count_rows() we force resolution of all operations, without storing the result
By printing a logging statement, then writing a checkpoint, every operation after the VDS load is duplicated (AFAIK)
By checkpointing first, the logging statement can do a no-op calculation of current rows on the checkpoint data

I'm pretty this is old code so this has been here a while. The MT doesn't need to be returned in current usage, not sure if that really affects anything.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 26.72%. Comparing base (71b948e) to head (e1d509e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   26.72%   26.72%
=======================================
  Files           9        9
  Lines        1729     1729
=======================================
  Hits          462      462
  Misses       1267     1267

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


softmax patch with openmp and mkl

hi,
I found that ref_softmax did not use openmp or mkl to sppedup.
It takes much time when batchsizes and channels are very large, so I use mkl and openmp to speedup the "execute_forward_dense" function.
And I have run some tests to compare the before and after performance:
It shows about x10 ~ x90 improvement on SKX.

format: nc
batchsize: 128
channel: 100~20000
So I submit a PR  here.
Hope it would be useful.
Thank you,

Hi @tensor-tang,
We will review that and promote soon.
Great thanks for the PR!

Thank you @emfomenk and I am looking forward.


Font color issues on thin segments and percentage questions

This issue partially relates to issue# 19.

The attached screen capture illustrates the same funnel duplicated with three different color schemes. Because of the width of the lower tiers of the funnel, some of the numbers disappear due to the automatic font colors. Can the plugin detect the background mode selection (light or dark) and if the width of the funnel tier is very narrow, select the font color that will contrast best with the background, rather than the color of the funnel tier?
We also have concerns with the percentages being calculated and shown on the funnel; the percentage numbers don't seem correct. The text box below the three funnels illustrates what we expect the percentages to be, unless there is some aspect of a funnel diagram we do not understanding.

I forgot to mention, this is using Grafana 10.4 and version 1.1.1 of the plugin.

Thanks for the issue. I will try to get a fix out for this on Friday this week.

Fixed by https://github.com/mckn/mckn-funnel-panel/pull/37


Include ffmpeg libs in linux builds

The osu.Framework.NativeLibs package does not contain ffmpeg libs. Need to investigate the reason why and consider including them ourselves like is done for other platforms.

FWIW the original reasoning was the unavailability of official (or semi official) static binaries we could be assured would be cross distribution compatible.

This was attempted in #3846. Still unsure on the licensing kinks of that one.

I'll just note that I've tried to test the new libraries with the most recent framework bump (https://github.com/ppy/osu/pull/18029) and they're not actually getting used for me, because:
      9322:	/lib/x86_64-linux-gnu/libm.so.6: error: version lookup error: version `GLIBC_2.29' not found (required by /home/dachb/Dokumenty/opensource/osu/osu.Desktop/bin/Debug/net6.0/runtimes/linux-x64/native/libavutil.so) (fatal)
      9322:	find library=avformat.so [0]; searching
      9322:	 search cache=/etc/ld.so.cache
      9322:	 search path=/lib/x86_64-linux-gnu:/usr/lib/x86_64-linux-gnu:/lib:/usr/lib		(system search path)
      9322:	  trying file=/lib/x86_64-linux-gnu/avformat.so
      9322:	  trying file=/usr/lib/x86_64-linux-gnu/avformat.so
      9322:	  trying file=/lib/avformat.so
      9322:	  trying file=/usr/lib/avformat.so
      9322:
      9322:	/lib/x86_64-linux-gnu/libc.so.6: error: version lookup error: version `GLIBC_2.28' not found (required by /home/dachb/Dokumenty/opensource/osu/osu.Desktop/bin/Debug/net6.0/runtimes/linux-x64/native/libavformat.so) (fatal)
      9322:	find library=avcodec.so [0]; searching
      9322:	 search cache=/etc/ld.so.cache
      9322:	 search path=/lib/x86_64-linux-gnu:/usr/lib/x86_64-linux-gnu:/lib:/usr/lib		(system search path)
      9322:	  trying file=/lib/x86_64-linux-gnu/avcodec.so
      9322:	  trying file=/usr/lib/x86_64-linux-gnu/avcodec.so
      9322:	  trying file=/lib/avcodec.so
      9322:	  trying file=/usr/lib/avcodec.so
``

My OS is a bit crusty (it's ubuntu 18.04) so I don't think this is necessarily something that needs to be fixed, mostly just wanted to bring it up as a point of awareness that there's an ambient dependency on the glibc version still (which may be a transitive one, basing on the machine image  on which the libs are being built).


Does it work without Nvidia GPU?

Yes, you can use this branch to run on AMD GPUs: https://github.com/EleutherAI/gpt-neox/tree/AMD

If you’re asking if this can be run on AMD GPUs, the answer is yes.
if you’re asking if this can be run on CPU, the answer is no.
If you’re asking if this can be run on TPU, the answer is yes but not nearly as efficiently.

This code may or may not run on a CPU. We have no given any consideration to running on non-GPU devices.
It's technically impossible to do anything useful with it on a CPU, because it would take years to train a small language model on a CPU.

Can this run on a laptop with one GPU? Thanks.

Can this run on a laptop with one GPU? Thanks.

Yes, but you should probably use a much simpler library.


Docs/copy edit 1

This PR does a quick scan and update for style guide.
Please note only one # (H1) per page.
Also added back the requirements.txt and run script for easy spin up of docs.
Fixed a link.

Just a quick note please @bitwalker .. we have an error on main docs
             - miden/miden-compiler/appendix/known-limitations.md```

This file will remain live and searchable even if there is no menu link to it ... so I'm not sure it that's what you need? Or perhaps you need to add a menu link?

@kmurphypolygon I've added the missing nav item for that page, build instructions for the docs, and the tweaks I suggested, in the latest commit. I'm going to go ahead and merge this, but if you spot any other issues or have other suggested changes, let me know!


Add tga as option for image sequences

Added tga option for image sequence so the filename will be changed to result_[#####].tga

Released as v1.50.7


remove an always noop shrink in _pool

leftover from slice -> pad and shrink cleanup

oh nvm that's only for conv...


feat(components): adding text lockup component

Description
Adding text lock up component to display basic key value text anywhere
**Using visuals pulled from this figma (not official) **
What's included?

Text lockup component with support for small and large scale
Icon support for subtext
State support for active, positive, negative, caution
Trailing subtext support for to see the subtext on the bottom of the main text

Test Steps

[ ] npx nx run components:storybook
[ ] then locate the text lockup story under Components -> Text lockup
[ ] finally test the different storys and parameters configured

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

Screenshots or link to StackBlitz/Plunker

So looking at this now I think we have two separate atomic components on our hands here:
Text + text lockup

Icon + text lockup
For the icon + text lockup, we'd want one for each step on the type scale, something like this:

Then if you wanted to do what you have in your screenshots where there's an icon in the label of the Text + Text lockup you just nest that icon + text lockup into that slot.
I do think they're different though, for example the Icon + text lockup belongs in various places like data tables, lists, maybe sometimes even inline in body copy:

And if it's locked away in the larger text + text lockup component that precludes that doesn't it?

Icon + text lockup

So looking at this now I think we have two separate atomic components on our hands here:
Text + text lockup

Icon + text lockup
For the icon + text lockup, we'd want one for each step on the type scale, something like this:

Then if you wanted to do what you have in your screenshots where there's an icon in the label of the Text + Text lockup you just nest that icon + text lockup into that slot.
I do think they're different though, for example the Icon + text lockup belongs in various places like data tables, lists, maybe sometimes even inline in body copy:

And if it's locked away in the larger text + text lockup component that precludes that doesn't it?

I agree we can probably benefit from adding either a seperate component with td-icon-text with support for status tokens. or adding icon support to the td-typography component we have today

:tada: This PR is included in version 4.14.0 :tada:
The release is available on:

v4.14.0
GitHub release

Your semantic-release bot :package::rocket:


Scale Control Speed to Screen Density

Currently I'm pretty sure the controls move the ship by a static amount of pixels unaffected by the screen density; as a result, this game is slightly harder to play on higher density screens.

Actually that wasn't the problem here. It was the ValueAnimators. I tested the entire app with .5x animator speeds and didn't realize.


KOGITO-1532: Integrate Google Chrome extension selenium tests

Hello @tiagobento,
this is draft PR for Google Chrome extension selenium tests. Please take a look when you have some time.
I am no sure where to place these tests?

Out of interest, I'd have thought the chrome extension was a perfect candidate for testing with cypress that purports to be a selenium equivalent without the need for drivers etc. There's another PR for kogito-tooling introducing cypress tests.
I wonder why selenium was chosen here?

@manstis It is not possible to test by Cypress.
One thing is that Cypress is not designed to test third party pages and also it is strongly recommended to not do that in their documentation. https://docs.cypress.io/guides/references/best-practices.html#Visiting-external-sites
The second thing is that I also tried it and it was not possible to load GitHub page by the tool.

@tiagobento About "where to put the tests"... I am not sure about placing these tests inside src/tests because they are not unit tests but integration tests. I think there is no rule for such kind of tests. I am bit worried that this way it will be mixed with unit tests. I would rather to have them inside a new module in packages but this is up to discussion. The Vs code integration tests are inside it-tests directory (https://github.com/kiegroup/kogito-tooling/tree/master/packages/vscode-extension-pack-kogito-kie-editors/tests-it). We should unify where we will put it tests.
About running these tests with prod build. I think it is still not possible until https://issues.redhat.com/browse/KOGITO-926 is implemented.

@tomasdavidorg Yeah.. I think you're right. UI Tests should have their own packages, you can create a chrome-extension-pack-kogito-kie-editors-ui-tests or something like that. The important thing is that this module is compiled using lerna and all the tools we're already using in this repo.
About KOGITO-926, I don't understand why this prevents us from having these tests execute during build:prod. Our tests should be able to run in whatever editor version is configured at kie-bc-editors-unpacked/pom.xml, right?

@caponetto Thanks for the review. I will take a look and I will commit/change the suggestion.

Hi @caponetto , I have incorporated most of the suggestions. The samples and the PR tests I would let as they are for now and when the PR is merged, I would create the PRs here in the repository on the separated samples. What do you think?

Thanks @tomasdavidorg! I agree with you.

@tomasdavidorg Is this still Draft? To me it looks like it's good to be merged, correct? cc @caponetto @paulovmr

@tiagobento I will do few more changes to prepare the test for the separeted samples and then I will mark this for final review.

@caponetto @tiagobento I added samples (test.bpmn and test.dmn) which are not used yet. When this PR is merged I will update tests and create the PRs, so only those samples are used and no external urls.


two party POL holder should refund from completed state

currently ticks incoming to a holder with completed state do nothing.
lets make sure that any party deposits that arrive after the deposit deadline (e.g. due to a relayer issue) would get refunded as expected.

Fix pushed on audit-fixes branch.


Use uv on GitHub Actions

After testing here, I have a script to run against all my repos, doing that now.


Added caching

This closes #18 and closes #42

Thanks @makkinga!
Will try and test later this/next week, but initial peek through file changes look good 👍

Looks great @makkinga, thanks again!

No thanks @aryehraber! You're welcome


Add Tables

Subject
Tables
Description
Add Tables
Are you willing to participate in the development of this feature and create a pull request?
None

You may also refer to https://tailwindui.com/components/application-ui/lists/tables when making these examples.


Return type for Array#zip is wrong

Input
→ View on sorbet.run
# typed: true
s = [1].zip([2], [3])
T.reveal_type(s)

Observed output
editor.rb:3: Revealed type: T::Array[[Integer, T.nilable(Integer)]] https://srb.help/7014

Expected behavior
T::Array[[Integer, T.nilable(Integer), T.nilable(Integer)]]

Removing RBI label as this will have to be intrinsified


test_thread intermittently hangs while running tests

When running tests, I have noticed that test_threads hangs intermittently. I don't know the exact cause nor where it's hanging. On the master branch:
$ ./config -g --strict-warnings
...
$ make -sj4
...
$ make test HARNESS_JOBS=4
...
80-test_cmp_http.t ................. ok
90-test_store.t .................... ok
90-test_threads.t .................. ^Cmake[1]: *** [Makefile:3373: run_tests] Interrupt
make: *** [Makefile:3369: tests] Interrupt
$

It had been hanging for about 16 hours.
This is a placeholder in case others see this issue, and so that I can have a place to put additional information.

Can easily be reproduced:
$ uname -a
Linux tshort-vm 5.4.0-99-generic #112-Ubuntu SMP Thu Feb 3 13:50:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
$ git log --oneline -1
fdc5043d58 (HEAD -> master, upstream/master) ripemd: document as being present in the default provider
$ git clean -fdxq
$ ./config -g --strict-warnings && make -sj4
...
$ while /bin/true; do make test TESTS=test_threads; done
...

The above eventually hangs.
GDB info:
(gdb) info threads
  Id   Target Id                                         Frame
  1    Thread 0x7efdc1ce9740 (LWP 2025474) "threadstest" futex_wait_cancelable (private=<optimized out>, expected=0, futex_word=0x7efdbc011248) at ../sysdeps/nptl/futex-internal.h:183
* 2    Thread 0x7efdbb7fe700 (LWP 2025538) "threadstest" __pthread_clockjoin_ex (threadid=139628220761856, thread_return=thread_return@entry=0x7efdbb7fdea0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, block=block@entry=true) at pthread_join_common.c:145
(gdb) info stack
#0  __pthread_clockjoin_ex (threadid=139628220761856, thread_return=thread_return@entry=0x7efdbb7fdea0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, block=block@entry=true) at pthread_join_common.c:145
#1  0x00007efdc1ee79f3 in __pthread_join (threadid=<optimized out>, thread_return=thread_return@entry=0x7efdbb7fdea0) at pthread_join.c:24
#2  0x000055580d2503af in ossl_crypto_thread_native_join (thread=0x55580d70ceb0, retval=0x0) at crypto/thread/arch/thread_posix.c:90
#3  0x000055580d1e20cf in test_thread_native_multiple_joins_fn3 () at test/threadstest.c:286
#4  0x000055580d250469 in thread_start_thunk (vthread=0x55580d6e8f60) at crypto/thread/arch/thread_posix.c:28
#5  0x00007efdc1ee6609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#6  0x00007efdc1e0b133 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) thread 1
[Switching to thread 1 (Thread 0x7efdc1ce9740 (LWP 2025474))]
#0  futex_wait_cancelable (private=<optimized out>, expected=0, futex_word=0x7efdbc011248) at ../sysdeps/nptl/futex-internal.h:183
183	../sysdeps/nptl/futex-internal.h: No such file or directory.
(gdb) info stack
#0  futex_wait_cancelable (private=<optimized out>, expected=0, futex_word=0x7efdbc011248) at ../sysdeps/nptl/futex-internal.h:183
#1  __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x55580d6bbde0, cond=0x7efdbc011220) at pthread_cond_wait.c:508
#2  __pthread_cond_wait (cond=0x7efdbc011220, mutex=0x55580d6bbde0) at pthread_cond_wait.c:647
#3  0x000055580d250339 in ossl_crypto_condvar_wait (cv=<optimized out>, mutex=<optimized out>) at crypto/thread/arch/thread_posix.c:244
#4  0x000055580d25038d in ossl_crypto_thread_native_join (thread=thread@entry=0x55580d6e8f60, retval=retval@entry=0x0) at crypto/thread/arch/thread_posix.c:83
#5  0x000055580d1e0d40 in test_thread_native_multiple_joins () at test/threadstest.c:1049
#6  0x000055580d1e7c87 in run_tests (test_prog_name=<optimized out>) at test/testutil/driver.c:334
#7  0x000055580d1e0076 in main (argc=<optimized out>, argv=0x7ffec3849c78) at test/testutil/main.c:30
(gdb)

AFAICT, three additional threads are created, but there are only 2 threads running by the time I attach (so two have gone away). The main thread is waiting on a join of thread t2:
    if (!TEST_int_eq(ossl_crypto_thread_native_join(t2, NULL), 1))

Thread 2 is t2, based on the thread function (#3 test_thread_native_multiple_joins_fn3 in the stack above)

This is already being worked on in https://github.com/openssl/openssl/pull/19433

@ckalina might be interested in the above comment.

Fixed now for linux and macosx builds. There is still some problem with the threadstest on Windows on buildbot so I'll keep this open.

It's not intermittent on MacOS at all - it's 100% consistent.
$ make test TESTS="test_threads" V=1
/Applications/Xcode.app/Contents/Developer/usr/bin/make depend && /Applications/Xcode.app/Contents/Developer/usr/bin/make _tests
( SRCTOP=. \
	  BLDTOP=. \
	  PERL="/opt/local/bin/perl5.34" \
	  FIPSKEY="f4556650ac31d35461610bac4ed81b1a181b2d8a43ea2854cbae22ca74560813" \
	  EXE_EXT= \
	  /opt/local/bin/perl5.34 ./test/run_tests.pl test_threads )
00-prep_fipsmodule_cnf.t ..
# The results of this test will end up in test-runs/prep_fipsmodule
1..0 # SKIP FIPS module config file only supported in a fips build
skipped: FIPS module config file only supported in a fips build
Files=1, Tests=0,  0 wallclock secs ( 0.00 usr  0.01 sys +  0.13 cusr  0.03 csys =  0.17 CPU)
Result: NOTESTS
90-test_threads.t ..
# The results of this test will end up in test-runs/test_threads
1..2
    # Subtest: ../../test/threadstest
    1..19
    ok 1 - test_multi_default
    ok 2 - test_lock
    ok 3 - test_once
    ok 4 - test_thread_local
    ok 5 - test_atomic
    ok 6 - test_multi_load
    ok 7 - test_multi_general_worker_default_provider
    # SKIP:  @ test/threadstest.c:512
    # FIPS not supported
    ok 8 - test_multi_general_worker_fips_provider # skipped
    ok 9 - test_multi_fetch_worker
    ok 10 - test_multi_shared_pkey
    ok 11 - test_multi_downgrade_shared_pkey
    ok 12 - test_multi_load_unload_provider
    ok 13 - test_obj_add
    ok 14 - test_lib_ctx_load_config
    ok 15 - test_bio_dgram_pair
    ok 16 - test_thread_reported_flags

[and here it hangs]

@mouse07410 do you have https://github.com/openssl/openssl/commit/6ca4bd2e4c92531e74acba3e1ff08e6fbb664b20 and https://github.com/openssl/openssl/commit/4e43bc06f7673597a99f61325543449e72070c8c applied? does it still hang with the 2 patches?

@ckalina I confirm that the above commits remedy the MacOS problem.
All tests successful.
Files=265, Tests=3411, 565 wallclock secs ( 4.93 usr  0.79 sys + 229.48 cusr 102.40 csys = 337.60 CPU)
Result: PASS


Initial packaging for etcd

@kensipe @sttts @jdef
(new PR targeted against version-1.x)

ping

lgtm


Move linters to pre-commit using lint-staged

Currently all lint tasks run on push, even if no file affected by one of the linters has changed. It would be nice to use something like lint-staged that only runs linters if needed and only for the files that have one. This could increase developer productivity.

This needs to be done for both, web.dev and developer.chrome.com.

Both merged!


fix: upgrade to version 3.2.77

from: https://github.com/jenkins-x/jx

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
b5f8d92e7d7515e60842d85bd123cbd9cc8d6e28
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign hferentschik
You can assign the PR to them by writing /assign @hferentschik in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
b5f8d92e7d7515e60842d85bd123cbd9cc8d6e28
link
/test tls

gsm
b5f8d92e7d7515e60842d85bd123cbd9cc8d6e28
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest


[MWCore] 1375: Show progress dialog modal for first time syncing

to unexpected crashes on interacting with the app when resources ahven't been fully loaded
Fixes #1375
Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@LZRS Thanks for taking the initiative on this one, it looks good to me.


Update Viewer models instead of reinitializing Viewers

This PR updates the Py3DmolViewer.show() and NGLviewViewer.show() methods to simply update the models in an existing displayed instance of the viewer without reinitializing the viewer (which would previously clear the cell outputs and display a new viewer object). Here, the viewer object is bound as a class instance attribute so it can get reused by just adding and removing Pose/PDB string models.

@ajasja This fixes the bug we were discussing, and adds preliminary support for nglview while updating models rather than reinitializing the viewer.

Great! Switching between two poses now works (the view matrix is preserved etc)
However I get multiple copies of the viewer (in both cases). But the second viewer goes away when moving the slider. I have noticed the exact same problem also in my bundle example. Not exactly sure where it's coming from.
import viewer3d
view = viewer3d.init(pose1, window_size=(600,600))+ viewer3d.setStyle()
view()

nglview support does not work for multiple poses

I see this is due to the setStyle command.
I wonder why an exception was not raised. -- I think the not implemented method defs should be changed to:
def apply_nglview(self, args*, kwargs**):
        raise ModuleNotImplementedError(self.__class__.name__, BACKENDS[1])

Also perhaps of each module having an apply for each viewer, maybe there could be a
class setHydrogensPymol3D(ModuleBase) and  class setHydrogensNGLview(ModuleBase) etc? Although that would not work, right, because when you create the module you want to create it with the same name for each viewer.

Thanks for your review @ajasja !
Re: a second viewer per cell: I was getting that as well. It has something to do with calling viewer.update() before calling viewer.show(). I've added an implementation to not run viewer.update() until viewer.view() is called - I now only get one viewer per cell, and can show viewers in subsequent cells using view.show().

Re: setStyle.apply_nglview - thanks, I have fixed these method signatures now.

Re: class setHydrogensPymol3D(ModuleBase) and class setHydrogensNGLview(ModuleBase) - I also considered this, but I didn't want to duplicate the setHydrogens name in 3 different places (one for each backend). If the set* classes need to be cleaner, I'm okay with moving methods to a different file. The current implementation requires having an apply_py3Dmol and apply_nglview in each set* class, but this could be refactored in the future.

The makeBundle preset should also work for nglview now.

Thank you! This is great, I think it would be a good point to merge the refactor to master.


Kiosk browser cache

Is there a way to clear all browser history after the end of a session?
Thanks

Closing. Duplicate of #1671


Is custom click event needed anymore?

It seems to have been a problem for awhile now with React updates. More info here:
https://stackoverflow.com/questions/44466241/is-the-material-ui-custom-touch-event-needed-anymore-it-breaks-a-lot

Question? This helps us keep issues for... issues. :smile: Thanks!


Travis build: add [openjdk11]

Pull Request Test Coverage Report for Build 3130

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 69.975%

Files with Coverage Reduction
New Missed Lines
%

server/src/main/java/com/netflix/conductor/server/JerseyModule.java
1
90.91%

Totals

Change from base Build 3091:
-0.007%

Covered Lines:
9956

Relevant Lines:
14228

💛  - Coveralls

Please fix build failures.

Closing PR due to inactivity, please reopen whenever you are able to resume the work.


file upload error "Server responded with 0 code."

I have an issue. When I upload mp4 files, "Server responded with 0 code." occurred after yarn serve or python manage.py start.
How do I have to resolve it?
Thank you.

One more question. the root directory is the folder which there are ".git" and ".git ignore", isn't it?
Thank you.


[Fix #10317] Fix a false positive for Style/MethodCallWithArgsParentheses

Fixes #10317.
This PR fixes a false positive for Style/MethodCallWithArgsParentheses when using hash value omission.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I think that this exception should also be explained in the cop's examples.

I've added to NOTE as well as similar exception cases.

Thanks!


Bindable action for character insert/typing?

There are bindable actions like
InsertSpace
InsertTab
InsertNewline

but I could not find anything like InsertCharacter that would work for typing anything other than space, tabs and newlines? Is there a suitable event I don't see yet or could something like this be added?

Adding to this on this, InsertSpace is listed in help/keybindings.md, but produces an error if bound on v2.0.3

Hi,
Reviewing the open issues with inserting characters, can I suggest a Lua function:
function Insert(Current,item)
    if type(item)=="string" then
        Current.Cursor:DeleteSelection()
        Current.Buf:Insert(editor_GetTextLoc(Current), item)
    end
end
-- Dependent upon:
function editor_GetTextLoc(Current)
-- Returns Loc-tuple w/ current marked text or whole line (begin, end)
-- From https://github.com/NicolaiSoeborg/manipulator-plugin/blob/master/manipulator.lua
    local a, b = nil, nil
    if editor.HasSelection(Current) then
        if Current.Cursor.CurSelection[1]:GreaterThan(-Current.Cursor.CurSelection[2]) then
            a, b = Current.Cursor.CurSelection[2], Current.Cursor.CurSelection[1]
        else
            a, b = Current.Cursor.CurSelection[1], Current.Cursor.CurSelection[2]
        end
    else
        local eol = string.len(Current.Buf:Line(Current.Cursor.Loc.Y))
        a, b = Current.Cursor.Loc, buffer.Loc(eol, Current.Cursor.Y)
    end
    return buffer.Loc(a.X, a.Y), buffer.Loc(b.X, b.Y)
end

This can be used with spaces (" "), tabs ("\t"), newline ("\n") or any string.
Lua functions are bound in the usual way  - depending upon which file you store them inside.
However, Lua functions will not work with multicursor selections, unlike proper Go actions defined in the source - which execute at each cursor.
Hope this helps and we can close these issues?
Kind Regards Gavin Holt


Refactor static

Issue #, if available: 104
Description of changes:
Refactored to use the es domain name as a naming prefix for most objects.
Made changes to allow for pre-existing vpc endpoints. If the endpoints exist they are no longer created. This allows for a better deployment into an existing vpc.
If no bucket named is defined in the cdk.yaml a bucket will now be created based on the es domain name
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks so much. I really like it.


Ensure All 4 Criteria for Characters are included

Ensure that upper case, lower case, numbers and special characters are all able to be chosen for the user

All 4 have been made into variables with strings. They were arrays but could not get the code use it. Used the parse int method to help convert the strings into single variables


Hh

After creating your pull request, tick these boxes if they are applicable to you.

[ ] I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
[ ] I have tested my changes on Python 3.5/3.6

Description
Related issues (if applicable)

if you haven't already I highly suggest regenerating a new token @brandonbayliss8


AttributeError: '_StdoutProxy' object has no attribute 'isatty'

I did some reading online and it mentioned monkey patching. Any tips on how I can do that in this case?
Here's the complete traceback:
In [45]: spinner = Spinner('')
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-45-edb2ea8bc262> in <module>()
----> 1 spinner = Spinner('')

~/.local/lib/python3.6/site-packages/progress/helpers.py in __init__(self, message, **kwargs)
     29             self.message = message
     30
---> 31         if self.file.isatty():
     32             if self.hide_cursor:
     33                 print(HIDE_CURSOR, end='', file=self.file)

What's your environment? Are you just importing progress in ipython?

I have same issue and yes, I am importing progress in ipython. Is it not how it's supposed to be used? It was working for me earlier.

Closing this as it seems to be solved with check_tty=False. Let me know if there are other cases.


[X-WINDOWS] DJV fails to launch after launching

Summary: After having successfully launched DJV, DJV fails to launch on X-Windows. Pulling in new master and resultant build also fails to launch.
Build: cba4b36c9ce9889ca3936fd177a1efb23c164049
CLI Output:
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  40 (X_TranslateCoords)
  Resource id in failed request:  0x0
  Serial number of failed request:  225
  Current serial number in output stream:  225

Platform: Linux 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2+deb10u2 (2019-11-11) x86_64 GNU/Linux

Closing this since I never heard back and cannot repro...


Feature: Set theme as the system theme

Not possible right now as the browser doesn't pass the info to the extension.


[OSP17] Make extending overcloud partitions optional

Customise overcloud partitions only when 'remote_image_path' is specified..a.k.a when we're using overcloud-full-uefi image.

We no longer use custom overcloud images

Yes, i saw your change for adding support for overcloud_full image. Hence, created this issue for making this optional because extending overcloud partitions won't work with overcloud_full image.

Since jetpack now supports overcloud-full we can deprecate extending overcloud partitions instead of making it optional


Your current user or role does not have access to Kubernetes objects on this EKS cluster

When users deploy the EKS cluster based on the instructions in the README they may run into the following error - "Your current user or role does not have access to Kubernetes objects on this EKS cluster" My recommendation is creating a prerequisites step to ensure the right IAM roles/polices are in place

Do you mean console access? If yes, then my recommendation is to do the following:

Allow a configuration option for the blueprint to provide console cluster access for current user.
If option is provided then automatically detect whether the stack is provisioned under a specific role or IAM user and add console access permissions.

The other option that I working on right now is enabling cluster access (kubectl atm) for team users. We could extend this with console access as well as an option.

Yes, I think that would be helpful if we could extend this for console access as well


Improve check of signatures subset in stateful validator

Currently set inclusion is verified in non-effective way. This is a good start for a newcomer to contribute to the code:
https://github.com/hyperledger/iroha/blob/5fd84ec8191ceaf69bd49991ffdcbb4f1fb0440d/irohad/validation/impl/stateful_validator_impl.cpp#L74

std::map<pubkey_t,bool>map_keys;
for (auto sign : signatures) {
        map_keys[sign.pubkey] = True;
  }
for (auto pubkey : public_keys) {
       if(map_keys[pubkey] == False) return False;
      }
return True;

Is this approach acceptable?

@darsh7807 please look at the latest code, approach may be different:
https://github.com/hyperledger/iroha/blob/develop/irohad/validation/impl/stateful_validator_impl.cpp#L97-L112
Please, always look at the latest code (develop branch) when you're studying iroha :-)

@Warchant  Ok, I looked at it, I think it is pretty much same thing with the previous one.
I have discussed on the telegram channel and found this approach suitable for this condition:
for( auto pubkey : pulic_keys){    for(auto sign : signatures){          if( sign.pubkey == pubkey)  {              count++; break;           }          } } if ( count == public_key.size()) return True; return False;

I made a PR please review it
PR

I am new here. Can I make this change as follows. So I can learn the process and take part in this collaborative effort:
bool StatefulValidatorImpl::signaturesSubset(
const shared_model::interface::SignatureSetType &signatures,
const std::vector<shared_model::crypto::PublicKey> &public_keys) {
// TODO 09/10/17 Lebedev: simplify the subset verification IR-510
// #goodfirstissue
return std::all_of(public_keys.begin(),
public_keys.end(),
[&signatures](const auto &public_key) {
return signatures.find(public_key)
!= signatures.end();
});
}

@steephengeorge looks good, couple minors that need to be fixed are:

the todo comment removal
adding dco for your commit

Fixed in #1339


Add support for kafka 2.1

Thank you for the patch.
The version of kafka-client was updated at b3654ad.


Remote Validation does not seem to work for nested objects

Remote validation for the samples provided seem to work for single level objects within a razor page.
however when validation is against objects in a model that are nested: E.g.

the parameter that is added to the route by jquery includes a '.' which cannot be included as a parameter in the controller.
the resulting call get by jquery
https://localhost:5001/Company/VerifyCompanySlug?CProfile.CompanySlug=ttt
as you can see the parameter 'CProfile.CompanySlug' is not accessible by the action. the variable is always null when the remote call is made.
perhaps adding detail about this Jquery flaw? or a way to potentially correct this issue?
thanks :)
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0156ffc3-47ac-d5da-fbc2-9ff5018b071b
Version Independent ID: 615db388-a244-41f7-21b5-a4085d9ed479
Content: Model validation in ASP.NET Core MVC
Content Source: aspnetcore/mvc/models/validation.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Thanks for the suggestion. jQuery behavior is beyond the scope of this article.
Should your request generate enough  👍 responses, we’ll reconsider. We'll also reconsider this issue in the next doc update.


Some questions about train_shape_predictor_ex_main.cpp

hello everyone,
I runned the example in train_shape_predictor_ex_main.cpp and got the file sp_cs.dat. Then, I used sp_cs.dat to detect landmarks of my face using camera. I found the detected results are very different between continuous frames when I keep the same posture.
I am wondering why this appears, was it because the training set is too small? If I augment the training dataset, can I get more precisely sp_cs.dat?
By the way, train_shape_predictor_ex_main.cpp mentions
“This algorithm has a bunch of parameters you can mess with.  The
documentation for the shape_predictor_trainer explains all of them.
You should also read Kazemi's paper which explains all the parameters
in great detail”
what's the exactly paper does 'Kazemi's paper' means?
BRS

Yes, it's just an example.  It doesn't make a high quality model as the dataset is too small.
The example program you are reading contains a full reference to Kazemi's paper.

thanks @davisking


Fix sub being displayed and display identity name in multiproxy selector

Fixing the following issues:
1- The sub identity is displayed (here "Chainsafe Validator 0"), even when we have a local name. That's weird. E.g check on Kusama: Fqcoa6z2T8QJkNWMr8M7LcVmPonv7wwARsvciiL7HyUnJc4

2- The main selector shows the address even when there's an onchain identity

some quality of life bonus. Even if you have a local name (displayed by default) you can search by identity name, and it will be correctly displayed.

Ah I added many more tests that I forgot to push.

name display with sub (this PR in particular)
name edition with check for buttons and keyboard interactions (esc or enter)
check for the multi-proxy selector changes


Missing darwin_arm64 build

Provider Version
0.24
Terraform Version
0.14.9
Describe the bug
Missing darwin_arm64 build artefact, so terraform init (and installation via download.sh) fails on MacBook Pro M1. As per .goreleaser.yml build matrix, such artefact should been built.
Expected behavior
Artefact for darwin_arm64 is built on releases.
Code samples and commands

Use Apple Silicon machine
Run terraform apply in a project that requires terraform-provider-snowflake plugin

I'm still getting the following on v0.25.6
╷
│ Error: Incompatible provider version
│
│ Provider registry.terraform.io/chanzuckerberg/snowflake v0.25.6 does not have a package available for your
│ current platform, darwin_arm64.
│
│ Provider releases are separate from Terraform CLI releases, so not all providers are available for all
│ platforms. Other versions of this provider may have different platforms supported.
╵

I don't really know enough about how terraform resolves releases to be able to investigate this properly, but the binary that you guys are providing for darwin_arm64 works when I manually install it to my plugins cache.
I'm happy to try and work out why this is happening and submit a PR if someone could explain how dependences are resolved in the terraform registry?

@HughZurname there's no binary for darwin_arm64 in releases, if one builds it manually and puts to plugins it works. Probably something is wrong with release process.

Fixed in the newest release! I had to upgrade go


Add input parameters

Add input parameters
Signed-off-by: Brad McCoy<EMAIL_ADDRESS>

We will use this as a base to build the cdevents github action. It's a good starting point.
/approve


Fixes pedantic clippy ptr cast lints in append_vec.rs

Problem
When running pedantic clippy, it found some ptr-cast related lints in append_vec.rs. Specifically this one: https://rust-lang.github.io/rust-clippy/master/index.html#/ptr_as_ptr.
Summary of Changes
Use ptr::cast() and ptr::from_ref() to handle pointer casting safer.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (312f725) to head (e597648).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage    81.8%    81.8%
=======================================
  Files         851      851
  Lines      230370   230371    +1
=======================================
+ Hits       188660   188662    +2
+ Misses      41710    41709    -1