Issue #16 - Getting Landrush to work on Windows

This is a first stab at resolving #16 and getting Landrush to work on all OSes. The key changes are:

Avoid the use of fork and use Ruby's Process.spawn to start the Landrush DNS server.  No dependency to rexec anymore
Downgrading the rubydns gem to 0.8.5 which is based on eventmachine which works across OSes opposed to Celluloid which won't work on Windows. See also https://github.com/ioquatix/rubydns/#migrating-from-rubydns-08x-to-09x

Apart from that the changes of this pull request are consequences of the two points mentioned above.
In command.rb I also removed the use of /usr/bin/pr (which does not exist on Windows) with printf. Last but not least, I added some documentation for configuring DNS on Windows.
I tested against Windows 10 and it  works. I still need to test on Windows 7. There is no issue with running the Landrush DNS server, but rather a question of differences in the DNS configuration. On Windows 7 it might for example be necessary to configure the "DNS suffix list" for the adapter to which one adds the Landrush DNS server.
If we agree to merge this pull request, the next steps would be:

Automate Windows DNS configuration
Make tests runnable on Windows
Get greater test coverage
These things could be addressed in follow up issues.

Looking forward to get some feedback on this.

Looks like the gemfile.lock picks up a newer RuboCop version that is not fully backwards compatible.
Seems adding something like what is outlined in this PR https://github.com/Homebrew/homebrew/pull/48144/files could work.

Looks like the gemfile.lock picks up a newer RuboCop version that is not fully backwards compatible.

TBH I did not run Rubocop. I think it was added just a while ago and I just rebased on top of these changes. Personally I only ever ran rake with explicit target which did not show any problems. However, looking at the Rakefile the rubocop task is part of the default task.
You can run rake build or rake test directly to bypass this. I see what I can do regarding rubocop itself...

I fixed some basic spacing issues, but other than that just re-generated .rubocop_todo.yml, since it looked like that most errors were just ignored anyways. Not sure whether all default Rubocop checks make sense anyways. Happy to discuss style once we have an overall agreement on this pull request.

I am wondering what environment the CI job is running on. Linux? It reports:
Finished tests in 96.890238s, 0.4335 tests/s, 0.6193 assertions/s.

  1) Failure:

test_0004_stops the landrush server when there are no dependent machines left(    Landrush::Action::Teardown) [/home/travis/build/phinze/landrush/test/landrush/action    /teardown_test.rb:48]:

Expected: false

  Actual: true

  2) Failure:

test_0001_starts and stops a daemon(Landrush::Server::start/stop) [/home/travis/    build/phinze/landrush/test/landrush/server_test.rb:23]:

Expected: false

  Actual: true

42 tests, 60 assertions, 2 failures, 0 errors, 2 skips

rake aborted!

My result of rake test on OS X is:
Finished tests in 37.004713s, 1.1350 tests/s, 1.7025 assertions/s.

42 tests, 63 assertions, 0 failures, 0 errors, 1 skips

I can try to run the tests in a Linux VM, but it would be nice to know the environment used for CI to make sure I align with it.

Ok, I pushed another update to this pull request, fixing the tests on Linux as well. Turns out that I missed a Process.detach after spawning the Landrush DNS server. Seems OS X and Windows are more forgiving, where on Linux you end up with Zombie process which won't go away until the parent process exits.

@strzibny - WDYT?

Rebased on current master.

@hferentschik works fine on Fedora 23. However I had to add gem 'json' to Gemfile
[lmohanty@LalatenduM-laptop landrush-hardy]$ bundle exec rake
Running RuboCop...
Inspecting 44 files
............................................

44 files inspected, no offenses detected
Run options: --seed 7723

# Running:

...Stopping daemon...
Pid file /tmp/vagrant_landrush_test_working_dir/run/landrush.pid not found. Is the daemon running?
.Stopping daemon...
Pid file /tmp/vagrant_landrush_test_working_dir/run/landrush.pid not found. Is the daemon running?
.Stopping daemon...
...Stopping daemon...
Pid file /tmp/vagrant_landrush_test_working_dir/run/landrush.pid not found. Is the daemon running?
.Stopping daemon...
.Stopping daemon...
Pid file /tmp/vagrant_landrush_test_working_dir/run/landrush.pid not found. Is the daemon running?
.Stopping daemon...
.Stopping daemon...
..Stopping daemon...
.Stopping daemon...
.....Stopping daemon...
........S......Stopping daemon...
.Stopping daemon...
.Stopping daemon...
.SStopping daemon...
...

Finished in 16.901247s, 2.4850 runs/s, 3.5500 assertions/s.

42 runs, 60 assertions, 0 failures, 0 errors, 2 skips

You have skipped tests. Run with --verbose for details.

However I had to add gem 'json' to Gemfile to make it work

Hmm, interesting. I thought JSON is part of the standard lib, so it should not be necessary to install an additional gem. What Ruby version are you using?

@hferentschik
$ ruby --version
ruby 2.2.4p230 (2015-12-16 revision 53155) [x86_64-linux]

Interesting. I guess it cannot harm to explicitly add 'json'. trying to understand why is it required. Did you specify any particular version?

@hferentschik nope, it was just gem install json then added to Gemspec

@hferentschik I think you need to update https://github.com/phinze/landrush/blob/master/CHANGELOG.md in this PR to list the fix

Sure. The change log is not updated, nor the version bumped. This would
happen
when a new release is cut. Probably making a bit of a version jump as
well!?
Thanks for the feedback btw. Much appreciated.

@LalatenduMohanty I've added the json gem to the Gemfile and pushed an update. Can you try once more?

You need json for Ruby packaged in Fedora, it's unbundled from Ruby itself.
On Feb 5, 2016 4:54 AM, "Lalatendu Mohanty"<EMAIL_ADDRESS>wrote:

@hferentschik https://github.com/hferentschik nope, it was just gem
install json then added to Gemspec
—
Reply to this email directly or view it on GitHub
https://github.com/phinze/landrush/pull/154#issuecomment-179809114.

You need json for Ruby packaged in Fedora, it's unbundled from Ruby itself.

Go figure.

@hferentschik now bundle exec rake works fine in Fedora 23 without any modification

now bundle exec rake works fine in Fedora 23 without any modification

nice

@njam  @ahpook  @strzibny  @fh
Please review - I am almost done with my review and really want to merge this so we can say we work on Windows again.

Related to this issue is #157 which needs to be fixed as well.

@hferentschik Is there a reason why you added the style violations to the rubocop todo? The whole point behind rubocop is to enforce a consistent style across the new code - the todo is only there for old code that has to be cleaned and refactored, so I would prefer not to add more debt to that.

Is there a reason why you added the style violations to the rubocop todo?

Yes and no. The rubocop todo file needed upgrading anyways, due to some changes in its format. Given the amount of violation which were already in there, I felt it was not worth spending too much time on changed violations. I am also very much for a code style, but not necessarily agree with all the rubocop defaults.
That said, if the plan is to stick to all rubocop defaults, I am happy to go over my changes again and adjust the code to at least come to the same level (if not better) of violations as prior the pull request. I just did not want to spend time on style problems until I get some feedback on the actual technical changes. WDYT?

@hferentschik Sounds fair - maybe just use the autocorrect feature to remove the overall amount of errors, and we'll see for the rest. Sorry for giving style comments first, I am just not able to give the PR a test drive for the next days - as soon as I am able to do so, there will be more substantial feedback (unless someone else already chimed in ;))
Fwiw, I dont like all the rubocop defaults either, and I dont have any preference in regards to which to use - I just like to have something, and improving from there.

maybe just use the autocorrect feature to remove the overall amount of errors

+1

Sorry for giving style comments first, I am just not able to give the PR a test drive for the next days

Sure. No problem. Just happy to get some feedback. I also found some other related issues which I will address in follow up pull requests. For example the way the Vagrant data dir is determined is wrong. One need to go via Vagrant @env instance which is passed to the plugin. This does not really effect this code, but can lead to problems on Windows where you want to start Landrush from a cygwin shell.

I just like to have something, and improving from there.

+1 Sounds like a good plan.

I included few styles issues that I would like to change. As for real Windows testing, I don't have the Windows machine for testing that I had. @pvalena can you please test this patch?

@strzibny Hi, sorry i am really busy right now, but as soon as I get it done I will test it.

@strzibny, thanks for the feedback. I am planning another update to this pull request for next week. I'll address your style comment and try to reduce the overall amount of robocup violations.

@fh, @strzibny - I did a fair bit of code cleanup and reduced the amount of rubocop violations considerably. Forced pushed an update to this pull request.
Also created a follow up pull request #160 based on this pull request addressing issue #157.
@bexelbie How is the review going?

Here is another idea. The problem seems to be access for people to Windows machines. What's about marking Windows support as experimental? If we can agree that the code is not breaking anything for Linux or OS X, we could then go ahead and merge. We could even do a release and this way get feedback from people trying to use Landrush on Windows.

@hferentschik moving to windows as experimental could work - I am traveling this week so my windows testing time is more limited :(

@hferentschik like that idea very much.

like that idea very much.

Ok, let's go for something like that then. I guess all that's needed are some notes in the docs

@hferentschik do you have time to rebase and add the docs notes?  I saw your comment about wanting to land this, this week.

do you have time to rebase and add the docs notes?

will do. I also will add a commit which allows to run the tests on Windows. Now you can develop Landrush on Windows as well :-)
I also confirmed the setup once more on a "virgin" Windows 10 setup. Worked fine.

I saw your comment about wanting to land this, this week.

Most likely tomorrow. Once everything is merged we will need to talk about a release :-)

Ok, I pushed one more update adding a note to the docs that Windows support is experimental for now. I also changed the test suite and it runs now on Windows as well. So Landrush can now be run and developed on Windows.
I would like to merge this now. Can I get one more maintainer ACK - @njam, @ahpook, @strzibny, @fh, @bexelbie, @phinze?

@hferentschik looks like there's merge conflicts, according to github - do you need to rebase? I'm 👍 once that's resolved, I read through the docs and all seems reasonable.

looks like there's merge conflicts, according to github - do you need to rebase?

I don't think so. I might have pushed one time too many to this branch. I'll can close this pull request and open a new one. That should sort things out.

I'm :+1: once that's resolved, I read through the docs and all seems reasonable.

Thanks.

Actually I needed one more rebase. Nevertheless, here is the new pull request, passing also Travis CI - https://github.com/vagrant-landrush/landrush/pull/170


fix(partition-plan): security vulnerability.

What type of PR is this?
type-bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fix security vulnerability and remove redundant code.
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.:

PR title suggestion: security: broken access control in the partition plan


⚠ AlphaRatio has degraded performance

In 7cc543e, AlphaRatio ($AR) experienced degraded performance:

HTTP code: 200
Response time: 2281 ms

Resolved: AlphaRatio performance has improved in 36e84db.


Fix human genomics test data based on broken short-read DNA seq fastq files + adding cram files

@GCJMackenzie this is great. I will pick the ones needing updating then. Would you mind maybe adding the docu to the README https://github.com/nf-core/test-datasets/blob/modules/data/genomics/homo_sapiens/README.md ? (Iam updating it in this PR, might be easiest to wait until this one is merged)

@GCJMackenzie for the data in paired_mutect2_calls did you use the filtered or unfiltered vcfs from sarek?

Hi @FriederikeHanssen I think this should work:
gatk GenomicsDBImport \
-V ../gvcf/test.genome.vcf  \
--genomicsdb-workspace-path test_genomicsdb \
-L test-datasets/data/genomics/homo_sapiens/genome/genome.interval_list
Also, as a heads up, for the the directory: /test_genomicsdb/chr22$1$40001/__3cf81648-433d-4464-be08-23d082445c9b139814474716928_1630588248448/
and the file:
/test_genomicsdb/chr22$1$40001/genomicsdb_meta_dir/genomicsdb_meta_2b25a6c2-cb94-4a4a-9005-acb7c595d322.json
The text in bold will change with each run, but the contents of the file and directory will remain the same. It would be great if we could rename the names back to what they are above as this will stop my tests for genomicsdbimport and createSomPon breaking when they try to download the files

Thanks guys!


Update to .NET core 1.0.1

https://blogs.msdn.microsoft.com/dotnet/2016/09/13/announcing-september-2016-updates-for-net-core-1-0/

Skip this and go to Current instead of LTS?


Fix the visual studio project creation

Fixed the debugging issue after Visual studio project creation
Also updated all the properties for visual studio project from Godot to Redot

Will review soon, we're in the middle of getting a release done but after that is prime time for fixes and things like that. Appreciate the input man, we'll check back soon

Needs to be retargeted at master, and also done for 4.3, standby for Trashguy and Spartan to touch base

If you want me rebase the fix to master. I will do that, let me know. It was based on branding fixes.
It should not conflict with any other fixes.

The redot-rebranding branch is dead, this needs to target 4.3 and master.

closing this pull request and will create a new one as the amount of fix has to be done for rebasing is too much.


[BUG] Vampirism incompatibility

Vampirism hud overwrites the temperature and water hud
https://www.curseforge.com/minecraft/mc-mods/vampirism-become-a-vampire

This is a Vampirism bug, but I'll see if I can work around it. Since you didn't leave any details, can you please provide the versions and the loader? I literally am unable to guess from a screenshot.

neoforge 21.1.61
vampirism 1.10.0
Homeostatic <IP_ADDRESS>

This is fixed in the latest release. Can be found on CurseForge and Modrinth.


Stuck in "An update is already running"

Steps to reproduce

Open Mihon
Try to update the mangas

Expected behavior
Chapters get updated for the mangas.
Actual behavior
Nothing happens. The "Library last updated" shows as 22 hours ago.
Crash logs
No response
Mihon version
0.16.5
Android version
Android 14
Device
Google Pixel 6a
Other details
This happened 22 hours ago and i tried to update it 4 times since then at different times and it doesnt work.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

your title and description doesn't match

How so? When i try and update the chapters i get the message "An update is already running" and this update has presumably been running since 22 hours ago and doesnt stop.

Try force stopping the app, and maybe make sure Mihon still has notifications permission. Iirc, it should try to update the library again when you open it, see if it's getting stuck on an entry/source.

How so?

Cause it doesn't. You can't just write a half baked issue and expect everyone to understand it.
Anyway do what the other comment mentioned and join our discord for further support.

Try force stopping the app, and maybe make sure Mihon still has notifications permission. Iirc, it should try to update the library again when you open it, see if it's getting stuck on an entry/source.

Thanks forcing the app to stop worked.

How so?

Cause it doesn't. You can't just write a half baked issue and expect everyone to understand it.
Anyway do what the other comment mentioned and join our discord for further support.

What should i have specified more in my Issue? I am genuinely interested in how i can improve in that regard.


all: close files

Want an invite code?

Unfortunately, I'm an Android user.

@whyrusleeping Could you please give me the invite code?

sent an email :)


Update ConversionService and DelegatingConversionService examples with their new signature

Update the examples of ConversionService and DelegatingConversionService so they match their signatures.

@ddadon10 thanks for the contribution! Merging


Clean up several TODO(version) related to conversions

Conversions have been updated to be as explicit as possible on what is
allowed and what isn't.

Update many stub injection/bijections have been replaced by
Conversions
ListHandler has been updated to try and remove the cyclic dependency on
needing to convert bidirectionally between
internal.model.PackageDefinition and universe.v3.model.PackageDefinition

Formatting of Universe.scala has been updated to try and make
declarations as consistent as possible.
Update CosmosIntegrationTestClient to be more tolerant of receiving a
token that isn't >= 10 characters. Prior to the fix
CosmosIntegrationTestClient would result in an
ExceptionInInitializerError if the token passed in was < 10 characters.

@jsancio @tamarrow please review

LGTM! :shipit:


Sikuli integration in Ginger - Implemented

Minor fixes are pending-

Update/Extend SikuliX jar file to support advanced Sikuli operations like GetValue and Sibling element action supports.

Improve image capture functionality.

I think it is better to put the Sikuli project on a separate repo. we can merge this PR and do the refactoring as part of enhancements we are planning to do in this release


chore(release): 1.147.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 55bf940ed62f33f354028b175a104f6d7953849b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 625f371e983e88f76dd7a225d55b471dbd7e07a1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 625f371e983e88f76dd7a225d55b471dbd7e07a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 6fc0fe41c43abdb5b17bc52ee2a313b7370aa9f2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 6fc0fe41c43abdb5b17bc52ee2a313b7370aa9f2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 2f30528c6ddc9ef814ce113296d74ed0d0c7aece
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 2f30528c6ddc9ef814ce113296d74ed0d0c7aece
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 16a2e0a2ad1ebd9f34334a5eef521f46c6f42cd9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: cb99b416a1ea2ea3b898d863be4d5f4ecea6f430
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: d98ad1b863b19194f2445c08f4d39312c819050f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: d98ad1b863b19194f2445c08f4d39312c819050f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: d1b8580c92bfb25637567e31f35c47cf339f92f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 5c5836c1d466d2385907ec4f56d1cd9eea1ee081
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 5c5836c1d466d2385907ec4f56d1cd9eea1ee081
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Foundation Encoders

This implements the JSONEncoder, JSONDecoder, PropertyListEncoder, and PropertyListDecoder types proposed by SE-0167.
This pulls all Foundation-specific work out of #8124 for separate integration.
This PR depends on #9004 and should NOT be merged until #9004 is complete and merged.

@swift-CI please test

@DougGregor This isn't quite ready to be merged yet — I've got unit tests incoming either later tonight or early tomorrow. But when they make it I'll test and ping you if ready to merge

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - a1345ce4eceb35f1f76add66befdc6e189bd0d8c
Test requested by - @DougGregor

Ok!

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - a1345ce4eceb35f1f76add66befdc6e189bd0d8c
Test requested by - @DougGregor

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - a1345ce4eceb35f1f76add66befdc6e189bd0d8c
Test requested by - @itaiferber

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - a1345ce4eceb35f1f76add66befdc6e189bd0d8c
Test requested by - @itaiferber

@swift-ci please clean test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d177bdf748c5e86f06e12852317a7b73b51b5248
Test requested by - @DougGregor

@swift-ci clean test macOS

@tkremenek I think the linker errors are legitimate, no? The box types that I added were marked as fileprivate where I think they should actually be internal (I looked at the box types for Sequence, Iterator, etc. and they are all @_fixed_layout @_versioned internal). I'm about to push that change and test

@itaiferber great point; I wasn't certain if those failures were genuine or not.  I'll cancel the job I just initiated.

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d177bdf748c5e86f06e12852317a7b73b51b5248
Test requested by - @tkremenek

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - d177bdf748c5e86f06e12852317a7b73b51b5248
Test requested by - @itaiferber

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - d177bdf748c5e86f06e12852317a7b73b51b5248
Test requested by - @itaiferber

🎉 @DougGregor @tkremenek When either of you gets a chance, do you mind merging this in please? Thanks!

@tkremenek Thanks!

Congrats to @itaiferber for getting this landed

Thanks, @DougGregor! Looking forward to feedback when people start using it. :)

@itaiferber I have another question.
What should codingPath contain on processing super and nestedContainer?
Current implementation seems not to contain both of super and key for nestedContainer.

@norio-nomura This is another bug: codingPath on nested containers and referencing encoders should include the codingPaths of their parents. I have a branch with a fix (https://github.com/itaiferber/swift/tree/foundation-codingpath-fixes) but haven't gotten the chance to put it up as a PR yet. Will do in the next few days.

@itaiferber Thank you for clarifying. 🙏
FYI, I'm trying to implement YAMLEncoder and YAMLDecoder for SE-0166 at https://github.com/jpsim/Yams/pull/43.
I'll check your branches to fix codingPath on that.

Is Codable support for NSKeyedArchiver part of another PR ? It's in the SE but can't seems to find it in code for now.

@Dimillian That integration hasn't been completed yet. This will be coming in in a future PR.

@itaiferber JSONDecoder & JSONEncoder are not yet available on Linux, or am I missing something?

@bubski How recent a snapshot of Swift are you using?

@CodaFi I tried both
swift-4.0-DEVELOPMENT-SNAPSHOT-2017-06-06-a-ubuntu16.04
and
swift-4.0-DEVELOPMENT-SNAPSHOT-2017-06-07-a-ubuntu16.04

It seems that because this has landed in the Darwin SDK that it will need to explicitly be put into Foundation for it to be usable on Linux.  The proposal does not make mention of platform lock-in, so I think this will need to be mirrored over.

@bubski As @CodaFi mentions, this will need to be introduced into swift-corelibs-foundation in order to be available on Linux. The code as-is should be easy to transfer over to there without requiring many changes (if at all), but we haven't gotten the chance to (and it seems that no one from the community has either).

I've filed SR-5195 about this.

@itaiferber I started hacking around the idea
http://github.com/bubski/JSONEncoderLinux
and managed to get it running on Linux.
But I don't have a good swift-corelibs-foundation dev environment to do proper implementation (that's why I copy-pasted some internals to expose them).
I'll try to clean it up and make a PR to swift-corelibs-foundation so it's easier for someone to verify.

@CodaFi Thanks for that!

@bubski Cool, thanks! The one annoyance will be keeping these things in sync. There are still some outstanding changes that will be landing in JSONEncoder/Decoder that will need to be ported over as well.

@itaiferber Yea, I figured. I'm open to any suggestions.
It's also tricky because of discrepancies in the way Foundation types casting works on Linux (or rather the fact that it doesn't) together with JSONSerialization producing different types on Linux vs macOS.

@bubski Yep, there are a few places where I've noted (in the Darwin implementation) places which may have this discrepancy. I think overall, it might be worth updating JSONSerialization to follow suit, but that will require some further review which we simply haven't had time for.
As for keeping things in sync, there's not much at the moment, unfortunately. We struggle with this ourselves. I think we need a general process/solution for improving this.

@itaiferber Is having a default value + support optional Codable property something planet?
Let me explain, you define a var as such in a Codable object:
var progressMax: Int = 0
But then if you decode your object with a JSON that does not contain progressMax it'll throw a missing key error. Which make sense, but it also make sense to have a default, hardcoded value + a JSON defined one if available.

@Dimillian It's possible to support, but I don't know if that's something we'd want to do out of the box. It's impossible for us to tell whether the default value is assigned for the benefit of other initializers, or whether you meant for it to be a default value if the JSON couldn't be read. I don't know if we can read into the intent there — did you want us to assign a default, or were you expecting the error? No real way for us to know.

@itaiferber In this specific case, the JSON can be different and still represent the same object once decoded.
If you have a model defined as such
class Book: Codable {

var title: String
var author: String
var progress: Int = 0

}

The JSON will always have the title and author value defined, but the progress value will be in only in some cases (let's say it's an API and the server control it).
So it make sense in our case to work with non optional value, because we decided that when progress is not present, it should be equal to 0.
Is there a way in current implementation to represent that?
But I understand that you can't really define our intent at a lower level, and in make sense for other use case to throw an error.

@Dimillian You've got a few options here (of course, not all perfect):

Make progress an Int? — this will set it to nil by default instead of throwing an error, and you can treat nil as "no progress". Of course, this is a subpar experience, but it's the easiest solution.
Make progress a custom Progress type which can initialize from nil and has an Int raw value. Also not optimal, but it will work.

None of these solutions are great, but they are at least explicit. I'll think on this some more; perhaps there is a cleaner way to improve the experience of doing this.

@itaiferber Actually, your 1. is what we did. It's a bit subpar because we have to unwrap it each time yes. But that's acceptable. In our case we have a lot of var like that now, as we converted NSCoding/Reflection code to Codable. And we could write custom decoder and encoder but in that case we lose a bit of the benefit of Codable.
I think this should be an option in the decoding strategy of the JSONDecoder. Like an optional decoding strategy, you set it to what you want. If that feasible. Maybe I'll take a look at it.


Which platform to opt while creating a keyword to use WWD in website

I am trying to use porcupine WWD in my website. For that, I'm using the JS binding. I created a new keyword for the linux/x86_64 platform using the optimizer tool and generated the uint8 array to be used in the voiceControlDemo.js file.
When I open the demo/js/voice_controller_demo.html in firefox, and click on Start Demo, I see an error in the debugger console :
keyword file has incorrect format or belongs to a different platform
Please suggest me which platform should I select while creating the keyword, if I intend to use it in my website.
Thanks.

Wake words model file generated for Linux platform won't work for WebAssembly. You can use any of the wake word model files made available here:
https://github.com/Picovoice/Porcupine/tree/master/resources/keyword_files/wasm
There's a fee for generating custom wake word model files for WebAssembly. You have to contact Picovoice for pricing details and their license terms.


[Waiting for Apr 5 python 3.9 deprecation] Extend AsyncStatus wrapper to allow methods and functions with args

Fixes #45

Just to let you know there is also https://github.com/bluesky/ophyd-async/issues/117, not sure if they should be 2 separate PRs or do them both in one?

@coretl Oh, cool, thanks for letting me know. Happy to do that in here as well since they're such small related changes. I'll test it closer to the time it becomes actually relevant.


added test cases for restapi

Hey there,
this PR adds test cases for the REST API. As the test cases for working with tags have already been included, I've added the general GET and POST Requests, as well as all requests that are working with mission ids.
The test cases are located in backend\restapi\tests.py and running them works by using python manage.py test restapi
Hope I covered everything, feel free to point out any cases I forgot :)
This would resolve #60

Thanks for spotting the typo @s-rappold :) could you please approve it again, it dismissed your review after my latest commit


[webapi] Fix improper conversionTable values

This patch fixes improper values in conversion table
which are used to validate conversion.

@zqzhang Files unitcommon.js have been updated.


Flatpak/flathub support

Describe what problem your feature request solves
A Flatpak install would be a great alternative to Snaps and Appimages, since this allows most users to download threat-dragon straight from their software store. Would people be open for this? I could look into it myself but I want to see if there is an appetite for it.

This would be great to have @TeaDrinkingProgrammer , if you would like to find out what is involved then that would be great

We probably could follow the example in https://docs.flatpak.org/en/latest/electron.html
it takes several steps, but nothing that can not be automated

@sparticvs @jgadsden  I was still planning on looking at it, it is just that I am incredibly busy right now, I probably will have some time in a week or two. I have never done anything with Flatpak though, so it will be a learning experience for me. How about I start working on it and ask for help/feedback when I have something to show for?

Yes, sure, that sounds great @TeaDrinkingProgrammer  - over to you

I did a bit of research and bumped into this fun roadblock:
The guide @jgadsden linked is indeed very useful and I followed it. This went well until I got to the step where you have to build the NPM packages. This step uses a separate python script to download all NPM dependencies so you do not have to put them in the manifest manually. The problem is that this script relies on a package-lock file from either NPM or YARN to get the download links. I have looked up if maybe it would be possible to convert from PNPM lock files to NPM lock files, but the creator of PNPM has the staunch opinion developers should add support for PNPM instead of PNPM adding a convertor (I think this is quite unrealistic to expect from users and that it will put off developers rather than help adoption, but I digress).
I think there are a few ways of solving this issue:

Switching to NPM: I do not know the ins and outs of PNPM vs NPM, but I imagine it was chosen for a reason.
Adding PNPM support to the script: this would be possible, the script is not very big, but I personally wouldn't want to undertake it as I am not very fluent in Python, Flatpak or PNPM.
Only using NPM for generating a package-lock: I have tried this out. Besides the fact that the only-allow package would need to be disabled for this, it also creates a package-lock with different versions than the main one, which will probably create some headaches.

I honestly do not like any of the options, but I do not see any others. Any ideas?

Hello @TeaDrinkingProgrammer  - I realise the amount of work to get this far, much appreciated
pnpm was chosen because it is fast on the download and install ... and we liked using it as it is marginally more forgiving than npm.  But that was the only reason: we thought it looked fun and went with it
It has caused us some problems, for example moving from pnpm version 7 to 8, and it does have some downsides
If it is stopping us from doing flatpak then we can migrate back to npm, it is not as bad as it sounds and does simplify our pipeline scripts
We can ponder for a bit? and if we decide to move back to npm then I am happy to implement this, unless you want the honour :)

I was intending to do a 2.1 release soon, this will reinstate the PDF button on the desktop version
I could delay this for a bit so as to get npm back in if we decide that is the way forward ... all part of the pondering :)

@jgadsden No, I'm happy to hand it back over to you, it is a lot more complicated than I thought 😅 , but hey, I learned a lot from it. Probably, moving to NPM is the obvious option as it is the industry default, but the script also supports YARN so that would also be an option. From what I can find, Yarn is faster than NPM, but slower or equal to PNPM, but I find that these kinds of benchmarks or opinions are rather subjective. One interesting thing about Yarn, is that it does not have an audit fix command (you need a package for this), I can imagine this could be a dealbreaker for an app under the OWASP umbrella. I would personally give them both a try and see what works, but that's just me.

oops, I did not mean to say that I wanted to implement the flatpak, I was just referring to the migration back to npm from pnpm
I hope you will still carry on with the flatpak @TeaDrinkingProgrammer ?

I have heard about Fedora turning RPMs into flatpaks, would that be worth looking in to?

@TeaDrinkingProgrammer yes, although I haven't done that myself, I know others that have.

We have moved Threat Dragon back to npm from pnpm. There is no real difference, npm install times now seem to be comparable with pnpm and we are no longer forcing our developers to use pnpm.
It is still OK to use pnpm with Threat Dragon, we do not get in the way of anyone installing and running with pnpm, it is just that now the repo clones with a package-lock.json instead of a pnpm-lock.json file
@TeaDrinkingProgrammer did you want to carry on with your development? you probably just need to sync your fork to get the npm lock file

It's been a while, but I haven't forgotten about this. I have looked at it again with NPM and I have gotten a lot further, but I am up to a roadblock again. I have a strong hunch it has to do with the Python script but I will discuss it here first to rule out any oddities on this side.
The problem is as follows:
As I discussed previously, Flatpak does not allow internet connections in the build step. Flatpak does support downloading sources before the build step, so there is a script which "converts" the package-lock.json file to a generated-sources.json file. This allows flatpak to download all node_modules dependencies before  the buildstep which are then used by NPM during npm install. I generate the generated-sources file first and let Flatpack build, but get this error:

I will try these commands on my system, ND so how far I get

Hey @jgadsden can i contribute to this issue?  and if so how can i help & contribute to get tis resolve ASAP.
Please and thanks :)

Hello @mademarc , if you would like to repeat what @TeaDrinkingProgrammer has done so far, that would be a great first step

@sparticvs , @TeaDrinkingProgrammer and @mademarc , is the flatpak / flathub support progressing? We moved to npm and package-lock.json (instead of a pnpm-lock.json file) so it may be worth revisiting
No problem if we can not do Flatpak in time for version 2.3 (end August 2024) as it can be bumped back to version 2.4 (early December 2024)

I might look into it in a couple of weeks so if I find the time, it would be in time for 2.3.

If I understand correctly, there is no need for a flathub account? The submission is done following page Submission

hey @jgadsden i was  unable to address the Flatpak feature request asi was super busy at that moment and that said i could consider the following steps to assist that are below:

Research Flatpak Packaging: Look into creating a Flatpak package, especially for Electron apps.

2.Test Locally: Build and test the Flatpak package on their system.

Submit to Flathub: Follow Flathub’s submission guidelines to make it available.

Update Documentation: Add Flatpak installation instructions to the project's documentation.

or can i follow up with @TeaDrinkingProgrammer in order to fix this issue ?

you are most welcome to work on this @mademarc , I do not have the time myself but if you could coordinate with @TeaDrinkingProgrammer that would be great


fix db-to-sqlite command in ecosystem doc page

the --connection parameter has become positional

Thanks for spotting this!


closed splits eating window space

I noticed that when you combine vertical and horizontal splits, after closing some of them, the space occupied by the last closed split remains unusable:

in the demonstration I used default config with "editor.split.mode": "oni" as the only override and the sequence executed was:
<c-w><c-v>
<c-w><c-s>
<c-w><c-q>
<c-w><c-q>

Ah ya, this looks familiar 😄 Thanks for logging the issue, @mellotanica .
Actually had a workaround in the demo branch - you'll notice the website demo doesn't have this issue!
I'm factoring out the change in #2159


cordova-android version requirement mistake?

I think there's been a mistake. Version 2.2.0 bumped cordova-android requirements to 7.1 even though it still says cordova 7.1 which comes with cordova-android 6.3
The change was done in this commit: https://github.com/phonegap/phonegap-plugin-push/commit/68884671116c9f1e23de0b9cba583a2a008516ed#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
Was that a mistake?
This gives me an error when installing the plugin for android on cordova 7.1 because I can never fulfill that requirement.
Plugin doesn't support this project's cordova-android version. cordova-android: 6.3.0, failed version requirement: >=7.1.0
Skipping 'phonegap-plugin-push' for android

@oliverjanik no, it wasn't a mistake. There is a fix in cordova-android 7.1.0 that is needed for 2.2.0. Just because cordova pins a version of a platform it doesn't mean you can't install a later version. Just update the cordova-android version in your config.xml.

Thanks for the info, what fix are you referring to, if you don't mind?

https://github.com/apache/cordova-android/commit/3a339ba37fc979d5abec809ff085a2d410c48d99


Clock initializes as 00:00:00

You can see the clock flash 00:00:00 in the contact section, try and make it display the actual time for a more polished experience.

Fixed by adding a preloader to the website (issue #136 ), this flash cannot be seen anymore.


DPDK: Cleanup queue and core count selection logic

Cleaning up perf test and queue/core selection logic.
Noting here that the multicore/hugevm tests should eventually support multiple nics. Currently we do not make use of multiple nics because it is more complicated to configure them. A future PR will have to implement this support.

@LiliDeng  or @squirrelsc  can I get another eye on this? Should be ready to merge.

Identified that the issue I noticed during testing will be fixed by PR https://github.com/microsoft/lisa/pull/2204


WinUI 3 Sample

Please provide a WinUI 3 sample app

“BTW this will also work in WinUI3 however there is a bug and the Type is not comming throug to AP Setter so once it's fixed it will also wrok in WinUI3.0”
https://github.com/microsoft/microsoft-ui-xaml/issues/6171

I tried (https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation)
this in WinUI3.0 not working,
is there solution for WinUI3.0.

@bos1313 as described in the web page of this project there is a bug in wini3 that makes this harder not sure if they fixed it. But I'll update the description with a workaround later today.

ok added working winui3 version, have fun

Thanks KWodarczyk
it works fine.

done

Hi, Karol,
first of all thanks for your generous help regarding to navigation issue.
I have question for you,
I am using WinUI 3 template studio (
https://marketplace.visualstudio.com/items?itemName=TemplateStudio.TemplateStudioForWinUICs
)
and I build two or tree blank pages.
I understand how NavigationView works but I would like to use button click
in order to open some page regardless to NavigationView  proces.
For example if I have LogIn page I need button click to redirect user to
some page or when I have List View of person I need to select some person
end open it in ne detail page.
Do you have some similar example or link of course or web page where I can
learn this, thanks.
On Mon, Jul 31, 2023 at 10:03 AM Karol @.***> wrote:

Closed #3
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#event-9960589374,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI7UOMR6EESLHNZW5GX6XADXS5RGXANCNFSM6AAAAAAQ25EIC4
.
You are receiving this because you were mentioned.Message ID:
<KWodarczyk/UwpWinUI3PageMVVMNavigation/issue/3/issue_event/9960589374@
github.com>

--
Božo Skopljaković

Hi, if you just need to switch to different Page that is not part of
NavigationView just look at the PageOneViewModel and switching to SubPageOne
Hope that helps
śr., 2 sie 2023, 10:13 użytkownik bos1313 @.***>
napisał:

Hi, Karol,
first of all thanks for your generous help regarding to navigation issue.
I have question for you,
I am using WinUI 3 template studio (
https://marketplace.visualstudio.com/items?itemName=TemplateStudio.TemplateStudioForWinUICs
)
and I build two or tree blank pages.
I understand how NavigationView works but I would like to use button click
in order to open some page regardless to NavigationView proces.
For example if I have LogIn page I need button click to redirect user to
some page or when I have List View of person I need to select some person
end open it in ne detail page.
Do you have some similar example or link of course or web page where I can
learn this, thanks.
On Mon, Jul 31, 2023 at 10:03 AM Karol @.***> wrote:

Closed #3
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3 as
completed.
—
Reply to this email directly, view it on GitHub
<
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#event-9960589374>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AI7UOMR6EESLHNZW5GX6XADXS5RGXANCNFSM6AAAAAAQ25EIC4>

.
You are receiving this because you were mentioned.Message ID:
<KWodarczyk/UwpWinUI3PageMVVMNavigation/issue/3/issue_event/9960589374@
github.com>

--
Božo Skopljaković
—
Reply to this email directly, view it on GitHub
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#issuecomment-1661720998,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIAELT7HWMGUWXWTRWJULDXTID3HANCNFSM6AAAAAAQ25EIC4
.
You are receiving this because you modified the open/close state.Message
ID: @.***
com>

Thank you very much Karol,
your help is much appreciated and your example works fine, I just had doubt
is this right approach in my case.
I'll try incorporate your example in my solution and I hope this will work.
Thanks and have a nice day.
On Wed, Aug 2, 2023 at 11:02 AM Karol @.***> wrote:

Hi, if you just need to switch to different Page that is not part of
NavigationView just look at the PageOneViewModel and switching to
SubPageOne
Hope that helps
śr., 2 sie 2023, 10:13 użytkownik bos1313 @.***>
napisał:

Hi, Karol,
first of all thanks for your generous help regarding to navigation
issue.
I have question for you,
I am using WinUI 3 template studio (

https://marketplace.visualstudio.com/items?itemName=TemplateStudio.TemplateStudioForWinUICs

)
and I build two or tree blank pages.
I understand how NavigationView works but I would like to use button
click
in order to open some page regardless to NavigationView proces.
For example if I have LogIn page I need button click to redirect user to
some page or when I have List View of person I need to select some
person
end open it in ne detail page.
Do you have some similar example or link of course or web page where I
can
learn this, thanks.
On Mon, Jul 31, 2023 at 10:03 AM Karol @.***> wrote:

Closed #3
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3
as
completed.
—
Reply to this email directly, view it on GitHub
<

https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#event-9960589374>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AI7UOMR6EESLHNZW5GX6XADXS5RGXANCNFSM6AAAAAAQ25EIC4>

.
You are receiving this because you were mentioned.Message ID:
<KWodarczyk/UwpWinUI3PageMVVMNavigation/issue/3/issue_event/9960589374@
github.com>

--
Božo Skopljaković
—
Reply to this email directly, view it on GitHub
<
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#issuecomment-1661720998>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABIAELT7HWMGUWXWTRWJULDXTID3HANCNFSM6AAAAAAQ25EIC4>

.
You are receiving this because you modified the open/close state.Message
ID: @.***
com>

—
Reply to this email directly, view it on GitHub
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#issuecomment-1661819318,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI7UOMVHV4OCS2ABF4AY4UTXTIJRBANCNFSM6AAAAAAQ25EIC4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Božo Skopljaković

Hi, Karol
I solved my problem with your example, thanks.
I have additional question, sorry for bothering you,
I am trying to trigger in WinUI 3 Mouse Over event but without success,
this is my code in WinUI that is similar to code that works fine in WPF
<i:Interaction.Behaviors>
<ic:EventTriggerBehavior
EventName="SelectionChanged">
<ic:InvokeCommandAction Command="{Binding}"
CommandParameter="{Binding SelectedItem, ElementName=ListView1}" />
</ic:EventTriggerBehavior>
</i:Interaction.Behaviors>
I need solution when I mouse hover on ListView that trigger selected item.
Thanks
Best Regards
On Wed, Aug 2, 2023 at 11:02 AM Karol @.***> wrote:

Hi, if you just need to switch to different Page that is not part of
NavigationView just look at the PageOneViewModel and switching to
SubPageOne
Hope that helps
śr., 2 sie 2023, 10:13 użytkownik bos1313 @.***>
napisał:

Hi, Karol,
first of all thanks for your generous help regarding to navigation
issue.
I have question for you,
I am using WinUI 3 template studio (

https://marketplace.visualstudio.com/items?itemName=TemplateStudio.TemplateStudioForWinUICs

)
and I build two or tree blank pages.
I understand how NavigationView works but I would like to use button
click
in order to open some page regardless to NavigationView proces.
For example if I have LogIn page I need button click to redirect user to
some page or when I have List View of person I need to select some
person
end open it in ne detail page.
Do you have some similar example or link of course or web page where I
can
learn this, thanks.
On Mon, Jul 31, 2023 at 10:03 AM Karol @.***> wrote:

Closed #3
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3
as
completed.
—
Reply to this email directly, view it on GitHub
<

https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#event-9960589374>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AI7UOMR6EESLHNZW5GX6XADXS5RGXANCNFSM6AAAAAAQ25EIC4>

.
You are receiving this because you were mentioned.Message ID:
<KWodarczyk/UwpWinUI3PageMVVMNavigation/issue/3/issue_event/9960589374@
github.com>

--
Božo Skopljaković
—
Reply to this email directly, view it on GitHub
<
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#issuecomment-1661720998>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABIAELT7HWMGUWXWTRWJULDXTID3HANCNFSM6AAAAAAQ25EIC4>

.
You are receiving this because you modified the open/close state.Message
ID: @.***
com>

—
Reply to this email directly, view it on GitHub
https://github.com/KWodarczyk/UwpWinUI3PageMVVMNavigation/issues/3#issuecomment-1661819318,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI7UOMVHV4OCS2ABF4AY4UTXTIJRBANCNFSM6AAAAAAQ25EIC4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Božo Skopljaković


[Documentation Error] Documentation Changelog

At Documentation Changelog, the link to CustomArgument goes to https://jorelali.github.io/1.13-Command-API/customarguments.md which does not exist.
Proposed fix
Should be changed to https://jorelali.github.io/1.13-Command-API/customarguments.html

Fixed in https://github.com/JorelAli/1.13-Command-API/commit/d950492582f5624b430d14ae67ef98b050844063 .


initialPage does not work on Android with Hermes

Current Behavior
initialRouteName don't work. Or scrolling to first route. Problem only on Android with Hermes (no problem on iOS with Hermes).
Expected Behavior
Tabs should open specified initialRouteName on init.
How to reproduce
https://github.com/Bardiamist/initialRouteRame
Your Environment
software	version
iOS or Android	Android (Checked on Android 11 simulator)
@react-navigation/native	5.9.3
@react-navigation/material-top-tabs	5.3.14
react-native-tab-view	3.0.0
react-native	0.64.0
expo	-
node	15.12.0
npm or yarn	yarn 1.22.10

Original post: https://github.com/react-navigation/react-navigation/issues/9435#issuecomment-802644853

same issue

same issue

This works for me:
https://github.com/callstack/react-native-pager-view/blob/master/src/PagerView.tsx#L64
@@ -61,7 +61,9 @@ export class ViewPager extends React.Component<ViewPagerProps> {
     // On iOS we do it directly on the native side
     if (Platform.OS === 'android') {
       if (this.props.initialPage != null) {
-        this.setPageWithoutAnimation(this.props.initialPage);
+        requestAnimationFrame(() => {
+          this.setPageWithoutAnimation(this.props.initialPage);
+        })
       }
     }
   }

I was encountering the same behavior, the fix suggested by @KusStar seems to work

The proposed fix leads to another issue. Now the first page is visible before it skips to the initialPage.

I don't think this change comes from using Hermes. I can reproduce it with JSC too. It seems like when upgrading to 0.64 (from 0.63.4) the order of calling addView and receiveCommand in PagerViewViewManager is changed.

Since I cant upgrade to rn-pager-view v5 at the moment (facebook/react-native#31245 happens with rn64 & pager-view v5, but not v4), I have patched v4 to fix the problem without a flash of the first page. Maybe someone wants to port this to v5:
diff --git a/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPager.java b/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPager.java
index d2ca9b0..d4f5bd1 100644
--- a/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPager.java
+++ b/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPager.java
@@ -144,6 +144,8 @@ public class ReactViewPager extends VerticalViewPager {
   private final EventDispatcher mEventDispatcher;
   private boolean mIsCurrentItemFromJs;
   private boolean mScrollEnabled = true;
+  private int mInitialPage = 0;
+  private boolean mInitialPageWasSet = false;

   public ReactViewPager(ReactContext reactContext) {
     super(reactContext);
@@ -212,6 +214,12 @@ public class ReactViewPager extends VerticalViewPager {
   @Override
   protected void onAttachedToWindow() {
     super.onAttachedToWindow();
+
+    if (!mInitialPageWasSet) {
+      setCurrentItemFromJs(mInitialPage, false);
+      mInitialPageWasSet = true;
+    }
+
     // The viewpager reset an internal flag on this method so we need to run another layout pass
     // after attaching to window.
     this.requestLayout();
@@ -228,6 +236,10 @@ public class ReactViewPager extends VerticalViewPager {
     }
   };

+  /*package*/ void setInitialPage(int initialPage) {
+    mInitialPage = initialPage;
+  }
+
   /*package*/ void addViewToAdapter(View child, int index) {
     getAdapter().addView(child, index);
   }
diff --git a/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPagerManager.java b/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPagerManager.java
index f8a4cb7..7a98e14 100644
--- a/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPagerManager.java
+++ b/node_modules/react-native-pager-view/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPagerManager.java
@@ -146,4 +146,9 @@ public class ReactViewPagerManager extends ViewGroupManager<ReactViewPager> {
         pager.setOffscreenPageLimit(offscreenPageLimit);
     }

+    @ReactProp(name = "initialPage")
+    public void setInitialPage(ReactViewPager pager, int initialPage) {
+        pager.setInitialPage(initialPage);
+    }
+
 }
diff --git a/node_modules/react-native-pager-view/src/ViewPager.tsx b/node_modules/react-native-pager-view/src/ViewPager.tsx
index 5a413b3..a118a66 100644
--- a/node_modules/react-native-pager-view/src/ViewPager.tsx
+++ b/node_modules/react-native-pager-view/src/ViewPager.tsx
@@ -57,15 +57,6 @@ export class ViewPager extends React.Component<ViewPagerProps> {
   private isScrolling = false;
   private viewPager = React.createRef<typeof ViewpagerViewManager>();

-  componentDidMount() {
-    // On iOS we do it directly on the native side
-    if (Platform.OS === 'android') {
-      if (this.props.initialPage != null) {
-        this.setPageWithoutAnimation(this.props.initialPage);
-      }
-    }
-  }
-
   public getInnerViewNode = (): ReactElement => {
     return this.viewPager.current!.getInnerViewNode();
   };

Thank you @danilobuerger - I patch-packaged your change and it fixed this issue for me. - initial page was not appearing on launch after upgrading to react-native 0.64.

@danilobuerger
Thank you!
I had the same issue, but i couldn't upgrade to version 5 because i'm using pager-view with webviews and in Android the vertical scroll from the webview conflicts with the scroll from the pager view.


Fixed-#25 Splits is_binary into multiple functions

Is that ok to merge?

@theodesp a few comments:

why mark these functions as "private, underscore prefixed?
if we were to split this in smaller functions, would it make sense to update the tests accordingly?


Rename Timer::{percent,percent_left} to Timer::{fraction,fraction_remaining}

Objective
Fixes #10439
Timer::percent() and Timer::percent_left() return values in the range of 0.0 to 1.0, even though their names contain "percent".
These functions should be renamed for clarity.
Solution

Rename Timer::percent() to Timer::fraction()
Rename Timer::percent_left() to Timer::fraction_remaining()

Changelog
Changed

Renamed Timer::percent() to Timer::fraction()
Renamed Timer::percent_left() to Timer::fraction_remaining()

Migration Guide

Timer::percent() has been renamed to Timer::fraction()
Timer::percent_left() has been renamed to Timer::fraction_remaining()

While we're renaming, why not name it Timer::fraction_remaining()?

0.12 release just added Time<Fixed>::overstep_percentage and Time<Fixed>::overstep_percentage_f64, which similarly return a normalized value in the range 0.0 to 1.0. It seems like they should become overstep_fraction to match.
Should that be included in this PR or should it be another one?

#10448 will rename overstep_percentage(_f64).


Develop

Ready for deployment

Coverage remained the same at 67.508% when pulling a5693bb2e56cbfb3b443d5b1cf9ac7bcdfdc9759 on WolfBerwouts:develop into 1b4bc37f9a40024de7a0a4a5d3f2a31a2ac2b3be on opengridcc:develop.

Coverage remained the same at 67.508% when pulling 57bbd8951e5c341344c48c9144c33eba2a3fd3bb on WolfBerwouts:develop into 1b4bc37f9a40024de7a0a4a5d3f2a31a2ac2b3be on opengridcc:develop.


Can't update record

When trying to update a record for a simple class, I am getting the following error message:
MultiTenantException: 1 modified entities with TenantId not set.
Looking directly at the database, I can see that the TenantID is set just fine when the record was created.
Any ideas why this may be happening?

Hi @ericsports
It might be set in the database but for some reason the entity in memory doesn’t have it set. Can you link me to a simple project that recreates the problem? I’d be happy to take a look.

@achandlerwhite Thanks for the reply, I have sent you a message with the project attached.

Thanks @ericsports I got the project. I was able to start it up and run it. I did change the Sql Server database to use the in-memory variant because I'm on a Mac (haven't tried setting up Sql Server on it yet).
I see you have the localhost resolving to the "baxter" tenant. I am able to register a user with Identity and was able to update the phone number for that user.
What was it in the app that triggered the error message for you?

Thanks for looking at it!  It was the SiteSettings found in the models folder (there is already a controller set up, you can access it at /SiteSettings)
I can create new ones, delete them, but if I go to edit and save, that's when I got the error.

Thanks. I will take a look tomorrow.

Thanks @achandlerwhite , appreciate it!

I've gone ahead and downloaded the actual samples and tried to add a simple class (with proper annotation) to that and scaffold it as well.  Same outcome directly from the samples, can create, can delete, but get that same error when trying to update.

Hi again, I see the issue.
Because you are using _context.Update(siteSettings) to do a direct update the tenant id is not set on the "untracked" entity because tenant id is a shadow property in EFCore.
You have a few options:

Use TenantNotSetMode.Overwrite will will plug in the tenant Id when saving. Note that this settings will be in effect for any future saves on the same dbcontext in the request.

_context.TenantNotSetMode = TenantNotSetMode.Overwrite;
_context.Update(siteSettings);
await _context.SaveChangesAsync();

You can add a property to the SiteSettings class called TenantId which Finbuckle.MultiTenant will use, then if you make sure it gets passed around in the Get/Post requests the tenant Id should be there when you call Update and SaveChanges.

Avoid using Update and instead get the entity from the database via EFCore then update this "tracked" entity, then save it.

var siteSettings = await _context.SiteSettings.FirstOrDefaultAsync(m => m.Id == id);
siteSettings.Prop1 = model.Prop1;
siteSettings.Prop2 = model.Prop2;
// etc..
await _context.SaveChangesAsync();

I think 1) is probably the best way to go here.

Thanks for the explanation, really appreciate your help.


Display Current Week Number

I want to see the current week number on the display.

[ ] Setup main.py
[ ] Display number to screen
[ ] Fetch week number from World Time API
[ ] Sleep for an hour


Resample mask error

Hello, I reveived this warning and error in the preprocessing stage. This is due to the resample process that make some instances disappear?
2021-07-19 15:06:43.138 | WARNING  | nndet.planning.properties.instance:instance_class_and_region_sizes:213 - Instance lost. Found {1: 0, 2: 0, 3: 0, 4: 0} in properties but [1 2 3] in seg of 1_2_840_113654_2_55_446543879.
Thanks

When I read the code, it seems like at this stage the only thing was done is to read image and save back to npz, so what cause is the reason of instance missing??

Hi @vankhoa21991 ,
can you double check that specific case for any anomalies (e.g. wrong segmentation mask, wrong label json, data corruption due to an error during a copy process)? Since the warning is raised in the analysis phase no resampling was performed until that point. The case was only cropped to the non-zero regions so all instances should be present during analysis. (Sometimes if the data is corrupted, large regions of the scan were zero and thus disappeared in the cropping stage).
You are right that small objects can vanish during the resampling phase though (and that also happens sometimes). The message looks different then and can be found here https://github.com/MIC-DKFZ/nnDetection/blob/470ef323f90f14e120547d326bce46c5f90a9893/scripts/preprocess.py#L347-L350.
Best,
Michael


Rust-web3?

Hey, just found this project. It looks pretty similar in goals to https://github.com/tomusdrw/rust-web3.
Maybe we could join efforts on that?

(to be clear, the goal of a CLI is beyond the scope rust-web3, but that could be quite easily done as a wrapper around the library, re-using the same internals)

@rphmeier thank you!
Emerald is actually bigger than just a wrapper, but wrapper is an important part. Unfortunately that project is under LGPL, which is incompatible with our goals. On other hand, maybe authors of that project can reuse our code, we're working on same tech anyway

@rphmeier yes, these projects are very very similar by concept, but in addition to the other licensing model (Apache 2.0 instead of LGPL-3.0) out main point is to borrow all private related things from parity and other clients, for example, wallets, adressbooks, transaction signs, details in our roadmap.


How did you build your training dataset?

In your Biorxiv paper, I don't understand the sentence:
'The final dataset contains 1434 sequences for the algo-
rithm to learn from (239 antibody/antigen complexes × 6
CDRs each).'
As I understood it, the antibody/antigen complex uses all the 6 CDRs together (H1-H3 and L1-L3) , so how did the training set grow from 239 to 1434 training samples?

Hi Mostafa,
No, the model treats CDRs as independent training samples (I know sounds
bizarre, but it turns out you can actually get good performance by
considering CDRs in isolation), so from N antibodies you get 6*N samples to
train / test on.
Edgar
On Thu, 5 Jul 2018 at 12:36 Mostafa Benhenda<EMAIL_ADDRESS>wrote:

In your Biorxiv paper, I don't understand the sentence:
'The final dataset contains 1434 sequences for the algo-
rithm to learn from (239 antibody/antigen complexes × 6
CDRs each).'
As I understood it, the antibody/antigen complex uses all the 6 CDRs
together (H1-H3 and L1-L3) , so how did the training set grow from 239 to
1434 training samples?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/eliberis/parapred/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADW4nfvLDyY-i56Q9Bz8vv-NH-TJ4FF-ks5uDfpNgaJpZM4VDuU9
.

Do you have the training data available with the annotation of contact or non-contact?
I tried looking in the data directory and the precomputed pickle, but did not find the information.


Unified Tensor class

Create turn Tensor to a generic class to unify function definition and evaluator interfaces.
Tensor to represent a symbolic tensor by default, optionally made concrete by initializing with an numpy array
class Tensor(Generic[T])
    @property
    def rank(self):
        ...
    ...

Usage
typing definition:
RealType = Union[
    BFLOAT16,
    FLOAT16,
    FLOAT,
    DOUBLE,
    INT8,
    INT16,
    INT32,
    INT64,
]

TReal = TypeVar("TReal", bound=RealType)

In function definition:
@torch_op("aten::add")
def aten_add(self: Tensor[TReal], other: Tensor[TReal], alpha: float = 1.0) -> Tensor[TReal]:
    # add.Tensor(Tensor self, Tensor other, *, Scalar alpha=1) -> Tensor
    if alpha != 1:
        other = op.Mul(other, alpha)
    return op.Add(self, other)

Traced only functions:
@torch_op("aten::transpose", trace_only=True)
def aten_transpose(self: Tensor[Any], dim0: int, dim1: int):
    # transpose.int(Tensor(a) self, int dim0, int dim1) -> Tensor(a)

    # Use the Tensor API
    self_rank = self.rank

    if self_rank == 0:
        result = self
    else:
        # Python code, change when onnxscript supports this
        dims = list(range(self_rank))
        dims[dim0], dims[dim1] = dims[dim1], dims[dim0]
        # Python code ends

        result = op.Transpose(self, perm=dims)

    return result

Evaluators operate on concrete Tensors
cc @gramalingam @fatcat-z @xiaowuhu @BowenBao @titaiwangms @abock

Is it possible to annotate dimensions?
What if the tensor type needs to be a subset (superset, intersection, etc) of RealType?
Related to type system, what's the difference between INT64 and int? Can we make it interchangeable?

I have the same question. A parametric Tensor type would be perfect, the main question is whether we enable a way to specify dimensions. I thought there was an earlier proposal to use multiple generic-parameters when it becomes available?

Shapes is a little tricky with Generics, as explored in https://github.com/microsoft/onnx-script/pull/228#issuecomment-1335719316. Tensor[INT64["M", 42]] seems to be the most realistic in this pre Python 3.11 world. Functions with typevars tend not the need shaping annotations.
They can define a different typevar: https://github.com/microsoft/onnx-script/blob/dfaf174a7efaee415223dc628859f7c11318d1f6/onnxscript/function_libs/torch_aten/typing.py#L56-L66
I think we can treat them as the same with the proposed generics system. INT64 however is less ambiguous, because int on windows is int32 it seems.

Re @BowenBao 's question:

what's the difference between INT64 and int?

In the existing system, INT64 represents a tensor (with int64 element types). In the proposed system, we should really say Tensor[int64] instead of Tensor[INT64]. (Just a minor point, once we decide what to do.)

Tensor[TReal, Shape["M", 1]] # Shape can be a non-generic with __class_get_item__ defined; mypy will still fail
Tensor[TReal, "M", 1]] # Supported only after 3.11
Tensor[TReal, Literal["M"], Literal[1]]] # mypy will not fail but it will also not do anything useful

@torch_op("aten::add",
    shape={
        "self": ("M", "N"),
    }
)
def aten_add(self: Tensor[TReal], other: Tensor[TReal], alpha: float = 1.0) -> Tensor[TReal]:

cons: verbose, duplication

It could be great to able to indicate the output is of the exact same type of the input, not only real.

It could be great to able to indicate the output is of the exact same type of the input, not only real.

Yes. This is why I think typevars are great

Another option for shapes might be:
Annotated[Tensor[TReal], Shape["M", 1]]  # a bit more verbose version of option 1 above

Yes, using type-vars to indicate type-constraints is useful. One issue @abock ran into using type-vars (in his generation of signatures for all ONNX  ops) was getting intellisense to be useful for usage of type-vars. May not be an issue if we use predefined vars like TReal that have a standardized meaning.
Another detail: using Tensor[TReal] would mean that we switch to using TReal to mean the element-types. This is doable (except for types like bfloat16/float16 which may not be well-supported), but just mentioning it.

Yes, type-vars in Python typing bring much from the world of traditional generics ala C# - we can express those constraints.
I think it's worth revisiting seeing exactly which distinct type unions fall out of the codegen and use that to inform what our generic unions could be and how they could be named. With sensible naming, the IntelliSense issue may be acceptable today, and I expect rich support for typings in the IDEs to improve over time as well.

I suggest we go with Tensor[TReal, Shape["M", 1]], where shape is Optional. Shape will not be a generic type but instead be a normal type with __class_get_item__ defined. This way we get python <3.11 to allow constructs like Shape["M", 1]

Will the use of strings (like "M") work with mypy (which used to complain about this ... it allowed int constants, but not string constants, as "dependent types")

It will still fail mypy the same way we do now

https://github.com/microsoft/onnxscript/issues/217

Also reference: https://github.com/google/jaxtyping


Test aarch64

wheel builds are green 🎉  https://github.com/ddelange/asyncpg/actions/runs/3072698535

closing in favour of https://github.com/MagicStack/asyncpg/pull/954


Add files via upload

@BineBolcina file/lib/domains/org/tscng.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@BineBolcina Please provide us with a proof, which shows that the school recognizes the domain tscng.org that you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@BineBolcina You might miss my previous comment. Please react.

@BineBolcina I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!

@BineBolcina Please provide us with a proof, which shows that the school recognizes the domain tscng.org that you are submitting as an official email domain for the students. You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

Hello, I apologise for not seeing your comment earlier,
I am sending you the WHOIS links of the school:
https://www.whois.com/whois/tscng.org
https://who.is/whois/tscng.org


Disabling iptables in docker service

As I see here this code
opts << '--iptables=true' if iptables

does nothing if iptables is set to false.
This lead me to assume that --iptables=false is the default option, however, looking at the docker docs, it seems that this is not the case...?

Do your iptables allow this particular connection? Docker will never make changes to your system
iptables rules if you set --iptables=false when the daemon starts. Otherwise the Docker server will
append forwarding rules to the DOCKER filter chain.

am I missing something here guys?

awesome!! thanks @someara ! ;)


Code looks overcommented

This may be none of my business, but I think the huge part of comments in this project doesn't make sense because the code is already obvious. They explain nothing and don’t help. Just a noise. My advice is get rid of them. What do you think?
Like this:

Or this:

@zenwalker Sounds good to me!


Adjust several log lines

Drop two that provide nearly no value that have been copy/pasted around since the early days of Knative controllers.
Reduce the CloudEvents log statement to debug level.
Add a log statement to the path where PipelineRun updates the TaskRun status.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

cc @afrittoli (IIRC you care most about things touching CE)

/lgtm

/retest


Emote Search

From what I can tell there is no feature to allow for searching emotes.
It's tedious scrolling through all the emotes to find the one you are looking for (if you don't remember what it's called or it's spelling) what I would recommend is something like the search that exists on the PC version, where you are given an option to search, filtering out emotes that don't match.

See https://github.com/bttv-android/bttv/issues/454#issuecomment-1107645392

Thank you!


Replace clock_ticks with std::time

Oh wow. I never noticed that clock_ticks had been deprecated. Thanks for the pull request.


missing AndroidManifest.xml when building

Android target : 19
I don't really know which other information could be relevant.
BUILD FAILED
E:\Development\Android SDK\tools\ant\build.xml:577: com.android.io.StreamException: java.io.FileNotFoundException: E:\PROJETS\Tarmac\TMM\bin\android\bin\deps\google-play-services_lib\AndroidManifest.xml (Le fichier spécifié est introuvable)
    at com.android.io.FileWrapper.getContents(FileWrapper.java:93)
    at com.android.xml.AndroidManifest.getStringValue(AndroidManifest.java:410)
    at com.android.xml.AndroidManifest.getPackage(AndroidManifest.java:146)
    at com.android.ant.ComputeDependencyTask$1.processLibrary(ComputeDependencyTask.java:198)
    at com.android.ant.DependencyHelper$AdvancedLibraryProcessor.processLibrary(DependencyHelper.java:69)
    at com.android.ant.DependencyHelper.processLibraries(DependencyHelper.java:210)
    at com.android.ant.GetLibraryPathTask.execute(GetLibraryPathTask.java:183)
    at com.android.ant.GetLibraryPathTask.execute(GetLibraryPathTask.java:162)
    at com.android.ant.ComputeDependencyTask.execute(ComputeDependencyTask.java:226)
    at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
    at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
    at org.apache.tools.ant.Task.perform(Task.java:348)
    at org.apache.tools.ant.Target.execute(Target.java:435)
    at org.apache.tools.ant.Target.performTasks(Target.java:456)
    at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393)
    at org.apache.tools.ant.Project.executeTarget(Project.java:1364)
    at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
    at org.apache.tools.ant.Project.executeTargets(Project.java:1248)
    at org.apache.tools.ant.Main.runBuild(Main.java:851)
    at org.apache.tools.ant.Main.startAnt(Main.java:235)
    at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
    at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)
Caused by: java.io.FileNotFoundException: E:\PROJETS\Tarmac\TMM\bin\android\bin\deps\google-play-services_lib\AndroidManifest.xml (Le fichier spécifié est introuvable)
    at java.io.FileInputStream.open(Native Method)
    at java.io.FileInputStream.<init>(FileInputStream.java:120)
    at com.android.io.FileWrapper.getContents(FileWrapper.java:91)
    ... 24 more

Total time: 0 seconds
Build halted with errors.

Hi, did you downloaded google play services from your android package manager (see: https://github.com/SempaiGames/openfl-gpg#how-to-install)
Also, make sure you're using openfl-legacy (since openfl-next does not support android extensions using JNI yet).

I do have google play services downloaded.
I'll look into the all legacy/next suggestion monday (it's on my work computer).
Thanks!

Hi again,
So far no change.
I'll try to give you as much information I can.
These are my libraries installed and there versions:
actuate: [1.8.6]
extension-nativedialog: [1.2.1]
ganalytics: [0.0.3]
HaxePunk: 2.5.5 [2.5.6]
hxcpp: [3.2.102]
lime-samples: 2.3.0 [2.5.1]
lime: 2.4.3 2.4.5 [2.5.2]
openfl-gpg: [1.3.0]
openfl-gps-lib: 1.0.3 [1.0.4]
openfl-ouya: [1.0.2]
openfl-unityads: [1.0.3]
openfl: 3.1.1 [3.2.2]
These are the installed packages:

These are the files in my bin folder for my haxepunk project:

This is my project.xml:

<app file="Hareport - Crazy flights" main="Main" path="bin" />

<certificate path="**********" alias="*********" password="*******" if="android" unless="debug"/>

<window fps="60" background="0x333333" />
<window width="960" height="540" resizable="true" unless="mobile" />
<window fullscreen="true" if="mobile" />
<window orientation="landscape" vsync="true" antialiasing="0" if="cpp" />

<source path="src" />

<haxelib name="HaxePunk" />
<haxelib name="Actuate" />
<haxelib name="openfl-unityads" />
<haxelib name="ganalytics" />
<haxelib name="openfl-gps-lib" />
<haxelib name="openfl-gpg" />
<haxelib name="extension-nativedialog" />

<assets path="assets/shaders" rename="shaders" include="*.vert|*.frag" />
<assets path="assets/graphics" rename="graphics" include="*.png|*.jpg" />
<assets path="assets/audio" rename="audio" include="*.mp3" if="flash" />
<assets path="assets/audio" rename="audio" include="*.wav|*.ogg" unless="flash" />
<assets path="assets/font" rename="font" include="*.ttf" />

<setenv name="GOOGLE_PLAY_GAMES_ID" value="************" />

<set name="openfl-legacy" />

<android target-sdk-version="19" />

<icon path="assets/HaxePunk.svg" />

And I'm not sure what I can add :\

Hi, just in case: Can you check that the SDK you're using to download the Google Play Services Lib is the same that OpenFL is using to build the project?
Another option is to manually add the required files to your project: In your case, you should be able to copy the files in "E:\Development\Android SDK\extras/google/google_play_services/libproject/google-play-services_lib" to your "bin/android/bin/deps/google-play-services_lib".

...
I'm so sorry.

Never mind :) Glad you fixed it!


Add ch region tests

Description
Please include a summary of the change and which issue is fixed.
Type of change

[ ] Internal refactoring
[ ] Bug fix (bugfix - non-breaking)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets
In case of new feature or breaking changes, please include code snippets.

I'll look to better reuse some of this too, be it matrix or reusable actions, but if there are obvious paths there, feel free to make suggestions on this pr still.


My images  display error

Expected behavior
In CLI
$ docker images
harbor.shuziguanxing.com/develop/nginx      latest              28ce8b992d57        4 minutes ago       31.9MB
harbor.shuziguanxing.com/develop/java      latest              28ce8b992d57        4 minutes ago       222.9MB

Actual behavior
In Kitematic

Information about the Issue
Need to show two image on the 'My Images' page

Kitematic Version: 0.17.2
Os Version: MacOs Mojave 10.14.1


Support redux v4

When installing redux-little-router in a project using<EMAIL_ADDRESS>I get the following warning:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

Same here. A compat. check and/or update would be great.
In the meantime I'm gonna see if I run into any issues with redux 4 and little-router 15 myself.

Hey folks, as of December 10, 2018, this project is no longer under active maintenance and we will no longer be moving forward with issue requests. Thank you for helping to make redux-little-router better!


Error occured after install plugin

I made custom plugin and comment out the Dockerfile line below.
# install plugins if necessary
# ;;
# ;; NOTE: In GROWI v3 and later,
# ;;       2 of official plugins (growi-plugin-lsx and growi-plugin-pukiwiki-like-linker)
# ;;       are now included in the 'weseek/growi' image.
# ;;       Therefore you will not need following lines except when you install third-party plugins.
# ;;
RUN echo "install plugins" \
 && yarn add \
     growi-plugin-XXX \
     growi-plugin-YYY \
 && echo "done."
# you must rebuild if install plugin at least one
RUN npm run build:prod

after build the container, I saw below error in my growi top directory.
Error occured in mt
TypeError: Cannot convert undefined or null to object
詳細
    in mt
    in t
    in ForwardRef
    in div
    in div
    in $t
    in t
    in ForwardRef
    in div
    in div
    in p
    in div
    in t
    in $n
    in t
    in ForwardRef
    in p
    in i
    in B

how can i fix it?

@ryoma310
As you can see in the NOTE, GROWI v3 or later includes official plugins.
So you can leave the codes commented out.

@ryoma310

I made custom plugin

Oh, sorry, I coudn't realize your comment.
Coud you setup development environment?
https://docs.growi.org/en/dev/startup-v2/dev-env.html
Dev environment will dump more detail errors.
Further more, if you can read Japanese, docs for developing plugins are here.
https://docs.growi.org/ja/dev/plugin/architecture.html

thank you for reply!
I just pull and rename your growi-plugin-boilerplate repository, and upload to my repository.
After that, add yarn add username/repository to Dockerfile and rebuild by docker-compose.
I think this error comes from version inconsistency of package.json.
(I also rename the path in src/client/js/components/Foo.jsx)
I haven't setup the development environment.
I will try it and read the documents! thank you!


Do not require explicit casting for small comptime literals that can fit in a typed integer

Currently we emit an error if we attempt to pass a comptime literal to be formatted.
printf("{}", 5);
error: parameter of type '(integer literal)' requires comptime

This example requires that the 5 be explicitly cast to an integer of specified size before we can actually print.
printf("{}", u64(5));

Often, we just want any readable value we can so we could instead check whether the literal fits into the range of a specific large integer type (i.e. u64) and cast within the printf routine.
This proposal suggest doing automatic casting within printf in order to simplify and make code clearer. Also note we have a similar issue for floats, however casting/narrowing there is likely a bit more nuanced in respect to preserving precision.
The following would compile and work if accepted.
printf("{}", 5);

Why not simply consider the integer to have a type equal to the smallest type capable of representing this integer when passed through a function call? 5 would assume the type u3 (or u8 if it's more useful internally for the compiler) when passed into the variadic component of fmt.format.
The advantage of this is that this issue is fixed across the breadth of the language, rather than just the narrow case of fmt.format in std.

See also #137

I think this can be fixed without casting number literals (soon to be renamed to comptime_int or maybe even just int #556)
I think there's a place in the compiler where we disallow an comptime int as a var args parameter, but we can remove this restriction.


update platform-editor

basic commenting feature
no comments on Resources
add and remove ephemeral annotations
set selection

This change is

assets-excluded/custom.sty line 14 at r1 (raw file):
Previously, tjcouch-sil (TJ Couch) wrote…
I'm curious - what does this stand for?

z (custom markers all start with 'z' according to spec) ms (milestone) c (comment) -s (milestone pairs start with '-s' and close with '-e' according to spec)

extensions/src/platform-scripture-editor/src/_commenting.scss line 573 at r1 (raw file):
Previously, tjcouch-sil (TJ Couch) wrote…
Does this url actually work? I would have expected you would have to set it to a papi-extensions

No, all the SCSS files are copied from the BNF repo mostly as is but we override the image urls in the _editor-overrides.scss file (that's its primary purpose). This makes it easier to compare and update the other copied SCSS files.


Docker run issue.

Good day. I'm Sean, a uni student trying to follow through this very impressive work. But i have faced a problem which i was looking at for a week but still couldn't solve it.
So, I was following through this ipython-soccer-predictions project.
I did
gcloud compute instances create ipy-predict \
  --image https://www.googleapis.com/compute/v1/projects/google-# containers/global/images/container-        vm-v20140522 \
  --zone=us-central1-a --machine-type n1-standard-1 --scopes storage-ro bigquery

which was successful and it created a VM instance named ipy-predict.
Then since gcutil doesn't work any more, i typed in
gcloud compute ssh osy044_googlemail_com@ipy-predict --zone=us-central1-a

This connected to the VM instance that i have just created.
Then on VM instance, i typed in
docker run fhoffa/ipython-predictions:v1

Then it gives the the following error and it stops running.
2015-07-18 09:14:57,874 WARN Included extra file "/etc/supervisor/conf.d/supervisord-ssh.conf" during parsing
2015-07-18 09:14:57,874 WARN Included extra file "/etc/supervisor/conf.d/supervisord-extra.conf" during parsing
2015-07-18 09:14:57,874 WARN Included extra file "/etc/supervisor/conf.d/supervisord-ipython.conf" during parsing
2015-07-18 09:14:57,894 INFO RPC interface 'supervisor' initialized
2015-07-18 09:14:57,894 CRIT Server 'inet_http_server' running without any HTTP authentication checking
2015-07-18 09:14:57,895 INFO RPC interface 'supervisor' initialized
2015-07-18 09:14:57,895 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2015-07-18 09:14:57,895 INFO supervisord started with pid 1
2015-07-18 09:14:58,897 INFO spawned: 'ipython' with pid 12
2015-07-18 09:14:58,898 INFO spawned: 'sshd' with pid 13
2015-07-18 09:14:58,899 INFO spawned: 'gitpull-predictions' with pid 14
2015-07-18 09:14:59,629 INFO exited: gitpull-predictions (exit status 0; not expected)
2015-07-18 09:15:00,630 INFO success: ipython entered RUNNING state, process has stayed up for > than 1 seconds (sta
rtsecs)
2015-07-18 09:15:00,631 INFO success: sshd entered RUNNING state, process has stayed up for > than 1 seconds (starts
ecs)
2015-07-18 09:15:00,631 INFO spawned: 'gitpull-predictions' with pid 26
2015-07-18 09:15:00,635 INFO exited: gitpull-predictions (exit status 128; not expected)
2015-07-18 09:15:02,645 INFO spawned: 'gitpull-predictions' with pid 27
2015-07-18 09:15:02,651 INFO exited: gitpull-predictions (exit status 128; not expected)
2015-07-18 09:15:05,657 INFO spawned: 'gitpull-predictions' with pid 28
2015-07-18 09:15:05,664 INFO exited: gitpull-predictions (exit status 128; not expected)
2015-07-18 09:15:06,665 INFO gave up: gitpull-predictions entered FATAL state, too many start retries too quickly

I have checked the supervisord config file and the log files too.
The log file says
fatal: destination path '/home/ipy/ipynotebooks/soccer' already exists and is not an empty directory.
fatal: destination path '/home/ipy/ipynotebooks/soccer' already exists and is not an empty directory.
fatal: destination path '/home/ipy/ipynotebooks/soccer' already exists and is not an empty directory.

It seems like the error is caused by restarting the gitpull-prediction over and over again without successfully running it. But im not sure exactly how to solve it. Is there any way to go through this problem?

@osy044 did you find its solution ? I am also facing this same issue

I've got the same problem... anyone find a fix?

Same problem, would love to see a solution for this issue

I have fixed the problem.
Instead of using dockers, I installed python & pandas on google VM, not on my PC. In that way i could import gbq from pandas.io and also improt other python modules on VM python & pandas. So then you can run the python code in this way and obtain the final results.
But i think i had other problems going through this work, for example, missing dll files or missing library files. Those files have to be downloaded separately.


Add zerion injected support

Where is it already supported? Anyway this issue is no really related to Lock anymore as we have deprecated it, will add it to https://github.com/snapshot-labs/sx-ui/issues/821


Implement Account Activity premium APIs

We've had multiple people ask for this (e.g. https://twitter.com/nicomo/status/947124468392120320).
I've applied for access, but I'm still waiting for my application to be approved.