How to use custom sorting

Is there some way to replace the sorting algo without having to fork the package?
The sorting is quite janky with a few data sets I tested and _.orderBy(data, key, direction) delivers exactly the sorting I expect so I was wondering if there is some way to tell the package to use a custom sorting method.

I am currently replacing return this.rows.sort(sortColumn.getSortPredicate(this.sort.order, this.columns)); with return _.orderBy(this.rows, (row) => (row.data[sortColumn.show]), this.sort.order); here https://github.com/spatie/vue-table-component/blob/master/src/components/TableComponent.vue#L221 which requires me to have a local copy of the package.

An easy solution I quickly played with would be the following.
settings.js
const settings = {
    sortHandler: (rows, column, order) => {
        return _.orderBy(rows, (row) => (row.data[column]), order);
    }
};

TableComponent.vue
if (settings.sortHandler typeof Function) {
    return settings.sortHandler(this.rows, sortColumn.show, this.sort.order);
}

return this.rows.sort(sortColumn.getSortPredicate(this.sort.order, this.columns));

Looks like a clean and nice solution. Have you tried making a PR for that?


Change the layout of regex/regex_handler settings, possibly combine settings into one block?

You have to uncomment out the buffer size of the regex script in two different parts of terminus-bot.conf in order to enable the script, causing confusion for users who thought it was already enabled. Aka, line 288 configures the max buffer size, located near the top of the file, then again at line 614, near the bottom.

Would rather fix this with a README change, and possibly improved output on start (if the current output is not clear enough).


feat(cli): Adding hash command

related to #399
fixes #390

Squash commits

Squash commits

We can now squash and merge right from GitHub web interface, I'll do after approval.
Because it's a single commit.


ls-remote lists versions lexicographically and duplicates the list

Hey pretty cool project. Wanted to contribute by nitpicking a little bit 😄

As you can see here ls-remote result is duplicated and the version numbers are listed lexicographically. Ordering of the patch releases is not important but minor releases should be ordered according the numerical/semantic/release order.

Hi @Akaame
Thanks for raising this issue. I was aware of lexicographical order. I made an attempt but then left it as it is at the time of first release. I ll take your suggestion and fix up on the order.
Little history on my first attempt
As numeric was not possible - 1.16 was released after 1.6 while numerically 1.6 > 1.16
Release order is the way I wanted to do it but as --sort is not available on git versions < 2.0. And to be able to support older versions of git, it wasn't possible.
https://github.com/kevincobain2000/gobrew/blob/35d26fecd277d8fa2b1f401f6f453bf49697ea9b/gobrew.go#L104-L112
I ll look into semantic ordering.

Thanks, I have added semantic version sort for both gobrew ls and gobrew ls-remote in #10 and #11
Screenshots updated for ls-remote

This issue is fixed. For now, I had to remove beta and rc versions from the tool. Will look into ordering such in another pull req.
Screenshots


Officially "blessed" build environment and instructions are missing from build instructions

The BUILD.md file has extremely skeletal information on how to build the demos.
As requested in #819, it would be good to know what combinations of OS, compiler, and build tools have actually been used and tested.
For example, it was mentioned that ninja was never used, but clang was apparently used.  Clang normally would imply Linux; however, if we're talking Windows, it would be nice to know how clang was installed in order to match with what has been used.
Most people would be happy to match with the developers, but, to do that, we need to actually know what the developers are using.
Thanks.

There is no official build environment. I'm working on this repo in my spare time, mainly on Windows 10 with VS 2019. So that's my "official" environment.

Thanks.  That's really useful to know as I've been having build issues caused by 2019/2022 build tool confusions.
I'll set up a VM that is Win 10 and VS 2019.  Please do put it into the BUILD.md when you shift to something newer.
Thanks.


Audio Output Device Select Option missing

Hi,
Just like there exist an option to select microphone & camera from available list of microphones & cameras, option to select Audio Output Device from available list of Audio Output Devices like speakers, headphones, virtual output, etc etc.
Jitsi have this option so yeah its possible.

Yes, contributors are welcome to implement. You can also contribute by sending pull request.

Probably you'll need to follow: https://www.plugnmeet.org/docs/developer-guide/setup-development#troubleshooting


Split the CI for Cygwin into 2 jobs rather than 2 workflows

I finally found out that stating that the second job needs the first, it is not skipped. This allows us to get one workflow for the whole test suite on Cygwin (but unfortunately it can take quite some time, with 2 × 6 hours of timeout).

All green - for the first time in a while! I'll merge immediately :smile:


skeleton-typescript-webpack invalid package script tasks?

Correct me if I am wrong, but is there supposed to be double hyphens in the Npm scripts? seemingly they look like arguments with no values and they appear to break the tasks completely.
See here here here here here here here here and finally here

@niieani See above.

This is intentional @Vheissu. Passing parameters to the underlying task in NPM is done with the -- parameter. See official NPM docs for reference: https://docs.npmjs.com/cli/run-script.
Please close.


Automated cherry pick of #2607: natgateway bugfix

Cherry pick of #2607 on release/2.11.
#2607: natgateway bugfix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@1fd2fce). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2647   +/-   ##
==============================================
  Coverage                ?    7.1%
==============================================
  Files                   ?     464
  Lines                   ?   73414
  Branches                ?       0
==============================================
  Hits                    ?    5214
  Misses                  ?   67771
  Partials                ?     429

Flag
Coverage Δ

#aFlag
7.1% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/regiondrivers.go
20% <ø> (ø)

pkg/compute/models/vpcs.go
1.94% <0%> (ø)

pkg/compute/models/natgateways.go
3.47% <0%> (ø)

pkg/compute/models/natstable.go
3.89% <0%> (ø)

pkg/compute/models/natdtable.go
4.32% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd2fce...98128f1. Read the comment docs.


etcdctl: cluster-health

What is the replacement for this? etcdctl API 3 doesn't have it.

https://github.com/coreos/etcd/blob/master/etcdctl/README.md#endpoint-health

@heyitsanthony is right. It is replaced by endpoint-health, which provides more information about the cluster.


Thellier GUI Measurement Quality Branch

I have over the course of the last few months created a local branch of PmagPy where I worked on making Thellier GUI capable of marking measurement data bad by right clicking on the measurement record in the list on the left of the GUI. This makes Demag GUI and Thellier GUI more similar in the design of their user interaction which simplifies the UI, prevents the deletion of unwanted measurement data which is the current method to solve the lack of this feature, and allows the user to abstract another aspect of data analysis which is one of the goals of the GUIs. This new feature with the exception of marking NRM steps bad, which I have marked by a warning dialog and basically disallowed, is done. I have pushed a moment ago this branch of PmagPy named thellier_meas_flags and I hope that @ltauxe, @ronshaar, and @moonshoes87 could take a quick look at this branch and ensure it is more or less stable and works mostly as expected before I merge it into master. So I'll wait for a few responses on the function of this feature bellow before I do the merge which I hope to be able to do in the next couple of weeks before our next release. I have already checked that it is merged properly with master up to now (as far as I can tell), and that it passes all of the unit tests we currently have.

it is not so easy to delete a measurement for thellier data as you really need to delete at least a pair and you have to be careful of pTRM checks up the line and vector subtraction issues.  did you do that?
lisa

On Mar 22, 2017, at 1:10 PM, Kevin Gaastra<EMAIL_ADDRESS>wrote:
I have over the course of the last few months created a local branch of PmagPy where I worked on making Thellier GUI capable of marking measurement data bad by right clicking on the measurement record in the list on the left of the GUI. This makes Demag GUI and Thellier GUI more similar in the design of their user interaction which simplifies the UI, prevents the deletion of unwanted measurement data which is the current method to solve the lack of this feature, and allows the user to abstract another aspect of data analysis which is one of the goals of the GUIs. This new feature with the exception of marking NRM steps bad, which I have marked by a warning dialog and basically disallowed, is done. I have pushed a moment ago this branch of PmagPy named thellier_meas_flags and I hope that @ltauxe https://github.com/ltauxe, @ronshaar https://github.com/ronshaar, and @moonshoes87 https://github.com/moonshoes87 could take a quick look at this branch and ensure it is more or less stable and works mostly as expected before I merge it into master. So I'll wait for a few responses on the function of this feature bellow before I do the merge which I hope to be able to do in the next couple of weeks before our next release. I have already checked that it is merged properly with master up to now (as far as I can tell), and that it passes all of the unit tests we currently have.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/170, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDQCR2qoK0F6UP4Ap_g5v37UoQUOuks5roYA6gaJpZM4MlwXd.

Yeah I noticed the problems with removing a measurement in a Thellier experiment are much greater than in a Demag experiment. So here's the basic overview:

Z or I step marked bad:

if there is another Z or I step of matching treatment use it instead and recalculate parameters (basically restarts a segment of the GUI, hope I didn't miss anything here because this is where things could go wrong) these are the IZZ, IIZ, ZZI, ZII cases where one of the duplicates is bad.
if there are no matching Z or I steps of the same treatment you have no choice but to throw out that treatment step and remove it from calculations even though there might be a different Z or I step still marked good. Data is reinitialized as if this treatment step is just non-existent. These are the ZI or IZ cases where one is bad. So basically how to handle only a single I or Z for a treatment step the solution being that there is no treatment step if you only have a single I or Z you need both so if there is one it just may as well not be there.

PTRM checks, Tail checks, Additivity checks:

These are all just single data point measurements so I can just remove the bad points from the dataset and recalculate the parameters pertaining to differences between data points.

NRM

Freak out and tell the user not to do this. Thellier GUI regularly accesses the first Z step as the NRM because that's where it puts it during data read in. This becomes a bit more troubling as later I need to keep that data but not treat it as the NRM to normalize things with. This also raises the problem of what do you do if the user marks all NRMs bad? I might look at this more later, but for now just implementing this for the other steps should be a large bonus for the users. By the way though I still let the user do this, but it does not prevent the NRM from being used for normalizing things and just removes it from PCA there is a really long warning message to tell the user this is kinda a bad idea. I can fully block it before merging if there are objections to this.

There are some troubles with this (mostly around the recalculation bits), but it is the most simplistic and intuitive approach I could think of that works without too much implementation mess. That said I might have missed some of the places where data is stored in Thellier GUI as it has data all over and such a major feature is doubtless to have fallout. Which is why I am hoping to test this rigorously on the separate live branch before merging. Also it would be good to have someone with better knowledge of Thellier GUI's data structures see if I caught all the places I need to recalculate after removing a point. This could mostly be done by checking the recalculation of statistics after marking things good or bad in the GUI and just looking at how the functions mark_meas_bad, mark_meas_good, and on_right_click_listctrl work none of which are long.


provide missing configuration in DatabaseClientFactory.Bean

So we can incorporate your pull request, please share the following:

What issue are you addressing with this pull request? https://github.com/marklogic/java-client-api/issues/1018
Are you modifying the correct branch? "develop"
Have you run unit tests? (See CONTRIBUTING.md)
Version of MarkLogic Java Client API (see Readme.txt)
Version of MarkLogic Server (see admin gui on port 8001)
Java version (java -version)
OS and version
What Changed: What happened before this change? What happens without this change?

Added the mentioned call.


Slow load time during file open.

Hello.
New to neovim, long time vim user...  I started of with this project & when I use the onedark syntax highlighting I am having extremely long load times during file open...  Its actually causing me to insert bugs into code.
Open file, if I type anything before load finishes or /-search or /-paste something it ends up putting it into the file then jumping to the search result... So I don't even really get to see it inserted.
If I comment out the onedark it seems to work well again... I'm not convinced its only a onedark issue however..  I work on large C file (linux kernel), large C++ files & sometimes large python files... Not sure if file size matters...  Let me know if there is something I can do to provide more info..  I usually work in a large sized VM running ubuntu enterprise (No GUI)

I wonder whether you have the old kickstart which used onedark theme by default, or do you use the latest kickstart which uses tokyonight by default but then switched it to onedark? If you are on the old kickstart perhaps try with the latest version.
Although I think it's more likely an issue with treesitter than the theme, you can try disabling treesitter highlighting. Another thing that might be slowing things down is the LSP, in case you enabled the clangd LSP...

I'll rebase off the remote and see if it improves... It looks like I must have an older copy...  I didn't enable any clang support if it wasn't already..  Its interesting b/c some files do seem to open fine and others do not so I wonder if it isn't something about the syntax of the file..
Let me see how it goes after a rebase.

Something else worth noting is that "vim.opt.mouse = 'a'" prevents you from highlighting text in an out of focus tmux pane....

The new config is also "slow-ish" but at least it doesn't show me the code & let me do things before it's done loading.

You can try disabling treesitter highlight, something like this:
diff --git a/init.lua b/init.lua
index 013fcc2..9af7463 100644
--- a/init.lua
+++ b/init.lua
@@ -796,6 +796,7 @@ require('lazy').setup({
      auto_install = true,
      highlight = {
        enable = true,
+        disable = { 'c', 'cpp' },
        -- Some languages depend on vim's regex highlighting system (such as Ruby) for indent rules.
        --  If you are experiencing weird indenting issues, add the language to
        --  the list of additional_vim_regex_highlighting and disabled languages for indent.

Hi there.
The goal of the kickstart.nvim project is to provide a starting point for new users that's easy to read and understand.
Fast startup times are not a core goal, but thank you for the report in any case!


Fix for #788. No longer deleting issues, just marking them as fixed.

Should fix #788 and #821.
Adding a "fixed" bool flag to issues.
We will no longer delete issues, but instead, we will simply mark them as fixed.
If an issue comes back (regresses), we will set fixed to false.  The justifications will be preserved because the issues never get deleted.
The UI will not display fixed issues.
TODO:

[ ] - Ensure the item score (justified and unjustified) are appropriately ignoring fixed issues.

Write tests for the following flows:

[ ] - new issue

[ ] - existing issue

[ ] - fixed issue

[ ] - regressed issue

Coverage decreased (-0.003%) to 68.715% when pulling e5be51dd8d6f71337f075ac09ec812ffa432d414 on issue_preservation into 6403186ac9000f12993e7de73da7a350ee38f6c4 on develop.

Coverage decreased (-0.008%) to 68.71% when pulling bbe55a4c354f8f36d0ba43380b1f2a3f0495a444 on issue_preservation into 6403186ac9000f12993e7de73da7a350ee38f6c4 on develop.

Coverage decreased (-0.008%) to 68.71% when pulling bbe55a4c354f8f36d0ba43380b1f2a3f0495a444 on issue_preservation into 6403186ac9000f12993e7de73da7a350ee38f6c4 on develop.

Coverage decreased (-0.008%) to 68.71% when pulling 3d83ca4c2083dbecb7999e6d57fea6b0577c0d50 on issue_preservation into 6403186ac9000f12993e7de73da7a350ee38f6c4 on develop.

Coverage increased (+0.2%) to 68.872% when pulling fd4892b5b5080da15ddf3dcd40033a315a465155 on issue_preservation into 6403186ac9000f12993e7de73da7a350ee38f6c4 on develop.

Coverage increased (+0.2%) to 68.872% when pulling fd4892b5b5080da15ddf3dcd40033a315a465155 on issue_preservation into 6403186ac9000f12993e7de73da7a350ee38f6c4 on develop.

Hi @monkeysecurity ,
I believe this update also requires a change on the Auditor Settings page where it still shows the total number of issues from the beginning (including those which have been marked as fixed). Thus upon clicking on the auditor setting it takes you to the search which shows only current failures (a number that does not match the one shown on auditor settings).
Example
Auditor Settings

Audit Issues Report on Search Page for the same account referenced above

I believe the fix for this is in the views/auditor_settings.py where we need an added filter for excluding marked issues.
However, it may also be that this was the intended behaviour?
Recreating Issue
You can recreate this by fixing something on an account and then returning to the auditor settings page to see it still has the original count.


Enable context_dependent option for Rubocop Style/BracesAroundHashParameters

Per https://github.com/bbatsov/rubocop/issues/2063, there is an unfortunate effect of always removing optional braces around hash parameters. Something like this is a violation:
add_users({ name: 'Mitch' }, { name: 'Gib' })

And the fix is:
add_users({ name: 'Mitch' }, name: 'Gib')

I'm running into this issue when using the RSpec include matcher.
The alleged fix is:
Style/BracesAroundHashParameters:
  EnforcedStyle: context_dependent

:+1: :+1: :+1: :+1: :+1:

(assuming the fix does fix it)

Ok! Will give it a try and see how it works.

Tested locally in gridiron. This no longer reports violations on code like this:
add_users({ name: 'Mitch' }, { name: 'Gib' })

but still reports violations on code like this:
my_method('string', { optional: 'hi' })


What is the purpose of converting CvMat to ImageFrame when passing image from node to node? Why not just pass CvMat and skip the conversion?

I am in the midst of writing my own calculators and it seems that there are a lot of such conversions in official calculators when most of the operations on CPU are written using OpenCV. Why not save the conversion and pass CvMat around? What are the benefits of converting to ImageFrame?

Hi,
Good question!  cv::Mat is a perfectly acceptable object to pass around in packet streams between calculators, and can certainly be an option for you (or anyone) writing their own custom calculators.
The main reason for ImageFrame is more of an internal preference, to not require the dependence on opencv for all [internal] applications that want to use any of the mediapipe calculators/graphs.
I understand it looks a bit weird on the desktop app to convert from opencv to imageframe, then inside the calculator uses opencv again.
On the other hand, using imageframe as interface, the mobile apps don't need to link in opencv (at the app level) to send camera frames into the medaipie graph (nor should they, as the phone camera frames are GPU based).
The good news is that any conversion between imageframe and cv::Mat happens with zero copy (the data pointer is shared). So the mediapipe::formats::MatView() just creates a cv::Mat header (no data copy), and is very efficient.
There isn't much benefit of ImageFrame over opencv for your own calculators, other than consistency with the calculators mediapipe provides.


fix batch_matmul for invalid mma config for sm  < 80

Some MMA configs are not valid in sm<80. Fix this by filtering out mma_configs before creating the tuning space.
This should address #225
Also, I changed the warning for contiguous tensor to warn_once to reduce the amount of context printed to the consol.

There is another minor annoyance with tuning this model. By default, hidet parallel tuning/build uses # of cores as parallel workers. However, when the fused kernel is large, the compilation processes would use all the memory in the system and cause system hang.
Setting hidet.option.parallel_build(enabled=True) seems to have no effect.
I will make a fix in another PR

Thanks @xinli-git, it looks good to me.

Thanks @yaoyaoding, I will work on this next :)


fix: register custom alias provided by the user if present

fixes https://github.com/reibitto/sbt-welcome/issues/8, although I'm not sure what exactly semantic of auto alias should be and if my fix is not breaking other things. Unit tests are passing but maybe it'll be worth to have scripted test to see if aliases are working?

I'm actually not sure how to write an integration test for sbt plugins and check its internal state, but I could at the very least add a test to make sure the sbt command in the data structure is correct. The only tests that currently exist test the rendering.

I have some experience with scripted tests, I can take a look and try to write one. I think internal state doesn't need to be inspected, all what we need to check is if an alias invokes a command and doesn't result in error instead.


barback should prioritize transforms that are needed to produce assets with active requests

repro instructions in this bug:
https://code.google.com/p/dart/issues/detail?id=15573
"pub serve" appears to be running dart2js on every single entrypoint, instead of just the one I navigate to.

This issue has been moved to dart-lang/barback#23.


Generate pages without corresponding file

As I understand it, every page that staticjinja generates must have a corresponding file on disk, whether a template file or another source file with corresponding rendering rule. It would be neat if there was a way to generate pages solely on the basis of data structures defined in the build script, which might all use the same generic template (such as _post.html).
Is my understanding correct that such a thing is not currently possible? And would there be any interest in adding support for it?

Hi! Thanks for reaching out. I think I see what you mean, are you talking about something similar to https://github.com/staticjinja/staticjinja/issues/72? I believe what you request is currently possible using a custom render function, though it's not super nice. See https://github.com/staticjinja/staticjinja/issues/72#issuecomment-727076869 for more info. Will that work for you?

Hi! Thanks for reaching out. I think I see what you mean, are you talking about something similar to https://github.com/staticjinja/staticjinja/issues/72? I believe what you request is currently possible using a custom render function, though it's not super nice. See https://github.com/staticjinja/staticjinja/issues/72#issuecomment-727076869 for more info. Will that work for you?

I think you're right @NickCrews, that should accomplish what I am describing. I'll give it a shot. Thanks!

I think you're right @NickCrews, that should accomplish what I am describing. I'll give it a shot. Thanks!


Free Palestine in README

Hi,
I'm Israeli. I'm not personally opposed to the Free Palestine message in the readme. I don't want to get into my personal opinions regarding Palestine.
My goal with this issue is to try and help you avoid a mistake I believe I was a part of. If you'd rather have this discussion elsewhere feel free to email me instead.
Personally, I regret the #BlackLivesMatter banner that I supported in the Node.js website. It did very little to help with the injustice or tech's complictness in it - I believe we have failed in our promise to be part of the solution.
What I'd like to do is challenge you to do more than "performative allyship" here. "Free Palestine" is an ambiguous message that is divisive and doesn't do enough to help Palestinians.
Instead, I'd like to suggest supporting organisations that actively help Palestinians or promoting Palestinians yourself:

Promote technology and initiatives from companies that promote peaceful co-existence and hire Palestinians like Mellanox/Nvidia.
Put a link to tech accelerators that help Palestinians like GazaSkyGeeks. They also accept donations (I have donated myself in the past).
Add a link to programs that help Palestinians like Manara and suggest hiring from there yourself.
Offer direct mentorship/training to Palestinians who want to get involved (e.g. https://news.ycombinator.com/item?id=11860938 )

To be clear - my point applies equally to the BlackLivesMatter message in the README. Saying "black lives matter" isn't enough nor does it deal with the systematic problem.
The only reason I did not recommend companies/charities/accelerators for that cause is that I do not have experience with any.

@benjamingr those are beautiful ideas that you brought up!

that last link to a random post from 2016 is chef's kiss

That last post was just a real example of a message that worked for me personally. That is my username in hacker news.

Just another reason for not using graphql...

Nice place for some political discussions guys, applause.
Any relation of Palestine to graphiql issues?

Nice place for some political discussions guys, applause.
Any relation of Palestine to graphiql issues?

Yes. Once the maintainer posts "free Palestine" in the title of the readme there you have a relation.

@FlickerLogicalStack you didn't read the instructions did you...

The GraphQL technical steering committee is working on a policy to guide the use of political speech from the voice of a GraphQL project. The original author chose to revert the original change via #1879 until we complete that policy. This should resolve this issue, so I am closing it.
As a reminder, all discussion within GraphQL projects must adhere to our Code of Conduct.

Thanks for the update. Removing the banner seems like a good call to me.
@acao if you would like to constructively contribute towards helping Palestinians please feel free to reach out to me or to any of the organisations I mentioned in this post.

@benjamingr I am already working with local palestinian organizations and helping my jewish friends forming an IJAN chapter! This is something I’ve already discussed. The local organizations are the ones who encouraged use of the phrase “free palestine” at local protests where our rainbow coalition assembled, where people from all faiths assembled to call for an end to the apartheid. This act was a constructive way of helping the Palestinians, according to my Palestinian friends. I am not interested in any further condescending “guidance” on the matter

Fair enough, sorry if my message came off as condescending that was not my intention and best of luck.
If we learned a lesson about performative activism that'll have to do.


Show initialization failures also in the popover

Fixes #210
Previously, we would only show a notification when failing to initialize the client (e.g. this could happen when an error occurs while checking the protocol version) without informing the popover. This was also causing exceptions like #210, because we were failing to instantiate objects like PortalBindingManager due to the initialization error.
With this pull-request we will:

Show an error message in the popover too, coloring the status bar indicator as red when that happens.
Don't attempt to re-initialize the client if it is outdated or an error has previously occurred.

I have tested this works correctly with a few themes (One Light UI, One Dark UI, Atom Material, Nord UI) by opening the DevTools and enabling the Offline checkbox in the Network tab. On reload, I verified that the above message was being shown in the popover.
/cc: @jasonrudolph @nathansobo

Can I talk you into describing the steps you used to test these changes?

Thanks for reminding me of that, I have updated the body of the pull request to describe the steps I followed.
I have also addressed https://github.com/atom/teletype/pull/212#discussion_r151428811 and verified it works as expected, so I am going to merge this once CI is green. Thanks for the review, @jasonrudolph! 🙇


Allow rustc bootstrap to use unstable features even though it's using a beta-cargo

This is the sane alternative to https://github.com/rust-lang/rust/pull/51322#issuecomment-394828839
cc @kennytm

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors r_

=/
@bors r+

:pushpin: Commit 1bdb89d has been approved by matklad

:sunny: Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 946ab0040c26b17f6d49eaf7e21bfaeee64ac211 to master...


Add --import compiler options to specify module imports that should happen for every module.

The --import compiler option can be specified multiple times on the command line, or would be a string array in tsconfig.json. Its argument is a module name which would be imported at the top of every external module in the project.
For example, the following command line:
tsc app.ts --import module

Would be the equivalent of:
// app.ts
import "module";

The named module will be resolved in the same way the above import declaration's module would be resolved, so the module name must either be declared as an ambient external module or resolve to a valid path relative to each external module in the list of sources, unless that would mean importing itself.
This is to support loading an external library of TypeScript helper functions as well as various polyfill and shim libraries.

related to #2901

Doesn't seem like we need this


add files to showoff lol

I have create few files , they won't make a big change !just to practice my git skills

all right


"Popover.CloseButton doesn't close when pressed on android"

Description
When you try to close the close button inside the popover it does not close.
CodeSandbox/Snack link
https://snack.expo.dev/?files={"App.tsx"%3A{"type"%3A"CODE"%2C"contents"%3A"import React from 'react'%3B\nimport { Popover%2C Button%2C Box%2C Center%2C NativeBaseProvider } from 'native-base'%3B\n\nfunction Example() {\n  return <Box h%3D\"60%25\" w%3D\"100%25\" alignItems%3D\"center\">\n      <Popover trigger%3D{triggerProps %3D> {\n      return <Button {...triggerProps} shadow%3D{2} colorScheme%3D\"danger\">\n              Delete Customer\n            <%2FButton>%3B\n    }}>\n        <Popover.Content accessibilityLabel%3D\"Delete Customerd\" w%3D\"56\">\n          <Popover.Arrow %2F>\n          <Popover.CloseButton %2F>\n          <Popover.Header>Delete Customer<%2FPopover.Header>\n          <Popover.Body>\n            This will remove all data relating to Alex. This action cannot be\n            reversed. Deleted data can not be recovered.\n          <%2FPopover.Body>\n          <Popover.Footer justifyContent%3D\"flex-end\">\n            <Button.Group space%3D{2}>\n              <Button colorScheme%3D\"coolGray\" variant%3D\"ghost\">\n                Cancel\n              <%2FButton>\n              <Button colorScheme%3D\"danger\">Delete<%2FButton>\n            <%2FButton.Group>\n          <%2FPopover.Footer>\n        <%2FPopover.Content>\n      <%2FPopover>\n    <%2FBox>%3B\n}\n\n    export default () %3D> {\n        return (\n          <NativeBaseProvider>\n            <Center flex%3D{1} px%3D\"3\">\n                <Example %2F>\n            <%2FCenter>\n          <%2FNativeBaseProvider>\n        )%3B\n    }%3B\n    "}}&dependencies=react-is%2Cexpo-font%2Cnative-base%403.3.4%2Cstyled-system%2Cexpo-constants%2Creact-native-web%2Creact-native-safe-area-context%2Creact-native-svg%2Cstyled-components%2C%40expo%2Fvector-icons%2Cexpo-linear-gradient%2Cformik%2Cyup%2C%40react-navigation%2Fdrawer%2C%40react-navigation%2Fnative%2Creact-native-vector-icons%2Creact-native-gesture-handler%2Creact-native-linear-gradient%2C%40react-native-community%2Fmasked-view%2Creact-native-screens%2Creact-native-reanimated
Steps to reproduce

Go to the snack expo link mentioned above.
Select the iOS device and click on the popover and click the close button it works perfectly.
But If you change the device to Android and click the close button inside the popover it doesn't close.

NativeBase Version
3.3.3
Platform

[X] Android
[ ] CRA
[ ] Expo
[ ] iOS
[ ] Next

Other Platform
No response
Additional Information
https://github.com/GeekyAnts/NativeBase/issues/4646. This is also an issue, unable to click any button in the same page of popover.

@ThelmaAndrews Thanks for reporting this! We're working on this.

Hi @ThelmaAndrews, This issue is fixed in version 3.3.4`.


No module named habitat_sim.utils.datasets_download

Hi, when I use the command to download Habitat test scenes, I get an error:
/root/miniconda3/envs/semexp/bin/python: No module named habitat_sim.utils.datasets_download
The error shows there is no datasets_download module, however, I believe I have successfully installed habitat-sim v0.15 because when I use the command: pip show habitat-sim, I get:
habitat-sim
Version: 0.1.5
Summary: A high performance simulator for training embodied agents
Home-page:
Author: FAIR A-STAR
Author-email:
License:
Location: /root/miniconda3/envs/semexp/lib/python3.7/site-packages/habitat_sim-0.1.5-py3.7-linux-x86_64.egg
Requires: attrs, gitpython, matplotlib, numba, numpy, numpy-quaternion, pillow, scipy, tqdm
Required-by:

Could you help me figure out the problem? Thanks!

Okay, that's because this old version of habitat-sim does not contain such module and function.


Vanced MicroG is not running in background.

I have Infinix mobile running X0S (Android 10) and it basically kills microg app.
I tried every setting to stop XOS from killing MicroG app like turning off battery optimization, Turning off restrict to run in the background, but no fix.
When I open revanced youtube it closes automatically sometime or it says "no internet connection" at first I didn't have an idea to why it is happening then I opened microg and minimize the app and open Revanced Youtube and it worked fine.

please add additional description

This is an issue that I have also been reported on in the past.
For some reason, MicroG doesn't run in the background on Infinix's OS.
Unfortunately, this issue is not easy to resolve as none of the developers own an Infinix device.

@MustafaHassan1 You might as well use another android device than a Infinix device as that's not what revanced team is targeting at the moment.

Thanks I will close the issue now at least you heard my issue and replied me that is enough.
Thank you and your team for all the efforts.


fixed reading 10x formatted visium mtx files

Description
Replaced Anndata's read_mtx function with scanpys native read_10x_mtx function for reading mtx formatted visium experiments. This solves issues with matching the spot positions to barcodes, as well as missing feature names and barcodes, and proper matrix orientation.
How has this been tested?
all tests ran locally
Closes
closes #802

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ad4083) 69.83% compared to head (f3b434a) 69.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #803   +/-   ##
=======================================
  Coverage   69.83%   69.83%
=======================================
  Files          39       39
  Lines        5497     5497
  Branches     1034     1034
=======================================
  Hits         3839     3839
  Misses       1363     1363
  Partials      295      295

Files
Coverage Δ

src/squidpy/read/_utils.py
75.00% <66.66%> (ø)

thank you @LinearParadox ! I wonder if it's related to #797 , @Lem-P could you try out this solution and see if it fixes the issue?

I think it's likely a different issue. When squidpy would read the mtx file, the object would have no gene / barcode names, and the failure would likely be noticed at qc (as you would have only a single peak in spot counts, since they'd be all NA). Do you know if the current test datasets in squidpy have the mtx files floating around somewhere? It would be nice to add some tests to make 100% sure the mtx reading is equivalent with reading h5 files.

hi @LinearParadox , you are right, re-reading the issue I think it's due to the header being set wrong.
regarding tests, unfortunately we don;'t have the mtx file in thedatasets, and we don't really have a test suite for readers in squidpy. For spatialdata, we have a robust and rather compute expensive pipeline that ensures that datasets can always be read by the readers and supported by spatialdata objects (set up by @LucaMarconato , cc). I think it's outside the scope of squidpy to set something up like that as we are hoping that users will transition to spatialdata eventually. You can find the (tested) datasets here: https://github.com/scverse/spatialdata-notebooks/tree/main/datasets . I will merge this once CI passes

maybe @LinearParadox can you add a release note? you can add it in the dev release for now (in docs/release_notes) and I will move it to whatever version we do next. Thank you!

Should be done! Let me know if you need me to add more detail or if there's anything else I should modify/add!


[CELEBORN-1476] Enhance the RESTful response error msg

What changes were proposed in this pull request?
Partial backport https://github.com/apache/kyuubi/pull/2634
It is aimed to enhance the error message when exception thrown in RESTful api method.
Why are the changes needed?
As title.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

cc @SteNicholas

Merged to main(0.6.0) and branch-0.5(0.5.1).


Can internal project release already the rebrand version?

@alexsoeres

@joachimprinzbach is that possible?

Discuss with Michael Besel first

website of design system will still be password protected until go live
repositories can be merged sooner, packages can be aligned before go live

Internal applications: OK to go live before October 28th.


Improved CODE_OF_CONDUCT.md

Enhanced visual appearance of the document

Summary by CodeRabbit

Documentation

Enhanced the presentation and clarity of the Code of Conduct with improved formatting, including emojis and bold text.
Updated section headers for better visual engagement.
Reformatted lists of acceptable and unacceptable behaviors for clarity.
Added styled links for reporting incidents and accessing the Contributor Covenant homepage and FAQ for better accessibility.

Hi @Innovatorcloudy
Thank you for your PR and the time you've invested in improving our CODE_OF_CONDUCT!
I appreciate your effort to make the document more visually appealing.
However, I must respectfully decline this change. The CODE_OF_CONDUCT is a critical document that outlines the standards and expectations for our community. It's based on widely accepted templates, carefully adapted to reflect the specific norms I wish to establish for our project.
Given the serious nature of this document, I prefer to maintain a more formal and straightforward style, without emojis or extensive formatting. This approach ensures clarity and emphasizes the importance of its content.
Again, thank you for your contribution!
Your engagement with the project is valued, and I encourage you to continue participating in other areas where we can make the documentation more user-friendly and engaging.

Thank you for your contribution.
I'm sorry you created a PR, but as I stated above it doesn't fit with my policy so I will close it.


Provided Elastic-Job plugin

Fix #603 Elastic-Job plugin

Coverage increased (+0.06%) to 23.114% when pulling c87039a828fc97d5e0e0a4f15582bb901c90c11a on hanahmily:master into af0b05a5088470ee27dcdb15ce11f51182a2d2f5 on OpenSkywalking:master.

And you should resolve the conflicts, because we released 3.2.5, Next expected version is 3.3.0

Coverage increased (+0.06%) to 22.987% when pulling 31970312d1333c0e72e7cacd9eb44b10b8655593 on hanahmily:master into 91386d43e1377c7ee1300cc37635f63d77f89bfa on OpenSkywalking:master.


Fix for iterator type error in example pyramid.cpp

Pyramid example doesn't work due to mcpp::HeightMap not supporting direct iteration over the heights stored in array.
See below.
rowan@kinson:~/Code/rmit/studio/examples$ mining pyramid_broken
===============================================
MINING: Compiling pyramid_broken.cc into pyramid_broken
===============================================
In file included from pyramid_broken.cc:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/algorithm:1751:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/copy.h:15:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/min.h:14:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/min_element.h:55:3: error: static assertion failed due to requirement '__has_iterator_category_convertible_to<mcpp::HeightMap::Iterator, std::forward_iterator_tag, false>::value': std::min_element requires a ForwardIterator
  static_assert(__has_forward_iterator_category<_ForwardIterator>::value,
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/min_element.h:67:19: note: in instantiation of function template specialization 'std::min_element<mcpp::HeightMap::Iterator, std::__less<void, void>>' requested here
    return _VSTD::min_element(__first, __last, __less<>());
                  ^
pyramid_broken.cc:36:28: note: in instantiation of function template specialization 'std::min_element<mcpp::HeightMap::Iterator>' requested here
    int min_height = *std::min_element(heights.begin(), heights.end());
                           ^
1 error generated.
===============================================
MINING: Executing pyramid_broken
===============================================
mining:13: no such file or directory: ./pyramid_broken

Wrote rudimentary fix for the pyramid example, which extracts height values numbers into vector for std::min_element to work.

Nevermind, had old build, fixed in https://github.com/rozukke/mcpp/pull/86.


Show labels and milestones in the final report

Can be handled using suffix and heading #16 settings.


Daily graph for tested

Is your feature request related to a problem? Please describe.
Right now the tested graph shown only works for cumulative switch but not for daily switch. Upon clicking on daily switch the testing graph vanishes where as the rest four graphs remain in their position as they were.
Describe the solution you'd like
Show a daily basis tested graph just like the rest of the four graphs of confirmed, active, recovered, deceased ones. There might be a problem for lack of data as the tested graph data starts from 13th March - in that case you guys can put something like unconfirmed lest the slider goes behind the date.

Hi! The testing time series also contains some missing data points in between since the information wasn't released by the state/central government. For example, there's no data for 22 April in the All States chart. I couldn't think of an elegant solution to handle this, so I didn't add the daily testing graph. Let us know if you have a solution in mind.

Yup, didn't notice this discontinuity. There's multiple dates 28 march, 29 march, 20 April - no data. How about we put something like 'Not Available' for two days when we have data missing for a day, like plotting zero on graph but writing NA in stead of any count along with fluctuation wrt previous day on the plot legend. We have data for the 19th, the 21st - we don't know exact count for the 20th and the 21st itself, thus we'll have to sacrifice two days daily count for a single day missing value. Bet so many lapses won't look good on the plot either.

I think your approach makes sense. We can omit the bar for an extra day for the period when the data is missing. Also, instead of writing NA, we can just show a '-' like we do for the cumulative graph.
Let me know if you'd like to make a PR for this.

I'll have to pass on PR. I'm not well versed in react, tbh.

Sure, nevermind


Update team roster

Updates the Pulumi team roster to mark a few folk as inactive 😢 .

😢  Two quick things:

Let's delete, not mark inactive.
Let's add Nick and Dan!! :tada:


Get holidays from BambooHR

@shanebonham brought up the need to get holidays out of bamboo #2
For reference, holidays look like this
  {
    "id": 19,
    "type": "holiday",
    "name": "Memorial Day",
    "start": "2017-05-29",
    "end": "2017-05-29"
  }


Added support for syncing the existing models

Added support for new command sequelize-mig:sync
Moved out some common code between make and sync operations to helper.

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


After version upgrade, relevant methods { RedisClient } cannot be used

Motivation
After version upgrade, relevant methods { RedisClient } cannot be used
eg：import redis, { RedisClient } from 'redis';
Basic Code Example
I am using this version ："redis": "^3.0.2"
The specific usage is:
import redis, { RedisClient } from 'redis';
I upgraded and used it ："redis": "^4.6.7"
Now, it cannot be used： { RedisClient } from 'redis'
May I ask what is the name of the RedisClient for version 4.6.7，
Or how to use it RedisClient ？

mark


qtads: 3.2.0 -> 3.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/realnc/qtads/releases.
meta.description for qtads is: "Multimedia interpreter for TADS games"
meta.homepage for qtads is: "https://realnc.github.io/qtads/"
meta.changelog for qtads is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.3.0 with grep in /nix/store/6f5d1vc9iv7wwdkjyi67jmb3x2ks3nx5-qtads-3.3.0
found 3.3.0 in filename of file in /nix/store/6f5d1vc9iv7wwdkjyi67jmb3x2ks3nx5-qtads-3.3.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
qtads

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6f5d1vc9iv7wwdkjyi67jmb3x2ks3nx5-qtads-3.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A qtads https://github.com/r-ryantm/nixpkgs/archive/fd1690622fb79776376cd54d6ffcf3cac1e0c7a9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6f5d1vc9iv7wwdkjyi67jmb3x2ks3nx5-qtads-3.3.0
ls -la /nix/store/6f5d1vc9iv7wwdkjyi67jmb3x2ks3nx5-qtads-3.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

qtads

Maintainer pings
cc @orivej for testing.

Result of nixpkgs-review pr 183780 run on x86_64-linux 1

1 package built:

qtads


Ability to self-host JIRA-GHE plugin ?

Hi team !
For a particularly sensible project, we would like to be able to push event from Github Enterprise to JIRA.
We analyzed the already existing Github for Jira plugin, but it appears that it's not compliant with our security policies as it is hosted in Atlassian Cloud, ... and push too many info to Jira (like GH PRs for instance).
--> Is it possible to run the GH-for-Jira app on a server outside of JIRA cloud, ie. to self-hosted the app (note: we have a Jira cloud offer, and don t want to have a self-managed solution).
We noticed there's a developer mode but it doesn't seem to be designed to be used in prod on our own servers.
Thanks a lot for your help :)

Just so I'm clear: you have Jira Cloud and yet don't trust Atlassian's Cloud for the integration?

Hi @mboudreau,
That's correct, at least for this very sensitive project only.
What's an issue for us in that case is that webhook gets all the PR and issue data without any way to filter what the app has access to.
We would like to know if there is any way to amend the plugin (and reducing what is pushed to Jira basically) and host the amended plugin within our servers.

Hey @jsire-ledger , just a heads up that we are leaning towards reverse proxy solution (https://github.com/atlassian/github-for-jira/issues/1810 ). Potentially, you could've implement a smart reverse proxy that would manipulate the payload and sanitise/exclude sensitive data. Is it something that could've been of your interest?

Thanks a lot for the heads-up.
Last time we talked with @gxueatlassian, we realized that your solution/apps needs to fetch information from our GitHub instance to grab more details (like IDs of different repos, app installation details). So for that to happen, the app needs to "talk" to our GitHub instance, which requires an IP address ( and/or via public DNS ).
However, we aren't able to provide public access to our on-prem GitHub instances. We are trying to figure out another way to work around that.
We will keep monitoring the progress of the issue #1810 as it might match our requirements eventually.


CBMEM003.001 wrong format of returned value results in fails

Device
novacustom ns70mu
RTE version

OSFV version
branch: release-v0.3.0
Affected component(s) or functionality
Measure Reboot Time kwd of lib/options/dcu.robot resource
line 124:
Append To List    ${durations}    ${boot_time} s
Brief summary
i have reasons to believe that the ,,s" in append to list kwd line is put there by mistake
How reproducible
No response
How to reproduce
try running boot time measure suite
Expected behavior
success
Actual behavior
notice the cbmem002.001 passes while cbmem003.001 does not. In logs we can see the cbmem3 has problem with comparing values from output that is because cbmem2's list consists of float values (e. g. 2.5, 2.38, 1.3) while cbmem3 adds and extra ,,s" at the end so the returned values are no longer floats (e. g. 2.5s, 2.38s, 1.3s) As a result the test case gets confused and fails.
Link to screenshots or logs
logs.zip
Additional context
No response
Solutions you've tried
remove ,,s" from the kwd

Also noticed this error when testing a release. It was fixed here:
https://github.com/Dasharo/open-source-firmware-validation/pull/499/files


[Bug] Cancel requests

Describe the Bug
Try to cancel requests using cancelLoadAll:
loadObject.cancelFn is not a function
TypeError: loadObject.cancelFn is not a function

Steps to Reproduce

Cancel loading requests with cancelLoadAll

The current behavior
cancelLoadAll do nothing and an error appears.
The expected behavior
cancelLoadAll cancel all pending requests.
OS
Windows 10
Node version
18.18.2
Browser
Last

If you're using the wadouri image loader, cancelFn is indeed undefined in https://github.com/cornerstonejs/cornerstone3D/blob/4d12d9d2ecf38805e7c9ca7e93bf36372bfe85ff/packages/dicomImageLoader/src/imageLoader/wadouri/loadImage.ts#L53 and https://github.com/cornerstonejs/cornerstone3D/blob/4d12d9d2ecf38805e7c9ca7e93bf36372bfe85ff/packages/dicomImageLoader/src/imageLoader/wadouri/loadImage.ts#L156 .

@sedghi Can you check please?

we haven't implemented cancel (yet), it requires attaching a signal to each request, and sometimes it even doesn't makes sense to cancel for high bandwidth request, but you can look into the nifti loade in cornerstone3D to see how you can implement one


store keys as files

See: https://github.com/joehand/dat-next/issues/83

What is the use case(s)?
How would a user resume with a secret key?
Do we need the secret key for the content feed too?

Moving to dat node 1.3 milestone https://github.com/datproject/dat-node/milestone/2

Everything is files now.


remove forward slash in absolute path

updating wiki link round 2
apparently a forward slash snuck in there 😞

Ah, yep, missed that. Thanks.


Denis/circle ci

Circle CI successfully build and run Corda: https://circleci.com/gh/denis-yu-glotov/blockchain-integration-framework/22.
Now I am adding Fabric and run scenarios between them.


feat(Optimizer): Add MSE Optimizer

The goal of this issue is to implement MSE Optimizer.
Finding the rmin and rmax through the MSE Optimizer:

Take the maximum and minimum values [rmin, rmax] as initial values, then
Iterate N times, each time attempting to narrow down the interval [rmin, rmax] to [rmin + eps, rmax - eps]. Calculate the MSE error between the fake_quantized tensor and the original tensor using rmin and rmax.
Chose the rmin and rmax with the smallest MSE error as inputs for calculating scale and zeropoint.

implements https://github.com/huggingface/quanto/issues/135
What does this PR do

Add MseSymmetricOptimizer
Add _MseAffineOptimizer, because QModuleMixin doesn't support optimizer for activations, I make it internal temporarily
Fix ruff deprecate parameter warnings

@dacorvo This PR is ready to review

Thank you for the pull-request. There is a misunderstanding however about the core design principles of quanto in general and the scope of optimizers. quanto is lightweight and simple, allowing to combine the best quantization algorithms by strictly following the pytorch extension patterns and staying modality agnostic. Regarding the optimizers: they are only meant to be used to apply PTQ on weights. For 8-bit quantization, a SymmetricOptimizer will be used (defaults to AbsmaxOptimizer), for lower bitwidth, an AffineOptimizer. The AbsmaxOptimizer gives excellent results for 8-bit, so I don't think it is actually required to provide alternatives like the MseSymmetricOptimizer. The MseAffineOptimizer might improve the performance of qint2 or qint4 models, but I will only merge it if you provide numbers proving it.

@dacorvo We have some internal models that show better results using MSE compared to other methods, including AbsMax. However, I don't think I can publicly share these models 😂 I will return to this PR and finish it when I have a shareable number.
By the way, here are some numbers but they didn't compare to AbsMax. https://mqbench.readthedocs.io/en/latest/benchmark/ImageClassification/Benchmark.html


406 - Remove warnings and error messages at the compile/runtime

Issue Number
#406
The commit of this PR starts at: cec2e26
Purpose/Implementation Notes
Remove the error and warning messages at both compile and runtime for client and storybook.
Except the following item 🐛  :
Prop xyz did not match. Server: upgrading Next.js to version 12 should resolve this issue without the need for additional settings or plugins.
(resource) https://nextjs.org/docs/architecture/nextjs-compiler#styled-components
Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] Lint and unit tests pass locally with my changes

🗒 This PR is outdated and no longer applicable due to the tech stack upgrades made in PR https://github.com/AlexsLemonade/scpca-portal/pull/432, thus closing this issue.


(Sokol) Update parity to 2.6.4

Please update your nodes to parity 2.6.4
NOTE this update also includes a change of spec.json, so instructions are different than usual ones:
https://forum.poa.network/t/update-sokol-to-parity-2-6-4/3134
Nodes to be updates:

[ ] Adam Kagy Sokol Validator
[ ] Alex Emelyanov
[ ] Bootnode Sokol Las Vegas A
[ ] Blockscout
[X] Bootnode-ASG-i-0737f9
[ ] Henry Vishnevsky
[ ] Ian Ferrell Validator
[ ] Ilmira Nugumanova
[ ] Irvin Cardenas
[ ] Jim O'Regan SOKOL Validator Chicago A
[ ] Jim O'Regan SOKOL Validator Chicago B
[ ] John D. Storey
[ ] John H. LeGassic
[ ] Kiryl Ihnatsyeu
[ ] Kiryl Ihnatsyeu Bootnode
[ ] Kristina Yevseyeva Sokol
[X] Master of Ceremony
[ ] Michael Milirud
[ ] MM Azure EastUS Bootnode
[ ] Oxana Kunets | NYC-v2
[ ] Peter Chen Sokol Validator
[ ] Sokol Bootnode Toronto A
[ ] Stephen Arsenault

Checks

[X] Resync

Docs updates

[X] playbook defaults (https://github.com/poanetwork/deployment-playbooks/pull/246)

Update to 2.6.5 and prepare for Istanbul activation instead https://forum.poa.network/t/istanbul-activation-on-sokol/3161


Customers:  Add proposed business customer type fields

This is a sub-task of the epic to support business profiles.
Proposed work
Add the following fields to the customer model to support business profiles

Customer type: business (exists today)
Business name
Doing business as (optional)
Business type

Individual, sole proprietor, or single-member LLC
Corporation
Nonprofit organization
Partnership
Limited liability company

Addresses (already exists)
Phone numbers (already exists)
SIC code (optional)
Business Classification & Tags | SIC Codes - Google docs
NAICS code (optional)
Business Classification & Tags | NAICS Codes - Google docs
Website (optional)
Email Address (already exists)
EIN (optional)
Date established (optional)
D&B D-U-N-S number (optional)
Representatives (optional array)

First name
Last name
Job title
Date of birth
SSN (last 4)
Addresses
Phone numbers
Email address

@darwinz can we create a PR of just the models being added? I want to agree on the descriptions, naming, etc before merging.
Also, can we hold off merging this until v0.5.0 is released? I don't want to introduce partial support for businesses right now.


BUG - Color theme reverts back to light mode

I have noticed many times, the ecency web app theme changes to default light after a number of session on google chrome. Cant say exactly when it happens, but I have noticed it multiple times.
OS: MacOS 12.2
System Color Theme: Dark
Browser: Google Chrome - Version 100.0.4896.127

fixed in #979


Content tweak to provider link

Content tweak to provider link

Yep no problem
On Mon, Nov 4, 2019 at 11:08 AM Paul Hayes<EMAIL_ADDRESS>wrote:

@fofr commented on this pull request.
In app/views/application/choices/provider.njk
https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training-prototype/pull/268#discussion_r341997739
:

@@ -6,7 +6,7 @@

{% block primary %}
-You can preview a list of training providers and courses currently available on Apply for teacher training here.
+You can preview a list of training providers and courses currently available on Apply for teacher training.
👍
Can we make the full link: preview a list of training providers so it
makes sense in isolation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training-prototype/pull/268?email_source=notifications&email_token=AJHOYDIXFKCWQPZYHYCLMEDQR77CFA5CNFSM4JIR53S2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKEX32A#pullrequestreview-311000552,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJHOYDJ54DHFABYSFPZIWNDQR77CFANCNFSM4JIR53SQ
.

--
Please note I work Mondays to Thursdays
Content designer, Apply for postgraduate teacher training | Becoming a
Teacher | Teaching Workforce and Digital, Data and Technology (DDaT)
Directorates
E<EMAIL_ADDRESS>| T: 07961 100 193
A: Sanctuary Buildings, Great Smith Street, London, SW1P 3BT
Check out the new ‘Find Postgraduate Teacher Training’ service here:
http://education.gov.uk/find


Consider support .sum files for security purposes.

As per https://blog.golang.org/modules2019#TOC_5. sums can be important.

I presume you mean checking these in, right? It can also be good for caching I think.


Update to Go 1.18

Go 1.18 was released and brings a few improvements and bug fixes.
I'm still not 100% familiar with the codebase, but I think some of the benefits for the project are:

Apple M1, ARM64, and PowerPC64 users rejoice! Go 1.18 includes CPU performance improvements of up to 20% due to the expansion of Go 1.17’s register ABI calling convention to these architectures

The linker emits far fewer relocations. As a result, most codebases will link faster, require less memory to link, and generate smaller binaries. Tools that process Go binaries should use Go 1.18's debug/gosym package to transparently handle both old and new binaries.

TLS 1.0 and 1.1 disabled by default client-side

Rejecting SHA-1 certificates

Also until specific features for 1.18 are used (like the use of generics) it will still be possible to compile with go 1.17

As mentioned in #153, the version in the go.mod is the minimum version. go 1.17 simply means that the oras-go library can be compiled against go 1.17, 1.18, and newer versions.

Closing as this issue is succeeded by #261


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter sonoff for common errors and appropiate suggestions to keep this adapter up to date.
Please see the result of the check below.
ioBroker.sonoff
   -

ERRORS:

[ ] :heavy_exclamation_mark: [E035] No devDependency declared for @iobroker/testing. Please add "@iobroker/testing":"4.1.3" to devDependencies at package.json

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.
[ ] :eyes: [W519] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be considered as a suggestion and be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence

This issue has been replaced by new isse #391
This issue can be closed.
your
ioBroker Check and Service Bot


Building setup-app on Linux fails

The method getPassword() in build.gradle doesn't work on Linux.
It is used to get the password for the keystore interactively on the commandline to sign the app.
A workaround is to not use the method and instead either hardcoding the password or setting it to an empty string (app can't be signed then): def password = "" //getPassword("android_keystore").

We only support OS X for now.


Tooltips are clickable

Godot version
6263f58
System information
W10
Issue description
You can hover mouse on the tooltips and click them:

Notice how the main window gets unfocused as I click the tooltip. It will also block my clicks.
Steps to reproduce

Hover over something so a tooltip appears
Move your cursor over the tooltip
Click

Minimal reproduction project
No response

Should be fixed by #48186


chore(deps): update terraform ibm to latest for deployable modules / architectures

This PR contains the following updates:

Package
Type
Update
Change

ibm (source)
required_provider
patch
>= 1.68.0 -> >= 1.68.1

ibm (source)
required_provider
patch
1.68.0 -> 1.68.1

Release Notes

IBM-Cloud/terraform-provider-ibm (ibm)
v1.68.1
Compare Source
BugFixes

Fix code engine job regression (5545)
Update(Cloud-Databases): Added hints for region and location mismatches (5557)
fix(Cloud-Databases): Remove deprecated connectionstrings attribute (5554)
remove the return value from waitForVpcCluster (5557)
fix: read endpoint type from schema (5552)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 3.0.1 :tada:
The release is available on:

GitHub release
v3.0.1

Your semantic-release bot :package::rocket:


Lift searchOffset state up to Sidebar

Fixes #87

Lifted the searchOffset, setSearchOffset state into the Sidebar component
Changed some dependencies for useEffect to include function calls (these likely never changed before, but ESLint was yelling at me)
Removed an effect that was clearing the searchOffset every time the SearchView component was rendered, including initial render.
Apparently hit Cmd+S and my prettier went ham

One thing I'd like is to be able to add tests to prevent regression for stuff like this, but I don't know how.


Removed some unused imports

Removed some unused imports.
Wasn't sure if it's ok to remove the intake import or not in Plotting.ipynb?

Ignore deliberate side effect imports:
diff --git a/tox.ini b/tox.ini
index 8ab9e46..25834a4 100644
--- a/tox.ini
+++ b/tox.ini
@@ -73,7 +73,8 @@ norecursedirs = doc .git dist build _build .ipynb_checkpoints
 #                   .*gallery/bokeh/xarray_gridded\.ipynb$
 #                   .*gallery/.*/xarray_image\.ipynb$
 #                   .*gallery/.*/xarray_quadmesh\.ipynb$
-
+nbsmoke_flakes_to_ignore = .*hvplot\..* imported but unused.*
+
 [flake8]
 include = *.py
 # run_tests.py is generated by conda build, which appears to have a

(nbsdev) D:\code\pyviz\hvplot>pytest -v --nbsmoke-lint --nbsmoke-lint-debug examples
=============================================================== test session starts ================================================================
platform win32 -- Python 3.6.8, pytest-4.4.1, py-1.8.0, pluggy-0.9.0 -- d:\venvs\nbsdev\scripts\python.exe
cachedir: .pytest_cache
rootdir: D:\code\pyviz\hvplot, inifile: tox.ini
plugins: cov-2.7.1, nbsmoke-0.2.8.post44+gbdfd485
collected 11 items / 22 skipped

examples/homepage.ipynb::D:\code\pyviz\hvplot\examples\homepage.ipynb PASSED                                                                  [  9%]
examples/user_guide/Customization.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Customization.ipynb PASSED                                  [ 18%]
examples/user_guide/Geographic_Data.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Geographic_Data.ipynb PASSED                              [ 27%]
examples/user_guide/Gridded_Data.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Gridded_Data.ipynb FAILED                                    [ 36%]
examples/user_guide/Introduction.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Introduction.ipynb PASSED                                    [ 45%]
examples/user_guide/NetworkX.ipynb::D:\code\pyviz\hvplot\examples\user_guide\NetworkX.ipynb FAILED                                            [ 54%]
examples/user_guide/Plotting.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Plotting.ipynb FAILED                                            [ 63%]
examples/user_guide/Statistical_Plots.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Statistical_Plots.ipynb PASSED                          [ 72%]
examples/user_guide/Streaming.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Streaming.ipynb PASSED                                          [ 81%]
examples/user_guide/Subplots.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Subplots.ipynb FAILED                                            [ 90%]
examples/user_guide/Viewing.ipynb::D:\code\pyviz\hvplot\examples\user_guide\Viewing.ipynb FAILED                                              [100%]

===================================================================== FAILURES =====================================================================
___________________________________________________________________ test session ___________________________________________________________________
D:\code\pyviz\hvplot\examples\user_guide\Gridded_Data.ipynb
** line 18 col 0: 'numpy as np' imported but unused
To see python source that was checked by pyflakes: D:\code\pyviz\hvplot\examples\user_guide\Gridded_Data.nbsmoke-debug-postmagicprocess.py
To see python source before magics were handled by nbsmoke: D:\code\pyviz\hvplot\examples\user_guide\Gridded_Data.nbsmoke-debug-premagicprocess.py
___________________________________________________________________ test session ___________________________________________________________________
D:\code\pyviz\hvplot\examples\user_guide\NetworkX.ipynb
** line 18 col 0: 'numpy as np' imported but unused
** line 443 col 0: 'matplotlib.pyplot as plt' imported but unused
** line 524 col 4: redefinition of unused 'pygraphviz' from line 275
** line 524 col 4: 'pygraphviz' imported but unused
** line 529 col 8: redefinition of unused 'pydot' from line 279
** line 529 col 8: 'pydot' imported but unused
To see python source that was checked by pyflakes: D:\code\pyviz\hvplot\examples\user_guide\NetworkX.nbsmoke-debug-postmagicprocess.py
To see python source before magics were handled by nbsmoke: D:\code\pyviz\hvplot\examples\user_guide\NetworkX.nbsmoke-debug-premagicprocess.py
___________________________________________________________________ test session ___________________________________________________________________
D:\code\pyviz\hvplot\examples\user_guide\Plotting.ipynb
** line 16 col 0: 'intake' imported but unused
To see python source that was checked by pyflakes: D:\code\pyviz\hvplot\examples\user_guide\Plotting.nbsmoke-debug-postmagicprocess.py
To see python source before magics were handled by nbsmoke: D:\code\pyviz\hvplot\examples\user_guide\Plotting.nbsmoke-debug-premagicprocess.py
___________________________________________________________________ test session ___________________________________________________________________
D:\code\pyviz\hvplot\examples\user_guide\Subplots.ipynb
** line 18 col 0: 'numpy as np' imported but unused
To see python source that was checked by pyflakes: D:\code\pyviz\hvplot\examples\user_guide\Subplots.nbsmoke-debug-postmagicprocess.py
To see python source before magics were handled by nbsmoke: D:\code\pyviz\hvplot\examples\user_guide\Subplots.nbsmoke-debug-premagicprocess.py
___________________________________________________________________ test session ___________________________________________________________________
D:\code\pyviz\hvplot\examples\user_guide\Viewing.ipynb
** line 42 col 9: undefined name 'display'
To see python source that was checked by pyflakes: D:\code\pyviz\hvplot\examples\user_guide\Viewing.nbsmoke-debug-postmagicprocess.py
To see python source before magics were handled by nbsmoke: D:\code\pyviz\hvplot\examples\user_guide\Viewing.nbsmoke-debug-premagicprocess.py
================================================= 5 failed, 6 passed, 22 skipped in 20.49 seconds ==================================================

Haven't decided yet what nbsmoke should do about display(). I'd like it to complain by default (requiring display to be explicitly imported), but I'm open to suggestions about that. I didn't look at the graphviz/dot bits of the networkx example.

Oops, I see my local copy was not up to date. I'll rebase and cross my fingers...

It looks to me like the intake import should be marked #noqa; even if the import is not required for the notebook to run, intake itself appears to be required, so it doesn't hurt to be explicit in the notebook about that.

Oh, and we always want to import display explicitly; I don't like relying on IPython's prior imports.

Thanks this is  good start! I should be able to track down more in my docs sweep.


Angular 5.0 and Angular-Split 0.2.7

Hi,
First of all, thanks for your work on Angular-Split. :-)
I'm trying to install in Angular 5.0, but it 0.2.7 is not working. I think 0.2.7 is for 4.0, but the code is updated to 5.0. Is there a way I can use it before you release the new code by NPM?
Thanks,
Rafa

try 1.0.0-beta.5 with ng5

angular-split 0.2.7 should works with angular 5.0.0, here is a demo showing it:
https://stackblitz.com/edit/angular-lkn9uz?file=app%2Fhello.component.ts
Test to uninstall an reinstall it:
npm uninstall angular-split
npm install<EMAIL_ADDRESS>

But like @zanecat said, you can use 1.0.0-beta.6 with angular 5.0.0 minimum.


Dark mode using media selector

Please add support for media selector darkMode instead of class.

Hello,
thanks for raising this issue. I will look into adding native support for this in the library.
In the meantime - please do the following:

copy the theme: https://github.com/Yonom/assistant-ui/blob/main/packages/react/src/styles/themes/default.css
paste it to your globals.css
update the dark mode CSS selector

Hope this helps!
Best
Simon


style: format header to fix ci errors

Signed-off-by: Jason Liu<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

Codecov Report

Merging #167 (4adc20d) into main (6db62c3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 4adc20d differs from pull request most recent head 1b18060. Consider uploading reports for the commit 1b18060 to get more accurate results

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   57.82%   57.82%
=======================================
  Files          91       91
  Lines        8159     8159
=======================================
  Hits         4718     4718
  Misses       3029     3029
  Partials      412      412

Flag
Coverage Δ

unittests
57.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/koordlet/metricsadvisor/be_collector.go
68.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db62c3...1b18060. Read the comment docs.

/lgtm
/approve


feat: update esbuild config to support building multiple files for main

Electron noticed the plan that it will limit the direct access to the node components such as require() and process.env from v12.
So some electron users are supposed to set nodeIntegration: false, contextIsolation: true and preload: 'preload.js' for webPreferences of the window.
The current esbuild configuration is only for a single entry point (main/index.ts). So it is not able to build additional files like preload.js. This PR make it supports building multiple files for main.

Thanks for explanation and the PR!

changes are released

Fantastic! Thanks a lot for the quick turnaround @karolis-sh, and thank you @wisedier for the PR! 🚀


Update python:3.10-slim Docker digest to cc91315

This PR contains the following updates:

Package
Type
Update
Change

python
final
digest
2bac437 -> cc91315

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the python cc91315 update again.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Would it be possible for a markdown-it plugin to implement attribute lists, meta data extension?

Would it be possible for a markdown-it plugin to implement the Maruku meta data extensions (inline attribute lists and attribute list definitions)?
These are really useful for being able to set a few key attributes like id and class without having to switch into full html. They are also real useful for setting attributes on links and images, so you can make some links nofollow or set the target. Very useful. I have used these with Maruku in the past on Ruby and loved them, I am really wishing that one of these parsers would implement so I can use them now with javascript.
See: http://maruku.rubyforge.org/proposal.html
A few details from the proposal page:
This proposal describes two additions to the Markdown syntax:
inline attribute lists (IAL)
## Header ##       {: key=val .class #id ref_id}

attribute lists definitions (ALD)
{:ref_id: key=val .class #id}

Every span-level or block-level element can be followed by an IAL:
### Header ###     {: #header1 class=c1}

Paragraph *with emphasis*{: class=c1}
second line of paragraph
{: class=c1}

In this example, the three IALs refer to the header, the emphasis span, and the entire paragraph, respectively.
IALs can reference ALDs. The result of the following example is the same as the previous one:
### Header ###  {: #header1 c1}

Paragraph *with emphasis*{:c1}
second line of paragraph
{:c1}

{:c1: class=c1}

https://github.com/andrey-p/markdown-it-classy
There are no way to implement it correct via plugin (i don't count all rules rewrite), because definition has problems with consistency. We postponed all related work on this kind of extension, until it's done in commonmark spec. That will happen sometime, but no deadlines known. Until that happens, you can try hack from link above.

@puzrin Thanks for letting me know. I'm glad there is discussion about this to standardize and improve the spec. It's great stuff. Thanks for pointing me to classy plugin, that could help for some things.

@puzrin @jeffbski Probably worth mentioning that I haven't yet managed to port markdown-it-classy to work with markdown-it version 4 and above - it's on my todo list for this week.

@andrey-p  thanks for info. If you need help - let me know.

@andrey-p thanks for the heads up.


⚠ Bofrost.at has degraded performance

In 33323a1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1321 ms

Resolved: Bofrost.at performance has improved in f42dc41 after 6 minutes.


Bug: input background color for invite editors is not great in darkMode

Problem

fixed on the next release!


This is an Issue Title

here is issue's comment.

good one, and I think this can solved like.....


Error trying to connect redux-form

Hello guys, I'm currently facing troubles when I try to connect my redux form using reduxForm({..})
Here is the pastebin: http://pastebin.com/eZrz2xtz
Does anyone have an idea why I get this error?
Best,

@billyshena what version of redux-form are you using?
In v6 you have to connect using redux using connect rather than relying on reduxForm.

@JMacLulich I'm currently using v6
Here is the part where I connect redux form
LoginPanel = reduxForm({
  form: 'auth' // a unique name for this form
})(LoginPanel);

Hi @billyshena
Just me, but I usually use the same name for the form in the store as the name of the React object, like so:
LoginPanel = reduxForm({
  form: 'LoginPanel' // a unique name for this form
})(LoginPanel);

You then have to connect to redux, something like this:
LoginPanel  = connect(mapStateToProps, undefined, undefined, { withRef: true })(LoginPanel)
The mapStateToProps function is your normal mapping function for react-redux, but if you didn't have one, you would just supply undefined here.
I've included { withRef: true} here only because I want to be able to access the reduxForm to call submit() on it from outside the wrapped component. This is purely a react-redux thing.
Hope this helps.
Jason.


Compile on Godbolt link maybe broken

Hi Iliass (@imahjoub) I notice that the "try it on Godbolt" button links to code that fails compile.
This link is one potential solution that repairs it. There are several possible ways to repair and i'm not sure which one you like. That link does link to one possible correciotn.
Nice work on this repo iliass.

Hi Chris,
yes I changed the code and forgot to update Godbolt link. I will use your link.
Many thanks :)

issue handled in PR#89

Thanks Iliass it works (@imahjoub)


Revert "Retry 'Retryable' requests to dynamoDB"

Reverts weaveworks/cortex#480

./tools/test -netgo

# github.com/weaveworks/cortex/pkg/chunk

pkg/chunk/aws_storage_client_test.go:221: cannot use dynamoDBMockRequest literal (type *dynamoDBMockRequest) as type dynamoDBRequest in return argument:

	*dynamoDBMockRequest does not implement dynamoDBRequest (missing Retryable method)

pkg/chunk/aws_storage_client_test.go:230: cannot use m (type *dynamoDBMockRequest) as type dynamoDBRequest in return argument:

	*dynamoDBMockRequest does not implement dynamoDBRequest (missing Retryable method)

FAIL	github.com/weaveworks/cortex/pkg/chunk [build failed]

ok  	github.com/weaveworks/cortex/pkg/configs/api	0.017s

ok  	github.com/weaveworks/cortex/pkg/configs/client	0.085s

ok  	github.com/weaveworks/cortex/pkg/distributor	0.012s

ok  	github.com/weaveworks/cortex/pkg/ingester	6.720s

ok  	github.com/weaveworks/cortex/pkg/ring	0.009s [no tests to run]

ok  	github.com/weaveworks/cortex/pkg/ruler	0.103s

ok  	github.com/weaveworks/cortex/pkg/util	0.008s


Check of common values is failing

It seems that the CI job for make check-common-values is not working, possibly because we are using the wrong yq dependency (see here).
It would have catched the discrepancy with common-values.yaml and each of the other values.yaml.
Originally posted by @viccuad in https://github.com/kubewarden/helm-charts/pull/476#discussion_r1670631049

More info about this issue: https://github.com/kubewarden/helm-charts/pull/476#discussion_r1672682614


Investigate perf issue

So Russel Winder says on https://www.youtube.com/watch?v=Q_Z_8HXt68k that Ceylon is 10 times slower than other languages for this benchmark: https://github.com/russel/Pi_Quadrature/tree/master/Ceylon/source/uk/org/winder/pi_quadrature
We have to check that and see if there's any truth and how to improve if yes.

For pi_sequential_loop vs. Pi_Sequential, it looks like the difference is due to int vs long loop variables.

Benchmark
Elapsed Time

gradle run_Pi_Sequential (java)
6.026402439

gradle run_Pi_Sequential (java replacing int with long)
9.876295689

ceylon pi_sequential_loop
9.972917

There's probably some optimization to be had by using while instead of for in the Ceylon code. But the difference doesn't show up for this simple benchmark without warmup.
Note: there are several other tests that I didn't look at.

The compiled Ceylon code for the above benchmark:
    public static void run() {
        final long n =<PHONE_NUMBER>L;
        final double delta = 1.0 / n;
        final long startTime = .ceylon.language.system_.get_().getNanoseconds();
        double sum = 0.0;
        final long $ceylontmp$first$2 = 1L;
        final long $ceylontmp$last$3 = n;
        final boolean $ceylontmp$increasing$4 = .ceylon.language.Integer.offset($ceylontmp$last$3, $ceylontmp$first$2) >= 0;
        final long $ceylontmp$incr$5 = $ceylontmp$increasing$4 ? 1L : -1L;
        long i$8 = $ceylontmp$first$2;
        long $ceylontmp$element$7 = $ceylontmp$first$2;
        boolean $ceylontmp$f$6 = false;
        loop_0: do {
            if ($ceylontmp$f$6) $ceylontmp$element$7 += $ceylontmp$incr$5;
            $ceylontmp$f$6 = true;
            i$8 = $ceylontmp$element$7;
            final long i = i$8;
            $ceylontmp$continue$1: do {
                final double x = (i - 0.5) * delta;
                sum += 1.0 / (1.0 + x * x);
            }             while (false);
        }         while ($ceylontmp$increasing$4 ? i$8 - $ceylontmp$last$3 != 0L : i$8 - $ceylontmp$last$3 != 0L);
        final double pi = 4.0 * delta * sum;
        final double elapseTime = (.ceylon.language.system_.get_().getNanoseconds() - startTime) / 1.0E9;
        .uk.org.winder.pi_quadrature.tools.output_.output("pi_sequential_loop", pi, n, elapseTime);
    }

vs. the original int based Java code:
  public static void main(final String[] args) {
    final int n = 1_000_000_000;
    final double delta = 1.0 / n;
    final long startTimeNanos = System.nanoTime();
    double sum = 0.0;
    for (int i = 1; i <= n; ++i) {
      final double x = (i - 0.5) * delta;
      sum += 1.0 / (1.0 + x * x);
    }
    final double pi = 4.0 * delta * sum;
    final double elapseTime = (System.nanoTime() - startTimeNanos) / 1e9;
    Output.out(Pi_Sequential.class, pi, n, elapseTime);
  }

By reading the code, the difference looks like it would be due to the for loop complexity. But again, for this test, it isn't.

FTR, with the while loop optimization, I'm getting 9.688739 in Dart :P
$ ceylon run-dart uk.org.winder.pi_quadrature
========================== pi_sequential_loop
	π = 3.141592655589971
	iteration count =<PHONE_NUMBER>
	elapse time = 9.688739

or 14.785866 with the code as-is.

it looks like the difference is due to int vs long loop variables

Yeah, the reason is that the JVM inserts save points in for loops with long counters but not in for loops with int counters. To my mind, that's a pretty damn bizarre behavior, but that's what it does.

Look at his code, he does ten times less iterations in Ceylon as for the other Languages, so the diff is more than that.

@FroMage I accounted for that. The difference is small.

 So the diff is not that much now? Or was it another test?

Must have been a test that boxes then.

See my reddit comment - what is presented in the video is inconsistent. My best guess is that he tried run-js at some point, and was mixing up the JVM and JS backends.

Hurray for our intrepid reporter! :)

And even then what he says makes no sense. The Ceylon code runs in 1.04 seconds but then he says "Remember that it's a 100 times less iterations" and then "I didn't want to make you wait for a 104 minutes? Eh what? Since when are 1.04s times 100 a 104 minutes instead of 1 minute 44 seconds?

Damn, we have to talk to Russell about this. Thanks John.

"Remember that it's a 100 times less iterations"

I just jumped to few slides, but isn't it only 10 times less iteration.
final int n = 1_000_000_000; vs value n = 100_000_000;

sorry, John spotted it out already

OK, so when I put everything at the same iterations, and fix a couple of bugs in the benchmark:

Benchmark
Java
Ceylon 1.2
Ceylon 1.1
Kotlin

futures loop 1 task
12
12
12
N/A

futures loop 2 task
6
6
6
N/A

futures loop 8 task
1.2
1.5
1.5
N/A

futures loop 32 task
0.9
1.1
1.1
N/A

futures map/reduce 1 task
N/A
12
15
N/A

futures map/reduce 2 task
N/A
16
10
N/A

futures map/reduce 8 task
N/A
16
12
N/A

futures map/reduce 32 task
N/A
9
7
N/A

sequential comprehension
N/A
12
15
N/A

sequential loop
8
12
12
8

sequential map/reduce
9
12
15
12

parallel streams
N/A
N/A
N/A
11

sequential reduce
N/A
N/A
N/A
4

sequential streams
N/A
N/A
N/A
11

So we're in the same ballpark except for the int/long difference. We also improved from 1.1 to 1.2 except in the weird case of futures map/reduce which I can't quite understand.

 Perhaps two threads isn't enough to offset additional gc locking complexity? In any event, adjusting Task to:
  class Task(Integer id) satisfies Supplier<Float> {
    shared actual Float get() {
      value start = 1 + id * sliceSize;
      value end = (id + 1) * sliceSize;
      /*
      return (start..end).map((Integer i) {
        value x = (i - 0.5) * delta;
        return 1.0 / (1.0 + x * x);
      }).reduce(plus<Float>);
      */
      variable value total = 0.0;
      for (i in start..end) {
        value x = (i - 0.5) * delta;
        total += 1.0 / (1.0 + x * x);
      }
      return total;
    }
  }

results in timings of 9.7, 4.9, 2.4, and 1.6 w/8 cores.

PS: it might be good to mention what the numbers actually mean (times, iterations?) and whether higher/lower is considered better. Right now I'm a bit lost trying to figure things out :)

The results correspond to "futures map/reduce x task" in the table, with x being the number of threads. The work is evenly divided among x threads.

@jvasileff sorry, I was actually referring to Stef's table :)
The comment "we also improved from 1.1 to 1.2" threw me off because looking at the two columns it seems to me a) that about half of the numbers stayed the same and b) except for one all of the rest of the numbers seem to have gone up instead of down. Assuming lower numbers are better I don't see how we have improved :)

Sorry my numbers are in seconds.

OK, well, closing then. Mystery solved.


unnecessary left (

Maybe the left most ( is unnecessary.

It's useful to compare to the adjacent parenthesis so I think we'll keep it. Thanks for sending this in though!


Add metrics server

What this PR does / why we need it: Adds metrics server as a default add-on from Kubernetes 1.7 onwards
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): related to #427
Add metrics-server add-on from Kubernetes version 1.7 onwards

/test puppet-roles-verify

/test puppet-roles-verify

/assign @simonswine

Thanks @dippynark
/approve
/lgtm


public configuration, only other clisters of the currently configured…

… object are cloned, remove step bar
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@codding-y PTAL


WP admin Top bar showing over the top of the top menu bar

is there an easy fix - other than moving the menu bar down using css - to stop the admin bar covering the foundation top bar?

@dblackw, the easy fix is to hide the WP adminbar on front end. You can do so at My Account -page.
Unfortunately, FoundationPress does not include the Edit Post Link on its templates, so it could get tricky to get to the back end. I suggest you add it to your templates: https://codex.wordpress.org/Function_Reference/edit_post_link

@dblackw : Not sure if I understand what you mean? This is what is looks like on a fresh install. The WP-admin bar on top (if logged in, of course) and the site menu located just below.

@olefredrik, I guess @dblackw is using fixed class with top-bar. We still need Edit Post Link at least on page.php and single.php. What do you think?

Yes I'm using the fixed class - I have made a conditional Css fix if logged in

@dblackw, how's about sharing your fix?


Update getting started link

https://github.com/balena-os/resin-intel/blob/f0df498b5324a946941ea50ebacc993f300745a2/genericx86-64.coffee#L38-L40
should be changed to point to https://www.balena.io/docs/learn/getting-started/intel-nuc/nodejs/

@shaunmulligan so shall we change the getting started links for all the boards in the same fashion as you suggested here?

@garethtdavies are you the person to go about this sort of bugs?

@floion yes! I've opened a PR for this and I'll go through the other repos. Specifically, on this one there are no Surface getting started docs so, for now, are the NUC docs the best place?


Splash damage

Sometimes splash damage doesn't register

Okay I am pretty sure this happens because I put the splash damage code in AAscProjWeap (it's all prototype code, folks). If the projectile is destroyed before the splash damage is applied, no splash damage occurs! I suppose the way to fix this would be to move the code out of AAscProjWeap, but still need to determine the best/correct way to doing it (as well as verify this is the cause of the actual bug).


Issue in the image size

When I hit the toggle button the image doesn’t shrink to be a small icon on the left top like in the demo.
One more thing, when I compiled the less file, some lines in the css file stile underlined red as if something wrong in the copiled file. The overall, is the cards working well except for the image doesn’t get shrinked to be like an icon image in the top left corner of the card.
Below are two cards one before I hit the toggle button and the second one After.

Hi @adelgebeely2020 show me your code, please.
I need more details, let me know


HierarchicalRoleInterface problem

here https://github.com/ZF-Commons/zfc-rbac/blob/develop/src/Role/HierarchicalRoleInterface.php#L36 maybe we could change the return type to iterable?
public function getChildren(): array;
// to
public function getChildren(): iterable;

Then when working with doctrine I could just return ArrayCollection, but now I have to do this:
public function getChildren(): array
{
    return $this->children->toArray();
}

Sounds reasonable


when send in text, both text and attachment got check up

AFTER_SEND : {"message": {"attachment": "test", "metadata": null, "quick_replies": null, "text": "test"}, "notification_type": null, "recipient": {"id": "1208595212586466", "phone_number": null}, "sender_action": null}
RESPONSE : {"error":{"message":"(#100) Only one of text or attachment can be specified","type":"OAuthException","code":100,"error_subcode":2018018,"fbtrace_id":"Ft9OlIgxEe4"}}
<IP_ADDRESS> - - [06/Mar/2017 21:03:57] "POST /webhook HTTP/1.1" 200 -

thank you. fixed.


Validate the path

We should be validating the path portion of publicPaths is a valid URI path.

It looks like this was addressed in 35402263aee65befc638f338839681b970ff8f84.


Added application recipient store

Implemented a whitelist of users to receive application submitted notifications

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2350
#2349
#2348  👈
#2347
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite

ahh that does make a lot more sense. I was trying to not disturb the existing user_deliverable_categories but I like the approach you outlined a lot more.