"MAVSDK" and "Arducopter SITL" incompatibility (and fly_qgc_mission.cpp and QGC incompatibility)

Hi,
I'm the current maintainer of Rosetta Drone 3, a MAVLink implementation for DJI drones.
We are testing MAVSDK to send a QGC mission to Arducopter SITL using fly_qgc_mission.cpp.
We identified at least two issues:

ISSUE 1: telemetry.health_all_ok() is always false
ISSUE 2: Arducopter doesn't start the mission but disarms.

Everything works fine sending the mission from QGC to Arducopter SITL instead of using fly_qgc_mission.cpp.
Output of fly_qgc_mission.cpp:

	Waiting to discover system...
	Discovered autopilot
	Waiting for system to be ready	<--- BUG 1: blocks on while (!telemetry.health_all_ok())
	(Waiting disabled by me, for testing)
	System ready
	Importing mission from mission plan: /data/data/com.termux/files/home/imatronix/server/test/p9-quillota.plan
	Found 10 mission items in the given QGC plan.
	Uploading mission...Mission uploaded.
	Arming...
	Armed.

Output of arducopter.exe:

	...
	AP: EKF3 IMU0 is using GPS
	AP: EKF3 IMU1 is using GPS
	AP: Terrain: clamping offset 435 to 15
	AP: Arming motors
	ARMED
	Mode AUTO
	AP: Mission: 1 Takeoff
	waypoint 1

	(little pause, probably a timeout)

	AP: Disarming motors	<--- BUG 2: Unexpected disarm. Why? There is no problem when sending the same mission from QGC
	AP: Mission: 1 Takeoff
	DISARMED

Are this incompatibilities intentional?
How do we make this world better?
IMO fly_qgc_mission.cpp is suposed to send QGC missions, so I would expect it to speak the same language as QGC (or rename it to fly_qgc_mission_in_unintelligible_accent.cpp).

Regarding the health fields: that was just some proxy that I came up with which tended to work ok with PX4. It's not properly done as it should. It should probably depend on the health.is_armable flag instead which is basically MAV_SYS_STATUS_PREARM_CHECK.
It would probably be a good idea to remove the health_is_all_ok in MAVSDK v2 and recommend is_armable everywhere.
Now when it comes to missions that's a bit harder because various items get interpreted differently, and then the mission transfer is also different, ArduPilot putting home into item 0 and starting with item 1 for the mission while PX4 just starts at 0.
For your exact problem, I'm not sure what exactly it is, but let's try to debug it and fix it.

Are this incompatibilities intentional?

No, just the way things were standardized appropriately or interpreted differently and have developed from there.

How do we make this world better?

There is a two-weekly MAVLink dev call where we discuss what gets added to MAVLink and how PX4 and ArduPilot can slowly become more compatible. However, progress is hard, because often to become more compatible requires changes which would break backwards compatibility or additions of new mechanisms which require implementing or add complexity.
But anyway, let's debug what you're stuck on and go from there.
Any chance you can provide me code or steps how I can reproduce the issue?

Thanks @julianoes,
I got fly_qgc_mission.cpp working with Arducopter SIT.
I had to disable the telemetry.health_all_ok() and set AUTO_OPTIONS = 10 in Arducopter SITL.
More info here.
But this was just the initial test.
Where I really need help is in getting MAVSDK / fly_qgc_mission.cpp to work with Rosetta, which already works fine with QGC.
I will create an issue here: https://github.com/The1only/rosettadrone/issues/120

Hi @kripper, nice work with Rosettadrone!
I think QGC mission from a file would not work as it is. This is because APM expects slightly different mission sequences. As a side not, APM expects first mission item as the home position and second mission item as takeoff. QGC does this conversion when uploading the mission to the autopilot but the example file you mentioned does not.
Please use the MAVSDK integration tests as basis for mission upload to APM SITL. There are two separate tests in this file, one each for PX4 and APM.
See how mission upload, arm and takeoff are executed in a sequence to run the mission with APM in this function: APM Mission Raw Integration test
Also see how the mission plan is created in Create Mission Plan Raw for APM
Hope this helps :)
Best,
khedar

It would probably be a good idea to remove the health_is_all_ok in MAVSDK v2 and recommend is_armable everywhere.

Yes. Having a universal is_armable check that each fight controller knows how to interpret depending on their features and sensors is a good idea.
BTW, when sending the first mission from QGC, we get an error saying that the aircraft is unable to arm even when it 1) sends the ACK to the arm/disarm command, 2) send the ACK to the set-flight-mode command and 3) informs that the flight mode is GUIDED in the next heartbeat.
I think I have seen this also once with arducopter SITL.
I believe QGC then disables the arming check and it works the second time...or we switch the fight mode to auto to get Rosetta actually starting the mission.
This only happens with QGC. With the C++ example, the mission starts flawlessly. Anyway, we should better fix this issue with QGC.

Now when it comes to missions that's a bit harder because various items get interpreted differently, and then the mission transfer is also different, ArduPilot putting home into item 0 and starting with item 1 for the mission while PX4 just starts at 0.

I don't see a problem if the first item is a set-home-location or a take-off.
All models can and should support both sequences.

There is a two-weekly MAVLink dev call where we discuss what gets added to MAVLink and how PX4 and ArduPilot can slowly become more compatible. However, progress is hard, because often to become more compatible requires changes which would break backwards compatibility or additions of new mechanisms which require implementing or add complexity.

Good. On the long term, it pays off.
Congratulations. I admire your work on QGC.
Tomorrow I'll try to replay some logs with QGC.
I was looking for a debugging tool for Rosetta''s ground based "fight controller" (MissionManager) that uses virtual sticks to fly the missions.
I experienced an issue that didn't occur in the simulator, so the logs are crucial.

BTW, when sending the first mission from QGC, we get an error saying that the aircraft is unable to arm even when it 1) sends the ACK to the arm/disarm command, 2) send the ACK to the set-flight-mode command and 3) informs that the flight mode is GUIDED in the next heartbeat.

I think I see something similar often with PX4 but I never quite tried to get to the bottom of it. Or at least it's a similar "try again and it works on the second try" sort of thing.

Yes, it's like a first time timeout. I believe I've also seen a message saying something like "arm check disabled".
I believe this is on the QGC side.


Deno Preact support?

Amazing project! I'm very excited at the prospect of software creators and designers in particular being able to use a component library directly in this highly intuitive manner. Well done!
I'm curious what the path might look like in supporting preact, specifically for deno/fresh?
Great concept, well executed — thanks for putting this out there!

Hey @will-weiss, thanks for the kind words!
I've not used deno or fresh, but I can't see an obvious reason as to why it wouldn't work as-is, besides some preact peer dependency warnings. Perhaps it's worth giving it a go and reporting back?
If you can get it working, it would be good to have it captured somewhere (at the very least documented in this issue, but maybe as an example application or added to the generator).
If there are any easy changes I can make to help, I'll see what I can do.

I'm going to move this over to Discussions for the time being :)


after running sc.pp.highly_variable_genes, the sc.pp.scale get error？？？

hello, recently I use the scanpy package to preprocess the single cell rna-seq data, the following is my process step. But when I go to the last step, namely I want to scale the dataset, the error occurs. I have 4271 cells and 1024 genes after running "adata = adata[:, adata.var["highly_variable"]]". But the error says the 4271 is not equal to 1024 in the dimension 0.  I do not know the reason, so can you give me an answer?Thanks very much.
sc.pp.filter_genes(adata, min_counts = filter_min_counts)
sc.pp.filter_cells(adata, min_counts = filter_min_counts)
sc.pp.normalize_per_cell(adata)
sc.pp.log1p(adata)
sc.pp.highly_variable_genes(adata, min_mean=0.0125, max_mean=3, min_disp=0.5, subset=True)
adata = adata[:, adata.var["highly_variable"]]
sc.pp.scale(adata)

Hey!
Using the latest verisons of scanpy and anndata, I have tried reproducing this via:
adata = sc.datasets.pbmc3k()
sc.pp.filter_genes(adata, min_counts = 10)
sc.pp.filter_cells(adata, min_counts = 10)
sc.pp.normalize_per_cell(adata)
sc.pp.log1p(adata)
sc.pp.highly_variable_genes(adata, min_mean=0.0125, max_mean=3, min_disp=0.5, subset=True)
adata = adata[:, adata.var["highly_variable"]]
sc.pp.scale(adata)

and I don't get an error. Could you reproduce this error with one of the datasets in sc.datasets? That way I could try to reproduce your error. Also, which version of anndata and scanpy are you on?
Other than that, you don't need the line adata = adata[:, adata.var["highly_variable"]] if you use subset=True in the sc.pp.highly_variable_genes() call.


Fix CI

FYI @oconnor663

(Not sure why my earlier PR went green)

https://travis-ci.org/keybase/saltpack/jobs/347390394 definitely shows an error but it went green anyway. welp.

Coverage remained the same at 84.756% when pulling aef6d987cdd7cf8e8b39087816e403843d6a0573 on akalin/fix-ci into aa09e3282650ead27093b6209ab12f4a4fc31924 on master.

Coverage remained the same at 84.756% when pulling aef6d987cdd7cf8e8b39087816e403843d6a0573 on akalin/fix-ci into aa09e3282650ead27093b6209ab12f4a4fc31924 on master.

Coverage remained the same at 84.756% when pulling 52a7baa542b5e62f46362d0bae45befce0ed146b on akalin/fix-ci into aa09e3282650ead27093b6209ab12f4a4fc31924 on master.


[bugfix] Move setup handling to the training type plugin

What does this PR do?

This PR makes sure each plugin always call datamodule setup within a distributed setting.
Fixes #https://github.com/PyTorchLightning/pytorch-lightning/issues/8872
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@tchaton isn't the problem in #8872 that deepspeed calls model.train_dataloader() arbitrarily? In PL, the trainer is usually the one that accesses the dataloader through the attach and reload functions. Therefore, I cannot see how this PR can possibly fix that by moving setup(), which will affect all plugins and will be backward incompatible. Also, we lose again hook call order consistency.

I agree with @awaelchli here. IMO we should go along with #6030 and if we resolve the data as early as possible, we should also be save with #8872 if I understood it correctly

@tchaton isn't the problem in #8872 that deepspeed calls model.train_dataloader() arbitrarily? In PL, the trainer is normally the one that accesses the dataloader through the attach and reload functions. Therefore, I cannot see how this PR can possibly fix that by moving setup(), which will affect all plugins and will be backward incompatible. Also, we lose again hook call order consistency.
If a plugin calls hooks at arbitrary places, it is only appropriate that the plugin documents this (such as the case with model.train_dataloader() reported)

Hey @awaelchli @justusschock @ananthsub,
I agree there is no perfect way to resolve this and yes DeepSpeed plugin is hacking around to access the batch_size, however I believe it is important to make sure setup is always called within a progress group initialised which is currently not the case for ddp_spawn and DeepSpeed.
Best,
T.C


linting: no-else-return

Problem:

remove if / else syntax for returns and throws in favour of simple ifs

Motivation:
using if else, especially nested ones, increases the amount of indentation, very often reducing readability. (mostly because you don't know which if and else match). Using ifs in new lines should make it more readable, reduce horizontal space.
The best example of motivation is probably in: packages/util/src/errors.ts file

Also removed file which was nowhere used ;)


Markdown preview is broken in 1.3.0 release

VSCode Version: Code 1.3.0 (e724f269ded347b49fcf1657fc576399354e6703, 2016-07-07T16:56:12.476Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:

Open a markdown file
the magnifier glass for preview is absent on the top right

see also #8130
Ctrl+Shift+V works fine

https://github.com/Microsoft/vscode/issues/7666 for the issue that the action moved into the tab context menu.

I believe this was fixed by 99aa1bc6b095f1954a0f4088fdd0c674e4d1d580


Static GH site looks bad

Windows 10 Google chrome 87:
Example https://milo123459.github.io/upptime

Please see https://upptime.js.org/docs/faq. You haven't added the base URL to your configuration.

Please see https://upptime.js.org/docs/faq. You haven't added the base URL to your configuration.

@AnandChowdhary I did that and it still doesnt't appear to work. I re ran the setup CI as well. any ideas now?

@AnandChowdhary I did that and it still doesnt't appear to work. I re ran the setup CI as well. any ideas now?

It looks good to me! :)

It looks good to me! :)

Yup, now it's fine, I have another question, how often does the GH workflow run fo rechecking uptime? It certainly isn't running every 5 minutes..
@AnandChowdhary

Yup, now it's fine, I have another question, how often does the GH workflow run fo rechecking uptime? It certainly isn't running every 5 minutes..
@AnandChowdhary


Docker-compose fails on building conductor-server

Hi there!
Yesterday I wanted to run Conductor using Docker-compose and noticed some bugs. One of them was reported yesterday.
But there's another bug related to the server Dockerfile.
Specifically, on line 28 of the file conductor/docker/server/Dockerfile:
COPY --from=builder /conductor/server/build/libs/conductor-server-*-all.jar /app/libs
That line fails due to the fact that it's a directory, not a file (there's a missing slash). So it should be:
COPY --from=builder /conductor/server/build/libs/conductor-server-*-all.jar /app/libs/
That's all. Thank you.
Regards!

Currently Docker is giving me another error, I'll check if it still happening and if it is, I'll reopen this issue.


Object reference not set to instance of a object error

Hello,
we have multiple projects that are very similar but it seems on some of the projects when trying to run coverlet i get this error in the title. Object reference not set to instance of a object error. The error comes from "\coverlet.msbuild.target(7, 5): warning : [coverlet] unable to instrument module: non test project name because: Object reference not set to instance of a object error"
dotnet test --no-build --logger:trx --logger:xunit --results-directory *** /p:CollectionCoverage=true /p:CoverletOutput=*** /CoverletOutputFormat=cobertura /p:Exclude="[xunit.]"
All projects use this same line and we using latest version of
coverlet.collection
coverlet.msbuild
xunit test logger
But i get a reference error on some of the projects. was wondering if their is a reason behind it

Can you try with vstest integration and upgrade to last version 1.2.0 https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md

Hey Marco,
i did what guide said and tried both dotnet test / vstest . The error is not their anymore but the generated code coverage file is a empty xml ? we have loads of test in the file . so their should be code coverage. the test and normal project target netcore 3.1 only . dont know if that would help

Can you share you test project csproj and the command line you used?Is the project open source?

Can you also enable logging https://github.com/tonerdo/coverlet/blob/master/Documentation/Troubleshooting.md#msbuild-integration and share if possible, here or on a private github repository, because logging could expose sensitive data.

@ashleybeshir any news?

Close for stale conversation, feel free to reopen if needed.


Fix initial submitError state for FieldArrays

When adding a new field to a FieldArray (which already has a field with a submitError), the submitError for the new field is initialised with empty.
This breaks form validation, as the new field has not been submitted yet and therefore should not have an initial submitError.
Therefore changing the initial value for submitError and asyncError of new fields to undefined.
Issue: https://github.com/erikras/redux-form/issues/2667

Codecov Report

Merging #2668 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2668   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1374    1374
======================================
  Hits         1374    1374

Impacted Files
Coverage Δ

src/reducer.js
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85dc885...34104df. Read the comment docs.

Hey @erikras, can you take a look at this one? It's currently causing quite some issues for me, would be great to get this fixed

Looks great.


[WIP] #577 [Angular]: user service

Story / Bug id: https://github.com/CodeForPoznan/volontulo/issues/577
Reference person: @magul
Description:
WIP service just for @magul

I'm merging it with whatever issues it has and will create separate pull request to resolve them.


Fix pluto crash when remote endpoint is unstable

Currently, submariner-gateway pod while invoking the whack commands does not set any dpdaction flags. So the default dpdaction of disabled was applied. While using this action, when the remote endpoint is not responding within a certain duration, some problematic code path in Libreswan was getting executed and leading to crash. The proper fix would be to use an updated Libreswan, but as a workaround we can explicitly set the dpdaction=hold to avoid hitting the problematic code paths.
Related PR in libreswan:
https://github.com/libreswan/libreswan/commit/c7a6113a85d27fcf8018b05f62905548e37f33f0
Fixes: https://github.com/submariner-io/submariner/issues/2516
Co-authored-by: Yossi Boaron<EMAIL_ADDRESS>

Looking into the linter errors


Missing creation of file 'top_5k_keywords.txt' and missing 'dice_stop_words.txt'

Hello @simonhughes22 ,
I started using the third ipynb (Conceptual Search - 3. Create Word2Vec Model.ipynb) and realized that the file 'top_5k_keywords.txt' wasn't created on previous steps. Could you please provide a code for it or even an example of how is the 'top_5k_keywords.txt' structure?
Also, the stop_words file is missing. I think that it's a small file and can be easily provided.
BR,
Denis.

@denisb411 I added some example files to the "./sample input files" folder and some more comments to notebook 3. These are small samples of our data, I cannot provide the full files unfortunately as that is our data. However, I would use the python scripts where possible instead, those are more clearly commented and share common config files, so you don't have to hunt down filepaths in notebooks to fix them all in multiple locations. The top_5k_keywords.txt is just a lucene format synonym file that I used to extract our top 5k search terms from the job descriptions. I have included python code that emulates the solr and ES synonym processing chains. This can also be used to filter the documents only to the recognized keywords, depending on how you want to approach this.


Remove address_3, address_4 and lead from company/contact

As agreed, this removes the following fields.
From Company:

lead
registered_address_3
registered_address_4
trading_address_3
trading_address_4

From Contact:

address_3
address_4

Codecov Report

Merging #249 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #249      +/-   ##
===========================================
- Coverage    92.69%   92.67%   -0.03%
===========================================
  Files           56       56
  Lines         1957     1951       -6
  Branches       185      185
===========================================
- Hits          1814     1808       -6
  Misses         120      120
  Partials        23       23

Impacted Files
Coverage Δ

datahub/company/serializers.py
97.61% <ø> (-0.16%)
:arrow_down:

datahub/korben/spec.py
83.33% <ø> (ø)
:arrow_up:

datahub/korben/etl.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a822aa...9bb70cf. Read the comment docs.


Document python dependency name

We should add some documentation to the python-runtime-cnb that states what dependencies are provided and how to require them.

@kvedurmu closing this as I think #8 has resolved it.


Remove pyc files

It looks like a couple pyc files were accidentally added to the repository. This PR removes them.

@danielnaab good catch!


Zebrunner is not started correctly after Upgrade 1.4 ->1.5

Steps:
git clone --recurse-submodule --branch 1.4 https://github.com/zebrunner/zebrunner.git
./zebrunner.sh setup (minio setaup)
Create organization, repo, run Web-demo and API-demo jobs
git checkout develop
git pull --recurse-submodules
./zebrunner.sh upgrade
Actual result: during setup I saw message in log
" Do you want to do an upgrade? y/n [n]:y
No need to perform upgrade to 1.1
No need to perform upgrade to 1.2
No need to perform upgrade to 1.3
No need to perform upgrade to 1.4
Upgrading Zebrunner from 1.4 to 1.5
reporting-service
SET
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
UPDATE 1
patch/1.5.sh: line 97: syntax error near unexpected token fi' patch/1.5.sh: line 97: fi'
No need to restart service as nothing was upgraded.
"

added mcloud related upgrade steps so issue should be fixed

Fixed.


All icons shaded in

Addon Version
v0.1.80-12-ga2ba437
World of Warcraft Version
Retail
Describe the bug
Both v0.1.80-11-gb1b0659 & v0.1.80-12-ga2ba437 (30/07/2024 updates) add a darkened shade over the bag icons.
It happens the moment you do anything with items in the bag. So, on first load or reload the bag icons look normal, but if you equip an item, swap gems, sort bags, do literally anything that uses an item in the bag every item becomes shaded.
I'm playing remix. I disabled every addon and had no bag issues using default ui. Turned on betterbags (no plugins) and immediately after right clicking to sort bags the icons went dark.
The issue goes away after reverting to v<IP_ADDRESS>-g30243f1.

Steps to reproduce

open bag
right click to sort bags or
remove gem or
add gem or
sneeze in the bags direction...

sorry, i should have used the newest version in the version section. It is the newest version and the one before it. I had to revert 3 versions back.

Thanks for the report, I'll fix this today.

This should be fixed in the latest alpha -- I can't test because everything is down, but on cata it did fix it.

This was fixed and released with v0.1.81.


Use Case For Why User Location  Look-back window is vital.

@jlurien it was for a use case of the "device location api" which was not "precision marketing"  or "Fraud".  The above is a copy of the MEFFY application which was submitted.

Ok, but to make issues more actionable, please let's try to use of the agreed template for enhancements:
Problem description

Possible evolution

Alternative solution

Additional context


Secondary research on authentication functionality at STLTs

User Story
As a ReportStream teammate, I want to learn from fellow teammates about the authentication functionality at STLTs they worked at, so we can have a better understanding of the overall landscape of user authentication in the ReportStream environment.
Background and context
As part of the design brief to add additional third-party authentication providers and abstract our authentication layers, we will need to consider identity proofing as a separate functionality from Okta authentication. As more and more Senders are added to the Universal Pipeline in the near and far future, we will need to prove that these organizations 'are who they say they are', and are not bad actors that could send faulty or fraudulent data into ReportStream.
Open questions

Did the STLT use any 2FA authentication? Or any 3rd-party authentication functionality?
How did the STLT interact with Senders?
Did this STLT undertake any identity proofing of users?
What level of authentication/verification was the STLT seeking from Senders?

Working links

Part of Authentication enhancements design brief
Discussion guide TBD

Acceptance criteria

[x] Catalogue what, if any, authentication capability(s) a STLT used
[x] Understand how a STLT interacts with its Senders
[x] Understand STLT level of expected authentication/verification

Not in scope

[] Talking directly to STLT / STLT clients
[] Deciding what authentication capability(s) ReportStream should have

Began to put outreach posts in Slack with various folks to learn about their background with the STLTs they worked with.

Discussions have been completed; met with Chris K to go over the synthesis of this effort and it appears to be finalized! Link here: https://app.mural.co/t/primedatainput6410/m/primedatainput6410/1685656723223/62d953ac53acd55780b2c58ed2b3b82385f3ba21?sender=ufb3824a0e63fafb0304f5774


[PROPOSAL] Combine gems, extract opensearch-aws-sigv4

What/Why
What are you proposing?
There are 5 gems in this repo:

opensearch-api
opensearch-dsl
opensearch-ruby
opensearch-aws-sigv4
opensearch-transport

All except opensearch-aws-sigv4 are always used by anyone wanting to call OpenSearch in Ruby.

Propose to merge them into opensearch-ruby.
Propose to extract opensearch-aws-sigv4 into a separate repo.

What users have asked for this feature?
Coming from #127.
What problems are you trying to solve?

I don't believe anyone ever uses opensearch-api, opensearch-dsl, opensearch-transport separately from opensearch-ruby. Seems like unnecessary overhead.
We have tags such as opensearch-api/2.1.2 and the number of tags will grow fast. Each tag only refers to a subset of the code, and may incorrectly imply some relationship between, say opensearch-ruby and opensearch-api in the tag. Theoretically they could even be incompatible.
Our 1.x, 2.x branching strategy forces to release all the gems at the same time or create more confusion.

What is the developer experience going to be?
Major increment opensearch-ruby and collapse the other 3 gems into it.
Extract code for opensearch-aws-sigv4 into a new repo called opensearch-ruby-aws-sigv4.

Should we keep opensearch-dsl separated in its own repo too? It's a supplemental gem to build queries. It's not always required, esp when the user want to build a micro-service to monitor a cluster for example.

Do we know if anyone is using opensearch-dsl separately?

One of the applications I worked in the past didn't use dsl (I built an ORM framework specialized for domain instead).
And yes it's to save space for micro-services that don't use dsl.

I don't have any strong opinions if you think it's useful!

@dblock Would you mind creating opensearch-ruby-dsl and opensearch-ruby-aws-sigv4 repos?

@dblock discussed with @vamshin regarding dsl-py where we've merged it into the Python client instead of maintaining it as a standalone package like we planned to above. @vamshin brought up a valid point that addresses my micro-service concern: The footprint of the DSL library is minuscule. So, to reduce the overhead of maintaining another repo and keep it consistent with other clients, let's merge the DSL gem into the Ruby Client gem as well.

Hi there, just a quick question: am I correct to assume that the merge hasn't been completed yet?

@RuslanHassonov sorry I missed this. It's a WIP and almost done #175


value ranges for 'max_random_illumination', 'max_aspect_ratio', etc

ImageRecordIter has a lot of parameters for augmentation. I'm not quite sure what is the reasonable value ranges for some parameters. E.g. max_random_illumination should range from [0,255] or [0,1]? How about max_random_scale, max_aspect_ratio and max_shear_ratio?

Bumping this ;-)
Any color on this would be very useful. Thanks!


Log4j2 vulnerability (CVE-2021-44228)  - mcr.microsoft.com/java/jre-headless:11-zulu-alpine

Can you please confirm if the image mcr.microsoft.com/java/jre-headless:11-zulu-alpine  affected by the Log4j2 vulnerability (CVE-2021-44228)  ?

Microsoft official response to the issue: https://msrc-blog.microsoft.com/2021/12/11/microsofts-response-to-cve-2021-44228-apache-log4j2/

Azul support answer about this question:
=========
This CVE does not affect the JDK directly, and while there have been related vulnerabilities which have affected JDK versions in 2009, 2017, and 2018, versions since then have been secure against those.
However, the new CVE is reported against Apache Log4J, which is a logging framework used almost everywhere in Web Application frameworks. You will need to take steps to find and secure any environment which uses it.
The long-term strategy will be to upgrade to Log4J 2.15 everywhere, which was released on Friday December 10, 2021.  It's possible that deploying this update may cause issues with your web services, so it would be wise to take the time to run through an Integration Test cycle first.
In the short term, there are several mitigation strategies, presented at the following sites:
•	https://access.redhat.com/security/cve/cve-2021-44228
•	https://www.lunasec.io/docs/blog/log4j-zero-day/
•	https://github.com/advisories/GHSA-jfh8-c2jp-5v3q
We recommend that you review these and choose the approach that works best for you and your team and the way you work with the application servers.
Here are some details to help you with queries you may have to field internally.
•	Some versions of Log4J can use LDAP and JNDI to lookup and acquire resources over the network, and under certain conditions it allows arbitrary, untrusted code from an LDAP server controlled by a malign actor to execute.
•	Apache Log4J is not part of Zulu, but is likely present in your environments as part of any number of application frameworks, including Apache Tomcat or Eclipse Jetty.
•	Similar Remote Code Execution (RCE) vulnerabilities have been reported against versions of Java between 2009 and 2018. Each used a similar mechanism, loading code over JNDI, but each had a separate execution path. Fixes were released to block the particular execution path each time.
•	The present CVE uses the same mechanism, but the execution path which allows the vulnerability to be exploited lies within the vulnerable versions of Log4J rather than the JDK.
The most common work-arounds are:

Set the system property log4j2.formatMsgNoLookups to true, or
Remove the JndiLookup class from the classpath. For example:
zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.cl
================


docs: fix minor typo

I don't think it's a typo (both variants are acceptable, you could pronounce it as "el-i"). But this does seem more common!


Add MAINTAINERS.md file and nominate James Taylor as a maintainer

Signed-off-by: heatherlp<EMAIL_ADDRESS>

I'm sure @jt-nti would disagree ;)

Even the build knows this is a bad idea!


Review Process

Abstract Pre-review
Each abstract submitted should be checked as soon as possible for three things:

Whether the submission and abstract template instructions followed. Examples include: more that two pages, edited parts fo the template that shouldn't have been edited, not following APA citation style, did not upload an ODT, DOCX, or zip with latex files.
Whether the correct metadata was supplied to the Orvium form.
Whether the submission is spam or inappropriate.
Whether the HTML and PDF versions of the abstracts are properly generated.

If there are issues in 1 or 2, the editorial assistants should contact the submitting author using the Orvium response template and let them know what they need to correct. For abstracts submitted in the last few days of February, we can give them until March 3rd to correct their submissions, otherwise they should correct it by the February 28th due date.
For spam or inappropriate content, we should reject it outright and the editorial assistants should inform the author with the Orvium response template.
For issues in 4, the editorial assistants should let the Orvium developers know about the issues at<EMAIL_ADDRESS>Content should not be checked at this stage, but if the editorial assistants notice some formatting errors or such in the content they can mention this to the authors as a courtesy.
Once the author(s) have corrected items 1 and 2 (and ideally 4 is fixed), we can make the abstract public and mark it as preprint version 1.
Abstract reviews
We assign two reviewers from the scientific committee to each abstract. Each reviewer will have multiple reviews to do (up to 5). We will assign that reviewer to the abstract in Orvium. The reviewers will rate and comment on each abstract:

Give a numerical rating (1-5) and a single sentence comment for these three qualities:

Fits the topic and theme of the conference
Scientific soundness
Communication of the content

Recommend: Accept (oral), accept (poster), or reject

If a reject, provide the reason.
If accepted (optionally) feedback on what to fix/adjust in the abstract to make it ready for publishing

Reviewers should not include their name or identifiable information in the submitted review text.
Editorial assistants review the reviews and make sure there are no inappropriate comments from the reviewers. They should check with the editors if they find anything questionable.

The organizing committee decides on the number of oral presentation and number of poster presentations we can have.
The organizing committee and editorial assistants tally the ratings and comments.
We develop a ranking algorithm for the numerical ratings.
We rank the submissions and decide on acceptances and rejections based on rankings and comments.

We release the acceptance/rejection results via Orvium to the authors and publish the reviews alongside the abstracts.
Abstract final versions
Accepted authors may submit updated abstracts with minor adjustments for the published version. Editorial assistants review the abstracts to make sure there are no drastic changes that would alter the review decisions. Then we publish the final abstract versions.
Paper pre-review
Similar to the abstracts, editorial assistants review for steps 1-4 above. If good, we published the preprint to Orvium for conference attendees (and the public) to see.
Paper reviews
TBD

Looks good to me! You have a couple of typos here and there:

Examples include: more that two pages,

Editorial assistants review the reviews and make sure there are no inappropriate comments from the reviewers.

What is the error in:

Editorial assistants review the reviews and make sure there are no inappropriate comments from the reviewers.

I'm not seeing it :(

Me neither. Can't remember what bothered me yesterday ...

Ok, I've sent it to the library and orvium people for comment. Will present on the 10th to the organizing committee.

Here is my current revision after taking feedback from Orvium, Library, and Organizing Committee:
Abstract Pre-review
Each abstract submitted should be checked as soon as possible for three things:

Whether the submission is spam or inappropriate.
Whether the submission and abstract template instructions were followed.
Examples include: more that two pages, edited parts fo the template that
shouldn't have been edited, not following APA citation style, did not upload
an ODT, DOCX, or zip with latex files.
Whether the correct metadata was supplied to the Orvium form.
Whether the HTML and PDF versions of the abstracts are properly generated.

The editorial assistants should assign themselves as an editor to the
submission, so we all know who is handling the pre-review.
For spam or inappropriate content (1.), we should reject it outright and the
editorial assistants should inform the author by pressing "Reject" button in
Orvium. Use template text for this response and state the reason clearly. If
you'd like someone on the organizing committee to handle this, let them know.
If there are issues in (2.) or (3.), the editorial assistants should contact
the submitting author using the Orvium "Request Changes" button and use the
template text for this step to let them know what they need to correct.
For abstracts submitted in the last few days of February, we can give them
until March 3rd to correct their submissions, otherwise they should correct it
by the orginal February 28th due date.
For issues in 4, the editorial assistants should let the Orvium developers know
about the issues at<EMAIL_ADDRESS>Article content should not be checked at this stage, but if the editorial
assistants notice some formatting errors or such in the content they can
mention this to the authors as a courtesy.
Authors should then edit their submission by pressing "Edit" and submitting a
new document and/or correcting the metadata.
TODO : Ask Orvium why the article does not display as Version 2 if the author
edits the submission.
Once the author(s) have corrected items 2 and 3 (and ideally 4 is fixed), the
"Assign Editor" should be set to "Jason Moore" to signal that this is ready to
have reviewers assigned.
Do not "Accept" the abstracts at this point, as it will make the abstract
public. We will make the accepted abstracts and their reviews public after
we've made the final selection of presentation, poster, or rejection.
Abstract reviews
We will assign two reviewers from the scientific committee to each abstract by
pressing "Invite Reviewers" on the abstract submission in Orvium. Each reviewer
will review up to 5 abstracts.
The reviewer must have an account on Orvium to be invited. If they are invited
they will receive an email inviting them. The click on the email link which
brings them to the abstract in Orvium. Then they select "My Reviews" on the
left and there is a blue "Accept the Invitation" button. Once they accept they
can submit a review.
The reviewers will rate and comment on each abstract:

Provide a comment for these three qualities:

Fits the topic and theme of the conference
Scientific and technical soundness
Communication of the content

Recommend: Accept (oral), accept (poster), or reject

If a reject, provide the reason.
If accepted (optionally) feedback on what to fix/adjust in the abstract to
make it ready for publishing in the book of abstracts (should be minor
revisions)

In Orvium reviewers have to do three things:

Fill out the "general comments" box
Upload a document which contains the review
Select: "Accept", "Minor Revision", or "Major Revision"

TODO : The "general comments" box and uploading a document is redundant and
it would be nice if the editors did not have to open a document with the review
and could simply see it in the interface.
We will have to tell the reviewers that the things in 3. mean:

Accept: Accept as is, no edits needed for the abstract to be published.
Minor Revision: Accept, but abstract needs edits to be published.
Major Revision: Reject

OR

Accept: Oral
Minor Revision: Poster
Major Revision: Reject

or the Orvium drop down is changed to say: oral, poster, reject
Reviewers should not include their name or identifiable information in the
submitted review text. We need to check each review to make sure identifiable
info is not present.
The reviewer selects "Submit" to deliver the review to the editor.
TODO : It seems pressing "Submit" allows the author to immediately see the
review. We'd like to moderate the reviews in case someone says inappropriate
comments.
Editorial assistants review the reviews and make sure there are no
inappropriate comments from the reviewers. They should check with the editors
if they find anything questionable.

The organizing committee decides on the number of oral presentation and
number of poster presentations we can have.
The organizing committee and editorial assistants tally the ratings and
comments.
We develop a ranking algorithm for the numerical ratings.
We rank the submissions and decide on acceptances and rejections based on
rankings and comments.
We select "Poster", "Presentation", or "None" in the "Decision" drop down
beside each abstract in the moderator panel.
We press "Accept" for all accepted reviews and "Reject" for all rejected
reviews in teh moderator panel.

TODO : Selecting the "Decision" drop down does not seem to signal to the
author whether their paper has been accepted or rejected.
Reviewer Instructions

Create an account on Orvium
Check your email for review invitations.
Log into Orvium
Accept the review invitations under "My Reviews" on the left side of the
Orvium website after logging in.
Type your recommendation: Accept Oral, Accept Poster, Reject into the
"General Comments" field.
Upload a file with your review text.
Select "Accept", "Minor Revision=Edit Abstract", or "Major Revision=Reject"
Submit the review.
Repeat for each of your reviews.

The text of your should briefly comment on these three qualities:

Whether the submission fits the topic and theme of the conference
Whether the work is scientifically and technically sound
Whether the content is communicated well

You should make one of three recommendations:

Accept for an oral presentation
Accept for a poster presentation
Reject

If you recommend to reject, provide a reason for your recommendation.
If you recommend to accept, optionally provide feedback feedback on what to
fix/adjust in the abstract to make it ready for publishing in the book of
abstracts. These should be minor revision requests and are only intended to
improve the abstract communication for the published book of abstracts.
Abstract final versions
Accepted authors may submit updated abstracts with minor adjustments for the
published version. Editorial assistants review the abstracts to make sure there
are no drastic changes that would alter the review decisions. Then we publish
the final abstract versions.
Paper pre-review
Similar to the abstracts, editorial assistants review for steps 1-4 above. If
good, we published the preprint to Orvium for conference attendees (and the
public) to see.
Paper reviews
TBD


Download Zenus data for other than Bundesland

Hi,
I was wondering if I can download data for a different regional scope than the default "Bundesland" resolution. On the web, I can choose to download data for 1000A-1004 for "Gemeinden". Is that possible?
Another thing: When displaying the table in the current form, there is no distinction between the full number and the percentage. I guess the rawdata is not parsed correctly. Or am I missing something?

Hi @chesselingfm,
I will come back to you a little later but the problem with multiple values in the same column is already fixed in dev, we are actively working at parsing the new data format only available in Zensus. My latest PR should fix the issue (without addressing the language selection, yet, so only for de). Zensus changed to a new format where multiple values are all gathered in a single value column which means that one observation has X rows, one for each value (long format instead of wide). We decided to transform the data so that the user gets back a wide format as it should be, meaning that a single row stands for all observations for that particular identity (unique set of statistic, time, zone and available attributes).
To your first question: I am sure that is possible and we should already support this because you can pass any keyword argument to the get_data method that is supported by the API but I also saw this possibility in the Web UI so I will dig a little deeper and add it in an appropriate way!

Here is your example table with the current dev version:
'|    | Stichtag   | Bundesländer       | Alter (5er-Jahresgruppen)   | Personen__%   |   Personen__Anzahl |\n|---:|:-----------|:-------------------|:----------------------------|:--------------|-------------------:|\n|  0 | 2011-05-09 | Schleswig-Holstein | Insgesamt                   | 100,0         |            2800119 |\n|  1 | 2011-05-09 | Schleswig-Holstein | Unter 5 Jahre               | 4,0           |             112644 |\n|  2 | 2011-05-09 | Schleswig-Holstein | 5 bis 9 Jahre               | 4,5           |             126157 |\n|  3 | 2011-05-09 | Schleswig-Holstein | 10 bis 14 Jahre             | 5,3           |             149131 |\n|  4 | 2011-05-09 | Schleswig-Holstein | 15 bis 19 Jahre             | 5,4           |             151155 |'
As you can see, the previous value column actually combined two observations: "Personen" as count and as percentage. The general way we are handling this in a standardized way for all supported databases is this:

we always use the attribute label as column name, "Personen" in this case
we add the unit for this column with a double underscore, so "Anzahl" and "%" in this case

This should give you all the information you need as user to work with this column and understand its content

@chesselingfm I just realized we already support your request in the current dev branch with the keyword parameters regionalvariable and regionalkey for Table.get_data(). So for any Regionalstatistik table ending with a "B" in its number/name, you can use regionalvariable to specify the regional depth. Regionalstatistik supports the follow codes:

"DG" (Deutschland, 1)
"DLAND" (Bundesländer, 16)
"REGBEZ" (Regierungsbezirke, 44)
"KREISE" (Kreise und kreisfreie Städte, 489)
"GEMEIN" (Gemeinden, 13564)

However, not every table supports every code/regional depth.
With our next release 0.3.0 this will be part of the master branch and the version that you can install with pip. The release will happen somewhere in the next week.

Implemented and documented, see latest release 0.3.0 and the changelog as well as the improved documentation


Data Structure

How should the data be structured?

Data can be:

CSV
Geopackage

Structure:
attribute 1 | attribute 2 | attribute N | time | geometry

For columns, I probably want something like:

ID
Person
City
State
Country
Start_Date
Geometry


LEGACY (from old validation library) - Add support for custom rules that have parameters

Currently, custom rules can only be simple callbacks that don't take in any additional parameters
There are cases when parameters are necessary

Closing this since Valitron has been replaced with Respect\Validation


Update ProtonVPN instructions to include recent addition of Wireguard

Update ProtonVPN instructions to include recent addition of Wireguard support in https://github.com/qdm12/gluetun/pull/2390
References to the custom provider have been removed as it is not necesary anymore.
This PR is mostly based on the comment of @TheRealBix (https://github.com/qdm12/gluetun/pull/2390#issuecomment-2266670716) in the upstream PR.
I tested those instructions in my environment and can confirm they are complete.

@qdm12 I integrated your remarks and fixed the linting errors.
Note I didn't test this provider with OpenVPN so I trust your review blindly ;)


added new iphone model simulators to readme

Added new iPhone XR, XS and XS Max simulator aliases to the README documentation
--Sorry, should have made it all one PR

Thanks!


Typo in Wiki (Azure Web App sandbox)

In https://github.com/projectkudu/kudu/wiki/Azure-Web-App-sandbox
"Every Azure Web App has a local directory which is temporary and is deleted when the run is no longer running on the VM."
should be
"Every Azure Web App has a local directory which is temporary and is deleted when the app is no longer running on the VM."

Fixed, thanks!


fix(schemas/yazi.json,theme.json,keymap.json): replaced [select] with [pick] for<EMAIL_ADDRESS>

Resolved breaking changes when migrating to<EMAIL_ADDRESS>mentioned on
Issue#1772 section 1.2.

See https://github.com/yazi-rs/schemas/blob/main/CONTRIBUTING.md#updating-for-a-new-yazi-release.

See https://github.com/yazi-rs/schemas/blob/main/CONTRIBUTING.md#updating-for-a-new-yazi-release.

Thank you, ill check it out. Apologize as I am new to the whole open source thing. Sorry again for any inconvenience earlier or in the future.


Update copilot to 1.95.239 for updated API proposals metadata

This PR closes #23663
Update Copilot version in the insiders extension gallery to 1.95.239 to align with Copilot proposed API changes.
Link to files to upload: https://microsoft-my.sharepoint.com/:f:/p/lewissanchez/IgA67soStD2xT7Q15op97pP4AdJfPwISUMmDSvmErITyx2o?e=j0IK6t

@lewis-sanchez please add all the files in your onedrive folder? only vsix is there right now.


Support for LoongArch64

LoongArch is a risc architecture. In this pr, I want to add support for LoongArch.

Hi all:
libffi already supports LoongArch, see:https://github.com/libffi/libffi/pull/678.
We have Loongarch machines in the GCC compile farm, see: https://cfarm.tetaneutral.net/machines/list/. I think you can build the Loongarch port code with it.
Thanks

@theaoqi

Does this patch make a jffi library that works for you? The changes are quite simple, so if this is all that is needed that would be great!

Does this patch make a jffi library that works for you? The changes are quite simple, so if this is all that is needed that would be great!

Sorry for not replying in time.
The patch worked for the LoongArch platform. After that I will try my best to adapt jruby.
Thanks

There are two other places we will want to add LoongArch support other than JRuby:

https://github.com/jnr/jnr-ffi

jnr-ffi contains type mappings for supported platforms, so we know how wide these values are. LoongArch may be mostly a copy of MIPS for these types, but we should review it and make sure jnr-ffi knows about LoongArch.
https://github.com/jnr/jnr-constants
jnr-constants contains POSIX C constants like socket flags. These don't usually differ by hardware platform, but we should review them to make sure the Linux constants are not different on a LoongArch Linux instance.
Thank you for your help!

I have requested access to the GCC compile farm so we can build a binary for LoongArch.

Thank you for reminding. I have a pr in jnr-ffi: https://github.com/jnr/jnr-ffi/pull/308.
Please check the code for me when you have time.
I'll do the rest as you suggest, for example: jnr-constants.
Thank you for your help!

There are two other places we will want to add LoongArch support other than JRuby:

https://github.com/jnr/jnr-ffi

jnr-ffi contains type mappings for supported platforms, so we know how wide these values are. LoongArch may be mostly a copy of MIPS for these types, but we should review it and make sure jnr-ffi knows about LoongArch.
https://github.com/jnr/jnr-constants
jnr-constants contains POSIX C constants like socket flags. These don't usually differ by hardware platform, but we should review them to make sure the Linux constants are not different on a LoongArch Linux instance.
Thank you for your help!

Hi:
jnr-constant already supports LoongArch: https://github.com/jnr/jnr-constants/pull/98.
So now I just need to adapt jnr-ffi.
Thanks


"container_inclusive" is disregarded on the selective refresh class

Hi Ari,
The "container_inclusive" argument is very important when you add a partial refresh. What you did in: https://github.com/aristath/kirki/blob/72ea3dc343706f02fc49702a9e90956c23c6c259/includes/class-kirki-selective-refresh.php#L49 makes it impossible to pass the "container_inclusive" argument to the native WordPress Selective Refresh API.
Can you take a look at it?

You're absolutely right...
Marking as a bug, I'll take a look.

I think this last commit in the develop branch fixes the issue but didn't have any time to test, can you please verify that it works for you?

Hi Ari, just tested and it works perfectly. Thanks!

👍 awesome, thanks for checking!
Will be included in the next release.


Split Resource Ingress and Resource Egress in separate resources

Problem
Today our contract is organized as follows:

This contract modelling has certain shortcomings, most notably it doesn't map to the way the implementation is organized: receiver cares only about ingress contracts, dispatcher cares only about egress contracts.
I propose to reorganize the contract as follows:

In other words, I propose to split completely Ingress and Egress and get rid of the Resource entity, duplicating eventual fields required in both Ingress and Egress.
Persona:
Which persona is this feature for? Developer
Exit Criteria
Contract is organized as explained above
Additional context (optional)
This is going to simplify the implementation of #312 and #313. This will also allow us to have potentially different config maps, one for the "ingress contracts" and one for the "egress contracts", mitigating #337. Splitting in different CMs can be tackled in another issue.

cc @pierDipi I know this is something we discussed about a while ago, wdyt about it?

We chatted about this a while ago.
What I think is that we should optimize to save space more than everything else.
The current contract is optimized for saving space.
Why do you think that this will simplify #312 and #313?
We should already have everything in place to implement them pretty easily.

This contract modeling has certain shortcomings, most notably it doesn't map to the way the implementation is organized: receiver cares only about ingress contracts, dispatcher cares only about egress contracts.

We can do that even with the current contract too and mitigate #337, as follow:

broker reconciler can use a CM (A) and fill only resource and ingress,
the trigger reconciler can use another CM (B) and fill only resource and egress.

I think I don't understand your reasons fully.

We can do that even with the current contract too and mitigate #337, as follow:
broker reconciler can use a CM (A) and fill only resource and ingress,
the trigger reconciler can use another CM (B) and fill only resource and egress.

That's what I want to do, but TBH I don't like the idea of reusing the same Resource type. What about:

Because Resource <-> Ingress is a 1:1 association, Ingress just get the fields it needs from Resource
Resource <-> Egress is 1:many association, so we could have something like Egresses (name to be bikeshed) where the Resource fields goes

My more "long term" vision about the contract is to have a way we will be able to send to the data plane (no matter what's the communication mean) single ingress and egresses. That's something we don't need to do now, until we know what this communication mean is, but maybe this issue is a good step forward in that direction.

Ok, let's then build a plan on how to upgrade safely after this change.

@pierDipi Agreed, I think we should have some fancy upgrader job that clean up the bad CMs and creates the new one, then touches all the broker and trigger resources so these get reconciled.
Actually, if in the context of this issue we also split in 2 config maps, we won't even need to remove the old CM, we can just ask the user to do so, we only need to touch all the resources to re-reconcile them.
I'm also thinking that we should get the upgrade tests in at some point before moving forward with this one...

Actually, if in the context of this issue we also split in 2 config maps, we won't even need to remove the old CM, we can just ask the user to do so, we only need to touch all the resources to re-reconcile them.

No need to touch all resources, once a controller starts it queues and reconciles all resources.


More flexible file locations

This fixes #23 and #13
Removes the fields testName and directory and replaces them with goldenFile and actualFile. This allows a lot more flexibility:

Custom file names and/or custom file extensions
Custom directory locations
Option to not save "actual" files

This pull request has 2 commits. The first commit maintains the testName field, but I think things are cleaner and simpler without it (2nd commit).
The hgold program isn't aware of the changes made, but will still continue to work if you use defaultGolden (the default directory and file names).

@bitc
Hi! Thanks for this PR.
Option to not save "actual" files This is the feature I am waiting for :)
@CristhianMotoche
Can I do something to help you, merging this two commits?

Hi @christianheyn The PR is good. I think I forgot to merge it. Thanks @bitc for the contribution. :tada:


Updates and Documentation for WandB sweeps

Based on other work were doing, we should add some documentation and make necessary tweaks for running a W&B sweep with this codebase.

Add documentation and examples of running WandB sweeps with Yoyodyne.
Make updates to codebase so PTL and WandB play nice wrt logging hyperparameters, etc.
Update PTL to log max validation accuracy.

Let me also add that the documentat should probably show how to retrieve best runs from the wandb API too.

I guess relatedly it would also be nice to have a system for easily pointing W&B run id's to yoyodyne logging, etc.

Working on this now. Was wondering if you think we should add train args so that it can be called in such a way that a wandb agent trains from a sweep (by adding a wandb_sweep_id and max_num_runs arg), or if this should be a seperate scripts that we maintain in the library (something like train_wandb_agent.py).
Other notes:

I was not able to find anything on how to log the max validation accuracy in PTL, and let it propogate that logging to wandb, so instead I just do wandb.define_metric('val_accuracy', summary='max') when wandb logging is enabled.
PTL tries to log the model hparams to the wandb when the WandbLogger is enabled, causing a warning, because they also get logged when we start the sweep agent. See here: https://github.com/wandb/wandb/issues/2641. I do not know how to fix this, since it does not seem to be PTL behavior I can toggle, and we need the PTL WandbLogger in order to also log runtime metrics. I think we can just let it happen it for now?

Working on this now. Was wondering if you think we should add train args so that it can be called in such a way that a wandb agent trains from a sweep (by adding a wandb_sweep_id and max_num_runs arg), or if this should be a seperate scripts that we maintain in the library (something like train_wandb_agent.py).

While I'm not sure I have enough context to get this yet, I think I am fine just including docs and a sample script for doing wandb stuff. It's hard for me to imagine doing this effectively using yoyodyne-train alone, I guess? I assume you did your sweeping using custom Python, right?

I was not able to find anything on how to log the max validation accuracy in PTL, and let it propogate that logging to wandb, so instead I just do wandb.define_metric('val_accuracy', summary='max') when wandb logging is enabled.

SGTM.

PTL tries to log the model hparams to the wandb run when the WandbLogger is enabled, causing a warning, because they also get logged when we start the sweep agent. See here: [CLI] wandb: WARNING Config item 'hyperparam_name' was locked by 'sweep' (ignored update) wandb/wandb#2641. I do not know how to fix this, since it does not seem to be PTL behavior I can toggle, and we need the PTL WandbLogger in order to also log runtime metrics. I think we can just let it happen it for now?

Let's just suppress the warning in __init__.py then, and add a TODO to investigate this at the PTL level later.

Working on this now. Was wondering if you think we should add train args so that it can be called in such a way that a wandb agent trains from a sweep (by adding a wandb_sweep_id and max_num_runs arg), or if this should be a separate script that we maintain in the library (something like train_wandb_agent.py).

While I'm not sure I have enough context to get this yet, I think I am fine just including docs and a sample script for doing wandb stuff. It's hard for me to imagine doing this effectively using yoyodyne-train alone, I guess? I assume you did your sweeping using custom Python, right?

Yeah I just have a train_wandb_agent.py script that calls the functions in train.py. So do we need a directory at the top-level of our repository called examples or similar? Or do you think its better to have train_wandb_agent.py live alongside train.py?

Let's just suppress the warning in __init__.py then, and add a TODO to investigate this at the PTL level later.

Sounds good!

Working on this now. Was wondering if you think we should add train args so that it can be called in such a way that a wandb agent trains from a sweep (by adding a wandb_sweep_id and max_num_runs arg), or if this should be a separate script that we maintain in the library (something like train_wandb_agent.py).

While I'm not sure I have enough context to get this yet, I think I am fine just including docs and a sample script for doing wandb stuff. It's hard for me to imagine doing this effectively using yoyodyne-train alone, I guess? I assume you did your sweeping using custom Python, right?

Yeah I just have a train_wandb_agent.py script that calls the functions in train.py. So do we need a directory at the top-level of our repository called examples or similar? Or do you think its better to have train_wandb_agent.py live alongside train.py?

Yes that's what I'd suggest. I'd have one for running the sweep and, optionally, one for grabbing the results from W&B.
I don't know if we need to modify the project file to register the existence of that directory, but prevent it from being installed as part of the package...something to look out for: browse the verbose installation info and you should see what happens there.

@kylebgorman Should we leave this open until we've played with the examples and are sure the scripts are sufficient, and documentation is good enough?

I was thinking I'd commit it and then just take it for a spin next...

Okay, sure. I'd like to take it for a spin first.

Sorry, I just meant this issue -- not the PR!

Sorry, I just meant this issue -- not the PR!

Got it, yea I was confused at first.


⚠ T:Riza Docs has degraded performance

In 514d396, T:Riza Docs (https://docs.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 4470 ms

Resolved: T:Riza Docs performance has improved in 14cfef5.


Splitter balloon split chances

The splitter balloon has to have certain chances of splitting depending on how many times the splitter balloon has been split. So, for example, if its the first time the splitter balloon was popped it splits 100% of the time. If its the second time it has been popped, it has a 20% chance of splitting. After a third time it has a 5% chance of splitting. And so on.

Spawn chance for this balloon should also be reduced.


ErrorException: Warning: Error while sending STMT_PREPARE packet

Laravel Version: Laravel Framework Lumen (5.8.8) (Laravel Components 5.8.*)
PHP Version: PHP 7.2.19-0ubuntu<IP_ADDRESS>
Database Driver & Version: mysql  Ver 14.14 Distrib 5.7.26

Description:
Queue jobs is losing connection to database and throw exception
ErrorException: Warning: Error while sending STMT_PREPARE packet
Queue command (managed by supervisord) artisan queue:work --queue=children --sleep=3 --tries=3 --daemon
The error is not related to large data sent to database, it seems to be it's related to some how data connection is lost with database
My error comes from a simple query
$child = Child::find($child_id);
Let me know if you need any further information
PS: No change in mysql nor php default settings.
Steps To Reproduce:
Sometime below steps will work
1- Make sure queue is running
2- Restart database (/etc/init.d/mysql restart)
3- Send a job to the queue
4- You will get this error
5- Send another job to the queue (no error)

Small clarification, my job will just call a model that will process the data
<?php
namespace App\Jobs;
use Illuminate\Support\Facades\DB;
use App\Models\Child;

class childjob extends Job {
    public $tries = 3;
    public $timeout = 1800;
    public $child_id;
    public function __construct($child_id)
    {
        $this->child_id = $child_id;
    }
    public function handle(){
        Child::setsomething($this->child_id);
        return true;
    }
}

and inside Child Model:
public static function setsomething($child_id){
    $child = Child::find($child_id);
}

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Also: please post this on the Lumen repo if you decide to repost. Thanks!
Thanks!

Many users are reporting similar experiences on Laracasts
https://laracasts.com/discuss/channels/laravel/error-while-sending-stmt-prepare-packet-on-queued-jobs

Also in stackoverflow
And most of the cases its laravel not lumen
On Sun, Jun 30, 2019 at 13:25 decowboy<EMAIL_ADDRESS>wrote:

Many users are reporting similar experiences on Laracasts
https://laracasts.com/discuss/channels/laravel/error-while-sending-stmt-prepare-packet-on-queued-jobs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/28920?email_source=notifications&email_token=AAHJ3YIHWUDFAD2EZM2PX7DP5CC3NA5CNFSM4H2XQDTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4JMVI#issuecomment-507024981,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHJ3YLOMPMBI2FGAWJDWS3P5CC3NANCNFSM4H2XQDTA
.

--
echo "Hello World :)"

Could this be because the database service is getting a new PID for whatever reason and that the old one is still loaded since horizon is a long running process?

Since i have updated my application i also get this error regularly.
Code has been changed by over 400 commits, find the culprit in this is not really easy.
Only big thing changed on the server is from mysql -> mariadb.

Our problem indeed also happens on MariaDB, not sure about mysql.

I'll re-open this to have a look at a later time. Feel free to provide more info on the matter in the meantime.

What is can see so far:
Happens on different random jobs.
Happens around 1 of 1000 jobs, could be complete random.
Examples:
ErrorException[internal] in unserialize
warningWarning: Error while sending STMT_PREPARE packet. PID=26143

variable_representation | O:28:"App\Jobs\FetchProofscopeData":8:{s:15:"*project_file";O:45:"Illuminate\Contracts\Database\ModelIdentifier":4:{s:5:"class";s:15:"App\ProjectFile";s:2:"id";i:154404;s:9:"relations";a:1:{i:0;s:7:"Project";}s:10:"connection";N;}s:6:"*job";N;s:10:"connection";N;s:5:"queue";s:13:"project-files";s:15:"chainConnection";N;s:10:"chainQueue";N;s:5:"delay";N;s:7:"chained";a:2:{i:0;s:367:"O:34:"App\Jobs\FetchProjectFileThumbnail":8:{s:15:"*project_file";O:45:"Illuminate\Contracts\Database\ModelIdentifier":4:{s:5:"class";s:15:"App\ProjectFile";s:2:"id";i:154404;s:9:"relations";a:1:{i:0;s:7:"Project";}s:10:"connection";N;}s:6:"*job";N;s:10:"connection";N;s:5:"queue";N;s:15:"chainConnection";N;s:10:"chainQueue";N;s:5:"delay";N;s:7:"chained";a:0:{}}";i:1;s:364:"O:31:"App\Jobs\ForceRenderProjectFile":8:{s:15:"*project_file";O:45:"Illuminate\Contracts\Database\ModelIdentifier":4:{s:5:"class";s:15:"App\ProjectFile";s:2:"id";i:154404;s:9:"relations";a:1:{i:0;s:7:"Project";}s:10:"connection";N;}s:6:"*job";N;s:10:
-- | --

ErrorException/app/Jobs/InsertSystemLog.php in App\Jobs\InsertSystemLog::handle
warningWarning: Error while sending STMT_PREPARE packet. PID=26147

/app/Jobs/InsertSystemLog.php in App\Jobs\InsertSystemLog::handle at line 100
        $log->save();
    }
}

FYI
Not sure if this is has anything to do with this error, but I'm using https://github.com/GeneaLabs/laravel-model-caching to cache my queries
let me know if you want me to upload any log to the issue

Since i have updated my application i also get this error regularly.
Code has been changed by over 400 commits, find the culprit in this is not really easy.
Only big thing changed on the server is from mysql -> mariadb.

Same here, I started to get this error after lumen upgrade

Some jobs will also be marked as failed, most of them go trough.

Getting the same issue. Never had this issue on Laravel 5.6 but after updating to 5.7 this now happens daily. It looks like jobs are not actually failing since I have no items in the failed_jobs table, yet Sentry reports 80 issues.
All these issues seem to be related:

PDO::prepare(): MySQL server has gone away
E_WARNING: Error while sending STMT_PREPARE packet. PID=10

some issues and I thought it has to do with Telescope or horizon, but apparently, it is more common than I thought.

Same issue from April 28: https://github.com/laravel/horizon/issues/583

Adding mine for context:
Laravel 5.8.28
mysql  Ver 15.1 Distrib 10.2.25-MariaDB and 10.1.36-MariaDB
Happens with and without telescope installed.
I'm seeing both the STMT_PREPARE and MySQL server has gone away errors.

Seems like this PR probably causes this but it's actually quite logic. If you're in a transaction and lose connection, there's no recovery from that.
Are all of you using transactions?

@driesvints In my case i just use Model::create()

I’m not using any transaction
I doubt this error related to losing connection, i have my code hosted with
my database and no errors in MySQL logs
This error is very random for me, in one day I get like 10 errors, next few
day no error at all
PS: my app is not production so it’s used only by me (server not overloaded)
On Fri, Jul 12, 2019 at 17:01 Dries Vints<EMAIL_ADDRESS>wrote:

Seems like this PR https://github.com/laravel/framework/pull/12929
probably causes this but it's actually quite logic. If you're in a
transaction and lose connection, there's no recovery from that.
Are all of you using transactions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/28920?email_source=notifications&email_token=AAHJ3YNVJRGYVQ4QOMXG3OLP7CFDNA5CNFSM4H2XQDTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZ2ZCQ#issuecomment-510897290,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHJ3YPGHQGOWTDRNBOO5QLP7CFDNANCNFSM4H2XQDTA
.

--
echo "Hello World :)"

@driesvints No transactions.
It seems it has to do with Horizon/Telescope.
Although Telescope is fully disabled.
Below you can find some of our Sentry logs:

@driesvints 3 separate listeners are failing in our application and none of them have database-transactions.

Im not using horizon nor telescope and face this issue
I’m passing Eloquent model to the queued job constructor, maybe this is the
issue
Any one doing the same thing ?
On Fri, Jul 12, 2019 at 17:38 jlmmns<EMAIL_ADDRESS>wrote:

@driesvints https://github.com/driesvints No transactions.
It seems it has to do with Horizon/Telescope.
Although Telescope is fully disabled.
Below you can find some of our Sentry logs:
[image: Screen Shot 2019-07-12 at 9 35 07 AM]
https://user-images.githubusercontent.com/3619890/61136110-9d1de380-a488-11e9-8be5-bbb4e502d071.png
[image: Screen Shot 2019-07-12 at 9 34 16 AM]
https://user-images.githubusercontent.com/3619890/61136129-a5761e80-a488-11e9-8c71-00d86a2c7beb.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/28920?email_source=notifications&email_token=AAHJ3YNWIWKDS74BKT4B64DP7CJODA5CNFSM4H2XQDTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZ6CXA#issuecomment-510910812,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHJ3YMC4TABMGIQY6PKDHDP7CJODANCNFSM4H2XQDTA
.

--
echo "Hello World :)"

I do not use telescope so i don't think the problem lies there, no transactions too

I too am facing this issue. I am not using horizon or telescope. I do not have any jobs that are shown as failed in my DB but I do get the notifications a few times a day. It fails randomly on any job. I have very little traffic on the server. I have trying to figure it out for the past few days now.
Laravel 5.8.28
MYSQL version: 5.7.26

It seems like everybody with this problem is using Sentry? Is this correct or are some people here using other services?

@Christophvh Sentry is just for receiving/displaying errors. The actual error has already before sent to Sentry.

I’m using Sentry but I configured it as a log channel
On Mon, Jul 15, 2019 at 13:40 Robert Fridzema<EMAIL_ADDRESS>wrote:

@Christophvh https://github.com/Christophvh Sentry is just for
receiving/displaying errors. The actual error has already before sent to
Sentry.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/28920?email_source=notifications&email_token=AAHJ3YLNJC6N2NM7UBVJMXDP7RHZZA5CNFSM4H2XQDTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ5J7GI#issuecomment-511352729,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHJ3YLRDZZHODFD67WBZMLP7RHZZANCNFSM4H2XQDTA
.

--
echo "Hello World :)"

I'm also having this issue with Telescope AND Voyager: It seems to happen with artisan commands, one of wich is very long (sitemap:generate from spatie's package on a 1500 pages website)
Screenshot 1

Screenshot 2

Hey everyone, It has been a few days since I added more workers to my system and there has been no errors reported!
My advice right now would be to try upping the number of workers you have and see if that helps
Cheers!

@dark9911 how many workers?

I have had it with 1 and also with 40, so i don't think it has anything to do with the amount of workers

Same issue here. It only seems to occur on queue workers, not on the application itself. Seems related to the long running processes. Haven't got Telescope nor Horizon.
Php: 7.3.7
Database: 10.3.15-MariaDB-1:10.3.15+maria~bionic
Laravel: v5.8.28

@dark9911 how many workers?

i set it to 10 workers

Just got hit with one today.. Guess @koenhoeijmakers was right. Has nothing to do with the amount of workers :(
Sentry says it failed making a request to grab user_settings from MYSQL during a job call.
ErrorException: Warning: Error while sending STMT_PREPARE packet. PID=27771

Just got hit with one today :(
@koenhoeijmakers is right. The error has nothing to do with the amount of workers.
Sentry says it failed making a request to grab user_settings from MYSQL during a job call.
ErrorException: Warning: Error while sending STMT_PREPARE packet. PID=27771

I'm with @Christophvh on the question about Sentry.
The error itself is pretty normal for long running jobs, but it supposed to be caught by the framework and transformed to a QueryException (which in turn triggers the re-connection to the database), so it should never reach Sentry in its native form.
But it does. (Maybe even before the framework catches and handles it? That would explain why there's no failed jobs)
So the question remains: do we all use Sentry?
I do: "sentry/sentry-laravel": "^1.0.0",
And also updated it to 1.0 the same time we did the 5.8 update.

@sebestenyb II think we are all using sentry. Sounds like we know where the problem lies now. I guess we should notify sentry next?

So the question remains: do we all use Sentry?

I do use Sentry. And I don't recall seeing the issue reported in HoneyBadger, which I also use.

I am using "sentry/sentry-laravel": "1.1.0", but at the time of updating all packages is also updated this, and wonder if the cause is in this package version. @sebestenyb Are you also receiving this errors 1.0.0?

I'm with @Christophvh on the question about Sentry.
The error itself is pretty normal for long running jobs, but it supposed to be caught by the framework and transformed to a QueryException (which in turn triggers the re-connection to the database), so it should never reach Sentry in its native form.
But it does. (Maybe even before the framework catches and handles it? That would explain why there's no failed jobs)
So the question remains: do we all use Sentry?
I do: "sentry/sentry-laravel": "^1.0.0",
And also updated it to 1.0 the same time we did the 5.8 update.

Perhaps parent::report($exception); should be placed at the beginning of the report method, rather than at the end of it? I don't see the error appear in my logs either.

my composer.json:
        "sentry/sentry-laravel": "^1.0",
and composer show | grep sentry:
sentry/sdk             2.0.3      This is a metapackage shipping sentry/sentry wit...
sentry/sentry          2.1.1      A PHP SDK for Sentry (http://sentry.io)
sentry/sentry-laravel  1.1.0      Laravel SDK for Sentry (https://sentry.io)

So the question remains: do we all use Sentry?

It may come from Sentry: On a project, I'm using both Sentry and Bugsnag, but this error only appears in Sentry.
NB: It happened both in Sentry 1.0.2 and 1.1.0

Happening to our app too. It's happening in a queued job and am using this sentry
sentry/sdk             2.0.3      This is a metapackage shipping sentry/sentry wit...
sentry/sentry          2.1.1      A PHP SDK for Sentry (http://sentry.io)
sentry/sentry-laravel  1.1.0      Laravel SDK for Sentry (https://sentry.io)

Along with Laravel Framework 5.8.27
No issues in Laravel 5.7.
Anyone know a workaround?

Same issue on our app. We are using queued jobs and sentry
sentry/sdk             2.0.3      This is a metapackage shipping sentry/sentry wit...
sentry/sentry          2.1.1      A PHP SDK for Sentry (http://sentry.io)
sentry/sentry-laravel  1.0.1      Laravel SDK for Sentry (https://sentry.io)

Laravel Framework 5.8.28

As replied by sentry in the sentry-laravel issue

Interesting. We would have to dig where the warning is emitted from since it might not be silenced and thus will be caught by Sentry which is correct.

Since 2.x of the base SDK (and 1.x of Laravel) "errors" (like warnings and notices) are captured much better which might be the reason of the uptick of the errors. We also now capture every "error" by default which you can change using the error_types option.

To reiterate what is said in the other issues, this is a warning and Laravel recovers from this gracefully so it's mere informational that this warning is emitted, it does not crash your apps or jobs these warnings were always emitted but not always captured.

So yes it's an error, but no the job wont fail (as Laravel will just reconnect).

For reference:

Our problem indeed also happens on MariaDB, not sure about mysql.

I'm experiencing the issue on MySQL.

Happens around 1 of 1000 jobs, could be complete random.

Same for me.

I'm using https://github.com/GeneaLabs/laravel-model-caching to cache my queries

I'm not using any form of model caching

It seems it has to do with Horizon/Telescope.

I'm also using Horizon but not Telescope.

Are all of you using transactions?

No transactions in my jobs either.

It seems like everybody with this problem is using Sentry?

I'm also using Sentry.

The warnings seem to have stopped for me after I've changed my retry_after and timeout according to the docs

The --timeout value should always be at least several seconds shorter than your retry_after configuration value. This will ensure that a worker processing a given job is always killed before the job is retried. If your --timeout option is longer than your retry_after configuration value, your jobs may be processed twice.

My timeout was 600 seconds in horizon but the retry_after was still the same (in the config/queue.php it's set at 90)

I'm going to close this as this seems to be Sentry specific and there really isn't an issue except from the warning. Thanks to everyone who helped investigate this 👍

My apologies if it is frowned upon to comment on a closed issue, but I'd like to quickly reply to the solution suggested by @koenhoeijmakers

The warnings seem to have stopped for me after I've changed my retry_after and timeout according to the docs

My configuration already had the retry_after set significantly higher than the timeout before this issue starting popping up, so (at least in my case) the two are not related.

Anyone have a solution for this? It's still an issue to at least v5.8.32

Same here on 5.8.32

@markdza @Mult1Hunter you can find the issue here https://github.com/getsentry/sentry-laravel/issues/254#issuecomment-512715265 seems like nothing to do with laravel itself.

Thanks. Looks like we are stuck with this warning in sentry then. Don't want to silence all warnings.

I ended up adding this method to Exceptions/Handler.php:
public function shouldReport(Exception $e)
    {
        // check if sentry is trying to falsely report 'Warning: Error while sending STMT_PREPARE packet. PID=XX'
        if (strpos($e->getMessage(), 'STMT_PREPARE packet') !== 'false') {
            return parent::shouldReport($e);
        }
    }```

I ended up adding this method to Exceptions/Handler.php:
public function shouldReport(Exception $e)
    {
        // check if sentry is trying to falsely report 'Warning: Error while sending STMT_PREPARE packet. PID=XX'
        if (strpos($e->getMessage(), 'STMT_PREPARE packet') !== 'false') {
            return parent::shouldReport($e);
        }
    }```

public function shouldReport(Exception $e)
{
        // check if sentry is trying to falsely report 'Warning: Error while sending STMT_PREPARE packet. PID=XX'
        if (strpos($e->getMessage(), 'STMT_PREPARE packet') === false) {
            return parent::shouldReport($e);
        }
}

@mrahmadt  What happens if the error message does NOT contain 'STMT_PREPARE packet'?
In your case it's undefined / not explicit, so I rewrote your code as follows:
    public function shouldReport(Exception $e)
    {
        // check if sentry is trying to falsely report 'Warning: Error while sending STMT_PREPARE packet. PID=XX'
        // see https://github.com/laravel/framework/issues/28920
        if (strpos($e->getMessage(), 'STMT_PREPARE packet') !== false) {
            return false;
        }

        return parent::shouldReport($e);
    }

I continue obtaining the error even though apply the code from last comment

I continue obtaining the error even though apply the code from last comment

I assume the Laravel logger is capturing it and logging it as opposed to the Exception Handler.

I also have the same issue.
Laravel 6.5.0
No sentry used.
More > 1000 Jobs
Queue limit to 1 process.
Horizon timeout set to 3600.

so the best solution is to discard error in handler?

I had the same problem with my laravel v6.18.0.
And the error stopped coming after update sentry/sentry-laravel library from v1.5.0 to v1.8.0 by command composer update sentry/sentry-laravel.

I continue obtaining the error even though apply the code from last comment

It also should help here, if the decision from comment above (excluding error by Error Handler) doesn't work.


Pep8 python3

This PR does more standard formatting and Python3 support.
I didn't test with Python2 but I think it should still work.

I'm a bit confused by this line: https://github.com/bmtgoncalves/Mining-Georeferenced-Data/blob/master/SurgePrediction_Live/MultiLayerSurgePrediction.py#L145
The point that are labelled 1.0 are used for training, but not evaluated in prediction.

Andrews thanks so much for your feedback.
Actually, I do something worse as I was just let by another attendee:
In the following lines 148-149 I effectively leak testing data to the
model!
The merits of democratising your code :).
We have a paper under submission on this, so that has been a life saver
amidst a little embarassing. The supervised learning results are not that
spectacular, but still the argument for using multiple data layers stays
valid (phew :). )
On 10 November 2015 at 13:36, Andreas Mueller<EMAIL_ADDRESS>wrote:

I'm a bit confused by this line:
https://github.com/bmtgoncalves/Mining-Georeferenced-Data/blob/master/SurgePrediction_Live/MultiLayerSurgePrediction.py#L145
The point that are labelled 1.0 are used for training, but not evaluated
in prediction.
—
Reply to this email directly or view it on GitHub
https://github.com/bmtgoncalves/Mining-Georeferenced-Data/pull/2#issuecomment-155525123
.

cross_val_predict(model, X_train, y_train, cv=LeaveOneOut(len(X_train))
Should be a good way to do the thing (possibly more savely).

all the whitespace fixes are a bit of a nitpick (done by autopep8) and if you want I can send a PR only containing the python3 fixes.

(also I don't think it's embarrassing. Everybody's code has bugs, you were brave enough to open your code up to criticism ;)

Thank you for the PR. I'm pretty picky about PEP8 compliance as well (have a plugin on subl to warn me when there's an issue).

Hi Andreas,
I have trying to use the above code for cross_validation but it is not easy
to find how to import the function appropriately. I am looking at this
example:
http://scikit-learn.org/stable/auto_examples/plot_cv_predict.html
This is what I am getting when trying to import through the interpreter.

from sklearn.cross_validation import cross_val_predict
Traceback (most recent call last):
File "", line 1, in
ImportError: cannot import name cross_val_predict
import sklearn.cross_validation

best,
tassos
On 10 November 2015 at 16:26, Andreas Mueller<EMAIL_ADDRESS>wrote:

cross_val_predict(model, X_train, y_train, cv=LeaveOneOut(len(X_train))
Should be a good way to do the thing (possibly more savely).
—
Reply to this email directly or view it on GitHub
https://github.com/bmtgoncalves/Mining-Georeferenced-Data/pull/2#issuecomment-155572176
.

You can find how to import it in the API docs:
http://scikit-learn.org/stable/modules/classes.html
This document contains all classes and functions and where to find them.
and see here:
http://scikit-learn.org/stable/modules/generated/sklearn.cross_validation.cross_val_predict.html#sklearn.cross_validation.cross_val_predict
cross_val_predict was introduced in 0.16, so it is likely that you have an older version. We are now at 0.17 btw.


set UTC mode if utc=YES

This Pull Request fixes https://github.com/pr1ntf/iohyve/issues/305.
I had same trouble on my FreeBSD machine.

Please check and merge this PR.


Use short service and characteristic type UUIDs

Respond with short type UUIDs for Apple-defined services and characteristics (fixes #740)
Require a description and type UUID for characteristics (these are currently optional?)
Fix service.getCharacteristic not automatically adding the Name characteristic

This causes the warning to go away for short form Apple UUIDs. Happy to approve.

This causes the warning to go away for short-form Apple UUIDs.

Warnings appearing in the console app or what warnings are you talking about?