Improve Gradle Configuration Time

As a part of https://github.com/gradle/gradle/issues/1628 I submitted Spring Security's Gradle  Configuration Time.
The Gradle team replied with:

The vast majority of the time (75%) is spent in the Gretty plugin, which is doing a lot of heavy lifting in dynamic Groovy. If it was migrated to @CompileStatic (or Java or Kotlin) you’d see a big improvement in your configuration time.

It would be nice if the Gretty plugin could improve the configuration time by switching to @CompileStatic, Java, or Kotlin.

See also https://github.com/gretty-gradle-plugin/gretty/issues/46 for the same issue on the gretty fork.

@wolfs Thanks! I was not aware of the fork.

@rwinch @wolfs So this issue has achieved something good and got me to learn to run the gradle-profiler, nice.  I ran this for myself a couple of times on spring-security.
Being new to the analysis and with reference to https://scans.gradle.com/s/7yjns4i55vj66/ ... I was not able to see where it was inferred that Gretty consume 75% of the configuration time.  Is there a 10 second explainer for that, which numbers to read?  In fact I had trouble working-out how to get the breakdown numbers to add to the totals ... are those timings averages per execution (that doesn't tally either).

@javabrett I didn't look at the results myself. I was told by the Gradle team after submitting my results. I'll see if they are able to help out here.

@javabrett Please use this branch of the Gradle profiler (which will be merged soon) to get easier to read flame graphs. You'll see Gretty consuming a huge amount of time in dynamic invocations in the CPU flame graph.
In general plugins should not contain any dynamic code unless absolutely necessary. I.e. the reasoning for closing the referenced PR was the wrong way around: You should always use @CompileStatic everywhere (or write Java or Kotlin), not just when someone explicitly told you about a performance problem.

The configuration-time performance improvement from adding @CompileStatic should now be available in Gretty 2.3.0-SNAPSHOT and 3.0.0-SNAPSHOT.  A 2.3.0 release shouldn't be too far away.
A subsequent buildscan for spring-security is available at https://scans.gradle.com/s/o6jlskwqa7k3y .
Thanks @rwinch for the report and @wolfs and @oehme for the profiler support.

What an excellent result, going from 3s to 100ms. Thank you!

@javabrett Did you post the right build scan? The scan you posted is for the gradle-profiler project, not for the spring security project. What is the improvement for the spring security project?

Thanks @wolfs .  Hmmm that's really annoying ... I guess I did not specify --project-dir . and reading https://github.com/gradle/gradle-profiler/blob/master/src/main/java/org/gradle/profiler/CommandLineParser.java#L22 :
defaultsTo(new File(".")

... I didn't spot that when invoking e.g. /path/to/gradle-profiler/build/install/gradle-profiler/bin/gradle-profiler ... help with cwd of the project-of-interest-to-profile, that's going to run for gradle-profiler.  Intentional do you think?

Build scan for 'measured build #1' build [help]: https://gradle.com/s/zsuig7soqm3om

... which I guess is going to be nowhere near the improvement, if any.  Does the buildscan profile provide any details, or is jfr with the flame graphs or something else needed to get the required details?

For algorithmic problems like this you'll need to use JFR/Flamegraphs. They'll point you right to the code that is causing the problem.

A couple of testing updates and observations:

One thing I hit was a problem running gradle-profiler against spring-security with jfr and with JDK9 (on macos).  I wasn't really meaning to run JDK9, but it's my current default and I forgot to switch-down to JDK8.  Raised https://github.com/gradle/gradle-profiler/issues/76 in case it is a profiler bug.
spring-security contains a number of transitive dependencies on Gretty (2.0.0), both in the buildscript and as plugins, so it is not trivial to swap-in a newer version - either a bunch of Spring deps need to be rebuilt as snapshots, or dependency management scripts need to be added.  Complicated by the groupId change org.akhikhl.gretty -> org.gretty.

https://github.com/spring-projects/spring-security/blob/master/build.gradle#L3
https://github.com/spring-projects/spring-security/blob/master/samples/javaconfig/concurrency/spring-security-samples-javaconfig-concurrency.gradle#L1
-> https://github.com/spring-gradle-plugins/spring-build-conventions/blob/master/build.gradle#L28

Could you elaborate what you mean by leaking test configuration?


feat(KC): justification + small fixes

Added features:

Unstaking of ineligible jurors
Justification of the vote
Safe transfers to avoid reverts
1 vote per address in PoH DK
Changing the default court to General instead of Forking. The latter is basically rudimental now. I need clarifications on how to implement the forking process
Some small fixes along the way

We could add the _justification as part of the commitment hash? L330


Feature/color schemes

Back again with a new PR, this time to add color schemes, or themes, to the app!
To get themes working in WinForms, some changes were needed, the biggest being;

Having to replace all TextBoxes with custom StyleableTextBoxes.
Having to replace all RichTextBoxes with custom StyleableRichTextBoxes.
Having to replace all ComboBoxes with custom StyleableComboBoxes.
Adding some custom events whose job is purely to draw over elements and apply colors from the ColorScheme.

I also wanted to include a custom color for the title bar, but this didn't seem to work on my Windows 10 machine, so I decided not to bother with it.
ColorSchemes are serializable, and are saved in the XML format. This way, users can create their own by simply duplicating any theme, changing the name, and applying changes to them.
So long as a scheme is inside the themes folder, it will get loaded, and will be added to the Themes Menu Item.
Right now, I have included 5 preset themes, which you can see in these screenshots;
Light Theme

Light Streamer Theme

Dark Theme

Dark Streamer Theme

Accented Dark Theme

This has been seen - will be reviewed.

I can't comment directly on lines in the PR. I'm not sure why.
I have some questions\comments:
Is there a reason ThemeFileOperations is internal instead of public or private?
Release version of binary seems to fail on reading the schemes - I couldn't figure out why after about 5 minutes of poking because it says the schemes list or an item in it is empty object reference, and I stepped through the list being filled.
XmlColor - why does color_ end with underscore instead of begin? I've seen fields begin with it but not end - does that style choice signify something?
ColorSchemeManager GetSelected() - Are you meaning to edit the incoming list reference? If so, please specify this in function name - "GetSpecifiedSchemeAndFillSchemesIfNecessary". Better yet, decompose the two things going on (choosing scheme and filling the list) into two separate functions, only using IEnumerables so that it's clear who gets to change the set..
I have a few minor style nits:
ThemeFileOperations line 16 - should be IEnumerable, not list, since once that set is returned you should not add to it
ThemeFileOperations line 18 - use Path.Combine
ThemeFileOperations line 42-49 - Would be better served by LINQ query (efficiency + intent to return set that should not be added to)
ColorSchemeManager lines 55 & 68 - for clearer intent, I'd change "foreach (var scheme in schemes.Where(scheme => scheme.Name == name))" to "scheme = schemes.FirstOrDefault(s =>s.Name == name); if (scheme != null)".
SettingsManager line 327 - newline after if closing bracket
This is a great PR - don't let my comments fool you; this is good work. Let me bring this up with the other main contributor, simon\a1xd, to firm up our approval of the addition of the theme state and directory.

Is there a reason ThemeFileOperations is internal instead of public or private

There is not, my IDE uses internal by default and I forgot to change it to public

Release version of binary seems to fail on reading the schemes - I couldn't figure out why after about 5 minutes of poking because it says the schemes list or an item in it is empty object reference, and I stepped through the list being filled.

I thought I fixed this a few days ago, this is caused by the CurrentTheme being null at the first time the application is launched after already having a .config file, since the JsonProperty is set to required for some reason. I'll take another look at it.

XmlColor - why does color_ end with underscore instead of begin? I've seen fields begin with it but not end - does that style choice signify something?

It does not, I copied this class over and forgot to look it over, thanks for the headsup!
This has been resolved.

ColorSchemeManager GetSelected() - Are you meaning to edit the incoming list reference? If so, please specify this in function name - "GetSpecifiedSchemeAndFillSchemesIfNecessary". Better yet, decompose the two things going on (choosing scheme and filling the list) into two separate functions, only using IEnumerables so that it's clear who gets to change the set..

That's a very good point, has been resolved!

ThemeFileOperations line 16 - should be IEnumerable, not list, since once that set is returned you should not add to it
ThemeFileOperations line 18 - use Path.Combine

Have been resolved.

ThemeFileOperations line 42-49 - Would be better served by LINQ query (efficiency + intent to return set that should not be added to)

I'm not sure how I would turn this into a LINQ query, could you give some more pointers on this?

ColorSchemeManager lines 55 & 68 - for clearer intent, I'd change "foreach (var scheme in schemes.Where(scheme => scheme.Name == name))" to "scheme = schemes.FirstOrDefault(s =>s.Name == name); if (scheme != null)".

Resolved

SettingsManager line 327 - newline after if closing bracket

Resolved

This is a great PR - don't let my comments fool you; this is good work. Let me bring this up with the other main contributor, simon\a1xd, to firm up our approval of the addition of the theme state and directory.

Thanks, much appreciated :)

Alright - last two comments on paths. Once resolved will merge.

I've completed your other PR, which has a couple conflicts with this one - merge latest master into your feature branch and fix the conflicts. Then I will merge

Master has been merged, and conflicts have been resolved

Nope, I'm just the worst. Merged


Improve exception messages when Windows fails to load an extension module

Probably I would not have noticed it otherwise but it is explicitly listed in "Whats New In Python 3.0". I have traced the change in CPython regarding this announcement to just two commits: d6179e12 (code) and bccd63c3 (NEWS entry).
The update in this PR reflects the change in IronPython. The old error message in IronPython was generic but contained the file name. The CPython message is specific about the cause of the failure but contains %1 instead of the file name. I remember encountering both in the past and being puzzled in both cases. So this update combines the specific error code/message with the file name (library path) used.

Seems like we've got a bunch of versions of the win32 exception handling code. Might be interesting to have something available in the core at some point (like PythonNT.GetLastWin32Error).

I saw that too. ctypes deserves a thorough review and possibly localized redesign. This is not going to happen for me before the summer recess, I'm now just picking up some loose ends that I've noticed.


Permit underscores as non-semantic separators in numeric constants

So we can write 0xFF_FF_FF_FF instead of 0xFFFFFFFF, or 1_000_000 instead of 1000000.  Many languages seem to permit this nowadays.  They have no semantic significance.

I'll leave this one open for a while to see if anyone wants to get their feet wet.  It's very simple to implement, I think - just a modification of the lexer.  The implementation involves extending the regular expressions for numeric constants, followed by filtering away the underscores before interpreting the number.

Hi, I am attempting to implement this feature. The changes to the lexer are simple enough and seem to be working. But one thing not discussed here is that if compiled programs are to accept numeric literals with underscores, changes will also need to be made into reader.py and reader.h.
The change to reader.py is trivial but because reader.h uses scanf to read input, to support literals with underscores we will need to replace scanf with a function of our own(something similar to parse_int in the Python reader).
I do want to continue work on this issue to make the change to reader.h. Just wanted to give you a heads-up on how I plan to proceed.

Right, I had forgotten about those. Good that you are working on this!

I little advice I thought of:

Remember to update the grammar in the language reference: https://github.com/HIPERFIT/futhark/blob/master/docs/language-reference.rst

Take care that numbers consisting entirely of underscores are not permitted.  An easy way to accomplish this may be to require that the first character is not an underscore.

Maybe it's OK to support multiple consecutive underscores.  Maybe it's useful for finer subdivision, e.g. for a binary literal: 0b1010_1010__1010_1010__1010_1010__1010_1010__1010_1010.  Your call.  Some languages don't permit this, others do.

Thanks! I will make sure to update the language reference before I send in a pull request.
I have changed the lexing rule to require the first character is not an underscore character.

Closed in fc5820aca8096cc77b73042e907103fd81ddaedc.


How to get the WhatsApp client version?

Does anyone know how to find out the version of the WhatsApp client using this library?

You can use window.Debug.VERSION


Need Month View With Resource (Room Detail like Day View)

I want Month View like Day View but there should be Date instead of Time.

Okay, please elaborate your question.
"There should be date instead of time" Where?
Please post a screenshot with your "desired" endresult 'mspaint' as for now your question seems unclear to what you want to be changed.

i want view like this:

please reply me as soon as possilbe.
Thanks

this seems like a template issue, custom made issue not a general library one.
this requires a rewrite with a new different type of template.
It can be done and I estimate it requires 2-3 days (8-10 hours of figuring everything out )
of fitting its not easy to make.

The views are templates.. feel free to do your own template... and maybe you can share with us!
Thats not an issue, but anthing, we can help!


Separable convolutions in 3D ( For example, separable_conv3d )

Is there a function to implement separable convolutions with 3D convolutions. We have a similar function in the case of 2D called as separable_conv2d()
Is there a similar implementations in 3D as well?
Thanks in Advance!

@sankethvedula, I don't think so.

You might ask on StackOverflow and see if there exists a feature like that, but I am not aware of such.

A separable_conv3d would be great to implement architectures like Xception to video and medical imaging data. Any way of extending the separable_conv2d implementation already present in TF?

Please refer to #7278


Rename csharp endpoint and nodejs endpoint

Renamed files correctly
Refers and fixes #16410

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: vedipen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@cjgronlund - Is @brapel (Bryan Apellanes) still the author for these updated articles? Thanks.

@cjgronlund - Assigning to you as writer is no longer in the address book.

@aahill
Hi, Aaron, Please have a look at this public PR and determine whether it should be accepted. Also, you'll need to add yourself as author. Thank you!
@nitinme @tchristiani

Looks good to me - thanks so much @vedipen, we really appreciate it! #sign-off
I don't have the permissions to merge, but @nitinme can after review, I believe.

@aahill: I'm sorry - only the author of this article, @brapel, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Looks good to me - thanks so much @vedipen, we really appreciate it! #sign-off
I'll add myself as the author, but @nitinme may need to merge this pull request in the mean time.

@aahill: I'm sorry - only the author of this article, @brapel, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Add in functional enrichment test

We need some basic proteomics on the p3 synapse set from which we can compute leapr pathways.

Added basic analysis. Still can add networks later.


v0.146.0

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin please rerender

@cshaley @conda-forge/core review and merge request. Thanks!

Thank you for stepping up!


prims algorithm

added Minimum spanning Tree using Prim's Algorithm.

@ayushi-2501 Your PR has been merged successfully, Thank you for your contribution.
Give repo a star if it was useful.
Happy hacking.


[relay] fixed read receipt logic

LGTM 👍

Merged/rebased in https://github.com/hbang/TypeStatus/commit/93e90c72729ba72ed9f2c1552a627fb3964dd3af


[Coverity CID: 180699] Error handling issues in /tests/bluetooth/tester/src/gatt.c

Static code scan issues seen in File: /tests/bluetooth/tester/src/gatt.c
Category: Error handling issues
Function: get_attrs
Component: Tests
CID: 180699
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

This has already been fixed by commit c20af890206e75ab4a3031c06e196bdfc1e1fe36


Get latest version of data only if exists

For data using [latestversion] in their directory structure (e.g. CMIP5 at DKRZ), this fix returns the latest version of the data after checking that the data actually exist in that version. Otherwise it goes back to the previous version and checks again, and so on.

looks good to me! :)


MIAD-194: ADR008: Historic Prisoner Alerts data fix will not be run in production

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.71%. Comparing base (0120ead) to head (5a58f3e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #265   +/-   ##
=========================================
  Coverage     91.71%   91.71%
  Complexity      534      534
=========================================
  Files            93       93
  Lines          1896     1896
  Branches        124      124
=========================================
  Hits           1739     1739
  Misses          106      106
  Partials         51       51

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add resources for test workloads

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 58.271%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
620

Relevant Lines:
1064

💛  - Coveralls


Create the Consolime terminal to display console state

A Consolime terminal is needed to display the console state. It should be possible to close with an Escape key.

It's done now, too!


SILOptimizer: add a diagnostics pass to warn about lifetime issues with weak references.

The DiagnoseLifetimeIssuesPass pass prints a warning if an object is stored to a weak property (or is weakly captured) and destroyed before the property (or captured reference) is ever used again.
This can happen if the programmer relies on the lexical scope to keep an object alive, but copy-propagation can shrink the object's lifetime to its last use.
For example:
  func test() {
    let k = Klass()
      // k is deallocated immediately after the closure capture (a store_weak).
      functionWithClosure({ [weak k] in
                            // crash!
                            k!.foo()
                          })
    }

Unfortunately this pass can only catch simple cases, but it's better than nothing.
rdar://73910632

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 514bd26f913d6ea4da2ad34294b9f39c79be0fc2

Build failed
Swift Test OS X Platform
Git Sha - 514bd26f913d6ea4da2ad34294b9f39c79be0fc2

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - d37a3529e2e7da265806e3cf46a4edb117114691

@eeckstein We should probably have another iteration of this diagnostic after you merge this that recurses through all ForwardingConsumes, not just Enum. There is a ForwardingOperand abstraction that's close to what you need for that. Without that, I think we could have false positive warnings.

We may also want to be more conservative in the OperandOwnership::DestroyingConsume case. That only destroys the OSSA value, but could actually forward the reference through a store.

@eeckstein in general this looks really great!

@swift-ci smoke test linux

@swift-ci smoke test windows

It may be good enough to just warn when the only destroys are actual Destroys.

You are right. I'll change that

@swift-ci smoke test linux

@swift-ci smoke test linux

@eeckstein I'm referring to cases like this
%0 = alloc_ref
%copy = copy_value %0
store %copy to ...
store_weak %0 to ...

or
%0 = alloc_ref
%copy = copy_value %0
%cast = cast %copy
store_weak %0 to ...
... = %cast

Ah, you are right. I fixed this.

@swift-ci smoke test


[SPARK-48580][CORE] Add consistency check and fallback for mapIds in push-merged block meta

What changes were proposed in this pull request?
Add consistency check for mapIds between the push-merged block meta from the server side and the mapTracker on the driver side for reduce tasks. If any mapIds is found missing in the chunk meta, fallback to fetching original shuffle blocks.
This end-to-end check helps to avoid issues of data loss during the shuffle read phase when reduce tasks fetch merged data.
Why are the changes needed?
ShuffleBlockFetcherIterator initializes requests based on the mergeStatus and mapStatus from the driver side, where the mergeStatus's mapTracker (partition level bitmap) comes from the mapTracker maintained in the shuffle service's memory. but the actual mapIds for fetching chunk data come from the shuffle service's metaFile. There is no consistency check between the two.
When the server encounters issues such as disk failures, it may cause inconsistencies in mapIds between the mapTracker and the metaFile. This ultimately results in data loss when reduce tasks fetch merged data.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT
Was this patch authored or co-authored using generative AI tooling?
No

@mridulm @otterc Please help review, thanks in advance!

Thanks for contributing this @gaoyajun02 , I will circle back to this later this week.

@gaoyajun02 , trying to understand the scenario better here - did you observe disk issues which resulted in this inconsistency ?
If yes, should this be checksum'ed - to ensure correctness.
I would prefer that to adding an additional rpc calls to the driver ? Given this should be a rare enough scenario.
Thoughts ?
Also, +CC @zhouyejoe as well.

Service nodes with disk issues (e.g. No space left on device, Read-only file system) have a large number of logs stating IOExceptions exceeded the threshold when merging shufflePush, as well as the following WARN log:
INFO application_xxx attempt 1 shuffle 0 shuffleMerge 0: finalize shuffle merge
WARN Application application_xxxx shuffleId 0 shuffleMergeId 0 reduceId 133 update to index/meta failed

The corresponding method is specifically updateChunkInfo -> writeChunkTracker, which encounters an IOException when serializing chunkTracker to disk.
Based on this information, it can be determined that: during the finalize partition process, writing the serialized chunk to the metaFile failed, but the truncate operation succeeded, meaning the bitmap of the last chunk was deleted from the metaFile, while the mapTracker records the mapId after the block data processing is completed.

Additionally, I have also encountered scenarios of data duplication: updateChunkInfo is also called after the block merge is completed. In this case (see code: link), if updating the metaFile fails due to IOException: No space left on device, the mapTracker will not record the mapId, but the chunkTracker is not reset. When finalizePartition is executed later and disk space is restored, the metaFile update succeeds, but the mapTracker does not lack this mapId.

The above example scenario was determined through metric collection and localization in our production environment. However, there are still many inconsistencies in mapId at the application layer that cannot be explained, and this PR cannot guarantee the final consistency of shuffle data. These service nodes (which account for a very small percentage of the cluster nodes, 0.1%) have common file system errors at the system level, and there is a small probability of data loss cases occurring daily. Given these types of issues, my current solution is to consider rolling back the entire reduce partition data, not just the inconsistent mapIds.

@gaoyajun02 , trying to understand the scenario better here - did you observe disk issues which resulted in this inconsistency ?
If yes, should this be checksum'ed - to ensure correctness. I would prefer that to adding additional rpc calls to the driver - which will now be incurred for all calls - given this should be a rare enough scenario.
Thoughts ?
Also, +CC @zhouyejoe as well.

The first two paragraphs are my descriptions of these scenarios.
The added getMergeStatusMapTracker call does not result in an additional RPC call to the driver during runtime, because after the first request for metadata, the mergeStatus is already saved in the mergeStatuses of the Executor side's MapOutputTrackerWorker. Considering that some system-level errors cannot be fully covered, I think it is necessary to perform merge metadata verification and fallback on the reduce side. @mridulm


top bar menus don't open in iOS

The top bar menus (File, Scene, etc.) won't open in iOS browsers.  (I've tried both chrome and safari apps)
the iOS version 10.3.1
Note: these menus do work with android

Unfortunately I don't have an iOS browser so I can't fix easily the issue for now.
The ui is not really designed for mobile, the top bar was meant to be opened on hover, not on click, so it's actually surprising it's working on android.
I think android consider a touch as an hover but iOS don't.
Looks like something to do with https://stackoverflow.com/questions/35187970/css-hover-not-working-on-ios-safari-and-chrome

yes an onclick attribute does fix this, closing this and opened an issue in yagui


Chart schemas, deployer script validation, and ci integration

Summary

Closes #937 by adding values.schema.yaml files, which if converted to values.schema.json files will be recognized by the helm CLI that will validate any passed helm chart values.
Adds helm chart schema validation of our clusters' hubs' configuration by trialing the helm template command against the chart in question with the non-encrypted helm chart values files.
Closes #279 by adding a workflow to trial our deployer scripts validate command by using the non-encrypted helm chart values files.
Closes #994 by manually ensuring and using the new schemas to ensure we don't have Helm chart values our templates rely on, but that we don't provide default values for in the Helm chart's values.yaml file
Cleans up helm chart configuration that wasn't correct, as identified by the schema files
Cleaned up logic associated with and content of requirements.txt and dev-requirements.txt

requirements.txt is now purely dependencies for the deployer script
dev-requirements.txt is now purely dependencies for scripts in the extra_scripts folder etc
Both files have inline comments to clarify the situation

Test failure unrelated
The test failure is unrelated and is resolved by #1044.

I am going to merge this now as I'd like to use some of the functionality added in the deployer in https://github.com/2i2c-org/infrastructure/pull/1047 to validate our support chart 🎉

I updated all the clusters/hubs helm charts locally and all is fine - so any failures in CI leftover are flakey tests

Lovely work, @consideRatio!


Thermostat wont show Temperature

I have set up everything and runs quite nice but my thermostat is showing nothing.
I am pretty newbie and dunno what i am doing wrong. THX

Just had the same issue (and looked it up here instead of start playing).
The docu at https://templates.blakadder.com/sonoff_NSPanel.html#use-example gives the necessary hints: sending the command NSPSend {"ATCEnable":1} at least enables the set point on the circle. Yet, for now it always resets to default 26°C after some seconds although it forwards the value to ESP: {"NSPanel":{"ATCMode":0,"ATCExpect0":18}} followed by a {"NSPanel":{"ATCEnable":1,"ATCMode":0,"ATCExpect0":26}}.

Ah, did not fully read through the docu: https://blakadder.github.io/nspanel/#activate-thermostat-page also gives the payload to send for the activation of that page.
Then, the display also 5-minutely sends a status like {"NSPanel":{"id":"1001383218","params":{"switch":"on","switches":[{"switch":"on","outlet":0}]}}}, if I see this correctly. Yet, still no manual changing of temperature on the screen without reset. But I have a clue.

So my clue was correct: enabling the command mirroring in nspanel.be solves the reset of set point temperature.
Two things still open:

how to get rid of the notification page (to set up via ewelink app) when switching to automatic mode on screen?
why tasmota-nspanel build does not include thermostat functionality (https://tasmota.github.io/docs/Commands/#thermostat) as the (imho correct) counterpart for the thermostat page?

Ah, did not fully read through the docu: https://blakadder.github.io/nspanel/#activate-thermostat-page also gives the payload to send for the activation of that page. Then, the display also 5-minutely sends a status like {"NSPanel":{"id":"1001383218","params":{"switch":"on","switches":[{"switch":"on","outlet":0}]}}}, if I see this correctly (so not only in auto mode which is not possible to select on screen with a note to enable that from the eWeLink app). Yet, still no manual changing of temperature on the screen without reset. But I have a clue.

 Can't reproduce and the activation is anyway part of nspanel.be's screeninit().

Ok, beside thermostat functionality (https://tasmota.github.io/docs/Commands/#thermostat), there are other options to consider:

https://tasmota.github.io/docs/Rules/#simple-thermostat-example
https://github.com/Beormund/Tasmota32-Multi-Zone-Heating-Controller
own simple Berry thermostat controller


Error connecting to Redis instance

Hi we're having trouble connecting to our Redis instance, and we believe we've set all RsmqOptions correctly (e.g., hostname and password work when connecting manually via redis-cli). There might be a bug in the way the password is prefixed with "redis" in normal_facade.rs (l24):
 pub async fn new(options: RsmqOptions) -> RsmqResult<Rsmq> {
        let password = if let Some(password) = options.password.clone() {
            format!("redis:{}@", password)
        } else {
            "".to_string()
        };

Is prefixing "redis" a necessity? I think this is causing our authentication issue.

Yeah, that is a bug. One sec and I will fix it

What is happening there is that the username is "redis" and then it is inserting the password into the string.
Does the password contain characters like ":" or "@"?

I think I will change it so it uses the redis ConnectionInfo type directly rather than an string. So we can avoid problems with passwords with special characters

It would be similar if you use the normal facade, btw.
I see the interface isn't ideal. I will see if I can code some better functions tonight or tomorrow. Meanwhile, try that and let me know

Just updated the library to v6.0.0 which uses the internal types from redis to build the ConnectionInfo so the password is passed as-is to the redis library. That should fix your issues.

Thanks, David, we'll try it out!


Kaldi service does not have transcription likelihoods

Kaldi ASR service does not report transcription likelihoods, making it hard to decide when a phrase should not be recognized.

Implemented in master branch. See: https://community.rhasspy.org/t/how-does-the-confidence-score-work/2229/7

Implemented in master branch. See: https://community.rhasspy.org/t/how-does-the-confidence-score-work/2229/7

Now in latest 2.5.10.


rpc error: code = DeadlineExceeded desc = context deadline exceeded

Can't start deployment:
Events:
  Type     Reason                  Age                From                     Message
  ----     ------                  ----               ----                     -------
  Normal   Scheduled               102s               default-scheduler        Successfully assigned media/pod-65fd4bd946-rx8f4 to fsn-w-node-1
  Warning  FailedAttachVolume      87s                attachdetach-controller  AttachVolume.Attach failed for volume "k8s-pod-data" : attachment timeout for volume k8s-pod-data
  Warning  FailedAttachVolume      82s (x3 over 86s)  attachdetach-controller  AttachVolume.Attach failed for volume "k8s-pod-data" : rpc error: code = Aborted desc = The volume k8s-pod-data is attaching
  Normal   SuccessfulAttachVolume  78s                attachdetach-controller  AttachVolume.Attach succeeded for volume "k8s-pod-data"
  Warning  FailedMount             55s                kubelet, fsn-w-node-1    MountVolume.SetUp failed for volume "k8s-pod-data" : rpc error: code = DeadlineExceeded desc = context deadline exceeded
  Warning  FailedMount             21s (x6 over 54s)  kubelet, fsn-w-node-1    MountVolume.SetUp failed for volume "k8s-pod-data" : rpc error: code = Internal desc = mount failed: exit status 32
Mounting command: mount
Mounting arguments: -t ext4 -o defaults /dev/longhorn/k8s-pod-data /var/lib/kubelet/pods/26a09bb1-80aa-11e9-beb5-96000026364c/volumes/kubernetes.io~csi/k8s-pod-data/mount
Output: mount: /dev/longhorn/k8s-pod-data is already mounted or /var/lib/kubelet/pods/26a09bb1-80aa-11e9-beb5-96000026364c/volumes/kubernetes.io~csi/k8s-pod-data/mount busy

Any ideas how to fix that issue?

Useful
Info

Versions
Rancher v2.2.3 UI: v2.2.41

Route
workload

Hi @vistalba, did you managed to fix the issue? What was the reason?

I have the same error and don't have any clues


azure front door managed certificates

Hi! I can't find any information on how the Azure front door managed certificates are actually managed.
What if an azure front door managed certificated needs to be revoked, are there any process of doing this? Are there any documentation for this?
Regards,
Frank Thingelstad
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f7be424c-f540-a753-6ecc-6ff3913368d5
Version Independent ID: dc80b25f-374d-8775-16e7-ae7d57b4b94f
Content: Azure Front Door - Frequently Asked Questions
Content Source: articles/frontdoor/front-door-faq.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: duau

Hello @frankthing, Thank you for your feedback! We will review and update as appropriate.

@frankthing , As mentioned here, when you use a certificate managed by Azure Front Door, the HTTPS feature can be turned on with just a few clicks. Azure Front Door completely handles certificate management tasks such as procurement and renewal. After you enable the feature, the process starts immediately. If the custom domain is already mapped to the Front Door's default frontend host ({hostname}.azurefd.net), no further action is required. Front Door will process the steps and complete your request automatically.
And for the Front Door managed certificate option, the certificates are autorotated by Front Door. If you are using a Front Door managed certificate and see that the certificate expiry date is less than 60 days away, file a support ticket.
Refer : https://docs.microsoft.com/en-us/azure/frontdoor/front-door-faq#does-front-door-support-autorotation-of-certificates
The certificate management tasks such as procurement and renewal of Front Door managed certificates are handled in the backend and that information is not available publicly.
May I know what are you referring to when you say "What if an azure front door managed certificated needs to be revoked"?

Hi and thanks! What I mean is that, if there is an scenario where for example there are signs of compromised keys, and the ssl certificate needs to be replaced and the old one invalidated.  When we use self maanged certificates, we have routines on how to perform this, but in a case where we use frontdoor-managed certificates and we do not manage them on our own, how would this look like?
Just tried to find any information or documentation about this as this is typically someting our security department would ask for.

@frankthing , thank you for the update. As I mentioned earlier, for the Front Door managed certificate option, the certificates are autorotated by Front Door and are taken care of in the backend in case of any issues. However, let me reach out to the backend team to see if they can provide some more insights on same.

@frankthing , below is the update that I received from the backend team regarding Azure FrontDoor managed certificates:
There is an internal security team which keeps track of certificates which have been compromised. This team drives all teams including AFD/CDN to force rotate the certs if such a case arises. A recent example was certs which were revoked by Digicert (link).
In terms of work – once we get signal, we rotate them from our own Key Vault where these certs are stored.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


feat: Revamp README for improved clarity and developer onboarding

Added a detailed project overview and features section.
Expanded installation instructions with dependency details.
Enhanced usage examples for Transaction, Request, and Origins classes.
Introduced a new section on error handling with code examples.
Added contributing guidelines, including coding standards and feedback process.
Included visual and structural improvements for better readability.
Updated Table of Contents to reflect new sections.

This update improves developer onboarding and provides clearer documentation for the News Ladder library.

LGTM 💪🏻


make turn costs work

there is code for it, make it reasonable (maybe restrict to left turns?)

I did some investigating but couldn't quite figure out all the pieces, but here's some notes.
What's happening
Here's the rough idea of what's happening:

WaySegmentParser goes through every OSM element, and for relations that are for turning from one edge to another will process the relation twice. First to remember the OSM way IDs in the relation for later, and second to create the OSMTurnRelation object and pass it to OSMTurnRelationParser.
The OSMTurnRelationParser evaluates the OSMTurnRelation's restrictions tag and stores the relation and result (infinity or 0) in the TurnCostStorage, which uses ints: fromEdge, viaNode, toEdge, and cost.
(later...)
The DefaultWeightingFactory assigns each weighting (e.g. PriorityWeighting) a DefaultTurnCostProvider
Many things call the DefaultTurnCostProvider's calcTurnWeight function: the CH Graph classes as well as a chain of utility functions in GHUtility that are then called by the Dijkstra class during the run of the dijkstra algorithm
calcTurnWeight unloads the costs from TurnCostStorage to return, or when the turn is a u-turn, just uses a configured u_turn_cost.

Changes
We need to make sure turn_costs: true is on for config-local.yaml, it's not yet. That's easy.
We could modify the OSMTurnRelationParser to store a different turn cost, if the tags of the relation, its two ways, and the node all fit certain conditions. This would require figuring out the right OSM way tags and OSM node tags just from the internal edge/node IDs.
Or we could make a different TurnCostProvider that calculates turn weight after unloading from storage. Again we would need to find a method for loading the way and node tags from internal edge/node IDs.
The difference is mainly at what stage we want to perform that operation -- during OSM data loading or during CH & dijkstra's.

Got stuck on implementing turn costs this weekend. Some things that I tried:

Adding a turn cost to edges in GraphExplorer.streetEdgeStream(). This was what Hazel tried in PR #84. However, this made server initialization painstakingly slow (> 1h). So I built the cache by initializing the server with a binary from the master branch and then ran the server. This did change routes slightly but it completely messed up the time calculation, for example, giving times like 21 minutes to travel 1 km, and 1h16m to travel the length of Market Street. I couldn't place exactly why this happened, but I think it's because we're double- / triple-, ..., n-counting turn costs.
Adding a turn cost to Gtfs.HIGHWAY edges in MultiCriteriaLabelSettingSpliterator.tryAdvance(). This again made initialization too slow. I tried routes on a smaller region and they failed because edge IDs were OOB. I think this was because I was passing the wrong edge IDs around and to the DefaultTurnCostProvider, but I'm not fully sure because it was difficult to diagnose and debug.

FWIW the Graphhopper team hasn't fully implemented this feature either. They have an outstanding PR for it, but it will only work for single-mode directions. I'm going to make a tactical retreat and try playing with cost calculation and edge weights on unit tests to see what happens at a much smaller scale before giving this another stab.

I think I've found a bug in my implemented logic where we are incorrectly penalizing intersection with straight angles, e.g.
0 -- 1 -- 2
angle: 180 deg

In calcChangeAngle(), we ensure that the angle of incidence falls in the interval [-180, 180]. The literal edge case is that, it's possible that both edges passed to calcChangeAngle() have azimuths of 0 degrees. In this case, we add 180 within the function, causing all straight-angled intersections to receive a U-turn penalty, since U-turns are -180 or 180 degrees as specified within our TurnCostsConfig.
Our orientation calculation leverages GraphHopper's lightweight DecimalEncodingValue mechanism, with possible values only aligning on every 12 degrees (5 bits needed to encode all possible values). This means that there's a slice of about 2π/15 where "straight" intersections are being treated as u-turns.
I'm implementing some unit tests to verify a corrected behavior in where we exit early if both edges have the same azimuth; meaning that the angle of incidence is a straight one.


[ISSUE-292] RAW Block volumes support

Purpose
Issue #292
Add Support for RAW Block volumes

Do we have related e2e tests for this?

Do we have related e2e tests for this?

@mishoyama
Yes, https://github.com/dell/csi-baremetal/blob/783bef2d27e8489fcfdd76e3374bb9322811def8/test/e2e/scenarios/different-sc-test.go#L120


Clarify documentation of the timestamp offset for streams

Hey Guys,
We are using streams in RabbitMQ. It was very confusing when we try to attach to a stream at midnight. It turns out we actually attach to a nearest chunk that was earlier. I propose that you make these changes to documentation:
https://www.rabbitmq.com/streams.html
Where it reads:
Timestamp - a timestamp value specifying the point in time to attach to the log at. It will clamp to the closest offset, if the timestamp is out of range for the stream it will clamp either the start or end of the log respectively. With AMQP 0.9.1, the timestamp used is POSIX time with an accuracy of one second, that is the number of seconds since 00:00:00 UTC, 1970-01-01. Be aware consumers can receive messages published a bit before the specified timestamp.
Replace with:
Timestamp - a timestamp value specifying the point in time to attach to the log at. It will clamp to the closest offset, if the timestamp is out of range for the stream it will clamp either the start or end of the log respectively. The chunk size is dynamic and based on the message ingress rate. Be aware consumers can receive messages published a bit before the specified timestamp. Applications consuming RabbitMq streams should apply filter to ingest messages of interest. With AMQP 0.9.1, the timestamp used is POSIX time with an accuracy of one second, that is the number of seconds since 00:00:00 UTC, 1970-01-01. Note: Timestamp where client attaches to the stream queue is not message time timestamp
I feel this should clear the confusion once for all. (I mean until next time implementation changes ;) )

I agree we should clarify that the timestamp used is the arrival time not any other use provided timestamp.
I'm not sure the suggested paragraph makes this particularly clear however.
How about something like:
Timestamp - a timestamp value specifying the approximate point in time at which to attach to the stream. RabbitMQ streams record the arrival time of each message and it to determine the attach offset, not any other timestamp provided in the message itself (RabbitMQ stream do not interpret the messages at all). It will clamp to the closest preceding offset, if the timestamp is out of range for the stream it will clamp to either the start or end of the stream respectively. With AMQP 0.9.1, the timestamp used is POSIX time with an accuracy of one second, that is the number of seconds since 00:00:00 UTC, 1970-01-01. Given the above behaviour, consumers can receive messages published a bit before the specified timestamp.
The implementation for time based stream attachment hasn't changed AFAIK and is unlikely to ever change as there is no reasonable alternative that I can see.

"RabbitMQ streams record the arrival time of each message and it to determine the attach offset" <-- something missing here
@kjnilsson I modified my message based on your suggestions. I think this description should be blunt. I mention chunk to make sure it's known that chunk is dynamic and unpredictable - so do not base your logic on it. The gist is: you will get some messages before the timestamp you specified and you should filter.
Timestamp - a timestamp value specifying an approximate point in time at which to attach to the stream. It will clamp to the closest offset, if the timestamp is out of range for the stream it will clamp either the start or end of the log respectively. The chunk size is dynamic and based on the message ingress rate. Be aware consumers can receive messages published a bit before the specified timestamp. Applications consuming RabbitMq streams should apply filter to ingest messages of interest. With AMQP 0.9.1, the timestamp used is POSIX time with an accuracy of one second, that is the number of seconds since 00:00:00 UTC, 1970-01-01. Note: Timestamp where client attaches to the stream queue is not message arrival time timestamp or any other timestamp provided in the message itself (RabbitMQ stream does not interpret the messages at all).

I'd remove "The chunk size is dynamic and based on the message ingress rate." above.

I'd remove "The chunk size is dynamic and based on the message ingress rate." above.

Yeah I have mixed feelings about it too. It's internal detail, you are probably right.

@Vic152 may I ask what was the exact problem that "sending at midnight" presented? It's difficult for us to edit without understanding what part was confusing and why.

Yeah this does not matter that much. Say 00:00 UTC. We replay messages from 00:00UTC of every day. It does not matter.
Attach at any point of time but you do not really. Then you attach to start of a chunk that is of uncertain size/message count. However, you are guaranteed to attach to stream before your timestamp. Our problem is that this functionality worked a bit random until we understood that it does not attach to the message but the chunk but chunks are dynamic.
The behaviour of streams is not what one would expect. If I say I want to attach at 00:00 I want to attach at 00:00, not a bit before, even worse, an uncertain bit before that is highly dynamic. Of course this is done like this to address general case but not obvious.
Aim to edit doc is to stress and make it unequivocally clear that you do not attach to particular message arrival timestamp but some arbitrary, unknown time before. That it is responsibility of your application to filter for exact time.
Also, general suggestion - with my technical writer hat on - use short sentences. Avoid commas if possible.

@Vic152 so it's the approximation due to chunked data transfer that was confusing. Thanks.

@Vic152 so it's the approximation due to chunked data transfer that was confusing. Thanks.

That. It would be nice to include guidance in the documentation about how to deal with the behaviour. It would save time if the users were told they need to filter.


Curl executable

I guess there is no way around of installing curl to path ?

You can also specify the path to the curl executable using the ToolSettings.ToolPath property:
Task("Download")
    .Does(() =>
{
    CurlDownloadFile(
        new Uri("http://host/file.txt"),
        new CurlDownloadSettings
        {
            ToolPath = "/path/to/curl"
        });
});

@matkoch assuming that you are on a Windows Machine, you could use chocolatey to fetch and install curl, which is a simple choco install curl, which puts the curl.exe on your path.
If you wanted to go one step further, you could use the ChocolateyInstall alias to install curl as part of your build process.
And if you wanted to go one step even further, you could try out my new Module (which hasn't actually been released yet) Cake.Chocolatey.Module which would let you add this:
 #tool choco:?package=curl
to the top of your build script, and assuming that you have chocolatey installed already, it would perform the installation of the tool.

@matkoch Did this answer your question?

Probably @gep13 s answer is the right, but I ended up building my own build tool. So this is no longer relevant to me. I will close this anyhow.


[firebase_admob] Fix firebase_admob issues caused by un-handled exception situations

Migrates flutter/plugins#1807 by @archanpaul

Any clue why CI checks are failing with "wait_for_emulator" error? It will be great if this is merged with master soon.

Closing this due to upcoming AdMob refactoring:
https://github.com/FirebaseExtended/flutterfire/issues/2521


How to restore a snapshotted downstream cluster master-head 4e57bbf

Rancher Server Setup

Rancher version: master-head 4e57bbf (also all others I tried)
Installation option (Docker install/Helm Chart):

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): Helm chart, 3 node K3s cluster

Proxy/Cert Details: No proxy, self-signed certs

Information about the Cluster

Kubernetes version: 1.21.2
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):
Custom, 1 node KVM RKE2

Describe the bug
Snapshot of a cluster works. How to restore?
To Reproduce
Snapshot a downstream cluster. How to restore?
Result
Snapshot OK.
Expected Result
A button or link to restore.
Screenshots

Additional context
<!--Add any other context about the problem here.—>

Not in the menu, need to go to the cluster -> snapshot tabs.


Bulk request for MONDO IDs

Hi,
I have 9 diseases/disorders I would like to request a MONDO ID for based on gene curations performed using the ClinGen framework
Mondo_bulk_submission_ILMN_17_Nov_2023.xlsx
. I have filled in the template for bulk submissions as directed - see attached.
Thank you in advance for your help!
Best wishes,
Alison

thank you @acoffey26. We'll review these soon and let you know if we have any questions.

@acoffey26 to confirm, you want to replace the definition for MONDO:0100061 'PRPS1 deficiency disorder'?

Sorry should have deleted that row!
Please start from row 5.
Thank you,
Alison
@.***
Alison Coffey, PhD
Senior Manager, Clinical Genomics,
Illumina Services Laboratory, San Diego
Medical Genomics Research
858.202.4500
<EMAIL_ADDRESS>www.illumina.comhttp://www.illumina.com/
@.***
@.https://www.facebook.com/illuminainc/ @. https://www.linkedin.com/company/illumina @.*** https://twitter.com/illumina
From: Nicole Vasilevsky @.>
Sent: Tuesday, December 12, 2023 5:23 PM
To: monarch-initiative/mondo @.>
Cc: Coffey, Alison @.>; Mention @.>
Subject: Re: [monarch-initiative/mondo] Bulk request for MONDO IDs (Issue #6882)
External message, be mindful when clicking links or attachments
@acoffey26https://urldefense.com/v3/__https:/github.com/acoffey26__;!!HrbR-XT-OQ!SI9kqUw4Xw8DlWZY5uYo3Vls_kjgKvrUOAOGa_WPHjR8GQX2mmK8Qrk5Vv-_xVMDbiQA4fRqEuLtmQ33UC8bgm1nkw$ to confirm, you want to replace the definition for MONDO:0100061 'PRPS1 deficiency disorder'?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/monarch-initiative/mondo/issues/6882*issuecomment-1852479178__;Iw!!HrbR-XT-OQ!SI9kqUw4Xw8DlWZY5uYo3Vls_kjgKvrUOAOGa_WPHjR8GQX2mmK8Qrk5Vv-_xVMDbiQA4fRqEuLtmQ33UC-Napx_Mw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AUGOWL25RBRA5EUJFZI7VM3YJCHGTAVCNFSM6AAAAAA7PYLDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGQ3TSMJXHA__;!!HrbR-XT-OQ!SI9kqUw4Xw8DlWZY5uYo3Vls_kjgKvrUOAOGa_WPHjR8GQX2mmK8Qrk5Vv-_xVMDbiQA4fRqEuLtmQ33UC-sQxtSgQ$.
You are receiving this because you were mentioned.Message ID: @.***>

sounds good, thanks!

@acoffey26 Is there a clingen working group URL that I can associate with these requests?

We are requesting these for internal gene curations performed using the ClinGen framework but they will be presented to the Syndromic Disorders GCEP over time. Does that help?
https://clinicalgenome.org/affiliation/40060/
We come under the “Other” group
https://clinicalgenome.org/working-groups/clinical-domain/other/
@.***
Alison Coffey, PhD
Senior Manager, Clinical Genomics,
Illumina Services Laboratory, San Diego
Medical Genomics Research
858.202.4500
<EMAIL_ADDRESS>www.illumina.comhttp://www.illumina.com/
@.***
@.https://www.facebook.com/illuminainc/ @. https://www.linkedin.com/company/illumina @.*** https://twitter.com/illumina
From: Nicole Vasilevsky @.>
Sent: Tuesday, December 12, 2023 6:33 PM
To: monarch-initiative/mondo @.>
Cc: Coffey, Alison @.>; Mention @.>
Subject: Re: [monarch-initiative/mondo] Bulk request for MONDO IDs (Issue #6882)
External message, be mindful when clicking links or attachments
@acoffey26https://urldefense.com/v3/__https:/github.com/acoffey26__;!!HrbR-XT-OQ!Q7M8aBpnB3edRSnFDbgVYiu0A-rIf2tSw3-gy2iDM0_3u-QcA1fUkjlmuF_3zzhhLRiKt26pA--luQt3qsoMeEmA2A$ Is there a clingen working group URL that I can associate with these requests?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/monarch-initiative/mondo/issues/6882*issuecomment-1852594845__;Iw!!HrbR-XT-OQ!Q7M8aBpnB3edRSnFDbgVYiu0A-rIf2tSw3-gy2iDM0_3u-QcA1fUkjlmuF_3zzhhLRiKt26pA--luQt3qsqnpykqag$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AUGOWL77D5ZCGMQYIJHUOKDYJCPMVAVCNFSM6AAAAAA7PYLDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGU4TIOBUGU__;!!HrbR-XT-OQ!Q7M8aBpnB3edRSnFDbgVYiu0A-rIf2tSw3-gy2iDM0_3u-QcA1fUkjlmuF_3zzhhLRiKt26pA--luQt3qsp_p1QzMA$.
You are receiving this because you were mentioned.Message ID: @.***>

perfect, thanks!

@acoffey26
Another question:
The spreadshseet specifies that MONDO:0010011 schizencephaly should be a child of COL4A1-related disorders but I don't see evidence of COL4A1 being involved in this term on the OMIM page: https://omim.org/entry/269160
Is this a mistake or if not, could you please provide evidence of that?
Thank you!

@acoffey26
There is a request for MONDO:0009974 'familial hemophagocytic lymphohistiocytosis type 1' to be a child of FHL1-related myopathy, but this does not seem correct to me. Could you confirm and provide evidence? Thanks!

@acoffey26
for KIF7-related ciliopathies, this code was added to be a child, but this is not a valid ID:
MONDO:00111778

Hi,
Thank you for your email re a problem with ID MONDO:00111778.
Please accept my apologies, this was a typo on our part and the ID should be MONDO:0011778.
Please let me know if you have any further questions re this ID,
Thank you for your help,
Best wishes,
Alison
@.***
Alison Coffey, PhD
Senior Manager, Clinical Genomics,
Illumina Services Laboratory, San Diego
Medical Genomics Research
858.202.4500
<EMAIL_ADDRESS>www.illumina.comhttp://www.illumina.com/
@.***
@.https://www.facebook.com/illuminainc/ @. https://www.linkedin.com/company/illumina @.*** https://twitter.com/illumina
From: Nicole Vasilevsky @.>
Sent: Thursday, December 14, 2023 7:05 PM
To: monarch-initiative/mondo @.>
Cc: Coffey, Alison @.>; Mention @.>
Subject: Re: [monarch-initiative/mondo] Bulk request for MONDO IDs (Issue #6882)
External message, be mindful when clicking links or attachments
@acoffey26https://urldefense.com/v3/__https:/github.com/acoffey26__;!!HrbR-XT-OQ!VcN6A5DuU1lVasScUytVtiTuJaBp39FqwENEIKMgsq7WgBS08oLPXJ0vG_aIh8D6BjVBmMgiYGT0LgBZnOiB54s4Pg$
for KIF7-related ciliopathies, this code was added to be a child, but this is not a valid ID:
MONDO:00111778
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/monarch-initiative/mondo/issues/6882*issuecomment-1856423924__;Iw!!HrbR-XT-OQ!VcN6A5DuU1lVasScUytVtiTuJaBp39FqwENEIKMgsq7WgBS08oLPXJ0vG_aIh8D6BjVBmMgiYGT0LgBZnOj3a4CG2g$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AUGOWL3LNZQZZVIMDQ3TZBLYJNEWFAVCNFSM6AAAAAA7PYLDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGQZDGOJSGQ__;!!HrbR-XT-OQ!VcN6A5DuU1lVasScUytVtiTuJaBp39FqwENEIKMgsq7WgBS08oLPXJ0vG_aIh8D6BjVBmMgiYGT0LgBZnOiRdTUGyg$.
You are receiving this because you were mentioned.Message ID: @.***>

Hi,
Thank you for your enquiry re the inclusion of MONDO:0009974 'familial hemophagocytic lymphohistiocytosis type 1' to be a child of FHL1-related myopathy.
We reviewed our request and agree that this is not a suitable child term for FHL1-related myopathy so would ike to revise our request and remove this term. The edited child terms for FHL1-related myopathy are now suggested as:
X-linked myopathy with postural muscle atrophy|myopathy, reducing body, X-linked, childhood-onset|myopathy, reducing body, X-linked, early-onset, severe|Uruguay Faciocardiomusculoskeletal syndrome|X-linked scapuloperoneal muscular dystrophy| X-linked Emery-Dreifuss muscular dystrophy
MONDO:0010401|MONDO:0010415|MONDO:0010414|MONDO:0010292|MONDO:0010400|MONDO:0010680
Many thanks for your help,
Best wishes,
Alison
@.***
Alison Coffey, PhD
Senior Manager, Clinical Genomics,
Illumina Services Laboratory, San Diego
Medical Genomics Research
858.202.4500
<EMAIL_ADDRESS>www.illumina.comhttp://www.illumina.com/
@.***
@.https://www.facebook.com/illuminainc/ @. https://www.linkedin.com/company/illumina @.*** https://twitter.com/illumina
From: Nicole Vasilevsky @.>
Sent: Thursday, December 14, 2023 7:03 PM
To: monarch-initiative/mondo @.>
Cc: Coffey, Alison @.>; Mention @.>
Subject: Re: [monarch-initiative/mondo] Bulk request for MONDO IDs (Issue #6882)
External message, be mindful when clicking links or attachments
@acoffey26https://urldefense.com/v3/__https:/github.com/acoffey26__;!!HrbR-XT-OQ!U3qqx9zYvkdcQ-knOsfOHyzjAZQzVLdbnnjKK-p9yVBUJrxvjJ51FdgHv2KSSBs-dcEfPj2UdHGVH_9xSRVBOM5dKg$
There is a request for MONDO:0009974 'familial hemophagocytic lymphohistiocytosis type 1' to be a child of FHL1-related myopathy, but this does not seem correct to me. Could you confirm and provide evidence? Thanks!
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/monarch-initiative/mondo/issues/6882*issuecomment-1856420914__;Iw!!HrbR-XT-OQ!U3qqx9zYvkdcQ-knOsfOHyzjAZQzVLdbnnjKK-p9yVBUJrxvjJ51FdgHv2KSSBs-dcEfPj2UdHGVH_9xSRU336UCKQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AUGOWLY6O77XWSIIPCK4CR3YJNEOFAVCNFSM6AAAAAA7PYLDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGQZDAOJRGQ__;!!HrbR-XT-OQ!U3qqx9zYvkdcQ-knOsfOHyzjAZQzVLdbnnjKK-p9yVBUJrxvjJ51FdgHv2KSSBs-dcEfPj2UdHGVH_9xSRWodUUqIw$.
You are receiving this because you were mentioned.Message ID: @.***>

Dear Nicole,
Thank you for your email and enquiry re MONDO:0010011 schizencephaly being a child of COL4A1-related disorders.
We listed schizencephaly  as a child term based on a reference to schizencephaly in OMIM and a publication listed in GeneReviews.
If you open up the clinical synopsis page in OMIM for the disorders associated with COL4A1 ( https://www.omim.org/clinicalSynopsis/table?mimNumber=180000,614519,611773,175780,618564), schizencephaly is listed under BRAIN SMALL VESSEL DISEASE 1 WITH OR WITHOUT OCULAR ANOMALIES; BSVD1 in the section on Central Nervous System.
It is also discussed in PMID: 23225343 (see attached) which describes the finding of variants in COL4A1 in individuals with schizencephaly and suggests the expansion of phenotypic spectrum of COL4A1-related disorders to include schizencephaly.
I hope this provides enough evidence for the inclusion of schizencephaly as a child term, please let me know if you have any further questions and we will be happy to help.
Thank you for your help and careful review,
Best wishes,
Alison
@.***
Alison Coffey, PhD
Senior Manager, Clinical Genomics,
Illumina Services Laboratory, San Diego
Medical Genomics Research
858.202.4500
<EMAIL_ADDRESS>www.illumina.comhttp://www.illumina.com/
@.***
@.https://www.facebook.com/illuminainc/ @. https://www.linkedin.com/company/illumina @.*** https://twitter.com/illumina
From: Nicole Vasilevsky @.>
Sent: Thursday, December 14, 2023 6:55 PM
To: monarch-initiative/mondo @.>
Cc: Coffey, Alison @.>; Mention @.>
Subject: Re: [monarch-initiative/mondo] Bulk request for MONDO IDs (Issue #6882)
External message, be mindful when clicking links or attachments
@acoffey26https://urldefense.com/v3/__https:/github.com/acoffey26__;!!HrbR-XT-OQ!XumveqRmJfrjwprMxk0kG4-Jv_EppH8lAmnqhVtsc20r9p_H2FvbU5Pe0-xPpsgBwn4HI428HQ2E86-byVKdnk6YoQ$
Another question:
The spreadshseet specifies that MONDO:0010011 schizencephaly should be a child of COL4A1-related disorders but I don't see evidence of COL4A1 being involved in this term on the OMIM page: https://omim.org/entry/269160https://urldefense.com/v3/__https:/omim.org/entry/269160__;!!HrbR-XT-OQ!XumveqRmJfrjwprMxk0kG4-Jv_EppH8lAmnqhVtsc20r9p_H2FvbU5Pe0-xPpsgBwn4HI428HQ2E86-byVILLMK4OQ$
Is this a mistake or if not, could you please provide evidence of that?
Thank you!
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/monarch-initiative/mondo/issues/6882*issuecomment-1856410249__;Iw!!HrbR-XT-OQ!XumveqRmJfrjwprMxk0kG4-Jv_EppH8lAmnqhVtsc20r9p_H2FvbU5Pe0-xPpsgBwn4HI428HQ2E86-byVLKtHM8tw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AUGOWL5A5QMD2BTXGYUAFYTYJNDQBAVCNFSM6AAAAAA7PYLDEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGQYTAMRUHE__;!!HrbR-XT-OQ!XumveqRmJfrjwprMxk0kG4-Jv_EppH8lAmnqhVtsc20r9p_H2FvbU5Pe0-xPpsgBwn4HI428HQ2E86-byVKFWQt1SA$.
You are receiving this because you were mentioned.Message ID: @.***>

Hi, Thank you for your enquiry re the inclusion of MONDO:0009974 'familial hemophagocytic lymphohistiocytosis type 1' to be a child of FHL1-related myopathy. We reviewed our request and agree that this is not a suitable child term for FHL1-related myopathy so would ike to revise our request and remove this term. The edited child terms for FHL1-related myopathy are now suggested as: - X-linked myopathy with postural muscle atrophy - myopathy, reducing body, X-linked, childhood-onset - myopathy, reducing body, X-linked, early-onset, severe - Uruguay Faciocardiomusculoskeletal syndrome - X-linked scapuloperoneal muscular dystrophy - X-linked Emery-Dreifuss muscular dystrophy MONDO:0010401|MONDO:0010415|MONDO:0010414|MONDO:0010292|MONDO:0010400|MONDO:0010680 Many thanks for your help, Best wishes, Alison

Hi @acoffey26
According to OMIM, the gene EMD is implicated in 'X-linked Emery-Dreifuss muscular dystrophy'. Only this class ('X-linked myopathy with postural muscle atrophy') is stated to have an FHL1 variation.

I added MONDO:0018829 'familial schizencephaly' as a child of 'COL4A1-related disorder'

I revised 'COL4A1-related disorder' to be a child of 'hereditary disease' and removed the parent 'vascular disorder' because the vascular phenotypes seem to be only a component of this disease and not every child term is a vascular disorder. This was causing 'familial schizencephaly' to be incorrectly inferred as a child of 'neurovascular disorder'.

If this is closed and there are still changes needed, please feel free to reopen this ticket, thanks!


architect-orb push-to-registries should allow building image using private base image

Team @giantswarm/team-tinkerers is trying to use push-to-registries to create a container image based on a private one on Quay here.
Since the authentication against Quay is only happening just before the docker push command, this fails.

fixed in architect-orb v4.37.0


ONLY 1.9 can join.

**### What is the output link of /viaversion dump?
http://hastebin.com/ocebatadim.json
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
BungeeCord version git:BungeeCord-Bootstrap:1.10-SNAPSHOT:18f57f2:1195 by md_5
(Latest)
CraftBukkit version git-Spigot-7d15d07-c194444 (MC: 1.9) (Implementing API version 1.9-SNAPSHOT)
I tested this with only ViaVersion installed, and it still didn't work, so, not an issue with any plugins.
How does this error happen? login? Using an item?
Triggered on login.
Is there an error in the console? Use pastebin.com. Is there a kick message?
Console.
Internal Exception: java.io.IOException: An established connection was aborted by the software in your host machine
Kick message.
Internal Exception: io.netty.handler.codec.DecoderExeption: java.IOException: Packet 0/32 (SPacketChunkData) was larger than I expected, found 61440 bytes extra whilst reading packet 32.

ViaVersion isn't compatible with CraftBukkit 1.9 (all the other ones seem to work from what we've tested) at this point in time.
Consider using proper Spigot / CB 1.9.1.


Fix heartbeat typo

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description

Issue reference

@Jarema it looks like the PR contains a bunch of other changes, even from v1.10... do you mind reopening this PR with just your typo update?

@Jarema friendly bump

Closing in favor of #3082


rowDoubleClicked event

can we add this event? for now I'm using cellDoubleClicked, but seems to me like a better choice would be rowDoubleClicked
Thanks!

sounds fair. i'll get this in.


Make it harder to delete a project

It's currently really easy to accidentally delete a project. We should have a confirm dialog or an undo option.

@philwebb
Can i take up this issue.

@philwebb / @bclozel
Can i take up this issue.


Allow users to update scheme params

#89

I made the SchemeStep take full use of the new SchemeConfig type. However, it is still a lot more work to do in the PR.

Take full use of the SchemeConfig in the rest of the app
Update the state so that the votingMachineConifg is only present under SchemeConfig.params.votingMachineConfig
getCallableParamsArray should take a SchemeConfig and votingMachineCallableParamsArray (or something similar)
++

So we are setting the schemeTypeName inside of schemeConfig? I thought you wanted to keep those things separate?

So we are setting the schemeTypeName inside of schemeConfig? I thought you wanted to keep those things separate?

My thought was that it would be nice to do it the same way as the VotingMachineConfig. Therefore I thought that a Config was a combination of typeName and params.
Do you think we should do it another way?

So we are setting the schemeTypeName inside of schemeConfig? I thought you wanted to keep those things separate?

My thought was that it would be nice to do it the same way as the VotingMachineConfig. Therefore I thought that a Config was a combination of typeName and params.
Do you think we should do it another way?

No not at all, just was confused by the comment issue :P

No not at all, just was confused by the comment issue :P

Sorry about that 😛
Please, just say so when I am being unclear 😉

@sogasg gonna rebase before merge if that's alright


[BUG] - Unable to pick GE DICOM through GUI - CreateOspreyJob - Jon Hauksson

Describe the bug
It is currently not possible to correctly pick GE DICOM T1 images through the job file creator.
Additional context
MRSHub post (https://forum.mrshub.org/t/niftii-vs-dicom/1235)

Solved in #582


pfe-navigation line-height bug

Description of the issue

class="pfe-navigation__main--menu-label" has a different line-height then the words in the class=pfe-navigation__utility. This causes the mobile menu icon to sit lower when comparing it to the globe, search, user and 3x3-grid icons.

Word Menu has computed line-height: 13.2px
Word English has computed line-height: 18px

Impacted component(s)

pfe-navigation

Steps to reproduce

Go to 'https://www.redhat.com/en'
View the homepage at a screensize at 700px so you see the mobile menu icon
Inspect the word Menu
See the computed line-height being applied on pfe-navigation__main--menu-label
Inspect the word English
See the computed line-height being applied on pfe-navigation-item [slot=trigger]
Visually see how the mobile icon is sitting lower than the other 4 icons.

Expected behavior
pfe-navigation__main--menu-label line height should match the line height of pfe-navigation-item [slot=trigger]. When it has the same line-height the mobile menu icon will sit at the same line as the globe, search, user and 3x3-grid icons.
Screenshots of showing bug

Screenshots with line height changed inline

Implementation notes:
The pfe-nav items have 3 declarations for line height, but the mobile menu text does not get the 3rd one because its not slotted, (it's provided in an attribute pfe-menu-label="Menu").

Globe icon, line height of 1.3

Menu Icon, gets line height of 1:1


chore: project addition by @Harshu467 #1384

Related Issue

@Harshu467
#1334
Description

Screenshots

Checklist for projects addition

[x] My project has contribution guidelines.
[x] My project has a Code of Conduct.
[x] My project has a README file.
[x] My project has a License.

Ready to Merge

you have added projects before so you don't need to add full code check the docs

There were conflicts on that PR and henced I closed that PR and created nedw one , please check and merge.

I am facing conflicts because my pr not merge early and other pr added which cause this conflicts as in project.json my data is added in last but because u merge other PR it takes that place and I am facing this conficts evrytime . IT is request from my side please merge it and check it

I am resolving it

I have resolved the conflicts, Please merge it as soon as possible

@priyankarpal  Please Add labels of GSOC and level 1, I did not got points on GSOC leaderboard


fix(fastify-vite): file path formats on Windows

close #132
Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

LGTM, thank you!


Update Contributors.html

Problem
-On hover Box-Item grows in size now
Solution
-transform property added to box-item on hover
Changes proposed in this Pull Request :

1.transform property added to box-item on hover
2.on hover color of the contributors name changes to navy
..

Other changes

i want to work on this issue @herambchaudhari4121 , assign it to me


When will the changes for Click Once be available

The changes for Clickonce signing are not yet available because the latest version is still v0.4.0 and these changes require v0.5.0.
When will these changes be available?

I copied and ran this instead from my own repository on my own self-hosted runner in the meantime.  I had to fiddle around with the location of the sign cli tool but otherwise I got it to succesfully sign a .vsto file.

@GeetarmanAgilico Available now. What changes did you have to implement to get it working?

OK thanks.  It was just a pathing issue to the sign cli tool thats all...  I just ended up copying it to the location it was looking for it in.


Stats weight outputs negative values on Intellect and MP5 - Shadow Priest

Describe the bug
I chose Shadow Priest P1 Preset and used stats weight feature, then negative values displayed on Intellect and MP5, which is confused for me.
To Reproduce
Steps to reproduce the behavior:

Chose Shadow Priest.
Chose P1 Preset.
Modify 'Settings' as the pic below.
Click on 'Stat Weight'.
Click on 'Calculate' on the popped out window.
See bug.

Expected behavior
Intellect and MP5 maybe no benefit for short duration battle, so their weights are supposed to be 0 but not be negative.
(Intellect provides spell crit, so it must be positive.)
Sim Links and Screenshots
Sim Settings

Sim Result

Desktop (please complete the following information):

OS: [Windows]
Browser [Chrome]
Version [106.0.5249.119 (64bit)]

I recently made some updates to the EP calculation which should hopefully fix the most eggregious cases like this one. Note that it is possible to get negative values due to natural variance, but it should be a lot better now.


ubuntu xenial just a blank screen

Please paste the output of the following command here: sudo edit-chroot -all
chronos@localhost / $ sudo edit-chroot -all
name: xenial_main
encrypted: yes, locked
Unmounting /mnt/stateful_partition/crouton/chroots/xenial_main...
chronos@localhost / $

Please describe your issue:
when starting the chroot it just brings up a blank screen. It has the colourful background but no icons, launcher etc. all you can do is move the mouse and return to chrome os. non of the ubuntu shortcuts do anything. the only way to close it is to unmount it from chrome os. Literally nothing can be done on it other than move the mouse around a colourful background
this is what the terminal says when I startunity
crosh> shell
chronos@localhost / $ sudo startunity
Password:
Enter encryption passphrase for xenial_main:
Entering /mnt/stateful_partition/crouton/chroots/xenial_main...
Unknown username "geoclue" in message bus configuration file
_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root
X.Org X Server 1.18.4
Release Date: 2016-07-19
X Protocol Version 11, Revision 0
Build Operating System: Linux 4.4.0-97-generic x86_64 Ubuntu
Current Operating System: Linux localhost 4.4.118-13211-geca7e0a1e0d8 #1 SMP PREEMPT Tue Apr 24 23:43:38 PDT 2018 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 4710400 verity payload=PARTUUID=5a767cd7-c99a-a944-bd5f-a5b81a98cd8b/PARTNROFF=1 hashtree=PARTUUID=5a767cd7-c99a-a944-bd5f-a5b81a98cd8b/PARTNROFF=1 hashstart=4710400 alg=sha1 root_hexdigest=ff5b397aeda09a7955be63042423bf06e3610630 salt=894aeef508251d7b979ed46e01e1cc3fd5419b7a4d6d0bfb578f58e72837c0a6" noinitrd vt.global_cursor_default=0 kern_guid=5a767cd7-c99a-a944-bd5f-a5b81a98cd8b add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic disablevmx=off
Build Date: 13 October 2017  01:57:05PM
xorg-server 2:1.18.4-0ubuntu0.7 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.33.6
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Sat May  5 12:46:54 2018
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Error org.freedesktop.DBus.Error.UnknownMethod: Method "ReleaseDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist
xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)
Error executing command as another user: Not authorized
This incident has been reported.
crouton: version 1-20180329190032~master:d287904a
release: xenial
architecture: amd64
xmethod: xorg
targets: unity,touch
host: version 10452.74.0 (Official Build) stable-channel eve
kernel: Linux localhost 4.4.118-13211-geca7e0a1e0d8 #1 SMP PREEMPT Tue Apr 24 23:43:38 PDT 2018 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
xrandr: Output eDP1 is not disconnected but has no modes
xrandr: Output DP1 is not disconnected but has no modes
xrandr: Output DP2 is not disconnected but has no modes
Kicking xrandr again
xrandr: Output eDP1 is not disconnected but has no modes
xrandr: Output DP1 is not disconnected but has no modes
xrandr: Output DP2 is not disconnected but has no modes
Kicking xrandr again
(EE) BUG: triggered 'if (priv->num_active_touches == 0)'
(EE) BUG: ../../src/synaptics.c:2966 in UpdateTouchState()
(EE)
(EE) Backtrace:
(EE) 0: /usr/lib/xorg/Xorg (xorg_backtrace+0x4e) [0x57cee65c66ce]
(EE) 1: /usr/lib/xorg/modules/input/synaptics_drv.so (0x7fb20000f000+0x5b9c) [0x7fb200014b9c]
(EE) 2: /usr/lib/xorg/modules/input/synaptics_drv.so (0x7fb20000f000+0x7682) [0x7fb200016682]
(EE) 3: /usr/lib/xorg/Xorg (0x57cee6414000+0x94268) [0x57cee64a8268]
(EE) 4: /usr/lib/xorg/Xorg (0x57cee6414000+0xb9652) [0x57cee64cd652]
(EE) 5: /lib/x86_64-linux-gnu/libc.so.6 (0x7fb207419000+0x354b0) [0x7fb20744e4b0]
(EE) 6: /lib/x86_64-linux-gnu/libc.so.6 (__select+0x33) [0x7fb2075165d3]
(EE) 7: /usr/lib/xorg/Xorg (WaitForSomething+0x1d7) [0x57cee65c33f7]
(EE) 8: /usr/lib/xorg/Xorg (0x57cee6414000+0x53bce) [0x57cee6467bce]
(EE) 9: /usr/lib/xorg/Xorg (0x57cee6414000+0x57e13) [0x57cee646be13]
(EE) 10: /lib/x86_64-linux-gnu/libc.so.6 (__libc_start_main+0xf0) [0x7fb207439830]
(EE) 11: /usr/lib/xorg/Xorg (_start+0x29) [0x57cee6456069]
(EE)
(II) AIGLX: Suspending AIGLX clients for VT switch
Error org.freedesktop.DBus.Error.UnknownMethod: Method "TakeDisplayOwnership" with signature "" on interface "org.chromium.LibCrosServiceInterface" doesn't exist
If known, describe the steps to reproduce the issue:
I created a chroot in shell with sudo sh ~/Downloads/crouton -t unity,touch -n xenial_main -e
when I did sudo startunity and entered password etc it happened and the only way to close the chroot is to manually unmount it from chrome os terminal
This problem occurs on my pixelbook. i don't know if this is specific to the pixelbook or if it is a problem with crouton
edit: I just created a trusty chroot and that seems to be working fine so it's definitely something to do with xenial

same issue here...

Same issue here

I have this issue on a gen1 Thinkpad Yoga 11e Chromebook.

same issue here

I got it working by doing this:
sudo enter-chroot -n (name of my chroot)
sudo apt-get install compizconfig-settings-manager
ln -s /usr/bin/xterm /home//Desktop/xterm
then exit the chroot and startunity like normal.
then click on the xterm icon to open a shell and enter: ccsm
search for unity in the search box and from there you should see a way to enable unity plugin (on left hand side).

If you have a Chromebook that supports our will support crostini (Linux apps on Chrome OS) then you may be better off using that.


docs(Readme) syntax errors and grammarly suggestions

Thank you for your PR and taking the time to edit!  Unfortunately most of the grammer issues have been marked in a previous PR and I won't merge this one.
Keep watching out for future mistakes - I gladly accept corrections :)

Thank you for your PR and taking the time to edit!  Unfortunately most of the grammer issues have been marked in a previous PR and I won't merge this one.
Keep watching out for future mistakes - I gladly accept corrections :)


Changing bit precision (truncation bits)

Hi,
I am currently trying to modify the sycret code in order to enable it on the truncated value,
i.e. generating keys with smaller alpha (and less bits) -> keys will be shorter -> evaluation will take less step
I have passed the test for rust code with a theoretical error probability.
However, when I try to test it with python, i.e. enable the stream parallelism then I could not passed the test because most of them are error.
I think there is something wrong with the stream part, but I didn't see anything I can do.
Do you have any idea that which part might be the problem¿
Thank you a lot!
@tholop

Thanks for your interest!

What is the new number of bits? I guess that N=2 can make sense for the byte precision, but make sure to stay consistent if you start working in Z_{2^16}
For the issue with Python, it's hard to tell but you should check that you are allocating memory properly with Numpy, and converting back to the proper type (maybe np.int32 if you are using N=2?)
Finally, the stream parallelism actually happens in Rust, not Python. So you might want to double-check your casting and raw pointers here for instance: https://github.com/OpenMined/sycret/blob/6f745306fb7771a88981b1b61645029097a41174/src/stream.rs#L79 Maybe it's worth writing Rust tests for these stream functions too

Originally we wanted to have a generic N, but as you can see some functions (especially the memory wrappers) are implicitly hardcoding N=4. This is because we didn't have any reason to use a lower precision so we went with the most efficient implementation (e.g. we can use u32 directly instead of working with vectors or arrays)

Thank you for your reply!
I was trying to lower the bit by generating keys from a truncated alpha value , i.e. which alpha can be presented in a small ring exactly (maybe Z_{2^27} for example), so that the size of the key can be reduced because the number of CW, CW_leaf is connected with the bit number. Similarly, the evaluation step will be reduced as well because of the reduction of the bit number.
In my specific implementation, I have changed the KeyLen from 32 to a smaller number.
To my best knowledge, the change mentioned above should be theoretically reasonable, so the error is weird to me……

Thanks for your interest!

What is the new number of bits? I guess that N=2 can make sense for the byte precision, but make sure to stay consistent if you start working in Z_{2^16}
For the issue with Python, it's hard to tell but you should check that you are allocating memory properly with Numpy, and converting back to the proper type (maybe np.int32 if you are using N=2?)
Finally, the stream parallelism actually happens in Rust, not Python. So you might want to double-check your casting and raw pointers here for instance: https://github.com/OpenMined/sycret/blob/6f745306fb7771a88981b1b61645029097a41174/src/stream.rs#L79
Maybe it's worth writing Rust tests for these stream functions too

Originally we wanted to have a generic N, but as you can see some functions (especially the memory wrappers) are implicitly hardcoding N=4. This is because we didn't have any reason to use a lower precision so we went with the most efficient implementation (e.g. we can use u32 directly instead of working with vectors or arrays)

Thank you for your reply!
I was trying to lower the bit by generating keys from a truncated alpha value , i.e. which alpha can be presented in a small ring exactly (maybe Z_{2^27} for example), so that the size of the key can be reduced because the number of CW, CW_leaf is connected with the bit number. Similarly, the evaluation step will be reduced as well because of the reduction of the bit number.
In my specific implementation, I have changed the KeyLen from 32 to a smaller number.
To my best knowledge, the change mentioned above should be theoretically reasonable, so the error is weird to me……

Yes, it is theoretically reasonable, but in practice our current implementation works with byte-level operations. So to make it work with 27 bits you will need to change more things than just the value of KeyLen -- basically rewrite the core functions, for instance with bit arrays instead of byte arrays and u32 outputs.
If you have a working prototype at some point feel free to open a pull request! I would be happy to have a look at your code and maybe merge it as an experimental feature for people who want to change the bit length.


Change follow_group at runtime error

Issue description
Hi, since I'm adding units to my scene in script, I have to append theese units to the PhantomCamera3D follow_group property. I'm using append_follow_group_node with a reference to the unit in question but when I debug I see that the follow_group property haven't changed and is still empty.
I've also tried to directly modify the property with an Array[NodePath] but i got an error Invalid set index 'follow_group' (on base: 'Node3D (PhantomCamera3D)') with value of type 'Array[NodePath]'.
Have a nice day,
Steps to reproduce
Open 3DFollowGroupExampleScene
Modify follow_group in script
(Optional) Minimal reproduction project
No response

This sounds similar to #119, does replacing the attached script in the comment in there solve the issue?

It does not, but maybe is there something I'm missing ? Here's the minimal reproduction project.
camera_error_reproduction.zip

I can see the issue.
It looks like you're trying to fetch the follow group nodes using $PhantomCamera3D.follow_group, which isn't a property that exists, and why you're getting that error.
What you can do instead is call the getter method $PhantomCamera3D.get_follow_group_nodes(). That will return the nodes as they get instantiated.

Thanks you for your help !

Can't directly access properties.


Play without Region or Server

There seems to be an issue not present in the standard game.  When starting out it is possible to press play without selecting a region or entering ip:port.  Doing so will remove the the menu and present a blank grid.
You can still use "esc" to enter the menu and continue playing as normal.

this will likely be the next bug i fix.

resolved, sorry about the delay in the fix uronsai.


New command graph has wrong parameter documentation (+ potential anomaly when running in monorepo)

Describe the bug
Let me start by saying thank you for the great value and improvements you provide to the community with terragrunt!
My first remark is that the documentation for the new command terragrunt graph <command> states --graph-root as a parameter for the root (by default the git root dir), but it should be --terragrunt-graph-root.
My second remark is that I encountered a weird phenomenon within my monorepo where I have in the git-root three completely decoupled environment directories: terragrunt graph plan escaped my current env-directory and travesed into another env-directory.
Steps To Reproduce
For the first remark:
terragrunt graph plan --graph-root foo/bar/path
ERRO[0000] flag provided but not defined: -graph-root
ERRO[0000] Unable to determine underlying exit code, so Terragrunt will exit with error code 1

For the second remark:
In my git root directory I have no terragrunt.hcl. For each environment dev, test, and prod, I have a dedicated directory, each with a root terragrunt.hcl.
When inside a deep directory dir-1 within dev which depends on another dir-2 inside dev and this dir-2 is refering a local file next to its own terragrunt.hcl using get_terragrunt_dir(), e.g., a SOPS encrypted secret like this:
locals {
  secret_values = yamldecode(sops_decrypt_file("${get_terragrunt_dir()}/secrets.yaml"))
}

then terragrunt ended up in test trying to fetch the secrets.yaml found inside test environment.
When I run with
terragrunt graph plan --terragrunt-graph-root <PATH TO DEV-DIR>

then this anomaly does not happen.
Expected behavior
For my first remark:
Either the documentation is updated or the command accepts the key specified at the moment in the documentation.
For my second remark:
Running terragrunt graph plan in a mono-repo containing several envs should not attempt to touch files in a neighbouring environment directory.
Nice to haves
For my first remark:

Documentation: https://terragrunt.gruntwork.io/docs/reference/cli-options/#graph
CLI help output: terragrunt-graph-root
What the code does: https://github.com/gruntwork-io/terragrunt/blob/e0c5cbe815914aea348ff6d6fb0cf936c687e982/cli/commands/graph/command.go#L27

For my second remark:
I might try creating a hello-world example but lack time right now (also to rule out any other anomalies due to my setup). Till then I was hoping that some experienced person could tell me if this is a false-positive and terragrunt graph is meant to behave like that.
Versions

Terragrunt version: v0.66.3
OpenTofu/Terraform version: v1.9.4
Environment details (Ubuntu 20.04, Windows 10, etc.): darwin_arm64

Additional context
n/a

The graph command seems to be broken, or at least not working with most setups, at the moment. There are many open issues already on this topic.

Thanks for the hint!
Regarding my second remark in this issue, I might implement my own alternative to have a similar look-and-feel: Invoke terragrunt graph-dependencies on the root terragrunt.hcl, then use the digraph to detect all northbound dependencies to my current directory, e.g., dir-1 in my example should have its its dependency dir-2 --> dir-1 visible in the root level digraph. --- Just a random idea, but sounds easy to implement as a custom/home-grown workaround.
PS: I noticed another issue I have no clue how to invoke the terraform command terraform graph via terragrunt now. I will check if an open issue exists and otherwise create a new one.


Improving SBT API

Hi guys.
I want you to check out these changes.
SBT now is more complex but allows you to relate better betwen shader stages and shader groups and ask for any SBT configuration.
I added more features (which I've been working on for a few weeks) to the MPM sample.
Let me know if some changes are needed.

Hi Gabe!
The thing is that the ray tracing pipeline drivers need to be copied to a host buffer and passed as arguments to the vkCmdTraceRays call to link them to the pipeline itself. This is better explained in the following link:

SBT handles
This functionality is quite complex and this is the best way I could think of for the user to have all the group handlers at their disposal since they are ordered according to the following requirements:

I'm sure you can expose all this logic to the user, but you have to take into account all these details, such as aligning the handlers to memory. If you can think of a better way to deal with this problem I'm open to improvements of course.

This does not explain why there are multiple buffers. Also, the buffer that contains the shader handles absolutely should not be a host buffer as it currently is. Either way, though, there should only be a SINGLE buffer created, with the function just returning the single buffer and the strided device address regions.
Note: the API has this, where there is both a buffer output in the function signature, but also a buffer output within the entries struct which is also a result of the same function.
typedef struct
{
    daxa_BufferId buffer;
    daxa_SpanToConst(daxa_GroupRegionInfo) group_regions;
} daxa_RayTracingShaderBindingTableEntries;

DAXA_EXPORT daxa_Result
daxa_ray_tracing_pipeline_create_sbt(
    daxa_RayTracingPipeline pipeline,
    daxa_RayTracingShaderBindingTableEntries * out_sbts, daxa_BufferId * out_buffer,
    daxa_BuildShaderBindingTableInfo const * info);

this appears to be a copy+paste error and I would like you to completely review the changes you've made because it does not seem complete or tested.
It appears that the buffer is created twice with the same size (but computed completely differently)
    // Allocate a buffer for storing the SBT.
    auto sbt_info = daxa_BufferInfo{
        .size = current_offset,
        .allocate_info = DAXA_MEMORY_FLAG_HOST_ACCESS_SEQUENTIAL_WRITE,
        .name = std::bit_cast<daxa_SmallString>(name_cstr),
    };
    // NOTE: it is responsibility of the user to destroy the buffer
    auto & sbt_buffer_id = *out_buffer;
    auto const create_buffer_result = daxa_dvc_create_buffer(device, &sbt_info, r_cast<daxa_BufferId *>(&sbt_buffer_id));

    /// LATER, in the same function...

    // Allocate a buffer for storing the SBT.
    auto sbt_handler_info = daxa_BufferInfo{
        .size = sbt_handle_size,
        .allocate_info = DAXA_MEMORY_FLAG_HOST_ACCESS_RANDOM,
        .name = std::bit_cast<daxa_SmallString>(name_handle_cstr),
    };

     auto handle_result = daxa_dvc_create_buffer(device, &sbt_handler_info, r_cast<daxa_BufferId *>(&out_entries->buffer));

Hi again @GabeRundlett,
I am gonna try to explain better and then I can improve the API, and then I can make it easier to work with.
RT pipeline needs to keep alive at least two buffers to work properly:

for shader handlers.
for groups to push them into the SBT (this second buffer depends on the first one's handlers).

The problem that I see is that depending on your requested groups, you need a subset of handlers or maybe all of them. Thus, somethings can go wrong if user doesn't do the right thing. Image I split the logic in two:

You ask for shader handlers: handler buffer returned.
You request to build some groups from the provided handlers (previously requested): group handler buffer returned.

What if handlers doesn't match group needs? If you ask for groups which need handlers not provided to the function?
Therefore, there's another option that I came to my mind. Handlers live during ray tracing pipeline's life-cycle and user doesn't need to manage them at all. Then you can ask for as many set of group as you want.
There's also another option which is not implemented right now and it's compatible with all of them. User can be able to provide a buffer to copy groups into it and thus, you can "recycle" it for many set of groups.
If you can think of anything else, you can share it and we can discuss it. I really want to push this forward.
Thank you,
Jaime.


Clean up / optimize makefile, sandbox builds better.

removed a bunch of cruft from overly-generic makefile copypasta
(many of it doesn't do anything here, and makes it harder to read).
much of this does more work than is necessary (e.g. go get and
thrift-gen happens on every make test).
don't use the global thriftrw + plugin, or install globally, just
build and use a local version from the vendored code.

It still does more than is necessary, but I haven't found a quick way
to make "always re-gen copyright" both reliable and efficient, so it's
currently unavoidable.
If you remove thriftc and copyright from test though, you can see
how e.g. make cover just prints the previous run if no source changed,
which would be ideal (and make test still forces a rerun, intentionally).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Groxx:x: mfateevYou have signed the CLA already but the status is still pending? Let us recheck it.

Unfortunately I can't seem to get glide to always include the thriftrw dependencies :|  There doesn't appear to be any supported way, and a couple of my attempts at tricking it didn't seem to work.
I know how to do this in dep though.  Any interest in upgrading?  I'd be happy to migrate and help you understand the differences (they're minor.  mostly dep == glide, but smarter)

I'll just toss this and start a new pull from scratch once travis is happy with it - there have been somewhat substantial changes.

think I've got it, but it looks like there's a bad glide cache on travis:
[WARN]	Unable to checkout github.com/apache/thrift
[ERROR]	Update failed for github.com/apache/thrift: Unable to get repository: Cloning into '/home/travis/.glide/cache/src/git-git.apache.org-thrift.git'...
fatal: remote error: access denied or repository not exported: /thrift.git
: exit status 128
[INFO]	--> Fetching go.uber.org/net/metrics
[INFO]	--> Fetching go.uber.org/thriftrw
[INFO]	--> Fetching go.uber.org/zap
[INFO]	--> Fetching golang.org/x/net
[INFO]	--> Fetching golang.org/x/sys
[INFO]	--> Fetching golang.org/x/text
[INFO]	--> Fetching golang.org/x/tools
[INFO]	--> Fetching google.golang.org/genproto
[INFO]	--> Fetching google.golang.org/grpc
[INFO]	--> Fetching gopkg.in/yaml.v2
[ERROR]	Failed to install: Unable to get repository: Cloning into '/home/travis/.glide/cache/src/git-git.apache.org-thrift.git'...
fatal: remote error: access denied or repository not exported: /thrift.git
: exit status 128
make: *** [.build/thriftrw-plugin-yarpc] Error 1
The command "make cover_ci" exited with 2.

the git-git.apache.org-thrift.git repo doesn't exist any more, I don't know why it'd be inferring that as the current "source" unless it's a bad cache or something.

and now it's stuck on a 1.9 -> 1.10 change.  1.9 apparently can't do coverage of multiple packages, 1.10 can.  which would be great because it GREATLY simplifies and speeds up running tests.
but I think it's working!  I can version goveralls too if anyone thinks it'd be worthwhile.

Nice.  Finally works.  Thanks for upgrading Go, @arthurguber !
I'll clean up history a bit and open a new request, IMO this one is a bit too changed from the original to make the approval valid :)