:PluginUpdate fails when running from a fish shell

I'm trying out the latest Vundle (downloaded and installed according to these instructions just a couple days ago).

vim instances: Vim 8.0 and NeoVim 0.2.0
terminal apps: Terminology 0.9.99 and GNOME Terminal 3.22.1
shell language: fish 2.3.1
OS: Fedora 25 Workstation x86_64 (Linux)

I only configured and installed one other plugin --- EditorConfig. The :PluginInstall command seemed to work without issue, but :PluginUpdate has trouble when (Neo)Vim is invoked from fish (as opposed to bash).
Which terminal I used doesn't seem to make a difference. Vim and NeoVim both produced errors, but slightly different errors...
Plain Vim in fish flashes this on screen for a second ---

--- but then Vundle's progress window pane seems to proceed normally.
NeoVim in fish produces more verbose errors. Here's the log (from hitting l after :PluginUpdate runs).
[2017-06-13 19:29:27] Plugin URI change detected for Plugin Vundle.vim
[2017-06-13 19:29:27] >  Plugin Vundle.vim old URI: Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
[2017-06-13 19:29:27] fish: cd '/home/terrycloth/.vim/bundle/Vundle.vim' && git config --get remote.origin.url
[2017-06-13 19:29:27]                                                     ^
[2017-06-13 19:29:27] >  Plugin Vundle.vim new URI: https://github.com/VundleVim/Vundle.vim.git
[2017-06-13 19:29:27]
[2017-06-13 19:29:27] Plugin VundleVim/Vundle.vim
[2017-06-13 19:29:27] $ cd '/home/terrycloth/.vim/bundle/Vundle.vim' && git remote set-url origin 'https://github.com/VundleVim/Vundle.vim.git' && git fetch && git reset --hard origin/HEAD && git submodule update --init --recursive
[2017-06-13 19:29:27] > Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
[2017-06-13 19:29:27] > fish: cd '/home/terrycloth/.vim/bundle/Vundle.vim' && git remote set-url origin 'https://github.com/VundleVim/Vundle.vim.git' && git fetch && git reset --hard origin/HEAD && git submodule update --init --recursive
[2017-06-13 19:29:27] >                                                     ^
[2017-06-13 19:29:27] >
[2017-06-13 19:29:28] Plugin URI change detected for Plugin editorconfig-vim
[2017-06-13 19:29:28] >  Plugin editorconfig-vim old URI: Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
[2017-06-13 19:29:28] fish: cd '/home/terrycloth/.vim/bundle/editorconfig-vim' && git config --get remote.origin.url
[2017-06-13 19:29:28]                                                           ^
[2017-06-13 19:29:28] >  Plugin editorconfig-vim new URI: https://github.com/editorconfig/editorconfig-vim.git
[2017-06-13 19:29:28]
[2017-06-13 19:29:28] Plugin editorconfig/editorconfig-vim
[2017-06-13 19:29:28] $ cd '/home/terrycloth/.vim/bundle/editorconfig-vim' && git remote set-url origin 'https://github.com/editorconfig/editorconfig-vim.git' && git fetch && git reset --hard origin/HEAD && git submodule update --init --recursive
[2017-06-13 19:29:28] > Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
[2017-06-13 19:29:28] > fish: cd '/home/terrycloth/.vim/bundle/editorconfig-vim' && git remote set-url origin 'https://github.com/editorconfig/editorconfig-vim.git' && git fetch && git reset --hard origin/HEAD && git submodule update --init --recursive
[2017-06-13 19:29:28] >                                                           ^
[2017-06-13 19:29:28] >
[2017-06-13 19:29:29]
[2017-06-13 19:29:29] Helptags:
[2017-06-13 19:29:29] :helptags /home/terrycloth/.vim/bundle/Vundle.vim/doc
[2017-06-13 19:29:29] :helptags /home/terrycloth/.vim/bundle/editorconfig-vim/doc
[2017-06-13 19:29:29] Helptags: 2 plugins processed

If Vundle is doing shell commands under the hood, then you might want to make sure it's always actually using bash, because while alternative shells like zsh and fish are mostly compatible with bash, their syntax is not identical...

See I don't use a POSIX Shell (i.e. Bash/Sh) wiki entry.

Oh, yes, that fixes it. Sorry I didn't notice that wiki page before. Thanks!

Great 😄

Hello! I'm sorry to resurrect a closed commit, but this issue currently trends high when searching for why a fish config with (neo)vim and Vundle are slow. The link provided above by vimishor does indeed contain a fix for me (in .vimrc, set shell=bash), however it also suggests fixing the issue by writing a function to execute the update command properly.
It is insufficient to use the fish command suggested in that article. Doing so will fix the error when executing :PluginUpdate, yes, but it will leave your vim instance very sluggish as it generates errors while trying to handle the broken environment. What's worse is that these errors seem to be effectively swallowed, at least in my setup, to the point of requiring trial-and-error to fix.
Hopefully this helps someone else not lose an afternoon to figuring out 'why is my vim so slow these days, anyway?' (For the record, switching buffers was taking 5-6 seconds. It did seem to slowly creep to that level of latency, so I wonder if there's some logfile it's appending to and re-scanning on each error.)


T265 Stops Working When Streaming Starts

librealsense
2.37.0 RELEASE

OS
Ubuntu 16.04.7

Name
Intel RealSense T265

Serial Number
15322110183

Firmware Version
<IP_ADDRESS>1

Usb Type Descriptor
3.1

Product Line
T200

I have been trying to get the T265 tracking camera working with no success. Whenever I start the device, it always gives me similar errors to the log below. Could this possibly be a problem with the device? If so, any idea what is going on?
I have tested this on Realsesnse Viewer and ROS, Windows and Linux, v2.38.1 and v2.37.0, prebuilt and built from source, and both my laptop and desktop. They all have similar issues.
For the data below, I used 2.37.0 built from source. with the CMake options -DCMAKE_BUILD_TYPE=Release -DBUILD_EXAMPLES=true -BUILD_WITH_TM2=ON

00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:507 - Added a gyro sensor id: 0 at 200Hz
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:507 - Added a accel sensor id: 0 at 62Hz
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:510 - Skipped a velocimeter stream
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:510 - Skipped a velocimeter stream
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/rs.cpp:2535 - Framebuffer size changed to 1855 x 1056
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/rs.cpp:2535 - Window size changed to 1855 x 1056
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/rs.cpp:2535 - Scale Factor is now 1
00:43:05 [Info]  - Intel RealSense T265 was selected as a default device
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-info.cpp:53 - Picked 1/29 devices
00:43:05 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/context.cpp:365 - Found 1 RealSense devices (mask 255)
00:43:10 [Info]  - Starting streaming of Fisheye, Fisheye, Gyro, Accel, Pose...
00:43:10 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:600 - Request for stream type 4 with stream index 1
00:43:10 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:600 - Request for stream type 4 with stream index 2
00:43:10 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:600 - Request for stream type 5 with stream index 0
00:43:10 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:600 - Request for stream type 6 with stream index 0
00:43:10 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:600 - Request for stream type 8 with stream index 0
00:43:10 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:645 - Activated 5/5 streams
00:43:11 [Warn] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/libusb/messenger-libusb.cpp:66 - bulk_transfer returned error, endpoint: 0x2, error: Success, err. num: 0
00:43:11 [Error] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:2036 - Bulk request error RS2_USB_STATUS_IO
00:43:11 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:1437 - Got bad response, stopping log_poll
00:43:11 [Error] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:1345 - Stream transfer failed, exiting
00:43:11 [Error] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:1263 - Interrupt transfer failed, exiting
00:43:12 [Warn] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/libusb/messenger-libusb.cpp:66 - bulk_transfer returned error, endpoint: 0x2, error: No such device, err. num: 19
00:43:12 [Error] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:2036 - Bulk request error RS2_USB_STATUS_NO_DEVICE
00:43:12 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:1453 - Got bad response, stopping time sync
00:43:15 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/rsusb-backend/../tm2/tm-boot.h:22 - Found a T265 to boot
00:43:17 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-info.cpp:53 - Picked 1/29 devices
00:43:17 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/context.cpp:365 - Found 1 RealSense devices (mask 255)
00:43:17 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-info.cpp:53 - Picked 1/29 devices
00:43:17 [Info] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/context.cpp:365 - Found 1 RealSense devices (mask 255)
00:43:32 [Info]  - Stopping streaming
00:43:32 [Warn] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/libusb/messenger-libusb.cpp:66 - bulk_transfer returned error, endpoint: 0x2, error: No such device, err. num: 19
00:43:32 [Error] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:2036 - Bulk request error RS2_USB_STATUS_NO_DEVICE
00:43:32 [Warn] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/libusb/messenger-libusb.cpp:66 - bulk_transfer returned error, endpoint: 0x2, error: No such device, err. num: 19
00:43:32 [Error] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:2036 - Bulk request error RS2_USB_STATUS_NO_DEVICE
00:43:32 [Warn] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/libusb/messenger-libusb.cpp:66 - bulk_transfer returned error, endpoint: 0x2, error: No such device, err. num: 19
00:43:32 [Error] /tmp/binarydeb/ros-kinetic-librealsense2-2.37.0/src/tm2/tm-device.cpp:2036 - Bulk request error RS2_USB_STATUS_NO_DEVICE

Further info.  I looked at the USB activity using "dmesg -wH".
I connected the device at the with realsense-viewer already open.
Started streaming data at [+11.930934].
This time, I used Ubuntu 20.04 w/ v2.38.1 built from source. Everything else works just fine except the T265 disconnect issue.

[Sep 7 14:54] usb 1-1: new high-speed USB device number 36 using xhci_hcd
[  +0.148606] usb 1-1: New USB device found, idVendor=03e7, idProduct=2150, bcdDevice= 0.01
[  +0.000009] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  +0.000005] usb 1-1: Product: Movidius MA2X5X
[  +0.000005] usb 1-1: Manufacturer: Movidius Ltd.
[  +0.000005] usb 1-1: SerialNumber: 03e72150
[  +0.920621] usb 1-1: USB disconnect, device number 36
[  +0.466910] usb 2-1: new SuperSpeed Gen 1 USB device number 17 using xhci_hcd
[  +0.024718] usb 2-1: New USB device found, idVendor=8087, idProduct=0b37, bcdDevice=ff.ff
[  +0.000007] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  +0.000006] usb 2-1: Product: Intel(R) RealSense(TM) Tracking Camera T265
[  +0.000005] usb 2-1: Manufacturer: Intel(R) Corporation
[  +0.000004] usb 2-1: SerialNumber:<PHONE_NUMBER>3
[ +11.930934] usb 2-1: usbfs: usb_submit_urb returned -19
[  +0.170123] usb 2-1: usbfs: usb_submit_urb returned -19
[  +0.029978] usb 1-1: new high-speed USB device number 37 using xhci_hcd
[  +0.160621] usb 1-1: New USB device found, idVendor=03e7, idProduct=2150, bcdDevice= 0.01
[  +0.000014] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  +0.000005] usb 1-1: Product: Movidius MA2X5X
[  +0.000005] usb 1-1: Manufacturer: Movidius Ltd.
[  +0.000004] usb 1-1: SerialNumber: 03e72150
[  +0.323437] usb 2-1: USB disconnect, device number 17
[  +0.176897] wlp2s0: authenticate with 44:a5:6e:60:b8:99
[  +0.003749] wlp2s0: send auth to 44:a5:6e:60:b8:99 (try 1/3)
[  +0.068551] wlp2s0: authenticate with 44:a5:6e:60:b8:99
[  +0.000013] wlp2s0: send auth to 44:a5:6e:60:b8:99 (try 1/3)
[  +0.011052] wlp2s0: authenticated
[  +0.007673] wlp2s0: associate with 44:a5:6e:60:b8:99 (try 1/3)
[  +0.007279] wlp2s0: RX AssocResp from 44:a5:6e:60:b8:99 (capab=0x1431 status=0 aid=1)
[  +0.000931] wlp2s0: associated
[  +0.027730] wlp2s0: disassociated from 44:a5:6e:60:b8:99 (Reason: 1=UNSPECIFIED)
[  +4.147305] usb 1-1: USB disconnect, device number 37
[  +0.504890] usb 2-1: new SuperSpeed Gen 1 USB device number 18 using xhci_hcd
[  +0.020887] usb 2-1: New USB device found, idVendor=8087, idProduct=0b37, bcdDevice=ff.ff
[  +0.000006] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  +0.000004] usb 2-1: Product: Intel(R) RealSense(TM) Tracking Camera T265
[  +0.000003] usb 2-1: Manufacturer: Intel(R) Corporation
[  +0.000003] usb 2-1: SerialNumber:<PHONE_NUMBER>3
[  +6.369941] wlp2s0: authenticate with 44:a5:6e:60:b8:9b
[  +0.004665] wlp2s0: send auth to 44:a5:6e:60:b8:9b (try 1/3)
[  +0.003243] wlp2s0: authenticated
[  +0.004969] wlp2s0: associate with 44:a5:6e:60:b8:9b (try 1/3)
[  +0.004512] wlp2s0: RX AssocResp from 44:a5:6e:60:b8:9b (capab=0x1511 status=0 aid=2)
[  +0.001518] wlp2s0: associated


Method to force onchange commands to run

In the case of a git.UpToDate operation with an onchange that failed, the only way to rerun the failed onchange is to push another commit to the remote repository.
We should add a feature to mark a certain state operation as force-changed so that the onchange commands are re-run.
Perhaps in addition, track command failures and automatically force-change operations as needed.

Should be a matter of specifying names of operations that should be considered to have changed.


Do not append the element if it is null

If element is null it triggers a js error.  Since element CAN be null it makes sense to test the element value before trying to add it to the DOM.

@ahocevar   Thx I diidn't expect a merge so fast  :smile:   Here is a unit test : https://github.com/openlayers/openlayers/pull/16355/files


Compatibility issues between fluent-plugin-cloudwatch-logs and fluent-plugin-forest

Problem
The issue is that the logs are not being flushed to S3 by the forest plugin. I have verified that the logs are arriving on my local instance by printing them using stdout. Can anyone help regarding what the problem can be?
The strange thing is that, if I remove this configuration, forest plugin normally flushes other logs to S3. But as soon as I add this config and restart td-agent, forest plugin stops flushing logs and td-agent.log is stuck at the following line :
2018-12-19 07:44:14 +0000 [info]: listening fluent socket on <IP_ADDRESS>:24224

Steps to replicate
Below is the config file that I am using (The parts marked with $ are masked for privacy concerns).
<source>
  @type cloudwatch_logs
  format json
  state_file /var/log/td-agent/state/$.msa.lambda.state
  include_time_key true
  time_key time
  time_format %Y-%m-%dT%H:%M:%S.%L%Z
  log_group_name /aws/lambda/$
  log_stream_name 2               #[^:*]*
  use_log_stream_name_prefix true
  region $
  aws_key_id  $
  aws_sec_key  $
  tag $.$.$.msa.lambda.log
</source>

#<match *.*.$.msa.lambda.log>
#  @type stdout
#</match>

<match *.*.$.msa.lambda.log>
  type copy
  deep_copy true

  <store>
    @type forest
    subtype s3
    <template>
     @type s3
     buffer_type file
     buffer_path /tmp/td-agent/buffer/${tag}.buffer_

     buffer_chunk_limit 64m
     buffer_queue_limit 1024
     num_threads 2 # the number of threads to flush the buffer
     <buffer tag_parts>
     flush_at_shutdown true
     </buffer>
     flush_interval 30s # how long will a compressed file generated on S3
     time_format %Y-%m-%dT%H:%M:%S.%L%z
     # AWS Common Config
     s3_region $
     # AWS Credential Config
     aws_key_id $
     aws_sec_key $
     # AWS S3 Config
     s3_bucket $

     s3_object_key_format %{path}%{time_slice}/${tag_parts[3]}/${tag_parts[2]}/%{index}.%{file_extension}
     auto_create_bucket false
     path ${tag_parts[0]}/${tag_parts[1]}/backendlog/lambda/middleware/${tag_parts[4]}.${tag_parts[5]}.${tag_parts[6]}.${tag_parts[7]}
     time_slice_format %Y-%m-%d/%H  #%Y%m%d%H
     format json
     time_key time
     include_time_key true
     tag_key log_source
     include_tag_key true
     utc # timezone
    </template>

  </store>
</match>

Expected Behavior or What you need to ask
Are there any conflicts/dependency issues between the plugins fluent-plugin-cloudwatch-logs and fluent-plugin-forest?
Using Fluentd and CloudWatchLogs plugin versions

OS version - Ubuntu 16.04
Bare Metal
Fluentd v0.12

fluentd : 0.12.29 td-agent : 2.3.6-0

Dependent gem versions

fluent-plugin-cloudwatch-logs (0.4.5) for fetching logs from cloudwatch
fluent-plugin-forest (0.3.0) to send logs to AWS S3
fluentd (0.12.29)

Fluentd v0.12 is already EOL.
If you encountered this issue with Fluentd v1, please feel free to comment on this issue.
Closing.


[FIX] Issue with iOS crash which string value was not handled properly.

In regards to issue #116 .
Wherein NSString was not handled properly for null returns.

👍


0.7.4-rc2 update

Signed-off-by: Stephen Curran<EMAIL_ADDRESS>

Don't ask...

Codecov Report

Merging #1771 (3531b7f) into main (5ecf63b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1771   +/-   ##
=======================================
  Coverage   95.23%   95.23%
=======================================
  Files         525      525
  Lines       33056    33056
=======================================
  Hits        31482    31482
  Misses       1574     1574


chore(deps): bump pandas >=2.0

SUMMARY
In Pandas 2.0 installing the optional but recommended performance dependencies is now possible via pip extras, reference. These deps are also available in 1.5.3 but with the help of pip extras and pip-compile-multi, it should be much cleaner and more obvious as why these deps are installed. I think pandas[performance] should be installed in a separate follow-up PR.
This PR bumps dependency pandas from 1.5.3 to latest stable version 2.0.3 to be able to add these optional dependencies.
With Pandas 2.0 we could also potentially

leverage new pandas features
mitigate bugs
improve performance

Changes in 2.0: https://pandas.pydata.org/docs/whatsnew/v2.0.0.html
TESTING INSTRUCTIONS

scripts/tests/run.sh --module tests/integration_tests/
pytest ./tests/unit_tests/

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

LGTM! Thanks for this nice PR!

@sebastianliebscher would you mind updating the PR description to include the reason for bumping said package as this would help provide more context when reviewing? Is it purely from a code maintenance/hygiene perspective or is this change a precursor for something else?

@john-bodley PR summary updated

Hey @john-bodley @rusackas! Can we merge the PR?


Figure out a better way to do paren around a LabeledText

jk this will be fixed in application code

jk this will be fixed in application code


can't change default shell

I have installed the Zsh,and run command sudo chsh -s zsh,but zsh not work.
root@XY:~# echo $SHELL
/bin/bash

windows 10  preview 14352
what should i do?

For a workaround you can launch zsh from your .bashrc file. We don't run login which is the component that normally sets those things up.

Another option I have seen people do is use the command bash -c zsh.

@russalex @benhillis Thank you all.
I have resolved the problem.
My way is add  command bash -c zsh to .bashrc file.

@seayxu Russalex meant bash.exe -c /bin/zsh

@fpqc I know,but this way is not what i want.
it is not work when opened command windows after closed

Then you should just put /bin/zsh in .bashrc. No need to do bash -c in that case.

@fpqc yes,i get it.
Thank you!

# Launch Zsh
if [ -t 1 ]; then
exec zsh
fi

This might be better ;)

Along with everything above, to get my terminal to open to zsh, I had to go to
Terminal > Preferences > General
Then change the "Shells open with:" option to: Default login shell

This one was actually dupe #477 way up top but was never marked as such. Work-around was to exec zsh inside .bashrc, or launch it by whatever creative means you like. These days just wsl.exe will respect the default shell.

 In other words, it runs bash, runs bash, and then runs ZSH. It would be akin to opening a cmd.exe session and typing cmd.exe powershell.exe.
The exec in the second method is unnecessary because it execs the text that comes after it. exec zsh and zsh do the same thing.
What I have in my $HOME/.bashrc is
 [[ $- == *i* ]] && $(command -v zsh) || echo "ZSH is not installed"

What this does:

[[ $- == *i* ]] && says "if this is an interactive session (ie not started by a script), do what comes next". If not, continue as if nothing happened. This is a safeguard because while Bash scripts are 99% compatible with ZSH, some integral parts such as arrays and strings have some significant differences that might make your script take a dump.
$(command -v zsh) runs the command command -v zsh, which will print the full path to ZSH (eg /bin/zsh) if there is a binary with that name on the path. The $() executes the output of whatever is between the parens- in this case the full path to ZSH or nothing if it cannot be found. The $() will return the exit status of that command if it is nonzero.
|| echo "ZSH is not installed" says "if that last command returned a nonzero exit status" (||), "execute whatever follows". In this case, what follows is a friendly message telling you ZSH is not installed.

HTH!

What I have in my $HOME/.bashrc is...

...unnecessary.
chsh(1) has worked since the 2017 Fall Creators Update via wsl.exe. HTH.

@radum
i'm using you method...but how about this?
➜  data git:(master) ✗ chsh -s /bin/zsh
正在更改 captain 的 shell。
密码：
chsh: shell 未更改。
➜  data git:(master) ✗ chsh -s /bin/bash
正在更改 captain 的 shell。
密码：
shell 已更改。
➜  data git:(master) ✗ echo $SHELL
/bin/bash
➜  data git:(master) ✗ chsh -s /bin/zsh
正在更改 captain 的 shell。
密码：
shell 已更改。
➜  data git:(master) ✗ echo $SHELL
/bin/bash
➜  data git:(master) ✗


fix(enhanced): add abortOnMissExpose field

Description
When users set invalid expose , the compile will not be aborted , and the remoteEntry will include below contents:
var moduleMap = {
	"./Button": () => {
		var e = new Error("Cannot find module './src/Button.tsx'"); e.code = 'MODULE_NOT_FOUND'; throw e;
	},
};

And the users will not feel the error until the consumer use the error provider . For dynamic provider , this is a bit dangerous , so need to add an option to allow the users feel this error .
So this pr adds a new oprtion abortOnMissExpose , users can set abortOnMissExpose: true ,and it will abort the compile if exist miss expose modules
new ModuleFederationPlugin({
  abortOnMissExpose: true
})

// it will throw the error info if exist miss modules

Related Issue

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Checklist

[X] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] I have updated the documentation.

Should this default to true? Or do we even need an option for this? Can we just fail the build, as this should always be an invalid build?

Should this default to true? Or do we even need an option for this? Can we just fail the build, as this should always be an invalid build?

Ahh yes , i add options because i don't sure whether it can be default behavior . So , we can throw error if exist miss modules  by default ?

I would vote for this as the default behavior. No options.  Like when the entry point is an invalid path. However, if you want to collect feedback, let's default to true. If there are no problems from users, I would suggest we make it ssandard function of the federation plugin in the future: error the build if invalid exposes are passed. Then we can remove the options after user feedback from it.

cool i will set it as default behavior

@ScriptedAlchemy  I change the pr , and now it will abort the compile process if not find the expose modules


Add and Remove Aliases from Endpoint Aliases Page

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Enables a user to add or remove aliases from the Endpoint Aliases page is System Explorer.
Why should this Pull Request be merged?
This change will let users see the list of all available endpoints in their system and choose a valid endpoint to alias instead of having to script everything.
What testing has been done?
Built and ran manual tests. Ran automated tests.

[ ] Fix typo "aleady" -> "already"
.

[ ] We might want to put the alias and endpoint names in quotes, to help in the case where the endpoint name is empty.

[ ] The text fields should be single-line, and ideally support tabbing between them (not sure if this is possible).

The text fields should be single-line, and ideally support tabbing between them (not sure if this is possible).

You should be able to tab between items at the same array index. Enforcing single-line and tabbing between array elements is doable, but not trivial. I'd rather track that as an enhancement issue and not try to put it in this change.

[ ]  The text fields should be single-line, and ideally support tabbing between them (not sure if this is possible).

[ ] Detect incoming errors and do no thing in the error case.


Verify ALL public APIs are documented

There are many header files (179) in the include/ folder that do not define a doxygen @defgroup and so are not being included in the Sphinx/Breathe-generated API documentation.

There are also include files that contain a doxygen defgroup, but the corresponding doxygengroup directive is not found in an API reST file so the content isn't generated in our API docs.  Need to verify that every defgroup has a corresponding doxygengroup mentioning it, and add the missing ones.


Add support for <config.json>

Thanks you, Dan. I created a branch based on this PR and then created a small test. It created the the following JSON file:
[
    "/var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/plsql-formatter-test-18221914857276644694/query.sql",
    "/var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/plsql-formatter-test-18221914857276644694/markdown.md"
]

and then called script format.js /private/var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/plsql-formatter-test-18221914857276644694/config.json.
The console output was:
Formatting file 1 of 2: /var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/plsql-formatter-test-18221914857276644694/query.sql... done.
Formatting file 11 of 2: /var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/plsql-formatter-test-18221914857276644694/markdown.md... done.

The files were processed (formatted) correctly, but the output 11 of 2 looks wrong.
I changed line 390 as follows to fix the problem.
ctx.write("Formatting file " + parseInt(Number(i)+Number(1)) + " of " + files.length + ": " + files[i].toString() + "... ");

A more elegant solution is welcome.
I have some other issues with all existing SQLcl related tests. They are failing. I'm not sure what the problem is. I'll have to analyze it.
Please update this PR when anytime. In the meantime I will write the test cases. They can be merged later into this PR.

The files were processed (formatted) correctly, but the output 11 of 2 looks wrong.

I should have noticed that! :) I updated the code to make it a standard for loop.

The current version does not work with rootPath anymore. That's why all other test cases fail.

What are your thoughts on commit e278609? The idea is to move the 'imports' of the Java classes to the top (which is common in Node.js code, for example). That removed 30 lines of code from duplicate imports.
Also, and perhaps a little more importantly for a JavaScript developer like myself, I prefixed the classes so one could tell where they came from and distinguish them from what's in JavaScript (e.g. String vs javaString).

What are your thoughts on commit e278609? The idea is to move the 'imports' of the Java classes to the top (which is common in Node.js code, for example). That removed 30 lines of code from duplicate imports.

It's probably better this way.

Also, and perhaps a little more importantly for a JavaScript developer like myself, I prefixed the classes so one could tell where they came from and distinguish them from what's in JavaScript (e.g. String vs javaString).

I understand the reason for the prefix. But why not use a common prefix for Java classes. "java" for everything? The full qualified package is not that important IMO.

I understand the reason for the prefix. But why not use a common prefix for Java classes. "java" for everything? The full qualified package is not that important IMO.

Done.

I created a branch https://github.com/Trivadis/plsql-formatter-settings/tree/feature/pr-101-config-file based on your change plus a test case for a config file with a file array. All tests completed successfully.
You can merge it into your branch.
I will add another test with all parameters later. I will probably need to change some other tests once you updated printUsage.

Okay, I've integrated the test changes and took the first stab at the doc. Let me know what you think.

README.md looks good. Thanks a lot! 👍
As soon as you merge my PR https://github.com/dmcghan/plsql-formatter-settings/pull/1 I can accept this PR.

Thanks, Philipp!

I thank you, Dan. It was a pleasure working with you.

Woohoo! Can I give this a test already? 😃

Yes! Main Branch is the one to use with current SQLDev and SQLcl versions. A release is coupled with legacy versions. It's a different concept to other repos. So, the next release is planned when SQLDev 21.1 becomes available.

It worked beautifully! Now I am generating a temp json file with my staged files within the pre-commit hook and it's perfect!
staged_files=$(git diff --cached --name-only --diff-filter=ACM | grep "db/")
jq -n --arg file "${staged_files}" '{ files: $file | split("\n") }' > temp/config.json
sqlcl ... script format.js temp/config.json

👏🏻


custom ‘barcode_whitelist’ specifying positional barcodes from the spatial arrays

Hi,
I noticed that the custom "barcode_whitelist" for the spatial positional barcode arrays is not found. Could you please provide the full barcode whitelist? Thank you.

Hey biliopo,
I've now added the whitelist under the meta folder.
Cheers,
M


OpenStack: Changed metadata hostname source order

OpenStack: Changed metadata hostname source order
Change flatcar-openstack-hostname.service to use afterburn openstack provider implemented on https://github.com/coreos/afterburn/pull/462  instead of openstack-metadata.
Closes: https://github.com/flatcar/Flatcar/issues/1445
BootEngine PR: https://github.com/flatcar/bootengine/pull/96
Superseeds https://github.com/flatcar/scripts/pull/2009
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

[ ] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Hello @alejandro-ripoll,
You need to readd to the commit the correct CROSS WORKON ID for the bootengine: https://github.com/flatcar/bootengine/commit/fb2631ce5e6a21d044c8dca73f59db01f9d5abcf.
Also, the changelog entry needs to reflect the correct PR ID and the commit message needs to be smaller and in the commit description to add the necessary links / what has been changed.
Thank you.

Hello @alejandro-ripoll,
You need to readd to the commit the correct CROSS WORKON ID for the bootengine: flatcar/bootengine@fb2631c.
Also, the changelog entry needs to reflect the correct PR ID and the commit message needs to be smaller and in the commit description to add the necessary links / what has been changed.
Thank you.

Thanks @ader1990 and @tormath1. I think it should be alright now.


FormItem: field name support dot in prop

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

description
Sometimes property name has . in form object, so need support to parse this key in form.
example
<el-form :model="wifi">
  <el-form-item prop="bands['2.4g'].channel"></el-form-item>
</el-form>

rules: {
  "bands['2.4g'].channel": [{
     // validators
  }]
},
wifi: {
  bands: {
    "2.4g": {
        channel: 11
    },
    "5g": {
        channel: 40
    }
  }
}

Now this will cause an error that says this prop is not valid
related issues
#10299

Any unit tests?

Any unit tests?

Only run with existing use cases in the project. I can add some later if necessary


cataclysm: Add optional support for LUA

Many mods for Cataclysm require LUA support.  This PR adds LUA=1 to the build command if --with-lua is specified, and updates the requirements accordingly.

Looks good to me. Could you add revision 1 after sha256 line so that existing users can get update once it's merged? Also minor nitpicks, Homebrew prefers options and deps ordered alphabetically. lua stuff can go before tiles stuff I guess.

Changed "LUA" to "Lua", reordered options, deps and ARGS alphabetically.
@tomyun I wasn't quite sure exactly where you'd like the revision 1; I'm not at my Mac so committing blind, but can finish this off later today.

@ddunwoody revision can be after sha256 and before head I think. If you're not sure, you can always put it somewhere and let brew audit --strict tells you where it likes.

@tomyum revision added.  Thank you for the tip on brew audit --strict; most helpful.

It now passes the test and bottles fine. BTW, it gives some debug messages for missing class_definitions.lua and autoexec.lua on startup. Is it something we'd expect?
DEBUG: Lua returned file io error for lua/class_definitions.lua
cannot open lua/class_definitions.lua: No such file or directory
  Press spacebar...

And I forgot to ask if we'd like --with-lua to be :recommended (default) rather than :optional. If the most users are expected to use lua-dependent modules, :recommended would make more sense. I'd leave it up to your decision.

being optional should be better. lua support is currently very limited.

@zanderzhng Thanks for your comment. I'll pass on :recommended for --with-lua option then. Do you have any idea on lua/class_definitions.lua error above?

i just built cataclysm --with-lua --HEAD without error, did you build with HEAD?
it seems to be a new feature, maybe a dependency for HEAD is necessary.

I'll update this over the weekend with the recommendation and take a look at the missing file error.
The latter seems to be explicitly referenced in the Makefile.

Ping?

Closing due to lack of response, but please feel free to reopen!


Warn about problematic combinations of target and host version

The "supported targets" table in the readme excludes these combinations, but it would be useful to have an explicit warning.
https://github.com/taiki-e/setup-cross-toolchain-action/blob/0350ba83607e75dc601b3e8b3c70a3b7c7fbd580/.github/workflows/ci.yml#L78-L91

Segmentation fault on ubuntu 20.04

Maybe related to https://bugs.launchpad.net/qemu/+bug/1701798


macs2 dedup missing versions

https://github.com/CCBR/CHAMPAGNE/blob/c3f485542408f4d35724c47a9c40fa47f5fa743f/modules/local/deduplicate.nf#L2
versions need to be emitted here.

related to #27


Progmem for command name

I tried modifying the src to add flashstringhelper for the command function name, compiles fine but it does not work. Do you have plans to add progmem for command name in the future? this might help for many commands ram usage.

Hi, have a look here: https://github.com/spacehuhn/SimpleCLI/issues/8

Thank you it works, awesome library as always.


Upgrade build tools version

Closing this issue because there isn't any reason to upgrade the build tools currently. If you feel that this is a mistake and we really really should be using 22.0.1 or above, please say why (e.g. if you had problems building the SDK) and we can bump the version accordingly.


NIFI-7461: Fix image url in documentation.

Image in documentation does not appear. "page not found" appears.
There is a image directory, but the link is not properly connected. So I fixed image url in documentation. I can see the image of the current document.
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

I think this is because the relative URLs are different for the hosted site and the local documentation built and bundled within the application. Can you please provide a screenshot showing the failure to load the image and the complete URL of the page as you view it? I see it working successfully on the hosted website and in a local documentation build.
This could also be a caching issue; have you tried a hard refresh in your browser?

I just verified on the latest master, and everything looks good. Going to close the ticket. Feel free to reopen if you can post a screenshot and more details showing what you're seeing.


asset selection for request - PoC

Needs test, I can't fully build, but I tested data methods outside of this solution.
If successful, needs own component so it's free to use everywhere
edit: also definitely needs paging
@Riley-Kilgore

I figured out how to run it (with WSL2) and there are some bugs, I'll reopen after I fix it


Question

Im trying to use a HLS m3u8 stream and it's not working. Is this format supported?

Not sure if your still looking but I did find a way on how to do it, I'll make a form of this and share it to you when I'm available as im not right now


Missing Apycula file when compiling nextpnr_gowin

I am trying to compile nextpnr-gowin after installing apycula using this github action:
https://github.com/philiprbrenan/nextPnr/actions/runs/5565472535/jobs/10165851576
The compilation process terminates with the following message concerning an apycula file:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.10/dist-packages/apycula/GW2A-18.pickle'
Please tell me how to obtain this file?

This file should be in the apicula 0.8.2a1 release.
The non-standard way is to download gw2a-18-chipdb from artifacts.
https://github.com/YosysHQ/apicula/actions/runs/5311060550#artifacts

This leads to
[  1%] Generating chipdb/chipdb-GW2A-18.bba
[  3%] Built target bbasm
Traceback (most recent call last):
File "/home/user/.local/venv/bin/gowin_bba", line 8, in
sys.exit(main())
^^^^^^
File "/home/user/.local/venv/lib/python3.11/site-packages/apycula/gowin_bba.py", line 258, in main
db = pickle.load(f)
^^^^^^^^^^^^^^
_pickle.UnpicklingError: invalid load key, '\x1f'.

apicula 0.8.2a1 release + nextpnr master.

@yrabbit In message above there is the result of such combination - "_pickle.UnpicklingError: invalid load key, '\x1f'."

This error message indicates that there is an attempt to open the chip base zip file in the usual way as an unpackaged file.
You can see for yourself.

nextpnr uses gowin_bba from apicula installed on your computer, and if it is 0.8.2a1, it is very unlikely that it uses unpackaged database loading.
And you can find all gowin_bba.py on your computer and check that it is version 0.8.2a1 by looking at line 258.
https://github.com/YosysHQ/apicula/blob/87131a1f997eebe1d9a6b4fc2f55a211eeeb962f/apycula/gowin_bba.py#L258


Skype for Business Administrator role is also required

We have found that currently the Skype for Business Administrator role is also required to assign PSTN numbers to resource accounts when you do not have the Global Administrator role.
Also worth noting, to assign Teams licenses like Teams Phone Standard license to a user/resource account requires User Administrator role.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b434530-6bf2-6e00-6eae-6fa043d022ce
Version Independent ID: caab785f-e3a4-831a-87d8-26934a9f834f
Content: Use Microsoft Teams administrator roles to manage Teams - Microsoft Teams
Content Source: Teams/using-admin-roles.md
Service: msteams
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

Hi @SvenBell, thank you for your feedback.
This issue is the same as:
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/5978
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/5980
@CLYVR do you know what role is required to assign a number to a resource account? It seems that Teams Service Admin is not enough. Thanks!

Hi @SvenBell, I remembered something.
Are you using Set-CsUser or Set-CsPhoneNumberAssignment?


[BUG] Ambiguous behavior downloading blobs using conditions between v11 and v12

Library name and version
Azure.Storage.Blobs 12.13.1
Describe the bug
Downloading a blob using the SDK v11, throws a StorageException when the blob exists and a condition is passed like this:
blob.DownloadToStream(memStream2, AccessCondition.GenerateIfNoneMatchCondition(eTag));
//or
blob.DownloadTo(filePath, AccessCondition.GenerateIfNoneMatchCondition(eTag));

However, in v12. Two things are happening:

No exception is thrown (was expecting RequestFailedException)
The Stream/File are empty

blob.DownloadTo(memStream2, conditions: new BlobRequestConditions
{
    IfNoneMatch = new ETag(eTag),
});
//or
blob.DownloadTo(filePath, conditions: new BlobRequestConditions
{
    IfNoneMatch = new ETag(eTag),
});

Expected behavior
v12 version should throw a RequestFailedException where ErrorCode == BlobErrorCode.ConditionNotMet
Actual behavior

No exception is thrown (was expecting RequestFailedException)
The Stream/File are empty

Reproduction Steps
//v11 test

//storageAcct is a valid instance of CloudStorageAccount
var blobClient = storageAcct.CreateCloudBlobClient();

var container = "test";
var blobContainer = blobClient.GetContainerReference(container);
blobContainer.CreateIfNotExists(BlobContainerPublicAccessType.Off);

var fileName = "TestFile.txt";

using(Stream fileStream = new<EMAIL_ADDRESS>+ fileName, FileMode.Open, FileAccess.Read, FileShare.Read))
{
    CloudBlockBlob blob = blobContainer.GetBlockBlobReference(fileName);
    blob.UploadFromStream(fileStream, AccessCondition.GenerateIfNotExistsCondition());
}

string eTag;
using(MemoryStream memStream = new MemoryStream())
{
    CloudBlockBlob blob = blobContainer.GetBlockBlobReference(fileName);
    blob.DownloadToStream(memStream, AccessCondition.GenerateIfExistsCondition());
    eTag = blob.Properties.ETag;
    Assert.IsFalse(string.IsNullOrWhiteSpace(eTag), "ETag not provided");
}

using(MemoryStream memStream2 = new MemoryStream())
{
    CloudBlockBlob blob = blobContainer.GetBlockBlobReference(fileName);
    //the following line throws a StorageException ex
    //where -> ex.RequestInformation.HttpStatusCode == (int)System.Net.HttpStatusCode.NotModified
    //this behavior is also confirmed in blob.DownloadTo(filePath)
    blob.DownloadToStream(memStream2, AccessCondition.GenerateIfNoneMatchCondition(eTag));
}

//v12 test

var container = "test";
//service is a valid instance of BlobServiceClient
var blobContainerClient = service.GetBlobContainerClient(container);
blobContainerClient.CreateIfNotExists(AzureStorage.Models.PublicAccessType.None);

var fileName = "TestFile.txt";

using(Stream fileStream = new<EMAIL_ADDRESS>+ fileName, FileMode.Open, FileAccess.Read, FileShare.Read))
{
    BlobClient blob = blobContainerClient.GetBlobClient(fileName);
    blob.Upload(fileData);
}

string eTag;
using(MemoryStream memStream = new MemoryStream())
{
    BlobClient blob = blobContainerClient.GetBlobClient(fileName);
    blob.DownloadTo(memStream);
    eTag = blob.GetProperties().ETag.ToString();
    Assert.IsFalse(string.IsNullOrWhiteSpace(eTag), "ETag not provided");
}

using(MemoryStream memStream2 = new MemoryStream())
{
    BlobClient blob = blobContainerClient.GetBlobClient(fileName);
    //the following line does NOT throw a RequestFailedException
    //however the stream is completely empty (memStream2.Length == 0)
    //this was also confirmed with DownloadTo(filePath) => file contents are empty
    blob.DownloadTo(memStream2, conditions: new BlobRequestConditions
    {
	IfNoneMatch = new ETag(eTag),
    });
}

Environment
Hosting Platform and .NET runtime version: Windows 11 .NET Framework 4.6.1
IDE and version: Visual Studio 2019

I also see the same problem.

Thanks for this information.  It actually assisted a lot to what's going on.
So you are correct, I believe a 304 is being thrown because it's comparing the Etags and running into an error. However let me reconfirm if this is the correct response to do in terms of passing the 304. Because looks like we should check the BlobErrorCode if it is Not-Modified.
https://github.com/Azure/azure-sdk-for-net/blob/3724ce24abd58311ec7846661870213b5f826911/sdk/storage/Azure.Storage.Blobs/src/PartitionedDownloader.cs#L162
Looks like normally from the service we're expecting a 412 for the modified during in flight.

Adding Service team to look into this


[CT-581] [Feature] Grants as Node Configs

Description
Today users often configure a post_hook to grant permissions on models, seeds, and snapshots:
{{ config(post_hook = 'grant select on {{ this }} to role reporter') }}

This ticket aims to make it easier to specify grants allowing it to be configured directly both in dbt_project.yml as well as in source files:
# dbt_project.yml
models:
  export:
    +grants:
      select: ['reporter', 'bi']

-- SQL
{{ config(grants = {'select': ['other_user']}) }}

These grant configs will not necessarily look the same for each and every warehouse. The logic to generate the sql from these configs can be overriden by adapters.
Implementation
The implementation can be split up into two testable parts. Although it is possible to merge them separately (sequentially), both are required for this feature to be exposed to users.
Adding the Configuration

[ ] a "grants" config should be added to model, seed, and snapshot nodes. The value of this config is a dictionary.
[ ] merge behavior for grants should be to override / clobber not append.
[ ] test that projects can define grants in 1) the dbt_project.yml, 2) models, seeds, and snapshots, and 3) both the dbt_project.yml and models, seeds, and snapshots with the correct merge behavior.

Issuing the grants

[ ] create a new macro: get_grant_sql(grant_config: dict) -> str that creates the warehouse-specific sql from grant portion of the config. The default implementation should throw or return an empty string because it is expected to be overridden by adapters. The macro signature here is designed to accept different shapes of grant configs for each adapter to use whatever best fits the warehouse's permissions system.
[ ] create a new macro: apply_grants which calls get_grant_sql to apply the grants (see persist_docs for an example of similar implementation)
[ ] add a call to apply_grants in all materializations
[ ] test that postgres projects can define grants in 1) the dbt_project.yml, 2) models, seeds, and snapshots, and 3) both the dbt_project.yml and models, seeds, and snapshots and those permissions can be read back directly from the postgres warehouse after a run.

In order for this to be usable, the adapters must each override get_grant_sql. Because that does not prevent a merge into main for core, adapter work will be tracked in separate tickets.

Looking grand! Two things I picked up on and want to call out:

The default implementation should throw or return an empty string because it is expected to be overridden by adapters.

Our attitude here depends on how much of a standard exists across our relevant databases. It's likely that many many databases support grant <privilege> on <object> to <recipient>. In that case, we should make this the default__ implementation, within the global project, and only require adapters to reimplement if they vary from that standard.

The value of this config is a dictionary.

This is how I have it in the original proposal and in https://github.com/dbt-labs/dbt-core/issues/5090. I'm ~85% sure it's the right data structure. There are two things that give me hesitation:

Some privileges have wonky names. E.g. 'roles/viewer' on BigQuery. This still works (right?), it's just a little uglier:

grants:
  'roles/viewer': ['recipient_one', 'recipient_two']

# but should we instead opt for:

grants:
  - privilege: 'roles/viewer' # or just call this attribute 'name'?
    recipients: ['recipient_one', 'recipient_two']

On most databases, it's possible to grant multiple privileges to multiple people at the same time: grant select, manage, something_else on object this_table to person_a, person_b, group_c. But if we make grants a list, I'm not sure how we can support merging/clobbering. I think it would be better to just require a bit of duplication, in cases where you want to grant multiple privileges to the same group of people.

✅  default implementation - edited.

Since we don't control warehouse naming conventions I figured those would be completely overridable. For an extreme example, dbt_project.yml for FunkyDB could read something like:

grants:
  dance_moves: [1, 15, 79]
  dancers: "engineering_all"
  max_allowed_intensity: 9000

and the adapter override would have the freedom to map that directly to the correct SQL grant statement for FunkyDB.

I don't think I totally understand. Since our merge strategy is to clobber here, I feel like it shouldn't matter if it applies to multiple recipients. I'm fine with requiring duplication if we need to, but I'd like to understand better.

Good point re: 2! I had been thinking about a merge strategy of "merge" (updating specific keys, leaving keys without updates in place). If our merge strategy is indeed to clobber, it doesn't matter.

Moved the second half of this description to #5263


Replace localtime() function with datetime.now()

Add UserStatus migration of existing User data
Replace localtime() function with datetime.now()
When I tested it in my real application environment, the localtime() function caused a problem: I got a "localtime() cannot be applied to a naive datetime" error in that part, and when I replaced it with datetime.now(), the error disappeared. The test case passes, but I'm not sure if there aren't other side effects, could you please look into it?

Release Notes

Just wanted to say

Release type: patch
Add UserStatus migration of existing User data
Replace localtime() function with datetime.now()

can you provide a stacktrace?
datetime.now() is not ideal

As you can see, there is no special message in the console, and the GraphiQL client shows the same error I wrote down. That's it, is there anything else I can do to take more logs?

I think I've found the cause: I have USE_TZ = False set in my settings.py, which I don't know why it's set this way. If I change it to USE_TZ = True, the problem doesn't occur. How do you suggest I fix this?

I would suggest you to set USE_TZ = True is is recommended by django and is the default since Django 5

Please make sure that your branch is in sync with origin/main branch. there are lot's of redundant commits here...


Add Jupyter integration page to Docs

Thank you so much for contributing to Datapane, please help us by filing out this PR template and ensure you have read the CONTRIBUTING.md.
It may take a few days to review your PR and merge it - please bear with us!
Thanks!
Prerequsites

[x] Has been tested locally
[ ] If a bugfix, have included a breaking test if possible

Proposed Changes
Adds Jupyter Integration to docs.

We're shining a light on it by placing it in the root of the navigation. We can move this elsewhere if preferable, e.g. within Tutorials.
We've taken advantage of our notebook-based docs, by making the Jupyter docs page itself an app that's uploaded and shared with the reader.

We have to remove part of this for now. The cells_to_blocks, upload, and save cells are now markdown rather than code cells. This is because cells_to_blocks doesn't support nbconvert, which is what's used in our automated docs build and deployment. Tracking progress which should make this possible in future, e.g. https://github.com/jupyter/jupyter_client/pull/656. The blocker right now is getting the current notebook path when executing from within nbconvert.

It's tentatively named "Jupyter Integration", let's decide what to name it before merging.

Re-ordered and removed/updated some of the text.

Great, LGTM! I'll do my follow-ups in another branch so we can land this.


Added support for CTCL data  import

Added app for electoral district and party
Updated import_export_ctcl app with import for party and entire CTCL data
Added script to import_export_ctcl template for importing CTCL data in a given sequence
fixed a few warnings

Great work @mnneelam, this is some excellent code. 👍


Add EIT e2e cases

Test cases covered: (As will be seen in slack)
VPC-FILE-CSI-TEST: [EIT BASED] VERIFYING MULTI-ZONE/MULTI-NODE READ/WRITE BY USING DAEMONSET
VPC-FILE-CSI-TEST: [EIT BASED] VERIFYING PVC CREATE/DELETE WITH ibmc-vpc-file-eit-retain-dp2 STORAGE CLASS RESTRICTED TO DEFAULT WP
VPC-FILE-CSI-TEST: [EIT BASED] VERIFYING PVC EXPANSION USING DEPLOYMENT
VPC-FILE-CSI-TEST: [EIT BASED] PROVISIONING DEPLOYMENT ON WP WHERE EIT IS NOT ENABLED MUST FAIL

Testing pending for now

Things to be updated in base jenkins after PR is merged

Use go 1.20 instead of 1.19
Use supported version of kubectl (1.28 or above)
Update repo to ibmcloud-volume-file-vpc
Update e2e.sh/iks-cluster path
Add parameter --addon-version in e2e.sh


Update contributing guidelines & update CHANGELOG

Fixes #172

Pull Request Test Coverage Report for Build 561

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.5%

Totals

Change from base Build 559:
0.0%

Covered Lines:
273

Relevant Lines:
280

💛  - Coveralls


Failing to find files in 'dist' when exporting to S3/Zip with Bedrock

Hey,
I'm having a bit of an issue getting the export functionality working for zip/s3 with the plugin. I was able to get it working with a subdirectory following guides found on other issues but the export is where it is failing.
I believe it could be to do with me using the Bedrock folder structure from Roots.io or a failing in the exclude/include functionality.
With the folder structure all of the production assets live inside a dist file located here:
/web/app/themes/theme_name/dist/
I've tried adding this folder and specific files inside of the include URL section but have had no success.
The plugin seems to be crawling the following folder:
/web/app/themes/garrison/resources/
Again I have added this to the exclude URL section but have had no success.
Is there a way I can specify a wildcard/regex expression for crawling files?

hardcoded filtering of dist paths was removed some time back, no longer an issue


CVE-2023-36665

What is the issue?
Snyk reported a security vulnerability on protobufjs dependency
Is there a CVE Mitre link?
https://www.cve.org/CVERecord?id=CVE-2023-36665
What is the mitigation if known?
Upgrade to<EMAIL_ADDRESS>

https://github.com/janus-idp/backstage-showcase/security/dependabot/29


fix house_of_botcake note

no need to free b again, just use it to modify.

If the content of b is modifiable, then yes, we can modify b for further exploitation.
The comment here is for a more general use case where the content of b is not modifiable. In this, freeing b is needed to overwrite the fwd pointer of victim again.

Oh, I see. Thanks.


keycloak not able to redirect back after successful login

Hello,
I`m using this plugin with same example code
when i'm running code normally using the flutter run command
flutter run -d chrome --web-port 60000
completed login flow and redirecting back to app after successful login.
in this case the redirectURI is http://localhost:60000/loginCallback
but After i build the flutter project and then hosted that build in windows system's IIS,
and redirectURI Also changed to the system's IP
http://<IP_ADDRESS>:88/loginCallback
onGenerateRouting code is taking from issue link :- https://github.com/gibahjoe/keycloak_flutter/issues/1#issuecomment-760256583
in this case after successful login it does not redirect to the hosted app instead it shows the 404 Not-Found error

Hi, when you see the 404 error, what url is in the address bar?

Hello,
As per the build hosted on IIS, below is the redirect Url
http://<IP_ADDRESS>:88/loginCallback
which is also added in Keycloak's Valid Redirect URIs
after login it redirects to the below URL
http://<IP_ADDRESS>:88/loginCallback#state=337fc704-8f2f-4a16-9d33-5fc53ee354d8&session_state=c0ffeea5-a1fd-487a-84cd-795930d2569a&code=4e4bf19c-2c2d-4608-b7e8-4ceb4186c839.c0ffeea5-a1fd-487a-84cd-795930d2569a.dc846db4-af13-4643-ae21-695419a5598d
and gives 404 Error page Url
Screen Shot of 404 error page :-

Okay. What's your flutter version?
This looks like incorrect server configuration. Can you try to access the url directly without the # part of it?
Also, please paste your route settings let me take a look

Yes,
the Flutter version : Flutter 2.0.1 • channel beta
Can`t access directly without the # part Same 404 error found.
this is the direct url :- http://<IP_ADDRESS>:88/loginCallback
Route Setting
    initialRoute: '/',
    routes: {
      '/': (context) => MyHomePage(title: 'Flutter Keycloak demo'),
       '/loginCallback': (context) => MyHomePage(title: 'Flutter Keycloak loginCallback'),
    },
    onGenerateRoute: (routeSettings) {
        var uri = Uri.tryParse(routeSettings.name);
        if (uri.fragment.startsWith('state')) {
          return MaterialPageRoute(
              builder: (_) => Center(
                    child: MyHomePage(title: 'Flutter Keycloak loginCallback1'),
                  ));
        }
        return MaterialPageRoute(
          builder: (_) => Center(
            child: Text('Route ${routeSettings.name} not found'),
          ),
        );
      },

The issue appears to be from your configuration. I don't know enough about IIS but it seems the traffic going to the callback url is not being sent to your app.

Hi,
Any suggestions on keycloak server configuration settings that you can suggest that we can update or change to solve this issue?
as implemented solution works when we're running project using simple flutter run command (i.e With localhost).

Hi, I believe its a server configuration issue, not Keycloak.
I don't know much about IIS but you need to forward all requests to that address to your index.html
in your project index.html, ensure you have this line
<base href="/">
On Nginx, it will look something like this
location / {     try_files $uri $uri.html $uri/ /fallback/index.html; }

Closing this since no clear next steps. Feel free to reopen


Exclude 2 jfr testcases on aarch64 platform

Related to issue #2985

@sophia-guo  I used the same email, the error arose when I deleted Contributing.md file. I am working  on it


Update CMakeLists.txt

Some systems (I know of 2) have the include dir as a symlink, where .. would resolve to something else that totally doesn't contain the cuda dir. The proposed way should work better in that case!
$ ls -al /opt/cuda/include
lrwxrwxrwx 1 root root 28 Mar  1 16:45 /opt/cuda/include -> targets/x86_64-linux/include

This is the solution I was looking for. Thanks!


version updates and related fixes due to pandas and linalg

There are some problems introduced by the sort function pandas being completely deprecated, now sort_values have to be used (introduced in pandas 0.17). There were some issues with linalg when passing matrices with dtype object (would not make automatic conversion to a numeric dtype)

@bthirion there are some issues due to mkl installation and libgfortran library installation after trying to upgrade to numpy 1.9, then neurodebian support numpy 1.8.2 while pandas sort function deprecation forces to upgrade to pandas 0.17.1 then forcing numpy to 1.9.
We would need to avoid using pandas sort function completely or upgrade to numpy 1.9 and related dependencies, what do you think is best?

for the moment i took the initiative to do without the pandas sort, since its only used in one line of code.

All travis problems fixed, @bthirion the version update is ready for review. The circle ci failure is related to a problem with the brainomics cea server, which is an issue also open in nilearn https://github.com/nilearn/nilearn/issues/678

Indee, I had come tio the same conclusion. I'll do a review in the afternoon, as we badly need these fixes.

Also I had to upgrade sphinx gallery to its latest release (0.1.12) to avoid another problem with circle ci. There was some folder naming convention broken with sphinx  1.6 (_extensions folder name changed to extentions). The new sphinx gallery version fixes the issue.

Aside from one small detail, LGTM.

what detail? we merge this?

Simply clarifying the pandas substitution (at least a comment, maybe an encapsulating function).

Done. I think a comment makes more sense for now, later we can create a function in utils if this comes up again, to make the compatibility constrain more explicit.

Thx. Merging


Add getPosition() function to Reader

Hi,
Description
As a user of ion-js, I would love to be able to get position information from ionReader, so that when using ionReader to read a ion file, I can know which position I'm currently at.
Application scenario
Our team uses ion to define a format, e.g. paragraph P uses certain format style S, and the definition of style S is out side of the paragraph itself. see blow:
style::{
  name:S,
  font:Arial,
  .....
}
....
....
paragraph::{
  name:A,
  style:S,
  .....
}

I'm working on a vs code extension: ion-style-peek, so that in the above ion file, when users are viewing paragraph A and call go to definition on S, the editor will jump to style S.  Similar implementation can be found: https://github.com/pranaygp/vscode-css-peek
To implement the above, we need to get the position when parsing style container in the ion, hence the requesting issue.
Pull request:
https://github.com/amzn/ion-js/pull/655
Thanks!
Ethan

Added in #657.


notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin"} (current: {"os":"linux","arch":"x64"})

👋  We are running into an issue with the fsevents library when we try and run npm install after renovate tries to update third party dependencies. Here is the error
 notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin"} (current: {"os":"linux","arch":"x64"})

Manually adding linux to the os array in the package-lock.json resolves the issue but it eventually gets overwritten when the package-lock.json gets updated.
I tried to make the change myself here  but I don't think I'm allowed to make commits or open up PRs as I'm not an active maintainer of this project. I'm happy to make the change if someone wants to give me the keys.

not an error

We encountered the issue today that after upgrading fsevents to 2.3.3 that our build on linux stopped working:
2023-09-04T15:35:04.839Z [INFO]: # Executing command: npm install
2023-09-04T15:36:10.147Z [WARNING]: npm ERR!
2023-09-04T15:36:10.152Z [WARNING]: code EBADPLATFORM
                                    npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin"} (current: {"os":"linux"})
                                    npm ERR! notsup Valid os:  darwin
                                    npm ERR! notsup Actual os: linux
                                    npm ERR!  Build failed
2023-09-04T15:36:10.177Z [ERROR]: !!! Non-Zero Exit Code detected

We fixed it for now by using:
      "os": [
        "darwin",
        "linux"
      ],

Which eventually gets overwritten :-/

+1

fsevents is MACOS-only module! It WON'T WORK on Linux.


Add GEE Token

Hi @pauliax, thanks for your submission. At the moment, we're only merging token icons that have a certain level of usage, and that we can easily verify. Currently this token has very little usage, and the Gees token sale doesn't reference their token address anywhere I could easily find, so without those, I can't merge this yet.
Can you provide any info that this is in fact the official token?

@danfinlay this token has very little usage because it can not be used until the crowdsale is over and the crowdsale starts today. If you scroll down on this page: https://tokensale.geens.com/ there is the info confirming that the token address I provided is correct:
Token Contract Address: 0x4F4f0Db4de903B88f2B1a2847971E231D54F8fd3
Token Symbol: GEE
Decimals: 8


BLUEPRINT: Unified chapter on infinite magma constructions (#591)

This PR:

Unifies the former Asterix Equation and Greedy Constructions chapters into a more comprehensive chapter titled "Infinite magma constructions".
Adds a survey of examples, brief explanations of the following: a translation-invariant magma played straight, by Reinke to refute 1648->206; an example of my modified translation-invariant magmas, as written here: 1659->45.
Updates the selected equations in the blueprint and in the Lean code so that they remain in sync.

The surveyed examples are picked so that they are simple, but not trivial: the aim is not to showcase the most "powerful" applications of each technique, but to provide an accessible entrypoint for people who wish to study them.
Review:
This needs a brief review. Please read through 7.1 and 7.4 (the other two sections come from existing chapters), see that the web and LaTeX versions render OK, and that there are no math mistakes.
If that's done, it can and should be merged. Note that this progresses but does not by itself resolve #591 !

Thanks @zaklogician!
Equation1659_not_implies_Equation4315 seems to be declared in the blueprint, but not in the Lean codebase.

That's right, I did a local build, don't know how that made it through. Will fix in a jiffy.

Looks great!  I'll merge once the blueprint compiles.


Cannot set property 'status' of null

Expected behavior
Lack of "TypeError: Cannot set property 'status' of null" message in node logs.
Actual behavior
Sometimes in node logs I can see a message "TypeError: Cannot set property 'status' of null". I believe it is posted instead of "I haven't been chosen for offer".
Steps to reproduce the problem
I guess enable pruning.
I haven't seen this message in node logs until I enabled pruning feature.
I do not know if it does any actual harm to node operations. But it does mess with node monitoring scripts, since they are based on node logs.
I can see about 5-20 of these errors per day.
Specifications

Node version: 5.1.1
Platform: Ubuntu 18.04

Error logs

Disclaimer
Please be aware that the issue reported on a public repository allows everyone to see your node logs, node details, and contact details. If you have any sensitive information, feel free to share it by sending an email to<EMAIL_ADDRESS>

This issue is not relevant because it was for v5 and current version of OT-node is v6.


New package: BrazilCentralBank v0.1.0

Registering package: BrazilCentralBank
Repository: https://github.com/azeredo-e/BrazilCentralBank.jl
Created by: @azeredo-e
Version: v0.1.0
Commit: 71907424c57cc77d551b415a2880fb6a8d9a73f8
Reviewed by: @azeredo-e
Reference: https://github.com/azeredo-e/BrazilCentralBank.jl/issues/1#issuecomment-1998874396
Description: BrazilCentralBank.jl is an interface in the Julia programming language for the data API of Brazil's Central Bank (BCB)

[noblock] Just a tip: Documenter should not be a dependency of your package, since it is only used for building the package documentation. Including it in the [deps] section of your main Project.toml means that anyone using this package also has to install Documenter and all of Documenter's dependencies. You want to keep the main list of dependencies as small as possible. Instead, Documenter should only be a dependency in the Project.toml you use for building the documentation (most people use docs/Project.toml).


exec: "/bin/sh": stat /bin/sh: no such file or directory

Hi I am trying to create a base image using "scratch" in my redhat linux
Following is the instruction file that I am using:
FROM scratch
ADD mkdir dir/repos
cmd: >docker build -t repos
This is throwing this error:
Step 1 : FROM scratch
--->
Step 2 : RUN mkdir /dir1
---> Running in f5a7c25254b8
exec: "/bin/sh": stat /bin/sh: no such file or directory
Container command not found or does not exist.
I also restarted docker daemon.And any of thr forum questionnaire was of no use.
Kindly update me on this

Output of docker version:<<
Docker version 1.10.3, build 79ebcd8-unsupported

Output of docker info:<<

Containers: 7
Running: 0
Paused: 0
Stopped: 7
Images: 7
Server Version: 1.10.3
Storage Driver: devicemapper
Pool Name: docker-253:0-135927573-pool
Pool Blocksize: 65.54 kB
Base Device Size: 10.74 GB
Backing Filesystem: xfs
Data file: /dev/loop0
Metadata file: /dev/loop1
Data Space Used: 2.637 GB
Data Space Total: 107.4 GB
Data Space Available: 36.21 GB
Metadata Space Used: 4.743 MB
Metadata Space Total: 2.147 GB
Metadata Space Available: 2.143 GB
Udev Sync Supported: true
Deferred Removal Enabled: false
Deferred Deletion Enabled: false
Deferred Deleted Device Count: 0
Data loop file: /var/lib/docker/devicemapper/devicemapper/data
WARNING: Usage of loopback devices is strongly discouraged for production use. Either use --storage-opt dm.thinpooldev or use --storage-opt dm.no_warn_on_loop_devices=true to suppress this warning.
Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
Library Version: 1.02.107-RHEL7 (2016-06-09)
Execution Driver: native-0.2
Logging Driver: journald
Plugins:
Volume: local
Network: bridge null host
Authorization: rhel-push-plugin
Kernel Version: 3.10.0-514.6.1.el7.x86_64
Operating System: Red Hat Enterprise Linux Server 7.2 (Maipo)
OSType: linux
Architecture: x86_64
Number of Docker Hooks: 2
CPUs: 2
Total Memory: 3.702 GiB
Name: icl-awsec2-vm01.nam.nsroot.net
ID: WT33:WGQ3:RZNA:74EB:X6C5:TLTF:FKHX:TMSP:BE2S:3KIJ:EMDC:DOMR
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Registries: icl-awsec2-vm01.nam.nsroot.net:5000 (insecure), docker.io (secure)

Step 2 : RUN mkdir /dir1
This looks different than what you specified above as ADD mkdir dir/repos. Are you sure it's the same dockerfile? Also seems a bit odd to try to mkdir from ADD, looks like a mistake.
In addition, the scratch image has no tooling at all in it, it's a completely empty filesystem. A tool like mkdir would not exist, and likewise using the shell syntax of RUN mkdir foo would not work because it tries to run this in /bin/sh -c <cmd>, which also does not exist in scratch.

I see, Yes that was a typo. I meant ADD mkdir dir1/repos*
I am beginner in docker, Can you suggest what do I need to do to create a base image just for a testing purpose.

@Pdharti First I would start with https://docs.docker.com/engine/reference/builder/
Unless you are going to use a static binary or have some rootfs for the container that you want to use, you don't want scratch.
You can start off with something familiar like debian, ubuntu, or centos... or for something more minimal alpine, of if you don't need a package manager simply busybox.


Fix two rule model issues related to FormLineExpression

Avoid StackOverflowError caused by a loop in ExpressionPart#equals().
Extend ExpressionVisitor to handle ExpressionFieldVariable classes.

Not ready to merge yet. Help with implementing ToStringExpressionVisitor#visit(ExpressionFieldVariable) needed.

@manstis Ready. Thanks for review!

drools
(master) https://github.com/droolsjbpm/drools/commit/90d36eb72
(6.3.x) https://github.com/droolsjbpm/drools/commit/2e480f674

Thanks @yurloc


Use the last version of the logo

The logo used for the bot is an old version. We have to use the newest version (probably the blue one).

@jespino https://github.com/jitsi/jitsi-meet/blob/master/images/jitsiLogo_square.png might be a good source

Done

See https://github.com/mattermost/mattermost-plugin-jitsi/commit/36562894d5a1fac9f9af3d53270f7742cb4fb3ca#r40219866

@hanzei Thanks! very good catch, I didn't know it. Now is fixed, and with a better logo version (the one used for the mobile icon).


Preserve import paths for implicit cradles

Attempt to fix #765

/azp run

@maralorn does this fix things for you?

/azp run

Yes, this change fixes a test case I was using which used the implicit cradle without any config files and multiple modules.

Yes, this change fixes a test case I was using which used the implicit cradle without any config files and multiple modules.

May I ask you to test again? I just pushed a patch to fix a copy-paste error


Roles are not listing in dropdown

Hi,
I have enabled the feature "DASHBOARD_RBAC":True in superset_config file but it is not listing any roles in the drop down. can anybody help me on this.

Not sure if that was ever tried, but I'm closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


[Package Request]: WD Dashboard

How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[x] The installer meets the above requirements

Please provide the following information
Download Page Url: https://support-en.wd.com/app/answers/detailweb/a_id/31759/~/download%2C-install%2C-test-drive-and-update-firmware-using-western-digital
Publisher: Western Digital
Package Name: WD.Dashboard
Description: The software helps check on Western Digital drives in Windows. Tools for checking health, firmware versions and updates are included.
Package Version: <IP_ADDRESS>
Installer Url: https://wddashboarddownloads.wdc.com/wdDashboard/DashboardSetupSA.exe

Installer does not support unattended installation.


Add a link to the namespace in tables that display it

We should show the namespace in the different tables as a link to the namespace itself, as this allows a quick access to the namespaces.

Done already. #969


csv example export refactor

Until now, the csv export/import example files just saved fixed strings (e.g. not respecting column separators). Now they are created by the export service, and should reflect the settings.

using encoding config now


04/01/2018 06:40 : Create Pull Request for branch prTesting_2018040106 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix the return type for css tag

At present the following yields a type error because the return type of css is inferred weirdly from a composition of several function.
import { css } from 'styled-components';

const child = css``;
const parent = css`
  ${child}
`;

In the above, the type of child is the following which is unable to be nested inside of another css string (i.e. parent).
string | number | false | Keyframes | IStyledComponent<"web", any, any> | TemplateStringsArray | StyledObject<Props> | StyleFunction<Props> | RuleSet<Props> & { isCss?: boolean | undefined; }) | null | undefined;

This PR fixes the problem by:

Explicitly defining the return type of css as RuleSet<Props> and then...
Updating the flatten function to always return a RuleSet.

It seems like this might be what is already desired internally as I was able to remove type casting of css(...) as RuleSet<X> in several places.

This looks great. IMHO we merge #3828 then rebase this, since that one adds tsc coverage to tests.

Thank you, this went in with #3828


No email notification

Hi,
I've made a new install with the latest version, configure mysql instead of a previous Sqlite default install,  and  now i don't have an SQL syntax error with the LIMIT clause ! Multiple-indicies is OK too !
I've deleted the 411 indices in elasticsearch to start from a clean situation !
A search is configured to send notification once a day with the cron notation  and is enabled (high priority) !
I don't know what i'm doing wrong, but i can't receive any email  notification ???
If i execute the search everything is ok, and i receive the email notification !
My local smtp is up and running (Postfix) ...
Can someone help me please ?
Thanks for your help.
PS : The enable button is not so clear with the default colors (enable vs disable) !

Can you confirm that the Search in question is running? You can see this by hitting the "Jobs" button on the Search configuration page.

Hello,
All is fine now, and jobs too, the only problem i have is the date format (CEST instead of GMT), so when the search is created i've to substract 2 hours :) !
Thanks for your help.

Nice. :] See #42 for progress on that issue.


fix snakeyaml vulnerability issue by disabling detekt

Signed-off-by: Subhobrata Dey<EMAIL_ADDRESS>Description
fix snakeyaml vulnerability issue by disabling detekt
Issues Resolved
#231
#232
#233
#234
#235
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Lets also open an issue to triage in future.

ok sure created #239


Refactor reportValidity

https://github.com/morewings/react-forge-ui/blob/master/src/internal/inputs/useValidation.ts
reportValidity has badly readable code. Might be a bug.
Related #275

Fixed in https://github.com/morewings/koval-ui/pull/382


convert to simple quotes

Fully mechanic. Since all our code samples are using ~ Begin/~ End, the only triple quotes in the actual text were keywords. While I didn't check all of them, I did check the ones followed by a new line.

We can more easily check the rendered PDF for errors.


Monaco improvements

Create theme at runtime which follows the CSS variables of the site
Disable a few opinionated Monaco defaults like minimap and word highlights
Move styles to separate file

Labeling for backport as well as this is low-risk but nice improvement imho :)

make L-G-T-M work.


Openafs: Update to support newer kernels and improved nixos module

Motivation for this change

Support newer kernels
Add an openafs server systemd service to serve afs on a nixos server

Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Don't merge yet. The openafs package is completely unprepared to act as a server. Re-titled it as work in progress

Consider this done. Please merge.
I added a new nixos module for the openafs server and changed the generation of config files to be copied at activation time. This is necessary, as the server must be able to write to its config location.

Copying config files versus linking
The openafs server (the bosserver process, to be specific) checks access rights for some important configuration files and directories. It in particular wants write permissions to its own /etc/openafs/server directory and, of course, to /var/openafs. That's why, these directories cannot be served from the store.
Runtime changes to the server are also reflected through the configuration files (like adding a temporary server to the network, etc.), which is why the files have to be individually writable and cannot be served as links.
Alternative approach to configuration
The only real configuration file (in the NixOS sense) is /var/openafs/NetInfo. The /etc/openafs/server directory is regarded as runtime data, and the server supports means to change these files remotely, as they have to be kept consistent between several servers in the same AFS cell. This also means, that it comes with its own tools to modify the files (namely the bos command). An alternative approach would be to completely ignore the configuration and leave it to the server. The NixOS approach to "purity" goes amiss here anyway, as the configuration is not dependent on this particular NixOS machine but on the position of the server inside the AFS cell.

@Mic92, @maggesi, @joachifm and @globin: Reviving this pull request.

Are there any user-visible changes that might need a changelog?

I updated the pull request and addressed the remarks. The generation of the NetInfo file is optional and now produces a null-value, instead of the empty string, if unneeded.
I added the types accordingly. The problem with showing the default value of the bosConfig option is, that defaultText must not depend on derivations, which is not possible. I copied the text of the derivation and quoted the reference to the openafs package.

I moved the copying stuff into the services' preStart section.
@joachifm As you were asking for a Changelog (wherever that would go to): There are (theoretically) user-visible changes for the openafs client users. This change drops support for kerberos4, which is outdated for more than 15 years now and known to be insecure. It was never working together with a kerberos 5 installation in the first place, as the installed binaries collided. Dropping support for kerberos 4 also got rid of the collision. In the rare case that there are users of a openafs client on NixOS that use kerberos 4 for authentication, it would be time to change, now.

Re changelog, if you deem it appropriate, you could drop a note in https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-1703.xml

Anyway, I have nothing further on this, so if it works & nobody complains I suppose we can integrate.

@joachifm, @Mic92 Is anything blocking this from being merged?

@spacefrogg sorry I never set it up completely with kerberos etc, maybe @joachifm did.

who is @z77z btw (packet maintainer)? Does not seem to be on github?

I don't know him or if he is still active. I would be willing to add myself to the list of maintainers of this package, although, due to the mention-bot, I will be notified of future changes to these files anyway. Is there an official policy of taking maintainership?

@spacefrogg if you want to be a maintainer of this package, then you should add yourself. That's pretty much it for policy on that front, as far as I'm aware :)

@joachifm Could we merge this into 17.03? Is anything stopping this from being merged?

It'd be easier if it didn't do so much in a single changeset.  I also still don't like how it dumps stuff into /etc. Anyway, I think @globin can make a determination about integrating into the release.

@spacefrogg this has merge conflicts. Can you rebase and fix?

Ready to merge.

I tested it with:
services.openafsServer = {
  enable = true;
  cellServDB = [{
    ip = "<IP_ADDRESS>"; dnsname = "localhost";
  }];
  cellName = "localhost";
};
services.kerberos_server.enable = true;

However I need still need a keytab:
$ sudo systemctl status openafs-server.service
● openafs-server.service - OpenAFS server
   Loaded: loaded (/nix/store/ghlkq2hnkv8pcyxiam9sjl7mb9jclllx-unit-openafs-server.service/openafs-server.service; enabled; vendor preset: enabled)
   Active: inactive (dead)
Condition: start condition failed at Fri 2018-02-02 09:17:45 GMT; 4min 39s ago
           └─ ConditionPathExists=/etc/openafs/server/rxkad.keytab was not met

How can I get a keytab for my local kerberos service?
Ideally the enable option should also mention that.
At the moment the user is left in the dark.

Setting up an AFS server is much more complicated than just enabling a nixos module. You need a running Kerberos 5 server setup, to start with. You have to create a kerberos principal (i.e. account) with a special name ("afs/") and export that to the specific keytab ("/etc/openafs/server/rxkad.keytab").
This is really involved and way beyond the scope of the option description. It is documented in the Quick Start Guide, which, now, gets installed with the openafs package. But generally speaking, somebody who wants to setup an AFS server knows that this guide exists and is already following it while setting up the nixos service.
To make a long story short: What do you suggest on where to put the pointer to the documentation? I'd be happy to fix that.

Added a better description to the enable option.

Added a minor update to support kernels up to 4.15


feat: create a market maker bot

[ ] use rust
[ ] implement some logic for spread and create an api client for the xchange

done by. #3


Added an additional prefix case for public_url to allow relative paths.

Checklist

[X] Updated CHANGELOG.md describing pertinent changes.
[ ] Updated README.md with pertinent info (may not always apply). - NA
[ ] Updated site content with pertinent info (may not always apply). - NA
[X] Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will 🤓.

With this the public_url field will remain relative if the path starts with ./
This supports cases with CDN's such as itch.io which requires relative paths to host static files.
Existing users that use api/taco/ will still have the url coerced to /api/taco/. But if they specify ./api/taco/ then ./api/taco/ is used in the output. .bin/api is still coerced to /.bin/api/, paths must exactly start with ./.
It may be better to omit the ./ in the output, let me know if that's wanted.
It may be valid to extend the check to be !(val.starts_with('/') || val.starts_with("./") || val == "."), as trunk build --public-url "." feels very natural to write, but results in /./ being emitted.

I forgot to tag: this resolves #165 and #320
As an additional note, this is an alternative change that would allow trunk build --public-url "."
/// Ensure the given value for `--public-url` is formatted correctly.
pub fn parse_public_url(val: &str) -> String {
    if val == "." {
        return "".into();
    }
    // If val don't start with a / (absolute) or . (relative) path, default to absolute.
    let prefix = if !(val.starts_with('/') || val.starts_with("./")) {
        "/"
    } else {
        ""
    };
    let suffix = if !val.ends_with('/') { "/" } else { "" };
    format!("{}{}{}", prefix, val, suffix)
}

Hm, this may not work well for cargo serve, as it is probably not supported by the Axum router to have relative urls.
Will do a bit testing locally. My guess is we have to do an additional step to transform the url, before we use it in the serve command.

@Earthmark looks like @dnaka91's comment hasn't been addressed. Please advise.

This would be good for uploading sites to IPFS also.

Even if it doesn't work with trunk serve, it would be very helpful for trunk build as it's only then that typically we change the public url.

For anyone else looking to sed this seems to do the trick to add a . infront of the /:
cat ./dist/index.html | sed "s@'/@'./@g" | sed 's@"/@"./@g'

I totally forgot about this, my apologies there. I think the sed approach is probably good enough for most use cases.
This is particularly for a CI system so trunk could produce a correct artifact, but I'm not sure what the effect will be on the serve path. So, I'll close this for now, but if it becomes an issue that I need to solve later I'll certainly push an update back up the pipe.

Exactly. I don't understand why relative paths is not the default...


reverted db, added matches and readability stats within submissions

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Reverted DB
[ ] Added readability inside submissions entity, added matches entity

Change Status

[ ] Incomplete, need to test

Looks good to me.


Button values not submitted in Firefox

See the following example:
http://jsfiddle.net/tdhooper/cxcv2rnb/3/
The 'language' value is not included in the post data.
This works in Chrome, or in Firefox when pjax is disabled.

Thanks for reporting. This is a known problem; please follow https://github.com/defunkt/jquery-pjax/pull/390#issuecomment-42797352 for updates.
BTW, your fiddle to demonstrate this doesn't actually use PJAX because it's a cross-domain post. But yes, on a single site this would definitely be a problem.
For now you could solve this by observing clicks to submit button elements and adding their name/value pairs as hidden <input>s to the form.

Thanks for the update.

Temporarily solved with:
	$(document).on('click.thunderboard', 'form input[type="submit"]', function(e) {
		$(this).closest('form').append($(this).clone().attr('type', 'hidden'));
	});

But I believe there should be a built-in solution for this.


Example app (Test app) edits

I changed the example app to another simple design and added it to apps.json.

Sorry for the delay in replying to this - for some reason I didn't see it.
I'm afraid the addition of the app with id espAndLCDtest when it's in the apps/_example_app folder will break this though - but I'll merge and remove the apps.json change


add Sendable

issue
Summary
add Sendable To Checkbox
Testing
Describe how a reviewer can test the functionality of your PR. Provide test content to test with if
applicable.
Steps:

Provide setup instructions.
Explain in detail how the functionality can be tested.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[x] Updated documentation if necessary

can you review @QuietMisdreavus ?


Error while building Hue-4.1.0

It stopped at ls: cannot access /mnt/data/apps/hue-4.1.0/binary/hue/desktop/desktop.db: No such file or directory
Here is the full stack error. What is required to to at my end?
`Post-processed 'dashboard/help/index.html' as 'dashboard/help/index.e505932c5f0c.html'
Post-processed 'dashboard/js/create-collections.ko.js' as 'dashboard/js/create-collections.ko.bc1110aa4344.js'
Post-processed 'dashboard/js/search.ko.js' as 'dashboard/js/search.ko.08e0e0a1f999.js'
Post-processed 'dashboard/js/collections.ko.js' as 'dashboard/js/collections.ko.f5c3d5a4901f.js'
Post-processed 'dashboard/js/search.utils.js' as 'dashboard/js/search.utils.85783f1cc171.js'
1401 static files copied to '/mnt/data/apps/hue-4.1.0/binary/hue/build/static', 1401 post-processed.
make[1]: Leaving directory /mnt/data/apps/hue-4.1.0/binary/hue/apps' --- Setting up Desktop database make -C /mnt/data/apps/hue-4.1.0/binary/hue/desktop syncdb make[1]: Entering directory /mnt/data/apps/hue-4.1.0/binary/hue/desktop'
--- Regenerating database at /mnt/data/apps/hue-4.1.0/binary/hue/desktop/desktop.db
--- Syncing/updating database at /mnt/data/apps/hue-4.1.0/binary/hue/desktop/desktop.db
/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/cryptography-1.3.1-py2.6-linux-x86_64.egg/cryptography/init.py:26: DeprecationWarning: Python 2.6 is no longer supported by the Python core team, please upgrade your Python. A future version of cryptography will drop support for Python 2.6
DeprecationWarning
Syncing...
Traceback (most recent call last):
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/bin/hue", line 11, in
load_entry_point('desktop', 'console_scripts', 'hue')()
File "/mnt/data/apps/hue-4.1.0/binary/hue/desktop/core/src/desktop/manage_entry.py", line 59, in entry
execute_from_command_line(sys.argv)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/init.py", line 399, in execute_from_command_line
utility.execute()
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/init.py", line 392, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/base.py", line 242, in run_from_argv
self.execute(*args, **options.dict)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/base.py", line 285, in execute
output = self.handle(*args, **options)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/base.py", line 415, in handle
return self.handle_noargs(**options)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/South-1.0.2-py2.6.egg/south/management/commands/syncdb.py", line 92, in handle_noargs
syncdb.Command().execute(**options)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/base.py", line 285, in execute
output = self.handle(*args, **options)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/base.py", line 415, in handle
return self.handle_noargs(**options)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/management/commands/syncdb.py", line 57, in handle_noargs
cursor = connection.cursor()
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/backends/init.py", line 162, in cursor
cursor = util.CursorWrapper(self._cursor(), self)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/backends/init.py", line 132, in _cursor
self.ensure_connection()
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/backends/init.py", line 127, in ensure_connection
self.connect()
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/utils.py", line 99, in exit
six.reraise(dj_exc_type, dj_exc_value, traceback)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/backends/init.py", line 127, in ensure_connection
self.connect()
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/backends/init.py", line 115, in connect
self.connection = self.get_new_connection(conn_params)
File "/mnt/data/apps/hue-4.1.0/binary/hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/backends/sqlite3/base.py", line 347, in get_new_connection
conn = Database.connect(**conn_params)
django.db.utils.OperationalError: unable to open database file
make[1]: *** [/mnt/data/apps/hue-4.1.0/binary/hue/desktop/desktop.db] Error 1
make[1]: Leaving directory /mnt/data/apps/hue-4.1.0/binary/hue/desktop' make: *** [install-env] Error 2

Forgot to update.  I downloaded the tar file and tried to build.

Seems like the 'hue syncdb' command was not ran when doing the 'make' (it will just create the SQLLite DB)


Bump node engine in package.jsons from 12 to 14

Follow-up to https://github.com/cfpb/consumerfinance.gov/pull/6377 to set the node version in use within the package.jsons to version 14 from 12.
Changes

Update node versions in package.jsons from 12 to 14.

How to test this PR

PR checks should pass.

👍  We don't use the engine-strict flag so if we have any environments sans node 14 they'll get some advisories but should still run fine.
Edit: Except github actions may not like it? See PR checks.

Yeah, except that small part ;)
This needs updating: https://github.com/cfpb/cfgov-refresh/blob/bd47b40133a50e6fd17fa09c3b523a282e5814c6/.github/workflows/frontend.yml#L22