HttpMethod.Post - Not passing parameters

I know you have not implemented any Post requests, but when I am sending a post request for an order or withdrawal, it does not seem to pass any params.
I have added the params, and also tried with no Post params at all, and the error is always ;
{"message":"Missing product_id"}
{"message":"currency is required"}
`public async Task<Order> SubmitMarketOrderCrypto(Side side, String productID, Double size, Double funds, OrderType orderType = OrderType.Market)
		{
			var request = new GdaxRequestBuilder("/orders", HttpMethod.Post)

				.AddParameterIfNotNull("side", ((Side)side).ToString())
				.AddParameterIfNotNull("product_id", productID)
				.AddParameterIfNotNull("type", ((OrderType)orderType).ToString())
				.AddParameterIfNotNull("size", ((Double)size).ToString())
				.AddParameterIfNotNull("funds", ((double)size).ToString())

				.Build();

			return (await this.GetResponse<Order>(request).ConfigureAwait(false)).Value;

		}`

Hello @ColossusFX,
I believe the issue here is that the AddParameterIfNotNull method is for adding query string parameters to the request, but the parameters that GDAX is expecting is a json object in the body. Something like this should work:
internal class SubmitMarketOrderRequest
{
    [JsonProperty("type")]
    public String Type { get; } = "market";

    [JsonProperty("product_id")]
    public String ProductId { get; set; }

    [JsonProperty("side")]
    public Side Side { get; set; }

    [JsonProperty("size")]
    public Decimal Size { get; set; }
}

public async Task<Order> SubmitMarketOrderBySize(Side side, String productId, Double size)
{
    var model = new SubmitMarketOrderRequest
    {
    	Side = side,
    	ProductId = productId,
    	Size = size
    };

    var request = new GdaxRequestBuilder("/orders", HttpMethod.Post)
    	//.AddBody(model)
        .Build();

    //TODO: There should be an AddBody method on the request builder that does this.
    request.RequestBody = JsonConvert.Serialize(model);

    return (await this.GetResponse<Order>(request).ConfigureAwait(false)).Value;
}

Thanks for replying.
It's hard to edit other people's code.
Yes I was going over all functions earlier realized I had to serialize the Post message.
I will push the branch after I have tested it all.
Thanks again

I have added changes to my branch, I still can't quite get it working.  I'm getting Null Reference Exception.
If you get 5 mins can you just glance over it?
Thanks again


VK_IMAGE_LAYOUT_PREINITIALIZED used with VK_IMAGE_TILING_OPTIMAL.

loadTexture in texture/texture.cpp creates an image with VK_IMAGE_TILING_OPTIMAL and VK_IMAGE_LAYOUT_PREINITIALIZED
The spec says:
"Currently, VK_IMAGE_LAYOUT_PREINITIALIZED is only useful with VK_IMAGE_TILING_LINEAR images because there is not a standard layout defined for VK_IMAGE_TILING_OPTIMAL images."
You probably want to use VK_IMAGE_LAYOUT_UNDEFINED instead.

This is fixed for the texture loader. A few of the examples also use preinitialized as the initial layout for optimal tiled images, and though it's not against the specs undefined is the correct one. I'll fix these too.

Using pre-initialized may cause a driver to go down the wrong path trying to maintain the texture contents. In this particular case the contents are updated using a vkCopyBufferToImage before changing the layout so using pre-initialized should be harmless, but probably still better to only use well-defined behavior in Vulkan.
Btw, I believe you previously pointed out that copying image content from a staging buffer is simpler than using a staging linear texture. I argued that it's not that big a deal because it is not all that much simpler. However, using a staging buffer is probably the preferred approach anyway, not because it's simpler, but because it only uses required Vulkan behavior. There are devices/drivers out there right now that don't support any linear textures.


Update reactive-resume.yaml to enable one click deployment

Add the required env variables for Minio for Coolify handling. The previous fix #3762 I don't believe actually fixes the issue, but had some of the first steps. I suggest moving back to quay.io's image of Minio since that seems to be the more common version in these Services. The key issues here is the lack of two environment variables that are required for Minio in some odd edge-case processing. Adding these two variables allows for the Reactive Resume one click deployment to deploy Minio with Traefik tags added, which allows the PDF download feature to work when appropriate domains are added.
Changes

Updated the reactive-resume.yaml to conform to the required Minio deployment env variables in order to get Traefik tags automatically

Issues

fix #3746

Thank you for the PR 💜.


weird ^M at the end of line on Windows?

I'm using Windows, and EOL is LF (yes, I am not a fan of CRLF)
But whatever I replace text, it comes up with ^M at the end of the line.

Default setup
return {
    "nvim-pack/nvim-spectre",
    dependencies = {
        "nvim-lua/plenary.nvim",
   },
   keys = {
    {
      "<leader>S",
      function()
        require("spectre").toggle()
      end,
      desc = "Spectre",
    },
  },
  opts = {},
}

My config

definitely sed issue. Seems like it converts files from LF to CRLF after replace. I dunno how to solve it. Seems like you need to run by hand to remove ^M. Will  be good if @windwp can help.
I will try to reproduce issue.

I am having same issue and the biggest problem is that it then messes up my undo history as it looks like the entire file was replaced/changed because every line adds the ^M carriage return. Anyone make any progress on this or have any ideas?

It seems we need to be able to run sed with the binary flag maybe? Is there a way to pass configuration / flags to sed from spectre?
https://www.gnu.org/software/sed/manual/sed.html

Yeah, sure.
replace_engine={
      ['sed']={
          cmd = "sed",
          args = {'--binary'},

      },
  },

yeah unfortunately that doesn't fix it :( it is some weird thing with sed and windows where it is saving the file in windows native format of crlf even when the file itself starts as lf unix style.

@EpsilonKu is sd option supposed to be officially supported now to use? i see mention in the readme but not much more and looks like maybe a recent PR? I am getting an error on Windows:
E5108: Error executing lua ...kstart-data/lazy/nvim-spectre/lua/spectre/replace/sd.lua:19: attempt to index local 'file' (a nil value)
I would not be surprised if it is a windows path issue where the file arg is not being properly escaped or something. sed works fine (other than the ^M \r line feed issue).

Yeah, sd was added recently. Hope @Zananok can help. Sadly I don't have ready windows to reproduce issue.

Problem is the line above, which opens the file:
    local file = io.open(value.filename, "r")
So, it means its not finding the file. I can do a simple PR later to improve readability of the error, but if you add a print(value.filename) just above, you will probably see a non proper formulated path due to windows or something.
As for ^M, its windows tools that causes this. You can run "dos2unix filename" on the file and should fix it. Additionally, but I haven't tested, after you save the file with ^M, run on the nvim: :!dos2unix

Bot is marking as stale. Bumping to see if this is something someone is willing considering to fix down the road. Thanks!


Add Flux 0.13 compatibility

Closes #201.
Depends on Flux 0.13 release and https://github.com/FluxML/FluxTraining.jl/pull/103

Apparently this fails on 0.12 due to changes necessary to Embeddings for 0.13. @darsnack do you know what could have caused this and if this means that 0.13 changes to Embedding are not forward compatible?

This isn't because of Embedding. Parallel(connection, layer) (i.e. a single branch) doesn't wrap the single layer in a tuple. So instead of iterating the tuple as expected, we are iterating the branch itself.

Okay this is cause https://github.com/FluxML/Flux.jl/pull/1862 added a type restriction to Parallel that should have probably always been there.
You could either remove 0.12 from the compat, special case 0.12 in the source, or on L50 of models.jl, you can do Tuple(catbackbone[2].layers) in the mapreduce.

Thanks! I'll try the forward-compatible fix so that FastAI.jl can be used with both 0.12 and 0.13


SPFX Application customizer extension does not run on partial pages updates

Category

[x] Bug

Describe the bug
SPFX Application customizer extension does not run on partial pages updates
Steps to reproduce
I want to inject some CSS to my SharePoint page, so I follow those steps @ https://tahoeninjas.blog/2018/05/08/inject-custom-css-on-sharepoint-modern-pages-using-spfx-extensions/ to create SPFX Application customizer extension, where i did the following:-
md app-extension
cd app-extension
yo @microsoft/sharepoint

What is your solution name?: app-extension
Which baseline packages do you want to target for your component(s)? SharePoint Online only (latest)
Which type of client-side component to create?:   HelloWorld description

then i added the following code inside the .ts:-
import { override } from '@microsoft/decorators';
import { Log } from '@microsoft/sp-core-library';
import {
  BaseApplicationCustomizer
} from '@microsoft/sp-application-base';
import { Dialog } from '@microsoft/sp-dialog';

import * as strings from 'HelloWorldApplicationCustomizerStrings';

const LOG_SOURCE: string = 'HelloWorldApplicationCustomizer';

/**
 * If your command set uses the ClientSideComponentProperties JSON input,
 * it will be deserialized into the BaseExtension.properties object.
 * You can define an interface to describe it.
 */
export interface IHelloWorldApplicationCustomizerProperties {
  // This is an example; replace with your own property
  cssurl: string;
  scripturl: string;
}

/** A Custom Action which can be run during execution of a Client Side Application */
export default class HelloWorldApplicationCustomizer
  extends BaseApplicationCustomizer<IHelloWorldApplicationCustomizerProperties> {

    @override

    public onInit(): Promise<void> {
      Log.info(LOG_SOURCE, `Initialized ${strings.Title}`);

      const cssUrl: string = this.properties.cssurl;
      const scriptUrl: string = this.properties.scripturl;

      const url = window.location.href;
      if (cssUrl && url.toLowerCase()=="https://t****.sharepoint.com/sites/customeroperations/sitepages/dashboard.aspx") {
          // inject the style sheet
          const head: any = document.getElementsByTagName("head")[0] || document.documentElement;
          let customStyle: HTMLLinkElement = document.createElement("link");
          customStyle.href = cssUrl;
          customStyle.rel = "stylesheet";
          customStyle.type = "text/css";

          const head2: any = document.getElementsByTagName("head")[0] || document.documentElement;

          head.insertAdjacentElement("beforeEnd", customStyle);
          head2.insertAdjacentHTML("beforeEnd", '<META HTTP-EQUIV="refresh" CONTENT="300">');

      }

      return Promise.resolve();
    }
}

So as shown in the above code I am specifying to only attach the custom css if the window.location.href = the url of the home page which is https://t****.sharepoint.com/sites/customeroperations/sitepages/dashboard.aspx in our case. now the above is working on most cases but is failing on the following cases:-

let say i am inside the Pages library >> then I click on the "Home" link to open the home page>> this will do a partial update to the page and will load the home page content without causing the whole page to load >> where in this cases the SPFX extension will not run.

second case>> if I am inside the home page and the SPFX has loaded the custom css file correctly >>then i click on a page inside the news web part >> this will open the news page without refreshing the page >> which will cause the SPFX to run on the news page (which is not the home page)...

so my question is how I can force the SPFX extension to run on partial updates to check the page url, to avoid the above 2 issues?
Thanks in advance for any help.
Regards

As a workaround, we can add navigatedEvent listener inside onInit function which will re-render our component every time we navigate to another page.
 this.context.application.navigatedEvent.add(this, () => {})
Test code for your reference:

Amos Wu
Microsoft SharePoint Community Support

As a workaround, we can add navigatedEvent listener inside onInit function which will re-render our component every time we navigate to another page.
 this.context.application.navigatedEvent.add(this, () => {})
Test code for your reference:

References:
https://nanddeepnachanblogs.com/posts/2020-04-10-handle-navigation-in-sharepoint-framework-application-customizer/
Amos Wu
Microsoft SharePoint Community Support

thanks for the code. where it fixed most of the navigation issues i were facing. But still i am facing this issue >> if inside the home page's News web-part >> i click on "News Post", as follow:-

the new page will open and the custom CSS will be applied to it.. not sure why? although the new news page will have a url different than the home page url.. can you advice on this please?
Thanks

any advice on this ?thanks

The page created by the new post looks like an asynchronous request, the entire page is not refreshed, and the navigation bar has not changed, so this.context.application.navigatedEvent.add(this, () => {}) does not take effect.
You could take a reference to this blog:[Handling page creation events in your SPFx application customizer](https://www.eliostruyf.com/handling-page-creation-events-spfx-application-customizer/
Amos Wu
Microsoft SharePoint Community Support)

The page created by the new post looks like an asynchronous request, the entire page is not refreshed, and the navigation bar has not changed, so this.context.application.navigatedEvent.add(this, () => {}) does not take effect.
You could take a reference to this blog:[Handling page creation events in your SPFx application customizer](https://www.eliostruyf.com/handling-page-creation-events-spfx-application-customizer/
Amos Wu
Microsoft SharePoint Community Support)

yes i saw the link, but i am nto sure how i need to combine the code inside the link with my code? as the 2 use different approaches..

Hello @johnGu123 - sorry for the long delay.
In the last few months me made multiple fixes and improvements related to navigation and navigatedEvent.
Currently it should work with in-place navigation correctly.
Could you please check if your issue is resolved?
Thanks!


MinimalCycleBasis

Whether to support technology with a mixture of arcs and straight lines

To be robust, the minimal cycle basis code is designed to use arbitrary-precision arithmetic. If you use floating-point arithmetic, rounding errors can lead to an incorrect result. Implementing an algorithm that supports arcs and line segments is more complicated. Obtaining a robust algorithm has the same issues regarding arbitrary-precision versus floating-point. I believe that using the QFNumber class (instead of BSNumber class) can lead to an exact result (using arbitrary-precision). QFNumber allows you to compute exact results when the expressions include square-root terms. QFNumber<T,1> implements arithmetic of numbers x+ysqrt(d0), where x, y and d0 are rational. QFNumber<T,2> implements numbers u+vsqrt(d1) where u = x0+y0sqrt(d0) and v = x1+y1sqrt(d1) with rational numbers x0, y0, d0, x1, y1, d1 (and d0 != d1). The more square root terms with distinct d-arguments, the more expensive to compute. The number of such terms depends on the geometric problem at hand. I have to work through the cycle basis ideas to determine how many square root terms occur.
I will add this to my list of requests to be considered, but I doubt I can produce an implementation in the short term.

Just a thought. If you approximate each arc by a polyline so that the polyline does not intersect any other edge or arc, you can use the current minimal cycle basis code. Once you have the cycles, you can replace the polylines by the arcs that generated them.


[CT-1584] [Feature] New top level commands: interactive compile

Describe the feature
In dbt-rpc and dbt-server, we support using some kind of manifest object(in mem object for dbt-rpc and manifest.msgpack for dbt-server) that regenerated whenever a dbt project file got modified to to support interactive compile.
Here's the link of how it is done in dbt-rpc and dbt-server
We would want to support this as a top level dbt-command where user would be able to compile 1 file/string leveraging existing state of project(likely manifest.msgpack generated by previous command)
Open questions for @jtcohen6 :

We need a mock command that shows what invoking this looks like. Is this what it should look like?dbt compile_sql --state {somepath to manifest.msgpack, optional} file_name

then we print the compiled code out?
how do we imagine update that manifest.msgpack when something changes but before user do another command that could generate that file? Should we just load the outdated ones? or should we try to do something like partial parsing to check project and determine whether we need a full parsing?

a compile by any other name
What do we think of creating this "interactive compile" as a modification / extension of the existing compile command?
$ dbt compile --code "select * from {{ ref('my_model') }}"

Should the argument to --code be base64 encoded (same as dbt-rpc), to support a full range of characters?
How should dbt-core "return" the compiled code? My instinct here is, a log event that shows up in stdout (for CLI users) and can be programmatically parsed (for dbt-server)

There are a few important ways in which this would be different from the dbt compile command that exists today.
If those differences feel too big/confusing, let's create a totally new command instead (e.g. dbt compile_code). Here are the differences that come to mind for me:

dbt compile --code is mutually exclusive with selection criteria (dbt compile --select/--exclude/--selector). If the --code argument is provided, dbt should skip over node selection entirely.
If dbt compile receives the --code argument, it should not populate the adapter cache. This is a behavior of standard dbt compile, but we don't want the added overhead for interactively compiling exactly this query. (Should this be another optional flag? We used to have a --bypass-cache/--no-use-cache flag before v1.0; we could add it back in.)
Not different: I think dbt compile --code would still want the ability to use --defer, though! Imagine that you've built some models in your dev schema, the rest are in prod, and you want to interactively compile a query that touches both:

select * from {{ ref('changed_model_in_dev') }}
union all
select * from {{ ref('unchanged_model_in_prod') }}

$ dbt compile --defer --state path/to/prod/artifacts/ --code "c2VsZWN0ICogZnJvbSB7eyByZWYoJ2NoYW5nZWRfbW9kZWxfaW5fZGV2JykgfX0KdW5pb24gYWxsCnNlbGVjdCAqIGZyb20ge3sgcmVmKCd1bmNoYW5nZWRfbW9kZWxfaW5fcHJvZCcpIH19"

select * from dbt_jcohen.changed_model_in_dev
union all
select * from analytics.unchanged_model_in_prod

re: manifests
I don't think we need to support a CLI --manifest flag, as a way to skip over parsing. For local runs, this is already the implicit behavior achieved via partial parsing (using target/partial_parse.msgpack).

how do we imagine update that manifest.msgpack when something changes but before user do another command that could generate that file? Should we just load the outdated ones? or should we try to do something like partial parsing to check project and determine whether we need a full parsing?

IMO this is not in scope for dbt-core. We can operate under the assumption that, if the user is modifying the manifest at the same time they're running commands, it's their responsibility to manage state for those manifests, and pass in the appropriate one to the appropriate command. In that case, the role of dbt-core is to support that concurrency by not mucking with globals, and ensuring that Manifest A being used by Command X won't be incidentally mutated by Command Y which wants to use Manifest B.

Another consideration, not mentioned above: We should support interactive compilation of a specific model, within the context of that model, while still being able to skip over cache population. That will enable us to avoid this issue: https://github.com/dbt-labs/dbt-rpc/issues/46

for --allow-introspection vs --no-allow-introspection(name tbd), here's how different runner implement it. Link for without connect to warehouse, link for being able to connect to warehouse.
The only difference seems to be removing line
with self.adapter.connection_for(self.node):


Missing image for addressformat table reference

https://docs.superoffice.com/database/tables/addressformat.html
The image reference is wrong (contains space).
At the same time:

update the screenshot
add enum links

After fix and local build:


[engine release builder] builder not found: " Production Engine Drone"

example engine release builder failure: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac engine_release_builder/523/overview
Looks like no successful build happened starting from 02/26:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac engine_release_builder/523/overview
This blocks cherry picks to roll branches on presubmits: https://github.com/flutter/flutter/pull/144592

Culprit: https://github.com/flutter/engine/pull/50893

lowering to P2 as the roll will try to roll to newer commits instead of using cherry pick
engine release builders failed on new errors after the revert (https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac Production Engine Drone/10264/overview, https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Windows engine_release_builder/821/overview)

@XilaiZhang @keyonghan was the original change reverted in main?

@XilaiZhang can you please open a new bug with all the remaining failures?

@XilaiZhang @keyonghan was the original change reverted in main?

Revert landed: https://github.com/flutter/engine/pull/51214.

Thanks @keyonghan, @XilaiZhang please let us know when the new bug is ready to close this one.

https://github.com/flutter/flutter/issues/144700 to track. Closing here.

Sure, filed https://github.com/flutter/flutter/issues/144704 for mac engine release builder and https://github.com/flutter/flutter/issues/144705 for linux engine release builder. Thanks for filing the one for windows!


⚠ Jenkins Plugins Artifactory has degraded performance

In 766e70d, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1240 ms

Resolved: Jenkins Plugins Artifactory performance has improved in c450639 after 25 minutes.


JBDS-4493 Virtualization detection never terminates on powershell<=2

Codecov Report

Merging #844 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   96.52%   96.35%   -0.17%
==========================================
  Files          36       36
  Lines        3221     3404     +183
  Branches      268      483     +215
==========================================
+ Hits         3109     3280     +171
- Misses        112      114       +2
- Partials        0       10      +10

Impacted Files
Coverage Δ

browser/services/platform.js
99.52% <100%> (+0.58%)
:arrow_up:

browser/model/devstudio.js
88.17% <0%> (-1.83%)
:arrow_down:

browser/model/helpers/downloader.js
96.94% <0%> (-1.52%)
:arrow_down:

browser/model/jbosseap.js
98.8% <0%> (-1.2%)
:arrow_down:

browser/pages/about/controller.js
21.05% <0%> (-1.17%)
:arrow_down:

browser/directives/componentPanel.js
14.28% <0%> (-1.1%)
:arrow_down:

browser/pages/confirm/controller.js
89.71% <0%> (-0.93%)
:arrow_down:

browser/services/data.js
97.03% <0%> (-0.92%)
:arrow_down:

browser/model/jbossfuse.js
99.21% <0%> (-0.79%)
:arrow_down:

browser/model/cdk.js
99.22% <0%> (-0.78%)
:arrow_down:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe4e74...23939c3. Read the comment docs.


Update frequently-asked-questions-faq.yml

Clarified how to add SQL Server to an existing VM

@bluefooted
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @greglow-sdu , thanks so much for your submission! We'd like to integrate your suggestion a bit more fully into the documentation so we've pulled your changes into the private repo and aim to address this next month. I'm going to close out this public PR but please feel free to comment should you need anything further in the meantime.
Thanks again for reaching out and helping improve our documentation! I hope you have a wonderful rest of your day.
Masha from the SQL Docs team


Make it so that ESM and CJS both are outputted

See https://github.com/GoogleChromeLabs/browser-fs-access/issues/42#issuecomment-961871284 for context.

CC: @steveruizok

Closed via https://github.com/GoogleChromeLabs/browser-fs-access/pull/83.


Create MDM Endpoints for Formula Data

Create MDM endpoint for MP Formula Data :
Formula Code: Dropdown

Test Case: TC389

Test Passed


error: Could not resolve: "react". Maybe you need to "bun install"?

I don't know if this is replicable, but I tried doing in a parallel project, and cloning your repository, and this happened:
code/beth_stack [main●] » bun run src/index.tsx

error: Could not resolve: "react". Maybe you need to "bun install"?
import { Elysia, t } from "elysia";
^
code/beth_stack/src/index.tsx:1:1

Is there any way to get around this?
bun: 0.6.2
node: 18.17.1
os: linux

Make sure your tsconfig JSX settings are aligned with the ones shown in the typed-html docs


Adding DevToolsNameGenerator and DevToolsNameResolver

This adds a new DevToolsNameGenerator class (similar to the NameSectionReader), which is responsible for generating the names depending on the name source (import, export, name section). The corresponding DevToolsNameResolver can then be used to resolve the names during disassembling wasm binaries.
The new DevToolsNameGenerator will adhere to the following naming scheme, if no name is set in the name section:

For entities (functions, tables, memories, or globals) that are imported, and which have both a <module_name> and a <field_name>, we generate a name in the form $<module_name>.<field_name>.
Otherwise, for entities (functions, tables, memories, or globals) that are exported, we take the first entry in the exports table and generate a name $<export_name>.
Otherwise:

Types use $type#.
Tables use $table#.
Memories use $memory#.
Global variables use $global#.
Functions use $import# when the function is imported, and $func# otherwise.
Local variables (and in particular parameters) use $var#.
Labels use $label#

Furthermore, adhering to the NameResolver's naming scheme (for variables and functions), if the name is known and if it is a reference, we print the index too: e.g. $foo (;0;). This is now also introduced for tables, globals and memory.

My latest change includes Eric's and Benedikt's comments.
Furthermore I added:

a small check for type names that were missing.
the way we handle import names without module and field name (not sure whether this actually happens?). In any case, the wasm2wat tool chooses to name the import as "$." if the two fields are not set, which I have also now adapted to be the case for us since we want to stick with the wasm2wat naming for imports and exports. IMHO $import# would be more meaningful in this case. WDYT?

Dear Yury, @yurydelendik
since I want to make sure that the output is WAT-compatible I had a look into the function format defined here. The function  text format does not seem to include the index as done in the output of the NameResolver (like '$foo (;0;)'). I currently also output that index and I might want to remove it if it is not WAT compatible. Do I miss anything?

Dear Yury, @yurydelendik
since I want to make sure that the output is WAT-compatible I had a look into the function format defined here. The function text format does not seem to include the index as done in the output of the NameResolver (like '$foo (;0;)'). I currently also output that index and I might want to remove it if it is not WAT compatible. Do I miss anything?

Nevermind, just realized that it is a comment.

I noted that wabt replaces invalid characters (that are used for names) by underscores. Adapting the DevToolsNameGenerator to do the same.


Volume normal on speakers but low on razer headset

Hello! I have this weird but where volume is like 50% lower than it should.
If I set my device to my speakers, the volume is exactly as loud as the webpage
However, if I set the audio device to my razer headset the volume is very low
I already played with all the possible settings on the windows audio mixer as well as the mixer provided by razer and i can't figure out how to normalize the volume.

@CaptainJawZ Make sure you don't have the 5.1 Surround Sound experiment enabled, that is probably what's causing this

With no other reports of this issue I think it will be something specific to your hardware configuration / drivers.  If you are still experiencing this issue please update all your drivers and ensure you are on the latest versions of GPMDP and Windows


Fix the problem of the deployAddons.sh

This patch fixes the problem that the deployAddons.sh script does not install UI in Ubuntu environment.

Thanks @bjlee72!
@resouer @WIZARD-CXY does this look alright?

@k8s-bot ok to test

@bjlee72 Did you test it? I wonder why use ${KUBECTL} create -f namespace.yaml twice?

@WIZARD-CXY. I changed the code as commented with the following assumptions:
To run the ./deployAddons.sh, you should first run kube-down.sh, and kube-up.sh next, and finally deployAddons.sh ALWAYS. Thus, there is no way to run deployAddons.sh multiple times without shutting down the whole cluster.

OMG, why should we tear down the whole cluster to deploy addons again? Can we check if the kube-system namespace exists before creating it ? If it exists, we are not gonna create it?

Hmmm. if we do set -e, on kubectl -f namespace.yaml fails, the deployAddons.sh exists immediately. I thought that you know this issue. That's why I first removed set -e to prevent the whole script from exiting.

Anyway, as you said that my assumption is wrong, I will find another way :-)

Besides, if we leave set -e, then we cannot implement if-then-else logic. All the test that fails automatically makes the whole script exit. :-(

@WIZARD-CXY , I ask you to review the newly committed code one more time. As I already told you, it's impossible to implement the if-then-else logic that you requested in those previous comments with set -e (The reason I already explained). Thus, I implemented the if-then-else blocks without it. Though, the newly committed script basically does the same thing with the previous one, except for that it does not try re-install the addons if they are already installed.

Much better work, Let me test it and see if we can keep set -e

I understand your problem.It just like this one.
https://stackoverflow.com/questions/6550484/avoid-grep-returning-error-when-input-doesnt-match
I recommend keep using set -e to ensure it stops when other things fail and
use KUBEDNS=eval "${KUBECTL} get services --namespace=kube-system | grep kube-dns | cat"`

Thanks @WIZARD-CXY . Following your suggestion, a new commit is issued.

Good job, I wonder will you update the doc by the way
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/ubuntu.md

@WIZARD-CXY , Thanks. I will update the doc, and will include that into the same pull request.

👍🏻👍🏻

ubuntu.md is updated.

Well done. LGTM

Thanks for reviewing, @WIZARD-CXY!

@k8s-bot test this please

Shippable build failed. Any hint to solve this?

You'll have to rebase your branch

All checks have passed. Thanks guys. I really learned a lot.

@bjlee72 Thanks for the change.


Answer / deny option on the lock screen

When someone calls / video chat have a answer / deny option, just like the regular phone app would do.

@manuroe i think it's related to CallKit

Yes. CallKit is now available.


Relative state depth issue

I am having a little bit of trouble generalizing the relative depth of my Containers within the redux store.
For instance, lets say I have a Container that uses the function
import _ from 'lodash';

const mapStateToProps = (state) => {
  const country = _.get(state, 'Address.Country', {});
  const { value } = country;
  return { value };
};

This is fine, for now, because I'm calling
combineReducers({
   /*...*/,
  Country: Country.Reducer,
   /*...*/
});

inside of my Address reducer, and in my Root reducer, I am doing the same with Address.
Now, let's imagine that I create a deeper nesting. Lets say I have a store that looks more like
{ User: { Address: { Country: { value:  'USA' }  }  }  }

Do I need to inject the new relative path into the Country container?
_.get(state, 'Address.Country', {}); // undefined
_.get(state, 'User.Address.Country', {}); // new relative path

Or am I missing something?
Basically, I'd like the containers to be depth-agnostic. My reducers already operate this way, I don't understand why containers are necessarily different.
Perhaps there could be a way to receive both relative state and global state within a mapStateToProps call?

This is a usage question, and should really be asked over on Stack Overflow.
That said: reducers are frequently structured so that they only know about the scope of the data they need to update, using the combineReducers utility.  However, any given component could be interested in any portion of the entire state tree.  Also, Redux only stores a reference to the state tree as a whole anyway, so that's what's returned by getState().
This is where "selector" functions come in.  Selectors generally receive the entire state as an argument, and extract some small piece out of the whole.  That way a component doesn't need to know what the entire state structure looks like - the selector is abstracting it.  Think of selectors as an "SQL-like query" for a state tree.
The Redux docs talk about selectors in http://redux.js.org/docs/recipes/ComputingDerivedData.html, and Dan discusses them in his recent "Idiomatic Redux" video series: http://redux.js.org/docs/recipes/ComputingDerivedData.html.


How to change the search hint size?

Any help will be highly appreciate!

I am not actively maintaining the project at the moment and the hint text size is fixed, so here is what you can try (I can't promise that it will play nicely but give it a try):
First obtain a reference to the EditText that is holding the query and hint (both are on the same EditText), and then set its size. Something like:
EditText editText = (EditText)mSearchView.findViewById(R.id.search_bar_text);        editText.setTextSize(getResources().getDimensionPixelSize(R.dimen.your_hint_text_size));
Keep in mind that the query text is using the same EditText, so reset it when appropriate.

Thx！


Update README with CoreOS install instructions

add in details for installing on CoreOS, refer to sample cloud-config file

+1 =)


Fix issue #249

This PR fixes #249 . The underlying issue happens to be related to ForwardDiff.jl. https://github.com/JuliaDiff/ForwardDiff.jl/issues/622 https://github.com/JuliaDiff/ForwardDiff.jl/pull/481

@bartvanerp Agreed, I've changed the PR to use multiple dispatch instead. Let's see if all tests are passing on CI.

Codecov Report
Base: 60.46% // Head: 60.94% // Increases project coverage by +0.48% :tada:

Coverage data is based on head (ad608cf) compared to base (6b5c403).
Patch coverage: 94.73% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   60.46%   60.94%   +0.48%
==========================================
  Files         194      195       +1
  Lines        7150     7134      -16
==========================================
+ Hits         4323     4348      +25
+ Misses       2827     2786      -41

Impacted Files
Coverage Δ

src/ReactiveMP.jl
75.86% <ø> (+2.52%)
:arrow_up:

src/nodes/autoregressive.jl
20.00% <ø> (ø)

src/fixes.jl
93.33% <93.33%> (ø)

src/distributions/mv_normal_mean_precision.jl
91.93% <100.00%> (ø)

...distributions/mv_normal_weighted_mean_precision.jl
98.00% <100.00%> (ø)

src/distributions/normal.jl
90.00% <100.00%> (+0.06%)
:arrow_up:

src/message.jl
30.43% <0.00%> (+0.32%)
:arrow_up:

src/node.jl
39.62% <0.00%> (+0.64%)
:arrow_up:

src/variables/constant.jl
61.90% <0.00%> (+0.92%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Syntax Highlighting: Use with <c-/> command

There is a somewhat undocumented command which is like an enhanced find-in-buffer experience, accessible via <c-/>:

It's a really cool feature! The only downside with it is that it doesn't respect syntax highlighting. I believe that with the work we have in the textmate highlighting feature, it should be possible to get syntax highlighting here.
We expose an API for querying the tokens / highlights as a syntaxHighlighter object off of he editors:
https://github.com/onivim/oni/blob/a99544bdffbceb07c86a1f8c0da614ef7c2e4f52/browser/src/Editor/NeovimEditor/NeovimEditor.tsx#L175
And that has a method for getHighlightTokenAt:
https://github.com/onivim/oni/blob/a99544bdffbceb07c86a1f8c0da614ef7c2e4f52/browser/src/Services/SyntaxHighlighting/SyntaxHighlighting.ts#L116
But, we also have the full set of tokens on the line - so it might be worth creating an API like getTokensForLine(bufferId, lineNumber) - if we had that, it should be pretty straightforward to get the token colors and show some nice syntax highlighting here 👍

The <c-/> code is mixed in with the QuickOpen functionality here:
https://github.com/onivim/oni/blob/master/browser/src/Services/QuickOpen/QuickOpen.ts
Might also be a good opportunity to refactor it out it into its own module.

@bryphe whilst working on the hover syntax highlighting I developed this which is a function that can be used to get tokens for any kind of line given some arguments.
This would definitely work quite well there, and actually given that they are all dom elements, the same system as for hover highlighting could be used there


https://technet.microsoft.com/library/dn394343(v=office.15).aspx

Broken Link.
https://technet.microsoft.com/library/dn394343(v=office.15).aspx

@khuramshahzad - I see the URL goes 404, but need additional info. Which article had this link in it?

#please-close


Reformat the code (tried to keep your settings, so just changed which was not the same everywhere in your code)

Sometimes newlines added or removed, always add line feed to the end of the file
Spaces added/removed
I tried not the change anything which was already the same everywhere.
Please let me know if you don't like any of the code style settings. Everything can be changed, I don't care what is the setting, but they should be the same everywhere.

For example:

space or no space after cast:

var remoteEndPoint = (IPEndPoint) args.ProxyClient.TcpClient.Client.RemoteEndPoint;
var remoteEndPoint = (IPEndPoint)args.ProxyClient.TcpClient.Client.RemoteEndPoint;

space in initializers:

internal static readonly char[] SpaceSplit = { ' ' };
internal static readonly char[] SpaceSplit = {' '};

Thank you:)

typo fix in pull request template
2 unused parameters removed (bufferSize, since it is already passed to the CustomBinaryReader constructor)

Doneness:

[X] Build is okay - I made sure that this change is building successfully.
[X] No Bugs - I made sure that this change is working properly as expected. It does'nt have any bugs that you are aware of.
[X] Branching - If this is not a hotfix, I am making this request against develop branch

:thumbsup:


Fail to build APK | Ubuntu 17.0 | Ironic

Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Short description of the problem:
snippetbucket@GA-78LMT-S2:~/source/ionic/todo$ ionic cordova build android  --stacktrace

cordova build android

You have been opted out of telemetry. To change this, run: cordova telemetry on.
Android Studio project detected
Running command: /home/snippetbucket/source/ionic/todo/hooks/after_prepare/010_add_platform_class.js /home/snippetbucket/source/ionic/todo
ANDROID_HOME=/home/snippetbucket/source/android-sdk_r24.2-linux/android-sdk-linux
JAVA_HOME=/usr/lib/jvm/java-8-oracle/
studio
Subproject Path: CordovaLib
Subproject Path: app
publishNonDefault is deprecated and has no effect anymore. All variants are now published.
WARNING: The specified Android SDK Build Tools version (23.0.1) is ignored, as it is below the minimum supported version (26.0.2) for Android Gradle Plugin 3.0.0.
Android SDK Build Tools 26.0.2 will be used.
To suppress this warning, remove "buildToolsVersion '23.0.1'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.
java.nio.file.AccessDeniedException: /home/snippetbucket/.android/cache/sdkbin-1_b735609c-repository2-1_xml
IOException: https://dl.google.com/android/repository/addons_list-3.xml
java.nio.file.AccessDeniedException: /home/snippetbucket/.android/cache/sdkbin-1_d29da320-addons_list-3_xml
IOException: https://dl.google.com/android/repository/addons_list-2.xml
java.nio.file.AccessDeniedException: /home/snippetbucket/.android/cache/sdkbin-1_d28f8b9f-addons_list-2_xml
IOException: https://dl.google.com/android/repository/addons_list-1.xml
java.nio.file.AccessDeniedException: /home/snippetbucket/.android/cache/sdkbin-1_d281741e-addons_list-1_xml
Failed to download any source lists!
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':CordovaLib'.

Failed to find Build Tools revision 26.0.2

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Get more help at https://help.gradle.org

BUILD FAILED in 6s
(node:11613) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: /home/snippetbucket/source/ionic/todo/platforms/android/gradlew: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':CordovaLib'.

Failed to find Build Tools revision 26.0.2

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Get more help at https://help.gradle.org

BUILD FAILED in 6s
What behavior are you expecting?
I am very new for ironic. know UI but APK generate strange ... what should I do ??
Steps to reproduce:
export ANDROID_HOME=/home/snippetbucket/source/android-sdk_r24.2-linux/android-sdk-linux
export JAVA_HOME=/usr/lib/jvm/java-8-oracle/
export PATH=$PATH:/home/snippetbucket/source/android-sdk_r24.2-linux/gradle-3.4.1-bin/gradle-3.4.1/bin
than from right folder of ironic I had fire.
ionic cordova build android
Than got reported issue. What should I do ?
insert any relevant code between the above and below backticks

Which @ionic/app-scripts version are you using?
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Have u found a solution yet?


chore: move directory creation responsibility to Makefile

This commit adds new rules to create directories and sets order only
pre-requisites to the existing rules as a way to centralise directory
creation, which is currently scattered around all the build scripts.
See: https://github.com/resin-io/etcher/pull/923#discussion_r90881453
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

I've just fixed the conflicts. @lurch Is this good to merge?


Differential operators

What do you think if we add common differential operators like \grad, \div, \rot (\curl)? The only problem I see it's collision between \div (÷) symbol and divergence operator. But division symbol is rarely used, I think we can redefine it as \divsymb [1].
[1] See \div operator: http://www.dfcd.net/articles/latex/latex.html

While I have nothing against that, I think that generally we shouldn't collect all common TeX extensions and squash them into our XML files. I'm a fan of more component-wise approach: let's split these symbols and formulae to "modules" and allow the user to choose at runtime what modules he/she wants to be enabled.

I second this!

It would be nice, yep, but let's keep it in separate packages/modules as @ForNeVeR suggests.


Crash of 2D-warp flow after retry

Missing parallelism parameter in 2D warp function induces crash when retrying the warp flow.
See last error in following flow:
00c73a2f-25d5-4d4f-9247-f5fd8b8455b7
lambda4-loval

Fix with commit e18eade.
And is part of v0.1.9 now, which is currently deployed.


Help users avoid CUDA errors when using oversized img2img inputs

When the image input is supplied, the model attempts to create an output image of the same dimensions. Users should ideally be providing square images of smaller dimensions like 512x512, but if they use an arbitrary image like a photo they took on their phone, the dimensions will be way bigger and the model will run out of memory and crash with a CUDA error.
This is not a great experience, and it's totally unclear to the user what might have gone wrong.
Possible actions
In ascending order by effort:

Update the description for the image input to give users a warning
Abort the prediction with an error if the image is too big, or not a square
Automatically crop and resize the image

Related issues/PRs

https://github.com/replicate/replicate-web/pull/3029
https://github.com/replicate/replicate-web/issues/2769

cc @anotherjesse

As a user, I would want whatever processing we do to an image to be explained to me. So if we're resizing, we should say we've done that, so someone intentionally trying to put a large image in doesn't get confused about the behaviour.

@nutlope from Vercel just ran into this and got stuck.


Add asn2gb binaries for mac and linux64

[X] This software or dataset is not more easily backed up by other systems (e.g. a conda package which could more easily be mirrored by a conda mirror)
[X] This software or dataset's license allows us to distribute it. If possible please link to it.
[X] This software or dataset is related to the sciences, galaxy, or similar areas.

NCBI Public domain software - from ftp://ftp.ncbi.nih.gov/toolbox/ncbi_tools/README.htm:

We make it freely available to the public without restriction to facilitate the use of NCBI by the scientific community

.

The 'use upstream' field is set to false since upstream is not versioned, hence may lead to a different version being returned in future

Thanks @jamesabbott!


HADOOP-18682. Move hadoop docker scripts under the main source code

Description of PR
There are special branches for running hadoop in docker
docker-hadoop-runner-latest
docker-hadoop-runner-jdk11
docker-hadoop-runner-jdk8
docker-hadoop-runner
docker-hadoop-3
docker-hadoop-2
These branches, run specific versions of hadoop. For example, branch docker-hadoop-3 runs hadoop-3.3.6.
This patch is adding a similar setup under the main source code which will be running the latest trunk. This will be useful for testing code changes and debugging. It will also make it easier for new hadoop contributors to test the project and get familiar with it.
The files were originally copied from the branch hadoop-docker-3 and were modified so that the code comes from trunk and maven builds the docker image instead of the user.
More specifically, in branch hadoop-docker-3

The Dockerfile downloads hadoop release 3.3.6 and then un-tars it inside the containers and sets it up
The user has to build the Dockerfile image before starting the docker environment

With these changes, in trunk

The user doesn't have to build the image, this is done by maven while packaging the project
Maven generates a directory hadoop-<version> under hadoop-dist/target

That directory contains the same files as a release
The compose files are placed under that location
The files from that dir are used as docker mounted volumes. That way these files are present in the containers when starting the environment and are also used for starting the services (namenode, etc.)

Jira: https://issues.apache.org/jira/browse/HADOOP-18682
How was this patch tested?
This patch was tested manually in a local env. It's adding a setup for running hadoop in docker. A README.md has been added with instruction for testing the changes locally.
I've also created a patch and tested it against trunk with dev-support/bin/test-patch /tmp/1.patch.
To test that the docker environment uses the latest code from trunk, I added a LOG prefix to this
2024-01-22 09:30:57 INFO  NameNode:1846 - createNameNode []

and then built the project again, started the docker env and checked the logs
2024-01-22 09:58:44 INFO  NameNode:1846 - xbis: createNameNode []

To test the patch locally
> mvn clean install -Dmaven.javadoc.skip=true -DskipTests -DskipShade -Pdist,src

> cd hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/compose/hadoop

> docker-compose up -d --scale datanode=3

> docker exec -it hadoop_datanode_1 bash
bash-4.2$ hdfs dfs -mkdir /test

For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@ayushtkn Can you take a look at this PR?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
yamllint
0m  0s

yamllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 55s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 14s

trunk passed

+1 :green_heart:
compile
8m 19s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
7m 30s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
mvnsite
11m 32s

trunk passed

+1 :green_heart:
javadoc
4m 39s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
4m 51s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
28m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
17m  0s

the patch passed

+1 :green_heart:
compile
8m  0s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
8m  0s

the patch passed

+1 :green_heart:
compile
7m 32s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
7m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-1 :x:
hadolint
0m  1s
/results-hadolint.txt
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
7m 15s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 32s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
4m 52s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
28m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
638m 17s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

801m  5s

Reason
Tests

Failed junit tests
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs yamllint markdownlint hadolint

uname
Linux 97f22c0771dd 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5810004edb3b85e9c3cfd63f935f3328ab59c37a

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/1/testReport/

Max. process+thread count
4640 (vs. ulimit of 5500)

modules
C: hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/1/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
yamllint
0m  0s

yamllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 57s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 28s

trunk passed

+1 :green_heart:
compile
8m 18s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
7m 35s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
mvnsite
11m 59s

trunk passed

+1 :green_heart:
javadoc
4m 38s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
4m 51s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
28m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
16m 44s

the patch passed

+1 :green_heart:
compile
8m  1s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
8m  1s

the patch passed

+1 :green_heart:
compile
7m 30s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
7m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-1 :x:
hadolint
0m  1s
/results-hadolint.txt
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
7m  1s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 32s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
5m  0s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
28m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
602m 25s
/patch-unit-root.txt
root in the patch failed.

+0 :ok:
asflicense
0m 35s

ASF License check generated no output?

764m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy

hadoop.hdfs.TestDistributedFileSystemWithECFileWithRandomECPolicy

hadoop.hdfs.server.federation.router.TestRouterRefreshSuperUserGroupsConfiguration

hadoop.hdfs.server.federation.router.TestRouterRetryCache

hadoop.hdfs.server.federation.router.TestRouterUserMappings

hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

hadoop.hdfs.server.federation.router.TestRenewLeaseWithSameINodeId

hadoop.hdfs.server.federation.metrics.TestNameserviceRPCMetrics

hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup

hadoop.hdfs.server.federation.metrics.TestRouterClientMetrics

hadoop.hdfs.server.federation.router.TestRouterNamenodeHeartbeat

hadoop.hdfs.server.federation.router.TestRouterMountTableCacheRefresh

hadoop.hdfs.server.federation.router.TestRouterMultiRack

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs yamllint markdownlint hadolint

uname
Linux 66f28dabf359 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 464c37847a3fe848a8e16fda3caf3261e3d97212

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/2/testReport/

Max. process+thread count
4561 (vs. ulimit of 5500)

modules
C: hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/2/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn Thanks for the review.

I think Ozone even builds the docker images during:

BTW, that's where I got the idea for this PR.

because we are doing stuff for docker image, not sure how much, we need to see the time diff with & without the patch....

The times I posted above, are for this branch. Let me get the times for trunk as well and post them in another comment.
Because we are mounting the dist directory as a docker volume for the containers, there isn't any extra time needed in the build other than the time we spend building the dist directory. It's not building an official hadoop image using a Dockerfile.

These are the times from my local machine. Someone with a more powerful CPU or a different OS will be getting different times but the spread, with and without the dist profile, will be analogous.

trunk

Without -Pdist

> mvn clean install -Dmaven.javadoc.skip=true -DskipTests -DskipShade
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:06 min

With -Pdist

> mvn clean install -Dmaven.javadoc.skip=true -DskipTests -DskipShade -Pdist,src
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:49 min

this branch

Without -Pdist

> mvn clean install -Dmaven.javadoc.skip=true -DskipTests -DskipShade
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:34 min

With -Pdist

> mvn clean install -Dmaven.javadoc.skip=true -DskipTests -DskipShade -Pdist,src
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:30 min

Without the dist profile, docker is still built but there are no dist files to be used for the containers and therefore starting the environment will fail.

Thanx @xBis7 for the details. I haven't tried the code locally yet, but on a quick look, it looks fine.
If @jojochuang is convinced, it is good with me

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
25m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
yamllint
0m  0s

yamllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 47s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 46s

trunk passed

+1 :green_heart:
compile
16m 26s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
15m  4s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
mvnsite
18m 16s

trunk passed

+1 :green_heart:
javadoc
8m 29s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 37s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
47m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 43s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
29m 27s

the patch passed

+1 :green_heart:
compile
15m 46s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
15m 46s

the patch passed

+1 :green_heart:
compile
14m 55s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
14m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-1 :x:
hadolint
0m  1s
/results-hadolint.txt
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
13m 57s

the patch passed

+1 :green_heart:
shellcheck
0m  1s

No new issues.

+1 :green_heart:
javadoc
8m 18s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 32s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
shadedclient
50m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
747m 37s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 35s

The patch does not generate ASF License warnings.

1048m 28s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient xmllint shellcheck shelldocs yamllint hadolint

uname
Linux 5c2310990dcf 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 03d600f0a51e9cefa7282856215c77e63196583b

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/3/testReport/

Max. process+thread count
3913 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/3/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @jojochuang any comments on this?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 02s

No case conflicting files found.

+0 :ok:
codespell
0m 02s

codespell was not available.

+0 :ok:
detsecrets
0m 02s

detect-secrets was not available.

+0 :ok:
markdownlint
0m 02s

markdownlint was not available.

+0 :ok:
xmllint
0m 00s

xmllint was not available.

+0 :ok:
shellcheck
0m 01s

Shellcheck was not available.

+0 :ok:
shelldocs
0m 01s

Shelldocs was not available.

+0 :ok:
yamllint
0m 01s

yamllint was not available.

+0 :ok:
hadolint
0m 01s

hadolint was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m 00s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
4m 56s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
108m 15s

trunk passed

+1 :green_heart:
compile
47m 52s

trunk passed

-1 :x:
mvnsite
28m 48s
/branch-mvnsite-root.txt
root in trunk failed.

+1 :green_heart:
javadoc
19m 14s

trunk passed

+1 :green_heart:
shadedclient
390m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
5m 06s

Maven dependency ordering for patch

-1 :x:
mvninstall
3m 08s
/patch-mvninstall-hadoop-dist.txt
hadoop-dist in the patch failed.

+1 :green_heart:
compile
48m 07s

the patch passed

+1 :green_heart:
javac
48m 07s

the patch passed

+1 :green_heart:
blanks
0m 01s

The patch has no blanks issues.

-1 :x:
mvnsite
28m 00s
/patch-mvnsite-root.txt
root in the patch failed.

+1 :green_heart:
javadoc
19m 56s

the patch passed

+1 :green_heart:
shadedclient
232m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
7m 47s

The patch does not generate ASF License warnings.

813m 26s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient xmllint shellcheck shelldocs yamllint hadolint

uname
MINGW64_NT-10.0-17763 34cb8b2b35a4 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 03d600f0a51e9cefa7282856215c77e63196583b

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6483/1/testReport/

modules
C: hadoop-common-project/hadoop-common hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6483/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@xBis7 the compilation is failing in your PR,

Instead of building hadoop image with "snapshot" version, why not use hadoop-runner with bind mounts?  The former may result in lots of throwaway images locally.

why not use hadoop-runner with bind mounts?

@adoroszlai you are right. Now that I'm going over this PR again, it can be simplified. All we need is a base image and to mount the generated distribution files.
Is there a way to run the CI locally before pushing to the PR?

I tried it locally and it looks like it's working like that

why not use hadoop-runner with bind mounts?

❯ docker image ls | grep hadoop
apache/hadoop-runner                                 docker-hadoop-3   0bcc0ce3086d   5 years ago     1.06GB

The -SNAPSHOT is only appended for the project version, not the image.
Also, the build succeeds.

@adoroszlai I updated the README and also changed the hadoop-runner version as suggested. I tested it locally and there are no issues.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+0 :ok:
yamllint
0m  1s

yamllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
18m 57s

trunk passed

-1 :x:
compile
0m 20s
/branch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

+1 :green_heart:
compile
8m 31s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
mvnsite
15m 24s

trunk passed

+1 :green_heart:
javadoc
5m 40s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
4m 59s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
30m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
20m  9s

the patch passed

-1 :x:
compile
0m 14s
/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javac
0m 14s
/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

+1 :green_heart:
compile
8m 13s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
8m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  1s

No new issues.

+1 :green_heart:
mvnsite
10m 35s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
5m 26s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
5m  0s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
31m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
638m 41s

root in the patch passed.

+1 :green_heart:
asflicense
1m  8s

The patch does not generate ASF License warnings.

807m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient xmllint shellcheck shelldocs yamllint hadolint

uname
Linux cd0fd39ca20a 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1343de866d156e06e8d0e962be6ca4e363d45fc5

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/5/testReport/

Max. process+thread count
4118 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/5/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+0 :ok:
yamllint
0m  1s

yamllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 39s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 31s

trunk passed

-1 :x:
compile
0m 26s
/branch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

+1 :green_heart:
compile
18m 17s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
mvnsite
26m 34s

trunk passed

+1 :green_heart:
javadoc
10m 39s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
8m  1s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
57m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 45s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
35m 46s

the patch passed

-1 :x:
compile
0m 26s
/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javac
0m 26s
/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

+1 :green_heart:
compile
17m 43s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
17m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  0s

No new issues.

+1 :green_heart:
mvnsite
19m 41s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
10m 31s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
7m 56s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
58m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
808m 31s

root in the patch passed.

+1 :green_heart:
asflicense
1m 40s

The patch does not generate ASF License warnings.

1117m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient xmllint shellcheck shelldocs yamllint hadolint

uname
Linux c90eaab50e78 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 08987d1cdff8a6fd49e324498b59d25e0d4dac6d

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/6/testReport/

Max. process+thread count
3692 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/6/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 24s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+0 :ok:
yamllint
0m  1s

yamllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m  6s

trunk passed

-1 :x:
compile
0m 27s
/branch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

+1 :green_heart:
compile
16m 24s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
mvnsite
22m 16s

trunk passed

+1 :green_heart:
javadoc
9m 55s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
8m  3s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
51m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 47s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
30m 48s

the patch passed

-1 :x:
compile
0m 26s
/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javac
0m 26s
/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

+1 :green_heart:
compile
15m 56s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
15m 56s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  0s

No new issues.

+1 :green_heart:
mvnsite
18m 40s

the patch passed

+1 :green_heart:
shellcheck
0m  1s

No new issues.

+1 :green_heart:
javadoc
9m 51s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
8m  5s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
53m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
763m 12s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 43s

The patch does not generate ASF License warnings.

1037m  1s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload

hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient xmllint shellcheck shelldocs yamllint hadolint

uname
Linux bf430c5e969a 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 43ff443fa4b74dffdfa232d59457ec8636a5635c

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/7/testReport/

Max. process+thread count
3904 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/7/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  2s

Shelldocs was not available.

+0 :ok:
yamllint
0m  2s

yamllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 56s

trunk passed

+1 :green_heart:
compile
20m 16s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
18m 46s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
mvnsite
26m 21s

trunk passed

+1 :green_heart:
javadoc
10m  6s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
8m 20s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
53m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 47s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
32m 53s

the patch passed

+1 :green_heart:
compile
19m 10s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
19m 10s

the patch passed

+1 :green_heart:
compile
18m 16s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
18m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  1s

No new issues.

+1 :green_heart:
mvnsite
19m 58s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
10m  3s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
8m 23s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
56m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
32m 11s
/patch-unit-root.txt
root in the patch failed.

+0 :ok:
asflicense
0m 32s

ASF License check generated no output?

352m  4s

Reason
Tests

Failed junit tests
hadoop.portmap.TestPortmap

hadoop.metrics2.source.TestJvmMetrics

hadoop.ipc.TestCallQueueManager

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6483

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient xmllint shellcheck shelldocs yamllint hadolint

uname
Linux 6ee16f60d652 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7a281026100bfa6c1950ca22c411113daedb3104

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/8/testReport/

Max. process+thread count
786 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-dist . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6483/8/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

test failures doesn't look related, some OOM related.
@adoroszlai does this look good now?

does this look good now?

Looks good.  Since the new docker-build profile is optional, I think it's safe to merge it.

Thanx @xBis7 & @adoroszlai

Thanks @ayushtkn @adoroszlai for the help!


Add Capability to retrieve Custom KeyStores

Purpose

This PR adds the feature to retrieve custom keystores from the KeyStoreManager class.
Custom KeyStores can be configured in the Carbon.xml file which can then be retrieved using KeyStoreManager

deployment.toml configuration
[[keystore.custom]]
file_name = "custom.jks"
password = "custom"
type = "JKS"
alias = "custom"
key_password = "custom"

Problem Statement: wso2-enterprise/iam-product-management#67
Public Git Issue: wso2/product-is#20564

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10191907178

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10191907178
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10296190570

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10296190570
Status: success

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10313768488

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10313768488
Status: success


Feature Request: Port the rapier repo's ray_cast_vehicle_controller to bevy_rapier

It would be great to have a vehicle controller built into bevy_rapier.
The rapier repo already has one here. The character controller has already been brought over so it makes sense to also bring over the vehicle controller.

was there any progress on this in last 1.5 years?
I'd like to have vehicle controller for Bevy for my project, so I wonder if I should implement rapier integration myself, or maybe someone has a working demo


scratch scope is broken?

Hello up there. If I try to use the following program:
kprobe::vfs_open {
        $h = 0;
}

kretprobe::vfs_open {
        $h = 1;
}

(note $h is used in both probes), bpftrace gives the following unhelpful message (hard to diagnose what is going in a real program):
root@deco:# bpftrace test.bt
error: <unknown>:0:0: in function kretprobe:vfs_open i64 (i8*): A call to built-in function 'abort' is not supported.

However if I change $h in the second probe to e.g. $g - it works:
kprobe::vfs_open {
        $h = 0;
}

kretprobe::vfs_open {
        $g = 1;
}

root@deco# bpftrace test.bt
Attaching 2 probes...
^C

So it seems scope handling for scratch variables is not correct and it overlaps between probes in unexpected way.
Thanks beforehand,
Kirill

Thanks, this is #380, closing. Yes, we need to fix #380!

Thanks for feedback.


Github Actions not running configure tests

Some syntax error in the actions config it seems.
https://github.com/zlib-ng/zlib-ng/actions/runs/36026785

This can be closed now.


BehaviorSubject does not seem to use its initialValue (RC3, scala.js)

I was trying to upgrade a Scala.js project from 1.0-M2 to 1.0-RC3, and it seems the semantics of BehaviorSubject have changed between the two versions. The following would print the initialValue on M2, but does not on RC3:
val subject = monifu.reactive.subjects.BehaviorSubject[Int](10)
subject.foreach(println)

My use case is actually to transform an Observable into a state machine which can always give its current state (even when the source has not emitted a first element). For example let's say I have some Observable of clicks and I want a shared switch:
val clicks = PublishSubject[Unit]()

val switch: Observable[Boolean] = {
  val connectable = clicks.scan[Boolean](false) { case (old, _) => !old }.behavior(false)
  connectable.connect()
  connectable
}

It is possible to simply use a BehaviorChannel and pushNext the initial state. But had I the semantics of BehaviorSubject wrong or is it is a bug ?

Yes, the semantics have changed, however this will get reverted. Thanks for reporting it and please have patience while I fix it. Will happen sometime this week.

Ok thanks !

As an aside- this issue appears to have started in M11, so until this fix is released, users can still upgrade to M10.

There is also a problem in Scala version (not scala.js). It occurs when source Observable for behavior subject is not completed. The first code snippet does not print anything but second works ok.
  test("Behavior with uncompleted source") {
    val obs = PublishChannel[String](Unbounded).behavior("init")
    obs.connect()
    obs.foreach(s => println(s)) // expected to print "init" but prints nothing.
  }

  test("behavior with completed source") {
    val obs = Observable().behavior("init")
    obs.connect()
    obs.foreach(s => println(s)) // prints "init"
  }

@sikor, @mseddon, @niladic - guys, I'm sorry for keeping you waiting. This issue is now fixed.
The history of this problem is that I've been very enthusiastic about my new way of synchronizing subjects in a wait-free fashion that I've broken the contract of BehaviorSubject and of ReplaySubject without noticing it. Should I ever break this contract again, it should be caught by tests.
The behavior of BehaviorSubject and that of ReplaySubject is now fixed and should work both on top of the JVM and on top of JS.  I have released version 1.0-M4 of Monifu.
Please try it out and let me if you are experiencing any more problems.

Thanks @alexandru! I will check this out tomorrow.  I know how it is to be dragged away by work :)


Update OpenSSL Config for ripemd160

What was wrong?

OpenSSL 3 removed ripemd160 functions from the default behavior. Instead they now have to be locally configured. This broke a lot of blockchain related logic and they decided to add it back in in version 3.0.7, see blog post here.

CircleCI is using openssl3 but not (yet?) the latest version. Since this breaks tests even on master, which were previously passing, we need to update the config for now until the newer open ssl version is used in the circleci images.

How was it fixed?

For now, updating the openssl config just works™ and we can ideally remove it when the images are updated.
Config changes suggested, among other places, here

Todo:

[x] Clean up commit history
[x] Add entry to the release notes

Cute Animal Picture

Note: I emailed circleci support to ask where we can track the openssl version on the Python images. I will update here when I get a response but for now we can watch the version printed via the build step.


[Request] Total Cover CE

DFred's CE already has Cover (Half) and Cover (Three-Quarters). A Cover (Total) would be really nice for modules like Alternative Token Visibility's cover calculator.
Cover (Total) could just have the active effect: flags.midi-qol.grants.attack.fail.all

Great idea! Added and it'll be out in the next release

@caewok this might be of interest to you as well ;)

Thanks! I am in the process of updating Alt. Token Vision. Once you release your next update, I will update ATV accordingly to use DCE's total cover.


error: inline assembly requires more registers than available

Hi all,
Thanks for the great project. I'm trying to compile it on a 2018 Macbook Pro, and I keep getting the following error:
error: inline assembly requires more registers than available

error: could not compile `halo2curves` (lib) due to 1 previous error

even when I try cargo build --release --features portable. Interestingly, debug mode does not cause this problem and everything succeeds. Is there something else I should do to prevent emission of unsupported assembly?
At the same time, trying to compile on a linux box, compilation succeeds, but the lurk repl immediately fails with an illegal instruction. I suspect I am failing to disable some kind of unsupported optimization, but does anyone have any pointers? In this second case, even debug mode results in the illegal instruction. Any thoughts?

even when I try cargo build --release --features portable. Interestingly, debug mode does not cause this problem and everything succeeds. Is there something else I should do to prevent emission of unsupported assembly?

This is about halo2curves' assembly generation: https://github.com/privacy-scaling-explorations/halo2curves/blob/main/Cargo.toml#L49
This is only activated if one imports arecibo with the non-default asm feature:
https://github.com/lurk-lab/arecibo/blob/5268c2084821955c5953c29c7e179b2052523b5d/Cargo.toml#L116
Which happens here in your case because your 2018 Mac is on x86_64:
https://github.com/lurk-lab/lurk-rs/blob/8802da5c85d26129167c3ba7ef4e7ed22f56707a/Cargo.toml#L72-L73
So I guess this is about modifying the flag
[target.'cfg(target_arch = "x86_64")'.dependencies]
into
[target.'cfg(and(target_arch = "x86_64", not(target_os = "macos")))'.dependencies]
Can you try that and tell me if it works for you?

Hi, thanks for the fix. I changed the line you mentioned to these two:
[target.'cfg(all(target_arch = "x86_64", not(target_os = "macos")))'.dependencies]
nova = { workspace = true, features = ["asm"] }
[target."cfg(all(target_arch = \"x86_64\", target_os = \"macos\"))".dependencies]
nova = { workspace = true }

And the build works. I think the syntax uses all rather than and and I needed to add another target for x86 + macos.


Add more context to the title of deletion modals

Adds the resource types "namespace", "cluster", "project" as
additional context to the titles of the respective deletion modals
in order to reduce the likelyhood of a user accidentally deleting
an unintented resource.

We changed the title from "Are you sure you want to delete" to
"Are you sure you want to delete the namespace:" with namespace
being bold. The same is true for cluster and project as well.

rancher/rancher#17619

The change where the deletion occurs on a namespace resource type:

The change where the deletion occurs on a project resource type:

The change where the deletion occurs on a cluster resource type:

The change where the deletion occurs on a non-elevated resource type:

This wasn't really well described in the issue, but seems like the bold message should be shown for deleting namespaces or "higher" (project, cluster).  And show for all namespaces, not just the system one.  (System gets the extra info banner, which still makes sense).

I've removed the system constraint for namespace modals.
I've added project and cluster to this change. I failed to find an enumeration of resource types to judge for myself but if there are any additional resource types I should add feel free to let me know.

Don't use "fixes #x" / "resolves #x" / etc; Issues get moved to QA once merged (the [zube]: To Test label) and then they close it once validated.  Linking to the issue in the PR is good though, the person merging it will go through the issue links and move their label.

I've removed resolves and left the issue link.

We don't normally do the translations (other than en-us).  zh-* are maintained by our team in China as their own PRs, for all the others https://translate.rancher.com is the source of truth and they are synced into github

I didn't provide any translations beyond en-us. I did change a string id which I carried through.

Oops I missed that only the key changed on the translations.. 👍


Unable to connect paired bluetooth device

It asks to make pair for unpaired devices but gives "error while connecting to the device" after pairing.
Environment
react: "16.9.0",
react-native: "^0.63.3"
react-native-bluetooth-escpos-printer: "0.0.5"

Im having the same problem

Did anyone find solution to this i am having the same problem

Im having the same problem

I'm having the same problem on react native 0.68