Review new pseudocode for random floating-point numbers in an arbitrary range

I have updated the Uniform Random Real Numbers section of my page, "Random Number Generation and Sampling Methods", to include new pseudocode for a method to generate random floating-point numbers in an arbitrary range.  This time, however, the method—

covers all representable numbers in the range,
avoids generating intermediate random floating-point numbers, and
is generalizable to floating-point numbers of any (fixed) precision and non-binary floating-point numbers.

This is thanks to work by Downey in 2007 and @christoph-conrads with the Rademacher Floating-Point Library.
Please review this method to see if I have specified the method correctly, and report any errors you find in this issue thread.

RNDRANGE: Interval [a, b].

if lo<0 and hi>0

You need to check the signbit because your interval might be [-0, +0]: if signbit(lo) == 1 and signbit(hi) == 0.

   if ret==0 and neg==0: continue

From the code below I gather you want to implement round-toward-zero semantics (like in Rademacher FPL). Then this line must be removed because with rounding toward zero, -0 and +0 must be treated as different numbers.
Think of it this way: every floating-point number x in [a,b] has a weight w(x) and the probability of x is w(x) divided by the sum of all weights. With round-toward zero semantics and with signbit(x) == 0, the weight is the distance from x to the next larger floating-point number y. With signbit(x) == 1, you can exploit symmetry and take the next smaller floating-point number which will be -y.

   if ret>=lo and ret<hi: return ret

You seem to return values from a half-open interval here but the documentation above promises values from a closed interval.

 if v==0: ex-=1
 break

I assume this is meant to be read as if v == 0 then ex = -1; break; endif (Downey's exponent drawing).

   if ex==MINEXPONENT
     s=RNDINTEXC(pow(FPRADIX,FPPRECISION))
   else
     sm=pow(FPRADIX,FPPRECISION-1)
     s=RNDINTEXC(sm)+sm

Base-2 Floating-point numbers have for every exponent the same number of significand digits but for normal floats (normal in contrast to a denormal float) we know the represented number is not zero so during calculations we pretend the most significand bit equals one but this bit is never stored. Consequently...

FPPRECISION is the number of significant digits in the floating-point format. Equals 53 for binary64, or 24 for binary32.

you only have to draw from 52 significand bits for binary64 and 23 significand bits for binary32, irrespective of the choice of exponent.

The sample code for RNDRANGE really is intended to produce numbers in the interval [a, b], closed in both ends.  This is done to ease the definition of the other seven methods in the RNDRANGE and RNDU01 families, given in my article.

Thank you for your review.

Base-2 Floating-point numbers have for every exponent the same number of significand digits but for normal floats (normal in contrast to a denormal float) we know the represented number is not zero so during calculations we pretend the most significand bit equals one but this bit is never stored. Consequently...

FPPRECISION is the number of significant digits in the floating-point format. Equals 53 for binary64, or 24 for binary32.

you only have to draw from 52 significand bits for binary64 and 23 significand bits for binary32, irrespective of the choice of exponent.

Implementing this may complicate the method, which is intended to apply to floating-point formats without an implied high digit (such as decimal64 and decimal128) just as well as to formats with an implied high digit (such as binary64 and binary32).

Section was updated.

Closed because I no longer need a review.  Comments on my Randomization and Sampling Methods article are still welcome, though.


Swiper does not work in production, and it does not show any error

Check that this is really a bug

[X] I confirm

Reproduction link
https://github.com/Nefcanto/QwikSwiperBuild
Bug description
I"m using Swiper JavaScript version in my Qwik projects.
It works in the development mode. But when I deploy it to the production, it does not work.
I also reported this problem to the Qwik team.
I don't know if it's your bug or their bug. I can't find out. Thus I posted to both teams.
Expected Behavior
Swiper JavaScript version works in the production environment, or gives a descriptive error on why it does not work
Actual Behavior
Swiper JavaScript version does not work in production build and it prints no error
Swiper version
9.2.0
Platform/Target and Browser Versions
Debian 11, Qwik 0.100.0, Chrome 111
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Hi, I have a same problem
Here are my test with get started steps: https://codesandbox.io/s/swiper-test-82167s
Don't show any error on logs... so I thing it's a bug

@OsirisFrik
Check this example
https://codesandbox.io/s/swiper-test-forked-n2qmgo

Check that this is really a bug

[x]  I confirm

Reproduction link
https://github.com/Nefcanto/QwikSwiperBuild
Bug description
I"m using Swiper JavaScript version in my Qwik projects.
It works in the development mode. But when I deploy it to the production, it does not work.
I also reported this problem to the Qwik team.
I don't know if it's your bug or their bug. I can't find out. Thus I posted to both teams.
Expected Behavior
Swiper JavaScript version works in the production environment, or gives a descriptive error on why it does not work
Actual Behavior
Swiper JavaScript version does not work in production build and it prints no error
Swiper version
9.2.0
Platform/Target and Browser Versions
Debian 11, Qwik 0.100.0, Chrome 111
Validations

[x]  Follow our Code of Conduct
[x]  Read the docs.
[x]  Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[x]  Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ]  I'm willing to open a PR

Looks like issue from Qwik on how they attach event listeners

Any updates? I upgraded Swiper version from 6 to 9.2.4 because of the centered pinch focus when zooming in and out, and it perfectly works in local but not works only in production without any runtime errors.

Did anyone solve this?

I have the same problem too. it works in local but not works in production.

I have the same problem too. it works in local but not works in production.

I needed up using nuka-carousel. You should check it out


Renaming projects

From @pjotrp on June 27, 2014 9:8
When you rename a project on github you lose all existing issues!
Copied from original issue: domitry/nyaplot#1

From @pjotrp on June 27, 2014 9:12
Woops - I looked in the wrong place!

This issue was moved to lokeshh/nyaplot-domitry#1


Update package.json

updated the peer dependency, I don't know for what peer dependency stands for, but because of that when I install your package it's showing me warnings

The versions are meant to be loose, not exact, so that it covers better semver range.
Peer dependencies are meant to be dependencies that the user has to install.
I think the problem here is that auto-animate is still not covered by the given semver range due to its alpha/beta flag, however I don't know what's a good workaround for that.
I'm sorry but I have to close this issue, don't worry I'll try to come up with the semver issue.


Fix peerDependencies of<EMAIL_ADDRESS>

closes issue #972
changed peerDependencies,
"@formio/js": "^5.0.0" to "@formio/js": "^5.0.0-rc.18" which was causing the issue #972
and
"zone.js": "~0.11.4 || ~0.12.0" to "zone.js": "^0.13.0" which was also hindering npm install<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

This will get fixed with the latest release coming today.


Fixes rendering bug in Epoch.Time.Heatmap

At the top of the Epoch.Time.Heatmap.redraw there is a series of checks that ensures the chart has data before fully redrawing chart. It was erroneously inspecting the @data member when ensuring that the first layer had actual values to display.

@jamesarosen - Can you take a look at this and make sure I am not mad? Also, if you have any suggestions for how to clean up that line to make it more readable, I am entirely comprised of ears.

How about
isNonEmptyArray = (ary) ->
  Epoch.isArray(ary) and ary.length > 0

redraw: ->
  return unless isNonEmptyArray(@data) and<EMAIL_ADDRESS>

Ooh, good call, could probably put that in Epoch.Util. Updates en route.

@jamesarosen - That should do it, thoughts?

+1

Yeah, while non-empty is a double negative, I think it is used quite often to describe the test. An alternative would be to replace it with not Epoch.isEmptyArray(ary) but that just seems to make the test less clear. Should be good to go, from my perspective.


Train FIA: Generic error in expression

Pressing the "Train FIA" button in the HQ flag dialog gives "Generic error in expression".
This is the file where the error occurs I think
Tried adding a semicolon, havent helped. Its beyond me unfortunately.

This can be fixed by changing:
BTN_R(2,109, "Train FIA", "Increase HR capacity and FIA skill", "[] remoteExec [""fnc_BE_buyUpgrade"", 2]");
To:
BTN_R(2,109, "Train FIA", "Increase HR capacity and FIA skill", "call fnc_BE_buyUpgrade;");

The function fnc_BE_buyUpgrade is server side, which is why we use remoteExec[,2]. It is odd that it crashes with remoteExec. Do you have the error full message on the error (RTS file)?

Yeah I thought so, but just wanted to make it work for me. I will try to provide the .rpt byt iam currently out of town. It should be reproducable easy enough though.


Fix setup.py version

Set the next expected version

[Current coverage][cc-pull] is 100%

Merging [#15][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #15   diff @@
===================================
  Files           5     5
  Lines          71    71
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           71    71
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [6114acc...3861e1e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/kpn-digital/py-timeexecution/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/kpn-digital/py-timeexecution/compare/6114acc7c89fd7faff8b08b172e675194bbbcfb0...3861e1e702769eb146cebe8f02dd02f237a938ac
[cc-pull]: https://codecov.io/gh/kpn-digital/py-timeexecution/pull/15?src=pr


DS-3719: Trying to fetch unqualified metadata fields via REST fails a…

…lso in 6.x
Same change as in master branch PR 1868

Closing this due to commit spam trying to meet code style requirements. Reopened as PR 2007.


Sdpaint error

im running a 3090 with this i installed it inside my automic1111 directory - enabled control net to run scripts,  set it to run in api mode, updated control net, verified scribble model,  running into this error "venv "C:\Super_SD\stable-diffusion-webui\venv\Scripts\Python.exe"
Python 3.10.5 (tags/v3.10.5:f377153, Jun  6 2022, 16:14:13) [MSC v.1929 64 bit (AMD64)]
Commit hash: 0cc0ee1bcb4c24a8c9715f66cede06601bfc00c8
Installing requirements for Web UI
automic111 terminal error -----------------------------------------------------------------------------------
Launching Web UI with arguments: --no-half --api
No module 'xformers'. Proceeding without it.
python_server_full_path:  C:\Super_SD\stable-diffusion-webui\extensions\Auto-Photoshop-StableDiffusion-Plugin\server/python_server
[AddNet] Updating model hashes...
0it [00:00, ?it/s]
[AddNet] Updating model hashes...
0it [00:00, ?it/s]
Loading weights [9aba26abdf] from C:\Super_SD\stable-diffusion-webui\models\Stable-diffusion\deliberate_v2.safetensors
Creating model from config: C:\Super_SD\stable-diffusion-webui\configs\v1-inference.yaml
LatentDiffusion: Running in eps-prediction mode
DiffusionWrapper has 859.52 M params.
Applying cross attention optimization (Doggettx).
Textual inversion embeddings loaded(9): advntr, bad-artist-anime, bad-artist, bad-hands-5, bad-image-v2-39000, EasyNegative, emb-rrf2, eonn, ng_deepnegative_v1_75t
Textual inversion embeddings skipped(3): nartfixer, nfixer, nrealfixer
Model loaded in 2.9s (create model: 0.5s, apply weights to model: 0.6s, move model to device: 1.0s, load textual inversion embeddings: 0.8s).
Deforum ControlNet support: enabled
Running on local URL:  http://<IP_ADDRESS>:7860
To create a public link, set share=True in launch().
[ControlNet] warning: using deprecated '/controlnet/txt2img' route
[ControlNet] warning: consider using the '/sdapi/v1/txt2img' route with the 'alwayson_scripts' json property instead
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\anyio\streams\memory.py", line 94, in receive
return self.receive_nowait()
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\anyio\streams\memory.py", line 89, in receive_nowait
raise WouldBlock
anyio.WouldBlock
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\base.py", line 77, in call_next
message = await recv_stream.receive()
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\anyio\streams\memory.py", line 114, in receive
raise EndOfStream
anyio.EndOfStream
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\uvicorn\protocols\http\h11_impl.py", line 407, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\uvicorn\middleware\proxy_headers.py", line 78, in call
return await self.app(scope, receive, send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\fastapi\applications.py", line 271, in call
await super().call(scope, receive, send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\applications.py", line 125, in call
await self.middleware_stack(scope, receive, send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\errors.py", line 184, in call
raise exc
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\errors.py", line 162, in call
await self.app(scope, receive, _send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\base.py", line 104, in call
response = await self.dispatch_func(request, call_next)
File "C:\Super_SD\stable-diffusion-webui\modules\api\api.py", line 96, in log_and_time
res: Response = await call_next(req)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\base.py", line 80, in call_next
raise app_exc
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\base.py", line 69, in coro
await self.app(scope, receive_or_disconnect, send_no_error)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\gzip.py", line 24, in call
await responder(scope, receive, send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\gzip.py", line 44, in call
await self.app(scope, receive, self.send_with_gzip)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\exceptions.py", line 79, in call
raise exc
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\middleware\exceptions.py", line 68, in call
await self.app(scope, receive, sender)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\fastapi\middleware\asyncexitstack.py", line 21, in call
raise e
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\fastapi\middleware\asyncexitstack.py", line 18, in call
await self.app(scope, receive, send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\routing.py", line 706, in call
await route.handle(scope, receive, send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\routing.py", line 276, in handle
await self.app(scope, receive, send)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\routing.py", line 66, in app
response = await func(request)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\fastapi\routing.py", line 237, in app
raw_response = await run_endpoint_function(
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\fastapi\routing.py", line 165, in run_endpoint_function
return await run_in_threadpool(dependant.call, **values)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\starlette\concurrency.py", line 41, in run_in_threadpool
return await anyio.to_thread.run_sync(func, *args)
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\anyio\to_thread.py", line 31, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\anyio_backends_asyncio.py", line 937, in run_sync_in_worker_thread
return await future
File "C:\Super_SD\stable-diffusion-webui\venv\lib\site-packages\anyio_backends_asyncio.py", line 867, in run
result = context.run(func, *args)
File "C:\Super_SD\stable-diffusion-webui\extensions\sd-webui-controlnet\scripts\api.py", line 99, in controlnet_txt2img
return self.controlnet_any2img(
File "C:\Super_SD\stable-diffusion-webui\extensions\sd-webui-controlnet\scripts\api.py", line 115, in controlnet_any2img
alwayson_scripts = dict(any2img_request.alwayson_scripts)
AttributeError: 'ControlNetStableDiffusionProcessingTxt2Img' object has no attribute 'alwayson_scripts'"
sdpaint error
WARNING: You are using pip version 22.0.4; however, version 23.1 is available.
You should consider upgrading via the 'C:\Super_SD\sd_livepaint\SdPaint\venv\Scripts\python.exe -m pip install --upgrade pip' command.
pygame 2.3.0 (SDL 2.24.2, Python 3.9.13)
Hello from the pygame community. https://www.pygame.org/contribute.html
Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Super_SD\sd_livepaint\SdPaint\venv\lib\site-packages\requests\models.py", line 971, in json
return complexjson.loads(self.text, **kwargs)
File "C:\Users\andre\anaconda3_\lib\json_init_.py", line 346, in loads
return default_decoder.decode(s)
File "C:\Users\andre\anaconda3\lib\json\decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=w(s, 0).end())
File "C:\Users\andre\anaconda3\lib\json\decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\andre\anaconda3_\lib\threading.py", line 980, in bootstrap_inner
self.run()
File "C:\Users\andre\anaconda3\lib\threading.py", line 917, in run
self._target(*self._args, **self._kwargs)
File "C:\Super_SD\sd_livepaint\SdPaint\Scripts\SdPaint.py", line 91, in send_request
r = response.json()
File "C:\Super_SD\sd_livepaint\SdPaint\venv\lib\site-packages\requests\models.py", line 975, in json
raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

same error here too

ah just update sd-web-ui and controlnet


Feature/fix#1 update to swift 3

Used Xcode 8 tooling to perform automatic update.
Then made manual adjustments.
Removed the Carthage, RxSwift related artefacts as not relevant to this Playground

Fixes #1


Trivial addition of app-site association check

Similar to robots.txt, easy to add, and not included in Burp as per https://portswigger.net/kb/issues
See: https://www.nccgroup.trust/us/about-us/newsroom-and-events/blog/2019/april/apples_app_site_association_the_new_robots_txt/
and portswiggers own: https://portswigger.net/daily-swig/apples-app-site-association-creates-info-leak-risk

Looks good, thanks!


JSON API RC3 tracking

Hey there! I just wanted to let you know that JSON API has hit RC3, and we'd like client libraries to start implementing it like it was 1.0, as a final check that we're good for 1.0. I wanted to make this issue to let you know!
https://github.com/json-api/json-api/issues/484

Copy that, Steve!  I'm already working on it!

Closing as this now is working on 1.0 compatibility.


Unsupported Terraform Core version issue

Hi, I was following the README under the "controller" directory. I cloned the repository and performed:
cd oci-quickstart-aviatrix/controller/simple`
terraform init

It at first looked fine but then hits the error as described in the title:
Initializing modules...
Downloading github.com/oracle/oci-quickstart-aviatrix/controller/terraform-modules/network-security-groups for default_network_sec_group...
- default_network_sec_group in .terraform/modules/default_network_sec_group/controller/terraform-modules/network-security-groups
Downloading github.com/oracle/oci-quickstart-aviatrix/controller/terraform-modules/vcn-plus-subnet-default for default_vcn_plus_subnet...
- default_vcn_plus_subnet in .terraform/modules/default_vcn_plus_subnet/controller/terraform-modules/vcn-plus-subnet-default
Downloading github.com/oracle/oci-quickstart-aviatrix/controller/terraform-modules/marketplace for subscribe_to_marketplace...
- subscribe_to_marketplace in .terraform/modules/subscribe_to_marketplace/controller/terraform-modules/marketplace
- subscribe_to_marketplace.image_listing in .terraform/modules/subscribe_to_marketplace/controller/terraform-modules/marketplace/listings
- subscribe_to_marketplace.subscribe_to_listing in .terraform/modules/subscribe_to_marketplace/controller/terraform-modules/marketplace/subscription

Error: Unsupported Terraform Core version

This configuration does not support Terraform version 0.12.9. To proceed,
either choose another supported Terraform version or update the root module's
version constraint. Version constraints are normally set for good reason, so
updating the constraint may lead to other errors or unexpected behavior.

Please advise. Thanks!

Current code is based on Terraform 0.11. You can use a tool like terraform-switcher to switch between TF 0.11 and 0.12 while we don't migrate the code to 0.12.


Compare performance with columnify

Comparing performance with the prior implementation, columnify.

Our approach is faster than columnify!
BTW, we can't use benchmark-driver's memory benchmark feature... It doesn't care about external process...

It doesn't care about external process...

Oh, I see...  I'll consider removing the memory benchmark and providing a practical benchmark repository for E2E. Like this.


MathJax error in user report

Replace the text below with the details of the issue you are facing.
DO NOT simply erase the form and type a free-form response.
Issue Summary
MathJax error in the reports dashboard, with Uncanny and Tincanny reports.
Its eems fine in the learndash quiz but not in the detailed reports for all users.
\ (1) \ begin {equation} M=24{2} \times 3 \times 5^{2} \quad N=24{3} \times 3^{2} times 7 \end{equation}(1) Find the largest number that divides exactly into M and N.
Please suggest how to fix this.
Thanks

There is no enough information in your report to diagnose the problem.  E.g., what version of MathJax are you using? What is the error message that you received?
Also, the expression you give looks like it might include some typos (e.g., \ begin rather than \begin).
In any case, since it works in the quiz setting but not the other reports, it is more likely an issue with how MathJax is integrated into those reports rather than an issue with MathJax itself, so you may want to report the problem to the maintainers of those plugins.


Subscriber never gets isStopped or closed true.

Hello,
I am trying to implemente angular2-busy, but I found that the Subscriber using customPOST never got closed or isStopped.

In the image for the first subscriber I am using customPOST, and the second one is from http post (angular 2 http).
not sure what is going on.
Regards.

Its normal behavior because restangular  using BehaviorSubject (Hot Observable).
If making http request we get Cold Observable.
To solve your problem you can use take() or any similar operator
Example:
let observable =  this.restangular.all('...').customPOST(...);
let sub = observable.take(1).subscribe(res => {
  console.log(res);
}, err => {
  console.log(err);
});

console.log(sub);


Fix layout issue in docs pages, like jobs

This fixes an issue in the docs page. See #30470 for more details.

Signed

I created #30493
I have tested this. In my view, this should be merged urgently as it's impacting multiple pages of the live site.
/lgtm

Preview of fixed pages:

https://deploy-preview-30490--kubernetes-io-main-staging.netlify.app/docs/tasks/debug-application-cluster/debug-service/
https://deploy-preview-30490--kubernetes-io-main-staging.netlify.app/docs/tasks/debug-application-cluster/debug-application-introspection/
https://deploy-preview-30490--kubernetes-io-main-staging.netlify.app/docs/tasks/debug-application-cluster/debug-running-pod/
https://deploy-preview-30490--kubernetes-io-main-staging.netlify.app/docs/tasks/debug-application-cluster/debug-running-pod/

This PR fixes the above pages
/lgtm

Tried linking all the issues that are related and fixed by this PR.

This PR has a second lgtm
/approve


prometheus exporter: accept more text media type

currently curl -v -H "Accept:text/plain" http://localhost:9464/metrics return 406. Fixed by reversing the logic of checking MediaRange.

Thanks!


pull request for e2e test at 01/25/2017 03:15:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Pager] - pager indicator runs off sides on large number of pages

Description
When there is a large numbers of pages the selected page indicator runs off the right side.
Steps to reproduce
Create a HorizontalPager with a large number of pages
Expected behavior
Possibly indicate page overflow at edges with a smaller indicator

Sorry, but I don't think we currently have plans to support such use case. Our current implementation is a pretty basic implementation of the simplest design. Feel free to copy the code and adjust as needed. Thanks


Fixed demoDesignVars to work with localSection DVs

@anilyil, @nbons not sure which one of you is best placed to check this
Previously, when looping through design variables, the demoDesignVars method would check whether the variable appeared in self.DV_listLocal or self.DV_listSectionLocal and then either way try to get the variable bounds from self.DV_listLocal meaning you'd get a KeyError if you used SectionLocal variables.

@nbons wrote that routine initially I believe. My modifications should only be related to indentation, but I might have messed up the routine since I don't know it that well. I did not understand your problem. Did you fix it? Is there a feature that is broken that used to work previously?

Sorry, should have been clearer, this issue was nothing to do with your changes, I just thought I'd tag the two people who were working on pygeo the most at the moment. I guess since @nbons wrote the original function he is the best person to double check this fix.

This looks fine. I made this change on my local repo among other things, just haven't got around to making a pull request.

Do you have anything against merging this then? Or would you rather merge your fork instead?

No, you can go ahead and merge it. Or Josh can. I don't have the power to
do so. I'll submit an additional pull request at some point.
On Mon, Dec 9, 2019 at 2:16 PM Alasdair Gray<EMAIL_ADDRESS>wrote:

Do you have anything against merging this then? Or would you rather merge
your fork instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mdolab/pygeo/pull/18?email_source=notifications&email_token=AB46FIG2MNVWO4BVSFB43RTQX2KQ7A5CNFSM4JASZIX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKKGVY#issuecomment-563389271,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB46FICKW3RSD7HR3S4XK6DQX2KQ7ANCNFSM4JASZIXQ
.

@joanibal


angular-cli compiles project using TypeScript 2.5.x, irrespective of TS version in package.json

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.
Globally installed:
@angular/cli: 1.4.9
node: 6.11.2
yarn: 1.2.1
os: linux x64 (Ubuntu 17.04)

node_modules of my project:
@angular/animations: 4.4.6
@angular/common: 4.4.6
@angular/compiler: 4.4.6
@angular/core: 4.4.6
@angular/forms: 4.4.6
@angular/http: 4.4.6
@angular/platform-browser: 4.4.6
@angular/platform-browser-dynamic: 4.4.6
@angular/router: 4.4.6
@angular/cli: 1.4.9
@angular/compiler-cli: 4.4.6
@angular/language-service: 4.4.6
typescript: 2.3.4

Repro steps.

Create a new Angular project using $ ng new my-project.
Add any code that does not compile with TypeScript 2.5 but compiles with TypeScript 2.3 to src/app/app.component.ts (see What's new in TypeScript for inspiration), e.g.:

interface Options {
    data?: string;
    timeout?: number;
    maxRetries?: number;
}

function sendMessage(options: Options) {
    // ...
}

const opts = {
    payload: "hello world!",
    retryOnFail: true,
}

// Error!
sendMessage(opts);
// No overlap between the type of 'opts' and 'Options' itself.
// Maybe we meant to use 'data'/'maxRetries' instead of 'payload'/'retryOnFail'.

Run $ ng serve or $ ng build --aot

The log given by the failure.
In the above setup, running $ ng serve or $ ng build --aot fails with the following error message:

ERROR in /home/simon/tech/tests/angular-deptest2/src/app/app.component.ts (19,13): Type '{ payload: string; retryOnFail: boolean; }' has no properties in common with type 'Options'.

This means that the code is getting compiled with at least TypeScript >2.4, instead of the expected version 2.3.4 (as per my project's package.json – which angular-cli generated).
Desired functionality.
The code should compile (JIT and AOT) as my project's package.json lists "typescript": "~2.3.3" as a dependency.
Mention any other details that might be useful.
yarn link lists the following dependencies for angular-cli:
yarn list v1.2.1
…
├─<EMAIL_ADDRESS>…
│  ├─<EMAIL_ADDRESS><2.6.0
│  ├─<EMAIL_ADDRESS>…
├─<EMAIL_ADDRESS>
and, indeed:
$ cat<EMAIL_ADDRESS>| grep version
    "version": "2.5.3",

confirming that TypeScript 2.5.3 was installed (which is probably because of angular-cli's chalk dependency which depends precisely on TypeScript 2.5.3 or higher). Now, I suspect that @ngtools/webpack – which angular-cli uses for compiling – will simply take its sibling TypeScript node module for compilation. So since it's also being installed to node_modules/@angular/cli/node_modules/, it will use the TypeScript version in node_modules/@angular/cli/node_modules/typescript (i.e. 2.5.3), not node_modules/typescript (which is v2.3.4).
Temporary work-around.
Add @ngtools/webpack as a dev dependency to your Angular project's package.json. @ngtools/webpack will then be installed to node_modules/@ngtools/webpack, so that it will find the TypeScript version in node_modules/typescript.

That workaround is giving me errors:
ERROR in ./src/main.ts
Module build failed: Error: AotPlugin was detected but it was an instance of the wrong class.
This likely means you have several @ngtools/webpack packages installed. You can check this with `npm ls @ngtools/webpack`, and then remove the extra copies.
    at Object.ngcLoader (/Users/splaktar/Git/tf/webapp/node_modules/@ngtools/webpack/src/loader.js:450:19)
 @ multi webpack-dev-server/client?http://<IP_ADDRESS>:0 ./src/main.ts
ERROR in ./src/polyfills.ts
Module build failed: Error: AotPlugin was detected but it was an instance of the wrong class.
This likely means you have several @ngtools/webpack packages installed. You can check this with `npm ls @ngtools/webpack`, and then remove the extra copies.
    at Object.ngcLoader (/Users/splaktar/Git/tf/webapp/node_modules/@ngtools/webpack/src/loader.js:450:19)
 @ multi ./src/polyfills.ts

This is probably a duplicate of https://github.com/angular/angular-cli/issues/8107. Or the root cause is the same at least.
The proper workaround is to edit yarn.lock and ensure that all 3 typescript version specifications are resolved into same version (desired one). Note that it will likely break again next time you update dependencies.
Should be something like this, note 3 versions in the same resolution record. And there should be no other resolution recordss for typescript in the yarn.lock.
<EMAIL_ADDRESS><EMAIL_ADDRESS><2.5.0"<EMAIL_ADDRESS>  version "2.4.2"
  resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.4.2.tgz#f8395f85d459276067c988aa41837a8f82870844"

Then rm -rf node_modules and yarn install.
I would also recommend to not use global ng command for running any commands except ng new. You can use yarn ng <whatever> to ensure local CLI installation is used.

@Splaktar After updating your package.json, did you remove node_modules and yarn.lock and installed all dependencies from scratch using $ yarn install?

@devoto13 Thanks for your response! I did search for existing issues but I guess I wasn't using the right keywords…
Regarding the question of a "proper" work-around: I don't like adding addditional dependencies, either, but editing yarn.lock definitely feels… dirtier. :)

Alternatively, you can use npm which doesn’t exhibit the problem.

@codethief Maybe, but it fixes exactly the root cause of the problem. And this change is not something inherently incorrect. Yarn just can't de-duplicate some version specifications. So you sort of helping it to do this de-duplication :)
@clydin Heh, NPM brings so many problems instead... But it's definitely an option.

@codethief I tried your workaround, including removing yarn.lock and node_modules before doing a fresh install with yarn install. I got the same error that @Splaktar reported.

@codethief I'm seeing this on npm 3.10.10. It doesn't appear to be yarn specific as identified here.
@clydin which version of NPM works for you?

@karptonite @Splaktar I'm only guessing here but I suppose this is another de-duplicating issue, in this case because yarn (or npm) still downloads a separate copy of @ngtools/webpack for @angular/cli even though there already is one in your project's node_modules folder.

This does sound an awful lot like https://github.com/angular/angular-cli/issues/8107, but the mention of chalk might make things different since it was recently updated (https://github.com/angular/angular-cli/commit/fd82e1870e351cfaaba0aebd20ec7801a0ece4ab).
@codethief what version of chalk are finding in your dependencies?

I don't see typescript as a dependency of chalk in any of these:

2.2.0<EMAIL_ADDRESS>2.2.2<EMAIL_ADDRESS>2.3.0<EMAIL_ADDRESS>
Are you using a linked Angular CLI maybe?

@filipesilva I'm sorry, you are right of course. chalk is just a dev dependency – I guess it was late last night…
(For completeness, though, $ cat<EMAIL_ADDRESS>| grep version gives 2.3.0.)
So TypeScript 2.5.3 indeed seems to be pulled due to angular-cli depending on<EMAIL_ADDRESS><2.6.0 and yarn/npm not being able to de-duplicate this dependency correctly to the TypeScript 2.3.4 copy that already exists in my project's node_modules as per its package.json?

@Splaktar I use both 3.10.10 and 5.4.2 regularly without issue.
I just did a test with clean installs of node v6.11.5 (npm v3.10.10) and node v8.8.0 (npm v5.4.2).  With both, a new CLI (v1.4.9) project has only TS 2.3.4.
Also tested various yarn versions.  Versions beyond 0.26.1 appear to produce the issue.

Fixed by https://github.com/angular/angular-cli/pull/8185

@clydin ah yes, npm is working great for me with the CLI 1.4.9 (referenced by this issue). My issue has been with the CLI 1.5.0-rc.3. I put some updates in https://github.com/angular/angular-cli/issues/8107 after testing with the changes in https://github.com/angular/angular-cli/pull/8185.


Detected issues when assigning a matrix to a submatrix, rooted in Base abstractarray.jl

Not sure whether this is a false positive from JET or an issue in base. On JET master from today and Julia nightly from today this happens:
This seems like a pretty innocent piece of code but JET reports a possible issue.
julia> function f1(n) # Vectors work fine
           m = zeros(2n)
           sub = zeros(n)
           m[n+1:2n] .= sub
           m
       end
       @report_call f1(10)
No errors detected

julia> function f2(n) # Matrices have issues
           m = zeros(2n, 2n)
           sub = zeros(n, n) # this needs to be a matrix to trigger the issue
           m[n+1:2n, n+1:2n] .= sub
           m
       end
       @report_call f2(10)
═════ 2 possible errors found ═════
┌ @ REPL[31]:4 Base.materialize!(Base.dotview(m, n + 1 : 2 * n, n + 1 : 2 * n), Base.broadcasted(identity, sub))
│┌ @ broadcast.jl:881 Base.Broadcast.materialize!(Base.Broadcast.combine_styles(dest, bc), dest, bc)
││┌ @ broadcast.jl:884 Base.Broadcast.copyto!(dest, Base.Broadcast.instantiate(Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{2}}(bc.f, bc.args, Base.Broadcast.axes(dest))))
│││┌ @ broadcast.jl:926 Base.Broadcast.copyto!(dest, Base.Broadcast.convert(Base.Broadcast.Broadcasted{Nothing}, bc))
││││┌ @ broadcast.jl:967 Base.Broadcast.copyto!(dest, A)
│││││┌ @ abstractarray.jl:1039 Base.copyto_unaliased!(IndexStyle(dest), dest, IndexStyle(src′), src′)
││││││┌ @ abstractarray.jl:1079 Base.indexed_iterate(ret, 1)
│││││││┌ @ tuple.jl:91 x = iterate(I)
││││││││ no matching method found `iterate(::Nothing)`: x = iterate(I::Nothing)::Union{}
│││││││└───────────────
││││││┌ @ abstractarray.jl:1079 Base.indexed_iterate(ret, 2, _26)
│││││││┌ @ tuple.jl:96 x = iterate(I, state)
││││││││ no matching method found `iterate(::Nothing, ::Int64)`: x = iterate(I::Nothing, state::Int64)::Union{}
│││││││└───────────────

Here are the lines that JET is complaining about: https://github.com/JuliaLang/julia/blob/05eb1530bbfe2db0dd6c9a13ea065f17cb9730cf/base/abstractarray.jl#L1077-L1082=
version info:
julia> versioninfo()
Julia Version 1.9.0-DEV.875
Commit 05eb1530bbf (2022-07-01 22:42 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 16 × AMD Ryzen 7 1700 Eight-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.5 (ORCJIT, znver1)
  Threads: 8 on 16 virtual cores
Environment:
  JULIA_EDITOR = code
  JULIA_NUM_THREADS = 8

(clifford) pkg> st JET
Status `~/Documents/ScratchSpace/clifford/Project.toml`
  [c3a54625] JET v0.5.16 `https://github.com/aviatesk/JET.jl.git#master`

Started as a discussion on discourse: https://discourse.julialang.org/t/jet-is-unhappy-with-broadcast-assigning-a-matrix-to-a-submatrix-rooted-in-abstractarray-jl/83750

Thanks! This kind of report is a typical case where we need to improve the implementation of Julia Base. Let's just improve it and makes JET happier with Base.

Solved in upstream.


Implement a special message to display when you have 1 grouping left

Implemented a way to display special message for the case where you are a owner and the case were you are an admin for when you have 1 grouping left. Also cleaned up some of the messages.properties file and the html code that had multiple span tags.

I notice in your latest commit you are using style=“…” code rather than classes.  This is not DRY and should be avoided.  Recommend you use classes such that you define the style once and use many times.  We can talk about this in the groupings channel or at a meeting.


Adding checksum for latest snapshots artifacts

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Adding checksum for latest snapshots artifacts
Issues Resolved
#1497
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1574 (50e7640) into main (e9ce1cd) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1574      +/-   ##
============================================
- Coverage     94.32%   94.19%   -0.13%
  Complexity       12       12
============================================
  Files           148      149       +1
  Lines          3154     3170      +16
  Branches          8        9       +1
============================================
+ Hits           2975     2986      +11
- Misses          172      177       +5
  Partials          7        7

Impacted Files
Coverage Δ

...ts/jenkins/jobs/uploadMinSnapshotsToS3_Jenkinsfile
100.00% <100.00%> (ø)

src/system/temporary_directory.py
83.87% <0.00%> (-12.91%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

src/system/execute.py
100.00% <0.00%> (ø)

src/paths/output_dir.py
100.00% <0.00%> (ø)

src/paths/tree_walker.py
100.00% <0.00%> (ø)

src/paths/build_output_dir.py
100.00% <0.00%> (ø)

src/system/working_directory.py
100.00% <0.00%> (ø)

src/system/thread_safe_counter.py
100.00% <0.00%> (ø)

tests/jenkins/jobs/BuildAssembleUpload_Jenkinsfile
100.00% <0.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ce1cd...50e7640. Read the comment docs.


Make release-notes command work from any location

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

Context: brew release-notes currently fails when executed in a directory other than $HOMEBREW_REPOSITORY. Hence, this PR.

specify repository location using git's -C option
change newest to latest when talking about the latest tagged commit (a.k.a. tag)

Thanks again @maxim-belkin!


HDFS-16942. Send error to datanode if FBR is rejected due to bad lease

Description of PR
When a datanode sends a FBR to the namenode, it requires a lease to send it. On a couple of busy clusters, we have seen an issue where the DN is somehow delayed in sending the FBR after requesting the least. Then the NN rejects the FBR and logs a message to that effect, but from the Datanodes point of view, it thinks the report was successful and does not try to send another report until the 6 hour default interval has passed.
If this happens to a few DNs, there can be missing and under replicated blocks, further adding to the cluster load. Even worse, I have see the DNs join the cluster with zero blocks, so it is not obvious the under replication is caused by lost a FBR, as all DNs appear to be up and running.
I believe we should propagate an error back to the DN if the FBR is rejected, that way, the DN can request a new lease and try again.
How was this patch tested?
Modified a test and added a new test. Also validated manually by changing the code to always throw the InvalidLease exception to ensure the DN handled it, reset the least ID and retried.

Not sure what to do about this checkstyle error:
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/InvalidBlockReportLeaseException.java:1:/**: Missing package-info.java file.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 41s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
22m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 51s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 79 unchanged - 0 fixed = 80 total (was 79)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
22m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
238m 22s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

345m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5460/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5460

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1c427e3c3acb 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 15851db5be391e6f36c263739f55723ab2abb7af

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5460/2/testReport/

Max. process+thread count
3164 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5460/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Duplicate classes found:

  Found in:
    org.apache.hadoop:hadoop-client-minicluster:jar:3.4.0-SNAPSHOT:compile
    org.apache.hadoop:hadoop-client-api:jar:3.4.0-SNAPSHOT:compile
  Duplicate classes:
    org/apache/hadoop/hdfs/server/protocol/package-info.class

I believe this could be avoided by excluding it from either of the poms:
--- a/hadoop-client-modules/hadoop-client-api/pom.xml
+++ b/hadoop-client-modules/hadoop-client-api/pom.xml
@@ -126,6 +126,12 @@
                         <exclude>org/apache/hadoop/yarn/client/api/package-info.class</exclude>
                       </excludes>
                     </filter>
+                    <filter>
+                      <artifact>org.apache.hadoop:hadoop-hdfs</artifact>
+                      <excludes>
+                        <exclude>org/apache/hadoop/hdfs/server/protocol/package-info.class</exclude>
+                      </excludes>
+                    </filter>
                   </filters>
                   <relocations>
                     <relocation>

For instance, the above patch might help. I haven't tested this but I guess it might work.

@sodonnel also I am curious, was it just a specific log (only one case e.g. the lease was expired) or combination of logs from checkLease(DatanodeDescriptor dn, long monotonicNowMs, long id) that you have seen in various issues?
I wonder if lease expiry or invalid lease are worth having some dedicated metrics in NameNodeActivity, maybe not as with this patch, the subsequent attempt should anyways have new lease available to it from the response of heartbeat API.

@sodonnel also I am curious, was it just a specific log (only one case e.g. the lease was expired) or combination of logs from checkLease(DatanodeDescriptor dn, long monotonicNowMs, long id) that you have seen in various issues?
I wonder if lease expiry or invalid lease are worth having some dedicated metrics in NameNodeActivity (maybe not as with this patch, the subsequent attempt by BP actor should anyways have new lease id acquired from the response of heartbeat API before it reattempts sending FBR).

In the examples I saw, its was expired leases that caused the problem. However the namenode was under significant pressure when it happened. In one example, it was actually the SBNN which was rejecting the reports. Tailing the edits was taking frequent long locks (over 300 seconds at time) which was beyond the lease expiry.
In another example, it was the ANN after startup. I am not sure, but I think the system perhaps out of safemode with many block reports still outstanding, and then between under replication and IBRs, contention on the NN lock seemed to block the FBRs until the lease expired.

Duplicate classes found:

  Found in:
    org.apache.hadoop:hadoop-client-minicluster:jar:3.4.0-SNAPSHOT:compile
    org.apache.hadoop:hadoop-client-api:jar:3.4.0-SNAPSHOT:compile
  Duplicate classes:
    org/apache/hadoop/hdfs/server/protocol/package-info.class

I believe this could be avoided by excluding it from either of the poms:
--- a/hadoop-client-modules/hadoop-client-api/pom.xml
+++ b/hadoop-client-modules/hadoop-client-api/pom.xml
@@ -126,6 +126,12 @@
                         <exclude>org/apache/hadoop/yarn/client/api/package-info.class</exclude>
                       </excludes>
                     </filter>
+                    <filter>
+                      <artifact>org.apache.hadoop:hadoop-hdfs</artifact>
+                      <excludes>
+                        <exclude>org/apache/hadoop/hdfs/server/protocol/package-info.class</exclude>
+                      </excludes>
+                    </filter>
                   </filters>
                   <relocations>
                     <relocation>

For instance, the above patch might help. I haven't tested this but I guess it might work.

@virajjasani This isn't working. I added what you suggested, but still the same error. I also don't understand why this style warning is appearing, as its not a new package folder, and it has plenty of other classes in it already.

I also don't understand why this style warning is appearing, as its not a new package folder, and it has plenty of other classes in it already.

I think it's appearing because it was not resolved earlier or it was ignored. For instance, I see the last time the module was touched was by this PR #4252 and in the last QA result, I see checkstyle issues, but of course since the PR is quite old, we can't see what the error was (it reports 404 for the checkstyle report page).
I guess it's not that important either.

This isn't working. I added what you suggested, but still the same error.

Strange, I think this one should hopefully work:
--- a/hadoop-client-modules/hadoop-client-api/pom.xml
+++ b/hadoop-client-modules/hadoop-client-api/pom.xml
@@ -126,6 +126,12 @@
                         <exclude>org/apache/hadoop/yarn/client/api/package-info.class</exclude>
                       </excludes>
                     </filter>
+                    <filter>
+                      <artifact>org.apache.hadoop:*</artifact>
+                      <excludes>
+                        <exclude>org/apache/hadoop/hdfs/server/protocol/package-info.class</exclude>
+                      </excludes>
+                    </filter>
                   </filters>
                   <relocations>
                     <relocation>

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 29s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 27s

trunk passed

+1 :green_heart:
shadedclient
22m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 79 unchanged - 0 fixed = 81 total (was 79)

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 16s

the patch passed

+1 :green_heart:
shadedclient
22m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
241m 30s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

348m 18s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5460/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5460

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8bfa574c9407 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9604ad2377a0ee3ea423e17c4cca697f12c38f6e

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5460/3/testReport/

Max. process+thread count
2909 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5460/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Strange, I think this one should hopefully work:
--- a/hadoop-client-modules/hadoop-client-api/pom.xml
+++ b/hadoop-client-modules/hadoop-client-api/pom.xml
@@ -126,6 +126,12 @@
                         <exclude>org/apache/hadoop/yarn/client/api/package-info.class</exclude>
                       </excludes>
                     </filter>
+                    <filter>
+                      <artifact>org.apache.hadoop:*</artifact>
+                      <excludes>
+                        <exclude>org/apache/hadoop/hdfs/server/protocol/package-info.class</exclude>
+                      </excludes>
+                    </filter>
                   </filters>
                   <relocations>
                     <relocation>

@virajjasani Thanks! That has fixed the compile. I just pushed the change, so hopefully we will get a green build this time.

The reported failures are just known flakes, not related.
+1 (non-binding) from my side, thank you @sodonnel @Hexiaoqiao

@Hexiaoqiao Are you happy with the latest revision to give a +1 so I can commit? Thanks.

This wasn't the fix: https://github.com/apache/hadoop/pull/5460#issuecomment-1463012342, rather it broke the javadoc build.
Shoot a mvn clean site and find an exception like
[ERROR] /hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/package-info.java:22: error: package org.apache.hadoop.hdfs.server.protocol has already been annotated
[ERROR] @InterfaceAudience.Private
[ERROR] ^
[ERROR] java.lang.AssertionError
[ERROR] 	at com.sun.tools.javac.util.Assert.error(Assert.java:126)
[ERROR] 	at com.sun.tools.javac.util.Assert.check(Assert.java:45)
[ERROR] 	at com.sun.tools.javac.code.SymbolMetadata.setDeclarationAttributesWithCompletion(SymbolMetadata.java:177)
[ERROR] 	at com.sun.tools.javac.code.Symbol.setDeclarationAttributesWithCompletion(Symbol.java:215)
[ERROR] 	at com.sun.tools.javac.comp.MemberEnter.actualEnterAnnotations(MemberEnter.java:952)
[ERROR] 	at com.sun.tools.javac.comp.MemberEnter.access$600(MemberEnter.java:64)
[ERROR] 	at com.sun.tools.javac.comp.MemberEnter$5.run(MemberEnter.java:876)
[ERROR] 	at com.sun.tools.javac.comp.Annotate.flush(Annotate.java:143)
[ERROR] 	at com.sun.tools.javac.comp.Annotate.enterDone(Annotate.java:129)
[ERROR] 	at com.sun.tools.javac.comp.Enter.complete(Enter.java:512)
[ERROR] 	at com.sun.tools.javac.comp.Enter.main(Enter.java:471)
[ERROR] 	at com.sun.tools.javadoc.JavadocEnter.main(JavadocEnter.java:78)
[ERROR] 	at com.sun.tools.javadoc.JavadocTool.getRootDocImpl(JavadocTool.java:186)

Now the original problem
That @sodonnel mentioned over here https://github.com/apache/hadoop/pull/5460#issuecomment-1458896438
That the enforcer is giving an exception once he adds package-info.java
  Duplicate classes:
    org/apache/hadoop/hdfs/server/protocol/package-info.class

And the fix went in the direction this enforcer has gone crazy, lets filter this file itself, but that poor fellow wasn't doing anything wrong :)
Check the file-1
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/package-info.java
Now your added File-2
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/package-info.java
One was already there in hdfs-client, now this got added for the same package on hdfs as well. Why same package on client and hdfs jar, I think all of us here know those reasons, so not getting into that...
@sodonnel can you delete this new package-info.java file. And we can fix the build post writing "Checkstyle warnings is irrelevant/unavoidable"

Or, we just need to remove IA.Private annotation from package-info.java? It seems we don't put IA.Private on any of package-info.java

That way in future also, if anyone makes changes in hadoop-hdfs module's hdfs/server/protocol, then jenkins won't given any redundant warning?

Do you want just a followup PR to remove the file, or is just removing the IA.private line enough? TBH, I just copied the contents from another package-info file.

Just remove the file and the filter. no need to have dupes. many package-info must be having those IA.private.

TBH, I just copied the contents from another package-info file.

that's what all of us do :)

Ah, looks like we have IA annotations in some and not in others. Looks like removing might be better. Thanks!
I wonder how do we deal with it in future though? When someone makes changes only in hadoop-hdfs module's protocol package, the checkstyle failure will unnecessarily get attention?

But will the checkstyle not affect all future PRs? I think I have seen that happen before, where a new checkstyle issue comes in, and then future PRs are impacted by it, but I may be wrong.
I will remove the file and see what it does.

But will the checkstyle not affect all future PRs?

Correct, that's what I was wondering :)

But will the checkstyle not affect all future PRs? I think I have seen that happen before, where a new checkstyle issue comes in, and then future PRs are impacted by it, but I may be wrong.

How? You folks mean the new PR will also show this checstyle warning? So, our checkstyle works by computing diff b/w the trunk and the patch and flags when the number changes.
if you check the warning above:
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 79 unchanged - 0 fixed = 81 total (was 79)

There were already 79, the PR had 2 more, so that is what it flags

How? You folks mean the new PR will also show this checstyle warning?

Correct, I am only worried about the amount of time folks will end up wasting in future for such warning:
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/InvalidBlockReportLeaseException.java:1:/**: Missing package-info.java file. [JavadocPackage]

Posted #5478 to address the problem


Add ability to override indivual components versions

What is missing?
I would like the ability to upgrade just individual components version within releases.
Right now when you want to select a version of kube-prometheus you check the compatibility version matrix and go ahead and install a release based on which Kubernetes version you are running.
That works for most use cases, but sometimes upgrading Kubernetes versions is not possible, but you still want a newer version of prometheus operator.
Why do we need it?
Lets say a user is on Kubernetes version v1.24, so they have kube-prometheus release version pinned to release-0.12. Now lets say that user really wants a newer feature from prometheus operator, and in theory they don't have to upgrade Kubernetes versions as prometheus operator uses. But they can't upgrade to the version of  kube-prometheus as the next one up is not compatable anymore with their Kubernetes version.
Having the ability for the user to override just individual component versions, like prom-operator would be super helpful. It doesn't need to be tested and should be up to the user to take the risk of this. But right now the only option is to fully rewrite kube-prometheus or fork it due to pinned versions in each release branch.
I can also see this being done for security reasons as another good option, for older non-supported versions of kube-prom.
Environment
Not applicable.

kube-prometheus version:

Not applicable.
Anything else we need to know?:
👋 hi! 😄

cc @simonpasquier we already had a chat about this.

Also I believe we might need to do some things on https://github.com/jsonnet-bundler/jsonnet-bundler side of things. @metalmatze @brancz any thoughts and ideas how we could do that?

I don't think this really has anything to do with kube-prometheus. I think this should be solved in jsonnet-bundler. Currently jsonnet-bundler can only have a single version of a dependency, we should expand this to allowing to have multiple versions of the same dependency. It's honestly quite silly, because what you can do today already is fork whatever dependency you want a different version of at the version you want, install it, and use it to override.


Rework Ping Server example

In last course people reported strongly diverting results.
Re-run sample code.
Work out if the load of concurrent requests can be increased (something todo with open socket limit in OS)
Include chart of go vs java performance: x axis: thousands of concurrent requests, y-axis: median & 90th percentile response time.

Reach out to Lei Chen re improvements to Java code.
Se what can be done to improve maximum number of concurrent requests.


upload to modrinth

I use prism launcher (and sometimes modrinth launcher) which both let me download and update mods directly from modrinth. it would be cool if the mod was available on modrinth so i could automatically update it along with all my other mods
https://modrinth.com

prismlauncher is goated, will do

https://modrinth.com/mod/zombies-utils

yes, there's a (usually) 2 day review (unless they are overwhelmed with submissions then it can be a bit longer). this long review process is only for the initial upload, all future releases wont have this


Java debug to support exec form entrypoint

The current Java debugging injects additional JVM parameters through $JAVA_OPTS env var. Environment variables won't be evaluated when users dockerfile is using the exec from ENTRYPOINT statement. Here are the two form s of ENTRYPOINT:

ENTRYPOINT ["executable", "param1", "param2"] (exec form, preferred)
ENTRYPOINT command param1 param2 (shell form)

Please support both. CMD statement can be used to specify extra parameters to ENTRYPOINT.

In exec form, the variable will not be substituted, use the global JVM environment variable JAVA_TOOL_OPTIONS to enable debug options.
In shell form, use $JAVA_OPTS or the global JVM environment variable JAVA_TOOL_OPTIONS to enable debug options.

Closed with PR https://github.com/Azure/vscode-kubernetes-tools/pull/89


chore: improve publish

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.92%. Comparing base (37737df) to head (8894215).

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   86.78%   86.92%   +0.13%
==========================================
  Files           8        8
  Lines         734      734
  Branches       65       65
==========================================
+ Hits          637      638       +1
+ Misses         93       92       -1
  Partials        4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Handle IndentationError

From #92: IndentationError from code blocks should be handled along with SyntaxError in parsing so that it doesn't propagate forward in the build process.
Let's also change the logging level to a warning.

IndentationError is a subclass of SyntaxError.


SP4: Axis.ManualTicks(Tick[] ticks)

Feature Suggestion
Feature description:
The concept of major and minor ticks is great and the concept of manual tick positions is very much appreciated as well. So why not putting them together?
I mainly work with logarithmic plots. I need to use manual tick positions especially when zooming in - as there are no automatic ticks provided any more when the data range is 'too small'. (I skip adding an example plot with no ticks on the axis.)
Manual major ticks and labels work very well for these small range logarithmic plots.
If I understand correctly, in order to add minor ticks the only option right now would be to add more major manual ticks but with empty labels. The result is not great as the major and 'minor' ticks have an identical look and the grid lines are of the same color. So the lines are not easily distinguishable.

(Note: Just to clarify as this has been a subject to discussions before. This is a logarithmic plot. One might expect the minor grid lines need to be distributed in 'a more logarithmic way' but this is not the case. The space between minor ticks just gradually shrinks over the range of one full magnitude. Here, a range a lot smaller than a magnitude is plotted.)
Right now there is only major ticks (with labels) in my plots and minor ticks are just missing. With this the axis is a little empty. Particularly in logarithmic plots minor grid lines would be a wonderful orientation helper.
This is an example where I think minor ticks would help the viewer a whole lot when viewing the data:

So please add this feature!
Code example:
I suggest a similar way as adding manual major tick positions.
Example:
_plot.YAxis.ManualTickPositions(majorTicks, majorTickLabels);
_plot.YAxis.ManualMinorTickPositions(minorTicks);

Hi @FannyAtGitHub, thanks for this suggestion!
It would be great if the user could construct a collection of Tick objects (defining which are major, minor, labels, etc) and then pass them in. I'm thinking the API could look like this to compliment the existing GetTicks() method:
Tick[] ticks = /* your logic here */

formsPlot1.Plot.YAxis.SetTicks(ticks);

If you or someone else want to try to implement this and create a PR, I'd be happy to review it! Otherwise this issue may sit here for a little while until I'm able to get to it myself.
I think the way I'd approach it is to edit TickGenerator.cs and add a Tick[]? manualTicks { get; set; } = null; which can be set, and if the user sets it the returned ticks will always be those manual ones and not the ones generated by the major or minor tick generators

I'm merging #3047 now and will publish an updated NuGet package later today. It will allow this:
ScottPlot.Plot plt = new(400, 300);
plt.AddSignal(DataGen.Sin(51));
plt.AddSignal(DataGen.Cos(51));

// use a helper class to build a colelction of major and minor ticks
ScottPlot.Ticks.ManualTickCollection tc = new();
tc.AddMajor(0, "zero");
tc.AddMajor(20, "twenty");
tc.AddMajor(50, "fifty");
tc.AddMinor(22);
tc.AddMinor(25);
tc.AddMinor(32);
tc.AddMinor(35);
tc.AddMinor(42);
tc.AddMinor(45);

// get the tick array and apply it to the axis
ScottPlot.Ticks.Tick[] ticks = tc.GetTicks();
plt.BottomAxis.SetTicks(ticks);

Thanks again for your question @FannyAtGitHub! Although users will have to add logic that calls Plot.GetAxisLimits() and figures out how many ticks and where to place them, at least now there's a smooth way to manually define major and minor ticks 🚀


Application is busy

Hello.
Sometimes, my python script fail with this error :
"The message filter indicated that the application is busy."
I don't understand because I don't touch application and sometimes the script fail and sometimes not.
How can I manage busy error in my python script ?
Is there anyway to know if application is busy ?
Many thanks

Hi @djs45

How can I manage busy error in my python script ?

Avoid manual control of Photoshop while your script is running, it's a big execution improvement

Is there anyway to know if application is busy ?

There is no definite answer,  application is busy is means Photoshop is doing something, for example, you are currently saving a file in Photoshop and you execute a script and a similar situation occurs

Another thing to avoid is minimizing the Photoshop window, the window doesn't have to be active but it does need to be open (not minimized to tray) to function properly


[BUG] - Ripple displays outside of the button

NextUI Version
2.2.10
Describe the bug
This bug appears only locally in safari (macOS) and mobile(iOS) chrome/safari.
I reproduced in codesanbox but probably you should download and check it locally too. Because in sandbox I have normal behaviour.
Your Example Website or App
https://codesandbox.io/p/devbox/flamboyant-http-qnhdcl
Steps to Reproduce the Bug or Issue
_
Expected behavior
_
Screenshots or Videos
https://github.com/nextui-org/nextui/assets/12993018/47a813d0-a357-43e4-a0da-556e4b829a80
Operating System Version
macOS
Browser
Safari

I've tried your code locally in safari but didn't reproduce the issue.

@wingkwong this is strange. Now I see this on codesandbox too
My Safari version is 17.3.1 (196<IP_ADDRESS>.12)

I couldn't replicate this:
https://github.com/nextui-org/nextui/assets/30373425/b4f5cb13-a2ee-41c0-8fa5-386c14e00000

After updating on Safari 17.4.1 I can't reproduce it too. Let's close it for now.


Remove unnecessary folder #5 (SA)

_static/category is unnecessary, please remove and pull request

issue resolved via https://github.com/gsantella/ambucs-site-2023/pull/18


Unable to calculate checksum on not changed SQL Scripts

Which version and edition of Flyway are you using?
Use Flyway 6.0.8
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
We Use the Maven Plugin
Which operating system are you using?
Windows
What did you do?
We wil upgrade from Version 5.2.4 to the new Version 6.0.x
With Version 5.2.4 the migration runs fine!
Without any migration script changes, the scripts broken with Version 6.0.8!
This exception is threon
Caused by: java.nio.charset.MalformedInputException: Input length = 1
	at java.base/java.nio.charset.CoderResult.throwException(CoderResult.java:274)
	at java.base/sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:339)
	at java.base/sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
	at java.base/java.io.BufferedReader.fill(BufferedReader.java:161)
	at java.base/java.io.BufferedReader.readLine(BufferedReader.java:326)
	at java.base/java.io.BufferedReader.readLine(BufferedReader.java:392)
	at org.flywaydb.core.internal.resource.LoadableResource.checksum(LoadableResource.java:66)
	at org.flywaydb.core.internal.resolver.sql.SqlMigrationResolver.addMigrations(SqlMigrationResolver.java:140)
	at org.flywaydb.core.internal.resolver.sql.SqlMigrationResolver.resolveMigrations(SqlMigrationResolver.java:86)
	at org.flywaydb.core.internal.resolver.sql.SqlMigrationResolver.resolveMigrations(SqlMigrationResolver.java:46)
	at org.flywaydb.core.internal.resolver.CompositeMigrationResolver.collectMigrations(CompositeMigrationResolver.java:124)
	at org.flywaydb.core.internal.resolver.CompositeMigrationResolver.doFindAvailableMigrations(CompositeMigrationResolver.java:106)
	at org.flywaydb.core.internal.resolver.CompositeMigrationResolver.resolveMigrations(CompositeMigrationResolver.java:92)
	at org.flywaydb.core.internal.resolver.CompositeMigrationResolver.resolveMigrations(CompositeMigrationResolver.java:45)
	at org.flywaydb.core.internal.info.MigrationInfoServiceImpl.refresh(MigrationInfoServiceImpl.java:130)
	at org.flywaydb.core.internal.command.DbInfo.info(DbInfo.java:52)
	at org.flywaydb.core.Flyway$4.execute(Flyway.java:321)
	at org.flywaydb.core.Flyway$4.execute(Flyway.java:314)
	at org.flywaydb.core.Flyway.execute(Flyway.java:511)
	at org.flywaydb.core.Flyway.info(Flyway.java:314)
	at org.flywaydb.maven.InfoMojo.doExecute(InfoMojo.java:39)
	at org.flywaydb.maven.AbstractFlywayMojo.execute(AbstractFlywayMojo.java:751)
	... 22 more

@sbivi Thanks for reporting this. Any chance you can share the offending migration script?

Yes, you find the file here: script file

The immediate cause seems to be that the script contains some bytes that don't decode as valid UTF-8 or UTF-16. In that respect it's a duplicate of #2549 but it's good to have more files to test on. Obviously you can change the script to resolve the problem, but we will investigate what we can do better in these cases.

Hello Juli,
why you closed the ticket?
We cannot work with the new Version of flyway,
so some already existing script will not work anymore with the new version!
How should we fixes the script that already running in production?
You should fix the Checksum calculator that has worked with the previous major release!
Mit besten Grüßen
Stefan Brandt | Informationstechnik/Entwicklung
Web-Entwicklung
IVI Informationsverarbeitungs GmbH
Itzehoer Platz, 25521 Itzehoe
Telefon 04821 80404-81
Telefax 04821 80404-99
stefan.brandt<EMAIL_ADDRESS>www.ivi.de
Von: Julia Hayward<EMAIL_ADDRESS>Gesendet: Mittwoch, 13. November 2019 16:00
An: flyway/flyway<EMAIL_ADDRESS>Cc: Brandt, Stefan<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [flyway/flyway] Unable to calculate checksum on not changed SQL Scripts (#2558)
Closed #2558https://github.com/flyway/flyway/issues/2558.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/flyway/flyway/issues/2558?email_source=notifications&email_token=ANXTNUJSALSAPTIGU235J43QTQI5VA5CNFSM4JLTD4IKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOU2QZIDQ#event-2795607054, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANXTNUJNCNZ2Y5IUMRDJFZDQTQI5VANCNFSM4JLTD4IA.

IVI Informationsverarbeitungs GmbH
Itzehoer Platz, 25524 Itzehoe
Geschäftsführer: Guido Krüger, Dr. Lars Knudsen
Sitz: Itzehoe, Registergericht: Amtsgericht Pinneberg
HRB 2073 IZ, USt.-ID-Nr. DE 134 777 598

Hi Stefan,
As I explained, your script is not valid UTF-8. You can see this by iconv -f UTF-8 my-script.sql -o /dev/null - this produces an error message. Could you check to see if a single script is affected, or if it is a larger problem for you? What editor did you use to create the file? I am sorry we cannot simply reinstate the checksum calculator from Flyway 5.2.4, but we can look at other workrounds in future.
Best wishes,
Julia

Hi Julia,
yes we have some projekts used Flyway scripts. 16 Scripts in 6 projects are broken.
I Think the problems comes with german umlauts in SQL scripts with COMMENT's.
The Script files use file encoding Cp1252 - Can we set this to the flyway configuration and should it works than?
Or what shoud we do to fix the problem in older production scripts?

That's a very helpful suggestion! I have just tried it, and if you set
flyway.encoding=cp1252
in your config file (or on the command line), then the script you supplied works equally well with Flyway v5 and v6. You will still need to flyway repair as the checksums will work out differently after the encoding change, but there will be no need to change the scripts to work with Flyway v6.
I hope that's a reasonable solution?
Best wishes,
Julia

This woks fine - thx.

Great - just out of interest, what editor do you use? I'm not aware of any that produce files in CP1252 by default.

I have faced the similar issue. I am working with SQL Server migrations. Changing the flyway encoding configuration parameter to cp1252 has other complications. Though, the checksum gets calculated after changing the encoding to cp1252, on all the 45 migration files that I have, but during migrations it treats many of those line endings differently and could not migrate them.
I have resolved this by opening the problematic file in Notepad++ and re-converting each file to UTF-8. Now, the migrations are going smooth with default encoding "UTF-8"
Hope this helps someone.


GVim built against GTK 3 can't find icons

Issue description
When I start a version of GVim from vim_configurable built against GTK 3, as is the default as of commit 9ac7ec7fc77b015c49ef4698b78ce0c068b7dabf, I get the following message:
(gvim:16055): Gtk-WARNING **: 23:26:45.710: Could not find the icon 'document-open-ltr'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
        http://icon-theme.freedesktop.org/releases

Versions of GVim from vim_configurable built against GTK 2 do not give me this message.
Steps to reproduce
$ nix-build -E '(import <nixpkgs> {}).vim_configurable.override {guiSupport = "gtk3";}'
$ ./result/bin/gvim

For comparison:
$ nix-build -E '(import <nixpkgs> {}).vim_configurable.override {guiSupport = "gtk2";}'
$ ./result/bin/gvim

Technical details

system: "x86_64-linux"
host os: Linux 4.14.48, NixOS, 18.09pre147850.2428f5dda13 (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.0.4
channels(root): "nixos-18.09pre147850.2428f5dda13"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Do you have any icon theme installed?

I don't know what it would mean (in terms of NixOS options) to install an icon theme, so I doubt I have installed one.

Just add something like gnome3.adwaita-icon-theme to environment.systemPackages. Desktop environments should do that for you.

While I'm unfamiliar with GVim's dialogues, I see that adding wrapGAppsHook to its nativeBuildInputs does allow it to display a file-chooser dialogue; however, for me, opening this file-chooser dialogue produces many of the following warnings:
(gvim:21398): dconf-WARNING **: 20:08:07.668: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

Adding gnome3.adwaita-icon-theme to environment.systemPackages indeed does fix the warning from my initial report (thanks!). Should the NixOS manual suggest, as it currently does not, installing such an icon theme if one doesn't install a desktop environment?
Even with the adwaita-icon-theme installed, opening GVim's find/replace dialogue produces the following warning, which I suppose indicates some further GNOME package I'm missing:
(gvim:21404): Gtk-WARNING **: 20:28:51.298: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg.
This may indicate that pixbuf loaders or the mime database could not be found.

however, for me, opening this file-chooser dialogue produces many of the following warnings:

Yes, adding gnome3.dconf to services.dbus.packages is another thing you need to do if you build your DE yourself.

Should the NixOS manual suggest, as it currently does not, installing such an icon theme if one doesn't install a desktop environment?

I was contemplating a section on creating custom DEs. In addition to icons and dconf, it could suggest things like polkit, udisks or other things you will see in a full DE. Or maybe this could go to wiki – if I recall correctly, some of the errors from above are already listed there.

Even with the adwaita-icon-theme installed, opening GVim's find/replace dialogue produces the following warning, which I suppose indicates some further GNOME package I'm missing:

Yup, that would be librsvg gdk_pixbuf loader. You could fix it like this:
https://github.com/NixOS/nixpkgs/blob/5e21b90616152f8fd7c95df75ad22d634e8733c6/nixos/modules/services/x11/desktop-managers/xfce.nix#L109
Though I would expect wrapGAppsHook to take care of that.

Yes, adding gnome3.dconf to services.dbus.packages is another thing you need to do [...]

I've done so, and also set programs.dconf.enable = true, and rebooted, and the file-chooser dialogue now works without warnings. Thanks.
Would it make sense for programs.dconf itself to add gnome3.dconf to services.dbus.packages?

Or maybe this could go to wiki – if I recall correctly, some of the errors from above are already listed there.

Is there a wiki still? I thought it was shut down.

Though I would expect wrapGAppsHook to take care of that.

Ah, indeed it does; I had forgotten to test that.

Would it make sense for programs.dconf itself to add gnome3.dconf to services.dbus.packages?

Yes, I am not sure why it already is not there.

Is there a wiki still? I thought it was shut down.

Yup, we had a new one for a while now: https://nixos.wiki/


componentWillReceiveProps is deprecated

Please keep this warning in consideration for coming updates

Hi @TakaKeiji ,
This should be a simple fix replacing the lifecycle method,
PRs are always welcome and greatly appreciated.

the error from this library itself should be gone in the latest update.
The same lifecycle method deprecation warning also appears in my case from react-native's own components like TouchableOpacity etc.
Those will only be gone once react-native updates them.


NVMe sample: Fix nvme ids

OpenShift image has the NVMe hostid and hostnqn hardcoded, so it ends up being the same in all the control plane nodes, which is problematic.
This MachineConfig fixes this issue by recreating both files when the hostid doesn't match the system-uuid of the machine it is running on.
Bugs:

https://issues.redhat.com/browse/OCPBUGS-34629
https://github.com/openshift/os/issues/1519
https://github.com/openshift/os/pull/1520

/retest

/retest


getOrSetDefault send message in console

Describe the bug
Everytime I use (in 3.0.5) : getOrSetDefault(), a message of the type of data I got is send in the console.
Like : "OBJ: String T: String"
To Reproduce
Yaml YamlConfig = new Yaml("config","test");
String strengthstring = YamlConfig.getOrSetDefault("test","hey :D");

Expected behavior
Send nothing

Oh wait it was patched in 3.0.6


docs: fix typo

noticed while reading the docs

thank you for the fix, @rolweber .
i would love to merge it, but i need your consent to publish your work under the license of this project.
therefore, please sign your commit.
Please follow the instructions: https://github.com/CycloneDX/cyclonedx-python-lib/pull/318/checks?check_run_id=10085359274

Grmpf. Signing isn't enough, I also need to mention in the commit message that it's signed :-?

re: https://github.com/CycloneDX/cyclonedx-python-lib/pull/318#issuecomment-1350722019
exactly. for legal reasons each commit needs to ne signed-off to indicate that the author acknowledged the projects license and puts their work under said license.
This process is not regarding signed identity but legal signature.
You can read more here:

https://github.com/CycloneDX/cyclonedx-python-lib/blob/main/CONTRIBUTING.md#sign-your-commits

I fell for the difference between -S and -s.

All checks are passing now.


minimal changes to get existing example working in firefox

this is pretty much just the existing example, updated to use the new interfaces, and with some changes to fix stuff that was broken in firefox (haven't tested in any other browsers). Long term we probably want to make sure this works in all major browsers and in standards mode (at the moment it's relying on quirks mode, but I can't immediately figure out why...)

Added a commit that adds <!doctype html> to the top of the example index.html and made the required CSS fix 👍


Provide option to '--trace' and show output

Consider this a wishlist feature request to provide an option in the web interface to produce a parser with '--trace' enabled and to show the resulting trace output for debugging purposes.

Yes, this would be useful once 0.9.0 is released. (The PEG.js website always uses the latest officially released PEG.js version and 0.8.0 didn’t have tracing support.)
An easy way to implement this would be to add a checkbox labeled e.g. “Enable tracing” below the “Use results cache” one. Then, add a “Trace” link to the status bar with parse result which would open the captured trace in a popup.
I won’t work on this myself but if anyone is interested, I’ll accept a PR after the 0.9.0 release.

I reconsidered. I decided to keep the online editor simple and not turn it into a full-fledged grammar development IDE. If you want to debug things using tracing, you need to do it outside the editor.


[TextField] autoFocus doesn't seem to be working

Problem description
I tried making auto focus on my TextField with no success.
I also looked and saw that the autoFocus is being @ignore from the docs. Why is that?
Tried with autoFocus={true}
<TextField
        autoFocus={true}
        onChange={ (e) => debounceOnChange(e.target.value) }
        type="search"
      />

Tried with inputProps={true}
<TextField
        inputProps={autofocus: {true}}
        onChange={ (e) => debounceOnChange(e.target.value) }
        type="search"
      />

And even InputProps:
<TextField
        InputProps={autofocus: {true}}
        onChange={ (e) => debounceOnChange(e.target.value) }
        type="search"
      />

Versions

Material-UI: 1.0.0-alpha-19
React: 15.6.1
Browser: Al of them

I have noticed that the autoFocus behaviour is unreliable, I believe it's an issue with React internally. I have noticed the same thing outside of Material-UI.

is being @ignore from the docs. Why is that?

We avoid documenting native React properties.

This is actually in the specs now that I look at it and it seems fine (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-autofocus).
I solved it using this method:
class Example extends Component {
  constructor() {
    super();

    this._focus = this._focus.bind(this);
  }

  _focus() {
    this.textInput.focus();
  }

  componentDidUpdate(){
    this._focus();
  }

  render() {

    return (
        <TextField
            inputRef={(input) => { this.textInput = input; }}
            disabled={this.props.disabled}
        />
    );
  }
}

WDYT about adding the autoFocus attribute in a way that if it's set to true it will perform the call the _focus like I did here?
That way the component will support auto focus that works :)

WDYT about adding the autoFocus attribute in a way that if it's set to true it will perform the call the _focus like I did here?

I was expecting React to do such thing internally :pensive:.

test
source

Well it seems to work well with inputProps={{ autoFocus: true }} see https://codesandbox.io/s/ERxnnX9mm

Thanks!
It seems that in my case since it was disabled on start the autoFocus only applied during that time. As far as I'm concern we can close this issue.
I still think that we should have the autoFocus be set on the TextField and inside of it make perform the inputProps stuff. That way it's easier to use :)

I still think that we should have the autoFocus be set on the TextField

Your first example should be working too:
<TextField
        autoFocus={true}
        onChange={ (e) => debounceOnChange(e.target.value) }
        type="search"
      />

const MyComponent = () => {
 const inputRef = useRef<HTMLElement>(null);

 useEffect(() => {
    if (!inputRef.current) return;
    inputRef.current.focus();
  }, []);

  return (
      <TextField
        inputRef={inputRef}
        // ....
      />
  )
}

This alternative solution should work fine
const MyComponent = () => {
 const inputRef = useRef<HTMLElement>(null);

 useEffect(() => {
    if (!inputRef.current) return;
    inputRef.current.getElementsByTagName("input")[0].focus();
  }, []);

  return (
      <TextField
        inputRef={inputRef}
        // ....
      />
  )
}

This worked really well and additionally does not use an setTimeout. Thanks!

While the above example leads in the right direction, I found that the inputRef contains the input element itself, so there is no need for further selectors to get to it.
Also, no need to explicitly check if the inputRef.current has a value or not; check below:
const MyComponent = () => {
 const inputRef = useRef<HTMLInputElement>(null);

 useEffect(() => {
    inputRef.current?.focus();
  }, []);

  return (
      <TextField
        inputRef={inputRef}
        // ....
      />
  )
}

A bit late to the party but this is what worked for me. The usual inputRef.current?.focus() in a useEffect then
<TextField
  inputProps={{ ref: inputRef }}
  label="First Name"
  size="medium"
  fullWidth
  value={firstName}
  onChange={(e) => setFirstName(e.target.value)}
/>

Since this party seems to be going on.
Since my TextField is not rendered initially in the component
For me:
<TextField
  inputProps={{
    ref: (node)=>{
      node?.setSelectionRange(node.value.length, node.value.length);
    },
    autoFocus: true
  }}
...
/>

works fine


Fix line highlights for "Configure Session State"

Fixes #18032.

Thank you for the help, @serpent5!


[Cordova] Add loadExtension usecase

Impacted tests(approved): new 1, update 0, delete 0
Unit test platform: Crosswalk Project for android 18.46.457.0
Unit test result summary: pass 1, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-5885

LGTM, please drop a mail to @qiuzhong about this new sample app package.


CodeChecker store fails to process analysis, crashes with Error -5 while decompressing data: incomplete or truncated stream', extraInfo=None

Describe the bug
I can successfully analyze and parse my results.  My problem begins when I try to use the server and store the results.  The store process aborts with errors.  See attached file
CodeChecker version
CodeChecker analyzer version:
Kind                 | Version
Base package version | 6.13.0
Package build date   | 2020-07-08T17:44
Git commit ID (hash) | db517a98b095a8a03c6e3a551e8b5943844e1f84
Git tag information  | 6.13
CodeChecker web version:
Kind                          | Version
Base package version          | 6.13.0
Package build date            | 2020-07-08T17:44
Git commit ID (hash)          | db517a98b095a8a03c6e3a551e8b5943844e1f84
Git tag information           | 6.13
Server supported API (Thrift) | 6.28
Client API (Thrift)           | 6.28
To Reproduce
CodeChecker store ./reports  --name uu --url http://ramapo.wi.direct.com:61511/Default
Expected behaviour
No crash
Desktop (please complete the following information)

OS: Linux
Browser: Firefox

Additional context
output.txt

@kenroser In case of SQLite the maximum number of host parameters in a single SQL statement is set to 999 (SQLite version <= 3.32.0 /https://www.sqlite.org/limits.html/). In you case it is larger then 2000. It can be configured with the SQLITE_MAX_VARIABLE_NUMBER variable during compile time (https://stackoverflow.com/questions/15312590/what-is-the-limit-of-sql-variables-one-can-specify-in-a-single-execsql-query). So you have to compile your own SQLite.
For big projects it is recommended to use PostgreSQL database instead of SQLite.
We have docker images for the CodeChecker web server. So you can run a CodeChecker web server and a PostgreSQL server easily with docker. You can find more information and some examples in our user guide: https://github.com/Ericsson/codechecker/blob/master/docs/web/docker.md