[gen-l10n] nested localizations broken

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
This "fix" broke our use case:
Expected results
  @override
  String onboardingDescription(int count) {
    String _temp0 = intl.Intl.pluralLogic(
      count,
      locale: localeName,
      other: 'ERROR: onboardingDescription for this index not found',
      two: '$onboardingThirdDescription',
      one: '$onboardingSecondDescription',
      zero: '$onboardingFirstDescription',
    );
    return '$_temp0';

Actual results
    @override
  String onboardingDescription(int count) {
    String _temp0 = intl.Intl.pluralLogic(
      count,
      locale: localeName,
      other: 'ERROR: onboardingDescription for this index not found',
      two: '\$onboardingThirdDescription',
      one: '\$onboardingSecondDescription',
      zero: '\$onboardingFirstDescription',
    );
    return '$_temp0';
  }

Code sample
Code sample
{
    "onboardingDescription": "{count, plural, =0{$onboardingFirstDescription} =1{$onboardingSecondDescription} =2{$onboardingThirdDescription} other{ERROR: onboardingDescription for this index not found}}",
    "@onboardingDescription": {
        "placeholders": {
            "count": {
                "type": "int"
            }
        }
    },
    "onboardingFirstDescription": "View your upcoming and past games. Select a game and record it by pressing the red button.",
    "onboardingSecondDescription": "To record a game follow the set-up instructions. Once finished recording, save and upload later to get it analyzed.",
    "onboardingThirdDescription": "Upload your game's videos in My Recordings."
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Thanks for the report @tomassasovsky
I tried to recreate the replication using the details you provided, but getting below error while trying to run flutter gen-l10n:
The arb file /Users/dhs/Documents/NCFlutter/new_project/lib/l10n/app_en.arb has the following formatting issue:
FormatException: Unexpected character (at character 24)
"onboardingDescription": "{count, plural, =0{$onboardingFirstDescription} =...

Can you provide complete details or replication details so that we can try to debug it further ?

@darshankawar Fixed the code sample.

Thanks for the update. I was able to replicate it using latest stable and master versions and see below:
import 'package:intl/intl.dart' as intl;

import 'app_localizations.dart';

/// The translations for English (`en`).
class AppLocalizationsEn extends AppLocalizations {
  AppLocalizationsEn([String locale = 'en']) : super(locale);

  @override
  String onboardingDescription(int count) {
    String _temp0 = intl.Intl.pluralLogic(
      count,
      locale: localeName,
      other: 'ERROR: onboardingDescription for this index not found',
      two: '\$onboardingThirdDescription',
      one: '\$onboardingSecondDescription',
      zero: '\$onboardingFirstDescription',
    );
    return '$_temp0';
  }

  @override
  String get onboardingFirstDescription => 'View your upcoming and past games. Select a game and record it by pressing the red button.';

  @override
  String get onboardingSecondDescription => 'To record a game follow the set-up instructions. Once finished recording, save and upload later to get it analyzed.';

  @override
  String get onboardingThirdDescription => 'Upload your game\'s videos in My Recordings.';
}

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.13.2, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.13.2 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ff5b5b5fa6 (7 days ago), 2023-08-24 08:12:28 -0500
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.14.0-14.0.pre.93, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.14.0-14.0.pre.93 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ef9befc9da (11 hours ago), 2023-09-03 11:23:20 -0700
    • Engine revision fbc6f4a540
    • Dart version 3.2.0 (build 3.2.0-131.0.dev)
    • DevTools version 2.27.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

This looks like more of a feature request to allow referencing other arb strings from a given arb string via string interpolation. The previous implementation allowed this unintentionally because it would not escape the dollar signs in the generated code.
It should be possible to work around this by turning the "interpolated strings" into placeholders, and then pass those referenced arb strings in as parameters.
We could implement this feature, it would by check if the symbol after the dollar sign is a valid arb string getter. That's not syntax defined by ICU so it would be custom behavior supported by Flutter i18n.
CC @thkim1011

We also had a breakdown due to the fix carried out. It would be a good feature to write less and reuse patterns.


Added cleanup script for service accounts

Troubleshoot script in case limit exceeded for service accounts
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Would it be possible to read username from rhoas whoami or from localconfig?

Good idea. Will set that in place with priorities:
cmdline arg > localconfig > rhoas whoami > $USERNAME


[REFACTOR] Use more TypedPackedFuncs

This PR converts a good chunk of TVM's global PackedFuncs to be TypedPackedFuncs. Right now, this shouldn't actually change any behavior, since the type information is immediately discarded once the functions are registered in the Registry.
It does make things a lot shorter, using a few helper methods I added on Registry: set_body_simple, set_body_method, and set_body_node_method (names up for debate). These helpers use the properties of function pointers to infer argument and return types:
TVM_REGISTER_API("make.Realize")
.set_body([](TVMArgs args,  TVMRetValue *ret) {
    *ret = Realize::make(args[0], args[1], args[2], args[3], args[4], args[5]);
  });

becomes ->
TVM_REGISTER_API("make.Realize")
.set_body_simple(Realize::make);

This is shorter, runtime-equivalent, and also now has type information!
I don't believe this change has much runtime cost. It might interfere with inlining in some cases, would have to measure. Also, PackedFuncs aren't intended to be all that fast anyway.
So, that's the refactoring part. Now, the RFC part:
(moved to #2983)

cc @nhynes @tqchen

Thanks for the contribution, I like the automated detection of the signatures. The main question is the naming convention to make sure we are not confusing the users. Let us open a new issue about other parts of RFC.
I will summarize some of my take here(which can be moved to the RFC).  I like the idea of Node hierarchy compile time generation. This is something we have thought about for a while and might help https://github.com/dmlc/tvm/issues/2523#issuecomment-458821056
It is always tempting to automate the wrapper generation. However, our past experience teaches me that the automatic wrapper generation is never perfect. Think about how can we support keyword arguments, good pythonic style docstring and so on.  Eventually, we find that it is simpler to just do a manual wrapping, which gives us all the good native features, docs, and keep PackedFunc simple (by only support positional arguments without any meta-data).

This idea actually comes a lot :P https://github.com/dmlc/tvm/pull/2328#issuecomment-450001679
I know, for sure, that we could get good docs with really good codegen like that offered by Rust macros, but I also know for sure that we're not about to rewrite TVM in Rust :)
I think that the boilerplate really does bother new (advanced) users who want to use TVM as a tool. I wonder if there's a way forward here that satisfies all desiderata?

The main question is the naming convention to make sure we are not confusing the users.

Yeah I didn't put any thought into these, would welcome suggestions. Could do something like set_body_to_function_pointer / set_body_to_method_pointer, although those are a bit verbose.

This is ready to merge once we bikeshed the helper names

Here are some thoughts about naming:

set_body_simple -> set_body_typed, since it is really a method for automatic type detection

I did a quick check and seems overloading do work

set_body_method, set_body_node_method-> set_body_method

Use is_base_of to detect whether a class is subclass of NodeRef or Node, and use a different specialization path.

We also need to update the comment a bit to reflect the template arguments

Done @tqchen

Uh, I think that last build just timed out? is there a way to re-run it?

Thanks @kazimuth @nhynes , this is now merge !


SP2-439 - Refactor /goals endpoints to be prefixed with /plans/{plan-id}

This does as in the title but as it stands the Plan UUID in the URL and submitted in the GoalEntity object can be different - we should enforce one of them to be the main point of reference. I'd suggest we populate the object field from the URL parameter.

This PR has been reflected along the lines discussed in the Jira ticket to remove the hierarchy in the API endpoints, and moves all underlying function calls to reflect the initial noun in the API call - e.g. creating a new goal in a plan is performed by calling the PlanController since the URL is /plans/UUID/goals - all the tests have been updated accordingly and a new StepController added since we didn't used to be able to fetch an individual Step.


fix double close on error messages and leaks in body response not closed

This change is

Coverage increased (+0.3%) to 53.659% when pulling 6b5c6ebea5c80282409a1f00f03f159d9e1157ee on feature/err_message_liort_2 into bfa57f13dcff674262049a816b89a7cf7a3c0fa3 on dev.

Coverage increased (+0.3%) to 53.598% when pulling 6b5c6ebea5c80282409a1f00f03f159d9e1157ee on feature/err_message_liort_2 into bfa57f13dcff674262049a816b89a7cf7a3c0fa3 on dev.


fix UI tests missing lifetime annotations

This fixes UI tests, so now cargo test passes.

Well, nevermind, nightly is failing in CI, but is working locally.


Custom download method

Hi there!
I'm trying to setup deployment of Jenkins artifacts and I faced issue caused by authentication API of Jenkins. I need to pass force_basic_auth: yes option to get_url module to fix it, but unfortunately, I don't understand how to override download_unarchive update code method.
It would be great to have an ability to set my own update-code method just like it was done for event hooks. For example:
ansistrano_deploy_via: "task"
ansistrano_deploy_task_file: "{{ playbook_dir }}/deploy/jenkins-download.yml"

What do you think?

Just made a quick implementation, you can see it in this commit

You can modify download.yml with filters such as | default(omit) for your parameters or in this case default it to false and add new variables to the role
What you did at #220 is not the way to go IMHO

@ricardclau thank you for clarification.
I see that my solution is not the best. To be honest, I'm new in Ansible, so any suggestions are appreciated.
Do you mean to modify download.yml and make a new PR?
So, what about other options? What if I need to specify custom headers to get_url? Should I add them to download.yml too? There is a huge number of different options and I don't see an easy way to deal with them without forking the whole role. An ability to make custom deploy strategies would be a great feature, I think. Adding force_basic_auth solves my exact problem, but you never know which else options might be needed in future.
May be I don't understand something? Thank you for your time

I was checking and these new parameters are only supported in Ansible 2.0.
We still support 1.9 so it can be tricky, let´s see if the tests pass

Thank you

Hey @AnatolyRugalev can you please test this branch with your setup setting the variable accordingly? If this is a hassle we will just create a new tag

@ricardclau tested. Works fine for me

Brilliant, will merge and tag today
Regarding a 100% custom strategy, I think the best approach would be to create a noop strategy which basically does nothing so that you would implement the actual strategy in either the before or after update hooks. This would not break anything and may allocate such need
Having said that, if you think about it, there are not that many ways to "deploy" code. We might need a mercurial strategy, support the Google Cloud / Azure equivalent to S3 and similar things but I would prefer adding them as users demand it than opening the door to total custom which adds little benefit to the official deploy_helper module in Ansible
Thoughts?

Huh, I didn't know about deploy_helper module itself because I was searching "ansible capistrano deployment" 😅 and that's why I was asking for customization.
Now I see that your point is absolutely right 👍

Yeah, we created Ansistrano some years before deploy_helper existed. We have plans to integrate it once we deprecate Ansible 1.9 and in that scenario your "100% custom" strategy is just using deploy_helper :)
Cool, closing this for now and if more people demand such thing we will reconsider
Thanks for testing! Tag is available for everyone!


update travis

The Travis build failure is not related to this PR. It is a breaking change on Travis CI side that impacts how xvfb starts. It is fixed in https://github.com/mihaiparvu/ScreenCapLibrary/commit/b9014eca96be3b74b93dd92ce85d612e7dd92ac3 .

Done in https://github.com/mihaiparvu/ScreenCapLibrary/commit/d546f0a8f5eeb76c8355908d395ab0d4db432b03


Require cycle: node_modules/core-js/internals/microtask.js warning

Description
Getting this error when I build my React Native app
 ERROR  RangeError: Maximum call stack size exceeded, js engine: hermes
 ERROR  Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication). A frequent cause of the error is that the application entry file path is incorrect.
      This can also happen when the JS bundle is corrupt or there is an early initialization error when loading React Native., js engine: hermes
 WARN  Require cycle: node_modules\core-js\internals\microtask.js -> node_modules\core-js\internals\microtask.js

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
 ERROR  Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication). A frequent cause of the error is that the application entry file path is incorrect.
      This can also happen when the JS bundle is corrupt or there is an early initialization error when loading React Native., js engine: hermes

React Native version:
info Fetching system and libraries information...
System:
    OS: Windows 10 10.0.19043
    CPU: (4) x64 Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz
    Memory: 2.12 GB / 15.89 GB
  Binaries:
    Node: 14.16.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.18.1 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK: Not Found
    Windows SDK: Not Found
  IDEs:
    Android Studio: Version  <IP_ADDRESS> AI-201.87<IP_ADDRESS>99119
    Visual Studio: Not Found
  Languages:
    Java: 11.0.10
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^17.0.2 => 17.0.2
    react-native: ^0.64.2 => 0.64.2
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce
I'm not sure what caused it but it is similar to this commenter and issue #31173. The solution provided in #31173 is to disable Hermes but I would like to leave Hermes enabled since it is supposed to provide performance improvements.
Expected Results
No error in Metro
Snack, code example, screenshot, or link to a repository:

Thanks for the issue @KrisLau would need more information then just the error message. Could you provide a repo that demonstrates the error from a fresh template.

@safaiyeh Sorry it's taken me so long to get back to you! So I figured out the part that's causing the error but I'm unsure how to resolve it as it was working prior. It's being caused by the
registerComponent call in storybook/index.js. I had followed the instructions from this blog: https://spicyseashells.com/article/react-native-storybook to implement the dev menu toggle for storybook.
// index.js
import {AppRegistry} from 'react-native';
import {name as appName} from './app.json';
import Root from './Root';

AppRegistry.registerComponent(appName, () => Root);

// Root.tsx
const Root = () => {
  const [storybookActive, setStorybookActive] = useState(false);
  const toggleStorybook = useCallback(
    () => setStorybookActive(active => !active),
    [],
  );

  useEffect(() => {
    if (__DEV__) {
      // eslint-disable-next-line @typescript-eslint/no-var-requires
      const DevMenu = require('react-native-dev-menu');
      DevMenu.addItem('Toggle Storybook', toggleStorybook);
    }
  }, [toggleStorybook]);

  return storybookActive ? <Storybook /> : <App />;
};

// storybook/index.js
const StorybookUIRoot = getStorybookUI({
  host: Platform.OS === 'android' ? '<IP_ADDRESS>' : '<IP_ADDRESS>',
  asyncStorage: AsyncStorage,
});

AppRegistry.registerComponent(appName, () => StorybookUIRoot);

export default StorybookUIRoot;

Any updates on this

@safaiyeh Any ideas on what might be causing this?

Looks like this have not too much to do with RN itself and warning is properly thrown in that case.
This seems to be a problem with Storybook for ReactNative and it should be addressed with next version.
See more here: https://github.com/storybookjs/react-native/issues/240


🐛 [firebase_ml_vision: ^0.10.0]  can't update pod

after update firebase code to 7 I can't update pod the app this issue show to me

firebase_storage: Using Firebase SDK version '7.3.0' defined in 'firebase_core'
[!] CocoaPods could not find compatible versions for pod "Firebase/CoreOnly":
  In Podfile:
    Firebase/MLVisionTextModel was resolved to 5.0.0, which depends on
      Firebase/CoreOnly (= 5.0.0)

    firebase_core (from `.symlinks/plugins/firebase_core/ios`) was resolved to 0.7.0, which depends on
      Firebase/CoreOnly (= 7.3.0)

CocoaPods could not find compatible versions for pod "Firebase/MLVision":
  In Podfile:
    Firebase/MLVision

    firebase_ml_vision (from `.symlinks/plugins/firebase_ml_vision/ios`) was resolved to 0.1.1, which depends on
      Firebase/MLVision (= 7.3.0)

CocoaPods could not find compatible versions for pod "FirebaseCore":
  In Podfile:
    firebase_core (from `.symlinks/plugins/firebase_core/ios`) was resolved to 0.7.0, which depends on
      Firebase/CoreOnly (= 7.3.0) was resolved to 7.3.0, which depends on
        FirebaseCore (= 7.3.0)

    firebase_ml_vision (from `.symlinks/plugins/firebase_ml_vision/ios`) was resolved to 0.1.1, which depends on
      Firebase/MLVision (= 7.3.0) was resolved to 7.3.0, which depends on
        FirebaseMLVision (~> 7.3.0-beta) was resolved to 7.3.0-beta, which depends on
          FirebaseCore (~> 7.0)

CocoaPods could not find compatible versions for pod "nanopb":
  In Podfile:
    firebase_core (from `.symlinks/plugins/firebase_core/ios`) was resolved to 0.7.0, which depends on
      Firebase/CoreOnly (= 7.3.0) was resolved to 7.3.0, which depends on
        FirebaseCore (= 7.3.0) was resolved to 7.3.0, which depends on
          FirebaseCoreDiagnostics (~> 7.0) was resolved to 7.5.0, which depends on
            nanopb (~> 2.30907.0)

    firebase_crashlytics (from `.symlinks/plugins/firebase_crashlytics/ios`) was resolved to 0.4.0-1, which depends on
      Firebase/Crashlytics (= 7.3.0) was resolved to 7.3.0, which depends on
        FirebaseCrashlytics (~> 7.3.0) was resolved to 7.3.0, which depends on
          nanopb (~> 2.30906.0)

after comment these Lins in pod.file
# pod 'Firebase/MLVision'
# pod 'Firebase/MLVisionTextModel'
# pod 'Firebase/MLVisionLabelModel'

the update has worked .

Hi @niypoo
I see there's an open issue addressing the case you described https://github.com/FirebaseExtended/flutterfire/issues/4625.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @niypoo
I see there's an open issue addressing the case you described https://github.com/FirebaseExtended/flutterfire/issues/4625.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


vsftpd: 3.0.3 -> 3.0.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vsftpd/versions.
meta.description for vsftpd is: "A very secure FTP daemon"
meta.homepage for vsftpd is: ""
meta.changelog for vsftpd is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/pvnsv105zyffh7jcigkcj8cd7kh7alsn-vsftpd-3.0.5/bin/vsftpd passed the binary check.

1 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 3.0.5 with grep in /nix/store/pvnsv105zyffh7jcigkcj8cd7kh7alsn-vsftpd-3.0.5

found 3.0.5 in filename of file in /nix/store/pvnsv105zyffh7jcigkcj8cd7kh7alsn-vsftpd-3.0.5

directory tree listing: https://gist.github.com/9ba7d80f31c05a4d673a85f7dc0f7fc5

du listing: https://gist.github.com/8d75dab5e7ce7d537e7f910398158426

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
vsftpd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pvnsv105zyffh7jcigkcj8cd7kh7alsn-vsftpd-3.0.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vsftpd https://github.com/r-ryantm/nixpkgs/archive/3e4fd842e638b147cfef4659aaed39a27e8bde5c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pvnsv105zyffh7jcigkcj8cd7kh7alsn-vsftpd-3.0.5
ls -la /nix/store/pvnsv105zyffh7jcigkcj8cd7kh7alsn-vsftpd-3.0.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vsftpd

Maintainer pings
cc @peterhoeg for testing.

Result of nixpkgs-review pr 134543 at 3e4fd842 run on x86_64-linux 1

1 package built successfully:

vsftpd

3 suggestions:

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/servers/ftp/vsftpd/default.nix:39:5:
   |
39 |     license = licenses.gpl2;
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/servers/ftp/vsftpd/default.nix:14:15:
   |
14 |   patches = [ ./CVE-2015-1419.patch ];
   |               ^

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '-dirafter' doesn't match anything in file 'Makefile'
Near pkgs/servers/ftp/vsftpd/default.nix:38:0:
   |
38 |     description = "A very secure FTP daemon";
   | ^

Result of nixpkgs-review pr 134543 run on x86_64-linux 1

1 package built:

vsftpd


Unit test for issue #2313.

This is a test that exhibits issue #2313.

Ah it's this again :/
I know @percysnoodle had started working on a fix a while ago, but it's hard because under the hood restkit is just using KVC

Yep, see https://github.com/RestKit/RestKit/pull/1537 and https://github.com/RestKit/RestKit/pull/1541


GSSOC'21 Distinct Numbers in Window in C++

Hey, I am Kanchan Jeswani, a GSSOC'21 participant I want to add the code for the problem "Distinct Numbers in Window  ".
The problem statement is as follows :
We have given an array of size n and an integer k, and we have to return the count of distinct numbers in all windows of size k.
N = 7, K = 4, here, N is the size of te array A
A[] = {1,2,1,3,4,2,3}
Output: 3 4 4 3
This problem is based on sliding window and hashing
I would love to solve this problem using C++ with well-explained code along with its space and time complexity analysis.
Please assign me this.
Hope to hear from you.

/assign


Allow night motion pr light in room

Add configuration option to allow motion light on selected lights in a room

Great work with all the updates!
How would i config this light to use the new feature with nigt_motion to turn this on during night.
- lights:
        - light.master_bedroom_bed_led # Supports color_temp and xy
      automations:
        - time: "05:30:00"
          light_data:
            brightness: 50
            transition: 3
            color_temp_kelvin: 2200
        - time: "sunrise - 00:40:00"
          dimrate: 1
          light_data:
            brightness: 60
            transition: 3
            color_temp_kelvin: 2200
        - time: "08:30:00"
          orLater: "sunrise + 00:15:00"
          light_data:
            brightness: 50
            transition: 3
            color_temp_kelvin: 2700
        - time: "sunset - 01:30:00"
          light_data:
            brightness: 100
            transition: 3
            color_temp_kelvin: 2700
        - time: "sunset + 00:30:00"
          orLater: "21:00:00"
          dimrate: 2
          light_data:
            brightness: 5
            transition: 3

      light_modes:
        - mode: night_master_bedroom
          state: turn_off

      lux_constraint: 2000

Same indent as other configurations for the light. And remember to configure motionlights. Maybe best to set light_data?
It should not dim down lights during normal day automation, but if the brightness is the same or higher than normal, it probably will change color / color-temp if you configure that.
    - lights:
        - light.master_bedroom_bed_led # Supports color_temp and xy
      automations:
        - time: "05:30:00"
          light_data:
            brightness: 50
            transition: 3
            color_temp_kelvin: 2200
        - time: "sunrise - 00:40:00"
          dimrate: 1
          light_data:
            brightness: 60
            transition: 3
            color_temp_kelvin: 2200
        - time: "08:30:00"
          orLater: "sunrise + 00:15:00"
          light_data:
            brightness: 50
            transition: 3
            color_temp_kelvin: 2700
        - time: "sunset - 01:30:00"
          light_data:
            brightness: 100
            transition: 3
            color_temp_kelvin: 2700
        - time: "sunset + 00:30:00"
          orLater: "21:00:00"
          dimrate: 2
          light_data:
            brightness: 5
            transition: 3

      motionlights:
          light_data:
            brightness: 5
            transition: 3
            color_temp_kelvin: 2200

      light_modes:
        - mode: night_master_bedroom
          state: turn_off

      lux_constraint: 2000

      options:
        - night_motion

So if i understand you correctly, the option night_motion is restricting the light to respond on motion during normal modes like normal, morning and other custom modes?

No. There are functions in motion detection to not turn down brightness. Most use cases is when you need extra light for washing etc, but in your case you probably set motion brightness lower than normal brightness. The motion is still detected, but blocked by brightness already being higher. Since it is being blocked from setting a lower brightness, it should also not set motion color temp.
You could also use the configurations we discussed here

Ok, that sounds good. I cant use the motion_constraints because other lights are depending on the motion-sensors during day.
Will try this out!

Worked as expected, great!


🔄 Synced file(s) with product-os/secrets

Synced local file(s) with product-os/secrets.

This PR was created automatically by the repo-file-sync-action workflow run #1451464200

@balena-ci I self certify!


Can not reproduce

Hi,
Running predictions/DRCAML_mimic3_50/train_new_model.sh, I got such result:

evaluating on test
file for evaluation: ../../mimicdata/mimic3/test_50.csv
[MACRO] accuracy: 0.363, precision: 0.557, recall: 0.465, f-measure: 0.501, AUC: 0.855
[MICRO] accuracy: 0.389, precision: 0.619, recall: 0.511, f-measure: 0.560, AUC: 0.881

prec_at_5: 0.553
rec_at_5: 0.523

The performance of DR-CAML I got above is much worse than the one in Table5.
I cannot reproduce the result of CAML as well, while CNN works quite well as in Table5.
Could you release the parameters or new scripts that can reproduce the performance in the paper ?
Thank you very much !

Hi,
Thanks for sharing your code!
I have a similar problem.
Running predictions/CAML_mimic3_full/train_new_model.sh, I get the following results:
file for evaluation: ../../mimicdata/mimic3/test_full.csv
3372it [00:28, 117.89it/s]
[MACRO] accuracy, precision, recall, f-measure, AUC
0.0468, 0.0758, 0.0626, 0.0686, 0.8875
[MICRO] accuracy, precision, recall, f-measure, AUC
0.3511, 0.6305, 0.4420, 0.5197, 0.9844
rec_at_8: 0.3640
prec_at_8: 0.6943
rec_at_15: 0.5115
prec_at_15: 0.5481
These results are much worse than the results in table 4 of the paper.
I appreciate it if you release the parameters for the model you trained or an updated version of the scripts you used for that so that I can reproduce your results.
Kind regards,
N

Hi,
I have the same issue as well. I'm able to reproduce the results with the pre-trained models you've provided.
When I attempt to train the model from scratch, it doesn't give the same performance. I think the problem might be the number of epochs. Early stop doesn't occur within 200 epochs, and the final performance is the result after 200 epochs.
Best,
Vijay

Check evaluate_model.sh for exact reproduction of results of CAML. The model parameters have been published. There is also one script in the DR-CAML folder.

Hi,
Thanks for sharing your code!
I have a similar problem.
Running predictions/CAML_mimic3_full/train_new_model.sh, I get the following results:
file for evaluation: ../../mimicdata/mimic3/test_full.csv
3372it [00:28, 117.89it/s]
[MACRO] accuracy, precision, recall, f-measure, AUC
0.0468, 0.0758, 0.0626, 0.0686, 0.8875
[MICRO] accuracy, precision, recall, f-measure, AUC
0.3511, 0.6305, 0.4420, 0.5197, 0.9844
rec_at_8: 0.3640
prec_at_8: 0.6943
rec_at_15: 0.5115
prec_at_15: 0.5481
These results are much worse than the results in table 4 of the paper.
I appreciate it if you release the parameters for the model you trained or an updated version of the scripts you used for that so that I can reproduce your results.
Kind regards,
N

Hi,
I have the same problem. Any solution to train a new model to reproduce the results?
Best,
Yucheng


More run away memory for windows and group by

Problem
Size-based grouped windows do not evict empty groups even when emit_empty_windows is set. In a streaming context, where groups are likely to change, such as using size-based windows for correlation, this will lead to unbounded memory growth.
context: https://github.com/tremor-rs/tremor-www-docs/pull/89/files#r595935865
Possible Solution(s)
Evict empty groups if emit_empty_windows  is false

This is not only limited to size based groups. We keep the groups around forever unless eviction_period is set, in which case we clear out the group data for which we didnt receive events.
We reset the aggregation states every time we emit from a window, so these are not unbounded. It is just the group_data bookkeeping map is never cleared out (unless eviction_period is used).

This is fixed on main with #1143


Fix .connectivity.proxy.secretName defaulting

Found it while trying to re-create glasgow.

@kopiczko just delete the parameter from values.yaml if it is an empty string.

@kopiczko just delete the parameter from values.yaml if it is an empty string.

But I still would have to update the schema, no?

I tested it with glasgow and it works. Going with it. I prefer to have empty value defined in values.yaml. If that's not desired then it can be corrected in a future PR.

/run cluster-test-suites


Porting CC 110 Recaman's Sequence

🔨 Added:

timestamps
links to code example, references, tutorial playlist, livestream archive
descriptions, icons, tags
thumbnails
showcase contributions

Ready for preview 🚂
📋  Notes:

p5.Env is deprecated now. It would be nice if the sketch is updated with p5.Envelope() in place of it.
Anything more to add in related challenges?

Looks good! The thumbnail looks beautiful!!

Thanks so much!  I love your image, too!

So great!!


Use 'main.css' for this site

it'd be nice to use our own 'main.css' for this site - imported via NPM - like we do for H5BP. Right now, we do include the CSS but it's out of sync so importing via NPM would keep it up to date.

@coliff any thoughts on how to do this cleanly? This is just a static site, so there's not really a build step we can rely on.

oh right... good point. We could load it minified from the JSDelivr CDN.
<EMAIL_ADDRESS>This is an undocumented way of using 'main.css' though... maybe we could add this as an alternative way of using it to main.css to that projects README.

Live! https://h5bp.org/


docs: broken link to generator github actions (Fixes #3190)

Description
This PR fixes a broken link in the AsyncAPI Generator Installation Guide. The outdated link to the GitHub Marketplace Action for AsyncAPI documents needs to be updated with the correct URL.
Current Link: https://github.com/marketplace/actions/generator-for-asyncapi-documents
Updated Link: https://github.com/marketplace/actions/generator-validator-converter-and-others-all-in-one-for-your-asyncapi-docs
Resolves #3190

Summary by CodeRabbit

Documentation

Updated links and descriptions in the AsyncAPI GitHub Actions documentation to reflect current offerings.
Revised the "Happy Birthday AsyncAPI" document to include new links and npm scope updates for React and Web components.
Added details about AsyncAPI Special Interest Group meetings and additional reading resources.

@TRohit20 can you please take a look

@TRohit20  No worries man!

@quetzalliwrites PTAL

/update

/rtm


Use Documentation Annotations over nodoc

Summary of changes

added  @_documentation(visibility: private) under nodoc comments to make
sure public documentation is not generated for classes, functions or properties for internal purposes only.

Checklist
~- [ ] Added a changelog entry~
Authors

@KunJeongPark

We will need to bump the Xcode and Swift version to use this attribute. See Sammy's PR here for those versions: https://github.com/braintree/braintree_ios/pull/1034


Fix custom rules test

As revealed by the discussion at eslint/eslint#5577, we are doing Bad Things™ with our custom rules test. This is the fix.

Just read through the issue -- good stuff. I don't see any reason not to merge this and then go ahead with getting #25 in place.


Survey velocities don't match exactly original curvilinear velocities

@renskegelderloos
The survey aligned velocities don't exactly match the original velocities for curvilinear grids. It might be that there's a small error due to the extra operation with sin and cos from model output. Let me know if you get results that don't look right.
This is where I noticed it:
https://github.com/malmans2/oceanspy/blob/959a2488519008f50804325a0a69925304217fdf/oceanspy/tests/test_compute_functions.py#L406-L448

My understanding of this issue is that, this is a problem with the test rather than anything wrong with the code. The test is doing the following things:

calculate the geographical_aligned velocity. Here is a test showing it is doing the correct thing.

U = od_in._ds['U']
V = od_in._ds['V']
U = od_in._grid.interp(U, "X", boundary="fill", fill_value=np.nan)
V = od_in._grid.interp(V, "Y", boundary="fill", fill_value=np.nan)
od_in = od_in.compute.geographical_aligned_velocities()
o1 = np.hypot(U,V)
o2 = np.hypot(od_in._ds['U_zonal'],od_in._ds['V_merid'])

np.allclose(o1,o2)# True

The result here is True, which means everything is working fine.

Making a section, and then calculate the section aligned velocity from the data on the section.

s1 = np.hypot(od_surv._ds['U'],od_surv._ds['V']) # "original" data
s2 = np.hypot(od_surv._ds['U_zonal'],od_surv._ds['V_merid']) # zonal/meridional vel
s3 = np.sqrt(ds_out['tan_Vel']**2 + ds_out['ort_Vel']**2) # section aligned

np.allclose(s1,s3) ## False

That's more or less the original test. The current speed does not match. But s3 = s2, and if you do
#correspond to the case when rotate = False
od_surv._ds = od_surv._ds.drop(['U_zonal','V_merid'])
ds_out = survey_aligned_velocities(od_surv)
s4 = np.sqrt(ds_out['tan_Vel']**2 + ds_out['ort_Vel']**2)

np.allclose(s4,s1)## True

you also get s4 = s1. This suggest that the compute function is alright.
I can briefly explain what I think is going on here. The survey_aligned_vel function always prefer to use U_zonal. And subsample.survey_stations only interp the components of velocity, rather than their direction and strength, which actually make sense.
say we have
$$U_1^2+V_1^2 = u_1^2+v_1^2$$
$$U_2^2+V_2^2 = u_2^2+v_2^2$$
where u represent the original velocity on c-grid, U represent the transformed velocity. After xesmf interpolation:
$$U = w_1U_1+w_2U_2$$
$$V = w_1V_1+w_2V_2$$
$$u = w_1u_1+w_2u_2$$
$$v = w_1v_1+w_2v_2$$
Then when you are interested in the current speed at the survey station, you got two different result
$$s_1 = u^2+v^2 = w_1^2(u_1^2+v_1^2)+w_2^2(u_1^2+v_1^2)+2w_1w_2(u_1u_2+v_1v_2)$$
$$s_2 = U^2+V^2 = w_1^2(U_1^2+V_1^2)+w_2^2(U_1^2+V_1^2)+2w_1w_2(U_1U_2+V_1V_2)$$
The first two terms are the same, but the last term  does not necessarily match.
I also don't think we need to change this current test, because it works. And you can argue that assert_almost_equal is a even better test.

So, in summary, you recommend changing the test to assert_almost_equal and closing?

the test is already assert_almost_equal, I suggest we don't change anything. It might be nice if we can refer to this issue in the comment.
Change
'''
TODO: not exact match. Check with Renske!
'''
to
# see issue #70 for more info.

, so that less people will bother Renske.

Sounds good. Please make the change in the comment and close!

closed by PR #278


Use visible_alias instead of hardcoding them in docstrings

Thank you for your contribution! visible_alias makes a lot more sense here!


SW-6146 Remove unused list of supported locales

We used to configure Spring with an explicit list of supported locales, but we
removed that in commit 51b589f7 to support adding country codes to locales to get
country-specific date and number formatting.
Remove the list of locales we used to pass to Spring; people might think they
need to edit it when adding languages, when in fact it isn't referenced anywhere.

#2497  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite


Feature Button

Button Component includes

Standard Buttons
Outlined Buttons
Icon Button
Link Button
Floating Action Button

code looks nice , you can merge!


Graph View not working

Nothing is being rendered after running the command please fix it.

Completed in e148ad5a25f389b99ced64c5490e6e13f72c5912


Fix #175: give ROOTSYS priority

Coverage remained the same at 99.76% when pulling b70e02fd065e75d6491b561a570c976a7cb2d12e on ndawe:master into 4e0b6ad2de5728e1d1d457897aefc391bee20cb6 on rootpy:master.


GCN parameter n_timepoints cannot be any value that's not 1

The other parameters of each layer were hard coded.
For example, 675 is the number of voxels in the ROI mask for subject 4
I will need to look into it to find out how to allow different number of TRs, and possibly for other parameters for different subjects.
cc @srastegarnia
It will be useful to know how these parameters were set:
https://github.com/main-educational/brain_encoding_decoding/blob/6fbd95c3d93e5e7d82628f901c60fa813bf234bb/src/gcn_model.py#L13-L18
If we set n_timewindow=3, we got this error:
RuntimeError: mat1 and mat2 shapes cannot be multiplied (10800x1 and 3x32)

I have resolved the issue - the window length in data preprocessing has to match the parameter used in the model
Will think about how the tutorial flow to make this clearer.


Update faq.yml

@shayoniseth : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Allow a list of environment variables to be passed publish workflows

"Any environment variables set in an env context defined at the workflow level in the caller workflow are not propagated to the called workflow." A new input for publish.yml and publish_pure_python.yml should be added which accepts a YAML list of environment variable names and values (encoded as a multiline string). Each of the build steps of both publishing workflows should call a Python script which parses the YAML input and writes each environment variable to the file defined by GITHUB_ENV.

Am I misunderstanding this:
If I define a env at the top of an actions file, it will not be passed to any publish step?

That's correct

That's correct

😭 All this time, I thought it was my CI script.

Thank you @ConorMacBride for working on this


Electron 7.x.x and > throws context aware warning

When loading the segfault handler in Electron 7.x.x and greater there is a warning in the output:
(node:39360) Electron: Loading non context-aware native modules in the renderer process is deprecated and will stop working at some point in the future, please see https://github.com/electron/electron/issues/18397 for more information

Is this something that is tricky to have implemented? It doesn't look critical in the stable version of Electron but will stop working in the future. We really appreciate the utility of segfault-handler and the work that has gone into it.
No one on our team really understands what it would take to create a PR - we would be very happy to help test.

The issue mentioned says that N-API or Context Awareness is required in the future. Currently we use NaN, so it will require a rewrite to use N-API. Luckily, the code base isn't so large.


Scaling using ARM, CLI or Powershell

Is it possible to move up or down tiers using a method other than the portal?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7232dd1a-d250-1304-14ec-db25f04cff48
Version Independent ID: 29250085-defe-18ac-1ca9-2155b778127b
Content: Upgrade and scale an Azure API Management instance
Content Source: articles/api-management/upgrade-and-scale.md
Service: api-management
GitHub Login: @mikebudzynski
Microsoft Alias: apimpm

Thank you for your feedback, @nastassiar! Portal is just another client app to the ARM REST API so you should be able to define the same calls in an ARM template and call them from a Powershell or CLI commands. Here's the list of REST operations for APIM: https://docs.microsoft.com/en-us/rest/api/apimanagement/

@nastassiar Since we haven't heard back, we will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


diable val and test shuffling

Fixes part of #1551

Need to request .shuffle in the dataloader

If shuffle is set to True, the DataLoader will set the RandomSampler, so as an alternative, we could check if isinstance(dataloader.sampler, RandomSampler).

@awaelchli ahhh there it is haha. good catch.

Hello @williamFalcon! Thanks for updating this PR.

In the file pytorch_lightning/trainer/data_loading.py:

Line 202:111: E501 line too long (116 > 110 characters)

@williamFalcon check update


tcpdump-style filtering

Hi,
i have another question.
For the project i'm working on, i need tcpdump-style packet filtering. Here is the tcpdump-call what does  the job:
$ tcpdump -i en4 ether proto 0x22f0

I something like this  possible with the layer2 module?
I saw there is some filter related code in src/js/capture.js. When i naive tried to pass the filter as an option in the capture.Live constructor like this:
var capture = new layer2.capture.Live('en4', {filter: 'ether proto 0x22f0'});

all i got was an error:
> Error: link-layer multicast filters supported only on ethernet/FDDI/token ring/ARCNET/802.11/ATM LANE/Fibre Channel

Greets and thanks in advance,
Christian

Filters weren't fully implemented yet (hence the missing documentation :) ). I just released a new version (0.1.6) which should support them. Let me know if you run into any issues.

Works perfect, thank you.

Glad to hear!


Key Manager/OAuth2.0 - Userinfo

Implement userinfo API to get user's information for given token.
Sample impl - https://docs.wso2.com/display/IS540/Basic+Client+Profile+with+Playground

Fixed with https://github.com/wso2/carbon-auth/pull/129


Automated Package Upgrade

:tada: This PR is included in version 5.3.86 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Rector] Apply FuncGetArgsToVariadicParamRector

Refactor func_get_args() in to a variadic param with FuncGetArgsToVariadicParamRector rector rule.
Checklist:

[x] Securely signed commits

@MGatner updated https://github.com/codeigniter4/CodeIgniter4/pull/4963/commits/cb7458f424481c0683ccd830f51d016edd749d97
@paulbalandan the git hook somehow changing tabs on return, need manually run :
vendor/bin/php-cs-fixer fix system/Helpers/text_helper.php

@paulbalandan the git hook somehow changing tabs on return, need manually run :
vendor/bin/php-cs-fixer fix system/Helpers/text_helper.php

Not on me, though. Maybe your IDE has indentation set to tabs?

It is 4 space :

Actually, I run the manual command in IDE terminal, so if the IDE is the issue, it should be rolled back to invalid state. Let's see if this will happen again in the future.


VS Code continuously crashes on Windows 11 for more than month

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.94.2 and above (previous versions are also affected, but not quite certain which exactly)
OS Version: Windows 11 Enterprise v. 24H2, build 26100.2033

Steps to Reproduce:

Run VS Code, work with it
Put your machine to the sleep mode or hibernation, then wake it up
[Optionally] Try to search something across the folders:

You will see ENOENT error when trying to spawn search process

Close VS Code and try to open it again

Observe error message:

Observe unstopped VS Code processes:

Computer restart doesn't help
The only workaround is to uninstall VS Code and reinstall it again

Executing unins000.exe doesn't uninstall VS Code folder completely after incident occurred - You need to double-check for running processes in task manager, kill them and remove the rest of files manually

Repro is not stable: It might appear once-twice per week - Update of VS Code doesn't seem to be related

Update of OS doesn't seem to be related

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.95.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

This issue affects every version above 1.94.2 (including 1.95.1) and, most likely, the old version as well

Is it possible to check if endpoint protection, anti-virus or something else may quarantine/remove that file?
However "imported from" looks strange.
Also, are you using user install or system install?

Is it possible to check if endpoint protection, anti-virus or something else may quarantine/remove that file?

Not sure how to figure that out... I don't have anything installed on my machine but built-in Windows Security antivirus. I don't see anything related to VS Code installation in the "Protection history" there.

Also, are you using user install or system install?

System installer

Any update on this one? It's still happening

Can you share the full command line of the running vscode processes when this issue happens.

Can you share the full command line of the running vscode processes when this issue happens.

Can you please clarify what do you mean exactly? I don't use CLI commands to run VS Code, I'm just click on the VS Code icon in taskbar.
Although, I don't know if it can help you or not, but I just tried to open VS Code from terminal (pwsh environment) and here is what I got:
PS C:\Users\ivannosar> code
node:internal/modules/cjs/loader:1235
  throw err;
  ^

Error: Cannot find module 'C:\Program Files\Microsoft VS Code\resources\app\out\cli.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1232:15)
    at Module._load (node:internal/modules/cjs/loader:1058:27)
    at c._load (node:electron/js2c/node_init:2:16955)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:188:12)
    at node:internal/main/run_main_module:28:49 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v20.18.1

Also, is there any way to mark this issue somehow to prevent automatic close due to lack of activity? This issue is really annoying and has a strong but not guaranteed repro: It may pop up next day after previous appearance or it can pop up even in more than a week.

@deepak1556 can you please reopen this issue?

Executing unins000.exe doesn't uninstall VS Code folder completely after incident occurred - You need to double-check for running processes in task manager, kill them and remove the rest of files manually

You had mentioned certain vscode process are blocking uninstall, vscode is multi process application knowing the full commandline parameters of a process will help us identify the type of process causing the issue. Can you use https://learn.microsoft.com/en-us/sysinternals/downloads/process-explorer to get the full commandline value of those running process when the issue happens.

Can you use https://learn.microsoft.com/en-us/sysinternals/downloads/process-explorer to get the full commandline value of those running process when the issue happens.

Sure, will do!


[WIP] Feature aws json

WIP for the AWS json full feature.
NOTE
If you plan to contribute to this feature, please PR against this branch.  We designed the first supported endpoint to (hopefully) provide a foundation/pattern on which to build the subsequent changes.  Once we get them all, we'll release this.
To make sure we don't trip on each other, please update the list below by putting your name next to the API you intend to work on.  Once it gets into PR we can x that API and move on.  Thank you in advance for any support/tests/reviews/code work!
JSON Supported APIs

[x] CreateQueue - Admiral-Piett
[ ] GetQueueAttributes

(unsupported attributes are mocked)

[ ] GetQueueUrl
[ ] SendMessage
[ ] SendMessageBatch
[ ] ReceiveMessage
[ ] DeleteMessage
[ ] DeleteMessageBatch
[ ] PurgeQueue
[ ] Delete Queue
[ ] ChangeMessageVisibility
[ ] SetQueueAttributes

(Only supported attributes are set - see Supported Queue Attributes)

Steps For PR:

Create a model for your new Request struct
a. Implement <NewStruct>.SetAttributesFromForm - even if it just returns without doing anything.
b. You may also need to handle UnmarshalJSON for any nested request attributes/objects.
Create a RequestFunctionV1 function
Swap the reference in the routing table to the new V1 routing table
Copy the code from the old function
Call utils.REQUEST_TRANSFORMER with your new struct
Update fetches from the request Form to look at the new struct
Make the new V1 function return a status and response struct
Update any references to createErrorResponse to use createErrorResponseV1
Delete old/non-V1 function
Update/Create/Remove unit tests
Smoke Test with the SDK
Add automated tests in smoke_tests/... (use the v2 SDK as much as possible)
PR

Hi folks, I'd like to offer some testing support on this issue. Like others, we have been pinned to an old version of the AWS SDK to mitigate this, but we are starting to feel some pressure to resolve. Some of my peers suggest switching to LocalStack, but I am fighting to stick with goaws, as it has been flawless for us until now.
I have a suite of tests I can run in a vagrant environment with a goaws container, and I can quickly switch between AWS SDK versions and goaws versions (including image built from feature-aws-json branch).
We are using .NET AWS SDK.
Our test status right now:

AWS SDK
goaws
Pass/Fail

<IP_ADDRESS>
admiralpiett/goaws:v0.4.5
:heavy_check_mark:

3.7.300.37
admiralpiett/goaws:v0.4.5
:heavy_multiplication_x:

<IP_ADDRESS>
feature-aws-json docker build .
:heavy_check_mark:

3.7.300.37
feature-aws-json docker build .
:heavy_multiplication_x:

I'll keep a watch on this PR and contribute where I can.

@Matthew-Davey That's awesome, thank you!  The more the merrier!  I would definitely appreciate any support on this, it's a hefty feature.

@Matthew-Davey @kojisaiki @kojisaiki @mancej I think I've got something here for the pattern we were talking about before.  I think it's workable and, to me anyway, simplifies things for once we get into the actual Action level logic.  Let me know what you think when you have time!
https://github.com/Admiral-Piett/goaws/pull/289

@kojisaiki I just squashed some commits in here that I just now noticed you committed from a while ago - just to make things a little easier to manage.  After looking closer though - are those still valid?  They look like they're tests/pseudo code to explore the pattern early on?
Anyway, they conflict with my PR now.  Do you have any complaints if I get rid of them so I can rebase onto this cleanly?

@kojisaiki I just squashed some commits in here that I just now noticed you committed from a while ago - just to make things a little easier to manage. After looking closer though - are those still valid? They look like they're tests/pseudo code to explore the pattern early on?
Anyway, they conflict with my PR now. Do you have any complaints if I get rid of them so I can rebase onto this cleanly?

No problem to squash completely my old commit 👍
I deleted my initial PR https://github.com/Admiral-Piett/goaws/pull/285

Thanks @kojisaikiAtSony!  Apparently I had incorporated them into my last commit on the CreateQueueV1 and forgotten - sorry about that.  So they're there now.  😄
Regardless, I just merged so I think we're ready.  Did you wind up having time to take a look at this?  If so, do you know what API you were looking at?  I'll mark you down on the list so I can grab something new?

I tried to migrate SendMessage in an old PR, but I can look into it again with latest V1 flow 👍
While I'm in charge of SendMessage, I'd like to mark the name of the person in charge so that other people don't have to duplicate their efforts.

Looks good! but I cannot edit the description...

@kojisaikiAtSony Boo GitHub 🙂.  I guess because it's "my PR", I'll see if I can change that.  I put you on there for now though.  Thanks for hacking on SendMessage!

Hi @Admiral-Piett , sorry it's too late, but I can start again. I may be able to get other team members to help us out, so can I get assignments for other APIs as well?

SQS - GetQueueUrl
SNS - CreateTopic

Hi @Admiral-Piett , sorry it's too late, but I can start again. I may be able to get other team members to help us out, so can I get assignments for other APIs as well?

SQS - GetQueueUrl
SNS - CreateTopic

Yep, you got it!  @kojisaikiAtSony

Hello! I submitted a PR for sqs.ReceiveMessage. I had started it just to see if I could make any progress before committing to the refactor here, but then ended up getting a working implementation.
I also am in need of sqs.ChangeMessageVisibility, so I will also start work on that.

@Admiral-Piett
Can I get assignments for below APIs?

SQS - SendMessageBatch
SQS - DeleteMessageBatch
SNS - ListTopics
SNS - DeleteTopic

@Admiral-Piett
My side have 3 engineers, so may I get assignment for remaining below APIs if you don't mind?

SNS - SetSubscriptionAttributes
SNS - GetSubscriptionAttributes
SNS - ListSubscriptionsByTopic
SNS - ListSubscriptions

@Admiral-Piett thank you for accepting our contribution! As goaws users, we will try the new version soon! We will also continue to contribute with issues and PRs 👍


Codecov

This branch can be seen there at https://codecov.io/gh/lbighetti/hades/branch/codecov

This solves #15


wsl2 install errror0x80041002

Windows Build Number
Microsoft Windows [版本 10.0.19043.1202]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
5.10.16
Distro Version
Ubuntu18.04
Other Software
No response
Repro Steps
1.wsl --set-default-version 2
2.Install Ubuntu18.04 in MS store
3.Installing.....Error:0x80041002
1.wsl --set-default-version 1
2.Install Ubuntu18.04 in MS store
3.Install succeed!
4.wsl --set-version Ubuntu18.04 2
5.Error:0x80041002
Expected Behavior
Bug?
Actual Behavior
I'm crazy!!!!
Diagnostic Logs
wsl.zip

Looks like a failure to create the virtual network, I'll forward this along to my networking counterparts.

Is the "Virtual Machine Platform" installed?
What does "sc.exe qc vmsmp" show?

Is the "Virtual Machine Platform" installed?
What does "sc.exe qc vmsmp" show?

installed vmware.
but uninstall vmware error 0x80041002 still exist.

Is the "Virtual Machine Platform" installed?
What does "sc.exe qc vmsmp" show?

installed vmware.
but uninstall vmware error 0x80041002 still exist.

We need more tracing to understand the failure.  Can you try the following:

Reboot
https://github.com/microsoft/SDN/blob/master/Kubernetes/windows/debug/starthnstrace.ps1
Repro the problem
Stop the tracing in step 2.
https://github.com/microsoft/SDN/blob/master/Kubernetes/windows/debug/collectlogs.ps1

The tracing step 2 will tell us more about what went wrong.  It includes some key providers missing from wsl.zip.
The logs in step 5 will tell us more about the state of the machine.
Thanks!

We need more tracing to understand the failure. Can you try the following:

Reboot
https://github.com/microsoft/SDN/blob/master/Kubernetes/windows/debug/starthnstrace.ps1
Repro the problem
Stop the tracing in step 2.
https://github.com/microsoft/SDN/blob/master/Kubernetes/windows/debug/collectlogs.ps1

The tracing step 2 will tell us more about what went wrong. It includes some key providers missing from wsl.zip.
The logs in step 5 will tell us more about the state of the machine.
Thanks!

collectlogs.ps1.zip
server.zip
execute collectlogs.ps1 have many error.

Something is interfering with virtual NIC creation.  Can you upload the files in C:\Windows\Logs\NetSetup?

Something is interfering with virtual NIC creation. Can you upload the files in C:\Windows\Logs\NetSetup?

NetSetup.zip

??????

Is the "Virtual Machine Platform" installed?
What does "sc.exe qc vmsmp" show?

I'm running into a similar issue, and do have the "Virtual Machine Platform" installed. However:
> sc qc vmsmp
[SC] OpenService FAILED 1060:

The specified service does not exist as an installed service.

Is the vmsmp service only available under Hyper-V?

Regarding the NIC creation problem, I've re-asked a partner team here to take a look.
The virtual machine platform should install the hyper-v virtual switch even without Hyper-V.  "vmsmp" might not be the best way to detect that, however, because it only starts when WSL launches.  Try "sc query vmsp"

Regarding the NIC creation problem, a VMWare component appears to be blocking the NIC creation.  If it's still installed, you can try removing the VMWare product.  However, we have seen that even uninstalling it won't always help because they leave behind some cruft.  If you have already uninstalled, a network reset may purge it.  However, that purge may not even be sufficient.  We've reached out to VMWare in the past on the issue but haven't gotten any traction with them.

sc query vmsp is indeed showing an installed (and running) kernel driver.
When I try to start WSL version 2 and subsequently run sc query vmsmp or sc query vmsp it doesn't show either. Even after a clean re-install of Windows, is there a way that I can check (aside from sfc or re-enabling the feature with a reboot inbetween) if VMP is still installed correctly?
Or should I be able to figure out what's going wrong from the same logging, as in, if something is blocking the creation of the virtual NICs?
Not trying to hijack this thread, but I think the issue is really similar and another issue was closed with a "we're backporting some stuff" while I'm on the latest version of Windows Insider Builds 😅.

Is c:\Windows\system32\drivers\vmswitch.sys present?

Is c:\Windows\system32\drivers\vmswitch.sys present?

Yes, present:
0dd13e65d51b89a25399528c0c7216581a8f99e834f179d5aa88170442835c07  vmswitch.sys
-a----         9/11/2021   2:14 PM        2275104 vmswitch.sys

I see that the latest build contains fixes for specifically Hyper-V and WSL not running on ARM64. Hopefully that fixes it.

Regarding the NIC creation problem, a VMWare component appears to be blocking the NIC creation. If it's still installed, you can try removing the VMWare product. However, we have seen that even uninstalling it won't always help because they leave behind some cruft. If you have already uninstalled, a network reset may purge it. However, that purge may not even be sufficient. We've reached out to VMWare in the past on the issue but haven't gotten any traction with them.
It's also possible a 3rd party anti virus is blocking access to reg keys that need to change.

reinstall system can it be solved?

That should work as long as the offending 3rd party software isn't re-installed.


⚠ Samsung has degraded performance

In 332c524, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2418 ms

Resolved: Samsung performance has improved in 27eec35.


Put now waits 5 seconds for status to appear

Looks great. Anything magical about 5 seconds?

Not really, it just keeps the out/simple test short.

If you have a different suggestion, I'm glad to hear it.

Thanks!

Thanks for merging it!


Add certificate pinning

Add certificate pinning to the app

Before doing anything on the app side, should understand from the Realm team why the SDK is handling this for data access, but not for authentication. Moving to "Blocked"


Institutions able to set withdrawl date outside of study period.

Describe the Bug
PSI can (incorectly) report a withdrawal date outside of the student's original study dates, prompting a re-assessment based on the new (potentially longer) study dates.
Expected Behaviour
Withdrawal dates should be limited to the study period.  If institution attempts to set date > study end date, a validation should prevent this from being submitted.
Actual Behaviour
Currently, it is possible for an institution to specify a withdrawal date after the study end date.
** Steps To Reproduce**
Steps to reproduce the behaviour:

Go to '...'
Click on '....'
Scroll down to '....'
See error

this is a duplicate- move to close


Syndicate codewords are not useful/used

Description
Most people forget their codewords, so it would be really great to mark these in the chat with a red/blue color that is visible only to other Syndicates.
The issue is that no one remembers these codewords, so they aren't useful. But if they are shown as visible feedback this won't happen again.
Reproduction

Play as a Syndie, find another Syndie
Say a codeword to prove that you are also a Syndie
Get shot and killed as the other one doesn't remember any codewords

Additional context
None

If this is considered making it too easy to spot codewords on General Radio, alternatives would be to highlight them on the chat popup boxes only, or to introduce an easier way to keep them in your field of view such as an on-by-default setting to have them written at the top of your screen in a small overlay

Whats the problem with making it easy to spot - you're the informed minority on the station and it should be easy to find each other roundstart.

i think it's just not coded yet:tm:
everyone wants silly codeword highlighting

Just know that they could kill you even if they also know codewords. Syndie agents are not a team and it's always a risk to out yourself to another syndie because they might kill you for your equipment or TC if it benefits them.
This won't change anything with what the other syndie will do.

I find it rather amusing personally. Current list of codewords is so random you can't possibly ignore them in a conversation. They are so out of the left field you have to notice that something's wrong and it's not a sentence a sane human would say.

Well isnt this an old-fashioned issue.

I find it rather amusing personally. Current list of codewords is so random you can't possibly ignore them in a conversation. They are so out of the left field you have to notice that something's wrong and it's not a sentence a sane human would say.

On several occasions I've dropped code words in conversation with players I've been tasked to work with, only for it to fly right over their heads. I had to break down and write a message explicitly telling them on a paper and hand it to them. On at least one occasion they didn't even realize they rolled syndie until I told them directly.

I think having it highlight the word in text for other syndis would be good

Ive been looking into implementing this for a bit and am running into issues with getting ahold of the code words from the TraitorRole component (controlled server side) and handing it to the speechBubble system (controlled client side).
If I remember correctly, the Mind component/system is getting reworked. Should implementing this hold off until the rework is done or can anyone think of a clean way to send the code word data and if the user has a traitor to their speech bubble system?

Depending on the fraction of people who miss codewords because they simply don't realize they're syndicate, I think just making syndicate membership more obvious is the best solution; currently the only way to know if you're a syndicate if you miss the message is if you press the dedicated "am I a syndie" button.
Putting codewords at the top of the screen makes sense.

if you are shooting up medbay you will probably not notice the codewords are the top of your screen, having text highlighted red so you know someones cool would help

codeword highlighting has been added so this isn't an issue anymore (If anything they use them TOO much)!


Rework implementation of user-defined RDL enumerations

Issue
The current compiler implementation of user-defined enumerations (Custom enum types defined within SystemRDL) relies on extending the behavior of Python's Enum base class. The compiler makes use of the Enum functional API to dynamically create subclass definitions of UserEnum.
Use of Python's Enum ends up being cumbersome for two reasons:

Runtime Python type creation presents unique challenges when pickling UserEnum objects.
Python's Enum logic prohibits the use of member names that collide with Python's sunder and dunder naming conventions as a way of future-proofing the Enum implementation. This imposes unnecessary limitations on RDL source code, and other imported register models (as seen in #130).

Upcoming Change
The compiler's implementation of UserEnum will be reworked such that it is no longer dynamically subclassed during RDL compilation. Instead, user-defined enumerations will become regular classes that are instantiated exactly once for each unique RDL definition.
UserEnum
The UserEnum class will no longer be derived from Python's Enum. To support this, some slight changes are made:
New UserEnum members

UserEnum.type_name
Denotes the type name used in the RDL definition
UserEnum.members
An ordered dictionary of member_name : UserEnumMember pairs.

Unchanged behavior

UserEnum objects will still be iterable. Instead of singletons, the iterable will yeild UserEnumMember instances.
All existing documented members/methods remain unchanged.

Deprecated support

Now that Node.get_property('encode') will return a class instance of UserEnum, the use of __name__ to determine the enum type name will be deprecated. A compatibility backfill will be added, but this will emit a deprecation warning.
The is_user_enum() utility function will retain equivalent behavior but will emit a deprecation warning if used.

Removed support
Support for any other features intrinsic to Python Enum objects not mentioned here will be removed. Searching through public repositories showed that this does not appear to result in a compatibility conflict, since nobody appears to be using these Enum-specific features of UserEnum.
UserEnumMember
Rather than enumeration members being singletons, Enumeration members will be represented by individual class instances of UserEnumMember.
This new class maintains much of the prior functionality:

UserEnumMember.name
Identifier string of the enum member
UserEnumMember.value
Integer value of the enum member
UserEnumMember.parent (NEW)
Points to the parent UserEnum instance
UserEnumMember.__str__()
Stringifies the enum to "EnumTypeName.MemberName".
This backfills compatibility for some existing usages.
UserEnumMember.__int__() and UserEnumMember.__bool__()
Allows implicit enum member casting to integer/boolean datatypes.
All existing documented members/methods remain unchanged.

This turned out to not be the correct way to address these issues


[Bug] NPE when replaying CheckConsistencyJob

Describe the bug
A replay NPE made 3 FE crash and cannot recover
2021-07-02 04:22:36,862 ERROR (replayer|83) [EditLog.loadJournal():816] Operation Type 29
java.lang.NullPointerException: null
        at org.apache.doris.consistency.ConsistencyChecker.replayFinishConsistencyCheck(ConsistencyChecker.java:368) ~[palo-fe.jar:3.4.0]
        at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:339) [palo-fe.jar:3.4.0]
        at org.apache.doris.catalog.Catalog.replayJournal(Catalog.java:2560) [palo-fe.jar:3.4.0]
        at org.apache.doris.catalog.Catalog$3.runOneCycle(Catalog.java:2344) [palo-fe.jar:3.4.0]
        at org.apache.doris.common.util.Daemon.run(Daemon.java:116) [palo-fe.jar:3.4.0]

https://github.com/apache/incubator-doris/blob/d6e6c7815b452d0e262b5c5a7a52fce0880c6117/fe/fe-core/src/main/java/org/apache/doris/consistency/ConsistencyChecker.java#L365-L370
The previous version of this file didn't prevent the NPE anyway, but never cause NPE.
https://github.com/apache/incubator-doris/blob/94a81e52c796150333c54838a889be01934983a4/fe/fe-core/src/main/java/org/apache/doris/consistency/ConsistencyChecker.java#L366-L371
We infer that this NPE is caused by a change in the write-order of editlog. We don't have enough log to prove what’s really going on, but one possible explanation is that:

CheckConsistencyJob.tryFinishJob has already got the table and try to lock.
The table has been dropped just after tryFinishJob got the table.
The op succeeded on the dropped table, and write an editlog.
A follower replay this editlog and crash, and never recover.
https://github.com/apache/incubator-doris/blob/d6e6c7815b452d0e262b5c5a7a52fce0880c6117/fe/fe-core/src/main/java/org/apache/doris/consistency/CheckConsistencyJob.java#L244-L270

It may happen. In currently implements, the table level read/write lock will cause this problem. You can see #6136.
You can simple check if table is null and return in replayFinishConsistencyCheck()

It may happen. In currently implements, the table level read/write lock will cause this problem. You can see #6136.
You can simple check if table is null and return in replayFinishConsistencyCheck()

After a lot of discussions, we consider that change the return value of db.getTable(id/name) to Optional will be a good design to avoid all the possible replay crash when meet the dropped table.

We encountered this problem too. Is there any way to recover?

fixed by #6386


[in_app_purchase_storekit] Migrate tests to swift

Tests should be migrated to swift ahead of storekit 2 migration
Part of https://github.com/flutter/flutter/issues/119106

All tests have been migrated to swift.


⚠ Bofrost.fr has degraded performance

In 74d4b4c, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1061 ms

Resolved: Bofrost.fr performance has improved in cae8284.


Patch OPS files that need to be modified

Recently two PRs (#21 and #26) made modifications to some OPS source files. The script copying OPS sources to this repository should be modified to patch these files to prevent these modifications from being lost if the OPS sources are ever updated.

@mikecooke77 , @adammaycock I am going through old opsinputs issues and noticed this one.
Is it necessary to update the files in the linked PRs? As far as I can tell they are:

deps/ops/public/OpsMod_EnvUtils/OpsMod_EnvUtils.F90
deps/ops/code/OpsMod_Varobs/Ops_SetupVarobsLevDepC.inc

My view is that this isn't necessary now. I can't see a reason why we would need to update from OPS source again, I can understand a requirement for that when opsinputs was in its infancy but unless someone disagrees I think it's OK to let OPS and opsinputs go their own way.