Feature request: parameters order the same way they are defined in meta

Hello,
It would be nice to order parameters in the WebUI the same way they are defined in meta files. Perhaps, adding an optional order field to the parameters in the meta would let it implement easier.
Thanks!

Duplicate of https://github.com/StackStorm/st2web/issues/154

Closing because it's a duplicate.
Let's please continue in #154 - thanks!


State not being set on return (But gets set under 'nonce' in storage)

So I have just upgraded from Angular 4 --> 7.
I also updated angular-oauth2-oidc to latest 5.0.3.
The state returned from the login used to be set, however since the upgrade, this no longer happens.
Below is the response returned from the login server:
http://localhost:4200#access_token=Atza%7CIwEBIKPZv2d8d28WCqBemd1kgO_rrgPH_dNzCRBceuGGfDd4EMBnxMmcA4L8AmVdwR4VwipiC3FwZrxwNU5uSVLAgwYSAH9pyLMCpBLIkJzl21zUCxel1iR4iSWiQRTv0ejR_lWM8Xhhc7_9VKn51r34fvHsu6LjXSTwD-kGvIYx2qDj2KOcQyBTLAbIIwhiiJAnXSZ1vIKDalTJokNZXlcPbtp79dnR7anYz3UIDDTMSIttHENp4JcjqSyEXqWzNO9nP1GfblbTyYegfXg_aBp3JtNn1pBNTjm8N9xn_kvwqaxgDJj_qTSN8yXjGqqW919gMKQ8DH1aShytqoETo59pAoZJQxFx_LHgAqd4M7HXgZslb5gHfNKVSV5DtTd0hLEykUtz8EmLWCqvOO3eTYR-SPKjSLyb_SjNbCnxEbCNjiAkCIG_d8Mi_8e7YB4r2h7viBjpxicWcPYYM6j-bb7hfKJgxyEAssfrQQp594vM48IDkP16_kYLjcoiStu4ahODQVkJONjDEr6tYV5Xd0d-3a9WebLI1LktdaoZ2bIocW0ohQ&token_type=bearer&expires_in=3600&scope=profile&state=wyuAtI15PCxJ58BCTmf7ahC7S6cnkFfPfiNpQuAC
clearly at the end, the state is returned.
Whilst debugging, I found that this value was actually being stored under 'nonce' under storage. So seems like a bug to me.
Has anyone else ran into this issue? And if so, have any ideas on how to fix this.
Thank you!!

I have not experienced this. You could try loading source maps and debugging, you should probably put a break point around this area of the code that tries to get the nonce from the state. That code also suggests that the nonceStateSeparator on the OAuthConfig might be of use to you?
Good luck.

I have not experienced this. You could try loading source maps and debugging, you should probably put a break point around this area of the code that tries to get the nonce from the state. That code also suggests that the nonceStateSeparator on the OAuthConfig might be of use to you?
Good luck.

Cheers, will debug when I get the chance too :)

Debugged, and you're correct! That bit of code is what is deciding to make my state empty. However, currently there is no way (I don't think) for me to use the oauth services state property. What is returned to me has no nonce seperator in it - so this code will always set my state to empty :(
This is Login With Amazon that returns this, so I can't help it unfortunatley. In the mean time, I'll just access the none in storage - which sucks, but will do for now.
So my suggestion to possibly fix this issue would be add a ignoreNonceSeperator: boolean or something to the config?

Good to hear you've found a workaround!
I'm not entirely clear on the specifics of your situation though, and how the possible fix would help. Could you perhaps elaborate:

what is the exact value of state when your debugger breaks in that code?
what is the exact value of this.config.nonceStateSeparator when your debugger breaks in that code?
what state and nonce is being sent to the auth server (i.e. what URL is the user being sent to)
what is the URL when you get back (so the URL from your first post, but then corresponding to the other three bullets above)

Also, what is the exact ID Solution you're using? Do you have a link? Just "Amazon" is a bit broad (but I'm no expert on IDServers)

I am having a similar issue, despite having my OAuthStorage to localStorage or even when trying with SessionStorage the only value being stored is nonce, everything else is not being set up and I am trapped in an infinite loop, I can't find why is it doing this. I am drilling down to the angular-oauth2-oidc files to see what can I find, any advice?

Given the lack of interaction in this issue I'm keen on closing it. If someone needs help with the same or a similar issue, please feel free to open a fresh issue, but do add a full-but-minimal reproducible scenario please, e.g. in a StackBlitz sample.


Update min k8s version to 1.26

Please provide a description of this PR:
This will be needed once we transition to the new supported window for the next release.

Do we have documentation of this min requirement that needs to be updated as well?

Do we have documentation of this min requirement that needs to be updated as well?

We do have this listed in the release preparation doc. I just try to update it advancely, and RMs do not need to update it again.

https://istio.io/latest/docs/releases/supported-releases/ still shows master supporting 1.25
This should be updated as well.
We officially support supported versions of K8s at release date. See https://endoflife.date/kubernetes

Thanks for the info. I would like this to be merged after https://istio.io/latest/docs/releases/supported-releases/ is updated, which should be close to the release date. In the past, it wasn't updated on time, and I did cherry-pick several times. I'll just add a DNM label for now.

This can be merged once https://github.com/istio/istio.io/pull/14486 is declared.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
fc640f0233394516851f2b6ca6cb43e3e823a04e
link
unknown
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
fc640f0233394516851f2b6ca6cb43e3e823a04e
link
unknown
/test integ-telemetry-istiodremote

integ-telemetry_istio
fc640f0233394516851f2b6ca6cb43e3e823a04e
link
unknown
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Gateway doesn't stay online

I am using the default ChirpStack compose file from: https://github.com/chirpstack/chirpstack-docker/blob/master/docker-compose.yml
My additions:
Replace eu868 -> au915_0
Add:
  udp-packet-forwarder:
    image: rakwireless/udp-packet-forwarder:latest
    container_name: udp-packet-forwarder
    privileged: true
    depends_on:
      - chirpstack-gateway-bridge
      - chirpstack-rest-api
    environment:
      MODEL: "RAK7371"
      INTERFACE: "USB"
      DEVICE: "/dev/ttyACM0"
      BAND: au_915_928
      GATEWAY_EUI_SOURCE: chip
      SERVER_HOST: chirpstack-gateway-bridge
      CS_TENANT_ID: "XXXX-XXXX-XXXX..."
      CS_TOKEN: "eyJ0eXXXXXXXXXX..."
      CS_API_URL: "chirpstack-rest-api:8090"

Compose
version: "3"

services:
  chirpstack:
    image: chirpstack/chirpstack:4
    command: -c /etc/chirpstack
    restart: unless-stopped
    volumes:
      - ./configuration/chirpstack:/etc/chirpstack
      - ./lorawan-devices:/opt/lorawan-devices
    depends_on:
      - postgres
      - mosquitto
      - redis
    environment:
      - MQTT_BROKER_HOST=mosquitto
      - REDIS_HOST=redis
      - POSTGRESQL_HOST=postgres
    ports:
      - 8080:8080

  udp-packet-forwarder:
    image: rakwireless/udp-packet-forwarder:latest
    container_name: udp-packet-forwarder
    restart: unless-stopped
    privileged: true
    depends_on:
      - chirpstack-gateway-bridge
      - chirpstack-rest-api
    environment:
      MODEL: "RAK7371"
      GATEWAY_PREFIX: "RAK7371"
      INTERFACE: "USB"
      DEVICE: "/dev/ttyACM0"
      BAND: au_915_928
      GATEWAY_EUI_SOURCE: chip
      SERVER_HOST: chirpstack-gateway-bridge
      CS_TENANT_ID: "<ommitted for privacy>"
      CS_TOKEN: "<ommitted for privacy>"
      CS_API_URL: "chirpstack-rest-api:8090"

  chirpstack-gateway-bridge:
    image: chirpstack/chirpstack-gateway-bridge:4
    restart: unless-stopped
    ports:
      - 1700:1700/udp
    volumes:
      - ./configuration/chirpstack-gateway-bridge:/etc/chirpstack-gateway-bridge
    environment:
      - INTEGRATION__MQTT__EVENT_TOPIC_TEMPLATE=au915_0/gateway/{{ .GatewayID }}/event/{{ .EventType }}
      - INTEGRATION__MQTT__STATE_TOPIC_TEMPLATE=au915_0/gateway/{{ .GatewayID }}/state/{{ .StateType }}
      - INTEGRATION__MQTT__COMMAND_TOPIC_TEMPLATE=au915_0/gateway/{{ .GatewayID }}/command/#
    depends_on:
      - mosquitto

  chirpstack-gateway-bridge-basicstation:
    image: chirpstack/chirpstack-gateway-bridge:4
    restart: unless-stopped
    command: -c /etc/chirpstack-gateway-bridge/chirpstack-gateway-bridge-basicstation-au915_0.toml
    ports:
      - 3001:3001
    volumes:
      - ./configuration/chirpstack-gateway-bridge:/etc/chirpstack-gateway-bridge
    depends_on:
      - mosquitto

  chirpstack-rest-api:
    image: chirpstack/chirpstack-rest-api:4
    restart: unless-stopped
    command: --server chirpstack:8080 --bind <IP_ADDRESS>:8090 --insecure
    ports:
      - 8090:8090
    depends_on:
      - chirpstack

  postgres:
    image: postgres:14-alpine
    restart: unless-stopped
    volumes:
      - ./configuration/postgresql/initdb:/docker-entrypoint-initdb.d
      - postgresqldata:/var/lib/postgresql/data
    environment:
      - POSTGRES_PASSWORD=root

  redis:
    image: redis:7-alpine
    restart: unless-stopped
    command: redis-server --save 300 1 --save 60 100 --appendonly no
    volumes:
      - redisdata:/data

  mosquitto:
    image: eclipse-mosquitto:2
    restart: unless-stopped
    ports:
      - 1883:1883
    volumes:
      - ./configuration/mosquitto/config/:/mosquitto/config/

volumes:
  postgresqldata:
  redisdata:

If in ChirpStack compose I use eu868 instead of au915_0 then the heartbeat works correctly. So I think it's sending it to the wrong topic, but I'm unsure how to configure this from udp-packet-forwarder

Logs
##### 2024-11-21 04:45:41 GMT #####
### [UPSTREAM] ###
# RF packets received by concentrator: 0
# CRC_OK: 0.00%, CRC_FAIL: 0.00%, NO_CRC: 0.00%
# RF packets forwarded: 0 (0 bytes)
# PUSH_DATA datagrams sent: 1 (164 bytes)
# PUSH_DATA acknowledged: 100.00%
### [DOWNSTREAM] ###
# PULL_DATA sent: 3 (100.00% acknowledged)
# PULL_RESP(onse) datagrams received: 0 (0 bytes)
# RF packets sent to concentrator: 0 (0 bytes)
# TX errors: 0
### SX1302 Status ###
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 1 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms
INFO: [down] PULL_ACK received in 0 ms

Hi @CoenraadS
The topic is handled by the chirpstack-gateway-bridge component. You should go check the configuration file for that component. The UDP packet forwarder does not include any info about the band being used aside from the frequency the message is received.

The "INFO: [down] PULL_ACK received in 0 ms" messages are normal. Mean downlink socket is working fine.
In the logs you have shared there is no uplink received (well, just 1 but CRC failed). What device are you testing this with? Is it also AU915_0?

It is a MileSight PIR & Light Sensor. Scanning it with NFC shows that it is using AU915 frequencies, but it by default uses the entire range. However my understanding is that if it joined via AU915_0, then it should send uplink on those frequencies also. I can limit the frequencies used via the app if I want.
However it's unclear to me the relationship of a device sending uplink packages, and the gateway status. Does that mean that if no devices are sending uplink packages, the gateway appears offline? (even though the gateway is working fine)?

After further investigation, I think it's related to Windows USB Selective Suspend. I will close this issue, although I think the INFO: [down] PULL_ACK received in 0 ms messages are still erroneous in this case, it's not the root cause.

I close it because I thought it was related to Windows USB Selective Suspend, but then ofc it happened again shortly after I closed the issue.. Any ideas how I can diagnose if the usb is still 'live' from within the udp-packet-forwarder container?

I cannot help you with USBIPD, but if you find any more info about this issue, please feel free to share it here.

I thought it was.. but now I'm not so sure since again I hit the issue. Since restarting the docker container works, then the issue must be in the container. But I chased this for long enough, I will just restart the container whenever it happen.


Documentation_update

Fixed virtual environment name. The ".venv" directory is actually named ".venv2". That plus it being a hidden directory makes installation guide misleading.

@mchrusci thanks for your commits.
.venv is actually a symbolic link to .venv2 (meaning python2 virtual environment)
Do you have .venv hidden directory? If yes, there is no need to rename .venv to .venv2 right (since .venv2 exists)?
lrwxr-xr-x   1 wangwei   wangwei    6B Jul  5 15:34 .venv@ -> .venv2
drwxr-xr-x   7 wangwei  wangwei   238B Jul  5 15:34 .venv2/


Safari 3d-dice Graphics Bug

A couple of people have reached out indicating they are receiving a graphics error where dice look like the following:

user 1: iPhone 11, Chrome (Safari engine)
user 2: iPhone, Safari
I've also seen some delays when using the dice on Android, where sometimes it takes several seconds before the dice will show up.

I have found some issues on Android as well. 3d-dice for mobile devices disabled until a fix is found for this.


Update Kubernetes Port Documentation

What does this PR do?
Updates the documentation for kubernetes, in particular the port examples, and adds some notes about best practices
Motivation
Fixes #3348
More

[x] Added/updated documentation

ping @containous/kubernetes


Need high res photo with all team members

To be taken as soon as all of us are in I3P

Upload high-res pic to https://github.com/gmacario/spaceappschallenge-2019/tree/master/images
Rescale it to a smaller resolution
Use the low-res version for

Last slide of the slide deck
Team profile  at https://2019.spaceappschallenge.org/challenges/our-moon/eeny-meeny-miney-sample/teams/moebius-sail/project

We were unable to take a picture with the all of us before the final pitch.
We should instead try to get the photo that the official photographer of the event took us after the award ceremony


:wolf: add progress display for video

Displays the progress of portion of video segmented based on frames.

I tested it, it worked. Thank you for your contribution.


MOTR-89 Alpha internal-preview issues

✨ Key Changes:

Changed the plot button UIs and button text to properly reflect the visualizations on the animal phenotype data.
Updated mock data to properly reflect the site/assay mappings.
Added temporary ⚠ 📝 to indicate a) assays are not restricted to any site on the Upload form in Alpha release; b) incomplete datasets are used for animal phenotype data visualizations in Alpha release.
Changed the back button navigation UI on Analysis pages.
Improved the date validation (pattern) on the Upload form.
Updated Storybook components to reflect the changed UIs.

Merged MOTR-89


Corrected examples XML syntax

Upper case boolean values caused parser error
Ending XML closing tag invalidates file

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: EagleIJoe sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


What is guvnor and where do I get it ?

I really like this web interface, more featured than PM2-web, however I cant seem for the life of me to find any information on what guvnor is or how to get it.
Any help greatly appreciated.

Oh "boss" has been renamed to "guvnor". Got it.


Terraform v0.12.0-beta1 compatibility

Thank you for making a namecheap provider!  I was wondering if it's on the radar to make a version that is compatible with the new v0.12.0-beta1 version?

@danielposton Yea. I haven't looked over what exactly has changed, but I'm aware an upgrade is needed. I'll try and read over what all is changing this weekend.

@danielposton I created https://github.com/adamdecaf/terraform-provider-namecheap/pull/14 which worked for me locally on a DNS record. Can you try out the branch? Just run make to install the binary on your system in $GOPATH/bin.
https://github.com/adamdecaf/terraform-provider-namecheap/tree/terraform0.12

I tried to do this myself, because all namecheap resources are stuck on module.test.namecheap_record.subdomain.1: Still creating... (40m31s elapsed)
for me
Upon a make from that terraform0.12 branch -
fatal: unable to access 'https://gitlab.howett.net/go/plist.git/': SSL certificate problem: certificate has expired

Are there any alternatives that can be used, you think?
Version for context:
terraform --version
Terraform v0.11.13

gitlab.howett.net looks to be using a Let's Encrypt certificate chain. Is your machine trusting that root?
https://api.moov.io/ is another site (that I host) which uses Let's Encrypt. Can you load that?

Maybe he is behind a proxy or something. Also I noticed export TF_LOG=trace before running terraform apply might give you more info here.

FYI the master branch is updated with 0.12.0-rc1 after Hashicorp released it.

1.3.0 has been released with Terraform 0.12 support.


[Documentation] 'shown_icon' is missing in Entity Objects table

The configuration options table for Entity Objects is missing the show_icon and state_on, state_off attributes.
In the provided examples they are in:
    - entity: binary_sensor.window
      show_icon: true
      icon:
        state_on: mdi:window-open
        state_off: mdi:window-closed

I just updated the docs. Again thnx!


Add common propTypes for Events

We use a common library of proptypes. Add events type check and change the object at each one of the files that use this prop.

@jrogatis I'd like to help with this issue. How can I start?

@jrogatis I would like to help as well. Please me know if there is anything I can do.

sorry about the delayed answer!  Yes all help will be appreciated! @gURLmeetsCode and @caskuplich ! Its simple. look at the code and find the complex prototypes that repeat along the other component classes and add a file inside at the commom prototypes dir and try to export then there. Any help that you needed please contact me !

@jrogatis Let me see if I get it: I found at least 3 files that could use the common propTypes isEvent and isCurUser from the file client/util/commonPropTypes.js:

client/components/NavBar/NavBar.js
client/components/NotificationBar/NotificationBar.js
client/pages/NewEvent/index.js

But I haven't identified patterns of complex propTypes that could be reused by components. Maybe you can help me find these propTypes.

@caskuplich
curUser: PropTypes.shape({
_id: PropTypes.string,      // Unique user id
name: PropTypes.string,     // User name
avatar: PropTypes.string,   // URL to image representing user(?)
}).isRequired,
is one of than is used all over the app.

@jrogatis Unfortunately I can't run the project on my local machine. After Google redirects to the app, the following error appears:
Error
    at /<...>/meeting-for-good/node_modules/passport-google-oauth20/lib/strategy.js:95:21
    at passBackControl (/<...>/meeting-for-good/node_modules/oauth/lib/oauth2.js:132:9)
    at IncomingMessage.<anonymous> (/<...>/meeting-for-good/node_modules/oauth/lib/oauth2.js:157:7)
    at emitNone (events.js:110:20)
    at IncomingMessage.emit (events.js:207:7)
    at IncomingMessage.wrappedEmit [as emit] (/<...>/meeting-for-good/node_modules/opbeat/lib/instrumentation/http-shared.js:116:29)
    at endReadableNT (_stream_readable.js:1045:12)
    at instrumented (/<...>/meeting-for-good/node_modules/opbeat/lib/instrumentation/index.js:102:27)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)
    at process.fallback (/<...>/meeting-for-good/node_modules/opbeat/lib/instrumentation/async-hooks.js:514:17)

Node version: v8.3.0
MongoDB version: v3.4.7
OS: Trisquel 7 (Ubuntu 14.04)
Can you help me with this issue?

@caskuplich Hey there. Sure! Do you set the .env file properly with the correct api keys ?

@jrogatis I just didn't set the FACEBOOK_KEY, FACEBOOK_SECRET, AWS_ACCESS_KEY_ID, AWS_SECRET_KEY, and EMAIL_FROM.
Is there any problem to set the URL restrictions and redirect_url to http://localhost:8080 and http://localhost:8080/api/auth/google/callback, respectively on the Google API Console when I create a new OAuth API client_id? I enabled the Calendar API as stated on the README file and also created an API Key for Google Analytics.

You need to set this call back properly at the google api console.
http://localhost:8080/api/auth/google/callback
at the javascript authorized URLs  at restrictions area.

This is my Google Developers console settings:

This is a OAuth Client ID credential.
It seems that the problem is on the meeting-for-good code on the return. For some reason the code returned from Google causes the error I mentioned above. The URL of the return comes with a code query string, like this: http://localhost:8080/api/auth/google/callback?code=<code with 46 chars>. This is right, isn't it?

do you set the Oauth consentiment screen ? and enable the API ? @caskuplich ?

@jrogatis, yes. I set my email address and the Product Name as "Meeting for Good Dev". The other fields are optional.
Can I sign-in the application with the same email address I set in the Consent screen or should I enter with a different Google Account?

I'm suspicious that it's a version problem. I think that there is some breaking change in passport.js or other related package. @jrogatis, can you make a new clone of the repo run on your local machine?

@caskuplich I will try today.

@caskuplich its running perfectly.

@jrogatis, thank you so much. I'll try to find what is wrong with my local machine setup.

what . errors you got at the back ? @caskuplich ?

The same errors I posted above. What makes this hard to solve is that there isn't a good error message, unfortunately.

@jrogatis Yeah! Now I can login! I had to enable the Google+ API to make this work. So, my Google API console dashboard has the Google Calendar API, Google+ API and the Analytics API enabled. Thank you again @jrogatis. Now I can work on this issue on my local machine. :smile:

great @caskuplich !

@jrogatis , I DRYed the NotificationBar component (client/components/NotificationBar/NotificationBar.js) with no problems. But I tried to change the NavBar component (client/components/NavBar/NavBar.js) and it issues a warning on the web console saying that _id and avatar are required when the user isn't logged in. The current version doesn't issue any warning regarding propTypes. Can you help me with this?
I'd also want to DRY the client/pages/NewEvent/index.js file, and I noted that it is already issuing a warning on the console about the user propType right now (current version). I think that we should fix this warning before DRYing this file. What do you think?

@caskuplich  can you give me your branch url ? so i can see the code and help with  ?

@jrogatis Here is my branch URL: https://github.com/caskuplich/meeting-for-good/tree/fix/refactor-proptypes
I think the NotificationBar can be merged with no problems, but the NavBar issues propTypes warnings saying that _id, name, and avatar from curUser are undefined even when the user is logged in.
I also noticed that the client/pages/NewEvent/index.js (current version, I didn't modify it yet) issues a warning saying curUser propType is undefined just the first time we click the + button at the bottom right corner of the screen. When we click the next times it doesn't issue any warning.

i will adress this ASAP @caskuplich for some reason I miss your last comment


Reduce effect of border flashing

Because body initially loads with no height, the top/bottom border
flashes and causes some layout movement. This change does not eliminate
movement but masks the effect to some extent`

bors r+


Add the paper published in Annals of Oncology in 2015 to the Mario Negri part of the User section

As the title says. In the interest of full disclosure, I'm the first author of said paper, and Brad is a co-author.

Luca -- thanks so much for this. Congrats again on the paper.


Lookup Istio gateway by label

Description
The Istio Gateway for dynamically created VirtualService is now selected by label instead of fixed name.
See: #234
Changes proposed in this pull request:

Replace CLI flag gateway-name with gateway-ns-name that accepts unique name in the format: namespace/name
Add new CLI flag gateway-selector that accepts a  label selector query as in the K8s LIST REST API
Add new gateway object to the Watcher CR. The object has two properties: namespacedName and labelSelector that corresponds to the CLI flags.
Define basic validations for the new CLI flags and the Watcher CR gateway object fields.
CLI flags for the gateway lookup are merged during reconciliation with the Watcher CR configuration. Watcher CR values have  precedence over CLI flags
namespaced name of the gateway has precedence over label selector for lookup, because it's more specific
Add warnings as described in #234
Provide the default value for gateway selector CLI flag: operator.kyma-project.io/watcher-gateway=default
Add new file in the main package: flags.go to remove flag management from main.go - main.go becomes too big.
Related Issue(s)
#234

/test pull-lifecycle-mgr-build

great implementation 🔥


laptop not seeing valid display device

laptop I have been using for testing:
Acer v0.3108 Aspire 1410
hostname: negk
gateware revision: a4808ace
firmware revision: a4808ace, built Aug 28 2015 00:39:12
I plug it in, fumble around with video_mods and suddenly it starts working and I don't know what did it.
working: laptop sees hdmi device, sends desktop video,  video is displayed on one of the hdmi outputs.  I have had both hdmi and encoder sending data to usb.
Today I am not able to get it to see a display device.
laptop hdmi out hooked to Atlys hdmi1 in.
nothing connected to hdmi0 in or either hdmi out.
both USB hooked to dc10b. (not relevant, I hope)
hdmi_in0:  0x0
hdmi_in1:  0x0
hdmi_out0: 1280x720 from hdmi_in0
hdmi_out1: 1280x720 from hdmi_in0
encoder: off
ddr: read: 1761Mbps  write:    0Mbps  all: 1761Mbps

HDMI1 disconnected (normal left inverted right x axis y axis)

[11273.184291] [drm:intel_tv_detect], [CONNECTOR:25:SVIDEO-1] force=0
[11274.559525] [drm:i965_irq_handler], hotplug event received, stat 0x38040000
[11274.559545] [drm:intel_hpd_irq_handler], Received HPD interrupt on PIN 4 - cnt: 0
[11274.559607] [drm:i915_hotplug_work_func], running encoder hotplug functions
[11274.559615] [drm:i915_hotplug_work_func], Connector HDMI-A-1 (pin 4) received hotplug event.
[11274.559621] [drm:i915_hotplug_work_func], Connector DP-1 (pin 4) received hotplug event.
[11274.559630] [drm:intel_hdmi_detect], [CONNECTOR:14:HDMI-A-1]
[11274.560151] [drm:gmbus_xfer], GMBUS [i915 gmbus dpb] NAK for addr: 0050 w(1)
[11274.560161] [drm:gmbus_xfer], GMBUS [i915 gmbus dpb] NAK on first message, retry
[11274.564120] [drm:gmbus_xfer], GMBUS [i915 gmbus dpb] NAK for addr: 0050 w(1)
[11274.564128] [drm:drm_do_probe_ddc_edid], drm: skipping non-existent adapter i915 gmbus dpb
[11274.564137] [drm:intel_dp_detect], [CONNECTOR:18:DP-1]
[11274.566542] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x51450064
[11274.574683] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x51450064
[11274.582668] [drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x51450064
[11283.200299] [drm:intel_tv_detect], [CONNECTOR:25:SVIDEO-1] force=0
[11293.216297] [drm:intel_tv_detect], [CONNECTOR:25:SVIDEO-1] force=0

juser@negk:~$ lspci | grep Graphics
00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)
00:02.1 Display controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)

pretty sure this is because the SDA jumpers were in place.  pulled them, now negk sees a display device.

well.. maybe not.  jumpers still removed, un/plugged hdmi cable, now negk does not see a display device.
power cycled negk, Atlys, dc10, reloaded, negk does not see a display device.

I think this confirms we need much better debugging of when EDID is
accessed (IE messages up the UART as the EDID state machine transitions
occur). This will allow us to correlate the information we are getting in
dmesg.
I would also think it would be a good idea to permanently connect liteScope
to the EDID (and on Opsis, the HPD) lines to record traces of these pins
until we are 100% certain things are solid. Probably need a way to use
flterm to dump the liteScope recordings via the console UART too.
On 3 Sep 2015 10:15 am, "Carl Karsten"<EMAIL_ADDRESS>wrote:

well.. maybe not. jumpers still removed, un/plugged hdmi cable, now negk
does not see a display device.
power cycled negk, Atlys, dc10, reloaded, negk does not see a display
device.
—
Reply to this email directly or view it on GitHub
https://github.com/timvideos/HDMI2USB-misoc-firmware/issues/38#issuecomment-137516677
.

I'll add something in the gateware to allow EDID debugging.

See https://github.com/timvideos/HDMI2USB-misoc-firmware/issues/39 and https://github.com/timvideos/HDMI2USB-misoc-firmware/issues/33

If your issue is similar to to the one I had with a computer, this should solve it:
https://github.com/timvideos/HDMI2USB-misoc-firmware/commit/9bb88b8bba0052b9ec665e5a1294801b787d7357

negk laptop and all other problems working fine now.


Material UI doesn't work as provided in documentation

Hello @ranile! I've faced with the problem and maybe you could help me to understand how to fix it.
Problem description
Step 1
When I'm trying to use material yew based on documentation page
use material_yew::MatButton;
use yew::html;

html! {
    <MatButton label="Click me!" />
};

I've faced with an error: unresolved import material_yew::MatButtonthe item is gated behind thebutton feature
Step 2
If I add button feature
material-yew = { version = "0.3.0", features = ["button"] }

I see the following error:
the trait bound `material_yew::MatButton: yew::Component` is not satisfied
the trait `yew::Component` is implemented for `yew::ContextProvider<T>`
required for `material_yew::MatButton` to implement `yew::BaseComponent`

I guess this is because I'm using a new version of yew which is 0.21.0 and the traits has been changed since last material-yew publish.

@MadMed677 yes, the published version is quite old. you should take a dependency from git, which should be fine

Maybe I did something wrong but even if I fetch yew from Git and Material Yew from Git the result error will be the same
First option
Cargo.toml
[dependencies]
material-yew = { git = "https://github.com/ranile/material-yew", branch="material-3" }
web-sys = "0.3.69"
yew = { git = "https://github.com/yewstack/yew", features = ["csr"] }

The error says that 32 times for every component:
cannot find function `__dummy_loader` in this scope
crate::import_material_web_module!("/md-web/radio.js")
   |         ------------------------------------------------------ in this macro invocation

Other options
All other implementation have the same problem
<MatButton label="Add" raised=true>{"Add one"}</MatButton>
   |              ^^^^^^^^^ the trait `yew::Component` is not implemented for `MatButton`, which is required by `MatButton: yew::BaseComponent`

@MadMed667 right, the git one gives you an error, I should've expected that. It can't find the modules
I suggest you clone the repo and then use a path dependency for now. You'll you invoke rollup yourself
cd build
npm install
npm run build

This should fix your JS files not available issue.
One good way of permanently solving this problem is having a build script that calls npm run build. I would be happy to take a look at any PRs for it. I used to include build files in the repo but in light of the XZ exploit that was found, I'm not really comfortable doing that and telling others to use it. It would be best if end users invoked rollup themselves to bundle the martial components this library uses


I can't executable with ttkbootstrap library

https://cdn.discordapp.com/attachments/698842872530731049/846776078886633553/unknown.png

can you be more specific about your issue? What code are you executing? What error message are you receiving?

Traceback (most recent call last):
"File ""importlib\resources .py"", line 97, in open_binary
FileNotFound Error: [Errno 2)No such file or directory
:  'C:\\Users\\Kaomao\\AppData\\Local\\Temp\\_MEI124362\\ttkbootstrap\\themes.json'
"During handling of the above exception, another exception occurred:"
Traceback (most recent call last):
File "Notepad.py", line 538, in <module>"
File "Notepad.py", line 20, in _init_
File "ttkbootstrap\_init_ .py" , line 57, ne _init_
File "ttkbootstrap\_init_ .py", line 75, in _load_themes
File "importlib\resources .py", line 139, in read text
File "importlib\resources .py", line 121, in open_text
File "importlib\resources .py", line 111, in open_binary
FileNotFound Error : 'themes.json' resource not found in 'ttkbootstrap '
(10520)Failed to execute script Notepad

i covert py to exe but it can't run

are you using pyinstaller?

Yes

This i use py2exe
`
Traceback (most recent call last):
File "", line 177, in get_data
KeyError: 'ttkbootstrap\themes.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 741, in open_resource
File "", line 179, in get_data
OSError: [Errno 0] : 'ttkbootstrap\themes.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "Notepad.py", line 539, in
File "Notepad.py", line 21, in init
File "ttkbootstrap_init_.pyc", line 80, in init
File "ttkbootstrap_init_.pyc", line 100, in _load_themes
File "importlib\resources.pyc", line 139, in read_text
File "importlib\resources.pyc", line 121, in open_text
File "importlib\resources.pyc", line 91, in open_binary
File "", line 743, in open_resource
FileNotFoundError: ttkbootstrap/themes.json
Traceback (most recent call last):
File "", line 177, in get_data
KeyError: 'ttkbootstrap\themes.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 741, in open_resource
File "", line 179, in get_data
OSError: [Errno 0] : 'ttkbootstrap\themes.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "Notepad.py", line 539, in
File "Notepad.py", line 21, in init
File "ttkbootstrap_init_.pyc", line 80, in init
File "ttkbootstrap_init_.pyc", line 100, in _load_themes
File "importlib\resources.pyc", line 139, in read_text
File "importlib\resources.pyc", line 121, in open_text
File "importlib\resources.pyc", line 91, in open_binary
File "", line 743, in open_resource
FileNotFoundError: ttkbootstrap/themes.json
`

This i use py2exe
Traceback (most recent call last):
  File "<frozen zipimport>", line 177, in get_data
KeyError: 'ttkbootstrap\\themes.json'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<frozen zipimport>", line 741, in open_resource
  File "<frozen zipimport>", line 179, in get_data
OSError: [Errno 0] : 'ttkbootstrap\\themes.json'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "Notepad.py", line 539, in <module>
  File "Notepad.py", line 21, in __init__
  File "ttkbootstrap\__init__.pyc", line 80, in __init__
  File "ttkbootstrap\__init__.pyc", line 100, in _load_themes
  File "importlib\resources.pyc", line 139, in read_text
  File "importlib\resources.pyc", line 121, in open_text
  File "importlib\resources.pyc", line 91, in open_binary
  File "<frozen zipimport>", line 743, in open_resource
FileNotFoundError: ttkbootstrap/themes.json

@kaomao1234 , Ok. I played around with this for a few minutes using pyinstaller and was able to get it to work. You need to add --collect-all ttkbootstrap
You can read more about this option here: https://pyinstaller.readthedocs.io/en/stable/usage.html
Essentially, what you need to do with either pyinstaller or py2exe is make sure that it is importing all of the required files. This can be done is various ways depending on how you are building your executable. I'm not sure if the method below is the most efficient, but it does work.
C:\\> pyinstaller yourprogram.py --collect-all ttkbootstrap

Thank you very much.

@kaomao1234, did this fix your problem? If so, I'll close the issue.

Hello, I included this:
--collect-all ttkbootstrap
in my pinstaller command and I still get the error

and from what I can see ttkboostrap is in my package list

this also leads to ModuleNotFound errors when running through the anaconda terminal instead of the VS code terminal
as you can see error here

no error here

pyinstaller main.spec --onedir --collect-all ttkbootstrap --hidden-import "heapq" --upx-dir C:\Users\dm3704\upx-3.96-win64
here the entire line i use to run pyinstaller

are you able to post your spec file? Some of these options are flagged in the spec file as well. So, it may be that the CLI options are overriding spec file options, or vice versa.

Thank you very much once I edited my spec file it ran like perfectly. They were, as you said overriding the commands in the commandline. As for my second issue with ModuleNotfoundError, I can bypass it by just using VScode to run the tkinter App instead of the anaconda terminal but do you have any thoughts on why anaconda's environment isn't reading the module even though it's downloaded and working?
Either way thank you ver much for the quick support and congratulations on the really awesome package, I've been really enjoying it!

try running using the command python main.py.

This also worked, thank you very much for your time.

Try using the previous version of ttkbootstrap.Version 0.5.2 worked in my case.


Various optimizations to the XDAG pool startup time

Copy of the PR https://github.com/XDagger/xdag/pull/40 with correct target branch

This PR is the copy of broken PR https://github.com/XDagger/xdag/pull/40


Safe way to reference entities?

I'm working on a game prototype using fleks and I'm struggling to find a good way to reference an entity from a component. A simple example would be one entity following another entity and therefore needing a reference.
It seems that the Entity value class is not a safe reference because entities get reused after removal from the world, so a reference might reference a completely different entity in the future.
Is there some safe way to reference entities? Do I need to set a remove entity hook and search for all components that might reference that entity?

Hi,
this is a good question and tbh I don't know what are the best practices here.
I remember that I did what you mention at the end in an old project using Ashley and I didn't like it because every time I add a component with entity references I had to remember to add the cleanup logic to the hook. Also performance wise it is not ideal because you have to iterate through all such components and also through the entity ref containers.
Another solution which is maybe better and which I also used in some projects is a RemoveSystem with a RemoveComponent. Instead of removing an entity directly you then have to add a RemoveComponent to it. The system then really removes the entity.
This has the advantage that you can control when entities get really removed. It is also easy to e.g. add a timer to en entity and remove it delayed by simply adding a delay to the RemoveComponent and adjust the logic in the RemoveSystem.
Also, on your entity ref components you can then check if your entity has a RemoveComponent and remove it or do whatever logic you need to do (e.g. follow another nearby entity).
Finally, in the last version of Fleks you can provide your own EntityProvider. Check the wiki. That way you can remove the recycle logic and always create new IDs. But be careful to not overflow the IDs.
Of course I am open for other ideas and can add some generic solution to Fleks if there is a good one 😃

Finally, in the last version of Fleks you can provide your own EntityProvider. Check the wiki. That way you can remove the recycle logic and always create new IDs. But be careful to not overflow the IDs.

That actually sparked an idea! What I want is to identify different versions of the same entity, so I hacked together some utilities to actually track versions of entities: https://gist.github.com/dragbone/149b63c55eec650a32bf60d697b80fc0
A generic solution could probably work pretty similar by tracking versions internally and providing references when needed (without attaching a Component to every entity).

Is this a convenient enough solution for you? Looks pretty minimalistic and nice.
Out of curisoity: would it help if recycled entities don't get reused within a single frame (=world.update call)? I think that should also work at least if the important systems are triggered every frame. If you have systems that run at a fixed rate then this won't help. In that scenario your solution is better and should still work.
I personally don't want to add this directly to the current "core" of Fleks because this problem does not occur in every game and I guess it has some impact on the performance as well (most likely not huge though).
I am thinking more towards a second EntityProvider implementation that contains the entity versioning logic.

If you have time and if you are motivated, feel free to help me out and create a PR because I am not sure when I will have time to add this

I haven't looked much into the inner workings of fleks but I'll give it a try :)

Snapshot release should be live in the next few hours. Stable 2.5 release will be ready in the next few weeks


Misc doc changes

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the source of truth for this Elixir
library and leverage on latest features of ExDoc.

@kianmeng looks like theres 4 diff types of changes:

license file changes + addition to readme
doc badge linking
test file adjustments
mix file adjustments

can we split up this pr into two PRs. I can merge in 2,3,4. But pt1 is up to @oltarasenko

Also, could you resolve conflicts for the quickstart changes? there has been some changes in the quickstart spider example.

@kianmeng looks like theres 4 diff types of changes:

license file changes + addition to readme
doc badge linking
test file adjustments
mix file adjustments

can we split up this pr into two PRs. I can merge in 2,3,4. But pt1 is up to @oltarasenko

I am not quite sure why do we need to remove something from the licence? Could you explain?

Also, could you resolve conflicts for the quickstart changes? there has been some changes in the quickstart spider example.

@Ziinc Done. Please check.

@kianmeng looks like theres 4 diff types of changes:

license file changes + addition to readme
doc badge linking
test file adjustments
mix file adjustments

can we split up this pr into two PRs. I can merge in 2,3,4. But pt1 is up to @oltarasenko

I am not quite sure why do we need to remove something from the licence? Could you explain?

@oltarasenko @Ziinc
Just remove APPENDIX from the licence, which is not part of the license terms and agreements.

@kianmeng looks like theres 4 diff types of changes:

license file changes + addition to readme
doc badge linking
test file adjustments
mix file adjustments

can we split up this pr into two PRs. I can merge in 2,3,4. But pt1 is up to @oltarasenko

I am not quite sure why do we need to remove something from the licence? Could you explain?

@oltarasenko @Ziinc Just remove APPENDIX from the licence, which is not part of the license terms and agreements.

Ok, I don't have objections in this case I think!

@Ziinc I can't seem to reply to your comment, so I put everything here.

any reason why this change is necessary?
It would be preferable to leave as is to prevent major ver api changes from breaking docs generated.

Use the latest ExDoc to generate the documentation to leverage its latest features.

any reason why the aliases is removed? it is used for doc gen.

This is similar to using the assets option for Exdoc:
   defp docs do
     [
-      source_ref: "v#{@version}",
+      assets: "documentation/assets",

See https://hexdocs.pm/ex_doc/Mix.Tasks.Docs.html#module-configuration

:assets - Path to a directory that will be copied as is to the "assets" directory in the output path. Its entries may be referenced in your docs under "assets/ASSET.EXTENSION"; defaults to no assets directory.

@Ziinc @oltarasenko Any updates on this?

@kianmeng merge requires all checks to pass, i'll fix the checks when I'm free. i'll try to get this merged in this week.

@kianmeng Could you please run mix format and send it back, so I can merge it?

@oltarasenko Done. Please check.

:tada: :tada: :tada: :tada: :tada:


changelog: fix links & section

What does this PR do?
fixing some bad links and adding new sections post 1.9 release
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Nice! Let's get this merged? :))

yes, release is out :tada:


Azure E2E: Analyze all test failures and get them all pass except product issues

So the overall status is, Out of 90 test cases, 71 passes.
In the rest 19 failures, 17 are caused by the 3 known issues:
a. DateTime serialization.
b. Handling the "ProvisioningState" field of Resource.
c. Parameter validation through pattern match.
2 issues were caused by new found issue that the Hydra spec converter didn't handle correct for PassThrough flag on dictionary type.

The CI failure is expected that this branch uses private azure common packages


Add a note about rustflags compatibility.

Over time, Cargo occasionally starts issuing new flags that may conflict with flags the user is passing directly to the compiler. Some recent examples are -C embed-bitcode (which broke anyone passing -Clto manually), and -C prefer-dynamic (which is kind of a mess). Future conflicts might be things like --remap-path-prefix or --extern-html-root-url (for rustdoc). This adds a note to mention these potential conflicts.
Although we try to maintain backwards compatibility as much as possible throughout all of Cargo, this particular area I think is dangerous enough that it is prudent to have some kind of warning somewhere. It is very rare that conflicts arise in practice, but they can happen.
I also added a note about passing in flags that Cargo itself issues, which can cause problems. Closes #9358.

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit 4d3772b8827b09eace478489f20514837b17b5b9 has been approved by alexcrichton

:hourglass: Testing commit 4d3772b8827b09eace478489f20514837b17b5b9 with merge 51eac9c4ff738ae1899ab40be5a718c8458ae4e3...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing 51eac9c4ff738ae1899ab40be5a718c8458ae4e3 to master...


YARN-11438. [Federation] ZookeeperFederationStateStore Support Version.

JIRA: YARN-11438. [Federation] ZookeeperFederationStateStore Support Version.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
33m  5s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 39s

trunk passed

+1 :green_heart:
shadedclient
24m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
23m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  3s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

96m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5537

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f9e1abae460e 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c380e2132368cb9c81333c6e29029bb2e95f5191

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/1/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 33s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 40s

trunk passed

+1 :green_heart:
shadedclient
24m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
23m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 10s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

107m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5537

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 22a9f3fd3d4f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c380e2132368cb9c81333c6e29029bb2e95f5191

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/2/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 44s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
24m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 28s

the patch passed

+1 :green_heart:
shadedclient
24m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  4s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

105m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5537

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e04d18b9d8be 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 468e3c6ae4e65025daa62ca2dc71b64dae0a91cc

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/3/testReport/

Max. process+thread count
537 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  8s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 41s

trunk passed

+1 :green_heart:
shadedclient
23m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
23m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  3s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

104m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5537

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ae0baa4d63c3 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 38b7ae6ed28406715a74b2a448cf2cfb1cc0058d

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/4/testReport/

Max. process+thread count
531 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 37s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 36s

trunk passed

+1 :green_heart:
shadedclient
23m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
23m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  4s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

104m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5537

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cbaf10578f77 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 70408bdde3279cea1c80af7ce4e936f6515f1d89

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/5/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this PR again? Thank you very much!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 51s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
24m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
23m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  4s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

122m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5537

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 238ed8ad2d06 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fcc88cb56426c25b2b861e34fe8513e8ed312e25

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/6/testReport/

Max. process+thread count
590 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5537/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Loose typing for object with index signature

TypeScript Version:  3.1.5

Search Terms:
Index Object Wrong Type Assertion
Code
const testObj: { [key: string]: string } = {
    'test': '423423423gwe',
    'fesgeg': 'yekwjfghkfhewk',
}

const test = testObj['fjdhsgjfhdg']

Expected behavior:
I expected that the type of the constant test is string | undefined or in best situation undefined. I could understand that typescript can't know of the key is available based on the index signature in the typing, but it doesn't make any sense to just assert that the given key name is available in the object.
Actual behavior:
the type of the constant test is string
Playground Link:
Playground
Related Issues:

I made the example code much smaller and easier

See discussion in #13778


Broken link on Storage Capacity page

Problem:
The text CSI ephemeral volumes on link is not working, it should point to this https://kubernetes.io/docs/concepts/storage/ephemeral-volumes/#csi-ephemeral-volumes
Check the page Storage Capacity for the problem.
Page to Update:
https://kubernetes.io/docs/concepts/storage/storage-capacity/
Proposed Solution:
It should resolve this issue by adding a simple link and enhancing the document line.
Update the link on the text CSI ephemeral volumes to https://kubernetes.io/docs/concepts/storage/ephemeral-volumes/#csi-ephemeral-volumes and not to this link.
/kind document
/assign
/language en

/triage accepted

/sig storage

/kind documentation


Allow download location to be specified when selecting deployment group artifacts

We're in a position at present where we are using the Download Pipeline Artifact to create a folder structure for our build artifacts (about 8 of them), as we have another tool which generates our patches from a specific output.
Is there any intention to give us the download option directly on the Artifact Download section of the Deployment Group and Agent jobs, rather than having to do this in tasks?
Or is it always expected to be only supported in tasks?

@chshrikh for deployment group question.

@bendursley You can set system.artifactsdirectory variable on release definition to change the download directory of artifacts

@omeshp isn't that for all artifacts, however, rather than just specific ones.
My example, so there's some clarity here:
If I have four artifacts, I download them to different directories as follows:
Database: $(System.ArtifactsDirectory)
Client: $(System.ArtifactsDirectory)\Bin\Client
Service: $(System.ArtifactsDirectory)\Bin\Service\Bin
Templates: $(System.ArtifactsDirectory)\Templates
We then build up our server patches based on this fixed locations.
It's possible to have this flexibility with the Download Pipeline Tasks.

Hi @bendursley, We currently don't support setting download location per artifact. We will support it in yaml based pipelines in future. Till then one option you can take is to move the artifacts to correct locations after download.

Thanks for the info @omeshp


JAVA-1995: Use rule chains to enforce JUnit rule order

No changelog entry because this does not impact production code.

Note that if the server rule is a @ClassRule but the session rule is a @Rule, a chain is not required because the former is automatically initialized first.

Forgot to mention: the only existing case of this is DefaultRetryPolicyIT.


in_app_purchase_storekit iOS platform tests failing on master, crashing during native tests

2023-01-12 15:45:05.739421-0800 Runner[16019:91680] This copy of libswiftCore.dylib requires an OS version prior to 12.2.0.
...
Testing failed:
	Runner (16019) encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted. (Underlying Error: Crash: Runner (16019) <external symbol>. If you believe this error represents a bug, please attach the result bundle at /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Runner-ggqcfckyiymcpddaoomloyrpgpgm/Logs/Test/Test-Runner-2023.01.12_15-43-49--0800.xcresult))

** TEST FAILED **

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8792132915415967441/+/u/Run_plugin_tests/native_test/stdout
Plugin tree is closed.

in_app_purchase_storekit uses shared_preferences_foundation, which is using Swift as of https://github.com/flutter/plugins/pull/6940.  The in_app_purchase_storekit example is an Objective-C project, which does not automatically set up the search paths to find the Swift runtimes.  shared_preferences_foundation should be hooking that up in its podspec.
See explanation at https://github.com/flutter/flutter/issues/16049#issuecomment-552060349 and the first time this was done in plugins: https://github.com/flutter/plugins/pull/6369


"Stoina" is listed in the drop-down menu

Description:
"Stoina" is listed in the drop-down menu alongside its corresponding county, according to the law
Precondition:
The website is up an running.

Step 1
Type "Stoina" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Stoina, GORJ".


[Error] Unable to write MeshSync data to the Meshery Database

Screenshots/Logs

Unable to write MeshSync data to the Meshery Database  app=meshery code=1002 probable-cause="Meshery Database is crashed or not reachable" severity=2 short-description="Error while writing meshsync data.no such table: objects" suggested-remediation="Restart Meshery Server.Please check if Meshery server is accessible to the Database"
Environment

Host OS: Linux
Platform: Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

// @mgfeller

the code 1002 isn’t on this page, though - https://docs.meshery.io/reference/error-codes#meshery-server.

@manav1403 is this issue still valid?


feat(controller):create viewer role in project namespace automatically on project creation

Follow-up to #1906.
This improves UX considerably by leaving an admin who has created a project only to assign the pre-created viewer role to SSO users with specific claims.

As discussed offline, I will amend this PR to also create a project level admin role.


Add dasel to tools

Thanks for adding dasel (data selector). Keep it up.. Greetings from Vienna. Cheers. Prost.


Rewrite GameUninstall Method

making the entire function from the older try of this method into one beeg method.
Old reference: https://github.com/bagusnl/Collapse/blob/8296c077a1c7ea4730f38a3b657cb39cfec7a6e0/CollapseLauncher/Classes/InstallManagement/BaseClass/InstallManagerBase.cs#L398-L726
With the help of @Arikatsu, @muscularcandy67, and @Cryotechnic
Resolve #141

 New Game Uninstall method


added my name to the guestbook.md

added my name Abosede Eniola Olarewaju  to the guestbook.md

added my name to the guestbook.md


Extend high scores

Add misclicks
Add steps total
Add time taken
Add date and time

My game today:
Grid 14   Score 52715   Time 00:20:01   Steps 181   Miss. 0032     25.05.2024  00:10  Daniel

Also, when the game is over, I want to see at which place I was without searching for my score.


EFK: practice/efk.md

This article is waiting to be claimed. practice/efk.md
@rootsongjc @gorda

/accept

/accept

/pushed

/merged


Java() doesn't create target for enum-switch anonymous class

This issue was originally created at: 2008-05-06 09:10:11.
This issue was reported by: mbrady.
mbrady said at 2008-05-06 09:10:11
When you 'switch' on an Enum, javac creates an anonymous inner class for the class doing the switch.  The Java parser doesn't create the .class file target for this.
For example, when I run 'scons' on the 3 files below, I expect to see
  Java parser found classes:
    Bar$1.class
    Bar.class
    Foo$1.class
    Foo.class

but I actually see:

  Java parser found classes:
    Bar.class
    Foo.class

Here are the test files.  (They are also attached)
Bar.java
public class Bar
{
  public void doSomething(Foo x)
  {
    // This switch statement produce anonymous inner class Bar$1.
    switch (x)
      {
      case A:
      case B:
      default:
      }
  }
}

Foo.java

public enum Foo
{
  A, B;

  public void doSomething()
  {
    // This switch statement produce anonymous inner class Foo$1.
    switch(this)
      {
      case A:
      case B:
      default:
      }
  }
}

SConstruct
env = Environment()
env['JAVAVERSION'] = "1.6"

jclasses = env.Java('.', '.')

print '-' * 60
print 'Java parser found classes:'
print '-' * 60

for jc in jclasses:
    print jc

print '-' * 60

mbrady said at 2008-05-06 09:13:10

Created an attachment (id=400)
enum Foo that contains a switch statement

mbrady said at 2008-05-06 09:13:33

Created an attachment (id=401)
class Bar that contains a switch statement

mbrady said at 2008-05-06 09:14:44

Created an attachment (id=402)
SConstruct that lists found .class file targets.

stevenknight said at 2008-05-06 09:34:49
Hi Michael--

Thanks for the report.  What version of Java are you using?  Different versions have slightly different behavior w.r.t. naming the files for anonymous inner classes, and I want to make sure that whoever fixes this gets the right fix(es) for the right Java versions.
Thanks,

mbrady said at 2008-05-06 09:48:51

Stephen,
I'm using JDK 1.6.0 update 4 (1.6.0_04).
Do you think that this is fixable?
Seems like the parser would have to look at a switch statement and figure out whether it's switching on a primitive or an Enum.  Is this do-able with the current parser?
Thanks for your help.
--Michael

gregnoel said at 2008-05-23 13:59:39
Bug party triage.

russel said at 2008-06-05 22:21:08

I wonder if replicating the Java parser in Python is a bad idea, wouldn't it be better to get the Java parser to parse the Java code and report back.  By invoking the javadoc command with a suitable Doclet, you can get a parse and report on the parse from the definitive source, the java compiler.
gregnoel said at 2008-12-26 13:30:40

Adjust triage of issues.

managan said at 2009-08-28 12:50:09

add java to keywords

stevenknight said at 2009-11-10 18:00:19

stevenknight => issues@scons

dirkbaechle said at 2014-07-12 06:26:11

added dependency

mwichmann said at 2017-12-12 12:55:14

see also bug 2547

mwichmann said at 2017-12-13 09:16:31

adding self to Cc list

Votes for this issue: 1.
mbrady attached Foo.java at 2008-05-06 09:13:09.

enum Foo that contains a switch statement

mbrady attached Bar.java at 2008-05-06 09:13:32.

class Bar that contains a switch statement

mbrady attached SConstruct at 2008-05-06 09:14:44.

SConstruct that lists found .class file targets.

dirkbaechle said this issue blocks #2733 at 2014-07-12 06:26:11.

Seems to be the same as #2547, can we combine?  See also #2742, which has a patch proposal.


Change name of repository to model_seg_lesion_mp2rage

To be consistent with the sister repository: https://github.com/ivadomed/model_seg_sc_mp2rage

Closing this issue as discussed in the previous meeting (i.e. no need to change the name of repository) because

we decided to have a single repository for both models and
the lesion and sc separation is therefore no longer necessary: we can stick to ms.


Whats app message

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
4, due to the extensive changes across multiple files including JavaScript, CSS, and schema modifications. The PR affects both front-end and back-end components, requiring a thorough review to ensure consistency and functionality across the application.

 🧪 Relevant tests
No

 🔍 Possible issues

Possible Bug: The PhoneNumber field added in Schema.js does not specify any constraints or validation for phone numbers, which might lead to inconsistent data formats being stored.

Code Redundancy: The CSS for .categoryTitle is defined twice with the same properties in Categories.module.css, which could lead to maintenance issues.
 🔒 Security concerns
No

 Code feedback:
relevant fileServer/models/Schema.js
suggestion

Consider adding validation for the PhoneNumber field to ensure data consistency. For example, use a regex pattern to validate phone numbers. [important]

relevant line},  PhoneNumber: {
relevant fileClient/src/pages/Categories.module.css
suggestion

Remove the duplicate .categoryTitle CSS block to maintain cleaner and more maintainable code. [important]

relevant line.categoryTitle{
relevant fileClient/src/pages/Whyus.jsx
suggestion

Extract inline styles for h1 into the CSS module for better maintainability and separation of concerns. [medium]

relevant lineWhy Us?
relevant fileClient/src/components/Datadisplay.jsx
suggestion

Implement error handling for the sendMessage function to manage cases where window.open might fail or be blocked by browser settings. [medium]

relevant lineconst sendMessage = (phoneNumber) => {

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.


Extend AD tutorial

Figure for the docs:

The windows builds fail due to weird GitHub Actions failures such as https://github.com/trixi-framework/Trixi.jl/pull/522/checks?check_run_id=2298121942#step:6:361. I propose to merge this as it is since the failures are not related to this PR (and we experienced similar failures on Windows in the last few days...).


TopEarlgreyAlertIdLcCtrlFatalProgError done in sw/device/tests/sim_dv/lc_ctrl_program_error.c?

Spun out from https://github.com/lowRISC/opentitan/issues/15649.
@gdessouky @cindychip can you double check whether that is the case?

https://cs.opensource.google/opentitan/opentitan/+/master:hw/top_earlgrey/dv/env/seq_lib/chip_sw_lc_ctrl_program_error_vseq.sv;l=5?q=lc_ctrl_program_err&sq=&ss=opentitan%2Fopentitan:hw%2F
I believe the sequence for forcing is done, we just need to add some checkings to align with the all_escalation to check alert_handler and plic interrupt values.
Should be a max half day effort.

Yup, exactly, can confirm this was also my understanding - the escalation and reset are triggered, but we are missing checks on the alert cause; that it is as expected and that after reset, the alert handler cause is cleared and the fault register is also cleared - in line with that chip_sw_all_escalation_resets test.

Closing this issue as the PR for the test has been merged.


Update common files.

Will need a change in test-infra to get all tests passing.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.4
821f98653a393aad0358690865a65ed712c88b09
link
/test lint_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.4
821f98653a393aad0358690865a65ed712c88b09
link
/test lint_istio_release-1.4

gencheck_istio_release-1.4
3f56668431b363f420f65e900901f5be04d69b94
link
/test gencheck_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.4
3f56668431b363f420f65e900901f5be04d69b94
link
/test gencheck_istio_release-1.4

lint_istio_release-1.4
3f56668431b363f420f65e900901f5be04d69b94
link
/test lint_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.4
3f56668431b363f420f65e900901f5be04d69b94
link
/test lint_istio_release-1.4

gencheck_istio_release-1.4
3f56668431b363f420f65e900901f5be04d69b94
link
/test gencheck_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.4
3f56668431b363f420f65e900901f5be04d69b94
link
/test gencheck_istio_release-1.4

lint_istio_release-1.4
3f56668431b363f420f65e900901f5be04d69b94
link
/test lint_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
On Mon, Oct 28, 2019, 5:33 AM Istio Automation<EMAIL_ADDRESS>wrote:

@geeknoid https://github.com/geeknoid: The following tests failed,
say /retest to rerun them all:
Test name Commit Details Rerun command
gencheck_istio_release-1.4 3f56668
https://github.com/istio/istio/commit/3f56668431b363f420f65e900901f5be04d69b94
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/18365/gencheck_istio_release-1.4/139 /test
gencheck_istio_release-1.4
lint_istio_release-1.4 3f56668
https://github.com/istio/istio/commit/3f56668431b363f420f65e900901f5be04d69b94
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/18365/lint_istio_release-1.4/142 /test
lint_istio_release-1.4
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/18365?email_source=notifications&email_token=AAEYGXLMTRCTRNJO45VMCC3QQ3L3DA5CNFSM4JFTKLD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECMWZ6A#issuecomment-546925816,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXMZKWMLIYMHFWAUFC3QQ3L3DANCNFSM4JFTKLDQ
.


Improve OpDef serialisation to include Function-valued fields

OpDef has several fields(/subfields) containing various Box<dyn ...> values. These are currently dropped during serialisation.
Consider whether these should be serialised by the same mechanism as dyn CustomConst, or how they can otherwise be serialisation round-tripped.

See #1344: these operations are now serialized with markers indicating expected binaries. Loading code (e.g. validation) can make decisions as to how to handle this.


Add json-schemas for Configuration json files

Title
Add json-schemas for Configuration json files
Type of Change

[x] DX Enhancement
[x] QOL

Description
Add json-schemas for Configuration json files
Impact
Will help with editing config json with intelligence and keeping a documentation of the expected json format.
Future Plans
Validate it using some validators
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

@MyDrift-user Do you see this as any improvement to the DX? This Doesn't affect any functionality!

This seems to to be up-to date with current changes. It looks like it will break the special characters which's logic I have modified in my Refractor

Lol, I was having fun with this implementation, but really the pester and unit tests in github actions it seems like overkill. I'm going to close it.