EdcRuntimeExtension: Can't load injected implementations when working with SQL Policy Store

Bug Report
Describe the Bug
When trying the to implement sql policy store implementation. The EdcInjectionException is thrown for contractDefinitionStore and sqlPolicyStore even after providing appropriate dependencies
Expected Behavior
The build should get succeed and the the application should run with SqlPolicyStore
Observed Behavior
When adding :extensions:sql:policy:store and :extensions:sql:contract-definition:store the shadowJar is not created properly. After checking the generated jar I noticed the contract definition classes are not being picked up
Steps to Reproduce
We are trying EDC with following dependency structure.

Create the module using following gradle file

plugins {
    `java-library`
    id("application")
    id("com.github.johnrengelman.shadow") version "7.0.0"
}

val rsApi: String by project

dependencies {
    implementation(project(":extensions:dataloading"))
    implementation(project(":extensions:api:api-core"))
    implementation(project(":extensions:sql:policy:store"))
    implementation(project(":extensions:sql"))
    implementation(project(":extensions:sql:asset:index"))
    implementation(project(":extensions:sql:pool:apache-commons-pool"))
//    implementation(project(":extensions:sql:contract-definition:store")) // Since this dependency is part of extensions:sql not needed again
    implementation(project(":extensions:aws"))
    implementation(project(":extensions:transaction:transaction-local"))
    implementation(project(":extensions:api:data-management:asset"))
    implementation(project(":common:util"))
    implementation(project(":data-protocols:ids"))
    implementation(project(":extensions:iam:iam-mock"))
    implementation(project(":extensions:data-plane:data-plane-http"))
    implementation(project(":extensions:data-plane:data-plane-framework"))
    implementation(project(":extensions:data-plane:data-plane-spi"))
    implementation("org.postgresql:postgresql:42.3.3")
    implementation("jakarta.ws.rs:jakarta.ws.rs-api:${rsApi}")
}

application {
    mainClass.set("org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime")
}

tasks.withType<com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar> {
    exclude("**/pom.properties", "**/pom.xm")
    mergeServiceFiles()
    archiveFileName.set("provider.jar")
}

Aim is to use following class with other mentioned classes.

 @Inject
 SqlPolicyStore sqlPolicyStore;

Build gets successful on invoking

./gradlew clean samples:sql-policy-demo:provider:build

When we run the generated Uber/Fat jar with following command, It gives following error

 java -Dedc.fs.config=samples/sql-policy-demo/provider/config.properties -jar samples/sql-policy-demo/provider/build/libs/provider.jar
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

INFO 2022-04-12T22:17:40.723493 Initialized Null Vault
SEVERE 2022-04-12T22:17:40.794663 Error booting runtime
org.eclipse.dataspaceconnector.spi.system.injection.EdcInjectionException: The following injected fields were not provided:
Field "contractDefinitionStore" of type [interface org.eclipse.dataspaceconnector.spi.contract.offer.store.ContractDefinitionStore] required by org.eclipse.dataspaceconnector.contract.ContractServiceExtension
Field "sqlPolicyStore" of type [class org.eclipse.dataspaceconnector.sql.policy.store.SqlPolicyStore] required by org.eclipse.dataspaceconnector.extensions.api.ProviderExtension
Field "contractDefinitionStore" of type [interface org.eclipse.dataspaceconnector.spi.contract.offer.store.ContractDefinitionStore] required by org.eclipse.dataspaceconnector.extensions.api.ProviderExtension
	at org.eclipse.dataspaceconnector.boot.system.ExtensionLoader.sortExtensions(ExtensionLoader.java:194)
	at org.eclipse.dataspaceconnector.boot.system.ExtensionLoader.loadServiceExtensions(ExtensionLoader.java:149)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.createExtensions(BaseRuntime.java:183)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.boot(BaseRuntime.java:106)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.boot(BaseRuntime.java:90)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.main(BaseRuntime.java:69)

Context Information
It seems dependency issues. The generated Jar does not contain the contract definition store class. Upon adding the classes manually as library the example is working

Used version: EDC v1.0.0
OS:ubuntu

Detailed Description
Provided above
Possible Implementation
Seems the dependency is not being loaded in the generated jar

Thanks for reporting.
After a sneak peek:

on the point 2., you can't inject the SqlPolicyStore implementation, you should inject the interface PolicyStore
what if you uncomment the implementation(project(":extensions:sql:contract-definition:store")) row? it works?

Thanks for replying back @ndr-brt
Thanks for highlighting, Changed to PolicyStore Spi now.
But the error remains for contractDefinitionStore dependency as follow after uncommenting the dependency implementation(project(":extensions:sql:contract-definition:store"))
org.eclipse.dataspaceconnector.spi.system.injection.EdcInjectionException: The following injected fields were not provided:
Field "contractDefinitionStore" of type [interface org.eclipse.dataspaceconnector.spi.contract.offer.store.ContractDefinitionStore] required by org.eclipse.dataspaceconnector.contract.ContractServiceExtension
Field "contractDefinitionStore" of type [interface org.eclipse.dataspaceconnector.spi.contract.offer.store.ContractDefinitionStore] required by org.eclipse.dataspaceconnector.extensions.api.ProviderExtension
	at org.eclipse.dataspaceconnector.boot.system.ExtensionLoader.sortExtensions(ExtensionLoader.java:194)
	at org.eclipse.dataspaceconnector.boot.system.ExtensionLoader.loadServiceExtensions(ExtensionLoader.java:149)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.createExtensions(BaseRuntime.java:183)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.boot(BaseRuntime.java:106)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.boot(BaseRuntime.java:90)
	at org.eclipse.dataspaceconnector.boot.system.runtime.BaseRuntime.main(BaseRuntime.java:69)
Disconnected from the target VM, address: '<IP_ADDRESS>:47105', transport: 'socket'

I think it's an issue with gradle: https://github.com/gradle/gradle/issues/847
Probably we would need to give unique names to the modules

Thanks for the quick response and identifying the issue. Can we expect the fix having unique module name soon?

Opened a PR about this, would you be so kind to have a try on that commit? (module names are changed, details in the PR #1154 )

Thanks for helping out, @ndr-brt . I have verified the PR and code works fine :+1:

Good! Let's keep this open until the PR gets merged


bad link

website: https://github.com/milvus-io/docs/blob/0.6.0/userguide/cpu_milvus_docker.md
broken link：

the link was not timely updated on this doc,you can find it on chinese guidehttps://github.com/milvus-io/docs/blob/master/site/zh-CN/guides/get_started/install_milvus/cpu_milvus_docker.md

@AmyYH  Please double check if this issue has been put to rest.

Please refer to the latest version v0.10.2:
https://github.com/milvus-io/docs/blob/master/v0.10.2/site/zh-CN/quick_start/install_milvus/milvus_docker-cpu.md


[Feature Request] Mentions

Here is a video showcasing the feature on iOS
https://user-images.githubusercontent.com/53708281/137012530-b9562918-a1fa-48ae-8648-da7faa3b5c00.mp4
and here it is on macOS.
As seen in https://github.com/BlueBubblesApp/BlueBubbles-Desktop-App/issues/224, MyMessage has partial support for this feature since it shows mentioned names in boldface.

Completed by @elliotnash because he's just that good


simulate OD pairs

I would like to try simulating the OD pairs in addition to the paths. This would allow for the removal of the dependency on real world TLC data, and allow simulations to be created in other regions or even globally. Pairs could be generated probabilistically based on node density, which can be calculated from the OSM data the tool already needs for operation.

🚢 'd


[Documentation] Runtime testing using filename

Description

RBS does not support filename based runtime testing using CLI command rbs test

Explanation

RBS uses Open3.capture3 to run a command for executing runtime tests.
If a filename is passed as an argument to rbs test command, Open3.capture3 executes the filename as a command, due to which a Permission denied error is thrown.

This error is because a filename cannot be executed as a command, using Open3.capture3, which throws permission denied error.

How about $ rbs test ruby test.rb ?

Closing this as ruby/gem_rbs_collection#41 is merged.


When overriding dest_addr, also override Host header

This is my local fix for https://github.com/fzipi/go-ftw/issues/60.
Seems to work well enough here, though the problem running 920171-1 which prompted the nil check could use a look.

Replaced by #63.
Thanks for the contribution. I've polished your PR with a test and some cleanup, and added you as co-author to the commit.


Cook-4667

Hey friends,
I need to be able to have no action taken on the tomcat service resource at time of convergence. There was another pr (https://github.com/opscode-cookbooks/tomcat/pull/57) doing something simliar, but this is much more flexible and I don't care about the SSL changes being implemented there.
Updated the readme with attribute description as well as added logging output for invalid actions.
https://tickets.opscode.com/browse/COOK-4667

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@elebertus

Please sign the CLA here.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@elebertus

Please sign the CLA here.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@elebertus

Please sign the CLA here.

Since the CLA hasn't been signed in over 6 month for this PR I'm going to close it out at this point.  If the author would like to sign the CLA feel free to open up the PR again.


feat: add partial withdrawal

we could redo the "expand position" function to "modify position"

the modify position function should allow users to add tokens (functionality of the expand position function) or unbond some.


Bootstrap-ify Doxygen

This project looks like pure gold. Make it happen
https://github.com/Velron/doxygen-bootstrapped

The standard search bar doesn't work with this layout, and it was also generated prior to the namespace icons. The result looks great at first glance, but degrades quickly as you look closer. I'll stick with vanilla Doxygen for now.

Not ready for prime time, huh? Better to try than not! Thank you.
On Mon, Dec 21, 2015 at 10:23 AM, David Zemon<EMAIL_ADDRESS>wrote:

The standard search bar doesn't work with this layout, and it was also
generated prior to the namespace icons. The result looks great at first
glance, but degrades quickly as you look closer. I'll stick with vanilla
Doxygen for now.
—
Reply to this email directly or view it on GitHub
https://github.com/DavidZemon/PropWare/issues/58#issuecomment-166328844.


Feature:

An API for fetching audio books from open source domain relevant to keyword added by the user. User can play audio book in an interactive window.

Please assign me this for hacktoberfest


0 clients connected to this buffer?

Describe the bug

Installed kickstart, but :LspInfo yields:
0 clients connected to this buffer
Configured servers list: lua_ls
When opening a .cpp file
To Reproduce

git clone https://github.com/nvim-lua/kickstart.nvim.git "${XDG_CONFIG_HOME:-$HOME/.config}"/nvim
nvim
:LspInfo

Desktop

OS: Windows (WSL)
Terminal: Windows Terminal

Neovim Version

NVIM v0.10.1
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068

no bug. you have to install them with :Mason i


Fixed afterPacketout() to retry recoverable warnings

Added extra handling in DecoderStream.afterPacketout() to deal with recoverable errors in libogg's ogg_stream_packetout.
Now afterPacketout() will correctly retry when ogg_stream_packetout sets rtn = -1
This makes node-ogg more resilient to imperfect (but perfectly usable) ogg streams.
For more info: http://xiph.org/ogg/doc/libogg/ogg_stream_packetout.html

This looks good, but do you have a sample OGG file where this is relevant?

This is relevant in streaming situations, such as tuning into an Icecast broadcast that's in mid-stream.
In the .ogg file I've linked to below, I captured ~ 5 seconds of a live Icecast stream to disk.
https://brandonkirsch.com/media/myOggRip.ogg

rebased and fixed white space issues here 👉 #19
sorry for the very long delay in getting this in 🙈 ❤


ftBrony doesn't react to the B button at all times

It only reacts after additional FTP commands. In Windows Explorer, f.e. you have to push the B Button on the 3DS (seemingly nothing happens) -> refresh or change the folder in Windows Explorer (it fails in WIndows Explorer, but on the 3DS you get the "Push B to quit message") -> push B again to quit.
I think (I'm not sure) the reason is in the ftp_session_read_command(ftp_session_t *session) function, more specifically in the line saying:
rc = recv(session->cmd_fd, buffer, sizeof(buffer), 0);
No idea how to properly fix this yet, though.

maybe force close connections from serverside killing the FTP server and re-opening?

Well, if we knew where to check the buttons, force exiting would be easy. Problem now is, I have no idea where in the source code it hangs.

A sec...
<EMAIL_ADDRESS>

Yeah, that's where it waits for the B button (that's actually after you teh B button was detected the first time). The question is, if it refuses to react to the B button in any way - where in the code is it?

Just a quick note... While ftBrony 1.1 does in fact look a lot better than ftBrony 1.0 (I'm also pretty sure there are a lot under-the-hood changes), it will still not fix this issue.

I finally narrowed this down to socExit() blocking. I'm not sure how to investigate further. ftBRONY will respond when the client drops its connection.

Thanks for looking into this! I'm pretty sure force exit would be possible, but the (possible) consequences...? No idea. That issue doesn't happen with 'proper' FTP clients, btw, but almost everyone uses WIndows Explorer, I guess.

I've seen it happen with several apps, such as ES File Explorer on my phone.
You should be able to hold L+R+DOWN+B to exit to hbmenu. That's finnicky though, I think it will leak open handles. I would also try closing Windows Explorer.

No, closing it does not work. If you close it, you are forced to do the force close on 3DS. You need to (1) press B on 3DS, (2) F5 refresh in Explorer, (3) press B again on 3DS.

I have had it happen with Cyberduck as well, though not with the recent release.

As far as I can tell, this is just a quirk of the SOC:U service. It's blocking on SOCU_Shutdown(). I tried setting linger options, as well as using recv() on the socket before doing close() (in case that was needed to ACK a client-side shutdown). Nothing seems to help at all. The best I can do for now is put a print message that says "Waiting for socExit()..."


for archive.org

I now have access to archive.org working.
See my test case here : https://github.com/h4ck3rm1k3/hadoop-archive-org-bucket-fs
new URI("s3://bucketname").getHost()
is returning null, and I wonder how this ever worked.

I am having some problems with further testing. Closing this PR for now until I fix and test more.

https://github.com/h4ck3rm1k3/hadoop-archive-org-bucket-fs/issues/1 this is the problem that I found. Needs more work. Need to create test cases inside of hadoop for this.


Regression between 1.8.2 and 2.0.0

When I upgrade to 2.0.0, I get following error
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/sandbox/node_modules/svelte-je
ster/src/svelteconfig' imported from /sandbox/node_modules/svelte-jester/src/transformer.js

Here's the sandbox where this error can be seen.
If I revert svelte-jester to 1.8.2, sandbox gives a different error but the same code works fine in my local system.

I have the same issue. Working on a fix.

Hmm there still seems to be a bit of a problem. In our project, we still get stuff like this:
Jest: synchronous transformer .../node_modules/svelte-jester/src/transformer.js must export a "process" function.

Is this related or a separate issue?

@winfr34k you may want to refer to messages in this PR. You can also checkout this sandbox where its working as an ESM module in its glory with all kind of configurations :-)

Thank you, @bhvngt!
However, we seem to still have incompatible dependencies (jest-mock-extended), so we can't switch just yet...
If anyone is interested in a diff to what's changed in our svelte/kit project, have a look here: https://github.com/communityvi/communityvi/pull/126/files

Hmm there still seems to be a bit of a problem. In our project, we still get stuff like this:
Jest: synchronous transformer .../node_modules/svelte-jester/src/transformer.js must export a "process" function.

Is this related or a separate issue?

You will get this error, if Jest thinks something does not use ESM. Could be Typescript or another transformer.


Add setting to control inline chat accessibility logic

We have added an accessible diff viewer for inline chat. Today, this is on when accessibility mode is on and off otherwise. We should have dedicated setting with on, off, and auto

To verify

check that inlineChat.accessibleDiffView exists
check that it works as advertised


Add filter count on top of filter icon

for https://github.com/filamentphp/filament/pull/3549

Thanks!


This page may need updating to include Syntax references.

[Enter feedback here]
This page may need updating for Syntax

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 774d5574-4307-5a2d-5fde-020f7d4c0c40
Version Independent ID: ae77d33a-e9c4-80d9-03f7-e93d1df26181
Content: Can Machine Learning be used to assign managed metadata attributes for items?
Content Source: Community/machine-learning-and-managed-metadata.md
Service: machine-learning
GitHub Login: @bhall999
Microsoft Alias: jhendr

@mikezimm - The original author of this article seems to have moved on. If you have any specific suggestions, we'd love to incorporate them!

Hello @mikezimm, just checking in to see if you have any specifics we can add to this article or if we should close the issue. Thanks so much!

@eemancini ,
It has been a while but when I was looking at it I was surprised that an article talking about AI and assigning meta data would not make any reference to Microsoft Syntex:
https://www.microsoft.com/en-us/microsoft-365/enterprise/sharepoint-syntex?activetab=pivot%3Aoverviewtab


Trigger events from buttons extension

I have a tabular table up and running with several table buttons that work great. However, I am trying to trigger a Meteor template event based on a button, and am unable to get it to fire.
In my case, I have a table of contacts and a Meteor method to merge duplicate contacts. I want to trigger this process by clicking a "Merge Contacts" button. While I know I can add an action function to the button, to keep my code organized and to take advantage of the template context, I want to use a Meteor template event.
Here's my table code:
TabularTables.Contacts = new Tabular.Table({
  name: "contactTable",
  collection: Contacts,
  select: {
    style: 'multi',
    selector: 'td:first-child'
  },
  columns: [
    {
      orderable: false,
      className: 'select-checkbox',
      targets: 0
    },
    {
      title: "First Name",
      data: 'firstName',
      visible: true
    },
    {
      title: "Last Name",
      data: 'lastName',
      visible: true
    },
    {
      title: "Email",
      data: 'emails.0.address',
      visible: true
    },
    {
      title: "Actions",
      tmpl: Meteor.isClient && Template.contactListActions,
      visible: true
    }
  ],
  dom: '<"top"Bf>rt<"bottom"<"pull-left"il>p><"clear">',
  buttons: [
    {
      text: 'Add Contact',
      action: function addContactLink() {
        FlowRouter.go('/contacts/new');
      }
    },
    {
      extend: 'colvis',
      text: 'Columns'
    },
    {
      extend: 'collection',
      text: 'Actions',
      autoClose: true,
      buttons: [
        {
          text: 'Merge Contacts',
          className: 'dtMergeBtn'
        },
        {
          extend: 'csv',
          text: 'Export Contacts'
        },
      ]
    }
  ],
  'colVis': {
    'buttonText': 'Change columns'
  }
});

And here's the event:
Template.contactList.events({
  'click .dtMergeBtn' ( event, template ) {
    $('#dedupeContacts').modal('show');
    [ ... event functionality ... ]
  }
});

If I place a console.log("click dtMergeBtn"); in the button's action within the table definition, it shows up in the console as expected. However, if I place the same console.log(); in the template event, nothing happens.
I'm wondering if it's because I'm using a button collection to make the buttons in a dropdown, but even when I add the buttons to the main line they work.
Also, other buttons in the collection that use native dataTables functionality, like export and print, work just fine.
Any help would be greatly appreciated! Thanks!

I found out more about this issue, although I still don't have a super-clean resolution.
In DataTables, buttons placed in a collection, so they appear as a dropdown menu, are only rendered into the DOM when the parent is clicked. So normal Meteor template events don't register the event.
So instead of a typical Meteor event, I used a jQuery delegated event handler in the onRendered function to call the method.
Template.contactList.onRendered(function () {
  // WARNING: Hackiness ahead. Unable to make events fire on dataTable collection
  // buttons since they only render on click. This is the only way I could find to
  // trigger the click event

  $('body').on('click', '.dtMergeBtn', function() {
    $('.dt-button-background').hide();
    $('.dt-button-collection').hide();

    $('#dedupeContacts').modal('show');
    [ ... more event handler ... ]
  });
});

Also, I had trouble getting the autoClose parameter to take hold on the collection, hence the $().hilde(); effect on the collection DOM elements.
If anyone has a less-hacky way of triggering Meteor event handlers in this situation, I'd love to learn, but this appears to at least be functional if anyone runs across the same problem.

Of course, the actually best thing to do is probably just include the event handler in the button's action. I was just trying to keep the code organized, and also try to take advantage of getting ReactiveVars, which I don't think you can from within a button's action.


Add cashed out leave support for AU Payroll

Update the AU Payroll configuration to allow support for Cashed Out Leave.
This includes adding a new property to both the LeaveApplication object for leave requests, and LeaveEarningsLine object for pay slip identification.
Description
Additions to xero-payroll-au.yaml:
Add new property PayOutType to the LeaveApplication object.
Add an equivalent property to the LeaveEarningsLine object.
Release Notes
API users need to be able to create Cashed Out Leave applications, and also to be able to tell which lines on the employee payslip corresponds to cashed out leave.
Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@rdemarco-xero  yes that will be part of the work, this was just a quick draft as an example of what the solution likely is - this is work for a future sprint. Though I will add updating the examples to the acceptance criteria of the ticket so it is captured clearly as a requirement.


add another condition to isEmpty

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
❌

An undefined variable should means empty  in the method named isEmpty of QueryTrait

this pr is to sloved the following case :

$query = new \yii\db\Query();

$query->andFilterWhere([
    'myCondition'=>$myCondtionValue //  This undefined variable cause a warning
]);

my mistake


Rename relaton caches

From global ?  "#{Dir.home}/.relaton-bib.pstore"<EMAIL_ADDRESS>to a suffix of @ronaldtse's choice.

I'm surprised; I'd have thought you'd want the local cache specific to the document and not the directory. In fact, this change means I did not need to do https://github.com/riboseinc/metanorma-cli/issues/9 after all. But OK.

Need to change relaton-cli as well, since it uses the current cache.


Throw GitHubProjectItemNotFoundError if a project item cannot be found

Please avoid duplicates

[X] I checked all open feature requests and none of them matched my problem.

What’s missing?
A custom GitHubProjectItemNotFoundError error
Why?
Current error looks like this
GraphqlResponseError: Request failed due to following response errors:
 - Could not resolve to a node with the global id of 'PVTI_lADNJr_OAAWBdc4Cg8PL'.

Alternatives you tried
Catche GraphqlResponseError based on message, not ideal.
Would you be interested in contributing the feature?

[ ] yes

closing in favor of #145


move locus calculation to separate function

This moves the locus calculation from RichDiagnostic::render to Diagnostic::locuses. Some questions to answer:

[ ] Is the implementation impact acceptable?
The way I implemented this has some impacts on the existing API though: Because this way uses a BTreeMap keyed with the FileId, the FileId must now implement Ord instead of just PartialEq.
This was the simplest and least overhead accumulating way to enable deduplication by file. Alternatively we could derive another arbirary ordering of the FileIds, e.g. by indices from a deduplicated Vec.
I personally think this change is justified because

many library users make use of SimpleFiles, which is compatible and
any sensible candidates for FileId that I can think of and implement PartialEq also implement Ord.

[ ] Should this new function be added to the public API?
I did not yet implement it this way, but it was suggested in #333. This would go towards better enabling "alternative" renderers.

Please note the CI is failing because of dependencies not being compatible with the oldest tested against Rust version (1.40.0).

I'm wondering if there is as way to do this without needing to allocate an intermediate BTreeMap for this? 🤔 That's the one thing that would give me pause I guess.
We might also be able to solve this better if we had some sort of intermediate 'resolved diagnostic' - something I'm hoping we can get to at some stage!

The reason for using a BTreeMap was this comment https://github.com/brendanzab/codespan/blob/629d35a4c9f30236a2adbc5773c756d23d1775d7/codespan-reporting/src/term/views.rs#L98-L100
I would not call it an "intermediate BTreeMap" because its used afterwards, like the vector the above comment is referencing.
I don't see a way without allocating some data structure similar to this. We could do with a Vec but that does not come with the deduplication built in, and no advantages that I am aware of.


a ^funny command.. with a #funny_submit

example: (someone uses: ^funny.. happybot: Dental hygiene that's your most appealing feature..)
example of #funny_submit: ^funny: Happyheart cannot swim, but he can throw tnt!
if you don't want the "Funny_submit" text channel, give this message a ⬇ , if you want the "Funny_submit" text channel, k give this message a ⬆ .

remove #gamble and replace it with #funny_submit


Update dependency eslint-plugin-jsdoc to v7.2.3

Renovate-bot automated upgrade failed because of required manual changes, this PR adds those changes

Replace with #133


electron-cash: 4.0.14 -> 4.1.0

(cherry picked from commit d3958aa3fa5fbd9ee162a0872ef3d4562d951d6f)

Motivation for this change
#97479
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

should target release-20.09 not nixos-20.09

Yes, sorry


feat: Add context to install command

@adifayer theres another update here https://github.com/datreeio/docs/pull/110
lets close this one


chore: Add dependabot for Github Actions and Pub

Can you explain what it does?

Yes, it's a tool for check new version of dependencies.
When a new version is available, Dependabot create a PR with the new version of the dependence.

Such a great feature!
Thank you.


Rust: first commit

First effort towards https://github.com/denisidoro/navi/issues/154

Closing without merging because rust will keep being a "feature" branch


[Frontend] Sign-in/sign up page

use react to create user sign-in/sign-up page
assignee: Rayyan

Sign-In page is completed

Currently working on the sign up page, not started yet but will start soon


Add Garden Linux to /etc/os-release

What would you like to be added:
Garden Linux currently does not show that it is Garden Linux.
# cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux bullseye/sid"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Why is this needed:
This is why in any monitoring it appears always as Debian:

Garden Linux is essentially a Debian operating system so we cannot and should not try to impersonate it as another operating system, especially as some installed programs may rely on it. There are however some valid additions that we should do based on man 5 os-release.
PRETTY_NAME="Garden Linux (Debian GNU/Linux bullseye/sid)"
NAME="Garden Linux"
ID=debian
HOME_URL="https://gardenlinux.io"
BUG_REPORT="https://github.com/gardenlinux/gardenlinux/issues"
VERSION_ID="<<gardenlinux release>>"

@gehoern , @MalteJ: what do you think?

Fixed, the entry looks as follows:
RETTY_NAME="Garden Linux"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://gardenlinux.io/"
SUPPORT_URL="https://github.com/gardenlinux/gardenlinux"
BUG_REPORT_URL="https://github.com/gardenlinux/gardenlinux/issues"
GARDENLINUX_FEATURES=base,gcp,gardener,_prod,server,cloud
GARDENLINUX_VERSION_ID=20200427
GARDENLINUX_BUILD_ID=27.0
VERSION_CODENAME=bullseye

+1


Really Domain Admins???

Does this really require Domain Admins? And if so why and when will it be fixed so we can delegate and/or specify a different level of rights?
I swear the whole Azure model is taking us back 20 years in the security space and acting like we are all working in 20 user mom and pop shops where domain admins is just given to everyone so everything "works".
You guys have received 20+ years of "this is not an acceptable model to do things", are we looking to continue that message for another 20?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5c653c09-5b97-4bf0-7581-d4749993e3d9
Version Independent ID: a90440e8-1d30-9fba-5148-813df159ae2f
Content: Azure AD Connect: Seamless Single Sign-On - Frequently asked questions
Content Source: articles/active-directory/connect/active-directory-aadconnect-sso-faq.md
Service: active-directory
GitHub Login: @swkrish
Microsoft Alias: billmath

@jricha34 Thanks for your feedback! We will investigate and update as appropriate.

@jricha34 I understand your point. Please note that there is already a feedback provide related to it in Azure Feedback forum. Please upvote the feedback. This will help feature team prioritize the requirement for implementation.

@jricha34 We will now proceed to close this thread. If there are further questions regarding this matter, please open a new issue and we will gladly continue the discussion.


Fix callback key expression example.

This is https://github.com/OAI/OpenAPI-Specification/pull/1545, repackaged on the correct branch.  :)


How to listen for migration events

Hello, Guys.
I know this is not really an issue, but I have asked this on Stackoverflow but answer yet for over 13 hours
You know when you use SequelizeJS with migration and not .sync, when you want to make changes to your DB structure, you generate and edit a migration for it.
Then you run sequelize db:migrate
This updates the db schema structure but not the corresponding Sequelize model.
You have to manually edit the model to match the current state of the actual DB
Now that is what I want to automate (kind of).
There is a function in Sequelize QueryInterface: showAllTables and describeTable that list all tables in the database and get table schema respectively.
I want to use those functions to fetch the current database schema and populate it to a file each time I run sequelize db:migrate or sequlize db:migrate:undo (Just like rails migration does)
Now my problem is hooking into that migration event.
I know that Sequlize CLI use Umzug for migration and the Umzug README says:

Umzug is an EventEmitter. Each of the following events will be called with name, migration as arguments. Events are a convenient place to implement application-specific logic that must run around each migration:

migrating - A migration is about to be executed.
migrated - A migration has successfully been executed.
reverting - A migration is about to be reverted.
reverted - A migration has successfully been reverted.

How do I hook in and listen for those events with my current Sequelize object and perform actions when the event happens?
Thanks

I'm afraid CLI doesn't support Umzug events right now. The only way is to directly listen Umzug instance:
const umzug = new Umzug(...);
umzug.on('migrating', (...) => { ... });

Thanks @jukkah for your response. I actually tried that by what I got in the umzug test file.
I think my problem was the file I placed it. I will try that now and get back to you on my progress.
Thank you.

@jukkah; I was not able to get it to work. I tried putting the script in the .sequlizerc and event in the migration file itself, but the event doesn't seem to be observed. I guess it's like you said, CLI doesn't support the Umzug events now.
Thanks for the help anyways.

There is an another hack! You can add code into up/down functions of migration file. So your migration files could look like this:
const listener = require('../my-listener-hack');

module.exports = {
  up(...) {
    // on migrating
    listener.doSomethingOnMigrating();

    // migrate your DB here

    // on migrated
    listener.doSomethingOnMigrated();
  },
  down(...) { ... }
};

Thank you @jukkah
Given the new version of CLI just returns a queryInterface method I couldn't do it exactly like that as anything after the return wouldn't execute.
However, since the returned methods are promises, I could chain a then method and pass my function to it. It then runs that function after migrating.
const updateSchema = require('../update_schema');

module.exports = {
  up: function (queryInterface, Sequelize) {
    return queryInterface.createTable('users', {
      // fields definition
    }, {
      underscored: true
    }).then(updateSchema);
  },
  down: function (queryInterface, Sequelize) {
    return queryInterface.dropTable('users').then(updateSchema);
  }
};

My only concern with this is that I will have to chain the .then(updateSchema) to any migration function I write. But it's the best solution I have so far.
Thanks again.

Yeah, this is an ugly hack but it's working. :sweat_smile:
I'm closing the issue for now. Reopen it or open a new issue if needed.


R.swift is now supporting localized strings

As the author of R.swift I wanted to give you a heads-up that R.swift is now supporting localized strings including stringsdicts!
Just so you know! :)

@mac-cain13
Thank you!
We will make this repository deprecated.


Features and Fixes Part 2

Closes #363
Closes #365
Closes #375
Blocking:

[x] https://github.com/Zeugma440/atldotnet/issues/235

@kissthermite
You can download and install the .flatpak file from the assets section on this CI build: https://github.com/NickvisionApps/Tagger/actions/runs/6601503583 to test the remembering of format strings and the sorting files by album with disc number while we wait for our backend's (atldotnet) developer to fix the flac file issue.
Just a note, the format string used for file name to tag will be remembered independently of that used by tag to file name.
Once you download and extract the .flatpak file from the assets, you can use these commands to install it:
#from the directory containing the .flatpak file
flatpak install org.nickvision.tagger-x64.flatpak
flatpak run org.nickvision.tagger//master

Once you've tested and are done with it (or you can keep using it until the next beta release) you can uninstall it with:
flatpak uninstall org.nickvision.tagger//master

Feel free to comment with any issues, comments, questions, or concerns :))

It does remember my custom format string even after closing Tagger. Such a nice QOL. Good job @nlogozzo!

Feel free to comment with any issues, comments, questions, or concerns :))

And album sorting now behave the way i expected too. Another job well done!

@kissthermite Glad everything works as expected :)
This build should contain the fix for PublishingDate and flac files: https://github.com/NickvisionApps/Tagger/actions/runs/6603980868
Once you confirm that works I will merge this PR and release RC1 and we should be all good for a stable release on Friday!

@kissthermite Glad everything works as expected :)
This build should contain the fix for PublishingDate and flac files: https://github.com/NickvisionApps/Tagger/actions/runs/6603980868
Once you confirm that works I will merge this PR and release RC1 and we should be all good for a stable release on Friday!

it's working! :rocket:

Yay!! I have to go to work now but once I get home later td I'll merge and do a release :)

Yay!! I have to go to work now but once I get home later td I'll merge and do a release :)

I just edited my comment in case you didn't see it.

I just realized that there's currently no way to remove Publishing Date tag?

That trash can button can be seen on Custom Properties
VORBIS-VENDOR would do nicely beside Pick a date/Date button

That trash can button can be seen on Custom Properties
VORBIS-VENDOR would do nicely beside Pick a date/Date button

Ah, good idea! Will implement that when I get home instead

That trash can button can be seen on Custom Properties
VORBIS-VENDOR would do nicely beside Pick a date/Date button

Ah, good idea! Will implement that when I get home instead

@kissthermite Ok, done! Use this build to test: https://github.com/NickvisionApps/Tagger/actions/runs/6605232433

I think we should take disc number to consideration everywhere where we compare track numbers: for sorting by artist, year and genre too.

Done in latest commit!

@nlogozzo  another job completed fantastically!

@kissthermite RC1 will come in a little bit.
Just be advised that configurations are kept independent of branches. Meaning flatpak beta and flatpak master will be different. So upon installing rc1, your format string won't be remembered until you use it for the first time on the version.

Just be advised that configurations are kept independent of branches. Meaning flatpak beta and flatpak master will be different. So upon installing rc1, your format string won't be remembered until you use it for the first time on the version.

Why is that? Flatpak data dir is always ~/.var/app/org.nickvision.tagger no matter the branch

Just be advised that configurations are kept independent of branches. Meaning flatpak beta and flatpak master will be different. So upon installing rc1, your format string won't be remembered until you use it for the first time on the version.

Why is that? Flatpak data dir is always ~/.var/app/org.nickvision.tagger no matter the branch

I could be wrong. I thought the whole branch was kept separate from each other. Guess it's just the binaries and the rest is shared.


Is it necessary to query account balance at any block number?

Conflux is a high-performance public chain, we are working on integrating with Rosetta. But we have encountered a problem that is Our chain default won’t save all historical states, which means only supporting query account balance in the latest blocks for example latest 5w blocks.
If one want query balance in any block height, the fullnode’s disk storage will be very very big maybe several hundred T
So if it is Ok for the query balance Data-API only support query balance at latest 5w blocks ?

I think this is a duplicate of https://community.rosetta-api.org/t/is-it-necessary-to-query-account-balance-at-any-block-number/651 - so closing this and we can discuss more there. Thanks


Publish install.yaml with releases

Proposal
It would be great to have the output of kustomize build ./config/default as a release asset.
Use-Case
This makes it easier to install the add-on without using Helm. Currently, users that don't use Helm either need to download multiple files from the repo and have the same directory structure to run Kustomize or have a script that uses the Helm CLI to download and build the chart and then patch the output to remove Helm-specific metadata.
Is this a feature you are interested in implementing yourself?
Yes
Anything else?
We can start doing this on v0.5.0. It has already been published, but we can upload assets anytime.

What do you think? @JorTurFer @tomkerkhove

I think that this is useful. In core we use something similar to bring the option of deploying with kubectl


Schema only changes for LMS who lives here

What is the context of this PR?
Duplicate who lives here for the no primary flow
Corrected routing rules
How to review
Does it work as per slides?

Just got into this state by adding 2 people and 1 student.  Not sure where the highlighted 'Person' is coming from

@insacuri probably here https://github.com/ONSdigital/eq-survey-runner/pull/1832/files#diff-c9e6b1b5985ae51160d65d915d321a01R685

@insacuri Relationship title has been fixed

squashy


All routes should be specified as 16-bit routes.

While trying out CSP 2.0, I noticed that one of my nodes that had a routing table didn't work anymore.
We would like to make the upgrade to CSP2.0 as painless as possible, however there is the challenge of having a routing table already defined.
With this change,
set csp_rtable '0/0 CAN0, 24/3 KISS, 29/5 TXS'
becomes
set csp_rtable '0/0 CAN0, 24/14 KISS, 29/16 TXS'
This route will then both work for CSP 2.0 and CSP 1.0. Otherwise the route would have to be specified in a different way for the two versions (in addition to some more code changes, if CSP1.0 compatibility with the old route definition was to be preserved).

Why is this better? It does not reuse the incoming packet for the response. And thus takes up two buffers instead of one.

csp_sendto_reply will modify the packet, thus the second transmission will be sent to ourselves (a reply to a reply).
This at least changes that so we don't do something that's completely wrong. Wasting one buffer allocation in the call, for something that's clearly debugging oriented and only meant to be run sparingly, seemed worth the extra cost of making it more "correct".

I don't understand the rationale for this. The idea of having backwards compatibility with CSP 1 is to not require an update of the node numbers and routing tables. This breaks that and is somewhat in between CSP 1 and 2.

Please try the CSP 1 compatibility mode with the masks and you'll see why this change matters.
I agree that it's not completely ideal, but otherwise we need to have dynamic calls to get the current netmask length everywhere.

I think your comments are valid - you can pick and choose the bug-fixes you need for upstream if needed.

Why is this better? It does not reuse the incoming packet for the response. And thus takes up two buffers instead of one.

csp_sendto_reply will modify the packet, thus the second transmission will be sent to ourselves (a reply to a reply).
This at least changes that so we don't do something that's completely wrong. Wasting one buffer allocation in the call, for something that's clearly debugging oriented and only meant to be run sparingly, seemed worth the extra cost of making it more "correct".

Okay. I see now. I just haven't come across any cases where sendto_reply is used more than once. Because multiple packets are typically not used as connectionless.

I don't understand the rationale for this. The idea of having backwards compatibility with CSP 1 is to not require an update of the node numbers and routing tables. This breaks that and is somewhat in between CSP 1 and 2.

Please try the CSP 1 compatibility mode with the masks and you'll see why this change matters.

I'm not sure I understand what you mean by "with the masks"? When CSP 1 is used the routing table must be given as it has always been given. With /5 signifying a single node.
With CSP 2 it must use extended mask, so now /14 signifies the single node.
We don't expect people will want to move dynamically between CSP versions, hence why compatibility with the old routing table format is preferred over, the flexibility of swapping protocol without routing table.

I agree that it's not completely ideal, but otherwise we need to have dynamic calls to get the current netmask length everywhere.

Yes. Dynamic call to get mask length. That's how I implemented it. Just a single function call. And it is only really used in the routing table parser. So nothing too harmful. So again, I believe we prefer to keep full backwards compatibility. I.e. if you upgrade to CSP 2.0 master, it just works as a CSP 1.6. untill you set the config.version = 2. (And provide a new routing table)


pathing issues in windows with node and babel

I have the following script:
gulp.task('babel', function () {
  return gulp.src('./src/**/*.js')
    .pipe(sourcemaps.init())
    .pipe(babel())
    .pipe(sourcemaps.write('.', {
      includeContent: false,
      sourceRoot: function(file) {
        var from = file.path;
        var to = path.resolve(path.join(__dirname,'..', 'src'));
        var dest = path.join(path.relative(from, to), 'src');
        console.log('from %s\nto: %s\ndest: %s\n', from, to, dest);
        return dest;
      }
    }))
    .pipe(gulp.dest('./dist'));
});

and the following directory structure:
\src\api\application\ApplicationController.js
\dist ===> where things are transpiled to

and then I build it paths things correctly. ( source root pathing is done for this http://stackoverflow.com/questions/29170589/debug-nodejs-es6-app-webstorm ).
My output looks like this in the transpiled file:
//# sourceMappingURL=ApplicationController.js.map

and then in the map file ( i shorten for lack of space ) this:
sources":["api/application/ApplicationController.js"]
"sourceRoot":"..\\..\\..\\src"

here we can note that the paths for the sources is wrong for windows, however, I noticed you are manually switching it back for some reason on windows. https://github.com/floridoo/gulp-sourcemaps/blob/master/index.js#L365
When I open something like node-debug, I can see the paths getting resolved incorrectly like so: http://www.screencast.com/t/8nWrqRSjMSM
Any ideas whats going on?

In case anyone else comes across this issue, the above function is returning the windows style path separators cause blink debugger to not be able to find them. Just replace
return dest;

with
return dest.split(path.sep).join('/');

and it works fine.

The result of this function call should be run through the unixStylePath helper.  If anyone wants to send a PR, feel free.


PG: Start render loop before creating scene

PR for playground to start the default render loop before calling the scene creation function, so that we can stop it and start a new one without having to use setTimeout() to wait for the default to be started.
Basically the current code to start the render loop is moved into a hidden public method which is called after creating the engine, right before calling the user function that creates the scene.
Forum discussion: https://forum.babylonjs.com/t/make-it-easier-to-stop-default-render-loop-on-playground/26749/2

Just making sure: can you test with the JS and the TS mode?

Yep I should have mentioned I tested it locally with JS and TS, using a simple animation, and it seems to be working well. :)


Copying content inside About dialog crashes the terminal

Environment
Windows build number: 10.0.18363.535
Windows Terminal version (if applicable): Both on 0.7.3451.0 and current master

Any other software?

Steps to reproduce
I'm trying to copy the version number inside About dialog.

Expected behavior
It works.

Actual behavior
The terminal freezeed and crashed.

Windows version 18363.720, Windows Terminal version 0.10.761.0, still have the same issue. The system language is traditional Chinese(Taiwan). Sometimes need to click 'Copy' multiple time to trigger the crash.

I really tried with this one. I set my system language to Chinese, installed 0.10.761.0 directly from our releases page, and copied the contents of the about dialog about 40 times.
I just can't reproduce this. 😦

Yeah I'm having a hard time trying to reproduce it on my other laptop with 0.10.761.0. Even if I could reproduce it when I first reported this issue, it crashed somewhere deep inside Windows.UI.Xaml. I think we should leave it here, to see if there's more people having this issue.

Wasn't there a race in .NET FX discovered just the last few months? I don't know if the fix has been pushed to GA yet, but a dev machine might have more up-to-date binaries. That could explain both the difficulties to repro, and that it's deep inside some obscure asynch code handling XAML.
Just an idea.

Just tried 0.10.781.0, still crashed on the first try. But after the first crash, I can copy the string normally without any crashes.
Faulting application name: WindowsTerminal.exe, version: 0.10.2003.18001, time stamp: 0x5e72d01a
Faulting module name: Windows.UI.Xaml.dll, version: 10.0.18362.657, time stamp: 0xda02d3eb
Exception code: 0xc000027b
Fault offset: 0x0000000000712ec0
Faulting process id: 0x28f4
Faulting application start time: 0x01d5feeabc103103
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_0.10.781.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Windows\System32\Windows.UI.Xaml.dll
Report Id: b0ce9b3d-1dd8-461a-80b6-931e84243c85
Faulting package full name: Microsoft.WindowsTerminal_0.10.781.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

I think this no longer happens to me since I first opened this. And no one really reports similar issues for a very long time. I'll just close this for now.


Bug: Column thickness and spacing changes depending on the data count

This is the preview I get from Jetpack Compose, you can see that the more the data displayed, the smaller the column is.

Expected behavior
Column thickness and spacing should be consistent regardless of how much data is displayed, if the data is too much to display in the screen, then it should be horizontally scrollable.
Code:
Chart(
    chart = columnChart(
        columns = listOf(
            LineComponent(context.getColor(R.color.primary), 1f, shape = pillShape),
            LineComponent(context.getColor(R.color.secondary), 1f, shape = pillShape),
        ),
        dataLabel = textComponent {
            typeface = Typeface.SANS_SERIF
            textAlign = Paint.Align.CENTER
            color = android.graphics.Color.WHITE
        },
        dataLabelVerticalPosition = VerticalPosition.Bottom,
        spacing = 4.dp,
        innerSpacing = 0.1.dp
    ),
    model = entryModelOf(frequencies, remainingStocks),
    startAxis = startAxis(
        label = axisLabelComponent(typeface = Typeface.SANS_SERIF, textSize = 10.sp, lineCount = 1),
        axis = null,
        tick = null,
        guideline = axisGuidelineComponent(shape = Shapes.rectShape, color = Color.LightGray.copy(alpha = .25f)),
        valueFormatter = DecimalFormatAxisValueFormatter("##")
    ),
    bottomAxis = bottomAxis(
        label = axisLabelComponent(typeface = Typeface.SANS_SERIF, textSize = 10.sp, lineCount = 1),
        guideline = null,
        tick = null,
        axis = null,
        valueFormatter = { value, _ -> labels[value.roundToInt()] }
    ),
)

To add more context, in the app I'm working on, the columns count is dynamic, it isn't fixed like January-December for example. It can be few or many, depending on the data sent by the API. That's why I want to make the column thickness static regardless of columns count.
Yes I'm agreed, I think we need parameter like in point 2.
And if I understand your first point right, shouldn't thicknessDp named minThicknessDp instead?

Thanks, that was fast. Hope it can be released soon!
IMO this is the best chart library for Android right now. Keep rocking! 🤓

Thanks for the kind words! We plan on releasing Vico 1.6.0 this week.

Hello! Vico 1.6.0, which is now rolling out, adds the feature in question. Thank you for the suggestion!

@Gowsky is 2.x version has merged this feature?

Hello, @asker517. Yes, this functionality is available in Vico 2, but the API differs. Please see here.


let RD teleporter work crossgrid

About the PR
title, lets the portals be on different grids
Why / Balance
more interaction variety and lets it be more useful, though will be used to make portals to/from grids such as ATS and evac, like it has been before, which i think is maybe fine? since you can only have the portals link one pair of places at once
should be merged if ATS being portalled to from cargo is fine
Media
tested, works
Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[ ] I have added media to this PR or it does not require an ingame showcase.

Changelog

:cl:

tweak: The hand teleporter may now have portals placed on differing grids.

Summary by CodeRabbit

New Features

Enhanced the Hand Teleporter's capabilities by allowing it to create portals across different grids.

It was removed specifically because portal from cargo to ATS isn't wanted.

It was removed specifically because portal from cargo to ATS isn't wanted.

what if it had a distance limit

if it has a distance limit that will never include the ATS it's useless for any other cross-grid teleporation it seems like really

if it has a distance limit that will never include the ATS it's useless for any other cross-grid teleporation it seems like really

i mean more so a distance limit that stops it from working, but when the grid is back in range you can use it again

Can't allow teleportation to ATS, one way or another. Perhaps teleportation between grids with station anchors is disallowed? Maybe only disallowed if both grids have station anchors? Though, that'd be easy to abuse. Perhaps soft/hard station anchors for that purpose?

make single lattice near ATS and place portal on it

Yeah, letting them TP to ATS is kinda OP.


Update 0112-path-sum.java

https://github.com/neetcode-gh/leetcode/pull/2510

File(s) Modified: 0001-two-sum.py, 0002-add-two-numbers.py, etc...
Language(s) Used: python, javascript, etc...
Submission URL: _https://leetcode.com/problems/[problem-name]/submissions/xxxxxxxxx/_

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

#2510

File(s) Modified: 0001-two-sum.py, 0002-add-two-numbers.py, etc...
Language(s) Used: python, javascript, etc...
Submission URL: https://leetcode.com/problems/[problem-name]/submissions/xxxxxxxxx/

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

Hey @Anukriti167
could you please update above PR details.


MaxTaskMem 0.0 KB allways

Hello there! thanks for the tool, looks promising. nice thing that it works on historical events data!
I tried that and got a 'Max memory which an executor could have taken =   0.0 KB'. and everywhere a 0.0 KB in the 'MaxTaskMem' column which is obviously wrong since the job ran and used some memory.
Other metrics look at least sane.
I wonder what can be the case?
My ultimate goal is to find out how much can I lower the memory footprint of a job and do not get OOM, this 'MaxTaskMem' field looks like a good fit for that, right?

Thanks @kretes for trying this out. We have seen this issue but never debugged it. I took a look. Looks like the JsonProtcol.scala, the main class responsible for converting events to JSON (which gets logged into event log files) is not handling the peak execution memory metric (part of TaskMetrics).  We can try to get this patched into open source, but that will take its own sweet time.
For now, the only useful way to get this value will be to run sparklens as part of your application. It is possible to configure sparklens to not do simulations. In this mode, it will save a sparklens output file (typically few MBs in size). You can use this output file just like event log history files and get the same out (with simulation) at any later point in time.
Thanks again for sharing your findings.

Thanks @iamrohit - it works when run together with the diagnosed job.
Still I wonder how should I interpret the MaxTaskMem.
In the code sparklens is doing such a thing:
val maxTaskMemory = sts.taskPeakMemoryUsage.take(executorCores.toInt).sum // this could
// be at different times?

And if it is a sum of that many peakMemoryUsages as many executorCores are there - then it is not a 'task' metric, as one task goes on one core, right?
I got the result of 16 GB in one stage, and given executor has that much memory - it is not available to a task, if a few of them are running concurrently on the same executor.

Hello!
Thanks for the thorough explanation.
I would then call this metric 'WorstCaseExecutorMemUsage'. And this is actually what I am looking for. Although in my case the worst case didn't happen at all since it was way more than executor memory.
I will be looking at the result of this metric in a few more jobs.
The feature you are describing sounds like a good thing to do! Looking forward to it!

@iamrohit - Would the calculation of maxMem in StageSkewAnalyzer.scala still be valid in case there are different (independent) stages which are executing in parallel.   Currently sparklens looks at stage level maxMemory and then finds global maximum - What if there are are 2 or more tasks belonging to different stages which get scheduled on the same executor.  In this case should we take sum of (vcore number of ) tasks with highest peakExecution memory?

You are right @anupamaggarwal. We should probably change the logic to account for parallel stages. What we have seen in practice is that this worst case is typically very unlikely and even if this occurs and executor goes out of memory, the execution typically proceeds as some of the tasks will go to other executors on retry. Feel free to raise PR.

I know this an old issue but are there any plans to fixing this?

I know this a very old issue, but are there any plans to fix this? This is an extremely useful metric to have.


AsyncCoroutineRunner is invoking DontDestroyOnLoad in editor mode

Describe the bug
When trying to deploy an app package within the build window by clicking on install, Unity throws the error
InvalidOperationException: The following game object is invoking the DontDestroyOnLoad method: AsyncCoroutineRunner. Notice that DontDestroyOnLoad can only be used in play mode and, as such, cannot be part of an editor script.
Deploying is therefore currently broken. The offending line is https://github.com/microsoft/MixedRealityToolkit-Unity/blob/mrtk_development/Assets/MixedRealityToolkit/Utilities/Async/Internal/AsyncCoroutineRunner.cs#L96
There has been a UNITY_EDITOR preprocessor around it, though it was removed in #5951 by @wiwei.
To reproduce
Steps to reproduce the behavior:

Open any MRTK project
Build an app package
Try to deploy it to a device using the Build Window Deploy Options tab

Your Setup (please complete the following information)

Unity 2019.1.14
MRTK 2.1.0

Target Platform (please complete the following information)

HoloLens

fixed via #6363


workarund fix for incorrect padding bits in bcrypt hashing

Fix #183
Use workaround described in https://github.com/ansible/ansible/issues/36129#issuecomment-660504404 to remove warning message when using password hashing.
/cc @SuperQ

Is there anything preventing this PR from being merged?

Is there anything preventing this PR from being merged?

Is there anything preventing this PR from being merged?


New version: Amazon.AWSCLI version 2.17.14

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

[Policy] Needs-Manual-Merge

https://github.com/microsoft/winget-pkgs/issues/142854


Enable use without trace: true

All modules run through the register handler of SystemJS, so it should be fully possible to make this work without having to set trace: true on SystemJS.
Basically System._loader.moduleRecords contains the SystemJS private tree which should contain the same information as System.loads I believe?
If it is lacking we can certainly look at adjusting this as the trace: true feature will be deprecated in the next release of SystemJS.

(by next release I mean the major deprecation release later this year)

ok, I will have a look at that.
Seems like rewriting those two lines should do it: https://github.com/capaj/systemjs-hot-reloader/search?utf8=✓&q=System.loads

Handling this in systemjs-hmr, although I don't think usage without trace is possible here


Advanced Vehicle Info App

Hi there,
I wanted to show a few values on the IDrive system that you're not able to see by default.
So i did some modifications (super quick and dirty!), mainly to the ReadoutApp, to get what i wanted.
This is the result:

Wouldn't it be nice to properly implement a screen like this? :)
My understanding of this whole project is sooooo bad so i guess i am not the right one to do this properly.
I mostly achieved my goal by copy+paste and trial+error ;)
But for any dev being more involved into this project it should be a easy task.
I also don't know about the graphical capabilities of the system. I simply used the RHMI list.
In theory the output of the screen could be configurable in the main app. (Which values and where to place them + update interval of the cds data)
Please let me know if i can help out any further.

nice! I also recall some similar concepts requests which i collect here below for any possible futher improvements!
https://github.com/BimmerGestalt/IDriveConnectAddons/issues/5
https://github.com/BimmerGestalt/AAIdrive/issues/175

That looks so good! Congrats on figuring it out without any help!
Your approach of using a List is the correct one. There aren't very strong graphical capabilities in the system, the closest being manually sending over PNGs to take the place of some of the table cells. It would also be possible to add an AM App Icon to the Car Information menu in the car, as another entry point besides the unlabeled entryButton in the OnlineServices menu.
Do you imagine it should stay in the Readout app? I was planning for such a detailed view to be a separate addon app, but that would add an extra unlabeled icon to the car. I also have been unsure of how to build the UI to configure the displayed data. A first version could simply show a static list, easily enough.
Would you like to contribute a Pull Request, or may I copy code from your branch and add some polish?

Very nice. I also tried to implement such feature but I wasn't able to. I would very appreciate it if it could get integrated into AAIDrive (or within a extra application).
Thank you

Any updates on this?

I've been busy with other projects and haven't had time to look into this.

@Katana1234 can you maybe describe how you achieved the menu in the screenshot? this would be enough for my needs.
If it's a self compiled APK maybe just share it here?

@ogakul I already posted all my code changes necessary to show this menu + my objections why not to use this code above ;-)

I've posted a test build for this feature branch, try it out!

Nice! I tested it and it seems to be working fine
Do you plan to add an icon and a title to the "app" in the idrive? or is it not much possible? I can see that the Mapbox navi doesn't have a title

0°C oil & 255°C battery seems a bit off :D  anyway I quickly tested it and it works, even if I have to test it more deeply in the next days and i'll let have my feedback on this

I had my car off, and that's what AAiDrive displays on the car info screen.
When on, I have the correct oil temp.
I am not sure about the Battery though. It is fixed at 255C no matter when. I also wonder how did I not fry inside :D

Thanks for the early feedback! In some places I have the code reject obvious bad data, I guess I need to add that for battery temp :)
I can't change the app icon, but I plan on adding a shortcut icon like the Notifications app.

Added an app icon to the Vehicle Info screen of the car:

thanks! this looks pretty cool, also that it's within the My Car menu!
I also noticed that you removed the battery temp info and added the Gear info.
One thing that remained in the interface was the gap (empty cell) where the Batt temp was.
Do you know what the HVAC temp is?

Great work @hufman . That's really nice.

thanks! this looks pretty cool, also that it's within the My Car menu! I also noticed that you removed the battery temp info and added the Gear info. One thing that remained in the interface was the gap (empty cell) where the Batt temp was.
Do you know what the HVAC temp is?

@HaivanJV HVAC stands for Heat Ventilation and Air Condition. This value represents the temperature of the heat exchanger and is more or less the temperature of the air comming out of the air vents. (I assume!)

@hufman Nice implemenatation! Thank you very much for taking your time on this! I also like your concept of having multiple categories :)
In theory the layout of the categories, rows and column could be configurable within the app. But i'm already super happy with this solution and everything that follows is just cosmetics!
Side note: The clutch value seems to be a state  instead of a percentage value. At least for my car with an automatic gearbox.
Values:
3 -> "Open / Idle?" -> This value is returned while gear P is engaged
2 -> "Uncoupled" -> This value is returned while a gear is engaged but the torque converter is uncoupled (when accellerating from standing still)
1 -> ??? -> not yet seen
0 -> "Coupled" -> This value is returned while a gear is engaged and the torque converter is coupled (typically while driving)

Thank you! I'm pleased with how it's shaping up, after I got over the motivational cliff to add a new data pipeline to the app :)
The Battery Temp only shows a value if it's lower than 255C. If nobody sees any valid data for this field, it's easy enough to remove.
I wasn't sure what the Clutch field would show, the CDS API just calls it clutchPedal.position, just like acceleratorPedal.position, so I guessed :) Similarly, the brakePedal in my car only goes from 10-25, somehow haha.

I guess battery temperature will only work for electric cars.
Maybe we can determine if a car is electric when engine.electricVehicleMode returns a value. just guessing... :)
And i guess clutchPedal.position works different between manual and automatic gearboxes. BMW engineers are traditionally reusing properties in different ways for different configurations :D
We can look into this in a later step. In theory we have the engine.info.gearboxType to determine what gearbox the car is equipped with. We'll probably have to compare some infos of different cars. but this is already too much for this GitHub issue :)

My Mini EV does have a battery temp there, it seems! I fixed a crash-on-disconnect I was seeing in analytics and merged it to the main branch, and will probably push it to the beta app store users after a week for translations to roll in.

@Katana1234  please experiment with the code and come up with more screens of data that you'd like to see :) I don't want to build a configuration system, but would accept ideas for how to organize the data into pre-built screens.

First of all, thank you for the great effort made to create this app, which allows us to obtain new features in our cars.
Would it be possible to add the following data point to CDSMetrics: driving.acceleration {longitudinal= , lateral= } ?
I don't know if I'm wrong, but I think they are the different forces exerted on the car, when accelerating, braking or taking a curve in (m/s²), if we divide this value by 9.81 we could obtain the different G forces and display them on the screen.
It's just an idea and I don't know if it's correct.
Thank you.

@hufman

@hufman Feel free to try my branch: https://github.com/Katana1234/AAIdrive/tree/car_info_data_selection

Very cool! I posted a branch with your Driving Details updates and the Windows screen. However, isn't the GPS information is already available elsewhere in the car, like in one of the side panels? I'm reluctant to add more work for the translators than necessary :) I'm considering hiding the Windows and maybe GPS behind the Advanced Settings toggle, and then I can justify not translating them.

@hufman Nice refactoring, thanks :) Yes the GPS info is kind of redundant, but you will not be able to see all of this infos in one place within the IDRIVE system. And the altitude is inaccessible in IDRIVE.
Did you take a look at my brake interpretations? The brake value is not a percentage value. It is a bit coded state:
https://github.com/Katana1234/AAIdrive/blob/bf259b1a284b956077e62676a21e53247b50505f/app/src/main/java/me/hufman/androidautoidrive/cds/CDSMetrics.kt#L201
I also added a interpretation for the clutch values, at least for automatic gearboxes. Otherwise the original number will be returned:
https://github.com/Katana1234/AAIdrive/blob/bf259b1a284b956077e62676a21e53247b50505f/app/src/main/java/me/hufman/androidautoidrive/cds/CDSMetrics.kt#L236

Yes I saw the brake and clutch values. I feel my car has more of a smooth gradient for brake values than a bitfield would indicate, so I didn't want to commit to that interpretation and thus the strings, if they were incorrect. I should display them as binary in my car to see how it looks. As a rough approximation I suppose those labels would be more useful than the current arbitrary number. My car is electric so I don't know how the values correlate to a gas car.

Feel free to try your brakeContact values here:
https://docs.google.com/spreadsheets/d/10FfyFMfW5VGKQGMyOlp4iCyeXoOleGbB5na0-ZFpMX8/edit?usp=sharing
This way you can validate my "interpratation" easily :)

Indeed, I see those values too, I'll code them up.

I updated my branch with these changes, what do you think? Any last ideas before I merge it to the main branch?

@hufman I didn't check the compiled version, but the values selected in the code looks good to me :)

dear @hufman , i tried this test branch. the only misreading I have to highlight is the sunroof one, since I do not have one :D

@berseker please try the latest build from the Readme, which should include a fix for your sunroof!

@hufman  now seems fine


After modifying Access List(s), NPM does not automatically update the configuration of the relevant Host(s)

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Notice: English is not my native language.

Describe the bug
After modifying or deleting Access List(s), NPM does not automatically update the configuration of the relevant Host(s).
Nginx Proxy Manager Version
2.9.19
To Reproduce

Add an Access List called acc_1 (Assume that the settings are correct.)
Modify a host called host_1, and change its Access List option to acc_1
Modify the setting options for acc_1 (e.g. username and password)
Visit host_1，Log in with the modified username and password.
You cannot log in with the modified username and password, but you can log in with the previous username and password.

Also, if you delete the Access List that has been used, although the web interface shows accessibility as PUBLIC, the actual accessing browser prompts "Untrusted Certificate" (The certificate is actually valid).
The current way to solve this problem manually is to edit the problematic host(s), do not change anything, and click Save
Expected behavior
After I modify or delete Access List(s), NPM should automatically update the configuration of the relevant host(s).
Operating System
Ubuntu 22.04.1 LTS (GNU/Linux 5.15.0-56-generic x86_64)

There's already an open issue for this. Check out #2254. It also includes a temporary fix

+1 to this. Editing (and saving) an Access List does not update the hosts that use it. This poses a security risk, as a system admin might falsely believe that updating the Access List applies the changes to all necessary hosts.
#2254 was an unrelated bug and has since been closed. The "workaround" is a PowerShell script that uses the API to update all hosts without making any changes. This is not a solution.


ScriptQuery mapping

See: https://github.com/elastic/elasticsearch-net/pull/1944
We currently map script query as a single unit but we need to move the inline, file and id properties under another script property of type ScriptBlock.
This ScriptBlock should be used under ScriptScoreFunction rather then the whole ScriptQuery

We have IScript which we use everywhere a script can be specified.  Can we use that instead?

:+1: good call, absolutely
-ScriptBlock
+IScript


Add unique name constraint in Team model

Fixes #103
This PR alters the Team model, by adding a constraint to the name field.
This purpose is to prevent the creation of two teams with different names.
Changes you made

Add "unqiue=True" on name field in Team model to prevent the creation of different teams with same name.
Add test for the mentioned above.

please add meaningful description

please add meaningful description

@mgold1234 Done.

@kobihk I'm not sure how to fix the issues you stated above.. the PR is already merged - should I create a new PR with the fixes?

@orzionpour yes please


fix: do not prevent touchend for clear button

Fixes #681

This change is

This should also probably validate on a clear button tap so it would behave the same on mobile and desktop. Currently, if you have a required date-picker, it doesn't get marked as invalid if you clear the field on mobile.

Confirmed the regression (can be reproduced in Chrome mobile device emulation).

desktop:validate() for clear button is called for empty string (correct)

mobile: validate() for clear button is called for old value (incorrect).

Will continue investigating where the actual problem is.


Replace difference and intersection from turf

Replace difference and intersection from turf with the new lib polygon-clipping. This lib is also used in the alpha version of turf but turf make problems ... so why not use the original source?
Fix: #630

I like replacing turf where possible.
Can you give a bit more info on:
Library size: how's the delta between the components we removed vs what we import now?
Functionality:
Anything we have to be aware of that the new library is missing or edge cases which are unsupported?

Library size:
https://bundlephobia.com/result?p=<EMAIL_ADDRESS>8.2kB
https://bundlephobia.com/result?p=<EMAIL_ADDRESS>6.8kB
replaced by
<EMAIL_ADDRESS>7.7kB
Functionality:
Only difference and intersection is replaced what currently only used in Draw.Cut. While testing by my self and with cypress no problems happen and I found no unsupported cases.
Also I tried #555 but this is still a issue.
Also a positiv fact is that the library is up-to-date. The latest realease is 8 days old.
https://github.com/mfogel/polygon-clipping


Connection previews don't flash when night vision is applied

Before reporting, I have confirmed that

[X] This bug does not appear to be reported on GitHub Issues before.
[X] This bug still exists in the latest version of the Minecraft Transit Railway mod.
[X] I have tested this in the official version of Minecraft Transit Railway, not a modified, custom, or unofficial build.

Describe the Bug
When connecting to rail nodes, the flashing of the connection preview doesn't happen when you have night vision.
https://github.com/user-attachments/assets/0df383b6-413a-42d2-9ad5-3fd2b2ef3b39
Reproduction Steps

Apply night vision to yourself
Try to connect two nodes with a connector

In-game Log and Crash Report
latest.log
Mod Loader
Fabric
Minecraft Version
1.20.4
Minecraft Transit Railway Version
4.0.0 beta 12
Operating System
Manjaro Linux 24.1.2
List of Mods or Modpack You Were Using

Architectury (https://modrinth.com/mod/lhGA9TYQ)
Athena (https://modrinth.com/mod/b1ZV3DIJ)
Axiom (https://modrinth.com/mod/N6n5dqoA)
BetterF3 (https://modrinth.com/mod/8shC1gFX)
Chipped (https://modrinth.com/mod/BAscRYKm)
Cloth Config v13 (https://modrinth.com/mod/9s6osm5g)
Continuity (https://modrinth.com/mod/1IjD5062)
CraterLib (https://modrinth.com/mod/Nn8Wasaq)
Fabric API (https://modrinth.com/mod/P7dR8mSH)
Indium (https://modrinth.com/mod/Orvt0mRa)
Iris (https://modrinth.com/mod/YL57xq9U)
Jade (https://modrinth.com/mod/nvQzSEkH)
Joban Client Mod (https://modrinth.com/mod/lQqKCDhg)
Lithium (https://modrinth.com/mod/gvQqBUqZ)
MTR London Underground Addon (https://modrinth.com/mod/jrAXj11W)
MTR Station Decoration Addon (https://modrinth.com/mod/station-decoration)
Minecraft Transit Railway (https://modrinth.com/mod/XKPAmI6u)
Mod Menu (https://modrinth.com/mod/mOgUt4GM)
Placeholder API (https://modrinth.com/mod/eXts2L7r)
ReFramed (https://modrinth.com/mod/jCpoCBpn)
Reese's Sodium Options (https://modrinth.com/mod/Bh37bMuy)
Resourceful Lib (https://modrinth.com/mod/G1hIVOrD)
Simple RPC (https://modrinth.com/mod/ObXSoyrn)
Simply Light (https://www.curseforge.com/projects/300331)
Sodium (https://modrinth.com/mod/AANobbMI)
Sodium Extra (https://modrinth.com/mod/PtjYWJkn)
Xaero's Minimap (https://modrinth.com/mod/1bokaNcj)
Xaero's World Map (https://modrinth.com/mod/NcUtCpym)

Extra Information
No response

not fully sure if this works on windows, it probably does

Should be fixed in the upcoming beta version!


training model

Hello,can this method be used in a model with a free anchor frame?

I didn't experiment with the free anchor frame. But I think you can try to change the mask from binary mask representation to PatchDCT representation.


Attribute (data-server-rendered="true") missing

I check the Live Demo, and I found
the dom of (id-#app) missed attribute data-server-rendered="true"
does it means hybrid failed ?

I have the same problem, the server output has the  attribute data-server-rendered="true", but after the client re render the attribute data-server-rendered="true" missed.

lol.. it does have, though what I guess is you are looking for it in the inspector window. rather you must see it in the view-source. :)

lol.. it does have, though what I guess is you are looking for it in the inspector window. rather you must see it in the view-source. :)

nm … did you mean I need check page raw network response and the element tree will remove the attribute after hybrid ?


updated gns3 (1.4.1)

Thank you for the contribution. It needed some fixes, so they were made in 2bc2f3d7b11859473d4c5fc5fd3805b419fa937f. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Document Azure Pipelines in ODP docs

We just added Azure pipelines to the list of CI services in ODP! We need to add docs to https://finosfoundation.atlassian.net/wiki/spaces/FDX/pages/75530342/Continuous+Integration
FINOS org on Azure is dev.azure.com/finosfoundation
When done, ask the Perspective team to review docs.

Just a mention, but it's being added - https://github.com/finos/open-developer-platform/commit/0eea5e9878cb5e0c11871cc32f9588920b51fbda


The client is closed error while using v4

Hey There!
I was trying to connect my Redis server with node-redis but can't reach the server. After a couple of searches on the internet, I tried to downgrade the version and it was solved. I just wondered that why I couldn't reach the server with the new version?
This is my code to connect to the server:
const client = redis.createClient({
  host: '<IP_ADDRESS>',
  port: 6379,
  enableOfflineQueue: false,
  retry_strategy(options) {
    if (options.error && options.error.code === 'ECONNREFUSED') {
      return new Error('The server refused the connection');
    }
    if (options.total_retry_time > 1000 * 60 * 60) {
      return new Error('Retry time exhausted');
    }
    if (options.times_connected > 10) {
      return undefined;
    }
    return Math.max(options.attempt * 100, 3000);
  },
});

Environment:

Node.js Version: 16.13.0
Redis Server Version: 5.0.7
Node Redis Version: 4.0.0
Platform: Ubuntu 18.04

@Fexyler I just encountered this today myself. It's not a bug but is instead how V4 works. You need to manually connect now after creating the client (using client.connect()) before running any redis commands.  Also, the config object is different now (most of the config options now go under socket and how you define reconnect strategy is also quite different.)
A large amount has changed between the versions so be prepared for a major refactor if upgrading!
Details and new docs here.

Okay I will check the document that you sent, thank you for your response!

@jayeclark Where would I input client.connect()? I am debugging someone else's software and it is not clear from the documentation.

@jayeclark Where would I input client.connect()? I am debugging someone else's software and it is not clear from the documentation.

right after where the client is declared.

I had the same error message when using redis as express-session store. It only happened when i used chrome.
The cause of the bug was because i disabled chrome web security (disable-web-security). Enabling it again fixed the problem.


WIP: dumps resources that do not have labels

This is a very naive solution to #160 that I'm using in the interim.  Probably too naive to be merged in, but could be useful for folks in the meantime.
Signed-off-by: Paul Czarkowski<EMAIL_ADDRESS>

Closing due to fix in #198


Loosing original type

Hello,
Thank you for the library, surprisingly i realized that each values are casted to String.
I don't know if it's intentional.
Example :
{
  "foo": {
    "bar": true
    "barz": 1234
}

Returns
{
  "foo.bar": "true"
  "foo.barz": "1234"
}

Instead of.
{
    "foo.bar": true
    "foo.barz": 1234
}

Not an issue anymore, i won't use this library.


Add "ASP.NET Core" to titles and H1's

For example, Model Binding should be "Model binding in ASP.NET Core".
Use SkyEye to start at the top, but update all articles.

Dup of https://github.com/aspnet/Docs/issues/5280
I was planning to do it this weekend, but I can drop that down to just dealing with descriptions if you want.

@guardrex  go for it.

@guardrex  not really a dup. This is a specific request from bill gates.

My issue plans to cover https://github.com/aspnet/Docs/issues/3278 ... isn't that the same thing?

Follow guidance in https://aka.ms/seo-for-writers-cheat-sheet

Not everyone working here has access to that. :trollface: :smile: It could be made part of https://docs.microsoft.com/style-guide/welcome/. The community can edit metadata.

Good idea. I'll get it out there. In the meantime, does your team need it to complete this task?

No ... I was half-kidding. I took a PDF of that prior to losing access to it, and the team has access. Rick will let me know if he wants to handle the titles, while I handle the descriptions; or he might close this and I'll work it through #3278 and #5280.

It was updated this Jan. 17. Please let me know if you need the newest version. :>)
Thanks for your work!

I may have an older version looking at the year. It says, "Updated: 17 January 2017."


Matmul substitution failed when conducting INT8 PTQ for DAMO-YOLO

Issue Type
Bug
Source
pip (model-compression-toolkit)
MCT Version
2.1.0
OS Platform and Distribution
No response
Python version
No response
Describe the issue
As I'm testing the DAMO-YOLO nano model can be deployed to IMX500, I download the onnx file for the DAMO-YOLO-Nm from the official GitHub repository and conduct MCT PTQ. But I've got an error as described in the title above. I'm guessing the issue is coming from a MatMul layer (<14196x8> <8x1> => <14196x1>). Can it be solved when I substitute the original matmul layer with another working the same as the original? Or Is there any way to fix the issue from the MCT itself?
Thank you for the time to read this request!
Expected behaviour
No response
Code to reproduce the issue
import model_compression_toolkit as mct
import tensorflow as tf
from get_calibration_data import representative_dataset_gen
model_path = "./saved_model/damoyolo_tinynasL18_Nm"

model = tf.keras.models.load_model(model_path+"_float32.h5", compile=False)

tpc = mct.get_target_platform_capabilities(
    fw_name="tensorflow",
    target_platform_name="imx500",
)

mp_config = mct.core.MixedPrecisionQuantizationConfig(num_of_images=5, use_hessian_based_scores=False)
config = mct.core.CoreConfig(mixed_precision_config=mp_config,
                             quantization_config=mct.core.QuantizationConfig(shift_negative_activation_correction=True))
# Define target Resource Utilization for mixed precision weights quantization (76% of 'standard' 8bits quantization)
resource_utilization_data = mct.core.keras_resource_utilization_data(model,
                                   representative_dataset_gen,
                                   config,
                                   target_platform_capabilities=tpc) <= error here

Log output
Exception: Matmul substitution failed: Unable to locate weight for node tf.linalg.matmul_1.

Hi @hglee98 ,
I see you downloaded an onnx file of the DAMO-YOLO nano model, but in the code you use an H5 keras file. Can you share the code for converting the model from ONNX to H5?

Hello @elad-c, Thank you for your reply!
I use onnx2tf==1.22.3 to convert onnx to H5.
You can download the library via this github repository.
https://github.com/PINTO0309/onnx2tf

Thanks,
Can you share your Keras and ONNX versions?

Here's the list of my setup as follows:
python=3.10.14
keras==2.14.0
onnx==1.15.0

Hi @hglee98 ,
Running the code below in an environment with the above versions didn't reproduce the error. There was no error in mct-nightly as well.
I converted the onnx file to keras like this:
onnx2tf -i "damoyolo_tinynasL18_Nm.onnx" --output_h5
Please note that using conversion tools such onnx2tf might generate unusual model graphs which in turn converts to sub-optimal models (e.g. representing swish activations as separate Sigmoid-Mul nodes, or consecutive reshape & transpose operations to handle the CHW to HWC conversion).
k_model = tf.keras.models.load_model("damoyolo_tinynasL18_Nm_float32.h5")

tpc = mct.get_target_platform_capabilities(fw_name="tensorflow", target_platform_name="imx500")

def rep_ds():
    for _ in range(5):
        yield np.random.random((1, 416, 416, 3)).astype(np.float32)

mp_config = mct.core.MixedPrecisionQuantizationConfig(num_of_images=5, use_hessian_based_scores=False)
config = mct.core.CoreConfig(mixed_precision_config=mp_config,
                             quantization_config=mct.core.QuantizationConfig(shift_negative_activation_correction=True))
# Define target Resource Utilization for mixed precision weights quantization (76% of 'standard' 8bits quantization)
resource_utilization_data = mct.core.keras_resource_utilization_data(k_model,
                                   rep_ds,
                                   config,
                                   target_platform_capabilities=tpc)

Environment creation in colab:
!pip install -q tensorflow==2.14
!pip install -q model-compression-toolkit==2.1.0
!pip install -q onnx==1.15.0
!pip install -q onnx-graphsurgeon
!pip install -q sng4onnx
!pip install -q onnx2tf==1.22.3

Thank you for investigating this issue. I appreciate your thorough review. As the problem doesn't seem to be replicable on your end, I'll conduct further investigations in my own environment using the install command that you suggest. I'll close this issue for now, and Thank you again for your time and assistance👍


Slow speed when installing large apk.

My project is pretty large so it takes me too much time to build or install, besides, sometimes it can't be installed to my phone with the ERROR INSTALL_FAILED_INVALID_APK;
Is there any ways of improving the speed of installing large apk to my phone?
p.s Computer Info: 8GB RAM, 5400HDD, x86 64 Windows 7,
phone: nexus 5 android 5.1.1; HUAWEI MATE 7;

I'm sorry @Cold-Snake but this plugin is using the Android Debug Bridge to start the WiFi connection and all the problems related to the performance or the apk installation can't be fixed changing the code of this project.

@pedrovgs
Thanks a lot, I'll do it as you say.


Add copy button to toast with error

Motivation
Sometimes the error is too big to be readable inside a toast. We should add a copy button
Usage example

Possible implementations
No response

I would like to contribute to this issue. I understand the relevant changes needed and will work on them.


High memory consumption

What is the expected memory overhead of adding this library to code? For 5 metrics in noticed it added ~180mb , that sounds a tad ludicrous.

That sounds like you're doing something odd.
It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

Added a query here https://groups.google.com/forum/#!topic/prometheus-users/4tEEJt4YLdA


deprecated NumberEntity features

Hi,
Not an issue for me, but after HA update today with 2022.09 version, saw this in the log 👍
2022-09-12 17:36:15.053 WARNING (MainThread) [homeassistant.components.number] Entity number.yeelink_ceiling4_3dd8_off_delay_time (<class 'custom_components.xiaomi_miot.number.MiotNumberSubEntity'>) is using deprecated NumberEntity features which will be unsupported from Home Assistant Core 2022.10, please report it to the custom integration author.
please report it to the custom integration author. : Done
Have a nice day, and thank again for this integration !!

Fixing it will not be compatible with older versions of HA core, so I will fix it after the next release.


[KYUUBI #5546][AUTHZ] Reorgnize the package names for rules

Why are the changes needed?
To close #5546
Refactor the code path of authz

Rule is not specify for ranger, extract to a independent path rule
Collect each. rule's class together
Move RangerConfigProvider to ranger package

The output is

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

We're currently processing your upload.  This comment will be updated when the results are available.

Merged to master


docs: bdd_integration.rst page

ON INSPECTION (reading the page):
First example for behave w/ hooks does not look correct to me (import-statement), like: toolium_before_all() function should be unknown because it is imported as before_all (and internally overwritten by the environment function).
HINT:
Behave fixtures should also make the setup/teardown hooks easier to use.

The example works, before_all() from toolium lib is imported as toolium_before_all() and then called inside the before_all()of the user test project.
Anyway, I'll take a look at behave fixtures to use them in toolium initialization.
Thanks!


Doesn't run after PR is merged

Hey there! I'm new to GitHub actions, so if this is incorrect at all, I apologize!
Here's the issue I'm seeing. I've got a repo that I'd like to use this with. We have a large team working on this project and many people are leaving stale branches around. Anyhow, I went ahead and created a GitHub workflow as defined below (using the new yaml syntax):
name: Delete PR Branches on Merge

on: pull_request
jobs:
  cleanup:
    name: Cleanup
    runs-on: ubuntu-latest

    steps:
    - uses: jessfraz/branch-cleanup-action@master
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        NO_BRANCH_DELETED_EXIT_CODE: 0

When I open a new pull request on this repo, this workflow runs and exits without doing anything (since the PR hasn't been merged).
When I merge the PR, however, this workflow doesn't run because it's only running on pull_request, and GitHub doesn't consider a merged PR to be a pull_request event, apparently. I wonder if this behavior has changed since this was first built?
Anyhow: I can't seem to find a way to get this to run. Am I way off, or did GitHub change the way that the pull_request event works?

I think this is still a valid issue, but I just realized that GitHub has this functionality built-in by default now!
Sorry for the trouble. If anyone else stumbles across this like I did, this may be of use: https://help.github.com/en/articles/managing-the-automatic-deletion-of-branches


fix(errors): solve CloudWatch, KMS, EMR and OpenSearch service errors

Description
Solve the following errors:
CloudWatch

ap-south-1 -- KeyError[49]: 'Namespace'

Lambda

ap-southeast-1 -- ValidationError[60]: 1 validation error for Function
runtime
  none is not an allowed value (type=type_error.none.not_allowed)

EMR

ap-northeast-1 -- ValidationError[83]: 1 validation error for Node
additional_security_groups_id
  none is not an allowed value (type=type_error.none.not_allowed)

KMS

ap-southeast-1 -- TypeError:71 -- argument of type 'NoneType' is not iterable

VPC

us-east-1 -- KeyError[98]: 'VPCOptions'

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Do we need to change the checks using this code?
What if a namespace or the VPCOptions is nil?

Those checks can handle Null values in that attributes.

Cool!


dev: use local kakarot-ssj instead of remote release from archived repo

With the introduction of modexp and ecpairing, we need to stop using the old remote repo and start using the local version of kakarot-ssj
Changes since the version we're using right now:

modexp
ecpairing
some optimisation changes discussed internally

Once done

[ ] enable modexp as external_precompile
[ ] enable ecpairing as external_precompile

@enitrat is this open for contribution

No, can you stop spamming please?

Unplanned: the deployments will keep using the audited code in kakarot-ssj repo.