Architectural/legacy compatibility decisions

I’m opening this issue to summarize the major changes between linter-eslint and this package, and to decide what else is worth changing.
Some of the changes are necessary because of the new architecture; some of them are just opportunities to shed support for legacy stuff. I feel like there’s a better sense of project hygiene these days, such that someone who is using a very recent version of ESLint probably doesn’t need some of the oddball config options that linter-eslint offered.
But then my use cases for linter-eslint were pretty bog-standard, so I’ll have to lean on others’ experiences here.
(Before reading below, make sure you’ve read the README and understand why this package exists distinct from linter-eslint.)
Architectural changes
I began with @scagood's work in this gist, then made changes as follows:

Worker script runs in the user’s own version of Node. The README specifies the several ways that this can be set. Out of the box this is just node, and in simple cases (no NVM, node installed in common places) will probably do the right thing without further configuration.

Main package and worker pass messages back-and-forth over stdout/stdin. Both use ndjson to properly chunk messages instead of relying on @scagood’s jsonChunks helper — which worked surprisingly well for how terse it is, but failed sometimes when especially large JSON payloads were being sent. A few dependencies, but this is a pure JS package and feels safe to use in an arbitrary Node environment. If it isn’t, we can figure out what to replace it with.

With newline-delimited JSON, PromiseQueue is no longer needed as a way of enforcing one-JSON-chunk-at-a-time behavior. I switched to the system linter-eslint uses: give each job a random ten-character hex string as a unique identifier.

All configuration lookups now go through Config instead of atom.config.get. Config is what handles the layering of .linter-eslint files atop atom.config.get so that package options can be specified either way. Config has its own get method for lookups and an onDidChangeConfig method for subscribing to changes.

The NodePathTester object is what handles the sanity-checking of a value that the user gives us for nodeBin. The goal is to check the value whenever nodeBin changes just to guard against typos and whatnot. If $nodeBin --version is successful, we assume it’s a valid Node; if not, we show a message to the user so they can correct it.
I was worried that the value of nodeBin that this package sees could change at least once during startup as “patches” are overlaid on the core config — first by project-config or atomic-management (if one is installed), then by our own application of .linter-eslint as a project-specific override.
But Config.initialize, our first action upon activation, happens synchronously, so anything present in .linter-eslint will be available from the get-go. Also, I imagine the late activation hook (core:loaded-shell-environment) saves us from any other startup turmoil.

I haven’t tested any of this on Windows yet. I have a Windows machine I could try it on, but I haven’t ever had occasion to set up a Node environment in Windows, so someone who’s well-versed in that would probably be better at identifying areas of improvement there.

You’ll see a lot of console.log and its siblings in here. The module exported by console.js shadows the default console methods and will skip actual logging unless the package is run in dev mode. I’m not saying that all those statements will stay in for a release, but the logging has been quite helpful in this pre-v1 phase as I’ve moved large parts of this thing around, so I’m in no hurry to take it out.

Things I’ve done so far

Integrate new information into the “Debug” command

The expanded path to the version of node we’re using
The version of node we’re using
Which linter (linter-eslint or linter-eslint-node or neither) would handle the linting in this project (see below)

Detect incompatible versions of ESLint

Logic: If the worker detects an ESLint version < 7.0.0, we’ll show a warning message once per session if linter-eslint is not installed. This message can be disabled in the settings.
The warning message includes an “Install linter-eslint” button; ideally this would happen with the same workflow as atom-package-deps, but there’s no provision for “optional” dependencies that I can tell, and no way to “borrow” its UI for my use case. So the button just opens up https://atom.io/packages/linter-eslint in the user’s browser.

Defer to linter-eslint if present for v7.x ESLint

Both versions can theoretically lint with ESLint v7. If both are present, linter-eslint-node will let linter-eslint handle v7 projects. If only linter-eslint-node is present, it will handle v7 projects.

Things I haven’t done yet and am not certain are worth doing

Fall back to package’s own version of ESLint?

This is a fine idea and something linter-eslint does, so I’m sure this will happen, but I’m fuzzy on the details. By default, linter-eslint wouldn’t lint unless an .eslintrc is found, so how common is it for someone to have an .eslintrc defined but no local ESLint module?

Integrate consistent-path?

The current package relies on consistent-path as a heuristic for finding the global ESLint install. We could use it to help find Node itself if the user hasn’t specified nodeBin, but the package is read-only and hasn’t been touched in six years.
For users who have told us exactly where their Node is, we’d be unnecessarily starting a shell session, including evaluating anything in their .bashrc or .zshrc or whatever.
For those who haven’t, it feels like a lot of work to do to guess a value they could honestly just tell us.
I haven’t decided if it’s better to have a robust heuristic here, or if it just complicates our “simply tell us where your Node is” guidance.

Tests
I wanted to pin down the architecture before porting over the specs, but I swear that’s on my agenda.
Options I’ve migrated

Fix on save

Disable when no .eslintrc

Ignore certain rules while typing

Logic: if the document is dirty, the worker will filter out any violations whose rule ID is present here

Ignore fixable rules while typing

Logic: if the document is dirty, the worker will filter out any violations with a fix property

Disable certain rules from auto-fixing

Easy enough by passing a function to the ESLint construtor (fix: () => {})

Options I’ve added

Path to Node binary (the big important one)

Warn about old ESLint versions

When enabled, shows a message once per session when this package can’t use the included ESLint

Options I think should be removed

Use global ESLint — bring-your-own-node means that the worker script ought to handle this properly, I hope? (check workingDir algorithm)

Global node path: again, presence of nodeBin makes this unnecessary

Options I’m on the fence about

Lint HTML files

The core logic is there (if enabled, an extra scope goes into the “scopes” setting) but I haven’t tested if this works. Feel like this could be rolled into the scopes setting.

Use custom .eslintrc path

No obvious way I see to tell ESLint class to look in a different location for .eslintrc, so I think we’d have to read in this path and bundle it into the options passed into the ESLint constructor. Plus be sure to clear the cache when this file changes. This would be a lot of work for an obscure use case.

Disable caching — so far I’ve not had a need to micromanage caching the way that linter-eslint has. Maybe this could control whether we cache ESLint instances in the worker script at all?

Local node_modules path — I’ve got a code path for this, but haven’t tested it yet. In theory, this will work; but, again, is this a common use case?

This is awesome!! :100: Thank you for doing this.
As far as the options goes I think it is best to only add options that are needed by users. If no one requests an option I don't see any reason to add it. The ones you have migrated look like a good start.
Once we get the tests migrated (at least some of them) I can setup semantic release to automatically release the package.

Thank you @savetheclocktower for converting my quickly thrown together gist into something that is much more sturdy! And thank you @UziTech for facilitating this :)

@savetheclocktower let me know when you think this is ready for release and I can setup semantic-release to release the first version.
 If you have any questions about that feel free to ask.

I think I'll have it ready in a few more days. A few of the tests are not worth keeping, but it's still worth getting the rest to work.

@UziTech If you're set up to test on Windows, I think we'll be ready for a release if you can manually check the stuff described in #7, particularly the “Testing behavior with various ESLint versions” stuff. If you can't, let me know, and I'll see if I can do it this weekend.


HSEARCH-3731 Upgrade to Hibernate ORM 5.3.13.Final

https://hibernate.atlassian.net/browse/HSEARCH-3731

The CI build passed: merging.


Add PSP Initiatives

Is this ready to be merged?

Is this ready to be merged?

We do not want to merge this PR. I will close the pull request.


Separating database reads and writes

Can mautic separate database reads and writes to utilize read replicas? Thank you.

Closing as this is not an issue relating to the documentation. Please post on https://forum.mautic.org if you have general questions about Mautic.


Implement Python #0007: Python Dependencies

[ ] cpython
[ ] poetry
[ ] pip
[ ] pipenv

RFC is here

I believe this has been fully implemented now:
https://github.com/paketo-buildpacks/cpython/issues/393
https://github.com/paketo-buildpacks/poetry/issues/74
https://github.com/paketo-buildpacks/pipenv/issues/235
https://github.com/paketo-buildpacks/pip/issues/289


restructure DDBRelayConfigClient so it may be reused by logging feature

Waiting on: https://github.com/armPelionEdge/maestro/pull/95

No longer waiting on #95 due to #95 not being ready for dev yet


news update

Why are these changes needed?
News update.
Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e50d5a1) 39.21% compared to head (913e661) 39.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
- Coverage   39.21%   39.11%   -0.10%
==========================================
  Files          57       57
  Lines        6082     6082
  Branches     1363     1363
==========================================
- Hits         2385     2379       -6
- Misses       3502     3508       +6
  Partials      195      195

Flag
Coverage Δ

unittests
39.11% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RDP wrapper fully support but not listening on 10.0.19041.4474

I've already done everything so that the listening is green, and I changed it .ini and much more, nothing helps please help

Try this: https://t.me/rdpwrap/76956

No response in a week, considering resolved.


lessc compile error "Cannot call method 'charAt' of undefined"

Hi,
When trying to compile bootstrap via lessc, i found out this very strange behavior.
When i'm compiling within bootstrap's directory, everything works fine:
$ cd bootstrap && lessc bootstrap.less

But when i go up one folder, it looks like
$ cd ../ && lessc bootstrap/bootstrap.less
TypeError: Cannot call method 'charAt' of undefined
    at getLocation (/usr/lib/node_modules/less/lib/less/parser.js:204:34)
    at new LessError (/usr/lib/node_modules/less/lib/less/parser.js:213:19)
    at Object.toCSS (/usr/lib/node_modules/less/lib/less/parser.js:379:31)
    at /usr/lib/node_modules/less/bin/lessc:103:28
    at /usr/lib/node_modules/less/lib/less/parser.js:428:40
    at /usr/lib/node_modules/less/lib/less/parser.js:94:48
    at /usr/lib/node_modules/less/lib/less/index.js:113:15
    at Object.parse (/usr/lib/node_modules/less/lib/less/parser.js:430:17)
    at /usr/lib/node_modules/less/lib/less/index.js:112:14
    at [object Object].<anonymous> (fs.js:107:5)

Why i need this? I've included bootstrap to my project via @import. This inclusion file is one dir above bootstrap.less. So when i'm compiling my inclusion file, it gives me the very same error.
Additional:
$ lessc -v
lessc 1.2.1 (LESS Compiler) [JavaScript]
$ uname -a
Linux gamboo.at 2.6.32-4-pve #1 SMP Mon May 9 12:59:57 CEST 2011 x86_64 GNU/Linux

I hope someone can reproduce this error.
Some additional information:

I'm running debian
Inclusion via browser works great
Stable v1.4.0 in the same procedure also works great

And another intressing part:
When cd-ing to bootstrap/ and building via lessc ../include.less everything works fine :D

i don't think this is a bootstrap bug  - could you open this issue in the less.js repo - thanks!


Support GRANT .. ON SCHEMA .. in Babelfish

Description
Support GRANT/REVOKE .. ON SCHEMA .. in Babelfish
PLEASE NOTE: This change is with the assumption that we are going to restrict function overloading. Based on any other  decision made otherwise, the catalog implementation would be extended to store the arguments in another PR.

Supported syntax GRANT <permission> ON SCHEMA::<schema_name> TO <user_name>
Supported syntax REVOKE <permission> ON SCHEMA::<schema_name> FROM <user_name>
Added one SQL statement PLTSQL_STMT_GRANTSCHEMA to store relevant information to execute GRANT/REVOKE .. ON SCHEMA .. statements.
Created one catalog table sys.babelfish_schema_permissions to hold the details for each GRANT/REVOKE statements.
GRANT on schema/objects adds a row in the catalog table if not exists already.
REVOKE on schema/objects removes the corresponding row in the catalog table if it exists already.
REVOKE on schema internally grants permission to all the objects if there are explicit permissions granted to the objects belonging to the same schema.
GRANT ALL on objects work as it is and add rows in the catalog for each relevant permission depending on the object type.
REVOKE ALL on object should do nothing, if the relevant schema permission exists in the catalog. But, it should remove the rows from the catalog if the object level permission is granted.
Drop statement for OBJECT/SCHEMA removes all the relevant object entries from the catalog.

Issues Resolved
Task: BABEL-4344
Signed-off-by: Shalini Lohia<EMAIL_ADDRESS>Test Scenarios Covered

Use case based - Yes

Boundary conditions - N/A

Arbitrary inputs - N/A

Negative test cases - Yes

Minor version upgrade tests - N/A

Major version upgrade tests - N/A

Performance tests - N/A

Tooling impact - N/A

Client tests - N/A

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-36 of 675 (94.67%)  changed or added relevant lines in 9 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.3%) to 72.302%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contrib/babelfishpg_tsql/src/pl_handler.c
99
100
99.0%

contrib/babelfishpg_tsql/src/catalog.c
248
250
99.2%

contrib/babelfishpg_tsql/src/pl_exec-2.c
59
66
89.39%

contrib/babelfishpg_tsql/src/pltsql_utils.c
83
91
91.21%

contrib/babelfishpg_tsql/src/tsqlIface.cpp
132
150
88.0%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tsql/src/catalog.c
1
85.28%

contrib/babelfishpg_tsql/src/pltsql_utils.c
1
90.05%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
40733

Relevant Lines:
56337

💛  - Coveralls


Add functionality to refresh the navigator when route state is changed or some other overriding feature

Sometimes it is necessary to refresh the current route which has the same location (see issue #512). I tried your suggestion but it did not work for me because method _runGuards returns true for a BeamGuard which returns a specific BeamLocation and method update is exits before it calls notifyListeners.
I investigated the method apply of BeamGuad and it always returns true if
if( redirectionBeamLocation.state.routeInformaiton.location
  != target.state.routeInformation.location) {
  return true;
}

It would be good if this condition is also include routeInformation.state check. Or maybe some parameter of BeamGuard with signature bool Function(context,origin,target) which can be used in above mentioned condition.

@bambinoua Indeed, it should also check RouteInformation.state

We have a problem with including a state check because you cannot really define the state if using BeamGuard.beamToNamed. This will be reworked as a part of v2 which will focus on guards.


Update KRaft SCRAM user creation to support secrets protection (master)

Description
Support KRaft SCRAM user creation when confluent secrets are enabled
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Manually tested
Checklist:

[x] Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
[ ] I have added tests that prove my fix is effective or that my feature works
[x] If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Closing in favor of https://github.com/confluentinc/cp-ansible/pull/1855 (PR from fork rather than different branch on confluentinc/cp-ansible)


Update profile picture from OAuth provider every time a user logs in

Currently we fetch the profile picture once on registration and then it does not change.
This should be done every time a user logs in, so changes in profile picture are reflected on our end.
Question: Should we allow people to opt-out of using the profile picture from the OAuth provider and instead use a different one or none?

I would keep it simple at the moment and just always use the given picture.
But we should also update all other information as email and name if it has changed.


Don't delete authconfig property

I've spent quite some time that the passed in auth object for docker.pull gets changed. In specific here the authconfig property gets deleted. I guess the best way would be to either not delete it or clone the passed in opts object to avoid situations like this.

Yeah authconfig it's messy in pull, to say the least, it will be refactored on next version.
Will ping later

Just refactored docker.pull
Give it a try from the master branch.
Will ping as soon as it is published.

Published on v2.1.3


OSError on while adding concise_concepts to spacy nlp pipeline

Hi Team,
I am getting below issue while adding concise_concepts to spacy nlp pipeline in the latest version
nlp.add_pipe("concise_concepts", config={"data" : prints_data})
2022-10-11 16:25:18.181 ISTextract_expertreports_printsdu74r1dm4mrf ERROR:root:Traceback (most recent call last): File "/workspace/main.py", line 12, in wrapper response = wrapped_func(*args, **kwargs) File "/workspace/main.py", line 43, in extract_expertreports_prints output_result = extract_prints(year) File "/workspace/extractprints_frompdf.py", line 65, in extract_prints nlp.add_pipe("concise_concepts", config={"data" : prints_data}) File "/layers/google.python.pip/pip/lib/python3.8/site-packages/spacy/language.py", line 792, in add_pipe pipe_component = self.create_pipe( File "/layers/google.python.pip/pip/lib/python3.8/site-packages/spacy/language.py", line 674, in create_pipe resolved = registry.resolve(cfg, validate=validate) File "/layers/google.python.pip/pip/lib/python3.8/site-packages/thinc/config.py", line 746, in resolve resolved, _ = cls._make( File "/layers/google.python.pip/pip/lib/python3.8/site-packages/thinc/config.py", line 795, in _make filled, _, resolved = cls._fill( File "/layers/google.python.pip/pip/lib/python3.8/site-packages/thinc/config.py", line 867, in _fill getter_result = getter(*args, **kwargs) File "/layers/google.python.pip/pip/lib/python3.8/site-packages/concise_concepts/__init__.py", line 51, in make_concise_concepts return Conceptualizer( File "/layers/google.python.pip/pip/lib/python3.8/site-packages/concise_concepts/conceptualizer/Conceptualizer.py", line 101, in __init__ self.run() File "/layers/google.python.pip/pip/lib/python3.8/site-packages/concise_concepts/conceptualizer/Conceptualizer.py", line 117, in run self.create_conceptual_patterns() File "/layers/google.python.pip/pip/lib/python3.8/site-packages/concise_concepts/conceptualizer/Conceptualizer.py", line 409, in create_conceptual_patterns with open(self.json_path, "w") as f: OSError: [Errno 30] Read-only file system: './matching_patterns.json```

Are you able to run the simple example given in documentation?


Remove uses of std::process::exit

Problem
std::process::exit prevents drops from running which has the potential to be problematic for e.g. open files or other IO relying on being closed cleanly.
Solution
Remove each use of std::process::exit, instead percolating the error up to nargo's main function and returning an error there.
Additional context
The nargo test PR brings us a bit closer in percolating up errors more to be caught by testing, but also adds more std::process::exit instances in doing so.

This is also important for things that get compiled to wasm, as std::process::exit causes a force exit in all WASI runtimes and breaks a lot of tooling (I had to deal with this in Circom).

Assigning this to @Ethan-000


New package: SpectralStatistics v0.1.0

Registering package: SpectralStatistics
Repository: https://github.com/clozej/SpectralStatistics.jl
Created by: @clozej
Version: v0.1.0
Commit: 786aa1af4d720f1abaac164295e7644cf30bf97d
Reviewed by: @clozej
Reference: https://github.com/clozej/SpectralStatistics.jl/issues/18#issuecomment-1819102868
Description: Numerical package for the computation and analysis of spectra and eigenvectors of quantum systems

Can you add a link to your package's docs to the README.md file? That helps potential users to discover its features.

Can you add a link to your package's docs to the README.md file? That helps potential users to discover its features.

There is a link to the package's docs in the readme in the Introduction section:

See the documentation here for a description of all the exported types and functions.

[noblock]
Sorry for my comment, I somehow missed that.

[noblock]
You are still blocking this PR with https://github.com/JuliaRegistries/General/pull/95301#issuecomment-1814011909 @clozej


Handle inability to contact metrics server on forwarding

Explain your changes:

Handle an error of contacting a metrics server requested by forward URI

Explain how you tested your changes:

Testing to be done

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? List them

Closes #14432

!ci-build-me

!approved-for-mainnet

!approved-for-mainnet

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

@approved-for-mainnet

!approved-for-mainnet


Support per port traffic target policies for a destination

Please describe the Improvement and/or Feature Request

Does OSM support multiple end-points of a service ?
Let us say if we have 2 endpoints in a service. Say Service(Account) A uses port 8080 and 8081.
In SMI TrafficTarget spec, we want to list two different destination specs one for each end-point.
Rules and Sources for each destination are different.
Is this currently supported ? If not, is it planned ?
Scope (please mark with X where applicable)

New Functionality          [ ]
Install                    [ ]
SMI Traffic Access Policy  [X ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ X]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]
Project Release            [ ]

Possible use cases

Hi Shashank,
Pleased to hear that you are working on this issue and we need it badly. We really appreciate it.
When do you think this will be available ?
Would this be available for both permissive and non-permissive modes ?
Once it is implemented, how would the access policy look like ?
Is it same as mentioned by SanyaKochhar (I guess that is inline with SMI spec) OR different ?

This issue should be resolved as a part of the effort to consolidate routes per service port. Multiple ports on a service do not share the same route configuration anymore. This change should be available as a part of release v1.0.0.


feat: Update dependencies to patch reported vulnerabilities and update ArgoCD default version

Description

Update dependencies and rebuild action dist to patch reported vulnerabilities
Update default version of ArgoCD to 2.4.7

Motivation and Context

Patch reported vulnerabilities
Keep default version of ArgoCD current

How Has This Been Tested?

CI checks

Screenshots (if appropriate):

:tada: This PR is included in version 1.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fixes repo url parsing

The logic was resulting in <username>/c instead of username/chaos.
Corrected it.

Thanks!! I thought I was the only one with this problem!

Thanx for confirming, @J0hn-
I wonder why it was there in the first place, but then its chaos! 😄

@tarunbatra

I wonder why it was there in the first place

If you look at the comments just a few lines above your changes, you'll see this:
# remote is one of these:
#  git@github.com:amoffat/chaos.git
#  https://github.com/chaosbot/chaos.git

So the last four characters are being chopped off to get rid of the ".git". That part of the remote address isn't necessary, but it is how GitHub presents the URL:

See also: Chesterton's fence
👎 Because, as is, this will break Chaos since the result of this function is used in (pretty much?) every API request. I'll remove my downvote if you update this to deal with both the case where the ".git" is at the end and the case where it isn't.

👍 Thanks for addressing that issue.

Hi @reddraggone9 I fixed the issue in a way it will work for both of the cases. Thanx for pointing it out! :)


Extensions viewlet always searches for @workspaceUnsupported after reload

Testing https://github.com/microsoft/vscode/issues/124984

duplicate https://github.com/microsoft/vscode/issues/125047


Support jdk11

We have been supporting local managed DNS service using a system property.
but this feature was removed at jdk9.
The new feature jdk.net.hosts.file doesn't meet our needs and requires lots of source code changes.
so, I set up our NameService using reflection.

Thank you for your hard work.


LeftHandDrive returns Right hand drive

Currently Left hand drive is implemented like this:
        public bool LeftHandDrive =>
            Singleton<SimulationManager>.instance.m_metaData.m_invertTraffic
            == SimulationMetaData.MetaBool.True;

I suppose who ever wrote this confused left hand drive with left hand traffic.
I suggest the following fix.
        //make this [Obsolete]
        public bool LeftHandDrive => LeftHandTraffic; // Intentionally wrong for legacy reasons.

        public bool LeftHandTraffic =>
            Singleton<SimulationManager>.instance.m_metaData.m_invertTraffic
            == SimulationMetaData.MetaBool.True;

I didn't remove Left hand drive because I don't want to make too many changes in the code. note that the variable names may also need an update.

Rather than have something intentionally wrong, why not just do a find and replace across the entire source of the mod?
Also, I think it would be much less ambiguous if it was named TrafficDrivesOnLeft to divest from the often confused terms such as LHT/RHD vs. RHT/LHD.

@aubergine10 you will need to search and replace a lot of variable names too.

I think it will be worth doing, to avoid future confusion. We (well, kvakvs specifically) did a lot of similar code clean up shortly after migration to Harmony framework just to improve overall maintainability of the codebase.

I can have a look at doing the bulk update later today, if you want?

@aubergine10 that would be nice.


Audit cookbook does not automatically skip profiles for a different platform type

Cookbook version
4.0.0
Chef-client version
12.19.36
Platform Details
Amazon Linux and Windows 2012 R2 (AWS default AMIs)
Scenario:
I have an audit role that is added to a base role in the run-list of all nodes. My attributes are set as follows:
{
  "audit": {
    "fetcher": "chef-server",
    "reporter": "chef-automate",
    "profiles": [
      {
        "name": "linux-baseline",
        "compliance": "delivery/linux-baseline"
      },
      {
        "name": "linux-patch-baseline",
        "compliance": "delivery/linux-patch-baseline"
      },
      {
        "name": "windows-baseline",
        "compliance": "delivery/windows-baseline"
      },
      {
        "name": "windows-patch-baseline",
        "compliance": "delivery/windows-patch-baseline"
      }
    ]
  }
}

Steps to Reproduce:
See attributes and versions above.
Expected Result:
I'd like the audit cookbook to determine the platform and skip profiles that are not relevant.
Actual Result:
At the moment an error is thrown:
Running handlers:
[2017-06-20T13:46:51+00:00] INFO: Running report handlers
[2017-06-20T13:46:52+00:00] WARN: Format is json
[2017-06-20T13:46:52+00:00] INFO: Initialize InSpec 1.25.1
[2017-06-20T13:46:52+00:00] ERROR: Report handler Chef::Handler::AuditReport raised #<RuntimeError: This OS/platform (amazon) is not supported by this profile.>
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/inspec-1.25.1/lib/inspec/runner.rb:188:in `supports_profile?'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/inspec-1.25.1/lib/inspec/runner.rb:175:in `add_target'
[2017-06-20T13:46:52+00:00] ERROR: /var/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:134:in `block in call'
[2017-06-20T13:46:52+00:00] ERROR: /var/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:134:in `each'
[2017-06-20T13:46:52+00:00] ERROR: /var/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:134:in `call'
[2017-06-20T13:46:52+00:00] ERROR: /var/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:57:in `report'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/handler.rb:259:in `run_report_unsafe'
[2017-06-20T13:46:52+00:00] ERROR: /var/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:75:in `run_report_safely'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/handler.rb:125:in `block in run_report_handlers'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/handler.rb:123:in `each'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/handler.rb:123:in `run_report_handlers'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/handler.rb:135:in `block in <class:Handler>'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/client.rb:441:in `block in run_completed_successfully'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/client.rb:440:in `each'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/client.rb:440:in `run_completed_successfully'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/client.rb:299:in `run'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application.rb:295:in `block in fork_chef_client'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application.rb:283:in `fork'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application.rb:283:in `fork_chef_client'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application.rb:248:in `block in run_chef_client'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/local_mode.rb:44:in `with_server_connectivity'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application.rb:236:in `run_chef_client'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application/client.rb:464:in `sleep_then_run_chef_client'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application/client.rb:451:in `block in interval_run_chef_client'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application/client.rb:450:in `loop'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application/client.rb:450:in `interval_run_chef_client'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application/client.rb:434:in `run_application'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application.rb:59:in `run'
[2017-06-20T13:46:52+00:00] ERROR: /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/bin/chef-client:26:in `<top (required)>'
[2017-06-20T13:46:52+00:00] ERROR: /usr/bin/chef-client:57:in `load'
[2017-06-20T13:46:52+00:00] ERROR: /usr/bin/chef-client:57:in `<main>'
  - Chef::Handler::AuditReport
Running handlers complete
[2017-06-20T13:46:52+00:00] INFO: Report handlers complete
Chef Client finished, 0/11 resources updated in 02 seconds

If I remove the Windows references from the attributes file and run chef-client the audit completes successfully.

I've noticed this is still an issue with version of 7.0.1 of the cookbook.  I've made use of inspec's ability to know what controls need to run so I have developed multi os controls around individual products profiles.
Do you think this will resolved in the future? as I will would need to start splitting out my profiles as I would like to move to the audit cookbook approach for running my compliance scans.

Need @chris-rock to comment on this :)

I understand this is indeed an issue. The reason why this happens is that each profile executes individually and fails because it is not applicable. You could work around that if you place all the profiles into a wrapper profile that depends on all the profiles.
I think it makes sense for the audit cookbook to understand the read and skip exception. As part of https://github.com/inspec/inspec/issues/3158 we discussed to define a mechanism to report a skipped profile which would be beneficial for that issue as well.


configure host port

ECOPROJECT-1581
Currently the hostPort: 30001 is fixed by the operator and is no possible to change, making it impossible for pods to deploy if that port is already in use.
This PR makes the port configurable.

/test ?

/test 4.13-openshift-e2e

/test 4.12-openshift-e2e

/override ci/prow/4.13-openshift-e2e

/lgtm
giving a chance to get more feedback before merging,feel free to un-hold
/hold

/test 4.13-openshift-e2e

/retest

/unhold


Allow (and prefer) SQLite binary compilation with Zig

This PR adds support for using Zig as a drop-in replacement for GCC/Clang, and prefers it if found. The sole complication was that emacsql-sqlite-compile offered no way to extend the list of arguments passed to the compiler, so I created a helper function (emacsql-sqlite-compile-arguments).
Rationale
I primarily use Emacs on Windows. As a software developer, I’ve already set up my environment to be able to compile large, complex C/C++ projects (e.g. LLVM, openimageio, x265), but I’m not a C/C++ developer myself. I recently had trouble compiling emacsql-sqlite’s native binary and found a trivial solution using zig cc. I thought I’d offer it as an option here in case anyone else finds it useful.

The sqlite back-end will soon be replaced by the new sqlite-builtin and sqlite-module back-ends. I intend to preserve the sqlite back-end as-is in the next release.
In a future release I will probably merge https://github.com/magit/emacsql/tree/system-sqlite.
Yet another release later, I might merge https://github.com/magit/emacsql/tree/backend-rewrite. But that doesn't come without risk, which is why I might not want to take because by that time this back-end will only be kept around for users stuck on ancient Emacs releases.
This pull-request falls into the same category. I might merge it after merging backend-rewrite but I might also decide against doing so. It is to early to tell.

Actually it is quite unlikely that I am gonna want to merge this, so it seems more honest to close it now.

Alright. I’m not sure I understand about the branches you mentioned, since it looks like both of those would still need compilers and as such this is equally applicable there, but I do understand that it’s a ridiculously specific PR with a bit of a shaky foundation, so I defer to your judgement. Thanks for taking the time to look at it, and thanks for everything you do!

Alright. I’m not sure I understand about the branches you mentioned, since it looks like both of those would still need compilers and as such this is equally applicable there, but I do understand that it’s a ridiculously specific PR with a bit of a shaky foundation, so I defer to your judgement. Thanks for taking the time to look at it, and thanks for everything you do!
(Apologies for the doubled notification.)


Rename dashboard to smartpanel

Closes #29

FWIW I just pushed a fix to the rename-smartpanel branch that renames tfc_web/smartpanel/templates/dashboard since it looks like that got missed and the whole thing doesn't work without it.

thx!


Collection update doesn't update index

Collection update doesn't update indexed object.
Here what I found
Collection.prototype.update = function (doc) {

// some code here
        var arr = this.get(doc.$loki, true),
          obj,
          position,
          self = this;

// some code here

        obj = arr[0];

        Object.keys(this.constraints.unique).forEach(function (key) {

// !!! HERE index is updated with old object
          self.constraints.unique[key].update(obj);
        });

        position = arr[1];

// !!! Only HERE document is updated, but index still have old value
        this.data[position] = doc;

So when you try get get document by index, old document is returned

I think you are correct, we probably should update the unique[].update to use doc instead of obj.
Additionally, unique constraints can become internally inconsistent because doc is likely pointing to the same reference as obj.  If you do a get() and update a property on that returned object, you have already updated the document in our collection.data array, without having yet called update (since it is the same object reference).
So unless the user is using unique constraints to enforce at the insert() level, they are not really safe to use unless you specify 'clone' option on collection creation to ensure internal reference is different than user space reference.  In that condition your change suggestion would be needed for successful index updates.
Would you care to submit a p.r. to fix that?  If you are familiar with adding unit test cases, that could be useful as well... otherwise we can just add that to list of things to do when we get time.
Thanks

I updated collection.update() to use doc which should help out when cloning is enabled (which it probably should be anyways).
Feel free to let me know if it works as expected, I will look into adding more unit tests to verify this later.

Closing this


Scroll main content independently of sidebar

This is an awesome component - thank you for sharing it!
Currently scroll is disabled in the main content area when the sidebar is activated.  Do you know how I can get scroll to work in both the main content area as well as the sidebar at the same time?

Setup your element to be scrollable
On Fri, Sep 18, 2015, 17:24 Kris Fields<EMAIL_ADDRESS>wrote:

This is an awesome component - thank you for sharing it!
Currently scroll is disabled in the main content area when the sidebar is
activated. Do you know how I can get scroll to work in both the main
content area as well as the sidebar at the same time?
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/react-sidebar/issues/17.

Could you elaborate?  It looks like the sidebar creates a fixed overlay that is preventing the scrolling of any content underneath, regardless of what overflow is set to.   I'm not great with css though so it's quite possible I'm missing something simple.

@krisfields I agree with you, scrolling fields not smooth at all on iOS :(

I was trying to test this out and didn't seemed to work. Tried here on codesandbox: https://codesandbox.io/s/yp638q29rv
it just empty screen.


[3.1.107-SDK] Build fails during core-setup

I'm trying to build the 3.1.107-SDK release of source-build on Debian under WSL, looking towards packaging it for Debian, and am running into trouble during compilation; specifically, 11 errors show up during core-setup building, ending with:
      0 Warning(s)
      11 Error(s)                                                                                Time Elapsed 00:03:57.30
##vso[task.logissue type=error]Build failed (exit code '1').

'core-setup' failed during build.
See '/home/avatar/src/source-build-3.1.107-SDK/artifacts/logs/core-setup.log' for more information.
'aspnet-extensions' failed during build.
'aspnetcore-tooling' failed during build.
'aspnetcore' failed during build.
'websdk' failed during build.
'known-good' failed during build.

Build FAILED.

I have attached core-setup.log here, which contains a number of errors of the form:
##vso[task.logissue type=error;sourcepath=/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets;linenumber=1260;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) Error when creating nuget lib package from /home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/artifacts/packages/Release/specs/runtime.debian-x64.Microsoft.NETCore.DotNetAppHost.nuspec. System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/artifacts/bin/debian-x64.Release/corehost'.%0A   at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)%0A   at System.IO.Enumeration.FileSystemEnumerator`1.Init()%0A   at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized)%0A   at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options)%0A   at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)%0A   at System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)%0A   at NuGet.Common.PathResolver.PerformWildcardSearch(String basePath, String searchPath, Boolean includeEmptyDirectories, String& normalizedBasePath)%0A   at NuGet.Packaging.PackageBuilder.ResolveSearchPattern(String basePath, String searchPath, String targetPath, Boolean includeEmptyDirectories)%0A   at NuGet.Packaging.PackageBuilder.AddFiles(String basePath, String source, String destination, String exclude)%0A   at NuGet.Packaging.PackageBuilder.PopulateFiles(String basePath, IEnumerable`1 files)%0A   at Microsoft.DotNet.Build.Tasks.Packaging.NuGetPack.Pack(String nuspecPath, String nupkgPath, Manifest manifest, Boolean packSymbols) in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs:line 256
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error : Error when creating nuget lib package from /home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/artifacts/packages/Release/specs/runtime.debian-x64.Microsoft.NETCore.DotNetAppHost.nuspec. System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/artifacts/bin/debian-x64.Release/corehost'. [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at System.IO.Enumeration.FileSystemEnumerator`1.Init() [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options, Boolean isNormalized) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at NuGet.Common.PathResolver.PerformWildcardSearch(String basePath, String searchPath, Boolean includeEmptyDirectories, String& normalizedBasePath) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at NuGet.Packaging.PackageBuilder.ResolveSearchPattern(String basePath, String searchPath, String targetPath, Boolean includeEmptyDirectories) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at NuGet.Packaging.PackageBuilder.AddFiles(String basePath, String source, String destination, String exclude) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at NuGet.Packaging.PackageBuilder.PopulateFiles(String basePath, IEnumerable`1 files) [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]
/home/avatar/src/source-build-3.1.107-SDK/packages/restored/microsoft.dotnet.build.tasks.packaging/1.0.0-beta.20113.5/build/Packaging.targets(1260,5): error :    at Microsoft.DotNet.Build.Tasks.Packaging.NuGetPack.Pack(String nuspecPath, String nupkgPath, Manifest manifest, Boolean packSymbols) in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs:line 256 [/home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/src/pkg/projects/Microsoft.NETCore.DotNetAppHost/Microsoft.NETCore.DotNetAppHost.pkgproj]

I can confirm that corehost does not exist under /home/avatar/src/source-build-3.1.107-SDK/artifacts/src/core-setup.fcfdef8d6ba770e4d7ba9efefe2591d8c33a1fc6/artifacts/bin/debian-x64.Release; however, it does exist under a parallel directory named debian.-x64.Release, which seems odd.
Thoughts?

What version of Debian is this? I would have expected the version to be between the . and - in debian.-x64.

It's bullseye. My /etc/os-release is as follows:
PRETTY_NAME="Debian GNU/Linux bullseye/sid"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Hmm, yeah, that's "missing" some version variables vs. 10/buster which we build on routinely in PR validation / CI:
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

(They're optional in the /etc/os-release spec from what I see, but source-build currently needs them so it can end up with a RID like debian.11-x64.)
I think that https://github.com/dotnet/source-build/issues/297 probably tracks fixing this requirement--in general it tracks broadening how well we support distros that are unknown in similar ways.
@cerebrate do you know if Debian bullseye will get VERSION_ID=11 in its /etc/os-release, perhaps once it becomes more stable?

Aha! Well, that's easy enough to fix for now.
And I would presume bullseye would get those fields once it formally ships as Debian 11 and becomes the new stable, as that's what's seemed to happen in the past, but I don't have any inside insight on that. It's a little inconvenient from a packaging point of view, though, because new packages are supposed to be built against testing or unstable, which lack those fields.


【XCode11】 Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Client error attempting to change layout margins of a private view'

Please upgrade
iOS13 mistake has fixed


Make tilemap texture origin point top-left.

Fix https://github.com/godotengine/godot/issues/29487. In this commit: https://github.com/godotengine/godot/pull/28896 bad offset of textures and shapes was fixed, but a center of texture was added too, and this seems not dessired by default because breaks too much compatibility with demos and user projects. A future Check box for center texture can be added

Thanks!


doc: Add mention about lack of HEEx syntax highlighting to the readme

Adds a note in the readme about lack of support for HEEx syntax highlighting and directs users to the Phoenix Framework extension instead.
Fixes #64.

Thanks!


About Hungarian matching loss?

Hi, thanks for your great work! I wonder if Hungarian matching loss could be added to this package since set prediction is also an important part of this work.

I am not the author of this repository, but you can use this scipy function to compute the Hungarian matching: https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.linear_sum_assignment.html

Thank you so much!


Create test database for EUROPDX partners

Create a test database with 2-3 europdx providers and share it with Dalibor.

Done.


bug: ion-toggle md bug

Bug Report
Ionic version:

[x] 4.1.1
Current behavior:
When the toggle button is toggled it correctly changes the color but only moves to a middle state and not completely to the right.

This behaviour only happens for mode="md"

Expected behavior:

The toggle button moves completely to the right when toggled.

Steps to reproduce:
Make an empty application with a default ion-toggle control
Related code:

<ion-content>
  <ion-toggle></ion-toggle>
</ion-content>

Hi there,
Thanks for the issue. I am not seeing this happen with ion-toggle. Can you provide a repository with the code required to reproduce this issue? Thanks!

@liamdebeasi Sorry can be closed. Was a error in a global .css file.


separate flaky tests from output - passes that did not pass on first try are instead output as flaky, not passed

Conditionally enabled by config option separateFlaky of type boolean. Default is false, which will not change the current behaviour.

There seems to be some conflict with the prettier and eslint rules. Running npm run prettier then results in some eslint failures.
I ran the prettier fmt in a separate commit, so luckily I can revert easily if necessaru. lmk if you want to adjust this to use eslint instead or just ignore.

Very nice 🚀  @jgibo , thank you for fixing this

hmm, yeah eslint is being a pain here => https://github.com/ryanrosello-og/playwright-slack-report/actions/runs/6275837955/job/17058601126?pr=54
Leave it with me and I will fix when i do the version bump

Thanks @ryanrosello-og! Great lib you've built here.
I'm also looking into the issue where the statistics count doesn't seem to be right in certain environments. At my job, we're running the tests in a GCP VM and the counts appear to be off in the stats output - different to what playwright reports in the suite end logs.
Seems strange that the runtime env would affect this, hopefully I'll know more about this later today then I'll report back.


'Customizing days' example showing wrong disabled date

Customizing days example showing wrong disabled date.
Disabled dates as per example should be Sundays, but in the example they are shown as Saturdays.
need to change the modifiers to fix the issue.
// ModifiersExample.js

const modifiers = {
  disabled: date => getDay(date) === 0, // change from 6 to disable Sunday
  highlight: date => getDay(date) === 2
}

Thought this fixes the issue in example, Ideally I feel like the change should be made in how the CalanderGrid is laid out.

Thanks, I just got confused when writing that comment.

Ideally I feel like the change should be made in how the CalanderGrid is laid out.
You mean the start of the week day? That depends on the locale you pass, the example uses enGB.


Cannot create Logic App

When using the palette to run Create Logic App it returns a message saying:
command 'azureLogicApps.createLogicApp' not found
The extension is installed correctly.

Duplicate of #35


Update Posts “references”

Automatically generated by Netlify CMS

👷 Deploy Preview for friendly-gumption-35ffbe processing.

Name
Link

🔨 Latest commit
f9bea1c5aa1e061b0a703b81f71a10cdaf4c3fdf

🔍 Latest deploy log
https://app.netlify.com/sites/friendly-gumption-35ffbe/deploys/6343a0abb8bc2a0009fb16e6


Ubuntu 14.04: unmet dependencies

All of my machines are 14.04 atm.
Which Ubuntu do I need to make EternalTCP work?
The following packages have unmet dependencies:
et : Depends: libncurses5 (>= 6) but 5.9+20140118-1ubuntu1 is to be installed
Depends: libprotobuf9v5 but it is not installable
Depends: libsodium18 (>= 0.6.0) but it is not installable
Depends: libstdc++6 (>= 5.2) but 4.8.4-2ubuntu1~14.04.3 is to be installed
Depends: libtinfo5 (>= 6) but 5.9+20140118-1ubuntu1 is to be installed
Depends: libgflags2v5 but it is not installable
Depends: libgoogle-glog0v5 but it is not installable

14.04 seems to be too old. Can you upgrade to the latest LTS?  I think it's
16.04
On Sat, Apr 29, 2017, 3:30 PM MarkSwanson<EMAIL_ADDRESS>wrote:

All of my machines are 14.04 atm.
Which Ubuntu do I need to make EternalTCP work?
The following packages have unmet dependencies:
et : Depends: libncurses5 (>= 6) but 5.9+20140118-1ubuntu1 is to be
installed
Depends: libprotobuf9v5 but it is not installable
Depends: libsodium18 (>= 0.6.0) but it is not installable
Depends: libstdc++6 (>= 5.2) but 4.8.4-2ubuntu1~14.04.3 is to be installed
Depends: libtinfo5 (>= 6) but 5.9+20140118-1ubuntu1 is to be installed
Depends: libgflags2v5 but it is not installable
Depends: libgoogle-glog0v5 but it is not installable
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MisterTea/EternalTCP/issues/29, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASuv7n6NRqUd4VFayBlUlLR6M-BDdGFks5r07oSgaJpZM4NMZwZ
.

All of our corporate machines and VMs are still on 14.04.
No worries.
Maybe it would help others if the docs specified Ubuntu >= 16.

I'll try to make a 14.04 build. It may be as simple as just building it
against that OS
On Sun, Apr 30, 2017, 8:34 AM MarkSwanson<EMAIL_ADDRESS>wrote:

Closed #29 https://github.com/MisterTea/EternalTCP/issues/29.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MisterTea/EternalTCP/issues/29#event-1063460960, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASuvwMWx8zdIntcXvMDJyWCzpr053t7ks5r1KnygaJpZM4NMZwZ
.

Reopening so I can make a 14.04 build.  Going to spin up a 14.04 VM for this.

So I can't upload a PPA since ubuntu 14 doesn't have libsodium, but you can build your own using these steps:
sudo su -
add-apt-repository ppa:chris-lea/libsodium;
echo "deb http://ppa.launchpad.net/chris-lea/libsodium/ubuntu trusty main" >> /etc/apt/sources.list;
echo "deb-src http://ppa.launchpad.net/chris-lea/libsodium/ubuntu trusty main" >> /etc/apt/sources.list;
apt-get update
apt install libboost-dev libsodium-dev libncurses5-dev libprotobuf-dev protobuf-compiler cmake libgoogle-glog-dev libgflags-dev dh-systemd git build-essential
exit
git clone https://github.com/MisterTea/EternalTCP.git
cd EternalTCP
mkdir build
cd build
cmake ../
make


Goreleaser changelog grouping does not work

Eventhough we have changelog groups defined in .goreleaser.yml based on the documentation at https://goreleaser.com/customization/changelog/, the last release changelog was not grouped correctly (everything was grouped under "Other").
Unfortunately, as far as I am aware, there is no option to run just a single stage of the goreleaser pipeline. So, debugging this issue is going to be tricky.

This is still broken. The Goreleaser tests produced the correct output for our configuration when I was working on #889 but apparently the released version of Goreleaser works differently 🤷🏽


Feature 4893 performance improvements

Description

Using the VS2019 Performance Profiler several places were identified where the performance of LEAN could be improved by applying minor tweaks for a respectable total performance improvement of 10-20% during backtesting.
I was limited to profiling and runtime tests as I haven't been able to get Python working locally with LEAN, but all tests passed in the build pipeline.
For ease of reviewing each commit in the PR covers its own minor tweak.
Related Issue

#4893
Motivation and Context

Performance
Requires Documentation Change

No
How Has This Been Tested?

VS2019 Performance profiler was run before and after to verify that bottle necks had been removed or reduced. Backtesting runtimes were verified lower total runtime while providing the same stats as before.
Performance tests
BasicTemplateBenchmark C# using EURUSD from 2007-04-01 to 2017-01-01 :
master
25,48 seconds at 142k data points per second. Processing total of 3.627.182 data points.
24,68 seconds at 147k data points per second. Processing total of 3.627.182 data points.
25,47 seconds at 142k data points per second. Processing total of 3.627.182 data points.
PR
23,07 seconds at 157k data points per second. Processing total of 3.627.182 data points.
23,88 seconds at 152k data points per second. Processing total of 3.627.182 data points.
23,47 seconds at 155k data points per second. Processing total of 3.627.182 data points.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[X] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[X] My code follows the code style of this project.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Welcome to LEAN @AndreasSundebo, thank you for the PR. We'll review and post feedback or tweaks ASAP.

@Martin-Molinero @jaredbroad Added performance tests as requested.


Turtles not moving once activated

when I place the turtles down and run the turtle command it only half works, the turtles turn, move to calibrate and then return to where they were, going idle immediately after.
here's a clip of what happened and me following your suggestions for some other issues:
https://drive.google.com/file/d/1805ktr8bfg8NM_RNYkg0mYn6EbhYvyOB/view?usp=sharing

I see you closed the issue, did you solve the problem? I'm watching what you uploaded and I have to say I'm still working on figuring out what could be going wrong.

I see you closed the issue, did you solve the problem? I'm watching what you uploaded and I have to say I'm still working on figuring out what could be going wrong.

Yes, I did find out how to fix the issue, I just had to break and replace
the turtle and it worked perfectly.
On Wed, Jan 13, 2021 at 11:02 PM MerlinLikeTheWizard <
<EMAIL_ADDRESS>wrote:

I see you closed the issue, did you solve the problem? I'm watching what
you uploaded and I have to say I'm still working on figuring out what could
be going wrong.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/merlinlikethewizard/Mastermine/issues/8#issuecomment-759946832,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARZZMNWUUAKE3FAJ2IDOXXLSZ2CGPANCNFSM4WBUQEQQ
.

Yes, I did find out how to fix the issue, I just had to break and replace
the turtle and it worked perfectly.
On Wed, Jan 13, 2021 at 11:02 PM MerlinLikeTheWizard <
<EMAIL_ADDRESS>wrote:

I see you closed the issue, did you solve the problem? I'm watching what
you uploaded and I have to say I'm still working on figuring out what could
be going wrong.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/merlinlikethewizard/Mastermine/issues/8#issuecomment-759946832,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARZZMNWUUAKE3FAJ2IDOXXLSZ2CGPANCNFSM4WBUQEQQ
.


fix: initial vote sync

Verified votes retrieved from db on startup were broadcasted with net->onNewPbftVotes but on startup no peer is actually connected yet. As a temporary fix I delay the broadcast for 2 minutes when it is expected that there will be peers connected. A better fix is needed on develop.

prnet cleaned-up successfully


The close button on the title bar cannot be closed

The close button on the title bar cannot be closed as below;

but  menuitem "Exit" can close app!

It's a normal behaviour, you need to click on the Close button of MyImwWIndow3 (in the middle of the screen).

Thank you very much. The problem has been solved


Jax custom call

We are importing this to explore some things. @hawkinsp hold off on reviews. Thanks!

Hi! This looks really useful. Is anyone still committed to making this happen?

@jlu-spins yes, we are making an improved version with better C++ typed argument support. But it creates a new dependency on some XLA component that's still WIP. We are actively working on this, and will hopefully have a version in a few weeks.
In the meanwhile, https://github.com/dfm/extending-jax is still a good guide for doing JAX custom call at head.

@zhangqiaorjc Thank you!

How create a custom class instance with several call method and its own stateful resource. Something like Extending TorchScript with Custom C++ Classes

I'm going to close this PR since this work has been superseded by XLA's FFI API which is documented in https://github.com/google/jax/pull/22095.
@MoFHeka — Please feel free to open a new discussion topic with more details about your specific use case if it would be useful to continue the conversation.


Create ICRC-4.md

I realized I put this in the wrong repo.

Hi @skilesare , I updated the folder structure a bit, please re-submit your PR. Also please complete the CLA. Thanks!


JS: Type-tracking through global access paths

Type tracking now steps through global access paths. It uses an intermediate pseudo-node to avoid constructing all read/write pairs.
The above leads to an improved call graph due to class tracking
We also resolve function calls directly through global access paths
Closure modules now rely on the global access paths module instead of computing them by itself
Removing globalFlowPred() as the flow should now be handled by the above improvements

Full evaluation on nightly. I've since fixed the bug that caused the spurious changes to invalid-prototype-value and a new evaluation is running, but probably own't affect the results much.
Another evaluation on definitions.ql with CG metrics, shows the call graph has definitely changed, but also that the way we deal with external calls in that metric is officially bogus. The "lost" call edges are mainly due to external calls being classified differently.

Marking as WIP until we've decided if the perf cost is worth it.

Some more evaluations from this week:

Full eval on nightly and big-apps. Overhead is roughly ~10%.
Number of called functions on nightly and big-apps. Most projects are affected, overall >1000 new callees, even when excluding gecko and test262. The -8 on amphtml is fixed in the latest commit.

I think this is ready to land.

This needs a rebase.


the moment i try to import your component i get this error. : there are several files providnig this module.

import SearchHeaderComponent from 'react-native-search-header';
Can you please fix this ?

Try
npm start -- --reset-cache
and see if that will fix the issue.

I have the same problem but I could not find a solution.
I already try reset-cache but is not working

I'll push a new version soon, and hopefully it will fix this issue.

Excelente, thanks


Function to erase cache if new synGet() metadata or config file changes

There are a few cases where a file would change upstream of the drake workflow that would invalidate the results:

A file changes on Synapse and the version was not explicitly specified in config.yml
The config file parameters are changed.

Functions impacted: iterative_normalization(), import_metadata(), import_counts(), counts target, clean_md()
Ideas for how to remedy this:
There are only a few functions that directly depend on either a synGet() call or config::get().

Perform a check first to see if the state has changed. If there is a change, drake::clean() the target.

I'm not sure drake::clean() is the best function. Additionally, this approach would require explicit conditional logic. e.g. if metadata input changes; invalidate import_metadata() target.

This solution might address use case 1.


Prole-info command

Since we already have Pui and Psi, I don't see a reason not to add a command for role information. The command could display the role's name, color, icon (if there's one), ID, permissions, etc.
Since we are allowed to copy role IDs, searching for them shouldn't be hard.
Alias: ri, roleinfo, role
Command: Prole-info <role name or id>

Command has been partially implemented by https://github.com/JustAnyones/Pidroid/commit/8dd8c15cb0ce65514f42ce4017064ce9737a855c
The icon features are not available as I have not yet implemented the methods to obtain it from the d.py library

Fully implemented by https://github.com/JustAnyones/Pidroid/commit/9d723d0b28a22abc8b959b54edfeae90f47c15d9


model prediction differs before and after saving the model

System Info
accelerate verion: 0.29.1
Platform: Linux
python version: 3.10
transformer verion: 4.39.3
peft: 0.10.0
Who can help?
No response
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[X] My own task or dataset (give details below)

Reproduction
Hi @pacman100 @younesbelkada @BenjaminBossan, I'm seeing difference in the model prediction before saving the model and after loading the model.
I'm fine-tuning google's gemma 2b model,
Please find the reproducible code below,
Here i'm fine-tuning the gemma model with my dataset.
import pandas as pd
import torch
import transformers
from trl import SFTTrainer
from peft import LoraConfig
from transformers import AutoTokenizer, AutoModelForCausalLM, BitsAndBytesConfig
from datasets import Dataset, load_dataset

model_id = "google/gemma-2b"
bnb_config = BitsAndBytesConfig(
    load_in_4bit=True,
    bnb_4bit_quant_type="nf4",
    bnb_4bit_compute_dtype=torch.bfloat16
)

tokenizer = AutoTokenizer.from_pretrained(model_id, token=os.environ['HF_TOKEN'])
model = AutoModelForCausalLM.from_pretrained(model_id, quantization_config=bnb_config, device_map={"":0}, token=os.environ['HF_TOKEN'])

data = pd.read_csv('train_data.csv')
train_df = Dataset.from_pandas(data)

lora_config = LoraConfig(
    r=8,
    target_modules=["q_proj", "o_proj", "k_proj", "v_proj", "gate_proj", "up_proj", "down_proj"],
    task_type="CAUSAL_LM",
)

trainer = SFTTrainer(
    model=model,
    train_dataset=train_df,
    dataset_text_field = "text",
    max_seq_length = 512,
    args=transformers.TrainingArguments(
        num_train_epochs = 10,
        per_device_train_batch_size=4,
        gradient_accumulation_steps=16,
        warmup_steps=2,
        max_steps=10,
        learning_rate=2e-4,
        fp16=True,
        seed = 12,
        logging_steps=1,
        output_dir="outputs",
        optim="paged_adamw_8bit"
    ),
    peft_config=lora_config,
)

trainer.train()

After finishing training, I immediately tested with two examples to check how model does prediction for it, and I noticed model generated the expected output.
# Below is with example 1 input

text = "trained input example text 1"
device = "cuda:0"
inputs = tokenizer(text, return_tensors="pt").to(device)

outputs = model.generate(**inputs, max_new_tokens=200)
print(tokenizer.decode(outputs[0], skip_special_tokens=True))

# Below is with example 2 input

text = "trained input example text 2"
device = "cuda:0"
inputs = tokenizer(text, return_tensors="pt").to(device)

outputs = model.generate(**inputs, max_new_tokens=200)
print(tokenizer.decode(outputs[0], skip_special_tokens=True))

After checking the performance of the fine-tuned model, I saved the model with the below step
trainer.save_model("finetuned_model")

After saving the model, i restarted the kernel and loaded the fine-tuned model
from peft import AutoPeftModelForCausalLM
import torch
new_finetuned_model = AutoPeftModelForCausalLM.from_pretrained(
     "finetuned_model",
     low_cpu_mem_usage=True,
     return_dict = True,
     torch_dtype = torch.float16,
     device_map = "cuda:0",)

After loading the fine-tuned model, I tested the model with the same example input and I noticed generated output from the model is different.
text = "trained input example text 1"
device = "cuda:0"
inputs = tokenizer(text, return_tensors="pt").to(device)

outputs = new_finetuned_model.generate(**inputs, max_new_tokens=200)
print(tokenizer.decode(outputs[0], skip_special_tokens=True))

I'm not sure where I'm making mistake could you please help me here?
Expected behavior
Expecting the model to generate the same answer before saving the model and after loading the model.

Could you ensure that when predicting, the model is in .eval() mode and that the same random seed is set? Could you also check that the model is configured in the exact same manner, especially when it comes to quantization?

@BenjaminBossan its works correctly now. thanks.


I wrote an R package.

I remember a few months ago someone put together a python package that could be installed and maintained separately. Over the weekend I threw together an R package containing the API functions, adding some documentation files, etc.
I've got my work on a release branch in my gregmacfarlane/omxr repo. If anyone would like to help me check out the code, that would be great.
Also, I'd be happy to transfer ownership to osPlanning if you like.

Hi Greg,
Thanks for doing this. I'd be happy to check out the code. I'm kind of
swamped right now, but I'll try to get back to you before the end of the
month.
Regards,
Brian
Brian Gregor, P.E.
Oregon Systems Analytics LLC
PO Box 2211, Salem Oregon 97308
(503) 877-0349
On Mon, Jul 20, 2015 at 6:21 AM, Greg Macfarlane<EMAIL_ADDRESS>wrote:

I remember a few months ago someone put together a python package that
could be installed and maintained separately. Over the weekend I threw
together an R package containing the API functions, adding some
documentation files, etc.
I've got my work on a release branch in my gregmacfarlane/omxr
https://github.com/gregmacfarlane/omxr/tree/release/v0.2.0 repo. If
anyone would like to help me check out the code, that would be great.
Also, I'd be happy to transfer ownership to osPlanning if you like.
—
Reply to this email directly or view it on GitHub
https://github.com/osPlanning/omx/issues/18.

That's great.  I'll take a look and provide feedback too.

Updated to match work by @bstabler; preparing to wrap-up.


Search function available to lua

I am writting some lua code to search whatever is in the "primary" selection. But the lua API doesn't seem to provide a "search" function. In view:Find() I can not set the query string. Nor can I do something like HandleCommand("find foo -l") because there is no command find (though there is a replace command).
Alternatively, how can I set the lastSearch variable from lua?
Of course, I can cycle through all lines and use lua's own function string.find(), but that seems ackward given that micro already has the functionality.
On the other hand, search.go has  func Search(searchStr string, v *View, down bool) that looks to me as exactly what I need.
Thanks!

Added this to the search-goodies branch of my fork.
Please try it out and let me know if you find any issues.
👍

See the buffer:FindNext function, which is available to plugins.

@agarrubio were you able to figure out how to use Buf:FindNext?

@obedm503 I guess you had a trouble with Buf:FindNext because it's not quite obvious how to pass Loc structure to it from Lua. E.g. if you pass bp.Cursor.Loc, it will error since you're actually passing a pointer. Need to derefence it, which is done with unary minus operator as per https://godoc.org/layeh.com/gopher-luar#New. So you need to pass -bp.Cursor.Loc. Or alternatively you can pass buffer.Loc(bp.Cursor.Loc.X, bp.Cursor.Loc.Y).
Here is an example of using Buf:FindNext from my init.lua:
local micro = import("micro")
local config = import("micro/config")
local regexp = import("regexp")

local mySearch = {}

-- mostly reimplements bp:FindNext()
local function myFindNext(bp, s, down)
    -- the '-' is to dereference the pointer (see gopher-luar documentation & the comment in autoclose plugin)
    local searchLoc = -bp.Cursor.Loc
    if bp.Cursor:HasSelection() then
        if down then
            searchLoc = -bp.Cursor.CurSelection[2]
        else
            searchLoc = -bp.Cursor.CurSelection[1]
        end
    end
    local match, found = bp.Buf:FindNext(s, bp.Buf:Start(), bp.Buf:End(), searchLoc, down, true)
    if found then
        bp.Cursor:SetSelectionStart(match[1])
        bp.Cursor:SetSelectionEnd(match[2])
        bp.Cursor.OrigSelection[1] = -bp.Cursor.CurSelection[1]
        bp.Cursor.OrigSelection[2] = -bp.Cursor.CurSelection[2]
        bp.Cursor:GotoLoc(match[2])
        bp:Relocate()
    end
end

function hlsearchWord(bp)
    if not bp.Cursor:HasSelection() then
        bp.Cursor:SelectWord()
        search = "\\b" .. regexp.QuoteMeta(bp.Cursor:GetSelection()) .. "\\b"
    else
        search = regexp.QuoteMeta(bp.Cursor:GetSelection())
    end
    bp:HighlightCustomPattern("hlsearch", search)
    mySearch[bp:ID()] = search
end

function onFind(bp)
    mySearch[bp:ID()] = nil
end

function onFindLiteral(bp)
    mySearch[bp:ID()] = nil
end

function preFindNext(bp)
    if mySearch[bp:ID()] ~= nil then
        myFindNext(bp, mySearch[bp:ID()], true)
        return false
    end
    return true
end

function preFindPrevious(bp)
    if mySearch[bp:ID()] ~= nil then
        myFindNext(bp, mySearch[bp:ID()], false)
        return false
    end
    return true
end

function init()
    config.TryBindKey("Alt-s", "lua:initlua.hlsearchWord", false)
end

It uses my PR #1663 (which implements bp:HighlightCustomPattern). Alt-s highlights all occurrences of the selected text or the word under cursor. But also it (temporarily) makes Ctrl-n and Ctrl-p jump to the next such occurrence, not to the next lastSearch match.
Yeah, this Lua code looks pretty intricate for such a simple thing. Perhaps it would be indeed good to provide some bp:SetLastSearch.

@dmaluka Thanks for the response. I ended up iterating each line and regex matching to find the matches. That worked fine.


[BUG]UnicodeDecodeError: 'gbk' codec can't decode byte 0xac in position 102: illegal multibyte sequence

Description
When loading a variable from the yaml environment, the crewai library tries to load it in gbk encoding as soon as Chinese is present in it, but my yaml file is utf-8. You want to add a measure to detect file encoding when loading yaml files
Steps to Reproduce

edit agent.yaml or task.yaml
Write a lot of Chinese into the above two yaml files
crewai run

Expected behavior
When loading yaml files, it automatically detects whether the file encoding is gbk or utf-8 or something else, and loads the file in this encoding format because it involves the definition of agents and the definition of tasks, and people in many other countries may use different encodings
Screenshots/Code snippets

Operating System
Windows 11
Python Version
3.12
crewAI Version
0.51.0
crewAI Tools Version
0.51.0
Virtual Environment
Poetry
Evidence
`
crewai run
C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\pydantic_internal_config.py:341: UserWarning: Valid config keys have changed in V2:

'allow_population_by_field_name' has been renamed to 'populate_by_name'
'smart_union' has been removed
warnings.warn(message, UserWarning)
Running the crew
C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\pydantic_internal_config.py:341: UserWarning: Valid config keys have changed in V2:
'allow_population_by_field_name' has been renamed to 'populate_by_name'
'smart_union' has been removed
warnings.warn(message, UserWarning)
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\jonty\PycharmProjects\crew_agent\src\crew_agent\main.py", line 22, in run
CrewAgentCrew().crew().kickoff(inputs=inputs)
^^^^^^^^^^^^^^^
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\crewai\project\crew_base.py", line 38, in init
self.agents_config = self.load_yaml(
^^^^^^^^^^^^^^^
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\crewai\project\crew_base.py", line 53, in load_yaml
return yaml.safe_load(file)
^^^^^^^^^^^^^^^^^^^^
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\yaml_init_.py", line 125, in safe_load
return load(stream, SafeLoader)
^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\yaml_init_.py", line 79, in load
loader = Loader(stream)
^^^^^^^^^^^^^^
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\yaml\loader.py", line 34, in init
Reader.init(self, stream)
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\yaml\reader.py", line 85, in init
self.determine_encoding()
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\yaml\reader.py", line 124, in determine_encoding
self.update_raw()
File "C:\Users\jonty\AppData\Local\pypoetry\Cache\virtualenvs\crew-agent-OgCTPeQm-py3.12\Lib\site-packages\yaml\reader.py", line 178, in update_raw
data = self.stream.read(size)
^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'gbk' codec can't decode byte 0xac in position 102: illegal multibyte sequence
An error occurred while running the crew: Command '['poetry', 'run', 'run_crew']' returned non-zero exit status 1.

`
Possible Solution
When loading yaml files, it automatically detects whether the file encoding is gbk or utf-8 or something else, and loads the file in this encoding format because it involves the definition of agents and the definition of tasks, and people in many other countries may use different encodings
Additional context
no

hello,have your questions has finished?,I also meet the same question,can you help me

When I use custom i18n json files, the json files also have this problem when loading

Everything is OK。


Add version view for events

Short description
This PR adds the revision slider for events
Proposed changes

Add UI for revision slider for events
Add functionality to restore earlier revisions

Side effects

I'm not exactly sure if the permissions are correct
blocked until #2268 has been merged

Resolved issues

Fixes: #1154

Pull Request Review Guidelines

This is superseded by #2268.


Natspec-only docs

Could we have an config option to only generate docs for items with natspec documentation, i.e. contracts, interfaces, libraries, functions, and events. I comment all these accordingly, but often have uncommented internal/private items. As such, the generated docs have many redundant entries. It would be nice to have a natspec only option.

This is an interesting idea. You should be able to implement it in solidity-docgen 0.6 with a custom template that renders conditionally if item.documentation is defined.

This is an interesting idea. You should be able to implement it in solidity-docgen 0.6 with a custom template that renders conditionally if item.documentation is defined.

do you know what would be needed to conditionally render only private/internal items? i noticed item.documentation will simply exclude the @dev tags.

Private items should always be omitted automatically. It doesn't make sense to document them as they are not part of the interface.
Internal items you can omit by filter by item.visibility.
Is this related to this issue though? If not, please open another issue I can share more details.

I also think it should be default


I was wondering why the tests were not getting tripped up by these and that is when I realized that this function is not being used anymore because of a recent refactor. I might probably drop this function later but thanks for the PR.


[1.0] Remove domains in bot usernames and mark users system generated.

https://www.notion.so/appsmith/Feature-Flag-Strategy-931fe4a78d9443e6a981f6ed58fc602d

duplicate of #30131

duplicate of #30131


Unable to export resultset when in grid presentation

Could you provide any details?
There is an issue with context menu and custom SQL queries.
But it is not related to results export exactly.

Yes, I was unable to view context menu from resultset of custom queries under grid presentation.

Fixed.
You can re-download 4.2.3 again


Draft Print:  Select printer based on sheet size

@n0minus38
Can you think up any way to have housekeeper single out any dft files that are on 'D' sized sheets and print only those ones? I'm needing a way to make sure that I print off any D sized prints in a project and can't really think of a way other than cycle through thumbnails in windows explorer and keep an eye out for an obvious change in the size of title block

Need to add checks in CheckStartConditions().

Done


Error in console

This happens every time Sublime Text is loaded.
reloading python 3.3 plugin Catppuccin.create-tmtheme
Traceback (most recent call last):
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 308, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 584, in _check_name_wrapper
  File "<frozen importlib._bootstrap>", line 1022, in load_module
  File "<frozen importlib._bootstrap>", line 1003, in load_module
  File "<frozen importlib._bootstrap>", line 560, in module_for_loader_wrapper
  File "<frozen importlib._bootstrap>", line 853, in _load_module
  File "<frozen importlib._bootstrap>", line 980, in get_code
  File "<frozen importlib._bootstrap>", line 313, in _call_with_frames_removed
  File "/home/txtsd/.config/sublime-text-3/Packages/Catppuccin/create-tmtheme.py", line 49
    <string>{v}</string>"""
                          ^
SyntaxError: invalid syntax

It looks like it's a leftover file from older commits, since it tries to open Catppuccin.sublime-color-scheme to parse it.
Version: ST4 (build 4143)

@braver I've created a new tag with the previous changes, so it should be picked up upstream.
@jgburet please try updating from Package control.
Also, it would be very much appreciated if you guys could open new issues later instead of necrobumping old closed ones since it's difficult for us to track any new comments.
Thanks!


Bullet indention

Does it look better with the lists indented?

@Silburfuchs Do you have a preference? I don't feel strongly either way, so I'll leave this up to you.

Looks good, I'll merge it in. Thanks for the commit!

No problem guys!  Thanks!
Justin Cole
<EMAIL_ADDRESS>On Tue, Feb 20, 2018 at 8:19 AM, Bryan Sfara<EMAIL_ADDRESS>wrote:

Merged #35 https://github.com/securestate/king-phisher-templates/pull/35
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/securestate/king-phisher-templates/pull/35#event-1482503879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYOB4e-HPcQFAhf-4gbLlvw5z_kZAJABks5tWtSOgaJpZM4SK0wn
.


Source Account Auth: Use source account/contract in native token contract

Would be nice to update the call signature for the token.approve method in the example dapp while you're at it:
https://github.com/stellar/soroban-example-dapp/blob/main/pages/index.tsx#L143

added to current Soroban Sprint since @leighmcculloch mentioned it is critical.


create inception-v4

create inception-v4

It seems that there are testing codes which are not deleted.


I142 integrate firebase into the home page

Change Summary

Added a trigger to automatically update the user statistics on any changes made to the visit subcollection.
Added protection and display of user statistics on the homepage

Change Form

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
The trigger only works with the emulator enabled and does not currently work on the live server.
Paid plan will be needed to be able to deploy the functions.
Related Issue

Resolve #142

Thank you for the review @scratchclaggy!

@NicholasChoong Thanks for the review 😊

All g


Fix use of potentially invalidated iterator.

I've occassionally seen crashes when using Cesium for Unreal, showing a call stack that indicates a problem with raster overlays. I think the cause is the use of an iterator after it has been invalidated, and it's fixed by this PR.
I originally made this change in #327 and didn't see the crash anymore afterward. That PR isn't quite going to make it into our November release, which is the reason for this separate PR.

I'm self-merging this because it's a clear improvement and should go into today's release.


BUG REPORT - GeoSpatial Control - ShowShapeLabels

The boolean parameter ShowShapeLabels doesn't work.

Detalhes do documento
⚠ Não edite esta seção. É necessário para a vinculação do problema do docs.microsoft.com ➟ GitHub.

ID: 9e34915e-ffa9-9a20-55c6-c9e71561f9be
Version Independent ID: 673a113e-5978-85d2-699a-44e1a5a5fdf7
Content: Adicionar componentes geoespaciais a aplicativos feitos com o Microsoft Power Apps - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/geospatial-overview.md
Service: powerapps
GitHub Login: @iaanw
Microsoft Alias: iawilt

I checked with our engineering team and can confirm it's working as described (should show the labels or not). For further troubleshooting you might like to try asking about your issue at the Power Apps forum.

Hi. Thanks for the answer.
Here below you can see the issue happening... It happens once... The second time I access this screen, the map doesn’t show the shape labels.
@.***
Prof. Paulo J. Rech
De: iaanw @.>
Enviada em: terça-feira, 27 de julho de 2021 20:18
Para: MicrosoftDocs/powerapps-docs @.>
Cc: Paulo Jaco Rech @.>; Author @.>
Assunto: Re: [MicrosoftDocs/powerapps-docs] BUG REPORT - GeoSpatial Control - ShowShapeLabels (#2575)
I checked with our engineering team and can confirm it's working as described (should show the labels or not). For further troubleshooting you might like to try asking about your issue at the Power Apps forumhttps://powerusers.microsoft.com/t5/Building-Power-Apps/bd-p/PowerAppsForum1.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/powerapps-docs/issues/2575#issuecomment-887896061, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASNBNMEDQUVEBI3POI2Q2X3TZ45DPANCNFSM5A4EPNIA.


Atoms get not shown in "building idea"

X = GRID([2.4,4.5,-3,4.5,2.4]);
Y = GRID([7,5]);
Z = GRID([3,3]);
building = X * Y * Z;
lar = ARRANGE3D(LAR(building));
VIEWCOMPLEX(lar, explode=[1.4,1.4,1.4], show=["FV","atom"])

visualization of atoms is wrong
Because copCF (output from TGW) as well as lar.C[:CF] are  wrong !!
I verified that input to function build_copCF ls exact,  because it returns 0 for the Euler characteristic:  IFF  there are 18 atoms in copCF.   That is exactly the number it should be:  look at the image (wrong!  should be not faces, but atoms) ... 8+8 inner atoms + 2 outer atoms.

Please discuss with me the issue. It would be urgent ...
ciao, --a

I think this has been resolved by new TGW implementation
@apaoluzzi please double-check:
using Plasm

X = GRID([2.4,4.5,-3,4.5,2.4]);
Y = GRID([7,5]);
Z = GRID([3,3]);
building = X * Y * Z;
lar = ARRANGE3D(LAR(building));
VIEWCOMPLEX(lar, show=["FV"], explode=[1.4,1.4,1.4], title="Faces")
VIEWCOMPLEX(lar, show=["CV"], explode=[1.4,1.4,1.4], title="Atoms")

and, if it works, close the issue


enable specifying folders in AutoTrace options, closes #163

@MWSestabro, please review just the new tests


SubSchema Fields

Added support for fields that have their own subschema
The code flattens the sub-fields, so the path for address: { street } becomes 'address.street'
The parent's values are also merged into each child - this way field properties like editableBy and group can be set on the parent for all children, and can still be overridden by children
Minor changes were needed in several places to properly support paths, so currentValues[path] becomes get(currentValues, path)
In Form.getData(), replaced underscore's pick with lodash's pick which properly supports paths and returns a new object
Fixed a bug in collection.getParameters that made it impossible to specify a limit with addView or addDefaultView

Thanks! I'll add another field to the forms example to serve as a test case for this.

Oh ok, I see how you've implemented it now. I thought you would adapt FormNested somehow but you're not even using it, which is probably just as well. OK let's keep it this way for now then :)


Use auto traits to improve compile-time checking of internally tagged newtype variants

Internally tagged newtype variants containing a value other than a map or struct is an error at runtime:
#[derive(Serialize)]
#[serde(tag = "type")]
pub enum E {
    // There is no meaningful way to put `"type": "N"` *inside* of the serialized u64.
    N(u64),
}

@abonander's idea from #1307: bound the newtype variant data by an auto trait to catch the commonly mistaken cases (primitives, strings, etc).
// #[cfg(not(feature = "unstable"))]:
#[doc(hidden)]
pub trait InternallyTaggable {}
impl<T> InternallyTaggable for T {}

// #[cfg(feature = "unstable")]:
#[doc(hidden)]
pub auto trait InternallyTaggable {}
impl !InternallyTaggable for u64 {} // etc.

Tracking issue for auto traits: https://github.com/rust-lang/rust/issues/13231

@dtolnay why would this need to be an auto trait? Could serde simply not impl this tagging trait for scalar types and then the Serialize derive macro could either add that impl or not depending on the characteristics of the type to which it was applied?


Get rid of lazy statics in metrics, use new derive macro

Further improve metric ergonomics by switching to new derive macro.
Test Plan
CI, manual testing

Codecov Report

Merging #1100 (878e6fb) into main (1e95b5e) will increase coverage by 0.06%.
The diff coverage is 30.43%.

@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
+ Coverage   64.58%   64.65%   +0.06%
==========================================
  Files         125      125
  Lines       25128    25109      -19
==========================================
+ Hits        16228    16233       +5
+ Misses       8900     8876      -24


(0.4.0) Syntax error in generated code for SQL IN clause

Hi Vitus,
The following query
@Query("update sports set rated = 1 where id in (:ids)")
  Future<void> setRated(List<int> ids) ;

generates the following in the .part . Note the missing closing parenthesis in the query - (? instead of (?)
 @override
  Future<void> setRated(List<int> ids) async {
    await _queryAdapter
        .queryNoReturn('update sports set rated = 1 where id in (?');
  }

This causes the following run-time exception
DatabaseException(near "?": syntax error (code 1): , while compiling: update sports set rated = 1 where id in (?) sql 'update sports set rated = 1 where id in (?' args []}

If this is a valid issue - and easily fixed - then would it be possible to get a hot-fix release?

Thanks for your report. I'll take a look at it later that day!


[Linear] Ensure a resource is only serialized/hashed at most once to reply it

Currently the go-control-plane caches (both linear and snapshots) will serialize the resource as many time as there are clients receiving it.
This is an issue with control-planes watched by a lot of clients, especially with large resources (e.g. endpoints)
This PR ensures that the serialization occurs at most once per resource, in all cases (sotw/delta watches and linear/snapshot cache). A resource will still only be serialized if:

it is returned to at least one client.
its version had to be considered to be returned (i.e. the resource was added again with the same stable version).

Merge activity

Dec 23, 1:45 PM EST: A user started a stack merge that includes this pull request via Graphite.