Java 8+

Is it possible to make this compatible with java 8+
I currently cannot use this because I get the following error:
gamebuster@gamebuster-Ryzen9-3900X-RTX-3080:~/Desktop/Modding/WildermythGameProvider$ ./gradlew build --info
Initialized native services in: /home/gamebuster/.gradle/native
The client will now receive all logging from the daemon (pid: 1159260). The daemon log file: /home/gamebuster/.gradle/daemon/7.1.1/daemon-1159260.out.log
Starting 24th build in daemon [uptime: 57 mins 53.899 secs, performance: 99%, non-heap usage: 51% of 256 MiB]
Using 24 worker leases.
Now considering [/home/gamebuster/Desktop/Modding/WildermythGameProvider] as hierarchies to watch
Watching the file system is enabled if available
Starting Build
Settings evaluated using settings file '/home/gamebuster/Desktop/Modding/WildermythGameProvider/settings.gradle'.
Projects loaded. Root project using build file '/home/gamebuster/Desktop/Modding/WildermythGameProvider/build.gradle'.
Included projects: [root project 'WildermythGameProvider']

> Configure project :
Evaluating root project 'WildermythGameProvider' using build file '/home/gamebuster/Desktop/Modding/WildermythGameProvider/build.gradle'.
All projects evaluated.
Selected primary task 'build' from project :
Populating VCS workingDir MixinExtra_ekvol5eg59rv8qezjbdvgjak4/MixinExtras with ref 0.0.6: c948689427146f57d5bfb80eedc6efd62bdbcb7d
Now considering [/home/gamebuster/Desktop/Modding/WildermythGameProvider/.gradle/vcs-1/MixinExtra_ekvol5eg59rv8qezjbdvgjak4/MixinExtras, /home/gamebuster/Desktop/Modding/WildermythGameProvider] as hierarchies to watch

> Configure project :MixinExtras
Evaluating project ':MixinExtras' using build file '/home/gamebuster/Desktop/Modding/WildermythGameProvider/.gradle/vcs-1/MixinExtra_ekvol5eg59rv8qezjbdvgjak4/MixinExtras/build.gradle.kts'.
Caching disabled for Kotlin DSL accessors for project ':MixinExtras' because:
  Build cache is disabled
Skipping Kotlin DSL accessors for project ':MixinExtras' as it is up-to-date.
Registering project ':MixinExtras' in composite build. Will substitute for module 'com.llamalad7:MixinExtras'.

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':compileJava'.
> Could not resolve all task dependencies for configuration ':compileClasspath'.
   > Could not resolve com.llamalad7:MixinExtras:0.0.6.
     Required by:
         project :
      > No matching variant of project :MixinExtras was found. The consumer was configured to find an API of a library compatible with Java 9, preferably in the form of class files, preferably optimized for standard JVMs, and its dependencies declared externally but:
          - Variant 'apiElements' capability com.llamalad7:MixinExtras:0.0.6 declares an API of a library, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component compatible with Java 16 and the consumer needed a component compatible with Java 9
              - Other compatible attribute:
                  - Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)
          - Variant 'runtimeElements' capability com.llamalad7:MixinExtras:0.0.6 declares a runtime of a library, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component compatible with Java 16 and the consumer needed a component compatible with Java 9
              - Other compatible attribute:
                  - Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)

* Try:
Run with --stacktrace option to get the stack trace. Run with --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 775ms

I also tried altering the build script myself to make it compatible with java 8, but I don't really know Kotlin, and it didn't work.

It' occurs when using the release jar with java 9. The release jar was compiled with a later version.

Can confirm, if I compile with sourceCompatability and 'targetCompatabilityset to8`, I can use it with my java 9 project just fine.
https://github.com/WilderForge/MixinExtras/commit/413eb91c8a3ef11108be4bcc34b1d1e6f8bcc250

Try with 0.0.7

I'm going to close this since it's been inactive for quite a while and I believe the issue is fixed in the last few releases. Feel free to reopen if you're still experiencing issues.


Hanging

All the commands I've tried seem to hang for me for a few minutes sometimes (but they eventually complete.) Sometimes they work as expected (almost immediately.) I've seen no errors reported on the Harvest status page.
When I ^C out while it's hanging I get the following:
/home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:879:in `initialize': Interrupt
        from /home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:879:in `open'
        from /home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:879:in `block in connect'
        from /home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/timeout.rb:73:in `timeout'
        from /home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:878:in `connect'
        from /home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:863:in `do_start'
        from /home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:852:in `start'
        from /home/jared/.rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:1375:in `request'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/adapter/net_http.rb:82:in `perform_request'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/adapter/net_http.rb:40:in `block in call'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/adapter/net_http.rb:87:in `with_net_http_connection'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/adapter/net_http.rb:32:in `call'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/request/authorization.rb:38:in `call'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/lib/hcl/harvest_middleware.rb:19:in `call'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/rack_builder.rb:139:in `build_response'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/connection.rb:377:in `run_request'
        from /home/jared/.gem/ruby/2.2.3/gems/faraday-0.9.1/lib/faraday/connection.rb:140:in `get'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/lib/hcl/net.rb:31:in `get'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/lib/hcl/timesheet_resource.rb:44:in `block in resources'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/lib/hcl/day_entry.rb:40:in `with_timer'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/lib/hcl/commands.rb:138:in `note'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/lib/hcl/app.rb:49:in `run'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/lib/hcl/app.rb:28:in `command'
        from /home/jared/.gem/ruby/2.2.3/gems/hcl-0.4.15/bin/hcl:4:in `<top (required)>'
        from /home/jared/.gem/ruby/2.2.3/bin/hcl:23:in `load'
        from /home/jared/.gem/ruby/2.2.3/bin/hcl:23:in `<main>'

I've confirmed this issue on multiple machines and networks, but my coworkers don't seem to be having any issues. Any ideas?

Haven't experienced the issue this week yet, suspecting it was on their side, but still a little confused. I'll call this closed.


debt snowball idea

User feedback:

I'd enter debts by (1) amount, (2) interest rate, and (3) minimum payment. You could give users the option of doing a "debt snowball" approach (lowest balance first) or "debt avalanche" (highest interest first), although these would still be segregated into high, medium, and low interest categories, which I think makes sense. Then, your cash flow is minimum payments on all debts except either the smallest or highest interest, which gets all available cashflow. Any high interest debt will "block" the waterfall from going further down the chain, except for minimum payments, but that's the way it should be.

Another user said:

The high / medium / low income debt sections also give ranges for approximate returns. In context, users are thinking about debt, such as credit card rates. I recommend removal of Expected or approximate returns globally.


Get rid of phases in the database controller

The main logic behind the phases is not used anymore as I see. We're going through all the phases on each reconcile. So we have an idea of using K8s events instead of phases.
TODO:

Remove the whole phase logic from the database controller and replace it with events. So instead of phase switching, db-operator is throwing  an event.
Remove phases from database status

I started working on this. :)

@bobertrublik Big PR is merged: https://github.com/db-operator/db-operator/pull/65
I don't think we'll be changing database_controller now until this issues is done

Great, I've already begun with some changes. I will rebase from main. :)

Great, I've already begun with some changes. I will rebase from main. :)

After the update to v2.3.0 we noticed that db-operator creates a Reconciling event each time it runs the reconciliation function even though no changes were reconciled. This causes the event history to be filled with Started reconciling db-operator managed database.
From kubernetes.io:

Event is a report of an event somewhere in the cluster. It generally denotes some state change in the system.

Here I'm also a little surprised that db-operator only records that first event even though it goes through all reconcilication steps every time and also logs each steps meaning the event record is somehow omitted.
I deployed db-operator with a database locally and observed the following behavior.
First reconcile:
6s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
6s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases
6s          Warning   FailedCreatingOrUpdating       database/postgres-db                                        Secret "postgres-db-credentials" not found

Second reconcile:
2s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
2s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases
2s          Normal    InstanceAccessSecretCreating   database/postgres-db                                        Creating secret containing credentials to access the database instance
2s          Normal    ProxyCreating                  database/postgres-db                                        Creating proxy
2s          Normal    SecretsTemplating              database/postgres-db                                        Creating templated secrets
2s          Normal    InfoConfigMapCreating          database/postgres-db                                        Creating ConfigMap
2s          Normal    Templating                     database/postgres-db                                        Handle templated credentials
2s          Normal    BackupJobCreating              database/postgres-db                                        Handle BackupJob
2s          Normal    Finishing                      database/postgres-db                                        Finishing reconciliation process
2s          Normal    Ready                          database/postgres-db                                        Ready

Third reconcile:
3s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
2s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases
2s          Normal    InstanceAccessSecretCreating   database/postgres-db                                        Creating secret containing credentials to access the database instance
2s          Normal    ProxyCreating                  database/postgres-db                                        Creating proxy
2s          Normal    SecretsTemplating              database/postgres-db                                        Creating templated secrets
2s          Normal    InfoConfigMapCreating          database/postgres-db                                        Creating ConfigMap
2s          Normal    Templating                     database/postgres-db                                        Handle templated credentials
2s          Normal    BackupJobCreating              database/postgres-db                                        Handle BackupJob
2s          Normal    Finishing                      database/postgres-db                                        Finishing reconciliation process
2s          Normal    Ready                          database/postgres-db                                        Ready

Fourth reconcile:
1s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
1s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases

All future reconciles:
11s         Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database

Not sure if there is some kind of rate limiting for events or what's going on here.
Anyway, I would propose to move the event recorders from the handleDbCreateOrUpdate function inside the respective reconciliation functions. They should only record an event if they updated an object in the cluster.
If I understand the code correctly the reconciler simply reconciles without checking if the resource has to be reconciled? That would be an issue with my proposition.

After the update to v2.3.0 we noticed that db-operator creates a Reconciling event each time it runs the reconciliation function even though no changes were reconciled. This causes the event history to be filled with Started reconciling db-operator managed database.
From kubernetes.io:

Event is a report of an event somewhere in the cluster. It generally denotes some state change in the system.

Here I'm also a little surprised that db-operator only records that first event even though it goes through all reconcilication steps every time and also logs each steps meaning the event record is somehow omitted.
I deployed db-operator with a database locally and observed the following behavior.
First reconcile:
6s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
6s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases
6s          Warning   FailedCreatingOrUpdating       database/postgres-db                                        Secret "postgres-db-credentials" not found

Second reconcile:
2s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
2s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases
2s          Normal    InstanceAccessSecretCreating   database/postgres-db                                        Creating secret containing credentials to access the database instance
2s          Normal    ProxyCreating                  database/postgres-db                                        Creating proxy
2s          Normal    SecretsTemplating              database/postgres-db                                        Creating templated secrets
2s          Normal    InfoConfigMapCreating          database/postgres-db                                        Creating ConfigMap
2s          Normal    Templating                     database/postgres-db                                        Handle templated credentials
2s          Normal    BackupJobCreating              database/postgres-db                                        Handle BackupJob
2s          Normal    Finishing                      database/postgres-db                                        Finishing reconciliation process
2s          Normal    Ready                          database/postgres-db                                        Ready

Third reconcile:
3s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
2s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases
2s          Normal    InstanceAccessSecretCreating   database/postgres-db                                        Creating secret containing credentials to access the database instance
2s          Normal    ProxyCreating                  database/postgres-db                                        Creating proxy
2s          Normal    SecretsTemplating              database/postgres-db                                        Creating templated secrets
2s          Normal    InfoConfigMapCreating          database/postgres-db                                        Creating ConfigMap
2s          Normal    Templating                     database/postgres-db                                        Handle templated credentials
2s          Normal    BackupJobCreating              database/postgres-db                                        Handle BackupJob
2s          Normal    Finishing                      database/postgres-db                                        Finishing reconciliation process
2s          Normal    Ready                          database/postgres-db                                        Ready

Fourth reconcile:
1s          Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database
1s          Normal    CreatingOrUpdating             database/postgres-db                                        Starting process to create or update databases

All future reconciles:
11s         Normal    Reconciling                    database/postgres-db                                        Started reconciling db-operator managed database

Not sure if there is some kind of rate limiting for events or what's going on here.
Anyway, I would propose to move the event recorders from the handleDbCreateOrUpdate function inside the respective reconciliation functions. They should only record an event if they updated an object in the cluster.
If I understand the code correctly the reconciler simply reconciles without checking if the resource has to be reconciled? That would be an issue with my proposition.

@bobertrublik the "Reconciling" message means only that the reconciliation has started, and it's happening every $RECONCILE_PERIOD
First reconciliation can be broken, it's happening when a configmap doesn't exist, though I don't really know why it can't continue after creating it.
Since v2.0.0 we're reconciling all the time unless --checkForChanges arg is provided. Don't you have it set?
If not, it's actually strange that events are not created on the 4 reconcile, I'll have a look

And yes, it makes sense to create events when something is actually changed. But we need to figure out how to make dbo understand that something was changed or not

Since v2.0.0 we're reconciling all the time unless --checkForChanges arg is provided. Don't you have it set?

I looked at the Helm chart and it says that argument is only meant for DbUsers?
https://github.com/db-operator/charts/blob/main/charts/db-operator/values.yaml#L13-L22
I think there must be some sort of behavior with events that I'm not understanding. I let the reconciling run in the background for some time and the first reconcile is missing from the history and the repeating Reconciling events don't appear every time 😄
Logs:

2024-02-16T10:13:08Z	DEBUG	events	Started reconciling db-operator managed database	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "Reconciling"}
time="2024-02-16T10:13:08Z" level=info msg="DB: namespace=db-operator, name=postgres-db start CreatingOrUpdating"
2024-02-16T10:13:08Z	DEBUG	events	Starting process to create or update databases	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "CreatingOrUpdating"}
time="2024-02-16T10:13:08Z" level=info msg="DB: namespace=db-operator, name=postgres-db successfully created"
time="2024-02-16T10:13:08Z" level=info msg="DB: namespace=db-operator, name=postgres-db instance access secret created"
time="2024-02-16T10:13:08Z" level=info msg="DB: namespace=db-operator, name=postgres-db generic proxy creation is not yet implemented skipping..."
2024-02-16T10:13:08Z	DEBUG	events	Creating secret containing credentials to access the database instance	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "InstanceAccessSecretCreating"}
2024-02-16T10:13:08Z	DEBUG	events	Creating proxy	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "ProxyCreating"}
2024-02-16T10:13:08Z	DEBUG	events	Creating templated secrets	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "SecretsTemplating"}
2024-02-16T10:13:08Z	DEBUG	events	Creating ConfigMap	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "InfoConfigMapCreating"}
time="2024-02-16T10:13:08Z" level=info msg="DB: namespace=db-operator, name=postgres-db database info configmap created"
2024-02-16T10:13:08Z	DEBUG	events	Handle templated credentials	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "Templating"}
2024-02-16T10:13:08Z	DEBUG	events	Handle BackupJob	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "BackupJobCreating"}
2024-02-16T10:13:08Z	DEBUG	events	Finishing reconciliation process	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "Finishing"}
2024-02-16T10:13:08Z	DEBUG	events	Ready	{"type": "Normal", "object": {"kind":"Database","namespace":"db-operator","name":"postgres-db","uid":"83113b3d-4432-4029-b272-949e951dde69","apiVersion":"kinda.rocks/v1beta1","resourceVersion":"7295"}, "reason": "Ready"}
time="2024-02-16T10:13:08Z" level=info msg="DB: namespace=db-operator, name=postgres-db finish Ready"

Events for one iteration:
8m32s       Normal    InfoConfigMapCreating          database/postgres-db                        Creating ConfigMap
8m32s       Normal    Templating                     database/postgres-db                        Handle templated credentials
8m32s       Normal    BackupJobCreating              database/postgres-db                        Handle BackupJob
8m32s       Normal    Finishing                      database/postgres-db                        Finishing reconciliation process
8m32s       Normal    Ready                          database/postgres-db                        Ready
7m32s       Normal    CreatingOrUpdating             database/postgres-db                        Starting process to create or update databases
7m32s       Normal    InstanceAccessSecretCreating   database/postgres-db                        Creating secret containing credentials to access the database instance
7m32s       Normal    ProxyCreating                  database/postgres-db                        Creating proxy
7m32s       Normal    SecretsTemplating              database/postgres-db                        Creating templated secrets
4m32s       Normal    Reconciling                    database/postgres-db                        Started reconciling db-operator managed database

Events two iterations later:
9m4s        Normal    InfoConfigMapCreating          database/postgres-db                        Creating ConfigMap
9m4s        Normal    Templating                     database/postgres-db                        Handle templated credentials
9m4s        Normal    BackupJobCreating              database/postgres-db                        Handle BackupJob
9m4s        Normal    Finishing                      database/postgres-db                        Finishing reconciliation process
9m4s        Normal    Ready                          database/postgres-db                        Ready
8m4s        Normal    CreatingOrUpdating             database/postgres-db                        Starting process to create or update databases
8m4s        Normal    InstanceAccessSecretCreating   database/postgres-db                        Creating secret containing credentials to access the database instance
8m4s        Normal    ProxyCreating                  database/postgres-db                        Creating proxy
8m4s        Normal    SecretsTemplating              database/postgres-db                        Creating templated secrets
3s          Normal    Reconciling                    database/postgres-db                        Started reconciling db-operator managed database

Events after the following iteration:
10m         Normal    InfoConfigMapCreating          database/postgres-db                        Creating ConfigMap
10m         Normal    Templating                     database/postgres-db                        Handle templated credentials
10m         Normal    BackupJobCreating              database/postgres-db                        Handle BackupJob
10m         Normal    Finishing                      database/postgres-db                        Finishing reconciliation process
10m         Normal    Ready                          database/postgres-db                        Ready
9m35s       Normal    CreatingOrUpdating             database/postgres-db                        Starting process to create or update databases
9m35s       Normal    InstanceAccessSecretCreating   database/postgres-db                        Creating secret containing credentials to access the database instance
9m35s       Normal    ProxyCreating                  database/postgres-db                        Creating proxy
9m35s       Normal    SecretsTemplating              database/postgres-db                        Creating templated secrets
94s         Normal    Reconciling                    database/postgres-db                        Started reconciling db-operator managed database

I'll try to find something out.

I looked at the Helm chart and it says that argument is only meant for DbUsers?

I've forgotten to update it, now it also support dbs

Hmm I set checkForChanges: true and it also appears as argument in the deployment.
Containers:
   operator:
    Image:      my-db-operator:v1.0.0-dev
    Port:       60000/TCP
    Host Port:  0/TCP
    Command:
      db-operator
    Args:
      --check-for-changes

Looking at the logs it still goes through all reconciliation steps.
Events after upgrade:
❯ k get events
LAST SEEN   TYPE     REASON                         OBJECT                              MESSAGE
61m         Normal   InfoConfigMapCreating          database/postgres-db                Creating ConfigMap
61m         Normal   Templating                     database/postgres-db                Handle templated credentials
61m         Normal   BackupJobCreating              database/postgres-db                Handle BackupJob
61m         Normal   Finishing                      database/postgres-db                Finishing reconciliation process
61m         Normal   Ready                          database/postgres-db                Ready
60m         Normal   CreatingOrUpdating             database/postgres-db                Starting process to create or update databases
60m         Normal   InstanceAccessSecretCreating   database/postgres-db                Creating secret containing credentials to access the database instance
60m         Normal   ProxyCreating                  database/postgres-db                Creating proxy
60m         Normal   SecretsTemplating              database/postgres-db                Creating templated secrets
94s         Normal   Reconciling                    database/postgres-db                Started reconciling db-operator managed database
62s         Normal   ScalingReplicaSet              deployment/db-operator              Scaled up replica set db-operator-9f4b76db to 1
62s         Normal   SuccessfulCreate               replicaset/db-operator-9f4b76db     Created pod: db-operator-9f4b76db-r6xnp
61s         Normal   Scheduled                      pod/db-operator-9f4b76db-r6xnp      Successfully assigned db-operator/db-operator-9f4b76db-r6xnp to k3d-myk3s-server-0
61s         Normal   Pulled                         pod/db-operator-9f4b76db-r6xnp      Container image "my-db-operator:v1.0.0-dev" already present on machine
61s         Normal   Created                        pod/db-operator-9f4b76db-r6xnp      Created container operator
61s         Normal   Started                        pod/db-operator-9f4b76db-r6xnp      Started container operator
61s         Normal   ScalingReplicaSet              deployment/db-operator              Scaled down replica set db-operator-5bc797cdcf to 0 from 1
61s         Normal   SuccessfulDelete               replicaset/db-operator-5bc797cdcf   Deleted pod: db-operator-5bc797cdcf-g75k4
61s         Normal   Killing                        pod/db-operator-5bc797cdcf-g75k4    Stopping container operator
1s          Normal   Reconciling                    database/postgres-db                Started reconciling db-operator managed database
1s          Normal   CreatingOrUpdating             database/postgres-db                Starting process to create or update databases
1s          Normal   InstanceAccessSecretCreating   database/postgres-db                Creating secret containing credentials to access the database instance
1s          Normal   ProxyCreating                  database/postgres-db                Creating proxy
1s          Normal   SecretsTemplating              database/postgres-db                Creating templated secrets
1s          Normal   InfoConfigMapCreating          database/postgres-db                Creating ConfigMap
1s          Normal   Templating                     database/postgres-db                Handle templated credentials
1s          Normal   BackupJobCreating              database/postgres-db                Handle BackupJob
1s          Normal   Finishing                      database/postgres-db                Finishing reconciliation process
1s          Normal   Ready                          database/postgres-db                Ready

Second iteration:
❯ k get events
LAST SEEN   TYPE     REASON                         OBJECT                              MESSAGE
3m36s       Normal   Reconciling                    database/postgres-db                Started reconciling db-operator managed database
3m4s        Normal   ScalingReplicaSet              deployment/db-operator              Scaled up replica set db-operator-9f4b76db to 1
3m4s        Normal   SuccessfulCreate               replicaset/db-operator-9f4b76db     Created pod: db-operator-9f4b76db-r6xnp
3m3s        Normal   Scheduled                      pod/db-operator-9f4b76db-r6xnp      Successfully assigned db-operator/db-operator-9f4b76db-r6xnp to k3d-myk3s-server-0
3m3s        Normal   Pulled                         pod/db-operator-9f4b76db-r6xnp      Container image "my-db-operator:v1.0.0-dev" already present on machine
3m3s        Normal   Created                        pod/db-operator-9f4b76db-r6xnp      Created container operator
3m3s        Normal   Started                        pod/db-operator-9f4b76db-r6xnp      Started container operator
3m3s        Normal   ScalingReplicaSet              deployment/db-operator              Scaled down replica set db-operator-5bc797cdcf to 0 from 1
3m3s        Normal   SuccessfulDelete               replicaset/db-operator-5bc797cdcf   Deleted pod: db-operator-5bc797cdcf-g75k4
3m3s        Normal   Killing                        pod/db-operator-5bc797cdcf-g75k4    Stopping container operator
2m3s        Normal   InfoConfigMapCreating          database/postgres-db                Creating ConfigMap
2m3s        Normal   Templating                     database/postgres-db                Handle templated credentials
2m3s        Normal   BackupJobCreating              database/postgres-db                Handle BackupJob
2m3s        Normal   Finishing                      database/postgres-db                Finishing reconciliation process
2m3s        Normal   Ready                          database/postgres-db                Ready
63s         Normal   Reconciling                    database/postgres-db                Started reconciling db-operator managed database
63s         Normal   CreatingOrUpdating             database/postgres-db                Starting process to create or update databases
63s         Normal   InstanceAccessSecretCreating   database/postgres-db                Creating secret containing credentials to access the database instance
63s         Normal   ProxyCreating                  database/postgres-db                Creating proxy
63s         Normal   SecretsTemplating              database/postgres-db                Creating templated secrets

Four iterations later:
❯ k get events
LAST SEEN   TYPE     REASON                         OBJECT                              MESSAGE
7m42s       Normal   Reconciling                    database/postgres-db                Started reconciling db-operator managed database
7m10s       Normal   ScalingReplicaSet              deployment/db-operator              Scaled up replica set db-operator-9f4b76db to 1
7m10s       Normal   SuccessfulCreate               replicaset/db-operator-9f4b76db     Created pod: db-operator-9f4b76db-r6xnp
7m9s        Normal   Scheduled                      pod/db-operator-9f4b76db-r6xnp      Successfully assigned db-operator/db-operator-9f4b76db-r6xnp to k3d-myk3s-server-0
7m9s        Normal   Pulled                         pod/db-operator-9f4b76db-r6xnp      Container image "my-db-operator:v1.0.0-dev" already present on machine
7m9s        Normal   Created                        pod/db-operator-9f4b76db-r6xnp      Created container operator
7m9s        Normal   Started                        pod/db-operator-9f4b76db-r6xnp      Started container operator
7m9s        Normal   ScalingReplicaSet              deployment/db-operator              Scaled down replica set db-operator-5bc797cdcf to 0 from 1
7m9s        Normal   SuccessfulDelete               replicaset/db-operator-5bc797cdcf   Deleted pod: db-operator-5bc797cdcf-g75k4
7m9s        Normal   Killing                        pod/db-operator-5bc797cdcf-g75k4    Stopping container operator
6m9s        Normal   InfoConfigMapCreating          database/postgres-db                Creating ConfigMap
6m9s        Normal   Templating                     database/postgres-db                Handle templated credentials
6m9s        Normal   BackupJobCreating              database/postgres-db                Handle BackupJob
6m9s        Normal   Finishing                      database/postgres-db                Finishing reconciliation process
6m9s        Normal   Ready                          database/postgres-db                Ready
5m9s        Normal   CreatingOrUpdating             database/postgres-db                Starting process to create or update databases
5m9s        Normal   InstanceAccessSecretCreating   database/postgres-db                Creating secret containing credentials to access the database instance
5m9s        Normal   ProxyCreating                  database/postgres-db                Creating proxy
5m9s        Normal   SecretsTemplating              database/postgres-db                Creating templated secrets
2m9s        Normal   Reconciling                    database/postgres-db                Started reconciling db-operator managed database

@bobertrublik are you sure those are new events, they look to me like they were only created once

I just entered the same local cluster and shell as before and these are my events.
❯ k get events
LAST SEEN   TYPE     REASON        OBJECT                 MESSAGE
2s          Normal   Reconciling   database/postgres-db   Started reconciling db-operator managed database

I keep posting with the wrong account :D
I just entered the same local cluster and shell as before and these are my events.
❯ k get events
LAST SEEN   TYPE     REASON        OBJECT                 MESSAGE
2s          Normal   Reconciling   database/postgres-db   Started reconciling db-operator managed database

Templates and secretTemlates are triggering another reconciliation, because they are changing the secret data, there is an issue for fixing it: https://github.com/db-operator/db-operator/issues/77

fifth reconciliation

Is fifth coming after the second one, or it's third?

Is fifth coming after the second one, or it's third?

Judging by the timestamp and a reconciliation interval of 60s it should be the fifth reconcile. There should be an event at 4m9s and 3m9s in between. The logs are printed each minute as expected.

Alright, that's weird. I'll try to have a look the next week

I had another look at the code and have trouble understanding the workflow when CheckChanges is set.
First we check here whether we want to do a full reconciliation.
https://github.com/db-operator/db-operator/blob/a5ed0144e2b8e7db9a0325d71c84713af0d94f30/internal/controller/database_controller.go#L151
This check is dependent on the DATABASE_FORCE_FULL_RECONCILE annotation, the checkForChanges flag, the database status and the check whether the database has changed.
If any of these conditions are true, why are we still entering the handleDbCreateOrUpdate here?
https://github.com/db-operator/db-operator/blob/a5ed0144e2b8e7db9a0325d71c84713af0d94f30/internal/controller/database_controller.go#L152-L156
Shouldn't this information be enough to exit and wait until the next reconciliation phase?
Looking into handleDbCreateOrUpdate I must admit I don't understand this check here:
https://github.com/db-operator/db-operator/blob/a5ed0144e2b8e7db9a0325d71c84713af0d94f30/internal/controller/database_controller.go#L287-L297
Shouldn't there be an else clause that aborts the function?

I'll close this issues for now. If events are becoming trouble again, I'll open another one for fixing it


New package: Vega v0.1.0

Registering package: Vega
Repository: https://github.com/queryverse/Vega.jl
Created by: @davidanthoff
Version: v0.1.0
Commit: 2e6240784de6ca927db8609f10a574dda5b857ec
Reviewed by: @davidanthoff
Reference: https://github.com/queryverse/Vega.jl/commit/2e6240784de6ca927db8609f10a574dda5b857ec#commitcomment-37841571

Just a heads up: unless someone objects, I will merge this tonight, when the three day wait period has passed.


Fix various type issues

Fixes for https://github.com/gtk-rs/gtk/issues/1051 https://github.com/gtk-rs/gtk/issues/1050

CC @EPashkin @GuillaumeGomez


*: switch to golangci-lint

Signed-off-by: Vincent Batts<EMAIL_ADDRESS>Now this doesn't fix lint, but now makes main in a fixable way.
checking lint
specs-go/v1/index.go:24:15: `specificies` is a misspelling of `specifics` (misspell)
        // MediaType specificies the type of this document data structure e.g. `application/vnd.oci.image.index.v1+json`
                     ^
specs-go/v1/manifest.go:23:15: `specificies` is a misspelling of `specifics` (misspell)
        // MediaType specificies the type of this document data structure e.g. `application/vnd.oci.image.manifest.v1+json`
                     ^
schema/schema.go:20: File is not `goimports`-ed (goimports)
        "github.com/opencontainers/image-spec/specs-go/v1"
schema/loader.go:81:20: var-naming: method JsonSource should be JSONSource (revive)
func (l *fsLoader) JsonSource() interface{} { // nolint: golint
                   ^
schema/loader.go:120:20: var-naming: method JsonReference should be JSONReference (revive)
func (l *fsLoader) JsonReference() (gojsonreference.JsonReference, error) { // nolint: golint
                   ^
schema/backwards_compatibility_test.go:24: File is not `goimports`-ed (goimports)
        "github.com/opencontainers/image-spec/specs-go/v1"
schema/spec_test.go:98:7: `TOOD` is a misspelling of `TODO` (misspell)
                        // TOOD(stevvooe): This is nearly useless without file, line no.
                           ^
make: *** [Makefile:97: lint] Error 1

Now this doesn't fix lint, but now makes main in a fixable way.

It does now! 😛

look at that :green_circle: CI!


PR: Expand pattern to detect possible site-packages directories (Pythonpath manager)

Description of Changes

We were not detecting site-packages directories in Mac framework installations and two digit Python environments (e.g. Python 3.10).
Add tests for the small utility function that does that job.

Issue(s) Resolved
Fixes #21228.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

Thanks @mrclary for your review. I'm not that good to work with regular expressions, so I really appreciate your help.
I applied your suggestions and checked that the new tests I added pass, so this should  be ready now.


Introduce Template Properties for Axis2 Transport Properties

This PR introduces the template to enable/disable axis2 http/https transportSender or transportReceiver properties.
Resolves: https://github.com/wso2/product-is/issues/8364

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2536762967

PR builder failed due to the missing default configurations added through the: https://github.com/wso2/product-is/pull/13986
Therefore this change should be added to product-is after merging the above PR.

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2541378605

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2541378605
Status: success


Can you add some configurations that we can add username and password to login in the WEB UI

Describe the feature:

yanagishima version:
presto version:
conf/yanagishima.properties:
JVM version (java -version):
Server OS version (uname -a if on a Unix-like system):
Client OS version
Browser:
Description of the problem including expected versus actual behavior:
Steps to reproduce:
Please include a minimal but complete recreation of the problem, including
(e.g.) query execution, bookmark, settings, hisotry etc.  The easier you make for
us to reproduce it, the more likely that somebody will take the time to look at it.

Provide logs (if relevant):
Provide screenshots (if relevant):

Hi, is auth.xxx=true option not enough your situation?
https://github.com/yanagishima/yanagishima#authentication-and-authorization


[Feature request / Design proposal] Allow EcdhKeyExchangeProvider to be extensible like the other security providers

Summary
Microsoft.IdentityModel.Tokens should expose extension points for custom EcdhKeyExchangeProvider implementations where the private key may not be available in memory. Providing these extensions would bring EcdhKeyExchangeProvider in line with the other cryptographic providers within the library.
Motivation and goals
The Microsoft.IdentityModel.Tokens library provides the ability for consumers to provide custom SecurityKey implementations and cryptographic providers. This is useful when one wants (or needs) to store private key material in a way that is otherwise inaccessible to the built-in .NET cryptographic libraries. This could be a key exposed through a 3rd party crypto library such as BouncyCastle, a secrets manager such as 1Password (or an SSH agent), or on a hardware backed device such as an HSM.
Yubico (CC: @JamieHankins @aafortner) is collaborating with a sister-team within Entra ID that requires the use of the ECDH functionality within the Microsoft.IdentityModel.Tokens library. One set of private keys used for key agreement is stored on Yubico's YubiHSM product. These are private keys are never available to the host computer that is executing the Microsoft.IdentityModel.Tokens library. This also implies that the actual ECDH key agreement operation must be performed on the YubiHSM.
The current implementation of EcdhKeyExchangeProvider is currently not extensible. There are no override-able methods like there are on other *Provider classes. The current implementation also assumes in-memory access to the private key which may not always be available in the case of custom implementations.
This feature would allow for custom implementations of EcdhKeyExchangeProvider in a similar manner to how other providers (e.g. SignatureProvider) allow for extension.
A possible implementation has been created here: YubicoLabs azure-activedirectory-identitymodel-extensions-for-dotnet:ecdh-keyexchange-provider
In scope

Allow overriding or extension of the DeriveKeyFromHash step within the GenerateKdf function.
Add CreateEcdhKeyExchangeProvider or similar to CryptoProviderFactory to allow instantiation of custom provider implementations.
Remove any assumptions within EcdhKeyExchangeProvider around access to private key material.
Modify existing internal uses of EcdhKeyExchangeProvider to use CryptoProviderFactory instead of instantiating the provider directly.
Any additional properties, constants, glue code to bring EcdhKeyExchangeProvider in line with other crypto providers

Out of scope

Breaking API signature changes
Any other providers

Risks / unknowns

EcdhKeyExchangeProvider is an existing class with existing interface expectations. While I have a proposal that does not appear to cause any breaking API surface changes, it's always possible something has been missed.
Behavior changes are also challenging to avoid, but through careful refactoring and AppContext switches, it should be possible.
The trickiest part is the constructor. The existing public constructor of EcdhKeyExchangeProvider is doing some verification which presently assumes access to the private key. The same checks could be implemented in a different way.
Other crypto providers implement IDisposable and also have a Release mechanism through CryptoProviderFactory.Release*Provider(). EcdhKeyExchangeProvider currently implements neither of these. IDisposable would be a breaking API change. Adding a ReleaseEcdhKeyExchangeProvider method to CryptoProviderFactory could provide a "lesser of two evils" approach to still allowing for resource cleanup. Since there is no built-in implementation of this method for this provider, there should be no behavior change. The built-in version can simply no-op.

Examples
Extending EcdhKeyExchangeProvider:
public class MyProvider : EcdhKeyExchangeProvider
{
    private IKeyStore _keyStore;
    private ICustomKey _myKey;

    public MyProvider(
        IKeyStore keyStore, // Representation of the out-of-band crypto
        SecurityKey privateKey,
        SecurityKey publicKey,
        string alg,
        string enc) :
        base(
            keyStore.GetByKeyId(privateKey.KeyId),
            publicKey,
            alg,
            enc)
    {
        _keyStore = keyStore;
        _myKey = keyStore.GetByKeyId(privateKey.keyId);
    }

    public override byte[] DeriveKeyFromHash(
        ECDiffieHellmanPublicKey otherPartyPublicKey,
        HashAlgorithmName hashAlgorithm,
        byte[] prepend,
        byte[] append)
    {
        byte[] keyAgreement = _keyStore.EcdhKeyAgreement(_myKey, otherPartyPublicKey);
        return _keyStore.Hash(hashAlgorithm, [prepend, keyAgreement, append]);
    }
}

@GregDomzalski @jennyf19 i think the overall this feature makes sense.

@brentschmaltz @jennyf19 Great! Would you like me to add the next level of detail mentioned in the issue template for feature requests? Or should we open the PR and go through any feedback there?


OCM-6054 | feat: Create node pool with SG IDs

Allow the user to pass SG IDs when creating machine pool for HCP.
Reuse validation from classic.
Pass the values to the backend.

Can be merged after https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/7448 is available in staging, code reviews will be appreciated in the meantime.

/retest

/draft

@ciaranRoche backend changes are available in staging, can you rePTAL?


streamline toString() impl  with Deparsers

right now both implement the same logic. as a general principle, it's bad to repeat the same logic in multiple places.
it seems Deparser does a more complete traversal of the objects, shouldn't we implement all toString() with their corresponding Deparsers ?

If you are talking only about getting a string representation of the SQL you are right. But there  is more. The deparsers are following the visitor pattern and toString does not. At the moment it is a very convinient way to test the visitor hierarchy. That one will not work anymore if you drop the second implementation. Additional recently adapter classes were introduced. The next logical step would be to transfer the visitor logic of deparsers into the adapters. Conclusion: it is a good test pattern to implement the same output using different strategies and test for a match. IMHO this does not violate dry.

I think as long as you have the same logic defined in two places, you
always run the risk that these surprise u  with different results.
your point from the previous comment was that  the deparser framework may
be changed from using "visitor" to using "adaptor" , so that if we have  a
standalone logic in toString(),  the toString() logic does not need to be
changed together with the adaptor. am I understanding it correctly?
but my counter argument to that is,  even if u change to adaptor,  the new
adaptor-based traversal still runs the risk of producing conflicting
results from toString().  after all, conceptually the core of toString() is
to follow some traversal,  and that has been defined elsewhere  so it's
better not to do it again(possibLy differently)
On May 17, 2015 2:32 AM, "Tobias"<EMAIL_ADDRESS>wrote:

If you are talking only about getting a string representation of the SQL
you are right. But there is more. The deparsers are following the visitor
pattern and toString does not. At the moment it is a very convinient way to
test the visitor hierarchy. That one will not work anymore if you drop the
second implementation. Additional recently adapter classes were introduced.
The next logical step would be to transfer the visitor logic of deparsers
into the adapters. Conclusion: it is a good test pattern to implement the
same output using different strategies and test for a match. IMHO this does
not violate dry.
—
Reply to this email directly or view it on GitHub
https://github.com/JSQLParser/JSqlParser/issues/133#issuecomment-102771782
.

I understand your argument and agree with you that DRY is a good practice to follow.
At the time I made this fork, both ways were halfway implemented. So I decided to go for both and checking each against the other. My point here is testing, tests, tests, write effective tests without much effort. Without this different strategies and massive tests, the visitors (deparserd) or the toString would not have been in this very good state.
I do not agree that both have the same logic defined. They produce the same output but using different strategies of traversal the object hierarchy. I agree as I said if it would be only the output it would be redundant.
Assume you would remove one way. So how do you test the deparser. You let it build a sql and check it against a fix String or dynamic generated String from a parsed statement. Therefore you need for the dynamic way a different strategy of building this String if you want to avoid checking the deparser against itself. You have to implement some kind of toString method. So why not keeping this dynamic String building within the actual object (toString)?
The fact, that the adapters will be enhanced be the traversal logic of the deparsers was not an argument for keeping the toStrings but the way how they will evolve, so merely an informational statement :).
So at the moment I do not want to change the implementation of it.


“Join conference” button shows up after leaving call

If a user leaves the conference, let them rejoin it if they change their mind

ToDo: come up with proposed behaviour

@turt2live says this is no longer a problem.

I can confirm, I could leave and re-join during testing today and yesterday


Improve browser console

Landed in https://github.com/metarhia/metarhia.com/commit/a37f113dd9f64edfbe689cb49cccf437098bb8ff and https://github.com/metarhia/metarhia.com/commit/1eab80af91dd38689a56c75bc0d942685f8253e7

Landed in https://github.com/metarhia/metarhia.com/commit/a37f113dd9f64edfbe689cb49cccf437098bb8ff and https://github.com/metarhia/metarhia.com/commit/1eab80af91dd38689a56c75bc0d942685f8253e7


Using gulp-grunt my task never end.

Hi,
Using require('gulp-grunt')(gulp); my other gulp task and grunt-task never end.

What's your Gruntfile's block like? You have to return the stream, e.g.:
gulp.task('clean', function() {
  return gulp.start('grunt-clean:dist');
});

I have this also, Just including grunt into the gulp file prevents the gulp functions from ending. i.e. running them individually.
Are you saying to just put return on every grunt task will solve this also ?

@Smurf-IV Not quite. This setup works for me:
var gulp = require('gulp');

require('gulp-grunt')(gulp);

gulp.task('default', function() {
  return gulp.start('grunt-default');
});

gulp.task('serve', ['grunt-default'], function() {
  gulp.start('watch');
});

gulp.task('watch', function() {
  gulp.watch('**/*.js', function() {
    gulp.start('grunt-gulp:build');
  });
});

Previously, using grunt = require('gulp-grunt') did not work.

Gulp.start is new for me.
I was following the documentation
https://github.com/gulpjs/gulp/blob/master/docs/API.md#deps
gulp.task('build', ['array', 'of', 'task', 'names']);

If I comment out
require('gulp-grunt')(gulp);

then my individual gulp tasks exit when they have finished.
Putting it back in and using as you have suggested:
gulp.task('default', function() {
  return gulp.start('grunt-default');
});

Stop the gulp tasks from exiting. (i.e. not even running the grunt task)


fix: sequelize addHook type definition

at

We're currently processing your upload.  This comment will be updated when the results are available.


[Download Bundle Error]

OS: win32 - x64
Error: Error
Message: EBUSY: resource busy or locked, open 'C:\Users\aaa.vscode\extensions\tabnine.tabnine-vscode-3.2.10\binaries\3.3.96\x86_64-pc-windows-gnu\TabNine-deep-local.exe'
Stack: Error: EBUSY: resource busy or locked, open 'C:\Users\aaa.vscode\extensions\tabnine.tabnine-vscode-3.2.10\binaries\3.3.96\x86_64-pc-windows-gnu\TabNine-deep-local.exe'

Duplicate of #383


A description of my usage of this.

Just so you're aware of one particular use out there that is happening with your code.
I use this for flask servers yes, but I've learned there's nothing flask specific about this despite it's name. I can pull environmental configs for a CLI as well, or any program really.
I am using this in several CLI only projects to pull prefixed environment variables.
Cheers! Thanks for sharing this package; it has been really useful!

@nackjicholson thank you for sharing!
I sort of realized after building this package that it isn't necessarily Flask specific, but I haven't taken the time to re-release as a generic package. If only the days were longer :)


Integration test coverage for generating deployable jar task provider

Hey,
I would like to add an integration test to cover the previously closed issue https://github.com/bazelbuild/intellij/issues/1172.
GenerateDeployableJarTaskProviderTest  should cover the ability to generate a deployable jar task provider in scala_library.
Thanks,
Zachi

Happy to take additional tests.

Hey @brendandouglas ,
After looking into the GenerateDeployableJarTaskProviderTest flow I wish to implement, it seems more beneficial to implement an end-to-end test based on the BazelInvokingIntegrationTest that actually builds a deployable jar.
The actual problem for this issue was the fact that although IntelliJ had a valid run configuration before-launch build step, it failed building a deployable jar.
I believe that by only testing IntelliJ Swing UI, we might miss proper coverage in case of additional changes to this task flow.
I'll be glad to get your input on the matter. In case you think it's not a valid point, It'll be great to hear how do you suggest to properly add good coverage for this task.
Thanks

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


Initial groundwork for a low level api

Motivation
The next gen APIs (Vulkan and D3D12) offer an low level interface of the GPU in comparison to older APIs like OpenGL or D3D11. To avoid overhead due to high level abstraction we want to investigate the implementation of a thin wrapper above the mentioned low level APIs to address https://github.com/gfx-rs/gfx/issues/1102.
Goals
This PR creates a new low level core API corell and two backend implementations for the low level core. corell is heavily based on the vulkan API and shares a lot of concepts like Instance, Surface, etc., but tries to also take d3d12 into account. In future steps further abstractions could be considered to reduce the amount of setup code.
Planned coverage for this PR:

[x] Instance/Context
[x] Surface
[x] Swapchain
[x] PhysicalDevice

Note: Also includes some dummy types for other objects.
format and memory are mainly copied from core.
Hoping for early feedback if this is the intended way to go with regards to #1102.
cc @MaikKlein for quick checking ash based vulkan implementation if you have time 😄

The ash usage looks good.

:umbrella: The latest upstream changes (presumably #1140) made this pull request unmergeable. Please resolve the merge conflicts.

Current state
New way to setup the backend:
fn main() {
    let window = winit::WindowBuilder::new()
        .with_dimensions(1024, 768)
        .build()
        .unwrap();

    // instantiate backend
    let instance = back::Instance::create();
    let physical_devices = instance.enumerate_physical_devices();
    let queue_descs = physical_devices[0].get_queue_families().iter().map(|family| { (family, family.num_queues()) }).collect();

    // build a new device and associated command queues
    let (device, queues) = physical_devices[0].open(queue_descs);

    let surface = back::Surface::from_window(&window, &instance);
    let mut swap_chain = surface.build_swapchain::<ColorFormat>(1024, 768, &queues[0]);

    'main: loop {
        for event in window.poll_events() {

        }

        let frame = swap_chain.acquire_frame();

        // rendering

        // present frame
        swap_chain.present();
    }
}

Instance is the main entry point for an application. It's similar to an OpenGL context to some extent. We'll mainly use it for enumerating the available GPU devices on the system.
PhyiscalDevice and Surface are host abstraction of the corresponding gpu device and window. They are needed to build Device and Swapchain (driver/application-level counterparts).
Every GPU and virtual adapter (e.g d3d12 WARP) will be represented as PhysicalDevice and the user can query information about these devices. Probably most interesting properties are the supported command queues, which will be created together with the device.
Design decisions
Thread behavior (Vulkan)
Some objects need to be externally synchronized (e.g vkDevice on destruction or vkQueue on submit).
I tried to avoid locking for these objects to minimize the overhead and enforced the synchronization using Arc/Rc. Reference counting also has some additional overhead but it should only used for 'large' objects like device and command queue, which internals won't be cloned very often (on startup usually).
An alternative approach would be trying to remove all kind of reference counting and entirely relay on references &/& mut, but this might become very tricky to ensure the lifetimes and handle the trait interfaces.
Command queues
Only partially linked to this PR but I think worth to discuss early on.
Vulkan and D3D12 have different kind of command queues (also Metal's encoders, but I'm not familiar with the API):

D3D12 allows 3 different queue types/families (http://images.slideplayer.com/11/3326273/slides/slide_20.jpg) with an hierarchical: Graphics queues support also compute and transfer/copy operations.
Vulkan slightly differs: Graphics and Compute queues also support transfer/copy operations. If a physical device exposes a graphics queue, it also has to support a graphics+compute queue.

Possible queue combinations: Graphics/Copy, Graphics/Compute/Copy, Compute/Copy, Copy
Command buffers of the different types can then be submitted to the queues.
Difficulty here is the representation of the command buffers and command queues. We can either try to separate the different types to ensure at compile time that e.g a compute command buffer doesn't call draw or detect it at runtime.
Minor issues

I'm not totally happy with the name PhysicalDevice as it can also includes virtual devices like the mentioned WARP implementation, but couldn't find a good name (maybe adapter?)
Often returning references to Vec<_> (e.g https://github.com/gfx-rs/gfx/pull/1125/files#diff-4e5f58801cbe25ef39fdaf3aff780d49R91), any suggestions for improvement here?

If I forgot to mention something I'll add it later!
Any feedback appreciated!

Often returning references to Vec<_>

Why not return iterators like QueueFamiliyIter or QueueFamilies (can be type aliases) ?

@msiglreith thanks for the awesome writup!
let queue_descs = physical_devices[0].get_queue_families().iter().map(|family| { (family, family.num_queues()) }).collect();

Why do we need to process this? Could physical_devices[0].open just accept queue families directly?
let surface = back::Surface::from_window(&window, &instance);

This might look better as let surface = instance.create_surface(&window);
let mut swap_chain = surface.build_swapchain::<ColorFormat>(1024, 768, &queues[0]);

Doesn't surface already know about the size (or has the size)?

Every GPU and virtual adapter (e.g d3d12 WARP) will be represented as PhysicalDevice and the user can query information about these devices

Nice to see d3d concepts fitting into the queue families!

Reference counting also has some additional overhead but it should only used for 'large' objects like device and command queue, which internals won't be cloned very often (on startup usually).

It sounds reasonable, yes.

Vulkan and D3D12 have different kind of command queues (also Metal's encoders, but I'm not familiar with the API):

Metal's encoders are close to our Encoder, it's not related to the command queue.

Difficulty here is the representation of the command buffers and command queues.

I have some ideas, will express them in the follow-ups.

I'm not totally happy with the name PhysicalDevice as it can also includes virtual devices like the mentioned WARP implementation, but couldn't find a good name (maybe adapter?)

Yes, Adapter sounds good!

Often returning references to Vec<_>

I'm not aware of any valid use case to return &Vec<>. If you have these queue families locally, you can return slices &[].

@Bastacyclop @kvark First of all thank you for the feedback!

Why not return iterators like QueueFamiliyIter or QueueFamilies (can be type aliases of Vec iterator) ?

I'm not aware of any valid use case to return &Vec<>. If you have these queue families locally, you can return slices &[].

Probably will try to use iterators and slices as fallback depending on the complexity and usability.

Why do we need to process this? Could physical_devices[0].open just accept queue families directly?

In order to specify how many queues of a certain family we want to create. D3D12 theoretically supports infinite software queues and doesn't allows us to query how many hardware queues there are iirc.

This might look better as let surface = instance.create_surface(&window);

Yes, Adapter sounds good!

Agree! Going to change it.

Doesn't surface already know about the size (or has the size)?

Actually yes. Vulkan allows to create swapchains images with different dimensions from the surface (vk specs extensions, 29.5 Surface Queries), but I can't imagine a use-case at the moment. Also switching this to the default windows size.

@msiglreith the latest changes look good 👍

I'm quite fine with the current design iteration.
Both backends should work fine (without crashing), Vulkan validation layers throw some errors due to lack of synchronization primitives and need to create the swapchain images.
All points mentioned in the feedback has been addressed iirc. Added TODOs throughout the source code for future work.
Upcoming topics to work on:

Shaders, RenderPasses and Pipelines
Resources and Memory
Descriptor handling
Synchronization
Command Buffers

My biggest concern here is the code duplication between our current gfx_core and the low-level counter-part. I'd prefer a much gradual transition, but it looks like we are too invested already, so merging this.
Note to all developers - any changes would have to go into both the current and new cores. Hence, we should make the swap and deprecate the old one as soon as possible!
@homu r+

:pushpin: Commit 76d65f0 has been approved by kvark

:hourglass: Testing commit 76d65f0 with merge eb46bdb...

:sunny: Test successful - status


Fix Ruby 2.4 deprecations

lib/devise_security_extension/models/password_archivable.rb:20: warning: constant ::Fixnum is deprecated
I'm upgrading my app to Ruby 2.4 and getting these deprecations everywhere.

This successfully removes the warnings for me on Ruby 2.4.1 👍

Is there anything stopping merging this branch? This warning is driving me crazy.

Someone with merge permissions :trollface:

Please merge

Is this gem still actively maintained?

Unfortunately it doesn't appear so. A couple of us have made a fork called devise-security

@tibbon
This repo is pretty much unmaintained at this point... try the fork of it at https://github.com/devise-security/devise-security


Add item into history events of collection

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #3240
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 100 usd

😍 Perfect, I’ve sent the payout
💵 $100 @ 53.89 USD/KSM ~ 1.856 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x595aa25cc5a8f21845a12623394800038205d8f96fc6aaa4fa98183e157e1222
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


An update for NFAuthenticationKey_Windows.zip

Netflix add-on version
Last one
Operative systems used
Windows
Kodi version used
Kodi 20 (Nexus)
Description of the bug
hi everybody,
the NF authentication key generator for windows browser seams to be old. the login page says :
Update required
Looks like your browser, operating system, or device is not supported. Please make some updates to access Netflix. Learn more about updates and requirements here.
Can't access your account? Contact us.
thanks for all.
Steps to reproduce the behavior
No response
Debug log - mandatory
no log
Possible fix
No response
Additional context
No response
Screenshots

@ttchampi can you please share more information.

Which windows version (7,8,10,11)?
Which browser is opened?
What version does the browser have? (120.0.6099.130)

For me it works fine with Windows 10 and Chrome 120.0.6099.130

I found something that works...
If I understand correctly, when I open the NFAuthenticationKey.exe file, the settings.json file is extracted and when I press start, a browser is extracted in the BrowserTempData file. But this one is no longer up to date.
...on the other hand, by opening the settings.json file, you can force NFAuthenticationKey.exe to use another browser by replacing the sentence:
"* Remove me and specify here the browser path with .exe extension, only if not recognized ( e.g. C:\mypath\chrome.exe) *"
by "C:\Program Files\Google\Chrome\Application\chrome.exe" (the path to a more up-to-date downloaded Chrome Browser with \  and not just \ )
Anyway, but the fact remains that the browser provided with the NFAuthenticationKey.exe file is out of date... isn't it? (version appears to be number 78.0.3904.97)


RC.8 Release PR

Release checklist:

[ ] All local tests pass
[ ] All commits are signed off
[ ] Flakyness report (N/A, better wait for merge from staging).
[ ] All ./scripts pass
[ ] Iroha Java

[ ] Compiles
[ ] Runs
[ ] tests pass

[ ] Iroha JavaScript

[ ] Compiles,
[ ] Runs
[ ] tests pass

changelog update should probably also be in the checklist


_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
master passed

+1 :green_heart:
compile
0m 20s
master passed

+1 :green_heart:
checkstyle
0m 10s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 26s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
checkstyle
0m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  2s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

24m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5401

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a0dd96e0c8f8 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84ccae368f

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-asyncfs U: hbase-asyncfs

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 33s
master passed

+1 :green_heart:
compile
0m 18s
master passed

+1 :green_heart:
checkstyle
0m  8s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 24s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
checkstyle
0m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
8m 59s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

23m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5401

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 9577a9307081 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84ccae368f

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
76 (vs. ulimit of 30000)

modules
C: hbase-asyncfs U: hbase-asyncfs

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 33s
master passed

+1 :green_heart:
compile
2m 39s
master passed

+1 :green_heart:
checkstyle
0m 44s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 30s
the patch passed

+1 :green_heart:
compile
2m 42s
the patch passed

+1 :green_heart:
javac
2m 42s
the patch passed

-0 :warning:
checkstyle
0m  8s
hbase-asyncfs: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

-0 :warning:
checkstyle
0m 37s
hbase-server: The patch generated 2 new + 8 unchanged - 1 fixed = 10 total (was 9)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
8m 57s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

33m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5401

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 54ebbd19993d 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84ccae368f

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-asyncfs.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 32s
master passed

+1 :green_heart:
compile
2m 43s
master passed

+1 :green_heart:
checkstyle
0m 44s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
2m 42s
the patch passed

+1 :green_heart:
javac
2m 42s
the patch passed

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-asyncfs

+1 :green_heart:
checkstyle
0m 33s
hbase-server: The patch generated 0 new + 8 unchanged - 1 fixed = 8 total (was 9)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  0s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

33m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5401

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 5034a2523341 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84ccae368f

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 23s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 11s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
shadedjars
4m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 16s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
shadedjars
4m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  1s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
220m  2s
hbase-server in the patch passed.

242m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5401

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8ce3ea27a8c1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84ccae368f

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/testReport/

Max. process+thread count
4231 (vs. ulimit of 30000)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 39s
master passed

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
shadedjars
4m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
4m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 39s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
229m 11s
hbase-server in the patch passed.

255m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5401

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0aa6b07c0b52 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84ccae368f

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/testReport/

Max. process+thread count
4454 (vs. ulimit of 30000)

modules
C: hbase-asyncfs hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5401/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Space Spider

About the PR
A space spider, dangerous and cunning, it does not kill first, but makes its prey safe for sustenance.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

:cl: Nimfar

add: Adds the Space Spider.

down for more salv mobs


Change IGN_DESIGNATION to GZ_DESIGNATION

Signed-off-by: Nate Koenig<EMAIL_ADDRESS>I ran find . -name "*" -exec -i 's/IGN_DESIGNATION/GZ_DESIGNATION/g' {} \; in order to make this repository compliant with https://github.com/gazebosim/gz-cmake/pull/282

All the CI that could pass for this branch has passed.


Fixed the offset links

The offset URLs must have changed so I went ahead and updated them to point to the right pages.

Thank you! 🙏


Bookmark folder popups don't show and hide at the correct time

On the next branch the logic behind rendering bookmark subfolders has been rewritten.
Before it was CSS based for layout etc. which was great for performance and simplifying logic but had limitations like the inability to scroll a long list of bookmark items or control folder position when overflowing the screen. The new logic is JS based so there's no longer any issues with position and layout, however, the implementation is still incomplete.
Current issues:

There should be a short delay before opening the first folder on hover to prevent accidental opens (this works now!).

After the first folder is open, there should be no delay opening nested folders since that's annoying and feels like the app has frozen (Chrome actually still uses a delay for nested folders but I don't think that's ideal).

There should also be a delay before closing a folder popup (on mouseout) to closing when the user is moving their mouse to a nested folder etc. (this work now too! Interestingly Chrome keeps folders open until a click outside or ESC key press).

The delay timeout speed should be tweaked for the optimal UX.
When opening another folder on the same level any existing folder popup on that level should be closed immediately.

Many things here differ from the Chrome UX because Chromium is designed for good a11y however this extension favours speed.

Only difference from my original write up is that there's no delay before showing a folder popup. It's not actually that annoying to trigger it by accident and it actually feels very responsive with the immediate open.

For my own future reference, the reason we had an open delay before was only on nested folders because it's too easy to open the wrong folder. When moving the mouse between the target folder and its popup, if you happen to mouse over another folder your target folder's popup will be closed.


Saving figures in offline mode

It seems that it is not possible to save figures to SVG/PDF/PNG in offline mode:
plot(1:10); plotlyfig = fig2plotly(gcf, 'offline', true); saveplotlyfig(plotlyfig,'myPlotlyFig','pdf');
Gives the following output:

Error using response_handler (line 29)
Aw, snap! We don't have an account for . Want to try again? Sign in is not case sensitive.
Error in plotlygenimage (line 63)
response_handler(response_string, extras);
Error in plotlyfig/saveas (line 332)
plotlygenimage(imgfig, filename, varargin{:});
Error in saveplotlyfig (line 68)
p.saveas(filename, varargin{:});

Is there a way to save the Plotly Plot as JSON file?
Something like in the Python API?

Is there a way to save the Plotly Plot as JSON file?
Something like in the Python API?


Don't strip full stops from Github link URLs

Github allows full stops in repo names. For example, see https://github.com/octokit/octokit.rb
Also removes some unused constants.

Actually, hold fire on this one. I think we do want to strip a .git suffix, just not full stops in general.

@hmac - all yours.


Remove stdin/stdout/stderr parameters of Daemon.init

These seem to be leftovers that are not actually used for anything.
@sneben: agree?

In the ancient version this was there for debugging purposes. I think debugging should be a possibility. Let's introduce a debugging switch, which sets the path of all three to a log file under /var/log. What do you mean?


Add more pre eoc game sprites!

I really miss pre-eoc. WOuld appreciate this plugin if possible.

Picture examples would be great

https://imgur.com/a/uk1yL58
More texture to the grounds, shadow etc.

this would be nice too:
https://imgur.com/a/XHMKoDI

Any updates on this? :)


the HUGE npm package size of 225MB makes the module less producible

[./node_modules/siwe] -> du -h -d 1
88K	./dist
44K	./lib
24M	./integrations
12K	./.github
24K	./test
294M	./examples
318M	.

The main files take up 44K, while the examples take up 294M. This results in a lot of redundancy with each production deployment. For a service of a certain size, this is a serious obstacle.
Suggestion: take the examples out of the npm package

Apologies, the examples directory was previously excluded but sneaked back into the previous release. @w4ll3 should the integrations be excluded as well?

Not even sure how those folders are in the release, they are no longer in this repo.

Oh I didn't notice integrations was removed from the repo as well. It's just because they're in my local copy

Thank you so much @yi we love making the release smaller.


Adding css file #6

This CSS file should have all the code to format your whole website

fixes #6


VIES Soap validation  not happening

In the readme you are advertising VIES API validation - but I can't seem to find anything related to this in the source code.

@gabiudrescu it's because the validation is not done in this plugin, but in the dependent bundle : https://github.com/Prometee/VIESClientBundle also dependending on a lib https://github.com/Prometee/VIESClient

@Prometee so, with this file https://github.com/Prometee/SyliusVIESClientPlugin/blob/master/src/Resources/config/validation/VATNumberAwareInterface.xml#L14 you are calling this class https://github.com/Prometee/VIESClientBundle/blob/master/Constraints/VatNumberValidator.php#L38 that is using this helper to call the soap ws: https://github.com/Prometee/VIESClient/blob/master/src/Helper/ViesHelper.php#L38

Yes this is how it works because VIES webservice could be used elsewhere (other sf projects, put php project, etc...) and I like to separate things which can be separated

thanks for the info.


add description for local submission validation

I removed the following text from the model-output/readme but perhaps we should add it back once we have a recommended procedure:
Local forecast validation
Optionally, you may validate a forecast file locally before submitting it to the hub in a pull request. Note that this is not required, since the validations will also run on the pull request. To run the validations locally, follow these steps:
[Add description for local forecast validation]

related to #120


Initial version of SliverTabView

NOT FINISHED!
Example usage:
class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage>
    with SingleTickerProviderStateMixin {
  late final _horizontalController = TabController(length: 3, vsync: this);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: CustomScrollView(
        slivers: [
          MultiSliver(
            children: [
              SliverPinnedHeader(
                child: Container(
                  color: Colors.white,
                  child: TabBar(
                    controller: _horizontalController,
                    tabs: const [
                      Tab(text: 'Red'),
                      Tab(text: 'Blue'),
                      Tab(text: 'Green'),
                    ],
                    labelColor: Colors.black,
                  ),
                ),
              ),
              SliverTabView(
                precedingPinnedExtent: 48,
                children: [
                  SliverToBoxAdapter(
                    child: Container(
                      height: 2000,
                      color: Colors.red,
                      child: Placeholder(),
                    ),
                  ),
                  SliverToBoxAdapter(
                    child: Container(
                      height: 10000,
                      color: Colors.blue,
                      child: Placeholder(),
                    ),
                  ),
                  SliverToBoxAdapter(
                    child: Container(
                      height: 1000,
                      color: Colors.green,
                      child: Placeholder(),
                    ),
                  ),
                ],
                horizontalController: _horizontalController,
              ),
            ],
          ),
        ],
      ),
    );
  }
}

@MindMayhem you can check this one out. I'm curious what you think of it.

Note that I edited the example a bit to add a tab bar

@MindMayhem you can check this one out. I'm curious what you think of it.

Checked out it, seems like it works similar to SliverIndexedStack, but it using TabController for control, instead directly providing index
Honestly, i don't see difference between SliverIndexStack and SliverTabView
Sometimes using ValueNotifier will be more lightweight than using complex TabController with TickerProvider (which, for sure, doesn't used here)

@Kavantix  any update <3 ?

class Test extends StatefulWidget {
  const Test({super.key});

  static const String routeName = "catalog_choice_page";

  @override
  State<Test> createState() => _TestState();
}

class _TestState extends State<Test> with SingleTickerProviderStateMixin {
  late final TabController tabController;

  @override
  void initState() {
    super.initState();

    tabController = TabController(length: 2, vsync: this);
  }

  @override
  void dispose() {
    super.dispose();

    tabController.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return CustomScrollView(
      physics: const ClampingScrollPhysics(),
      slivers: <Widget>[
        SliverToBoxAdapter(
          child: Container(
            padding: const EdgeInsets.all(30),
            color: Colors.blue,
          ),
        ),
        SliverToBoxAdapter(
          child: Container(
            padding: const EdgeInsets.all(30),
            color: Colors.green,
          ),
        ),
        SliverToBoxAdapter(
          child: TabBar(
            controller: tabController,
            tabs: const <Widget>[
              Tab(text: "tab 1"),
              Tab(text: "tab 2"),
            ],
          ),
        ),
        SliverTabView(
          horizontalController: tabController,
          children: const <Widget>[
            SliverToBoxAdapter(
              child: Center(child: Text("Page 1")),
            ),
            SliverToBoxAdapter(
              child: Center(child: Text("Page 2")),
            ),
          ],
        ),
      ],
    );
  }
}

View is scrollable but it maybe should not because of the physics chosen in CustomScrollView().
By removing the SliverTabView(), the view is well not scrollable.

Hi @EArminjon I am not really planning on continuing this PR anytime soon as I currently have no need for this and didn't really hear from others.

Oh sad, need it for a complex UI with multiple TabbarView.


If I have a space in my catalog library name, the catalogs are broken

Version - 0.57.0-rc2
Steps:

Go to settings and add catalog Name = Tani Library, URL = https://github.com/tfiduccia/qa-catalog
Save
Go to Catalog and click on one of my catalogs

Results - First you can tell something is wrong because the images are not showing up on main catalog page.  Then if you click on one of them you get an error page.

Expected:  We should either not allow them to put spaces in Catalog Name or fix it so it works.

isn't this a dupe of #3124 ?

Yes, #3124


New version: REALiX.HWiNFO version 8.14

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Resolved https://github.com/microsoft/winget-pkgs/issues/188214

force pushed the update to release date

Automatic Validation ended with:

Executable C:\Program Files\HWiNFO64\HWiNFO64.EXE returned exit code: 183

(Automated response - build 897.)

Automatic Validation ended with:

Executable C:\Program Files\HWiNFO64\HWiNFO64.EXE returned exit code: 183

(Automated response - build 897.)

@stephengillie Excuse me for tagging, but what does this mean,
Does it mean that the application failed to launch?
I have run it in my machine started the program from cmd and i see no exit code: 183, what am i missing?

Hi @pr1sm8,
Sorry for the delay in responding. The validation pipeline is somewhat designed for Windows Forms, and add the https://github.com/microsoft/winget-pkgs/labels/Validation-Executable-Error link when the exit code is non-zero. But a non-zero exit code is common for CLI applications, so I usually pass exit codes below 1000. I"ve requested to push this upstream:

https://github.com/microsoft/winget-pkgs/issues/157749