HBASE-20904 Prometheus /metrics http endpoint for monitoring

Since all the metricsources have not moved to new metrics API, I added two servlets.
a. /prom (PrometheusServlet) uses the new metrics API.
b. /prom2 (PrometheusHadoop2Servlet) uses the old hadoop2 metrics API
PrometheusHadoop2Servlet can be thrown out once all the metricsources start using the new API.
Side note

Most of the servlet code for /prom2 code is cloned from HADOOP-16398

Hi! Can you comment on the jira issue so I can assign it to you?

@busbey I have commented on it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 17s
master passed

+1 :green_heart:
compile
0m 19s
master passed

+1 :green_heart:
shadedjars
6m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
shadedjars
6m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 40s
hbase-http in the patch failed.

26m 57s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b821b573037d 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 36a6ef9cf9

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-http.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/testReport/

Max. process+thread count
318 (vs. ulimit of 12500)

modules
C: hbase-http U: hbase-http

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 46s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
shadedjars
6m 33s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
hbase-http in the patch failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 32s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
shadedjars
6m 25s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
hbase-http in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-http in the patch passed.

25m 51s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7bbf5602824b 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 36a6ef9cf9

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/testReport/

Max. process+thread count
311 (vs. ulimit of 12500)

modules
C: hbase-http U: hbase-http

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 20s
master passed

+1 :green_heart:
checkstyle
0m 13s
master passed

+1 :green_heart:
spotbugs
0m 32s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-http: The patch generated 7 new + 7 unchanged - 0 fixed = 14 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m  4s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

27m  7s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle

uname
Linux 279238ebadbb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 36a6ef9cf9

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-http U: hbase-http

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@mmpataki  We have flakey tests.

@saintstack

@mmpataki We have flakey tests.

I am sorry, I ran tests from the IDE and not from mvn, so this build came up.

Looks good but we export protmetheus metrics even when they are not of use, not being accessed?

thank you for the review, I will add a configuration to enable it (disabled by default).
// I asked about this in mailing list but didn't get any responses.

added a missing update to hbase-default.xml

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  3s
master passed

+1 :green_heart:
compile
0m 41s
master passed

+1 :green_heart:
shadedjars
6m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
shadedjars
6m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 27s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 45s
hbase-http in the patch passed.

27m 36s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bf78431859eb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/testReport/

Max. process+thread count
418 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 30s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
shadedjars
6m 22s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 17s
hbase-http in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 44s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 46s
hbase-http in the patch passed.

30m 21s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9e0fcceafca7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/testReport/

Max. process+thread count
394 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
master passed

+1 :green_heart:
checkstyle
0m 38s
master passed

+0 :ok:
refguide
4m 52s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
1m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-http: The patch generated 8 new + 7 unchanged - 0 fixed = 15 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+0 :ok:
refguide
6m 33s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
14m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

48m 33s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux d868d88f27ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/3/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
shadedjars
5m 39s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 18s
hbase-http in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 35s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-http in the patch passed.

27m  5s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8af46a5e8c68 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/testReport/

Max. process+thread count
494 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 15s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
shadedjars
7m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 58s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
shadedjars
7m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 55s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 56s
hbase-http in the patch passed.

36m 22s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 765e79b8c24f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/testReport/

Max. process+thread count
412 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
checkstyle
0m 41s
master passed

+0 :ok:
refguide
5m 50s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
1m 27s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

-0 :warning:
checkstyle
0m 15s
hbase-http: The patch generated 8 new + 7 unchanged - 0 fixed = 15 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+0 :ok:
refguide
6m 32s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
13m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

48m 39s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux bf55af8f0ce0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Updated the conf key name in HttpServer.java

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  9s
master passed

+1 :green_heart:
compile
0m 41s
master passed

+1 :green_heart:
shadedjars
6m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
shadedjars
6m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 32s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 44s
hbase-http in the patch passed.

28m 37s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4c9c65445564 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/testReport/

Max. process+thread count
411 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 41s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
6m 46s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 17s
hbase-http in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 44s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 46s
hbase-http in the patch passed.

31m 52s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1cfe97d456e8 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/testReport/

Max. process+thread count
405 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 52s
master passed

+1 :green_heart:
checkstyle
0m 40s
master passed

+0 :ok:
refguide
4m 59s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
1m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 29s
the patch passed

-0 :warning:
checkstyle
0m 16s
hbase-http: The patch generated 8 new + 7 unchanged - 0 fixed = 15 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m  8s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m 26s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

42m 12s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux 9d94929b9e48 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b4a4debdd9

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sorry you didn't response on mailing list.
Yeah, i think it should be optional opt-in. We publish metrics on the /metrics servlet, we then also publish to jmx, we also ship metrics over the heartbeat to the master. Each formatting takes up resources -- mem, cpu -- so unless the prometheus custom interface is being consumed, lets not have the general service pay the price.

@saintstack I have made the changes, could you please review them.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
0m 44s
master passed

+1 :green_heart:
shadedjars
5m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
shadedjars
5m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 40s
hbase-http in the patch passed.

25m 17s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 96636e988c5e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/testReport/

Max. process+thread count
494 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  7s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
7m  4s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 18s
hbase-http in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m  6s
hbase-common in the patch passed.

+1 :green_heart:
unit
0m 57s
hbase-http in the patch passed.

34m 28s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 568fd4c3316b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/testReport/

Max. process+thread count
390 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
checkstyle
0m 39s
master passed

+0 :ok:
refguide
4m 56s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
1m 14s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-http: The patch generated 9 new + 7 unchanged - 0 fixed = 16 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 48s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m  8s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
1m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

40m 40s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux 3f1e3ecafe01 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-common hbase-http U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I should also note here that each change gets feedback currently from 3 different precommit checks (depending on the target branch) and different tests happen in them so it is very possible to get something that fails in only one of them. e.g. if you make a change that relies on JDK11 language features then you will get a failure in the jdk8 build and not in the jdk11 build.

I am not understanding this Apache pre-commit builds, why the build fails in first and succeeds in second attempt

@mmpataki The precommit job runs in three stages: (1) general static analysis, (2) jdk8 (maybe hadoop2, depending on branch), (3) jdk11-hadoop3

@busbey @saintstack  I am blocked because of this (HADOOP-17081) issue I reported today (I will fix it) and for now, trying to implement a hack, any suggestions are welcome.
Possible Hacks:

Register the sink when we want to read and unregister once done
Use the JMX API to get the metrics and write it (no need to use write a sink)

Also a question pops up in my mind.

Is it worth to write a exporter for hadoop2 metrics when it's decided to use the native metrics system?  Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 45s
the patch passed

+1 :green_heart:
compile
3m 16s
the patch passed

+1 :green_heart:
javac
3m 16s
the patch passed

+1 :green_heart:
shadedjars
6m 41s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 20s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-hadoop-compat in the patch failed.

-0 :warning:
javadoc
0m 17s
hbase-http in the patch failed.

-0 :warning:
javadoc
0m 16s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
19m 43s
root in the patch failed.

56m  3s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3672a94bc844 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/testReport/

Max. process+thread count
714 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
2m 39s
the patch passed

+1 :green_heart:
javac
2m 39s
the patch passed

+1 :green_heart:
shadedjars
6m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  8s
the patch passed

_ Other Tests _

-1 :x:
unit
25m 27s
root in the patch failed.

61m 31s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 032533770c69 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/testReport/

Max. process+thread count
787 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
master passed

+1 :green_heart:
checkstyle
1m 59s
master passed

+0 :ok:
refguide
5m  1s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
10m  6s
master passed

-0 :warning:
patch
8m 55s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

-0 :warning:
checkstyle
1m 59s
root: The patch generated 30 new + 7 unchanged - 0 fixed = 37 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 59s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m  1s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

-1 :x:
spotbugs
0m 45s
hbase-http generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
spotbugs
8m 37s
root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
asflicense
0m 52s
The patch generated 3 ASF License warnings.

63m 11s

Reason
Tests

FindBugs
module:hbase-http

Dead store to toRemove in org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:[line 89]

FindBugs
module:root

Dead store to toRemove in org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:[line 89]

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux e6d9294d3e89 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-general-check/output/patch-site/book.html

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-general-check/output/new-spotbugs-hbase-http.html

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-general-check/output/new-spotbugs-root.html

asflicense
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
137 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 54s
the patch passed

+1 :green_heart:
compile
3m 10s
the patch passed

+1 :green_heart:
javac
3m 10s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 23s
hbase-hadoop-compat in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-http in the patch failed.

-0 :warning:
javadoc
0m 14s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
20m 12s
root in the patch failed.

55m 59s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 67e07a33d230 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/testReport/

Max. process+thread count
843 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
2m 38s
the patch passed

+1 :green_heart:
javac
2m 38s
the patch passed

+1 :green_heart:
shadedjars
6m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
25m 43s
root in the patch failed.

61m 26s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ff5e4e00fb58 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/testReport/

Max. process+thread count
751 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
checkstyle
1m 56s
master passed

+0 :ok:
refguide
5m  2s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
10m 33s
master passed

-0 :warning:
patch
9m 24s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 29s
the patch passed

-0 :warning:
checkstyle
2m  3s
root: The patch generated 30 new + 7 unchanged - 0 fixed = 37 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 10s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m 19s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

-1 :x:
spotbugs
0m 44s
hbase-http generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
spotbugs
9m  7s
root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

63m 59s

Reason
Tests

FindBugs
module:hbase-http

Dead store to toRemove in org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:[line 89]

FindBugs
module:root

Dead store to toRemove in org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:org.apache.hadoop.hbase.http.prometheus.PrometheusHadoop2Servlet.renderMetrics(Collection)  At PrometheusHadoop2Servlet.java:[line 89]

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 8ae3054cc9c0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-general-check/output/patch-site/book.html

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-general-check/output/new-spotbugs-hbase-http.html

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/8/artifact/yetus-general-check/output/new-spotbugs-root.html

Max. process+thread count
137 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
2m 43s
the patch passed

+1 :green_heart:
javac
2m 43s
the patch passed

+1 :green_heart:
shadedjars
5m 42s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 19s
hbase-hadoop-compat in the patch failed.

-0 :warning:
javadoc
0m 17s
hbase-http in the patch failed.

-0 :warning:
javadoc
0m 15s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
11m 54s
root in the patch failed.

42m 26s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 97bae4a5889e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/testReport/

Max. process+thread count
746 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s
master passed

+1 :green_heart:
compile
2m 19s
master passed

+1 :green_heart:
shadedjars
5m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 53s
master passed

-0 :warning:
patch
8m 58s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
compile
2m 16s
the patch passed

+1 :green_heart:
javac
2m 16s
the patch passed

+1 :green_heart:
shadedjars
5m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 48s
the patch passed

_ Other Tests _

-1 :x:
unit
18m 14s
root in the patch failed.

49m 25s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux be3eb1c772ae 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/testReport/

Max. process+thread count
855 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 42s
master passed

+1 :green_heart:
checkstyle
2m 18s
master passed

+0 :ok:
refguide
5m 24s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
11m 22s
master passed

-0 :warning:
patch
10m  9s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

-0 :warning:
checkstyle
2m 16s
root: The patch generated 32 new + 7 unchanged - 0 fixed = 39 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 31s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
12m 22s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
11m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 43s
The patch does not generate ASF License warnings.

69m 10s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a91fa3badcfb 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
122 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/9/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s
master passed

+1 :green_heart:
checkstyle
1m 56s
master passed

+0 :ok:
refguide
4m 53s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
10m 11s
master passed

-0 :warning:
patch
1m  2s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

-0 :warning:
checkstyle
1m 55s
root: The patch generated 32 new + 7 unchanged - 0 fixed = 39 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 58s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m  8s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
10m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

62m 42s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 76cbe7b7b78d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
137 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey @saintstack I am blocked because of this (HADOOP-17081) issue I reported today (I will fix it) and for now, trying to implement a hack, any suggestions are welcome.
Possible Hacks:
1. Register the sink when we want to read and unregister once done

2. Use the JMX API to get the metrics and write it (no need to use write a sink)

Also a question pops up in my mind.
* Is it worth to write a exporter for hadoop2 metrics when it's decided to use the native metrics system? I have mixed answers, please comment on this.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 26s
the patch passed

+1 :green_heart:
compile
3m  1s
the patch passed

+1 :green_heart:
javac
3m  1s
the patch passed

+1 :green_heart:
shadedjars
6m 18s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 15s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 18s
hbase-hadoop-compat in the patch failed.

-0 :warning:
javadoc
0m 16s
hbase-http in the patch failed.

-0 :warning:
javadoc
0m 14s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
232m 57s
root in the patch passed.

267m 11s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9ce324749646 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/testReport/

Max. process+thread count
4765 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
2m 21s
the patch passed

+1 :green_heart:
javac
2m 21s
the patch passed

+1 :green_heart:
shadedjars
5m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 49s
the patch passed

_ Other Tests _

-1 :x:
unit
320m  8s
root in the patch failed.

352m 13s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ead9d112ce8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 500a1df379

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/testReport/

Max. process+thread count
5744 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/10/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Is it worth to write a exporter for hadoop2 metrics when it's decided to use the native metrics system? I have mixed answers, please comment on this.

This same question popped into my head. 😸  glad you found a work around, but I think a good argument could be made for just doing the native metrics. that said, I don't have the cycles right now to do a metrics review to make sure we have a good set to start with.

a glance shows the unit test failures are all in the backup/restore system? is that right?

a glance shows the unit test failures are all in the backup/restore system? is that right?

Yes, the test failures don't seem to be related. I will try to check them tomorrow.

a glance shows the unit test failures are all in the backup/restore system? is that right?

Yes the failures are in backup-restore component.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
checkstyle
1m 57s
master passed

+0 :ok:
refguide
4m 58s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
10m  9s
master passed

-0 :warning:
patch
9m  1s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

-0 :warning:
checkstyle
1m 55s
root: The patch generated 29 new + 7 unchanged - 0 fixed = 36 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m  2s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
10m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
10m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

62m 57s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 563604ed26d0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a7a0e1a596

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
137 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
3m  3s
the patch passed

+1 :green_heart:
javac
3m  3s
the patch passed

+1 :green_heart:
shadedjars
6m 21s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 15s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 18s
hbase-hadoop-compat in the patch failed.

-0 :warning:
javadoc
0m 16s
hbase-http in the patch failed.

-0 :warning:
javadoc
0m 13s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
240m 18s
root in the patch passed.

274m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b180c78c89f4 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a7a0e1a596

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/testReport/

Max. process+thread count
4471 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
compile
2m 17s
the patch passed

+1 :green_heart:
javac
2m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 49s
the patch passed

_ Other Tests _

-1 :x:
unit
298m 31s
root in the patch failed.

330m 49s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 86bf582967f0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a7a0e1a596

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/testReport/

Max. process+thread count
4225 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/11/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 25s
master passed

+1 :green_heart:
checkstyle
2m 22s
master passed

+0 :ok:
refguide
6m 18s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
12m  6s
master passed

-0 :warning:
patch
1m 13s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

-0 :warning:
checkstyle
1m 55s
root: The patch generated 29 new + 7 unchanged - 0 fixed = 36 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m  5s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
11m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

77m 19s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 3e41f925b1ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3bd54217a0

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
137 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
master passed

+1 :green_heart:
checkstyle
1m 56s
master passed

+0 :ok:
refguide
4m 45s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
10m 26s
master passed

-0 :warning:
patch
1m  9s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

-0 :warning:
checkstyle
1m 54s
root: The patch generated 29 new + 7 unchanged - 0 fixed = 36 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 58s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
10m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

63m 38s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 3652964bfb7e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3bd54217a0

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/branch-site/book.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
138 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 49s
the patch passed

+1 :green_heart:
compile
3m 14s
the patch passed

+1 :green_heart:
javac
3m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-hadoop-compat in the patch failed.

-0 :warning:
javadoc
0m 21s
hbase-http in the patch failed.

-0 :warning:
javadoc
0m 15s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
229m 26s
root in the patch failed.

266m 20s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1c6f0ebacc85 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3bd54217a0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/testReport/

Max. process+thread count
3216 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
2m 39s
the patch passed

+1 :green_heart:
javac
2m 39s
the patch passed

+1 :green_heart:
shadedjars
6m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
357m 47s
root in the patch failed.

394m 50s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1814

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a35c5e4bbecb 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3bd54217a0

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/testReport/

Max. process+thread count
2979 (vs. ulimit of 12500)

modules
C: hbase-common hbase-hadoop-compat hbase-http . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1814/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Implement multipart 'get all siblings in one request' functionality

Implement the multipart 'fetch all siblings with one HTTP GET' call.
http://docs.basho.com/riak/latest/dev/references/http/fetch-object/#Siblings-examples
Possibly requires Zinc HTTP library enhancement (sounds like it can't parse multipart responses, at this point), to implement support for 'Accept: multipart/mixed'.
See: RFC1341 - Multipart MIME type

Fortunately, turned out that Zinc handled multipart/mixed quite well.
The hard part was figuring out the tricky order of the Accept header: */*, multipart/mixed.


Error deploying resources: Access denied for 'DescribeKey' on AWS::KMS::Key

Describe the bug
I'm encountering an error when attempting to deploy resources using amplify push with the latest Amplify CLI. The error message is: "Unable to retrieve Arn attribute for AWS::KMS::Key, with error message Access denied for operation 'DescribeKey'."
Steps To Reproduce
Steps to reproduce the behavior:
1. Create AWS KMS using custom resources in Amplify.
2. Create Lambda functions that depend on KMS to decrypt existing secret.
3. Run amplify push to deploy the resources.
4. Observe the error message related to KMS permissions.

Expected behavior
The resources should deploy successfully without encountering permission issues.
Amplify Framework Version
2.44.0
Amplify Categories
API, Auth, DataStore, Storage
Dependency manager
Swift PM
Swift version
6.0.2
CLI version
12.13.1
Xcode version
16.1
Relevant log output
<details>
<summary>Log Messages</summary>

INSERT LOG MESSAGES HERE

```
Is this a regression?
Yes
Regression additional context
No response
Platforms
iOS
OS Version
iOS 18.1
Device
iphone 16
Specific to simulators
No response
Additional context
No response

Since this is related to being unable to push using the CLI, I'm transfering this to amplify-backend who owns the CLI tooling


flash: simulator: option to preserve RAM at boot

Add an option to not initialise the flash simulator memory at boot time. This allows the simulated flash device to persist across call to sys_reboot.

Question: this is only possible for devices that keep memory contents unmodified between resets?

Yes, if the memory contents are modified then this doesn't work.
It also doesn't work for the native_sim platforms because sys_reboot causes the sim to exit, not restart.
mps2/an385 was chosen because it is a simulated platform that can also run twister coverage tests.
The coverage tests are the point of this for me, I want to coverage test libraries that interact with the reboot API and NVS.

@JordanYates, the flash simulator also has an option to create the flash simulator in a memory region. This ensures that the location doesn't change.

@JordanYates, the flash simulator also has an option to create the flash simulator in a memory region. This ensures that the location doesn't change.

The location changing was not the issue, but the behavior of not erasing the RAM can be obtained by using the memory region. PR has been updated to just be a test for that functionality


Reel board custom config pyocd

Fixes #32966 (the fix is for the reel_board).
The PR

adds support in pyocd runner to attach a board-specific configuration file
use a board-specific pyocd.yaml file for reel_board, to pass configuration for the flash command

Looks good.
One consideration is that pyocd currently only supports one config file (multiple are on the todo list), so having a board-specific config file will preclude a user/project config file.

Looks good.
One consideration is that pyocd currently only supports one config file (multiple are on the todo list), so having a board-specific config file will preclude a user/project config file.

Is this something we could fix on the runner code? E.g. add logic so if both config files exist, pick the one that has precedence?

If this is something you're concerned about, it might be better to just implement multiple config file support in pyocd. (Of course I would say that! 😉) The hardest part would be handling --no-config mixed into the command line.
For now, this PR is probably fine as is. If needed, the user can use --tool-opt="--config=<path>" to override the config file path.