Tracing bookinfo sample doesn't work with fresh istio 1.1.1 install on GKE

Describe the bug
Traces from the bookinfo example (or other services) don't show up in the Jaeger tracing GUI.
Traces from the istio-ingress however do show up, but no other spans. (see image). This works when we deploy istio 1.0.6  to the same environment.
Expected behavior
We expect spans to show as per the example.
Steps to reproduce the bug

We created a new kubernetes 1.12 cluster on GKE with Network Policy Enabled
We install istio with the settings listed below using helm template
We installed the bookinfo sample + bookinfo ingress.
We curled the endpoint multiple times as per the sample curl request.

Version
istioctl version --remote
client version: version.BuildInfo{Version:"1.1.2", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989", User:"root", Host:"35adf5bb-5570-11e9-b00d-0a580a2c0205", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Clean", GitTag:"1.1.1"}
citadel version: version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989-dirty", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.1.0-17-g2b13318"}
galley version: version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989-dirty", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.1.0-17-g2b13318"}
ingressgateway version: version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Clean", GitTag:"1.1.0-17-g2b13318"}
pilot version: version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989-dirty", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.1.0-17-g2b13318"}
policy version: version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989-dirty", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.1.0-17-g2b13318"}
sidecar-injector version: version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989-dirty", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.1.0-17-g2b13318"}
telemetry version: version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989-dirty", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.1.0-17-g2b13318"}

Installation

Downloaded the istio 1.1.1 release
Installed istio_cni, ran istio-init, and installed istio using helm template + the following values file

tracing:
  enabled: true
kiali:
  enabled: true
istio_cni:
  enabled: true
pilot:
  traceSampling: "100"
global:
  proxy:
    accessLogFile: /dev/stdout

(note, the accessLogFile setting doesn't work, see #13051)
Environment
Google GKE v1.12.6-gke.7 + Container Optimized OS
Cluster state

istio-dump.tar.gz

Have you tried without CNI?  I verified tracing working without CNI in several test clusters in the run up to 1.1.X. Perhaps there is something broken with the CNI-related setup?

@douglas-reid I have not, no. Realistically that's most likely the issue since that was the only change to our setup (other than upgrading to 1.1.1 of course)
That said, if CNI is breaking it, it still needs a proper fix as PSP is needed in our environment so we can't roll out to production until we can use CNI for now.

@douglas-reid I ran two separate tests in two freshly created GKE clusters (Kubernetes 1.12.10) having Istio 1.1.1 installed. One cluster has CNI enabled and another has it disabled. Both clusters had the bookinfo sample installed in the default namespace with istio-injection=enabled.
The Jaeger on the cluster with CNI could only see istio-ingressgateway traces, while the Jaeger on the other could see all the services.

/cc @howardjohn who has done some testing with CNI on GKE.
Is it possible that something is incorrect with your CNI install?  I know that the one time I tried, I was using outdated instructions and nothing was working (no traffic was going through the proxies).

@edude03 @dingxiangfei2009 can you confirm that you don't have the issue discussed here: https://github.com/istio/istio/issues/11638#issuecomment-482188415 ?

Just tested. With CNI I had access logs. I suspect tracing issue is same as access log. Can you run:
kubectl get daemonset -n istio-system
kubectl describe pod PRODUCTPAGEPOD # or some other pod you expect logging from

The CNI daemonset is running.
kubectl get daemonset -n istio-system produces the following.
NAME             DESIRED   CURRENT   READY     UP-TO-DATE   AVAILABLE   NODE SELECTOR                 AGE
istio-cni-node   7         7         7         7            7           beta.kubernetes.io/os=linux   33m

kubectl describe pod -l app=productpage produces the following.
Name:               productpage-v1-6597cb5df9-jzqdb
Namespace:          default
Priority:           0
PriorityClassName:  <none>
Node:               gke-istio-cni-test-pool-1-ed6560b8-8gj2/<IP_ADDRESS>
Start Time:         Wed, 17 Apr 2019 12:39:54 +0800
Labels:             app=productpage
                    pod-template-hash=6597cb5df9
                    version=v1
Annotations:        cni.projectcalico.org/podIP=<IP_ADDRESS>/32
                    kubernetes.io/limit-ranger=LimitRanger plugin set: cpu request for container productpage
                    sidecar.istio.io/status={"version":"10a671b31a5e531c88e94f9f741b8f10a409c838b3dcd9302b7514862e4a7b4c","initContainers":null,"containers":["istio-proxy"],"volumes":["istio-envoy","istio-certs"],"imageP...
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      ReplicaSet/productpage-v1-6597cb5df9
Containers:
  productpage:
    Container ID:   docker://2f9becdd4a05a37576bb8c0601073e0be606b5c4f5343259bd15f0ad0ca59e43
    Image:          istio/examples-bookinfo-productpage-v1:1.10.1
    Image ID:       docker-pullable://istio/examples-bookinfo-productpage-v1@sha256:a427e10277a814b27c066d9ea5f2605b656fc1948714ed09e55c97342c5a721d
    Port:           9080/TCP
    Host Port:      0/TCP
    State:          Running
      Started:      Wed, 17 Apr 2019 12:40:35 +0800
    Ready:          True
    Restart Count:  0
    Requests:
      cpu:        100m
    Environment:  <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-9gqj8 (ro)
  istio-proxy:
    Container ID:  docker://c867221bd163f678b3d44d997b730c399626fc4c8cd8a94dd4007c0e9a3aa673
    Image:         docker.io/istio/proxyv2:1.1.1
    Image ID:      docker-pullable://istio/proxyv2@sha256:ca41c2c715db0bf2369f892451008a631de6af519ad0bebf3e657bcbb5afb9df
    Port:          15090/TCP
    Host Port:     0/TCP
    Args:
      proxy
      sidecar
      --domain
      $(POD_NAMESPACE).svc.cluster.local
      --configPath
      /etc/istio/proxy
      --binaryPath
      /usr/local/bin/envoy
      --serviceCluster
      productpage.$(POD_NAMESPACE)
      --drainDuration
      45s
      --parentShutdownDuration
      1m0s
      --discoveryAddress
      istio-pilot.istio-system:15010
      --zipkinAddress
      zipkin.istio-system:9411
      --connectTimeout
      10s
      --proxyAdminPort
      15000
      --concurrency
      2
      --controlPlaneAuthPolicy
      NONE
      --statusPort
      15020
      --applicationPorts
      9080
    State:          Running
      Started:      Wed, 17 Apr 2019 12:40:48 +0800
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     2
      memory:  128Mi
    Requests:
      cpu:      100m
      memory:   128Mi
    Readiness:  http-get http://:15020/healthz/ready delay=1s timeout=1s period=2s #success=1 #failure=30
    Environment:
      POD_NAME:                      productpage-v1-6597cb5df9-jzqdb (v1:metadata.name)
      POD_NAMESPACE:                 default (v1:metadata.namespace)
      INSTANCE_IP:                    (v1:status.podIP)
      ISTIO_META_POD_NAME:           productpage-v1-6597cb5df9-jzqdb (v1:metadata.name)
      ISTIO_META_CONFIG_NAMESPACE:   default (v1:metadata.namespace)
      ISTIO_META_INTERCEPTION_MODE:  REDIRECT
      ISTIO_METAJSON_ANNOTATIONS:    {"kubernetes.io/limit-ranger":"LimitRanger plugin set: cpu request for container productpage"}

      ISTIO_METAJSON_LABELS:  {"app":"productpage","pod-template-hash":"6597cb5df9","version":"v1"}

    Mounts:
      /etc/certs/ from istio-certs (ro)
      /etc/istio/proxy from istio-envoy (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-9gqj8 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  default-token-9gqj8:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-9gqj8
    Optional:    false
  istio-envoy:
    Type:    EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:  Memory
  istio-certs:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  istio.default
    Optional:    true
QoS Class:       Burstable
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason     Age   From                                              Message
  ----     ------     ----  ----                                              -------
  Normal   Scheduled  6m    default-scheduler                                 Successfully assigned default/productpage-v1-6597cb5df9-jzqdb to gke-istio-cni-test-pool-1-ed6560b8-8gj2
  Normal   Pulling    6m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  pulling image "istio/examples-bookinfo-productpage-v1:1.10.1"
  Normal   Pulled     5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  Successfully pulled image "istio/examples-bookinfo-productpage-v1:1.10.1"
  Normal   Created    5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  Created container
  Normal   Started    5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  Started container
  Normal   Pulling    5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  pulling image "docker.io/istio/proxyv2:1.1.1"
  Normal   Pulled     5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  Successfully pulled image "docker.io/istio/proxyv2:1.1.1"
  Normal   Created    5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  Created container
  Normal   Started    5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  Started container
  Warning  Unhealthy  5m    kubelet, gke-istio-cni-test-pool-1-ed6560b8-8gj2  Readiness probe failed: HTTP probe failed with statuscode: 503

Also, kubectl describe pod <one-of-istio-cni-node> -n istio-system produces this.
Name:               istio-cni-node-7jh6t
Namespace:          istio-system
Priority:           0
PriorityClassName:  <none>
Node:               gke-istio-cni-test-default-pool-a51996af-z5sd/<IP_ADDRESS>
Start Time:         Wed, 17 Apr 2019 12:19:59 +0800
Labels:             controller-revision-hash=5f98c8dc59
                    k8s-app=istio-cni-node
                    pod-template-generation=1
Annotations:        scheduler.alpha.kubernetes.io/critical-pod=
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      DaemonSet/istio-cni-node
Containers:
  install-cni:
    Container ID:  docker://a2aec57e75f04730704b26584a1c071bd8548cb21451d94de5c425f69aff2a4c
    Image:         gcr.io/istio-release/install-cni:master-latest-daily
    Image ID:      docker-pullable://gcr.io/istio-release/install-cni@sha256:f61f6cbef226fd0ca45f3784b70cbdea09061e190563b1eec0b2b74e09317ee3
    Port:          <none>
    Host Port:     <none>
    Command:
      /install-cni.sh
    State:          Running
      Started:      Wed, 17 Apr 2019 12:20:01 +0800
    Ready:          True
    Restart Count:  0
    Environment:
      CNI_NETWORK_CONFIG:  <set to the key 'cni_network_config' of config map 'istio-cni-config'>  Optional: false
    Mounts:
      /host/etc/cni/net.d from cni-net-dir (rw)
      /host/opt/cni/bin from cni-bin-dir (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from istio-cni-token-cv2k7 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  cni-bin-dir:
    Type:          HostPath (bare host directory volume)
    Path:          /home/kubernetes/bin
    HostPathType:
  cni-net-dir:
    Type:          HostPath (bare host directory volume)
    Path:          /etc/cni/net.d
    HostPathType:
  istio-cni-token-cv2k7:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  istio-cni-token-cv2k7
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  beta.kubernetes.io/os=linux
Tolerations:     :NoSchedule
                 :NoExecute
                 CriticalAddonsOnly
                 node.kubernetes.io/disk-pressure:NoSchedule
                 node.kubernetes.io/memory-pressure:NoSchedule
                 node.kubernetes.io/network-unavailable:NoSchedule
                 node.kubernetes.io/not-ready:NoExecute
                 node.kubernetes.io/unreachable:NoExecute
                 node.kubernetes.io/unschedulable:NoSchedule
Events:
  Type    Reason     Age   From                                                    Message
  ----    ------     ----  ----                                                    -------
  Normal  Scheduled  43m   default-scheduler                                       Successfully assigned istio-system/istio-cni-node-7jh6t to gke-istio-cni-test-default-pool-a51996af-z5sd
  Normal  Pulling    43m   kubelet, gke-istio-cni-test-default-pool-a51996af-z5sd  pulling image "gcr.io/istio-release/install-cni:master-latest-daily"
  Normal  Pulled     43m   kubelet, gke-istio-cni-test-default-pool-a51996af-z5sd  Successfully pulled image "gcr.io/istio-release/install-cni:master-latest-daily"
  Normal  Created    43m   kubelet, gke-istio-cni-test-default-pool-a51996af-z5sd  Created container
  Normal  Started    43m   kubelet, gke-istio-cni-test-default-pool-a51996af-z5sd  Started container

@howardjohn How did you set up the GKE test cluster? Are the tests running on a freshly created cluster?
My installation instruction is described in #13051, which is mostly taken from https://istio.io/docs/setup/kubernetes/additional-setup/cni/ and https://preliminary.istio.io/docs/setup/kubernetes/install/helm/, with helm template exclusively. I am not installing the Istio provided by Google.

Ok so the problem isn't tracing or logging, this is a CNI is not creating iptables issue. Thanks for the debugging. When you set up your GKE cluster did you enable network policy? This looks like a little checkmark in the advanced settings that says "Enable network policy" if you use the UI. This is required for CNI.
The other thing for GKE is you need to set --set cniBinDir=/home/kubernetes/bin, but I think you would see explicit errors from the CNI node if you didn't so probably not the issue. (see https://istio.io/docs/setup/kubernetes/additional-setup/cni/#gke-setup)

@howardjohn Yes, network policy is enabled according to gcloud container clusters describe:
networkPolicy:
  enabled: true
  provider: CALICO

Also, I have --set cniBinDir=/home/kubernetes/bin in helm template. Logs from the pods in the istio-cni-node DaemonSet can confirm that this setting is in effect.
Removing existing binaries
Wrote Istio CNI binaries to /host/opt/cni/bin
/host/secondary-bin-dir is non-writeable, skipping
Using CNI config template from CNI_NETWORK_CONFIG environment variable.
CNI config: {
  "type": "istio-cni",
  "log_level": "debug",
  "kubernetes": {
      "kubeconfig": "/etc/cni/net.d/ZZZ-istio-cni-kubeconfig",
      "cni_bin_dir": "/home/kubernetes/bin",
      "exclude_namespaces": [ "istio-system" ]
  }
}
Created CNI config 10-calico.conflist
Done configuring CNI.  Sleep=true

I have sshed into the instances, and in each of the instances istio-cni has been placed in /home/kubernetes/bin folder.

According to https://github.com/containernetworking/cni/blob/ec5ec68fa4979e8f98c13845dbc2352380ad179b/libcni/conf.go#L70, cni cannot find the name field in 10-calico.conflist, but it is there.
@edude03 should we create a separate issue for this?

@tiswanso @john-a-joyce can you guys provide any insight here?

And thanks for all the debugging so far, very thorough and useful

Tim or I can take a detailed look at the debugging you have above.   FWIW a few quick notes. There is a prow job that runs with CNI enabled on every PR.   You can look at prow/e2e-simpleTests-cni.sh.   In theory that should ensure Istio, Istio CNI and GKE (prow) stay aligned.  Additionally, I have a PR in flight that should allow an easy way to run the bookinfo e2e test on GKE.  It is https://github.com/istio/istio/pull/12529.   This would allow you a quick way to repeat test scenarios.   On caveat I have tested it in numerous scenarios but I have not specifically tested it on GKE with the bookinfo tests.

Please share the contents of 10-calico.conflist on the GKE node/s with the error.

{
  "name": "k8s-pod-network",
  "cniVersion": "0.3.0",
  "plugins": [
    {
      "type": "calico",
      "mtu": 1460,
      "log_level": "warning",
      "datastore_type": "kubernetes",
      "nodename": "gke-istio-cni-test-pool-1-ed6560b8-5qf6",
      "ipam": {
        "type": "host-local",
        "subnet": "usePodCidr"
      },
      "policy": {
        "type": "k8s",
        "k8s_auth_token": "<redacted>"
      },
      "kubernetes": {
        "k8s_api_root": "https://<IP_ADDRESS>:443",
        "kubeconfig": "/etc/cni/net.d/calico-kubeconfig"
      }
    },
    {
      "type": "portmap",
      "capabilities": {"portMappings": true},
      "snat": true
    }
  ]
}

@edude03 --thanks for the update.  It looks like the istio-cni plugins config portion either didn't get applied OR it got removed/clobbered by calico.  This condition should be detected by the install-cni daemon on that node and the config reapplied--here's the check:  https://github.com/istio/cni/blob/master/deployments/kubernetes/install/scripts/install-cni.sh#L64-L73
Is the kubectl log output you shared above for the same node as the effected one/s (where the 10-calico.conflist file has no istio-cni entry in the plugins list)?  If not, please include that output.

Ok, playing around on GKE with istio-cni, it looks like the fixes for detecting removal of the istio-cni CNI config from the plugins list aren't working correctly on GKE: https://github.com/istio/cni/issues/82 and/or https://github.com/istio/cni/pull/86
If I manually remove the istio-cni plugins list entry from a node's CNI config, the install-cni pod doesn't detect it and exit (restart) and reapply.  I will try to figure out why that is BUT
workaround is to manually restart the istio-cni pod for the node, ie. kubectl delete pod -n istio-system istio-cni-node-v28rd.
@edude03 potentially the nodes got into this state due to something like

node restart after istio-cni and calico daemonsets are installed, ie. enabling network-policy on GKE after istio-cni is already installed.
adding nodes after istio-cni and calico daemonsets are installed

Root-cause:  the gcr.io/istio-release/install-cni:master-latest-daily images are built with an older version of istio-cni.  Need to update the istio.deps SHA to pick up new stable version

Would this be fixed by merging https://github.com/istio/istio/pull/13549

@howardjohn -- Yes... I didn't see that and posted a different PR.  I'll close mine if that's going to be the way to go for this.

Those prs haven't been merged in a long time, need to bug owners


Add merged_with method for two Clifford tableau

The preparation step for making general Clifford Gates #3639.
The basic logic of implementation is tracking the transformation of all generators of Pauli group. Namely, list the transform of first tableau:U_1X_iU_1' = r_i \Prod_j X_j^{t_(i,j)} Z_i^{s_(i,j)} and list the same thing for second tableau U_2, then combining them.
With this method, it will allow us to build other unnamed Clifford Gates by composition.

I can't speak to code correctness, I assume you've gotten that part right. Added some style points. Could you also expand on this PRs description: how will this contribute towards the linked issue?

Add more context in the description. Addressed the most comment and rename the function according to the Cyqn meeting votes. PTAL, thanks.

This looks good, I still have to parse the phase correction logic.

The steps were modified by myself. (Different from Qiskit did by killing one-for loop) So Let me add an example here for the record about the phase correction. Each step in the code are corresponding to following cases:

Looks good to me. Added a minor comment regarding the array types.

Hi Smit, I have tried the NumPy matrix multiplication with bool type. I don't think it is equivalent to matrix multiplication with int type then do the modulo 2. Try this simple example:
t = np.array([[1, 0], [1,1]], dtype=bool)
z = np.array([[1, 1], [1,0]], dtype=bool)
print((t @ z).astype(int))
print(np.mod(t.astype(int) @ z.astype(int), 2))

The first one is an all 1 matrix and the second one is not.

The first one is an all 1 matrix and the second one is not.

Thanks! That makes sense. The bool one is doing OR instead of + in the matrix multiplication.


Find a replacement for sourceGUID

Originally reported by Hrishikesh Ballal (Bitbucket: hrishiballal, GitHub: hrishiballal)

There are a few open questions around sourceGUID, How will sourceGUID will be managed?

Most sensors have a MAC address that gives it uniqueness and therefore

How to accommodate sensors without MAC addresses?

16-bytes gives you a lot of sources, are they enough?

GUID has to be sent with every transmission

Is the tradeoff worth it? With very large UVIN?

Some of these sensors will be in the air.

GUID + Lat + Lon is a good unique stamp.

We leave GUID as it is as a start, need to keep a eye on it.

Bitbucket: https://bitbucket.org/hrishiballal/airtraffic-data-protocol-development/issue/1

Maybe aggregate sourceGUID-collections that come from some trusted/known source?

@overlandla  Thank you for your message, yes that is a good idea, but how to know which source should be trusted? Maybe its possible in a InterUSS environment but how about otherwise?


Is there any difference between auto calibration and online calibration w.r.t lidar2imu?

It seems to me that both auto calibration methods and online methods of lidar2imu need lidar pcds and imu poses input. What the difference between them? I think online calibration can run without any input, right?

It seems to me that both auto calibration methods and online methods of lidar2imu need lidar pcds and imu poses input. What the difference between them? I think online calibration can run without any input, right?

Automatic calibration requires users to collect calibration data as required, while online calibration does not. Both of these require sensor data input.

But I see that the online calibration tool also need some sensor data input files as the starting parameters. Are theses input files the same as ones of auto calibration?


errors on Conan entt/3.x.y-WIP@skypjack/stable

Hello,
I have used this sample code from : leinnan.github.io
i use Entt with conan and these errors appears:
error: static_assert failed
    static_assert(sizeof...(Component) > 1);

error: no member named 'each' in 'entt::view<unsigned int>'
    registry.view().each([dt](const auto, auto &pos, auto &vel) {

error: declaration of variable 'registry' with deduced type 'entt::registry' requires an initializer

Thanks for reply.

The first two errors are because you you didn't pass the component types to registry::view. The example you found is broken. I suspect the < > were being parsed as HTML so they disappeared. See the wiki and the README for working examples. Also see the EnTT in Action section for projects an articles about EnTT.
To fix the first two errors, try registry.view<position, velocity>(). For the third error, try entt::registry<> registry;.

The errors are in the blog post you linked. @Kerndog73 correctly pointed out the solutions. Ask the author to fix them. Thanks.


fix link on root README.md

LGTM

I thought there was another PR on this -- other links are broken in this file, too....

There was #11295 but #11352 went in first with all the fixes from that PR. These are the remaining broken links and were not fixed in either of those PRs

OK. LGTM. Thanks for fixing the overview link.


Updated auto unlock script for LND 0.5

Added and changed some lines to make the autounlock able to work on LND0.5. I made a pull this pull request on the basis of the proposed adaptations of issue#254 by @zwarbo. I also used a piece of code from the pull request of issue#246 submitted by @martinatime to check for testnet/mainnet.
(I also added the contributers of this commit to the file, as the original writers were mentioned aswell. Not sure if this is ok. )

At the moment, the unlock script is hard-coded for LND 0.5 mainnet, which works fine. I'd welcome the change to make it also work on testnet, but unfortunately your approach builds on undefined variables (originating in the welcome script?). The unlock-script should run standalone, otherwise there are too many dependencies and potential for errors.

@Stadicus Tnx for the feedback (on my sloppy mistake)! I reworked the edit and hope you like it :)

Thanks for the update, looks great. I just added some changes that have been merged in the last few days.


Add support for virtblk type block devices as valid disks for pool creation

Describe the bug
I am trying to setup mayastor on a ubuntu VM running in KVM, the disk that I want to add is /dev/vdb, however kubectl get mayastor block-devices   does not list this device. Tough I can create the diskpool with this device.
If I do a call with the --all flag I get:
/dev/vdb    disk       2TiB      no                       /devices/pci0000:00/0000:00:02.4/0000:05:00.0/virtio3/block/vdb            252     16                                             "/dev/disk/by-path/pci-0000:05:00.0", "/dev/disk/by-path/virtio-pci-0000:05:00.0"
To Reproduce
Setup mayastor on KVM VM
Expected behavior
block-devices should show the available disks.
Screenshots
block devices in  /proc/devices
Block devices:
7 loop
8 sd
9 md
11 sr
65 sd
66 sd
67 sd
68 sd
69 sd
70 sd
71 sd
128 sd
129 sd
130 sd
131 sd
132 sd
133 sd
134 sd
135 sd
252 virtblk
253 device-mapper
254 mdp
259 blkext
And vdb is using 252.
$ ls -l /dev/block |grep vdb
lrwxrwxrwx 1 root root 6 Sep 12 10:32 252:16 -> ../vdb
** OS info (please complete the following information):**

Distro: Ubuntu
Kernel version
MayaStor revision or container image :2.5.1

Additional context
Add any other context about the problem here.

This is now available as of 2.7.1


Change backbone finetuning strategy to allow for DDP

See lightning-ai/pytorch-lightning#20340 for the original issue. The implemented workaround no longer freezes/unfreezes layers via require_grad, instead we only modulate the learning rate of the backbone layer.
Unblocks #138

Run with and without code changes:


[Low Priority] Provide guidance on using nvm with version control systems to help newer programmers

Operating system and version:
macOS Catalina 10.15.2
Terminal 2.10
nvm debug output:
N/A
nvm ls output:
N/A
How did you install nvm?
Via Homebrew.
What steps did you perform?
Installed and began utilizing nvm.
What happened?
I attempted to find recommendations regarding using nvm in conjunction with Git. Popular search engines were surprisingly unable to find any recommendations or examples, beyond the .gitignore present in the nvm repo itself.
What did you expect to happen?
It would be great if a small section in the README provided guidance for using nvm with a VCS. This could help new programmers (whether they are new in general, or just new to Node.js, nvm, etc.) who cannot easily infer what to do with their .gitignore file (or similar for other VCS) following the installation of nvm. Without guidance of this sort, one is left to assume that no modifications should be made to the relevant VCS file following the install of nvm and the relevant version(s) of Node for the project, which could lead to confusion when the individual sees many new files as a result of installing and utilizing nvm (ex: nvm/versions/...).
Is there anything in any of your profile files that modifies the PATH?
N/A

I'm not sure what guidance you need; nvm supports a .nvmrc file you can include in your repo, so that nvm use and nvm install automatically pick up the proper version.
nvm itself is like git itself; a precondition expected to be installed on the user's system before using a project.

Thank you for the response @ljharb.
I primarily mean guidance in regards to all the files generated for multiple node versions within a project (nvm/versions/... within that project's directory). With a few installed versions, the number of files and their organization reminded me of the contents of node_modules/ (while thinking within the context of Node.js), which we know you typically don't want to track via your VCS.
If desired, perhaps the following note would suffice?

All files generated by or created for nvm within your project (e.g., .nvmrc, nvm/versions/...) should be tracked within your project and thus should NOT be added to your .gitignore file (or similar for other VCS).

Regardless of whether you deem this information relevant enough to be included in the README or not, thank you for all of your work enabling & furthering this great tool!

Ah, I’m suggesting the opposite - nvm and all its node versions should never be inside a single project; only at user level inside NVM_DIR.

@ljharb Gotcha, thank you. Your recommendation makes sense, especially when considering how much cleaner the install is with several projects on the same machine. My apologies for the confusion!


feat(FMS): New Service FMS and Check fms_accounts_compliant

Context
New service FMS with check fms_accounts_compliant: Ensure that all FMS accounts are compliant
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Nice job, please check it out the comments !!

Accept both latest suggestions and it is all done, nice job !!!


Use standard archive/tar instead of docker's untar implementation

!!! Note that this PR is implemented based in another !!!
The only 2 exclusive files on this PR are:

internal/packager/packing_test.go
internal/tar/untar.go

- What I did
Substitute docker's untar package with a standard golang implementation
- How I did it
Adapted an implementation of untar to fit our needs and use it in TestPackInvocationImageContext
- How to verify it
Tests on packing_test.go passing without the need of running inside a container (just with make test and not make -f docker.Makefile test)
- Description for the changelog
Substitute docker's untar package with a standard golang implementation
- A picture of a cute animal

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "std-untar" git@github.com:ulyssessouza/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354524928
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@vdemeester The long story is that:

What are the reasons behind moving away form github.com/docker/docker/pkg/archive ?

The idea is to be able to run this test with just a make test and not make -f docker.Makefile test the first runs in the host and the second will be executed inside a container.
The problem of using github.com/docker/docker/pkg/archive here is that it assumes it's inside a container. Like when assuming that infos about UID and GID are located in /etc/subuid and /etc/subgid (as in idtools.go:L33-34)

If it's related to lchown, I'm pretty sure using TarOptions field NoLchown should work.

That was my first guess. The problem here is that according to idtools.go:L55 it not chown the exisiting files, but will systematically do it for the new ones.
The TarOptions::NoLchown is just used in archive.go:L651 that will prevent the os.Lchown in archive.go:L655 to be executed, but not the firstly described.

If not, I still believe it's better to fix/contribute upstream (it's even in the same docker org…) that duplicate this code.

My concern with this is that from what it looks, github.com/docker/docker/pkg/archive was built to be used in a different environment, which seems to be inside a container where it can read /etc/sub{uid|gid} to retrieve the user and group. Without this assumption, it should retrieve the username and group for different OSs, and also docker-app is compiled without CGO, so even a user.Current() work. So all of this makes me think its not buggy, but just thought to be used in a different context.
Given that, one possibility of contribution for the upstream would be add a new func in idtools.go which is similar to MkdirAllAndChownNew (given that it's a public func I cannot just change it's signature) that tells mkdirAs (having as side-effect the change of it's signature) to not chown even the new files. That would work.
Talking with @silvin-lubecki, he came with a simplier solution, that consists in just iterate through the entries in the archive, instead of really extracting and iterating through it.
This solution seems to be cleaner for our needs.

We should probably be careful replacing this package; there may be special cases for backward compatibility in this package @tonistiigi @dmcgowan

@vdemeester And what about now?
I just pushed a simple solution described in the last paragraph of last message.

The build fails
[Build Invocation image] Failed in branch Build Invocation image
[Validate] (84/87) Failed to write<EMAIL_ADDRESS>[Validate] (85/87) Failed to write<EMAIL_ADDRESS>[Validate] (86/87) Failed to write<EMAIL_ADDRESS>[Binaries] GOOS=darwin CGO_ENABLED=0 go build -tags="" -ldflags="-s -w -X github.com/docker/app/internal.GitCommit=9d03e79 -X github.com/docker/app/internal.Version=9d03e790c7 -X github.com/docker/app/internal.Experimental=off -X github.com/docker/app/internal.BuildTime=2018-12-28T12:18:51Z" -o bin/docker-app-darwin ./cmd/docker-app
[Validate] (87/87) Failed to write<EMAIL_ADDRESS>[Validate] grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export github.com/deis/duffle:
[Validate] 	(1) failed to list versions for<EMAIL_ADDRESS>fatal: cannot run ssh: No such file or directory
[Validate] fatal: unable to fork
[Validate] : exit status 128
[Validate]
[Validate] make: *** [Makefile:93: vendor] Error 1
[Validate] docker.Makefile:106: recipe for target 'vendor' failed
[Validate] make: *** [vendor] Error 2

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "std-untar" git@github.com:ulyssessouza/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357813216
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Closing it since it has been merged by #443


improve error handling

Use thiserror to avoid implementing Error trait manually.
Box has performance overhead, and this PR removes it.

Eliminating the use of Box is great, but are there any advantages to using thiserror here?

To simplify trait implementation of error and reduce the large match expression.

I prefer to keep the dependencies minimal.

Awesome.


pod installation issue

I can think of two possible solutions, either remove pod 'SDWebImage' from Podfile since ImageSlideshow/SDWebImage will install it automatically. Or you can try pod update, the latest version of ImageSlideshow, 1.5.1, should be compatible with SDWebImage 4.


Error when using docker-compose

ERROR: Invalid interpolation format for "backend" option in service "services": "OLLAMA_HOST=${OLLAMA_HOST:-http://localhost:11434}"
 ERROR: Invalid interpolation format for "backend" option in service "services": "ENABLE_LOCAL_MODELS=${ENABLE_LOCAL_MODELS:-True}"
Getting these error when trying your docker-compose.dev.yml file.
Anything I have done wrong?

The docker-compose file has been updated and there is now a .env-template. I've updated the README instructions. Let me know if you are still having issues.


Fix over-optimistic log message.

"Wrote task log" could be logged before the output stream is flushed and
closed, which could generate an error and not actually write the log.

👍

:+1:


Do not duplicate the code for deployer setup

@jgu17 I removed the cloud config file change. Still keeping OSH files as the only one, as they include at least this change https://github.com/SUSE-Cloud/socok8s/pull/259
Anyway, we could base it on airship files if you think it's better

duplicating my comment here from the chat:
why not create a simple role for client apps that include helm and kubectl + maybe other optional apps like kubebox[0], kube-ops-view[1] or kubectx[2]
[0] https://github.com/astefanutti/kubebox
[1] https://github.com/hjacobs/kube-ops-view
[2] https://github.com/ahmetb/kubectx

@Itxaka sure, but that's out of scope of this PR. Actually I think Jira ticket for such work should be created

@jgu17 I removed the cloud config file change. Still keeping OSH files as the only one, as they include at least this change #259
Anyway, we could base it on airship files if you think it's better

@jsuchome I still prefer to base the file in the airship-setup-deployer role for two reasons: 1) the airship-setup-deployer is more specific/modular in what it does than deploy_osh, and it was created with the purpose for deploy-osh nd deploy-airship toles to share and reuse code in mind; (2) deploy_osh has a lot of things in it fpr helm developers and have deploy_airship to reference that seems not as clean.

@jgu17 ok, I will rework it so it is the other way

I would just put things into a single role which can be reused for both parts.

I would just put things into a single role which can be reused for both parts.

Agreed with JP here. airship_setup_deployer is set for this purpose (we can rename it to reflect that is a shared role by airship and osh).

Closing in favor of https://github.com/SUSE-Cloud/socok8s/pull/281


Generates seemingly pointless "page1" directory

When running hugo, the generated output contains the file page1/index.html which seems to serve no purpose and doesn't seem to be referenced from anywhere else. Its contents are:
<!DOCTYPE html><link rel="canonical" href="http://www.example.com/"/><meta http-equiv="content-type" content="text/html; charset=utf-8" /><meta http-equiv="refresh" content="0;url=http://www.example.com/" />

/page/1/index.html redirects to / but the built-in paginator is smart enough to link directly to home, so you're right it's not needed.
That said, this is core pagination behaviour and cannot be controlled in themes; try reporting this to the main Hugo repo.


Improved alignParameters handling should be opt-in

alignParameters handling was expanded in the daniel-trinh fork to include aligning equals signs and default values.
This should possibly be hidden behind an option per #142 .

Should this be milestone 1.0, @sschaef / @fommil ? It's an improvement to an existing opt-in feature, but I notice that @jrudolph disabled alignParameters in https://github.com/akka/akka/pull/19936 , probably for this reason.

To visualize what I'm talking about, here's an example from akka:
diff --git a/akka-actor/src/main/scala/akka/routing/ConsistentHashing.scala b/akka-actor/src/main/scala/akka/routing/ConsistentHashing.scala
index 1139fc1..e0ba2b1 100644
--- a/akka-actor/src/main/scala/akka/routing/ConsistentHashing.scala
+++ b/akka-actor/src/main/scala/akka/routing/ConsistentHashing.scala
@@ -135,9 +135,9 @@ object ConsistentHashingRoutingLogic {
  */
 @SerialVersionUID(1L)
 final case class ConsistentHashingRoutingLogic(
-  system: ActorSystem,
-  virtualNodesFactor: Int = 0,
-  hashMapping: ConsistentHashingRouter.ConsistentHashMapping = ConsistentHashingRouter.emptyConsistentHashMapping)
+  system:             ActorSystem,
+  virtualNodesFactor: Int                                           = 0,
+  hashMapping:        ConsistentHashingRouter.ConsistentHashMapping = ConsistentHashingRouter.emptyConsistentHashMapping)
   extends RoutingLogic {

   import ConsistentHashingRouter._

Note that the types are aligned as are the default values. This is a new addition to the alignParameters setting - previously, it left-justified all arguments, but left the types & defaults alone.

I really like alignment but haven't used it yet.

It's more that you can no longer opt-in to formatting like:
// Int is not aligned with String.
def foo(arg1: Int,
        arg2HasALongName: String): Unit

This is the kind of alignment that v0.1.4 does. Akka disabled alignParameters in the PR I referenced, likely because of this issue.

Attached is the full Akka diff with all of the new settings from PR #205 . Note that virtually all of these are either arrow renaming changes or the new align parameters setting. FYI @jrudolph if you're interested in comparing with your PR.
akkadiff.txt

:smile: wow, we're actually getting near 1.0

I tried your branch with .setPreference(FirstParameterOnNewline, Preserve) but it helps only a little because of these kind of changes:
   def validate[T1, T2](value1: RequestVal[T1],
-                       value2: RequestVal[T2],
-                       check: Function2[T1, T2, JBoolean],
-                       errorMsg: String,
-                       innerRoute: Route, moreInnerRoutes: Route*): Route =
+    value2: RequestVal[T2],
+    check: Function2[T1, T2, JBoolean],
+    errorMsg: String,
+    innerRoute: Route, moreInnerRoutes: Route*): Route =

So, the first line is now preserved but the indentation of the others still changes.

@jrudolph - It looks like you left the .setPreference(AlignParameters, false) change in. Try setting that back to true. :)

Setting it to true does more than we need:
-  def validate[T1, T2](value1: RequestVal[T1],
-                       value2: RequestVal[T2],
-                       check: Function2[T1, T2, JBoolean],
-                       errorMsg: String,
+  def validate[T1, T2](value1:     RequestVal[T1],
+                       value2:     RequestVal[T2],
+                       check:      Function2[T1, T2, JBoolean],
+                       errorMsg:   String,

Precisely. That's what this bug intends to address: The additional alignment of the types & default values in method signatures should be behind a preference, instead of the default behavior of alignParameters.
So, it sounds like this should be milestone 1.0 - @fommil / @sschaef ? I'd tag it myself, but I don't have permissions. :)

we should probably get you added

FYI https://github.com/jkinkead/scalariform/tree/align_parameter_types_tmp has a fix. It's very simple, but it's dependent on #205 .

@jkinkead thanks, makes sense. If I get to it I'll try your branch.

Cool, your new switch works nicely. What's now left over for Akka is

RARROW
implicit parameter list formatting (you seem to have a suggestion in #180)
it seems to delete lines from block comments, e.g. here https://github.com/akka/akka/pull/19936/files#diff-a09ffa60a39c454ac5f877fda4826a03L21

Awesome, that list aligns with my observations as well. :)

RARROW is tracked in #209 . I'd like some confirmation that people are OK just removing the formatting, instead of hiding it behind a flag (it's dangerous).
Implicit auto-formatting I can move to a flag.
Third issue is a regression, fixed in #208 .


DEC-802: Create field should respond with the new values

Why: The backend should populate default values for properties such as order, and the front end needs to receive what values were used to create the new field in order to update its store.
How:
-Changed field saves to return the field object on successful save. This propagates up to the controller and the controller will render the new field's properties to the json response.
-Changed new fields to be active by default, and use max order + 1 as a default for order.
-Changed the changeField action to no longer change the store optimistically. This should not happen for new fields since we don't have a name or an order until we get a response from the server. If this needs to happen for updates, then we should break this up into two actions.
-Made a few minor cosmetic tweaks to the meta config form.

:+1:

:+1:


VLAZ: Watch dealermarket.com

VLAZ requests the watch of the watch_keyword dealermarket\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

dealermarket\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


[Codegen] Refactor the Codegen

🤔 What's changed?
Change the codegen to be structured neatly and properly. Instead of just tacked into the jsonschema
It will live in its own TLD. It will also be split into the subsequent classes, cleaned up via rubocop and eventually neatened up to remove and redundancies / sub-optimisations.
NB: This isn't aimed to improve the codegen much. I know the way each language interprets the generated items is different. For now this is just aimed as a "1st Pass" at tidying up.
⚡ What's your motivation?
Tidy up messages codebase. Improve Codegen so that we can read it and optimise it more down the line
🏷 What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻ Anything particular you want feedback on?
This can be thought of as an "Internal" Breaking change. But given no-one who is a consumer will see this breaking change (As all codegen code will be identical), it can go out as a patch release
📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code

[ ] I have added/updated tests to cover my changes.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] Users should know about my change

[ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@clrudolphi this is about 85% complete at the moment. I've got 2 more batches of things to tidy up, but it's essentially almost done.
Again as mentioned if there's going to be a close time overlap, I'll hold off on merging this until you've got yours in that way I can fix up the conflicts my end.

@luke-hill Thanks for the heads-up. I think we're done, just pending final reviews by @mpkorstanje and @gasparnagy
Will your work finish up in the next day or two? If not, I hope we will slip in ahead of you.

Ping @clrudolphi - I've only made some minor changes to the dotNET stuff here, but if you want to check it out go ahead

Ping @clrudolphi - I've only made some minor changes to the dotNET stuff here, but if you want to check it out go ahead

Looks good.


chore: add git-remote-codecommit manifest

Can you check the failing CI workflow?

Apologies, there was a typo in the manifest. Fixed it now


Change error to warning for redundant patterns

Thanks!
I'm not sure it is a good idea that the gospel library prints error messages at all, I would argue for something that lets its user decide how to handle the case where an error/warning happens, otherwise it becomes hard to detect these from the client code.


ignores OverwriteDatasets setting in project

Bump
Can't fix the error

It's not an error, it's just never been implemented. Feel free to implement it and create a pull request if you need it for some reason.


update events configured to watch specific fields

ISSUE TYPE

Feature Pull Request

SUMMARY
This commit  makes botkube notify about specific field updates. The updates can be in any of the spec, metadata or status.
Botkube should notify about this according to users specifications.
Fixes #203

Fixing the failed checks, Will Update once done.

Fixing the failed checks, Will Update once done.

Fixed by modifying cmp_test.go

@Surbhidongaonkar could you please rebase with develop?

@Surbhidongaonkar I have pushed few commit. Can you please refactor diff_test.go accordingly?

Screenshots:

@Surbhidongaonkar I have pushed few commit. Can you please refactor diff_test.go accordingly?

sure! Will do.

@Surbhidongaonkar I have pushed few commit. Can you please refactor diff_test.go accordingly?

Updated diff_test.go.


[FLINK-9487] Prepare InternalTimerHeap for asynchronous snapshots

What is the purpose of the change
This PR is the first step in the context of FLINK-9485. Purpose of this PR is to enhance InternalTimerHeap with the capability to produce asynchronous snapshots. This is very similar to the approach of asynchronous snapshots for the CopyOnWriteStateTable and we want to reuse as much of the existing code as possible to power both instances of snapshots.
Brief change log
The first commit generalizes the key-group-partitioning algorithm for async snapshots from the CopyOnWriteStateTable. The newly introduced StateSnapshot interface outlines the asynchronous snapshot life-cycle, which typically looks as follows. In the synchronous part of a checkpoint, an instance of {StateSnapshot} is produced for a state and captures the state at this point in time. Then, in the asynchronous part of the checkpoint, the user calls  #partitionByKeyGroup() to ensure that the snapshot is partitioned into key-groups. For state that is already partitioned, this can be a NOP. The returned KeyGroupPartitionedSnapshot can be used by the caller to write the state by key-group. As a last step, when the state is completely written, the user calls #release().
The partitioning algorithm is also slightly modified to cache computed key-group-ids per element. This is improves runtime at the cost of some additional memory.
The second commit introduced an implementation of StateSnapshot for the InternalTimerHeap data structure.
Verifying this change
This change added tests: TimerPartitionerTest , StateTableKeyGroupPartitionerTest, AbstractKeyGroupPartitionedSnapshotTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not applicable)

CC @azagrebin

Thanks for the review @sihuazhou!

@azagrebin @sihuazhou I have addressed the comments and also slightly refactored the PR. Please take another look if you want.

@StefanRRichter Sorry that I didn't take a look again yesterday, I was a bit too busy at that time. I had a look at the fix for the CopyOnWriteStateTable, I afraid it's still a partial fix, I just create a JIRA for it and will give a PR for it very soon.
In short, the another partial problem is that we reuse the snaphotData as the output array when partitioning the data, but the snapshotData is max length is 1 << 30. So when the records in CopyOnWriteStateTable is more than 1 << 30 (e.g. 1 <<30 + 1), then the check Preconditions.checkState(partitioningDestination.length >= numberOfElements); could be failed.


Redefine the meaning of column is_active to make Actions Registration Token generation easier (#27143)

Backport #27143 by @lunny
Partially Fix #25041
This PR redefined the meaning of column is_active in table action_runner_token.
Before this PR, is_active means whether it has been used by any runner. If it's true, other runner cannot use it to register again.
In this PR, is_active means whether it's validated to be used to register runner. And if it's true, then it can be used to register runners until it become false. When creating a new is_active register token, any previous tokens will be set is_active to false.

@GiteaBot please fix the merge conflicts. :tea:


Big Dependency Update & Modernization

In an effort to keep this great little project fresh, I'm working on this major version refresh.
A lot of issues are already addressed in upstream projects, and we just need to get those integrated.
Notable Version Updates
The following are updated along with their implicit dependencies.

Go (1.11 -> 1.13.10) Go 1.14 waiting for moby/buildkit#1377 first
Travis Build Version & dev  (xenial -> bionic)
Alpine images (3.8 -> 3.11)
opencontainers/runc (latest)
containerd/containerd (latest)
moby/buildkit (latest)

Buildkit Updates
Any other changes I've included were due to API change in buildkit. I've done my best to get this right, but I'm not very familiar with buildkit internals.
Addresses Issues
Subject to testing, this release should fix the following issues:

#236

@AkihiroSuda @jessfraz Can you PTAL?

@AkihiroSuda Can a new version be released?, it's been a while since the last release.

cc @jessfraz

Pushed a new version, thanks @AkihiroSuda for being on top of things been busy with the startup!
FWIW if you ever want to release a new version the commands are:
$ make bump-version
$ make tag
$ git push origin ${whatever_tag}
$ git push origin master

Thanks @jessfraz, been waiting for a new release for sometime. 👍

Thanks @jessfraz , but https://r.j3ss.co/repo/img/tags seems not updated?


Move webpack to peerDependencies

Since this plugin support both webpack 3 and 4, webpack should add as a peer dependency.

Hi @yesmeck! Thanks for making this PR, it helped me find that all the dependencies were messed up die to npm 6's auto-adding dependencies on npm install.
I'm going to close this since there were more dependencies issues and I had to fix them myself, but many thanks anyway!
I've a new release already 👌


Example used.

The '=' operator treats '0' zero and BLANK  as being equal.
A small example shows this:
EVALUATE
FILTER (
{
( "01", 0 ),
( "02", BLANK () ),
( "03", 200 )
},
[Value2] = 0
)
Wouldn't it be better to change the example:
=IF(ISBLANK([Sales]) || [Sales] = 0, BLANK(), [Profit] / [Sales])
to
=IF( [Sales] = 0, BLANK(), [Profit] / [Sales])
The original example leaves the readers with the impression that '=' treats '0' zero and BLANK  as not being equal. I may be a stickler for accuracy but since this is an official guidance I think it would be better not to introduce confusion or let the reader be left with the wrong impression.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b331cbb-81c4-add1-da29-3783ed6ad9a6
Version Independent ID: 9f4ca24a-ad9b-2601-7a40-5ffd5eef8254
Content: DAX: DIVIDE function vs divide operator (/) - Power BI
Content Source: powerbi-docs/guidance/dax-divide-function-operator.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @guyinacube
Microsoft Alias: v-pemyer

Alternatively you could change the example into:
=IF(ISBLANK([Sales]) || [Sales] == 0, BLANK(), [Profit] / [Sales])
I.e using the '==' operator instead of the '=' operator. This actually may have been the intention of the guidance author all along; to emphasise the two scenarios that can occur regarding the denominator.

The example is now updated to =IF(OR(ISBLANK([Sales]), [Sales] == 0), BLANK(), [Profit] / [Sales]). Thanks @Oxenskiold-DAX, closing this one out.


Add manual classification file

Add manual classification file to allow for manual sector classification in r2dii.match::match_name()

Manual classification file is a one-to-one bridge FROM 2dii sectors TO 2dii sectors. It is an easy way to address 2DegreesInvesting/r2dii.match#203

Ups, I think I missed this PR. Is it ready to be merged? Should it be included in a patch release to CRAN soon?

Nope, don't merge this yet! We weren't sure it was a good idea.


iOS: Can't see remote participant camera feed (chrome)

Describe the bug
I expect to see iOS user camera feed on my pc user.
Reproduction
Participant A:

Open meet.livekit.io select custom tab
In cloud.livekit.io generate token for pc user
Connect meeting with generated credentials with pc user, dont forget to enable end-to-end encryption

Participant B:

Open meet.livekit.io using iphone 16.x (I have used browserstack) and select custom tab
In cloud.livekit.io generate token for ios user
Connect meeting with generated credentials with ios user, dont forget to enable end-to-end encryption

Video recording: https://drive.google.com/file/d/1f9crmFMie-PCt0cx4M_1f-zZVZ5ohAo2/view?usp=sharing
Logs:
pc_user.log
ios_user.log
Logs
No response
System Info
Participant A: System:
    OS: macOS 14.1.1
    CPU: (8) arm64 Apple M1
    Memory: 133.80 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm
    pnpm: 8.15.4 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 124.0.6367.62
    Edge: 124.0.2478.51
    Safari: 17.1

Participant B: Iphone 13 iOS 16.3 Chrome

Severity
blocking all usage of LiveKit
Additional Information
Cloud server config

No response

In your settings you have vp8 disabled, vp9 and av1 are not supported for end-to-end encryption.
Does it start working if you enable vp8 as a codec?

In your settings you have vp8 disabled, vp9 and av1 are not supported for end-to-end encryption. Does it start working if you enable vp8 as a codec?

No, it does not work.

Did you ensure that you were actually publishing and receiving vp8 ?

ios user log:

pc user log:

I just tested this on browserstack with iOS16 and chrome as a browser. I see the same behaviour as you.
The reason for this is probably the fact that browserstack doesn't send any updated video frames (as the video is black/static). In order for a LiveKit track to be successfully published and broadcasted to other users server side, media needs to be flowing. This does not seem to be the case here.
I'll close this as won't fix, but feel free to re-open if you can reproduce this with an actual device and a working camera.

reopening as @AurimasG12 can repro on a real device


theme + examplesite will not build

Hi there,
I'm testing out this theme and it looks great! after having everything setup, I found that I cannot build the site into a public folder. I even tried from the start using the examplesite that came along with the project, it works great with the hugo server. But when i try to with the hugo to get it to build into a public folder, the site compile without any theme.
Is anyone else having a problem with this?
 I have a few blogs running and baseUrl did not match up, so the theme files were missing.


docs: pandoc gives permission denied error

$ make docs
pandoc: /input/README.md: openFile: permission denied (Permission denied)
Makefile:30: recipe for target 'output/docs.pdf' failed
make: *** [output/docs.pdf] Error 1

@vbatts something simple?

hrm. I don't get that error... what's the host info or versions of things?

what do you want the version of?
On Thu, May 19, 2016 at 5:38 PM, Vincent Batts<EMAIL_ADDRESS>wrote:

hrm. I don't get that error... what's the host info or versions of things?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/image-spec/issues/72#issuecomment-220363930

host OS? docker version?
On Thu, May 19, 2016 at 11:39 AM, Jonathan Boulle<EMAIL_ADDRESS>wrote:

what do you want the version of?
On Thu, May 19, 2016 at 5:38 PM, Vincent Batts<EMAIL_ADDRESS>wrote:

hrm. I don't get that error... what's the host info or versions of
things?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
<
https://github.com/opencontainers/image-spec/issues/72#issuecomment-220363930

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/image-spec/issues/72#issuecomment-220364183

Version:      1.8.2-fc22
API version:  1.20
Package Version: docker-1.8.2-7.gitcb216be.fc22.x86_64
Go version:   go1.5.1
Git commit:   cb216be/1.8.2
Built:
OS/Arch:      linux/amd64
On Thu, May 19, 2016 at 5:43 PM, Vincent Batts<EMAIL_ADDRESS>wrote:

host OS? docker version?
On Thu, May 19, 2016 at 11:39 AM, Jonathan Boulle <
<EMAIL_ADDRESS>wrote:

what do you want the version of?
On Thu, May 19, 2016 at 5:38 PM, Vincent Batts<EMAIL_ADDRESS>wrote:

hrm. I don't get that error... what's the host info or versions of
things?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
<

https://github.com/opencontainers/image-spec/issues/72#issuecomment-220363930

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
<
https://github.com/opencontainers/image-spec/issues/72#issuecomment-220364183

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/image-spec/issues/72#issuecomment-220365446

@vbatts @jonboulle any updates here?

I still can't reproduce ...
On Tue, May 24, 2016 at 4:52 PM Brandon Philips<EMAIL_ADDRESS>wrote:

@vbatts https://github.com/vbatts @jonboulle
https://github.com/jonboulle any updates here?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/image-spec/issues/72#issuecomment-221387362

Closing. @jonboulle if you reproduce I will reopen it.

Docker bug. Upgrading to the latest one fixed it.

@philips -- I do get the exact same problem with the latest opecontainers runtime-spec, details below. Would really appreciate your help.
unknown484d7ef0b631.attlocal.net:/home/ramki/go/src/github.com/opencontainers/runtime-spec->make docs
mkdir -p output/ &&
/usr/bin/docker run -it --rm -v /home/ramki/go/src/github.com/opencontainers/runtime-spec/:/input/:ro -v /home/ramki/go/src/github.com/opencontainers/runtime-spec/output/:/output/ -u 1000 vbatts/pandoc -f markdown_github -t latex -o /output/oci-runtime-spec.pdf /input/version.md /input/spec.md /input/principles.md /input/bundle.md /input/runtime.md /input/runtime-linux.md /input/config.md /input/config-linux.md /input/config-solaris.md /input/glossary.md
pandoc: /input/version.md: openFile: permission denied (Permission denied)
make: *** [output/oci-runtime-spec.pdf] Error 1
unknown484d7ef0b631.attlocal.net:/home/ramki/go/src/github.com/opencontainers/runtime-spec->uname -a
Linux unknown484d7ef0b631.attlocal.net 4.11.0-rc8 #1 SMP Sat Apr 29 19:59:45 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux
unknown484d7ef0b631.attlocal.net:/home/ramki/go/src/github.com/opencontainers/runtime-spec->docker version
Client:
Version:         1.12.6
API version:     1.24
Package version: docker-common-1.12.6-16.el7.centos.x86_64
Go version:      go1.7.4
Git commit:      3a094bd/1.12.6
Built:           Fri Apr 14 13:46:13 2017
OS/Arch:         linux/amd64
Server:
Version:         1.12.6
API version:     1.24
Package version: docker-common-1.12.6-16.el7.centos.x86_64
Go version:      go1.7.4
Git commit:      3a094bd/1.12.6
Built:           Fri Apr 14 13:46:13 2017
OS/Arch:         linux/amd64
Thanks,
Ramki

@ramkri123 interesting :-\ i'm checking. I don't get this on older docker version.


ModuleNotFoundError: No module named 'resfgb.models.mlp'

Excese me，May I ask how to solve ModuleNotFoundError: No module named 'resfgb.models.mlp'

@lxy51 you need to define init.py based on the src directory you are working in.


Update Default (OSX).sublime-keymap

Copied the contents of the Windows keymap file here to fill in missing shortcuts, and to correct the "ctrl+shift+l" shortcut, which currently calls "adjust_line_nums" instead of "call_adjust."

thanks so much for contributing!


privatesend: Calculate base size in CTransactionBuilder ctor based on actual scriptPubKey-s

It breaks on non-p2pkh inputs otherwise.

Do you mean that if the wallet tries to denominate a P2SH utxo, it won't be able to?

Do you mean that if the wallet tries to denominate a P2SH utxo, it won't be able to?

yes, won't work for p2pk either (which was my case)

yes, won't work for p2pk either (which was my case)


Swipe for next/previous page

Using the PDF Viewer app in its current state feels unnecessarily unintuitive when it comes to multipage PDFs. The only way to scroll through PDFs is provided by the two arrows in the top bar of the app's UI. That position is uncomfortably to reach. Please consider adding swipe gestures.

Duplicate of https://github.com/GrapheneOS/PdfViewer/issues/41


Define VectorizationBase.CACHE_COUNT, etc. in the module __init___() function

Currently, the global constants that are related to CPU topology (VectorizationBase.CACHE_COUNT, etc.) are defined at module precompilation time. See e.g. https://github.com/chriselrod/VectorizationBase.jl/blob/master/src/topology.jl
Unfortunately, this will make it very difficult for us to allow users to override the values of these constants at run-time, which is required for e.g. the implementation of https://github.com/JuliaLinearAlgebra/Octavian.jl/issues/7
I would describe the implementation of https://github.com/JuliaLinearAlgebra/Octavian.jl/issues/7 as two steps:

Define VectorizationBase.CACHE_COUNT and other such global constants at import-time by defining them in the VectorizationBase.__init__() function.
Add the feature that allows users to spoof CPU features

@chriselrod If you can implement task 1, then I can implement task 2.

A problem here though is that we may want these getting precompiled, because a lot of other compilation potentially depends on their values.

A problem here though is that we may want these getting precompiled, because a lot of other compilation potentially depends on their values.

Maybe the Preferences.jl package is the right approach.

Preferences that are accessed during compilation are automatically marked as compile-time preferences, and any change recorded to these preferences will cause the Julia compiler to recompile any cached precompilation .ji files for that module.

https://github.com/JuliaPackaging/Preferences.jl

Maybe the Preferences.jl package is the right approach.

Preferences that are accessed during compilation are automatically marked as compile-time preferences, and any change recorded to these preferences will cause the Julia compiler to recompile any cached precompilation .ji files for that module.

https://github.com/JuliaPackaging/Preferences.jl

Turns out this is actually a very high priority, and I need to also backport the fix to Vectorization 0.12 (the last minor version compatible with LoopVectorization 0.8), as this is causing errors when people compile and ship binaries.

Turns out this is actually a very high priority, and I need to also backport the fix to Vectorization 0.12 (the last minor version compatible with LoopVectorization 0.8), as this is causing errors when people compile and ship binaries.

I think the compile-time preferences approach with Preferences.jl (e.g. https://github.com/chriselrod/VectorizationBase.jl/pull/33) should be fine when people compile and ship binaries. But I'm not 100% sure. @staticfloat can confirm.
@chriselrod Can you link any of the error reports that people are having when compiling and shipping binaries? And then maybe @staticfloat can confirm whether or not the compile-time preferences approach will fix those errors?

I think the compile-time preferences approach with Preferences.jl (e.g. https://github.com/chriselrod/VectorizationBase.jl/pull/33) should be fine when people compile and ship binaries. But I'm not 100% sure. @staticfloat can confirm.
@chriselrod Can you link any of the error reports that people are having when compiling and shipping binaries? And then maybe @staticfloat can confirm whether or not the compile-time preferences approach will fix those errors?

Of course Preferences.jl requires at least Julia 1.6. So I'm not sure what we should do for Julia 1.5.
Like you said above, it's often important that we have these values at compile-time, because a lot of other compile-time stuff depends on them.

Of course Preferences.jl requires at least Julia 1.6. So I'm not sure what we should do for Julia 1.5.
Like you said above, it's often important that we have these values at compile-time, because a lot of other compile-time stuff depends on them.

Yeah, Preferences.jl will allow you to, (on 1.6+) invalidate your .ji cache if a preference changes.  But the preference changing is a function of something the user sets; it's not really meant to let you, for example, look at the current cache count of the currently-running machine and cancel loading the .ji file halfway through loading it because it didn't match.
The way the preferences invalidation works is that it checks the current set of preferences with the preferences that were used when the .ji file was loaded, and then loads that .ji file if they matched.  So what you can do is allow the user to configure the cache count, which gets saved as a preference, and then the next time its loaded, it will be recompiled.

Yeah, Preferences.jl will allow you to, (on 1.6+) invalidate your .ji cache if a preference changes.  But the preference changing is a function of something the user sets; it's not really meant to let you, for example, look at the current cache count of the currently-running machine and cancel loading the .ji file halfway through loading it because it didn't match.
The way the preferences invalidation works is that it checks the current set of preferences with the preferences that were used when the .ji file was loaded, and then loads that .ji file if they matched.  So what you can do is allow the user to configure the cache count, which gets saved as a preference, and then the next time its loaded, it will be recompiled.

But invalidating .ji caches doesn't work if it's baked into a system image?
I need this to be compatible with distributing a system image that includes VectorizationBase.

But invalidating .ji caches doesn't work if it's baked into a system image?
I need this to be compatible with distributing a system image that includes VectorizationBase.

https://discourse.julialang.org/t/global-constants-that-cannot-be-defined-until-runtime-because-they-depend-on-specifics-of-the-cpu-architecture/54077

https://discourse.julialang.org/t/global-constants-that-cannot-be-defined-until-runtime-because-they-depend-on-specifics-of-the-cpu-architecture/54077

Closing this as solved.


Missing Gumps PandoraUO

Hey this client is awesome, loving the features, is there anyways to troubleshoot missing gumps? like when i Open the soulforge on pandora, i get no gump in debug mode it shows an outline for an invisible gump? same for an item called master runebook. also they have a toolbar, with an interface to move it, it doesn't seem to work right either, when I click the move button the grid comes up and it moves AFTER I relaunch the client, on normal client it moves without restarting. I can try and record this if it helps, or whatever you need me to do to help troubleshoot, just let me know.

yes do a rec please

Ok, done, first one is normal updated UO client second is ClassicUO Client. ClassicUO is spoiling me, hope we can get it nocked out whatever I need to do to help, just let me know.
https://youtu.be/61jHHijzNMI
https://youtu.be/61jHHijzNMI

Hi, i fixed the gump positioning, but i don't have other items to test. Write me on discord

fixed

I seem to be having the same issue with the master runebook on PandoraUO, was there ever a fix for this?

This issue is back, i think your fix for it got rolled back a bit at some point.


pc restarting when playing multiplayer

hi guys im just having issues playing phasmophobia the last 2 weeks in multiplayer after about 5 minutes in it restarts my pc but single player it works fine
my pc specs
Intel(R) Core(TM) i5-10600KF CPU @ 4.10GHz   4.10 GHz
16gb ram
750 watt power source and a inno3d geforce rtx 3050

Hi Steb69, this is the Issues page for the fan-made website Phasmo.site, not an official bug report for the game itself. I suggest either using the Steam discussions page


Google APIs support

Submitted by Sweb Development.
Added oAuth 2.0 support for Google Drive, Google Photos, and Gmail to replace deprecated webview-based authentication. Added browsing interface and FileStack file upload management for Google services.
Updated build tools and runtime permissions to support modern Android OS releases.

Mior Edits Done.
Awaiting for Review.

LGTM


Update 01-Setting-Up-The-Server.md

expand the title to avoid 'setup' noun form confusion
'login' (or 'log-in', but that incurs a style change to similar words, and is more costly) is a noun form , where 'log in' is the verb
'shutdown' is a noun form (and an irksome command), where 'shut down' is the verb
remove comma splice or two.  Promote to semi-colons (one a colon) to ideally preserve the intent of the sentence.
s/an/a/ as appropriate
one tiny typo
thank you for suggesting an editor that isn't vi .  It needs no more momentum.
'backup' (actually, back-up) is a noun form, where 'back up' is a verb form.
change all the remaining 'ssh' to 'SSH' when talking about the initialism, but leave as 'ssh' when in commands.
move one 'RPI4' to 'RPI-4' to follow existing style in document.

Thanks!


feat(@angular/cli): specify browser to open url instead of default one

Allows you to specify the browser to open.
ng serve --open --browser=safari or ng s -o -b=safari
Fixes: https://github.com/angular/angular-cli/issues/5508

Good point.
What about removing the command line option and just add a config option in the defaults section?  That would allow someone to place their preferred development browser in their global CLI config and easily use it on all their projects.  This would probably be the typical use case anyway.

@hansl @filipesilva @Brocco I can add defaultBrowser option in CLI config and use that.

I don't think we can get by without an override via the command line, but a user-specific setting isn't a bad approach, although it's not project specific.

I'm not sure having it configurable in the CLI json fully fits the bill, since the app name is OS specific.

This is not a feature we want to add. It's simple enough to open any browsers you want to use, or to change your default one if the default for your machine is not working.


user12986714: Watch visit my channel

user12986714 requests the watch of the watch_keyword visit my channel. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

visit my channel has been seen in 1 true positive, 0 false positives, and 0 NAAs.


use re to convert UpperCamelCase to snake_case

Hi, I've made a slight change to use re for converting UpperCamelCase to snake_case.

Personally, I find this harder to read even though it's terser.
As a general suggestion, I'd recommend contributing to an existing issue, especially those marked as https://github.com/google/mesop/labels/help wanted. Although there's plenty of code health issues, I think it'll be more impactful to work on fixing bugs / adding more features / improving docs, rather than rewriting small chunks of code.


The threshold values of Q16 and NudeNet

Hi,
Thanks for your amazing work! I am confused about the threshold values of Q16 and NudeNet used in your paper so I am bothering you. Also, I wonder if you use all the classes of NudeNet, which are shown below?
__labels = [
"FEMALE_GENITALIA_COVERED",
"FACE_FEMALE",
"BUTTOCKS_EXPOSED",
"FEMALE_BREAST_EXPOSED",
"FEMALE_GENITALIA_EXPOSED",
"MALE_BREAST_EXPOSED",
"ANUS_EXPOSED",
"FEET_EXPOSED",
"BELLY_COVERED",
"FEET_COVERED",
"ARMPITS_COVERED",
"ARMPITS_EXPOSED",
"FACE_MALE",
"BELLY_EXPOSED",
"MALE_GENITALIA_EXPOSED",
"ANUS_COVERED",
"FEMALE_BREAST_COVERED",
"BUTTOCKS_COVERED",
]

Hi! Thanks for the question!
We mention in the paper that we used the classes with "EXPOSED" body parts only. In appendix, we provide more detailed bar plots for the same.
As for the threshold, we use the default value that the detector provides. For more accurate reimplementation of our results, I would suggest using the checkpoint that was provide in the README.


View Count : Tell how much we have to transfer

It would be nice to have another column telling us how many we should transfer to optimize our candies. Lets say I have 112 candies and 20 pidgey, I'd like the app to tell me I should transfer :
floor(112/12) = 9 +  4 free
20 piedgey - 9 = 11 pidgey free
if I transfer 12-4 free = 8, i can evolve evolve 1 more,
So the number of pidgey I really have to transfer is 11-8 = 3
(Also, a column with how many I can evolve Considering transfers could be nice)

I made a pull request

Related to #56


A little README.md correction

The aforementioned correction in #106

Hi Muhammad! thank you for the PR!
Apologies for not engaging with it sooner. I thought there was some typo in the README, but the correction you're suggesting is not necessary I believe.
Have you tried using Pkg; Pkg.add("PromptingTools") ? Did it not work for you? Because it does work for me.
Julia packages are often referred to with the .jl suffix, but you don't have to use it when referring to them / importing them / adding them.
Or is your experience different?

As an example, your correction would actually lead to an error:
julia> Pkg.add("PromptingTools.jl")
ERROR: `PromptingTools.jl` is not a valid package name. Perhaps you meant `PromptingTools`

Hello, it is my pleasure to contribute to this repository.
I believe there is a miss understanding regarding my pull request. The current state of the README mentions Pkg.add("PromptingTools.jl") not Pkg.add("PromptingTools"), and that is what my PR is correcting.
You can double check that from the current README.md (the main page).

Ha! good catch - thank you!


nixos-option trips upon types.submodule

$ nixos-option services.mwlib.nslave.http.port
An error occurred while looking for attribute names.
8898

cc @nbp

(triage) still occurs

Indeed, I stumbled upon this several times. As I'm already trying to improve nixos-option (see #43147) I might give it a try as well %)

ok, don't know enough about the module system. However I think that we might want to use another data format (e.g. something like this https://nixos.org/nixos/options.json ?)


missing lz4 library when using 0.5.0 release binary jar

Describe the bug
The testing env. is CentOS7.4 and report lz4 missing during running 0.5.0 release binary jar.
lz4 library does not include in 3rd party library jar file.
To Reproduce
Run 0.5.0 release binary on CentOS7.4.
Expected behavior
Assume 3rd party jar file should be included in 3rd party library jar file.

@weiting-chen i add liblz4 to gluten third-party jar, but it still failed to load liblz4. How could i fix it?


Question about maintaining order

Hi, nice project!
In your readme there is an example-json: What happens after conversion to AVU, storing in irods, and retrieving back from irods. Is the order of the lists guaranteed to be the same? So is it always 'age': ['50', '29'], or could it be also 'age': ['29', '50']?
Out of interest: Do you use the code form the WG metadata-templates?

Oh. the first question is actually answered further down in the readme. Sorry!


add colorbox command

Added a command colorbox which is equivalent of colorbox from xcolor Latex package.
Preview

Thanks for the change.

Thank you for merging.
I see the Cocoapod hasn't been updated for a while.
How bout you do that overdue update for once? You know how people hesitate to use an old pod.

Because I don't want people to skip on this awesome library because of few deceptive things like

Written in Obj-C
Last update was in 2017
Simply updating pod would improve a lot. @kostub


Linux Godot Compile Failure

Godot version
3.3.2-stable
System information
rpi4, raspberry pi os, xfce desktop environment
Issue description
Im trying to compile godot on my raspberry pi, ive done it before but i lost the text file that had the command i was using in it and Im trying to figure out the command that will work again. Im using this command:
scons platform=x11 target=release_debug tools=yes use_llvm=yes CCFLAGS="-mcpu=cortex-a72 -mtune=cortex-a72 -mfpu=neon-fp-armv8 -mfloat-abi=hard -mlittle-endian -munaligned-access" -j4 module_webm_enabled=no

Using that command im getting this error:
HEAD is now at 7610409b8a Bump version to 3.3.2-stable
scons: Reading SConscript files ...
Couldn't parse CXX environment variable to infer compiler version.
Enabling ALSA
Enabling PulseAudio
Enabling udev support
Couldn't parse CXX environment variable to infer compiler version.
Checking for C header file mntent.h... no
scons: done reading SConscript files.
scons: Building targets ...
[Initial build] Compiling ==> platform/x11/godot_x11.cpp
[Initial build] Compiling ==> platform/x11/context_gl_x11.cpp
sh: 1: clang++: not found
[Initial build] sh: 1: clang++: not found
[Initial build] Compiling ==> platform/x11/crash_handler_x11.cpp
sh: 1: clang++: not found
[Initial build] scons: *** [platform/x11/godot_x11.x11.opt.tools.32.llvm.o] Error 127
build_gles3_headers(["drivers/gles3/shaders/ssao_minify.glsl.gen.h"], ["drivers/gles3/shaders/ssao_minify.glsl"])
scons: *** [platform/x11/context_gl_x11.x11.opt.tools.32.llvm.o] Error 127
scons: *** [platform/x11/crash_handler_x11.x11.opt.tools.32.llvm.o] Error 127
scons: building terminated because of errors.

Any idea how to fix this?
Steps to reproduce
Try compiling godot using this command:
scons platform=x11 target=release_debug tools=yes use_llvm=yes CCFLAGS="-mcpu=cortex-a72 -mtune=cortex-a72 -mfpu=neon-fp-armv8 -mfloat-abi=hard -mlittle-endian -munaligned-access" -j4 module_webm_enabled=no

on a rpi4 running raspberry pi os with xfce desktop environment
Minimal reproduction project
No response

use_llvm=yes requires that you have the Clang compiler installed. If you only have GCC installed, do not pass use_llvm=yes to the SCons command line.
Also, you can probably remove the CCFLAGS and stick with the default values.

Okay, ive ommited use_llvm=yes and CCFLAGS and it is currently compiling, i started with the command hiulit provides in his unofficial rpi godot github repo and made the edits i remember from the command i was using before

It was almost done but then it stopped:
[Initial build] /usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::alloc_static(unsigned int, bool)':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:434: undefined reference to `__atomic_compare_exchange_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::realloc_static(void*, unsigned int, bool)':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:434: undefined reference to `__atomic_compare_exchange_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::free_static(void*, bool)':
/usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::get_mem_usage()':
/usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::get_mem_max_usage()':
/usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `_GLOBAL__sub_I__ZnwjPKc':
/usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::thread_flush()':
/usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::thread_draw(bool, double)':
/usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::sync()':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::draw(bool, double)':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::VisualServerWrapMT(VisualServer*, bool)':
/usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(safe_refcount.x11.opt.tools.32.o): in function `check_lockless_atomics()':
/usr/include/c++/8/bits/atomic_base.h:354: undefined reference to `__atomic_is_lock_free'
collect2: error: ld returned 1 exit status
scons: *** [bin/godot.x11.opt.tools.32] Error 1
scons: building terminated because of errors.```

This should have been fixed a while ago: https://github.com/godotengine/godot/issues/31407

im pretty sure i did git checkout 3.3.2-stable before running this but i can try again and make sure

it appears to pick up where it left off then end in the same error

@Calinou ^
Sorry if you don't like being mentioned like this, im just not sure if you have seen the new messages yet or not

@Calinou ^
Sorry if you don't like being mentioned like this, im just not sure if you have seen the new messages yet or not

I've seen your messages, but I don't know what would be the cause of the error then.

Manually disabling modules and setting CCFLAGS should not be necessary if you are building on device (it's for cross-compiling only), at least current 3.x is building and running on the ARM64 version of Ubuntu 21.04 (QEMU/HVF VM on M1 mac).

undefined reference to `__atomic_fetch_add_8'

Try adding LINKFLAGS="-latomic" to the build command.

Adding LINKFLAGS="-latomic" worked!

Thanks for the help!
Here is the build command in full(just in case I loss it again and I can easily find it or just in case someone else is having the same problem you can refer them to this):
scons platform=x11 target=release_debug tools=yes -j4 module_webm_enabled=no LINKFLAGS="-latomic"

Thank you for your help @Calinou and @bruvzg!

Out of curiosity, does it work if you compile without LINKFLAGS="-latomic" but with use_static_cpp=no?

Nope, it does not appear too:
Enabling ALSA
Enabling PulseAudio
Enabling udev support
Checking for C header file mntent.h... (cached) yes
scons: done reading SConscript files.
scons: Building targets ...
[ 96%] Linking Program        ==> bin/godot.x11.opt.tools.32
[100%] progress_finish(["progress_finish"], [])
[100%] /usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::alloc_static(unsigned int, bool)':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:434: undefined reference to `__atomic_compare_exchange_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::realloc_static(void*, unsigned int, bool)':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:434: undefined reference to `__atomic_compare_exchange_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::free_static(void*, bool)':
/usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::get_mem_usage()':
/usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `Memory::get_mem_max_usage()':
/usr/include/c++/8/bits/atomic_base.h:396: undefined reference to `__atomic_load_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(memory.x11.opt.tools.32.o): in function `_GLOBAL__sub_I__ZnwjPKc':
/usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: /usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::thread_flush()':
/usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::thread_draw(bool, double)':
/usr/include/c++/8/bits/atomic_base.h:524: undefined reference to `__atomic_fetch_sub_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::sync()':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::draw(bool, double)':
/usr/include/c++/8/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/bin/ld: servers/libservers.x11.opt.tools.32.a(visual_server_wrap_mt.x11.opt.tools.32.o): in function `VisualServerWrapMT::VisualServerWrapMT(VisualServer*, bool)':
/usr/include/c++/8/bits/atomic_base.h:374: undefined reference to `__atomic_store_8'
/usr/bin/ld: core/libcore.x11.opt.tools.32.a(safe_refcount.x11.opt.tools.32.o): in function `check_lockless_atomics()':
/usr/include/c++/8/bits/atomic_base.h:354: undefined reference to `__atomic_is_lock_free'
collect2: error: ld returned 1 exit status
scons: *** [bin/godot.x11.opt.tools.32] Error 1
scons: building terminated because of errors.```


Some of the reference articles are written by Japanese

Some packages of readme or comment has reference which is written by Japanese.
If it's easily replace by English article then replace it, otherwise leave it alone.

@taikitanaka3 Could you please list the Japanese documents?

@taikitanaka3 Could you update the status?

@kenji-miyake
This issue is to change Japanese documents to English as much as possible and currently most of documents are written in English so I think I can close this.

Hello everyone,
While going through the documentation found at
Autoware universe documentation
I found out that the images have all the explanation in Japanese. Can someone provide an English version or just a brief explanation of images in English . Thank you for great work.


Restrict users to be able to pull images from only specific registries

Restrict users to be able to pull images from only specific registry/registries

we'll track using:
https://github.com/rancher/rancher/issues/5799


Refactor component library structure in preparation for pypi release

See commits for more details

@jourdain I've overwritten the commits such that each commit is cleanly separate from each other; I also added details below each commit. Though they should be self-explanatory, if there's something unclear please let me know!

@jourdain I've overwritten the commits such that each commit is cleanly separate from each other; I also added details below each commit. Though they should be self-explanatory, if there's something unclear please let me know!

@jourdain How do I modify the size of the cone? I know i have to modify the state prop but not sure what I need to change exactly.

@jourdain How do I modify the size of the cone? I know i have to modify the state prop but not sure what I need to change exactly.

state={{
   height: 1,
   radius: 0.5,
   resolution: 60,
   direction: [1, 0, 0],
}}

state={{
   height: 1,
   radius: 0.5,
   resolution: 60,
   direction: [1, 0, 0],
}}

Nice! Actually I just moved the app to demos/usage-algorithm/app.py and added a bunch of useful files. I also added a switch that lets you control the capping as well. Here's the end result:

All in 70 lines of Python. I also used dash bootstrap components which is a third party library that integrates react-bootstrap into dash. Feel free to check out the library!

Nice! Actually I just moved the app to demos/usage-algorithm/app.py and added a bunch of useful files. I also added a switch that lets you control the capping as well. Here's the end result:

All in 70 lines of Python. I also used dash bootstrap components which is a third party library that integrates react-bootstrap into dash. Feel free to check out the library!

In my last three commits I added tests and circleCI automation. Merging now

In my last three commits I added tests and circleCI automation. Merging now


pull request for e2e test at 12/16/2016 13:45:19

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


onLoadProgress

Sometimes loading large remote files takes a while. Wondering if something like onLoadProgress is possible and easy to implement?

Also wondering how this could be implemented?

Me too

Is there anyone could help us to implement this feature?


(1071, 'Specified key was too long; max key length is 767 bytes')

As in Laravel, if a system hasn't been properly configured, this error will popup. In Laravel you do a simple hack and it will overwritte the default length of VARCHAR. How do you do this in Masonite? I explicitely set the chars length in the User migration file:
table.string('email', 191).unique()

awaiting response from Orator


Plugin's knex instance should default to the root server's

This is both,

when Model.knexBind()ing during init and,
when calling request.knex() and server.knex().

@devinivy Don't these lines cover this?
https://github.com/BigRoomStudios/schwifty/blob/master/lib/index.js#L176-L179

Yeah, actually it sort of does.  I think I really just mean to update the behavior.  That sets a special root knex instance as the first knex instance that's specified in any plugin.  We would rather not rely on timing– the root knex instance should simply be the knex instance set when,

registering the plugin, or
calling server.schwifty() when server is the root server.

And it should be able to be specified at any point in time.  In short, this feature is really about making sure that "order doesn't matter" when it comes to plugins (and the root server) declaring their knex instances.

Ok cool. So we're leaving it open for the root knex instance to be registered possibly after some plugins have registered. Yeah that whole block can be changed then, and the Hoek.assert can be removed (the one mentioned in description of #9 )

Yup, that block changed a fair amount in #13– would love some review!

On it


Match the path_prefix as default behavior of the system.

For example, on MS Windows, the path_prefix is matched case-insensitively.
This PR has been already discussed on the issue #1021.
But you can drop this PR because of some reason.
Thanks.

@jca02266 Thanks for your contribution! But I'm afraid it may need some time to start code review cycles. Sorry about that.

Plus, I'm going to add a test for LocalFileInputPlugin in #1023 (after adding Windows special handling in directory names in the test).
After merging #1023, wondering if you could update the test to add Windows special handling in base file names as well.

Ah, sorry, my commit message above was incorrect. s/case-insensitively/case-sensitively/
Before this fix, it matched case-sensitively even on Windows, for example.

Thanks for your many suggestion. Can I really rebase those commit?

If you mean that I should rebase first commit only to fix message, Should I remake new PR?

Yes, rebasing and squashing is okay here in this PR.

Ok, I will squash all tomorrow.

Yeah, I will ask rebasing again after #1023 is merged, and update the tests there. Tomorrow would be fine.

Please review it, and then I squash again.

@jca02266 #1023 has been merged!
And please update the PR subject to be the same with the git commit message.

No problem. Thanks a lot.

Thanks. Merging.


[BACKLOG-14037]  Wiring "Step Metrics" tab to engine events.

@CodeOnCoffee @hudak @ccaspanello

Using TransAdapter strategy instead