Static redirect URIs required by OIDC specification

The current implementation of the OIDC client in the ssh3 client binary spawns a local HTTP webserver at a random port with a random URL path fragment. This contradicts the OIDC specification, which expects a persistent and static (list of) redirect URI(s), even when the application is set to confidential.
https://github.com/francoismichel/ssh3/blob/20f2894426742ee2fe92e33fa3d2521be7677b20/auth/openid_connect.go#L46-L56

https://openid.net/specs/openid-connect-registration-1_0.html#ClientMetadatahttps://openid.net/specs/openid-connect-registration-1_0.html#ClientMetadata

<IP_ADDRESS>. Authentication Request
redirect_uri
REQUIRED. Redirection URI to which the response will be sent. This URI MUST exactly match one of the Redirection URI values for the Client pre-registered at the OpenID Provider, with the matching performed as described in Section 6.2.1 of [RFC3986] (Simple String Comparison). When using this flow, the Redirection URI SHOULD use the https scheme; however, it MAY use the http scheme, provided that the Client Type is confidential, as defined in Section 2.1 of OAuth 2.0, and provided the OP allows the use of http Redirection URIs in this case. Also, if the Client is a native application, it MAY use the http scheme with localhost or the IP loopback literals <IP_ADDRESS> or [::1] as the hostname. The Redirection URI MAY use an alternate scheme, such as one that is intended to identify a callback into a native application.

This way it is not possible to set up an OIDC client application with an ID and secret pair that works, e.g. with GitLab.
OIDC Provider:

Application ID: $(openssl rand -hex 32), is generated by the identity provider, e.g. 6f1379417c8a5cae738bc030e5ddc59ec352af02704351e182727fb0136fe1fe
Secret: gloas-$(openssl rand -hex 32), is generated in the identity provider, here GitLab, e.g. gloas-48ac71b03fcf805a127ba614c88646956751e154c76b77991f909a918c21b86e
Callback URL: http://localhost/
Trusted: No
Confidential: Yes
Scopes: openid, email

Notes:

Confidential can also be set to No, since we are serving the redirect URI from localhost. Then PKCE authentication is required.
The scopes must be matching with what is requested by the client:
https://github.com/francoismichel/ssh3/blob/20f2894426742ee2fe92e33fa3d2521be7677b20/auth/openid_connect.go#L68

Server configuration:
~/.ssh3/authorized_identities

oidc 6f1379417c8a5cae738bc030e5ddc59ec352af02704351e182727fb0136fe1fe https://gitlab.example.com<EMAIL_ADDRESS>
Client configuration:
~/.ssh3/oidc_config.json

[
    {
        "issuer_url": "https://gitlab.example.com",
        "client_id": "<Application ID from above>", // e.g. 6f1379417c8a5cae738bc030e5ddc59ec352af02704351e182727fb0136fe1fe
        "client_secret": "<Secret from above>" // e.g. gloas-48ac71b03fcf805a127ba614c88646956751e154c76b77991f909a918c21b86e
    }
]

Note: The Readme speaks of config.json and also oidc_config.json, while the latter is the default when not using the -oidc-config flag.
https://github.com/francoismichel/ssh3/blob/20f2894426742ee2fe92e33fa3d2521be7677b20/README.md?plain=1#L262
https://github.com/francoismichel/ssh3/blob/20f2894426742ee2fe92e33fa3d2521be7677b20/cmd/ssh3.go#L454

The SSH3 server has been started first with
ssh3-server --bind '[::]:8443' -cert ~/ssh3-cert.pem -key ~/ssh3-priv.key -generate-selfsigned-cert -v

to generate the key pair.
Subsequent invocations fail, when the -generate-selfsigned-cert flag is passed, why the final command line reads:
ssh3-server --bind '[::]:8443' -cert ~/ssh3-cert.pem -key ~/ssh3-priv.key -v

When spawning an associated SSH3 client with
ssh3 -use-oidc https://gitlab.example.com -v server:8443/ssh3-term

the OIDC provider, here GitLab, responds with:

An error has occurred
The redirect URI included is not valid.

This also happens when using the PKCE authentication scheme:
ssh3 -use-oidc https://gitlab.example.com -do-pkce -v server:8443/ssh3-term

Primary ways of mitigating this could be:

[ ] Supporting the dynamic client registration protocol: Final: OpenID Connect Dynamic Client Registration 1.0 incorporating errata set 2
[ ] Using a static redirect URI on the client which can be preconfigured in the OIDC provider, e.g. by a convention for port and secret, or by allowing to configure them directly.
[ ] Providing a complete example in the documentation or in the Readme that explains the whole life cycle of setting up and configuring OIDC-based SSH3 logins at the Identity Provider (IdP; OIDC provider), in the SSH3 server and in the SSH3 client.

Additionally there may be a way to get rid of the client_secret on the client in case of only supporting PKCE authentication for non-confidential OIDC clients, e.g. by introducing a flat -require-pkce on the server.
References:

#99

I was going to open a ticket but I see there is already an existing ticket.
The Google OP requires a static redirectURI and does not allow wildcards. Google does let you wildcard localhost ports. The redirect URI http://localhost/ will work for all ports.

This is the error I get when I use SSH3 oidc with google:

What is the security goal?
Is the security goal of adding a random fragment to securely link the request to the OP with the response form the OP? If so OIDC already provides a more secure way of doing this using PKCE (RFC 7636: Proof Key for Code Exchange). The way it works is client creates:
$$CV \gets \{0,1\}^{256}$$
$$VC \gets \mbox{SHA256(CV)}$$
The client then adds VC to the auth request URI. Then to claim the ID Token associated with this request, the client must reveal VC to server. This means that even if an attacker intercepts the original request, the attacker only learns VC not CV. Additionally if the attacker triggers a redirectURI response which is not intended response from the client, when the client-supplies VC, it will break.
It looks like SSH3 supports PKCE, but the default in the SSH3 config is to for PKCE to be false.
doPKCE := flag.Bool("do-pkce", false, "if set perform PKCE challenge-response with oidc")
I don't see a reason why you would ever want PKCE to be false. Is there an OP that doesn't support PKCE?

The random port is also problematic for firewalls

@almereyda If you want to play around SSH OIDC with a fix redirectURI, I created a PR #144 You can just pull from my branch and use it.

One reason for using that randomly-generated path was to avoid other programs to hijack the token by sending a fake request to the ssh3 waiting on localhost, causing it to close the socket, and then the attacker could listen on the same port and retrieve the token like that. It seems doable on pretty much any OS.
But maybe am I missing something making such an attack undoable ?

@francoismichel If I understand your attack correctly, this was the attack that PKCE was introduced to defeat:

The clients chooses initiating the auth request chooses a value CV and VC=Hash(CV) and initiates the auth request by sending VC to the OpenID Provider (OP),
The user authenticates
The OpenID Provider does the redirect to the redirect URI sending the auth code to the client via the localhost socket,
The client sends the auth code and the CV value to the OpenID Provider  which returns the ID Token.

An attacker who intercepts the auth code by listening on the localhost socket can not redeem that auth code for an ID Token because the attacker does not know a value CV such that VC=Hash(CV).
This is the value of enabling PKCE.

There is another known attack here which neither PKCE nor a randomized redirect URI does not fix.

Attacker binds to a localhost port,
Attacker opens browser to initiate auth request,
User clicks I consent (in some IDPs that don't even need to consent if they have already consented for that client-id),
Attacker gets auth code and redeems it for the ID Token

The user looking at a browser window that popped up has no easy way to determine that this was opened by the legitimate service running on localhost. There two mitigations:

Use a port numbers lower than 1024 in your redirect URI ACL at the OpenID Provider. This means that an attacker requires root access to bind to a port that will accept by the redirect URI ACL. This also means that SSH3 client needs to setUID root functionality.
Use a cosigner like we do in OpenPubkey

Mobile device flows don't have this problem because app identity is known to the OS and so the iOS can enforce a map of redirect URIs to specific cryptographic identities associated with the candy crush app.

Why release the port at all? To be the same redirect URL and work best with reverse proxies and firewalls the port should be static anyhow. So I see no reason why the port should be release after using it?

@septatrix Releasing the port makes sense if you are using this as a cli where the cli isn't always running. The alternative is a daemon which starts at OS bootup and always holds that port or a set of ports, but that is a more complex client to build.

@septatrix Releasing the port makes sense if you are using this as a cli where the cli isn't always running. The alternative is a daemon which starts at OS bootup and always holds that port or a set of ports, but that is a more complex client to build.

Ah I was under the assumption that the SSH3 server would be the one receiving the token. That seems like the intuitive solution

Thanks for the discussion.
The attack with an attacker opening a browser window concurrently to SSH3 may not be easy to perform but it makes sense. I wish there was a generic way in OIDC to display some text to the user in the browser window so that it can check the browser window is indeed the right one.
The difference in this scenario however, is that the attacker must either be root or be running with the same rights as the current user in order to be able to show a browser window in its desktop session, while the previous scenario (the one avoidable with PKCE), the attacker just needs to be able to listen on a port.
The reason why PKCE is disabled by default is simply because I couldn't make it to work by the time with that specific version of the oidc module and the google OP, but I may give it another try now. We should probably list the common OPs that support PKCE well and enable it by default.

Concerning the random URL, I am not strongly against removing it, but we should probably ensure that PKCE is enabled then, and use the random URL if not.

I would also like to note that the RFC says to construct these loopback URLs using the numeric literals (<IP_ADDRESS> and [::1] respectively) instead of "localhost".
Another option (which would also be necessary when one wants to implement a mobile client for SSH3) is to use private-use URI schemes like be.francoismichel.ssh3:/oauth2redirect/. This is also possible on desktop OS though it requires a more traditional installation. E.g. on linux a ssh3.desktop file would be required

@septatrix My two cents:

Using numeric loopbacks seems reasonable. The only reason I like localhost is that is it generic to ipv4 and ipv6. It seems like it wouldn't be hard to just specify two redirect URIs one being the loopback for IPv4 and one being the loopback for IPv6.
How well supported is native-app OAuth in OIDC on the desktop? I haven't build any systems using it and I don't know if there are any gotchas. I agree on mobile devices private-use schemes is both well supported and a security requirement. Are protocol handlers still used for this?

@septatrix My two cents:

Using numeric loopbacks seems reasonable. The only reason I like localhost is that is it generic to ipv4 and ipv6. It seems like it wouldn't be hard to just specify two redirect URIs one being the loopback for IPv4 and one being the loopback for IPv6.

In Linux binding to ::1 defaults to dual stack mode, i.e. it also received IPv4 packets

How well supported is native-app OAuth in OIDC on the desktop? I haven't build any systems using it and I don't know if there are any gotchas. I agree on mobile devices private-use schemes is both well supported and a security requirement. Are protocol handlers still used for this?

Not really sure about this TBH


Add swagger alert for token param

To avoid misunderstandings in token I suggest adding a description to the swagger

Integrated, thanks!


Update Composer dependencies (2021-06-19-00-12)

Visual regression test passed!
View the visual regression test report


chore: Added the encrypted Chat_app by Parmesh Bhatt

Closes issue #1402
Description
Chat_app is encrypted and managed by the admin chat_app and no one can edit this.
Checklist for projects addition

[X] My project has contribution guidelines.
[X] My project has a Code of Conduct.
[X] My project has a README file.
[X] My project has a License.

In order to merge the pull request, it is essential that your projects include a contributing guide, code of conduct, license, and a readme. These requirements must be fulfilled without any exceptions.

any updates?


Interface harmonization of in-memory (vg.cpp) and on-disk (index.cpp) graph representations

(ported from README.md)

@adamnovak @glennhickey @edawson and I discussed this on a call the other day.
We should establish a list of functions that we'd like to have any vg-style object support. This should be pretty easy now that we've made five or six implementations of vg-handling libraries. If we can do this then the vg API can be implemented abstractly, and flexibility provided by giving different storage interfaces to the same system. For example, an xg-backed VG object should look basically the same as one that's backed by hash tables, although it couldn't be writeable. So perhaps there should be static and dynamic versions of the API, with the static one a read-only subset of the dynamic.


error handling should be added when priority level is larger than the number of nodes - 1 in TSP-PRI

https://github.com/Thinklab-SJTU/LinSATNet/blob/bf4a44a6b0f5aa241dfb1a623426c573378e9aa2/TSP_exp/utils/project.py#L26-L48
The following scripts should be added in L27
    if priority_level > node_num - 1:
        priority_level = node_num - 1
        print("FIXME : appropriate message")

Thanks for providing this corner case and the following is a detailed analysis:
In this problem, the second node should be visited within the first $priority\_level$ steps. As we are dealing with TSP with starting and ending nodes, the number of steps to take is $node\_num - 1$. The last step must be from an intermedium node to the ending node, so the remaining number of steps is $node\_num - 2$. Therefore, when $priority\_level \ge node\_num - 2$, the
priory constraint is redundant and the problem degenerates to TSP-SE.  So a more efficient implement should be: if $priority\_level \ge node\_num - 2$, not adding the last constraint (the shape of $A, b$ matrices need to change); else,  adding it.

I am closing this issue --- feel free to reopen it if the issue still exists!


Fix annoying Chrome nag on mobile

"[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event."

also 'touchmove' and 'wheel'


make Visitor not satisfy WideningTransformer

For consideration/discussion.
When working on https://github.com/ceylon/ceylon.ast/issues/107, I noticed that WideningTransformer<Null>s used as visitors perform better than Visitors. Prior to #107, timings where 63.31ms for the transformer, and 79.72ms for the visitor. I assume this is due to the extra object created by the Java backend for interfaces with default methods and the extra layer of indirection.
With this patch, the visitor takes only 28.33ms vs. 41.49ms for the visitor after #107. So there is a significant performance boost that would be meaningful to code that runs several passes of a visitor.
Now, this still isn't as fast as the typechecker's visitor, which I can only guess attains its speed from 1) being an abstract class rather than a delegate object, and/or 2) having void methods rather than Object-returning methods. These aren't things we can address.
The raw numbers:
-------------------
Initial (1.2.0 ast)
-------------------
countNodesTransformerNull:         63.31ms (control)
countNodesVisitor:                 79.72ms
countNodesTcVisitor:               14.76ms (control)

------------------------------
With visitor optimization #107
------------------------------
countNodesTransformerNull:         56.96ms (control)
countNodesVisitor:                 41.49ms
countNodesTcVisitor:               14.91ms (control)

-----------------
With fast-visitor
-----------------
countNodesTransformerNull:         59.25ms (control)
countNodesVisitor:                 28.33ms
countNodesTcVisitor:               14.94ms (control)

I want to have this change in 1.2.1, but I can’t merge this PR because it touches virtually every file in source/ceylon/ast/core, so it doesn’t apply right now, and even if I merged a fixed version right now, it could break when I made more changes in independent branches.
I think I’ll make this change right before the release, when everything else is already done. And, importantly, source-gen will have to be updated as well, to produce the extra visit method.
@jvasileff how did you produce this patch? Not manually, I hope…

how did you produce this patch? Not manually, I hope…

see the commit message for the precise steps :smile:

Whoa. Nice! Thanks!
I had avoided looking at the commit message because it also makes GitHub load the huge patch :D

We could also provide this class:
shared abstract class AbstractVisitor() satisfies Visitor {}

If your visitors extend that class instead of satisfying Visitor, the compiler doesn’t have to generate a thousand methods that just delegate to Visitor$impl. If you have a lot of visitors, this might have a significant impact on bytecode size – AbstractVisitor.class is 100K.

Interesting idea (AbstractVisitor)
I gave it a try to see if it would help with hotspot (less code to optimize). But it didn't seem to make a difference.
Since this is something space conscious users can do on their own, I think I'd probably wait to see what happens with the Java 8 version of the compiler.

Yeah, once we compile to Java 8’s default interfaces this should be obsolete anyways.

Done in 3fc1045f79a8cb2cf9df7e32977a35c52f1ecbf0.

Oops, wasn’t quite done yet.

Now done in 5cd395b, I hope.


Blank screen shown when changing from Account (token list) page to the Send Ether/THIBCoin page

On the Account List page, if I click an account it takes me to its Account page (which shows the token list associated with the account). If I then click on the Ether or THIBCoin card, it always shows a blank screen before it has loaded the Send Ether or Send THIBCoin page.
The blank screen doesn't usually last very long, but still the user may be left wondering why there isn't a loading screen (i.e. "Loading transaction page..." or similar) so they're confident nothing has gone wrong.
Since it's changing the route, we can't use the same approach as was done in this commit https://github.com/paritytech/fether/commit/854f1b4512823259832d5e9a237f3a6b27a8ae21

@ltfschoen Can you try if #414 solves your problem? It still has some corner-case bugs, but should mostly work as you'd expect (no loading screen at all).


embedding bokeh plot results in blurry slide

I am not sure why, but embedding a plot will result in both the slide text and the plot looking blurry.
Embedding is being done either as follows:
<object type="text/html" width="900" height="450", data="embed/plot.html"/>

Or by adding a script and div element into the html directly.  Can provide an example if necessary, and advice even if very general, would be appreciated.

not that the issue appears to be due to the fact that bokeh uses an html canvas, but for some reason the correct size information doesnt propogate to the bokeh canvas and as a result it looks zoomed in.

@amcpherson did you ever find a solution? I have this same problem when using chart.js.
For future reference I'll attach a screen shot showing how normal text renders fine (in the upper left), but the text rendered inside the canvas element looks ugly.

We have other issues related to screen size or resizing so I'm willing to have a look here.
@amcpherson you said you can provide an example, I'd like it to reproduce and understand.
Cheers,


Incorrect calculation of refreshing time OpenIDMetadata

Version
I am using botframework-connector==4.8.0
Description
We should update open id metadata once every five days. In the line https://github.com/microsoft/botbuilder-python/blob/master/libraries/botframework-connector/botframework/connector/auth/jwt_token_extractor.py#L129
        if self.last_updated < (datetime.now() + timedelta(days=5)):
            await self._refresh()

we can see that refreshing will be performed every time as self.last_updated will be always less then now + 5 days.
In order to fix this issue, we should change + to -. In that case, metadata will be refreshed once every 5 days.
For refreshing metadata, two additional requests are performed.

Hi @tracyboehrer, you closed this issue without merging my PR https://github.com/microsoft/botbuilder-python/pull/994.
Will you merge it or you are going to fix it in the scope of some other issue? Or maybe the logic works as expected?


Don't suppress 'dots' output for snippets tests.

CI aborts the run if the test goes longer than 10 minutes without emitting any output.
This change also eases running with verbose output for debugging long-running tests, e.g., nox -e snippets -- --verbose.
See #5003.

@dpebot Please merge.

You gotta tell her when
@dpebot will you merge when tests pass?

OK.  Maybe she should respond to non-understood mentions with a help message?

@tseaver maybe. The source is over here: https://github.com/GoogleCloudPlatform/repository-gardener/tree/master/webhook-app

Hmm, @dpebot doesn't seem to have picked up the baton here.

let me see why.

Oops, "ships passing".

It's fine, I still found the issue.

Thought: does --quiet prevent pytest from dumping fixture values on test failures? I recall @jonparrott had some frustration with that leaking things it shouldn't.

pytest shouldn't leak anything that I'm aware of. Also the real "secret" is the service account keyfile which is a file and thus would never be logged.


Animations Fail To Load Under Firefox

Using firefox 38.7.1 animations do not render. Opening up the console I can see:
"InvalidCharacterError: String contains an invalid character"
The line number and column correspond to the start of the minified javascript and no other errors are displayed. All other types (streams/static captures) appear to render fine.
I attempted to build a version of the animate.html template without the minification to make more sense out of it, but the node package ecosystem had other ideas.

I'm away from my workstation at the moment. But, that error originated from atob when I was using line breaks in the base64 string.  Maybe it has something to do with the leading newline after the script tag?

No problem.
It doesn't look like changing linebreaks in the generated file fixes things. Throwing a console.log(e) before the atob(e) call shows that e is undefined, which is presumably not the value that was expected.

I bet if you changed innerText to textContent it'll work in Firefox.  I'll look into it more when I get back.

Yep, that fixes the issue. There's a chance you might just be a javascript wizard.

An update is inbound.  This incidentally fixed the scrollable renders, too.  Thanks!

There's a chance you might just be a javascript wizard.

I wish!  Those guys are smooth with the ladies.


Feature/au 278 omat tiedot tunnistamosta

Adds integration to Yrtti + Tunnistamo and fetches user data from those services. Also prefills form fields with said data.
To test:

Normal git pull.
Checkout integration modules manually to /public/modules/custom

https://github.com/City-of-Helsinki/drupal-module-helfi-yjdh -> develop branch
https://github.com/City-of-Helsinki/drupal-module-helfi-helsinki-profiili -> develop branch

Drush cim / Drush si / make new

Tests fail because of the missing modules:
Unable to install the helfi_helsinki_profiili module since it does not exist.
Unable to install the helfi_yjdh module since it does not exist.


Remove unintended double negation in docstring

Small typo fix.
ImportError: If importing vertexai SDK didn't not succeed. -> ImportError: If importing vertexai SDK did not succeed..

thanks @BioGeek!


How to use component?

How do I use the components from this library?
Why is there no example or installation guide in the readme?

Currently, there is no guide on how to install and also an example of how to use the component because this library is under development and may change a lot in the future.
If you want to try out the dev version components you can use this configuration theme in your react native project
Create unistyles.ts


LOCAL_POSITION_NED Cant Init After Arming

Hi,
I recently updated the PX4 firmware through QGC 3.0.0. I used GPS for position estimate, then I used mavlink inspector to monitor the local_position_ned, and I found after I armed the FCU the position didnt initialize(x,y,z cant become 0). I used OFFBOARD to control the multicopter, then it turned over.how can I fix it?
Any help is appreciated.

Duplicate of #5604.


Add test CI stage to find crashes and memory leaks automatically

This PR adds simple opening and checking of editor and project as CI stage.
This will allow to find PR which will cause crashes or memory leaks, before merging them to main repository.
This fixes https://github.com/godotengine/godot-proposals/issues/1358
It depends on https://github.com/godotengine/godot/pull/44399 because uses GLES 2.
Test project is https://github.com/qarmin/RegressionTestProject which contains its own CI to be sure that project update will not introduce unexpected errors.
There are a few changes when comparing this PR with  https://github.com/godotengine/godot/pull/40994(for 3.2 branch)

There is only 1 step with opening editor - Git repository of test project now contains ./godot folder with imported earlier resources
Project running time is 30s instead 25s because editor opens a lot slower due compiling shaders
For now checking for memory leaks is disabled, because for now there is a lot of memory leaks in GLES 2 backed

Example CI log - https://github.com/qarmin/RegressionTestProject/runs/1620701731

Closing for now since test CI with Vulkan was merged.


Consider that some fields are optional when generating the vehicle name

Consider that some fields are optional when generating the vehicle name

Hey @hudsonbrendon the version in the manifest.json file has not been changed, so updates will not arrive for those who already have version 1.0.1 (which is the manifest version).


fix read_fifo to always define packet before return, Correct typo in dosctring

fixes #5
fixes #4
I was not able to reproduce the OP issue for #5 but the fix appears to have worked for the OP and is better coding practice.
Tested with rfm69 and rfm9x bonnets on Raspberry Pi.

@tekktrik When you have a chance would you take a look at my attempt to resolve this. Let me know if it looks OK.


Add builtin:logmonitoring.log-storage-settings to CR and reconciler

Description
Ticket
With this it is possible to define ingest rule matchers in the dynakube. This configuration needs to be stored in settings (schema builtin:logmonitoring.log-storage-settings) in the scope of the current cluster ( = KubernetesClusterMEID).
This logic queries inside the logmonitoring reconciler all settings with this schemaID, and if there is none, we create new ones based on the defined ingest rule matchers in the dynakube (default is empty).
IF we query the settings and there are already some defined, I decided to add a condition to the dynakube that says exactly that.

How can this be tested?
Go to the Environment API v2 page in your tenant and try it out. It is in the Settings section. At first you'll need to enable com.compuware.apm.webuiff.config.core.hierarchy.resolution.pg.k8workload.pgwlhr.feature
Deploy a dynakube with a valid logmonitoring section for example:
  logMonitoring:
    ingestRuleMatchers:
    - attribute: "k8s.deployment.name"
      values:
        - "dynatrace"
        - "anothertest"
    - attribute: "k8s.container.name"
      values:
        - "testContainerName"
  templates:
      logMonitoring:
        imageRef:
          repository: us-central1-docker.pkg.dev/cloud-platform-207208/chmu/logmodule
          tag: latest

Wait a little bit then run in the environment API page the get query for the settings with the schema. See if it is created properly.
It should look like this:
{
  "items": [
    {
      "objectId": "vu9U3hXa3q0AAAABACpidWlsdGluOmxvZ21vbml0b3JpbmcubG9nLXN0b3JhZ2Utc2V0dGluZ3MAEktVQkVSTkVURVNfQ0xVU1RFUgAQMDFGNjZGMjkxRjBENjU0MAAkMzcxM2RjMDktMDYzNC0zMjM0LTlhNTAtYTg4MTA4OGY2YmI0vu9U3hXa3q0",
      "value": {
        "enabled": true,
        "config-item-title": "dynakube-test",
        "send-to-storage": true,
        "matchers": [
          {
            "attribute": "k8s.deployment.name",
            "operator": "MATCHES",
            "values": [
              "dynatrace",
              "anothertest"
            ]
          },
          {
            "attribute": "k8s.container.name",
            "operator": "MATCHES",
            "values": [
              "testContainerName"
            ]
          }
        ]
      }
    }
  ],
  "totalCount": 1,
  "pageSize": 100
}

You can then grab the objectID, delete the setting and reapply a dynakube with an empty logmonitoring section and see if default settings gets created.
That looks like this:
[
  {
    "schemaId": "builtin:logmonitoring.log-storage-settings",
    "scope": "KUBERNETES_CLUSTER-D3A3C5A146830A79",
    "value": {
      "enabled": true,
      "config-item-title": "my-cluster-name",
      "send-to-storage": true,
      "matchers": []
    }
  }
]

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 32.09302% with 146 lines in your changes missing coverage. Please review.

Project coverage is 64.43%. Comparing base (d389598) to head (bde9ad7).

Files with missing lines
Patch %
Lines

test/mocks/pkg/clients/dynatrace/client.go
29.41%
36 Missing and 12 partials :warning:

pkg/clients/dynatrace/settings.go
0.00%
28 Missing :warning:

pkg/clients/dynatrace/settings_logmonitoring.go
64.17%
16 Missing and 8 partials :warning:

...a3/dynakube/logmonitoring/zz_generated.deepcopy.go
0.00%
19 Missing and 1 partial :warning:

...g/controllers/dynakube/logmonitoring/reconciler.go
23.80%
11 Missing and 5 partials :warning:

pkg/util/conditions/settings_logmonitoring.go
0.00%
8 Missing :warning:

test/mocks/cmd/remote_command/executor.go
0.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4053      +/-   ##
==========================================
- Coverage   64.66%   64.43%   -0.24%
==========================================
  Files         397      399       +2
  Lines       26466    26678     +212
==========================================
+ Hits        17115    17190      +75
- Misses       8023     8135     +112
- Partials     1328     1353      +25

Flag
Coverage Δ

unittests
64.43% <32.09%> (-0.24%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I removed ingestRuleMatchers from logMonitoring section to get empty logMinitoring: {}. Then I updated my dynakube and had to wait ~9 minutes for the default matcher to be added to the settings object on the server. Is it OK? I guess we need to limit the number of queries we sent to the server. On the other hand it is a little bit annoying.

Just a sidenote which is important IMO: we not only removed the ingestRuleMatchers in the dynakube but we also removed the settings in the Environment API manually while the condition was stored in the dynakube that there are already settings, then edited the dynakube -> this led the waiting time. IMO i think this is ok, as I do not think it should be a normal use case to delete the settings in the API manually while everything is up and running. But maybe @chrismuellner has more context there and knows more.

Operator currently has no good way of reacting to changes done on the Dynatrace API side. We are listening and reacting to changes in the Kubernetes cluster and need to find a way to better/quicker react to external changes.
This is not something we can quickly fix here, but we'll need to properly think about options we have. For the initial feature the delay is acceptable.


fCNV dies on .cnv files with lines containing only "*"

Using seabird 0.8.0 on Anaconda 4.1.11 on OS X 10.10.5. I have data from a 19plusV2 processed using SBEDataProcessing <IP_ADDRESS>. This version produces .cnv files with lines containing only "*" inside the <InstrumentState> tag. Example below:
* <HardwareData DeviceType='SBE19plus' SerialNumber='01906651'>
*
*    <Manufacturer>Sea-Bird Electronics, Inc.</Manufacturer>
*
*    <FirmwareVersion>2.2c</FirmwareVersion>
*

When trying to process a file like this, fCNV dies with the error There are no rules able to parse the input. File: myfile.cnv.
Deleting all the lines containing only "*" in the cnv enables fCNV to parse the file without issue. I don't know enough about yaml rules to submit a fix, unfortunately.

I'd like to chime in that I'm also having this problem.
In addition, fCNV fails when there are blank lines.  Again, deleting these blank lines, as @dnowacki-usgs did for the lines containing only "*", worked.

Hi @dnowacki-usgs  and @porterdf,  thanks for the notes.
The branch dev was patched to handle your files. That should work fine for now, but I'll properly address that and upgrade the package in the first chance. Hopefully in the following days.
Thanks!

Thanks @castelao!  BTW thanks for developing this super useful package.

Resolved in the latest official release, 0.10


Supporting the feature; Biometric authenticator to integrate with mobile devices, in WSO2 Identity Server..

Biometric Authenticator to integrate with mobile devices
Problem
Biometric authentication is a missing functionality as of now in WSO2 product IS.
Implementation of a biometric authenticator which can be integrated with mobile devices would solve this problem and would give an extra layer of authentication with biometrics.
Insights behind the feature

Bringing OOTB support for biometric authentication

Integrating a passwordless solution for authentication from biometrics is way simpler and faster for the user.

Biometrics is an inheritance factor(something that you are). Hence it's one of the most secure authentication methods to authenticate a user with the fingerprint.

Biometric authenticators in the mobile devices are easily accessible to users.

Design
Architecture mail thread: https://markmail.org/message/r2scjjbxfjfdd7yd
The design includes:

Two main components (Biometric authenticator and the new endpoint at "/biometric-oath") - related PR wso2-incubator/identity-outbound-auth-biometric#3

Android mobile application - related PR wso2-incubator/identity-outbound-auth-biometric#5

Documentation
https://docs.google.com/document/d/1URKLwzGE8HOzGIsLfGkTbyCgOmEFasqitJZuzuyvCLk/edit?usp=sharing

Sequence flow
Device registration flow (Not yet implemented.)

Biometric authentication flow (Implemented.)

Android application
Here are the activites / user interfaces involved in the android application which is developed in kotlin.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Constant time requirements in the specification.

A/O the meeting on Nov 6'th 2020, we have decided the following wrt. constant time requirements for certain instructions.
Instructions affected:

mul
mulh
mulw
mulhu
mulhsu
clmul
clmulh

All of these instructions are important for cryptographic use cases. They are used to handle secret data, and so their execution latency must not depend on the values of their inputs.
Cores implementing the cryptography extension must check the relative values of the registers addresses rs1 and rs2 for each instruction.

If compare(rs1,rs2) (The exact comparison <, <=, >, >= is not decided just yet.), then the core must execute the instruction such that its execution latency is not dependant on the value of GPR[rs1] or GPR[rs2].

If the complement of the constant time condition is true, then cores may execute the instruction such that its latency is independent of its input values, but it is not guaranteed to.

If a core always implements its multipliers such that their latency is independent of their inputs, then no comparison between register addresses is needed.

These requirements will be put in a dedicated section of the specification.

We considered another option for enforcing constant time behaviour: A CSR bit which when set, would force certain instructions to behave in a constant time manner. We decided against this to avoid introducing extra state.
The only other alternative would be to introduce guaranteed constant time variants of the multiply instructions (e.g. ctmul, ctclmul), but we considered this wasteful of instruction encoding points.

Closed with spec release v0.7.2-scalar


Could you please explain why the default full viewer cannot be directly used??????

Hi,
I'm going to be polite. This non-sense is baffling: Setup-pdf.js
And from an older issue: Issue 9210 Quote: "Hence we don't want to make it too simple to use it directly." Honestly, what is that????
What I'm supposed to do? Go through the ~2000 LOC of PDFViewerApplication from web/viewer.js to just make the full viewer work? Now I think I understand why it wasn't added under examples. Can you please explain what's the whole point of this crap?
Maybe you can learn a bit from Leaflet, simply adding proper attribution should be enough provided you want credit. Please make things simpler and easier, and not harder as quoted. No one wants to waste time.

This behavior is not tolerated here.


Deploy Mimir on CAPA installation

Add Mimir into CAPA app collection
Deploy Mimir onto all CAPA testing installation

Mimir is deployed to capa app collection

I guess we should wait to have a working mimir on golem before enabling it on all other CAPA installations.

Do not forget to remove the golem silence and the opsgenie policy for golem

Gazelle rollout PR: https://github.com/giantswarm/giantswarm-configs/pull/101


Mater Detail for orgs dashboard

Implemenation of dashboard master detail pattern to acheive omni box update with selected item route. Issue https://github.com/getcouragenow/packages/issues/386

Implemented a master detail wrapper which is reuseable
On clicking the item on left, now pushes the route to right , impemented custom route,by overriding overlay entries. Now the pushed route takes on the width availble to the right side of left pane.
Selected item shows selection but on pop selection doesnt updates. - needs to be worked on
copy paste url high lights the right selection

Note : It needs to be tested in CI, i will test and update the issue  https://github.com/getcouragenow/packages/issues/386 if something is not right

thanks.


Provide a control to reduce or hide the lower compartment

Provide a control to reduce or hide the lower compartment. People have requested more diagram/tile real estate for large inventories.

Added a new raise/lower control button on the far right side of the lower compartment.

When the compartment is lowered, it releases almost 30% more page space to the diagram or tile view.

The state of the compartment is saved into API settings and restored when the tool is reloaded.


Challenges ID3

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified


Identity Setup - Type Error - Windows Kit folder

electron-windows-store quits with an TypeError during first use.

You need to install a development certificate ... (Y/n)
Y
Welcome to the Electron-Windows-Store tool!
...
Please enter the location of your Windows Kit's bin folder: (C:\Program Files (x86)\Windows\Kits\10\bin\x64)
hit enter =>

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    ...
    at inquirer.prompt.then (...lib\setup.js:161:31)

Also happens when actually entering the path. I'm on a 32 bit machine - also tried C:\Program Files (x86)\Windows\Kits\10\bin\x86.
// edit
When I look at setup.js:161 this might be an issue w/ the input for the publisher identity. I entered two words (don't know yet what exactly goes in there).
node v6.2.1
npm 3.10.2
// edit 2:
setup.js:160 is the issue:
let publisher = dotfile.get().publisher.split('=')[1]

There's nothing to split as dotfile.get() returns an object and publisher already contains the actual content. That leads me to the thought that my input might be invalid.
What exatly goes into the identity prompt?
Guess those lines could use some extra explanation + some more robustness.

Guess the input should be something like CN=whatever


Uncompileable javascript generated by numeric names for enums.

Describe the bug
To Reproduce
Steps to reproduce the behavior:

My GraphQL schema:
For example, the graphql type

enum NumberEnum {
  _25
  _50
  _75
  _100
}

Generates this code:
export enum NumberEnum {
  25 = "_25",
  50 = "_50",
  75 = "_75",
  100 = "_100"
}

which is incorrect and does not compile in typescript:
[tsserver 2452] [E] An enum member cannot have a numeric name.

My GraphQL operations:

Not applicable. (I think?)

My codegen.yml config file:

Not applicable. (I think?)
Expected behavior
Maybe generate this instead?
export enum NumberEnum {
  _25 = "_25",
  _50 = "_50",
  _75 = "_75",
  _100 = "_100"
}

Environment:

OS: mac os
@graphql-codegen/typescript:
NodeJS: 10

Additional context

Hi @merisbahti
You can use namingConvention to override the enumValues transformations:
config:
  namingConvention:
    enumValues: keep


Support For No-std

Objective
The addition of no_std support would effectively improve the range of usage of the coinselect library. It is quite advantageous at this point that very little external dependencies exist , in this light it would be quite straight forward for the support of no_std environment to be implemented.
Changes Required
A require change is the  inclusion of the attribute  in the lib.rs file
#![no_std]

#[cfg(feature = "std")]
extern crate std;

which ensures that no_std is the default state.
In the toml file we need to ensure no_std for the rand dep is recognised with such lines :
[dependencies]
rand = { version = "0.8.5", default-features = false , features = ["alloc"] }

[features]
std = ["rand/std"]

This is also required for functions that requires std functionalities
#[cfg(feature = "std")]

pub fn function_that_requires_std() {
    // ...
}

I would begin working on it which i believe the code might clarify some questions.


Add Swapnil Sharma to Contributers list

@Roshanjossey

@swapsha96, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Comparison with cycle-accurate Simulators

I'm having issues using the csv_compare method to verify that two traces are matching. I'm using Spike as a golden reference. However, Spike is instruction-accurate, while the RTL model is cycle-accurate. Because of this, the results of instructions are not necessarily written-back in program order (for example with a multi-cycle multiplier), which creates a discrepancy with respect to the Spike log.
I could easily modify the comparison function to fix this, but I am asking to make sure I am not missing something, as this issue is something I suspect already came into consideration. Also, other verification projects make no changes to the csv_compare method.
Am I missing something or is csv_compare dependent on in-order commit logs?

I have the same problem, the RTL model is cycle-accurate and my core have multi-cycles function unit (MCFU). So the result of RTL doesn't fit the Spike log, to solve that i only comparing only register value change. Should I do that to solve the problem?


In rails engine: `require': cannot load such file -- street_address (LoadError)

Hi,
I'm trying to make this a dependency in a Rails Engine.   Has anyone tried this?  I can't figure out how to get a model within the engine that requires StreetAddress to work.  I've tried putting "require 'street_address'" in engine.rb, railtie.rb application.rb within the engine.
Thoughts?
Thanks all!
Jonathan

Hi @futbolpal I have used this dependency in Rails. And Its working correctly. See example.
2.1.0 :001 > User.last.street_address
=> #<StreetAddress::US::Address:0x00000008036e40 @number="1600", @street="Pennsylvania", @street_type="Ave", @unit=nil, @unit_prefix=nil, @suffix=nil, @prefix=nil, @city="Washington", @state="DC", @postal_code="20500", @postal_code_ext=nil>
please provide explanation of what you exactly want in your model, so it will helpful for find out solution.
Thanks.


no matches for kind HorizontalPodAutoscaler

Describe the bug
A clear and concise description of what the bug is.
helm install --name=istio-operator --namespace=istio-system banzaicloud-stable/istio-operator --version 0.0.51
NAME                   READY   STATUS             RESTARTS   AGE
pod/istio-operator-0   1/2     CrashLoopBackOff   5          5m29s
Log
{"level":"error","ts":1593166431.6729662,"logger":"kubebuilder.source","msg":"if kind is a CRD, it should be installed before calling Start","kind":{"Group":"autoscaling","Kind":"HorizontalPodAutoscaler"},"error":"no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta2""
Steps to reproduce the issue:
helm repo add banzaicloud-stable https://kubernetes-charts.banzaicloud.com
helm install --name=istio-operator --namespace=istio-system banzaicloud-stable/istio-operator
Expected behavior
it should install istio 1.6.3
Screenshots
Additional context

@satishmane, thanks for the issue!
What is your Kubernetes version and which cloud provider and Kubernetes distribution are you using?

Also, what does this say to you?
kubectl api-versions | grep autoscaling

thanks @Laci21
Kubernetes version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.4", GitCommit:"c96aede7b5205121079932896c4ad89bb93260af", GitTreeState:"clean", BuildDate:"2020-06-18T17:02:08Z", GoVersion:"go1.13.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.10-gke.36", GitCommit:"34a615f32e9a0c9e97cdb9f749adb392758349a6", GitTreeState:"clean", BuildDate:"2020-04-06T16:33:17Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}
cloud provider
Google GKE
kubectl api-versions | grep autoscaling
autoscaling/v1
autoscaling/v2beta1
internal.autoscaling.k8s.io/v1alpha1

The Istio operator supports Kubernetes 1.15.0+: https://github.com/banzaicloud/istio-operator#istio-operator-installation
You are on v1.14.10-gke.36, so please try with a higher Kubernetes version to be able to properly use the operator.
Also, you should have autoscaling/v2beta2 enabled on your cluster, which should be the case by default with higher Kubernetes versions on GKE.

@Laci21 thanks


drafting linked audiences public beta

https://segment.atlassian.net/browse/DOC-856

Closing this PR for now.


IntegerTransition on Width/Height throws error

setting an IntegerTransition to Property Width/Height throws an error: Invalid property type "Int32" for this transition: IntegerTransition.
Yet DoubleTransition does not, but width/height snaps to the new set width/height.
<UserControl xmlns="https://github.com/avaloniaui"              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"              xmlns:d="http://schemas.microsoft.com/expression/blend/2008"              xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"              mc:Ignorable="d" d:DesignWidth="60" d:DesignHeight="60"              x:Class="AvaloniaApplication1.Views.TopBarView" Background="Red" Height="{Binding TopBarHeight}" Width="{Binding TopBarWidth}">   <Panel Height="{Binding TopBarHeight}" Width="{Binding TopBarWidth}">     <Grid RowDefinitions="60,60,60,*" ColumnDefinitions="60,60,60,*">       <Button Grid.Row="0" Grid.Column="0" Background="Yellow" Command="{Binding TopBarButtonPressed}"></Button>     </Grid>     <Panel.Transitions >       <IntegerTransition Property="Width" Duration="0:0:2"/>       <IntegerTransition Property="Height" Duration="0:0:2"/>     </Panel.Transitions>   </Panel> </UserControl>
TopBarButtonPressed sets/expands the UserControl from code-behind;

@Wyvernius with how the animation type registry is wired, the transitions and animators will only work with a property that has the exact type as defined in their registry. Hence IntegerTransition will only work with Int32 types and so on.

That would be because Width/Height is a double, not an Integer. Use DoubleTransition instead of IntegerTransition (even tho Transitions seems to be broken on controls with a Width/Height property which I'm about to make an issue on)

2022 and still having this issue, but now when applying DoubleTransition to Width/Height property I get this error

<Grid.Transitions>
    <DoubleTransition Property="Height" Duration="0:0:1" />
</Grid.Transitions>

I'm setting the transition property in the grid object itself

Closing as integer transition is not supposed to be used with doubles. If you need custom behavior with rounding, you can create custom transition.
@aragubas


Enhancement: Clear Browser Cache when Idle

Describe the Bug/Feature
As a former user of Self-Destructing Cookies, I am very glad to see "Cookie AutoDelete" already in place as its successor, which does its job (in my case) even better than SDC.
I noticed though that there seems to be no option implemented to delete the browser's cache, after a set idle time (like SDC had). I looked through the existing issues and documentations on here, but it doesn't seem to have come up yet. My question therefore is, is a "Clear Browser Cache when Idle"-function implementable, or is it prohibited by webExtension limitations?

Yes it should be possible but I think that feature "should" probably be it's standalone extension as it can't make use of the whitelist/greylist.
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browsingData/removeCache
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/idle

Is it really necessary to "exile" this function into a separate extension? It has been part of SDC for a long time, is closely linked to the purpose of this addon, and could be deactivated by those who don't want their cache being cleared automatically.

I would rather have this feature and similar ones (which can be generalized as delete browsing data on idle) be in a separate extension that someone else can do.

@mrdokenny I think this is a good idea to have this just like self-destructing cookies had it. Why cant you integrate this? no need to have whitelist/greylist a part of clearing browser cache on idle.
Its a needed feature together with removing/clearing cookies.

@2SI3NX The browsingData API has all these data that you could remove. The reason why those functions should be a separate extension is

"Clearing Cache on Idle" doesn't rely on any of CADs functions

Localstorage is an exception cause there's a hostname parameter

If I implemented for just cache, I would have to add settings for all of them, which can bloat the settings page
I have to request the idle permission which will show up in an update
Modularization of code so it is easier to manage

Anyways if no one creates it, then I'll probably make one at some point. :)

@2SI3NX I discovered that uMatrix has a built-in "Cache clearing after set time" feature, maybe that's an alternative for you as well.

@spodermenpls thanks for the info, although the point is to have this in one addon just like SDC had it. and not to bloat firefox with an additional addon only to clear cache automatically.  SDC set the bar for users really high, they learned by having a sort of 'two in one' solution and thats why it was the best.
I believe Cookie-AutoDelete is the next best thing after SDC - however, missing features that the user was previously used to will make Cookie-AutoDelete look less impressive than SDC. i cant stress enough how important this is.
I have to manually clear cache because it:

grows too big (even though i can set a limit)
and sometimes pages dont load properly because something went wrong in the cache.

@mrdokenny i have high hopes for Cookie-Autodelete and il report as many bugs as i can, i hope you can implement this feature. thanks very much.


Matplotlib's drawstyle ignored

Setting the drawstyle seems to get ignored, any ideas?
http://nbviewer.ipython.org/gist/iiSeymour/c2abb463be92e7ec115c

I have taken a quick look at this as I want to use a subplot in interactive plots that uses draw style steps (and don't want to mess with that library).
The end outcome looks like it should all happen in src/elements/line.js by toggling
this.datafunc = d3.svg.line().interpolate("linear")
to:
this.datafunc = d3.svg.line().interpolate("step-before")
or
this.datafunc = d3.svg.line().interpolate("step-after")
There does not seem to be a clear d3 equivalent of drawstyle='steps-mid'
How to pass in the draw style seems to have two potential options, adding a drawstyle argument to the function, or passing as a component of props.  Personally I would lean towards a drawstyle argument.  Translation from the mpl dialect of "step" to "step-before" should happen in this function as well.
Drawstyle would be detected in exporter.draw_line and a switch implemented to pass directly to renderer.draw_line paralleling the marker implementation.    renderer.draw_marked_line is the only other place I can see modifications required.
I will reflect on this a little then try and get a pul request together, but thought I would add some notes here in case my follow through is lacking

Thanks for looking into this!
Here is the code from the d3js step-before and step-after options: https://github.com/mbostock/d3/blob/0d639efa9b78775bef6b1b5c59d6e7da31e85e72/src/svg/line.js#L125-L143
It might not be too bad to add a step-mid option.

I ended up implementing via linestyle as it was cleaner and less likely to break other renderers.
Pull requests submitted for both mplexporter and mpld3.  Visual tests all checked.


Engine -> Framework roll failing on Dart trace event change

flutter/dev/tracing_tests/test/image_painting_event_test.dart is failing repeatedly in https://github.com/flutter/flutter/pull/116907 from the new field __destinationStream in the trace event.
https://ci.chromium.org/ui/p/flutter/builders/try/Linux framework_tests_slow/2576/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux framework_tests_slow/2571/overview
Guessing it's from the Dart roll https://github.com/flutter/engine/pull/38187 and maybe from https://dart.googlesource.com/sdk.git/+/4981cbffe2f66db3a0cc8eced18085e03fbbb8ba
@bkonyi

cc @christopherfujino in case the test needs to be updated.

Looks like the change in Dart was reverted at https://dart-review.googlesource.com/c/sdk/+/274802. Leaving this open to monitor the rolls recovering.

FYI @CoderDake

Thanks for bringing this to my attention @bkonyi
Sorry about this breaking your tests, You are correct that the change was reverted this morning.
It was my fault that the revert didn't go through on Friday when it should have.
Is there anything I can do to help with this as the revert stands?

The forward fix worked, and the roll has landed https://github.com/flutter/flutter/pull/116920


 Please explain in details what do you want and why

closing as no answer from reportee


[move] IR module definitions require an address

In Move source language, module definitions must either have leading addresses specified (module 0x42::M { ... }), or be defined within an address definition (address 0x42 { module M { ... } }). In Move IR, however, modules cannot be defined with an address, and instead command-line tools that process the IR specify the address under which to publish the module.
Remove the ability to pass in addresses from the command-line with Move IR, and instead require modules to be defined with a leading address.
What's in this pull request?
This is a large pull request, so I'll explain myself a bit. At its core this does one thing: modify the move_ir_types::ModuleDefinition so that instead of a name: ModuleName, it has a identifier: QualifiedModuleIdent field, and modify the parser to parse a leading address for that change. This requires module definitions to have leading addresses, so most .mvir tests, and some tests that define MVIR programs as strings (such as in the e2e-testsuite) need to be modified in order to pass (this is why this PR touches 300+ files).
Everything beyond that is "optional," but I decided to bundle these changes up together rather than touching hundreds of files in multiple pull requests. These changes include:

Since it's now unused, the compiler executable no longer needs to take an --address argument, so I deleted it. A module's address is the one it's defined with; the one passed in on the command-line is now meaningless and would be confusing to keep around.
Specifying an address is also now obsolete when invoking the IR compiler programmatically. So I removed the address: AccountAddress arguments from functions related to parsing Move IR, or compiling Move IR modules into bytecode modules.
The Compiler trait used by functional tests defined a compile method took an address argument. This argument was unused by the Move source language compiler, and now it's unused by the IR compiler as well (the only two objects that implement this trait). So I removed the argument from the trait method.
The transactional test runner's "publish" command required an --address argument be specified only when compiling Move IR. That's no longer necessary in the Move IR case, so I removed the argument altogether. This also means all transactional tests need to be modified to no longer pass that argument, which would be another large pull request -- that's part of my rationale for bundling all these changes together in one pull request.

What about address 0x42 { module M { ... } } syntax for Move IR?
I dunno, do we need it? Move IR exists almost entirely for writing tests for the Move VM, and most of those tests would not define multiple modules within a single address block. Supporting that syntax would make things more complex.
None of the changes in this pull request prevent that syntax from being supported, though. Even if Move IR were to be modified to support that syntax, the vast majority of the 300+ test files modified in this PR would not be modified. So IMHO it's better to land this PR first and potentially make that change later.

I think the exact reason why we had this module M syntax is address 0xA { module M {} } syntax used to be our main way of writing tests and it's easier for us to migrate to what it was. Now that we have all those new syntax in movelang I think we should just safely deprecate the address 0xA { module M {} } and this PR is really a clean first step

/land


Pre-format copied text in code editor for Markdown code display

Issue Description
Currently, the Gitter chatrooms have a bunch of unformatted snippets being posted by users who aren't aware/CBA to correctly format their text. This leads to decreased readability and a longer wait time to receive help, and stops questions that involve snippets from standing out.

Instead of seeing this:
function repeatStringNumTimes(str, num) {
  if (num < 0) return '';
  return str.repeat(num);
}

repeatStringNumTimes("abc", 3);

We see a lot of this:
function repeatStringNumTimes(str, num) {
if (num < 0) return '';
return str.repeat(num);
}
repeatStringNumTimes("abc", 3);

Suggestion
Instead of placing the onus on less experienced users, FCC can do the heavy lifting, leading to an all-around better experience.
Here are some ways I can see doing this:

Add 4 spaces before every line in the code editor. While this might be the easiest approach, it is, IMO, also error-prone and could make it harder for users to understand how to correctly space/format text for readability.

Add ```\n and \n``` to the beginning and end of the copied text, stripping out any newlines at the front or back of copied text first. This should have the most success in correctly formatting the text without affecting the user's experience in the code editor, but I'm sure there are plenty of edge cases where this may not be possible to apply to a user's copied selection. Same goes for adding 4 spaces to the beginning of every line in the copied text, which would probably be even more difficult to handle without errors.

Add a "copy code" button, utilizing one of the aforementioned methods of adding proper formatting, which might be easier to serve up compared to interacting with a user's clipboard.

The super fast and easy way which I'm sure alludes me but sticks out to you. (Suggest it below!)

@noahkiss thanks for the suggestion. This would be very convenient to have, but this would probably be a fairly low priority given the current projects fCC is working on right now. Also, another solution is to be put the onus on beginners to know how to format their code. You can find the discussion here. I'll leave this open for others to comment as well.


[openapi-alps] Upgrade build image to Ubuntu 20, use pre-installed git

Fixed in https://dev.azure.com/devdiv/DevDiv/_git/openapi-alps/pullrequest/460155


Add Influxdb v2 workaround to docs

Hi
UniFi Poller can talk to InfluxDB 2.0 using DBRP mappings : https://docs.influxdata.com/influxdb/v2.0/tools/grafana/?t=InfluxQL#view-and-create-influxdb-dbrp-mappings
Once your InfluxDB 2.0 bucket is created (using CLI or 8086 web UI) :
# influx bucket list
ID                      Name                    Retention       Organization ID
f2763f172b50dea3        _monitoring             168h0m0s        143f24876e1ec5d2
74e9f584fccacedc        _tasks                  72h0m0s         143f24876e1ec5d2
7112dfae5d1aa164        unifi                   8760h0m0s       143f24876e1ec5d2

# influx v1 dbrp create --db unifi-db --rp unifi-rp --bucket-id  7112dfae5d1aa164 --default
ID                      Database        Bucket ID               Retention Policy        Default Organization ID
075053f3abe50000        unifi-db        7112dfae5d1aa164        unifi-rp                true    143f24876e1ec5d2

# influx v1 auth create  --read-bucket 7112dfae5d1aa164 --write-bucket 7112dfae5d1aa164 --username unifi-user
Please type your password:

Please type your password again:

You then just have to fill up.conf :
[influxdb]
  disable = false
  url  = "http://influxdb:8086"
  user = "unifi-user"
  pass = "mysuperpassword"
  db = "unifi-db"

Originally posted by @Fredouye in https://github.com/unpoller/unpoller/issues/255#issuecomment-812365646

Which settings do you use for Grafana? I'm having trouble adding a datasource with those settings.

Has anyone managed to make the dashboard work? Mine seems not getting any data, even if I can see they're flowing to DB in influxDB GUI and on unpolled logs seems to receive them.
In grafana seems that the right DB is not showing even if test & save works fine

I had to do an additional step for it to work - initially, influxDB appeared fine, grafana test & save was happy, but had no data.
This post worked for me: https://community.influxdata.com/t/influxdb-error-retention-policy-not-found-autogen/26352/6
basically just had to type the following in cli (after already creating the v1 dbrp bucket):
influx v1 dbrp create --db unifi --rp autogen --bucket-id
This then turns 'influx v1 dbrp list' 'Default' field for unifi, to false, and this somehow makes everything work...

I'm still getting these errors in my dashboard


Using unix domain socket

Hello, is there any way to use thruster with unix domain sockets?
If they is no way to do that now, I wonder if is possible to add a method .build_from_incoming which use hyper::Server::builder instead hyper::Server::bind for create the underlying hyper::Server
or maybe just a new type of server thruster::UsdHyperServer which impl the ThrusterServer trait but ignoring the port argument, like this:
use thruster::{
    context::basic_hyper_context::{
        generate_context, BasicHyperContext as Ctx, HyperRequest,
    },
    async_middleware, middleware_fn,
    App, Context, ThrusterServer,
    MiddlewareNext, MiddlewareResult,
};

use hyper::{
    service::{make_service_fn, service_fn},
    Body, Request, Response, Server,
    server::accept,
};

use std::sync::Arc;
use async_trait::async_trait;
use tokio::net::UnixListener;

pub struct UdsHyperServer<T: 'static + Context + Send> {
    app: App<HyperRequest, T>,
}

impl<T: 'static + Context + Send> UdsHyperServer<T> { }

#[async_trait]
impl<T: Context<Response = Response<Body>> + Send> ThrusterServer for UdsHyperServer<T> {
    type Context = T;
    type Response = Response<Body>;
    type Request = HyperRequest;

    fn new(app: App<Self::Request, T>) -> Self {
        UdsHyperServer { app }
    }

    async fn build(mut self, path: &str, _port: u16) {
        self.app._route_parser.optimize();

        let arc_app = Arc::new(self.app);

        async move {
            let service = make_service_fn(|_| {
                let app = arc_app.clone();
                async {
                    Ok::<_, hyper::Error>(service_fn(move |req: Request<Body>| {
                        let matched = app.resolve_from_method_and_path(
                            &req.method().to_string(),
                            &req.uri().to_string(),
                        );

                        let req = HyperRequest::new(req);
                        app.resolve(req, matched)
                    }))
                }
            });

            let mut listener = UnixListener::bind(path).unwrap();
            let incoming = listener.incoming();
            let incoming = accept::from_stream(incoming);

            let server = Server::builder(incoming).serve(service);

            server.await?;

            Ok::<_, hyper::Error>(())
        }
        .await
        .expect("hyper server failed");
    }
}

#[middleware_fn]
async fn plaintext(mut context: Ctx, _next: MiddlewareNext<Ctx>) -> MiddlewareResult<Ctx> {
    let val = "Hello, World!";
    context.body(val);
    Ok(context)
}

fn main() {
    println!("Starting server...");

    let mut app = App::<HyperRequest, Ctx>::create(generate_context);

    app.get("/plaintext", async_middleware!(Ctx, [plaintext]));

    let server = UdsHyperServer::new(app);
    server.start("/tmp/thruster.sock", 4321);

    // test the server with the following command:
    // curl --unix-socket /tmp/thruster.sock http://host/plaintext
}

Yep, I very much like this functionality. I have a few thoughts about this. It looks to me like tokio models the incoming streams as separate structs. I don't have enough knowledge about why they're doing this, probably because of tcp vs unix data streams, but I bet they have good reasons.
With that in mind, I'd like to propose adding build_on_unix_socket to the HyperServer impl for now.
    async fn build_on_unix_socket(self, socket_addr: &str);

This could then be used just like start does with build internally, that is
        let server = HyperServer::new(app);
        tokio::runtime::Runtime::new()
            .unwrap()
            .block_on(server.build_on_unix_socket("/tmp/thruster.sock"))

Thoughts? This seems less invasive than adding it to a trait, and less work than maintaining a third set of ThrusterServer implementations.

I've been doing some thinking and I think the best solution would be to implement a method that allows the application to build on any hyper server configuration.
async fn build_on_hyper_builder(mut self, builder: hyper::server::Builder)

and then we just have to use this new method for writing the build method required by the ThrusterServer trait, like this
    async fn build(mut self, host: &str, port: u16) {
        let addr = (host, port).to_socket_addrs().unwrap().next().unwrap();
        let builder = Server::bind(&addr);
        self.build_on_hyper_builder(builder);
    }

This seems it covers more use cases and is still easy to build on unix socket

Mmm, yes, I like that solution very much. Feel free to open a PR, otherwise
I'll hopefully get to this midweek!
On Sun, Apr 5, 2020 at 1:52 PM encendre<EMAIL_ADDRESS>wrote:

I've been doing some thinking and I think the best solution would be to
implement a method that allows the application to build on any hyper server
configuration.
async fn build_on_hyper_builder(mut self, builder: hyper::server::Builder)
and then we just have to use this new method for writing the build method
required by the ThrusterServer trait, like this
async fn build(mut self, host: &str, port: u16) {
    let addr = (host, port).to_socket_addrs().unwrap().next().unwrap();
    let builder = Server::bind(&addr);
    self.build_on_hyper_builder(builder);
}

This seems it covers more use cases and is still easy to build on unix
socket
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trezm/Thruster/issues/147#issuecomment-609455950, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJWOLKFZ5WIZJZUVKHUBSTRLDANTANCNFSM4L66HAOA
.

I tried to implement it but since I'm pretty new to rust I didn't succeed.
I have successfully compiled the crate adding the new method with and a few tricks that seem unnatural to me...
But the example I wrote doesn't work.

I can try this out today, not to worry! I'll post the PR here when it's done so you can compare with what you were doing and hopefully see where you were going astray :)

So after some noodling, I realized that hyper doesn't actually natively support unix sockets! I had to use hyperlocal in order to get all of the traits on the correct Unix streams.
With that in mind, I thought it easiest to add hyperlocal as an optional dependency and hide the whole thing behind a feature flag. This means that I actually went with the original solution you proposed @encendre, of implementing another server and ignoring the port. Not the most elegant solution, but will definitely work for now!


i hope there is tagcomplete

ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/starlette/responses.py", line 331, in call
stat_result = await anyio.to_thread.run_sync(os.stat, self.path)
File "/usr/local/lib/python3.8/dist-packages/anyio/to_thread.py", line 31, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "/usr/local/lib/python3.8/dist-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
return await future
File "/usr/local/lib/python3.8/dist-packages/anyio/_backends/_asyncio.py", line 867, in run
result = context.run(func, *args)
FileNotFoundError: [Errno 2] No such file or directory: '/content/stable-diffusion-webui/tmp/tagAutocompletePath.txt'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/uvicorn/protocols/http/h11_impl.py", line 407, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/usr/local/lib/python3.8/dist-packages/uvicorn/middleware/proxy_headers.py", line 78, in call
return await self.app(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/fastapi/applications.py", line 270, in call
await super().call(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/starlette/applications.py", line 124, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/starlette/middleware/errors.py", line 184, in call
raise exc
File "/usr/local/lib/python3.8/dist-packages/starlette/middleware/errors.py", line 162, in call
await self.app(scope, receive, _send)
File "/usr/local/lib/python3.8/dist-packages/starlette/middleware/gzip.py", line 24, in call
await responder(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/starlette/middleware/gzip.py", line 44, in call
await self.app(scope, receive, self.send_with_gzip)
File "/usr/local/lib/python3.8/dist-packages/starlette/middleware/exceptions.py", line 79, in call
raise exc
File "/usr/local/lib/python3.8/dist-packages/starlette/middleware/exceptions.py", line 68, in call
await self.app(scope, receive, sender)
File "/usr/local/lib/python3.8/dist-packages/fastapi/middleware/asyncexitstack.py", line 21, in call
raise e
File "/usr/local/lib/python3.8/dist-packages/fastapi/middleware/asyncexitstack.py", line 18, in call
await self.app(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/starlette/routing.py", line 706, in call
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/starlette/routing.py", line 276, in handle
await self.app(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/starlette/routing.py", line 69, in app
await response(scope, receive, send)
File "/usr/local/lib/python3.8/dist-packages/starlette/responses.py", line 334, in call
raise RuntimeError(f"File at path {self.path} does not exist.")
RuntimeError: File at path /content/stable-diffusion-webui/tmp/tagAutocompletePath.txt does not exist.
since your model was able to do that before now it will give this error so i hope it will come back

The newest commits of the autotag complete looks for the models/Lora folder in the webui which does not exist in the "version" of the webui in this repo.
The "stable" commit that is compatible is 7fdad1, which you can do:
!git clone -b 1.16.2 https://github.com/DominikDoom/a1111-sd-webui-tagcomplete

instead.

thank bro

wow cool finding 🥳 we have stable version of the https://github.com/kohya-ss/sd-webui-additional-networks and has LoRA folder we should make all folders same name thanks @NUROISEA ❤


Collect ignores accept and gets called when dragging item of any type

Describe the bug
I have a multiple drag source and a drop area which accepts one of the types.
I expected that collect function of drop area should be called only for accepted types.
This behavior makes me do some redundant if-else clauses and causes re-renders of drop area.
According to the docs: 'This drop target will only react to the items produced by the drag sources of the specified type'
Reproduction
https://codesandbox.io/embed/react-dnd-example-2-9egv7
check logs when dragging Banana box
Steps to reproduce the behavior:

Go to https://codesandbox.io/embed/react-dnd-example-2-9egv7
Start  dragging Banana
Check scroll logs
See that collect of different drop area were called

Expected behavior
Only collect function of drop targets with the same type should be called
Screenshots
Desktop (please complete the following information):

OS: Mojave 10.14.4
Browser: chrome Version 76.0.3809.100 (Official Build) (64-bit)
Version: 9.3.2

Thanks in advance

still the issue


Errors of includes while building the hands_on_audio_acquisition

Terms

[X] Checked the existing issues and discussions to see if my issue had not already been reported;
[X] Read the best practice and checked if my bug was not one of the common bugs documented in the Wiki;
[X] Updated my Python virtual environment with rye sync;

Describe the issue
Hello,
We tried to build the hands_on_audio_acquisition for the H2b part of the project but we get some issues with including the "stm32l4xx_hal.h" and "stm32l4xx.h" with "no such file or directory". We have already installed Software Package stm32l4 for the hands_on_mcu from last week.
Thank you!
Command or program
build the hands_on_audio_acquisition
Issue Type
Error when running an command
What is your platform?
Linux (WSL)
Other platform
No response
Relevant error output
No response
Screenshots
No response
Additional information
No response
Recommended fix or suggestions
No response

Hi @jeertmans,
Sorry for the inaccuracy, my STM IDE is well installed on Windows OS. The project is updated and it works for 2 of our 4 computers. We are all on Windows and we all installed the package stm32l4..

Can you edit the main post and include one or two screenshots showing what you do and the error message in its context?
You can easily copy-and-paste or drag-and-drop images.

I inserted a screenshot of the console @jeertmans !
Thank you :))

Hi @ppasture ,
If the steps given by @TheTarados do not solve your problem, you can try these ones.
Did you clone the git project on your Linux volume through WSL ? If yes, then this can be the cause. Windows has some problems to access Linux file, but not the other way around. That's why you should install as many softwares as possible on your host OS, including git and a git GUI.

Hi @TheTarados @brockauly,
Problem fixed, I had not understood how the .ioc file was working. I generated the code with the .ioc as you told me to do and now it works!
Thank you,
Pierre

Perfect, can you include a screenshot of how you did generate the code with the .ioc? So I can mark this as "solved" and close the issue :-)

After opening the .ioc file (and migrate the project if it has to), I generated the code using the "Project->Generate code" button on the top tab.
Problem solved now!

Thanks!


Codeunit 9064 "Stor. Serv. Auth. Shared Key" function GetHeaderValueOrEmpty throws an exception

I am doing Customer Statement with own report that has communication to Azure Blob Storage and I encounter a problem that I am receiving an error in the end despite everything is fine:

The codeunit function specified in topic is causing the issue (at least in the end). I cannot debug actual behavior because functions are set as non-debuggable.
I do not dare to do ClearLastError() after call Resp := BlobClient.PutBlobBlockBlobStream(FileName, InStr); because I could miss something definitely crucial.
The same behavior is for BlobClient.GetBlobAsStream()
To illustrate the issue I created small demo app
pageextension 50100 CustomerListExt extends "Customer List"
{
    actions
    {
        addfirst(processing)
        {
            action(TestUpload)
            {
                Caption = 'Test Upload';
                ApplicationArea = All;
                trigger OnAction()
                var
                    InS: InStream;
                    FileName: Text;
                begin
                    if UploadIntoStream('', '', 'All files (*.*)|*.*', FileName, InS) then
                        SendFileToAzure(InS, FileName);
                end;
            }
        }
    }

    local procedure SendFileToAzure(var InStr: InStream; FileName: Text)
    var
        BlobClient: Codeunit "ABS Blob Client";
        Resp: Codeunit "ABS Operation Response";
        StorageAuth: Codeunit "Storage Service Authorization";
        Auth: Interface "Storage Service Authorization";
        AccountKey: Text;
        AccountName: Text;
        RequestUrl: Text;
        ContainerName: Text;
    begin
        GetBlobStorageParams(RequestUrl, AccountName, AccountKey, ContainerName);
        Auth := StorageAuth.CreateSharedKey(AccountKey);
        BlobClient.Initialize(AccountName, ContainerName, Auth);
        Resp := BlobClient.PutBlobBlockBlobStream(FileName, InStr); //here exception is thrown
        if not Resp.IsSuccessful() then
            Error(Resp.GetError())
        else
            Message('File is uploaded successfully.\Here is intermediate error:\%1\\Here is error stack:\%2', GetLastErrorText(), GetLastErrorCallStack());
    end;

    local procedure GetBlobStorageParams(var resourceurl: Text; var keyname: Text; var keyvalue: Text; var ContainerName: Text)
    var
        UrlLbl: Label '%1://%2.blob.%3/', Comment = '%1 - data after DefaultEndpointsProtocol=; %2 - Account Name; %3 - data after EndpointSuffix=';
        data: List of [Text];
        element: Text;
        endpoint, protocol : Text;
        AzureBlobConnectionString: Text;
    begin
        //actual ConnectionString is taken from setup
        AzureBlobConnectionString := 'DefaultEndpointsProtocol=https;AccountName=<YOURACCOUNTNAME>;AccountKey=<YOURACCOUNTKEY>;EndpointSuffix=core.windows.net';
        //actual ContainerName is taken from setup
        ContainerName := '<YOURCONTAINERNAME>';

        //parsing Connection String
        data := AzureBlobConnectionString.Split(';');
        resourceurl := '';
        keyname := '';
        keyvalue := '';
        foreach element in data do
            case true of
                element.Contains('DefaultEndpointsProtocol='):
                    protocol := element.Substring(StrLen('DefaultEndpointsProtocol=') + 1);
                element.Contains('EndpointSuffix='):
                    endpoint := element.Substring(StrLen('EndpointSuffix=') + 1);
                element.Contains('AccountName='):
                    keyname := element.Substring(StrLen('AccountName=') + 1);
                element.Contains('AccountKey='):
                    keyvalue := element.Substring(StrLen('AccountKey=') + 1);
            end;
        resourceurl := StrSubstNo(UrlLbl, protocol, keyname, endpoint);
    end;
/*
File is uploaded successfully.
Here is intermediate error:
Exception of type 'Microsoft.Dynamics.Nav.Types.Exceptions.NavNclInvalidHeaderException' was thrown.

Here is error stack:
"Stor. Serv. Auth. Shared Key"(CodeUnit 9064).GetHeaderValueOrEmpty line 4 - System Application by Microsoft
"Stor. Serv. Auth. Shared Key"(CodeUnit 9064).CreateSharedKeyStringToSign line 19 - System Application by Microsoft
"Stor. Serv. Auth. Shared Key"(CodeUnit 9064).GetSharedKeySignature - System Application by Microsoft
"Stor. Serv. Auth. Shared Key"(CodeUnit 9064).Authorize line 7 - System Application by Microsoft
"ABS Web Request Helper"(CodeUnit 9045).PrepareRequestMsg - System Application by Microsoft
"ABS Web Request Helper"(CodeUnit 9045).PrepareRequestMsg - System Application by Microsoft
"ABS Web Request Helper"(CodeUnit 9045).PutOperation - System Application by Microsoft
"ABS Client Impl."(CodeUnit 9051).PutBlobBlockBlob line 23 - System Application by Microsoft
"ABS Client Impl."(CodeUnit 9051).PutBlobBlockBlobStream line 10 - System Application by Microsoft
"ABS Blob Client"(CodeUnit 9053).PutBlobBlockBlobStream line 4 - System Application by Microsoft
CustomerListExt(PageExtension 50100).SendFileToAzure line 14 - ALProject1 by Default publisher
CustomerListExt(PageExtension 50100)."TestUpload - OnAction"(Trigger) line 6 - ALProject1 by Default publisher
*/
}

proof of work
Using access keys for the Azure Blob Container

running coded action

selecting file for upload

file uploaded successfully and message shown

proof that file is in the container

@PaulFurlet thanks for you detailled example.
I guess, that I maybe found the source of the error by your callstack.
It's probably related to the following code path:
https://github.com/microsoft/ALAppExtensions/blob/41405db353de27492e4785694dfb8cb11bf57f8d/Modules/System/Azure Storage Services Authorization/src/SharedKey/StorServAuthSharedKey.Codeunit.al#L88
    local procedure GetHeaderValueOrEmpty(Headers: HttpHeaders; HeaderKey: Text): Text
    var
        ReturnValue: array[1] of Text;
    begin
        if not Headers.GetValues(HeaderKey, ReturnValue) then
            exit('');

        if HeaderKey = 'Content-Length' then
            if ReturnValue[1] = '0' then
                exit('');

        exit(ReturnValue[1]);
    end;

Instead of using the return value of GetValues, it might be better to check for the existence of an header with the .Contains Method.
https://learn.microsoft.com/de-de/dynamics365/business-central/dev-itpro/developer/methods-auto/httpheaders/httpheaders-contains-method
Feel free to created a Pull Request for the system application to refactor this codeunit to call Contains before the call of GetValues and exit the procedure as early as possible.

@darjoo you have taken part at similiar issues for the storage service authorization, maybe you can have a look at this issue, too.

@pri-kise thanks for pointing, created PR #22139

@pri-kise is this normal behavior or did I do something wrong? https://github.com/microsoft/ALAppExtensions/actions/runs/4169770631/jobs/7218103696

Thanks for the ping @pri-kise.
You're right that we should add .contains. before .get as it will always throw an exception if the key does not exist which can be caught and ignored but will show up in GetLastError. Whereas .contains will simply return true/false.
I'll review your PR today @PaulFurlet

@pri-kise is this normal behavior or did I do something wrong? https://github.com/microsoft/ALAppExtensions/actions/runs/4169770631/jobs/7218103696

It does not seem related to your changes, I'll ping the team who owns the pipeline infrastructure to take a look.

This appears to be resolved. Also, the System Application is now debuggable. If this issue persists, please create a new issue.


AOS IE (Internet Explorer) 10 not displaying HTML on Scroll - Opacity still 0

I have a problem with IE10 (or IE 10 render mode) where the elements are created but hidden with opacity 0, some how its not changing them on scroll

It happens with all elements on IE10? Or a specific one?

No confirmation since September and no other issues like this. I presume it's working fine, there was some work regarding IE's in the meanwhile.

I have the same issue, class aos-animate not added in ie10

me too :(

Having the same issue on E10.

Me too... Has anyone found a solution to this?

Same problem with macOS and Safari (latest versions)
AOS version 2.3.4
The warning appears in responsive mode
TypeError: e.indexOf is not a function. (In 'e.indexOf(" ")', 'e.indexOf' is undefined)

I have the same issue. The first element animates in. None of the other elements will animate.

Same issue.

Same

same problem.whai i do plz suggest me!


Sessions file is not read (?)

Hi @noook - thanks for putting this together, very cool.
When I relaunch the application, I am asked for the password again. The sessions file (session.json) has been written/updated, but it doesn't seem to make any difference.
(I'm on Ubuntu - in case that makes a difference.)

Hello, I indeed noticed this, it seems to be related to the scope the script is able to read/write when installed globally, if you have any lead feel free to suggest / report here the problem !

Hi @noook - On Linux, when the script is installed with sudo into a systems directory, then the session.json isn't writable (if igdm is not run with sudo).
However, I've installed the application via git, to be able to tinker. It still doesn't pick up the session.json, although it's writable. I'll see whether I can figure out the problem in more detail.


Jiggling layout

It seems like the typing animation of the banner's header affects the whole layout of the website when the animation starts running and it makes the whole layout expand or shirk constantly.

Same problem here, but there are two solutions that you can use:

Create fixed size container with typing text in it
Make smaller size of font and paste in  tag, so typing will be happening on different line


Enable cross-compiling for x86 + NVIDIA Grace (ARM64)

This fix build up on our previous fixes. It will bring back arm compiling, but this time we take a more wholesome approach.
Also, this change removes some redundancies that were in the build process.
Depends on
https://github.com/NVIDIA-Merlin/Merlin/pull/1043

@jperez999 @EmmaQiaoCh I rebased to current main. From my perspective this is mergeable.

@jperez999 @EmmaQiaoCh @minseokl I wish this could be merged ;-)

I am going to push this through as the failure does not have anything to do with the docker files edited in this PR. We will see if this runs successfully in our Pipeline and revert if we have any issues.


Extension issue

Issue Type: Bug
Extension Name: python
Extension Version: 2020.3.71659
OS Version: Windows_NT x64 10.0.18362
VSCode version: 1.43.2

:warning: We have written the needed data into your clipboard. Please paste! :warning:

@Ebaharloo this bug is filed with no description or details about the issue. Please file again with details.


build: Drop clamav-scan resource requests

Description
Let the Konflux team manage these resources as they seem to be on track of doing that
https://github.com/konflux-ci/build-definitions/pull/1247
Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.

/retest collector-build


NumberControl is doubly disabling its Slider

In Gas Properties "Energy" screen, we have a NumberControl that can be disabled.
Here's what it looks like enabled:

and disabled:

Note that when it's disabled, the slider is much dimmer (lower opacity value) than the rest of the component.  I suspect that this is because both the NumberControl and its Slider are reacting to the NumberControl's enabledProperty, and the Slider ends up having its opacity reduced twice; once by itself, once by its parent NumberControl.   The Slider should not be involved at all here.
Self assigning to investigate.

Transferring this issue from scenery to scenery-phet.


add archive format to all posts

Hello Victoria
I added an option in the config to show all posts archived by year. I think this could be a good addition to the theme. My site has the changes.
Have a good holiday!
Angelo

Thank you for the PR Angelo!


Support Scala 2.12

This could cause problems in supporting Scala 2.10.

+1 for this. I just tried to add Scala 2.12 cross-building to akka-stream-kakfa but I found that this library was a blocker.

I wonder how does the community feel about removing support for Scala 2.10.

Kafka is not yet published for 2.12.0 and this library depends on that. There's a PR pending - https://github.com/apache/kafka/pull/2113. I'll try to understand what are their plans.

They merged that PR - I'm just waiting for the 2.12 artifacts to be published.

For what it's worth Akka related tools are all on 2.11+ (and eagerly awaiting 2.12 for this) so we can merge @cb372's PR :-)

Hey @ktoso, thanks for popping by :) It seems that the Kafka people have merged the PR for 2.12 support but I can't see the artifacts anywhere as I write. I asked on the ticket referenced earlier on when it's expected to see published artifacts, so I can update my build.

It seems that based on https://cwiki.apache.org/confluence/display/KAFKA/Time+Based+Release+Plan next release will happen in Jan 2017. Not sure if they plan to release current version binaries for 2.12.

https://github.com/apache/kafka/pull/2113#issuecomment-260159755 - it seems promising.

https://github.com/apache/kafka/pull/2164 it's still open. Once this get merged we should be able to get latest patch version compiled for 2.12 and hopefully unblock this.

apache/kafka#2164 is fixed now.

Yes, but artifacts are not published yet. I think there will be a new release soon.

There are rc0 builds now available, but no artifacts just yet.  Build them locally with ./gradlew install_2_12 from the <IP_ADDRESS>-rc0 tag.

Thanks. To build this in CI I need to wait until the arifacts are published, although I will be able to test locally. I saw in the ML that this is a pre-alpha version, it's worth to be noting this when scalatest-embedded-Kafka will be released.

kafka RC1 artifacts are now published to https://repository.apache.org/content/groups/staging/org/apache/kafka/.
They are designated pre-alpha as they have not received extensive testing from the Kafka team, the only difference between the 2.11 and 2.12 versions are the compiler/JVM with the 2.12 being built with 2.12.1 and Java8.

Do you know if they're planning to publish <IP_ADDRESS> on Maven Central? I can't seem to find them there.

Fixed in version 0.11.0!

@manub those builds won't work in general until the kafka artifacts are in maven central.  The current ones are still RC1, it looks like they'll get promoted very soon though.

@leachbj are the binaries going to be different? The artefacts aren't tagged rc1...

I think the final artefacts are the same as the rc1.  Looks like the Apache process doesn't version as rc1 and just limits publishing them to the staging repository.  The final binaries are now in maven central; https://mvnrepository.com/artifact/org.apache.kafka/kafka_2.12/<IP_ADDRESS>


Image size in mobile view is not in same ratio

Please fill out the template below

Did you read the instructions in README ?
Yes
Solves which issue ?
Fixes #338
Give discription.
Image size is now fixed
Checklist
(To mark the checkboxes use x within the box brackets)

[x] Signed the code of conduct.

[x] Have you added yourself to the participants.

[x] Joined opencode zulip server.

Here is the live link :- https://rattlecode17sh.github.io/Opencode-Collaborative-19/

Here are the project cards after changes

@ananya-agrawal please review

@Rattlecode17sh any updates on this?

Just give me one day...half way completed


Is tezos-public-node-with-probes in prod?

Is this commit supposed to substitute "tezos/tezos-public"? Or is it just a dev test?

tezos-public-node-with-probes is in production. It restarts the node when all of its public connections have disappeared, something I have seen happening.


Sometimes a user never receive notifications

Upon investigating the code, it appears that the (FCM) token is not consistently stored in the database. This issue may be related to the asynchronous nature of the token retrieval process, specifically this line of code:
const fcm_token = await requestForToken();
Because this operation is asynchronous, there is a possibility that the sign-up process proceeds without the FCM token being successfully obtained and stored.

Upon further testing, we've noticed that the issue with the FCM token not being stored during the signup process has not been completely resolved. This seems to occur intermittently. I am reopening this issue for additional investigation and resolution.

After investigation the FCM token is not stored when the when the user is asked for notification permissions (first time) during the first signup attempt. However, if the user has already granted permission before signing up, the token is stored successfully.
To resolve this, ensure that the FCM token registration and storage process is retried after the user grants permission, regardless of when it's granted.