Cherry-pick: Update go to 1.21.4 (#648)

Cherry pick of https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/648
What this PR does / why we need it:
Update go to v1.21.4

/lgtm

/hold


Run Tool in a Post Build Command

I am looking to run this tool in a post-build command to automate the generation of the interfaces.
I have had some trouble getting this to work however, as the command builds the app I seem to get stuck in an infinite loop where the app keeps building and calling the command to generate the interfaces.
I was wondering if there was a way to only run the command once by having the command ignore the post-build command or adding a condition to the post build command that would prevent the command from being run multiple times.
Here is the command that I have now.  Any help would be greatly appreciated.
 <Target Name="PostBuild" AfterTargets="PostBuildEvent">     <Exec Command="if $(ConfigurationName) == Debug(
dotnet-generate-client '$(ProjectDir)' -o '$(SolutionDir)My.App.API\ClientInterfaces' -n 'My.App.API'

)" />   </Target>

Similar issue: https://github.com/Dreamescaper/GenerateAspNetCoreClient/issues/26
You can pass built dll to the tool, that would probably work better.

Awesome! That worked.  Thank you for the quick response!


Please write the code for--

New post HTML Link( Hyperlink) with title automatic add in previous post in middle of content In wordpress website
like Also read- epicnewsnation.com
thank you

New post HTML Link( Hyperlink) with title automatic add in previous post in middle of content In wordpress website like Also read- epicnewsnation.com
thank you


Error when using Ubuntu 15.04 with upstart

Ubuntu 15.04 with systemd is supported per https://github.com/chef-cookbooks/openssh/pull/62 but I had to switch back to upstart for a different cookbook and now I'm running into an issue with the openssh cookbook:
[htpc] out: ---- Begin output of /bin/systemctl start ssh ----
[htpc] out: STDOUT:
[htpc] out: STDERR: Failed to get D-Bus connection: Operation not permitted
[htpc] out: ---- End output of /bin/systemctl start ssh ----
[htpc] out: Ran /bin/systemctl start ssh returned 1
[htpc] out: [2015-10-16T06:26:27+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

Any way to support both systemd & upstart for Ubuntu 15.04 in this cookbook?

In general, how come cookbooks have to be concerned about specifying service provider anyways?

Getting the correct service provider is tricky business since some distros (like ubuntu) are in a mixed state with both upstart/init or systemd/init.  I'll see if I can get a fix for Ubuntu 15.04 in the near future here.  It just requires a special case for newer Ubuntu releases.

@tas50 but how come every single cookbook has to handle that? Shouldn't that detection be built into the service resource itself?

@fletchowns What version of chef-client were you running when you had this issue?  Chef 12 should just do the right thing.

@fletchowns I've tested on 15.04 using the latest release of the cookbook with Chef 12.6 and this doesn't seem to be an issue.  There have been changes to both the cookbook and to chef-client to better handle multiple init systems.  I'm going to close this out at this point.

Thanks @tas50 ! This was on Chef 11. I'm upgrading to Chef 12 this week, I'll give it another shot after that.


[BUG] The home page is totally disturbed

Description
I've observed some serious UI problems that are very obvious.
See the home page screenshot. @GarimaSingh0109

Expected Behavior
I will be fixing all this disorder of elements.
fixing the navbar and the sections that follows.
Looking forward to this issue to assign it to me. I am very excited to contribute in it.
Waiting for the reply.
Actual Behavior
I don't know why but the overall design is disturbed.
Structure is fine but the CSS has to be edited.The structure
Additional Information
Also the content in the page are very simply written. I'll make them a bit arranged in center align and readable to the user.
Browser
Chrome
Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct
[X] The changes don't break the code
[X] Please attach screenshots and videos of the development work once done

add other labels too. hacktoberfest, hacktoberfest-accepted, gssoc-ext, level2.


easier alternative way of getting infinity through whatever buggy js exists in this world

(+!+[]+[])/+[]

if you divide any string number other than 0, by 0 you get Infinity
example:
"1"/0 === Infinity // yes

oh nvm closing because it uses a slash


electrum: 4.0.3 -> 4.0.4

Motivation for this change
Version update: https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I was able to broadcast transactions. I even got the "opportunity" to cancel a stuck transaction. This looks good to me.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/365


add new case get appinfo in guest

Review two scrips logic, i think they are passed.
Will update their format in my PR.


Is it an add-on over inline requires + ram bundles ?

Hi @kirillzyusko,
Thank you for the library.
My project has RN 0.63.4
I have already added inline requires everywhere in my project for the heavy component screens as per RN docs (https://reactnative.dev/docs/ram-bundles-inline-requires).
I have also enabled RAM bundling for android.
Upon investigating the loaded modules, I observed the total number of loaded modules fell from around 3.3k to 350.
But still I don't see significant reduction in app start time.
I wanted to know if this library is an add-on over inline requires and ram bundles and can it help me reduce more start time of the app ?

Hi @tarun-khanna
This library is a simple wrapper around RAM bundles functionality with unified API and some useful functions (such as preloading, caching etc.)
That's strange, that startup time wasn't decreased. Because 350 modules ~ hello world RN app. So startup time should be really fast!
From my experience, I can say, that decreasing ~1000 modules led to 1s improvement. These values are rough, but can give an approximate result. I don't know, why it didn't give you any benefits😔

Hey @kirillzyusko
Thank you for your quick response :)
Can you tell me if replacing inline requires with your library's register api will help in any case or it won't bring much difference ?

@tarun-khanna I don't think you will get any benefits. You can try, but if you are sure, that you properly implemented inline requires in your app, then it doesn't make sense.
The main purpose of this library was to provide preloading API to deliver best UX to end user. Because if you will load additional 0.5Mb of bundle during the app runtime, it may slightly freeze the app. With preloading API you can do it in invisible mode (in parallel with data fetching from internet, for example). That was the main purpose.

Alright, thanks a lot @kirillzyusko for your inputs! 😄


Create a temporary contract deployer

Some SC are not for the posterity (hello world, sum ...).
We should create an optional deployer that can perform autoclean function using autonomous SC trigger.

@gregLibert need more context here... can it be done with the ExecuteSC?

@gregLibert need more context here... can it be done with the ExecuteSC?

The idea is to have a kind of self-destructing smart contract deployer.
Usage scenario: I want to test the Massa blockchain and deploy a very simple smart contract. To reduce storage costs, it's best if my smart contract self-destructs to recover storage costs and only pay for gas costs.


Fix docker volumes

This also fixes the problem of adding a new row at the top of the form if no row was present.

Reviewer: @philipnrmn

not 100% how this works, but if i fill all the fields out, switch to JSON then switch back container volumes is empty

Guys, I'm going to merge this in so that we can provide a build. But @Poltergeist could you please take a look at the comments Kenny left?

sounds good

integration tests pass.

The docker volume gets cleared if no docker image is present. Ideal would be to only show those fields if a docker volume is set.


Roll engine 88113925e3a0..7ce2666e54cb (3 commits)

https://github.com/flutter/engine/compare/88113925e3a0...7ce2666e54cb
git log 88113925e3a063bd6a249346aaa784e65772a25b..7ce2666e54cb137f35b62950b32b8db80d5027e6 --no-merges --oneline
7ce2666e5 Guard Android logs (flutter/engine#8824)
8584da2c2 Roll src/third_party/skia dc19391eef52..70aab823547a (8 commits) (flutter/engine#8836)
1cdc16322 Roll src/third_party/dart 1577b95c93..dbe80f3397 (43 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6073401853083648

Commit queue failed; closing this roll.


cors issues with frontend

when trying to access to the DBS endpoint, I get the following error:
Access to XMLHttpRequest at 'http://localhost:8000/' from origin 'http://localhost:6006' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
this needs to be handle server-side to allow all origins to access the DBS server.
It can be overcome by using a CORS unblocker like CORS Unblock extension

Thanks for testing and reporting this. If it needs to be handled server side, it would need to be done in the https://github.com/oceanprotocol/decentralized_storage_backend repo

opened in DBS repo, closing issue here.


Update golang deps

starting to work on improving it ...
-> https://github.com/StackExchange/blackbox/issues/344#issuecomment-994797503


High CPU consumption

Describe the bug
I'm running KCP on my local machine (MacBook Pro 2019, 2,6 GHz 6-Core i7, 32 GB memory), and the KCP process steadily consumes > 1000% CPU.
Some client requests time out, with the KCP logs containing:
{"level":"warn","ts":"2022-02-02T14:26:11.184+0100","caller":"etcdserver/util.go:166","msg":"apply request took too long","took":"1.201838934s","expected-duration":"100ms","prefix":"read-only range ","request":"key:\"/registry/networking.k8s.io/ingresses/\" range_end:\"/registry/networking.k8s.io/ingresses0\" count_only:true ","response":"range_response_count:0 size:5"}

To Reproduce
$ start --push-mode --install-cluster-controller --resources-to-sync=deployments --resources-to-sync=services --resources-to-sync=ingresses.networking.k8s.io --auto-publish-apis

And to KinD clusters configured:
$ kubectl get clusters
NAME
kcp-cluster-a
kcp-cluster-b

Expected behavior
I've mitigated the issue by having only one physical cluster. Still the CPU consumption is > 1000% CPU, but at least the client requests do not time out.
The KCP process should not consume that much CPU, and scale well with the number of physical clusters.
Additional context
This happens with the kcp-ingress project setup: https://github.com/jmprusi/kcp-ingress#getting-started.

This was something @ncdc  and @sttts were looking into and seems to be MacOS specific?

A quick profiling the KCP process gives the following information:

github.com/kcp-dev/kcp/pkg/syncer.(*Controller).processNextWorkItem
/Users/antonin/Development/kcp-ingress/tmp/kcp/pkg/syncer/syncer.go

  Total:      48.90s    224.18s (flat, cum) 81.45%
    286            .          .           }
    287            .          .
    288            .          .           // Done returns a channel that's closed when the syncer is stopped.
    289            .          .           func (c *Controller) Done() <-chan struct{} { return c.ctx.Done() }
    290            .          .
    291        9.54s      9.59s           func (c *Controller) processNextWorkItem(ctx context.Context) bool {
    292            .          .           	// Wait until there is a new item in the working queue
    293       29.75s    204.97s           	i, quit := c.queue.Get()
    294            .          .           	if quit {
    295        3.39s      3.39s           		return false
    296            .          .           	}
    297            .          .           	h := i.(holder)
    298            .          .
    299            .          .           	           // Get blocks until it can return an item to be processed. If shutdown = true,
    145            .          .           // the caller should end their goroutine. You must call Done with item when you
    146            .          .           // have finished processing it.
    147       11.32s     11.34s           func (q *Type) Get() (item interface{}, shutdown bool) {
    148       17.15s     81.41s           	q.cond.L.Lock()
    149        7.55s      7.56s           	defer q.cond.L.Unlock()
    150        3.53s      3.54s           	for len(q.queue) == 0 && !q.shuttingDown {
    151            .          .           		q.cond.Wait()
    152            .          .           	}
    153            .          .           	if len(q.queue) == 0 {
    154            .          .           		// We must be shutting down.
    155       14.33s     71.28s           		return nil, true
    156            .          .           	}
    157            .          .
    158            .          .           	item, q.queue = q.queue[0], q.queue[1:]
    159            .          .
    160            .          .           	q.metrics.get(item)

I'll try to dig into it.

After a new round of analysis, it seems the root cause lies in the syncer stop operation that shuts down the workqueue, but does not properly stop the informers and workers, that continue to add / get items, so processNextWorkItem turns into an infinity loop over the following execution path:
kcp-dev/kcp/pkg/syncer.(*Controller).processNextWorkItem
    293       29.75s    204.97s           	i, quit := c.queue.Get()

k8s.io/client-go/util/workqueue.(*Type).Get
    153            .          .           	if len(q.queue) == 0 {
    154            .          .           		// We must be shutting down.
    155       14.33s     71.28s           		return nil, true
    156            .          .           	}


Question about n_feat value

I have a question about the n_feat value used in 'ffs_final.py'. The README does not clearly define how to set the n_feat value.
https://github.com/Sowmya-R-Krishnan/RSAPred/blob/03fbc3fb9600986f2680ab1bffe01630a4a5d35d/Feature_selection/ffs_final.py#L24
When setting n_feat to 2, the ffs_final.py code runs, but the process_regression_output_v1.py code gives p1 and p2 values of 0, and the get_desc_stats_v1.py file does not run because there is no column in the process_regression_output_v1.py code output file.
When setting n_feat to 3, the ffs_final.py code does not finish running.
Could you please provide guidelines on how to appropriately set the n_feat hyperparameter? Specifically, what is the recommended value for n_feat in RSAPred dataset?
Thank you for your assistance.

Hi. Thanks for the message. The n_feat value indicates the number of features to be considered for the combination. So by setting n_feat = 2, you are computing all possible 2 feature combinations and n_feat = 3, you are computing all possible 3 feature combinations.
By using n_feat = 2 and pass_feat = "all", the program will compute all possible 2 feature combinations, which will not take a lot of time. But with n_feat = 3 and pass_feat = "all", it will take a while to finish, even though we have parallelized the code with multi-processing. I suggest you change the Pool(4) parameter in line 86 to the desirable number of processes you can use - more the number of processes, faster the code will execute.
Also, for n_feat > 3, you can try supplying the first output of get_desc_stats_v1.py instead of "all" for the pass_feat parameter. That will reduce the number of features to consider for computing the "n" feature combinations, thereby decreasing the runtime significantly. Hope this clarifies - let me know if you have any further queries.
With regards,
Sowmya

Thank you for answering my question.
I run the code using the "./data/Aptamers_dataset_v1.csv" dataset.
The Data_processing codes and ffs_final.py code executed successfully with n_feat=2.
However when I run the process_regression_output_v1.py file, I get '0 0' output and encountered an error in get_desc_stats_v1.py file.
Could you please provide the n_feat hyperparameter value for each rna type that you used in the research paper?
I share the output files with aptamer data.
output_aptamer.zip

Hi. We used forward feature selection - so for every RNA subtype the code was executed from n_feat = 2 till the final number of features reported in the paper (Refer Table 2 column 2 for n_feat values and Table 3 for the complete list of features for each type).
When running process_regression_output_v1.py, you should change the correlation cut-off used for filtering the best models. From the outputs you have provided, the maximum correlation is 0.45 and the cut-off in the code is 0.60. So none of the models have passed the filter and the subsequent code (get_desc_stats_v1.py) throws an error. Please change the cut-off and try again. I will also update this in the README file for clarity.

Thank you for your kind answers.
I apologize for the continued questions. I have another question about handling multicollinearity.
Where can I find the code for addressing multicollinearity?
In my understanding, the ffs_final.py code does not calculate correlations between features. Instead, it evaluates the regression model's performance using different feature combinations and the target variable (pKd value). It seems to focus on feature selection based on predictive performance rather than explicitly removing multicollinearity by analyzing feature correlations.
https://github.com/Sowmya-R-Krishnan/RSAPred/blob/e2d34e4837604db9b0e87d3eb16116049025337b/Feature_selection/ffs_final.py#L87
I would greatly appreciate your clarification on this.

While running ffs_final.py, we have provided an input file named - Pairwise_featcorr_0.8.pkl. This file contains all pairwise feature correlations which pass our pairwise correlation threshold (r<0.8).
In the ffs_final.py code, lines 74-79 are designed to handle multi-collinearity. For every possible feature combination with n_feat features, first we check if all the feature pairs within the combination have r<0.8. Only if all feature pairs pass this criteria (no multi-collinearity), they are used to build a regression model. Hope this clarifies.
if(n>2):
	feat_combinations_pass = []
	for combination in feat_combinations:
		feat_pairs = set(list(combinations(combination, 2)))  #Creates all possible pairs of n_feat features in a combination
		feat_pass = [True for pair in feat_pairs if(pair in pair_corrs)]  #Checks if each pair passes the r<0.8 cut-off
		if(len(feat_pass)==len(feat_pairs)):  #Only if all pairs pass (no multi-collinearity), the combination is used for model
			feat_combinations_pass.append(combination)

Thank you so much for your detailed explanation and clarification. I now understand how the code handles multicollinearity by using the Pairwise_featcorr_0.8.pkl file to filter feature combinations based on pairwise correlations. Your response and the reference to the publication have been very helpful. I appreciate your time and support.
Best regards,
Haelee Bae


Add script to modify Thrift include guard variables

This adds a script which will modify the include guard variables for the Thrift includes included by DuckDB. This is necessary because the new parquet reader also includes Thrift headers and without renaming there are collisions.

@jwyles-ahana Can you please squash the two commits into one and update the commit message?  Right now you have the PR message but I couldn't see the commit message.

@yingsu00 I have squashed the two commits into one and updated the commit message.

This PR is the first PR to resolve https://github.com/facebookincubator/velox/issues/1734

@majetideepak The S3 tests kept failing, will you be able to help take a look? I saw the following error messages
126: E0603 21:40:03.008405  7145 Exceptions.h:68] Line: ../../velox/connectors/hive/storage_adapters/s3fs/S3FileSystem.cpp:82, Function:initialize, Expression: Failed to get metadata for S3 object due to: 'Network connection'. Path:'s3://dummy/foo.txt', SDK Error Type:99, HTTP Status Code:-1, S3 Service:'Unknown', Message:'curlCode: 7, Couldn't connect to server', Source: RUNTIME, ErrorCode: INVALID_STATE
126: [       OK ] S3FileSystemTest.noBackendServer (27561 ms)
126: [----------] 9 tests from S3FileSystemTest (47754 ms total)
126:
126: [----------] Global test environment tear-down
126: [==========] 12 tests from 2 test suites ran. (47757 ms total)
126: [  PASSED  ] 9 tests.
126: [  FAILED  ] 3 tests, listed below:
126: [  FAILED  ] S3FileSystemTest.writeAndRead
126: [  FAILED  ] S3FileSystemTest.viaRegistry
126: [  FAILED  ] S3FileSystemTest.fileHandle
126:
126:  3 FAILED TESTS

@jwyles-ahana you don't have to create a separate commit just to retry CircleCI. Would you please just do something in your original commit and try a few more times?

The S3 test failures are fixed on the main branch. Please rebase with main.

@jwyles-ahana Will you please squash the commits and make the commit title shorter? Thank you!

@jwyles-ahana Could you resolve the conflict please?


Easy copy-paste dashboard for commenting

Hi, I like the concept, but in it's current state, there's quite some effort one needs to do in order to comment in a nice way instead of just leaving a link. Perhaps each item in the list on the landing page can have a copy button next to it that copies to the clipboard, a formatted comment for an easy paste.
Sample comment (output) -

I downvoted because no attempt was made

Sample comment (actual content copied to clipboard) -

[I downvoted because no attempt was made](http://idownvotedbecau.se/noattempt/)

Sorry, this slipped by me... I appreciate the idea, but I'm not sure if implementing it (or something similar) would be worthwhile. First, there's many ways to phrase the links, but no one right way. For example, I wouldn't want the link to be phrased as in your example (in fact, I'd prefer the blank url).  I'd prefer to let the end user format as they desire. Anyone can use AutoReview comments to format the links as they desire, adding as little or as much info as they want.
I'll leave this open and let it collect other opinions.  Thanks for the suggestion.

I think this is a good idea, given a reasonably-polite template can be composed. Maybe something like:

I downvoted because ...; click here to find out how to fix it and then @mention me so I can change my vote.


Add action to add type annotations to let function bindings

Summary
The FSharp Compiler Service knows all of the type information about a particular function, this PR adds support to Rider to add that information to source code in the form of type annotations:
let printerFun a b = sprintf "%s %d" a b

transformed to:
let printerFun (a : string) (b : int64) : string = sprintf "%s %d" a b

TODO:

[ ] Add test case covering out args
[ ] Add test case covering functions being passed as other function parameters or returned from functions

Nice - this looks like a really useful addition!
With regards to tuples, does it correctly parenthesise ’a * (‘b list) and (‘a * (‘b * ‘c)) for example? I can’t recall the exact function, but I believe FCS will pretty print a type for you and parenthesise correctly.

Nice - this looks like a really useful addition!
With regards to tuples, does it correctly parenthesise 'a * ('b list) and ('a * ('b * 'c)) for example? I can’t recall the exact function, but I believe FCS will pretty print a type for you and parenthesise correctly.

Hi @saul,
I'm aware of GetToolTipText for pretty printing types, but that would require typechecking the whole file, and also relying on something intended for tooltips to generate code... This was actually my initial approach, but it seemed too hacky (though I'm aware relying on hand-rolled type printing code isn't optimal either) - if you know of a FSharpType -> string function on FCS, that would be ideal.
https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/service/FSharpCheckerResults.fsi#L169

Yes - see here: https://github.com/saul/fsharp-support/pull/1/files#diff-aa5ffd16642349932d67a02a4f0a0f3fR43-R44

I'm aware of GetToolTipText for pretty printing types, but that would require typechecking the whole file
The file is going to be type-checked in any way, and GetFSharpSymbol uses results of it too under the hood.

@saul I've taken a look at your symbolUse.DisplayContext.WithShortTypeNames(true) |> fSharpFunction.FullType.Format-like thing, not sure if it fits this pattern though, as each function parameter has multiple FSharpType elements, and the thing that's rendered is an FSharpType itself, which puts in the same position of having to piece the type string together ourselves...
If you guys would prefer, I could swap out the current implementation to get the type from the tooltip, which should do the trick?

This is weird... I would definitely expect this to be annotated as:

@saul Yes, thanks for noting, I also think this way. I thought it'd be good to cover it in a separate commit/PR, along with having separate actions for annotating a single parameter or return type.


Make possible to select rectangle/area on a screen on map of the world and add this area as a custom city.

https://a-b-street.github.io/docs/howto/new_city.html is a bit tricky and I have seen some people from OSM interested by it, but scared away by command line stuff.
I think that JOSM-like download interface (that would also reject too large areas) would be great.

I've heard some requests for something like this. I think it's pretty feasible to add an in-game UI for it.

First open the browser to geojson.io and tell them to draw there
Somehow copy back the results (the tricky step)
Use https://github.com/a-b-street/abstreet/blob/master/importer/src/bin/pick_geofabrik.rs to find the osm.pbf best matching the boundary
Run osmconvert to clip
Run the one-shot importer automatically

Step 2 is a bit awkward because we'd need to support copy/paste (across 4 platforms) -- there are crates for it and I think we used to use one of them, so maybe not bad. The single-line text entry box in abst today sucks and I really don't want to make a multi-line one, but we could maybe just have a button saying "grab from system clipboard" and display the result and not allow editing in the UI.
Step 3 is more what we would do for a real permanent import; it might be overkill or too large a download for a quick demo. I'm not aware of any OSM download service that'll extract the city-sized areas people will likely draw. https://protomaps.com/bundles is the closest, but we need a .osm ultimately; I don't think the bundle has enough.
Step 4 means bundling the osmconvert binary for the correct platform. Or... if that's a hassle, I don't actually think it's so hard to implement the equivalent of osmconvert large_map.osm -B=clipping.poly --complete-ways -o=smaller_map.osm in Rust with the OSM parser we've already got. Argh, I guess the complication is that we don't handle .pbf. There are crates like https://crates.io/crates/osmpbf we could use.
I think this is sounding like an awesome hackathon project. Tentative plan is to do this in two weeks at https://democracylab.org/index/?section=AboutEvent&id=sthacktricksday2021

Step 2 is a bit awkward because we'd need to support copy/paste (across 4 platforms) -- there are crates for it and I think we used to use one of them, so maybe not bad. The single-line text entry box in abst today sucks and I really don't want to make a multi-line one, but we could maybe just have a button saying "grab from system clipboard" and display the result and not allow editing in the UI.

What about showing map with abstreet with bbox selection done there? Exactly like it is done by JOSM?

I'm not aware of any OSM download service that'll extract the city-sized areas people will likely draw

Limit it to a part of the city (say, like Kraków city center bundled in AB Street by default) and use Overpass API? May be not feasible if used on a large scale, but I am not expecting it done on massive scale.

To make sure I'm understanding, it sounds like what you are describing is predicated on having a zoomable slippy map of the world in abstreet?

What about showing map within abstreet with bbox selection done there? Exactly like it is done by JOSM?
it sounds like what you are describing is predicated on having a zoomable slippy map of the world in abstreet?

This sounds hard to implement, so that's why I think we can do step 1 and 2 and just open up the browser to an existing interface that can select boundaries, and tell people to copy-paste the GeoJSON blob back. It'd be cool to embed it directly and make this even easier, but I think even with a browser step, this'd be a huge step in usability.

use Overpass API?

Maybe worth a try, but this is probably not what it's intended for. We need to select all nodes, ways, relations intersecting that bbox. We could try to get clever and filter just for certain types, but that list is kind of huge and probably hard to maintain.

To make sure I'm understanding, it sounds like what you are describing is predicated on having a zoomable slippy map of the world in abstreet?

Yes. No idea how hard it would be and is it reasonable. Main factor is, I guess, "can we use OSMF tile servers or other free tier of tile hosting".

Maybe worth a try, but this is probably not what it's intended for. We need to select all nodes, ways, relations intersecting that bbox.

I do it for some projects, downloading entire cities is within Overpass API range. My guess is that size limitation would be AB performance, not Overpass download capability. And for now any area runnable in AB would be downloadable with Overpass.
(no promises here, and natural=coastline is a trap here - Overpass data needs augmenting with https://osmdata.openstreetmap.de/data/water-polygons.html or some tricky processing to get seas/oceans rendered)

We could try to get clever and filter just for certain types

For some cases I exclude buildings, but AB is using them anyway. I would not try filtering.

But if you are worried that it may be misuses of Overpass - look at their usage policy (I remember reading it - but maybe it changed since that time)

Sounds like the Overpass idea is worth trying, then. Closer to the hackathon, I'll break this down into parallelizable tasks, one of which could be a little tool that tries to effectively assemble a .osm from Overpass.

little tool that tries to effectively assemble a .osm from Overpass.

If it can be downloaded from Overpass (I am betting that any area that can be loaded and run sanely it will be) you can simply download .osm file ([out:xml]).

Dumping more related tasks for the hackathon:

cache the geofabrik index file
rearrange data/input and carve out a single place for all the geofabrik pbfs, since many places will share. Simplify config a bit.

I just tested whatever what I was saying matches reality. I just downloaded 628MB .osm file representing entire city of Vienna with an Overpass query.
I used following script that used (very unimpressive) library code from https://github.com/matkoniecz/osm_bot_abstraction_layer/blob/master/osm_bot_abstraction_layer/overpass_downloader.py (basically, inefficient file saving, logging and retrying).
from osm_bot_abstraction_layer.overpass_downloader import download_overpass_query

vienna_download = """
  [timeout:250];
  (
    nwr(48.10,16.26,48.26,16.51);
  );
  out meta;
"""
download_overpass_query(vienna_download, '/tmp/vienna.osm')

Thank you for confirming Overpass is a viable option! It looks extremely straightforward for us to use it too.

I am not maintainer of Overpass service, not sure how significant use AB Street would generate, not sure how significant use is OK.

I'll double-check their policy before publicizing this tool, and check with the owner. I suspect they have rate limiting on their end for individual users, but we could also send an "A/B Street" user agent if they want to throttle across all users.

I suspect they have rate limiting on their end for individual users

Yes. See http://overpass-api.de/api/status

Though I am not sure if they have user-agent limiting or just request to self-limit. But I expect that AB Street:
will not have this feature used extremely heavily
big chunk of that will be OSM mappers, including use for OSM data validation and other mapping help

Another possibility for OSM data is GeoFabrik. A relatively new but really quite powerful Python library uses it for automatic data acquisition https://pypi.org/project/pyrosm/
It downloads .osm files in Protocol Buffer Binary Format and I've been using it in an automated pipeline to grab data for the whole of London (which surely is one the upper-end of areas you'd be able to handle).
The library is open-source so it might provide a nice example of how to do it:
https://github.com/HTenkanen/pyrosm/blob/master/pyrosm/data/geofabrik.py
Not sure if you could directly call the library to handle it or if you'd have to reimplement the logic in Rust but it seems like it'd be a good alternative and it might have less throttling as they're direct file downloads rather than custom queries

One more thing to consider for usecase of use for OSM mapping validation: how long mappers needs to wait after update to rerun import and see changes.
For Overpass it is enough to wait 5-10 minutes (right now replication lag is 2 minutes).

Just got cargo run --bin one_step_import -- bedfordshire.geojson to work! Lots of smoothing out needed, but that wasn't hard so far. Quick lunch break, then I'll wire up a UI.

End-to-end import from the UI now "works". Lots of hacks along the way. First up, going to work on a sane way to run a command and display live STDOUT/STDERR in widgetry.

Has some rough edges, but after about 6 hours of work, it works. :D

Likely done for the weekend. This'll be included in this week's release, but it's not ready for general use / testing yet. I'll finish this off next week. The remaining tasks, in no real order:

[ ] Put the temporary downloaded files somewhere else
[ ] Name the imported maps differently, so they don't overwrite each other
[ ] Look for the executables a little more flexibly, and start including in the .zip release
[ ] Update the docs
[ ] The clipped map winds up with no borders; we're not being equivalent to --completeWays yet
[ ] Fix the upstream osmio bug with the double end tag
[ ] Make the command runner cancellable
[ ] Add a progress bar to the reqwest downloading
[ ] Stop running the curl command from the importer; use reqwest + whatever progress bar
[ ] Also remove the dependency on osmconvert from importer. Can we remove ALL external deps?
[ ] Revisit all of the bonus tasks listed above
[ ] Announce the new tool!

Very notably, none of this works on the web. I think it could be done in a few different ways, but still leaving that as future work.

This is now done/released. Repurposing this bug to track cleanup tasks that came up along the way.

[ ] Stop calling reqwest directly in parking_mapper.
[ ] Stop calling reqwest directly in map_gui's updater. Maybe just need a FutureLoader.
[ ] Consider removing the dependency on osmconvert entirely. Need to improve performance of clip_osm first, then rerun and make sure it's equivalent.
[ ] Make the command runner cancellable. Need to rethink make_loading_screen to allow extra stuff.
[ ] Figure out web support for importing
[ ] Try using Overpass, which might be much faster than downloading a huge geofabrik extract
[ ] Maybe we don't need to handle the Osmosis boundary format at all; just natively use GeoJSON everywhere?
[ ] Reorganize all .pbf's downloaded in the import pipeline to live under data/input/shared, in a directory structure mirroring what geofabrik does. Change importer config to just refer to these relative filenames, and always assume geofabrik is our main source. The updater may have to get smarter to figure out what pbf to download, based on input DataPacks.

Finally giving the new import screen a wirl.
I'm proposing some minor UI changes here: https://github.com/a-b-street/abstreet/pull/584/files
When running from my development build, I initially saw this screen:

From the application log I was able to deduce I need to do a cargo build --release to compile the import binary, then the import process started to work. Probably fine for dev builds, but wanted to check - is this binary included in the release so that everything "just works"?
The import process is still running - I've swapped out because clip_osm is 16.5GB and climbing. It'd be neat to make that less of a hog.

From the application log I was able to deduce I need to do

Good point, this error could be more clear what you need to do. I guess I was assuming most people aren't building from source...

is this binary included in the release so that everything "just works"?

Yes, it is! I tested with the Linux .zip and it seems fine.

I've swapped out because clip_osm is 16.5GB and climbing

Turns out reimplementing this little piece of osmconvert wasn't as straightforward as I expected. OSM files (including pbf, afaict) always list all nodes, then ways, then relations. The clip tool currently works like this:

Read and cache ALL nodes, no matter how far outside of the boundary they are
For each way, check if ANY of its nodes are inside the boundary. Keep it if so
For each relation, check if ANY of its children (nodes, ways, or other relations) have been saved. Save it if so.
Crawl all ways (whoops just realized this should handle relations too) and build a list of nodes we actually use
Write all of the saved nodes, ways, and relations

That first step is the memory hog. Filtering the nodes inside the boundary in step 1 doesn't work, because then a way crossing the boundary refers to nodes we haven't saved, so the final output doesn't have the node just outside the boundary, which messes up clipping and removes all border intersections.
From skimming the osmconvert source, they do lots of file rewinding. I'm still not sure all of the performance tricks they use, but I think we could adapt our approach to avoid the memory issue.

Read all nodes, only caching the ones in bounds
Read all ways, only caching the ones with at least one saved node
Same for relations
Build a set of all nodes that all of our saved ways and relations refer to
Go back and re-read the file from the start. Save all nodes in the above set
Write all 3

Same for relations

Note that you should have to all ways referred to by relations, what may include ways not cached in step 2.
So you will need to cache additional ways, what may trigger need to cache additional nodes (see for example multipolygon on edge of area).
You may also skip some relations, for example load only multipolygons and public transport routes (anything else?) to avoid loading entire boundary of country or entire waterway relations.

So you will need to cache additional ways, what may trigger need to cache additional nodes (see for example multipolygon on edge of area).

That's a good point. I think that's a bug with the current implementation in abstreet too. Not sure how often it bites us.

Likely not a big issue, as it will affect only complex buildings and greenery eyecandy that is both on map edge and placed in an unfortunate way.

Is it possible to add it also to http://abstreet.s3-website.us-east-2.amazonaws.com/0.2.50/osm_viewer.html ?

On reread it seems that I missed

This only works in the downloaded version, not on web.

part

Ah right. It would technically be possible to make all of this work on the web, but to avoid exploding the initial .wasm size to download with the extra importer dependencies, we'd have to carve out a separate WASM app to separately fetch and execute. And maybe trying to import all in a browser is too intense, and at this point, it'd be simpler to just run a small API server somewhere with reasonable rate-limiting.
Not planning on tackling that soon.
But since you've reminded me of this issue, I'm actually going to take a shot at using Overpass instead of geofabrik + clipping, since I never actually tried that.

I switched the default to Overpass -- it was super easy to wire up, and is way faster than downloading and clipping a potentially massive PBF. This also maybe opens the door for some kind of "refresh my current map with recent data" feature.
https://twitter.com/CarlinoDustin/status/1414699376887287833

One thing that seems missing is a clear handling of Overpass refusal to serve data (say someone trying load entire USA in one go or repeated downloads resulting in exhausting quota)
429, 503, 504 error codes indicate rate limiting

BTW, has Overpass got exposed to web? From looking at diff it seems that it is not changed but it is likely that I missed relevant diff.

One thing that seems missing is a clear handling of Overpass refusal to serve data

Indeed. I can try testing this later to see how the error shows up. I think https://github.com/a-b-street/abstreet/blob/f35538b460146cc637123c987cb96e181b8982da/abstio/src/download.rs#L10 should plumb back the HTTP response code, and https://github.com/a-b-street/abstreet/blob/f35538b460146cc637123c987cb96e181b8982da/importer/src/bin/one_step_import.rs#L73 could check the error code and surface a better message. Might have to rearrange the error handling to plumb back the response code properly.

BTW, has Overpass got exposed to web?

No, nothing has changed here. https://github.com/a-b-street/abstreet/blob/master/importer/src/bin/one_step_import.rs isn't web-friendly. Everything could be done in memory in the browser -- downloading the osm.xml, running the importer, producing the binary map file, feeding it back to abstreet. But bundling all of the code to do that in the abstreet.wasm file would really bloat it; I'd want to keep it separate. And if it was separate, we'd have to asynchronously load and execute the extra WASM, then find some way (maybe the browser's user session storage) to plumb back the binary map file. All of that feels like it's getting complicated. The alternative is running a little server somewhere that does all of this and returns the URL of a hosted binary map.


Debloat button

Description
A button which just runs everything to debloat would be useful, I know there's apply tweaks but it relies on the tweaks being ticked or unticked, where's a debloat button would just remove all the unnecessary things, disable everything etc.
Reason
Apply tweaks relies on user not accidentally leaving something ticked they don't need
Examples
No response

The Apply Tweaks is the button that does everything, the other ticks are not related to it, they behave independently from Apply Tweaks, I know the GUI design doesn't helps, but adding another tab may clarify what each buttons does better. Sorry for the confusing layout I've made, I'm not so good at sketching UIs...


Develop barlines

This PR add data types to bar lines

segno and dblsegno (#969)
heavy and dblheavy (#787)

It also add the corresponding SMuFL codes whenever appropriate

I'll wait for @musicEnfanthen to review and merge, since his review was requested, but it looks good to me.


Use data attributes to overwrite predefined options?

Was just thinking about it now as I will be just adding a certain class to any element I want to use Slick on, but maybe some of these elements would need a few different options rather than the ones I've set in my JS file.
Worth a feature add?
What is the expected behaviour?
To prioritise options from data attributes over the ones that are set from first initialization.
e.g. data-slick='{"slidesToShow": "4", "slidesToScroll": 4}' should overwrite:
$('.gnd-carousel').slick({
	slidesToShow: 1,
	slidesToScroll: 1,
	prevArrow: '...',
	nextArrow: '...'
});

====================================================================
What is observed behaviour?
No change; still uses the options I have defined in my scriptname.js file.
====================================================================
More Details

Which browsers/versions does it happen on? - All
Which jQuery/Slick version are you using? - Latest as of 12/04/2016
Did this work before? - Nope

It's been discussed, actually!. Thanks for the feedback @krypsin


mediumroast_js: Add creation and modification dates to companies

Introduction
Creation and modification dates for company objects should be created and assigned.
Implementation notes

At present the creation date and modification date are not assigned during object creation.  They should be and at initial creation the two dates should be the same.

Confirmed to work


CUPS crashes when information / description strings are too long

cups-browsed (from cups 2.2.0-2 in Ubuntu 10.16) breaks when parsing long lines.  See
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1635856

This is part of cups-filters, NOT CUPS.


restore does not restore match.data

We have mandated that tournaments keep the data key on a match clean. However, this data is not really saved along with the normal state. I.e. if you use Duel.restore from database step as per https://github.com/clux/tournament/blob/427d3c25dd7cb2ffc40ed3b702fb81e9e46af05b/doc/base.md#serialization then this data is lost if you store it on the match.
Restore should be extended to handle match.data.

A fix for this would close clux/duel#14

Released in<EMAIL_ADDRESS>All tournament implementations get this version on reinstall due to the current versioning scheme.


Allow to filter props passed to child component

glamorous version: 4.5.0
glamor version: 2.10.40
react version: 15.6.1

Relevant code:
const withLayout = Component => {
  return glamorous(Component)(
    'layout',
    ({
      align,
      basis,
      flex = 'row',
      grow,
      shrink,
      wrap,
    }) => {
      if (flex === true) {
        flex = 'row';
      }
     return {
        display: 'flex',
        flexDirection: flex,
        flexGrow: grow,
        flexBasis: basis,
        flexWrap: wrap,
        flexShrink: shrink,
        justifyContent: align[0],
        alignItems: align[1],
      };
    },
  );
};

const Layout = withLayout('div');

Problem description:
The code above is a simplified version of my Layout component. As you might have seen I have created a HOC to be able to add layout style to different HTML elements and Components. As a result I can't use rootEl to filter props and the annoying unknown props warning appears e.g. "Unknown prop grow on xyz tag. Remove this prop from the element".
This problem always appears if glamorous is used within a HOC.
Suggested solution:
Add another option to the glamorous api to be able to filter specific properties which shouldn't be passed to the child component. According to 'forwardProps' 'filteredProps' would be a good name.
If somebody points me to the right direction how to implement this new option I would create a new pull request.

Thanks for this. I'm fine with filteredProps. Thanks for being willing to help! Here's what needs to happen:

Test it (creating a index.filter-props.js file would be best I think). Should also behave like forwardProps here I think...
Implement it here and here (basically do the same thing we do with forwardProps).
Document it on the website (open a PR on that repo).

Make sure to follow the contributor guidelines.
Thanks!


Tutorial doesn't work

I've tried running all the steps in the tutorial as-is, but the gateway did not work.
No address is returned (even a long while after deployment):
$ kubectl get ingress
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
NAME        CLASS    HOSTS   ADDRESS   PORTS   AGE
aspnetapp   <none>   *                 80      36m

I manually searched for the IP created for AG, and curl gets:

<title>502 Bad Gateway</title>

502 Bad Gateway

Microsoft-Azure-Application-Gateway/v2

And it seems that the AG is created without backend targets:
        "backendAddressPools": [
            {
                "name": "bepool",
                "id": "[redacted]",
                "properties": {
                    "provisioningState": "Succeeded",
                    "backendAddresses": [],
                    "requestRoutingRules": [
                        {
                            "id": "[redacted]"
                        }
                    ]
                },
                "type": "Microsoft.Network/applicationGateways/backendAddressPools"
            }
        ],

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e4a217cd-8949-e9b8-d8c5-a0f864b10237
Version Independent ID: e38769a3-04f6-c695-da48-8d0598a06bb9
Content: Tutorial: Enable the Ingress Controller add-on for a new AKS cluster with a new Azure Application Gateway
Content Source: articles/application-gateway/tutorial-ingress-controller-add-on-new.md
Service: application-gateway
GitHub Login: @Caya
Microsoft Alias: caya

@aelij
Thanks for your feedback! We will investigate and update as appropriate.

@SaiKishor-MSFT how long did it take for the IP to appear? I waited over 30 minutes. If it takes longer than a few minutes I would add a warning to the docs.


GraalJS' node throws PermanentBailoutException running Grunt

First, thank you all for your work on GraalJS, it's helped us out quite a bit.
We've got a subproject of a larger project which is Javascript and node-based, using Grunt as the build tool.  We call Grunt to build this subproject as part of the main project, creating a JS file artifact.  We use GraalVM/JS to run the Javascript as part of our test suite.
What we've found is, when using GraalVM and the GraalJS Node.js binary is also on the path, we get an exception when running Grunt:  org.graalvm.compiler.core.common.PermanentBailoutException: Compilation exceeded 300 seconds during CFG traversal
Even though this exception is thrown, Grunt completes successfully and the rest of the build and testing can continue, but with a 5 minute lag for what is usually a 15 second process.  I'm attaching the output with the full exception in case that is helpful.
GraalJS node and grunt exception.log
Our workaround for the moment is to keep the GraalJS node off the path, so the regular node can run Grunt without the delay and error, but I thought this was worth reporting.
Grunt version is 1.3.2, GraalVM version is CE RC12.

Hi @LaCuneta
thanks for your report. Is your project available somehow so that we can try that out ourselves? That is definitely interesting and we would like to investigate that. It seems it happend during execution of browserify - we are regularly running that ourselves, so this package is known to work fine in principle.
The error means that Graal could not compile a certain method (it timed out while trying that); this is not catastrophic as the code is still executed by the interpreter, but that might be a magnitude slower.
Short-running processes in general are not the ideal target for Graal-Node.js currently - it is prone to slower warmup, thus processes like npm or grunt take longer than on the original Node.js. A delay like you experience it is unexpected, though.
Best,
Christian

Thanks for the information on short running processes with Graal-Node.js!  That will be good to know even if this problem is resolved.
Our project is public, here are the steps you can try to reproduce (note the project as a whole is Scala/sbt-based, but you should not need them installed to run these steps):

Clone the Tortoise repo: https://github.com/NetLogo/Tortoise
Navigate to the engine/ directory.
npm install
Make sure the Graal-Node.js node is on the path.
./node_modules/grunt/bin/grunt - should run the build scripts and cause the issue.

I hope that helps!  Thanks again.

Thanks for your setup details.
I am failing with
Running "browserify:main" (browserify) task
>> Error: Cannot find module './engine-scala' from '/home/christian/oracle/githubissues/graaljs/118/Tortoise/engine/target/classes/js/tortoise/shim'
Warning: Error running grunt-browserify. Use --force to continue.

Aborted due to warnings.

engine-scala is referenced several times from this project, seems to be an npm module (or plain .js file?). Not part of the repo, not referenced in any package.json file, don't find it on npm or with google. Where can I get that from?

Shoot, that's my bad, I forgot there are a couple Scala files compiled for the engine.  You can ignore them for this test case.  I put a branch called graal-example with the dependency removed you can check out, or if it's easier you can comment out { MersenneTwisterFast } = require('shim/engine-scala') from prims.coffee:18, auxrandom.coffee:3, random.coffee:3 and it should be good to.
However, I noticed when I ran grunt on the graal-example branch on my machine I did not get the timeout!  When I took a copy of the missing engine-scala.js file and put it in the appropriate place (engine/target/classes/js/tortoise/shim/), then added the references to MersenneTwisterFast back, the timeout re-appeared.  So this might be related somehow.  I'm attaching a copy of the engine-scala.js file in case that is helpful.
engine-scala.js.zip

Thanks, will investigate!

Hi,
I could not yet reproduce your problem, it does not occur on the master branch for me. On my machine, the grunt task always (successfully) finishes after around two minutes (that's way too long compared to original Node.js, but no failure either). I'll investigate the graphs to see if there is anything we can immediately optimize for.
Warmup improvements in general are high up our agenda, so the overall performance should (and will) improve over the next months.
Best,
Christian

Thanks for checking into it!  We'll look forward to the warmup improvements.

I have revisited this issue. I still cannot reproduce the failure on my machine. I am thus closing it, given the amount of changes to both the Graal.js engine and the GraalVM compiler in the meantime.


Change quantity is not returning the subscription detail

Describe the bug
Change quantity is not returning the subscription detail
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Are you using the CloudShell?
If not using the CloudShell:

OS: [e.g. iOS]
PowerShell version
Modules installed

Additional context
Add any other context about the problem here.

This seems to be a known issue in CSP scenarios.


Reduce the size of //tensorflow/tools/pip_package:simple_console_windows

This change reduce the size of //tensorflow/tools/pip_package:simple_console_windows's zip file from<PHONE_NUMBER> bytes to 47690474 bytes for a CPU build. For GPU build, it will avoid going over 4GB when multiple CUDA compatibility are specified.
To fix https://github.com/tensorflow/tensorflow/issues/22390
/cc @gunan

Thanks for the review!

@meteorcloudy could you send this internally instead?

Will do it!


Add except option in Partial reloads

In some cases the parameters are too many in the only option
So I added an option
except
I also added it in https://github.com/inertiajs/inertia/pull/1477

Heya. We removed our master branch. Feel free to re-attempt this to 1.x!


PD: Support receiving multiple records in osdp_OUT

According to the standard (3.9) the command command structure is 4-byte element, repeated 1 or more times.

The PD right now does not support this feature because the CP implementation does not support this. I will add support for this feature on PD side only (adding this to CP will make the API complex).


Clarify amocas.w for RV64 and add a code sequence

1, Add a clearer explanation that only low 32 bits are used in compare for rv64
2. Add assembler example to suggest assembler syntax

I think the proposed assembler syntax is the only sensible one given the precedent of the other atomics operations (and e.g. zicbo* which also use (reg)). It matches what I've implemented for LLVM.


Implement and test set/get land_inspector functions

We need to implement, improve, and thoroughly test the functions for setting and getting land inspectors in our LandVer system. This will involve adding new functionality, enhancing existing code, and creating comprehensive tests.
Tasks:

Implement set_land_inspector function

Add the function to the ILandRegistry trait
Implement the function in the LandRegistry contract
Ensure only authorized entities (e.g., admin) can set inspectors
Add proper error handling and event emission
Implement get_land_inspector function
Add the function to the ILandRegistry trait
Implement the function in the LandRegistry contract
Return the inspector's address for a given land ID
Enhance inspector management
Implement a function to remove an inspector from a specific land
Add a function to list all lands assigned to a particular inspector
Implement a function to check if an address is an inspector for any land
Update data structures
Modify the Land struct to include an inspector field
Add a mapping to track inspector assignments efficiently
Implement access control
Create an only_admin modifier or function to restrict access to admin-only functions
Ensure all inspector management functions use proper access control
Write comprehensive tests
Test setting an inspector for a land
Test getting an inspector for a land
Test removing an inspector from a land
Test listing lands for a specific inspector
Test access control (only admin can set/remove inspectors)
Test error cases (e.g., setting inspector for non-existent land)

Definition of Done:
• Tests are written to verify the new functionality.
Note: Only applications through the OnlyDust platform will be considered.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a full-stack developer with experience in QA testing and languages like Python, Cairo, Solidity, React, and JavaScript.
How I plan on tackling this issue
i will Validate input parameters.
Check for land existence.
Enforce ownership authorization.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a cairo developer with alot of contributions in the starknet ecosystem. I belive i would be a perfect fit for this issue and i would love to show case my skills in this repo if given the chance.
How I plan on tackling this issue
I would go throught the code base first of all to get a feel of the project and coding style. Then i would start implementing the function. then i would create an event to be fired off when a land inspector is set. Then i would write several test cases for the function to make sure it works as expected and the event is fired off.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a web3 developer with experience writing smart contracts and testing: Here is my onlydust profile:https://app.onlydust.com/u/No-bodyq
How I plan on tackling this issue
I will implement the set_land_inspector function using the function parameters and mapping the land_id to the inspector address. I will then write tests to substantiate the new functionality

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a web3 developer with 3 years expeerience writing tests and developing smart contracts
How I plan on tackling this issue
Properly go through codebase find the invariants , test against it anf figure out specific edge cases to test for  while ensuring it tallies with intended functionality

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a Full Stack Developer specializing in Next.js, TypeScript, Node.js, Cairo and Rust . With over 31 contributions across projects in the OnlyDust ecosystem, I’ve developed strong proficiency in delivering high-quality solutions and resolving complex issues within tight deadlines. My experience spans frontend, backend, smart contracts, and the optimization and maintenance of scalable codebases.
How I plan on tackling this issue
To implement and test the set_land_inspector function, I will ensure its correctness and reliability through comprehensive testing. The function will allow assigning an inspector to a specific land ID within the smart contract.
I will begin by defining the set_land_inspector function, which will take land_id of type u256 and inspector of type ContractAddress as parameters. This function will update the contract's state to link the specified inspector with the designated land ID. To maintain security, I will implement access controls to ensure that only authorized users can invoke this function, preventing unauthorized changes to the land inspector assignments.
The core logic will involve updating the contract's state to establish the relationship between the given land ID and the specified inspector address. After completing the implementation, I will write tests to verify the functionality of the set_land_inspector function. These tests will cover successful assignments of a land inspector to valid land IDs, correct state update verification after function calls, and access control checks to ensure unauthorized users cannot execute the function. I will also test edge cases, such as attempts to assign an inspector to a non-existent land ID.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hello, i'm an experienced frontend and block chain developer. I would love to work on this issue.
How I plan on tackling this issue

I will understand the function signature
i will modify the smart contract
i will Write unit tests to ensure the functions work as expected .
I will Write integration tests to verify the function works within the overall system.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have a solid background in smart contract development and blockchain technology, specifically with platforms like Ethereum and StarkNet. My expertise includes designing and implementing decentralized applications (dApps) with a strong emphasis on security, efficiency, and functionality. I have experience in developing and testing smart contracts that involve complex data management and access control mechanisms. This background equips me to effectively implement and enhance the inspector management functionalities within the LandVer system, ensuring that the new features are robust, secure, and thoroughly tested.
How I plan on tackling this issue
I would begin by reviewing the existing LandRegistry contract to understand its current structure and functionality related to land management and inspector assignments. I would then implement the set_land_inspector function by adding it to the ILandRegistry trait and defining its logic in the LandRegistry contract, ensuring that only authorized entities can set inspectors through an only_admin access modifier. Proper error handling and event emission would also be incorporated.
Next, I would implement the get_land_inspector function, ensuring it accurately retrieves the inspector's address for a given land ID. I would enhance the inspector management system by adding a function to remove inspectors from specific lands and another to list all lands assigned to a particular inspector. Additionally, I would implement a function to check if an address is an inspector for any land.
To support these features, I would update the Land struct to include an inspector field and establish a mapping to manage inspector assignments efficiently. I would ensure that all functions related to inspector management utilize proper access control through the only_admin modifier.
Finally, I would write comprehensive tests to verify the new functionalities, covering scenarios such as setting and getting inspectors, removing inspectors, and listing lands for a specific inspector. I would also include tests to ensure that only admins can perform restricted actions and to handle error cases appropriately. This structured approach will ensure that the inspector management functionalities are effectively implemented and thoroughly tested, enhancing the integrity of the LandVer system.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
i  have experience in cairo and previously as personal projects and OS, so hoping to make use of them here and mark my first odhack contributio
How I plan on tackling this issue
I will implement a comprehensive land inspector managment sys using a hierarchical validation approach that includes cross-inspector verification nd integrity checks through the Merkle proofs for land assignments. The implementation will feature a dynamic rating system for inspectors based on their verification history, with automated performance metrics influencing their future assignment eligibility.
While this adds significant security features, I believe the centralized inspector assignment model culd be improved by implementing a decentralized consensus mechanism for inspector selection, potentially using a reputation-based staking system.


[Improvement]: The AMS API should shade the ZooKeeper and Curator packages to prevent potential issues caused by version incompatibility

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
The AMS API should shade the ZooKeeper and Curator packages to prevent potential issues caused by version incompatibility, such as the following:

How should we improve?
Shade the ZooKeeper and Curator packages in the AMS API module.
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

It seems to be the same issue with #1611 .
@xieyi888 had tried to fix it by #1612.
Can you both review the solution approach and PR together? We can work together to push forward the resolution of this issue.

It seems to be the same issue with #1611 . @xieyi888 had tried to fix it by #1612.
Can you both review the solution approach and PR together? We can work together to push forward the resolution of this issue.

ok, i will close this PR, and this issue will be fixed in PR #1611 .

Thansk

It seems to be the same issue with #1611 . @xieyi888 had tried to fix it by #1612.
Can you both review the solution approach and PR together? We can work together to push forward the resolution of this issue.

Thanks, I had change ams/api/pom.xml  in https://github.com/NetEase/arctic/pull/1612 ,Please take a look , Thanks so much


[WIP] fix: Executable path on mac

Closes https://github.com/shiipou/clone-project-manager/issues/3

Must be fixed by the total rewrite of the app.


Investigate whether JsUtility.getScriptResource() is able to extract resources from JAR files

I strongly suspect that the getScriptResource() method is only able to read resources from the standard file system; resources contained in JAR files may not be accessibly via this method as it's currently implemented.

This utility method performs as expected with resources contained in JAR files. No need to do anything.


batteryPercentageState?

hi,
thanks for the plugin and the update, can you add batteryPercentageState from the API? then i can see my battery.

I can try.  However, I don't have a SolarEdge system with a battery, so I cannot test it.  That means that you would have to be willing to test it.  If that's the case, contact me at<EMAIL_ADDRESS>and I will share the files with you to copy onto your homebridge to test it for me.
-Ed
On Monday, November 2, 2020, 5:12:52 AM CST, colseven<EMAIL_ADDRESS>wrote:

hi,
thanks for the plugin and the update, can you add batteryPercentageState from the API? then i can see my battery.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

New index.js and config.schema.json files sent.  Let me know if it works for you.

Feature tested and committed in version 0.1.3.


(iOS) EXC_BAD_ACCESS when calling presentFullscreenPlayer()

When calling presentFullscreenPlayer(), it seems like UIResponder gets into some kind of loop or infinite recursive vortex.
I'm using React 0.40 on iOS 10.2 with react-native-video master (perhaps I should wait for an official release? Just wanted to get up and running with react 40).
RCTVideo.m

How my component looks
....
  <TouchableOpacity onPress={() => {this.setState({videoPaused: false}); this.player.presentFullscreenPlayer();}}>
    <Text>Play</Text>
  </TouchableOpacity>
  <Video
    source={{uri: 'http://techslides.com/demos/sample-videos/small.mp4', type: ''}}
    paused={this.state.videoPaused}
    ref={(ref) => {
      this.player = ref;
    }}
    resizeMode={'cover'} />
...

This video works fine playing without fullscreen mode.

this is now working for me, but would be interested if anyone else gets this.

same thing.
how did you avoid that issue?

@vadzim-wellit - I eventually just pointed to master for this repo, and forked it into my own so no changes would be introduced that might break my project.  I think that's what fixed it, but i'm not completely sure.


Daikin Cloud changes will break this integration March 11th 2024

See https://github.com/rospogrigio/daikin_residential/issues/182#issuecomment-1933967548 and https://developer.cloud.daikineurope.com/login, Daikin is intentionally breaking all existing integrations including this one. They only give a month to rework the code

Thank you for informing ...lets see ... need to check how we change here because 200 calls a day is way too less for normal integration use cases

I have it on my plan to adjust soon

@Apollon77 I have read the topic in daikin_residential. I'm trying to find out what the impact will be for my plugin (https://github.com/JeroenVdb/homebridge-daikin-cloud).
Will I have to register as a Developer and bring my own key or let my users bring their own key?

Daikin introduces a new developer portal for open source. In the end it will be a OAuth flow initially to get tokens which can be used then. In the beginning it is a central client id, later each develoepr/user needs his own client-id.
it seems that they rendered unintentionally the old ways no longer working too early which is meehhh ... I need to find some days to add this here.

Yes, looks they broke something, also users of other integrations are reporting issues, for example https://github.com/rospogrigio/daikin_residential/issues/209

I had exactly the same problem with homebridge and found a workaround:

Log in to the Daikin Onecta app (if already logged in, log out and log in again)
Enter new required information, which is now asked for
Restart Homebdrige, the login now runs without problems

Just FYI: The Tuya platform integration also requires you to first create a developer account. I guess, my for April, that would be a feasible option to let everyone bring their own key/authentication.

@JeroenVdb on tuya it dependss what you want ... other story in my eyes

@JeroenVdb BTW: There will be rate limits also ... e.g. 200 calls/day and such ... so the library will try to optimize that as much as possible, so next version will be a major one

Log in to the Daikin Onecta app (if already logged in, log out and log in again)
Enter new required information, which is now asked for
Restart Daikin-cloud adapter

This worked for me.
Let's keep fingers crossed that it will stay this way ... I have written a heating/cooling automation with external temperature sensors relying on this adapter.

2.0.0 released


Is it possible to wait till document is received ?

Is it possible to wait till document is received in componentdidmount ?
Isfirst = () => {
var value = undefined;
dB.findOne({'isfirst': true}, function (err, doc){
console.log(doc)
value = doc
})
return value
}
Componentdidmount() {
var value = this.Isfirst();
console.log(value);
}

I did not understand your question, but you can use db.findAsync, which returns a promise

@antoniopresto can please give me an example of dB.findAsync how can I use it ?
Thank you.


Ionic 2 RC3 new project does not work

Short description of the problem:
I created a new ionic 2 project using 'ionic start myProj blank --v2'  and I have latest ionic 2, node and npm as below:
Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.3
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.45
ios-deploy version: 1.8.3
ios-sim version: 5.0.4
OS: OS X El Capitan
Node Version: v6.9.2
Xcode version: Xcode 8.2 Build version 8C38
npm version: 4.0.3
What behavior are you expecting?
When running 'ionic serve', I got the following errors:
ionic serve

ionic-hello-world@ ionic:serve /Users/myProj
ionic-app-scripts serve

[11:31:47]  ionic-app-scripts 0.0.45
[11:31:48]  watch started ...
[11:31:48]  build dev started ...
[11:31:48]  clean started ...
[11:31:48]  clean finished in 1 ms
[11:31:48]  copy started ...
[11:31:48]  transpile started ...
events.js:160
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE <IP_ADDRESS>:53703
at Object.exports._errnoException (util.js:1022:11)
at exports._exceptionWithHostPort (util.js:1045:20)
at Server._listen2 (net.js:1259:14)
at listen (net.js:1295:10)
at net.js:1405:9
at _combinedTickCallback (internal/process/next_tick.js:77:11)
at process._tickCallback (internal/process/next_tick.js:98:9)
at Module.runMain (module.js:606:11)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:149:9)
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "ionic:serve" "--"
npm ERR! node v6.9.2
npm ERR! npm  v4.0.3
npm ERR! code ELIFECYCLE
npm ERR! ionic-hello-world@ ionic:serve: ionic-app-scripts serve
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ionic-hello-world@ ionic:serve script 'ionic-app-scripts serve'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ionic-hello-world package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ionic-app-scripts serve
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ionic-hello-world
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ionic-hello-world
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/myProj/npm-debug.log
There was an error serving your Ionic application: There was an error with the spawned command: serve
Steps to reproduce:

download lated node v6.9.2
update npm to latest v4.0.3
npm install -g ionic
ionic start myProj blank --v2
ionic serve

insert any relevant code between the above and below backticks

Which @ionic/app-scripts version are you using?
ionic-app-scripts 0.0.45
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

This issue occurs because you have 2 instances of ionic serve running.  The following commit should resolve this issue in the future. d6de4132247af41a52e291f15f91cc4930404092


RSP-1706: X-Content-Type-Options

See https://helmetjs.github.io/docs/dont-sniff-mimetype/

Set by default with helmet


fix: fix size limit by removing unneeded function

approved. but I think you should do this once everything else is in dev

Will wait for all remediations then pull dev and merge this


Automated Package Upgrade

:tada: This PR is included in version 25.3.248 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Composer S3 save ckpt bug?

Hi, i'm using this config
# Checkpoint to local filesystem or remote object store
    save_interval: 4ba
    save_num_checkpoints_to_keep: 1  # Important, this cleans up checkpoints saved to DISK
    save_folder: s3://bucket/path/llama2/ckpts/{run_name}
    save_filename: ep{epoch}-ba{batch}-rank{rank}.pt
    save_overwrite: true

Composer warns me
2023-08-18 13:41:24,016: rank0[247][MainThread]: DEBUG: composer.utils.checkpoint: Saving checkpoint to path/llama2/ckpts/{run_name}/ep{epoch}-ba{batch}-rank{rank}.pt

So it's saving in my local directory, not s3, he ignores s3://bucket/
My endpoint is ok, casue no errors about this and my data_remote loads good from my s3.

@germanjke, Are you sure it doesn't get saved to s3?

It will saved on local path anyway?
It's not like if s3 in path: save_to_s3() else: save_to_local()?
yes i confirm it

Name: composer
Version: 0.15.0
Summary: Composer is a PyTorch library that enables you to train neural networks faster, at lower cost, and to higher accuracy.
Home-page: https://github.com/mosaicml/composer
Author: MosaicML
Author-email<EMAIL_ADDRESS>License:
Location: /usr/lib/python3/dist-packages
Requires: coolname, importlib-metadata, mosaicml-cli, numpy, packaging, psutil, py-cpuinfo, pyyaml, requests, tabulate, torch, torch-optimizer, torchmetrics, torchvision, tqdm
Required-by:

The debug print statement is a bit misleading. Under the hood we create an S3 object store which already knows what bucket it is writing to. So within that bucket it is writing to the object key that it prints out.

It's little bit strange, cause I can save gpt-neo-125m checkpoints and can't save it with LLaMA2, with same docker image
Maybe problem on my side, will try to fix this
I hope it's no bugs about LLaMA2

Hi guys, problem was about ~11 min downloading 7B ckpts to s3, obviously 125m ckpts downloads so much faster.
My expermients was like debug, and max_duration was like 10ba (training was like 10 mins), so when training is over i just killed my jobs.
But if you will not kill them after training,  ckpts will saving later. So yes, just wait some time for bigger models.
Thanks!


Feat: Add onClick callback

This PR adds onClick callback support and fixes #273

Current coverage is 95.58% (diff: 100%)

Merging #312 into master will increase coverage by 0.13%

@@             master       #312   diff @@
==========================================
  Files             3          3
  Lines           132        136     +4
  Methods          20         20
  Messages          0          0
  Branches         31         32     +1
==========================================
+ Hits            126        130     +4
  Misses            6          6
  Partials          0          0

Powered by Codecov. Last update 5f41589...ef3b56e


Random exceptions thrown

No resources are loaded with JSv2 and randomly the following error is logged: (There are maybe also others)
 [JSv2]   [JS] Exception caught while invoking event handler
 [JSv2]   TypeError: Cannot read properties of null (reading 'type')
    at removeEntityFromAll (internal:shared/entity.js:64:41)
    at internal:shared/entity.js:54:5
    at Event.invoke (internal:shared/events.js:265:17)
    at onEvent (internal:shared/events.js:408:18)

Fixed in https://github.com/altmp/altv-js-module-v2/commit/f4a09e3a347e0d13d062143e5cb6b0f84111619f


undefined method `username' for nil:NilClass

Link: https://www.codewars.com/kata/55e2adece53b4cdcb900006c/train/haskell
Message: undefined method `username' for nil:NilClass

This should be fixed.


Frontend Dev (HTML, CSS, JS): CSS Combinators

Description
Description
I would like to make documentation on CSS Combinators
I would provide theory related to it along with some examples
Domain
Frontend Dev HTML/CSS/JS
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign documentation

/assign documentation

/assign

@ayushjain27 this issue was created by me so please try to understand and create your own issue.


Add date range selectors and file exporting

This lets you select a date range and then export it to a .ods file.

Before merging this I'm going to go back and see if I can improve some of the code, which is a little messy compared to the previous work done on it.
I'm wondering if @JamesRamm is still interested in this project at all. I modified your code to introduce date selectors instead of predefined buttons, but am afraid it's not as organized as yours. Would appreciate if you're willing to give it a look.

If possible, I would separate the commits into 2 PR's - one for 'Add Date Range Selectors' and one for 'Exporting'.

I'm going to go ahead and merge it. It works in my browser on my machine, without any bugs.
I think we can just increment it a major version. @tomdyson would you be willing to deploy this? Or to add me to the package on PyPi (alexgleason).

Thanks @alexgleason! I've added you as a maintainer on PyPI: https://pypi.org/project/wagalytics/


Add content-length header to tornado app

The Content-Length header is needed to display download progress: https://github.com/silx-kit/h5web/pull/908.
Flask already adds it automatically in the flask.Response object so I add it manually for tornado.
We could argue that the header could be set when creating the h5grove.Response but as Flask adds it already, perhaps it is easier that the implementing back-end has the responsibility of adding it?
What do you think @t20100 @axelboc ?

Probably safer to include it in h5grove.Response. Not a big deal if Flask overwrites it (although maybe it just skips adding it if it already exists?)

Probably safer to include it in h5grove.Response. Not a big deal if Flask overwrites it (although maybe it just skips adding it if it already exists?)

I think it will go the other way round: we create the Flask,Response object which sets the Content-Length headers and then, we set the custom headers, eventually overwriting Flask ones.

Having Content-Length in headers returned by encode sounds more generic: If we restore streaming at some point to interleave data reading/sending, I guess that would be needed... but if there is HTTP compression further down the way, it's a problem right?.. or we can expect the compression step to overwrite the value?

Anyway, this if fine for me as it is, we can rework it if streaming is needed.

@t20100 Could you have another look ? I changed Response to compute the Content-Length at construction


Test variants discovery for Android projects

My implementation in #173 takes into account any user defined build variants and the default build variants - debug and release except the default test variants - test and androidTest.

Addressed by https://github.com/microsoft/build-server-for-gradle/pull/194


Allow search hotkey from search activity

When already searching, one cannot use ctrl+/ key to activate search again. This should allow user to highlight search query string for a new search.

Given #318 and #223, is this still relevant? Not sure I understand the functionality entirely. Ctrl + / for highlighting the query in the same way as #318?

Ctrl+/ from the search activity should highlight the entire query as it
would if going to the search activity from another activity like
history/bookmarks
Currently doesn't seem to do that
If I've gone down a few results and want to search something with hotkey it
doesn't focus the search bar for a new query, in this case a new line is
being sung and want to search that instead
On Tue, Dec 3, 2019, 20:29 Harjot Singh<EMAIL_ADDRESS>wrote:

Given #318 https://github.com/ShabadOS/desktop/issues/318 and #223
https://github.com/ShabadOS/desktop/issues/223, is this still relevant?
Not sure I understand the functionality entirely. Ctrl + / for highlighting
the query in the same way as #318
https://github.com/ShabadOS/desktop/issues/318?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ShabadOS/desktop/issues/319?email_source=notifications&email_token=ADLZ3BZDZQPZ3MH4L3BJGVDQW4BX5A5CNFSM4JTHGTD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3MY6Q#issuecomment-561433722,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLZ3B246YULD3MAYXWLOU3QW4BX5ANCNFSM4JTHGTDQ
.

We could also have this swap the input mode. Or long-press can swap input mode.

Ctrl+a is an acceptable alternative


Fix URL unwrap fatal error in xcode preview

Updated FileManager extension to use init(fileURLWithPath:)
URL initializer when constructing file path in switch statement
for 'file' and 'directory' types.
Xcode preview was crashing due to the URL force unwrap encountering
a nil value. This happens when the path contains a space and hence
URL(string:) returns a nil value.
The root cause; "Simulator Devices" folder located in:
/Users//Library/Developer/Xcode/UserData/Previews
On my device i actuall have a directory with a space and a directory
with a URL encoded space;
./Simulator Devices
./Simulator%20Devices
Making the above change prevents the fatal error and still seems to use
the correct directory (Simulator Devices).
I imagine this is really an apple/xcode issue and there should only
be one of those directories present.
Tested on Simulator and physical device; working as expected.

"Simulator Devices" folder located in:
/Users/<your_user_name>/Library/Developer/Xcode/UserData/Previews


python3.pkgs.aiomysql: fix build dependency constraints

Description of changes

Pull patch that updates setuptools-scm and removes setuptools-scm-git-archive.
Add wheel as an explicit build dependency.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Shouldn't we wait until the PR you linked in the diff lands in a release?

It's unclear when a release will be made, and I need something like that for the work in https://github.com/NixOS/nixpkgs/issues/247287, because building a package with build validates build dependency constraints. At the moment, the failing constraint is that setuptools-scm in nixpkgs is too recent.

Result of nixpkgs-review pr 250206 run on x86_64-linux 1

8 packages marked as broken and skipped:

python310Packages.orm
python310Packages.orm.dist
python310Packages.ormar
python310Packages.ormar.dist
python311Packages.orm
python311Packages.orm.dist
python311Packages.ormar
python311Packages.ormar.dist

4 packages built:

python310Packages.aiomysql
python310Packages.aiomysql.dist
python311Packages.aiomysql
python311Packages.aiomysql.dist


feat: external cloud upload

Applicable spec: N/A
Overview

Adds parameter for uploading to a different cloud (openstack project)

Rationale

To place runner image builder in a different model.

Module Changes

cli.py: added optional paramter upload-cloud to define a different cloud to use from default (first in clouds.yaml)
openstack_builder.py: Added path to upload to a different cloud.

Library/Dependency Changes
None.
Checklist

[x] The contributing guide was applied
[x] The documentation is generated using src-docs
[x] The PR is tagged with appropriate label (urgent, trivial, complex)
[x] The application version in pyproject.toml is incremented

The remaining conversations:
https://github.com/canonical/github-runner-image-builder/pull/19#discussion_r1738930072
https://github.com/canonical/github-runner-image-builder/pull/19#discussion_r1738972647
https://github.com/canonical/github-runner-image-builder/pull/19#discussion_r1742014021
to be addressed in a followup PR since it takes quite a while to get the integration tests passing.


Expanded row Feature added

Expanded row Feature added, needed in my own project added feature, please review and merge.

Hi, i'm an user of this library, so i decided to fork it and I'll take a look at the pull requests and slowly merged everything.
If you want to help me or only support me please take a look at my fork, i will take a look at all prs and add them fast, don't worry :)

Sure
Sent from my iPhone

On Sep 26, 2021, at 4:32 PM, Carmelo @.***> wrote:

Hi, i'm an user of this library, so i decided to fork it and I'll take a look at the pull requests and slowly merged everything.
If you want to help me or only support me please take a look at my fork, i will take a look at all prs and add them fast, don't worry :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Checked the pull request in a fork of mine. First off this looks good in my opinion, but I do think you need to adjust the following.

You missed to declare the RowExpandComponent in the module as normal- and entry component.
You declared a function onExpandRowClick inside the ng2-smart-table component you can remove it if there is no use for it unless I can see this as a sort of API thing.
You changed ng2-smart-table to ngx-smart-table.
DivViewComponent is a great example where we can define a component where we include the table, but I think for me it would be best to narrow it down and make more strict what users can put into row in between.

Other than that good work and hopefully we see this soon in the release of ng2-smart-table 🚀

Checked the pull request in a fork of mine. First off this looks good in my opinion, but I do think you need to adjust the following.

You missed to declare the RowExpandComponent in the module as normal- and entry component.
You declared a function onExpandRowClick inside the ng2-smart-table component you can remove it if there is no use for it unless I can see this as a sort of API thing.
You changed ng2-smart-table to ngx-smart-table.
DivViewComponent is a great example where we can define a component where we include the table, but I think for me it would be best to narrow it down and make more strict what users can put into row in between.

Other than that good work and hopefully we see this soon in the release of ng2-smart-table 🚀

I have made correction, Please check and let me know,
1, fixed.
2. removed.
3. fixed now.
4. I kept this as I needed specific details for my own project, we needed to display complex component within expanded row.
5. also added couple if fixed related multi select column bug.


Sending to Cloud Logging ignores HOST_METRICS_LOG_SYSTEM

Flag HOST_METRICS_LOG_SYSTEM seems to only influence the output to console.
System.* metrics are still received in Cloud Logging.
We only need the process.* metrics and receive a lot of data from cloud foundry.
Host metrics are currently reporting 655 entries per minute that are not even available in the BTP cockpit (more cpu/ram than is assigned to the current instance).

hi @marcsst
right, HOST_METRICS_LOG_SYSTEM is only considered in the console exporter. i'll try to clarify that in the readme.
i'm afraid you'll need to find a different solution, because we only start up @opentelemetry/host-metrics and are not involved any further in case of exporting via otlp... if you find a way to configure @opentelemetry/host-metrics, let me know!
best,
sebastian


net/freeradius: EAP-TTLS with inner auth from LDAP is impossible to configure from GUI

We have been tinkering to get our desired setup working, but we had to manually patch config files to make it work.
If you wish to use EAP-TTLS with inner-tunnel auth set to PAP, which actually uses LDAP on Radius side, in inner-tunnel config,
the authorize ldap section needs to look like the one in the default file.
The way it is now, for any type of EAP auth that uses an inner tunnel, LDAP will never work.
If the inner-tunnel site config is changed as shown, and the client is configured for EAP-TTLS and PAP as inner auth, then the TLS tunnel is built properly using the annonymous uid and then as the inner auth the credentials are being sent and an LDAP bind is attempted to verify the user can authenticate. This has been tested against an IPA LDAP server.
authorize {
...

        #
        #  The ldap module reads passwords from the LDAP database.
        ldap
          if ((ok || updated) && User-Password) {
              update control {
                  Auth-Type := ldap
              }
          }
...
}

authenticate {
...
        Auth-Type LDAP {
                ldap
        }
...
}

as a workaround now: what is the way to make this permanent for us?
Currently each time the gui is touched, our edits will be overridden.

I will take care of all your Tickets, sounds reasonable. Thx for investigation

Sure, thanks so much for taking care of this plugin. It has saved us the huge PITA to setup a radius ourselves, which is always everyones least favorite thing to do... 😆

Sorry for the delay, I added a checkbox in LDAP section to explicitly enable this, so this wont break existing setups (if any) cause I cant test every combination.

it seems that this has been adressed in some other ticket. is that the case?

Yep, #2626 .. maybe @fichtner is motivated to have a look next week :)


command incorrect

for me , the install command is
dotnet  tool install --global dotnet-search
not dotnet install tool --global dotnet-search

Fixed with #4


Handle decoding errors

supernova-tests: user error (Decoding error: Invalid magic number: 0)

Closed by #15


Make OutputEventRenderer single point emitting threads for rendering pipeline

Expected Behavior
Executor logic e.g. for throttling or task grouping is moved to OutputEventRenderer, the top of the rendering pipeline. Synchronization only needs to happen in OutputEventRenderer and none of the listeners in the pipeline.
The central executor is shut down as needed. Part of the work will likely involve identifying all the places that create instances of OutputEventRenderer outside of a service registry. To be able to properly shut down, the OutputEventRenderer needs have a lifecycle.
Current Behavior
Synchronization needs to happen at lower levels of the rendering pipeline. This maybe lead to contention and synchronization issues.
Context
Avoid contention and synchronization issues for rendering pipeline.
Related to #2221

Duplicate of #2221


Add TypeScript definitions

This day and age TypeScript definitions are mandatory with an SDK for a paid service.

Thanks for the feedback! We'll take a close look into this in the upcoming two weeks.
cc @chri-roch12

Just pinging, agree with OP

Is this coming anytime soon?

This is still in our backlog has unfortunately not yet been prioritized, so I don't have a date for when this would be available, although we welcome any contributions in that regard.


training decoder

Did you start with 5e-4 leraning rate for training decoder?

Yes, that is correct.


LG-6485: Update line height value for accordion component

Why: To improve readability when the accordion heading spans multiple lines of text.
Live preview: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-lg-6485-accordion-line-height/components/accordions/
Screenshots:

Before
After

@aduth After testing across browsers and widths, I think a slight increase is okay. Are you okay with it, too? Particularly if/when this is in effect with the IdP.

@aduth After testing across browsers and widths, I think a slight increase is okay. Are you okay with it, too? Particularly if/when this is in effect with the IdP.

I think it'd be fine too.
Only other thing worth pointing out is I discovered USWDS does define some explicit line-height for the banner text ("Official website...") equivalent to 1.2, and previously the accordion button's line-height didn't matter so much since it was smaller and the text + button were vertically centered. We could opt to style the banner accordion button to 1.2 to bring them back in sync?

Given the USWDS discovery, this makes sense. 👍🏼

Cool, I think so too 👍  Updated in 812f87a.

Just inspected the latest built. Looking good.

Current visual regression build failure looks more expected now, limited to just the accordions themselves:


Add Redshift support

There is a patched version of Redshift here. Eventually, this may make it to the upstream package, but for now that's guaranteed to work on window managers that implement this protocol.
No Wayland protocols have been added to Way Cooler yet, there might be a nice way to set it up so that later ones can be added very easily. This crate will have to be used (C-bindings, can't use their wrappers)

Need #144 module first


appbar color not uniform across whole bar is that to be expected or should it be one color?

Curious,
Shouldn't the color on the app bar be uniform across the whole bar?

It was uniform before 1.1.0:

If You have ST build < 3106 you have to restart ST after theme/preferences changes


hey Erik, remember me?

we were internet buddies way back - you kind of kickstarted my tech career - would love to connect<EMAIL_ADDRESS>

HIP HOP MARIO CLUB FOR LIFE