FromCacheAsync not async all the way through

First of all: sorry for all the issues and comments lately. Been thoroughly checking EFPlus out to see if we can incorporate it into our projects.
I checked out the FromCache async extension methods (on EF6 net462), and I noticed two things:

The cache call is wrapped in Task.Run, so the result is not retrieved async.
This can be expected, because in netfull ObjectCache is used, which does have async overloads. And the only equivalent that does have async overloads is IDistributedCache, which is .NET Core only. Sadly this would make it impossible to implement, for example, Redis in an async way.
If the cache hit misses, the actual database call is also not async (Example: ToList() is used instead of ToListAsync().

Am I correct here, or missing something? If I'm correct you can see this issue as a feature request. 😀

Hello @nphmuller ,
Firstly, don't be sorry for opening issues ;)
I believe you are partially right, but we will explain why we did it this way.
Task.Run
Using Task.Run make the code to run asynchronously. A task is created, and the main thread continues the job while the task is trying to retrieve the result in another thread.
Using Task.Run is similar to using an async method. So yes, the code retrieve the result asynchronously.
ToList vs ToListAsync
We did it on purpose. Async may look cool, but it also comes with some issue which can severely impact the application performance.
Since the call is using inside a Task.Run, that make the ToList method to run asynchronously but without having to use ToListAsync() which can cause performance issue.
It doesn't matter if "Async" method are called or not, as long as the method is invoked in another thread (using Task.Run) to make it asynchronously.
Here is why we don't want to use ToListAsync:
http://stackoverflow.com/questions/28543293/entity-framework-async-operation-takes-ten-times-as-long-to-complete/28619983#28619983
Let me know if I answered correctly to your both questions.
Best Regards,
Jonathan

Sure, the calls will still be ran in another thread, and that's really handy for a frontend application (freeing up the gui thread). For a backend application however it does not really matter if the call is executed on thread 1 or thread 2. The depletion of the threadpool is way more important.
If I understand it correctly, Task.Run still uses a thread on the threadpool, but just another one. This has basically no benefit and only adds to overhead of creating the task objects and running the function on another thread. If used correctly (via ToListAsync or GetKeyAsync) the call would free up the threadpool, until the database or redis is ready and then use another thread (could be the same or a different one) to return the result. This is the true benefit of async/await, IMO. And, for me, it  is a more important benefit than the downside of a small overhead.
Another benefit is that EF supports cancellation, which is also great for performance, since you can stop a call halfway-through if it turns out the client does not want the result anymore.
The link on performance you mentioned is an edge case in where data types are returned from the database that are pretty big (images, huge texts, etc). (At least, if I understand it correctly) Normally async's overhead is actually pretty small (en it can even be faster than sync on some insert or update queries).
See this link for the comments of EF's team on the issue. And this link for a performance test with smaller amounts of data (varchar(256), int).
And in the edge cases where there's this perfomance issue, the developer can choose to use the sync version of the call. I think it's only confusing if the async version actually behaves like the sync version under the hood.
Taking these point in account, do the async cache extension methods actually add any benefit for a backend application? It looks like I could just use the sync methods. Or, if I really want async all-the-way, retrieve my own results and add them to the cache with QueryCacheManager.Add, etc.
By the way, I'm not hating on your library. Again: it's looking great and could save me a LOT of time. Just trying to understand it correctly and to get it as best as possible. :)

I wish asynchronous was easier to understand and explain.
I will re-read your post later today and make sure before answering you.
Meanwhile, here is a small example why I did it this way. I believe Async method (from some Microsoft method, not your) have so much overhead that's not worth using them and Task.Run give better performance.
Here is the result from the code below when using with VARCHAR(MAX) on 6000 entities
-ToList(): 97
-ToListAsync(): 1064
-Task.Run + ToList(): 88

ToList and Task.Run take essentially the same time. It's random which one will be the faster!

Here is the result from the code below (small modification) when using with VARCHAR(50) and 50 characters on 6000 entities

ToList(): 28
ToListAsync(): 45
Task.Run + ToList(): 17

I may have done a mistake, but it seems ToListAsync is already the worse method to use and become worse as the packet size growth.
The problem is NVARCHAR(MAX) is used by default for Code First user, and generally a table contains multiples columns, not only an Id and an NVARCHAR columns.
I will make more test but it seems the Task.Run overhead is way better/faster than using ToListAsync
using System;
using System.Collections.Generic;
using System.Data.Entity;
using System.Diagnostics;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace Z.EntityFramework.Plus.Lab
{
    public partial class Form_Request_Async : Form
    {
        public Form_Request_Async()
        {
            InitializeComponent();
            button1_Click(null, null);
        }

        private void button1_Click(object sender, EventArgs e)
        {
            var clock1 = new Stopwatch();
            var clock2 = new Stopwatch();
            var clock3 = new Stopwatch();

            // CLEAN
            using (var ctx = new EntityContext())
            {
                ctx.EntitySimples.RemoveRange(ctx.EntitySimples);
                ctx.BulkSaveChanges();
            }

            // SEED
            using (var ctx = new EntityContext())
            {
                var list = new List<EntitySimple>();

                for (var i = 0; i < 6000; i++)
                {
                    // list.Add(new EntitySimple() {Test = new string('z', 50) }); // Async method take twice the time even with a varchar(50) columns
                    list.Add(new EntitySimple {Test = new string('z', i)}); // Async method take more than ten the times of non async method or Task.Run
                }

                ctx.EntitySimples.AddRange(list);
                ctx.BulkSaveChanges();
            }

            // TEST
            using (var ctx = new EntityContext())
            {
                // JIT Compile everything...
                {
                    var list = ctx.EntitySimples.ToList();
                    var list2 = ctx.EntitySimples.ToListAsync().Result;
                    var list3 = Task.Run(() => ctx.EntitySimples.ToList()).Result;
                }

                {
                    clock1.Start();
                    var list = ctx.EntitySimples.ToList();
                    clock1.Stop();

                    clock2.Start();
                    var list2 = ctx.EntitySimples.ToListAsync().Result;
                    clock2.Stop();

                    clock3.Start();
                    var list3 = Task.Run(() => ctx.EntitySimples.ToList()).Result;
                    clock3.Stop();
                }
            }

            StringBuilder sb = new StringBuilder();

            sb.AppendLine("ToList(): " + clock1.ElapsedMilliseconds);
            sb.AppendLine("ToListAsync(): " + clock2.ElapsedMilliseconds);
            sb.AppendLine("Task.Run + ToList(): " + clock3.ElapsedMilliseconds);

            this.richTextBox1.Text = sb.ToString();
        }

        public class EntityContext : DbContext
        {
            public EntityContext() : base("CodeFirstEntities")
            {
            }

            public DbSet<EntitySimple> EntitySimples { get; set; }

            protected override void OnModelCreating(DbModelBuilder modelBuilder)
            {
                modelBuilder.Types().Configure(x => x.ToTable(GetType().DeclaringType != null ? GetType().DeclaringType.FullName.Replace(".", "_") + "_" + x.ClrType.Name : ""));

                base.OnModelCreating(modelBuilder);
            }
        }

        public class EntitySimple
        {
            public int Id { get; set; }
            public string Test { get; set; }
        }
    }
}

ToList and Task.Run take essentially the same time. It's random which one will be the faster!

That's because Task.Run is the same as ToList. It executes the same call. Wrapping it in Task.Run has basically no additional benefits (from a backend perspective), and actually introduces some efficiency problems. (see the 2nd link)
My suggestion at this point would be this:
-Offer sync methods, which you're already doing.
-Offer async methods, if they are truly async. Or don't offer them at all.
The async methods currently are only confusing for the user, because they imply it's truly async, while it's actually not. Leave the choice for picking the more efficient way (sync vs async) to the user, because there are cases where the async way has some big benefits. (like the threadpool, which doesn't deplete as quick, which I mentioned previously)
These might be some interesting reads:

Unfortunately, this is a misuse of Task.Run. The problem is that it’s not truly asynchronous.
And when we do testing, it works! Unfortunately, this change introduced a performance problem.

PS: If you're looking at (at least for me) more daily use cases, you don't usually retrieve 6000 records at once. When you're only returning a few records, the difference in execution time is (imo) negligible.
Thanks for looking into it! :)

Thank you for your link.
I will for sure read them. I just need to convince myself and make sure I understand correctly the difference and why I should always use async task over Task.Run.
Btw, this may not be your case but most applications I have seen, developers I have talked, stack overflow questions I have answered often use way more than 6000 records for the caching. But hey! They were already using ToListAsync before, so they will not really be penalized anyway
Well, I guess I have some reading to do now ;)

I meant retrieving 6000 records at once, btw. Not caching 6000 records (which should be a lot more common). But you're right. I shouldn't assume my use case is the main use case. ;)
Looking forwards to your conclusions!

I have read a lot about async vs. Task.Run, I still want to read some more, but so far, I agree with you.
I believe Task.Run is sometimes fine when too much complexity is involved. By example, Entity Framework Extensions also use Task.Run for BulkInsertAsync. Making all the code truly async is way too more complex. It works, but not optimized for the thread pool.
Even more, using truly async method often introduce some UI deadlock because one method with await miss the call to ConfigureAwait(false).
However, for simple functionality, like EF+ Query Cache, I agree with you. If a truly async method is already coded and the code will stay simple, better to use it!
That still bug me:
If I use ToListAsync method, the thread pool will be better managed. But some query may take 10x the times to execute... So have we really improved or decreased the thread management since a thread will take more time to be completed?

Async method can be faster than sync method

http://www.thereformedprogrammer.net/analysis-of-entity-framework-6-async-performance/
Be careful when reading posts with benchmark test. Like you know, the code often contains many major mistakes.
Using the same code as him, I can prove that my:

sync method is faster than my sync method…
async method is faster than my async method…

Only by calling the same method twice! The test didn’t take into consideration JIT Compilation, QueryCacheManager and other optimization done by Entity Framework. So obviously, sync method called first was penalized versus async method called last!
At the end, it makes no senses an async method go faster than the sync method. Unless the sync method is poorly coded since async method can only add some overhead!
With the same code as him, calling the same method twice I dramatically "improved" the performance:
EF, with 10 in database -----------------------
Ran List all, Ef Direct: total time = 18 ms (1.8 ms per action)
Ran List all, Ef Dto: total time = 188 ms (18.8 ms per action)
Ran Create, Ef Direct: total time = 25 ms (2.5 ms per action)
Ran Update, Ef Direct: total time = 124 ms (12.4 ms per action)
Ran Delete, Ef Direct: total time = 23 ms (2.3 ms per action)

EF, with 10 in database -----------------------
Ran List all, Ef Direct: total time = 2 ms (0.2 ms per action)
Ran List all, Ef Dto: total time = 10 ms (1.0 ms per action)
Ran Create, Ef Direct: total time = 19 ms (1.9 ms per action)
Ran Update, Ef Direct: total time = 28 ms (2.8 ms per action)
Ran Delete, Ef Direct: total time = 15 ms (1.5 ms per action)

Hello @nphmuller ,
As you suggested, we modified the code for EF6 and EFCore to use async method instead. EF5 doesn't have async method, so we keep using Task.Run
The v1.4.17 has been released.
We will try to check other features as well when time permit.
Best Regards,
Jonathan

Yeah, you can close it.
Thanks for the effort! ;)

Closing Comment: Confirmed!


Ffi poc

This PR demos a possible simple implementation of an FFI, by exposing a new evaluator constructor method that allows users to provide their own SDK-like function bindings.

Is this still needed? Otherwise let's close

Is this still needed? Otherwise let's close

I'm fine with closing it, tho it may be useful for reference as the functionality in question still hasn't been implemented elsewise

Is this still needed? Otherwise let's close

I'm fine with closing it, tho it may be useful for reference as the functionality in question still hasn't been implemented elsewise

I'd like to try to keep the prs list cleaner. What if you opened a github discussion on a FFI implementation instead? Then you can link your branch.

Sure, added an issue, feel free to wipe this


Why doesn't the rollupOptions support arrays？

Description
{
build: {
rollupOptions: {}
}
}
Why doesn't the rollupOptions support arrays？
Suggested solution
{
build: {
rollupOptions: []
}
}
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Why is array needed for? The current rollupOptions of Vite are completely consistent with what Rollup itself can accept.

?Because I saw someone use it, export an array rollup.config.js, or some people are wrong?

Why is array needed for? The current rollupOptions of Vite are completely consistent with what Rollup itself can accept.

Why is array needed for? The current rollupOptions of Vite are completely consistent with what Rollup itself can accept.

@fi3ework

closing as not an invalid question.


Added versions to all available packages that actually had releases.

Cross your fingers and hope this fixes the CI build.

How did the build go on your system with this?

This problem has already been addressed.


Feature/asset packager

I was recently tasked with moving a fair bit of content (and the associated assets) from Server A to Server B and was unhappy with the bulk packages necessary to do so. I came up with a tool to iterate over properties and generate a package filter I could then use to create a content package and move the content without needing to resort to larger packages. I figured it could be of use to other people so the ACS AEM Commons would be a great place for it to live - especially considering the other content packagers already present in it. Note: also really handy for porting subsections of content and assets to a local instance when trying to resolve issues present on a remote server. It saves time and space on your machine to just bring what is needed!
Example Task:
Move /content/we-retail/en/subsection and the associated assets to a new server.
Current way to do so:
Package up /content/we-retail/en/subsection and /content/dam/we-retail (since you can't know what was used you usually resort to bringing more than necessary).
New way:
Create a content packager definition providing the page path "/content/we-retail/en/subsection", define any restrictions wanted on either the pages or assets packaged, and create the package!
Note: This is my first ACS AEM Commons contribution so I'm not positive if I did everything correctly - happy to amend anything necessary!

Pull Request Test Coverage Report for Build 4037

68 of 83 (81.93%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 49.627%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bundle/src/main/java/com/adobe/acs/commons/packaging/impl/AssetPackagerServletImpl.java
68
83
81.93%

Totals

Change from base Build 4030:
0.3%

Covered Lines:
11989

Relevant Lines:
24158

💛  - Coveralls

@davidjgonzalez @badvision are you okay with me reviewing this?  Or should I avoid reviewing/merging PRs from my own colleagues?

@hitmaninwis as long as you weren’t super involved in writing it (ie dev bias) - then review away!  We trust you will review all code equally, regardless of the author! :)

I think that @HitmanInWis has proven his commitment to quality and substance time and time again.  No complaints from me.

Also be sure @id-keenan to submit a documentation update PR to https://github.com/Adobe-Consulting-Services/adobe-consulting-services.github.io to go along with this new feature.  LMK if you need a hand getting set up locally.

With the cut of v4.1.0 today, please be sure to merge latest master and update the CHANGELOG.md file accordingly to move this feature to the next release.

@HitmanInWis The PR updates have been made, feel free to take a second pass!

@HitmanInWis updated to remove duplicates. I added a Collections.reverse call on the translated Set object to keep the page path entry at the top - I feel like that's more author friendly than having it at the bottom of a potentially giant list. Probably unimportant but I liked it at the top as opposed to the bottom :)


Is there any plan for Pytorch-DML as well?

Hi, Thanks a lot once again for this.
I wonder if you have any plans to have a pytorch port of DML as well? knowing that Microsoft joined as the mainainers of Pytorch on windows since version 1.6.
Any feedback on this is greatly apprecaited.

Thanks @Coderx7 for your feedback. We're looking closely at how best to serve the PyTorch community with DirectML. Would love to know more about your PyTorch use case and expectation!

Thanks a lot for the quick response.
Currently Pytorch is very limited in terms of diverse hardware support for training and inference. All that's supported is either NVIDIA GPUs with compute capability 5.0+ and AMD GPUs through Rocm which doesn't take into account the AMDs integrated graphics and many older gpus.
They once started to work on TVM, but left it for good, the support for Intel OneDNN/OneAPI has also been stagnant for some time now, it was supposed to  add support for a wider range of GPUs specifically Intel's integrated GPUs ranging from 4th Gen up to now. but none of these are actually implemented so far.
As you can see, The DML project can have an immense impact on the Pytorch community specially on Windows and specially for productions.
Something like tensorflow-directml, can definitely be a great addition, as it allows for both training and inference on GPUs regardless of the vendors. Lots of Nvidia, AMD, Intel GPUs can now be utilized to their full extends and the possibilities are just huge.
For inference, we have had Onnx, TVM and openvino for sometime now, although they rely on many providers, they are not currently a viable solution as there are many bugs/inconsistency so far.
but being able to actually utilize GPU for training is just something completely different.
I have installed tensorflow-directml and I was blown away, Just imagining the same opportunely for Pytorch just excites me beyond measure! and I'm 100% i'm not alone!

To add to these comments, I have had much less friction using PyTorch on Windows compared to TensorFlow. I much prefer using PyTorch for this (and other) reasons, and having cross-hardware support via DirectML would improve its versatility and usefulness even further.

It's been a while since we're waiting for pytorch on direct-ml.
Any update?
Aren't pytorch on direct-ml coming anytime soon?

@wchao1115 Is there any update concerning this? This has been nearly a year ago, so any (hopefully good ) news is really appreciated


Feature Request - Fabric Support for Minecraft

Feature Request
Fabric is a newer lightweight modding API for Minecraft.   Adding official support for Fabric into AMP would make remote management of Fabric modded Minecraft servers significantly easier.
Fabric Webpage:  https://fabricmc.net/
Fabric Wiki: https://fabricmc.net/wiki/start
Install instructions for the Minecraft/Fabric server instance:  https://fabricmc.net/wiki/tutorial:installing_minecraft_fabric_server
Feature Information:

What should it do?  Install and Run Fabric modded Minecraft servers.
Is it specific to a given application module?   Minecraft Module

I confirm:

[x] that I have searched for an existing feature request matching the description.

I do want to add I managed to get Fabric working in AMP.    I had to run the Fabric installer outside of AMP on a copy of the Minecraft server.   Then I just copied everything back and selected the fabric-server-launch.jar as the Server jar.     Started up without issue.     Granted it would be great if this process was automated.

Closing as I just realized this is a duplicate of #179. Please see that issue for further information on this.


Bug: Protocol tests added in Smithy 1.46.0 do not pass

Describe the bug
S3 URI resolution behavior when dealing with object keys that contain dot segments is incorrect (https://github.com/smithy-lang/smithy/pull/2166)
Expected Behavior
All S3 protocol tests should pass
Current Behavior
Tests do not pass
Reproduction Steps
Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel]' started.
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:99: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel] : failed - actual query items in Endpoint is nil but expected are not
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:99: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel] : XCTAssertEqual failed: ("foo/../key.txt") is not equal to ("/mybucket/foo/../key.txt")
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:99: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel] : XCTAssertEqual failed: ("mybucket.s3.us-west-2.amazonaws.com") is not equal to ("s3.us-west-2.amazonaws.com")
Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesEmbeddedDotSegmentInUriLabel]' failed (0.294 seconds).
Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel]' started.
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:50: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel] : failed - actual query items in Endpoint is nil but expected are not
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:50: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel] : XCTAssertEqual failed: ("/../key.txt") is not equal to ("/mybucket/../key.txt")
/Users/dayaffe/Documents/Development/SwiftSDKWorkspace/UpdateSmithy/aws-sdk-swift/codegen/protocol-test-codegen/build/smithyprojections/protocol-test-codegen/s3/swift-codegen/S3TestSDKTests/GetObjectRequestTest.swift:50: error: -[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel] : XCTAssertEqual failed: ("mybucket.s3.us-west-2.amazonaws.com") is not equal to ("s3.us-west-2.amazonaws.com")
Test Case '-[S3TestSDKTests.GetObjectRequestTest testS3PreservesLeadingDotSegmentInUriLabel]' failed (0.002 seconds).
Test Suite 'GetObjectRequestTest' failed at 2024-04-02 17:11:24.558.
	 Executed 2 tests, with 6 failures (0 unexpected) in 0.296 (0.296) seconds

Possible Solution
No response
Additional Information/Context
No response
AWS SWIFT SDK version used
latest
Compiler and Version used
latest
Operating System and version
mac

We have decided to disable the 2 tests in question in order to proceed with the upgrade. The tests are failing because we have a placeholder for endpoint resolution used only for protocol tests, not because of an actual failure. Go v2 and typescript SDKs also do not currently run these tests.

The 2 tests disabled here were moved to different location and are now run correctly. Refer to https://github.com/awslabs/aws-sdk-swift/pull/1590 to details.


Detection sensitivity is very low when no indicators are present

GitGuardian Shield Version
2.72.0

[X] I can reproduce this bug in the latest version

Command executed
Simply add a txt file with a fake AWS key (found on Google) with
AKIAJIPU77TQL5LB6OIB
8Mw77pe6Ua9wr56f6lr069rDPTDWeUvV0q6ZS+6N

Then
ggshield scan -v --all-policies path lol.txt
This won't find anything...
Try the same, with a few pointers:
key=AKIAJIPU77TQL5LB6OIB
secret=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

And this will work.
Describe the bug
There really seems to be a problem in the sensitivity system, ggshield definitely isn't built with a "clues" system that adds weight depending on the findings it has.
An AWS key should always get caught no matter the prefix, especially if the pair key+secret is in the same file imo.
Expected behavior
ggshield should flag secrets without needing pointers for "password" or "key", especially for such common use cases like AWS keys.
Screenshots
If applicable, add screenshots to help explain your problem.
Traceback (if available)
Add any other context about the problem here.

Hi @Gby56,
We had a look at the example you submitted, thanks for opening this issue.
The engine does not raise an alert indeed. Yet, your explanation is not exactly right. The case you described happens because we apply a validation on the context of the secret to verify the secret is not made of some random text that happens to match AWS Keys pattern. If you were to include any characters, as long as it includes non text characters, in the close context of the secret then an alert would be raised. For instance :
a = b
AKIAJIPU77TQL5LB6OIB
8Mw77pe6Ua9wr56f6lr069rDPTDWeUvV0q6ZS+6N

We are looking into improving this. I'll keep you updated as soon as we have results on this topic.

Got it ! I understand yes, we had a few people playing with it internally and were surprised to see it not triggered.
I would expect that a random string that fits exactly an AWS key, exact length, on a single line, that would trigger an alert 🤔
Maybe the tool could flag things and suggest a way to ignore the finding in the cli output, so even if it's a false positive it's not too noisy ?


[Bug] Setting up config flow with NGINX SSL proxy results in 504 error

Bug ??
When setting up the integration in a new environment, the configuration flow cannot start and it shows the following error on frontend:
Impossibile caricare il flusso di configurazione:  <title>504 Gateway Time-out</title>
504 Gateway Time-out

nginx
I was not able to figure out why, but it happens in environments where there is a NGINX SSL proxy and with the following configuration:
http:
 use_x_forwarded_for: true
 trusted_proxies:
   - <IP_ADDRESS>/24
If I remove these lines from configuration file, then the config flow works correctly. If I try to start a new config flow after setting up the first one, it work too, even if there is the above configuration.
What version of the integration are you using?
miele-0.1.4
Anything in the logs that might be useful for us?
No response
Additional information
No response

This is odd...
I am running all my instances of HA behind a haproxy reverse proxy service in my routers. The proxy is taking care of the SSL processing.  I have the same  http: setup as you have., except that trusted_proxies specifically points to the gateway (e.g. <IP_ADDRESS>)
Is the 504 error generated by your reverse proxy?
Is your problem specific to the miele integration?
I cannot really see that we handle http requests differently when setting up the config flow than we do during normal operation.

I don't know who is generating the 504 error and neither which is the URL that is generating that error.
However it's specific to the Miele integration.

I cannot really see that we handle http requests differently when setting up the config flow than we do during normal operation.

Exactly the same...
I'll try to investigate

I've just installed this integration and just get a spinning circle when trying to configure it - Im accessing my home assistant via Nabu Casa (https://xxxxxxxxxx.ui.nabu.casa/) which I guess is a reverse proxy of sorts.
I'm not currently on my local LAN so can test further later on, but I suspect this might be the same issue?

@bradleykite
This is the first report that there is a problem with setup through Nabu Casa. Please try to set up the integration from LAN.

Hi, OK I've been able to test a little more.
On clicking on "Add Integration" and then selecting "Miele", the UI just displays "Please wait, starting configuration wizard for Miele" - the pending request is a POST for /api/config/config_entries/flow

The POST data is:   {"handler":"miele","show_advanced_options":true}
After waiting 21 mins, the browser closed the TLS connection and the UI never allows the integration to be configured.

I'm going directly to the Home Assistant IP - no reverse proxy or Nabu Casa.
At the same time, the main hassio log file displays essentially that it detected the browser close the TLS connection
2023-01-10 16:28:19.932 ERROR (MainThread) [homeassistant] Error doing job: protocol.resume_writing() failed
Traceback (most recent call last):
File "/usr/local/lib/python3.10/asyncio/transports.py", line 300, in _maybe_resume_protocol
self._protocol.resume_writing()
File "/usr/local/lib/python3.10/asyncio/sslproto.py", line 522, in resume_writing
self._app_protocol.resume_writing()
File "/usr/local/lib/python3.10/site-packages/aiohttp/base_protocol.py", line 31, in resume_writing
assert self._paused
AssertionError
Not sure what else I can provide to help troubleshoot this?

@bradleykite Moving your issue to separate issue #198

Hi,
I've experienced the same issue with another custom integration. It looks like to be a common problem with NGINX ssl proxy and Let's encrypt certificate.
As a workaround I was able to start config flow by using the local IP address of the Pi with HA installed.
https://community.home-assistant.io/t/504-gateway-time-out-during-update/171010
I think that we could close this issue, as it is not related to this integration.
Thanks
Andrea

Hey there,
I try to setup my Miele washing machine. Unfortunately, I run into the same timeout error when using my Nginx SSL proxy. When accessing the HA instance directly without SSL proxy inbetween, I just get the loading without any changes even after minutes of waiting. I'm using a totally fresh install of the HAOS.
Is there anything I can try/set to acquire more information about what's going on?
Thanks!
David

Hey again, guess I found the problem. I have a native IPv6 internet access and distribute a public IPv6 address to each device in my network. After disabling DHCPv6 for my network interface of the HAOS, I'm able to setup the integration successfully.
So, I guess there might be some problem with accessing the Miele cloud over IPv6 here.

I encountered the same issue as the original reporter, and fixed it disabling in configuration.yaml:
#http:
#  use_x_forwarded_for: true
#  trusted_proxies:
#    - <IP_ADDRESS>
#    - <IP_ADDRESS>
#    - <IP_ADDRESS>

Unfortunately, the disabling IPv6 trick did not have any impact.
Now I had to revert the http in the configuration.yaml, hope it won't break the integration.

Stale issue - closing


Content-Length header is ignored in web.Response constructor

Long story short
Header Content-Length is ignored in web.Response constructor.
It is set to 0 when body parameter is not passed to constructor.
Expected behaviour
Either to get warning like "you header was ignored" or to have it not ignored.
Actual behaviour
Header value is silently updated.
Steps to reproduce
>>> headers = {'Content-Length':555}
>>> r = web.Response(headers=headers)
>>> r.headers
<CIMultiDict('Content-Type': 'application/octet-stream', 'Content-Length': '0')>

Your environment
aiohttp (1.1.3)
Python 3.5.2 (v3.5.2:4def2a2901a5, Jun 25 2016, 22:18:55) [MSC v.1900 64 bit (AMD64)] on win32
Win10

What is use case for providing Content-Length without BODY?

Respond to HEAD request.
The HEAD method is identical to GET except that the server MUST NOT return a message-body in the response.

Good point, thank for report.


Convert homepage from CMS driven to CI template

From @leonstafford on June 12, 2017 4:8
Background
Current way some pages's templates come from the CMS is less than ideal. Only developers have been the ones to update these pages, so easier to maintain as regular templates.
Acceptance criteria

[ ] homepage renders as it does currently on production

Dependencies
*code snippets from DB for the elements currently being fetched from it (top section, main content)
Copied from original issue: sleepbusorg/sleepbus_org#23

fixed by https://github.com/sleepbusorg/sleepbus.org/commit/26268401c162b4d9bb270f03f4117b6ce5389254


Card - In mweb and hybrid app, display of virtual card number &amount behavior is inconsistent

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9. 0.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Issue reported by: Applause - Internal Team
Action Performed:

Launch app in both mweb and hybrid app
Tap profile icon -- more features
Enable expensify cards
Tap + issue card - select an user - virtual card-next
Enter maximum 8 digit amount
Tap next
Enter a card name and tap next
Tap issue card

Expected Result:
In mweb and hybrid app, virtual card number and amount behavior must be consistent
Actual Result:
In mweb, virtual card number and amount box overlapped. In Android hybrid app, amount is shown as truncated
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/0479b77b-20eb-44bb-87d7-e7ad543327e2
https://github.com/user-attachments/assets/e06f6027-3780-4098-94a0-d921aaf576f8
View all open jobs on GitHub

@mallenexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Will get to this soon

Gonna close this cuz I don't think anyone's going to be issuing an $88MM limit on a card

But... before closing.. @daledah since you already did some research here, any reason I shouldn't close? Are there other instances where this overlap shows that's not millions of 💵 ?

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Off the next week then will revisit this

Thanks @daledah .  I'm back from OOO, bumped to Daily so I can get to this this week.

Still behind, will get to soon :/

Labeling Not a priority and closing. I don't think it's valuable enough to justify more internal investment, espec from design and engineering folks.


Multiple series: select the point (no drag) - tooltip jumps back and forth between points

This is continuation of #43
Example: http://jsfiddle.net/kdragon/xdwuup4j/
Steps:

click (no drag) the black diamond in the middle
tooltip and selection jump back and forth between series (the blue dot below clicked point)

You can also see it on mouse up after the drag.

i'm really hoping this can be fixed soon. we have code in production that has been effected weeks by this
Thanks
Keith

Sorry for the delay, Easter and all... It is fixed now, as seen in http://jsfiddle.net/kdragon/xdwuup4j/.

Hi Torstein,
after applying the change or running the fiddle:  http://jsfiddle.net/kdragon/xdwuup4j/. i'm still seeing the same issue.
same instructions:

click (no drag) the black diamond in the middle
tooltip and selection jump back and forth between series (the blue dot below clicked point)

i see this behavior for any point i click, black or blue
Thanks
Keith

Oh, sorry about that, I was sure I had it working, but I can also see this now. I'll check it out.

Now it works as far as I can see: http://jsfiddle.net/highcharts/xdwuup4j/1/

Problem is still visible on Win7/Chrome - after click, tooltip jumps to another series.

i confirm that this is still an issue

Ok, this turned out to be a touch one. Please try now: http://jsfiddle.net/highcharts/xdwuup4j/2/

The problem is resolved on Win7/Chrome :+1:


initial commit for application tracing using opentelemetry

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Sachin Narang:x: Sachin4403Sachin Narang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


adding impConsPurposes

Included in https://github.com/IABTechLab/iabgpp-es/pull/58 so closing this PR.


Added failure handling capabilities to run.sh

Added logic in run.sh to handle failures from exports/source statements.
Added more formatting to run.sh
Added an integration test to validate contents of the dynamically generated run.sh with a static expected run.sh based on OS
Made logic of archiving a job non optional
Job Completion Handler no longer throws any exceptions as it runs in an asynchronous manner. Added TODOs in the the class to add metrics instead which we would eventually need to set alerts or maybe dynamically mark the node as unhealthy.

Coverage increased (+0.1%) to 93.09% when pulling 914b35464903330d42980bdd5c57710ded1af166 on amitsharma1981:develop into 2433f6d2a8dc6bf79ae077033257d36d6bb9d93e on Netflix:develop.


bin folder creation

Using RENEE's template, create a bin folder for XAVIER
redirect script loads required modules and conda environments
redirect works on both BIOWULF and FRCE

fixed with #24


Check for tscon Before Processing TeamSpeak Users

Basic check to abort if $tscon is null

:tada: This PR is included in version 6.15.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Institute of Applied Technology

@beba4434 Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@beba4434 You might miss my previous comment. Please react.

https://www.iat.ac.ae
8 16 A St - Al Qusais Industrial Area - Al Qusais Industrial Area 2 - Dubai, United Arabic Emirates
https://www.iat.ac.ae/component/simplefilemanager?task=download&id=59 (Page 46)
https://www.iat.ac.ae/schools/admission/contact-us

@philipto philipto

@philipto

@beba4434 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Can we add PSSessionOptions to the PowerShellJob.ps1 / Invoke-PsOnRemote

I would like to be able to pass session options like SkipRevocationCheck and change the OperationTimeout.  Not sure if it is possible to use one of the other parameters to accomplish this.  When I have tried to add -UseSSL or -SessionOption (New-PSSessionOption -NoEncryption -NoCompression -SkipRevocationCheck) that would normally be on Invoke-Command in the scriptArguments  I think the Invoke-PsOnRemote does not accept the parameter.
Or maybe add a SkipRecocationCheck like the skipCACheckOption

Hi @johnfleenor,
Currently the task does not allow to expose those parameters like SkipRevocationCheck. The task internally add the UseSSL parameter if the WinRM protocol is HTTPS. What is the scenario you would want to SkipRevocation check? You would be better off using HTTP instead of HTTPS in that case, since it would be really insecure to skip revocation check.

The exposing the PSSessionOption would also allow for Operation and Idle timeout.  When a script hangs it takes 3 minutes to timeout by default.  When I make a script call I can't see what it is doing. So I remote the the box and check the powershell logs for event errors then I queue up a build or cancel each of these take time.

@johnfleenor, In our implementation of the task the timeout is much more layered than just the Operation and Idle timeout. We currently do not have plans to expose the PSSessionOptions at the task or the cmdlet layer. Thanks for your feedback, for now if you would like more flexibility in the way your script runs in the remote machine you can consider using the normal PowerShell task and establish a remote session and execute scripts.


User

How to get user Without Pagination From Api...

Hi, @Krishna8077078
use the code below:
ConnectyCube.users.get(userId).then(response => console.log(response.user));
ConnectyCube.users.get({ login: 'some_login' }).then(response => console.log(response.user));
ConnectyCube.users.get({ email<EMAIL_ADDRESS>}).then(response => console.log(response.user));

I think u can't get it what i am trying to say...means is--how to retrieve users from API as without pagination..and is there any other way to filter use via a phonebook contact list.

You will receive response with one user w/o pagination if you would use the code I have provided before (see full possible parameters in our docs).
You also are able to get users by filters - ConnectyCube.users.get(filter).
Check the Adressbook API to get phone's contacts - https://developers.connectycube.com/server/users?id=retrieve-all-users
I did not understand your case. What is wrong with the pagination?


Refactoring complex methods of classes XMLSchedulingDataProcessor and JobRunShell

Related to no particular issue. This is a behavior-preserving refactoring.
Summary of this pull request:
•	We are evaluating a research prototype called Bandago that assists in the refactoring of complex methods. Bandago is an Eclipse plugin that automatically identifies and refactors a type of code smell called Brain Method. A Brain Method centralizes the intelligence of a class and manifests itself as a long and complex method that is difficult to understand and maintain We have applied Bandago to 2 complex methods of your project, and we would like to receive feedback.
•	Bandago is very conservative and you should not observe many source code changes (only in the affected class).
•	The source code (after the refactoring) should behave equivalently to the original one.
•	As a sanity check, we have run tests before and after Bandago performed the refactoring(s) on the project. All tests passed.
•	The goal of the refactorings applied is to improve the legibility of the refactored method.
•	In this case, Bandago refactored the method XMLSchedulingDataProcessor.process extracting fragments of its code into the new methods initSchedule, updateTriggerDataMap, triggerMisfireInstruction, parseJobDefinitions, parseTriggerDefinitions, checkIgnoreDuplicates, checkOverWriteExistingData, parseTriggersToDelete, parseJobsToDelete, parseTriggersGroupToDelete and parseJobGroupsToDelete. Also, the method JobRunShell.run() was refactored extracting fragments of its code into the new methods executeJob, updateTrigger, reExecuteJob, and treatVetoedExeption.
Thanks in advance for your help in this evaluation!

Hi, thank you for the PR. We typically do not take refactoring for no particular reason. We will close this PR as invalid unless it can be proven that it improves performance or fix a defect.


Create feature_request

I'm new to Git Hub, and I'm an artist, not a programmer. I hope this is an appropriate way to pass a note to the project creator for him or her to consider a feature request!

Hello!
Don't worry, I'm not much more experienced with GitHub than you are :)
(I think the more traditional route for requests is to open a new thing under the Issues tab and tag it with Enhancement.)
The good news is that with this firmware and library it is already possible to send a rapid sequence of images to the badge. You could basically play back video. There isn't much storage on the device, so this will require it to be plugged into a computer, currently.
Are you wanting these to loop after being disconnected? There is a tiny bit of storage off chip that isn't currently being used, and perhaps it could play from that.

(moving conversation over to #8)


JOSS final read & proof

[ ] final proof for typos, etc.
[ ] release version 0.4.1

for archive make sure (see comment here)

[ ] "The title of the archive is the same as the JOSS paper title"
[ ] "That the authors of the archive are the same as the JOSS paper authors"

xref openjournals/joss-reviews3330


Calling methods on resources with arg list throws error

If you call the methods on resources:
get()
post()
put()
remove()
with a list of arguments, e.g.:
db.resources.get('testService', {a: 1, b: 2})
  .result(function(response){
    console.log(JSON.stringify(response, null, 2));
  });

an error is thrown:
Error: no name for executing resource service

When arguments are passed in as a single object, all is OK, e.g.:
db.resources.get({name: 'testService', params: {a: 1, b: 2}})
  .result(function(response){
    console.log(JSON.stringify(response, null, 2));
  });

Isn't that WAI? At least as far as requiring you to use a call obj if you want to pass in params. The error message could certainly be better. :)
That is the usage I documented, at any rate. It's also consistent with the spec from 8.0, which shows this usage:
db.resources.get({name:..., params:{...}, txid:...})

This is pretty typical of the API, IIRC. You have to fallback on a call object once you stray from the bone simple use case.

Thanks for the input, @kcoleman-marklogic. Your example from the spec makes the expected usage very clear to me:
db.resources.get({name:..., params:{...}, txid:...})
This signature from the jsdocs tells me I should do something different:
get(name, params, txid) -> {ResultProvider}
This may be a limitation of jsdocs.
For now, I'm going to push this issue out because for me it speaks to making it clearer across the docs that the call object is the expected usage.
I also see that the issue probably can't be "fixed" as I had thought (i.e., make positional params always possible) because of the mix of optional parameter data types in some of the methods.

FWIW, I think there are some other places where we try to finesse this limitation with the JSDoc through words.
For example, take a look at Documents.remove: http://docs.marklogic.com/jsdoc/documents.html#remove. There, we say "... takes a configuration object with the following named parameters or, as a shortcut, one or more uri strings or an array of uri strings".
Of course, that pre-supposes you understand that "named parameters" means a call object. I have no idea if that's a safe assumption for a Node.js developer or not.
A lot of this could be mitigated by including simple examples of the accepted call forms in the JSDoc. IDK how hard or easy that would be as I'm not very conversant with the markup. Erik got saddled with all that work back at the beginning.

This might be relevant:
http://usejsdoc.org/tags-param.html#parameters-with-properties

Great find! I think that has a lot of potential to address some of the call object confusion. It probably still can't help with the "call object or these shortcuts" problem, but it is certainly worth experimenting with.

Added an explanatory sentence to the JSDoc for each of the resource execution methods.
Given that Data Services endpoints offer a better way to execute code on the server, it's better not to risk destabilizing the implementation by changing the argument parsing.

Should cause no regressions.


Fix docs.rs build.

docs.rs runs offline, so it cannot clone libcubeb. Therefore, do not exclude it from the package.

cc @kinetiknz @padenot

Alternatively, instead of this, we could just stub out libcubeb for the docs.rs build, since it is not necessary to build it for the documentation.

As I think about it, I believe that that might be preferable. With the code here, we run the risk of producing a build without the rust backends. But, if we maintain existing behavior and just stub out the C bindings for docs.rs, we ensure that the rust bulids are always there, and also fix the docs.rs build.


Error when Content-Type header included

Getting

"Response to preflight request doesn't pass access control check: Redirect is not allowed for a preflight request."

when I include any Content-Type or Authorization header. Works when Content-Type and Authorization headers are omitted. Ideas?

It was Brave Browser. I had to unset "Cookies blocked" on localhost.


Tabular: NeuralNetClassifier does not use GPU

I am training the tabular classification model. I have installed the GPU version of MXnet and the latest version of autogluon. However, the training of NeuralNetClassifier is very slow and in most cases runs out of time and skips the model. I checked nvidia-smi and I guess that the model just doesn't use GPU.

Can you try using:
predictor = task.fit(train_data, label=label, ngpus_per_trial=1)?
GPU usage is not enabled by default, it needs to be specified. This functionality will become more clear in the next release as GPU usage is only partially implemented (Neural network and CatBoost use GPU if specified, but the other models don't)

Dear @Innixma thanks for the response,
I was using ngpus_per_trial, but still, the training is very slow and again nvidia-smi doesn't show any GPU usage.

Interesting, thanks for the clarification. I am on vacation next week but will take a look once I return. We are planning to refactor the usage of GPU for v0.1 and I will ensure this is resolved for v0.1.

@ghazaryanartashes  Did you call fit with verbosity=4 and check the NN is actually training in the output logs which should print updates every epoch?
The NN should train on GPU if you've properly installed GPU-version of MXNet, but FYI GPU training is not actually that much faster for this NN as it's a fairly small network. The NN model is expected to train slowly if you have high-dimensional data, in which case you can try specifying smaller hyperparameter values for the NN, or simply removing it from the set of models that are trained in fit() via the excluded_model_types argument.
If you'd like more help, it'll be helpful if can post your code, the output logs from fit(), as well as your OS and the output of pip freeze to show which package versions you're using.

In v0.1 and pre-release, NeuralNet uses the GPU if specified: #896


'self' not allowed to be defined as a variable name when objects are defined

Description:
The following
type Foo object {
    public string name = "";

    function testFunc() {
        self.name = "";
    }
};

string self = "";

fails with
$ ballerina run test.bal
error: .::test.bal:1:1: redeclared symbol 'self'

Affected Versions:
0.990.4-SNAPSHOT

Tested this on the current master and it's working properly. Hence closing this issue.


Positional encoding

Thank you very much for your paper!
Would you mind shedding some light on the positional encoding? I see you add a randomly initialized weight vector and not the Fourier signal as the original Perceiver. Would you please explain the design choice? Isn't that losing all the geometric information of the data?
Thanks!

Hi Dvir,
Thank you for your interest in our paper :)
We used positional encodings exclusively for the latent probes, *not *for
the point clouds in input as to make the model permutation invariant wrt to
shuffling of the said point clouds.
We were not really interested in preserving geometric information ofthe
latent probes since they are randomly initialized parameters anyway, so we
used learnt positional encodings instead of the ones based on fourier.
If you do not care about the model being invariant to permutation, then you
can use the fourier positional encodings.
I hope I cleared your doubts, I am here if you need any further
clarification :)
Have a great evening, Gio
On Sat, Dec 4, 2021 at 8:47 AM Dvir Ginzburg @.***>
wrote:

Thank you very much for your paper!
Would you mind shedding some light on the positional encoding? I see you
add a randomly initialized weight vector and not the Fourier signal as the
original Perceiver. Would you please explain the design choice? Isn't that
losing all the geometric information of the data?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GiovanniTRA/transmatching/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGNYEH6MB6RCPE7CIF3XPDUPHBRPANCNFSM5JLJKL2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Thank you for the thorough answer,
Got it, thanks!


⚠ Bofrost.at has degraded performance

In c9aa5b9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2553 ms

Resolved: Bofrost.at performance has improved in 8ffe859 after 313 days, 2 hours, 39 minutes.


Add accessibility note to interactivity section in the new React docs

We want to add accessibility into the new React Docs. This PR adds a note in the interactivity section letting users know to use the html tag <button> instead of <div> when using onClick handlers.

This overview is really supposed to be a brief 1-minute summary of each page within the section. How about we instead add a note to the "Responding to Events" page at an appropriate place?
I also noticed that the linked page is a little terse and jargony and I'm not sure that it is accessible (ha) to many of our site visitors. I found https://developer.mozilla.org/en-US/docs/Learn/Accessibility/HTML which might be a better introductory resource to link to.

Added to the "Responding to Events" page and updated the link to https://developer.mozilla.org/en-US/docs/Learn/Accessibility/HTML

Looks good. It conveys the right message.


No sc directory

README.md references a sc directory with Python scripts, but no sc directory exists in repository.

DBSeer is now completely re-packaged! Please do a git pull and look at the new documentation! There's also a video demo of DBSeer at http://dbseer.org/video


Add art_bot_dev.py to production image

There are some cases in which the commands are working correctly in local development but doesn't seem to work in production. By adding the file, we can test out the commands using the terminal on Openshift.

Testing in art build dev namespace before merge.


Unity warning: "Rename the assemblies to avoid hard to diagnose issues and crashes."

At least with Unity 2021.2.8f1 on Windows, using the Package Manager to add the MuJoCo Unity package produces the following warning:
“Plugin 'Packages/org.mujoco/mujoco.dll' has the same filename as Assembly Definition File 'Packages/org.mujoco/Runtime/Mujoco.asmdef'. Rename the assemblies to avoid hard to diagnose issues and crashes.”
A solution that seems to be working (i.e., no more warning messages, both PlayMode and EditMode tests pass) is to rename mujoco/unity/Runtime/Mujoco.asmdef to mujoco/unity/Runtime/Mujoco.Runtime.asmdef.  This renaming is consistent with Unity's suggested naming conventions:
https://docs.unity3d.com/Manual/cus-asmdef.html
Note that in addition to renaming the Mujoco.asmdef file, the contents of the file must be changed slightly:
    "name": "Mujoco.Runtime",

And then references to it must be changed in the other .asmdef files.
mujoco/unity/Editor/Mujoco.Editor.asmdef:
    "references": [
        "Mujoco.Runtime"
    ],

mujoco/unity/Tests/Editor/Mujoco.Editor.Tests.asmdef:
    "references": [
        "UnityEngine.TestRunner",
        "UnityEditor.TestRunner",
        "Mujoco.Runtime",
        "Mujoco.Editor"
    ],

mujoco/unity/Tests/Runtime/Mujoco.Tests.asmdef:
    "references": [
        "UnityEngine.TestRunner",
        "Mujoco.Runtime"
    ],

Note that the name of the last such file, mujoco/unity/Tests/Runtime/Mujoco.Tests.asmdef, would be better and more consistent were it changed to Mujoco.Runtime.Tests.asmdef, but such a change is not strictly necessary to fix the warnings.

This is very useful, thanks.  I'll prepare this change and push it in the next batch.

pls help me
Plugin 'Assets/GoogleMobileAds/GoogleMobileAds.dll' has the same filename as Assembly Definition File 'Assets/GoogleMobileAds/GoogleMobileAds.asmdef'. Rename the assemblies to avoid hard to diagnose issues and crashes.

Going to close due to inactivity. Please re-open if this is still an issue.


Greedy Portfolio on version 0.1.0

Currently, we use the greedy portfolio generated using the old version (0.0.2) however, we should create a greedy portfolio for ourselves.

This portfolio would be released with the next major release. Till then, we will continue using the portflolio from version 0.0.2


IndexError: list index out of range for stored procedures

I get a crash when trying to run a built-in stored procedure:
HRDB> exec sp_spaceused;
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/eric/.virtualenvs/awscli/lib/python2.7/site-packages/mssqlcli/main.py", line 117, in <module>
    main()
  File "/home/eric/.virtualenvs/awscli/lib/python2.7/site-packages/mssqlcli/main.py", line 110, in main
    run_cli_with(mssqlcli_options)
  File "/home/eric/.virtualenvs/awscli/lib/python2.7/site-packages/mssqlcli/main.py", line 55, in run_cli_with
    mssqlcli.run()
  File "/home/eric/.virtualenvs/awscli/local/lib/python2.7/site-packages/mssqlcli/mssql_cli.py", line 440, in run
    self.execute_query(text)
  File "/home/eric/.virtualenvs/awscli/local/lib/python2.7/site-packages/mssqlcli/mssql_cli.py", line 365, in execute_query
    output = self._execute_interactive_command(text)
  File "/home/eric/.virtualenvs/awscli/local/lib/python2.7/site-packages/mssqlcli/mssql_cli.py", line 321, in _execute_interactive_command
    output, query = self._evaluate_command(text)
  File "/home/eric/.virtualenvs/awscli/local/lib/python2.7/site-packages/mssqlcli/mssql_cli.py", line 548, in _evaluate_command
    self.mssqlcliclient_main.execute_query(text):
  File "/home/eric/.virtualenvs/awscli/local/lib/python2.7/site-packages/mssqlcli/mssqlcliclient.py", line 112, in execute_query
    in self._execute_query(single_query):
  File "/home/eric/.virtualenvs/awscli/local/lib/python2.7/site-packages/mssqlcli/mssqlcliclient.py", line 146, in _execute_query
    = query_messages[result_set_summary.request_id].message if query_messages else u''
IndexError: list index out of range

Sorry about this @ericlathrop, can you provide some more details on your OS and the exact procedure you're attempting to run?

$ uname -a
Linux xps 4.15.0-72-generic #81-Ubuntu SMP Tue Nov 26 12:20:02 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

I'm trying to run sp_spaceused, or sp_helpdb

I can repro this. Thanks for letting us know! I'll investigate this further.

Looks like our implementation to support multiline statements is what's causing the break (#130).
We use result_set_summary.request_id as index for query messages but there appears to be a mismatch with the number of messages it's expecting. If I override the index with 0 it works for single-line statements but not when multiline is enabled.
We also need to improve testing to catch queries like sp_spaceused.
I need to look at this at a later time since the solution is seemingly non-trivial.


Exclude private getters from querystring & form posts

The way we were reflecting over objects for inclusion in querystrings and form posts was including public properties with inaccessible getters.
Now we make sure that the getter of the property is public.
Fixes #462

@onovotny So something that might need a bit of thought -- I removed the explicit binding flags in one of the GetProperties() calls, because I mistakenly thought the default was BindingFlags.Public | BindingFlags.Instance. It's not. It's just BindingFlags.Public, so you get static properties back.
Now I've realised that, my first thought was to change them both to public instance, but maybe it's desirable to allow static? A potential example of a property you might want to make static and set once is an API key or something. On the other hand, there are potentially better ways to handle that use case?

I'm not crazy about including statics, but changing it at this point would be a breaking change.

It would only be a breaking change for one of the places (form posts). The query string already had the correct binding flags applied.
I think it's probably okay. The fact that statics worked for form posts was undocumented and not really that logical either. I'd be surprised if anyone was intentionally using them.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bennor sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Meaning of cluster0 and cluster1 in GINet

Hello, I am studying your source code and DeepRank-GNN. It's great if you can explain to me the meaning of cluster0 and cluster1 in the ginet.py.
According to the original paper DeepRank-GNN, it seems like two clusters mean internal graphs & external graphs.
It seems that the same graph is being used for both GNN as data_ext is cloned from data. Please correct me if i am wrong. The implementation code seems different from the model described in the paper.
Also, why do the results of pooling operation in cluster0 pass to the second convolution layer?

Thank you for your time.
class GINet(torch.nn.Module):
    # input_shape -> number of node input features
    # output_shape -> number of output value per graph
    # input_shape_edge -> number of edge input features
    def __init__(self, input_shape, output_shape=1, input_shape_edge=1):
        super(GINet, self).__init__()
        self.conv1 = GINetConvLayer(input_shape, 16, input_shape_edge)
        self.conv2 = GINetConvLayer(16, 32, input_shape_edge)

        self.conv1_ext = GINetConvLayer(input_shape, 16, input_shape_edge)
        self.conv2_ext = GINetConvLayer(16, 32, input_shape_edge)

        self.fc1 = nn.Linear(2 * 32, 128)
        self.fc2 = nn.Linear(128, output_shape)
        self.clustering = "mcl"
        self.dropout = 0.4

    def forward(self, data):
        act = F.relu
        data_ext = data.clone()

        # EXTERNAL INTERACTION GRAPH
        # first conv block
        data.x = act(self.conv1(data.x, data.edge_index, data.edge_attr))
        cluster = get_preloaded_cluster(data.cluster0, data.batch)
        data = community_pooling(cluster, data)

        # second conv block
        data.x = act(self.conv2(data.x, data.edge_index, data.edge_attr))
        cluster = get_preloaded_cluster(data.cluster1, data.batch)
        x, batch = max_pool_x(cluster, data.x, data.batch)

        # INTERNAL INTERACTION GRAPH
        # first conv block
        data_ext.x = act(
            self.conv1_ext(data_ext.x, data_ext.edge_index, data_ext.edge_attr)
        )
        cluster = get_preloaded_cluster(data_ext.cluster0, data_ext.batch)
        data_ext = community_pooling(cluster, data_ext)

        # second conv block
        data_ext.x = act(
            self.conv2_ext(data_ext.x, data_ext.edge_index, data_ext.edge_attr)
        )
        cluster = get_preloaded_cluster(data_ext.cluster1, data_ext.batch)
        x_ext, batch_ext = max_pool_x(cluster, data_ext.x, data_ext.batch)

        # FC
        x = scatter_mean(x, batch, dim=0)
        x_ext = scatter_mean(x_ext, batch_ext, dim=0)

        x = torch.cat([x, x_ext], dim=1)
        x = act(self.fc1(x))
        x = F.dropout(x, self.dropout, training=self.training)
        x = self.fc2(x)

        return x

Hi there,
cluster0 and cluster1 are different levels of clustering. They do not specifically represent "internal graphs" and "external graphs"
Best,
Xiaotong


[Numpy] Random.normal() with backward

Description
As title
Gradient estimated through reparameterization trick:
z ~ N(\mu, \sigma) = N(0, 1) * \sigma + \mu
dz/d\mu = 1
dz/d\sigma = N(0, 1)

Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

You may mention that this uses the reparameterization trick.

@sxjscience This PR looks good to you?

LGTM. We can merge this in once the conflicts are resolved.

@sxjscience
Sure, I will resolve the conflict ASAP.


Setting forceY in multiChart

I'm creating a chart that uses multiChart to display a bar graph with 2 line graphs on top of it.
The y scale is being calculated automatically based on my data, but I want to start my scale at 0. I've tried multiple combinations of using 'forceY' in different ways to make this happen, and I can't get this to work with my multiChart.
I was able to do this fine with linePlusBarChart - but I need to display 2 lines so I can't use it.
Any suggestions?

I'm looking for this too. So far I have just pushed an additional item in my array with zero amounts, not the most elegant solution.

+1


Bug 2093277: Add ACM resources to resourceVersion update list

In order to update objects these need to get the resourceVersion from
the existing ones. There is a list to determine which resources should
be able to grab this field and ACM resources were not part of it.

/lgtm


⚠ ClamAV has degraded performance

In 15d68bb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 72 ms

Resolved: ClamAV performance has improved in 1c83cff.


⚠ Turnos 24x7 has degraded performance

In 6d04dce, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3672 ms

Resolved: Turnos 24x7 performance has improved in 11a881a.


Spatial audio breaks when adding RapierPhysicsPlugin

When adding RapierPhysicsPlugin from bevy_rapier3d to the spatial example you will get compilation errors saying Velocity is ambiguous. But in my own project I've also had a case where it silently broke the spatial audio (resulting in just 2d audio).
I think it would be a good time to also think about the following question: Would it be beneficial if a physics engine can provide the velocity instead?

Avoids redundant calculation of velocity, physics engines will calculate this anyway.
More accurate velocity if it's calculated by a physics engine?
Avoids worry about ambiguous imports.

Let's also include bevy_xpbd when we come to a solution.

So we either need to support a bunch of popular physics libraries or add some sort of adapter layer that can be extended by other crates. Like exposing a trait that can be used to build adapter crates like bevy_fmod_rapier.

Maybe for now we can keep doing our own velocity calculation and find a solution to this bug so we don't have to worry about physics libraries. I don't think there will be much advantage by letting a physics engine calculate the velocity. What do you think?

https://github.com/Salzian/bevy_fmod/pull/56 solved this for me in the sense that it's not necessary anymore to import Velocity directly.

Closing for now; if it's still interesting maybe we can create a new issue for the idea of being able to use the velocity as provided by a physics engine


Revert "Flav/prep login for auth0"

Reverts dust-tt/dust#4113

Proper fix implemented in https://github.com/dust-tt/dust/pull/4128.


Problem while using the AutoLayout

Please refer the attached screen shot and below description.

I had used the green colour portion as RMScannerView
I had used the red colour as a bottom view.

I had added the Auto Layout based on the screen layout.
Now when I run the application in iPhone 6 or iPhone 5, 5s with iOS 7.1 to 8.1 then layout of RMScannerView is not worked because it can not touch the top border of red portion as you found in the attached screenshot.
Please let me know if you had required any more information from my side to track the above issue.

Same issue here


Add AWSPlacementGroup controller

This PR adds scaffolding for the new AWSPlacementGroup CRD controller.

@JoelSpeed addressed your latest review comments, PTAL.

/lgtm

/retest-required

/retest-required

/test e2e-aws-upgrade


feat: Support for sponge 1.20.6

Motivation
Sponge now supports 1.20.6
Modification
Add 1.20.6 for sponge
Result
Allows PR #1395 to be complete and mergable
Other context

Wraps up PR #1395

Hi, have you tested sponge 1.20.6 with all modules that have sponge support?

Hi, have you tested sponge 1.20.6 with all modules that have sponge support?

I haven't as sponge's API kept giving time outs and 524 for all versions, it'd be great if someone else can test it
Caused by: java.io.IOException: Server returned HTTP response code: 524 for URL: https://repo.spongepowered.org/service/rest/v1/search/assets?md5=e3899bcf5a638 22d9c41dff001559921aven.groupId=org.spongepoweredaven.artifactId=configurate-yamlaven.baseVersion=4.1.2aven.extension=jar

Okay, so we'll have some problems with our platform inject because of the new sponge api version. I think I will need some time because at this point we need to remove cloudperms in order to proceed with sponge


Closing the GUI app doesn't terminate electron processes

Closing Ferdi doesn't kill all running electron processes. When I close Ferdi via the GUI as one normally would by hitting the x button in the top bar Ferdi closes and appears to not be running as indicated in the Gnome dock. Looking at htop though there are still electron processes running and they are quite hungry. I made sure I had no other elelctron-based apps running like VSCode or sth similar.
OS/env:
Using GNOME 3.38.2  on Arch Linux with kernel 5.9.11
Steps to reproduce:
Use Gnome shell on arch, install Ferdi, install a few services like whatsapp, telegram and gmail, use them, close the app. check system processes e.g. with htop.

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Killing the app via the GUI kills all app processes.
Screenshots
App open and running:

App closed:

@morrieinmaas can you reproduce this with the latest Ferdi Version? We now use electron 13 instead of electron 8, so that makes a big difference.

Tried to reproduce this with htop same like the author.
All Ferdi electron processes are correctly terminated on app quit.
Verified on macOS Big Sur running 5.6.1-nightly.27


License script fails to handle newly rolled boringssl in flutter/engine

From https://github.com/flutter/engine/pull/5390 with attempt to roll dart with rolled boringssl
╰─➤  flutter/travis/licenses.sh
Verifying license script is still happy...
Resolving dependencies...
Got dependencies!
Finding files...
failed to handle ../../../third_party/boringssl/src/LICENSE: found too many authors for this copyright:
OpenSSL License
...
#0      License._readAuthors (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/licenses.dart:406:7)
#1      new License._ (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/licenses.dart:272:127)
#2      new MultiLicense._ (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/licenses.dart:954:70)
#3      new License.fromBodyAndType.<anonymous closure> (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/licenses.dart:182:22)
#4      _HashVMBase&MapMixin&&_LinkedHashMapMixin.putIfAbsent (dart:collection-patch/compact_hash.dart:270)
#5      new License.fromBodyAndType (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/licenses.dart:161:32)
#6      new RepositoryOpenSSLLicenseFile (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:1983:29)
#7      RepositoryBoringSSLSourceDirectory.createFile (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:1965:18)
#8      RepositoryDirectory.crawl (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:864:36)
#9      new RepositoryDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:837:5)
#10     new RepositoryBoringSSLSourceDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:1948:85)
#11     RepositoryBoringSSLDirectory.createSubdirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:2014:18)
#12     RepositoryDirectory.crawl (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:859:39)
#13     new RepositoryDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:837:5)
#14     new RepositoryBoringSSLDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:2002:79)
#15     RepositoryRootThirdPartyDirectory.createSubdirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:1904:18)
#16     RepositoryDirectory.crawl (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:859:39)
#17     new RepositoryDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:837:5)
#18     new RepositoryGenericThirdPartyDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:1200:87)
#19     new RepositoryRootThirdPartyDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:1874:84)
#20     RepositoryRoot.createSubdirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:2310:18)
#21     RepositoryDirectory.crawl (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:859:39)
#22     new RepositoryDirectory (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:837:5)
#23     new RepositoryRoot (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:2280:37)
#24     main (file:///Users/aam/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses/lib/main.dart:2411:42)
<asynchronous suspension>
#25     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:263)
#26     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)

aborted.

Changes to LICENSE that triggered this error are below. @Hixie any thoughts on what is the right fix for this?
╰─➤  diff LICENSE $FH/engine/src/third_party/boringssl/src/LICENSE
181a182,251
>
>
> Licenses for support code
> -------------------------
>
> Parts of the TLS test suite are under the Go license. This code is not included
> in BoringSSL (i.e. libcrypto and libssl) when compiled, however, so
> distributing code linked against BoringSSL does not trigger this license:
>
> Copyright (c) 2009 The Go Authors. All rights reserved.
>
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions are
> met:
>
>    * Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
>    * Redistributions in binary form must reproduce the above
> copyright notice, this list of conditions and the following disclaimer
> in the documentation and/or other materials provided with the
> distribution.
>    * Neither the name of Google Inc. nor the names of its
> contributors may be used to endorse or promote products derived from
> this software without specific prior written permission.
>
> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
>
> BoringSSL uses the Chromium test infrastructure to run a continuous build,
> trybots etc. The scripts which manage this, and the script for generating build
> metadata, are under the Chromium license. Distributing code linked against
> BoringSSL does not trigger this license.
>
> Copyright 2015 The Chromium Authors. All rights reserved.
>
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions are
> met:
>
>    * Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
>    * Redistributions in binary form must reproduce the above
> copyright notice, this list of conditions and the following disclaimer
> in the documentation and/or other materials provided with the
> distribution.
>    * Neither the name of Google Inc. nor the names of its
> contributors may be used to endorse or promote products derived from
> this software without specific prior written permission.
>
> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Proposed fix is to ignore last part that starts with BoringSSL uses the Chromium test infrastructure to run a continuous build, -
https://github.com/flutter/engine/pull/5390/commits/65604b11e9fe36ada32148be3da7bdbcad85ab92

I forget how boringssl is handled, but basically we just need to update that code to handle the new combined license and then basically ignore these last two additions. If it's handled as a special case then it's just a matter of updating the regexp. If it's handled as multiple licenses then we need to update the patterns to correctly split the above into the relevant separate blocks, and then skip them.

Thanks @Hixie
boringssl license is handled as an openssl license, so my fix sounds similar to what you are suggesting, except it simply cuts bottom part of license text that trips copyright count verification.

Fixed by https://github.com/flutter/engine/commit/65604b11e9fe36ada32148be3da7bdbcad85ab92#diff-498bddb8dfa5429f3420a0e16ef68e18


Problem extracting 7z archive

Someone posted an archive over at adamhathcock/sharpcompress#73 which can't be unpacked, neither by sharpcompress nor my own managed-lzma implementation. The official 7z application seems to be able to unpack it.
Should investigate at what point my implementation diverges from the official source.

Link to archive is http://springrts.com/dl/buildbot/default/develop/102.0.1-19-gfbc1b5b/win32/spring_{develop}102.0.1-19-gfbc1b5b_win32-minimal-portable.7z

In a first look the metadata section of the 7z file (compressed via lzma) decodes properly (decoded checksum matches the header value) but then parsing the metadata section yields strange file attributes which make no sense; from there on it's probably broken. Right now I'm suspecting a bug in the metadata parsing code.

Update: the archive has been created on linux, using linux file attributes. I don't parse these properly since they use different constants.
If I ignore the linux file attributes the decoder still throws an exception, so something else is going wrong.

For the second part its the same issue as #16 just for the lzma decoder instead of lzma2 ... oops

Further research shows that linux file attributes are not officially supported by 7z archives, but some 3rd party libraries abused the fact that the official codebase is lazy in its error checking and started hiding linux file attributes in unused metadata bits.
Newer versions of the 7z GUI client acknowledge this and try to parse this unofficial extension, but the main 7z codebase still does not support it, it is only handled in the UI layer.
However since it seems to have become a de-facto standard I'll update my implementation to be able to deal with it.

This should make it possible to read archives using this extension. I'll create a separate issue to track the possible feature request of being able to extract those posix file attributes.

The fix for this is included in alpha-6


Update to nodejs 20

@acote88 you created this commit from the secrets branch, but can you create it on main instead? I'm not ready to merge the secrets branch.

cherry-picked onto main as 3bf2323

setup-go needs to be v5


fast5 content

Hello developers,
I have a little question to  consult you. You have developed the hpg-pore to analysis FAST5 files, so you must clearly understand the internal format of the FAST5 files. I use the 'h5dump' to view the entire contents of the FAST5 file, but I can not understand what the make up mean, such as  some GROUP,
ATTRIBUTE .  Do you know some papers that illustrate FAST5 files in detail? Could you give me a help?
Thanks.

https://porecamp.github.io/2016/tutorials/PoreCamp2016-02-MinIONData.pdf
Might be helpful


feat(app): only display footer on homepage

🤔 Why do you want to make those changes?
We only want to display the footer in the homepage
🧑🔬 How did you make them?

Remove <Footer /> from the RootLayout
Adding <Footer /> on the homepage
Fix style 🎨

🧪 How to check them?
Check the preview 👀

@Boyadjie plus qu'à faire en sorte que la sidebar soit fixed 😊


Parameter amax in scalar_search_wolfe2 is not used

The line search method  scipy.optimize.linesearch.scalar_search_wolfe2 (which is used for scipy.optimize.linesearch.line_search_wolfe2) has the following header:
def scalar_search_wolfe2(phi, derphi=None, phi0=None,
old_phi0=None, derphi0=None,
c1=1e-4, c2=0.9, amax=50)
It allows a parameter amax which is the Maximum step size allowed but this parameter is nowhere used in the definition of the function (and I have a concrete function that I would like to minimize where I need this functionality).
As I am no expert in line search methods, I don't know how this bounding of the step size could be implemented without destroying the convergence property of the line search method.

@PhilippWacker In the Fortran-using version of this function, scipy.optimize.linesearch.scalar_search_wolfe1, it appears to me that if the step size reaches amax and this is still too small to meet the strong Wolfe conditions, the function will give up on converging and return a step size of None. As far as I know this is the only way to use a max step size with this particular line search algorithm.
Thinking about alternatives, I think scipy.optimize.linesearch.line_search_armijo tries step sizes decreasing from the supplied alpha_0 to find one that gives sufficient decrease in the objective function. The lack of a curvature requirement means it should to be guaranteed to converge on some step size under alpha_0 (unless a too-large amin is somehow supplied to scalar_search_armijo). Would that work for your problem?

I circumvented the issue by scaling the cost function: My problem was that the line search didn't try small enough steps (and the cost function was always np.nan), so I scaled the input of the cost function such that it did find finite values. Thanks!

I've been poking at this function and am most of the way towards making a PR that fixes some documentation, uses the parameter, adds a few tests, and simplifies some of the code.

@cdouglass, would you please make maxiter of the wolfe2 a parameter too? In some cases that number may be too restrictive.
I encounter a case when the wolfe2 search returns None though a simple backtrace worked fine. It appears if the initial point is too far from the minimum, wolfe2 has either exhausted maxiter or amax.


glue hangs if interface name does not match filename

On 57681be5420586fff80ca6c6f850a9bfc7e6a4c2, given the following files roc glue Package-Config.roc glue.rs will just hang forever.
Package-Config.roc:
platform "roc-lang/rbt"
    requires {} { init : SomeInterface.RecursiveThing }
    exposes [SomeInterface]
    packages {}
    imports [SomeInterface]
    provides [initForHost]

initForHost : SomeInterface.RecursiveThing
initForHost = init

SomeInterface.roc:
interface Rbt
    exposes [RecursiveThing]
    imports []

RecursiveThing : [RecursiveThing Str]

(RecursiveThing is not a great name for this extremely non-recursive type, but I was trying for a different SSCCE when I found this!)

ahhhh, looks like interface Rbt in the filename SomeInterface.roc might be the problem here! But still it hangs forever if the name is wrong.

This just happened to me, and it looks similar to #3440.