[TA] Added healthcare new properties

Description
Bring back the removed FHIR feature to Text Analytics

Added properties fhirVersion and documentType to AnalyzeHealthcareEntitiesOptions and AnalyzeHealthcareEntitiesAction.
Use the keyword to indicate the version for the fhirBundle contained on the AnalyzeHealthcareEntitiesResult.
Added property fhirBundle to AnalyzeHealthcareEntitiesResult.
Added property confidenceScore to HealthcareEntityRelation.
Added enum DocumentType.

All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-textanalytics

Don't review it. Found a TextUtil has a recording text issue. ,
Give a partial recorded json section. The REDACTED name should be offset and length. It should not be "REDACTED"
"entities":[{"REDACTED":17,"REDACTED":11,

+1 on @kristapratico's review. Also, is it intentional to have that many samples for healthcare? 4 samples for one feature seems excessive.

Since we have (1) healthcare action and (2) healthcare bespoken methods. It would require to have 4 samples, each one having sync and async API in java.

@kristapratico Does Python also have that many samples showing bespoke and beginAnalyze variants for the same feature?


put_pixel does not seem to work

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10
Godot 2.1.4-stable
Issue description:

I used Fill to set the background of an image red then used put_pixel to set a 10x10 block green
It filled the image in red but did not draw the green block.
Get_Pixel shows the expected change but visually there is no difference.
Steps to reproduce:
Code provided below, I may have implemented it correctly but i'm unable to find an example of code that works on 2.1.4
Link to minimal example project:

put_pixel_test.zip

This is not an issue, I was almost certain I had tried to draw the entire image but perhaps not.
The example provided won't work due to the image being cut off by the window which was resolved with
sprite.set_centered(false)


[Feature] ask for UpdateToVersionFile Official implementation

i was stuck when i want to achieve restore feature.
i think we need an 'UpdateToVersionFileAsync' function example.
after searching organization .i found 'RestoreVersionAsync、UpdateToVersionFileAsync' funciton in Below project.
url
url
can we have an Official implementation for this?
Thank you.

Hello @yaolinhong
Please clarify your request. What exactly is going wrong?
Do I understand it right that you are trying to implement Document history feature? I mean this one: https://api.onlyoffice.com/editors/history#apply
If so, please note that file versions storage and management is your task as independent integrator. To display the versions list in the editor you have to pass information about versions and version order.
If I misunderstood your request, please clarify it.

Hello @yaolinhong Please clarify your request. What exactly is going wrong? Do I understand it right that you are trying to implement Document history feature? I mean this one: https://api.onlyoffice.com/editors/history#apply
If so, please note that file versions storage and management is your task as independent integrator. To display the versions list in the editor you have to pass information about versions and version order. If I misunderstood your request, please clarify it.

thanks for the response. @Misokados
i has followed the guide to implement Document history feature. https://api.onlyoffice.com/editors/history#apply
i have no problem about display the versions list in the editor.
when browser trrigger onRequestRestore button,it seems i need to do some file versions storage and management work myself.
I would really appreciate if you can give me some simple advice.
image

when browser trrigger onRequestRestore button,it seems i need to do some file versions storage and management work myself.

That's right. Please check out this title: https://api.onlyoffice.com/editors/config/events#onRequestRestore
You have to call https://api.onlyoffice.com/editors/methods#refreshHistory when user clicks on 'Restore' button.

So, the ideal scenario should look like this: when a user clicks the 'Restore' button you have to check out number version and place it as the latest version in your storage. After that you have to refresh versions order.


Redirect page: redirect with meta refresh

If you go directly to a page with a redirect template, the page should redirect to the target site. Like that you can use redirects for Vanity Urls etc.

looks fair and easy to implement.

Yes, I will take the redirect.ftl from usb project.


sources.list empty

hello, i am trying to install this using Ubuntu 18, but i have this error
E: Type '<!DOCTYPE' is not known on line 1 in source list /etc/apt/sources.list.d/locast2tuner.list
E: The list of sources could not be read.
this url is empty
https://wouterdebie.github.io/my_ppa/sources.list
any ideas?
thank you!

Oops, sorry. That should be "https://wouterdebie.github.io/ppa/sources.list
https://wouterdebie.github.io/my_ppa/sources.list". If fixed the readme.
On Wed, Apr 7, 2021 at 2:18 PM detodotv @.***> wrote:

hello, i am trying to install this using Ubuntu 18, but i have this error
E: Type '<!DOCTYPE' is not known on line 1 in source list
/etc/apt/sources.list.d/locast2tuner.list
E: The list of sources could not be read.
this url is empty
https://wouterdebie.github.io/my_ppa/sources.list
any ideas?
thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wouterdebie/locast2tuner/issues/19, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABKABQHB6NX3UWED66S6Y3THSVYVANCNFSM42RMAXTA
.


Strange effect when exiting powershell while VMWare PowerCLi  and PSReadline loaded.

powershell -noprofile
Add-PSSnapin VMware.VimAutomation.Core
Import-Module PSReadLine
when I close PS window by X-title button, before window is closed I see current directory name about several hundred times in console. something like D:\D:\D:\D:\D:\D:\D:\D:\D:.
On 'exit' there is no such effect.
Win7SP1 x64, PowerCLi v5.8R1, PSReadline - current -master, PS v4.0
It was first watched in december PSreadline release.
I'm not sure about PSReadline and not VMWare problem, but don't know how to debug.
need confirmation.

Reproduced with PowerShell version 3.0, PowerCLI version 5.5, and PSReadLine 1.2.
You can workaround this by importing PSReadLine first and then adding the snapin.


Input?

How would I handle input via behavior trees?

What are you referring to specifically? You can handle inputs any way you like when extending States/Transitions/leaves

I wanted to handle inputs in a reusable way.
I just don't know how to actually implement it.

You can take a look at the example scene in the 2.0.0 (#57) branch. I handle the vectors simply on the Character using
func _physics_process(_delta):
	movement_direction = Vector2(
		Input.get_axis("ui_left", "ui_right"),
		Input.get_axis("ui_up", "ui_down")
	)

and apply it in the FSMState script that is used for the walking state. This relies on the Character having a movement_direction  var, but you can easily write your own reusable component/class for the character that is accessed in the BT or FSM too!

I really don't want to have invisible dependencies thought.
using a script on a node seems like it would defeat the point of a behavior tree

using a script on a node seems like it would defeat the point of a behavior tree

You can always move the same code into the BT nodes!

(Using blackboards to store the value, if that isn't obvious haha)


Cannot read property 'enabled' of undefined

Problem
Coming from https://github.com/Expensify/App/pull/45452, we're getting the following crash on Crashalytics:
 Non-fatal Exception: androidx.camera.core.impl.a1: Cannot read property 'enabled' of undefined
       at .CardReconciliationPage(address at index.android.bundle:1:7676603)
       at .renderWithHooks(address at index.android.bundle:1:1205059)
       at .beginWork$1(address at index.android.bundle:1:1244381)
       at .performUnitOfWork(address at index.android.bundle:1:1230412)
       at .workLoopSync(address at index.android.bundle:1:1230313)
       at .renderRootSync(address at index.android.bundle:1:1230193)
       at .recoverFromConcurrentError(address at index.android.bundle:1:1227070)
       at .performSyncWorkOnRoot(address at index.android.bundle:1:1227704)
       at .flushSyncCallbacks(address at index.android.bundle:1:1194773)

Solution
Fix the issue

Ah didn't realize we already had an issue for it. Thanks for pointing that out. I'll close this issue in favor of that one.


Split xml modules

Needs a fs2 snapshot still due typelevel/fs2#3006, but other than that, features fully working xml and xml-scala modules with native support and up-to-date dependencies.

This PR still references a fs2 snapshot and a snapshot of the http4s build plugin, but apart from these small version bumps, I believe it's good for review (and as soon as we have stable dependencies also a 0.1.0 release based on it).
Tagging @rossabaker as you were the one starting the whole effort and might be interested, feel free to ignore.


Database is not encrypted when using Java 3.0.19 API

OrientDB Version: 3.0.19
Java Version: AdoptJDK 11.0.1+13
OS: Wind 10 1903
Expected behavior
Database should be encrypted at file-level when using Java 3.x API (OrientDB.createIfNotExists(..))
Actual behavior
STORAGE_ENCRYPTION_METHOD and STORAGE_ENCRYPTION_KEY config keys are ignored, database is created but stays unencrypted.
Also creation encrypted db using deprected api works, but that db cannot be opened using new API.
Steps to reproduce
//==================
//In new API:
//==================
		//encryption config values are ignored, db stays unencrypted

		private static final String ENC_KEY = "T1JJRU5UREJfSVNfQ09PTA==";
		private static final String EAC_DB_NAME = "TestDb";
		private static final String ENC_METHOD = "aes";

		orient.createIfNotExists(
                EAC_DB_NAME,
                ODatabaseType.PLOCAL,
                OrientDBConfig.builder()
                        .addConfig(OGlobalConfiguration.STORAGE_ENCRYPTION_METHOD, ENC_METHOD)
                        .addConfig(OGlobalConfiguration.STORAGE_ENCRYPTION_KEY, ENC_KEY)
                        .build());

        try (ODatabaseSession session = orient.open(EAC_DB_NAME, "admin", "admin",
                OrientDBConfig.builder()
                        .addConfig(OGlobalConfiguration.STORAGE_ENCRYPTION_METHOD, ENC_METHOD)
                        .addConfig(OGlobalConfiguration.STORAGE_ENCRYPTION_KEY, ENC_KEY + "InvalidKey") //FIXME Test if provided key is verfied (is not!)
                        .build())) {

            return session;
        }

//==================
//Mixed old API and new API:
//==================
        //Db creation with old API
        ODatabaseDocumentTx db = new ODatabaseDocumentTx("plocal:"+ OrientConfiguration.orientDbHomeDirStatic + "/databases/temp3_enc");
        db.setProperty(OGlobalConfiguration.STORAGE_ENCRYPTION_METHOD.getKey(), "aes");
        db.setProperty(OGlobalConfiguration.STORAGE_ENCRYPTION_KEY.getKey(), "T1JJRU5UREJfSVNfQ09PTA==");
        db.create();

        db.command(new OCommandSQL("create class TestEncryption")).execute();
        db.command(new OCommandSQL("insert into TestEncryption set name = 'Jay'")).execute();

        List result = db.query(new OSQLSynchQuery<ODocument>("select from TestEncryption"));
        db.close();

        //Old API opening - works
        db.open("admin", "admin");
        OStorage storage = ((ODatabaseDocumentInternal) db).getStorage();
        db.close();
        storage.close(true, false);

        db.setProperty(OGlobalConfiguration.STORAGE_ENCRYPTION_KEY.getKey(), "T1JJRU5UREJfSVNfQ09PTA==");
        db.open("admin", "admin");
        result = db.query(new OSQLSynchQuery<ODocument>("select from TestEncryption"));
        LOG.warn("result size (should be 1): " + result.size());
        LOG.warn("result value (should be \"Jay\"): " + result.get(0).toString());
        storage = ((ODatabaseDocumentInternal) db).getStorage();
        db.close();

        storage.close(true, false);

        //New API
        //throws: Suppressed: com.orientechnologies.orient.core.exception.OSecurityException: AES encryption has been selected, but no key was found. Please configure it by passing the key as property at database create/open. The property key is: 'storage.encryptionKey'
        try (ODatabaseSession session = orient.open("temp3_enc", "admin", "admin",
                OrientDBConfig.builder()
                        .addConfig(OGlobalConfiguration.STORAGE_ENCRYPTION_METHOD, ENC_METHOD)
                        .addConfig(OGlobalConfiguration.STORAGE_ENCRYPTION_KEY, "T1JJRU5UREJfSVNfQ09PTA==")
                        .build())) {
        }

I'm still having this issue today. Why has there been no resolution on this obviously critical issue?

The first test is incorrect, you already opened storage during createIfDoesNotExist method, AES key is used only once during storage opening/creation and can not be replaced till the next storage close. Checking the second test.

The second test passed both with invalid and valid way.

Closing the issue as invalid.

Sorry checked under the 3.1 version. Let me check on 3.0

Has got the same result on 3.0.33 version. Closing as invalid.


importer API lacks of file format documentation

An user importing a CSV can't know what columns should use for the geometry columns, what types we guess and so on.
In general:

add information about all the formats we support with detailed information of what we do for each one, for example

KML: import as many tables as layers, we don't use the styles and we expect it in wgs84
shp: import as many tables a shp files, we need prj file (if it lacks of it we use WGS84 )...
csv: there should be a the_geom column (optionally called, wkb_geometry, geojson,...) the format for that column can be geojson (a single feature), WTK or WTB

add clear information about encodings and types. How we guess encodings and types

cc @juanignaciosl @Kartones @pramsey

I've just seen the new docs in production and they look really nice ^_^
http://docs.cartodb.com/cartodb-platform/import-api/geospatial-data-formats/#supported-geospatial-data-formats
(minor comment: I'd move the "Dataset Basics" a bit up, for a future version).
Thanks @iriberri and @csobier
closing this for the moment

I'll move it up right now (and move it underneath the supported format section).


Handle shared types between different contracts

Problem
Say the user has two contracts using a shared custom library, and they want to pass data of some custom type (from the shared library) from one contract to another in the SDK. For instance, suppose the following Sway library:
library shared_type;

// anything `pub` here will be exported as a part of this library's API
pub struct MyStruct {
    foo: u64,
}

And two contracts, contract_a and contract_b, that look the same, for brevity's sake:
contract;

use shared_type::*;

abi MyContract {
    fn takes_shared_type_and_return_it(arg: MyStruct) -> MyStruct;
}

impl MyContract for Contract {
    fn takes_shared_type_and_return_it(arg: MyStruct) -> MyStruct {
        arg
    }
}

Then, in the Rust, using the SDK:
setup_contract_test!(
    contract_a_instance,
    wallet,
    "packages/fuels/tests/contracts/contract_a"
);

setup_contract_test!(
    contract_b_instance,
    None,
    "packages/fuels/tests/contracts/contract_b"
);

let my_struct = MyStruct { foo: 42 };

The Rust code above will fail with:
`MyStruct` is ambiguous because of multiple glob imports of a name in the same module consider adding an explicit import of `MyStruct` to disambiguate.

That happens because we generate MyStruct twice under two different modules: contract_a and contract_b:
pub mod contractainstance_mod {
            // Imports...
            pub struct contractAInstance {
                contract_id: Bech32ContractId,
                wallet: WalletUnlocked,
                logs_lookup: Vec<(u64, ParamType)>,
            }
            impl contractAInstance {
                pub fn new(contract_id: Bech32ContractId, wallet: WalletUnlocked) -> Self {
                    Self {
                        contract_id,
                        wallet,
                        logs_lookup: ::alloc::vec::Vec::new(),
                    }
                }
                // ...
            }
            pub struct contractAInstanceMethods {
                contract_id: Bech32ContractId,
                wallet: WalletUnlocked,
            }
            impl contractAInstanceMethods {
                #[doc = "Calls the contract's `takes_shared_type_and_return_it` function"]
             // ...
            pub struct MyStruct {
                pub foo: u64,
            }

pub mod contractbinstance_mod {
            // Imports...
            pub struct contractBInstance {
                contract_id: Bech32ContractId,
                wallet: WalletUnlocked,
                logs_lookup: Vec<(u64, ParamType)>,
            }
            impl contractBInstance {
                pub fn new(contract_id: Bech32ContractId, wallet: WalletUnlocked) -> Self {
                    Self {
                        contract_id,
                        wallet,
                        logs_lookup: ::alloc::vec::Vec::new(),
                    }
                }
                // ...
            }
            pub struct contractBInstanceMethods {
                contract_id: Bech32ContractId,
                wallet: WalletUnlocked,
            }
            impl contractBInstanceMethods {
                #[doc = "Calls the contract's `takes_shared_type_and_return_it` function"]
             // ...
            pub struct MyStruct {
                pub foo: u64,
            }

So, two problems arise:

The Rust compiler can't disambiguate when you say MyStruct; it would have to be contractainstance_mod::MyStruct.
You can use an instance of MyStruct, a shared type, interchangeably between contract_a and contract_b; contract_a takes strictly contractainstance_mod::MyStruct and contract_b takes strictly contractbinstance_mod::MyStruct.

This forces the user to either:

Break Sway best practices (using a library to share types) to please the SDK and the Rust compiler or;
Manually disambiguate MyStructs by referring to them as contractainstance_mod::MyStruct and contractbinstance_mod::MyStruct and when passing MyStruct amongst each other, manually creating the other MyStruct from the MyStruct you have in hands. E.g. contractainstance_mod::MyStruct { foo: my_original_struct.foo }.

Both are bad experiences we should come up with some SDK magic to improve this.
Solution
I haven't thought through any actual solution. Decided to open this issue so we can discuss some options here.

I'll try to summarize what was discussed:
There were two approaches:
Approach 1) Users will call lib_abigen manually on all used libraries.
The mod names of the generated lib types will be well-known. Contracts that use these types will have their rust bindings redirected to the generated lib types so that they might be shared. The user will need to manually import the library-generated types. Library JSON ABI files would need to be made available. Requires support from the compiler.
Approach 2) Users will pass to abigen all related contracts, abigen will proceed to generate bindings with deduplicated/shared types wherever possible. Can be done without compiler support with the caveat that all types will be deduplicated not only the ones coming from a library.
We've decided to try out approach #2.


ERROR when trying to run ng new when behind a corporate proxy

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Windows 7 enterprise edition

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.16
node: 4.6.0
os: win32 x64
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

No, I'm trying to create a project using "ng new" and it is unable to clone from github.  I've set the http/https proxy settings in the .npmrc and .gitconfig files.  I've include authenticate and I've even tried to use CNTLM to manage proxy authentication.  It states the proxy is open and does not require another proxy.  I am able to access github.com from chrome and IE.
Note: this all works fine when I'm in the office and we can directly connect to github.  The only issue is when I telework and I have to go through the proxy.  One thing we noticed is the IP address going requesting the files from github is my local IP address and not the proxy.  I've set the config file to use the proxy, but it still doesn't work.
The log given by the failure.

Normally this include a stack trace and some more information.

4120 verbose stack Error: Command failed: git -c core.longpaths=true clone --template=C:\Users\peterson_t\AppData\Roaming\npm-cache_git-remotes_templates --mirror git@github.com:webpack/compression-webpack-plugin.git C:\Users\peterson_t\AppData\Roaming\npm-cache_git-remotes\git-github-com-webpack-compression-webpack-plugin-git-7e55907cd54a2e91b96d25a660acc6a2a6453f54-e286d0b5
4120 verbose stack Cloning into bare repository 'C:\Users\peterson_t\AppData\Roaming\npm-cache_git-remotes\git-github-com-webpack-compression-webpack-plugin-git-7e55907cd54a2e91b96d25a660acc6a2a6453f54-e286d0b5'...
4120 verbose stack
4120 verbose stack     at ChildProcess.exithandler (child_process.js:213:12)
4120 verbose stack     at emitTwo (events.js:87:13)
4120 verbose stack     at ChildProcess.emit (events.js:172:7)
4120 verbose stack     at maybeClose (internal/child_process.js:829:16)
4120 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
4121 verbose cwd c:\WebstormProjects\AngularTest
4122 error Windows_NT 6.1.7601
4123 error argv "C:\Program Files\nodejs\node.exe" "C:\Users\peterson_t\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "install"
4124 error node v4.6.0
4125 error npm  v3.10.8
4126 error code 128
4127 error Command failed: git -c core.longpaths=true clone --template=C:\Users\peterson_t\AppData\Roaming\npm-cache_git-remotes_templates --mirror git@github.com:webpack/compression-webpack-plugin.git C:\Users\peterson_t\AppData\Roaming\npm-cache_git-remotes\git-github-com-webpack-compression-webpack-plugin-git-7e55907cd54a2e91b96d25a660acc6a2a6453f54-e286d0b5
4127 error Cloning into bare repository 'C:\Users\peterson_t\AppData\Roaming\npm-cache_git-remotes\git-github-com-webpack-compression-webpack-plugin-git-7e55907cd54a2e91b96d25a660acc6a2a6453f54-e286d0b5'...
4128 error If you need help, you may report this error at:
4128 error     <https://github.com/npm/npm/issues
log.txt

4129 verbose exit [ 1, true ]
Mention any other details that might be useful.

Thanks! We'll be in touch soon.

This is caused by Line 58 of the package.json, and is actually an NPM issue.
The line in question:
"compression-webpack-plugin": "github:webpack/compression-webpack-plugin#7e55907cd54a2e91b96d25a660acc6a2a6453f54"
I say this is an NPM issue because NPM is doing exactly what it's expected to, but hasn't considered your use. This may work as a replacement for you: "compression-webpack-plugin": "git+https://github.com/webpack/compression-webpack-plugin#7e55907cd54a2e91b96d25a660acc6a2a6453f54"

I'm not sure that is the only issue.  I now get a network tunnel error.
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\peterson_t\AppD
ata\Roaming\npm\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v4.6.0
npm ERR! npm  v3.10.8
npm ERR! code ECONNRESET
npm ERR! network tunneling socket could not be established, statusCode=400
npm ERR! network This is most likely not a problem with npm itself
npm ERR! network and is related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settin
gs.
npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
npm ERR! Please include the following file with any support request:
npm ERR!     c:\WebstormProjects\AngularTest\npm-debug.log
I've setup the config files based on what was stated by others:
.npmrc config file as follows
proxy=http://domain%5Cusername:password@xxx.xx.xx.xxx:xxxx
https-http://domain\username:password@xxx.xx.xx.xxx:xxxx
registry=https://registry.npmjs.org
strict-ssl=false
note I need to use https for the registry config because I receive a json parse error
.gitconfig file as follows
[credential]
helper = manager
[url "https://"]
insteadOf = git:/
[url "https://github.com/"]
insteadOf =<EMAIL_ADDRESS>[http]
proxy = http://domain\username:password@xxx.xx.xx.xxx:xxxx
[https]
proxy = http://domain\username:password@xxx.xx.xx.xxx:xxxx

Well, your git issue isn't the problem this time. The 400 error points to a config error somewhere. You may need strict-ssl set to true.
I'd also talk to your network team and see if they have any custom rules enabled that might prevent NPM from working (Certificate rules, protocol rules, black/whitelists, etc.). They'll have much more context surrounding your environment than anyone here will.

A quick follow up, the webpack team is aware of this and is working on publishing this particular project to npm.

Have you tried setting https_proxy and https_proxy environment variables in Windows? That's how it works for me. Git fun really not Angular-CLI fault.
Ensure you can npm install and git clone from Github to make sure your settings work.


[Camera]Hopefully the camera package will add frame processing. For example, I want to use iOS CoreImage to process frames.

Use case
I want to process frame in real time.
Proposal
I've been looking around a lot and there doesn't seem to be any such feature yet. Hopefully, you'll consider adding this feature.
Thank you flutter team.

Hi @llli0v0,
Please tell us the problem you are running into that led to you wanting a new feature. And please precisely describe what you would like camera package to be able to do for that. It would be helpful if you give an example you found as well.


openssh: add BRs for check section, patch broken tests

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

OpenSSH package tests currently fail due to missing BuildRequires lines and a couple of broken tests. This commit makes the tests pass.
Change Log

Add useradd and sudo requirements when running check sections
Fix failing regression tests due to a bad "future date"

Does this affect the toolchain?

NO
Test Methodology

Local build of package with RUN_CHECK=y

Opting not to address the remainder of spec linting issues.

Opting not to address the remainder of spec linting issues.


Update api endpoints using v1 to use r0 instead

https://matrix.to/#/!XqBunHwQIXUiqCaoxq:matrix.org/$1493422976620705zgcwk:matrix.org

It's done here (https://github.com/matrix-org/matrix-python-sdk/pull/125/commits/c7c748257376aa71f93c829b9fc8e055ab42cf51) but I'd like to have some consensus on testing before we do this, although I can extract it out into a separate PR I suppose.


Column/Block Paste should be pasted as a block

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:07:25.676Z)
OS Version: Windows_NT x64 6.1.7601
Extensions:

Extension
Author (truncated)
Version

Bookmarks
ale
0.16.0

read-only-indicator
ale
0.6.0

shell-snippets
cds
0.1.2

npm-intellisense
chr
1.3.0

python
don
0.7.0

xml
Dot
1.9.2

reg
ion
0.0.1

ecdc
mit
0.10.3

PowerShell
ms-
1.4.1

vba
spe
1.0.17

shell-launcher
Tyr
0.1.3

sort-lines
Tyr
1.3.0

Steps to Reproduce:

Select any block using Shift+Alt+(MouseDrag)
Copy it using Ctrl+C
Try to paste it anywhere else in the code
It's pasted like a regular lines & not as a block

Reproduces without extensions: Yes/No
Is it possible to include this feature.

+1

Possible dupe of #5940?


Update readme and Cargo.toml

Reason for This PR
Update readme and Cargo.toml files to reflect the experimental status of the crate.
Description of Changes
Provided in commit messages.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any newly added unsafe code is properly documented.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.

Updated PR, please take another look.


Error with "FT_Done_MM_Var", tested in Ubuntu18.04

[ 88%] Linking CXX executable devel/lib/fast_gicp/gicp_kitti
/home/wangshouan/anaconda3/lib/libfontconfig.so.1: undefined reference to `FT_Done_MM_Var'
collect2: error: ld returned 1 exit status
CMakeFiles/gicp_kitti.dir/build.make:430: recipe for target 'devel/lib/fast_gicp/gicp_kitti' failed
make[2]: *** [devel/lib/fast_gicp/gicp_kitti] Error 1
CMakeFiles/Makefile2:350: recipe for target 'CMakeFiles/gicp_kitti.dir/all' failed
make[1]: *** [CMakeFiles/gicp_kitti.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Linking CXX executable devel/lib/fast_gicp/gicp_align
[100%] Built target gicp_align
Makefile:145: recipe for target 'all' failed
make: *** [all] Error 2

[ 88%] Linking CXX executable devel/lib/fast_gicp/gicp_kitti /home/wangshouan/anaconda3/lib/libfontconfig.so.1: undefined reference to `FT_Done_MM_Var' collect2: error: ld returned 1 exit status CMakeFiles/gicp_kitti.dir/build.make:430: recipe for target 'devel/lib/fast_gicp/gicp_kitti' failed make[2]: *** [devel/lib/fast_gicp/gicp_kitti] Error 1 CMakeFiles/Makefile2:350: recipe for target 'CMakeFiles/gicp_kitti.dir/all' failed make[1]: *** [CMakeFiles/gicp_kitti.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [100%] Linking CXX executable devel/lib/fast_gicp/gicp_align [100%] Built target gicp_align Makefile:145: recipe for target 'all' failed make: *** [all] Error 2

I met the same issue with you. Do you have any methods to solve it?


Create a tool for automatic update versions

The aim of the tool, in Python, would be to do the following things.

[ ] Automatically update upstream SCL GitHub repository to the new
[ ] Copy / create a directory structure like is mentioned here https://github.com/sclorg/welcome/blob/master/contribution.md#adding-a-new-version
[ ] It would be nice to run also tests on all architectures, like Fedora, CentOS, RHEL
[ ] Store output into the JSON file. What failed, what was successful
[ ] TBD

example PR: https://github.com/sclorg/s2i-php-container/pull/261/commits

This will be solved by this issue https://github.com/sclorg/container-workflow-tool/issues/10


Passing block to class_property tries to return first assignment in block

The following happened recently on master.
Running this code.
require "logger"
 module Test
   class_property(logger) {
     @@logger ||= begin
       a = 1
       Logger.new(STDOUT)
     end
   }
   Test.logger.info("logme")
 end

returns  class variable '@@logger' of Test must be (Logger | Nil), not Int32
crystal version
Crystal 0.24.0+50 [c9fac5645] (2017-11-14)

LLVM: 4.0.1
Default target: x86_64-apple-macosx

This works correctly in 0.23.1 and worked on 0.24.0 a few days ago so a recent change may have caused this.

Your example shows improper usage of class_getter.
The whole point of lazy getter is not to define @@its_ivar by hand...
Proper version is as follows:
require "logger"

module Test
  class_property(logger) { Logger.new(STDOUT) }
end

Test.logger.info "logme"

@jhass I'd suggest removing those tags since it's neither bug nor it's related to the compiler.

Well, how does it get typed as Int32 though? It should expand to
def self.logger
  @@logger ||= begin
    @@logger ||= begin
      a = 1
      Logger.new(STDOUT)
    end
  end
end

The last expression in the inner begin is Logger.new, so the type of the inner begin expression should be Logger, which makes the type of the inner @@logger ||= expression Logger, which makes the type of the outer begin expression Logger, which makes the type of the outer @@logger ||= expression, Logger. Where do I go wrong?

@jhass indeed, you're right! even though included usage of class_property was improper, below code should compile alright...

@Sija you are correct I was using class_property incorrectly.  I checked the code and saw the block gets assigned to the class variable.  I removed @@logger ||= and my code was working again.
@jhass Thanks for minimizing that code, i now know I was using it incorrectly ,but that particular change in behavior didn't seem right to me.

Both examples now show
$ crystal test.cr
I, [2019-10-13 20:45:26 +03:00 #26218]  INFO -- : logme

$ crystal --version
Crystal 0.31.1 (2019-10-02)

LLVM: 8.0.1
Default target: x86_64-apple-macosx

@vlazar Yes, thanks! It seems to be working fine now. I don't know what fixed it.


Pod Ready and Running Status not correct / not consistent when using StatefulSet

Version:
k3s version v1.17.0+k3s.1 (0f644650)
Describe the bug
I am experiencing wrong or stale status information while testing StatefulSets using three nodes. The Pods are indirectly pinned to hosts via LocalPersistentVolumes. If I shut down a node, the Pods that were running on this node are gone for good and cannot be re-created on another node due to said LocalPersistentVolumes constraints. So far, so good. If I shut down a node, this is quickly noticed:
$ kubectl get nodes
NAME     STATUS     ROLES    AGE   VERSION
node03   Ready      <none>   19d   v1.17.0+k3s.1
node01   Ready      master   19d   v1.17.0+k3s.1
node02   NotReady   <none>   19d   v1.17.0+k3s.1

But the Pod that was running on this node is still reported as Running and Ready:
# kubectl -n vault get pods -o wide
NAME            READY   STATUS    RESTARTS   AGE     IP            NODE     NOMINATED NODE   READINESS GATES
vault-transit   1/1     Running   0          22m     <IP_ADDRESS>   node01   <none>           <none>
vault-0         1/1     Running   0          21m     <IP_ADDRESS>   node01   <none>           <none>
vault-2         1/1     Running   0          21m     <IP_ADDRESS>    node03   <none>           <none>
vault-1         1/1     Running   0          2m59s   <IP_ADDRESS>    node02   <none>           <none>

This also gives the same wrong/stale info:
$ kubectl -n vault get pod vault-1 -o json | jq .status.containerStatuses[0].ready
true

Only this delivers the correct info:
$ kubectl -n vault describe pod vault-1 | grep "^  Ready"
  Ready             False

The headless service for the StatefulSet apparently also already knows that the Pod is gone and offers only two Pod IP addresses instead of three:
# dig +nocmd +noall +answer @<IP_ADDRESS> vault.vault.svc.cluster.local
vault.vault.svc.cluster.local. 5 IN	A	<IP_ADDRESS>
vault.vault.svc.cluster.local. 5 IN	A	<IP_ADDRESS>

If the whole node is down, a Pod running on that Node obviously cannot be "Running" and if it's not "Running", it also cannot be "Ready". Even is this argument did not count, this StatefulSet has a readinessProbe with period 10 seconds and failure threshold of three, so a Pod that is gone should not be ready anymore after 30 seconds.
After a looong period of time, the state changes to "Terminating":
# kubectl -n vault get pods -o wide
NAME            READY   STATUS        RESTARTS   AGE   IP            NODE     NOMINATED NODE   READINESS GATES
vault-transit   1/1     Running       0          31m   <IP_ADDRESS>   node01   <none>           <none>
vault-0         1/1     Running       0          30m   <IP_ADDRESS>   node01   <none>           <none>
vault-2         1/1     Running       0          30m   <IP_ADDRESS>    node03   <none>           <none>
vault-1         1/1     Terminating   0          11m   <IP_ADDRESS>    node02   <none>           <none>

This seems to be the final state., I did not observe further state changes.
To Reproduce
Not sure. Maybe this is already a well-known problem. I just stumbled over this. I guess you need at least two nodes (master and worker), a StatefulSet and node-pinning for its members.
Expected behavior
I would expect kubectl to show correct and consistent data.
Actual behavior
kubectl shows incorrect and inconsistent data.
Additional context
Re-starting the shut-down node works fine without any issues. The vault Pod gets started again automatically. I would personally expect the RESTART count to increase since the name of the Pod has not changed ("vault-1") but in fact the RESTART count is still 0. But I guess this is just a matter of convention. Also, the IP address changes, but this is to be expected for Kubernetes Pods that are being restarted, although somehow unfortunate for StatefulSet members.

Closing as Out of Date. Kubectl information is controlled by upstream.


Rubocop format fixer is causing strange indentation in generated config initialization

Fixed by updating Rubocop to 1.15.


Use pd.Timedelta for time_since_treatment

To represent duration in the time_since_treatment column, we have 2 options:

put numerical values into time_since_treatment and persist the time unit in the metadata [non-intuitive and probably error-prone]
represent duration directly with the pandas dtype Timedelta [preferred]

@jbao Is it OK to label "Help Wanted"?

@LappleApple I think we need more discussion concerning the above 2 options.


sched/pthread: fix memory leak of pthread_tcb_s

Summary
sched/pthread: fix memory leak of pthread_tcb_s
pthread tcb should be released appropriately
Signed-off-by: chao an<EMAIL_ADDRESS>Impact
N/A
Testing
ci-check

@anchao
I noticed that spresense:elf stops with this PR.
Initial memory usage: 6180
Registering romdisk at /dev/ram0

Memory Usage after romdisk_register:
  Before:     6180 After:     6236 Change:       56
Mounting ROMFS filesystem at target=/mnt/romfs with source=/dev/ram0

Memory Usage after mount:
  Before:     6236 After:     6796 Change:      560

****************************************************************************
* Executing errno
****************************************************************************

Memory Usage after exec:
  Before:     6796 After:    10196 Change:     3400
Hello, World on stdout
Wait a bit for test completion
Hello, World on stderr
We failed to open "aflav-sautga-ay!" errno is 2

If I revert this PR, it works.
Initial memory usage: 6204
Registering romdisk at /dev/ram0

Memory Usage after romdisk_register:
  Before:     6204 After:     6260 Change:       56
Mounting ROMFS filesystem at target=/mnt/romfs with source=/dev/ram0

Memory Usage after mount:
  Before:     6260 After:     6820 Change:      560

****************************************************************************
* Executing errno
****************************************************************************

Memory Usage after exec:
  Before:     6820 After:    10220 Change:     3400
Hello, World on stdout
Wait a bit for test completion
Hello, World on stderr
We failed to open "aflav-sautga-ay!" errno is 2

Memory Usage after program execution:
  Before:    10220 After:     9052 Change:    -1168

****************************************************************************
* Executing hello
****************************************************************************

Memory Usage after exec:
  Before:     9052 After:    10252 Change:     1200
Getting ready to say "Hello, world"
Wait a bit for test completion

Hello, world!
It has been said.

argc	= 1
argv	= 0x2d030118
argv[0]	= (0x2d030120) "hello"
argv[1]	= 0
Goodbye, world!

Memory Usage after program execution:
  Before:    10252 After:     9052 Change:    -1200

****************************************************************************
* Executing hello++1
****************************************************************************

Memory Usage after exec:
  Before:     9052 After:     9996 Change:      944
Hello, World!
Wait a bit for test completion

Memory Usage after program execution:
  Before:     9996 After:     9052 Change:     -944

****************************************************************************
* Executing hello++2
****************************************************************************

Memory Usage after exec:
  Before:     9052 After:    10556 Change:     1504
main: Started.  Creating MyThingSayer
Wait a bit for test completion
CThingSayer::CThingSayer: I am!
main: Created MyThingSayer=0x2d02ff20
main: Calling MyThingSayer->Initialize
CThingSayer::Initialize: When told, I will say 'Hello, World!'
main: Calling MyThingSayer->SayThing
CThingSayer::SayThing: I am now saying 'Hello, World!'
main: Destroying MyThingSayer
CThingSayer::~CThingSayer: I cease to be
CThingSayer::~CThingSayer: I will never say 'Hello, World!' again
main: Returning

Memory Usage after program execution:
  Before:    10556 After:     9052 Change:    -1504

****************************************************************************
* Executing hello++3
****************************************************************************

Memory Usage after exec:
  Before:     9052 After:    10636 Change:     1584
CThingSayer::CThingSayer: I am!
Wait a bit for test completion
main: Started.  MyThingSayer should already exist
main: Calling MyThingSayer.Initialize
CThingSayer::Initialize: When told, I will say 'Hello, World!'
main: Calling MyThingSayer.SayThing
CThingSayer::SayThing: I am now saying 'Hello, World!'
main: Returning.  MyThingSayer should be destroyed

Memory Usage after program execution:
  Before:    10636 After:     9052 Change:    -1584

****************************************************************************
* Executing mutex
****************************************************************************

Memory Usage after exec:
  Before:     9052 After:    10676 Change:     1624
Starting thread 1
Wait a bit for test completion
Starting thread 2
Stopping threads
	Thread1	Thread2
Loops	10	10
Errors	0	0

Memory Usage after program execution:
  Before:    10676 After:    11308 Change:      632

****************************************************************************
* Executing pthread
****************************************************************************

Memory Usage after exec:
  Before:    11308 After:    10572 Change:     -736
PARENT: started
Wait a bit for test completion

PARENT: calling pthread_start with arg=305419896
CHILD: started with arg=305419896
CHILD: returning -2023406815
PARENT child exitted with -2023406815
PARENT returning success

Memory Usage after program execution:
  Before:    10572 After:    11308 Change:      736

****************************************************************************
* Executing signal
****************************************************************************

Memory Usage after exec:
  Before:    11308 After:    11692 Change:      384
Setting up signal handlers from pid=12
Wait a bit for test completion
Old SIGUSR1 sighandler at 0
New SIGUSR1 sighandler at 0xd030389
Old SIGUSR2 sighandler at 0
New SIGUSR2 sighandler at 0xd030389
Raising SIGUSR1 from pid=12
Kill-ing SIGUSR1 from pid=12
siguser_action: Received signo=10 siginfo=0x2d02e518 arg=0
  SIGUSR1 received
siginfo:
  si_signo  = 10
  si_code   = 0
  si_errno  = 4
  si_value  = 0
SIGUSR1 raised from pid=12
SIGUSR1 not received

Memory Usage after program execution:
  Before:    11692 After:     9188 Change:    -2504

****************************************************************************
* Executing struct
****************************************************************************

Memory Usage after exec:
  Before:     9188 After:    10628 Change:     1440
Calling getstruct()
Wait a bit for test completion
getstruct returned 0xd02fd70
  n = 42 (vs 42) PASS
  pn = 0x2d02fd88 (vs 0x2d02fd88) PASS
 *pn = 87 (vs 87) PASS
  ps = 0xd02fd6c (vs 0xd02fd6c) PASS
  ps->n = 117 (vs 117) PASS
  pf = 0xd02fb79 (vs 0xd02fb79) PASS
Calling mystruct->pf()
In dummyfunc() -- PASS
Exit-ing

Memory Usage after program execution:
  Before:    10628 After:     9188 Change:    -1440

****************************************************************************
* Executing task
****************************************************************************

Memory Usage after exec:
  Before:     9188 After:    10924 Change:     1736
Parent: Started, pid=15
Wait a bit for test completion
Parent: Calling task_create()
Parent: Waiting for child (pid=18)
Child: execv was successful!
Child: argc=2
Child: argv[0]="child"
Child: argv[1]="Hello from your parent!"
Child: Exit-ting with status=0
Parent: Exit-ing

Memory Usage after program execution:
  Before:    10924 After:    11420 Change:      496

Memory Usage End-of-Test:

@anchao

I noticed that spresense:elf stops with this PR.

sabre-6quad:elf (qemu) also stops.
/home/ishikawa/opensource/QEMU/qemu-8.2.0/build/qemu-system-arm -semihosting -M sabrelite -m 1024 -smp 4 -kernel nuttx -nographic
Initial memory usage: 6228
Registering romdisk at /dev/ram0

Memory Usage after romdisk_register:
  Before:     6228 After:     6284 Change:       56
Mounting ROMFS filesystem at target=/mnt/romfs with source=/dev/ram0

Memory Usage after mount:
  Before:     6284 After:     6844 Change:      560

****************************************************************************
* Executing errno
****************************************************************************

Memory Usage after exec:
  Before:     6844 After:    10236 Change:     3392
Wait a bit for test completion
Hello, World on stdout
Hello, World on stderr
We failed to open "aflav-sautga-ay!" errno is 2


Allow authentication to zpagov.net

Community Note
Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment
Description
Request that you add the Gov Cloud as an option for zpa_cloud:  https://config.zpagov.net/

Hi @elusivesecurity
I am actually looking into it and we may be able to add support for it may be included in the next release ~v2.2.x
There are a couple other things you will need to do beyond replacing the endpoint URL.
Please see the updated files in the Gist repo and place them in the respective directories:
gozscaler/config.go
zpa/provider.go
Once you do that, navigate to the zpa directory via command prompt and run make build13 to compile the provider.
Authentication:
You can then authenticate via environment variables using the following parameters:
export ZPA_CLIENT_ID      = "xxxxxxxxxxxxxxxx"
export ZPA_CLIENT_SECRET  = "xxxxxxxxxxxxxxxx"
export ZPA_CUSTOMER_ID    = "xxxxxxxxxxxxxxxx"
export ZPA_CLOUD    = "GOV"
Happy to setup sometime with you to discuss it in more details just email me at wguilherme@ You know the rest. ;)

This worked, thanks!  And I forgot to mention in my first post, but thanks for making these providers!


BUG infinite request on (change)

I succed to use your module, FINALLY ! :)
I simply use your demo  to load more chunk when scrolling but it seems big bug when scroll fast or drag scrollbar until bottom, look here my gif:

code:
exactly the same  as your demo
browser:
bug on chrome and firefox

Related to #19. Working on it.

Nice, i cant wait !!! :-D

the way I have worked around this is only do the next fetch of chunk when I have not requested the previous starting point in chunk...
to elaborate, i created a set of values going into the below method, if my set size increases while while adding the element to the set, then i call the below, else i don't fetch the next chunk.
this.fetchNextChunk(this.buffer.length, 10)
this has worked for me, in not fetching duplicates. hope this gives some ideas to avoid the duplication, until it is fixed in the library by rintoj.
good work otherwise Rintoj! thanks!

@istiti, @gnasit, Thanks for helping me with this issue. I have added two new events: start and end. Recommend you to use end instead of change.
Please see the updated documentation

Fix is available with v0.1.3


Refine Layer Idea

Often DI is used to connect the bigger structures within an application. Classically developers think in architectural layers like

business logic
business data (entities)
Micro-Services
Use-Cases (system functions, services)
Controllers/Presenters/Gateways
UI / DB / external interfaces

Almost in all cases we want to enforce strict layering between those and when defining dependencies we want to make things available just within one or some layers but not in others. Or we want to get service decorations or interceptors for all services within one layer but not the other.
So it should be possible to model/describe this during the bind process quite simple and straight forward.

Packages are good enough. One could use them to model layers as long as the code is packaged somehow in layers as well.


SAK-33634 generate anonymous id

Taking a substring from the internal id, like it was done before.
Adding the i18n anon string when needed, instead of by default (to avoid adding a resourcebundle entry inside the API).

Ok, I did as you told: have removed the field from database and used the submission id. LGTM


is ledisdb 100% api compatible with redis?

I am using a software that uses redis as backend.
I need to use a redis compatible disk based store  as backend for that software, due to redis memory issues.
is ledisdb 100% api compatible with redis?

No, ledisdb is not redis :-)


added 'uses: msys2/setup-msys2@v2' to cmake.yml

fix: missing  'uses: msys2/setup-msys2@v2'  added to example/cmake.yml

thanks!


Matching constructor causes a crash

I have this code
int getX() { return 0; }

class Foo {

	Foo(int x, int y);

	int getX();
	int getY(){return m_y;};

	int m_x;
	int m_y;
};

int Foo::getX() const { return m_x; }

Foo::Foo(int x, int y)
	:m_x(x)
	,m_y(y)
	{}

but when I do this query
Foo::Foo(_){_;}

I get the following crash
thread '<unnamed>' panicked at 'begin <= end (166 <= 165) when slicing `
int getX() { return 0; }

class Foo {

        Foo(int x, int y);

        int getX();
        int getY(){return m_y;};

        int m_x;
        int m_y;
};

int Foo::getX() const { return m_x; }

Foo::Foo(int x, int y)
        :m_x(x)
        ,m_y(y)
        {}
`', /home/brad/.cargo/registry/src/github.com-1ecc6299db9ec823/weggli-0.2.3/src/result.rs:79:20
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

If I move the constructor back into the class then I don't get a match or crash
int getX() { return 0; }

class Foo {

	Foo(int x, int y)
		:m_x(x)
		,m_y(y)
		{}

	int getX();
	int getY(){return m_y;};

	int m_x;
	int m_y;
};

int Foo::getX() const { return m_x; }

produces no match with the same query as before
Foo::Foo(_){_;}

I've also tried
$foo::$foo(_){_;}

to match all constructors and I think it matches but also crashes

Thanks for the detailed bug report!
I'm pretty sure that I know where the issue is. I'll take a look

Sorry I forgot to ping this issue, but this should be fixed now.
weggli -X 'Foo::Foo(_){}' /tmp/test.cpp
/tmp/test.cpp:17
Foo::Foo(int x, int y)
	:m_x(x)
..
	{}


vault: fix build for darwin

Motivation for this change
Closes #129443
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @jonringer @manveru

@jonringer changed to use isLinux, and same change made to vault-bin

Result of nixpkgs-review pr 129447 at e0cda370 run on aarch64-linux 1

2 packages built successfully:

vault
vault-bin


created apps.py in root folder to override the default admin site

Sir,
the earlier code was not working in Django 3.2 and was raising following error...
RuntimeError: 'reviews.apps' declares more than one default AppConfig: 'AdminConfig', 'ReviewsAdminConfig'
after removing parts of code under reviews/apps.py to rool folder under apps.py its working fine.
also now comment8or project will work in django 3.2

Thank you for this, I had been looking elsewhere online and hadn't found an answer. I didn't think to look here at first.

Finally! It works


Fixing Issue #227 (Zero-Termination of Login and Password Arrays)

Affected files:
AuthHandler.cpp and AuthHandler.h
Additions/modifications proposed in this pull request:

Zero-Terminate the login and password arrays of ev casted as a LoginRequest

Suggestions to save more coding space:

Maybe make it so that we don't have to call the function before every return (Call the function inside the switch case instead?)

Will close #227 (issues links in titles won't automagically link issues to PRs 😢)
Awesome PR! Thanks for submitting eos428!
Left some notes for you in discord regarding calling your zero_term method once at the top of on_login(). Take a look there.
Other than that, we'll wait for the CI builds, and I'll Nem review this, as he's more familiar with the authserver structure than I am, and may have feedback.
Again, great work! Welcome to SEGS!

Things are fine on my end. Go ahead and merge :D


node deposit.js [YOUR_SOLANA_ADDRESS] 0x7C9e161ebe55000a3220F972058Fb83273653a6e [AMOUNT_IN_GWEI] [FEE_IN_GWEI] [ETHEREUM_PRIVATE_KEY] https://rpc.sepolia.org

Hi, you need to replace those information inside the square bracket to your own wallet address, and it should work

I've created a repository that ensures a seamless experience without the need for any code editing
https://github.com/duongnq2798/testnet-deposit/tree/feat-deposit-cli


Tight coupling to jQuery version

Built with jQuery 2.2.4, demo page using 2.2.3 => '$(...).beverages()' is not a function

False diagnostic: the problem came from fixing the deployment of index.html: this uses a relative path that was incorrect after applying the make script.


Fix undefined logins

Details
Fixes the error below:

Fixed Issues
$ https://github.com/Expensify/App/issues/22273
Tests

Request money from a user you haven't chatted with before
Notice the app doesn't crash

[ ] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
N/A

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/22219519/df4ed7a7-943a-442a-abd0-caa86877f14e

Mobile Web - Chrome

Mobile Web - Safari
https://github.com/Expensify/App/assets/22219519/aa8feb34-989f-4843-a8e7-50686f5d672f

Desktop
https://github.com/Expensify/App/assets/22219519/80fb850e-b010-4b79-842b-2561c66f3d65

iOS
https://github.com/Expensify/App/assets/22219519/5fb5ad68-017d-4469-a759-6a8b066f99fd

Android
Uploading android.mov…

I think we can close this PR, since we're reverting the offending one here https://github.com/Expensify/App/pull/22303


Debug OauthService Account scopes

Check if the user gave us sufficient scopes in the account:
Scenarios:

The user signed up without the read email scope and the oauth consent screen did not ask for adding new scopes
The user didn't check the boxes in the oauth consent screen

Business logic:

Don't add accounts with insufficient scopes
Explain to the user why the specific scopes are required and let it retry or cancel adding account.

https://github.com/tiki/strategy_google/issues/75 will create the designs.


move history file

close #2030

You're awesome, @antarus !
I didn't expect a fix so fast. Thanks a lot :)

it was a small modification :D


Deploy new ember image to test (resolves userToken issue #85)

Here is a new version of ember to be deployed to test for testing. This should fix the userToken issue documented in #85 and restore the new user fields.
oapass/ember:20181127-aec1ef8@sha256:7365cc4b1149907cfbfeb4bcad678b5146dc6c28ab025d94d09bb889759d1ed5

done


Counseling on the loss of physical properties

Hello, after I customize a substance using the following code, I find the following properties are missing through Sugar_model.get_missing_properties(). Do all the following missing properties need to be completed (as follows)?
Does the absence of 'Dortmund', 'UNIFAC', 'PSRK' affect the accuracy of the results? Does the absence of iscyclic_aliphatic affect the accuracy of the results?
Sugar_model=bst.Chemical('Sugar_model',
                  default=True,
                  search_db=False,
                  formula='C10H15O3',
                  Tb=350.7+273.15,
                  Hvap=82035.54660,
                  phase_ref="l",
                  Tm=70+273.15,
                  Hfus=29600,
                  Hf=-790760,
                  Tc=580,
                  Pc=2500002,
                  Vc=0.0005)

The following missing properties are as follows.
['Dortmund',
 'UNIFAC',
 'PSRK',
 'Pt',
 'dipole',
 'Sfus',
 'iscyclic_aliphatic',
 'Tm',
 'similarity_variable',
 'Tt',
 'sigma',
 'epsilon',
 'omega']

Hello, for custom substances, due to the lack of 'Dortmund','UNIFAC', 'PSRK', I added them through the code Sugar_model.Dortmund = {'CH3': 2, 'CH2': 3}, but error AttributeError: can't set attribute 'Dortmund' will report. A lack of Dortmund seems to lead to a lack of ActivityCoefficients (https://biosteam.readthedocs.io/en/latest/API/thermosteam/equilibrium/activity_coefficients_module.html#thermosteam.equilibrium.activity_coefficients.DortmundActivityCoefficients:~:text=Create a DortmundActivityCoefficients that estimates activity coefficients using the Dortmund UNIFAC group contribution method when called with a composition and a temperature (K).).

@zasddsgg,
You can use the <GroupCounts>.set_group_counts_by_name method.
Sugar_model=bst.Chemical('Sugar_model',
                  default=True,
                  search_db=False,
                  formula='C10H15O3',
                  Tb=350.7+273.15,
                  Hvap=82035.54660,
                  phase_ref="l",
                  Tm=70+273.15,
                  Hfus=29600,
                  Hf=-790760,
                  Tc=580,
                  Pc=2500002,
                  Vc=0.0005)

@yoelcortes, Hello, could you please take some time to look at this problem.


Add -T command-line option to hb-service.

As discussed in Discord: to suppress timestamps in the log output.  Useful in combination with --sdtout when logging using systemd.
I hope this is OK.  I ran npm run test:e2e:
Test Suites: 18 passed, 18 total
Tests:       180 passed, 180 total
Snapshots:   0 total
Time:        33.624 s

Thanks!


Add a Debian -r bookworm

Please paste the output of the following command here: sudo edit-chroot -all

Please describe your issue:
Any chance of adding Debian bookworm release.
Thank you.
If known, describe the steps to reproduce the issue:

Is there even a build of bookworm out? I don't think you would want to build it on hardware that is as low powered as a Chromebook...

Much appreciated.


sets baseUrl from data supplied by background.js rather than deriving it

fixes #62

          1 Warning

:warning:
manifest is not changed, forget to bump version?

  Generated by :no_entry_sign: Danger

I don't have a corporate environment so I can not test the change but it works perfect in common script and inbound script so LGTM


Quest - Update QR display and edit functionality with performant option

Previously, we had to use population just to correctly map the QuestionnaireResponse and Questionnaire due to missing answers. However, this seems to have been fixed here and we can revert to providing the QuestionnaireResponse as it is

After reafctoring and removing some code on fhircore it is found that ResourceMapper has some code to init fhir-path that is now taking time for first time init. Once First time init is done it works fast.
  private val fhirPathEngine: FHIRPathEngine =
    with(FhirContext.forR4()) {
      FHIRPathEngine(HapiWorkerContext(this, DefaultProfileValidationSupport(this)))
    }

SDK -> questionnaire-viewmodel -> L83 -> QuestionnaireResponseValidator -> L104 causes app crash due to assertion which does not handle the case if url is null
require(
      questionnaireResponse.questionnaire == null ||
        questionnaire.url == questionnaireResponse.questionnaire
    ) {
      "Mismatching Questionnaire ${questionnaire.url} and QuestionnaireResponse (for Questionnaire ${questionnaireResponse.questionnaire})"
    }

https://github.com/google/android-fhir/pull/1106 PR on SDK to use cached fhir-context in code

Login screen with app loaded with FhirContext and FhirPathEngine
Total = 591.84 Megabytes
FhirContext = 67+ MB
FhirPathEngine = 100+ MB

Without FhirPathEngine it is brought down to BUT this means that QuestionnaireActivity would take time
Total = 8.3787 Megabytes


bug(Timepicker): Timepicker design against Material 3 specifications

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
The Timepicker we got with @angular/material 19 doesn't look like it should be according to the Material 3 specifications.
Reproduction
Right now it's more like a select list with different times: https://material.angular.io/components/timepicker/overview
But this is far away from the Material specifications and I don't think it's a good UI/UX experience either.
Expected Behavior
The Timepicker should work, look and feel like described in the official material specifications over here: https://m3.material.io/components/time-pickers/overview.

I also found this open source example which I would expect it to be: https://dev.to/dhutaryan/a-new-material-timepicker-component-51aj
Actual Behavior
It doesn't look like in the specifications, and I think this is not the UI quality most of us expect from the material components.
Environment

Angular: 19.0.0
CDK/Material: 19.0.0
Browser(s): Every Browser
Operating System (e.g. Windows, macOS, Ubuntu): Every operating system

highly support this issue! i would love to get a proper timepicker. The current one is a joke.

would love to have a nice timepicker instead of a select list!

This design is primarily geared towards mobile users on Android. It would look out of place in the desktop-focused enterprise UIs that a lot of Angular developers build.

If Angular really would keep enterprice in mind, we would not have to rewrite our whole application to signals.

Is it though once angular becomes zoneless?

@crisbeto How about 2 appearances/modes maybe? then the devs could decide themselves which one they wanna use.
I think there are many more people that would love have the modern material variant.


baseN start from last

Hi. I'm using baseN to create a combinations from 10 elements(numbers and letters).
I save each array to a file.
Can i somehow start with the last array if I stop generating combinations?

Hi, i'm getting out of memory error when i'm trying to create a 11x11 array.
Can you share your code to help me fix this error?
Thanks.

Now that js-combinatorics is completely (and incompatibly :-) rewritten, I will close this issue for the time being. if you still have the same problem w/ newer version, please open a new issue.


Add missing .coverage report to artifacts

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.87%. Comparing base (fae5d37) to head (517509c).
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   99.87%   99.87%
=======================================
  Files           7        7
  Lines         828      828
=======================================
  Hits          827      827
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Correct file format on original image for G000591

While I was working on #168, I noticed an erroneous filetype for one of the original images. Currently, the image url for Rep. Michael Guest (G000591) is broken because the file has a ".jpeg" extension.
This is the current (broken) link: https://theunitedstates.io/images/congress/original/G000591.jpeg
It should be: https://theunitedstates.io/images/congress/original/G000591.jpg
This PR renames that image to make it consistent with all the others.

[x] I'm acknowledging that my submission is free of all known copyright in at least the United States. (In general, works of the federal government should satisfy this criteria.)

Good spot, thanks!


HADOOP-19278. remove marker delete option

The options to delete markers everywhere or under authoritative paths have been removed.
Markers on parent paths will never be deleted after any file creation.

Removes a lot of production code
testing can cut out a lot of parameterized tests, especially on costed operation.
Lines up for pushing more code down into S3AStore (but does not do this)

How was this patch tested?

Marker tool tests all failing.

For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 30 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 42s

trunk passed

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 21s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 22s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 48s

trunk passed

+1 :green_heart:
shadedclient
20m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 13s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 16s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javac
0m 16s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
compile
0m 15s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-1 :x:
javac
0m 15s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 13s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 14 new + 6 unchanged - 0 fixed = 20 total (was 6)

-1 :x:
mvnsite
0m 15s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

-1 :x:
spotbugs
0m 13s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
shadedclient
21m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 16s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

80m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7052

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint

uname
Linux 6943262c450a 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 537218c009cf90274d82622f909e6725137f8d6a

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/1/testReport/

Max. process+thread count
715 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 34 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 36s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m 13s

trunk passed

+1 :green_heart:
shadedclient
40m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 28s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 22s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 2 new + 8 unchanged - 0 fixed = 10 total (was 8)

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

-1 :x:
spotbugs
1m 16s
/new-spotbugs-hadoop-tools_hadoop-aws.html
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
39m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 47s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

144m  8s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-aws

Dead store to len in org.apache.hadoop.fs.s3a.S3AFileSystem.executePut(PutObjectRequest, Progressable, PutObjectOptions, File)  At S3AFileSystem.java:org.apache.hadoop.fs.s3a.S3AFileSystem.executePut(PutObjectRequest, Progressable, PutObjectOptions, File)  At S3AFileSystem.java:[line 4256]

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7052

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint

uname
Linux 7454999a83f3 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 04844d56faae15bb125af0804d25eb1130fa6cb5

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/2/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 34 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
0m 55s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
4m  2s
/branch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-aws in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
compile
0m 23s
/branch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-aws in trunk failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-0 :warning:
checkstyle
0m 20s
/buildtool-branch-checkstyle-hadoop-tools_hadoop-aws.txt
The patch fails to run checkstyle in hadoop-aws

-1 :x:
mvnsite
0m 23s
/branch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in trunk failed.

-1 :x:
javadoc
0m 23s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-aws in trunk failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javadoc
0m 24s
/branch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-aws in trunk failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

+1 :green_heart:
spotbugs
2m 37s

trunk passed

+1 :green_heart:
shadedclient
3m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 23s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 43s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0)

-1 :x:
mvnsite
0m 34s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javadoc
0m 34s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-1 :x:
spotbugs
0m 23s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
shadedclient
5m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 26s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

21m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7052

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint

uname
Linux e1067983ef5b 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c02d320e8113e16ace5be73efa5b8e44df22328d

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/3/testReport/

Max. process+thread count
88 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 35 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  7s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 46s

trunk passed

+1 :green_heart:
shadedclient
20m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 16s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

hadoop-tools/hadoop-aws: The patch generated 0 new + 13 unchanged - 6 fixed = 13 total (was 19)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 41s

the patch passed

+1 :green_heart:
shadedclient
22m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  9s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 25s

The patch does not generate ASF License warnings.

92m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7052

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint

uname
Linux 92acfa517382 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eadce2a72d357d8bd45ea460b2f84c3b5adb2419

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/4/testReport/

Max. process+thread count
727 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7052/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

This is good for review. Nice purge of outdated stuff, simpler docs, and with lots of tests deparameterized: faster test runs. What not to like?
@mukund-thakur @ahmarsuhail @shameersss1 @saikatroy038 @HarshitGupta11

Great effort @steveloughran for taking this one out. Removing legacy code and making the code base clean.


Fix crash in UpgradeChart when upgrading fails

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>

Closing this and making a new PR with better tests and based on #5810


[Spike] Proposal document for Views feature

There are major headwinds for the security to invest in the Views Feature [1] that has been created, lets

[1] https://github.com/opensearch-project/OpenSearch/issues/6181

Exit Criteria

[x] Create a high level feature document
[x] Reviewed and alignment with stakeholders
[x] Create a meta issue with rough outlinining

Meta https://github.com/opensearch-project/security/issues/3873


Restrict internet access from siren container

Objective
Security harden, specifically by restricting egress traffic from the siren container unless to approved destinations.

I added some small nitpicks, feel free to revert them!
question; this does not expose over SSL currently, right?
as that would create a new security hole while patching another one:
one of the main issues we faced initially is that a user would have to send their session password in plaintext to Siren.

@antondlr

question; this does not expose over SSL currently, right?

Yes, the primary objective of this PR is getting the egress restrictions in place.

one of the main issues we faced initially is that a user would have to send their session password in plaintext to Siren.

Preventing the exfiltration of sensitive data (eg, keys) from the container can largely be achieved using egress rules. But from the browser is another another kettle of fish.  I

@antondlr

it would also be nice to use the same template for nginx_proxy.conf.template and siren-http{,s}.conf, manipulating the template can be done from docker-assets/docker-entrypoint.sh

Yeah I considered that, but I also wanted to avoid changing the existing siren image, and instead try to wrap it in nice warm security blank.
I would like to explore improving this, and also starting nginx in a lifecycle hook and then running the container with less perms.
I suggest we explore this in a new issue.

Preventing the exfiltration of sensitive data (eg, keys) from the container can largely be achieved using egress rules. But from the browser is another another kettle of fish. I

yeah so, taking a step back here and looking at which dangers actually exist, I think securing browser-siren traffic is paramount because once the SESSION_PASSWORD has leaked, it's game over, and it's a more viable attack vector. I'm definitely not against restricting egress traffic from the container, I think it makes a lot of sense, but not at the cost of sacrificing the current ssl-by-default setup. happy to talk about it / be convinced otherwise!
so the question is... how do we do both?

I also wanted to avoid changing the existing siren image

feel free to go ham on the exiting image :-)


installed_languages should not be required

Making installed_languages required in schema IMO doesn't make sense since it's not required in user settings because it's inherited from default settings so not having it should not raise a warning.
https://github.com/sublime-treesitter/TreeSitter/blob/20ffa941686ad7698f9daee24fc4b28a7202e3c7/sublime-package.json#L110

Agreed, thanks for catching this. This is fixed in https://github.com/sublime-treesitter/TreeSitter/releases/tag/1.5.1