[flutter_tools] Ensure service worker starts caching assets since the very first load

As a performance improvement, this PR ensure service worker starts caching assets since the very first load by calling self.clients.claim(),
Fixes: https://github.com/flutter/flutter/issues/115336
This is how the service worker behaves now:

Load page for the first time, and service worker gets installed
Request asset cat.jpg and service worker caches it right away
Load the page for the 2nd time and it must be taken from the cache.

https://user-images.githubusercontent.com/79719460/201992435-843172da-3f5e-4904-afd5-e8c53b47853f.mp4
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I updated existing tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

@ditman can you take a look at this one?

Ha, the tests that are failing are doing so because this is working better now, for example:

location ['main.dart.js'] is <1> instead of <2>

That number is "the number of times it was downloaded from the server", which kinda makes sense is 1 now. I'll review the tests to make sure we're not introducing anything nefarious (like an un-updateable service worker or similar :P)

Hi, @ditman I updated those integration test to expect fewer requests, now they are passing,
The test that failed in this check didn't failed in the previous commit which makes me think it's flaky, or did I really break something 😅?

@davidlanderos-digital thanks! I'm finishing something urgent, but this notification is living in my Notifications forever now, until I review it. I want to also bring this up with the web team so they can take a second look (ETA for a decision: week 48!)

friendly ping @ditman

Let's go!

@davidlanderos-digital I'm sorry, but I "Google testing" is stuck because of an infrastructure issue. Could you rebase upstream and push again?

@christopherfujino Hi, this PR is messed up because of the rebase, i'm closing it in favor of a this new PR https://github.com/flutter/flutter/pull/116833


Updated readme to have better readability

Short Description:
Updated readme to have better readability
Fixes:
-Updated readme to have better readability

Thanks for contributing!
:+1:


Introducing cache to speed up runner

@arorajatin Adding dependencies cache to speed up execution.
Changes are still untested, I will confirm these after testing them. Then you can merge.

@arorajatin Tested the changes, please review it
Mainly these changes are to fix following warning coming during workflow execution.
INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance. If you want to abort this run, press Ctrl + C.


OAK-9874 (unit test only) - Add a (failing and @Ignored) unit test to check that queries return same result with and without index.

The unit tests in this PR reproduces the issue in OAK-9874

nitpicking: May be we should add common in SameQueryResultsWithAndWithoutIndexTest, to indicate that it is a common test for both lucene and elastic.

@thomasmueller suggested removing the Common from the names of the tests. I'm fine with either option, but let's agree on one naming pattern.

nitpicking: May be we should add common in SameQueryResultsWithAndWithoutIndexTest, to indicate that it is a common test for both lucene and elastic.

@thomasmueller suggested removing the Common from the names of the tests. I'm fine with either option, but let's agree on one naming pattern.

Given that a lot of tests are there that still need to be ported - I would suggest to have some identifier that would suggest that these tests have already been ported simply by looking at the class name itself.

nitpicking: May be we should add common in SameQueryResultsWithAndWithoutIndexTest, to indicate that it is a common test for both lucene and elastic.

@thomasmueller suggested removing the Common from the names of the tests. I'm fine with either option, but let's agree on one naming pattern.

Given that a lot of tests are there that still need to be ported - I would suggest to have some identifier that would suggest that these tests have already been ported simply by looking at the class name itself.

After talking with Thomas, I have renamed the test to include Common in the name.


keypress for left or right should not trigger when in input boxes

If you are in an input box, such as the search bar, and you click the left arrow, you are redirected to the previous page. This functionality comes from lines 226-239 of the learn.js file:
 jQuery(document).keydown(function(e) {
      // prev links - left arrow key
      if(e.which == '37') {
        jQuery('.nav.nav-prev').click();
        alert('handler for left arrow triggered in learn');
      }

      // next links - right arrow key
      if(e.which == '39') {
        jQuery('.nav.nav-next').click();
          alert('handler for right arrow triggered in learn');
      }
    });

This functionality should be disabled for input boxes because a user would expect a left or right arrow key to only move the typing cursor.
jQuery('input').keydown(function (e) {
         //  left and right arrow keys
         if (e.which == '37' || e.which == '39') {
             e.stopPropagation();
         }
     });

Nice catch. Would you be able to submit this in a pull request?


"Properties" from shadow edpoints should be present in __layout.svelte

Describe the problem
Heres a route

The shadow endpoint (index.js) exports a property that is available to the index.svelte. But the property is not available to __layout.svelte
Files:
tlayout.zip
Describe the proposed solution
Make properties available in __layout.svelte to make the experience the same and not having to use load
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response

That would be a change to Svelte-Kit's design, where layout components run before the other components in the file. Shadow endpoints are meant to be equivalent to writing a load() function in their corresponding component, i.e. the handlers in index.js should be at the same level of the hierarchy as the load() function of index.svelte. Since __layout.svelte can pass data down to index.svelte via the stuff parameter, obviously the layout code must run before the index.svelte code and therefore cannot use any of index.svelte's results, or there would be a circular (and infinite) loop.
So while I'm not Rich Harris and can't read his mind, I'm quite confident that this feature request will not be implemented. I'll leave this issue open for a few more days to let others chime in if they disagree, with reasons why the design of shadow components should be changed. But I expect I'll be closing this issue sometime next week.

The only way is to get the data in getSession that way:
// src/hooks.js
/** @type {import('@sveltejs/kit').GetSession} */
export function getSession(event) {
  if (event.url.pathname == '/todos') {
    const data = 'urlSessionXData'; //getData(event.url.pathname);
    return { [event.url.pathname]: data };
  }
}

layout prop from session if pathname: {hello}

Because only from getSession can you directly pass data to __layout.svelte.

@rmunn I see what you mean but I thought of the handler as something that provided the shadow endpoints to everything in the request - just as getsession does. See @lukaszpolowczyk workaround

The layout docs say "there are elements that should be visible on every page". So I figured that if a dev want something available on every page, layouts is the place. But I think what is being said here is the "if you want data on every page then layouts is not the place". As a dev, I don't care what runs first but I do want data from endpoint available everywhere. Or is that place a store. Either way, I suggest layout docs be updated to say that __layout.js and "shadow" eindpoint is not supported.

I successfully moved to getsession.
I vote for data being avail to layouts. It makes sense to me to think of it as request level data

Layouts are for things common to every page. Pages' props aren't: they are specific to each page so they aren't available to layouts.
Besides, @rmunn's point stands: endpoints run after layouts. If you need some data in a layout, you can get it in its load() instead and pass it down to pages through stuff. In the future, this should also be possible through layout endpoints and possibly middleware—both of which would still run before page endpoints.

Yes that's how it works. I'm just saying - why?
It's because a runs b4 b - ok, maybe it could be reversed?
It does seem to me that a requests data logically was made available to layouts. Why not (other than this is how today)?
Get it from the "load() " which page endpoints are trying to minimise the use of. Why is that better?

Thanks for being patient :-)
I saw page endpoints as a way to keep logic out of layouts, pages and components. By running first and making result available for all rendering elements. I still think it makes sense.
I think that page endpoints / shadow endpoints was exactly introduced  a smarter way than load, for covering some but not all stuff -  but I can't remember where I saw this.
Thanks. Now I understand the intended use of page endpoints better.
Can you confirm that there is no way for a page endpoint to deliver data to a layout for SSR ?
Example:
/pages/[slug].svelte
/pages/[slug].js
In endpoint we use slug to lookup page data in headless CMS. Some page data is page title, which is defined in layout.
I don't see how to make them avail for SSR?

You can use stuff for that:

add a load function to your page
pass the desired properties to stuff
access that through the $page.stuff store in your layout

https://kit.svelte.dev/docs/loading#output-stuff
Closing as the desired feature is available this way already

FWIW, I was/am also confused by the intended design. I would bet most folks who are coming from a server-side web dev background, (e.g. django, rails, etc.) will expect data rendered by the server to be available to layouts. But from what I gather, the design for SvelteKit sort of assumes you're either using a load() function in your layout, (and not using an endpoint) and passing the results to components nested inside the layout. Or, you're using endpoints to render every page's full set of data and not using layouts that require server-side data that the endpoint returns.

For anyone coming here looking to understand @dummdidumm recommendation, here's an example. Key notion is that pages have to pass the data "up" to the layout by pulling the data out of props and putting it into stuff.
// src/routes/index.ts
export const get = () => {
  const user = await getUser()
  return {
    body: {
      user
    }
  }
}

Hello {user.name}
<slot/>


GRPC name resolution problem

Hello,
When trying to access GRPC that isn't located in root (/) context it fails with error:
{
  "code": 14,
  "details": "Name resolution failed for target dns:host/ws",
  "metadata": {}
}

I'm trying to access method in /ws context. For example:
GRPC HOST/ws/com.some.pkg....
It resolves everyting until /com as host.

The reason is probably that grpc-js does not work as expected. To the ServiceClientConstructor, the complete url host/ws is passed. I assumed that the address also allowed subpaths. I search once in the documentation how and if it works correctly.

@grpc/grpc-js is the successor of grpc. For grpc there is https://github.com/grpc/grpc/issues/14900, which mentions prefix of url.
https://github.com/grpc/grpc/issues/14900#issuecomment-378071244:

The host used to create the channel does not go into the path used by gRPC (the channel builder arg should not include the "/foo" portion from your example). Instead, HTTP/2 paths are specified in a :path header field, and gRPC clients generate these from the proto service definition in the form protoPackage.serviceName.methodName (see here).

I also found the following issue: https://github.com/grpc/grpc-node/issues/980#issuecomment-517794622. grpc-js does not seem to support this feature.

Ok, thank you very much! Please, make sure that this override will support variables from env (coz for local run there are no need in /foo, but for dev/qa/prod stand it is).

@ey-in-vorontsov May I ask what client you are using to support subpath in prod. Does it also support the specification of a path? In my search, I actually found that this usage is rather unsupported.
And I try to support the specification of a path. But I will not use an internal api. I don't have the use case myself and can't test this sufficiently and only with difficulty. A longer support would be very costly.

We have standalone java application with REST API (/api) for external integrations and GRPC (/ws) for grpc-web. Url's are routed by nginx to same application with different ports.
On JS client side is generated code from proto that is used with API url:
new AuthServicePromiseClient(config.apiUrl); // Where config.apiUrl == http://host:port/ws

AuthServicePromiseClient:
export class AuthServicePromiseClient {
  constructor (hostname: string,
               credentials?: null | { [index: string]: string; },
               options?: null | { [index: string]: any; });

  auth(
    request: b$pn$proto$central_auth_auth_service_pb.AuthRequest,
    metadata?: grpcWeb.Metadata
  ): Promise<b$pn$proto$central_auth_auth_service_pb.AuthResponse>;

}

AuthServiceClient.auth:
proto.com.somespace.auth.AuthServiceClient.prototype.auth =
    function(request, metadata, callback) {
  return this.client_.rpcCall(this.hostname_ +
      '/com.somespace.auth.AuthService/Auth',
      request,
      metadata || {},
      methodDescriptor_AuthService_Auth,
      callback);
};

NOTE: rpcCall is a method from AbstractClientBase in grpc-web (https://github.com/grpc/grpc-web/blob/627e33718d5055e3cfb9c8318e81cf1b4045b189/javascript/net/grpc/web/abstractclientbase.js#L54)

I have now tried to rebuild the PathAwareChannel. Unfortunately I could not test it reasonably and therefore I am dependent on help. Please test once with the next version.
Additionally it is now possible to pass the ChannelOptions. These are set by request.options.
proto < ./hello.proto

{{
  request.options = {
    channelFactoryOverride: (address, credentials, options) => {
      ....
    }
 };
}}

GRPC grpcb.in:9000/ws/hello.HelloService/sayHello
{
  "greeting": "world"
}

Hello,
Thank you, I've checked and it seems that it works well!
But want to mention for history, that If no port defined:
GRPC grpcb.in/ws/hello.HelloService/sayHello
{
  "greeting": "world"
}

Error will be:
{
  "code": 14,
  "details": "No connection established",
  "metadata": {}
}

It seems that grpc-js uses as default port 443 (used in line 83)
Thanks for the feedback:-)


extconf.rb: Do not strip debugging symbols

Refs #128

Crash investigated and fixed in libsass 3.6.1.


File upload issue

hii
i am using phantomjs v1.9.16 in Linux with nightwatchjs(http://nightwatchjs.org).
There has been an problem i am facing while uploading files on site.
Phantomjs seems to be freeze everytime at that point.
Any help will be appreciated.
Thanks

I'm also experiencing this. Windows 7.


Get rid of the ThemeProvider single child context restriction (canary)

This is the follow-up to https://github.com/styled-components/styled-components/pull/2706.

@probablyup No problem!


program of binary equivalent

this program gives the binary equivalent of a decimal number
another program gives the sum of the last four digits of a seven-digit number

Hi Dear @KumarSanskar
Great code
Thanks for your contribution......
Show your support on my youtube channel web Pixar(The institute of coding)
like , share , subscribe
youtube - https://youtu.be/5qnQjgdpFPg
telegram-channel - https://t.me/WebPixar
join our telegram channel for more goodies , swag packs


Uncaught ReferenceError: file is not defined

[Enter steps to reproduce below:]

... Install package
... Press ctrl + alt + h

Atom Version: 1.12.5
Electron Version: 1.3.9
System: Microsoft Windows 10 Pro
Thrown From: git-history package, v3.2.0
Stack Trace
Uncaught ReferenceError: file is not defined
At C:\Users\alex\.atom\packages\git-history\lib\git-history-view.coffee:10

ReferenceError: file is not defined
    at GitHistoryView.initialize (file:///C:/Users/alex/.atom/packages/git-history/lib/git-history-view.coffee:10:20)
    at GitHistoryView.View [as constructor] (C:\Users\alex\.atom\packages\git-history\node_modules\space-pen\lib\space-pen.js:184:25)
    at GitHistoryView.SelectListView [as constructor] (C:\Users\alex\.atom\packages\git-history\node_modules\atom-space-pen-views\lib\select-list-view.js:18:51)
    at new GitHistoryView (file:///C:/Users/alex/.atom/packages/git-history/lib/git-history-view.coffee:6:7)
    at atom-text-editor.GitHistory._loadGitHistoryView (file:///C:/Users/alex/.atom/packages/git-history/lib/git-history.coffee:18:13)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\alex\AppData\Local\atom\app-1.12.5\resources\app.asar\src\command-registry.js:259:29)
    at C:\Users\alex\AppData\Local\atom\app-1.12.5\resources\app.asar\src\command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (C:\Users\alex\AppData\Local\atom\app-1.12.5\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:587:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (C:\Users\alex\AppData\Local\atom\app-1.12.5\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:382:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (C:\Users\alex\AppData\Local\atom\app-1.12.5\resources\app.asar\src\window-event-handler.js:106:36)
    at HTMLDocument.<anonymous> (C:\Users\alex\AppData\Local\atom\app-1.12.5\resources\app.asar\src\window-event-handler.js:3:59)

Commands
     -1:57.3.0 application:open (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -1:45.6.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
 14x -1:42.4.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -1:39 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:03.3.0 core:copy (atom-text-editor.editor.mini.is-focused)
     -1:02.0 core:paste (atom-text-editor.editor.mini.is-focused)
     -1:01.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:02.8.0 git-history:show-file-history (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "telemetryConsent": "limited"
  }
}

Installed Packages
# User
git-history, v3.2.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (active)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (active)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.13.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.4 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (active)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.0 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages

Same issue here
Atom Version: 1.12.3
System: Ubuntu 14.04 LTS
Thrown From: git-history package, v3.2.0

+1

Sorry, I don't have much free time to investigate this right now. PRs are always welcome!

For me, fixing a typo in initialize fixed this. I have PR waiting #40

[Enter steps to reproduce below:]

...
...

Atom Version: 1.13.1
Electron Version: 1.3.13
System: Microsoft Windows 7 Professional
Thrown From: git-history package, v3.2.0
Stack Trace
Uncaught ReferenceError: file is not defined
At C:\Users\Administrator\.atom\packages\git-history\lib\git-history-view.coffee:10

ReferenceError: file is not defined
    at GitHistoryView.initialize (file:///C:/Users/Administrator/.atom/packages/git-history/lib/git-history-view.coffee:10:20)
    at GitHistoryView.View [as constructor] (C:\Users\Administrator\.atom\packages\git-history\node_modules\space-pen\lib\space-pen.js:184:25)
    at GitHistoryView.SelectListView [as constructor] (C:\Users\Administrator\.atom\packages\git-history\node_modules\atom-space-pen-views\lib\select-list-view.js:18:51)
    at new GitHistoryView (file:///C:/Users/Administrator/.atom/packages/git-history/lib/git-history-view.coffee:6:7)
    at atom-text-editor.GitHistory._loadGitHistoryView (file:///C:/Users/Administrator/.atom/packages/git-history/lib/git-history.coffee:18:13)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\src\command-registry.js:259:29)
    at C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\src\command-registry.js:3:59
    at CommandPaletteView.module.exports.CommandPaletteView.confirmed (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\node_modules\command-palette\lib\command-palette-view.js:210:32)
    at CommandPaletteView.module.exports.SelectListView.confirmSelection (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\node_modules\atom-space-pen-views\lib\select-list-view.js:338:21)
    at space-pen-div.atom.commands.add.core:confirm (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\node_modules\atom-space-pen-views\lib\select-list-view.js:109:19)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\src\command-registry.js:259:29)
    at C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\src\command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:587:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:382:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\src\window-event-handler.js:106:36)
    at HTMLDocument.<anonymous> (C:\Users\Administrator\AppData\Local\atom\app-1.13.1\resources\app.asar\src\window-event-handler.js:3:59)

Commands
     -1:43.1.0 settings-view:open (input.hidden-input)
     -1:33.3.0 core:paste (input.hidden-input)
     -0:33.8.0 tree-view:reveal-active-file (div.line)
  3x -0:30.1.0 core:close (input.hidden-input)
     -0:12.2.0 command-palette:toggle (input.hidden-input)
     -0:04.3.0 core:confirm (input.hidden-input)
     -0:04.3.0 git-history:show-file-history (input.hidden-input)

Config
{
  "core": {
    "telemetryConsent": "limited",
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ]
  }
}

Installed Packages
# User
atom-material-syntax, v1.0.2 (active)
atom-material-ui, v1.3.9 (active)
git-history, v3.2.0 (inactive)
git-plus, v7.2.0 (active)
linter, v1.11.21 (active)
linter-php, v1.3.1 (active)
minimap, v4.26.8 (active)
minimap-git-diff, v4.3.1 (active)
atom-dark-syntax, v0.28.0 (inactive)
atom-dark-ui, v0.53.0 (inactive)
atom-light-syntax, v0.29.0 (inactive)
atom-light-ui, v0.46.0 (inactive)
base16-tomorrow-dark-theme, v1.4.0 (inactive)
base16-tomorrow-light-theme, v1.4.0 (inactive)
one-dark-ui, v1.8.2 (inactive)
one-light-ui, v1.8.2 (inactive)
one-dark-syntax, v1.6.0 (inactive)
one-light-syntax, v1.6.0 (inactive)
solarized-dark-syntax, v1.1.1 (inactive)
solarized-light-syntax, v1.1.1 (inactive)
about, v1.7.2 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.14.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.33.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.29.0 (inactive)
autosave, v0.23.2 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.43.2 (active)
bracket-matcher, v0.85.1 (active)
command-palette, v0.39.1 (active)
deprecation-cop, v0.55.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.204.5 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.2.0 (active)
go-to-line, v0.31.2 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.1 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.159.3 (active)
metrics, v1.1.3 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.2 (inactive)
settings-view, v0.244.0 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.5 (active)
status-bar, v1.6.0 (active)
styleguide, v0.48.0 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.1 (active)
timecop, v0.33.2 (active)
tree-view, v0.211.1 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.39.0 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.1 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages

+1

+1

+1

+1

+1

Fixed by change the line of code from "@show() if file" to "@show() if @file"

+1
can anybody give us an answer?

+1


Flat View - runtime setter of repeat properties

Enable setting repeat X/Y properties at runtime

 All committers have signed the CLA.

Changes can be tested with change_view sample by opening a console and setting viewer.view.current.repeatX and repeatY to true/false

I'm on it

Not merging this mess, see #41 for new PR


Replace repo.namedBlob by git.TreeEntry.

namedBlob turned out to be a poor imitation of a TreeEntry. Using the latter directly shortens this code.

for performance reasons

And even if it was, it was only optimizing for README files. How heavy is that really?

Otherwise, I don't know how this could happen.

Thanks for the vote of confidence!

IIRC we needed the namedBlob at some point because we were passing round git.Blobs but we're able to get the TreeEntry just as easily now so it might be needed anymore

drafted until there are tests pre-written to cover README rendering: https://github.com/go-gitea/gitea/pull/22898#discussion_r1110009347

Codecov Report

Merging #22898 (6f1384f) into main (33e556e) will decrease coverage by 0.12%.
The diff coverage is 50.87%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main   #22898      +/-   ##
==========================================
- Coverage   47.44%   47.32%   -0.12%
==========================================
  Files        1140     1140
  Lines      150804   150985     +181
==========================================
- Hits        71549    71460      -89
- Misses      70788    71059     +271
+ Partials     8467     8466       -1

Impacted Files
Coverage Δ

models/actions/run.go
1.73% <0.00%> (+0.02%)
:arrow_up:

models/actions/run_list.go
0.00% <0.00%> (ø)

models/actions/status.go
22.85% <0.00%> (-1.39%)
:arrow_down:

models/auth/oauth2.go
60.52% <ø> (ø)

models/auth/twofactor.go
19.73% <ø> (ø)

models/db/engine.go
44.80% <ø> (ø)

models/issues/label.go
55.95% <0.00%> (ø)

models/unittest/testdb.go
12.92% <0.00%> (ø)

modules/auth/password/hash/pbkdf2.go
69.69% <ø> (ø)

modules/avatar/hash.go
100.00% <ø> (ø)

... and 64 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The current CI failures are
Init storage failed: Put "http://minio:9000/gitea/": dial tcp: lookup minio on <IP_ADDRESS>:53: no such host

and
=== Test_DeleteOrphanedIssueLabels (/drone/src/models/migrations/v1_14/v177_test.go:37)

LoadFixtures failed after retries: testfixtures: error inserting record: pq: column "exclusive" of relation "label" does not exist, on file: label.yml, index: 0, sql: INSERT INTO "label" ("num_closed_issues", "id", "repo_id", "org_id", "name", "color", "exclusive", "num_issues") VALUES ($1, $2, $3, $4, $5, $6, $7, $8), params: [0 1 1 0 label1 #abcdef false 2]

--- FAIL: Test_DeleteOrphanedIssueLabels (5.07s)

    v177_test.go:37: initializing fixtures from: /drone/src/models/migrations/fixtures/Test_DeleteOrphanedIssueLabels

    v177_test.go:37: error whilst loading fixtures from /drone/src/models/migrations/fixtures/Test_DeleteOrphanedIssueLabels: testfixtures: error inserting record: pq: column "exclusive" of relation "label" does not exist, on file: label.yml, index: 0, sql: INSERT INTO "label" ("num_closed_issues", "id", "repo_id", "org_id", "name", "color", "exclusive", "num_issues") VALUES ($1, $2, $3, $4, $5, $6, $7, $8), params: [0 1 1 0 label1 #abcdef false 2]

FAIL

FAIL	code.gitea.io/gitea/models/migrations/v1_14	6.460s

FAIL

These don't seem to be related to this patch. I'll restart and if it happens again I guess I'll try to reproduce locally.

Please update branch

Thank you @lunny, @delvh and @zeripath :)

@kousu
Please update again, I've added a label so we can get it merged hopefully without bugging you too many more times. 🙂

Of course! Here it comes around again.
I really appreciate getting this in. I've had my eye on this patch for a couple of months now.
Did I do something wrong btw? Did I miss clicking "Allow Edits from Maintainers" or something?

Did I do something wrong btw? Did I miss clicking "Allow Edits from Maintainers" or something?

Nope, not your fault, I believe it's a GitHub thing that doesn't let us update it because it's from an org vs a user account.


cw721: Move transfer events after action event

Describe your changes and provide context
Move transfer events after action event attribute in cw721 transfer/send
Testing performed to validate your change

More context:
CW721 events by convention will have the action attribute first, followed by subsequent attributes. Since the action attribute currently gets added after the transfer_nft event attributes, it ends up emitting action last.
To bring the contract in-line with CW721 convention, we emit the transfer_nft event attributes in the expected order in both send_nft and transfer_nft calls.


[Android] convertFileSrc does not correctly convert sdcard paths.

After choose a file this nativePath is returned:
file:///sdcard/Music/Sinéad O'Connor/Sean Nos Jua (2002)/05 - Óró Sé Do Bheatha 'Bhaile.flac
parsing it with convertFileSrc returns:
https://localhost/_app_file_/sdcard/Music/Sinéad O'Connor/Sean Nos Jua (2002)/05 - Óró Sé Do Bheatha 'Bhaile.flac""
which can not be loaded by the webview.
Complete file info:
{
"extension":".flac","name":"05 - Óró Sé Do Bheatha 'Bhaile",
"nativePath":"file:///sdcard/Music/Sinéad O'Connor/Sean Nos Jua (2002)/05 - Óró Sé Do Bheatha 'Bhaile.flac",
"uri":"content://com.android.externalstorage.documents/document/326E-6BB3%3AMusic%2FSin%C3%A9ad%20O'Connor%2FSean%20Nos%20Jua%20(2002)%2F05%20-%20%C3%93r%C3%B3%20S%C3%A9%20Do%20Bheatha%20'Bhaile.flac",
"ionicPath":"https://localhost/_app_file_/sdcard/Music/Sinéad O'Connor/Sean Nos Jua (2002)/05 - Óró Sé Do Bheatha 'Bhaile.flac"
}

Selecting the same file but from the "Music" quick access works as expected.
Also converting the uri instead of the nativePath works as expected but it fails after the app restarts.

Agreed. My workaround is:

Explicitly set Scheme and MixedContentMode in config.xml - because why not.

        <preference name="Scheme" value="https" />
        <preference name="MixedContentMode" value="0" />

      var filePathCorrected = window.Ionic.WebView.convertFileSrc(fileUri);
      filePathCorrected = filePathCorrected.replace('file:/', "https://localhost/_app_file_");
      return filePathCorrected;

Wrap calls to local files with this:

  getAsFileUrlMobile(fileUri: string) {
    if (this.isiOS()) {
      return window.Ionic.WebView.convertFileSrc(fileUri);
    }
    else {
      // correct file paths on Android due to https://github.com/ionic-team/cordova-plugin-ionic-webview/issues/598
      var filePathCorrected = window.Ionic.WebView.convertFileSrc(fileUri);
      filePathCorrected = filePathCorrected.replace('file:/', "https://localhost/_app_file_");
      return filePathCorrected;
    }
  }

Agreed. My workaround is:

Explicitly set Scheme and MixedContentMode in config.xml - because why not.

        <preference name="Scheme" value="https" />
        <preference name="MixedContentMode" value="0" />

      var filePathCorrected = window.Ionic.WebView.convertFileSrc(fileUri);
      filePathCorrected = filePathCorrected.replace('file:/', "https://localhost/_app_file_");
      return filePathCorrected;

Wrap calls to local files with this:

  getAsFileUrlMobile(fileUri: string) {
    if (this.isiOS()) {
      return window.Ionic.WebView.convertFileSrc(fileUri);
    }
    else {
      // correct file paths on Android due to https://github.com/ionic-team/cordova-plugin-ionic-webview/issues/598
      var filePathCorrected = window.Ionic.WebView.convertFileSrc(fileUri);
      filePathCorrected = filePathCorrected.replace('file:/', "https://localhost/_app_file_/");
      return filePathCorrected;
    }
  }

I haven't done the MixedContentMode option (mostly because I do not understand what it does) but your .replace is working! Maybe you should do a PR?

BTW for some reason I can not reuse a file URI unless I re-choose it again with the file picker
https://stackoverflow.com/questions/63870146/native-file-can-not-be-used-as-source-if-it-is-not-selected-by-file-picker

BTW for some reason I can not reuse a file URI unless I re-choose it again with the file picker
https://stackoverflow.com/questions/63870146/native-file-can-not-be-used-as-source-if-it-is-not-selected-by-file-picker

Yes - I've observed the same behaviour, not exactly sure either.  Must be a pointer reference that's screwed.  Anyone?

Agreed. My workaround is:

Explicitly set Scheme and MixedContentMode in config.xml - because why not.

        <preference name="Scheme" value="https" />
        <preference name="MixedContentMode" value="0" />

      var filePathCorrected = window.Ionic.WebView.convertFileSrc(fileUri);
      filePathCorrected = filePathCorrected.replace('file:/', "https://localhost/_app_file_");
      return filePathCorrected;

Wrap calls to local files with this:

  getAsFileUrlMobile(fileUri: string) {
    if (this.isiOS()) {
      return window.Ionic.WebView.convertFileSrc(fileUri);
    }
    else {
      // correct file paths on Android due to https://github.com/ionic-team/cordova-plugin-ionic-webview/issues/598
      var filePathCorrected = window.Ionic.WebView.convertFileSrc(fileUri);
      filePathCorrected = filePathCorrected.replace('file:/', "https://localhost/_app_file_/");
      return filePathCorrected;
    }
  }

I haven't done the MixedContentMode option (mostly because I do not understand what it does) but your .replace is working! Maybe you should do a PR?

I could, but I also don't care enough to go through the effort.  Ionic team should be fixing this stuff themselves, it's pretty freaking basic.
But instead, they just concentrate on adding more model frameworks (Vue, React...), which just introduced even more bugs, and then they spend too much time on CSS shadow parts etc, when they could be making the core rock solid instead.

I could, but I also don't care enough to go through the effort. Ionic team should be fixing this stuff themselves, it's pretty freaking basic.
But instead, they just concentrate on adding more model frameworks (Vue, React...), which just introduced even more bugs, and then they spend too much time on CSS shadow parts etc, when they could be making the core rock solid instead.

I think they are ignoring this plugin since there is a capacitor plugin and capacitor belong to the Ionic Team. 🤔

I'm facing this issue right now, and @distante suggestion didn't work.
I looked into the Ionic/WebView plugin and found that is uses an old implementation of the local web server:
https://github.com/google/webview-local-server
instead of the new one:
https://developer.android.com/reference/androidx/webkit/WebViewAssetLoader
so I believe we need to update the native webView plugin to use the newer implementation.

look what I found!
an open issue from 2019 😁:
https://github.com/ionic-team/cordova-plugin-ionic-webview/issues/483

I fixed it at last by using cordova-android@nightly (9.1.0) which contains the following temporary fix:
setAllowFileAccess(true)

also I needed to add the following in config.xml to mitigate a new permission in android Q:
 <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application" xmlns:android="http://schemas.android.com/apk/res/android">             <application android:networkSecurityConfig="@xml/network_security_config" android:requestLegacyExternalStorage="true" />         </edit-config>
android:requestLegacyExternalStorage="true"


Inspecting the managed heap in a dotnet core application in Linux

Hi there,
I want to inspect the memory of an application that is consuming more memory than expected and do a simple !dupmheap to try to figure out which are the type of objects that are piling up.
Please check this self-contained example. It will create a docker image with all the tools already installed, then creates a dotnet core 2.1 application that runs in a continuous loop printing messages with a 1s sleep between messages, and use it as entry point:
FROM microsoft/dotnet:2.1-sdk
WORKDIR /app
RUN apt-get update && apt-get install curl -y && \
    apt-get install gpg -y && \
    apt-get install apt-transport-https -y && \
    curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.gpg && \
    mv microsoft.gpg /etc/apt/trusted.gpg.d/microsoft.gpg && \
    sh -c 'echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-xenial-prod xenial main" > /etc/apt/sources.list.d/microsoft.list' && \
    apt-get update && \
    apt-get install procdump -y && \
    apt-get install lldb-3.9 -y
RUN dotnet tool install -g dotnet-symbol && \
    export PATH="$PATH:/root/.dotnet/tools" && \
    dotnet symbol coredump && \
    dotnet new console && \
    echo 'using System; namespace app { class Program { static void Main(string[] args) { while(true) { Console.WriteLine($"{DateTime.Now:HH:mm:ss} Hello!"); System.Threading.Thread.Sleep(1000);} } } } '  > Program.cs && \
    dotnet build -c Release
WORKDIR /app/bin/Release/netcoreapp2.1
ENTRYPOINT [ "dotnet", "app.dll" ]

Then you need to run it with ptrace support and connect to it:
$ docker build --no-cache --rm -t lldb-poc .
$ docker run --cap-add=SYS_PTRACE --security-opt seccomp:unconfined -d --name lldb-poc-c lldb-poc
$ docker exec -it --privileged lldb-poc-c /bin/bash

Once in, the first thing I tried is to get a memory dump and open it with LLDB.  You will see that the application has the PID 1 (as usual when it is the entry point), and you can take the dump using procdump that is also installed:
# procdump --pid 1

ProcDump v1.0.1 - Sysinternals process dump utility
Copyright (C) 2017 Microsoft Corporation. All rights reserved. Licensed under the MIT license.
Mark Russinovich, Mario Hewardt, John Salem, Javid Habibi
Monitors a process and writes a dump file when the process exceeds the
specified criteria.

Process:                dotnet (1)
CPU Threshold:          n/a
Commit Threshold:       n/a
Threshold Seconds:      10
Number of Dumps:        1

Press Ctrl-C to end monitoring without terminating the process.

[07:31:51 - INFO]: Timed:
[07:31:54 - INFO]: Core dump 1 generated: dotnet_time_2018-10-22_07:31:51.1

Now that the dump is taken, I try to open it in LLDB...
# lldb-3.9 `which dotnet` -c dotnet_time_2018-10-22_07\:31\:51.1
(lldb) target create "/usr/bin/dotnet" --core "dotnet_time_2018-10-22_07:31:51.1"

But it hangs forever... the prompt never gets to (lldb) again. I tried several variants, like loading the SOS plugin first, and then do the target create after, but the outcome is always the same.
I tried also to attach to the running process, but no luck:
# lldb-3.9 `which dotnet`
(lldb) target create "/usr/bin/dotnet"
Current executable set to '/usr/bin/dotnet' (x86_64).
(lldb) plugin load /usr/share/dotnet/shared/Microsoft.NETCore.App/2.1.5/libsosplugin.so
(lldb) process attach -p 1
error: attach failed: unable to attach

Could you please give me some guidance on how to explore the process' memory with LLDB in linux?

@mikem8361 @noahfalk @tommcdon can you please help here?

You need to be supervisor to attach with lldb.  sudo -E lldb-3.9

I'm not sure what is going on.  I'll have to follow your repo steps which it may be a while before I can get to it.  This looks like a lldb setup/install/configuration problem more than a .NET Core or SOS problem, but I do want to document helpful with lldb itself.

Thanks for looking into this.
It is indeed strange. And the problem may boil down to the microsoft/dotnet image itself. For example, despite of all flags and capabilities indicated, still cannot do things like these:
# echo 0 | tee /proc/sys/kernel/yama/ptrace_scope
tee: /proc/sys/kernel/yama/ptrace_scope: Read-only file system
0

# sysctl -w kernel.yama.ptrace_scope=0
sysctl: setting key "kernel.yama.ptrace_scope": Read-only file system

I am doing some investigation, although my knowledge as developer in Linux is pretty much none, but it does not seem to be easy to fix reading things like this : https://community.c9.io/t/cant-attach-gdb-to-process-ptrace-readonly/6343
Being unable of even doing a basic memory analysis on a production containerized dotnet core app is definitely a downer. Specially nowadays where there are lot of gen 2 collectable objects like RabbitMQ subscriptions, connected Websockets, etc... You are probably right and this may not be a .NET Core or SOS problem, although it has a potential impact in its perception as a production ready tool (at least for linux containers!). Let me know any findings or even if you definitely discard it as relevant issue in this repo, and I will continue my pilgrimage repo by repo 🤠
Cheers.

It may be the microsoft/dotnet:2.1-sdk docker images you are starting with and then it something we (.NET Core) need to look at.

Any update? What are the next steps?

Adding @tommcdon
@mikem8361 sounded like it was on his todo list to look into but he is on vacation right now so there wouldn't be an update from him for a while.

Hi there, any update on this? :) Thanks

This issue looks like a dup of https://github.com/dotnet/diagnostics/issues/79 which I have added some comments. If these are the same issue, then this one should be closed.
I haven't tried creating/using the docker image yet which I hope to do this week.

I don't this this is a dup. Referenced issue solved by using createdump, but here I cannot attach to a running dotnet process.

This is definitely not a duplicate. FWIW I'm leaving my results here for those whose google search leads them here.
I noticed that a default install of lldb (apt-get -y install lldb) works in combination with --cap-add=SYS_PTRACE when the container is based on mcr.microsoft.com/dotnet/core/runtime:3.0-buster-slim, but fails with the frustrating and uninformative "could not attach" error message when the container is based on mcr.microsoft.com/dotnet/core/runtime:2.2-stretch-slim. It turns out that in Buster apt-get install lldb installs version 7.0, whereas in Stretch it installs version 3.8. Trying newer versions available for Stretch, I found that neither of 3.8, 3.9 and 4.0 can attach in a container, but 7.0 can, although installing it pulls in many dependencies and produces a very fat image (~500M extra). If you aren't able or willing to upgrade to .NET Core 3.0, changing the dockerfile to use
RUN apt-get -y install lldb-7
RUN ln /usr/bin/lldb-7 /usr/bin/lldb

may be an acceptable workaround.


⚠ Samsung has degraded performance

In 20831cd, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2768 ms

Resolved: Samsung performance has improved in 7caa5ef.


add igs-kastellaun

hfg-karlsruhe.txt

bsz mak-wun.txt

@zYoru Pull request merged. Thank you!
@GR33N5Y5 @onpaak Please create separate pull requests as explained at the bottom of this page.


New version: Microsoft.Edge.Beta version 98.0.1108.33

ARP entries are correct.
Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 2047
Microsoft Reviewers: Open in CodeFlow

🤷♂


Tweaks?

Dear @brentp
Nice Nim work, as usual. I just had a few queries/suggestions:

Can I ask why the encoding is the way it is? It seems strange to code all non-ACGT as A rather than N - is there a downstream reason for this? The indexing is different from the ACGTN of 0-4 used by Heng Li, and I wondered why you diverged from this.
It would be useful to add functionality for minimizers - following the minimap2 algorithm, one uses an invertible hash function e.g.

proc hash*(k: uint64): uint64 =
  var ky = k
  ky = (not ky) + (ky shl 21)
  ky = ky xor (ky shr 24)
  ky = (ky + (ky shl 3)) + (ky shl 8)
  ky = ky xor (ky shr 14)
  ky = (ky + (ky shl 2)) + (ky shl 4)
  ky = ky xor (ky shr 28)
  ky = ky + (ky shl 31)
  return ky

proc inverse_hash*(k: uint64): uint64 =
  var tmp: uint64 = 0
  var ky = k
  tmp = ky - (ky shl 31)
  ky = ky - (tmp shl 31)
  tmp = ky xor ky shr 28
  ky = ky xor tmp shr 28
  ky = ky *<PHONE_NUMBER>5860113213'u64
  tmp = ky xor ky shr 14
  tmp = ky xor tmp shr 14
  tmp = ky xor tmp shr 14
  ky = ky xor tmp shr 14
  ky = ky *<PHONE_NUMBER>3933553977'u64
  tmp = ky xor ky shr 24
  ky = ky xor tmp shr 24
  tmp = not ky
  tmp = not (ky - (tmp shl 21))
  tmp = not (ky - (tmp shl 21))
  ky = not (ky - (tmp shl 21))
  return ky

It's then straightforward to make minimizers. Is this something you'd be happy to add?

Hi Simon,

I can't recall why I chose this encoding and I'm open to changing it. I think I looked at the squeakr (https://github.com/splatlab/squeakr/blob/master/include/kmer.h) encoding when I was building this. Does the lh3 encoding allow reverse-complement by just flipping all the bits? I do want to keep 2-bit encoding. If we have a separate bit for N, then 2-bit won't work.

this sounds great to me. adding @zeeev and cdunn2001 as they have a similar library that also does minimizer stuff (though I can't find it now)

Dear Brent,

The coding doesn't matter greatly, but I'm trying to retain compatibility with minimap2. I deal a lot with viruses, that have lots of ambiguities, so I'm leaning towards 4-bit representation along the lines of [naf](https://github.com/KirillKryukov/naf]. In minimap2, minimizers that contain Ns are skipped. I'll have to hunt down what happens with query sequences.

Thanks for the pointer (I'll add @cdunn2001 esp as he's local to me). I have to take a break for a few days, but I can add and put in a PR if there isn't anything else out there.

Sorry for slow response. (I am also @pb-cdunn )
We had some stuff here. But it's not really ready to be used as a sub-module yet.
I agree with 2-bit encoding, and ours uses 2-bit also. I'd prefer a whole new library for dealing with Ns. The efficiency really is that important.

Thanks @cdunn2001! Perhaps as a compromise for now we can encode ambiguities by resolving e.g. to the smallest lexicographic character (Y/y = C etc.)? For future discussion, perhaps we can have generics for 2bit vs. 4bit representations?


Math not working in Mails

Maybe we consider this a wontfix :blush:

Unless you program a mail client that does understand js 😜. Of course, we could offer the editor a field with a fallback title without math, but that would be one more thing an editor had to fill out, so I would probably say just leave it as it is.

Alright, now we have documented this as a design decision and can reference it when needed :blush:


appending all day event views to eventviews.

https://github.com/user-attachments/assets/fd447bf4-794f-4359-bb50-e1b1e64151bc

@sakshiprit Can you elaborate a bit on this solution? How can this fix the on click not responding issue?

Without this line, the all day views were being created and added in the scrollView, but we were not keeping a reference to them in the eventViews array. Therefore even if the event views were visible , they were not directly accessible elsewhere in our code.And by adding then to eventViews array, we are now storing a reference to each created event view. This way allows us to navigate to correct detail view of the all day event.


FileNotFoundError

Dear Developer Team,
I am writing to seek your assistance regarding an issue I encountered while attempting to run the code associated with your paper titled "Codon language embeddings provide strong signals for use in protein engineering". When running the 'training.py' file, I encountered the following traceback error:
Traceback (most recent call last):
  File "training.py", line 141, in <module>
    ckpt_path='production-run/latest-56000.ckpt')
  ...
  FileNotFoundError: [Errno 2] No such file or directory: 'training_data.fasta'

It seems that the 'training_data.fasta' file is not found, leading to this error. I would greatly appreciate it if you could provide some guidance on how to address this issue.
Thank you very much for your time and consideration. I look forward to your valuable guidance.
Sincerely,
Geng Hu

if you red the paper, you can find this
Data availability We have made available, in our website, the training set (http://opig.stats. ox.ac.uk/data/downloads/training_data.tar.gz), the heldout set (http:// opig.stats.ox.ac.uk/data/downloads/heldout.tar.gz) and the weights of the trained model (http://opig.stats.ox.ac.uk/data/downloads/ calm_weights.pkl). All datasets used for validation of the models presented in this article are available at https://github.com/oxpig/CaLM.
you need to download the data by hand，  the data is not included in this github


Helm Chart Install with hashicorp/helm_release provider can't find k6-operator chart

Brief summary
I am trying to install the k6-operator helm chart with terraform hashicorp/helm_release provider.  I have tried to reference the repository via OCI/https and the provider cannot find the chart. Please provide the url and chart to put in the helm_release resource.
k6-operator version or image
0.0.13
Helm chart version (if applicable)
3.5.0
TestRun / PrivateLoadZone YAML
NA
Other environment details (if applicable)
No response
Steps to reproduce the problem
Create a terraform resource below.
resource "helm_release" "k6_operator" {
  name             = "k6-operator"
  repository       = "https://grafana.github.io/helm-charts"
  chart            = "grafana/k6-operator"
  namespace        = "k6-operator-system"
  version          = "3.5.0" # var.operator_versions.chart_version
  create_namespace = false
  cleanup_on_fail  = true
  recreate_pods    = true
  wait             = true
}

Expected behaviour
The provider can download the helm chart and install it.
Actual behaviour
Getting error when installing helm chart.
module.k6-operator.helm_release.k6_operator: Creating...
╷
│ Error: could not download chart: chart "grafana/k6-operator" version "3.5.0" not found in https://grafana.github.io/helm-charts repository
│
│   with module.k6-operator.helm_release.k6_operator,
│   on ..\modules\k6-operator\k6-operator.tf line 1, in resource "helm_release" "k6_operator":
│    1: resource "helm_release" "k6_operator" {
│
╵

Hi @jsclifford, thanks for reporting the issue.
AFAIS, helm-charts does not support OCI at the moment:
https://github.com/grafana/helm-charts/issues/2481
To be clear, k6-operator doesn't publish the chart on its own -- it happens via that repo. Please feel free to update there with your use case.
Without OCI, other ways to specify the chart in Terraform should work, e.g.:
provider "helm" {
  kubernetes {
    config_path = "~/.kube/config"
  }
}

resource "helm_release" "k6_operator" {
  name  = "k6-operator"
  chart = "https://github.com/grafana/helm-charts/releases/download/helm-k6-operator-3.5.0/k6-operator-3.5.0.tgz"
}

Ok thanks.  I will try the direct download.  I will ask in the other repo to support OCI


Parseable Profiler Output

Per today's Performance meeting, there was a mention by @tclune that maybe the profiler output could be provided in YAML (nested timers are easily represented) or CSV format (easy to parse) rather than just in the stdout.
Indeed, maybe the logger could be the one to write this to a separate file at first?
I'll assign @weiyuan-jiang and @tclune as they are the people I think of with MAPL profiling

Also related #1213


Inconsistent application of permissions

Describe the bug
Assuming there are two metadata schemas (the same applies to documents, too), one accessible by me, the other not. Listing all schemas returns both elements, but if I want to access the single schemas via GET {id} the check for READ permissions is properly applied and I receive HTTP 403 for the schema I'm not allowed to access.
To Reproduce
As the complete reproduction relies on a valid JWT, I'll stick with the simple case, which also shows the issue well enough. In that case, only one schema with arbitrary permissions is needed in MetaStore. As we open the URLs in the browser, we do not have any JWT, thus the situation is the same as if we do not have proper permissions.
Steps to reproduce the behavior:

Enable JWT-based authentication in MetaStore
Open http://localhost:8040/api/v1/schemas/ in the browser, you'll get a result
Open http://localhost:8040/api/v1/schemas/{id} and you'll receive an error 403

Expected behavior
Filtering by permission should also happen for listing operations. It is implemented in the code, but seems not to work as expected.

Obviously, this is no issue of repo-core but in MetaStore directly. (see kit-data-manager/metastore2#71)


[SPARK-49611][SQL] Introduce TVF all_collations() & remove the SHOW COLLATIONS command

What changes were proposed in this pull request?
The pr aims to

introduce TVF all_collations().
remove the SHOW COLLATIONS command.

Why are the changes needed?
Based on @cloud-fan's suggestion: https://github.com/apache/spark/pull/47364#issuecomment-2345183501
I believe that after this, we can do many things based on it, such as filtering and querying based on LANGUAGE or COUNTRY, etc. eg:
SELECT * FROM all_collations() WHERE LANGUAGE like '%Chinese%';

Does this PR introduce any user-facing change?
Yes, provide a new TVF all_collations() for end-users.
How was this patch tested?

Add new UT.
Pass GA.

Was this patch authored or co-authored using generative AI tooling?
No.

can we also remove the SHOW COLLATIONS command in this PR? https://github.com/apache/spark/pull/47364#issuecomment-2346416502  I'd like to avoid confusion as Spark has a very special LIKE semantic in SHOW commands (different from Spark's own LIKE operator for string matching)

can we also remove the SHOW COLLATIONS command in this PR? #47364 (comment) I'd like to avoid confusion as Spark has a very special LIKE semantic in SHOW commands (different from Spark's own LIKE operator for string matching)

Okay, Let me handle it together.

An we discuss the name? Are there any other collations? Is there precedence? Can we lean into what we did for keywords function?
Sent from my iPhone
On Sep 13, 2024, at 3:02 AM, Maxim Gekk @.***> wrote:

@MaxGekk commented on this pull request.

In sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scalahttps://github.com/apache/spark/pull/48087#discussion_r1758576610:

  SYSTEM  BUILTIN  UTF8_BINARY NULL  NULL  ACCENT_SENSITIVE  CASE_SENSITIVE  NO_PAD  NULL

  SYSTEM  BUILTIN  UTF8_LCASE  NULL  NULL  ACCENT_SENSITIVE  CASE_INSENSITIVE  NO_PAD  NULL

I would replace this LIMIT by WHERE which always returns one row, to don't depend on order and how LIMIT behaves.
—
Reply to this email directly, view it on GitHubhttps://github.com/apache/spark/pull/48087#discussion_r1758576610, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA22CFHCAGKZHSXT3QNJPHDZWKZ3FAVCNFSM6AAAAABODCERQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBSG4YDGNJTGQ.
You are receiving this because you were mentioned.Message ID: @.***>

@srielau @mihailom-db What are your thoughts about the function name? string_collations is also fine to me since collation only makes sense for string.

I do not have strong preferences, but to me maybe something like collation(s)_info seems like the most appropriate. As this TVF is not generation only collation names but actually providing some more information on what the given collations are. @cloud-fan @srielau

Or call it collations() ?

@panbingkun Which function name do other systems use?

@panbingkun Which function name do other systems use?

Database
Support
Name

mysql
SHOW COLLATION
COLLATION

MariaDB
SHOW COLLATION LIKE 'latin2%';
COLLATION

oracle
SHOW COLLATION
COLLATION

TiDB
SHOW COLLATION
COLLATION

PingCap
SHOW COLLATION
COLLATION

Firebird
SHOW COLLATIONS
COLLATIONS

MS SQL Server
SELECT name, description FROM sys.fn_helpcollations();
...collations()

I just wonder how long folks at Microsoft were thinking of the name fn_helpcollations :-) Seems it is obvious choice.

Oracle has SHOW COLLATION??
Do you have link?
Also we should have a wider spread… 5 flavors of MySQL re still MySQL.
Collations() works for me. Happens to line up with the ANSI information schema
Sent from my iPhone
On Sep 14, 2024, at 4:02 AM, panbingkun @.***> wrote:

@panbingkunhttps://github.com/panbingkun Which function name do other systems use?
Database        Support Name
mysql   SHOW COLLATION  COLLATION
MariaDB SHOW COLLATION LIKE 'latin2%';  COLLATION
oracle  SHOW COLLATION  COLLATION
TiDB    SHOW COLLATION  COLLATION
PingCap SHOW COLLATION  COLLATION
Firebird        SHOW COLLATIONS COLLATIONS
MS SQL Server   SELECT name, description FROM sys.fn_helpcollations();  ...collations()
—
Reply to this email directly, view it on GitHubhttps://github.com/apache/spark/pull/48087#issuecomment-2350952430, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA22CFGODHWK2YYFZUVKQ6LZWQJSVAVCNFSM6AAAAABODCERQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE2TENBTGA.
You are receiving this because you were mentioned.Message ID: @.***>

Oracle has SHOW COLLATION?? Do you have link? Also we should have a wider spread… 5 flavors of MySQL re still MySQL. Collations() works for me. Happens to line up with the ANSI information schema
…
Sent from my iPhone On Sep 14, 2024, at 4:02 AM, panbingkun @.> wrote:  @panbingkunhttps://github.com/panbingkun Which function name do other systems use? Database Support Name mysql SHOW COLLATION COLLATION MariaDB SHOW COLLATION LIKE 'latin2%'; COLLATION oracle SHOW COLLATION COLLATION TiDB SHOW COLLATION COLLATION PingCap SHOW COLLATION COLLATION Firebird SHOW COLLATIONS COLLATIONS MS SQL Server SELECT name, description FROM sys.fn_helpcollations(); ...collations() — Reply to this email directly, view it on GitHub<#48087 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA22CFGODHWK2YYFZUVKQ6LZWQJSVAVCNFSM6AAAAABODCERQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE2TENBTGA. You are receiving this because you were mentioned.Message ID: @.>

It was my bad, I misread Oracle.
Additionally, I have updated links and screenshots for all databases.

let's go with collations() then.

let's go with collations() then.

Updated, thanks!

thanks, merging to master!

Thanks all, @mihailom-db @uros-db @MaxGekk @cloud-fan @srielau


Filtering should always be done server side when filtering dataviews linked to an analysis

If a map is being rendered using vector tiles and a dataview is linked to an analysis node, filtering should NOT be done client side (d3.cartodb doesn't know anything about analyses). Instead, map should be re-instantiated and GeoJSON tiles should be fetched again.
Also, dataviews that have source that is different to the layer's source should not try to get data from the vector tiles.
cc: @javisantana @fdansv

Closed via https://github.com/CartoDB/cartodb.js/pull/1306


Subgrid scope doesn't access outer grid scope function

I saw that there was a thread on this issue, and several solutions were suggested
(https://github.com/angular-ui/ng-grid/issues/1782)
I've tried them all, and couldn't get this to work.
What I'm trying to do:

I have a grid, and a subgrid that opens using the expandable feature.
I have a button in the template of one of the columns of the sub-grid.
I want the button ng-click to trigger a function on the $scope of the grid, to trigger an alert (just an example).

Please help me I'm trying to solve this for hours and in the thread there is no working full example :(
thanks.

Wow I feel stupid, https://github.com/angular-ui/ng-grid/issues/3174
The example there is just simple, and works :(


feat: checking for disk space before migrating

pvmigrate now checks if there is enough disk space before starting to migrate to openebs volumes.
in a nutshell:

check what is the largest pv per node[1].
check what is the largest non attached pv.

nodes must have, as free, double the space used of the largest pv with. total free space in a node is decreased by 15% prior to verifying if enough space is available.
this behavior can be disabled in the command line by using the flag -skip-free-space-check.
[1] the "per node" portion is determined by finding the pod where the pvc is attached and where the pod is running.

Why double the largest PV, and not the sum of the PVs?

Why double the largest PV, and not the sum of the PVs?

I thought we were migrating one PV at a time and then deleting the original. I gonna have to read the code once more. Anyway, I am closing this one and opening a new one in kurl repo as soon as I get it in place.

The logic is in the readme!

The logic is in the readme!

well, that is an option as well. shame on me.


fix: bump paperclip-macros minor

This is to address min/max being added and breaking back compat. paperclip-macros 0.6.4 and 0.6.5 will be yanked from crates. paperclip 0.9.0 and 0.9.1 will also be yanked from crates.
Resolves #542

@Sufflope
I think we also yank paperclip 0.9.0 and 0.9.1 unfortunately, because those need the min/max change.
So once the paperclip-macros 0.6.{4,5} is yanked then paperclip 0.9.{0,1} become broken anyway?
Is this the right thing to do?
CC
@formlogic-kirk @snaggen  @RaulTrombin @thomedw
for visibility since you've raised PRs recently, see #542 for the problem we're trying to address here, sorry for the mess-up :(

I wonder if another way is to release 0.6.6 without min/max
Then pre 0.9.0 would get the correct code when updating, and existing 0.9.{0,1} would stay working.

First let me say that I don't have previous experience with yanking, sorry (it's not a brag "I don't break things" :sweat_smile:  on the contrary, it's just that I never got to maintain a public library :cry: ), so I don't have prior battle-tested knowledge.
So my not-so-educated opinion is: the problem with your second approach is in the (contrived, admittedly, but technically possible) case where someone would have pinned a =0.9.0 paperclip dependency but no explicit macros version, it would break on cargo update? So I think the safest option is your first one.

Won't it break anyway with the first approach? Because we'd be yanking the paperclip-macros pointed to by the paperclip 0.9.{0,1}?

According to https://doc.rust-lang.org/cargo/commands/cargo-yank.html if I understand correctly, it should prevent new projects from adding paperclip 0.9.{0,1} as dependencies, but projects which have them already should continue compiling (with a warning telling them those deps are yanked). But at least users would be warned, and be able to update by switching to at least 0.9.2, instead of updating only the macro and getting a cryptic error that some fields are missing in a proc-macro. At least that's my understanding.

Note that anyway on my side I updated all my internal projects to 0.9 and I generate min/max attributes, and I am quite aware of the problem we're discussing, so even if there's a subsequent problem with the chosen strategy, it won't be a big issue to me, so feel free to choose the strategy you think will work the best!

Looks good to me 👍

Alright cool, I'll try and do this tomorrow or over the weekend, thanks both


How to really run tests in parallel, or troubleshoot when they don't?

I'm using the Visual Studio Tests task with "Run tests in parallel on multi-core machines" checkbox selected. But they still run sequentially. I believe the test agents pool which I'm using has all machines multi-core, it's the Universal Store pool in the Microsoft VSTS instance.

Can you please re-run the build with System.debug set to True and share the build logs with<EMAIL_ADDRESS>so that I can have a look?

@abatishchev tagging you for notification.

@abatishchev  Okay so I had a look at your runs.

x64
0

This is the run settings file being passed to vstest console which clearly indicates that the VsTest task is passing on the information to vstest console to use all available cpu cores (0 indicates use all).
However I'd like to tell you that this sort of parallelization works only at an assembly level, ie if all your tests are in the same dll then it will not be able to parallelize the execution.

Also since you are interested in parallelizing the tests you should try out the phases in release that allow multi-agent parallelism. This should help cut down your test run time considerably.
Please take a look at https://blogs.msdn.microsoft.com/devops/2017/03/26/vstest-task-dons-a-new-avatar-testing-with-unified-agents-and-phases/ for guidance on using this feature.

Thanks for confirmation and for the link, will try it out!

@ShreyasRmsft hi, can I ask for some help to reconfigure my build properly? Here's its definition: https://microsoft.visualstudio.com/defaultcollection/Universal Store/Universal Store Team/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=17821
I have 2 assemblies of unit tests I want to run in parallel so I turned off Multi-agent with Maximum number of agents: 2. But it stills runs the full set, all 31 tests twice.

@abatishchev sorry for not replying sooner. The multi agent flow is not yet supported in build. Currently it's only available in the release pipeline (the blog points it out I believe). It may take a while for it be supported in the build pipeline.

No problem, thanks for coming back on this! And thanks for explaining. Let me try it out in one of my release definitions rather than build.

Hi,
Wanted to check back on this. I have two assemblies holding unit tests and checked "run in parallel" option in vsts task but it still executes sequentially.
Can someone please help here:
https://microsoft.visualstudio.com/Universal Store/_build/index?buildId=7376351&_a=summary
Thanks
Amit


The menu will remain disabled when: you view the context menu before loading a file

Research
MSDN documentation for: CanExecuteChanged

Occurs when changes occur that affect whether or not the command should execute.
You must keep a hard reference to the handler to avoid garbage collection and
unexpected results. See remarks for more information.

When subscribing to the System.Windows.Input.ICommand.CanExecuteChanged event
using code (not when binding using XAML) will need to keep a hard reference to
the event handler. This is to prevent garbage collection of the event handler
because the command implements the Weak Event pattern so it does not have a hard
reference to this handler. An example implementation can be seen in the CompositeCommand
and CommandBehaviorBase classes. In most scenarios, there is no reason to sign
up to the CanExecuteChanged event directly, but if you do, you are responsible
for maintaining the reference.

Related articles:

How to enable menuitem after canExecute is called
WPF ViewModel Commands CanExecute issue
CommandManager.InvalidateRequerySuggested() isn't fast enough. What can I do?


samples: Simple read and simple write

This also does the following:

get rid of the download maven jar part since it's now available in gcs
put steps into bash scripts so it's easier to use

ok this is now ready for another round of review.

added separate integration test for all 3 samples
simpleRead needs to use command line arguments, reason documented.


Fix issue with Sigma mint creation

PR intention

if using the same wallet.dat between two machines, the count is not synced. Therefore during mint transaction creation, we have to:

check the chain to see if this mint already exists
ensure the chain is synced for access to all mints

This PR adds that.

Adds tests for the same

Also reverts a bad change in ResetMintCount - The intention of this function is to reset the internal mint count to the value in the database.

@riordant please resolve remaining request changes.


(README.md): correct mispelling of "Spencer Dixon"

Current coverage is 72.58% (diff: 100%)

Merging #1032 into master will not change coverage

@@             master      #1032   diff @@
==========================================
  Files            12         12
  Lines            62         62
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             45         45
  Misses           17         17
  Partials          0          0

Powered by Codecov. Last update 87a1988...e97860c

Good catch, thank you!


Add support for PiR and temp/hum sensor

Just tried your app on my Homey, but does not recognise the following devices. Would it be possible to add support? (if details needed let me know what and how to do)
see pictures
homey finds the devices but says no compatibele app was found to support it.
Many thanks!
Temp/HUm sensor: ZTH01
Pir sensor : ZG-204ZL/ZG-204Z

Closed, as request made on Homey community forum


Update Elixir/Erlang versions in CI

Pull Request Test Coverage Report for Build 2c150441d5de5b916d64d321d01a6c28b390b901-PR-22
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.8%) to 95.758%

Totals

Change from base Build 773d3a0bb65ceb72c0e134ca898ae423bc351805:
1.8%

Covered Lines:
158

Relevant Lines:
165

💛  - Coveralls


Recruitment survey API's

https://fiterio.atlassian.net/browse/INKO-42
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Please fix spotLess issue before I approve @Deepika1095

Fxied @jumba2010


Fix tests failures in multiple files

FAILED ../../../../integration_tests/src/main/python/hive_delimited_text_test.py::test_read_compressed_hive_text
FAILED ../../../../integration_tests/src/main/python/get_json_test.py::test_get_json_object_quoted_question
FAILED ../../../../integration_tests/src/main/python/time_window_test.py::test_grouped_sliding_window_array
FAILED ../../../../integration_tests/src/main/python/datasourcev2_read_test.py::test_read_all_types_count
FAILED ../../../../integration_tests/src/main/python/orc_write_test.py::test_orc_do_not_lowercase_columns
FAILED ../../../../integration_tests/src/main/python/expand_exec_test.py::test_expand_pre_project
FAILED ../../../../integration_tests/src/main/python/logic_test.py::test_logical_with_side_effect
FAILED ../../../../integration_tests/src/main/python/json_matrix_test.py::test_scan_json_strings
FAILED ../../../../integration_tests/src/main/python/repart_test.py::test_hash_repartition_exact
FAILED ../../../../integration_tests/src/main/python/misc_expr_test.py::test_raise_error

All these tests pass with ANSI mode disabled.


Does not compile with MinGW

The makefile defaults to MSVC tools when Windows is detected, maybe there is a way to make it detect if its running in MSYS2 and switch to GCC automatically?

MinGW is currently untested. The original MinGW has it last significant update in the SourceForge repository in 2013 and will not be supported.
The 64 bit fork mingw-64 will be supported in the near future, but I have to build a proper virtual machine environment for it first.
The Makefile structure needs to be changed for that, but I am planning that anyway to make cross-compilation for other environments than the build environment smoother than with the current setup.


SPAM: Modify it to work in Tavern on the Meta

My most active room in the chat network is Tavern on the Meta. I'm interested in the Smokey Pings After Message user script, but noticed that it only works on CHQ and SOCVR. Please modify it so it works on Tavern on the Meta as well.

Done. I didn't increase the version number, so if you have it installed already you'll have to reinstall it.

I bumped version to 0.2.1.

Nice one, thanks all :)


Added more unit tests

CC: @feynmanliang @fabuzaid21

I'll go ahead and merge this, but I just wanted to let you know about the update.


Parse lower-cased 'h'

It appears the documented 'h' and 'hh' tokens are not currently working, the following Pull Request is an attempt at fixing that.
Before the fix:
>>> arrow.get("5 PM", "h A")
<Arrow [0001-01-01T12:00:00+00:00]>

After the fix:
>>> arrow.get("5 PM", "h A")
<Arrow [0001-01-01T17:00:00+00:00]>

Changes Unknown when pulling 1624fd20d296bff197ea6a08385e1d234220484c on truveris:master into ** on crsmithdev:master**.


No clear way to access ReactDOMServer in React ^0.14.0

Since the separation of ReactDOM and ReactDOMServer since React 0.14 there is no clear way to access from ReactDOMServer after loading react-dom.js
In an earlier issue, I posted enough code to load ReactDom into the ReactJS class but I don't see a way to write the equivalent of the following commonJS require in php…
import ReactDOMServer from 'react-dom/server'

cc @stoyan

Fixed by @zpao in https://github.com/reactjs/react-php-v8js/commit/05a69cded262ea6ecd58ef2a2eb4306ccd73103a


ContainerApps configuration cli sample does not work

Exported app.yaml can not reuse if it contains secret due to below issue.
https://github.com/microsoft/azure-container-apps/issues/259

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62186553-2955-8288-d044-5edf05b28203
Version Independent ID: 394665c1-c6fa-dcab-f298-00e9705290b1
Content: Use storage mounts in Azure Container Apps
Content Source: articles/container-apps/storage-mounts.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@georgeOsdDev Thanks for your feedback! We will investigate and update as appropriate.

Since the referenced product bug is in closed status, we will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


How to edit dtb files?

I saw https://github.com/DecisionToolkit/dte, but I don't know if it's usable yet.
Are there any other editors that maintain the lines aligned when you make changes to the table?

Hi @bbigras,
Unfortunately dte is not usable yet.
I don't know if there is any such an editor available. It would be great to have a plugin for Vim, JetBrains' tools or even VSCode. Or plugin for any editor available for multiple platforms.
Personally, I have no capacity to handle all of them, so if you know somebody that could help or you know a company that would like to sponsor such work, it would be really appreciated.
P.S. I use JetBrains' tools and have already some experience with building big decision tables the hard way (copy/paste lines and columns). It's painful...

@bbigras
Something is happening in the dte project. Basic editing capabilities are added. There is still a long way to make it a full-featured editor, but any feedback is much appreciated.


How to put Windows Defender Antivirus in Passive Mode on Server 2019

I'm running Windows Server 2019 Standard Version 10.0.17763 Build 17763, and I tried the registry entry you provided to put Windows Defender Antivirus in Passive Mode, but even after adding that key and restarting, when I run the Get-MpComputerStatus PowerShell cmdlet the AMRunningMode line still shows Normal.  Do you have any other directions on how to put Windows Defender Antivirus in Passive Mode or is that not possible on the version of Windows Server that I'm running?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff9a2869-614c-e077-8d71-351448810897
Version Independent ID: 09369dc3-f8d1-9b19-0043-47fa733a3b81
Content: Microsoft Defender Antivirus on Windows Server
Content Source: microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-on-windows-server.md
Product: m365-security
Technology: mde
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

Hello @surje23. Thank you for posting this question. I will look into this issue and will post an update here soon.

Any progress?
Thank you,
Stephen Jordan
From: Denise Vangel-MSFT @.>
Sent: Monday, June 14, 2021 11:09 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: S Jordan @.>; Mention @.>
Subject: [EXTERNAL] Re: [MicrosoftDocs/microsoft-365-docs] How to put Windows Defender Antivirus in Passive Mode on Server 2019 (#5316)
Hello @surje23https://url.emailprotection.link/?buEq4eyNl9NRYRhKUfm4VcOoW5neFPaXpljg0nEEvDfYq3gujH4PEanQBBSvmw_BOQ23y5qcjjQI-7ASZZMSYHQ~~. Thank you for posting this question. I will look into this issue and will post an update here soon.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://url.emailprotection.link/?bl1KsB9lBTNlthkihAoK7auOcYDLJW_YmSznxCVSrn26lEWV-s7U2MSCIFDqw4UEghOMgqthCveZ3avtQ-q60kbwYh-HBTsW6HgQqb5Ciuz6BUONNCKX0peP2Oo2ZadCQq2weyyUL1EdMyo3RLo7kMy0LWbA5PoPj6Li469SIijQ~, or unsubscribehttps://url.emailprotection.link/?bWE7suYDd3aHsbZpp-Lf4nD_YHfpu7tsY-wHdLbsPbR0oc1v--Zi-0UsLdST21ELcIPAs3Z_lQNz0z7yuusG8JfWWq7_Ucg47U9ikZlcTFr5tO5WTq2PTL_9AUEdNenFPTMRtitqdHpRHEPmVU2QIiHhqM4--ahWwoJqe0wX9vG8~.

Hello @surje23. Yes, I have an update. The docs have been updated to do a better job of explaining passive mode on Windows Server and how to set it as such. Please see https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-on-windows-server?view=o365-worldwide#need-to-set-microsoft-defender-antivirus-to-passive-mode. Thank you!

Hi Denise,
I have reviewed the article at the link you provided, and tough it is clearly explained, that process for putting Microsoft Defender Antivirus in passive mode on Server 2019, namely that registry change, does not work.  However, if my reaching out to others in the industry hasn't lead me down an incorrect path, I believe what might be missing from this article is the process others are telling me about for onboarding those servers through Microsoft Endpoint Manager, something I know nothing about and that I haven't done.  So, I think the problem is that there is more to this story than just what is contained in that article. Or in other words, I think that article assumes some additional steps have been taken beyond just installing Windows Server 2019.  If nothing else has been done other than Windows Server 2019 being installed, which automatically installs Microsoft Defender Antivirus, then that registry change is not going to work.  If you believe I'm incorrect, please feel free to set me straight, and I don't mind paying for some consulting time for that if needed.
This link below talks about the onboarding process:
https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/configure-server-endpoints?view=o365-worldwide
Thank you,
Stephen Jordan
(432)570-8324 (Option 1 for sales.)
[Logo12%]http://www.techwiseit.com/
From: Denise Vangel-MSFT @.>
Sent: Tuesday, July 20, 2021 5:50 PM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: S Jordan @.>; Mention @.>
Subject: [EXTERNAL] Re: [MicrosoftDocs/microsoft-365-docs] How to put Windows Defender Antivirus in Passive Mode on Server 2019 (#5316)
Hello @surje23https://url.emailprotection.link/?buEq4eyNl9NRYRhKUfm4VcOoW5neFPaXpljg0nEEvDfYq3gujH4PEanQBBSvmw_BOQ23y5qcjjQI-7ASZZMSYHQ~~. Yes, I have an update. The docs have been updated to do a better job of explaining passive mode on Windows Server and how to set it as such. Please see https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-on-windows-server?view=o365-worldwide#need-to-set-microsoft-defender-antivirus-to-passive-modehttps://url.emailprotection.link/?bGc_Vm5f3ezqpCyzqYPaSIoKZsrkrePiRE24PwaHFtnaIrEH4aFELLt6POZruAmwkHHMBf176kpcXfiDHv4rXn5v1cdgqD5J2Upo_UWEvnzayElW_Q2vLzZvl3-_6q6y8FcD9IXxxQnMCCXuX8bBFczR1Rd40jFwHhbcIJINYplNMt7XywaCyw0RtdYzFbneoZ2QP25NYSLCp7g8KCIbAsA~~. Thank you!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://url.emailprotection.link/?bOUzYnTaomUApab52t4blIW9YfEYrTTdVqmeyHkJwWnrMvKCdDEvq2tO-Qt3tPIdkBzSXeQhpFT1mU2KAq664qPxpKV7ZdHRpOc5tj8WRDmrMLNR4d3n76iZAQiHwKluM21P0C0i-tSoRnzrkRixhciYwE2prJEZHSsLREC-R8-M~, or unsubscribehttps://url.emailprotection.link/?bLrQEIHj-E91KHWCfxBkQ9ixnBv7q81RROGjsq1QQouMsd8bAb5QqG3cqbVOA4z_CesPxGi15H-QCEKbcasHKjdKC0cPY0_2pCF3K7WW__MONITbNEIaFtS9yBddHnFGGEM1mCPHIS_Z5ke3wsKbQomwoRYQTzbSzjMK5rRj2Thg~.


Add 'fastcgi_pass_header "X-Accel-Buffering";' to nginx configuration

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
I tried to run the Drupal functional test \Drupal\Tests\big_pipe\Functional\BigPipeTest and got some errors
Details
PHPUnit 9.6.20 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\big_pipe\Functional\BigPipeTest
.EE.                                                                4 / 4 (100%)

Time: 00:14.646, Memory: 6.00 MB

There were 2 errors:

1) Drupal\Tests\big_pipe\Functional\BigPipeTest::testBigPipe
Behat\Mink\Exception\ExpectationException: Current response header "X-Accel-Buffering" is "", but "no" expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:180
/var/www/html/web/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php:338
/var/www/html/web/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php:161
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

2) Drupal\Tests\big_pipe\Functional\BigPipeTest::testBigPipeNoJs
Behat\Mink\Exception\ExpectationException: Current response header "X-Accel-Buffering" is "", but "no" expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:180
/var/www/html/web/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php:338
/var/www/html/web/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php:251
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

ERRORS!
Tests: 4, Assertions: 86, Errors: 2.

It looks like the bigpipe test is trying to verify the X-Accel-Buffering header is correctly set, while nginx by default filters it out.
Describe your solution
You can use the following config to make nginx forward the header:
fastcgi_pass_header "X-Accel-Buffering";

Describe alternatives
No response
Additional context
I've fixed it locally by customizing the nginx config, but I thought it might be useful to make it the default, either for Drupal or more generally, if DDEV is aimed primarily at development. Thanks!

Have you already tried it by adding your own .ddev/nginx_full/nginx_site.conf?
Do you think this is a correct thing to do for everybody? If so, after you have tested it, please add a PR.

Thanks @rfay

Have you already tried it by adding your own .ddev/nginx_full/nginx_site.conf?

Yup

Do you think this is a correct thing to do for everybody?

I can't think of any negatives. I guess it's normally not forwarded because it's considered an internal directive and it's generally better not to be promiscuous. But I'm not a sysad (:
I've made #6564 where I was bold and decided to forward all the X-Accel-* headers, as it feels like the others could be useful for the same reason, but happy to cut it back if desired.

Updated issue description to be about passing all X-Accel-* headers.


Add CI Job to Run Benchmark and Publish Results

Is your feature request related to a problem? Please describe.
Yes. Currently the script used to benchmark must be run manually. This can lead to out-of-date or missing benchmark performance data.
Describe the solution you'd like
I would like a new job added to the CI pipeline that would run the benchmark script, then publish the results as an artifact. This job could run on ever push or every release, or at some other interval.
Describe alternatives you've considered
The alternative is to keep running the script manually. As mentioned above, this may result in benchmark data being out-of-sync with the actual code. Automatically running the benchmark script and publishing the results will ensure that the two are always synchronized.

I'd like to work on this.
Deno is pushing benchmarks to a git repo in their CI.
@dyladan Will a similar approach be enough? If so, any pointers to which repo should be used to push the data would be helpful.

Yes, I think a similar approach would be enough. I would push it to this repo.

@dyladan Not sure if pushing to this repo will work from within CI, I'm not very familiar with CircleCI.
I think the data has to be maintained in a separate repo, because otherwise there will be merge conflicts right?
Currently benchmark data is exported as JSON and stored with historical data.
Kinda stuck on the pushing part though.

It should be implemented as a github action and can either be triggered by a master push, or a release publish. For an example of a release publish triggered build you can look at what we are doing for the docs right now at .github/workflows/docs.yml

done in #4144, benchmarking is now tracked by #4171


iOS support

Currently Warp can't build for iOS targets due to its use of natpmp which relies on native sockets. Apple has decided to lockdown native socket support so this low-level functionality cannot be used directly via natpmp. We should either look for an alternative crate to natpmp or extend it with iOS (and potentially Android) support via iOS frameworks.

Warp doesnt use natpmp directly but is depended on in a upstream dependency, however in a upcoming change, i will have it exclude natpmp for ios and default to using igd, which should build and work fine it.

This was resolved with a dependency update upstream.


Ping command uses incorrect source

Information
Describe the bug
In configuration/commands.toml the ping commands reference src_addr_ipv4 and src_addr_ipv6. This results in a KeyError when trying to run the ping command via the webUI.
To Reproduce
Run a ping against any device.
Expected behavior
Ping completes without issue
Screenshots
[D 190722 17:39:39 construct:79] ping inet {target} count 5 source {src_addr_ipv4}
[E 190722 17:39:39 hyperglass:231] Unable to add output to cache: {'location': 'router1', 'type': 'ping', 'target': '<IP_ADDRESS>'}
<IP_ADDRESS> - - [22/Jul/2019 17:39:40] "POST /lg HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 2309, in __call__
    return self.wsgi_app(environ, start_response)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
    response = self.handle_exception(e)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 1741, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
    raise value
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
    response = self.full_dispatch_request()
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
    raise value
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
    rv = self.dispatch_request()
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/opt/rh/rh-python36/root/usr/lib/python3.6/site-packages/flask_limiter/extension.py", line 544, in __inner
    return obj(*a, **k)
  File "/opt/hyperglass/hyperglass/hyperglass.py", line 203, in hyperglass_main
    cache_value = execute.Execute(lg_data).response()
  File "/opt/hyperglass/hyperglass/command/execute.py", line 296, in response
    "scrape", device_config, self.input_type, self.input_target
  File "/opt/hyperglass/hyperglass/command/execute.py", line 141, in __init__
    self.params = getattr(Construct(device), query_type)(transport, target)
  File "/opt/hyperglass/hyperglass/command/construct.py", line 80, in ping
    fmt_command = conf_command.format(target=target, source=source)
KeyError: 'src_addr_ipv4'

Environment
CentOS 7, Python3.6

Looks like this is an issue with my example config file and not the code base itself which is always good.
FYI, the commands.toml file goes away entirely in the next release (see the develop branch). Although users can still override the default commands, the application doesn’t rely on a default config file to run.


[ha-agent] Support more ndm integrations

What does this PR do?
[ha-agent] Support more ndm integrations
Motivation
Describe how to test/QA your changes
Test that when using HA Agent, the new added integrations only run on leader Agent.
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Send and Receive data between two MCUs with only one wire. Is it possible?

Hi!!
Can your library work in a way that it keeps sending and receiving data through two MCUs (with only one wire) in a fixed timing (let's say, at each 10 ms the sender becomes the receiver and after more 10ms it's the opposite around, forever repeating. The pinmode of both MCUs would have to be changing from input to output and in sync with each other.
Can it be done? Or implemented in an example?
Thanks for all your libs! They are great!!

hi, you can setup both MCU as GT_TRX and

MCU_1 send to MCU_2
MCU_2 receive, wait 10ms, send to MCU_1
MCU_1 receive, wait 10ms, send to MCU_2
and so on

Thanks! Are the functions non-blocking? Can I do other stuff in the loop() while sending/receiving data? Also no need to worry about setting pinmode (or attaching and detaching interrupts) at each transition from sender to receiver?

Unfortunately, sending data is blocking function. Receiving is non blocking. Default mode is high-pull, so no need to worry short circuit. Interrupts are disabled while transmitting. This is not good, but necessary for mid and high transmitting speed

Thanks! My transfer will be of only one byte (or a char)  value each time. Do you know how long in ms it takes for each send/receive? If it doesn’ t take too long, it won’t be a problem… Also… can the sending data be modded to be non-blocking? Or it’s not possible?

Time depends on speed of course.
Non blocking - everything is possible :D non blocking means there will be buffer and a bunch of controlling code + new handlers, maybe i will implement it in future, don't have for it time

I’ll run two attinys 85 at 8mhz or 1mhz to save battery power…
I’ll give it a try… and I hope you implement a complete non-blocking in a near future!! :) :)

Hi, pin + gnd

Sure! I Forgot to add writing adding common gnd between them! :)

HI! Do  I have to set the Two MCUS at the same speed? I want to use  a  slave Attiny 85 at 1 MHz. So I'll need to use a Master Attiny167 at 1MHz also or can I leave the 167 at 16 Mhz?

Just set the same transmission speed in library, it not depends on clock speed

I made it work! But  I´m having some trouble on the GT_TRX mode when  switching from sender to receiver after sending one byte. Do I have, when switching from one mode to another, to detach interrupts when switching to sender mode and re-attach interrrupts when changing back to receiver? I´m doing it but not quite working yet...

No, library knows when it is sending data and dont ignores input
bool tickISR() {
        if (GT_ROLE == GT_TRX && transmitting) return 0;

Hi! Individually I can send from one MCU to the other, but I can´t find a way to the receiver be able to send back a byte. It seems that   trx.available() always keeps returning something even after having received a single byte (by trx.read() . I´m not using any buffer value, although I use clearBuffer() to no effect.  Could you add an example of sending back and forth a byte between two mcus using a single wire? I can provide my code if you want....


No way to get status of ongoing poll

Ideally !poll and/or !poll status should repeat the options and list the time remaining.

It was non-trivial and required some refactoring. 26f4c59575612e308fba85949c2b26a227ca3cab.