cachedImplicit for defs

(well, not really cached, more like a doThisDerivationHerePlease)
Motivation: we are wanting to introduce Haskell-style deriving support in stalagmite https://github.com/fommil/stalagmite/issues/1 and https://github.com/fommil/stalagmite/issues/40
@data(deriving = Functor)
class Cat[Food](food: Option[Food], foods: List[Food])

There are a lot of advantages to doing this besides compiletime and runtime performance, not least that it means that instances are defined on the implicit scope of Cat rather than being orphaned.
For basic data types, this means putting a implicit val ... = cachedImplicit on the companion for whatever the user wants.
This works (in the sense that it correctly fails to compile)
import cats.Functor

case class Cat[Food](food: Option[Food], foods: List[Food])
object Cat {
  implicit val CatFunctor: Functor[Cat] = shapeless.cachedImplicit
}

But the following does not (i.e. it compiles but it should not)
import _root_.io.circe
import circe._

case class Cat[Food](food: Option[Food], foods: List[Food])
object Cat {
  implicit def CatEncoder[A: Encoder]: Encoder[Cat[A]] = {
    def CatEncoder = ???
    implicitly[Encoder[Cat[A]]]
  }
}

It compiles because the implicitly recurses on itself via Cat's implicit scope (where we are defining CatEncoder), it's not actually finding the generic instance. This is a big problem because it's easy to make and we want the compiler to catch it rather than recurse.
What we need is something that cachedImplicit but for defs which stops the recursion, and any other gotchas that cachedImplicit is working around.
Would it be as "simple" as copy/pasting the cachedImplicit macro and changing it to support def with type parameters? The caching bit is not so important, it's really just support for this kind of thing that we need https://github.com/milessabin/shapeless/commit/ffe50c8da741f1b0adf1436e0a17bd93ac076964

Can you explain your Cat functor example some more? Why isn't val CatFunctor what you want there?

Because cat has a type variable

Or maybe Functor is a bad example, any implicit that needs a type parameter.

Your circe example fails because Dog isn't a case class.
I'm going to close this for now. Please reopen when you have a small, self contained example of the problem.

I'm working on editing the text.

it is updated

The update makes your question a lot clearer. Thanks.
Could you turn that example into a standalone (ie. no circe dependency) failing test. Thanks.

I guess I could use something from the stdlib like Numeric

standalone
case class Complex[T](real: T, img: T)
object Complex {
  implicit def n[T: Numeric]: Numeric[Complex[T]] = {
    def n = ??? // shadow
    implicitly[Numeric[Complex[T]]]
  }
}

it would be great to have something like this negative example:
object Complex {
  implicit def n[T: Numeric]: Numeric[Complex[T]] = cachedImplicit
}

that failed to compile. To give you a small self-contained positive example, I'd need access to something with a generic deriver from shapeless. Maybe the sexp example? Or is this enough?

what am I talking about... I already have something like this that can be used. The above should succeed when this is in scope
implicit def numericComplex[T: Numeric]: Numeric[Complex[T]] =
  new Numeric[Complex[T]] {
    type CT = Complex[T]
    def plus(x: CT, y: CT): CT = Complex(x.r + y.r, x.i + y.i)
    def times(x: CT, y: CT): CT =
      Complex(x.r * y.r + (-x.i * y.i), x.r * y.i + x.i * y.r)
    def negate(x: CT): CT = Complex(-x.r, -x.i)
    def zero: CT = Complex(Numeric[T].zero, Numeric[T].zero)
    def compare(x: CT, y: CT): Int = {
      val real = (Numeric[T].compare(x.r, y.r))
      if (real != 0) real
      else Numeric[T].compare(x.i, y.i)
    }
  }

OK, that helps.
But, with that in mind, can you try and reduce this some more, if only as an exercise in minimization so that you know the kind of thing I'm looking for in future. For instance, it doesn't have to be Numeric per se, and none of the Numeric method implementations above are relevant.
Try and reduce the example to the bare minimum so that it can form the basis of a test for the fix.

For instance, this is exemplary.

well, excepting that it doesn't have imports :wink:

Negative case, should not compile due to missing implicit (doesn't need to be cachedImplicit, can also be a new method)
import shapeless._

trait Foo[T]

case class Bar[T](a: T)
object Complex {
  implicit def foo[T: Foo]: Foo[Bar[T]] = cachedImplicit
}

positive case, should compile. Add
object Foo {
  implicit def bar[T: Foo]: Foo[Bar[T]] = new Foo[Bar[T]] {}
}

Hmm ... interesting. However I don't think the positive case should compile. foo and bar are ambiguous and have the same relative priority.

I take that back ... not sure. Will investigate.

this is why I find it easier to create examples that I can verify with the compiler.

I've read it again and I'm pretty sure this should work. It's weird that I'm defining an instance for Foo[Bar[T]] on the Bar companion because the realistic case is that there would be generic derivation for Foo and I didn't want to add the 50 LOC of boilerplate for that.

swap cachedImplicit out for
  implicit def foo[T: Foo]: Foo[Bar[T]] = {
    def foo = ??? // shadow
    implicitly[Foo[Bar[T]]]
  }

to see both compiling. To verify the behaviours of this simple trick (sadly only verified runtime), define a Foo[String] on the Foo companion and request an instance of Foo[Bar[String]]. You'll get a stackoverflow for the first case.
implicit val string: Foo[String] = new Foo[String] { }

I'm not sure this is a "bug" since cachedImplicit is only supposed to work for val, rather a feature request to support implicit def.
BTW, perhaps the example is better like this:
import shapeless._

trait Foo[T]

case class Bar[T](a: T)
object Bar {
  implicit def foo[T: Foo]: Foo[Bar[T]] = cachedImplicit
}

positive case, should compile. Add
import Derived._

object Derived {
  // not really generic derivation, but good enough for our purposes
  implicit def bar[T: Foo]: Foo[Bar[T]] = new Foo[Bar[T]] {}
}

I don't think I need this anymore. If anybody else is interested, I'm happy for it to be reopened but it's not something I'll be working on.


1.13.1

server version: 1.13.1
plugin version: 4.9.1
plugin not working.. not load anything please help/fix thanks.

solved .. problem caused by config


Read a specific 2D (level) field

Whitelist (and blacklist) currently for 3D fields currently only work with Base-names. So selecting a specific model level of for example snow is currently not possible.
This requires some filtering in the R script (get_all_fields).

This requires R-script changes

@kobebryant432 are you familiar with R, and are able to take up this (and #41) ? If not, i can take up these issues.


Roslyn analyzer for AM

Started working on one (WIP)

Codecov Report

Merging #284 (8fa132a) into master (a462a52) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   75.91%   75.94%   +0.02%
==========================================
  Files         106      106
  Lines        8737     8737
  Branches     1475     1475
==========================================
+ Hits         6633     6635       +2
+ Misses       1618     1617       -1
+ Partials      486      485       -1

Impacted Files
Coverage Δ

...nuous/Solvers/EquationSolver/InvertNode.Classes.cs
46.39% <ø> (ø)

AngouriMath/Convenience/MathS.cs
64.00% <100.00%> (ø)

...ouriMath/Functions/ExpressionNumerical.Equality.cs
100.00% <0.00%> (+9.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a462a52...8fa132a. Read the comment docs.


Remove debug option and make http service error logs optional

Motivation
Which issue does this fix? Fixes #35
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Docs have been updated (if applicable)

I have checked and tested the current functionality and I think that the option to run without debug information is not necessary, on the contrary, I have changed the default behavior and turned off HTTP service error logs with the possibility to turn them back on.
I've been going through the other HttpService and ManagementSDK setup options, but I don't think we're missing anything else there for now.

I think, it might be worth it to mention this change also in the Debugging section in readme.md.
I would add something like:
By default we do not provide any additional logs from the HttpService. If you require these logs, you can change this behaviour by using (option --log-http-service-errors-to-console).
What do you think about it @winklertomas @Simply007


flash-attn-with-kvcache has performance issue for torch 2.5.0

flash-attn version=2.6.3
torch version: 2.5.0 nightly
    dec_len = 1
    batch_size = 32
    context_len = 16000
    print(batch_size, dec_len, context_len)

    with torch.device("cuda"):
        q = torch.randn((batch_size, dec_len, 32, 128), dtype=torch.bfloat16)
        k_cache = torch.randn((batch_size, context_len, 32, 128), dtype=torch.bfloat16)
        v_cache = torch.randn((batch_size, context_len, 32, 128), dtype=torch.bfloat16)
        k = torch.randn((batch_size, dec_len, 32, 128), dtype=torch.bfloat16)
        v = torch.randn((batch_size, dec_len, 32, 128), dtype=torch.bfloat16)
        cache_seqlens = torch.zeros(batch_size, dtype=torch.int32)
        cache_seqlens += 15996

    torch.cuda.synchronize()
    t1 = time.perf_counter()
    for i in range(1000):
        flash_attn_with_kvcache(q, k_cache, v_cache, k, v, cache_seqlens = cache_seqlens, causal=True)
    torch.cuda.synchronize()
    t2 = time.perf_counter()
    print((t2-t1)/1000)

    torch.cuda.synchronize()
    t1 = time.perf_counter()
    for i in range(1000):
        flash_attn_func(q, k_cache, v_cache, causal=True)
    torch.cuda.synchronize()
    t2 = time.perf_counter()
    print((t2-t1)/1000)

The time taken for flash-attn-with-kvcache is 40% longer than the flash-attn-func. However, this problem doesn't occur for torch=2.4.0

call flash_attn_with_kvcache without block_table ?


WLC_BIT_OVERRIDE_REDIRECT is not set when running dmenu

For some reason wlc_view_get_type comes back as 0.

Should be fixed in 986927f

Thank you.

Related problem. When I do not have an x window open, and I run dmenu (from within sway, I can't type anything into dmenu. It works if I have an x window open to begin with, though. I give unmanaged windows (like dmenu) focus when they appear, but it doesn't seem to help.


Scanner 2.26.2

Checklist

[x] Investigated and inspected CI test results
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed
CI

Why are tests skipped?

@RTann maybe the PR needs to be against master? Or if there is a closed PR to master, then it needs to be tagged to this milestone.
For the 3.72.1 release, this PR to master was cherry-picked by automation when the milestone was closed and the PR was found closed (cut-rc action: https://github.com/stackrox/stackrox/blob/master/.github/workflows/cut-rc.yml#L180): #3424

The version of Scanner on master is for the 73 release, and is not compatible with the 72 release. Updating the version on master will require us to revert another file, which will then all need to be reverted back once we cut this release. Making this PR based on the release branch allows us to avoid those complications.
There precedent for making PRs against the release branch directly, if it's necessary (for example, see https://github.com/stackrox/stackrox/pull/3596 which was merged and is also part of the same Milestone)

Thanks! I'm not sure why OSCI isn't running on this or that PR. I hadn't looked before for OSCI on PR's like this to a release branch. The config for this release is here: https://github.com/openshift/release/blob/e4978df7abc56e88a0f9280de4ef1a2a95d3e38b/ci-operator/config/stackrox/stackrox/stackrox-stackrox-release-3.72.yaml#L390 -> https://github.com/openshift/release/pull/32143/files#diff-cd82043cb1b2c7242c71e63307df514741a8d666f3587e1a722302706fc6c108R6-R7

I believe it's because postsubmit: true is set, so it'll only run upon merge. I don't think direct merges were expected


filters: better UI for in/not in

https://global-power-plants.datasettes.com/global-power-plants/global-power-plants?_sort=rowid&country_long__in=Canada%2C+United+States+of+America%2C+"foo%2Cbar"&primary_fuel__exact=Solar
The UI for IN requires the user to serialize the options themselves. It'd be nice if instead you entered one option at a time, and previous entries became pills that could be X'd out individually.

Eh, not high ROI, and I'd like to push as much to the search box as possible anyway


SPIKE: Become React v18 strict-mode compatible

Once we are running on react v18 in non-strict mode, it will be time to make the necessary component updates so that we are strict-mode compatible. This work can be broken out into multiple tickets if needed depending on results of discovery when strict-mode is enabled. If work is minimal, complete within scope of this ticket.
Acceptance Criteria

Strict-mode enabled via <React.StrictMode></React.StrictMode> tags

[ ] in index.tsx and CustomRenderUtils.tsx, make it the first component wrapping everything

Necessary fixes to components made to be strict-mode compatible so that...

[ ] No errors in yarn run test
[ ] All pages in local dev mode operate correctly with no errors in browser console

We are blocked from being strict-mode compatible due to react-uswds. There were a few failing tests, and the first one I investigated seems to point to the FilePreview component causing an error due to the second load's useEffect attempting to read the file while it is still loading from the previous iteration.


update CHANGELOG

Codecov Report

Merging #1621 (84f9e77) into main (4b9d1fe) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
+ Coverage   93.89%   93.91%   +0.01%
==========================================
  Files         253      253
  Lines       47396    47396
==========================================
+ Hits        44503    44511       +8
+ Misses       2893     2885       -8

Impacted Files
Coverage Δ

src/postings/stacker/expull.rs
98.57% <0.00%> (-0.48%)
:arrow_down:

src/termdict/sstable_termdict/termdict.rs
74.46% <0.00%> (ø)

src/fastfield/multivalued/mod.rs
98.45% <0.00%> (+0.38%)
:arrow_up:

src/core/segment_reader.rs
91.16% <0.00%> (+0.40%)
:arrow_up:

src/store/index/mod.rs
98.37% <0.00%> (+0.54%)
:arrow_up:

src/directory/composite_file.rs
96.61% <0.00%> (+3.38%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Download datapacks and resource packs

Enable support to download datapacks and resource packs from modrinth

Won't fix


Keyboard management does not work

Microsoft PowerToys version
0.68.1
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce
os：windows11 professional，22h2，22621.1413。
app：0.68.1
Keyboard management does not work .When it doesn't work, I have to reconnect the keyboard.
PowerToysReport_2023-03-17-21-07-02.zip
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

Hi, did you try restarting PowerToys instead of reconnecting keyboard? Does it also help to fixkeyboard manager? /needinfo


Update Readme to highlight submission with chart src as a preference

We would prefer partner to submit chart source to make it easier for us to ptovide recommendation in the event of failures.
Make this clear in the doc , maybe provide all examples using src and add note at bottom to say tarball also possible.

Done


MINOR: do not start processor for bounce-at-start

Do not start the processor for test_broker_type_bounce_at_start; only start it after the broker has been shutdown.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

System test builder for the patch:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1370/
System test builder for trunk, as baseline to compare and re-produce the issue:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1371/

@bbejeck for reviews.

Can you elaborate. It say's MINOR but is a 500 lines PR -- the change to the system test LGTM, but I am not familiar with the ZK code...

It should only be a few lines... I'll rebase.

First system test did not start running but failed.

First system test did not start running but failed.

I have found the issue and re-triggered in https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1372/

System test did not pass.

System test did not pass.

Yup, I'm looking into this. What's interesting is that on trunk with 100 runs I cannot re-produce this issue even once. So maybe it is a very rare case, but anyways I think I can still figure out the blocker for the system test failure.

So I've run my patch on https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1385 for 100 runs without issue; ironically running trunk on the branch builder does not reproduce this issue either: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1377.
But from trouble shooting this issue I still think this PR is needed to prevent this race condition (though it may be very unlikely).


Nuxt: side menu basePath if set to '/' ignores host

What happens?
when pathRouting basePath is set to '/' main navigation redirects to
https://tag/menu-element
instead of
https://host/tag/menu-element
What did you expect to happen?
correct redirect
How can we reproduce the issue?
https://codesandbox.io/p/devbox/nuxt-playground-forked-32ms33
click on any menu item

OpenAPI Document
No response
edit: I actually see that codesandbox redirects almost correctly just // after host

nav link is still incorrect

so that double / causes issue on localhost dev env unless we boot nuxt with custom host
edit2: culprit is here so with base path / it will be //id
https://github.com/scalar/scalar/blob/f82a76776be134c2f5263727fc912a287f8d330a/packages/api-reference/src/components/Sidebar/SidebarElement.vue#L48

lets do this a bit smarter!


fixup! [nrf noup] tree-wide: support NCS Partition

Will be squashed.
Use partition manager defines instead of kconfig deduced from
devicetree for RPMSG shared memory.
Ref: NCSDK-11234
Signed-off-by: Håkon Øye Amundsen<EMAIL_ADDRESS>

Nice

seems other autosquash tags are also permitted, so:
[nrf noup] area: short log goes here

fixup! [nrf noup] tree-wide: support NCS Partition

is also correct.


Attempt to enable a second Bitbucket repo results in UNIQUE constraint failed: orgs.name

Component
server
Describe the bug
Hi! I am attempting to build and run a new installation of woodpecker and encountered the following issue when adding repositories:
Steps to reproduce
Launch a woodpecker server (v1.0.5) and agent instance using the Bitbucket repo client.
From the repositories tab, choose a repo and click Enable.
Again, from the repositories tab, choose a second repo and click Enable.
Expected behavior
The repository is enabled successfully.
Actual behavior
The bottom right of the screen contains the following error highlighted in red:
UNIQUE constraint failed: orgs.name, which is a SQLite error.
System Info
/version returns:
`{"source":"https://github.com/woodpecker-ci/woodpecker","version":"1.0.5"}`

I'm not using docker-compose, but here are the sanitized ansible tasks that provision the server and agent containers:

- name: Run Woodpecker Docker Container
  community.docker.docker_container:
    name: woodpecker
    image: "{{ woodpecker_version }}"
    env:
      WOODPECKER_HOST: "https://{{ woodpecker_server_host }}"
      WOODPECKER_LETS_ENCRYPT: "true"
      WOODPECKER_LETS_ENCRYPT_EMAIL<EMAIL_ADDRESS>      WOODPECKER_BITBUCKET: "true"
      WOODPECKER_BITBUCKET_CLIENT: "{{ woodpecker_bitbucket_client }}"
      WOODPECKER_BITBUCKET_SECRET: "{{ woodpecker_bitbucket_secret }}"
      WOODPECKER_AGENT_SECRET: "{{ woodpecker_rpc_secret }}"
      WOODPECKER_LOG_LEVEL: "trace"
      WOODPECKER_ADMIN: "myuser,anotheruser"
      WOODPECKER_OPEN: "false"
      WOODPECKER_REPO_OWNERS: "companyname"
    ports:
      - "80:80"
      - "443:443"
      - "9000:9000"
    restart_policy: "always"
    volumes: "/var/lib/woodpecker:/var/lib/woodpecker"

- name: Run Woodpecker Runner Container
  community.docker.docker_container:
    name: runner
    image: "{{ woodpecker_agent_version }}"
    env:
      WOODPECKER_SERVER: "server.domain.tld:9000"
      WOODPECKER_AGENT_SECRET: "{{ woodpecker_rpc_secret }}"
      WOODPECKER_HOSTNAME: "localhost"
      WOODPECKER_MAX_WORKFLOWS: "5"
      WOODPECKER_LOG_LEVEL: "info"
    ports:
      - "3000:3000"
    restart_policy: "always"
    volumes:
      - "/var/run/docker.sock:/var/run/docker.sock"
      - "/var/lib/woodpecker-agent-conf:/etc/woodpecker"

### Additional context

With trace level logging enabled, I see:

{"level":"trace","time":"2023-11-09T20:53:07Z","caller":"/woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/router.go:43","message":"[POST] /api/repos?forge_remote_id={37418eb3-cdb7-4bf5-a8a0-7953042cd586}"}

I speculate this bug is being triggered at or around https://github.com/woodpecker-ci/woodpecker/blob/main/server/api/repo.go#L129

### Validations

- [X] Read the [Contributing Guidelines](https://github.com/woodpecker-ci/woodpecker/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://woodpecker-ci.org/docs/intro).
- [X] Check that there isn't [already an issue](https://github.com/woodpecker-ci/woodpecker/issues) that reports the same bug to avoid creating a duplicate.
- [X] Checked that the bug isn't fixed in the `next` version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
- [X] Check that this is a concrete bug. For Q&A join our [Discord Chat Server](https://discord.gg/fcMQqSMXJy) or the [Matrix room](https://matrix.to/#/#woodpecker:matrix.org).

Also, here's the sqlite dump of the orgs table:
sqlite> .schema orgs
CREATE TABLE `orgs` (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, `name` TEXT NULL, `is_user` INTEGER NULL, `private` INTEGER NULL);
CREATE UNIQUE INDEX `UQE_orgs_name` ON `orgs` (`name`);

sqlite> .dump orgs
PRAGMA foreign_keys=OFF;
BEGIN TRANSACTION;
CREATE TABLE `orgs` (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, `name` TEXT NULL, `is_user` INTEGER NULL, `private` INTEGER NULL);
INSERT INTO orgs VALUES(1,'',0,0);
COMMIT;

sqlite> select * from orgs;
1||0|0

As you can see, the name field in the above record is the empty string.

Found a workaround: drop the index.
sqlite> drop index UQE_orgs_name;
I now end up with these two rows:
select * from orgs;
1||0|0
2||0|0

So it complains as the names of your orgs are somehow `` or null. Related code should be https://github.com/woodpecker-ci/woodpecker/blob/main/server/forge/bitbucket/bitbucket.go#L402

Hi, @anbraten!
Confirming that both the workspace name and the workspace ID in Bitbucket are populated with strings in the pattern [A-Za-z]+.

Workaround not helpful- if you restart the service, it will be caught in a crashloop with:
{"level":"fatal","error":"msg: Sync error '*model.Org': UNIQUE constraint failed: orgs.name","time":"2023-11-09T22:11:02Z","message":"could not migrate datastore"}


Tag gadts

It took a while but its here!
In this pull request I created the tags coq_tag_gadt , coq_tagged_match so that my implementation is retro-compatible with the working code.
Here is an example of how these options will work
type 'a term =
  | Int : int -> int term
  | String : string -> string term
  | Sum : int term * int term -> int term
  | Pair : 'a term * 'b term -> ('a * 'b) term
[@@coq_tag_gadt]

let rec get_int (e : int term) : int =
  match[@coq_tagged_match][@coq_match_with_default] e with
  | Int n -> n
  | Sum (e1, e2) -> get_int e1 + get_int e2
  | _ -> .

Will be translated to
Inductive term : vtag -> Set :=
| Int : int -> term int_tag
| String : string -> term string_tag
| Sum : term int_tag -> term int_tag -> term int_tag
| Pair : forall {a b : vtag}, term a -> term b -> term (tuple_tag a b).

Fixpoint get_int (e : term int_tag) : int :=
  match e in term t0 return t0 = int_tag -> int with
  | Int n => fun eq0 => ltac:(subst; exact n)
  | Sum e1 e2 =>
    fun eq0 => ltac:(subst; exact (Z.add (get_int e1) (get_int e2)))
  | _ => ltac:(discriminate)
  end eq_refl.

The key idea is that we are tagging the indexes of the GADT so that they are unique and distinguishable for Coq metatheory, this allows us to be smart on how to build dependent pattern matches that will discharge impossible branches by solving simple inequations.

Top again for the work! I added a first round of reviews.


Use json/jq to pick out the validator address

https://github.com/palomachain/paloma/issues/300
Background
The method previously used, palomad keys list --list-names doesn't list addresses which don't have a name,
which can happen particularly when recovering an address. We'll use a less error-prone method with jq.
Testing completed

[x] manual testing

@Vizualni 🏓 (or close?)

Closing (:


Training wont work - AttributeError: 'ChatBot' object has no attribute 'find'

AttributeError: 'ChatBot' object has no attribute 'find'
Chatterbot 1.0.8
The code is the ListTrainer quickstart example from the docs
I dont think theres any problems with my code, its a problem with the module

Faced this a long ago and quit chatterbot. Today I need chatterbot for a project and came to report this issue. And found this was issued 3 days ago. Hoping quick response from the maintainers. Please :)

@Ufgtftcbtcut found a solution after few google searches.
Use ListTrainer(chatbot.storage) instead of ListTrainer(chatbot).
See this

Oh. Then, can the docs be updated?

@Ufgtftcbtcut found a solution after few google searches. Use ListTrainer(chatbot.storage) instead of ListTrainer(chatbot).
See this

Thank you very much solved.

邮件已收到，谢谢您！


Add cross-press support for enocean binary_sensor

At this moment the enocean/binary_sensor supports only 6 of 8 possible combinations.
The PTM215 module (Eltako FT55) can also pressed crossed (left button on, right button off).
It would be nice to see support for this in one of the next versions.

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum. Thanks!


Change empty strings to null

@franckc noted in discord that nulls are the preferred way to not have an env var set, over empty strings ''.
https://webpack.js.org/plugins/environment-plugin/#usage-with-default-values
Not 100% sure this is the right move, as we may have code which depends on a value being set, even if its an empty string.

I'm not entirely sure how to test this in the local environment because I think that those config values are used in the deployment process. It may also be worth considering that many of these values are just passed through to origin-js in its constructor, but surely it doesn't require any empty strings. I would say that if this breaks something, then we need to fix the broken thing rather than depend on strings here. I haven't found any issues yet. So just merge it and see what happens?

@tomlinton FYI

@franckc I resolved a conflict here. Can this be merged?

I'm nervous to change all these to null so late in the game if nothing was breaking. You sure you want to do this?

@wanderingstan I'll defer to @franckc. I don't see what the downside is, but I'm not the one dealing with the deployment process.

This is a cleanup and not a must-have so I'd say let's hold off for after V1 when we have more time to test...

Let’s hold off.
On Sun, Sep 30, 2018 at 10:48 PM Franck<EMAIL_ADDRESS>wrote:

This is a cleanup and not a must-have so I'd say let's hold off for after
V1 when we have more time to test...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OriginProtocol/origin-dapp/pull/609#issuecomment-425795897,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuxN7HfPnCPVtI775RSlRffZrJqTRz_ks5ugayTgaJpZM4W9oS_
.

--
Cofounder of Origin http://www.originprotocol.com
Join our Telegram http://t.me/originprotocol

...and when we come back to this, I think we all agree that we should have the all the actual default values here in webpack.config instead of sprinkled across the code.

Closing because https://github.com/OriginProtocol/origin/commit/d2525d26b2861e2b4be06b39006d098b48124282#diff-e902c2e5a1c422350a63ae6f2ec8e67a 😐


[Snyk] Security upgrade alpine from 3.13.0 to 3.17

Snyk has created this PR to fix 4 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

Dockerfile

We recommend upgrading to alpine:3.17, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Out-of-bounds Read SNYK-ALPINE313-APKTOOLS-1533754
  714

Buffer Overflow SNYK-ALPINE313-OPENSSL-1569448
  714

Buffer Overflow SNYK-ALPINE313-OPENSSL-1569448
  714

Out-of-bounds Write SNYK-ALPINE313-ZLIB-2976175
  714

Use After Free SNYK-ALPINE313-BUSYBOX-1920736
  614

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Use After Free

Checkmarx One – Scan Summary & Details – 63bfe8de-e91d-40ab-82e6-b225a1329516
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Unpinned Actions Full Length Commit SHA
/tests.yaml: 36
desc

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 28
desc

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 26
desc

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 22
desc

CVE-2024-6484
Npm-bootstrap-3.4.1
Vulnerable Package

CVE-2024-6485
Npm-bootstrap-3.4.1
Vulnerable Package

Unpinned Package Version in Apk Add
/Dockerfile: 61
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Healthcheck Instruction Missing
/Dockerfile: 52
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

Fixed Issues

Severity
Issue
Source File / Package

CVE-2007-2379
Npm-jquery-3.7.1

CVE-2014-6071
Npm-jquery-3.7.1

Unpinned Package Version in Apk Add
/Dockerfile: 61

Healthcheck Instruction Missing
/Dockerfile: 52


Saving feature names - 'Booster' object has no attribute 'feature_types'

Hi,
if I follow this issue and follow the advice of @khotilov in https://github.com/dmlc/xgboost/issues/3089 ie:
if hasattr(bst, 'feature_names'): bst.set_attr(feature_names = '|'.join(bst.feature_names))

Then after loading that model you may restore the python 'feature_names' attribute:

if bst.attr('feature_names') is not None: bst.feature_names = bst.attr('feature_names').split('|')

, I get the error:
 'Booster' object has no attribute 'feature_types'
Maybe I miss something in the first place to save the feature names together with the binary format? Where do I "handover" a list of feature names?

The feature names originate from a DMatrix (data matrix) object. You need to run bst.predict() at least once so that the feature names get transferred from the training DMatrix to the Booster object.


Add PPTX processor

Hi there,
I've made some enhancements to the Langchain gem by adding support for the PPTX file format. Specifically, I've included the power_point_pptx gem as a development dependency, allowing Langchain to process PowerPoint presentations.
Changes made:

Added support for PPTX files.
Updated the list of supported file formats to include PPTX.
Included power_point_pptx (~> 0.1.0) as a development dependency.

@willywg Thank you for the PR!


chore: update translations for zh-cn locale

Summary
This updates translations for the zh-cn locale
Testing
👀

Hi @scnwwu!
You've previously been responsible for updating zh-cn translations.
Would you mind updating the translations in this pull request by either:

Adding suggestions for each translation in this pull request. click here for more information on adding suggestions.
Updating the attached CSV and attaching it to the pull request

zh-cn-locale-update-Dec2023.csv


Prevent Text From being highlighted

The text doesn't seem to highlight, but willing to make more changes as needed.

@Subrina45 This is better than nothing but does not close either of the two issues linked.
#22 should not be closed since this prevents all selection of this text, as we've discussed in call, we only want to prevent it when the mouse leaves the canvas.
Regarding #42 this PR does not address it in anyway.


FIleSystem View to handle same fileIds across partitions correctly

FileSystem View must treat same fileIds present in different partitions as different file-groups and handle pending compaction correctly.
As we move to onboarding non-hudi datasets to Hudi, it will be easier if Hudi does not make any assumptions on file-id uniqueness across partitions. Also, Timeline service will persist these data-structures in disk and hence, it is important to get the schema (of file-system view data-structures) correct.

@n3nash : Ready for review

@bvaradar The changes look fine to me but have a general comment. It looks more like a bandaid solution to pass partitionPath in all places. Should the partitionPath should be part of the fileSlice since now a FileId by itself is not describable given duplicates are possible ? WDYT ?

@n3nash : Having FileSlice store partitionPath makes sense to me since it already has fileId. Will make the change.

@n3nash : Addressed review comments. Please take a look.

@n3nash : Can you take a look.

@n3nash @vinothchandar : Addressed your comments.

@vinothchandar : Fixed


(BUG) The FV is opened automatically after canceling FV

Steps to reproduce:

Open the "Face Verification" page with "OK, VERIFY ME" button
Click the  "OK, VERIFY ME" button
Click the "X" close button to close the pop up with the oval camera shape
Pay attention to the automatically opens pop-up again

Actual result: The FV is opened automatically after canceling FV. User cannot close the FV and move to other actions
Expected result: The "Face Verification" page with "OK, VERIFY ME" button should be displayed after canceling FV
Video: https://www.screencast.com/t/Y9H3uDZNf
Checked on DEV V1.0.6-0
LG V30+ // Android 8.0 // Google Chrome 84.0.4147.111
Desktop: Windows 10 // Google Chrome  84.0.4147.125

@AnastasiiaOdnoshevna I pushed a fix to the master so it will be available on gooddev after a 10 minutes.

@yaroslav-fedyshyn-nordwhale the issue isn't reproduced
Checked on DEV V1.0.6-0
LG V30+ // Android 8.0 // Google Chrome 84.0.4147.111
Desktop: Windows 10 // Google Chrome  84.0.4147.125

@yaroslav-fedyshyn-nordwhale if you're hotfixing please link the commit here
so i could easily find it


False negative for Thieme Synthesis article

https://www.thieme-connect.de/products/ejournals/html/10.1055/s-2007-965924 is open access but http://api.oadoi.org/10.1055/s-2007-965924 says it's closed. To be reported to CrossRef? Thieme is not in BASE yet and I couldn't find an OAI-PMH endpoint, I wrote them.

Are you sure that this full text is available for free? I'm redirected to https://profile.thieme.de/HTML/sso/ejournals/login.htm?type=default&subsidiary=www.thieme-connect.de&hook_url=https%3A%2F%2Fwww.thieme-connect.de%2Fproducts%2Fejournals%2Fhtml%2F10.1055%2Fs-2007-965924 where Thieme asks me to login, see:

Alternatively, maybe request Thieme to report license information to CrossRef? That might be easier than setting up a OAI PMH data provider... and BASE reads information from CrossRef as well.
See also: #24

No, I'm not sure the full text is available: I'm redirected to a login page too now. I was at home when I reported this so I'm not sure what happened. I could close this, your issue seems to have better info.
Yes, BASE and CrossRef would be happy to receive such information (cf. https://github.com/Impactstory/oadoi/issues/28 ), but I'm not sure what's an effective way to ask. I've written some journals and asked some authors to ask their journals, but I didn't get replies so far. If you work for a Thieme customer then maybe you could try and contact them.

I'm not representing a customer, but we have some contacts at Thieme... I'll give it a try. They get a place on my growing list of publishers to bug from time to time as well ;)

oaDOI now showing closed, as it should.


Add point-source direction resolution to paper

Train azimuth on systematic sets and calculate point-estimate sensitivities/bias and add it to respective robustness plots

fixed


Comments are copied verbatim without checking if they might be invalid

C and Rust comments are not the same. bindgen copies comments verbatim anyway, and this breaks things.
For example, here's an excerpt from a real-life header I was using with bindgen 0.19:
#include <stddef.h>
#include <stdint.h>

typedef uint32_t mbedtls_mpi_uint;

/**
 * \brief          MPI structure
 */
typedef struct
{
    int s;              /*!<  integer sign      */
    size_t n;           /*!<  total # of limbs  */
    mbedtls_mpi_uint *p;          /*!<  pointer to limbs  */
}
mbedtls_mpi;

bindgen 0.20 output for this type is:
/* automatically generated by rust-bindgen */

pub type mbedtls_mpi_uint = u32;
/**
 * \brief          MPI structure
 */
#[repr(C)]
#[derive(Debug, Copy)]
pub struct _bindgen_ty_2 {
    /*!<  integer sign      */
    pub s: ::std::os::raw::c_int,
    /*!<  total # of limbs  */
    pub n: usize,
    /*!<  pointer to limbs  */
    pub p: *mut mbedtls_mpi_uint,
}
#[test]
fn bindgen_test_layout__bindgen_ty_2() {
    assert_eq!(::std::mem::size_of::<_bindgen_ty_2>() , 24usize);
    assert_eq!(::std::mem::align_of::<_bindgen_ty_2>() , 8usize);
}
impl Clone for _bindgen_ty_2 {
    fn clone(&self) -> Self { *self }
}
pub use self::_bindgen_ty_2 as mbedtls_mpi;

which rustc does not like:
error: expected outer doc comment
  --> <anon>:10:5
   |
10 |     /*!<  integer sign      */
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: inner doc comments like this (starting with `//!` or `/*!`) can only appear before items

Oh, that sucks, is it really a parse error?
cc https://github.com/rust-lang/rust/pull/38825 and https://github.com/servo/rust-bindgen/issues/378.

It seems we need to process comments no matter what, sigh.

I think it shouldn't be that hard. If the comment is C-style and the first character is * or !, insert a space. Otherwise, if the first character is / or !, insert a space.

I'm having this issue as well. This seems like it should be very common, since there are a lot of libraries with Doxygen comments. Is there at least a way to turn off the copying of comments? What if I don't need annotations? At the very least, what @jethrogb would at least let me use bindgen. Everything else about the bindings is great!

It looks like we need to fix this here, based on the following discussion of these kinds of errors:
https://github.com/rust-lang/rust/issues/2789

I'm landing a workaround in https://github.com/servo/rust-bindgen/pull/444, since I don't have the time to write the proper fix right now. This should allow people to keep using bindgen meanwhile.

Same issue when building FAST
mmacy@DuhBuntu [~/devel/ruFAST|18:11|146] cargo build
Compiling ruFAST v0.1.0 (file:///storage/mmacy/devel/ruFAST)
error: expected outer doc comment
--> /storage/mmacy/devel/ruFAST/target/debug/build/ruFAST-d825d3ad93645a05/out/bindings.rs:41738:1
|
41738 |   /*! \brief Class interface for cl_mem.
|  ^ starting here...
41739 | |  *
41740 | |  *  \note Copies of these objects are shallow, meaning that the copy will refer
41741 | |  *        to the same underlying cl_mem as the original.  For details, see
41742 | |  *        clRetainMemObject() and clReleaseMemObject().
41743 | |  *
41744 | |  *  \see cl_mem
41745 | |  */
| |__^ ...ending here
|
= note: inner doc comments like this (starting with //! or /*!) can only appear before items
error: Could not compile ruFAST.
To learn more, run the command again with --verbose.

@mattmacy assuming since you're running cargo build you've got a build.rs. did you set the "skip comment generation" flag there?
bindgen::builder().generate_comments(false)

@snewt yes, I got past that point by doing so

@ildart suggests in #650 converting them to rustdoc. It's slightly tricky, but should be doable.

A related issue is that sometimes comments aren't actually doc comments, like with this sort of pattern:
#if !SOME_DEFINE
    int field_a;
    int field_b;
#endif //!SOME_DEFINE


Notify when dotenv file is improperly formatted

When the library is given a dotenv file that is in INI format (by mistake in my case), it will not create environment variables. I can't find where users are notified of this. Should they be and how?
Here is stuff to reproduce.
.env
[secrets]
DB_PATH=securepath
DB_NAME=perfectname

main.rs
use std::env;
use dotenvy::dotenv;

fn main() {
    env_logger::init();

    dotenv().ok();
    for (key, value) in env::vars() {
        println!("{key}: {value}");
    }
}

dependencies
dotenvy = "0.15.1"
env_logger = "0.9.0"
log = "0.4.17"

Run with $ RUST_LOG=debug cargo run | grep DB_

@mpmoran: The problem is most likely the dotenv().ok();.
That code turns the Result (that dotenv returns) into an Option (see Result::ok). So you are basically just ignoring any error that dotenv might return.
The example of the dotenv function (which is just dotenvy::dotenv().ok();) is probably not the best example that could be shown.

@d4h0 good comment. I've removed the ok() examples to make this more clear.
@mpmoran dotenvy does inform you of parse errors. Using the same .env file as your example:
fn main() {
    let e = dotenvy::dotenv().unwrap_err();
    print!("{}", e);
}

Error parsing line: '[secrets]', error at line index: 0

I'm going to politician this and say that I can't affirm or deny the previous comments. I'm no longer using this library. Please deal with this issue as it deserves.

This is working when the line is changed to dotenvy::dotenv()
@mpmoran feel free to reopen if you still have issues.


Asserts: use DEFAULT_LONG_TIMEOUT in eventually()

And update javadoc to say why. Also makes the timeout configurable
via -Dbrooklyn.test.defaultTimeout=1s.

LGTM, merging.


Update CAPO CLI Flags

Flag --metrics-bind-addr has been deprecated, Please use --diagnostics-address instead. To continue to servemetrics via http and without authentication/authorization set --insecure-diagnostics as well.

Note this is just CAPO being behind the times.  There are new values:
cluster-api-core:
  capi_diagnostics_address: :8443
  capi_insecure_diagnostics: false

for all other components.  We should consider altering the script to make these use .Values.global variables to set them in one place.


Loading image from cache takes up to 1.5 seconds

How can I decrease time of loading image from cache? There is no point in caching if image can be downloaded faster from the internet than from cache.

it's the same.  download=>decode. i think you should decrease your image size..

Thanks for the reply, yes, caching work very fast if image size is not too big, but on large images (4k for example), it takes some time.


Fixed #20223 -- Added keep_lazy() as a replacement for allow_lazy()

This is actually a rebased version of #1007 / #4002 which fixes the @timgraham remarks on those

buildbot, add to whitelist.

A few cosmetic edits you can apply with patch -p1 -i raw.diff: http://dpaste.com/1GRCAC2

Looks like you need to add lazystr to utils/encoding.py -- unfortunately this creates some circular imports. You can fix them by moving from django.utils.functional import Promise to inner method imports in utils/encoding.py. Please rebase your branch and squash commits when fixing. Thanks!

@timgraham I'll check the test failures later, can't reproduce locally right now

@timgraham tests are green again, and I should have fixed the double line breaks in docs

merged in d693074d431c50e4801dd6bf52525ce1436358f0, thanks!

Thanks @timgraham !


Replace dependency on Hadoop-BAM with Disq

Closing as WontFix, see https://github.com/heuermh/disq-adam


@XmlAttribute(required = true) is ignored

My problem is explained here.
My Objects are generated using an XSD file which contains @XmlAttribute(required = true) but this doesn't affect the properties in Swagger. When I add @ApiModel and @ApiModelProperty(required = true) It works fine but I don't want to do this manualy for a generated object.

JAXB annotations are not parsed by default. #960 contains two methods to introduce the parsing. Keep in mind that in Springfox this may not work, and in that case you'd need to ask in their project.


Two way binding is not working in ngOpen

I think here is bug because i don't see two way binding. when i click on check box then the direction of the arrow changes but i click on the arrow the direction is changed but there is no effect on check box.
I am wondering whether this is bug or not.

The workaround doesn't work anymore, because Chrome now focuses the summary element on the first click, and only the second click removes the "open" attribute.

Is that a bug in Chrome? It seems weird that it is not bubbling the click event.

Yes, something is odd about this.

Here is a better workaround, which should be able to form the basis for an actual solution: http://plnkr.co/edit/B4zLrOK8yXZoPIUDyKCg?p=preview
It makes use of the fact that the <details> element emits a toggle event whenever its "open" status changes.
mod.directive('details', function($parse) {
  return {
    restrict: 'E',
    link: function(scope, element, attrs) {
      if (angular.isDefined(attrs.ngOpen)) {
        var ngOpen = $parse(attrs.ngOpen);
        element.on('toggle', function(ev) {
          scope.$apply(function() {
            ngOpen.assign(scope, element.attr('open') === 'open');
          });
        });
      }
    }
  }
});


[Script]: Chinese Number Plate Scanner

Aim
Hello @avinashkranjan ,
Adding a Chinese number plate scanner which helps the China for the traffic ratio evolution also I when I was visited the Shanghai for a project on E-Traffic Catcher me and  my friend who is from IIT Delhi developed this for the China Traffic and we are the winner of that project.
So, I think I should add this in your Project {Amazing-Python-Scripts}
Soon will raise a PR 👍🏻
Details
It is an end-to-end Chinese license plate recognition software based on U-Net, OpenCV, and CNN, where U-Net and OpenCV are used for license plate localization and correction, and CNN is used for license plate recognition. Both U-Net and CNN are implemented using TensorFlow's Keras.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Go Ahead @SyedImtiyaz-1


Widths and aligning of navbar; use proper css

What could be better
navbar is now bad css
On what page are you experiencing this problem
EVERYWHERE!!!
Additional context
https://stackoverflow.com/questions/39767411/center-middle-flexbox-item-and-justify-the-rest

Let's tag @StijnToemen :)

This is OK now @StijnToemen ? You sneakily added more improvements, not just a color change? :smile:


BFD: Data Ratios: Carrier

Requested Feature
RIF export ratios need adjustments:

ratio of types of claims overall
ratio of claim types per bene
ratio of lines per claim type

Claim Ratio = Claim of Type / Claim Total across all types
Synthea Total:  1,054,589,695
Actual Total:  23,195,755,891

Table
Claim % (Synthea)
Claim % (Actual)
Notes

carrier
12.94
31.05
underrepresented in Synthea

Table
Average Line/Claim (Synthea)
Average Line/Claim (Actual)
Notes

carrier
9.46
2.03
overrepresented in Synthea

"Actual" counts as of analysis time.

Table
Count

beneficiaries
83,178,011

carrier_claims
7,203,110,966

carrier_claim_lines
14,634,334,226

Full data analysis for all tables is here: https://github.com/synthetichealth/synthea/wiki/RIF-Data-Analysis

Claims per Beneficiary

Synthetic
Real

Claims Lines per Claim

Synthetic
Real


use julia-docdeploy action

This switches the default GHA + Documenter config to use the julia-docdeploy action in order to take advantage of the new in-line annotation feature: https://github.com/julia-actions/julia-docdeploy/releases/tag/v1.2.0.
Uses buildpkg to build while avoiding the package server (and also to follow the julia-docdeploy README example).

Seems cool!
Are there any downsides to this switch?

 That logger emits @error and @warn etc in a way that GitHub actions understands, so GitHub actions can generate the annotations. There's no API calls etc, it's just printing the warnings with the GitHubActions-approved formatting (https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#setting-an-error-message) so it can use them.

All sounds good to me!
looks like the reference tests need to be updated with the same change (https://invenia.github.io/PkgTemplates.jl/dev/developer/#Updating-Reference-Tests-and-Fixtures-1)
If you bump the version too, we can merge and make a release as soon as CI passes


Suggestion: An graphical user interface like p4vasp

Since the development of p4vasp has stopped, I suggest it would be very helpful to develop an alternative user interface based on py4vasp.

We don't have any immediate plans to work on a graphical user interface. For the moment interacting with the data produced by VASP within a Jupyter environment is fine for us. Are there any specific things you have in mind that you could do with a GUI that would not be possible within a Jupyter notebook?

In p4vasp, I'd like to see the atoms' movement during the relaxation, and also, I could choose some atoms, and fix their coordinates, generate a new POSCAR file. I am not sure how to do that with py4vasp.
Is there a tutorial on how to use py4vasp in Jupyter?

The creation of input files is currently not supported, but this is planned for a future release of py4vasp. Visualization of the structure during a relaxation or MD simulation is already possible. We have updated a part of the tutorials to make use of py4vasp (https://vasp.at/tutorials/latest/) and will work on porting more and more of them to this new framework. At the beginning of these tutorials, you will find a brief introduction to the Jupyter environment and see some ways py4vasp can be used.

I checked the tutorial (https://vasp.at/tutorials/latest/), it is very complete, but it is not very user-friendly for people who don't do coding much. For normal academia or students, maybe there should be more examples and explanations of py4vasp's structure and usage. For example, not a lot of people are familiar with the concept of the "wrapper", although it is not complicated.

Thank you for the comments. We have already considered some options to improve the documentation of py4vasp. Adding more examples to the documentation the way that numpy does it, would be a great addition. We might also add a specific tutorial for py4vasp at some point.

Is it possible to read the data from the HDF5 file using py4vasp during the simulation? For example, during the structure relaxation, I'd like to check the energy convergence trend. Usually, I would check the data in OSZICAR or OUTCAR, would VASP update the data in the HDF5 file during each electronic or ionic step?

The data is written at the end of every step so in principle it should work to access the energy during the iteration. There may be a bit of a delay because potentially the data get buffered before it is written to file.
However, note that you need to be careful when you do that. HDF5 doesn't like when you open the file multiple times including write access. In particular, one way that fails is if you open the file in Python and then run VASP while the file is still open.
The top-level py4vasp wrapper routines will only read from the file and close it immediately afterward. This avoids this issue. But if you write more advanced scripts interacting with the lower-level routines that require manual handling of the HDF5 file it is something to be aware of.

Here is an example about installing HDF5:
./configure --enable-parallel --prefix=/home/shreeja/local/ --enable-fortran --disable-shared --enable-cxx --enable-fortran2003 --enable-unsupported --with-zlib=/home/shreeja/local
As you could see, there are a lot of options, is there a recommended setting when installing  HDF5 on the cluster？

If I'd like to get the electron occupation of atom-1's d orbital, which method in py4vasp should I use? I only found there are methods of born effective charge in the tutorial.

The charges are the 0th component of the magnetic moments
https://vasp.at/py4vasp/latest/data/magnetism/

Is it possible to get the detailed information in WAVECAR with py4vasp? for example, I would like to use py4vasp to replace [VaspBandUnfolding] and CA-NAC, which could read the WAVECAR file and generate the Nonadiabatic Coupling between different orbitals. I am not sure if all the information in WAVECAR is stored in HDF5 files.

At the current stage, reading the orbitals with py4vasp is not supported. The data can be written to hdf5, but we need to optimize this writing for performance first, before we can expose it to users. Which specific data would you like to access, the pseudo-orbitals on the FFT grid or something else?

I'd like to calculate the COHP, which requires getting the wavefunction data of each orbital.

Sorry, perhaps I should have elaborated a bit more: VASP uses the PAW methods, so we have two different orbitals:

The pseudo-orbitals Ψ_nk(r) on the FFT grid are optimized to find the groundstate of the system. Evaluating operators with the pseudo-orbitals is fast and simple because it typically just requires FFTs to the right basis (r or G). However, they are not normconserving, i.e., the density of the system is not n(r) = sum_nk Ψ*_nk(r) Ψ_nk(r), so they only approximate the true values of quantities.
The all-electron orbitals can be recovered from the pseudo-orbitals using a projection technique. With this method, you get accurate results comparable to all-electron techniques for almost all quantities.

Which of these two orbitals do you need?

I'll investigate how difficult it would be to write this data to HDF5 and make it available via py4vasp.


Condensing gasses into chemicals should be possible

Though probably not vice-versa without careful balance work.
This means Oxygen, Nitrogen, Plasma (this is somewhat important so maybe make it not condense by normal means), Water Vapor, Nitrous Oxide, Tritium, and CO2 should be convertible to chems via some machinery.

Could we standardize mols <-> u? Maybe including molar mass?

Could we standardize mols <-> u? Maybe involving molar mass?

pv=nrt. How much volume is a u? going roughly off the size and containers in game already, a shot glass is 10u, so 1u would be about 5ml

I tried actual math and it was pretty useless, so arbitrary contrived solution: 1mol = 1u.

it would depend on pv=nrt for real life. For instance, in 1atm, liquid oxygen 1mol = 28 ml, and boils at -183c.
though we really don't handle boiling/freezing of gasses right now, they just exist at those temps and pressures as a gas eternally, so you could just blame spess magic and pick some arbitrary values.
Requiring the gases to be at certain temps for the machine to convert them might be engaging gameplay however. especially since most of the gasses atmos deals with have boiling points in the -190c range. It could require atmos to get cans of gasses at specific temps. i.e. oxygen, nitrogen, co2 around -200c to get base oxygen, nitrogen and carbon chems. more exotic chemicals could use miasma or plasma cooled below -200c with the help of frezon to get radium, sulfur, uranium, or others.
my ultimate question would be, the condenser would be something that requires pipes and gas inputs then I assume? a single machine would then have a max of 4 pipe inputs/outputs ideally so fitting all 7-9 gasses in seems like an issue

One hackish way to do this would just be to introduce a machine that condenses some portion of gases that flow into it.
I think implementing condensation would be better. I'd do this by giving each pipenet node container a "condensate" solution container. Then, based on energy, gases, and pressures in the container, move gas from the air pipenet nodes to the solutions and vice versa. I'd probably opt not to implement fluid flow, i.e. condensate stays in the pipenet it formed in and doesn't flow through other devices. The only additional "machine" you'd need is a tap to extract the condensate from a pipenet.
Responding to suggestions in the comment above:

The ideal gas law is for ideal gases, not liquids. $PV = nRT$ doesn't apply. The physically accurate thing to do would be to work through molar mass of the liquid (which is different from molar mass of a gas), as someone pointed out above. This would be a constant for each liquid you either look up or make up.
My suggestion would give you a condensate mixture of all the gases condensed at whatever temperature you've managed to get the pipe to. It would be up to you to separate the liquid gases cough chem master cough. Real cryogenic plants use a molecular sieve followed by fractional distillation to separate liquid gases.
There's a complex system of equations for determining the equilibrium fraction of condensed vs. vapor phase gas. At high pressures enough pressures, even room (or higher-temperature) gas can be forced into liquid form. This is what keeps the pressure vessel of a boiling water reactor from exploding, for example. Fortunately, I already have a code version of the solved equations for water vapor for a nuclear-reactor AME replacement from an earlier project that could be extended to other gases.

Sure, a flag to disable condensation should be trivial to add, and also help with debugging if things go wrong.
That said, freezing out the external pipes could be an interesting mechanic. Have you wondered why real spacecraft are essentially dead if their internal heaters fail? (it actually has more to do with all the electronics freezing out, but we'd still end up in the same situation where the spacecraft/station is dead)

Yeah, I talked myself into the idea being potentially cool. Like I said it would be something worth playtesting to see if it's actually good or not!

I have 0.2u/mol on Citadel's implementation of chem gases, mostly because 120 moles is actually quite a lot (throw a full large beaker of hot water and you've more than doubled the pressure in that tile, at 1u/mol).

Here's a video of freezing a pipe such that the gas inside it condenses into liquid inside the pipe. Gas analyzer can't analyze liquid inside the pipe, so the gas "disappears". Machine to drain the liquid from the pipe coming soon:
https://user-images.githubusercontent.com/3229565/223955278-9c81b169-377b-4c77-a68f-e6ec1cca1f09.mp4


[release-1.15] update Kiali to 1.55 (for Istio 1.15)

This is an automated cherry-pick of #40588

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio_release-1.15
dd003bb3eacad7b33c5174154c6cafca2fced8b6
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests-arm64

/test release-test


Switching Cordova Version of an article redirects to the startpage

Bug Report
Problem
When i switch the cordova version for an article, the startpage of the docs are shown.
What is expected to happen?
I should stay in the article, when i switch the cordova version.
What does actually happen?
I'm redirected to the startpage of the docs.
Information
Example:
"Next Steps"-article for cordova version 9:
https://cordova.apache.org/docs/en/9.x/guide/next/
If you switch the cordova version, you always gets redirected to the startpage of the docs: https://cordova.apache.org/docs/en/latest/
no matter which version you are selecting.
The docs exists for the other versions, if manually edit the url:
Version 10: https://cordova.apache.org/docs/en/10.x/guide/next/
Version 11: https://cordova.apache.org/docs/en/11.x/guide/next/
dev:
https://cordova.apache.org/docs/en/dev/guide/next/
Environment, Platform, Device
Smartphone, Android 10, Google Chrome
I think it' s the same problem on a desktop pc.
Checklist

[ ] I searched for existing GitHub issues
[ ] I updated all Cordova tooling to most recent version
[ ] I included all the necessary information above

I think this is probably intentional. Switching versions via either the banner or the version selector always returns back to the "Home" page of the Documentation. I do understand the annoyance however. I think the primary reason for this behaviour is that it's not easy to know if a particular version of a page exists in another version of the documentation.

I saw, that it is not happening on every article. For example the article "Customize Icons". The switching between the versions works here:
Article in Version 9:
https://cordova.apache.org/docs/en/9.x/config_ref/images.html
If I use the switch or click on "Click here for the latest released version.", i stay in the article. But if I'm doing the same for "Next Steps" it's not working, though the other versions exists.

Interesting. I've done a bit further research and found several pages that did properly do a redirect, and some that didn't.
It seems to be powered by https://github.com/apache/cordova-docs/blob/806350c7c1ab0a230919c598558cb35263020eb0/www/_layouts/docs.html#L176-L187
It produces a link with the same URL but replacing the version with latest in the URL for the link. However, the build process actually builds a list of generated URLs called all-pages, which the above snippet seems to use to decide to fallback to the documentation root/index.
So this indicates that I was in fact wrong and redirecting to the same documentation page of of a different version is the intended behaviour.
It's been awhile since I built locally, but my last build does include some of the URLs that isn't working. Unfortunately I'm not in a position to attempt to build as jekyll seems to depend on Ruby2, which is basically EOL now and Ubuntu 22 doesn't have official support anymore. Trying to install Jekyll on Ruby3 has errors.
I'll be curious to see if the generated all-pages.yml file contains or is missing some of those URLs that isn't redirecting to the same version, such as /docs/en/latest/guide/platforms/android/index.html. If it's missing that line, then we have to look at why the generated all-pages.yml file is missing that page, otherwise we need to look at why the template seems to think it's missing.

Cool, thank you for your research. I was surprised, that you wrote, you cannot setup a local build environment, because the used technology is too old. So the cordova docs are still build with these old technologies? Is jekyll still under development, or is the last supported version only for Ruby2?


Looking forward to your free sharing

Looking forward to your free sharing, 100 stars have been completed

Thats not an issue and there are no reason to say this here , i will update whenever im free


[Question] Manage sessions opened

Is it possible to get the currently active sessions? My intention is to manage who is currently logged in and force a specific user, for example, to logoff whenever I want

Currently, no such way to do that. What you can do is use flask-sessions to manage user's session server side along with Flask-Discord by overriding methods like save authorization token and get authorization token of Flask-Discord.


Using a colon (":") in the commit message.

Hi!
When using a colon in a commit message twice, a part of the message is lost.
Apparently, the error is in this place:
https://github.com/hoopher/commit-linter/blob/a294798acc2247a09295cf35b7442aeb645b7f2e/commit_linter/hooks/commit-msg#L38
Example of a message:
fix: bla-bla

A very important commit

ref: https://task.domain.com

After executing the hook:
fix: bla-bla

A very important commit

ref

Suggestion: specify the number of splits in .split():
commitPostfix = ss.split(':', 1)[1]

Hi @loskost
Thank you for the suggestion, I have fixed the code in the last commit
I will push the changes ASAP to the pypi
Appreciate your contribution


Add new properties for job

Codecov Report

Merging #41 (07cfdc0) into master (d9bc338) will increase coverage by 0.82%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   66.48%   67.31%   +0.82%
==========================================
  Files          19       19
  Lines         925      930       +5
==========================================
+ Hits          615      626      +11
+ Misses        310      304       -6

Flag
Coverage Δ

integration
67.31% <88.88%> (+0.82%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

api4jenkins/__init__.py
77.61% <ø> (-0.17%)
:arrow_down:

api4jenkins/artifact.py
35.29% <ø> (ø)

api4jenkins/input.py
31.81% <ø> (ø)

api4jenkins/report.py
45.20% <ø> (-0.75%)
:arrow_down:

api4jenkins/utils.py
0.00% <ø> (ø)

api4jenkins/job.py
84.61% <87.50%> (+0.05%)
:arrow_up:

api4jenkins/__version__.py
100.00% <100.00%> (ø)

api4jenkins/node.py
57.35% <0.00%> (+5.88%)
:arrow_up:

api4jenkins/queue.py
72.91% <0.00%> (+6.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bc338...07cfdc0. Read the comment docs.


Gap handled between streams for continuous hover effect

Fixes #12508.

Fixes #12508
Gap no more changes hover effect of pointer cursor
Testing Plan:
Chrome dev tools
GIFs or Screenshots:

I'm a little skeptical that this is the right approach, with a 0.3px thing here.  @synicalsyntax @alexandraciobica this might be a good thing for you to look at a proper fix for.


Enable usage of escape char '' in string values

Allows the use of escape characters in kconfig and sdkconfig string values, allowing the use of unicode characters, etc.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.RandyW seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

https://patchwork.kernel.org/patch/6357771/

Hi @SonnyX ,
Thanks for sending the PR. Can you explain a bit about the use case for this?
Normally I would be all for merging a change like this. However we actually maintain 4 copies of the kconfig parser right now (this copy, a copy in kconfig-frontends which is for Windows users on the CMake branch, a copy of kconfiglib in the master branch and a different copy of kconfiglib in the CMake branch). This change would need to be applied in all four places to be consistent.
Once we merge the CMake preview branch, at least this will be back down to 2 places not 4.
I'm not saying we can't merge this, but I would like to understand the rationale for this and how important it is to your use case.
Angus

Oh, also - I only just noticed the target branch. We only accept PRs against master. For major bug fixes and the like we can also backport to the v3.0 release branch after merging to master.

@projectgus
The use case for this would be allowing the use of special characters in the sdkconfig file: the use case for most users would be the usage of newline and return characters (\n and \r).
However since a string is just a (unsigned) char array, we use this to initialize a array with device-specific data so that when we change hardware later-on we can just select the right sdkconfig file for the job. (dynamic pin configurations for example)
As an example, the equivelant of:
unsigned char modulePins[4] = { 17, 18, 21, 22 }; would be unsigned char modulePins[4] = "\x1a\x1b\x20\x21";
Then dropping in a variable defined through the kconfig we can turn this into  unsigned char modulePins[CONFIG_MODULE_AMOUNT] = CONFIG_MODULE_PINS;

Hi @SonnyX ,
Thanks for explaining. Normally we'd recommend one of the following:

Setting a single int config item for each pin. Better if you have a small number of pins.
Setting a  "choice" config item for device type and then having some device.h which can do #ifdef CONFIG_DEVICE_MODEL_A, etc, etc. Better if you have a large number of pins. This will give less obscure errors than having the preprocessor inject a hex string (ie you get the error at the place the array is mis-typed, rather than having to navigate from the macro usage back to the macro definition and then into the sdkconfig file).

Are either of these approaches suitable for your use case?

Hi @projectgus ,
I agree with you upon these approaches, don't know how I missed the idea of using preprocessor device models.
Regarding the use of special characters in preprocessor defined strings, the changes could ofcourse still be useful for some end-users.
With the above suggestion I am closing this pull request.


bevy_render: Only auto-disable mappable primary buffers for discrete GPUs

Objective

While it is not safe to enable mappable primary buffers for all GPUs, it should be preferred for integrated GPUs where an integrated GPU is one that is sharing system memory.

Solution

Auto-disable mappable primary buffers only for discrete GPUs. If the GPU is integrated and mappable primary buffers are supported, use them.

Seems reasonable to me!

bors r+


Remove New prefix from command function name

prefixing cobra command function names with New (IMO) reads awkwardly, for example reading NewPlatformCommand, to me reads like this function would be creating a command that makes a new platform, which it doesn't. on the flip side its "creating" something for the cli framework.
this is solely a naming suggestion given the above observation, nothing technically wrong here
while i do like the compacting into function, i think between a New prefix and the generated var style in for example https://github.com/cloudlift/lift/blob/b98dc2ce7e20890762db3016583d67c2a77409fc/cmd/list.go#L9 i think id likely go for the generated approach, possibly compacting that down into init

I see how it reads a bit funny.  Maybe CreatePlatformCommand is easier to parse?  As for the var approach, to me it seems like nothing else is going to be calling that var in the code base, so why have it hanging out in the package.  I find it easier to reason about the lifecycle of everything by making the function calls vs. having go call init...but that is just my early vibe on the matter.

the var is indeed referenced by other commands, i.e, in root.go say:
var rootCmd = &cobra.Command{
       Use:   "lift-go",
       Short: "Multi cloud deployment tool",
       Long:  `lift is a tool for enriching your application so it can be deployed to multiple cloud platforms with minimal effort.`,
}

then in say platform.go you reference that via rootCmd.AddCommand(..):
var platformCmd = &cobra.Command{
		Use:   "platform",
		Short: "Platform commands",
		Long:  `Commands related to platform operations`,
		Run: func(cmd *cobra.Command, args []string) {
			cmd.Help()
			os.Exit(1)
		}}

func init() {
	rootCmd.AddCommand(platformCmd)
}

platformCmd is defined as a var here as platform_list.go needs to reference it. though in cases where something may not need to attach to another command, for example platform_list.go, the var can be consolidated inline, ie:
func init() {
	platformCmd.AddCommand(&cobra.Command{
		Use:   "list",
		Short: "Platform list",
		Long:  `Lists platforms available to deploy to`,
		Run: func(cmd *cobra.Command, args []string) {
...
...
...

The New* style of function is usually reserved for creating an instance of a struct.  The pattern allows for members of the struct to easily be mocked using constructor injection. Here is a good write up https://appliedgo.net/di/

agreed on the using New* for structs

merged per discussion


Make SessionHolder a true weak-reference

Problem
SessionHolder behaves today as both a strong reference to a session (i.e an instance of a holder will prevent the de-allocation of a referenced session) as well as a weak reference to a session (i.e an instance of a holder will NOT prevent the de-allocation of a referenced session).
It switches between these two modalities depending on whether it is referencing an UnauthenticatedSession vs a SecureSession, as well between different states of a SecureSession even.
This is very confusing to intuit and understand.
It also causes oddities like:

When a CASEServer attempts to ensure a guaranteed session reserved for a subsequent hand-shake, having just a SessionHolder isn't sufficient. It has keep an extra Optional<SessionHandle> member to keep the session pinned. This clearly indicates the weak-ref aspect of SessionHolder.
When evicting a session, we're forced to detach all SessionHolders to reduce the reference counts till only real strong-refs remain (i.e SessionHandles). However, this means that if we did have any strong refs remaining, we have prematurely evicted a session we didn't need to and could have skipped it.

Proposed Solution
We already have a 'strong ref' construct in SessionHandle, and a shared-ptr like construct that can be modeled using Optional<SessionHandle. Consequently, make SessionHolder a pure weak-reference.

Likely too risky to tackle this for 1.0 given how close we are to SVE.


Fix rtt assignement for low values of infra-cache-max-rtt

When a server is deemed still usable keep the same logic (a useful value outside of the RTT_BAND) also for small configured values of infra-cache-max-rtt.

Thanks!


Accommodate HMACs stored as binary in DynamoDB

Hey there, thanks for providing node-credstash - it's been a super helpful utility!
I noticed that node-credstash was unable to read credentials stored by python credstash - it was throwing an error saying the HMACs didn't match. Turns out that python was just storing HMACs as binary in DynamoDB whereas node-credstash was using strings.
I've prepared a quick fix to accommodate both string and binary types. Let me know if you have any questions!

Hey @galenmaly, thanks for the PR! We're very excited to get our first one on node-credstash.
This change looks fine so I'll accepting it, cheers!


Add yamllint workflow, validates .yaml files

This has two effects:

It will validate .yaml files for general correctness everywhere except vendor and dev-tools/vendor
And as a side-effect, it might enable other workflows to happen. E.g. we will no longer need to consult with forks to see if  #5295 #5268 #5183 etc are working.

Thank you @sanmai.


404 Errors on Referral Links

Issue in ./help/v8/connect/ac-ajo.md
The following links at the bottom of the page result in 404 errors
Discover this integration in this end-to-end sample.
Learn more in Journey Optimizer documentation.

Thanks for your feedback @jtwood426
This is now fixed. Changes will be live later today
Internal reference > DOCAC-10335


Compliance with terraform 0.15.0 and new example added

Description
Fix:

Make sure s3 bucket is deleted by terraform even if not empty
Change the return value of the python workload so it matches what is expected by the client.py

Feature

Adding a config files example for data plane back by an S3 bucket
Compliance with terraform 0.15.0

Checklist

[x] Added tests that cover your change (if possible)
[ ] Added/modified documentation as required (such as the README.md, or the docs directory)
[x] Manually tested
[x] Made sure the title of the PR is a good description that can go into the release notes
[ ] (Core team) Added labels for change area (e.g. area/controlplane) and kind (e.g. kind/improvement)

BONUS POINTS checklist:

[x] Backfilled missing tests for code in same general area
[ ] Refactored something and made the world a better place

lgtm


Throw ResourceGroupLocation not available error

Bug 6101943: Custom Registration script defaults to unavailable TZL region (https://msazure.visualstudio.com/One/_workitems/edit/6101943)

Approved with suggestions


Support 7.20

Switch examples to latest Camunda Spring Boo, JDK 17..
Steps

[x] JDK 17
[x] Spring Boot 3.1.3
[x] Camunda 7.20
[x] Polyflow 4.0.0 (4.0.0-SNAPSHOT)
[x] Camunda BPM Data 1.4.0
[x] Camunda Platform 7 Mockito 7.20.0
[x] Axon Server Connector 4.8.2 // FIXME, do we need it?

My notes for process engine migration to Camunda 7.20 / Polyflow 4 etc. - some notes are specific to our setup (e.g. Azure SQL database), but maybe it helps:

Update versions in your POM according to the changes above
Do the javax -> jakarta migration
If you have a dependency on org.apache.httpcomponents:httpclient, use org.apache.httpcomponents.client5:httpclient5 instead
If you have a dependency on groovy, change the group id from org.codehaus.groovy to org.apache.groovy
If you are using the OpenAPI Generator, depending on which generator you use, you might have to set the config options useSpringBoot3 or useJakartaEe to true
Either migrate your database schema to use DATETIMEOFFSET instead of DATETIME2 for Instants or set spring.jpa.properties.hibernate.type.preferred_instant_jdbc_type to
TIMESTAMP in your application.yaml.
Either migrate your database schema to use UNIQUEIDENTIFIER instead of BINARY for UUIDs or set spring.jpa.properties.hibernate.type.preferred_uuid_jdbc_type to BINARY
in your application.yaml.
Due to a change in how Hibernate handles sequences, you will either need to replace the hibernate_sequence with per-table sequences (recommended) or set the JPA property
hibernate.id.db_structure_naming_strategy to legacy to restore the old behavior. An example database script for creating the sequences can be found is attached below

DECLARE @next_value BIGINT, @sql NVARCHAR(MAX);
SET @next_value = NEXT VALUE FOR hibernate_sequence;
SET @sql = 'CREATE SEQUENCE association_value_entry_seq START WITH ' + CAST(@next_value AS NVARCHAR) + ' INCREMENT BY 50'
EXEC (@sql)
SET @sql = 'CREATE SEQUENCE domain_event_entry_seq START WITH ' + CAST(@next_value AS NVARCHAR) + ' INCREMENT BY 50'
EXEC (@sql)
DROP SEQUENCE hibernate_sequence;

The database schema upgrade from 7.19 to 7.20 is not very spectacular, but you should apply it nonetheless. Add the scripts to your Flyway migrations directory or whatever you use.


Refactored Tests with Quick

Solves: https://github.com/zenangst/Tailor/issues/22

@heshamsalman


Document latest Metrics SDK

We need to update the standalone documents of Metrics SDK to help people understand the metrics spec changes and how JavaScript SDK implements them.

[ ] https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/processor-api.md needs to be replaced with Views API
[ ] https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/exporter-guide.md#metrics needs to be replaced with MetricReader and MetricExporter

[ ] Details about the difference between two AggregationTemporality.
[ ] Examples for both pull/push models of exporting.

[ ] Examples for all kinds of instruments and common practice.

[ ] Significant changes in histogram and boundaries.
[ ] Significant changes in async instruments https://github.com/open-telemetry/opentelemetry-js/issues/868.

I believe all docs should be moved to the website. We can iterate on them here and move them to the website when we're happy with them?

This was discussed a bit at the maintainer's meeting last week. On the docs side, we have outlines that can be followed now!
Getting started: https://github.com/open-telemetry/opentelemetry.io/issues/1746#issuecomment-1250157077
Manual instrumentation: https://github.com/open-telemetry/opentelemetry.io/issues/1746#issuecomment-1250157891
As mentioned in the call, if y'all can contribute a code sample that handles initialization of metrics in the most correct way, then we (docs SIG) can probably cover the rest iteratively.
I also think that JS getting started is unique, since there's really two major SDKs that people use, whereas other languages just have one way to get started. I'd recommend that for now, we focus on the Manual Instrumentation doc and then figure out the right way to structure the JS getting started docs orthogonally.

Sorry to leave you hanging for so long I promise I haven't forgotten this. I'll make sure to get something tomorrow even if it isn't completely polished so you have something to work with.

Sounds good!


Icon request: .nvmrc

.nvmrc should use the gear icon, or a node.js related icon

You got it! :grin:


Neofetch doesn't detect properly Radeon 5600XT GPU

Description
While glxinfo or other tools detect properly 5600XT, neofetch doesn't. See screenshot.
Neofetch version
7.1.0
Screenshot

Verbose log
https://pastebin.com/guYZfFUL

Also applies to the 6650XT, which shows as AMD ATI Radeon RX 6650 XT / 6700S / 6800S

Same goes for 7900 XTX, shows AMD ATI Radeon RX 7900 XT/7900 XTX

Same for my RX 580 AMD ATI Radeon RX 470/480/570/570X/580/580X/590


FastBoot 1.0 compatibility

This fixes FastBoot compatibility breaking changes.

@lucacorti Looks like the build is failing with Cannot find module 'broccoli-stew'. You should probably add it as dependency in package.json

The build works for me, but adding it anyway.

@lucacorti Thanks for the PR 👍

Sorry, couldn't figure out why the build was still failing.


Fast cluster HW barrier

Before we merge this we should merge https://github.com/pulp-platform/riscv-opcodes/pull/9 and update the submodule reference.

[x] Add support in Banshee
[x] Evaluate PPA impact

⚠ This is a forking point from Occamy on the software side. If we merge this to main, we should maintain a separate branch (could be the current occamy branch) to support software development on Occamy.

This has to happen eventually, research must move ahead. Let's point an occamy branch to current master and merge


fix: adds correct dependency to run cube tests

In OpenshiftIT we are using cube in standalone mode, not using container mode. Hence changing it to use correct dependency.

@Ladicek Can you trigger retesting of PR somehow?

Hmm it seems OpenShift had fun evicting pods again...
retest this please

Hmm, these timeouts happen far too often to my liking...

Aaaa, this fails because of https://github.com/snowdrop/spring-boot-http-booster/issues/60

@dipak-pawar Can you please rebase the PR on to the latest master so CI can execute the tests with the latest changes in master?
Thank you

retest this please

retest this please


chore: run go mod tidy for samples and benchmarks

@rahul2393 Thanks (but the changes turned out to be unnecessary, as it was already fixed by one of the dependabot PRs)


Empty tables

I have pinba server, and I'm trying to add pinboard to it.
After installing pinboard, I see emty page (e.g. sites list is empty)
Also most of ipm tables are empty
mysql> select * from ipm_report_by_server_name;
Empty set (0.00 sec)

while request table is not
select count(*) from request;
+----------+
| count(*) |
+----------+
|     2930 |
+----------+

Did you configure the cron task?

What do you mean by configure? I runned following command (tried it one more time)
sudo ./console register-crontab
Defining crontab task...
Please enter the frequency of data aggregating (frequency must be equal "pinba_stats_history" of the pinba engine config).
Frequency (in minutes, default "15"):
Crontab task are defined successfully
Please set parameter "aggregation_period" to value "PT15M" in config/parameters.yml

Why do you run this command under sudo? It is not require sudo. Run in the simple mode.

first I tried without sudo, nothing changed

Looks like problem is beacuse I don't have timestamp field in request table. What does this mean?

pinba plugin version is correct
mysql> SELECT * FROM information_schema.plugins where PLUGIN_NAME = 'PINBA';
+-------------+----------------+---------------+----------------+---------------------+--------------------+------------------------+---------------+--------------------+----------------+-------------+
| PLUGIN_NAME | PLUGIN_VERSION | PLUGIN_STATUS | PLUGIN_TYPE    | PLUGIN_TYPE_VERSION | PLUGIN_LIBRARY     | PLUGIN_LIBRARY_VERSION | PLUGIN_AUTHOR | PLUGIN_DESCRIPTION | PLUGIN_LICENSE | LOAD_OPTION |
+-------------+----------------+---------------+----------------+---------------------+--------------------+------------------------+---------------+--------------------+----------------+-------------+
| PINBA       | 1.1            | ACTIVE        | STORAGE ENGINE | 50621.0             | libpinba_engine.so | 1.4                    | Antony Dovgal | Pinba engine       | GPL            | ON          |
+-------------+----------------+---------------+----------------+---------------------+--------------------+------------------------+---------------+--------------------+----------------+-------------+

but I see, that aggregation task uses it
    $sql = '
        INSERT INTO
            ipm_status_details (server_name, hostname, script_name, status, tags, tags_cnt, created_at)
        SELECT
            server_name, hostname, script_name, status, tags, tags_cnt, FROM_UNIXTIME(max(timestamp))
        FROM
            request
        WHERE
            status >= 500
        GROUP BY
            server_name, hostname, script_name
        LIMIT
            25
    ';

but structure of my request table is
mysql> describe request;
+------------------+---------------+------+-----+---------+-------+
| Field            | Type          | Null | Key | Default | Extra |
+------------------+---------------+------+-----+---------+-------+
| id               | int(11)       | NO   | PRI | 0       |       |
| hostname         | varchar(32)   | YES  |     | NULL    |       |
| req_count        | int(11)       | YES  |     | NULL    |       |
| server_name      | varchar(64)   | YES  |     | NULL    |       |
| script_name      | varchar(128)  | YES  |     | NULL    |       |
| doc_size         | float         | YES  |     | NULL    |       |
| mem_peak_usage   | float         | YES  |     | NULL    |       |
| req_time         | float         | YES  |     | NULL    |       |
| ru_utime         | float         | YES  |     | NULL    |       |
| ru_stime         | float         | YES  |     | NULL    |       |
| timers_cnt       | int(11)       | YES  |     | NULL    |       |
| status           | int(11)       | YES  |     | NULL    |       |
| memory_footprint | float         | YES  |     | NULL    |       |
| schema           | varchar(16)   | YES  |     | NULL    |       |
| tags_cnt         | int(11)       | YES  |     | NULL    |       |
| tags             | varchar(1024) | YES  |     | NULL    |       |
+------------------+---------------+------+-----+---------+-------+
16 rows in set (0.00 sec)

Field timestamp added in pinba 1.1. In the install documentation there is the remark:

Since the version 1.5 Intaro Pinboard requires Pinba 1.1 or higher.

according
mysql> SELECT * FROM information_schema.plugins where PLUGIN_NAME = 'PINBA';
+-------------+----------------+---------------+----------------+---------------------+--------------------+------------------------+---------------+--------------------+----------------+-------------+
| PLUGIN_NAME | PLUGIN_VERSION | PLUGIN_STATUS | PLUGIN_TYPE    | PLUGIN_TYPE_VERSION | PLUGIN_LIBRARY     | PLUGIN_LIBRARY_VERSION | PLUGIN_AUTHOR | PLUGIN_DESCRIPTION | PLUGIN_LICENSE | LOAD_OPTION |
+-------------+----------------+---------------+----------------+---------------------+--------------------+------------------------+---------------+--------------------+----------------+-------------+
| PINBA       | 1.1            | ACTIVE        | STORAGE ENGINE | 50621.0             | libpinba_engine.so | 1.4                    | Antony Dovgal | Pinba engine       | GPL            | ON          |
+-------------+----------------+---------------+----------------+---------------------+--------------------+------------------------+---------------+--------------------+----------------+-------------+

I have 1.1 version. If I'll downgrade to 1.4 this will fix the problem?

Yes.

Thanks!


Replace colors by ansis

You are using the colors package that is installed by the MagicMirror² core. We are about to remove it from the core, then your module would have a problem with this dependency starting with the next MagicMirror² release.
Instead of including colors into your dependencies, I think it would be a better approach to replace it with the drop-in replacement ansis (as we about to do in core).
I had problems getting your build process to run, so I haven't tested my changes. But I am positive that it will work :slightly_smiling_face:
In the second commit I also made a few cosmetic improvements.

Hello, colors is only used within a 'mock' server faking some APIs for development purposes.
I guess I should have added colors to my own package.json at the first place. It just worked as MM2 is providing it, I wasn't aware of it.
Okay to use ansis as alternative.

I guess I should have added colors to my own package.json at the first place.

Exactly :slightly_smiling_face:
I've searched through all the modules on the official list so that we don't break any modules with this change for the next release.

Thanks. But are you doing this for each one of the MM2 modules? That's quite heavy work !

I'm not that familiar with your build process, so I don't know why your tests are failing. Can you handle it? Otherwise we can just add colors to your package.json.

The issue might be related to old libraries I've removed by changing the APIs I'm using. It is absolutely not related to the removal of colors as it already failed before.
I'm positive that merging my dev branch will eventually get everything running great with the latest changes. Btw, I will merge upcoming master into it to check.

Created a new PR with the same changes after latest master update: https://github.com/djey47/MMM-IDF-LOCALTRANSPORT/pull/18


Feature Request: search box or Filter

An option to type multiple resources in a search box of select multiple resources and it show you which planets have all the selected resources then hover on the planet listed to show number of veins of the searched for resources.

Multiple resources selection is already built-in by shift-clicking resource icon.
And press tab key to toggle the display among selected resources.
The viewability is not high enough as it is. I'd like to do something about this, but have no plans yet.

i would also like to just search by name as well that way you can tag your factory worlds and pull it up by entering a short partial search string

Yes, that would be the next milestone.

Name search has been added in v1.0.0


Post-review changes preview DO NOT MERGE

DO NOT MERGE
Just created for viewing a diff
This is a nice view of the diff of:
https://github.com/ClusterHQ/flocker/pull/2682
Pre and post review.

I'm going to close this and delete the branches.


chore: update archivst -> archivista

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 4 (50.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 27.407%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/run.go
1
2
50.0%

cmd/verify.go
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

cmd/verify.go
1
58.23%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
111

Relevant Lines:
405

💛  - Coveralls

we may want to get https://github.com/testifysec/go-witness/pull/34 in first

This is going to be a breaking change unless we depricate

requires https://gitlab.com/testifysec/internal-infra/deployments/-/merge_requests/7

This is going to break everything in our infra due to the new flag name.  Can we add an alias deprecate the old one please

@colek42 this is ready now.


Fix email validation within candidate_interface/sign_up_form

Context
We introduced case-insensitive email_address validation in the model but the SignUpForm was doing its own email_address validation and the logic wasn't in sync.
Changes proposed in this pull request
Refactor SignUpForm so that all email_address validation happens within the model.
Guidance to review
Run the tests! Read the code. Try to reproduce the bug.
Link to Trello card
595 - Can't sign up/in with uppercase version of existing email
Env vars
No new env vars.

Tested this locally and it seems to work really well 👍

Adding this temporary red review as I want to deploy the current master to prod and then merge this in + do another deploy

Yep that's cool, just make sure you revert this before merging: https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/pull/774/files

Adding this temporary red review as I want to deploy the current master to prod and then merge this in + do another deploy

Cool, I've rebased this against latest master, so it's ready to be merged when you are ready to deploy.


Theater

For use with the "Cinema" Places preset

HFC Symbol

This one will need a bit of tweaking to retain the detail of seats vs. people. In smaller version, I'll probably have to abandon the seats altogether.

Standalone symbol designs:

32
24
16

This one was tough. cc: @jakecoolidge


update keywords

Description

Related Issue(s)

Checklist

[ ] I have read the contribution guidelines
[ ] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

Hi Sumit,
I've reviewed your PR and I have a suggestion.
Tokenising splits Node-RED to node red. Which is why I suggest we use both
versions.
Let me know what you think.
Thanks,
Zeger-Jan van de Weg
ZJ van de Weg
CEO, FlowFuse
https://flowfuse.com/
On Sat, 20 Jul 2024 at 14:50, sumit shinde ( Roni ) <
@.***> wrote:

@.**** commented on this pull request.
In src/blog/2023/01/getting-started-with-node-red.md
https://github.com/FlowFuse/website/pull/2367#discussion_r1685425388:

@@ -9,9 +9,9 @@ tags:
- posts
- node-red
- how-to

Node-RED getting started

Node-RED Tutorial

Install Node-RED

nodered getting started

Because nobody searches 'Node-RED' exactly as written, we, as a company,
ensure to write it this way for branding. However, when people search on
Google, they often use variations like 'nodered' or 'node red' all time.
Below is the google keyword planner result
Screenshot.2024-07-20.181057.png (view on web)
https://github.com/user-attachments/assets/9fc4a22f-f167-4f43-a377-395c8e6ff4ab
—
Reply to this email directly, view it on GitHub
https://github.com/FlowFuse/website/pull/2367#discussion_r1685425388,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATJSO3C5HK7JIVBRRUOOKDZNJMKZAVCNFSM6AAAAABLD6CWRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBZHE3TMOBXHA
.
You are receiving this because your review was requested.Message ID:
@.***>


Follow symlinks when fixing permissions.

Fixes # .
Changes proposed in this pull request:

Follow symlinks when running chown. This fixes a change in 7.2.92 where 'data', 'logs', and 'run' under /usr/lib/unifi/ were symlinked out of the directory. The broken permissions led to a startup failure (see #103),

@goofball222

Unfortunately the -H flag for chmod isn't platform agnostic, and in this case following symlinks and changing those permissions isn't the correct behavior anyway.
The correct fix in my opinion, & based on what the rest of the community is doing is to remove the unwanted symlinks post .deb install, which I've modified the Debian and Ubuntu Dockerfiles to do in 6509f02. That way the data, log, and run files all stay in the expected location / volumes with the application.
Appreciate your contribution!

Removing the symlinks makes a lot more sense. Thank you for the explanation!