Wrong sort order for Go to File

Issue Type: Bug

Create files as follow tree:

├── pp
│   └── src
│       └── app.h
├── ps
│   └── src
│       └── app.h

Ctrl + P and type ps/app.h
Expected ps/src/app.h sort at first but not actually

VS Code version: Code 1.67.2 (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5, 2022-05-17T18:15:52.058Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 7 5800H with Radeon Graphics          (16 x 3194)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
27.87GB (15.45GB free)

Process Argv
--crash-reporter-id b9977eb4-e704-4623-b964-f4ec24c2d8e9

Screen Reader
no

VM
0%

Extensions (29)

Extension
Author (truncated)
Version

typesharp
bon
0.6.0

doxdocgen
csc
1.4.0

gitlens
eam
12.0.7

better-cpp-syntax
jef
1.15.14

vscode-clangd
llv
0.1.17

python
ms-
2022.6.3

vscode-pylance
ms-
2022.6.0

jupyter
ms-
2022.4.1021342353

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.8

remote-containers
ms-
0.234.0

remote-ssh
ms-
0.80.0

remote-ssh-edit
ms-
0.80.0

remote-wsl
ms-
0.66.3

cmake-tools
ms-
1.10.5

cpptools
ms-
1.9.8

cpptools-extension-pack
ms-
1.2.0

powershell
ms-
2022.5.1

java
red
1.7.0

vscode-xml
red
0.20.0

vscode-yaml
red
1.7.0

omg-idl
RTI
1.0.1

cmake
twx
0.0.17

vscodeintellicode
Vis
1.2.21

vscode-java-debug
vsc
0.41.0

vscode-java-dependency
vsc
0.19.1

vscode-java-pack
vsc
0.23.0

vscode-java-test
vsc
0.35.0

vscode-maven
vsc
0.35.2

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vsclangdf:30486550

What do you see instead?

What do you see instead?

I'd prefer ps/src/app.h be the first one.

Yeah there's room for improvement here. I'm curious what:

ps app.h
app.h ps

gets... I would expect the same but just curious.
The problem here is that our fuzzy logic is a little strange when you're dealing with only two characters in a folder name. If the ps folder was really pas and you typed pas/app.h I think you'll get what you expect because of our fuzzy algorithm.
A workaround would be to do: "ps" app.h or app.h "ps" which should filter out the pp item... but it would be ideal if this "just worked".

The sort order is the same but with a little different .

It's nice to have an option to make continuous match part a high score.


Build Instructions Not Working

I'm trying to follow the instructions in the continued_stabilization branch to get my own build of the latest code.
mock@MockAir12 ~/C/G/c/c/alb-ingress-controller> git branch
* continued_stabilization
...

mock@MockAir12 ~/C/G/c/c/alb-ingress-controller> glide install -v
...does stuff

mock@MockAir12 ~/C/G/c/c/alb-ingress-controller> go build
can't load package: package .: no Go files in [path removed]/code/contrib/alb-ingress-controller

Attempts to build from the Dockerfile fail in a different way:
mock@MockAir12 ~/C/G/c/c/alb-ingress-controller> docker build -t alb-ingress-controller .
Sending build context to Docker daemon  395.5MB
Step 1/4 : FROM alpine:3.5
 ---> 37c7be7a096b
Step 2/4 : RUN apk add --no-cache ca-certificates
 ---> Using cache
 ---> d59f1a77d826
Step 3/4 : COPY server server
COPY failed: stat /var/lib/docker/tmp/docker-builder961811684/server: no such file or directory

Am I doing something dumb here?  Given the project is evolving fast I'd like a surefire way to run the latest version.

Hi @alexmbird
PTAL at https://github.com/coreos/alb-ingress-controller/pull/235
Specifically https://github.com/coreos/alb-ingress-controller/blob/update_build_instructions/BUILDING.md and let me know if that's more clear.

Perfect, just what I needed.  Thanks!


Migrate this repository to the maplibre flutter repo

We are currently implementing a new feature for the maplibre flutter library (https://github.com/maplibre/flutter-maplibre-gl/issues/258) and it would be easier for us to have this code in the same repository.
I understand if you want to keep things seperated and have this as a standalone package, but moving the code over would help us contribute features faster. Right now we have to fork this package, wait for the PR to be merged and then create the adjustments in the plugin.
For android and iOS the workflow would be the same, but the native android and iOS packages as more mature and most functionallity is already presetn which is not the case with this package.

Lesson learned. Never write issues while having a bad internet connection on the train 😆
Closing as its a duplicate of #2

Lesson learned. Never write issues while having a bad internet connection on the train 😆
Closing as its a duplicate of #2


golang 1.10

golang 1.9 -> 1.10
added golang cache to volumes and travis caching

maybe it'll be faster too?

That's where go's cache is located in the image
$ docker run --rm golang:1.10 go env GOCACHE
/root/.cache/go-build

/test pull-service-catalog-unit

[sorry for the noise, getting the first prowjob presubmit for this repo to run]
/test pull-service-catalog-unit

I'll take the -i out and see what happens.

As a baseline, here is the results of building the commit prior:
https://travis-ci.org/kubernetes-incubator/service-catalog/builds/399448590

/lgtm

/approve


enable plugins via command line option, megaparsec

now all of those behave:
tailwind-run ./. -o styles.css -p "forms, typography"
tailwind-run ./. -o styles.css -p ""
tailwind-run ./. -o styles.css -p Aspect-Ratio,forms,typography
case-insensitive, white space before and after ',' is allowed, "" is documented to indicate no plugin


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3291

Questions ?
Please refer to the Backport tool documentation


Update deps

copilot:all

🤖 Generated by lychee action
Summary

Status
Count

🔍 Total
973

✅ Successful
400

⏳ Timeouts
0

🔀 Redirected
0

👻 Excluded
572

❓ Unknown
0

🚫 Errors
0

Full action output
Full Github Actions output


Kubernetes Instructions

I added instructions in README.md to quickly target the Kubernetes environment on Bluemix using the IBM Cloud Developer Tools CLI, and one minor modification to package.json so that it is compatible with bx dev debug commands from the CLI.
This uses the same steps as running locally, and uses bx dev enable to generate Kubernetes assets, with bx dev deploy to handle compilation of the Docker image, push to IBM Container Registry, and the subsequent push to Kubernetes using the generated helm chart.
This does not cover Watson service bindings to Kubernetes clusters, as that requires more changes to the application code, and is not fully supported by the Cloud Developer Tools CLI yet.

This looks good. We're working through the details of adding Bluemix Container (K8s) instructions for another journey (watson-convesation-slots-intro) and we'll be adding BX dev tools CLI instructions there as well. After we've worked out the details of where the instructions will live in the repo, and how they will be linked in the top-level README, we'll revisit this PR and make them consistent.
Thanks.

Just curious, what's the status here?  Language and marketing teams are pushing the video that goes along with this, but the instructions aren't part of the repo yet b/c this pr isn't merged.

We've put k8s instructions for conversation-slots into a separate doc:
https://github.com/IBM/watson-conversation-slots-intro/blob/master/doc/source/Container.md
and linked to it from the README.
So, whatever revisions are required for these instructions, they'd need to be put into a doc/sources/*.md and linked to from the README>

Closing. This is out-of-date now. Sorry it got held up in review. We're doing OpenShift instructions now so I'm not sure we'll need to add k8s instructions too.


Enhancements on "Software Switch", "Library" and "Books"

Enhancements:
1.Add software switch "PISCES" to "Software Switch";
2.Add library "Scapy" to "Library";
3.Add some Chinese books to "Books".

Thank you for you PR. merge it.


Fixes problems with growlnotify for windows.

If running on windows, you end up with an empty argument which ends up being a set of double quotes and that doesn't compute for growlnotify.

Thanks @rquadling, sorry this has taken so long!

Thank you.


@inject and @customElement

with following i get the DI unknown key error
@customElement('association-select')
@inject(BindingEngine, EntityManager)
export class AssociationSelect {
  constructor(bindingEngine, entityManager) {
    this.bindingEngine  = bindingEngine;
    this.entityManager  = entityManager;
  }

however, following works just fine
@customElement('association-select')
@inject(Container)
export class AssociationSelect {
  constructor(container) {
    this.bindingEngine  = container.get(BindingEngine);
    this.entityManager  = container.get(EntityManager);
  }

that's with aurelia-cli 0.18.
i tried to debug it further, but to no avail. any idea's what's happening there? why is that internally not just the same?

it's separate files, but well it's requirejs/aurelia-cli. so, all get's bundled and then yes, then it could be bellow.
that would would make it somewhat an aurelia-cli issue as well. at least, i've no idea howto enforce some bundling order using aurelia-cli

with your hint i made more tests, and it's confirmed i guess
mini more background:

association-select is a custom element. so it's kept in a seperate file while the other plugin files are bundled.
in order to have it traced and bundled by aurelia-cli and jspm i've added a
import {AssociationSelect} from './association-select'; to the 'index.js'
however, imports with ./get removed in the build task i've copied from you.
so i've added that import {AssociationSelect} from './association-select'; to the paths.importsToAdd(in front) in your build tasks
they get now re-added in front of all and thus was before the EntityManager
when i changed the importsToAdd(in front)  to an importsToAppend it worked again

so, was easy enough fixable for me finally, but i'm unhappy that it's not a solid fix and probably quite a few others will run into this issue


Use same style to document code

Version A (primarily used by compute):

Version B (primarily used by UX):

Which one is better? Then in the future only one style should be used.

Kai sagt: version A = numpy, version B = vielleicht PEP8, checken!

The whole project uses the PEP8 styleguide. PEP8 references PEP257 for docstring conventions: https://www.python.org/dev/peps/pep-0257/
Numpy specifies even more and seems to be compatible with PEP8/PEP257. See

https://github.com/numpy/numpy/blob/master/doc/example.py and
http://www.sphinx-doc.org/en/stable/ext/example_numpy.html

In the future code should be documented with NumPy docstrings.

Result of team discussion: When the other issues are fixed, we will adapt the documentation according to Numpy's style for everything. Sphinx is currently used for the viroconcom package. We will use it only for viroconcom and not the whole virocon project.

I thought about this again. First, we thought that not as many developers will work with the django app compared with viroconcom. I am not so sure anymore. I think if it is not much effort to use sphinx, we should use it for the django app too.

Done and merged.


GW security group not deleted after running 'subctl cloud cleanup aws'

After running the following commands on OCP 4.11 cluster on AWS:

subctl cloud prepare aws  --ocp-metadata < metadatafile >
subctl cloud cleanup aws  --ocp-metadata < metadatafile >
check [1] for more details.

subctl version : subctl version: v0.14.0-rc4
I can still see the submariner GW security group on AWS UI.
[1]
$ subctl cloud prepare aws  --ocp-metadata aws-cluster-a/metadata.json
✓ Preparing AWS cloud for Submariner deployment
✓ Obtained infra ID "yb-awsa-9b2kp" and region "us-east-2" from OCP metadata file "aws-cluster-a/metadata.json"
✓ Initializing AWS connectivity
✓ Retrieving VPC ID
✓ Retrieved VPC ID vpc-0f50548218add38be
✓ Validating pre-requisites
✓ Validated pre-requisites
✓ Creating Submariner gateway security group
✓ Created Submariner gateway security group yb-awsa-9b2kp-submariner-gw-sg
✓ Adjusting public subnet yb-awsa-9b2kp-public-us-east-2a to support Submariner
✓ Adjusted public subnet yb-awsa-9b2kp-public-us-east-2a to support Submariner
✓ Deploying gateway node for public subnet yb-awsa-9b2kp-public-us-east-2a
✓ Deployed gateway node for public subnet yb-awsa-9b2kp-public-us-east-2a
✓ Retrieving VPC ID
✓ Retrieved VPC ID vpc-0f50548218add38be
✓ Validating pre-requisites
✓ Validated pre-requisites
✓ Opening port 4800 protocol udp for intra-cluster communications
✓ Opened port 4800 protocol udp for intra-cluster communications
$
$ subctl cloud cleanup aws  --ocp-metadata aws-cluster-a/metadata.json
✓ Obtained infra ID "yb-awsa-9b2kp" and region "us-east-2" from OCP metadata file "aws-cluster-a/metadata.json"
✓ Initializing AWS connectivity
✓ Retrieving VPC ID
✓ Retrieved VPC ID vpc-0f50548218add38be
✓ Validating pre-requisites
✓ Validated pre-requisites
✓ Removing gateway node for public subnet yb-awsa-9b2kp-public-us-east-2a
✓ Removed gateway node for public subnet yb-awsa-9b2kp-public-us-east-2a
✓ Untagging public subnet yb-awsa-9b2kp-public-us-east-2a from supporting Submariner
✓ Untagged public subnet yb-awsa-9b2kp-public-us-east-2a from supporting Submariner
✓ Deleting Submariner gateway security group
✓ Deleted Submariner gateway security group
✓ Retrieving VPC ID
✓ Retrieved VPC ID vpc-0f50548218add38be
✓ Validating pre-requisites
✓ Validated pre-requisites
✓ Revoking intra-cluster communication permissions
✓ Revoked intra-cluster communication permissions

Seems to be related to this PR


[WIP] Improved Libfirm API

This PR implements an improved libfirm api. Work in progress.
The rust code is generated from a json file which is extracted from libfirms' python script.
Todo:

~Generate types for all nodes~
Generate typed Project Pins from data.json that allow to match on their parent.
Generate Construction class from Java api.
Integrate with lib.rs datastructures (Graph, Entity, Types, ...).
Update existing code to use new types

@joshuabach In the next hour or so I will push construction methods. They were a little bit more work because they involved more data types than just nodes.

The generator should surpress some warnings by adding the prefix:
#![allow(dead_code)]
#![allow(clippy::all)]

And run rustfmt after generation.

The generator should surpress some warnings by adding the prefix:
#![allow(dead_code)]
#![allow(clippy::all)]

And run rustfmt after generation.

The generator should surpress some warnings by adding the prefix:
#![allow(dead_code)]
#![allow(clippy::all)]

And run rustfmt after generation.

Instructions for other people on running the generator:
# get deps (do this once)
yarn global add ts-node
cd libfirm-rs/generator
yarn
# do this each time the generator script is changed
ts-node ./gen.ts
cargo fmt --all

Preserving @hediet old PR description:

This PR implements an improved libfirm api. Work in progress.
The rust code is generated from a json file which is extracted from libfirms' python script.
Todo:

~Generate types for all nodes~
Generate typed Project Pins from data.json that allow to match on their parent.
Generate Construction class from Java api.
Integrate with lib.rs datastructures (Graph, Entity, Types, ...).
Update existing code to use new types

bors r+
There is general consent to merge this, even though there is additional work to be done:

nicer cli interface
no fixpoint iteration +  abstraction for optimizations

Also see tracking issue #171.


Is this project still active?

 I'm intending to do some work on Rangy but it hasn't been my priority for a good few months.

Ping @timdown, looking for maintainers (see #418)?

Jul 21, 2016

It's not dead... I should have some free time next week

lol, but it so is

Anyone know of anything comparable to rangy?

I created a clone of this project called rangy-updated here.  (see #458 ) that accepts PRs and collaborators.


Added ASGI application

This PR introduces an ASGI counterpart to the current WSGI app.
The ASGI code itself is moved into a seperate module asgi.py, which is conditionally included as it is only valid in Python 3 (due to async/await calls).

I'd prefer not to have to maintain yet another copy of the exposition http handling for a subtly difference interface. Is there not some interface all of these can share?

I understand your hesitance to adapt yet another interface. The README file is already quite crowded.
As for whether there is a common interface all of these can share, I wanna say yes, there is the PEP-3333 standard WSGI and it's spiritual successor ASGI.

Supporting just these two should be enough, as any web-framework should be able to integrate with one or the other, depending on whether it's a synchronous or asynchronous framework.

My last though is that WSGI and ASGI should not be considered equal to the frameworks. As they are gateway interfaces and thus more general than specific frameworks.

Note: I have closed the PR for the Quart extension of the README file, I included it solely for completeness to have a flask-equivalent ASGI framework example.

It doesn't matter to me why this exists, it matters that we're already duplicating this code 3 times for various things that were popular at various times.

How would you feel about cleaning up, by deprecating the twisted code, removed flask and python http documentation and going solely with the code+examples for the gateway interfaces?
The gateway interfaces produces production quality endpoints in standard defined ways, and the integrations are simple in most languages, either via routers, middleware or adapters.
For Flask/Django it's common practice to utilize WSGI middlewares, for Quart/Django it's common practice to utliize ASGI middleware. Twisted has a WSGIResource which can call any WSGI app, thus I don't see the need for the MetricsResource for twisted.

Is it possible to get twisted to use one of the *sgi apis? That way it could be replaced by docs.

Yea, that is very much possible.
To use the make_wsgi_app as a twisted resource, simply replace MetricsResource(), with: WSGIResource(reactor, reactor.getThreadPool(), make_wsgi_app()).
Or use txasgiresource to do the same thing with the make_asgi_app, by replacing MetricsResource() with ASGIResource(make_asgi_app()).
The example in the README example becomes:
from prometheus_client import make_asgi_app
from txasgiresource import ASGIResource
from twisted.web.server import Site
from twisted.web.resource import Resource
from twisted.internet import reactor

root = Resource()
root.putChild(b'metrics', ASGIResource(make_asgi_app())

factory = Site(root)
reactor.listenTCP(8000, factory)
reactor.run()

And all the framework specific code for twisted can be deprecated/removed.

If we can do that then and avoid duplicating the parameter handing code, that sounds good.

I will do it when I can get around to it.
How do you feel about the MetricsHandler, and the start_http_server + _ThreadingSimpleServer?
We could eliminate _ThreadingSimpleServer by making start_http_server an alias of start_wsgi_server. If we did that we could additionally deprecate MetricsHandler, and potentially rewrite it to wrap and call the WSGI app from make_wsgi_app? - How do you feel about it this?

MetricsHandler is used by users, so it should continue to work. I'm okay with switching around how start_http_server works as long as it can still handle concurrent scrapes.

What do you think about this?

Thanks!

@Skeen Thanks for this! It works really well, and I was apple to add it to a FastAPI app like this:
from fastapi import FastAPI
import prometheus_client

app = FastAPI()
metrics_app = prometheus_client.make_asgi_app()
app.mount("/metrics", metrics_app)

@brian-brazil Can you please consider releasing a new version to PyPI? Thanks!

Hi!
ASGI is really cool feature. Especially for fastapi app (see comment above). When are you going to release asgi version to PyPI?

I can't wait to use Prometheus in fastapi. But I noticed that prometheus_client has not released a new version. So I chose to starlette_exporter. At least for now, there are no functional issues. You can try it, too.
@denisSurkov @pquentin

@brian-brazil Thank you for the release! 🎉

@Skeen Thanks for this! It works really well, and I was able to add it to a FastAPI app like this:
from fastapi import FastAPI
import prometheus_client

app = FastAPI()
metrics_app = prometheus_client.make_asgi_app()
app.mount("/metrics", metrics_app)

@brian-brazil Can you please consider releasing a new version to PyPI? Thanks!

could you please remain me that, how can i add a count metrics in the asgi mode? Thanks alot

could you please remain me that, how can i add a count metrics in the asgi mode? Thanks alot

The same way you'd do it for non-asgi:
from prometheus_client import Counter
c = Counter('my_failures', 'Description of counter')
c.inc()     # Increment by 1
c.inc(1.6)  # Increment by given value

could you please remain me that, how can i add a count metrics in the asgi mode? Thanks alot

The same way you'd do it for non-asgi:
from prometheus_client import Counter
c = Counter('my_failures', 'Description of counter')
c.inc()     # Increment by 1
c.inc(1.6)  # Increment by given value

Thanks a lot!

could you please remain me that, how can i add a count metrics in the asgi mode? Thanks alot

The same way you'd do it for non-asgi:
from prometheus_client import Counter
c = Counter('my_failures', 'Description of counter')
c.inc()     # Increment by 1
c.inc(1.6)  # Increment by given value

Hello mogul, it's me again~
I found that, in the multiprocess mode, if two fastapi(asgi) workers exists, their are two counter exists, and the data will like:

and then i need calculate the qps like:
sum(increase(context_app_calls_total{app_name=~".*", endpoint="/test", instance="<IP_ADDRESS>:8000", job="8000_metrics", method="get", status_code="200"}[1m])/60)

will i get correct result like this way? Thanks a lot

Hi @aLowMagic
I don't think this PR is the right place to ask for help like this, or to have these discussions, as it's unrelated to ASGI itself.
The challenge your facing is a more generic one of combining multiple parallel data-series, irrelevant to how the data series are collected, or which programming language is used to do that collection.
I would suggest you have a look at: https://prometheus.io/community/ - And seek help there :)

Hi @aLowMagic
I don't think this PR is the right place to ask for help like this, or to have these discussions, as it's unrelated to ASGI itself.
The challenge your facing is a more generic one of combining multiple parallel data-series, irrelevant to how the data series are collected, or which programming language is used to do that collection.
I would suggest you have a look at: https://prometheus.io/community/ - And seek help there :)

Thanks a lot~


Option to disable /lukkit run.

I think it would be a good idea to add a configuration option to disable/enable the /lukkit run command, and preferably, have it disabled on default.
I find it really insecure to allow any server operator to execute any Lua code, especially when a server instance runs with elevated privileges. Usually, server operators are trusted people, but what if an attacker somehow gets server operator access? The damage would be way worse than usual, as it would not be limited to the Minecraft server, but to the whole machine, or even network. An attacker with server operator access could, for instance, install a virus on the machine with some simple Java Standard Library calls.

By the way, awesome that you picked up development again :smiley:

Thanks mate, I enjoy this stuff. Apologies for not reading this sooner, for some reason it didn't notify me.
There's two ways we can go about this (technically three when combined):

Implement a config options like you discussed
Implement a permission node for permission based usage
Implement both

I'm happy to leave that choice up to you.
Thanks for the request.

The configuration option for sure, ensuring the security part. All Lukkit commands are administrative commands anyway, so the single permission lukkit.command is quite good in my opinion, for simplicity.

Will be released in 1.1.2 tomorrow - implementing config option and permission node.
Cheers for the feedback!


How can I create a tag!-like parser to check all (MANY) items in a list?

What I mean is let's say we have:
const URI_SCHEMES: [&'static str; 164] = ["aaa", "aaas", "about",
    "acap", "adiumxtra", "afp", "afs", "aim", "apt", "attachment", "aw",
...

What macros should I use to check every string in array like:
named!(pub url_proto,
       alt_complete!(
           tag!("https") |
           tag!("http")  |
           tag!("ftp") |
           ...
       )
);

Can I create a parser that checks everything in URI_SCHEMES?
Or the only way is to rewrite all of them?
Trying to write it ALL in alt_complete gives:
error: recursion limit reached while expanding the macro `error_position`

that would be useful! You're right, using alt! or alt_complete! for this will not work, so a custom combinator should be written for this.
In the meantime, you have a few options:

separating the parser on subsets of the list, because:

named!(pub url_proto,
  alt_complete!(tag!("https") | tag!("http") | tag!("ftp") | tag!("rtp"))
);

will do the same as:
named!(pub http_proto,
  alt_complete!(tag!("https") | tag!("http"))
);
named!(pub other_proto,
  alt_complete!(tag!("ftp") | tag!("rtp"))
);
named!(pub url_proto,
  alt_complete!(http_proto| other_proto)
);

You could also write a custom function instead of using the combinators to write it.
In the meantime, I'll get to work on a combinator for this.

closing this for now, there's still no combinator for thid, but not much demand. Feel free to reopen if it should really be added


⚠ Jenkins Plugins Artifactory has degraded performance

In b66d54e, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2166 ms

Resolved: Jenkins Plugins Artifactory performance has improved in a39fa8a after 26 minutes.


Can't figure out how to proceed in the installation

I was following the installation guide (https://github.com/IHTSDO/snow-owl/blob/master/documentation/src/main/asciidoc/installation_guide.adoc) but got stuck on the last part where it asks me to unzip the snowowl-community zip (unzip snowowl-community-{version}-mysql.zip -d /opt).
I'm not sure where to get this zip file and how to proceed from here with the installation. the guide is pretty confusing :(

Hi Amihai,
The zip file mentioned in the guide is the distribution of the Snow Owl application.
After running the maven build the zip file will be available in the releng/distribution/target/ directory.
Maven build instructions are here - https://github.com/IHTSDO/snow-owl/#build
I hope this helps.
Kai


A unified logging system for the whole netcdf-c library

One thing missing from the netcdf-c library is the general
ability to report more detailed execution information. For
example, if a routine returns the NC_EPERM error code (access
error), there is currently no general way to tell the user what
the name of the file for which access failed.  A library-wide
logging system would help mitigate this deficiency.  By enabling
logging, a user could get more information about, for example,
why a netcdf-c API call failed (and maybe even where).
This issue is intended to come to some agreement about how to provide
a unified logging system for the netcdf-c library. The proposal here
is basically to provide two systems: a trace system and a log system.
The trace system would basically be the existing log system in libsrc4.
The log system would be the one used in libdap2+libdap4.
Currently, two logging facilities exist in the netcdfd-c
library. One is in the libsrc4 directory and other is in the
libdap2 and libdap4 directories.
The two logging systems are different in terms of how they are
controlled. In libsrc4, a log request is associated with a
"level" number: -1 to 5, where -1 means no logging.  If the
global level is less than or equal to the level number
associated with a given log statement, then that log statement
is executed and a log message is output.
In libdap2 and libdap4, the log statement has an associated
ordered "class" of message: e.g. (in order) ERROR, WARN, INFO, DEBUG.
The classes of messages to be output is determined by a global log
level that is one of the classes. If the level is set to a given
class, then all log messages at that level or lower
will be output, otherwise suppressed. For example, if the
log level is INFO, then all log statements tagged ERROR, WARN, or INFO
will be output and log statements tagged DEBUG will be suppressed.
This logging system is closely patterned on the Java
logging system.
In practice, the libsrc4 logging system is used almost exclusively
as a trace system rather than logging per-se. Thus, as each procedure
is entered, a log/trace statement is executed to report on the
procedure and its arguments. Occasionally, log statements are used
to report error or warning information, but it is not the norm.
An additional feature for a logging system is to control where the
log output is to be sent. For both of the netcdf-c logging systems,
stderr is the default. But both can be directed elsewhere (typically
to some file).
As an aside, it would be worth noting HDF5 error reporting system and
(separate) trace system.

Or you mean that trace includes normal execution information, but log includes mostly error information?
yes; the issue of where the output goes is orthogonal to log vs trace.

Thanks for reminder. Moved my comment to
issue https://github.com/Unidata/netcdf-c/issues/643


Kill LocalProcess?

First off, thank you for this incredibly cool project.
I'm trying to kill a long-running interactive LocalProcess and can't tell whether this is supported by the current API.
So far, I've attempted:

kill(term.process.shellPid, SIGTERM)
Send the ^D exit signal: term.send(data: [0x4])

Neither has triggered the exit block I defined when initializing the terminal.
  let term = HeadlessTerminal { (exit) in
           print("Exit:\(exit)")
  }

Any tips?

Hello,
The kill operation is the only reliable one.  Sending control-d will only work if the process happens to be in the shell and the shell is configured to treat control-d as eof (which is the default but could be changed under you)
That said - there is possibly a limitation in the code in raising the notification when the process is killed, I would need to look into it - just a bit hard with the kids on vacation, but will try to look into it


Limit and Offset not working correctly

New user of library here 👋. Thank you so much for it. I need to add contacts screen to the app, nothing fancy. When I fetch contacts using this query:
contactsApi
                .queryWithPermission()
                .include { Name.all + Phone.all + Contact.PhotoThumbnailUri }
                .where { (Name.DisplayName startsWith searchText) }
                .orderBy(ContactsFields.DisplayNamePrimary.asc())
                .findWithContext()

I got 300+ contacts and everything works smoothly. When I am adding paging limit and offset it starts to act weird. It scrolls to 150 offset and stops. the last list has 9 elements, where my loadSize is 10, so the paging stops. I tried and hardcoded offset 150, limit 10 and it gives 9 elements which is not true.
Here is the query with limit and offset:
contactsApi
                .queryWithPermission()
                .include { Name.all + Phone.all + Contact.PhotoThumbnailUri }
                .where { (Name.DisplayName startsWith searchText) }
                .orderBy(ContactsFields.DisplayNamePrimary.asc())
                .limit(limit)
                .offset(offset)
                .findWithContext()

The problem is clearly that list.size is smaller then limit. Even if I test other offsets like 160, 200, 300 it gives the results but some reason some of them are not a full list. Maybe some contacts are malfunctioning and that breaks the query?

Hey @PiotrPrus, thanks for taking interest in this lib! I copy-pasted your query code into the sample app in the repo and am not able to reproduce the issue.
I used a very simple scenario. I created 300 contacts. Each contact has no data beside the name. Each contact is named "Contact 1xxx" where "xxx" is a number from 1 to 300. Here's the code I used to generate the test contacts;
for (i in 1..300) {
  contactsApi
      .insertWithPermission()
      .rawContact {
          setName {
              displayName = "Contact ${1000 + i}"
          }
      }
      .commitAsync()

I then modified ContactsActivity.kt to show only 10 contacts per page (limit(10)) starting at offset 0 and loading the next page every time the refresh button in the toolbar is clicked. Take a look at the recording below.
https://github.com/vestrel00/contacts-android/assets/4332753/df38b1cd-104a-4b30-8f06-415a10e39ae5
Note that I had to also include Contact.DisplayNamePrimary because that is what the sample app uses to display in the list. Other than that, the query is a direct copy-paste.

Maybe some contacts are malfunctioning and that breaks the query?

Perhaps. I would really like to see the set of contacts that is able to reproduce this issue. Could you please help me with that?
It would make things easier to be able to reproduce the issue using a smaller number of contacts (300+ is a lot when trying to debug an issue). I would suggest creating around 10 to 20 test contacts with some test data where the issue is reproducible. Use smaller limit like 2, 3, 4, or 5.
Looking forward to your reply! I'm not marking this as a bug yet until I am able to reproduce it on my end because it's not impossible that the bug is not with the library =)

Closing this for now because no feedback.


Feat: Make it responsive

Describe the feature
@Satyam1923
when i  try to open this web in responsive screen, the design of whole page is changed
we can make it responsive with the help of grid layoyt
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I can help you with that. Please assign me under GSSOC 2024.


SDK installation problem

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D400

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Ubuntu 16

Kernel Version (Linux Only)
4.15.0

Platform
PC

SDK Version
2.17.1. }

Language
C

Segment
Robot

Issue Description
Hello,
I install the realsense 2.17.1 according to the manual installation guide.
When I run:
./scripts/patch-realsense-ubuntu-lts.sh, a fail information occur, the total output is  below:
Package required libusb-1.0-0-dev:  - found
Package required libssl-dev:  - found
Create patches workspace in ubuntu-xenial-hwe folder

The kernel has modified files:
	modified:   drivers/media/usb/uvc/Makefile
	modified:   drivers/media/usb/uvc/uvc_driver.c
	modified:   drivers/media/v4l2-core/v4l2-ioctl.c
	modified:   include/uapi/linux/videodev2.h
Proceeding will reset all local kernel changes. Press 'n' within 10 seconds to abort the operation
Do you want to proceed? [Y/n]Y
Update the folder content with the latest from mainline branch
remote: Total 0 (delta 0), reused 0 (delta 0)
From git://kernel.ubuntu.com/ubuntu/ubuntu-xenial
 * branch            hwe        -> FETCH_HEAD
Resetting local changes in ubuntu-xenial-hwe folder
 HEAD is now at 50ec9ec UBUNTU: Ubuntu-hwe-4.15.0-126.129~16.04.1
Applying realsense-uvc patch
patching file drivers/media/usb/uvc/Makefile
patching file drivers/media/usb/uvc/uvc_driver.c
Hunk #1 succeeded at 208 with fuzz 2 (offset 5 lines).
patching file drivers/media/usb/uvc/uvcvideo.h
Hunk #1 FAILED at 153.
1 out of 1 hunk FAILED -- saving rejects to file drivers/media/usb/uvc/uvcvideo.h.rej
patching file drivers/media/v4l2-core/v4l2-ioctl.c
Hunk #1 succeeded at 1248 (offset 2 lines).
patching file include/uapi/linux/videodev2.h
Hunk #1 succeeded at 680 (offset 12 lines).

I ignore it and keep install the librealsense. After installation, I  test the installation by realsense-viewer. some warning occur:
 26/11 22:43:59,800 WARNING [140147348924160] (sensor.cpp:338) Unregistered Media formats : [ UYVY ]; Supported: [ ]
 26/11 22:43:59,809 WARNING [140147348924160] (backend-v4l2.cpp:1248) Pixel format 36315752-1a66-a242-9065-d01814a likely requires patch for fourcc code RW16!
 26/11 22:43:59,810 WARNING [140147348924160] (sensor.cpp:338) Unregistered Media formats : [ RW16 ]; Supported: [ ]
 26/11 22:44:04,857 WARNING [140147348924160] (types.cpp:57) set_pu(id=9) failed! Last Error: Input/output error
 26/11 22:44:04,857 WARNING [140147348924160] (sensor.cpp:722) Exception was thrown when inspecting properties of a sensor
 26/11 22:44:04,857 ERROR [140147348924160] (types.h:214) xioctl(VIDIOC_G_CTRL) failed Last Error: Invalid argument
 26/11 22:44:04,858 WARNING [140147348924160] (sensor.cpp:722) Exception was thrown when inspecting properties of a sensor

I check on the Motion module, an error occur:Motion Module failure, the terminal in which realsense-viewer run output:
 26/11 22:45:06,480 WARNING [140147215537920] (ds5-timestamp.cpp:174) HID timestamp not found! please apply HID patch.

Then I check on the RGB Camera, the terminal in which realsense-viewer run output:
26/11 22:53:21,611 WARNING [140146921957120] (ds5-timestamp.cpp:64) UVC metadata payloads not available. Please refer to installation chapter for details.

Then I check on the Stereo Module, the terminal in which realsense-viewer run output:
26/11 22:54:33,046 WARNING [140146913564416] (ds5-timestamp.cpp:64) UVC metadata payloads not available. Please refer to installation chapter for details.

Then I check off the Motion Module, the terminal in which realsense-viewer run output:
 26/11 22:55:24,067 ERROR [140147638209152] (types.h:214) Failed to enable_sensor /sys/devices/pci0000:00/0000:00:14.0/usb2/2-1/2-1:1.5/0003:8086:0B3A.0003/HID-SENSOR-2000e1.3.auto/enable_sensor Last Error: Permission denied

Could you please provide some advice to solve these issues? Thanks a lot.

Hi @TouchDeeper   Given the number of errors that you have experienced, I would recommend trying a backend installation of librealsense, which requires an internet connection but is not depenent on kernel versions or Linux versions and does not require patching.
The librealsense version 2.17.0 from November 29 2018 that you are using is very old, as the SDK is currently up to 2.40.0 at the time of writing this.  If you need to use this version for your project then the libuvc backend method of backend installation should be the suitable one for that age of SDK.
https://github.com/IntelRealSense/librealsense/blob/master/doc/libuvc_installation.md
If you are able to upgrade your project to a modern SDK, then versions 2.30.0 and newer can instead use a backend installation method called RSUSB to build librealsense from source code with the CMake build flag -DFORCE_RSUSB_BACKEND=true.  Again, an internet connection is required for this method.
https://github.com/IntelRealSense/librealsense/issues/6432#issuecomment-631484711

@MartyG-RealSense
Thank you for your reply. Is the realsense-ros compatible with the backend installation? Are there some differences in using between manually installation with backend installation?

The ROS wrapper can work with librealsense whether it is built manually or with RSUSB.
RSUSB does have limitations compared to a manual build.  For more information about this, please visit the link below and scroll down through the linked-to comment to the section headed What are the advantages and disadvantages of using libuvc vs patched kernel modules?
https://github.com/IntelRealSense/librealsense/issues/5212#issuecomment-552184604

patching file drivers/media/usb/uvc/uvcvideo.h Hunk #1 FAILED at 153. 1 out of 1 hunk FAILED -- saving rejects to file drivers/media/usb/uvc/uvcvideo.h.rej
We have the same issue and we find out that you need to change
scripts/realsense-camera-formats-xenial-hwe.patch
in order to match a recent change of uvcvideo.h
realsense-camera-formats-xenial-hwe.patch.txt

Thanks very much @chia-labradorsystems for your advice to @TouchDeeper   :)

@chia-labradorsystems Thanks for your advice, I use your patch, it work. But I found that the v1-media-uvcvideo-mark-buffer-error-where-overflow.patch also has problem, the patch this file want to apply is below:
diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
index fb86d6a..81a3530 100644
--- a/drivers/media/usb/uvc/uvc_video.c
+++ b/drivers/media/usb/uvc/uvc_video.c
@@ -1077,6 +1077,7 @@ static void uvc_video_decode_data(struct uvc_streaming *stream,
 	/* Complete the current frame if the buffer size was exceeded. */
 	if (len > maxlen) {
 		uvc_trace(UVC_TRACE_FRAME, "Frame complete (overflow).\n");
+		buf->error = 1;
 		buf->state = UVC_BUF_STATE_READY;
 	}
 }

But the line buf->error = 1; want to add already exist. I comment this patch then the ./scripts/patch-realsense-ubuntu-lts.sh succeed.
The output of sudo dmesg | tail -n 50 is:
[ 2232.450836] usbcore: deregistering interface driver uvcvideo
[ 2279.527160] media: Linux media interface: v0.10
[ 2279.530285] Linux video capture interface: v2.00
[ 2279.671020] uvcvideo: Found UVC 1.00 device Chicony USB2.0 Camera (04f2:b59e)
[ 2279.672379] uvcvideo 1-8:1.0: Entity type for entity Extension 4 was not initialized!
[ 2279.672382] uvcvideo 1-8:1.0: Entity type for entity Processing 2 was not initialized!
[ 2279.672385] uvcvideo 1-8:1.0: Entity type for entity Camera 1 was not initialized!
[ 2279.672550] input: Chicony USB2.0 Camera: Chicony  as /devices/pci0000:00/0000:00:14.0/usb1/1-8/1-8:1.0/input/input36
[ 2279.672780] usbcore: registered new interface driver uvcvideo
[ 2279.672782] USB Video Class driver (1.1.1)

The registered new interface driver uvcvideo  sholud indicate the script run succeed.
Then I run realsense-viewer, some warning occur:
 03/12 14:19:40,127 WARNING [139772010632960] (sensor.cpp:338) Unregistered Media formats : [ UYVY ]; Supported: [ ]
 03/12 14:19:45,192 WARNING [139772010632960] (types.cpp:57) set_pu(id=9) failed! Last Error: Input/output error
 03/12 14:19:45,192 WARNING [139772010632960] (sensor.cpp:722) Exception was thrown when inspecting properties of a sensor
 03/12 14:19:45,192 ERROR [139772010632960] (types.h:214) xioctl(VIDIOC_G_CTRL) failed Last Error: Invalid argument
 03/12 14:19:45,192 WARNING [139772010632960] (sensor.cpp:722) Exception was thrown when inspecting properties of a sensor

Does these waring affect?

@MartyG-RealSense @chia-labradorsystems  I don't know why,  there will be new warnings occur now when I open realsense-viewer.
When I check on Stereo Module, a warning occurs:
(ds5-timestamp.cpp:64) UVC metadata payloads not available. Please refer to installation chapter for details.
when I check on RGB Camera,  a warning occurs:
UVC metadata payloads not available. Please refer to installation chapter for details.
when I check on Motion Module, a warning occurs:
 HID timestamp not found! please apply HID patch
I found that the hardware timestamp of all streams is not available except the accel stream.

@MartyG-RealSense @chia-labradorsystems There will be new warning occurs like I post in my first comment. When I open the realsense-viewer,  warnings occur:
03/12 22:35:14,655 WARNING [140166347478784] (sensor.cpp:338) Unregistered Media formats : [ UYVY ]; Supported: [ ]
 03/12 22:35:14,664 WARNING [140166347478784] (backend-v4l2.cpp:1248) Pixel format 36315752-1a66-a242-9065-d01814a likely requires patch for fourcc code RW16!
 03/12 22:35:14,664 WARNING [140166347478784] (sensor.cpp:338) Unregistered Media formats : [ RW16 ]; Supported: [ ]
 03/12 22:35:19,711 WARNING [140166347478784] (types.cpp:57) set_pu(id=9) failed! Last Error: Input/output error
 03/12 22:35:19,712 WARNING [140166347478784] (sensor.cpp:722) Exception was thrown when inspecting properties of a sensor
 03/12 22:35:19,712 ERROR [140166347478784] (types.h:214) xioctl(VIDIOC_G_CTRL) failed Last Error: Invalid argument
 03/12 22:35:19,712 WARNING [140166347478784] (sensor.cpp:722) Exception was thrown when inspecting properties of a sensor

Then I check on Stereo Module, a warning occurs:
(ds5-timestamp.cpp:64) UVC metadata payloads not available. Please refer to installation chapter for details.,
Then I check on RGB Camera, same waring occurs:
(ds5-timestamp.cpp:64) UVC metadata payloads not available. Please refer to installation chapter for details.
Then I check on Motion Module, a warning occurs:
(ds5-timestamp.cpp:174) HID timestamp not found! please apply HID patch.
What's more, the hardware timestamp of all streams is not available except the accel stream.

Could you please provide some advice? Tanks a lot.

@TouchDeeper   It looks as though hardware metadata support is not enabled on your librealsense build.  When performing a manual build, metadata support is provided by patching (a step you reported as having failed in the opening comment of this case).
If you are still using SDK 2.17.0 then could you try a libuvc-backend build of librealsense instead of a manual one if you have not tried it already, please?
https://github.com/IntelRealSense/librealsense/blob/master/doc/libuvc_installation.md
Do not run the patching script after the libuvc-ackend build is completed, as patching is not necessary with the backend installation method and metadata support should be included in the build already.

@MartyG-RealSense, @ev-mp   thank you for your reply.
I uninstall the installed SDK and reinstall according to libuvc_installation.md. It is worth noting that I just run a part of libuvc_installation.md:
sudo cp config/99-realsense-libusb.rules /etc/udev/rules.d/
sudo udevadm control --reload-rules && sudo udevadm trigger
mkdir build && cd build
cmake ../ -DFORCE_LIBUVC=true -DCMAKE_BUILD_TYPE=release
make -j2
sudo make install

because I have installed the dependencies manually and I need the 2.17.1 version.
After installation, I run rs-enumerate-devices to verify the installation, but No device detected. Is it plugged in? occurs.
The information of lsusb is
Bus 002 Device 008: ID 0dd8:0562 Netac Technology Co., Ltd
Bus 002 Device 016: ID 8086:0b3a Intel Corp.
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 003: ID 04f2:b59e Chicony Electronics Co., Ltd
Bus 001 Device 009: ID 24ae:1813
Bus 001 Device 004: ID 8087:0aaa Intel Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

The related information of usb-device is:
T:  Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 16 Spd=5000 MxCh= 0
D:  Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs=  1
P:  Vendor=8086 ProdID=0b3a Rev=50.c8
S:  Manufacturer=Intel(R) RealSense(TM) Depth Camera 435i
S:  Product=Intel(R) RealSense(TM) Depth Camera 435i
S:  SerialNumber=039223051536
C:  #Ifs= 6 Cfg#= 1 Atr=c0 MxPwr=440mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=0e(video) Sub=01 Prot=00 Driver=uvcvideo
I:  If#= 1 Alt= 0 #EPs= 1 Cls=0e(video) Sub=02 Prot=00 Driver=uvcvideo
I:  If#= 2 Alt= 0 #EPs= 1 Cls=0e(video) Sub=02 Prot=00 Driver=uvcvideo
I:  If#= 3 Alt= 0 #EPs= 0 Cls=0e(video) Sub=01 Prot=00 Driver=uvcvideo
I:  If#= 4 Alt= 0 #EPs= 1 Cls=0e(video) Sub=02 Prot=00 Driver=uvcvideo
I:  If#= 5 Alt= 0 #EPs= 1 Cls=03(HID  ) Sub=00 Prot=00 Driver=usbhid

The output of dmesg is:
[ 7040.975712] usb 2-1: new SuperSpeed USB device number 18 using xhci_hcd
[ 7040.996415] usb 2-1: New USB device found, idVendor=8086, idProduct=0b3a
[ 7040.996420] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 7040.996424] usb 2-1: Product: Intel(R) RealSense(TM) Depth Camera 435i
[ 7040.996427] usb 2-1: Manufacturer: Intel(R) RealSense(TM) Depth Camera 435i
[ 7040.996429] usb 2-1: SerialNumber:<PHONE_NUMBER>36
[ 7040.997799] uvcvideo: Unknown video format 00000050-0000-0010-8000-00aa00389b71
[ 7040.997807] uvcvideo: Unknown video format 00000032-0000-0010-8000-00aa00389b71
[ 7040.997898] uvcvideo: Found UVC 1.50 device Intel(R) RealSense(TM) Depth Camera 435i (8086:0b3a)
[ 7040.999580] uvcvideo: Unable to create debugfs 2-18 directory.
[ 7040.999772] uvcvideo 2-1:1.0: Entity type for entity Intel(R) RealSense(TM) Depth Ca was not initialized!
[ 7040.999776] uvcvideo 2-1:1.0: Entity type for entity Processing 2 was not initialized!
[ 7040.999780] uvcvideo 2-1:1.0: Entity type for entity Camera 1 was not initialized!
[ 7040.999989] input: Intel(R) RealSense(TM) Depth Ca as /devices/pci0000:00/0000:00:14.0/usb2/2-1/2-1:1.0/input/input46
[ 7041.000759] uvcvideo: Unknown video format 36315752-1a66-a242-9065-d01814a8ef8a
[ 7041.000768] uvcvideo: Found UVC 1.50 device Intel(R) RealSense(TM) Depth Camera 435i (8086:0b3a)
[ 7041.001656] uvcvideo: Unable to create debugfs 2-18 directory.
[ 7041.001754] uvcvideo 2-1:1.3: Entity type for entity Processing 7 was not initialized!
[ 7041.001757] uvcvideo 2-1:1.3: Entity type for entity Extension 8 was not initialized!
[ 7041.001760] uvcvideo 2-1:1.3: Entity type for entity Camera 6 was not initialized!
[ 7041.111641] hid-sensor-hub 0003:8086:0B3A.0012: No report with id 0xffffffff found
[ 7041.186733] hid-sensor-hub 0003:8086:0B3A.0012: No report with id 0xffffffff found

Mixing installations together that were created by different methods is not recommended.  Because -DFORCE_LIBUVC=true was used, it is likely that the dependencies were freshly installed automatically over the internet, potentially causing a conflict with dependencies that were already present from the previous 2.17.0 installation.
If you need to install the 2.17 manual installation, you should be able to by going to its build folder and inputting the instruction below:
sudo make uninstall && make clean

@MartyG-RealSense I have done sudo make uninstall && make clean.
What's more, how can I specify the SDK version in the libuvc_installation.sh?

Hi @TouchDeeper   You have a point about the problems of using libuvc_installation.sh for the installation, as it is set by default to look for the latest master version of the SDK instead of the 2.17 version that you want.   It may be possible to edit the path of the script to look for a local zip file containing the 17.1 source code but it is likely too much trouble to be worth trying.
Let's go back to the manual installation process.
https://github.com/IntelRealSense/librealsense/blob/master/doc/installation.md
Can you confirm please that when you perform the manual installation, you perform all of the steps before Step 3.

@MartyG-RealSense
I install the sdk2.40 according to the libuvc_installation.sh.
I find that after I calibrated the IMU according to IMU Calibration Tool for Intel® RealSense™ Depth Camera,  if I reboot the PC, the calibration result will not work. I have to reload the calibration result by python rs-imu-calibration.py -i accel_1.txt gyro_1.txt to make it work.
Is this situation normal? Thank you a lot!

Once the .txt file has been saved, the IMU calibration tool should then ask you if you want to save the calibration to the camera hardware.   Do you receive this message and input Y in response to it, please?
To quote the documentation:

Then the script will ask to save the data to the Device.
Choose Y (or any other combination with Y or y in it) to save.
That’s it. At the end a confirmation message appears:
SUCCESS: saved calibration to camera.

Thank you for your reply. But I 'm sure I have entered Y when it ask me whether to save the result to camera.
---Original---
From<EMAIL_ADDRESS>Date: 2020/12/11 20:18:11
To<EMAIL_ADDRESS>Cc: "Mention"<mention<EMAIL_ADDRESS>Subject: Re: [IntelRealSense/librealsense] SDK installation problem (#7863)
Once the .txt file has been saved, the IMU calibration tool should then ask you if you want to save the calibration to the camera hardware.   Do you receive this message and input Y in response to it, please?
To quote the documentation:
Then the script will ask to save the data to the Device.
Choose Y (or any other combination with Y or y in it) to save.
That’s it. At the end a confirmation message appears:
SUCCESS: saved calibration to camera.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

If you are still using SDK 2.17, I wonder if that could be a cause of the calibration not saving, as the SDK release notes say that the IMU calibration tool was first released in SDK 2.18.0, the next version after the one you are using.
https://github.com/IntelRealSense/librealsense/wiki/Release-Notes#release-2180

Thanks for the update @TouchDeeper - do you still have a problem that needs solving, please?

@MartyG-RealSense I'm still testing, please give me more time. Thank you a lot.

No problem, please update when you have test results.   Good luck!

@MartyG-RealSense I have posted a new issue about calibration, could you please have a look? Thank you a lot.

I will look at it.   Thanks very much.


JSON decode error when defining database

                                            [!] QR Code Generated: https://discord.com/ra/qqFkqrarq0ra0QJ0o-Ky0Jn_8pq0nANPil69y1nVkPo

Task exception was never retrieved
future: <Task finished name='Task-30' coro=<RemoteAuthClient.run() done, defined at /Users/mte/Library/Python/3.8/lib/python/site-packages/remoteauthclient/remoteauthclient.py:196> exception=JSONDecodeError('Expecting value: line 1 column 1 (char 0)')>
Traceback (most recent call last):
File "/Users/mte/Library/Python/3.8/lib/python/site-packages/remoteauthclient/remoteauthclient.py", line 199, in run
await self._task
File "/Users/mte/Library/Python/3.8/lib/python/site-packages/remoteauthclient/remoteauthclient.py", line 179, in _run
await self._event("userdata", user=user)
File "/Users/mte/Library/Python/3.8/lib/python/site-packages/remoteauthclient/remoteauthclient.py", line 105, in _event
return await handler(**kwargs)
File "/Users/mte/Documents/coding/discord-hackering/Fake-Verification-Bot-main/main.py", line 206, in on_userdata
database = json.load(open("/Users/mte/Documents/coding/discord-hackering/Fake-Verification-Bot-main/databae.json", encoding="utf-8"))
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/json/init.py", line 293, in load
return loads(fp.read(),
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/json/init.py", line 357, in loads
return _default_decoder.decode(s)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

nvm, i am the stupid, simply add {} in the blank database.json file.


Add pre-commit configuration

Inspired by pre-commit configuration from homeassistant core project.

I like this change a lot. I had to fix flake8 so many times after github actions failed!


Clean up url generation and testing

This cleans up a bunch of stuff with how we generate, use and test urls - see individual commit messages for details of each change.

No more "secure => true" \o/


Types when destructuring arrays

    function f([a,b,c]) {
      // this works but a,b and c are as any
    }

it's possible write something like that?
    function f([a: number,b: string,c: boolean]) {
      // being a typed as number, b as string and c as boolean?
    }

You can write:
function f([a, b, c]: [number, string, boolean]) {
}

Thank you @AyaMorisawa

Cross-post reference http://stackoverflow.com/questions/31923739/types-when-destructuring-arrays


Support of route-target route-map

Enhancement summary
Under router_bgp/vrf stanza, the eos_cli_config_gen schema doesn't support route-target route-map:
"The route-target route-map command allows the user to export and import route target extended community lists from one VRF to another using route maps.
Syntax
route-target {import | export} [evpn | vpn-ipv4 | vpn-ipv6] route-map RM"
Which component of AVD is impacted
eos_cli_config_gen
Use case example
vrf STK-HUB-SMT80-001
rd <IP_ADDRESS>:42001
route-target import evpn 42001:1
route-target import evpn 42001:42001
route-target export evpn 42001:2
route-target export evpn 42001:42001
route-target import evpn route-map RM_DENY-DEFAULT  <<<<<<<<<<<
...
Describe the solution you would like
1/ In eos_cli_config_gen schema, under router_bgp/vrfs/route_targets/import or export, in addition to "address_family" and "route_targets" properties, we add a new property (key: "route_map", value: "string")
2/ In jinja2 template "router-bgp.j2", make the relevant changes
Describe alternatives you have considered
No response
Additional context
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

We need this yes. For now I believe others have just entered "route-map RM_DENY-DEFAULT" under additional_route_targets.


TodoMVC.com FOAM app Broken

New todo items don't show in list.

Caused by stale data in LocalStorage. Only affects people with existing data in their LocalStorage, like us on the team.


example for returning more than 1 value for native

can you please add an example for returning more than one value via native?
I have 4 values in the config page to be set by returning them from a function in sendTo.
in jsonUIconfig I have:
		"mqttUserId": {
			"type": "text",
			"label": "mqtt userId",
			"newLine": false
		},
		"mqttUserName": {
			"type": "text",
			"label": "mqtt user name",
			"newLine": false
		},
		"mqttPwd": {
			"type": "text",
			"label": "mqtt pwd",
			"newLine": true
		},
		"mqttClientId": {
			"type": "text",
			"label": "mqttClientId",
			"newLine": false
		},
		"_create": {
			"type": "sendTo",
			"label": "Create Login Data",
			"command": "create",
			"variant": "outlined",
			"useNative": true,
			"jsonData": "{\"user\": \"${data.mqttUserName}\", \"pass\": \"${data.mqttPwd}\"}}"
		}

and in the message portion I have
	const resultFromFunction = {
		native: {
			mqttUserId: '1232445564356',
			mqttUserName: 'login.User',
			mqttPwd: 'login.Password',
			mqttClientId: 'login.clientID'
		}
	};
	this.sendTo(obj.from, obj.command, resultFromFunction, obj.callback);

after returning the message only the last value is modified in the config page of the adapter.
If I reduce it to one value, it is running OK.

I can add it if someone canbzell how it works. I do not even know if its possible.
Note: I did not develop jsonconfig or its components.

I couldn't get this to work either. Its a Admin missing feature/bug imho.

OK, I transfer this to the admin adapter


timeline_drawer measurement bugs

There are some bugs drawing measurements in the circuit timeline drawer. Taking a simple circuit and a backend to schedule on:
from qiskit import QuantumCircuit, transpile
from qiskit.test.mock import FakeParis
from qiskit.visualization import timeline_drawer

qc = QuantumCircuit(2, 2)
qc.cx(0, 1)

backend = FakeParis()

The following scenarios have various errors...
1- One measurement with show_clbits=False
qc.measure(0, 0)
new_qc = transpile(qc, backend, scheduling_method='alap')
timeline_drawer(new_qc, show_clbits=False)

KeyError: Clbit(ClassicalRegister(2, 'c'), 0)
2- One measurement with show_clbits=True
qc.measure(0, 0)
new_qc = transpile(qc, backend, initial_layout=[25, 26], scheduling_method='alap')
timeline_drawer(new_qc, show_clbits=True)

The clbit measure seems off and starts earlier than the qubit measure.

3- Two measurement with show_clbits=False
qc.measure(0, 0)
qc.measure(1, 1)
new_qc = transpile(qc, backend, initial_layout=[25, 26], scheduling_method='alap')
timeline_drawer(new_qc, show_clbits=False)

TypeError: '<=' not supported between instances of 'float' and 'NoneType'
4- Two measurements with show_clbits=True
qc.measure(0, 0)
qc.measure(1, 1)
new_qc = transpile(qc, backend, initial_layout=[25, 26], scheduling_method='alap')
timeline_drawer(new_qc, show_clbits=True)

AttributeError: 'list' object has no attribute 'repeat'

Thanks for reporting this. I was aware of this issue 2 but the clbits are bit problematic because they are not transpiled with t0 nor delay (thus it always starts at t=0). In principle the program parser of the drawer parses the program for each bit and we need to update this logic to infer correct t0 of measurement instruction on clbits.
I need to investigate show_clbits bugs, but if there anyone interested in solving this I'm also happy to review.

Ok the clbits may be a bit harder so if we could at least fix the case where we just plot the qubits (issue 1 and 3) then that will at least allow us to plot basic circuit timelines (we set show_clbits=False by default)


Swipe from anywhere with floating effect on scene

Thank you for building this package, I really like this package so much ❤
That would be great if we could make add a fluid effect like Instagram to make the next screen floating on the current screen.
See the right image below:
https://user-images.githubusercontent.com/17447048/146701494-a03dc62a-58f1-4c36-8a60-ea62f64823eb.mp4
Reference: article
Thank you again 🚀

Sorry for the delay. Thanks for creating this issue with all the details! I really like how this animation looks and am open to a PR adding it to this package. Unfortunately, I don't think that I'll have the time to implement it myself anytime soon.


chruby detection broken since 0.5.13

          This broke chruby detection for me. I **HAVE** a `.ruby-version` in my repo (a gem, not a Rails app) and I have a global `~/.ruby-version` file in my home folder. It works everywhere, but not with this version of the ruby-lsp extension in latest VSCode. It was working perfectly until this change.

Originally posted by @tvdeyen in https://github.com/Shopify/ruby-lsp/issues/1438#issuecomment-1994621516

This is how you pin to a previous version https://stackoverflow.com/questions/42626065/vs-code-how-to-rollback-extension-install-specific-extension-version

I'm also getting a chruby error, I think this is the same issue
Failed to activate chruby environment: Cannot find installation directory for Ruby version 3.2.2

I'm on macOS 14.4
> which ruby
/Users/me/.rubies/ruby-3.2.2/bin/ruby

Ruby version:
> cat .ruby-version
3.2.2

Extension output:
2024-03-13 12:50:15.250 [info] (wb-app) Checking if asdf is available on the path with command: /bin/zsh -i -c 'asdf --version'
2024-03-13 12:50:15.856 [info] (wb-app) Checking if chruby is available on the path with command: /bin/zsh -i -c 'chruby --version'
2024-03-13 12:50:16.402 [info] (wb-app) Discovered version manager chruby
2024-03-13 12:50:16.413 [info] (wb-app) Discovered Ruby version 3.2.2 from file:///Users/me/app/.ruby-version

Followed by the error Failed to activate chruby environment: Cannot find installation directory for Ruby version 3.2.2
Permissions:
~/.rubies is owned by my user

Thank you for the report. Are you installing your rubies in a custom directory by any chance? For example, modifying the RUBIES environment variable so that chruby can find them in a non standard place? Please let us know where your rubies are installed.

No. The rubies are in ~/.rubies what is the default I think.

Also, what operating system are you using?

I am on macOS 14.3.1 (23D60)

Just published v0.5.14. Please let us know if the issue is fixed.

Works like charm! Thanks


I wanna learn

I have a question or need help
Please DO NOT post it! We don't provide support in GitHub issues any more.
We would be happy if you join our group chat on Telegram  and ask the community to help.

If you open an issue asking for support, the issue would be closed without providing any answer.

Please, read issue templates before posting. If you have questions feel free to join our support group.
https://t.me/joinchat/B35YY0QbLfd034CFnvCtCA


nvchecker: 2.3 -> 2.4

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 131910 at 67fc7263 run on aarch64-linux 1

4 packages built successfully:

haskellPackages.nvfetcher
nvchecker (python39Packages.nvchecker)
nvfetcher
python38Packages.nvchecker


How to perminantly bind a pv to a pvc after creation?

When I am in AWS and using the aws ebs csi driver I can do a 3 step deploy to get my pv's really to be pv's such that when a deployment is removed (or redeployed/updated) that I bind the same pv to the pvc.

Create a pvc, pod and deploy into k8s
Wait for pv to be created from csi driver
Create a new pv in my kustomize referencing the volume that has been created
Modify pvc to reference volumeName
Re-deploy everything.

Two questions, is there an easier way, and if not, what goes in the csi section (and any other pertinent sections) below to get me the same behavior?
# define the data pv (having spun one up before and hard-coding it in here)
apiVersion: v1
kind: PersistentVolume
metadata:
  name: registry-data-vol
spec:
  storageClassName: warm
  capacity:
    storage: 50Gi
  volumeMode: Filesystem
  accessModes:
    - ReadWriteOnce
  csi:
    driver: ebs.csi.aws.com
    fsType: ext4
    volumeHandle: vol-xxxx

This is how I did it:
---
apiVersion: v1
kind: PersistentVolume
metadata:
  annotations:
    pv.kubernetes.io/provisioned-by: rancher.io/local-path
  name: pv-retain-vault
spec:
  accessModes:
  - ReadWriteOnce
  capacity:
    storage: 10Gi
  claimRef:
    apiVersion: v1
    kind: PersistentVolumeClaim
    name: pv-retain-vault
    namespace: vault
  hostPath:
    path: /var/lib/rancher/k3s/storage/pv-retain-vault
    type: DirectoryOrCreate
  nodeAffinity:
    required:
      nodeSelectorTerms:
      - matchExpressions:
        - key: kubernetes.io/hostname
          operator: In
          values:
          - capital
  storageClassName: local-path
  volumeMode: Filesystem
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: pv-retain-vault
  namespace: vault
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 10Gi
  storageClassName: "" # Empty string must be explicitly set otherwise default StorageClass will be set
  volumeName: pv-retain-vault

The key points are from this link:

ensure there is a claimRef in your PV to pre-bind it to your PVC.
use the volumeName and a blank storageClassName in the PVC to ensure it uses the volume as is.

Let me know if that helps.


add .eslint.js

add .eslint.js used to let developer easy to set up environment.
CLI: use eslint instead of prettire. It's accepted by many developer.
"lint" script is many developer's habit.

This commit is not useful for "use". So you don't need to merge it before release new version.

No sorry we're going to go ahead with Prettier. Thanks

haha. Actually I don't mind any kind of coding style. This PR is still use "prettier" not other style. Just replace linter "prettire" by "eslint".


async/await: adopt latest "main" renames

Motivation:
On Swift's main branch Task.runDetached has been renamed to detach.
Modifications:
Adopt the new spelling.
Result:
Compiles again on the main nightlies.

late lgtm, thanks for following up :)


Update wallaroo-command-line-options

Update command line options to reflect current output of --help
Update examples to use full-length options
Add section on machida's --application-module parameter and setting PYTHONPATH
Rewrite section on --out to reflect that it is only valid for TCP Sink, and indicate
that users using other sinks should refer to the specific sink's documentation
Add notes on log rotation and log rotation file size

[skip ci]
closes #1461

@nisanharamati I haven't done a thorough review but if you're indicating:

Rewrite section on --out to reflect that it is only valid for TCP Sink, and indicate
that users using other sinks should refer to the specific sink's documentation

You should do something similar for --in since that is only valid for TCP Source.

@dipinhora

Rewrite section on --out to reflect that it is only valid for TCP Sink, and indicate that users using other sinks should refer to the specific sink's documentation

You should do something similar for --in since that is only valid for TCP Source.

Hmmm. Good point.
Should I also open an issue to update startup_help.pony (since it still lists --in as required, and makes the assumption of a TCP Source)

@aturley updated #1461 to cover the additional issues

Thanks for that option, by the way


Fix issue with dev process crashing

Previously we were trying to start up the server immediately when the compilation was invalid. Instead, we should inform the dev runtime that the build is in progress. This fixes a bug where the second error after a crashed server would cause the dev process to crash.
Fixes #441

!merge


Update EnableMailboxAuditing.ps1

no idea what to do here...

@alexfcga what do you mean, friend?


Expose jsPDF's output formats to config. Promise interface.

You can specify the output format of jsPDF in attribute 'pdfOutputFormat' of the options object. For example 'datauri'.
Now html2pdf function returns a promise, resolved with pdf in the desired format, or undefined on save.

Hey @sergilrod, thanks for the contribution! As I've mentioned elsewhere I'm working on a revamp to the API, which will include Promises and the ability to customize the output.

Ok then. Looking forward to see the changes.
Thanks!!

Hi, I have just pushed a new branch, new-api, which is ready for testing! The readme has all the information on the new API. Please let me know if there are any problems with it - I want to make sure it's stable before merging into master!
The jsPDF.output method is now exposed through html2pdf's own output method, like so:
html2pdf().from(element).toPdf().output(type, options).then(function (val) {
  // Output value is stored in val.
});

Closing, v0.9.0 added the requested feature.


Does not work properly with STI (single table inheritance)

I'm using rails 3 beta2, and I've tried both the master branch, and 1.1.rc0. When I use devise_for in my routes, the routes are never created. 'rake routes' never shows any session/devise related routes, just those that I've created.
It doesn't throw any errors or break anything, the routes just don't come through. I have to manually set them for them to work.

Yep exactly. In order for the STI models to work, you have to re-declare the devise method in your child models.
Heres a better explanation:
http://pastie.org/915925

Link not working


About the cuda version

Dear the authors, thanks for your wonderful work! I'm curious about whether I could run your code under other CUDA versions, for example like CUDA 11.3 and CUDA 11.8?
Really looking forward to your reply!!!^^

Thank you for your attention, I think the CUDA 11.3 or CUDA 11.8 can also well run my code. I just list the version of my environment.

Thanks for your prompt reply! I'll try it immediately : )


Fix planUpdatable check

The logic was reversed deciding to hide the plans step when updating a service instance.
See https://github.com/openshift/origin-web-console/issues/2350

@jmontleon

This allows me to update the plan successfully now.
Maybe better to open a separate issue for this one, but what I see now is:
We specify in the dev plan that it can be updated to prod in the updates_to array in the dev plan and I can do that. (see comment at: https://github.com/openshift/origin-web-console/issues/2350 for catalog output.)
However we don't specify that prod can be 'downgraded' to dev (the updates_to array is empty and ommited in the catalog output, but the UI still lets me try to do that.

@jmontleon Can you open a separate issue for updates_to? I don't see it mentioned in the spec.
https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md
cc @pmorie


Support for a histogram buckets api

Doesn't look like this has been asked here before. One thing my team is looking for is the ability to specify histogram buckets when registering a histogram. This can currently be done at the exporter level, but there are a few reasons why this would be useful at the registration level. One reason being ease of configuration. A library should be able to suggest an appropriate bucket distribution that a consumer can then accept by default or override. This would also provide a unified interface for exporters to support which can help with making exporters more compatible with each other. Not sure exactly what the api should look like, perhaps:
describe_histogram!("my_hist", "histogram with exponential buckets").with_exp_buckets(0.1, 1.5, 25);

👋🏻
This is not the first time this request has been made, but in general, I've consciously avoided providing an API like this because it forces particular decisions around using histograms that I believe are better left as an exporter concern.
At a high level, doing this right now would mean changing the recorder API in a way that I'm not willing to do. This change would only benefits Prometheus users, and that's too much of an idiosyncrasy to bake into the core API. I do have thoughts/plans around a future API change to support for generic/arbitrary metric metadata, one that could potentially support defining exporter-specific details that doesn't force the API to take on such Prometheus-specific details... but that's a ways off.
This is hopefully something that can be addressed before that by Prometheus finally releasing native histogram support as GA.


Should component volume consider symmetryFactor?

In #1954, we are starting to store more information at the component level. One of those things is the decay power (powerDecay). While looking at some downstream test results with these changes, we noticed that the center-most assembly block-wise decay power was not properly accounting for the symmetry factor. After some discussion, we found that it was due to the fact that we were calculating the block-wise decay power from component-level decay power; and the latter was getting calculated without consideration to the symmetry factor.
E.g., we typically calculate block-wise power by doing something like:
b.decayPower = b.decayPowerDensity * b.getVolume()

where b.getVolume() accounts for the symmetry factor. However, a block-wise decay power derived from component-level decay power looks something like:
for c in b:
    c.decayPower = c.decayPowerDensity * c.getVolume()

b.decayPower = sum(c.decayPower for c in b)

where c.getVolume() does not respect the symmetry factor.
So all this said, should c.getVolume() respect the symmetry factor? This could look something like:

@albeanth "decayPower" is not a parameter in ARMI. That sounds like some MCNP value.

should c.getVolume() respect the symmetry factor?

For your situation, it seems like a clear "yes".  But Component.computeVolume() is used in just SO MANY place, so.... can I say for sure, right now, that making the suggested change is correct everywhere? No, I can't say that.
But:

We can just test your idea, and see if a million things break.
EVEN IF a bunch of other things break, we could add a parameter to that method:

def computeVolume(self, respectSymmetry=False):

So, it seems fixable either way.

"decayPower" is not a parameter in ARMI.

It was until #1954. Either way, that's not the important part here.
I agree, component.getVolume() is used an a gazillion places - and is why I wanted to open this Issue first and see what others thoughts were. Just changing it will likely have quite the ripple effect.
We could do the optional param, that would be easy. But if it is indeed a bug, then maybe the optional param isn't the "right" option and really it should just be hardcoded in. That's the part I don't know and wanted to get the opinion of others on.

I'm not sure I agree with a keyword argument here. To me it seems like the multiplicity should be scaled back with the symmetry so that this would be captured on self.getArea(). This seems like it could be a bug in the pin level parameters if we don't account for this in the spatial grid and number of components in the block.

Was adding a test to Block.completeInitialLoading and noticed that the component-wise heavy metal mass here calls out the symmetry factor. So it seems as though someone at some point thought about this.
https://github.com/terrapower/armi/blob/864106e1da0501bee13489c223b950a80906ab25/armi/reactor/blocks.py#L797
If the component volume considered the symmetry factor then the sf factor here wouldn't be needed.

https://github.com/terrapower/armi/pull/1990#discussion_r1847423048
cross referencing here for posterity

Before we can get started on this ticket, I guess what I want is some sort of high level view of all the places this change will impact.
I have (perhaps temporarily) added "complex" as a label to this ticket because my guess is that if we follow Tony's suggestion above and change the default behavior here, this will have far-reaching and hard-to-catch changes in ARMI or downstream.
Of course, if we can itemize all the places this affects and the list is small... great! That's not a problem.  I would love to be wrong.

Was discussing this issue with a teammate yesterday and discovered that there may be other symmetry factor related issues. I think this work could consider expanding to a general audit of the use of symmetry factor throughout ARMI.
See here for some awkward use of the symmetry factor (it gets awkward to keep things consistent).

The number of issues that this central assembly has caused in 1/3 core models is just laughable. Here is at least one, and I know of multiple other internal instances of similar troubles: https://github.com/terrapower/armi/pull/742
At this point I am cautious to believe hardly anything about the central assembly without doing a lot of manual verification.

I've coincidentally been working on something similar due to a downstream bug, see https://github.com/terrapower/armi/pull/2017. I think adding a symmetry scaling check to moves makes the most obvious sense. Core.add uses Assembly.moveTo for placing a newly created assembly in the core, so this accounts for new assembly addition.
Conceptually, I think we'd want to have the assembly parameters populated before placement in the core, then the placement and movement would account for adjustments due to the symmetry factor.

I was just talking with @albeanth about this and he had the idea of baking the symmetry factor into the parameter getters. Noting it here for future reference.

I was just talking with @albeanth about this and he had the idea of baking the symmetry factor into the parameter getters. Noting it here for future reference.

This could a slow operation though. Not sure. The idea was to try and prevent devs from even using the symmetry factor at all. It's a finnicky little thing (at least currently) and looks to be error prone. Exposing it in one place would help this, I think.

Was discussing this issue with a teammate yesterday and discovered that there may be other symmetry factor related issues.

Okay, my current desire before we get started solving this issue is:

Come up with a consistent solution that would make it easy for ARMI devs/users to know when they have to care about symmetry factors.
a. If we can't give people a "include a symmetry factor here" logic, then no solution we come up with will be any more useful to the users/devs than our current situation.
THEN itemize the places that symmetry factor is used now, and where they will also be used based on the change in (1).

I notice a lot of excitement about this ticket, hopefully someone feels like helping with the initial leg work.  :)

This is one of the best comments I've ever come across in ARMI:
https://github.com/terrapower/armi/blob/8b9a693f9bc4030eaa3fbcaa394bb7af74ed10bf/armi/bookkeeping/report/reportingUtils.py#L478-L479

Was adding a test to Block.completeInitialLoading and noticed that the component-wise heavy metal mass here calls out the symmetry factor. So it seems as though someone at some point thought about this.
https://github.com/terrapower/armi/blob/864106e1da0501bee13489c223b950a80906ab25/armi/reactor/blocks.py#L797
If the component volume considered the symmetry factor then the sf factor here wouldn't be needed.

The use of the symmetry factor here does nothing, as the symmetry factor is always 1 when the assembly is created and before it is placed in the core. This can be verified by placing an assert sf==1 somewhere and successfully initializing a test reactor.


Postman: 7.36.1 -> 8.4.0, add libdrm and mesa which were missing (according #111382)

Motivation for this change
Getting latest version of Postman
Things done
Updated version and hashes, tested (failed), added missing libraries and tested successful.

[?] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s) -> Enabled by default so assuming yes

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after) - About 5 MB diff?
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122845 at 72548d64 run on x86_64-linux 1

1 package built successfully:

postman

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/web/postman/default.nix:70:3:
   |
70 |   installPhase = ''
   |   ^


Add option to copy both buffer regions in ediff

When solving merge conflicts with ediff I found myself more than once in a
need of having changes from both conflicting branches to be in final
merge. Sometimes they need refining, but usually parts of the conflicting
region were useful as is. IDK how to achieve that in a standard ediff without
selecting one change and then manually copying the other one.
This commit adds two keybindings to Ediff Control Panel: A and
B. They copy changes from both conflicting regions to the C
buffer. Two keys to allow for specifying order of yanks in a C.

Got it, thanks for the explanation. I feel a tiny bit smarter now. This looks great. Feel free to merge (unless you want additional reviews).


Create interactive instruction dialog

Summary
Make an interactive walk through that displays step by step instructions on how to us pulsebox properly.
Resources
https://getbootstrap.com/docs/4.0/components/modal/

I would love to help you with this project.

Your contribution would be definitely be appreciated however this project is deprectated please refer to pulsetracker this is where the new version of this project has been moved.


KAFKA-3859: Fix describe group command to report valid status when group is empty

With the new consumer, when all consumers of a consumer group are stopped (i.e. the group is empty), the describe consumer group command returns Consumer group ... is rebalancing.
This PR fixes this issue by distinguishing between when the consumer group is actually rebalancing and when it has no active members.

LGTM

@hachikuji Could you please take a look at this when you get a chance? The patch for KAFKA-3853 is kind of related to this, and I'd like this to be finalized and merged first. Thanks.

Closing this PR as a fix was provided as part of the PR for KAFKA-3144.


Request feature for liveness checking for "Client" instance in pulsar-python

Is your feature request related to a problem? Please describe.
In pulsar's python client, after the client instance was created, the instance maintains one or more TCP connections. However, there is no straightforward way to check if these connections are alive.
Describe the solution you'd like
Add a method like "is_open()" to the client class to return the status of existing connections.

@sijie hi, any update of this issue? if not, could you please provide any workaround to check the connection's state?

@codelipenghui hi, any progress?

The issue had no activity for 30 days, mark with Stale label.

Closed as stale. The development of the Python client has been permanently moved to http://github.com/apache/pulsar-client-python. Please open an issue there if it's still relevant.


Introduce Extra Filters for Total Stats on API

Pull Request Test Coverage Report for Build d102ae657e16295e386bbfa7a064c49cef8277b1-PR-222

9 of 16 (56.25%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 66.536%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/athena_web/schema/event/total/resolver.ex
4
7
57.14%

lib/athena_web/schema/location/total/resolver.ex
5
9
55.56%

Totals

Change from base Build b533d7deca9315e5a937d71a91e23c0f1ee28b2f:
0.09%

Covered Lines:
509

Relevant Lines:
765

💛  - Coveralls


how write es6  member?

class Actor {

    /**
     * @constructor Actor
     */
    constructor() {

        /**
         * @member
         */
        this.name = "leo";

    }
}

how write this.name annotate ?

Hey guys - is there an update on whether jsdoc supports ES6 now? I have seen some messages floating around but didn't see anything authoritative.

Officially it looks to be in the low priority list with no planned release date.
https://github.com/kpi-wdc/wdc/issues/97

@mizzao @mattvot On GitHub master, JSDoc currently supports almost all ES2015 features. However, there has not been a formal release that includes ES2015 support, so the version on npm does not include ES2015 support.
JSDoc 3.4.0 will be the first formal release with ES2015 support. I don't have a firm date for that release; there are more changes to land, and my time has been scarce. For now, if you need ES2015 support, I recommend using the development version of JSDoc.

Thanks! Good to know.

@hegemonic which one is the dev one for es6 stuff?

@JerryFox1 GitHub master is the development version.

@hegemonic, is the es6 classes support documented yet? I'm having trouble generating documentation for methods:

/**
 * This is the main App class
 * @class App
 */
class App extends React.Component {
  /**
   * Constructs an instance od App.
   *
   * @param {Props} props - The props.
   * @constructs App
   */
  constructor(props) {
    super(props);
  }

  /**
   * Renders the component
   *
   * @method render
   */
  render() {
  }
}

"render" method does not show up in the docs. I'm on JSDoc 3.4.0-dev.

@mhagmajer You want to specify that the render method is an instance method of App. This should work:
/**
 * This is the main App class
 * @class App
 */
class App extends React.Component {
  /**
   * Constructs an instance od App.
   *
   * @param {Props} props - The props.
   * @constructs App
   */
  constructor(props) {
    super(props);
  }

  /**
   * Renders the component
   *
   * @method App#render
   */
  render() {
  }
}

@tomauty, thanks for replying! Unfortunately this syntax doesn't seem render the method in the docs in JSDoc 3.4.0-dev (Sun, 14 Jun 2015 18:49:07 GMT).

Oh, yeah I'm currently using 3.3.0. Looks like a change in 3.4 broke this functionality...

@hegemonic can you release 3.4 to npm with dev tag, because git is slow.

Exporting a class only after fully defining it seems to solve the problem of getting member functions to render in the output docs, but with 3.4 I haven't found any way to get plain members to render any documentation.


Cardboard VR Split View

Do you know how could I implement a Cardboard VR View ?
It would help to start adding value to any app with the VR split view feature.
Regards!

I'm sorry.
There is no plan to update the feature because I don't know the function in detail.

We could have a meeting and I could show you in a simple way what is needed :) Let me finish my master's degree and some personal projects and I could contribute with a pull request for this in a few months ;)


Scaling of arrowBar

Hi @ivanek,
I really like the Gviz package because of its flexibility. But I stumbled upon a minor problem:
When i am creating high resolution images of my transcript models, the arrow-bar connecting the different exons does not seem to scale at all. So at high resolutions the arrows are nearly invisible.
I found the default values for W, D and min.height in .arrowBar() to be the culprits.
Would it be possible to let the arrows automatically scale with resolution? Or at least to expose the values (W, D and min.height) in the GeneRegionTrack-class so they can easily be adjusted if needed?
Thanks in advance.

Here is how it looks with default values:

Here is how it looks with adjusted values:

I exposed two parameters: arrowFeatherWidth (W) and arrowFeatherDistance (D), min.height was already available. So far only in the GitHub version. I will later push it also to devel version in Bioc.
example setting:
displayPars(grtrack)$arrowFeatherWidth <- 15

Thanks alot, I will try it out soon.