Bulk appeal access revocation

Summary
Guardian does not consider the user status like quit, inactive etc in org/company, there is a possibility that users can switch org while they still have active appeals in the system. These accounts pose a huge security threat. When they grow in number, they also become unmanageable for IT administrators. Hence it is essential to periodically check for inactive user accounts and take appropriate actions on them as soon as they're identified.
Proposed solution
Guardian appeal-approval workflow takes identity providers(IAM) like Shied, Ldap, and HTTP to fetch user details like name, title, manager, department, etc.
As a solution we are proposing the following steps:

Identity providers to have a user status as metadata like accountStatus=active
a scheduled job in Guardian

To fetch all users having active appeals
fetch the status of a user using IAM
revoke appeal access if a user is not active

Additional context
In the future, we want to trace whether a user is idle for more than a configured duration and will mark a user as inactive and revoke its access.

@singhvikash11 Are we expecting that Guardian will expect accountStatus key to be there in identity manager? I think this should be kept flexible and there could be mapping that can de be defined to figure out which key to look for. Thoughts?

@ravisuhag yes, we'll make it flexible. Users can map accountStatus in IAMSchema, for now we are not creating any expression to evaluate the status of user.

@rahmatrhd @singhvikash11 Based on the discussion on the PR. I have a few questions?
Since IAM is registered in policy, the account status config can change based on each policy.

How do we expect the IAM provider to check for it for each policy registered in a generic way?
Would dormant access revocation happen at the policy level?
Will the job check status config for each policy and then revoke access for users?

@ravisuhag IMO, this is as part of the access-request lifecycle in a broader way. Here as a lifecycle of the access request, it filters all the active appeals and kicks-in revocation stage if the user of these appeals becomes inactive based on a policy configured.

Few thoughts:

I think most of the logic should be contained within Job only. We should avoid making changes in core for this apart from introducing status which can be configured in IAM config.
If such actions increase more and more we should think of a way to make jobs generic. On possible way could be. Job can be defined in a yaml config.

action: appeal.revoke
when:
on:

@singhvikash11 just had a thought, for all current policies, they still don't have the account status configured, then how we will revoke active appeals attached to those policies? The same case also for if the iam config got updated due to the contract changes with the identity service.
Seems we can't have this process as part of the policy iam. Agree with @ravisuhag that the logic should be part of the job only.

Update:
Guardian will provide an API to revoke access to all resources for a given user. The decision of the dormant users can be taken outside of Guardian and access can be revoked using the bulk access revocation API.

@rahmatrhd @ravisuhag as we discussed we'll create an API to revoke appeals in bulk based on appeal filter criteria. Please lemme know if the below contract is okay for this Api.

message RevokeAppealsRequest {
string account_id = 1;
repeated string statuses = 2;
repeated string role = 3;
repeated string provider_types = 4;
repeated string provider_urns = 5;
repeated string resource_types = 6;
repeated string resource_urns = 7;
string created_by = 8;
message Reason {
string reason = 1;
}
Reason reason = 9;
}

message RevokeAppealsResponse {
repeated Appeal appeal = 1;
}

rpc RevokeAppeals(RevokeAppealsRequest) returns (RevokeAppealsResponse) {
option (google.api.http) = {
post: "/v1beta1/appeals/revoke"
body: "reason"
};
}


Make ModelExperimental.boundingSphere account for RTC_CENTER

This fixes #10627. The testing sandcastle + data are in that issue.

Thanks for the pull request @j9liu!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@lilleyse did you have any comments on this PR?

Nope, looks good.


feat: EXTRA_CACHING_STRATEGIES

SUMMARY
Superset enables us to run different caching strategies under celery beat.
The ability here is to provide additional strategies from the config that can later be run if the strategy is chosen
In order to use Strategy type like
EXTRA_CACHING_STRATEGIES: List[Type[Strategy]] = []
It was required to split from the single cache.py file into smaller modules in order to avoid importing superset.app

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

hi @amitmiran137  I see this was closed without merge.
I have few questions here.

it calls charts explore url and request lib doesn't load javascript so it doesn’t really gets the data from endpoint which is POST explore_json or POST data which actually loads data into cache.
also this won't generate thumbnail urls.

so should we just invoke headless driver like we do for reports?


Add Sunshine rover from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of kccda, to add Sunshine rover to CKAN.
Mod details:
name = /mod/601/Sunshine%20rover
author = kccda
abstract = Sunshine rover - A rover for all terrains
license = All Rights Reserved
Homepage = http://forum.kerbalspaceprogram.com/index.php?/topic/138239-sunshine-rover/
description =
Website: https://kccda.wordpress.com/
Please direct questions about this pull request to kccda.

Closing for https://github.com/KSP-CKAN/NetKAN/pull/3819


add debug handlers on HTTP based on env var

Adds debug handlers to 8080 port based on env var and adds a release notes for it
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
6e429c6e54cf58b6861fd35f1a5fb83e1ac5b0c5
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sorry, I misunderstood your proposal and was thinking to disable only 8080 conditionally. Now I have disabled adding them based on env var for both Http ports.
I think we should the following

Move readiness to 15014 (or new port) because 15014 any way needs to be exposed outside
Remove debug from 15014 and we can move 8080 to <IP_ADDRESS> if we want to retain Debug on Http and control it with this env var till we get this from Xds over TLS

@costinm can you PTAL at this?

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-telemetry-k8s-tests_istio

lint_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-telemetry-k8s-tests_istio

lint_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test lint_istio

integ-security-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-telemetry-k8s-tests_istio

lint_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test lint_istio

integ-security-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-telemetry-k8s-tests_istio

lint_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test lint_istio

integ-security-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-telemetry-k8s-tests_istio

lint_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test lint_istio

integ-security-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test unit-tests_istio

release-test_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test release-test_istio

gencheck_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test gencheck_istio

integ-operator-controller-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-telemetry-k8s-tests_istio

lint_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test lint_istio

integ-security-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-pilot-k8s-tests_istio

analyze-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
187c73a1a175c32e7ebb49a03cb27ea380d2b522
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm Can you please take a look when you get chance?


Does it support picture plus music composite video?

I'm sorry to bother.
As the title,I expect to use a picture and a music video composite a new video.

https://github.com/PHP-FFMpeg/PHP-FFMpeg#advancedmedia


Stringnames matching member variables get replaced by null by the compiler

Operating system or device - Godot version:
Mageia 6 x64, Godot master HEAD (8ee2018)
Issue description (what happened, and what was expected):
I've discovered and bisected that since commit 2e5a4cb, my game DynaDungeons no longer works as expected due to supernatural substitutions of valid strings by Nil.
I have strictly no clue how a change to InputEvent would break my singleton like this, but reverting it does fix the bug. CC @volzhs.
This trimmed-down test shows an example of the bug: http://hastebin.com/ofazepakoc.coffee
Steps to reproduce:
git clone https://github.com/akien-mga/dynadungeons
cd dynadungeons
godot -e
// Press run, see the debugger yelling at you
// Check the value for the `width` variable: it's empty!
// try to `print("width")` before the problematic call in `global.gd`: it prints an empty string

I wasn't yet able to make a minimal reproducer, the issue appears to be a bit non-deterministic.

The first problematic call: https://github.com/akien-mga/dynadungeons/blob/master/scripts/global.gd#L104
I do handle InputEvents later on in this function, but not sure why it would trigger such a weird bug.

Alright, found the bug.


Added simple .read function to return the contents of a file as a string

I have added a simple function that returns the contents of a file as a string - used in a browser based editor accessing files via webdav
usage:
file_content = webdav.read(path)

Closing this request - figured out you can use a virtual file
import cStringIO
virtual_file = cStringIO.StringIO()
webdav.download(path,virtual_file)
file_content = virtual_file.getvalue()


cdc: e2e verification, cli

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/4550
fix https://github.com/pingcap/tiflow/issues/4934
What is changed and how it works?
suggest review c5c0408 (#5032)
Check List
Tests

Unit test

Code changes

Has exported function/method change

Side effects

Increased code complexity

Related changes
Release note
 `None`.

/run-all-tests

/run-all-tests

/run-all-tests

/run-kafka-integration-test


THRIFT-5109: Misc CMake build improvements

Patch: Mario Emmenlauer
This closes #2026
This closes #2025
This closes #2021

[x] https://issues.apache.org/jira/browse/THRIFT-5109
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

Moving towards one build system (cmake) is a great effort, it's nice to see this happening in some capacity.  Unfortunately when builds break... merging is hard. :)

Unfortunately when builds break... merging is hard. :)

Haha yes! I was actually hoping you could help with the Gruntfile?
The "problem" now is not that the CMake build itself would be broken. The problem is that the Javascript build in autotools was not used on MSVC before, whereas in CMake I have now enabled Javascript on MSVC. And it fails, probably never worked.
This could and should be split off into a separate issue, unless you (or someone else) could fix the Javascript build?

The rest of this PR should be fine and should have worked from the start. The failing Javascript could just be disabled on AppVeyor.

I was going to suggest the same thing, but was distracted and didn't get back to it.
Since JS issue is unrelated to cmake (the issue is that JS can't be compiled on windows), one solution is to disable JS build on windows, and make another issue for JS.

I've found a small improvement where the Javascript target actually depends on the target that copies the compiler into the source tree, not on the build of the compiler. This ensures that if the compiler is not built, it will still be copied.
If the CI is now successful, this should be ready for review / merge.

There seems to be an unrelated issue in https://travis-ci.org/github/apache/thrift/jobs/677163097. Should I re-trigger the builds and tests?

Re-triggered build with a rebase on latest master, to fix random error in Travis CI.

:-( Another random error in the CI. Can this be merged anyways?

Ready for review.

@janosvitok comments from your side?


Update hdinsight.md

Please merge before April 15th.

Docs Build status updates of commit 612d33e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 81: [Error] W:\dlxj-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\plugin.executor.ps1 failed to execute customized script in the plugin step docset_prebuild in the docset azuredotnet
Line 138: [Error] W:\dlxj-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\docset.prebuild.ps1 failed to execute
Line 215: [Error] Error happened to execute the task _dependentPackages/ECMA2Yaml/tools/Run.ps1
Line 80: [Warning] Failed to run script W:\dlxj-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -2146232576

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 612d33e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 81: [Error] W:\k0ev-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\plugin.executor.ps1 failed to execute customized script in the plugin step docset_prebuild in the docset azuredotnet
Line 138: [Error] W:\k0ev-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\docset.prebuild.ps1 failed to execute
Line 215: [Error] Error happened to execute the task _dependentPackages/ECMA2Yaml/tools/Run.ps1
Line 80: [Warning] Failed to run script W:\k0ev-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -2146232576

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3112570:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 81: [Error] W:\rfzt-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\plugin.executor.ps1 failed to execute customized script in the plugin step docset_prebuild in the docset azuredotnet
Line 138: [Error] W:\rfzt-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\docset.prebuild.ps1 failed to execute
Line 215: [Error] Error happened to execute the task _dependentPackages/ECMA2Yaml/tools/Run.ps1
Line 80: [Warning] Failed to run script W:\rfzt-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -2146232576

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9401c17:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 81: [Error] W:\dgpm-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\plugin.executor.ps1 failed to execute customized script in the plugin step docset_prebuild in the docset azuredotnet
Line 138: [Error] W:\dgpm-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\docset.prebuild.ps1 failed to execute
Line 215: [Error] Error happened to execute the task _dependentPackages/ECMA2Yaml/tools/Run.ps1
Line 80: [Warning] Failed to run script W:\dgpm-s_dependentPackages\ECMA2Yaml\tools\Run.ps1 with exit code -2146232576

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9401c17:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

:x:Error

Details

[Error] YamlDotNet.Core.YamlException: (Line: 1, Col: 1, Idx: 0) - (Line: 102, Col: 4, Idx: 3419): Exception during deserialization ---> System.InvalidCastException: Invalid cast from 'System.String' to 'System.Collections.Generic.Dictionary2[[System.String, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Object, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089]]'. at System.Convert.DefaultToType(IConvertible value, Type targetType, IFormatProvider provider) at System.String.System.IConvertible.ToType(Type type, IFormatProvider provider) at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider) at YamlDotNet.Serialization.Utilities.TypeConverter.ChangeType(Object value, Type destinationType, CultureInfo culture) at YamlDotNet.Serialization.Utilities.TypeConverter.ChangeType(Object value, Type destinationType) at YamlDotNet.Serialization.NodeDeserializers.ScalarNodeDeserializer.YamlDotNet.Serialization.INodeDeserializer.Deserialize(IParser parser, Type expectedType, Func3 nestedObjectDeserializer, Object& value)
at YamlDotNet.Serialization.ValueDeserializers.NodeValueDeserializer.DeserializeValue(IParser parser, Type expectedType, SerializerState state, IValueDeserializer nestedObjectDeserializer)
--- End of inner exception stack trace ---
at YamlDotNet.Serialization.ValueDeserializers.NodeValueDeserializer.DeserializeValue(IParser parser, Type expectedType, SerializerState state, IValueDeserializer nestedObjectDeserializer)
at Microsoft.DocAsCode.YamlSerialization.YamlDeserializer.LooseAliasValueDeserializer.DeserializeValue(IParser reader, Type expectedType, SerializerState state, IValueDeserializer nestedObjectDeserializer)
at Microsoft.DocAsCode.YamlSerialization.YamlDeserializer.Deserialize(IParser parser, Type type, IValueDeserializer deserializer)
at Microsoft.DocAsCode.YamlSerialization.YamlDeserializer.Deserialize[T](TextReader input, IValueDeserializer deserializer)
at JoinTOC.TOCMerger.AlterYamlHeader(String path, Action`1 handler)
at JoinTOC.TOCMerger.HandleConceptualNode(TocItemViewModel tocItem, String tocFilePath)
at JoinTOC.TOCMerger.Merge(CommandLineOptions opt)
at JoinTOC.Program.Main(String[] args)
Line 81: [Error] W:\tjot-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\plugin.executor.ps1 failed to execute customized script in the plugin step docset_prebuild in the docset azuredotnet
Line 138: [Error] W:\tjot-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\docset.prebuild.ps1 failed to execute
Line 215: [Error] Error happened to execute the task _dependentPackages/CommonPlugins/tools/JoinTOC.ps1
Line 80: [Warning] Failed to run script W:\tjot-s_dependentPackages\CommonPlugins\tools\JoinTOC.ps1 with exit code -1

[Error] YamlDotNet.Core.YamlException: (Line: 1, Col: 1, Idx: 0) - (Line: 102, Col: 4, Idx: 3419): Exception during deserialization ---> System.InvalidCastException: Invalid cast from 'System.String' to 'System.Collections.Generic.Dictionary2[[System.String, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Object, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089]]'. at System.Convert.DefaultToType(IConvertible value, Type targetType, IFormatProvider provider) at System.String.System.IConvertible.ToType(Type type, IFormatProvider provider) at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider) at YamlDotNet.Serialization.Utilities.TypeConverter.ChangeType(Object value, Type destinationType, CultureInfo culture) at YamlDotNet.Serialization.Utilities.TypeConverter.ChangeType(Object value, Type destinationType) at YamlDotNet.Serialization.NodeDeserializers.ScalarNodeDeserializer.YamlDotNet.Serialization.INodeDeserializer.Deserialize(IParser parser, Type expectedType, Func3 nestedObjectDeserializer, Object& value)
at YamlDotNet.Serialization.ValueDeserializers.NodeValueDeserializer.DeserializeValue(IParser parser, Type expectedType, SerializerState state, IValueDeserializer nestedObjectDeserializer)
--- End of inner exception stack trace ---
at YamlDotNet.Serialization.ValueDeserializers.NodeValueDeserializer.DeserializeValue(IParser parser, Type expectedType, SerializerState state, IValueDeserializer nestedObjectDeserializer)
at Microsoft.DocAsCode.YamlSerialization.YamlDeserializer.LooseAliasValueDeserializer.DeserializeValue(IParser reader, Type expectedType, SerializerState state, IValueDeserializer nestedObjectDeserializer)
at Microsoft.DocAsCode.YamlSerialization.YamlDeserializer.Deserialize(IParser parser, Type type, IValueDeserializer deserializer)
at Microsoft.DocAsCode.YamlSerialization.YamlDeserializer.Deserialize[T](TextReader input, IValueDeserializer deserializer)
at JoinTOC.TOCMerger.AlterYamlHeader(String path, Action`1 handler)
at JoinTOC.TOCMerger.HandleConceptualNode(TocItemViewModel tocItem, String tocFilePath)
at JoinTOC.TOCMerger.Merge(CommandLineOptions opt)
at JoinTOC.Program.Main(String[] args)
Line 81: [Error] W:\tjot-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\plugin.executor.ps1 failed to execute customized script in the plugin step docset_prebuild in the docset azuredotnet
Line 138: [Error] W:\tjot-s.optemp\packages\opbuild.scripts.1.72.0\tools\opbuild\docset.prebuild.ps1 failed to execute
Line 215: [Error] Error happened to execute the task _dependentPackages/CommonPlugins/tools/JoinTOC.ps1
Line 80: [Warning] Failed to run script W:\tjot-s_dependentPackages\CommonPlugins\tools\JoinTOC.ps1 with exit code -1

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@tylerfox in your .md file there are an extra pair of "---" in the lower part of the content, which will cause confusion in OPS Build because anything between a pair of "---" is considered yaml header. This is why your PR validation is failing. Could you please remove  extra pair of "---" lines?

@tylerfox in your .md file there are an extra pair of "---" in the lower part of the content, which will cause confusion in OPS Build because anything between a pair of "---" is considered yaml header. This is why your PR validation is failing. Could you please remove extra pair of "---" lines?

Oh I see, thanks! I was just trying to add a horizontal line, but that makes sense. Removed.

Docs Build status updates of commit b90b6f0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/hdinsight.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@TianqiZhang can you please merge this now?

Docs Build status updates of commit 2c3ae7c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/hdinsight.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Expo build crashes on both ios and android when using stripe-react-native

Describe the bug
App crashes on IOS emulator after app icon clicked (after I remove all stripe-react-native related imports, the app works fine).
On Android emulator, it crashes when the method 'createToken' is called.
Have not tested it on real devices yet, but the app is working perfectly on Expo Go(Android Expo Go still crashes when calling creatToken).
To Reproduce
Steps to reproduce the behavior:
Here's the code to reproduce the bug:
import React, { useState, useEffect } from "react";
import { View, TextInput } from "react-native";
import Button from "./Button";

import {
  CardField,
  initStripe,
  createToken,
} from "@stripe/stripe-react-native";

const StripePaymentForm = () => {

  useEffect(() => {
    async function fetchPublishableKey() {
      initStripe({
        publishableKey: 'your publishable key here',
      });
    }

    fetchPublishableKey();
  }, []);

  const handleBtnPress = async () => {
    const res = await createToken(); // Android build crashes in this step
  };

  return (
    <View>
      <CardField
        postalCodeEnabled={true}
        placeholder={{
          number: "4242 4242 4242 4242",
        }}
        cardStyle={{
          backgroundColor: "#FFFFFF",
          textColor: "#000000",
          borderWidth: 1,
          borderRadius: 6,
          borderColor: "black",
        }}
        style={{
          width: "100%",
          height: 50,
          marginVertical: 15,
        }}
      />
      <Button
        title="Create Token"
        onPress={handleBtnPress}
      />
    </View>
  );
};

export default StripePaymentForm;

Expected behavior
On IOS the app should not crash on splash screen.
On Android, the createToken method should not cause the app to crash.
Desktop (please complete the following information):

OS: Windows 10 and Mac Big Sur

Smartphone (please complete the following information):

Device: IPhone 12 emulator, Pixel 3a emulator
OS: IOS14 and Android 11

Additional context
stripe-react-native version:  "@stripe/stripe-react-native": "^0.1.4",
Please let me know what kind of extra information you need from me in order to debug, thanks!

On Android, the createToken method should not cause the app to crash.
This might be https://github.com/stripe/stripe-react-native/issues/405

On Android, the createToken method should not cause the app to crash.

This might be https://github.com/stripe/stripe-react-native/issues/405

Thanks for the reply, any idea why the iOS build crashes when opening up the app?

https://github.com/stripe/stripe-react-native/issues/405#issuecomment-886386464

@ruida-shen

Thanks for the reply, any idea why the iOS build crashes when opening up the app?

can you provide some error message to help us with debugging?

@ruida-shen

Thanks for the reply, any idea why the iOS build crashes when opening up the app?

can you provide some error message to help us with debugging?

Hi, So the behavior of this bug on IOS is that, if my app has imports of the stripe-react-native module, it will crash when app opens up in ios emulator, but if I remove all stripe-react-native imports, the app works fine, also the app is working fine with the stripe-react-native module in Expo Go, too.
Here is the system log of my ios emulator:

Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: objc[72443]: Class CSAudioFileManager is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/SpeakerRecognition.framework/SpeakerRecognition (0x14a01d288) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/CoreSpeech.framework/CoreSpeech (0x148dffa08). One of the two will be used. Which one is undefined.
Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: objc[72443]: Class CSNNVADEndpointAnalyzer is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/SpeakerRecognition.framework/SpeakerRecognition (0x14a01dcd8) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/CoreSpeech.framework/CoreSpeech (0x148dfff58). One of the two will be used. Which one is undefined.
Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: objc[72443]: Class CSAudioRecordContext is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/SpeakerRecognition.framework/SpeakerRecognition (0x14a01dd28) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/CoreSpeech.framework/CoreSpeech (0x148e00048). One of the two will be used. Which one is undefined.
Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: objc[72443]: Class CSSelectiveChannelAudioFileWriter is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/SpeakerRecognition.framework/SpeakerRecognition (0x14a01df08) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/CoreSpeech.framework/CoreSpeech (0x148e00228). One of the two will be used. Which one is undefined.
Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: objc[72443]: Class CSPlainAudioFileWriter is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/SpeakerRecognition.framework/SpeakerRecognition (0x14a01d1e8) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/CoreSpeech.framework/CoreSpeech (0x148e00958). One of the two will be used. Which one is undefined.
Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: objc[72443]: Class CSRemoteRecordClient is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/SpeakerRecognition.framework/SpeakerRecognition (0x14a01d788) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/CoreSpeech.framework/CoreSpeech (0x148e01a38). One of the two will be used. Which one is undefined.
Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: objc[72443]: Class CSServerEndpointFeatures is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/SpeakerRecognition.framework/SpeakerRecognition (0x14a01da08) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/CoreSpeech.framework/CoreSpeech (0x148e020c8). One of the two will be used. Which one is undefined.
Jul 26 14:08:50 Ruidas-MacBook-Pro ComFanrallyApp[72443]: assertion failed: 20F71 18E182: libxpc.dylib + 50305 [454053CA-B690-3B99-BE31-2369B04EA493]: 0x7d
Jul 26 14:08:51 Ruidas-MacBook-Pro com.apple.CoreSimulator.SimDevice.AD408E73-DAC5-44C4-A1E7-5A7F5C61E1AD[69552] (UIKitApplication:com.fanrally.app[481f][rb-legacy][72443]): Service exited due to SIGABRT

Please tell me what additional logs I can provide to help.

I get the same issue. I've narrowed it down to just importing StripeProvider.
import { StripeProvider } from "@stripe/stripe-react-native"
Adding this line to my app makes it crash on splash screen when testing on device. Does not happen in the iOS simulator or native Android device.
Last Exception Backtrace:
0   CoreFoundation                	0x1912a65b4 __exceptionPreprocess + 220 (NSException.m:199)
1   libobjc.A.dylib               	0x1a5d257a8 objc_exception_throw + 60 (objc-exception.mm:565)
2   <appname>                      	0x100ca923c 0x100a74000 + 2314812
3   <appname>                      	           	0x100cc9a48 handleFatalReactError_block_invoke_2 + 520 (EXReactAppExceptionHandler.m:26)
4   libdispatch.dylib             	0x190e937ec _dispatch_client_callout + 20 (object.m:559)
5   libdispatch.dylib             	0x190ea29bc _dispatch_async_and_wait_invoke + 96 (queue.c:1545)
6   libdispatch.dylib             	0x190e937ec _dispatch_client_callout + 20 (object.m:559)
7   libdispatch.dylib             	0x190ea1c40 _dispatch_main_queue_callback_4CF + 884 (inline_internal.h:2557)
8   CoreFoundation                	0x1912201f8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16 (CFRunLoop.c:1790)
9   CoreFoundation                	0x19121a0d0 __CFRunLoopRun + 2524 (CFRunLoop.c:3118)
10  CoreFoundation                	0x1912191c0 CFRunLoopRunSpecific + 600 (CFRunLoop.c:3242)
11  GraphicsServices              	0x1a8801734 GSEventRunModal + 164 (GSEvent.c:2259)
12  UIKitCore                     	0x193c877e4 -[UIApplication _run] + 1072 (UIApplication.m:3269)
13  UIKitCore                     	0x193c8d054 UIApplicationMain + 168 (UIApplication.m:4740)
14  <appname>                      	0x100a78db8 main + 88 (main.m:8)
15  libdyld.dylib                 	0x190ed5cf8 start + 4

Here is the error from the device using the Apple Console
*** Terminating app due to uncaught exception 'ExpoFatalError', reason: 'Expo encountered a fatal error: Unhandled JS Exception: Invariant Violation: Native module cannot be null.'
*** First throw call stack:
(0x1912a65b4 0x1a5d257a8 0x10423d23c 0x10425da48 0x190e937ec 0x190ea29bc 0x190e937ec 0x190ea1c40 0x1912201f8 0x19121a0d0 0x1912191c0 0x1a8801734 0x193c877e4 0x193c8d054 0x10400cdb8 0x190ed5cf8)

What could be the cultprit of this? I am running on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

App crashes after installing stripe-react-native sdk with error "java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/gms/common/internal/zzbq;". After removing the SDK the app runs fine.

@purplecones Each Expo SDK version requires a specific stripe-react-native version. See the CHANGELOG for a mapping of versions. To install the correct version for your Expo SDK version run:
expo install @stripe/stripe-react-native

I am not using EXpo

@purplecones @ruida-shen does installing the proper stripe-react-native version (for your version of Expo) fix the crash for you?
@vivekmahato26 your error seems to be a different one, not connected with the crash explained in this issue.
If you still having this problem can you please create a separate issues with reproduction steps and information about the environment you have (is this a fresh RN app, what RN version, etc.)

@purplecones @ruida-shen does installing the proper stripe-react-native version (for your version of Expo) fix the crash for you?
@vivekmahato26 your error seems to be a different one, not connected with the crash explained in this issue.
If you still having this problem can you please create a separate issues with reproduction steps and information about the environment you have (is this a fresh RN app, what RN version, etc.)

Hi, that doesn't help unfortunately. But doesn't expo 42.0.0 supports react-native-stripe 0.1.4 out of the box?

@ruida-shen if you are on expo 42 than 0.1.4 version of react-native-stripe should be the right version for you.
If you use the correct version than I will have to investigate this issue more and try to reproduce it. Are you on a fresh expo 42 app?

@ruida-shen if you are on expo 42 than 0.1.4 version of react-native-stripe should be the right version for you.
If you use the correct version than I will have to investigate this issue more and try to reproduce it. Are you on a fresh expo 42 app?

I recently upgraded my app from expo 41 to 42, and react-native-stripe from 0.1.1 to 0.1.4.

Was it working properly on 41 (with stripe 0.1.1)?

Was it working properly on 41 (with stripe 0.1.1)?

No, it wasn't working either, I was hoping upgrading to 0.1.4 will solve the issue, but unfortunately this is not the case.

One last question @ruida-shen. Are you using bare or managed workflow in expo?
I'm trying to reproduce the issue. I created a new expo app (expo 42), I installed stripe with expo install @stripe/stripe-react-native, imported StripeProvider and used it in App.tsx. After that when opening the app everything works correctly for me, is there something I'm missing here?
Maybe you are able to reproduce the issue on a fresh expo app.

One last question @ruida-shen. Are you using bare or managed workflow in expo?
I'm trying to reproduce the issue. I created a new expo app (expo 42), I installed stripe with expo install @stripe/stripe-react-native, imported StripeProvider and used it in App.tsx. After that when opening the app everything works correctly for me, is there something I'm missing here?
Maybe you are able to reproduce the issue on a fresh expo app.

I am using managed workflow. The app only crashes in standalone build, so after running the command expo build:iOS, and choose emulator. Then, after the build is done, download it and install it in iOS emulator, the app crashes

Same issue here. Using expo to run the app on a physical device. Works fine on my i phone but crashes on my android. If I remove the  it works again on andrroid.

@ruida-shen Expo doesn't support @stripe/stripe-react-native with expo build. See the documentation here - https://docs.expo.dev/versions/latest/sdk/stripe/#standalone-apps
If you need a standalone iOS build please use EAS build. Remember to configure the stripe plugin correctly - https://docs.expo.dev/versions/latest/sdk/stripe/#config-plugin-setup-optional
@crosshat yours issue seems to be a different one. Can you please share the way you build the expo ap, error you see and expo and stripe versions? You can create a different issue for that

@souhe I fixed the issue. In my case if I use <StripeProvider> in the render it worked fine on IOS and crashed the app on Android. So instead of using <StripeProvider> in the render I imported the initStripe() method and initilized it in my useEffect hook. useEffect(() => {         setIdealBank('abn_amro');         initStripe({             publishableKey,             merchantIdentifier: 'merchant.com.stripe.react.native',             urlScheme: 'https://mywebsite.com',             setUrlSchemeOnAndroid: true,         });     }, []);
This works fine on both Android and IOS. But injecting it in the render using <StripeProvide> with attributes still doesn't work. So I am avoiding it for now.

I assume that everything is clear and works as expected. @crosshat feel free to create another issue if you have any problem.

What's stopping Expo from supporting expo build? eas build is much slower for me


[Android] Support controls property

As seen in #119, but for Android.

Any progress on this?

Waiting for native controls for android.


Update installation.rst

Added a couple clarifying sentences at start of general instructions for non-developers.

What about something like that below. Right now we don't explain here how to setup a fork etc., so the reason for using SSH for development is more later on. But this explains the different options for users less familiar with GitHub. Technically, you can really use either approach and everyone will have their preference. We should add this to the develop branch too as I want to keep the user guide consistent. To make it more seamless, Louisa you could push this first to develop and then from develop to main.
@zmoon @lkemmons
The instructions below are for cloning a repository using SSH, which is recommended, but requires adding an SSH key on your current machine. If you prefer, you can also clone the monet, monetio, and MELODIES-MONET repositories using HTTPS [#clone]_.

There was a lot of confusion at NCAR during the practice tutorial because people did not see the footnote. We could condense it even more.

condense?

The instructions below are for cloning a repository using SSH. If you prefer, you can also clone the monet, monetio, and MELODIES-MONET repositories using HTTPS [#clone]_.

Yes that works. I like the important one. Let's add that to the develop and main branches.

Looks great!  Thanks!
On Thu, Mar 10, 2022 at 9:43 AM rschwant @.***> wrote:

Yes that works. I like the important one. Let's add that to the develop
and main branches.
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-CSL/MELODIES-MONET/pull/76#issuecomment-1064271705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH5BH7MJSFVARADENHZEI6LU7IRCRANCNFSM5QLB2T2Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

In favor of #77


Install django-stubs when running static type checks.

django-stubs requires python 3.10+ because of the use of | operator on types instead of Union. I don't understand why 3.8 and 3.9 are listed as supported?? Kick this particular can down the road.


Report redesign

I'm curious how committed you are to the current report design?
Here's what I'm considering. I am not familiar with echarts (except maybe once 10 years ago), but I read a bit of docs just now.

Have a separate chart per metric (data type). This reduces noise when observing a single metric.
Connect the charts to a group to synchronize them (docs: https://echarts.apache.org/en/api.html#echarts.connect)
Add dataZoom option, this will allow the user to zoom in and out of the data which removes the need for multiple level/charts of data aggregation (docs: https://echarts.apache.org/en/option.html#dataZoom)
Data zoom example: https://echarts.apache.org/examples/en/editor.html?c=area-simple
This seems to use 20,000 data points (one per day).

Still allowing the user to zoom doesn't meant we can just show all the raw data. 10s or 100s of thousands of data points (1 year for example) probably would be too much so we'd still want to do some kinda aggregation.
I guess the easiest option would be to pick a 'safe' data point count, say 5000, and keep the existing report types (single day/month/year) but allow the reports to include as much data as possible up until the set limit.
Another option would be rework the report params to just take an arbitrary date range -start <date> -end <date> and divide it up by max data points, say 5000 (or min of 5min) and aggregate the data to that level. This is more flexible since you could then ask for say the last 3 months. And you could even maintain the existing commands as aliases "month" gets converted to 30days ago until now, etc.

I don't find the current charts very useful so if you want to take a stab at replacing them or making them more informative, I'm on board.


Add ability to chat with ChatGPT using mic (speech-to-text)

This PR adds a speech-to-text using Openai's whisper model https://openai.com/research/whisper.
Audio is recorded for a specified duration, which is then transcribed into text using Whisper. This text can be forwarded to ChatGPT for a response. Additionally, ChatGPT's responses can be audibly relayed back to the user through the 'Say' task.
Improvements:

[ ] Add a root level purpose which listens to audio stream and starts recording if voice is detected (volume level maybe) and records until voice stops

1 comment, otherwise it seems that most of the code is copied and pasted somewhere and since it works and is well documented,LGTM
Also, just curious if some files are copied from somewhere?

All the functionality to interact with Openai's API is dealt with using implementation provided by https://github.com/olrea/openai-cpp

It seems like the improvement can be put in another PR after this PR is merged


SQL Server Browser and default instances note

Hello team! I believe we need to add a quick note on this documentation about the SQL Server Browser and default instances, I mean, for default instances SQL Server Browser will always try to discover the instance using the port 1433 if no port is informed in the client connection string. I had more than two customer's with a misunderstanding on this, they were thinking that SQL Server Browser also perform port resolution for default instances when no port was informed on the connection string.

@andrecrms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@VanMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Made changes and approved. Thanks for bringing up this issue, @andrecrms!
#sign-off

@VanMSFT: I'm sorry - only the author of this article, @markingmyname, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


some tweak

Didn't pick the css transition on .process because it wouldn't render the connections properly.
Will have to look into that later, it was quite neat.


Unknown error: eldest called on user with existing eldest KID

Installed Keybase for the first time, made a typo in the device name, and figured there was a method to rename. Ended up deleting the device and locking myself out.
"There was an error provisioning

Unknown error: eldest call on user with existing eldest KID"

From reading other issues, it sounds like I need an account reset. My apologies.

keybase username?

iodeslykos

ok, reset


AuthorizationState:unauthorized validationResult:StatesDoNotMatch

Dear,
I was able to implement openid but i have two questions :
1/First time if i try to access angular page without login, i see home page, and 1 seconde after, i see unauthorized page.
2/If i login and then attempt to access angular home page, i see home page, then 1/2 sec after unauthorized page ,and then i m redirecting to home page.
Is it possible to avoid those redirect mecanism ?
When i see traces : i see :
Auth result received AuthorizationState:unauthorized validationResult:StatesDoNotMatch
VM1384:1 XHR finished loading: OPTIONS "https://localhost:44318/connect/userinfo".
Auth result received AuthorizationState:authorized validationResult:Ok
Auth result received AuthorizationState:authorized validationResult:Ok
Thanks and best regards,

I fixed it by removing hash # in route


in operator can be used in list and dicts, not just lists

According to this : https://github.com/dmitrii-eremin/python-lua/blob/5e61488e9552e2ba182480a8a0710fa3715430ab/pythonlua/luainit.lua#L388
It only checks if it's a list, but you could use in in python even for hashtables, then you would need in lua just to do
if dict[key] then

python code being
if key in dict

thats smart! u should try making a pr.


[docs] Update the README

[x] I have followed (at least) the PR section of the contributing guide.

Adapting the README with what I found relevant for Base UI specifically. Will comment on some things in particular.

I have no idea why those checks are failing 🤔


Error that happened out of nowhere

Microsoft PowerToys version
0.77.0
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
The error happened out of nowhere.
Here's the Log:

Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19045.0
IntPtr Length: 8
x64: True
Date: 17/01/2024 17:07:19
Exception:
System.Runtime.InteropServices.COMException (0x80263001): {Desktop composition is disabled} The operation could not be completed because desktop composition is disabled. (0x80263001)
   at Standard.NativeMethods.DwmExtendFrameIntoClientArea(IntPtr hwnd, MARGINS& pMarInset)
   at System.Windows.Shell.WindowChromeWorker._ExtendGlassFrame()
   at System.Windows.Shell.WindowChromeWorker._UpdateFrameState(Boolean force)
   at System.Windows.Shell.WindowChromeWorker._HandleDwmCompositionChanged(WM uMsg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Shell.WindowChromeWorker._WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

/dup #30507


Plans to support 2.* version of Microsoft.Extensions.Logging library

I have an issue when using a 3rd party library that references IdentityModel.OidcClient 2.7+, since my WPF app (.Net 4.7.2) has other dependencies that rely on Microsoft.Extensions.Logging 2.1.1.
When do you plan to add support to Microsoft.Extensions.Logging 2.1.1 ?
Snippet from "IdentityModel.OidcClient2/src/IdentityModel.OidcClient/IdentityModel.OidcClient.csproj"
  <ItemGroup Condition=" '$(TargetFramework)' == 'net452' ">     <PackageReference Include="Microsoft.Extensions.Logging" Version="1.1.2" />   </ItemGroup>
Or can you provide an alternative?

Well - that would be a breaking change since it breaks everyone on 1.x
What's the issue? are there breaking changes in logging between 1 and 2?

yes - we will drop netstandard1.x and net45x on v3


Update dependencies and use app router

[x] I have read and agree to the Code of Conduct, and have followed the Contributing guidelines.

Pull Request Type

[x] Other

Summary
I've updated next and all relevant dependencies. Also used app router and improved the project structure a little bit.

I will try to make some time this weekend to check the changes

@masterHAWK99 there are some conflicts, could you fix them? I would like to merge this PR next week

I checked the changes and I get some warnings in the console

@eduardconstantin Sorry for the delay in my response. I managed to fix those warnings and also updated Next to the latest version.
I was unable to reproduce the bug where the answer remains selected after reveal. My suggestion would be to create an issue for that, as I don't believe this PR introduced that behavior and it is already quite extensive.

@masterHAWK99 no worries! I checked the changes and everything looks great. Whatever you did seem to have fixed the issue in the practice mode.


⚠ Jenkins Plugins Artifactory has degraded performance

In ca24471, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1148 ms

Resolved: Jenkins Plugins Artifactory performance has improved in c98f8a8 after 12 minutes.


 If it's a player & that player is interacting with us, identify them as the PKer. If it's an NPC & that NPC is interacting with us, assume no PK took place. Otherwise, fall back to the old player loop.
Add embeds of the top 3 most valuable items that were lost on death to the notification body
Refactor: move some logic out of handleNotify to subroutines

Tested very simple PVP deaths with this version
One skulled with items
    extra: {
      "valueLost": 1575,
      "isPvp": true,
      "pker": "IronGempir",
      "keptItems": [],
      "lostItems": [
        {
          "id": 579,
          "quantity": 1,
          "priceEach": 620,
          "name": "Blue wizard hat"
        },
        {
          "id": 379,
          "quantity": 5,
          "priceEach": 191,
          "name": "Lobster"
        }
      ]
    }
    playerName: "pajdonk"
    message: "pajdonk has just been PKed by IronGempir for 1575 gp..."

One skulled with no items
    extra: {
      "valueLost": 0,
      "isPvp": true,
      "pker": "IronGempir",
      "keptItems": [],
      "lostItems": []
    }
    playerName: "pajdonk"
    message: "pajdonk has just been PKed by IronGempir for 0 gp..."

One PVE death with few items
    extra: {
      "valueLost": 0,
      "isPvp": false,
      "keptItems": [
        {
          "id": 13660,
          "quantity": 1,
          "priceEach": 0,
          "name": "Chronicle"
        }
      ],
      "lostItems": []
    }
    playerName: "pajdonk"
    message: "pajdonk has died..."

One PVE death with many items. I actually kept my chronicle but the plugin thought I lost it, I guess the "what items you lose" isn't as easy as what has the highest value
    extra: {
      "valueLost": 15,
      "isPvp": false,
      "keptItems": [
        {
          "id": 1947,
          "quantity": 1,
          "priceEach": 22,
          "name": "Grain"
        },
        {
          "id": 1947,
          "quantity": 1,
          "priceEach": 22,
          "name": "Grain"
        },
        {
          "id": 556,
          "quantity": 1,
          "priceEach": 5,
          "name": "Air rune"
        }
      ],
      "lostItems": [
        {
          "id": 559,
          "quantity": 1,
          "priceEach": 5,
          "name": "Body rune"
        },
        {
          "id": 555,
          "quantity": 1,
          "priceEach": 4,
          "name": "Water rune"
        },
        {
          "id": 557,
          "quantity": 1,
          "priceEach": 4,
          "name": "Earth rune"
        }
      ]
    }
    playerName: "pajdonk"
    message: "pajdonk has died..."

As a conclusion, I'm OK with this state of the PR since it doesn't crash in PVP deaths with zero items

As a conclusion, I'm OK with this state of the PR since it doesn't crash in PVP deaths with zero items

Agree; there's more edge cases / refactoring to be done - but will leave for another PR


[Ballerina central] undefined package 'googlecalendar'

Description:
In nipuna/gcalendar3 docs it asks to import wso2/googlecalendar. But there is no package found as wso2/googlecalendar in ballerina central.
Affected Product Version: 0.975

Typo is fixed and ballerina central is updated now

Thanks
On 11 July 2018 at 12:07, Nipuna Ransinghe<EMAIL_ADDRESS>wrote:

Typo is fixed and ballerina central is updated now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ballerina-platform/ballerina-www/issues/968#issuecomment-404061211,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYUEe6hWgMvIHqu8mUkAFK7OW0WHTfR3ks5uFZ0wgaJpZM4VCBQ8
.

--
Rivindu Madushan
Undergraduate,
Department of Computer Science & Engineering,
University of Moratuwa


MacOS Audio Unit in latest release tag only supports Intel architecture

Will be addressed in https://github.com/igorski/homecorrupter/pull/9


Relinquary Lily Pads and Vanilla Lily pads

OTG Plugin or Mod
[Please specify if it's about Forge Mod or Spigot server Plugin placing "x" into []]

[ ] OTG Mod for Forge

OTG Version
[Please specify the full OTG version that you are running by placing "x" into []]

[ ] OpenTerrainGenerator-1.12.2+-+v8.3.jar

Forge or Spigot Versions
forge-1.12.2-<IP_ADDRESS>47-universal.jar
Server/Client Log
crash-2020-02-05_16.45.56-client.txt
crash-2020-02-05_16.45.09-client.txt
crash-2020-02-05_16.44.16-client.txt
crash-2020-02-05_16.41.00-client.txt
What other plugins are you running?
Beyond the skies mod pack. https://www.curseforge.com/minecraft/modpacks/beyond-the-skies
Random Tweaks
Random Patch's
Worldedit forge
Fast Asyncronous World edit
Description
Issue occurs when placing lily pads
Issue occurs when playing reliquenary lily pads
OTG is running on client side only
[What did you expect to happen? - Explain what you expected to happen after performing the previously described steps]
[Can you provide a Minimal, Reproducible Example? See here for details: https://stackoverflow.com/help/minimal-reproducible-example]
[And Delete the lines in square brackets!]

Hey @blacksythe , thanks for reporting this. Could you try removing mods to see which minimal combination of mods exactly causes the issue? Also, could you try using OTG v9.0_r6, available on the Discord (otg-dev-releases channel). Be sure to delete OTG-Core.jar from the 1.12.2 folder when updating. Thanks!

Will do my suspects are reliquery

Allright, thanks for reporting back, glad you could figure it out :).


Recommended infra to run with all mathlib

Thank you for the project!
You mention running this lean4web on Ubuntu, could you please share the specs of the machine running the live version https://live.lean-lang.org/?
I've been testing with a few VMs on GCP (n2, 16 GB 2 vCPUs), but I tend to get lag and "busily processing" yellow tooltip whenever I paste a block of code.

I believe live.lean-lang.org is run on nix-os. On lean.math.hhu.de is run on ubuntu where we have 50GB RAM and 16 CPUs, although you probably don't need these specs.
Although, I believe the initial loading in Lean (yellow progress bar, not specific to the web editor) is parallelised and would heavily profit from more CPUs. That could be something to ask in Zulip "lean4" channel about for more details.
There should also be an option to the lean/lake commands which limit the max. number of CPUs used, which would help with the lag. (also not webeditor specific, but these could be modified in the code here or added as a config option.)

Excellent, thanks so much for the answer, I'll try increasing CPU settings!

I increased the number of vCPUs to 6, but what really made a difference was the lake serve -- -j 4.
The "busily processing" warning now disappears in 3 seconds. Still slower than my machine in local, but much much better.
On a side note, the issue was particularly present for snippets where I did a full import Mathlib.
Thanks again!


[jpegd] Add quick seek function to bitstream

Use C++ std::string::find function to look for specific byte quickly.
When there is a lot of junk data in the jpeg stream, it took quite some time to look for the 0xff and the marker.
Try using C++ std::string find function to look for that; it greatly improve the speed.

pls fix the build issues

Fixed, change to uint8_t since it is a byte.

Hi, there is a new commits to fix the compilation issue for windows on innersource.   Can anyone help to merge that commit to innersource.


Conditional Template

Resolves #2741

Implements the allOf feature of JSON schema to allow conditional fields + conditional schema validation
"auto_create" string has gone in favour of an enum (dropdown), which shows appropriate follow-up fields
all workspace templates updated to use conditional schema to streamline the form
Airlock review VM configuration - nested properties, conditionally required
UI code to massage the data payload sent in for create or update of a resource.

/test-extended

/test-force-approve


Correct behavior of toString

... on signals, should say "<Signal>", not "<Stream>".
Much as I regret that we don't have separate signal and stream concepts: As long as we don't, messages to the programmer/user should name the concept correctly. Currently, if you run
import Graphics.Element

main = Graphics.Element.show (Signal.constant 42)

you get output "<Stream>". But it should be (and before 0.15, was): "<Signal>". Streams are not a thing, currently.

Thank you for the fix!


Don't Merge! PR real time test for source branch full build

OPS Build status updates of commit 216735d:
:clock10: Full build: the average full build time is 6 min(s) 13 sec(s) This is based on the last 107 build(s) for this repository
:warning: This is a FULL build due to a configuration change (usually in openpublishing.publish.config.json and/or docfx.json). It is strongly suggested to merge this configuration change after the business hours, as it could impact the overall build performance of other PRs on the '.openpublishing.publish.config.json' branch. For more detailed info, please click here.

OPS Build status updates of commit 216735d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Word selection (Shift-Option Arrow) broken

Since 1.4.1, the keyboard shortcut for word selection – Shift–Option Arrow left/right – behaves like the cursor movement by one word to the left/right (= like Option Arrow left/right). Up to version 1.2.x the keyboard shortcut behaved in the standard MacOS way (extend the current selection by one word to the left/right).
Shift Arrow left/right and Shift-Command Arrow left/right behave like expected.
P.S.: I love this handy App. Since publishing, it became a daily companion of mine. Keep on the good work!

Excellent, very much appreciated. Thank you.


Stateful initialization of crypto backends

Fixes #94.

lot of unsafe

In the cc310 backend, I must resort to unsafe in order to access the C functions. Making the whole function unsafe extern "C" would automatically also make it available for the C wrapper. Nevertheless, I think it is fine to drop the function-wise unsafe and have lakers-c add a wrapper for that.

constructor to Crypto

I thought of that, the issue is how to provide a constructor that is generic for all backends (what should it take as parameter?).
For example in rustcrypto we would want to pass rand_core::OsRng, while in cc310 it would be either nothing or the static_cell you mentioned.

must resort to unsafe

Yeah, but that should be limited to the C or register calls; having a static mut is unsafe independently of that (and, moreover, about to be deprecated in favor of static S: SyncUnsafeCell<X>; or any safer wrappers around it).

rovide a constructor that is generic for all backends

There's two ways to answer that:

I don't think we need a constructor that is generic over all backends. It is convenient for the tests suite and the build tests to have a single lakers-crypto dispatch crate whose features can be placed in a matrix, but that's really just that. Any application building on it can make its choice of which crypto implementation to use (possibly guided by features of its own, but picking concrete crypto and not the dispatch crate), or defer to some platform specific dispatch that knows how to construct any backends, but in the end, the library part just takes an impl instance of it.
For this concrete case, the constructor doesn't need to take anything (and can thus be just be implementing Default): the static_cell can be a static local of the constructor.


"Nușfalău" is listed in the drop-down menu

Description:
"Nușfalău" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Nușfalău" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Nușfalău, SĂLAJ".


auto focus first form-control on htmx load

fixes #883

We probably want a more targeted class like 'form-autofocus' to have more control over this behaviour

Updated: now it only focus on first element with class form-control-auto-focus.
The template for contributor_name has now that class, so it has effect on adding authors, supervisors and other types of contributors


Check if object exists when presented with upa

previously just checked ws perms
Still needs integration tests

Coverage increased (+0.008%) to 97.912% when pulling a4e0bc272b9dd55ce7ffc289d477f7c65f7a89b5 on MrCreosote:master into bc3ede26d72874e86aad9c8bc479e0bad37dd3b7 on kbaseIncubator:master.


[iOS] Bring the iOS branch up to date with the latest master changes (.NET standard)

My attempt at bringing iOS up to date so that it can eventually be merged into master without too many changes.
I've also included the fix from #1429 (latest commit) since it was already present in the *.sln files on master.

let's do it


Release 0.2.8

@JuliaRegistrator register(branch=release)

Registration pull request created: JuliaRegistries/General/17502
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.8 -m "<description of version>" bb3e9f2df67f3f8ca13edc896752e7bc3d052224
git push origin v0.2.8


Updated notes

@MattEEvans
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Look into issues with Github linking and login flow for certain users

Context
Brief description. Is this part of a parent issue?
Requirements

Check out this screen recording
@maxachis and @joshuagraber hypothesize that this is limited to staging users and is a relic of those users being wiped every day.
Confirm that this is the case.
Also: look into what it would take to preserve users in the lesser DBs. It would be nice to have stable testing users anyways.

Tests

TBD

Docs

TBD

Open questions

Any uncertainties? Anything we're flexible about?

To make sure I'm properly understanding the video, and to confirm with @joshuagraber on this:

Sign in with Github -> Get "You already have an account with this email address"
Sign in manually, sign-in successful. Follow-up /profile page states "Your account is linked with GitHub"
If accessing page via localhost, omitting the linked=true query parameter, user is given option to link account with GitHub.
Clicking this then successfully takes the user to a linked=true version of the profile page.
Signing out and then clicking Sign in with GitHub again produces the You already have an account with this email address error

@joshuagraber Additionally, with a v2 production database setup which can persist for longer periods of time, I wonder if this is something we'll still observe in that environment.

I agree that we can address this closer to launch. I linked to it from #248 so we don't forget.


Implicitly extract tar.gz files from plugins that upload them

This makes it so plugins upload to a path like:
/api/v1/results/global/e2e.tar.gz

And it will show up in:
/results/plugins/e2e/results/<contents>

(For single-node plugins, this would map to:)
/results/plugins/systemd_logs/node1/<contents>

This needs to be documented along with the snapshot documentation that
is already under review.
Since the upload path is now expected to have a file extension in it, In
case for some reason the sonobuoy master launches with an old version
of the sonobuoy worker (or for plugins not using sonobuoy worker that
upload their own contents), if the path has no file extension, it is
guessed to be .json or .tar.gz, same as before.
Signed-off-by: Ken Simon<EMAIL_ADDRESS>

Fixes #28

@timothysc PTAL
Made some changes per review:

If there's no file extension in the upload URI, we just save the file without an extension instead of guessing one (so no untarring will happen in that case)
Plugin errors channeled from driver.Monitor() now carry a ".json" extension to make things consistent, and there's a test for this now
Removed duplicate Close() calls by putting the file write in a closure and putting the defer f.Close() there


Change build scripts to be independent from the working directory

This change allows running the build scripts from any directory, making it more robust and less likely for people to use it wrong.

pushd/popd is a bash-specific which means you removed compatibility for a bunch of systems.
You should restore the previous PWD.
You could also make the Powershell scripts behave the same.

I removed pushd and switched to an approach using test and a subshell. This way it even returns to the old dir when there is an error.
I also wrapped the powershell scripts in a try-finally and use pushd/popd there as well.


VS Code is not displaying correct italic font.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.58.2
OS Version: Windows 11 build 22000.71

Steps to Reproduce:

Use Cascadia Code (or any other font that has a separate italic font) as your default font.
Check of it displays the font correctly.

Comment: Earlier, VS Code was displaying the italic font correctly. Either it's a bug in the VS Code itself or maybe it's a windows 11 thing.

/needsMoreInfo
Is it in editor or it terminal?
Please provide values of editor.fontFamily and terminal.integrated.fontFamily?
How was Cascadia Code installed (manually or with Windows Terminal, do you have WT installed)? It doesn't have "separate" italic font, it's merged with regular if both installed.
Also note that Cascadia Code in latest release has separate display features for italics and cursive.

editor.fontFamily : "Cascadia Code"
terminal.integrated.fontFamily: "Meslo LGS NF"
However, I am only concerned with the editor font. I have the latest version of Cascadia Code that came with WT. Earlier I had manually 2105.24, which showed the cursive letters for the italic variant. I have removed this version, and I can see that the WT version does not have cursive letters.
I thought that this is a VS Code issue and opened the issue. I am closing it now.
Although it would be good to know how to switch to the cursive version.

If you have latest Cascadia Code version (personally I use Cascadia Code PL installed manually to avoid conflicts with WT) you can use Font features https://github.com/microsoft/cascadia-code#font-features to control display of font.
I guess that you want to enable cursive from (instead of more "toned-down" italics) and in this case "editor.fontLigatures": "'calt', 'ss01'" should help

Ok, Thanks.


Enable pre-commit checks

fixes #60

For the moment I added checks that seem to be good in general. Please let me know if you are fine with my choice.

I would like to request explicit approval from @ondrejkrejci and @ProkopHapala as well. This PR will influence the code styling and will enforce users to adhere to it in the future. So if you want to say no to some specific check, this would be the moment 😎 .

@ondrejkrejci, @ProkopHapala since you didn't provide your opinion yet, should I consider that PR good to go? Or do you have issues with it?

I put the comment there, that I wanted to suggest maybe some changes. I am saturated now. Friday - So if you do not hear from me on Monday, then feel free to go. Sorry for the delay. I am trying to sit on too many chairs now, so this had to go to very low priority for me ....

Since everyone agreed to keep supporting Python 3.6+, I will redo some of the changes and re-request everybody's approval.

Since the only change was enabling Python 3.6+ compatibility, I decided to go without a further review. All the other changes were already approved.

@ondrejkrejci, can you please make a follow-up PR to fix the issues you've reported?


SMS Retrieve previous messages/conversations

When you are in the web widget, message tab.  Any previous messages/conversations that you have may sent out via your cell phone or other apps do not get pulled in.

Hi, @AndyHaas Now the app only pulls messages in recent 7 days. We will create a enhancement to support to pull older message.
Does you get messages in recent 7 days? If you don't get, please let's know. it may be a bug.

@embbnux the app does currently get the last 7 days of messages. When we convert over from the desktop app to the web widget I am trying to eliminate the calls of "Where are my messages"

@AndyHaas

suggestion is when they scroll all the way at the top is to have a button that states to get the previous messages. and they can continue to scroll up and get the older messages

Thanks @AndyHaas  Good idea, it has been in our backlog

Would like to see this get accomplished. I am using this a day to day tool and have to keep going to my cell phone to see previous texts. If there is any way to update this to allow a end user to grab previous messages this would make life a bit easier.

@AndyHaas I will push this. Thanks

@embbnux this looks good. I was able to go all the way back to the begging of time. Much appreciated.


Configured DNS server not applied to connections when PersistentKeepalive is set to 0

Describe the bug
Setting persistent keepalive to 0 adds an empty line to the generated configuration files, which causes the configured DNS server to not be applied to the connection on Fedora 38 via NetworkManager.
To Reproduce

Set default['firezone']['wireguard']['persistent_keepalive'] to 0 (the default value)
Set default['firezone']['wireguard']['dns'] to any non-default value (example: <IP_ADDRESS>)
Generate a Firezone device profile via the normal user workflow
Inspect the config and see that it includes a blank line where the PersistentKeepalive directive would be, and a valid DNS directive
Import the config using NetworkManager's "import from file" feature
Activate the connection
Note that the connection has no assigned DNS servers
Manually edit the config file to remove the blank line
Re-import the config using NetworkManager's "import from file" feature
Activate the connection
Note that the connection has the correct assigned DNS server

Expected behavior
This may be a bug in NetworkManager's parsing of the config file, however Firezone can mitigate the problem by generating a config that either does not include the PersistentKeepalive line if the value is 0, or including the directive explicitly set to 0.
Platform:

Firezone Version: 0.7.30
OS: Linux
Distro: Server - Ubuntu 22.04, Client - Fedora 38
Kernel version: Server - 5.15.0, Client - 6.4.10
Deployment method: Omnibus

Thanks for the report @enpaul.
Are you able to test if this is happening on Docker as well? Many configuration bugs were fixed in the Docker deployment method. Omnibus deployments have been deprecated for some time.

Hi @jamilbk , yes I just ran this test on my dev setup and found that it exhibits the same symptoms on the server side (generates a config with the blank line). I don't have access to my Fedora workstation at the moment to confirm that the config behaves the same on the client, but I'd say it's a safe assumption that it does. I can confirm that later tonight though. Once that's done I'll update the issue with the details from my docker dev setup.

@enpaul As a workaround, could you leave the PersistentKeepalive field blank? That should keep it from being printed at all I believe. I'm not sure what a PersistentKeepalive value of 0 would achieve in the WireGuard client?

Fixed in 0.7.36


Honor new 'important' category of OutputEvents

As a follow up to https://github.com/microsoft/debug-adapter-protocol/issues/218, please highlight output messages tagged as 'important'. Perhaps log this in the console and trigger a showUser-like pop-up that disappears after a couple of moments?

@roblourens I've improved the output event support in Mock Debug. Now you can send output events for all output categories, e.g. prio(message) for "important" messages.
See https://github.com/microsoft/vscode-mock-debug/tree/main/sampleWorkspace#output-events

I wonder whether these messages should also be marked somehow in the debug console?

I wonder whether these messages should also be marked somehow in the debug console?

I think it's a great idea to have them stick out using something visual (bold font, different color or some other flag).

Yes, showing an important message in bold with a strong color (not red) makes sense.

@roblourens I agree, we should not drop the category on logged objects.
Most likely, ignoring the category was an oversight.

I guess we style the object differently and just don't have a style for it.
@misolori I wonder whether we should show an error icon next to logged errors in the debug console. Currently the only difference is the text color.
Then we could just show the same icon next to a logged object

Implemented this. @polinasok out of curiosity can you give an example of when you will use this?
I noticed that since 'important' is a category, we can't mark a message as "important error" vs "important info". Is that your intention with the API change or would you want to be able to differentiate these things?

@roblourens from a DAP perspective there is no concept of "info" vs. "error".
DAP's "stderr" and "stdout" categories express the source/origin of a message and not the semantic (which is unknown to the DA anyway).
The "important" category can be considered as a variant of the "console" category: in both cases is the DA the source of the message and therefore the semantics and "importance" is known.

@roblourens cool!

If we ever do need an icon to represent this, we did start using this in the terminal for decorators

Also if you expand that notification, the debug session name is set as the "source" so you can tell why it is showing up.
I will open another issue for setting an icon on debug console stderr messages. I think that could be an accessibility issue right @isidorn?

We might want to use this for errors or for very important info messages (as opposed to just general logging that users might or might not need/want to inspect).
Here are some of the examples:

Build Errors
We currently use OutputEvent(stderr). The message is better formatted in the Debug Console than in the launch error pop-up. And users find the pop-up annoying because they have to close it every time they iterate on their build errors.
Failure to set breakpoints
When some breakpoints fail to set, we return a success response with a list of requested breakpoints and their status. The UI highlights the failed ones in a different way, and there is a hover with the error. But if none of the breakpoints are hit (e.g. we have a path mismatch in a remote debugging set-up), then the program might quickly run to completion and those markers would disappear as soon as the session is over, leaving the users with no record of what went wrong. A message in the Debug Console would remain after the session's end.
Breakpoint on one thread interrupts a step operation on another
This is not an error, and can look very unexpected to the users as the view jumps somewhere else. Also, we have the option of cancelling the step operation or pausing it and allowing it to be resumed with "Continue". Either way we need to let the user know what's going on and how to proceed.
When we fail to retrieve goroutines
Go users generally care about goroutines (lightweight Go threads), but not so much about the underlying runtime threads, so that's we use the ThreadsRequest to communicate the info about the goroutines. But when the program is stopped on entry or in some other corner cases, we might not be able to retrieve any gorotuines. To play nice with DAP we are forced to send back a successful Dummy thread, which at the same time yields no usable Call Stack, so additional info in the debug console can be useful.

@roblourens we should not ignore the category. I forgot the original intention when I coded that up.
Icon sounds like a good first step. For accessibility - we could just append the category at the end of the aria label of the REPL element.

Verification steps

Install the mock debug extension
Clone this repo and debug this workspace using the mock debug extension: https://github.com/microsoft/vscode-mock-debug/tree/main/sampleWorkspace
When stepping over the prio() line, you should get a notification in VS Code
The "source" field on the notification is the name of the debug session

The mock above shows a pop-up. Will it disappear on its own after a while or will the user always have to close it manually?

Yeah, they timeout after 20s or so

Seems to work. I wonder if the notifications should automatically be dismissed if they're still open when the session ends. It could be annoying if there was an error in a session that generated a lot of messages the user would need to manually close..

If the debug sessions end quickly because of the "important" issues shown as notifications, then dismissing them immediately is not that helpful. But dismissing them when starting a new session might be a better approach.

That makes sense. They should only dismiss when a debug configuration of the same name as created them is started.

If it's annoying, you can just hit esc, otherwise they will automatically hide relatively quickly. Is it that bad?

@polinasok I was wondering whether you ever adopted this? I don't think I see any usages of the "important" category in the vscode-go or delve repos. I'm asking because I was rethinking the decision to make this a notification, in https://github.com/microsoft/debugpy/issues/1019

I guess I'm not sure whether @polinasok is still working on that, if not it looks like @hyangah has been active on it

Delve-Dap has not adopted this yet. But it should. Pop-up is nice - similar to ErrorResponse with showUser. What's aa notification?


Support new compile-time errors for initialization clashes

A recent update to the language specification includes two new compile-time errors for initialization conflicts: It is a compile-time error to have an initializer or an initializing formal initializing a final variable with an initializing expression. The rationale is that similar situations are already compile-time errors. For example:
class C {
  final x = 42; // A final instance variable with an initializer.
  C(this.x); // Compile-time error: `x` is initialized already, and final.
  C.someName(): x = 41; // Compile-time error: `x` is initialized already, and final.
}

Tool specific issues:

[ ] analyzer #29657.
[ ] vm #29658.
[ ] dart2js #29659.

What about something like this:
class C {
final x = 42;
C.someName() {
x = 100;  // Should this also be a compile time error ??? currently the VM produces a runtime error.
}
}
The runtime error reported is  Class 'C' has no instance setter 'x='.

No, the treatment of that setter invocation is unchanged, the addition to the spec only deals with initializer lists and initializing formals vs. locally initialized final variables:
It is a compile-time error if $k$'s initializer list contains an initializer for
a final variable $f$ whose declaration includes an initialization expression.
...
It is a compile-time error if $k$ includes an initializing formal for a final variable
$f$ whose declaration includes an initialization expression.

All child bugs are closed. @eernstg looks like we can close?

Indeed, thanks!


Clearer distinction but public/confidential flow

Redeeming the auth code for a token and refreshing an access token differ when you are on a confidential or public client scenario. This update tries to make difference clearer in the use of the client secret on those calls.
Disclaimer: this is merely a docs issue, I've tested both public and confidential flows and the service works as expected.

@JoseMSoares-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Fast fail or handle NaN correctly in log and others

See also: #259
In 0.5 log returns NaN instead of throwing an error for negative values. I'm not really sure if that's good or bad.

We don't have any support for NaN in Squiggle now. My inclination is that an error would be better.

Yeah, it just gets passed around as a number and can create problems downstream.
Btw, when we get to strict(er) typing, my hunch is that squiggle should distinguish between integers and floats, instead of going with original JS semantics, but that's a bigger and more complicated discussion.

Yea, makes sense


update annotation processing

DO NOT MERGE
in progress

@DanielJMaher this needs to get merged in first before the UI portion can be merged

All checks have failed.  Mind fixing? @birdage

@DanielJMaher its to do with test coverage, will look at it

@FBRTMaka Check this please!!!!

@birdage What happened now?

======================================================================
ERROR: tests.test_annotations (unittest.loader.ModuleImportFailure)
ImportError: Failed to import test module: tests.test_annotations
Traceback (most recent call last):
File "/usr/lib/python2.7/unittest/loader.py", line 252, in _find_tests
module = self._get_module_from_name(name)
File "/usr/lib/python2.7/unittest/loader.py", line 230, in _get_module_from_name
import(name)
File "/home/travis/build/asascience-open/ooi-ui-services/ooiservices/tests/test_annotations.py", line 23, in
@skipIf(os.getenv('TRAVIS'), 'Skip if testing from Travis CI.')
NameError: name 'skipIf' is not defined

======================================================================
FAIL: test_annotation (tests.test_annotations.AnnotationsTestCase)
Traceback (most recent call last):
File "/home/travis/build/asascience-open/ooi-ui-services/ooiservices/tests/test_annotations.py", line 75, in test_annotation
self.assertEquals(response.status_code, 201)
AssertionError: 500 != 201
FAIL: test_searching (tests.test_annotations.AnnotationsTestCase)
Traceback (most recent call last):
File "/home/travis/build/asascience-open/ooi-ui-services/ooiservices/tests/test_annotations.py", line 167, in test_searching
self.assertEquals(response.status_code, 201)
AssertionError: 500 != 201

@birdage PASSED

@FBRTMaka You cool with this?

@birdage totes