Programming exercise: Use primitive booleans instead of objects for the domain class attributes

Is your feature request related to a problem?
A few attributes of the programming exercise domain class use the Boolean type instead of plain boolean.
This results in the caller having to use Boolean.FALSE.equals(exercise.attribute()) or similar to decide how a null-value should be handled. This is error-prone, as it can be easily forgotten in some places to handle this correctly, which results in inconsistent behaviour.
Describe the solution you'd like

Step 1: The getter/setter methods of an attribute should take/return plain booleans and the Booleans.?.equals(…) comparison should happen inside.
Step 2: Refactor the callers of the gett/setter to remove the Booleans.?.equals() checks there.
Step 3: Change the attribute type to plain boolean and set an appropriate default value for each one. Remove the internal Booleans.?.equals checks in the getter.
Step 4: Repeat for the next attribute.

This should allow refactoring while being able to check in each step that no tests break, i.e. the behaviour stays the same.
Describe alternatives you've considered
No response
Additional context
No response

Hi Benedikt, I just assigned this task to myself. I took the first step that you described for the attribute publishBuildPlanUrl but the following line of the ParticipationIntegrationTest does not make sense anymore.
               assertThat(aProgrammingExercise.isPublishBuildPlanUrl()).isNull();
My hunch would be to change this line (after setting a default value) to check for equality to the expected default value.
What's your opinion on this?

I’d assume that the build plan only gets published in case publishBuildPlanUrl was explicitly set to true somewhere. Therefore, the intermediate step 1 for the getter in this case should probably be return Booleans.TRUE.equals(publishBuildPlanUrl).
So in this specific case I’d expect that the assertion should now be
assertThat(aProgrammingExercise.isPublishBuildPlanUrl()).isFalse();

Hi Benedikt,
I'm a bit stuck because the tests keep failing for a reason I don't understand.
The initialization of the attribute looks like this right now:
@Column(name = "allow_online_editor", table = "programming_exercise_details")     private boolean allowOnlineEditor = false;
and its setter method like this:
public void setAllowOnlineEditor(boolean allowOnlineEditor) {         this.allowOnlineEditor = allowOnlineEditor;     }
However I get the following error:
java.lang.NoSuchMethodError: 'void de.tum.in.www1.artemis.domain.ProgrammingExercise.setAllowOnlineEditor(java.lang.Boolean)'
I don't get why the old parameter type is expected here but my hunch is it has something todo with the database.

Hm, that’s difficult to debug with only this message. Is there a branch where I can see the changes? Which test(s) are failing?

Yes I'll publish my branch and commit the current changes. The tests are obvs. gonna fail though

Hm, I made the two changes you mentioned above and all tests in the two classes bases on the ProgrammingExerciseIntegrationTestService (ProgrammingExerciseIntegrationJenkinsGitlabTest/ProgrammingExerciseIntegrationBambooBitbucketJiraTest) still pass.
Might that have been caused by some classes not being recompiled so that an old cached version is used again? I’m not sure when/why that would happen, though.
diff --git a/src/main/java/de/tum/in/www1/artemis/domain/ProgrammingExercise.java b/src/main/java/de/tum/in/www1/artemis/domain/ProgrammingExercise.java
index 89f6585ac6..6acaf451bb 100644
--- a/src/main/java/de/tum/in/www1/artemis/domain/ProgrammingExercise.java
+++ b/src/main/java/de/tum/in/www1/artemis/domain/ProgrammingExercise.java
@@ -52,7 +52,7 @@ public class ProgrammingExercise extends Exercise {
     private Boolean publishBuildPlanUrl;

     @Column(name = "allow_online_editor", table = "programming_exercise_details")
-    private Boolean allowOnlineEditor;
+    private boolean allowOnlineEditor = false;

     @Column(name = "allow_offline_ide", table = "programming_exercise_details")
     private Boolean allowOfflineIde;
@@ -250,7 +250,7 @@ public class ProgrammingExercise extends Exercise {
         return allowOnlineEditor;
     }

-    public void setAllowOnlineEditor(Boolean allowOnlineEditor) {
+    public void setAllowOnlineEditor(boolean allowOnlineEditor) {
         this.allowOnlineEditor = allowOnlineEditor;
     }

diff --git a/src/main/java/de/tum/in/www1/artemis/web/rest/ParticipationResource.java b/src/main/java/de/tum/in/www1/artemis/web/rest/ParticipationResource.java
index cc6b5b3854..68604d982b 100644
--- a/src/main/java/de/tum/in/www1/artemis/web/rest/ParticipationResource.java
+++ b/src/main/java/de/tum/in/www1/artemis/web/rest/ParticipationResource.java
@@ -526,7 +526,6 @@ public class ParticipationResource {
                 programmingExercise.setPublishBuildPlanUrl(null);
                 programmingExercise.setProgrammingLanguage(null);
                 programmingExercise.setPackageName(null);
-                programmingExercise.setAllowOnlineEditor(null);
             }
             else if (exercise instanceof QuizExercise quizExercise) {
                 quizExercise.setQuizQuestions(null);

Mh okay could you try checking out my branch and running the tests there?


ParticlePopulation's nonextendability

I am wondering if there is a good reason (that is not yet apparent to me) why ParticlePopulation<P> is a final class? I would like to extend this class in order to override the logNormEstimate method for SMC variants (and add some additional fields, too), but this restraint obviously makes it impossible without rewriting the whole class.
Thanks!

The main reason is that final classes are easier to reason about. In 99% of the cases, extending a class A is a sub-optimal strategy. It is usually better to create a new class B that contains an instance of A as a field (this is called composition). This sometimes require creating an interface C for A and B, but not always. Let me know if it does in this case.
Of course, there are some rare cases where that doesn't work, and feel free to remove final then. That will not break current behavior.
Best,
Alex

Thanks!


i can't use dumpdecrypted ，tips killed:9

i use my account to signed, and the kernel Log is : only launchd is allowed to spawn untrusted binaries

So far I understand it, you need to have a valid ent on the binary and you need to inject its trust
cd /private/var/mobile/Documents # save place to work in
ldid -e `which bash` > ent.xml # Get the ent from bash and save it
ldid -Sent.xml `which dumpdecrypted` # sign dumpdecrypted with the ent. "-Sent.xml" is the correct usage
inject `which dumpdecrypted` # inject into trust cache

But not really sure if this is correct. At least this is the way how I archive this.

So far I understand it, you need to have a valid ent on the binary and you need to inject its trust
cd /private/var/mobile/Documents # save place to work in
ldid -e `which bash` > ent.xml # Get the ent from bash and save it
ldid -Sent.xml `which dumpdecrypted` # sign dumpdecrypted with the ent. "-Sent.xml" is the correct usage
inject `which dumpdecrypted` # inject into trust cache

But not really sure if this is correct. At least this is the way how I archive this.

how did i delete the trust cache,i use your method but still can't,the kernel tip same as before

@CCbird on iOS 12 things need to be signed using a cert. I recommend bfdecrypt instead.

Refer to #206 for all dumping and injecting related issues.


Issues

Not working

Could you be more descriptive? How isn't it working?

{"errorType":"Error","errorMessage":"Failed to get user ban","trace":["Error: Failed to get user ban","    at getBan (/var/task/func/helpers/user-helpers.js:41:15)","    at processTicksAndRejections (internal/process/task_queues.js:95:5)","    at async Runtime.exports.handler (/var/task/func/oauth-callback.js:44:25)"]}

It failed to fetch a users ban status here which means one of the three variables could be wrong. I would first try triggering a deploy to make sure environment variables are set properly then maybe checking the bot's permissions

Thank you so much, I was able to fix it. I really appreciate it!


CFE-846 : Add user defined tags to the GCP buckets created

PR has the changes for https://github.com/openshift/enhancements/pull/1217 proposed to support GCP tags in OCP, which requires cluster-image-registry-operator to add gcp userTags available in the status sub resource of infrastructure CR, to the gcp buckets created by the operator.

/hold https://github.com/openshift/enhancements/pull/1217

/remove-hold

/label px-approved

/jira refresh

/lgtm

Hi @wewang58, could you help test this code?
Please collaborate with @jianli-wei on how we test it if you need help.
Thank you both!

Will there be tests for this feature?

Yeah, QE is working on the pre-merge tests and have asked for GCP regression tests too.

HI, If i launch  a cluster with cluster-bot, which installer pr or api pr, also needed?

/label qe-approved

@bharath-b-rh are there other PRs needed to test this?
@wewang58 do you still need an answer?

test failures seem flake related
/retest

@flavianmissi @wewang58 : Yeah we need below installer PRs to test the feature.
https://github.com/openshift/installer/pull/7126
https://github.com/openshift/installer/pull/7201
https://github.com/openshift/installer/pull/7138
https://github.com/openshift/installer/pull/7279

@bharath-b-rh do we need to merge the installer PRs and this one together in that case? sounds like this one won't work standalone.

@bharath-b-rh do we need to merge the installer PRs and this one together in that case? sounds like this one won't work standalone.

Yeah, I am working with installer team to get the PRs merged. If we merge this without installer code, user cannot define tags and the registry operator won't add any tags. But the operator as such can be deployed.

/test e2e-aws-operator

/test e2e-aws-ovn-upgrade

/label qe-approved

e2e failure seems unrelated
/retest
/lgtm

/label docs-approved


improve documentation on how execution timeouts work and pitfalls with commands not catching InterruptedException

I spent quite some time understanding that Hystrix commands that execute longer than the configured executionTimeoutInMilliseconds are canceled from 'a client's perspective', but only an InterruptedException is thrown on the executing thread. Most HTTP libraries ignore this exception and thus, the command keeps on executing. Without setting proper timeouts on the HTTP client, the Hystrix thread pool might get saturated very quickly.
I think this behavior should be better documented in the wiki. Related is e.g. this issue: #1519 or other where people opened issues for not understanding this behavior.

Thanks for the feedback @jack-kerouac .  I added a couple sentences here: https://github.com/Netflix/Hystrix/wiki/How-it-Works#6-hystrixobservablecommandconstruct-or-hystrixcommandrun

Thanks, sounds good already! May I suggest the following extension in its own paragraph:
Please note that there's no way to force the latent thread to stop work - the best Hystrix can do on the JVM is to throw it an InterruptedException. If the work wrapped by Hystrix does not respect InterruptedExceptions, the thread in the Hystrix thread pool will continue its work, though the client already received a TimeoutException. This behavior can saturate the Hystrix thread pool, though the load is 'correctly shed'. Most Java HTTP client libraries do not interpret InterruptedExceptions. So make sure to correctly configure connection and read/write timeouts on the HTTP clients.
Feel free to change. Thanks a lot!

Your version was more helpful to a consumer of the doc, so I hope you don't mind that I just used yours as-is.  Thanks for the contribution!

Not at all. Thanks!


Bump Onyx to 2.0.53

Details
Bumps Onyx to 2.0.53 and fix this issue.
Fixed Issues
$ https://github.com/Expensify/App/issues/44196
PROPOSAL: https://github.com/Expensify/App/issues/44196#issuecomment-2184085451
Tests

Open any thread
Go to three dots -> leave
Quickly open the thread again, click Join and open the chat header
Wait for about 10-15 seconds, the app should not crash

[x] Verify that no errors appear in the JS console

Offline tests
Same.
QA Steps
Same.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/20051562/5e8a3a95-fb73-4c06-8399-4859fbce14ee

Android: mWeb Chrome
https://github.com/Expensify/App/assets/20051562/9461e21d-a850-4c86-bf5f-f112b9037902

iOS: Native
https://github.com/Expensify/App/assets/20051562/f6307d86-ce12-4bc2-84c6-293faf2828fc

iOS: mWeb Safari
https://github.com/Expensify/App/assets/20051562/2f40a18f-f4bf-4023-84dc-bc0409282aef

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/20051562/6051275b-7637-4d1a-b115-06dbad7cff9b
https://github.com/Expensify/App/assets/20051562/5c34925c-fb42-4822-8d90-af3765e21c5b

MacOS: Desktop
https://github.com/Expensify/App/assets/20051562/66c4c1fa-5b27-47ca-a422-56f04046f940

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

perf tests failing

perf tests failing

@situchan It's also happening on main.

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.1-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Validation of resolving requirements missing errors

Notice the "Dependency" rows are not rendered as requirements because they are indeed missing. Metanorma needs to display warning messages if these requirements are not found.

Also, "Dependency" should be rendered as "Prerequisites".

Also, "Dependency" should be rendered as "Prerequisites".

In ISO, or in general? @ronaldtse

In general please. We're trying to align this across SDOs.

Confirm fixed in ISO 19115-3. Thanks!


creating a branch

Creating a Branch For DATA-STRUCTURE & ALGORITHM
CREATING  THIS BRANCH BECAUSE OF  I WANNA  ONLY CODE IN DATA STRUCTURE & ALGORITHM.

🤣🤣🤣🤣🤣🤣🤣🤣
I HAVE SOME TROUBLE WHILE USING THIS BIG PROJECT ! IWANNA ONLY CODE FOR DATA STRUCTURE..WHEN I OPEN THIS PROJECT IN VSCODE.... IT'S STARTS STUCKING..
So, any Solution!

Use updated fork file 📁
Where all file present and change code and send pull request


Bugfix: A factor of 2 was missing from the Saha equation

A factor of 2 was missing from the Saha equation. Basically we were underestimating the number-densities of ionized species.
In addition to fixing this bug, I introduced the test to test/runtests.jl that helped me realize that there was an issue. This test checks the saha function against the analytic solution for a pure hydrogen atmosphere.
I think that this is probably going to resolve my outstanding issues with hydrogenic free-free opacity. But I wanted to submit this PR separately since it's going to affect the line opacities (I'm curious if it will improve agreement in PR #9 )

My bad!


useNodesInitialized cannot be resolved

Describe the Bug
Hello, the API documentation lists the hook useNodesInitialized, which is something I would need.
However, there doesn't seem to exist any reference to this hook in the codebase.
Is it something obsolete? Was it replaced? There seems to be many hooks in the codebase that are not documented.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Use const nodesInitialized = useNodesInitialized();

Expected behavior
As a user, I expected to be able to use this hook, but it cannot be defined.
Screenshots or Videos
No response
Platform

OS: [All]
Browser: [All]
Version: ["react-flow-renderer": "^10.3.14",]

Additional context
No response

Works after upgrading to React 17.


Ideate on the availability update flow

Work with Tom and Gabe and property manager group to come up with options for how property managers might update availability.
Some options we've already discussed:

email updates with "click to update availability"
CSV import from property manager software with unit level availability info
property manager login to partner portal and edit the availability in the unit summary field

HRD is keen to have email reminders to edit availability, and in a recent meeting brought up two possibilities:

Including in the email a link to the portal where they can update availability
Allowing PMs to update availability from within the email, like an embedded form.

I have hesitations about #2 for security reasons. I think a login should really be required to edit availability data. Plus it's more engineering time than a simple reminder with a link, and for not much gain, given that either way they're still filling out a form.

Safiya also mentioned that getting any CSVs from PMs might be a problem, and if we get them they're unlikely to be in a workable format, and may be inaccurate. Currently, her preferred workflow seems to be to seed the database with some initial data, and after that PMs are exclusively editing the availability summary table.
Initial data exists in a sheet already, and additional data is being gathered now via Google form. It includes information about the property (amenities, accessibility features, etc), and a summary of availability. Data on individual units is not being collected AFAIK.
So IMO this is what we'll need:

A new table for availability summaries
A way to import initial data (including the availability summary) via CSV, potentially from two separate CSVs. Note that the summary table would be populated directly, and not derived from data on individual units
Ability for PMs to update availability summaries directly from the portal

And the flow for PMs looks like:

Receive an email reminder to refresh availability data with link to do so
Click link, navigate to login
Login, automatically directed to the edit availability form
Update form and submit

Tickets for initial work have been filed. Closing this for now.


Support for visual studio 2019

Currently this extension couldn't be installed in vs 2019.

Submitted pull request #292 to update the manifest to VS 2019.
I built an updated version for VS 2019. Works on my machine 😄

After installing I got

Visual Studio has detected one or more extensions that are at risk of not functioning in a future VS update.

Seems like there are really some compatibility issue.

VS 2019 requires async extensions. https://blogs.msdn.microsoft.com/visualstudio/2018/05/16/improving-the-responsiveness-of-critical-scenarios-by-updating-auto-load-behavior-for-extensions/

Submitted pull request #292 to update the manifest to VS 2019.
I built an updated version for VS 2019. Works on my machine 😄

I tried it on my machine, it works just fine, thanks, great job!

FYI, the next version of VS 2019 will completely refuse to load this extension:

Works on VS2019 but throws a "this is using deprecated APIs!" warning.

Weird, I'm not seeing errors

I should have been more clear - "next version" being 2019.1 (at least the pre-release version available to me as of 4/2), not the just-released 2019, which I think just outputs warnings.

@frhagn do you have some news about this issue?

it seem the extension need to update the ExtensionPackage class (Typewriter/VisualStudio/ExtensionPackage.cs) changing inheritance from Package to AsyncPackage.cs)
see https://github.com/Microsoft/VSSDK-Extensibility-Samples/tree/master/AsyncPackageMigration

For this to be compatible with VS2019 version 16.1 (currently in public preview), you need to migrate to use AsyncPackage with background load. This is supported in VS2015 and above and is described here https://github.com/Microsoft/VSSDK-Extensibility-Samples/tree/master/AsyncPackageMigration

@frhagn are these cases being closed because they won't be implemented? or because they've been fixed somewhere else?

@frhagn are these cases being closed because they won't be implemented? or because they've been fixed somewhere else?

It's been fixed in the latest release, it's not available from the VS marketplace yet (download link is dead there for some reason), but you can get it manually from the release page. https://github.com/frhagn/Typewriter/releases/tag/v1.22.0

@michaelaird sorry about that.. It's fixed in 1.22.0. Anyone else (besides @antur84) having trouble downloading it from the VS Marketplace?.. seems to be working for me.

Thanks! 1.22 updated fine for me directly in VS.
On Wed, 24 Apr 2019 at 11:13, Fredrik Hagnelius<EMAIL_ADDRESS>wrote:

@michaelaird https://github.com/michaelaird sorry about that.. It's
fixed in 1.22.0. Anyone else (besides @antur84
https://github.com/antur84) having trouble downloading it from the VS
Marketplace?.. seems to be working for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/frhagn/Typewriter/issues/286#issuecomment-486284892,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABVP2PCTNVWGULWWNYG3GTPSB2J5ANCNFSM4GIXPCFQ
.

Download link didn't download the proper version here either


Structured logging (JSON)

Is your feature request related to a problem? Please describe.
Its pretty common these days to emit structured logs instead of textual logs. Its easier to parse and some cloud environments already has support for parsing and indexing them. My problem is mainly with GKE, textual logs to stderr/stdout are by default logged with severity of ERROR which is not really great as that brings a lot of noise.
Describe the solution you'd like
Ability to switch to json logging, a severity field would decide the level of the logged message. Example logged message:
{
  "severity":"INFO",
  "message":"Hello world.",
  "time":"2020-10-12T07:20:50.52Z"
}

https://cloud.google.com/logging/docs/structured-logging

@levkk do we need to keep using the env_logger? This is a good use case for the tracing-subscriber. Like the examples below, we could display logs using the existing formatters. Both text and pretty formatters have color support.
Let me know your thoughts so I can send the PR.
text => current values - using full formatter
2023-07-19T05:06:43.430838Z  INFO pgcat: Welcome to PgCat! Meow. (Version 1.0.2-alpha3)
2023-07-19T05:06:43.447918Z  INFO pgcat: Running on <IP_ADDRESS>:6432
2023-07-19T05:06:43.447940Z  INFO pgcat::config: Ban time: 60s
2023-07-19T05:06:43.447945Z  INFO pgcat::config: Idle client in transaction timeout: 0ms
2023-07-19T05:06:43.447950Z  INFO pgcat::config: Worker threads: 5

We could use a custom format to implement the current format if needed.
structured => using the json formatter
{"timestamp":"2023-07-19T05:08:43.827969Z","level":"INFO","fields":{"message":"Welcome to PgCat! Meow. (Version 1.0.2-alpha3)","log.target":"pgcat","log.module_path":"pgcat","log.file":"src/main.rs","log.line":88},"target":"pgcat"}
{"timestamp":"2023-07-19T05:08:43.842202Z","level":"INFO","fields":{"message":"Running on <IP_ADDRESS>:6432","log.target":"pgcat","log.module_path":"pgcat","log.file":"src/main.rs","log.line":149},"target":"pgcat"}
{"timestamp":"2023-07-19T05:08:43.842238Z","level":"INFO","fields":{"message":"Ban time: 60s","log.target":"pgcat::config","log.module_path":"pgcat::config","log.file":"src/config.rs","log.line":987},"target":"pgcat::config"}
{"timestamp":"2023-07-19T05:08:43.842252Z","level":"INFO","fields":{"message":"Idle client in transaction timeout: 0ms","log.target":"pgcat::config","log.module_path":"pgcat::config","log.file":"src/config.rs","log.line":988},"target":"pgcat::config"}
{"timestamp":"2023-07-19T05:08:43.842266Z","level":"INFO","fields":{"message":"Worker threads: 5","log.target":"pgcat::config","log.module_path":"pgcat::config","log.file":"src/config.rs","log.line":992},"target":"pgcat::config"}

debug => using the pretty formatter
  2023-07-19T05:09:59.427259Z  INFO pgcat: Welcome to PgCat! Meow. (Version 1.0.2-alpha3)
    at src/main.rs:88

  2023-07-19T05:09:59.441273Z  INFO pgcat: Running on <IP_ADDRESS>:6432
    at src/main.rs:149

  2023-07-19T05:09:59.441295Z  INFO pgcat::config: Ban time: 60s
    at src/config.rs:987

  2023-07-19T05:09:59.441302Z  INFO pgcat::config: Idle client in transaction timeout: 0ms
    at src/config.rs:988

  2023-07-19T05:09:59.441308Z  INFO pgcat::config: Worker threads: 5
    at src/config.rs:992

our current log format (for comparison)
[2023-07-19T05:18:51.976008Z INFO  pgcat] Welcome to PgCat! Meow. (Version 1.0.2-alpha3)
[2023-07-19T05:18:51.990326Z INFO  pgcat] Running on <IP_ADDRESS>:6432
[2023-07-19T05:18:51.990348Z INFO  pgcat::config] Ban time: 60s
[2023-07-19T05:18:51.990353Z INFO  pgcat::config] Idle client in transaction timeout: 0ms
[2023-07-19T05:18:51.990357Z INFO  pgcat::config] Worker threads: 5

initial PR is here: https://github.com/postgresml/pgcat/pull/517

This is pretty awesome, although I'm quite a bit annoyed because of it as well.   Fun story, this change as it rolled out broke my production infra!
So. Associated here is the warning-level message in pgcat when it's discarding a session to the pool due to "SET" being called, along with a few other things that are "warning" level logs which happen... a lot.
So. If it's fex. a PHP based backend,  which always calls "SET" to make sure fex. the output for BYTEA format in postgres is canonical,  and theres.. say, a few million calls to those functions every few minutes, we get a lot of log lines.  Almost all identical, for a behaviour we don't really care much about. ( Discard is cheaper than a tcp+tls connection, I'm cool with that.)
But, here the log filtering from RUST_LOG variable changed, so the discard filters to ignore such lines are now logged.  And well, that ate my log quota.
And that's the story of why logging is bad you should all go back to spooling logs to an unbuffered  line printer instead.
( ps. how the bleep do I filter out specific spammy warning-level messages now? )


use val y for result metric

This would've been really bad, thanks a ton for catching it! How did you come about it?

I think we would have noticed, since we rarely would have train and val sets of equal size - so it would throw an error. Used our pipe for the algorithmic fairness course - it was great! 🐒


Issues with Zig

The issue I have reported on LazyVim: https://github.com/LazyVim/LazyVim/issues/4746
Trying to figure out where is the upstream issue, I see the error messages stop showing up when I disable friendly_snippets from garymjr/nvim-snippets so I'm guessing the issue may come from here?

I have tried applying the patch provided in this PR and seems to fix it: https://github.com/rafamadriz/friendly-snippets/pull/517

Multiple PRs tried to address this actually, none of them got merged yet. The earliest I know of is #507.

Hi @alosarjos, we've merged in PR #531 which I've tested and seems to resolve the issues with Zig snippets not loading. Please pull the latest changes from main and test again.
Apologies a fix wasn't merged sooner.
cc: @Eveeifyeve

Please let me know if there is anymore issues.

Please let me know if there is anymore issues arise.

As I will make a new pr that fixes more issues.
As it was my fault that it was broken.


Updating the Documenter version

The current release is now v0.23.

Coverage remained the same at 100.0% when pulling 2fb2ae528cbba2786c11dc6af7269a56ceea3391 on Nosferican:Update-Documenter into f968c69dea24f851d0c7e686db23fa55826b5388 on JuliaLang:master.


PLT-5288: Add a generic builtin evaluation pass

Turned out to be pretty straightforward. The only trickiness was around logging: if just go naively we elminate everything that looks like trace <constant string> x, which is most calls! So I added a flag to be conservative about this and linked it to the existing conservative optimization flag.
I also pulled out the argument-splitting bit from the call-site inliner into a "application context" module, which seems to match it better IMO.
Pretty modest improvements though.

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Changelog fragments have been written (if appropriate)
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[x] Targeting master unless this is a cherry-pick backport
[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Thanks to merging COKC, the ifThenElse examples now reduce away almost entirely, which is cool. But still not that impactful.


Add Null adapter

An adapter that does nothing at all.
Useful for e.g. staging servers where you do not want emails to be sent,
but still want a valid return from deliver
The use-case that led to writing this adapter was that I have a long-running staging server, from which I don't want emails to be sent, and where using the Local adapter will lead to growing memory usage over the long term, if it's not purged periodically. Rather that setting up this purging, this adapter simply says that it sent an email, but does nothing.

Hi @brentonannan
I had a need for this too at some point, but thought about solving it in a different way, with a Logging adapter. Do you think that would work for you?

Sorry for the slow reply @stevedomin, national holiday here yesterday =)
A logging adapter would effectively do the same, i.e. not send an email, so if y'all are going to include that in the package, I'd use that in place of this. Just thought it was worth sending a PR since I already wrote this adapter for myself anyways.

@brentonannan sorry for the time it took us to come around that one, I've put a PR (#78) with a Logger adapter, hopefully that will work for you!
Thanks for sending that PR.


Linebreaks in custom use statements should display when viewing collection and work pages

Linebreaks in "Additional terms of use" do not display in the collection or work pages.
Also, users are not able to enter line returns in this field in the form using the return key.

Linebreaks display fine for abstracts, so there maybe an approach to copy from there.

Related, the "Additional terms of use" added at the work level (configured at the collection level) do not allow adding linebreaks at all. Once that is possible, the display when saved should have the linebreaks.


add ipgeolocation link

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[ ] Your submissions are formatted according to the guidelines in the contributing guide
[ ] Your additions are ordered alphabetically
[ ] Your submission has a useful description
[ ] The description does not end with punctuation
[ ] Each table column should be padded with one space on either side
[ ] You have searched the repository for any relevant issues or pull requests
[ ] Any category you are creating has the minimum requirement of 3 items
[ ] All changes have been squashed into a single commit

Hey! Thank you for that proposal and sorry for the delay.
Can you please resolve conflicts so that I can merge? Be careful about alphabetical order.

Closing this PR as I have no news on it. Feel free to reopen it if you work on it again


[Preception] Apollo 7.0 Close Perception module makes planning and prediction modules not working

Hi team,
I am using Apollo r7.0.0 to test vehicle crossover static NPC. Using perception module, the system works fine.
But when I closes the perception module and want to use obstacle_gt to test the crossover, it makes planning and prediction module not working as below shows

And I tried to open the planning module manually but find with this error
E0302 16:53:17.438055 16491 reference_line_provider.cc:205] [planning]Routing is not ready.

And the prediction and routing I thought was running.

And in the simulator, ground truth sensor works fine. The ground truth ID is e3fef197-9724-48ec-b98e-c5a0892d09c4.

And the vehicle ID is 8e776f67-63d6-4fa3-8587-ad00a0b41034. Vehicle is for apollo 6.0.

Any advice on this problem?

@Xuanye-Zhang
For the vehicle ID provided (8e776f67-63d6-4fa3-8587-ad00a0b41034), the 3D ground truth is publishing data to /apollo/perception/obstacles_gt, which might need to be changed to /apollo/perception/obstacles to get it working. You can modify the JSON file to make this change.
I might be wrong but the prediction module is probably triggered by perception messages and the planning module is probably triggered by prediction messages, which is why SimControl is publishing dummy perception messages by default.
I suggest you use vehicle 2e966a70-4a19-44b5-a5e7-64e00a7bc5de provided by https://github.com/MingfeiCheng/AV-Fuzzer/ This vehicle ID has been working fine for me.

@Xuanye-Zhang For the vehicle ID provided (8e776f67-63d6-4fa3-8587-ad00a0b41034), the 3D ground truth is publishing data to /apollo/perception/obstacles_gt, which might need to be changed to /apollo/perception/obstacles to get it working. You can modify the JSON file to make this change.
I might be wrong but the prediction module is probably triggered by perception messages and the planning module is probably triggered by prediction messages, which is why SimControl is publishing dummy perception messages by default.
I suggest you use vehicle 2e966a70-4a19-44b5-a5e7-64e00a7bc5de provided by https://github.com/MingfeiCheng/AV-Fuzzer/ This vehicle ID has been working fine for me.

Thanks! it works!
The issue is when using only 3D ground truth have to publish the 3D ground truth sensor message in  /apollo/perception/obstacles instead of  /apollo/perception/obstacles_gt.


Add regresion test for bug #2226

This fixes https://github.com/quasar-analytics/quasar/issues/2226
It ensures there will never be a regression for this bug

LGTM once you add mimir to the list as @djspiewak suggested

@jedesah ready


Use PR target for higher permissions

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

@Rugvip added a note around making sure that the script is inlined in the repo.


Getting issue with the cluster config. I am getting this error. Pls suggest. Thanks.

terraform plan
╷
│ Error: Unsupported argument
│
│   on main.tf line 13, in module "ecs":
│   13:   cluster_name = local.name
│
│ An argument named "cluster_name" is not expected here.
╵
╷
│ Error: Unsupported argument
│
│   on main.tf line 15, in module "ecs":
│   15:   cluster_configuration = {
│
│ An argument named "cluster_configuration" is not expected here.
╵
╷
│ Error: Unsupported argument
│
│   on main.tf line 24, in module "ecs":
│   24:   autoscaling_capacity_providers = {
│
│ An argument named "autoscaling_capacity_providers" is not expected here.
╵

please fill in the issue template provided so we can properly triage and help troubleshoot


Add minimal LiveView setup with a /live example page

📖 Description
This is an attempt at a minimal setup for LiveView inspired by an internal project at Mirego. We must wait for the phoenix 1.7 release to drop before merging this.

Shared templates between live and dead components (/ and /live)
No more Phoenix.View
Minimal HTML module that maps to the new HTML/JSON module in phoenix to use in controllers
Only the unified Phoenix.Flash integration needs phoenix 1.7.

The goal is to have this exact setup in a deployed project before merging it, but since the changes are not that big, it will serve as a reference for when phoenix 1.7 drops.
🦀 Dispatch

#dispatch/elixir

🦀 Requesting reviewers for this pull request:

@gcauchon (contributor with 1 commits in the last 90 days and 45 commits overall)
@JoeyBG (reviewer for the elixir stack)


Can not pull checkpoints (This repository is over its LFS data quota.)

# git-lfs pull
batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.
error: failed to fetch some objects from 'https://github.com/biboamy/TVSM-dataset.git/info/lfs'

It appears that due to GitHub's restrictions on downloading large files, the checkpoint could not be downloaded. Would it be possible to host the checkpoint somewhere else?

Hello, thanks for raising this issue. You can download the checkpoint from this path and manually put them into the repository. Let me know if this works. Thanks!

Thanks!


Update to stabilized futures_api

https://github.com/rust-lang/rust/pull/59739 was merged! 🎉
The changes will be included in the new nightly to be released tomorrow.

nightly-2019-04-25 released!


Multiple children in anchored container bug/misunderstanding?

Hi, I'm not sure if this is my misunderstanding (probably!) or a layout bug.
I'm trying to put some content in the top left and bottom left of an anchor layout container (red) inside a FlipBook (blue).
But what I get is...

...or, if I swap the order of the two children of gameplayPage (red) I get...

...but what I'm expecting is that both cyan and yellow boxes be within the red box. Nothing is expected to be in the blue area.
It feels like the first child of gameplayPage is affecting the layout of the second child somehow?
I apologise if I've totally misunderstood how layouts or children are supposed to work, or if I've missed some config from the demo code.
The simplified repro code (based on cmd/scaffold) is...
package main

import (
	"image/color"
	_ "image/png"
	"io/ioutil"
	"log"

	"github.com/blizzy78/ebitenui"
	"github.com/blizzy78/ebitenui/image"
	"github.com/blizzy78/ebitenui/widget"
	"github.com/golang/freetype/truetype"
	"github.com/hajimehoshi/ebiten/v2"
	"golang.org/x/image/font"
)

type game struct {
	ui *ebitenui.UI
}

func main() {
	// load button text font
	face, err := loadFont("fonts/NotoSans-Regular.ttf", 20)
	if err != nil {
		log.Println(err)
		return
	}

	defer face.Close()

	// construct a new container that serves as the root of the UI hierarchy
	rootContainer := widget.NewContainer(
		// the container will use a plain color as its background
		widget.ContainerOpts.BackgroundImage(image.NewNineSliceColor(color.RGBA{0x13, 0x1a, 0x22, 0xff})),

		// the container will use an anchor layout to layout its single child widget
		widget.ContainerOpts.Layout(widget.NewAnchorLayout()),
	)

	flipBook := widget.NewFlipBook(
		widget.FlipBookOpts.Padding(widget.Insets{
			Top:    50,
			Left:   50,
			Right:  50,
			Bottom: 50,
		}),
		widget.FlipBookOpts.ContainerOpts(
			widget.ContainerOpts.BackgroundImage(image.NewNineSliceColor(color.RGBA{0x00, 0x00, 0xff, 0xff})),
			// get the flipbook to fill the page
			widget.ContainerOpts.WidgetOpts(
				widget.WidgetOpts.LayoutData(
					widget.AnchorLayoutData{
						StretchHorizontal: true,
						StretchVertical:   true,
					},
				),
			),
		),
	)

	playerStatsText := widget.NewText(widget.TextOpts.Text("PLAYER STATS", face, color.Black))
	playerStatsPanel := widget.NewContainer(
		widget.ContainerOpts.BackgroundImage(image.NewNineSliceColor(color.RGBA{0xff, 0xff, 0x00, 0xff})),
		widget.ContainerOpts.Layout(widget.NewAnchorLayout()),
		widget.ContainerOpts.WidgetOpts(
			widget.WidgetOpts.LayoutData(
				widget.AnchorLayoutData{
					HorizontalPosition: widget.AnchorLayoutPositionStart,
					VerticalPosition:   widget.AnchorLayoutPositionStart,
				},
			),
		),
	)

	nofityText := widget.NewText(widget.TextOpts.Text("NOTIFY", face, color.Black))
	notifyPanel := widget.NewContainer(
		widget.ContainerOpts.BackgroundImage(image.NewNineSliceColor(color.RGBA{0x00, 0xff, 0xff, 0xff})),
		widget.ContainerOpts.Layout(widget.NewAnchorLayout()),
		widget.ContainerOpts.WidgetOpts(
			widget.WidgetOpts.LayoutData(
				widget.AnchorLayoutData{
					HorizontalPosition: widget.AnchorLayoutPositionStart,
					VerticalPosition:   widget.AnchorLayoutPositionEnd,
				},
			),
		),
	)

	gameplayPage := widget.NewContainer(
		widget.ContainerOpts.BackgroundImage(image.NewNineSliceColor(color.RGBA{0xff, 0x00, 0x00, 0xff})),
		widget.ContainerOpts.Layout(widget.NewAnchorLayout()),
		// this is in an implicit AnchorLayout from FlipBook
		widget.ContainerOpts.WidgetOpts(
			widget.WidgetOpts.LayoutData(
				widget.AnchorLayoutData{
					StretchHorizontal: true,
					StretchVertical:   true,
				},
			),
		),
	)

	playerStatsPanel.AddChild(playerStatsText)
	notifyPanel.AddChild(nofityText)

	// NOTE: ****** swap the below two lines order to see a difference in layout, but neither as expected ******
	gameplayPage.AddChild(playerStatsPanel)
	gameplayPage.AddChild(notifyPanel)

	flipBook.SetPage(gameplayPage)

	// add the button as a child of the container
	rootContainer.AddChild(flipBook)

	// construct the UI
	ui := ebitenui.UI{
		Container: rootContainer,
	}

	// Ebiten setup
	ebiten.SetWindowSize(400, 400)
	ebiten.SetWindowTitle("Ebiten UI Scaffold")

	game := game{
		ui: &ui,
	}

	// run Ebiten main loop
	if err := ebiten.RunGame(&game); err != nil {
		log.Println(err)
	}
}

// Update implements Game.
func (g *game) Layout(outsideWidth int, outsideHeight int) (int, int) {
	return outsideWidth, outsideHeight
}

// Update implements Game.
func (g *game) Update() error {
	// update the UI
	g.ui.Update()
	return nil
}

// Draw implements Ebiten's Draw method.
func (g *game) Draw(screen *ebiten.Image) {
	// draw the UI onto the screen
	g.ui.Draw(screen)
}

func loadFont(path string, size float64) (font.Face, error) {
	fontData, err := ioutil.ReadFile(path)
	if err != nil {
		return nil, err
	}

	ttfFont, err := truetype.Parse(fontData)
	if err != nil {
		return nil, err
	}

	return truetype.NewFace(ttfFont, &truetype.Options{
		Size:    size,
		DPI:     72,
		Hinting: font.HintingFull,
	}), nil
}

Oh, I've just noticed this comment in AnchorLayout...
AnchorLayout will only layout the first widget in a container and ignore all other widgets.
my bad!

No worries. In your case you may want to use GridLayout instead, with a single column and two rows. In the lower row's child, you can set
widget.WidgetOpts.LayoutData(widget.GridLayoutData{
	VerticalPosition: widget.GridLayoutPositionEnd,
})

so that it aligns to the bottom.
By the way, thanks for checking all of this out. It's still a work in progress and documentation is still incomplete or inaccurate. Sorry about that.

By the way, thanks for checking all of this out. It's still a work in progress and documentation is still incomplete or inaccurate. Sorry about that.

My pleasure, thank you for making it! :D Hopefully I'll get to a point where I can pitch in and help.

I'm getting close to what I'm after using the GridLayout \o/

Looking good. For floaty stuff, there's also Window if you need it.


Install a binary from a cached file option?

Hey, is there an option to install a nodejs binary from an already downloaded file, not without downloading it each time from a remote url? It would definitely save time.

If I had to do this kind of thing, I'd use this kind or url :
file://my/local/file.tar.gz
file:// is a valid url and it's a local one :)
Can you test it ?

Assuming this means a file already on the node.

Marking as low priority unless someone speaks up.


[SECURITY] Update Go versions to the latest minor versions for Ubuntu virtual environments

Tool information

Tool name: Go
Add or update? Update
Desired version: See below
Approximate size:

Bug:
As I noted in https://github.com/actions/setup-go/issues/39#issuecomment-590754775, all minor revisions of installed Go versions, e.g. in Ubuntu 18.04 image, are out-dated:

Go 1.11 (installed version: 1.11.12, latest version: 1.11.13)
Go 1.12 (installed version: 1.12.7, latest version: 1.12.17)
Go 1.13 (installed version: 1.13, latest version: 1.13.8)

All never minor releases of the respective Go versions contain fixes for security vulnerabilities, so this becomes a security issue.
Virtual environments affected

[ ] macOS 10.15
[x] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

NOTE: I didn't check the versions of Go in macOS or Windows virtual environments.
Can this tool be installed during the build?
Yes, using the setup-go action, but it takes an order of magnitude more time than using a pre-installed version.
See https://github.com/actions/setup-go/issues/39 for details.
Are you willing to submit a PR?
Yes, it should be a trivial change, e.g. for Ubuntu 18.04, to:
https://github.com/actions/virtual-environments/blob/51d02f26f42e53bb963bb6bc9754501b28a3d2ba/images/linux/scripts/installers/1804/go.sh#L32-L34

Hello, thank you for your response. We updated default go version to the 1.14 (the latest actual  stable version) and patch versions to the latest (1.11.13, 1.12.17, 1.13.8, 1.14). Changes will be deployed to the next images rollout.
Note: @alepauly , Please pay attention, that we have improved Go installation logic so we don't need to maintain patch version manually, the latest one will be consumed automatically.

Hello, thank you for your response. We updated default go version to the 1.14 (the latest actual stable version) and patch versions to the latest (1.11.13, 1.12.17, 1.13.8, 1.14). Changes will be deployed to the next images rollout.

Great, thanks for fixing this!

Note: @alepauly , we have improved Go installation logic so we don't need to maintain patch version manually, the latest one will be consumed automatically.

This is a very good improvement since automation will prevent Go versions being outdated :+1:.

I see that the Ubuntu 1804 (20200316 update) release already contains all updated Go versions, so I'm closing this issue.


Still a problem on<EMAIL_ADDRESS>> Gulp serve after file changes not getting reflected #5395

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version:  Microsoft Edge Version 97.0.1072.55 (Official build) (64-bit)
SPFx version<EMAIL_ADDRESS>Node.js version:  v14.15.0
Windows 8.1

Describe the bug / error
In a previous post (Gulp serve after file changes not getting reflected #5395) it was mentioned that this is now fixed -- however I am stilling getting the same problem unless I add "sessionStorage.clear();"
Steps to reproduce

Create an extension for SharePoint Online using yo
Write some code
execute gulp serve
Changes are visible the first time
make some more changes to the code and refresh the same page.
the changes are not visible unless ctrl+c is applied and gulp serve is restarted having to confirm/accept all the annoying debug/script warnings.

Expected behavior
The browser page should refresh when pressing ctrl + r (with cache option disabled in devtools), instead of having to close the table make the changes and then running gulp serve again (this is not effective).

Hi @snugam - just to confirm few things:

you are creating a Command Set extension
the extension is not installed to the app catalog, you're just serving it using debug query string from localhost
Is that correct?

Few more questions:

Are you seeing that the rebuild of the project is happening in the command prompt/terminal?
Do you have the cache enabled or disabled for the Network requests?

Thanks!

Hi there,
Yes to your question "the extension is not installed to the app catalog,"
Yes to your question " you're just serving it using debug query string from localhost Is that correct?"
(to your few more Q.1) Yes, gulp serve is running, and you can see some "deployment" when I save the code.  It does also work fine when I add this line of code "sessionStorage.clear()".
(to your few more Q.2) Under devtools, cache is disabled (while devtools is open).
Hope it makes sense :)

@snugam - could you check one more thing?
Will the issue disappear if you add sw=bypass parameter to the Query String?

I have removed localStorage.clear();.
Added sw=bypass to the query string.
Reloading the page loads latest code changes.
When I counter test -
By removing localStorage.clear();.
Did not add sw=bypass to the query string.
Reloading the page does not load latest code changes.
I've also noticed that I have to re-add sw=bypass each time after reloading as it is removed after the page loaded.
Thanks again for your assistance!

@snugam  - could you share your solution with me? As I can't repro the issue.

I have created a Command Set solution using 1.13.1 generator
gulp serve
copied the debug string and pasted it to my list's page
made changes back and forth (alert in onInit, onListViewUpdated)
refreshed pages using f5, Ctrl+F5
The latest code is loaded correctly.
Am I missing something from your scenario? Maybe you have modifications in config\serve.json? For example, disabled https or default port instead of 4321?

thank you -- I believe you, it could be that I am missing something.  Because I am running the dev work on a VM the localStorage.clear() does not present a big problem;  I have sent you a connection request on LinkedIn.

To be honest, I feel a little dumb here; perhaps others can also learn from this.
I've removed the localStorage.clear() instruction saved the code, watched gulp serve do its thing; switched to the browser pressed CTRL+R to refresh AND... not new code. But, without making any changes, I thought, let me just check and see what happens if I refresh again and VOILA... the new change was there, without localStorage.clear().
I'm not sure how I managed to experience something very similar to this bug at the start only to discovery that I might have just been too quick in switching and refreshing back and forth.
thanks again @AJIXuMuK for the guidance!


Few bugs (featured image not showing) and an error found at the attribute 'clear' for my posts

Hi,
Thanks for creating this great plugin. Very easy to customise the AMP layout.
I have some bugs found:
– I have set a featured image for all my posts, but they are not appearing in the AMP page.

Google Search console shows me this error ' The attribute 'clear' may not appear in tag 'br'.' on all my posts (I am using KK-rating plugin) -> See the full code below but it gives an error for this line:

<br clear="both">.
Not important, but useful to know:

Can you also tell me how to change the language? (like this text: View Non-AMP Version). Which php-file, or it is possible to add a option to change the language on the frontend? a request for the future.

Thanks in advance! Keep up the good work. This is only plugin at the moment, with active support.

The plugin doesn't show featured images atm, this is something I also want to be implemented. If you are interested in adding it on your own site, you could copy the code from one of my recent pull requests: #82 .
As for the issue with the clear tag, AMP only allows certain tags and content to be loaded in AMP pages, so certain code will invalidate pages, it would need a similar fix to #77.


Provide an semantic equality func for apis.URL

url.URL has an unexported type (UserInfo) which causes semantic
equality to panic unless we add a custom equality function

/assign @n3wscott

/lgtm
/approve

/hold

let me move the func to the bottom of the file

/hold cancel

/lgtm


Flashing Terminal With Copy-On-Select with less in tmux

Describe the bug
With  #914 I've enabled the options key for copy-on-select on macOS.
We did run into certain situations where using copy-on-select may render the terminal unusable.
To Reproduce
Steps to reproduce the behavior:

Start a tmux session in ttyd tmux
Open output with less e.g echo  'hello world' | less
Double click (left mouse button) a word.

Selecting output within the pager less with a double-click (left mouse button) renders the terminal unusable.
Curiously the pager more  seems not to be affected.
I've used strace and attached to the less process which seems to loop constantly on the input.
Environment:

OS: [e.g. macOS 12.4]
Browser: [e.g. Chrome  102.0.5005.61]

Solution
Disabling the xterm.js option altClickMovesCursor seems to fix this issue.

[ ] Check what the option altClickMovesCursor is good for at all.
[ ] Check if it can be disabled safely.

I can send a pull request.

I've seen comments on your commit saying that it may break something too.
I'm going to revert this commit, you can always re-enable it with Client Options without changing ttyd's code.

You're right. Thanks for the hint - I'll  use the client options then.


Fix golint issues in maya/orchprovider/orchestration.go

File: maya/orchprovider/orchestration.go
Line 1: warning: package comment should be of the form "Package orchprovider ..." (golint)
Line 13: warning: comment on exported type OrchestratorInterface should be of the form "OrchestratorInterface ..." (with optional leading article) (golint)

Resources:
-> Contributors guide: https://github.com/openebs/openebs/blob/master/CONTRIBUTING.md
Complexity: Easy

I am interested in this issue.

@ABHIYANSHU, @ashishranjan738 Sorry for not informing, but I have already made required changes, making a PR in a bit.

I have committed the changes in the fix-docs branch


Fix inlinebutton With func

the InlineButton With func returned a new button with it's url property mangled (t.Text instead of t.URL)
this caused telegram to respoind with 400

Good catch, thank you!


add ilok-license-manager

Adding a new cask

[x] Checked there aren’t open pull requests for the same cask.
[x] Checked there aren’t closed issues where that cask was already refused.
[x] When naming the cask, followed the token reference.
[x] Commit message includes cask’s name.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.

Thank you.I have changed the uninstall method.

I have changed the pkgutil to the array. Thank you.


Make Laravel 6 compatible

This PR makes the package compatible with Laravel 6 along with a few other changes.

Set the minimal php version to 7.4 because of the usage of typed properties
Fixed a issue that the trait HasApiTokens was not correctly implementing the ISanctumUser->currentAccessToken()
Changed the way the config files behave

Use a seperate config (sanctum_orm) to do this packages configuration
Fixed a missing tag that caused the config to no be published correctly when following readme
Added a mergeConfig so that users that don't have a specified all config options will automatically fallback to the default

**Because the config file got renamed to no longer conflict with the default sanctum config file, this PR breaks backward compatibility. **

Some of the testcases are broken because they are still using the old config values, i will fix these because currently this repo does not have automated actions.


request.status is not a fonction

Hello,
After launching the server and authenticating myself. I have this error when I call this route: /api/node/list
request.status is not a function in router.js file

I've made a pull request to fix the error, but this still won't give you access to /api/node/list if the request is not performed locally.


About the visualizations of the paper

Hello, @mingu6 @oravus ,-I really appreciate for your work！Congratulations :)
The visualizations(like Figure 4(b) Example VPR alignment and Figure 9 Additional example localisation output for the VPR experiments selected from the test set.) in the paper look great. Currently I want to try to implement them but I failed. Is it convenient to provide the relevant implementation code?Of course, detailed guidance would be better.
I am always looking forward to your kind response.
Best regards.

Hi,
Thanks for taking interest in our work. I have uploaded a new notebook named qualitative_figures_vpr.ipynb in the root folder of this repo. You will need to install tilemapbase (for the osm maps) and utm and do some manual adjustments to get the plots looking nice.
To produce data for plotting however, you will need to alter the train/test script for the VPR task to generate output. On top of the traverse name, you will need the ground truth xy coordinates for the query, reference traverses and furthermore, you will need the predicted xy coordinates from the alignment step. Each set of xy coordinates should be stored as a 3D tensor (num sequences, seq len, 2).
Hope this helps.
Regards,
Ming


[WIP][DO NOT REVIEW] Test app armor issue

Ah, hmm.. yes, I think https://github.com/containerd/containerd/pull/5519 is wrong, as this implementation was explicitly different than the one in libcontainer, because containerd (and moby/docker) need to set up / load the profile, whereas runc only has to apply it.

I assume we are done with this testing PR given the root issue is now fixed?


subgraph typings generation error

When doing e.g. npm start:
.../components/%40shared/PoolTransactions/index.tsx: Variable "$user" is never used in operation "TransactionHistoryByPool".
Validation of GraphQL query document failed

won't be an issue after we merge this https://github.com/oceanprotocol/market/pull/1288


updates readme and adds example

Addresses part 1 of #2.

ping @diasdavid

Oh i had indeed missed this one. Thank you for pinging :)


README does not reflect latest release

0.970.0 is not mentioned

This repo is deprecated. Have to move to attic.


x/tools/internal/imports: tests failing on TryBots

9/10 of the TryBots are failing on the TestNoMainModule test for goimports.
Log: https://storage.googleapis.com/go-build-log/b3365264/freebsd-amd64-12_0_699c4d43.log

Clearly related to https://golang.org/cl/179998 but I can't reproduce the problem.


Playground: Live-editing code

Today, our playground is static - the code shown alongside the examples is read-only. This is unfortunate, because it is so tempting to edit it!
@thangngoc89 showed the Reason world how this works with sketch.sh- based off the incredible work on the js_of_ocaml toplevel - a demo of it in action here: http://ocsigen.org/js_of_ocaml/toplevel.html#version=4.06.0
It seems like we'll need to expose an entry point for the playground with JsooTop provided by the js_of_ocaml-toplevel package.
Each example is a module that provides a render: unit => component function. We'd need to figure out how to execute that 'function' in the context of the top-level, and wire up the example to read from it.
One concern is that it is easy to write code like while(true) { ... } that could halt / stop the browser. sketch.sh sandboxes this by running the code in a worker, but unfortunately I don't think that is (trivially) workable for us. Perhaps there is a way we could extract that render function to a worker?
Some additional links I found interesting while learning / pursuing this space:

Documentation for Jsoo top level: https://ocsigen.org/js_of_ocaml/3.1.0/api/JsooTop
@thangngoc89 's sketch blog posts:

Part 1: Introduction
Part 2: The Engine

@thangngoc89 's posts are a must read - they go over other critical pieces, like how to interpret errors, how to support ReasonML syntax, etc.
Some other items to think about:

We'll need to 'invert' the flow for running the examples. Right now, we compile the examples and run them - but in this new model - we wouldn't need to 'pre-compile' the examples - we'd compile them in the browser and dynamically call that render method some way .
We'll need to figure out how to handle errors. If we can get line numbers - the monaco editor supports error decorations that can be helpful.
We'll need to update our Monaco editor initialization logic here: https://github.com/revery-ui/revery/blob/7ff96ebab393c1d76f7cbda4d82900c8a7bb0ace/playground/src/index.html#L76 so that it isn't read-only, and that we respond to code changes.

Build instructions for the playground are available here: https://github.com/revery-ui/revery/tree/master/playground

Can I add a pr if this change has to be done?

Hi @nik72619c ! A PR for this would be very welcome 👍

Cool...would just set this flag mentioned

Filed the PR @bryphe kindly check !

@nik72619c Curios. That PR makes things more confusing :)

This work has been moved here: https://github.com/revery-ui/revery-playground
And the latest playground (now with editable code!) is here:
https://www.outrunlabs.com/revery/playground


Tracing TCP

Background

We are implementing tracing from the very edge of our platform.
We support HTTP protocol as well as several TCP based protocols (e.g. SFTP, HTTP Tunneling, straight TCP streams etc).

Problem
We want to have all requests (HTTP and TCP) traced throughout our system from the edge. The TCP streams are encrypted. We cannot attach trace data to each request.
Proposal
We believe that there is value in exploring using a TCP header similar to PROXY Protocol to inject a TCP header.

The PROXY protocol provides a convenient way to safely transport connection
information such as a client's address across multiple layers of NAT or TCP
proxies. It is designed to require little changes to existing components and
to limit the performance impact caused by the processing of the transported
information.

The PROXY header is injected into the TCP packet and looks something like this

PROXY TCP4 <IP_ADDRESS> <IP_ADDRESS> 56324 443\r\n

We want to propose something similar like this

TRACE b9c7c989f97918e1\r\n

We've seen other people ask if this is possible

https://github.com/coredns/coredns/issues/624
https://github.com/opentracing/opentracing-java/issues/292

I haven't seen a proposed solution yet.
Questions to address

Is this a reasonable idea?
Should this be proposed as a standard implementation similar to PROXY protocol?
Does this work if we have a long-lived TCP connection?
Does this correlate with https://www.w3.org/TR/trace-context/

Are you sure referring to this as "TCP Header" is accurate?  Afaik TCP Header structure is predefined by the TCP spec. What PROXY protocol seems to be doing is sending a specialized payload upon establishing a connection - a mechanism that is not fully transparent to the receiver, i.e. the receiver needs to actually support that or be confused by the incoming data stream. Please correct me if I am wrong, as I only briefly skimmed the PROXY spec.
Another issue is that tracing headers need to be sent on per-request basis, not just upon establishing the TCP connection.

Are you sure referring to this as "TCP Header" is accurate?

probably not, that's just my attempt at using a familiar nomenclature. in the above link it's described as

"header" or "PROXY protocol header" is the block of connection information
the connection initiator prepends at the beginning of a connection, which
makes it the sender from the protocol point of view.

I'm not sure what term would work better but hopefully this conveys the concept accurately. happy to edit the description to something that's more technically accurate if there's a suggestion available.

i.e. the receiver needs to actually support that or be confused by the incoming data stream

this is correct. the receiver of the tcp stream needs to be aware of how to parse this.

Another issue is that tracing headers need to be sent on per-request basis, not just upon establishing the TCP connection.

yeah, I raised this as a question in the original post too. for our company this is an acceptable tradeoff. using http connect tunnels as an example, we could establish the tcp trace id as the parent trace id for the tunnel and then the requests within that tunnel could be treated separately or as children.
I definitely understand there's some issues to solve or trade offs to accept to make it work, do you know of any other strategies for achieving this? We deal mostly with encrypted data and a lot of non-http payloads so parsing the payload and injecting a header isn't always an option.

You can try it, but I don't think the mechanism is generic enough, especially given one-per-connection limitation that's not going to work for many users.


Horizontal Population Chart

Dears,
Please help me to create a horizontal population chart, I tried to create one but it is showing me - [Negative] and + [Positive]
Where as I want to show the graph as one side Male and other side Female value.
Appreciate help and support.
https://user-images.githubusercontent.com/91035/92748341-b6246c00-f38d-11ea-8029-2068f64259ce.png
Please find the script I am using,

@AnilChitatil I don't know if this is what you would like to have but you can use ticks callback in order to have absolute ticks values on scale.
      xAxes: [{
           ticks: {
               callback: function(value, index, values) {
                     return Math.abs(value);
                }
           }
      }]

See here CodePen: https://codepen.io/stockinail/pen/gOrKXYY

Thanks @stockiNail. I think that is the best way to achieve this


Description of the kinds of data hosted on Landing Page

User story: (1.2) I want to see the description of the kinds of data hosted (e.g., type and count), so that I can quickly get an idea of what I might find
Tasks

[ ] total count of datasets
[ ] total count of species
[ ] total count of tomograms

The count will auto update as new datasets are added
Link to design: https://www.figma.com/file/WEmbsjtlBUtRy7pzmuCCjj/CryoET-Data-Portal---Phase-2-Designs?node-id=1929%3A65457&mode=dev

no pointing because this is accounted for in #26 of 6 points

Screenshot from design:


Provide a semantic meaning to eq function Sentences when other parameter is a string

Thanks for your contribution. Your pull request is accepted and will be available with the next sadedegel release.
Please check commit logs of commit 0ead1f9d8361828c64a2bc7b9866a475ed52c149
Note that this issue will be automatically closed by Github once the master branch is updated.


Feature Request: Add EXR

Hi,
Is it possible to add open exr to your list of supported formats?
Thanks,
Ciprian

Hi, unfortunately it's not supported natively by Ps, as far as I'm aware of. So that would be no, sorry.


Make generated JSON Schema available in PR

Just paste all generated schema into the log of the GitHub Action. Could be improved by pasting only the schema of the specific object type, that is contained in PR.

New group 'Output generate JSON Schema'

alternatively/supplement by adding it as an artifact to the run
https://github.com/actions/upload-artifact


Are there any plans to allow other testing frameworks to be plugged into DevOps?

Since CodedUI is kaput

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b6c92a2-2f5c-e34e-f285-3e1a2a02604b
Version Independent ID: 6f31f4c2-94ac-20eb-da01-e1d47f041945
Content: Run automated tests from test plans - Azure Test Plans
Content Source: docs/test/run-automated-tests-from-test-hub.md
Product: devops
Technology: devops-test
GitHub Login: @steved0x
Microsoft Alias: sdanie

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@WilliamAntonRohm - if what I am asking for is already present and possible, then this is probably a documentation issue because I cant find info about it. If its not already present this is a product roadmap or feedback item.
Have you tried to use that support bot before? Try asking it something with a simple yes or no answer like "Can I override config file settings in an app Service?"  (yes, you can).
This question would not be a good fit for Stack Overflow.


Made style combination as easy as SCSS, and makes karax the most lightweight and efficient web frontend framework,including Web APP and SSR

SCSS:
#scss file, needs an additional compilation
.problems {
  text-align: center;
  img,
  span {
    display: block;
  }
  img {
    margin: 10px auto;
  }
}
# nim code
for p in problems:
    tdiv(class="problems"):
        img(src = imgagePrefix & "tick.png")
        span(): text p

vs
#pure nim
var problemStyle = "text-align:center;"
for p in problems:
     tdiv(style=problem):
          img(style=problem&"display:block;margin: 10px auto;",src = imagePrefix & "tick.png")
          span(style=problem&"display:block;"): text p

Implementation also enhances SSR. You can run either run nim js --hints:off main.nim get its performant VDOM features or run nim cpp -r --hints:off main.nim to get its SSR version of the current VDOM tree with
template kxi*(): int = 0
template addEventHandler*(n: VNode; k: EventKind; action: string; kxi: int = 0) =
    n.setAttr($k, action)

import karax / [karaxdsl, vdom, vstyles]
template kxi*(): int = 0
template addEventHandler*(n: VNode; k: EventKind; action: string; kxi: int = 0) =
    n.setAttr($k, action)
var fullScreenStyle="width:100%; height:100%;"
let main: VNode =
  buildHtml tdiv(id="main",style="width:100%; height:100%;", onclick="click(this)")#implement click in some js file
 #buildHtml tdiv(id="main",style=fullScreenStyle)
echo main

I don't think this adds anything, this:
buildHtml tdiv(id="main",style="color:blue; text-align:center")

Can be written like this:
buildHtml tdiv(id="main",style={color: "blue", textAlign: "center"})

While still being short and very readable. I'm not against this change but it seems unnecessary to me when Karax has special support for styles.

It confirms to intuition of many web frontend developers, reduces additional learning overhead. Some styles has to be variant to avoid reserverd keyword float like cssFloat.
It provides convinience when rewriting applications in Karax, copy & paste is efficient and error resistant.
Besides, it's the same purpose with your PR, we long for this for a while, and thanks to your PR inspiration to have me done this finally.

Hi Zed,
     tdiv(onscroll=scrollEvent, style=style(
         (StyleAttr.height, cstring"400px"), (StyleAttr.overflow, cstring"scroll"))):

(from the scrollapp sample)
can it be rewritten somehow?

@dvska sure
tdiv(onscroll=scrollEvent, style={height: "400px", overflow: "scroll"})

This works because the {k: v} construct in Nim creates tuples of tuples, so the above results in the same as the example given.

I do

Why don't you make a separated README file in Chinese?

I do here , https://github.com/gogolxdong/karax

I think it maybe a bit harder to use link css in karax native.But I can't find a reasonable solution.
Now, I can only think of a helper function to generate helper Html Once when the view function is used.
Code in https://github.com/planety/kview


sketch out genesis predeploy check

Towards #372
To get this over the line, I think the blockers are as follows:

We need a good "ground truth" for what the standard predeploys actually are. I would have thought OP Mainnet, but then:

    superchain-genesis_test.go:75:
                Error Trace:    /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/superchain-genesis_test.go:75
                                                        /Users/georgeknee/code/ethereum-optimism/superchain-registry/validation/validation_test.go:80
                Error:          Should be true
                Test:           TestValidation/OP_Mainnet_(10)/Standard_or_Standard_Candidate_Chain/Standard_Genesis_Predeploys
                Messages:       Genesis does not contain an account for 0x4200000000000000000000000000000000000019

We need to fill out all of the expectations into a TOML file, read in and loop over them in this test
Exclude (exclusions_test.go) or downgrade any chain failing the check

For OP Mainnet, or in fact for any chain, if the genesis allocs are not present we have the option to go on chain (L2) and query for the information.


Menu icons are missing on 2.6

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Version Information:

Device: [e.g. reMarkable 1]
OS: [e.g. <IP_ADDRESS>]
Version [e.g. v1.3.3-beta]

Additional context
Add any other context about the problem here.

Could you fill out the issue template please


Add steps (server)

Context
This PR adds the server-side code of the PennyLane-Orquestra plugin. It is stand-alone from other parts of the plugin (and can be reviewed as such).
As part of Orquestra convention, workflows that are submitted to Orquestra must contain step definitions. A step is basically a piece of code to be executed and it can be made available by publishing it on a public repo on GitHub. Once done, it can be defined within workflows and Orquestra will pull the source to execute the given step.
Changes
Add the run_circuit_and_get_expval function inside of steps to define an Orquestra workflow step. As its name suggests, this function runs a circuit and computes the expectation value of operators.
Its inputs are:

backend_specs (dict): the parsed Orquestra backend specifications
circuit (str): the circuit represented as an OpenQASM 2.0 program
operators (str): the operator in an openfermion.QubitOperator or openfermion.IsingOperator representation

Further notes

The step definition is meant to integrate with Orquestra interfaces (in specific with QuantumBackend and QuantumSimulator) and involves calling high-level functions. This is meant to preserve current and future modularity provided by Orquestra.
run_circuit_and_get_expval includes applying the identity in cases when an empty circuit was provided or when a qubit is measured where no gates were applied. This is a temporary convenience to allow working with certain Orquestra backends.
Certain viable features (e.g., supporting noise models with Qiskit devices, allowing sampling) are left as future additions.

Thanks @thisac for the comments! :slightly_smiling_face:

Thanks for all the comments and reviews! :confetti_ball: Merging it for now, but can revisit if need be.


XrplClient unusable with xrplcluster.com

https://xrplcluster.com runs behind Cloudflare, whose firewall prohibits requests whose User-Agent request headers contain the . character. The User-Agent header included in XrplClient requests makes Cloudflare upset because it contains periods, so no requests are allowed through.
All we have to do to make this fix is augment the outgoing User-Agent header in JsonRpcClient doing something like this:
okhttp3.OkHttpClient okHttpClient = new okhttp3.OkHttpClient.Builder()
      .addNetworkInterceptor(chain -> {
        final Request request = chain.request();
        final Request fooUserAgent = request.newBuilder()
          .header("User-Agent", request.header("User-Agent").replaceAll("\\.", ""))
          .build();
        return chain.proceed(fooUserAgent);
      })
      .build();

return Feign.builder()
      .encoder(new JacksonEncoder(objectMapper))
      // rate limiting will return a 503 status that can be retried
      .errorDecoder(new RetryStatusDecoder(RETRY_INTERVAL, SERVICE_UNAVAILABLE_STATUS))
      .decode404()
      .decoder(new OptionalDecoder(new JacksonDecoder(objectMapper)))
      .client(new OkHttpClient(okHttpClient))
      .target(JsonRpcClient.class, rippledUrl.toString());

@nhartner Worked with someone at XRPL Labs to change the cloudflare rules, so this is no longer an issue.


[feature]: 0conf anchor restriction is needlessly limiting

The current 0conf anchor requirement, as I understand it, only applies to lnd as the funder, not lnd as the fundee. 0conf is generally primarily useful in an LSP-client model where the LSP funds a 0conf channel that the client accepts. In many cases lnd is used as an LSP on a server, however its relatively rare, afaiu, for lnd to be used as an LSP client (ignoring the general "buying inbound liquidity" stuff, which isn't always/usually 0conf). Thus, the 0conf anchor restriction applying on funding (but not fundee) is somewhat backwards - the primary use of 0conf in lnd (AFAIU) is where lnd is the funder, opening a channel to, eg, LDK or greenlight clients (though I believe that's always CLN as the LSP), not the other way around. Thus, the anchor restriction as it stands makes the 0conf feature in lnd not very useful for its primary potential use-case, as far as I can see.

If LDK is the fundee and LND is the funder, then changing this makes sense - thoughts @Roasbeef ?


Checking that the return value of every store function inside compose…

…Stores is not undefined

@honzatrtik @gaearon I feel this is only needed during development. I think it would be best if we don't have this check in production. Wrap the whole thing in
if (process.env.NODE_ENV === 'production') {
 // code here
}

Instead of just changing the error type. It will make production performant and not need to go through unnecessary code checks.

I gave this some thought. This change might cause some issues. If someone has runtime type checking in their reducers, this will cause an error.
Also, If they have some type of reducer that counts the number of actions that go through the reducer no matter the action. This change will make their code always show a warning.
If we don't think either of those are likely, then the benefits outweigh those downsides.

If someone has runtime type checking in their reducers, this will cause an error.

What kind of type checking are you referring to?

If they have some type of reducer that counts the number of actions that go through the reducer no matter the action.

Reducers must be pure in Redux. That's a hard constraint but it's not currently enforced. It's better if we log a warning than just behave weirdly.

What kind of type checking are you referring to?
There are libraries that convert Flow/Typescript type definitions to runtime checks.

I am not sure if default Flow would allow this to pass if your reducer function doesn't have type Object for state.
For instance in the counter example, the reducer always expects a number type state. This check is passing an object to all reducers.

Oh, I see now.. I haven't really thought about Flow in the context of this change.
Let's hear others' thoughts about this.

My suggestion: pass undefined as the state and make sure the returned result is not undefined.

Thanks for the food for thought.
I don't plan to merge this PR as is because it is superseded by #191.
Please let me know if you would like to implement #191 (throw if undefined is returned) instead.
Sorry for the churn!

Yup, i will try to implement #191 & apropriate tests tonight...

I think @taylorhakes is working on this already: #193

oh, i see! ok then.


http: fixing up CONNECT to be RFC compliant

Risk Level: Medium (data plane changes)
Testing: updated tests
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.use_rfc_connect
Fixes https://github.com/envoyproxy/envoy/issues/20378

cc @howardjohn

also @moderation if you have thoughts please feel encouraged to do a pass as well

@snowp ping?


Mod does not work on 1.19.3

Describe the bug
When launching Minecraft 1.19.3 with Minecraft Railroad Blocks installed, Minecraft will refuse to launch.
To Reproduce
Steps to reproduce the behavior:

Go to Minecraft
Ensure you are on version 1.19.3
Launch Minecraft
See error

Expected behavior
Minecraft should boot normally and the mod should load.
Additional Information:

Minecraft Version: 1.19.3
Mod Version: 0.3.1
Fabric Loader Version: 0.13.12

Additional context
This has been determined to be caused by a change in Minecraft's code. Specifically, the location of the register in Minecraft has changed, and the mod must be updated to correct the issue.

Users must update to this version before updating to Minecraft 1.19.3+.


Incorrect code line

There is a code line, that leads to an error (appendChild error, as container cannot contain itself), so this should be removed:
container.appendChild(this._container);

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3fc8bc19-4e5e-b6f4-34ef-77b004c2afd6
Version Independent ID: 847c467c-0015-1eb9-bdc7-720a40f1cdba
Content: Create your first component using Power Apps Component Framework - Power Apps
Content Source: powerapps-docs/developer/component-framework/implementing-controls-using-typescript.md
Service: powerapps
GitHub Login: @Nkrb
Microsoft Alias: nabuthuk

this._container and the locally scoped container variable are not the same; the code should work as it is.


Division: use twbs/rfs for backward & forward compatibility

Follow-up to @stof's suggestion at https://github.com/twbs/bootstrap-sass/issues/1226#issuecomment-1056845983. Adopts the https://github.com/twbs/rfs library to handle division in a forward- and backward- compatible fashion in both libsass and dart-sass. Reverts devDependency pin to node-sass.
I am not convinced that merging this in favor of math.div() is the best choice, but since it is a marginally viable proposal, I felt like I should put the option up for consideration. This suggestion follows in the footsteps of Bootstrap 4 and 5, but I do want to note that more serious breaking change around @import are scheduled for October, and we will have to make a clean break with libsass by then in any case — either with a "3.5" release, or with a fork.
See also
https://github.com/twbs/bootstrap-sass/issues/1217
https://github.com/twbs/bootstrap-sass/issues/1219
https://github.com/twbs/bootstrap-sass/pull/1221

I wanted to open this PR because it seemed like a viable suggestion and follows in the footsteps of Bootstrap 4 and 5, but I also want to note that this sort of thing is not going to be a viable long-term strategy for forward-compatibility, as much more serious breaking change around @import are scheduled for October.

Why importing the whole RFC library (which is about responsive font sizes) instead of only the divide function ?

I just tried to do the Bootstrap 4-est thing. In truth I don't intend to maintain this branch or push for merging it, but I did want to evaluate the feasibility of an alternative to Math.div that a commenter suggested in another issue. The rest is for the maintainers to decide.

@AprilArcus the math.div replacement in Bootstrap 4 is just the divide function, not the whole RFS library (which is about a specific feature, that happens to need doing divisions)

Hi team, I just want to make sure this update doesn't break anything that depends in the previous version. Please confirm the impact.


Retrieving with get_item()

Hi there!
We've been using bloop in our project and up until now it's great. Just a question though: is there a specific reason why the library doesn't use get_item() in case the table only has a primary key and no sort key? According to AWS it's the recommended and fastest way in these cases.
Thanks!

Hello, thanks for opening an issue!  I'm really glad bloop is working well for you so far :)
Do you have a reference for the speed difference of GetItem and BatchGetItem on tables with only a primary key?  I would expect GetItem to keep its lead for loading a single item, and to fall behind immediately once the number of items to load is greater than one[0].
For anyone curious about how bloop maps a single Engine.load to one or more dynamodb_client.batch_get_item calls, here's a few references.  Because bloop will load instances of different models (possibly in different tables)[1] in as few batches as possible, the code to track table names when unpacking objects gets a little complex:

Call stack: Engine.load -> SessionWrapper.load_items -> dynamodb_client.batch_get_item -> boto3 docs
Docs: Engine.Load (User Guide), Engine.Load (Public API), SessionWrapper.load_items (Internal API)

[0] if for no other reason than the http overhead + request signing/validation
[1] otherwise you need two calls to load eg. a Tweet object and a User object, instead of engine.load(user, tweet)

Thank you for the thorough explanation. I now understand better how bloop works and realise my mistake, as in I didn't notice bloop was using batch_get_item under the hood.
I have done tests on my project comparing retrieval times of single get_item calls vs a query or a batch_get_item and indeed it's a no brainer: the single get_item calls are much worse performance-wise.

Glad things are clearer.  Thanks for opening an issue, I'm sure others had the same question.
I'm going to close this, pull requests for docs are always welcome :)