Incompatibility with tns-ios 4.0.1

Hi,
I have been happily using your nice dependency, but after upgrading from tns-ios 3.4.1 to 4.0.1 when I tap a textfield the screen go up ok, but when I press a key then, after the update, the screen go up about  20px more ...  so on an iPhone SE when the keyboard disappears then the screen goes down keeping 20px hidden by my action bar. If it matters, I'm using Angular TypeScript {N}. Thx !!

Same here.

same

Are you using a ScrollView? I found I had to wrap all my ScrollViews in StackLayouts after the 4.0.1 upgrade.

@gsmedley Thanks, but unfortunately all of them were already wrapped with StackLayouts .... so still experiencing the problem :-(

Same. Seems scrollview at top level of component should be wrapped by stacklayout (or other container, not sure)
Not worked:
<ScrollView>
</ScrollView>

Worked:
<StackLayout>
  <ScrollView>
  </ScrollView>
</StackLayout>

Finally working with the workaround and with some dependencies updates


Select List - Select All Option

Would it be possible to investigate adding a new feature to the select list.
It would be great to have the ability to turn on a "select all" option that would appear the top of a multi select list, allowing the user to select/deselect all options in a single click.

We'll be adding some enhancements after 1.0

@stap123 why was this closed?

project is dead and I was clearing old issue that will never be dealt with


chore: Delete Init.Data.Subtype.Basic

The few useful lemmas can go to Data.Subtype.Basic and the other ones can be deleted.

LGTM besides the CI error,
bors d+

bors merge

bors merge


[fix] solve various windows onedal build warnings

We have a number of these errors in the compilation stage in windows for onedal: warning C4101: 'e': unreferenced local variable
Add static casts to double type where implicit conversion had been previously done.
Following the guide of this StackOverflow post: https://stackoverflow.com/questions/24428146/catching-exception-with-unreferenced-local-variable-warning by casting to void, it will tell the compiler it is unused, but will not impact the output machine code.
Fix belt-and-suspenders setting of variable to const std::int64_t to int as required by numpy interfaces.


Enable command execution tests

Description:
$title for streaming queries, which got disable in https://github.com/ballerina-platform/ballerina-lang/pull/23252.
Steps to reproduce:
n/a
Affected Versions:
n/a
OS, DB, other environment details and versions:
n/a
Related PR:
https://github.com/ballerina-platform/ballerina-lang/pull/23252
commit: https://github.com/ballerina-platform/ballerina-lang/pull/23252/commits/a4ffb16c4c3fff283b9d92717a042451a7eddbac

Closing since this issue has been addressed.

Closing since this issue has been addressed.


Update /about and /covid, and other page styles

Updates the copy and layout for:

/about
/covid

Updates the layout & styles for:

/on-demand
/partners

Could you also update this to read:
  If you have any questions, you can call our hotline at 971-407-1829

Feel free to merge when you're ready - thank you for your help!

I also added the country code in the tel (just in case):
971-407-1829


dxx-rebirth: build with gcc6 as gcc8 is not supported

Motivation for this change
Fix the build.
https://github.com/NixOS/nixpkgs/pull/69380
https://github.com/NixOS/nixpkgs/issues/68361
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build dxx-rebirth


style selectors:  doesn't support  nesting pseudo selectors

Describe the bug
I'm new to vanilla-extract ,and when I use it with selectors, I encountered a problem, which it didn't work as I thought, I tried to search the website, but I didn't find any words to say I can't use it like this.
I'm not sure whether is a bug or feature
not working

working

Reproduction
https://vanilla-extract.style/
System Info
System:
    OS: macOS 12.0.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 92.42 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.14.2 - ~/.nvm/versions/node/v18.14.2/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 9.5.0 - ~/.nvm/versions/node/v18.14.2/bin/npm
  Browsers:
    Chrome: 112.0.5615.121
    Firefox: 108.0.2
    Safari: 15.1
  npmPackages:
    @vanilla-extract/css: ^1.11.0 => 1.11.0
    @vanilla-extract/vite-plugin: ^3.8.0 => 3.8.0
    vite: ^4.2.0 => 4.2.

Used Package Manager
npm
Logs
No response
Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

I searched such question with gpt-4, it somehow answered my question, (Need confirmation)

I searched such question with gpt-4, it somehow answered my question, (Need confirmation)

GPT-4's response is pretty accurate. Not supporting nested selectors in an intentional decision, though that doesn't mean we will never support it in the future. Given that native CSS is starting to support CSS nesting, it could make sense to support it in Vanilla Extract in the future.
Generally speaking, Vanilla Extract's docs are quite explicit about what is supported, and the types will help you avoid situations that are not supported.


nomad oasis images fails to build

I am building a nomad oasis image from my repository.
My repository:
After an update, the image fails to build with the following error:
=> ERROR [builder 4/5] RUN uv pip install -r default_plugins.txt -c requirements.txt                                                  0.9s
------
 > [builder 4/5] RUN uv pip install -r default_plugins.txt -c requirements.txt:
#54 0.839   × No solution found when resolving dependencies:
#54 0.839   ╰─▶ Because only nomad-lab<1.2.2.dev578 is available and
#54 0.839       nomad-simulations==0.0.1 depends on nomad-lab>=1.2.2.dev578, we can
#54 0.839       conclude that nomad-simulations==0.0.1 cannot be used.
#54 0.839       And because you require nomad-simulations==0.0.1, we can conclude that
#54 0.839       the requirements are unsatisfiable.
#54 0.839
#54 0.839       hint: nomad-lab was requested with a pre-release marker (e.g.,
#54 0.839       nomad-lab>=1.2.2.dev578), but pre-releases weren't enabled (try:
#54 0.840       `--prerelease=allow`)

Would there be a way to overcome this ?
Thanks in advance.

Hi !
Mi repository is here:  https://github.com/mdforti/nomad
right now, the develop branch is an exact fork of this repo. I also tried using the address of this repo on the build with same results.
some other symptoms:

the image in my repo builds when I comment all lines in default_plugins.txt, but the resulting app doesnt seem to be parsing archives.
the image in this repo fails to build with same error message.

I think the problem might be that the plugins like nomad-simulations are pointing to a version of nomad  published only in the private nomad repository. I can not confirm as I dont have access to gitlab-registry.mpcdf.mpg.de/nomad-lab/.
Hope this helps!

Hi @mdforti,
This is caused by the temporary solution we have used for our new plugins.
Can you try passing the SETUPTOOLS_SCM_PRETEND_VERSION as a build arg?
docker build . --target final --build-arg SETUPTOOLS_SCM_PRETEND_VERSION=1.3.3?

Hi ! with this option the image builds but the resulting app container is always unhealthy. When checking the container, it seems to be restarting all the time.

Before debugging this further, could I ask if there is a specific reason for creating a fork? Are you planning to make some very specific customizations that cannot be done through the nomad.yaml config file or through plugins?
I'm asking this because in a typical use case, people start from our pre-built image, and add things on top. With a fork you will have much more control, but it might end up requiring quite a lot of work to keep the code up-to-date.

I started this project long before the plugins came up. The first customization I was thinking about was on the landing page, I would like my Institute graphics to be seen and I am not sure if I can do this with Plugins. Then, in the beginning I needed to get a parser for calculating energy differences, which I know can be done with plugins but, honestly, although I am trying to learn as fast as possible, as an amateur developer I find the plugins development process quite steep. Also, my workflow was working before the plugins came up, but it is also true that I had not pulled any updates for a long time.

Could you share some logs from the nomad app container?

nomad_oasis_worker.log
nomad_oasis_app.log
I tried to get the logs of the app and worker containers. Both of them keep restarting in loop.
Thanks for the help !

Can you try again with the latest commit?

that would be the develop branch, right ?

Thanks for explaining your situation. Sounds perfectly reasonable. There has definitely been quite some flux in how the plugin system works, but we hope that this settles down now.
If you think that the modifications you have done to the UI could be reasonably added as part of our config, please let us know. I think it would not be a problem for us to add a possibility of customizing some links or graphics in the config.ui section.

that would be the develop branch, right ?

Yes.

Great ! building from the nomad-coe/nomad:develop works ! the funny thing is, the logs are from an image build with the same repo but bilt this morning probably an hour before the commit. I will try to rebase my branch and see if it still works.

@lauri-codes , I would have to check it. What I was doing was nothing too fancy, just adding a logo in the header and changing the text in the landing page of the oasis. Would it be possible to configure this way ? Actually would be much easier to get updates.

I do think that it could be possible. Could you open up an issue about your specific needs, maybe with some screenshots? We could then internally evaluate if/how those customizations should be added.

Sure, I will prepare this later.  Thank you very much for your help!


feat: add geo search input

Description
This PR adds a new GeoSearchInput component that helps users select a location, inspired by this React plugin.
Closes #2.
Notes

In order to build and test locally with sanipack, I had to install @babel/cli and @babel/core.
Should I add them as dependencies to the project, or is sanipack going to handle them in the future?

I got the styles working by copying the CSS file from esri-leaflet-geocoder's dist folder.
Then I updated them with .leaflet :global($selector) and updated the URL for images - inspired by the Leaflet.css file.
Is there any other way to accomplish the same?

This is great! Thanks a bunch!

I'll take a look at the sanipack issues.
There is a way to import CSS directly, but it results in global CSS which I prefer not to use (in this plugin), so I appreciate the effort you did to make this scoped <3

Thanks again!

This is great! Thanks a bunch!

I'll take a look at the sanipack issues.
There is a way to import CSS directly, but it results in global CSS which I prefer not to use (in this plugin), so I appreciate the effort you did to make this scoped <3

Thanks again!

Published as v1.0.1

Published as v1.0.1

Awesome. Thank you for the quick review, @rexxars! 🎉

Awesome. Thank you for the quick review, @rexxars! 🎉


Avoid intermediate arrays for other container types

SUMMARY
Another quick follow up to #713 to avoid toBitmapContainer as this has shown up on hot paths for us too.
Automated Checks

[x] I have run ./gradlew test and made sure that my PR does not break any unit test.
[x] I have run ./gradlew checkstyleMain or the equivalent and corrected the formatting warnings reported.

This passes all our parity tests internally too, so should be good to go now!

This looks good to me, merging.

Thanks @lemire!


Update setuptools

Cryptography requires a recent setuptools to install

Codecov Report

Merging #1537 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1537   +/-   ##
=======================================
  Coverage   54.23%   54.23%
=======================================
  Files        3584     3584
  Lines       88223    88223
=======================================
  Hits        47845    47845
  Misses      40378    40378

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129f314...48abbac. Read the comment docs.


In-place merge sort

Regarding MergeSort.java
In the source code comments, it states "Space: In-place." and according to "In-place algorithms" wikipedia states
"an in-place algorithm (or in Latin in situ) is an algorithm which transforms input using a data structure with a small, constant amount of extra storage space.  The input is usually overwritten by the output as the algorithm executes."
However, in line 47 of the code the output array is used to merge the left and right half and is later used to overwrite the input array.  This takes O(nlogn) extra space which is not constant.

@timiscoding Thanks for the note. I initially coded it using extra space with the assumption that I'd get back to it at a later stage and code an in-place version; I obviously forgot to get back to it. But your issue has brought it to my attention. So, I coded up an in-place version of merge sort and committed it.


Overhaul ngtx core api

[ ] Make queries chainable
[ ] Allow lazy queries

This issue is already implemented now.


Missing alternative names for GB and US

Thanks for the PR!
Could you please remove the changes to Rakefile and lib/countries/cache/countries.json?
We regenerate the cache before a new release, otherwise it's a constant source of merge conflicts, and the Rakefile change appears to be unrelated to this PR.

Could you please remove the changes to Rakefile and lib/countries/cache/countries.json? We regenerate the cache before a new release, otherwise it's a constant source of merge conflicts, and the Rakefile change appears to be unrelated to this PR.

With lib/countries/cache/countries.json it is clear, but what is wrong with  Rakefile? The change is to keep the order of the keys in lib/countries/cache/countries.json.

Ok, the Rakefile change makes sense, but please see https://github.com/countries/countries#please-do-not-submit-pull-requests-on-cache regarding lib/countries/cache/countries.json

Additionally, reverting lib/countries/cache/countries.json breaks the specs…


fixed the main bug in the production server

Just allow my code please I just fixed the most annoying bug in the server

Dude I fixed the production server bug just imagine that

That is awesome 🤣


GPII-3718: Set new exekube version

This PR updates the exekube version which includes the latest providers available for Terraform 0.11.
This PR depends on https://github.com/gpii-ops/exekube/pull/74

LGTM


Create Some Other Models

[ ] Create the Message model
[ ] Create the Comment model

[x]  Create the Message model
[x]  Create the Comment model

Done with this issue...


add functionality to Demag GUI for averaging multiple measurements

Currently, the only option for averaging multiple measurements at the same treatment step appears during the initial conversion of magnetometer files to MagIC format. Even then, the conversion scripts are pretty inflexible as they require you to make the choice between importing everything and averaging for all replicate measurements in the dataset.
It would be great if Demag GUI provided the option to selectively average "good" replicate measurements for each sample in addition to the "bad measurement" flags already available. It seems that implementing this in the GUI could be tricky though. @Caoimhinmg what do you think?

@lfairchild this would not be a trivial thing...Demag GUI is very much set up so that modifying the measurements file is not done beyond writing a b or g in quality. I'd either need to hack this in with a custom session file keeping track of what to average (of course then this wouldn't get published in MagIC) which I'm reluctant to do. Alternatively something would need to be added to the vocabulary to indicate to Demag GUI that 2 measurements should be averaged, unless we want to remove lines from the measurements file which is less than ideal as you cannot unaverage a measurement if the user changes their mind. @njarboe, @rminnett what do you think about the vocabulary thing? This might be a good addition as it could modify how the current importing scripts are handling averages which is by only reporting the average measurement, which involves a loss of information as explained above.

@lfairchild and @Caoimhinmg, let me know if I should leave this issue open, since it has not been touched in over a year.

I'm closing this issue.  If someone wants to work on it, go ahead and reopen.


How are we handling app logging? distributed tracing?

Describe the task
How are we handling app logging? distributed tracing?
Distributed tracing has tools for it, but at a minimum we can use GUUID so we can track transaction across services.
Can we look at Kibana, but only keeps data for 2 weeks (hard limit).
Log levels!  Winstonjs for example.
Acceptance Criteria

[ ] what is required for this task to be complete?
what is the finishing point or end state of this task?
[ ] what is the output of this task?

SME/User Contact
(may want to use a persona to fill this in)
Additional context

any additional details that could not be captured above

Implemented logic to pass a unique id as request id in http request header while calling backend API and backend will create log along with this request id.  Also updated backend code with Winston logging.


com.google.fonts/check/varfont/bold_wght_coord doesn't distinguish between "no Bold instance" and "Bold instance wght != 700"

Observed behaviour
com.google.fonts/check/varfont/bold_wght_coord fails when there is no Bold instance present, using the same status code (wght-not-700) as for when the Bold instance's wght coord is not 700, for example:
     FAIL The "wght" axis coordinate of the "Bold" instance
          must be 700. Got None instead. [code: wght-not-700]

Thus the check effectively enforces that a Bold instance must be present which some profiles might wish to override, while retaining enforcement of "if a Bold instance is present, its wght coord must be 700".
Expected behaviour
It would be better to have a separate status code for the case of "no Bold instance" to enable profiles to override the different conditions should they wish to selectively enforce this check (for example, WARN on "no bold instance" but still FAIL on "bold instance is present but its wght coord != 700").
Resources and exact process needed to replicate
Run fontbakery check-adobefonts (or other profile that uses this check) on the attached nobold.otf.zip which contains a wght axis but has no "Bold" named instance. Observe the failure with message "The "wght" axis coordinate of the "Bold" instance must be 700. Got None instead. [code: wght-not-700]".

The fix is included in pre-release v0.8.11a1. You can install it with this command:
python -m pip install --upgrade --pre fontbakery'[freetype]'


Research how to switch SQLite db connection when we switch projects

Based on the comment:

when we change projects, we disconnect the sqlite_lci_db object from one SQLite database (file), and attach it to another one. This is tricky because it currently works fine, but after projects is stripped out bw2data (and hence sqlite_lci_db) doesn't know that the project has switched. You probably also saw that there are some other JSON or pickle files which also need to be re-read, but we are switching towards storing everything in the SQLite database. So I think there has to be some hook in bw2data which is called when the user_data_dir is changed, and another for the logs directory.

Related to https://github.com/brightway-lca/brightway2-data/issues/98

There are two main SQLite databases to be aware of:

A database which stores information about projects. This we keep and port to bw_projects. bw_projects also therefore needs to use appdirs to know what directory this database is stored in.
A database which has project-specific data. This is the database which make life tricky - to allow bw2database.Database (a Peewee Model) to just work when we switch projects, we defer the binding of the Peewee model, and the use the SubstitutableDatabase class to allow us to dynamically switch the SQLite database file.

In the future, bw2data will try to import bw_projects, and then add the substitutable database from the second item to a registry of databases in bw_projects which need to be modified when switch (currently set_current, but I like switch or something similar more) is called.

Existing solution using [SubstitutableDatabase](https://github.com/baali/bw_projects/blob/main/bw2projects/sqlite.py) works. We need to evaluate or follow up on is this the best approach and if there are more options available.

We don't need to solve things for other libraries building on bw_projects, we will execute the registered callbacks, the other libraries are responsible for their behaviour.


Pin tab is closed when github notifications are closed

Step to reproduce:

pin a tab
make sure the pinned tab is selected
click on notifier button
github notifications tab is open
press Cmd-W (or Ctrl-W)
github notifications tab is closed
pin tab is closed too

I am unable to reproduce this, could someone else on a mac see if they can? (I'm not on one)

I can't reproduce this either, and I'm on a mac.
@paulrouget is it reliably reproducible? Try disabling other extensions (turn only this one on in incognito mode to disable the others).

Sorry - my initial assumption was wrong. I've updated the Step To Reproduce.

I was able to reproduce it, will look into the cause.


MB-4198 Document viewer long filenames overflow with ellipsis

Description
This pr changes the text overflow style on the document viewer menu. Ellipsis will now show if the text overflows.
Reviewer Notes

This PR addresses the issue on IE11 where the document viewer height was shrinking to 0. Check out the resource article below.
The document title will also have ellipsis.

Setup
Add any steps or code to run in this section to help others prepare to run your code:
make storybook

To see changes:

http://localhost:6006/?path=/story/components-document-viewer-menu--menu
http://localhost:6006/?path=/story/components-document-viewer-document-viewer--pdf-viewer

Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.
this article explains the fix for IE11 flexbox height issue shrinking to 0.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-4198

  Generated by :no_entry_sign: dangerJS against 7527c2c3ac5fa39b04e051287b2326111e380989

The collapsed menu is looking good to me.  The menu icon seems to be disappearing in Chrome at least when the filename in the titlebar is too long as well.  Do we want to deal with it in the titlebar in a similar fashion?  Should we just call the filenameFromPath once and pass it to the DocumentViewer component since it's needed both places?

IE11 is showing me an empty screen for this page 😬

IE11 is showing me an empty screen for this page 😬

Doesn't seem like it's because of the changes in the PR?

The collapsed menu is looking good to me. The menu icon seems to be disappearing in Chrome at least when the filename in the titlebar is too long as well. I think we need to make specify the icon should not flex shrink.
Do we want to deal with the text-transform it in the titlebar in a similar fashion? Should we just call the filenameFromPath once and pass it to the DocumentViewer component since it's needed both places?

Yea, I can just pass in the transformed title and pass it down to the menu

@donaldthai The text transform looks good for the titlebar.  The menu icon is still shrinking for me because we haven't set flex-shrink: 0 on that button.

On IE11 the title doesn't display on hover but if we move the title attribute to the button instead of the paragraph I think it will work.

@donaldthai Did you want to revert .loki/reference/chrome_laptop_TOO_TIO_Components_RequestedServiceItemsTable_Rejected_Service_Items.png to what's on master?

Let me revert that file

@duncan-truss yayyyy it's passing now!


How to Use this planner

I try to use it in clearpath husky robot，but in the rviz I cannot find the /local_goal topic and the /cmd_vel  could not be published.

It looks like you are launching a planner node using state_lattice_planner/launch/local_planner.launch.
In the launch file, some topic names are remapped.
https://github.com/amslabtech/state_lattice_planner/blob/6793de79b272c20fa9948a4a65b8627e9b33c6b9/launch/local_planner.launch#L39-L42
So cmd_vel is remapped to /local_path/cmd_vel. If you prefer the name cmd_vel, you can simply delete the remap.
Unchecking the Dead sinks and Leaf topics checkboxes (at the top left of rqt_graph)  will help you to debug.
And although this is not directly related to the topic at hand, you don't need to run lookup_table_generator with the planner.
The lookup_table_generator is implemented as a ros node, but it doesn't communicate with other nodes and generates a lookup table (csv file) from the given parameters.


The identity API is not supported for this add-in. 13000

I did some minor changes to the manifest and taskpane.js to make it work in outlook and after the following error message is shown: getAccessToken error: {"name":"API Not Supported","message":"The identity API is not supported for this add-in.","code":13000}
Including this error in the terminal: Verify error: {"name":"JsonWebTokenError","message":"jwt must be provided"}
Here are the changes https://github.com/microsoftgraph/msgraph-sample-office-addin/compare/main...Wladefant:msgraph-sample-office-addin:change-to-outlook-addin

The reason seems to be that the jwt is undefined and because of that of course the graph api token can not be acquired either. What could be the problem? I have done everything imaginable, to no avail.

After hardcoding the accesstoken (API token:) and graph token that I got from running the same addin in excel it works perfectly fine

@Wladefant this isn't a good forum to get support on Outlook add-ins. I would recommend Microsoft Q&A as a better option.

all right, I have asked and looked much around but I am still not able to understand why Office.auth.getAccessToken or OfficeRuntime.auth.getAccessToken works on Excel but not on Outlook. And why even though my Outlook version support the Idenitity API it show the message he identity API is not supported for this add-in.","code":13000
https://learn.microsoft.com/en-us/javascript/api/office/office.auth?view=common-js-preview

Microsoft Q&A is the best place to post your questions on add-ins. If that doesn't work out you may need to contact support.


[BACKLOG-23867] Set a bottom on the ComboVar and remove the border in variablizable table cell so it doesn't overflow, and let TopicSelection group fill the space the Composite is given

[BACKLOG-23867] Set a bottom on the ComboVar and remove the border in variablizable table cell so it doesn't overflow, and let TopicSelection group fill the space the Composite is given

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/core/widget/TableView.java
  ui/src/main/java/org/pentaho/di/ui/core/widget/TopicSelection.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:


when Train the reward model, Get error

when Train the reward model, Get error:

Thanks for your feedback, but we can't reproduce your bug.
Please show more detail about your bug.
By the way, we suggest to use our train_rm.sh to train.
Thanks.


Extend deposit contract to store UCCB addresses

Currently, the deposit contract stores only the validators' BLS pubkey and reward address. However, the validators have to sign the Relayed events and the UCCB transactions submitted to the target chain, so they need a private key whose address must be stored in the deposit contract.
Furthermore, the deposit contract shall have a function which can be used to retrieve all UCCB addresses and their stake in a single call. It shall also emit events with these data when the deposit() or tempRemoveStaker() functions are called.
An additional extended version of the getStakers() function that returns the stakes along with the BLS pubkeys would be helpful too.

Implemented as part of https://github.com/Zilliqa/zq2/pull/1178.


Add issues: read permissions to docs

Fixes #1710
Starting from digger v0.6.41, at least issues: read permission is required to check if PR number is an issue or not. It should be clearly stated in the document so that other folks are not confused.
I'm not sure when issues:write is needed, please add another note where appropriate.

Hey many thanks for this docs fix 🙏 I would like to add a note that issues: write will be needed for those using drift reconciliation with GitHub but for now this will work for everyone else


Allow disableNormalizePath authScheme parameter for sigv4/sigv4a

Description of changes:
Add the disableNormalizePath property as an allowed property for sigv4 and sigv4a auth schemes.  This parameter is required for some services (eg: S3) to correctly sign requests.  Specifying it in endpoint parameters will allow SDKs to potentially remove more S3 customizations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing as this will be added to #1855


Hotfix: Fix for logical extension error in rails 4. Issue #61

Added logical extensions to prevent compatibility errors.

Thanks!


Multiple infiller decompose

Pull request
Please confirm that this pull request has done the following:

[x] Tests added
[x] Documentation added (where applicable)
[] Example added (either to an existing notebook or as a new notebook, where applicable) (not yet, next commit)
[x] Description in CHANGELOG.rst added

Adding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following:
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

This is to be done after #43

The notebook where this is used is in PR #45 . It constructs a consistent basket in the infiller data and then breaks it down into several components.


Version <IP_ADDRESS>.Alpha6-SNAPSHOT examples reference invalid artifact versions that should be 1.0.0.Alpha4

Version <IP_ADDRESS>.Alpha6-SNAPSHOT examples uses the parent POM version but the required version of many artifacts is 1.0.0.Alpha4
ErrorOnExecution.txt

I think this is now resolved.
If that's not the case, please open an issue at https://issues.jboss.org/browse/SWARM


I have Fixed the Isuue.

i have fixed the issue with body parser in line no 6.

@Zaid-maker Have you checked? Is it working now perfectly?

Yea ita working 1000% fine.
Thanks for making that thing.
On Sun, Mar 1, 2020, 11:43 PM Saurabh Shubham<EMAIL_ADDRESS>wrote:

@Zaid-maker https://github.com/Zaid-maker Have you checked? Is it
working now perfectly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Saurabh3333/give-me-a-joke/pull/6?email_source=notifications&email_token=AMXTCNDNXLCTZLWHUQY3U7TRFKUFZA5CNFSM4K7GFOQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNHF4Q#issuecomment-593130226,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMXTCNHISOIBOJNHC6PP2LDRFKUFZANCNFSM4K7GFOQQ
.


Remove .only

Mistakenly committed a .only on tests

What no eslint rule?

Lol… it’s coming…
On Sat, Feb 18, 2023 at 4:38 AM Pete Bacon Darwin @.***>
wrote:

What no eslint rule?
—
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/workers-sdk/pull/2757#issuecomment-1435660899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABUZ2BMI7TH4OBVTVAGZQLWYC7FHANCNFSM6AAAAAAU75WCO4
.
You are receiving this because your review was requested.Message ID:
@.***>


Button Config Script resizes between switches

Overview
When I switch between Icon, sprite or Quad, they sizes revert back to default sizes.
Expected behavior
I wish that I could set the scale and have it remember the previous scale
Actual behavior
Steps to reproduce
(Links to sample github project preferred)
Unity editor version
2019.4.13
Mixed Reality Toolkit release version
2.5

@Railboy , I don't know how to assign this to you.

@Railboy , I don't know how to assign this to you.


Remove http links

What issue is this referencing?
#210 changed the python and ruby links to point to exchange js for now.
Tried to remove any links to http sites.
Does the following command run without warnings or errors?

[x] yes! npm run pr-checks

Have you taken a look at our contributing guidelines?

[x] yes!

My node version matches the one suggested when running nvm use?

[x] yes!

I wonder why it is still mad about https stuff...
Thank you for looking into this...
I'll still merge this once the build re-runs


Grapher: Possible to add coordinates at cursor?

The old Grapher displays the coordinates at the cursor and updates such coordinates as the cursor is moved. When trying to manually select an operation point, this can be useful. Is this even possible?

It's absolutely possible; good idea!


Support HTTP POST requests to /userinfo, aligning to OpenID Core specification

This PR adds support for the HTTP POST requests to /userinfo endpoint. While the OpenID Core specification recommends using HTTP GET, at least MinIO uses HTTP POST in their OIDC login flow.
OpenID Core:

5.3. Userinfo Endpoint:

The UserInfo Endpoint MUST support the use of the HTTP GET and HTTP POST methods

5.3.1. Userinfo Request:

It is RECOMMENDED that the request use the HTTP GET method and the Access Token be sent using the Authorization header field.

I tested this manually with a local MinIO instance, and it successfully allows their [x] Claim User Info setting to be checked. Without this change, it fails with a Method not allowed error from the IdP.

I was unable to create a backport for 1.22. @marcellmars, please send one manually. :tea:
go run ./contrib/backport 32578
...  // fix git conflicts if any
go run ./contrib/backport --continue


Ability to easily load assets from within a dependency crate

What problem does this solve or what need does it fill?
I would REALLY really like to be able to somehow use assets in an asset folder of a rust dependency as 'assets' that i load with bevy .
for multiple reasons...

i could use this crate shared between my editor and my game

i could make it private in git while keeping my editor public in git

is there -any- way I can use  assets in an asset folder of a dependency as normal enshrined assets in my bevy project?  AS WELL as also use assets in the normal root asset folder too ?
What solution would you like?
I would like to be able to put some of my game assets in the assets folder of a dependency crate and be able to load them with bevy assets (like load_folder) as well as still being able to load assets that are in the root /assets folder of the project
What alternative(s) have you considered?
Currently I am having to use a git submodule which sucks and has many issues, its very annoying to deal with - i want to be able to keep my games editor open source while also NOT exposing my licensed game assets and also not having to deal with sooo many headaches
Additional context
I am using the bevy_asset_loader crate to load assets but i believe the root issue goes deeper than this

I suspect you don't actually want your crate's assets to "mix" with your binary's assets. Would just making an asset source for your dependencies be sufficient? For that we'd need something like a build script to copy the assets somewhere next to the assets folder, and then just have each crate create its own asset source.
Please correct me if you need crate assets and binary assets to be in the same asset source!

Hmmm yeah i think there are many different ways to go about this and approach this and i cant say for sure what i "need" , im not exactly sure what to prescribe here.
If it were possible to be able to include/access an assets folder of specific dependency crates , such that sub-crates could be providers (sources) of bevy assets , yes.  That would solve my problem.  If that involves copying (?) im not sure .
I say this would solve my problem because: my games map editor is open source (while i am actively making my game w it ) but i dont want to make my games Assets be open source.   Its hard to juggle rn as im like.. gitignoring stuff out of my assets folder which is a giant pain .  If i could put my games assets in a different git repo, that solves my problem.   And the cleanest way ( besides submodules which i tried and is also messy and a pain ) i can see would be to somehow be able to allow the bevy asset system to load assets not only from the root asset folder, but from some sort of dependency asset folders.   Which could be am asset folder of a dependency crate or some other solution.

To elaborate on your comment , are you suggesting i run a build script to copy assets from a subcrate to my assets folder ?  This perhaps could work yes --  i guess it would be nice to have the functionality as more enshrined though so my build pipeline isnt as messy .
I think this is going to crop up its head again as the official bevy editor gets built -- there is going to need to be an assets folder for the assets of the editor and a different one for the assets of the game --- right ?  Thats my issue

First, for your real-life problem, have you tried separate asset sources? Instead of having fine-grained gitignores, you can just have assets and game-assets or something, and gitignore all of game-assets. Or alternatively, just make your asset source point to a completely different folder path which is like your "assets" Git repo. Your specific case may be
As for this issue (the more general problem of assets in crates), I absolutely agree that this should be something Bevy should do or at least help with. If Bevy could provide like a bevy_build crate with utility functions like create_crate_assets_folder, that would be nice.

Thats a great idea!! I was thinking abt out other engines like unity or unreal do this ... yeah they do like you describe : theres some other gameassets folder somewhere , could be in .local or appdata or otherwise .
What is frustrating to me is how its not really possible to do this in bevy / the bevy_asset_loader crate .   If you have used that crate , it only can assume all of your assets are in /assets and i believe this is due to a limitation of bevy itself

Does bevy_asset_loader not support other asset sources? I would be very surprised. That seems like a bug if true. Bevy does support custom asset sources already, so there should be nothing else Bevy needs to do on its side.

Huh.. okay so you are saying that its possible for me to load assets from /assets and from another folder like /game-assets .    I dont see any docs or examples or anything about that .
And when i try to load anything w bevy asset loader , it auto prepends (assumes) my paths with /assets soooo .. i feel stuck

Sorry, here's the example that shows it off. https://github.com/bevyengine/bevy/blob/main/examples/asset/extra_source.rs

Ahhh okay amazing . Thanks ill give this a spin

Okay yes you can close this I got it all working !!
For anyone else, what I did was i made a separate repo to hold my game assets and that is a private repo.   Each time my editor loads up, I copy the files from that repo into a .gitignored folder ("artifacts")   . It is adjacent to /assets, not inside of it .
I also configure the artifacts folder as an 'extra source' like the example.
Then when i use bevy_asset_loader, i can set my path to point at stuff in that 'artifacts' folder by using "../artifacts/game_assets/ ...."
So now my game assets are totally separate from my editor assets; they have a private git repo while my editor uses a public repo .


[TASK]: Verify race result outputs

Task Summary
Race result outputs need to be verified they are correct.
Working directory:  /src/app/race/Race.tsx /src/app/race/utils.ts
This [ Task ] should be done when editing any logic inside these files.
Consider adding tests:

timeTaken
errors
cpm
accuracy

Issue Labels:

[proposed Label] high priority
[proposed Label] task
[proposed Label] bug

we don't have test setup so i guess we have to setup test suite first.


dnsproxy: 0.37.7 -> 0.38.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AdguardTeam/dnsproxy/releases.
meta.description for dnsproxy is: "Simple DNS proxy with DoH, DoT, and DNSCrypt support"
meta.homepage for dnsproxy is: "https://github.com/AdguardTeam/dnsproxy"
meta.changelog for dnsproxy is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/imbk1vpv237sq2y38k1f786ydxg9rbrs-dnsproxy-0.38.0/bin/dnsproxy passed the binary check.

1 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 0.38.0 with grep in /nix/store/imbk1vpv237sq2y38k1f786ydxg9rbrs-dnsproxy-0.38.0

found 0.38.0 in filename of file in /nix/store/imbk1vpv237sq2y38k1f786ydxg9rbrs-dnsproxy-0.38.0

directory tree listing: https://gist.github.com/045a02f2090849e3ad3858d2a159ce95

du listing: https://gist.github.com/7ebde33b42561fd01d83797f1bcf8a22

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
dnsproxy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/imbk1vpv237sq2y38k1f786ydxg9rbrs-dnsproxy-0.38.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dnsproxy https://github.com/r-ryantm/nixpkgs/archive/31257ffdc3c3fa52afc683c342f173e9bb03d085.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/imbk1vpv237sq2y38k1f786ydxg9rbrs-dnsproxy-0.38.0
ls -la /nix/store/imbk1vpv237sq2y38k1f786ydxg9rbrs-dnsproxy-0.38.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dnsproxy

Maintainer pings
cc @contrun @kalbasit for testing.

Result of nixpkgs-review pr 128200 at 31257ffd run on aarch64-linux 1

1 package built successfully:

dnsproxy

1 suggestion:

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/tools/networking/dnsproxy/default.nix:21:5:
   |
21 |     license = licenses.gpl3;
   |     ^


Parsing to structs

Are there any plans to implement the ability to parse to structs?

Not at the moment, no.
I'd rather focus on making working with DOM as fast and easy as possible, and leave Serde for when you need structs, as the guys there do a lot of very good work regarding compiler plugins and all that.
If a demand for json-rust to implement parsing to structs becomes a thing, it is not out of the question, but I see that as a more of a 2.0 nice to have kind of a feature at this point.


FQSEN constructor does not accept all valid PHP Class Names

FQSEN constructor accepts only alphanumeric characters, but a lot more are allowed in PHP.
This makes parsing in ReflectionDocBlock fail with valid php class names.
From PHP Documentation:

A valid class name starts with a letter or underscore, followed by any number of letters, numbers, or underscores. As a regular expression, it would be expressed thus: ^[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*$.

For example Option«T» is a valid Interface Name, but is not a valid FQSEN name.
In a library I am working on I need to handle this special chars, and to do so I committed a small patch to the regexp in a fork: https://github.com/nicmart/ReflectionCommon/commit/9f3d9ea46181a75d03bfbbc9f72b281daa9dccc1
If you agree that this is an issue that has to be fixed, I can open a pull request with the fix.
Thanks!

Any update on this? Is the repo still maintained?

Hi @nicmart,
Think you are right about this. I would be happy to accept your PR on this.

Hi @nicmart,
I found some time to fix this. It would be very nice if you could do a review.
Thanks!


Image missing in HA

It appears the custom integration does not have an entry in the HA Brands repo.
The images could made to show generic Netgear pngs, same as this other Netgear custome integration.
If the above images are okay, I can change this HA Brands PR #5758 from Draft to Review?

Yeah thank you, Image is not perfect but better than nothing :-)
Thank you!

Fixed in https://github.com/home-assistant/brands/pull/5909


Added plugin receiver docs folder

Proposed Change
Added plugins folder to docs for plugin receiver documentation.
Checklist

[ ] Changes are tested
[ ] CI has passed

Closing this as we're currently working on a way to autogenerate documentation.


[Tabs] Icon & optional count

Summary
From
Internal Watson-IoT/pal-tracking#178

Is this an extension to an existing component, pattern, or a brand new asset?
This is an EDS item
What is the rationale for this contribution.
This contribution intends to allow users in highly restricted space applications, to identify tabs and navigate between then with no text label, but instead with an icon. Eg: between lists of alerts identified by our alert status icons.
The additional piece is to also allow for a visual text counter of how many records would be in each tab (handled to the component as a number by the implementer).
Detail the intended behavior
A standard carbon tab in most senses and utilising its styling and interactions in all ways aside from the fact that rather than a typical label, these tabs show a 20px status icon left aligned with optional text counter, also left aligned.
Image:

Found here: https://ibm.invisionapp.com/share/U2NYW8D7DFV#/screens/319196742
Not shown but for consideration - in a responsive scenario, these tabs could fold into a dropdown like typical tabs, with the inline icon dropdown #1374  as the most appropriate version.
Inspiration from other products
This is used heavily in some forms of the EDS schematic diagram pattern: https://ibm.invisionapp.com/share/U2NYW8D7DFV#/screens/319157458

I haven't seen any teams ask for this. We've moved this into the experimental section for now, BUT I saw that Carbon actually is building the icon only tab version into their tabs as a modifier.
If you watch from 49-56 mins here you'll see the updates they are making to the two tab styles, so this should be achievable by the Carbon component soon. Still not sure if teams need the count though.
Meeting recording
Passcode: CsQZ4J8S
So in that case is this something we need to support separately in the PAL?


Implement action to test and merge green head

DO NOT MERGE PRs TO TRUE-HEAD IF THEY DON'T HAVE TESTS

This needs to be merged into true-head to work, since we're watching for pushes on true-head. To the best of my knowledge this should work

looks good to me too


Bind keyboard event on search input box

Bind enter press event on search input box
Since you have already requested service list from server. It would be a better choice to put them on page.

Codecov Report

Merging #180 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             develop   #180   +/-   ##
========================================
  Coverage        0.4%   0.4%
  Complexity         7      7
========================================
  Files            102    102
  Lines           4658   4658
  Branches         798    798
========================================
  Hits              19     19
  Misses          4638   4638
  Partials           1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed43595...4d202cb. Read the comment docs.

如果不执行动态查询，可能会出现脏数据，自动提示可能也会出现这种情况
Google Translate:
If you do not perform dynamic queries, dirty data may appear, and automatic prompts may also occur.


Use SelectedListItem as argument in listItemBuilder instead of index

Closes #16
This PR replaces the parameter in ListItemBuilder function with SelectedListItem, instead of integer index.
The reason is that if the search is used, it produces a subset list that has no longer valid indexes for matching it with the original list. So it's impossible to customize the rendering of the items for searched items.
So as we replace an arbitrary index with SelectedListItem, we now have SelectedListItem.value which can be used to match the item in the original list, and thus use this data to render a custom widget.
The change can be considered breaking, but it is absolutely crucial, so to make it work with the search.

@deep-mindinventory?

@mi-raj04 please consider merging this. It is really important. The search feature is otherwise not usable.

@pratikkansaramind @deep-mindinventory can you please consider releasing? It's been merged for months now, but still isn't in the release.

@abrarmalekji345?

@romatallinn Ok will do Asap


fix text in header shape

"continued [slide idx]" in question text in header shape increments instead of "[slide idx]"

Resolved by #451.


Environment list search bar

Signed-off-by: chaitali-mane<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?
Need to add the search bar for Environments List

:chains: Related Resources
#4668
:+1: Definition of Done
I have added the search bar for Environments list.
:athletic_shoe: How to Build and Test the Change
Steps to reproduce the behavior:
if you have sample data for the infra servers than
go to >> infrastructure tab >> click on Chef server on left side navigation bar >> Organizations >> Environments tab >> see the list of Environments.
:white_check_mark: Checklist

[ ] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[ ] All commits have been signed-off for the Developer Certification of Origin.

:camera: Screenshots, if applicable
Environments search

Environments search value

No data found in Environments search

Found some Styling issue in testing like spinner not displaying for full page height and more list header spacing.

Created issue for the UI chages #https://github.com/chef/automate/issues/4750 and raised PR with changes #https://github.com/chef/automate/pull/4754 against issue.


pluggy plugins are not detected

Hi all,
I am using pluggy do defines hooks via entry point to my library
seems like nuitka --standalone is not taking into account dist/entry_points.txt
I tried manually to copy the package-dist folder and it worked

It seems that Nuitka itself does not have the function of embedding data files. You should try virtualbox instead.

It can though.. like xml files.. but maybe that needs special configuration and ideally.. supporting the entry points detection for that package when using --include-package option

Nuitka itself does not have the function of embedding data files.

on the contrary, we have very good support for that, to the point that it's slowing us down from working on more important things

@KRRT7
example.zip
extract the folder, then  pip install path to egg_sample_plugin and egg_sample
then try to run the script sample.py
then compile it with
python -m nuitka --run --standalone --include-package=egg_sample_plugin path\to\sample.py

You want to use --include-distribution-metadata which includes the information needed to lookup entry points at run time.

For third party packages, yaml configuration can be used. Here is an example
- module-name: 'opentelemetry.propagate'
  data-files:
    - include-metadata:
        - 'opentelemetry-api'


Error handling

I noticed that when a user attempts to run the app with a local unsupported model, even if the device has enough ram, the app tries to generate something and subsequently crashes.
I suggest implementing error handling at a low level to address this issue.
llama.cpp already handled it, so it should be simple to fix

You mean if a user attempts to run a model too large for their devices ram? Generally i like operating on the idea that no hard restrictions are placed on running models. If the user wants to attempt to run a model that needs more ram than they have, I will let them but yeah it will most likely crash.
Instead I would prefer to implement a warning for such models, or if you wanted to implement some logic to prevent the user from running such models, I would need a way to toggle it off in the settings page.

Yeah I like your idea
I mean
If a user attempts to load a fake or corrupt .gguf file or a model that fits into RAM but is not officially supported by llama.ccp yet
or is using an outdated version.


Make unix_term.rs compile on BSD platforms

This is a temporary fix for a bug in libc.
A fix PR (awaiting breaking changes in 1.0) is open against libc, here.

A merge of this PR would be highly appreciated!

Just encountered this while installing wasm-pack.

any chance to get this merged?

ping @mitsuhiko

Thanks. I will make a release with this.


NASA requires API key ?

I just looked at the NASA API website and there it asks me to register with an API key.
Maybe I am getting something wrong here, but if not I would love to fix this. I haven't really done much open source work, but I would love to change that.
Here ist the link I tried: https://api.nasa.gov/

There are many APIs at NASA. Some asks for API Keys, Some don't.
For each API, there are the parameters, if there is apikey parameter, it will ask for it. Some really need it, and some just gives more options to use.

Hey @flofriday, thank you for that review 😄
It's quite complicated. Some APIs offer a number of requests for free and then requires an authentication. Currently, we try to display the first accessible option.
As @Ronkiro said, NASA case is even more complicated since they offer a list of APIs with different authentication processes. So, from my POV, we should stick with the first accessible option which is No authentication.
There is a real subject on simplifying all that but I'm still not sure on what the best option would be right now...


YouTubeCenter not active/working/available

I am running FF 36.0.1 and have installed the YouTubeCenter script version 2.1.7. I should, according to the documentation and the installation on Chrome, see the option/configuration screen as soon as I get to Youtube.com. I don't.
When I click on a video on youtube, I should see, like I do on Chrome, not only the option/configuration screen, but also all the options under the youtube player. I do not see anything there.  I don't.
Just to show the differences, I have added a couple of screenshots, taken today 7th March 2015.
First from Chrome, Shot 1 - where the gear wheel can be seen on the right hand side and Shot 2 where the options - Download, Repeat, Aspect and Resize can be seen:

Chrome Shot 2

Here are the same shots as above for Firefox (v.36.0.1), Shot 1 - NO gear wheel present, and Shot 2 - NONE of the options are available :

Firefox Shot 2

What do I need to do to activate and use this script.
Thanks.

Version 2.1.7 is known to be incompatible with Firefox. Use the Development Version until a new stable release can be made.

To add to what @Zarggg said, you can find the developer version here: https://github.com/YePpHa/YouTubeCenter/wiki/Developer-Version

Brilliant, it worked.
Thanks guys.


Reintroduce xDS Creds

This PR is https://github.com/grpc/grpc/pull/25365 + https://github.com/grpc/grpc/pull/25405.
It will require a cherry-pick.

Bazel C/C++ Dbg MacOS  resulted in a status of "tool failed". Assuming that's an infra failure. Regardless, we didn't touch any of those code paths in this PR.


Update zio, zio-test, zio-test-sbt to 2.0.16

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.2 to 2.0.16
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report
Patch coverage has no change and project coverage change: +3.51% :tada:

Comparison is base (97f819c) 66.72% compared to head (4586047) 70.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   66.72%   70.24%   +3.51%
==========================================
  Files          19       18       -1
  Lines         565      531      -34
  Branches       21       21
==========================================
- Hits          377      373       -4
+ Misses        188      158      -30

see 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Superseded by #412.


There needs to be a "map" widget that is the ineteractive graphical farm designer

Widget is there, there's just nothing in it ;p


${workspaceFolder} not supported in manualCoverageFilePaths

Describe the bug
I have a coverage file in some subdirectory of my workspace.
When I specify the path as relative to my workspace, or using ${workspaceFolder}, the extension is not able to load the file. It fails with errors like ENOENT: no such file or directory, open ...
If I replace ${workspaceFolder} with the absolute path to my workspace, the extension is able to load the file.
E.g.:
This works:
"coverage-gutters.manualCoverageFilePaths": ["/foo/bar/workspace/coverage.dat"]

This doesn't:
"coverage-gutters.manualCoverageFilePaths": ["coverage.dat"]

This doesn't:
"coverage-gutters.manualCoverageFilePaths": ["${workspaceFolder}/coverage.dat"]

Desktop (please complete the following information):

OS: macOS
Extension Version: v2.10.3
VSCode Version: 1.75.1

Additional context
Thanks for the extension!

@garymm Thanks for the ticket, I am not familiar with ${workspaceFolder} is this something that the newer vscode api's provide to the extension settings? (@mattseddon might have insights here as well if the extension needs to consider some template like variables?)

Visual Studio Code supports variable substitution in Debugging and Task configuration files as well as some select settings. Variable substitution is supported inside some key and value strings in launch.json and tasks.json files using ${variableName} syntax.
source https://code.visualstudio.com/docs/editor/variables-reference
You could make it work but it would definitely not be free.
The best (quickest) option for low maintenance is to specify in the docs/description of the config option (coverage-gutters.manualCoverageFilePaths) that the path provided must be a full path. I don't think this would lead to terrible UX because the option only has to be set once.

Visual Studio Code supports variable substitution in Debugging and Task configuration files as well as some select settings. Variable substitution is supported inside some key and value strings in launch.json and tasks.json files using ${variableName} syntax.
source https://code.visualstudio.com/docs/editor/variables-reference
You could make it work but it would definitely not be free.
The best (quickest) option for low maintenance is to specify in the docs/description of the config option (coverage-gutters.manualCoverageFilePaths) that the path provided must be a full path. I don't think this would lead to terrible UX because the option only has to be set once.

Thanks @mattseddon sounds like a good option on the documentation front.

This unfortunately precludes sharing these settings with a team. We're actually running into this issue right now, where we want to put these setting into our versioned ${repo}/.vscode/settings.json like we do with certain other settings ("eslint.workingDirectories", "java.checkstyle.version", etc.).
Are we open to accepting a PR to support either ./... or ${workspaceFolder}/...?

I can't speak for @ryanluker but I would say that if you are sharing settings/extensions with a team then a good option is to create a shared dev container.
https://code.visualstudio.com/docs/devcontainers/create-dev-container

This unfortunately precludes sharing these settings with a team. We're actually running into this issue right now, where we want to put these setting into our versioned ${repo}/.vscode/settings.json like we do with certain other settings ("eslint.workingDirectories", "java.checkstyle.version", etc.).
Are we open to accepting a PR to support either ./... or ${workspaceFolder}/...?

@josephzidell Thanks for the input! The repo is very open for PRs to add extra support as long as the tests pass and the performance isn't worsened for the other more use cases.
Take a look at @mattseddon 's suggestion first though and see if that fills your needs 🤔.


Test Quarkus DynamoDB extension with Camel Quarkus AWS 2 DDB

This reworks #3114 with the following changes:

Created a new test grouping for testing Camel AWS extensions with their associated Quarkus AWS extensions
Simplified the configuration docs
Dropped the limitations notice about the 'batch consumer' feature not being supported. I've removed the reference to it from the Camel component docs instead
Fixed some compilation warnings

Most of the test code is duplicated from the original ddb test, but we could look to have more DRY in future.

And so I think #3116 could be closed once this one is merged.


Update embargo doc link in SECURITY_OWNERS and change PST to PSC

See https://github.com/kubernetes/security/issues/8 for more information

/lgtm

/lgtm

@cheftako I believe it's because it decouples the kubernetes from github. I think the idea is that if for some reason the org decided on using a different service for official git repos, the git.k8s.io docs links wouldn't have to be updated since that site could just redirect to the new repo locations. In my original link switch PR https://github.com/kubernetes/community/pull/3311, I was told to do it that way, so I did. Perhaps @nikhita can clarify.

@cheftako thanks, I'm also changing it there in https://github.com/kubernetes/kubernetes/pull/75201 so is it best to change it only there and wait for the sync or to change it in both places? Feel free to close the PR if we should wait for the sync.

@joelsmith Change it there and wait for sync is currently the correct procedure.

/close
The change was already synced by the Kubernetes Publisher bot from https://github.com/kubernetes/kubernetes/pull/75201


Minimize blocking during multi-wifi reconnect

Is your feature request related to a problem? Please describe.
ESP8266
If wifi is lost, the device will wait CONFIG_TIMEOUT until attempting a reconnect. The reconnect (connectMultiWifi) attempts to reconnect a hard coded 10 times (with ~3 second delays).
The problem that I have for a remote IOT device (PID temperature controller, 1 second sampling frequency) is that the reconnect attempts are blocking.  the amount of time stuck in reconnect can be significant (at least 60 seconds for minimum 2 reconnect attempts + 30second connect attempt after reset).
Describe the solution you'd like
I'd like the reconnect attempts (connectMultiWifi) to be adjustable (or less) to limit time spent blocking main loop. Currently this is hardcoded.
Describe alternatives you've considered
changing specific hardcoded attempts to a define.
Additional context
Add any other context or screenshots about the feature request here.

Hi @jjskaife
Thanks for your interest in the library and your good research to understand the internal working of it.
I'll certainly make those parameters configurable in the next release, even the configurable parameters are already too many for normal users to handle ;-)
I also suggest that you redesign your code to prevent issue with any blocking code in the loop(), for example either

Using ESP8266TimerInterrupt to read from IoT device
Using higher priority task to read from from IoT device and lower priority for Blynk.run() task.

Good Luck,

In the mean time, you can modify the library code as follows to test
#ifndef WIFI_MULTI_CONNECT_WAITING_MS
  // For ESP8266, this better be 3000 to enable connect the 1st time
  #define WIFI_MULTI_CONNECT_WAITING_MS       3000L
#endif

#ifndef WIFI_MULTI_CONNECT_WAITING_TIMES
  #define WIFI_MULTI_CONNECT_WAITING_TIMES    10
#endif

    uint8_t connectMultiWiFi()
    {

      uint8_t status;
      BLYNK_LOG1(BLYNK_F("Connecting MultiWifi..."));

      WiFi.mode(WIFI_STA);

      setHostname();

      int i = 0;
      status = wifiMulti.run();
      delay(WIFI_MULTI_CONNECT_WAITING_MS);

      while ( ( i++ < WIFI_MULTI_CONNECT_WAITING_TIMES ) && ( status != WL_CONNECTED ) )
      {
        status = wifiMulti.run();

        if ( status == WL_CONNECTED )
          break;
        else
          delay(WIFI_MULTI_CONNECT_WAITING_MS);
      }

      if ( status == WL_CONNECTED )
      {
        BLYNK_LOG2(BLYNK_F("WiFi connected after time: "), i);
        BLYNK_LOG4(BLYNK_F("SSID="), WiFi.SSID(), BLYNK_F(",RSSI="), WiFi.RSSI());
        BLYNK_LOG4(BLYNK_F("Channel="), WiFi.channel(), BLYNK_F(",IP="), WiFi.localIP() );
      }
      else
        BLYNK_LOG1(BLYNK_F("WiFi not connected"));

      return status;
    }

then specify somewhere in your code, for example
#define WIFI_MULTI_CONNECT_WAITING_MS       1000L
#define WIFI_MULTI_CONNECT_WAITING_TIMES    3

Your contribution has been noted in Contributions and Thanks

Releases v1.6.1

Add configurable connectMultiWiFi parameters. Check Minimize blocking during multi-wifi reconnect #6
Update ESP8266_CORE_VERSION for ESP8266 core v3.0.1+

thanks for the link to your ESP8266TimerInterrupt code. That looks like a great solution. I've been using the blynk timers and will try yours.


Multipart Buffer Possible Solution

This is failing somehow in the decoder/encoder, as it appears that the parser is behaving as intended. I'm hoping another set of eyes can determine what I am missing. Because with the parser working I'm not sure where I am going wrong.
This uses a buffer however it seems to work almost across the board. The places I am worried is in the encoder and decoder now more than the parse but let me know.
I'm hoping someone can see what I'm missing because I've been looking over this code and lost sight of where I have gone wrong.  I know this needs a ton more documentation.

Are streams being compared directly here, rather than the bytes to which they run?  The test failures are showing a comparison between streams with some opaque effects, and I can't tell if they're equal, or if they're not, what's wrong.

You see the problem.
I can see if I can boil this down to something much more easily testable for everything beside the binary. For text based content we should be able to use decodeAscii or decodeUtf8.
I was very lost last night, but I'm starting to feel like I might understand how to make testing a bit easier to interpret.
Although I'm still not sure where the decoder/encoder may be going wrong. Especially because the parser seems to be working.

I guess what I'm saying is I can't even tell if the decoder is going wrong.  Stream equality is not going to work.  I would not be shocked if running the streams to bytes reveals that it's working fine, and that it's a bad test.
If not, we'll have a much bigger clue. :)

So looks like it is having trouble with Headers in the Second Parts, but works correctly for the first part. So, a little more, and we can switch back to a stream after this is debugged as a Simple Task.

CI passed. :tada:

Any idea why this is now failing on totally unrelated code?


Fix Ordering Bug for ClientNoteEdit

Description
Changed notes from being part of Sets to being part of lists.
The note kept getting popped to the bottom of the list because editing used to be implemented as a removal of a target note  and an insertion of its edited form.
Also added the test ClientNoteEditCommandTest#execute_editExistingUntaggedNoteToAddTag_discardsDefaultUntaggedTag() and found a flaw in TagNoteMap initialisation and fixed that.
GUI has been updated too.
Fixes #270 Fixes #296
Testing
NIL
Remarks
NIL

@qwoprocks  Merged after doing this: 🏃♂

LGTM, but is it possible to also add in a more informative message for client note edit? Using String.format to show the user > which client, the original note content, and the new note content. Can do in a separate PR if you want but imo its a simple enough change to do in this one.


Roslyn-based analyzers goes to .NET API Analyser

The link for Roslyn based analyzers goes to .NET API analyser. https://docs.microsoft.com/en-us/dotnet/standard/analyzers/api-analyzer
Which is correct? If the tool is API Analyser the text in Rosalyn analysers section should be more specific.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4ede120-eba4-51e3-3b40-9c214375990f
Version Independent ID: a24e2a42-dc7f-4537-ac0f-8dabd6cdd5be
Content: Microsoft Security Code Analysis documentation overview
Content Source: articles/security/develop/security-code-analysis-overview.md
Service: security
GitHub Login: @sukhans
Microsoft Alias: terrylan

@dombat Thank you for your feedback . We will have this reviewed with the content team ..

@dombat WE discussed this internally wit the product group and they approved the chaange to a more appropriate link for the Rosln API analyzers. The security extension is a complete package with multiple tools each with a different value proposition. The API analyzers remain the same as mentioned in the text, however by default it is focused on Security only rules so that one can run Security specific rules be default. However, they do have the option to run the generic analyzers, by editing the default config, if desired. We have initiated a change for link to https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/security-warnings . We will now close this issue.  The changes should be live in the next 24-48 hours as per the next release cycle.
Thank you.


Hand Models don't have linecasts

[Enter feedback here]
I followed all the steps, but the hand models don't have the line casts coming out of them and dont allow for pickup or manipulation of objects.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e94ee7b-9330-dc8f-cac2-9e677372db91
Version Independent ID: a3c182a8-1754-8adf-7cbc-51f6ed3f8b2c
Content: 4. Making your scene interactive - Mixed Reality
Content Source: mixed-reality-docs/unreal-uxt-ch4.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @sw5813
Microsoft Alias: suwu

Double check the last step of page 3; I somehow skimmed over the DefaultMode setting on the first run through.
"The last step in setting up your project is to tell Unreal to default to MRGameMode. Go to Edit > Projects Settings > Maps & Modes (in the Projects) section. In the Default Modes section, click the dropdown and choose MRGameMode. In the Default Maps section right below, change both the EditorStartupMap and the GameDefaultMap to Main. This way when you close the editor and reopen it, the Main map will be selected by default. Similarly, when you play the game, the Main map will be the level that is started."

I actually got it working, thanks! now I'm having an issue packaging it for HoloLens. Its saying I dont have the Binaries for the target platform installed. I believe I downloaded everything from the prerequisites. Any idea why this would happen? I'm unfortunately new to Unreal but worked with the HoloLens in Unity for a while.

You'll need to download supporting files from the Epic launcher- see the second step of: https://docs.unrealengine.com/en-US/Platforms/AR/HoloLens2/HowTo/PackageApp/index.html

I have the same problem as the original poster - no line casts coming from the hands - I also have an error message "Attempting to start an AR session but there is no AR plugin configured. To use AR, enable the proper AR Plugin in the Plugin Settings".

I have switched on the relevant plugins in both the AR and VR plugin setting sections in Unreal - I have also ensured MRGameMode is switched in as per above.

Any ideas anyone?

@andolph

Did you setup the ARSessionConfig blueprint?
If so, did you also add it to the level blueprint?
Also, check the last step on page 3 of the tutorial, to be sure you changed both the DefaultMode and Level settings.

Yes - all three
As mentioned before, I have the hands appearing and I can point, pinch etc but they won't interact with the scene (ie chess piece) and I don't see any casts from them either. The error message implies an AR plugin issue but the relevant ones are all switched on.
I'm running Unreal 4.25

Update:
Fixed !

Ensure All  AR and VR plugins are turned off in Plugin settings except the ones needed by Windows MR and MRTK
The cast lines to the hands are now visible and there is now correct functionality for picking up objects, etc

andolph,
So I believe I found a solution, however seeing as I'm new to UE4 in
general I dont know why it works. First, go to the UXTools C++ Classes
folder and search for UxtHandInteractionActor. Drag two of them into your
scene. You should now see the lines coming out of the hands when you press
play. Let me know if this works!
On Thu, May 21, 2020 at 9:03 AM andolph<EMAIL_ADDRESS>wrote:

Yes - all three
As mentioned before, I have the hands appearing and I can point, pinch etc
but they won't interact with the scene (ie chess piece) and I don't see any
casts from them either. The error message implies an AR plugin issue but
the relevant ones are all switched on.
I'm running Unreal 4.25
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/mixed-reality/issues/2196#issuecomment-632073444,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APM4SBQLPNGBZISJMSMC6OTRSURCJANCNFSM4M4KRGGA
.

hi CLaferriereRY
Many thanks but please my post just above yours


Resume isolate before terminating tests to prevent flutter_tester leaks in integration tests

When running integration tests locally I noticed that flutter_tester processes were being leaked. This is because during some of the tests the Flutter isolate is left paused and when we try to tear down (by  sending SIGTERM) the output of the process says

Waiting for current test to finish
Press Ctrl+C again to terminate

Since the process doesn't quit within 10s, we then send SIGTERM which terminates the process and no cleanup is performed (so the child flutter_tester process is left). Sending a second SIGTERM did not resolve the issue in my testing because it also resulted in an unclean shutdown.
This probably fixes #26350, though I don't think it's a perfect fix since other code that terminates while paused (for example the user clicking Stop in the IDE while at a breakpoint) could still leak these processes - I don't think that's really a Flutter issue though (it's likely a package:test issue, or limitation that the IDEs should consider).

tools_tests are failing, can you try rebasing on ToT? this might have been fixed upstream.

Hmm, the failure does seem to be caused by this change - but I don't understand why the try/catch seems to be being ignored here and the error still thrown:

The same code in a simple command line app seems to behave as I'd expect (the catch block executes). Is this a bug or am I overlooking something?

I've opened https://github.com/dart-lang/sdk/issues/39513 about the caught exception that's still failing the test (it's possible it's my bug, but I can't come up with an explanation that makes sense to me).
I'll see if I can find a better way to work around it here for now.

I've rebased on latest code, fixed the indenting and also added a null check to avoid trying to resume when there's no VM service. The tests seem to all pass locally, though I'm still confused by the behaviour of the catch block - I may come back and tweak this in a future PR based on the response to https://github.com/dart-lang/sdk/issues/39513.

If resume().timeout(defaultTimeout) might leak an error into the containing Zone (via an unawaited Future or microtask), you can use asyncGuard() to make sure it is caught where you want it to be caught.
However if resume().timeout(defaultTimeout) is in the tool codebase, the preferred solution is to not leak the error.

I was able to reproduce it without any zones in https://github.com/dart-lang/sdk/issues/39513 (and without the timeout firing). It feels like a bug, but I'm not sure 🤷♂

I left a comment on https://github.com/dart-lang/sdk/issues/39513.

I pushed 5207952f0 which changes the timeout code (which aimed to print a warning when an action took too long, including all of the messages that went over the API in the meantime if they're not already being printed) to use a Timer which is cancelled if the future completes.
This seems to resolve the issue - exceptions in resume are now handled and don't fail tests.

Looks like Cirrus builds aren't running for this PR again 😞
@fkorotkov - could be another instance of 404s from GH?

@DanTup there was another issue this time. I've poked around and found that GH timed out while delivering the webhook. Cirrus' metrics looks fine around that time so will investigate more to see on which end this happened. In the meantime I've manually redelivered the webhook.


⚠ ClamAV has degraded performance

In 2b25360, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: ClamAV performance has improved in ebd4b34.


Update to 1.11.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Change the way search features works in Busy beta.

Lately, while browsing using @busy.org I try to search, some artworks post of others.
But after using the search features it brings me to google instead of giving me the list of artwork in the feed.

I suggest that instead of bringing users to google when using the search features in busy why don't use the feed to give what the users want to search?
Here is the example of what I want to happen.
In Utopian when you search for a project it will give you a project list.
When you search for an Idea of Busy it will give you those Idea.

Here's Another Example!
I tried to search about the bug of busy in utopian.io.

Again I'm Suggesting for Busy to make the search features of Busy to make easier to use. Show the result on the feed instead of bringing user in Google. Open Source Contribution posted via Utopian.io

more details are here #1070
also it tests in new firefox versions.

@bonustrack Do you think we should use site:busy.org on the google search for the TopNav, instead of site:steemit.com? Also I was looking at asksteem.com's api. We could possibly use that, though you can only go to page 10. https://github.com/Hoxly/asksteem-docs/wiki

This issue has been fixed here #1183


[move-only] Fix SIL representation and SILOptimizer to preserve value deinits

Fix SIL representation and SILOptimizer to preserve value deinits.
Fixes:

rdar://110079028 ([move-only] Finish SIL support for drop_deinit)
rdar://109849028 ([move-only] LowerAggregateInstrs eliminates struct deinitialization)

Many basic SIL passes were silently deleting the struct and enum deinits:

SROA
Mem2Reg
RLE
DSE
FunctionSignatureOpts
LowerAggregates
SILCombine
EarlyCodeMotion
ReleaseHoisting
many passes that rely on ARC analysis (RCIndentity)

Major Changes:

add SIL verification for drop_deinit
fix ownership lowering to handle drop_deinit
disable deinit devirtualization (until the optimizer is tested)
fix 'shouldExpand' to recognize value deinits; impacts many passes
fix dead function elimination to collect and preserve value deinits
fix RCIdentity to recognize value deinits; impacts many passes
fix SILCombine special cases to preserve value deinits
fix TypeLowering to preserve value deinits; mainly fixes LowerAggregates

@swift-ci test

@swift-ci smoke test windows


SWITCHYARD-2172 Security context not propagated through JMS reference…

https://issues.jboss.org/browse/SWITCHYARD-2172

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Closing as this should be done in application code but not in SwitchYard itself. Instead I added a quickstart demonstrating it.
https://github.com/jboss-switchyard/switchyard/pull/77


adding an option to page from ListResult

Coverage decreased (-0.51%) to 58.14% when pulling 87792edc42c5ca2d2ad23820b93fbd737bc51668 on aozarov:temp1 into 05e3f0a856850813b7a07462dc2e4ece3ef5e4ce on GoogleCloudPlatform:master.

Coverage decreased (-0.48%) to 60.38% when pulling 8cfb28657c714f8c7768fcd0240c32896f5ae8e3 on aozarov:temp1 into e0c03c91b64b55fe9c8612c85bbc18ec52cba37a on GoogleCloudPlatform:master.

LGTM. Merge when other merges are done.

Coverage decreased (-0.55%) to 68.29% when pulling 57c424257de64c7e1b5de085360408094dd2e0c6 on aozarov:temp1 into 2cd8108b808b026758fe22231c5cdeed16ff7ca0 on GoogleCloudPlatform:master.


In vec32minmax use iterators to avoid clone/sort a vector

https://github.com/dfsp-spirit/neuroformats-rs/blob/4235e974391863c2f070821cd7294015fee7ff93/src/util.rs#L67-L79
There are multiple ways to accomplish that, the most elegant ones, use iterators.
The most obvious solution is to use the Iterator::min and Iterator::max, although it will not filter/panic on NaNs.
I'll work in a solution using iterators and submit a PR soon.

While rewriting the function I also noticed a bug in this function:
https://github.com/dfsp-spirit/neuroformats-rs/blob/4235e974391863c2f070821cd7294015fee7ff93/src/util.rs#L99
This line will never be executed, because has_nan is always false if remove_nan is false.

Fixed at #5 in https://github.com/dfsp-spirit/neuroformats-rs/pull/5/commits/63e63367cf17a60e9ae0d5d52b32a8ef177b30d7


Illegal expression causes exception message in tests

In tests/async/events.py we see at line 24 the line
h.bind_event('finish', lambda f, exc=None: 'OK'+4)

This raises exceptions, which result in the unintelligible output "Exception ignored in:" in the middle of the test output stream. If it's intended to raise that exception, could the message be suppressed, or at least identify the exception?

Apologies: the exceptions concerned don't appear to be related to the line in question, as they occur even when 'OK'+4 os changed to 'OK'.

I also see two messages that read "Not Found: /bsjdhcbjsdh" in the testing output.

Additionally, please note that the "Exception ignored" message only occurs on Mac OS (Yosemite), while the "Not found" message occurs on both Mac OS and Ubuntu

Some of these messages are caused by third party libraries which pulsar uses as soft-dependencies during unit testing.
Therefore suppressing them may be outside the power of pulsar. Having said that, the Exception ignored.. message is an asyncio message not to worry about until they have finalised the library in py 3.6, i.e. no longer provisional.


Add information about Tableau

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@sayaliKutwal I made the changed suggested by camperBot on your behalf.
LGTM

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


fix: Prevent unsubscribe from leaking listeners (#1295)

Since 8eeeec1 it seems listeners have been leaking on keep-alive sockets.
Apparently abort() has been deprecated since v17, using close() the onSocketClose listener is properly removed, and by creating a new onData function I'm able to remove the 'data' listener too.

[ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue
[ ] I updated ./docs/v3-UPGRADE-GUIDE
[ ] I updated readme
[ ] I added unit test(s)

fix #1295

ping @LinusU to take a look

Removing of
		request.on('abort', () => {
			socket.removeListener('close', onSocketClose);
		});

is OK, since I don't see any request.abort call. So, this thing is just useless.
More over request.abort was deprecated since Node.js v14.1.0/v13.14.0.
It was added in https://github.com/node-fetch/node-fetch/commit/51861e98a8f87e0905e71bb101b506f9512a9d7f on Aug 12, 2021 by @tekwiz

The other change is also the correct one. Removing the 'data' listener on the request closing.
The current code works obliviously wrong in case when the same socket is used for multiple requests. It will add additional listeners on each request.
The current implementation only suited for non keep-alive agent.

BTW, the other way to prevent the existent of multiple listeners on the same net.Socket is storing a socket in WeakSet. Before adding the listener just check, is the socket already in the set, or no.
/** @type {WeakSet<net.Socket>} */
const socketsWithOnDataListener  = new WeakSet();

// ...

if (!socketsWithOnDataListener.has(socket)) {
    socket.prependListener("data", onData);
}

Did not test, but should work.

Could this fix be backported to the 2.x line? Would a PR doing that be accepted/considered?
Context: https://github.com/node-fetch/node-fetch/issues/1295#issuecomment-997041342 user reported this in 2.6.0, and https://github.com/openai/openai-node/issues/349 also reported this with<EMAIL_ADDRESS>


Segmentation fault when popup's callback is set to popup_close()

Steps to reproduce
Source this script:
vim9script

['Hello']->popup_dialog({close: 'button', callback: 'popup_close'})

(I know, that's silly.) Vim should crash as you soon as you close the popup dialog.
Expected behaviour
Vim should not crash.
Version of Vim
9.0.1946
Environment
macOS 14.0
Apple Terminal
xterm-256color
ZSH 5.9
Logs and stack traces
Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x1823beb38 __kill + 8
1   vim                           	       0x1004a8054 may_core_dump + 72
2   vim                           	       0x1004a7ec0 mch_exit + 252
3   vim                           	       0x1006bcedc getout + 1196
4   vim                           	       0x100451b94 preserve_exit + 236
5   vim                           	       0x1004ae930 deathtrap + 672
6   libsystem_platform.dylib      	       0x182425a24 _sigtramp + 56
7   vim                           	       0x100600ac4 call_callback + 200
8   vim                           	       0x100600ac4 call_callback + 200
9   vim                           	       0x1004befc4 invoke_popup_callback + 168
10  vim                           	       0x1004b7748 popup_close_and_callback + 548
11  vim                           	       0x1004b8184 f_popup_close + 196
12  vim                           	       0x10035bf44 call_internal_func + 252
13  vim                           	       0x1005fd510 call_func + 2536
14  vim                           	       0x100600ac4 call_callback + 200
15  vim                           	       0x1004befc4 invoke_popup_callback + 168
16  vim                           	       0x1004b7748 popup_close_and_callback + 548
17  vim                           	       0x1004b8184 f_popup_close + 196
18  vim                           	       0x10035bf44 call_internal_func + 252
19  vim                           	       0x1005fd510 call_func + 2536
20  vim                           	       0x100600ac4 call_callback + 200
21  vim                           	       0x1004befc4 invoke_popup_callback + 168
22  vim                           	       0x1004b7748 popup_close_and_callback + 548
23  vim                           	       0x1004b8184 f_popup_close + 196
24  vim                           	       0x10035bf44 call_internal_func + 252
25  vim                           	       0x1005fd510 call_func + 2536
26  vim                           	       0x100600ac4 call_callback + 200
27  vim                           	       0x1004befc4 invoke_popup_callback + 168
28  vim                           	       0x1004b7748 popup_close_and_callback + 548
29  vim                           	       0x1004b8184 f_popup_close + 196
[etc…]

oh, it's recursively calling the callback again...


Add a tool to catch panics in systems and attempt to handle them

What problem does this solve or what need does it fill?
Remove system if it panic and run error handle function if this don't work panic.
For mods as dynamic plugins don't broke game
What solution would you like?
schedule.set_error_handler(|error, schedule| {
      error.system_id
      schedule
      // panic for default
})

What alternative(s) have you considered?
Say to mod makers that they test their mods
.

Instead of trying to catch panics, why we cant let systems return Result<()>? IMO it will be easier to deal with.

Would something like a SystemPanic Event work well?
Such that when a system panics its removed from its schedule and an event is sent and can be handled in a system.
Then you could have access to entities and resources as well.
fn panic_handler(mut events: EventReader<SystemPanic>,  res: Res<SomeResource>) {
    ...
}

Instead of trying to catch panics, why we cant let systems return Result<(), Error>? IMO it will be easier to deal with.

System from mod can panic and don't return Result<(), Error>. ComputeTaskPool breaks app if system panic.

I'm personally against trying to catch panics here. Panics are meant to be unrecoverable errors, such as unreachable code and invalid state. I worry that making it easy to catch panics will encourage people to use what I believe is an antipattern.
If there's a specific system that's panicking when it shouldn't, you can make a fix by wrapping it in catch_unwind.
use std::panic::catch_unwind;

fn panicky_system(query: Query<Entity>) {
    // ...
}

fn better_system(query: Query<Entity>) {
    // Catch the panic and return a Result.
    let result = catch_unwind(move || panicky_system(query));

    // Silently return if the system panicked.
    if result.is_err() {
        return;
    }

    // ...
}

Either way, I like what @Umatriz is suggesting by supporting the use of the Result type instead.

I am closing this issue becouse i think that mods maded in rust is bad idea


Edits from verbatims and comments

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Run script failed with no detailed information. Please retry building your content again. If the issue still happens, open a ticket in http://SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/NuGet/docs.microsoft.com-nuget, working directory: W:\vakv-s, target branch: master, target branch commit: 0e17f20ebcd0fd33f116fccceb98d5cbad65dc6a, source branch: kraigb, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/NuGet/docs.microsoft.com-nuget, working directory: W:\33ma-s, target branch: master, target branch commit: 0e17f20ebcd0fd33f116fccceb98d5cbad65dc6a, source branch: kraigb, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Consume-Packages/Finding-and-Choosing-Packages.md
:white_check_mark:Succeeded

docs/Consume-Packages/Overview-and-Workflow.md
:white_check_mark:Succeeded

docs/Consume-Packages/Reinstalling-and-Updating-Packages.md
:white_check_mark:Succeeded

docs/Consume-Packages/media/Finding-01-Popularity.png
:white_check_mark:Succeeded

docs/Consume-Packages/media/Finding-02-SearchResults.png
:white_check_mark:Succeeded

docs/Consume-Packages/media/Finding-03-Downloads.png
:white_check_mark:Succeeded

docs/Consume-Packages/media/Finding-04-VersionHistory.png
:white_check_mark:Succeeded

docs/Consume-Packages/media/Finding-06-include-prerelease.png
:white_check_mark:Succeeded

docs/Create-Packages/Creating-a-Package.md
:white_check_mark:Succeeded

docs/Create-Packages/Prerelease-Packages.md
:white_check_mark:Succeeded

docs/Hosting-Packages/Local-Feeds.md
:white_check_mark:Succeeded

docs/Hosting-Packages/NuGet-Server.md
:white_check_mark:Succeeded

docs/Policies/NuGet-FAQ.md
:white_check_mark:Succeeded

docs/Reference/Package-Versioning.md
:white_check_mark:Succeeded

docs/Schema/nuspec.md
:white_check_mark:Succeeded

docs/Schema/packages-config.md
:white_check_mark:Succeeded

docs/Tools/Package-Manager-UI.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-install.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-pack.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-update.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-add-bindingredirect.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-find-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-get-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-get-project.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-install-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-open-packagepage.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-register-tabexpansion.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-sync-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-uninstall-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-update-package.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.