terminal.integrated.inheritEnv setting not working

Issue Type: Bug

Behaviour
Expected vs. Actual
terminal.integrated.inheritEnv is set to false (not checked), but $PATH in Terminal inside VS Code is wrong.
Steps to reproduce:

Make sure the setting is off, open VS Code (not just reload), open a Terminal, type echo $PATH.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.10.4
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

See screenshots

User Settings

venvFolders: "<placeholder>"

languageServer: "Pylance"

formatting
• provider: "black"

terminal
• activateEnvironment: false

VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T16:12:57.074Z)
OS version: Darwin x64 21.5.0
Restricted Mode: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 1

Memory (System)
16.00GB (0.02GB free)

Process Argv
. --crash-reporter-id 13eab17c-98ea-4f98-b8d0-695a94888d2f

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

copilot
Git
1.36.6340

python
ms-
2022.10.1

vscode-pylance
ms-
2022.7.40

r-debugger
RDe
0.4.7

r
REd
2.5.2

vscode-scheme
sjh
0.4.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
pylanb8912cf:30529770
vsclangdf:30486550
c4g48928:30535728

I've been working with kartikr on an issue. He asked me to open this one.
Settings

$PATH outside VS Code

$PATH inside VS Code

you could try no longer running a login shell in the terminal by creating a terminal profile and setting its args to []. If you go with this fix, you will want to make sure any aliases in your profile scripts are moved over to your ~/.bashrc/~/.zshrc file since aliases only apply to the shell they're set in

@alecramsay Here're the step by step instructions for you:

Use Open User settings (JSON) command.
Set args to []:
        "bashwithnoargs": {
            "path": "/usr/bin/bash",
            "args": []
        }

Use  to select your created profile now.

The issue I was having that motivated opening this issue -- https://github.com/microsoft/vscode-python/issues/19238 -- has been resolved. I unwittingly had a non-universal / non-Apple silicon version of VS Code installed.


SDK: Closing a Runspace does not clean up resources

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
We have a .NET Windows Service that needs to interact with Exchange Online. For various reasons we can't use the Graphs APIs, so we are using the Exchange Powershell Module via the Powershell SDK (version 7.4.1). This works fine, but I have noticed a memory leak.
Now, the Exchange Online Poweshell module is not exactly known for good memory use, but that shouldn't really matter. Once I close the Runspace and dispose both the Runspace and the Powershell objects, I would expect Powershell to clean up all resources allocated, no matter if the code run cleaned up properly or not.
We have previously used an out-of-process runspace on .NET Framework to work around this issue, but with the Powershell SDK on .NET 8 the Powershell .exe file is not distributed in the NuGet package, making this more difficult. Thus, I'd like to be able to run in-process, but a memory leak makes this difficult.
I have followed the steps here (https://techcommunity.microsoft.com/t5/exchange-team-blog/reducing-memory-consumption-of-the-exchange-online-powershell-v3/ba-p/3970086) to reduce memory usage significantly, but this is merely a workaround. The core issue here is that Powershell does not correctly free resources when asked to do so.
Expected behavior
Disposing and closing the Powershell and Runspace objects should release all resources.

Actual behavior
Some allocated memory stays behind, leading to a memory leak.

Error details
No response
Environment data
Powershell SDK verison 7.4.1 running on .NET 8 using Exchange Powershell Module version 3.4.0

Visuals
No response

Is this issue specific to the Exchange PowerShell module, or are you able to reproduce it without any external modules?

@MatejKafka I will have a go, but I suspect it is the Exchange Module causing it.
However, that shouldn't really matter. A PowerShell runspace should be able to clean up, no matter what a script or module does. Otherwise, what is the point of being able to host PowerShell in-process in the first place? Then hosting in a external process should be the default and the SDK NuGet package should redistribute the .exe file to allow for this.

SDK NuGet package should redistribute the .exe file to allow for this.

I see the PowerShell application (pwsh.exe) as being simply another program that uses the PowerShell SDK rather than being part of the SDK itself.
If it was part of the SDK nuget then any application using the SDK would then also get the exe whether it needed it or not.
If you want to run the pwsh.exe why not simply run pwsh.exe installed on the host system?

I found another static variable that should be cleared when closing the runspace:

@rhubarb-geek-nz I found your suggestion about having these caches in IntialSessionState very sensible. That way they could be cleared properly. The current implementation does not really seem geared to hosting PowerShell in a long-process that is sensitive to memory leaks.
I also found (and worked around via reflection) a memory leak in the Exchange Online PowerShell module, but that is for a separate issue.


Export block links within a file

Thanks for this plugin. Incredible work! I am supremely grateful.
One thing that doesn't work yet is block links. E.g., if I have a block:

Some text! ^myblock

And then I have a link later in the file:
A link to [[#^myblock]].

Better Export PDF doesn't export that as a link (though the text is still styled as a link).
Running Obsidian 1.6.5, Better Export PDF v. 1.8.1.
🙇♂ Thanks again!

I tested the example you gave. The link can be jumped. Can you test to open your Debug mode and check if the blockid rendering is normal?

D'oh, should have tested my own demo. The actual problem I'm having is a block id for a callout, which perhaps is already covered by https://github.com/l1xnan/obsidian-better-export-pdf/issues/100#issuecomment-1916706283
blockid in the target seems to render properly in the DOM, but the link does not:

Here's what's failing for me. The target:

> [!OUTCOME]+ Use principles and frameworks to make ethical decisions about information systems and knowledge management issues in organizations.
>
> - [ ] 📖 Read the introduction and chapter 1 of Mike Monteiro's _Ruined by Design_ %% [@Monteiro2019Ruined-By-Design-How-Designers, introduction and chapter 1] %%
> - [ ] 📖 Review the Canadian guidelines to security and privacy of information
> - [ ] 📖 Review the ethical lenses reading
> - [ ] 📚 [[#Topic exams]]
> - [ ] ✍ [[#Applied reflections]]: [[#Ethical Information Systems]]
^MGMT-6006-LO-5-1

...and the link:
#### Ethical Information Systems

> [!OUTCOME] Week 11
> - [ ] [[#^MGMT-6006-LO-5-1]]

Review and respond to the chosen case study.
What are the ethical dilemmas in the case?
What should the organization do? Why?

Perhaps it is case-sensitive?

I haven't seen a situation where the blockid is in uppercase. Obsidian should have made the conversion, but I didn't convert it, which caused this problem. It will be fixed in the next version. For now, we can only uniformly use lowercase to solve this issue.


parser: Support columns from subselect statements

Fixes #467

Cool that it works, however there is still an issue when using joins in a subselect statement.
Take this example:
SELECT r.*
FROM (
        project_saves
        JOIN projects
        ON project_saves.project_id = projects.id
    ) r;

This fails with the message
# package sqlc
sql-queries/projects.sql:159:1: empty edit contents

sqlc seems to believe that thesubselect r has no columns since when selecting a field of r the error message is "column "id" does not exist". Is there an easy way to fix this?


Where is the cache data saved?

I'm using this WebView to run whatsapp.com
The whatsapp save some folders of session and user data, where is it saved?

The data directory defaults to %LOCALAPPDATA%\flutter_webview_windows\YOUR_APP.


[fixed] Workaround for selection bug in IE, fixes #80

Please don't forget to merge this commit :) It's really blocking for IE11 users :(


[1.x] Supports PHP 8.4 (experimental)

@crynobone I just took a look at the workflow runs. It seems the workflow is currently not testing correctly. We define the matrix with Laravel and PHP versions, but we do not require the Laravel version anywhere. (In my original PR there are also PHP 8.4 runs with Laravel 8, so the exclude doesn't work as intended. Probably the arrays with the laravel versions should be an exclude each.)

Should we just close my PR #90 in favour of this one?


docs: add custom hasher example to readme

Title
docs: add custom hasher example to readme

Description
Adds an example to the readme of how to use a custom hasher with the helia data importing utils.
Closes: #640

Notes & open questions
Would love feedback on wording etc. @2color

Change checklist

[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
[ ] I have added tests that prove my fix is effective or that my feature works

Nice!


chore!: upgrading to node-rfc 2.7

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://www.conventionalcommits.org/en/v1.0.0/
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: upgrading to node-rfc 2.7.0

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Addresses #108

Addresses #108

Hi @raphaelreyna ,
First of all, lot of thanks for contributing.
It's very weird for python 3.5 build to fail when 3.6 & 3.7 are passing. It may be issue from the CI provider side. It happens sometimes.
Secondly, it's very sleek what you did in the code. Kudos for that.
Could you change in ordering in nonzero_christoffels_list within the first 8 indices at the top of file so that we can do
for _, k, l in nonzero_christoffels_list[0:4]:
    chl[0][k][l] = chl[0][l][k] = some value
    chl[3][k][l] = chl[3][l][k] = some value

or something like that to save computation. It matters a lot when it called 100000 times when calculating geodesics.
Kindly remember to apply black after your changes 😃

Oh! this is happening everywhere!

https://status.circleci.com/
https://status.appveyor.com/

@raphaelreyna Can you do this?
git commit --amend
and then
git push -f origin master
to trigger the CI builds

Hi @ritzvik,
Thank you for your kind words. I will look into implementing your suggested changes later today and tomorrow!

So I have implemented the suggestion given by @ritzvik, and it looks like all of the quality checks have been passed. I feel like it's ready for a review, is this where I would ask for that?

So I have implemented the suggestion given by @ritzvik, and it looks like all of the quality checks have been passed. I feel like it's ready for a review, is this where I would ask for that?

@raphaelreyna Thanks a lot for taking the pain to look into the project and implementing the suggested changes. It's great that the tests have passed and it is surely ready for merging. Also, the the problem on the Numba's  side seems to be resolved. That's why the tests are working again.
@raphaelreyna I have been on github for the past 1.5 moths and you can consider me pretty novice in open source development. But still, I had my fair share of learning. So one advice from my side is always make branches in your fork while working on any bug/feature. Never directly make changes to master. Secondly, try to make the commit messages a little more concise and informative.
If you are interested in working further, or are just interested, kindly join the Riot Chat here
Finally, I would ask @shreyasbapat to merge this.
Thanks again @raphaelreyna

@shreyasbapat Also close #108 on merging

Thanks a lot!


Add documentation for CNY APIs

SYRCityLine API
Syracuse Airport API
Onondaga County voter information API

Consolidate readme files?

Added with this commit.


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=548837526
https://github.com/Azure/azure-cli-extensions/commit/3548b1b36f07d0206839e268b784475a177380ea

Docs Build status updates of commit 5d71c6d:
:clock10: Full build: the average full build time is 7 min(s) 15 sec(s), this is based on the last 115 build(s) for this repository.

Docs Build status updates of commit 5d71c6d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


python311Packages.angr: 9.2.84 -> 9.2.96

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 299858 run on x86_64-linux 1

28 packages built:

python311Packages.ailment
python311Packages.ailment.dist
python311Packages.angr
python311Packages.angr.dist
python311Packages.angrcli
python311Packages.angrcli.dist
python311Packages.angrop
python311Packages.angrop.dist
python311Packages.archinfo
python311Packages.archinfo.dist
python311Packages.claripy
python311Packages.claripy.dist
python311Packages.cle
python311Packages.cle.dist
python311Packages.nampa
python311Packages.nampa.dist
python311Packages.pyvex
python311Packages.pyvex.dist
python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.claripy
python312Packages.claripy.dist
python312Packages.nampa
python312Packages.nampa.dist
python312Packages.pyvex
python312Packages.pyvex.dist


Add security and versioning dependency alerts with Dependabot

Dependabot alerts on updates for the project's dated and vulnerable dependencies and automatically creates PRs to easily update them

Built with ❤ by Pipeline Foundation.

Can you look into it @anchitj ?


CharLiteral, ByteLiteral

We need to be able to express characters and bytes directly in ThingML. Right now, we use extern expression to express a byte or character literal, which makes a lot of things to appear as PSM whereas they are PIM (we can qualify a thing as PIM if does not contain any extern expression of extern statement).
One problem is that characters are typically expressed as 'c' in most (if not all) programming languages. We use single quotes for externs... We might want to use backquotes for externs (e.g. as code snippet in MarkDown) and stick with a conventional notation for characters.

I agree that we should support character literals, and also that - if we do - they should really be the same as most other programming languages (single quotes). Changing the externs to backquotes breaks a lot of old ThingML code, but at the same time, we wouldn't have to escape all single quotes in externs, which is a nice side-effect.
But what would a byte literal be @brice-morin? Wouldn't that just be a number? Or are you thinking of supporting hex notations like 0xFF - which in my mind should just be the same value as 255.
Isn't this also somewhat related to having a set of basic datatypes included in the language?

Yes, I was thinking about 0x.. notation (which you use, with quotes e.g. in your ThingML-BLE project), but we could indeed fallback to numbers. Not sure e.g. in Java if we can assign 255 to a byte directly or whether we should use the hex notation (though the compiler could take care of the conversion)...
At least we should have proper literals for all common primitive types, which well accepted notations.
Since we agree, @ffleurey has to fix it :-)

Also, 'BooleanLiteral' should have a 'boolValue' of type 'EBoolean' and not 'EString' (not that it is a big deal to convert between the two, that is just annoying and inconsistent with other Literals)


Weird edge case

The following code
#import "@preview/showybox:0.1.1": *
#show link: it => { text(blue, it.body) }
#showybox(
  title: [
    Title#footnote[
      https://google.com
    ]
  ],
)[
  https://github.com
]

renders correctly, however, while the Github link points to https://github.com the Google link (in the footnote) points to http://google.com instead of https://google.com.
If I remove #show link: it => { text(blue, it.body) } it points to https://google.com.

The show rule overrides the links default behaviour. Viewers then still recognize the link from the text, but depending on the viewer different things happen. Chrome seems to get it right while Apple Preview does the http thing.
Whether a link show rule should or shouldn't remove the link's behaviour of, well, making a link is a valid question. However, it is in any case a typst/typst question and not related to the package repository.

What you want to use here is either:
#show link: it => { text(blue, it) }

or just
#show link: set text(blue)

So it instead of it.body to retain the links default behaviour.

Thank you


ERF - QvantryEdit: Here is the PR I contacted you about, sorry for the size of it :S

Feature summary:

Indicator groups that can grow from 1 - 4 auras depending on user settings per indicator group.
Separate stacks text on each aura into a separate FontString in the upper right corner.
Color HealthBarStatusColor depending on dispelable debuff types (You can't tweak these colors yet)
Color HealthBarBackground depending on Alive/Dead/Ghost (You can't tweak these colors yet)
Add the ability to have a general debuffs aura group which will show any debuff sorted from shortest duration to longest duration. The aura names that the user enters for which aura to track acts as a blacklist for this group rather than a whitelist (this is not obvious in the UI though)
Choose if an indicator group should be disabled in raids (i.e: I use this on my group which tracks personal offensive CDs such as combustion and more, I don't need to see that in raids, but it's nice to see in M+).
Add some debug features that can be run from the chat in-game: PrintSupportedDispels(), SetIsGhost(), SetIsDead(), SetHasCurse(), SetHasMagic(), SetHasDisease(), SetHasPoison() and SetDebug() to turn all of it off at once.

Apologies for never having merged this, to be honest I've been intimidated with how large the single patcheset was. Further, I've done a ton of work refactoring and retooling most of the addon in the time since you submitted this patch, and I think some of my work overlapped with what you included in this pr. Any chance you're still interested in contributing, and would you consider rebasing your changes on the latest iteration of the addon? I know that's a lot of work, so feel free to say no :-P

Hi Britt,Thanks for getting back to me. In truth i never intended to even submit this code, I was just playing around, and after a while I kept playing around and it became something.With that said though, it’s not version iteratively controlled, it’s not what I would consider even close to professional production code. I have all the understanding in the world.Finally though, I barely play anymore, so I think I’ll skip contributing this time, good luck though!/MartinOn 24 Dec 2023, at 21:43, Britt Yazel, PhD @.***> wrote:
Apologies for never having merged this, to be honest I've been intimidated with how large the single patcheset was. Further, I've done a ton of work refactoring and retooling most of the addon in the time since you submitted this patch, and I think some of my work overlapped with what you included in this pr. Any chance you're still interested in contributing, and would you consider rebasing your changes on the latest iteration of the addon? I know that's a lot of work, so feel free to say no :-P
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

All good man, I wish you the best!


Replace all of the example event IDs with modern room v4+ ones

Looks weird to have $143273582443PhrSn:example.org all over the spec

Closing in favour of https://github.com/matrix-org/matrix-doc/issues/2759


sm2 sign bug

The bug I found is about function sm2_sig_gen in crypto/sm2/sm2_sign.c:185 .
Explicit formulas:
x1,_ = kG , r = (x1 + e) mod N,  s = (d + 1)^-1 * (k - rd mod N) mod N
We only check  r == 0 or r+k == n , but there is another condition that always makes s zero. and in that case, when we verify the signature, since we do check BN_cmp(s, BN_value_one()) < 0,  the signature is always invalid.
Here I give the case of message that makes s zero. e is the big number form of message's hash. when e == ( ( ( d ^ -1 )mod N ) * k - x1 )mod N, s is always zero.  That is to say we signed an invalid signature.
To solve this problem, I suggest  adding codes in sm2_sign.c:263 :
if (BN_cmp(s, BN_value_one()) < 0)
continue;

@InfoHunter, @romen - thoughts?

It's true. This is kind of the dual of #8435, which makes s zero by choosing d=N-1 (invalid, spec wise).
But if this fix was in OpenSSL right now, you'd have an infinite loop DoS ;)

It's true. This is kind of the dual of #8435, which makes s zero by choosing d=N-1 (invalid, spec wise).
But if this fix was in OpenSSL right now, you'd have an infinite loop DoS ;)

So, you meant  to find N ^ -1 mod N when generating s if d=N-1?
Actually, I meant that you would do an invalid signature even if your secrete key is valid(not an invalid d). For a given message e,  it's to hard to know which random number (denoted by k) will makes s invalid (zero) when generating signatures, but we do know this kind of situation maybe happen if we do nothing will s. So, I turn to a new direction, Assume we geneated a   random number k when computing s, we were able to know which exact message (denoted by e) we can't sign, that is , a message where e == ( ( ( d ^ -1 )mod N ) * k - x1 )mod N,

I meant that you would do an invalid signature even if your secrete key is valid

I know what you meant :) I understand the math.
I think in these situations instead of silly loops for corner cases, it is best just to have flat signature code, then just return failure if you hit a corner case. For example, the case you are talking about, happens with the same probability as me guessing an SM2 key.
Yes it punts the problem to the application but pushing code complexity into the lib seems silly to me.
(My claims are the same for ECDSA and deterministic ECDSA schemes.)

It's true. This is kind of the dual of #8435, which makes s zero by choosing d=N-1 (invalid, spec wise).
But if this fix was in OpenSSL right now, you'd have an infinite loop DoS ;)

As for #8435, my viewpoint is that we should be unable to generate a signature  with such invalid key, namely, you will always get a nullptr when sm2_do_sign with d == (N -1). And the issue in here is quite different. It can reach the result and return a (r,s). Exactly, I don't think adding such codes in openssl will lead to an infinite loop. It is because we should get an error from  (d + 1)^-1 mod N where  the key is invalid. You wlll return from sm2_sign.c:261. (if (!BN_add(s, dA, BN_value_one())
|| !ec_group_do_inverse_ord(group, s, s, ctx)
|| !BN_mod_mul(tmp, dA, r, order, ctx)
|| !BN_sub(tmp, k, tmp)
|| !BN_mod_mul(s, s, tmp, order, ctx)) {
SM2err(SM2_F_SM2_SIG_GEN, ERR_R_BN_LIB);
goto done;
} )
In addition, In function ec_group_do_inverse_ord  we should check (d + 1) != 0 before when we use fermatInverse to calculate (d + 1) ^ (N - 2) mod N, or you will go further into a wrong direction.

@mattcaswell Any idea?

I meant that you would do an invalid signature even if your secrete key is valid

I know what you meant :) I understand the math.
I think in these situations instead of silly loops for corner cases, it is best just to have flat signature code, then just return failure if you hit a corner case. For example, the case you are talking about, happens with the same probability as me guessing an SM2 key.
Yes it punts the problem to the application but pushing code complexity into the lib seems silly to me.
(My claims are the same for ECDSA and deterministic ECDSA  .)

:)Yes, there's a very low chance so that one who committed the codes does not take this into consideration. But different from invalid key (that's the problem of ec_generate_key) which we treat just to return an error and a null pointer, this is a valid private key. We should generate a valid signature for a valid  secrete key. Or user who uses this doesn't know what's happening and what to do with it.  By loops(just like ecdsa to find a non-zero s), we can produce a valid signature because the more times we loop, the less possible we will sign  an invalid signature with a limit zero.

@bbbrumley I think what @zhangzhanli raised is another problem from #8435.
#8435 depicted a problem in OpenSSL SM2 key generation, while this thread raised a new problem that random number k will cause s to 0 and it eventually makes the SM2 signature invalid.
To prevent the application from getting an invalid SM2 signature, there seems two ways of doing this:

Just return error if s is equal to 0, or
Insert a loop to compute another valid s thus we can return a valid signature to caller

So what @zhangzhanli suggested for us is to do option 2 instead of option 1?

Well, I just reviewed the SM2 specification and it requires to check if s is equal to zero, if so then the signature algorithm needs to re-generate a random value k. So the current OpenSSL implementation seems not quite right...

I consider this is worth a fix in the signature generation function of SM2, what do you guys think? @mattcaswell @bbbrumley

GOST signature uses loop in the signature callback for this purpose

Thanks for reviewing, Paul. I think my terminology is confusing the two of you -- "dual" in mathematics informally means things that are different, but somehow related. At the end of the day, both this and #11688 reach invalid signatures because ś=0 holds. Although they both reach that in different, clever ways.
But I want to reiterate, you cannot implement fix 2 in OpenSSL as long as #8435 is not resolved. Or attackers can DoS OpenSSL with an infinite loop using the invalid key from #8435.

I consider this is worth a fix in the signature generation function of SM2, what do you guys think

I agree. Checking the spec, OpenSSL code is not consistent.

But I want to reiterate, you cannot implement fix 2 in OpenSSL as long as #8435 is not resolved. Or attackers can DoS OpenSSL with an infinite loop using the invalid key from #8435.

Now I understand what you meant, then it seems we need to address dual problems (keygen and sign) at the same time? ;-) I recall that some discussions are still active in other threads indicating that fixing #8435 is not very easy at current stage?

"not very easy" is accurate ;)
I think the advice of @zhangzhanli is accurate and try to split the problem for now

different from invalid key (that's the problem of ec_generate_key) which we treat just to return an error and a null pointer,

Before returning from ec_group_do_inverse_ord do a BN_is_zero check on the result. Then adding the looping in sm2_sig_gen should be fine.
Another approach would be an early reject of the invalid key in sm2_sig_gen, but that seems like a hack because you shouldn't be able to reach that level of the code without a valid key to begin with IMO.

And yet another approach might be we provide a standalone SM2 key generation ability aside the current EC code and place that with the new provider framework (in the keymgmt part I guess?) - then we can resolve the d == (N -1) keygen problem; Then we can add a loop in sm2_sig_gen.
But I also accept the following approach mentioned by you:

Before returning from ec_group_do_inverse_ord do a BN_is_zero check on the result. Then adding the looping in sm2_sig_gen should be fine.

Marking as inactive, to be closed at the end of 3.4  dev, barring further input


Projection Scaling issue

Hi @yuxng ,
I tried to test poseCNN on my own images, I have strange results :

The poses seem to be well estimated but it seems that there is a scaling issue. If I did understand your paper, this probably come from the fact that the bounding boxes (shown with the labels) are mispredicted. But I don't really get why. To record my images, I also used a Asus Xtion Pro Live RGB-D camera with the following intrinsic matrix :
"
[[528, 0, 320]
[0, 528, 240],
[0, 0, 1]]
"
I then tied to test it with another intrinsic matrix (as if I was working with a 1280x960 image) :

The projections look better but the estimated translation vector looks off (just by considering the bleach and mustard). The intrinsic matrix used for this is :
"
[[978.9, 0, 320],
[0, 978.9, 240],
[0, 0, 1]]
"
Do you have an Idea about what would cause this ? Is my first intrinsic matrix right and I am just missing a scaling factor ? Or is my 2nd matrix right and the estimation of the bleach pose is just bad ?
Also, these estimations have been made without ICP refinement.

The network is trained with the specific intrinsic matrix in the YCB_Video dataset. So the distance of the object that the network predicts is related to that intrinsic matrix. You can try to visualize the results using that intrinsic matrix.

Using the same intrinsic matrix as in demo.py, I have a result comparable to my second case. I guess that sense since the intrinsic matrix of my camera is different.
Thanks for you reply !

I am going to retrain the network using my own intrinsic matrix but I have another question regarding that :
Since the intrinsic matrix of my camera and the intrincix matrix of the camera used to capture the dataset, how will that affect the results ?

You might have missed a verb or there is a typo, but your question doesn't make sense to me @TotoLulu94 Although I guess you were asking if it is possible to retrain with owns own intrinsic matrix in case the training dataset got recorded with that camera? Is that your question? If yes I would also be interested in the answer.

Yep that's right :

Since the intrinsic matrix of my camera and the intrincix matrix of the camera used to capture the dataset are different, how will that affect the results ?

@TotoLulu94 I am seeing a similar scaling issue as you have mentioned when using a Kinect with a different intrinsic matrix. The predicted translation vector seems to be off by 10-20 cm. Did retraining on YCB video dataset with your own intrinsic matrix solve your problem ?


Clean up /resources

For the files in the resources directory, we need to decide what to do with each individual file:

[ ] DarwinCore definition Chinese version.xlsx
[ ] DwCTermsForTranslations_2011-10-16_Japanese15.xlsx
[ ] DwCTermsForTranslations_2011-10-16_Spanish.xls
[ ] dwc_terms.csv
[ ] index.html
[ ] simple_dwc.properties
[ ] simple_dwc_MSAccess.mdb
[ ] simple_dwc_MySQL.sql
[ ] simple_dwc_pgsql.sql
[x] simple_dwc_terms_header.csv -> dist/simple_dwc_horizontal.csv eafc308
[x] simple_dwc_terms_list.csv -> dist/simple_dwc_vertical.csv eafc308

@tucotuco can you indicate in my issue what should happen with each file? The checkbox should only be checked once the file has been removed/moved.


upgrade crates-index-diff to v11, with 'normalization' support

See this PR for details: https://github.com/rust-lang/crates.io/pull/5066.
Note that it brings gitoxide in as first step, with git2 being scheduled for removal towards the end of the year at the latest. Once that happens I am happy to submit another PR and see to removing git2 here as well.

@Byron could you ping me here, or re-request the review when this is ready for another round?
( I would still love to have the manual test by @Nemo157 , or I have to finally take the time to figure out my local setup ;) )

@syphar I think it's ready. All non-nix related tests seem to be passing as well. All I had to change is the version number, all fixes were applied in crates-index-diff as well as git-repository.

I updated to v11.1.3 locally and tried running the daemon with registry watcher, that seems to be erroring out when calling peek_changes:
docsrs-web-1  | 2022/09/01 21:50:37 [ERROR] docs_rs::utils: Failed to get new crates
docsrs-web-1  |
docsrs-web-1  | Caused by:
docsrs-web-1  |     invalid number at line 1 column 2
docsrs-web-1  |
docsrs-web-1  | Stack backtrace:
docsrs-web-1  |    0: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
docsrs-web-1  |              at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/result.rs:2125:27
docsrs-web-1  |       docs_rs::build_queue::BuildQueue::get_new_crates
docsrs-web-1  |              at /build/src/build_queue.rs:199:34
docsrs-web-1  |    1: docs_rs::utils::daemon::start_registry_watcher::{{closure}}
docsrs-web-1  |              at /build/src/utils/daemon.rs:31:27

(it would be nice if the errors attached additional context, rather than all being #[error(transparent)], if this is a json error then it could have the path inside the index that failed).

I thought I had reset crates-index-diff_last-seen to the current HEAD before running that, but I missed that the docker setup uses an anonymous mount for the index. After execing in and resetting that it seems to be working ok now. The ref it was attempting to diff from was:
  crates-index-diff_last-seen        fb8f72861d6 Updating crate `scorpion#0.1.3`

Thanks for sharing! I have improved error messages in the new release which will include the line it failed to decode a crate-version from. That should help.
No matter what the trees are that it diffs, I would expect all of these to yield valid lines of crate-versions, so it's surprising there are lines it cannot interpret at all. If this is something you think can be addressed, then the URL to the crates-index used and the hashes of both commits would be necessary to reproduce it. Thanks.

I was able to reproduce it with:
n main() -> anyhow::Result<()> {
    let index = crates_index_diff::Index::from_path_or_cloned_with_options(
        "index",
        crates_index_diff::index::CloneOptions {
            repository_url: "https://github.com/rust-lang/crates.io-index-archive".into(),
            fetch_options: None,
        },
    )?;
    let start = git_hash::ObjectId::from_hex(b"fb8f72861d63ecfd7564ca7eb82f720debe6db4d")?;
    let end = git_hash::ObjectId::from_hex(b"31a1d8c9b1f6851c9b248813b5bb883ba5297883")?;
    let _ = index.changes_between_commits(start, end)?;
    Ok(())
}

> cargo run --release
[....] long time to clone the archive repo
Error: Failed to decode "---" in update-dl-url.yml as crate version

Caused by:
    invalid number at line 1 column 2

(I locally added the filename into the error message too to see where it was failing)
Looks like the issue is this file was added outside the repository schema: https://github.com/rust-lang/crates.io-index/blob/master/.github/workflows/update-dl-url.yml
That shouldn't block us using it here, we are past the commit adding that and modifications like that are rare enough that we can just update once it's fixed.

Thanks so much for your effort!
I have adjusted the fixture generator to also include the .github folder which allows to reproduce the exact same issue, and fix it. Additionally, and finally 😅, I have added the filename to json-deserialization errors which should help debugging without you having to make locally changes, should there be a next time for that.
The fix was published in the new v11.1.5 release.

With CI being green, I think this is ready for another round of reviews. I opted to switch the Oid types used in the docs.rs API to their corresponding gitoxide versions in anticipation of gitoxide being able to fetch the crates index in a month or so, fully replacing git2 in the process.

cc @Nemo157 do you have any more comments / anything to add?

@Byron I'm seeing the merge is blocked because of conflicts, could you rebase so I can merge after @Nemo157 gives his go?

Great to hear it's ready!
It looks like you want to rebase even though rebasing and squashing and merging seems to work through the github UI. Merging into master seems to work without conflicts, but indeed, when rebasing there are a lot of conflicts in Cargo.toml.
While trying it a few times, also with squashing, I grew a little frustrated so I am here asking if it it's OK to merge into master instead. Looking at the history, I merged master into this branch to resolve conflicts some time ago so any nice history that could have been is no more unless I redo the work. The latter seems easier than rebasing, so if that's desired I'd close this PR and create a new one with a single commit.
I could probably get this done within the next hours if I hear from you with direction.
Thank you

Thanks for trying, I think if the alternative is a new PR with single commit I can also just to a squash-merge with github, so we can leave it like it is.
Merge-commits are disabled on the repo.

Squash and merge is fine by me, but @Byron just as a tool you might find useful: when Cargo.lock has merge conflicts I often use git checkout HEAD Cargo.lock and then the cargo command I originally ran; that usually fixes the issues without needing manual edits.

Squash and merge is fine by me, but @Byron just as a tool you might find useful: when Cargo.lock has merge conflicts I often use git checkout HEAD Cargo.lock and then the cargo command I originally ran; that usually fixes the issues without needing manual edits.

Thanks a lot for sharing, I will be sure to remind myself of this advice from now on! Interestingly I had it in the back of my head when sloppily resolving merge conflicts on Cargo.lock knowing it will be overwritten anyway, but somehow didn't manage to get to arrive at simply checking it out.
If there is time for a couple of days more, I will upgrade the version of crates-index-diff to also clone using gitoxide - these clones are faster - in case it's of interest.

Looks good to me. I'm happy to wait a couple days then I can do some manual testing (currently we never clone the repo as everything runs on the same instance, but we may be migrating some infrastructure around that will cause some new clones so having it faster would be useful).

That's great to hear! Just now I managed to fully replace git2 in crates-index-diff and took the liberty to do the same here, removing git2 entirely which hopefully helps compile times to stay more or less the same.
Commit 3423ea5 also contains a note that the reviewer might find interesting as it makes an assumption.

Looks good to me. I'm happy to wait a couple days then I can do some manual testing (currently we never clone the repo as everything runs on the same instance, but we may be migrating some infrastructure around that will cause some new clones so having it faster would be useful).

@Nemo157 manual testing would be awesome, so we're safe with a change like this.
Regarding the new infrastructure work: I remember I tested the separate registry-watcher (start-registry-watcher) and saw that it currently also doesn't support cloning the initial repo. I assume that's why we're cloning the index repo in entrypoint.sh.

That's great to hear! Just now I managed to fully replace git2 in crates-index-diff and took the liberty to do the same here, removing git2 entirely which hopefully helps compile times to stay more or less the same.

Awesome!

Something I thought would be worth mentioning is that gitoxide, similar to git2, leaves a small pack after each fetch operation. It's planned to implement fetch.unpackLimit to auto-unpack small packs, and to eventually support limited repacking as well (i.e. there are 10k loose objects, let's put those into a pack). I will keep crates-index-diff uptodate with relevant releases of gitoxide and probably post PRs with updates here if that's OK with you.
The above is probably a long-winded way of saying: nothing changes for you, as I saw that git gc is invoked in code from time to time already to alleviate the 'too many small packs issue', but I think that one day gitoxide can do the right thing based on existing git-configuration variables to keep repos well maintained automatically.

@Nemo157 it would be awesome if you could help with a short review & a manual test here.

ping @Nemo157 for a test, only for the case that this got lost. I totally understand if there wasn't time.

I've got this running on my server now. Initially seems to be working fine, it added a bunch of crates from the ~100 commit old last-seen-reference I set and has added a few more since. I'll leave it with the registry watcher enabled for now to see if anything happens.

I haven't seen anything weird skimming the last 13 hours of logs, so this seems to be working fine.

@Byron could you merge master & fix the conflicts? Then I'll squash-merge this PR

It's finally done 🎉.


Updates to the Template

I did implemented some updates that add some functions, add some customized layouts and streamline the worklfow

@kbjarkefur needs you to accept the pull request, and maybe upgrade my status ;)

@rdoino-wb, before merging could we remove the DS Store files? Adding them to the gitignone. Also, I see that many logos are deleted, are these not needed? I only see a warning coming from here as the file does not exist in that direction.
Sorry for the delay.


donot work in win7 win8 win10 with UAC

Demo all do not work

this isn't generally possible
google "drag drop with uac dont work" an read about it
But maybe that is one approach
https://stackoverflow.com/questions/14091626/how-to-enable-drag-and-drop-between-normal-uac-elevated-privileges-application

@landrix
I Mean Project can conain the Solution ChangeWindowMessageFilterEx


Create convert-array-to-number.md

Hi there!
This is my first pull request! please let me know if I need to fix anything! :) thanks

Hey! The code looks good 😄
Could you maybe write a bit about the use case? It seems it's very special, but I might be overlooking something 😉

Hi there, I already put some examples right below the code, do you need more use cases?
Thanks!


fix: Redshift unload not escaping SQL query

Feature or Bugfix

Bugfix

Detail
redshift.unload_to_files wasn't escaping SQL query. As such, the user has had to escape the SQL query themselves when querying a string value.
Relates

#1116

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: dfa9e3d6828fd602be8b90633bd1dd226b5e2222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: dfa9e3d6828fd602be8b90633bd1dd226b5e2222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 267474f2bc766d7e69da763a0507e79035832548
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 267474f2bc766d7e69da763a0507e79035832548
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Demo App is broken

Hello,
the demo app at https://pingcrm-yii2.tebe.ch/login shows an empty page.
The JavaScript console error is:
vue.runtime.esm.js:620
   [Vue warn]: Property or method "$page" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

found in
--->  at resources/js/Pages/Auth/Login.vue

#
The same is seen when doing a git clode and npm ci ... , as described in the README.
Thank you.
Kind regards
Jaochim

Thanks for reporting. I suspect this has to do with the dependabot fix and deployment, which seems to be executed on every commit to the master branch. I'll try to fix this soon.

Fixed with 755356c3909b9a827c6fb340702a0d2c56f5280a reverting back to the last working version.


Integration with vuex-persistedstate creates error

Steps to reproduce

Clone https://github.com/laurensiusadi/feathers-vuex-persistedstate-problem (feathers-vuex-chat with vuex-persistedstate installed)
Run repo as it should with feathers-chat server too
Sign up then sign in
Send a chat
Refresh browser (a chat sent earlier is loaded from localstorage)
Try hitting delete button (uses message.remove)

It will throw error

Now try send new chat
Click delete button immediately without refresh in between
Chat removed without error

Expected behavior
Able to delete record using message.remove()
Actual behavior
Error thrown with data from localstorage
System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
NodeJS version: 12.16.0
Operating System: Windows 10
Browser Version: Opera 66, Firefox 73
Additional info
Error behaviour was found initially on a private repo, with vuex-persistedstate and vuex-persist using localstorage and localforage (async) both tested giving same error for all record methods (patch, remove). Turns out error is able to be duplicated using feathers-vuex-chat.

The problem was object rehydrated from localstorage uses JSON.parse() so it becomes plain object instead of a model object.
Solution:
const persistPlugin = (namespace, paths) =>
  createPersistedState({
    key: namespace,
    paths: paths,
    rehydrated: store => {
      const state = store.state[namespace]
      const commit = store.commit
      Object.keys(state.keyedById).forEach(id => {
        const record = state.keyedById[id]
        commit(`${namespace}/removeItem`, record)
        commit(`${namespace}/addItem`, record)
      })
    }
  })

It might also be possible to use the hydrateAPI method.  The docs are currently missing the API signature for it, but you can see it in the example code.  It basically does what you've done above.

@marshallswain Yes, I'm copying the code from hydrateAPI, but since I use multiple store plugins, I decide to use that code so I don't call hydrateAPI multiple times.


removed old reference to 'az appliance' and replaced with 'az managed…

The documentation for managed apps has not been fully updated to the latest changes with the Azure cli

@MJZawacki - thanks for making this fix. Unfortunately, we recently reorganized the managed applications documentation so this topic no longer exists. The Azure CLI examples have been updated to show the latest commands. See https://docs.microsoft.com/en-us/azure/managed-applications/scripts/managed-application-cli-sample-create-application

#please-close


Bugfix: scaled addressing mode: round B1 up to one byte.

Issue uncovered by Ben Bouvier during regalloc work.

Sure thing, sorry about that -- verified that this case hits the assert without the fix.


Stuck on Loading

Hello, when I try to watch a video from my feed, it just get stuck on "Loading"

I have deleted the config, relog into my instance with token and still problem persists..

Did you try changing instances as well?

i will try but if i change instance there i cant see my subs, i am using invitui to follow my channels rarely i need to search for other stuff. will try when i get home and let you know see if we can get to the button of this. thanks

@darkhz ok I did that same result when I press enter I get mpv: unable to load video or similar is super fast so cant read the whole thing.

Try loading the stream manually

Press ';' on a video item to open the link popup, copy the invidious link.
In another terminal, type mpv <your invidious link> and see if mpv actually plays it.

@darkhz ok I did this, same  result :(

Ah, then this has something to do with the stream, youtube-dl or mpv.

I've been having the same problem since around a month ago, and in my case, MPV is able to load videos correctly. However, and sadly, invidtui has stopped working for me. Every video/audio that I try to play fails with the message "MPV: unable to load [video name]". I just tried manually copying the Invidious link and opening it with MPV and it works.

@Leblake can you provide the link of the invidious item which you are trying to play, so that I can test it as well?

Here's the link: https://iv.ggtyler.dev/watch?v=-_70t906txA. Happens with all links, can't use invidtui anymore. :(

The issue was found, apparently invidtui is using invalid parameters while sending files to MPV. A fix will be issued soon.

Wow, that was lightning fast. Awesome work. :love_you_gesture:

A quickfix has been released for now. This issue will be closed, and maybe later a status screen may be implemented, so that the user can monitor the stream that is currently being loaded, for potential errors, if any.


Disable query injection when key exists already

When using ConnectedRouter you may have already set a query with a custom parser like this
const history = qhistory(createBrowserHistory(), stringify, parseQueryString);

<ConnectedRouter history={history}>

This PR ensures it doesn't override existing queries which may have different parsing logic
Ive published this under https://www.npmjs.com/package/@dr3/connected-react-router for the meantime :)

This would solve #383 too.

Sorry for slow response. LGTM!

This introduced a bug. The reducer query field is only updated when it has disappeared and reappeared.
Here's an example: in our product a Lightstep, we use query params for the chart time window (?time_window=). We use a history replace action to change the time window, and the URL time window is the authoritative source of that state (good for link sharing). With this change, the reducer query field never updates when the location.search changes.
I think the if (location && location.query) statement should be if (location && location.search === state.search), so it updates when the query params change, but accomplishes the goal from this PR.
Would that work for you @dr3?

Ah, apologies @tedpennings. Its been a while since I worked on router, I havent tried this out, but in my usage
const history = qhistory(createBrowserHistory(), stringify, parseQueryString);

my worry would be that when search does change, it would override the output of parseQueryString with the implementation in this package. But I agree, I think this did introduce a bug for those not using qhistory to manage its query string separately

@dr3 that's reasonable. I'm not very familiar with qhistory. Maybe we could pass a custom query string parser to createConnectRouter, defaulting to the one in this package?


x509: certificate signed by unknown authority

I am hit with this message during "Testing with NodeJs App" step. I used a new OpenSSL certificate as per the instructions in the FAQ.
kubectl apply -f https://raw.githubusercontent.com/dgkanatsios/azuregameserversscalingkubernetes/master/artifacts/examples/simplenodejsudp/dedicatedgameservercollection.yaml
Error from server (InternalError): error when creating "https://raw.githubusercontent.com/dgkanatsios/azuregameserversscalingkubernetes/master/artifacts/examples/simplenodejsudp/dedicatedgameservercollection.yaml": Internal error occurred: failed calling webhook "aks-gaming-webhookserver-mutation.azuregaming.com": Post https://aks-gaming-webhookserver.dgs-system.svc:443/mutate?timeout=30s: x509: certificate signed by unknown authority
Is this because I am using OpenSSL, instead of a valid CA. Is there a way to get past this without actually procuring a cert from a CA?

Hi @uthappa123,
You can temporarily deploy my version of api server instead in the meantime.
https://raw.githubusercontent.com/hieumoscow/azuregameserversscalingkubernetes/master/artifacts/deploy.apiserver-controller.yaml
I will make a PR for the Self-signed OpenSSL guide when I have it.
Hieu

Thanks a lot. That worked!


Feature/lw/get return parking pass

Flipped the logout icon on home screen so arrow is pointing left instead of right.
Styling changes for getting a parking pass and returning a parking pass.


Add call batching?

Would fix #14. Something along the lines of Lighting.BatchBegin() and Lighting.BatchEnd(). Calls would be stored and applied only when BatchEnd is called. Would allow for removing unnecessary overhead of Lua and unnecessary set_led_enabled calls.

Batching would be optional. Essentially, there is a batcher class such that if BatchBegin wasn't called, commits requested change immediately, else stores it. For set_colour, the code in #14 would be a good start.

Can do it
what about the batcher class, should it be member of Sio?

I just implemented this in commit 9f30e84. CPU usage is now 0% even with the previous delay of 80ms.


use getEnvironment to pull correct apiRoot

Details
Staging versions of the apps are not able to connect with Plaid test credentials in the native apps because we always use the .env.production credentials there. This change is necessary so that we can ask QA (and internal testers) to test the VBA flow in TestFlight and Google Play store versions of the app.
Fixed Issues
$ https://github.com/Expensify/App/issues/5075
Tests
Tested that the app continued to work normally on dev builds + web. The specific change here is not easy to test locally since the app needs to be a "beta" version.
QA Steps

With the app installed on the device navigate to staging.new.expensify.com/bank-account
Select the option to log in to bank account
Enter the test credentials (bank: Chase user: user_good pass: pass_good)

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Oh hmm actually just realizing that as a side effect of this change anyone using the beta version of the app effectively won't be able to set up a bank account properly. I'm not sure who we allow to access the beta or if this matters.

Making this a draft for now so that we can get some feedback on this https://github.com/Expensify/App/issues/5075#issuecomment-914525831

Alright this one's ready now.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @ctkochan22 in version: 1.0.95-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add some file-related assertion

Adding some assertions allowing us to test wether files AreEqual or AreNotEqual would be a good improvement for testing file processing procedures.
Here is an example of overloads that could be implemented : http://www.nunit.org/index.php?p=fileAssert&r=2.5
I personally like the filenames and streams overloads.

How would the file comparison done? I like the idea.

What about comparing MD5 hashes? Delphi now has a System.hash unit with classes for MD5 and SHA-1 hashes generation. They only take Strings as inputs though.
I posted a question regarding hash generation against entire files here
I'm open to any other way to do it.
I just think performance should be a concern in a unit test execution context.

I'll accept a PR wth a DUnitX.FileAssert unit, hook it up in the same way as DUnitX.Assert is hooked up in TDUnitX.Create - will need ifdefs if you use something not available in earlier versions of delphi.

I'm actually working on this now.  I was looking at the System.Hash and unfortunately it does not have a procedure to hash a file.  Everything is done based on string or TBytes, meaning that the entire file would have to be loaded into memory and thus negating most of the benefits or doing a memcompare of strings.  I am going to look at LockBox via IFDEFS possibly and/or leave the hash functionality as plug-in-able for other solutions people may want to add.
On another note, I'm adding the ability to point to a FixtureData folder that can hold files that the FileAssert object will let you compare to making it easy to create, edit, and version control the "expected" file data.
Hopefully done in the next day or so and will update my existing PR with the changes.

No point in comparing hashes.   Generating the hash would involve reading the whole file.   So you could do a byte by byte comparison reading both files at the same time.   I would check the size first as it's an easy failure.

Glad you said that - I was thinking the same thing, but thought maybe I was missing something.  My comparison is currently using 4k blocks and does do a size check to short circuit if different.


iOS18 HEIC photo open failed

Describe the bug
When opening a photo shot by an iOS 18 device, will get an error: 'Invalid input: Unspecified: Metadata not correctly assigned to image'.
Steps/Code to Reproduce
from PIL import Image
from pillow_heif import register_heif_opener

register_heif_opener()

Image.open("path_to_img").show()

IMG_6849_1.zip
Expected Results
Open image successfully
Actual Results
PIL.UnidentifiedImageError: cannot identify image file 'path_to_img'
Versions
3.12.0 | packaged by Anaconda, Inc. | (main, Oct  2 2023, 17:20:38) [MSC v.1916 64 bit (AMD64)]
Windows-11-10.0.22631-SP0
0.16.0
{'libheif': '1.17.6', 'HEIF': 'x265 HEVC encoder (3.4+31-6722fce1f)', 'AVIF': 'AOMedia Project AV1 Encoder v3.8.2', 'encoders': {'x265': 'x265 HEVC encoder (3.4+31-6722fce1f)', 'aom': 'AOMedia Project AV1 Encoder v3.8.2', 'mask': 'mask'}, 'decoders': {'libde265': 'libde265 HEVC decoder, version 1.0.15', 'aom': 'AOMedia Project AV1 Decoder v3.8.2'}}

Thank you for reporting this, can not promise fix to arrive soon, as it will require new version of libheif to be published.
Reference: https://github.com/strukturag/libheif/issues/1190

Is it possible to create a new release with this fix ASAP? This update in libheif is necessary for users with iOS18, and it is a breaking change.

Release is planned for tomorrow or a day after.


indicator-sound-switcher: fix Gtk Namespace error

Description of changes

indicator-sound-switcher on master has been broken for quite some time:
nix run nixpkgs#indicator-sound-switcher
Traceback (most recent call last):
  File "/nix/store/0kkmhyrzmj5ym22vgjccb4frx50hlxlg-indicator-sound-switcher-2.3.9/bin/..indicator-sound-switcher-wrapped-wrapped", line 6, in <module>
    from indicator_sound_switcher import main
  File "/nix/store/0kkmhyrzmj5ym22vgjccb4frx50hlxlg-indicator-sound-switcher-2.3.9/lib/python3.11/site-packages/indicator_sound_switcher/__init__.py", line 32, in <module>
    from .indicator import SoundSwitcherIndicator, APP_ID
  File "/nix/store/0kkmhyrzmj5ym22vgjccb4frx50hlxlg-indicator-sound-switcher-2.3.9/lib/python3.11/site-packages/indicator_sound_switcher/indicator.py", line 8, in <module>
    gi.require_version('Gtk', '3.0')
  File "/nix/store/ak80bykk8halwf1klflhvpncq9lw2f8s-python3.11-pygobject-3.48.2/lib/python3.11/site-packages/gi/__init__.py", line 122, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available

Moved gobject-introspection to nativeBuildInputs as suggested here https://github.com/NixOS/nixpkgs/pull/174422#issuecomment-1344413989
Not sure if removing gobject-introspection from progagatedBuildInputs has any unintended effects, but it works on my end.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Pinging maintainer: @Alexnortung

Add a :+1: reaction to pull requests you find important.

Anyway, do you mind also changing that platforms = [ "x86_64-linux" ]; to platforms = platforms.linux in another PR?


[NETBEANS-451] search for git revision instead of mercurial one.

Changed to search for ".git/HEAD" instead of ".hg/dirstate"

Why not changing the class name instead of adding a comment explaining why the name is no more relevant ?
Prefer using uppercase 'L' to denote long type (0L is more readable than 0l)

Why not changing the class name instead of adding a comment explaining why the name is no more relevant ?
Changing the name of this ant-task will lead to more changes in the build scripts itself. This pull-request just changes the source of the generated ID but not the "behavior" of the ant-task.

Nice work, I also wanted to implement the support for .git, so thanks for taking care of that.

I see general agreement and came to the same conclusion as the other reviewers - this looks good and a testbuild resultat in the expected result (revision is part of product version). I'm merging this to master.
Thank you!


Update Barbarian Assault pbs 1.4.1

Adds a small feature !ba gc adding 1 more network IO for alt gamble count support
New network IO is located in grabgc() and implemented in gcLookup() and is limited behind by a config with a relevant warning

The core already has a !gc command - are you aware youre duplicating that?

I don't plan on adding anything to this PR. Is there anything I need to do to fix this PR? Otherwise when will a review be expected? Anything would be greatly appreciated.


docs: plugin creation documentation

Having been experimenting with the plugins setup in #388 and how it works, I was thinking that we could maybe have a docs/07-plugins.md file or modify the plugins section of the 03-customization.md file to incorporate some information about the process / steps for building your own plugin and how everything ties together.
This might help other potential contributors, and lead to more collaborations on PRs etc.
Happy to have a first stab at it, if you think it would be useful?

I think this is a great idea - I don't know that I'd ever be talented enough to build any of my own, but it would definitely help me learn the architecture better while troubleshooting/helping others with the issues as I've been trying to do.

I think this is a great idea - I don't know that I'd ever be talented enough to build any of my own, but it would definitely help me learn the architecture better while troubleshooting/helping others with the issues as I've been trying to do.

@eiddor exactly what I was thinking! I am new to the balena team, and on the hardware/distribution side so was working on the RoonBridge plugin linked above in part because Roon is great software but also to teach myself more about balenaCloud / balenablocks / balenaSound and how everything ties together...much easier to do this with an actual project I thought 😄
Have hit a number of road blocks, but that is not necessarily a bad thing - failing helps to learn things sometimes I guess!
But some of the things surrounding plugins and how they interact with the audio block could quite easily be documented I feel, and help people like you and I to get going a bit quicker. Haha.

@eiddor exactly what I was thinking! I am new to the balena team, and on the hardware/distribution side so was working on the RoonBridge plugin linked above in part because Roon is great software but also to teach myself more about balenaCloud / balenablocks / balenaSound and how everything ties together...much easier to do this with an actual project I thought 😄
Have hit a number of road blocks, but that is not necessarily a bad thing - failing helps to learn things sometimes I guess!
But some of the things surrounding plugins and how they interact with the audio block could quite easily be documented I feel, and help people like you and I to get going a bit quicker. Haha.

I would definitely be to willing to help more I had a good starting point like this.
To be honest, maybe even take it up a level to docs/07-architecture.md to explain how all of the balena* components work together, too.
I know I've had to do a lot of Googling/tab opening to try to isolate things like how librespot related to raspotify which related to the spotify plugin (I'm still missing something from the other day).  But I also had to do some digging to figure out an alsa fix in balenaSound that @tmigone fixed for me a few weeks ago.

I would definitely be to willing to help more I had a good starting point like this.
To be honest, maybe even take it up a level to docs/07-architecture.md to explain how all of the balena* components work together, too.
I know I've had to do a lot of Googling/tab opening to try to isolate things like how librespot related to raspotify which related to the spotify plugin (I'm still missing something from the other day).  But I also had to do some digging to figure out an alsa fix in balenaSound that @tmigone fixed for me a few weeks ago.

@eiddor I just discovered we already have all this info in this doc on arhitecture
Plugins info here - https://github.com/balenalabs/balena-sound/blob/master/ARCHITECTURE.md#plugins-1
Guess we just need to link to it more clearly somewhere.
Also this is helpful - https://github.com/balenablocks/audio#usage
Guess it could be fleshed out with some more examples etc potentially

@eiddor I just discovered we already have all this info in this doc on arhitecture
Plugins info here - https://github.com/balenalabs/balena-sound/blob/master/ARCHITECTURE.md#plugins-1
Guess we just need to link to it more clearly somewhere.
Also this is helpful - https://github.com/balenablocks/audio#usage
Guess it could be fleshed out with some more examples etc potentially

Ahhh, extremely helpful - I'll have a look at them later.  I agree that making it more prominent along with some examples would help others even more.
Thanks, @shawaj !

Ahhh, extremely helpful - I'll have a look at them later.  I agree that making it more prominent along with some examples would help others even more.
Thanks, @shawaj !

Also @eiddor take a look at #388 and #399 where I have been working on a couple of new plugins. My hackery might help to show how some bits work. Although right now it is not documented very well haha

Also @eiddor take a look at #388 and #399 where I have been working on a couple of new plugins. My hackery might help to show how some bits work. Although right now it is not documented very well haha

@shawaj Believe me, I've been seeing every commit as you push it!  It's a bit above my capabilities as someone who doesn't code, but it's fun to try to read/understand what you're trying to accomplish.  Very helpful!

@shawaj Believe me, I've been seeing every commit as you push it!  It's a bit above my capabilities as someone who doesn't code, but it's fun to try to read/understand what you're trying to accomplish.  Very helpful!

@eiddor I'm not a very good coder to be honest.  Mainly do hardware and distribution but in my previous company (Pi Supply / JustBoom) I worked with a lot of stuff to do with audio cards and associated drivers. So know a little bit about the software side of that.
Mainly I'm just good at googling and copy pasting and seem to have a (sometimes frustrating) desire to find solutions to things that should just work. But I guess that's why we are all into Raspberry Pi, IoT and tinkering - always hunting the next challenge 😜👌

@eiddor I'm not a very good coder to be honest.  Mainly do hardware and distribution but in my previous company (Pi Supply / JustBoom) I worked with a lot of stuff to do with audio cards and associated drivers. So know a little bit about the software side of that.
Mainly I'm just good at googling and copy pasting and seem to have a (sometimes frustrating) desire to find solutions to things that should just work. But I guess that's why we are all into Raspberry Pi, IoT and tinkering - always hunting the next challenge 😜👌


rolled back electron builder version

minimatch ReDoS vulnerability in v23.6.0 of electron-builder
See issue here: https://github.com/electron-userland/electron-builder/issues/7206
This change removes high severity vulnerabilities but introduces some moderate ones.
Note: these are all in the electron-builder dependency chain - which is a dev, not runtime, dependency.

@nkolba Do we still want to revert to electron-builder: ^22.10.3, or can we upgrade to 24.0.0-alpha.8, they fixed the dependency issue in that version.
Or do we prefer to stick to "stable" versions?

No.  Really, just wanted to document the issue.

closing - new PR with electron upgrade and electron builder upgrade gets rid of the issue.


Stack bounty results into a single message

You can send multiple embeds in a single message right? Just send criminal defeated, close bounties and new balance in a single message content, with embeds for all the bounties dueled attached
It's a shame to have to wait for all the messages to send

Unnecessary - Moving to v2

Maybe it should all be rendered into a single image (maybe 2)
Could be much prettier


feature request: add support for bundling .css files

When I try to import element-ui css in my project, I run into the following error:
error  in ./~/element-ui/lib/theme-default/index.css

Module parse failed: /home/igeorgas/webApps/apptree2/node_modules/element-ui/lib/theme-default/index.css Unexpected character '@' (1:0)
You may need an appropriate loader to handle this file type.

| @charset "UTF-8";.el-breadcrumb:after,.el-breadcrumb:before,.el-form-item:after, ... /*more output*/ ...

My main.js entry point
/**
 * Import project's dependencies
 */
import Vue from "vue";
import ElementUI from "element-ui";
import "element-ui/lib/theme-default/index.css"; // <--- this line causes the error

My webpack.mix.js
mix.js('resources/assets/js/main.js', 'public/js/app.js');

Now, In order to overcome this I had to manually configure and reference the built-in webpack.config.js by adding the following lines:
{
test: /.css$/,
loader: 'style-loader!css-loader'
},
@JeffreyWay  Although its indeed very simple to modify the original webpack.config.js file, IMHO It could be helpful to add support for handling .css files in the next laravel-mix version, since handling .css files is a very common task .
Please also refer to this issue

Duplicate of https://github.com/JeffreyWay/laravel-mix/issues/190


[release-0.13] Use release-0.13 branch of test-infra

https://github.com/knative/test-infra created a release-0.13 branch for dependent release branches to use instead of master. Switching our release branch to this should significantly reduce the frequency of automatic update PRs there.
We will get one more no-op 0.13 point release from this, but hopefully no more after that.
Proposed Changes

Update test-infra dependency to release-0.13 branch in eventing-contrib release-0.13 branch

cc @chaodaiG

https://github.com/knative/test-infra/issues/1899

/lgtm


In the "sui-message" component the header and the content are not displayed

In the "sui-message" component the header and the content are not displayed if the “icon” props is transmitted:
<!--Header and content are NOT displayed-->
<sui-message
    header="My header"
    content="My content"
    icon="info circle"
/>

<!--Header and content are displayed-->
<sui-message
    header="My header"
    content="My content"
/>

I'm submitting a ...

[x] bug report

Environment:

Version: 0.11.0
Browser: Chrome 83.0.4103.116 (Official Build) (64-bit)
Language: ES6/7

just add this line
{this.icon && {content}}


API Docs full text search

Use case
Search bar in the API Docs helps us find the right information quickly. But, it can be improved with full text search capability. For example, if I search CupertinoScaffold keyword, it would be great if CupertinoPageScaffold is returned in the search results.

Proposal
Algolia is a good tool for Open Source project documentation. It is widely used by other Open Source projects such as React, TypeScript, and Scala.
References

API Docs: https://api.flutter.dev/
Algolia: https://www.algolia.com/for-open-source/

Obsolete.


fix: make new ui compatiable with old backend api for statement

This PR is replaced by #1431 , so close it.


Method not found: 'Asp.Versioning.ApiVersion Asp.Versioning.IApiVersionParser.Parse(System.String)'

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I use this code to add version on .net freamwork 4.6.2:
Asp.Versioning.WebApi : 7.0.0
Asp.Versioning.WebApi.ApiExplorer : 7.0.0
config:
config.MapHttpAttributeRoutes();
            config.Routes.MapHttpRoute(
                name: "DefaultApi",
                routeTemplate: "api/v{apiVersion}/{controller}/{action}/{id}",
                defaults: new { id = RouteParameter.Optional }
            );
            config.AddApiVersioning(options =>
                {
                    options.ReportApiVersions = true;
                    options.AssumeDefaultVersionWhenUnspecified = true;
                    options.Conventions.Add(new VersionByNamespaceConvention());
                    options.DefaultApiVersion = new ApiVersion(1, 0);
                    options.ApiVersionReader = ApiVersionReader.Combine(
                        new UrlSegmentApiVersionReader(),
                        new HeaderApiVersionReader("x-api-version"),
                        new MediaTypeApiVersionReader("x-api-version"));
                }
            );
SwaggerConfig.Register(config);

controller
[HandleError]
    [ApiVersion("1")]
    [System.Web.Http.AllowAnonymous]
    [Route("api/v{version:apiVersion}/[controller]/[action]")]
    public class BaseController : ApiController
    {
}

[ApiVersion("1")]
public class CustomerController : BaseController
{
}

but when call api method like this, I get error:
http://localhost:63593/api/v1/Customer/GetErrors?userCode=1
<Error ml-update="aware" ml-stage="preload" ml-view="top">
<Message>An error has occurred.</Message>
<ExceptionMessage>Method not found: 'Asp.Versioning.ApiVersion Asp.Versioning.IApiVersionParser.Parse(System.String)'.</ExceptionMessage>
<ExceptionType>System.MissingMethodException</ExceptionType>
<StackTrace> at Asp.Versioning.ApiVersionRequestProperties.get_RequestedApiVersion() at Asp.Versioning.Dispatcher.ControllerSelectionContext.get_RequestedVersion() at Asp.Versioning.Dispatcher.DirectRouteControllerSelector.SelectController(ControllerSelectionContext context) at Asp.Versioning.Dispatcher.ApiVersionControllerSelector.SelectController(HttpRequestMessage request) at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__15.MoveNext()</StackTrace>
</Error>

Expected Behavior
No response
Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version
No response
Anything else?
No response

This all looks correct. Something is amiss at runtime. It's like the assembly isn't present or something. Do you have project that reproduces this behavior? .NET 4.6.2 is supported and I don't see any reason why this would not work.

Last call. Did you ever find the cause of this? Did you create a repro? This looks an assembly was not copied to the output directory or the output needed to be cleaned.

No more information was provided so it seems you solved the problem or abandoned the issue. MissingMethodException implies that an assembly was not copied or deployed with your application or somehow the wrong reference is being used. If you're ever able to provide more context and it wasn't solved, I can help dig into it further.

I hit this as well with an existing project. For anyone else who has the problem I checked my build warnings and noticed one about bindingredirects that I needed to add. Specifically, in my case:
<dependentAssembly>
  <assemblyIdentity name="Microsoft.Owin.Host.SystemWeb" culture="neutral" publicKeyToken="31bf3856ad364e35" />
  <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
</dependentAssembly>

I also had a warning around needing to install the Microsoft.Bcl.Async library as well.
Did both of those and it seems to be back working.

@markjerz Thanks for the follow up information. I had a suspicion it was something like that, but I had no other information and I couldn't repro the  conditions. I'm sure this will be useful to anyone else that hits this issue.

I've run into this issue as well - I've unloaded my projects and then reloaded with dependencies. I saw some warnings about conflicts requiring bindingredircts so I took care of those. Since VS doesn't like to clean solutions I closed the project and deleted the /bin and /obj folders from my project folders, then opened the project again and built the solution.
When I run the program I can access my non-api controller methods, but when I try to call my API methods using postman I get the following error:
"Message": "An error has occurred.",
"ExceptionMessage": "Method not found: 'Asp.Versioning.ApiVersion Asp.Versioning.IApiVersionParser.Parse(System.String)'.",
"ExceptionType": "System.MissingMethodException",
"StackTrace": "   at Asp.Versioning.ApiVersionRequestProperties.get_RequestedApiVersion()\r\n   at Asp.Versioning.Dispatcher.ControllerSelectionContext.get_RequestedVersion()\r\n   at Asp.Versioning.Dispatcher.DirectRouteControllerSelector.SelectController(ControllerSelectionContext context)\r\n   at Asp.Versioning.Dispatcher.ApiVersionControllerSelector.SelectController(HttpRequestMessage request)\r\n   at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__15.MoveNext()"

I think I finally understand why this might be happening. I've provided a detailed explanation in:
https://github.com/dotnet/aspnet-api-versioning/discussions/1079#discussioncomment-9216115
The short, short answer is that if you are targeting .NET Framework greater than 4.5, but less than 4.7.2 and you directly reference Asp.Versioning.Abstractions, NuGet is going to resolve an incompatible combination. The solutions are:

Target .NET 4.7.2 or above
Do not directly reference Asp.Versioning.Abstractions

NuGet will resolve it as a transitive dependency with .NET Standard 1.0

If this works for you, please share so that others can benefit from it.

@johnGeorge4  good to know that seems to be putting on you on the right path. This is less of a .NET Standard issue itself and more of a NuGet resolution problem. .NET Standard is just a set of API contracts; it isn't a runtime. The reason MissingMethodException happens is that .NET 4.5 is being resolved as a direct dependency, but the transitive dependency to Asp.Versioning.Abstractions is being resolved to a higher version. The method signatures between .NET 4.5 and .NET Standard 2.0 are different. The .NET 4.5 implementation is expecting .NET Standard 1.0. This results in an incompatible mismatch.

Had to do some digging into my web.config, but eventually I found where my framework was still being set to the .NET 4.6.1 so I updated it to 4.8.0 and then included the netstandard assembly that I found here: https://stackoverflow.com/a/51743098
<system.web>

.
.
.
</system.web>
This let my project finally run successfully. I then used this response (https://github.com/dotnet/aspnet-api-versioning/discussions/1082#discussioncomment-9183553) to help get my routing on the controller level fixed so I could make a call from Postman to one of my test APIs.
Thanks for all the help! I really appreciate it!


Methods for customizing a click on a cluster

Hello. Thanks for the awesome library!
Tell me how to make a smooth zoom when clicking on a cluster?
Can't understand from the documentation.
Thank you!

What do you mean by "smooth zoom"?

What do you mean by "smooth zoom"?

In general, how can you customize a click on a cluster? For example, zoom slowly to the markers in the cluster or fast, or adjust the zoom scale?

hi! is there any other way for this library to catch the mouseover event for each cluster?

I did something like this
const onClusterClick = (
                event: google.maps.MapMouseEvent,
                cluster: Cluster,
                map: google.maps.Map,
            ) => {
                const markers = cluster.markers;
                const bounds = new google.maps.LatLngBounds();
                if (markers) {
                    for (let i = 0; i < markers.length; i++) {
                        bounds.extend(
                            markers[i].position as google.maps.LatLng,
                        );
                    }
                    map.setCenter(cluster.position);
                    const boundsZoomLevel = getBoundsZoomLevel(
                        bounds,
                        map.getDiv().getBoundingClientRect(),
                    );
                    const initialZoom = map.getZoom() || 9;
                    for (let i = initialZoom; i <= boundsZoomLevel; i = i + 2) {
                        setTimeout(
                            () => setZoom(map, i),
                            150 * (i - initialZoom),
                        );
                    }
                }
            };

Less than 150ms makes it not smooth.
https://stackoverflow.com/questions/6048975/google-maps-v3-how-to-calculate-the-zoom-level-for-a-given-bounds


Make an addition to the directory

Everyone, and yes that includes you reading this no matter who you are, is welcome to contribute to this project and add their own annoying page as long as it complies with the readme.md

#58 added my page

Just wanted to make sure anyone who sees this knows the project can still be contributed to 👍

Updated 4 hacktoberfest

I'm actively maintaining this project again.

Is this issue still open in 2024?

Technically it is still open,  unfortunately I've been locked out of my
github account. At some point in the future, I plan to add allow more
contributors to add to the page.
On Fri, Nov 1, 2024, 12:11 PM AmatulSaboor @.***> wrote:

Is this issue still open in 2024?
—
Reply to this email directly, view it on GitHub
https://github.com/DevvitIO/ReallyAnnoyingDirectory/issues/2#issuecomment-2452143041,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDNDGRA327JPODTXQHHK43Z6OR4FAVCNFSM6AAAAABRARDLT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSGE2DGMBUGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ok thanks


Logrus instances and override

In our codebase, we have 2 to 3 instances of TiKV in certain circumstances. All of them are currently logging through the logrus standard logger.
It would be preferable if each tikv-client instance had his own logger attached to it so it would be possible to configure them differently based on the instance directly.
Every logger could use the standard logger by default and a new method could enable configure a different logger by default.
I'm opening the issue here to get a feeling if this would be an accept PR on this repository, at some point in time, I could take the issue and make the necessary code changes.

@maoueh  I think it is a great idea!


Windows installer using Git for Windows SDK

After discussion, we outlined a set of work that could be done using the Git for Windows SDK to create a reliable Windows installer for Software Carpentry workshops.
Background
In Software Carpentry they teach git and the command line. They've been using the git for Windows installer. (https://git-for-windows.github.io)
However, it doesn't come with nano, make and sqlite, which are other things needed in the workshop. The installer in this repo was written to create one installation that would include all of this software. With updates to the various software however, the installer is now broken.
Work to be done

Use the Git for Windows SDK (https://github.com/git-for-windows/git/wiki/Technical-overview) to develop and document a custom installer which includes nano, make, and sqlite.
Test this installer on different versions of Windows to ensure it will work across different versions of the Windows operating system.

There's an update from Oliver Stueker
"
Just as a heads-up: The next release (v2.15.0.windows.2 or newer) of
the "Git for Windows" installer will include a proper nano editor from the
MSYS2 package repos.
The days where carpentry attendees are running into nano-related roadblock
seem to be numbered.
The release will also have the option to select either vim, nano or
Notepad++ (in case it's installed) as the default editor for git.
"
http://lists.software-carpentry.org/pipermail/discuss/2017-November/005579.html

excited flail

I emailed Oliver to ask if he had a link to that update, so we could know the timeline.


Bump version to 1.17.0

Changelog
Bugfixes

Fix support for wildcard 1Q operators in ISA (@notmgsk, #571).
Fix incorrect compiler selection, leading to long strings of RX and RZ gates not being collapsed (@notmgsk, #591).

Behind-the-scenes

Docstrings (@rigettizach, #594).
Update magicl bindings and magicl version dependency (@colescott, #574).
Improve collinearity comparisons, and allow tests to reduce the comparison threshold (@notmgsk, #593).

don't forget to bump the quicklisp_version in the Dockerfile here as well once the rigetti quicklisp repo is setup

I will update those, but the quicklisp dist won't be ready for a day or two (maybe longer) since I have to wait for IT to provision stuff.

don't forget to bump the quicklisp_version in the Dockerfile here as well once the rigetti quicklisp repo is setup

I will update those, but the quicklisp dist won't be ready for a day or two (maybe longer) since I have to wait for IT to provision stuff.

oic. So this PR is just to bump the version.txt, but we won't actually do the release for a couple of days until the new quicklisp repo is setup?

don't forget to bump the quicklisp_version in the Dockerfile here as well once the rigetti quicklisp repo is setup

I will update those, but the quicklisp dist won't be ready for a day or two (maybe longer) since I have to wait for IT to provision stuff.

oic. So this PR is just to bump the version.txt, but we won't actually do the release for a couple of days until the new quicklisp repo is setup?

No, we will release. It's not a blocker, we can just trigger the deploys manually I think (so they're not dependent on the tests passing).

don't forget to bump the quicklisp_version in the Dockerfile here as well once the rigetti quicklisp repo is setup

I will update those, but the quicklisp dist won't be ready for a day or two (maybe longer) since I have to wait for IT to provision stuff.

oic. So this PR is just to bump the version.txt, but we won't actually do the release for a couple of days until the new quicklisp repo is setup?

No, we will release. It's not a blocker, we can just trigger the deploys manually I think (so they're not dependent on the tests passing).

I might be misunderstanding how the Docker build works, but if the docker image is based on a quicklisp version with the old magicl, won't the quilc it produces be broken (and therefore the QMIs that upgrade to that quilc / qvm docker image)?

don't forget to bump the quicklisp_version in the Dockerfile here as well once the rigetti quicklisp repo is setup

I will update those, but the quicklisp dist won't be ready for a day or two (maybe longer) since I have to wait for IT to provision stuff.

oic. So this PR is just to bump the version.txt, but we won't actually do the release for a couple of days until the new quicklisp repo is setup?

No, we will release. It's not a blocker, we can just trigger the deploys manually I think (so they're not dependent on the tests passing).

I might be misunderstanding how the Docker build works, but if the docker image is based on a quicklisp version with the old magicl, won't the quilc it produces be broken (and therefore the QMIs that upgrade to that quilc / qvm docker image)?

Yeah, you're right (as usual). I'll try to get the quicklisp dist available ASAP.

I guess the other option is that we could "vendor" magicl similar to what we already do for rpcq and qvm, rather than building off the version that is in quicklisp.
Maybe that would cause conflicts or something since both qvm and quilc depend on magicl, and the quilc Dockerfile depends on qvm's docker image while the qvm Dockerfile also depends on quilc's docker image... maybe it could be "imported" in just one of the Dockerfiles.
Unclear if this would be an improvement over setting up our own quicklisp repo :)


Upload Design Diagrams for Design Document 2

Is your feature request related to a problem? Please describe.

In the instructions for Design Document 2, under the Prototype section, part  E (screenshot below) describes the diagrams needed in the repository:

At the time this issue was published, we only have the class diagram (docs/api/class_diagram.jpg)

Describe the solution you'd like

Additional requested diagrams uploaded

Describe alternatives you've considered

N/A

Additional context

N/A

Addressed by #70


docs: use CodeExampleTabs component for avatar page

docs: use CodeExampleTabs component for avatar page

Obligatory GIF (super important!)

:hammer_and_wrench: Type Of Change

These types will not increment the version number, but will still deploy to documentation site on release:

[x] Documentation

:book: Description
Implemented our new CodeExampleTabs component into the avatar page. Also made a few small fixes to the CodeExampleTabs component that I noticed while trying to use it.
Renamed ExampleTabs to CodeExampleTabs as there was already another component in our library called ExampleTabs on the tabs page and it was very confusing.
:bulb: Context
Was trying to figure out how much effort it would be to start implementing this component on all of our pages so tried doing it on one page myself. Not a difficult task but a bit time consuming and tedious. I will break up our existing story for this into multiple stories so we can start working on it next sprint https://dialpad.atlassian.net/browse/DLT-691
:pencil: Checklist

For all PRs:

[x] I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] I have reviewed my changes.
[x] I have added all relevant documentation.
[x] I have considered the performance impact of my change.

:crystal_ball: Next Steps
Break up stories, pull into next sprint.
:camera: Screenshots / GIFs

I'm sure this will be very rare, but not sure how to solve for positioning copy button when first line is long enough to bleed into it.

Can probably just doe "Vue" and "HTML".

Indentation seems to be a little bit too much.
<dt-avatar
        icon-name="person"
    />

<dt-avatar
      icon-name="person"
    />

Maybe like so...

Just put this up. lemme know what you think.

Maybe like so...

Just put this up. lemme know what you think.

Yeah, that placement works. Can remove the redundant "Copy code" Tooltip on hover/focus, but retain the "Copied" Tooltip upon click.

Noticed the Vue|HTML keyboard functionality is broken. Can only focus active tab, and can't keyboard to sibling tab.

Keyboard functionality and "copy code" tooltip fixed.

Copy button only copies Vue.
https://github.com/dialpad/dialtone/assets/1165933/25b7d14b-0371-47fc-b153-5bddcdd2e3bb

Copy button only copies Vue.

Thanks, fixed


A16-0-1: Fix handling of #else.. directives

Description
Fixes https://github.com/github/codeql-coding-standards/issues/386.
The #else family of directives were not treated as legitimate children of conditional preprocessor directives. This PR:

Updates #else to be universally acceptable - we will only report on invalid #..if.. directives.
Updates #elif to be acceptable within a conditional directive, while retaining the ability to report #elif directives with invalid children.

Change request type

[ ] Release or process automation (GitHub workflows, internal scripts)
[ ] Internal documentation
[ ] External documentation
[x] Query files (.ql, .qll, .qls or unit tests)
[ ] External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

[ ] No rules added
[ ] Queries have been added for the following rules:

rule number here

[x] Queries have been modified for the following rules:

A16-0-1

Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?

[x] Yes
[ ] No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

[ ] Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

[ ] Confirmed

Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author

[x] Have all the relevant rule package description files been checked in?
[x] Have you verified that the metadata properties of each new query is set appropriately?
[x] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[x] Are the alert messages properly formatted and consistent with the style guide?
[x] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[x] Does the query have an appropriate level of in-query comments/documentation?
[x] Have you considered/identified possible edge cases?
[x] Does the query not reinvent features in the standard library?
[x] Can the query be simplified further (not golfed!)

Reviewer

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

we seem to have accidentally double addressed this FP report - in this PR


Verify correctness by larger example and proper parameter

[ ] Verify with smaller size
[ ] Verify with larger size
[ ] Generate plot in paper


Created setup.py

Addressing issue #16

nice now try filling content!

@Abdur-rahmaanJ let me read through the project, I may not be much help there! Just created the setup.py for the lols!