Storage prefixes configurable

Is your feature request related to a problem? Please describe.
Hello, I would like to use amplify-ios lib to retreive S3 object from existing S3 but the prefix "/public" is forced. It is therefore impossible for me to find my files.
Describe the solution you'd like
Can you make the prefixes configurable? This would make life easier for existing projects.
Additional context
I see that I can add "pluginOptions" in my request. Maybe I can change/delete the prefix through this? But I can't find the documentation that lists the possible key/values

hi @baillyjamy ,
thanks for reaching out.
The Amplify Storage plugin currently support three different access levels: public, protected, private, defined by the StorageAccessLevel enum.
Each storage request accepts an options  argument based on its type.
For example, below a list request:
let listOptions = StorageListRequest.Options(accessLevel: .private)
Amplify.Storage.list(options: listOptions) { ... }

Unfortunately we don't currently support fully customizable prefixes, but I'll mark this as a possible enhancement and discuss it the team.

Thank you for taking the time to read me and consider my request.
I would like to give you some additional feedback.
I don't think it's a good idea to force people who want to use an aws functionality on mobile to use the Amplify workflow if it's very restrictive, for example in my case, I want to access an S3 instance created without amplify so it doesn't necessarily respect its rules (rules that I don't dispute) but I use Cognito to give access to my S3.
I could use aws-sdk-ios but it's a bad idea to reinvent the wheel. Amplify facilitates Cognito authentication and renews it. Also, all aws-sdk-ios documentation refers to Amplify.
So even if I want to re-implement the Cognito authentication system and connect to my S3 with aws-sdk-ios, it's difficult without documentation.
Well, I may be a lazy guy but I tried to bypass Amplify and reinvent the wheel for Android, it was not a good idea. I'd like to avoid starting again here ^^
What I'm trying to say is that either we need an Amplify that is more customisable and less restrictive, or we need an aws-sdk-ios that is better documented and less in the shadows.
Or maybe I didn't understand anything about Amplify? In that case I'd like some help to find out how you would solve my case.
Thanks for reading, I'm not very good English, it's just feedback, not a request. It's not arrogant.

For reference, this has been requested for Android as well: https://github.com/aws-amplify/amplify-android/issues/910

Hello, I'm coming back to you to see if you're going to add this feature or not. And if so, do you have an idea of when?
On my side I have to make a choice if I use Amplify or not and I have to move forward on the subject of retrieving my S3 objects. Your answer will help me to make a decision.

Hello, being unanswered, I take the liberty of asking you again to find out what you are going to do.

These prefixes should be configurable - developers/end users should decide what's best for them. Can this be request be prioritized?

These prefixes should be configurable - developers/end users should decide what's best for them. Can this be request be prioritized?

The JS client also had this issue and there appears to be a workaround. Wondering if something similar could happen for iOS https://github.com/aws-amplify/amplify-js/issues/332#issuecomment-602606514

Yeah, this entirely breaks our use case - and we cannot re-configure our existing backend setup just to support the forced prefixes.
Please make this configurable - and make it more explicit in the documentation that this behavior occurs.

A discussion on discord, the developer wants to completely remove the prefix. The flexibliity to configure custom prefixes should allow configuring "empty" or no prefix for certain levels.

Still no news for this feature? I don't understand why this feature is implemented for the js lib and not for ios.

This https://github.com/aws-amplify/amplify-ios/pull/1277 been released in https://github.com/aws-amplify/amplify-ios/releases/tag/v1.14.0 Please let us know if you have any questions


Need to manually update state_vim.vim and state_gvim.vim when upgrading Vim version

Problems summary
The state_vim.vim and state_gvim.vim files modifies the runtimepath variable and includes a path to /usr/share/vim/vim80. When upgrading to Vim 8.1, the runtime files are moved to /usr/share/vim/vim81, but the state files are not updated to reflect this. This causes an error when starting Vim because it can't find any files in the old vim80 path.
A common symptom of this is when your vimrc loads the default colorscheme (or any colorscheme that comes built-in with Vim). It can't find the colorscheme in the non-existent runtime path.
I fixed the issue by modifying the state files to point to the new runtime path.
Expected
Not sure how dein should handle the new runtime path when upgrading Vim.
Environment Information (Required!)

dein.vim version(SHA1): 3c9f6e3

OS: Linux arch 4.16.9-1-ARCH #1 SMP PREEMPT Thu May 17 02:10:09 UTC 2018 x86_64 GNU/Linux

Vim/neovim version: Vim 8.1

Provide a minimal .vimrc with less than 50 lines (Required!)
" Your minimal .vimrc
set runtimepath^=~/path/to/dein.nvim/
call dein#begin(path)
call dein#end()

colorscheme default

The reproduce ways from Vim starting (Required!)

Modify the state files to point to an invalid runtime path to simulate the change when upgrading Vim (e.g. change /usr/share/vim/vim81 to /usr/share/vim/vim80)
Run vim/gvim

Upload the log messages by :redir and :message (if errored)
Error detected while processing /home/john/.vim/vimrc
line 5:
E185: Cannot find color scheme 'default'

dein.vim version(SHA1): 3c9f6e3

It is very old version in 2017 Dec.
Please don't report the old version's bug.
It is fixed in the latest version of dein.vim.
Closing.


add junit test for authManager

add junit test for AuthManager

@shaqianqian , can you also add the documentation as we discussed ?
I don't see it.
Thank you

Merged in JMeter through:
https://github.com/apache/jmeter/commit/629c6430e17df7f7f75891d29e2129ab55a57d68


docs(README): Add more extensions for filter paths

Hey there! I tried to add solid-styled to my vite project and copy-pasted code from vite integration docs, but it turns out that it lacks tsx and jsx extensions. I thought that it would be great if we add them, because they are very common.
This PR adds those extensions to bundler integrations README
Thank you for an awesome library ❤

Thanks!


pam: add optional pam_gnome_keyring integration

Motivation for this change
Add Gnome Keyring auto-unlock in addition to similar KWallet option. GDM does this, but other applications not. For example by setting security.pam.services.slim.enableGnomeKeyring = true; there will be an option in Gnome Keyring password asking dialog to remember the password when using default SLIM login manager.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Ref. https://github.com/NixOS/nixpkgs/issues/21859, https://github.com/NixOS/nixpkgs/issues/17044, https://github.com/NixOS/nixpkgs/pull/21860, https://github.com/NixOS/nixpkgs/issues/20608, https://github.com/NixOS/nixpkgs/issues/20608

cc @Mic92


OSD deployment fails due to invalid drive groups syntax

Problem
Due to a recently introduced regression, ceph-salt stopped deploying OSDs.
Symptom
The "Deploying OSD groups 1/1" step finishes immediately, and then sesdev create octopus ... --qa-test ... fails because the cluster has zero OSDs.
Analysis
ceph-salt uses a command like the following to deploy OSDs:
echo '{\"testing_dg_admin\": {\"host_pattern\": \"admin*\", \"data_devices\": {\"all\": true}}}' | ceph orch osd create -i -

When I try this command manually, it fails:
admin:~ # echo '{\"testing_dg_admin\": {\"host_pattern\": \"admin*\", \"data_devices\": {\"all\": true}}}' | ceph orch osd create -i -
Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 1070, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 191, in handle_command
    return dispatch[cmd['prefix']].call(self, cmd, inbuf)
  File "/usr/share/ceph/mgr/mgr_module.py", line 309, in call
    return self.func(mgr, **kwargs)
  File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 153, in <lambda>
    wrapper_copy = lambda *l_args, **l_kwargs: wrapper(*l_args, **l_kwargs)
  File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 144, in wrapper
    return func(*args, **kwargs)
  File "/usr/share/ceph/mgr/orchestrator/module.py", line 437, in _create_osd
    dgs = DriveGroupSpecs(yaml.load(inbuf))
  File "/usr/lib/python3.6/site-packages/ceph/deployment/drive_group.py", line 117, in __init__
    self.build_drive_groups()
  File "/usr/lib/python3.6/site-packages/ceph/deployment/drive_group.py", line 122, in build_drive_groups
    (drive_group_spec, name=drive_group_name))
  File "/usr/lib/python3.6/site-packages/ceph/deployment/drive_group.py", line 228, in from_json
    "Feature <{}> is not supported".format(applied_filter))
ceph.deployment.drive_group.DriveGroupValidationError: Failed to validate Drive Group: Feature <\"host_pattern\"> is not supported

admin:~ # echo $?
22

When I change the single quotes that are around the JSON in the echo statement to double quotes, it succeeds. It also succeeds with the single-quotes, provided I remove the backslashes from the JSON.

This is wrong. Here is the real issue: https://tracker.ceph.com/issues/44270


local library in pom.xml

gerbil.nif.transfer-1.1.0.jar should be included as local dependency. Right now you have to run mvn initialize before the maven build.
This setup is not compatible with maven standard and therefore not compatible to Jenkins.

this library is no longer used.


[PHPStanRules] Skip equal union type on Array typed usage passed on NarrowPublicClassMethodParamTypeByCallerTypeRule

Fixed 🎉

All checks have passed 🎉 @TomasVotruba it is ready for review.


Fix download URL of libtiff for 17.03 release

The recently merged patch (#28027) to change the libtiff download url is also needed in the release-17.03 branch else the package is unbuildable.
Motivation for this change
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

done in 36b4c4ed44333d561ad59c7c0b474439b0443dae
(we use git cherry-pick -x for backports)


Fix Follow Me example

Fix Follow Me example by explicitly setting a non-zero value for absolute_altitude_m in target_location

@julianoes Please check and approve this.
This is related to a similar issue in the C++ SDK https://github.com/mavlink/MAVSDK/issues/2216

@KarthiAru do you mind fixing style: https://github.com/mavlink/MAVSDK-Python/actions/runs/10200136185/job/28238813887?pr=722

@julianoes Done


Use defaultNetworkId to select the network on container create

Once rancherio/cattle#98 is added, use defaultNetworkId to select the default choice in the network dropdown instead of selecting the first one.

Created in Rancher: https://github.com/rancherio/rancher/issues/231


Implement creators and aliases

Aliases are multiple variations of the same creator. A work will have one or more creators, and each of those creators can have multiple aliases. Users can assign creators to works using their aliases, as well as enter new creators, for example, when collaborating with people from other institutions.
Features

changes to an alias should create a new alias tied to the same creator
users may update/add new aliases to existing creators
a work's metadata will have the depositor as the creator, with the metadata auto-populated from LDAP
users may not alter the creator record once it has been saved (for now)
new creators may be added during the work version edit step
new creators may come from LDAP or be entered manually, such as a non-PSU individual
works are searchable by both creator and alias
facets use the creator canonical name only

TODO

[x] Move alias association from work to work version #176
[x] Add new creator/alias combinations to the edit form #179
[x] Send creator/alias and orcids to datacite #186
[x] Index creators and aliases into Solr #178
[ ] Search existing creators both via LDAP and locally added creators #180
[x] Creators/aliases are included in Work History #195
[x] Creators/aliases are included in diffs between versions #202

@awead can give @monksp a quick tour of how this works in current ScholarSphere

Closed in #523


Mapping of ISO metadata datestamp to DCAT

Generally the DCAT-AP metadata only contains information about the data itself not the metadata. That means that the date from the gmd:dateStamp attribute is not mapped to DCAT-AP as it is about the metadata not the data. This mapping is important as the metadata datestamp is important for harvesting purposes.This should be clarified in GeoDCAT-AP

Jakub, Do you think 2 datestamps are needed the one of the original metadata item  which is being mapped and of the actual DCAT Catalog Record entry?

Well, the original metadata item is represented by the DCAT Catalog Record - so they should be the same thing. Do you have another opinion?

No, would be fine with me


list-objects in REST returns list-buckets reply

Describe the bug
Direct to s3, REST list-objects commands return a reply in the following format:
<?xml version="1.0" encoding="UTF-8"?>
<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Name>{bucket name}</Name><Prefix></Prefix><Marker></Marker><MaxKeys>1000</MaxKeys><IsTruncated>false</IsTruncated><Contents><Key>test_file</Key><LastModified>2024-09-06T16:16:10.000Z</LastModified><ETag>"b1d046bfa87363856e8b5bf987a6cabf"</ETag><Size>10</Size><Owner><ID>{canonical ID}</ID><DisplayName>{AWS display name}</DisplayName></Owner><StorageClass>STANDARD</StorageClass></Contents></ListBucketResult>

Via versitygw, something similar to the following is returned instead:
<?xml version="1.0" encoding="UTF-8"?>
<ListAllMyBucketsResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Owner><ID>{key ID}</ID><DisplayName></DisplayName></Owner><Buckets><Bucket><Name>versity-gwtest-bucket-one</Name><CreationDate>2024-09-06T13:15:11.9262355-03:00</CreationDate></Bucket><Bucket><Name>versity-gwtest-userplus-bucket</Name><CreationDate>2024-09-04T13:29:48.504560459-03:00</CreationDate></Bucket></Buckets></ListAllMyBucketsResult>

This is the expected list-buckets reply.
To Reproduce
Run the script at https://github.com/versity/versitygw/wiki/Running-Test-Suite#rest, but replace the list-buckets URL (localhost:7070) with the bucket URL (.localhost:7070 to turn it into a list-objects command.
Expected behavior
Like direct to S3, a ListBucketResult XML message is returned rather than a ListAllMyBucketsResult XML message containing a single bucket.
Server Version
Version  : v1.0.6
Build    : 7e30e63
BuildTime: 2024-09-06_10:20:00PM
Darwin Lukes-MacBook-Pro.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:25 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6030 arm64

If I run with aws cli, it seems to have the ListBucketResult as expected:
% aws --debug s3api list-objects --bucket test 2>&1 | grep "^b'"
b'<?xml version="1.0" encoding="UTF-8"?>\n<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Name>test</Name><Prefix></Prefix><Marker></Marker><NextMarker></NextMarker><MaxKeys>1000</MaxKeys><Delimiter></Delimiter><IsTruncated>false</IsTruncated><Contents><LastModified>2024-09-06T15:50:30.415Z</LastModified><ETag>5843979fc12b3ee91ce87763332b9afc</ETag><Key>test</Key><Size>587</Size><StorageClass>STANDARD</StorageClass></Contents><EncodingType></EncodingType></ListBucketResult>'

The ListAllMyBucketsResult comes from listing buckets instead of listing objects. Could the request you are sending somehow being interpreted as a list buckets instead?

Is there a way to see the underlying REST command when running it from the command line?  It might be a bit different.

OK, I checked the debug output and noticed a difference.  When I send the REST commands, I'm using:
GET
/

host:{bucket name}.<IP_ADDRESS>:7070
x-amz-content-sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
x-amz-date:20240908T000841Z

host;x-amz-content-sha256;x-amz-date
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855

The format s3api uses is:
GET
/versity-gwtest-userplus-bucket
encoding-type=url
host:<IP_ADDRESS>:7070
x-amz-content-sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
x-amz-date:20240908T000841Z

host;x-amz-content-sha256;x-amz-date
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855

It looks like direct S3 properly handes my format, but versity does not.

Ah, yeah I dont know that we can handle virtual host style bucket access. This access assumes path style.  We may need to add a feature issue for virtual host style access if we want to add this.

Closing this and tracking the virtual host addressing feature enhancement in #803


Consume Messages Starting At The Time Of Connection

I only want to consume message that have been committed to the kafka queue after I have connected with the consumer - I want to ignore messages received earlier than this timestamp.  I will be sending many messages so I would have to have to keep track of the most current offset or have to read all messages and drop those in the past.  What is the best way to accomplish this task?
Thanks,
Tim

You can use the offset client to get the latest offset.


[WIP] CB-14224 add license text & GitHub link to template/Properties/Default.rd.xml - proposal (for discussion)

Original issue
https://issues.apache.org/jira/browse/CB-14224
Platforms affected
Windows
What does this PR do?
Proposed template/Properties/Default.rd.xml updates:

add MIT license text from https://github.com/Microsoft/Windows-universal-samples, with left aligment fixed
add link to https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml

Rationale: I think it is desired to add license headers whenever possible to satisfy Apache RAT license auditing tool. While I think it should be possible to configure the auditing tool to skip this file I would rather follow the practice of adding the license text whenever possible.
Marked as WIP since I also proposed updates to LICENSE text in https://github.com/Microsoft/Windows-universal-samples/pull/949.
What testing has been done on this change?
I verified that coho audit-license-headers -r windows with these changes does not show the missing license header any more.
Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

Thanks for the quick review. I am afraid that I don't really understand
your question. I think this piece of XML was intended as some kind of
optional instructions.
On Thu, Jul 26, 2018, 9:24 PM Shazron Abdullah<EMAIL_ADDRESS>wrote:

@shazron commented on this pull request.
In template/Properties/Default.rd.xml
https://github.com/apache/cordova-windows/pull/284#discussion_r205645861
:

@@ -13,6 +13,28 @@

 Using the Namespace directive to apply reflection policy to all the types in a particular namespace
 <Namespace Name="DataClasses.ViewModels" Seralize="All" />

Is this missing the start of the xml comment block?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/cordova-windows/pull/284#pullrequestreview-140960020,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfNULbAJNGavRKlCYRaM5DBeMPegsT4ks5uKmvdgaJpZM4ViuSw
.

As this change is already part of 6.0.x (GH-285) it should now be in master. Title and description have been updated.


Added parsing for TypeLiteralNode

This adds the parsing of records and identifiers to the AST for TypeLiteralNode

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.


implement the MediaPlayer2 Interface

Description
First of all, thanks for the best music player ever 😎
I used i3status-rs to display the current song in my i3 status bar. Is there a plan to implement the MediaPlayer2 interface.
Proposed solution
No response

Do you mean MPRIS? There is mpd-mpris already. Im not sure rmpc is the right place for that. Or why does mpd-mpris not work for you?

Thank you for your suggestion. I have tried mpd-mpris, but the status bar is not working.
➜  mpd-mpris -no-instance
mpd-mpris running
➜  busctl --user list | grep "org.mpris.MediaPlayer2." | cut -d' ' -f1
org.mpris.MediaPlayer2.mpd

Maybe I should submit an issue to i3status-rs

You can try mpDris2, its directly recommended by the i3status.


[Docs] add TS import/parsers settings to Readme

Just a line from the eslint-import-resolver-typescript readme, which is already linked in a nearby code comment; it took me way too long to figure out critical stuff was in that linked readme. Proposing this as it may help others, not sure if it applies for all typescript uses or not.

I'm confused, this should already be covered by https://github.com/import-js/eslint-plugin-import/blob/main/config/typescript.js#L15-L17 which plugin:import/typescript provides.

Ah you're right - extending the recommending plugin caused issues and I had to go granular, I assumed extending the typescript plugin would do similarly, didn't realize it brought settings with it. It also looks like I'm the only one that was confused here lol, so I'll just close. Thank you for your work on this amazing tool!


using phase_common_static: loosing phase with bcftools convert

I'm having a problem with loss of phase after running bcftools 'convert --hapsample' on a bcf created via
 phase_common_static --thread 12 --input chr19.19.filtered.vcf.gz --map map.txt.gz --output chr19.19.phased.bcf --region 19 --pbwt-depth 8 --pbwt-modulo 8 --log chr19.19.shapeit.log  2> chr19.19.shapeit.err
Unfortunately, the system won't let me upload the bcf file, but I think it can be recreated from any bop output from phase_common_static.
When I run this using the bcftools 1.15 (also tested on1.17-56-g402de74a)
bcftools convert --hapsample test6b test6.bcf
The phase is lost in the hap file

19 19:171762_T_C 171762 T C 0* 0* 0* 0*
19 19:209360_G_T 209360 G T 0* 0* 0* 0*
19 19:229783_G_A 229783 G A 1* 0* 1* 0*

When I convert that same bcf to vcf, the phase is preserved
test6b.vcf.txt
When I convert that vcf to bcf and convert to hapsample
    bcftools convert --output-type b -o test6b2.bcf test6.vcf
    bcftools convert --hapsample test6b2 test6b2.bcf

The phase is preserved in the hap file.

19 19:171762_T_C 171762 T C 0 0 0 0
19 19:209360_G_T 209360 G T 0 0 0 0
19 19:229783_G_A 229783 G A 1 0 1 0

When I try converting the original bcf to hap using bcftools 1.3.1 (based on this thread)
bcftools-1.3.1/bcftools convert --hapsample test6b131 test6.bcf
The phase is preserved in the hap file.
So, it seems the way phase_common_static creates phase in bcf is compatible with bcftools 1.3.1, but not the recent versions.(?) Or maybe it is a bcftools issue?

Using 5.1.1

Thanks for this. What about recompiling S5 linking with the last HTSlib version?

I'm sorry, but I don't have time to help further on this.


[scheduler] Implement deflaking backfiller

It would be interesting to use this logic to rerun failed tests to surface flakes. Not needed in this PR though.

https://github.com/flutter/cocoon/pull/1776#discussion_r857897367
https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/service/scheduler/policy.dart;l=1?q=policy.dart&sq=&ss=flutter%2Fcocoon
It would be nice if backfilling tried to rerun failed tasks to see if they passed.

\cc @keyonghan

@XilaiZhang should this still be assigned to you?


Avoid multiple names for built-in fixtures

For example: wf, workflow, execution, ctx.
Ideally, there should be one way to reference each of these fixtures. Is there any compelling reason to provide multiple names?

For example: wf, workflow, execution, ctx.
Ideally, there should be one way to reference each of these fixtures. Is there any compelling reason to provide multiple names?

No reason in particular other than convenience of having a shortened name. I can see how having multiple names could get confusing though.
Also forceing a more descriptive name is probably a good thing to do.
I agree.

The short or long choice is up to you. I am fine either way.
Will you be able to drop the logic that supports the multiple name feature by going with single names?

The short or long choice is up to you. I am fine either way.
Will you be able to drop the logic that supports the multiple name feature by going with single names?

I think using the more descriptive names will be better.
It wouldn't be difficult to remove the support for multiple names, but I don't see the harm in leaving it as an option for user defined fixtures.

The downside is testing, maintaining, documenting, and supporting a feature that enables a pattern we have decided is not Pythonic or a best practice.


ECONNREFUSED FetchError

Storage Explorer Version: v1.14.0
Build Number: 20200624.3
Platform/OS:  macOS Catalina V 10.15.5
Architecture:  x64
Regression From:   Not sure - did not attempt in a previous version
Bug Description
When attempting to upload more than one subsequent file through storage explorer - The app freezes and then the Fetch Error - EconnRefused is presented. I am also now unable to access the storage account via the azure website portal saying that my endpoint is not accessible.
Steps to Reproduce

Log into Azure AD through Azure Storage explorer to connect with Storage Account - the issue persists with either using AD or or storage account keys
Upload one folder from local drive using the upload folder option
Once successful add another file following the above procedure.
This will stall and then not connect correctly and the error will result. "Unable to retrieve Child Resources"
Go to azure portal website and click into the container for which you uploaded the file and you'll now be unable to see the container or access it.

Expected Experience
Expected to be able to upload multiple files through azure storage, copy and manipulate storage folders into different directories. As well as see them in the portal website.
Actual Experience
Storage explorer is able to upload one folder or file and then any subsequent attempt is met with the error. Furthermore you are locked out of the azure storage account on azure's portal website. Effectively locking you out of the storage account.
Additional Context
I have checked the firewall issue and contacted Microsoft about this. They do not know what may be causing it. Thought I'd report the bug to see if it's a mac issue related. The issue seemed to be fixed if I simply deleted the app and restarted my computer - getting rid of any cpu cookies. But I've restarted my computer three times now and the issue persists with Storage Explorer and I'm unable to access the account via the portal website.

@allyson-dev Upload in Storage Explorer are done independently and it is very unlikely that our logic between uploads is causing this issue. If this issue happens to occur after a successful upload, I would guess it is because something is configured to react to data written events in the storage account, which causes it to be locked. So to help us investigate, could you please try the following:

See if this issue occurs on any other storage account
Check if there is any trigger reacting to data written events.

Closed due to lack of response. If you are still having issues please open a new issue.


arm support / check arch

Overview
It is easily possible to run most things on arm, or another architecture that is not x86. However solc-x doesn't check for it, doesn't complain and happily downloads the wrong binary, which then results in exec format error. When I copy a manually compile solc into $PATH, it works however.
At the very least, solc-x should check the arch and complain before downloading and running, or alternatively download the right binary accordingly.
Specification
Ideally, solc-x checks the architecture, and if a corresponding binary is available, downloads that.

Thanks for bringing this up.
Adding a check shouldn't be difficult.  I don't think the solidity team serves binaries for arm but it should still be possible to build it manually when the correct dependencies are in place. Given py-solc-x already does that for OSX, it will (hopefully) be easy to implement for this case.

It should be pretty similar to how it is done on os x, yes.

To avoid duplicating code, where do you think would be the best way to put this? Mayb define _compile_solc and this then gets called from install_osx and install_arm, which both get called from install_solc, where first arch is checked, and then depending on that it is compiled or if x86, the way used so far is kept. Additionally, maybe check platform, as I do not know if / how much relevance arm has on windows (probably very little) or on MacOS (none).

Yes, I think we're in agreement with the approach:

in install_solc, prior to the sys.platform checks, do a check for the architecture and if not x86, call a new _install_solc_arm function
the majority of code in _install_solc_osx can be moved into a _compile_solc method that gets called by _install_solc_osx and the new _install_solc_arm

If there is no additional logic beyond what's needed in _compile_solc, you might be able to omit the _install_solc_arm function in the middle and just call directly from install_solc to _compile_solc.
Admittedly my experience with arm is zero, you're probably more knowledgeable than I in what steps are needed here.  If you want to open a PR I'll be very happy to receive and review it :pray:

Thanks for the reply. I'll try to get a PR soon.

Admittedly my experience with arm is zero, you're probably more knowledgeable than I in what steps are needed here.

Assuming dependencies are installed, it is literally the same as on linux.  (I am only talking arm on linux here) Checking dependencies would depend on distribution or running some cmake command (if I remember correctly solc uses cmake)

Closed in #82


Failed reading from appsetting config

The following setting has failed loading the SafeAggregateSink with following config file:
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
    <startup>
        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.2" />
    </startup>
  <appSettings>
      <add key="serilog:using:RollingFileAlternate" value="Serilog.Sinks.RollingFileAlternate" />
      <add key="serilog:write-to:RollingFileAlternate.logsDirectory" value=".\logs" />
      <add key="serilog:write-to:RollingFileAlternate.fileSizeLimitBytes" value="128" />
    </appSettings>
</configuration>

The problem is in the second key is not logsDirectory but logDirectory without s


[SPARK-15215] [SQL] Fix Explain Parsing and Output

What changes were proposed in this pull request?
This PR is to address a few existing issues in EXPLAIN:

The EXPLAIN options LOGICAL | FORMATTED | EXTENDED | CODEGEN should not be 0 or more match. It should 0 or one match. Parser does not allow users to use more than one option in a single command.
The option LOGICAL is not supported. Issue an exception when users specify this option in the command.
The output of EXPLAIN  contains a weird empty line when the output of analyzed plan is empty. We should remove it.

How was this patch tested?
Added and modified a few test cases

Test build #58106 has started for PR 12991 at commit ee7868e.

Test build #58106 has finished for PR 12991 at commit ee7868e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58106/
Test PASSed.

cc @hvanhovell Could you please review this? Thanks!

LGTM
cc @rxin should we also add this to 2.0?

Looks alright to add.
@gatorsmile can you submit a separate pr to fix the toString for CatalogTableType
It reads really really weird with all the None, Some, Option, List, etc.

And of course the timestamp<PHONE_NUMBER>656

Sure, will submit a separate PR for it.

Test build #58170 has started for PR 12991 at commit eed4e1d.

LGTM pending Jenkins.

Test build #58170 has finished for PR 12991 at commit eed4e1d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58170/
Test PASSed.

BTW do we need to update the description? Is it still accurate?

Just updated it  and now I think it is more readable. Let me know if anything is not clear. Thanks!

@hvanhovell feel free to merge.


Refresh side-labels when collapsed tree is expanded

Which event can I use to refresh the side-label width when I expand a tree node ?
I would like to show the whole tree items in case somebody expands it. Otherwise it gets truncated.
BTW: is it possible to provide an EVENT for the tree plugin if the an item is collapsed/expanded ?

It's there in master, just read the latest docs on ReadTheDocs.

Thx. I was always looking at the latest stable version. Would recommend to drop this link. Might be confusing for others.

stable version is still the official supported version. But i'll release 1.2 soon.


print is not thread-safe

Here is the minimum reproduction:
import 'dart:isolate';

void main() {
  Future.wait([
    for (var i = 0; i < 100; i += 1)
      Isolate.run(() {
        print('test');
      })
  ]);
}

The expected output is 100 lines that each contains a single test, but the actual result is that some of the lines are empty and some of the lines will have testtest.
The underneath issue is that print uses writeln internally, and writeln would print the message and a newline character in two separate calls, causing a race condition between threads.

As a workaround, directly calling write with newline character added to message is thread-safe.
import 'dart:isolate';
import 'dart:io';

void main() {
  Future.wait([
    for (var i = 0; i < 100; i += 1)
      Isolate.run(() {
        stdout.write('test\n');
      })
  ]);
}

Honestly I cannot think of a way to fix this without performance penalty on print.
If we're not going to fix it then it might be worth documenting this limitation and workaround.

Adding the \n on the string will copy the entire string one extra time. That's definitely unnecessary overhead.
(And on Windows, we'd still have to convert the \n to \r\n afterwards.)
One thing we could perhaps do, is to use an internal native writeln call that appends the newline on the native side.
We may have to convert the string to UTF-8 anyway, or make sure it's zero-terminated. Then we can emit the line terminator along with the string contents, in the same native write call.

https://dart-review.googlesource.com/c/sdk/+/330999


mysql database connection migrations already exists.

DB_CONNECTION=mysql
New Fresh MySQL Database Coming migration already exists.
$ php artisan migrate:refresh

   INFO  Preparing database.

  Creating migration table ............................................................................................................... 12ms FAIL

   Illuminate\Database\QueryException

  SQLSTATE[42S01]: Base table or view already exists: 1050 Table '`filament`.`migrations`' already exists (SQL: create table `migrations` (`id` int unsigned not null auto_increment primary key, `migration` varchar(255) not null, `batch` int not null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')

  at C:\xampp\htdocs\root\prod\filament-demo\vendor\laravel\framework\src\Illuminate\Database\Connection.php:759
    755▕         // If an exception occurs when attempting to run a query, we'll format the error
    756▕         // message to include the bindings with SQL, which will make this exception a
    757▕         // lot more helpful to the developer instead of just the database's errors.
    758▕         catch (Exception $e) {
  ➜ 759▕             throw new QueryException(
    760▕                 $query, $this->prepareBindings($bindings), $e
    761▕             );
    762▕         }
    763▕     }

  1   C:\xampp\htdocs\root\prod\filament-demo\vendor\laravel\framework\src\Illuminate\Database\Connection.php:544
      PDOException::("SQLSTATE[42S01]: Base table or view already exists: 1050 Table '`filament`.`migrations`' already exists")

  2   C:\xampp\htdocs\root\prod\filament-demo\vendor\laravel\framework\src\Illuminate\Database\Connection.php:544
      PDOStatement::execute()

This is the default Laravel migration so it shouldn't be an issue with Filament.
Does php artisan migrate:fresh make a difference?


Separate package file detection and analysis

We now have two modules which rely upon detecting package files in projects:

maven-metadata-inferer
javascript-metadata-inferer.

Those two systems have a a common feature: for each element, we check the SCM and/or the local file system looking for packaging files (pom.xml in maven projects and package.json for javascript projects). When we will add python analysis, we will also add lookup of dependencies.txt file. So it would be cool to move and make common the detection file. The different steps should be something like

Change priority of current enhancers to 1 (in order for detection to happen beforehand)
Create a new PackageFileDetectorEnhancer in base module. This enhancer will receive the refactored common code. If you look into MavenPomReader, its the #MavenPomReader#processModelElement(...), the MavenPomReader#processPomAtPath(Element, String) and the MavenPomReader#processPomAtSCM(Element) methods which should be rewritten.
In each of these methods, instead of directly loading the elements, just add a model property linking the file name to its absolute path
Rewirte existing Enhancer to read those properties and load the models instead of directly loading the model (like they currently do)

Fixed in fcee29720ff470dbb89af661097c7d220c0c379f


Throttle 0.2.7 requires Java 9

We've been using 0.2.6 for some time and noticed the 0.2.7 release. As per Semantic Versioning we assumed this was a patch release and referenced the new version. Unfortunately this release requires Java 9.
Would it be possible to release a new version that uses Java 8 bytecode?

Ah, sorry, I wasn't thinking.  There were no actual source code changes, only gradle/travisci/test changes.  I only released it because it was an easy way to make sure the pipeline was still working.  I scanned through this recent Gradle blog post about multi release jars, but it isn't something I have time to dive into and maintain.  I've updated the README with a comment about the last supported Java 8 version and will properly bump the minor or major version if anything needs to be released again.

No worries, thanks for all your work on this great library.


Add djLint for .hbs linting

While djLint has a formatter, the formatter does not produce good results on more complex pages and does not output fatal errors when formatting, unlike Prettier, leading to some pages being formatted even when they had broken syntax.

This PR partially addresses https://github.com/AdvisorySG/dawn-advisory-theme/issues/126, but for reasons mentioned in the description, the autoformatter has not been enabled.

LGTM!
My own testing


Create touchscreen

Add/fix controls for touchscreens.
Left click activates after release. This fixes issue with clicks occurring before mouse position has updated.
Click hold is rebound to right mouse.
Click drag is rebound to middle mouse, except when an item container is being clicked.

The plugin repo was private and has been made public now.

The plugin repo was private and has been made public now.

You should either close and reopen your PR, or push new code then to force CI to rerun. Since your configgroup is still called example instead of something unique, I suggest the latter.

After discussion, we don't think we can safely support these plugins unfortunately.


Ant colony optimization-- C,C++ and Java

Is your feature request related to a problem? Please describe.
Ant colony optimization in C,C++ and Java
Describe the solution you'd like
Ant Colony Optimization (ACO) is a metaheuristic optimization algorithm inspired by the foraging behavior of ants. It is commonly used to solve combinatorial optimization problems, such as the traveling salesman problem (TSP) and the vehicle routing problem (VRP). The algorithm mimics the behavior of ants as they search for food and communicate with each other through pheromone trails. Here's an explanation of the key components and steps of the Ant Colony Optimization algorithm:
Problem Definition: Define the optimization problem that needs to be solved, such as the TSP, VRP, or any other combinatorial problem.
Initialization:
Create a colony of artificial ants. Each ant represents a potential solution to the problem.
Assign random initial positions (or solutions) to the ants.
Solution Construction:
Each ant constructs a solution by iteratively building a feasible solution.
At each step, an ant selects the next component or decision based on a probabilistic rule that combines the pheromone trail information and a heuristic value.
The pheromone trail represents the accumulated knowledge of previously found good solutions.
The heuristic value captures problem-specific knowledge to guide the ant's decisions.
The selection probability of a particular component is typically proportional to the pheromone trail intensity and inversely proportional to the distance or cost associated with that component.
Local Update:
After each ant constructs a complete solution, a local update of the pheromone trail is performed.
The pheromone trail intensity is updated based on the quality of the solution constructed by the ant.
The update rule typically involves evaporation of the existing pheromone and deposition of new pheromone based on the quality of the solution.
Global Update:
After all ants have completed their solutions, a global update of the pheromone trail is performed.
The global update rule reinforces the pheromone trails of the best solutions found so far.
It ensures that good solutions have a higher probability of being selected by future ants.
Termination:
Determine a termination criterion, such as reaching a maximum number of iterations or achieving a satisfactory solution.
If the termination criterion is not met, go back to step 3.
Output:
Return the best solution found during the optimization process.
The key idea behind ACO is the positive feedback loop created by the pheromone trail. As ants repeatedly travel along good paths, they deposit pheromone, making those paths more attractive to other ants. Over time, the algorithm converges towards good solutions that are reinforced by the accumulated pheromone

Assigned!
@HadiaSamreen : C, C++ & Java


[FEATURE] Readme logo repositioning

Readme logo repositioned.

why am i getting this error, any maintainer response please.

@ShorunTech I think it's for the deployment configuration that needs me to authorize every deployment, no worries the pr looks nice


SQL ODBC driver doesn't work on cbl-mariner python image

Describe the bug
Trying to use cb-mariner python image to query SQL table, failed.
To Reproduce
Steps to reproduce the behavior:

Setup an image and install SQL ODBC drivers:

FROM mcr.microsoft.com/cbl-mariner/base/python:3.9-cm2.0
...
RUN curl https://packages.microsoft.com/config/rhel/7/prod.repo > /etc/yum.repos.d/mssql-release.repo && \
    ACCEPT_EULA=Y yum install -y msodbcsql17 unixODBC unixODBC-devel && \
    yum clean all

# Set the environment variable for ODBC library path
ENV LD_LIBRARY_PATH=/usr/local/lib:/usr/lib:/usr/local/lib64:/usr/lib64

Create an instance and connect to its shell
docker run -it <imageid> sh
Connect to SQL table
isql -v -k "DRIVER={ODBC Driver 17 for SQL Server};SERVER=<serverName>.database.windows.net;DATABASE=<databaseName>;UID=<uid>;PWD=<pwd>"
[IM004][unixODBC][Driver Manager]Driver's SQLAllocHandle on SQL_HANDLE_HENV failed
[ISQL]ERROR: Could not SQLDriverConnect

Expected behavior
Get "Connected! " Successfully.
Screenshots
I also tried to get traces,
strace -t -f -o trace_out.txt isql -v -k "<connection string>"
saved logs as file: sql_logs.txt
And there is no such issue when using ubuntu as docker image:
FROM ubuntu:20.04
ARG UBUNTU_VERSION=20.04
...
# Install required packages and setup MS SQL Server repository
RUN apt-get update && apt-get install -y \
    curl \
    apt-transport-https \
    && curl https://packages.microsoft.com/keys/microsoft.asc | tee /etc/apt/trusted.gpg.d/microsoft.asc \
    && curl https://packages.microsoft.com/config/ubuntu/${UBUNTU_VERSION}/prod.list | tee /etc/apt/sources.list.d/mssql-release.list \
    && apt-get update \
    && ACCEPT_EULA=Y apt-get install -y msodbcsql17 \
    && ACCEPT_EULA=Y apt-get install -y mssql-tools \
    && echo 'export PATH="$PATH:/opt/mssql-tools/bin"' >> ~/.bashrc \
    && apt-get install -y unixodbc-dev \
    && rm -rf /var/lib/apt/lists/*

# Source .bashrc to update PATH
RUN /bin/bash -c "source ~/.bashrc"

@dylanw-oss not sure why you're installing drivers from RHEL7 repo since CBL-Mariner has those packages available also. Using the ODBC Driver 17 for SQL Server it connects to the server as expected:
isql -v -k "DRIVER={ODBC Driver 17 for SQL Server};SERVER=<IP_ADDRESS>;DATABASE=Test101;UID=zcobol;PWD=password"
+---------------------------------------+
| Connected!                            |
|                                       |
| sql-statement                         |
| help [tablename]                      |
| quit                                  |
|                                       |
+---------------------------------------+
SQL> quit

/home/zcobol/.odbc.ini driver info:
zcobol [ /home/zcobol ]# cat .odbc.ini
[ODBC Driver 17 for SQL Server]
Description=Microsoft ODBC Driver 17 for SQL Server
Driver=/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.10.so.6.1

@zcobol, thanks! Can you share your docker file? what's the base image you used and how did you install the driver?
The driver is not available when I use this as base image:
FROM mcr.microsoft.com/cbl-mariner/base/python:3.9-cm2.0

Resolved! Remove RHEL7 repo and it works! Thanks!

RUN ACCEPT_EULA=Y yum install -y msodbcsql17 unixODBC unixODBC-devel && \
    yum clean all


Use inventory reservoir as source for all files and dirs

Which Delta project/connector is this regarding?

[x] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description

Currently, users have large tables with daily/hourly partitions for many years, among all these partitions only recent ones are subjected to change due to job reruns, corrections, and late arriving events.

When Vacuum is run on these tables, the listing of files is performed on all the partitions and it runs for several hours/days. This duration grows as tables grow and vacuum becomes a major overhead for customers especially when they have hundreds or thousands of such delta tables. File system scan takes the most amount of time in Vacuum operation for large tables, mostly due to the parallelism achievable and API throttling on the object stores.

This change provides a way for users to pass a reservoir of files generated externally (eg: from inventory reports of cloud stores) as a delta table or as a spark SQL query (having a predefined schema). The vacuum operation when provided with such a reservoir data frame will skip the listing operation and use it as a source of all files in the storage.

"Resolves #1691".
How was this patch tested?

Unit Testing  ( build/sbt 'testOnly org.apache.spark.sql.delta.DeltaVacuumSuite')

Does this PR introduce any user-facing changes?
yes, the MR accepts an optional method to pass inventory.
VACUUM table_name [USING INVENTORY <reservoir-delta-table>] [RETAIN num HOURS] [DRY RUN]
VACUUM table_name [USING INVENTORY <reservoir-query>] [RETAIN num HOURS] [DRY RUN]
eg:  VACUUM test_db.table using inventory select * from reservoir_table RETAIN 168 HOURS dry run

@bart-samwel I have fixed/applied all the changes/suggestions pointed out by you. Please review the changes and test cases
The only pending item is adding a parenthesis around the subquery. Somehow am running into a parse error in some pass-through conditions (eg: delete from table query using IN operator) as pointed out in the above comment. The error is getting thrown from the delegated spark parser and not delta while adding parenthesis around the subquery

@bart-samwel I have fixed the function comments, adding a new delta error (pls check the state value that I have chosen) and minor improvements you suggested in unit testing while checking for files that exist. I have also rebased the code to the latest master to resolve upstream conflicts

@bart-samwel , thanks for guiding me through and reviewing my changes. I have fixed the final comments.

@tdas as per our discussion today, I have rebased my changes with the latest master, please review and advise on the next steps

Thank you! A bit busy with 3.1 release, I will get back to you next week. Thank you for your patience!

Hey @arunravimv finally got sometime to review this PR. I am still going through it but overall looks pretty good. Will merge when I am done with the pass.

hi @tdas is there a target release version for this feature thanks

@tnyz target version is next release 3.2. tentatively april (3 months since 3.1).


reaction game and favicon for website is added

Related Issue
Closes #176

Description

Screenshots

favicon

Checklist

[x ] My code adheres to the established style guidelines of the project.
[x ] I have included comments in areas that may be difficult to understand.
[x ] My changes have not introduced any new warnings.
[ x] I have conducted a self-review of my code.

@Dharmesh177 i didn't get the points of this successful merge of the PR can u please help me out .


feat: export meta object

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 90.777%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
2105

Relevant Lines:
2243

💛  - Coveralls


(Bug) AppStore warnings

[ ] ITMS-90078: Missing Push Notification Entitlement - Your app appears to register with the Apple Push Notification service, but the app signature's entitlements do not include the 'aps-environment' entitlement. If your app uses the Apple Push Notification service, make sure your App ID is enabled for Push Notification in the Provisioning Portal, and resubmit after signing your app with a Distribution provisioning profile that includes the 'aps-environment' entitlement. Xcode does not automatically copy the aps-environment entitlement from provisioning profiles at build time. This behavior is intentional. To use this entitlement, either enable Push Notifications in the project editor's Capabilities pane, or manually add the entitlement to your entitlements file. For more information, see https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/HandlingRemoteNotifications.html#//apple_ref/doc/uid/TP40008194-CH6-SW1.

[ ]  Why do we have this ? We don't using geolocation as i remember ? ITMS-90683: Missing Purpose String in Info.plist - Your app‘s code references one or more APIs that access sensitive user data. The app‘s Info.plist file should contain a NSLocationWhenInUseUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. If you're using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. For details, visit: https://developer.apple.com/documentation/uikit/protecting_the_user_s_privacy/requesting_access_to_protected_resources

@alt-a1r If some text you need to append will be shown to users on the AppStore or somewhere in the system popups, please ask @patpedrosa for such content


Investigate migrating run configs and libraries brought in by the old plugin

If you create an AE standard project using the old plugin, there will be a local dev server run config created for the user.
Then, when switching to our new tooling and opening the above project, the run config will be in an invalid state: it will have a legacy name (referencing the app engine sdk) and the sdk path will be empty.
Similarly, the module's libaries will have a provided dependency on the App Engine SDK.

We may want to look into modifying AppEngineStandardFacetMigrationConversionProcessor to handle this as well. This may also warrant a rename of that class, to convey that it now handles broader project-level migration to our plugin.

I've created a doc with a bunch of screenshots to make the current process explicit and help expose what friction there currently may be:
https://docs.google.com/document/d/1QXzD8n_YA14hpZLlu0aGVvtXxORFsMkwV2u7StxiVls/edit
From this exercise I see two areas we can improve:

Migrate the local dev run config -> rename it to something less confusing
Fix the migration of the deployment run config. After migrating to the new plugin, the deployment config was in a broken unrecoverable state

This is the kind of stuff I'm not sure is worth spending too much time on fixing by automating vs documenting what the users should manually do, i.e., deleting the old run configs and creating new ones manually.

For things like the naming of the local dev run config I agree its less important.
But I do think making the process smoother for the deploy run config is a good idea. For a user switching to our plugin its not the best experience if the first then they see is a broken / unrecoverable run configuration.

Before going knee deep on this, I'd just take a look at the OKRs and see if there's anything on the way more urgent.
I'd agree more with you if, previously, deployment run configs held a lot of data that would be inconvenient for the user to reproduce, by creating new ones. Since this isn't the case, quite on the contrary, I'm not too sure if this warrants a lot of effort. Just my 2 cents :)

I think having working run configs is a bigger deal to have a smooth transition and good first experience with the new plugin.


Syntax error with empty statements ending on \;

Here's an example:
\;\;\;

This works:
;;;

handled in scope lexer. \; is not in scope, it's a psql feature.


Add precision to fracture for cheesing.

Please be as descriptive as possible, including: what is expected, why is this feature needed, what is the objective, etc.
What is the feature being requested?
Add precision to fracture for cheesing.
What are use cases for this feature?

add code snippet to cheesing.
exterior_poly = exterior_poly.fracture(max_points=max_points,
precision=precision)


Setup Create React App

Setup an empty react app.
Leverage typescript, babel, eslint, prettier, react-router.
Do not eject the app.
https://create-react-app.dev/docs/adding-typescript/

done


Does iScroll work with the document.body as the scroll target?

I have a scenario where the body flexes with max height and a lot of columns are put on, much like how Trello does its columns, so I wanted to be able to scroll horizontally, however after adding IScroll and adding scrollX: true to the options it doesnt seem to work, although I am not sure if that is because it doesnt like being applied to document.body or something else

I'd like to know as well.

Me too. Is this possible? Help appreciated..


Fix a typo in rest-api.md for renaming a network ACL

Signed-off-by: Hiroaki Nakamura<EMAIL_ADDRESS>

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Thanks!


Report Mutation Percentage Coverage Measure

Was able to verify that the plugin captured survived & not covered mutants in our Sonar DB and were viewable on the project dashboard.
Currently the above metrics are reported as issues. However, it would be nice if this plugin also stored a Coverage Measure that captured Mutation Coverage % similar to Line & Condition.
@nicojs @simondel - Any thoughts on whether this could be supported?

Great to hear that the plugin is working for you! I agree that we need the metric. Let's call it "Mutation Score".
This is rather easily implemented. We now report the mutation score in the onScoreCalculated event here: https://github.com/stryker-mutator/stryker/blob/master/packages/stryker-api/src/report/Reporter.ts#L45. It is written to disk by the event-recorder reporter so that part is already done. All that's left is to read in that file as well and report the metrics you want reporting.
@j-truax You're welcome to help. Do you want to implement this?

@nicojs - I wouldn't mind contributing but my bandwidth is a limited right as I am working full time and getting my MBA. My work requires me to get approval prior to contributing to open source projects. At the very least I will try and set aside some time to review the source and see what enhancement is needed for this.

I chatted with @j-truax about this. I'll give it a shot- may take me a bit.


failed to start with meteor 1.5 release build

In debug it works fine
9631145….js?meteor_js_resource=true:23 Uncaught Error: First argument to _arity must be a non-negative integer no greater than ten

Hi, I'll look into it tonight!

It puzzled me as I downgrade to <IP_ADDRESS> and run meteor --production mode

I updated the demo to Meteor 1.5 and it's working, I deployed it on Heroku. The package is installed and imported using npm:
import /* ... */ from 'meteor-redux-middlewares';

I'll now try to run the demo using the Meteor package (it's on the "meteor" branch). I'll keep you up to date.
Are you using the npm package? Or the Meteor one?

It seems to be problem with standard-minifier-js
replaced with abernix:standard-minifier-js

It works using the Atmosphere package too, I updated the "meteor" branch of the demo.
I also tried to run the demo using the production mode (yarn start -- --production) and it's working, I can't reproduce your error.

Are you using<EMAIL_ADDRESS>

Yes, it was<EMAIL_ADDRESS>and I replaced with abernix:standard-minifier-js.

Nice!


resolve issue 196 by moving the status check after files are added.

When line endings don't match changes are detected but they go away when added.

@microsoft-github-policy-service agree

fix for #196

@guythetechie thoughts?


[PSUPCLPL-11380] Doc update: how to change cluster CIDR guide

Description
Sometimes it's necessary to change podSubnet at an existing cluster. This PR adds HowTo guide on this procedure.
Fixes # (issue)
PSUPCLPL-11380
Solution
Doc update
How to apply

Test Cases
At an existing cluster go through the steps from /documentation/Maintenance.md#changing-cluster-cidr
ER: podSubnet in the cluster is changed, all the pods work fine.
Checklist

[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] Integration CI passed
[ ] Unit tests. If Yes list of new/changed tests with brief description
[x] There is no merge conflicts

Unit tests

Hi, @koryaga,
The doc updates are reviewed.
Thanks!


Automate Build Testing using CI for both MacOS and Windows

Recent issue #347 shows that we are not correctly assessing our builds.
I would recommend using a CI app such as AppVeyor to automate a build on MacOS, Windows and Linux to ensure each release can build on all systems.

@GregoryHamel I will make this issue a priority.  Even tonight, merging #346 broke the build, and it wasn't until ecdbd3f3d74398ee30c341445724fc80c6ed8738 that I was able to recognize that and fix it.

I have submitted the request to allow us to use AppVeyor
cc @codecalm

Note: once this is up and running #402 should be re-investigated if required

@codecalm I've also requested access for https://www.chromaticqa.com/ too would be awesome if you could approve them


Using cd in the notebook can break path to jinja templates

Filing this issue as this has bitten me a few times. Hopefully we can find a way to figure out absolute paths to the templates...

It has been a long time since I have seen this problem and while I have no particular reason to think this is fixed, I don't know how to reproduce it. I'm happy to close this issue and reopen it if a user reports this problem or I encounter this issue again.


Uncaught TypeError: Cannot set property 'rotation' of null

In the middle of a rotation, escaping to menus ALWAYS, and leaving the map INTERMITTANTLY causes the crash error:
Uncaught TypeError: Cannot set property 'rotation' of null.
The intermittent errors are more common in full screen, but escaping to the menu is 100% fatal.
I use a mac, and am running the game in-engine.
I can confirm the bug occurs even with an empty game - so there are no plugins that are interfering with your plugin.

Note that I was able to resolve the menu crash by using the CTB_CustomScriptANnywhere_MZ plugin to call a pre-script common event before the SceneMap.prototype.callMenu command. The common event flips a switch to stop a common event I use to generate all my calls to your rotation plugin commands, waits 25 frames, and then calls your screen transform reset plugin command. All 3 are needed to resolve the menu crash.  I then use CTB_CustomScriptAnywhere_MZ's post-script to call a common event that turns my desired transforms (in this case rotations and shakes) back on.  For the easier task of transferring the player to new maps, I simply turn off the switch to the rotation calling common event, call your screen transform reset plugin, and use a door animation to give rpg maker enough time to finish operations before I transfer maps.

That's definitely a problem that comes from changing the current scene. I'll update this plugin later to check if the same scene is still usable when transforming.

Try getting the new version. The issue should be fixed now. Sorry for taking so long with this!

It is still broken.  Same error, same context.  The version appears to still have the same update number 1.5 - perhaps your commit did not complete?

Seems like my testing was inadequate with only testing the fix with scaling. Anyway, I've pushed another fix, and this time I've tested it with all the other options too.
Also, the version number being the same was just that I forgot to increase it.


Provide snapshot-topologies support in orchestrator-client (and via api)

orchestrator has a --snapshot-topologies option not available via orchestrator-client.
This patch provides:

support in orchestrator-client to support --snapshot-topologies
support in the api interface to handle a /api/snapshot-topologies call which will do the same thing.

Output of orchestrator-client looks like:
$ orchestrator-client -c snapshot-topologies
Took 2.125752ms

Output of a call to the orchestrator api (e.g. https://orchestrator.example.com/api/snapshot-topologies`) shows:
{"Code":"OK","Message":"Topology Snapshot completed","Details":"Took 2.058672ms"}

In case this PR introduced Go code changes:

[x] contributed code is using same conventions as original code
[x] code is formatted via gofmt (please avoid goimports)     # note: using go 1.12 formatting
[x] code is built via ./build.sh

snapshot-topologies was written a long time ago and I haven't been practicing it in a while. The idea was to have some "git history" for the topologies; I think the feature needs to be revisited and get some serious testing.

Well Shlomi, you set it up here. It's getting testing... but to be honest I'm not sure if the content it generates is being used. Were you wanting to get rid of it that would be fine I think.
Having said that the PR was because I'm moving all access to orchestrator to use the http interface so that I can switch the orchestrator clusters I talk to more easily (rather than use the config file). So moving to orchestrator-client means that any existing scripts etc collecting data which used the orchestrator binary need to be adapted.  This was missing.
This patch has been running since I made the PR and seems to be working fine.


Testing on cityscapes

Hi,
I wished to run inference on the cityscapes test set, while retaining the directory structure of the test set(test/number/images).
How could I adapt the repository for this task?

You either have to add this to the image path in the .json files (if this is possible) or write your own data loader.


Bump the build to latest blowdryer-diffplug

The failed build on Java 11 is https://bugs.openjdk.org/browse/JDK-8297557


Update Package.swift

Due to current structure much of it has to be specified manually, but this adds Swift Package Manager support for the library + Swift tests

If anyone needs this with SwiftPM it is available on my fork until merged. It is tagged as version 3.2.1.

Sorry I've only just managed to get around to this @Juice805 - appreciate the work.
Also does this resolve #11?

@Juice805 - any chance you know if this will resolve #11?

It should fix that error, yes.

@Juice805 would it be possible for you to update this for Swift 5? (Don't worry if not, I can probably work it out!)


Add new map format

Summary
This PR implements a new map format, .fmp, that allows for much better modding support than the vanilla .map format.

All the data in .idx, .obj and .map is rolled into one file.
Data is compressed with zlib. (It is added as a new dependency). This gives a ~10x filesize reduction.
It is editor-agnostic, but supports saving/loading using Tiled's latest development branch. (Some bugs were present/features did not exist in the Python API of the latest official release. The features needed did not make it into the recent 1.2.4 release of Tiled, so ~2 months are needed before the official release is compatible.)
Tiles are still loaded based on tileset atlas. The Tiled plugin loads the correct atlas on startup based on the atlas property of the map.
Strings that repeat often in the file, like string IDs, are compressed using a string to integer mapping.
Modding is supported through an "object" system. Objects can be saved in the map, which contain a type, ID, name, position and extra properties. When the map is loaded a custom function belonging to an instance of core.tile_exporter is run for each object and passed the object's data. This function can then call something like Chara.create. This concept is generalizable to new data formats also (although currently unimplemented), as long as they have a map position. Since objects can be given arbitrary properties, the kinds of behavior that can be ran to instantiate objects is greatly increased.

As an example, core.map_object is added to support adding map features like stairs.
This should allow map initialization logic previously hardcoded, like setting extra properties of characters, to be moved into the map itself, allowing the same functionality without needing to write any code.

Layering is supported for object layers.
Lua code is not contained in the format. Any extra behavior needed could be run as a callback on an instance of core.map.

There is a new feature added to the game client to export the needed tilesets for Tiled to load. The tilesets and needed plugins will be output to Tiled's config directory, ~./tiled. Once this step is done, both vanilla (gzipped) .idx and .fmp files should be loadable as long as all the data they used was also loaded into Elona_foobar at the time of export. If mod data is changed afterward, then the tilesets need to be regenerated also. .fmp contains a list of mods and semver versions of the data used at the time of saving, so incompatibilities can be detected.
Although this is a replacement for the vanilla .map format, there is no effect on existing saves. .fmp is an interchange format, intended to be converted into the in-memory map representation.
No maps have been converted to the new format yet. The map initialization code should be moved to Lua first.
Other changes

zlib and libpng are added as dependencies. zlib is a dependency of libpng itself and is used for map compression. libpng is used to output the tile images displayed in Tiled.
boost version is changed to 1.69 because of an API incompatibility in Boost.GIL introduced in 1.68 (see here).
Boost.Locale is removed as a dependency and instead functions from sol2 are used to provide UTF-16 conversion on Windows (see here).
Windows dependencies are moved to a separate repo. lua is now prepatched for wstring support on Windows.
zstr is used for gzip decompression to avoid a dependency on Boost.Iostreams.
core.tile_exporter is created to handle export/instantiation logic of data from map files.
core.map_object is added.

Example
Here is Tiled with the format's plugin support.

Format
Following is the map format.
Details

char[4]                    - header
int                        - map format version
size:                      - mod count
  string                   - mod name & version (mod-0.1.0)
mapping                    - file-local ID -> property names
properties                 - mdata properties
int                        - width
int                        - height
mapped_int[width * height] - tiles (string ID)
size:                      - layer count
  int                      - layer ID
  int                      - layer kind
  string                   - layer name
  properties               - layer properties
  if kind == tile:
    skip
  elif kind == group:
    size:                  - child layer count
      int                  - child layer index
  elif kind == object:
    size:                  - object count
      mapped_int           - data type
      mapped_int           - data instance
      int                  - object x
      int                  - object y
      properties           - object properties
  elif kind == image:
    skip

size:
  also an int

string:
  null-terminated

mapping:
  size:                    - item count
    int                    - file-local ID
    string                 - real name

properties:
  size:                    - count
    mapped_int             - key
    typed_value            - value

mapped_int:
  index into mapping table, represents a string

typed_value:
  0 - int
  1 - bool
  2 - string

Closed the PR because it is hard to merge it into the current develop.


Python: Improve readability of transaction test

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

can you do the same in node?

I will


Consider bin script as a package usage

extensible-react-scripts 😕  NOTUSED?
Still using extensible-react-scripts?
Depcheck did not find code similar to require('extensible-react-scripts')
or import from 'extensible-react-scripts'

I indeed don't do imports from this package, but I use it on npm scripts. e.g:
"start": "extensible-react-scripts start",
"test": "extensible-react-scripts test --env=jsdom"

Could that be considered a package usage?

Yes. This makes the NOTUSED? flag much less useful than it could be.

+1 for this issue.
I am using ts-node like this: "start": "node  --require ts-node/register src/index.ts", it'd be great if npm-check would consider ts-node as used.

Yeah, this bites me with mocha and standard for every package I publish 😄
Would love to accept a pull request, any takers? 💌

Looks like this will need to be fixed in https://github.com/depcheck/depcheck, that's what this package uses to determine unused packages.

@LinusU Can you post the scripts you use mocha and standard in? It would help me test a fix.

@Ionaru
{
  // ...
  "scripts": {
    "test": "standard && mocha"
  }
}

Thanks for getting on top of this ❤

@LinusU I copy-pasted that script into my test setup, but npm-check does not see them as unused.

Hmm, have you also added standard and mocha to your dependencies? npm install --save-dev standard mocha

Yes, I installed them

When I use depcheck by itself, I use a .depcheckrc to include my bin folder explicitly:
parsers:
  '**/*.js': ['es6']
  '**/bin/*': ['es6']

What would be nice would be if npm-check would also "honor" the presence of a .depcheckrc or other depcheck config file?


Did you defined a new class named CityscapesVideoDataset ?

Did you defined a new class named CityscapesVideoDataset ? When I run the test.py, there is a error KeyError: 'CityscapesVideoDataset is not in the dataset registry'. If you defined a new class, could you  share it please?

Sorry, I know it

@Wave2689 Hi, You can donwload the Cityscapes sequence part from here.


Filter requests based on peers/whitelist . Deprecate useWhiteList

Remove deprecated constructor for config object use default construct or and setters to populate values. Remove catch all block and disabling filter as this doesn't doesn't make sense. Deprecate useWhiteList and use disableAutoDiscovery in its place. For time using when useWhiteList is set assume that this means auto discovery is enabled.

Initial issue description

Currently when discovery is OFF, node A will not discover new nodes in the network and fail any transactions to new nodes say 'B', however node A will accept transactions from node B if node B discovered node A through other nodes in network (Node B has discovery=ON) which shouldn't be the case. When discovery is OFF, it should enable whitelist to only connect to the peers present in the config file and thereby connection to new nodes (waiting to be discovered) are terminated even before any API communication is tried.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8902762). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #971   +/-   ##
========================================
  Coverage          ?   99.3%
  Complexity        ?    2154
========================================
  Files             ?     327
  Lines             ?    5884
  Branches          ?     356
========================================
  Hits              ?    5843
  Misses            ?       5
  Partials          ?      36

Impacted Files
Coverage Δ
Complexity Δ

...va/com/quorum/tessera/config/cli/OverrideUtil.java
100% <ø> (ø)
60 <0> (?)

...quorum/tessera/partyinfo/PartyInfoServiceImpl.java
97.26% <100%> (ø)
19 <1> (?)

...m/quorum/tessera/api/filter/IPWhitelistFilter.java
96.77% <100%> (ø)
11 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8902762...fdc35ef. Read the comment docs.


Customize colors of Checkbox and Radio

There is no color property in the Checkbox control. Therefore, no way to customize the color of a checkbox.
This gives me a lot of pain and just because of that I need to place my widgets on a dark card.
Is it THAT HARD to make colors customizable?

possible workaround: Can you create a checkbox without a label and put it in a row with a text control with color of your choice? Wrap that together in a custom control?
yeah not ideal but in theory...

I'm sorry for your pain. It's not "that hard" to implement - you could just kindly ask, no need to complain right away.

possible workaround: Can you create a checkbox without a label and put it in a row with a text control with color of your choice? Wrap that together in a custom control?

I think he/she meant the color of the checkbox itself, not that of the associated label.

I'm sorry for your pain. It's not "that hard" to implement - you could just kindly ask, no need to complain right away.

"Not that hard"? I am impressed!
I still don't understand how the flutter widgets are converted for use in python code. And I am so curious to know that someday.
Please, Try making a video showing how this is done. I think this may attract Flutter guys who are also proficient Pythoneers, so they could contribute to Flet's development.

Added new properties:

Checkbox.check_color
Checkbox.fill_color
Radio.fill_color

Styled checkbox example:
import flet
from flet import Checkbox, Page

def main(page: Page):
    page.add(
        Checkbox(label="Checkbox with default style"),
        Checkbox(
            label="Checkbox with constant fill color",
            fill_color="red",
            check_color="yellow",
        ),
        Checkbox(
            label="Checkbox with dynamic fill color",
            fill_color={"hovered": "blue", "selected": "green", "": "red"},
        ),
    )

flet.app(target=main)

Styled radio example:
import flet
from flet import Column, Page, Radio, RadioGroup

def main(page: Page):
    page.add(
        RadioGroup(
            Column(
                [
                    Radio(label="Radio with default style", value="1"),
                    Radio(
                        label="Radio with constant fill color",
                        value="2",
                        fill_color="red",
                    ),
                    Radio(
                        label="Radio with dynamic fill color",
                        value="3",
                        fill_color={"hovered": "blue", "selected": "green", "": "red"},
                    ),
                ]
            )
        )
    )

flet.app(target=main)

Como personalizar a cor da label do RADIO? Consegui entender que posso alterar a cor da seleção, mas quero entender como posso fazer isso com LABEL


clientv3/integration: fix keepalive by waiting for unhealthy

The blackholed endpoint cannot be re-pined. Then it will make the waiting time longer than expected. Let us wait for it can be re-pined before blackhole ep1 to test re-pin.

@gyuho
wow... semaphoreci turned green.

fix https://github.com/coreos/etcd/issues/8678

i am going to merge this in as it does fix the test.


Add VENV_DIR to dev session in cookbook, fix #588

This adds a VENV_DIR constant to the example dev session in the cookbook as described in #588

Looks great to me! Thanks @NickleDave 🎉

Thank you!


Issue with loading wasm binary on ArLocal 1.1.29

Hey!
That's probably a followup of https://github.com/textury/arlocal/issues/83
After switching to ArLocal 1.1.29, I'm getting these errors while trying to load wasm binary (using the /{txId} endpoint:

If I try to load the data with
const txData = (await this.arweave.transactions.getData(id, {
      decode: true
    })) as Uint8Array;

I'm getting these errors

Originally raised on Discord and reproduced by @kouraf

fixed in #89 :raised_hands:


Add warnings to error response for sklearn Pipelines

See #92
When calling the prediction pipeline produces warnings, it is treated as an error. This includes situations where the model output might be correct but we're not sure, most notably when there is a mismatch of the version of the loaded sklearn model and the sklearn version of the runtime.
Although we still return the model outputs to the user, we don't show them what warnings were actually encountered. This makes debugging difficult. Therefore, we want to show them the warnings.
This requires two changes. First, we need to add the encountered warnings to the response. Second, we need to display these warnings. This PR implements the first step.
On top of that, this PR introduces a small refactoring to reduce the amount of code duplication (see the last paragraph of this comment). This refactoring results in no functional changes.

Not sure why there is a timeout error. Log says:

timed out after 20 seconds

even though the call seems to be:
        self.framework_docker_test(
            "sklearn",
            "tabular-classification",
            "skops-tests/iris-sklearn-latest-logistic_regression-with-config",
            custom_input=clf_data,
            timeout=600,
        )

The whole CI fails after 3 min, so these 600 seconds don't seem to be honored.

What's the change here which fixes the original issue of not returning the warnings?

https://github.com/huggingface/api-inference-community/pull/114/files#diff-e20608fb08c5272baa6ed6abca2e2a940ee3b6ff51f1088b9d04970cb681f083R125

timed out after 20 seconds

This is when the docker wants to be shut off. I tried manually to see what was happening but it's true that the docker image doesn't see to honor the SIGTERM signal. I don't really understand what's going on since all other docker seem to be working just fine.
The only thing that seems to work locally is to forcefully discard the container.
On the cluster it's OK since k8s already does this, but it's still very odd/peculiar behavior.

@adrinjalali @Narsil I addressed your comments.
Timeout unfortunately still occurs.


Missing semicolon

I noticed there is a missing semicolon here.
I think we used to have an eslint rule for missing semicolons, not sure if that was removed intentionally.

I think we used to have an eslint rule for missing semicolons, not sure if that was removed intentionally.

I believe that not working for interfaces, neither in TS nor in ESLint. So selfhost with format on type and this code action save config: 	"editor.codeActionsOnSave": {"source.fixAll.eslint": true},. When writing expressions I happily see semicolons being auto-inserted. Adding @dbaeumer for the ESlint part of this

The reason for ESLint not detecting this is that we need to turn the ESLint semi rule off and use the TS semi rule. Something like
        "semi": "off",
        "@typescript-eslint/semi": "error",

I will look into chancing this for VS Code.

Actually we have the right settings in the eslintrc file
		"semi": "off",
		"@typescript-eslint/semi": "warn",

Yeah, semi colons in interfaces and inline types are considered optional and eslint doesn't seem to auto insert them. I now use the ts formatter setting (as user setting)

There is a special rule in TS ESLint for member delimiter. Let me look if we can use that one:
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/member-delimiter-style.md

I needed to revert this. It caused hundreds of warnings in out code base :-(.

The question is: do we want to enforce this. If yes, we would need to adopt?

We would also need to decide what happens with single line
context?: { cell: DiffElementViewModelBase; }

I am in favor of forcing a semicolon there as well (e.g. after DiffElementViewModelBase)

Let's make this a team decision

I did some additional testing with the ESLint rule and it affects only interface and type literals. Object literals are still separated using ','. Here are examples what the rule will enforce:
interface X {
    foo: number; // <== enforces a semicolon here
}

type X = {
   foo: number;  // <== enforces a semicolon here.
}

As said above by default the ESLint rule enforces no semicolon if the type literal is written on one line. So this is correct
type X = { foo: number }  // <== no semicolon

and this would be an error
type X = { foo: number; }  // <== no semicolon allowed

But we can customize ESLint that even on single line we enforce a semicolon. Since it is a type definition and not an object literal I would actual opt to enforce it.

/cc @microsoft/vscode
Please raise concerns and leave feedback - this is about semicolons in a few more places (see comment above)

This is now done

I'm a bit late, but my personal preference is to use a command on single line definitions as semi colons look a little off to me when single line interfaces are inlined into other statements:
    "@typescript-eslint/member-delimiter-style": [
      "warn",
      {
        "multiline": {
          "delimiter": "semi",
          "requireLast": true
        },
        "singleline": {
          "delimiter": "comma",
          "requireLast": false
        }
      }
    ],

As long as we're consistent it doesn't bother me too much though.

I prefer semicolon for all type literals and comma for object literals.


Make for_each_contiguous_slice() a variadic function.

I added this as a separate API because during dev work I didn't want to involve conflicts, but the API is backwards-compatible and the performance is basically identical when you pass just a single buffer (according to the benchmarks I added).
I think that the fusing and folding handling is basically correct; there might be additional opportunities for optimization (especially for folding) but I think this is ready for review.

Updated per offline comments. Note that the single-buffer case is ~identical in performance, but the benchmarks for the multibuffer case show a dramatic slowdown (~half the throughput), which I'm going to look into.

Nice work.
A high level comment: you make an std::array<void*, N> on the stack at the beginning, then unpack that with template shenanigans. Can you just pass that array through the layers of for_each_contiguous_slice? That would simplify the code a lot. Would that work?

See https://github.com/dsharlet/slinky/pull/99 for a variant that does that.

PTAL


Change esm file extension

Hi,
As type module is not set in the package.json, I have an error when I try to build my project as esm.
Here is the trace
import { createValidation } from 'graphql-no-alias';
         ^^^^^^^^^^^^^^^^
SyntaxError: Named export 'createValidation' not found. The requested module 'graphql-no-alias' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using

I tested and it works well by updating the extension of the esm version from .js to /mjs
  "exports": {
    "import": "./dist/prod/graphql-no-alias.esm.mjs",
    "require": "./dist/prod/graphql-no-alias.js"
  },

Thank you so much

I will change all my libraries to type:module eventually.
But then I also need to change other configuration files, like jest setup etc...

Ok, I see... thank you for your response.
Maybe just update the file extension in the build output can be a good temporary option before changing all your libraries

I've updated the package to be type module. It's a major version change.

Perfect, I just tested it and it works well.
Thank you for your reactivity and for this nice package !


Avoid use of deprecated Lwt_main.yield

... by replacing them with the almost-equivalent Lwt.pause. Promises constructed in this way have slightly different scheduling behaviour, but this shouldn't impact the correctness of our code.
This may make our tests that use these functions more or less flaky; I'm not sure.
See https://github.com/ocsigen/lwt/issues/855 for more details.

You beat me to it :-)


ICL_NUIM dataset from official site are not matched

Excellent work!
I attempt to play around with ICL_NUIM. But somehow your src/scripts/generate_fusion_data_icl_nuim.py do not match the data in https://www.doc.ic.ac.uk/~ahanda/VaFRIC/iclnuim.html.
For example, the gt_mesh.ply, {RENDER_PATH}-color,  {RENDER_PATH}-depth-simulated, RENDER_PATH}-depth-clean. Where to get this. In addition, the scale is 1000, which is not compatible with ICL-NUIM.
Which format does this project use? The data I use is in TUM format.

We use the augmented ICL-NUIM from here: http://redwood-data.org/indoor/dataset.html.

Thank you, Kejie, for the very quick reply.
I will now close this issue as the question is well solved.


Move TreeSize function to separate /pkg dir

Summary:
Currently there is code in /utils/utils_daemon.go to handle getting the size of a directory specified by a path.  This utils package is too large and needs to be broken up.
Proposed solution:
Move the TreeSize function into a separate package inside /pkg called directory.  The build tag at the top of this file will need to be changed from // +build daemon to // +build linux as it uses syscall.Stat_t which is a linux only type.  Because of the new directory the function name can be changed to Size.

I'll start working on this.


OpenSearch : Pinned Queries

Is your feature request related to a problem? Please describe.
Sometimes it is desirable to artificially boost certain search results for a query and arrange them higher with the rest of the search results. This feature is typically used to guide searchers to curated documents that are promoted over and above any "organic" matches for a search. The promoted or "pinned" documents are identified using the document IDs stored in the _id field.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Duplicate of #72


[$250] Track expense - App throws error when submitting track distance expense

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to self DM.
Click + > Track expense > Distance.
Submit a track distance expense.

Expected Result:
The track distance expense will be created successfully.
Actual Result:
App throws error when submitting track distance expense - There is a previously existing chat between these users.
Workaround:
Uncnown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/a931bfe2-a93e-44a0-8554-79800bbba54f

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018888d22189418e67
Upwork Job ID:<PHONE_NUMBER>651751011
Last Price Increase: 2024-08-08

Issue OwnerCurrent Issue Owner: @jjcoffee

We think that this bug might be related to #vip-vsb

I can reproduce but if it's not coming from the back-end, I am wondering if we changed the API request in some PR, looking!

Oh, on production we call TrackExpense and we call CreateDistanceRequest on staging

It's coming from this PR: https://github.com/Expensify/App/pull/42302

I am going to open it for proposals since everyone involved in the original PR is not online and if we don't get any, I will revert the original PR.

Hmm, I don't think we can just move createDistanceRequest back down as that would most likely cause a regression from https://github.com/Expensify/App/pull/42302 since we'd call IOU.splitBill first and return early instead of creating the distance request for splitting.
I wonder if we also need to handle the other conditions that result in calling trackExpense:
https://github.com/Expensify/App/blob/717d344a38bb04265d219a5143d6ab0dd70596ed/src/pages/iou/request/step/IOURequestStepConfirmation.tsx#L446

Having investigated further, it looks like @dominictb's alternative solution is the way to go here.
:ribbon::eyes::ribbon: C+ reviewed

Sounds good, assigning @dominictb

Looks resolved
https://github.com/user-attachments/assets/8cba050b-ab46-4db8-bcc9-d2b19b03ca67

Awesome, thank you! Removing deploy blocker

Summarizing payment on this issue:

Contributor: @dominictb $250 via Upwork - PAID
Contributor+: @jjcoffee $250 via Upwork - PAID

Upwork job is here: https://www.upwork.com/jobs/~018888d22189418e67

Hey @jjcoffee can you please complete the BZ checklist for this when you get a sec?

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/42302
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42302/files#r1723447110
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - should've been caught in checklist
Determine if we should create a regression test for this bug. Yes - although one most likely already exists
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go to self DM.
Click + > Track expense > Distance.
Submit a track distance expense.
Verify that the expense shows up with no errors.

Do we agree 👍 or 👎

Test case created! https://github.com/Expensify/Expensify/issues/422130
All done here, thanks!


trainer.on_gpu == True for gpus = 0 or gpus=[]

Describe the bug
trainer.on_gpu == True for gpus = 0 or gpus=[] because of this line.
When resuming from a checkpoint, the model is transfered to gpu at this line, even if gpus=0
Expected behavior
gpus=0 should make training happen on CPU.
I can make a PR for that, the fix is pretty simple, I think we can just replace
self.on_gpu = gpus is not None and torch.cuda.is_available()
by
self.on_gpu = True is (gpus and torch.cuda.is_available()) else False
Am I missing something?

to use no gpus just set
gpu=None

If you think that gpus=0 or gpus=[] should also run on no GPUs feel free to submit a PR


[FEATURE]Disable decimals display if not necessary

Feature request summary
Maybe I don't get how to do that, but sometimes I have integer value, so there is no need for ".00" digits. How I can fix that ? Pls help

Rationale
Better looking from ui perspective

Hi @YevhenTarashchyk for USD this is working as designed. If you wanted to use an integer you could use a TextField from Polaris. Is there a specific use case for this or a currency that doesn't have decimal points that you're trying to use?


DeliberationPhase: During "Deliberation" round, players are unable to access role cards/UI

This issue occurs across all devices--once the deliberation round starts, all of the UI buttons on all devices become non-responsive, even before the timer appears.

cannot reproduce - will re-test after deliberation phase is complete


reshuffled vision tab components

Rearranged components so that they fit better on the screen.  Prior to this, the 100% width vision map was not fitting on the screen (most screens are wider than they are tall), and scrolling back and forth to use the scrub bar/filter was annoying.
Map is now 50% width with the controls (scrub/filter) on the right 50%.
Put use counts/log below in another 50/50 split.
Added pagination to ward log.
Demo:
http://hchung.westus.cloudapp.azure.com:8080/matches/3037756062/vision

I think this is the wrong approach. We definitely need a bigger map. In the current map size, you can't see details much. One way of solving the filter problem would be a floating fixed div. I am vehemently against reducing the size of the map.

And please no pagination to the ward log. This is just one game. It is important to see all the wards without clicking anything else like page numbers.

I fully like this pr, 100% map was really annoying.

The 100% map doesn't fit on my screen though, which makes the controls hard to use.

What about setting the map size to 100% of the height of your screen and moving the filters to the side? This 50% map is not useful to anyone as it's a bit small. So, if scrolling is an issue, let's make it fit the height instead of cutting it in half.

Do you know the proper CSS for getting to 100% height?  I tried height: 100% but it doesn't seem to be working.
On my screen the current 50% width is also taking up about 90% of the height (once browser, taskbar are included).  My screen resolution is 2560x1440 -- what resolution are you using that it's unusable at 50%?

I am not saying it's unusable. I am just saying the smaller map is not good for detail oriented users (like me). What if we add an option and let the user decide?
Hmm.. Why do we need to split the below tables into 50%? They look good enough as they are now. Regarding moving them to purchases page, we should have them at both places. They are both purchases and vision related. Users should click once on vision and see everything vision related.

Regarding moving them to purchases page, we should have them at both places. They are both purchases and vision related. Users should click once on vision and see everything vision related.

I agree

I am just saying the smaller map is not good for detail oriented users (like me). What if we add an option and let the user decide?

Probably the best decision would be to add switcher - http://www.material-ui.com/#/components/toggle

I'd like to push this as-is, and we can think about solutions for larger maps later?