Make tests OO

Right now we are using a lot of static matchers from hamcrest. Let's make those tests more object-oriented. See https://github.com/yegor256/cactoos/issues/588 , where this was applied to cactoos project.

@0crat in (here)

@paulodamaso Job #893 is now in scope, role is DEV

@0crat assign @marceloamadeu

@0crat in (here)

@paulodamaso There is an unrecoverable failure on my side. Please, submit it here:
PID: 4@041da5f8-f9e0-45ec-8176-7f0140d878bb, thread: AsyncProc-4
com.zerocracy.farm.reactive.StkRuntime[76] java.lang.IllegalStateException: org.codehaus.groovy.runtime.InvokerInvocationException in com.zerocracy.stk.pm.cost.funding.send_zold
org.codehaus.groovy.reflection.CachedMethod[105] org.codehaus.groovy.runtime.InvokerInvocationException: groovy.lang.MissingMethodException: No signature of method: com.zerocracy.pmo.banks.Zold.pay() is applicable for argument types: (java.lang.String, com.zerocracy.cash.Cash$S, java.lang.String) values: [paulodamaso, $4.00, none]
Possible solutions: pay(java.lang.String, com.zerocracy.cash.Cash, java.lang.String, java.lang.String), any(), wait(), find(), dump(), grep()
org.codehaus.groovy.runtime.ScriptBytecodeAdapter[71] groovy.lang.MissingMethodException: No signature of method: com.zerocracy.pmo.banks.Zold.pay() is applicable for argument types: (java.lang.String, com.zerocracy.cash.Cash$S, java.lang.String) values: [paulodamaso, $4.00, none]
Possible solutions: pay(java.lang.String, com.zerocracy.cash.Cash, java.lang.String, java.lang.String), any(), wait(), find(), dump(), grep()

0.39.6: CID: d4286ab9-e35d-4cbb-857a-be32f05f5f95, Type: "Send zold"

Bug was reported, see §29: +15 point(s) just awarded to @paulodamaso/z

@0crat assign @marceloamadeu (here)

@paulodamaso The job #893 assigned to @marceloamadeu/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso/z

@0crat wait

@0crat wait (here)

@marceloamadeu The impediment for #893 was registered successfully by @marceloamadeu/z

@paulodamaso the puzzle #unknown is still not solved.

@paulodamaso the only puzzle #948 is solved here.


Add an option to not delete TemporaryFile on dealloc

It's sometimes useful to create a temp file but keep it around for a little bit longer, instead of automatically deleting it on dealloc. TemporaryDirectory already has a similar option.

@aciidb0mb3r

@swift-ci please smoke test

CI green \o/


Improve user account UI

User account UI needs to look a bit nicer and offer options to update supplied personal details.

the register UI has been improved, so this is a matter of styling and of editing the user record. Therefore, it will be deferred until edit is done in the next sprint.


Locking conversion to Hiragana or Katakana

When using wanakana to bind an input I would like to suggest adding an option to lock conversion to hiragana or katakana. For now I have found a workaround by adding a custom eventListener and calling toKana(), feeding it text converted to upper/lower case.

Well, the IME mode is just for convenience and does pretty much the exact same thing as your workaround, that said, this would be an easy feature to add and sounds useful.
Would you like to submit a pull request for this?

Just a note - a quick look at the code shows that only toKana was really set up for dynamic input. Also, the onInput handler used in the IME mode does some extra cursor resets to ensure the input cursor is placed at the end of the altered input.
Direct calls of toHiragana with a stream of input could miss some of the features - it's probably worth breaking out the IMEMode references to be handled in toHiragana and toKatakana rather than toKana.
I'll take a quick stab at this today and see what happens.

@floridagamer07 Do you want to give https://github.com/WaniKani/WanaKana/blob/dev/gh-pages/assets/js/wanakana.min.js a shot and let me know if it's working as expected for you?

Thanks for the quick response. I tried out the code and it works as expected, changing the option to toHiragana/toKatakana will lock the input conversion. Though one bug I found was when you bound an input with wanakana.bind(input); the 'n' block (なにぬねの) cannot be entered, it will show up as (ex. んあ), but binding an input with wanakana.bind(input, { IMEMode: true }); everything works as expected and the 'n' block can be entered normally.

Good catch! I've updated it now and everything seems groovy.
@mimshwright want me to go ahead and publish?

Sure. Go for it.
On Thu, Jul 13, 2017 at 18:55 Duncan Bay<EMAIL_ADDRESS>wrote:

Good catch! I've updated it now and everything seems groovy.
@mimshwright https://github.com/mimshwright want me to go ahead and
publish?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/WaniKani/WanaKana/issues/57#issuecomment-315138096,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIqaCw1D9mm9h7knNkqo70h-wVtiN-7ks5sNkvogaJpZM4OVD8n
.

Live on NPM.


error related to nltk

i have installed python,nltk .did coding related stemming .
everything was fine.
but suddenly error came by showing that 'python' is not recognized as internal and external command
reinstalled python 2.7
now while importing nltk below error is showing
github
my project has come to end suddenly it happen
how to resolve this
thank you in advance

This seems unrelated to the project. An import error in PIL is not specific to bong. By the way, use python 3 :D


20.09: Caddy module broken with pkgs.caddy1

Describe the bug
PR #102186 broke the caddy module on 20.09.
This PR causes an error if services.caddy.package = pkgs.caddy1:
error: The option `services.caddy.agree' can no longer be used since it's been removed. this option is no longer necessary for Caddy 2

At https://github.com/deviant/nixpkgs/blob/6c30370d8dcc081daa744334ab352305525c08fb/nixos/modules/services/web-servers/caddy.nix#L115 the option is used for caddy1, but removed in the PR without a check for the caddy version.
The PR was a backport from unstable, where caddy1 isn't supported anymore.
To Reproduce
Check out the 20.09 branch of the nixpkgs repo, then

add after line 9 in nixos/tests/caddy.nix:

      services.caddy.package = pkgs.caddy1;

run nix-build nixos/tests/caddy.nix

Additional context
caddy1 doesn't seem to be covered for security updates by upstream anymore, see
https://github.com/caddyserver/caddy/blob/master/.github/SECURITY.md#supported-versions
Maybe instead of fixing the issue the module could drop support for caddy1 (esp. as there hasn't been any other bug reports yet), or at least warn of the EOL status for caddy1.
Notify maintainers
@rushmorem @fpletz @zimbatm
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.8.18, NixOS, 20.09.1889.58f9c4c7d3a (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.7`
 - channels(root): `"home-manager, lorri, mozilla-overlay, nixos-20.09.1889.58f9c4c7d3a, nixos-hardware, nixos-unstable-21.03pre253060.a322b32e9d7, nixpkgs-20.09.1889.58f9c4c7d3a, nur"`
 - channels(addy): `"home-manager, lorri, mozilla-overlay, nixos-20.09.1889.58f9c4c7d3a, nixos-hardware, nixos-unstable-21.03pre253060.a322b32e9d7, nixpkgs-20.09.1889.58f9c4c7d3a, nur"`
 - nixpkgs: `/home/addy/.nix-defexpr/channels/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: caddy1
# a list of nixos modules affected by the problem
module:

ping @davidak just for informational purposes.

Caddy 1 is not supported anymore and was removed in https://github.com/NixOS/nixpkgs/pull/99371.
So it does not make sense to create a workaround for this.
We should remove caddy1 even from 20.09, since it's not supported and a security risk.
(migrating the config to caddy2 is a bit of work)


[Feature Request] Allow adding annotations to ServiceAccounts

Is your feature request related to a problem? Please describe.
We are using rbac-manager to set up our ServiceAccounts for our GitLab runners, and we need to grant these ServiceAccounts permissions using AWS IAM roles. We do this by adding an annotation to the ServiceAccount, indicating the IAM role to assume. Right now, there is no native way to add annotations to the ServiceAccounts created by rbac-manager.
Describe the solution you'd like
We would love to see the possibility to add metadata like labels and annotations to the created ServiceAccounts to help us maintaining our access controls properly.
Describe alternatives you've considered
Currently, we are working around this by annotating the created ServiceAccounts in the rollout pipeline with kubectl annotate, exploiting the fact that currently the equality check of ServiceAccounts is not altered by additional annotations.
Additional context
We can try to provide a PR for this feature if you think this makes sense.

Thanks for the feedback, and after a quick scan I think it makes sense to base this feature on the changes made in #417 . We will monitor that issue and base our PR on these changes.

We saw the solution in #418 for #417 and would like to begin our implementation draft. However, we have some questions to start, as this is our first go at a kubernetes controller:

in order to allow metadata being provided by the user, we would start by adding metav1.ObjectMeta ´json:"metadata,omitempty"´ to the v1beta1.Subject. Is this a backward compatible API change from your point of view?
we saw the granular implementation of reconciler.saMatches() from #418 and are wondering, if we also should explicitly compare only metadata provided by the user instead?
in any case, we will need to compare more metadata than before, should we extend the reconciler.metaMatches() or should we create a separate method for the metadata provided by the user?

Yes, I would consider adding a field that is optional to be a backward compatible (minor semver) change.
I do think that only comparing the metadata provided by the user is appropriate. There's a lot of other things that might affect the metadata of a service account (including some  automated), so this seems safest.
I think extending metaMatches would likely be fine.

Hi @sudermanjr ,
sorry for the delay. I added a PR to solve this issue, and I'm looking forward to your feedback.


Create the Admin react client and issues necessary to migrate from vue to react

My plan is to knock out the first 3 steps to get the project up and running and then create the issues below to allow folks to start the migration.

[ ] Set up react admin client
[x] Setup admin redux store
[ ] Setup admin react router
[ ] Setup form library
[ ] Migration guide

Separate issues to create:

(/) Build out the Home view
(/) Create Header Toolbar
(/) Create Side Menu
(/) Create AddIntersectionsTable
(/) Create React Admin version of AdvocacyGroups (tests, form, and view)
(/) Create React Admin version of Artifacts (tests, form, and view)
(/) Create React Admin version of Categories (tests, form, and view)
(/) Create React Admin version of Geographies (tests, form, and view)
(/) Create React Admin version of Levels (tests, form, and view)
(/) Create React Admin version of Officials (tests, form, and view)
(/) Create React Admin version of Publications (tests, form, and view)
(/) Create React Admin version of VideoTestimonials (tests, form, and view)

@ed-snodgrass I edited your description for checkboxes example.  Like?  I kept your strikethrough, but maybe that is automatic(?)

[ ] test
[ x ] test
[ ] test

Nice. Thank you Mark. I'll check off the forms library when I finish the testing of the forms.


plugin + eureka: Add fate tracking support

Following patch 5.18, NMs only render (and the client only receives the Added Combatant line) when the player is within 100y of them. Upon leaving the 100y radius Removed Combatant lines are sent. These changes made the overlay unable to usefully track FATEs in Hydatos.
This PR moves the eureka overlay from relying on Added/Removed Combatant loglines, and adds a new FateWatcher module to the plugin using FFXIV.Machina to watch network packets for FATE info. Korean/Chinese clients are also supported (although I don't have the chinese client OpCode upon submission of this PR).
This also allows us to track the bunny FATEs! Yay!

Alright, I realize I don't have any authority here but...

No no...pull request comments from anybody are always much appreciated.  Thanks for taking the time to review.

Really thank you for your input here, everything you've suggested is good and I greatly appreciate it. I'll try and implement it over the next day or so.

I just updated my own network parsing code to read the opcode from the FFXIV plugin. Feel free to use this as a template.

I just updated my own network parsing code to read the opcode from the FFXIV plugin. Feel free to use this as a template.

Thank you! Sorry for the vanishing act, I'm back and working on this.

I've tried implementing most of the suggestions here, thank you massively for all your input. I know it's been a long time..
AFAIK all I have left to do is add the new options to the config panel UI, add translations for the bunny fates (input welcome on that) and then a final review.

Thank you!!!
I'll try to give this a whirl and take a look at it this weekend when I have a little bit more time.

Thanks for all this.  I'm going to merge this now to avoid conflicts on #1353, and because this all looks good and ready to go.  Other followups can be done separately if you want to do them.  :)


IntroText.json in mods folder

What feature do you want to get added on the base engine?
I would like to add my custom quotes on the intro of my mod, but I'm doing a modpack (you don't have a .exe in it) but we can't. So, I'd be cool if we could put a IntroText.json in the mods folder that works. Thanks !
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

IntroText.txt already works, but only on the mod at the top of your "mods" menu

IntroText.txt already works, but only on the mod at the top of your "mods" menu

Does it work the same as Kade Engine?

The top mod can do that.


Issue 313: Regular expression pattern constraint for attachment filenames

Description
When included in a document definition, the filenameRegexPattern constraint verifies that all attachments for that document type conform to the specified regular expression pattern.
Testing

Generate a sync function from attachment-constraints-doc-definitions.js:

./make-sync-function -j test/resources/attachment-constraints-doc-definitions.js build/test-sync-function.txt

Copy and paste the sync function into a Sync Gateway configuration file.
Create a test document:

PUT /test/attachment-test-1 HTTP/1.1
Host: localhost:4985
Content-Type: application/json

{
	"type": "staticAttachmentFilenameRegexPatternDoc"
}

Add an attachment with a valid filename to the document (it should succeed with 201 Created):

PUT /test/attachment-test-1/foo.xls?rev=1-35244b689bcb92f9767971da257112e8 HTTP/1.1
Host: localhost:4985
Content-Type: text/plain

This isn't actually an Excel document, despite the file extension, but it doesn't matter because the document type doesn't validate content type of attachments.

Attempt to add an attachment with an invalid filename (it should be rejected with 403 Forbidden):

PUT /test/attachment-test-1/bar.invalid?rev=2-6ddfb9f095264f2658ba82f5ed48e6bc HTTP/1.1
Host: localhost:4985
Content-Type: text/plain

The file name doesn't match the regex: /^(foo|bar)\.(xls|xlsx)$/

Related Issue

GitHub issue link: #313

Yes, that's a good point. I'll add some specs for dynamic constraints.

@dkichler: Ready for review again.


qsctl throws UnicodeDecodeError while use os.walk

Step to reproduce
qsctl 1.7.0 with python 2.x on linux
>>> # create a file with bad name:
>>> touch $(echo -e "\x8b\x8bThis")
>>> qsctl sync ./ qs://xxxxxx

Fixed by https://github.com/yunify/qsctl/commit/b4f2ab1a1a6a8bc324d8b520f0b842d8738cfb3d


Infer source edges

What
Currently the edges which are considered to be sources for allocation are given as input in the allocation_network_id column of the Edge table. I'm wondering whether this is still necessary, because whether an edge is a source can be inferred.
Why
No unnecessary input should be expected from the modeler.
How
Whether an edge is a source can be inferred from the connected nodes:  outgoing edges of LevelBoundary and FlowBoundary nodes. Vertical fluxes on basins can also be sources but these are handled differently (https://github.com/Deltares/Ribasim/issues/564#issuecomment-1805696385).

After discussion with @gijsber we concluded that this is not desired, as the modeler should always specify an order of preference over the sources.


Rearrange OBS projects to match IBS setup

Rearrange OBS repositories (Dev, Stable, Staging) to match IBS setup. We should be consistent and have the same setup everywhere for the sake of clarity and maintainability.
See Devel:Elemental:Teal53 project in IBS where all packages, containers and images are built within the same project under the repositories  standard, charts, containers, images.
Also with this setup we could even think on attempting a next step automation goal, building a fully functional elemental artifacts in OBS based on PRs, allowing developers to have a full build ready to be deployed (images in the registry and helm charts rebuild accordingly) by just submitting a PR to github.

This is a breaking change to all our URLs and image references. Should be done a while after we are publishing in IBS through maintenance.  Marking as blocked

Should probably wait for Teal54 ?!
@agracey - this needs offline discussion

We should document the IBS builds as the primary images.

Going to be applied as part of #815


Dev install doesn't work without h5py already installed

pip install -e .
Obtaining file:///Users/saul/p/jupyterlab-hdf
    ERROR: Command errored out with exit status 1:
     command: /usr/local/miniconda3/envs/jupyterlab-hdf/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/saul/p/jupyterlab-hdf/setup.py'"'"'; __file__='"'"'/Users/saul/p/jupyterlab-hdf/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info
         cwd: /Users/saul/p/jupyterlab-hdf/
    Complete output (9 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/Users/saul/p/jupyterlab-hdf/setup.py", line 56, in <module>
        from jupyterlab_hdf._version import __version__
      File "/Users/saul/p/jupyterlab-hdf/jupyterlab_hdf/__init__.py", line 10, in <module>
        from .contents import HdfContentsManager, HdfContentsHandler
      File "/Users/saul/p/jupyterlab-hdf/jupyterlab_hdf/contents.py", line 7, in <module>
        import h5py
    ModuleNotFoundError: No module named 'h5py'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

You are using option 6 here, which comes with this warning:

Although this technique is common, beware that it will fail if sample/init.py imports packages from install_requires dependencies, which will very likely not be installed yet when setup.py is run.

Hmm, I see the problem. Are you prepping a PR? If not I'll just fix it

Hmm, I see the problem. Are you prepping a PR? If not I'll just fix it

Nope, I worked around it by installing h5py first

Makes sense. Think I'll choose option 1, then

Ended up going with option 3, since that was already built into my setupbase.py file


[SPARK-20728][SQL] Make ORCFileFormat configurable between sql/hive and sql/core

What changes were proposed in this pull request?
SPARK-20682 is trying to improve Apache Spark to have a new ORCFileFormat based on Apache ORC for many reasons.
On top of that, this PR depends on SPARK-20682 and aims to provide a configuration to choose the default ORCFileFormat from legacy sql/hive module or new sql/core module.
For example, this configuration will affects the following operations.
spark.read.orc(...)

CREATE TABLE t
USING ORC
...

Since SPARK-20682 (#17924 and #17943) are still under review, I'm inevitably including the dependent code. I'll update this and previous PR according to the review result. Also, in this PR, I updated ParquetReadBenchmark to help reviewers understand the state-of-the-art status of Apache Spark.
How was this patch tested?
Pass the Jenkins with new test suites.

Test build #76924 has started for PR 17980 at commit 7716234.

Test build #76924 has finished for PR 17980 at commit 7716234.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76924/
Test FAILed.

Test build #76931 has started for PR 17980 at commit 73d56f2.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76931/
Test FAILed.

Retest this please.

Test build #76935 has started for PR 17980 at commit 73d56f2.

Test build #76935 has finished for PR 17980 at commit 73d56f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76935/
Test PASSed.

Test build #77011 has started for PR 17980 at commit 87dd161.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77011/
Test FAILed.

Retest this please

Test build #77019 has started for PR 17980 at commit 87dd161.

Test build #77019 has finished for PR 17980 at commit 87dd161.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77019/
Test PASSed.

Test build #77264 has started for PR 17980 at commit 05716c8.

Test build #77264 has finished for PR 17980 at commit 05716c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77264/
Test PASSed.

Hi, @sameeragarwal , @cloud-fan , @gatorsmile .
Could you give me some advice on this? I think this is the start of Feature Parity for ORC.

Retest this please.

Test build #78192 has started for PR 17980 at commit 05716c8.

Test build #78192 has finished for PR 17980 at commit 05716c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78192/
Test PASSed.

Test build #79264 has started for PR 17980 at commit 39c3851.

Test build #79264 has finished for PR 17980 at commit 39c3851.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79264/
Test FAILed.

Retest this please.

Test build #79269 has started for PR 17980 at commit 39c3851.

Test build #79269 has finished for PR 17980 at commit 39c3851.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79269/
Test PASSed.

Hi, @rxin, @sameeragarwal , @cloud-fan , @gatorsmile , @viirya .
Since Apache Spark 2.2.0 release is going to coming soon, it's a good time to restart this.
Could you give me some advice how to make ORC support up-to-date in Apache Spark 2.3?

Test build #79412 has started for PR 17980 at commit cbc5bc2.

Test build #79412 has finished for PR 17980 at commit cbc5bc2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79412/
Test PASSed.

Test build #79570 has started for PR 17980 at commit 5db6acf.

Test build #79570 has finished for PR 17980 at commit 5db6acf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79570/
Test PASSed.

In general, this PR seems to have the large number of lines.
Are there any ways to split this PR into multiple smaller PRs?

Thank you for review, @kiszk .

The first one about adding new ORC source is more smaller than this .
Also, there is more smaller version without vectorized part.

If we need to split more, we can split the one adding Apache ORC dependency into a separate one, too. Is that helpful for review?
In general, about 50% lines are new ORC test codes which is duplicated from old ORC test codes. Could you recommend some better way?

Hi, @kiszk . I will start with Adding Apache ORC dependency (pom and dependency changes) in
SPARK-21422 first.

If new test cases works for existing orc component, how about updating test cases at first?

I developed new ORC component and tests in sql/core module without sql/hive module. Do you mean add a sql/hive module test-dependency into sql module?

I see. I thought that new tests are for old and new ORC components.

I'm trying to split the PR as you recommend. Thank you always.

Retest this please.

Test build #80224 has started for PR 17980 at commit 5db6acf.

Test build #80224 has finished for PR 17980 at commit 5db6acf.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80224/
Test FAILed.

Merged build finished. Test FAILed.

Retest this please

Test build #80254 has started for PR 17980 at commit 5db6acf.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80254/
Test PASSed.

Retest this please.

Test build #80603 has started for PR 17980 at commit 5db6acf.

Test build #80603 has finished for PR 17980 at commit 5db6acf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80603/
Test PASSed.

Test build #80727 has started for PR 17980 at commit 5a9958d.

Test build #80727 has finished for PR 17980 at commit 5a9958d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80727/
Test FAILed.

Test build #80729 has started for PR 17980 at commit 61b27e5.

Test build #80729 has finished for PR 17980 at commit 61b27e5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80729/
Test FAILed.

Retest this please.

Test build #80741 has started for PR 17980 at commit 61b27e5.

Test build #80741 has finished for PR 17980 at commit 61b27e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80741/
Test PASSed.

Retest this please.

Test build #81090 has started for PR 17980 at commit 61b27e5.

Test build #81090 has finished for PR 17980 at commit 61b27e5.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81090/
Test FAILed.

Test build #81095 has started for PR 17980 at commit 02371c6.

Test build #81095 has finished for PR 17980 at commit 02371c6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81095/
Test FAILed.

Test build #81096 has started for PR 17980 at commit 04b8494.

Test build #81096 has finished for PR 17980 at commit 04b8494.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81096/
Test PASSed.

Test build #81190 has started for PR 17980 at commit 257e5a6.

Test build #81190 has finished for PR 17980 at commit 257e5a6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81190/
Test PASSed.

Test build #81274 has started for PR 17980 at commit edead5d.

Test build #81274 has finished for PR 17980 at commit edead5d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81274/
Test PASSed.

Test build #81379 has started for PR 17980 at commit c50e997.

Test build #81379 has finished for PR 17980 at commit c50e997.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81379/
Test PASSed.

Test build #81612 has started for PR 17980 at commit 01868ab.

Test build #81612 has finished for PR 17980 at commit 01868ab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81612/
Test PASSed.

@dongjoon-hyun Do we still need this PR?

Thank you for review, @jiangxb1987 . Yes. This is still required. I'll rebase this PR after #19651 .

Almost codes inside this PR are merged now except #19943 .


Localize Enum Display names

This PR addresses a bug and a couple missing features.
The bug is that Enum value localization would previously store the first localization that's hit and always use that. By passing a function which returns a Name value to the constructor of EnumNameAndGroup and executing that when we need the name we avoid this.
One missing feature is that the GetEnumSelectList was checking the DisplayAttributes for values to display, but it wasn't localizing those values like other uses of DisplayAttributes do.
The other missing feature was that Html.DisplayFor didn't pay attention to DisplayAttributes on enums, and consequently didn't localize them.

I'll take reviewing this one.

CC @Eilon and @dougbu. I know this isn't exactly what we had talked about (adding new Enum properties to the DisplayName context) but once I got down into it it seemed cleaner this way.

The bug is that Enum value localization

When submitting the final commit, please update the description to avoid the implication that [Display(Name = "Fred")] is only about localization. The attribute is in general about UI overrides, in some cases including localization of the displayed strings.

This PR addresses a bug

What bug number? Do we have anything tracking the bug or either of the gaps mentioned in the description?
Not sure about doing the three separate pieces in one PR. I'm not confident the added tests are covering each bit sufficiently.

:watch:

:up::date: I started to split this up into three separate PR's but they're connected enough that it was going to take more time than I though was really prudent to spend on it. Are there any specific test case you feel are missing?

:watch:

:up::date: looks like the only unaddressed thing was the new dependency.

:watch: let's sit down and go through your next iteration together.

:watch: mainly for EnumGroupAndNameTest refactoring

:up::date: Good idea on the comparer, made it much cleaner than the silly foreach zip I had started trying to do.

:up::date:

:watch: for some cleanup

:up::date:

:watch: for the last couple of wrinkles to be ironed out.

:up::date:

:shipit: w/ one removal and a better commit description. Also mention the relevant bugs.

@dougbu are you talking about the actual commit message or about the Pull Request description? Because I already added the # for the 3 bugs and removed (to my eyes) the implication that it's only about localization on the Pull Request description.


Add policy definitions to help secure data workloads

Overview/Summary
This PR adds a number of policy definitions previously authored by @marvinbuss, and supersedes the following PRs:

#756
#758
#759
#760
#761
#762
#763
#764
#765

These policies need to be reviewed before this PR is merged. These are our initial observations against the current available built-in policies:

Custom Policy Definition ID
Observations

Append-Synapse-Purview
Has no built-in matches.

Deny-Cosmos-Cors
Has no built-in matches.

Deny-Cosmos-KeyBasedMetadataWriteAccess
Similar to 4750c32b-89c0-46af-bfcb-2e4541a818d5 but the built-in policy uses an append effect instead of - Deny.

Deny-DataExplorer-Sku
Has no built-in matches.

Deny-DataExplorer-TrustedExternalTenants
Has no built-in matches.

Deny-DataFactory-ApiVersion
Has no built-in matches.

Deny-DataFactory-IdentityType
Has no built-in matches. (similar to f78ccdb4-7bf4-4106-8647-270491d2978a but the built-in is for Azure Data Factory linked services)

Deny-DataFactory-IntegrationRuntimeManagedVirtualNetwork
Has no built-in matches. (similar to 0088bc63-6dee-4a9c-9d29-91cfdc848952 but not a suitable alternative)

Deny-DataFactory-ManagedPrivateEndpoints
Has no built-in matches. (extends the controls relating to 8b0323be-cc25-4b61-935d-002c3798c6ea)

Deny-DataFactory-PublicNetworkAccess
Matches the built-in policy 1cf164be-6819-4a50-b8fa-4bcaa4f98fb6. Consider removing.

Deny-EventHub-IpFilterRules
Has no built-in matches.

Deny-EventHub-MaximumThroughputUnits
Has no built-in matches.

Deny-EventHub-NetworkRuleSet
Has no built-in matches.

Deny-EventHub-Sku
Has no built-in matches.

Deny-EventHub-VNetRules
Has no built-in matches.

Deny-HdInsight-MinimalTlsVersion
Has no built-in matches.

Deny-HdInsight-NetworkProperties
Similar to c8cc2f85-e019-4065-9fa3-5e6a2b2dde56. Needs evaluation.

Deny-HdInsight-Sku
Has no built-in matches.

Deny-IotHub-MinimalTlsVersion
Has no built-in matches.

Deny-IotHub-Sku
Has no built-in matches.

Deny-Search-PublicNetworkAccess
Similar to 9cee519f-d9c1-4fd9-9f79-24ec3449ed30 but built-in uses modify effect instead of deny

Deny-Search-Sku
Has no built-in matches.

Deny-StreamAnalytics-ClusterId
Has no built-in matches.

Deny-StreamAnalytics-StreamingUnits
Has no built-in matches.

Deny-Synapse-Firewall
Similar to 56fd377d-098c-4f02-8406-81eb055902b8 but built-in uses audit effect instead of deny

Deny-Synapse-LinkedAccessCheckOnTargetResource
Has no built-in matches.

Deny-Synapse-Spark-AutoPause
Has no built-in matches.

Deny-Synapse-Spark-AutoScale
Has no built-in matches.

Deny-Synapse-Spark-ComputeIsolation
Has no built-in matches.

Deny-Synapse-Spark-DefaultSparkLogFolder
Has no built-in matches.

Deny-Synapse-Sql-Sku
Has no built-in matches.

Deploy-DataFactory-ManagedVnet
Has no built-in matches.

Deploy-Synapse-AuditingSettings
Similar to ac7891a4-ac7a-4ba0-9ae9-c923e5a225ee but potentially not a suitable replacement due to storage account creation logic in built-in. Also 32ba8d30-07c0-4136-ab18-9a11bf4a67b7 might be better option due to using Log Analytics for log storage.

Deploy-Synapse-Sql-AuditingSettings
Has no built-in matches.

Deploy-Synapse-Sql-MetadataSync
Has no built-in matches.

Deploy-Synapse-Sql-SecurityAlertPolicies
Has no built-in matches. (similar for workspaces, but not sqlPools)

Deploy-Synapse-Sql-TransparentDataEncryption
Similar to cfaf0007-99c7-4b01-b36b-4048872ac978 but built-in uses AuditIfNotExists effect instead of DeployIfNotExists.

Deploy-Synapse-Sql-VulnerabilityAssessment
Has no built-in matches.

Deploy-Synapse-VulnerabilityAssessment
Similar to 0049a6b3-a662-4f3e-8635-39cf44ace45a but built-in uses AuditIfNotExists effect instead of DeployIfNotExists.

This PR fixes/adds/changes/removes

No linked issues

Breaking Changes

None

Testing Evidence
Need evidence to validate that these policies all work as expected.
Also need to validate which of these are compatible with AzureChinaCloud and AzureUSGovernment clouds.
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[ ] Updated relevant and associated documentation.
[x] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@marvinbuss - these are now ready for you to review and ensure they are still valid. I've provided a quick review in the PR description to identify any possible overlap with built-in policies but do not want to make changes without your input as you were the original contributor for these.
Do you also want to identify at which scopes these should be assigned, otherwise these will not add value to the ALZ reference implementation.
If you feel these are "optional" for customers, perhaps we could add a flag to the implementation options to allow customers to optionally enable these?


Move level up check to task generation

Currently we check if a Hero has leveled up while applying the task results to the Hero state, which causes some funkiness with responsibilities vis a vis the HeroManager and TaskResultGenerator classes. If we check for leveling up when the Task is generated that should resolve these issues.

As part of this, change the code so that TaskManager just asks TaskGenerator for a new Task, rather than asking for a generator algorithm. This hides the implementation of how to generate a Task from the TaskManager.
This will then allow us to refine the Task generation process, which should be 3 steps:

Determine next Task type
Determine specifics of Task based on type
Check results against Hero to see if it will cross any thresholds (level, short-term limit, etc.) and update Task results accordingly.

Steps 2 and 3 seem like they should primarily be handled by TaskResultGenerator.

I could clean up how task "results" are generated, but for now at least all responsibilities are where they should be. Closing this, and I will open a new ticket for refactoring the actual result generation/application process.


Schema is not documented

Need to make a Json-Schema document to describe the api schema.

Currently in progress: http://vgmdb.info/schema/album.json

Done


fix: auto active other item after tab item closed in FluentTabs .

🐛 Bug Report
The close operation causes the first tab item to be selected by default.
💻 Repro or Code Sample
see tabs Dynamic demo: https://www.fluentui-blazor.net/Tabs
🤔 Expected Behavior
scene 1:

In Dynamic demo, I select item month 5, selected index is 4.
Click close button, remove item month 5.
Current active item is month 6 (selected index is 4).
Auto select adjacent item.

scene 2:

In Dynamic demo, I select item month 5, selected index is 4.
Click close button in month 4, remove item month 4.
Current active item is month 5 (selected index is 3).
Keep select same item.

😯 Current Behavior

Hello,
Thank you for your comment. This could be another possibility, but at the moment we've chosen to go back to the first element. When a tab is removed from the list, we of course have to go back to an existing element. What's wrong with going back to the first element instead of an adjacent one?


XcodeProj's dependency on swift-package-manager breaks dependency resolution for consumers of XcodeProj

Context 🕵♀
In #492, @pepibumur added SwiftPM as a dependency of XcodeProj. In Package.resolved:
.package(url: "https://github.com/apple/swift-package-manager", .branch("swift-5.0-RELEASE")),

What 🌱
Unfortunately, this breaks downstream Swift packages that depend on XcodeProj. There's a restriction in SwiftPM that version-based packages cannot have branch-based dependencies.

Note that packages which use branch-based dependency requirements cannot be depended-upon by packages which use version-based dependency requirements; you should remove branch-based dependency requirements before publishing a version of your package.

So if I create a package that declares a version requirement on XcodeProj:
// swift-tools-version:5.1

import PackageDescription

let package = Package(
  name: "repro",
  dependencies: [
    .package(url: "https://github.com/tuist/XcodeProj.git", from: "7.0.0"),
  ]
)

it'll fail to resolve:
$ swift package resolve
Updating https://github.com/tuist/XcodeProj.git
error: the package xcodeproj[https://github.com/tuist/XcodeProj.git] @ 7.2.2 contains incompatible dependencies:
    swift-package-manager[https://github.com/apple/swift-package-manager] @ swift-5.0-RELEASE

This is using the Swift 5.1 toolchain that ships with Xcode 11.0:
$ swift -version
Apple Swift version 5.1 (swiftlang-1100.0.270.13 clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.7.0
$ xcodebuild -version
Xcode 11.0
Build version 11A420a

Proposal 🎉
Not sure what a good workaround would be, since SwiftPM doesn't tag versioned releases and instead publishes a branch for each Swift version 😬
FWIW, Carthage recently dropped their dependency on SwiftPM due to difficulties supporting multiple Swift versions and working around bugs in SwiftPM itself.

Unfortunately, this breaks downstream Swift packages that depend on XcodeProj. There's a restriction in SwiftPM that version-based packages cannot have branch-based dependencies.

I'm very sorry for that, I was not aware of this restriction and we should definitively work out a solution for this.

Not sure what a good workaround would be, since SwiftPM doesn't tag versioned releases and instead publishes a branch for each Swift version 😬

Since they don't tag versioned releases, we can find a replacement package for the SwiftPM. We only use one of its utilities from one of the tests to run command in the system. If  we find a package that provides that utility and that is Linux compatible I'd replace it.
Would you like to push a fix for it @elliottwilliams? Otherwise I can look into it later this week.
Thanks for bringing this up 🙏

Yes, would be glad to have SwiftPM removed. It’s a very heavy dependency as well

Yes, would be glad to have SwiftPM removed. It’s a very heavy dependency as well

It's only dependency of the test target though.

Sounds good, no worries!

Would you like to push a fix for it @elliottwilliams? Otherwise I can look into it later this week.

Opened #499

XcodeProj 7.3.0 has been released 🚀

Thanks for the quick turnaround on this!

One additional wrinkle: The previous versions of XcodeProj that did have SwiftPM can still screw up package resolution. The Package.swift I wrote above works, but if I add XcodeGen 2.10.1:
// swift-tools-version:5.1

import PackageDescription

let package = Package(
  name: "repro",
  dependencies: [
    .package(url: "https://github.com/tuist/XcodeProj.git", from: "7.0.0"),
    .package(url: "https://github.com/yonaskolb/XcodeGen.git", from: "2.10.1"),
  ]
)

it fails again:
$ swift package resolve
Fetching https://github.com/yonaskolb/XcodeGen.git
Updating https://github.com/tuist/XcodeProj.git
Updating https://github.com/kylef/PathKit
Updating https://github.com/kylef/Spectre.git
Updating https://github.com/tadija/AEXML
Fetching https://github.com/yonaskolb/JSONUtilities.git
Fetching https://github.com/onevcat/Rainbow.git
Fetching https://github.com/jakeheis/SwiftCLI.git
Updating https://github.com/jpsim/Yams.git
Fetching https://github.com/tuist/Shell
error: the package xcodeproj[https://github.com/tuist/XcodeProj.git] @ 7.2.2 contains incompatible dependencies:
    swift-package-manager[https://github.com/apple/swift-package-manager] @ swift-5.0-RELEASE

I think this is because XcodeGen @ 2.10.1 depends on XcodeProj 7.1.0, so SwiftPM's resolver has to consider versions other than the first one it tries to pick. When it considers 7.2.2, it encounters the branch-based dependency and fails.
This is probably a bug in SwiftPM more than a thing XcodeProj needs to deal with here, though. In the meantime, the only workaround I know if is to specify an exact version of XcodeProj in the top-level Package.swift:
8c8
<     .package(url: "https://github.com/tuist/XcodeProj.git", from: "7.0.0"),
---
>     .package(url: "https://github.com/tuist/XcodeProj.git", .exactly("7.1.0")),


[DNM until after 2.9.1 is out] Make KDM handlers run on all Rancher replicas

Issue: #44936

Problem

Currently, the KDM metadata handler runs only on Leader pod by design, this causes KDM versions change happen only on leader pod when the url is changed; leading to a situation where for /v1-rke2-release/releases goes to any non-leader replicas after a url has changed, they would show older versions
Solution

Make sync handler run on all replicas
Testing

Added a validation test here
Engineering Testing
Manual Testing

Easily able to replicas this as shown in #44936
Automated Testing

Test types added/modified:

Validation (Go Framework)

QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

One final request 😁 -- could you include a README.md, detailing the expected config for this and how to run the test 🙂

Closing this in favour of #46645


optimize resync in jiva replicas

Description

Currently we start one replica and let other replicas to sync with the healthy replica, and due to this replicas take too much time for the sync which is unnecessary since jiva controller sends the io's if quorum is met. Due to this time consuming operation controller go into RO state.
Context

Optimizing sync will ensure that there will be less rebuild time and controller wouldn't go into RO state.
Possible Solution

Send start signal to both the replicas who has same revision counter.
Screenshots

Closing via openebs/jiva#204

Merged into 0.9
https://github.com/openebs/jiva/pull/204


portable-pypy support

Issue #326: have this from last year, only tested on debian wheezy.

This adds support for pypy2-2.3.1, pypy2-2.4.0, pypy3-2.3.1 and pypy3-2.4.0, which is already worth pulling. However the current PyPy2 release is 2.5.0 so that version would be most useful to have. Also why not support all past versions of this portable pypy distibution?
Should the portable pypy have its own namespace? That would actually not solve the issue I reported in #326. Perhaps the Ubuntu-specific pypy should move to its own namespace, too. So pyenv would install PyPy from source by default, which should always work. If possible, use the precompiled variants.
I already tested the portable distribution under Fedora. I checked out your branch and all versions downloaded and installed as expected. I had to install virtualenvwrapper manually, to avoid error messages when opening a new terminal.

@olliewalsh :+1:
@BengtOFFIS Lack of some versions isn't a problem. Anyone can write patch and send some PRs.
Replace pypy namespace by pypy-portable would be nice for Linux variants other than Debian/Ubuntu, but it might not be nice for platforms other than Linux such like OS X. Just introducing new namespace of pypy-portable would be the simplest way to deal with....

@BengtOFFIS Pushed 292813eca39d3dd18fde2e6c3040071607b25e51 to install pypy-portable on unsupported platforms. This might be the best for your needs.

Also why not support all past versions of this portable pypy distibution?

Been months since I looked at this but IIRC the older portable pypy packages did not create the pypy symlink so they would not work with pyenv - this could be fixed up after install I suppose.

Closing this PR as it's superceded by
https://github.com/yyuu/pyenv/commit/292813eca39d3dd18fde2e6c3040071607b25e51

@olliewalsh 292813eca39d3dd18fde2e6c3040071607b25e51 hasn't been merged into master branch yet. Anyway I will merge them later. Thanks for sending PR :octocat:


Add a custom classification layer as a head of the model

The head of the model has one layer by default, going from 768 neurons (hidden state) to 17 (number of classes).
This is not exactly what it was initially implemented, having 3 layers as a head consisting of: Linear (768, 50), ReLU, Linear (50, 17)
I need to write a custom classifier class to include this.

The Trainer class accepts models coming from 2 different inputs: a pretrained model from transformers, or a Pytorch module.
I am trying to plug in the classifier class implemented by Olesya to my trainer. However, I am getting an error at the moment: RuntimeError: mat1 and mat2 shapes cannot be multiplied (32x17 and 768x50)
Note that I have tweaked it a little bit, especially the line that defines the last hidden layer to remove CLS tokens.
This is the code:
config = {
    "hidden_layer_size": 768,
    "classifier_intermediate_layer_size": 50,
    "classifier_layer_size": 17,
}

def tokenize(batch):
    """Tokenises the text and creates a numpy array with its assigned labels."""
    encoding = tokenizer(batch["text"], max_length=177, padding="max_length", truncation=True)

    labels_batch = {k: batch[k] for k in batch.keys() if k in labels}
    labels_matrix = np.zeros((len(batch["text"]), len(labels)))
    for idx, label in enumerate(labels):
        labels_matrix[:, idx] = labels_batch[label]
    encoding["labels"] = labels_matrix.tolist()
    return encoding

class BertClassifier(nn.Module):
    """Bert Model for the multi label classification task."""
    def __init__(self, config, freeze_bert=False):
        """
        @param   bert: a BertModel object
        @param   classifier: a torch.nn.Module classifier
        @param   freeze_bert (bool): Set `False` to fine_tune the Bert model
        """
        super(BertClassifier,self).__init__()

        self.bert = AutoModelForSequenceClassification.from_pretrained(
            "bert-base-uncased",
            problem_type="multi_label_classification",
            num_labels=len(config["labels"]),
            id2label=config["id2label"],
            label2id=config["label2id"],
        )

        self.classifier = nn.Sequential(
                            nn.Linear(config["hidden_layer_size"], config["classifier_intermediate_layer_size"]),
                            nn.ReLU(),
                            nn.Linear(config["classifier_intermediate_layer_size"], config["classifier_layer_size"]))
        self.sigmoid = nn.Sigmoid()
        # Freeze the Bert Model
        if freeze_bert:
            for param in self.bert.parameters():
                param.requires_grad = False

    def forward(self,input_ids,attention_mask):
        """
        Feed input to BERT and the classifier to compute logits.
        @param    input_ids (torch.Tensor): an input tensor with shape (batch_size,
                      max_length)
        @param    attention_mask (torch.Tensor): a tensor that hold attention mask
                      information with shape (batch_size, max_length)
        @return   logits (torch.Tensor): an output tensor with shape (batch_size,
                      num_labels)
        """
        outputs = self.bert(input_ids=input_ids,
                           attention_mask = attention_mask)

        # Extract the last hidden state of the token `[CLS]` for classification task
        print(outputs.keys())
        # Feed input to classifier to compute logits
        logit = self.classifier(outputs["logits"])

        return logit

class MultilabelTrainer(Trainer):
    def compute_loss(self, model, inputs, return_outputs=False):
        """
        Custom loss function calculation using BCEWithLogitsLoss, it returns the loss and the outputs if the
        return_outputs flag is set to True
        This function is used during training, evaluation, and prediction; specifically every time a batch is processed.
        The default loss function is here https://github.com/huggingface/transformers/blob/820c46a707ddd033975bc3b0549eea200e64c7da/src/transformers/trainer.py#L2561

        Args:
          model: the model we're training
          inputs: a dictionary of input tensors
          return_outputs: if True, the loss and the model outputs are returned. If False, only the loss is
        returned. Defaults to False

        Returns:
          The loss and the outputs of the model.
        """
        # forward pass
        outputs = model(**inputs)
        logits = outputs.logits
        # compute custom loss
        loss_fct = torch.nn.BCEWithLogitsLoss()
        loss = loss_fct(logits.view(-1, self.model.config.num_labels),
                        labels.float().view(-1, self.model.config.num_labels))
        return (loss, outputs) if return_outputs else loss

I think this is nearly it! I looked at the source code for the Classifier in Transformers, and it was a matter of adding the layers to the self.classifier attribute.
class CustomBertClassifier(AutoModelForSequenceClassification):
    def __init__(self, num_labels, id2label, label2id):
        super().__init__()
        self.bert = AutoModelForSequenceClassification.from_pretrained(
            "bert-base-uncased",
            problem_type="multi_label_classification",
            num_labels=num_labels,
            id2label=id2label,
            label2id=label2id,
        )
        self.classifier = nn.Sequential(
            nn.Linear(768, 50),
            nn.ReLU(),
            nn.Linear(50, 17)
        )


How to catch method_not_supported exception?

I want to catch the exception "method_not_supported", and customer result , how to do?
Thank you!

Perhaps this will help?
http://sanic.readthedocs.io/en/latest/sanic/exceptions.html#handling-exceptions

thanks, this is good.


ci: setup CodeQL code scanning

https://securitylab.github.com/tools/codeql

Codecov Report

Merging #2645 (4b01242) into master (9d975ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2645   +/-   ##
=======================================
  Coverage   93.85%   93.85%
=======================================
  Files          86       86
  Lines        6172     6172
  Branches     1264     1264
=======================================
  Hits         5793     5793
  Misses        348      348
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d975ce...4b01242. Read the comment docs.


[S2GRAPH-45] Provide way to call specific bucket on experiment.

pass impressionId from header into s2core so user can specify specific becket under experiment.

+1 lgtm

+1

+1


Limit panic on large or corrupted string length

When we receive a string with a huge length (because it is corrupted or because it is very large), the code will panic.
The panic happens in makeslice Go library: https://golang.org/src/runtime/slice.go
This patch assume that if the string length is negative or larger than MaxInt32, something is wrong and will return an error.
It should protect the library against most panic raised in that situation.
The rational is that panic while processing stream of data can be critical. We should probably ignore the message with the error and try continuing processing next message.
Please, let me know if you have comments or idea to improve the patch.

This looks great, thanks for the contribution and for providing tests!


Support UE5.3

There seems to be a new uint32 before the pixel_format_name_id in the .uexp file. I don't know the role of this number. But it seems that by consuming it, the rest of the flow works fine (both export and injection), at least with the assets I've tried (which include textures I've cooked myself with UE as well as some I've extracted from a game using FModel).

Hi, can I merge your first commit?
I'll tag the next version as v0.5.6 so you can keep your v0.5.5 release.


Webtop Alpine in Home Assistant blank screen...

Webtop Alpine KDE in Home Assistant X86-6
name: Anderson
about: Webtop Alpine KDE is blackout screen after I installed in my HA
Hi,  Appology if I'm asking anything ain't right or stupid here.. just I'm facing problem on Webtop Alpine KDE in HA. I'm facing a problem that after done installed & launch the apps are just blackout only, anybody could help me on this cause I'm seek arround google whoever have similar problem about this but also cannot fix mine.. browser without plugin, clear cache & etc...
I uninstall & reinstall 3 times, result still the same as picture attached.. just blackout with 1 tiny round circle with pop out to access virtual keyboard & etc.... thanks in advance
Home assistant - Webtop Alpine KDE
Thanks in advance & apprieciated🙏🙏🙏

Thanks! The add-on is broken for the moment but I'm trying to fix it

Thanks and apprieciated. Excited the new batch launch😊

:-) don't be too excited tough ; currently according to my test I managed to start the container manually (going in the ssh terminal addon and executing docker run --rm -it --security-opt seccomp=unconfined --shm-size="1gb" -p 3001:3001 lscr.io/linuxserver/webtop:latest bash) but many images just didn't start. I think there was 1 or 2 that worked (I think it was ubuntu-xfce) I will have to check again

Mmh, there is an error mkdir: cannot create directory '/sys/fs/cgroup/init': Read-only file system

To be updated :
[] Black screen : alpine-xfce ; alpine-kde
[] Partially working : ubunbu-xfce
[] Ingress to solve

Ubuntu works (without ingress) but graphics are messed up ; seems like an issue with drivers

Ok it works. Ubuntu only it seems. So what do you want, KDE or XCFE ?
It seems XCFE is better with low memory systems

Thanks & apprieciated. As per your suggest XCFE.😊

Next step is for me to test :

[ ] TZ setting
[ ] Keyboard setting
[ ] Ingress

For me on rpi4 the default graphic device was not detected so I've implemented an addon option DRINODE where you need to specify you dri device (for me /dev/dri/card1)

I'm using X86/64 Intel NUC 7. Okay, I will try it out on dri device.

virtual keyboard not able to use and just allow me to change position only..

Hi, that's normal ingress does not work yet you need to enable the port in addon options and connect with ip:port

😅😅 Hi. IP:3000 TZ setting as UTC +8.

Thanks, so kasmvnc connects but not webtop. I'll check thanks

Could you please try with puid guid 0 ?

Hi Sir, finally it's works. Thanks and appreciated.
yes, PUID 0 & GUID 0 works now.

but virtual keyboard seem not working yet.

Thanks for the feedback. I've added a chmod -R 755 for the home folder that seems now to allow to use PUID/GUID 1000
I've removed ingress to avoid confusion as it is not working yet
I'll check virtual keyboard but not sure how I can act on it from the addon

Where do you find the virtual keyboard? I don't see it but can use my smartphone or device keyboard. Thanks

I tried now can already. I found only touch screen is works well, if I hover my mouse over the icon & not able to toggle the virtual keyboard pop out. it has to be touch screen to toggle it pop out.

Ingress works but when connecting on computer, phone or ipad my virtual keyboard works...

Hi Sir, thanks for your works & apprieciated. After latest update push I'm not able to start the webtop.
Also last test with the previous version, it causing my HA down & I have to force hard reboot the whole machine.

Hi, TZ must be in the form Country/City (Europe/Paris), so I've added a text in the Readme to describe that. Here are valid values : https://manpages.ubuntu.com/manpages/focal/man3/DateTime::TimeZone::Catalog.3pm.html
I'll reinstall and test it but yesterday it worked fine on mine...

Alright, thanks sir.
Yes successful started TZ as Europe/Paris

So everything is working ?

Yes sir, seem good now and thanks. I'm trying now & keep observe the HA supervisor😊

Hi, this is not really an issue ; it's just a bug from HA. When there is devices, it allows reaching sda devices (hard drives). On virtual machines (which I guess you are on) or some systems where those devices don't exist, it just puts this error in the log. However, there is no issue linked to it, and nothing I can do as it is due to HA supervisor

I see. Okay², thank you very much sir😊😊

Hi Sir, may I know does this webtop able to install any application? I tried to installed few but kept failure, noted that it will causing the RAM consumption increase but just would like to know whether it is possible or not to install side loaded application.😊😅

Hi, you can just add them in the addon options next to engrampa, but they must be part of the Ubuntu store. For example, engrampa,libreoffice


Difficult to keep track of entities that were searched by HNS

Problem
As a user, when I search an entity using HNS the explorer returns the resulting entity but does not store the HNS name used during my sessions. if I have returned many entities using HNS it gets very difficult to know which account is tied to which name.

Provide a solution that stores the HNS domain name temporarily within a users session
When the user exists the sessions it can forget the HNS domain

Feedback from Jesse Whiteside [HashPort]
Solution
See above
Alternatives
No response

If HNS and KNS services reply with two different results then present the two results to the user.


[Do-not-merge] Updates to sample to include user assigned identity

Updating the sample to include user assigned identity.
This sample is equivalent to the python one https://github.com/Azure-Samples/compute-python-msi-vm
Do not merge - still pending full verification.

Thanks @lmazuel
@sarangan12 Sample is now validated, so should be ready to merge. Please let me know if you have any comments, I've pushed a few more updates today. Thanks!


Update books Typescript Indonesian(PDF)

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Sorry sir

This is an english language book
Please read CONTRIBUTING.md guidelines!


Intro Action Nitro!

This PR intro our submission for the clibre gamejam. An action platformer where the goal is to jump from plane to plane and reach the ISS to kill the bad guys.
This game uses both the sprites of gamnit flat and 3D models with gamnit depth. It has many particle effects and manipulates the camera to create custom animations.
Ping the cocreators @R4PaSs, @BlackMinou, @MehdiAit.

No nukes?

I'm asking myself about the repo size. Games are mainly assets and they make the repo more and more heavy to clone. Is an additional 10MB an acceptable burden or should we find a way to handle out-of-tree packages?
Maybe we could use git submodules to help the link between lib+compilo version with game code and other oot projects. Unfortunately, one adage says "you have a git problem, you use submodules, now you have two git problems"

Le controle des tirs au clavier c'est pas top. un controle des tirs a la souris serait plus pratique

I had similar doubts about the size of the project, assets for 3D games are heavy. I could remove some art source files to make it lighter. (like the blender model, and the splash svg+jpg source)
I wouldn't mind using submodules, but the other way around: the game having as submodule a precise version of Nit. If we are to use submodules in the Nit repo, the maintenance would be a pain as a PR could affect many distinct projecs.

Ask @BlackMinou for the nuke. It could easily be added as a powerup!

+1 for me anyway.

The last reroll reduces the project size to 3.4 mb.


Setup with xcworkspace is not working if xcodeproj is in a different folder

First I just want to thanks for this great plugin + an awesome blogpost.. I've been missing vim quite alot in my daily job and would love to use it more with iOS development.
On to my issue, I seem to have problem running setup in some projects I have and I've pinned it down to the structure of the project. The folder structure of the project looks something like this
-- root
  -- MyApp.xcworkspace
  -- MyApp
    -- MyApp.xcodeproj

This unfortunately breaks the assumption in get_project_information that the xcworkspace and the xcodeproj is in the same folder. What do you think would be the best solution to fix this?

Thank you very much!
Hmm, interesting case. I think that the best solution would be to split project selection into 2 steps:

Select xcworkspace (optional, only if we detect xcworkspace, if not we skip second point and show xcodeproj picker)
Check if xcodeproj exists in the same location with the same name, if not show xcodeproj picker.

This solution would have to take into consideration current users that didn't have this step.
Maybe we could check it in "get_project_information" and show picker if needed (only if xcodeproj doesn't exist where we expect it).
Would you like to implement those changes or do you want to wait for me to do that?

@siimon this issue should be fixed now. Could you update the plugin and see if it works as expected now?

@wojciech-kulik works perfectly, thank you so much!


Upgrade to Node.js 16

The "engines" field in package.json is just removed, since it's advisory
only and doesn't affect anything.
Fixes https://github.com/web-platform-tests/wpt-pr-bot/issues/179.

A previous silent error turns into failed tests, fixed in https://github.com/web-platform-tests/wpt-pr-bot/pull/195.


#6292 show yAxisR when set

This fix should be heavily tested before merge. It changes the Plot right axis behavior.

seems to break "Second Y Axis" in PlotFeatures.ipynb


GNU-style release SHA256 sums

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
SHA256 provided with the release cannot be verified using standard Linux tools:
$ sha256sum -c SHA2-256SUMS
sha256sum: SHA2-256SUMS: no properly formatted SHA256 checksum lines found

The reason is two-fold:

file:hash is not a standard checksum syntax, coreutils understands only GNU hash  file or BSD SHA256(file) = hash styles.
For some reason, SHA2-256SUMS has Windows line endings, not Unix ones.

Version line is immaterial and will simply generate a warning:
sha256sum: WARNING: 1 line is improperly formatted

P.S. Consider signing releases with GPG, just like the original fork does: https://github.com/ytdl-org/youtube-dl/releases/download/2021.06.06/youtube-dl.sig.

The updater depends on this format. To apply your PR, first the updater has to be modified to handle this new format (while also keeping support for the old format), hope most people update in a reasonable amount of time and then change the GHA. It would be much easier to just add another file with this new style instead.
As for the new lines, the SHA file was being built by windows machine previously. I only recently split it into a separate action and made it ubuntu-latest while removing py2. So the sed replace should not be necessary

Consider signing releases with GPG, just like the original fork does

I am not sure how to sign in github actions, but I'll look into it.

I guess you’ll have to commit an encrypted private key, then store the passphrase as a repository secret and use it to unlock the key when signing. (The passphrase should be a long random string, but I think you already know that.) And keep a key revocation certificate at the ready, just in case something happens.

I guess you’ll have to commit an encrypted private key, then store the passphrase as a repository secret and use it to unlock the key when signing. (The passphrase should be a long random string, but I think you already know that.)

Why not add the private key itself as the secret?

Actually, this could work too. I guess I’m just used to the model where repository secrets can only store one line of text, but GitHub allows multiline secrets as well.

It would be much easier to just add another file with this new style instead.
Ok. Switched to creating a parallel SHA2-512SUMS instead.

Sorry for the force push. I first merged the branch with my local tip instead of origin/master

To apply your PR, first the updater has to be modified to handle this new format (while also keeping support for the old format), hope most people update in a reasonable amount of time and then change the GHA.

Looks like no one will have much trouble updating even a very old version:
hashes = list(map(lambda x: x.split(':'), hash_data.splitlines()))
return next((i[1] for i in hashes if i[0] == 'yt-dlp%s' % label), None)

will always return None for GNU-style hash without crashing: hash lines have no colons, so i[0] test will simply never succeed. When a hash cannot be found, exe update issues a warning, while zip-file update doesn't even warn!
Looks like the version: line is not used by the updater (and even if it needs a version, it's always available in GitHub's JSON). sha256sum would warn on that line too. So I decided to use version: as a format differentiator: if it's present—colon format is assumed, if it's absent—GNU style is assumed. Currently colon branch is always taken.
May I suggest that in the future, when a substantial number of people have updated their yt-dlps (even if they didn't, the maximum they'll get is a warning), the format of SHA2-256SUMS be changed to a proper GNU style, which validates cleanly without a warning (i.e. has no version: line). Of course, if you don't like that suggestion, you may simply avoid cherry-picking the last commit in this branch.

Looks like no one will have much trouble updating even a very old version:
will always return None for GNU-style hash without crashing: hash lines have no colons, so i[0] test will simply never succeed.

great

while zip-file update doesn't even warn!

fixed

Looks like the version: line is not used by the updater

Correct

sha256sum would warn on that line too. So I decided to use version: as a format differentiator: if it's present—colon format is assumed, if it's absent—GNU style is assumed. Currently colon branch is always taken.

This is good

May I suggest that in the future, when a substantial number of people have updated their yt-dlps (even if they didn't, the maximum they'll get is a warning), the format of SHA2-256SUMS be changed to a proper GNU style, which validates cleanly without a warning (i.e. has no version: line)

Yes, of course. The current hashfile structure is due to youtube-dlc. I don't mind changing it eventually to stay compliant to the UNIX standards. My only concern was the updater. But now that it is a non-issue, I have no reservations in changing it. But, I'd rather not have everyone updating get hit by the warning right away. So we wont make the change right now.
If I forget to get back to this in a month or so, feel free to remind me again

I have pushed some changes. Let me know what you think of them. I am going to sleep rn. If there are no more changes needed, I can merge it tomorrow

I have pushed some changes. Let me know what you think of them.

I'm totally fine with your changes.

If I forget to get back to this in a month or so, feel free to remind me again

Let's create an issue to track it: https://github.com/yt-dlp/yt-dlp/issues/385.


recursive saving fails for STI associations

... at least that's what it seems like.
Here's a reduced test case:
https://gist.github.com/1442692
The last few lines should illustrate the issue. (If not, please let me know so I can elaborate.)
FWIW, an earlier, simpler test case exhibited the same issue, but @markiz managed to fix (or work around?) that.
On IRC @markiz concluded, based on a previous (if old and possibly outdated) ticket, that it might be best to manually traverse the object graph and save the respective objects.
I'm happy to accept that as the recommended solution, but figured it might be worth discussing explicitly.
PS: FWIW, this issue was revealed when I refactored dm-maker.

I'd like to elaborate.
The problem in question seems to be that if you have a graph of objects like this:
     GP
    /  \
   P1   P2
  / \    \
 C1  C2   C3

GP -- grandparent
P  -- parent
C  -- child

And you instantiate whole graph and save one of the children, say, C2, then P2 and its children (C3) will not get saved.
Now you might not know about the parent/child relationship since you can instantiate object both ways (child = Child.new(:parent => Parent.new) and parent = Parent.new(:children => [Child.new])) so not propagating save to children of parents might lead to some surprise.
However, I have a feeling that this behavior is intended. Some clarification is welcome.


Add CI for traceability

Proposed refactoring or deprecation

The goal would be to start validating the PR description.
Motivation

Pitch

Additional context

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @borda @carmocca @akihironitta

Closing as this is no longer necessary


elfutils: enable debuginfod support

elfutils contains several libraries, and when debuginfod support is enabled, only libdebuginfod.so depends on libarchive and curl, among others, leading to a large closure size increase.
To mitigate this effect, libdebuginfod.so is moved to a separate output. libarchive and libcurl remain in the build closure, but derivations which depend on, say, libelf, but not libdebuginfod only retain a reference to the out output and not the libdebuginfod output and their runtime closure size does not increase.
Enabling libdebuginfod by default allows to use nixseparatedebuginfod without recompiling gdb and perf, mostly.
This admittedly complex contraption ensures we don't get two copies of libelf (one for systemd withouth debuginfod support, and one for debuginfod enabled gdb) in this case.
The bin output contains build tools, and since curl and libarchive are always in the build closure we dont move debuginfod and debuginfod-find to a separate output.
tested by rebuilding
/nix/store/axqgmkgmhy2rzlbffglhjv1npy5ni0ra-gdb-13.1
/nix/store/73cbnzc96xir60xff5qblhvw6fb7n309-perf-linux-6.1.21
/nix/store/nk7lla63w1pbzyavgz7hcvdhmrd9qgqy-systemtap-6.1.21-4.8
/nix/store/bhss1whsh67b0wa1mj5h3z1p4nwndxd4-valgrind-3.20.0
/nix/store/v2hlzj0gbnycj7ssznvjvhw5bxwxsbmm-hotspot-1.4.1
/nix/store/7cnyh97201zk780zwbh1sh913wflsgjp-heaptrack-1.4.0
/nix/store/1893dw0r67hh6iqbjdhwbpb8dsc1i8iy-networkmanager-1.40.12
/nix/store/xc5yfb7v042ypmbwwswpsq91jwapls4k-dwz-0.14
/nix/store/vfyvlmrnns4k0dppd6fnddkxc1s3dkck-linux-6.1.21
and checking which of these keep the debuginfod reference.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg eval

I changed the pull request to just setting enableDebuginfod to true without patchelf hacks.

This PR breaks the gdb build on x86_64-darwin (and aarch64-darwin assuming that worked before), as elfutils only supports platforms.linux. I have confirmed that manually disabling gdb.enableDebuginfod with an override fixes this problem, unfortunately people on darwin now have to manually do as i did and compile gdb from source.
It would be nice if we could only enable enableDebuginfod by default on platforms that actually support it.

Yeah, conditionally enabling in gdb sounds very reasonable. Let me try to add a trivial solution:  https://github.com/NixOS/nixpkgs/pull/228697
Can you give it a try?


Fix crash caused by stale owner

Adjust NOTIFICATION_PREDELETE in Node to clean up owned nodes.
Also make sure, that the owner is always an ancestor.
resolve #78736

I see cases where this is needed, but I think there's still a case to fix: in the MRP in #78736, shouldn't the child_node.reparent(self) break the ownership of child_node by owner_node?

I have investigated this case and I was unable to create a crash by reparenting after the changes of this PR.
Still I believe, that there is a bug, that currently reparenting allows a Node to have an owner, that is not an ancestor (which contradicts the owner-description).
I was unable to finish this investigation yesterday and intend to look into this again.

I have updated the PR with an additional verification, that the owner is always an ancestor and added a warning about this case.
I have also considered as a more strict alternative in Node::add_child, but would consider it as too restrictive:
	ERR_FAIL_COND_MSG(p_child->data.owner && p_child->data.owner != this && !p_child->data.owner->is_ancestor_of(this), vformat("Can't add child '%s' to '%s', owner '%s' would no longer be an ancestor.", p_child->get_name(), get_name(), p_child->data.owner->get_name()));

I have also considered as a less strict alternative to adjust the documentation of Node.owner, but had the impression that this would find not enough attention and users might not easily find the reason, why their node's owner became null:
[b]Note:[/b] The owner of the [Node] is automatically erased, if the node is moved to a place in the scene tree where its owner is no longer an ancestor.

I agree with that approach.
I'm wondering if it should be expected that a node still has owned nodes by the time the destructor is run. Shouldn't all the previous mechanics of the owner and/or owned nodes (pre-delete, exit tree notifications, etc., etc.) have cleaned things up?

One of the MRPs in the linked issue sets the owner of a Node, while that node is not in the tree. So tree-notifications don't help in these cases.
Also when handling this during tree-notifications, the owner would always be removed when a Node is relocated in the scene tree, which would be bad for usability.
I was not aware of pre-delete, thanks for bringing this to my attention.
During NOTIFICATION_PREDELETE currently only data.owner is cleared, but not data.owned.
I believe, that it would be conceptually better, if I move the data.owned-clean-up code from ~Node to NOTIFICATION_PREDELETE.

Slightly relevant here: we now have a PR that changes how reparenting works https://github.com/godotengine/godot/pull/81506.
But I guess that wouldn't completely eliminate invalid cases we are trying to prevent here? I would err on the side of caution at this point and bump this to 4.3.
But an approval from @RandomShaper would still be appreciated so we can merge it as soon as the next dev cycle starts 🙂

Thanks!

Cherry-picked for 4.2.2.


wavebox: 10.131.16-2 -> 10.131.18-2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for wavebox is: Wavebox Productivity Browser
meta.homepage for wavebox is: https://wavebox.io
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 10.131.17-2 in filename of file in /nix/store/v3xw4dvfnj7ssnbn8r4w4mzf9s1xp5ba-wavebox-10.131.17-2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

wavebox

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v3xw4dvfnj7ssnbn8r4w4mzf9s1xp5ba-wavebox-10.131.17-2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A wavebox https://github.com/r-ryantm/nixpkgs/archive/372b56fb74171777d17852db9b8dacf4aad886a9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/372b56fb74171777d17852db9b8dacf4aad886a9#wavebox

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v3xw4dvfnj7ssnbn8r4w4mzf9s1xp5ba-wavebox-10.131.17-2
ls -la /nix/store/v3xw4dvfnj7ssnbn8r4w4mzf9s1xp5ba-wavebox-10.131.17-2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

wavebox

Maintainer pings
cc @flexiondotorg for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for wavebox is: Wavebox Productivity Browser
meta.homepage for wavebox is: https://wavebox.io
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 10.131.18-2 in filename of file in /nix/store/ml3l67lhb4hs37l5jah3i5lkyvxc2i47-wavebox-10.131.18-2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

wavebox

Instructions to test this update (click to expand)

Either download from the cache:
nix-store -r /nix/store/ml3l67lhb4hs37l5jah3i5lkyvxc2i47-wavebox-10.131.18-2 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A wavebox https://github.com/r-ryantm/nixpkgs/archive/8fbb91c4f3cf8756ef60597fae595674647a4011.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8fbb91c4f3cf8756ef60597fae595674647a4011#wavebox

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ml3l67lhb4hs37l5jah3i5lkyvxc2i47-wavebox-10.131.18-2
ls -la /nix/store/ml3l67lhb4hs37l5jah3i5lkyvxc2i47-wavebox-10.131.18-2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

wavebox

Maintainer pings
cc @flexiondotorg for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.


Add a webpage for curriculum guides

Description
Clearly and concisely describe the issue or suggestion here:
The curriculum guide pages will be hardcoded for each curriculum. We don't need to store related Digital Technology Curriculum Strands in the database because each curriculum will have their own webpages to then link the unit plans, lessons, curriculum integration into (where appropriate)
Checklist
Change the space in the box to an x for those you have completed. You can also fill these out after creating the issue.

[ ] I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number).

Closing this issue as its progress is now managed on internal resource.


Typo in create-sql-api-nodejs.md

Invalid call to create a container. Probably bad copy/paste from the previous line.

@ivanizag : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ivanizag Thanks for fixing. We will merge your PR soon.
#sign-off

@SnehaGunda: I'm sorry - only the author of this article, @deborahc, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Graalvm is not supported out of the box

To make possible to use micronaut-kubernetes with graalvm is necessary to add the following typehint
@TypeHint(
        value = {
                io.micronaut.kubernetes.client.v1.Port.class,
                io.micronaut.kubernetes.client.v1.Address.class,
                io.micronaut.kubernetes.client.v1.KubernetesObject.class,
                io.micronaut.kubernetes.client.v1.Metadata.class,
                io.micronaut.kubernetes.client.v1.endpoints.Endpoints.class,
                io.micronaut.kubernetes.client.v1.endpoints.EndpointsList.class,
                io.micronaut.kubernetes.client.v1.endpoints.EndpointsSubset.class,
                io.micronaut.kubernetes.client.v1.services.Service.class,
                io.micronaut.kubernetes.client.v1.services.ServiceList.class,
                io.micronaut.kubernetes.client.v1.services.ServiceSpec.class,
                io.micronaut.kubernetes.client.v1.pods.ContainerStatus.class,
                io.micronaut.kubernetes.client.v1.pods.Pod.class,
                io.micronaut.kubernetes.client.v1.pods.PodStatus.class,
                io.micronaut.kubernetes.client.v1.secrets.Secret.class,
                io.micronaut.kubernetes.client.v1.secrets.SecretList.class,
                io.micronaut.kubernetes.client.v1.configmaps.ConfigMap.class,
                io.micronaut.kubernetes.client.v1.configmaps.ConfigMapList.class,
                io.micronaut.kubernetes.client.v1.configmaps.ConfigMapWatchEvent.class,
        },
        typeNames = {
                "io.micronaut.caffeine.cache.SSAW",
                "io.micronaut.caffeine.cache.PSAW"
        },
        accessType = {
                TypeHint.AccessType.ALL_DECLARED_CONSTRUCTORS,
                TypeHint.AccessType.ALL_PUBLIC_METHODS,
                TypeHint.AccessType.ALL_DECLARED_FIELDS
        }
)
public class Application {

    public static void main(String[] args) {
        Micronaut.run(Application.class);
    }
}

it would be great to add this settings to reflection-config.json to make it easier to use.

The caffeine classes are already defined in micronaut-core for master and 1.3.x branches.

Sandy doesn't works

Or maybe is a issue when you use kubernetes and jwt modules, because that was I did.

Those io.micronaut.caffeine classes were included after 1.3.5 was released. If you try with Micronaut 1.3.6 (which was released yesterday) you won't need to define those 2.
We will add all the missing kubernetes classes to the graalvm configuration.

Yep the problem with caffeine was in 1.3.5. In 1.3.6 is working, my bad I didn't check the last version, but this fixing it doesn't listed in the milestone because of that is a little tricky to check the new fixes in new version, implement a Changelog it would be great.
Thanks for add the missing classes.

We're working on improving our release notes to automatically include everything. In some modules we've done the change and we plan to do it in the rest of the modules soon. Thanks for your feedback :-)


Improve design system for testimonials

Need to improve this component on \<Component name>\src\<File Name.html>
Improvements required :
Any reference image?
Any external reference?
You can checkout this one for better understanding.

assign me @rupsha014 @Rajdip019


Add dataset repr to recipe run page

This PR adds a dataset representation section to each recipe run page as requested by @cisaacstern

For instance: https://pangeo-forge-569wyqzf5-pangeo-forge.vercel.app/dashboard/recipe-run/1163?feedstock_id=1


Add a test that shows modeling /scale as a duck for core K8s types.

There are a number of notable differences:

Selector is part of Spec not Status,
Selector is structured vs. string,
The Replicas in Spec is a pointer.

/lgtm


Update LAB_AK_07_Implementing_migration_in_hybrid_scenarios.md

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Submitted by cjpluta on behalf of MOC Labs Review


Close the search results by clicking away

When you're searching, you can usually close the search results by clicking on the 'X' button in the top-right corner.

This button disappears however if you have a long list of search results and have scrolled down through them:

One solution would be to make the 'X' button stick in position as the results are being scrolled. Another solution would be to make the search results box close if a user clicks anywhere outside the results, such as clicking on the map. We could even try doing both of these.

Using a Bootstrap Modal may make more sense for what you need. They come with sections for header, body, and footer. So the title, close button, and any action buttons would always be visible. Possible the scrollable modal so you can scroll the body content https://getbootstrap.com/docs/5.3/components/modal/
But if you do still want to use Bootstrap cards for this you could define header, body, and footer sections with those yourself https://getbootstrap.com/docs/5.3/components/card/#header-and-footer
But as these don't immediately have a scrollable area for the body you would need to put in your own solution to cope with that.


use npm scripts

dopeness. lg.

@paulirish @ebidel I have tried it, but it does not work for me. I miss something?
https://github.com/abdonrd/abdonrd.com/pull/19/files
Thanks in advance!

Hmmm
$ yarn run lh https://abdonrd-develop.firebaseapp.com
yarn run v1.3.2
$ lighthouse-ci https://abdonrd-develop.firebaseapp.com
/bin/sh: 1: lighthouse-ci: not found

but yet:
https://github.com/ebidel/lighthouse-ci/blob/57a3efc66a330ba9b48ac22bf5ba61a209d565db/package.json#L8-L10
i am confused. :/

Did some fixes and things seem to be working now.
https://github.com/ebidel/lighthouse-ci/commit/e57e8972be1fc364f90ae4dcdc2c5d11aa227f01
https://github.com/ebidel/lighthouse-ci/commit/14c3cbd90f411aca339ccdaf5a9230ef078ef382

Now it works, thanks!


CLI for creating controllers

📝 Description
Add a cli command for creating controllers
Describe the solution you'd like
maya generate controller <name>

or
maya g c <name>

This is a good feature to have in our CLI.


Bug: Bitcoin Connect still fetches info if the button is not visible, but is mounted

See https://github.com/getAlby/bitcoin-connect/issues/69
Example is in nostrudel settings page, where the lightning settings are hidden by an expandable section. It'll still request the balance even though the section isn't open.

I am closing this, I think actually it's the responsibility of the app to only render the button when it should be visible.