BkTimeableTest fails intermittently

./takes>mvn -o test
Sometimes org.takes.http.BkTimeableTest fails and sometimes it passes. It should be fixed.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.746 sec - in org.takes.facets.auth.social.PsGoogleTest
Running org.takes.http.BkTimeableTest
Exception in thread "Thread-1" java.lang.IllegalStateException: java.io.FileNotFoundException: C:\Users\fatcat\AppData\Local\Temp\junit8691524069542580095\junit3177265002913825846.tmp (The system cannot find the path specified)
        at org.takes.http.BkTimeableTest$2.run(BkTimeableTest.java:96)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.FileNotFoundException: C:\Users\fatcat\AppData\Local\Temp\junit8691524069542580095\junit3177265002913825846.tmp (The system cannot find the path specified)
        at java.io.FileOutputStream.open(Native Method)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:221)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:171)
        at org.takes.http.Options.socket(Options.java:130)
        at org.takes.http.FtCLI.start(FtCLI.java:94)
        at org.takes.http.BkTimeableTest$2.run(BkTimeableTest.java:88)
        ... 1 more
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.513 sec <<< FAILURE! - in org.takes.http.BkTimeableTest
stopsLongRunningBack(org.takes.http.BkTimeableTest)  Time elapsed: 1.513 sec  <<< ERROR!
java.io.FileNotFoundException: File 'C:\Users\fatcat\AppData\Local\Temp\junit8691524069542580095\junit3177265002913825846.tmp' does not exist
        at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:299)
        at org.apache.commons.io.FileUtils.readFileToString(FileUtils.java:1711)
        at org.apache.commons.io.FileUtils.readFileToString(FileUtils.java:1748)
        at org.takes.http.BkTimeableTest.stopsLongRunningBack(BkTimeableTest.java:104)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask.run(FutureTask.java:262)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)

Running org.takes.misc.VerboseIterableTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.misc.VerboseIterableTest
Running org.takes.http.BkReuseTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0 sec - in org.takes.http.BkReuseTest
Running org.takes.facets.auth.social.PsGithubTest
[?[0;37mINFO?[m] pool-1-thread-3 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:57818 /login/oauth/access_token): [200 OK] in 16ms
[?[0;37mINFO?[m] pool-1-thread-3 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:57818 /user): [200 OK] in 0ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.075 sec - in org.takes.facets.auth.social.PsGithubTest
Running org.takes.rs.RsJSONTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.331 sec - in org.takes.rs.RsJSONTest
Running org.takes.facets.auth.social.PsLinkedinTest
[?[0;37mINFO?[m] pool-1-thread-8 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:57820 /uas/oauth2/accessToken): [200 OK] in 0ms
[?[0;37mINFO?[m] pool-1-thread-8 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:57820 /v1/people/): [200 OK] in 0ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.216 sec - in org.takes.facets.auth.social.PsLinkedinTest
Running org.takes.rs.RsWithoutHeaderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.rs.RsWithoutHeaderTest
Running org.takes.facets.auth.TkAuthTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.468 sec - in org.takes.facets.auth.TkAuthTest
Running org.takes.facets.auth.codecs.CcBase64Test
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.takes.facets.auth.codecs.CcBase64Test
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8

Results :

Tests in error:
  BkTimeableTest.stopsLongRunningBack:104 -+ FileNotFound File 'C:\Users\fatcat\A...

Tests run: 302, Failures: 0, Errors: 1, Skipped: 5

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

@yegor256 please do something about this issue

@simonjenga milestone set to 1.0 (correct me if I am wrong)

@rajithd can you please help? Keep in mind this. If you have any technical questions, don't hesitate to ask right here; This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

@simonjenga many thanks, 15 mins added to your acc for reporting this bug, pmt ID 74654376

@simonjenga couldn't reproduce the issue. Tried many ways to reproduce (mvn -o test, mvn clean install, mvn test,  mvn -Dtest=BkTimeableTest test) but all the test cases were passed without any issue. I'm suspecting this may related to OS because I'm using Ubuntu and based on the log you are using windows. Is there any additional steps for this ?

@rajithd It may be related to the OS. I am using Windows 7 and i just executed the command:
mvn -Dtest=BkTimeableTest test and i was able to reproduced the same issue with the error again.
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.takes.http.BkTimeableTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.83 sec <<< FAILURE! - in org.takes.http.BkTimeableTest
stopsLongRunningBack(org.takes.http.BkTimeableTest)  Time elapsed: 1.83 sec  <<< ERROR!
java.io.FileNotFoundException: File 'C:\Users\fatcat\AppData\Local\Temp\junit7823434478729757194\junit6511253519646324226.tmp' does not exist
        at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:299)
        at org.apache.commons.io.FileUtils.readFileToString(FileUtils.java:1711)
        at org.apache.commons.io.FileUtils.readFileToString(FileUtils.java:1748)
        at org.takes.http.BkTimeableTest.stopsLongRunningBack(BkTimeableTest.java:104)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask.run(FutureTask.java:262)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)

Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8

Results :

Tests in error:
  BkTimeableTest.stopsLongRunningBack:104 ┬╗ FileNotFound File 'C:\Users\fatcat\A...

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

@rajithd check this "no obligations principle".. This task is on your name for at least 15 days. If you can't close it within the next 48 hours I will have to assign someone else to it. This article should help if you're stuck
added -30 to your rating, now it is equal to -90

@rajithd the task is overdue, and I have to re-assign it to someone else. Please, stop working with it immediately. In general, we're against overdue tasks, check this page; -60 added to your rating, current score is: -240

@raphaelln could you please pick this up? This article explains how we work. Any technical questions you may ask right here. The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed

@simonjenga please could you please share with me your environment configs ? I couldn't reproduce the error, following my configs:

Windows 7 Professional
java 8 (1.8.0_51)
maven 3.3.9
intel core 2 duo 2.93
8gb ram

Besides that, I investigated the source and I believe is the time to create the temp file is greater than in our machine than ours, because the test first create and delete the file:
final File file = this.temp.newFile();
file.delete();
After that, starts the thread, which will create the socket connection and the required file.
But the sleep time (1500 ms) in the test case, is not enough to create the file in time to be able to process it in the next line of the code.
Please if possible, could you please put just for a little test, the following line in:
Options.java
after line 182
System.out.println("************* CLOSING THE FILE ***********************");`
And try to simulate the error again, and please check if the above code is executed before the read try.

@raphaelln There are intermittent results (FAILURE/SUCCESS) within Unit tests that have something to do with creating files in the temp Dir in my computer.
System.out.println(System.getProperty("java.io.tmpdir"));
C:\Users\fatcat\AppData\Local\Temp\

Try to reproduce this issue in the following environment:
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files (x86)\Java\jdk1.7.0_80\jre
Apache Maven >= 3.1.1
Default locale: en_GB, platform encoding: UTF-8
OS name: "windows 7", version: "6.1", arch: "x86", family: "windows"

The same error messages may appear on:
Apache Maven 3.2.1, Apache Maven 3.2.5 and Apache Maven 3.3.3
The reason this FAILURE sometimes happens is because this project generates and fills my temp Dir with a lot of folders and it does not delete them. I have to manually delete them to make the Build to pass.
I recently manually deleted all those folders in the my temp Dir and so far the Build is OK. But after some time, this problem will recur after executing the project Build several times for some days.
I think part of the fix to this issue is to visit the source code and look at places where temp folders are being created and not deleted e.g org.takes.tk.TkFilesTest.dispatchesByFileName() and then put appropriate code to delete the dir being created.
This is your request:
[INFO]
[INFO] --- maven-surefire-plugin:2.19:test (default-test) @ takes ---

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.takes.http.BkTimeableTest
************* CLOSING THE FILE ***********************
[←[0;37mINFO←[m] pool-1-thread-2 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49436 /): [200 OK] in 2s
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.05 sec - in org.takes.http.BkTimeableTest
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

https://github.com/teamed/qulice/issues/691

@davvd it's done in PR #601, please assign reviewer.
Thanks.

@davvd it's done in PR #601, please assign reviewer.
Thanks.

@raphaelln OK, sure

@simonjenga PR #601 is merged. Please review and close the ticket if everything is ok.
Thanks.

@raphaelln I am reviewing it and I will close it shortly...

@raphaelln The fix has made this issue to disappear. I will open another issue if i come across similar problems related to creating temp files.
:thumbsup: :ok:

@davvd the issue was closed, please could you proceed.
thanks.

@davvd the issue was closed, could you proceed please.
thanks.

@raphaelln you are welcome

@davvd can you calculate this task?

@elenavolokhova please, review this task for compliance with our quality rules

@davvd Looks good!

@davvd Looks good!

@elenavolokhova thanks for the review

@raphaelln added 10 mins to @elenavolokhova, for QA review, payment code is 78665675
thanks, I just added 30 mins to your account, payment AP-09B27035W7591761S, 404 hours and 9 mins spent
+30 to your rating, your total score is +0


MBR and GPT Partitions

Adapted from lines 4764-5026 in winioctl.h.
Sorry if something is done wrong, I haven't dealt with much FFI and winapi stuff before.

Fixed the merge conflict, was missing a comma.

Is there anything else I should do to get this merged?


Add helper functions for getting Reports & Markers out of Diagnostics

Exposes some helper functions as discussed in #9.
@Mesabloo let me know if I need to add tests etc. They are simple functions, but maybe you want tests anyway? In the meantime I will try building my LSP using this branch.

Don't worry about testing those functions. They are small enough not to be tested (the whole codebase isn't properly tested anyways). :)
Most of the changes look good to me. I am just a bit hesitant about the markersOf function.
Doing so, we should also have one function per type of data which can be unpacked from the Report (one for the markers, one for the message, one for the notes, etc). With simple pattern synonyms, we should be able to have a very simple API (which would not leak the internal representation) such as, for example
pattern Warn, Err :: forall msg. Maybe msg -> msg -> [(Position, Marker msg)] -> [Note msg] -> Report msg
pattern Warn errCode msg reports notes = Report False errCode msg reports notes
pattern Err errCode msg reports notes = Report True errCode msg reports notes

Now, whenever we need some information, we can have it however we like it (either both the message and the reports, or also the note, and more importantly the fact that it is a warning/error).
Plus we didn't leak the private internal representation, as we can always apply a function to reports and notes to convert to the internal representation (in this case, those are already lists so it's just the identity).
I don't know if this piece of code works, but something along those lines should.
And we also get free pattern matching using case thanks to that. :D

@Mesabloo Yeah it works, but I had to change the implicit whole module export to an explicit one :man_shrugging:.
As a bonus, I could export the patterns as the only "constructors" for Report.
Code seems to build, but this is with default flags configured.
Tests seem to pass, but idk if a manual check needs to be done as well?

Yeah it works, but I had to change the implicit whole module export to an explicit one 🤷♂.

module Error.Diagnose.Report.Internal
  ( Marker (..)
  , Note (..)
  , Report(.., Warn, Err)
  , err
  , errorToWarning
  , warn
  , warningToError
  , FileMap
  , prettyReport
  ) where
  -- ...

You can also do module Error.Diagnose.Report.Internal (module Error.Diagnose.Report.Internal, Report (.., Warn, Err)) where (similar to what I did in the Error.Diagnose.Diagnostic.Internal module, see here).

Everything else looks good to me! 😄

Also, I believe I had references to both warn and err in the documentation for the module Error.Diagnose.
This may need to be fixed to.

Yeah it works, but I had to change the implicit whole module export to an explicit one man_shrugging.

module Error.Diagnose.Report.Internal
  ( Marker (..)
  , Note (..)
  , Report(.., Warn, Err)
  , err
  , errorToWarning
  , warn
  , warningToError
  , FileMap
  , prettyReport
  ) where
  -- ...

You can also do module Error.Diagnose.Report.Internal (module Error.Diagnose.Report.Internal, Report (.., Warn, Err)) where (similar to what I did in the Error.Diagnose.Diagnostic.Internal module, see here).
Everything else looks good to me! :smile:

Ah yes, much simpler. Thanks!

Also, I believe I had references to both warn and err in the documentation for the module Error.Diagnose. This may need to be fixed to.

Couldn't find any using grep? Maybe no references?

Couldn't find any using grep? Maybe no references?
Only there https://github.com/Mesabloo/diagnose/blob/f8badb4d8c11034c52cf7af6cec2879406cea4ed/src/Error/Diagnose.hs#L74-L92

And in the compatibility layers for (mega)parsec too  https://github.com/Mesabloo/diagnose/blob/f8badb4d8c11034c52cf7af6cec2879406cea4ed/src/Error/Diagnose/Compat/Parsec.hs#L50 https://github.com/Mesabloo/diagnose/blob/f8badb4d8c11034c52cf7af6cec2879406cea4ed/src/Error/Diagnose/Compat/Megaparsec.hs#L58
Apart from that, it should be everything that needs to be changed. :)

@Mesabloo Ok, my grep didn't cover everything. This should be everything now!
(I had already fixed the parsec related files.)

(I had already fixed the parsec related files.)

Ah sorry, I completely missed it!

This should be everything now!

Thank you very much for your contributions! I'm merging this now but I'll publish a new version to hackage later. In the meantime, you should be able to use the master branch. 😃

@luc-tielen Version 2.4.0 is live! :tada:


Update github build process to automatically generate experfwiz.zip when new release is made

Need to see if github automation can be used to generate the ExperfWiz.zip file.
Should contain everything in the repository except:
gitignore / git files

Implemented via Azure Pipeline


Phone number not showing in contact card until after re-login

Whenever a colleague has their phone number set in their Teams contact card, i can't see it unless i logout and login again. I believe the phone number comes from Active Directory. This looks like a synchronization issue in Teams.

This is probably related to https://github.com/MicrosoftDocs/msteams-docs/issues/1527.

@GabrielSandor, Thanks for reporting it. We have forwarded your feedback to the dev team.


Update documentation of configuration options

The documentation of the configuration options was extended and updated.
This resolves #71 for the most part.

I added tables here as well. To compare:

preview without tables
preview with tables

Command-line options can also be documented with ... wait for it ... Asciidoctor! ... which has special support for UNIX manual pages.
It is used by Git (e.g. git-clone) and by asciidoctor itself.
I used it to create the bitcoinj-cli man page -- source -- in bitcoinj-addons.

@msgilligan: please don't get me wrong, I'd really really like a rendered documentation, but I see it out of scope of the pending pull requests (mostly due to time/my current knowledge). I do think we should come to that point, but right now I have to decide whether to hold it back or merge, and I'm going with the latter, because "better is better" in my opinion.

Yeah, go ahead and merge.
I'm hoping to have time to help with rendered documentation sometime within the next month or so, but don't wait for me.

Okay, great. Thanks for your "blessing"! :)


Production build has different styling/layout than normal local build (Could be Material UI)

Is this a bug report?
No?

Did you try recovering your dependencies?
Yes

1.7.0
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

Environment:
OS:  OS X El Capitan 10.11.6
Node:  8.11.3
Yarn:  1.7.0
npm:  6.3.0
Watchman:  Not Found
Xcode:  Xcode 7.3.1 Build version 7D1014
Android Studio:  Not Found
Packages: (wanted => installed)
react: ^16.3.2 => 16.4.1
react-dom: ^16.3.2 => 16.4.1
react-scripts: 1.1.4 => 1.1.4
Steps to Reproduce

The main problem with the app is the different layout in the production version and the local version

Pull app from git
Run App locally by typing Yarn and then Yarn Start in the console
Yarn build webapp
Deploy app with a hosting site such as firebase and notice layout differences

Expected Behavior

I made a very stripped down version of my app with just a button
Locally it deploys and should run like this

Actual Behavior
After building it turns into this
https://testrun2-16fa8.firebaseapp.com/login
Notice the shift in layout.
Reproducible Demo

https://github.com/artalpade/stripped_down_problem
This is a pretty stripped down reproduction of my problem. I am absolutely lost as what I should do and would appreciate all help!

This is probably the issue.  You're telling CRA that the page is hosted at /SizzlDemo2.0 instead of the root. This then leads the url to the main.css file til look like this: /SizzlDemo2.0/static/css/main.c08e9487.css instead of /static/css/main.c08e9487.css which is where it's actuall located.

Found the answer I have to delete the line @skoging was talking about earlier, thank you!
resolved


Documented NLB for Kubernetes 1.9

This change is dependent on kubernetes/kubernetes#53400

This change is

ping @justinsb @bchav

@micahhausler FYI, the Travis CI error has been fixed. Please rebase or update the branch. Thx!

@micahhausler Can you resolve the merge conflict? Thanks.

Added note specifying Alpha status, link to supported instance types and IPv6 limitation.

@tengqm Is this LGTM?

@steveperry-53 @tengqm Bumping: is this Docs LGTM?

@micahhausler Do you need help finding a tech reviewer for this PR? Is there anyone you can suggest?

@justinsb can you take a look?

@arun-gupta Can you recommend anyone for a tech review?

@micahhausler Any luck finding a tech reviewer?
/cc @idvoretskyi

Not yet, I’ll prod some folks here at KubeCon to see if we can get in knocked out

@micahhausler Docs code freeze begins today at 7pm Pacific time. Without a complete tech review, this feature documentation will not be included in the 1.9 release. Please:

Find a technical reviewer.
Incorporate their feedback until they /lgtm.
Notify me by /cc with any updates.

/cc @enisoc @idvoretskyi

Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.

docs/concepts/services-networking/service.md, line 563 at r3 (raw file):

be proxied HTTP.

#### PROXY protocol support on AWS

Perhaps outside the scope of this change, but can be enabled manually by an operator, target groups with protocol TCP support proxy protocol version 2: http://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#proxy-protocol

docs/concepts/services-networking/service.md, line 595 at r3 (raw file):

forward the client's IP

The original PR only supported instance registration, but source IP is not preserved when the target group type is 'ip', see bottom of http://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-type

docs/concepts/services-networking/service.md, line 596 at r3 (raw file):

Unlike classic Elastic Load Balancers, Network Load Balancers (NLBs) forward the
client's IP through to the node. If a service's `spec.externalTrafficPolicy` is
set to `Cluster`, the client's IP address will not be propogated to the end

propagated

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.

docs/concepts/services-networking/service.md, line 563 at r3 (raw file):
Previously, andrewtandoc wrote…
Perhaps outside the scope of this change, but can be enabled manually by an operator, target groups with protocol TCP support proxy protocol version 2: http://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#proxy-protocol

Yea, we'll keep this PR just scoped to NLB

docs/concepts/services-networking/service.md, line 595 at r3 (raw file):
Previously, andrewtandoc wrote…

forward the client's IP

The original PR only supported instance registration, but source IP is not preserved when the target group type is 'ip', see bottom of http://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-type

Correct. I'm planning on adding ip registration at a later date, and will update the docs accordingly then.

Comments from Reviewable

@andrewtandoc Addressed spelling issues can you comment on this PR
/lgtm
```?

/lgtm

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.

docs/concepts/services-networking/service.md, line 563 at r3 (raw file):
Previously, micahhausler (Micah Hausler) wrote…
Yea, we'll keep this PR just scoped to NLB

TCP target groups are implicitly NLB

Comments from Reviewable

@zacharysarah Should be good to go


Failed installing Directus: Error: Command failed: cd server && npm run cli bootstrap

Windows 11
Running the installer fails with:
Failed installing Directus: Error: Command failed: cd server && npm run cli bootstrap

Happy to provide any additional information.

There are two commands there cd server and npm run cli bootstrap.
Run the first one in your terminal inside of C:\Projects\nuxtus. I'm guessing it will fail there because as a Windows user, you do not have cd which is a Linux terminal command for 'Change Directory'. Unless you are running WSL? in which case cd will run, if it does run successfully, run the second command.

Thanks for the quick reply.   The cd command does work fine on Windows, but it the command is running in the nuxtus directory, where I initiated the create command,  and the server directory is actually a folder deeper inside the created app directory.

If I manually move to that directory and run:
npm run cli bootstrap
It fails with a sqllite error.

This may be a windows issue if it has not been tested on windows.  Just thought I would let you know.  I will try and spin it up in WSL.  Thanks!

Unfortunately, I don't have access to a Windows machine to test on but it seems to me the root cause is that the create script hasn't correctly identified the current working directory.
I'll see if I can try this on a windows machine. But please update this ticket and let me know if WSL works.

Got Windows 11 in a virtual desktop to test this. Thanks for reporting.
I just tried running npx create-nuxtus test-app  in Windows Command Prompt and everything installed okay.
I then tried in Windows Powershell and got the same result.

I haven't used a Windows machine regularly for over 20 years so there might be something I'm missing, but the install script seems to work okay.
Node v16.17.0
Npm v8.15.0
Perhaps you could try updating Node version and re-run the installer?
I'll leave this ticket open for a few days and hope to hear back on how you went.

That super interesting.  I just spun up a Windows 11 VM and installed node.  It failed again with the same error.  I am using the same versions of Nodejs and NPM as you did.

After that failed, I got thinking it might be a path issue.  I moved it up a directory and ran it.  That passed.  I suspect an issue with using "nuxtus" in the path?  Thanks again for digging in.

Here I used a string that does contain nuxtus.

Here is one that does not contain nuxtus, but does nuxt.

Here is one that has non nuxt containing string.

Hope this is helpful.  It appears to be the string "nuxt".

Thank you for the updated information - this is very helpful! I'll look into it again in regards to the nuxt text in the directory and get back to you.

It gets even weirder! I just tried the same combination of directories you did and everything worked for me!
Can you do me a favour and confirm if the sqlite database file is created in the successful vs failed installs and also check the server/.env file and send me the path of the sqlite database from that file?

Directory contents:

.env contents:

I think you are on to something.  The paths in the files look correct, but the sqlite file is missing in the path that contains the string nuxt.  Are you using the same casing?  I am at a loss at the moment.  It does work great otherwise, so I just wanted to say thanks for the cool project.

Thanks for the kind words on the project, I'm glad you like it. I'm still at a loss as to why "nuxt" related folders don't work but I'm wondering if it is some form of permission issue. I'm working on another feature at the moment and will pop a couple of forced permission changes to the server folder and see if that helps you.
In the meantime, is the data.db file anywhere else in the directory structure? (Perhaps a folder up or something)?

Im a windows user, currently im busy but after my appointment I can try to reproduce this. @craigharman

That would be great thanks @Intevel! Appreciate any help narrowing this down.

@craigharman Sorry, I can't reproduce this.
@slaanish Which Windows Build do you use?

Wasn't able to reproduce this and no response in 2 months so I am going to close.


Make bandit work with clang++

This commit removes all errors when compiled with clang++ 3.6

Not sure why the CI build is broken.

It's broken because CMake 2.8.12 or higher is required and you are running version 2.8.7

I'm looking at adding a script for updating cmake in travis as described in here: https://gist.github.com/winterz/10cc2741d466cbd8ff21

I'm also looking at fixing a few errors this PR introduced for older compiler versions. Nothing major.

There is an open issue for the problem in travis here travis-ci/travis-ci#2030
It's the updated version of cotire that requires cmake 2.8.12

I have cmake 3.0.2 in my box. Not sure if this is truly the case.
On Fri, Jul 24, 2015 at 2:38 AM, Joakim Karlsson<EMAIL_ADDRESS>wrote:

There is an open issue for the problem in travis here
travis-ci/travis-ci#2030
https://github.com/travis-ci/travis-ci/issues/2030
It's the updated version of cotire that requires cmake 2.8.12
—
Reply to this email directly or view it on GitHub
https://github.com/joakimkarlsson/bandit/pull/58#issuecomment-124456549.

The cmake version issue is not on your box. It's on the travis machine where bandit is built at each push.

I couldn't get travis to use a higher version than 2.8.11. I reverted cotire to 1.6.9. to loosen the version requirement. It builds on travis now.

@joakimkarlsson You can install (newest) CMake manually

I got it working. Turns out we did have a fix for this that I accidentally removed. We're back to cotire 1.7.2


service.bat - fix quotes around domain BASE path

This was causing an extra pair of double quotes to appear in the call to wildfly-service.exe, breaking the installation for domain mode.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

this is ok to test

@ctomc please approve


SplunkBase installation instructions don't match the tarball provided

The SplunkBase page for eventgen points to the documentation directory in this repository, which recommends running setup.py and setting the app up as a Pip package.
However, the tarball I downloaded from the SplunkBase site didn't include any setup.py file.
Please either provide instructions on the SplunkBase Details page on how to use the tarball provided, or change the structure of the tarball distribution to match existing documentation.
The setup instructions talk about installing a tar.gz file with pip, so I tried that with the tarball downloaded. Running pip install eventgen-621.tar.gz returned the following error, reflecting that there is no setup.py file in the tarball file:
pip install eventgen_621.tgz
Processing ./eventgen_621.tgz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/anaconda3/lib/python3.6/tokenize.py", line 452, in open
        buffer = _builtin_open(filename, 'rb')
    FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/9b/09zm299n2137b28vmlh98x7r0000gn/T/pip-req-build-15cj2tk7/setup.py'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/9b/09zm299n2137b28vmlh98x7r0000gn/T/pip-req-build-15cj2tk7/

Eventgen is currently using python 2.7, we currently do not support python 3.

Thanks @lephino - I also tried the pip instal with pip2 on my system and received the same error. My problem is more about finding instructions for installing the tarball provided on SplunkBase.
This issue is about the documentation provided in the Splunk App page on SplunkBase, which points to the documentation in this repository, even though they have different installation processes.
I just found a related issue at #76 with comments differentiating between the Splunk App distribution and the developer instructions in this repo, I'll continue reading through them for an answer.

The spl on splunkbase just needs to be installed directly into splunk.  You simply go in to your splunk frontend, choose install from file on the app management pane and select the eventgen download.

@lephino ha, that's much simpler than it seemed from the instructions! Thanks for the very quick help. I hope the complicated instructions on the SplunkBase page can be updated to prevent future confusion :)

lol yeah I'll see about getting those fixed.  The pip install is a reference to this actual repo, and for installing eventgen from this source repo


Feature: Added Error Handling in Addons, Database components of Controlpanel [2]

See: #1898
Reopening PR as instructed in #3150 by @sneridagh

Created a new PR as the feature branch code become outdated.


Evaluate header canonization in request

#553 by @alessiodallapiazza removed the header canonization in the proxy response, applied by default by the Go standard library.
We should also evaluate if it's possible to do the same for requests and allow the proxy user to specify its own custom headers, when needed.

In https://github.com/elazarl/goproxy/issues/510 there is a complain that involves it about the header name change from APP_Key to App_key, maybe it's related to this one

We're using http.ReadRequest() to read the request data, but it convert the header names to the canonical form.
We need to evaluate if we have to rewrite this function (ugly hack).

https://github.com/golang/go/issues/37834

Possible approach:

We call http.ReadRequest() to parse the basic information
After its call, we make a copy of the data it read and parse them manually to obtain a copy of the original headers (just he headers!)
For each header, we canonicalize them and check if the result is a different key
If the key is different, we delete the value in the headers map and we use the original key instead


Collect examples for the relation without Distant supervision

Now i want to extract some relations,but i can not find that relations from any databases.So we can write applications without training data for relations(without Distant supervision)?

Absolutely! This may require some conversation about how to do it properly... but in our human trafficking applications there are essentially no databases and distant supervision works well...
one way to think about it is to write some (low quality) simple rules as distant supervision. for example, we had lots of collisions about which location (is it concord CA? TX?) -- but we heuristically used phone number to grab those which were less ambiguous.
Since I don't know the domain, I can't generate these rules... but this would be fun to meet about...
@ajratner @netj would love to have that elastic search regular expression integration... then as they search for rules we could data program :)

If we don`t have any positive and negative examples,how to learn the weight of a factor???we can generate a constant or depend on some variables for it,but if we have some negative candidates for a relation,i am not sure that deepdive can give small weights automatically for them without examples

Roughly, the game works like this:

You heuristically generate many different kinds of low quality examples.  They labels you generate will be noisy--this is OK. It's a little disturbing from a classical ML perspective but fine from a stat/optimization perspective.

Now, the game is to get some redundancy in the labels so that you can "denoise the labels" Also, if there is structure between the label sets, you can even denoise to an even greater extent.

Of course, you may choose to label some data or to fix some rules, but engineering-wise it's hopefully easier... we have some theory that gives situations in which noise from many crappy rules is enough to learn to essentially perfect accuracy.

But, it's mostly in latex, and we need more experience... hence my excitement :)
We're building tools to support this type of extreme distant supervision... @zhangce @ajratner @netj @thodrek  COULD BE FUN!!

@chrismre When do you complete your tools?:))

I don't know... :) @netj

@astrung the "data programming" process that @chrismre is not embodied in https://github.com/HazyResearch/snorkel


Updated badge order and format

This PR implements #4

Now support is provided via <ask.fiware.org>


'null' Values Causing Issues with .csv File Import In Snowflake With non-VARCHAR Datatype

Describe the bug
When creating external tables pointing to .csv files in Snowflake, trying to type certain columns as non-VARCHAR datatypes, (e.g. INT/NUMBER) when there are NULL values present in the source causes this error when trying to query the external table (not on external table creation, just querying): "Failed to cast variant value "null" to FIXED"
Steps to reproduce

Put a csv file in S3 where some columns have NULL values and these same columns should be non-VARCHAR datatypes, e.g. INT
Create a .yml file which follows dbt_external_table syntax and type appropriately. Example:

version: 2

sources:
  - name: PEOPLESOFT_ORACLE_ARCHIVE
    database: RAW_DEV
    loader: s3

    tables:
      - name: ps_tcf_vista_f_metadata

        external:
          location<EMAIL_ADDRESS>          file_format: "RAW_DEV.peoplesoft_oracle_archive.PS_TCF_VISTA_F_METADATA_FMT"
          auto_refresh: true

        columns:
          - name: COLUMN_ID
            data_type: INT

          - name: SCHEMA_NAME
            data_type: VARCHAR

          - name: TABLE_NAME
            data_type: VARCHAR

          - name: COLUMN_NAME
            data_type: VARCHAR

          - name: DATA_TYPE
            data_type: VARCHAR

          - name: DATA_LENGTH
            data_type: INT

          - name: DATA_PRECISION
            data_type: INT

          - name: DATA_SCALE
            data_type: INT

          - name: NULLABLE
            data_type: VARCHAR

Run dbt run-operation stage_external_sources --vars 'ext_full_refresh: true'
SELECT * from the created table and get the error message: "Failed to cast variant value "null" to FIXED"
The columns in question causing the issue are DATA_PRECISION and DATA_SCALE, which have NULLs. No amount of tweaking the associated file format to ensure that incoming NULLs are properly processed handles the issue, and when directly querying the stage in question, the NULLs look like they are coming through correctly. Setting DATA_PRECISION and DATA_SCALE to VARCHAR makes the issue go away, but then the data isn't typed correctly.

Expected results

The external table should come back properly and cleanly with correct datatypes and with nulls handled properly.

Actual results

SELECT * from the created table and get the error message: "Failed to cast variant value "null" to FIXED"

Screenshots and log output

System information
packages:
 - package: fishtown-analytics/dbt_utils
   version: 0.6.3
 - package: fishtown-analytics/dbt_external_tables
   version: 0.6.0

Which database are you using dbt with?

[ ] redshift
[ X] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
installed version: 0.18.1
   latest version: 0.18.1

Up to date!

Plugins:
  - bigquery: 0.18.1
  - snowflake: 0.18.1
  - redshift: 0.18.1
  - postgres: 0.18.1

The operating system you're using:
Mac OS Big Sur 11.1
The output of python --version:
Python 2.7.16
Additional context
I think this has to do with normal "SQL" Nulls versus variant/JSON nulls. Intercepting the external table creation statements in the Snowflake query history, this external table creation statement, when later queried, shows issues:
create or replace external table RAW_DEV.PEOPLESOFT_ORACLE_ARCHIVE.ps_tcf_vista_f_metadata(
            COLUMN_ID INT as (nullif(value:c1,'')::INT),
            SCHEMA_NAME VARCHAR as (nullif(value:c2,'')::VARCHAR),
            TABLE_NAME VARCHAR as (nullif(value:c3,'')::VARCHAR),
            COLUMN_NAME VARCHAR as (nullif(value:c4,'')::VARCHAR),
            DATA_TYPE VARCHAR as (nullif(value:c5,'')::VARCHAR),
            DATA_LENGTH INT as (nullif(value:c6,'')::INT),
            DATA_PRECISION VARCHAR as (nullif(value:c7,'')::VARCHAR),
            DATA_SCALE VARCHAR as (nullif(value:c8,'')::VARCHAR),
            NULLABLE VARCHAR as (nullif(value:c9,'')::VARCHAR)
    )
    location = @raw_dev.peoplesoft_oracle_archive.ps_tcf_vista_f_metadata_stg
    auto_refresh = True
    file_format = RAW_DEV.peoplesoft_oracle_archive.PS_TCF_VISTA_F_METADATA_FMT

But this (manually edited) statement is successful:
            COLUMN_ID INT as (nullif(value:c1,'')::INT),
            SCHEMA_NAME VARCHAR as (nullif(value:c2,'')::VARCHAR),
            TABLE_NAME VARCHAR as (nullif(value:c3,'')::VARCHAR),
            COLUMN_NAME VARCHAR as (nullif(value:c4,'')::VARCHAR),
            DATA_TYPE VARCHAR as (nullif(value:c5,'')::VARCHAR),
            DATA_LENGTH INT as (nullif(value:c6,'')::INT),
            DATA_PRECISION INT as (nullif(nullif(value:c7,''),'null')::INT),
            DATA_SCALE INT as (nullif(nullif(value:c8,''),'null')::INT),
            NULLABLE VARCHAR as (nullif(value:c9,'')::VARCHAR)
    )
    location = @raw_dev.peoplesoft_oracle_archive.ps_tcf_vista_f_metadata_stg
    auto_refresh = True
    file_format = RAW_DEV.peoplesoft_oracle_archive.PS_TCF_VISTA_F_METADATA_FMT;

Note the additional nested nullif statements on columns 7 and 8, respectively, DATA_PRECISION and DATA_SCALE.

Thanks for the bug report @codigo-ergo-sum!
I think the simplest approach is to replace the nullif([column] , '') below:
https://github.com/fishtown-analytics/dbt-external-tables/blob/8ce844e7993b165322f46bb68718b0a84c6ca86a/macros/plugins/snowflake/create_external_table.sql#L19-L20
With something a bit more thorough that (a) leverages Snowflake's IS_NULL_VALUE function (docs) and (b) checks for strings that look like 'null':
(case when is_null_value([column]) or lower([column]) = 'null' then null else ... end)

Thanks for the bug report @codigo-ergo-sum!
I think the simplest approach is to replace the nullif([column] , '') below:
https://github.com/fishtown-analytics/dbt-external-tables/blob/8ce844e7993b165322f46bb68718b0a84c6ca86a/macros/plugins/snowflake/create_external_table.sql#L19-L20
With something a bit more thorough that (a) leverages Snowflake's IS_NULL_VALUE function (docs) and (b) checks for strings that look like 'null':
(case when is_null_value([column]) or lower([column]) = 'null' then null else ... end)


fix bgp_default_policies_test.go

fix bgp_default_policies_test.go for Cisco, Arista, Nokia.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


Update bloop-config to 1.5.4

Updates ch.epfl.scala:bloop-config from 1.5.3 to 1.5.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "bloop-config" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "ch.epfl.scala", artifactId = "bloop-config" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Binary incompatible version

Superseded by #2135.


Kubectl download failed

Hello,
I was trying taskcat with the --no-delete option and I saw that tap wasn't installed. Looking at the logs i get:

aws s3 cp --no-progress s3://amazon-eks/1.23.7/2022-06-29/bin/linux/amd64/kubectl ./kubectl
download failed: s3://amazon-eks/1.23.7/2022-06-29/bin/linux/amd64/kubectl to ./kubectl An error occurred (IllegalLocationConstraintException) when calling the GetObject operation: The us-west-2 location constraint is incompatible for the region specific endpoint this request was sent to.

I'm trying to setup it in eu-south-1 region.
I'm sure I already setup TAP in this region with the old template not using taskcat
regards

@satya-dillikar and/or @spagno Are you able to duplicate if you set the region to us-west-2 with the --region parameter on Lines 1380-1381? All of the other awscli s3 cp calls in the user-data script use buckets local to that region, so they shouldn't need to be updated. Also, this hasn't been necessary in other regions in previous testing (including GovCloud).
Alternatively, try updating this to a wget or curl statement to download the file over the internet (example) instead of over a VPC gateway S3 endpoint. My intent with this implementation was to minimize billable outbound internet calls, but the data transfer required for this file is trivial.
If either fixes it, send over a PR.

@spagno , I was able to change the region in .taskcat.yml and were able to successfully upload and test  in us-west and us-east regions.
Try changing the region in .taskcat.yml and let us know your findings as Troy suggested.
Thanks
Satya

Hi,
I'm getting the same problem trying installing tap in eu-south-1 region. How can I fix this?
Thanks
matteo

@matteowiz is the region set to eu-south-1 in your .taskcat.yml file?

Or are you deploying via the CloudFormation management console link (reference)? Or something else?

@leclaist ,
Yes, you can update the region as eu-south-1 in your .taskcat file or manually deploy it in the eu-south-1 region.
The fix is to

replace cloud-init.sh:
line: aws s3 cp --no-progress "s3://amazon-eks/${AwsKubectlVersion}/bin/linux/$arch/kubectl" ./kubectl
with
curl -O https://s3.us-west-2.amazonaws.com/amazon-eks/1.24.10/2023-01-30/bin/linux/amd64/kubectl
[Note: parameterize correct version and arch]
and

test in the eu-south-1 region.

HTH
Satya

@leclaist Yes I'm using the CloudFormation Management Console.
How can I edit this script? Do I have to import all the files into a personal bucket and run from there?
Thanks
matteo

@matteowiz Minor misunderstanding on our end. You don't need to, but if you want, you can add the eu-south-1 region to one of the tests in the ./.taskcat.yml config file and deploy via taskcat. This tool is primarily intended for maintainers, contributors, and CI/CD though. Thank you for your feedback and confirming your deployment method. @leclaist is working on duplicating the issue. Thanks!

This has been adressed here. We are also running the internal CI against eu-south-1 (amongst other regions) and don't see issues re. the kubectl download anymore. So I think we are good to close this.
@tlindsay42


issue on treemap

Hello,
i tried to use treemap but unfortunately it gives me error#17
each time
I included highcharts, highcharts-more and highstock in my app module like this:
export function highchartsFactory() {        var hc = require('highcharts');      var hs = require('highcharts/highstock');      var hcm = require('highcharts/highcharts-more');      var ex = require('highcharts/modules/exporting');      var hm = require('highcharts/modules/heatmap');      var sg = require('highcharts/modules/solid-gauge');      hs(hc);      hcm(hc);      ex(hc);      hm(hc);      sg(hc);      return hc; } providers: [{         provide: HighchartsStatic,         useFactory: highchartsFactory     }
and then used the example lie this:
` this.treeMapOptions = {
colorAxis: {
minColor: '#FFFFFF',
maxColor: '#999'
},
series: [{
type: 'treemap',
layoutAlgorithm: 'squarified',
data: [{
name: 'A',
value: 6,
colorValue: 'red'
}, {
name: 'B',
value: 6,
color: 'yellow'
}, {
name: 'C',
value: 4,
color: 'green'
}, {
name: 'D',
value: 3,
color: 'blue'
}, {
name: 'E',
value: 2,
colorValue: 5
}, {
name: 'F',
value: 2,
colorValue: 6
}, {
name: 'G',
value: 1,
colorValue: 7 }]
}],
title: {
text: 'Highcharts Treemap'
}
};
<chart  [options]="treeMapOptions">   `
but it keeps gives me the #17 error in the console

is there any solution for this!?
thanks

did you get it working?

yes, I just registered it like this in the my module:
`import { ChartModule } from 'angular2-highcharts';
import { HighchartsStatic } from 'angular2-highcharts/dist/HighchartsService';
export function highchartsFactory() {
var hc = require('highcharts');
var hcm = require('highcharts/highcharts-more');
var hr = require('highcharts/modules/treemap');
 hcm(hc);
 hr(hc);
 return hc;

}
@NgModule({
providers: [{
provide: HighchartsStatic,
useFactory: highchartsFactory
}]
})
`
and it's now working fine

unfortunately no, but I can help you if there's a problem

Thanks for offering me your help, I actually need your help on bringing highcharts in a non-angular-cli project via node-modules with import module. I cannot achieve it.
Can you help me with that?
link to the project:
angular-highcharts-treemap

This issue should be reopened. Because it does not support pure angular2/4 support. We have to add JS files to index.html to get it working, looks like a temporary fix.
https://github.com/Janatbek/angular-highcharts-treemap/blob/master/src/index.html
Can anyone get the pure angular2/4 support for Tree map?


Output filename different than input

Would it be possible to specify a different output file than the source file? For example, my project requires specifying a main.css file, along with a minified version, main.min.css.
gulp.task('minifycss', function() {
    gulp.src('./dist/assets/css/main.css')
        .pipe(minifycss())
        .pipe(gulp.dest('./dist/assets/css/main.min.css'));
});

Obviously the above doesn't work — it just creates a folder called main.min.css then puts the output file inside, but something like the above would be great.
Cheers,
Mark

This really should be built-in functionality...

No, it shoudl not, use gulp-rename.


Feat: Update to Cider 2 via Themekit

Updated the theme for use in Cider 2. #1.
Updated documentation for updated theme.
Updated to use Whiskers and Cider-Themekit.

Hello again,
Done both! Thank you for your time.

Thanks again for taking the time to work on this port and update it! Will give you maintain permissions after merging this repository :saluting_face:


Limit of saved tabs in 1200

After ~1200 tabs, my extension always with Chrome close, lost 100+ tabs.

For more it's about 2000 tabs. After which I completely lose everything upon restart (the sidewise window is empty), which forces me to back up my sessions just to be sure I can at least go back to a session that had less than 2000 tabs. Complicated, but hey, the alternative is no Sidewise at all... :)

When this guy is make the project open source for we help build and fix issues like this?

Well it's not open source, but you can always view the source code... Just find the proper folder in your Chrome profile, then you'll have access to all the JS files. You can prettify them (and make them readable) with plenty of web tools. Then you can mod them. Personally, I've modded the window manager to increase the width so that the scrollbar is partly outside the screen (giving me a few more px of screen estate, among other advantages.)

The data corruption issues surrounding having several thousand tabs should now be fixed. Sidewise should now be able to store an essentially unlimited number of tabs. It is now using chrome.storage.local for storing the tree data, which has no maximum storage limit.
Please let me know if you see any further issues of this type.

OK! Thanks very much!!!


[Feature Request]: Support for inferring schemas from Python dataclasses

What would you like to happen?
We should be able to infer a schema from a Python dataclass. Blocked by #22082
Issue Priority
Priority: 2
Issue Component
Component: sdk-py-core

@TheNeuralBit Issue closed as stale - is the work actually completed here?


libdsp: improvements for lib_observer.c

Summary
The main motivation of these changes is to improve modularity and enable various combinations of the motor controller logic.

libdsp/lib_observer.c: separate angle observer from speed observer
They can be used completely independently, so they should'n be coupled.
For example, a sensored motor controller in speed control mode doesn't need an angle estimator.

libdsp/lib_observer.c: update some comments
The angle observer always refer to a motor electrical angle,
while the speed observer can be applied to a motor electrical speed or a motor mechanical speed.

libdsp/lib_observer.c: remove dir argument from motor_sobserver_div as we can automatically detect the direction of movement

Impact
Breaking change for code that uses previous observer interfaces.
Not used yet in NuttX repositories.
Testing

Sorry @raiden00pl I think missed to merge this PR before merging #5479

NP. Conflicts solved

@pkarashchenko thx for review. done

LGTM!
But seems that CI fails because of some Beta feature "Unchanged files with check annotations"

This is because this patch doesn't rebase the latest mainline, and CI by default check all change from your base to latest mainline plus the new change.
Anyway, let's ignore the false alarm and merge this PR.


EBSCO ebooks need to be indexed

EBSCO ebooks are now part of OCLC's Collection Manager product!  See https://www.oclc.org/content/dam/support/worldshare/EBSCO_CM_quick_start.pdf


Prune old history

The option to prune old history items that are no longer needed. Currently once a file is no longer needed it is expired, and the history shows expired. Holding expired job history for too long may not be beneficial. The option to add a lifecycle to delete this too could help keep the history clean. E.g. remove record after X of inactivity.

It may be more appropriate to not prune the records but instead suppress them in the front-end. This would allow for metrics, such as "total translations", "top languages", "top document types". This can be useful for showing the value of this project with metrics in addition to anecdotally.
This would also be simpler to apply by filtering the results returned to the front-end React to exclude anything with "expired" that is older than "X" days.


Create CONTRIBUTING.md

I have made a CONTRIBUTING.md file. Please send any feedback if needed.

@AvidCoder101 don't merge this PR, will add changes within this PR by myself.

I still needed someone to check it for me first anyway, in case I needed something changing.

@AvidCoder101 I push all changes within your PR.

@AvidCoder101 can you please remove your last commit it is not looking good.

Sorry, just saw that you had changed it. I fixed it back.

@AvidCoder101 remove your two last commits and then git push.

@MRslimcoder I've just changed it back. Is that ok?

LGTM


Binary Search

Implemented iterative binary search algorithm in all the three languages. I do not know python, so had to use the code converter. Also wrote a decent explanation of how time complexity is calculated for it in the readme file.

@imsuraj675 Done bhaiya. Do I have to update the pull request?

Good work


Uncaught TypeError: Super expression must either be null or a function, not object

when using the extends and HTMLCustomElement method i get an error
of
Uncaught TypeError: Super expression must either be null or a function, not object

nevermind.. it was my mistake not exporting the class


Logs in My Games\Skyrim.INI\SKSE instead of My Games\Skyrim Special Edition\SKSE

Since the last skse64_1_6_1170 log files of the plugins are put in the directory My Games\Skyrim.INI\SKSE instead of My Games\Skyrim Special Edition\SKSE. I've try with latest CommonLibSSE-NG 3.7.0, same. Also I use a template: https://github.com/SkyrimDev/HelloWorld-using-CommonLibSSE-NG
I use this function to log, quite a famous function:
void SetupLog() {
    auto logsFolder = SKSE::log::log_directory();
    if (!logsFolder) {
        SKSE::stl::report_and_fail("SKSE log_directory not provided, logs disabled.");
        return;
    }

    auto logFilePath = *logsFolder / std::format("{}.log", Plugin::NAME);
    auto fileLoggerPtr = std::make_shared<spdlog::sinks::basic_file_sink_mt>(logFilePath.string(), true);
    auto loggerPtr = std::make_shared<spdlog::logger>("log", std::move(fileLoggerPtr));
    spdlog::set_default_logger(std::move(loggerPtr));
    spdlog::set_level(spdlog::level::trace);
    spdlog::flush_on(spdlog::level::info);
}

I guess I should indicate somewhere to use the latest SKSE, it's my first SKSE plugin, any help is welcome. Also there's lot of SKSE plugins that have this issue now.

I have this problem too. It only happens on AE, if I use SE to load my plugin It will be in the right place


Update font list to those on Debian Jessie

The order has also been updated to that of OpenStreetMap Carto reflecting work better understanding fallbacks.

On hold - maps-test2004 is going to stretch, so I can use that list, which is much better

I've changed the PR to be the Stretch font list.


Typos

Fix "expresssions" -> "expressions"

Fixed in the last PR #249

Fixed in the last PR #249


mix and match the props/options in different months.

Hi,
we want  mix and match the props/options in different months.  We have accommodations that have in the summer months Ranges of 7, 10 or 14 days and checkin only on saturdays and in the spring they have  minimum 3 nights and checkin all days.
Is this possible ?
best...remco

Hi @remcoz ,
I don't this that's possible out of the box, and while this would be a relevant feature, it is not trivial to implement.
What could be done more easily is either emit events when changing month visibility, or bind a model to the current month(s) visible.
Anyway it's not something that can be done right now but I'm tagging it as it's definitely an interesting use case.
We'll let you know when adding a feature that could help you in this use case.
Cheers

I do was thinking in implement a better events emit, because today in v4 still there are some limitations.

I do was thinking in implement a better events emit, because today in v4 still there are some limitations.

Well that's great, as you say, the events are pretty limited for now. This could allow working around some custom behaviors, and leave some room to discuss more complex changes like the one @remcoz needs - I may need this kind of feature for one of my clients sooner or later, so maybe I'll work on it when v4 has been released.

I was thinking on v5 with Vue v3 compatibility.
Some rewriting has to be done to better control some events.

@matiasperrone I added a v4.x milestone for stuff that could make it during v4 but maybe won't. But I think this should be splitted in two issues:

One for the events, v4.x or v5 as you say
One for customizing props depending on the month, without any milestone.

I am going to close this. next-month-rendered event maybe it'll be helpful.
Check the new v4.1 version.

I am going to close this. next-month-rendered event maybe it'll be helpful.
Check the new v4.1 version.


Where is CUDA 9.0 version ?

Where is CUDA 9.0 version ?

I'm also having problems with getting this library to work with CUDA 9.1. Getting "OSError: libnvrtc.so: cannot open shared object file: No such file or directory"

I have added the support for nvrtc 9.0, 9.1, and 9.2.
They are also available through pip.


Remove console output

We can revisit this after I finished porting all libraries to bower.

Conflict, can you recheck again?


Cleanup code

Some suggestions for code improvements:

[ ] Remove dead code: Instead of commenting out code, it should be removed. If needed, we can still recover it from the git commit history
[ ] Remove console.log statements. It's ok to use them for debugging, but they must be removed before each commit.

Both tasks have been done, with the exception of the ACL entry deletion code, that is left there as commented, because it works but produces permission issues as a side effect. When deleting all data from a file in a Solid pod (through a SPARQL query), the empty file is left in place. The CSS reports that file as being there, so Comunica attempts to fetch it, and removing the ACL entry produces an error when doing that.
I think the files themselves should probably somehow be deleted when all their contents are removed, but it is beyond the scope of this issue, maybe? :thinking:


Feature Request: Save Code Folding

It's been months on this ticket https://discuss.atom.io/t/save-code-folding/17793/4
I'm wondering if this is something this plugin can solve. Save the state of code folding with a project?  I can probably build this as a PR maybe but I haven't dealt with ATOM before so maybe if you run off the top of your head how you would do this that would save me hours of unknown research.
Thanks!

The project manager in it's current state doesn't have anything in it that would help with implementing this and I can't really think of a way to do this.
There is an issue up on the Atom repository for this https://github.com/atom/atom/issues/8764, but not much action there either though :(

@danielbrodin Don't you have a place to save the state of the project? What tabs were open, etc. I was thinking that would be a good place to save the state of the folded coded in those files. At first in the open tabs and then of course in closed files through the life of editing that project.

That was something that was going to be added because of keeping track of open tabs etc... but that was implemented directly in Atom so there have been no need to save the projects state. I'm all up for adding such a thing though if someone implements it.

@mehcode so nice. Beautiful. Thank you!


blastdbcmd: BLAST Database error: No alias or index file found for nucleotide database

Expected Behavior
I want to create seqTaxDB with the downloaded nt database
Current Behavior
While augmenting the database with taxonomic information there's an error with BLAST+'s blastdbcmd
Steps to Reproduce (for bugs)
These steps go well:
wget ftp://ftp.ncbi.nlm.nih.gov/pub/taxonomy/taxdump.tar.gz
mkdir taxonomy && tar -xxvf taxdump.tar.gz -C taxonomy

The next command
blastdbcmd -db nt -entry all > nt.fna
returns an error
BLAST Database error: No alias or index file found for nucleotide database [/scratch/users/pnovikova/refinement/taxonomy/mmseqs2/NT/nt] in search path [/mnt/lscratch/users/pnovikova/refinement/taxonomy/mmseqs2/NT:/mnt/lscratch/users/pnovikova/refinement/taxonomy/mmseqs2/NT:]
Context
Providing context helps us come up with a solution and improve our documentation for the future.
blastdbcmd: 2.11.0+
Package: blast 2.11.0, build Oct  6 2020 03:24:05
Your Environment
Include as many relevant details about the environment you experienced the bug in.

Which MMseqs version was used (Statically-compiled, self-compiled, Homebrew, etc.): bioconda, MMseqs2 Version: 12.113e3

I think you have to download the NT first and create a blast database with makeblastdb and then you can theoretically use blastdbcmd for the remaining commands.
However, I am not sure if the procedure described in the wiki still works with NCBI's recent change to the V5 database format. As far as I remember, it shouldn't work anymore.

Was this issue ever resolved? I am getting the same error trying to build a database using blastdbcmd with NCBI nt.


Improve README

Once the setup is sorted (i.e. command line vs gui), update the readme to tell the user how to use the package

Updated readme with background info about the pharmacokinetic models.
Clarified input parameters for modelling.
GUI not yet finished so I've put instructions on how to run the model in the Terminal.


[vcpkg_check_features] Set output variable explicitly and allow reverse-logic check

The aim of these PR is to make the following changes to vcpkg_check_features():

Require an output variable to be explicitly set
The current implementation silently sets the variable FEATURE_OPTIONS, this breaks the pattern used in other functions like vcpkg_from_github() or vcpkg_extract_source_archive_ex(), where out variables are set explicitly. A new parameter OUT_FEATURE_OPTIONS is added to replace the FEATURE_OPTIONS variable.

Do not create variables for each feature
Stop creating output variables for each feature, this makes it so that OUT_FEATURE_OPTIONS is the only output variable produced by this function.

Allow inverted-logic features.
Allow features that have opt-out behavior in their build-systems, e.g.:  cpprestsdk[websockets,brotli], to use vcpkg_check_features() with inverted logic.

In order to accommodate these changes the usage of the function has been changed to:
vcpkg_check_features(
  OUT_FEATURE_OPTIONS <output_variable>
  [FEATURES]
    <feature1> <option_name1>
    [<feature2> <option_name2>
     ...]
  [INVERTED_FEATURES
    <feature3> <option_name3>
    [<feature4> <option_name4>]
     ...]
)

Ports already using vcpkg_check_features() need to be updated to follow this new usage:

[x] czmq
[x] darknet
[x] librdkafka
[x] mimalloc
[x] mongo-c-driver
[x] oniguruma
[x] paho-mqttpp3
[x] pcl
[x] xsimd
[x] xtensor
[x] zeromq

Is there a simple reason why <uppercasefeature>_ENABLED and <uppercasefeature>_DISABLED are not simply passed by vcpkg to cmake? VCPKG probably has something in place to generate the FEATURES list and knows about all available features. Having to write it out in another function is just duplication of information.
see build.cpp line 411 and 412. E.g. FEATURES and ALL_FEATURES.
So in CMake it could simply defined as:
foreach(feature ${ALL_FEATURES})
 string(TOUPPER "${feature}" upfeat)
 if(${feature} IN LIST ${FEATURES})
   set(${upfeat}_ENABLED 1)
   set(${upfeat}_DISABLED 0)
 else()
   set(${upfeat}_ENABLED 0)
   set(${upfeat}_DISABLED 1)
 endif()
endforeach()

and should be put somewhere before the portfile is included.
vcpkg_check_features() thus looks superflous and there is no benefit of having it. I still have to do the mapping from feature to cmake option and it might even be more obvious using the syntax:
-DSOME_STRANGE_PORTFILE_SPECIFIC_CMAKE_OPTION=${FEATURE_DISABLED} instead of just passing ${port_OPTIONS}

Is there a simple reason why <uppercasefeature>_ENABLED and <uppercasefeature>_DISABLED are not simply passed by vcpkg to cmake?
vcpkg_check_features() thus looks superflous and there is no benefit of having it. I still have to do the mapping from feature to cmake option and it might even be more obvious using the syntax:
-DSOME_STRANGE_PORTFILE_SPECIFIC_CMAKE_OPTION=${FEATURE_DISABLED} instead of just passing ${port_OPTIONS}

The main motivation behind this PR is to get rid of automatically-set variables.
We strive to design portfile functions with zero or minimal side-effects. Although, sometimes it is not possible (e.g.: vcpkg_configure_cmake() smuggles the generator to vcpkg_install_cmake()).
The same is true for vcpkg features, we try to limit the behind-the-scenes "magic" that is done by vcpkg, for that reason, adding feature_ENABLED and feature_DISABLED macros would contribute negatively to this goal.
Using the -DLIBRARY_SPECIFIC_OPTION=${FEATURE_DISABLED} pattern does not solve the problem of having to map each feature to a CMake option manually, but having the definition in vcpkg_check_features() match the library specific option from the start does.
vcpkg_check_feature(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
  "feature"    LIBRARY_SPECIFIC_OPTION
)

behind-the-scenes "magic"

that just referes to undocumented behavior. If the variables are documented there is no issue with that. The function just is documented and thus it seems like less behind-the-scenes "magic". The same could be said about all the VCPKG_POLICY_ variables. They are just missing documentation.
Netherless you probably want to add an optional APPEND option and an optional NEGATE option instead of an INVERTED_FEATURES list. APPEND to append to OUT_FEATURE_OPTIONS which allows chaining of multiple vcpkg_check_feature calls into one OUT_FEATURE_OPTIONS variable which is probably necessary if you do not want to have big duplicated features checks for different build targets.

We did consider a NEGATE option, but we felt that having the user declare the two categories was clearer and easier to read (assuming you don't have over a page of options). Because this is setting cmake -D options, order isn't relevant.
I really like the idea of APPEND, though we can add that switch later once we see a port that can benefit from it.


MAINT: remove usage of removed astropy functionality _find_home()

This should hopefully fix #1106

cc @aphearin - this should be good to go now, and maybe could be included in a quick bugfix release that fixes astropy 7.0 compatibility.

Thanks for this fix @bsipocz! I'm glad you were able to pinpoint this issue with setuptools, and separate this bug from the ongoing unresolved bug with Numpy 2.0 incompatibility, which may take longer to resolve. The source of the Numpy 2.0 incompatibility looks like the way the cython kernels are written, but I haven't gotten to the bottom of that yet. And so since your fix in this PR works in standalone fashion, maybe we should proceed with this merge and then turn attention to the cython/extension-helpers/etc - do you agree?

Yes, I agree that these should be handled separately. Saying that it's not yet numpy2.0 compatible is totally legitimate, but there is no reason for not to be astropy 7 compatible when it's all just silly API cleanups that shouldn't have happened without due notice of downstream.

Great, yes, that's what I thought too - thanks for confirming.


Automatically sync emojis list

Hey, this lib becomes out of sync whenever gitmoji adds a new emoji. Here's how I managed to solve the problem.

Add gitmoji to the dev dependencies. Unfortunately gitmoji is not available from NPM, so we must point to the GitHub repo.

    "gitmoji": "carloscuesta/gitmoji",

Change the commitlint config file:

const { gitmojis } = require('gitmoji/src/data/gitmojis.json')
const allGitmojiCodes = gitmojis.map(gitmoji => gitmoji.code)

module.exports = {
  rules: {
    'type-enum': [2, 'always', allGitmojiCodes],

What do you think? Would you like a PR?

Downside of the approach above is that it will install all dependencies from the gitmoji repository. Almost doubled the contents of my yarn.lock file :fearful:.
I have another idea. We can download the gitmojis.json file from GitHub and place it in os.tmpdir(). Next time, if the file already exists, skip the download.
const downloadSync = (url, targetPath) => {
  const result = require('child_process').execFileSync('curl', ['--silent', '-L', url], {
    encoding: 'utf8',
    maxBuffer: Infinity,
  })

  fs.writeFileSync(targetPath, result)
}

const filePath = join(os.tmpdir(), 'gitmojis.json')

// Download gitmoji.json if not already downloaded
if (!fs.existsSync(filePath)) {
  downloadSync('https://raw.githubusercontent.com/carloscuesta/gitmoji/master/src/data/gitmojis.json', filePath)
}

const { gitmojis } = require(filePath)
const allGitmojiCodes = gitmojis.map(gitmoji => gitmoji.code)

module.exports = {
  rules: {
    'type-enum': [2, 'always', allGitmojiCodes],

Now in order to update the list of emojis the user only needs to rm /tmp/gitmojis.json (so that it'll be downloaded again next time commitlint runs). Or maybe we should keep the file at join(__dirname, 'gitmojis.json') // => "node_modules/commitlint-config-gitmoji/gitmojis.json" so that deleting the node_modules folder will also delete it (which seems to be what users would expect).

The second approach is better in my opinion

@khaosdoctor Thanks for the comment.
What do you think about a) saving to /tmp/gitmojis.json Vs. b) saving to node_modules/commitlint-config-gitmoji/gitmojis.json?


fix: re-add offline flag to sqlx crate

I think this got accidentally dropped in the big refactor, unless there’s some reason I’m missing why use of the offline flag should require a direct sqlx-core dependency.

CI failure is due to a failed network request for rustup during setup; not related to this change.

I think one of the intentions of v0.7 was to always provide offline functionality although I haven't checked the implementation to see if that's the case

Yes the intent was to make the offline feature non-optional, not remove it. This is because it shares a lot of code with the support for #[sqlx::test] and would have made a more complicated feature matrix if it was optional, and it seems like most people end up using offline mode anyway.
If offline mode doesn't work, feel free to open a fix for that.

Oh! That makes a lot of sense, thanks.


[bug] config managent might lead to removal of ignored files

HubKit version(s) affected: 1.6-BETA7
When you run the config-init command (or checkout the _hubkit branch) and have a config.php file that is ignored by Git (as is the case for HubKit itself) the config.php file will overwritten.
And the same is true for other files, although unlikely I still consider this a serious problem. Both commands should check if these files exist (and are ignored by .gitignore) and warn that these will be temporarily moved to named file like hk~config.php, once done these files moves are moved back.
As the the config-init command is designed with the purpose of initializing the configuration branch this requires a finalizing command to clean-up everything once done.
Effectively editing/initializing the configuration is as follows:

inti-config or edit-config (new command)
Editing the configuration, adding files, etc
save-config verifies the configuration (by crashing if broken 😅 ), checkout the previous branch (before editing started),
and restores backed-up files.

In the rare case the temp files still exist fail hard with an error, and require to solve this manually.

OK, well moving the config.php file (for HubKit) would actually break the application 😶🌫
As this is rare case I suggest to rather detect if there are files that would be overwritten by checkout, and error instead.
Git already issues an error when this happens in another situation.

OK, I solved it. Will open a pull request tomorrow.


Support reversing when path includes reversing segments with the Smac Planners (or other feasible planners)

Essentially, some of the planners in Nav2 are kinematically feasible containing specific points to reverse direction to achieve some path. It is differentiated by having a cusp point and the direction of the arrows on the path are reversed. So the path yaws will be pointing in the opposite direction than a forward-moving request.
I'd like to make sure this can respect those, approximately speaking. The 3 tests:

Path asks robot to reverse direction in the middle of some plan: MPPI does so around the right point in the right direction
Path asks the robot to start in reverse, MPPI does so rather than rotating forward to follow
Path asks for an in-place rotation, MPPI approximately does so (though, the least important of the 3)

Though, this could be something to be dealt with at a later date. Just wanted it documented. This is the lowest priority of the remaining tickets

This is a problem post initial release.


Update get-partitionsupportedsize.md

#982
Action Taken:
Added "This command will show the actual value to see the minimum and maximum size for the partition (SizeMin and SizeMax)."
See screenshot: https://snag.gy/GjqpDB.jpg
See article:
https://docs.microsoft.com/en-us/powershell/module/storage/get-partitionsupportedsize?view=win10-ps#feedback - not updated
still show up as: "MinimumSize"  "MaximumSize "
See example in this article as well:
https://docs.microsoft.com/en-us/powershell/module/storage/resize-partition?view=winserver2012r2-ps

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.

I accept the additions after @JohanFreelancer9 edit, but I am not seeing in the PR the original issue fixed where the user says to correct Get-PartitionSupportedSizes in the Description.

I am agree with this PR.
@get-itips looks like @sowjanya365 removed on Apr 24 the 's'.

@dariomws306 oh thanks for the clarification.

I'd drop the "actual" but am otherwise OK with this.

@AndreaBarr This PR can be merged. Thanks.


fix: delimiter slice may be overwritten

What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Byte slices are not copied by value. As a result, buffered reader could overwrite delimiter when scanning more tokens.
What is the new behavior?
Make a copy of the delimiter byte slice.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 29.677%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
1461

Relevant Lines:
4923

💛  - Coveralls


tr_artic_r3: Tx payload message length unclear in datasheet

The datasheet for the Artic-R3 is unclear, with no clear indication of how to calculate this parameter.
ARTIC R3 Datasheet - For use with Argos 2/3/4 - 3.5.2 a)

Message length for 120bit message [4bit]: 0x6

This should be confirmed with the manufacturer before completing the tests.

This seems to be explained in more detail in;
A4-SYS-IF-0086-CNES_0107 - SERVICES AND MESSAGE FORMATS General Specifications
The result it the 4bit message length is further divided up into [3bit (number of 32bit words + 1][1bit (parity of previous 3bit].


Enhancement-data-reference-styles (prod)

@mmontesanonyc Just tweaking some things. Have a look.

Nice - thanks.


Feature/python 39

Thanks @pauloxnet

Thanks @pauloxnet

Thanks to you @migonzalvar 👌

Thanks to you @migonzalvar 👌


release?

It would be great to have a release soon so we can more easily install into pangeo forge containers.

I agree, I'm also writing another blog post and it would be nice to give
readers a simple pip/conda install fsspec-reference-maker rather than
having to pull directly from the main branch.
On Mon, Aug 23, 2021 at 9:31 AM Ryan Abernathey @.***>
wrote:

It would be great to have a release soon so we can more easily install
into pangeo forge containers.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/intake/fsspec-reference-maker/issues/68, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTH32WCU5JXT2KP7XMEEF3T6JZVXANCNFSM5CU6GPSQ
.

--
Lucas Sterzinger (he/him)
PhD Candidate
UC Davis Cloud Physics Research Group
Hoagland Hall 236
@.***
https://lucassterzinger.com

done

I believe fsspec-reference-maker is currently only released on pypi? IIUC conda-build can't resolve dependencies with pip, so we'll need it on conda to fulfill https://github.com/pangeo-forge/pangeo-forge-recipes/issues/197 ?


[ART-4221] New private area on mirror

This is deployed. This logic will also need to be implemented in @vfreex 's port to python in openshift-eng.


Add a consensus::deserialize_hex function

We have serialize_hex and deserialize but no deserialize_hex, add it.
I've put it in consensus/mod.rs even though this is strange but its also strange to put it in encode when the error handling is the new style. Should really be on top of #1891 but I think this can go in before release and 1891 likely won't.
Found while hacking up the rust-bitcoincore-rpc dependency upgrade for upcoming release bitcoin v0.31.0.

Will need #2036

I'm now not sure this is correct because it does not have the same behaviour in regards to erroring if all data is not consumed. However doing so needs a refactor which implies I have to change the error handling because I've used the "new" style. I'm inclined to put this to draft and do it after the release ...

Drafting sounds good to me. deserialize_hex should definitely error if it doesn't consume all the bytes. If users want to do partial reads of a stream they should be using the consensus_decode trait.

Cool, thanks.

Yes I have wanted this SO MUCH for SO LONG :) :)

I took it from you rust-bitcoincore-rpc crate. After thinking "what a lazy bastard, why didn't he upstream this" :)

I took it from you rust-bitcoincore-rpc crate. After thinking "what a lazy bastard, why didn't he upstream this" :)

Vaguely remember something like "we don't know how to deal with errors when it comes to hex and don't want to think about it". Which I agreed with at the time, we didn't do much hex other than hash types in the hashes::hex module and converting to hex never gives errors while parsing it can.
But glad it's making it in. Tbh on principle we should have neither of them and users should just use a hex crate to do hex, but well, it's so common in Bitcoin to represent txs as a very specific type of hex (non-prefixed lowercase) that we can get away with it IMO.

Cool, thanks for looking. I'll come back to this once v0.31.0 is out.

it's so common in Bitcoin to represent txs as a very specific type of hex (non-prefixed lowercase) that we can get away with it

Yeah, I would even consider impl FromStr for Transaction

Needs hex to use new io crate.

Ah, interesting, so IO is actually useful in hex.

Damn, I was using this method just now and then realized it doesn't exist yet..

This is WIP but showcases that we only need Read in hex not BufRead.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-80 of 181 (55.8%)  changed or added relevant lines in 13 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 83.917%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bitcoin/src/taproot/serialized_signature.rs
0
2
0.0%

hashes/src/util.rs
6
8
75.0%

bitcoin/src/blockdata/witness.rs
2
5
40.0%

bitcoin/src/crypto/key.rs
9
12
75.0%

bitcoin/src/consensus/serde.rs
1
7
14.29%

bitcoin/src/consensus/encode.rs
18
35
51.43%

bitcoin/src/consensus/mod.rs
19
66
28.79%

Files with Coverage Reduction
New Missed Lines
%

bitcoin/src/consensus/serde.rs
5
43.87%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
19489

Relevant Lines:
23224

💛  - Coveralls

Needs #2512

Might need #2573

Rebased for good measure to pick up #2573, there are no acks anyways. No other changes.

Labels were stale.


cache-client: fix npe when the context wasn't set

Summary
it will panic when the context is not set.
Related issue(s)
Fixes #

/assign @stevekuznetsov

/lgtm
/approve


Review whether we need both links in IA emails

Issue: in the IA email we send an upload and a download link. This tends to cause more confusion than it actually resolves, as the links are the same and go to the same place. This is probably exacerbated by the bug in #34 which means session state is ending up in a weird place.

Expected: we change copy in the email and just send a single link to the IA and make it clear that is where the user can download, upload and review the IA. We could probably make it clear that the URL is not one use.
@ClaireTroughtonJAC would it be best for me to speak to Matt Howley about this?

Have emailed Matt and Rob.

Dear ((assessorName))
((applicantName)) has applied for the role of ((exerciseName)) and has nominated you as an independent assessor.
You are asked to provide evidence of the candidate’s performance against the ((xCompetencyAreasOrXSkillsAndAbilities)) for this role.
Guidance on completing the form and what to include in your assessment can be found on the JAC website.
The links below should not be opened in Internet Explorer. Please use an alternative browser such as Google Chrome or Firefox.
To view and complete the assessment form, please click on the link below. You may close and revisit the link as required:
((uploadUrl))
Edit and save the form using Microsoft Word, or any other compatible word processor.
As the JAC runs a policy of Name-Blind sifting, we would be grateful if you could avoid referring to the candidate by name when providing your written examples.
The date for return is ((submitAssessmentDueDate)).
When you have completed the form, please upload it at the link above.
Point of contact
If you need assistance, please contact the Selection Exercise Team by email ((exerciseMailbox)) or call ((exercisePhoneNumber)).
Confidentiality
Whilst written feedback is provided to some unsuccessful candidates, the JAC treats independent assessments as confidential and in line with GDPR and Data Protection legislation. Information you provide will not be disclosed to the candidate.
If you raise a serious allegation that the JAC believes should be investigated, you will not be identified as the source without your consent.
Regards
((selectionExerciseManager))
On behalf of the Judicial Appointments Commission

Here is the new copy. We'll need to make the same changes over on the IA reminder email.
I am checking with Notify what will happen if our template suddenly doesn't require the downloadUrl field: https://ukgovernmentdigital.slack.com/archives/C0E1ADVPC/p1596011554195300

Notify ignores additional fields :tada:
This change has been made in Notify.


Does not login

Following this tutorial and have gone through it multiple times to make sure everything is set right.
Upon login with a user (one who is registered with my tenant), the login popup goes away but then comes back with no changes to the parent page. I have't touched the code from github and I am seeing no errors in the console.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 370e4c33-91b6-eafb-1ced-0a079449d982
Version Independent ID: cefd38c9-5c1e-c381-0549-ded07f752f97
Content: Tutorial - Enable authentication in a single-page application  - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-tutorials-spa.md
Service: active-directory
Sub-service: b2c
GitHub Login: @davidmu1
Microsoft Alias: davidmu

Digging into the code, this tutorial assumes one has setup the API and needed scopes. If you follow this tutorial straight through, top to bottom, it gives the above behavior.

@aszalacinski Thank you for the detailed feedback. We are actively investigating and will have the content owner make an update as appropriate.

Hi @aszalacinski ,
Thanks for your valuable feedback! Is this related to the other issue you created where you said that you managed to get it to work by using an older version of MSAL, or are you still stuck on the login issue?

It is not. It's based on how the Tutorial section is setup. If you follow the tutorial from "top to bottom" the code sample references an API that you don't setup until the next tutorial, protecting an API. If you leave the code as is, you get the experience I mentioned in the original comment.
I have found solutions to my code obstacles by digging into the msal library and accompanying sample code however this tutorial page in the docs may cause some confusion. Thanks for getting back to me!

Thank you, @aszalacinski
I am assigning this to the content author, @davidmu1 .
Which is the API setup tutorial that you are referring to? Do you think it would be enough to include a note in the document that this is a prerequisite?

@MarileeTurscak-MSFT: Please assign this item to @mmacy who is now supporting Azure AD B2C.

@MarileeTurscak-MSFT: Please assign this item to @mmacy who is now supporting Azure AD B2C.

Not sure why this is marked as closed, still having the same issue. I followed this "from top-to-bottom" and I'm still having an issue with the "ServerError: AADB2C90205: This application does not have sufficient permissions against this web resource to perform the operation."
Seems like I'm having the same issue where this code is asking for an access token to something I haven't built yet

@KepanoEgg It seems you might have missed the Error: insufficient permissions section of the article, which states:

Error: insufficient permissions
After you sign in, the app displays an insufficient permissions error - this is expected:
ServerError: AADB2C90205: This application does not have sufficient permissions against this web resource to perform the operation.
You receive this error because you're attempting to access a resource from the demo directory, but your access token is valid only for your Azure AD directory. The API call is therefore unauthorized.
Continue with the next tutorial in the series (see Next steps) to create a protected web API for your directory.

Admittedly not the best experience for a tutorial, however. I'll start a discussion internally about updating the sample and tutorials to improve the flow so that errors like this aren't thrown at the end of the tutorial.

You are correct, I did miss that section, but I also agree that it's not ideal for a tutorial.

@mmacy So the next step has me set up an API on my B2C tenant as well, so the token still won't work, because it's not on my AD tenant.  Did I miss a step there?


Toil reduction: basic listing of a repo should not require an entry in repos.yml.

repos.yml duplicates a bunch of information that's either already available from the GitHub API or we can easily add using tags. This is a source of toil and frustration.
An entry in repos.yml should only be necessary for specifying metadata that we can't easily get from GitHub tags.
For example, we already tag our repos with govuk. type is a natural fit for a tag. description should come from the repo description and not be duplicated here. retired should be inferred if the repo is archived. Team ownership could probably be a tag.

D'oh. Thanks @ChrisBAshton 😄
TIL fix (as opposed to fixes) is one of GitHub magicky keywords 🙃


Add missing subtask name

It's a total mystery to me that hardhat was fetching and executing the task anyway.
I just checked in main. The name is undefined, but it executes the correct task correctly nonetheless 🤷


Can't comprehend how to add "localImage" via JSON under Images.main

When you look @ this doc: https://spotify.github.io/HubFramework/Protocols/HUBComponentImageData.html
it tells we can add local Images from the swift code via "localImage" property of HUBComponentImageData.
Whereas in the JSON Doc. : https://spotify.github.io/HubFramework/json-programming-guide.html
There is only a reference to URI & placeholder property under Images.main.

So how do I give reference to LocallyStored Images from the JSON file, via which attribute?
May be I am missing something or the doc misses something.
Thanks
Anant

@anantthebiker The framework doesn't support adding local images when using JSON yet, it needs to be done in code in a content operation. We could always add support for specifying a local image name in JSON as well (we haven't had the need for it internally yet, since when we use JSON we always use remote images downloaded over the network).
@diegc, do you think this is something that would be OK to add to the JSON schema from an Android perspective?

How about a local key that points to a bundled image?

@JohnSundell there would be no need to add a new property to the schema from the Android perspective, since loading local images can be done using the standard uri format for local resources (android:resource://...). The code path for local resources is the same as for remote resources.

@diegc Ah that's cool! But if one wants to use the same JSON for both iOS & Android, android:resource//... cannot be used (as it won't work on iOS). How about we introduce a local key that then gets translated to the platform-specific paths on the client side?

@JohnSundell definitely. I was just referring to the ability to set a local image in code on Android. While the same property can be used for both local and remote if the clients inspect its value, I agree that for cross-platform JSON, having something more explicit makes it easier (Android could then, for instance, translate local = "foo_icon" to something like uri = "android:resource//org.blah/drawable/foo_icon").
So, in short, adding local is ok for Android :)

@diegc Sounds awesome! 🚀 I'll add an issue for adding it.

Implementation plan here: https://github.com/spotify/HubFramework/issues/162


Add borastankovic.edu.rs

@akymaky Thank you for your patience while waiting for a review and processing your request. Pull request merged.


v0.8.9_15: Cross symbol ‘x’ is missing

SEVERITY: Major
MODULE: Mountain Chart
Platform: MAC / Safari 9.0
RELEASE: v0.8.9
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.8.9/preview/mountainchart.html
Mountain chart page will be loaded
Select a country. For example we select China.
Selected country is shown on top left with the population of that country
Take the mouse to the population. A small circle is shown to remove this population
Note that cross symbol ‘x’ is missing there

ACTUAL RESULTS:
Cross symbol ‘x’ is missing on population of the country
EXPECTED RESULTS:
Cross symbol ‘x’ should be there for better understanding to deselect the country
SCREENSHOT:

https://github.com/Gapminder/vizabi/pull/1042


Support httpie in Chrome DevTools

This is not httpie tool request per-se, instead as an avid user of the httpie tool, I find it frustrating that in the network tab of the Chrome DevTools, there's an option in the context menu of a request to copy it as a Curl or Fetch command line, but not as Httpie command line.
It would be great if anyone from this community will work on a browser extension to support that!

I think it might be possible to add it to DevTools directly. Planning to look into it at some point.  Here’s the ‘Copy as curl’ implementation in DevTools:
https://github.com/ChromeDevTools/devtools-frontend/blob/9b555a1251af22350c65966e094a3d74c4eee135/front_end/panels/network/NetworkLogView.ts#L2095-L2203


Bug when rewriting relative import in un-optimized node_modules

Do NOT ignore this template or your issue will have a very high chance to be closed without comment.

Describe the bug
When dev server rewriting relative import inside un-optimized node_modules, the rewrited path is wrong and cause 404 when request the child modules.
This is the same issue with https://github.com/vitejs/vite/issues/204 but I didn't provide reproduction. So I open this issue.
Reproduction
Here is a minimal reproduce:
https://github.com/csr632/test-vite/tree/wrong-resolve
System Info

required vite version: 0.16.6

I am working on this


Add throttling counter in gcsio

Implement an on_error callback where throttling counter is incremented when GCS throttling happens.

A new retry object is needed for invoking a custom on_error callback. We derive this retry object based on the default retry object from gcs client library.
Default retry object are replaced with the new retry object in the API calls.
Both copy_batch and delete_batch are reimplemented without client.batch() so retry will happen if needed.

This is a second attempt for this feature. The previous PR is at #31584.

R: @andrewsg @Abacn

The failed YAML Xlang Direct test is unrelated to the code change here.


Removed spaces to make command one line

The existing script has a line break which prevents the script from working if copying directly. My change removed the spaces so the script is usable without editing.

Hello @yhscherber ... Thanks for the PR. It was done originally because we have a line length limit on code of 85 characters. Indeed, tho! We can't be breaking folks. 🙈😄 I'm going to move this to an issue and work it right now because this update is going to touch several topics here.

Ah! Good news, @yhscherber ... I only found ONE other instance of this. I was concerned that there might be a half-dozen or more, but no ... just one. Let's merge your PR here, and then I'll knock out that other one on a new PR.
Thanks again! :rocket: