android suggestions

Hi,
First, thanks for creating this plugins with minimal dependencies and using the latest Android APIs.
I'd like to propose some improvements for the Android pluging.

on Android API < 29 support connection without requiring location permissions.

wifiManager.connectionInfo.ssid requires location permission, as an alternative the ssid could be obtained from info.getExtraInfo().
In the change receiver once could check both connectionInfo and extraInfo to cover both cases
          result.success(wifiManager.connectionInfo.ssid == wifiConfiguration.SSID || info.getExtraInfo() == wifiConfiguration.SSID)

implement disconnect method on Android

Some application need to programatically disconnect from the peer to peer network and go back to the "default" WiFi/Internet connection.  On API < 29 this could be done by calling wifiManager.disconnect(), not the nicest but it works. On API >=29, it is a bit more involved but cleaner: unregister the network callback, and unbind the process from the network.
Note: on API >= 29, the network callback was being removed on onAvailable which caused the connection to be disconnected as soon as it was connected.

issue with wpa2/wpa3 on Android 11

On Android 11 (didn't test on Android 10) setWpa2Passphrase and setWpa3Passphrase are mutually exclusive. I propose to add an argument to explicitly ask for WPA3 when required by the application. The error is:
E/flutter (31808): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: PlatformException(error, only one of setIsEnhancedOpen, setWpa2Passphrase,setWpa3Passphrase, setWpa2EnterpriseConfig or setWpa3EnterpriseConfig can be invoked for network specifier, null, java.lang.IllegalStateException: only one of setIsEnhancedOpen, setWpa2Passphrase,setWpa3Passphrase, setWpa2EnterpriseConfig or setWpa3EnterpriseConfig can be invoked for network specifier

I'm submitting a PR with the above proposed changes. Happy to discuss them. Tested on Android 8.1 (Nexus 5X) and Android 11 (Pixel 2(
Thank you!

no need to discuss, I agree with your assessments. This was a quick prototype, so its nice to be able to move it forward. I plan on addressing some other issues I've come across, just been busy over the holiday season. Thanks a ton.
My only comment is regarding the location permissions on <29, I believe even with that change location permissions are still necessary due to the nature of connecting to alternative WIFI devices. However it would remove the requirement in the case of getSSID here https://github.com/HerbiaEra/flutter_wifi_connect/blob/6632122edb12b7293af596e7cd3e9c6fec5439f5/android/src/main/kotlin/com/weplenish/flutter_wifi_connect/FlutterWifiConnectPlugin.kt#L71 has i implemented it.
I'm sure you've noticed the primary reasons I didn't implement certain things in android is because there is no ability to implement them in iOS, so I've left a few things in limbo as a result.

Thanks @vipero07 for accepting my contribution and merging it so quickly!
Regarding permissions this is what I have so far and it is working fine on Android 8.1 and 11.0.
    <uses-permission android:name="android.permission.CHANGE_WIFI_STATE" />
    <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
    <uses-permission android:name="android.permission.CHANGE_NETWORK_STATE" />
    <uses-permission android:name="android.permission.WRITE_SETTINGS" />

My understanding is that as long as we don't perform a wifi scan, or ask for the currently connected SSID (unless the connection was triggered by us. I think for the use case of IoT device pairing (which I believe it is also your use case) we will not need location permissions.
Please tag me once you publish a new version in pub.dev, in the meantime I'm referencing the commit hash.

pub.dev has been updated to include your modifications.
On android pre 29 for it to connect to an ssid by prefix it does a wifi scan. So only in the case of having the exact ssid would it not require location permission. Unfortunately for me the device I'm dealing with is prefixed. However you are correct the other cases wouldn't require location permissions. Honestly it didn't occur to me. Thanks again for the insight.


Feature/improve mapping of errors

Try errors as URLError in Result.mapToNetworkError
Run swiftformat

Codecov Report

Merging #7 (8975952) into main (71806bf) will decrease coverage by 0.18%.
The diff coverage is 81.81%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   76.60%   76.42%   -0.18%
==========================================
  Files          50       50
  Lines        1530     1527       -3
==========================================
- Hits         1172     1167       -5
- Misses        358      360       +2

Impacted Files
Coverage Δ

...kServiceAsyncBeta/NetworkServiceClient+Start.swift
76.00% <ø> (-0.48%)
:arrow_down:

...etworkServiceAsyncBeta/Result+NetworkService.swift
79.41% <71.42%> (-6.70%)
:arrow_down:

...HelperAsyncBetaTests/MockNetworkServiceTests.swift
98.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add Status into Presence struct

I just add the status into the Presence structure.

go fmt please

Sorry, I don't know what do you mean with "go fmt" ?

Just type go fmt on the directory :)

Ok, didn't know about this command line. Pretty useful.
Thank.

Thanks.


nixos/tests/nginx: add test variant for moreheaders module

Description of changes
As suggested here https://github.com/NixOS/nixpkgs/pull/277449#issuecomment-1873033836
I copied the test skeleton from nixos/tests/nginx-auth.nix.
Build with nix-build -A nixosTests.nginx-moreheaders.
We don't need to include the module because nixos includes it by default.
If someone has ideas for better another test or two, please drop them.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Not sie what's wrong with the Darwin eval. Found to restart it.
@ofborg eval

Looks like store corruption on the builder.

@ofborg eval

Now it's green 🎉


Error in 5p10XTCR example script

When running the 5p10XTCR example in a docker container the pipeline runs until the following point and then fails:
...<lines above cut>...
TRA chains: 156 (55.12%)
TRB chains: 127 (44.88%)
TCR_out/TCR_testrun_bcreads.fasta
TCR_out/TCR_testrun_ref/
Feb 19 22:24:35 ..... started STAR run
Feb 19 22:24:35 ... starting to generate Genome files

genomeGenerate.cpp:150:genomeGenerate: exiting because of *OUTPUT FILE* error: could not create output file TCR_out/TCR_testrun_ref//genomeParameters.txt
Solution: check that the path exists and you have write permission for this file

It looks like there might be an error in genomeGenerate.cpp putting in an additional / character into the path for the output file

looks like an error in STAR - will try earlier versions of STAR and then pin those versions in the Dockerfile.  Any advice on working versions of STAR?


Add Unit Test Job

As a developer
I need a unit test job
So that I can run unit tests when I run the nosetests command
Details & Assumptions:

...

Acceptance Criteria:
Given [some initial state]
When [some event]
Then [some measurable outcome]

Btw this story seems to be covered by #63 already?


GEOMESA-652 Enable per feature visibilities

Users can now set visibilities on a per feature level
by setting a property in the feature user data.  There
is a utility class, SecurityUtils, that exposes the key
and convenience methods for setting visibilities.

Looks good. I had one comment about updates/deletes.
It might be user-friendly if we allowed something in the SFT that specified a particular attribute to be a classification/capco marking. Then we could run something (in a pluggable fashion) to turn that label into visibilities for them.
I imagine we might need something like that for the command line tools ingest as well, where we'll need to set the user data based on a column in the file.

I've read through, and it looks good.  @elahrvivaz's comment brings up an excellent point.

Updates for deletes look good.

Committed as b182f6bc867f239c135f4db0e55b88ac2958ac2d on 1.5.


Migrate to SMAPI 4.0 & Improve formatting

This PR solves all deprecation warnings for SMAPI 4.0, adds auto-updates to nuget packages and improves the code formatting.
Code formatting was automatically done by vscode, but if you don't like that I'll revert that.
I updated SMAPI to the latest version and created a workflow to automatically merge any future updates after confirming the project still succeeds to build.
Migration was done by using the wiki page as a reference and adjusting the code accordingly.
I plan on contributing another feature, but wanted to make sure the project builds without any warnings/errors first, which is how this PR came to be.

Please revert the code formatting.  The default VS code formatting is very wrong in my opinion (in several ways).

Will do that!
Is there a way to enforce the code formatting you want? (Would .editorconfig do that?)

I don't believe there is any .editorconfig that works between the Mac version of Visual Studio (which I use) and the Windows version, or with VSCode.  I'd be delighted to be wrong about that, however.
Here's the format overview in preferences:

...and of course, indent with tabs rather than spaces.

What do you think of this?
I only kept the rules that were modified, but hopefully this catches everything shown in the screenshot.
There are many more options, so I just left a link to the reference pages in the file.

Looks promising!  I'm not sure which IDEs will actually pay any attention to it, but it certainly can't hurt.

So the PR is looking much better.  I still see a lot of "noise" changes in the whitespace.  Maybe some of that is unavoidable, but can we do anything about the common case of blank lines:

Here the original code had whitespace up to the proper indentation level for that block of code; your version strips that out.  That makes it harder to review the actual code changes in the PR, and also makes it slightly harder for a user who comes along later and wants to insert some code on the blank line.  Sure, if they hit return the editor ought to insert the proper indentation, but what if they want to type something and then hit Return?  They have to first mash the Tab key to get the cursor where it belongs.
So if there is some way in your editor to make it not strip the whitespace out of blank lines, I'd much prefer it.

Oh I think there was an option for that in .editorconfig as well. I'll fix that and rebase again!

Should be a lot better now!

Yeah looks good!  I'm going to study this more carefully and likely merge it in tomorrow.  Thank you for your contribution!

Nice work.  I hope the thing you're gearing up to tackle next is https://app.bountysource.com/issues/111311010-feature-add-multiplayer-support-to-farmtronics-sdv-mod — you would be a hero to a whole lot of Farmtronics users!
Also, feel free to hop into our Discord server (link at bottom of https://miniscript.org), or DM me directly there, so we can communicate more quickly as you tackle such a complex issue.


Improve API of sm3

The current API of sm3 requires users to explicitly provide message length. This might lead to potential misuses. For example, the following code wrongly computes the digest (due to incorrect length input) without informing the user.
        let msg = [0x61_626300u32];

        let hash = sm3_enc(&msg, 512);
        // this assertion fails
        assert_eq!(
            hash,
            [
                0x66c7f0f4, 0x62eeedd9, 0xd1f2d46b, 0xdc10e4e2, 0x4167c487, 0x5cf2f7a2, 0x297da02b,
                0x8f4ba8e0
            ]
        );

Another problem of the API is that it awkwardly requires user to pad the message with 0's to fit in the u32 blocks, which is error-prone. For example, the following code gives the digest of 0x0061_6263 instead of 0x6162_63.
        let msg = [0x61_6263u32];

        let hash = sm3_enc(&msg, 24);
        // this assertion fails
        assert_eq!(
            hash,
            [
                0x66c7f0f4, 0x62eeedd9, 0xd1f2d46b, 0xdc10e4e2, 0x4167c487, 0x5cf2f7a2, 0x297da02b,
                0x8f4ba8e0
            ]
        );

One possible fix could be to modify the API so that it accepts a string as input, then after manually finding the length, this wrapper function may split the string into &[u32] for use of the core functions.

Would it be a good idea to assume msg length is a multiple of 8? This way we can use &[u8].

How about let's survey how other Rust's crypto libraries design their APIs and list here? Then, we can discuss pros and cons.

Yes, as can be seen, they all use [u8] (or equivalent b"hello,world") as a minimum unit for input. I believe using this API would be more user-friendly.

Yes, agree.

I changed the API of sm2/3 to use &[u8] in 52201d6c2431b241efaa044c505da2ea0bbf14b0 and  1eff82ee2f69abc7acb5903d29a9bf608198f18a. Currently sm4 API also accepts [u32] as input, I think maybe changing it to use &[u8] would be more adherent to conventions. What's your opinion?
For example, see

RustCrypto: https://github.com/RustCrypto/block-ciphers

extern crate aes_soft as aes;
extern crate block_modes;

use block_modes::{BlockMode, BlockModeIv, Cbc};
use block_modes::block_padding::Pkcs7;
use aes::Aes128;

// create an alias for convinience
type Aes128Cbc = Cbc<Aes128, Pkcs7>;

let mut cipher = Aes128Cbc::new_varkey(key, iv).unwrap();
// buffer must have enough space for message+padding
let mut buffer = [0u8; 32];
// copy message to the buffer
buffer[..msg_len].copy_from_slice(msg);
let encrypted_msg = cipher.encrypt_pad(&mut buffer, msg_len).unwrap();

let mut cipher = Aes128Cbc::new_varkey(key, iv).unwrap();
let decrypted_msg = cipher.decrypt_pad(encrypted_data).unwrap();

Yes, agree.

Done in #17.


@Mapper igonre filed under a collcetion of objects

Hello,
I have a parentNode object that contains  collection of childNode objects . Each childNode  contains two attributes (attribute1, attribute2) I have created a ParentNodeMapper and  I  want to ignore attribute2 from  childNode objects.  I tried the withIgnoreFields = {"com.test.entities.ParentNode .childs.attribute2","com.test.beans.ParentNode .childs.attribute2"}, but it didn't work. If there any why to ignore it without passing by custom mapper?
Thanks

Hi,
sorry for delay, you can ignore the attribute2 based on its name, or with the name of the class holding it :
"attribute2", "Class.attribute2" or "xx.yyy.zzz.Class.attribute2"
Selma does not ignore fields based on a complete bean path.


Fix add checkBlockRules() check for create view and alter view

run buildall

run performance

run buildall

run p0


web: show * next to resources with pending manual mode changes

Also better support for manual mode pending resources

I imagine we will change the styling later on, but wanted to get the correct functionality in first.


Invalid ServiceAccount name when using named releases

Hi,
The chart creates a serviceaccount object based on {{ .Release.Name }}, however, the deployment refers to {{ .Chart.Name }} as the serviceaccount.
These are not guaranteed to be the same, for example, I am trying to deploy one release as switchboard-internal and another as switchboard-external, thus the deployment fails because it is looking for the switchboard serviceaccount.

Thanks for the issue! I'll likely get to it in the next 3-5 days.


Identifiers which start with an underscore could be scoped to the file

The lack of scoping in MMAR makes it difficult to make large programs. One way to add this could be to treat label and constant identifiers which start with an underscore as being private to the file they're defined in.
This does not solve the problem of nesting labels however, and may just encourage users to split each function into its own file.

Made obsolete by #22.


Correlation analysis 1.4

Classic dialog skill analysis - got up to 1.4 when running the notebook and encountered this error:
InvalidParameterError: The 'stop_words' parameter of CountVectorizer must be a str among {'english'}, an instance of 'list' or None. Got {'i', 'the', 'of', 'and', 'is', 'or', 'be', 'in', 'a', 'an', 'to', 'on', 'can'} instead.

closed as issue already addressed


ssm-session-manager-plugin: add "aarch64-linux" support

Description of changes
This package has an if that covers only linux on amd64 and mac on all platforms. This adds support for linux of arm64.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage I am not using nixOS, so cannot run this.
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I created a flake that includes this package and it build and worked fine.
CC: @mbaillie

@martinbaillie I think you are the correct maintainer and the file has the wrong username?

@maxeaubrey Maybe you're the right person to ping? :)

@WhyNotHugo looks good but I don't have an arm64 nix box to verify. I'm also not sure of the "correctness" of the way the different archs are gated (just visually comparing with other derivations in nixpkgs, not that there's not 50 different approaches 😅) - I'd suggest posting in the "PRs ready for review" thread.

This one? Done.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1053

CI seems happy now. I've tested building on aarch64 and amd64.

@ofborg build ssm-session-manager-plugin

Can you please fix the commit message to fit the contributing guide? Then ofborg would also be auto triggered.
After that we can merge this.

Can you please fix the commit message to fit the contributing guide?

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#writing-good-commit-messages
I don't see any specific convention mentioned. History makes it obvious what I should use, but perhaps an explicit mention in the docs would help? I'm very sure my previous contributions don't fit this very clear convention.

I think ofborg is happy now :relieved:

First bullet in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#submitting-changes

Thanks!

Thanks!


chore: update deprecated goreleaser option.

Summary
Replaces the deprecated replacements option according to recommendation in docs: https://goreleaser.com/deprecations/#archivesreplacements
I don't recall why the old template had a replacement for Arm. @Eric-Warehime do you know if it's needed?

@Eric-Warehime do you know if it's needed?

Not at all.


displayName set on forwardRef is not honored

Describe the bug
In styled-components v4 beta we started decorating the forwardRef wrapper with displayName and various other statics to reduce the amount of interim component layers during rendering and preserve various library behaviors. https://github.com/styled-components/styled-components/blob/30c372cf635e0db77f74c0aaacf60deda729581c/src/models/StyledComponent.js#L249-L311
However, it doesn't seem like enzyme surfaces a displayName set on a forwardRef component.
To Reproduce
See this codesandbox: https://codesandbox.io/s/yv7l2p76q9
Expected behavior
The test expectations should work since name and displayName are set on the forwardRef node.
It would be really great if this could work for a few reasons:

Shallow rendering does not currently render the immediate child of ForwardRef, so if we modified our library so the wrapped child of ForwardRef had all the statics etc it still wouldn't work without diving

The components don't show up at all when using "find" off of "mount" since ForwardRef isn't honoring displayName

Sidebar: I really wish ref forwarding was implemented as a decorator or class mixin... sigh.

Hmm, does react itself respect .displayName on a forwardRef?

@ljharb It doesn't in the devtools as of right now... but it's a weird case since it's a metacomponent thingy and doesn't have a renderable

cc @gaearon

If it doesn't show up in the dev tools, then I wouldn't expect it to make any sense to have a displayName - typically only custom components have displayNames, and forwardRef produces a special kind of component that's not a class or an SFC.

Yeah, I’m not really sure what to do about it honestly. Usage of the ref
forwarding API is incredibly awkward, but the functionality is super
compelling.
On Fri, Sep 7, 2018 at 5:58 PM Jordan Harband<EMAIL_ADDRESS>wrote:

If it doesn't show up in the dev tools, then I wouldn't expect it to make
any sense to have a displayName - typically only custom components have
displayNames, and forwardRef produces a special kind of component that's
not a class or an SFC.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/enzyme/issues/1810#issuecomment-419587905, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiy1vD5c-j1-midQWwLTBpnVl69XG4wks5uYvorgaJpZM4WflEw
.

If DevTools doesn't show it that sounds more like a bug with DevTools that we can fix.

Do React warnings show it?

I'll experiment and get back to you

@gaearon I don't believe it does:
Users/bear/code/homepage/node_modules/react-error-overlay/lib/index.js:2172 Warning: Failed prop type: The prop `fluid.aspectRatio` is marked as required in `Image`, but its value is `null`.
    in Image (created by Context.Consumer)
    in BaseStyledComponent (created by ForwardRef)     <- that should be a named component
    in article (at PostExcerpt/index.js:24)
    in PostExcerpt (at PostList/index.js:13)
    in div (created by Context.Consumer)
    in BaseStyledComponent (created by ForwardRef)

@gaearon this will be a problem with react-native too since they started doing the same thing we are: https://github.com/facebook/react-native/commit/e708010d18f938e2d6b6424cfc9485d8e5dd2800#diff-e250436371d8e58356be701ad28b37caR268

Made a PR against React to support this: https://github.com/facebook/react/pull/13615

@probablyup I'm running into the issue you're describing.
I've confirmed the changes from this PR are in my local react src.
I've created a Button that uses forwardRef.
I've set a displayName as a static property in that file.
Button.displayName = "Button"
When using find in an enzyme test - the static property displayName is not recognized.
ForwardRef is recognized.
let component = shallow(<Form {...props} />).find("ForwardRef"); <-- component found
let component = shallow(<Form {...props} />).find("Button"); <-- component not found

@jackson-sandland what version of react and enzyme and enzyme adapter are you using?

@ljharb
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>I figured out how to set the displayName but it's the Higher Order Component version of the displayName e.g. higherOrderWrapper(wrappedComponent).
Is that the best option we've got?
Can we actually get a find by the name of the wrappedComponent?

Finding by reference is preferred; so in that case, you can find by the wrapped component constructor itself.
Setting the displayName should make it show up in .debug(), but it may still be a bug that it's not findable.

It must still be a bug.
Here's the output of wrapper.debug():
'
<ForwardRef(Button) className="btn" onClick={[Function: proxy]}>
Text here
</ForwardRef(Button)>
'

@jackson-sandland would you mind filing a new issue covering all this? I'll be happy to take a look at it ASAP.


Change collections, RxList, RxMap

Change collections, RxList, RxMap and others that exist for AtomList, AtomMap...

Change collections, RxList, RxMap and others that exist for AtomList, AtomMap...

Not testing and looking at the Readme, I found the new declaration as follows:
RxList for: [].asAtom();


Run SAS Code from sasjs

run a sas code which is available in git hub from sasjs

Hi @shivakrishnay  - can you please elaborate on the exact issue you are facing?  What is it you have tried, and what are you trying to do?

We support two approaches from running SAS code from GIT.

As part of a regular SASjs project (compile/build/deploy from a GIT branch) as described here: https://communities.sas.com/t5/SAS-Global-Forum-Proceedings/Scaffolding-SAS-Projects-With-NPM-and-SASjs/ta-p/726347

Executing directly from an unsecured GIT repository using the sasjs run command as described here: https://cli.sasjs.io/run/#using-github-urls

Getting below error while ran the below code,
sasjs run github link -t sas9
ERROR  An error has occurred when running your SAS code.
Error while handling error. unable to verify the first certificate

Hi @shivakrishnay - it sounds like your github repo is using self-signed certificates.  If your admin cannot configure the correct certificates, you can try the steps listed here:  https://github.com/sasjs/cli/issues/1181#issuecomment-1090638584
Alternatively, you can add the following entry to your target your sasjs/sasjsconfig.json file (or ~/.sasjsrc if global):
      "httpsAgentOptions": {
        "allowInsecureRequests": true
      },

We are assuming that this issue is resolved - if not feel free to raise another.


Update position for radio and social links

have these reflected in the screenshots below:

specs are in zeplin

Done 32780fbb6f692af6e878652ca624ad91e773cd20 and e83eb0dbfd927de0a24a09f95f786d0637608a1c.


Can't start bot

Please tick all applicable boxes.

[x] I am using Python 3.5 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[x] The latest master version (1.9.8)
[ ] The latest review version

What type of issue are you creating?

[x] Bug
[ ] Feature request
[ ] Question

Description of issue
Can't get the bot to start running. Just tried a complete reinstall and manually updated the bot. No success.
Steps to reproduce
1.) run the command ./sudo.sh

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
musicbot.log
[39.265632629] 2018-09-18 00:07:40,122 - INFO - launcher: Starting sanity checks
[39.943695068] 2018-09-18 00:07:40,123 - INFO - launcher: Checking for Python 3.5+
[40.208578110] 2018-09-18 00:07:40,123 - INFO - launcher: Checking console encoding
[40.377140045] 2018-09-18 00:07:40,123 - INFO - launcher: Ensuring we're in the right environment
[41.342258453] 2018-09-18 00:07:40,124 - INFO - launcher: Required checks passed.
[41.675090790] 2018-09-18 00:07:40,125 - INFO - launcher: Optional checks passed.
[41.875123978] 2018-09-18 00:07:40,125 - INFO - launcher: Moving old musicbot log
######################### PRE-RUN SANITY CHECKS PASSED #########################
[124.534606934] launcher-ERROR: Error starting bot
Traceback (most recent call last):
File "run.py", line 367, in main
from musicbot import MusicBot
File "/root/MusicBot/musicbot/init.py", line 7, in
from .utils import _get_variable
File "/root/MusicBot/musicbot/utils.py", line 3, in
import aiohttp
ImportError: No module named 'aiohttp'
[126.894712448] launcher-INFO: Attempting to install dependencies...
[129.628658295] launcher-INFO: All done.

Figured it out.
Needed to use "python3.6 run.py" to start the bot.


[meta] Add labels to GH repo

I think it'd be great to have some more labels available on this repo so we can organize tasks and make it easier for people to find something they can contribute that falls within their skill set. Off the top of my head I'm thinking:

Good for Beginner (or "Good First PR", something to highlight tasks that don't require a ton of background knowledge)
Documentation
Has PR
Under Discussion

Anything else?

Ok, I made a few labels and I even created a project. I've never used a github project before, but maybe it'll be helpful! We'll see how it goes. Thanks!


Add CredentialsBinding controller documentation

How to categorize this PR?

/area security ipcei
/kind enhancement
/ipcei workload-identity
What this PR does / why we need it:
Adds the relevant documentation copied from https://github.com/gardener/gardener/pull/10327 which was recently closed.
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/9586
Special notes for your reviewer:
cc @vpnachev
Release note:

NONE

/lgtm

/retitle [GEP-26] Add CredentialsBinding controller documentation

/label ipcei/workload-identity

/lgtm
/approve


Create a way to expose members of a java object on the global scope of the script context

Hello,
I am registering certain objects that contain methods that I want to be exposed in the script using Context#putMember(name, object).
For some of these methods I want them to be exposed in a "namespace", for example:
public class IVRModuleRuntime extends ScriptModuleRuntime<IVRModule> {
    @Api
    public void say(String message) {

    }
}

should be exposed under the IVR "namespace" so I would do context.putMember("IVR", ivrModuleRuntime):
IVR.say("this is IVR");

In contrast, I'd like this module to be exposed as root functions:
public class DebugModuleRuntime extends ScriptModuleRuntime<DebugModule> {

    @Api
    public void info(String message, Object... args) {

    }
}

I want to ultimately expose at the root, so inside the script I can do:
var test = "test";
info("this is a {}", test);

I couldn't find an easy way to do this, so I came up with this:
https://gist.github.com/brentco/748be33f93e47c09c11d5a8e1b619a2a
Basically, I use reflection and  a ProxyExecutable to invoke the right method in the module runtime based on the method's name and a list of arguments. I manually try to match that up to the right method and then call it.
It seems to be working for now, but this is not something I want to rely on. I doubt it has good performance and there are probably edge cases and whatnot. So I'd like to see this being implemented properly inside the API :)

Hi @wirthi
The difference lies in how I expose all the methods. In the case where I expose an object with members under an identifier (say gets automatically exposed under IVR because I do putMember("IVR", objectThatContainsSay);. Indeed this works perfectly. However, say that I want to expose the contents of objectThatContainsSay on the root (without "IVR") then there is no way as far as I could see to expose it "automatically". Instead, I have to manually expose each thing via reflection because I cannot do putMember("", objectThatContainsSay); where then I would have say() on the root instead of under "IVR". To get around this, I have the reflection stuff that exposes each member of objectThatContainsSay so that under the hood it would do "alright there is a say method in objectThatContainsSay so let's expose it as putMember("say", proxyThatCallsSayInObject). This way I simulate the approximate behavior of doing putMember("", objectThatContainsSay);.
I hope it's clearer now!

Hi @brentco
thanks for your clarification. I better understand your usecase now. The reflection problem seems to be 100% on the side of your Java application, has nothing to do with JavaScript or the Context interface.
For the global object, yes, things are different as you cannot just modify that (and expect everything else to still work). Did you have a look at the suggestions in #44 already if you can use them?
-- Christian

Sorry, I had JUST updated my thing to be a little more clear. The reflection part is a workaround for being able to achieve the goal. It seems #44 is similar but not the same.
Perhaps explaining my use case could help as well:
I have objects in Java that contain methods that are to be exposed into the JavaScript. When I create a Context, I add all these objects into the context as members. Some of these objects I want exposed under a "namespace" such as IVR so that all the methods of those objects are under IVR.(). Other objects I want to expose in the same way, but not in a "namespace" so on the root object, so that I can call () in JavaScript.
So what I'm really asking for is a way to expose the content of a java object into the root JS object, much like you would otherwise expose that content if you put an identifier.
I don't think what is described in #44 matches with this.

If you manually do that, you can expose them to the global object. See my example above. But you have to do that for every method you make available (unlike the case where you expose an object, and all its methods are automatically recognized, i.e. your IVR.say() example). If the methods you want to expose change, you have to manually change them in the JS global object (note that this might expose the problem as discussed in #146, that you cannot delete from the global object in JS).
-- Christian

So there's no possibility that doing the same for the root object could be made? If not, then I'll have to keep my reflection proxy.


about query

Excuse me, is there no query function in ball_tree? How do I get query's nearest neighbor vector index
this is my code
my code：XX is a double* (size N*D)     X_test is double**     N is 10   D is 512
int leaf = 40;
p2h::Ball_Tree<double>* tree = new p2h::Ball_Tree<double>(N, D, leaf, XX);
tree->display();
p2h::MinK_List* list = new  p2h::MinK_List(10);
std::cout << "   nns   " << tree->nns(10, 10, 1, X_test[0], list) << std::endl;;

How  to get  X_test[0]'s nearest neighbor  index
tasnks

Thanks for your interest!
nns() only returns the number of candidates for the query, which is not the list of the NNS index.
The NN index is stored in the list in your case. You can visit methods/pri_queue.h and use the function ith_id() to get the index one by one.
Please let me know if you meet other issues. Thanks!

int leaf = 40;
p2h::Ball_Tree<double>* tree = new p2h::Ball_Tree<double>(N, D, leaf, XX);
tree->display();
p2h::MinK_List* list = new  p2h::MinK_List(10);
std::cout << "   nns   " << tree->nns(10, 10, 1, X_test[0], list) << std::endl;;
std::cout << list->max_key() << std::endl;
std::cout << list->min_key() << std::endl;
std::cout << list->ith_id(1) << std::endl;

我使用了function ith_id() ，但是它并不是我期待的返回值，我的 X_test[0]正确的最邻近索引是第五条。
还有就是 ith_id() 的输入是int类型，这个应该输入什么呀？我应当怎么使用 ith_id() 函数获取到 X_test[0]的最邻近索引（4 if index start 0或5 if index start 1）

i want to sove the problem is :
datasets    10 Vectors，the dimension is 512.  i want to build ball tree。   and   use it  to query a vector ，get its  index  （0~9/1~10）.。。。

First of all, the nns() of the ball tree returns the approximate results, not the exact ones.
The input parameter (i.e., int) of ith_id() starts from 0, which means that you should call ith_id(0) if you want to find the nearest neighbor that the ball tree found; similarly, you can call ith_id(1) if you aim to find the 2nd nearest neighbor that ball tree found. The valid range is [0, k-1].
Moreover, the returned value starts from 0, and the returned range is [0, n-1].
Besides, max_key() and min_key() mean the largest and smallest distances the ball tree found. The ith_key(i) returns the (i+1) nearest distance.
BTW, I am not clear about the dimension information of your test queries. For the problem of P2HNNS, please ensure that the query should be one dimension higher than the data. Thanks!

For the problem of P2HNNS, please ensure that the query should be one dimension higher than the data
why？？？  the data create ball  tree is  10 * 512 dimensions。the query data is 1 * 513 ？？？？？？

now   ，

First of all, the nns() of the ball tree returns the approximate results, not the exact ones.
The input parameter (i.e., int) of ith_id() starts from 0, which means that you should call ith_id(0) if you want to find the nearest neighbor that the ball tree found; similarly, you can call ith_id(1) if you aim to find the 2nd nearest neighbor that ball tree found. The valid range is [0, k-1].
Moreover, the returned value starts from 0, and the returned range is [0, n-1].
Besides, max_key() and min_key() mean the largest and smallest distances the ball tree found. The ith_key(i) returns the (i+1) nearest distance.
BTW, I am not clear about the dimension information of your test queries. For the problem of P2HNNS, please ensure that the query should be one dimension higher than the data. Thanks!

now，，in my code，
XX is a double* (size ND)     it is used to create  ball tree；
X_test is double    size  1D
N is the vector  numbers    D is  dimension
the  create tree code ： p2h::Ball_Tree tree = new p2h::Ball_Tree(N, D, leaf, XX);
find  min  distance index code :
p2h::MinK_List* list = new  p2h::MinK_List(1);
std::cout << "   nns   " << tree->nns(10, 10, 1, X_tes], list) << std::endl;;
std::cout << list->ith_id(0) << std::endl;     this is  min  index,but  my code result is   incorrect  result

Before answering your questions, I suppose I should let you know that this repo targets at the problem of Point-to-Hyperplane Nearest Neighbor Search (P2HNNS). For the problem of P2HNNS, the input datasets are data points in $R^{D-1}$ space. In this repo, I add one more dimension after loading the data, so in ap2h.h, datasets also contain $D$ dimensions. Different from the traditional point-to-point NNS problem, the queries are NOT data points but hyperplane queries that are in $R^D$ space. Moreover, the distance is not the commonly used Euclidean distance but the point-to-hyperplane distance.
So for your issue, you might first check the distance function we used is the one in your considered case; otherwise, you indeed cannot get the correct results. Second, you might check that the query (X_test) is a hyperplane query but not the direct data point. Third, the nns() only accept float* for the hyperplane query. You might change double* to float*.
Besides, although this is not your test case, I also want to clarify that this repo provides the approximate (not exact) methods for the problem of P2HNNS. Although you did all the correct things, as the ball tree we provided will not check all branches and allow approximation factor, it only provides the approximate results. Thus, it is reasonable if you cannot get the exact results.

Before answering your questions, I suppose I should let you know that this repo targets at the problem of Point-to-Hyperplane Nearest Neighbor Search (P2HNNS). For the problem of P2HNNS, the input datasets are data points in RD−1 space. In this repo, I add one more dimension after loading the data, so in ap2h.h, datasets also contain D dimensions. Different from the traditional point-to-point NNS problem, the queries are NOT data points but hyperplane queries that are in RD space. Moreover, the distance is not the commonly used Euclidean distance but the point-to-hyperplane distance.
So for your issue, you might first check the distance function we used is the one in your considered case; otherwise, you indeed cannot get the correct results. Second, you might check that the query (X_test) is a hyperplane query but not the direct data point. Third, the nns() only accept float* for the hyperplane query. You might change double* to float*.
Besides, although this is not your test case, I also want to clarify that this repo provides the approximate (not exact) methods for the problem of P2HNNS. Although you did all the correct things, as the ball tree we provided will not check all branches and allow approximation factor, it only provides the approximate results. Thus, it is reasonable if you cannot get the exact results.

Thank you very much for your reply. I have realized where my problem lies. Wish you success in your work, life and study

Ha ha, under your prompt, I just modified the distance method, now your method has been adapted to my point-to-point problem solving, and adopted your code architecture, compared with the ball tree method I used before, the ball tree construction time comparison: 91ms vs 1140ms nns time comparison: <1ms vs 23ms. Your method beats the game. Thank you

Hello, referring to your project, I have realized the functions I want to achieve, thank you.
I would like to ask you, according to your understanding of ball tree, can ball tree achieve incremental learning? My understanding is that in incremental learning, if I add a piece of data, I only need to add that piece of data to the last node and update the dimension of the number. It is not necessary to reconstruct the ball tree with (N+1) *D data.

Thank you for your assessments and your appreciation.
For the point-to-point problem you aim to deal with, you might also need to carefully set up the new lower bound (or upper bound) if you consider the approximate case, as the current lower bound I used in ball_node.h is designed for P2H distance.
For your follow-up question, my suggestion is that the ball tree can support incremental updating (or learning) if the data distribution does not change too much; otherwise, the ball tree might not be the best choice because the pivot points we have chosen for data splitting when building the ball tree will become less effective, and the ball tree might be extremely imbalanced. As such, the nns() will also become less efficient.
An alternative option is that you apply the ball tree for incremental updating (or learning) for only a short period (e.g., one week or 10 days). Then, you might reconstruct the ball tree for the whole dataset (offline) so that we could choose more promising pivots for data splitting.

Thank you for your assessments and your appreciation.
For the point-to-point problem you aim to deal with, you might also need to carefully set up the new lower bound (or upper bound) if you consider the approximate case, as the current lower bound I used in ball_node.h is designed for P2H distance.
For your follow-up question, my suggestion is that the ball tree can support incremental updating (or learning) if the data distribution does not change too much; otherwise, the ball tree might not be the best choice because the pivot points we have chosen for data splitting when building the ball tree will become less effective, and the ball tree might be extremely imbalanced. As such, the nns() will also become less efficient.
An alternative option is that you apply the ball tree for incremental updating (or learning) for only a short period (e.g., one week or 10 days). Then, you might reconstruct the ball tree for the whole dataset (offline) so that we could choose more promising pivots for data splitting.

Thank you very much for your advice. I have understood my thinking for future projects. The best wishes for you

Hello, I have a new problem in nns.
p2h::Ball_Tree* tree = new p2h::Ball_Tree(N, D, leaf, XX);
//p2h::BC_Treetree = new p2h::BC_Tree(N, D, leaf, XX);
tree->display();
p2h::MinK_List list = new  p2h::MinK_List(1)
tree->nns(1, int(N), 1, X_test[i], list);
In the case of nns, parameter int(N) has a lot of influence on the result. For example, when N=20000 in the case of tree construction, my int(N) is int(* 0.2n), so when the correct result of my test data is >4000 (0.2 * 20000 = 4000), the wrong result will appear. I have to enlarge int(N) to int(N), but that would be a brute force search, so where is my problem?

Hello, I have a new problem in nns. p2h::Ball_Tree* tree = new p2h::Ball_Tree(N, D, leaf, XX); //p2h::BC_Tree_tree = new p2h::BC_Tree(N, D, leaf, XX); tree->display(); p2h::MinK_List_ list = new p2h::MinK_List(1) tree->nns(1, int(N), 1, X_test[i], list);
In the case of nns, parameter int(N) has a lot of influence on the result. For example, when N=20000 in the case of tree construction, my int(N) is int(* 0.2n), so when the correct result of my test data is >4000 (0.2 * 20000 = 4000), the wrong result will appear. I have to enlarge int(N) to int(N), but that would be a brute force search, so where is my problem?

I change the Ball_Tree leaf the same as  int(N * 0.2) or int(N * 0.5) ,  the problem maybe solve.But  the Accuracy rate Serious decline

Hello, I have a new problem in nns. p2h::Ball_Tree* tree = new p2h::Ball_Tree(N, D, leaf, XX); //p2h::BC_Tree_tree = new p2h::BC_Tree(N, D, leaf, XX); tree->display(); p2h::MinK_List_ list = new p2h::MinK_List(1) tree->nns(1, int(N), 1, X_test[i], list);
In the case of nns, parameter int(N) has a lot of influence on the result. For example, when N=20000 in the case of tree construction, my int(N) is int(* 0.2n), so when the correct result of my test data is >4000 (0.2 * 20000 = 4000), the wrong result will appear. I have to enlarge int(N) to int(N), but that would be a brute force search, so where is my problem?

Yes, it might happen. The parameter int(N) represents the number of candidates you aim to check in this nns() function. Basically, we are only interested in k=100 NN of the query, then int(N) is only 2 to 5 times of k, e.g., [2k, 5k]. As such, nns() could be efficient as it will not need to check too many candidates. However, if you set too large for this parameter, e.g., int(N) = 0.2*n or n, then the efficiency will degrade rapidly. You might consider using a factor of k to set up this parameter rather than using a fraction of n.

But the result of my testing, for example when I was building the ball tree, was that the data was... If int cand, // number of candidates is 4000 when I conduct nns, then it can guarantee 100% correctness only when the test data is 0~4000, but when the test data index is >4000, the accuracy is 0%. So I guess int cand must >=leaf. Based on this, I conducted the test again, set leaf = 1w, int cand = 5000, and the test accuracy was less than 50%

I suppose it is not the problem of the cand setting. Basically, the sweet range of the leaf size is in between 20 to 500. In most cases, we do not suggest setting a very large value for leaf.
I suppose the reason is that the ball tree we built is designed for point-to-hyperplane distance, which might NOT be the distance (e.g., Euclidean distance) you considered for your problem. Thus, when you build a ball tree with more than a leaf, as the lower bound is not correct for your problem and you might choose a wrong branch, the accuracy degrades rapidly.
The construction of the ball tree I currently designed could also support Euclidean distance, but you use perform nns() by considering your own distance, you should carefully modify the est_lower_bound function in ball_node.h and the center preference in Lines 153-162 in ball_node.h (here, you might choose the branch that the distance (you consider, not inner product) between the center and query is closer) when traversing the ball tree from root to leaves.
I hope my suggestions could be useful for you, but directly solving your problem is out of the scope of this repo, and I do not have much free time for the indirect problem. Wish a great success for you!

I suppose it is not the problem of the cand setting. Basically, the sweet range of the leaf size is in between 20 to 500. In most cases, we do not suggest setting a very large value for leaf.
I suppose the reason is that the ball tree we built is designed for point-to-hyperplane distance, which might NOT be the distance (e.g., Euclidean distance) you considered for your problem. Thus, when you build a ball tree with more than a leaf, as the lower bound is not correct for your problem and you might choose a wrong branch, the accuracy degrades rapidly.
The construction of the ball tree I currently designed could also support Euclidean distance, but you use perform nns() by considering your own distance, you should carefully modify the est_lower_bound function in ball_node.h and the center preference in Lines 153-162 in ball_node.h (here, you might choose the branch that the distance (you consider, not inner product) between the center and query is closer) when traversing the ball tree from root to leaves.
I hope my suggestions could be useful for you, but directly solving your problem is out of the scope of this repo, and I do not have much free time for the indirect problem. Wish a great success for you!

Thank you very much for your suggestions. I hope my questions will not affect your work. I am satisfied that you can answer my questions, thank you


Bullseye integration with WeaponPack Gamma broke in 2.4.0

In Bullseye 2.4.0-rc.4.zip, the Bullseye aiming system was applied to the longbows from WeaponPack Gamma. However, Bullseye 2.4.0.zip stopped applying the new aiming system to those bows; it only applies to the vanilla bows.
The WeaponPack Gamma bows still work, but they use the vanilla aiming system.

Thank you, an update is now out to fix this issue!


Avoid disappeared _

In the resulting HTML, two continuous _ will disappear and make the fonts italic.

Thank you very much for this PR! Merged into master. I'll make a new release later today.

I'm combining this release with the integration of MCMCChains and hope to test it later today or tomorrow on Stan & cmdstan 2.19 (C++ versions).


Added target framework to netstandard2.0

Please consider adding netstandard2.0 as a target framework if you can.

I...don't understand how this compiles. The docs say IAsyncEnumerable only supports netstandard2.1 and above:

I'll do some more digging but if it's working with netstandard2.0 then I'll just downgrade to that altogether.

Welp it gets pulled in with the Microsoft.Bcl.AsyncInterfaces package (which I did not know existed). Derp. We can just target netstandard2.0 directly.

Unfortunately I have some problems compiling the project, i get the following message:
MinVer : error MINVER1007: "git" is not present in PATH.
Even though I installed git and entered the environment variable.


Vim mode has been removed

Looks like a new version of dartpad has arrived. A regression I've found is the lack of Vim mode which was added to the previous version https://github.com/dart-lang/dart-pad/issues/1361
Would be great if either it could be added again, or more realistically a toggle for the old dartpad version could be added (so we can continue to have full functionality while this new version is still in beta).

+1 for this.
Whenever I want to create a quick snippet or test a small piece of logic/code. My first instinct is to do it in dartpad. The new version has really been holding me back from consistently using it.

FYI the old version of Dartpad with VIM mode can be found at https://old-dartpad-3ce3f.web.app

This isn't too much work to implement, since Codemirror already supports Vim keybindings. See this pull request for details.

Hi @johnpryan thanks for replying with a reference PR, this would be a huge help and an exciting task to work on!

Haven't been able to work on this due to some circumstances, I am however content on implementing this in the future.
In the meantime, if somebody wants to pick it up then please do so.

@johnpryan dropping a mention for attention and review.


[web][client] handle exceptions from the server at the client side

If there is some problem on the server side or the
user does not have the proper access rights, handle
the exception returned from the server in the client,
and print some useful error messages.

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- web/client/codechecker_client/cmd_line_client.py  1

See the complete overview on Codacy


Unable to find a spec satisfying when using gemspec and bundler

When using bundler with gemspec to develop a gem, licensefinder does not detect the gem.
I first run bundle install --path=. to create the lockfile with a Gemfile:
source 'https://rubygems.org'

gemspec

It creates the following spec for the developed gem:
PATH
  remote: .
  specs:
    GEMTOTEST (1.7.1)
      GEMTOTESTDEPENDENCY (~> 4)

Then I run license_finder and it reports an error:
LicenseFinder::Bundler: is active
/var/lib/gems/2.5.0/gems/bundler-2.0.2/lib/bundler/spec_set.rb:39:in `block in for': Unable to find a spec satisfying GEMTOTEST (>= 0) in the set. Perhaps the lockfile is corrupted? (Bundler::GemNotFound)
	from /var/lib/gems/2.5.0/gems/bundler-2.0.2/lib/bundler/spec_set.rb:21:in `loop'
	from /var/lib/gems/2.5.0/gems/bundler-2.0.2/lib/bundler/spec_set.rb:21:in `for'
	from /var/lib/gems/2.5.0/gems/bundler-2.0.2/lib/bundler/spec_set.rb:79:in `materialize'
	from /var/lib/gems/2.5.0/gems/bundler-2.0.2/lib/bundler/definition.rb:170:in `specs'
	from /var/lib/gems/2.5.0/gems/bundler-2.0.2/lib/bundler/definition.rb:237:in `specs_for'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/package_managers/bundler.rb:62:in `gem_details'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/package_managers/bundler.rb:47:in `details'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/package_managers/bundler.rb:15:in `current_packages'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/package_manager.rb:97:in `current_packages_with_relations'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/scanner.rb:17:in `each'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/scanner.rb:17:in `flat_map'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/scanner.rb:17:in `active_packages'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/core.rb:83:in `current_packages'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/core.rb:78:in `decision_applier'
	from /usr/lib/ruby/2.5.0/forwardable.rb:223:in `acknowledged'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/license_aggregator.rb:51:in `block in aggregate_packages'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/license_aggregator.rb:49:in `each'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/license_aggregator.rb:49:in `flat_map'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/license_aggregator.rb:49:in `aggregate_packages'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/license_aggregator.rb:11:in `dependencies'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/lib/license_finder/cli/main.rb:139:in `report'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /home/licenses/.bundle/lib/ruby/2.5.0/gems/license_finder-5.9.1/bin/license_finder:6:in `<top (required)>'
	from /home/licenses/.bundle/bin/license_finder:29:in `load'
	from /home/licenses/.bundle/bin/license_finder:29:in `<main>'

license_finder seems to not understand the spec remote:.

Nevermind. My custom Docker image messed up between the Gemfile to install license_finder and the Gemfile to test.


fix: Add resolve action to allowed gateway rules

Description
Resolver policies require the policy action to be "resolve", which was not allowed before this change.
Has your change been tested?
Tested through use in the terraform provider locally
Types of changes
What sort of change does your code introduce/modify?

[*] Bug fix (non-breaking change which fixes an issue)

Checklist:

[* ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

I don't understand the changelog bot, there is very clearly a changelog included in this pr

Didn't realize the changelog number had to match the PR number. Good to know


PDP: Update roles with permissions for members

Describe this PR
Add lines for the permissions to view, add, remove, modify team members in PDP.
Changes

Changes to user-roles.mdx

What issue does this fix?
n/a

This was resolved with #4356. Closing.


GSE Hijacking chat function

So any time I try to press enter, the " / " key, click a name, or even hit send message from my friends list GSE instead spams ~Keypress~ in chat. I can't type in game in any capacity because of this. It won't let me send any messages anywhere to anyone because of this.

Hi.
What version of GSE are you using? In case you are using GSE 3.0.13:
On the GSE window, click OPTIONS, then on the OPTIONS window, go to Debug, then disable "Display Debug Messages in Chat Window".

I did this and enabled all parts, but it's not displaying anything in the chat window. Just keeps spamming Keypress.

I opened the debug sequence frame and it's not showing any bugs there either. I have replicated the bug by just spamming the macro. The only cure is to reload the UI, then as soon as I use the macro again it takes over the chat function again. It also disables my ability to use the LFG tool.

I would be checking your KeyBindings.  GSE "cant" do anything without a
hardware event telling it to do something and even then it can only do what
your macro tells it to tell WoW to do.  With the information supplied (No
steps to reproduce, no screenshots, no GSE.lua file to test, no macro
export strings, no description of OS or game version) I can only suggest
going through the basics.
The things to do:

Check your keybindings
Check your macro.  Is it casting your macro or saying your macro if
its saying you need to check the actions.
Disable all mods and enable GSE - does the problem still exist??
If 2 is fine then you have another mod that is breaking GSE.  Need to
find out which mod it is.  (Known mods which currently have issues with GSE
are ElvUI on BCC.- see #830)

If the problem is in #2 then you need to understand that GSE is a very low
level tool.  It doesnt DO anything nor does it know how to check anything.
All it does is take a list of commands and sends them to WoW.  If the
commands are going to break WoW, GSE assumes that you as the operator know
why you would want to do that.  It really is Garbage In, Garbage Out.
Outside of that I really need a ton more information.  As it stands all I
can say, again with respect and sympathy, is you is it sounds like you have
a "macro problem and might want to fix that".
On Sat, 3 Jul 2021 at 21:12, xan2622 @.***> wrote:

Hi.
What version of GSE are you using? In case you are using GSE 3.0.13:
On the GSE window, click OPTIONS, then on the OPTIONS window, go to Debug,
then disable "Display Debug Messages in Chat Window".
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/922#issuecomment-873394761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMCFMKUJ2EGZ7XBDRE35TTV3ZSPANCNFSM47YCAS4Q
.

--
TimothyLuke

The other thing to check for is a Mod having the same or similar name to a Macro.  GSE creates a series of "buttons"  If another mod changes that button (which GSE cant prevent) you may have some very weird things like this happen.

This may not be the issue but if you have a variable in the macro but no variable exists that matches the name below in the variables section you macro will literally say the variable name.  Eh if you have ~~MyVar~~ and you don’t have a variable matching the case of MyVar it will literally say “~~MyVar~~”

closing this out for now as no further information


Dart Analyzer Error Encountered a Dart Analysis Server error.

Analyzer Feedback from IntelliJ
Version information

IDEA AI-192.7<IP_ADDRESS>92135
2.8.2
AI-192.7<IP_ADDRESS>92135, JRE 1.8.0_212-release-1586-b04x64 JetBrains s.r.o, OS Windows 7(amd64) v6.1 Service Pack 1, screens 1600x900

Exception
Dart analysis server, SDK version 2.8.2, server version 1.27.4, FATAL error: NoSuchMethodError: The getter 'isEof' was called on null.
Receiver: null
Tried calling: isEof
#0      Driver._captureExceptions.errorFunction (package:analysis_server/src/server/driver.dart:720:7)
#1      _CustomZone.handleUncaughtError (dart:async/zone.dart:1059:19)
#2      _CustomZone.runGuarded (dart:async/zone.dart:981:7)
#3      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1019:23)
#4      _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#5      _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#6      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#7      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:405:11)
#8      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
#9      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

For additional log information, please append the contents of
file://C:\Users\Kunal\AppData\Local\Temp\report1.txt.

Thanks for reporting this issue! This was previously reported in https://github.com/dart-lang/sdk/issues/40223. Please follow along there.

Duplicate of https://github.com/dart-lang/sdk/issues/40223


Address the "filtering by related things" problem

Let's say you have a list posts with a related field author (that links to the authors list). Currently, the "simple search" functionality (#319) available from the admin UI won't dereference this relationship. So if you filter by "Jane" in the admin UI, you'll only get posts with "Jane" in the name, not posts where the author has "Jane" in their name.
Ideally, Keystone would be able to apply these "simple search" filters to related collections and apply them to items in the list being viewed.
Note, this functionality is closely related to, and dependant on, the "Implement configurable search fields" (#343) but is a distinct piece of work.

Closing as dupe. Moved all information here over to #352


Release azure-cli-cdn 0.0.3

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Started releasing azure-cli-cdn 0.0.3...

Release of 'azure-cli-cdn' with version '0.0.3' successful. View at https://pypi.python.org/pypi/azure-cli-cdn/0.0.3.

GitHub release created. https://github.com/Azure/azure-cli/releases.


Extended stock info access of cart items

Add possibility to access stock info of cart item, not only is_in_stock.
What is the motivation for adding / enhancing this feature?
For example, in magento in product settings you can setup backorder property. So if you want in custom theme to print in cart a special label if product will be backordered (stock.qty <= 0 && stock.backorders > 0) you need to access theese properties.
Can you complete this feature request by yourself?
For now i simply added "stock: event.result" to product object passed to  "cart/updateItem" action in stockAfterCheck event in file core/modules/catalog/store/stock/actions.ts. But i'm not sure either it proper way or not.
#1751 seems related.

Hey! yeah, this makes perfect sense- please propose a PR to the core with this change. Please also take a look at the filterOutUnavailableVariants (Find in Files) which may be useful - and it's also updating product.stock but not in the cart (reference code)

Hello, i created pull request.
Also i enabled products.filterUnavailableVariants option and tested filterOutUnavailableVariants. If qty is zero but backorders are enabled, magento returns is_in_stock = true, so this method does not remove zero quantity childs with backorders.

@Cheeerd cool! Please go forward with next core extensions, you did a great job and cool feedback :) Custom attributes are being indexed - but by default they're indexed as a product/child properties and not under the custom_attributes (https://github.com/DivanteLtd/mage2vuestorefront/blob/c71788e1c918225685344657f9d6ca0b2417d801/src/adapters/magento/product.js#L424)

I also noticed that when stock item is saved to cache, the backorders property is not saved with it. I think it may be useful to save it too. But im afraid, that vuestorefront could be connected with another backend except magento, and there are this property may not exist or named differently.
https://github.com/DivanteLtd/vue-storefront/blob/84993c719af720042f44bb492f4374527623c003/core/modules/catalog/store/stock/actions.ts#L51

Good point. As long as you keep these minimal fields included it’s safe with other platforms. We’ve just stored the most fundamental data into cache as the rest was not required by the filter out of the stock variants feature

Hi @Cheeerd are you adding this cache extension in here or are we good to close this issue? I’m closing it for now and please do reopen when needed


Add btnLabelType in MediaLibrary

These changes allows to show custom label for type in media library button

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

See https://github.com/area17/twill/pull/279#issuecomment-496571894

See https://github.com/area17/twill/pull/277#issuecomment-523464051


hsky_ur5_moveit gazebo inertial not stable

Hi,
I am simulating husky_ur5_moveit package in ROS indigo following this tutorial but its inertial parameters are not stable. Whenever I start the simulation with the ur5 arm the husky always tips over as you can see in this image.
I also tried to move the husky in its natural position (its four wheels on the ground) and then run the stow script to home the arm but then the husky again tipped over.
It is not the first time someone reported this behavior. As you can see here
Please let me know if you need more information.
I'm using the newest version.
Best,

FYI @tonybaltovski sounds the Husky intertial params could use some tuning.
@TheDash, did you see this when you were developing the moveit config/demos?

One option for moving the laser around is via environment variables (http://wiki.ros.org/husky_bringup/Tutorials/Customize Husky Configuration#Environment_Variables)
I'll have to leave it with @TheDash to comment on the moveit configuration.

@andrestoga @paulbovbel @TheDash
The inertial stability remains an issue for me in simulation. I adjusted the decorations.urdf.xacro to remove the front bumper and moved the lidar to its position in husky.urdf.xacro. As shown in the image below. In addition, I increased the husky's mass and proportionally the inertia in each direction.

While the robot spawns in the correct position now and stability overall improved, the husky turns right very slowly over time. In addition, any movement of the arm outside the bounds of the top_plate has a tendency to cause a lot of motion of the base. After observing the husky's behavior in simulation, I believe the issue could be caused by the ur5_arm_shoulder_lift_joint. As the majority of the motion occurred when the two link don't appear to be connected properly as in the image below. Any suggestion you can give on fixing this issue would be appreciated.

Thank you for your time and attention to this matter. Have a great week. God bless.
Very Respectfully,
CMobley7

The inertial stability remains an issue for me in simulation. I adjusted the decorations.urdf.xacro to remove the front bumper and moved the lidar to its position in husky.urdf.xacro. As shown in the image below. In addition, I increased the husky's mass and proportionally the inertia in each direction.

For best stability - I always just used laser_enabled:=false. However, that shouldn't have to be the case.

While the robot spawns in the correct position now and stability overall improved, the husky turns right very slowly over time.

I've noticed this too.

As the majority of the motion occurred when the two link don't appear to be connected properly as in the image below. Any suggestion you can give on fixing this issue would be appreciated.

I'll check what changing the position of the UR5 does. It looks like it may be too far off of the platform, causing all of this drifting and swaying.

@TheDash,
I measured the physical top_plate on our Husky and its dimensions were .825 m x .620 m x .006 m. However, the STL provided here has the top_plate dimensions as  .73 mm x .59 mm x 0.01 mm. I made a new top_plate with the physical dimensions above and exported it as an STL and DAE. I replaced the top_plate files in husky_description and expected to have to change the import size in the urdf. However, strangely it imported with the correct size. Now, the ur5_arm position match's on the physical and simulation Husky. However, the Husky now moves around erratically regardless of what is enabled. In an empty world, it will spawn as seen in the picture below and move around. I'm going to adjust my part later today from m to mm and see if this has any effect. Any additional ideas? Did changing the position of the ur5_arm in your urdf have any effect on the Husky's motions while the ur5_arm was moving?

@TheDash,
Adjusting it from m to mm fixed the erratic movement on startup. However, the adjusted plate dimensions had no effect on the stability that I can see. Any suggestions?
Thank you for your time and attention to this matter. Have a great weekend. God bless.
Very Respectfully,
CMobley7

Closing to due inactivity, please feel free to reopen if the needed.


[ENHANCEMENT] refactor uninstall-controller to use structured logging

We want to have consistent and structured logs to improve the ability to filter and analyse longhorn-manager logs.
Currently the controller uses the global logrus package logger, the task here would be to switch the log calls to the instance logger that was implemented in longhorn/longhorn-manager#661
While doing this also improve the log messages, where possible.
For an example of a successful completion of this task have a look the engine-controller refactor at longhorn/longhorn-manager#662

community contributed by @c3y1huang in longhorn/longhorn-manager#706


Infinite reload issue with chrome browser

Try to run the app with my KeyCloak Setup. It works fine with with all other browser except Chrome. After authentication it reloads again and again.

This is not related to this demo, as this might be an issue with Chrome or the Keycloak JS library, which had a bug in one of the previous versions. Please refer to the official Keycloak documentation or the mailing-list, if the issue still occurs.

@Joban1992 I'm having the same problem with the reloads, what exactly did you fix? Every 10 seconds or so I get an alert saying authenticated
    const keycloak = Keycloak(       {         url: "/auth",         realm : "...",         clientId: "...",         resource: "...",         'public-client': true,         'ssl-required': "none"       }     );     keycloak.init({ onLoad: "check-sso" }).success(function(authenticated) {       alert(authenticated ? 'authenticated' : 'not authenticated');     }).error(function() {       alert('failed to initialize');     });   }

The way to fix this w/o changing code is to init it like this.  keycloak.init({onLoad: 'login-required',"checkLoginIframe" : false})
where checkloginiframe is disabled

Thanks @djmason9 . It worked!

The way to fix this w/o changing code is to init it like this. keycloak.init({onLoad: 'login-required',"checkLoginIframe" : false})
where checkloginiframe is disabled
@djmason9 i came across this infinite reload recently , i used your technique to solve this issue. but same code was working fine without adding [checkLoginIframe" : false] !! any idea why sudden it started refreshing the page ?

any idea why sudden it started refreshing the page ?

I just started getting this issue too. It was working fine until Chrome crashed recently and I restarted (rarely restart Chrome) and it pulled some updates. I'm wondering if it's related to Chrome's recent SameSite changes. Based on my logs, the token is received from Keycloak after login, but after redirect back to my app page, the refresh of the token fails with a 400 error. And this cycle repeats over and over.
(!) A cookie associated with a cross-site resource at https://mykeycloak/ was set without the SameSite attribute. It has been blocked, as Chrome now only delivers cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
[KEYCLOAK] Estimated time difference between browser and server is 0 seconds
(3) [KEYCLOAK] Refreshing token: token expired
(x) POST https://mykeycloak/auth/realms/myrealm/protocol/openid-connect/token 400
(!) [KEYCLOAK] Failed to refresh token

The way to fix this w/o changing code is to init it like this. keycloak.init({onLoad: 'login-required',"checkLoginIframe" : false})
where checkloginiframe is disabled

excellent


patternProperties failing

Hello.
I'm using this code from validictory tests:
import validictory
schema = { "patternProperties": {"[abc]": {"type": "boolean"}}}
data = { "a":True, "d":"foo"}
validictory.validate(data, schema)

If I understand correctly, it should not validate this because d is not in [abc] and value type of d is string, not boolean. Homewer, it validates fine. I'm using validictory 1.0.0 from PyPi

I think you want additionalProperties: false - look here for an example
http://json-schema.org/example2.html
On Tue, Apr 28, 2015 at 7:20 AM, Ruslan<EMAIL_ADDRESS>wrote:

Hello.
I'm using this code from validictory tests:
import validictory
schema = { "patternProperties": {"[abc]": {"type": "boolean"}}}
data = { "a":True, "d":"foo"}
validictory.validate(data, schema)
If I understand correctly, it should not validate this because d is not
in [abc] and value type of d is string, not boolean. Homewer, it
validates fine. I'm using validictory 1.0.0 from PyPi
—
Reply to this email directly or view it on GitHub
https://github.com/sunlightlabs/validictory/issues/87.

--
James Turk
Labs Director | Sunlight Foundation http://www.sunlightfoundation.com/
202-558-8723 | @JamesTurk https://twitter.com/jamesturk
[image: Sunlight Foundation] http://sunlightfoundation.com/

Oh, looks like it works with test code, so I'll try with my real code. Thank you and sorry for false alarm.

No problem, thanks!


Remove weird api that will be refactored soonish

This PR removes the asymmetric crypto api. This is done because it will be refactored soon and we want to avoid that it is already used.

Unfortunately this drops the tests, which I think we should keep. Let's revert the commit instead, since we should be doing a better job of documenting API changes anyway and the change was an API & ABI break.


Fix Yarn's "unmet peer dependency" warnings with explicit top-level dependencies in subpackages

What problem does this feature solve?
When installing with Yarn, a Vue CLI 3 project currently emits a lot of warnings:
warning "@vue/cli-plugin-babel ><EMAIL_ADDRESS>has unmet peer dependency "webpack@>=2".
warning "@vue/cli-plugin-e2e-cypress ><EMAIL_ADDRESS>has unmet peer dependency "eslint@>= 3.2.1".
warning "@vue/cli-plugin-eslint ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@vue/eslint-config-prettier ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@vue/eslint-config-standard ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@vue/eslint-config-standard ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>- 4.x".
warning "@vue/eslint-config-standard ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@vue/eslint-config-standard ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^4.0.0".

This is confusing for users, many of them interpreting these warnings as an error or sign that they've done something wrong.
What does the proposed API look like?
Neutrino solved this problem by duplicating dependencies in subpackages, so I recommend we do the same. It's a little bit of a pain, but if it saves every Yarn user from a confusing experience, I personally think it's worth it.

The default vue create process actually filters out the warnings.
Some cases also isn't entirely cost-free (e.g. the eslint-plugin-cypress case, the user may use the Cypress plugin without ESLint, so adding eslint as its dep doesn't make sense) - which means we can't entirely get rid of the warnings even if we want to.


[BUG] Extraneous run execute

Describe the bug
The following code segment will have a run execute in the compiled output, which should be optimized out.
To Reproduce [Steps to reproduce the behavior]
Compile the following code in JMC or on try-out
execute as @e[type=axolotl,tag=tf2.new,tag=tf2.no_respawn] expand {
    tf2.batch_number:@s = execute on passengers
                          run tf2.batch_number:@s
                        = index::i * 1.0;
    team join player_motion.no_collide;
    tag @s remove tf2.new;
}

Expected behavior [A clear and concise description of what you expected to happen.]
I expected it to compile to
execute as @e[type=axolotl,tag=tf2.new,tag=tf2.no_respawn] store result score @s tf2.batch_number on passengers store result score @s tf2.batch_number run data get storage tf2:index i 1.0
execute as @e[type=axolotl,tag=tf2.new,tag=tf2.no_respawn] run team join player_motion.no_collide
execute as @e[type=axolotl,tag=tf2.new,tag=tf2.no_respawn] run tag @s remove tf2.new

Actual behavior
Instead, it compiles to
execute as @e[type=axolotl,tag=tf2.new,tag=tf2.no_respawn] run execute store result score @s tf2.batch_number on passengers store result score @s tf2.batch_number run data get storage tf2:index i 1.0
execute as @e[type=axolotl,tag=tf2.new,tag=tf2.no_respawn] run team join player_motion.no_collide
execute as @e[type=axolotl,tag=tf2.new,tag=tf2.no_respawn] run tag @s remove tf2.new

Note how the first line contains a useless run execute.
Screenshots

Desktop

2022 M2 MacBook Air running MacOS Sonoma 14.4.1

Fixed in 76990b04a57c2be59061e83c10d4ca55a84ca848


Add selected template as defined in CakePHP 3.9

Update the template array in FormHelper, added in 3.9 in cakephp/cakephp#13686
Otherwise it throws a RuntimeException when using MultipleCheckbox

Right.
But should be added in

https://github.com/Holt59/cakephp3-bootstrap-helpers/blob/v4.0.3/src/View/Helper/FormHelper.php
https://github.com/Holt59/cakephp3-bootstrap-helpers/blob/cake4-bs4-1.0.0/src/View/Helper/FormHelper.php

Yes, those should be in another commits, as I'm using cake 3 with bootstrap 3.
Maybe cherry-pick the commit?

These cannot be cherry-picked directly due to conflicts. I can make the change myself to the other branches but you can open PRs if you want to keep authorship on this.

Thank you.
Nevermind about authorship, its just a line.
Maybe you should make a release with this fix? In the meantime it can be fixed by adding the line in the project's AppView


Routing to Controller Actions

ASP.NET MVC -> Controllers -> Routing to Controller Actions

Relationship to middleware (#61)
Startup code and relationship to MVC route handler
Attribute routing

[Route], [Http*]
Routes on controller vs actions
Inheritance
Token replacement in route templates ([controller], [action], [area])
Custom route attributes using IRouteTemplateProvider
Pointer to using Application Model to customize attribute routes

Conventional routing

Mapping of action/area/controller maps to a controller action (action selection)

Action constraints

HTTP method constraints
Custom constraints

cc @ssargent

Is there going to be any way to create route configuration files that point directly to controllers?  There still seems to be quite a heavy focus on attribute routing.  This ticket explains some of the things I'd hope to see made available.

Some existing content we might leverage:  http://www.asp.net/web-api/overview/web-api-routing-and-actions/attribute-routing-in-web-api-2

@danroth27 - I meant, not using attribute routing.  "route configuration files that point directly to controllers".
Attribute and in-code routes are a somewhat dated practice compared to what other mature frameworks out there are doing.

This is about documenting the existing features. Use that ticket to further ask for things but this issue isn't  about adding new features.

o_O

Initial content in PR: https://github.com/aspnet/Docs/pull/602

Any way to map routes in a separate file / class? @danroth27 @atrauzzi

I have searched everywhere for some content on how to handle custom inline route constraints in MVC 6. Are they still in?

When you say custom, you mean beyond the ones that are available here?
https://github.com/aspnet/Routing/blob/1.0.0-rc1/src/Microsoft.AspNet.Routing/RouteOptions.cs

Any updates on this issue? I would appreciate some documentation on this topic :) ... would older documentation work until then?

It's in progress

I'd be happy to be a test-subject for your documentation when you feel it's ready.  I'm about 200 hours into working with MVC/webapi after about 25 years of software engineering experience<EMAIL_ADDRESS>

fixed by https://docs.asp.net/en/latest/mvc/controllers/routing.html


revert fixtures db change

This fixes https://github.com/symfony/demo/issues/998
The issue was that the fixture db data contained user passwords using argon2 encoder algo which is not implemented in php 7.1 afaik. So authentication failed in the tests.
So this reverts the db changes done in https://github.com/symfony/demo/commit/6c32238022bb0666f06d04a2b527b803591f799b.
Build is green now :wink:

Great detective work! Thank you so much David. It's great to see all tests green again 💚


Remove rubocop:disable comments from exercises/

Addresses issue "Remove rubocop magic comments from user facing files #385" for the rest of the files within exercises/
Rubocop still shows no errors with these inline comments removed.

Awesome! Thanks. :heart:
Happy Hacktoberfest!


Ctrl + dot prints a weird underlined e character

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.90.0
OS Version: Linux x64 6.5.0-35-generic (Ubuntu 22.04)

Steps to Reproduce:

open any file
hit Ctrl + . (will print the weird character)
hit Ctrl + . again (will remove it)

I noticed this is happening when trying to do a quick fix action. you can hover over the error and trigger the quick fix manually but it's pretty annoying atm. I thought there is a conflict between keyboard shortcuts, removed everything else using Ctrl + dot other than quick fix, but it's still like that.

It doesn't happen in 1.90.1

For me it happens in 1.90.1


Team configurations wiki page

@zoeself register

@zoeself register

@h1alexbel I've just registered this ticket as a task and will assign it to someone soon. Thanks!

@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2023-09-20T16:19:02.062913.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Update pipeline generation yaml

Updates the yaml to work with the new changes made in https://github.com/Azure/azure-sdk-tools/pull/4969

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Cannot read properties of null (reading 'length') when initializing firebase on node 20.11.0

Environment

Operating System version: Ubuntu / Mac OS
Firebase SDK version: 12.0.0
Firebase Product:  database,
Node.js version:  20.11.0
NPM version: v10.2.4

Describe the problem
After an upgrade from node 20.10.0 to 20.11.0 an exception occurs when initializing firebase, reverting back to 20.10.0 solve the issue
Steps to reproduce:
Stat a nodeJS process and initialize the connection to Firebase
Relevant Code:
    admin.initializeApp({
      credential: admin.credential.cert({
        projectId,
        clientEmail: email,
        privateKey,
      }),
      databaseURL: databaseUrl,
    });

Exception with node 20.11.0
/Users/jeromecurlier/Development/Aura/Services/ContentService/node_modules/stream-shift/index.js:16
    return state.buffer[0].length
                           ^

TypeError: Cannot read properties of null (reading 'length')
    at getStateLength (/Users/jeromecurlier/Development/Aura/Services/ContentService/node_modules/stream-shift/index.js:16:28)
    at shift (/Users/jeromecurlier/Development/Aura/Services/ContentService/node_modules/stream-shift/index.js:6:99)
    at Duplexify._forward (/Users/jeromecurlier/Development/Aura/Services/ContentService/node_modules/duplexify/index.js:170:35)
    at PassThrough.onreadable (/Users/jeromecurlier/Development/Aura/Services/ContentService/node_modules/duplexify/index.js:136:10)
    at PassThrough.emit (node:events:518:28)
    at emitReadable_ (node:internal/streams/readable:832:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:81:21)

Node.js v20.11.0

Removing node_modules andpackage-lock.json seems to have resolved the issue

Looking at the logs, it seems to be an issue in one of your dependencies (unrelated to firebase-admin). Closing this as it looks like you have resolved the issue.


Inline loader doesn't load translation when pipe is passed to content projection

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
Passing transloco pipe usage as content projection to other component with transloco pipe usage, when both components use inline loaders, leads to no translation for th first one
Expected behavior
Both translation work
Minimal reproduction of the problem with instructions
Demo https://stackblitz.com/edit/transloco-inline-loaders-content-projection?file=src%2Fapp%2Fapp.component.html

app component has a translation for the app.text key
hello component has a translation for the hello.text key
both components load translations inline via providing TRANSLOCO_SCOPE token and use transloco pipe to translate
app's text is passed to hello component's content projection
no translation for app.text
uncomment <!-- {{ 'app.text' | transloco }} --> in app.component.html and both translation works well

What is the motivation / use case for changing the behavior?
This should work ¯_(ツ)_/¯
Environment
Stackblitz

Angular version: 10.1.3

Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

Furthermore where is even an issue with passing translation via input.
Same example, but using input instead of content projection
<hello [title]="'app.text' | transloco"></hello>

No translation for app.text 😶
https://stackblitz.com/edit/transloco-inline-loaders-input?file=src/app/app.component.html

@artaommahe in your hello.component change the providers to viewProviders.

@shaharkazaz O_o never saw this thing in the wild.. thx. Looks like this should be added to the inline loaders docs page to avoid further issues like this one

@artaommahe I'll add a reference for it in the FAQ or the inline loaders docs when I have the time.


Fix a format for echoed string

Now each linter use its own format for the echoed message, so it will be great to decide and specify only one format to use.
IMHO something like that will be good:
When we know the severity
:[linter-name] Severity - Text

And when we don't know:
:[linter-name] Text

Note that the 1st letter of severity/text is in capital.
I'm thinking that linter-name can be helpful for the file types using multiple ones.
@w0rp If you agree, I can make a PR.

Yeah, sounds good. I think there should be some options for enabling/disabling the linter name and the severity. I suppose there would only be two severity values at the moment, "Error" and "Warning." I'd set the linter names and the Severity to be off by default, and explain the new flags in the README and the new help file.

These kinds of messages will be especially helpful once quickfix support is in.

Most of the time, only 'Error' and 'Warning' are reported by linters (Sometimes 'Style') so yes, those two are enough.

I've already started to work on this, and the severity + type are already done (Disabled by default and configurable).
But for the linter, I still don't know where can I get the name of the current used one.
Temporary, I've added a key name to be returned with the output of linter handlers, then added it to g:ale_buffer_loclist_map and that works. But I think that is not a good way to proceed.
Any idea?

You'll have to associate each warning/error with each linter, as more than one linter could be run for the same buffer. I'd try adding a key to each of the loclists returned by the Handle functions which maps to the linter name the warnings and errors are for, and see if that breaks setting the loclist at all. If it doesn't, then you should be able to read that key in the echo functions to get the linter names.
I'm thinking of something like this in s:HandleExit.
for item in linter_loclist
    item.linter_name = linter.name
endfor

I'd try adding a key to each of the loclists

Try that. Make a branch where we'll work.

Check out the echo-string-format branch. I added the linter_name key as described, and everything seems to work fine with it being there. Now you should be able to run through the items from g:ale_buffer_loclist_map and get the type and linter name from there.

Great thanks. I'll come with something tomorrow.


Verify Clean Up ODS Deployer Post-Migration

Signed-off-by: Pablo Felix Estevez Pico<EMAIL_ADDRESS>

LGTM..apart from above comment

@pablofelix Could you link the jenkins job  where this was tested?

https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-test-pr/23/robot/


Can't build on Debian Testing

I'm getting errors with asciidoc when building. My asciidoc version is 8.6.9-3
$ make
[  1%] swaygrab.1
a2x: WARNING: --destination-dir option is only applicable to HTML based outputs
a2x: ERROR: "xsltproc"  --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0  "/etc/asciidoc/docbook-xsl/manpage.xsl" "/home/david/git/sway/build/bin/swaygrab.1.xml" returned non-zero exit status 127
swaygrab/CMakeFiles/man-swaygrab.1.dir/build.make:60: recipe for target 'bin/swaygrab.1' failed
make[2]: *** [bin/swaygrab.1] Error 1
CMakeFiles/Makefile2:665: recipe for target 'swaygrab/CMakeFiles/man-swaygrab.1.dir/all' failed
make[1]: *** [swaygrab/CMakeFiles/man-swaygrab.1.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

Oops. I had not installed xsltproc


Disable VS tests that fail randomly

These tests fail occasionally. Seems like this was a known issue and they tried to "fix" it by adding a retry but apparently that isn't fully solving the problem : https://github.com/microsoft/vscode/issues/78602
Just disabling them for us since our need for running the core vs tests is low.

Coverage remained the same at 34.576% when pulling 88a2a6dba1e80b4f5b2dabec39590c4a287d1509 on chgagnon/disableTests into a7110d89160e25cf914030dd467f3d85c0292692 on master.

Didn't we have a discussion before on not running the vscode tests as part of our regular tasks? I thought we were only supposed to run these on the merge from vscode commits.

I think we can also make it so these tests are only run if there is a code change in the vs path?

Not sure, but regardless if they're going to fail randomly shouldn't we disable them anyways? I guess it doesn't matter as much if we just use them for signoffs or something since we can just re-run but in general I think it's fine to just trust that the VS stuff is working since it's pretty unlikely we're going to be making changes for something like this anyways.

@Charles-Gagnon yeah i guess, it's more so we get really no benefit from running the vscode tests at all except when we do a merge from vscode. I remember when we kept having our builds fail because of vscode tests.

We do get benefit from running their tests since we have a lot of changed in their code. Running their tests ensures we aren't breaking the assumptions they are making about their code. The idea that we just disable tests when they fail isn't right in my opinion since they are failing for a reason. But we just don't have the time to investigate why they are failing. I don't think this means in general we just should ignore their tests.

So we definitely shouldn't disable their tests completely - for the reasons that Anthony stated. But this set in particular I've seen fail numerous times and as the linked issue I included indicates this is something VS Code themselves has seen but apparently doesn't seem to think is worth fixing completely.
I'm going to merge this in since I don't hear any strong objections but if anyone has any better suggestions on what to do please let me know.


builder: Fix cleanUp

instance_ufo and master_ufo should be deleted when cleanUp is set to true. Fixes https://github.com/googlefonts/gftools/issues/290#issuecomment-768457334

I'm having some doubts about the current implementation.
Currently, we will end up deleting source files if the project is ufo based and they are stored in the dirs master_ufo etc. I think we need to check what type the sources are first, then run the clean up operations which are suitable for the file type. I'll add this now.

I'm having some doubts about the current implementation.
Currently, we will end up deleting source files if the project is ufo based and they are stored in the dirs master_ufo etc. I think we need to check what type the sources are first, then run the clean up operations which are suitable for the file type. I'll add this now.

@moyogo I've changed the implementation so it will cleanUp regardless of what source format is used. Can you review this please? (I'm not able to select you as a reviewer)

@moyogo I've changed the implementation so it will cleanUp regardless of what source format is used. Can you review this please? (I'm not able to select you as a reviewer)

@m4rc1e LGTM I'm sorry I didn't get those folders earlier but now I do. Good catch on the already existing folders.

Thanks Denis!