Backend deployment stuck on "Extracting Cache"

Environment information
System:
  OS: macOS 13.3.1
  CPU: (10) arm64 Apple M2 Pro
  Memory: 91.20 MB / 16.00 GB
  Shell: /bin/zsh
Binaries:
  Node: 20.0.0 - ~/.nvm/versions/node/v20.0.0/bin/node
  Yarn: 4.1.0 - ~/.nvm/versions/node/v20.0.0/bin/yarn
  npm: 9.6.4 - ~/.nvm/versions/node/v20.0.0/bin/npm
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/backend: Not Found
  @aws-amplify/backend-cli: Not Found
  aws-amplify: Not Found
  aws-cdk: Not Found
  aws-cdk-lib: Not Found
  typescript: 5.3.3
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
Hi,
I'm pushing my app in staging phase and, after some deploys, one got stuck at "Extracting Cache" phase during 30 minutes (normal full deploy time is around 5/10 minutes).
Context:

The previous deploys were ok
I pushed 2 times in a few minutes before this happens (maybe its related, due to the 2 deploys planned)

it highlights some issues with the CI/CD:

This is unclear why this happens, and i've no way to investigate it
Deploys are not canceled by subsequent deploys (if i push 5 times, should i make 5 deploys ?)
We are unable to cancel a deploy, it's really bad because in this case i had to destroy the full app (i am not in production yet)

your view additional logs from cloud formation, apart from that on amplify site you view logs for each deployment.

@blinkdaffer yes i can view the logs on Amplify, but the only log i've is that its "Extracting Cache" (which is a pipeline thing) and this happens before i run cloudformation

Hey @JJK801, could you provide us the AppID and the build number?

@ykethan as mentioned, i had to delete my app to kill the build.
App ID was d1suwdedpi40c and it was the last running build (another was waiting) of this app

@JJK801 👋 , since the Amplify app d1suwdedpi40c has been deleted we cannot review the logs for it. Are you currently blocked and are observing a similar behavior with a different Amplify app? If yes, can you share the app id?
Here are some insights on the additional queries:

Deploys are not canceled by subsequent deploys (if i push 5 times, should i make 5 deploys?)

Today, each commit on a git branch will trigger a new Amplify build. To skip an automatic build on a particular commit, you can include the [skip-cd] text at the end of the commit message.

We are unable to cancel a deploy, it's really bad because in this case i had to destroy the full app (i am not in production yet)

We have identified this as a bug and are working on fixing it. In the meantime, as a workaround you can use the stop-job CLI command to cancel the ongoing deployment:
aws amplify stop-job --app-id {value} --branch-name {value} --job-id {deploy/build #}

Verify if the job has stopped using: aws amplify get-job --app-id {value} --branch-name {value} --job-id {deploy/build #}

Out of curiosity, what region was your app in?

@Jay2113 thanks for the commands to stop job.

Today, each commit on a git branch will trigger a new Amplify build. To skip an automatic build on a particular commit, you can include the [skip-cd] text at the end of the commit message.

yes but in a team flow, we dont want to skip CI/CD, just make the latest build cancels the previous builds. Given a build takes 10 minutes ans i merge 5 PRs  at the same time, i will have 50 minutes building where 10 would be enough.

@johnpc

Out of curiosity, what region was your app in?

my app is in eu-west-3 region

@JJK801 wanted to follow up on this issue. Were you able to mitigate the issue?

Closing the issue due to inactivity.


Error in relative path handling

Copied from Discord:
JimmyDansbo — Today at 3:05 PM
When starting box16 with the -rom option it assumes that the path provided is from the box16 executables directory instead of the current directory
Sepia — Today at 3:54 PM
Well, it had been the other way at one point, assuming the path provided was relative to where the command line was located, but the original emulator assumes the path is the box16 executables directory, so that was a compatibility-breaking change and I put it back.
So you can bug it on Github, but unfortunately it's not going to be fixed unless I decide to intentionally break compatibility with the official emulator.
ZeroByte — Today at 4:07 PM
what happens if you specify an absolute path on the cmdline?
e.g. -rom ./myrom.bin
or -rom /home/user/somedir/myrom.bin
ok - decided to just test it... @JimmyDansbo - absolute paths beginning with / will use any location.
at least it does in Linux
JimmyDansbo — Today at 4:12 PM
Sure, absolute paths will always work, but normal behavior for a program is to use current working directory as a reference instead of using the directory where the binary is located.
In my home directory, I have x16-rom directory and box16 directory. If start box16 from my home directory with the following command: box16/build/box16/box16 -rom x16-rom/build/x16/rom.bin it will not work
ZeroByte — Today at 4:14 PM
hmm - gonna try the official emu in a similar vein
JimmyDansbo — Today at 4:14 PM
official emu works as every other linux program :wink:
ZeroByte — Today at 4:18 PM
hahaha - I just found a bug in the official emu
x16emu -rom .
it boots the emu with null ROM instead of giving "cannot open rom.bin" error msg.
it tries to open the directory itself as if it were the ROM file
okay, so the official emu's behavior is as follows:
if -rom is specified, search relative to the PWD at execution time
else look in exe directory
JimmyDansbo — Today at 4:20 PM
hehe
Yeah, that would be the normal way of doing it for any binary on linux
DesertFish — Today at 4:27 PM
if -rom is specified, search relative to the PWD at execution time
else look in exe directory
I think it now always looks in exe dir regardless of parameter
(I requested the change to look in exe dir for the rom.bin as default)
ZeroByte — Today at 4:46 PM
I've tried a bazillion permutations on the official emu. If -rom is not specified, then it looks in the exe directory, and only there. If -rom is specified on the cmd line, then that is opened relative to the PWD.
JimmyDansbo — Today at 4:47 PM
Yes, but box16 does not try to open rom relative to current working directory
ZeroByte — Today at 4:49 PM
Sepia stated that he didn't want to break compatibility so I thought I'd give it a thorough putting through its paces just to make sure.
DesertFish — Today at 4:50 PM
My use case is the situation where -rom is not specified
ZeroByte — Today at 4:53 PM
And for a final check - I ran box16 from somewhere different than either the specified ROM or the specified PRG arguments, using only relative paths to reach each one. box16 clearly builds rom path relative to the exe in all cases, and prg path relative to PWD
Sepia - just so you don't miss this in the TL;DR thread above- the official emu uses PWD-relative path for the -rom argument if provided, else EXE directory if not specified.
Sepia — Today at 5:01 PM
I see. Okies, that's totally a valid bug then. I'll see if I can fix it properly this time. :stuck_out_tongue:

Hopefully fixed with 40b0e36d0be2fc2f7287e0779dfb05eb6233760c

Seems to be fixed, closing.


Calling mavericksActivityViewModel in fragment, not working properly

I recently discovered some buggy behavior when using mavericks with compose.
When I have Activity A and Fragment B inside A,
If I call mavericksActivityViewModel like below I expected to receive pre-existing actvity viewModel, but I received newly created viewModel.

@Composable
fun PlaceSearchScreen(
    modifier: Modifier = Modifier,
    activityViewModel: ActivityA_ViewModel = mavericksActivityViewModel(),
    fragmentViewModel: FragmentB_ViewModel = mavericksViewModel(),
    ...
) { ... }

When calling mavericksActivityViewModel, this method calls mavericksViewModel with activity as their scope argument.
But when mavericksViewModel method called  IN FRAGMENT with activity as scope argument,
parentFragment in below code snippet is not null because view itself is owned by fragment.
    val viewModelContext = remember(scope, activity, viewModelStoreOwner, savedStateRegistry) {
        val parentFragment = scope as? Fragment ?: findFragmentFromView(view)

        if (parentFragment != null) {
            val args = argsFactory?.invoke() ?: parentFragment.arguments?.get(Mavericks.KEY_ARG)
            FragmentViewModelContext(activity, args, parentFragment)
        } else {
            val args = argsFactory?.invoke() ?: activity.intent.extras?.get(Mavericks.KEY_ARG)
            ActivityViewModelContext(activity, args, viewModelStoreOwner, savedStateRegistry)
        }
    }

Therefore viewModelContext become FragmentViewModelContext in this case.
Because Activity's viewModel is owned by Activity,  call MavericksViewModelProvider.get  with FragmentViewModelContext will not return activity's pre-existing viewModel here.
I think getting parentFragment code snippet should be null when scope is activity and view owned by fragment

Same to me


[Documentation] Refactor poktroll documentation so its easier to navigate

Summary

No changes to the actual documentation
Create navigation bar tabs
Format the sidebar styling
Auto-expand all sidebars
Add search functionality (added after video was recorded)

Before:
https://github.com/pokt-network/poktroll/assets/1892194/b6bcc4fa-6504-432f-90ea-ab36f7bd4fdc
After:
https://github.com/pokt-network/poktroll/assets/1892194/5635ca1d-9f8d-48c5-906b-574c95c11b26
Issue

#460

Type of change
Select one or more:

[ ] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[x] Documentation
[ ] Other (specify)

Testing

[x] Documentation changes: make docusaurus_start

Sanity Checklist

[x] I have tested my changes using the available tooling

@okdas I couldn't find any github workflows that update https://dev.poktroll.com/. Where is it?
Reason why I ask:

@okdas I couldn't find any github workflows that update https://dev.poktroll.com/. Where is it?

This is the one: https://github.com/pokt-network/poktroll/blob/main/.github/workflows/upload-pages-artifact.yml

@Olshansk there's a conflict now after the other branch is merged - I can take care of it - just LMK.


Not delivered messages logging

Add functionality to log events published in transport and not received by anyone.
Try to reuse akka deadletters \ unhandled mechanism

Is not an issue since transport deprecation in 2.0


Rename Base to Catalog

As per recent EVM EIP changes Base was renamed to Catalog.
Adjust for consistency between implementations.

This is mainly renaming PR. Good firss PR.

[ ] Update code
[ ] Update unit test
[ ] Update integration test


Unsupported YouTube Playlist response.

Seems like neither spotify or youtube playlists are working for some reason...
I've attached the file which i was told to link below!
File Dump
This is the error which is also thrown along side the unsupported error:
TypeError: Cannot read properties of undefined (reading '0')

(No this isnt to do with my code, its a library issue

Can you provide the error trace stack? I tested with your file and it is working perfectly,

The id is empty because I used the dump file instead of the playlist link. I set the limit > 100 and it can fetch all the playlists as well

Heres the trace stack
TypeError: Cannot read properties of undefined (reading '0')
at module.exports (C:\Users\user\Music\Spixx Mongo\node_modules\@distube\ytpl\lib\main.js:103:13)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async DisTubeHandler.resolvePlaylist (C:\Users\user\Music\Spixx Mongo\node_modules\distube\dist\core\DisTubeHandler.js:156:32)
    at async DisTube.play (C:\Users\user\Music\Spixx Mongo\node_modules\distube\dist\DisTube.js:167:28)

Not sure why it isnt working for just me

It's working now, im guessing it was just a 1 time thing or something. Thanks for the help


Remove !reset in groups

There should at least be a solution that no random dude can !reset in groups

Could it check if the person is a group admin when you do !reset?

Related to that, what if we also added a whitelist so the bot only responds (starts new conversations) to certain users? This way you can control who can talk to your bot's self-hosted instance.

Could it check if the person is a group admin when you do !reset?

Yeah, I think so. After a quick glance in the documentation, I don't see an out-of-the-box solution from whatsapp-web.js to check if a user is a group admin, but I think it's not too hard to figure that out.

Implemented in 4079b39
About the whitelist, I'll make a new TODO entry in the roadmap.


Compatibility with Kubernetes 1.24

Compatibility with Kubernetes 1.24
The ConfigMapLock resource is deprecated and was removed from the latest version of Kubernetes (1.24)
As you can see in the code, they recommend using ConfigMapsLeasesResourceLock instead
https://github.com/kubernetes/client-go/blob/v0.24.1/tools/leaderelection/resourcelock/interface.go#L194-L195
case configMapsResourceLock:
	return nil, fmt.Errorf("configmaps lock is removed, migrate to %s", ConfigMapsLeasesResourceLock)

@invidian please review again

@invidian done


SSL certificate update for Listener

As the result of the test on my lab, it's enough to update a SSL certificate for only one Listener when we set the same certificate for more than one Listeners. I think it might be hlpful if the statement is on FAQ.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88466307-81b8-1e5b-7f2c-191d8e818071
Version Independent ID: 08ad49f3-6a57-b925-794a-37215e985aba
Content: Frequently asked questions about Azure Application Gateway
Content Source: articles/application-gateway/application-gateway-faq.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@KosukeHosoda , Thanks for raising the issue. We will investigate and update you.

@KosukeHosoda , If you have a Wildcard cert then there is a use case of adding the same cert to multiple listeners.
@vhorne , Can you take a look at this and check if you can add it as a FAQ item?

I actually had the same question prior to reading Kosuke's testing results. I had searched for that answer quite a bit last time we had to make changes to our certs. Also, I'm not sure I understand the point about it only applying when using wildcard certs. We're using SAN certs which are used by multiple listeners. Ideally, you'd be able to view and edit your certs in a blade of the app gateway's page, but I know this isn't the forum for that request.

#reassign:winthrop28

I am closing issues that are older than a year in order to research and cross reference them individually. I am recording each issue and compiling a list of articles to review. If you feel there is an urgent need to address something related to this GitHub issue, please open a new issue and I will reply in the new thread. Please also reference this GitHub issue number in the new issue. Thanks. #please-close


test: add tests for api handlers

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

382 of 414 (92.27%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.3%) to 41.743%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

api/handler/v1beta1/adapter.go
147
179
82.12%

Totals

Change from base Build<PHONE_NUMBER>:
2.3%

Covered Lines:
2788

Relevant Lines:
6679

💛  - Coveralls


[Android] Multiple app instances on first run

Hi. I've just experienced weird thing using react native. When I run command react-native run-android (can't test on iOS) app runs ok, when I press Home button and run it again using app icon, app creates second instance, and doing it again creates +1 instance.
After killing this first-run app makes the problem disappear - next run and doing same thing makes the app back to its instance.
So first run = multiple instances, then leaving (back press (times number of instances)) or killing from recent tasks and everything is fine.
I've tested it on empty app created with react-native init, and the problem remains - I've just added componentDidMount and componentWillUnmount and it mounts multiple times without unmounting. I've tested it with realese apk file and same there - first app run - multiple instances (after running multiple instances pressing back doesn't close app, just close one instance and show another), then all ok. Tried both on emulator and physical device. RN41
Is it a bug or am I doing something wrong? Thanks in advance.

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

@selcute @hramos
i have got the same isuse
and i log Activity's life recycle
the log is:
`
03-20 20:19:05.871 8053-8053/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onCreate:null
03-20 20:19:05.871 8053-8053/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onResume:com.nongfenqi.app.android.thrall.MainActivity@a36c5db
03-20 20:19:29.571 8053-8053/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onPause:com.nongfenqi.app.android.thrall.MainActivity@a36c5db
03-20 20:19:45.151 8053-8053/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onCreate:null
03-20 20:19:45.151 8053-8053/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onResume:com.nongfenqi.app.android.thrall.MainActivity@cb9fdca
03-20 20:21:03.081 8053-8053/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onPause:com.nongfenqi.app.android.thrall.MainActivity@cb9fdca
03-20 20:24:24.621 8936-8936/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onCreate:null
03-20 20:24:24.631 8936-8936/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onResume:com.nongfenqi.app.android.thrall.MainActivity@70d85f4
03-20 20:24:30.361 8936-8936/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onPause:com.nongfenqi.app.android.thrall.MainActivity@70d85f4
03-20 20:24:42.361 8936-8936/? E/com.nongfenqi.app.android.thrall.MainActivity: ,onResume:com.nongfenqi.app.android.thrall.MainActivity@70d85f4
`
scene is:
after i installed the app,runing it, then press home button, open other app, then back to my app
it happend and create two instance
but when i killed my app,open it again ,do the same thing again, it no happen
this happend only at first times!!!
my react-native version is: 0.42.2
my test phone is : samsung galaxy on7(sm-g6100) android version is:6.0.1
and huawei p9(EVA-AL10) android version is: 7.0

Why is this issue closed, I do have the same problem in android with RN - 0.43.0-rc.4.
Any solution would be greatly helpful.

My solution to this was to set android:launchMode="singleTop" on the main activity in AndroidManifest.xml. More info here.
I do not know if there are any side-effects though.

I provided a reason for closing earlier in the thread. You can open a new issue if you're encountering this.


Salesforce Errors when deploying from AppExchange or GitHub

I have tried deploying this from the AppExchange and Github. I am receiving issues in both areas.
AppExchange Error: Q_Sydney_Logo: An unexpected error occurred. Please include this ErrorId if you contact support: 152651771-39560 (962122789)
GitHub deployment response:
package.xml:No package.xml found
package.xml:Bad file:Content is not allowed in prolog.

The Q_Sydney_Logo error can be solved by going to "Setup | Salesforce Files | General Settings", and enabling "Skip triggers execution and validation rules on asset files".


Don't call _disconnected() in Connection.close()

This change prevents a deadlock that was observed when closing NSQProducer (see issue #13). This is was originally opened as pull request #14, but a couple of other changes got mixed in with that one, so I'm re-issuing it as a distinct pull request.
The _disconnected() method will be invoked later by NSQHandler.channelDisconnected(), so there is no need to also call it in Connection.close().
In the case of an exception on the connection, _disconnected() will be invoked by NSQHandler.exceptionCaught().

thanks for circling up on all these edge cases, sounds good to me.


Link directly to choosen showing with filmstaden buy link

https://www.filmstaden.se/bokning/biljettval/Sys99-SE/AA-1573-201908202045

We have something similar today right? I want to remember that we added a "buy link"

Yes, but we today we just link to the movie, not the selected showing

Newer URL:
https://www.filmstaden.se/bokning/kop/Sys99-SE/20220103-1440-1036

@Edholm is sfshowing id stored on the showing?

@lindskogen it is! So this should be feasible


EtcdRestore should take in EtcdCluster reference

Currently, EtcdRestore takes in ClusterSpec in order to restore EtcdCluster. This incurs a problem when the configuration of EtcdCluster to restore is huge, for example labels, ownerRef, TLS policy, pod policy, etc.
In order to simplify the process and reduce duplication, it'd better put a reference to EtcdCluster in EtcdRestore instead:
spec:
  s3: ...
  etcdCluster:
    name: example-etcd-cluster
    namespace: etcd-services

TODO: Update the restore-operator walkthrough doc as well.

Now that the restore-operator deletes the reference EtcdCluster it should also first delete any existing etcd pods and services in its namespace before creating the new restored EtcdCluster CR.
Adding a TODO above.


does not build on ppc64le

nix is locked at version 0.5, which does not support ppc64le.
error[E0432]: unresolved import `self::consts`
  --> /home/joel/.cargo/registry/src/github.com-1ecc6299db9ec823/nix-0.5.1/src/sys/ioctl/platform/linux.rs:34:15
   |
34 | pub use self::consts::*;
   |               ^^^^^^ Could not find `consts` in `self`

Upstream supports this architecture as of later versions (0.8.1): https://github.com/nix-rust/nix/commit/4ee5113d1ebd0fa1318da63c6fd0f5d6972604a3
It looks like this is pulled in by rustyline:
[[package]]
name = "rustyline"
version = "1.0.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "encode_unicode 0.1.3 (registry+https://github.com/rust-lang/crates.io-index)",
 "kernel32-sys 0.2.2 (registry+https://github.com/rust-lang/crates.io-index)",
 "libc 0.2.42 (registry+https://github.com/rust-lang/crates.io-index)",
 "nix 0.5.1 (registry+https://github.com/rust-lang/crates.io-index)",
 "unicode-width 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)",
 "winapi 0.2.8 (registry+https://github.com/rust-lang/crates.io-index)",
]

Rustyline looks like it might have a new release soon:
https://github.com/kkawakam/rustyline/issues/123#issuecomment-405095599

We should have that component optional to begin with.


fix: enable compatibility for loading native ES modules with require

Back port https://github.com/serverless/serverless/commit/8b960a2e92364149e463c274172dc9d08a37a836 which is linked to https://github.com/serverless/serverless/issues/12936

Thanks!


Way to convert OpenDiS output data files to vtk?

Hi OpenDiS team,
I just recently installed this and have been going through the provided examples.
I see that Ovito is mentioned as a visualization tool in the tutorial, but I wanted to ask if it was possible to convert the output files from .data format to .vtk format so that they could be visualized in something like Paraview? Does someone know of a script already out there that performs that function?

Hi,
I have added pyexadis utility function write_vtk() in commit LLNL/exadis@b142636. With this you should be able to convert .data files to .vtk files for visualization in Paraview, e.g.
import pyexadis
from pyexadis_utils import read_paradis, write_vtk
pyexadis.initialize()

N = read_paradis('config.data')
write_vtk(N, 'config.vtk')

I hope this helps.

Thanks! And this is something I put into a post-processing python script? Do I need to have OpenDiS running to use this?

Right now it is meant to be used as a post-processing step, i.e. you first run a simulation that generates .data files, and then convert these .data files to .vtk files for visualization.
If you really want to generate the .vtk files directly during a simulation run, then you can always use a modified version of the SimulateNetwork driver class from ExaDiS where you add something like
from pyexadis_utils import write_vtk
write_vtk(N, os.path.join(self.write_dir, 'config.%d.vtk'%(tstep+1)))

after line 792. I may add this as a permanent feature in the future.

Is there a specific place I can import pyexadis from?

Library pyexadis is built during compilation of the code. To compile, follow the instructions at Compilation. After successful compilation, the library will be located in ${OPENDIS_DIR}/core/exadis/python. From there you should be able to import it after its path is properly added, e.g.
# add path to python
pyexadis_path = '/path/to/OpenDiS/core/exadis/python/'
if not pyexadis_path in sys.path: sys.path.append(pyexadis_path)

# import pyexadis
import pyexadis

I do not see a pyexadis.py file in my python folder. I only have pyexadis_base.py and pyexadis_utils.py files

There is no file pyexadis.py. A successful compilation of the code should produce shared library file pyexadis.cpython-*.so in the folder. This is the library that will be loaded when calling import pyexadis from python.

I got it to work, thanks for the help!


Add light / dark theme toggle

It would be great to have a toggle to switch between light theme (needs implementation) & dark theme (currently available).

Hi, @manovotny I would like to work on these feature

@ManishDait you're more than welcome to give it a shot and submit a PR. The only guidance I'll give is... We did try next-themes and ran into issues with RSCs and hydration. We are aware of workarounds listed in issues on the repo, but we were not able to come up with a solution we were happy with, so we skipped it for now. Ideally, it would be finding and fixing a solution in next-themes so many projects could benefit from it.

Going to close this one out, as I'm happy with the current light/dark mode setup 👍

Is there any way to force light mode instead of defaulting to the system preference?


How to add customize cosmos app chain into the bdjuno?

we have setup an app chain, how can we add it into bdjuno?

Hi @VegeBun-csj to learn how to setup BDJuno for your custom chain follow our docs here https://docs.bigdipper.live/

@MonikaCat hi, can u help add our app chain into the bdjuno? we have encounterd some issue.

@MonikaCat hi, bro. We have encountered an issue:

I researched the bdjuno source code and found the error comes from the lib juno. How can we solve it?
Also i found many branched in bdjuno repositry, Do we need to push a customize juno branch?

Hi @VegeBun-csj as the error suggested, it seems like the grpc server on your end might be unable to serve the request made by client in bdjuno. Can you check if you have registered the Tx service on your grpc server correctly? Thanks!

@zura35 hey bro. Thank you for your suggestion. I have solved the problem, and i meet a new problem:

Hi @VegeBun-csj may I ask if you have already added the module according to this tutorial before starting bdjuno? 🙏

Hi @VegeBun-csj may I ask if you have already added the module according to this tutorial before starting bdjuno? 🙏

@zura35  yeah, i have added the application modules into my bdjuno main.go, and i compiled it successfully. Also im using it to start.

I noticed that i didnt add custom addresses parser into the bdjuno, Maybe it cause the problem?

@zura35 I have resolved it with changeing the wasm version! :) thanks bro


Minecraft 1.20.5 Support

Since Minecraft has changed to Java 21, the old plugins will no longer work. Please add 1.20.5 support to both Friends API and Party API :)

Sorry, we don't have neither friends nor party API.


action-bar in arcgis cli gives global is not defined

Expected Behavior
Empty ActionBar in the screen
Current Behavior
Completely white screen in the browser
Steps to Reproduce (for bugs)
steps to reproduce:
run the arcgis cli (version 4.16.0)
arcgis create jsapi-react-app -t react
install the calcite-react components (version (0.54.0)
npm install calcite-react
in src/index.tsx
add import ActionBar from 'calcite-react/ActionBar';
add  in render function
Note: this is the minimal implementation of the ActionBar resulting in an error. Adding ActionGroups, Actions and the required icons ends up in the same error message
Result in browser:
Empty screen
console error: global is not defined
Context + Screenshots

Your Environment

Version used:
Calcite-react 0.54.0
Arcgis-cli: 4.16.0

Browser Name and version:
Chrome  85.0.4183.83
Edge 85.0.564.41
Freifox 80.0

Operating System and version (desktop or mobile):
Windows 10

@arjanvanzutphen This looks related to two dependencies, uniqid and react-popper. I believe an update to popper will resolve the ActionBar bug you're noticing, so I'll hop on that right away. I'm still looking at solutions for uniqid but should have a fix soon.
Currently I don't have a workaround for you to move forward but I will keep this issue updated as I make progress.

One work-around I found is to include one rule of JavaScript to your highest index.(e)js file in your applicatie.
Add 'window.global = window' directly within the head element.
Steps:

Add this rule to your index.ejs in the public folder directly after the title tag.

Create the env-config.js file in the root folder of your project.
Add the rule 'window.global = window;' to this newly created file.


Chan.Part.API: implement remove system channel

Type of change

New feature

Description
Implement removal of the system channel, which will allow existing networks to transition to using the channel participation API.
Related issues
FAB-17965

Looks good to me.


chore: project qoute-generator

In this project , I use qoutable api to fetch the daily random qoutes with their author name, and it is built by using HTML, CSS, JavaScript.
#1524
Description
Screenshots
Checklist for projects addition

[x] My project has contribution guidelines.
[x] My project has a Code of Conduct.
[x] My project has a README file.
[x] My project has a License.

Please note that if your project doesn't meet these requirements, your PR may be closed. Make sure to include these elements in your project before submitting the PR.

@priyankarpal  is there need to create new PR for this.

@priyankarpal is there need to create new PR for this.

yeah we have migrated our website to Next.js and TypeScript, so the file path has changed. Please check our updated contributing guidelines for more information.


include linux/tcp.h on Linux pre-glibc 2.17

Bazel 0.24.0 upgraded grpc from 1.13.0 to 1.18.0, and the latter makes use of
the TCP_USER_TIMEOUT socket option.  Problem:  grpc conditions the option on
the Linux kernel version but sources the option from glibc's netinet/tcp.h.
glibc != Linux kernel, and that option wasn't imported to glibc until 2.17.
We can't just build Bazel with glibc 2.17 because we still have to support
CentOS 6 dev nodes which ship with glibc 2.12.  So instead this change
tweaks the grpc headers to conditionally include <linux/tcp.h> instead of
<netinet/tcp.h>.
Resolves https://github.com/grpc/grpc/issues/18728.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @beasleyr-vmw isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

Makes me a bit sad...

(Update: Didn't realize that the "release notes: no" mergeability prereq referred to the issue label rather than commit message---I'm wholly new to the gRPC project---so I stripped that out of my commit message and repushed. Apologies for the noise.)

newb question: The Kokoro failures seem to be flakes unrelated to my change. (Ex: "A compatible installed dotnet SDK for global.json version: [3.0.100-preview4-011108] from [/var/local/git/grpc-dotnet/global.json] was not found".) Is there anything else I can do here?

There's definitely flakes. I'll check the status exactly when in the office.

Yes, the various breakages were either introduced asynchronously, or are just infrastructure flakes, and are unrelated to this change. Merging.


Issue with k8s.io/docs/concepts/overview/what-is-kubernetes/

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
This documents assumes that the reader have a basic understanding of the concept of containers and some experience with administration/operations work.
Proposed Solution:
Add a section that specifies this as prerequisite for reading this page.
Page to Update:
https://kubernetes.io/docs/concepts/overview/what-is-kubernetes/

@dipakmdhrm 👋 That's great feedback, thanks!


fix: call onModalHide when the confirm modal is closed

Details
Properly clean up the state if there is an attempt to upload an invalid / unsupported attachment.
Fixed Issues
$ https://github.com/Expensify/App/issues/18888
PROPOSAL: https://github.com/Expensify/App/issues/18888#issuecomment-1546696596
Tests

Open an Expensify chat in the browser.
Attempt to upload a non supported file.
Close the error message.
Drag and drop a supported file to the chat.

[x] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as tests.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/4160319/7bb442d4-42af-48f2-bf8d-d369615f527f

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://github.com/Expensify/App/assets/4160319/7f8c3697-bc42-48b7-b3ae-0f071e2ecf90

iOS

Android

While we're at it, can we fix the naming of the event handler and prefix it with onAttachmentPreviewClosed, or, my personal preference, place those lines directly in the prop:
onModalHide={() => {
    this.setShouldBlockEmojiCalcToFalse();
    this.setState({isAttachmentPreviewActive: false});
}}

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.13-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fix(publish): deprecate Dendron: Publish Dev command

This PR aims to deprecate Dendron: Publish Dev command. The user gets a warning toaster to use Dendron CLI instead with a button to publish cook docs.
added it as a fix to include this in changelog

what is the usage of publish dev today? do we have a chart on amplitude on this?

5 unique users in the last 7 days and 24 in the past 30 days: Chart


⚠ Bofrost.at has degraded performance

In f62f352, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2464 ms

Resolved: Bofrost.at performance has improved in 4760c17 after 8 minutes.


Webapp/login

Please answer these questions before submitting pull request

Why submit this pull request?
[ ] Bug fix
[x] New feature provided
[ ] Improve performance

New feature or improvement

Add new filter for username/password login.
Add new webapp.yml configuration file.
Modify webapp startup script.

Coverage increased (+0.1%) to 24.596% when pulling d3b4e5653014ad7aa5821f6b15c42a5074dc13d6 on webapp/login into 6605fcd3a880790e3f69d0a7cbd20da3fc0217d1 on master.

@wu-sheng after renamed the package to org.apache.skywalking.apm.webapp.proxy
does the file  apm-webapp/src/main/resources/application.yml need to update the entry from org.apache.skywalking.apm.webapp.tools.CollectorServerList to org.apache.skywalking.apm.webapp.proxy.CollectorServerList?

I am not sure. If should, you could send a pr directly.

@zone1511 this https://github.com/apache/incubator-skywalking/pull/1392 pr has renamed the config.


TK 448 take start date into account for time entries

Disable the project’s name inside the select component of create/edit timeEntry form if the date isn't between the startDate and endDate of the timesheet.
EndDate isn't required, so if there is no endDate, projects are disabled if the timeentry's date is before the startDate.
Modify the startDate field annotation in TimeSheet.java, TimeSheetRequest.java, and TimeSheetResponse.java to add
@JsonFormat(pattern = TimeKeeperDateFormat.DEFAULT_DATE_PATTERN) to get it in the right format for the frontend.
Tests

As agreed today, @tkuy will take ownership of this PR and rebase from develop

Everything seems fine


Support of code completions based on workspace

Suppose I have two different files in the same workspace, how to do code completions based on them, say one file is imported in another file. Right now I can only provide code completions for only one file.

Could you provide more information, please? How many editors do you have? Which language server do you use?
It is the responsibility of the language server to provide completions given that proper rootUri is provided, i.e. pointing to the location of workspace on the disk.

I am going to close this issue if there are no objections.


Observable.race() completes immediately when one of its sources complete before emitting any item

RxJS version: 5.4.0
Code to reproduce:
Observable.race(
    Observable.empty(),
    Observable.of(2).delay(500)
  )
  .subscribe(console.log, null, () => console.log('complete'));

http://jsbin.com/nuzifo/edit?html,js,console
Expected behavior:
2
complete

Actual behavior:
complete

Additional information:
Maybe this isn't a bug but the documentation for Observable.race() says (https://github.com/ReactiveX/rxjs/blob/master/src/operator/race.ts#L18):

Returns an Observable that mirrors the first source Observable to emit an item from the combination of this Observable and supplied Observables.

I'd expect that complete notification doesn't count as an item and therefore it should ignore the complete notification from the first source Observable and wait until Observable.of(2).delay(500) emits. But it doesn't because of the default behavior of  OuterSubscriber at https://github.com/ReactiveX/rxjs/blob/master/src/OuterSubscriber.ts#L20-L22
I checked also RxJS 4 amb operator and it works the same as RxJS 5.4.0 right now. Its description is maybe even more ambiguous when saying:

Propagates the observable sequence or Promise that reacts first

doc may need to be improved, but behavior itself is expected let race completes if any of source completes. refer our test cases here : https://github.com/ReactiveX/rxjs/blob/master/spec/observables/race-spec.ts#L94

I know this issue is closed but I faced the exact same issue by relying on the existing documentation. That being said, I think the documentation should be updated to include a mention about completed Observables.
Next I'd like to know what is the preferred way to achieve what the original author wanted to do? Meaning, have n Observable instances, get first value from any of the instancesv whichever has that value available first. Ignore completed Observables.

The docs should probably use "reacts first" instead of "first to emit an item". If you really wanted to only react to emitted items, then you could add .concat(Observable.never()) to each observable.


Not Exposing Climate Entity

I just updated to 1.7.6 after the recent change that Cielo did which caused previous versions to break. Once updated there is no climate entity exposed which breaks thermostat cards, homekit bridge controls, etc. Let me know if there's somewhere I can poke around to try and provide more information. Thanks.
Steps:

Updated integration via HACS from 1.7.4 to 1.7.6
Restarted HA
Removed existing Cielo device
Added new Cielo device and successfully connected and checked entity list

update your HA

update your HA

Thank you. Dumb issue on my part, I somehow stuck my container to a static version from 2023 and didn’t realize it wasn’t pulling the latest HA. Sorry for the issue!

No problem! ;)


"/menus forceopen" command doesn't work from console

Checking the wiki, this command can also be used in console, but the only message I got is "You cannot use this command from this source (player only)." I think the behavior of the command isn't correct.

Please provide more information
Minecraft version
Mod version
Server software

Sure!
Minecraft version: 1.12.2 in Magma DEV-v32e7e1a
ForgeMenus version: 2.0.3-1.12.2 (the latest version)
Server software: Ubuntu 20.04
Also, I have ForgePlaceholderAPI with ForgePlaceholders, ReforgedPlaceholder and SpigotPlaceholders.

Yeah, you're correct I think I got confused. Will sort out a fix for it in a minute :)

Fixed by 2.0.4


Update controller and agent to kube-rs client 0.91.0

What this PR does / why we need it:
Our controller uses a really out of date Kubernetes client (kube-rs) API. This updates it to a newer version. Another PR can bump us to latest, which will cause more changes to the agent which is why I avoided that big of a jump.
Much of the controller code was written years ago when the kube-rs did a lot less of the heavy lifting. Switching to a newer version with a better reconciliation model means I was able to delete a lot of helper code.
All the tests had to be rewritten for the new API.
Special notes for your reviewer:
This is a lot. I am hoping the tests can confirm the functionality but we may also need to do a good bug bash.
If applicable:

[ ] this PR has an associated PR with documentation in akri-docs
[x] this PR contains unit tests
[x] added code adheres to standard Rust formatting (cargo fmt)
[x] code builds properly (cargo build)
[x] code is free of common mistakes (cargo clippy)
[x] all Akri tests succeed (cargo test)
[x] inline documentation builds (cargo doc)
[x] all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@kate-goldenring the Controller system doesn't have any "delete" event partly because these can be missed easily, e.g for the node watcher if the controller was on the now missing node, it will never get a delete event for that node.
Overall, the akri controller currently use an event based imperative mechanism (node got deleted, so I do remove it from Instances). But the kube-rs "Controller" system is a bit different in that it works with: I have a resource (in our case the Instance), I should ensure everything is set-up correctly for it.
So if we were to follow the full kube-rs flow here, we would have an Instance controller, that ensure all broker Pods/Jobs/... are here, and that all referenced nodes are healthy, it would trigger on an Instance change to reconcile that Instance, would trigger on owned Pod/Job/... change (to ensure it is always according to spec), and would also trigger (for all Instances) on node state change.
We could also have a reflector for the Configuration to maintain a cache of them and avoid fetching the Configuration from API every time we reconcile an Instance.
I didn't comment on this as your goal was to do the minimal changes necessary to upgrade to latest kube-rs

@diconico07 that vision makes sense. I started down the path of minimal changes and obviously it grew so much that a full rewrite with just an instance controller would have been easier. At this point, I don't have much more time to devote to this, so could we look at this from the lens of what needs to change here for parity and upgraded kube-rs and then track an issue on rewriting the controller?

Because we are not reconciling instance deletes anymore, the BROKER_POD_COUNT metric is becoming more of a BROKER_POD_CREATED metric

it would trigger on an Instance change to reconcile that Instance, would trigger on owned Pod/Job/... change (to ensure it is always according to spec), and would also trigger (for all Instances) on node state change.

@diconico07 clarifying here: are you saying the controller should still watch Instance, Pod and Node resources? or just instance resources and verify the existence of resources based on the instance change?

It should reconcile Instances (Controller mode), watch Nodes (IIRC there is a way to just get a trigger when a specific field gets updated), and watch Pods,Services,Jobs (if we want to always keep these in line with the spec in Configuration).
The last two being light watches (or probably reflector for nodes), that will just trigger an Instance reconciliation.


TrimPrefix baseDir ot mtad.yaml instead of Replace

Change the logic of calculating path to trim the base directory instead
of replacing it. JIRA: LMCROSSITXSADEPLOY-1623

Fix in https://github.com/cloudfoundry-incubator/multiapps-cli-plugin/pull/105


Add point-like background table

I just realized that we also can have a point-like background table, that would contain the
background rate inside the region defined by RAD_MAX.
So the function would take the background events and normalize to the solid_angle as defined by RAD_MAX

Sorry, but then per sr would not make sense. So I think this is rather an issue for the GADF format and not here.


Use of custom colours in Pie Chart?

I couldn't find any way to use custom colours for pie chart using library's API either in documentation or in examples.
Is it possible with the current API?

Yes, use color option:
//variable of custom colors
var colors = ["red", "green", "blue"];
...
chart {
    color: function(d){
        return (d.data && d.data.color) || colors[i % colors.length]
    }
}
...
// or set custom colors directly in the data
data = [{
        key: "One",
        y: 5,
        color: "yellow"
    },{
        key: "Two",
        y: 2,
        color: "gray"
    },{
        key: "Three",
        y: 9
    },
     ...
];

@krispo Awesome. Thanks.

The above code works for legend colors and not for the pie colors.

Hi @shgattu , check it please:
http://plnkr.co/edit/YVBBhE?p=preview

Thanks Kripo. The plunker link works good.
http://plnkr.co/edit/f2gTjx?p=preview.

For anyone who comes across this in the future, you can also use hex color codes to determine the color of a data point.

Hi @martellaj, can you show an example of how to use hex codes for colors?

Can we create a doughnut chart?

How to change font colors in Pie chart for the label and for the legend


[ETL-215] remove list of lists

get_center_input_files used to return a list of lists to support validation across multiple files.  This has been removed to simplify the code.  A list of entities is now returned.

They're meant to be worked on in a new PR.   I'll probably file new issues but those are non-essential code improvements


Actions: Secure cloud deployments with Open ID Connect on GHES

Summary
GitHub Actions now supports OpenID Connect (OIDC) for secure deploy to each cloud, which uses short-lived tokens that are automatically rotated for each deployment.
This feature is currently available only for DotCom and will soon be enabled even for enterprise SKUs (GHES).
Intended Outcome

With the new OpenID Connect (OIDC) support in GitHub Actions, you can author secure cloud deployment workflows without needing any cloud secrets stored in GitHub.
OpenID token exchange eliminates the need for storing any long-lived cloud secrets in GitHub
Admins can use the security mechanisms of their cloud provider to ensure Action workflows have the minimal amount of access to cloud resources.

How will it work?

Developers set up OIDC trust on their cloud roles to manage access between their deployment workflows and cloud resources.
In each deployment, a GitHub Actions workflow can now mint an auto-generated OIDC token. This token has all the metadata needed to get a secure, verifiable, identity for the workflow that is trying to authenticate.
Cloud login Actions can fetch this token and present it to their respective clouds.
The cloud provider then validates the claims in the OIDC token against the cloud role definition and provides a cloud short-lived access token that is only valid for a single workflow run, and then automatically expires. Actions within the same Job could however use this access token to connect and deploy to the cloud resources.

this has shipped<EMAIL_ADDRESS>closing out this issue.


Fetch more than 30 forks

Forks from GitHub are paged 30 at a time. It would be nice to fetch them all for large projects (many forks).

@Newgap thats a good point. Would be open for a PR from community as I have couple of busy weeks.

I will work on this.

all yours @Syed-Umair

@techgaun, Do you need me to load specific amount of forks data like 100 or all that is available.

@Syed-Umair I think the best would be to follow the guidelines and put lazy loading or page numbering at the bottom of the page: https://developer.github.com/v3/guides/traversing-with-pagination/

Ok, I will do that.

Don't forget that if we change the sorting, you will need to refetch the data from GitHub with that new sorting. Or, you can fetch all data in memory and sort that instead.

@Newgap agreed. I am however not sure if we really want to fetch all data. For examle, facebook/react has 20K forks and not sure how helpful/useful would it be to pull them all. But, again, for something like such repos, this tool might not be used as often and could be potential trade-off? Just not sure what would be the best way to get around this. Thoughts?

Can we set the number of forks to be fetched via UI instead of using a max of 100 like in #14? I usually use this tool to find the fork with the latest commit, which is impossible or at least very luck-based with repos with more than 100 forks.

@ModischFabrications fair point. That's probably a good idea. Will try to get that in soon


Not detecting that execution has completed

Hi Ryan, thanks again for this great tool.
For some reason, it has stopped detecting when one of my MA's completes.
In Autosync, State just remains as "Running", even though the State on the MA in MIM is idle again.
Autosync does not seem to be able to recover from this, even after many hours.
The MA is called AAD_Mobile, it is a psma by Soren.
Exporting results in errors which are to be expected.
In the example here, 0 exported objects complete successfully. However, even if some complete successfully, the problem is the same.
This is what the GUI looks like

And here is a trace from starting the service and then starting only the AAD_Mobile controller.
autosync.log
I'm running Autosync version 1.2.8002.27749 and MIM version 4.6.531.0
Any idea what i could do?
Let me know if I can provide some additional information.
Thanks
Martin

@mrmueller what status did that last run finish with in the sync engine?

@ryannewington it finishes with "completed-export-errors"

Hmm. That doesn't make much sense. When it's next in that state, can you please go to task manager and right click on the autosync server process exe and select create memory dump. Share the resulting file via onedrive to<EMAIL_ADDRESS>We'll debug from our side and see what it thinks it's waiting for.

This is the latest run. Sending dump shortly.

Thanks for the help you provided by email Ryan!
Really appreciate you doing this even though it was clear early on that this issue was not related to autosync.
Solution for people finding this later:
Autosync is calling the "Execute" WMI method on the management agent, and that method (usually) returns once the run is finished. It was not returning here.
Problem was that my export powershell script was not handling one exception properly.
try{
$ErrorActionPreference = "Stop"
New-MgUserAuthenticationPhoneMethod -UserId $userPrincipalName -PhoneNumber $primaryPhone -PhoneType "mobile" -SmsSignInState "ready"
}catch{
$obj = @{}
$obj.Add("[Identifier]",$Identifier)
$obj.Add("[ErrorName]",$($_.Exception.Message))
$obj.Add("[ErrorDetail]",$($primaryPhone))
$obj
}
The Powershell Cmdlet New-MgUserAuthenticationPhoneMethod was throwing an exception which was not caught as I would have expected
I had to add $ErrorActionPreference = "Stop" before the command because New-MgUserAuthenticationPhoneMethod does not support -ErrorAction
Now that the exception is caught, MIM seems to complete the WMI call as expected and Autosync can continue without issues.


Wrong version number in docker for windows release notes?

Problem description
Currently on windows release notes it states that newest version is 1.13.3. Should that be 1.12.3?
There is also a high probability I have understood something wrong.
Problem location
https://github.com/docker/docker.github.io/blob/master/docker-for-windows/release-notes.md

@LKajan this is fixed now. Thanks for the feedback. See related PR #645 for details on the file changes.


Implemented the BlockchainEstimateFee function

Implemented the BlockchainEstimateFee function to estimate the transaction fee per kilobyte that needs to be paid for a transaction to be included within a certain number of blocks

Cool! Thanks for contributing!


Remove support for built-in scripts in the editor

Built-in scripts have many limitations that users tend to discover late in their project. This causes a lot of pain as scripts must be replaced by their non-built-in variants one by one.
Note that this only unexposes the ability to create and edit built-in scripts from the editor. It's still possible to save a scene that contains executable built-in scripts using PackedScene or external tools. (Removing support for built-in script resources is likely more involved, but it would be useful to make sending PackedScenes over the network more secure.)
This is a compatibility-breaking change, as built-in scripts need to be turned into non-built-in-scripts before upgrading a project to Godot 4.0.
This closes https://github.com/godotengine/godot/issues/31758, closes https://github.com/godotengine/godot/issues/5535, closes https://github.com/godotengine/godot/issues/29863, and closes https://github.com/godotengine/godot/issues/31364.

I am entirely against this PR. It doesn't solve any real issue, it just removes an extremely useful feature, only because it has a few minor shortcomings.
90% of the scripts in my project are built-in. Each of them is tightly related to their scene and useless outside of it. Many are less than 10 lines long. Saving them to files means I will suddenly have hundreds of useless new files that I'd need to store somewhere. Built-in scripts (and actually any resource) lets you to avoid that bloat and are one of the best things about Godot.
Removing built-in scripts might fix some issues, at the cost of introducing severe usability problems. You suddenly can't just duplicate your scene and edit the new one, you have to make sure that your script is unique otherwise you can break your original scene. You can't just have small behavior scripts in your levels, now each of these scripts needs to be separate file and suddenly your level files are mixed with scripts, resulting in complete mess; well, unless you keep each level in a separate directory and are fine with having 100 directories, which are hell to navigate. You also can't just copy a scene to another folder/project, you need to remember about the script or everything breaks. I'm pretty sure lots of users use the built-in scripts and removing them would result in an outrage.

Built-in scripts have many limitations that users tend to discover late in their project.

You mean these?

Which are visible every time you create a built-in script? We could extend this to list everything (maybe as a tooltip or URL idk).

This causes a lot of pain as scripts must be replaced by their non-built-in variants one by one.

This doesn't make any sense. Which exactly limitation is discovered "late in the project" and forces you to replace the scripts? Like, there is zero reason to replace the built-in scripts. If you used them, they are already there and work perfectly fine. The only thing that comes to mind is encryption, but 1) this is not something that can't be fixed 2) we could just mention it in the tooltip 3) it's useless anyways.
So again, instead of completely destroying Godot's usability for many people, I'd rather focus on minimizing and better documenting the limitations of the built-in scripts. There aren't many of them and they aren't a very big deal (like, you didn't even link anything meaningful). Having built-in scripts outweights not having them by a lot.

I don't think the feature should be removed as many users find it useful (as exemplified by @KoBeWi's extensive use case), and the issues it has are fairly benign.
Several of those could likely be fixed easily, e.g. #29863 should be simple - if it's a builtin script, ignore the external editor setting. What built-in scripts need is maybe a maintainer that cares about this (wink wink KoBeWi).

Built-in scripts do still have inherent limitations due to not being files in the file system. They do not work with external tools in any way, shape or form. They only support GDScript. They cannot be globally registered with class_name. And so on and so forth. Now, maybe powerusers like KoBeWi understand why those limitations are there and are not hindered by them. But a ton of users are confused by it. They don't understand what a built-in script is, how it's different from a normal script, and why some features of the engine don't work properly.
So even though they may help with some project organization, their usability is very low. If we are to keep them, they need to be improved significantly in a way that guides inexperienced users instead of leaving them confused like it is now.

They do not work with external tools in any way, shape or form.

This is fine. If you use external tools, you just can't use built-in scripts, you need to use built-in script editor for that (I mean, this even makes sense if you look at it this way xd).
 You can edit .tres files externally, unless they are built-in (which just makes it more difficult).

They only support GDScript.

We should also have an error message about that in script create dialog, if there isn't one already. btw VisualScripts also can be built-in, and it's the only way to have them saved as text.

They cannot be globally registered with class_name.

You are given an explicit error if you try to use class_name in a built-in script. I don't know how it could be any less confusing (assuming you do read the errors, which most people don't do from my observations; I wouldn't care about them though).
I'd actually like to see a list of features not supported by built-in scripts, to see what is fixable and what needs to be better documented.

I use GDScript all the time, and I always like use build-in script. Please don't

Something that I like about Gamemaker is the "Creation Code" script that you can attach to any object without creating any additional file, sometimes it's faster/less messy to set up variables or execute a function at the start of the game by code rather than exporting variables.

@KoBeWi I’m not arguing if the limitations are fine or not right now, so there is no reason to dispute them. They are there and they trip people. We get user support requests from people using built-in scripts without realizing it all the time. I believe that you find them useful and are satisfied with them, but we do have a lot of users who get into problems from using them, often using them accidentally. In other words, we make it too easy to use them without realizing what that implies. This is what I’d like to see addressed instead of providing a rationale why no support for external tools is actually OK.
PS. Didn’t actually know it was possible to store VS in a text form. Still, we had a person ask for built-in C# the other day 👀

often using them accidentally

Does it still happen after we added the warning label? I'm thinking, maybe we could  hide the option to create built-in scripts behind an editor setting, if it's really that advanced feature?

Yes, there are definitely people running into that after 3.2.2 🙃
I was thinking maybe we could add an icon or a badge to the script editor that would appear for built-in scripts and when clicked open a short explanation to the nature of the beast? Tool scripts could also use such a badge.
The ideas is that when people work on it, they may pay more attention than they only create it. Plus it can fit more details there about present problems.

Closing due to lack of support.

I would suggest making a tracker for actual issues with built-in scripts, so that we can see how to solve or document them all. To be honest usability has improved a lot already and I haven't seen many user reports that would point otherwise in the past year or two (at least on GitHub, there might be more confused users on Discord/Reddit/Q&A).

commonly, a snippet of game logic exclusively pertains to one specific node of one specific scene.
in such a scenario, having to add a separate file for each piece of code doesn't do anything but to introduce bloat.
this is where built-in scripts shine.
personally, if it weren't for the various bugs/limitations, then I'd likely default to built-in scripts for every script that isn't registered (contains class_name keyword). at least I wouldn't see any reason not to.
@KoBeWi

I'd actually like to see a list of features not supported by built-in scripts, to see what is fixable and what needs to be better documented.

ok so first of all the class_name thing, but I think that's kind of a non-issue since the use-case for built-in scripts is not one where it makes a lot of sense to register it as class. the only thing I can think of is that maybe it would be cool to be able to register scenes that one uses as templates (instancing a scene as root node of another) as a Node class. that would enable you to have scenes appear in the "create new node" window and even have a little custom icon for them.

next up is that changes in built-in scripts are not picked up and automatically reloaded during test play. "Persistent live editing" is one of the major selling points advertised on godotengine.org, so I think many new users are looking forward to using it and are then disappointed that it doesn't work in this case.

built-in scripts cannot be properly searched. while they can be searched if you tick tscn in the ctrl+shift+f dialogue, after clicking on a line in the search result panel, the raw tscn file opens in the code editor instead of just the script resource.

there is some jankyness with built-in scripts as tool scripts that I cannot properly define right now. It kind of works, but I remember having to reopen the script or even restart the editor every time after having made changes, or otherwise I got spammed with error messages.

then using them in external editors and version control friendliness, but that can be understood as limitation rather than as bug. I'm not sure what currently happens if one tries to edit a built-in script with an external editor. if it opens the scene file raw in the external editor, then that's just confusing and a bad experience. instead, it should always use the built-in code editor.

there may be more that doesn't come to mind right now but I think that summarizes it quite nicely.

you can extend a built-in script if you set its resource_path property to something not occupied, like res://21739871 or res://built_in_script_base_enemy then you can extend from the script with extends "res://built_in_script_base_enemy", though, you have to clear the resource_path of the built-in script before saving the scene with the script otherwise you wouldn't be able to load the scene later because the resource_path points to no script file when the scene is loaded, and resource_path for scripts is only for script files.


Enhancement: Internal json rpc error returned on invalid auth token

Description
When sending an auth request with an invalid token the server returns an "internal" JSON RPC error (code -32603).
Environment details
Streamlabs OBS Version: 1.1.2
Operating System: Windows
Steps to reproduce the issue

Connect to Streamlabs OBS
Pass on authentication an invalid token
See response:

{
    "id": 1,
    "jsonrpc": "2.0",
    "error": {
        "code": -32603,
        "message": "INTERNAL_JSON_RPC_ERROR Invalid token"
    }
}

Expected behavior
Error returned should be other than an internal error, for example an "authentication failed" or "invalid token" error with a unique error code.
Actual behavior
API returns a general error of the wrong type (internal).
Further information
It would be great if further errors with unique error codes would be introduced, so the consumer of the API can better handle errors returned as response, especially on connection establishment and authentication.

The JSON RPC specification doesn't say which code should we use for the failed auth. It has a very limited list to choose from. https://www.jsonrpc.org/specification
Custom codes could make it slightly more difficult to create write the client code for our API. So just a message with an invalid token looks good for me

I didn't see that the codes are predefined in the JSON-RPC specs. They say in the specs that

The remainder of the space is available for application defined errors.

but I have to agree with you, custom codes will make it more difficult and require proper documentation.
Is there maybe a better way I might miss for handling authentication errors (like invalid or expired tokens)? I would currently match strings of error messages to figure out what went wrong.


[Shared] Config and Genesis refactoring improvement: ValidateConfig has to work with mocks and real implementation

Objective
Keep track and address areas of improvement. Specifically, in this issue we aim at addressing the comments below
Related PR https://github.com/pokt-network/pocket/pull/235
Origin Document

https://github.com/pokt-network/pocket/pull/235#discussion_r986252144

Goals

[ ] Improve code quality

Deliverable

[ ] Refactor the code so that there's no ambiguity

Non-goals / Non-deliverables

Changes in logic

General issue deliverables

[ ] Update the appropriate CHANGELOG
[ ] Update any relevant READMEs (local and/or global)
[ ] Update any relevant global documentation & references
[ ] If applicable, update the source code tree explanation
[ ] If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

_REPLACE_ME: Make sure to update the testing methodology appropriately_
Task specific tests: make ...
All tests: make test_all
LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @Olshansk

We are using interfaces now, this can be closed


[ISSUE-#1875] Upgrade nacos-client version to 1.4.0

Does this pull request fix one issue?
For-#1875

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM

LGTM


Add missing definitions for cross compilation

Added HAVE_SCHED_GETCPU and HAVE_CLOCK_MONOTONIC_COARSE definitions for arm/arm64.
The compilation is still failing due to other missing thing, but I'll do a PR later.

@manu-silicon looks like this may actually be slightly incorrect, I believe you want to be setting the respective _EXITCODE variables to 0, rather than the variables themselves. This has the correct effect, but will suppress the compile check, and just assume it's always true. Setting _EXITCODE still results in the compile check being run I believe, and just provides the answer to the run check.

See https://github.com/dotnet/coreclr/pull/3512

@benpye You are right, I did not fully grasp how cmake worked in this case. Fix is in PR #985


Compiler integration

There  are some areas that need work. After changing ControlFlowGraph.treeRoots to use ReferenceHashMap instead of List, current test don't throw errors. However, the code that's generated has some problems:

The register allocation sometimes uses the rsp register which causes segfaults. I don't think there's an option to  ban certain registers from being used in the current code or give a partial coloring in the current code.
There are probably some bugs in liveness/allocation. For example for the program:
czynność f() -> Liczba {   jeśli(prawda)       zwróć 12   wpp zwróć 12 }
In one of the cases the the instruction mov rax, 12 is removed from the program despite being generated by linearization. This doesn't happen when the return values are different suggesting some code might be comparing the instructions by value.

I'm also not really sure about how to link the standard library. Currently the location of stdlib.c has to be passed as an argument same as other external code. This is not optimal, but I'm not sure what's the best way to do it.

The standard library should be in some fixed system-wide location, such as /usr/lib, ideally installed by some package manager. Alternatively, it can be added as a resource (at app/src/main/resources or so), and then it will be available at runtime (even if the program is packaged as a portable JAR), and it can be copied to some temporary location, like /tmp or ~/.cache.
For the time being, I think it should be sufficient to just assume that there is stdlib.o in the current directory.

One more thing that seems missing is returning non-zero exit code when compilation fails.

These two problems you listed will be fixed by PR #136, which will be merged after this one.

These two problems you listed will be fixed by PR #136, which will be merged after this one.

Integration fails on one of the tests but I'm not able to replicate it on any of my machines.


Mangadex chapter tracking resets to zero

Steps to reproduce

Read manga from mangadex.
Add tracking

Expected behavior
Mangadex tracker should update the chapters as i read.
Actual behavior
It briefly shows the number of chapter I'm in currently but then immediately resets to zero automatically. Even if I manually update the chapter number it resets.
Crash logs

Tachiyomi version
Preview 425
Android version
Android 11
Device
Realme 6i
Other details
It is happening since release 425 I think.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.7.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Mangadex currently does not support chapter tracking so its currently disabled


Add-user script generates invitation link instead of password

Is your feature request related to a problem?
Nope
Describe the feature you'd like
./add-user.py is used to bootstrap the application with it's first admin user. This should spit out a registration link instead of spitting out a generated password. We already have the invitetoken concept, though there is another issue with that - #277
Have you considered alternative ways to get this feature
Well we could leave it the way it is but that seems unfavorable

👍


tests/kernel/interrupt: Assertion Failure in test_prevent_interruption

To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=qemu_x86
make
make run

Screenshots or console output

***** delaying boot 1000ms (per build configuration) *****
***** Booting Zephyr OS v1.14.0-rc3-192-g100a2bba6c57 (delayed boot 1000ms) *****
Running test suite interrupt_feature
===================================================================
starting test - test_nested_isr
SKIP - test_nested_isr
===================================================================
starting test - test_prevent_interruption

 Assertion failed at zephyr.git/tests/kernel/interrupt/src/nested_irq.c:116: offload_function: (check_lock_new equal to check_lock_old)

Interrupt locking didn't work properly
FAIL - test_prevent_interruption
===================================================================
Test suite interrupt_feature failed.
===================================================================
RunID: ci-190410-1550-659:uytl
PROJECT EXECUTION FAILED

Environment (please complete the following information):

OS: fedora29
Toolchain zephyr
Commit SHA or Version used: 110cab8aa37e0c08824cebae7047a042e56f8377

Additional context
Add any other context about the problem here.

@cinlyooi-intel I can't reproduce it in my environment. It works for for me.
west build -b qemu_x86 tests/kernel/interrupt/
west build -t run

Booting from ROM..***** Booting Zephyr OS v1.14.0-rc3-193-g110cab8aa37e *****
Running test suite interrupt_feature
===================================================================
starting test - test_nested_isr
SKIP - test_nested_isr
===================================================================
starting test - test_prevent_interruption
PASS - test_prevent_interruption
===================================================================
Test suite interrupt_feature succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

@overheat @wentongwu As it is triggered by an assertion, it definitely did happened. However, I think this might be one of the rarely occurred bug. This is the first time I see in about two weeks worth of daily triaging every possible failure in preparation for 1.14.

cant reproduce.


Invert Color

When the MultiApp starts, the display shows invert color. It seems a common problem on other M5 Stack apps recently.

That problem may be caused by a change on new M5Stack hardware. They may use a different LCD variant that need a different driver setting.

M5 Stack apps on Arduino IDE can resolve the invert color after recompilation probably using different/updated default driver setting as you identified.


simple-btn always send "1" as data

when I send in config like
{"id":1,"data":2,"...
after button click I get data=1

Try new widgets in 2.1.0


[Bug]: Code does not download pdf file from link

Bug expectation
The code is supposed to download the pdf file from the link and save to my machine, but it doesn't.
Bug behavior

[ ] Flaky
[ ] PDF

Minimal, reproducible example
const puppeteer = require("puppeteer");
(async () => {
  const browser = await puppeteer.launch({
    headless: false,
  });
  const page = await browser.newPage();

  await page.goto(
    "https://www.thecampusqdl.com/uploads/files/pdf_sample_2.pdf"
  );
  const client = await page.target().createCDPSession();
  await client.send("Browser.setDownloadBehavior", {
    behavior: "allow",
    downloadPath: "C:/meu local/",
  });
})();

Error string
no error
Puppeteer configuration
No response
Puppeteer version
19.5.2
Node version
18.12.0
Package manager
npm
Package manager version
8.19.2
Operating system
Windows

A couple of things:

You need to configure the download behaviour before downloading. It was not allowed before the configuration, and when you got to the page it was prohibited, so it did not download.
You need to configure the download behaviour for the same CDP session so using page.target().createCDPSession()  is also problematic. Since, as far as I recall, puppeteer does not provide and interface to the used CDP session currently, you can use page._client() to access it. NOTE: Accessing the client via the internal-api is subject to changes and is subject to changes.

All in all, this is a fixed code that should work for you:
const puppeteer = require("puppeteer");
(async () => {
  const browser = await puppeteer.launch({
    headless: false,
  });
  const page = await browser.newPage();
  const client = page._client();
  await client.send("Browser.setDownloadBehavior", {
    behavior: "allow",
    downloadPath: "C:/meu local/",
  });
  await page.goto(
    "https://www.thecampusqdl.com/uploads/files/pdf_sample_2.pdf"
  );

})();

I believe it's the same as https://github.com/puppeteer/puppeteer/issues/299 Try using the workarounds @Kle0s mentions or other in that issue thread.

hello. i have a problem.
I use this code https://github.com/puppeteer/puppeteer/issues/9557#issuecomment-1399441291
into Visual Studio Code (MacOS).
Once the script is started from Visual Studio, the browser opens with the PDF viewer but it is not saved in the folder. If you manually press the icon, it is saved in the chosen folder. How is it resolved?

@CloudItaly try using headless: true


Fix CDATA context

When the cursor was positioned on an opening or closing CDATA block, the context parser should stop and classify the context as content. Before this fix, the parser will skip the CDATA annotation and continue parsing beyond the target position. This could result in invalid node stacks resolution when the context is positioned exactly over these CDATA elements.
To detect when the cursor is on the CDATA block, these methods were added. The rest of the empty methods must be declared to implement the LexicalHandler for SAX defined here.
Additional tests were added to verify the fix.

Cool, thanks a lot!

Thanks to you for having a look!


Nextjs 13 Frontend

This adds the Nextjs 13 frontend based on a template by shadcn
The template includes:

Next.js App directory
Tailwind CSS
TypeScript
ESLint
Prettier

I've added:

Secondary nav
The ability to select tags to discover

@NicoSerranoP @hackertron merge completed


Expression operators

No issue to close. Related to #401, #400 and #402
Description
This PR adds:

new query analyser for DDL and DML queries
new query planner for DDL queries
new query executor for DDL queries

Is it a feature that change user experience?
no - this is rewrite of query execution functionality
Client output
queries DROP [SCHEMA|TABLE] IF EXISTS <first>, <second> are broken because schema change queries planning and execution were changed and requires additional enhancements

Pull Request Test Coverage Report for Build 445328254

3833 of 4415 (86.82%)  changed or added relevant lines in 70 files are covered.
50 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.9%) to 89.784%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/description/src/lib.rs
5
6
83.33%

src/types/src/lib.rs
6
7
85.71%

src/data_manager/src/tests/persistence.rs
28
30
93.33%

src/data_manager/src/tests/queries.rs
21
23
91.3%

src/data_manager/src/tests/system_schema/schema.rs
85
87
97.7%

src/node/src/lib.rs
0
2
0.0%

src/plan/src/lib.rs
3
5
60.0%

src/query_planner/src/create_table.rs
3
5
60.0%

src/data_definition/src/lib.rs
12
15
80.0%

src/storage/src/in_memory.rs
24
27
88.89%

Files with Coverage Reduction
New Missed Lines
%

src/query_analyzer/src/lib.rs
1
74.38%

src/data_manager/src/lib.rs
2
57.91%

src/description/src/lib.rs
3
80.36%

src/query_executor/src/ddl/drop_table.rs
3
0%

src/plan/src/lib.rs
4
81.25%

src/query_executor/src/ddl/create_schema.rs
4
0%

src/query_executor/src/ddl/create_table.rs
4
0%

src/query_executor/src/ddl/drop_schema.rs
6
0%

src/query_executor/src/lib.rs
23
25.0%

Totals

Change from base Build 410390414:
-0.9%

Covered Lines:
10458

Relevant Lines:
11648

💛  - Coveralls


Add conversion for tosa reduce ops

This adds conversions for all tosa reduce ops. Also adds unit tests and regression tests.

FYI, you should be able to add suggestions to a batch and do a single commit :)


Flexible continue configuration with external python (aka frozen packages fix)

Problem(s)

[Main] Currently python and all dependencies are distributed using pyinstaller and @sestinj mentioned the 'frozen' package terminology not allowing for importing external modules in config or their custom steps.
Users don't have intelisence when editing their custom continue config
Startup is slow. I think we should be able to speed it up because we woudn't need to load all executable into memory like we do with pyinstaller
Users can't debug their scripts using breakpoints

Solution
Solves the main problem, but lays ground work for others.
Setup a full python environment in .continue

Have a prerequisite a user has python installed - for instance vscode native python extension assumes you have it in your path already.
Install poetry with all the packages in .continue folder. I have played around with using execa, a cross platform child process library
Distribute python server sources with the extension, or similarly upload to s3
Install the continue core dependencies within the .venv within .continue
Allow additional file to source user dependencies from (will also be in .continue somewhere).
Finally allow users to add their own python files somewhere in .continue that can use any of the core or user dependencies.
Bonus - setup a .vscode in .continue with the goodies to allow users get intelisence + debugging of their custom scripts

Some background: before we were doing something very similar:

Create python venv (not with poetry because that requires an additional installation, more surface area for things to go wrong)
Install dependencies from a .whl file
Activate the venv
Run the python file from the venv

Issues with this:

Dependency resolution is SUPER slow, especially on Windows. It sometimes took >5 minutes to download the packages. To me this means that we would absolutely have to package them together is S3, or maybe there is some other way around this
Much more surface area for mistakes. Since moving toward pyinstaller, we've basically eradicated all startup issues. With enough testing, maybe I could be confident in another approach, but it was quite bad before and I want to avoid this
Requires python to be installed. Surprisingly often python isn't installed on someone's computer

Upsides we are attempting to gain:

Intellisense in the config file (note that in the worst case, one way to achieve this is by downloading the source code to a folder that doesn't do anything except provide reference for the interpreter)
Faster startup (potentially). There are two versions of this: 1) upon initial download, downloading dependencies locally was slower, but 2) after subsequent updates, we get to cache the dependencies instead of downloading and starting
Allow outside deps!

Resolution. You are right, we shouldn't run resolution on the clients at all. Could potentially be overcome by using something like setuptools to bundle all dependencies in a 'fat' wheel and download that.
Indeed the setup will be harder to get right.
Python distribution. I tried looking for a cross platform python bash one liner installer and failed. A hack that might work:

Create a simple bootstrap.py with code to create a virtual environment with its own python interpreter (venv is available from within python as far as I understand)
Package it with pyinstaller so we can simply run the binary on the user's device
Now that we have .venv we can download our fat wheel from step 1 and run_continue_server.py

I think its worth mentioning I have never distributed a python program this way. It might be a smart idea to try to get someone with experience. They would figure it out x5 most likely. For example one of the contributors from either of packaging tools pyinstaller, cx_Freeze or setuptools to help with this on a contract basis. There is also a company that specializes in this, maybe they can offer a contract or pitch their own solution https://www.activestate.com/company/contact-us/

I like the fat wheel idea. Main drawback is that you must have Python installed, but there's no reason we can't just "if python installed then download pyinstaller binary instead". Thoughts on this? It seems probably true that the intersection of users that a) don't have python installed and b) want to use custom imports in the config file, is probably small.
Setup will be harder, but this just means making sure testing gives enough confidence., and some of this is already setup.

My idea is still only use the system python for bootstrapping the venv that will have its own python installation with the version we want.
You are right that the dual setup would work for 99% of the users.
For own sanity I would still suggest trying the bootstrapping venv with pyinstaller. I want to give it a try sometime within the next couple of days. Very curious if this hack would actually work. That's the closest I will ever get to a OS boot loader hacker

Yet another promise of a cross platform python runtime PyOxy
An internet friend pointed me to this thing: https://gregoryszorc.com/docs/pyoxidizer/main/pyoxy.html which looks promising

@bra1nDump Finally...we have a solution for this : ) Using typescript with esbuild, theoretically any package can be bundled!

That's awesome! I heard santa really endorses projects using a single runtime this year. Wait ... maybe they have to be deer powered


DG cleanup

Codecov Report

Merging #296 (e973631) into master (3f7e2ef) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #296   +/-   ##
=========================================
  Coverage     84.37%   84.37%
  Complexity     1629     1629
=========================================
  Files           142      142
  Lines          4256     4256
  Branches        536      536
=========================================
  Hits           3591     3591
  Misses          548      548
  Partials        117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7e2ef...e973631. Read the comment docs.


Enquiry on "The dataset is too large to download." message

Hi
I have setup dataverse 5.5 using this docker compose file https://github.com/IQSS/dataverse-docker/blob/master/docker-compose.yml
I have uploaded a dataset that is only 19kb. However, I got this message  "The dataset is too large to download" in the screenshot.

Can I check if this is the default behaviour or I have missed out any steps?
Thank you very much

I hadn't realized you sent this to the Dataverse Previewers repository, where there are fewer people watching. This question is one that would be best to ask on the community mail list, in chat, or on the giithub.com/IQSS/dataverse repository which is for the main Dataverse software.
That said - I think 5.5 may still have shipped with the default for https://guides.dataverse.org/en/latest/installation/config.html#zipdownloadlimit at 0 bytes - if you enter a larger value, that may fix your problem. (Later versions have a more reasonable default.)

This question is one that would be best to ask on the community mail list, in chat, or on the giithub.com/IQSS/dataverse repository which is for the main Dataverse software.

https://github.com/IQSS/dataverse-docker/issues is probably a good place to ask too, since you mentioned that repo, @debug1g
Perhaps some extra config is done by dataverse-docker, I mean. 19 KB is awfully small though. 😄

FWIW: I think it was this: https://github.com/IQSS/dataverse/pull/8015 - went into 5.6.

@qqmyers ah yes, and https://github.com/IQSS/dataverse/issues/7932 explains quite well what the problem was:

In v5.5, not having a ZipDownloadLimit set results in a limit of 0 being returned and that disables all Zip Downloads. The docs say there is a default limit of 100MB, but the code in SystemConfig sets the default to 0.

And yes, your suggestion above should work:

That said - I think 5.5 may still have shipped with the default for https://guides.dataverse.org/en/latest/installation/config.html#zipdownloadlimit at 0 bytes - if you enter a larger value, that may fix your problem. (Later versions have a more reasonable default.)

Sorry for the noise. 😄

thanks qqmyers and pdurbin for the advice. The problem is now fixed. thank you very much!


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_47ot47e_6n/clone/recipe/meta.yaml:0: jinja_render_failure: The recipe could not be rendered by Jinja2
Errors were found


robot version search not working

Describe the bug
Search function for to query for a specific robot versions is not implemented.
This is a problem because all robot versions are stored with the same name.
To Reproduce
** Two different robots version should be already loaded.
Steps to reproduce the behavior:

Go to Robot Framework view http://<IP_ADDRESS>:8000/sources/robot/
Click on the Search Textbox
Enter any existing robot version

Expected behavior
all matches to a specific robot version should be displayed
Screenshots

Desktop (please complete the following information):

OS: macOS 10.15
Browser chrome
Version 83.0.4103.116

Additional context
Add any other context about the problem here.

duplicated of #321


Fixes tls protocol and cipher match check judgment, adapt TLS 1.3 Protocol only with TLS 1.3 cipher

Fixes tls protocol and password match check judgment, adapt TLS 1.3 Protocol only with TLS 1.3 cipher
When tls1.3 is specified in the tls protocol and only the corresponding cipher is supported, it will prompt failure in the process of SSL_CTX_set_cipher_list and SSL_set_cipher_list.
For example, in nginx , config
ssl_protocols TLSv1.3;
ssl_ciphers TLS_AES_256_GCM_SHA384;
It will be prompted before fixing “SSL_CTX_set_cipher_list ("TLS_AES_256_GCM_SHA384") failed (SSL: error: 1410D0B9: SSL routines: SSL_CTX_set_cipher_list: no cipher match)”

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Hi  @t8m  hope you are well
In fact, what the CLA detects is a no-relay mailaddress. Can I send the CLA file with my real mailbox?

You can put multiple e-mail addresses into the ICLA - i.e., put there both - the regular one and the github no-relay one.

One thing to note though, we've historically were against TLS-1.3 ciphersuites in the cipher list spec and I am not sure we want to change it. @mattcaswell ?

Thanks for the reminder, actually in use. Agree to have stricter requirements for the support list, but match detection expectations can be more decoupled

One thing to note though, we've historically were against TLS-1.3 ciphersuites in the cipher list spec and I am not sure we want to change it. @mattcaswell ?

One thing to note though, we've historically were against TLS-1.3 ciphersuites in the cipher list spec and I am not sure we want to change it. @mattcaswell ?

Right. We have considered the TLSv1.2 and below ciphersuite list and the TLSv1.3 list as completely separate things. I don't think we want to change that position.

One thing to note though, we've historically were against TLS-1.3 ciphersuites in the cipher list spec and I am not sure we want to change it. @mattcaswell ?

Right. We have considered the TLSv1.2 and below ciphersuite list and the TLSv1.3 list as completely separate things. I don't think we want to change that position.

Agree to separate them,so I submitted this MR to differential judgment

Agree with use SSL_set_ciphersuites or SSL_CTX_set_ciphersuites to set ciphersuites.
but, this modification just for compatibility with protocol and cipher match checking, not really for setting

Sorry, but to set TLS1.3 ciphers this is the wrong API. SSL_set_cipher_list and SSL_CTX_set_cipher_list are meant to set the TLS1.2 ciphers only. I think You are supposed to use SSL_set_ciphersuites or SSL_CTX_set_ciphersuites instead.

Agree with use SSL_set_ciphersuites or SSL_CTX_set_ciphersuites to set ciphersuites.
but, this modification just for compatibility with protocol and cipher match checking, not really for setting

I may be wrong, but I think it is neither possible to add TLS1.3 ciphersuites nor to remove TLS1.3 ciphersuites
with SSL_set_cipher_list or SSL_CTX_set_cipher_list they are only settable with SSL_set_ciphersuites and
SSL_CTX_set_ciphersuites.
Furthermore it is common practice to set the cipher list before setting the min/max tls protocol version,
so the min/max_protocol_version values used here may not reflect the final values.