Installing nodegit via npm fails at Configuring libssh2.

When I try installing nodegit via npm it keeps throwing the following error. I tried the following:

brew reinstall gcc
I tried reinstalling node via brew and also via the node installer
sudo xcode-select --install

Is there anything else I can do? - Having the same issue even on other machines, all running MacOS Sierra.
My Node Version is: v6.11.2
My NPM Version is: 3.10.10
Console Output after npm install nodegit:
[nodegit] Running pre-install script
[nodegit] Configuring libssh2.
{ Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1020:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:367:16)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn /bin/sh',
  path: '/bin/sh',
  spawnargs:
   [ '-c',
     '/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/openssl/openssl' ],
  cmd: '/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/openssl/openssl' }

[nodegit] ERROR - Could not finish preinstall
{ Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1020:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:367:16)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn /bin/sh',
  path: '/bin/sh',
  spawnargs:
   [ '-c',
     '/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/openssl/openssl' ],
  cmd: '/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/Users/timeoschmidt/Desktop/Freiheit\\ Praktikum/Node\\ Upload\\ Repo/node_modules/nodegit/vendor/openssl/openssl' }
npm ERR! Darwin 16.7.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "nodegit"
npm ERR! node v6.11.2
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node lifecycleScripts/preinstall && node lifecycleScripts/install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node lifecycleScripts/preinstall && node lifecycleScripts/install'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nodegit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node lifecycleScripts/preinstall && node lifecycleScripts/install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nodegit
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nodegit
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/timeoschmidt/Desktop/Freiheit Praktikum/Node Upload Repo/npm-debug.log

( If I am running the same command with global -g argument, it seems to install without errors, but my scripts using nodegit still throw the error: Error: Cannot find module 'nodegit' ).
I would really appreciate help or references to other issues with things I can try.

I am trying to install nodegit via npm and get the same error:
$ npm install nodegit
npm WARN package.json @ No repository field.
npm WARN package.json @ No license field.
\
><EMAIL_ADDRESS>install C:\dev\AlphaHelp\helpserver\node_modules\nodegit
> node lifecycleScripts/preinstall && node lifecycleScripts/install

[nodegit] Running pre-install script
[nodegit] npm@2 installed, pre-loading required packages
[nodegit] Running install script
node-pre-gyp
ERR! Tried to download(403): https://nodegit.s3.amazonaws.com/nodegit/nodegit/nodegit-v0.20.1-node-v46-win32-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v46 ABI) (falling back to source compile with node-gyp)
gyp

ERR! configure error
gyp
ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
gyp ERR! stack     at Object.failNoPython (C:\dev\AlphaHelp\helpserver\node_modules\nodegit\node_modules\node-gyp\lib\configure.js:483:19)
gyp ERR! stack     at Object.<anonymous> (C:\dev\AlphaHelp\helpserver\node_modules\nodegit\node_modules\node-gyp\lib\configure.js:508:16)
gyp
ERR! stack     at C:\dev\AlphaHelp\helpserver\node_modules\nodegit\node_modules\node-gyp\node_modules\graceful-fs\polyfills.js:284:29
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:82:15)
gyp ERR! System Windows_NT 10.0.15063
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\dev\\AlphaHelp\\helpserver\\node_modules\\nodegit\\node_modules\\node-gyp\\bin\\node-gyp.js" "configure" "--fallback-to-build" "--module=C:\\dev\\AlphaHelp\\helpserver\\node_modules\\nodegit\\build\\Release\\nodegit.node" "--module_name=nodegit" "--module_path=C:\\dev\\AlphaHelp\\helpserver\\node_modules\\nodegit\\build\\Release"
gyp ERR!
cwd C:\dev\AlphaHelp\helpserver\node_modules\nodegit
gyp ERR! node -v v4.4.2
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
node-pre-gyp
ERR! build error
node-pre-gyp
ERR! stack Error: Failed to execute 'C:\Program Files\nodejs\node.exe C:\dev\AlphaHelp\helpserver\node_modules\nodegit\node_modules\node-gyp\bin\node-gyp.js configure --fallback-to-build --module=C:\dev\AlphaHelp\helpserver\node_modules\nodegit\build\Release\nodegit.node --module_name=nodegit --module_path=C:\dev\AlphaHelp\helpserver\node_modules\nodegit\build\Release' (1)
node-pre-gyp
ERR! stack     at ChildProcess.<anonymous> (C:\dev\AlphaHelp\helpserver\node_modules\nodegit\node_modules\node-pre-gyp\lib\util\compile.js:83:29)
node-pre-gyp ERR! stack     at emitTwo (events.js:87:13)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:827:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
node-pre-gyp
ERR! System Windows_NT 10.0.15063
node-pre-gyp
ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\dev\\AlphaHelp\\helpserver\\node_modules\\nodegit\\node_modules\\node-pre-gyp\\bin\\node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd C:\dev\AlphaHelp\helpserver\node_modules\nodegit
node-pre-gyp ERR! node -v v4.4.2
node-pre-gyp ERR! node-pre-gyp -v v0.6.37
node-pre-gyp
ERR! not ok
Failed to execute 'C:\Program Files\nodejs\node.exe C:\dev\AlphaHelp\helpserver\node_modules\nodegit\node_modules\node-gyp\bin\node-gyp.js configure --fallback-to-build --module=C:\dev\AlphaHelp\helpserver\node_modules\nodegit\build\Release\nodegit.node --module_name=nodegit --module_path=C:\dev\AlphaHelp\helpserver\node_modules\nodegit\build\Release' (1)
[nodegit] ERROR - Could not finish install
[nodegit] ERROR - finished with error code: 1
npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "nodegit"
npm ERR! node v4.4.2
npm ERR! npm  v2.15.0
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node lifecycleScripts/preinstall && node lifecycleScripts/install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node lifecycleScripts/preinstall && node lifecycleScripts/install'.
npm ERR! This is most likely a problem with the nodegit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node lifecycleScripts/preinstall && node lifecycleScripts/install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nodegit
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls nodegit
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\dev\AlphaHelp\helpserver\npm-debug.log

no. Doing --save does not fix it for me. I still get
[nodegit] Configuring libssh2.
{ Error: spawn /bin/sh ENOENT
    at _errnoException (util.js:1021:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:192:19)
    at onErrorNT (internal/child_process.js:374:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn /bin/sh',
  path: '/bin/sh',
  spawnargs:
   [ '-c',
     'server/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/mnt/c/Users/Martin\\ Muzatko/dev/bitbucket/sic
on/server/node_modules/nodegit/vendor/openssl/openssl' ],
  cmd: 'server/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/mnt/c/Users/Martin\\ Muzatko/dev/bitbucket/s
icon/server/node_modules/nodegit/vendor/openssl/openssl' }

[nodegit] ERROR - Could not finish preinstall
{ Error: spawn /bin/sh ENOENT
    at _errnoException (util.js:1021:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:192:19)
    at onErrorNT (internal/child_process.js:374:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn /bin/sh',
  path: '/bin/sh',
  spawnargs:
   [ '-c',
     'server/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/mnt/c/Users/Martin\\ Muzatko/dev/bitbucket/sic
on/server/node_modules/nodegit/vendor/openssl/openssl' ],
  cmd: 'server/node_modules/nodegit/vendor/libssh2/configure --with-libssl-prefix=/mnt/c/Users/Martin\\ Muzatko/dev/bitbucket/s
icon/server/node_modules/nodegit/vendor/openssl/openssl' }

><EMAIL_ADDRESS>install /path_of_my_project/node_modules/nodegit

> node lifecycleScripts/preinstall && node lifecycleScripts/install

[nodegit] Running pre-install script

[nodegit] Configuring libssh2.

{ Error: Command failed: /path_of_my_project/node_modules/nodegit/vendor

/libssh2/configure

--with-libssl-prefix=/path_of_my_project/node_modules/nodegit/vendor/openssl/openssl

/path_of_my_project/node_modules/nodegit/vendor/libssh2/missing:

Unknown `--is-lightweight' option

Try `/path_of_my_project/node_modules/nodegit/vendor

/libssh2/missing --

help' for more information

configure: WARNING: 'missing' script is too old or missing  rm:

cannot remove 'conftest': Input/output error configure:

error: No crypto library found!

Try --with-libssl-prefix=PATH  or --with-libgcrypt-prefix=PATH or --with-wincng on Windows

at ChildProcess.exithandler (child_process.js:275:12)

at emitTwo (events.js:126:13)

at ChildProcess.emit (events.js:214:7)

at maybeClose (internal/child_process.js:925:16)

at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)

killed: false,

code: 1,

signal: null,

cmd: '/path_of_my_project/node_modules/nodegit/vendor

/libssh2/configure

--with-libssl-prefix=/path_of_my_project/node_modules/nodegit/vendor/openssl/openssl'

}/path_of_my_project/nodegit/vendor/libssh2/missing:

Unknown `--is-lightweight' option

Try `/path_of_my_project/node_modules/nodegit/vendor

/libssh2/missing --

help' for more information

configure: WARNING: 'missing' script is too old or missing

rm: cannot remove 'conftest': Input/output error

configure: error: No crypto library found!

Try --with-libssl-prefix=PATH

or --with-libgcrypt-prefix=PATH

or --with-wincng on Windows

[nodegit] ERROR - Could not finish preinstall

{ Error: Command failed: /path_of_my_project/node_modules/nodegit/vendor/libssh2/configure

--with-libssl-prefix=/path_of_my_project/node_modules/nodegit/vendor

/openssl/openssl

/path_of_my_project/node_modules/nodegit/vendor/libssh2/missing:

Unknown `--is-lightweight' option

Try `/path_of_my_project/node_modules/nodegit/vendor

/libssh2/missing --

help' for more information

configure: WARNING: 'missing' script is too old or missing

rm: cannot remove 'conftest': Input/output error

configure: error: No crypto library found!

Try --with-libssl-prefix=PATH

or --with-libgcrypt-prefix=PATH

or --with-wincng on Windows

at ChildProcess.exithandler (child_process.js:275:12)

at emitTwo (events.js:126:13)

at ChildProcess.emit (events.js:214:7)

at maybeClose (internal/child_process.js:925:16)

at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)

killed: false,

code: 1,

signal: null,

cmd: '/path_of_my_project/node_modules/nodegit/vendor

/libssh2/configure

--with-libssl-prefix=/path_of_my_project/node_modules/nodegit/vendor/openssl/openssl' }

@ThiagoDallacqua Are you on macOS Sierra?

nope Ubuntu

@ThiagoDallacqua Try sudo apt-get install libssl-dev libcurl4-openssl-dev.
If not, you could also try sudo apt-get install curl libcurl3.

@rcjsuen it worked, but now the problem comes from post-install
[nodegit] WARN - Could not finish postinstall

{ Error: Command failed: node "/path_of_my_project/node_modules/nodegit/dist/nodegit.js"

/path_of_my_project/node_modules/nodegit/dist/nodegit.js:15

throw ex;

^

Error: /path_of_my_project/node_modules/nodegit/build/Release/nodegit.node: cannot enable

executable stack as shared object requires: Invalid argument

at Object.Module._extensions..node (module.js:664:18)

at Module.load (module.js:554:32)

at tryModuleLoad (module.js:497:12)

at Function.Module._load (module.js:489:3)

at Module.require (module.js:579:17)

at require (internal/module.js:11:18)

at Object.<anonymous> (/path_of_my_project/node_modules/nodegit/dist/nodegit.js:11:12)

at Module._compile (module.js:635:30)

at Object.Module._extensions..js (module.js:646:10)

at Module.load (module.js:554:32)

at ChildProcess.exithandler (child_process.js:275:12)

at emitTwo (events.js:126:13)

at ChildProcess.emit (events.js:214:7)

at maybeClose (internal/child_process.js:925:16)

at Socket.stream.socket.on (internal/child_process.js:346:11)

at emitOne (events.js:116:13)

at Socket.emit (events.js:211:7)

at Pipe._handle.close [as _onclose] (net.js:554:12)

killed: false,

code: 1,

signal: null,

cmd: 'node "/path_of_my_project/node_modules/nodegit/dist/nodegit.js"' }

@ThiagoDallacqua #1282 and Microsoft/WSL#916 looks related but not sure if they will be of any help to you.

Similar issue on Amazon Linux solved with:
sudo yum install libgcrypt-devel

@tamastimar This resolved the issue for me on macOS High Sierra 10.13.1
Thank you!

Running: macOS Sierra
Ran brew doctor and got a warning saying to update xcode command line tools.
Worked after updating.

There is a problem with spaces into the Path "\ " and then the error appears.

Remove the spaces into your folder and it will work.

This is easily said but not easily done, especially when your path is relative to a given server hostname that decided that it needed spaces.
What is the proper way to escape that in the script?

@tamastimar solve worked for me on High Sierra, though I did run through all the libgcrypt and openssl reinstall steps first without success. So it's possible both fixes are required.

brew install libgcrypt was the fix for me

This error has come back in an update to Mac OS High Sierra 10.13.5. Using brew install libgcrypt no longer works as a fix. I've tried everything. Including installing xcode beta 10_2. The issue arose after an update to xcode command line tools that I've been unable to revert for some reason.

 I will just use docker to deliver the environment nodegit needs.
That nobody took the time and fixed the script by escaping the path shows me how less the team cares about cross-platform adaptability.
I'm not the best with bash either, but this should suffice: https://apple.stackexchange.com/a/52485

sudo xcode-select --install does not fix this any more on macOS Mojave

@dvakatsiienko I've the same issue, but I get all kind of weird permission denied errors, and brew cannot be run as sudo anymore. Ideas?

@biohazard999 try to run brew doctor it will tell you issues and possible solutions.
Do you have npm-related permission issues?
If so, it will also break nodegit. I mean sudo npm install nodegit will not work.
It will work only without sudo. If so, try this guide to fix npm permissions

@dvakatsiienko Thanks, worked for me!

This should be fixed in latest. Can someone try installing at 0.23.0-alpha.1?

I solved this issue by running "sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target /" on my macOS.


pin poetry version

changes

pin poetry version to version seen in latest tests on main

notes

this PR is a follow up to https://github.com/NYCPlanning/db-data-library/pull/366 and replaces https://github.com/NYCPlanning/db-data-library/pull/347
can't use original PR (https://github.com/NYCPlanning/db-data-library/pull/347) because it's a branch in SPTKL's remote repo so we can't push new commits to that branch
test failing in this PR is known and expected pytest failure, same as on main

@mbh329 dropped the PATH edits from the dockerfile!

merging this branch since @mbh329 and I talked it over. the urgency is because poetry is now failing on main and other dev branches (but not on this branch)


local csars were deleted for they were not accessed too long

Hi.
I'm not so sure whether this is an issue or it is a temp strategy.
Right now, the CSARs will be stored to a temp path(java.io.tmpdir). But the files under temp path will be deleted automatically. For example, in my system, temp files will be deleted if they are not accessed for 10 days. But CSARs are application data, the should not be deleted automatically. Whether the store location  should be changed a new path, so it should not be deleted for unknown?
Regards.

Hi,
the container normally uses the system temp folder to store its files, such as CSARs, so yes depending on the system those may be deleted. I've commited (b113338c3918264853770f8a5acb145afa85a52) a work-around, where you can set a VM argument like this: -DopenTOSCAPath=/home/ubuntu. The working dir of the container would than be /home/ubuntu/openTOSCA.
An alternative would be to alter the .product configuration under org.opentosca.container.product or the config.ini in the binary distribution.
Regards

thx it helps a lot.
Regards

Hi,
Another question, there was a startup.sh file in the early version in which i can set the VM argument. But now container is started by a compiled file OpenTOSCA, how should I set the  VM argument DopenTOSCAPath? could you give me some guidance? thx.
Regards.

Under {openTOSCARoot}/configuration/config.ini add the following line if you want the container to use the path /home/ubuntu/openTOSCA:
openTOSCAPath=/home/ubuntu

OK, thx.
Regards.


Try optimx with hjkb instead of optim

Not easy to get working.

Note even just switching optim with optimx::optimr with everything the same causes problems. Better to allow after certain number of iterations

not followirg


test lat/lng/type removal

Bummer.

Yeah I didn't really expect it to pass but now I have a sense of what I need to work on next to get this removed.


reproducible environment for finetuning

aim is to make everyones life easier to experiment with AI
requirements & deliverables

use python script to setup a VM in VAST.AI (all automated)
easy install (integrated with the setup script on VAST.AI)

bash script for installing all required components (use Ubuntu 22.04)
requirements script for pip install (required python components)
a test script to check the cuda is working in right version & the GPU is found with minimal requirements

a python script which parses pdf (use pdf2text commandline, not the python version), uses wiki txt files, download a website e.g. manual.grid.tf and question/answer files for finetuning and populates the model
experiment with multiple models and demonstrate results (timing, quality, ...)

falcon 7B
falcon 70B (load on 40 GB GPU, there are tricks)
falcon 70b on DUAL GPU A6000 instance
llama2 (see if better)

bring openai compatible API life on top of Avast GPU machine (ok to do SSH portforwarding)
all is opensource

gpu usage

use instances on https://cloud.vast.ai/instances/ (A6000 max, but 24 GB Gpu's would be better)

some info which can be used
Fine-tuning Large Language Model (LLM) on a Custom Dataset with QLoRA _ MLExpert - Crush Your Machine Learning interview.pdf
implementation details

all scripts use 'set -ex' to make sure they stop when error
can also use vscript (see vlang) as alternative to bash, we have quite some primitives working see crystallib (ask codescalers team for help if needed)
put some example pdf, and text files in this repo' so its easy for people to experiment
use info from threefold and see how the results are for questions and answer: https://manual.grid.tf/

Chat with Multiple PDFs using Llama 2 and LangChain _ MLExpert - Crush Your Machine Learning interview.pdf
Private GPT4All_ Chat with PDF Files Using Free LLM _ MLExpert - Crush Your Machine Learning interview.pdf
Private Chatbot with Local LLM (Falcon 7B) and LangChain _ MLExpert - Crush Your Machine Learning interview.pdf

Support Chatbot using Custom Knowledge Base with LangChain and Open LLM _ MLExpert - Crush Your Machine Learning interview.pdf


Decorator doesn't forward self to decorated methods

Decorator doesn't forward self to decorated methods.
Works:
@lambda_handler
def handler(event, context):
    pass

Fails:
class Adapter:
    @lambda_handler
    def handler(self, event, context):
        pass

# TypeError: handler() missing 1 required positional argument: 'context'

:tada: This issue has been resolved in version 3.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Run a mainnet test Mithril network

Issue
Start and run a Mithril test network that connects to a Cardano mainnet network and that runs the unreleased Cardano Node/CLI 1.36.0.
The goal of this issue is to validate that the computation of the stake distribution with the new query query stake-snapshot --all-stake-pools is working as expected.
Also we want to make sure that there is no other issue that would prevent a Mithril network to create certificates on the mainnet

The testing-mainnet network is producing snapshots and certificates as expected 🎉
We have also validated that the snapshot can be restored with the mithril-client


refactor: use ConfigType instead of Config

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.00%. Comparing base (8c078cb) to head (07e4dd0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   77.93%   78.00%   +0.06%
==========================================
  Files           6        6
  Lines         349      350       +1
==========================================
+ Hits          272      273       +1
  Misses         77       77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


⚠ ClamAV has degraded performance

In a82679f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 544 ms

Resolved: ClamAV performance has improved in ff2eeba.


Update fold and add tests.

@jbcrail seems like there is conflict with https://github.com/uutils/coreutils/pull/558#issuecomment-100096983

Thanks. The makefile had a conflict. I rebased the pull request and everything looks good now.


Format markdown

Produced via: prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)

/ok-to-test
/assign @evankanderson @grantr
Eventing Sources is a new addition, so this is the bigger initial one.


issues triage

I just take a look at some issues, here are some that I think can be closed (because they are either solved or invalid)  :

#90
#176
#177
#195

this one should be tested to confirm if it’s still an issue : #89

I have tested #83 against 2d404b8035f8dc349ebbf6b9281d173473a7c871, and it seems resolved:
steve@neith /tmp $ ~/dev/json-schema/bin/validate-json data.json schema.json
JSON does not validate. Violations:
[[2].thing] String value found, but an integer is required
[[2].thing] String value found, but a boolean is required
[[2]] Failed to match exactly one schema

@mathroc thanks


Simplifying CI

Coverage remained the same at 100.0% when pulling 6903c17fda638092332069b62a0efa49ebfc0946 on simply-ci into e1664addc57b55917f11d267847921b3289dec3b on master.

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.


fix: Updated managed switch endpoint

Changed managed switch endpoint to work with fw 7.2

Hi @bluecmd, could you review and approve this PR? :-)


[BUG] Unable to search for users

Please make sure you've tried the latest version of Fritter first, as the F-Droid version is sometimes out of date!

Describe the bug
I am unable to search for users within Fritter.
To Reproduce
Steps to reproduce the behavior:

Go to the Search Icon in the upper right corner of the main screen.
Input a User
Failure

Screenshots

Device

I have the same issue

Having the same issue rn

Hi i have the same isue

Hi i have the same isue

and the last estable relese 2.16.4 and the beta 5 3.0.0, beta 6 3.0.0 have the same behavior

This should now be fixed, thanks to #679


feat: allow babel cache to be enabled

Allow the babel cache to be disabled, thanks for the patch @Arturszott.
In this pull I make one tiny tweak, the environment variable is now simply not set if you set babel-cache=true.

Thanks! Looks great. Simplicity 🔥

@Arturszott did you ever get a chance to try this out? You should be able to use it if you run:
npm i nyc@next --save-dev

I have found this PR when debugging issue with nyc and babel
What exactly is the problem with babel cache and nyc? I can't find a reference to any issues, only this PR :) no matter how much I look

...hm, but it's true, there is some issue with nyc and babel cache
Any idea what is the underlying issue? :(


cleanup unused redux state

What's wrong

a lot of redux state is unused or minimally used. this is a first cut of investigating unused state. this is based on a quick look through so when removing, please make sure that they can really be removed

address slice

[x] remove addressVerified
[x] remove addressChangedViaMap
[x] remove fullAddress
[x] the weather api calls should be made in Location.js and and zipCode should be moved out of redux and be local to Location only
[x] remove zoneText
[x] remove zoneId and all updateZone dispatch calls
[x] remove lastZone
[x] remove lastZipCode

crop slice

[ ] move activeGrowthPeriod into local state for calendar view
[ ] remove snackOpen from crops slice, already exists in shared slice

filters slice

[ ] cropFiltersOpen should be local state in cropSidebar

map slice

[ ] remove regionLabel
[ ] remove regionShorthand
[ ] remove selectedRegion
[ ] remove council and add councilLabel, councilShorthand to default state

goals slice

[ ] remove allGoals
[ ] goalsOpen should be local state in CoverCropGoals.js

shared slice

[ ] remove snackHorizontal and snackVertical because they are never updated, make local to App.js
[ ] investigate and hopefully remove dataDictionary
[ ] investigate speciesSelectorActivationFlag

weather slice

[ ] remove pondingFrequency
[ ] remove weatherDataReset

soil slice

[ ] remove or do something with isSoilDataLoading
[ ] remove or use isSoilDataLoading

address slice section on PR https://github.com/precision-sustainable-ag/dst-selector/pull/428

DataDict was moved into myCoverCropComparison component which was the only place it was being used.  and the speciesSelectorActivationFlag looks to be used in a few places and get set to both true and false in different places.


Model and view updates to fix issues related to approving contact suggestions

Track date created/modified on contact and record instances
Save created (or existing) contact to contact suggestion's 'contact' field (prevent dupes on re-approvals)
get_or_create record instance when approving record suggestions

This is not a complete solution... BRB.


After you modify the time range, you can still create a schedule that is outside the scope

if i modify the time range in
        {
            viewName: name,
            renderStartDate: '',
            renderEndDate: '',
            hourStart: 8,
            hourEnd: 18,
            timezones: options.timezones,
            isReadOnly: options.isReadOnly,
            showTimezoneCollapseButton: false
        },
        options.week
    );```
but can still create a schedule out the time range.

@cx4 Please describe the issue in detail following the issue template.
Any example code reproducing the problem would be helpful.
Closing the issue since lack of information.


ng serve --aot Reference to a non-exported function

Versions
Angular CLI: 1.6.3
Node: 8.9.1
OS: darwin x64
Angular: 5.1.2
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.6.3
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.3
@schematics/angular: 0.1.11
typescript: 2.5.3
webpack: 3.10.0

Repro steps
When I run ng serve --aot I'm getting error what slideToLeftTransition and slideToLeft are not exported even if they are used just in this file.
import { Component, OnInit, Input, EventEmitter, Output } from '@angular/core';
import { trigger, state, animate, style, transition } from '@angular/core';

function slideToLeft() {
    return trigger('slideToLeftTransition', [
        state('void', style({ position: 'absolute', width: '80%' })),
        state('*', style({ position: 'absolute', width: '80%' })),
        transition(':enter', [
            style({ transform: 'translateX(100%)' }),
            animate('0.2s ease-in-out', style({ transform: 'translateX(0%)' }))
        ]),
        transition(':leave', [
            style({ transform: 'translateX(0%)' }),
            animate('0.2s ease-in-out', style({ transform: 'translateX(100%)' }))
        ])
    ]);
}

function slideToLeftTransition() {
    return slideToLeft();
}

@Component({
    selector: 'app-details-view',
    templateUrl: './details-view.component.html',
    styleUrls: ['./details-view.component.scss'],
    animations: [slideToLeftTransition()],
    host: {
        '[@slideToLeftTransition]': ''
    }
})
export class DetailsViewComponent implements OnInit {

    @Input() loading: boolean;
    @Output() close = new EventEmitter();

    constructor() { }

    ngOnInit() {
    }

    closeDetails($e) {
        this.close.emit($e);
    }
}

Observed behavior
ERROR in src/app/admin/shared/details-view/details-view.component.ts(19,10): Error during template compile of 'DetailsViewComponent'
  Reference to a non-exported function.

Desired behavior
I should not get these kind of errors if my typescript is actual valid source code and I should not need to export private functions to work just for specific angular aot compiler.

Hello, errors like Error encountered resolving symbol values statically mean that there has been some problem in statically analyzing your app.
Angular CLI always runs some statical analysis, even on JIT mode, in order to discover lazy-loaded routes.
This may cause a lot of static analysis errors to surface when importing your project into the CLI, or upgrading for older versions where we didn't run this kind of analysis.
Below are good resources on how to to debug these errors:

https://angular.io/guide/metadata
https://gist.github.com/chuckjaz/65dcc2fd5f4f5463e492ed0cb93bca60
https://github.com/rangle/angular-2-aot-sandbox#aot-dos-and-donts

If your problem still persists, it might be a bug with the Angular Compiler itself.
In that case, please open an issue in https://github.com/angular/angular.


[3.x] Fix texture atlas generation when source sprite is larger than generated atlas

Fixes #41414
The problem: atlas images getting cut off.

https://github.com/godotengine/godot/blob/3.4/editor/import/resource_importer_texture_atlas.cpp#L134
In this line, "xf" starts at the left margin in the original sprite frame (source) image. Which in my case is a 512x512 image with the eyeball in the middle and a lot of empty space around it. This 512x512 dimension is set to the src_width and src_height variables respectively.

The variables width and height in this function refer to the final atlas texture's width and height, which is 256x252 in this case. So the entire generated texture atlas (256x252) is smaller than a single source animation frame (512x512). That exposes this bug.
It looks like in this loop it's limiting by the generated atlas's width when it's actually looping through the source image's pixels.
for (int xi = (xf > 0 ? int(xf) : 0); xi < (xt < width ? xt : width - 1); xi++) {
So instead it should limit by the source image's width.
for (int xi = (xf > 0 ? int(xf) : 0); xi < (xt < src_width ? xt : src_width - 1); xi++) {
This indeed produces the correct results. And it makes sense why the images were getting cut off before.

There's already code that guarantees you're not drawing outside of the destination atlas texture's dimensions.
https://github.com/godotengine/godot/blob/3.4/editor/import/resource_importer_texture_atlas.cpp#L147
This width/src_width variable swap seems to have been a type-o. I don't think the same coding problem is present on the y axis, because my sprites would have been clipped off vertically as well.

Thanks!

Cherry-picked for 3.4.1.


In Production?

Is this being used in production anywhere? I'm starting a new project where I need a main (wrapper) angular app and multiple sub-apps written in angular. overmind hasn't been maintained in some time, so I was just wondering if it is still a good option. overmind looks like just what I need.

Hey Zack. We used it in production at Domo for a year or so then pulled it out in favor of the lazy loading that was to be part of angular 1.5. That functionality hasn't made it into Angular yet unfortunately. I don't really plan on maintaining this so you're probably better off using ocLazyLoad until Angular supports lazy loading.

Awesome! Thanks Dave!


fix RESOLVE_URIS_COMPLETED, to have one large action instead of hundr…

Fixes
Issue Number: https://github.com/OdyseeTeam/odysee-frontend/issues/727
What is the current behavior?
On http://localhost:9090/$/list/d91815c1bc8c80a1f354284a8c8e92d84d5f07a6 5x claim_search and 193x resolve requests are made.
What is the new behavior?
On http://localhost:9090/$/list/d91815c1bc8c80a1f354284a8c8e92d84d5f07a6 5x claim_search requests are made.
Other information
Nothing crashes as far as I've tested but probably needs a review by someone who knows whats what.
I didn't write much of this it was basically taken from ui/redux/actions/claims.js and I made sure that the data mapping made sense in redux.
PR Checklist
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change (Could be wrong though)
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

I didn't look too deep, but doing collectionItemsById[0].items feels like we will just handle 1 collection.  When loading "my collections" page, the variable could hold N collections.

Agreed (though in my experience collectionItemsById almost always has one element but better safe than sorry)

The map feels like an unnecessary extra loop?

True, I can change that, but the reason behind doing it this way is so that if need be later on processResult could be shared between claims.js and collections.js.

Move processResult outside of the loop?

Sure.

But the issue still remains: the ClaimPreview will still end up calling a resolve because  it is mounted before this part of the code finishes.

AFAIK, thats probably the right way to go as if a claim does not resolve in doFetchItemsInCollections it would get resolved  later on when the component is mounted.

It seems to be already checking resolvingUris before resolving, so maybe that flag isn't updated correctly for the case of collections.

not sure what you mean there.

Was this resolved? Not sure.


Suggestion on buffer sizes

Hi Team,
I have a use case where certificate size go more than 4K.
I see we have macros defined in https://github.com/DMTF/libspdm/blob/main/include/library/spdm_lib_config.h
and some other macros like LIBSPDM_MAX_SPDM_MSG_SIZE, LIBSPDM_SCRATCH_BUFFER_SENDER_RECEIVER_CAPACITY, LIBSPDM_SCRATCH_BUFFER_LARGE_SENDER_RECEIVER_CAPACITY
What should be the sizes of each which I need to customize for optimal performance.
Thanks,
Prithvi  A Pai

Currently, it should be LIBSPDM_MAX_CERT_CHAIN_SIZE.
But we dont have "LIBSPDM_MAX_SPDM_MSG_SIZE, LIBSPDM_SCRATCH_BUFFER_SENDER_RECEIVER_CAPACITY, LIBSPDM_SCRATCH_BUFFER_LARGE_SENDER_RECEIVER_CAPACITY" any more. Those need to be set at runtime. Please refer to https://github.com/DMTF/libspdm/blob/main/doc/user_guide.md

@jyao1 Thank you for your suggestion.
We are using libspdm 2.3.2 (https://github.com/DMTF/libspdm/releases/tag/2.3.2) so that doesn't allow us to set sizes at runtime. So is there any suggestion on other buffer sizes so that performance is not compromised

Thanks a lot for suggestion.


Not working with VueJS

Whenever I try to import this module into my VueJS / Nuxt Setup I encounter this error: render function or template not defined in component: anonymous
If I comment the import out the page renders normally.
Do you have any workaround?

It seems to work with Vue, it shouldn't conflict with it..
Take a look at: https://codepen.io/anon/pen/gZGBYX?editors=1111
However this isn't done with an import since that isn't possible in a codepen.
Could you show me an example of your code, so I can see what the problem is?


(GH-1623) Replace all 'nodes' keys with 'project migrate' command

This fixes a bug in the project migrate command that resulted in only
the first group in an array of groups having its nodes key replaced
with targets. The command now replaces nodes keys with targets in
all groups.
This also updates the project migrate command to remove any version
field that does not have a value of 2 from the inventory file.
Fixes #1623

CLA signed by all contributors.


Drop Header for Water Quality Graph and Add Embayment Name to Graph

Updated graph to remove header and add embayment to the title


Destroy room and redirect

Task-489
Description
Redirect to home page when room Owner clicks "Leave Room" button
Room should be destroyed in the backend
What to test for/How to test
Create a room and press the leave room button. You should be able to leave the room.
After that, try joining the same room, an error saying it doesn't exist should show up

@MarcoGoC I checked the error. It only shows up if the Scum poker server isn't running. If it's running, the error doesn't show up.


fix porchсtl push method for windows

we are compiling the porchctl to use it on Windows. the proposed fix is changing the Windows path representation to the Unix-based one.

/ok-to-test

/retest-required

/lgtm

/approve


Credetial Guard available for Non Enterprise OS Sku's?

[Enter feedback here]
Hi! i just startet the "HVCI and Windows Defender Credential Guard hardware readiness tool" on a Windows 10 PRO machine and saw that there is now the OS Sku Pro and Home listed.
`###########################################################################
OS and Hardware requirements for enabling Device Guard and Credential Guard

OS SKUs: Available only on these OS Skus - Enterprise, Server, Education, Enterprise IoT, Pro, and Home
Hardware: Recent hardware that supports virtualization extension with SLAT
To learn more please visit: https://aka.ms/dgwhcr
###########################################################################`
has that changed? ore is it still only avaible on the Enterprise edition. Thanx for the Info!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 41c2cb44-269d-3334-019a-726eb5432f1c
Version Independent ID: 251024cc-b818-18c6-a112-4ac0276cb4b1
Content: Manage Windows Defender Credential Guard (Windows 10) - Microsoft 365 Security
Content Source: windows/security/identity-protection/credential-guard/credential-guard-manage.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: v-tea

Hello @mario-sit ,
I believe info in this article is incorrect and Credential Guard is not supported in Windows 10 Pro and Home.
Also, it was never announced.
I will create a PR to remove this info from the article
Thank you

Hi Marat!
I thought the same. Thanks very much.
Regards Mario
From: MaratMussabekov<EMAIL_ADDRESS>Sent: Donnerstag, 13. August 2020 07:01
To: MicrosoftDocs/windows-itpro-docs<EMAIL_ADDRESS>Cc: Mario Brecher<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windows-itpro-docs] Credetial Guard available for Non Enterprise OS Sku's? (#7900)
Hello @mario-sithttps://github.com/mario-sit ,
I believe info in this articlehttps://docs.microsoft.com/en-us/windows/security/identity-protection/credential-guard/dg-readiness-tool is incorrect and Credential Guard is not supported in Windows 10 Pro and Home.
Also, it was never announced.
I will create a PR to remove this info from the article
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/windows-itpro-docs/issues/7900#issuecomment-673257004, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQK6B5FJJNUPHTF3GAI2X63SANXQ3ANCNFSM4PCFJUMQ.

The DG & DC Readiness tool should get updated then too.
Related: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/5690

msinfo32 shows Credential Guard under active services for virtualization based security, on my Windows 10 Pro 2004 system.
So it works at least on some 10 Pro editions.

The 'DG & DC readiness tool' that beerisgood links to is an ancient version,

The 'DG & DC readiness tool' that beerisgood links to is an ancient version. That should have flashing warning lights that it is old.

I know. See my second link
Microsoft need to fix that


Various UI refactorings

I've put the page title in the header as there is plenty of space there.
I've reworked the journal toggles into one row of CSS-styled toggle buttons. Fix #218
Also some removed some of the txn type filters (now there's just cleared, pending and other)
Lots of other SASS cleanup and refactorings. We have a lot of duplicate and redundant code. I've tried to enforce sensible global styles over special cases on all the single pages.

@yagebu These changes are awesome!

I like that the <h1>'s are in the header - makes the page look sharper and saves a ton of space. Maybe I change the styling a little bit - make the page title in the header bold or in another background-color, so it is more distinguishable, but still saves the space as it does now.
The Journal-toggles look very good! I'll add a cursor: pointer to them, so it is clearer that these are clickable toggles. Also, titles for the toggles (for when you hover) with a explanation what the toggle does.
The SCSS grew heavily towards the beginning of the project, and honestly I did forget about refactoring it.
"General Journal" -> "Journal" is a good decision overall. Maybe renaming the "Journal" subheader on the Account view to "Account Journal" to make it clearer what the distinction is? What do you think?

Again, thanks for the good work!

Also, titles for the toggles (for when you hover) with a explanation what the toggle does.

:+1:

Maybe renaming the "Journal" subheader on the Account view to "Account Journal" to make it clearer what the distinction is? What do you think?

Sounds good.

Will add these changes when you merged.


Bugfix/fix cant build android version

Removed "react-native-awesome-module": "link:./modules/awesome-module" it caused duplication of dependencies defined in   "awesome-module": "link:./modules/awesome-module",
Removed "react-native-blur": "^3.2.2" as it is deprecated dependency, we should use "@react-native-community/blur": "^4.4.0"
Added missing dependency to my-module
Now Android project complies, although its UI is misplaced. I assume these modifications do not cause it as iOS looks fine.

merged


Sass import relative to Sass file?

At the moment, relative imports appear to be relative to the importing Vue file. For example:
<style src="../styles/main.sass" lang="sass"></style>
Inside of the styles directory is a _vars.sass file. Importing this with @import '../styles/vars' works (note the same path as the Vue file initially wanted), however importing with @import 'vars' or @import './vars' does not, as it appears to be relative to the Vue file that initially imports the root Sass file.
Is there any way to make these imports relative to the Sass files importing them? This appears to be how it works in the Webpack starter setup.
Thanks!

It should work if you don't use the src attribute, but directly use @import:

It does, thanks for that @LinusBorg! 👍
New issue, probably doesn't constitute an official new issue yet:
Previously with the Webpack starter kit I think was able to import npm packages using for example @import '~normalize.css', however that isn't working under vueify. All I'm getting is a failed GET in the console from insert-css.js:16. Any ideas?

Would also be interested in a solution to import css from npm packages. There seems to be a simple way to have bower and node folders included as sass include paths as described in this stackoverflow answer . Just don't know if this is applicable somehow to vueify.

@priithansen For what it's worth, this is all a lot easier with Webpack as all the preprocessors' loaders include this functionality built-in. Worth a try if you're still having trouble (let me know if you'd like a working config).

Thanks for the heads up @SamHH. Will look into it when the times comes to switch compilers.

I have the same problem here
<style lang="scss">
@import './assets/sass/modules/core/css/global.scss'
</style>

and inside :
@import "core.css";
@import "widgets.css";

it find core.scss and widgets scss only if i add a leading slash like:
@import "/core.css";
@import "/widgets.css";

It should work without, strange


Zone level allocate block and page hit seg fault when having over 2 scenarios of 5GB workload

https://github.com/umn-cris/MQSim/blob/e6b816e56a3aafcb5a9292868b6c33b44c502e74/src/ssd/Address_Mapping_Unit_Zone_Level.cpp#L884
Seg fault after second scenario start running, when execute
./MQSim -i ssdconfig_zone.xml -w workload/workload_zone_alloc.xml

Translation_wf
Seems like it's not initialized. Could let this go for now since supporting multiple scenario is not required.


One item does not work on UWP which breaks the whole library

Hello, I am trying to use your library on UWP to access SFB via my app. This is a great library from what I can tell (when I run the demo app in non-uwp). However, UWP does not allow me to reference the library:
Microsoft.IdentityModel.Clients.ActiveDirectory.Platform
Furthermore and related, the class UserPasswordCredential does not exist anymore either. From what I read, this is because Microsoft no longer wants to store passwords. While I understand this approach for most scenarios, there is certainly still a case for it. Aside from that, it seems the library will work just fine on UWP. However, as you know, this breaks everything because I cannot get the token, etc... without the password.
In days of research, I found this beauty. It is a hack or workaround to the problem. Basically, instead of using AcquireTokenAsync and passing in a UserPasswordCredential, I am able to use this code and successfully acquire a string which is the token. The issue is, I do not know how to inject this into your library the correct way so everything else downstream still works. In other words, I know that you typically get a bit more than just a string of the token but rather, an AuthenticationResult. While the token is part of that AuthenticationResult, it is not the only part of it. Any ideas how to correct this issue so the library will work on UWP OR inject my workaround into your library?
Thanks!
 ` public static async Task<string> GetAzureAdTokenStringAsync(string ResourceId)
    {
        if (ResourceId.StartsWith("http"))
        {
            ResourceId = Helpers.ReduceUriToProtoAndHost(ResourceId);
        }

        //create the collection of values to send to the POST

        var vals = new List<KeyValuePair<string, string>>
        {
            new KeyValuePair<string, string>("resource", ResourceId),
            new KeyValuePair<string, string>("username", Username),
            new KeyValuePair<string, string>("password", Password),
            new KeyValuePair<string, string>("grant_type", "password"),
            new KeyValuePair<string, string>("client_id", ClientId)
        };

        var url = string.Format(AadInstance, Tenant);

        // ... Use HttpClient.
        using (var client = new HttpClient())
        {
            client.DefaultRequestHeaders.Add("Cache-Control", "no-cache");

            HttpContent content = new FormUrlEncodedContent(vals);

            HttpResponseMessage hrm = await client.PostAsync(url, content);

            // ... Read the string.
            var responseContent = await hrm.Content.ReadAsStringAsync();

            // ... Display the result.
            if (hrm.IsOk() && hrm.IsJson())
            {
                var resultDictionary = JsonConvert.DeserializeObject<Dictionary<string, string>>(responseContent);

                return resultDictionary["access_token"];

            }
        }
        return string.Empty;
    }`

Thanks for using this. Yes  this does work with any platform including UWP and Xamarin.
Basically you use ADAL v3 to acquire token by using user login and adal takes care the rest.
However I will write sample and put it to this repo as it could be easier. Please give me a day to prepare.

While I do appreciate you writing a sample app that targets UWP and others may benefit from it, my issue may just be my fault if you say it already works with UWP. I just know that UWP does not allow me to reference Microsoft.IdentityModel.Clients.ActiveDirectory.Platform which is referenced in your test app. So, to re-write a test app in UWP, I could not figure out how to get past that.
I do appreciate you writing a new sample and can certainly wait a day. In the meantime, I will keep playing around to see if I can figure it out too.
Thanks again! Look forward to your sample.

not perfect sample but i just uploaded UWP sample. Please let me know how it helps you.


Pick 1 of - do nothing

At the moment, picking "do nothing" at random fails because of https://github.com/Cardshifter/Cardshifter/blob/master/cardshifter-core/src/main/resources/com/cardshifter/core/modloader/EffectDelegate.groovy#L74 . It should probably be solved by adding a doNothing() no-operation method.

It is now possible to use doNothing() as an effect, which will fix this.


Critical Vulnerability CVE-2022-27404 in buster

The docker image for buildpack-deps:buster is flagging a critical CVE, CVE-2022-27404.
I think a rebuild should fix the issue.

https://security-tracker.debian.org/tracker/CVE-2022-27404
The fix has only become available in Buster this weekend with the Debian 10.13 release. It (and all dependent images) will be rebuilt once the base image update is merged (https://github.com/docker-library/official-images/pull/13132).

Background:

Tags in the [official-images] library file[s] are only built through an update to that library file or as a result of its base image being updated (ie, an image FROM debian:buster would be rebuilt when debian:buster is built).
-https://github.com/docker-library/official-images/tree/2f086314307c04e1de77f0a515f20671e60d40bb#library-definition-files

Official Images FAQ:

Though not every CVE is removed from the images, we take CVEs seriously and try to ensure that images contain the most up-to-date packages available within a reasonable time frame
- https://github.com/docker-library/faq/tree/0ad5fd60288109c875a54a37f6581b2deaa836db#why-does-my-security-scanner-show-that-an-image-has-cves

Since our build system makes heavy use of Docker build cache, just rebuilding the all of the Dockerfiles won't cause any change. So we rely on periodic base image updates.

We strive to publish updated images at least monthly for Debian. We also rebuild earlier if there is a critical security need. Many Official Images are maintained by the community or their respective upstream projects, like Ubuntu, Alpine, and Oracle Linux, and are subject to their own maintenance schedule.
- from the same FAQ link


Rails 6.1 changed ::ActiveJob::Logging::LogSubscriber to ::ActiveJob:LobSubscriber

Fixed in https://github.com/rocketjob/rails_semantic_logger/pull/110


Slash Commands, Interactions and Message Components

Adds new Discord API features like Slash Commands, Interactions and Message Components. Also contains functions for the automatic discovery and registration of Attribute based Application Command handlers. Has Custom ID based interaction handling and methods for creating UI Components. Slash Commands module is designed as an optional, separate package.

Removed the conflicting "Message Components" related parts entirely from this branch, as well as the conflicting Discord.API deserialization classes. But moved the Model/Entity conversion functions to a helper class to keep the library consistent.

I see a lot of classes with "Rest" suffix that aren't actually Rest Entities. I think those should be moved to the shared Core library.

I see a lot of classes with "Rest" prefix that aren't actually Rest Entities. I think those should be moved to the shared Core library.

Could you provide some examples of the classes

I see a lot of classes with "Rest" prefix that aren't actually Rest Entities. I think those should be moved to the shared Core library.

Could you provide some examples of the classes

RestApplicationCommandChoice
RestApplicationCommandOption
SocketApplicationCommandOption
SocketApplicationCommandChoice
SocketSlashCommandDataOption
This one is a bit odd, it isnt a Socket Entity but hijacks a guild id
SocketMessageComponentData

I also unified the RestGuildCommand and RestGlobalCommand since their functions are the same and the only distinction between them is their Guild value. I think it is simple enough to add a nullable reference and a IsGlobal property. And i think the use of "this" is pretty excessive isn't it?

I also unified the RestGuildCommand and RestGlobalCommand since their functions are the same and the only distinction between them is their Guild value. I think it is simple enough to add a nullable reference and a IsGlobal property.

The difference between them is there api routes to delete and modify them etc, thats why i made them different things

I also unified the RestGuildCommand and RestGlobalCommand since their functions are the same and the only distinction between them is their Guild value. I think it is simple enough to add a nullable reference and a IsGlobal property.

The difference between them is there api routes to delete and modify them etc, thats why i made them different things

I see you are also using a helper class to interface with the API functions. Again even the helper functions are identical except, once has a guildId param and on doesn't. Creating a function to use in both of the cases can be accomplished like so:
public static async Task DeleteApplicationCommand (BaseDiscordClient discord, ulong commandId, IGuild guild,
            RequestOptions options)
        {
            var appInfo = await ClientHelper.GetApplicationInfoAsync(discord, options).ConfigureAwait(false);

            if (guild != null)
                await discord.ApiClient.DeleteGuildApplicationCommand(appInfo.Id, guild.Id, commandId, options).ConfigureAwait(false);
            else
                await discord.ApiClient.DeleteGlobalApplicationCommand(appInfo.Id, commandId, options).ConfigureAwait(false);
        }

The endpoints are different yes but the parameters are identical. Or you can keep the abstract base class but add the delete/modify... functions as abstract functions so typecasting isn't needed to use these functions which are almost the same.

Could you please exclude any changes you made to the main lib and just work on implementing your slash command service into the current build of the interaction branch. If you would like methods changed then open separate pr's for them

Could you please exclude any changes you made to the main lib and just work on implementing your slash command service into the current build of the interaction branch. If you would like methods changed then open separate pr's for them

Then let me just open another PR just for the Slash Command Service instead of reverting the conflict resolutions. Those files are already standalone and shouldn't cause any problems

Could you please exclude any changes you made to the main lib and just work on implementing your slash command service into the current build of the interaction branch. If you would like methods changed then open separate pr's for them

Then let me just open another PR just for the Slash Command Service instead of reverting the conflict resolutions. Those files are already standalone and shouldn't cause any problems

Please do that thanks. Can I close this one in the mean time?


Errors when npm start

I've cloned the repo and installed it as per the instructions. When I ran "npm start" there were errors in the terminal related to my version of Node and npm. I updated both and repeated the process, but the errors persisted.
Please see the debug file with the errors log attached.

I don't see any debug file attached?
Here's my output:
❯ node -v
v5.6.0

react-webpack-boilerplate master
❯ npm -v
3.7.2

react-webpack-boilerplate master
❯ npm start

><EMAIL_ADDRESS>start react-webpack-boilerplate
> node index

server running at localhost:3001, go refresh and see magic
webpack dev server listening on localhost:3000
webpack: bundle is now VALID.

Everything is working fine.

If you're running on Windows, try changing line 10 of package.json from
"dist": "NODE_ENV=production webpack -p --progress",
to
"dist": "SET NODE_ENV=production webpack -p --progress",
I ran a similar error when trying to install on Windows 7.

All should be good after https://github.com/srn/react-webpack-boilerplate/commit/807fea8b53b16a2cde62d676d0386e18be43751a


fix(zk_toolbox): docs shared bridge url link

What ❔

Fixed docs link in zk_toolbox to shared bridge

Why ❔

Docs link in zk_toolbox to shared bridge was broken

Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.

CC @Deniallugo 🙏


Total viewable rows after child row expansion

I maybe missing something but I do not see how to get the total number of rows viewed by the user after clicking child row expansion button.
I would like to set the total number of rows including child rows and each time a child row is expanded have the overage updated into the pagination. If you look at any of the examples you will see once you expand the child rows the total rows slot does not update.
Any help is appreciated.

The pagination component has a default number of items on each page.
If child rows are also counted as an 'item' on a page and if you expand the a parent row, the last rows of the current page will disappear. And you can't set a custom 'items per page' for only one page with the paginator.
So I think that your feature is impossible to implement.

Thanks for the sanity check and the cycles for thinking about it. Great component, thanks for sharing.


JS Uncaught TypeError

Built from github.
I see the following error in the browser console;
Uncaught TypeError: (0 , u.default) is not a function (typeof.js:11)
and there is no diagram displayed.

What browser are you running?

Hi,
I am running Google Chrome 47.0.2526.106 (64 bit) on CentOS 6.5
Let me know if you want any more testing done.
Thanks,
On 18 December 2015 at 18:49, Jeff Avallone<EMAIL_ADDRESS>wrote:

What browser are you running?
—
Reply to this email directly or view it on GitHub
https://github.com/javallone/regexper-static/issues/21#issuecomment-165868233
.

Same result on Firefox - Mozilla/5.0 (X11; Linux x86_64; rv:38.0)
Gecko/20100101 Firefox/38.0
On 18 December 2015 at 18:49, Jeff Avallone<EMAIL_ADDRESS>wrote:

What browser are you running?
—
Reply to this email directly or view it on GitHub
https://github.com/javallone/regexper-static/issues/21#issuecomment-165868233
.

Thank you, I am seeing the same problem. It looks like it only happens when running the site locally (regexper.com isn't exhibiting the error). It may be due to some bad interaction between NPM deps that have seen updates since the last deployment. I'll be pushing a change to update versions shortly.


Change IPyKernel required message into non error message

Currently its a mondal error message.
Keep it as a modal, but not error, instead reguarl information message

Error message shows up in the jupyter extension's status.


This is not AES

I'm having problems with this part:
mcrypt_encrypt(
    MCRYPT_RIJNDAEL_256,
    $this->secretKey,
    $data,
    MCRYPT_MODE_ECB,
    mcrypt_create_iv(
        mcrypt_get_iv_size(MCRYPT_RIJNDAEL_256, MCRYPT_MODE_ECB),
        MCRYPT_RAND
    )
)

MCRYPT_RIJNDAEL_256 is not AES (http://stackoverflow.com/questions/4537099/problem-with-aes-256-between-java-and-php/4539318#4539318).

The 256 in that constant refers to the blocksize, not the keysize. Use MCRYPT_RIJNDAEL_128 to get the same algorithm as AES. The keysize is set just by the number of bytes in the key argument you supply. So supply 32 bytes and you get AES with a 256-bit key.

MCRYPT_MODE_ECB doesn't use an IV (http://stackoverflow.com/questions/1789709/is-it-possible-to-use-aes-with-an-iv-in-ecb-mode). So why are you setting one?

This is not AES and the ECB is not considered secure. You should use CBC mode and MCRYPT_RIJNDAEL_128 using 256-bit key, as suggested by @westinpigott.
Moreover, you cannot have only encryption, you need also authentication for security reason (for instance, using HMAC SHA-256). See this slides for more information: http://www.zimuel.it/slides/midwestphp2016/encryption
You can see how I implemented it in this project: https://github.com/ezimuel/phpcrypto/blob/master/src/Symmetric.php
Finally, the MCrypt extension is going to be deprecated from PHP 7.1, I suggest to use OpenSSL instead.


Joint accelerations using forward dynamics seem large

I'm trying to get the forward dynamics for walking, and I have been using constraintDynamics. However, the joint accelerations seem rather large for the swing legs. When I compare the joint accelerations to other solvers, they don't seem to match well.
I've simplified the problem to calling aba and having just a pendulum with length=2, mass=1, inertia=1, g=9.81, center of mass located at 1 and swinging about its edge. When I initialize the pendulum at pi/2 with no velocity, the acceleration should be around -4.905 but I am getting around -7.7.
I'm not sure what the cause of the higher joint accelerations are. Any help would be great.
I'm running the pinocchio3-preview and I've attached a tar file with my python code and urdf if that helps.
simple_pendulum.tar.gz

Dear @Kongx231,
First of all, thanks for the clean code.
It appears you have forgotten to normalize the configuration vector as follows:
import sys, os
import pinocchio as pin
from os.path import dirname, join, abspath
import numpy as np

pinocchio_model_dir = join(dirname(dirname(str(abspath(__file__)))), "simple_pendulum")

print(pinocchio_model_dir)
mesh_dir = pinocchio_model_dir

urdf_filename = "/single_pendulum.urdf"
urdf_model_path = pinocchio_model_dir + urdf_filename

model, collision_model, visual_model = pin.buildModelsFromUrdf(urdf_model_path,mesh_dir)
data = model.createData()

q = np.array([1, np.pi/2])
q = pin.normalize(q)
v = np.array([0])
tau = np.array([0])
a = pin.aba(model,data,q,v,tau)
print(a)

Dear @jcarpent ,
There is no complex joints such as floating-base joint or continuous joint in the pendulum system, why we still need to normalize the configuration vector before calling forward dynamics algorithms?
Thanks.

Because it is using continuous joints formulation, parametrized by q = [cos(theta),sin(theta)].

so sorry for disturbing.

For others bumping into this, it should be
q = pin.normalize(model, q).


Cylinders don't work w/ physics in Safari.

I have no idea. 😒

Or Edge. Lol. Quaternion rotation gone haywire.

Fixed at v1.16.3 (possibly earlier?)


Add song BPM check in NotesLoaderSSC

Make sure that a BPMS was in the header after processing steps to prevent the calculated defaulting to 60 when DisplayBpm is calculated.
This is my first commit to a open source project any comments will be appreciated , Hope I can become a regular.
fixes #615

Looks good to me. I'm not sure if this is enough to close the issue. Wouldn't we need to correctly update the bpm in the song select screen when changing the chart?

I have a theory that the second part (not visually changing as the user change charts) is lua related due to the fact that I did not change the flag that specifies that the chart/steps contains its own timing and that all the chart specific bpm values are calculated and stored, the functions to retrieve the BPM is also in the LunaSteps class. I have not yet looked in to how Lua handles the data.

I believe the BPM display on the screen is a particular class that should already properly react to this. I will test soon.

I am not sure how relevant this might be but its the reason I did not originally try to fix the bpm issue on my first commit.
The charts in question will also be picked up as broken in StepMania, not saying that is a reason we should not fix it but the tags were not used as in the ssc spec?
BPM should technically only be used in the header or ho I have this wrong. The BPM should also be related to the music for timing data and in my opinion cannot change from levels unless other music is provided. I can see how one can try and use the BPM to fake double time etc but that kind of goes against the ssc definition. (in the files in question there were multiple declarations of the same bpm sets, but this only had the effect of redundant calculations as the value changed were betwean 190.04 and 189.991 and had 187 iterations in the sample file I used !PiXeLaTeD! ... I feel this adds redundant loading times as the process of calculating the final BPM had to iterate over all the values 187 times with no significant change and do this for each Difficulty.
If I can get a sample from someone that have variable BPM per Difficulty then I will look in to the LUA.

I believe the BPM display on the screen is a particular class that should already properly react to this. I will test soon.

If you don't see anything obvious, I will like to have a go at some LUA

This https://github.com/etternagame/etterna/blob/425f10cfd58473754bba9021fc6f441e1accaefc/src/Etterna/Actor/Menus/BPMDisplay.cpp

When I got to the problem I debugged through this class to find the root cause. I see the set bpm from steps but cant remember off te top of my head of it was called at all.
Will investigate when I am home.

I looked in to the issue of only get BPM from song being called and my memory was correct. Even tho the flags are set that specifies that the step /  chart contains its own BPM the only call for BPM on displaying the values in the song manager is to the get BPM from song.
This is however my findings by just using breakpoints and will have to investigate the LUA code to be sure of my temporary conclusion.

I feel quite lost with the LUA part I am mentioning, expecting to find some sort of file with a lua extension, I do however feel to state that I am quite unfamiliar with the combination of LUA scripts and c++
I read the docks on LUA and see that everything is an Actor and followed down the hierarchy to find that the BPMDisplay is in deed also an actor (with some text as a intermediary node) so excuse my ignorance of LUA as a term I was throwing around.
I also saw that the default visual studio folder view is really bad to see the architecture and after changing that, I might be able to reason a bit better about the code base. (bare with me as I set up the environment and settle in)

I investigated a bit further but only realized (with the better view of the architecture) that I need to do more research on how the drawing of the BPM is instantiated.
My thought are that the issue might be completely a front-end issue as I am quite sure that the correct information is calculated.
Another interesting aspect I saw was that the tag being set in the ssc parser of "contains own timing data" is completely localized to the ssc parser. When I have more time I will look in to the composition phase of the BPM per song and how its changed as I suspect that the issue might be with the theme, that is if my literal understanding of

Lua is used in Etterna for Themes and Noteskins.

is correct.
The original pr will then just allow for themes (going with my possible ignorant view of the them-ing process, that I have no clue on how much freedom in choosing what values are presented exist) to display more accurate BPM values if a less valid ssc file is presented

The SSC notesloader is meant to support BPMs which are specific to a chart, and that is why the header BPM may not be totally necessary.
Your change compiles fine and as far as I can tell seems to fix the problems.
BPMDisplay holds a method which allows setting the bpm based on the given Steps, not just the Song. This is also exposed to Lua. After review, Til Death does in fact not acknowledge this.
Relevant code: https://github.com/etternagame/etterna/blob/cce9555823b0e2e5fdcaa92b632f42d27a41db94/Themes/Til Death/BGAnimations/ScreenSelectMusic decorations/wifeTwirl.lua#L383-L397
With access to a Steps object like we have from that file (the file holds a global called steps) we could just do self:SetFromSteps(steps) and call it a day within a Command that runs whenever the steps change. Well that doesn't work. It seems that these changes don't fix that issue.
I am too lazy to investigate why this is, but it would appear that every Steps defaults to the BPM of the first Steps. Either that, or no BPM is saved in the Steps itself.
In conclusion, your changes are the right first step to fixing this.

What's the status of this?
@EDuToit are you fine with us merging this as-is, or would you rather we wait?

I am happy with it as-is,
It did solve the problem and the songs with variable bpm in the pack mentioned by the op, shows as variable in song select with this fix.