SCons: Disable /EHsc for MSVC, speeds up build significantly

As seen in #80513, /EHsc seems responsible for extremely long build times for complex files such as gdscript_vm.cpp and variant_call.cpp, when combined with optimization flags.
On my Windows setup, a clean rebuild of the engine with scons p=windows (thus defaulting to optimize=speed-trace, i.e. /O2 on MSVC) went from 35 min down to 16 min with this patch. Incremental rebuilds that would lead to recompiling either gdscript_vm.cpp or variant_call.cpp will benefit even more.
We were using /EHsc to solve warnings in thirdparty code, so instead we silence that warning specifically.
Fixes #80513.

I could use help to properly assess the impact of removing /EHsc and ignoring the C4530 warning. I'm not super familiar with exception handling and stack unwinding. Relevant docs: https://learn.microsoft.com/en-us/cpp/build/reference/eh-exception-handling-model?view=msvc-170
Patching thirdparty libraries so they don't raise this warning is also an option. In theory, we don't want any exception handling in Godot.

Interesting error on tests after this change:
Error: .\tests/core/io/test_file_access.h(42): error C2338: static_assert failed: 'Exceptions are disabled! Use DOCTEST_CONFIG_NO_EXCEPTIONS_BUT_WITH_ALL_ASSERTS if you want to compile with exceptions disabled.'

Interesting error on tests after this change:
Error: .\tests/core/io/test_file_access.h(42): error C2338: static_assert failed: 'Exceptions are disabled! Use DOCTEST_CONFIG_NO_EXCEPTIONS_BUT_WITH_ALL_ASSERTS if you want to compile with exceptions disabled.'

So Doctest needs exceptions for the REQUIRE (and I think FAIL) macros, i.e. macros which mark the test as failed and abort. It has an option to disable the use of exceptions but that basically downgrades those macros to CHECK level, which mark the test as failed but don't abort.
We could look into whether we can get by with only CHECK level macros, but if so we can't test unrecoverable conditions. I haven't assessed what our current tests need.
So for now I just re-define /EHsc for the tests/SCsub environment.

Looked around and seems you can disable EH for doctest:
2 config possible:
DOCTEST_CONFIG_NO_EXCEPTIONS DOCTEST_CONFIG_NO_EXCEPTIONS_BUT_WITH_ALL_ASSERTS

Indeed, but as I pointed out above, I believe this will break the tests by downgrade REQUIRR/FAIL asserts to the non terminating CHECKED level, so some tests might crash if they rely instead of aborting.
Could still be worth doing but this will likely require changing a lot of tests.

There's also the quasi-supported (and undocumented) _HAS_EXCEPTIONS=0 definition to consider, which I typically see defined in conjunction with omitting /EH[sc], and supposedly allows the MSVC STL implementation to make different choices in some cases. I'll admit I don't fully understand the pros/cons to defining this versus not defining it, but I would imagine it's safe to define it as long as you don't plan to actually use any exception classes or exception-handling anywhere. Considering how little the STL is used in Godot anyway, I would imagine it's even less of a risk. Unreal (who also uses the STL very sparingly) seems to get away with defining this, just to give one example.
Has there been any consideration towards disabling exception-handling for GCC/Clang as well, through -fno-exception? Disabling exception-handling seems fairly ubiquitous for gamedev stuff and can have significant impacts on binary size, and presumably instruction cache performance, since it can omit all the generated code for the stack-unwinding, which is just dead weight if you never use exceptions anyway. This PR nets a ~15% decrease in binary size for target=editor. I would be surprised if GCC/Clang didn't net at least a couple of percentage points as well.

I made #80612 as an alternative to fully disable exception handling. Reviews and tests welcome :)

Superseded by #80612.


Base skeleton

[] created template
[]Readme
[]setup for python project
[]test setup
[]research dir created

done


Line endings should be LS

For the hashbang first line in cli.js to work, the file should be saved as unix textfile (lineending=LF ), you have a windows lineending (CRLF),  which gives a env: node\r: No such file or directory error on linux.

@jorisroling Are you checking it out on Windows or in CRLF mode? I don't see \r characters in cli.js in my checkout. https://help.github.com/articles/dealing-with-line-endings/

I just installed it with npm on my mac.
Download   Email (https://itunes.apple.com/app/apple-store/id922793622?pt=814382&mt=8&ct=download_email)

On Jul 8, 2016 at 4:57 AM,  <Anders D. Johnson (mailto:notifications@github.com)>  wrote:
@jorisroling (https://github.com/jorisroling)  Are you checking it out on Windows or in CRLF mode? I don't see  \r  characters in  cli.js  in my checkout.  https://help.github.com/articles/dealing-with-line-endings/
—
You are receiving this because you were mentioned.
Reply to this email directly,   view it on GitHub (https://github.com/adjohnson916/eyes-cli/issues/1#issuecomment-231263873), or   mute the thread (https://github.com/notifications/unsubscribe/AAmzUXucxo1rIE3_Y0xYLZ72nWaTfC_xks5qTbyagaJpZM4JHH_S).

@jorisroling Odd, I got the same thing from an npm install. Fixed since version 0.0.3 pushed to npm.

That is probably the issue, I just checked, I have version 0.0.2 here. Don't know why...

Doing npm update eyes-cli -g seems to solve it... thnx


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/25210

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/43317

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/56704

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/57609

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/57610


feat(react-query): add @reactQueryKey directive to override generated react-query key

Description
Adds a @reactQueryKey directive on QUERY which allows customizing the generated key.
Related dotansimha/graphql-code-generator-community#209
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Adds a test to make sure the generated key is correct.
Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@charlypoly I understand your reasoning for not wanting to mix configuration, but as it stands today, the mismatch of query keys between queries and their mutations is a big reason not to use the auto-generated react-query hooks.
Invalidation after mutation becomes much more difficult and error-prone, and as far as I can tell, there is no workaround for this problem.
Mixing configuration would be a compromise that is well-worth it, in my opinion.
Or do you have another solution in mind for this problem?

@spsaucier, actually, we will encourage people soon to not use generated hook-based plugins but instead rely on our gql-tag-operations-preset (soon to be renamed) that provides better integration with most frameworks (React Query included); you will an RQ example here: https://github.com/dotansimha/graphql-code-generator/tree/examples-front-end/examples/front-end/react/tanstack-react-query

Thanks, then I look forward to seeing what that entails practically as soon as it's ready. As it stands, I'm not sure what's being auto-generated in that example.

Thanks, then I look forward to seeing what that entails practically as soon as it's ready. As it stands, I'm not sure what's being auto-generated in that example.

Hi @spsaucier,
In the aforementioned example, the content of src/gql folder is generated.
Is provided a typed graphql() function that needs to be used to define GraphQL operations and fragments as follows:
import React from 'react';
import request from 'graphql-request';
import './App.css';
import Film from './Film';
import { gql } from './gql/gql';
import { useQuery } from '@tanstack/react-query';

const allFilmsWithVariablesQueryDocument = gql(/* GraphQL */ `
  query allFilmsWithVariablesQuery($first: Int!) {
    allFilms(first: $first) {
      edges {
        node {
          ...FilmItem
        }
      }
    }
  }
`);

function App() {
  // here, `useQuery` returns a typed `data` object, thanks to `graphql-request` support for typed graphql document (here: `allFilmsWithVariablesQueryDocument`)
  const { data } = useQuery(['films'], async () =>
    request('https://swapi-graphql.netlify.app/.netlify/functions/index', allFilmsWithVariablesQueryDocument, {
      first: 10,
    })
  );

  return (

      {data &&
{data.allFilms?.edges?.map((e, i) => e?.node && <Film film={e?.node} key={`film-${i}`} />)}
}

  );
}

Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.

Community plugins:

@graphql-codegen/typescript-react-apollo
@graphql-codegen/typescript-graphql-request
@graphql-codegen/typescript-apollo-angular
@graphql-codegen/typescript-apollo-client-helpers
@graphql-codegen/typescript-react-query
@graphql-codegen/typescript-urql
@graphql-codegen/named-operations-object
@graphql-codegen/urql-introspection
@graphql-codegen/flow-resolvers
@graphql-codegen/typescript-vue-apollo
@graphql-codegen/typescript-rtk-query
@graphql-codegen/flow-operations
@graphql-codegen/typescript-msw
@graphql-codegen/typescript-mongodb
@graphql-codegen/typescript-type-graphql
@graphql-codegen/jsdoc
@graphql-codegen/typescript-vue-urql
@graphql-codegen/kotlin
@graphql-codegen/typescript-vue-apollo-smart-ops
@graphql-codegen/java
@graphql-codegen/c-sharp-operations
@graphql-codegen/hasura-allow-list
@graphql-codegen/typescript-stencil-apollo
@graphql-codegen/relay-operation-optimizer
@graphql-codegen/typescript-oclif
@graphql-codegen/java-resolvers
@graphql-codegen/java-apollo-android
@graphql-codegen/flutter-freezed

Please move your PR by following these steps:
From your current PR branch:

git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
git fetch codegen-community
git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!

@dotansimha Can we merge this to make the existing version more flexible until the updates that @charlypoly mentioned are ready?

I echo @spsaucier's sentiment -- it would be cool to have this baked into the library as a temporary solution, currently working around it by fetching with manually-created hooks/factories and composing the generated query keys.
I would love if we could leverage the existing React Query custom UseQueryOptions.queryKey/UseInfiniteQueryOptions.queryKey parameter (if specified, overriding the generated key), but I understand that might be out of scope.

Hey! this plugins has moved to our community repo https://github.com/dotansimha/graphql-code-generator-community/tree/main/packages/plugins/typescript/react-query
Please move your PR by following these steps:
From your current PR branch:

git remote add codegen-community git@github.com:dotansimha/graphql-code-generator-community.git
git fetch codegen-community
git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!


Revert "Revert "Go 1.7 -> 1.8""

Reverts Clever/oplog-dump#47
#47 was reverted because we initially thought it was responsible for failed jobs, but #48 shows CPU allocation was not the cause. We can reduce CPU allocation again.

I reverted this as part of #48 - https://github.com/Clever/oplog-dump/pull/48/commits/d280ff7b3792e8d508345834a1ca56f1c5278b39


Sample Files for Countess™ 3 and 3 FL cell counters

Your code provided valuable insights for cell counter analysis. It would be better if you could provide the test files/sample files that you have used to test the code.
I also noticed that the cell counter produces CSV files and not JSON. I'm interested to know how you obtained JSON exports from the cell counter software.

Thank you pooja-b05 for your feedback! I appreciate your interest.
Regarding your request, I have uploaded two sample files (for fluorescent or only brightness count) that I used to test the code. You can find it in the repository.
As for the JSON exports, the cell counter software automatically generates JSON files as part of the save operation. If you look into the save directory, you should see the JSON files alongside the CSV files.
Please let me know if you need any further assistance.


feat: add completedTransactions cache

For an example of how this would be used, see https://github.com/near/rainbow-bridge-frontend/pull/48
Sometimes a transaction requires confirmation in NEAR Wallet.

Person takes action in App
App calls Function in Contract on behalf of Person
Function requires confirmation from Person. This could happen if:

Function has an attached deposit
Person signed into App using a contract other than Contract (walletConnection.requestSignIn(contractName) was given a contractName other than the name of Contract)
Person signed into App using Contract, which grantend a FunctionCall access key to App, but this access key ran out of allowance

near-api-js redirects to NEAR Wallet
Person clicks Approve or Deny
NEAR Wallet redirects back to App
App needs to figure out if the call to Function succeeded or failed

near-api-js provides two main ways for App to call Function:

Account.functionCall
A changeMethod on a Contract – under the hood, this calls Account.functionCall

Both of these previously accepted positional arguments for gas and deposit. Instead, now they accept an options object, with gas and deposit keys. In addition, you can provide a meta key, with its value a free-form object. If meta is provided, this transaction will be saved to a cache, along with your meta data. Whether or not the transaction results in a redirect to NEAR Wallet, once complete you can check the outcome in walletConnection.completedTransactions.
For now, completedTransactions only provides one way to look up a specific completed transaction: the remove method. Your app will only want to process a completed transaction once, so this method automatically removes a found transaction from the underlying cache.
Where is the cache? If in a browser, near-api-js will use localStorage. If used from Node, near-api-js imports the node-localstorage module, which writes the data to a file. By default, this file will live in ~/.near-api-js, but you can pick a different folder by setting the NEAR_CACHE_DIR environment variable.

@vgrichina yes

We need this one


is valuesFile in a helm release spec also working with a git source?

I am trying to use valuesFile in a helm release definition using other values file for staging env but this doesn't seem to work with a git source? Where is he expecting the file? Do I have to give a path relative to the root of the git source or relative to the chart path wich I specify? Tried all but nothing worked...

The valuesFile does work with a GitRepository source, and the path is expected to be relative to the root of the source. Your source-controller needs to be >=0.8.0, due to a bug, see: https://github.com/fluxcd/source-controller/blob/main/CHANGELOG.md#080

Thank you, got it working, the problem on my side was that he really wanted to have a values.yml also. Thought it would work only by specifiying my special "valuesFile". Closing the issue.


Using built-in Hive

Hello!
I'm pretty new to Spark-Notebook, I need to perform some very simple interactions with Hive Tables (Trying to make SparkSQL examples to work).
I'm using spark-notebook's sparkSession for this:
val spark = sparkSession
import spark.sql
import spark.implicits._
sql("create table tests(key INT, value STRING)") // done OK
sql("LOAD DATA LOCAL INPATH 'kv1.txt' INTO TABLE tests")

And the error I encounter is:
java.lang.UnsupportedOperationException: loadTable is not implemented
  at org.apache.spark.sql.catalyst.catalog.InMemoryCatalog.loadTable(InMemoryCatalog.scala:316)
  at org.apache.spark.sql.catalyst.catalog.SessionCatalog.loadTable(SessionCatalog.scala:319)
  at org.apache.spark.sql.execution.command.LoadDataCommand.run(tables.scala:302)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:58)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:56)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.doExecute(commands.scala:74)
  at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:114)
  at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:114)
  at org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:135)
  at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
  at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:132)
  at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:113)
  at org.apache.spark.sql.execution.QueryExecution.toRdd$lzycompute(QueryExecution.scala:87)
  at org.apache.spark.sql.execution.QueryExecution.toRdd(QueryExecution.scala:87)
  at org.apache.spark.sql.Dataset.<init>(Dataset.scala:185)
  at org.apache.spark.sql.Dataset$.ofRows(Dataset.scala:64)
  at org.apache.spark.sql.SparkSession.sql(SparkSession.scala:592)

Or trying to INSERT stuff manually:
sql("insert into table tests values (1, 'whoa')")

The error is:
org.apache.spark.sql.AnalysisException:
Hive support is required to insert into the following tables:
`default`.`tests`
               ;;
'InsertIntoTable 'SimpleCatalogRelation default, CatalogTable(
	Table: `default`.`tests`
	Created: Tue Apr 18 16:21:14 EEST 2017
	Last Access: Thu Jan 01 02:59:59 EET 1970
	Type: MANAGED
	Schema: [StructField(key,IntegerType,true), StructField(value,StringType,true)]
	Provider: hive
	Storage(Location: file:/home/mika/Desktop/spark-notebook-0.7.0-scala-2.11.8-spark-2.1.0-hadoop-2.6.0-cdh5.4.2-with-hive/spark-warehouse/tests, InputFormat: org.apache.hadoop.mapred.TextInputFormat, OutputFormat: org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat)), OverwriteOptions(false,Map()), false
+- LocalRelation [col1#6, col2#7]

  at org.apache.spark.sql.catalyst.analysis.CheckAnalysis$class.failAnalysis(CheckAnalysis.scala:40)
  at org.apache.spark.sql.catalyst.analysis.Analyzer.failAnalysis(Analyzer.scala:57)
  at org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$checkAnalysis$1.apply(CheckAnalysis.scala:383)
  at org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$checkAnalysis$1.apply(CheckAnalysis.scala:67)
  at org.apache.spark.sql.catalyst.trees.TreeNode.foreachUp(TreeNode.scala:128)
  at org.apache.spark.sql.catalyst.analysis.CheckAnalysis$class.checkAnalysis(CheckAnalysis.scala:67)
  at org.apache.spark.sql.catalyst.analysis.Analyzer.checkAnalysis(Analyzer.scala:57)
  at org.apache.spark.sql.execution.QueryExecution.assertAnalyzed(QueryExecution.scala:48)
  at org.apache.spark.sql.Dataset$.ofRows(Dataset.scala:63)
  at org.apache.spark.sql.SparkSession.sql(SparkSession.scala:592)

I've also tried to do it in the Spark's "official" way:
val warehouseLocation = "spark-warehouse"
val Hive = SparkSession
  .builder()
  .appName("Spark Hive Example")
  .config("spark.sql.warehouse.dir", warehouseLocation)
  .enableHiveSupport()
  .getOrCreate()

Still same errors.
Right now I'm trying to use spark-notebook-0.7.0-scala-2.11.8-spark-2.1.0-hadoop-2.6.0-cdh5.4.2-with-hive under Ubuntu 16.04 VM.
I launch spark-notebook with:
cd %notebook-dir%
./bin/spark-notebook
(there is something strange with paths when launching from /bin directly,
it can't find notebook folder then)
I've tried chmod-ing and chown-ing folders for 777 and my user, launching notebook with sudo, yet this gave me no results.
I've downloaded a dozen of different spark-notebook versions (master, 0.7 ones, and more), but i encounter same problem every time.
Maybe, I just do something wrong.
Thanks in advance.

this might be a known issue I think. try setting spark.sql.catalogImplementation=hive spark-conf.
e.g. you can start SN server with this added to force it:
-Dmanager.notebooks.override.sparkConf.spark.sql.catalogImplementation=hive \
 "-Dmanager.notebooks.override.sparkConf.spark.sql.warehouse.dir=hdfs://namenode:8020/user/hive/warehouse"

see here: https://github.com/spark-notebook/spark-notebook/pull/731#issuecomment-257386380


Add API for simple system ordering

Objective

Add API for easy system ordering.
Fixes #4220

Solution

Create new traits IntoLinkedSystemSet and IntoSequentialSystemSet.
Using these trait methods will produce a SystemSet that can be added to App through App::add_system_set.

IntoLinkedSystemSet

IntoLinkedSystemSet is a trait that provides a method link().
IntoLinkedSystemSet is implemented on tuples of systems containing 2 to 15 elements.

Syntax:
(system_a, system_b, system_c, system_d).link()

This is equal to:
SystemSet::new()
    .with_system(system_a)
    .with_system(system_b.after(system_a))
    .with_system(system_c.after(system_b))
    .with_system(system_d.after(system_c));

IntoSequentialSystemSet

IntoSequentialSystemSet is trait that provides a method then(next_system)
IntoSequentialSystemSet is implemented on a system, and accepts a system.

Syntax:
system_a.then(system_b)

This is equal to:
SystemSet::new()
    .with_system(system_a)
    .with_system(system_b.after(system_a));

Or
(system_a, system_b).link()

Known Limitations

IntoSequentialSystemSet is not implemented for SystemSet. This means you can't do system_a.then(system_b).then(system_c).
IntoLinkedSystemSet is not implemented for tuples with more than 15 elements.

Changelog
Added

Allow sequential ordering of two systems by using IntoSequentialSystemSet::then and doing system_a.then(system_b).
Allow sequential ordering of multiple systems (up to 15) by using IntoLinkedSystemSet::link on tuples of systems.

P.S.: writing and debugging proc macros is not a very fun experience lol

Nice work! I'll do a full review soon. Did you experiment with the .then() syntax as well?

I’m not up-to-date on https://github.com/bevyengine/rfcs/pull/45 but isn't the terminology chain instead of link?

Yes, but to do that we'll need to first rename the existing system chaining :)

This seems awfully similar to earlier iterations of #2381 before it was extended to support fan-in/fan-out topologies. While the then syntax could be logically extended to support those kinds of use cases, the link approach may not.

Hello, sorry for the late response. I was not aware of #2381 and bevyengine/rfcs#45, whoops sorry. In hindsight, this is a very naive way of implementing sequential chains of system. I honestly think that there should be an easier way of making a linear sequential order of systems, but with the rfc I probably think it would be for the best that we should wait until stageless is implemented. However, I think the proc-macro I made for this should be useful in implementing system![].chain() or chain![].

Closing as this has been done in the stageless rework.


removes chime as a dependency

Changes proposed in this PR

removes chime as a dependency

Why are we making these changes?
Fewer dependencies, the better off we are :)

failed travis unit test run has a lot of debug statements https://api.travis-ci.org/v3/job/564143395/log.txt

@nsinkov

failed travis unit test run has a lot of debug statements https://api.travis-ci.org/v3/job/564143395/log.txt

The saml logs are between:
2019-07-26 18:42:08 DEBUG [main] waiter.test-helpers - 1 running test(s): {test-make-saml-authenticator/waiter.auth.saml-test 2019-07-26T18:42:08.569Z}
...
2019-07-26 18:42:10 DEBUG [main] waiter.test-helpers - 1 running test(s): {test-auth-redirect-endpoint/waiter.auth.saml-test 2019-07-26T18:42:10.076Z}
...
2019-07-26 18:42:10 DEBUG [main] waiter.test-helpers - 1 running test(s): {test-wrap-handler/waiter.auth.saml-test 2019-07-26T18:42:10.347Z}
...
2019-07-26 18:42:10 DEBUG [main] waiter.test-helpers - 1 running test(s): {test-saml-acs-handler/waiter.auth.saml-test 2019-07-26T18:42:10.599Z}
...
2019-07-26 18:42:11 DEBUG [main] opensaml.xml.signature.SignatureValidator - Signature validated with key from supplied credential
2019-07-26 18:42:11 DEBUG [main] waiter.test-helpers - 0 running test(s): {}

There are no more saml (org.opensaml.xml.XMLConfigurator) after the last saml test ends.


Remove turn option for cooperative games

Environment
Browsers: Chrome
OS: Mac OS
Steps to reproduce
Create team with cooperative option

Expected Behavior
There is no First turn option, since it doesn't make sense in cooperative game.
Actual Behavior

i will get that


if one page will be have multy Grid with different model  in method ->display()  column has incorrect model in $this

Laravel Version: 5.5
PHP Version: "php": "7.1.0"
Laravel-admin: 1.7.7

Description:
if one page will be have multy Grid with different model
in method ->display()  column has incorrect model in $this
function grid1(){
Admin::grid(
  (1.1)              Model1::class,
                function (Grid $grid)  {

****
$grid->someColumn('label column')->display(
                        function ($valueColumn) {
// correct $this
                        }
                    ) ;

}
****

function grid2(){
Admin::grid(
  (1.2)              Model2::class,
                function (Grid $grid)  {
 .....
 ***
$grid->someColumn('label column')->display(
                        function ($valueColumn) {
(2)                         // incorrect $this   dd($this);
                        }
                    ) ;
}

$this - has incorrect Model (Model1), but has correct attributes
may be problem in singleton
in class \Encore\Admin\Grid\Column
!!!!always one and the same model for all Grids on one page
public function setModel($model)
  {

      if (is_null(static::$model) && ($model instanceof Model)) {
          static::$model = $model->newInstance();
      }
  }

App::forgetInstance(Admin::class);
App::forgetInstance(\Encore\Admin\Grid::class);
App::forgetInstance(\Encore\Admin\Grid\Model::class);
App::forgetInstance(\Encore\Admin\Grid\Column::class);
This solution not working.
Please answer how use many Grids with different model on one page,
or fixed this problem.
Thank you

Try this.
use Encore\Admin\Grid;

function grid1(){
    $grid = new Grid(new Model1);
    ...
    return $grid;
}

function grid2(){
    $grid = new Grid(new Model2);
    ...
    return $grid;
}

But I think the filer will be the problems when use two grids in the same page.


Disable bauth removal where not applicable

when the user attempts bauth removal, check if bauth is implemented. if not, display "Basic Authentication not implemented in this app"

@liorkesos is it possible to check as the user attempts the command whether this is applicable or not?

Please list some general commands for apps as reference

As we discussed, this can be checked on the fly, no need to keep a list of where it's applicable

is the current command hossted httpopen?
if yes, please refer to #15, on how the reverse command should be done.

yes, current command is httpopen


[CSL-1619] Add MsgNo{Block,Headers} and related logic

What does this PR introduce?

Headers/block communication didn't have the response option for fail case. Instead, server node just didn't reply. As a result, calling party couldn't distinguish between timeout and negative response which lead to ambiguity. Now server party replies with exact error if it occurs.

Did the protocol change

Yes. Old clients won't manage to deserialize the message (binary format changed). But from the logic standpoint changes are minor.

Why is it needed in the mainnet.

We will later may want to introduce node web interface for querying blocks and headers separately and unability to understand whether node didn't reply or failed is very important to the client.
Similarly, we may have problems with debugging network timeouts because in order to confirm it is a timeout we need to check server node's logs.

This is still WIP, do not merge!
I was testing this change and have found a weird bug with unproper error handling. Thiss eems to be very important, i'm investigating.

Well, this is indeed not strictly necessary for mainnet, though I would ask @volhovM to expand on second commit (it was referred to some strange things observed with error handling, which are this things?)
Regarding inclusion post-mainnet: it will be a new endpoint if we want to change formats. But as far as I understand we were to refactor block handling in much more general way, so ... looks like there is no point merging this not now no later :(
@volhovM if there is some performance degradation or any other factor for mainnet, then please provide this commentary

This one is no longer WIP. So, the story: after I've added negative responses i decided to test them a little bit and discovered several bugs with a common source: exception handling in recovery worker was broken. Long story short: we expect that if failure happens inside the worker while we're in recovery, we catch in on the top level and then drop communication with recovery server node. But after #1393 was merged this predicate got broken: extra error handling (catch >> ignore) was added thus masking and hiding errors. This led to infinite loops on exceptions inside retrieval worker.
This PR together with feature fixes these bugs. And I tested negative responses also (throwing them in different places instead of responding correctly), seems to work as charm. It is absolutely crucial fix to have.
cc @georgeee

@dcoutts I've left two commits only as we've agreed.

To be merged into master as part of cardano-sl-1.0


[Serialization] Write protocol compositions as dependencies of protocols

A type dependencies are used at deserialization to drop a protocol early when a dependency is not deserializable. Dependencies on protocols via a protocol composition were not taken into account. This lead to the deserialization process failing later. Fix the serialization process to write protocol dependencies too.
rdar://78631465

@swift-ci Please smoke test

@swift-ci Please test Windows


Unexpected exceptions raised in main call may exposed TESTed internals

This test suite should check if a call to the function generate_division_by_zero raises a ZeroDivisionError.
- statement: 'generate_division_by_zero()'
  exception:
    message: "division by zero"
    types:
      python: ZeroDivisionError

However, if the following solution is submitted
print(1/0)

The stack trace exposes some of the TESTed internals that should remain hidden for students:

I guess we just forgot to clean the stack trace of the main call, because what happens above is as expected (test plan first executed main call and then calls a function, but the main call throws an exception that is displayed by the Python runtime on stderr, and exits, probably with a non-zero exit status that is not shown here). So all we should do is hide the execution_0.puy lines in the stack trace.


Support System.Text.Json 6.0 in v4 Client

This is blocking several of our projects from moving to .NET 6.0.

Also our projects are blocked by this (useless) package dependency restriction.
Please remove the upper bound as it is only needed if there are any breaking changes in the next versions. There are none anounced.

Nice one, thanks for that contribution <3

OK - no movement - time to fork?

@davidnmbond I think now is the time. I can handle this and in our organization, we're using this library heavily so there won't be an issue.

@davidnmbond I think now is the time. I can handle this and in our organization, we're using this library heavily so there won't be an issue.

Happy to help.  Give me a week to bring it up to our .NET 6.0 standards and I'll give you a shout.

While we wait, and for those that desperately need it, check out the PanoramicData fork which updates all nuget packages and has drastically overhauled the code base against the latest C#10 standards:
https://www.nuget.org/packages?q=PanoramicData.OData
https://github.com/panoramicdata/PanoramicData.OData.Client

Hey guys, please check out this issue I created some days ago: #835
I think its a bad idea to fork the repository and end up with 20 competing versions. As I understood @object, he would like to find a way to improve the maintenance of this repository... Can't you wait until what @object decides?

Btw, I do not like the idea to have any random company name in an open source product name. If the only viable option is to fork this repository, please consider a neutral name...

@ysmoradi (and others) sorry for late response and lack of maintenance activity from me in the last months. As I wrote in a different place, I haven't been using OData myself for more than 5 years, and at that time it was not even .NET Standard ready. All these years I've been doing develop,ment using different tool sets and even a different language (F#). And last couple of years having almost no time to add new features myself to this library, so I have to thank all of you for great contibutiion efforts.
I have been trying to find a proper replacement for myself, preferrably not a single person, just to avoid same situation again. Also having several people it's easy to avoid some design mistakes caused by individual decisions (which I did myself a few times). Your wish to continue developing the library looks promising, but I agree with @mbauerdev that just forking it might be an unnecessary step. Libraries are usually forked due to people being stuck with the original maintainer or due to differences in how to further develop them. While I can be classified as a burnout mainainer, I am willing to do my best to let the library develop live on supported by people who (unlike me) actively use OData and have inspiration to keep up with its new features.
So please think about what can be done to transfer library ownership (and its NuGet packages) from me to others.

While we wait, and for those that desperately need it, check out the PanoramicData fork which updates all nuget packages and has drastically overhauled the code base against the latest C#10 standards:
https://www.nuget.org/packages?q=PanoramicData.OData https://github.com/panoramicdata/PanoramicData.OData.Client

Seems to have the same problem.

@object - Happy to merge all the C# updates back in.  The new PanoramicData package is functionally identical, but with a LOT of code maintenance issues resolved.  To merge it back in, you will simply need to globally replace "PanoramicData.OData" with "Simple.OData", including the folder names, csproj file names etc.
In the meanwhile, the PanoramicData.OData nuget packages are working and free for all to use.

While we wait, and for those that desperately need it, check out the PanoramicData fork which updates all nuget packages and has drastically overhauled the code base against the latest C#10 standards:
https://www.nuget.org/packages?q=PanoramicData.OData https://github.com/panoramicdata/PanoramicData.OData.Client

Seems to have the same problem.

Yes - my mistake!  I've updated the package.  I hadn't actually factored in this pull request (facepalm).

Also, something to consider, making your package reference look like this also solves the problem:
    <PackageReference Include="Simple.OData.V4.Client" Version="5.*" NoWarn="NU1608" />
    <PackageReference Include="System.Text.Json" Version="6.*" NoWarn="NU1608" />

@object This PR seems like a quick fix. It would be great if you could merge it, because we are blocked with net6 migration, and ownership transfer does not seem like something that will happen any time soon

@robertmclaws Would you please consider fixing the same issue for Simple.OData.Client? I can create separate PR but it probably will be much quicker to merge this one


Install the vrp mission?

Use the forum topic, as for vRP, issues are not for help.


Merge master into develop

Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:

[ ] Write/update tests
[ ] make pr passes
[ ] Update documentation
[ ] Verify transformed template deploys and application functions as expected
[ ] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1047 into develop will increase coverage by 0.08%.
The diff coverage is 87.5%.

@@             Coverage Diff             @@
##           develop    #1047      +/-   ##
===========================================
+ Coverage    94.77%   94.86%   +0.08%
===========================================
  Files           69       69
  Lines         3256     3152     -104
  Branches       635      602      -33
===========================================
- Hits          3086     2990      -96
+ Misses          88       84       -4
+ Partials        82       78       -4

Impacted Files
Coverage Δ

samtranslator/model/api/api_generator.py
95.33% <87.5%> (+0.4%)
:arrow_up:

samtranslator/model/sam_resources.py
95.59% <0%> (-0.03%)
:arrow_down:

samtranslator/model/apigateway.py
97.72% <0%> (ø)
:arrow_up:

samtranslator/model/eventsources/push.py
88.85% <0%> (+0.24%)
:arrow_up:

samtranslator/swagger/swagger.py
97.66% <0%> (+0.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f886df...0773ce5. Read the comment docs.


Superfluid minting / invariants spec

Closes: #XXX
Description

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Need to fill out text for SuperfluidUndelegate and SuperfluidDelegateMore.
Also need to see how include how slashing connects to this.

q: what happens / what is supposed to happen if someone adds irrelevant tokens to a lock?
ex: Someone superfluids a lock of gamm/pool/1, but then adds gamm/pool/2 to that existing lock.

That should be impossible to do. Only two ways to add to a lock

Initial Lock creation
Add Tokens To Lock from msgServer

Adding Tokens to Lock via message server ensures that there aren't two denoms in the lock.

Codecov Report

Merging #933 (ce73b1f) into main (542d2f2) will increase coverage by 0.01%.
The diff coverage is 66.66%.

:exclamation: Current head ce73b1f differs from pull request most recent head b0e9f16. Consider uploading reports for the commit b0e9f16 to get more accurate results

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   20.59%   20.60%   +0.01%
==========================================
  Files         193      193
  Lines       25034    25038       +4
==========================================
+ Hits         5156     5160       +4
  Misses      18938    18938
  Partials      940      940

Impacted Files
Coverage Δ

x/superfluid/keeper/stake.go
58.68% <66.66%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542d2f2...b0e9f16. Read the comment docs.


Generate model to represent data mapping

Purpose
$subject
In this PR, we introduce a model that represents data mapping

Closing this until the implementation is finished.


Canvas not working with some basic file

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
The following is a JSON Canvas spec-compatible file, but Obsidian Canvas can't parse it properly.
{
  "nodes": [
    {
      "id": "1",
      "type": "text",
      "x": 100,
      "y": 100,
      "width": 200,
      "height": 50,
      "text": "1"
    },
    {
      "id": "2",
      "type": "text",
      "x": 500,
      "y": 100,
      "width": 200,
      "height": 50,
      "text": "2"
    }
  ],
  "edges": [
  {
      "id": "edge1",
      "fromNode": "1",
      "toNode": "2",
      "label": "description"
  }
  ],
  "metadata": {}
}

It should render a graph with 2 nodes and an edge between them.
Current behaviour
It doesn't render the graph.
Steps to reproduce

Save it as .canvas file and put it in the vault folder
Open the file with Obsidian

Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[X] Linux
[ ] macOS
[ ] Windows

Obsidian Version
1.6.7
Tasks Plugin Version
Not using it
Checks

[X] I have tried it with all other plugins disabled and the error still occurs

Possible solution
Test for compatibility with JSON Canvas spec.
Particularly, if you remove the edge from the list, then it renders fine.

I think you've figured this out already, but that is nothing to do with the Tasks plugin.


Chem: MMPa: saving tables to project

add all the tables to project
add all other objects as strings

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16447


Remove bootstrap from the codebase

The following tasks will finalize our departure from react-bootstrap our component library:
### Remaining components
- [ ] Replace Button Component: https://github.com/freeCodeCamp/freeCodeCamp/pull/51443
- [ ] Create Modal Component: https://github.com/freeCodeCamp/freeCodeCamp/pull/51070
- [ ] Progress Bar Component: #52011
- [ ] Replace Modal Component.

### Remove Bootstrap
- [ ] Remove the bootstrap classes that are used in the codebase. ( .btn, etc)
- [ ] Remove @freecodecamp/react-bootstrap as a dependency.
- [ ] Remove bootstrap.min.css injection.

### Clean up
- [ ] Removed unused CSS.
- [ ] Replace html elements that have a similar functionality with UI-elements.
- [ ] Move UI Components to its repo.

@Sboonny can you please assign me this issue??

The issue is not ready for contributions yet. The remaining components need to be replaced first.

Hii @Sboonny if you''ll be removing bootstrap, what css framework would you be using then?


[WFLY-14972] Check emptiness with Collection.isEmpty() (JPA)

Fixes: https://issues.redhat.com/browse/WFLY-14972

@scottmarlow Please review

@bstansberry Hello Brian, this one is approved, too. Please, could you check and merge?


experimental - open namespace quickfix remove lines when adding new namespace

Describe the bug
Open namespace quickfix remove lines when adding new namespace
To Reproduce
Use the open namespace quickfix on the Stream following code
module Repro

open System

type Foo = { Bar: string }

let bar (s: Foo) : Stream option = None

The line with type Foo will vanish.
If you remove the existing open System statement and do it again, it will remove both the type Foo and module lines.
Here's a gif too:

Environment (please complete the following information):

OS: windows
Ionide version: experimental
VSCode version: insider
dotnet SDK version: 3.0-preview6
mono / .Net Framework version: 4.0.30319.42000

Fixed by 23e71193b5af50dc696ecba75587ca007f1e617f


Add tests to highlight Number constructor whitspace handling deficiencies

Number('  2  ') === 2
So just like with trim, different environments handle internal trimming differently and inconsistently.

Related to #354

Thanks, fixed.


Issue #13: First approach

This is just a first approach to issue #13. @stephanenicolas and I were discussing how to this for some time so I gave it a shot. It's far from finish but I would like to have some feedback.
Instead of a factory I used the information gather by dart to create a separate class which works as an intent builder.
In our app we are trying to get rid of the IntentFactory pattern and let every activity be responsible of it's API via a builder. We hope we can make Dart take care of that.
Some open questions:

It doesn't make a lot of sense of me that ExtraInjection has a  Set<FieldBinding> instead of a single one. Why is that?
I didn't handle the parcel case. I am not 100% sure how it should be done
@f2prateek, does it make sense to you for IntentBuilder to get information from ExtraInjector? I am not very happy with the getters added
I haven't found a good way to handle mandatory / optional parameters. Any recommendation?

Thanks, I'll try to take a look this week. For the first question, this test case illustrates why multiple field bindings are required. Basically the same key could have multiple field bindings.

The biggest issue with this PR is that it should use a templating system to generate code.
Also a mandatory field check would be very nice for 1.0 release of the annotation processor.
And tests are missing to see if the annotation processor generates the right code. You can use "compile testing" or truth from Google for that.

Pleased to see this getting some attention.  I'll try to put some time into a review as well.

Thanks @stephanenicolas and @johncarl81!

I am reviewing the PR again. Here is the TODO list :

[ ] Adding unit tests to check generated classes.
[ ] check if we restrein the injectextra/intent builder to activities
[ ] fix the parcel / check serializable
[ ] check multiple bindings for the same key, how do we handle that ?
[ ] add tests to see if the intent is generated properly and inject extra can get the params. We think dart doesn't have those tests itself.

@stephanenicolas The test for the last is in the sample module - https://github.com/f2prateek/dart/blob/master/dart-sample/src/test/java/com/f2prateek/dart/example/SampleActivityTest.java

Thx @f2prateek . I am gonna work on that today.
Btw, there is another question, and I don't want to influence the answer : but are you 100 % sure you want to add this feature to Dart. I understand dart is very sharply focused, as butterknife is for instance. And adding such a new feature to Dart might be a little change of its actual focus.
The only alternative I see would be to create :

a shared artifact for Dart annotations
a shared artifact for the common part of annotation processor common to Dart and this new intent builder feature.
But it looks a bit heavy, and maybe after all that should simply fit naturally into Dart.

WDYT ?

I think it's useful to have this feature, but I agree there should be a way to seperate the binding features from the factory features.
I had considered two ways to do this.

The solution you proposed - a seperate annotation processor for generating the factories (and we use common code through a shared module).

Add an extra annotation (@GenerateFactory or something similar) for use on activities (and maybe fragments). This way the factories only get generated if the user has explicitly requested them, but simplifies our implementation.

I'm in favour of the latter, seems like there is much less ceremony around it.

Hi @f2prateek , thanks for your kind answer. From a user / dev perspective, I think solution 2 is really error prone : you have to annotate a class to get a behaviour..
It would prefer it the other way around. I mean, if you are to adopt this solution, why not having an annotation that prevents build from being generated ?
But if you really consider this feature is not part of the core of Dart (and to my mind this can be defended, I would say it is just a different aspect of Dart), we should split the library. I mean either split in a different library project with its own repo or as a new module in dart. But the best to enable/disable the feature would be to add or not a dependency to your build, as a dev.
But I think we might actually be over designing, to me it's quite possible that this is just a core Dart feature, just another aspect of extra injection.

sorry for the multi builds, I was blind, There was a problem in my pom files about the plugin (android maven plugin being differnt in parent and pom, not taking into account the groupId change).
Next commit is good.

@f2prateek This commit should be green. Everything works locally. So we :

Added unit tests to check generated classes of the intent builder
made it very clean and simple to use the parceler lib with the intent builder and Dart. (you never have to wrap or unwrap basically).
support multiple bindings for the same key, only one method is generated in the intent builder
added a test to see if the intent is generated properly and inject extra can get the params. This is part of the sample app tests.

@johncarl81 @f2prateek: Can you guys review?

In Transfuse I opted for mandatory extras to be handled as part of the first builder phase (in my case the constructor) then optional extras as optional methods in phase two.  My idea of how this should work in Dart is like this:
new SampleActivityIntentBuilder(context, requiredExtra1, requiredExtra2...)
    .setOptionalExtra3(extra3)
    .setOptionalExtra4(extra4);

This makes it much less likely that the end user will miss a mandatory extra
I like the null check on the extras druing the build(), in the case above these could be handled a little earlier in the constructor.

@johncarl81 about the constructor pattern :
We have also been thinking of a DSL that would be even more convenient, compared to a builder pattern. But it is a bit more complicated that our current model.
And personally, I prefer our current methods with meaningful names for each param more than a constructor's parameter. But that is really a matter of taste I guess. Though your way provides more constrain check at compile time...
We would have to all agree on the API before we change something like that.

@stephanenicolas, Yes, I prefer compile time errors over runtime errors where possible.  You could use Javadocs and parameter names to help with knowing what parameters are which.

@johncarl81 me too I must say, but still, I don't like to have to pass all params in one method call.
So maybe the only right way to do it and get the both of both worlds (compile errors and a nice syntax) would be a DSL.
If we target that for a next release then our current implementations is probably a good basis for a first shot.

Here is more or less what could the DSL generator look like. Indeed, it may not be so hard to implement :
public class IntentBuilder {
    private Intent intent = new Intent();

    public AfterSettingA withA(A a) {
        intent.putExtra(a);
        return new AfterSettingA() {};
    }

    public class AfterSettingA {
        public AllSet withB(B b) {
            intent.putExtra(b);
            return new AllSet() {};
        }
    }

    public class AllSet {
        public AllSet withC(C c) {
            intent.putExtra(c);
            return this;
        }

        public Intent build() {
            return intent;
        }
    }
}

@stephanenicolas, I have to say I like this approach.  This has the benefit of clearly asking for each parameter by name while leveraging compile time to enforce required fields.
One nit, I'd make sure to do a null check in each required DSL setter:
    //starting point
    public AfterSettingA withA(A a) {
        if(a == null){
            throw new IllegalStateException("Parameter a is mandatory");
        }
        intent.putExtra(a);
        return new AfterSettingA() {};
    }

@f2prateek : Follow up on the v2 idea and removing javapoet.
Ok. Good for me. I think it is for @Macarse as well. So, you take it, right ?
For the V2, chances are that we contribute. The best would be to have

a parent module
a common classes processor module
dart annotation processor module
intent builder annotation processor module
the runtime classes module
the annotation classes module

Actually, in a v2, would you mind to rename the intent builder to 'Henson' ? I had this idea in mind a long time ago of creating an annotation processor to generate a navigation sub-layer between activities : https://github.com/stephanenicolas/henson. I never had time to code it, it was intended to work with the byte code weaving InjectExtra equivalent of Dart I created last year, but I am happy to participate to coding it in Dart. However I find the name is nice and for good reasons. Do you mind ?

@johncarl81 we should double check with current optional / nullable contract of Dart for that. I didn't follow the latest changes. Wow, guys, we got a lot of features for a V2 here, but it really seems a lot for a PR !
Should we create a new V2 milestone, create a branch, and starting issuing tickets and coding ? Btw, I would be glad to join the contributors' team if that's possible.

status?

@Macarse I'm working on removing the JavaPoet dependency.

Hi @f2prateek , do you have any progress ? We are really looking forward to this feature.
Can we help ?

https://github.com/emilsjolander/IntentBuilder


RqLengthAware doesn't intercept the other two read() methods

At the moment, RqLengthAware doesn't intercept the other two read() methods, but it should. It should override them and make sure calls to them also decrease the internal length counter.

@yegor256 we will find someone to do this task, soon

@yegor256 milestone set to 1.0 (correct me if I am wrong)

@dmzaytsev the task is yours,please go ahead

@yegor256 thanks a lot for reporting, 15 mins added to your acc, pmt ID 000-db3fd47a

@davvd the PR for this task here  #208
please  find someone who can review this pull request

@yegor256 take a look the PR #208
please close  if that's all here, thank you

@dmzaytsev thanks!

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

@davvd Looks good!

@davvd Looks good!

@elenavolokhova thanks!

@dmzaytsev just added 10 mins to @elenavolokhova (for QA), payment ID is 56414325. 38 mins was added to your account, many thanks for your contribution! The task took 56414330.. age=58 hours and 2 mins, that's why a bonus here for fast delivery. added +38 to your rating, now it is equal to +1107


Switch from heketi:dev to stable image

Currently, the heketi/heketi:dev image is crash looping.  See https://github.com/heketi/heketi/issues/644.  It seems like a good idea to switch this project to use a released image version such as the latest 3 release instead of tracking the dev version.

There is also the issue that #112 is trying to address. We need to shift to a released version, yes, but I don't think 3 is sufficient. We need to aim for publishing release 4 ASAP and settling on that.

I also see that the reference issue was close. :) Changing this one to make it more useful.

This is still pending, but should definitely be done!


Feature/4/home

Engineers Checklist
What this PR does?

List of updates for features, enhancements, or bugfixes

How can it be tested?

Please provide step-by-step guide on how to test
If web or mobile, screenshots will be very helpful in addition

Where is it documented?

List JIRA tickets

Backend Updates

[ ] Updated Postman Documentation

[ ] Requests
[ ] Examples
[ ] Tests

[ ] Updated Tasks on JIRA
[ ] Tested API updates in dev environment
[ ] CI Checks Passed

I have worked on the alignment and responsiveness


Configuration console configuration loading/saving needs revision

While working on #22, I realized that the config console is going to need to change the way it loads configuration.

The problem comes when saving the configuration. .net does not provide facilities for saving configuration.
Currently, the config console serializes the SnapsInAZfsSettings object that was built from configuration when saving.
The problem with that is that anything that isn't explicitly defined in the class hierarchy will not be serialized and thus will be lost on save.
The JsonSerializer is capable of maintaining arbitrary JSON in a Dictionary marked with the [JsonExtensionData] attribute, which solves that problem. But, the configuration system in .net is unaware of that functionality and does not load anything into that dictionary, in the first place.
Thus, to make the config console able to handle formally defined properties as well as other arbitrary properties, the config console will need to explicitly load the configuration using the JsonSerializer, rather than the .net configuration extensions.
This is fine, but will just need some refactoring.
Originally posted by @dodexahedron in https://github.com/snapsinazfs/snapsinazfs/issues/22#issuecomment-1675521529

One problem that became immediately apparent upon starting work on this is that the implicit layering of configuration that the .net configuration subsystem does isn't something that will be handled by the JsonSerializer.
I will have to think about the most appropriate way to deal with this.
As I see it, there are two ways to handle it:

Continue to use the .net configuration subsystem for loading configuration, but deal with it in its native key-value-pair form in the config console and explicitly write out the equivalent JSON when saving.

Avoids re-inventing the wheel for the layering functionality
Potentially more difficult to enforce rules, since nothing will be strongly-typed
More flexible with regard to arbitrary settings not explicitly defined in classes in the application

Use the JsonSerializer to load the configuration, and manually handle layering configuration.

Will have to ensure the specified configuration files are loaded and layered correctly
Stronger guarantee that the resulting configuration is valid
Will have to ensure that [JsonExtensionData] members are defined and round-trip correctly

I'll start working on this and make a decision as the actual relative complexity and any other caveats of each option become clearer.

This ended up being a lot easier than I thought.
Since we don't really care about strongly typing the Kestrel settings in SIAZ itself, all I ended up doing was making the Kestrel property of the MonitoringSettings class an object. Then, when the configuration is loaded into the ConfigurationBuilder, we grab that section, turn it into a Dictionary, and turn it into a JsonNode.
See here for how it's done.
Doing this means no changes have to be made to the configuration console to handle it. Yay.


Adjust admin page design

Applying the new design to the admin pages.

after pulling the latest changes .. I saw that the admin is broken when resizing the browser

Yes, I found the same. I think it is not responsive yet or has bug for smaller size screen especially for header.

i will fix that now, i didn't make it responsive
On Sun, May 13, 2018 at 4:06 PM, Nikunj Kanetiya<EMAIL_ADDRESS>wrote:

Yes, I found the same. I think it is not responsive yet or has bug for
smaller size screen especially for header.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/tamiat/tamiat/issues/187#issuecomment-388629406, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVspUdxXBfrzhD6USXO3a2JLoOOXUnSHks5tyD3vgaJpZM4T4i91
.

@mohamedAdel01 Open any page directly except localhost:8080/admin for example http://localhost:8080/admin/media it will not show the logo, instead of this it will show the placeholder because logo image will not be found on that path, So that's why I have changed path static/logo-path to /static/logo-path. Please check the same.

one more minor issue with side nav-bar which has sub-items like contents. On hover the side will be closed something strange. Please just check it and if needed I will send you the video.
Thanks

And check another small issue for height

@mahnouman Cross checked everything mentioned in this thread and it all seems to be as expected now. Safe to close it.


Add missing Tabs on organisation/package view (Frontport #20539)

Frontport #20539
Hotfix https://github.com/go-gitea/gitea/issues/20106

.


Docs.MS Release Updates for Microsoft.Extensions.Azure

Update docs metadata and targeting for release of Microsoft.Extensions.Azure

Docs Build status updates of commit ed9336b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/overview/azure/microsoft.extensions.azure-readme-pre.md
:warning:Warning
View
Details

api/overview/azure/microsoft.extensions.azure-readme-pre.md

Line 2, Column 1: [Warning-title-missing] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'core'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 16, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/aspnet/core/fundamentals/dependency-injection?view=aspnetcore-3.0
Line 16, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/aspnet/core/fundamentals/configuration/?view=aspnetcore-3.0

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Setup help

-Added screenshot of service account email
-Added sample env
-Created Prerequisites

Done!

These changes have been merged into the 0_only-passwords branch through a squashed merge with a few extra changes.


includeCustomMappers doesn't work with Iterable spread operator

const myMappers = [MyMapper1(),MyMapper2()];

@MappableClass(includeCustomMappers: [...myMappers])
class SomeClass  {

}

will generate faulty code
MapperContainer.globals.use(...myMappers);
since use only accepts a single mapper

It also doesn't work with
const myMappers = [MyMapper1(),MyMapper2()];

@MappableClass(includeCustomMappers: myMappers)
class SomeClass  {

}

I suggest instead of this loop, the useAll method should be used instead
https://github.com/schultek/dart_mappable/blob/3b021d6c18a2c797603850f854daaec7e701d247/packages/dart_mappable_builder/lib/src/generators/class_mapper_generator.dart#L66-L71

Good catch

Fixed in 3.1.1


function unknow

    Hi,

thanks for your interest!
You can refer to the code below for visual analysis.
def plot_seg_result(img, mask, type=None, size=500, alpha=0.5, anns='mask'):
    assert type in ['red', 'blue', 'yellow']
    if type == 'red':
        color = (255, 50, 50)     # red  (255, 50, 50) (255, 90, 90) (252, 60, 60)
    elif type == 'blue':
        color = (90, 90, 218)   # blue (102, 140, 255) (90, 90, 218) (90, 154, 218)
    elif type == 'yellow':
        color = (255, 218, 90)  # yellow
    color_scribble = (255, 218, 90) # (255, 218, 90) (0, 0, 255)

    img_pre = img.copy()

    if anns == 'mask':
        for c in range(3):
            img_pre[:, :, c] = np.where(mask[:,:,0] == 1,
                                        img[:, :, c] * (1 - alpha) + alpha * color[c],
                                        img[:, :, c])
    elif anns == 'scribble':
        mask[mask==255]=0
        mask = mask[:,:,0]
        dilated_size = 5
        Scribble_Expert = ScribblesRobot()
        scribble_mask = Scribble_Expert.generate_scribbles(mask)
        scribble_mask = ndimage.maximum_filter(scribble_mask, size=dilated_size) #
        for c in range(3):
            img_pre[:, :, c] = np.where(scribble_mask == 1,
                                        color_scribble[c],
                                        img[:, :, c])
    elif anns == 'bbox':
        mask[mask==255]=0
        mask = mask[:,:,0]
        bboxs = find_bbox(mask)
        for j in bboxs:
            cv2.rectangle(img_pre, (j[0], j[1]), (j[0] + j[2], j[1] + j[3]), (255, 0, 0), 4) # -1->fill; 2->draw_rec

    img_pre = cv2.cvtColor(img_pre, cv2.COLOR_RGB2BGR)

    if size is not None:
        img_pre = cv2.resize(img_pre, dsize=(size, size), interpolation=cv2.INTER_LINEAR)

    return img_pre

Originally posted by @chunbolang in https://github.com/chunbolang/BAM/issues/13#issuecomment-1089620111

Sorry for the late reply.
This function is not provided as it is not very relevant to our work, and you can refer to this link for the function ScribblesRobot().
Best,


#165 Fix duplication of assure_each

Fix #165
Duplication of assure_each is removed. One method is renamed to assure_each_not.

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   62.92%   62.92%
=======================================
  Files          25       25
  Lines        1130     1130
  Branches       96       96
=======================================
  Hits          711      711
  Misses        413      413
  Partials        6        6

Impacted Files
Coverage Δ

selene/elements.py
47.81% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4776357...88593c1. Read the comment docs.


Static docstring missing reference

Registers a root to serve files from.  The input can either be a file
        or a directory.  See

Should reference some issue or commit?

@agoose77 it looks like you are the one who added that line, based on the git blame :)
51611c39 sanic/sanic.py (Angus Hollands       2017-02-14 19:10:19 +0000 204)         """Register a root to serve files from. The input can either be a
51611c39 sanic/sanic.py (Angus Hollands       2017-02-14 19:10:19 +0000 205)         file or a directory. See

Going to close this. Will reopen if necessary.


SSH2 Pecl extension not installed error

I get

Oh snap: ssh2 PECL extension is not installed. Please install it to use ssh.

after php artisan deploy command on L5

This was discussed on #5. Basically, you'll need to have the ssh2 PECL extension installed.

But where do you need to install this? I'm running my Laravel on local server. The one that comes with laravel --> php artisan serve command
Or do I need to install it on my production server?
Thanks @fadion :)

I don't believe you can install extensions for the built-in PHP server. I'd highly recommend setting up vagrant with homestead, an operations that won't take more than 5 minutes. Then you can easily install ssh2 in the vagrant box.

Thank you @fadion, it worked as expected with vagrant and homestead.

@alexhoma Glad I was of help.


Config the account for sentry

What would you like to be added:
We are apply for sentry which is free for opensource project,  sentry replied that

we should create a sentry account
convert the account into a sponsored one.

The replied email:

Why is this needed:
Because we want to use sentry for debugging
The process of introduce sentry will be tracked in the issue #122

/assign @RainbowMango

All of the task is that creating sentry account, and I'll finish the next step.
sentry:  https://sentry.io/welcome/
sentry plan for opensource project:  https://sentry.io/for/open-source/
account register: https://sentry.io/auth/login/

OK, no problem! I will take a look at it.

I‘m not familiar with the tool, would you please give a brief introduction about it at the next dashboard meeting?

I‘m not familiar with the tool, would you please give a brief introduction about it at the next dashboard meeting?

It's ok. I made a simple notes about sentry, you can view the notes if you like 👉🏻 https://dingwenjiang.notion.site/sentry-10425bd1f17780df968cfbbff117bf5f?pvs=25
apart from basic introduce, also made a show-case to solve the problem just occured:
issue link: https://github.com/karmada-io/dashboard/issues/120
and the corresponding solution:

We need extra configurations to control whether to enable error report. For some sensitive users, maybe they don't want to report any thing to the public platform, or maybe they have self-hosted sentry, we need to report to the self-hosted sentry.

Done.
Created the account and sent the invitation to you.
/close


Contact info?

Hey!
I have a few questions about your code. How can I contact you for a quick conversation?
Thanks!

plese answur we need talking u!

@paralin you can contact<EMAIL_ADDRESS>

@anunimeese ??


(#213) - basic authentication for rpm slice

This is for #213.

Codecov Report

Merging #240 into master will decrease coverage by 0.27%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #240      +/-   ##
============================================
- Coverage     80.17%   79.89%   -0.28%
  Complexity      214      214
============================================
  Files            37       37
  Lines          1175     1179       +4
  Branches         52       52
============================================
  Hits            942      942
- Misses          224      228       +4
  Partials          9        9

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/com/artipie/rpm/http/RpmSlice.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d2b30...a810029. Read the comment docs.

This pull request #240 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@victornoel the puzzle #250 is still not solved.

@g4s8 PLease merge

@sereshqua/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@paulodamaso please make sure you will find at least 3 issues during next CR, thanks

@paulodamaso ping

@sereshqua I'll try to find at least 3 issues in my next review, thanks

@0crat quality acceptable

@victornoel the only puzzle #250 is solved here.


Dilato: Core: There is a layout issue on quick open panel if the URL is too long

Steps:

Launch Brackets 1.13
Press ctrl+shift+O for win and cmd+shift+O for mac
Input a URL which is long, such as "http://www.baidu.com/s?ie=utf-8&f=3&rsv_bp=0&rsv_idx=1&tn=baidu&wd=首都博物馆&rsv_pq=8a880d180000121c&rsv_t=5a5au2RiMw4aK8tEHK4Jdd%2B7FTrkeY4MubGOJcyFhYc9mevwSNATfJX39YE&rqlang=cn&rsv_enter=1&rsv_sug3=2&rsv_sug1=2&rsv_sug7=100&rsv_sug2=1&prefixsug=shoudu&rsp=3&inputT=2078&rsv_sug4=2079"
Press ctrl+shift+O for win and cmd+shift+O for mac again

Result: There is a layout issue on quick open panel
Expected: No layout issue, the URL could display as ...

Build: 1.13.17668-1023

Verified this issue on build  build 1.13.0-17688 fixed


[do-not-merge] Check CI

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release notes:

/ok-to-test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.288%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1548

Relevant Lines:
2611

💛  - Coveralls


Fix compression integration testing with direct buffers

Motivation:
We did not correctly increase the writerIndex when testing with direct buffers so the test did not test anything
Modifications:
Replace setBytes(...) with writeBytes(...)
Result:
Test with direct buffers are done correctly

Noticed while porting compression stuff in netty 5

Rebased this.


Fully implement BsonPath

Hi @jcme if you want to chat about this in more depth I'd be happy to do that, I appreciated my description of the task was very vague! ;)

Hey @purplefox that probably would be very useful - thanks! I've used our brief mIRC conversation for some rough notes, but a slightly more detailed chat would probably help set me off in the right direction. Any chance you're in Welwyn before Christmas? We could grab a quick coffee

Unfortunately I won't be in the office until the New Year now :(
The original idea behind BsonPath was a bit like JsonPath http://jsonpath.com/ - a way to match/select/update elements in Bson documents.
An example is in our shopping basket example, here we want to increment the quantity of a product in a basket document when an event comes in.
A shopping basket might look like this:
{
    "basketID": 1256125
    "products": {
        "product1", 12
        "product435", 1
        "product32", 2
    }
}

If we want to increment the quantity of product435 with BsonPath we can just say:
BsonPath.add(basket, 2, "products", "product435");

Whereas if we had to do that by manipulating the BsonObject directly (or just using a Map) then it would be a lot uglier:
BsonObject products = basket.getBsonObject("products");
if (products == null) {
    products = new BsonObject();
    basket.put("products", products");
}
Integer currentQuantity = products.get("product435");
if (currentQuantity == null) {
    currentQuantity = 1;
}
currentQuantity++;
products.put("product435", currentQuantity);

(Internally that's more or less what BsonPath does).
So it's all about making it easier for the user to manipulate Bson objects.
Currently the path in BsonPath is represented as a list of vararg parameters, but we can also support representing a path as a string (like JsonPath does).
There's a lot of scope for the kinds of operations we can support here, I think initially it would be good to have:
get
set (already have this)
add (already have this)
remove
just working on a static path
we can also have matching operations, e.g.
boolean matches(BsonObject bsonObject, String... somePath)

Matches will be useful in implementing queries amongst other things.
Just some ideas.

BTW, if you want something a bit smaller we can find you another task too. Up to you :)


Syntax: support for backslash u range

Could you add support for the following syntax (when wchar_t chartype is used):
\uffff

it is always 4 hexdec characters

you can use \x{ffff}

PCRE doesn't support \uffff

I'm thinking about making alternative grammar with ECMAscript regex syntax.


How can I generate my own code instead of a third-party library?

Thanks to the author's efforts, I successfully converted some of the standard Python libraries into Rust code, and I thought that I could only convert the Python code I wrote into Rust code, and if I could, this library would be very easy to use。

Hello @wuxinfashi687,
Just for clarification, this project does not convert Python code into native Rust code. With pyo3_bindgen, you can generate bindings for calling Python from Rust. During runtime, the Python code must still be available to the underlying Python interpreter.
Option 1 (generate from Python module) [recommended]: If you wish to generate bindings to your own code, you could install it as a module in your local Python environment. You can do that in several ways, such as python -m pip install <path/to/my_module> if you use pip, or you can even directly modify the PYTHONPATH environment variable such that it includes a path to your module. Then, you can generate the bindings as usual:
let bindings = pyo3_bindgen::Codegen::default()
    .module_name("my_module")
    .unwrap()
    .generate()
    .unwrap();

**Option 2a (generate from source code string): To quickly see the generated Rust bindings for any single-file Python code, you could use Codegen::module_from_str(). However — as mentioned above, the Python code must still be available to the underlying Python interpreter during runtime.
const PYTHON_SOURCE_CODE: &str = include_str!("path/to/python/source_code.py");

let bindings = pyo3_bindgen::Codegen::default()
    .module_from_str(PYTHON_SOURCE_CODE, "my_module")
    .unwrap()
    .generate()
    .unwrap();

**Option 2b (runtime embedding of Python source code): If using Python modules is not an option (e.g. you wish to make your Rust code more portable), you could try embedding your single-file Python source code within your runtime Rust binary. You must make the module available to Python under the same name that you used to generate the bindings. This can be done in multiple ways, e.g. with sys.modules. However, I have not tested this workflow yet.
const PYTHON_SOURCE_CODE: &str = include_str!("path/to/python/source_code.py");

pyo3::prepare_freethreaded_python();
pyo3::Python::with_gil(|py| {
    let my_module = pyo3::types::PyModule::from_code(
        py,
        PYTHON_SOURCE_CODE,
        &format!("my_module/__init__.py"),
        "my_module",
    )
    .unwrap();

    py.import("sys")
        .unwrap()
        .getattr("modules")
        .unwrap()
        .set_item("my_module", my_module)
        .unwrap();
});

Since 0.5.0 (#20), function pyo3_embed_python_source_code() is now automatically included in all Rust modules generated from Python code via Codegen::module_from_str(). Therefore, you do not need to manually embed the Python code yourself, but you can instead use this convenience function instead. Below is an example of how the code above can be simplified.
Generate the bindings (same as before):
const PYTHON_SOURCE_CODE: &str = include_str!("path/to/python/source_code.py");

let bindings = pyo3_bindgen::Codegen::default()
    .module_from_str(PYTHON_SOURCE_CODE, "my_module")
    .unwrap()
    .generate()
    .unwrap();
}

Use the generated bindings:
include!(concat!(env!("OUT_DIR"), "/bindings.rs"));

pyo3::prepare_freethreaded_python();
pyo3::Python::with_gil(|py| {
    // Embed the Python source code for the module `my_module` into the underlying Python interpreter
    my_module::pyo3_embed_python_source_code(py)?;

    // Use the module `my_module` (e.g. call a function from it)
    my_module::my_function(py)?;
});


Terraform is registering all the providers in Azure subscription and failing sometime

For new azure subscription we have observed that few providers needs to be register or else script will try to register all the providers/services in Azure which are not required as well. Its best practice to make sure only the required services are registered.
Also, script is failing and giving the following error while registering the providers some times
"Getting error after running ./install.sh ""│ More information on the ""skip_provider_registration"" flag can be found here:
│ https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration
│
│ Original Error: Cannot register providers: Microsoft.AVS. Errors were: waiting for Subscription Provider (Subscription: ""d9908e94-6899-4ef6-8a14-5a185b3b7254""
│ Provider Name: ""Microsoft.AVS"") to be registered: context deadline exceeded
│
│   with provider[""registry.terraform.io/hashicorp/azurerm""],
│   on main.tf line 1, in provider ""azurerm"":
│    1: provider ""azurerm"" {"
We can instruct the user to make sure the required services/providers are registered and update the terraform scripts to skip the registration of all the services. I have raised PR for the same
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/resource_provider_registration
cc @gandham-santhosh @mohitga @vinukumar-vs @santhosh-tg @keshavprasadms

Thanks @sanketnagdive
@keshavprasadms can you look at it once?


Add Authentication Overview to WIki

This is a sub-page of API
See content in Authentication.docx

@shaneSheridan I just realized you could add files here. so cool!


增加安卓的沉浸式效果

Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist

[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

pass


Add CreateIncomingPayment on the admin graphql

We currently can only get and list incoming payments via the graphql api. We want to add support for also creating incoming payment via the graphql api.

Is this to create an incoming payment for any payment pointer or only one at this account provider?
If the former, I'm creating an Open Payments client service for #581 that could also do incoming payment creation.

Is this to create an incoming payment for any payment pointer or only one at this account provider? If the former, I'm creating an Open Payments client service for #581 that could also do incoming payment creation.

See:

#595


More information about the Location Data

Is it possible to give more information on how the location data is produced? Is it a mixture of IMU and vision based SLAM?
Thank you

Hi @Neabfi , the location trajectory data is generated by a proprietary visual-inertial SLAM pipeline, using the global shutter mono cameras + IMUs


The log flush thread should exit, after the main thread exits

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
Java Agent (apache/skywalking-java)
What happened
The log flush thread should exit, after the main thread exits.
What you expected to happen
when main thread exits， process should exits.
How to reproduce
throw exception at main thread, but process didn't exit.
Anything else

Are you willing to submit a pull request to fix on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You could simply logFlusherThread.setDaemon(true); then it would be closed with JVM shuts down.


Option forwarding

Opts to opt(ion)s, and dust to dust

Nonbreaking, but https://github.com/google/traceur-compiler/pull/1621 may see amendments. We can dangle for a while.
Maybe time to DRY up the opts->options transform.

Nice, happy to merge in the mean time and we can change later.

Can I get push here to save admin on my fork? :family:

@crisptrutski sure I've added you.


Add Modal component

Fixes

Fixes #458 by @sarayourfriend
Description

Adds a new Modal component based on the same code as the popover.
Refactors the popover composables to be more generic "dialog" composables and applies them to the modal.
https://user-images.githubusercontent.com/24264157/144447616-8bc4a7c8-16d3-4ad1-ad25-c490ac059088.mov
Testing Instructions

Run npm run storybook and visit http://localhost:6006/?path=/story/components-vmodal--default and test the modal with different props.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Outstanding question: should we scroll-lock the background (main page) when the modal is open?

Also wanted to point out that yes the Modal and Popover implementations are almost identical, but I'm not sure how to abstract them properly to combine them 🤔 I think a base VDialog component would make sense that VModal and VPopover would extend but with how the Vue templates work I think it would end up being more or less the same amount of code and prop documentation duplication that we have now.

I totally forgot about focus trapping, thanks for catching that! Shouldn't be too bad to fix.
The focus styles for the close button in general are bad, I put the regular focus ring in as a placeholder and meant to ping @panchovm about it. I don't think the focus ring by itself works well because the close button is right aligned with the edge of the modal so the focus ring is too "tight" horizontally with the button contents.
I'm confident Francisco can come up with a good solution for it 😁

When testing, I'm seeing the focus ring on these pink buttons is also pink, which seems like really insufficient contrast. Should I make a separate issue for that? I'm not sure if that's been introduced in this PR or not.

Not sure when that was introduced but this PR doesn't change the button other than adding a new variant so I think it's a separate issue.

Right now opening the modal via keyboard interaction will always focus the close button first, as it is the first tabbable element inside the dialogRef node. I think we could potentially add a prop for this like skip-close-button-on-focus (ugh, names!) that would skip the close button and focus the second tabbable element.
Reakit's implementation of this is nice because you can just pass an initialFocusElement prop but when I tried to get that to work with the popover I couldn't because at the time when you want to do the focus management, the ref for your internal node could still be empty. I wonder if we could somehow create a custom ref for this that would be able to signal like "reference pending re-render" or something so that we could just use initialFocusElement instead of trying to do something jankily named prop like skipCloseButtonOnFocus or whatever.

I once implemented a modal in react with something to the effect of an 'initial-focus-element-index' prop where if you wanted, say, the 5th element in a modal to be focused first, you passed the index5 to the prop. Terrible api design 😆

you passed the index5 to the prop
😱

I am not sure about the interface/visual consequences when @sarayourfriend says that Modal and Popover are equal. I guess it is just an implementation aspect. In terms of behavior, I like the idea of pressing escape any time on the modal to close it. The modal layout in general suggests a sub-navigation where it seems like a glance of a long searching for relevant content journey.
Regarding Modal size and breakpoints, I will work on a proposal. But for now, the desktop version is in the audio and image single result mockups. Whereas the mobile proposal I am handling looks like opening a new page but with a back to results action top-left aligned. However, I am seriously considering replacing it with a top-right aligned close action.
I will share a proposal for the focus style of close button soon. My initial guess is having a similar top-bottom and left-right padding that goes off the modal's width with a 1.5px white border. After all, the focus style is for highlighting the element itself.

Outstanding question: should we scroll-lock the background (main page) when the modal is open?

Yes, I agree with @zackkrida on this.

I just think the new components need some testing.

I agree! I've been trying to decide how to do this because most of the things that are actually testable in this component are already tested in the popover. The things the modal adds are:

Focus trapping - No need to test this as it's a third party library and we don't need to test it's implementation
Body scroll locking - I don't know how to test this without testing the implementation details and, in fact, I don't even know that we could test it in JSDom as I don't believe it emulates scroll position.

Body scroll locking could be tested in the e2e tests but this modal isn't implemented anywhere yet and we don't run the e2e tests against storybook I don't think.
I suppose I could add a test for the open/close behavior and the close button though.

@krysal can you re-review? I added tests for the close button and the scroll locking. Everything else is already tested by the VPopover tests. Those tests need to be abstracted out of the VPopover test suite. I tried doing this in this PR but I ran into some blockers and weird behavior... and it would increase the size of this PR significantly to re-write those tests.
I opened this issue https://github.com/WordPress/openverse-frontend/issues/501 to address that in the future.

Thanks for catching that @krysal! It's fixed now 🙏


Restrict access to engagement form page for team members

Issue #:
https://github.com/bcgov/met-public/issues/1281
Description of changes:

Allow team members to visit engagement form page for their engagements only
fix team members draft engagement filter
Add assigned engagement ids to redux

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1313 (c64cb9f) into main (d23ef3d) will decrease coverage by 0.02%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
- Coverage   72.46%   72.44%   -0.02%
==========================================
  Files         304      304
  Lines        8684     8696      +12
  Branches      631      631
==========================================
+ Hits         6293     6300       +7
- Misses       2290     2295       +5
  Partials      101      101

Flag
Coverage Δ

metapi
79.67% <72.72%> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

met-web/src/apiManager/endpoints/index.ts
100.00% <ø> (ø)

...b/src/components/engagement/form/ActionContext.tsx
59.52% <ø> (+0.22%)
:arrow_up:

...agement/form/EngagementFormTabs/EngagementForm.tsx
76.19% <ø> (-0.29%)
:arrow_down:

.../src/components/permissionsGate/PermissionMaps.tsx
100.00% <ø> (ø)

met-web/src/services/membershipService/index.tsx
41.66% <ø> (ø)

met-web/src/services/userService/index.ts
31.48% <ø> (-1.25%)
:arrow_down:

met-web/src/services/userService/userSlice.ts
28.57% <ø> (-4.77%)
:arrow_down:

...et-api/src/met_api/resources/engagement_members.py
66.66% <58.33%> (-3.04%)
:arrow_down:

met-api/src/met_api/services/engagement_service.py
70.12% <87.50%> (+0.33%)
:arrow_up:

met-api/src/met_api/services/membership_service.py
44.44% <100.00%> (-1.21%)
:arrow_down:

... and 1 more


[Documetation] Fixed links in getting-started.md

Fixed broken links in getting-started. Each link should be prefixed with /guide/ and ended with / instead of .html.
For example, previously clicking on 'Architecture overview' led to https://docs.convergence.io/architecture-overview.html, while the actual URL is https://docs.convergence.io/guide/architecture-overview/.

Yes, I noticed a few more broken links, but I'll make separate PRs for each page to make it easier to test changes.


[feature] allow ModelClient to fetch from different origins

Option for ModelClient to fetch from different origins.

@CezCz

@iameduardod Could you elaborate on your use-case, please?

@iameduardod Is this feature-ask still valid ?
If yes, Can you please add more details about the feature-request and use-case in the description, as requested ?

@sharanyavinod  @habansal  will share a sample repo today!

@sharanyavinod  @habansal  Here is a small repo with files and diagram that would hopefully explain this request! https://github.com/iameduardod/ModelClientFetchCORS


Improve project_stats display (7-day average, JSON link). Fixes #441

Add a 7-day average to the new/updated project chart, and
add a link to the JSON data.  This is per request from CII.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 98.29%

Merging [#443][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #443   diff @@
==========================================
  Files            37         37
  Lines           878        878
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            863        863
  Misses           15         15
  Partials          0          0

Powered by Codecov. Last updated by [5eca975...7c08dd4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/linuxfoundation/cii-best-practices-badge/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/linuxfoundation/cii-best-practices-badge/compare/5eca975ba15ef79697ca485ac04a1adf987e1cf0...7c08dd4adf5ab1a8fe930f0c9b396580bd3555db
[cc-pull]: https://codecov.io/gh/linuxfoundation/cii-best-practices-badge/pull/443?src=pr

This looks fine to me. I may come back in the future and move most of it to a helper, but that's mainly a taste issue.


aim42.org is down

Currently, a 404 is shown when accessing the homepage.

I moved this site over from github-pages to netlify today, and therefore reconfigured
several name- and DNS-Server...
let's wait a few more hours.

DNS transfer seems to be completed - site is up again.