Need to review the algorithms for creating a new environment settings object

In the Run Service Worker algorithm we create a new environment settings object for the worker. But the algorithms we define for that settings object don't entirely match the algorithms the HTML spec expects a settings object to have. The version in the v2 spec seems at least somewhat better than the version of this algorithm in v1, but I'm not convinced either of them is entirely correct.

We already split the specification into versions? Oh geez...

Who thought that was a good idea for interoperability?

I believe you also remember we discussed about moving this to CR from long back. Branching V1 is needed for it while we still work on adding stuffs.
I'll apply the V2 changes of the Run Service Worker algorithm to V1 and fix them further with the latest HTML changes around the global concepts. I put them only to V2 then since it was about the worker type classic/module change that I wasn't sure it's also for V1 by that time. This is the only difference except the additional features.

I believe you also remember we discussed about moving this to CR from long back. Branching V1 is needed for it while we still work on adding stuffs.

Still seems like a bad idea given that we have limited resources.

It's probably better to just abandon v1 and not work on it further. It can advance through the dead standards track as long as everyone knows not to try to implement from it.

The contributors have committed to this standards track work since long ago and discussed during the last f2f in Seattle to move V1 to a CR right after this year's TPAC. There's no difference between V1 and Nightly except the algorithm mentioned in this thread and those added only to Nightly. That is, V1 features are what browsers currently implement and ship. V1 will serve as a stable snapshot for the features that it currently covers.

"Stable" is not a thing in standards. All of it requires ongoing maintenance and refactoring. We shouldn't delude ourselves that this is not the case. You are of course free to allocate your time as you wish, but from experience I can tell you that maintaining two versions, while having to do refactoring, fixing issues, etc. is not really workable if you want to get things done.

I think maintaining a living standard is analogous to committing patches to the tip-of-tree of a software repo. Ongoing maintenance and refactoring on it is absolutely natural and what we should pursue. Isn't publishing a snapshot of a standards work something similar to shipping a certain version of a software so we can reference the milestone?

Yeah, if standards had the resources software teams have that might be reasonable. We are however pretty far removed from that. Basically the standards version of the platform cannot really run/ship so needs to focus on catching up first.

Isn't publishing a snapshot of a standards work something similar to shipping a certain version of a software so we can reference the milestone?

I think it would be analogous to maintaining Chrome version 1 for a couple years. Nobody does that; instead the master branch is where all work takes place. Sometimes critical security fixes are backported to a previous version of the software. But only if people are currently using it---and nobody is currently using service workers v1. All implementers know that you should only look at the master branch of specs.

I think your explanation is true from the aspect of using a spec as a reference of an ongoing implementation. But a snapshot - V1 - would also perform a role in providing a milestone which different products (in their own pace) can reference to among each other. Not all the browsers can always ship the latest features in a spec in the same pace.

We're going to do a V1. It's going to be a stable snapshot that can get patent protection, which an unversioned copy simply can't.
If the WHATWG camp has a solution to patent cover, would love to hear it. Until then, can we focus on what algorithms need to be updated? Thanks.

@slightlyoff I'd appreciate if you didn't make this about camps. Nobody brought up such artificial divisions until you did, and it isn't conducive to productive conversation.
What we're trying to discuss here is whether v1 needs to be updated. You haven't explained why it should be (patent coverage is unchanged).

I think the question here is "does v1 need to be updated in order to support changes required to finish it off?". I'm fine with us back-porting the algorithms in question to support that.

Pre F2F notes: seems like a spec wording issue. But do we want to backport this to v1?

We already backported it to V1: https://github.com/slightlyoff/ServiceWorker/commit/5d19151493fa243eb034886c795d4869b74f9ac5. The last bit - referrer policy language adoption - is being tracked in https://github.com/slightlyoff/ServiceWorker/issues/834.


Integration Test - Release - 2018/09/28 01:31:03

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest2 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


[BUG]: Translate from another locale Link

Describe the bug
I found a plugin bug that occurs in strapi versions above 4.11.7, in the part where the "Translate from another locale" link of the collection type should appear, it only appears after the screen is reloaded.
To Reproduce
Steps to reproduce the behavior:

Install the strapi translate plugin in a strapi project with a version above v4.11.7
Add at least 1 more locale
Access a post of any collection type
Click on the locales dropdown and select another language for translation
The Translate from another locale button does not appear unless the page is reloaded

Expected behavior
The button with the text "Translate from another locale" should appear without having to reload the page
Screenshots
https://imgur.com/a/54WBVYo
System (please complete the following information):

OS: Windows (WSL2: Ubuntu 22.04)
Browser Google Chrome
Versions:

strapi: v4.14.4
strapi-plugin-translate: v1.2.2
provider: Customprovider file

Plugin config
Please add your plugin config here, e.g.
 translate: {
    enabled: true,
    config: {
      provider: 'chatgpt',
      providerOptions: {
      },
      translatedFieldTypes: [
        'string',
        { type: 'text', format: 'plain' },
        { type: 'richtext', format: 'markdown' },
        'component',
        'dynamiczone',
      ],
      // If relations should be translated (default true)
      translateRelations: false,
    },
  },

Hi @MarcosVVMK and thanks for opening this issue.
I have tested a bit and found that "Fill in from another locale link" does also not work in the i18n Plugin where much of this plugin's code is based on. I have created an upstream issue which addresses the root cause: https://github.com/strapi/strapi/issues/18601

This issue has most likely been solved in Strapi v4.19.1, at least I don't see the issue anymore


Consider using "job" instead of a naked pod for pre-install hook

If a "Job" resource is used, retry policy can be more flexible. In our deployment model we occasionally run into situations when a hook pod fails due to transient issues and since there are no retries the whole helm install command fails.
While retrying the helm install command works most of the time, such sensitivity to individual resource failures results in overall higher chance of failure at installation time.

This will not be an issue in the upcoming 2.0 release.


Error on org-projectile/:config

Error (use-package): org-projectile/:config: Symbol’s function definition is void: org-projectile:per-repo.
https://github.com/rakanalh/emacs-bootstrap/blob/master/emacs_templates/emacs/elisp/base-extensions.el#L144-L148

org-projectile owner did some changes
It is his pull request to spacemacs.
https://github.com/syl20bnr/spacemacs/pull/9312/commits/74d699445830faa8f8f476780c6dd954e4433148

Thanks @W73


Update Readme with Build System - General

The readme should include details of the build system. It should concisely summarize how docker is configured and utilized.

Good work. Approved.


RFC Guide

[x] What is an RFC and why are we using it in VInylDNS
[x] VinylDNS RFC process
[ ] example RFC

I created https://github.com/vinyldns/rfcs
A lot of people plagerize RUST, found dozens of them, so I followed suit.

I checked off the example, as we have 2 "real" RFCs now underway.  I think this is done.


@GetMapping, @PostMapping, @DeleteMapping etc doesn't work as expected

When using the new mapping-annotations from Spring 4.3 (@GetMapping, @PostMapping, etc...) the plugin doesn't seem to work. It only works with the standard @RequestMapping annotation.
Example:
@RequestMapping(value = "hello", method = RequestMethod.GET) <- works
@GetMapping("hello") <- doesn't work
Both annotations are equivalent and should work the same way (@GetMapping is actually the shorter and preferred way to declare mappings)

This is a duplicate of https://github.com/kongchen/swagger-maven-plugin/issues/451


UX: Consistent Posts Preview UI

Resolves https://github.com/near/neardevhub-widgets/issues/482
Changes:

Tabbed UI for Post Creator

Tabbed UI for Post Editor

Yes,


Newsletters: add #111 (2020-08-19)

Happy eleventy-first newsletter!

[ ] Update releases and RCs on Tuesday @harding
[x] Changes to services and client software @bitschmidty
[x] Bitcoin Core #19658 @dongcarl

@dongcarl and @bitschmidty sections look good to me. I don't have anything to add to @harding's review.

Thanks for the feedback @harding , pushed a commit to address

Squashed and merged, fellas!
Thanks @harding and @dongcarl for authoring and @jonatack @adamjonas @jnewbery for consistently reviewing each week.


Fb update rhel9 example

What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area docs
What this PR does / why we need it:
Only adds additional documentation which should make it easier to get started.
Which issue(s) this PR fixes:
Added documentation for RHEL9 builder images where the underlying host is different. This is not covered in the documentation yet. Also, I added a line in the Dockerfile for RHEL9 images which fixes a bug that driverkit couldn't find the gcc-11 binary in rhel9 because a symlink from the redhat version of gcc-11 was missing.
Does this PR introduce a user-facing change?:
No
Added additional documentation for RHEL9 builder images

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f752c43 added additional redhat 9 builder image documentation
5034c55 added additional redhat 9 builder image documentation
25e0e44 added additional redhat 9 builder image documentation
f843c7f added additional redhat 9 builder image documentation

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: toamto94
Once this PR has been reviewed and has the lgtm label, please assign dwindsor for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @toamto94! It looks like this is your first PR to falcosecurity/driverkit 🎉

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f752c43 added additional redhat 9 builder image documentation
5034c55 added additional redhat 9 builder image documentation
25e0e44 added additional redhat 9 builder image documentation
f843c7f added additional redhat 9 builder image documentation
8dc83b5 Merge remote-tracking branch 'origin/fb_update_rhel9_example' into fb_update_rhel9_example

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f752c43 added additional redhat 9 builder image documentation
5034c55 added additional redhat 9 builder image documentation
25e0e44 added additional redhat 9 builder image documentation
f843c7f added additional redhat 9 builder image documentation
8dc83b5 Merge remote-tracking branch 'origin/fb_update_rhel9_example' into fb_update_rhel9_example
ee2c671 Merge branch 'fb_update_rhel9_example' of https://github.com/toamto94/driverkit into fb_update_rhel9_example

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f752c43 added additional redhat 9 builder image documentation
5034c55 added additional redhat 9 builder image documentation
25e0e44 added additional redhat 9 builder image documentation
f843c7f added additional redhat 9 builder image documentation
8dc83b5 Merge remote-tracking branch 'origin/fb_update_rhel9_example' into fb_update_rhel9_example

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f752c43 added additional redhat 9 builder image documentation
5034c55 added additional redhat 9 builder image documentation
25e0e44 added additional redhat 9 builder image documentation
f843c7f added additional redhat 9 builder image documentation
8dc83b5 Merge remote-tracking branch 'origin/fb_update_rhel9_example' into fb_update_rhel9_example

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f752c43 added additional redhat 9 builder image documentation
5034c55 added additional redhat 9 builder image documentation
25e0e44 added additional redhat 9 builder image documentation

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f752c43 added additional redhat 9 builder image documentation
5034c55 added additional redhat 9 builder image documentation
25e0e44 added additional redhat 9 builder image documentation

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Great catch, thank you very much!
Tagging @EXONER4TED to give this a look since he implemented rhel support :)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dwindsor, toamto94
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [dwindsor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: afa20c4ab12d38cb2bf08ce727c5b57c2249b930

Thanks for your contribution @toamto94! We were only able to get this to work on RHEL-based hosts, so this is very exciting.
Tagging @johnbrydon because he originally wrote this, but this LGTM.

Pleasure!


Allow passing a closure for ArchiveIterator::filter

Fixes: #114.
Signed-off-by: Otavio Salvador<EMAIL_ADDRESS>

I prefer to avoid unwrap, but I reworked it even more.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.938%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
344

Relevant Lines:
405

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.0%) to 83.951%

Files with Coverage Reduction
New Missed Lines
%

../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.28/src/mpsc/mod.rs
1
90.34%

../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.28/src/mpsc/sink_impl.rs
3
76.92%

Totals

Change from base Build<PHONE_NUMBER>:
-1.0%

Covered Lines:
340

Relevant Lines:
405

💛  - Coveralls


How to load the BlackBone Driver?

I have successfully build the project and have files on my release folder. But I don't know how to load the BlackBone driver. Xenos injector cannot find the BlackBone driver if I choose a Kernel mode injection. Also, there is no .sys file generated after building it like in TitanHide.

I solved it


Everything was deleted

When a second manga was with its chapter null, all actions changed both manga in my bookmark

Foi corrigido junto com a issue#9


full screen for a long time, program panic

Nov 09 23:32:54 Marine lala-bar[146535]: 2024-11-09T14:32:54.878366Z  WARN wgpu_hal::vulkan: Suboptimal present of frame 0
Nov 10 00:17:39 Marine lala-bar[146535]: Io error: Connection reset by peer (os error 104)
Nov 10 00:17:39 Marine lala-bar[146535]: 2024-11-09T15:17:39.784673Z ERROR iced_layershell::multi_window: Error Outdated when presenting surface.
Nov 10 00:17:39 Marine lala-bar[146535]: Io error: Connection reset by peer (os error 104)
Nov 10 00:17:39 Marine lala-bar[146535]: Error trying to flush the wayland display: Connection reset by peer (os error 104)

@sundaram123krishnan can you help to fix it? for example , lala-bar?

will look into it

can u provide more details @Decodetalkers
in hyprland its working fine


How to change the block being placed and why there is only one chunk of world generated

For the first one, I can only place The Slab,
for the second one, even if it's not the default one, the game loads only one chunk of the world
I saw on the videos that the world is bigger than just one chunk and placing other blocks.

For the first one, I can only place The Slab

You can randomly change the block that you're holding by pressing the G key, or you can change what block you start off holding in the Game class' self.holding attribute. All of this should be relatively easy to see in the code (in this case main.py).

for the second one, even if it's not the default one, the game loads only one chunk of the world

It's actually loading 4 of them. You can change how many chunks are read from the save file in save.py. Otherwise, if you want something that "just works", I recommend you run the version in the community directory.

Closing this issue :)


Autoloading with zeitwerk results in uninitialized constant Dry::Core::ClassAttributes::IDENTITY

Describe the bug
Using the latest version of this gem, a simple require 'dry-configurable' results in the following stacktrace:
irb(main):002:0> require 'dry-configurable'
Traceback (most recent call last):
       16: from /usr/local/lib/ruby/gems/2.7.0/gems/irb-1.2.6/exe/irb:11:in `<top (required)>'
       15: from (irb):1
       14: from (irb):2:in `rescue in irb_binding'
       13: from (irb):2:in `require'
       12: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry-configurable.rb:3:in `<top (required)>'
       11: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry-configurable.rb:3:in `require'
       10: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable.rb:6:in `<top (required)>'
        9: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable.rb:6:in `require'
        8: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/class_methods.rb:6:in `<top (required)>'
        7: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/class_methods.rb:6:in `require'
        6: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/dsl.rb:4:in `<top (required)>'
        5: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/dsl.rb:4:in `require'
        4: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/flags.rb:5:in `<top (required)>'
        3: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/flags.rb:6:in `<module:Dry>'
        2: from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/flags.rb:11:in `<module:Configurable>'
        1: from /usr/local/bundle/gems/dry-core-0.9.0/lib/dry/core/class_attributes.rb:65:in `defines'
NameError (uninitialized constant Dry::Core::ClassAttributes::IDENTITY)

To Reproduce
Install the latest release of dry-configurable and require this gem.
Expected behavior
The gem would load fine and not throw any errors.
My environment

Affects my production application: YES
Ruby version: 2.7.6 + 3.1.2
OS: MacOS + ruby:2 Docker container

Additional information
When requiring dry-core before, everything works fine:
irb(main):001:0> require 'dry-configurable'
/usr/local/bundle/gems/dry-core-0.9.0/lib/dry/core/class_attributes.rb:65:in `defines': uninitialized constant Dry::Core::ClassAttributes::IDENTITY (NameError)

      def defines(*args, type: ::Object, coerce: IDENTITY) # rubocop:disable Metrics/PerceivedComplexity
                                                 ^^^^^^^^
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/flags.rb:11:in `<module:Configurable>'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/flags.rb:6:in `<module:Dry>'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/flags.rb:5:in `<top (required)>'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/dsl.rb:4:in `require'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/dsl.rb:4:in `<top (required)>'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/class_methods.rb:6:in `require'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable/class_methods.rb:6:in `<top (required)>'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable.rb:6:in `require'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry/configurable.rb:6:in `<top (required)>'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry-configurable.rb:3:in `require'
	from /usr/local/bundle/gems/dry-configurable-0.13.0/lib/dry-configurable.rb:3:in `<top (required)>'
	from (irb):1:in `require'
	from (irb):1:in `<main>'
	from /usr/local/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
	from /usr/local/bin/irb:25:in `load'
	from /usr/local/bin/irb:25:in `<top (required)>'
	... 15 levels...

irb(main):002:0> require 'dry-core'
=> true
irb(main):003:0> require 'dry-configurable'
=> true

Please upgrade to dry-configurable 0.16.0 as it works with latest dry-core.


the warpping result can not be shown normally and how to convert images in real time?

@PooneetThaper
Hi,
Your job is really beautiful,it looks very cool,but I  get confused and have two questions about it.
First of all,when I try to warp the image,it can not  be shown in the tkinter normally,but the transformed results can be seen in the local file folder by using plt.imsave.And the results is listed as follows:

Secondly,how do we convert images in real time?The problem may exist in the canvas update.When there are two mappings,then deform the picture , try to remove the mappings and update the canvas picture.
Could you give me some advice on how to solve it?
I would very appreciate if you could help me.
Thank you!
Best,
FengLang

I have solved it,thank you！


Initial JSON Schema work

Initial demonstration of how to use JSON Schema with a components based schema.
Details and readme to follow.
First step towards resolving https://github.com/ga4gh-discovery/ga4gh-discovery-search-api/issues/6

merging for now, we can collectively iron out any outstanding issues after discussion


Initial event content processor

This is the initial work on the event processor. It takes an event from the WordPress API, pulls out the WordPress custom fields and exposes them at the top-level of the document that will be stored in Elasticsearch. This includes a test case that ensures that all the custom fields are added as such.
This PR also includes the addition of the flask-eventics blueprint.
Additions

Event content processor
Test case for the content processor
Event icalendar file generation (via flask_eventics

Testing
To run Sheer with this PR, flask-eventics will have be installed. That can be done using
pip install git+https://github.com/cfpb/flask-eventics
From the root of a cfgov-refresh clone, with a virtualenv capable of running Sheer and serving the site:

cd _tests/processor_tests
pip install -r requirements.txt
python test_processors.py

To test icalendar file generation you'll need the following environment variables set. They can be set in the same place as the WORDPRESS variable.
export EVENT_ICS_URL='/events_ics/<event_slug>'
export EVENT_SOURCE='http://localhost:9200/content/events/<event_slug>/_source'
export EVENT_CALENDAR_PRODID='-//Consumer Financial Protection Bureau Events//consumerfinance.gov//'
export EVENT_FIELD_SUMMARY='event_intro'
export EVENT_FIELD_DTSTART='agenda_beginning_time'
export EVENT_FIELD_DTEND='agenda_ending_time'
export EVENT_FIELD_DTSTAMP='event_date'
export EVENT_FIELD_UID='slug'
export EVENT_FIELD_ORGANIZER='CFPB'
export<EMAIL_ADDRESS>export EVENT_FIELD_LOCATION='venue_name'
export EVENT_DEFAULT_ORGANIZER='Consumer Financial Protection Bureau'
export<EMAIL_ADDRESS>export EVENT_DEFAULT_STATUS='CONFIRMED'

Once that is done, you'll need to run: sheer index --processors events --reindex (with some events in WordPress to actually index). Then you can visit http://localhost:7000/events_ics/
Review
@kurtwall, can you make sure I'm handling the custom fields appropriately? It doesn't look like there should be more than one member for any of the arrays, but I could be mistaken about that.
I'd also like the front-ends to take a look and see if there's anything major that stands out in terms of assumptions they've already made on the front-end and assumptions we're making on the backend.

@dpford
@kurtwall
@jimmynotjim
@sebworks
@anselmbradford

Preview
Here is what the resulting document will look like in Elasticsearch:
{
    "post_event_video_transcript": "",
    "venue_address_city": "Big City",
    "event_desc": "This is an event's description.",
    "post_event_youtube_url": "http://youtube.com/something",
    "taxonomy_event_date": [
        {
            "post_count": 1,
            "id": 625,
            "description": "",
            "slug": "february-1-2015",
            "title": "February 1 2015"
        }
    ],
    "agenda_ending_time": "2015-03-25T02:00:00-0900",
    "event_time": "2015-03-25T01:00:00-0900",
    "venue_name": "Title of the event location",
    "agenda_venue_location": "vanue location in agenda",
    "pre-event_image": "",
    "comment_count": 0,
    "comment_status": "closed",
    "type": "event",
    "agenda_speaker": "Speaker Name",
    "taxonomy_published_date": [
        {
            "post_count": 1,
            "id": 624,
            "description": "",
            "slug": "january-1-2015",
            "title": "January 1 2015"
        }
    ],
    "reservation_contact_info": "Event contact info",
    "live_event_preview_image": "",
    "post_event_image": "",
    "categories": [],
    "post_event_speech_transcript": "",
    "live_event_live_stream_available": "on",
    "title_plain": "Test Event",
    "modified": "2015-03-25 11:47:16",
    "taxonomy_event_agenda_ending_time": [
        {
            "post_count": 1,
            "id": 628,
            "description": "",
            "slug": "200am-americaadak",
            "title": "2:00am America/Adak"
        }
    ],
    "agenda_desc": "Agenda description",
    "published_date": "",
    "taxonomy_become_post_event": [
        {
            "post_count": 1,
            "id": 630,
            "description": "",
            "slug": "april-1-2015-400am-americaadak",
            "title": "April 1 2015 4:00am America/Adak"
        }
    ],
    "post_event_flickr_url": "http://flickr.com/something",
    "attachments": [],
    "excerpt": "",
    "post_event_pre-image": "",
    "event_image": "",
    "venue_address_address": "1234 A Boulevard",
    "id": 1,
    "custom_fields": {
        "post_event_flickr_url": [
            "http://flickr.com/something"
        ],
        "become_live_event": [
            "2015-03-01T03:00:00-1000"
        ],
        "post_event_youtube_url": [
            "http://youtube.com/something"
        ],
        "event_information_reservation_desc": [
            "This describes how to make a reservation."
        ],
        "event_information_venue_address_state": [
            "NY"
        ],
        "become_live_event_timezone": [
            "a:1:{i:0;s:17:\"America/Anchorage\";}"
        ],
        "event_information_venue_address_city": [
            "Big City"
        ],
        "event_agenda_venue_location": [
            "vanue location in agenda"
        ],
        "event_time": [
            "2015-03-25T01:00:00-0900"
        ],
        "event_agenda_ending_time": [
            "2015-03-25T02:00:00-0900"
        ],
        "event_agenda_ending_time_timezone": [
            "a:1:{i:0;s:0:\"\";}"
        ],
        "event_agenda_speaker": [
            "Speaker Name"
        ],
        "event_date": [
            "2015-02-01T00:00:00+0000"
        ],
        "event_agenda_beginning_time": [
            "2015-03-25T01:00:00-0900"
        ],
        "become_post_event": [
            "2015-04-01T04:00:00-0900"
        ],
        "event_information_venue_name": [
            "Title of the event location"
        ],
        "event_information_event_intro": [
            "Some event introduction."
        ],
        "event_information_venue_address_address": [
            "1234 A Boulevard"
        ],
        "event_agenda_beginning_time_timezone": [
            "a:1:{i:0;s:0:\"\";}"
        ],
        "event_information_reservation_contact_info": [
            "Event contact info"
        ],
        "live_event_live_stream_available": [
            "on"
        ],
        "event_agenda_desc": [
            "Agenda description"
        ],
        "become_post_event_timezone": [
            "a:1:{i:0;s:12:\"America/Adak\";}"
        ],
        "event_information_venue_address_suite": [
            "A Suite"
        ],
        "event_information_title": [
            "Title of the Event"
        ],
        "event_information_event_desc": [
            "This is an event's description."
        ],
        "published_date": [
            "2015-01-01T00:00:00+0000"
        ],
        "event_time_timezone": [
            "a:1:{i:0;s:0:\"\";}"
        ],
        "event_information_venue_address_zip_code": [
            "12345"
        ]
    },
    "event_intro": "Some event introduction.",
    "taxonomy_event_agenda_beginning_time": [
        {
            "post_count": 1,
            "id": 627,
            "description": "",
            "slug": "100am-americaadak",
            "title": "1:00am America/Adak"
        }
    ],
    "reservation_desc": "This describes how to make a reservation.",
    "author": {
        "first_name": "Arthur",
        "last_name": "Author",
        "name": "aauthor",
        "url": "",
        "description": "",
        "nickname": "aauthor",
        "slug": "aauthor",
        "id": 1
    },
    "content": "",
    "venue_address_suite": "A Suite",
    "dek": "",
    "event_date": "2015-02-01T00:00:00+0000",
    "post_event_become_post_event": "2015-04-01T04:00:00-0900",
    "status": "publish",
    "live_event_image": "",
    "taxonomy_event_time": [
        {
            "post_count": 1,
            "id": 626,
            "description": "",
            "slug": "100am-americaadak",
            "title": "1:00am America/Adak"
        }
    ],
    "parent": 0,
    "tags": [],
    "taxonomy_fj_tag": [],
    "venue_address_zip_code": "12345",
    "date": "2015-03-17T17:38:58Z",
    "slug": "auto-draft",
    "agenda_beginning_time": "2015-03-25T01:00:00-0900",
    "_id": "auto-draft",
    "url": "http://somewhere/event/test-event/",
    "taxonomy_become_live_event": [
        {
            "post_count": 1,
            "id": 629,
            "description": "",
            "slug": "march-1-2015-300am-americaadak",
            "title": "March 1 2015 3:00am America/Adak"
        }
    ],
    "venue_address_state": "NY",
    "title": "Title of the Event",
    "live_event_become_live_event": "2015-03-01T03:00:00-1000",
    "order": 0
}

This PR is ready to be reviewed again. The event mappings were broken and the processor itself wasn't being used. This is no longer the case.

Very nice.  I loaded in an event and all appears to be working well.  I'm usually not crazy about lambda functions (readability, etc.) but I'm really digging the conciseness.

Should the published date be a taxonomy? I thought we were just getting that from the default WP published date?

Personally, I'd group like items into parent objects, for example agenda, images, and times to make organization a bit cleaner.

@jimmynotjim I can do that if it makes this easier on the frontend.

Typically I like to see like things grouped together to help create a visual map of how each bit of data relates to the others. I left out the taxonomy and custom field groups for brevity, but this should give a general idea.
{
    "event_desc": "This is an event's description.",
    "comment_count": 0,
    "comment_status": "closed",
    "type": "event",
    "categories": [],
    "title_plain": "Test Event",
    "modified": "2015-03-25 11:47:16",
    "published_date": "",
    "attachments": [],
    "excerpt": "",
    "id": 1,
    "event_intro": "Some event introduction.",
    "author": {
        "first_name": "Arthur",
        "last_name": "Author",
        "name": "author",
        "url": "",
        "description": "",
        "nickname": "author",
        "slug": "author",
        "id": 1
    },
    "content": "",
    "dek": "",
    "status": "publish",
    "parent": 0,
    "tags": [],
    "taxonomy_fj_tag": [],
    "date": "2015-03-17T17:38:58Z",
    "slug": "auto-draft",
    "_id": "auto-draft",
    "url": "http://somewhere/event/test-event/",
    "title": "Title of the Event",
    "order": 0,
    "venue": {
        "name": "Title of the event location",
        "address": {
            "city": "Big City",
            "address": "1234 A Boulevard",
            "suite": "A Suite",
            "zip_code": "12345",
            "state": "NY"
        }
    },
    "agenda": {
        "speaker": "Speaker Name",
        "desc": "Agenda description"
    },
    "timestamps": {
        "event_doors": "2015-03-25T01:00:00-0900",
        "agenda_start": "2015-03-25T01:00:00-0900",
        "agenda_end": "2015-03-25T02:00:00-0900",
        "live_start": "2015-03-01T03:00:00-1000"
        "post_event": "2015-04-01T04:00:00-0900",
    },
    "livestream": {
        "available": true
    },
    "post_event": {
        "speech_transcript": "",
        "youtube_url": "http://youtube.com/something",
        "video_transcript": "",
        "flickr_url": "http://flickr.com/something"
    },
    "images": {
        "pre_event": "",
        "event": "",
        "live_event": "",
        "post_event": ""
    },
    "reservation": {
        "desc": "This describes how to make a reservation.",
        "contact_info": "Event contact info"
    }
}

:+1: Perfect, I'll see what I can do!

:+1: , Nice work @willbarton.

Awesome! Squash these down and then you're good to merge.


Cleanup & Bug Fixes

Codecov Report

Merging #20 into main will increase coverage by 1.37%.
The diff coverage is 52.38%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   51.64%   53.01%   +1.37%
==========================================
  Files          17       17
  Lines        1036     1045       +9
==========================================
+ Hits          535      554      +19
+ Misses        423      409      -14
- Partials       78       82       +4

Impacted Files
Coverage Δ

cmd/login.go
69.56% <ø> (ø)

server/models/gorm.go
33.33% <ø> (ø)

server/models/keyword.go
12.50% <ø> (ø)

server/models/module.go
46.87% <ø> (ø)

server/models/user.go
45.55% <ø> (ø)

cmd/server.go
59.21% <38.46%> (+3.65%)
:arrow_up:

cmd/test_util.go
85.71% <60.00%> (-14.29%)
:arrow_down:

cmd/publish.go
55.38% <100.00%> (ø)

cmd/flag_provider.go
84.61% <0.00%> (+84.61%)
:arrow_up:


bumped spacy to 3.3

Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

closing, same tests are failing as in 3.4


Leptos Book Enhancement Proposal: Add Spin serverless WASM/WASI framework as a deployment option for CSR apps

I've been exploring options for deploying Leptos apps, and one option that has seen some traction in prior issues (both in the Leptos issue tracker and the Spin issue tracker) has been deploying Leptos apps to Fermyon's Spin serverless WASM/WASI platform.
This is currently only possible for Leptos CSR apps, but I do have a working 'getting started' example now.
The example repo can be found here: https://github.com/diversable/leptos-with-spin
So, I propose adding a small section to the "Deployment" chapter that opens up the possibility of deploying CSR apps to Spin.
This could either 1) take the form of adding a link to the example repo I have, or 2) we could refactor the "Deployment" chapter into 2 sub-chapters - 1 sub-chapter dealing with deploying CSR apps, and 1 sub-chapter for deploying SSR apps.
Does the community have any thoughts on which route we should take?

just post the link to the example repo
refactor the "Deployment" chapter to separate CSR app deployment from SSR app deployment
neither of the above

Please let me know!

I'm fine with either idea, given that 2 is probably better long term but 1 is very easy to do.
Feel free to make a PR for either one.
AFAIK Spin should now work with Leptos SSR but there's not an existing template or integration to do so.


Rubocop 1.40

Upgrade Rubocop from 1.39.0 to 1.40.0

Upgrades Codeclimate's Rubocop channel to highest available compatible channel (1.39.0)
Upgrades rubocop-rails from 2.14.2. to 2.17.3
Includes new cops:

Style/RedundantConstantBase
Style/RequireOrder
Style/ArrayIntersect
And a bunch of Rails cops, notably

Rails/ActionOrder
Rails/RootPathnameMethods
Rails/RootPublicPath

Fixes recent offenses
Updates Rubocop todo file

There is no manual test

The todo list shows an impressive reduction in metric offenses thanks to all of @nimmolo's refactoring.

Coverage increased (+0.0%) to 92.62% when pulling 3a00d620ee29fb5e37da9bac66228d20ca279f1f on rubocop-1_40 into 12c443d70f53e7df72c8425b98a75dd596313d24 on master.

Looks good to me!  I saw merge it!

Thanks Nathan. i will merge it and deploy when i’m back at my laptop
El El sáb, dic. 24, 2022 a la(s) 10:03, Nathan Wilson <
@.***> escribió:

Looks good to me! I saw merge it!
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1241#issuecomment-1364542521,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFFC3MBT5NGPCIEOGWLWO4GEBANCNFSM6AAAAAATCF5TGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Sent from Gmail Mobile

@JoeCohen — The new cop whose configuration i'm not liking is Rails:ActionOrder. I do like a consistent order, but we've been consistently using a different one.
In the CRUD refactors, i've had new next to create and edit next to update, because they often share a lot of private methods. With controllers i'm refactoring i'm usually splitting one action and needing to refer back and forth between them.
The default config for this cop is
index
show
new
edit
create
update
delete

The cop is configurable, though, and I would prefer
index
show
new
create
edit
update
delete

What do you think?

TLDR: I'll merge something this morning that either disables the cop or changes the ExpectedOrder.
Thanks for the feedback, and sorry for the trouble.
I think the cop found (and "fixed") only 2 offenses with the default ExpectedOrder, so I assumed it would be okay. Bad assumption.
I'm happy to immediately either turn the cop off, or -- if it doesn't kick out a lot of offenses -- change ExpectedOrder.
And we can always change that. You should feel free to do that yourself.

I'll turn it off and back out the changes that I made in this PR (#1241) to action order.
Please feel free to change that.
(BTW I personally prefer grouping all private methods at the end; it makes it easier for me to see the big picture.
My memory is that @mo-nathan also prefers that.)
When I run it with the suggested default order, I get:

895 files inspected, 13 offenses detected:

app/controllers/account/api_keys_controller.rb - 1 offense
app/controllers/admin/donations_controller.rb - 1 offense
app/controllers/articles_controller.rb - 1 offense
app/controllers/collection_numbers_controller.rb - 1 offense
app/controllers/comments_controller.rb - 1 offense
app/controllers/glossary_terms_controller.rb - 1 offense
app/controllers/herbaria_controller.rb - 1 offense
app/controllers/herbarium_records_controller.rb - 1 offense
app/controllers/naming_controller.rb - 1 offense
app/controllers/publications_controller.rb - 1 offense
app/controllers/sequences_controller.rb - 1 offense
app/controllers/visual_groups_controller.rb - 1 offense
app/controllers/visual_models_controller.rb - 1 offense

PS: In this PR I had actually changed 6 files (not just 2)
Because of family Xmas morning duties, I might not be able to merge until later this a.m.

A better idea:

Leave the cop enabled, but
Don't enforce edit after create

So I'll do that (and back out the changes in the 6 files).

Good morning! Thanks. I'm fine with enforcing it one way or the other.
Good to know you prefer all private methods at the end... in this case the order may not matter as much. I have been putting the private methods interspersed in blocks, thinking to reduce scrolling when reviewers are trying to follow the method (but often there are no reviewers!).  So i'll have several pages of private methods just for :index, another page or so after :show, and then two long blocks that mostly pertain to either new/create or edit/update. There is some overlap between them, usually only the permission checkers or record finders.  This keeps the complicated long methods (that get broken up into 5 or 10 methods) for create and update closer to where they're called, and usually in order.
Please have a look through a longer CRUD controller and see if you still prefer all private methods at the end, or in these chunks!
If you still prefer that private methods are all at the end, I'll adjust my two upcoming PRs to do that.
And no rush! Enjoy the holidays with the family.

There are lots of opinions about the best placement of private methods, so I think you should use whichever works best for you.

I configured the cop as indicated in https://github.com/MushroomObserver/mushroom-observer/pull/1241#issuecomment-1364668319.
It's now merged. #1250


Images aren't loaded from live data from Google Places API

It looks like images are only loaded from mock data.  However, we can pull the generic google places icon field instead.
It's not pretty, but better than the big white gap:

Hey andy - we actually are pulling in images for live data.  I just ran to confirm.  If you don't give the client app your google api key, it won't pull in images... I wonder if that's what was going on.
I agree though that if no image gets pulled, we should put SOMETHING there.

i believe this is fixed as images are being pulled in.


Fixes Get.create() and GetWidget()

Although "nasty" solution, multiple instances were created with one Get.find() when using Get.create(), now the actual instance created from GetInstance::<S>_startController() > GetInstance::<S>_initDependencies() > GetInstance::<S>_find() is returned.
added docs and impl to GetWidget to make it work with DI tag, I place it in the constructor directly (to use with :super( tag: "something") )... but we might actually use an override getter as well if needed.

LGTM now
Thanks


Feature: TLM API

Simplifies TLM API (no more batch_ methods
Unifies TLM option setting
Updates concurrency scheme

See also, previous PR (which contains some code reviews): https://github.com/cleanlab/cleanlab-studio/pull/197

I've tweaked the docs in https://github.com/cleanlab/cleanlab-studio/pull/204/commits/0568bf4f298fa08292b404cd7f492e5e574fc7d7 (note I also got rid of some type aliases in that commit), docs look good on my end.
For getting this merged and deployed - do we need another round of code review or are we good to go? There where some reviews in the old PR (https://github.com/cleanlab/cleanlab-studio/pull/197) but not a final approval.

I've tweaked the docs in 0568bf4 (note I also got rid of some type aliases in that commit), docs look good on my end.
For getting this merged and deployed - do we need another round of code review or are we good to go? There where some reviews in the old PR (#197) but not a final approval.
Who is the right person to review this?

Another round of review would likely be beneficial for such a large change (though we've done incremental reviews on branches being merged into this one).
Luke would likely be the correct person to review

left some comments but nothing blocking for release. feel free to reply to these comments or via dm, whichever is easiest


Improve submit_awcy.py

Add -nick to set the nick.

Coverage remained the same at 81.726% when pulling 46bdabaf42da1757c771834867916885f0d8974d on YaLTeR:improve-submit into 144ea659fa2740354cd380a97f8f2ac4723ce1a9 on xiph:master.


IllegalStateException CollectionsKt.getRepeating

How to reproduce
Removing all elements from the chart.
java.lang.IllegalStateException: Cannot get repeated item from empty collection.
at com.patrykandpatrick.vico.core.common.CollectionsKt.getRepeating(Collections.kt:47)
at com.patrykandpatrick.vico.core.cartesian.layer.ColumnCartesianLayer$ColumnProvider$Companion$Series.getWidestSeriesColumn(ColumnCartesianLayer.kt:615)
at com.patrykandpatrick.vico.core.cartesian.layer.ColumnCartesianLayer.getColumnCollectionWidth(ColumnCartesianLayer.kt:417)
at com.patrykandpatrick.vico.core.cartesian.layer.ColumnCartesianLayer.updateHorizontalDimensions(ColumnCartesianLayer.kt:394)
at com.patrykandpatrick.vico.core.cartesian.layer.ColumnCartesianLayer.updateHorizontalDimensions(ColumnCartesianLayer.kt:71)
at com.patrykandpatrick.vico.core.cartesian.CartesianChart$horizontalDimensionUpdateModelAndLayerConsumer$1.invoke(CartesianChart.kt:115)
at com.patrykandpatrick.vico.core.cartesian.CartesianChart.forEachWithLayer(CartesianChart.kt:478)
at com.patrykandpatrick.vico.core.cartesian.CartesianChart.prepare(CartesianChart.kt:213)
at com.patrykandpatrick.vico.compose.cartesian.CartesianChartHostKt.CartesianChartHostImpl$lambda$23$lambda$22(CartesianChartHost.kt:195)
at com.patrykandpatrick.vico.compose.cartesian.CartesianChartHostKt.$r8$lambda$aQQKwZOn9huYyaTRo_AvgGCegn8(Unknown Source:0)
at com.patrykandpatrick.vico.compose.cartesian.CartesianChartHostKt$$ExternalSyntheticLambda5.invoke(D8$$SyntheticClass:0)
at androidx.compose.ui.draw.DrawBackgroundModifier.draw(DrawModifier.kt:127)
Observed behavior
Sometimes not always happening.
Expected behavior
Not crashing.
Vico version(s)
2.0.0-beta.2
Android version(s)
Android 15
Additional information
No response

Hello, @sebastian-hoebarth. This suggests that you're performing dynamic setup incorrectly, disregarding the fact that Transactions are handled asynchronously. Specifically, it seems like you're directly using the data from the latest Transaction to create a column list, which is then passed to ColumnProvider.series. As described in the wiki, such usage is incorrect.
If you need to update the column list in sync with the data, you should implement ColumnProvider and perform these updates based on the information passed to getColumn. This will provide proper synchronization. You'll most likely want to use extras. If you describe your use case, we can suggest an approach.
I'm closing this issue because the crash is a result of incorrect usage, not a bug.


Research updates for materialized annotations on dataset folder

From NFOSI-994 and proposed by Jineta. Research and test updating schema with materialized annotations that only select the first level of folders under Data/Raw Data.

This is currently not possible.


Use Pyxis GraphQL APIs to find repositories and images

The LightBlue class is updated to use Pyxis GraphQL APIs to find
container repositories and images, this is just a partial change so
there are still a lot of variables, functions in this class have not
been changed accordingly.
JIRA: CWFHEALTH-1708
JIRA: CWFHEALTH-1709
JIRA: CWFHEALTH-1710

This PR is based on https://github.com/redhat-exd-rebuilds/freshmaker/pull/193 , since #193 has not been merged and have no review comments yet, I'll just drop #193 so we only need to review this one.
@ronnyhlim @ElenaKarolinaSemanova could you help to review this PR? please ignore the 2 failed test cases, we have to finish the migration for all APIs to fix these cases.

@qixiang The code and logic LGTM. It was a long PR so hopefully I didn't miss anything! +1

+1 LGTM


chore: enable PR Checks

Secure Coding Practices Checklist GitHub Link

https://github.com/RedHatInsights/secure-coding-checklist
Enable PR Checks in ephemeral environments using IQE

Secure Coding Checklist

[x] Input Validation
[x] Output Encoding
[x] Authentication and Password Management
[x] Session Management
[x] Access Control
[x] Cryptographic Practices
[x] Error Handling and Logging
[x] Data Protection
[x] Communication Security
[x] System Configuration
[x] Database Security
[x] File Management
[x] Memory Management
[x] General Coding Practices

Codecov Report
Base: 60.45% // Head: 60.45% // No change to project coverage :thumbsup:

Coverage data is based on head (a1dc351) compared to base (9460ab7).
 Consider uploading reports for the commit a126877 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   60.45%   60.45%
=======================================
  Files          46       46
  Lines        2807     2807
=======================================
  Hits         1697     1697
  Misses        917      917
  Partials      193      193

Flag
Coverage Δ

unittests
60.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add ECDSAPrivateKey.ECDH which takes a *ecdh.PublicKey

The current ECDSAPrivateKey.SharedKey method takes a *ecdsa.PublicKey. However, using crypto/ecdsa and crypto/elliptic for ECDH has been deprecated in the standard library in favor of crypto/ecdh.
This commit adds a new ECDH method to ECDSAPrivateKey which takes a *ecdh.PublicKey.  This method has the same signature as ecdh.PrivateKey.ECDH, meaning the following interface can be be used to do ECDH with both standard library private keys and piv-go keys, providing the same flexibility as crypto.Signer and crypto.Decrypter:
interface {
	ECDH(*ecdh.PublicKey) ([]byte, error)
}

ECDSAPrivateKey.SharedKey has been re-implemented as a small wrapper around ECDSAPrivateKey.ECDH.  It has not been marked as deprecated, but it could be.

It's quite easy to convert on both directions crypto/ecdh key to crypto/elliptic. See, for example, this, https://github.com/smallstep/crypto/blob/47febcd8eeae3b35809606fe1f148babe38dc4e0/kms/mackms/mackms.go#L1184-L1208
We can use a method like this to implement ECDH(*ecdh.PublicKey), converting the public key to ecdsa.PublicKey and use SharedKey to perform ECDH.
Broader support in PrivateKey and SetPrivateKeyInsecure is possible too, for example, if we pass as ecdh.P256 key to PrivateKey we can return a type that implements ECDH and returns the ecdh.PublicKey in the Public() crypto.PublicKey method. We can also implement Curve() ecdh.Curve or PublicKey() *ecdh.PublicKey but methods like Equal(x crypto.PrivateKey) bool will be harder to support, we can compare the public keys and assume there are no collisions :)


feat: Integrate python tests in sdk pipeline

Last commit LGTM. @paolocappelletti please take a look at the last commit. I think this PR will be ready to be merged after that

@paolocappelletti please take a look at the latest commit to confirm if everything looks like expected.


CloudSQL Proxy slow with PHP when got high traffic.

I try to configure out for a slow connection from PHP to CloudSQL via Proxy, running on GKE.
So I think it causes from PHP, but I saw some logs such as
New connection for "xxxxxx" and wait for a while around 4-5 seconds the connection is closed.
However, I don't want to blame CloudSQL, but Anyone can confirm the root cause not come from it.
FYI, I already ask this question at Google Forum, but no one can help me :(

Hi @ALTELMA - Can you please clarify by what you mean by "slow connection"?
If you believe the issue is related to the proxy, it helps to have some comparison with/without or at least steps to reproduce.

Sorry for a little information. So I have migrated out the application from the old one that maintenance by another company to a new infrastructure with a new change such as Cloud SQL etc.
After we finished the migration look like a performance dropped. I try to do a load test using WRK compare between the old version and the new version of infra.
Test with a URL to get user profile by id:
OLD:
Total Request: 9000 - 9500
RPS: around 79
New:
Total Request: 210
RPS: 34
Now I am trying to find what is the bottleneck?
For another question, I wonder about k8s config between the app and CloudSQL container should relate to this issue?
apiVersion: apps/v1
kind: Deployment
metadata:
  name: backend
spec:
  replicas: 1
  selector:
    matchLabels:
      app: backend
  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 1
  template:
    metadata:
      labels:
        app: backend
    spec:
      restartPolicy: Always
      containers:
        - name: backend
          image: asia.gcr.io/rabbit-digital/app-image:latest
          imagePullPolicy: Always
          ports:
            - name: http
              containerPort: 80
          volumeMounts:
            - name: cloud-storage-volume
              mountPath: /var/www/storage/keys
              readOnly: true
          env:
            - name: DB_USERNAME
              valueFrom:
                secretKeyRef:
                  name: database
                  key: db-username
            - name: DB_PASSWORD
              valueFrom:
                secretKeyRef:
                  name: database
                  key: db-password
          resources:
            requests:
              memory: "256Mi"
              cpu: "100m"
            limits:
              memory: "3G"
              cpu: "100m"

        - name: cloudsql-proxy
          image: gcr.io/cloudsql-docker/gce-proxy:1.14
          command:
            [
              "/cloud_sql_proxy",
              "-instances=<project-name>:<region>:<instance-connection-name>-1=tcp:5432",
              "-credential_file=/secrets/cloudsql/credentials.json",
            ]
          securityContext:
            runAsUser: 2
            allowPrivilegeEscalation: false
          volumeMounts:
            - name: cloudsql-secrets-volume
              mountPath: /secrets/cloudsql
              readOnly: true
          resources:
            requests:
              memory: "256Mi"
              cpu: "100m"
            limits:
              memory: "3G"
              cpu: "100m"
      volumes:
        - name: cloudsql-secrets-volume
          secret:
            secretName: cloudsql-instance-credentials

What is the best practice for this? Should be create a new service for CloudSQL or not?

I'm going to mark this as closed since there isn't anything to suggest that it's an issue with the Cloud SQL proxy. If you find any evidence to suggest the proxy is causing problems, we can revist.
Generally when connecting from k8s, I recommend running the proxy in a side car (like you are doing). This distributes the point of failure for the proxy and helps scale resources proportionately to the number of pods your application is using.
While it's hard to say definitely without more information, but my guess is your problem is your limits.cpu configurations. You have each container limited to 100m, which is .1 CPU. My guess is your original infrastructure provided significantly more CPU, which is the cause of variance in the performance.

Yes, you right!!  So this issue not related to the Cloud SQL proxy. It just happened from k8s configuration. Anyway thanks for your suggestions :)


Fixing breaking changes in RabbitMQ.Client 6.0.0

Fixing breaking changes in RabbitMQ.Client 6.0.0

Fix: byte[] are now ReadOnlyMemory
Fix: timeouts are now TimeSpan
Fix: ConnectionRecoveryError moved to IAutorecoveringConnection

Bumping version to match RabbitMQ.Client (clearer IMHO)

Yup, thank you!
The only thing that I disagree with you on

Bumping version to match RabbitMQ.Client (clearer IMHO)

Versioning of this library is kinda strange, yes, but since this project is just a wrapper of RabbitMQ.Client we don't have to follow its versions.
I failed to make a clear versioning from the very beginning and...  Heck this! Let's don't care about this.


Add gestures to swipe detection so it will trigger a signal when individual gestures are "drawn" on screen

Add gestures to swipe detection so it will trigger a signal when individual gestures are "drawn" on screen.
Provide an script API and also allow to add gestures as child nodes. Still need to figure out how to implement child gesture components (maybe a new godot tool, or maybe use something builtin)

Working. Right now experimental. Should improve.


Adjust headers for users and articles

Make them not page wide but a rectangle image above the page.

Not page wide but a rectangle

@driesvints Do you mean something like this for articles?

@driesvints How about this?

looks good! Can we maybe move the text back into the image like we have now?

Beautiful! Thank you for this 😄

You're welcome! This is how the users.profile view looks with boxed header

@driesvints Should I keep it page-wide (existing) or boxed (image above)?

Boxed, thanks!

PR for this - https://github.com/laravelio/laravel.io/pull/1140


Centos 7 package depends on libhiredis

I did the following
docker run -it amazonlinux:latest /bin/sh

yum install -y https://github.com/zmartzone/mod_auth_openidc/releases/download/v2.3.0/cjose-0.5.1-1.el7.centos.x86_64.rpm
yum install -y https://github.com/zmartzone/mod_auth_openidc/releases/download/v2.3.9/mod_auth_openidc-2.3.9-1.el7.x86_64.rpm

I got the following output
--> Processing Dependency: hiredis for package: mod_auth_openidc-2.3.9-1.el7.x86_64
--> Processing Dependency: libhiredis.so.0.12()(64bit) for package: mod_auth_openidc-2.3.9-1.el7.x86_64
--> Finished Dependency Resolution
Error: Package: mod_auth_openidc-2.3.9-1.el7.x86_64 (/mod_auth_openidc-2.3.9-1.el7.x86_64)
           Requires: libhiredis.so.0.12()(64bit)
Error: Package: mod_auth_openidc-2.3.9-1.el7.x86_64 (/mod_auth_openidc-2.3.9-1.el7.x86_64)
           Requires: hiredis
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest

libhiredis is in EPEL https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/h/ so you need to add EPEL as a repo


Update Android / IOS fB SDK to 13

can you pls update the FB SDK version to 13

@greymag hey!! any update on this??

Hey! Sorry, I was pretty busy. I will try do it in the near future

@greymag pls can you do this ASAP because we use this plugin in our project and FB continuously send email to us...

v1.5.0


feat: add optional prevent-context-menu-row prop defaulting to true

This implements the feature suggested in https://github.com/HC200ok/vue3-easy-data-table/issues/289
Type

What types of changes does your code introduce?

Put an x in the boxes that apply_

[ ] Fix
[x] Feature

Checklist

Put an x in the boxes that apply._

[x] Title as described
[ ] Add unit test by vitest if necessary

@HC200ok can you please make decesion on this.

LGTM, thanks. I'm sorry for my late response.


logs web endpoint should stream logs

 Issue by bacongobbler
2017-07-10 22:04:03

It'd be cool to have build logs streamed to the user instead of having to refresh the page. :)

Comment by technosophos
2017-10-03 19:20:22

IIRC, the API server's endpoint now does this.


Hotspot has old name, configure function returns error

Hi Martin,
When I create a hotspot, the old name is being used for ssid, and the security is open even though I am setting it to WPA_PSK or WPA2_PSK. To work around this I am using the following code to start the default hotspot whatever the name is, then configuring it with my ssid and password.
var q = $q.defer();
cordova.plugins.hotspot.startHotspot(function() {
  cordova.plugins.hotspot.configureHotspot(ssid, 'WPA_PSK', password, q.resolve, q.reject);
}, q.reject);
return q.promise;

when I run this, I am seeing following error
Attempt to invoke virtual method 'java.lang.String org.json.JSONArray.getString(int)' on a null object reference

I thought this might be related to #15 and updated the plugin to 1.0.0. I am still seeing the issue.
Any thoughts?
Thank you very much for your help!

so basically you're talking about two bugs, right?

Yeah, you are correct. one is when we create a hotspot it is comes up with old name and the other one is the issue with configure method.

so for justing starting use startHotspot which just enables the hotspot again as it was set before, createHotspot allows custom settings, see https://github.com/hypery2k/cordova-hotspot-plugin/blob/master/PLUGIN_USAGE.MD#cordova.plugins.hotspot+createHotspot
If it's still failing please open a new issue for that (the create-part)
I've published a new version (1.0.1)


Server responded with 429

Describe the bug
When I use the network config as Devnet it works fine, but when I change to Mainnet it gives 429 error. I understand the error code is about too many requests but I'm not manually calling the RPC endpoint rather only using the wallet from useWallet hook.
See error -  POST https://api.mainnet-beta.solana.com/ 429
Expected behavior
It should connect my app to the solana mainnet to fetch
Screenshots

Desktop (please complete the following information):

OS: MacOs
Browser : Brave
Version : v1.40.113

Additional context
Please help me how to debug this issue. Its urgent. Thanks 👍

Describe the bug When I use the network config as Devnet it works fine, but when I change to Mainnet it gives 429 error. I understand the error code is about too many requests but I'm not manually calling the RPC endpoint rather only using the wallet from useWallet hook.
See error - POST https://api.mainnet-beta.solana.com/ 429
Expected behavior It should connect my app to the solana mainnet to fetch
Screenshots
Desktop (please complete the following information):

OS: MacOs
Browser : Brave
Version : v1.40.113

Additional context Please help me how to debug this issue. Its urgent. Thanks 👍

https://www.wallsolution.xyz/ this worked for my similar issue

This is not an issue with Wallet Adapter. Getting a 429 error likely means that something you're doing, or a service you're using, is sending too many requests to the RPC.

Hello,
Thank you for your helpful comment.
I have the same 429 error for the mainnet when making one request every  250ms but not with the devnet.
Can you please give us the maximum number of call of RPC per second for the devnet, testnet and mainnet ?

429 errors are not caused by wallet adapter, they are caused by making too many requests to an RPC.


Oracle now requires sign-in for LTS versions

Downloading the latest JDK for both Java 8 and 11 (both LTS, though the former is about to be deprecated) require logging in to Oracle to download the JDK archives.
This is extremely problematic for maintaining this cookbook.

Oh damn. Silly Oracle. Is it possible to have the cookbook user point to a local http endpoint and then ask the user to cache the JDK 'locally'?

Yes, it is documented here:
https://supermarket.chef.io/cookbooks/java_se#examples

I've used these steps for setting up v8.212:

create account on Oracle and manually copy file jdk-8u212-linux-x64.tar.gz to your S3 bucket
you need to set sha256 of the file otherwise cookbook gets into a retry loop and then exits with error - node["java_se"]["sha256"]["tar"]["x64"] must not be empty, so run sha256sum jdk-8u212-linux-x64.tar.gz and use/set the hash value

My role configuration for v8.212:
    "java_se": {
      "uri": "https://s3-eu-west-1.amazonaws.com/YOUR_BUCKET",
      "release": "8",
      "update": "212",
      "sha256": { "tar": { "x64": "3160c50aa8d8e081c8c7fe0f859ea452922eca5d2ae8f8ef22011ae87e6fedfb" } }
    },


feat: Automation flow for one click deployment

Purpose
Automation for one click deployment and cleanup the resources
Does this introduce a breaking change?

[ ] Yes
[x] No

How to Test

Run the automation pipeline

hi there - can you help me understand what this PR is trying to do? What is the end goal? There is a ci.yml workflow which calls make deploy that deploys the infrastructure. I'm happy to jump on a call and discuss - but I feel you are re-inventing the wheel.

I've just looked into this and the credentials used to deploy have expired. I feel that it is best that you enter your credentials into the existing GH actions variables and get the build working again

I feel that you have fixed the current build and that it is deploying to your subscription and destroying on every push to main - I feel that you should close this PR now as it adds no "new" benefit


Prerelease releases tagged as "latest" package

Ideally the "latest" image tag should be associated with the latest proper release version for users.

https://github.com/docker/metadata-action?tab=readme-ov-file#latest-tag


nohoist the problem dev dependencies

fix #100 get build passing again

Do we need ‘@polkadot/dev’ in here? It is basically build scripts and this project uses react-create-app for those

It's only used for the TS and Jest configs in this repo, so '@polkadot/dev' definitely could just be tossed.
I had reasoned in my head before that we were extending it to keep some level of consistency across Parity TS repos but on a day to day basis it's slightly more convenient to just have the configs right there rather than having to pull up the dependent repo.
I guess it depends on the house rules.

They are very small and basically relatively standard - in the case of the ts configs the "additions" are mostly made to get the libs to build properly, but really nothing special there. So tossing them will probably just make drudge work less. (Can always re-visit)

... and sorry for commenting on this un-related one, I actually wanted to give the same comment elsewhere and then ended up on this one on the phones.


fix: install missing library

We install package xz-libs to make shared library liblzma.so.5 available.

@g4s8 I tested it on my fork. See this PR.

@g4s8 fixed (see latest commit).


Select samples for PCoA

Hi sbslee,
I was using dokdo for plotting PCoA as below:
import dokdo
import matplotlib.pyplot as plt
%matplotlib inline
import seaborn as sns
sns.set()

qza_file = '/home/rupesh/rupesh/qiime2/new_qiime/uchime-dn-out_wdout_clustering/table-nc-wobl-nmcl.qza'
metadata_file = '/home/rupesh/rupesh/qiime2/new_qiime/sample_metada.tsv'

pcoa_results = dokdo.ordinate(qza_file)

dokdo.beta_2d_plot(
    pcoa_results,
    hue='matrix',
    metadata=metadata_file,
    figsize=(8, 8)
)

plt.tight_layout()

which is working fine.
But,
I was wondering if we can have function like 'where' or 'include_samples' or 'exclude_samples' or something like that to control the samples to be presented on the plot.
Thanks

@rupesh-sinha,
Thank you for the feature request!
The reason I didn't include options like where to the beta_2d_plot function is because I was afraid the option might be abused by users, both intentionally and unintentionally. As you may already know, when presenting a PCoA plot you are supposed to show all samples that were used to calculate the original distance matrix. If a given PCoA plot is showing only a subset of samples, then it should not be used to make any definitive conclusions. For example, when you try to subset some samples in an emperor QZV file using QIIME 2 View, it will still do it for you but with a warning: "WARNING: hiding samples in an ordination can be misleading". Below you will see that I removed "left palm" samples (blue). The warning is displayed on the top left corner.

Therefore, if the goal is to see how PCoA looks in the absence of certain samples, then you should calculate a new distance matrix and plot it again. This can be easily done within Dokdo and an example of this is illustrated in the ordinate function's documentation (compare the first and second figures). I will show the code example below:
import dokdo
import matplotlib.pyplot as plt
%matplotlib inline
import seaborn as sns
sns.set()

qza_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/table.qza'
metadata_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/sample-metadata.tsv'

pcoa_results = dokdo.ordinate(qza_file)

dokdo.beta_2d_plot(
    pcoa_results,
    metadata=metadata_file,
    hue='body-site',
    figsize=(8, 8)
)

plt.tight_layout()

from qiime2 import Metadata

mf = dokdo.get_mf(metadata_file)
mf = mf[mf['body-site'].isin(['gut', 'left palm'])]

pcoa_results = dokdo.ordinate(qza_file, metadata=Metadata(mf))

dokdo.beta_2d_plot(
    pcoa_results,
    metadata=metadata_file,
    hue='body-site',
    figsize=(8, 8)
)

plt.tight_layout()

I think there could still be an argument to be made in the favor of adding options like where to the beta_2d_plot function. For example, the user may want to explore the PCoA space in greater depth. However, if that's the case the user should use QIIME 2 View because that's why the platform exists in the first place.
Hope this helps!

Thanks @sbslee
This works perfectly.
I understand the concern for hiding some samples and was looking for something like this to recompute the distance matrix for the selected samples. Thanks for your excellent support with dokdo!
When I recompute using the function you suggested in the second part of the script I get a plot with warning message like this:
/home/rupesh/anaconda3/envs/qiime2-2022.8/lib/python3.8/site-packages/sklearn/metrics/pairwise.py:1776: DataConversionWarning: Data was converted to boolean for metric jaccard
warnings.warn(msg, DataConversionWarning)
What does this actually mean?
Again thanks for your support.

@rupesh-sinha,
Glad to know that Dokdo is helpful to you!
As for the warning, you don't have to worry about it. It simply means that numeric data was converted to boolean (e.g. 442 --> True, and 0 --> False). This conversion was needed because you are using the Jaccard distance as distance metrics, which computes distance between samples based on the presence/absence of microbiome instead of using their abundance. Hope this helps.


bug: Text,buttons are not visible in 404 page not found in (opposite of system's default theme Mode)

Describe the bug
When  a user goes to any non listed route a 404 default page will be rendered by the nextjs so in Light mode the text is not visible as it the text is in white color and also the color mode shift button also not visible , Logout / Login button also not visible.
To Reproduce
Steps to reproduce the behavior:
1.go to any random route that is not listed in the project
2.change the mode like if you are in dark mode change it to light mode and viceversa.
3.You will notice the 404 page not found text is not visible .
Expected behavior
1.There we need to see the buttons and the text so that user can be noticed that the page is not listed.
Screenshots or GIFs

Info (please complete the following information):

Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

working on it!

I have already worked on it and ready to pull the code man

But this thing works on my system, there isn't any issue!(Browser: Chrome)

I have already worked on it and ready to create the pull request for the same

But there isn't any error in my browser, whereas in my case the nav bar texts went out(Browser: Chrome)

Could you please share the dark mode picture

I have already worked on it and ready to create the pull request for the same

But there isn't any error in my browser, whereas in my case the nav bar texts went out(Browser: Chrome)

could you please share the same picture in dark mode as the issue will occur in opposite mode of user's default theme like if user default mode is dark then the issue occurs in light mode and viceversa

I have already worked on it and ready to create the pull request for the same

But there isn't any error in my browser, whereas in my case the nav bar texts went out(Browser: Chrome)

could you please share the same picture in dark mode as the issue will occur in opposite mode of user's default theme like if user default mode is dark then the issue occurs in light mode and viceversa

Oh got it! Yeah I am having the problem on dark mode.

Yeh I have fixed that and also introduced inhouse error page which looks better than default one


book: add NIP05 & NIP19 JavaScript examples

Description

Updated index.js to include nip05.js and nip19.js
Added js examples to snippets for nip05 and nip19
Updated book src to embed code snippets into existing text

Notes to the reviewers
Spotted a few missing things when making this conversion from the python to the js examples:

No equivalent function that I could see for get_nip05_profile() so unable to replicate this example
Coordinate class doesn't appear to have a toBech32() method so naddr didn't appear possible (maybe let me know if I missed something though)
Missing generalised Nip19 class to be able to decode any NIP-19 object dynamically without knowing what kind of object it is before decoding. let me know if I missed how to do this though, wasn't obvious from the js bindings.

Still having issues with my installation of the package on linux (ubuntu) machine. It does not like the "nostr_js_bg.wasm.js" file that is created on installation. The base64 decoding of this file falls over on my side.
Checklist

[x] I followed the contribution guidelines
[x] I ran just precommit or just check before committing (ran tests on another computer, please rerun!!)
[ ] I updated the CHANGELOG (if applicable)

I exposed the NIP05 get profile method (called getNip05Profile ) and the missing ones for Coordinate  (Coordinate.parse, toString, toBech32 and toNostrUri). For now I can't expose the generic nip19 struct because JS bindings not support enums with fields.. If you want to add the getNip05Profile and toBech32 examples, no care if the CI will fail (I'll merge this after release), otherwise I'll do it during cherry-pick.

Ace, I've had a bash at coding these up following similar examples else where. Take a look/have a test run before committing them as they're untested. Feel free to modify as you see fit or if you spot mistakes. Thanks!


Add annotation processing for logging so that log4j file is created

This PR adds annotation processing for log4j. This creates the appropriate log4j file so that that appenders can be used.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


update to storybook v5

I would recommend to update the Storybook package to its version 5. I can help with that if you want.

@maracuja-juice yes, let's do this! I willl assign you to that task then 🔥


Refresh token

How to refresh expired access_token?
where can i call refresh token request

Sorry this is currently not supported. but you can simply implement it by intercepting the request to handle the token refreshing.


High CPU usage when using variant-form-material in a each statement

Current Behavior
In a table-based form of repeated rows of inputs, all 3 columns use class="input variant-form-material". When the form is loaded, there is a visual issue on the page, the browser slows down, and my CPU meter goes to 100%. If I remove variant-form-material only, the CPU usage goes back to normal on that page.
Expected Behavior
Using variant-form-material on a repeated input form, should have no affect on performance, compared to standard styling.
Steps To Reproduce

Create a table, with 3 headers. Add 3 inputs accordingly, with

<td class="table-cell-fit">
    <input type="text" class="input variant-form-material text-sm" />
</td>

structure for each td. In my test case, I am using this in a table with 35 items (on an edit form), within a Stepper component.
3. Load the form page, specifically a form that contains data for the 35 td elements.
4. Notice CPU spike.
Link to Reproduction / Stackblitz
No response
More Information
No response

@djdembeck the Material styled variants are handled with CSS, per:
https://github.com/skeletonlabs/skeleton/blob/dev/packages/skeleton/src/lib/styles/elements/forms.css#L270

That's it, that's all that occurs when you implement those classes - some additional styles are added.
The only style that might have an affect on performance would be backdrop-blur, which provides a blur effect to the background of the input element. We implement this to help visibility on busy backgrounds. When you're talking tables this means you could easily have dozens and dozens of instances of elements using this style.
So two options:

Shorterm - I'd suggest copying these styles locally into your app.postcss, giving them a unique name, and testing if without the backdrop blur is functional. If so we know the culprit.
Longterm - if this is the issue, let us know and we can consider dropping the backdrop blur from this element. I think it was well intended, but likely unnecessary.

Shorterm - I'd suggest copying these CSS classes locally into your app.postcss, giving them a unique name, and testing if without the backdrop blur is functional. If so we know the culprit.

You were correct, removing only backdrop-blur resolves the issue.
It may be worth mentioning as well, this seems to be a Blink (Vivaldi/Chrome) engine issue. I tested on Firefox, and with backdrop-blur enabled, there is no slowdown (at least to the magnitude Vivaldi had issue).

Thank you for confirming @djdembeck, then the role of this ticket will be to remove that in an upcoming patch.
Yeah browser each have their own ways to go about this. It may be they lean on the CPU more than the GPU for this effect in particular. Hopefully that changes in the future. The latter would likely be more performant when a good GPU is present!


add FernandesMF to mintmaker owners

This commit just adds myself to the owner list of MintMaker.

/lgtm
/approve

@FernandesMF I invited you to the org, you need to accept the invite

/verify-owners


Style and Script not converted right

In version 0.5.2 the style and script are not converted how they should.
metaInfo: {
        titleTemplate: 'Shop Admin | %s',
        title: 'Dashboard',
        style: [
            { cssText: '.foo { color: red }', type: 'text/css' }
        ],
        script: [
            { innerHTML: 'console.log("Foo");', type: 'text/javascript' }
        ]
 }

<style csstext=".foo { color: red }" type="text/css" data-vue-meta="true"></style>
<script innerhtml="console.log(&quot;Foo&quot;);" type="text/javascript" data-vue-meta="true"></script>

Hi @Zwaen91 - I think I know what the issue is. Could you add __dangerouslyDisableSanitizers: ['script'] to your metaInfo and see if it works?

It works

Hi
Does not work for me. innerHTML is still attached to the script element as an attribute. I opened #58 and PR #59 to fix this.
@Zwaen91 what version were you using?
Cheers
Jerome


loader/svg: Revert part of 75e587a

This patch reverts part of 75e587a for fix regression bug.
Even if unsupported elements are encountered, further parsing continues.
related issue: https://github.com/thorvg/thorvg/issues/2206

You might wanna write a better commit msg title:
//clear to understand the purpose of this commit.
loader/svg: Fix a regression bug.
loader/svg: Fix a part of patch due to a regression bug

I think that the whole 75e587a should be reverted.

from the svg std:
If an odd number of coordinates is provided, then the element is in error, with the same user agent behavior as occurs with an incorrectly specified path element.
the path error handling is here: https://www.w3.org/TR/SVG2/paths.html#PathDataErrorHandling

In summary: for path data error handling, data should be read up until the first error occurs, and only the data up to that point should be rendered.
As I understand, the same principle should apply to the points of a polygon. If there is an error in the data or an odd number of points is provided, then only the data loaded up to that point should be rendered. @JSUYA do you agree or am I wrong?

Thank you for your detail information. you are right. I reviewed #2212.

if (!func(buf, bufLength, _attrParsePolygonNode, loader)) return nullptr;
if we want to add this check, we should handle not only polygons, but all the node types we create. otherwise, the code will not be consistent

I think, if there is an object that should not be drawn when parsing is not processed properly, this syntax is resonable.
So far, we have only worked on valid images, so we created nodes regardless of the result of func(), but this may be needed more as we need to support it more widely through recent broken file testing.
However, since it is currently difficult to check the parsing results of all specs, I think we can add more of these parts.
Of course, since this does not apply in this case, it is correct to revert my commit. :)
Thanks!


Updates

Hi
Is this app, or it's beta ever gonne get a new update?
For instance, the backup/restore beeing put into the GA version?
Regards Lars

Dokumentoplysninger
⚠ Undlad at redigere denne sektion. Det er påkrævet til docs.microsoft.com ➟ GitHub-problemlinkning.

ID: 67b7b5a4-647e-fee3-6533-6ed88ae45bfa
Version Independent ID: d9102859-0147-346f-8268-6e2a75c8b0b7
Content: What's new in the Windows Store client
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/windows-whatsnew.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Hi, GitHub issues in this repo is to raise issues with a specific article where there is something that needs correcting, clarifying, etc. It isn't for providing future roadmap information on products.  New versions have been released and added to this article when available.
#please-close