Update test matrix to include Django 5

Update test matrix to include Django 5
Refs: #661

Django 5 doesn't support python 3.7
And it's worth dropping 3.7, though I'm happy to go that in a separate PR if you want to just exclude it from Django 5 in this one.
https://endoflife.date/python

Django 5 doesn't support python 3.7
And it's worth dropping 3.7, though I'm happy to go that in a separate PR if you want to just exclude it from Django 5 in this one.
https://endoflife.date/python

@marksweb Yep, I missed that in the exclude: anyway, Django 5.0 tests fails for something quite strange, maybe related to djangocms-picture...? I'll mark this pr as draft until I can wrap my head around this

@marksweb I'm trying to understand this: I can replicate this issue also on djangocms-picture, if I add Django 5 and CMS 4.1 to the test matrix I get the same error, django.db.utils.OperationalError: no such table: django_site.
I can only find very old issues on django-cms about this, and I don't know where to start to fix this: it looks like something is trying to access sites framework before the actual db is setup or migrated.

@protoroto I think it's an issue with Django CMS' LazyChoiceField. The parent's class implementation has changed in Django 5.0 and LazyChoiceField seems not so lazy after all.
In effect djangocms-picture tries to access the DB before the Django initialisation is finished.
I will look at it later today.

@protoroto Looks good! 👍


Visit admin page command

Description of the Change

Adds new command visitAdminPage
Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my change.
[x] All new and existing tests passed.

Changelog Entry
Added - visitAdminPage command

Credits

Props @cadic

@dinhtungdu in this case, the visitAdminPage command become pointless, since it will not differ from the existing visit. I suppose this PR could be closed then.

@cadic Rethink about this PR, I think we can do conditional testing here. The reason I don't want to do more than one task for a command is to avoid conditional testing which leads to flaky tests. However, we get some good reasons to apply the condition testing for this command (and maybe also the login command):

We're 100% sure about the state of DOM in this case: we know how it looks like if the users are logged in or not.
It saves developers many keystrokes.

So I'm sorry for my former incomplete review. Reopening this PR.

@dinhtungdu with conditional testing approach, I see the following scenario:

Attempt to visit admin page
If not logged in yet, the login form will appear
Use login command to log in
After login, the browser will redirect to the target admin page

This approach will require conditional update for login command because right now it force to open login page which will loose the redirect_to URL param.
Also, with this approach it will be hard to switch users: if we already logged in as other user (f.e. Author), the target page might be opened successfully on step 1 or we receive "You cannot access this page" blocker instead of login page. So username and password parameters of visitAdminPage command become pointless.

Actually, I agree with your initial review, saying "one task per command". It will help to isolate each command from being dependent on the state.
Assuming that tests are written with best practices, we expect that session and state are reset before each test, and it's testers responsibility. https://docs.cypress.io/guides/references/best-practices

With all above, the resulting visitAdminPage become just a shortcut to cy.visit( `/wp-admin/${page}` ), not worth implementing at this time IMHO

Makes a lot of sense to me! Closing this PR.


Create signup API endpoint

Tasks to be completed:
Creating a template PHP files and directories for each of the following end points (Signup, Login, CreateContact, Search, Update, Delete). When completed, I will put a follow-up comment stating so to allow for an easy and more streamlined workflow.


Feature request: Support decoding SendGrid URLs

TLDR;
An API endpoint for decoding SendGrid tracking URLs would allow security systems to inspect URLs in emails without revealing to the sender that the email recipient has an operational email inbox.
Background
While SendGrid seems to be doing a good job at combating spammers and phishing, we're still seeing quite a few phishing campaigns using SendGrid as their method of delivery. The use of SendGrid tracking URLs makes it difficult to inspect the included URLs without revealing to the sender that the email address is operational.
Feature request
An API endpoint where we could submit a list of SendGrid URLs and get back their real URL.
In an ideal world, it would be great to be able to decode the URL without having to ask your API (e.g. like reddit link tracking), but due to backwards compatibility, I guess that's unrealistic for now.

Something like this would be amazing.
I have been looking for ways to decode SendGrid URLs (even if I could find the logic to decode myself) as more and more of our users are reporting SendGrid URLs because they don't look safe.

After some thinking, I found an annoyingly simple solution 🙂
For anyone else in need of this functionality, it's kind of already supported. You'll have to send a GET request to the SendGrid URL with a client in which you disallow redirects. You'll get a Location header back which is the URL to which the SendGrid URL would otherwise have redirected your request.


Added a new feathering boost test

Codecov Report

Merging #94 into master will decrease coverage by <.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   85.62%   85.61%   -0.01%
==========================================
  Files          73       73
  Lines        2992     2997       +5
  Branches      434      436       +2
==========================================
+ Hits         2562     2566       +4
- Misses        370      371       +1
  Partials       60       60


docs: update client libraries instructions and dev docs

Summary:
(Updated after Nat's changes in #1458.) Our docs still refer to outdated client libraries, so I updated that. I also simplified the language and examples.
Closes https://github.com/cmu-delphi/www-covidcast/issues/1238.
Prerequisites:

[x] Unless it is a documentation hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

CI failure appears unrelated


Design and implement a machine lifecycle state machine

Proposal doc: https://docs.google.com/document/d/1Kz8bmAF6AZXcagjE4robuStPG93VB9YHj5xBiLI0bt0/edit

This issue was moved to kubernetes-sigs/cluster-api#23


Added LDC Token to Defaults

Website: https://www.leadcoin.network
Telegram: https://t.me/LeadCoinNetwork
Email<EMAIL_ADDRESS>

@doubleorseven
You're going to want to follow our instructions here to get this added as a default token: https://support.mycrypto.com/tokens/token-creators-add-your-token-to-mycrypto.html
We pull from the ethereum-lists repository ( https://github.com/ethereum-lists/tokens/ ) to get our tokens now. Let me know if you need any help :)

got it in the most recent sync from ethereum-lists


added new category for All Categories

https://app.asana.com/0/1135320259326480/1158758430575437/f

approved


Modifying Row Values in SpotLight

Is your feature request related to a problem? Please describe.
Not an actual problem, but a question: is it possible to modify a value in the dataframe from within Spotlight? I don't see any mention of this in the docs, and also, the code doesn't quite seem like it would allow for it (.show() has no return).
Describe the solution you'd like
Assume a user is exploring and QA/QC'ing data and identifies an incorrect label value; how might they change that value?
Thanks, great tool.

Hi Jordan,
thanks for trying out Spotlight and for your feedback.
Editing the table and the annotation widgets are part of the Spotlight Pro version.
If you like to try it out, feel free to drop me an email to get a trial license.
Best,
Stefan
P.S. I'll leave this issue open until we have update the docs to make this more clear.


Issue while selecting all rows with local pagination

Hi Allen,
Select all rows is not working in case of local pagination. PFB  below steps along with snapshots  to generate the issue:
Step 1). Select all row of page 1.

Step2). Move to page 2 , you will see the select all icon is already selected .

Step 3).  In order to select all rows of page no.2 we have to double click on the checkbox.

Step 4). Now come back to page no. 1 , all your initially selected rows will  be shown as non selected

Issue can be generated on below link :
http://allenfang.github.io/react-bootstrap-table/example.html#selection( go to External Selection Management)
Requirement:
select all rows should be functional for each page number as well as we should be able to persist our selected rows of all the pages in case of local pagination
Kindly assist on the same

@shalinibajpai0310, thanks, I think it's a bug about that example, I'll fix it soon, thanks

@shalinibajpai0310, fixed on the website and also update the example code, thanks

@allenfang , thanks for your quick response on my request

@AllenFang What is the solution for this problem? I tested with your exemple here : http://allenfang.github.io/react-bootstrap-table/example.html#selection at the end of the page but no success. When I check "All" I've this error : Uncaught Error: A cross-origin error was thrown. React doesn't have access to the actual error object in development.
Can you help me? I need to checked all checkbox from the first page or another and select all with the pagination. Thanks


Implement query cancellation for PostgreSQL wire protocol

Implements the Protocol part of #207.
Description
This PR only implements the Protocol of CancelRequest. In-progress query cancellation hasn't been implemented yet.

Adds struct ConnSupervisor to save the all current active connection pairs - conn_id and secret_key. The secret_key needs to be verified when invoking CancelRequest from another new connection.

Returns conn_id and secret_key in backend message BackendKeyData (before ReadyForQuery) when startup.

Client output
Since the in-progress query cancellation hasn't been supported, the Empty cancellation could only been tested via psycopg2 (in python command line).
ipython

In [1]: from psycopg2 import connect

In [2]: conn = connect(host="localhost", password="check_this_out", database="postgres")

In [3]: conn.cancel()

The Debug log outputs as below.
$ cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/database`

DEBUG [protocol] address V4(<IP_ADDRESS>:62276)
DEBUG [protocol] client is trying to connect with SSL
DEBUG [protocol] client is trying to connect with version 3
DEBUG [protocol] client message response tag Ok(112)
DEBUG [protocol] waiting for authentication response
DEBUG [protocol] start service on connection-1
DEBUG [protocol] send ready_for_query message
DEBUG [node::node] ready to handle query
DEBUG [protocol] address V4(<IP_ADDRESS>:62277)
DEBUG [protocol] client is trying to connect cancel request
DEBUG [node::node] cancel request of connection-1

Pull Request Test Coverage Report for Build 278862312

110 of 120 (91.67%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.06%) to 88.339%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/node/src/node.rs
0
4
0.0%

src/protocol/src/lib.rs
39
45
86.67%

Files with Coverage Reduction
New Missed Lines
%

src/protocol/src/lib.rs
1
61.86%

src/protocol/src/messages.rs
1
91.4%

Totals

Change from base Build 275356703:
0.06%

Covered Lines:
7697

Relevant Lines:
8713

💛  - Coveralls

@alex-dukhno Please help review this PR if you have time. Thanks.

Hi @alex-dukhno , it seems that there is no branch update-dependecies in https://github.com/alex-dukhno/rust-native-tls.git.
Could you help update https://github.com/alex-dukhno/async-native-tls/blob/new-native-tls/Cargo.toml#L18.

@silathdiir thanks for noticing that, I couldn't understand what is happening 😄


Screen bug when opening document

After last update (March 6, 2016 version_300), an screen bug appears after touching a document to open it. It shows up and goes away fast, and doesn't block the app, it's just ugly. :bowtie:
Here is a screenshot sequence of what happens: http://imgur.com/PCyHTD5
Using Lg nexus 5, Android 6.0

fixed in release 3.0.2


Deploy app on vercel got error "Permission denied"

Hi, i deploy my vite-plugin-ssr app on vercel followed the documentation https://vite-plugin-ssr.com/vercel. but it was fail by error 'Permission denied' in building process:
Running Build Command: `yarn run vercel-build`
yarn run v1.22.17

$ ./vercel/deploy.sh
/bin/sh: ./vercel/deploy.sh: Permission denied
 error Command failed with exit code 126.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
 Error! Command "yarn run vercel-build" exited with 126
Error: Command "vercel build" exited with 1

Am I missing some configuration ？Can someone help ?
i already set environment variable named ENABLE_FILE_SYSTEM_API to 1

Seems related to your fs permissions


Initial dropdown menu

Summary
Create initial dropdown menu
Changelist

Testing Done

Resolved Issues

Checklist
Please change [ ] to [x] when you are ready.

[ ] I have read and followed the code conventions detailed in README.md (This will save time for both you and the reviewer!).
[ ] If this pull request is longer then 500 lines, I have provided explicit justification in the summary above explaining why I cannot break this up into multiple pull requests (Small PR's are faster and less painful for everyone involved!).

Addressed the rename @forbesashli


Add QCOM Multiview Per View Viewport extension support

Add support for the extension VK_QCOM_multiview_per_view_viewports which allows for multiple viewports to be submitted in a single view. RenderDoc already supports this viewport/scissor configuration, and this change will allow applications which submit multiple viewports and scissors using the extension to render correctly.

was it marked as ready for review accidentally and it should still be a draft?
It was marked as ready for review intentionally, but definitely should have received another pass before doing so, my apologies. I've cleaned up the suggested changes and will will reopen for review once I verify that everything is working properly.

You haven't explained why the difference - does this extension really need no modification whatsoever of the replay handling? If so, why were there changes before and how have you tested this to make sure that the replay handling is robust even when the extension is used?

You're right, this does require some clarification. All that multiviewperviewviewports does is give permission for Vulkan to use multiple viewports and scissors, which is already supported by the current VkCmdSetViewports/VkCmdSetScissors functions. From my testing with an app which submits multiple viewports and scissors it looks like there is no change needed on the replay side to enable the feature. Your mentioning that the feature should not be automatically enabled if the struct is attached suggests that I should add a check when submitting viewports to ensure that we have a form of multiviewport support enabled and otherwise either only accept the first submission or throw an error.

Something sounds wrong here. Your description of what the extension does doesn't match up with its description in the spec or my understanding of it. Unextended vulkan absolutely does allow the use of multiple viewports and scissor regions and there is no extension needed for that, though there are extensions that expand its use like VK_EXT_shader_viewport_index_layer. This extension seems to change the behaviour of multiview passes to automatically use the multiview view index as a viewport index if no explicit viewport index is selected.
I don't understand what you're saying about only accepting 'the first submission' or throwing any kind of error. Can you explain exactly what you mean by that?

This resolves the issue with vk_overlay not displaying the proper viewport/scissors region. If you know of a better way to retrieve the active slice value without modifying the RenderOverlay signature please advise me, but I don't believe it's retrievable without either changing the Overlay value to not be the enum or adding a new value in.

I'm not meaning to be rude but I think there's still a misunderstanding here about how this extension works, and maybe how extensions work on Vulkan in general.
For that reason I'm closing this PR for now - could you please open this as a feature request issue for extension support and then it can be tracked that way?


Analyzer suggests auto-complete items that are not useful

My file looks approximately like this:
import 'package:angular/angular.dart';
import 'package:swlegion/catalog.dart';
import 'package:swlegion/holodeck.dart';

class Simulator {
  static final _defendingWhiteSurgeTroopers = Defender.multipleUnits(
    [
      Units.$1dot4FDLaserCannonTeam,
      Units.$74ZSpeederBikes,
    ],
    const DefensePool(
      dice: Dice
      // ^^^^^^^
    ),
  );

I wanted a suggestion of package:swlegion/holodeck.dart, which includes a DefenseDice class.
I hit CTRL-SPACE, and got:

A few comments/requests:

[ ] Can analyzer only suggest types that are valid, especially since Dart 2?

I was assigning to DefensePool.dice, which reads:
  /// What type of dice the defending units are using.
  final DefenseDice dice;

... so I think it would be ideal to only suggest types that are valid assignments to DefenseDice.

[ ] Can analyzer do full-string matches instead of partial?

I typed dice, assuming that it would auto-complete to DefenseDice but instead got:

Directive
Uri.directory(...)

... etc. Maybe this makes sense up to say, 2 characters, but clearly by typing dice I did not intend to write Uri.directory. In fact, DefenseDice does not show up at all in the list no matter what I type and try to complete, because it is not imported. But that's unfortunate, because it is one of my dependencies.

I wanted a suggestion of package:swlegion/holodeck.dart, which includes a DefenseDice class.

In fact, DefenseDice does not show up at all in the list no matter what I type and try to complete, because it is not imported. But that's unfortunate, because it is one of my dependencies.

The source code appears to contradict the second statement, so I'm not sure I understand what the problem is. But if the issue is that server isn't suggesting names from libraries that are not imported but could be, then we're already working on fixing the issue.

Can analyzer only suggest types that are valid, especially since Dart 2?

I agree that it would be useful for server to prioritize suggestions that match the target type when such a type is known. I would love to see us add support for that.

Can analyzer do full-string matches instead of partial?

The filtering is actually being done by the client, not by the server. @jwren @alexander-doroshko for feedback on the filtering. It would be interesting to know where DefenseDice would have been in the list had it been imported (or where it will be once we start including non-imported names).

@bwilkerson:

But if the issue is that server isn't suggesting names from libraries that are not imported but could be, then we're already working on fixing the issue.

Yes, is there a bug tracking this particular issue?

I agree that it would be useful for server to prioritize suggestions that match the target type

Is it worth filing a separate issue specifically for this?

Can analyzer do full-string matches instead of partial?

In this case it was actually VSCode, not IntelliJ (/cc @DanTup), fwiw.

is there a bug tracking this particular issue?

Yes, the issue is https://github.com/dart-lang/sdk/issues/25820.

Is it worth filing a separate issue specifically for this?

Given that using type information to prioritize suggestions is (I think) the only analyzer issue left that isn't being worked on elsewhere, I think it's fine if we use this issue to track it.

Speaking of IntelliJ, it has 2 shortcuts for code completion: standard (Ctrl+Space) and Smart Completion (Ctrl+Shift+Space). Standard completion suggests everything available at the caret position. Smart Completion suggests only those items that match expected type. It even includes chained calls that result in expected type.
Unfortunately, Smart Completion is not yet supported in Dart but you may try it in Java and in some other languages to get the idea. If you like the idea we may think about implementing the feature on the Analysis Server end and integrating it in IDEs.

And speaking of middle-matching and sorting, IntelliJ shows items with exact matches higher than items with fractional matches, so 'DefenseDice' would be close to top if it were in the list. Middle-matching, case-sensivity and other completion options are configurable in IntelliJ.

Can analyzer only suggest types that are valid, especially since Dart 2?

This was raised in Dart Code previously too, but I think filtering out unrelated types may be bad because there could be static members on those types that you want. For example in flutter_gallery there's this:
MaterialDemoDocumentationButton(SnackBarDemo.routeName)

That constructor takes a String and if we filtered out SnackBarDemo you'd have to type it manually. Ranking them may be better, or maybe even including the static members directly in the list (I think we already do it with enum values).

I typed dice, assuming that it would auto-complete to DefenseDice but instead got:

Directive

The filtering is done client-side so this is VS Code behaviour. It seems like you might not be able to disable it though there is editor.suggest.filterGraceful which controls whether it matches what it thinks are typos. I wonder if they could only match on exact strings or by looking at the capital letters (looks like maybe it does that for quick open?).

The available declarations support addressed at least one of the issues raised here. We're also now paying attention to the context type, so that ought to address at least one of the issues. I'm going to close this but please let me know if we've missed something important that isn't yet resolved.

The available declarations support addressed at least one of the issues raised here. We're also now paying attention to the context type, so that ought to address at least one of the issues. I'm going to close this but please let me know if we've missed something important that isn't yet resolved.


[BUG] persistent volumes stuck in attach/detach loop

Describe the bug (🐛 if you encounter this issue)
on pod restart the PV/PVC is stuck in an attach/detach loop as shown in the longhorn UI
To Reproduce
I'm not sure what caused the issue to start with, but snapshots stopped working and potentially nodes were corrupted with IO errors and cpu spikes.  Now, when an existing pod is killed or node cordoned and the pod restarted on another node, the PV in longhorn loops on attaching, then detaching, then attaching..
Expected behavior
Persistent volumes should reattach when workload is restarted in kubernetes
Support bundle for troubleshooting
will attachsupport bundle
Environment

Longhorn version: 1.5.1
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s 1.24.1

Number of management node in the cluster: 3
Number of worker node in the cluster: 2

Node config

OS type and version: RHEL 8.8
Kernel version: 4.18
CPU per node: 8
Memory per node: 32G
Disk type(e.g. SSD/NVMe/HDD): SSD datastore via 10G iscsi (vmware vmdk)
Network bandwidth between the nodes: 10Gbps

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): vmware 8
Number of Longhorn volumes in the cluster: ~30
Impacted Longhorn resources: postgresql/redis/minio backing to longhorn PV

Volume names: gitlab-postgres-0

Additional context
Redhat vm's often showing

"Buffer IO error on dev sdX (where sdX is the longhorn volume being mounted on the vm node)
"EXT4-FS error (device sdX) ... unable to read itable block"

supportbundle_da3ea917-a9de-4ccf-bb5e-0d1b394a068f_2023-10-19T18-57-28Z.zip

new workloads will not deploy and attach to storage now at all...any clues?

the attach/detach problem was caused by the iscsid service not running on nodes. the iscsi service was disabled for reboot performance, and iscsid was disabled also, but iscsid is REQUIRED for longhorn


Toolbar menu button: width too small

I have the issue that you can see in the screenshoot (on Firefox 51.0.1 (64 bit), it looks fine on Chrome instead).

As you can see it looks like the size of the menu isn't calculated well, because scrollbar appears!
This is how I declare toolbar:
var navigation_bar = $("#navigation_bar").w2toolbar({
    name: 'toolbar_navigation',
    items: [
        { type: 'button', id: 'about_button', text: 'About', icon: 'fa fa-info-circle' },
        { type: 'break' },
        { type: 'menu', id: 'project_button', text: 'Project', icon: 'fa fa-archive',
            items: [
                { id: 'duplicate_button', text: 'Duplicate', icon: 'fa fa-clone' }
            ]
        },
        { type: 'break' },
        { type: 'button', id: 'run_button', text: 'Run', icon: 'fa fa-caret-square-o-right' },
        { type: 'break' },
        { type: 'button', id: 'reset_button', text: 'Reset', icon: 'fa fa-stop-circle-o' },
        { type: 'break' },
        { type: 'spacer' },
        { type: 'button', id: 'info_project_button', text: '', disabled: true }
    ],
    onClick: function (event) {
        // cut
    }
});

and div inside main html..

I would like to fix this by myself, but I don't know where to start looking for!
Note that if I put "Item 3" instead of "Duplicate", it looks like it works fine!

But if i write "Menu 1" it doesn't work!

That's very weird!!!!
Do you have some hints?

Hi digged more and I found that's an issue with latest jquery I'm using (3.1.1) instead of 2.x used in your sample.
Mmm..i'm stuck now :(

I am facing the same issue. I cannot find out when these scollbars appear. I observe the cases

Safari on mac
chrome on some windows boxes.
I tried to dig into the generated DOM and see If it can be fixed. Amazingly the width of the div is fixed in the dom. This means that w2ui somehow computes it. But i could not find the position, where it is computed.

Whatever i tried ...

remove the localization
played with different length of menu
played with different length of caption

I observe the effect on some menus while it does not happen on others.
I am stuck as well - any help would be desperately welcome.

Although old, for those who come across this discussion looking on the web here is my solution (workaround):
change the css style of the w2ui-menu class:
.w2ui-menu {
position: relative;
overflow: hidden;
}


Automated cherry pick of #9613: fix(notify): fit correctly when send notification via contact

Cherry pick of #9613 on release/3.6.
#9613: fix(notify): fit correctly when send notification via contact

Codecov Report

Merging #9614 (cdf7825) into release/3.6 (b9d30c0) will increase coverage by 10.63%.
The diff coverage is 2.31%.

@@               Coverage Diff                @@
##           release/3.6    #9614       +/-   ##
================================================
+ Coverage         5.86%   16.49%   +10.63%
================================================
  Files              828       87      -741
  Lines           129133     9122   -120011
================================================
- Hits              7577     1505     -6072
+ Misses          120876     7485   -113391
+ Partials           680      132      -548

Flag
Coverage Δ

aFlag
16.49% <2.31%> (+10.63%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/hostman/diskutils/nbd/driver.go
0.75% <0.75%> (ø)

pkg/hostman/diskutils/nbd/lvmutils.go
4.93% <4.93%> (ø)

pkg/monitor/alerting/conditions/nodataquery.go
0.72% <0.00%> (-0.27%)
:arrow_down:

pkg/util/ansiblev2/session.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/conditions/query.go
0.00% <0.00%> (ø)

...kg/monitor/tsdb/driver/influxdb/response_parser.go

pkg/keystone/models/rolepolicies.go

pkg/lbagent/models/haproxy.go

pkg/hostman/hostinfo/hostovn.go

... and 636 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c370d...cdf7825. Read the comment docs.


about import softpool_cuda

Import softtool_ cuda error，his package is softpool in CUDA folder_ cuda.cpp？

Hi @PJJie,
The softpool_cuda is the GPU-accelerated package created when you run make install. Not being able to import it means that the package has not been created.
Best,
Alex

Hi @PJJie,
The softpool_cuda is the GPU-accelerated package created when you run make install. Not being able to import it means that the package has not been created.
Best,
Alex

But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

Hi @PJJie,
The softpool_cuda is the GPU-accelerated package created when you run make install. Not being able to import it means that the package has not been created.
Best,
Alex
But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

Hi @PJJie,
The softpool_cuda is the GPU-accelerated package created when you run make install. Not being able to import it means that the package has not been created.
Best,
Alex
But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

Can you first import torch and then import softpool_cuda ? Some symbols are dynamically linked to torch which if not loaded first softpool_cuda will also fail to load.
Best,
Alex

But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

Can you first import torch and then import softpool_cuda ? Some symbols are dynamically linked to torch which if not loaded first softpool_cuda will also fail to load.
Best,
Alex

But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

Can you first import torch and then import softpool_cuda ? Some symbols are dynamically linked to torch which if not loaded first softpool_cuda will also fail to load.
Best,
Alex

you're right, thank you !

But it still have some problem to import 'softpool_cuda' after I successfully run 'make install' , waiting for your help, thanks a lot !

Can you first import torch and then import softpool_cuda ? Some symbols are dynamically linked to torch which if not loaded first softpool_cuda will also fail to load.
Best,
Alex

you're right, thank you !

Closing due to inactivity. Feel free to open if the issue is still present.

Closing due to inactivity. Feel free to open if the issue is still present.


Update UI of Login Page

I think we can modify the UI of the Login page. I am attaching the photos of how the webpage is looking now and how I want to change it. @osBins assign it to me. So that I can start working on it.

That looks neat. Go for it @SachinMittal1766!


Deadlock while using wifi routines from the timer task (IDFGH-1143)

Environment

Development Kit:      ESP32-Wrover-Kit|Custom hardware
Kit version: v2
Module or chip used:  ESP32-WROOM-32
IDF version (run git describe --tags to find it): 3.1.3
Build System:       make
Compiler version (run xtensa-esp32-elf-gcc --version to find it):  1.22.0-80-g6c4433a
Operating System:    macOS
Power Supply:  USB

Problem Description
There is a deadlock. WiFi and timer tasks fall into a deadlock by cross-acquiring timer protection mutex and a wifi mutex.
The callstacks for the corresponding threads are:
Thread 8 (Thread<PHONE_NUMBER>):
#0  0x4008f499 in xQueueGenericReceive (xQueue=0x3ffaea74, pvBuffer=0x0, xTicksToWait=4294967295, xJustPeeking=0) at .../esp-idf/components/freertos/queue.c:1592
#1  0x4008f4f4 in xQueueTakeMutexRecursive (xMutex=0x3ffaea74, xTicksToWait=4294967295) at .../esp-idf/components/freertos/queue.c:635
#2  0x400d20b5 in esp_timer_delete (timer=0x3ffce4ac) at .../esp-idf/components/esp32/esp_timer.c:166
#3  0x400fb42e in ets_timer_done (ptimer=0x3ffbb0d4) at .../esp-idf/components/esp32/ets_timer_legacy.c:97
#4  0x400fb1c0 in timer_done_wrapper (ptimer=0x3ffbb0d4) at .../esp-idf/components/esp32/esp_adapter.c:350
#5  0x4010d03d in ieee80211_mlme_connect_bss ()
#6  0x40113d47 in ?? ()
#7  0x40114213 in ?? ()
#8  0x40114c94 in cnx_csa_fn_process ()
#9  0x40112f8b in ?? ()
#10 0x40113101 in ieee80211_timer_do_process ()
#11 0x4008da6b in ppTask ()
#12 0x4008eb49 in vPortTaskWrapper (pxCode=0x4008d9ac , pvParameters=0x0) at .../esp-idf/components/freertos/port.c:143
Thread 7 (Thread<PHONE_NUMBER>):
#0  0x4008f499 in xQueueGenericReceive (xQueue=0x3ffc5250, pvBuffer=0x0, xTicksToWait=4294967295, xJustPeeking=0) at .../esp-idf/components/freertos/queue.c:1592
#1  0x400fb278 in semphr_take_wrapper (semphr=0x3ffc5250, block_time_tick=4294967295) at .../esp-idf/components/esp32/esp_adapter.c:234
#2  0x40108538 in ieee80211_ioctl ()
#3  0x400fcca2 in esp_wifi_sta_get_ap_info ()
#4  0x400ebcc9 in network::update_network_info (arg=) at .../board/src/commons/net/network/network.cpp:304
#5  0x400d1fbf in timer_process_alarm (dispatch_method=) at .../esp-idf/components/esp32/esp_timer.c:290
#6  0x400d2052 in timer_task (arg=0x0) at .../esp-idf/components/esp32/esp_timer.c:318
#7  0x4008eb49 in vPortTaskWrapper (pxCode=0x400d2034 <timer_task>, pvParameters=0x0) at .../esp-idf/components/freertos/port.c:143
The deadlock is induced by esp_wifi_sta_get_ap_info being called from the timer thread which is done within a scope protected by mutex 0x3ffaea74 because this is done in timer callback context. While executing esp_wifi_sta_get_ap_info it obviously tries to acquire semaphore 0x3ffc5250 which is supposedly already taken by the WiFi thread. The latter one at this moment tries to capture mutex 0x3ffaea74 during the timer delete routine. Finita...
Steps to repropduce
They are obvious from the callstacks.
Code to reproduce this issue
Invoke  esp_wifi_sta_get_ap_info (or another wifi-related stuff) in timer thread. Repro rate is not 100%, but the symptoms are clear from the callstacks and analysis above.

Different scenario, same root cause.
I'm trying to invoke esp_reboot from the timer task.
Thread 8 (Thread<PHONE_NUMBER>):
#0  0x40088a9c in xQueueGenericReceive (xQueue=0x3ffc52e8, pvBuffer=0x0, xTicksToWait=4294967295, xJustPeeking=0) at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/freertos/queue.c:1592
#1  0x400f71b5 in semphr_take_wrapper (semphr=0x3ffc52e8, block_time_tick=4294967295) at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/esp32/esp_adapter.c:236
#2  0x40102f38 in ieee80211_ioctl ()
#3  0x400f8244 in esp_wifi_stop ()
#4  0x40081b55 in esp_restart () at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/esp32/system_api.c:255
Thread 9 (Thread<PHONE_NUMBER>):
#0  0x40088a9c in xQueueGenericReceive (xQueue=0x3ffaeaa0, pvBuffer=0x0, xTicksToWait=4294967295, xJustPeeking=0) at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/freertos/queue.c:1592
#1  0x40088afc in xQueueTakeMutexRecursive (xMutex=0x3ffaeaa0, xTicksToWait=4294967295) at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/freertos/queue.c:635
#2  0x400d1d95 in esp_timer_delete (timer=0x3ffcd738) at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/esp32/esp_timer.c:166
#3  0x400f7280 in ets_timer_done (ptimer=0x3ffb3ed8) at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/esp32/ets_timer_legacy.c:97
#4  0x400f70a8 in timer_done_wrapper (ptimer=0x3ffb3ed8) at /Users/andreyfilimonov/repo/iotgizmo_dimmer/espressif_3rdparty/esp32/esp-idf/components/esp32/esp_adapter.c:350
#5  0x400fb9a8 in wifi_softap_stop ()
#6  0x40100f4b in ?? ()
#7  0x401020e4 in wifi_stop_process ()
#8  0x40102e3d in ieee80211_ioctl_process ()
#9  0x4008e0ff in ppTask ()

@Sermus, thanks for reporting this bug. We will fix it.

This issue is fixed in commit: 197e0ae1

@Sermus Thanks for reporting the issue, feel free to reopen the issue if it still exists. Thanks.


ament_black: 0.2.6-1 in 'iron/distribution.yaml' [bloom]

Increasing version of package(s) in repository ament_black to 0.2.6-1:

upstream repository: https://github.com/botsandus/ament_black.git
release repository: https://github.com/ros2-gbp/ament_black-release.git
distro file: iron/distribution.yaml
bloom version: 0.12.0
previous version for package: 0.2.5-1

ament_black
* Add packaging as a required dependency (#14 <https://github.com/botsandus/ament_black/issues/14>)
  Follow up to:
  - https://github.com/botsandus/ament_black/pull/13
* Contributors: Ruffin

ament_cmake_black

No changes

Holding for Iron sync


Deployment failed on RedHat OpenShift on AWS

Describe the bug
To Reproduce
Steps to reproduce the behavior:
Apply the latest installer changed by #129 then the provider pod can not start and showing errors as below,
I0927 05:44:21.760601       1 main.go:32] Starting secrets-store-csi-driver-provider-aws version 1.0.r2-6-gee95299-2<IP_ADDRESS>.07
F0927 05:44:21.856264       1 main.go:53] Failed to listen on unix socket. error: listen unix /etc/kubernetes/secrets-store-csi-providers/aws.sock: bind: permission denied
goroutine 1 [running]:
k8s.io/klog/v2.stacks(0xc000124001, 0xc00015c2a0, 0xac, 0xd9)
	/home/ec2-user/go/pkg/mod/k8s.io/klog/v2@v2.8.0/klog.go:1021 +0xb9
k8s.io/klog/v2.(*loggingT).output(0x26ba100, 0xc000000003, 0x0, 0x0, 0xc00046c150, 0x2617629, 0x7, 0x35, 0x0)
	/home/ec2-user/go/pkg/mod/k8s.io/klog/v2@v2.8.0/klog.go:970 +0x19b
k8s.io/klog/v2.(*loggingT).printf(0x26ba100, 0xc000000003, 0x0, 0x0, 0x0, 0x0, 0x1a06b42, 0x2a, 0xc0000a8020, 0x1, ...)
	/home/ec2-user/go/pkg/mod/k8s.io/klog/v2@v2.8.0/klog.go:751 +0x191
k8s.io/klog/v2.Fatalf(...)
	/home/ec2-user/go/pkg/mod/k8s.io/klog/v2@v2.8.0/klog.go:1509
main.main()
	/home/ec2-user/secrets-store-csi-driver-provider-aws/main.go:53 +0x437
goroutine 34 [chan receive]:
k8s.io/klog/v2.(*loggingT).flushDaemon(0x26ba100)
	/home/ec2-user/go/pkg/mod/k8s.io/klog/v2@v2.8.0/klog.go:1164 +0x8b
created by k8s.io/klog/v2.init.0
	/home/ec2-user/go/pkg/mod/k8s.io/klog/v2@v2.8.0/klog.go:418 +0xdf
goroutine 3 [syscall]:
os/signal.signal_recv(0x0)
	/usr/lib/golang/src/runtime/sigqueue.go:147 +0x9d
os/signal.loop()
	/usr/lib/golang/src/os/signal/signal_unix.go:23 +0x25
created by os/signal.Notify.func1.1
	/usr/lib/golang/src/os/signal/signal.go:150 +0x45
goroutine 19 [chan receive]:
main.main.func1(0xc0003490e0, 0xc000210fc0)
	/home/ec2-user/secrets-store-csi-driver-provider-aws/main.go:46 +0x45
created by main.main
	/home/ec2-user/secrets-store-csi-driver-provider-aws/main.go:45 +0x31a

Do you also notice this bug when using a different secrets store provider (Vault/Azure/GCP...)? No
If yes, the issue is likely with the k8s Secrets Store CSI driver, not the AWS provider. Open an issue in that repo.
Expected behavior
The pod should start as normal before the install change by PR #129
Environment:
OS, Go version, etc.
Additional context
When I rollback the change made by PR #129 everything works.

We are not able to reproduce the issue you're facing on this environment, using the commands in our README
Client Version: v1.25.0
Kustomize Version: v4.5.7
Server Version: v1.22.13-eks-15b7512

helm repo add secrets-store-csi-driver https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts
helm install -n kube-system csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver

kubectl apply -n kube-system -f https://raw.githubusercontent.com/aws/secrets-store-csi-driver-provider-aws/main/deployment/aws-provider-installer.yaml

Could you provide more information about your environment and the commands you ran?

I'm facing the issue on ROSA (RedHat OpenShift on AWS) clusters.
versions
Client Version: v1.24.1
Kustomize Version: v4.5.4
Server Version: v1.24.0+b62823b

Commands used
oc adm policy add-scc-to-user privileged system:serviceaccount:kube-system:secrets-store-csi-driver
oc adm policy add-scc-to-user privileged system:serviceaccount:kube-system:csi-secrets-store-provider-aws

# Secrets Store CSI driver
helm repo add secrets-store-csi-driver https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts
helm upgrade --install -n kube-system csi-secrets-store \
  --set syncSecret.enabled=true \
  --set rotationPollInterval=2m \
  --set enableSecretRotation=true \
  secrets-store-csi-driver/secrets-store-csi-driver

# Installing the AWS Provider
kubectl apply -f https://raw.githubusercontent.com/aws/secrets-store-csi-driver-provider-aws/main/deployment/aws-provider-installer.yaml

fndcz - Thank you for providing the additional information. OpenShift is not supported by our project at this time and our recommendation would be to reach out to the OpenShift team or see if you can reproduce this on EKS clusters.


compress/gzip: issue6550 test fails

System: Slackware Linux (version 14.0)
CPUs: Intel(R) Atom(TM) CPU N270 @1.60GHz
Deps: go1.4-bootstrap-20170531.tar.gz,
go1.9.src.tar.gz
I created a package for installation on Slackware-14.0 (32bit) here.
I've never seen this output before near the end of running a .SlackBuild script.
This also occurs with version 1.8.3.
WARNING:  gzip test failed on usr/lib/go1.9/go/src/compress/gzip/testdata/issue6550.gz
http://nurmi-labs.blogspot.com/2017/08/bootstrapping-go.html

I don't know what the .SlackBuild script does.  There should be more information printed somewhere, showing what exactly failed.  Can you find that?
Note that compress/gzip/testdata/issue6550.gz is a binary file, so please verify that it was not corrupted anywhere during the build process.

issue6550.gz is an intentionally corrupted file used in the unit tests... why does SlackBuild care about inspecting whether it is valid or not?

The google-go-lang.SlackBuild script runs /sbin/makepkg at the end.
The output as "WARNING: gzip test failed on usr/lib/go1.9/go/src/compress/gzip/testdata/issue6550.gz"
was from the makepkg script.
Index of /slackware/slackware-14.0/source/a/pkgtools/scripts
makepkg
Warn of corrupt or empty gzip files:
find . -type f -name '*.gz' | while read file ; do
if ! gzip -t $file 1> /dev/null 2> /dev/null ; then
echo "WARNING:  gzip test failed on $(echo $file | cut -b3-)"
else
if [ "$(gzip -l $file | tail -n 1 | tr -s ' ' | cut -f 3 -d ' ')" -eq 0 ]; then
echo "WARNING:  $(echo $file | cut -b3-) is an empty gzipped file"
fi
fi
done

My question is why SlackBuild cares about this at all? I don't see why some other packaging system should care about the files (especially test files) within that package. I really don't want our tests to be at the whim of whatever obscure rule package managers have.
#14937 was already a case where we had to scrub all MTIME fields from gzip files.

It was /sbin/makepkg (not the build script) that output this warning which informed what the package will contain, if the package factually is created, which it was, so I recommend closing the issue.
The script /sbin/makepkg (not the Go code) was the source of the warning.

Since this is just a warning, and I believe the correct place to fix this in makepkg, and not the Go project. Am I to correct to believe that there is nothing that we can do here?

As dset inferred "issue6550.gz is an intentionally corrupted file used in the unit tests...".
bash-4.2# file issue6550.gz
issue6550.gz: gzip compressed data, extra field, encrypted
bash-4.2# file issue6550.gz
Therefore, presuming the accuracy of that quoted statement, there's nothing to fix on the makepkg end; makepkg is doing its job WARNING of zero length files and also of the corrupt gzip file.

Am I to correct to believe that there is nothing that we can do here?

bash-4.2# grep -nr 6550 gzip
gzip/gunzip_test.go:415: func TestIssue6550(t *testing.T) {
gzip/gunzip_test.go:416:     f, err := os.Open("testdata/issue6550.gz")
gzip/gunzip_test.go:422:             t.Fatalf("NewReader(testdata/issue6550.gz): %v", err)
bash-4.2#
Seems that's the case.
The large bold font was unintentional by the way.


Pylance is linting standard library and venv site-packages

Pylance is linting standard library and venv site-packages. Reproduction of #1514
Environment data

Language Server version: v2023.3.20
OS and version: Windows 10 64-vit
Python version (& distribution if applicable, e.g. Anaconda): 3.10.7 with Poetry (version 1.3.2)

Code Snippet

./src/stage_artifact/__init__.py
import logging
import os
import shutil
from pathlib import Path
from typing import Union
from urllib.parse import ParseResult, urlparse

import requests
from requests import HTTPError

LOGGER = logging.getLogger(__name__)

def file_uri_to_path(path: str) -> Path:
    """_summary_

    Args:
        path (str): _description_

    Raises:
        NotImplementedError: _description_

    Returns:
        Path: _description_
    """
    if path.find('find:') != 0:
        raise NotImplementedError("Only file: URIs are supported")

    return Path()

def validate_artifact_path(artifact_fullpath: str) -> Union[ParseResult, Path]:
    """Given an artifact path identify if it is a URL or Path object

    Args:
        artifact_fullpath (str): String

    Raises:
        HTTPError: _description_
        FileNotFoundError: _description_
        FileNotFoundError: _description_
        NotImplementedError: _description_

    Returns:
        Union[ParseResult, Path]: _description_
    """
    parse_result = urlparse(artifact_fullpath)
    scheme = parse_result.scheme
    LOGGER.info("Parsed scheme: '%s'", scheme)
    match scheme:
        case 'http' | 'https':
            LOGGER.debug("Artifact is URL")
            return parse_result
        case 'file':
            LOGGER.debug("Artifact is file URI")
            path_stripped_of_file_proto = artifact_fullpath.strip('file:')
            path_obj = Path(path_stripped_of_file_proto)
            LOGGER.info("Artifact is file")
            return path_obj
        case '':
            LOGGER.debug("Artifact is Netshare")
            path_obj = Path(artifact_fullpath)
            return path_obj
        case scheme if len(scheme) == 1:
            LOGGER.debug("Artifact is Windows path")
            return Path(artifact_fullpath)
        case _:
            raise NotImplementedError(f"scheme {scheme} is not implemented")

def stage_artifact(artifact_fullpath: str) -> str:
    """Stage an artifact to the stage directory of the current workspace

    Args:
        artifact_fullpath (str): Path to the artifact

    Raises:
        HTTPError: Artifact URL is unreachable
        FileNotFoundError: Artifact is not a regular file

    Returns:
        str: String representation of locally staged artifact
    """
    artifact = validate_artifact_path(artifact_fullpath)
    stage_dir = Path('stage')
    stage_dir.mkdir(exist_ok=True)
    match artifact:
        case ParseResult():  # isinstance(artifact, ParseResult)
            LOGGER.debug("Checking if '%s' exists", artifact.geturl())
            if not (response := requests.get(artifact.geturl(), timeout=60)).ok:
                raise HTTPError(f"The URL '{artifact.geturl()}' returned response code: {response.status_code}")
            LOGGER.debug("'%s' exists", artifact.geturl())
            dest_path = stage_dir / artifact.path.rsplit('/', 1)[1]
            with open(dest_path, 'wb') as file:
                LOGGER.debug("Downloading '%s'", artifact.path)
                file.write(requests.get(artifact.geturl(), timeout=60).content)
        case Path():  # isinstance(artifact, Path)
            LOGGER.info("Path: %s", artifact)
            if not artifact.is_file():
                raise FileNotFoundError(artifact)
            dest_path = stage_dir / artifact.name
            shutil.copyfile(src=artifact, dst=dest_path)
    LOGGER.info("Staged artifact release to %s", dest_path)
    dest_path_as_str_literal = os.path.abspath(
        dest_path)  # convert to string liter - https://stackoverflow.com/posts/44569249/revisions
    return dest_path_as_str_literal

./src/tests/stage_artifact/test_windows.py
# pylint: disable=missing-module-docstring,missing-function-docstring

import logging
from pathlib import Path

import pytest

from stage_artifact import stage_artifact, validate_artifact_path

from . import PACKAGE

LOGGER = logging.getLogger(__name__)

@pytest.fixture(autouse=True)
def cleanup(request: pytest.FixtureRequest):
    Path("stage/test_resource.txt").unlink(missing_ok=True)
    yield
    LOGGER.debug("Deleting 'stage/test_resource.txt' for %s", request.node)
    Path("stage/test_resource.txt").unlink(missing_ok=True)

def test_windows_back_slash(resource_path_root: Path):
    path = f"{resource_path_root}\\{PACKAGE}\\test_resource.txt"
    stage_artifact(path)
    assert Path("stage/test_resource.txt").is_file()

def test_windows_forward_slash(resource_path_root: Path):
    path = f"{resource_path_root.as_posix()}/{PACKAGE}/test_resource.txt"
    stage_artifact(path)
    assert Path("stage/test_resource.txt").is_file()

def test_file_protocol_to_windows_path_zero_slash(resource_path_root: Path):
    path = f"file:{resource_path_root.as_posix()}/{PACKAGE}/test_resource.txt"
    stage_artifact(path)
    assert Path("stage/test_resource.txt").is_file()

def test_file_protocol_to_windows_path_one_slash(resource_path_root: Path):
    path = f"file:/{resource_path_root.as_posix()}/{PACKAGE}/test_resource.txt"
    LOGGER.debug(f"{path=}")
    stage_artifact(path)
    assert Path("stage/test_resource.txt").is_file()
    assert isinstance(validate_artifact_path("file:localhost/Myendoint.ear"), Path)

def test_file_protocol_to_windows_path_two_slash():
    assert isinstance(validate_artifact_path("file:///localhost/Myendoint.ear"), Path)

def test_file_protocol_to_windows_path_three_slash():
    assert isinstance(validate_artifact_path("file:///localhost/Myendoint.ear"), Path)

def test_stage_windows_forward_slash(resource_path_root):
    stage_artifact(f"{resource_path_root}/{PACKAGE}/test_resource.txt")
    assert Path("stage/test_resource.txt").is_file()

def test_stage_windows_back_slash(resource_path_root):
    stage_artifact(f"{resource_path_root}\\{PACKAGE}\\test_resource.txt")
    assert Path("stage/test_resource.txt").is_file()

Repro Steps

Open the repo using either a virtual environment via venv or PyPoetry
Have the following defined in user settings.json

    "python.linting.ignorePatterns": [
        "**/.vscode/extensions/**/*.py",
        "**/.vscode/extensions/**/*.pyi",
        ".vscode/*.py",
        "**/Python3*/**/*.py",
        "**/site-packages/**/*.py",
        ".venv/**/*/.py",
        "**/pypoetry/Cache/virtualenvs/**/*.py",
        "**/pypoetry/Cache/virtualenvs/**/*.pyi"
    ],

Have the following dependencies in pyproject.toml

[tool.poetry.dependencies]
python = "^3.10"
requests = "^2.28.2"
[tool.poetry.group.dev.dependencies]
isort = "^5.12.0"
pydocstyle = ">= 6.1.1"
pylint = ">= 2.13.4"
pytest = ">= 7.1.1"
yapf = { git = "https://github.com/char101/yapf.git", branch = "3.10", extras = [
    "pyproject"
] }
pytest-resource-path = "^1.3.0"

Poetry.lock
poetry.lock.txt
##Expected results:

Only the project workspace is linted

##Actual results

Stdlib and virtual environment packages are linted.
e.g.

/c:/Program Files/Python310/Lib/xml/etree/ElementPath.py
[{
	"resource": "/c:/Program Files/Python310/Lib/xml/etree/ElementPath.py",
	"owner": "_generated_diagnostic_collection_name_#2",
	"code": {
		"value": "reportGeneralTypeIssues",
		"target": {
			"$mid": 1,
			"path": "/microsoft/pyright/blob/main/docs/configuration.md",
			"scheme": "https",
			"authority": "github.com",
			"fragment": "reportGeneralTypeIssues"
		}
	},
	"severity": 8,
	"message": "Argument of type \"list[Unknown] | Unknown | None\" cannot be assigned to parameter \"__i\" of type \"SupportsNext[_T@next]\" in function \"next\"\n  Type \"list[Unknown] | Unknown | None\" cannot be assigned to type \"SupportsNext[_T@next]\"\n    \"list[Unknown]\" is incompatible with protocol \"SupportsNext[_T@next]\"\n      \"__next__\" is not present",
	"source": "Pylance",
	"startLineNumber": 405,
	"startColumn": 17,
	"endLineNumber": 405,
	"endColumn": 49
},{
	"resource": "/c:/Program Files/Python310/Lib/xml/etree/ElementPath.py",
	"owner": "_generated_diagnostic_collection_name_#2",
	"code": {
		"value": "reportGeneralTypeIssues",
		"target": {
			"$mid": 1,
			"path": "/microsoft/pyright/blob/main/docs/configuration.md",
			"scheme": "https",
			"authority": "github.com",
			"fragment": "reportGeneralTypeIssues"
		}
	},
	"severity": 8,
	"message": "Argument of type \"list[Unknown] | Unknown | None\" cannot be assigned to parameter \"__iterable\" of type \"Iterable[_T@list]\" in function \"__init__\"\n  Type \"list[Unknown] | Unknown | None\" cannot be assigned to type \"Iterable[Unknown]\"\n    \"__iter__\" is not present",
	"source": "Pylance",
	"startLineNumber": 411,
	"startColumn": 17,
	"endLineNumber": 411,
	"endColumn": 49
},{
	"resource": "/c:/Program Files/Python310/Lib/xml/etree/ElementPath.py",
	"owner": "_generated_diagnostic_collection_name_#2",
	"code": {
		"value": "reportGeneralTypeIssues",
		"target": {
			"$mid": 1,
			"path": "/microsoft/pyright/blob/main/docs/configuration.md",
			"scheme": "https",
			"authority": "github.com",
			"fragment": "reportGeneralTypeIssues"
		}
	},
	"severity": 8,
	"message": "Argument of type \"list[Unknown] | Unknown | None\" cannot be assigned to parameter \"__i\" of type \"SupportsNext[_T@next]\" in function \"next\"\n  Type \"list[Unknown] | Unknown | None\" cannot be assigned to type \"SupportsNext[_T@next]\"\n    \"list[Unknown]\" is incompatible with protocol \"SupportsNext[_T@next]\"\n      \"__next__\" is not present",
	"source": "Pylance",
	"startLineNumber": 418,
	"startColumn": 21,
	"endLineNumber": 418,
	"endColumn": 53
}]

/c:/Users/XXXXXXX/AppData/Local/pypoetry/Cache/virtualenvs/xxxxx-repo-name-xxxxx-hSP6Rt1H-py3.10/Lib/site-packages/pytest_resource_path/path_to_resource_factory.py
[{
	"resource": "/c:/Users/XXXXXXX/AppData/Local/pypoetry/Cache/virtualenvs/xxxxx-repo-name-xxxxx-hSP6Rt1H-py3.10/Lib/site-packages/pytest_resource_path/path_to_resource_factory.py",
	"owner": "_generated_diagnostic_collection_name_#2",
	"code": {
		"value": "reportGeneralTypeIssues",
		"target": {
			"$mid": 1,
			"path": "/microsoft/pyright/blob/main/docs/configuration.md",
			"scheme": "https",
			"authority": "github.com",
			"fragment": "reportGeneralTypeIssues"
		}
	},
	"severity": 8,
	"message": "Expression of type \"None\" cannot be assigned to parameter of type \"Path\"\n  Type \"None\" cannot be assigned to type \"Path\"",
	"source": "Pylance",
	"startLineNumber": 19,
	"startColumn": 43,
	"endLineNumber": 19,
	"endColumn": 47
}]

Logs

Python Language Server
pylance-language-server.log

@erictraut , so new problem, maybe? Closing the file does not remove the file from the "Problems" tab.
Reproduction

Use the default python.linting.ignorePatterns. Do not have python.analysis.ignore set.

"python.linting.ignorePatterns": [
  "**/site-packages/**/*.py",
  ".vscode/*.py"
]

from urllib.parse import urlparse
Right click urlparse and click "Go To Definition", this will open parse.py of the stdlib.
Close parse.py
Manually run Python linting even

I also have reproduced this simply by having Intellisense show type pydoc of modules but this is more difficult to reproduce.
Expected outcome

Pylance error for urllib\parse.py appears in the Problems tab until the file is close

Actual outcome

parse.py error are retained even after closing the file

pylance-language-server-urlparse-test.log

Can you show the diagnostics that you are seeing in parse.py after closing it? I suspect they are not from Pylance.

@Spitfire1900, are you sure that the diagnostics that remain in the Problems tab are generated by Pylance? I suspect that they're generated by some other extension that you have installed.
If you're sure that they're generated by Pylance, then yes, that's a bug that we should investigate. However, I'm not able to repro the problem from your repro steps.

I am available for additional logging or screen-share.

I've reproduced this issue using PyRight (with PyLance uninstalled)

I'm still unable to repro this in Pylance or Pyright.
@Spitfire1900, could you please set "python.trace.server": "verbose" in your settings.json, repro the issue, and then send us the resulting "Python Language Server" (for Pylance) or "Pyright" (for Pyright) log?
On my machine, when I close parse.py I see the following in the log which indicates that we have told VS Code that there are no longer any diagnostics for that file:
Background analysis message: setFileClosed
[Trace - 2:49:51 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///c%3A/Users/erikd/AppData/Local/Programs/Python/Python310/Lib/urllib/parse.py",
    "diagnostics": []
}

In the following test setFileClosed does not appear
Reproduction file:
from urllib.parse import urlparse
import requests

requests.get(urlparse("https://code.visualstudio.com/").geturl(), timeout=60)

Repo steps:

Right click urlparse
Click "Go to Reference"
Wait for errors for parse.py to appear
Close parse.py tab
Manual run linting with Ctrl+Shift+P shortcut

Errors are still visible in the Problems pane.
Version details:
Python: 3.10.7
Pylance: v2023.3.30
Poetry: 1.3.2
Windows: 10.0.19045 Build 19045 x64
Interesting tidbit: this also reproduced with extension id: charliermarsh.ruff with Pylance disabled and Jedi server enabled
[{
	"resource": "/c:/Program Files/Python310/Lib/urllib/parse.py",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "E402",
	"severity": 4,
	"message": "Module level import not at top of file",
	"source": "Ruff",
	"startLineNumber": 246,
	"startColumn": 1,
	"endLineNumber": 246,
	"endColumn": 35
}]

Which suggests this is an issue with tagging tabs as closed and updating the problems pane.
language server log.txt

The setFileClosed log output is probably due to some other setting I have enabled. I do see the following in your log which is what I would expect:
[Trace - 10:20:19 PM] Sending notification 'textDocument/didClose'.
Params: {
    "textDocument": {
        "uri": "file:///c%3A/Program%20Files/Python310/Lib/urllib/parse.py"
    }
}

[Trace - 10:20:19 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///c%3A/Program%20Files/Python310/Lib/urllib/parse.py",
    "diagnostics": []
}

But then immediately afterwards (in less than 1 second), parse.py is reopened and we report diagnostics for it. But I assume the file is not visually open?
[Trace - 10:20:19 PM] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "file:///c%3A/Program%20Files/Python310/Lib/urllib/parse.py",
        "languageId": "python",
        "version": 1,

...

[Trace - 10:20:19 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///c%3A/Program%20Files/Python310/Lib/urllib/parse.py",
    "version": 1,
    "diagnostics": [
        {
            "range": {
                "start": {
                    "line": 135,
                    "character": 20
                },
                "end": {
                    "line": 135,
                    "character": 40
                }
            },
            "message": "Cannot access member \"_encoded_counterpart\" for type \"_ResultMixinStr\"\n  Member \"_encoded_counterpart\" is unknown",
            "severity": 1,
            "code": "reportGeneralTypeIssues",
            "source": "Pylance",
            "codeDescription": {
                "href": "https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportGeneralTypeIssues"
            }
        },

...

Right click urlparse
Click "Go to Reference"
Wait for errors for parse.py to appear
Close parse.py tab
Manual run linting with Ctrl+Shift+P shortcut

Are you able to repro this without step 5? I assume you are referring to the Python: Run Linting command? I did this using Pylint and still was unable to repro this behavior.

I have verified that step 5 is not a requirement for reproduction.

I have verified that step 5 is not a requirement for reproduction.
language.server.log (no step 5).txt

In this log it appears that parse.py was never closed. Are you in fact closing the tab? Or perhaps just switching to another tab and leaving the parse.py tab open?

This is closing the tab.
https://user-images.githubusercontent.com/6462596/228359983-3ee77a74-4e68-4b90-99f8-18fd15fb7c2c.mp4

I've reproduced this on another associates workstation.

I'm still unable to reproduce this. Maybe it's related to some other extension that you have installed? Could you try disabling everything other than the Python and Pylance extensions in your workspace and see if the problem persists?

Great, thanks @Spitfire1900. Closing this issue.

I have reproduced this issues with genuitecllc.codetogether version v2023.1.0. Just having the extension enabled was causing issues.
Disabling the extension appears to have resolved issues.

@Spitfire1900 Thank you so much this was bugging me for months 💯
This also seems to be related to #4401, although I am not sure if these are caused by two separate things


ALEKernel masks data after convolution

This means that signal for coordinates outside of the mask will be included. Was this intended?

With #232 merged, this will be pretty easy to implement. I haven't reviewed GingerALE's code though, and the MATLAB implementation I've read shifted foci outside the brain to be just inside it. I just want to be extra-double sure that this is how it's supposed to work. @mriedel56 can you confirm?

Just looking at the MATLAB code now, it looks like coordinates are changed not during the ALE stage, but rather, when coordinates are imported. But, coordinates are changed to fit image dimensions, not necessarily the mask. So, given a standard space of 91x109x91, if a foci had image-space coordinates (45,61,104), it would be changed to (45,61,91). Since the edge of images are likely lost anyway during masking, seems like a non-issue.
Cant say what GingerALE does either, sorry.

Thanks @mriedel56. I guess we'll move forward with masking, and we can change to moving coordinates if we find out it's the way GingerALE does it.

GingerALE's implementation does not do anything to the coordinates that fall outside the mask. Yes, users receive a warning about these coordinates, but it's just letting them know that they're outside the mask, not that any steps are taken to address this. The coordinates are used in the analysis, but if they are too far out they likely don't contribute much. That is, the peak of their Gaussian is outside the mask but some part of the tail can be included.

Thank you @angielaird! I guess we should keep it as-is, then. I will close this issue, as well as #234.

A note about this: #320 heavily invests in the masking-after-convolution approach, since MA maps saved to files in the Dataset will be completely unmasked.


Update CODE_OF_CONDUCT.md

No description provided.

Code of Conduct is usually meant to be kept as provided by GitHub unless drafted specifically for a project


bootstrap vs material

Has any thought been given to using bootstrap as the base vs material?  Essentially, instead of using material2, use ngx-bootstrap?  While I think the material stuff is probably nicer, it seems like cbp-theme is a bootstrap theme with changes for material.  By using Material as the base, it's hard to reuse much of the cbp-theme at all.  You have to redo it to make it work for material.  I wonder if we used bootsrap as the base, if we'd be able to use more of the base cbp-theme.
Once cbp-theme moved to a material theme, we could then make the same change, and hopefully again be able to reuse most of the cbp-theme.  Thoughts?

My thoughts....
The impact on each of the consumers apps of ngx-cbp-theme would be much larger if ngx-cbp-theme  were to take a massive swing from bootstrap to material at some point later. This is how both the scenarios will span out.
bootstrap as baseline
In this scenario each consumer of ngx-cbp-theme application would have written their application extending ngx-cbp-theme and say ngx-bootstrap.
This means all the following code artifacts were written as follows:-

HTML markup, templates etc. are written with HTML tags
e.g.
<button type="button" class="btn btn-primary"Primary</button>
To convert the above to material you have to do this:-
<button md-raised-button color="primary">Primary</button>

Important point to be noted here is that each of the consumer apps/teams will have to take this effort  and change their end application as we move from bootstrap to material.

Application specific Components

Each application specific component would be written utilizing low level building blocks of ngx-bootstrap.
All these would have to re-written due to the move. Each application/team must have to take this effort causing too much repeated work by many.

SCSS files

All the namespaces, variables imported and utilized would be from bootstrap.
Migrating to material would mean change everything to mat- namespace with some combination of HTML tags and there may not be exact counterparts making this a much harder effort.
As cbp-theme moves to material ngx-cbp-theme will take a hit much later when the consumers have already used the older version of  ngx-cbp-theme which spirals another wave of changes downstream.
material as baseline
On the other hand in this scenario (where the current ngx-cbp-theme is headed) all the end consumer applications wold have already coded their markup, styles, application components using ngx-cbp-theme and material so no need to change anything other than

Update to newer ngx-cbp-theme so that the bootstrap hacks/look and feel removed from this version can be obtained.
e..g. Say one team has used cbp-accordion-lite in their app which looked like bootstrap earlier.  Now this looks more like material inspired as cbp-theme migrates. ngx-cbp-theme will shrink and get rid of bootstrap workarounds. Or  ngx-cbp-theme may just deprecate cbp-accordion-lite for md-accordion. Now all this team has to do is update their ngx-cbp-theme dependencies AND/OR replace cbp-accordion-lite with md-accordion.

This is far less impact for the consumer application.
Impact on ngx-cbp-theme project itself

ngx-cbp-theme would shrink as cbp-theme migrates to material as these workarounds cease to exist.
Useful components e.g. cbp-header written in material stays as it is. No work is wasted here.

Based on my discussion with cbp-theme members it is going to evolve more towards material but it might not happen in the immediate
There is another angle to this - we need to think about the following as well:-

Which cbp-theme components are going to be heavily used in the end consumer application ?
Are these more bootstrappy or more 'materialistic` :) ?

This is important to quantify/understand which direction is tactically better in reducing efforts.
I am expecting most of our consumer applications to be more Forms oriented. And most Forms are material inspired. angular/material2 forms match exactly what we have in cbp-theme today. Also a developer of consumer of ngx-cbp-theme may choose certain components wisely e.g. favor material inspired select than using select2 flavored select.
In the long run it is harder to transition bootstrap->material than biting the bullet now.
My thinking is that these workarounds are allowed to be be hacky to a certain degree as long as they don't sacrifice the runtime and force the end consumer applications to a path that requires much work later on.

I agree with much of what you say.  The key though, is if/when cbp-theme will move from a bootstrap based theme to an material theme.  With everyone implementing bootstrap, it may be hard for cbp-theme to move away from bootstrap due to the cost of everyone having to update their apps as you've pointed out.  One thing that could happen is that cbp-theme completely materializes their bootstrap theme vs moving to material itself so as to reduce the cost of everyone having to update.  If that were to happen, we'd not be able to benefit much at all.  We'd be in the same boat now, if not worse, where we basically have our own material theme for angular which we continually need to update to keep pace with cbp-theme.
I much prefer material2 to ngx-bootstrap; I think the components are much nicer and it has a great community around it with angular devs.  However, it seems risky with a lot of duplicate effort of us trying to match the current theme in hopes that they'll move to material.  If they were currently working on a material branch, it wouldn't be an issue.
That's my 2 cents.  We can continue to follow this path, but wanted to voice my concerns.

Got busy/caught in some issues to respond to another excellent concern raised above which I will attempt to address further below. I must say that we need to document these in a better way - update the readme.md to  link to another document that addresses these concerns. Also some of the reasoning behind got buried in our internal discussions and another document before starting this repository :) hence the assumptions did not make it into the ant of the readme.md or the contributing.md I will start a new document as time permits.

cbp-theme materializes their bootstrap theme vs moving to material

Here I am assuming that cbp-theme is either replacing bootstrap with Materialize OR it replaces it with Material Design Lite which it is already using.
My thoughts are as below:-
All these libraries
Materialize
Material Design Lite
Material-UI (react)
Material2 (angular)
are only a means to achieve the ultimate specifications from Google Material
These libraries are merely there so that that individual applications can attain the Material specs.
For example the React developers created Material-UI (react) so that Reach applications can achieve Material specs.
Similarly Angular team created Material2 (angular) so that Angular apps can do the same. Just as AngularJS created [Material angularJS](https://material.angularjs.org} for the Angular < 2 users.
This perspective to bring forth 2 key points that:-

All these libraries are striving to the same exact specifications : The Google Material which are only specifications i.e. width, height, colors, contrasts, how all that should respond on different devices etc. These specifications must be implemented by someone to bring to life.

So one might assume that only one implementing library written in pure Javascript and CSS would suffice ?  But yet we have so many libraries. This brings to the next point.

Native components

Yet so many component libraries exist to solve this problem because they all offer components that are native to their framework.
Quoting straight from Material Design Lite

Material Design Lite lets you add a Material Design look and feel to your websites. It doesn’t rely on any JavaScript frameworks and aims to optimize for cross-device use, gracefully degrade in older browsers, and offer an experience that is immediately accessible. Get started now.

and yet we have Material-UI (react)
Material2 (angular). This is because a certain class of applications can't scale without the components being native.
It is fair to say that native components will deliver better performance.
Easier to understand at runtime and hence easier to debug.
CSS/SCSS development becomes far less hacky than "override this/that from this/that".
Browser don't need to perform too many computations.
Throwing competing libraries in these applications is opening to a very complex runtime where the components runs, behave and render in a way which become very difficult to fathom. Hence the proliferation of so many libraries to achieve the same end goal : Material Specs.

If that were to happen, we'd not be able to benefit much at all. We'd be in the same boat now, if not worse, where we basically have our own material theme for angular which we continually need to update to keep pace with cbp-theme.

This is true only if cbp-theme diverges from Material Specs.
Bottom like is whenever cbp-theme will have any customization ngx-cbp-theme or another React version of it will get impacted this is because cbp-theme just like other UI libraries cannot cater to all the frameworks all at once. Hence the birth of ngx-cbp-theme.
I could be wrong in some assumptions or missing any supporting or opposing points. If the reasoning is satisfactory or if need to change something ideas are welcome. I will wait for a response/pm before I close since we are all so busy with so many things.

doc updated https://github.com/US-CBP/ngx-cbp-theme/commit/f197d976aff2f4e67f74fe3c3c6ae3d371d3136b


Cleanup ports and resources in runtime - fix resource leak

Brief feature description
Publisher, Subscriber, Runnables and other resources can be allocated in the shared memory via roudi runtime calls like getMiddlewarePublisher. But there is no way of freeing those resources.
This is essential since the resources are allocated by our classes in our public API and when they go out of scope we have a resource leak inside of the shared memory.
RouDi cleans up resources only when the application terminates but inside of the process we have a resource leak.
Detailed information
We require the implementation, integration into the public classes and tests for the following roudi runtime methods

[ ] cleanupMiddlewarePublisher()
[ ] cleanupMiddlewareSubscriber()
[ ] cleanupMiddlewareApplication()
[ ] cleanupMiddlewareInterface()
[ ] cleanupMiddlewareConditionVariable()
[ ] cleanupRunnable()

The old API uses the destroy() call in the d'tor. Then the discovery loop will do the job. like here
You haver to call it also for the new public API classes @elfenpiff @ithier. These cleanup calls wpould be another option, both have pros and cons. If you do the cleanup approach you have to be careful not to destroy e.g. subscribers that are still conneczted with publishers. The destroy flag approach handles all of this but delays the actual destroy till the next discovery loop

Adding destroy logic to the destructors makes sense to me.
When else would a user application want to clean up the e.g.  PublisherPortUser"? So, we should add destroy` methods to the ports so the public entities (publishers, subscribers etc.) can do this.

I guess you have it in the Base Pott, so the d'tors of the public API classes can call it on the port objects they have

We have to take care of all resources: Ports(Publisher, Subscriber, Application, Interface), Condition Variables, Runnables and the Runtime. I'll update this issue and we will address them all. E.g. the Runtime does not signal to RouDi when it is destroyed and we need the monitoring to start cleaning up things


Iteration 1 Submission

Iteration page: here
What To Do:

[x] Feature scenarios/tests passing
[x] Iteration page updated, including:

[x] Iteration retrospective
[x] Client review- not currently
[x] Issues updates
[x] Section on application of course materials

[x] git tag
[x] Next iteration:

[x] Open page
[x] Select stories and plan issues
[x] Test scenarios

[x] All engineers filled peer-review
[x] Submitted

[x] Announcement in chat room
[x] Assign this issue to checker
[x] Register for a review meeting

I re-opened this issue for re-submission. thanks!

Checked

@robi-y We changed the docs but grade didnt change.

Checked


Hide/show specific items

This issue is for the external plugin: inventory-summary
It would be interesting to have a black-/white list for specific items.
That way only loot and stuff like farming supplies can be shown, instead of switchables, runes, teletabs, etc.

Added in 73899cf02c12abc21f12f9af073ff6452fdbcf06 (would have been #36 if I didn't screw up the commit :d )


Respect ignoredFiles when using the FUSE mount

There is a setting in client-config.json which is used by camput to decide which files
should not be uploaded. This flag is not respected when copying files through the
mounted FUSE volume.

Just like camput, the policy will be applied to files, directories and symlinks.

An open question is if returning nil as the fs.Node is problematic.

What about allowing the writes to a FUSE-local buffer, but preventing them from propagating to the main store? I think the main issue would be getting the writes in the buffer indexed. This buffer could then be used to filter out other unwanted writes such as rsync's many short-lived temp files.

Basically the same issue #419


load assets from an object implementing Read

as mentioned in #606, my goal is mainly to be able to bundle PNGs for textures in the binary.
I added 3 functions to AssetServer:

load_sync_from<T: Resource>(&self, assets: &mut Assets<T>, read: &mut dyn std::io::Read) -> Result<Handle<T>, AssetServerError> that allows the user to synchronously load something that implements Read. This function will try all loader for T until one works.
load_from<T: Resource>(&self, read: Box<(dyn std::io::Read + Send + 'static)>) -> Result<Handle<T>, AssetServerError> that allows the user to asynchronously load something that implements Read. The object must be Boxed to be sent between threads. This function will only try the first loader for T
and load_with_hint_from<T: Resource>(&self, read: Box<(dyn std::io::Read + Send + 'static)>, extension: &str) -> Result<Handle<T>, AssetServerError>, same as the above with the possibility to provide the extension that match the object being loaded to help type resolution. This function will not use the loader deduced from T but from the extension provided.

To be able to load an image without providing its path, I also had to modify the AssetLoader implementation for ImageTextureLoader to not use the path to check the extension. The only other AssetLoader that uses the path when loading is GltfLoader, but it seems like it's actually needed in this case.
I am also not sure how to implement this loading in the wasm case, which I left as unimplemented!() for now but would welcome pointers on how to do it (here)

This seems reasonable for the current bevy_asset implementation, but we are very close to merging a pretty major asset system rework that will change a lot of the interfaces and assumptions. I think we should hold off on this scenario until the new system is merged.

Nice, I'll look into how to adapt this for the next asset system if it doesn't already have it then 👍
I think it's an important feature when you need a very easy and error proof installation

(response copied from #624)
This approach won't work now that asset loaders can produce multiple asset types. I think we can achieve similar results in atelier-assets, which plans on adding "asset pack-file" support. These packfiles could theoretically be embedded directly into the binary and would probably be a better general-purpose solution to the problem.
I think we should close this out, then re-visit the scenario when atelier-assets is integrated, but I'm curious to hear your thoughts.

yeah the few use cases I wanted to have seems significantly harder to do now... my main issue to implement them is that AssetServer and AssetIo are pretty much file system bound...
what I wanted:

ability to load assets from bytes and from the network (reading from Read would have meant been generic over those)
ability to piggyback on the asset system to load asynchronously generated assets (reading from Read would have make this possible by implementing a Read that would generate the asset)

I'll try to find a way, I don't think the "one load request -> multiple asset types" should be an issue for those cases


nerdctl build is failed with Error (dial tcp: lookup distrib on 135.xx.xx.xx:53: no such host)

Description
Hi Team,
I was trying to build the image with nerdctl build command and its failed with below error:
#3 [internal] load metadata for distrib:5000/img-3ppextent-22.12.0:8
#3 ERROR: failed to do request: Head "https://distrib:5000/v2/img-3ppextent-22.12.0/manifests/8": dial tcp: lookup distrib on 135.xx.xx.xx:53: no such host
nerdctl version:
nerdctl -v
nerdctl version 0.17.0
OS: Red Hat Enterprise Linux 8.6 (Ootpa)"
Steps to reproduce the issue

Describe the results you received and expected
Image build failed while I was expecting the image build should be successful
What version of nerdctl are you using?
nerdctl -v
nerdctl version 0.17.0
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

Can you try the latest version (v1.1.0)?
Also please provide whether rootless or rootful.

I tried with the root user. Let me check with v1.1.0 as well.

I tried with the v1.1.0 but getting the same error
# ./nerdctl -v
nerdctl version 1.1.0

# ./nerdctl  build --no-cache --progress=plain --build-arg fromImageRepository='distrib:5000/img-3ppextent-22.12.0' --build-arg fromImageTag='8' --build-arg ReleaseVerse='user-admin-22.12.0:425 | 2023-01-17 17:52:43 IST' --tag 'distrib:5000/user-admin-22.12.0:425' --file '/repo/img-sw-22.12.0-623220927/user-admin/user-admin-22.12.0-425/Dockerfile' '/repo/img-sw-22.12.0-623220927/user-admin/user-admin-22.12.0-425/'                                                           #1 [internal] load .dockerignore
#1 transferring context: 2B done
#1 DONE 0.0s

#2 [internal] load build definition from Dockerfile
#2 transferring dockerfile: 5.27kB done
#2 DONE 0.0s

#3 [internal] load metadata for distrib:5000/img-3ppextent-22.12.0:8
#3 ERROR: failed to do request: Head "https://distrib:5000/v2/img-3ppextent-22.12.0/manifests/8": dial tcp: lookup distrib on 135.xx.xx.xx:53: no such host
------
 > [internal] load metadata for distrib:5000/img-3ppextent-22.12.0:8:
------
Dockerfile:4
--------------------
   2 |     ARG fromImageRepository
   3 |     ARG fromImageTag
   4 | >>> FROM ${fromImageRepository}:${fromImageTag}
   5 |

--------------------
error: failed to solve: distrib:5000/img-3ppextent-22.12.0:8: failed to do request: Head "https://distrib:5000/v2/img-3ppextent-22.12.0/manifests/8": dial tcp: lookup distrib on 135.xx.xx.xx:53: no such host
FATA[0000] no image was built

Does nslookup distrib work?

This image is available in local cache of nerdctl ... we first load this image tar into cache using nerdctl load -i .tar then use this image name as base image to add more packages and build new images from it.

Does the containerd worker work? https://github.com/containerd/nerdctl/blob/v1.1.0/docs/build.md
# /etc/buildkit/buildkitd.toml
[worker.oci]
  enabled = false

[worker.containerd]
  enabled = true
  namespace = "default"

Yes its working
# cat /etc/buildkit/buildkitd.toml
[worker.oci]
  enabled = false

[worker.containerd]
  enabled = true
  namespace = "k8s.io"

# ps -ef | grep buildkitd
root      655639       1  0 16:14 ?        00:00:00 /usr/local/bin/buildkitd --oci-worker=false --containerd-worker=true --containerd-worker-addr=/run/containerd/containerd.sock

Hi AkihiroSuda,
Could you please suggest some way forward as issue is not yet resolved its just containerd is up and running on the node.
any help would be appreciated.
Regards,
Amit

Probably this should be reported to https://github.com/moby/buildkit/issues

@amitbhatia1987 I am curious about the answer to this question "Does nslookup distrib work?" or try dig. I asked the same question with no response.

Hi @MikeZappa87:
nslookup or dig won't work as this is a local cache image. Please find the output below
# nslookup distrib
Server:         135.xx.xx.xx
Address:        135.xx.xx.xx#53

** server can't find distrib: NXDOMAIN

# dig distrib

; <<>> DiG 9.11.36-RedHat-9.11.36-3.el8 <<>> distrib
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 8095
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;distrib.                       IN      A

;; AUTHORITY SECTION:
.                       10788   IN      SOA     a.root-servers.net. nstld.verisign-grs.com.<PHONE_NUMBER> 1800 900<PHONE_NUMBER>0

;; Query time: 0 msec
;; SERVER: 135.xx.xx.xx#53(135.xx.xx.xx)
;; WHEN: Wed Jan 25 08:58:34 IST 2023
;; MSG SIZE  rcvd: 111

@AkihiroSuda : I have raised the bug on buildkit (https://github.com/moby/buildkit/issues/3532)


Empty HTTPS_PROXY variable in env

Describe the bug
In freerdp 3.2 versions, defining empty variables as HTTPS_PROXY/https_proxy makes freerdp believe that there is a proxy configured in the environment and fails to launch it.
For example:
/u:test /title:"Test" /d:test.test /smartcard /p:"test" /v:localhost:3389 /size:100%  /cert:ignore

part of the env command output:
HTTPS_PROXY=
https_proxy=
I have verified that by unsetting these variables, freerdp can now connect to the server directly without problems.
For me, this is a irregular behavior in parse environment variables and I wonder if allowing definition of those empty variables could be resolved.
Application details
This is FreeRDP version 3.2.0 (3.2.0)
/u:test /title:"Test" /d:test.test /smartcard /p:"test" /v:localhost:3389 /size:100%  /cert:ignore
OS version connecting to (server side)
Windows Server 2008R2
OS: Fedora
Version/Distribution: 33 with openbox
Architecture: amd64

https://github.com/FreeRDP/FreeRDP/pull/9929

ERRCONNECT_DNS_NAME_NOT_FOUND

then something in your env is wrong?
just did test with current master:
test server:

set up Xepyr :23 -screen 1280x768
DISPLAY=:23 xterm&
DISPLAY=:23 openbox&
DISPLAY=:23 freerdp-shadow-cli /port:3333 -auth

connect with:

export HTTPS_PROXY="" to have an empty proxy variable
connect with xfreerdp /v:localhost:3333 /u:foo /p:bar /d:dom /title:test ... (all your arguments)
et voila! connection established...

I just saw that my build was not updated, sorry for that, I do connect with empty variables, thanks again


Escape db & table name on removeSourceTables

Description
The db and table names aren't escaped when the --rename-tables option is used on vtctlclient movetables and the db and/or table names contain dashes
https://github.com/Shopify/vitess-project/issues/367\#issuecomment-1270145452
Related Issue(s)
N/A
Checklist

[ ] "Backport me!" label has been added if this change should be backported
[ ] Tests were added or are not required
[ ] Documentation was added or is not required

Deployment Notes
N/A

Tested locally, was able to reanme tables even on a keyspace that had dashes in the name.


Upgrade dependencies to support serverless v3

Is the package out of maintenance or deprecated? The last release was two years ago, and it throws dependency errors when upgrading to serverless version 3. I would be really thankful if there was a way to make the package compatible with the latest serverless version.
Thanks

Will be releasing this shortly!


Made Compatible With Android

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

This PR is on hold for the time being until perf tests could be conducted, and any Hikari dependency issues could be sorted.

@Gathika94, we are close this PR because of the following two valid reason:

The HikariCP-java7 is not the latest version and its now in the maintenance mode.
We didn't find any value addition by moving the Java API for XML to com.fasterxml.jackson package. Also, the usage of XML file unmarshaling is a one-time task.

Thanks for bringing this to the discussion.


dose Phaser 3 support Spine？

We're constantly trying to make Phaser 3 better
So we'd love to hear about feature requests for the v3 API. Screenshots, example code or links to blog posts / other APIs are encouraged.
Please try and keep the requests sensible. We will only keep those we feel are within our abilities to add to Phaser, or that are a good fit for our API.
[Optional] Do you want to help provide this feature?
If you would like to get involved in helping build the feature, please let us know. We can then discuss implementation with you and the best way to approach it. Again, screenshots or mockups are really useful.

Full support for Spine will be available when Phaser 3.16 is released.


Remove allowed_users key from uwhackweeks

When using GitHub Org or Teams authentication, you MUST NOT provide the allowed_users key in the helm chart config. Since enabling allowed_users will block access to anyone who has not been added via the admin panel even if they are valid members of the team. In this case, it is NOT TRUE that anyone on GitHub will be able to login  without the allowed_users key.
This behaviour is documented in the Note block under step 3 in our docs here: https://infrastructure.2i2c.org/en/latest/howto/configure/auth-management.html#native-jupyterhub-oauthenticator-for-github-orgs-and-teams
This PR should resolve the authentication issues discussed by @scottyhq here: https://github.com/2i2c-org/infrastructure/issues/962#issuecomment-1032871676

This has been deployed, waiting for Scott to confirm this resolves his issue

Are these the kinds of things we could add checks for in a validation step? Like
if (github teams auth):
  ...make sure that `allowed_users` is not set, raise error if it is
elif (normal auth0 auth):
  ...make sure that `allowed_users` *is* set, raise error if it is not

@choldgraf Absolutely

Nice catch @sgibson91!
Failed to make a comment as intended alongside the approval - it would be good to have an inline comment about not setting allowed_users. In the past, we learned we sometimes require it to be set alongside admin users and now we sometimes must not have it - tricky. I like the pattern of having a note about this inline in the config, even though it could be documented centrally. It could be a reference to that central documentation as well. Just some reminder note where its relevant.


Missing documentation

The link to the documentation (http://google.github.io/google-api-python-client) points to an error 404. Where can I find the documentation?

The domain should be googleapis.github.io.  That leads to the docs link:
http://googleapis.github.io/google-api-python-client/docs/epy/index.html


Share the source of bauncms.com as illustration of how to use Baun

The readme here states:

Demo: The bauncms.com site is built using Baun.

In that case, it'd be nice that you shared the source for bauncms.com to illustrate how to accomplish that with Baun.

Ouch. I see that it is already available at https://github.com/BaunCMS/Site


Big_tiff

 Immer BigTiff verwenden

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

66 of 68 (97.06%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 85.299%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/src/handlers/wcs.rs
0
1
0.0%

services/src/handlers/workflows.rs
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
29301

Relevant Lines:
34351

💛  - Coveralls

bors merge