Differentiation between per user and system wide modifications

Hi,
Is there any way of knowing which tweaks (even comment markers in the code would be a good enough first step) apply on a per user basis rather than a per system basis? I guess this is related to #243.
Background: As I'm shortly going to be setting up a home machine, I've been experimenting with configuring Windows in a VM, initially controlled by a set of Ansible scripts. While I can create additional users via that, I suspect I'd need to do an initial login to get the 'first setup' of that user complete before running any 'per user' scripts.
Also, if other additional users are non-administrator child accounts would any of the tweaks apply/not apply to them ?

Apart from #243 it's related also to #5 and #29.

Is there any way of knowing which tweaks apply on a per user basis rather than a per system basis?

Rule of thumb is that tweaks that modify HKLM are per-system, tweaks that modify HKCU are per-user (although some may require admin privileges as they touch protected GPO keys). Installation/uninstallation of AppX is per-user, Installation/uninstallation of everything else is per-system.

I suspect I'd need to do an initial login to get the 'first setup' of that user complete before running any 'per user' scripts.

Currently, yes. There's some discussion about modifying the default registry hive in one of the linked tickets, but I don't intend to add such functionality anytime soon, as this is something what should rather be done via installation media customization (sysprep). Windows do a lot of stuff during the first setup, so some tweaks would be even completely ignored in this scenario.

if other additional users are non-administrator child accounts would any of the tweaks apply/not apply to them ?

That's a trick question. Virtually all tweaks would apply to them, but you're probably asking which tweaks can be applied by them. In that case only the tweaks which don't require admin privileges can be applied to/by such users. If you try to use RequireAdmin, the elevation mechanism will cause the tweaks to be applied to the impersonated (admin) account instead of the non-admin user. But then again, most of the tweaks which require admin privileges are per-system and would affect also the non-admin users.

Apart from #243 it's related also to #5 and #29.

Is there any way of knowing which tweaks apply on a per user basis rather than a per system basis?

Rule of thumb is that tweaks that modify HKLM are per-system, tweaks that modify HKCU are per-user (although some may require admin privileges as they touch protected GPO keys). Installation/uninstallation of AppX is per-user, Installation/uninstallation of everything else is per-system.

Great thanks. I'll take a look at the code to see which does which. It might be useful to provide grouping?

I suspect I'd need to do an initial login to get the 'first setup' of that user complete before running any 'per user' scripts.

Currently, yes. There's some discussion about modifying the default registry hive in one of the linked tickets, but I don't intend to add such functionality anytime soon, as this is something what should rather be done via installation media customization (sysprep). Windows do a lot of stuff during the first setup, so some tweaks would be even completely ignored in this scenario.

Thats fine. Even if I run the ansible scripts, perform a login manually then rerun on the other user then its still better than doing everything manually! :-D

if other additional users are non-administrator child accounts would any of the tweaks apply/not apply to them ?

That's a trick question. Virtually all tweaks would apply to them, but you're probably asking which tweaks can be applied by them. In that case only the tweaks which don't require admin privileges can be applied to/by such users. If you try to use RequireAdmin, the elevation mechanism will cause the tweaks to be applied to the impersonated (admin) account instead of the non-admin user. But then again, most of the tweaks which require admin privileges are per-system and would affect also the non-admin users.

Actually no, apologies for not making it clear enough. I'm still reading up on it, but while the admin level accounts I think I can create them as local accounts, I suspect creating the child accounts as full microsoft accounts would be preferable to get the benefit of cross-device monitoring/protection. I wouldn't want them to run the scripts, but simply be able to set up their UI to make it simpler - and hence wondering whether there are any implications if the accounts are not 'local' as such?

It might be useful to provide grouping?

The tweaks are already grouped thematically, so adding another dimension would just make things more confusing. But one day in the distant future, there will be a wiki #225, which will contain this info. And in even farther future possibly also a version of the script which will handle also all accounts and the default user registry hive.

...microsoft accounts...

You can still choose if the account will have the admin privileges (will be a member of local admin group) on the device or not. Although I personally haven't tested it, there seems to be a decent amount of users of this script and I have yet to hear about any substantial problems related to Microsoft accounts. I don't know exactly which parts are subject of roaming, so I'm unable to answer if the setting will be carried over between the devices, but other than that there aren't any special implications to Microsoft accounts. The only thing which comes to mind is that there are some tweaks impacting synchronization and sharing (DisableSharedExperiences, DisableActivityHistory) so you may want to not apply those.

It might be useful to provide grouping?

The tweaks are already grouped thematically, so adding another dimension would just make things more confusing. But one day in the distant future, there will be a wiki #225, which will contain this info. And in even farther future possibly also a version of the script which will handle also all accounts and the default user registry hive.

Yes I see in Default.preset

...microsoft accounts...

You can still choose if the account will have the admin privileges (will be a member of local admin group) on the device or not. Although I personally haven't tested it, there seems to be a decent amount of users of this script and I have yet to hear about any substantial problems related to Microsoft accounts. I don't know exactly which parts are subject of roaming, so I'm unable to answer if the setting will be carried over between the devices, but other than that there aren't any special implications to Microsoft accounts. The only thing which comes to mind is that there are some tweaks impacting synchronization and sharing (DisableSharedExperiences, DisableActivityHistory) so you may want to not apply those.

Yes, the plan is to have both adults with admin level permissions. And the child accounts are a work-in-progress ... its a 'learning experience' :-D
Thanks very much for your answers... the ansible script is starting to work (for a VM at least) - https://github.com/rnc/nicks-shell/tree/master/ansible-windows
One final question for this - while I can see from Default.preset that some settings are enabled by default, am I correct in thinking that Windows defaults is for everything enabled/installed?

while I can see from Default.preset that some settings are enabled by default, am I correct in thinking that Windows defaults is for everything enabled/installed?

Windows defaults are the ones in the second column of Default.preset. The functions in the first column apply the modifications deviating from the default, the functions in the second column restore the same settings to the default values. Some tweaks have also third column for cases where there are more options than just do / undo.
Some of the tweaks are commented in the file because they're not suitable for everyone. The tweaks which are enabled by default are curated by years of experience and user requirements, but those are my years or experience and my users, so your mileage may vary. You're definitely encouraged to read through FAQ and the script itself and create a preset suiting your needs. You may even supply your own tweaks, if needed.

Perfect, thanks!


Flow chart of work flows ~~~

All the Beacon workflows ~~~

City staff & OMB workflows for creating, editing, and publishing opportunities: https://docs.google.com/drawings/d/1TCFdlqI94v_M_ekg13NDGG6LHaC-50FxUyEW5u_wEBw/edit

Can we close this @shellicious ?


OpenWebRTC returns the same priority number multiple times

When getting ICE candidates on a data session (not sure if its specific to data sessions), candidates with the same IP vs. different methods use the same priority number. This is a violation of RFC 5245, section <IP_ADDRESS>.
To quote:
More generally, if there are multiple candidates for a
particular component for a particular media stream that have the same
type, the local preference MUST be unique for each one.
Firefox catches this and throws an ICE error, and only accepts the first candidate it got with a given priority (according to about:webrtc). As for Chrome; it appears to not care.

Here's an offer/answer reply from Firefox to a OpenWebRTC client. Rereading the specification and the code, I'm not sure anymore who's erring here, us, libnice (where the priority number comes from), or Firefox. I'm willing to write a patch, but I'd like to patch the right thing :)
Received : {"type":"offer","data":{"sdp":{"version":0,"originator":{"username":"mozilla...THIS_IS_SDPARTA-42.0","sessionId":"1401626202004890786","sessionVersion":0,"netType":"IN","addressType":"IP4","address":"<IP_ADDRESS>"},"sessionName":"-","startTime":0,"stopTime":0,"mediaDescriptions":[{"type":"application","port":9,"protocol":"DTLS/SCTP","netType":"IN","addressType":"IP4","address":"<IP_ADDRESS>","mode":"sendrecv","ssrcs":[1020872779],"cname":"{975deacb-b134-4f9e-8fab-e28083e3155a}","ice":{"ufrag":"d3fafa13","password":"df067a1c07ea982898362d2993330855","candidates":[{"foundation":"0","componentId":1,"transport":"UDP","priority":2122121471,"address":"<IP_ADDRESS>","port":52857,"type":"host"},{"foundation":"1","componentId":1,"transport":"UDP","priority":2122187007,"address":"2001:470:1f07:10f5:f087:a139:aad0:9d43","port":42169,"type":"host"},{"foundation":"2","componentId":1,"transport":"UDP","priority":2122252543,"address":"2001:470:1f07:10f5:3285:a9ff:fe3c:9d99","port":56061,"type":"host"}]},"dtls":{"fingerprintHashFunction":"sha-256","fingerprint":"77:DA:AF:36:E7:4C:7A:21:A7:EB:D4:A9:62:26:11:F5:52:27:6A:66:40:FF:C1:C5:03:C8:A1:53:37:C7:55:45","setup":"actpass"},"sctp":{"port":5000,"app":"webrtc-datachannel","streams":256}}]}}}
1E:FA:8E:9B:92:C6:42:D4:D8:0F:73:1C:35:F2:D1:34:B5:DE:9D:37:02:3C:63:49:E4:72:B7:F8:78:F7:EE:8C
1E:FA:8E:9B:92:C6:42:D4:D8:0F:73:1C:35:F2:D1:34:B5:DE:9D:37:02:3C:63:49:E4:72:B7:F8:78:F7:EE:8C
Answer: {"type":"answer","data":{"sdp":{"mediaDescriptions":[{"ice":{"ufrag":"/W/f","password":"hIx9cBNpfm7OaZ2ai/XhX7"},"type":"application","protocol":"DTLS/SCTP","addressType":"IP4","address":"<IP_ADDRESS>","candidates":[{"foundation":"2","componentId":1,"priority":2013266431,"address":"2001:470:1f07:10f5:3285:a9ff:fe3c:9d99","port":5033,"type":"host"},{"foundation":"3","componentId":1,"priority":1019216383,"address":"2001:470:1f07:10f5:3285:a9ff:fe3c:9d99","port":0,"type":"host","tcpType":"active"},{"foundation":"4","componentId":1,"priority":1015022079,"address":"2001:470:1f07:10f5:3285:a9ff:fe3c:9d99","port":5034,"type":"host","tcpType":"passive"},{"foundation":"5","componentId":1,"priority":2013266431,"address":"2001:470:1f07:10f5:f087:a139:aad0:9d43","port":5026,"type":"host"},{"foundation":"6","componentId":1,"priority":1019216383,"address":"2001:470:1f07:10f5:f087:a139:aad0:9d43","port":0,"type":"host","tcpType":"active"},{"foundation":"7","componentId":1,"priority":1015022079,"address":"2001:470:1f07:10f5:f087:a139:aad0:9d43","port":5075,"type":"host","tcpType":"passive"},{"foundation":"8","componentId":1,"priority":2013266431,"address":"<IP_ADDRESS>","port":5032,"type":"host"},{"foundation":"9","componentId":1,"priority":1019216383,"address":"<IP_ADDRESS>","port":0,"type":"host","tcpType":"active"},{"foundation":"10","componentId":1,"priority":1015022079,"address":"<IP_ADDRESS>","port":5031,"type":"host","tcpType":"passive"}],"sctp":{"port":5000,"app":"webrtc-datachannel","streams":1024},"dtls":{"fingerprintHashFunction":"sha-256","fingerprint":"1E:FA:8E:9B:92:C6:42:D4:D8:0F:73:1C:35:F2:D1:34:B5:DE:9D:37:02:3C:63:49:E4:72:B7:F8:78:F7:EE:8C","setup":"active"}}]}}}

My understanding is that the priorities must be unique, and that libnice (if they aren't) doesn't do the right thing. That Chrome accepts that doesn't mean it's right.

Perhaps @ocrete knows.

Ooops, this is definitely wrong in libnice. The "lazy" solution is to just add a local counter in  nice_candidate_ice_local_preference() and set it in the lower bits of the preference... Patches welcome. I guess the "better" solution includes trying to get more information from the OS in nice_interfaces and passing it around...

@sdroege - can someone patch this up please?

@alessandrod : perhaps this issue is also quick to fix?

This should be fixed upstream in libnice. Although I have a slightly more correct patch in my dev branch that I will commit when I have time to untangle the whole thing.

@ocrete - of course, all the issues should be fixed upstream in libnice and everything will be upstreamed as long as it's not too hacky to be. :) I'll take a look at the changes since what we're using and master and see if it's a good idea to bump.

This is fixed upstream now.


miss placed space in include header

...

Hello,
I'm not sure what you're talking about. I suppose meant that the L3 is not handled well so i did a rework on that feature.
Best regards, Justin.

Hello,
I'm not sure what you're talking about. I suppose you meant that the L3 error is not handled well so i did a rework on that feature.
Best regards, Justin.


GraphQL issues with real strain data (details page)

GraphQL query

query {
  strain(id: "DBS0238532") {
    id
    label
    names
    systematic_name
    characteristics
    summary
    genetic_modification
    genotypes
    mutagenesis_method
    species
    parent {
      id
      label
    }
    depositor
    plasmid
    dbxrefs
    genes
    in_stock
    phenotypes {
      phenotype
      note
      assay
      environment
      publication {
        authors {
          last_name
        }
        id
        pub_date
        title
        journal
        volume
        pages
      }
    }
  }
}

GraphQL response

{
  "data": {
    "strain": {
      "id": "DBS0238532",
      "label": "Dictyostelium discoideum",
      "names": [],
      "systematic_name": "γS13",
      "characteristics": [
        ""
      ],
      "summary": "Radiation-sensitive mutant.",
      "genetic_modification": "",
      "genotypes": [
        ""
      ],
      "mutagenesis_method": "",
      "species": "",
      "parent": null,
      "depositor": "",
      "plasmid": "",
      "dbxrefs": [],
      "genes": [
        ""
      ],
      "in_stock": true,
      "phenotypes": []
    }
  }
}

ArangoDB query response

[
  {
    "_id" : "stock/DBS0238532",
    "_key" : "DBS0238532",
    "_rev" : "_ZCj2yhW--_",
    "created_at" : "2007-09-14T09:37:07.000Z",
    "created_by"<EMAIL_ADDRESS>    "dbxrefs" : [ ],
    "depositor" : "",
    "editable_summary" : "",
    "genes" : [
      ""
    ],
    "publications" : [
      "5466867",
      "4536935",
      "1033268"
    ],
    "stock_id" : "DBS0238532",
    "summary" : "Radiation-sensitive mutant.",
    "updated_at" : "2008-09-11T10:40:35.000Z",
    "updated_by"<EMAIL_ADDRESS>    "strain_properties" : {
      "label" : "γS13",
      "species" : "Dictyostelium discoideum",
      "plasmid" : "",
      "names" : [ ]
    }
  }
]

Known issues between GraphQL response and ArangoDB response:

[ ] Systematic name is "γS13" in both, not "ys13"
[ ] Depositor is empty in both
[ ] Need to update GraphQL query to get publications list
[ ] GraphQL response incorrectly puts species ArangoDB response into label
[ ] GraphQL response incorrectly puts label ArangoDB response into systematic_name

It also will sometimes crash arango-deployment-operator and other pods after issuing this GraphQL query.

Ongoing work related to these issues can be found in fix/graphql-issues

Updated individual strain query to fetch publications
Removed annotation fields from strain query for now

More frontend work:

[ ] Fix publications display (remove icons for now, use numbers)

Parent and depositor fields are expected to be missing right now, so that is fine.


Add models and migrations for user, image, map, trail.

Add better_errors to gemfile
Set up application_controller for :null_session.

Looks great.  What does "better errors" do? :+1:

better_errors is a gem for Rails that displays errors better :+1:  also, I forgot to add another gem that lets you debug rails with a console. for next time!


eslint: alphabetize rules

it was getting ridiculous, and my OCD couldn't take it.

my OCD made me copy the lists out and run them through a sort to compare them.  they're (of course) the same and this is green, so merging...


Group Type is missing

It took me about 3 hours to overcome this tiny thing... ;o) "Security" group type does not work...little bit illogical, isn't it?
Thanks, Jan

Hi @janvars, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@mahesh-unnikrishnan - Mahesh, please review this PR in the public repo from @janvars and let @BryanLa know if it can be merged. Thanks.

@janvars  - could you please email us using the link (https://azure.microsoft.com/en-us/documentation/articles/active-directory-ds-contact-us). The 'security' group type should work and we'd like to investigate and see why this isn't working for your tenant.
Thanks!

@mahesh-unnikrishnan - Should we close or merge the text update?

Please close this PR.


When postgres is not an aurora it is giving error in the execution of agent

What does this PR do?
On postgres servers that are not aurora it is giving the following error in the log: "ERROR: function aurora_version () does not exist at character 8". From now on it will only be checked if there is a function, if there is, it is understood that it is an aurora.
Motivation
Because my Postgres servers (which are not aurora) in production have this error in the log very often
Additional Notes
No aurora_version function value was used, so I think that just seeing if it exists in pg_proc is enough
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

While we review this PR you can try installing version 5.0.3 of the check that should significantly reduce the frequency of that call

While we review this PR you can try installing version 5.0.3 of the check that should significantly reduce the frequency of that

I will look forward to the merge of this PR as it is a simple change and fixes a bug

We're currently on a code freeze, will be merging when it's over

We're currently on a code freeze, will be merging when it's over

Do you have any estimates for this merge?

Turns out this was not working well for all aurora versions. Reintroducing check but as a safeguard in https://github.com/DataDog/integrations-core/pull/9224


Update operator description in CSV

What does this PR do?
Updates the operator description and begins an uninstall doc.
What issues does this PR fix or reference?
Is it tested? How?

N/A

See also
https://github.com/redhat-developer/web-terminal-operator/pull/84

Do you plan to fix TODOs before merging?

The remaining TODOs are for links to documentation and devfile samples. We need to fill them before release, but I don't think we have good options for this yet. Ideally linking to something like<EMAIL_ADDRESS>would be great, but I don't know if we have a stable/official link to put here.

/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path

Merging this PR to get it off the backlog, opened issue https://github.com/devfile/devworkspace-operator/issues/473 to track remaining work.


Warn when overriding HTML elements

Phlex could issue a warning or raise whenever an element method is overridden in a subclass. The warning could be ignored explicitly with a macro, e.g.
override def title
  @post.title
end

I think this might make sense as a feature you can optionally enable.

Implementation with a TracePoint.

We could ship a 1.x version that doesn't break.

I don’t love the idea of using a TracePoint to implement this, which we need to support the override def foo interface, since the definition will happen before override is called.
I’m just going to close this for now. If it comes up again, we can take another look.


SVSM: require SNP restricted injection

To maintain security of the SVSM, require that Restricted Injection is present in the SEV features in order to boot.

I tested this on the latest IGVM QEMU and it results in a panic on SVSM startup due to the SEV features not being propagated from the IGVM file via QEMU. I'll look at fixing this in the IGVM QEMU.

Requiring restricted injection is a good idea and it doesn't affect the guest itself! :+1:

By default, QEMU does not enable restricted injection. It can be enabled via a parameter on the command line. At the moment this is true for both the IGVM and non-IGVM versions of QEMU.
Maybe you could add a commit to this PR that updates the documentation:
diff --git a/Documentation/INSTALL.md b/Documentation/INSTALL.md
index 477b4d1..35931a0 100644
--- a/Documentation/INSTALL.md
+++ b/Documentation/INSTALL.md
@@ -225,7 +225,7 @@ guest:
   -cpu EPYC-v4 \
   -machine q35,confidential-guest-support=sev0,memory-backend=ram1,kvm-type=protected \
   -object memory-backend-memfd-private,id=ram1,size=8G,share=true \
-  -object sev-snp-guest,id=sev0,cbitpos=51,reduced-phys-bits=1,svsm=on \
+  -object sev-snp-guest,id=sev0,cbitpos=51,reduced-phys-bits=1,svsm=on,init-flags=1 \
 ```

 This selects the ```EPYC-v4``` CPU type which will pass the CPUID validation
@@ -233,7 +233,9 @@ done by the AMD security processor. It also allocates memory
 from the ```memory-backend-memfd-private``` backend, which is a requirement to
 run SEV-SNP guests. An ```sev-snp-guest``` object needs to be defined to
 enable SEV-SNP protection for the guest. The 'svsm=on' parameter makes
-QEMU reserve a small amount of guest memory for the SVSM.
+QEMU reserve a small amount of guest memory for the SVSM. The `init-flags=1`
+parameter enables the SEV-SNP restricted injection feature which is required
+by COCONUT-SVSM.

 Further, the OVMF binaries and the SVSM binary need to be passed to
 QEMU. This happens via pflash drives:
@@ -255,7 +257,7 @@ $ sudo $HOME/bin/qemu-svsm/bin/qemu-system-x86_64 \
   -cpu EPYC-v4 \
   -machine q35,confidential-guest-support=sev0,memory-backend=ram1,kvm-type=protected \
   -object memory-backend-memfd-private,id=ram1,size=8G,share=true \
-  -object sev-snp-guest,id=sev0,cbitpos=51,reduced-phys-bits=1,svsm=on \
+  -object sev-snp-guest,id=sev0,cbitpos=51,reduced-phys-bits=1,svsm=on,init-flags=1 \
   -smp 8 \
   -no-reboot \
   -drive if=pflash,format=raw,unit=0,file=/path/to/firmware/OVMF_CODE.fd,readonly=on \

By default, QEMU does not enable restricted injection. It can be enabled via a parameter on the command line. At the moment this is true for both the IGVM and non-IGVM versions of QEMU.
Maybe you could add a commit to this PR that updates the documentation:

I think a better strategy would be to modify QEMU to honor the SEV features specified in the IGVM file embedded in the VMSA.  I recognize that this may take some doing, but is really the only robust way to ensure that the IGVM file gets the behaviors it expects at launch.  This will, of course, become non-negotiable once we reach a point that the IGVM file includes an ID BLOCK that specifies the expected measurement of the SVSM image, which will contain the VMSA and its expected SEV features.
If this is too much to bite off in the short term, then it will be better for this PR to wait until that work is done.  If there is strong desire to merge this PR before that work can be accomplished, then it would be much better for somebody else to pick up this PR and complete it - somebody who is able to actually work with QEMU and validate the workflow, which is something I am not going to be in a position to do.

I think a better strategy would be to modify QEMU to honor the SEV features specified in the IGVM file embedded in the VMSA.

Yes, and I've been working this week on exactly this. It will be fairly easy to set restricted injection to match the IGVM file in QEMU but due to the way this works in QEMU/kvm other features will require further work.
However, the current versions of QEMU we host in coconut currently require the extra command-line option to be set to enable restricted injection. If this PR is merged then users will have no option but to add that extra flag otherwise the SVSM will panic on startup, hence the suggestion for the documentation change in this PR.
But this is a draft PR, and if it is not going to be merged until we've moved to a QEMU that supports setting this via IGVM then we can leave the documentation unchanged.

I think a better strategy would be to modify QEMU to honor the SEV features specified in the IGVM file embedded in the VMSA.

Yes, and I've been working this week on exactly this. It will be fairly easy to set restricted injection to match the IGVM file in QEMU but due to the way this works in QEMU/kvm other features will require further work.
However, the current versions of QEMU we host in coconut currently require the extra command-line option to be set to enable restricted injection. If this PR is merged then users will have no option but to add that extra flag otherwise the SVSM will panic on startup, hence the suggestion for the documentation change in this PR.
But this is a draft PR, and if it is not going to be merged until we've moved to a QEMU that supports setting this via IGVM then we can leave the documentation unchanged.

I think we are in agreement.  This PR will remain a draft PR until your work to support VMSA-in-IGVM is complete.  If there is pressure to move forward with requiring restricted injection before that, then we can revisit and talk about how to change the workflow (and document the changes).

Both restricted injection and boot from IGVM are part of the SVSM patch set for KVM so this should be safe to merge now.

Both restricted injection and boot from IGVM are part of the SVSM patch set for KVM so this should be safe to merge now.

I'm assuming you're referring to https://github.com/coconut-svsm/linux/pull/7, right? That PR hasn't been merged yet and IMO we should wait for that. Otherwise, if users follow the installation guide in this repo, they'll end up a broken setup.

I'm assuming you're referring to coconut-svsm/linux#7, right? That PR hasn't been merged yet and IMO we should wait for that. Otherwise, if users follow the installation guide in this repo, they'll end up a broken setup.

@roy-hopkins has assured me that the existing SVSM patch set is sufficient to make this work correctly.  Roy, did I misunderstand?

I'm assuming you're referring to coconut-svsm/linux#7, right? That PR hasn't been merged yet and IMO we should wait for that. Otherwise, if users follow the installation guide in this repo, they'll end up a broken setup.

@roy-hopkins has assured me that the existing SVSM patch set is sufficient to make this work correctly. Roy, did I misunderstand?

My error - I thought the COCONUT QEMU/KVM had been updated since this PR was opened, but the previous update to 6.10 was never merged and used as the default kernel. The comment I wrote above about updating documentation still stands for the current situation, but it makes more sense to wait for coconut-svsm/linux#7 to be merged. I'm working on that now.

My error - I thought the COCONUT QEMU/KVM had been updated since this PR was opened, but the previous update to 6.10 was never merged and used as the default kernel. The comment I wrote above about updating documentation still stands for the current situation, but it makes more sense to wait for coconut-svsm/linux#7 to be merged. I'm working on that now.

Thanks for clarifying.  I'll move this PR back to draft state and await your report on when it's safe to merge.


Updated hyperref include

Include the package hyperref after all other packages, so that hyperrefs for footnotes work correctly. Otherwise footnotes will always reference the first page of the document.

@fbirk Havent tried it. I trust you


Extension context invalidated

OS version: Windows 10
Browser version: Chrome 72
Extension version: 1.23.2

Relevant integration (if any):
https://trello.com
🐛 Describe the bug
Sometimes when Trello has been open for a while, the "Start timer" button no longer works.
When I click on it, "Uncaught Error: Extension context invalidated." appears in the browser console (of the Trello tab) and nothing happens in Toggl.
Expected behaviour
The "Start timer" button should start the timer in Toggl.
Steps to reproduce
I haven't managed to reproduce it intentionally.
It might just be from Trello having been open for a long time, but there may be other factors. Maybe Toggl session timeout? Some kind of update? Not sure.
Other details or context
Googling for "Extension context invalidated" gives some information about this error and methods for preventing it.
Perhaps something can be done even without clear steps to reproduce the issue.

Hi @mjomble, thanks for reporting. This likely happens after the extension has updated in the background. There have been multiple updates in short succession recently.
For the time-being, refreshing the tab should fix the problem when it occurs. We'll work on fixing it in the near future 👍

I'm receiving this now, too. It's happened a few times in the last few weeks, I click the button and think I started timing, only to realise later that the thing never started. I need to get into the habit of checking the extension button to make sure my click worked.


Introduce web and wiki config in triviaqa dataset

The TriviaQA paper suggests that the two subsets (Wikipedia and Web)
should be treated differently. There are also different leaderboards
for the two sets on CodaLab. For that reason, introduce additional
builder configs in the trivia_qa dataset.

I just made the dummy data smaller :)
Once github refreshes the change I think we can merge !

Thank you so much for reviewing and accepting my pull request!! :)
I created these rather large dummy data sets to cover all different cases for the row structure. E.g. in the web configuration, it's possible that a row has evidence from wikipedia ("EntityPages") and the web ("SearchResults"). But it also might happen that either EntityPages or SearchResults is empty. Probably, I will add this thought to the dataset description in the future.

Ok I see ! Yes feel free to mention it in the dataset card, this can be useful.
For the dummy data though we can keep the small ones, as the tests are mainly about testing the parsing from the dataset script rather than the actual content of the dataset.


nav: click removes highlight

See anything strange in this image?

https://dvc.org/doc/use-cases/ci-cd-for-machine-learning

I clicked the nav entry of the page after it loaded and it stopped being bold. Should look like this:

@jorgeorpinel
I couldn't replicate it. Is this still an issue?

Yep
https://user-images.githubusercontent.com/1477535/204681559-1a21aef4-b9e6-4465-ad12-176e465dda33.mov

Closing this as fixed.
https://user-images.githubusercontent.com/20840228/207810805-fa0e0871-b1b5-416d-8927-9eb901c69ad5.mov


Support for Windows Subsystem for Linux (WSL)

The jumpbox script fails on (at least Ubuntu Bionic) Windows Subsystem for Linux.
Issue 1: install_core_packages()

line 107: fails due to permission issues related to subsystem and lxrun AppData icalc permissions; a check needed for WSL as step can be bypassed when running a WSL container

Issue 2: Curl Request

WSL lacks the cert bundles defaulted in most "standard installations" requiring the "--insecure" flag for curl request
Application installs are copied across multiple functions when essentially performing the same steps, an enumeration list should be calling a singular function which would allow for additional checks to be performed on against the target system.

It's important to note genesis ping as well as other functions will execute successfully for a "system" instantiation after running once, then commenting out lines 100 - 124, adding the "--insecure" flag to curl request and running again.

Hey @r0bm3, apologies for the lack of response here.  I just wanted to reach out and see if this is something that would still be useful for you?


Add MarkerLayer decoration APIs

Refs https://github.com/atom/atom/issues/9208
:warning: WIP :warning:

This still a thing?

@nathansobo This got subsumed by a different PR, right?

Yeah, #9426 subsumes this. Not sure if I remember exactly why I opened up a new PR, but this one can be closed.


envision-unwrapped: 0-unstable-2024-10-20 -> 1.1.1-unstable-2024-11-29

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for envision-unwrapped is: UI for building, configuring and running Monado, the open source OpenXR runtime
meta.homepage for envision-unwrapped is: https://gitlab.com/gabmus/envision
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.1-unstable-2024-11-29 with grep in /nix/store/wwgkyy497y65x5khvzkdxjyfzk1c0ds6-envision-unwrapped-1.1.1-unstable-2024-11-29
found 1.1.1-unstable-2024-11-29 in filename of file in /nix/store/wwgkyy497y65x5khvzkdxjyfzk1c0ds6-envision-unwrapped-1.1.1-unstable-2024-11-29

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

envision
envision-unwrapped

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wwgkyy497y65x5khvzkdxjyfzk1c0ds6-envision-unwrapped-1.1.1-unstable-2024-11-29 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A envision-unwrapped https://github.com/r-ryantm/nixpkgs/archive/fb85ab43e394e39113bb96d714eba2f73660472b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fb85ab43e394e39113bb96d714eba2f73660472b#envision-unwrapped

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wwgkyy497y65x5khvzkdxjyfzk1c0ds6-envision-unwrapped-1.1.1-unstable-2024-11-29
ls -la /nix/store/wwgkyy497y65x5khvzkdxjyfzk1c0ds6-envision-unwrapped-1.1.1-unstable-2024-11-29/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

envision
envision-unwrapped

Maintainer pings
cc @Pandapip1 @Scrumplex for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Now that envision has tags, we should change the update script to reflect that.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 360652

x86_64-linux

:white_check_mark: 2 packages built:

envision
envision-unwrapped

x86_64-darwin

aarch64-darwin


"plot" function is not defined.

I tried executing the following:
from SimpleCV import Image
img = Image('starry_night.png')
histogram = img.histogram(256)
plot(histogram)
and got the following error:
NameError: name 'plot' is not defined
Any idea what's wrong?

add
from pylab import *


Feat: QLinearAveragePool

Implement QLinearAveragePool operator.

@raphaelDkhn I can't find this operator in the ONNX library

@HappyTomatoo Thanks, it means it's deprecated. I'll close that issue


If ending run sequence due to stamina (with pots turned off), scheduled starts fail

...because, it looks like, the stamina restore window is never closed, and enabling lab fails from that window:

Interesting find, and one I never encountered because I use the Close and restart FFRK when starting option
Would either that or the upcoming Wait for stamina to recover option be an acceptable work-around?  Looks like you are using multiple schedules that may or may not trigger while the bot is still running. The restart command is skipped if it's already running.

That's right, it was just the first scheduled restart (at 3:05) that failed, due to the dialogue being open.  The others behaved as expected.
(The schedules I just use to kick labmem if it dies in the middle of the night for some reason that's fatal to the sequence, but which it can restart out of.  Hasn't happened in a long while.)
I think using the "close and restart" option would be an acceptable workaround, or "wait for stamina to recover" -- either one.
(In this case, I'd actually intended it not to restart -- I wanted to keep going for a bit, but avoid overgrinding magia on a few PCs -- but forgot about the scheduled restarts.  So this was an accidental discovery.)

This is mostly resolved already with the various workarounds, but in 7.9 I made it navigate back to the main lab screen when out of stamina so it should support this workflow

Resolved in #218


Automation sprint zero

Summary:

What: <brief description>
Ticket: sc<fill_in_issue_number>
Env: <rdev link>

Demos:
Notes:
Checklist:

[ ] I merged latest <base branch>
[ ] I manually verified the change
[ ] I added labels to my PR
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

i need to upload newer changes and then reopen pull request


Add Forms Support

Feature description
Overview
I would love to add Forms support to this library with the clean declarative approach inspired by Ant Design with the use of react-hook-form and Zod as the validation library.
Benefits
What the developer has to do is structure the form and give the zod schema, the <Form.Item> will handle all the validation internally, and onFinish only calls when the form is validated.
Proposed Structure
const AddNewUser = () => {
  const form = useForm({
    resolver: zodResolver(
      z.object({
        firstName: z.string().max(20),
        lastName: z.string().max(20).optional()
      })
    )
  })

  return (
    <Form form={form} onFinish={data => console.log(data)}>
      <div className='grid gap-x-10'>
        <Form.Item label='First Name' name='firstName'>
          <CustomTextField />
        </Form.Item>
        <Form.Item label='Last Name' name='lastName'>
          <CustomTextField />
        </Form.Item>
      </div>

      <Button type='submit'>Submit</Button>
    </Form>
  )
}

Affected component/components
All Input fields
Additional Context
No response
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues and PRs

Since current input components return actual data as the first argument, this might need to be changed to work with react-form-hooks as it expects the onChange event

I'd recommend taking a look at our forms guide in React Aria: https://react-spectrum.adobe.com/react-aria/forms.html. In many cases you don't even need react-hook-form or zod because the builtin validations are enough. There is a section about using those libraries, but I'd recommend starting simple and only adding them if needed. React Aria Components supports constraint validation, custom validation functions, server validation, etc. It's best to do zod-style validations on the server for security, and you can send the errors back to display via React Aria as well.

I see.
What do you think about DX?
which way is easier to build complex forms?
Here are my thoughts about the way I proposed,

it's less repetitive code to write
all the validation is in one place
typescript data schema comes as a bonus
supports a wide variety of validators

The React Aria approach and shadcn/ui approach both do it well but its lot of repetitive codes in each input.
Let me know about your thoughts


improvement: lager pkg do not depend one chassis

Coverage increased (+0.2%) to 62.521% when pulling 4deee7940cdd19c9ea09304fa89394985a88bb28 on tianxiaoliang:master into edb554b82f9a53de2c1a437b2c4a66672a0106dd on ServiceComb:master.


Missing clientId in application.yml causing an error

Describe the bug
When I first tried to clone and run the template I was stuck at the following issue.
Caused by: java.lang.IllegalArgumentException: Could not resolve placeholder 'mqtt.broker.clientId' in value "${mqtt.broker.clientId}"
This is caused due to a missing property in the application.yml file.
I wanted to know if there was a specific reason for excluding it. If there isn't, I would like to pick this issue up and contribute.
How to Reproduce

asyncapi generate fromTemplate asyncapi.yaml @asyncapi/java-spring-template -o spring-output-test
Run application

Expected behavior
Spring boot application will not start.

@Tenischev @derberg  Hi, could you please take a look at this? Thanks

@Tenischev please have a look 🙏

@Tenischev Thank you. Will work on this and let you know once I've made a PR.


[SPARK-39711][TESTS] Remove redundant trait: BeforeAndAfterAll & BeforeAndAfterEach & Logging

What changes were proposed in this pull request?
SparkFunSuite declare as follow:
abstract class SparkFunSuite
extends AnyFunSuite
with BeforeAndAfterAll
with BeforeAndAfterEach
with ThreadAudit
with Logging

some suite extends SparkFunSuite and meanwhile with BeforeAndAfterAll or BeforeAndAfterEach or Logging, it is redundant.
Why are the changes needed?
Eliminate redundant information and make the code cleaner.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.

Can one of the admins verify this patch?

Merged to master. Thanks @panbingkun


feat: upgrade to ky@1 and remove ky-universal

:tada: This PR is included in version 3.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[SPARK-50317][BUILD] Upgrade ORC to 2.0.3

What changes were proposed in this pull request?
This PR aims to upgrade ORC to 2.0.3 for Apache Spark 4.0.0.
Why are the changes needed?
To bring the latest bug fixes
Does this PR introduce any user-facing change?

https://github.com/apache/orc/releases/tag/v2.0.3
https://orc.apache.org/news/2024/11/14/ORC-2.0.3/

How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Thanks @dongjoon-hyun

Thank you, @viirya !

Merged to master for Apache Spark 4.0.0.


Consider replacing forEach, filter, reduce...

Hi,
when parsing the JavaScript input consider replacing methods like forEach with for constructs in order to improve performance significantly.
For example:
const numbers = [ 10, 20, 30, 40, 50 ];
const numbersLessThan30 = numbers.filter(number => number < 30);

// OUT [ 10, 20 ].

Should become:
const numbers = [ 10, 20, 30, 40, 50 ];
const numbersLessThan30 = [];

for (const number of numbers) {
    if (number < 30) {
        numbersLessThan30.push(30);
    }
}

// OUT [ 10, 20 ].

The second solution can be 10x times faster than the first.
This is a publication about a performance test based on all methods: https://hackernoon.com/javascript-performance-test-for-vs-for-each-vs-map-reduce-filter-find-32c1113f19d7.

I'd suggest doing this as a separate build step of your build step. If only small arrays are expected, the increased size of the code will only have the negative impact since performance will remain the same. If large arrays are expected, I think this kind of optimization is developer's responsibility and not Closure's.
Besides, the only real benefit of this would be transforming a chain of Array extras, but a lot of libs are already doing that. My personal favorite is iterare.


Contrib/Fastcluster BugFix and update Readme

What does this implement/fix? Explain your changes.

update Readme.md
bug fix in Line 32 and 43.

Hi,
There are a lot of conflicts with this pull request because the master branch of your github fork is no longer in sync with the main rdkit master. I could resolve these conflicts, but it would be better if you did it yourself since it will make future merges easier too.
There are instructions here for updating one github repo from another one:
https://github.com/KirstieJane/STEMMRoleModels/wiki/Syncing-your-fork-to-the-original-repository-via-the-browser
Thanks,
-greg

merged with #2051
Thanks @iwatobipen !


Add desugar changes for group by

Purpose
$title
Fixes #37140
Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@suleka96 / @gimantha / @hasithaa Do we need this PR? Looks like it got automatically closed without any attention. If you really don't need this PR anymore, please remove the stale label from the PR. Then it won't get added to the [Stale PR] Ballerina Stale PR Details mail in the future.

@anupama-pathirage Yes.. This work is in progress. @KavinduZoysa Are these changes in your local changes?

@anupama-pathirage Yes.. This work is in progress. @KavinduZoysa Are these changes in your local changes?

@gimantha, yes I have these changes locally.


[Switch button]: Add Switch button to the controls same as light button

Is your feature request related to a problem?
I always use light cards to modify the yaml to add a light-switch.
It would be great to have a dedicated card for light-switches as well.
Describe the solution you'd like
It seems the light function is very similar to the light-switch.
therefore the light function could be duplicated and tweaked to get the light-switch added to the mushroom cards.
Describe alternatives you've considered
As mentioned earlier I have used light and/or entity cards instead and modified the yaml files to get my switch cards.
Additional context
No response

I don't really understand what you call light switch. If you want switch card, you can use the entity card with toggle tap_action.

No worries, mate.
Cheers for the excellent work.


Could not find gem 'logstash-devutils' in any of the gem sources listed in your Gemfile.

Hi,
I was trying to "bundle install" but getting below error.
"
Could not find gem 'logstash-devutils' in any of the gem sources listed in your Gemfile. "
I have installed Jruby , even have logstash-devutils (1.3.6 java) but its always failing.
Not done any changes just as described at https://www.elastic.co/guide/en/logstash/current/filter-new-plugin.html
Please suggest.

Can you try running jruby -S bundle install


temp: pin versions to 2.0 from repo

#5
#4
#3
#2
#1
#6  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @buffalojoec and the rest of your teammates on  Graphite


⚠ Jenkins Plugins Artifactory has degraded performance

In ea7b711, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1320 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 36f7c44 after 50 minutes.


Documentation update regarding images below 10,000 bytes

Is this a bug report?
No, this is a documentation update suggestion
The following sentence should be updated to be more explicit:
To reduce the number of requests to the server, importing images that are less than 10,000 bytes returns a data URI instead of a path.
To this:
To reduce the number of requests to the server, importing images that are less than 10,000 bytes returns a data URI instead of a path, therefore these images will not be included in the build/static/media directory, but will be placed inline where they are used instead.

Please submit PR. Thanks


WIP: Enhance inject route utilities

Adds the following options to all utilities and therefore aligns them.

injectParams

transform
defaultValue
injector

injectQueryParams

defaultValue
injector

injectQueryParams.array

defaultValue
injector

injectRouteData

defaultValue
injector

injectRouteFragment

defaultValue

I also took the chance to rename initialValue to defaultValue (as I think it's a more fitting name).
injectQueryParams supports both values, as to not introduce a breaking change.
Tests are still missing.

is this still WIP?

Yes, docs and tests are missing.

Hello @Dafnik
Thanks for this great PR.
Regarding

I also took the chance to rename initialValue to defaultValue (as I think it's a more fitting name).
injectQueryParams supports both values, as to not introduce a breaking change.

I think initialValue is a better fit there because after the initialValue, the params can change however the router needs, and we shouldn't call it default value (as that would mean that we will reapply it again based on some condition, which we don't because we only need it the first time).

Hi, thank you very much :)
But it is actually a default value. 😅
Lets say we have the route test and use the URL /test?a=1234.
If we use injectQueryParams('a', {defaultValue: '1111'}) we will get the result 1234.
But now the route changes to /test. The query param is null and the default value 1111 will be emitted.
Or did I get this wrong?

Ping @eneajaho

This one should be included in the docs too https://timdeschryver.dev/blog/til-paramsinheritancestrategy-to-always-have-access-to-parent-route-info


Script editor now automatically completes file paths in GDScript

I'm not sure this functionality is really desired by any other developers but for me, it was very helpful.
The completion turns on if you type in load/preload or  "res: (in any function parameter), and lists every file visible in the filesystem dock.
This might be annoying for some people, so I added an editor option for turning it off.
The only related issue I could find: #2982

Oops, clang formatting

Can't we just get a COMPLETE_PRELOAD or COMPLETE_PATH instead of that rfind mess?

Indeed, that sounds better imo
On Apr 18, 2017 11:24 AM, "Bojidar Marinov"<EMAIL_ADDRESS>wrote:

Can't we just get a COMPLETE_PRELOAD or COMPLETE_PATH instead of that
rfind mess?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/8444#issuecomment-294743243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2_LcRsYnFaGvNDMpIPGkb0UED2DIks5rxIE0gaJpZM4M_qNJ
.

Actually haven't thought about it...
Will try that today

Done


Deploy to Azure Machine Learning managed online endpoint

Hi @chanezon ,
I encountered an issue while deploying the existing endpoint (ept), resulting in a failure to create the prompt flow deployment. The error message indicates a problem with establishing or configuring the deployment process for the endpoint. This issue needs to be addressed to ensure the successful deployment and functionality of the endpoint in the intended environment, not able to proceed further on this lab .
Please find the screenshot below :

Unfortunately, there isn't enough information available from this screenshot or your text to troubleshoot. I'm sure that's very frustrating for you. If there are no more details available to you (deployment logs) to help troubleshoot, you'll likely need to contact support so they can look into logs on their side to see what might have failed.  Sorry to see you ran into an issue in your subscription :(

Hi @chanezon , I encountered an issue while deploying the existing endpoint (ept), resulting in a failure to create the prompt flow deployment. The error message indicates a problem with establishing or configuring the deployment process for the endpoint. This issue needs to be addressed to ensure the successful deployment and functionality of the endpoint in the intended environment, not able to proceed further on this lab .
Please find the screenshot below :

Facing the same issue and I have raised a support request. Seems like the issue exists when deploying to the managed online endpoint which got provisioned from the bicep script. A quick fix which worked for us is to delete that managed online endpoint completely, and create a new endpoint with the managed identity (which in your case resolves to the name "id-amlonlineendpoint-1407183") through the Azure Machine Learning Workspace. Then deploy the flow with the newly created managed online endpoint.
@imabedalghafer

I'm going to close the issue as we've just refreshed the repo and none of our tester ran into this situation during the week long development cycle with the new version.  If you're still having the problem with the latest code in main please let us know.


Add a prompt, plus improve messaging to inform the user about the zopen overriding behaviour on conflicting tools

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Content Update

Category

[ ] zopen build framework
[x] zopen package manager
[ ] Documentation
[ ] CI/CD
[ ] Tools

Description

In zopen-config, it updates the messaging to inform the user on whether conflicting tools are being overriden or not.
In zopen-init: it add a prompt to ask the user on what the default behaviour should be for overriding zopen tools

Related Issues

Related Issue #
Closes #

[optional] Are there any post-deployment tasks or follow-up actions required?

Thinking about this... we know exactly which ports have conflicting tools with /bin so we could be precise and let the user know which tools are overridden. However, that may be a bit too verbose.


feat: patch includes in MODULE.bazel when publishing

MODULE.bazel can use include to organize dependencies but, per the docs:

Only the root module may use include(); it is an error if a bazel_dep's MODULE file uses include().

In Slack Thread @fmeum suggested that

combining all the [include] segments into a single MODULE.bazel file could be a feature of a tool based on the buildozer API
(...)
the tool needs to rename top-level variables that conflict. Or use a pattern such as IIFE (immediately invoked function expression).
(...)
It could even be combined with the Publish to BCR app to automatically patch in the full module file content

It would be great to have such a tool and/or automation in the BCR tools!

I'll bring this up at the next Rules Authors SIG meeting.

Here's a couple more things I thought about:
"pattern"
Maybe a "pattern" that could work nicely would be to invoke such a tool from a tools/bazel wrapper. Something like:

move MODULE.bazel to includes.MODULE.bazel at the root
add MODULE.bazel to .gitignore
have a wrapper in tools/bazel that invokes the tool which parses include.MODULE.bazel and materializes the MODULE.bazel

IMHO it would be ideal if buildozer had an expand_include command that would perform the recursive expansion.
renaming variables
For the renaming of the variables, the tool could probably use the path to the include file plus the MODULE prefix, e.g.:
# includes.MODULE.bazel at the root
include("//dir1/dir2/foo.MODULE.bazel")

bar = use_extension("//other/path:extension.bzl", "bar")

# dir1/dir2/foo.MODULE.bazel

bar = use_extension("//1/2/3:extension.bzl", "bar")

These would expand to:
# MODULE.bazel at the root

# include("//dir1/dir2/foo.MODULE.bazel")
dir1_dir2_foo_bar = use_extension("//1/2/3:extension.bzl", "bar")

bar = use_extension("//other/path:extension.bzl", "bar")


Supplement the convention for configuration file location and allow file merging

What problem does this feature solve?

There are way too many configuration files at the top level of my project.
I would like to break my webpack configurations into multiple files for reuse.

What does the proposed API look like?
I suggest a top level config-src directory that contains all configuration files.
Furthermore, it would be useful if config file modules could be merged, so multiple files could be reused between projects.
root
-src
-dist
-config-src
--webpack.config.0.first.js
--webpack.config.optimize.js
--webpack.config.resolve.js
--webpack.config.loaders.js
--webpack.config.z.last.js

Files would merged in order of listing, overriding previous entries.
Obviously, if the configuration files were not at the conventional location, other tools would break.  So perhaps vue-cli could have commands to:

Merge the files and put them in the conventional location.
Run the tools behind the scenes after merging, using the location of the merge file.
Provide a config-diff command to help us manage our projects.

The specification could also (via folders or filename):
4. Provide a means to specify a merge action of replace or override.
5. Provide a means to specify build mode in filename.
Finally, it would be nice to ask the major tool providers to agree on this standardized sub-directory to be checked, in addition to the top level directory, when searching for configuration files.

Finally, it would be nice to ask the major tool providers to agree on this standardized sub-directory to be checked, in addition to the top level directory, when searching for configuration files

This is a nice idea, but we won'T have the capacity to go through these discussions with all the different tool maintainers, so that won't happen.

I would like to break my webpack configurations into multiple files for reuse.

You can achieve without any support by vue-cli being required.
// vue.config.js
import config1 from './config/config1'
import config2 from './config/config2'
import chainConfig1 from './chainConfig1'
import chainConfig2 from './chainConfig2'

module.exports = {
  configureWebpack: {
    ...config1,
    ...config2,
  }
  chainWebpack: config => {
    chainConfig1(config)
    chainConfig2(config)
  }
}

@LinusBorg Thank you for posting the example.  I am aware of this, however I would like a convention for putting files into a folder without having to configure anything.  That's the main point I am making.  It would be < 10 lines of code in base that would reduce community efforts in a huge way.
p.s. I know suggesting a common config location for 3rd party tools is a bit idealistic...


updated faq with new farming content

Updated the FAQ with new QnAs from farmers.

Notably: Troubleshooting tips when Z-OS cannot boot on a 3node

closing this in favor of the simpler PR https://github.com/threefoldtech/info_grid/pull/274


Questions about LLaVA checkpoints

Hello! Thank you for your valuable work!
As shown in the figure, your paper mentioned LLaVA checkpoint,7B language Model, and I would like to ask you a few questions:

Since LLaVA open-source many weights, is the weight you using LLaVA-1.5 7b full_ft-1e?

Do you use full tune or LoRA fine-tune for the 2 stages of training?

How do you load the initial weights of Llava?  Do you pass the path of the LLaVA weights to both the model_name_or_path and the vision_tower in pretrain.sh?

I'm looking forward to your reply! Thank you very much!

Hi,
To start we open source our best-performing open-question model: QUILTNET ViT-B-32 Vision Encoder, 7B Language Model (i.e. lmsys/vicuna-7b-v1.5 + QuiltNet B-32).
To answer your questions:

We use liuhaotian/llava-v1.5-7b was as discussed in the paper and as can be found in scripts/v1_5/finetune_task.sh
No, we do not use LoRA
I'll assume you are asking about the 1st pretrain stage on liuhaotian/llava-v1.5-7b. Yes, we use: --model_name_or_path liuhaotian/llava-v1.5-7b \. --vision_tower openai/clip-vit-large-patch14-336 \

I see, thank you very much for your reply!!


Release 5.13.4

Codecov Report
Attention: Patch coverage is 44.53782% with 66 lines in your changes missing coverage. Please review.

Project coverage is 47.08%. Comparing base (57fde12) to head (fa8cdfd).
Report is 3 commits behind head on master.

Files with missing lines
Patch %
Lines

Viewer/ecflowUI/src/ModelColumn.cpp
0.00%
11 Missing :warning:

Viewer/ecflowUI/src/ChangeNotify.cpp
0.00%
4 Missing :warning:

Viewer/ecflowUI/src/TreeNodeWidget.cpp
0.00%
4 Missing :warning:

Viewer/ecflowUI/src/InfoProvider.cpp
0.00%
3 Missing :warning:

Viewer/libViewer/src/IconProvider.cpp
0.00%
3 Missing :warning:

libs/client/src/ecflow/client/ClientInvoker.cpp
50.00%
3 Missing :warning:

libs/node/src/ecflow/node/ExprDuplicate.cpp
40.00%
3 Missing :warning:

libs/server/src/ecflow/server/SslTcpServer.cpp
0.00%
3 Missing :warning:

libs/udp/src/ecflow/udp/UDPServer.hpp
0.00%
3 Missing :warning:

Viewer/ecflowUI/src/NodeQuery.hpp
0.00%
2 Missing :warning:

... and 15 more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   47.09%   47.08%   -0.02%
==========================================
  Files        1180     1179       -1
  Lines       93286    93311      +25
  Branches    14743    14744       +1
==========================================
- Hits        43933    43931       -2
- Misses      49353    49380      +27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dual SIM phone problem

Hello.. I've got problem with application od ma dual SIM phone - it's unable to choose, from which SIM I want to send premium SMS. App is sending SMS hardly from SIM 2, which has not alloowed premium SMS. Please give user to choose, which SIM he want to use..
Thank you..
David

Hi, could you write the type of your phone and version of Android OS? Thanks.
I have to warn that we can't guarantee successful fix because dual SIM phones are very problematic from programmers point of view. Before Lollipop there were no APIs for handling multi SIM phones. Some APIs were added in Lollipop and even with these it's still rather problematic to work with multi SIM phones. Multi SIM phones usually have many manufacturers' hacks to Android OS which are difficult/impossible to access by 3rd party apps.

Asus Zenfone 5, Android 5.0

I have finished implementation of multi-sim support, see screenshot.
It will work only on devices which have Android 5.1 or newer. Android didn't have official support for dual-sim in earlier releases.


Wrong "Reference Document" in warehouse posting from Sales and Puchase Returns

In codeunit 80 "Sales-Post", function CreateWhseJnlLine(...)
the "Reference Documents" is set to Posted Return Shipment instead of Posted Return Receipt

In codeunit 90 "Purch.-Post", function CreateWhseJnlLine(...)
the "Reference Documents" is set to Posted Return Receipt instead of Posted Return Shipment

The values are clearly reversed.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 18835.


Game tends to crash after buildings are built

Happened to me about 5 times already. As soon as some city improvement is built, the game crashes. Not always though.

Can confirm: I've played games until I discovered everything to about the year 2200 AD without any problems, but sometimes the game crashes before 1 AD.
Do you get some kind of error message? If so, can you make a screenshot?

This is a screenshot when I moved a settler down 1 tile and the game suddenly crashed:

This second time I built barracks & city walls. All OK. But it crashed when I built pyramids:

I've had this after a building completes, on the manager screen:

Okay, so I specifically need to look for a NullReferenceException. This helps a lot.
I discovered that the game crashes whenever you build one of the Space Ship components, so whatever you do: Don't build Space Ship parts!

And again, haven't checked to see if this is the same error:

This might make a difference:  I was hammering through turns and screens just to progress some techs - literally spamming the enter key.

I think there's a problem with resources not yet being loaded...
Only proper debugging will tell me what actually happens. I will explicitly hammer the enter key while debugging. :-)

There was a bug with getting graphics resources. That issue has been fixed.
I have played a game until 2020 AD, where I had more than 20 cities, boats, airplanes and I had discovered all techs. The game has not crashed. It appears that this issue has been fixed.


Data driven game modes: define game modes in json, access to all features and their constructors

kinda done now, closing.


qlf_k4n8: fix arch to allow physical .input and .output blif

Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>This commit fixes an issue in the physical description of the IO pb_types, for which, if a block that is not a top-level input/output has an output with no inputs, it is considered by VPR as a constant generator.
Given that the IO physical mode has only two possible settings (0 == output mode, 1 == input mode), the FASM feature is written only in case the input mode is selected. This will enable us to leave unaltered the top level IOs during repacking and let VPR correctly detect clock nets.
The repacker needs adjustments, and this commit also enhances the packing rules to deal with the changes in the physical description of the IO pb_type.
Note: This is a short term solution, as it requires to manually change the architecture. A longer-term solution will require to modify the architecture generation scripts, so to automate the update process.

There are some changes required for the repacker code, in order to generate valid netlists with valid IO top level ports. It is currently failing for some tests (adder_FFs and bin2bcd). The branch to look at is the following: https://github.com/antmicro/symbiflow-arch-defs/tree/fix-sdc

@acomodi  please close this PR as you have already moved these changes to OpenFPGA scripts


Request to change website redesign meeting champion

Since a past few meetings we have had to ask someone to open the meetings for us for website redesign and we feel it would be beneficial to have a new champion for website redesign and new hosts to host our meetings for website redesign.
The champion we would like to nominate is :

Divy Tolia

The hosts we want are:

Ben Halverson
Saulo Nunes
Divy Tolia

+1 on @designMoreWeb  as a champion

@designMoreWeb i just realized now that this is an issue, we need an PR to update this section here: https://github.com/nodejs/community-committee#current-initiatives

@designMoreWeb i just realized now that this is an issue, we need a PR to update this section here: https://github.com/nodejs/community-committee#current-initiatives

I’ll create a PR in a bit

Created the PR

PR merged. This issue is resolved. Thanks everyone.
https://github.com/nodejs/community-committee/pull/627


[release/1.3] cherry-pick: Disable criu tests in Travis CI

Temporarily disable criu tests until the 5.0.0 CI kernel issue is
resolved. Also update criu to v3.13
Cherry-picked: #3898 for release/1.3
Signed-off-by: Phil Estes<EMAIL_ADDRESS>

LGTM

Codecov Report

Merging #3908 into release/1.3 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.3    #3908   +/-   ##
============================================
  Coverage        42.07%   42.07%
============================================
  Files              129      129
  Lines            14322    14322
============================================
  Hits              6026     6026
  Misses            7395     7395
  Partials           901      901

Flag
Coverage Δ

#linux
45.59% <ø> (ø)
:arrow_up:

#windows
37.01% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff48f57...7b1a7de. Read the comment docs.


Configurable defaults

I'm working on universal JavaScript, that is, running the same JavaScript on the browser and the server for pre-rendering server side applications and on client applications it's normal to do xmlhttprequests with just a path. In this case this library assumes you'll be talking to http://localhost:80/, but that's not always the case, so I made it possible to set a default, to bootstrap an environment where the application can run unchanged.
I'll be publishing blog posts and libraries I developed around this idea at https://CarouselApps.com in case you are curious.

any word on this? seems really useful.

@atroche if you need it right now, I released a fork with that and a small bug fix:
https://www.npmjs.com/package/@pupeno/xmlhttprequest

I updated the branch to 1.8.0, it merged without any issues.

Well, at least no conflicts.


Fix typo

a Azure -> an Azure

@changeworld : Thanks for your contribution! The author, @renashahmsft, has been notified to review your proposed change.


package electron with edge.js native module

I have rebuild edge.js native module with electron headers and running fine but when i'm running electron-packager and trying to run application i get the following error:
[Error: The edge module has not been pre-compiled for node.js version v2.3.1. You must build a custom version of edge.node. Please refer to https://github.com/tjanczuk/edge for building instructions.]

This is an issue with edge. You may want to look into using a specific Electron version. See https://www.npmjs.com/package/edge-atom-shell


potential video preprocessing on DiDeMo videos

Thanks for the great work!
I used your released checkpoint 25M-retrieval-didemo.pth and directly conducted inference, but got accuracy lower than that reported in the repo:
reported (12 test frm): 61.2
re-inference (12 test frm): 59.5
re-inference (32 test frm): 59.8
I noticed that it seems you prepross the videos in DiDeMo, i.e., 2fps_360_trimed30 in the following config. I wonder if you resize the frames to 360 and what does trimed30 mean? Can you provide the preprossing script if it has great impact to the final results? Thanks a lot.
https://github.com/klauscc/VindLU/blob/30465487e8314fa1df45b1457b0313f25649e054/configs/ret_didemo.py#L5-L9

Hi,
I just tested the checkpoint and got exactly the same results as reported (see evaluation log). So the issue may be on the data side.
We resized the videos to 2fps with short side of 360.  trim30 means we only keep the first 30 seconds of each video. The original DiDeMo paper, CLIPBert, Singularity, LAVENDER also uses the first 30 seconds of the video.

Great! I successfully reproduced the results after preprocessing the videos to 2fps_360_trimed30. Thanks a lot.


feat: add general decode function

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

src/decode.zig
89.18%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

src/cricket.zig
100.00% <ø> (ø)

src/formats/der/internal.zig
100.00% <100.00%> (ø)

src/decode.zig
89.18% <89.18%> (ø)

... and 2 files with indirect coverage changes


Reference App

Can you share the sample codes of the app referenced in the video?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ca841cb-5a8f-ca9a-ec92-d088f43e0401
Version Independent ID: a56f0f32-4fb5-55b5-54d4-d26b39384316
Content: How to delegate user registration and product subscription
Content Source: articles/api-management/api-management-howto-setup-delegation.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

Hi @icocwp Thanks for reaching out. We will review and update as appropriate.

@icocwp Here is the complete code : https://github.com/Azure/api-management-samples/tree/master/delegation
For now I will proceed with closure of this and If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Wirst Intermittent Up Motion

To move the wrist up, sometimes it is required to go down first (feels like a code problem)

#malwire


When simulation explode.

Sometimes the simulation explodes.
jpp suggests that give negative scores for robots that break the simulation. Make sense.

Another way of reducing the possibility of wired behavior is damping. when we do attachment, the new link suddenly appear from nowhere, the abrupt force and moment are brutal, so add large damping on the creation of the new link can avoid exploding somehow.


second round on flow chart

Hey Pat
I have three tries at this.  I'm sorry that I have had a lot of difficulty getting the image quality right.  The last one should be good enough.  It is larger than the original so you should be able to shrink it to make it a higher quality image.

Thanks - looks like it should be good.


BDSO-edit doesnt resolve CL terms

Low priority, but even after refreshing imports, BDSO-edit doesn't seem to resolve the CL terms
I'll look into this and why this is happening
If we do eventually plan to upgrade ODK, it will eventually move to base file migration and it will solve this issue I think as that builds a merged import file which the -edit file pulls in
For now I'll edit the ontology using PCL and copy paste over the text into BDSO-edit

ok i was stupid, looking at wrong file lol, all good :)

oh wait was on wrong branch - ok yeah still an issue

Fixed when changed to merged import system


parsing csv file with only one column fails

Creating a subject ID list in Excel with only one column results in parsing failure
Unable to auto-detect delimiting character; defaulted to ','
Example file: Book1.csv

the , at the end of the column/line are missing in this case


Expander collapses in VirtualizingStackPanel when scrolled out of the view

Describe the bug
If you have a list of Expanders in a ItemsControl which is in a ScrollViewer and the ItemsControl is using a VirtualizingStackPanel as ItemsPanel, an expanded Expander that was scrolled out of the view, collapses when getting out of the view and leaving the space, that was used before emptyat the top of the scrollviewer until scrolled to the top.

To Reproduce

Create a new Avalonia Project (at least with Desktop App)
In the MainView.axaml paste the following content:

<ScrollViewer>
  <ItemsControl ItemsSource="{Binding Source}">
    <ItemsControl.ItemTemplate>
      <DataTemplate>
        <Expander HorizontalAlignment="Stretch">
          <Expander.Header>
            <Label Content="{Binding}"/>
          </Expander.Header>
          <TextBlock Text="My Content" Height="100" Background="Red"/>
        </Expander>
      </DataTemplate>
    </ItemsControl.ItemTemplate>
    <ItemsControl.ItemsPanel>
      <ItemsPanelTemplate>
        <VirtualizingStackPanel Orientation="Vertical" />
      </ItemsPanelTemplate>
    </ItemsControl.ItemsPanel>
  </ItemsControl>
</ScrollViewer>

In the MainViewModel.cs paste the following content:

    private List<string> _Source = new List<string>() { "1", "2", "3", "4", "5", "6", "7", "8", "9" };
    public List<string> Source => _Source;

Run the app, expand and scroll. Maybe you need to make the window size smaller to get into this issue for demonstration.

Expected behavior
The Expander stays expanded.
Avalonia version
11.2.3
OS
Windows
Additional context
Tested in Windows Desktop App only.

That's by design. Virtualization means that a control is destroyed when scrolling out of view. What you could do is to bind to IsExpanded in your ItemViewModel to keep the state.

That's by design. Virtualization means that a control is destroyed when scrolling out of view. What you could do is to bind to IsExpanded in your ItemViewModel to keep the state.

Thx. I thought it might be like this, but maybe not.
I will implement your suggenstion to store the state in the ItemViewModel.


Kerui-Security magnetic door sensor

I have some door sensors that show up but don't match your "type" field, they say "state = open" is there any way to add that in?

Closing this as I am no longer maintaining this add-on (I've moved my home automation to Hubitat and no longer use Home Assistant).


be able to apply some kind of impulse to player physics

related to #15
Currently it's impossible for functions outside of player Controller._physics_process() to influence the character's motion.
I want to be able to apply impulses on motion for stuff like

weapon recoil
bullet/melee impacts
explosion forces
drunkeness :)
wind, wading through water, and other environmental forces
etcetera

Maybe have an additional_force member to be able to write to from other functions.
It would be nicer to have the PC work like the Enemy type. But that's okay; the player is special.


zappa certify => Attribute Error: 'NoneType' on orig_value.split[...]

This is in reference to running zappa certify and getting the error below.
Possible Fix

Not sure yet. Today I started taking a look at the referred botocore file botocore/handlers.py and working out from there. I might have to set this up manually on AWS's APIGateway and Route53 instead but I would love to have a solution or direction instead. Please advice.
Steps to Reproduce

set certificate_arn (ex:arn:aws:acm:us-east-1:...)
set domain (subdomain.example.com)
zappa certify

Your Environment

Zappa version used:
OSX 10.12.5
zappa==0.42.2
python 2.7
zappa_settings relevant keys
"certificate_arn":"arn:aws:acm:us-east-1........"
"domain": "here.mysite.com"

Context & Error
Traceback (most recent call last):
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/zappa/cli.py", line 2358, in handle
sys.exit(cli.handle())
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/zappa/cli.py", line 459, in handle
self.dispatch_command(self.command, stage)
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/zappa/cli.py", line 555, in dispatch_command
manual=self.vargs['manual']
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/zappa/cli.py", line 1609, in certify
self.zappa.update_route53_records(self.domain, dns_name)
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/zappa/core.py", line 1698, in update_route53_records
is_apex = self.route53.get_hosted_zone(Id=zone_id)['HostedZone']['Name'][:-1] == domain_name
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/botocore/client.py", line 253, in _api_call
return self._make_api_call(operation_name, kwargs)
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/botocore/client.py", line 531, in _make_api_call
api_params, operation_model, context=request_context)
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/botocore/client.py", line 583, in _convert_to_request_dict
params=api_params, model=operation_model, context=context)
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/botocore/hooks.py", line 227, in emit
return self._emit(event_name, kwargs)
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/botocore/hooks.py", line 210, in _emit
response = handler(**kwargs)
File "/Users/ycosta3987/.virtualenvs/loudmouth-user/lib/python2.7/site-packages/botocore/handlers.py", line 577, in fix_route53_ids
params[name] = orig_value.split('/')[-1]
AttributeError: 'NoneType' object has no attribute 'split'

When this happened to me, I forgot to turn off route53_enabled. Since route53 doesn't manage my domains.

Happened to me too. I also don't use Route53 but CloudFlare.
(venv) C:\Users\ceefour\git\samara\samaraweb>zappa certify
Calling certify for stage prd..
Are you sure you want to certify? [y/n] y
Certifying domain keluargasamara.com..
Oh no! An error occurred! :(

==============

Traceback (most recent call last):
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\zappa\cli.py", line 2610, in handle
    sys.exit(cli.handle())
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\zappa\cli.py", line 505, in handle
    self.dispatch_command(self.command, stage)
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\zappa\cli.py", line 610, in dispatch_command
    manual=self.vargs['manual']
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\zappa\cli.py", line 1816, in certify
    self.zappa.update_route53_records(self.domain, dns_name)
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\zappa\core.py", line 1949, in update_route53_records
    is_apex = self.route53.get_hosted_zone(Id=zone_id)['HostedZone']['Name'][:-1] == domain_name
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\botocore\client.py", line 312, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\botocore\client.py", line 579, in _make_api_call
    api_params, operation_model, context=request_context)
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\botocore\client.py", line 631, in _convert_to_request_dict
    params=api_params, model=operation_model, context=context)
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\botocore\hooks.py", line 227, in emit
    return self._emit(event_name, kwargs)
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\botocore\hooks.py", line 210, in _emit
    response = handler(**kwargs)
  File "c:\users\ceefour\git\samara\venv\lib\site-packages\botocore\handlers.py", line 586, in fix_route53_ids
    params[name] = orig_value.split('/')[-1]
AttributeError: 'NoneType' object has no attribute 'split'

==============

Need help? Found a bug? Let us know! :D
File bug reports on GitHub here: https://github.com/Miserlou/Zappa
And join our Slack channel here: https://slack.zappa.io
Love!,
 ~ Team Zappa!

Python 3.6 on Windows 10:
argcomplete==1.9.2
Babel==2.5.1
base58==0.2.4
boto3==1.4.7
botocore==1.7.39
certifi==2017.11.5
chardet==3.0.4
click==6.7
Django==1.11.7
django-phonenumber-field==1.3.0
docutils==0.14
durationpy==0.5
future==0.16.0
hjson==3.0.1
idna==2.6
jmespath==0.9.3
kappa==0.6.0
lambda-packages==0.19.0
phonenumberslite==8.8.5
placebo==0.8.1
psycopg2==<IP_ADDRESS>
python-dateutil==2.6.1
python-slugify==1.2.4
pytz==2017.3
PyYAML==3.12
requests==2.18.4
s3transfer==0.1.11
six==1.11.0
toml==0.9.3
tqdm==4.19.1
troposphere==2.0.2
Unidecode==0.4.21
urllib3==1.22
Werkzeug==0.12
wsgi-request-logger==0.4.6
zappa==0.45.1

So this seems to be either people not using route 53 (and not disabling it with "route53_enabled": false in the settings or a possible duplicate of #1661. Correct?


Add golang examples

Add examples showing how to connect using golang/golang libraries to the new V2 API

Thank you. There are a number of v2 libraries in Go written by members of the community, but we don't currently have plans to add specific Go examples to this repository. We would evaluate examples that match the format of the existing ones if they were contributed.


Page becomes unresponsive when loading all sensors

There is a significant period of time - while the data is being parsed for all the various sensors - during which the page is unresponsive. What are some ways we can mitigate this? Not have a view with all sensors?

Other options:

load only X points per graph
load only past 1 hour of graph data
only show X graphs with an option to display X more at bottom of page
when pressed

Matt Taylor
OS Community Flag-Bearer
Numenta
On Thu, Dec 17, 2015 at 2:11 PM, Jeff Fohl<EMAIL_ADDRESS>wrote:

There is a significant period of time - while the data is being parsed for
all the various sensors - during which the page is unresponsive. What are
some ways we can mitigate this? Not have a view with all sensors?
—
Reply to this email directly or view it on GitHub
https://github.com/rhyolight/smartthings.htm.bridge/issues/16.

I like having a view with all the sensor graphs. It is especially useful if they can be synced (I had some troubles doing this with Dygraphs but I know it is possible because I've done it before). This would allow users to drill down on time periods on all charts at once.
I think a reasonable default data period of 1 day might make sense for all charts. They should all have some data over the past 24 hours, although some of them might take longer to load because they have lots more data.
It would be good to mitigate this by showing some loading indicator individually for each chart. There will also be something a bit jarring when the last chart appears and they all snap to the same time period, so we may want to address that, too.

Matt, can you help me understand why a user would like to see all charts with the same time range? Are you imagining the SmartThings to always be grouped in some logical way? Such as - this is a snapshot of the Numenta office over the last day.
The problem we are running into is that some of the sensors produce a huge amount of data, and some produce very little, over a 24 hour period. With a 24 hour window, the browser really bogs down. Even if we show some visual feedback to indicate data is being loaded, that won't prevent the page locking up. The only ways I can think of preventing this are:

Use a maximum number of rows as the default request, and set it to a reasonable number, instead of a time window.
Perform some kind of subsampling on the server, so the client never has to render more than a certain number of rows.
Use a server-side charting tool.

Main reason is to correlate anomalies across sensors. But we are still far from that right now. I have some backend rework to do before the HTM predictions will be good (aggregation, model param tuning).
So for now if it is troublesome, don't worry about it.
Sent from my MegaPhone

On Dec 19, 2015, at 8:23 AM, Jeff Fohl<EMAIL_ADDRESS>wrote:
Matt, can you help me understand why a user would like to see all charts with the same time range? Are you imagining the SmartThings to always be grouped in some logical way? Such as - this is a snapshot of the Numenta office over the last day.
The problem we are running into is that some of the sensors produce a huge amount of data, and some produce very little, over a 24 hour period. With a 24 hour window, the browser really bogs down. Even if we show some visual feedback to indicate data is being loaded, that won't prevent the page locking up. The only ways I can think of preventing this are:
Use a maximum number of rows as the default request, and set it to a reasonable number, instead of a time window.
Perform some kind of subsampling on the server, so the client never has to render more than a certain number of rows.
Use a server-side charting tool.
—
Reply to this email directly or view it on GitHub.

this was fixed via #23 . By default, charts now start with just 100 rows. Though, it is still possible to lock up the page by applying a large number of rows to all of the charts on the Sensors page.


Refactor RemoveUserRoom from PersistedRepository

Figure out a good replacement in EF Core

public void RemoveUserRoom(ChatUser user, ChatRoom room)
{
    RunNonLazy(() =>
    {
        // The hack from hell to attach the user to room.Users so delete is tracked
        ObjectContext context = ((IObjectContextAdapter)_db).ObjectContext;
        RelationshipManager manger = context.ObjectStateManager.GetRelationshipManager(room);
        IRelatedEnd end = manger.GetRelatedEnd("JabbR.Models.ChatRoom_Users", "ChatRoom_Users_Target");
        end.Attach(user);

        room.Users.Remove(user);
    });
}

Since we aren't using any virtual collections, can we get rid of the RunNonLazy function entirely and just use this line?
room.Users.Remove(user;

With the new entities acting as join tables, we have to first find the correct ChatUserChatRooms object based on the given user and given room then remove it from the room's Users list


ttml play issue

Have you read the FAQ and checked for duplicate issues:yes
What version of Shaka Player are you using: latest
Can you reproduce the issue with our latest release version:demo
Can you reproduce the issue with the latest code from master: demo
Are you using the demo app or your own custom app:demo
If custom app, can you reproduce the issue using our demo app:
What browser and OS are you using: any
What are the manifest and license server URIs:
*(you can send the URIs to<EMAIL_ADDRESS>instead, but please use GitHub and the template for the rest)*sent to mail
What did you do? Opened stream and waited for subtitles
What did you expect to happen? Subtitles in player
What actually happened? No subs appeared, but in http://dashif.org/reference/players/javascript/v2.5.0/samples/dash-if-reference-player/index.html it works fine. I suppose there is some trouble with ttml itslef, but how to workaround this problem? We need to lauch stream on your player with subtitles.

Looking over the caption mp4s, I think see the problem.
Our mp4 ttml parser assumes that an mp4 will only have a single mdat with ttml inside. These samples, however, have two mdats containing ttml each. Therefore, we end up ignoring the first mdat, and only using the second one... and the second mdat has only a single ttml cue in it, and that cue has a duration of 0.
This should be fairly simple to fix. Thanks for pointing it out.

Is there any way to make a hot fix on 2.2 version by ourself? We cannot wait for 2.3 version...

Well, I got the change out now, so you can just pull from master.

On reflection I'm not entirely sure if this is a bug, or if it's bad content, but I can't find a spec for ttml in mp4 so I'll leave the bug label for now.
This... bug (?) should be present in 2.0, but this change will only work after the ttml parser refactoring in 2.1.

Maybe label is enhancement?
Thanks a lot, it works now.

The fix has been cherry-picked to v2.2.x and will be released in v2.2.2.

Guys, have not you destroyed fix in 2.3.0? We checked new version and it seems to be does not work, if button cc is pressed, then captions are not downloaded

@theodab @joeyparrish
Guys, have not you destroyed fix in 2.3.0? We checked new version and it seems to be does not work, if button cc is pressed, then captions are not downloaded


feat: update unity pipelines to the new repository structure

Uses @dcl/unity-renderer instead of the legacy decentraland-renderer which was published by this repository.

I removed the documentation that belongs to the unity editor. In my branch of unity-renderer I'm updating the documentation for my next PR @kuruk-mm


New session attempts retry count

Codecov Report

Merging #177 into master will increase coverage by 1.68%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   73.94%   75.63%   +1.68%
==========================================
  Files           5        5
  Lines         664      669       +5
==========================================
+ Hits          491      506      +15
+ Misses        152      141      -11
- Partials       21       22       +1

Flag
Coverage Δ

#unittests
75.63% <100%> (+1.68%)
:arrow_up:

Impacted Files
Coverage Δ

main.go
62.34% <100%> (+0.23%)
:arrow_up:

selenoid.go
75.36% <100%> (+3.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429fe17...9f67e75. Read the comment docs.


EventIDs are not uint32

What does this pull request do?
Fixes improper type which may silently return invalid eventIDs due to truncation.
Where should the reviewer start?
... line 155?
How should this be manually tested?
	dev, err := fsevents.DeviceForPath(cfg.WatchDir)
	if err != nil {
		return nil, err
	}
	tm := time.Now().Add(-time.Hour)
	tmEventID := fsevents.EventIDForDeviceBeforeTime(dev, tm)

	es := &fsevents.EventStream{
		Paths:   []string{cfg.WatchDir},
		Latency: time.Second,
		Device:  dev,
		EventID: tmEventID, // before change, cast required here
		Resume:  true,
		Flags:   fsevents.FileEvents | fsevents.WatchRoot | fsevents.IgnoreSelf,
	}
	es.Start()

updating type cast to match the rest of the api

Thanks Jeremy.
Have you signed the Google CLA? We need contributors to sign the CLA so that fsevents can be used in Go tools in the future.
https://cla.developers.google.com/about

Whoops missed that, but yeah I have signed the CLA for another project.

Thanks. I've invited you to the GitHub team for fsevents so you can create branches and pull requests without needing a fork in the future.


Update README.md

Hi,
This small and useless PR adds a button to get your app on F-Droid + add Qwant to the list of available ressource.

Thanks!


[vm-runtime] move gas loading code from Move VM to Libra VM

This code is specific to the Libra VM, so it should live here.
Prerequisite for Move/Libra VM separation.

@bors-libra r=runtian-zhou

:pushpin: Commit c175b15 has been approved by runtian-zhou

:hourglass: Testing commit c175b15cc2ef4ed8e9b612809c715745734c95af with merge 34d2b87edfdcdb9bf3449860457f2cae18df1cce...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: runtian-zhou
Pushing 34d2b87edfdcdb9bf3449860457f2cae18df1cce to master...


Add context to strings

This commit adds a DList Text to the NVStr constructor. This allows haskell
code that generates string to give them a context, which will be tracked when
the string in used.
This allows, for example, to determine the dependencies of a derivation.

I used a DList, because I want O(1) concatenation, and I don't expect to read it except one when I consume it to find out the dependencies of a computation.
Alternative
Instead of hardcoding for DList Text, we could make it work with any monoid. That would adding one more type parameter to all types (NValueF c m r, NValue c m and ValueSet c m)

@madjar Looks good. How about instead of using a new dlist dependency, we just use Endo?  As long as you don't need to apply other sorts of list operations on the dlists, then Endo works nicely for simply accumulating strings in this style.

@jwiegley I'm not entirely convinced. The signature NVStr Text (Endo ([Text])) seems much less clear to me, so I'm afraid that while saving us a dependency, it would have a non-trivial cost in term of readability and understandability of the code.
The call for this trade-off is your, though, and you get the final say :)

@madjar Well that's easy. Elsewhere just define:
type DList a = Endo [a]

@jwiegley Here you go :)
One change I made while rebasing is changing the return type of NVLiteralPath + NVStr from NVLiteralPath to NVStr, in order not to discard the context. For reference, the behaviour of C++nix for this is to fail if the context is non-empty ; I can do that, but then I'll move away from DList.


add function comments for autograd

docString is to explain the APIs.
We do not need to make it wordy, just make it clear.
E.g., for a + b, we do not need to have "a" is the first operand. Instead, it is more useful to explain if a and b must be of the same shape, is boradcast done automatically.

@nudles  I've checked the whole file again and fixed all the problems. I will create another PR later.