[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
03870a2ac4cbc675d719fb3822ae3b19768a6851
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Fix]Recovery Traffic Control Config

Purpose of the pull request
Due to https://github.com/apache/dolphinscheduler/commit/4114cb07f64950f88ffb4aa8a4ecc4815f32d76b#diff-f2f54230647b5ed6920efc032cd61c4dc2acd8f728ad0f43aef1e8fd3f9793ed , dev branch has no Traffic Control Config in the YAML file. I recovery Traffic Control Config config

Brief change log

modified:   docs/docs/en/architecture/configuration.md
modified:   docs/docs/zh/architecture/configuration.md
modified:   dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/TrafficConfiguration.java
modified:   dolphinscheduler-api/src/main/resources/application.yaml

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

RateLimitInterceptorTest.
TrafficConfigurationTest.

Codecov Report

Merging #10505 (685ce8c) into dev (79ce5d7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10505      +/-   ##
============================================
- Coverage     40.87%   40.86%   -0.01%
+ Complexity     4852     4850       -2
============================================
  Files           886      886
  Lines         36032    36032
  Branches       3998     3998
============================================
- Hits          14729    14726       -3
- Misses        19847    19850       +3
  Partials       1456     1456

Impacted Files
Coverage Δ

...eduler/api/configuration/TrafficConfiguration.java
100.00% <ø> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (-1.34%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.08% <0.00%> (-0.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ce5d7...685ce8c. Read the comment docs.

PTAL @kezhenxu94

Hi, which milestone will be specified?

Hi, which milestone will be specified?

I just marked it for the next version.

Sure, thanks @SbloodyS


[Feature request] Change launch handling to allow opening in new tabs instead of new instances for different launch types

Is your feature request related to a problem? Please describe.
Currently, when Files is launched using command line arguments, it opens in a new instance instead of a new tab. When Files is set as the default explorer, folders opened through Search, PowerToys run, and VSCode all open in new windows instead of tabs.
Also, when Files is launched with no arguments from the start menu, it opens a new instance. This is annoying as opening a new instance is slower, and pressing other apps on the start menu such as edge open the current instance, not a new one.
Describe the solution you'd like

Adjust the launch event handing in Program.cs to open in a new tab when launched with CommandLineArgs.

Remove requirement for arguments to open in a new tab instead of instance so that launching from start opens the current instance

I also think the "when launching from the jump list -> open new tab / new instance" option should be changed to a universal setting for opening new windows or tabs when launched. It appears this is already the case, it's just that it's labeled oddly. I think the label should be changed to say "When opening a folder in Files".

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
I have already done the work for it and will open a PR soon. :)

In the future for command line launch there could be a command line argument to overwrite this behaviour:
Files c:\users -> honours the startup setting
Files c:\users -newwindow -> opens new window
Files c:\users -newtab -> opens new tab (or new instance if not running)

I'm not sure if opening from the start menu should open a new tab.. why would you click on the start menu tile instead of opening a new tab from the app? Should the setting when launching with a path be distinct from the setting when no argument is specified? + @yaichenbaum

I'm not sure if opening from the start menu should open a new tab.. why would you click on the start menu tile instead of opening a new tab from the app? Should the setting when launching with a path be distinct from the setting when no argument is specified?

@yaichenbaum?

Sorry I think I wasn't being clear. I think clicking the tile on start should open to the current instance (if it exists), like Edge does now.
However I realize now this may not even be possible anyway, as my current implementation would break shift+clicking to open a new Window on the taskbar and I haven't found a way to check if Files was launched from the start menu.


jest does not respect .babelrc env:test after failing with modules:false

Do you want to request a feature or report a bug?
bug
What is the current behavior?
Jest is ignoring babelrc env:test settings, sometimes.  Seems that after jest has failed from a babelrc misconfig, it can not recover even when the config has been corrected (as if .babelrc is being cached only when an error happens).
If the current behavior is a bug, please provide the steps to reproduce and either a repl.it demo through https://repl.it/languages/jest or a minimal repository on GitHub that we can yarn install and yarn test.
Bare with me, this is pretty annoying.
https://github.com/Lokua/throw-away-jest-repro.
If you clone,  yarn install, and yarn test - everything will pass! Great! This was a huge surprise to me because I discovered this after cloning this reproduction to confirm that you'd see it fail like I am locally. Huh? In other words my original origin is failing, but the clone of remote that came from origin isn't (exact same code)!?
Now, change .bablerc to look like the following:
{
  "presets": [
    ["env", {
      "modules": false
    }]
  ]
}

This will understandably fail because of the modules: false for all envs. But now here's the thing, put the .babelrc back the way it was, with the "env":{"test":{"presets":[["env", {"modules":"commonjs"}]]}} part, and your tests that used to pass under this exact config should fail. At least in a messed up way I hope it does so we can get to the bottom of this! ;P
What is the expected behavior?
I would expect the before and after scenarios mentioned above to output the same results.
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
node 6.8.0
npm 3.10.8
yarn 0.19.1
jest 19.0.2
OSX El Capitan 10.11.5
Also, for good measure, I have tried removing and reinstalling after the failure. I have also ran yarn cache clean && rm -rvf node_modules && yarn install && yarn test.  Once it fails, the correct config makes no difference.
The test will pass if a) fresh clone of repo or b) copy files (after the whole failure switcharoo scenario) to a new directory.

Sorry to spam your issues. I just went through the steps I mentioned above again (fresh clone, switched babelrc back and forth), and the tests do pass again. The original local repo, however, which is the same code (with env:test part), still won't pass. Copying the code from this local repo to a different folder, however, does result in passing tests. Wish I could provide you with something more concretely reproducible.

Try to run Jest with --no-cache once when you change .babelrc.


Is there a linux version ?

Just asking, because I want to go on Linux soon, bnut your program is awsome, so is there a linux version ?

I'm dumb, issue closed, just had to compile it from source.


updates expected throttle_time validation

Copying the default config throws an exception because throttle_time is expecting a number instead of the 'auto' string

Both a literal 'auto' string and any number should pass validation. And it should be optional. So you need to use a function that returns true for 'auto', any number or nil.
:help vim.validate in case you're confused :)


progress event doesn't fire

using the code example but it seems not to be working.
any idea?

It works on my machine, what node version, OS, request version etc are you using?

OS X 10.11.5
node 6.2.1
request 2.72

Are you trying with http://google.com/doodle.png? It seems that image no longer exists.

I tried with a different URL and different mime types
On Sat, Jun 11, 2016 at 12:03 PM, André Cruz<EMAIL_ADDRESS>wrote:

Are you trying with http://google.com/doodle.png? It seems that image no
longer exists.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IndigoUnited/node-request-progress/issues/22#issuecomment-225345761,
or mute the thread
https://github.com/notifications/unsubscribe/ABpaDZKXURJoPlBDmBr7ul6xnaB3FJD_ks5qKnnTgaJpZM4Ize44
.

This works for me with the same node version and I'm also using OSX:
'use strict';

var request = require('request');
var progress = require('./');

progress(request('https://gitlab.com/xamiro/xcf-dist-windows/repository/archive.zip?ref=master', function (err) {
    console.log('finish!', err);
}))
.on('progress', console.log.bind(console, 'progress'))
.on('error', console.log.bind(console, 'error'))
.on('end', console.log.bind(console, 'end'));

Are you using a URL with big files? If the download is too fast, the progress event won't be fired. See delay and throttle options.

I've updated the URL above, the previous one wasn't reporting the Content-Length header

ok the updated url works -  thanks.
what about POST progress on upload files? supported?

No, see #17

Thanks, you may close this issue.


changed mentions of Bitcoin Cash, BCH to Ecash, XEC when that network is selected

PR changes mentions of Bitcoin Cash and BCH to Ecash and XEC respectively when that network is selected.
An extra line of text is added to the configure page to display with which network the wallet is connected.

shoot, just noticed this somehow broke the send receive tab, PR will have to be updated

closing this PR and deleting my branch as the changes never got accepted


feat: handler for ban and unban messages

Handle /ban and /unban commands from servers, propagate them to other servers, and save them as privatebans.
Resolves #124

Fully tested on a Factorio server deployment.


Per-claim multi attribute separator

Is your feature request related to a problem? Please describe.
In our environment, we use Active Directory to populate our user store, and there are commas in the cn and displayName attributes. When attempting to use these values in a SAML claim, they are broken into two claim attributes due to the multiAttributeSeparator. I have scoured the docs and checked the source and as far as I can see the separator is only configurable on user store level, not per claim. The result of this is our users' names are split into two attributes in the SAML response, and a vendor we are working with is only using the first value, meaning only half of the user's full name is included. We do want this separation for e.g. roles and other multi-valued strings, so we are not able to disable this feature on the user store level.
Describe the solution you would prefer
The ability to disable multiAttributeSeparator parsing per-claim without affecting other multi-valued claims.
Additional context
https://github.com/wso2/carbon-identity-framework/blob/d17b1f4649587dc4882ccda56d6783d69fcbddb4/components/entitlement/org.wso2.carbon.identity.entitlement/src/main/java/org/wso2/carbon/identity/entitlement/pip/DefaultAttributeFinder.java#L173-L191

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!

Still an issue, but I no longer work with the affected system, so doesn't bother me 🎉


Fix windows dev issue

Please can someone with access to a windows machine check if this fix is sufficient?

Do we need this changes? Otherwise we can close this PR and delete the branch.

Sorry for the late comment here: this does indeed work

OK nice but the question is do we need this in the master branch? If yes then we need to merge this PR and not just close it. Otherwise it's fine.

My bad; yeah it should be merged, as long as it's not interrupting anyone else

@ntalen In this case please add a review and merge it afterwards.

Pretty new to Github, thought only the master could do merges.  Learn something new each day~


revert: "feat: produce sigstore Bundles for generic generator and go builder workflows"

Reverts slsa-framework/slsa-github-generator#3777
Lots of new failing errors in our e2e tests today. We may have missed something when testing these changes.
For now, we should revert while we debug, and come up with more robust testing methods.

https://github.com/slsa-framework/example-package/actions/runs/11511156484/job/32044242878#step:6:125
https://github.com/slsa-framework/slsa-github-generator/issues/3967

**** Verifying provenance authenticity with verifier at HEAD *****
Testing against builder args
  **** Default parameters (annotated tags) *****
WARNING: Insecure SLSA_VERIFIER_TESTING is enabled.
Verifying artifact hello: FAILED: missing signing certificate in bundle

FAILED: SLSA verification failed: missing signing certificate in bundle
✖ 1 == 0 :: not main default parameters (annotated_tags)
Error: Process completed with exit code 1.

@haydentherapper @loosebazooka


Check boto3 session allows calling 'inspector2' client service

Considering not all accounts might have 'inspector2' configured, this avoids breaking the AWS import module unless the service is available.

This might not be required if the latest boto3 client is being used. Closing this for now.


conda tensorflow-gpu version conflict

The problem happened when I install tf-gpu by conda instead of tf cpu version. It seems like cudnn mismatch problem and conda provides only 7.3 and 7.6 version. Is there any solution to build appropriate environment by conda?
W0902 04:30:46.757832<PHONE_NUMBER>83232 deprecation_wrapper.py:119] From /home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:1919: The name tf.nn.fused_batch_norm is deprecated. Please use tf.compat.v1.nn.fused_batch_norm instead.
W0902 04:30:46.759829<PHONE_NUMBER>83232 deprecation_wrapper.py:119] From /home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py:3976: The name tf.nn.max_pool is deprecated. Please use tf.nn.max_pool2d instead.
W0902 04:30:47.864533<PHONE_NUMBER>83232 deprecation_wrapper.py:119] From /home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/imageai/Detection/keras_retinanet/backend/tensorflow_backend.py:22: The name tf.image.resize_images is deprecated. Please use tf.image.resize instead.
W0902 04:30:48.388976<PHONE_NUMBER>83232 deprecation.py:323] From /home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/imageai/Detection/keras_retinanet/backend/tensorflow_backend.py:46: add_dispatch_support..wrapper (from tensorflow.python.ops.array_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.where in 2.0, which has the same broadcast rule as np.where
2019-09-02 04:30:54.357566: W tensorflow/compiler/jit/mark_for_compilation_pass.cc:1412] (One-time warning): Not using XLA:CPU for cluster because envvar TF_XLA_FLAGS=--tf_xla_cpu_global_jit was not set.  If you want XLA:CPU, either set that envvar, or use experimental_jit_scope to enable XLA:CPU.  To confirm that XLA is active, pass --vmodule=xla_compilation_cache=1 (as a proper command-line flag, not via TF_XLA_FLAGS) or set the envvar XLA_FLAGS=--xla_hlo_profile.
2019-09-02 04:30:54.484078: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudnn.so.7
2019-09-02 04:30:56.829854: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
2019-09-02 04:30:56.831738: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
Traceback (most recent call last):
File "/home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/imageai/Detection/init.py", line 340, in detectObjectsFromImage
_, _, detections = model.predict_on_batch(np.expand_dims(image, axis=0))
File "/home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/keras/engine/training.py", line 1274, in predict_on_batch
outputs = self.predict_function(ins)
File "/home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py", line 2715, in call
return self._call(inputs)
File "/home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py", line 2675, in _call
fetched = self._callable_fn(*array_vals)
File "/home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1458, in call
run_metadata_ptr)
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
(0) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[{{node conv1/convolution}}]]
[[nms/strided_slice_121/_2001]]
(1) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[{{node conv1/convolution}}]]
0 successful operations.
0 derived errors ignored.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "img.py", line 10, in
detections, objects_path = detector.detectObjectsFromImage(input_image=os.path.join(execution_path , "image2.jpg"), output_image_path=os.path.join(execution_path , "image2new.jpg"), minimum_percentage_probability=30, extract_detected_objects=True)
File "/home/users/tzong_hann/anaconda3/envs/myenv/lib/python3.6/site-packages/imageai/Detection/init.py", line 526, in detectObjectsFromImage
"Ensure you specified correct input image, input type, output type and/or output image path ")
ValueError: Ensure you specified correct input image, input type, output type and/or output image path

I solve it by install tf-gpu=1.12, rather than 1.13 as mentioned. Could requirement file provide detailed version? It may help someone like me.


CB-6125 creator of an environment will automaticly get enviromentAdmin

@keyki or @horadla23 pls review

There is no un-assignment here. I don't know if it's needed or not. @horadla23 might know.


Insomnia only opens on terminal command

Expected Behavior
Open insomnia
Actual Behavior
Nothing happens
Reproduction Steps
Show Applications > Search for insomnia > clicks icon > Nothing happens.
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2023.1.0
What operating system are you using?
Ubuntu
Operating System Version
22.04
Installation method
apt
Last Known Working Insomnia version
No response

I can only open Insomnia on terminal command. I wish I could open it by clicking on the icon located in the Applications menu.


debug pypy memory leaks with pypy upstream

when we've used pypy with custodian for long running operations (s3 scans) we get significant performance boosts, but accompanied by signficant memory growth, i strongly suspect we could probably reproduce this standalone, and the cause is likely the dynamic class construction of the sdk, which we should try and get to standalone reproducible case for discussion with pypy upstreams.
just creating a session / client / and doing an api call in a loop should be a good start for standalone reproduction.

Have a look at this @kapilt
https://gist.github.com/skurfer/41f99002f56f4a1c2f76fdf32e711351
There are some small reproducible leaks from that (in both PyPy and C Python), but if you know of some code that would better demonstrate the problem, let me know.

you'll need probably at least one maybe two orders more magnitude.

here's a standalone example of the pypy memory leak, needs a big bucket with a few million objects to exhibit
https://gist.github.com/kapilt/b2550e6b36da5650230a763268e3bd0a

and it looks like the root of the issue is creating and using boto3.Sessions, switching out to reusing a client in separate threads seems to work well to avoid the memory leak.

I've hammered on this from a number of angles.
The leak in your example occurs at the line:
info = client.head_object(Bucket=bucket, Key=k['Key'])

But you can trigger it with even simpler interactions, like:
getattr(client, 'meta' )

This applies to nearly any attribute of the client.
However, calling getattr to get the _cache or _class do not trigger the leak (maybe a clue?)
I believe the issue is somewhere inside the botocore.client.ClientCreator.     Initially I was convinced it was the _create_api_method creating closures shared between the Creator and the constructed class, but creating a dummy script that does the same thing doesn't exhibit the same leak.
If not there, then I'm suspicious of the Session class's SESSION_VARIABLES class attribute.   I'm not certain that class vars are thread safe, and I note they are using shallow copies which would seem to defeat the purpose.

hmm.. thanks i guess the question is does this reproduce on cpython, if so then a bug on boto, if not we should file against pypy upstream.


Should be able to restrict by a set of urls not just a single path.

Postponing this until a general purpose clustered spider emerges as a part of the extractor module.


Ability to comment on lines of code in a pull request

It would be nice to have the possibility to comment on specific lines of a code in a pull request - as it is possible in github:

Gitbucket (another github clone written in scala) has it already implemented.

This is what I'm wanting, but take some time to clean up previous tasks. :smiley:

+1

+1

+1

:+1:

It would be great to be able to comment at the pull request level but also on individual commits.

+1

+1

+1
For us this is one of the final main parts to make it basically feature complete. Having comments on code lines (and commits #796) is really a must. Would be a nice bonus for 0.10.0 ;)

+1

+1

+1

+1

+1

@Unknwon: Any update on this? We're thinking of switching from an SVN based workflow to Git + Gogs, but we'd really need this feature. We currently do code review using a very manual process (patches + e-mail), but even there we can comment on sections of code inline :) In fact, I would say most comments are inline.
Great work on Gogs btw!

+1 It is useful for review code in pull request

+1

+1

@ work We use gitlab but I'm looking for an alternative since their update and deployment process was written by crazy monkey in lack of caffeine.
But since pull request code line comments feature is missing we won't be able to switch to gogs since this is mandatory to do easy code review

+1

May be possibly implemented via git-appraise ( #2210 )

@strk As an ops, using the git-appraise cli would be fine for me. But some of my devs would like to have a nice UI to do this.
Frontend developpers, you know....

@theredcat yes I understand that, what I'm saying is that Gogs could just add a GUI to the git-appraise tool. That way users have a choice to either use the commandline or the GUI, and peer reviews would go togheter with the code when repository is cloned.

@strk Thx for the clarification. This would be, indeed, a very nice approach

:+1: git-appraise with a GUI sounds like the perfect road to follow

+1

@strk I think git-appraise would do the job but from what I recall (not sure if it was on gitter or in an issue discussion) @Unknwon wants to keep the way gogs handles the pull request stuff. From my understanding that does result in haveing this implemented for the gogs native way of handling pull request and if someone does the git-appraise way of storing data it has to be handled differently. If the later is done I expect that a user/admin has to choose which implementation of PRs he wants to use.

Agree, this is a must.

this is a must

+1

+9999999999

+1

STOP WITH '+1'

In many cases, especially on popular projects, the result is a long thread full of emoji and not much content, which makes it difficult to have a discussion. With reactions, you can now reduce the noise in these threads.

https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments
USE THAT!
I, and many others, are subscribed here for updates. Your '+1' is just making a mess.

Planned after https://github.com/gogits/gogs/issues/2109

Hi! Any updates on this issue?

Nope. In general, the maintainer of gogs has a lot weird opinions of how to run the project (which is ok since it he owns it) so most people have abandoned gogs in favour of gitea.

On 15 Aug 2017, at 00:12, Federico Bond<EMAIL_ADDRESS>wrote:
Hi! Any updates on this issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/gogits/gogs/issues/1644#issuecomment-322324305, or mute the thread https://github.com/notifications/unsubscribe-auth/AP5JX4DXlaDkY6ryXYpJBODx4He7AJlhks5sYMZigaJpZM4F9kHN.

@Unknwon deleting comments? Seriously?...

Nope. In general, the maintainer of gogs has a lot weird opinions of how to run the project (which is ok since it he owns it) so most people have abandoned gogs in favour of gitea.
~ @snoozeMoose

Any updates??

Any updates now? It's almost 2018, and this issue was opened in 2015.

Hello - Will this feature be implemented at all?

@kathiouchka I would suggest moving to gitlab.
its now 3 years and they didn't do anything

There's a much more active fork of Gogs called Gitea. I believe this feature hasn't been implemented there either but the plan is to use git-appraise to take care of it, which is a very nice solution.

Thanks, the prob is my whole infra is based on gogs, everything is great, BUT this feature. Meh, i'll wait another year or two.
jk, hello gitlab!

@tgy wait, author remove your messages about Gitea.

Choose GitLab if you need feature-rich Git hosting! Seriously! Or just pay GitHub, it's just $7/month.  Very unprofessional.
Take a look on your advertisement: "A painless self-hosted Git service."
Commenting on lines of code is a basic commodity for git hosting, not some extra feature.

@Freddis oh wow, thanks for such a great statement! For over 2.5 years you finally concluded with a paragraph and not a single moment to fork?
I have zero interest on philosophy discussion, thus I'll delete both of our comments.

What needs to be done so that this can become a reality? I see that there may be a dependency on #2109, but I don't see any progress on that issue.

@forestbelton at the risk of getting this comment deleted, gitea has comments available in the 1.6.0 release

+1

Are you going to update it?

I'm interested into this. Is anyone already wordking on it ?

Any updates on this major missing feature in Gogs? :D <3

i start made this feature, but my progress is slow
my progress on this video https://youtu.be/2Prxnibd8IM
branch here https://github.com/ivanbogomoloff/gogs/commits/feature/1644/ability-comment-pr
nowaday i implemented:

simple ui on html+js (add, delete, markdown render)
http post endpoint with send comment data and response rendered code comment
but now it very raw

i plan finish this feature in very very simple implementation to august, i hope do it

The developers of Gogs have no plans at all to implement this great feature?

Fyi, it is possible in Gitea now which is a fork of Gogs
On Tue, 4 May 2021 at 06:49, Aleksei Badyaev @.***>
wrote:

The developers of Gogs have no plans at all to implement this great
feature?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gogs/gogs/issues/1644#issuecomment-831697858, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALUPNHKFVSRQJXC5LBB7C3TL6DH5ANCNFSM4BPWIHGQ
.


lksctp-tools: 1.0.19 -> 1.0.20

Changes: https://github.com/sctp/lksctp-tools/compare/v1.0.19...v1.0.20
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4555

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4584

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4603

Hi @trofi, seems like upstream retagged 2 days ago UnU
Currently on staging-next
https://github.com/sctp/lksctp-tools/issues/62


Revision for new dashboard

This PR is a compilation of small fixes:

Replaced <svg> elements with tabler icons/lucide svelte
Made LinkForm span vertically
Added a second close button at the top of the ImportFromGithubModal
Fixed findSocialIcon for brand icons
Added zod's .url() for the LinkForm schema
Added a background to the search area
Fixed some alignment issues

Good work as always, merging :)


Support time offset information

The changes give offset information per character returned relative to the size of the input lattice. This allows you to find out when characters were said!
There is a bug where the first character is always given the timestep value of -1. Any help to try debug this would be great!

Found the bug, or at very least a reasonable workaround. Closing this PR so that I can add a new one with the changes.


SpaceY-Expanded: Update for spacedock

I found a 1.1.5 version for the mod in CKAN-meta
Failed because couldn't download or download is corrupted

@NecroBones, I found a 1.1.5 version for the mod in CKAN-meta
After investigating I noticed that you called the latest version 1.1.4 while you mention 1.1.5 in the changelog. The .zip is also called 1.1.4 but includes files from 1.1.5.

Yes, I think I probably typed it wrong in the spacedock version field. Spacedock (like Kerbalstuff) renames based on the provided version. I'll reupload and clear it up.

@Olympic1 Yep, I had simply uploaded 1.1.4 as 1.1.5. I've corrected it on Spacedock.

Thanks. To fix this and your other PR's, you have to rebase because we added the.kerbalstuff extension to all mods that were on KS.

Not sure I follow. I see that the filename extensions were changed. Does that mean I need to scrap this pull request and re-do it?

yes

Other than the conflict, is this ready for merge @Olympic1?

yes

OK, still learning my way around GitHub. :) I'm forgetting that I have an actual branch. :) Thanks guys!

@NecroBones No worries, I'm having.. "fun"? Trying to figure out how to solve merge conflicts. :D


[relates #626] Create test user / roles programmatically

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/475/
Test PASSed.


Bitches-Update github-community-guidelines.md

Help me with my coins and help me a.s.a.p motherfuckers

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Do I have any type of help here from anybody who loves to help retards who forgot how to use a phone and get some coins into a wallet

Maintain morality, ethics, humanitarian liberties, share society
Good parents value the weak common sense of good and evil. Human sympathy for natural water bodies and the volatility of natural water bodies. Responding to a good mind with virtue Responsible for helping communities achieve equality, happiness, pure smiles. Giving love to each other, good heart, creating a profitable career, respecting others, striving to work and develop for the public. It does not discriminate against national communities, color, age, gender, nationality, religion. We hope the outcome will be a happy outcome for friendship without borders. lead to peace Meaning of all religions, goodness, morality, responsibility, environment, the discipline of morality. fully contribute to society
Add tools to manage well-being, healthy, clean, bright, leading to God. Children are the purest things we must protect most for the future of society in guiding today's emerging communities to the happiness, appreciation, learning, love, respect, sharing, and equality of natural communities. Honest friendship for the global food chain
Security, quality of accommodation Caring for the Elderly, the Disabled, the balance of reality must be permanently composed of the Spirit of God.
https://vimeo.com/blog/post/how-to-compress-a-video?success#newsletter
MARS INTERPLAST CO., LTD @.*** @raengkrud (twitter.com)https://twitter.com/raengkrud
MARS INTERPLAST CO., LTD (godaddysites.com)
MR RAENGKRUD SARID[cid:43b37794-5edd-4b3c-bcef-021c180010de]
[cid:450480b2-84cb-4994-beca-f6e28416d976] https://mars-interplast.business.site/
[cid:138329a5-f792-4dae-9768-a6fd1753c0a4][cid:39b17570-c693-4627-a538-686c3320131b][cid:9120e977-1228-4fbb-bb2d-3361dfc1347c][cid:84f40f8b-30c8-4e76-aec5-a6c6f85c7904]                                                                               https://www.linkedin.com/company/75638870/admin/
[cid:7769a07c-3958-40a3-9a68-277e0be2f37f]

จาก: Dusto206 @.>
ส่ง: 12 ตุลาคม 2564 16:38
ถึง: github/docs @.>
สำเนาถึง: Subscribed @.***>
ชื่อเรื่อง: Re: [github/docs] Bitches-Update github-community-guidelines.md (#11110)
Do I have any type of help here from anybody who loves to help retards who forgot how to use a phone and get some coins into a wallet
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgithub%2Fdocs%2Fpull%2F11110%23issuecomment-940839583&data=04|01||69f6b7aec4e44202eca908d98d6405c2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637696283004279682|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bgRRb19mbx1HyyK1O1VCFJd6EWuQvyOD9F9eGlDR1n0%3D&reserved=0, or unsubscribehttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUNYKG3VF7LDWAMFWZPNQE3UGP6YTANCNFSM5F2DUIGA&data=04|01||69f6b7aec4e44202eca908d98d6405c2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637696283004289636|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=dEgKhomP%2FkKcYRSjVDkPOD%2BuUuTD3mYeudHVu2nGNkQ%3D&reserved=0.


meow v6.0.0 needs an upgrade to v10.0.0

Affected Packages
@changesets/cli
Problem
meow v6.0.0 has trim-newlines v3.0.0 as a dependency which causes this alert to pop up:
Uncontrolled Resource Consumption in trim-newlines.
A fix was introduced in trim-newlines v3.0.1 and meow bumped it's dependency version from trim-newlines v3.0.0 to trim-newlines v4.0.0 on Apr 27, 2021 (commit) and released it as part of meow v10.0.0 on May 5, 2021 (commit).
Steps to reproduce
npx degit vercel/turborepo/examples/design-system design-system
cd design-system
yarn install
git init . && git add . && git commit -m "Init"

Push it to a GitHub repository and enable Dependabot security alerts. Dependabot will create three alerts and one in particular (Uncontrolled Resource Consumption in trim-newlines) has to do with trim-newlines, meow and @changesets/cli.
Proposed solution
Upgrade to meow v10.0.0.

Also discussed in https://github.com/changesets/changesets/issues/587

Yeah, I commented there but it was a 2yo issue with no recent activity.
Sorry for the duplicate.

@changesets/cli has moved away from meow in https://github.com/changesets/changesets/pull/1392


Mobile Size Padding

Please look at both of the above pictures, "HELPING YOU IS OUR AIM" tagline does not have any left padding which does not look so nice. Also the "send message" button has its text being cut in the mobile view. I will resolve these minor issues, please allow me to work on this issue.

@RiyaGupta89 go ahead .

@Ankita297 Done. Please have a look.


Build-in search throws an error on production builds / Unrecognized key(s) in object: 'stopwordLanguages'

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
I tried to add the search as described in here: https://tina.io/docs/reference/search/overview/
But npm run build fails with:
npm run build

><EMAIL_ADDRESS>build
> tinacms build && hugo

Starting Tina build
Checking clientId and token. ✅
Checking branch is on Tina Cloud. ✅
Checking indexing process in Tina Cloud... ❌
IndexFailedError: Attempting to index but responded with status 'failed', To retry the indexing process, click “Reset Repository Cache” in tina cloud advance settings.  [
  {
    "code": "unrecognized_keys",
    "keys": [
      "stopwordLanguages"
    ],
    "path": [
      "search",
      "tina"
    ],
    "message": "Unrecognized key(s) in object: 'stopwordLanguages'"
  }
]

This happened to me in production (deployed to Cloudflare Pages), but is reproducible in development as well, follow the steps below.
In Local Mode the search config works perfectly fine:

npm run dev
http://localhost:1313/admin/#/collections/post/~

Reproduction
https://github.com/jobee/tinacms-reproduction
Steps to reproduce

Connect https://github.com/jobee/tinacms-reproduction to a new Tina Cloud project
git clone git@github.com:jobee/tinacms-reproduction.git
cd tinacms-reproduction
cp .env.example .env
Add ID & Tokens from the Tina Cloud project
npm install && npm run build

System Info
System:
    OS: macOS 13.3
    CPU: (10) arm64 Apple M1 Pro
    Memory: 934.36 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.14.2 - ~/.nvm/versions/node/v18.14.2/bin/node
    npm: 9.5.0 - ~/.nvm/versions/node/v18.14.2/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Safari: 16.4
  npmPackages:
    @tinacms/auth: ^1.0.3 => 1.0.3
    @tinacms/cli: ^1.5.6 => 1.5.19
    tinacms: ^1.4.6 => 1.5.10

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

@jobee this as fixed in last week's release of @tinacms/cli. Can you check the yarn.lock in your project for the version of @tinacms/schema-tools that is present in your project? Or push that up the yarn.lock to your reproduction.

@kldavis4 I've used npm. It's "@tinacms/schema-tools": "1.4.6"
See https://github.com/jobee/tinacms-reproduction/blob/main/package-lock.json#LL3969C42-L3969C42

@jobee the issue was on the backend and has been resolved. If you go to your project configuration page in Tina Cloud and click Reindex, and then retry the build, it should now succeed.


CASM-2670: Update image refs and resolve vulnerabilities

Resolves CASMPET-5009.

@bklei Is there any possibility of addressing the high and critical vulnerabilities in these images today?

artifactory.algol60.net/csm-docker/stable/docker.io/demisto/boto3py3:<IP_ADDRESS>40
artifactory.algol60.net/csm-docker/stable/etcd-operator:0.12.2-cray


[ENH] Improve cython interface with a more user-friendly compiling interface

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. In my code, I would like to do [...]
so I think the interface of having to setup setup.py can be made simpler, so perhaps a better way to do this could be, and then perhaps compile-and-cache on demand
Describe the solution you'd like
A clear and concise description of what you want to happen, including code examples if applicable.
from cython import cyimport
module = cyimport("module-name.pyx", __path__)

module.somefunction("param1", param2)

Describe alternatives you've considered
cyimport could also change to a better name, perhaps the more explicit cython_import
additionally
module  = cyimport("module-name", __path__)
if no extension is provided it can be assumed to be a cython file
Additional context
I think one of the turn-offs of people when they read the documentation is the setup process, many people are not familiar with setup.py, and I think changing to a better interface can drive more people to using cython

You probably want pyximport?
The big reason for promoting setup.py though is that it's the established way for distributing Python packages.

You probably want pyximport?
The big reason for promoting setup.py though is that it's the established way for distributing Python packages.

@da-woods pyximport is not recommended for production use because it messes with python internals, I was thinking something more production ready
also I don't think every case out there - esp for software that isn't libraries like webservers or similar - uses setup.py, and many "frameworks" like cookiecutter make setup.py for you automatically

@da-woods pyximport is not recommended for production use because it messes with python internals, I was thinking something more production ready
also I don't think every case out there - esp for software that isn't libraries like webservers or similar - uses setup.py, and many "frameworks" like cookiecutter make setup.py for you automatically

We do have cython.inline. I'd imagine a cyimport would not be hard to build on this same infrastructure, though the messy bit here would be in resolving relative imports and especially handling recursive dependencies (e.g. if a.pyx imports b.pyx, would it need to use cyimport as well?).
There's also the fact that it's often preferable to pre-compile everything at installation time vs. on the fly at runtime. I think the best answer here is tighter integration with distutils/setuptools (and possibly tools like cookiecutter as well).

We do have cython.inline. I'd imagine a cyimport would not be hard to build on this same infrastructure, though the messy bit here would be in resolving relative imports and especially handling recursive dependencies (e.g. if a.pyx imports b.pyx, would it need to use cyimport as well?).
There's also the fact that it's often preferable to pre-compile everything at installation time vs. on the fly at runtime. I think the best answer here is tighter integration with distutils/setuptools (and possibly tools like cookiecutter as well).

"big fancy words ahead lol"
you're right about the performance loss, and complexity  for distributing compiled binaries.
but I do feel that people would be more inclined to use cython were the interface just with only minor modifications to an existing codebase
my point is, setup.py is complex, badly documented imo (the realpython article is great for it though), and can be a turn off for many, I feel this process would just make it super easy for newbies to get used to cython
I guess from personal xp, I like programming where the library supports complexity but has encapsulated concepts into sensible paradigms with obvious defaults (think of requests vs urllib)
the matplotlib technique for running cython is incredibly straightforward and that's generally what I find appealing to code in, and I feel that most people would be likely to agree with me
I could be wrong though

"big fancy words ahead lol"
you're right about the performance loss, and complexity  for distributing compiled binaries.
but I do feel that people would be more inclined to use cython were the interface just with only minor modifications to an existing codebase
my point is, setup.py is complex, badly documented imo (the realpython article is great for it though), and can be a turn off for many, I feel this process would just make it super easy for newbies to get used to cython
I guess from personal xp, I like programming where the library supports complexity but has encapsulated concepts into sensible paradigms with obvious defaults (think of requests vs urllib)
the matplotlib technique for running cython is incredibly straightforward and that's generally what I find appealing to code in, and I feel that most people would be likely to agree with me
I could be wrong though

pyximport is not recommended for production use because it messes with python internals

I wouldn't say it does. The integration with Python's import system is fine. The main problems with it are (IMHO):

if does not use cythonize() and therefore requires a different setup than what users would otherwise have for their setup.py
it hooks into the import system. While that's obviously by design, it also means that it gets run on every Python import, which slows things down, both by duplicating module searches and by compiling things are runtime that should rather be compiled ahead of time, especially in a production system.


snoowrap does not work in mobile browsers

(Continued from #32)
Browsers don't allow custom user-agent headers to be set in XHR requests. This is apparently causing some issues with clients being redirected to reddit's mobile site.
It seems to only cause issues on mobile browsers; while the user-agent can't be set in desktop browsers either, reddit seems to work fine with the default user-agent there.

+1

BTW, I'm a framework engineer at Sencha.

Should be fixed in v1.6.0.


Update Grapher View after Changes on the Graph

User Story

I would like the Grapher View to be automatically updated (i.e. redrawn) after spots have been added or deleted.
This should happen regardless, if the changes have been made in the grapher itself (inside grapher adding points is not possible, but deleting points is possible) or in other view (e.g. BDV View, TrackScheme View or Table View).
If many spots have been added or deleted the Grapher View should be only updated once and not multiple times for each added/deleted spot.

Resolved via #342


Import doc for downtime registration

Import doc for downtime registration, taken from https://wiki.egi.eu/wiki/GOCDB/Input_System_User_Documentation#Downtimes

So now we have a nice URL: https://docs.egi.eu/documentation/337/internal/configuration-database/downtimes/


Update spark-standalone.md to fix link

What changes were proposed in this pull request?
Corrected a link to the configuration.html page, it was pointing to a page that does not exist (configurations.html).
How was this patch tested?
Documentation change, verified in preview.

Can one of the admins verify this patch?

Thanks merged into master 2.0 and 1.6


Repl examples on the website are weird

http://scalameta.org/
Reported by @a-nigredo on Gitter.

Fixed by republishing manually, making sure I use 2.11.11.


Ar button does not appear in Instagram's web browser (ios)

Hello all!
When you open model-viewer in instagram's web browser ar-button does not appear on ios devices. On Android there is no problem.
What can we do about this issue? or is it instagram's ios policy about third party applications.
ps: also in linkedin's web browser same thing but on twitter's web browser ar-button appears and working fine.
-->

model-viewer: v1.6

In addition; what type of web browser we have to add on ios or android application to see model-viewer and ar-button.

Hello all!
When you open model-viewer in instagram's web browser ar-button does not appear on ios devices. On Android there is no problem.
What can we do about this issue? or is it instagram's ios policy about third party applications.
ps: also in linkedin's web browser same thing but on twitter's web browser ar-button appears and working fine.
-->

model-viewer: v1.6

we tried that on android and ios.. This is what exactly you said. Androids work well, but on ios there is no model button at instagram's and linkedln's browser. All problems come with ios.
@elalish this should be very usefull for users where comes from instagram and linkedln.

@tpsiaki @AdrianAtGoogle Is there anything we can do to get these webview-type browsers working for AR?

duplicate of https://github.com/google/model-viewer/issues/1511

Yes, let's consolidate this discussion here: https://github.com/google/model-viewer/discussions/1915


[Warnings] On Compile

It compiles just fine but gives these warnings forgot to make an issue about that yesterday after compiling and testing the latest update to ebots just showing ya and letting ya know just in case here's the screenshot.

because these gamemodes not implemented yet, warning doesn't mean error and this warrning are the most fine one just saying these variables are defined but not used anywhere.

I see thanks for telling me this I'll close this now.


Use your own input form

How can I create my own login form?

Hello @chuppasik 👋
I'm assuming you would like to create your own login form with the existing authentication module.
To do this, create your form and interact with the endpoints provided by the authentication module.
The endpoints are defined here: https://github.com/serverpod/serverpod/tree/main/modules/serverpod_auth/serverpod_auth_server/lib/src/endpoints
And can be called in the client through the auth module, await client.modules.auth.<auth provider>, where <auth provider> is the provider implementation you would like to interact with.
You can inspect the implementation of the existing forms to get ideas for how to interact with the provider's methods to get authentication working.
Here is for example the implementation for the email sign-in form: https://github.com/serverpod/serverpod/tree/main/modules/serverpod_auth/serverpod_auth_email_flutter
And in the same folder structure you can find the implementations of the other providers.


Merge bot is asking to run a test and those test doesn't start

I've seen this a bunch of times today - see e.g.:
https://github.com/kubernetes/kubernetes/pull/22264
https://github.com/kubernetes/kubernetes/pull/21851
https://github.com/kubernetes/kubernetes/pull/21904
And a bunch of others
@eparis @lavalamp @mwielgus @gmarek @fgrzadkowski

@ixdy I know he was fighting try to get jenkins to pay attention yesterday...

https://github.com/kubernetes/kubernetes/pull/21907

https://github.com/kubernetes/kubernetes/pull/21982

closing in favor of the issue in kubernetes/kubernetes, as that repo gets noticed...  The problem isn't in code in contrib, the problem is in Jenkins, so we don't have a great place to report it.

@eparis - ok thanks!


Show notifications to users that have started exercises but didn't send them

In order to encourage students to finish their exercises, let's show some kind of notification (popup) telling them they have unfinished exercises.
Also, on the exercises page sort FIRST the in-progress exercises so they easily see what they need to finish.

No need for this.

We have IN_APP notifications
We have email notifications


Fixed typo  seperate->separate

Hi ! Thanks for the fix :)
The CI fail isn't related to your PR. I opened a PR #2286 to fix the CI.
We'll wait for #2286 to be merged to master first if you don't mind

The PR has been merged ! Feel free to merge master into your branch to fix the CI


wr.lakeformation.read_sql_query doesn't pass boto3_session to commit_transaction

Describe the bug
commit_transaction here does not pass along the boto3_session from it's parent function read_sql_query.
How to Reproduce
Without default aws credentials configured on your machine, create a boto3 session and pass it to `wr.lakeformation.read_sql_query`

Expected behavior
commit_transaction uses the boto3_session passed to read_sql_query
Your project
No response
Screenshots
No response
OS
Mac
Python version
3.10
AWS SDK for pandas version
2.19.0
Additional context
No response

Good catch, thanks. Now fixed in main


Light weight Mongodb support like Spring data mongodb.

+1

Blade does not currently have deep integration with mongo, and here is an example that works with mongo.


Invalidate Geoms with TileCover

Invalidate tiles from calculated bounds of supported geom types (multi)(point/line), falling back to timeout value.
Ref: https://github.com/ingalls/Hecate/issues/25

Next steps: Need to figure out the best way to queue this. It absolutely should not block the main request thread. Does it make more sense for this to live as a separate daemon with it's own database connection? Or as a worker thread that is queued with each delta creation?

Closed in favour of https://github.com/mapbox/Hecate/pull/157


Strip prefix of opening fence from closing fence line (#1)

The problem occurs only when construct codeIndented is disabled, as is the case with micromark-extension-mdx-md.

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
Strip whitespace from closing fence line the same way it's done with content lines. This enables to parse indented display math when construct codeIndented is disabled.
This PR (1-prefixed-closing-fence-a) requires the length of the whitespace prefix on the closing fence line to be equal (or less) as on the opening fence line.
An alternate version exists in 1-prefixed-closing-fence-b which behaves as codeFenced. It allows for arbitrary length whitespace prefix on the closing fence line.
I think this version 1-prefixed-closing-fence-a makes more sense as it treats the closing fence line the same way as content lines. But I might have missed the purpose of this behavior in codeFenced hence the two versions.

Hey, thanks for working on this!
I prefer 1-prefixed-closing-fence-b!
The reason is that initialSize is used to strip whitespace from the start. It has a different function.
Can you PR that one?

Codecov Report

Merging #2 (8563a42) into main (0983f46) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          803       803
=========================================
  Hits           803       803

Impacted Files
Coverage Δ

dev/lib/math-flow.js
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I prefer 1-prefixed-closing-fence-b! The reason is that initialSize is used to strip whitespace from the start. It has a different function.
Can you PR that one?

Closing in favor of #3.


Created prototipe of admin feature

Created adminServlet, admin.jps and added files to web.xml. Works by checking if user is specifically logged in an admin account.

Okay, merging to master :)

By the way, that idea of having a more compact navbar sounds interesting! Build a prototype and I'll be more than glad to check it out.


[Func] Add mipmap as new ResourceReader

This is the pull request for issue #473
First I want to implement if/else condition for a class named Drawables. But there is no method that can help me to detect if that resource really exists.
Then I decide to create new class name Mipmaps that can return the the class name of android.R.mipmap.class if SDK_INT >= HONEYCOMB (Or return Drawable as well)
public static class Mipmaps extends ResourceReader {
        protected Mipmaps(String resourcePackageName, Context context) {
            super(context);
            mResourcePackageName = resourcePackageName;
            initialize();
        }

        @Override
        protected Class<?> getSystemClass() {
            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
                return android.R.mipmap.class;
            }

            return android.R.drawable.class;
        }

        @Override
        protected String getLocalClassName(Context context) {
            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
                return mResourcePackageName + ".R$mipmap";
            }

            return mResourcePackageName + ".R$drawable";
        }

        private final String mResourcePackageName;
    }

This could be better if we can combine Drawables and Mipmaps as one class. But I think It's still ok, at least it works fine for your codebase.
Hope you take a look. It would be nice if I could get your response
P/S: Hey, can you help me to write test for this functionality?

On Jan 1, 2022, we’ll remove the Messages & Experiments feature from Mixpanel(more details).
This is housekeeping to close PR that is no longer relevant. Thanks @phatnhse for providing it.


Cancel chat prompt when message is send

When we send message, we stay on chat prompt
can u fix ?

fixed in https://github.com/michaljaz/web-minecraft/commit/655eeb1b118443afbe0f219143c078541dbcd1fd


Duplicate identifier

I just installed the plugin and there are more than 100 errors sayin duplicate identifier on the latest jquery.d.ts definition file. See image attached below:

For anyone who meets the same issue and who comes here for a solution: for me, this error occurred after I had just installed the plugin (1.8.0v20160504) and enabled the TypeScript nature on the project, until I configured the "source" and "exported" folders in the properties of the project.


AO RTSP Adapter Error - "Could not open device '/dev/v4l2-nvenc' for reading and writing. "

After failing to run the template module/run.py on WSL, I was informed Savant is not supported on WSL - https://github.com/insight-platform/Savant/issues/822.
Thus, I decided to setup GPU PV on a Hyper-V Ubuntu 22.04 VM. I got the nvidia-smi command working on the VM. The command glxinfo | grep "OpenGL renderer string" outputs OpenGL renderer string: D3D12 (NVIDIA GeForce RTX 4060 Laptop GPU). My Ubuntu kernel is 6.5.0-45-generic. The installation instructions also mentioned that I needed to dxg dkms, so I patched the linux-msft-6.6.y dxgkrnl version from WSL (https://github.com/microsoft/WSL2-Linux-Kernel/tree/linux-msft-wsl-6.6.y).
Here are some of the instructions I followed:

https://gist.github.com/OlfillasOdikno/f87a4444f00984625558dad053255ace
https://gist.github.com/krzys-h/e2def49966aa42bbd3316dfb794f4d6a

However, when I run the AO RTSP container from samples/template directory, I see this error:
always-on-sink-1  | RuntimeError: Received error "gst-resource-error-quark:
Could not open device '/dev/v4l2-nvenc' for reading and writing. (7)"
from nvv4l2h264enc0. Debug info: "v4l2_calls.c(713): gst_v4l2_open ():
/GstPipeline:pipeline0/nvv4l2h264enc:nvv4l2h264enc0:

always-on-sink-1  | system error: No such file or directory".

always-on-sink-1  |  ERROR insight::savant::deepstream::encoding
> You have configured NVENC-accelerated encoding, but your
device doesn't support NVENC for codec 'h264'.

According to the video encode/decode GPU support matrix, my GPU is supported by NVENC, so why is the RTSP container is giving me this error?
Since I saw that NVENC is dependent on CUDA, I tried installing CUDA12.2 (both WSL 2 and ubuntu 22.04 versions), neither of which fix the error. Do I need to patch a different version of dxgkrnl from a non-WSL source?
GPU support matrix - https://developer.nvidia.com/video-encode-and-decode-gpu-support-matrix-new

Hi. What nvidia-smi shows? Please list here.

When you ensure that nvidia-smi displays proper information about GPU similar to the following listing:
ivan@ivan-LOQ-15IRH8:~$ nvidia-smi
Sun Aug  4 11:31:30 2024
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.183.01             Driver Version: 535.183.01   CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA GeForce RTX 4060 ...    Off | 00000000:01:00.0 Off |                  N/A |
| N/A   45C    P8               1W /  60W |     18MiB /  8188MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A      5084      G   /usr/lib/xorg/Xorg                           14MiB |
+---------------------------------------------------------------------------------------+

You must configure your environment precisely as described here: https://docs.savant-ai.io/develop/
Do not skip or miss steps; do not go further if the previous step resulted in an error. Every single command must succeed. You do not need to install anything else in your host (VM) environment other than described in the document by the link.

Hi. What nvidia-smi shows? Please list here.
This is the output when I run /usr/lib/wsl/lib/nvidia-smi

Sun Aug  4 14:52:03 2024
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 560.27                 Driver Version: 560.70         CUDA Version: 12.6     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA GeForce RTX 4060 ...    On  |   00000000:01:00.0 Off |                  N/A |
| N/A   42C    P8              1W /   80W |      80MiB /   8188MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+

+-----------------------------------------------------------------------------------------+
| Processes:                                                                              |
|  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
|        ID   ID                                                               Usage      |
|=========================================================================================|
|    0   N/A  N/A       577      G   /Xorg                                       N/A      |
|    0   N/A  N/A       854      G   /unity-greeter                              N/A      |
|    0   N/A  N/A      3942      G   /Xorg                                       N/A      |
|    0   N/A  N/A      4090      G   /xdg-desktop-por                            N/A      |
+-----------------------------------------------------------------------------------------+

I copied the driver and lib files from my WSL VM into the Hyper-V Ubuntu 22.04 VM at /usr/lib/wsl/drivers/ and usr/lib/wsl/lib locations. More info on this procedure is mentioned in the links I pasted at the top of this page. I think that there might be something wrong with this approach, since it uses the Nvidia drivers from WSL and not Ubuntu.
Also, the docs say to install nvidia-driver-535, which several versions behind my up-to-date drivers (560.xx). Will that discrepancy cause any issues in Savant? Should I try installing nvidia-driver-555 on my Hyper-V VM instead?

How did you manage to get the driver version showing as 535.183.01 in nvidia-smi output? Though I installed the Nvidia driver 535 as specified in the savant docs, I couldn't get the driver version to be 535.183.01.

What kernel version are you using on the Ubuntu guest? Are you using a VM? I am using kernel version 6.5.0-45-generic on Hyper-V VM.

How did you manage to get the driver version showing as 535.183.01 in nvidia-smi output? Though I installed the Nvidia driver 535 as specified in the savant docs, I couldn't get the driver version to be 535.183.01.

You do not need exactly the same version. Nvidia changes minor version and it should not be a problem.

What kernel version are you using on the Ubuntu guest? Are you using an Ubuntu VM or do you have Ubuntu installed on the host via dual boot? I am using kernel version 6.5.0-45-generic on Hyper-V VM.

Unfortunately, we do not use Hyper-V and I cannot help with the question. I only know that our customers use Hyper-V and somehow managed to get a working VM.
Dual boot is OK.
Kernel version can vary as long as you are using Ubuntu 22.

How did you manage to get the driver version showing as 535.183.01 in nvidia-smi output? Though I installed the Nvidia driver 535 as specified in the savant docs, I couldn't get the driver version to be 535.183.01.

You do not need exactly the same version. Nvidia changes minor version and it should not be a problem.

Let me rephrase - I am completely unable to change the driver version. Before installing nvidia-driver-535, nvidia-smi shows me driver version 560. After installing nvidia-driver-535, nvidia-smi still shows me version 560. The 560 version came from my WSL Nvidia drivers, not from the ubuntu driver. Do you know how to override the WSL driver with the Ubuntu driver?

What kernel version are you using on the Ubuntu guest? Are you using an Ubuntu VM or do you have Ubuntu installed on the host via dual boot? I am using kernel version 6.5.0-45-generic on Hyper-V VM.

Unfortunately, we do not use Hyper-V and I cannot help with the question. I only know that our customers use Hyper-V and somehow managed to get a working VM.
Dual boot is OK.
Kernel version can vary as long as you are using Ubuntu 22.

Did they install the Nouveau driver by going to Nvidia website and downloading runfile? Or did they just follow the Savant installation directions and install the Ubuntu Nvidia driver?


ENH: stats.chisquare/power_divergence: add array API support

Reference issue
Toward gh-20544
What does this implement/fix?
Adds array API support to stats.chisquare and stats.power_divergence. Preserves but deprecates support for masked arrays per generalization of the conversation about gstd.
Additional information
Consider reviewing diff with "Hide whitespace" checked. I moved some test functions into classes.

Thanks @tupui!


fix(gui): Increase height of webview

connects to #1856
Change-Type: patch

Can you add before & after screenshots for a quick visual impression?

Ci is failing because the sass changes aren't committed ;)

The sass is committed? Should I build em too?

That second screenshot isn't what Etcher currently shows on success, which is actually this:

The sass is committed? Should I build the css?

@craig-mulligan yeah, sorry – that's what I meant

Oh @lurch - okay that flash again doesn't come up on my screen, I'm testing manually be setting the success state. I can't test it properly because etcher fails on my machine. (looks like elevation issues). So maybe there isn't actually more room to be used. @lurch do you mind pulling and testing this on your machine?

If not, don't worry about it. I don't think this is v urgent.

Yea defo's looks like the height used curbed to maintain that flash complete status. - closing.

@craig-mulligan what kind of elevation issues are you running into? Are you on current master?

@jhermsmeier yea, but it's happening with my standard etcher 1.1.2 as well. It happened a couple weeks ago, assumed it was the drive but looks like it's my machine. In the way of errors nothing throws, it starts and then just logs elevation cancelled as second later.

@craig-mulligan can you pull again & run make electron-develop before starting it? – This should have been fixed on current master, but your dependencies might be stale.

@jhermsmeier I get the same result. I'll open an separate issue for this.


Delay in pipeline submission response when submitting a pipeline

See COVID notebook scenario. The dialog box indicating a successful submission to kfp is taking longer than anticipated

As requested by @lresende I'm taking a look at this. I may not figure it out before my week vacation next week though, if others want to take a shot at it while I'm gone.
A more detailed understanding of this "bug" is:
When a user submits a pipeline (run or export) it displays a "warning" dialog to tell the user the submission may take some time (once it's submitted it shows a "results" dialog). The problem is the warning dialog is dismissible and if dismissed behavior until the results dialog displays is "odd." Some examples are:

The run and export buttons don't work, their dialogs will only open after the result dialog is show and dismissed.
any attempt to save (any file) wont succeed until the results are shown (using the save button or the file menu).
other pipeline and notebook feature still work, such as running a notebook or editing a pipeline (including the clear button)
any calls to the elyra api (such as opening the code-snippet side bar) wont go through until the results are displayed.

I ended up tracking down the root cause for this pretty fast. All the functionality that doesn't work during the submission has one thing in common: they make a call to the api. This seems to mean that while our submission is calling the api no other calls can go through and any feature that leverages a call will "hang" on that call until the submission api call finishes.
For solutions to this problem I have a couple ideas (not mutually exclusive):

we add more details to the warning dialog that specifically call out how some feature may not work while the submission is ongoing
we make it so the user can't dismiss the dialog as easily. We could do this my leveraging similar changes to #684 that will allow us to disable a dialog button so the user would only be able to clear it by clicking outside the dialog or the esc key (both of which dynamically close dialogs are are difficult to impossible to disable.
we look into "speeding up" the submission in some way so the time the api is blocked is minimized.

We should discuss this at our next scrum/dev meeting

Thanks for the last two comments @ajbozarth - this raised an alarm immediately for me (and affirmed in your subsequent response):

any calls to the elyra api (such as opening the code-snippet side bar) wont go through until the results are displayed.

We need to make sure that stack (pipeline submission and export) is async-enabled.  This is the same issue the jupyter framework had with starting kernels.
However, async-enablement won't resolve the issue for things taking a long time for submission - the time will still be the same - just that the UI will have more liberties to do other things - like fetch metadata or submit another job, etc.

Front end test case to see if a server fix address the issue:

Make some small change to the pipeline (move a node) so it has unsaved changes. Note that the X on the tab will be replaced with a dot representing unsaved changes.

Submit a pipeline and dismiss the warning dialog

Try saving (either using the save button or via the file menu)

If the server-side solution worked then the dot on the tab should be replaced the X to show a successful save. If the dot is still there then the save call is still blocking on the server.


Deterministic JSON serialization for map types

Problem
It's not currently possible to deterministically produce JSON data for types that include Protobuf map fields since the keys in those maps are not sorted. For example:
for _ in 0..<10 {
    var message = Some_Message.with { message in
        message.other = [
            "aaa": "abc",
            "111": "abc",
            "eee": "baz",
            "bbb": "baz",
            "ccc": "baz",
            "ddd": "baz",
        ]
    }
    message.other["0new"] = "abc"
    print(String(data: try message.jsonUTF8Data(), encoding: .utf8)!)
}

Outputs:
{"other":{"ddd":"baz","ccc":"baz","eee":"baz","111":"abc","0new":"abc","aaa":"abc","bbb":"baz"}}
{"other":{"111":"abc","bbb":"baz","ddd":"baz","0new":"abc","aaa":"abc","ccc":"baz","eee":"baz"}}
{"other":{"ddd":"baz","ccc":"baz","eee":"baz","111":"abc","0new":"abc","aaa":"abc","bbb":"baz"}}
{"other":{"111":"abc","bbb":"baz","ddd":"baz","0new":"abc","aaa":"abc","ccc":"baz","eee":"baz"}}
{"other":{"ddd":"baz","ccc":"baz","eee":"baz","111":"abc","0new":"abc","aaa":"abc","bbb":"baz"}}
{"other":{"111":"abc","bbb":"baz","ddd":"baz","0new":"abc","aaa":"abc","ccc":"baz","eee":"baz"}}
{"other":{"ddd":"baz","ccc":"baz","eee":"baz","111":"abc","0new":"abc","aaa":"abc","bbb":"baz"}}
{"other":{"111":"abc","bbb":"baz","ddd":"baz","0new":"abc","aaa":"abc","ccc":"baz","eee":"baz"}}
{"other":{"ddd":"baz","ccc":"baz","eee":"baz","111":"abc","0new":"abc","aaa":"abc","bbb":"baz"}}
{"other":{"111":"abc","bbb":"baz","ddd":"baz","0new":"abc","aaa":"abc","ccc":"baz","eee":"baz"}}

Use case
When sending Connect Unary GET requests, the serialized payload passed in the URL's query parameters must be deterministic in order to properly enable effective caching. Related: https://github.com/connectrpc/connect-swift/issues/196
Proposal
Add a useDeterministicOrdering: Bool = false field to JSONEncodingOptions (similar to what Protobuf for Go has) which, when set, causes JSONEncodingVisitor.visitMapField(...) to sort keys before iterating through and serializing them.

From the spec, https://protobuf.dev/programming-guides/proto3/#maps -

Wire format ordering and map iteration ordering of map values are undefined, so you cannot rely on your map items being in a particular order.

I agree that the default implementation should not incur the extra cost of producing deterministically ordered map keys, but there is value in providing the option to produce deterministic outputs, which is why this can be configured in several other Protobuf implementations:

Go: https://pkg.go.dev/github.com/golang/protobuf/proto#Buffer.SetDeterministic
Java: https://github.com/protocolbuffers/protobuf/blob/b8654c2d89acea1cef0c52a42b0174f4b5d3b5e4/java/core/src/main/java/com/google/protobuf/CodedOutputStream.java#L152-L158
CPP: https://github.com/protocolbuffers/protobuf/blob/b8654c2d89acea1cef0c52a42b0174f4b5d3b5e4/src/google/protobuf/io/coded_stream.h#L1227-L1235
Python: https://github.com/protocolbuffers/protobuf/blob/b8654c2d89acea1cef0c52a42b0174f4b5d3b5e4/python/google/protobuf/message.py#L181-L183

If desired, libraries can go further than the spec in providing customization options. The proposed option is not in conflict with the spec.

Sorry, meant to hold that and finish filling it in later, but accidentally posted just the reference.
Just wanted to include that it shouldn't be the default. TextFormat also has the need to sort, so that might be a reference for doing it (haven't looked at the PR).

Sorry, meant to hold that and finish filling it in later, but accidentally posted just the reference.
Just wanted to include that it shouldn't be the default.

No worries. I agree with disabling by default.

TextFormat also has the need to sort, so that might be a reference for doing it (haven't looked at the PR).

Thanks, this is a helpful tip. I updated the PR to use a similar strategy.

As an aside, I'd like to follow this change up with a similar one for BinaryEncodingVisitor which I believe has the same limitation.

Ah.  I re-read the original comment.  That makes sense.   For testing, I've long wanted someone to write a function that does actual correct comparisons of JSON blobs, independent of order.  That would simplify some of SwiftProtobuf's testing logic and make it easier to add new tests for more complex scenarios.

Yep, it would be good for testing, and the primary use case I have is to unlock caching when using unary HTTP GET requests with the Connect protocol (spec). For caching to actually work consistently, the request query for a semantically identical request message needs to be the same between requests.

Yep, it would be good for testing ...

I disagree, which is why I outlined my desire for a better way to compare two distinct JSON blobs.

I disagree, which is why I outlined my desire for a better way to compare two distinct JSON blobs.

Fair enough, I misinterpreted your initial statement about testing.
Are we all in agreement that adding this proposed option is reasonable given the use case for deterministic cacheable requests?

There is an alternative for your use case: to layer a JSON "canonicalizer" over the output. I love the separation of concerns there but it would be nice to know if that works for you.

There is an alternative for your use case: to layer a JSON "canonicalizer" over the output. I love the separation of concerns there but it would be nice to know if that works for you.

I assume you mean post-processing the outputs provided by SwiftProtobuf's serializer to make them deterministic? My thoughts on that are:

This would be nontrivial for binary-serialized payloads (which I'd also like to add a matching option for)
If we were able to get that to work, it'd likely incur significant processing overhead
Many other implementations provide this option, so it feels strange to require bespoke logic specifically for Swift

Putting on my hat of "google lead for protobuf" for a moment, I think that deterministic options are reasonable.  I think we should very much not make them the default and should even randomize things that we intend to have non-deterministic (to the extent practical, sometimes other concerns make this not work).  But having well named flags to provide determinism are good.

The "canonicalizer" idea would work fine for testing, but it doesn't sound like a good idea for @rebello95's use case.   Deterministic options sound like a good way forward for JSON, as long as "deterministic" is appropriately caveated:

It does not mean "sorted"
It promises stability in the medium term, but is not a long-term guarantee (we can change the "deterministic" order next year if we think it would help us meet other goals)

In particular, as mentioned above, we've been discussing changing the order of fields in binary encoding to make things faster.
My fear: someone who thinks that a hash of a "deterministic" serialized form is a good database key.  ☹

Thank you @fowles 👍🏽

Deterministic options sound like a good way forward for JSON, as long as "deterministic" is appropriately caveated:

It does not mean "sorted"
It promises stability in the medium term, but is not a long-term guarantee (we can change the "deterministic" order next year if we think it would help us meet other goals)

+1. Other languages have explicit caveats in their documentation (for example, C++) which speak to both of your points. I think these warnings are probably also reasonable discouragement against doing things like using them as database keys. The PR I proposed includes this disclaimer.

The Go implementation's documentation also clarifies the guarantees provided in a way that should meet everyone's needs:

// Deterministic controls whether the same message will always be
// serialized to the same bytes within the same binary.
//
// Setting this option guarantees that repeated serialization of
// the same message will return the same bytes, and that different
// processes of the same binary (which may be executing on different
// machines) will serialize equal messages to the same bytes.
// It has no effect on the resulting size of the encoded message compared
// to a non-deterministic marshal.
//
// Note that the deterministic serialization is NOT canonical across
// languages. It is not guaranteed to remain stable over time. It is
// unstable across different builds with schema changes due to unknown
// fields. Users who need canonical serialization (e.g., persistent
// storage in a canonical form, fingerprinting, etc.) must define
// their own canonicalization specification and implement their own
// serializer rather than relying on this API.
//
// If deterministic serialization is requested, map entries will be
// sorted by keys in lexographical order. This is an implementation
// detail and subject to change.

<EMAIL_ADDRESS>

Your fear is totally real and people even do it for the non-canonical forms.  When talking about stability it is important to quantify several distinct types:

non-deterministic
deterministic with a single run of a binary
deterministic across multiple runs of the same binary
deterministic across different binaries built against the same version of protobuf
deterministic within a single major version of protobuf
deterministic across all time (sometimes called canonical)

For wireformat, there is a notional "canonical" encoding that produces the last one but you can only achieve it if you know the exact schema of the data.
For json, there could be a "canonical" encoding defined around sorting, but I don't think it has been explicitly written out.
I suspect json wants 4 or 5 to provide useful caching.

There is a json rfc that makes an attempt to define "canonical," unrelated to protobuf.
Anyway I asked this question mostly because it's good to call out rejected alternatives.

Thank you all for working through this!
@thomasvl do you know when the next release cut will be?

Thank you all for working through this!
@thomasvl do you know when the next release cut will be?

This lands things on main, which is working towards 2.0.  There would need to be cherry picks to the 1.x branch if the desire is to have it in a release sooner.

Ah okay, yes it'd be nice to have it included in an earlier release. Would you like me to open cherry pick PRs to 1_x_release_branch or are you able to add them?

If you have the time, go for it (I'm not sure when I'll have the time (or any of the Apple folks will)).  There likely will be minor edits needed because of how things have changed on main.

https://github.com/apple/swift-protobuf/pull/1487


Should be compatible with executables (.exe)

What were you trying to do?
i am trying to use pdf-lib with the node js backend executable

How did you attempt to do it?
i have been making a exe of node js backend , which is using pdf-lib but after make exe it not working
What actually happened?
it is not working with exe files
What did you expect to happen?
it should be works with exe files
How can we reproduce the issue?
use a pdf-lib in node js project and make exe of that project and try to run that
Version
1.17.1
What environment are you running pdf-lib in?
Node
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
No response

if some one has a solution to this problem , let me know . thank u


Please select a license for redistribution.

Hi Jason,
first, thanks for your work. I would like to include your integration in my Home Assistant Gentoo overlay, https://github.com/onkelbeh/HomeAssistantRepository/
But, you have not published a license, not here, and not on pypi, so I am asking for clarification.
According to Gentoo's license guidelines, it is not allowed to redistribute a package without a license (https://devmanual.gentoo.org/general-concepts/licenses/index.html).
Today, I added it with an "all-rights-reserved" tag, this forbids redistribution and usage of gentoo's mirror system.
At the bottom of my README.md you can find some (outdated) license stats, perhaps this helps your decision. Thanks a lot in advance.
\B.

https://github.com/JasonCarter80/concord232/commit/1f4ac1df7f22cd874cbe982c0b7024b3308f368e added a license but I'm wondering whether all past contributors gave @JasonCarter80 permission to re-license their code.


Higher ed data is available for the three territories

Describe the bug
We should say in the training and workforce development methodology that low higher ed attainment rate is *not available for American Samoa and the Northern Mariana Islands
To Reproduce
Steps to reproduce the behavior:

Go to 'Methodology & data'
Scroll down to 'Higher ed enrollment rate.'
See error

Expected behavior

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
I will update living copy

never mind

never mind

I change it so now it is valid.

@KameronKerger will this need to be revisited when we add USVI and Guam?

yes @BethMattern

We will be removing Higher Ed across all
Lower income - but not college students. We measure by those below 200% poverty line
New - whoever is in low income and subtract the college attendance and then rank that %

closing and opening a new ticket to figure out how to handle this in the copy now that higher ed is a part of low income.


Docs fail to build due to missing CELERY_BROKER_URL environment variable

What happened?
My project is configured to use Celery and Docker. When I run docker-compose -f local.yml up (after building) I get the following error message from the docs container:
docs            | Running Sphinx v3.1.2
docs            | /usr/local/lib/python3.8/site-packages/environ/environ.py:437: UserWarning: Engine not recognized from url: {'NAME': '', 'USER': '', 'PASSWORD': '', 'HOST': '', 'PORT': '', 'ENGINE': ''}
docs            |   warnings.warn("Engine not recognized from url: {0}".format(config))
docs            |
docs            | Configuration error:
docs            | There is a programmable error in your configuration file:
docs            |
docs            | Traceback (most recent call last):
docs            |   File "/usr/local/lib/python3.8/site-packages/environ/environ.py", line 273, in get_value
docs            |     value = self.ENVIRON[var]
docs            |   File "/usr/local/lib/python3.8/os.py", line 675, in __getitem__
docs            |     raise KeyError(key) from None
docs            | KeyError: 'CELERY_BROKER_URL'
docs            |
docs            | During handling of the above exception, another exception occurred:
docs            |
docs            | Traceback (most recent call last):
docs            |   File "/usr/local/lib/python3.8/site-packages/sphinx/config.py", line 319, in eval_config_file
docs            |     execfile_(filename, namespace)
docs            |   File "/usr/local/lib/python3.8/site-packages/sphinx/util/pycompat.py", line 88, in execfile_
docs            |     exec(code, _globals)
docs            |   File "/docs/conf.py", line 22, in <module>
docs            |     django.setup()
docs            |   File "/usr/local/lib/python3.8/site-packages/django/__init__.py", line 19, in setup
docs            |     configure_logging(settings.LOGGING_CONFIG, settings.LOGGING)
docs            |   File "/usr/local/lib/python3.8/site-packages/django/conf/__init__.py", line 76, in __getattr__
docs            |     self._setup(name)
docs            |   File "/usr/local/lib/python3.8/site-packages/django/conf/__init__.py", line 63, in _setup
docs            |     self._wrapped = Settings(settings_module)
docs            |   File "/usr/local/lib/python3.8/site-packages/django/conf/__init__.py", line 142, in __init__
docs            |     mod = importlib.import_module(self.SETTINGS_MODULE)
docs            |   File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
docs            |     return _bootstrap._gcd_import(name[level:], package, level)
docs            |   File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
docs            |   File "<frozen importlib._bootstrap>", line 991, in _find_and_load
docs            |   File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
docs            |   File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
docs            |   File "<frozen importlib._bootstrap_external>", line 783, in exec_module
docs            |   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
docs            |   File "/app/config/settings/local.py", line 1, in <module>
docs            |     from .base import *  # noqa
docs            |   File "/app/config/settings/base.py", line 259, in <module>
docs            |     CELERY_BROKER_URL = env("CELERY_BROKER_URL")
docs            |   File "/usr/local/lib/python3.8/site-packages/environ/environ.py", line 123, in __call__
docs            |     return self.get_value(var, cast=cast, default=default, parse_default=parse_default)
docs            |   File "/usr/local/lib/python3.8/site-packages/environ/environ.py", line 277, in get_value
docs            |     raise ImproperlyConfigured(error_msg)
docs            | django.core.exceptions.ImproperlyConfigured: Set the CELERY_BROKER_URL environment variable

Tracing back through the code I can see that indeed the CELERY_BROKER_URL environment variable is not set in the docs container, because it usually set in the entrypoint script that the django container uses. I have not used sphinx before so I don't understand why it needs this environment variable to proceed.
Manually setting the environment variable in the docs Dockerfile solves the issue, but I don't know if this proliferation of environment variable setting is best for the project so I won't submit that as a fix at this point.
I would appreciate any input on a decent way of solving this problem, I am happy to write a PR following that guidance or leave it to someone else if they want to write one.
Thanks,
Adam

@adammsteele did you resolve this? I am also running into this. I will look into it.

Fresh pull as of yesterday (new project)
Docker version:

@adammsteele did you resolve this? I am also running into this. I will look into it.

Fresh pull as of yesterday (new project)
Docker version:

I ended up just deleting the docs service in local.yml as I didn’t want/need it. As I mentioned you could also add the environment variable to the docs Dockerfile and it works fine as a quick solution.

Add this line to your local env file
CELERY_BROKER_URL=REDIS_URL
I will propose a PR with this quick fix...
https://github.com/professorhaseeb/cookiecutter-django/blob/master/{{cookiecutter.project_slug}}/.envs/.local/.django

That was fixed in #2920. I just tried and I cannot reproduce. Closing


AVS 1.1.0 supprted featurs

Please clarify what new features are supported for AVS 1.1.0. The Read me file and Changelog.md file does not match.
From, Readme :
v1.1 released 10/02/2017:
Enhancements
•The SDK now supports TuneIn, Audible, Pandora, SiriusXM, Kindle Books, and Amazon Music.
•Added a capability agent for Settings, which allows a client to notify Alexa of locale changes.
From Changelog.md :
[1.1.0] - 2017-10-02
•Enhancements
◦Better GStreamer error reporting. MediaPlayer used to only report  MEDIA_ERROR_UNKNOWN , now reports more specific errors as defined in  ErrorType.h .
◦Codebase has been formatted for easier reading.
No mention of Amazon music , Audible etc.

Hi shikha-bansal,
Thanks for bringing this to our attention.  Please go with the readme text.  We will correct this in our next release (and update our process to avoid this in future).
-David

If the README txt is correct , I tried playing music via amazon music , but it says
"Amazon music is not supported on this device".
Nor am I able to use Audible and other services.

Sorry , I am able to use Audible  , Kindle books and TuneIn.
But the music apps Amazon music , Pandora, SiriusXM it says they are not supported,

Same question, Amazon music/Pandora/Spotify have not supported for me also in AVS 1.1
Amazon music/Pandora/Spotify are not supported by voice commands, it replies "Amazon music(Spotify or Pandora) is not supported on this device"
But there is a little different when checking with Alexa App.
1Launch the Alexa app.
2Tap the Menu button in the top left corner > Music，Books & Books > Pandora.  it says "App Support Unavailable"
2Tap the Menu button in the top left corner > Music，Books & Books > Spotify.  it says "App Support Unavailable"
3 But 2Tap the Menu button in the top left corner > Music，Books & Books > Music.  everything seems fine and cast the music to the device works too.


If newick__parse returns null, don't keep the rendering tree message

If newick__parse returns null, don't keep the rendering tree message because this means there was a parsing error.

Fixed here (0434633a925f608bf7e7238e19f7579fbad9efdd).


Issue when loading external song folder

Hello, I'd like to report a crash issue when loading an external song folder other than the local one where StepMania 5.3 is installed.   Do not use # or ; in a song title.
WARNING: Main title or music file for '/AdditionalSongs/Chilean Keyboard Megapack 3/(AMR) #56/' came up blank, forced to fall back on TidyUpData to fix title and paths.  Do not use # or ; in a song title.
WARNING: Main title or music file for '/AdditionalSongs/Touhou Gouyoukyou ~ Touhou Pad Pack/Wouldn't Cucumber-Flavored Beer Be Nice to Drink!_ - Everyone Can Know! This Technology Solves Every Problem -/' came up blank, forced to fall back on TidyUpData to fix title and paths.  Do not use # or ; in a song title.
WARNING: Main title or music file for '/AdditionalSongs/Touhou Kousaikai ~ Scarlet Festival Gathering/#Fairy_dancing_in_lake [CondorTalon]/' came up blank, forced to fall back on TidyUpData to fix title and paths.  Do not use # or ; in a song title.
WARNING: Main title or music file for '/AdditionalSongs/Touhou Kousaikai ~ Scarlet Festival Gathering/#FairyJoke [CondorTalon]/' came up blank, forced to fall back on TidyUpData to fix title and paths.  Do not use # or ; in a song title.
WARNING: Main title or music file for '/AdditionalSongs/Z-I-v Summer Contest 2018/[Starts with Vowels] - A Dumb Idea I Had When I Was Playing Mario Kart With Tim, and He Made Me Make It/' came up blank, forced to fall back on TidyUpData to fix title and paths.  Do not use # or ; in a song title.
WARNING: Video renderer list has been changed from 'opengl,glad' to 'glad,opengl,gles2'
Video renderers: 'glad,opengl,gles2'
Language: es
Current renderer: OpenGL
Theme: default
Partial log:
00:09.928: Renderer Found By SDL: opengles2
00:09.928: Renderer Found By SDL: software
00:10.289: Outfox SDL Reported Variables:
00:10.289: Outfox Engine: SDL compiled version: 2.0.12
00:10.289: Outfox Engine: SDL linked version: 2.0.12
00:10.289: Outfox Engine: GL_VENDOR   : Intel
00:10.289: Outfox Engine: GL_RENDERER : Intel(R) HD Graphics 630
00:10.289: Outfox Engine: GL_VERSION  : 4.6.0 - Build <IP_ADDRESS>85
00:10.289: Outfox Engine: GLSL version: 4.60 - Build <IP_ADDRESS>85
00:10.291: Compiling shader Data/Shaders/GLSL/Texture matrix scaling.vert
-- End of report

That happens everytime you load the game?

Ok, this issue is already know and a version with a fix will be coming this weekend.

This issue is fixed and will be pushed this weekend. Thanks for reporting!

Sorry for the late response. Yes, it happens everytime I load the game.

The new alpha will be out tomorrow, which will fix your issue, thanks for taking the time to follow up.

Hello @TheUnknownPerson.
Project Moondance Discord Moderator here, a while ago we created a bug hunter system, users who make issue on this repository gain points and can be rewarded in our discord, so I'm here to ask, are you in Project Moondance discord?
If not, you can join using this link: https://discord.gg/3DgsbSg
If you don't wish to join, that's okay. Please be sure to contact any moderator if you join.