Add support to efficiently display dropdown of thousands of values in dropdown

Describe the Bug with repro steps

Go to Generate Schema Action of SAP
Select the RFC Name dropdown, which returns 1000s of results, resulting into performance issues

What type of Logic App Is this happening in?
Standard (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Edge
Additional context
No response

This is probably just a situation where we forgot to virtualize a dropdown, I'll look into this

Hi @rllyy97 can you please check if this is a quick fix?

Hi @siddharth-ms, I took a look and the dropdown component we use does not have virtualization support.
The combobox component does have virtualization support so we could look into rendering dropdowns as modified comboboxes, but we'll need to discuss that as a team and the possible side effects.
We are currently doing some other work related to our dropdown/combobox editors so I will update you once we have more info.


Add vdpa interface support

What this PR does / why we need it:
Added a VDPA interface type to allow creation of virtual machines with vdpa NICs. VDPA devices are usually allocated by Intel SR-IOV device plugin.
Examples:
          interfaces:
          - masquerade: {}
            name: default
          - name: offload
            vdpa: {}
      networks:
      - name: default
        pod: {}
      - multus:
          networkName: default/offload
        name: offload

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Intel SR-IOV device plugin for vdpa devices currently has a bug that has not been merged. It works fine with kubevirt after I merged it locally. I think it will be merged soon.
Release note:
Allow creation of virtual machines with vdpa NICs.

@prnaraya If using Intel SR-IOV device plugin for vdpa devices, it needs this pr to be merged. If using another vdpa device plugin that has the same env variables with Intel SR-IOV device plugin (PCIDEVICE_<RESOUCE_NAME> and PCIDEVICE_<RESOUCE_NAME>_INFO), it should work well.

Hi @makoto126 ,
would you be able to submit a design document against https://github.com/kubevirt/community?
Mainly I think it is important to cover what is required from a device plugin in order for Kubevirt to be able to consume the device.
/cc @EdDev
another network binding.

@xpivarc ok, i will submit a design document as soon as possible.

another network binding.

Indeed,
@makoto126 , we are working on exposing KubeVirt network bindings as plugins.
A design document [1] is already in place, taking shape gradually.
I would suggest you to feedback on it and see if the integration points there fit your needs.
[1] https://docs.google.com/document/d/13fLaqZuM8El_CT5XzxPv-1epKsB1-Spv_jtXveEkkdQ

@EdDev I can't access it because I don't have permission.

@EdDev I can't access it because I don't have permission.

You need to join the kubevirt-dev googlegroup.
See https://github.com/kubevirt/kubevirt#community .

@xpivarc https://github.com/kubevirt/community/pull/228


French translation

Hello !
I have started the translation of the document in French so if someone also wishes to participate thank you to let me know so that I add you as a collaborator in my fort
here is the link: https://github.com/Donfreddy/docs

hi @thomasbnt ! thanks for your help I just pushed my last translations so now you can pull and work on the content/fr/quickstart/{script, socket, sse, tests, websokek}.md files

Goood!

Hello again @Donfreddy,
Pushed to the https://github.com/Donfreddy/docs/tree/french_translation
c8bb63169729d54c6f7b87d6dbad936b6de56e13 2de8697f0133fcbeb4aeb9a4965bd69051c17105 101b5232bae20d95121fe5c21e5c4a0d4ae52fc9 f3accdac1de71e7b4facab98f191bdf1a3b888d6 4f482e50bfd8a3f66d39c7d4c3df60c96a9f65b8
And edited small error typo on github ➡  GitHub at e984e5b3dd4d6eef31378ea7dbb6e2d7d038ed4c

Thank you @thomasbnt
I created a pull request
there remains the french version of screenshots


Where to specify the Zookeeper Quorum when its in standalone mode?

I have setup Titan 1.0.0-hadoop1 with storage backend as two node hbase cluster. In the titan-hbase.properties I have specified the
storage.backend=hbase
storage.hostname=<IP_ADDRESS>,<IP_ADDRESS>
I have setup hbase to use a standalone zookeeper at <IP_ADDRESS> which means that zookeeper is not running on both the nodes but hbase is configured to use a remote zookeeper ensemble.
Now, I am trying to start the titan graph in Cent OS 7
I go to the titan directory in which both my bin as well as my conf directory are on the same level and issue the command
$ bin/gremlin.sh
and on
gremlin> g = TitanFactory.open('conf/titan-hbase.properties')
When this happens I am finding that Titan wants to connect to both the Zookeeper nodes and I get the following exception
13:43:03 WARN  org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  - Possibly transient ZooKeeper, quorum=<IP_ADDRESS>:2181,<IP_ADDRESS>:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid
[INFO] ZooKeeper - Initiating client connection, connectString=<IP_ADDRESS>:218                            1,<IP_ADDRESS>:2181 sessionTimeout=90000 watcher=catalogtracker-on-hconnection-                            0x5d25e6bb, quorum=<IP_ADDRESS>:2181,<IP_ADDRESS>:2181, baseZNode=/hbase
[INFO] RecoverableZooKeeper - Process identifier=catalogtracker-on-hconnection-0                            x5d25e6bb connecting to ZooKeeper ensemble=<IP_ADDRESS>:2181,<IP_ADDRESS>:2181
[INFO] ClientCnxn$SendThread - Opening socket connection to server /<IP_ADDRESS>                            8:2181
[WARN] ClientCnxn$SendThread - Session 0x0 for server null, unexpected error, cl                            osing socket connection and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717                            )
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1119)
Since I do not have Zookeeper running on both nodes of hbase, where do I specify the zookeeper nodes separately.
The strange thing is when I now execute the following
from the Titan base directory
I do a cd to bin so the current directory is bin
bin$ bash gremlin.sh
and now create the graph
gremlin> g = TitanFactory.open('../conf/titan-hbase.properties')
note the .. to say that conf directory is on top
I get the correct prompt without any warnings
==>standardtitangraph[hbase:[<IP_ADDRESS>, <IP_ADDRESS>]]
The other issue is when invoked from the rexster the command that is called seems to be the one that is causing the warning.
How do I make sure that the one that is working is the default one to initiate?

change the storage.hostname=<IP_ADDRESS>
when titan connect hbase, it will set hbase.zookeeper.quorum=<IP_ADDRESS>

storage.hostname is misnamed.  It is actually a list of the zookeeper servers in your environment.  Titan can then find HBase via the Zookeeper.  fengkai9 supplied a correct answer.  Is this issue ready to be closed now ?

graben1437 is correct; storage.hostname should be a comma-separated list of the zk ensemble hosts.  I'm not really clear on whether fengkai9 resolved the issue with the change in his commen, but it sounds that way to me, so I'm tentatively closing.  Please reopen if there is still an problem.


SERVER-90754 Bring in TCMalloc MAP_FIXED_NOREPLACE bugfix

JIRA
Prior to 4.19
(https://github.com/torvalds/linux/commit/7aa867dd89526e9cfd9714d8b9b587c016eaea34), if the start of the second mapping did not overlap with the existing one, we erroneously replaced it.
Fixes #229
PiperOrigin-RevId: 635921913
Change-Id: I9faca10babf5f8acb81f2751b45caf66120f9819

This should be put into mongodb-forks first and then this change would be a change in the tag used in the install.sh script in addition to the code changes.


Adding libboost installation to tests

This will support #23 by @ayushmehar7.

All checks passed. Merging this!

All checks passed. Merging this!


Angular Chosem don't work well with ng-show

I'm using chosen-angular in my project and the home page is having dropdown menu which appears after selecting some value from checkbox values. I'm ng-show to show or hide the dropdown menu. The mentioned menu don't appear well as viewed in the attached image.

Any idea?

Does the list display correctly if you remove the ng-show?

Yes, It works well when it's used as it is. The issue happens when It was hidden and the $scope.var which show it turned to 'true' then it been viewed as shown in the attached screenshot

Ah, I see. My select is was doing something similar (I thought it'd be related to #97).
I just confirmed that the problem was actually related to this one. I had everything inside of a angular-ui tabset. Removing it from that makes it work correctly for me.

What if you use 'ng-if' ?

For some reason it's adding an inline style width: 0px;. Since I don't have the time to analyze chosen's code, I managed to fix it by setting width: 100% !important; (or whatever value you would need) on .chosen-container in chosen.css. I know it's a dirty hack, but after banging my head all day long, it works for me.

I can confirm that this works correctly when using ng-if

@yfilipov I removed the line in the angular-chosen.min.js that set width: 0px.  It has had no residual effects and the error described went away.
I did notice that when initializing chosen on a select when it (or its parent) is hidden causes problems.  I've got around that by explicitly setting the width of the original select in a css file or on the element itself.

Sorry the delay, I've just taken this project that was abandoned (read #162).
Hi @karimfikry would ng-if work for you? Could you please make a plunkr with your issue so I can manage to debug? You can use this one as an example: http://plnkr.co/edit/1U8KCH?p=preview
Thanks

The documentation is up to date to force the use of ng-if instead of ng-show.
With that said, I'll close this issue.


Add Textbook Beta Footer

We need a proper Footer

I think this'll be closed soon, with this PR?

Removing the label since this is being worked on

Footer is implemented, closing out!

What pages is it implemented on? I don't see it on the content pages under learn.qiskit.org. I tried hard refereshes and I tried in Chrome and Firefox.


I have an enterprise NAS (such as NetApp Filers or Dell-EMC Isilon).

is "Filers" correct? should it be "Files" in "I have an enterprise NAS (such as NetApp Filers or Dell-EMC Isilon)."?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3acd2fd4-b22c-5c11-e891-cc4993d9891e
Version Independent ID: 1acbff98-4a94-53f5-dd45-8f22637602b4
Content: Review your storage options - Cloud Adoption Framework
Content Source: docs/ready/considerations/storage-options.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#199047

This issue has been fixed.  Thanks!


Use blobs instead of random integers

Description
During investigation of https://github.com/scikit-image/scikit-image/issues/7262 I have created a blobs function that is quite fast and produces data more realistic than just np.random.randint.
So I suggest adopting it in benchmarks.
It is slightly faster on my machine
main:
[50.00%] ·· ======================================================== ================
                                   benchmark                          total duration
            -------------------------------------------------------- ----------------
             benchmark_labels_layer.LabelsDrawing2DSuite.time_draw        33.9s
                 benchmark_labels_layer.Labels3DSuite.mem_layer           16.7s
             benchmark_labels_layer.Labels3DSuite.time_create_layer       16.5s
               benchmark_labels_layer.Labels3DSuite.time_refresh          16.5s
                 benchmark_labels_layer.Labels3DSuite.mem_data            16.5s
                                      ...                                  ...
                                     total                                6.92m
            ======================================================== ================

This branch:
[50.00%] ·· ============================================================ ================
                                     benchmark                            total duration
            ------------------------------------------------------------ ----------------
               benchmark_labels_layer.LabelsDrawing2DSuite.time_draw          33.6s
                   benchmark_labels_layer.Labels2DSuite.time_fill             20.4s
             benchmark_labels_layer.Labels2DColorDirectSuite.time_fill        18.1s
               benchmark_labels_layer.Labels3DSuite.time_create_layer         13.5s
             benchmark_labels_layer.Labels3DSuite.time_raw_to_displayed       13.4s
                                        ...                                    ...
                                       total                                  6.56m
            ============================================================ ================

It also adds Balls 2D and Balls 3D example data with importing from napari.examples.utils

Is it worth moving to a more general location in the code base?

yes and no
It may be a useful example, but without cherry-picking this to 0.4.19, we need to use only utils.py content in benchmark to be able to compare main against the latest release.

Ok. Maybe we make it a sample or something in 0.5.0. Can make a task issue once merged.

Ok. Maybe we make it a sample or something in 0.5.0. Can make a task issue once merged.

We could make it sample now. But it will require to have two copies of code. Or we agree on cherry pick it to 0.4.19.

The samples are amazing, especially with points and labels!
😍
I think that following the existing Samples, these should be after astronaught as Balls and Balls (3D)
BTW The 3D one has some issue with background in mip though:

Some locations arn't set a value perhaps? or are those just the only 0 values...

BTW The 3D one has some issue with background in mip though:

It is not an issue. The background is visible only for 0 value.
I have improved it a little.

I have added tests

And found that the code was not python 3.8 compatible.

@Czaki this is for 0.5.0 so 3.8 compatibility is not important?

I see that the CI still uses 3.8, I guess because we wanted to keep it until 0.4.19. I'm a little shocked that the walrus operator there is reported as a syntax error, since it was introduced in 3.8? Is it because it's not allowed in square brackets due to implementation details?

It looks like this.


[SB] Cleaned up Disp

PR DESCRIPTION:
Due to a bug that was in uamqp when settling messages across the wire we sent dispositions to the service with settled=True by default. This caused our dispositions to model a "fire and forget" pattern where we never confirmed with the service if the messages had been settled and removed from the queue. This "fire and forget" pattern was also causing issues with locked-until-utc times on messages as we were not confirming that messages were being released by us back to the service.
This PR introduces changes to resolve this bug:
When sending dispositions now settled=False, this triggers us to have a transaction with the service that looks similar to as follows:

<- TransferFrame(....
Calling complete_messages()
-> DispositionFrame(role=True, first=1, last=None, settled=False, state=Accepted(), batchable=None)
<- DispositionFrame(role=False, first=1, last=None, settled=True, state={'accepted': []}, batchable=None)
Completed Msg

This pr models sending/receiving dispositions over the ReceiverLink similar to how the SenderLink deals with the Acks for TransferFrames sent.
When a disposition is sent that is related to Message settlement, we add a MessageDelivery object to a list that contains all the disposition information. When a corresponding disposition is received for that Message settlement, we call an on_disposition_received callback that processes the response, raises any appropriate errors received from the service's DispFrame. If no error is raised message._settled=True.
This PR also builds upon a similar format to what JS receive does, our receive operation for SB now calls "drain" when the timeout is reached. This aims to maximize the number of messages received per each receive call, as well as reduce the time it takes to settle the corresponding messages later as it will clear the link credit off of wire. If the drain is not received back within the timeout period time and there are no transfers coming across the wire - we kill the receiver link.
TODOs:

Should process_receive_error have changes?
Do we need to consider Timeout on sending disposition?
Stress tests compare websockets vs sockets
Add to EH the disp checking so pyamqp is aligned : #36825
Impact of drain on prefetch + iterator

API change check
API changes are not detected in this pull request.

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests


Wrong identification of Python code

Describe the bug
As usual, there are a couple of Python code files that were not identified correctly :)
cc: @gdesmar
Password for all files: zippy. As usual, they can contact dangerous code.
The following files were identified as text/plain:

BitForger.py.zip

possible characteristics: import urllib.request, subprocess.run, urllib.request.urlretrieve

_deobfuscated_code_FINAL.py (kopia).zip

characteristic executor: exec(lzma.decompress(

init.py.zip

quite similar to the (1), but a little longer

init.py(1).zip

import urllib.parse, import aiohttp

init.py (kopia).zip

subprocess.Popen

tools.py.zip

similar to (2), exec(lzma.decompress(base64.b64decode

The following files were identified as code/ps1. Those are more complicated, as they do contain PowerShell commands, but they are Python scripts:

init.py.zip
uidesign.py.zip

The same story, but with code/batch identification:

4a2353d4be195e06172985931534fe14dbe5746c452c7a27c1d4a5d51d516eb6.zip

To Reproduce
Steps to reproduce the behavior:

Upload and see the wrong file type

Expected behavior
Identification as code/python.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information if pertinent):

Assemblyline Version: 4.5.0.x - those files were collected for some time
Browser: [e.g. chrome, safari]

Additional context
Add any other context about the problem here.

And a little different case - wrong identified JavaScript. Interestingly, the mime type was originally application/javascript, but the final one is unknown -> maybe even for untrusted mimes, it would be useful to fall back to them if there is nothing better?
9bc1e972b4c7e11256f817954f51c07963fd6f17161c0c2ce867f0c3ba4173d1.zip
3adf910188dc6f0df92eca9a835aac4b31e3232b57adf661c8cfef4992812ea2.zip

A new example - Python code identified as text, interesting as it's just a revshell: setup.py(4).zip

Out of the 12 samples you uploaded, these two PRs are going to fix 8 of them.
Still left, if it can be improved, are the two files identified as code/ps1, the one identified as code/batch and _deobfuscated_code_FINAL.py (kopia).zip.
I'll give another try at tweaking the executor for the kopia one, but I want to make sure we don't reduce the confidence in the executor too much, as it could cause false positives. It currently check for a mandatory use of base64, like DataDog was doing. Since we are using the default score or 0 for that yara rule, we will prefer yara rules with higher score if there are conflicting results, so false positives are less of a worry. That brings us to the ps1/batch misidentification. As you saw, there are either full scripts of that other language sprinkled in the python file, or very specific language function names. Since those yara identification rules have a higher score, they are preferred over the python one. We could bump the python score higher, but we'd need to make sure not to cause any false positives on batch/powershell scripts.

Thanks for taking a look at this - yeah, I expect those to be difficult to fix. Currently, I can imagine only having very specific rules (rather not worth), or designing a way to handle multiple possible identifications and/or pass through some AI-based identification in such cases, which could be more capable of handling such mixed cases.

Eventually, it could be a score bump for "what exist first" - e.g. if the Python characteristic was found earlier in the file than ps1/batch AND was not after some not-Python indicators. I mean, if we have a strong Python indicator at the top of the file, and it's not inside a PowerShell variable assignment, it's reasonable to assume it has to be proceeded by Python. But recognizing if it was or wasn't inside a string (or something like it), sounds too complex for YARA

I modified the first executor to allow for different encoding. It will now check for a zlib or lzma or base64 payload inside an execution, instead of a base64 payload inside an optional zlib or lzma step inside an execution.
This will identify _deobfuscated_code_FINAL.py (kopia).zip as a python script. I don't think it will cause too many false positives, as the rule have a default score that will lower the chances.
Regarding the mixed code scripts, I agree that having the list of locations where the yara strings were found (and hopefully their name) could be of great help to deconflict the two languages. I'll try to look into it, but I think that's already a great start. 🙂

By adding the following code in yara_ident(), we can see that we have a lot of information coming back in the matches:
for m in matches:
    print(m.rule)
    for s in m.strings:
        print(f"\t{s.identifier}")
        for i in s.instances:
            print(f"\t\t{i.matched_data} @{i.offset}")

For the three currently misidentified files, we have:
uidesign.py
code_ps1
        $strong_pwsh6
                b'Start-Process' @849
        $strong_pwsh100
                b'-Command' @421
                b'-Command' @952
code_python
        $strong_py4
                b'else:' @1171
        $strong_py24
                b'subprocess.run(' @390
                b'subprocess.run(' @921
        $strong_py108
                b'os.getcwd()' @109

4a2353d4be195e06172985931534fe14dbe5746c452c7a27c1d4a5d51d516eb6
code_ps1
        $strong_pwsh6
                b'Start-Process' @2489
        $strong_pwsh38
                b'Invoke-WebRequest' @2320
                b'Invoke-WebRequest' @2706
        $strong_pwsh41
                b'Expand-Archive' @2878
        $strong_pwsh100
                b'-Command' @2307
                b'-Uri' @2338
                b'-OutFile' @2442
                b'-Command' @2693
                b'-Uri' @2724
                b'-OutFile' @2835
code_python
        $strong_py3
                b'\n    def install_chrome_and_driver():' @83
        $strong_py4
                b'else:' @444
        $strong_py23
                b'platform.system()' @143
        $strong_py24
                b'subprocess.run(' @1673
                b'subprocess.run(' @3397
        $strong_py108
                b'os.getcwd()' @1886
                b'os.getcwd()' @3652
code_batch
        $power1
                b'powershell' @2296
                b'powershell' @2682
        $command
                b'-Command ' @2307
                b'-Command ' @2693
        $cmd0
                b'@echo off' @2225

init.ps1.py
code_ps1
        $strong_pwsh6
                b'start-process' @3310
        $strong_pwsh9
                b'get-process' @3238
        $strong_pwsh27
                b'set-location' @3254
        $strong_pwsh34
                b'stop-process' @3337
        $strong_pwsh38
                b'invoke-webrequest' @3354
        $strong_pwsh39
                b'copy-item' @3280
        $strong_pwsh100
                b'-command' @3203
                b'-Command' @8281
                b'-Command' @9991
                b'-Command' @10006
                b'-Command' @10066
code_python
        $strong_py1
                b'\n    if __name__ == "__main__":' @10706
        $strong_py2
                b'\n    from getpass import getpass' @29
                b'\n    from subprocess import run' @62
                b'\n    from sys import argv' @94
                b'\n    from typing import Any' @120
                b'\n    from prompt_toolkit import PromptSession' @158
                b'\n    from prompt_toolkit.formatted_text import HTML' @204
                b'\n    from prompt_toolkit.history import InMemoryHistory' @256
                b'\n    from prompt_toolkit.completion import WordCompleter' @312
        $strong_py4
                b'try:' @0
                b'try:' @4548
                b'try:' @4852
                b'try:' @4870
                b'try:' @6310
                b'else:' @6609
                b'else:' @7110
                b'else:' @8432
                b'try:' @8994
                b'else:' @9443
                b'try:' @10326
                b'try:' @10465
        $strong_py108
                b'os.getcwd()' @4365
                b'os.getcwd()' @9108
                b'os.getcwd()' @9250
        $strong_py150
                b'os.system(' @5220
                b'os.system(' @8854
                b'os.system(' @9567
                b'os.system(' @9655

In all three cases, we can determine that all strong* strings of the code_ps1 rule are found between strong* strings of code_python. It would be easy to make code_python take precedence on code_ps1 in those cases.
The one currently identified as code/batch is trickier, as it doesn't use strong* strings. Right now, we do not have a real convention for the Identify yara rules. If we categorize the strings as strong*, weak* and others, maybe we could only use strong* to determine surrounding-ness of non-weak* strings of other rules. We already have the concept of rule score, and the higher the score, the higher the priority of the rule. Overriding that after the fact for certain string name may be puzzling/misleading, and it could remove the possibility for an admin to fix their Identify locally. Maybe we should consider the difference between the two rules' score, or never override a rule that has a score higher than a certain number.
Regarding the strong_py4, I wonder how strong it is... It's a simple regex that looks for try: or except: or else:. I feel like those are not that strong, even with the colon, as it may show up in normal text. If we remove it, or change it to weak_py1, it would stop uidesign.py from having python both before and after all ps1 indicators. In that case, how confident are we that having two python identifier before three ps1 identifier is enough?
And even if this is all super fancy and interesting (😃), we could simply bump the score of the code_python rule. I am not certain how many false positives of the other languages it could cause. It may be wiser to change that strong_py4 if we do: I just found out that it became a strong indicator through refactoring, but it was originally a weak one. I'll try to find a lot of various script to check if the score bump would change the identification of true VBS/Batch/ps1/... scripts.

BTW, the try:, else:, except: could also be strong if we require them to have at least a tab or four spaces before, and use as weak otherwise. It's rather unusual to have four spaces in a normal text (but two could be, so it won't be enough), and very common in Python code.

A few more samples :)
Here is a one that is obfuscated:  settings.py.zip
Two samples that are quite short, but with a rather important content - revshells: linux(1).txt.zip, windows(1).txt.zip
And a one I'm surprised it wasn't detected, but overall, it has only data - it's not a big loss not to identify it, so it's rather a side not: native.py.zip (note, it has a BOM mark, but it doesn't look to be a problem - other files with it were correctly identified)..

And a new one :D
post_install.py.zip


Add Vyxal

vyxal is a stack based golfing langauge that has aspects of traditional programming languages. here is the github https://github.com/Vyxal/Vyxal.
at the moment the 2.5.3 verison does not really work and is a WIP so we will have to use the 2.4.1 version which we can download as a tar gz file here https://github.com/Vyxal/Vyxal/releases/tag/v2.4.1

I guess this can now be closed with #363 merged


chore: changed the package name imu_corrector to autoware_imu_corrector

Description
Documentation counterpart of https://github.com/autowarefoundation/autoware.universe/pull/8222

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

note: pre-commit does not pass since it looks for links that will only exist when the main PR is merged

@ismetatabay
the parent PR was merged so this one should be ok as well :pray:
(as far as I understand the person who made the comment should resolve it)

@knzo25 sorry for the late response, I marked it as resolved thanks! :raised_hands:


As a user, I want the books list paginated so that I don't have to browse through all the titles at once.

dev notes
we might return to this to add alpha pagination later once we have sort titles to use for it.

This looks great!


Special format to "break out" of a list

Another user submitted feedback that they would like to have a special flag to "break out" of a list.  I fear this does not stay true to the nature of a microblog for lists but I'm open to alternative ideas.
Basically we would provide the ability for the user to close a list.  We already allow something similar with headers.

What are you "breaking into"? In other words, if you're no longer in list mode, are you in paragraphs then? Do you know what that user is trying to accomplish? Why do they propose breaking out?

Yea I think the idea was to break out into a paragraph.  Basically to have more control over how lists are created.

I'm going to close this issue because I don't think it stays with the theme of this site.


Attention Flow Visualization

Hello,
I’m interested in your paper, "Goal-Guided Transformer-Enabled Reinforcement Learning for Efficient Autonomous Navigation," and I’m currently working with your code.
In the paper, you visualized the attention flow map, but I couldn’t find the corresponding code in the repository.
Could you provide the code for visualizing it, or let me know how it can be done if you used a different library?
I look forward to hearing from you. Thank you!

Thank you for your attention.
Below is the open-sourced repo I utilized and modified for my attention visualization.
[luo3300612/Visualizer](link: https://github.com/luo3300612/Visualizer)
By the way, there are many open-source repositories on GitHub for attention visualization. The one I used has a potential issue: the README is in Chinese. If you can't read Chinese, you can try searching "ViT attention visualization" on GitHub and choose any other repository that suits you.

Thanks for the advice!

I have another question. In your paper, you describe the input image as an RGB image, but in your code with the default parameter(data_obs_fish), it seems that a monochrome image is used. Which one is correct?

Hi, i tried all RGB, mono, and depth and found that both RGB and mono can converge.
As far as I remember, the mono image is also not pure gray scale figure, you can use plt.imshow to confirm it.


Support for DMG inside a ZIP

I'm not sure if this is something that happens often (or why software vendors think it's necessary), but I have a ZIP download that contains a DMG.
To Reproduce
# ./recipe-robot -vv --keep-cache https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Processing: https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Input path looks like a download URL.
    Download URL is: https://www.finaldraft.com/downloads/finaldraft1200b57Mac.zip
Downloading file for further inspection...
    Download content-type is application/zip
################################################################################################################################# 100.0%
    Downloaded to /Users/n8felton/Library/Caches/Recipe Robot/2021-05-18_12-10-21_286621/finaldraft1200b57Mac.zip
Determining download format...
    File extension is zip
    Successfully unarchived zip
[ERROR] I wasn't able to gather enough information about this app to make recipes. If you saw any warnings above, they may contain more specific information.

# ls '/Users/n8felton/Library/Caches/Recipe Robot/2021-05-18_12-10-21_286621/unpacked'
Final Draft 12.dmg

Expected behavior
Should Recipe Robot be attempting to find a DMG inside a ZIP?

macOS: 10.15.7
Recipe Robot Version: 2.2.0
autopkg version: 2.1
/usr/local/autopkg/python --version: Python 3.7.5

It's difficult to explain why a vendor would do this. The dmg is already compressed; wrapping it inside a zip adds no benefit at all.
Not a top priority, but I'll keep this issue open to consider.


⚠ Bofrost.es has degraded performance

In ea3f62c, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1336 ms

Resolved: Bofrost.es performance has improved in dc2586d after 6 minutes.


deploy run section may be a sequence

Currently only a scalar is accepted by travis-yaml.
see https://secure.helpscout.net/conversation/85841773/15371/

Another finding: https://secure.helpscout.net/conversation/106394882/18115/

@rkh, does this Issue apply to our .travis.yml? We always get the follwoing note when testing it:

in deploy section: dropping file section: unexpected sequence

@SecUpwN I can't see the helpscout links, but from what I can tell from the code it is likely the same general problem.
Like you, I found this when investigating in deploy section: dropping file section: unexpected sequence, which is contrary to the docs for uploading multiple files.


Document which role version support which oVirt engine version

Currently we support following:

1.1.x ansible role s oVirt >= 4.1
1.2.x ansible role s oVirt >= 4.2
1.3.x ansible role s oVirt >= 4.3

We need to document it.

Development moved to https://github.com/ovirt/ovirt-ansible-collection If this is still relevant, please reopen there.


[Device Support Request] LEDVANCE/Osram Gardenpole RGBW-Lightify

Is your feature request related to a problem? Please describe.
It's currently not possible to set the power on state on LEDVANCE/(Osram) Gardenpole Lights.
Describe the solution you'd like
To add the 0x01 (save_defaults) command in the 0xfc01 cluster to store the default state.
(This seems like the way for pretty much all LEDVANCE/Osram lights that exist.)
Device signature
{
  "node_descriptor": "<Optional byte1=1 byte2=64 mac_capability_flags=142 manufacturer_code=48042 maximum_buffer_size=64 maximum_incoming_transfer_size=0 server_mask=0 maximum_outgoing_transfer_size=0 descriptor_capability_field=3>",
  "endpoints": {
    "3": {
      "profile_id": 49246,
      "device_type": "0x0210",
      "in_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0006",
        "0x0008",
        "0x0300",
        "0x1000",
        "0xfc0f"
      ],
      "out_clusters": [
        "0x0019"
      ]
    }
  },
  "manufacturer": "OSRAM",
  "model": "Gardenpole RGBW-Lightify",
  "class": "zigpy.device.Device"
}

Additional context
The "save_defaults" command already seems to be well-implemented for two models, so I guess the same thing should work for this too.

Hi @TheJulianJES / @dmulcahey,
sorry to comment in a closed issue, but I need to do the same thing for the Ledvance Panel TW Z3, I have 3 of them in the bedrooms and when power goes off and on during the night they turn on and I must make sure they remain off, otherwise my wife and kids get mad at me and my "smart" automation stuff...:)
I'd like to do a PR starting from #459, but I need a little bit of guidance regarding the light type differences, how does the quirk match the ID of the device, etc. would love to learn how to do it, if you have the patience to guide me a little bit.
This is the device signature:
{
  "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.Router: 1>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress|RxOnWhenIdle|MainsPowered|FullFunctionDevice: 142>, manufacturer_code=4489, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=False, *is_full_function_device=True, *is_mains_powered=True, *is_receiver_on_when_idle=True, *is_router=True, *is_security_capable=False)",
  "endpoints": {
    "1": {
      "profile_id": 260,
      "device_type": "0x010c",
      "in_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0006",
        "0x0008",
        "0x0300",
        "0x0b05",
        "0x1000",
        "0xfc0f"
      ],
      "out_clusters": [
        "0x0019"
      ]
    },
    "242": {
      "profile_id": 41440,
      "device_type": "0x0061",
      "in_clusters": [],
      "out_clusters": [
        "0x0021"
      ]
    }
  },
  "manufacturer": "LEDVANCE",
  "model": "Panel TW Z3",
  "class": "zigpy.device.Device"
}

Thanks for any help on this.


[SPARK-20933][SQL]when the input parameter is float type，the ’round ’ or  ‘bround’ function can't work well

What changes were proposed in this pull request?
spark-sql>select round(cast(3.1415 as float), 3);
spark-sql>3.141
For this case, the result we expected is 3.142
spark-sql>select bround(cast(3.1415 as float), 3);
spark-sql>3.141
For this case, the result we expected is 3.142
Because Float is converted to Double or BigDecimal directly,which will change its pricision.
If converting float into string can solve this problem.
How was this patch tested?
add unit test

Can one of the admins verify this patch?

Although I agree that 3.1415 should round to 3.141 in both cases, the value of 3.1415f is not quite the same as 3.1415. It's actually something like 3.14149999...  The behavior is correct, therefore. You should find that rounding 3.1415 as a double or string gives the answer you're expecting.

I don't understand why the value of 3.1415f  is  actually something like 3.14149999...
From the user's point of view, i think 3.142 maybe more  reasonable.

Try evaluating 3.1415f < 3.1415. It is true. Floating point representation is inexact and in your example you explicitly choose the inexact representation

Yes,Floating point representation is inexact .But I think if the length of Floating point value  is less than 7, it should be exact.
Evaluating 3.1415f < 3.1415, firstly, 3.1415f will be converted to Double,this step will lead to the precision loss.
Try evaluating 3.1415f == 3.1415.toFloat. It is true.

No, that's not how floating-point works. Even 0.1 as a double isn't exactly 0.1.
No, converting to double from float does not lose precision, but this is beside the point.
3.1415 as a double is also not exactly 3.1415. I don't understand what you're trying to point out; of course the narrowing conversion from 3.1415d to float matches 3.1415f. This doesn't change the fact that the rounding answer is correct here. I think you are thinking of the case where you specified 3.1415 as a decimal type.

maybe i have understood,thanks @srowen


Add unit tests for org.wso2.ballerinalang.compiler.util.NumericLiteralSupport

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

The purpose of this PR is to improve unit test coverage for this class, which will help you detect any regressions caused by future code changes.
Approach

Describe how you are implementing the solutions along with the design details.

I've analysed your codebase and noticed that org.wso2.ballerinalang.compiler.util.NumericLiteralSupport is not fully tested.
I've written some tests for the methods in this class with the help of Diffblue Cover.
Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, releated PRs, TODO items or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #16072 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #16072   +/-   ##
=========================================
  Coverage     11.34%   11.34%
  Complexity     3767     3767
=========================================
  Files          2064     2064
  Lines         96031    96031
  Branches      13462    13462
=========================================
  Hits          10896    10896
  Misses        83026    83026
  Partials       2109     2109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8abe16d...396fb29. Read the comment docs.

Thanks @JohnLBergqvist , for your fix. In order to enable the test case with the build, you need to add your test to testing.xml, similar to
https://github.com/ballerina-platform/ballerina-lang/blob/396fb297798a811a8bb6a5e98378bf9f3842c12f/compiler/ballerina-lang/src/test/resources/testng.xml#L23
Could you please fix it?


ATV reporting "failed to login"

Home Assistant release with the issue:

0.88.1
Last working Home Assistant release (if known):
0.86.4
Operating environment (Hass.io/Docker/Windows/etc.):

Docker
Component/platform:

apple_tv
Description of problem:
After upgrading to 0.88.1, I see errors in the logs re: ATV not being able to authenticate. I deleted the component (and all of its entities) and attempted to re-scan/re-sync. Although everything appeared to work, I started to get this same error upon HASS restart.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
apple_tv:
  - host: <IP_ADDRESS>
    login_id: !secret basement_apple_tv_id
    credentials: !secret basement_apple_tv_credentials
    name: Apple TV

Traceback (if applicable):
Mon Feb 25 2019 08:04:07 GMT-0700 (Mountain Standard Time)
A <class 'pyatv.exceptions.AuthenticationError'> error occurred: failed to login: 403

Additional information:
I am using an ATV3.

Turns out this was caused by the inclusion of both the default_config and apple_tv components in my configuration.yaml; once I picked on, it worked as expected.


Cannot find <ffi.h> under macOS

In a Linux environment, ffi.h is directly inside /usr/include whereas in macOS with a sysroot of /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk, it is inside usr/include/ffi. This caused the following error:
/Users/dave/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Modules/_ctypes/malloc_closure.c:5:10: fatal error: 'ffi.h' file not found
#include <ffi.h>
         ^~~~~~~
1 error generated.

Something to note is that 3.12 removed the libffi that shipped with the cpython sources, which was previously used for MacOS builds. I haven't been successful at compiling against system libffi, and recall needing to set CFLAGS explicitly to where the headers are located. But if there's a way to autodetect the system headers, that'd be great too.

Fixed by PR #14.

Possibly a bit too soon -- for some reason the x86_64 Mac build has now failed even though everything was fine on the M1 system...

Gotcha, we'll keep this open for now

ok I think I see what happened, the found libffi directory is not being passed to the ctypes target

Hmm, for the M1 system (which worked) I have when searching for include/ffi amongst the build files:
PythonBuild-prefix/src/PythonBuild-build/build.ninja
2039:  INCLUDES = -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include/internal -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/PythonBuild-build/bin -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Python -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/ffi
2049:  INCLUDES = -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include/internal -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/PythonBuild-build/bin -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Python -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/ffi
2059:  INCLUDES = -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include/internal -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/PythonBuild-build/bin -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Python -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/ffi
2069:  INCLUDES = -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include/internal -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/PythonBuild-build/bin -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Python -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/ffi
2079:  INCLUDES = -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Include/internal -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/PythonBuild-build/bin -I/Users/dbro078/build/openCOR/build/src/plugins/thirdParty/Python/PythonBuild-prefix/src/Python-3.12.2/Python -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/ffi

PythonBuild-prefix/src/PythonBuild-build/CMakeCache.txt
925:LibFFI_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/ffi

and yet for the x86_64 build I only have:
PythonBuild-prefix/src/PythonBuild-build/CMakeCache.txt
949:LibFFI_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/ffi

OK, the M1 system is using MacOSX14.4.sdk, the other MacOSX14.2.sdk -- I wonder if that is significant. Let me upgrade the x86_64 machine and try again.

The SDK version is probably not crucial here, I think the issue was x86 was hitting this code path which didn't use the detected libffi:
https://github.com/bjia56/portable-python-cmake-buildsystem/blob/libffi-macos-fix/cmake/extensions/CMakeLists.txt#L466
I assume this was because prior versions wanted to prioritize the libffi inside cpython sources over system headers.

Can you see if my libffi-macos-fix branch fixes it on your end?

Will do.

Now all good on x86_64 system. Thanks!


tendermint/roothash: remove Blocks from genesis

PR for https://github.com/oasislabs/oasis-core/issues/2426:

removes Fields from roothash genesis,
adds Round to RuntimeGenesis.

Superseded by #2462.


fix(swarm): fixed issue parsing url with no scheme [EE-4017]

Closes: EE-4017

This went wrong.... reopening a new PR.


When using an expired access token, I'm getting 403 instead of 401

If I go to the sample /oauth/resource resource with an expired access token, I get a 401 "expired_token" message:
{
    "type": "http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html",
    "title": "expired_token",
    "status": 401,
    "detail": "The access token provided has expired"
}

However, if I go to my own "authentication required" REST service with the same expired expired access token, I get a 403 "forbidden" message:
{
    "type": "http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html",
    "title": "Forbidden",
    "status": 403,
    "detail": "Forbidden"
}

After some debugging, it seems that this is because the $response object that was passed to OAuth2\Controller\ResourceController::verifyResourceRequest (and later on set to 401 in OAuth2\Controller\ResourceController::getAccessTokenData) is just ignored later on in ZF\MvcAuth\Authentication\DefaultAuthenticationListener::__invoke (line 174 onwards) and a GuestIdentity is returned, causing the authentication to treat it as an un-authenticated request by a guest, and not as an expired_token request.

any updates on this ?

Shouldn't we get 419 ?

@ezimuel Can you look into this one, please?

Any update on this?

From the looks of things, I'm going to have to hack in some sort of global state to account for a 419 here. Is there any knowledge for your side that will help with this or am I on my own?
Also worth noting that this bug makes this system effectively useless for any sort of production API that's used for the purposes of mobile and/or web apps - there's no way to know the difference between a 403 access denied and a 403 invalid token (which should be a 419 anyway)

Actually it needs to be a 401 as you have an option of "fixing" it by
login.
On Sunday, July 5, 2015, Daniel Hunt<EMAIL_ADDRESS>wrote:

From the looks of things, I'm going to have to hack in some sort of global
state to account for a 419 here. Is there any knowledge for your side
that will help with this or am I on my own?
Also worth noting that this bug makes this system effectively useless for
any sort of production API that's used for the purposes of mobile and/or
web apps - there's no way to know the difference between a 403 access
denied and a 403 invalid token (which should be a 419 anyway)
—
Reply to this email directly or view it on GitHub
https://github.com/zfcampus/zf-oauth2/issues/69#issuecomment-118644462.

--
Sent from a mobile thingy
Please excuse typos

This is fixed in zfcampus/zf-mvc-auth#83 — ZF\MvcAuth\Adatper\OAuth2Adapter now checks the response on OAuth2 validation failure to determine the type of failure, and returns a 401 if invalid credentials/tokens were provided, and a 403 if it was due to unauthorized scope.

Woot!


Consider supporting bounds for NonlinearProblem resolution

This issue is based on the discussion in here
The idea would be to support resolution of systems of nonlinear equations subject to contraints such as the ones available with JuMP https://jump.dev/JuMP.jl/stable/installation/#Supported-solvers

Isn't that just an OptimizationProblem with a dummy objective function, i.e. a feasibility problem.

Yes, feasibility problems are nonlinear problems. We should have such conversions automated in the near future, that would be nice. But one of the things prohibiting that right now is indeed the lack of bounds support in NonlinearSolve.jl


merge GO:0102005 with GO:0043333?

@drabkin, it looks like these might be the same enzyme, just named slightly differently. Can you check the details and merge if appropritate.

Thought it might have been from the Peifen set 0102005, (based on high id range), but it appears not. Will need to investiage.

Thanks. There are lots of enzymes where there is an exact synonym from EC that matches another term name. But in almost all cases, they aren't exactly the same.

Yes, I saw this a lot with the plant stuff.

Once I clean it up, I will open a ticket for a check, so this won't happen.

I fear many of Peifens will fall into these, as for expediency, I just checked for duplicate term names (which aren't allowed). 8-(.

Digging around in the annotations
GO:0043333 has one annotation for Ecoli ; this protein is listed on the EC entry page (EC <IP_ADDRESS>, which is listed as the xref for GO:0102005!
GO:0102005 has 15, mostly IEA;  one experiment to human; that UniProt id for that protein is not listed on the EC entry page; however, the record for the human protein at UniProt lists the EC number.
Based on this, I'm thinking of a merge

Done here #15686


remove logout keyword from Jupyterlab Git Notebook test case

this PR should fix the JS error we face in one of the JupyterLab TC, which was reported by @lugi0

Jenkins Job #JOB298. The failures are not related to this change and the "Jupyterlab Git Notebook" TC has passed.
However, I noticed there is one more TC in Tier2 quality gate which has the same issue, therefore I changed it too in a new commit. I'm going to run a new PR test job

Can you remove it also from test-jupyterlab-flask-notebook.robot? Teardown is also failing because of using this keyword:
https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-tier2/10/TestReport/
Can you also add a  [Documentation] section with a warning that this keyword doesn't work well Logout JupyterLab doesn't work well we should add

this is the Jenkins Pr job to test the changes after the last commit: JOB#299
Both the TCs affected by this PR are successful.


Problem with saving DataFrames to root files when they contain dtype object

Hi,
i have several textfiles with strings and floats in them. I can load them into a panda dataframe nicely.
I also need to save them in root format and wanted to use this library.
However, when i call the to_root function on my dataframe i got the following:
UserWarning: converter for dtype('O') is not implemented skipping
And indeed, if I load the rootfile later with read_root later the columns with strings in them miss.
I then tried this:
>>> for c in df.columns:
...     if df[c].dtype == object:
...         df[c] = df[c].astype(str)
Now i did not get any error message using to_root. However, when i load the root file later to a pandas dataframe it still misses the columns where strings are supposed to be.
How to fix this?
Thank you very much

You need to convert the str columns to the numpy string type S.
However, there seems to be a bug in pandas which is preventing that on reassigment,
I filed this issue here: https://github.com/pandas-dev/pandas/issues/15575
In the mean time, you might need to copy your data:
df2 = pd.DataFrame()
for name, column in df.items():
    if columns.dtype == object:
        df2[name] = column.astype('S')
    else:
        df2[name] = column

The S column type requires a maximum length of the string, be default it will take the longest string
in the series. If you want to give the max length yourself, you can do column.astype('S10') for a max length of 10.

They actually consider it a bug that the dtype on new assignments is not object.

Hi,
thanks for taking the time. Unfortunately your way of circumventing this issue does not work for me :(
Even if i create this new df2 and call .astype('S') or .astype('S10') it will stay of type object
I tried what you did in https://github.com/pandas-dev/pandas/issues/15575 and also there my output of
import pandas as pd
df = pd.DataFrame({'a': ['Hello', 'World']})
df['a'] = df['a'].astype('S')
df['b'] = df['a'].astype('S')
print(df.dtypes)
is just simply object for df['b'] aswell.

@MatousVozak What is the contents of the column that is an object? Strings, arrays or something else? The issue is inside root_numpy but it's unlikely to be fixed unless you're willing to make a pull request as it has been effectively depreciated in favour of uproot.
That said, a better question is you need to save to a ROOT file? You might be better served using a file format natively supported by pandas like hdf5.

Hi @chrisburr, yes it is a string and I needed to save into a root file. I simply wanted to change entries of one branch which was of a type char/string. As this was a hot fix and I couldn't find a quick work around I Eventually turned into a pyroot to do the job.
Best,
Mat

Was a workaround ever found for this?

Kind ping to @chrisburr ... though you may want to look at the uproot package at this stage?

As explicitly written in the README since a while, root_pandas, and root_numpy on which it depends, has been deprecated and effectively unmaintained for quite a while. We decided to close anthing outstanding as "won't do" and archive the package at this point.


Properly handle CARM errors and requeues

Prior to this patch we introduced new mechanisms to handle Role ARN
retrievals from the CARM cache. Which improved ACK runtime scaling
capabilities and addressed possible race condition scenarios. However in
the process we missed two things:

Setting an ACK.ResourceSynced condition stating that the resource
isn't synced, yet.
Returning the correct runtime error that will cause the reconciller to
requeue every 15seconds.

Both of the problems stemmed from the fact that we're not "yet" in the
reconcile function (rm.Sync) that is wrapped by a proper error handler
(that triggers requeues, and resets/sets resource conditions). In this
special case, we need to manually inject the condition and return a
controller-runtime error that will trigger a requeue after 15seconds.
While this is a "fair" fix, we're planning on refactoring a lot of the
runtime logic to make easier to read, maintain and more importantly
expose reusable component that will help avoid falling into such traps.
Signed-off-by: Amine Hilaly<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test all

/retest

/retest

/test all

/retest

/retest

/lgtm


Added WaitForNetworkTeam resource - Fixes #319

Pull Request (PR) description
This PR adds the WaitForNetworkTeam resource that will wait for a network team to come 'up' before proceeding.
This Pull Request (PR) fixes the following issues:

Fixes #319

Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[x] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[x] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and (optional) Integration tests created/updated where possible?

@johlju or @tysonjhayes - would either of you mind reviewing if you have time?

This change is

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Tests/Integration/MSFT_WaitForNetworkTeam.Integration.Tests.ps1, line 12 at r1 (raw file):

    SKU machines will support it.
#>
return

Should we write out a warning that it cannot run in AppVeyor when $env_APPVEYOR -eq $true and return? Would be cleaner if the integration test could run when manually started in a lab without needing to change the test code?

Tests/Unit/MSFT_WaitForNetworkTeam.Tests.ps1, line 106 at r1 (raw file):

Set-targetResource

Set-TargetResource (upper 'T'). Throughout.

Comments from Reviewable

Review status: 7 of 13 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Tests/Integration/MSFT_WaitForNetworkTeam.Integration.Tests.ps1, line 12 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should we write out a warning that it cannot run in AppVeyor when $env_APPVEYOR -eq $true and return? Would be cleaner if the integration test could run when manually started in a lab without needing to change the test code?

I've done this and also in the other Network Team integration tests. I added a new Common Test Helper function to reduce code duplication for these.

Tests/Unit/MSFT_WaitForNetworkTeam.Tests.ps1, line 106 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Set-targetResource

Set-TargetResource (upper 'T'). Throughout.

Done.

Comments from Reviewable

All done now! Thanks @johlju

Review status: 7 of 13 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

a discussion (no related file):
There are merge conflicts that need to be resolved.

Tests/TestHelpers/CommonTestHelper.psm1, line 112 at r2 (raw file):

    if ($NetworkAdapters.Count -lt 2)
    {
        Write-Warning -Message 'Performing Network Teaming integration tests requires at least two compatible network adapters to be specified.'

Maybe add to the message how they add those adapters? Point them to the comment-based help in each test maybe? :)

Comments from Reviewable

Review status: 11 of 14 files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
There are merge conflicts that need to be resolved.

Fixed merge conflict and also added line missing from README.MD

Tests/TestHelpers/CommonTestHelper.psm1, line 112 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Maybe add to the message how they add those adapters? Point them to the comment-based help in each test maybe? :)

Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Good catch! There a quite a lot of places to change when adding a new resource. :/ Maybe we should try to get more into the auto-documentation (when we have time). :slightly_smiling_face:

Definitely! This should be able to be done as well I think!

Comments from Reviewable


Fix/#49

fix some bugs

Codecov Report

Merging #52 into master will decrease coverage by 0.76%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   58.09%   57.32%   -0.77%
==========================================
  Files          30       30
  Lines         377      382       +5
  Branches      112      114       +2
==========================================
  Hits          219      219
- Misses        127      130       +3
- Partials       31       33       +2

Impacted Files
Coverage Δ

packages/swagen/src/helpers.js
29.48% <0%> (-2.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e19ee...dfe3b79. Read the comment docs.


Select input resets when the form encounters validation errors

Laravel Version: 5.7.26
PHP Version: 7.1.9
Laravel-admin: 1.6.15

Description:
I have some select input which loads option by ajax in my form, such as:
$form->select('university_id')->options(function ($id) {
                    $university = University::find($id);
                    if ($university) {
                        return [$university->id => $university->title];
                    }
                })->ajax('/admin/api/universities', 'id', 'title');

Select input resets when the form encounters validation errors.
I want to have the old value after validation fails.
Steps To Reproduce:

Can anyone help me with that?!
all my ajax loaded select inputs resets when the form encounters validation errors.
@z-song ?!

It's an old issue, but I resolved it some kind of this way (pseudocode):
$form->select('university_id')->options(function ($id) {                     if(!$id) $id = old('university_id');                     $university = University::find($id);                     if ($university) {                         return [$university->id => $university->title];                     }                 })->ajax('/admin/api/universities', 'id', 'title');
Why? On validation error it's redirected to previous URL with setting old input into session and error messages. Submitted values are handled by templates itself by using "old" helper function, so field itself doesn't keep value on error and it's not passed by $id argument.

@shacky super cool, thx!


feat(css): CSS (and preprocessor) ?url (fix #2522, #3833)

Description

[ ] Handle ?url for css and css preprocessors (return source path on dev server and compiled asset path on build)
[ ] Ensure css asset is compiled regardless of being imported by a script

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

I think I bit off more than I can chew with this.


Concept ExecutionModel

Specify reuirements of execution model trajectory exactly, e.g. must contain a trajectory state at specific world time
Remove additional nearest time point search in agent DoExecution()
ExecutionModelNan

assert times!

Resolved in development branch with PR #364


Move to 3.11-SNAPSHOT

Signed-off-by: Mandy Chessell<EMAIL_ADDRESS>

Problem seems to be that it can not find the 3.11-SNAPSHOT

Do you need the snapshot?
By default maven central & ~/.m2 will be in the repository search path. snapshots will not. If you want the CI build to pick up SNAPSHOTS, then you need to add that repo into the build.
For gradle, something like:

buildscript {
    repositories {

        maven { url("https://oss.sonatype.org/content/repositories/snapshots") }
        mavenCentral()
    }
}

For maven:

    <repositories>
        <repository>
            <id>ossrh-snapshots</id>
            <url>https://oss.sonatype.org/content/repositories/snapshots</url>
        </repository>
    </repositories>

Or similar. google for refinement.


TRANSLATE: README Documentation into Uzbek language

/hold
We don't yet have any reviewers for Uzbek. See https://kubernetes.io/docs/contribute/localization/ for how to set up a localization team.

/close
@dostonbek-andijonlik once there is a localizatio team for Uzbek, you are welcome to reopen this.

/close
@dostonbek-andijonlik once there is a localization team for Uzbek, you are welcome to reopen this.

Thank you 😊


Error: must bypass byte-per-second

This error can happend when you aren't provide any byte-per-second argument in player.play function.

Probaly related with fluent-ffmpeg issue that returns bit_rate as N/A.

This bugs will patched in next version as well.


Excluding .test.js files from build

Hi!
Is it possible to exclude from build some type of files?
For example if test files stored next to tested component (/pages/component.vue and /pages/component.test.js)
Trying to exclude files inside extend but without success, nuxt grab .test.js file while building

This feature request is available on Nuxt.js community (#c2258)

Hi @Atinux,
what about the test files that are located in the components folder? How can we ignore these kind of files at build time?

If you don't require them in your app, they won't be imported at build time @marco-gattelli


#minor Fix single task execution node input generation

TL;DR
This PR updates single task execution workflow generation such that the node containing the single task uses promises as inputs to pass through execution invocation inputs rather than statically bound values.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Discovered by @kumare3
Tracking Issue
https://github.com/lyft/flyte/issues/370
Follow-up issue
NA

Codecov Report

Merging #104 into master will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   63.24%   62.87%   -0.38%
==========================================
  Files         101      101
  Lines        7465     7369      -96
==========================================
- Hits         4721     4633      -88
+ Misses       2197     2191       -6
+ Partials      547      545       -2

Flag
Coverage Δ

#unittests
62.87% <100.00%> (-0.38%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/manager/impl/util/single_task_execution.go
81.25% <100.00%> (-4.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf02a81...3c36a88. Read the comment docs.


v2 -> npm -> wrong owner?

Hallo @regnete,
I ask NPM about our problem, but they well to know a little bit more:

I'm following up on this package issue. If you could share more about what your desired solution would be in this case, that would help determine next steps.

So, can you write more info about merge/delete wrong npm-module?

Thank you for taking care on this issue.
The plugin is published at npm with to different ids:

cordova-plugin-document-viewer at https://www.npmjs.com/package/cordova-plugin-document-viewer
de.sitewaerts.cordova.documentviewer at https://www.npmjs.com/package/de.sitewaerts.cordova.documentviewer

The first ID is published and maintained by me. It is based on the source at this github repo. It is up to date.
The second ID was published to npm by someone else based on a github fork. The plugin was not updated and maintained since it was first published a year ago. Even the github fork  doesn't show any activity. I think he only forked the repo to be able to publish it to npm, as we didn't publish our plugin to npm from the beginning on.
As the second ID is heavy outdated it should not be used by anybody anymore. I tried to contact the publisher but didn't get any response to my emails. He should update his github fork and republish to npm or the npm ID de.sitewaerts.cordova.documentviewer should be deleted/removed/redirected.
Please come back to me with any questions.

Just another reason to delete the old ID from npm:
The old outdated plugin is listed at cordova.apache.org, but the new one isn't.
https://cordova.apache.org/plugins/?q=pdf

Hi @regnete, I send your message on npm-support. until yet no answer :(

Hallo @regnete

Stephanie Snopek (npm) Feb 28, 15:19 PST
In this case, I would recommend going through our disputes process to request taking over the module, so you can keep it updated as needed.
https://docs.npmjs.com/policies/disputes
Essentially, email the current owner with your transfer request, cc'ing npm support. Our timeline is ~4 weeks to hear back from them, and if there is no response the package is likely abandoned. In those cases of abandonment, we'd transfer the package to you so you can update it, or decide to deprecate.
Let me know if you have any questions about this, I'll be here to help.
Thanks so much,
Stephanie
Tech Support
npm, Inc

Thank you. I just started the npm dispute process with an email to the owner and npm. Now we have to wait for the responses.

The ownership for the wrong/old npm module was passed over to me by the intial npm publisher. It's now marked as deprecated and will be removed in a few weeks.


Use encoding/csv for CSV output

@gcmurphy @callidus
The encoding/csv package will take care of quoting, double-quoting,
and other CSV quirks -- avoids having to fiddle with text templates.

LGTM, thanks @csstaub


Add lab virtual machine owner re-esablishment script and readme

Thanks @leovms , I will push this in now and update based on your feedback as a follow up.


Explicitly set preserveUnknownFields to false

Longhorn 7887
Which issue(s) this PR fixes:
longhorn/longhorn#7887
What this PR does / why we need it:
If Longhorn and Kubernetes are upgraded in a particular order from Longhorn v1.0.2- to the latest, preserveUnknownFields may remain true, even though the default (and intended value) is false. As a result, Kubernetes does not consider affected CRDs to have structural schemas, potentially resulting in unexpected behavior (including https://github.com/longhorn/longhorn/issues/7887).

@mergify backport v1.6.x v1.5.x v1.4.x


NewYearCountDown

#145 Added a new cool stuff, which can be visited at new year time if new year celebration will be happening virtually. It will light up a confetti which I also added and make UX great.
##EVENT
GSSOC

close #146


[tests] Fixed flaky selenium test: test_addition_of_transition_effect

Fixed flaky selenium test: test_addition_of_transition_effect.

coverage: 96.19%. remained the same
when pulling bb7110c3a7db5cec7866e0e91548324d352183d9 on fix-test_addition_of_transition_effect
into 15366d4160b1ec8ecac023f33e27d1020c771720 on master.


⚠ SceneTime has degraded performance

In a87b65d, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1355 ms

Resolved: SceneTime performance has improved in 39e3940 after 6 minutes.


PRL-3140 & PRL-3141 for childAnsApplicant , childAndRespondent and Ch…

…ildAndOtherPerson Relation
Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

These changes will be merged as part PR https://github.com/hmcts/prl-cos-api/pull/1599
Closing this PR.


WIP: Potential API change

Hi!
I was trying to play around with this awesome library, and in so doing came up with some (potentially not completely backwards-compatible...) API changes that I think might be worthwhile. Thought I'd throw them together into a PR to get some feedback (prior to updating all the extant Matcher impls to adhere to the new API).
The main thing is to ask Matchers to return the following complete set of information in a structured way:

What the Matcher looks like.
What the Matcher thinks the "actual" value should look like.
Whether the match was successful or not.

And optionally an explanation for why the match was unsuccessful.

I also put in a slightly modified template for match-failure panic messages:
  Expected: <formatted matcher>
       Got: <formatted actual value>

Or, if an optional explanation is attached:
  Expected: <formatted matcher>
       Got: <formatted actual value> (<explanation>)

DO NOT MERGE. At the moment this is just a vessel for feedback.

Looks cool :+1:
Also, you can prefix PR name with "WIP: " to explicitly state that it's not supposed to be merged. E.g.
WIP: Potential API change

So I guess the question is: should I make a real PR with updated default matchers, etc.?

Ping @ujh

@ujh seems to be MIA? @povilasb What's the path forward?

Hmmm, the only way I see is forking. But I really don't wanna do that. In that case we'd still need @ujh to help publish new versions on crates.io or transfer permissions etc.
I'd really like to get some feedback from @ujh first.

@joshburkart you should take a look at https://github.com/Valloric/hamcrest2-rust ;)


Update CreateAddress

What current issue(s) does this address, or what feature is it adding?

Addresses Issue https://github.com/CityOfZion/neo-python/issues/670
Updates CreateAddress functionality
Improves CreateAddress tests

How did you solve this problem?
trial and error
How did you make sure your solution works?
Unittest
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:

[x] Did you add any tests?
[x] Did you run make lint?
[x] Did you run make test?
[x] Are you making a PR to a feature branch or development rather than master?
[x] Did you add an entry to CHANGELOG.rst? (if not, please do)

Seeing this failure now:
FAIL: test_binops (boa_test.tests.test_binops.TestContract)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.6.3/src/neo-boa/boa_test/tests/test_binops.py", line 50, in test_binops
    tx, results, total_ops, engine = TestBuild(out, ['<<', 16, -2], self.GetWallet1(), '', '07')
AssertionError: ValueError not raised
----------------------------------------------------------------------
Ran 104 tests in 23.470s
FAILED (failures=1)

Investigating.

@ixje is the the failure I'm seeing above ☝ something that I need to resolve or it something that you are resolving? The failure looks to come from a test you modified 5 days ago. It is the same test that is failing in  https://github.com/CityOfZion/neo-python/pull/669 but for a different reason.

i'm working on resolving that issue...no need to worry at this point

Okay thank you @ixje


Update natvis to reflect 3.11.3 and the current structure of basic_json

In #3901 the underlying structure of basic_json was altered to move m_type and m_value under an m_data field. This updates the natvis Jinja template to be consistent with this change.  The template is rendered to produce nlohmann_json.natvis consistent with version 3.11.3.
fixes #4438
fixes #4340

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[ ]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Thanks a lot!


Yes, this workaround increases letter spacing so it is not suitable for us. I just found another workaround which I not see in this thread:

This URL https://unicode-table.com/ has changed to https://symbl.cc/
        > Yes, this workaround increases letter spacing so it is not suitable for us. I just found another workaround which I not see in this thread:

 text.replaceAll(' ', '\u{000A0}')

We started to use it and it seems that it "just works" for all our use cases. It just replaces all spaces in text with Unicode No-Break Space character.
Hope it may help someone :)

@roman-petrov that's a good fix. If you make one more modification it also replaces hyphens with non-breaking hyphens:
'UFC 284 - Makhachev vs Volkanovski'
    .characters
    .replaceAll(Characters(' '), Characters('\u{00A0}'))
    .replaceAll(Characters('-'), Characters('\u{2011}'))
    .toString()

Without the second replaceAll the text looks like this:
"UFC 284 -..."
Instead of this:
"UFC 284 - Makhachev vs V..."
Originally posted by @anthonymoretti in https://github.com/flutter/flutter/issues/18761#issuecomment-1415091689

@deltoro05
Please don't use comments from other issues to file a new issue. The linked issue is very old. Please use new issue template, fill out requested details so that we can properly address the issue.
Closing for now due to lack of details.


No error in swagger-parser when $ref to nothing

I encountered a problem in swagger-parser where a $ref to an object that does not exist at all did not throw an error - is this a bug, a configuration error, or do I need to run validation with something else first?

replied to user in:
https://community.smartbear.com/t5/Swagger-Open-Source-Tools/No-error-in-swagger-parser-when-ref-to-nothing/m-p/207157/highlight/true#M1422


Generate a PR to auto bump windows gitlab runner version on every new RC

What does this PR do?
Add a new job generate_windows_gitlab_runner_bump_pr which depends on trigger_auto_staging_release to generate a workflow on buildenv repository to bump windows runner agent version.
Motivation
RFC
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

Finishing QA before marking it as ready

/merge


Relationships are not stored in the database

Aarjav we are aware of this short coming, we are working on adding this feature to our source.


Silencing and unsilencing alerts should be done with a tool

Being able to silence and unsilence rules should be done with a command line tool

Any work being done on this?

You can run $ elastalert --verbose --rule noisy_rule.yaml --silence hours=4

Oh sorry. I meant if it is possible to UNsilence a rule?

Not quite as easily. Try
$ curl -XDELETE 'localhost:9200/elastalert_status/silence/_query' -d '{"query": {"query_string": {"query": "rule_name: \"my rule name\"}}}'

Thanks.
Since, I have query_key enabled, the rule_name field in silence type includes query keys as well.
I used regexp query to delete them.

@Qmando > You can run $ elastalert --verbose --rule noisy_rule.yaml --silence hours=4
Can I also do this in the following case?

Elastalert is running and no alerts were triggered yet
I want to do maintenance tasks for which I need to shutdown a system
I keep elastalert running
I execute the command while the other elastalert process is still running
I take the system offline, no alert is sent
After 4 hours, the alert would be triggered again automatically

My main question is: do I need to stop my first elastalert process before calling the "silence" command

@Qmando
I had silenced a rule for 1 day. After 1 hour, I wanted to unsilence it, and removed the entry from /elaslalert_status/silence
However, I still don't get the alerts.
Any idea why?


Failed to configure Hilla engine (using gradle in Windows)

Hi, while running the vaadinBuildFrontend Gradle task in the project described on your page (https://hilla.dev/docs/react/start/gradle), I encountered an exception.
The stacktrace indicates that the exception is caused by com.vaadin.flow.server.ExecutionFailedException: Failed to configure Hilla engine.
The root cause of this issue is that somewhere in this task, there is a check command being executed:
./gradlew.cmd -v
However, there is no gradlew.cmd script, but rather a gradlew.bat script.
To resolve this, you can simply copy the gradlew.bat script and rename it to gradlew.cmd.
I'm unsure about the best solution for this problem, but I couldn't find any. If you'd like, I can create a pull request (PR) to update the documentation with this information.

Which Hilla version are you using? This has been fixed in https://github.com/vaadin/hilla/pull/1064 and https://github.com/vaadin/hilla/pull/1068.

The fix (#1068) was released in 2.1.2.


game stuck, constantly occupying computer memory

oes anyone know what's going on? when I play for about 3-4 hours, CSGO will get stuck and constantly occupy memory

restart csgo. problem solved. close


Upgrade UI-Router

Used the new router as recommended and worked around glaring gaps such as the lack of a default route, and that nested viewports do not work.  We ignored the controller getting constructed twice and worked around the inability to inject $scope (beneficial side-effect of using the new router).  The code itself looks needlessly complex and clumsy to extend, although it obviously aims to be the opposite of that with it's multi-stage processing pipeline.  This is strike two on routers from Angular proper and it would probably benefit all to simply take the vastly superior ui-router and adopt that to Angular 1.5 and Angular 2.0.  The new router has been a painful and expensive dead end.  The Angular team and the community in general should view this as a problem with Angular's process and direction and be much more cautious and distrustful going forward.

I burned  my time trying to make new router working with nested views.
Finally decided to wrap ui-router with ES7 decorators that looks like new router I.e., @RouterConfig

@xmlking can you share your work? I notice that "the code has been moved to angular/angular"

@xmlking can you share your work? :)

I just experienced the same ;-(, going back to ui-router


add vector slice

This is really great. But you don't need to define in -- it already works, because nim defines it in terms of contains.

Oh nice! I can never remember that ‘in’ is already defined.

Currently the behavior of add on slices is buggy because it still thinks it's the original vector:
var s2 = v1[1..1] # ["two"]
s2 = s2.add(0, "yo") # expected ["yo"] but I get ["two"]
s2 = s2.add("yo") # expected ["two", "yo"] but I get ["yo"]

Currently the behavior of add on slices is buggy because it still thinks it's the original vector:

Good catch! Ok, I pushed fixes for add on a slice. I also found a bug in the regular vector add too where the Leaf branch didn't increase the vec size. There should probably be large vec test for these too.
Merry Christmas and thanks for a fun x-mas day puzzle! ;)


fix destroy functionality

includes "Remove window event listeners when plugin is destroyed" (tokybd)
Merge remove event listeners and will set vars to undefined instead of "null" in order to be able to reinitialize.

+1


[NFC] Silence some warnings in the overlays

@swift-ci please test.

I would really like the Foundation and XCTest teams to look at these rather than just silencing them. It's very possible they indicate mistakes.

There.  All else being equal, good to merge?
@swift-ci please smoke test.

Closed in favor of #6506


N+1 Queries with nested Includes

#204 and #205 address eager loading of resources and remove the N+1 query issue when resources are included. However the N+1 case still exists for nested includes. For example include=author,author.comments results in 19 queries in the test code.
I've made a branch to show this (https://github.com/cerebris/jsonapi-resources/tree/query_count). The tests in this work, but aren't what I want in the final codebase.

Here're the queries that are being run for fetching the posts with include=author,author.comments:
Processing by PostsController#index as HTML
  Parameters: {"include"=>"author,author.comments"}
  Post Load (0.2ms)  SELECT "posts".* FROM "posts"
  Person Load (0.2ms)  SELECT "people".* FROM "people" WHERE "people"."id" IN (1, 3, 4)
  Comment Load (0.1ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" IN (1, 3, 4)
  Comment Load (0.1ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 1]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 1]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 1]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 4]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 4]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
  Comment Load (0.0ms)  SELECT "comments".* FROM "comments" WHERE "comments"."author_id" = ?  [["author_id", 3]]
Completed 200 OK in 53ms (Views: 4.3ms | ActiveRecord: 1.1ms)

It appears the eager loading is working based on the first three queries, however the comments aren't using the retrieved comment data when they are being instantiated.

I didn't know about query_diet so instead I used instrumentation to track the queries:

## A little hack to get some numbers of how many queries was used
queries = {}
ActiveSupport::Notifications.subscribe('sql.active_record') do |name, start, finish, id, payload|
  name = payload[:name] || payload[:sql].gsub(/((?:FROM|JOIN) "?[\w_]+"?)/, "\1")
  queries[name] ||= 0
  queries[name] += 1
end
ActiveSupport::Notifications.subscribe('start_processing.action_controller') do |name, start, finish, id, payload|
  queries = {}
end
ActiveSupport::Notifications.subscribe('process_action.action_controller') do |name, start, finish, id, payload|
  Rails.logger.info("queries:")
  total = 0
  internal = 0
  queries.keys.sort.each do |name|
    count = queries[name]
    Rails.logger.info(" - #{name}: #{count}")
    if name == 'SCHEMA' || name == 'CACHE'
      internal += count
    end
    total += count
  end
  Rails.logger.info(" = #{total} (- #{internal} internal)")
end

I just logged it (as you can see) but maybe you can change it to something in a test helper?

Thanks, I'll take a look at it. Query_diet was literally the first thing I found that worked for the task. I've hacked how it's used, and it's not very elegant. Still it beats looking only at the log file one test at a time.

Cool, if you get it working feel free to update this PR and I'll try to debug on my end too

I just updated #205 with a simple query_count method based on the ActiveSupport::Notifications.subscribe('sql.active_record') method. I'm going to get rid of the query_count branch now.

Quick work! I'll have a look

@lgebhardt @slaskis fixed by #205? Can be closed?
Doesn't seem like this is the issue anymore on 'master'
get '/articles?include=user,user.comments'

Article Load (1.3ms)  SELECT "articles".* FROM "articles"  ORDER BY "articles"."id" ASC
User Load (0.6ms)     SELECT "users".* FROM "users" WHERE "users"."id" IN (1)
Comment Load (0.6ms)  SELECT "comments".* FROM "comments" WHERE "comments"."user_id" IN (1)


Help pane doesn't accept aliased modules

Steps to reproduce:

Import some module in Python with an alias - e.g.

import numpy as np

(not import numpy)

Type the name of one of the imported module's function/classes in the help pane along with its prefix - e.g. np.arange
Press enter.

Expected behavior: should show the help for the function/class that was requested. Should also ideally not need an enter keypress, like it was in 3.3.1.
Actual behavior: deletes what was just written and goes back to what was previously there, or to blank if nothing was written before. As such, cannot get help for a function inside an aliased package unless importing it like
from numpy import arange

Will also not take it with the package's full name - e.g. numpy.arange would also not work.
Setup: Spyder 3.3.4, running on windows 10, installed from Anaconda, Python 3.6.8.

I can confirm this in master as well.
ctrl+i on np.arange in the console works as expected.

Is this a regression ? or this has been a bug for some time?

Is this a regression ? or this has been a bug for some time?

It's a regression, was working fine in 3.3.3 when copy-pasted, and fine in 3.3.1 when written.

@dalthviz, please take a look at this one. I think it's related with the changes you made in 3.3.4 to try to fix another problem in the search field of the Help pane.


Issue #212 [Title] Add support for anchors.

Q
A

Fixed Issues?
#212

Patch: Bug Fix?

Minor: New Feature?
Yes

Major: Breaking Change?

Tests Added + Pass?
Yes

Documentation Provided
Yes (code comments and or markdown)

Any Dependency Changes?

License
Apache License, Version 2.0

Codecov Report

Merging #229 into development will increase coverage by 0.04%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##             development     #229      +/-   ##
=================================================
+ Coverage          82.74%   82.78%   +0.04%
- Complexity           787      792       +5
=================================================
  Files                 73       73
  Lines               2538     2545       +7
  Branches             463      466       +3
=================================================
+ Hits                2100     2107       +7
  Misses               174      174
  Partials             264      264

Impacted Files
Coverage Δ
Complexity Δ

.../core/components/internal/models/v1/TitleImpl.java
94.73% <100%> (+2.42%)
12 <1> (+4)
:arrow_up:

...com/adobe/cq/wcm/core/components/models/Title.java
100% <100%> (ø)
4 <1> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4397f26...411fb18. Read the comment docs.


Feature/3190 expand k8s nodes capabilities with storage from rook

WIP state.

Closing as a new pull was made for this: #3237


HHH-15534 Publish recent version of Hibernate Gradle plugin

https://hibernate.atlassian.net/browse/HHH-15534

Superseded by https://github.com/hibernate/hibernate-orm/pull/5337


Trigger tap event

What versions are you running?
$ go list -m github.com/chromedp/chromedp
github.com/chromedp/chromedp v0.8.5
$ go version
go version go1.18.6 windows/amd64

What did you expect to see?
I don't know how to trigger a click event.
What should I do?

See https://github.com/chromedp/examples/blob/master/click/main.go

I need to trigger the tap event of this element, but chromedp Click cannot complete


Implement search command

Use Pub's search api to look up packages from the Pub repo.
This involves adding a search command:
$ crawl search -p dio
$ crawl search -p dio -n 3 # list n results

and displaying the results in a formatted row.

Released under 0.6.0. Currently lists latest 10 results from search api.


Set custom value to queryKey

Problem
connect-web automatically makes queryKey, it is useful in many cases.
But, I may have issue for controlling cache.
This is an example of Todo app.
queryKey of Todo List
["example.v1.Service", "GetTodos"]

queryKey of Todo Detail**
["example.v1.Service", "GetTodo", {id: "xxx"}]

The second element is methodName.
Because this is different, invalidating the list does not discard the details cache.
Proposal
Can we extend useQuery function to set an arbitrary queryKey?

Hi @himaratsu. This behaviour is by design, we do it to provide strict type safety. You can of course use createQueryOptions directly and override the queryKey if you want to, but it opens you up for potential type mismatches.
If I understand your meaning, you want to invalidate more than one query with a call to invalidateQueries. One way to do this while maintaining the integrity of the key/value relationship would be to use predicate like so:
queryClient.invalidateQueries({
  predicate: (query) => {
     const queryKey = query.queryKey as ConnectQueryKey<AnyMessage>;
     return queryKey[1] === methodDescriptor.name || queryKey[1] === methodDescriptor.name
   },
})

We should have a slightly more robust and typesafe way to operate on the queryclient after v2 is released but this should do for now.
This behaviour will likely change in v2 since we're improving the keys

Hi paul-sachs , Thank you for your help.
I’ll try it!