why istio not working well with calico in openshift 3.11

I use istio to monitor all my services in k8s with calico environment.
The situtation is nothing captured into the prometheus and I got nothing edges displayed in the kiali component. And also the istio grafana dashboard (which grafana dashboard id is 7636)
Expected Behavior
Display all the traffic diagrams.
Current Behavior
nothing appears
It seems istio hijack failed , although injected succeed.
Your Environment

openshift 3.11
calico 3.8
istio 1.3.2

Have you configured network policy that may be blocking traffic?
@spikecurtis do you have any idea what the issue may be here?

@zzzhy can you explain why you think Calico has something to do with Istio not working? For example, was it all working fine before you installed Calico?
You should be able to check if Istio hijack is working by examining iptables within the pods. Are you using the Istio CNI plugin to configure the hijack, or the init container? I have a vague memory of some people hitting issues with CNI config ordering when combining the Istio CNI plugin with the Calico CNI plugin.

my develop env is on the minikube while production env is kubernetes with calico,  all run well in develop and not as the production.
when using the install option global.proxy.privileged , all things become normal , althougn I doubt if it is the right solution .
terribly sorry for not really confirmed whether it involoed with calico.

If running the Istio-proxy in privileged mode solves the problem it's very unlikely to have something to do with Calico.
The hijacking works by running the Istio proxy as a specific user (UID 1337 if I recall correctly).  I think that OpenShift by default assigns UIDs from a (per-namespace?) range, which might interfere with the proxy. Running as privileged might override that behavior and get it running as UID 1337.
@zzzhy if you need further help, I suggest you try the Istio forums at https://discuss.istio.io/ . Is it OK if we close this issue?

@spikecurtis thanks, just close it.


log when no services are loaded

It is possible to start a service that is empty. We should log it.
At the moment, it only logs what's loaded, when it's loaded. In the absence of service, we just get:
2021-07-05T15:36:01.044Z	INFO	app	application started
2021-07-05T15:36:01.044Z	INFO	app	started API server	{"addr": "<IP_ADDRESS>:8080"}
2021-07-05T15:36:01.044Z	INFO	app	started Health server	{"addr": "<IP_ADDRESS>:8081"}

Which makes you think it's working OK if it's only a few time dealing with this project.

Being able to start a QKM without any store is not a bug. stores can be created after the QKM starts and we are planning on implementing the possibility to add stores on the fly using the API (HTTP requests). This behavior is correct at the moment.


Fix: Additional permissions to deepwatch role to read from encrypted …

Updated the IAM permissions to read objects from S3 bucket.
Updated permissions to Decrypt the objects using KMS keys
Created a custom resource to scope down the KMS key permissions.

/do-e2e-tests

/do-e2e-tests


Deploy (& dispose) E2E test apps in parallel

Should help making E2E tests complete a few mins quicker by deploying (and disposing) E2E test apps in parallel. This should be especially useful in AKS (because of having to pull from a container registry through the network and because of the need to wait for a load balancer), and especially for tests like "service_invocation" that requires deploying half a dozen apps.

/ok-to-test

Looks like some things do need to be deployed in order. Closing for now - will maybe look into this again in the future


fix(docs/example/README.md): fix apply and move permissivemode

Signed-off-by: Rita Zhang<EMAIL_ADDRESS>
Description:
update kubectl create to kubectl apply
move permissive mode up as it needs to be set to false to see traffic flowing thru

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Codecov Report

Merging #2422 (da8c007) into main (49bbd47) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
- Coverage   59.66%   59.43%   -0.23%
==========================================
  Files         151      151
  Lines        6708     6708
==========================================
- Hits         4002     3987      -15
- Misses       2692     2707      +15
  Partials       14       14

Flag
Coverage Δ

unittests
59.43% <ø> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/configurator/validating_webhook.go
70.34% <0.00%> (-9.66%)
:arrow_down:

pkg/envoy/route/config.go
95.20% <0.00%> (-0.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49bbd47...da8c007. Read the comment docs.

Codecov Report

Merging #2422 (da8c007) into main (49bbd47) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
- Coverage   59.66%   59.43%   -0.23%
==========================================
  Files         151      151
  Lines        6708     6708
==========================================
- Hits         4002     3987      -15
- Misses       2692     2707      +15
  Partials       14       14

Flag
Coverage Δ

unittests
59.43% <ø> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/configurator/validating_webhook.go
70.34% <0.00%> (-9.66%)
:arrow_down:

pkg/envoy/route/config.go
95.20% <0.00%> (-0.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49bbd47...da8c007. Read the comment docs.


fix: fixes a validation issue with Markdown headings including trailing markup

Describe the pull request
This PR adds a test for having various types of markup inside a heading and validating that you can still link to those.
Why
There is a small gap between how Astro renders the id attributes of headings (slugs) and what the GitHub Slugger produces, and this gap leads to false-positives in this validation utility.
How
I decided to dig into why this happens, it seems like it's just the trailing hyphen that's the problem so I added a one line normalisation step to close the gap between Astro's heading id attribute and GitHub Slugger.
I would totally understand if you feel like this proposed fix is not the right approach and instead we should be contributing a fix to either Astro or Github Slugger to ensure this gap between slug outputs doesn't exist in the first place, rather than normalising it here. I'd just need a bit of direction on where to contribute this fix, if it shouldn't be in this project.
As for possible workarounds, there isn't one that I can think of besides patching this utility locally. I tried appending a trailing hyphen to my links that link to headings that I know have trailing markup, it will consider it valid from the perspective of this validation util but it won't work when you click this link on the actual page, because it doesn't match the rendered DOM id attribute of the heading.
Screenshots
Below screenshot shows:

a heading with a <Badge> markup
rendered id attr of the heading being "exportplatform"
validation util console output false-positive error for links that reference this heading

Thanks for your contribution :raised_hands:
First, just to double check, am I correct that the issue title is wrong and is not related to extra slash but hyphen?
I didn't get the chance yet to play with the issue but I think the issue is located in this plugin and like you mentioned when we're generating the slug based on the content. Altho, I don't think eliminating the hyphen would be the best solution but instead eliminating the source of the hyphen which I think is just the plugin not trimming trailing spaces on the content like it should.
In my head (and again, may be totally wrong as I did not test before writing yet), fileHeadings.push(slugger.slug(content.trimEnd())) should be enough to fix the issue. Would you be able to give it a try?

Ah yeah I meant hyphen and not slash oops :D
Thanks for finishing and merging the PR, much appreciated!


Ensure upgrade from pre 0.6.0 works

Version 0.6.0 introduced git submodules. Ensure this works normally when upgrading through tpm, and add check in health-check script to ensure they are set properly if user manages plugin manually.

fixed on 0.6.3


Pr checkpoint

Rearrange some things, easier debug with VSCode, tweaked models and init the migrations needed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-96.7%) to 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-96.7%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


[BUG] - Export/import ignores notes and colours

Description
After exporting as csv and then importing back, notes are missing. The exported csv file is also lacking quotes around the note text (the default text delimiter of the app).
Adding quotes manually around the notes field in the csv doesn't change the behaviour. This bug was present in the previous version too.
As of the current one, the colour attribute is also removed when exporting/importing.
Android version
Android 11
Reproduction steps
1. Go to the Export / Import menu in the settings.
2. Leave everything as is and export the file
3. Import the exact file that has just been exported
4. Notes and colours are stripped. (Overwrites the current ones if present and just lacks them otherwise)

Screenshots
No response
App debug info
App version: 1.5.1

Thanks for the report. The problem with exporting colors is known. Version 1.5.2 allows exporting them, and exporting colors will be default in 1.5.3.
I can't verify that exporting and importing notes doesn't work, although quotation marks don't seem to be set around the notes.
Could you verify that notes are really removed after reimporting notes.

Yup. I did it before submitting the report and just tried it again with more entries. Same behaviour.
I also noticed that now, when I add a new measurement with the + button, they aren't immediately displayed. I have to select "lifetime" or another valid time frame to refresh and see all the additions.

The issues about not showing the newest entries and color missing from export have been fixed.
I can't reproduce the notes issue with the default configuration, so please ensure you are using the default configuration.
Version 1.5.3 will include a button for exporting your configuration, so I can have a look at it.

I've updated to version 1.5.2 and the notes are all getting imported now, thank you. Still no quotes in the exported file, although it doesn't impact the import.
The app now crashes if I import around 170 entries though. Should I open a new bug report for this issue?

Great that the problem is resolved! I will keep the issue open as a reminder to look into the missing quotes.
Feel free to open a new issue for the crash. Please include information about your device and the configurations you used for exporting.

I've noticed it crashes only in specific circumstances. I'll refrain from opening a new issue for now if this doesn't happen for the majority of operations.

Please do tell me the circumstances. I try to avoid all crashes, even rare ones.

Alright. I commented in case you were still interested. I'll open a new issue now.


Digit Recognizer Project

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Digit Recognizer Project
:red_circle: Aim : Create a Machine Learning model which will predict the digits as per the user input.
:red_circle: Dataset : https://www.kaggle.com/c/digit-recognizer/data
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program and JWOC '22 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
What is your participant role?

[ ] SWOC 2.0 Participant.
[ ] JWOC 2022 Participant.
[ ] Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

I have registered for JGEC Winter of code, can I work on this?

I want to work on this issue under JWOC.
Name: Sriniketh J
GitHub Username: srini047

Tell me your approach for this project and also follow the guidelines in the issue, then mention all the details properly @srini047

Full Name: Sriniketh J
GitHub Profile Link : srini047
Participant ID:
Approach for this Project: Brief about MNIST Dataset and different models (one basic and one CNN based) and their accuracy and finally the best model with Conclusion.
Participant Role: JWOC

Issue assigned to you @srini047


WellFormattedCodeTests.cs:31: 60m/DEV Add recursive...

The puzzle 76-b1461939 from #76 has to be resolved:
https://github.com/DenisZhukovski/ObjectToTest/blob/dbb28fc8066fbe9979fa333b7a8b6fbfc85855ba/tests/ObjectToTest.UnitTests/WellFormattedCodeTests.cs#L31-L31
The puzzle was created by @DenisZhukovski on 22-Dec-22.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 76-b1461939 has disappeared from the source code, that's why I closed this issue.


feat: add present proof v2

This is essentially a three-way merge of
feat/ppv2
0.3.0-pre
TimoGlastra/refactor/generalize-proofs
BREAKING CHANGE: the present proof module has been extended to support both v1 and v2 of protocol. See Migrating from AFJ 0.2.x to 0.3.0 for a detailed migration instructions.

@NB-MikeRichardson it seems one test is failing, could you take a look at it?

Codecov Report

Merging #979 (566e8e8) into 0.3.0-pre (d2fe29e) will decrease coverage by 0.15%.
The diff coverage is 86.67%.

@@              Coverage Diff              @@
##           0.3.0-pre     #979      +/-   ##
=============================================
- Coverage      87.67%   87.52%   -0.16%
=============================================
  Files            574      601      +27
  Lines          13521    14544    +1023
  Branches        2190     2350     +160
=============================================
+ Hits           11855    12730     +875
- Misses          1662     1809     +147
- Partials           4        5       +1

Impacted Files
Coverage Δ

...les/credentials/formats/CredentialFormatService.ts
100.00% <ø> (ø)

...ore/src/modules/indy/services/IndyHolderService.ts
72.72% <ø> (ø)

...src/modules/indy/services/IndyRevocationService.ts
58.33% <ø> (ø)

packages/core/src/modules/proofs/ProofEvents.ts
100.00% <ø> (ø)

...odules/proofs/formats/indy/models/PredicateType.ts
100.00% <ø> (ø)

...proofs/formats/indy/models/RetrievedCredentials.ts
100.00% <ø> (ø)

...e/src/modules/proofs/models/ProofAutoAcceptType.ts
100.00% <ø> (ø)

.../modules/proofs/protocol/v1/models/PartialProof.ts
91.66% <ø> (ø)

...odules/proofs/protocol/v1/models/ProofAttribute.ts
72.72% <ø> (ø)

...odules/proofs/protocol/v1/models/RequestedProof.ts
81.81% <ø> (ø)

... and 75 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I haven't merged in https://github.com/hyperledger/aries-framework-javascript/pull/972 because that PR is not yet in 0.3.0-pre.
I am happy to merge that it in in due course: I would say let's get this stuff in first as people are waiting on it.

It would be nice if we can integrate here the changes introduced in https://github.com/hyperledger/aries-framework-javascript/pull/972 but if it's too much trouble we can merge it afterwards.

Yes I think it would be easier to merge afterwards. I'll merge this PR and we can then update with main (hasn't been done in a while).

Did someone add sonarcloud?

Merging as CI for node 14 passes (still the BBS issue)


feat: add simple version of asset input [LW-9231]

This PR adds a simple version of the AssetInput matching the existing API as closely as possible. This is required for the send flow form in Lace Beta (Midnight), as defined in https://input-output.atlassian.net/browse/LW-9231

@pczeglik-iohk @szymonmaslowski thanks for the in-depth review 🙏 all issues should be fixed in the latest commit


Add electron store to dependenciesWhitelist

For https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42416

It's now in the production branch, so Definitely Typed's CI will get the new whitelist next time it runs.


Add AWS CloudWatch logging using Watchtower

Pretty straightforward, although took a while to workout sensible log group and stream names that also worked for testing. Also logs exceptions to a special FAILED log.

Pull Request Test Coverage Report for Build 80

99 of 155 (63.87%)  changed or added relevant lines in 11 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.4%) to 77.475%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

global_settings/global_settings.py
16
17
94.12%

converters/md2html_converter.py
20
22
90.91%

converters/converter.py
13
16
81.25%

linters/linter.py
1
4
25.0%

resource_container/ResourceContainer.py
36
53
67.92%

webhook.py
1
31
3.23%

Files with Coverage Reduction
New Missed Lines
%

resource_container/ResourceContainer.py
1
79.6%

webhook.py
2
21.46%

Totals

Change from base Build 69:
-0.4%

Covered Lines:
6862

Relevant Lines:
8857

💛  - Coveralls


chore: fix github/workflows/unused.yml

See https://github.com/codeigniter4projects/website/runs/5390659728?check_suite_focus=true

[Symfony\Component\Console\Exception\RuntimeException]
The "--profile" option does not exist.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.083%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
222

Relevant Lines:
288

💛  - Coveralls

@MGatner I don't know how composer-unused works.
But I ran it locally, and also got Unused packages.
How to fix?
$ php composer-unused.phar --excludePackage=php --excludePackage=guzzlehttp/guzzle --excludePackage=http-interop/http-factory-guzzle

Results
-------

Found 1 used, 4 unused, 2 ignored and 1 zombie packages

 Used packages
 ✓ php (required by: codeigniter4/cache)

 Unused packages
 ✗ codeigniter4/cache
 ✗ codeigniter4/codeigniter4
 ✗ knplabs/github-api
 ✗ league/commonmark

 Ignored packages
 ○ guzzlehttp/guzzle (ignored by NamedFilter(userProvided: true, string: guzzlehttp/guzzle))
 ○ http-interop/http-factory-guzzle (ignored by NamedFilter(userProvided: true, string: http-interop/http-factory-guzzle))

 Zombies exclusions (did not match any package)
 💀 NamedFilter(userProvided: true, string: php)

It's gone through some major changes, including some feature requests of mine. You could try using the Config template from DevKit and see if that resolves some of these. For now though it might be easier to pull the Action YAML until this tool has settled.

You could try using the Config template from DevKit and see if that resolves some of these.

I tried, but it does not work.

For now though it might be easier to pull the Action YAML until this tool has settled.

What do you mean? What is the Action YAML?

I got:
to pull the action yaml = to remove the action yaml.
I did so.


Middle mouse button scrolling

VSCode Version: 1.10

I searched the issues but did not find any such post, so apologies if there is an existing thread that I missed.
I'd like to know if there is any middle mouse click scrolling, planned? That is, clicking the scroll wheel to toggle drag scrolling. It's a useful feature to have when navigating very long files.
And if it isn't, is there any API that would allow this to be enabled via an extension?
Thanks

@harold-b This is an OS-level Windows feature, it should work on Windows now. Also middle click has special behavior on Linux by acting as a secondary clipboard so it definitely wouldn't work there.

it should work on Windows now
Which version is it available on? I can't seem to trigger it on 1.10 public or insiders.

@harold-b do you have the same issues in Chrome and/or Atom? I wouldn't expect us to need to do anything on our side for it to work.

I'm on Chrome right now and it's always worked. I've never used atom (other than electron via VSCode), but I'll grab it and verify.

I tried Atom. It didn't work either. I checked the settings page to check if there was an option I needed checked, and the scroll worked there. So I decided to check a markdown file in preview mode on VS Code, it works there too. But not in text documents.

@harold-b k, I'll relabel and assign, thanks for bearing with me :smiley:

Not at all, my pleasure to help. Thanks for your attention :+1:

Hi, any news on this?
THX

Bump!
I use this feature constantly within Visual Studio, and it is greatly missed.

I keep seeing that you guys are working on something each month when there is a new version. How come you keep forgetting about this one? There has been a year already. If you say it is something OS level it means it's a bug. It doesn't matter, bug, feature, just please make it work.

@csicky there are 4000 open issues currently and there are ~2000 new ones created every month. Everything needs to be prioritized.

I understand that, but if there are 2000 new ones every month it means that in a year there were many issues prioritized before this one.

@csicky The advantage of us being Open Source is that if you'd like to have something implemented, you can do it and submit a PR. Issues and discussions are very valuable, but IMHO a PR will have a far greater impact! :heart:

@alexandrudima OK then, until I will find time to make it myself I will have to live with it every day. OS is not always an advantage. But if you say it's an advantage, why are you doing it actually? Not to share it with the users? Here is a request from some users.

@csicky I don't understand the point you're trying to make here? There are many good and bad things with OSS, but from this conversation I've gathered:
Advantages:

Ability to talk directly with developers
Access to source code
Ability to contribute
More unfiltered feedback from users

Disadvantages:

?

The fact that VS Code is OSS doesn't change the fact that we're busy and need to manage and prioritize the vast amount of incoming issues. You would probably be worse off if VS Code was closed as you wouldn't have the ability to contribute is what @alexandrudima was trying to say.

Well, if I would be a paying customer you would say that "Thank you for your feedback and we'll consider it". Instead because open source you say "If you want it that bad, go ahead and make it yourself." But this can feel good or bad depending on person.
What my problem with this is that I can be sure it will never be implemented / fixed. And since this functionality comes from the operating system, the fact that it was lost is actually a bug.
If we look at the numbers, people asked for this more than a year ago. There are also questions about this on other places on internet. In a year you received another 24000 issues all much more important than this one. Now you say that you need to prioritize but if that is the case there is a problem with how things are prioritized maybe. Couldn't this be on spot 23999 in this year and get some attention?
There is no point in arguing, I just waste time I can't afford.
Maybe I sound a bit grumpy, sorry for that.

Alright everyone, maybe I'll work on a PR for this today - depending on how similar VS Code is to Visual Studio, I may be able to use the Middle Click Scroll plugin as an example.

@ccu-michaelhatch the fix for this is likely pretty different from the VS one. I imagine a middle click event is being stopped when it should propagate up to some scrollable area.

Well either way I'm hoping I have time today/during the rest of the week to get it working - but that's a petty good lead so thanks for that. :)

I noticed that middle click scrolling is working on the release notes tab which opens after an update.

Any luck on this lately @ccu-michaelhatch?

Nope, sorry - I should have updated the group. I had sunk too much time into it without making significant progress and found a workaround that suited my needs--although I'm sure it's frustrating for everyone reading this, since that's likely what everyone else has had happen that has looked into this.

Can anyone explain why it doesn't currently work in most files? Is it a bug or by design? If anyone has any info on the issue, please put it here as it may help someone else fix the issue.

Since it comes from the operating system (or mouse driver?) and it should work by default, it must be a bug.  What is the difference between the editor and the release notes page? In release notes page middle click scrolling is working and I doubt that anyone programmed it to do.
What happens is that developers working on VS Code don't use it and didn't catch it not working as they never tried. I am just speculating here :)

When I looked into it, I found that the middle mouse button and the left mouse button were being grouped together for the file list, and I was trying to find something similar for the editor panel.

Badly missing this feature in VS Code, been using it for years in VS. Any plans to get this "working" or "implemented"?

Such features should be done on OS-level.
For Windows users: there is "Autohotkey" app, it can solve all your troubles (not only with scrolling).
Here is my version of mouse scroll in AHK:

It uses the right button, but this can be changed (see descriptions).
Works everywhere of course.

@Mikhail22 I struggle to understand why this must be done on OS-level? The middle wheel click and scroll works fine on the Release Notes page as well as plugin Details, Changelog pages from what I can see (might be more places as well).

@stefan505 because scrolling itself is kind of universal feature. I need to scroll everywhere - browsers, editors. Of course one can implement own scrolling, but since VSCode is a windowed app, it should just recieve scrolldown/up events. (AHK uses OS APIs).
Just like in Firefox - I use my AHK script and Firefox scrolls smoothly.
In this case I suggest VSCode should receive the scroll events and implement smooth scrolling.
(currently it is smooth only when using own scrolling, and yes it is not working in main editor)
By the way, how the mid-button works now - is suboptimal IMO. Compare to my scrolling method, I find it much better.

The new update uses middle mouse for box selection now, which while a nice feature I think the scrolling really needs to come back. I use this so much in Visual Studio!

I just discovered that holding Shift + scrolling the mouse wheel up and down scrolls the text editor horizontally. Tested in 1.23.0 stable release.
Wheel up scrolls left and wheel down scrolls right. Still not quite what is wanted, but close to it.

Great find @stefan505 ! This is very helpful in the meantime.

It is a common Windows document based application feature that a document's content is being scrolled when the mouse is moved while the middle mouse button is held down.
This issue is open for two years. Shouldn't this feature work by now?
I propose to add a Settings/Preferences option allowing the user to decide what happens when the mouse is moved while the middle mouse button is pressed.
(PS: Same behaviour for SQL Operations Studio, which seems to share the same code base VS Code does.)

It's 2018 now. I don't have any app that doesn't have this feature (except vscode).

No mouse button scroll, I mean where you click on small arrow at the bottom/top of scroll bar.
It's annoying on touchpad without this.

Would love to have middle mouse scroll please

pls

If issues are tackled by priority, then I'm posting here to share my support for this. Windows and Mac. 🙏
pls

Can people who have tried fixing this post their actions in this comment section plz ?
Thx

@harold-b This is an OS-level Windows feature, it should work on Windows now. Also middle click has special behavior on Linux by acting as a secondary clipboard so it definitely wouldn't work there.

@Tyriar It seems that there is a way to avoid middle-click default action. See the behavior of ScrollAnywhere It's also available for Chrome, so I guess it could be integrated. It's very effective when scrolling, giving the fact that since the editor knows the document length, it can scroll at the same speed as if the left button was drag'n'dropping the scrollbar.

I see label "feature-request" to this issue but it is actually a bug, not a feature request. I just scrolled up using middle click to read the label correctly.
Anyway, I found a solution because it was very frustrating. Using X-Mouse driver I could intercept middle-click and this program has its own middle click scroll which we can use.
https://www.highrez.co.uk/downloads/XMouseButtonControl.htm

No point in waiting another 2(two) years for this to be fixed.

Came here to bump this method, works for me!

Came here to bump this method, works for me!

I'm sorry but no - the requirement to download third-party software to obtain the desired functionality completely invalidates the suggestion that this is bug fix and not a feature request.

I see label "feature-request" to this issue but it is actually a bug, not a feature request. I just scrolled up using middle click to read the label correctly.
Anyway, I found a solution because it was very frustrating. Using X-Mouse driver I could intercept middle-click and this program has its own middle click scroll which we can use.
https://www.highrez.co.uk/downloads/XMouseButtonControl.htm

No point in waiting another 2(two) years for this to be fixed.

with this method works, but the problem cant close tab using middle click

@f7urry
I tried, and it does close the tab. However, I don't use that, I have a custom button on my mouse set  up for Ctrl+W and I use that to close tabs.
WOW, this is already 4 years old issue. Just because in the beginning somebody in VS Code team made a mistake and hijacked this mouse event. And is marked as "feature request".
About prioritization, this issue has less priority than ~75000 issues which came after it. So, if we can just all do a plus 1, thumbs up, 75000 times in this comment list, it will be fixed.

1/3 of the mouse buttons are not working properly, how can this be anything else than high priority?

Agreed this is a highly frustrating issue. VSCode should not overwrite default OS behavior without an option to re-enable it!

The Horizontal Scroll wheel also does nothing within VSCode.  I assume that these two behaviors are linked.  I tend to load up full VS instead of VSCode because a few of these daily operations tasks aren't supported gracefully.  I want to like VSCode more.

ok so i recently switchted to linux again annyone know how firefox coded what they call autoscoll ?
it allows you to scroll with middlemouse.
if firefox can implement it i'm 100% sure it can be done here 2.

Keep it up people!!! Only 74996 comments left until we reach priority :D

I am relatively new to the development myself and I like how VS code fits my learning needs. But my habit of scrolling with MMB is 20 years old now. I really would like this "new feature" to be there.

bump

I swear I've used middle click scroll in VS Code before but it hasn't been working for me for a while so maybe I'm mistaken. Bump

I came here looking for this feature. Why isn't it implemented yet? I'm suffering without middle mouse button scroll.

XMouse is OK pretty its pretty jittery and not smooth (unlike the one in VS for example). Bumping this again!

bump this is a real workflow-killer moving between 3 different programs that have this feature then to this program which doesn't. I've been using VSC for months and it still trips me up.

For those of us with repetitive strain injuries (RSI), scrolling the mouse wheel can be very painful. Middle mouse click would let me lazily move my hand to scroll, as I do in many other programs...
I understand this being low priority (as many things RSI sufferers care about often are), but this would be much appreciated...

This is not low priority microsoft are just being wining bitches about this becous they will always beleave that what they think is important is more importand and we are just<PHONE_NUMBER>9999999999999 people who think ouer problem is verry importend.
THere egos are just worth more to them then<PHONE_NUMBER>9999999999999 people.

Nobody sees this issue anymore.

Hmm ... Shall we create a new one and link to this one?

Did that just now, but it seems like middle click scrolling is something alien, or maybe too old for VS Code people. They need screen recording to understand something what comes from OS level since the beginning of time.
https://github.com/microsoft/vscode/issues/104183

104183 - 6302
97881 issues have passed since opening this one... are we getting old maybe? Do you guys remember 2016? The good old days...

Well, we'll be watching to see the outcome then.
However, we should refrain from being emotional on this.  Anyone is invited to implement middle mouse button scrolling and create a pull-request.

It looks like it's time to upvote the other issue now. 20 upvotes are required. So, please vote.

I link it here again, so people get an email notification. Please vote here https://github.com/microsoft/vscode/issues/104183
(I think voting means to click on the thumbs up icon in the first post, or maybe comment with +1, it is not very clear. I didn't see an actual "Vote" button)

We could all just decide to ditch vscode and move to an actual propper open
source text editor that isent obfuscated in such a way that only microsoft
employees can fix actual issues.
Op di 11 aug. 2020 om 12:17 schreef csicky<EMAIL_ADDRESS>
I link it here again, so people get an email notification. Please vote
here #104183 https://github.com/microsoft/vscode/issues/104183
(I think voting means to click on the thumbs up icon in the first post, or
maybe comment with +1, it is not very clear. I didn't see an actual "Vote"
button)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/6302#issuecomment-671860817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADH6HSKBOP5HT36NXF45ZDLSAELDLANCNFSM4CDSNZYA
.

Why are you guys so salty? It's cringe af being in this thread with you.

Why are you guys so salty? It's cringe af being in this thread with you.

They make a bug, 4 years ago people report it, then vs code people say it is a feature request, and on top of that not fixing it. When asked what takes so long they say we can fix it ourselves if we want it so much. Also on the other issue opened, they still keep the feature request label when obviously they hijacked the mouse event.

Right, and when they say it's going to be addressed, finally, why cry about it... Seems unproductive.

Because not having the thing do what it should do is scandalous in 2020.
This is not 1980 you didn't get at least get some outcry if you trow
established standards out the window for literally 0 reasons.
And the problem with fixing it ourselves is they wrote the code so
obfuscated, and we still need to be roped in to their ecosystem to even be
able to fix it.
And if we fix it they wouldn't push it to mainbransh because of the
saltmountains on the rimpled dollarbilfaces.
There are definatly some good employees at Microsoft who do their best to
fix the issues we make.
And its like that intentionally for obfuscation reasons which is
understandable but really they have 80% of the market so they should just
make everyones lives eazyer its not like normies are going to start using
linux and if they stop making evrything their own ecosystem and just use
the best shit then the costumer exp whould increas 30fold.
TLDR microsoft should take a look at how suckles writes their code and not
assume they will lose marketshare if people can just read their code
without 40 degrees in microsoft ecosstem.
Op ma 17 aug. 2020 om 20:37 schreef trbot86<EMAIL_ADDRESS>
Right, and when they say it's going to be addressed, finally, why cry
about it... Seems unproductive.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/6302#issuecomment-675044207,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADH6HSMH43AC7EBRVARNNOLSBF2ILANCNFSM4CDSNZYA
.

Someone at work stole my mouse, and replaced it with one where the scroll doesn't work, wheel click does work. I just came across this 4 year old issue now. I guess I gotta click the sidebar scroller to get any scrolling done.

I would love to see this fixed or be directed to a workaround so we can fix it ourselves. I use middle-click for scrolling in everything but VS Code is the only program this fails to function.

While we're waiting, here's an autohotkey workaround
https://github.com/qooqu/vs-code-mbutton-scroll-ahk

For the record here is how it is fixed in Atom.
https://github.com/UziTech/atom-scroll-editor-on-middle-click

Yeah definitely atom is now a better choice. BYE BYE VSCode :(

5 years.  5 years waiting for basic functionality.  If there's a reason that MS wants to keep the current middle click behavior or if people are using it for something, then make it an option in settings to change the behavior.  Can't understand why a MS product uses a completely different behavior from all other MS products.

Highly-desired long-standing low-hanging fruit.

No matter how many people upvote or comment, this will never be fixed. This issue here is still open only for the reason to not have another one opened by people.
I can recommend X Mouse Button Control to take control over stubborn apps.

I can recommend X Mouse Button Control to take control over stubborn apps.

Thanks for the X Mouse Button Control recommendation, @csicky.
This is great, especially after enabling the "sticky" scroll option so it acts close to default browser scrolling:

Autohotkey Script

Is this still not done? I'm on Ubuntu and this would be helpful and very much a low-hanging fruit...

What is cool is that now the issue count is at 181825 and this is 6302, in time, as the count only goes up to millions, and this will never be closed or completed, this will be a Guinness Book record worthy issue here, the issue with the smallest number still open 😄

It's niche, but my Nickel allergy makes it annoying to use the scroll wheel on my mouse (G502), which is made of Nickel metal. Less an issue nowadays that I have callouses on them, but it used to even make my fingers bleed sometimes. So instead I bind the thumb-button to middle-mouse-button for scrolling most of the time. Doesn't work in VS Code, though, hence why I've been subscribed to this issue for years.

@novacrazy one solution I can think of is to not use a mouse with a nickel wheel.

@novacrazy one solution I can think of is to not use a mouse with a nickel wheel.

On Linux, you can enable this functionality system-wide with:
xinput set-prop 15 'libinput Scroll Method Enabled' 0, 0, 1
xinput set-prop 15 "libinput Button Scrolling Button" 2
xinput set-prop 15 "libinput Button Scrolling Button Lock Enabled" 1
xinput set-prop 15 "libinput Natural Scrolling Enabled" 1

replace 15 with the value obtain from xinput --list --short
man libinput for more settings

Seriously, this just seems like one manager dev has mommy issues.

Would love to see this addressed. Still holding out after 7 years

I use this feature all the time within Visual Studio, and it's greatly missed.

Hey, don't be snarky.  Instead of not fixing this, the staff might not fix it AND unsubscribe from this thread.  THEN what will we do?

Opened in 2016...
let's wait till 2026!
😂
What is snarky...

@ChaosOrdeal
Very weird that you would think Linux users wouldn’t like middle mouse scroll
@alsoLut
xinput set-prop 15 'libinput Scroll Method Enabled' 0, 0, 1
xinput set-prop 15 "libinput Button Scrolling Button" 2
xinput set-prop 15 "libinput Button Scrolling Button Lock Enabled" 1
xinput set-prop 15 "libinput Natural Scrolling Enabled" 1
property 'libinput Scroll Method Enabled' doesn't exist, you need to specify its type and format
property 'libinput Button Scrolling Button' doesn't exist, you need to specify its type and format
property 'libinput Button Scrolling Button Lock Enabled' doesn't exist, you need to specify its type and format
property 'libinput Natural Scrolling Enabled' doesn't exist, you need to specify its type and format

Middle click scroll when? 7 years guys..

Middle click scroll when? 7 years guys..

Waiting for the 10 years anniversary or even better, never

2024, still waiting...

2024, still waiting...

Ah, shame.  I would really, really, really need autoscrolling to be able to navigate my code while the next mouse is shipping.
Can we tag this as https://github.com/microsoft/vscode/labels/accessibility?

I need this...

https://github.com/microsoft/vscode/issues?page=2&q=is%3Aopen+sort%3Acreated-asc
this is at number 50 of never to be completed issues

+1
i use it in browsers all the time so to not have it is incredibly weird

Can we tag this as  accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues ?

+1

Yes, tag them
El El vie, 21 jun 2024 a la(s) 9:51 p. m., aloguzzo <
@.***> escribió:

Can we tag this as accessibility
https://github.com/microsoft/vscode/labels/accessibility Keyboard,
mouse, ARIA, vision, screen readers (non-specific) issues ?
+1
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/6302#issuecomment-2183622980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUQ3NFLOWAPQ5F2QCKWZAI3ZITDCBAVCNFSM4CDSNZYKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJYGM3DEMRZHAYA
.
You are receiving this because you commented.Message ID:
@.***>

+1

Ah, shame.  I would really, really, really need autoscrolling to be able to navigate my code while the next mouse is shipping.
Can we tag this as  accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues ?

I woudl like to boost this.

How tf are people horizontal scrolling? Is everyone actually moving their mouse all the way to the tiny scrollbar at the bottom of the screen and dragging it left to right like it's 1990?

Mainly Shift + Scroll ?
Also but depending on the mouse model:

Mouse wheel side clicks
Extra horizontal mouse wheel

How tf are people horizontal scrolling? Is everyone actually moving their mouse all the way to the tiny scrollbar at the bottom of the screen and dragging it left to right like it's 1990?

Another workaround: use ALT-z to temporarily enable word wrapping.

I see label "feature-request" to this issue but it is actually a bug, not a feature request. I just scrolled up using middle click to read the label correctly.
Anyway, I found a solution because it was very frustrating. Using X-Mouse driver I could intercept middle-click and this program has its own middle click scroll which we can use.
https://www.highrez.co.uk/downloads/XMouseButtonControl.htm

No point in waiting another 2(two) years for this to be fixed.

Oh I said another two years... in 2018 :D
This is the best GitHub issue ever, would be a shame to close it now, let's wait for 2026!!!
In 2026 if all goes well we can submit this here
As for the workaround, it does work, the scroll cursor is not the prettiest, but it's ok

https://github.com/microsoft/vscode/issues?page=2&q=is%3Aopen+sort%3Acreated-asc
this is at number 50 of never to be completed issues

Now at number 24! We can win this!

I use it in browsers all the time so to not have it is incredibly weird

Particularly since Firefox supports it on Linux. So much for "This is an OS-level Windows feature" and "middle click has special behaviour on Linux so it definitely wouldn't work there".
:/

I'm not sure if this is the right direction but I have got a working prototype at https://github.com/UziTech/vscode/tree/middle-scroll/src/vs/editor/contrib/middleScroll/browser
The logic is pulled from https://github.com/UziTech/atom-scroll-editor-on-middle-click updated with vscode APIs

I'm not sure if this is the right direction but I have got a working prototype at https://github.com/UziTech/vscode/tree/middle-scroll/src/vs/editor/contrib/middleScroll/browser
The logic is pulled from https://github.com/UziTech/atom-scroll-editor-on-middle-click updated with vscode APIs

Man, can you make it as extension, please?

Man, can you make it as extension, please?

I don't believe this can be an extension since the extension APIs are so limited.

This is the kind of thing you interview for working at microsoft, then join the VS team, fix, ensure your PR gets merged and then quit.

I see label "feature-request" to this issue but it is actually a bug, not a feature request. I just scrolled up using middle click to read the label correctly.
Anyway, I found a solution because it was very frustrating. Using X-Mouse driver I could intercept middle-click and this program has its own middle click scroll which we can use.
https://www.highrez.co.uk/downloads/XMouseButtonControl.htm

No point in waiting another 2(two) years for this to be fixed.

Oh I said another two years... in 2018 :D This is the best GitHub issue ever, would be a shame to close it now, let's wait for 2026!!! In 2026 if all goes well we can submit this here
As for the workaround, it does work, the scroll cursor is not the prettiest, but it's ok

Omg thank you so much! I had no idea  X-Mouse had that feature. Works perfectly.


ScrollContainer assigned incorrect width to floatThead-container

Follow the documentation to create an overflow scrolling table and set a fixed width to the table wrapper.

Google Chrome Version 57.0.2987.110 (64-bit)
Ubuntu 16.x
jQuery 3.2.1
floatThead latest via Bower

https://jsfiddle.net/8wo3bprh/1/
Table header is get cropped due to the inaccurate width and overflow:hidden.

This plugin generates additional markup. You need to be more specific.
https://jsfiddle.net/8wo3bprh/3/

It kind wired that I cannot reproduce the issue on a Mac with the same version of Google Chrome.
By the way, the previous sample is working fine on Ubuntu Firefox.

sorry, I will be of no help here. I don't have an ubuntu box I can test on.

Thanks, I will update you if I fond the issue on Ubuntu (Window seems have the similar issue two).

:+1:  also happening in IE11 under windows 7.

can i have a jsfiddle with ie11 issue?
i offered a solution to the original issue, so yours is new maybe?

I'll see if I can get a fiddle going today.
On Fri., 9 Jun. 2017 at 7:41 am, Misha Koryak<EMAIL_ADDRESS>wrote:

can i have a jsfiddle with ie11 issue?
i offered a solution to the original issue, so yours is new maybe?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mkoryak/floatThead/issues/363#issuecomment-307241558,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC5GvkREjeqP6YDkkqOExVQ5efVbLDkdks5sCHF8gaJpZM4MmYcg
.

I have exactly the same issue. Anyone resolved this yet?

Can you provide a fiddle. I am waiting on one. Try the latest 1.x.x version, it might be not there

Also not having a windows box really makes this one difficult for me to fix at the moment. I'll get a VM after a new fiddle

The fiddle posted in the OP is applicable for me too. I have a very basic table, but the floated  part is missing about 18 pixels in width, causing the same 'gap' to show up as posted in the OP. Using Windows and Chrome (59.0.3071.115); and floatThead 2.0.3.

ok, does the fix i posted for his fiddle help you?
https://jsfiddle.net/8wo3bprh/3/
thats the problem I have with his fiddle, he had an error in it probably unrelated to this bug, but it makes it a bad example for me to work from

Both fiddles have the issue for me. My setup is exactly the same (table with a wrapper with a fixed width and height).

I think i am getting to the bottom of this issue. does the following fiddle correct it for you on your IE ?
https://jsfiddle.net/8wo3bprh/14/

it appears that the issue stems from a change in some version of chrome where they changed how scrollbars  affect the dimensions of the container where they appear.

Workaround works on this end, verified in latest Chrome and Edge / IE versions.
Awesome. ;) Keep up the good work!

I had this same issue except I used another plugin for scroll bars found here:
http://manos.malihu.gr/jquery-custom-content-scroller/
My fix
To fix this issue, I assigned another class that extended the width after the initialization.
https://gist.github.com/MaLeVoLenT1/a4c8d2b6336c183b00563c2494a64532

The reason I am not fixing this right now is that the issue is that browsers started to "use" zero width scrollbars at some point, while reporting ~15px width using the detection method that I use.
This is weird and I would like to first figure out when this behavior got introduced, and which browsers are affected.

I looked into this a bit today. It turns out the culprit is jquery. The width() method does not include the scrollbar width in 3.2.0 onward. The fix will have to be a jquery version check. yey


Need to know more about crash Logs

How it works actually ? did it caught Crash Automatically and save in file .. or do i have to write something else to save in file whenever the crash occurred. A bit more help would be very greatful ..

It's not a crash reporting tool, it's a logging tool.  You can hook it to your crash reporting tool if you'd like, which is what the Crashlytics destination is for.  The common usage section in the readme gives a decent explanation.  You use it like you'd use NSLog.  You can set a destination to go to a file if you like.  The files also have documentation inline, so check that out.


New support for the key query parameter when executing a view

Add support for the key query parameter when executing a view.

The ExecuteView action should probably use an HTTP POST request (instead of GET) if the application specifies one or more keys.


docs:added overview hook

Description
added overview hook
issue: https://github.ibm.com/GoldenEye/issues/issues/6088

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

@Khuzaima05 Did you forget to commit the readme updates?

@Khuzaima05

This work has been completed elsewhere. The only change remaining is to detect secrets, so I am closing this request.


[Bug]: Dropdown input styling and focus issues

Describe the bug
Icon
Icon should flip when dropdown is open and closed.

when dropdown menu open: arrow up
when dropdown menu closed: arrow down

Additional context
Talk to @twjeffery for more detail and discussion if needed.

@vanessatran-ddi & @chrisolsen will this be fixed as part of the work to combine the combobox and dropdown?

@vanessatran-ddi & @chrisolsen will this be fixed as part of the work to combine the combobox and dropdown?

@Spark450 Yes correct.

@vanessatran-ddi Would it make sense to link this issue to this PR https://github.com/GovAlta/ui-components/pull/1309
so it can close both issues?

@vanessatran-ddi Would it make sense to link this issue to this PR #1309
so it can close both issues?

Yes I think it's a good idea.


[Feature] Conservative Q-Learning

Hello,
I have seen many versions of Q-learning implemented in Pearl, but I would like to add the conservative Q-learning algorithm which is quite a milestone.
https://arxiv.org/abs/2006.04779

Hi @cvnad1,
Conservative learning is already available as an option in the Deep Q-learning policy learner (in fact, it's an option of its parent class, DeepTDLearning).
Hope that helps.


feat(dev): add vanillaExtract option for opt-out

Closes #6314.
This allows consumers to explicitly opt-out of Vanilla Extract support, even if the @vanilla-extract/css package is requirable. This is important in cases where node_modules has been flattened and consumers inadvertently still have access to this package (since Remix depends on @vanilla-extract/integration, which depends on @vanilla-extract/css).

I've opened a PR with a better approach for Vanilla Extract detection which avoids false positives (https://github.com/remix-run/remix/pull/6401), so this PR is no longer required to fix the linked issue.


dynamic/shortest 500

request
https://scigraph-data.monarchinitiative.org/scigraph/dynamic/shortest?start_id=HP%3A0011014&end_id=HP%3A0000118&max_depth=1
response
{
"code": 500,
"message": "There was an error processing your request. It has been logged (ID e97fa0aef407dbfa)."
}

Duplicate here: https://github.com/SciGraph/SciGraph/issues/242 - this was first but closing since the other has more information.


also have the problem,when use polygon component, holes can not  show when debugging off

Summary
same as https://github.com/react-native-maps/react-native-maps/issues/2845
"react": "16.13.1",
"react-native": "0.63.2",
"react-native-maps": "0.31.1",
Reproducible sample code
import React, {useMemo} from 'react';
import {inject} from 'mobx-react/native';
import {Polygon} from 'react-native-maps';

export const PolygonsView = inject(store => ({
  data: store.panel.home.type5Array,
  zones: store.panel.home.zones,
  isHide: store.panel.home.disabled,
  areaList: store.panel.areaList,
}))(
  ({
    data = [],
    zones = [],
    isHide = false,
    areaList = [],
    onPolygonClicked = () => {},
  }) => {
    const tmpPolygonEles = useMemo(() => {
      const result = data.map((polygon, index) => {
        console.log('polygon.id----', polygon.id);
        const {areatype = 1} = polygon;
        let lineColor = '#fffff';
        let fillColor = '#fffff';
        console.log('areatype---', areatype);
        switch (areatype) {
          case 1:
            lineColor = '#53A0F4';
            fillColor = '#53A0F475'; // 0.46
            break;
          case 2:
            lineColor = '#35D69C';
            fillColor = '#35D69C75';
            break;
          case 3:
            lineColor = '#35D69C';
            fillColor = '#35D69C75';
            break;
        }
        const coordinates = [...polygon.coordinates];
        if (coordinates.length === 0) {
          return null;
        }
        const holes = JSON.parse(JSON.stringify(polygon.holes));
        return (
          <Polygon
            // shouldRasterizeIOS
            tappable
            onPress={() => {
            }}
            // zIndex={99}  // cannot open
            key={polygon.id}
            coordinates={coordinates}
            holes={holes}
            strokeColor={lineColor}
            fillColor={fillColor}
            strokeWidth={1}
          />
        );
      });
      return result;
    }, [data, zones]);
    if (tmpPolygonEles?.length === 0 || isHide) {
      return null;
    }
    return tmpPolygonEles;
  },
);

Steps to reproduce
when debugging on,holes show ok,when after build bundle in app, the holes can not show
Expected result
when after build bundle in app, the holes can show correct
Actual result

holes show
holes can not show
React Native Maps Version
0.31.1
What platforms are you seeing the problem on?
iOS (Apple Maps)
React Native Version
0.63.2
What version of Expo are you using?
Not using Expo
Device(s)
12 promax
Additional information
none

when debug is set off,the proper fillColor is not avaliable,when remove the fillColor proper,holes appears,but it is not my wanted result, i want set color as well

i have update to latest version 1.7.1，here is sample code，it is funny
return (
<Polygon
// shouldRasterizeIOS  // Cannot open, otherwise holes will not be displayed
// onPress={() => {}}  Cannot open, otherwise holes will not be displayed
// zIndex={99}  // Cannot open, otherwise holes will not be displayed, regardless of debug on/off. What should I do if I encounter a layer error?
key={polygon.id}
coordinates={coordinates}
holes={holes} // 区域地图？
strokeColor={lineColor}
fillColor={fillColor} // 打开会不显示holes，debug off情况下
strokeWidth={1}
/>
);
when remove onPress property in Polygon component, holes can show，but onPress action is not working，but i want the onPres action
Both the zIndex property and onPress property cannot be set, otherwise holes will not be displayed

@leeeGreat I have the exact same issue.

I have a MapPolygon with an other single polygon as a hole.
Adding onPress prop to the MapPolygon hides the hole, only on iOS

I have no idea how to fix this, for now I removed the onPress as it's not critical for my feature


Ansible looks in the wrong place for python

Setup
I'm using this tool with GCP & AWS sentries and a Packet validator.
Issue
When the executing the Ansible playbook, the GCP & AWS instances throw "/bin/sh: 1: /usr/bin/python: not found" because Python's binary is located at /usr/bin/python3.
Temporary Solution
I manually SSHed into the servers and moved the binary location.
Permanent Solution
Ansible needs to confirm location of python before executing /usr/bin/python. I will try to make a pull request with this fix over the next few days.

Thanks for reporting!
Looks like you are using just the playbooks on a host created by you, if you use the scripts in this repo the hosts created by terraform don't have the problem you describe.
Take a look at https://docs.ansible.com/ansible/latest/reference_appendices/interpreter_discovery.html for running ansible on a host that doesn't have the python interpreter on the common locations, closing this issue now.

Thanks for the quick responses, Federico!
I am using the repo's scripts (i.e., yarn sync -c config/main.json and yarn clean -c config/main.json), not just the playbooks. There are also a few other small manual changes that I had to make in order to get the script to work as desired.
I will look deeper into these problems tomorrow to make sure that they're not configuration mistakes on my end. I will report back soon either way.

Interesting, the terraform modules in this repo by default create hosts based on ubuntu 18.04, whuch ships a python interpreter in the proper location. You can check the integration test results in the CI build to see how ansible works on this kind of hosts.
Please let us know if you find the cause of your issue, thx!

The issues were indeed configuration problems. Here they are (with solutions) for posterity:

The servers were "unreachable" depending on where I put my ssh key.
Cause:
I wasn't adding the keys via ssh-add.
Solution:
I added the keys via ssh-add after creating them with ssh-keygen.
Ansible was looking in the wrong place for python
Cause:
I had an old version of Ansible (Thanks for the interpreter_discovery link! I immediately realized my mistake when reading through it!)
Solution:
I installed Ansible through pip rather than through apt.

Great job on the package! It definitely saved me a lot of time! I think it would be nice if the README was a bit more expansive, though. I wrote an extremely verbose walkthrough for myself, but I think it may be too much for this repo's README. Instead, I'll make a pull request with a just few small additions to the README sometime over the next few days.

:100: thanks a lot!


Add deepChildren to commons-chunk-plugin.md

updated documentation for this pull request: https://github.com/webpack/webpack/pull/5764

@ljcrapo thanks for updating the docs in accordance with the PR. Please ping me when the main PR is merged and a new release is cut so we can get this merged (if I merge now it'll appear in the docs before it is available in the actual tool).

@skipjack the PR has been merged.


Upgrade result-like

Oh, great, miri's enforcing strict provenance now. I'll look into that, mayyybe actually I might not have the time but I'll try

Ah shoot AtomicCell is unsound under strict provenance


Implement custom sort caret

Hi @AllenFang ,
I was wondering if there's any progress for the sort caret?
It says in the documentation that it's coming soon, and since the issue #177 was opened and "closed", was wondering if there are any progress to this.
Let me know if there are any alternatives to customizing the caret
Thanks and keep on improving this!

@sinisbad123 hello, sorry for lately feature support, I will implement it ASAP. I can not tell you the when I can finish, because there're huge task I have to do for this project by myself. thanks

Anyway, before Nov, I will implement it.

RELEASE NOTE
Please upgrade to<EMAIL_ADDRESS>ONLINE DEMO
DOCS

Thank you so much @AllenFang ! More power!

👍

@AllenFang Per https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/177#issuecomment-427662857
Your Storybook demo does not include the actual caret icons/glyphs:
sortCaret: (order, column) => {
    if (!order) return (  Desc/Asc);
    else if (order === 'asc') return (  Desc/Asc);
    else if (order === 'desc') return (  Desc/Asc);
    return null;
  }

So I went in and added them to my local test. And oddly enough, the "caret" CSS seems to be missing when I add in the relevant ... for the carets:
    sortCaret: (order, column) => {
      if (!order) return ();
      else if (order === 'asc') return ();
      else if (order === 'desc') return ();
      return null;
    }

E.g. the CSS we want that is missing:
/* Missing from Boostrap CSS */
.caret {
  display:inline-block;
  width:0;
  height:0;
  margin-left:2px;
  vertical-align:middle;
  border-top:4px dashed;
  border-top:4px solid\9;
  border-right:4px solid transparent;
  border-left:4px solid transparent
 }
 .dropdown,
 .dropup {
  position:relative
 }
 .dropup .caret,
.navbar-fixed-bottom .dropdown .caret {
 content:"";
 border-top:0;
 border-bottom:4px dashed;
 border-bottom:4px solid\9
}

Here are my includes:
import 'bootstrap/dist/css/bootstrap.min.css';
import BootstrapTable from 'react-bootstrap-table-next';

This is my version:
"react-bootstrap-table-next": "^3.3.3",

And I have bootstrap4 enabled on my <BootstrapTable />
Any thoughts if I'm doing this wrong, or if indeed the 'bootstrap.min.css` is missing the relevant caret CSS?
P.S. Thanks for everything @AllenFang !

@hdehal
OMG....yours is the ONLY solution in the WHOLE internet that worked for me for sort caret!!! (after 2 days of trying everything else I finally found this post)
You saved me!
May your code always work in 1st go your entire life!

Thanks for Solution

Thank you it worked for me. @hdehal


glyphicon for feedback

The current glyphicon for feedback uses bootstrap "comment", which is being used by many websites to link to "chat" or "message" section/feature. This is somehow misleading. I'd suggest for feedback we should use bullhorn instead.

I believe this is a duplicate of https://github.com/gbif/portal16/issues/262. Please add your comments there :)


Support for CC and BCC in emails

would be great if CC and BCC is supported as well.

@danths  done! check my PR.


Ensure design docs are uploaded individually when replicating with bulk_get

Previously, when replication jobs used _bulk_get they didn't upload design docs individually like they do when not using _bulk_get.
Here were are preserving an already existing behavior which we had in the replicator without _bulk_get usage for more than 2 years. It was introduced here in https://github.com/apache/couchdb/pull/2426. Related to these issues https://github.com/apache/couchdb/issues/2415 and https://github.com/apache/couchdb/issues/2413.
Add tests to cover both attachments and ddoc cases. meck:num_calls/3 is helpful as it allows to nicely assert which API function was called and how many times.

why?

@rnewson good question, I should have explain that a bit better in the commit.
That is to preserve an already existing behavior which we had in the replicator without _bulk_get usage for more than 2 years. It was introduced here: https://github.com/apache/couchdb/pull/2426 related to these issues https://github.com/apache/couchdb/issues/2415 and https://github.com/apache/couchdb/issues/2413

Updated with the minor optimization and added references in the commit message and PR comment to the previous PR which introduced this behavior and the related issue.

@nickva thanks for the links. It still seems to be a (perhaps necessary) hack around a problem elsewhere. We should do The Right Thing for any _bulk_doc write that writes multiple design documents. It is not right imo to just teach our replicator to avoid triggering those bugs, no other client will be similarly protected.

@rnewson with the replicator we are trying to be compatible even with old, or possibly broken clients, clients. But most of all, in this PR, we are trying to bring back the previous behavior before the recent _bulk_get optimization. Currently, it's odd that the there is a difference based on whether [replicator] use_bulk_get is toggled or not.


why I only change the weight of the attacked model, the examples are not adversarial any more.

Hi, when I trained the default model for the first time and based on these weights I can generate adversarial examples with 100% attack success rate. But I trained the same model one more time and save the weights, try to attack this second model by the examples I generated based on the first one, it dose not work, the test accuracy is over 65%. Dose it make sense? I thought the adversarial examples should have transferability within the same model but different weights.
Thank you for your time!!

It does have transferability -- it worked 45% of the time here. See Figure 9 of the paper for some comparison of confidence vs. transferability.

So when I try to explore the defense method, setting higher confidence such as 1 is the best choice?

Yes. See also other papers on improving transferability, e.g., https://arxiv.org/abs/1611.02770.


Update go-md2man

Update fixes some rendering issues, including improperly escaping '$' in
blocks, and actual parsing of blockcode.
Example from: docs/man/docker-attach.1.md
ID=$(sudo docker run -d fedora /usr/bin/top -b) was being converted to
ID=do docker run -d fedora/usr/bin/top -b)

lolz LGTM

Nice!  LGTM

LGTM


⚠ GitLab Server has degraded performance

In 2dafc39, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6477 ms

Resolved: GitLab Server performance has improved in 0838062.


Better support for rollbacks

Hi,
I'm looking for a new deployment tool and deployer looks awesome - thanks for the great work you have done!
I have some concerns about rollbacks.
Sample scenario:
The deployment process consists of several steps:

prepare
release
update code
assets
database migrations
restart cache

Now lets assume the last step 'restart cache' fails. Currently deployer would only remove the release directory but it should also revert the db migrations.
We could probably add a very simple mechanism to improve rollbacks, similar to the one in Capistrano.
There is a simple function that allows to add rollback closures. Then the rollback command executes all registered closures [LIFO].
What do you thin about it? Maybe you have some better ideas how to improve rollbacks?

Hi,
I'm planning to create functionality like this in Deployer v4. It will be using event system.
But now i haven't mach time to work on Deployer v4.


very good

this paper is very good .Excuse me, can you publish the heat map, F1, testing and fine-tuning code on small data sets in the paper?

We used the sklearn package for measurement. More details can be found in #2. The test code is released. You can customize it for your need.


Video automatically going to native fullscreen on "first play" in iOS

Is there any way to prevent the default behaviour in iOS of going to native fullscreen when the video is first started? Note that once native fullscreen is exited and the video is then resumed, it then plays inline and allows going to the "fake fullscreen" mode using the fullscreen button in the player controls. In this case "fake fullscreen" is the desired functionality, as "fake fullscreen" supports subtitles, plugins, etc.
As described in #2302, I did add the useFakeFullscreen: true flag but this does not seem to help.
NB: this is using a YouTube video

Just use playsinline and webkit-playsinline attributes in the video tag; that should help. Also, if you are using YouTube, I'd suggest to use the configuration element youtube: {playsinline: 1} in the player config:
new MediaElementPlayer('player-id', {
       youtube: {
            playsinline: 1
       },
       // Other configuration
})

Please star the project to support it. Thanks

Thank you so much!
youtube: {
    playsinline: 1
},

Did the trick like you said. Have it starred already! I'll see if I can recommend the project elsewhere as well. Thank you for the great work maintaining this so actively.

You are welcome. Unfortunately I'm not maintaining it anymore I'm just wrapping things up for the big upgrade in WordPress. I accept PRs and check periodically issues


[Image] Remove unused backgroundColor and tintColor params from downloader

The outer UIImageView now takes care of backgroundColor and tintColor so the image downloader no longer needs to paint them manually. Remove these unused params that were only nil.
Test Plan: View the Images demo in the UIExplorer and verify that tint colors and background colors are honored.

I've already made this change. Not sure why it hasn't landed in github yet, but it will be in the next update.

👍🏻


docs: updated the values of the system requirements

In #1553, the system requirements were bumped, updated the docs to reflect this.

Good catch!


[elasticsearch] #1495 Configure JVM options files

[X] Chart version not bumped (the versions are all bumped and released at the same time)
[ ] README.md updated with any new values or changes
[X] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

need a big review!

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

I actually wonder if the chart can go further, and instead of you having to decide whether the options go into the env var or a file, you just declare the options you want, and the chart takes care of it. For example:
esJVMOptions:
    - "-XX:ActiveProcessorCount=3"
    - "-XshowSettings"

But if we're adding support for deploying a specific file, I don't think we should necessarily remove esJavaOpts since we're not removing it from ES itself.

Thanks, @pugnascotia.

I actually wonder if the chart can go further, and instead of you having to decide whether the options go into the env var or a file, you just declare the options you want, and the chart takes care of it. For example:
esJVMOptions:
    - "-XX:ActiveProcessorCount=3"
    - "-XshowSettings"

Well, we could eventually use this syntax and add every item in esJVMOptions to some hardcoded file in jvm.options.d, however, we can't add logic in Helm to parse the list and decide for every item whether it should go to env var or a file.
In addition, the esJVMOptions syntax here is a standard syntax in Helm and K8S world and is already used for defining the other config files in these Helm charts.

But if we're adding support for deploying a specific file, I don't think we should necessarily remove esJavaOpts since we're not removing it from ES itself.

OK 👍🏻

jenkins test this please

Also NIT but maybe renaming esJVMOptions to esJvmOptions for camel case

jenkins test this please

CI tests will fail because of https://github.com/elastic/helm-charts/issues/1443 but manual test is OK


React Aria Components => Button triggering both a Tooltip and a Modal

Provide a general summary of the issue here
We have a button triggering both a Tooltip and a Modal. When the modal has a position fixed or absolute it's closing it automatically adding the data-exiting="true" at the same time than the data-entering="true".
If I remove the TooltipTrigger around the button, or if the Modal is in position relative, then it works.
🤔 Expected Behavior?
The Modal should remain visible if we haven't clicked on any closing button
😯 Current Behavior
The Modal is opening and closing directly.
💁 Possible Solution
My guess is there are some sort of conflict with the Tooltip and Modal portals, and the is-exiting should probably be on the tooltip and not on the modal ?
🔦 Context
No response
🖥 Steps to Reproduce
Here is our code for better understanding :
<DialogTrigger>
  <TooltipTrigger>
    <Button>Show a tooltip and open the modal</Button>
    <Tooltip>
      <OverlayArrow>
        <svg width={8} height={8}>
          <path d="M0 0,L4 4,L8 0" />
        </svg>
      </OverlayArrow>
      Click to open the modal
    </Tooltip>
  </TooltipTrigger>
  <ModalOverlay>
    <Modal>
      <Dialog>
        {({ close }) => (
          <form>
            <Heading>Sign up</Heading>
            <TextField autoFocus>
              First Name:
              <Input />
            </TextField>
            <TextField>
              Last Name:
              <Input />
            </TextField>
            <Button onPress={close}>
              Submit
            </Button>
          </form>
        )}
      </Dialog>
    </Modal>
  </ModalOverlay>
</DialogTrigger>

.react-aria-ModalOverlay {
  position: fixed;
  top: 0;
  left: 0;
  width: 100vw;
  height: var(--visual-viewport-height);
  background: rgba(0 0 0 / .5);
  display: flex;
  align-items: center;
  justify-content: center;

  &[data-entering] {
    animation: fade 200ms;
  }

  &[data-exiting] {
    animation: fade 150ms reverse ease-in;
  }
}

Version
react-aria-components => 1.0.0-beta.1
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
MacOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Hello, we've recently upgraded to React Aria Components version 1.0.0-rc.0 and have noticed that several of our modals are malfunctioning, which we believe is directly related to this issue. Setting the modal dialog's position to relative as suggested by @charl0tee does not solve the issue for us unfortunately.
@devongovett Could you provide any updates on the resolution of this issue, or suggest any temporary workarounds we might employ in the meantime? Thank you! 🙌

@clemensheithecker FYI, in our case a workaround is to change the Modal to a controlled Modal, so we don't need to import the DialogTrigger anymore (which was the one causing issues when added around a TooltipTrigger)

Assuming I've understood correctly that the Dialog is not showing up at all. This should be fixed by https://github.com/adobe/react-spectrum/pull/5526
As seen here: https://codesandbox.io/p/sandbox/stoic-perlman-dk6qlp?file=%2Fsrc%2FApp.js
I did notice the close button inside the modal isn't working. Not sure why yet, so would like to leave this Issue open for the time being.


Master branch CI failing

https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/branch-ci-openshift-tektoncd-pipeline-operator-master-images/6
could not wait for build: the build tektoncd-pipeline-operator-registry failed after 42s with reason DockerBuildFailed: Docker build strategy has failed.

Pulling image docker-registry.default.svc:5000/ci-op-g2n4t...42e18f6000d6c2c40112eae8279b6b3c8774b55130fe335c88375c5 ...
--> FROM docker-registry.default.svc:5000/ci-op-g2n4tjhb/p...2e18f6000d6c2c40112eae8279b6b3c8774b55130fe335c88375c5 as 0
--> ARG version=0.1.0
--> COPY manifests manifests
error: build error: stat /tmp/build/inputs/manifests: no such file or directory

closing as the ci has been fixed


Result of wt103_base

Hi, thank you for the open source.
After I finished running run_wt103_base.sh with 4 GPUs, my final result looked like this:
| Eval  50 at step   200000 | time: 3815.87s | valid loss  3.15 | valid ppl    23.290
--------------------------------------------------------------------------------------
--------------------------------------------------------------------------------------
End of training
============================================================================
| End of training | test loss  3.19 | test ppl    24.248
============================================================================
Evaluating with bsz 10 tgt_len 64 ext_len 0 mem_len 640 clamp_len 400
Time : 34.78s, 90.57ms/segment
============================================================================
| test loss  3.16 | test ppl    23.683
============================================================================

Would you mind tell me which test ppl is the correct one? (The one reported in your paper&github) If 24.248 is the correct test ppl, I wonder why it cannot achieve 24.03 as you said in your github (since every random seed has been fixed).
By the way, will the result be the same if I use only 2 GPUs to train wt103 base ?
Thanks a lot!

Hi. Can you tell how much time did it take to train the model on wt103 with 4 GPUs???

Hi. Can you tell how much time did it take to train the model on wt103 with 4 GPUs???

I have trained for about 2.5 days on 4 GPUs (1080 Ti).

Thank you !

A question: when I try to execute run_wt103_base.sh, I get an import error:
Traceback (most recent call last):   File "train.py", line 14, in <module>     from data_utils import get_lm_corpus   File "/home/andrealk3/ALMA_PhD/transformer-xl/pytorch/data_utils.py", line 8, in <module>     from utils.vocabulary import Vocab **ImportError: No module named utils.vocabulary**
How have you managed to avoid this import error?
(this is almost worth opening a new issue)


Create On_Passwords

It is an issue, not a PR.

Hi @szepeviktor,

Passwords connect web applications and users.

Web applications cannot identify the person as typing the user's password has nothing to do with the person.
Users (adult persons) are not able to handle (generate, store, change) passwords.

Identification != Authentication != Authorization
Identification can be done by several means such as username, user ID, email, certificate number. We know who the users claim to be, but identification is not sufficient to confirm they are telling the truth. I answers the question "Who are you?".
Authentication can also be performed by several means such as password, security card, certificate verification, biometrics... Sometimes, it can perform both identification and authentication (X509 certificates). I answers the question "Prove me who you are?"
Authorization exist to prevent access on resources. It requires the authentication of the users. It answers the question "Are you allowed to be here?"

Web applications can identify, authenticate and authorize the users. But this requires correct implementation of the concepts in particular the authentication. Now the problem is more on the user registration where man can use the identity of another one.
No one is able to manage passwords. It's like modern torture.

So password authentication is a failed technology.
Please remember that originally a soldier stood beside each computer. There was no authentication in the software.

I totally agree with that! That is why this authentication mean should be abandoned ASAP in favor of strong methods such as Webauthn.


ISSUE_TEMPLATE hints to check applied rules

To prevent further non-issues.

Hi and thanks for the improvement suggestion through this PR,
The template already states that you should run the tool with vvv, so I'm not sure if this adds a lot. I think not everybody reads the complete template and follow all the steps, so I think adding more information might not yield the result that is wanted. Like to here more opinions on this though.

provide technical details such as: ... the command used to run PHP CS Fixer (run with -vvv)

I understood the template as follows: "Provide the CS-Fixer command with -vvv so that devs can copy and use it." So asking for the command itself, not that the user runs it.
That i discovered that this command lists applied rules was a sheer coincidence, but of course my actions can be blamed of being lazy and/or minor intelligent.
I think a stronger hint to check -vvv can prevent time consuming false reports.

The template already states that you should run the tool with vvv

Where is that written clearly and unambiguously?

Any feedback on the doc's is welcome and if you feel that something is not written clearly and unambiguously than of course this is valuable feedback.
The template issue main goal is to provide as much detail so anyone can to start working on the reported issue. As such is it not intended to guide people through the working of the tool, for that we have the usage doc. Again, it is not about blaming or calling someone lazy, it just goes to show that the intended way of provide the doc and template might not be working, therefore, sure, improvements are welcome.

I believe that merging this could help in some cases, and does not harm in other. I'll merge. THanks!


feat: refactor external api providers and code warnings

Description

Remove all unnecessary @Autowired;
Create a single Provider class to put all retrieving code in there and extend new providers from it;
Create a ProviderConfig to put all api and related configurations in one place;

Fixes #316
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
These changes were tested locally with Swagger, Unit testing and Integration tests.
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Further comments

I tested all related endpoints, everything is working!

ForestClient API
Oracle API
Others endpoints


perf: offer stream_logs for TaskMetadata and handle it for Run too

please don't merge without my review 👀


Some graphs are not resizing properly

For example try this with the latest release
  "$schema": "https://vega.github.io/schema/vega/v3.0.json",
  "width": 500,
  "height": 400,
  "padding": 5,
  "autosize": "pad",
  "signals": [
    {
      "name": "count", "value": 10,
      "bind": {"input": "select", "options": [1, 5, 10, 20]}
    },
    {
      "name": "points", "value": true,
      "bind": {"input": "checkbox"}
    }
  ],

  "data": [
    {
      "name": "source",
      "url": "https://vega.github.io/vega/data/cars.json",
      "transform": [
        {
          "type": "filter",
          "expr": "datum['Horsepower'] != null && datum['Miles_per_Gallon'] != null"
        }
      ]
    },
    {
      "name": "contours",
      "source": "source",
      "transform": [
        {
          "type": "contour",
          "x": {"expr": "scale('x', datum.Horsepower)"},
          "y": {"expr": "scale('y', datum.Miles_per_Gallon)"},
          "size": [{"signal": "width"}, {"signal": "height"}],
          "count": {"signal": "count"}
        }
      ]
    }
  ],

  "scales": [
    {
      "name": "x",
      "type": "linear",
      "round": true,
      "nice": true,
      "zero": false,
      "domain": {"data": "source", "field": "Horsepower"},
      "range": "width"
    },
    {
      "name": "y",
      "type": "linear",
      "round": true,
      "nice": true,
      "zero": false,
      "domain": {"data": "source", "field": "Miles_per_Gallon"},
      "range": "height"
    },
    {
      "name": "color",
      "type": "sequential",
      "zero": true,
      "domain": {"data": "contours", "field": "value"},
      "range": "heatmap"
    }
  ],

  "axes": [
    {
      "scale": "x",
      "grid": true,
      "domain": false,
      "orient": "bottom",
      "title": "Horsepower"
    },
    {
      "scale": "y",
      "grid": true,
      "domain": false,
      "orient": "left",
      "title": "Miles_per_Gallon"
    }
  ],

  "legends": [{
    "fill": "color",
    "type": "gradient"
  }],

  "marks": [
    {
      "type": "path",
      "from": {"data": "contours"},
      "encode": {
        "enter": {
          "stroke": {"value": "#888"},
          "strokeWidth": {"value": 1},
          "fill": {"scale": "color", "field": "value"},
          "fillOpacity": {"value": 0.35}
        }
      },
      "transform": [
        { "type": "geopath", "field": "datum" }
      ]
    },
    {
      "name": "marks",
      "type": "symbol",
      "from": {"data": "source"},
      "encode": {
        "update": {
          "x": {"scale": "x", "field": "Horsepower"},
          "y": {"scale": "y", "field": "Miles_per_Gallon"},
          "size": {"value": 4},
          "fill": [
            {"test": "points", "value": "black"},
            {"value": "transparent"}
          ]
        }
      }
    }
  ],

  "config": {
    "range": {
      "heatmap": {"scheme": "greenblue"}
    }
  }
}```

I am able to expand this graph by manually editing the CSS. It is rendering correctly. Can you advice?

In particularly when I disable this CSS>flex-direction

@allnash your graph specifies hardcoded width/height/autosize  values.  Remove them, and it should autoresize properly.  See https://github.com/nyurik/kibana-vega-vis#using-vega-and-vegalite-examples

@nyurik tried that. Please check the output.

This is on Kibana 5.5 fyi

UPDATE:
I was able to solve this by doing something as silly as -
  "width": 700,
  "height": 400,
  "padding": 20,
 /// NOTE autosize if left empty fixes everything. If I use "none" that seems to break rendering height though.
  "autosize":"",

@allnash, I am still unable to reproduce. This is what I just did:

I use Kibana 5.5.2 (I could check with the other versions) as downloaded from the release site
run bin/kibana-plugin install https://github.com/nyurik/kibana-vega-vis/releases/download/v0.2.5/vega_vis-0.2.5--for-Kibana-5.5.2.zip
run bin/kibana
Used this vega code:  https://gist.github.com/nyurik/750ee6fc7eb23a1e2199fc97bde4c260

No, don't add width, height, or autosize. Vega plugin automatically sets "autosize" to "fit".  Leaving it empty is the same as not adding it at all.

Ok I will try that.


Use JSON For Manifest Build Artifacts

Currently, manifests are authored using YAML, and then that same YAML is copied into the build folder. These manifest build artifacts (ex: web3api.yaml) are then downloaded by the Web3API client, parsed, and used at run-time.
@jeffscottward has suggested we use JSON for manifest build artifact for the following reasons:

JSON is faster to parse (deserialization)
JSON is easier to implement a parser for and has more implementations in various languages

Source: https://citeseerx.ist.psu.edu/viewdoc/download?doi=<IP_ADDRESS>8.2508&rep=rep1&type=pdf
Source changes needed:

[ ] CLI build command should output JSON versions of the manifest files (non-pretty versions to minimize size) to the build folder.
[ ] Web3API Client should fetch web3api.json instead of web3api.yaml, and pase it as JSON.

Just wanted to leave this, people usually prefer yaml for config/manifest since it allows comments 🙂

Agreed @mpetrunic. The idea is that developers will author their manifests using YAML, but the build pipeline will output them as JSON to the build folder, which will then be published to decentralized storage.
We will (in the future) have "verified source code" on the Web3Hub, so if someone wanted to surface the original manifest files they can using that feature.


[webview_flutter] Unexpected render underline with TextOverflow.ellipsis on Flutter web.

Hello! I try to run flutter web on Flutter webview. I'm trying to use a Flutter web app same as codepush (React Native).
Almost everything render well, but Text widget has problem. Sometimes Text widget with TextOverflow.illipsis render with underline.
I don't know how to fix this issue :(
Steps to Reproduce

Add webview on flutter native project.
Add WebView widet with 'https://changjoo-park.github.io/social_ui/#/'
See overflowed Text widget.

Expected results:
Render Text widget on Flutter Webview.
Actual results:
Render unexpected underline on Text widget.

Logs

https://github.com/flutter/flutter/issues/86776#issue-949594064 is same.

@ChangJoo-Park  I ran the webview sample on the latest stable channel with webview_flutter: ^2.0.10 but I could not reproduce the issue. Could you please share the output of flutter doctor -v and also share what device is this issue on, And by flutter native do you mean running the flutter app as a module?

code sample
import 'dart:io';
import 'package:counter_app/webview_sample.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        title: 'Flutter Demo',
        theme: ThemeData(primarySwatch: Colors.blue),
        home: WebViewSample());
  }
}

class WebViewSample extends StatefulWidget {
  const WebViewSample({Key? key}) : super(key: key);

  @override
  _WebViewSampleState createState() => _WebViewSampleState();
}

class _WebViewSampleState extends State<WebViewSample> {
  @override
  void initState() {
    super.initState();
    // Enable hybrid composition.
    if (Platform.isAndroid) WebView.platform = SurfaceAndroidWebView();
  }

  @override
  Widget build(BuildContext context) {
    final size = MediaQuery.of(context).size;
    return Container(
        height: size.height,
        width: size.width,
        child: WebView(
          initialUrl: 'https://changjoo-park.github.io/social_ui/#/',
          javascriptMode: JavascriptMode.unrestricted,
          onWebViewCreated: (WebViewController webViewController) async {},
        ));
  }
}

Output

Android
IOS

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.4 20F71 darwin-arm, locale en-GB)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter
    • Framework revision f4abaa0735 (4 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.164

• No issues found!

Hello @maheshmnj. thank you for reply.  flutter native means typical flutter application.
My goal is render "flutter web" inside flutter application like your code sample. sometime it render well but can not always.
I saw your code sample. my code is here.
  Widget build(BuildContext context) {
    final size = MediaQuery.of(context).size;
    return Scaffold(
        body: WebView(
          initialUrl: 'https://changjoo-park.github.io/social_ui/#/',
          javascriptMode: JavascriptMode.unrestricted,
          onWebViewCreated: (WebViewController webViewController) async {},
        ));
  }

my code and your code have same issue Text widget has underline :(

@ChangJoo-Park This issue looks same as https://github.com/flutter/flutter/issues/86776, You may follow up there for further updates. I am going to close this issue as a duplicate. if you disagree feel free to comment and I will reopen it.
Thank you.


Design of native type declarations

I wonder whether most type declarations should actually be MutableIO rather than just IO. Also the types may not necessarily declared "pure" since e.g. functions that change the value of a request attribute are stateful. Even more so for the response. For the routing I don't know whether the setup can change after server start (possibly not. just checking).

Commenting inline:
Q: "I wonder whether most type declarations should actually be MutableIO rather than just IO"
A:  What are the main advantages to to this change ? It's just that I would like to understand them before doing the change.
Q: " Also the types may not necessarily declared "pure" since e.g. functions that ch..."
A: Agree.
About this last question, the idea was to wrap both the request and the response, so that the "user" is receiving an immutable data structure as the request, and the signature of a given handler would change to:
handler :: Request -> Response

This way because you're dealing with data structures, you can validate your algebra, without even the necessity of running your app. Does this make any sense to you ?
Anyway, until we get there I will get your suggestion to declare types as not pure :+1:

For Mutable and MutableIO see http://www.frege-lang.org/doc/fregedoc.html PreludeIO.
In short: it tells the compiler that values of this type may "change under your feet". Not sure if @iwechsu would agree with this abbreviation ;-)

I've started a branch (io_to_mutable_io):
So far I've changed:

SHA: 392038af90c08c923b3830d38cefed6fbddacf4a
** Response -> MutableIO Response
** Route        -> Mutable Route

SHA: c27dd63f4fd89de9029a194ade46759398c490b0
** Request -> MutableIO Request

Could you take a look and tell me if I'm in the right direction ? Thanks!

Looks good to me ;-)
Is it still practical for you?

Yes it is, I'm happy knowing that it's both practical and formally correct. Thanks for the feedback :)


Update gem dependencies

Use latest Jekyll-feed: https://github.com/jekyll/jekyll-feed
Use latest Jekyll-Seo-tag: https://github.com/jekyll/jekyll-seo-tag/blob/master/docs/usage.md

@sylhare have you thought of any new features for Type on Strap?

Yeah I have been adding / updating stuff. If there's a particular feature you are interested in having here let me know

Netlify CMS support?

You can open an issue with it, but I doubt there's anything to do on the theme side, it's more of Netlifty being compatible with Jekyll.


has_many associations show page

Hi,
I have two models User and Role. The User having has many roles, the role belongs to the user.
I want to display in user show page all the role names in one by one. But now it's coming all the roles name is the same line with a comma separator. Kindly see my below code.
config.model 'User' do
show do
include_all_fields
field :roles do
orderable true
end
end
end
Could you please help me with how to show user role name one by one.

Please use StackOverflow for the support request, thanks.