Increase the test prometheus memory request

Recent test failures in release-multi-repo-8-autopilot-rapid-latest were caused by OOMKilled failures in the prometheus container:
containerStatuses:
  - containerID: containerd://eda177e63e2c28e473c95a17287015cae17af4503ad8ad04f99a138fa14dfd6f
    image: docker.io/prom/prometheus:v2.37.6
    imageID: docker.io/prom/prometheus@sha256:92ceb93400dd4c887c76685d258bd75b9dcfe3419b71932821e9dcc70288d851
    lastState:
      terminated:
        containerID: containerd://eda177e63e2c28e473c95a17287015cae17af4503ad8ad04f99a138fa14dfd6f
        exitCode: 137
        finishedAt: "2023-05-03T18:05:49Z"
        reason: OOMKilled
        startedAt: "2023-05-03T18:05:16Z"
    name: prometheus
    ready: false
    restartCount: 7
    started: false
    state:
      waiting:
        message: back-off 5m0s restarting failed container=prometheus pod=prometheus-deployment-76f4b58fb4-k7mgj_prometheus(779e3acb-82fc-4430-9946-714aa471ba16)
        reason: CrashLoopBackOff

This commit increases the memory request from 500Mi to 1Gi.

/hold

/unhold

The limit needs bumping. Request only affects scheduling, not oomkill.

Left a comment around limit. Autopilot sets limit to be the same as request, so bumping limit won't help on Autopilot clusters.
For standard clusters, the current limit is good enough.

/lgtm
/approve
@karlkfi you'll need to remove your changes requested state. Tide doesn't play nice with that Github state https://github.com/kubernetes/test-infra/issues/27750

FWIW, you can remove my change requested by hitting the "re-request review" button top right.


feat: add MaxCompletionTokens and CompletionTokensDetails

Describe the change
add MaxCompletionTokens and CompletionTokensDetails for o1 models
Provide OpenAI documentation link
Provide a relevant API doc from https://platform.openai.com/docs/api-reference

Thank you for the PR! We've merged similar stuff in #857


Feature Request: Different log colors / add sound

Today is the first day since I installed PaissaHouse to actually get notified that a house is available, to my surprise the notification is too... well "silent" and the color is the normal color of the log, it makes it harder to find if you go to the restroom or to get water, you came back AFK in limsa or people start to shout and the notification is lost in the log, I used the ping feature and well it does look a little different bout I wouldn't say that different, purple or red letters on notification would make it easier to distinguish from the crowded words in the log. Just something to make it easier to differenciate from other log things.

In order to receive a stronger visual and/or audio cue on a notification, set the chat channel notifications are sent to to TellIncoming or an unused linkshell, and use the game's built-in chat notification settings to further customize your notifications.


Still cannot log in

I was hoping Pixiv would undo whatever change was causing it so I was just going to wait it out, but I am still having the issue from #1368 or #1352. I updated, changed my language and region to japanese, and recopied the cookie (I later realized it didn't change anyway).

same here

Same. I was thinking Nandaka might have just not been active since has been ongoing, but it looks like they've contributed to a few other repositories in the last couple of months. Maybe the fix is complicated.

well okay, nvm, seems like it just started working again.
What i just tried was once again, changing the language on pixiv to japanese, and also in PixivBrowserFactory.py on lines 351 from
https://www.pixiv.net/en to https://www.pixiv.net
and on 372 from https://www.pixiv.net/ to https://www.pixiv.net

@4n0nh4x0r Would you be willing to share your compiled files for those struggling to understand how to use Python. There's unfortunately no guide on how to do this.

@4n0nh4x0r Thanks for replying to me 🙂. I tried doing the steps above and received the following error:

This was after manually downloading module "demjson3.py" to rectify an error received that this file was missing. I am unable to proceed. I couldn't successfully find where to download the mechanize module it is looking for. 😞

@icedstick
With Python installed, open a Powershell window.
Use the following command to navigate to your PixivUtil2-master directory:
cd Z:\PixivUtil2-master
Run the following command to install all of the requirements from requirements.txt (which includes the "mechanize" module you're missing):
pip install -r  requirements.txt

@blue-popsicle Thank you, this is the furthest I've gotten so far! I now receive the following errors now that I can run "python PixivUtil2.py":

I have triple-checked that everything login details and cookie-wise is entered correctly. Any ideas on how to rectify these errors?

@icedstick that is the error i got while pixiv was set to english for me.
it worked after setting it to japanese.
yea, no clue why, but the language of the site is important, probably some api change that is only applied on a certain language...
if that doesnt work, make sure you also have the cloudflare token set in your config.

@blue-popsicle & @4n0nh4x0r THANK YOU!!! I replaced the cookie values in config.ini after placing pixiv and fanbox websites into japanese and used firefox to retrieve the cf_clearance token that doesn't appear in chrome. It is working for me now! Thank your for laying it out for a newbie like me to follow.

I don't use fanbox, and already made those changes before the update, plus confirmed that they were there after the update.
I have also set my language to japanese
the only thing that's missing is the cf_clearance but I was under the impression that was just for fanbox
I am running this with linux by python, not exe (I guess I could try wine or something...)

I found out that my problem was that I had to log out manually and log back in in japanese to refresh the cookie. I can now log in.


Another ticking entity bug

Immunity given by certain items can cause compatibility issues, In this case it was a poison immunity ring from iron's spells. When worn it causes a crash.
crash-2023-06-18_01.29.34-client.txt

I just released a new version that should fix the encountered NullPointerException. (it was the same as the other reported bug)
Thank you again for the feedback!


Wrong handling of 'undocumented' attributes with jsdoc 3.6.x

As noticed by jsdoc#1672, jsdoc 3.6.x output differs from 3.5.x, especially on undocumented attributes strangely set to true while the comment attribute is correctly set with some user comment.
The effect for tsd-jsdoc is that such doclets are not managed anymore.
 I really wish they had done a major release.
I think in this lib we need to update to work with 3.6, and change how we determine exports (a la #100), then do a major release on our side.

I've just committed a sample of code to fix this problem.
See changes on publish.ts in PR#98.


Under the same validation set, the evaluation results of the EMA model after loading are inconsistent with those during training.

Hello, I use EVA-02/asuka/run_class_finetuning.py to fine-tune an image recognition task. After training the model, I evaluated it by loading the trained model. When loading the mp_rank_00_model_states.pt under the checkpoint-best, the results on the validation set (the validation set is the same as the validation set during training) are The evaluation results during training are the same. However, when I load the model under the checkpoint-best-ema, the accuracy obtained is much smaller than the evaluation results during training  using EMA. What is the problem?

The problem has been resolved.


Made minor change to missing arg in Tensorboard docstring

The doc string leaves out the write_images arg, which might be a little confusing for Tensorboard beginners. Added it.

LGTM


Fixes for SonarCloud

Codecov Report

Merging #299 (acbcc26) into master (20ce904) will increase coverage by 0.34%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   69.14%   69.48%   +0.34%
==========================================
  Files          66       66
  Lines        5509     5515       +6
==========================================
+ Hits         3809     3832      +23
+ Misses       1311     1293      -18
- Partials      389      390       +1

Impacted Files
Coverage Δ

dtls/client.go
75.86% <0.00%> (ø)

tcp/clientconn.go
68.68% <0.00%> (ø)

tcp/server.go
80.95% <ø> (ø)

tcp/session.go
70.45% <0.00%> (ø)

udp/client.go
84.94% <ø> (-2.16%)
:arrow_down:

udp/client/clientconn.go
72.04% <0.00%> (+0.48%)
:arrow_up:

udp/server.go
84.07% <ø> (ø)

net/blockwise/blockwise.go
67.91% <82.50%> (-0.08%)
:arrow_down:

dtls/server.go
83.90% <94.11%> (+0.09%)
:arrow_up:

message/options.go
75.82% <100.00%> (+0.82%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ce904...acbcc26. Read the comment docs.


Update Progress feature

What this PR does / why we need it:
In existing Gelato project the progress calculation was calculated and updated after finishing migration process for each object.
Using this patch progress will increase gradually for migration process.
We have given weightage to each sub-processes of migration which are "Download", "Upload" and "Delete+Completion".
Weightage for Download: 48
Weightage for Upload: 48
Weightage for Delete+Completion: 4
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Need to make sure it works with the YIG integration changes
Release note:

Hi @xing-yang @wisererik @kumarashit Please review, Thanks.

Hi @kumarashit @sfzeng @wisererik. Please review, Thanks

@sfzeng @kumarashit please review it again, it looks fine now.

@Click2Cloud-Gamma, please remove WIP. @sfzeng please review it again about your comments.

How about this PR now?

From the point of my view, there maybe a concurrency problem, logs have been sent to<EMAIL_ADDRESS>please check, thanks.

LGTM


2024-02-14 Proxy Release

Release 2024-02-14
NB: this PR must be merged only by 'Create a merge commit'!
Checklist when preparing for release

[ ] Read or refresh the release flow guide
[ ] Ask in the cloud Slack channel that you are going to rollout the release. Any blockers?
[ ] Does this release contain any db migrations? Destructive ones? What is the rollback plan?

Checklist after release

[ ] Make sure instructions from PRs included in this release and labeled manual_release_instructions are executed (either by you or by people who wrote them).
[ ] Based on the merged commits write release notes and open a PR into website repo (example)
[ ] Check #dev-production-stream Slack channel
[ ] Check stuck projects page
[ ] Check recent operation failures
[ ] Check cloud SLO dashboard
[ ] Check compute startup metrics dashboard

Reviewed for 12-16-2024 Friday changelog.


Add 'Glossary' page

Describe the Change You Would Like
Bolt should have a glossary of terms used in the Bolt documentation (e.g. target, plan, task, etc).
Questions

Should terms have links to relevant pages? For example, an entry for task might link to documentation for writing and using tasks.
What are the terms we want to list?

Example of one of our other glossaries: https://puppet.com/docs/puppet/latest/glossary.html

Some terms (in no particular order):

Bolt controller
Target
module
modulepath
project
inventory.yaml / inventory file
bolt-project.yaml / bolt project file
plan
task
apply
transport
TargetSpec


Ppe/the one that uses interaction streaming

I have noticed an issue with contract LppT1p3wri4FCKzW5buohsjWxpJHC58_rgIO-rYTMB8 - with the streaming loader, it loads longer than with the default one.
On the other hand - loot contract or "standard" PSTs evaluate 20-25% faster.
Needs more investiagation / debugging.


Performance impovements

It's not much but these combined give 10% improvement on my benchmark.

Can you add some JSDoc comments to the ones that new methods that you've created? I'm a bit confused by what they do. I've been meaning to get around to adding them to the entire codebase but I haven't gotten around to it because it's a big task.

Yeah sure could do that. With type info or just summaries?

Both probably, the more the better.

OK

Done now.

Lol I don't know what I was thinking adding that method. Object lookup is just as fast if not faster. Fixed.

Woot, this is 105ms on my bench.
Means 2x improvement since a week ago :grinning:

Looks great, thanks!


Feature request: Webmail on custom domains.

Now if Mox is running under mail.domain.com and I set up mail accounts for domain another-domain.com, webmail access would always be under mail.domain.com/webmail/.
It would be nice to have an option to have webmail available also at mail.another-domain.com/webmail/
Hum.. and while at it also the user account settings page at mail.another-domain.com/

Now if Mox is running under mail.domain.com and I set up mail accounts for domain another-domain.com, webmail access would always be under mail.domain.com/webmail/.
It would be nice to have an option to have webmail available also at mail.another-domain.com/webmail/
Hum.. and while at it also the user account settings page at mail.another-domain.com/

This is certainly on the list. Along with per-domain client settings, for IMAP and SMTP server. The current client configs all reference the host name. For multi-domain setups, this isn't great because if a domain needs to be moved, all client configs would need to be updated. I'll bump this todo up a bit. (:

Is it correct to assume that you intend to utilize SNI to enable per-domain client settings for IMAP and SMTP on a single server IP? If my understanding is correct, there can only be one reverse DNS entry for an IP address, which used to be a critical factor in avoiding being flagged as a malicious email server.

Is it correct to assume that you intend to utilize SNI to enable per-domain client settings for IMAP and SMTP on a single server IP? If my understanding is correct, there can only be one reverse DNS entry for an IP address, which used to be a critical factor in avoiding being flagged as a malicious email server.

Outgoing email would still always be coming from the mail server host name, independent of domain (SMTP EHLO will always mention the host name, not necessarily the domain name for sending). The reverse DNS checks done by the external receiving mail server should stay valid.
The MX record of each hosted domain would also still reference the actual mail server host name, independent of the hosted domain name. Changing the MX record is not a problem when a domain would need to be moved in the future, and it keeps the incoming SMTP config simpler. Incoming SMTP on port 25 could do SNI (assuming any sender using STARTTLS either does not validate TLS certs or uses SNI), and for deliveries reverse DNS doesn't matter, but I think per-domain TLS certificates on port 25 would only complicate matters, and not help anyone.
I plan to only have the per-domain TLS certificates in the IMAPS and Submissions listeners. They are the only ones that mail clients use (SMTP-receiving mail servers have no concern with these). The IMAP/Submission hostname will probably be mail. by default, with "mail" being CNAME to the host name. Those will be the names configured in email clients. And if a domain needs to move, changing the CNAME record will keep client configs working.

Closing this issue since the requested feature has been added to the roadmap.
Thank you for the details!


Move predis/predis to suggestions

Due to breakage when combined with Laravel 4 and below (L4 imposes predis 0.8.7 restriction) I moved predis/predis to suggest-section of composer.json.
If my changes turn out to break Travis I'll just close the PR and go cry in the corner.

The test for BUILD_ALL=true fails while ADAPTER=Predis does not. I'm very, very confused. :sob:

Thank you for this PR. As you probably noticed @aequasi helped you solve this issue in #48.
Btw, I see that you are based in Stockholm. Will I see you at the next PHP meetup?

Yeah I saw. Thanks!
Not sure; I'm horrible at networking and might be out of the country that week :shipit:


Atom error in Git pane after using terminal

First, thank you for this awesome package I use constantly!
Want to be sure you are aware of https://github.com/atom/atom/issues/17055#issuecomment-380511668 both another user and I noticed that we encountered this odd Atom error while doing something in the Git pane after using platformio terminal. I've only seen this in Atom beta 1.26.1

no longer seeing this in 1.26 or 1.27 beta, so closing....


Adding Drop downs in exsisting VPC

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests


Fix show deprecated suggestion for alias

Fixes #40588
I'm marking this as a draft as I'm not sure if the kindModifiers for the alias "export,deprecated" should contain the export modifier.
Let me know if this is correct or not as there are a few other fourslash test that are failing due to this change, so not sure if I should update them or not

Oh, I didn't see that there were other failing tests. Can you update those to show how the modifiers change?


Search window closes if settings.json is changed.

How to reproduce:
1- Open settings.json in an editor (vscode, neovim, notepad ...).
2- Open vscode (code) and start fuzzy search Ctrl+Shift+j. Don't press enter let it wait.
3- Edit settings.json:
    "editor.cursorStyle": "block", ->     "editor.cursorStyle": "line",

4- Save settings.json
In vscode suddenly fuzzy search terminates and terminal closes.

Hi, I can confirm. This is intended behavior. Some workspace settings affect the extension's behavior, in some cases requiring the extension to be restarted.

I see. Thank you for the quick response.


update index page

added new github user link

@NITISHSHARMA12  contribute here https://github.com/Ishaan28malik/Get-Dev-Resources


Bug: poor rep exposure for move

The newly implemented move() and surround() function families have some poor design choices regarding how they restructure the tree. There's some especially egregious representation exposure (like setParent()) and unsafe operations (like removeChildWithoutDelete()) that may compromise the integrity of the tree if used incorrectly.
We definitely need to refactor a lot of this and add some more safety checks to ensure that these functions are avoided or remade to be much safer and not so bug prone.

https://github.com/casey-c/egg/commit/fa4b20dc7b3e5f69c232e1effba89ec62dfbbd20


Contacts and Contact Attributes are DONE.

For every message received, not existing contacts get inserted or (if necessary) existing contacts get updated.
With Attributes such as:
-WHATSAPP_ID
-WHATSAPP_PHONE_NUMBER
-WHATSAPP_AVATAR
-WHATSAPP_NAME
-WHATSAPP_SHORTNAME
-WHATSAPP_PUSHNAME
-WHATSAPP_BLOCKED
-WHATSAPP_KNOWN

The "RETURNING" clause is not supported in SQLite3. Due to this problem. Code needed additional query function to access id of last inserted row in contacts. New select query added.


Structure Damage values not displayed in table

During testing, I observed that values in the Occupancy Type editor's Structure Damage and Content Damage tables were no longer being displayed compared to an FDA build from November 10, 2021.
Using SQLite, I verified in the study's sqlite file that there are values for occupancy types. However, in the latest release from December 13, 2021, the values are no longer displayed in the Occupancy Type editor.
Previous Build:

Current Build:

I am not sure what could have caused this. I have made no changes to the occtype editor. Might be something with SciChart. Maybe when we updated to a newer version or something. I don't think these plots ever quite worked correctly. This should be moved to task 14.

Update: This is definitely a bug. Seems to be affecting normal distributions. I don't think i had anything to do with this change. I think something happened in the model or statistics. This logic routes through Bob's importer and then i translate it into FDA 2.0 curves. It goes through some factories in the model and statistics and I think the median is getting set, but the mean isn't? I think Will made some updates so i should get the latest on stats before debugging further.

You're right - looks like IDistributedOrdinateFactory calls on the IDistribution factories which have since been nuked.


Where is IAuthenticationService used in AuthenticationMiddleware

I couldn't find any use of IAuthenticationService interface in AuthenticationMiddleware.cs.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 393b3379-6061-50a4-0975-b3d1d82b660b
Version Independent ID: 48e4e204-ea22-c225-0cbc-0d811bdb90ed
Content: Overview of ASP.NET Core Authentication
Content Source: aspnetcore/security/authentication/index.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @mjrousos
Microsoft Alias: riande

Sorry for the delay ... I got pulled off on something else. IIRC, the the AuthenticateAsync is from IAuthenticationService's implementation.
I noticed from the API that this is mentioned in passing for GetDefaultAuthenticateSchemeAsync in the middleware ...

Returns the scheme that will be used by default for AuthenticateAsync(HttpContext, String).

... where AuthenticateAsync specifically denotes IAuthenticationService.AuthenicateAsync.
Cross-refs:

https://learn.microsoft.com/dotnet/api/microsoft.aspnetcore.authentication.iauthenticationschemeprovider.getdefaultauthenticateschemeasync
https://learn.microsoft.com/dotnet/api/microsoft.aspnetcore.authentication.iauthenticationservice.authenticateasync

I'll close, but @mjrousos will see this and can revise my remarks if I'm incorrect.


Fix GUI display

Pull Request instructions:

Please follow the update protocol
Answer the questions below in detail. Your responses will be emailed to experimenters.
If the experimenters must do anything new, provide detailed step by step instructions on the wiki
Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
If you use the keyword "skip email" in the title, it will skip the email updates
Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:
Fixed the GUI display when selecting/changing tasks.
What issues or discussions does this update address?
The display issue seems to be related to some recent updates.

BlockMinReward was disabled in the Uncoupled task, but not enabled when we changed it back to other tasks.

Describe the expected change in behavior from the perspective of the experimenter
No
Describe the outcome of testing this update on a rig in 447
Tested it on my own computer.

Have you tested your changes with the UI file for training rigs? I'm still worried about maintaining two versions of UI files...

Have you tested your changes with the UI file for training rigs? I'm still worried about maintaining two versions of UI files...

Yes, I also tested the training rig UI.


Tamagui class font weights broken when upgrading to Expo 51

Current Behavior
Font weights from built in header (i.e. H1, H2) and button text class styles no longer apply.
There was an Expo font issue I opened for the SDK related to icons but the icon part has been fixed: https://github.com/expo/expo/issues/28693
Expected Behavior
The bold font weights apply
Tamagui Version
1.97.1

Platform (Web, iOS, Android)
iOS

Reproduction
I'm working on a reproduction- I can't get to Expo 51 from the starter repro due to https://github.com/tamagui/tamagui/issues/2637

But essentially I upgrade my repo from Expo SDK 50 to 51 and the font weights are all gone.

System Info
npx envinfo --system --npmPackages --binaries --browsers

><EMAIL_ADDRESS>npx
> envinfo --system --npmPackages --binaries --browsers

  System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 190.00 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 21.6.1 - ~/.nvm/versions/node/v21.6.1/bin/node
    Yarn: 4.0.2 - ~/.nvm/versions/node/v21.6.1/bin/yarn
    npm: 8.19.4 - ~/(redacted)
    bun: 1.0.30 - ~/.bun/bin/bun
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 124.0.6367.158
    Safari: 17.4.1
  npmPackages:
    @babel/core: ^7.24.0 => 7.24.5
    @google/semantic-release-replace-plugin: 1.1.0 => 1.1.0
    @graphql-codegen/cli: ^5.0.0 => 5.0.0
    @graphql-codegen/introspection: ^4.0.0 => 4.0.0
    @graphql-codegen/typescript-operations: ^4.0.1 => 4.0.1
    @graphql-codegen/typescript-react-query: ^6.0.0 => 6.0.0
    @manypkg/cli: ^0.20.0 => 0.20.0
    @semantic-release/changelog: 6.0.1 => 6.0.1
    @semantic-release/git: 10.0.1 => 10.0.1
    @semantic-release/github: 8.0.6 => 8.0.6
    @semantic-release/npm: 9.0.1 => 9.0.1
    @semantic-release/release-notes-generator: 10.0.3 => 10.0.3
    @sentry/react-native: ~5.22.0 => 5.22.2
    @tamagui/animations-react-native: ^1.97.1 => 1.97.1
    @tamagui/babel-plugin: ^1.97.1 => 1.97.1
    @tamagui/config: ^1.97.1 => 1.97.1
    @tamagui/font-inter: ^1.97.1 => 1.97.1
    @tamagui/lucide-icons: ^1.97.1 => 1.97.1
    @tamagui/themes: ^1.97.1 => 1.97.1
    @tamagui/toast: ^1.97.1 => 1.97.1
    @tanstack/react-query: ^5.12.1 => 5.17.15
    @types/react: ~18.2.79 => 18.2.79
    @typescript-eslint/eslint-plugin: ^5.49.0 => 5.62.0
    @typescript-eslint/parser: ^5.49.0 => 5.62.0
    axios: ^1.6.2 => 1.6.5
    babel-plugin-module-resolver: ^5.0.0 => 5.0.0
    babel-plugin-transform-inline-environment-variables: ^0.4.4 => 0.4.4
    burnt: ^0.12.2 => 0.12.2
    conventional-changelog-conventionalcommits: 5.0.0 => 5.0.0
    eslint: ^8.21.0 => 8.56.0
    eslint-config-prettier: ^8.6.0 => 8.10.0
    eslint-plugin-prettier: ^4.2.1 => 4.2.1
    eslint-plugin-react: ^7.32.1 => 7.33.2
    eslint-plugin-simple-import-sort: ^10.0.0 => 10.0.0
    expo: 51.0.2 => 51.0.2
    expo-build-properties: ~0.12.1 => 0.12.1
    expo-camera: ~15.0.6 => 15.0.6
    expo-constants: ~16.0.1 => 16.0.1
    expo-doctor: ^1.5.0 => 1.5.0
    expo-font: ~12.0.5 => 12.0.5
    expo-linear-gradient: ~13.0.2 => 13.0.2
    expo-linking: ~6.3.1 => 6.3.1
    expo-router: ~3.5.11 => 3.5.11
    expo-secure-store: ~13.0.1 => 13.0.1
    expo-splash-screen: ~0.27.4 => 0.27.4
    expo-status-bar: ~1.12.1 => 1.12.1
    expo-system-ui: ~3.0.4 => 3.0.4
    expo-updates: ~0.25.11 => 0.25.11
    graphql: ^16.8.1 => 16.8.1
    prettier: ^2.8.3 => 2.8.8
    react: 18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    react-native: 0.74.1 => 0.74.1
    react-native-gesture-handler: ~2.16.1 => 2.16.2
    react-native-reanimated: ~3.10.1 => 3.10.1
    react-native-safe-area-context: 4.10.1 => 4.10.1
    react-native-screens: 3.31.1 => 3.31.1
    react-native-svg: 15.2.0 => 15.2.0
    react-native-svg-transformer: ^1.3.0 => 1.3.0
    semantic-release: 19.0.5 => 19.0.5
    tamagui: ^1.97.1 => 1.97.1
    typescript: ^5.3.2 => 5.3.3
    zod: ^3.22.4 => 3.22.4

Nevermind, seems like an Expo Go problem since when I use the development build the fonts work totally fine


VAT validation

Seem that VAT validation set in backend isn't managed on frontend.

Could you provide some clear instructions on how to reproduce?

In backend - Customer - Customer Configuration set Show Tax/VAT Number as Required.
---> In frontend VAT Number is optional.
In backend - Customer - Customer Configuration set Enable Automatic Assignment to Customer Group to Yes and Tax Calculation Based on Shipping Address. Than follow Magento official instruction to manage VAT Validation: http://docs.magento.com/m2/ce/user_guide/tax/vat-validation-configure.html
---> Validation not works.

Just to make absolutely sure it's not a configuration issue. If you disable CleanCheckout (in app/etc/config.php, then flush all caches etc), it starts working again?

The reason I asked that question is because when I try to set VAT Number as Required, it's still not required in checkout even without this module. And we don't really mess with VAT settings either, other than set the user's default country.

Going to assume this is not related to Clean Checkout. Feel free to reopen this issue if that's not the case.


Adds ref and SHA as inputs, and sarif-id as output

Merge / deployment checklist

[X] Confirm this change is backwards compatible with existing workflows.
[X] Confirm the readme has been updated if necessary.
[X] Confirm the changelog has been updated if necessary.

This PR might be useful for those facing #796 by allowing to specify a ref, but is NOT a direct fix for it.

Please include the compiled sources (*.js and *.map files) in this PR. Because of the way actions are run, all build artifacts must be checked into the repo.

Hi @aeisenberg! Thanks for your feedback, I've included the compiled sources and fixed most inline suggestions.
I am trying to fix the integration tests, in the meantime there is one question remaining in inline suggestions.
FYI, Integration tests run in my fork. I had to enable workflows, then I created a draft PR in there just so workflows are executed. This information might be useful for future contributors.

All checks are green in my Draft, so as soon as running workflows is approved I think this can go forward.

Everything looks good, but the new CI jobs are failing. I'm digging in to try to figure out why.

sendStatusReport doesn't respect TEST_MODE like some other functions do, not sure why it is getting called here but it appears that the test doesn't have permissions to do a PUT against https://api.github.com/repos/github/codeql-action/code-scanning/analysis/status

sendStatusReport doesn't respect TEST_MODE like some other functions do, not sure why it is getting called here but it appears that the test doesn't have permissions to do a PUT against https://api.github.com/repos/github/codeql-action/code-scanning/analysis/status

Should I add a TEST_MODE for sendStatusReport or something?

In the nonofked version, I see that the permissions block is more permissive, which explains why it is passing there.

Now things are starting to become clear. If I explicitly add security-events: write then the failing workflows will pass. The difference between the failing workflows and the passing ones is that the failing ones use a value for the ref property of the upload status report that is different from that of the PR. Upload status report is an internal API endpoint for telemetry into code scanning. I don't know if it is a bug that the endpoint sometimes accepts requests from user agents that do not have security-events: write permissions. I'm communicating with the team that maintains this part of the API.
Regardless, I think our test workflows should have this permission anyway. Here is what I propose:

I will create a new PR that will add the security-events: write permission to all of our generated workflows.
Can you rebase your PR, @cw-acroteau, on top of the one I will create? And make sure to regenerate the two integration test workflows you created. Also, make sure to fix the merge conflict in CHANGELOG.md.

Thanks for helping me find this bug (or at least odd inconsistency) in the action.

Can you rebase your PR, @cw-acroteau, on top of the one I will create? And make sure to regenerate the two integration test workflows you created. Also, make sure to fix the merge conflict in CHANGELOG.md.

Hi! I just did that, hope everything is fine. I'm waiting to confirm that the worflows will pass, if there's an issue I'll try to fix it. Thanks!

Hi again @aeisenberg ! Can you please check if the checks are okay in a copy similar to https://github.com/github/codeql-action/pull/902 please? It fails here because of "RequestError [HttpError]: Resource not accessible by integration", but it might be due to the fork.

Oh sorry I did a git rebase, and not changed the base branch. I thought this was what you meant.

No problem. I wasn't clear about it. I changed the branch and it all looks good. Yes, the reason why the new workflows are failing is because the security-events permission is always downgraded to read for forks. I don't think it will be possible to get it to pass from a fork.  I'm in discussion with the API maintainers to figure out if we should avoid uploading status reports for integration tests. This should allow your integration tests to pass.

They are in Europe, so I probably won't hear anything until tomorrow.

PRs from forks will always have their security-events permission downgraded to read. This makes sense because we don't want malicious PRs to come around and tamper with the security alerts for refs they are not associated with.
There is an exception to this. a PR from a fork can write security events to resources associated with that PR only. This allows the PR to report security concerns about itself without giving it the ability to overwrite other refs.
What this means is that using the standard PR workflow, these new ref and sha inputs will not be able to work in forks. We will need to document this accordingly.
It looks like there are ways around this using pull_request_target  or possibly [Send write tokens to workflows from pull requests[(https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#enabling-workflows-for-private-repository-forks).  I haven't tried out either of these solutions yet, but they will probably work. However, there are added security considerations with this.
What this means is that we need to rebase on the latest tip of the aeisenberg/permissions in this PR (I'll do that shortly) and update the documentation of the inputs to point out the limitation with forks. This PR can then be merged. Later, we can  work on some proper documentation on how to use these inputs in forks.

I created a PR in your repo for these changes. If you are happy with them, please merge and then I can merge here.

This PR should not have been closed. It should have been retargeted to main. Let me see what happened.

@cw-acroteau I'm very sorry, but could you create a new PR targeting main? For some reason when #902 was merged, this PR was closed. Instead it should have been retargeted against main.

@cw-acroteau I'm very sorry, but could you create a new PR targeting main? For some reason when #902 was merged, this PR was closed. Instead it should have been retargeted against main.

@aeisenberg Please see #904


Clean up and Document the io.image enhancements

PR #3024 introduced a few enhancements on the io.image methods used for reading JPEG and PNG images. The code changes were merged but there are a few nice-to-have improvements missing.
More specifically:

[ ] Provide better error messages for JPEG and PNG when a specific ImageReadMode value is not supported.
[ ] Ensure that image_read_mode.h has a new line at the end of the file.
[ ] Replace the old #define with the newer constexpr expression at image_read_mode.h.
[ ] Move the documentation of ImageReadMode values from the methods to the enum.

Note: constexpr might cause problems on Windows. If that's the case, try using const instead.

Hey! I was wondering if I could contribute to this issue, is there anyone already working on it?

Hey @Sid2697, welcome!
Go for it. Looking forward to your PR.


Unable to search for formulas

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

[ ] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[x ] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[x] ran brew config and brew doctor and included their output with your issue?

To help us debug your issue please explain:

What you were trying to do (and why)
Trying to search for formulas.
What happened (include command output)

# brew search <any formula name>
Error: execution expired

What you expected to happen
View a list of formulas that match the search criteria, if any match

Step-by-step reproduction instructions (by running brew commands)
I am not sure if this is particular to my Mac or not. Up until yesterday, I was able to search for and install formulas as expected. I have been facing this issue since updating homebrew via brew update yesterday.

Additional info:

# brew config
HOMEBREW_VERSION: 1.7.1-224-ga985f0a
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: a985f0a5d0cd7e73ea6cafe842a08aba82cee4b5
Last commit: 2 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 80c925623934231f7c924467114cc9f09b13e024
Core tap last commit: 6 hours ago
HOMEBREW_PREFIX: /usr/local
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.3.7 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/bin/ruby
Clang: 9.1 build 902
Git: 2.18.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: 1.8.0_25
macOS: 10.13.6-x86_64
CLT: N/A
Xcode: 9.4.1
XQuartz: 2.7.11 => /opt/X11

# brew doctor
Your system is ready to brew.

Can you rerun with brew search --debug?

@virajchitnis It's OK, it's not a Homebrew bug in that case.

hi there, i am having same issues
here is terminal output:
Merts-MacBook-Air:projects mert$ brew search --debug
Error: invalid option: --debug
/usr/local/Homebrew/Library/Homebrew/cli_parser.rb:82:in `parse'
/usr/local/Homebrew/Library/Homebrew/cli_parser.rb:9:in `parse'
/usr/local/Homebrew/Library/Homebrew/cmd/search.rb:41:in `search'
/usr/local/Homebrew/Library/Homebrew/brew.rb:87:in `<main>'
Merts-MacBook-Air:projects mert$ brew search --debug  tmux
Error: invalid option: --debug
/usr/local/Homebrew/Library/Homebrew/cli_parser.rb:82:in `parse'
/usr/local/Homebrew/Library/Homebrew/cli_parser.rb:9:in `parse'
/usr/local/Homebrew/Library/Homebrew/cmd/search.rb:41:in `search'
/usr/local/Homebrew/Library/Homebrew/brew.rb:87:in `<main>'
Merts-MacBook-Air:projects mert$ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Putting non-prefixed coreutils in your path can cause gmp builds to fail.

Warning: You have unlinked kegs in your Cellar
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  cocoapods
  docker
  docker-compose
  docker-credential-helper
  docker-machine
  librtlsdr
  numpy
  pyqt
  python@2
  screen
Merts-MacBook-Air:projects mert$ brew config
HOMEBREW_VERSION: 1.7.2-59-g0af24cf
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 0af24cf8bc6ae9572de19c1f1209320f81cf31e2
Last commit: 23 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 0259c66b03f81bd174959493ad8cdcaef4025224
Core tap last commit: 6 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_DEV_CMD_RUN: 1
HOMEBREW_GIT: git
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_VISUAL: nano
CPU: quad-core 64-bit haswell
Homebrew Ruby: 2.3.7 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/bin/ruby
Clang: 8.0 build 800
Git: 2.10.1 => /usr/bin/git
Curl: 7.43.0 => /usr/bin/curl
Java: 10.0.2, 1.8.0_181
macOS: 10.11.6-x86_64
CLT: <IP_ADDRESS>.1.1480973914
Xcode: 8.2.1
XQuartz: 2.7.11 => /opt/X11
Merts-MacBook-Air:projects mert$

hello there, i was able to solve the problem by updating all repos and taps
find /usr/local/Homebrew -name ".git" -exec dirname {} \; | xargs -n1 -I% -- bash -c 'cd %; pwd; git pull'


fix: no longer doing email link tracking

:tada: This PR is included in version 4.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix youtube

This pull request...

Fixes a bug

Description
Fixes #885 by using a forked version of lavaplayer since the original seems dead atm.
This PR also adds optional support for the needed tokens if a youtube video is truely an age restricted video. Documentation on how to retireve the correct tokens can be provided in a PR as well. (Yes I'm well aware that this project aims to minimize the need for tokens but it seems to me that this is a too common issue to be left alone imo.)
An upcoming version will also fix #1122

We are using our own fork of lavaplayer. Please suggest or PR any patches there instead.

Thank you for making this @Sartharon Sartharon! I often encounter error 403, so I am glad to be able to use this as a stop-gap solution.

Thank you @Sartharon!


feat(test_utils): Use arbitrary/proptest instead of rand on generating random values

closes #1306

this diverged a bit and is no longer that useful, hence closing
cc @joshieDo


Paginate secrets in AWSSecretsManager

Describe changes
I was looking to contribute and this seems the easiest, however to be honest I haven't had a chance to test this with more than 100 secrets yet 😅
Please feel free to keep this on hold or take over. In the meanwhile, I might take a look at some other issues that I can contribute to and reliably test
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[x] If my change requires a change to docs, I have updated the documentation accordingly.
[x] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Other (add details above)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Alby requests to close the browser window when pop-up is opened in tab

Describe the bug
When using the Open link in same tab, pop-up as tab [Free] extension, Alby prompts to close the current browser window when either canceling or confirming a website to connect.
Screenshots (If Any)

To Reproduce
Steps to reproduce the behavior:

Install Open link in same tab, pop-up as tab [Free] on Chrome/Brave
Visit to https://podcastindex.org/ with no existing website connection
Either cancel or confirm the connection in the new tab
See browser warning to close window
Window closes if confirmed

Expected behavior
The tab should close without attempting to close the entire window
Alby information

Alby Version: 1.13.0
Alby installed through Chrome store
Wallet connected with Alby: RaspiBlitz

Device information [optional]:

OS: Fedora 36
Browser: Brave
Browser Version: Version 1.42.88 Chromium: 104.0.5112.81 (Official Build) unknown (64-bit)

Additional context
I use this browser extension because pop-ups do not play well with the Pop-Shell tiling gnome extension.
Are you working on this issue?
No

oh that's interesting. Thanks for reporting this.
To prompt the user for confirmation we open a new window and we try to close that window again.
The same-tab extension seems to prevent that a new window is opened, but we still try to close the window.

@escapedcat do you know if we can identify if the page is running in a popup or in a full tab with JS?

Not form the top of my head, found this:
https://stackoverflow.com/a/9112637/1667461
Not sure if this covers "OSX fullscreen" mode.


Suggest power cleaning devices

By 'power cleaning' I mean surge protection, uninterruptible supply, devices that clean up the power signal provided, etc.
This is because devices like the rpi are very sensitive to power fluctuations and it can cause serious issues if they occur, esp. surges.

May be part of going to production blog series but mostly outside the scope of our docs


Email address false negative

Seems like emails like<EMAIL_ADDRESS>should be valid. Repro:
brad: validator npm install validator
npm http GET https://registry.npmjs.org/validator
npm http 200 https://registry.npmjs.org/validator
npm http GET https://registry.npmjs.org/validator/-/validator-3.40.1.tgz
npm http 200 https://registry.npmjs.org/validator/-/validator-3.40.1.tgz
<EMAIL_ADDRESS>../node_modules/validator
brad: validator subl index.js
brad: validator node
><EMAIL_ADDRESS>false

Thanks. GMail ignores the dots and so will require some special handling. For example<EMAIL_ADDRESS>is valid and will send email to<EMAIL_ADDRESS>

Perhaps this can be fixed before running the validation itself, by doing something like:
if (value.match(/@gmail/)) {
  var parts = value.split('@');
  parts[0]  = parts[0].replace(/\./g, '');
  value     = parts.join('@');
}


Towards local Windows installs with Docker and WSL2

I managed to get a local SocialPredict instance running with Docker and WSL2 in early July/late June. Now WSL2 tells me it can't find the Docker install.
Look into this so that users can run local instances consistently with WSL2.

Could you outline the steps you followed to run it on WSL2?

Could you outline the steps you followed to run it on WSL2?

Yep!

Install vscode on WSL2
Through vscode, install the Docker extension
(I already have Docker Desktop for win11 with WSL2 support enabled)
Try to run ./compose-dev on WSL2 in my /socialpredict
See the attached screenshot for results:

When you try to access docker through Windows terminal and not through the wsl distribution, does it work?

When you try to access docker through Windows terminal and not through the wsl distribution, does it work?

Yes, I can access Docker Desktop fine on win11. It just seems like WSL2 forgot I have Docker.

Update: I updated my Docker extension in VSCode inside WSL2, and now that worked.

Update: I updated my Docker extension in VSCode inside WSL2, and now that worked.

VSCode has nothing to do with Docker itself, so I don't think this is the issue.

VSCode has nothing to do with Docker itself, so I don't think this is the issue.

Should I reopen this issue, then? I'm just confused that it started working again.

Steps for installing Docker on Windows:
This procedure was followed on a Windows 10 Pro machine but it should also work on Windows 11

Open Powershell as administrator and run:
wsl --install
Wait for the operation to finish and restart your machine.

After restarting the machine, the Ubuntu installation will begin. Wait until it finishes and make sure you enter a username and password.

After installation is complete, you will automatically be logged in to Ubuntu. You can exit by typing:
exit

Open again Powershell and run:
wsl --version
Make sure WSL Version is 2.

Visit Docker and download Docker for Windows.

Run the downloaded file and proceed with the installation:

Make sure to select "Use WSL 2 instead of Hyper-V"
Wait for the installer to finish unpacking files
When it finished make sure to click "Close and log out"
After logging in again you will be provided with Docker Service Agreement. Make sure to accept it.
Then Docker will start and offers you the option to Sign Up, Login or Continue without signing in. Make your choice.
Then you can either complete the survey or skip it.
After that Docker will be up and running. You can verify by checking on the bottom left part of Docker: "Engine Running".

Then open "Command Prompt(CMD)" or "Powershell" and run:
docker --version
docker compose version

If you did everything correctly you should see the version of both commands.

Now you can run Docker and Docker Compose on your Windows Machine. In order to run it you need to make sure Docker Desktop is running on your machine.

If you wish to run docker via the WSL VM, just search for "Ubuntu" and click on it. When the machine starts up and you are logged in you can run docker inside the VM.

If Docker Desktop is not running, you won't be able to run docker or docker compose. You will most likely get an error saying docker not found.

Thank you...yes, out of everything, I wasn't doing step #10. :')


Import error

paradoxia> help
Traceback (most recent call last):
File "paradoxia", line 18, in
main()
File "paradoxia", line 16, in main
console()
File "/home/mirco/Documenti/paradoxia/kernel/pdmain.py", line 372, in console
args = command.split()
AttributeError: '_Helper' object has no attribute 'split'

Did you run it like this :
cd paradoxia
python3 -m pip install -r requirements.txt
chmod +x paradoxia
sudo ./paradoxia

I can't reproduce the error, Can you tell me how you're running it? Do you have all modules installed? And what's your Operating system?

Did you run it like this :
cd paradoxia
python3 -m pip install -r requirements.txt
chmod +x paradoxia
sudo ./paradoxia

I can't reproduce the error, Can you tell me how you're running it? Do you have all modules installed? And what's your Operating system?

Nvm last night I have resolve it ty a lot

what was the error solution?


results stream has boundaries between rows missing

Azure Data Studio Version:
Version 1.3.7
Commit 9ca6200018fc206d67a47229f991901a8a453781
Date 2017-12-15T12:00:00.000Z
VS Code 1.26.1
Shell 2.0.9
Renderer 61.0.3163.100
Node 8.9.3
V8: 6.1.534.41
Architecture x64

Steps to Reproduce:

Run the following query:
select * from sys.objects o1 cross join sys.objects o2 cross join sys.objects o3
go

After a few seconds when some results have shown up, move the scrollbar on the right of result set all the way to the bottom.

Actual:
As new rows get displayed the row boundary between a few consecutive rows is missing:

Expected:
The row boundary between all rows to be present.

dupe  #3360


PyTorch: allocation on wrong device when loading checkpoint

Problem description
When storing the state dict of a transformer_engine model on a device with index A and afterwards load it on another device with index B, some memory still gets allocated on device A. The reason for this seems the be the pickle.loads in https://github.com/NVIDIA/TransformerEngine/blob/main/transformer_engine/pytorch/module/base.py#L411
This issue has a large practical impact in distributed training: if device 0 on a host writes the model checkpoint and when resuming the training all other devices read it, all 8 devices on the host suddenly allocate on device 0. In our case we are not able to resume trainings due to OOMs.
Minimal example
import argparse
import torch
import transformer_engine as te

parser = argparse.ArgumentParser()
parser.add_argument("--device", default=0, type=int)
parser.add_argument("--load", action="store_true")
args = parser.parse_args()

torch.cuda.set_device(args.device)

hidden_size = 1024
model = te.pytorch.Linear(hidden_size, hidden_size).cuda()

if args.load:
    state = torch.load("model.pt")
    model.load_state_dict(state)
    print("After load, max_memory_reserved on device 0:", torch.cuda.max_memory_reserved(0))

for _ in range(10):
    with te.pytorch.fp8_autocast(enabled=True):
        output = model(torch.randn((32, hidden_size)).cuda())

torch.save(model.state_dict(), "model.pt")

The issue is triggered this way:
>>> python test_fp8_mem.py --device 0
>>> python test_fp8_mem.py --device 1 --load
After load, max_memory_reserved on device 0: 23068672

Although, torch is set to use device 1 in the second call, memory on device 0 gets allocated as well. The overall CUDA context cannot be freed anymore, thus a significant part of the device is blocked.
Workaround
Restricting CUDA_VISIBLE_DEVICES to a single GPU per process works for us as a quick and dirty workaround

This issue comes up also when using the new distributed checkpoint format (extra state is saved only from 1 of the devices in every TP group)

@Marks101 There are 2 parts to this problem:

The model weights: These make up a large chunk of the allocated memory (~21 out of 23 MB in the toy example above) and can simply be allocated directly on the correct device by passing the map_location="cuda" argument to torch.load in your script, bypassing the need for any allocation on device 0.
The fp8 metadata: These are custom fp8 related tensors that need to be stored and make up only a small portion of the memory (~2 out of 23 MB in the toy example above). These are saved via PyTorch's custom get_extra_state method in TE which unfortunately does not receive the map_location argument. So these extra tensors would still be redundantly allocated on device 0 before being moved to the correct device during loading of the state dict. Often in practical scenarios this memory is negligible compared to the memory of the actual parameters, however, I have created #351 as a workaround.

Fixed in #351

Thank you so much for processing this so quickly!


Update launch files for ROS2 eloquent

Which TurtleBot3 you have?

[x] Burger
[ ] Waffle
[ ] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[ ] ROS 2 Dashing Diademata
[x] ROS 2 Eloquent Elusor
[ ] etc (PLEASE, WRITE DOWN YOUR ROS VERSION HERE)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Raspberry Pi 3
[ ] Intel Joule 570x
[ ] etc (PLEASE, WRITE DOWN YOUR SBC HERE)

Which OS you installed in SBC?

[ ] Raspbian
[ ] Ubuntu MATE 16.04 or later
[ ] Ubuntu Server 18.04 or later
[ ] etc (PLEASE, WRITE DOWN YOUR OS)

Which OS you installed in Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[x] Ubuntu 18.04 LTS (Bionic Beaver)
[ ] Linux Mint 18.x
[ ] Linux Mint 19.x
[ ] etc (PLEASE, WRITE DOWN YOUR OS)

Write down software version and firmware version

Software version: [x.x.x]
Firmware version: [x.x.x]

Write down the commands you used in order

See here

Copy and Paste your error message on terminal

See here

Please, describe detailedly what difficulty you are in

According to a comment here, the launch files seem not to be adjusted for ROS2 eloquent.

@AndreasAZiegler
Thank you for reporting the issue. We'll review the issue and get back to you.
Thanks!

I'm using Waffle, and also expect the support for ROS2 Eloquent.

@testkit
Because some dependencies (cartographer_ros, nav2_bringup, robot_state_publisher, and joint_state_publisher) packages do not support Eloquent yet, we might start to work on it mid December or early January next year.
Ryan

@rjshim, thanks for your information!

@rjshim I am also getting this error. Is there any update on the launch files?

I will close this thread as there have been no updates. Let me know if it still doesn't work.


Pass docker-args-build to apt "docker run"

This passes docker-args-build to the docker run commands used to run apt commands. This solves an issue seen at Plotly.
Note that we don't currently call the new docker-args-process-build because IMAGE_TAG isn't available to us. It also appears to be unavailable in dokku's builder-build so I'm unsure how the new trigger is supposed to work. Since Plotly uses only the older docker-args-build, this is fine for us.
This is currently untested but I'll update this PR when I've had the chance to test it on an internal Plotly system.
@josegonzalez FYI

Yeah this seems reasonable.
Also the docker-args-process-build missing the IMAGE_TAG argument is a definite bug, though I can revisit that in a future release.

This has passed my testing. (Docker arguments generated by an internal Plotly plugin are successfully passed to the container that runs apt.)

Thanks for the release!


can't invert matrix, determinant is 0

Hi,
first of all - thanks for this great component!
Then: I get tons of 'can't invert matrix, determinant is 0' warnings.
I saw that issue 1a04a62 addressed something like that?
So I rebuild the component, but the warnings are still there.
Everything is running great though, just the warnings are a bit annoying.
Thanks again,
Dirk

The commit is supposed to stop that but clearly somethings still up. I'm not 100% sure what could be wrong but at a guess it might be that you've not got a fixed with and height on the contents, in that case until it might be returning a zero for the size of the content which is resulting in the warning.

Hm -I started out with your example, which also throws this error ...?
https://supereggbert.github.io/aframe-htmlembed-component/dist/examples/index.html
I commented out the THREE.Matrix4().getInvers on line 505, and rebuild, but that didn't change anything.
Somehow I suspect that it is not your component but rather a side effect of something else.
When I comment out the render() method, nothing except the ground shows up, but the warning is still there. :/

@supereggbert I am getting this issue as well, and I think it's because I'm including other CSS files.     The thing is I have a site where it has a lot of CSS that is used for regular HTML and is outside of the A-Frame scene (for example a side panel that slides out).   I tested and as soon as I include one of these CSS files like bootstrap.css or jquery-ui.css, that's where I start seeing hundreds of these errors to the point where it freezes up the page.
Does my explanation make sense?  Is the issue that in order to use aframe-html-embed component, there really can't be any other CSS on the page other that that CSS that is being used for aframe-html-embed?

@lmalave Can you try again now with the master, I suspect it's caused by the plane being scaled to zero because it's content is initially zero. I've set a lower limit of scale to prevent a det of 0 on the transform matrix.

This might be the most bizarre bug I've ever tracked down....
I'm desperately trying to use your component in my project. I was getting the issue described here, but no html would render at all in my aframe scene. I basically did a manual binary search of my entire codebase and found the css for firebaseui was causing the issue. More specifically some of the "background-image: url(" rules. I was able to create a discrete example: https://codesandbox.io/s/aframe-htmlembed-component---test-c3e33
If you uncomment the style inside App.svelete, the html won't render in the scene and the console warns will go crazy.
I have no idea why this is happening. @supereggbert any help would be greatly appreciated 🙏

Thank you @dbradley that has pin pointed the cause of the 0 scale matrix problem. It looks like there are no CORS headers for the image so the resource can't be embeded. The component tries to embed all images since it doesn't know what will and won't be used in the html to be rendered to VR. I'll see if I can put a work around in place this weekend so if a resource fails to embed it simply won't get rendered.


Parameter types are not respected

Related Component
compiler
Problem
You can input u64 values to a function that only expects u8
Steps
/// Swaps out configurable values in a contract's or predicate's bytecode.
pub fn _swap_configurables(
    ref mut bytecode: raw_slice,
    configurables: Vec<(u64, Vec<u8>)>, // <----------- Expect Vec<u8>
) {
    // Iterate over every configurable
    let mut i = 0;
    while i < configurables.len() {
        let (offset, data) = configurables.get(i).unwrap();

        // Overwrite the configurable data into the bytecode
        data
            .ptr()
            .copy_bytes_to(bytecode.ptr().add::<u8>(offset), data.len());

        i += 1;
    }
}

#[test]
fn test_buffer_overflow_swap_configurables() {
    // Create a small bytecode vector
    let mut bytecode = Vec::new();
    let mut i = 0;
    while i < 10 {
        bytecode.push(42);
        i += 1;
    }
    let mut bytecode_slice = bytecode.as_raw_slice();

    // Create a configurable that attempts to write beyond the bytecode's bounds
    let mut configurables = Vec::new();

    let mut overflow_data = Vec::new();
    let mut i = 0;
    while i < 20 {
        overflow_data.push(0xFFFFFFFFFFFFFFFF); // <-------------- Input u64 value
        i += 1;
    }
    configurables.push((0, overflow_data)); // Start writing at offset 5

    log(bytecode_slice);
    _swap_configurables(bytecode_slice, configurables);
    log(bytecode_slice);
}

forc test
Possible Solution(s)
No response
Notes
No response
Installed components
forc 0.62.0

Expanding on this, it seems that the compiler is typing overflow_data as Vec<u8>, when it shouldn´t, because 0xFFFFFFFFFFFFFFFF does not fit into u8.
We do check this directly in this example:
fn f(v: u8) { }

#[test]
fn test() {
    f(0xFFFFFFFFFFFFFFFF);
}

We get this error
736 | fn test() {
737 |     f(0xFFFFFFFFFFFFFFFF);
    |       ^^^^^^^^^^^^^^^^^^ Literal value is too large for type u8.
738 | }

But in more complex cases, this test fails:
fn f(v: Vec<u8>) { }

#[test]
fn index_test() {
    let mut v = Vec::new();
    v.push(0xFFFFFFFFFFFFFFFF);
    f(v);
}

returns an ICE, which may be caused by us decaying unresolved Numeric to u64.
error: Internal compiler error: Verification failed: Type mismatch found for call to 'push_43': u64 is not a u8.
Please file an issue on the repository and include the code that triggered this error.

This the smallest example I could find:
pub fn f(v2: Vec<u64>, v3: Vec<Vec<u8>>) { }

#[test]
fn test() {
    let mut v1 = Vec::new();
    let mut v2 = Vec::new();

    v2.push(42);                 // A
    v1.push(0xFFFFFFFFFFFFFFFF); // B

    let mut v3 = Vec::new();
    v3.push(v1);

    f(v2, v3);
}

The intriguing part is that if we swap lines A and B, we get an error.
error: Internal compiler error: Verification failed: Type mismatch found for call to 'push_43': u64 is not a u8.
Please file an issue on the repository and include the code that triggered this error.

Which is consistent with above errors.


Migrate ophyd example devices to ophyd-async

will enable closing #352

@coretl how should we replicate the existing ophyd-sim devices in ophyd-async

update from #484 - this could be solved through using import from dodal

I think we should add the simulated areadetector to the docker-compose used by the dev-container, and have devices that point at it.
https://github.com/epics-containers/ioc-adsimdetector

Maybe, although that should be a separate issue


[Bug]: Apps show error - The action ... has failed on page load

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Multiple appsmith users have complained that they are seeing the error: The action ... has failed on page load.
We started seeing the error after the release of v1.7

Steps To Reproduce
Internal conversation - https://theappsmith.slack.com/archives/CGBPVEJ5C/p1653633651705329
This case is intermittently observed on apps before v1.7
Public Sample App
No response
Version
v1.7

I have the same issue after the update.

Here is the console info for the errors I am getting...


Add documentation for the non-linear score mixin class

For the implementation, see https://github.com/DoubleML/doubleml-for-py/pull/158.

This PR can be merged after the next Python pkg release. It contains the docu for the new linear / non-linear score mixin classes, see https://github.com/DoubleML/doubleml-for-py/pull/158.

The test build with the latest version of this PR (https://github.com/DoubleML/doubleml-docs/actions/runs/4221274850) has been successful, so I merge it now


Change options

It would be nice if there is a method for changing options after stickybits has been constructed/initialized.
Especially the stickyBitStickyOffset option needs changing sometimes.

Could you explain the feature?

@yowainwright: MutationObserver on a header element, when header element height changes (e.g. by media query but also by user/script or anything else), the sticky scroll offset is corrected.

@strarsis are you planning on working on this feature?

@yowainwright: No.


Overlap alert

https://github.com/zulip/zulip/issues/9157
Testing Plan:
Yes, I ran some tests. Actually, I just changed in one file so there is no need to run tests.
I also run the linter, and it totally passed. Also ran node test coverage.
GIFs or Screenshots:
https://drive.google.com/open?id=11i3vJ2ympuu7Gpr_NIOU9Z2RYFoWwCZ2

Hey, Is my solution is fine ??

Closing in favor of the more current https://github.com/zulip/zulip/pull/18439.

Actually this one is more plausible than the other one.


Vanilla - Origin (2015)

https://www.youtube.com/watch?v=QGMp_l8h0Pw

https://github.com/deeppaz/serenes/commit/1d13bd09b4f0f289aca006bad17d3f05c31b3b79 closed


ListCommand: show all available migrations

Fixes: #23
The command "doctrine:migrations:list" doesn't show all available migrations.

I'm no longer giving updates to this project.
I strongly suggest several alternatives:

Try to achieve the same functionality with a makefile, here is a practical example
Put your energies into pushing this functionality into the core project, rather than into an unmaintained package
Fork this repository and maintain your package
Also, ask yourself: do you really need different databases? Like really really?

I'm archiving the project here in GitHub and abandoning it on Packagist.


Are local gradients accumulated and never reset?

I can't see that the local gradients are ever reset. The values are overwritten by the global weights, but the optimizer opt is assigned to the global parameters, so won't this accumulate gradients in the local network?
https://github.com/MorvanZhou/pytorch-A3C/blob/5ab27abee2c3ac3ca921ac393bfcbda4e0a91745/utils.py#L41

I just found out that the state_dict contains the gradients. So they should at least be somewhat reset when loading the global state_dict (with new gradients) to the local nn.
From the pytorch documentation: "torch.nn.Module.load_state_dict: Loads a model’s parameter dictionary using a deserialized state_dict.".
To me, that sounds like it loads a copy of the global parameters, meaning that the gradients will be added to the previous global gradients.

I have a similar question about the gradient.
Acturally, after lnet.load_state_dict(gnet.state_dict()) being excuted, all the parameters in both lnet and gnet are shared. That is to say, the opt.zero_grad() will set the gradients in lnet and gnet to zero!  And, the loss.backward() will maklnet and gnet have the same gradient! So, gp._grad = lp.grad is useless because they point to the same memory!
It is confused and may be a serious bug. However, the code just works (look the episode reward curve and the visualization)!
In my opinion, the code had degraded to A2C, with the difference that the batch data are not in succession but from different envs.

The lnet.load_state_dict() function shows as below:
def load_state_dict(self, state_dict):
    # deepcopy, to be consistent with module API
    state_dict = deepcopy(state_dict)
    # Validate the state_dict
    groups = self.param_groups
    saved_groups = state_dict['param_groups']

it uses deepcopy to isolate parameters from the gnet. So there is no memory share on here.

So after the 1st iteration, gp._grad = lp.grad is useless because they are already the same!

Once local worker has moved to another worker, the gp._grad is necessary to switch to another worker's grad.

Thanks for your reply!

Yes, the load_state_dict() will not make parameters shared. I found it and had scratched out the sentence before.
It will be very kind of you to explain if there might be conficts between workers without locking the shared model.

What if worker A is updating gnet by opt.step and worker B just clears/modifies the gradients by opt.zero_grad()/loss.backward() ?

Note that I made the following comments by step-by-step debug.

# copy from continuous A3C, consider the cases after the 1st iteration
opt.zero_grad()         # zero gradient in both lnet and gnet
loss.backward()         # parameters in both lnet and gnet have the same gradients
for lp, gp in zip(lnet.parameters(), gnet.parameters()):     # the for loop is useless after the 1st iteration ??
    # if gp.grad is not None:
    #     return                           # This "if-return" code are copied from above link
    gp._grad = lp.grad
opt.step()                                 # update gnet parameters (parameters in lnet will not change!)
lnet.load_state_dict(gnet.state_dict())    # update lnet parameters

It will be very kind of you to explain if there might be conficts between workers without locking the shared model.

A lock could be applied in this case, but take a look of HOGWILD for the analysis of backprop without locking.


Allow easy adding of shipping details (e.g. preferred shipping date and time) page to checkout process

In my store, I don't want to skip the shipping method selection page when only one shipping method is available.
The reason is that I want to render a form where the user should insert more details about shipping method (i.e. preferred shipping date and time).
This is currently possible, but requires too much hacking in custom views, because the skip policy is hard-coded in core checkout.views.ShippingMethodView.get method.
I see two ways:

Provide a "should_skip_shipping_method_selection" method which could be overridden in custom views.
Add a settings flag which could be disabled.

The first one, I think, is the best one because allows much more customization.
(Title originally was: Skipping shipping method page when there's only one method should be optional)

This should be relatively straightforward with #1423.

I think more consistent improvement could be to move conditions application to the methods, which would allow to override them, as 1) suggests.

closing all issues that are feature requests that don't have PR's attached.


Fix throughput/octetDeltaCount issue in flow visualization

IsPresent field of connection should be updated before having
IsConnectionDying check otherwise IsConnectionDying will always
return true, which makes existing connections cannot be updated and
octetDeltaCount always return 0.
fixes #2085

@antoninbas Please have a quick check whether the fix works for your setup. It works for me locally. Thanks!

Codecov Report

Merging #2089 (820eaab) into main (b118f2d) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
- Coverage   60.97%   60.77%   -0.21%
==========================================
  Files         270      270
  Lines       20366    20365       -1
==========================================
- Hits        12418    12376      -42
- Misses       6649     6706      +57
+ Partials     1299     1283      -16

Flag
Coverage Δ

kind-e2e-tests
51.51% <100.00%> (-0.14%)
:arrow_down:

unit-tests
41.35% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/flowexporter/connections/connections.go
76.05% <100.00%> (-0.17%)
:arrow_down:

pkg/agent/controller/traceflow/packetin.go
56.69% <0.00%> (-7.15%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
69.46% <0.00%> (-3.82%)
:arrow_down:

pkg/agent/openflow/pipeline.go
66.66% <0.00%> (-3.19%)
:arrow_down:

pkg/controller/traceflow/controller.go
67.27% <0.00%> (-2.43%)
:arrow_down:

pkg/controller/networkpolicy/status_controller.go
85.16% <0.00%> (-1.30%)
:arrow_down:

pkg/agent/openflow/client.go
59.04% <0.00%> (-0.80%)
:arrow_down:

pkg/agent/agent.go
47.48% <0.00%> (+0.47%)
:arrow_up:

pkg/agent/route/route_linux.go
42.44% <0.00%> (+0.58%)
:arrow_up:

...ntroller/networkpolicy/networkpolicy_controller.go
70.77% <0.00%> (+0.64%)
:arrow_up:

... and 4 more

Currently delta count of first record will always be 0. Reason is that for some connections established before flow exporter gets deployed, the bytes in conntrack table may be quite large, making the first throughput a peak in the diagram.
In the case that connection lasting time is less than exporting interval, there will be only one record exported and delta count of the record will all be 0.
This can be fixed by latest commit.

So it fixes the issue with flows not being reported at all. However, if I use connections that last 30 seconds, and keep the export interval at 60 seconds everywhere, all the flow records still have delta counts set to 0, which in turn means that the throughput graphs are still all empty.
This doesn't seem right. I don't know if this is something that should be fixed by including non-zero delta counts in the first flow record for a connection, or if this is something that needs to be fixed on the ELK configuration side. @srikartati

For connections whose duration is lower than the activeFlowExportTimeout, we will send the flow record with idleFlowExportTimeout, depending on the exact duration of the short flow. In these cases, when we send one final record we can send non-zero delta values, i.e., for all flow records generated by idleFlowExportTimeout, we will send non-zero delta count, even though it is the first record (need a fix for this).
For flows whose duration is such that, where there will be one record because of activeFlowExportTimeout and the final record because of inactiveFlowExportTimeout will still have zero delta count and the second record will have the non-zero delta count.
What do you think?

I don't know if there is anything to change on the Antrea side. I do not want to report non-zero delta counts if it's going to create other issues, e.g. with bandwidth reporting, or if it is not in agreement with the IPFIX specs.
It seems to me that maybe this should be fixed on the ELK configuration side: maybe for these "throughput" graphs showing the cumulative amount of traffic, we should fallback to the total amount if the delta count is 0?

I don't know if there is anything to change on the Antrea side. I do not want to report non-zero delta counts if it's going to create other issues, e.g. with bandwidth reporting, or if it is not in agreement with the IPFIX specs.
It seems to me that maybe this should be fixed on the ELK configuration side: maybe for these "throughput" graphs showing the cumulative amount of traffic, we should fallback to the total amount if the delta count is 0?

I checked RFC again and could not find any relevant specification specific to this scenario. Yes even with change on the flow exporter side with inactiveFlowExportTimeout, we will still have an issue of incorrect bandwidth computation using the existing methodology.
Bandwidth computation for flows with only one record using delta count and time interval of records, which is the current method of computation, does not make sense. Therefore, thinking of providing a solution from the ELK flow collector side is a good alternative. I can think of two options:

Ignore the first flow record for bandwidth computation. The downside is we do not see flows with one flow record in throughput charts.
Compute bandwidth or throughput differently for the first flow record. Use total bytes and difference of flow end time - flow start time for the bandwidth computation corresponding to the first record and use the existing computation for the rest of the flow records. Normalize this for all flows. One con is that I am doubtful about the flow start time correctness as we have not tested this enough on all platforms. In due course of time, it will become robust.

@zyiou I feel the name Pod-to-Pod Flow Throughput (Bytes) is not appropriate as there is no time component at all. It should be changed to something like Pod-to-Pod Flow Cumulative Bytes. Do we use total bytes here or delta count? If delta counts, we should directly use total bytes and keep updating after every record.

@zyiou I feel the name Pod-to-Pod Flow Throughput (Bytes) is not appropriate as there is no time component at all. It should be changed to something like Pod-to-Pod Flow Cumulative Bytes. Do we use total bytes here or delta count? If delta counts, we should directly use total bytes and keep updating after every record.

I agree that the name should be changed.
We use delta count in the diagram. Reason is that the value shown in the diagram is actually the sum of delta count over the time period user chooses. For example, if user wants to view the data of last 5 min, the bytes in the diagram is the sum of delta count over last 5 minutes. Sum of total count over last 5 min does not make sense in this case.

We use delta count in the diagram. Reason is that the value shown in the diagram is actually the sum of delta count over the time period user chooses. For example, if user wants to view the data of last 5 min, the bytes in the diagram is the sum of delta count over last 5 minutes. Sum of total count over last 5 min does not make sense in this case.

In theory, we can do the difference of the total count of the last flow record and first flow record in the last five mins. Instead of changing too much, we can do a mix of the total count and delta counts, i.e., use total count for the very first flow record and delta count for the rest. Till now we are ignoring the bytes that come from the first flow record, which leads to inaccurate cumulative byte count. Do you agree?

/test-all

/test-ipv6-only-e2e
/test-ipv6-e2e


[BUG] Minor: DIVE and KWIVER looking at different image is horizontal / vertical fields

https://viame.kitware.com/#/viewer/6102f532c660db235f29edcd
detections computed on horizontal version in kwiver, dive shows vertical
gimp opens up image horizontally like kwiver sees it, ubuntu default image editor loads in vertically

exif orientation data say for it to rotate.  There is a setting in GIMP you might have used at some point and then clicked the "don't ask me again" checkmark.
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/drawImage#notes
Browser should use the orientation information to orient the image automatically.

Can we close this?  I think DIVE is behaving correctly.

Closing issue, dive is using the proper orientation.


Functional programming (itertools, functools, map, reduce, generators, iterators, list comprehensions)

Basic

iteration and filtering using comprehensions
reduction (useful for "sliding window" operations)
combining iterators with itertools

Advanced

Lazy computation and iteration with generators

itertools:

infinite iterations
groupby

functools:

caching

partial application

single dispatch


Excluding migrations from coverage report.

Coverage decreased (-0.1%) to 68.069% when pulling 309245f0eacfd8e5c45c89aa2b800b6a0a8581a1 on kevgliss:auditKeyUI into 744e20481719cf2c1bc43465252862a29365e52b on Netflix:master.


When Selection spans over a non-editable field it gets screwed up on resize

Note: This seems to be a Chrome bug actually

This works fine on Chrome Canary, except that when you have selected the citation anno and press the left key, the cursor disappears.

Browser problem. Not in our hands.


python312Packages.python-can: 4.4.2 -> 4.5.0

Diff: https://github.com/hardbyte/python-can/compare/refs/tags/v4.4.2...v4.5.0
Changelog: https://github.com/hardbyte/python-can/releases/tag/v4.5.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 359979

x86_64-linux

:white_check_mark: 23 packages built:

expliot
expliot.dist
gallia
gallia.dist
klipper
python311Packages.canopen
python311Packages.canopen.dist
python311Packages.cantools
python311Packages.cantools.dist
python311Packages.pycyphal
python311Packages.pycyphal.dist
python311Packages.python-can
python311Packages.python-can.dist
python312Packages.canopen
python312Packages.canopen.dist
python312Packages.cantools
python312Packages.cantools.dist
python312Packages.pycyphal
python312Packages.pycyphal.dist
python312Packages.python-can
python312Packages.python-can.dist
yakut
yakut.dist


Autodetect current branch

Hello!
Why CLI tool doesn't apply current branch automatically?
It can try to detect VCS type and get the current branch.
For example, git branch | grep -e "^*" | cut -d' ' -f 2.

@ihor-popyk, can you please check?
@AlexWayfer, did you try our GitHub / Bitbucket / GitLab sync? It should make things even easier

@AlexWayfer, did you try our GitHub / Bitbucket / GitLab sync? It should make things even easier

Yes, I saw it. But I'm not sure that I want Crowdin servers pull all of our project code, not only translation files. :grimacing:

We pull only those files you specify during configuration, no need to upload everything of course. There will be crowdin.yml file created in your repository, it has the same configuration as CLI but here you need to specify only files section, no need to specify your project credentials!

But how Crowdin servers will get crowdin.yml and localization files without git clone/pull?

Also you may have a separate repo where only files for localization are being hosted, nothing else. It's very common approach right now

And use git submodules? I'm not sure that this is a good idea. Also, what should I do with project branches (about which I wrote) in this case? Create two branches with the same name in two repositories? Oh, come on.

@Andrulko @AlexWayfer
I am going to implement this feature.
Thanks for suggestion.


PeerJ EC1

This article is viewed favorably by the reviewers, and should be published, after suitable revision.
Since it is an unusual submission, the reviewers have made many comments, though not always clearly indicating which are reflections and which call for changes. However, it really would help the article, and aid future readers, if as many as possible of those comments were to be addressed.
Reviewers 2 and 3 make specific comments about sections and paragraphs; those should certainly be attended to in a revision, as should the brief comments by Reviewer 1. Further, see some points below.
One repeated concern is about just having one reviewer for most of the works. This should be explained. How are conflicts of interest identified and addressed? How is having knowledgeable and skilled reviewers ensured? How is quality ensured if anyone can volunteer and review and that is the only checking done? How is correctness assessed in such cases? Has there been any review by others of the quality of the works accepted?

The reviewer point (mentioned in #18 and #26) is a valid one—personally I would prefer to not have just one reviewer myself.
Regarding conflicts of interest, we do have a checkbox asking people to confirm they do not have one, but no more than that (other than intrepid editors doing a little research). However, do most journals go further than that?
I do think it's fair to say that the checking of reviewers' work comes down to the editor, but I think that is true for most journals.
We are currently quite trusting of the reviewers in terms of their areas of expertise; any suggestions on how we could improve this moving forward? It probably comes down to more work on the part of the editor, I imagine.

Also related to #6

I agree that having multiple reviewers would be good in general, though it adds more work, and we need to change our systems to support it.
Regarding COIs, I think we are not doing less than most others.
Maybe there is a general question about:

what is the obligation of the editor in selecting reviewers, ensuring that they do not have conflicts, and checking the quality of the review?
how do we define this and then enforce it?

We do have a conflict of interest policy that reviewers are "required" to read before/during their review, and verify with a check that they do not have one. Of course, like most COI checks/declarations, this relies on people being honest, which I agree is probably the same level as most (if not all) other journals.
In fact, I don't think I've ever explicitly seen anything about COIs when reviewing for other journals... so I think we can respond with some of this. We certainly aren't doing less than most journals.
As an editor, I've definitely taken looks at a suggested reviewers, and in one or two cases did not ask them to review because they had previously contributed to the submitted software in some way. I think this is probably pretty similar to standard practice as an editor handling a paper submission.

I agree, I think we deal with this similarly to other journals.

Notes for paper:
Regarding quality of reviews:

Some editors get two reviewers (this happens frequently for submissions where the editor doesn't feel particularly comfortable with the submission)
If the review happens very quickly with few comments then the editor will often spend more time checking too
Inherent trust placed in the reviewer. We believe the openness of the review process promotes adherence to the review process... (reword!)

Also, projects that are broader in scope are more likely to get two reviewers, e.g., https://github.com/openjournals/joss-reviews/issues/217 had Matlab and C++ components.

The editor comments mainly collect a number of consistent questions in the reviewer comments, so I don't think we need to respond to everything multiple times... but here is my draft response:

We have made changes in response to many of the reviewer comments, as detailed in the rest of this document.
Regarding the question of number of reviewers, we have responded to Reviewer #1 and #2's comments.  We believe that our efforts around reviewer selection and reviews meets (and in some cases surpasses) that of most other journals, since the entire process is open and transparent. Further, we add structure to the reviews, and feel that this helps ensure that our criteria for submission quality are met. Some editors do regularly assign two reviewers, and other editors get involved in the review nearly at the level of a reviewer to help ensure quality (particularly if a review occurs very quickly). We do also have a conflict of interest policy to which reviewers are required to agree; this represents a step further than most other journals, though we do generally place trust in the reviewer---the openness of the review process and reviewer identities helps ensure adherence to the COI policy.

👍 LGTM


test: block generating end-to-end expected results on Saxon 10

Saxon 10 has a subtle change in serialization. Generating end-to-end test expected results using Saxon 10 should be blocked until it's resolved.
Tested on Saxon 10 (blocked), <IP_ADDRESS> (blocked), <IP_ADDRESS> (allowed) and <IP_ADDRESS> (allowed) with #844 integrated.

Saxon 10 has a subtle change in serialization.

Turned out to be a Saxon bug.

Also https://saxonica.plan.io/issues/4498 may be related.


window.scrollTop

Your system information

VelocityJS version: 2.0.5

I'm trying to animate the window.scrollTop using velocity v2. The code below doesn't work. Is there an interface to accomplish this?
    window.velocity(
        { scrollTop: "0px" },
        {
            duration: 800,
            delay: 500
        }
    );

I'm trying this, but it also doesn't work.
        var dummy = document.createElement("p");

        dummy.velocity(
            {
                tween: [0, 1000]
            },
            {
                progress: function(
                    elements,
                    percentComplete,
                    remaining,
                    tweenValue,
                    activeCall
                ) {
                    console.log("The current tween value is " + tweenValue);
                }
            }
        );

I'm having the same issue.
velocity(document.body, { scrollTop: scrollDist }, 5000, 'swing');

scrolling occurs immediately, without animation


chore: add final docs cleanup changes

part of RHCLOUD-36308

Preview: https://react-data-view-pr-data-view-163.surge.sh


[Storage] Async Query Blob

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob

Addresses #29625

In progress


Add Steps to Using Key Vault Certificate with RBAC

My customer had errors trying to add a custom domain to CDN using Key Vault certificate with RBAC permission model. Our documentation says they have to allow CDN to Get and List certificates and secrets using vault access policy for it to work. We confirmed using the RBAC Key Vault Secrets User role gave the correct permissions, so that method should be added to avoid confusion around which role to assign.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: beac0740-af6e-61ce-bcfa-e783ca181b7d
Version Independent ID: d97885ea-b051-5fde-bd14-ec977e34760e
Content: Tutorial: Configure HTTPS on an Azure CDN custom domain
Content Source: articles/cdn/cdn-custom-ssl.md
Service: azure-cdn
GitHub Login: @duongau
Microsoft Alias: duau

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Thank you for you dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Infer LLM embeddings to parquet

Add functionality to save embeddings as parquet.

inference is in batches, and so writing to hdf5 is better than to parquet, which would create many chunk files. because we want all embeddings in the same file, we'd have to re-combine them into one after inference. So, we use existing functionality to save first to hdf5, and optionally (default yes) to parquet.
the script now deletes any existing hdf5 file with the same name before the first set of embeddings is written to disk. pyarrow automatically overwrites existing files.
I simplified the pipeline.sh and the infer_small.sh scripts with the load_venv function
I fixed a bug in SimpleEncodedDataset.

I added a note about memory requirements -- under some circumstances it might be better to do the transformation to parquet in a separate process.

I also fixed code related to #121, and ran the linter autofixes on pipeline.py. it's large diff, but no functionality should have changed there.


Feature suggestion: Appear on scroll and/or delayed appearance

Unless I'm mistaken and this is currently supported, it would be nice if when the user visits a site, they get to experience it, at least for the first few seconds as pristine (without the cookie banner). Then, if they started scrolling, or after a developer-specified delay (e.g. on the order of 5 seconds or less), the cookie banner would appear. I'm not sure if this is against the cookie law though.

@zamirkhan You can implement that yourself if you want, probably something that doesn't would make its way into the API because of deprecation state in the future see also #409
You could easily do something like this what would delay for 5000 milliseconds:
setTimeout(function(){ window.cookieconsent.initialise({...},5000)});

There is also straight forward ways to achieve something similiar on a scroll event, no need to implement something like this within the API.

test

test2

@zamirkhan Take also a look on #409 IDK if this will find its way into the API because of the current state. However you can easily implement the requested functionality yourself and wrap it around the original configuration code of the API. If you want do delay the dialog for e.g. 5000 milliseconds you could easily do something like this:
setTimeout( function(){ window.cookieconsent.initialise({...}) }, 5000);

For the sake of simplicity I didn't include any .initialise() configuration parameters.
There are also straight forward ways to simple trigger the dialog on scrolling e.g. after some scrolling time with an event. For more information take a look on this thread
No need to implement something like this within the API. Simply load the cookie consent dialog after some amount of scrolled pixels.

You should do this in reverse way - hide info when user tries to use your website.

@zamirkhan Thanks for this question. So after looking at what you were asking and the suggestion because there is no way to determine how long a user will be on the site before it loads, legally speaking it should be the first thing they see in some manner. This law is obnoxious to the experience some times, but it can be mitigated with style and this is why we offer so much extension to the templates and styles available so you can make it the least intrusive to the user's experience.
@wargo32 it does do that, dismissOnScroll: true and dismissOnWindowClick: true


Consent

Have you given your consent for your mod to be placed on NexusMods by a person named JackQW?
If so then great glad to hear it if not I reported it that he didn't create the mod and you should do the same. I wasn't going to put your work on a site without permission. BTW the mod works great from what i have tested. Not one issue from upgrading the bandits so far.
Thank you for fixing the issue so quickly from before.

yeah, that's me


docs: Add some helpful notes for Incremental Static Regeneration

Hopefully this is helpful, explaining some of the steps one would have to go through for Vercel ISR in more detail.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

A number of additional things are touched on in the comments of the referenced PRs (seen above).
At any rate, I think these ISR docs could be more helpful overall, to better explain the functionality and limitations/edge cases users are likely to encounter.
As long as there is no dedication function for doing so, I think it would also be good to show a generic example of revalidating a given route (which most seem to do via fetch with the special header set). Something like:

https://github.com/jdgamble555/isr-test/blob/master/src/routes/revalidate/%2Bpage.server.ts
https://github.com/binsarjr/apiliburnasional/blob/7a10a92a339d9ccaaba71f5f6e1be28aa879fcaf/src/routes/api/revalidate/%2Bserver.ts

The changes around prerendering are not accurate. I think it's better to move the things that are parts of the comments in the code snippet out into better visible text and enhance those a bit. While digging into this I also noticed some flaws in the current implementation, will get back to this.