Crash with "Running without renderer sandbox" in debug.log

SyncTrayzor crashes very rarely when exiting the program ("The program encountered a problem and needs to close"). This is the error message that is written to debug.log (I already have several of them there, whereby the first two numbers are changing):
[0308/221734:ERROR:renderer_main.cc(227)] Running without renderer sandbox

It seems that this error message is related to the WebKit component that is used to display the Syncthing GUI. This also seems to affect "popular" software like Steam, but it seems that there isn't any "solution" at the moment (the problem seems to occur when the WebKit component is used in a certain way). Unfortunately, this crash seems to occur randomly, so I haven't found any steps yet to reproduce it (Synthing is however stopped properly before the crash occurs).

This is when closing Syncthing, as opposed to logging off / shutting down windows? (There's a similar issue where the embedded Chromium component crashes hard in this scenario, see cefsharp/CefSharp#800).
Is there more to the debug log that you can paste (giving me more googlable terms)? Is there anything in %APPDATA\SyncTrayzor\SyncTrayzor.log that's relevant?

Oh, and anything in the event log? Crashes normally end up with something in there....

Well, I got this crash only twice so far, but if I remember correctly, this always happened when SyncTrayzor was minimized to the system tray (no sync was occuring, Syncthing was idling) and I stopped it by right-clicking on the icon and choosing "Exit". This is the whole debug.log:
[0307/215321:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0307/215436:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0307/215616:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0307/215905:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0307/220029:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0307/220455:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0308/162633:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0308/163002:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0308/221218:ERROR:renderer_main.cc(227)] Running without renderer sandbox
[0308/221734:ERROR:renderer_main.cc(227)] Running without renderer sandbox

So nothing new here. SyncTrayzor.log also doesn't show anything interesting as the last entry there is written a few minutes before the crash.
However, I totally forgot about the event log (thanks for mentioning it!) which in fact shows two errors when the crash happened:
Red error with ".NET Runtime" as source:
Anwendung: SyncTrayzor.exe
Frameworkversion: v4.0.30319
Beschreibung: Der Prozess wurde aufgrund eines Ausnahmefehlers beendet.
Ausnahmeinformationen: System.Reflection.TargetInvocationException
Stapel:
   bei System.RuntimeMethodHandle.InvokeMethod(System.Object, System.Object[], System.Signature, Boolean)
   bei System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(System.Object, System.Object[], System.Object[])
   bei System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
   bei Stylet.ViewManager.CreateViewForModel(System.Object)
   bei Stylet.ViewManager.CreateAndBindViewForModel(System.Object)
   bei Stylet.WindowManager.CreateWindow(System.Object, Boolean)
   bei Stylet.WindowManager.ShowDialog(System.Object)
   bei System.Windows.Threading.Dispatcher.CatchException(System.Exception)
   bei MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   bei System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame)
   bei System.Windows.Application.RunInternal(System.Windows.Window)
   bei System.Windows.Application.Run()
   bei SyncTrayzor.App.Main()

Red error with "Application Error" as source:
Name der fehlerhaften Anwendung: SyncTrayzor.exe, Version: <IP_ADDRESS>, Zeitstempel: 0x54fbc1d8
Name des fehlerhaften Moduls: KERNELBASE.dll, Version: 6.3.9600.17415, Zeitstempel: 0x54505737
Ausnahmecode: 0xe0434352
Fehleroffset: 0x0000000000008b9c
ID des fehlerhaften Prozesses: 0x2320
Startzeit der fehlerhaften Anwendung: 0x01d059e54a74ba8d
Pfad der fehlerhaften Anwendung: D:\Programme\Internet\SyncTrayzorPortable\SyncTrayzor.exe
Pfad des fehlerhaften Moduls: C:\Windows\system32\KERNELBASE.dll
Berichtskennung: f50023a6-c5d8-11e4-8380-00241dce9ad3
Vollständiger Name des fehlerhaften Pakets:
Anwendungs-ID, die relativ zum fehlerhaften Paket ist:

Here is some discussion about the error:
https://code.google.com/p/chromiumembedded/issues/detail?id=524#c4
https://github.com/atom/atom-shell/issues/22
https://github.com/ValveSoftware/steam-for-linux/issues/3620
However, after reading the second link, I'm not so sure anymore that this crash was really caused by the WebKit component :-/. On the other hand, "MS.Win32.UnsafeNativeMethods.DispatchMessage" for example seems to point to WPF (or rendering a Windows in general).

I also found the second crash in the event log (this was for version 1.0.5 of Synctrayzor):
Red error with ".NET Runtime" as source:
Anwendung: SyncTrayzor.exe
Frameworkversion: v4.0.30319
Beschreibung: Der Prozess wurde aufgrund eines Ausnahmefehlers beendet.
Ausnahmeinformationen: System.ObjectDisposedException
Stapel:
   bei StyletIoC.Internal.Container.GetRegistrations(StyletIoC.Internal.TypeKey, Boolean)
   bei StyletIoC.Internal.Container.Get[[System.__Canon, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.String)
   bei SyncTrayzor.Bootstrapper.OnUnhandledException(System.Windows.Threading.DispatcherUnhandledExceptionEventArgs)
   bei System.Windows.Threading.Dispatcher.CatchException(System.Exception)
   bei MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   bei System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
   bei MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)
   bei MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)
   bei System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame)
   bei System.Windows.Application.RunInternal(System.Windows.Window)
   bei System.Windows.Application.Run()
   bei SyncTrayzor.App.Main()

Red error with "Application Error" as source:
Name der fehlerhaften Anwendung: SyncTrayzor.exe, Version: <IP_ADDRESS>, Zeitstempel: 0x54fb22ec
Name des fehlerhaften Moduls: KERNELBASE.dll, Version: 6.3.9600.17415, Zeitstempel: 0x54505737
Ausnahmecode: 0xe0434352
Fehleroffset: 0x0000000000008b9c
ID des fehlerhaften Prozesses: 0x1830
Startzeit der fehlerhaften Anwendung: 0x01d05918bd8c7882
Pfad der fehlerhaften Anwendung: D:\Programme\Internet\SyncTrayzorPortable\SyncTrayzor.exe
Pfad des fehlerhaften Moduls: C:\Windows\system32\KERNELBASE.dll
Berichtskennung: 0d3af21d-c50c-11e4-8380-00241dce9ad3
Vollständiger Name des fehlerhaften Pakets:
Anwendungs-ID, die relativ zum fehlerhaften Paket ist:

This crash seems to be linked to the IoC container you are using, but it also for example contains the "MS.Win32.UnsafeNativeMethods.DispatchMessage" entry in the trace stack.

Thanks! That 3rd stack trace, with the IoC container in it, is because we get an exception on shutdown. The IoC container's already been disposed, but then we try and create a dialog to display an exception... And get another exception. We should have logged to SyncTrayzor.log to that point, but maybe it hadn't flushed - I'll fix that. This means that the exception is occurring after the application's started exiting.
The other .NET exception - the 1st stack trace - is similar. We're trying to display the 'unhandled exception' dialog, and falling over (since this is on application shutdown, this is not so surprising). But again we should have logged the exception by this point.
I'm not sure whether the "Application Error" stack traces are the root cause of the problem, or are as a result of the unhandled exception handler throwing an exception. I'll:

Flush the log after writing an error. That should give us a decent "original error" stack trace.
Not try and display an error dialog if the application is shutting down. This should prevent that second crash.

Regarding the 3rd stack trace: I think I could reproduce this crash. It happens when one exits SyncTrazor before everything is loaded completely (especially the GUI of Syncthing).
So far I couldn't reproduce the first crash (with the first stack trace), but as you said it should be something similiar.
Regarding the "Application Error" stack traces: I think they are a result of the unhandled exception as the event log says each "Application Error" and its appropriate .NET Runtime error occured at the exact same time.
All in all I'm not sure anymore that these crashes have anything to do with the WebKit component because the error message I mentioned in my first post always seems to be written to the debug.log when there's a crash (maybe I should rename the title?).

Re the "Application Error" - there's two exceptions going on here. There's a first unhandled exception. SyncTrayzor tries to handle this, in order to log it and display a nice dialog to the user. This second logging-and-displaying step then fails with an error (because the application is shutting down).
The .NET stack trace you see is the second exception - the one we encounter while trying to display the first exception. I'm not sure whether the Application Error refers to the first exception or the second one.
I tried following your instructions to reproduce without success. If it's working for you, however, then great. Wait for the next release (hopefully coming out tomorrow), repro, and let's see what the error log contains that time.

1.0.7 contains the logging we need. Would you mind upgrading, and report back if/when you mange to repro/see it happen again? Thanks!

Ok, here are the interesting parts from Synctrazor.log (from the "logs" subfolder):
2015-03-10 15:49:33.4690 [Debug] SyncTrayzor.SyncThing.SyncThingProcessRunner: [JEMTR] 15:49:33 INFO: Starting web GUI on http://<IP_ADDRESS>:8384/
2015-03-10 15:49:33.7112 [Info] SyncTrayzor.SyncThing.SyncThingApiClient: Requesting API shutdown
2015-03-10 15:49:33.9720 [Debug] SyncTrayzor.SyncThing.SyncThingProcessRunner: [JEMTR] 15:49:33 INFO: Starting UPnP discovery...
2015-03-10 15:49:34.2239 [Info] SyncTrayzor.SyncThing.SyncThingProcessRunner: Syncthing process stopped with exit status -1
2015-03-10 15:49:34.2239 [Error] SyncTrayzor.Bootstrapper: An unhandled exception occurred System.ComponentModel.Win32Exception Zugriff verweigert Void Kill()    bei System.Diagnostics.Process.Kill()
   bei StyletIoC.Internal.Registrations.SingletonRegistration.<.ctor>b__0(Object o, EventArgs e)
   bei System.EventHandler.Invoke(Object sender, EventArgs e)
   bei Stylet.Bootstrapper`1.Dispose()
   bei System.Windows.ExitEventHandler.Invoke(Object sender, ExitEventArgs e)
   bei System.Windows.Application.DoShutdown()
   bei System.Windows.Application.ShutdownImpl()
   bei System.Windows.Application.ShutdownCallback(Object arg)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   bei MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler) System.ComponentModel.Win32Exception (0x80004005): Zugriff verweigert
   bei System.Diagnostics.Process.Kill()
   bei StyletIoC.Internal.Registrations.SingletonRegistration.<.ctor>b__0(Object o, EventArgs e)
   bei System.EventHandler.Invoke(Object sender, EventArgs e)
   bei Stylet.Bootstrapper`1.Dispose()
   bei System.Windows.ExitEventHandler.Invoke(Object sender, ExitEventArgs e)
   bei System.Windows.Application.DoShutdown()
   bei System.Windows.Application.ShutdownImpl()
   bei System.Windows.Application.ShutdownCallback(Object arg)
   bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   bei MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)

It seems that stopping/killing the Syncthing process leads to this exception. As far as I can tell the IoC container is also involved here, so maybe the singleton (which I guess is a reference to the Syncthing process) isn't initalized yet (because I stopped Synctrayzor while Syncthing was still starting)?
But as I said this crash only occurs when I exit Synctrayzor as fast as possible after the start of the program, so this maybe doesn't reflect the "normal" use of the program :).

Still worth fixing! The IoC container is only there before disposing it disposes all the singletons it owns, and one of those singletons's Dispose methods is throwing an exception.
What happens is that the Syncthing process dies (because we ask it to shut down). We normally detect the fact that it's dead and clear our reference to its process, but for some reason that isn't happening here (there's no lock on that field, so "threading" is probably to blame). We then try and kill it again, and that's falling over with a Win32Exception with 'Access Denied', which the docs say can occur if "The process is terminating." - which looks like the case here.
So, it's harmless, but we shouldn't be crashing! I'll put a proper memory barrier around that field, and catch Win32Exceptions there just to be sure.

Right, that commit should fix it, when it makes it into a release.
When that release comes out, even if SyncTrayzor doesn't crash, I'd still be interested in seeing the log after you've tried to repro. I want to see whether the "Killinternal failed with an error" message appears.

OK, I'll try it again when the new version is released.
If there are still any crashes (and I'm the only one to reproduce them), I'll probably try to debug them as I have installed Visual Studio 2013 anyway.

Great, thank you!

Ack, bad choice of words in the commit comment - didn't mean to close the issue.
Think I tracked it down. Cause was closing SyncTrayzor after never having run Syncthing. Should be fixed in v1.0.8, just released.

I can confirm that this crash seems to be fixed. Thanks!
I haven't been able to reproduce the first crash ("System.Reflection.TargetInvocationException"), so I'm not sure if this was also fixed (as a side effect) or if this is another issue. I'll propably open a new issue if I encounter the first crash again (and can reproduce it), so I think this issue can be closed.

There were two issues here. The first, root, issue is the crash on exit, which a5055b0 fixed. Then there was a second issue where we tried to handle this error (displaying a dialog to the user), but that crashed because we were shutting down when we tried to do that. The first few stack traces we looked at were this second "derivative" error - different things were failing, but all because the application was exiting at the time. This second "derivative" error was masking the first - its stack trace was being recorded, instead of the first error's stack trace - so I had to fix that first.


Feature request: convert artifacts to use Windows Package Manager (winget)

Replace Chocolately with WinGet where possible.
https://github.com/microsoft/winget-cli

@DanBrown-TechSmith, the winget-cli project seems to be in Preview, can you provide an example of the change that would have to be made?

This was just a thought for future consideration since I know WinGet is a new thing.  It would require using WinGet rather than Chocolately to install artifact packages.
From: leovms<EMAIL_ADDRESS>Sent: Friday, May 22, 2020 8:20 PM
To: Azure/azure-devtestlab<EMAIL_ADDRESS>Cc: Brown, Dan<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-devtestlab] Feature request: convert artifacts to use Windows Package Manager (winget) (#657)
@DanBrown-TechSmithhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDanBrown-TechSmith&data=02|01||3a3b46616d84438a2f7a08d7feaef8d0|77d3096378724d1193742c2b2a12ad65|0|0|637257899802072846&sdata=Gdd0N5RU3idMhS1K7JiSglxTHz2xtFAnHHgKx6iOFjQ%3D&reserved=0, the winget-cli project seems to be in Preview, can you provide an example of the change that would have to be made?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-devtestlab%2Fissues%2F657%23issuecomment-632952901&data=02|01||3a3b46616d84438a2f7a08d7feaef8d0|77d3096378724d1193742c2b2a12ad65|0|0|637257899802072846&sdata=gUWp49dCseETeD1czPJ1ANAFJ0VfaDTyjqyzcptT1es%3D&reserved=0, or unsubscribehttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABG3C5YI7WVYSSAVNSOGXWDRS4JBNANCNFSM4NF5MTLA&data=02|01||3a3b46616d84438a2f7a08d7feaef8d0|77d3096378724d1193742c2b2a12ad65|0|0|637257899802082841&sdata=z4MyZQsVqaGiB9H7mPsxoUByB%2FfNX4m4%2FkNBhJmWtM4%3D&reserved=0.

I like the idea!  Although WinGet seems to be currently for Windows 10 only:  https://docs.microsoft.com/en-us/windows/package-manager/  ..  Artifacts get typically applied to both client & server Windows operating systems.  I would assume that we could only move artifacts over to WinGet if it was available on all the Windows operating systems that Artifacts already support?

I just stumbled upon this and, while I know it's an old issue, it's still open.
Interested to know the use case for this asit hasn't been added.


[#155463715] Move global manifest properties to specific jobs

#155463715 Move global manifest properties to specific jobs
What?
In order to move closer to the manifests from cf-deployment we want to move all the global properties
to each specific job in the manifest.
How to review
This change is meant to result in no real changes in the deployment,
a No-Op.
To test the deployment:

Deploy from master (be sure this branch is rebased)
Deploy this branch

bosh would display a lot of changes in the properties diff, but then it would be a no-op, no VM would be updated at all.
all test should pass

Verify the new manifest
We have created a set of tool scripts in the repo https://github.com/keymon/paas-cf-release-reference/tree/master/scripts
You can check that the new manifest is equivalent by using the script  https://github.com/keymon/paas-cf-release-reference/blob/master/scripts/manifest_to_specific_properties.rb. This script, given a rendered cf-manifest.yml and a directory with all the releases spec (e.g. /tmp/releases/capi-release/jobs/*/spec) would generate a manifest with the properties in each job.
To use it:
git clone https://github.com/keymon/paas-cf-release-reference
cd paas-cf-release-reference

Generate the manifest based on master, and expand the variables into each specific job using the spec_job:
PAAS_CF_PATH=~/gds/paas-cf

( cd $PAAS_CF_PATH && git checkout master )

spruce merge \
    $PAAS_CF_PATH/manifests/cf-manifest/manifest/*.yml \
    <($PAAS_CF_PATH/manifests/cf-manifest/scripts/grafana-dashboards-manifest.rb $PAAS_CF_PATH/manifests/cf-manifest/grafana/) \
    <(ruby $PAAS_CF_PATH/terraform/scripts/generate_vpc_peering_manifest.rb "$PAAS_CF_PATH/terraform/prod.vpc_peering.json"
) \
    < $PAAS_CF_PATH/manifests/cf-manifest/stubs/datadog-nozzle.yml \
    < $PAAS_CF_PATH/manifests/cf-manifest/stubs/oauth.yml \
    > spruced-manifest.yml

RELEASES_DIR=./releases-spec/ ./scripts/manifest_to_specific_properties.rb ./spruced-manifest.yml > expanded-spruced-manifest.yml

The file expanded-spruced-manifest.yml will be our reference.
Now generate the manifest based on current brach:
PAAS_CF_PATH=~/gds/paas-cf

( cd $PAAS_CF_PATH && git checkout move_properties_to_specific_jobs_155463715 )

spruce merge \
    $PAAS_CF_PATH/manifests/cf-manifest/manifest/*.yml \
    <($PAAS_CF_PATH/manifests/cf-manifest/scripts/grafana-dashboards-manifest.rb $PAAS_CF_PATH/manifests/cf-manifest/grafana/) \
    <(ruby $PAAS_CF_PATH/terraform/scripts/generate_vpc_peering_manifest.rb "$PAAS_CF_PATH/terraform/prod.vpc_peering.json"
) \
    < $PAAS_CF_PATH/manifests/cf-manifest/stubs/datadog-nozzle.yml \
    < $PAAS_CF_PATH/manifests/cf-manifest/stubs/oauth.yml \
    > spruced-manifest-v2.yml

Finally diff both manifests with spruce diff. There should not be any difference.
spruce diff \
 <(spruce merge --prune meta expanded-spruced-manifest.yml) \
 <(spruce merge --prune meta spruced-manifest-v2.yml)  | less -R

Verify removed properties:
You can use the script https://github.com/keymon/paas-cf-release-reference/blob/master/scripts/print_all_properties_in_manifest.rb to print the properties that are defined somewhere in a manifest:
./scripts/print_all_properties_in_manifest.rb spruced-manifest.yml > spruce-manifest.properties.txt
./scripts/print_all_properties_in_manifest.rb spruced-manifest-v2.yml > spruce-manifest-v2.properties.txt

diff spruce-manifest.properties.txt spruce-manifest-v2.properties.txt

Who?
Anyone but @keymon or @LeePorte

Reviewer: please ignore this comment, it is slightly unrelated to the PR.
@alext We can see the current differences with cf-deployment using:
PAAS_CF_PATH=~/gds/paas-cf

spruce merge \
    $PAAS_CF_PATH/manifests/cf-manifest/manifest/000-base-cf-deployment.yml \
    $PAAS_CF_PATH/manifests/cf-manifest/manifest/010-cf-jobs.yml \
    > current.yml

wget https://raw.githubusercontent.com/cloudfoundry/cf-deployment/master/cf-deployment.yml -O cf-deployment.yml

spruce diff <(spruce merge --prune meta current.yml)  cf-deployment.yml  | less -R

I successfully validated, that there are no deployment changes, when I deploy from this branch (after deploying from master):
Task 2644 | 09:30:18 | Preparing deployment: Preparing deployment (00:00:09)
Task 2644 | 09:30:47 | Preparing package compilation: Finding packages to compile (00:00:01)

Task 2644 Started  Mon Mar 12 09:30:18 UTC 2018
Task 2644 Finished Mon Mar 12 09:30:48 UTC 2018
Task 2644 Duration 00:00:30
Task 2644 done

Succeeded

I fixed the comments above as suggested, except the more general idea of having a central source for config.
I am running the pipeline from scratch in my environment

@alext @dcarley @bandesz Do we proceed? :thinking:


SCEM

Will there be a guide for SCEM ?

Hi, this guide has already added. Please install updates.

I saw you guys added but, when he doing the back attacks, it doesn't specify if it's 4 times or 3 times or 2 times. Fix maybe?

This should be fixed in latest versions. Most of the work is in progress, many may not work.


Nenio Dialog Get Stuck

Describe the bug
This only happen to Nenio where I get "stuck" after finished talking with her which I can't select "I have to go" to end the conversation.
To Reproduce
Steps to reproduce the behavior:
Talk to Nenio
Finish dialog by selecting "I have to go" or whatever it is to end the conversation
Save Files
Manual_34_Drezen__30_Abadius__I__4716__18_48_33.zip
Settings
Settings.zip
Version Info:

ToyBox Version: 1.4.13 (Updated Yesterday 12/7/21
OS: Windows 10 21H1 19043.1387

Additional context
The save file is "clean" I only have ToyBox, NoFilmGrain and ChampionFeat Mods
Thanks!

same problem. seems to be an issue with preview dialog result. once you talk to her with that option enabled you cannot leave conversation, even if you disable the preview or turn off the mod via umm menu.

Just wanted to add that I narrowed this down to dialogue fixes:

make previously chosen answers more clear
expand answers for conditional responses
disable dialogue restrictions (both)

Disabling them before talking to Nenio allows exiting dialogue as normal.

This same issue can appear on other dialogue as well. Didn't run into it on Nenio, but Anevia instead
As pointed out by the previous comment, disabling the dialogue fixes mentioned allows exiting the dialogue as normal.
I went a step further, and reenabled all of them one by one. It only broke again after enabling

expand answers for conditional responses

So it appears to be caused by something related to that particular setting.


mounts with "bind,nosuid" won't apply nosuid

Hello,
Few times in uwsgi_it_api/uwsgi_it_api/templates/vassal.ini there is used hook similar to this:
; map /run
hook-as-root = mount:none /containers/{{container.uid}}/run /run bind,nosuid

According to man 8 mount the mount syscall can't handle additional options after "bind" - using bind it is nessecary to call mount second time, with "remount" and other options. (This is handled transparently by /usr/bin/mount).
I tested this under Debian Jessie, with kernel 3.16.7-ckt11-1+deb8u6. This configuration:
; mount bind /var/www
hook-as-root = mount:none /.old_root/containers/test1/www /var/www bind,nosuid,nodev,noexec

still allowed me to run executables with suid bit from /var/www.
This one:
; mount bind /var/www
hook-as-root = mount:none /.old_root/containers/test1/www /var/www bind,nosuid,nodev,noexec

did not.
I am not sure if this could be considered as a bug.

Well if suid apps can be run in a container it is a security problem (expecially for users having their custom distros). I think your second config misses a line (the one where we remount the dir). Would you like to paste a working configuration ?

I think your second config misses a line (the one where we remount the dir).

Yes, you are right, sorry! I meant to paste there snippet with remount.

Well if suid apps can be run in a container it is a security problem

I don't have full uwsgi.it installation so I cannot be 100% sure, but I don't think this is that severe. You still have to smuggle somehow binary with suid bit - you can't smuggle it in custom distro because only root directory is bind-mounted, and root directory is correctly remounted later with nosuid option.
In this configuration only 3 directories could hold suid binaries: /run, /tmp and /var/tmp.
In my opinion this is more of a documentation issue. Its just the way linux mount syscall works - if there is a bind option it will ignore any other options (not only "nosuid", but things like "ro" too). Maybe uwsgi should throw warning / error if bind mount has additional options specified.
Anyway, I prepared something you could call minimal repro case: https://gist.github.com/hiciu/8739c2f0c94296395aa6e629438bf045
On my uwsgi "bind,nosuid" is not enough to prevent suid executables from being executed. Here is output with only "bind,nosuid":
[uWSGI] getting INI configuration from emperor.ini
*** Starting uWSGI <IP_ADDRESS> (64bit) on [Thu Jun 23 17:36:00 2016] ***
compiled with version: 6.1.1 20160602 on 15 June 2016 01:14:13
os: Linux-4.6.2-1-ARCH #1 SMP PREEMPT Wed Jun 8 08:40:59 CEST 2016
nodename: unknown
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 4
current working directory: /home/hiciu/scratchspace/2016-06/23/uwsgi
detected binary path: /usr/bin/uwsgi
uWSGI running as root, you can use --uid/--gid/--chroot options
*** WARNING: you are running uWSGI as root !!! (use the --uid flag) ***
your processes number limit is 63993
your memory page size is 4096 bytes
detected max file descriptor number: 4096
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
*** starting uWSGI Emperor ***
*** has_emperor mode detected (fd: 6) ***
*** RRDtool library available at 0xd3cc30 ***
your mercy for graceful operations on workers is 60 seconds
*** Operational MODE: no-workers ***
spawned uWSGI master process (pid: 74577)
[uWSGI] getting INI configuration from test.ini
*** Starting uWSGI <IP_ADDRESS> (64bit) on [Thu Jun 23 17:36:00 2016] ***
compiled with version: 6.1.1 20160602 on 15 June 2016 01:14:13
os: Linux-4.6.2-1-ARCH #1 SMP PREEMPT Wed Jun 8 08:40:59 CEST 2016
nodename: unknown
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 4
current working directory: /home/hiciu/scratchspace/2016-06/23/uwsgi/vassals
detected binary path: /usr/bin/uwsgi
running "callret:chdir /" (pre-jail)...
uWSGI running as root, you can use --uid/--gid/--chroot options
running "mount:none none / recursive,private" (post-jail)...
running "mount:none /var/lib/machines/stretch /tmp/ns bind,nosuid" (post-jail)...
re-fork()ing...
running "mount:proc none /proc" (as root)...
running "umount:/.old_root recursive,detach" (as root)...
setgid() to 100
setuid() to 1000
running "exec:/test" (as user)...
-rwsr-sr-x 1 root root 6792 Jun 23 15:35 /test
0
/dev/mapper/vgssd-rootfs on / type ext4 (rw,relatime,data=ordered)
none on /proc type proc (rw,relatime)
your processes number limit is 63993
your memory page size is 4096 bytes
detected max file descriptor number: 4096
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
The -s/--socket option is missing and stdin is not a socket.
Thu Jun 23 17:36:00 2016 - [emperor] curse the uwsgi instance test.ini (pid: 74580)
Thu Jun 23 17:36:00 2016 - [emperor] removed uwsgi instance test.ini

(as you can see /test was executed with root privileges)
Here is output with "bind,nosuid" and "remount,nosuid":
[uWSGI] getting INI configuration from emperor.ini
*** Starting uWSGI <IP_ADDRESS> (64bit) on [Thu Jun 23 17:39:42 2016] ***
compiled with version: 6.1.1 20160602 on 15 June 2016 01:14:13
os: Linux-4.6.2-1-ARCH #1 SMP PREEMPT Wed Jun 8 08:40:59 CEST 2016
nodename: unknown
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 4
current working directory: /home/hiciu/scratchspace/2016-06/23/uwsgi
detected binary path: /usr/bin/uwsgi
uWSGI running as root, you can use --uid/--gid/--chroot options
*** WARNING: you are running uWSGI as root !!! (use the --uid flag) ***
your processes number limit is 63993
your memory page size is 4096 bytes
detected max file descriptor number: 4096
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
*** starting uWSGI Emperor ***
*** RRDtool library available at 0x1a3ec30 ***
your mercy for graceful operations on workers is 60 seconds
*** Operational MODE: no-workers ***
spawned uWSGI master process (pid: 74893)
*** has_emperor mode detected (fd: 6) ***
[uWSGI] getting INI configuration from test.ini
*** Starting uWSGI <IP_ADDRESS> (64bit) on [Thu Jun 23 17:39:42 2016] ***
compiled with version: 6.1.1 20160602 on 15 June 2016 01:14:13
os: Linux-4.6.2-1-ARCH #1 SMP PREEMPT Wed Jun 8 08:40:59 CEST 2016
nodename: unknown
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 4
current working directory: /home/hiciu/scratchspace/2016-06/23/uwsgi/vassals
detected binary path: /usr/bin/uwsgi
running "callret:chdir /" (pre-jail)...
uWSGI running as root, you can use --uid/--gid/--chroot options
running "mount:none none / recursive,private" (post-jail)...
running "mount:none /var/lib/machines/stretch /tmp/ns bind,nosuid" (post-jail)...
re-fork()ing...
running "mount:proc none /proc" (as root)...
running "umount:/.old_root recursive,detach" (as root)...
running "mount:none none / remount,nosuid" (as root)...
setgid() to 100
setuid() to 1000
running "exec:/test" (as user)...
-rwsr-sr-x 1 root root 6792 Jun 23 15:35 /test
1000
/dev/mapper/vgssd-rootfs on / type ext4 (rw,nosuid,relatime,data=ordered)
none on /proc type proc (rw,relatime)
your processes number limit is 63993
your memory page size is 4096 bytes
detected max file descriptor number: 4096
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
The -s/--socket option is missing and stdin is not a socket.
Thu Jun 23 17:39:43 2016 - [emperor] curse the uwsgi instance test.ini (pid: 74896)
Thu Jun 23 17:39:43 2016 - [emperor] removed uwsgi instance test.ini

(nosuid worked, /test was executed as user)


Additional component request - TreeView

Can we have TreeView component in the collection?

Sure, seems like we could implement it as styled nested list

I agree, but this looks good too
https://github.com/arnedesmedt/vue-ads-table-tree
https://jsfiddle.net/arnedesmedt/7my8L42q
And using tailwind.

Let's stop here for now.


[ScopedCssBaseline] Allow css to be only applied on children

[x] I have followed (at least) the PR section of the contributing guide.

Fixes #19657
Fixes #17244

I'm not sure why the test:umd fails, seems like a timeout. It works on my local computer

Note 1. We might want to use withStyles over the hook to fix 17244
Note 2. I don't understand why we use font weight: 'bolder' over the value from the theme
Note  3. For v5, I have started to gather ideas for the reset: https://trello.com/c/U5K9pVIC/2001-improve-css-reset

I think the title or the description should mention that a new component has been added.

@joshwooding thanks for the tip


merge master back to 2.8

@kailuowang
Thanks for some reviews!
Is this PR required for the release of "0.10.7-PLAY2.8"?

@kailuowang Thanks for some reviews! Is this PR required for the release of 0.10.7-PLAY2.8 ?

That's right. Although I don't have the time to figure out what failed the build.

@kailuowang
This appears to be due to 0.10.7-SNAPSHOT being defined in versions.sbt on the play2.8 branch.
Rebasing the play2.8 branch in master or defining 0.10.7-SNAPSHOT in versions.sbt and specifying the same version in example/project/plugins.sbt seems to solve the problem.
https://github.com/Javakky-pxv/play-swagger/pull/3

Thanks


Can't create iOS Archives when using Tangram-es binary framework because of bitcode weirdness

Went through testing Xcode's archive generation (which is how most independent developers generate their IPAs to distribute) and I get this error:

This seems to be related to an error I ran across before, describe here: (https://github.com/Alamofire/Alamofire/issues/835#issuecomment-145404118) but wasn't able to reliably reproduce it. It seems that in Xcode 8, bitcode generation for regular builds versus archives is a different process.
When I attempt to reproduce this by building the ios-sdk I get a slightly different error:
2016-12-06 15:06:31 +0000 [MT] Presenting: Error Domain=IDEFoundationErrorDomain Code=1 "Failed to verify bitcode in TangramMap.framework/TangramMap:
error: Bundle only contains bitcode-marker /var/folders/ty/20jr0dzn5_z9s6vw3ttczj400000gp/T/XcodeDistPipeline.epy/Root/Payload/ios-sdk.app/…" UserInfo={NSLocalizedDescription=Failed to verify bitcode in TangramMap.framework/TangramMap:
error: Bundle only contains bitcode-marker /var/folders/ty/20jr0dzn5_z9s6vw3ttczj400000gp/T/XcodeDistPipeline.epy/Root/Payload/ios-sdk.app/…}

I believe this is the actual error, and the test project I'm using is obfuscating that.
To Reproduce the first error:

Download the Tangram-es binary framework from https://github.com/tangrams/ios-framework
Start a new iOS project
Add the binary framework and make sure to embed the binary in xcode like so:

Attempt to archive the build (Product Menu -> Archive)

Or you could just use this project I made (you'll have to change the codesigning credentials for this one):
test-tangram-archive.zip
To reproduce the ios-sdk you'll need to follow the directions at https://github.com/mapzen/ios and then once you've pod installed and everything, attempt to archive the build.

Can you give a look at the different options within the xcode project when generating bitcode from here?
Also make sure that the framework has actually bitcode within the binary after being built,
for example:
otool -l build/ios-framework/lib/Release/libcore.a | grep __LLVM

Or any other relevant flags that makes sure that bitcode is enabled on every single binary.

At a first look it looks like the framework you gave in the .zip doesn't have bitcode compared to the one that is built on my local machine:
▶ otool -l /Users/karim/Downloads/test-tangram-archive/test-tangram-archive/TangramMap.framework/TangramMap | grep __LLVM

▶ otool -l /Users/karim/dev/tangram-es/build/ios-framework/lib/Debug/TangramMap.framework/TangramMap | grep __LLVM
  segname __LLVM
   segname __LLVM
  segname __LLVM
   segname __LLVM
  segname __LLVM
   segname __LLVM

Another thing to look at would be this step in the build system:
https://github.com/tangrams/tangram-es/blob/master/Makefile#L343
It seems possible that lipo breaks the bitcode.

Seems like at initial inspect, lipo might be the culprit.
Arnor:tangram-es Smollinger$ otool -l /Users/Smollinger/coding/git_projects/tangram-es/build/ios-framework-universal/Release/TangramMap.framework/TangramMap | grep __LLVM
Arnor:tangram-es Smollinger$ otool -l /Users/Smollinger/coding/git_projects/tangram-es/build/ios-framework/lib/Release/TangramMap.framework/TangramMap | grep __LLVM
  segname __LLVM
   segname __LLVM
  segname __LLVM
   segname __LLVM
  segname __LLVM
   segname __LLVM

@karimnaaji looks like we might actually be OK, kinda. I found this  post detailing some of the issues<EMAIL_ADDRESS>

Per that post, we just need to add -fembed-bitcode and that should make it happy, or use "BITCODE_GENERATION_MODE" which is also mentioned in the Alamofire link I mentioned in my original post. They went with BITCODE_GENERATION_MODE but I think either should be fine?

Can you give a try with this framework, generated from this branch https://github.com/tangrams/tangram-es/tree/ios-add-bitcode-flag.
Bad news is that even if the otool segname were visible and ENABLE_BITCODE set to YES the bitcode didn't seem to actually be generated, this framework raised up to the size of ~50Mb with the custom flag passed to all libraries.. :/

Tested this, and works great on my local machine. The ~50MB library size doesn't come through at all locally - the Mapzen iOS sample app size is around 7MB total with all the other libraries and imagery included in that. I am still investigating some weirdness with CircleCI producing extra large images but that seems to be to do with whatever command it's running.

Can you rebase this branch and open a PR for it?

@karimnaaji I'm still getting the bitcode error with version 0.7.2 binary downloaded from http://ios.mapzen.com/ - was this issue really systematically fixed?

@Buthrakaur Thanks for the note. We recently overhauled the entire build process for iOS, so it's possible we introduced a regression. I am also seeing the issue now.
ld: bitcode bundle could not be generated because '/Users/Smollinger/coding/git_projects/ios-sdk/Pods/Tangram-es/TangramMap.framework/TangramMap' was built without full bitcode. All frameworks and dylibs for bitcode must be generated from Xcode Archive or Install build for architecture arm64

@msmollin it's strange that the binary distributed via CocoaPods seems to be ok regarding bitcode support.

Hmmm I am seeing the issues on 0.7.1 distributed via Cocoapods when integrated in our Mapzen iOS SDK sample app. We haven't updated to 0.7.2 in that - I will take a look and see about that today.

hey @Buthrakaur, the S3 deployed version available on http://ios.mapzen.com/ is a debug version and we don't produce bitcode when we build for Debug. Is there any reason you would need bitcode support for Debug frameworks?

I must've had a debug version installed as well. I rm -rf Pods and re-installed, and now 0.7.1 from Cocoapods is installing correctly.

@karimnaaji thanks for explanation. We had to workaround some CocoaPods issue so we used distribution from the web site. Nothing indicates it's a Debug version so I thought it's Release. Does it make sense to publish only Debug version on the website? I'd expect Release version or both... or at least some mention it's a Debug version.

Hmmmm isn't anything under tangram-releases ( http://ios.mapzen.com/raw.html?prefix=tangram-releases/ ) a release build @karimnaaji ?
@Buthrakaur Can you try one from under the releases directory? That's what the Podspec is using - https://github.com/tangrams/tangram-es/blob/master/platforms/ios/framework/Tangram-es.podspec#L15

Right the naming should reflect the build type, https://github.com/tangrams/tangram-es/pull/1594 should give enough information. We decided to only provide Debug build for snapshots for development (we don't expect users to publish/archive from a snapshot) and Release build  for releases (with bitcode is enabled), available from both CocoaPods and the webside.
@msmollin yep those are Release builds.

I see - so it's just misunderstanding of the website on my side.. Little Debug vs Release on the site would help though. Thanks for your support.


Update docs for CRIContainerLogRotation

This is a draft PR for graduating CRIContainerLogRotation to GA.
KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2411-cri-container-log-rotation
k/k PR: https://github.com/kubernetes/enhancements/pull/2547
Signed-off-by: Urvashi Mohnani<EMAIL_ADDRESS>

/assign @tengqm
/sig node
/hold until kubernetes/kubernetes#99651 merges

/hold cancel
The upstream PR is in.

This is not ready yet, just made a tiny change to open a draft placeholder docs PR. Will update tomorrow but adding hold for now.
/hold

sorry, my original review wasn't complete. I added some suggestions on what topics might be good to cover. And I suggest to move the new section to the appropriate page

/remove-language es ja pt zh

Addressed all the comments, @SergeyKanzhelev @tengqm PTAL

beside a small suggestion lgtm

/lgtm

@tengqm @reylejano would appreciate an approve here please

/approve
Thanks.


Move integration tests for Testerina which use standard libs to distribution repository

Description:
Move integration tests for Testerina which use standard libs to distribution repository

[x] Basic Cases Test - Config Api Test
[x] Services Test

Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

https://github.com/ballerina-platform/ballerina-distribution/pull/922

https://github.com/ballerina-platform/ballerina-distribution/pull/948


PUT large object doesn't create custom metadata

When I create large objects, the metadata doesn't seem to be created. For example, a 12mb file I transfer to a S3rver instance creates a .dummys3_metadata whose contents are {"contentType":"binary/octet-stream","customMetaData":[]}.
Have you observed this issue before?

I can't reproduce this, I think I need a solid example. The test case for custom metadata still succeeds when I modified to put a 12mb buffer instead?

@whereandy We can probably address this issue fastest if you provide us a small repository with the minimal amount of code and assets needed to reproduce the issue.


Add validateField in Get Started section

Right now there is only validateForm in Overview.
Edit

"Finally apply validation when your data needs to be validate (e.g. a submit event handler):"
...

and introduce validateField with an example.

Hi @crsanti would you be willing to discuss over documentation structure? What do you consider is the difference between 'Get started' and 'Tutorial' ? How do you think we can make the docs to be the easier for the user to read and find what he's looking for?

About this is just an issue on the actual documentation, is missing a validateField sample


Add Recent or Time Sort Order to history list

The only sorting I can find for the received history is by the number of Hits. Would it be possible to add a Sort Order to each column AND (more important), Sort by Recent or by Time received?
Reason: When I hear but do not see a call (and the display starts to scan), I cannot determine where the last message received was from. Would be great to see a list of calls in the order they were received (Recent Ascending/Descending).

Hi there,
I'm not exactly sure what you're asking about. It seems to be about a particular piece of ham radio software. This page is for ORSSerialPort, which is a serial port code library used by Mac software developers, rather than any particular end-user application.
I write Aether (a ham radio logging app), but I don't think you're asking about that.
-Andrew

On Aug 31, 2021, at 11:19 AM, eli104 @.***> wrote:
The only sorting I can find for the received history is by the number of Hits. Would it be possible to add a Sort Order to each column AND (more important), Sort by Recent or by Time received?
Reason: When I hear but do not see a call (and the display starts to scan), I cannot determine where the last message received was from. Would be great to see a list of calls in the order they were received (Recent Ascending/Descending).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/armadsen/ORSSerialPort/issues/182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAICDF4MNFZTIDSCT7EMAIDT7UFIVANCNFSM5DESYN3Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sorry, it appears I may have jumped to the wrong branch.


Device not compatible in the car

I have a MBUX systeme on a mercedes, when i launch android auto on the car, i can't, i have a message witch say "uncompatible device" i have a pixel 7a

Does it work with a wired connection? Also, when do you see the message? Does it start the wireless connection to your phone before showing the message?

with my pixel 7a with a usb cable, android auto works. i have installed the pi0w image from your site on a pi zerow 1.1 i have tested with a samsung S20FE to, and so i have the same result "uncompatible device". When the raspberry start, the car lauch android auto, my phone is paired by bluetooth with "AA Wireless Key" and the message box appear with this uncompatible devic text message.


core: redefine opcode prices

Prices are defined in as a coefficients to BaseExecFee which
is defined by Policy contract. Native method prices are defined without need to multiply.
Close #1611 .

@AnnaShaleva, please review.


github-actions-indications - CSS is broken

Description

github-actions-indications's CSS is broken

How to replicate the issue + URL

See disabled workflow

https://github.com/134130/134130/actions/workflows/blank2.yml

See manual triggerable workflow

https://github.com/refined-github/refined-github/actions/workflows/release.yml

Extension version
24.4.9
Browser(s) used
Chrome

So they added a native "Disabled" text

I'll:

drop our "disabled" icon
check if we can preserve the "play" icon on disabled workflows


Entering a room without subscription creates frontend exception

When entering a room which the user is not subscribed to, a frontend exception is raised.
Reason is that the callback which tries to open the tab bar panel expects a subscription as parameter.

fixed

Fixed with https://github.com/mrsimpson/Rocket.Chat/commit/9a8935b01edeac31bad3f2b43fdaeebc669a4b7a


XGBoost version not compiled with GPU support [During CPU Inference Call]

Context
Train a simple XGB model, build a container with all the conda dependencies, and then deploy it into Kubernetes to generate a service; when doing offline inference with the model deployed, I'm getting common/common.h:239: XGBoost version not compiled with GPU support. exception, despite i am not trying to use GPU inference at all.
Repro Steps

Script to train xgboost model

from xgboost import XGBRegressor
from sklearn import datasets
import pandas as pd
import numpy as np

 def prepare_model_xgb2() -> Tuple[XGBClassifier, pd.DataFrame, pd.DataFrame]:
        iris = datasets.load_iris()
        df = pd.DataFrame(data=np.c_[iris["data"], iris["target"]], columns=iris["feature_names"] + ["target"])
        df.columns = [s.replace(" (CM)", "").replace(" ", "") for s in df.columns.str.upper()]

        input_cols = ["SEPALLENGTH", "SEPALWIDTH", "PETALLENGTH", "PETALWIDTH"]
        label_col = "TARGET"
        output_col = "PREDICTED_TARGET"

        # Separate features (X) and target variable (y)
        X = df[input_cols]
        y = df[label_col]

        # Create an XGBoost regressor
        clf_xgb = XGBRegressor(objective='reg:squarederror', seed=42, tree_method='hist')

        # Train the model
        clf_xgb.fit(X, y)

        return clf_xgb, X.head(10), df

Conda yaml for building container

channels:
- conda-forge
- nodefaults
dependencies:
- python==3.8.*
- absl-py==1.3.0
- anyio==3.5.0
- cloudpickle==2.0.0
- numpy==1.24.3
- packaging==23.0
- pandas==1.5.3
- pyyaml==6.0
- typing-extensions==4.5.0
- scikit-learn==1.3.0
- xgboost==1.7.3
- pyarrow
name: my-env

Stack trace

File \"/opt/conda/lib/python3.8/site-packages/xgboost/sklearn.py\", line 1139, in predict\n
return self.get_booster().predict(\n
File \"/opt/conda/lib/python3.8/site-packages/xgboost/core.py\", line 2163, in predict\n
_check_call(\n
File \"/opt/conda/lib/python3.8/site-packages/xgboost/core.py\", line 279, in _check_call\n
raise XGBoostError(py_str(_LIB.XGBGetLastError()))\n
xgboost.core.XGBoostError: [23:48:53] /croot/xgboost-split_1675457761144/work/src/data/../common/common.h:239: XGBoost version not compiled with GPU support.\n
Stack trace:\n
[bt] (0) /opt/conda/lib/libxgboost.so(+0xc01d4) [0x7fac9cab11d4]\n
[bt] (1) /opt/conda/lib/libxgboost.so(+0x1aaf12) [0x7fac9cb9bf12]\n
[bt] (2) /opt/conda/lib/libxgboost.so(xgboost::gbm::GBTree::ConfigureUpdaters()+0xdd) [0x7fac9cc53e9d]\n
[bt] (3) /opt/conda/lib/libxgboost.so(xgboost::gbm::GBTree::Configure(std::vector<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&)+0x331) [0x7fac9cc6b6d1]\n
[bt] (4) /opt/conda/lib/libxgboost.so(+0x2a7ab2) [0x7fac9cc98ab2]\n
[bt] (5) /opt/conda/lib/libxgboost.so(+0x2a12da) [0x7fac9cc922da]\n
[bt] (6) /opt/conda/lib/libxgboost.so(XGBoosterPredictFromDMatrix+0x2c9) [0x7fac9cacf3e9]\n
[bt] (7) /opt/conda/lib/python3.8/lib-dynload/../../libffi.so.8(+0xa052) [0x7facc4596052]\n
[bt] (8) /opt/conda/lib/python3.8/lib-dynload/../../libffi.so.8(+0x8925) [0x7facc4594925]\n

Additiona Notes
Note that local xgboost inference works fine; only remote call fails.
Attemps
clf_xgb = XGBRegressor(objective='reg:squarederror', seed=42, tree_method='hist')

I have tried setting the tree_method to both hist and exact, but same error.

May I assume that you are loading the trained model in the remote worker for inference? Could you please check the parameters of the loaded model? Also, is the model saved using pickle or using regressor.save_model?

@trivialfis Thanks for taking a look.

May I assume that you are loading the trained model in the remote worker for inference? Could you please check the parameters of the loaded model?

Yes the trained model is loaded in remote worker for inference, here are the parameters of the loaded model:
{'objective': 'reg:squarederror', 'base_score': None, 'booster': None, 'colsample_bylevel': None, 'colsample_bynode': None, 'colsample_bytree': None, 'eval_metric': None, 'gamma': None, 'gpu_id': None, 'grow_policy': None, 'interaction_constraints': None, 'learning_rate': None, 'max_bin': None, 'max_cat_threshold': None, 'max_cat_to_onehot': None, 'max_delta_step': None, 'max_depth': None, 'max_leaves': None, 'min_child_weight': None, 'monotone_constraints': None, 'n_jobs': None, 'num_parallel_tree': None, 'predictor': None, 'random_state': None, 'reg_alpha': None, 'reg_lambda': None, 'sampling_method': None, 'scale_pos_weight': None, 'subsample': None, 'tree_method': 'exact', 'validate_parameters': None, 'verbosity': None, 'seed': 42}

Also, is the model saved using pickle or using regressor.save_model?

Its saved through regressor.save_model and loaded through regressor.load_model

Closed as this is caused by user error; I have some logic that unexpectedly changed the tree_method to gpu_hist; sorry about that


How can we selectively deploy properties inside copy loop

How can we selectively deploy properties inside copy loop?
I am using Copy to iterate through an input list for subnet parameters and deploy them through template. Template as follow.
The challenge is that some of the subnets are not associated with a NSG and thus if we pass empty string the following template will error out. How can we put condition into the template to deploy the networkSecurityGroup property only if needed?
Thanks
"resources": [
{
"type": "Microsoft.Network/virtualNetworks",
"name": "[variables('vNet').name]",
"apiVersion": "[variables('apiVersion')]",
"location": "[resourceGroup().location]",
"comments": "This will build Shared Services Virtual Network.",
"properties": {
"addressSpace": {
"addressPrefixes": "[variables('vNet').cidr]"
},
"copy": [
{
"name": "subnets",
"count": "[variables('subnets').count]",
"input": {
"name": "[variables('subnets').entries[copyIndex('subnets')].name]",
"properties": {
"networkSecurityGroup": {
"id": "[resourceId('Microsoft.Network/networkSecurityGroups', variables('subnets').entries[copyIndex('subnets')].nsg)]"
},
"addressPrefix": "[variables('subnets').entries[copyIndex('subnets')].cidr]"
}
}
}
]
}
}
]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e71b5b6-0a86-b261-4fb3-e31ca6a12ec3
Version Independent ID: ab404f2d-5eb8-4e7e-fc37-ad785dcf852f
Content: Deploy multiple instances of Azure resources
Content Source: articles/azure-resource-manager/resource-group-create-multiple.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@Charmendar Thanks for the question! We will investigate on this and get back to you soon.
@tfitzmac Your insights please?

@Charmendar - this is a tricky scenario but there are a couple of approaches you could try.
I tried setting the id under networkSecurityGroup to null, but that produced an error. However, you can set the networkSecurityGroup object to null for items that don't have an nsg. Like:
"networkSecurityGroup": "[json('null')]"
To make that make, you would need to add the if function to test if the variable has an empty object for the nsg. It looks like you would also need to change your variable to store the full nsg object. Depending on the result, you either pass in the object or null. You'll see a similar example for a conditional resource in the if function.
The other approach would involve breaking the subnets out as a separate resource, instead of a property. You could keep two variables for subnets, one with nsg and one without. Then, use copy with the subnet to iterate over subnets with nsg and without.

Thank you very much! I will go with the json('null') option. It would be great if we can use if function throughout the template

@Charmendar - unless you are still having a problem with this, we will close the issue.

#please-close

Sure thanks for the solution!


Implement encryption

Based on PhakornKiong/pdf-lib#dev/DocEncrypt

What?
This PR adds the ability to encrypt a PDF document. It's based on PhakornKiong's PR https://github.com/Hopding/pdf-lib/pull/1015, which sadly did not get merged. I've updated his code to be compatible with the latest changes to pdf-lib. Tried to simplify where possible, minimizing changes to PDFDocument and PDFContext.
Why?
I needed PDF encryption on a project. This repo has already merged decryption. Let's have both!
How?
Uses CryptoJS to encrypt streams.
Testing?
I've tested it for my personal use case. I have not implemented unit tests yet. Want some assurance it will get merged before working on unit tests.
New Dependencies?
CryptoJS.
Screenshots
N/A
Suggested Reading?
Yes, also read the Encryption part of the spec.
Anything Else?
Checklist

[x] I read CONTRIBUTING.md.
[x] I read MAINTAINERSHIP.md#pull-requests.
[ ] I added/updated unit tests for my changes.
[ ] I added/updated integration tests for my changes.
[ ] I ran the integration tests.
[ ] I tested my changes in Node, Deno, and the browser.
[ ] I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
[ ] I added/updated doc comments for any new/modified public APIs.
[ ] My changes work for both new and existing PDF files.
[ ] I ran the linter on my changes.

I'll have a look at it as soon as I have a moment. Thanks very much for driving this here.

@programmarchy Everything seems alright. I'll be able to merge. I'm just not sure about the change from PDFHeader.forVersion(1, 7); to  this.context.header. I don't understand either the original code nor the new one to be honest :sweat_smile:

Do you have time to run those investigations? Otherwise, we should take the safest approach, which is probably to keep the original code. If that raises problems, we can solve them as they go.

@Sharcoux Agree on taking the safer approach. I'm good only supporting 1.7. So I'll simplify PDFSecurity to only support that version.
Also, this PR has a bug where encrypted PDFs cannot be opened Adobe Acrobat. It's stricter than other readers, so I need to fix that also.

@Sharcoux Agree on taking the safer approach. I'm good only supporting 1.7. So I'll simplify PDFSecurity to only support that version.
Also, this PR has a bug where encrypted PDFs cannot be opened Adobe Acrobat. It's stricter than other readers, so I need to fix that also.

Maybe you should keep the support for other versions and only add a comment above the part: const header = PDFHeader.forVersion(1, 7); mentioning that investigations are required to know why this is there. This way, we don't lose your work.

@programmarchy

But you ask a good question worth investigating. There may be a reason that version 1.7 was hardcoded. For example, maybe pdf-lib can read version 1.4 PDFs, but only supports writing 1.7-compatible PDFs?
If we determine that pdf-lib will only support writing 1.7 PDFs, then we could eliminate the code that handles encryption for other PDF versions.

pdf-lib does not seem to assume anything other than version 1.7.
I can't find any version checks for added functionality or deprecated functionality by PDF version.
Maybe that's why version 1.7 is hardcoded because of the simplification.

@programmarchy

But you ask a good question worth investigating. There may be a reason that version 1.7 was hardcoded. For example, maybe pdf-lib can read version 1.4 PDFs, but only supports writing 1.7-compatible PDFs?
If we determine that pdf-lib will only support writing 1.7 PDFs, then we could eliminate the code that handles encryption for other PDF versions.

pdf-lib does not seem to assume anything other than version 1.7. I can't find any version checks for added functionality or deprecated functionality by PDF version. Maybe that's why version 1.7 is hardcoded because of the simplification.
Add:
I found the comment mentioned by @Hopding
Hopding#916 (comment)

Nice, but then, this means that we should probably keep things the way they were. Can you revert that part and add a comment near the hard codded header linking to Hopding message or this conversation?

I reverted the version header part.
However, there's still the outstanding issue with encrypted PDFs not able to be read by Adobe Acrobat. Still looking into that. Acrobat doesn't seem to output any useful information for troubleshooting. Going to compare with other PDF libs.

Ah, my bad, I saw your comment too late. I merged but I won't release waiting for your fix.

@programmarchy Will you still try to make the pdfs be opened with Adobe Acrobet?

@Sharcoux It's on my todo list but I don't have a timeline of when I can finish it. Partly because of my schedule, and partly because I'm a bit stuck, frankly.
I know that qpdf is able to encrypt the same PDFs I tested with and they open successfully. Their encryption code is here: https://github.com/qpdf/qpdf/blob/main/libqpdf/QPDF_encryption.cc but I haven't finished comparing the implementations.
If we can attract others to help solve the problem I think that'd be ideal.

@PhakornKiong Hope it's okay that I am reaching out to you here. We're working on merging in your PDF encryption implementation into this fork of pdf-lib. The implementation works great for most PDF viewers, however, Adobe Acrobat cannot open the file.
Do you happen to have any insight?

@programmarchy
Try adding types that do not compress in the object stream.

Because,In PDF Specifications

In linearized files (see Annex F, "Linearized PDF" and Annex G, "Linearized PDF access strategies"),
the document catalog dictionary,
the linearization dictionary, and page objects shall not appear in an object stream.

Only a simple test, but the error seems to have disappeared.

Ah?
https://github.com/cantoo-scribe/pdf-lib/pull/54#issuecomment-2186396859
Perhaps this should be a separate issue from encryption?
There should be an impact on Object Stream output regardless of encryption.

@RippleRurigaki Yep, that fixed the issue with Acrobat! Nice find... I'll open a new PR.


Mark node as NotReady when ovs-ovn failed, and use io.Copy() maked k8s cni config  at kube-ovn-daemon

What type of this PR
Examples of user facing changes:
Features

#1475
use io.Copy() replace os.ReadFile() next, os.WriteFile()

Which issue(s) this PR fixes:
Fixes #1475

We need to reconsider if we should mark it as not ready and prevent schedule, close it at the the moment


ERROR: for cass2  Container "e08af5707469" is unhealthy

Hi, I was encountered this trouble when following instructions.
Please help!

ERROR: The Compose file './docker-compose.yml' is invalid because:
services.cass3.depends_on.cass2.condition contains "service_healthystart cass3 only after cass2", which is an invalid type, it should be a service_started, or a service_healthy

Same problem.

Hi, @duycuong87vn Please set them mem_limit to 4 GB then all work like a charm
mem_limit: 4g


FixedBufPool::next

Add an async API to get buffers out of FixedBufPool. This is another way in which FixedBufPool will be more useful than FixedBufRegistry.
Also reorganize the shared data structures of FixedBufPool and FixedBufRegistry into separate modules for better readability and future code reuse.

ugh, I did not mean to remove the draft status

@FrankReh

But we are left without a simple/fast pool, that doesn't allocate, for the current-thread case.

While the pool is not exhausted, tasks call next at near zero cost with no allocations.

@mzabaluev

While the pool is not exhausted, tasks call next at near zero cost with no allocations.
That's a very good point. I think I overlooked that while digging into the weeds of the implementation.

@Noah-Kennedy @mzabaluev Is something blocking this? It looks like all points have been resolved

You don't need my approval here. I'm alright with @FrankReh signing off on this and merging it whenever he feels it is ready.

@mzabaluev

While the pool is not exhausted, tasks call next at near zero cost with no allocations.

That's a very good point. I think I overlooked that while digging into the weeds of the implementation.

Is this not a common case though. I.e, to keep some pipeline of tasks fully utilized, do work whenever there is a buffer available?

Is this not a common case though. I.e, to keep some pipeline of tasks fully utilized, do work whenever there is a buffer available?

Depends if the task creation is only throttled by availability of the buffers.

I'm going to merge later tonight so it makes it into the next release. This is some really great work that we want in the repo but I had to do a manual merge on four files because code moved and code changed at the same time.
Actually the condensed diff that this page makes available isn't too bad to read. Most of the changes are straight forward.
I guess the drop code, and the intra-doc links are where there could be problems so another pair of eyes or two or three wouldn't hurt. It compiles cleanly, and there is a nice unit test that passes. But rarely do our unit tests check that things were dropped properly so that's why looking at the drop again would make sense.
But also, nothing we can't change yet again with more iterations.

Thank you @mzabaluev .


Enduro on Kubernetes: Can't Save Changes to CMS

So I have an enduro instance deployed to Kubernetes, with a persistent storage volume attached to the /cms folder, but the admin panel doesn't seem to be able to save changes to the content files.
I'm not just static deploying it because I make use of the Express server quite a bit.
(I understand this is a somewhat non-standard issue, but I figured this would be a great place to find people actually using this repo who might have some insight into whatever underlying permissions issues  might be afflicting me.)

attempted to set the securityContext of the volume to fsGroup: 1000, and that didn't work.


ARROW-7233: [C++] Use Result in remaining value-returning IPC APIs

There were a number of APIs left.

Please don't merge since this conflicts with https://github.com/apache/arrow/pull/6804

Looks like there are problems:

* checking whether package ‘arrow’ can be installed ... WARNING
Found the following significant warnings:
  /arrow/cpp/src/arrow/ipc/message.cc:123:1: warning: control reaches end of non-void function [-Wreturn-type]

/arrow/cpp/src/jni/orc/jni_wrapper.cpp: In function ‘_jbyteArray* Java_org_apache_arrow_adapter_orc_OrcStripeReaderJniWrapper_getSchema(JNIEnv*, jclass, jlong)’:
/arrow/cpp/src/jni/orc/jni_wrapper.cpp:231:87: error: ‘arrow::Status arrow::ipc::SerializeSchema(const arrow::Schema&, arrow::ipc::DictionaryMemo*, arrow::MemoryPool*, std::shared_ptr<arrow::Buffer>*)’ is deprecated: Deprecated in 0.17.0. Use Result-returning version [-Werror=deprecated-declarations]
       arrow::ipc::SerializeSchema(*schema, nullptr, arrow::default_memory_pool(), &out);
                                                                                ^
In file included from /arrow/cpp/src/arrow/ipc/api.h:25:0,
                 from /arrow/cpp/src/jni/orc/jni_wrapper.cpp:26:
/arrow/cpp/src/arrow/ipc/writer.h:437:8: note: declared here
 Status SerializeSchema(const Schema& schema, DictionaryMemo* dictionary_memo,
        ^~~~~~~~~~~~~~~

Will fix. I used clang to build the R bindings so I missed some deprecation warnings (wonder if there's a way to get ARROW_DEPRECATED to warn in clang?)
This will need to get rebased after ARROW-8311

Rebasing.

GLib failure https://github.com/apache/arrow/pull/6867/checks?check_run_id=574066551#step:5:1025
is https://issues.apache.org/jira/browse/ARROW-8373

AppVeyor build in progress:
https://ci.appveyor.com/project/pitrou/arrow/builds/32069395

Thanks. This is going to cause some mayhem with ARROW-8311 though


Graphs v2

Rework of HPU graphs. Now the flow looks like this:

VLLM_GRAPH_RESERVED_MEM is used to determine how much free memory after loading weights should be used for HPU-graphs (by default 30%)
we allocate blocks according to gpu-memory-utilization
we warmup all shapes without HPU graphs
we calculate remaining free memory and split it between prompt and decode graphs according to VLLM_GRAPH_PROMPT_RATIO (50%) and VLLM_GRAPH_MEM_MARGIN (5%)
we capture prompt graphs in order defined by bs*seq_len stoping when according to heuristics we won't fit another graph
as above but for decode graphs

Other important changes:

selecting token ids has been moved inside HPU graphs to limit memory usage
calculating attention_mask has been moved inside HPU graphs, but before model.forward to limit memory usage
*AttentionMetadata objects are trimmed before going into HPU graphs for better control over parameters (and avoiding recompilations due to changing constants)

@kzawora-intel Please review


Add middleware ordering for GRPC-web service projects

The page does not contain any information about ASP.NET Core services using GrpcWeb endpoints. Regarding #https://github.com/openiddict/openiddict-core/issues/1385 it took some time to figure out the correct ordering for the GrpcWeb middleware in an authorization scenario. The middleware page contains a section about the ordering for a Razor pages scenario which I understand is the most common case. However, mentioning the GrpcWeb middleware in that document would help others finding the right approach to debug these issues.
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9898482c-fa54-7ce2-1716-d14fbe03990d
Version Independent ID: 3926c686-0ccc-f9fe-ca52-0134612a1623
Content: ASP.NET Core Middleware
Content Source: aspnetcore/fundamentals/middleware/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@JamesNK  can you outline the changes needed for this doc to support gRPC?

gRPC-Web shouldn't be on this page because it isn't bundled with ASP.NET Core.
The only requirement for gRPC-Web is it's between UseRouting and UseEndpoints. That's covered here: https://docs.microsoft.com/en-us/aspnet/core/grpc/browser?view=aspnetcore-6.0#configure-grpc-web-in-aspnet-core

I tested whether gRPC-Web middleware comes before or after CORS and it didn't make a difference. The gRPC-Web middleware shouldn't impact CORS preflight requests.

Should it be true even if used along with Authentication and Authorization?
The issue I mentioned has a repo to test.  The GRPC-web service is called from a Flutter client, and I am not sure if that causes the issue.
I am really happy to help and since I already put up a repo about it, I can make modifications to make the issue reproducible using MS technology stack alone. Will you have any suggestions on how to test it further?

Could you get server logs? Lower the log level to Trace to get as much information as possible. Repeat for successful .NET client and unsuccessful flutter client.
There are docs for enabling logging at https://docs.microsoft.com/en-us/aspnet/core/grpc/diagnostics?view=aspnetcore-6.0#grpc-services-logging

PR that updates the GrpcWebMiddleware - https://github.com/grpc/grpc-dotnet/pull/1618
I don't think this is the issue, but it doesn't hurt to limit middleware to only run if content-type = application/grpc-web AND the request is a POST.


x/blog: make snippet more flexible in slices blog

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?
in https://blog.golang.org/slices blog at Passing slices to functions can't change or play with AddOneToEachElement function.
What did you expect to see?
adding AddOneToEachElement function to the try it snippet to try or change the function.
What did you see instead?
unable to change AddOneToEachElement function.

I'm sorry, I don't understand what you mean.  Can you show an example of how you think the blog post should be changed?  Thanks.

I think It's good to have
func AddOneToEachElement(slice []byte) {
    for i := range slice {
        slice[i]++
    }
}

in runnable snippet just like other functions in the blog.
func AddOneToEachElement(slice []byte) {
    for i := range slice {
        slice[i]++
    }
}
func main() {
    slice := buffer[10:20]
    for i := 0; i < len(slice); i++ {
        slice[i] = byte(i)
    }
    fmt.Println("before", slice)
    AddOneToEachElement(slice)
    fmt.Println("after", slice)
}

Hi afrouzMashaykhi , if u want to run  example code with custom slice manipulater function just write your custom function with different name in code area then change 'AddOneToEachElement' function name to your new function name.(u can click the code are and write some code)

I hope it will help u,

yeah thanks @Quaqmre . But I think it will be good to have that option too, just like other functions in the blog. hom?

Maybe u right it will be much helpfull for developers,but this issue releated with https://github.com/golang/blog project , u can reopen this issue on blog project ı think.
And I checked source code of gddo and snippets can doable more flexible with small changes,
If u want to make changes and send pull request look at
https://github.com/golang/blog/blob/master/content/slices.article
line of 185
.code slices/prog010.go /^func/,/^}/
to
.code -edit slices/prog010.go /^func/,/^}/
...

@Quaqmre  thanks for your help


CharString: more arguments on stack than required

There seems to be issues with the Lerna icon causing documents to not compile.

Removed Lerna from incompatGlyphs for now as it seems that compiling is fine now, but the icon still doesn't show up.


Implementing simpler solution for createdDate

It appears that the date that comes back from boto is not actually
the creation date.  As far as I can tell it is a problem with
AWS.  I've commented on it here
https://github.com/boto/boto/issues/2863

Looks good. Sucks all that research basically came down to creating the createdDate when shelf finds out about the artifac but I honestly think it won't cause any issues...


Using ActivatedDate instead of ChangeDate

Hi, thanks for the great script.
I've run into a problem because I don't want to track the change from the NEW state, but when it goes to the first In Progress state, because I have defined further “Proposed” states in addition to the NEW.
To do this, I use the ActivatedDate instead of the now commented-out calculation using the ChangedDate.
def extract_age(work_item_history):
    for history_entry in work_item_history["value"]:
        if "fields" in history_entry and "Microsoft.VSTS.Common.ActivatedDate" in history_entry["fields"]:
            activated_date = parse_ado_date(history_entry["fields"]["Microsoft.VSTS.Common.ActivatedDate"]["newValue"])

     #   if "fields" in history_entry and "System.State" in history_entry["fields"]:
     #       state_change = history_entry["fields"]["System.State"]
     #       changed_date_field = history_entry["fields"]["System.ChangedDate"]

     #       if "oldValue" in state_change and "newValue" in changed_date_field:
     #           old_state = state_change["oldValue"]
     #           new_state = state_change["newValue"]
     #           changed_date = parse_ado_date(changed_date_field["newValue"])

                # When it was moved "out of new" we care -> count days from then till today + 1 -> that's our WIA
      #          if old_state == "New":

      #              work_item_age = (date_today - changed_date.date()).days + 1
      #              print("Item was moved from {0} to {1} on {2} -> Work Item Age: {3}".format(old_state, new_state, changed_date, work_item_age))

            work_item_age = (date_today - activated_date.date()).days + 1
            print("Item was activated on {0} -> Work Item Age: {1}".format(activated_date, work_item_age))
            return work_item_age
    return 0

I just wanted to leave my adjustment here so that someone else could benefit from it if necessary.
If your next state is also defined under "In Progress", then the same should come out.
Or do you see problems with this approach that have led you to use the ChangeDate?
Cheers

Hi @2moveit
I don't see any problem, and I think it's the smarter solution. I think when I first created this script, I was just not aware how to do it better.
I'll have a more detailed looked (hopefully over the weekend) and will update the code accordingly. Relying on the "State Categories" rather than the states is more generic, I'm sure you're not the only one having more than one state in the "Proposed" category 👍

"Your" version is now the one that is used in general, as I updated the script in 430955a
Thanks a lot for your input!


Adding Windows builds

Would be good to have Windows builds also. Maybe they could be MSYS2 based if needed.

I will be happy for any help with this and will review any and all PRs.


Assign ticket to someone

Thanks for sharing this projet.
If you have not already planned, it would be logic to have a functionality for assigning to somone a ticket. Even with notification by email.

Thinking about this, I can't understand how the assigning would work.
In the bundle there are 2 types of user, those with ticket admin role, and those without.
The way it works at the moment is admin users can see all tickets, and those without can only see their tickets.
There are events firing so adding email notification would straight forward for someone to do outside of the bundle.

We should be able to assign a ticket to a specific user then this user could show his tasks and treat them by priorities or scheduled date and when it's done (resolved), he will assigne the ticket to the owner.
The way it work now, it's like a private messaging with status and priority.
We should turn the real goal of the bundle to a system such a bug tracking system or redmine.
You can add in the entity Ticket a new field assigned_to and date limit ? Do you agree ?

This sounds interesting, but will require more thought.
I will revisit this after some of my other neglected projects.

+1 We need this for our project. Maybe I will implement it and open a PR.

Is assigning a ticket to someone implemented?

Not at present.
I have been quite busy recently.
The next feature I'll be implementing will be #51

@hackzilla do you know when could you implement assigning functionality?

It's probably going to be at least month.
#51 is currently in progress.

I've decided I will attempt this for v3.  I haven't made a start of this, but I will soon.

hi @hackzilla , I need something like "assign ticket to someone", but simpler: I need to assign the ticket programmatically.
So I'm writing the code but I would like to have the same name for entity field  you will use for the assignee. Which name do you think you will put in Ticket Entity for that user?
so... in the future I will have no problem if I would like to switch to your more complex system (assign ticket from the gui)

I have no planned names at the moment.
If you name it something then I'm likely to stick with it.
(actually, I'm moving away from entities and towards interfaces. i.e. https://github.com/hackzilla/ticket-message/tree/master/Model).
I haven't given ticket-bundle the time it deserves for the last few months.
However, I am currently at Symfony Live London, learning about Symfony 4.
So I think I'm going to have to do a proper push, and get Ticket Bundle v4 working/released.

Wow, I would like to be there too!
I was thinking to something like "userAssigned" because of "userCreated" field.
What do you think? If you have a better name do not hesitate to suggest it :)
Using intefarces is really a better choice when working on open project like this.
Thank You!

my preference would be userAssigned.
Yhea, interfaces feel better.  A bit more work for the setup, but it allows people to store whatever they want in addition to the stuff for ticketing.

@Filoz Symfony Flex is awesome.  I didn't know about it until now.

@hackzilla in another service I developed a way to make tickets asignable to any entity (even other tickets) wich obviously includes users. Making to tickets assignable is as simple as implementing an interface and 2 static fununctions for mapping purposes to the disired entitys.
If this is still an active request I will be happy to prepare a PR implementing my aproach into your service. Need some time though.
This could be used further to implement an access con troll feature by users usergroups or any other entitys assigned to a ticketable entity.

I've taken a step back.
@phansys Does this feature still make sense?

Hi!
I think this feature is useful for scenarios which the implementation tries to cover features like provided by helpdesk platforms or similar, where the ticket must have a responsible regardless its creator.
In my own use case, I have this feature implemented via inheritance of the provided model, adding the missing properties at my own persistence layer.
As first step, I think we need to work in #128, in order to add support for specific use cases, while later we could analyze which features must be provided out of the box.

That helpdesk scenario was exactly my usecase. I needed to be able to assign users to a ticket to give them responsibility for the ticket but also make tickets filterable by any entity or even its child entities. Its a maintenance system for real life objects wich need to be maintained by technicians.
I introduced a own TicketAssignment entity wich handles the Mapping. Each entity wich is assignable implements an interface and thats basicly how you make entitys assignable in my Bundle. Quite easy to make new Entitys assignable. Could provide my aproach. Possibly even after #128, if you need any help there, let me know


add quote_field_suffix to simple_query_string

fix for #750

It has been tested in an internal project

Looking good. I will add it in the next release. I typically use these "bugs" as a chance to look into the Java code for other missing/removed properties. So it'll take a few days more.

If you want I can complete all the other missing properties from es6.2

Thanks for your support. It's basically synchronizing the Go code with QueryStringQueryBuilder.java and SimpleQueryStringBuilder.java.
But, to be honest, I think I'd like to do this myself. That way it's slower, but I keep myself in touch with the changes in core.

OK, no wories

Thanks again.


DL: Remove num_classes param from madlib_keras_fit()

The number of classes is embedded in the model architecture JSON, so it
is not necessary to explicitly pass it again as a parameter to fit. This
commit parses the model architecture JSON to automatically figure out
the num_classes value to use.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/804/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/807/

Approved to merge!


Vi-mode Feature Implementation

Vi-mode Feature Implementation
Description

Implements Vi-Mode Feature. There are some difference with zsh's spaceship implementation:

fishshell also allows to handle VISUAL and REPLACE_ONE modes and it use dedicated symbols for them in default fish_default_mode_prompt. So I add them too.
Zsh's spaceship also provide two methods to enable/disable vim mode(actually its implementation just switch it from emacs to vim). For fishshell same methods already exists out of box: fish_vi_key_bindings and fish_default_key_bindings.

Also I have overridden default fish_mode_prompt to avoid duplication. I think it better to have it all out of box.
Motivation and Context

#74
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):
How Has This Been Tested?

[ ] I have tested using MacOS
[x] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated the tests accordingly.

Hey @matchai ,
Thanks for your time spent to review this PR. Fixed it all.

Wow, that's interesting. After my commit CI start failing with this:

not ok 142 Prints section when fish_vi_key_bindigs is set
operator: =
expected: ' [I] '
received: ' [N] '
...

Unfortunately right after running fish_vi_key_bindings CI have fish_bind_mode in 'normal' state instead of 'insert'.


Code highlighting doesn't line up

I don't know if this is the correct repo, but throughout docs.microsoft.com all code samples with a highlighted line(s) will be displayed incorrectly:

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?view=aspnetcore-3.0#keep-alive-timeout
Chrone. Windows 10. 125% scale.

@JamesNK Thanks for reporting this.  It's a known problem but has not been prioritized high enough to fix yet.
The correct repo to create an issue in is https://aka.ms/sitefeedback
@Rick-Anderson FYI

I added a link to this issue in our internal bug tracking work item at https://icm.ad.msft.net/imp/v3/incidents/details/136852259/home


formatter/records: recjson output format hidden fields (don't expose sensitive data)

With the MARC/MARCXML export you can hide specific fields using CFG_BIBFORMAT_HIDDEN_TAGS to not expose sensitive data like e.g. email addresses.
The newly added recjson output format does not have this feature and thus will expose sensitive data if included in the recjson configuration. As far as I understand @egabancho is already working on a fix for this, however I wasn't able to find the ticket so adding one now.

Fixed in master for Invenio 1, so keeping only next labels for Invenio 2.

Since the issue is labelled as critical for INSPIRE, and since nobody has time to work on @hidden or @hidden_if decorators, putting this for triaging discussion. Let's assign at least semi-passive, semi-active ticket owner.

Yep this was critical for INSPIRE as long as master was concerned. At the moment, INSPIRE Labs (i.e. our pu-based instance) is not serving records, so it's no longer critical for us (still major)

The @hidden decorator has been implemented and merged in #2666. Do we need the @hidden_if version and if yes how it should work in respect to request, current_user and application context?

The @hidden decorator has been implemented and merged in #2666.

Great that you made the time!

Do we need the @hidden_if  version

I'd say nope. In theory, we did muse about finer granularity, this-field-seen-only-by-this-role, that-field-seen-only-by-that-role.  In practice, we had only one use case so far, where all the fields decorated as hidden can be seen by cataloguers. Hence I'd say let's close this issue now, and if needed, we'll open a new one for a more fine-grained conditional behaviour.


Update K3s security documentation.

Update security page to indicate that CIS 1.5 and 1.6 are covered by
this section.
Add network policy to Hardening Guide that shows how to allow for DNS
traffic.

@catherineluse who merges docs prs? devs or you?
can this get merged?


AddIdentity will add a marker Identity service and UseIdentity will throw if not found

Similar to what MVC does

ab29d5f5e581dd4cf9a8996b8c940bd4e5b65490


migrations: allow backend specific steps

Setup
Versions

Diesel: 1.4.0

Feature Flags

diesel: sqlite xor postgres

Problem Description
The SQL in the migration steps depends usually on the databaes backend.  E.g. diesel-cli itself creates an initial up step with
CREATE OR REPLACE FUNCTION diesel_manage_updated_at(_tbl regclass) RETURNS VOID AS $$

which works only with postgresql but fails with sqlite..
Using alternate migration diractories might be a way to fix this but it means that large parts of migration code must be replicated across the backends.
It would be nice to disable/enable execution of steps depending on the used backend.
In-SQL statements like
-- #[begin(postgres)]
CREATE OR REPLACE FUNCTION diesel_manage_updated_at(_tbl regclass) RETURNS VOID AS $$
-- #[end(postgres)]

to selectively enable sql blocks might be the perfect solution but are probably not easy to implement.
Instead of, I suggest backend specific filenames like
up-sqlite.sql
up-pgsql.sql
down-pgsql.sql

When such a file exists it is preferred over the generic up.sql resp. down.sql
So, you can share large parts of the migration between the backends and move only the specific parts into separate steps.

We see migrations as something highly backend specific. Sharing a migration between different backends is in my opinion an anti pattern and does generally not work well as soon as you use some more specific data types.
If you want to use something that abstract migrations over different backends I think barrel supports that. It has some integration with diesel as far as I'm aware.


Fix #33/stop command finishes with 404 error

fixes #33

:tada: This PR is included in version 4.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix UpdateStory method that doesn't work.

First of all, thank you for creating asana-go.
I fixed a bug that UpdateStory is implemented but does not work at all.

Thank you for spotting the problem!
The PR is very much appreciated. Happy to merge.


List of types that requires fake protocol message definition

As expressive power of type system of Protocol Buffer is significantly lower than TypeScript, typescript-json requires to lots of fake message definitions for not supported types by the Protocol Buffer. For an example, as Protocol Buffer does not allow repeated keyword on map<K, T> type, it must be wrapped into a fake message type like below:
message Something {
    repeated Something.Dictionary dictionaries = 1;

    message Dictionary {
        map<string, int32> value = 1;
    }
}

Therefore, list up types that requires fake protocol message definition and solve one by one for #364

[ ] Top level type that is not object like TSON.message<number>()
[ ] Union type of arrays: A[] | B[] | C[]
[ ] Union type in array: Array<A|B|C>
[ ] Union type containing array: string | Array<A> | B
[ ] Tuple type


Use JSON for config for cross language sharing

Just ran into this on a Rails project. I wanted to have my Rails asset path helpers read my gulpfile.js/config file, so I converted it to JSON.
Downside: It's not JS, so you can't have any logic in the config files (there isn't currently).
Upside: Easier cross-language sharing.
Worth it?

Feels fine to me. Makes me wonder what are config files normally saved out as? I feel like yaml is more popular.

I went with JSON because you can already require it in node. YAML is nice though, and I could use https://github.com/leafty/node-yaml-config

Another downside is you can't comment out a task, though you could probably set the value to false and then add that check when running defined tasks (ie. if iconFont key exists and has a valid input, run the task).


Adapt to new access method

Ford has changed the login method for its API. Since then the contrib has been unusable and only receives the "401" in response to the request.

Hi and thanks for your comment. I am waiting for https://github.com/d4v3y0rk/ffpass-module/pull/12 to be merged.

Should be fixed in latest release https://github.com/d-Rickyy-b/node-red-contrib-ffpass/releases/tag/v0.1.5
See also https://github.com/d4v3y0rk/ffpass-module/releases/tag/v1.0.7


We can nominate and externalize data that will fail Block validation

There were several issues with nomination discovered in #899:

[ ] There were leftover Enrollment in the EnrollmentPool which were picked up to be nominated, although they were also in the ValidatorSet;
[ ] There is no check that the result of Ledger.prepareNominatingSet can in fact be nominated;
[ ] Other node achieved consensus on duplicated Enrollments (!)

All of this needs to be fixed. #899 was just a stopgap measure but nominating enrollment (and nomination in general) needs to be much more thought out.

The main thing of this issue is to remove the duplication of enrollments. So we need to add the following algorithm for this issue.

We add the requested_height column in the enrollment_pool table, which means the height when the enrollment is inserted.
If the requested_height of an enrollment is smaller than the enrolled_height, the enrollment is removed from the EnrollmentPool when the getEnrollments function of the EnrollmentManager is called.

All the issues to be resolve is all about the getEnrollments function of the EnrollmentManager.
It there are any other point of view or any suggestions, please let me know. I will review them positively.

Last point: Do not return Enrollment for which the requested_height is > than the height we are nominating for.

We add the requested_height column in the enrollment_pool table, which means the height when the enrollment is inserted.

It should be "the height when the enrollment will be available".


Remove old Mangle renamer

I don't particularly like leaving comments in the source - we should just remove it then?

Agreed, it's all versioned so let's just remove.

The renamer is removed. The part that is turned to comments is the method "updateReferences" which a TODO for the current renamer.


Remove code/modules and code/theme folders

Custom modules and themes can be placed directly in drupal/web/modules/custom and don't need to be symlinked from drupal/code. The old code folder and the corresponding deployment steps can be removed.

Already moved.


[Content group cards] Storybook - Web Comp - card focus outline incorrect

The Web Comp Storybook card focus outline is not correct:

@DragosRistici Seems like this has been fixed already, would you be able to confirm?

@IgnacioBecerra There's still a double outline for the cards in the content group cards. Check the others, like Card section simple:
This one is Card section simple:

This one is Content group cards:

I'm checking here: http://ibmdotcom-web-components-canary.mybluemix.net/?path=/story/components-content-group-cards--default
Thanks,
Dragos


Fix empty string handling for FixedString() column

In case of empty value the previous row value for column was used because of buffer reuse

Thanks!


Any examples of a layer renderOrderFunction? How is it supposed to work?

I made something like this:
export function layerRenderOrderFunction(featureA, featureB) {
  return featureA.get('zIndex') - featureB.get('zIndex');
}

where zIndex is a positive float. I can say that this attribute is never undefined, so why does this not work?

Closing this since I solved it by using the zIndex property in the style object. I didn't see any documentation of it though, except for a single page where there was an example of ol.style.Style and it was really easy to miss.

ol.style.Style  has getZIndex method

Thanks, I really missed it! I have to say it's not where you'd look firsthand if you want to order features around, though.

right, it takes some time to be familiar with OL structures


⚠ API has degraded performance

In c12aef0, API ($ZESTY_API) experienced degraded performance:

HTTP code: 403
Response time: 1196 ms

Resolved: API performance has improved in 728c67c.


Cannot serialize a number field and read it in Java as a long type.

I have written to an MMDB file in Python:
writer = MMDBWriter()
writer.database_type = 'GeoIP2-ISP'
writer.insert_network(IPSet(['<IP_ADDRESS>/24', '<IP_ADDRESS>/24']), {'city': 'CITY', 'isp': 'ISP'})
writer.insert_network(IPSet(['<IP_ADDRESS>/24']), {
     "isp": 'Google',
     "organization": 'Google',
     "ip_address": '<IP_ADDRESS>',
     "autonomous_system_organization": 'GOOGLE',
     "autonomous_system_number": '15169'
})
writer.to_db_file(filename)

I have used the file in a Java application and encountered an error while deserializing data:
Caused by: java.lang.IllegalArgumentException: argument type mismatch
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:65)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at com.maxmind.db.Decoder.decodeMapIntoObject(Decoder.java:436)
	... 160 more
Caused by: java.lang.ClassCastException: Cannot cast java.lang.String to java.lang.Long
	at java.base/java.lang.Class.cast(Class.java:4067)
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	... 163 more

When I used the integer value 15169, I received a similar message: 'Cannot cast java.lang.Integer to java.lang.Long'.
How can I mark a field to be parsed as long?

You can try this
from mmdb_writer import MMDBWriter

writer = MMDBWriter(int_type='i32')

Just to let you know: The merge request requires python 3.10 to work as the usage of Union[float | Decimal] requires it.

def init(self, value: Union[float | Decimal]):
TypeError: unsupported operand type(s) for |: 'type' and 'type'

Maybe it makes sense to point this out somewhere in the Readme and according changes to the pyproject.toml.

Just to let you know: The merge request requires python 3.10 to work as the usage of Union[float | Decimal] requires it.

def init(self, value: Union[float | Decimal]):
TypeError: unsupported operand type(s) for |: 'type' and 'type'

Maybe it makes sense to point this out somewhere in the Readme and according changes to the pyproject.toml.


release 0.9.0 removed and making automated build fail

Was version 0.9.0 removed for some particular reason?
Our CI environment is failing when installing 0.9.0.
Caseless is a dependency of jspm-github making jspm builds failing.

Works on my end. Also I don't think it's possible to remove any package or version any more (after lef-pad).

did you try cleaning the npm cache?

Actually no, but I'm pretty sure I didn't had<EMAIL_ADDRESS>prior that.

This returns 502
https://registry.npmjs.org/caseless/-/caseless-0.9.0.tgz
While other versions like 0.10.0 downloads the file
https://registry.npmjs.org/caseless/-/caseless-0.10.0.tgz

req HEAD https://registry.npmjs.org/caseless/-/caseless-0.9.0.tgz
    Host: registry.npmjs.org
res 200 OK
    server:                       nginx/1.4.6 (Ubuntu)
    content-type:                 application/octet-stream
    last-modified:                Mon, 04 Jan 2100 13:43:46 GMT
    etag:                         "f48b0c92-707"
    expires:                      Wed, 06 Jul 2016 02:26:08 GMT
    access-control-allow-origin:  *
    access-control-allow-methods: GET
    cache-control:                max-age=21600
    content-length:               1799
    accept-ranges:                bytes
    date:                         Wed, 06 Jul 2016 15:17:27 GMT
    via:                          1.1 varnish
    age:                          2865
    connection:                   close
    x-served-by:                  cache-lhr6322-LHR
    x-cache:                      HIT
    x-cache-hits:                 1
    x-timer:                      S1467818247.419864,VS0,VE0

Thanks for checking this @simov
Now I get also a 200 response. Probably there was a problem with the npm registry.
Closing the issue.