[SPARK-16240][ML] Model loading backward compatibility for LDA

What changes were proposed in this pull request?
LDA model loading backward compatibility
How was this patch tested?
Existing UT

@hhbyyh Can you please help review? I am not sure if this is the right way to do it, as topicDistributionCol is not included in the MLWriter or load.

Test build #62012 has started for PR 14112 at commit 880c3a1.

Test build #62012 has finished for PR 14112 at commit 880c3a1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62012/
Test FAILed.

retest this

Thanks @GayathriMurali for the PR. I think we'll need to override the default behavior of getAndSetParams. Meanwhile, we need to invoke both convertVectorColumnsToML and convertMatrixColumnsToML.
I'll send a PR to your repository for reference.

PR created. Sorry I got something else that I need to turn to. Ideally, the overriding getAndSetParams should be in LDAParams, thus it can be reused by LDA and LDA Local/Distributed Model. Please help move it there (perhaps a new Function in LDAParams)
Let me know if you have any question. I'll revisit ASAP.

@jkbradley I find it not easy to add a unit test to cover the logic. Appreciate your thoughts.

@hhbyyh I think offline test should be OK for now, since we don't have unified save/load compatibility test framework until now. It's better we can get this feature in the next RC.

@hhbyyh Thanks for helping out. Updated commit includes logic to include topicDistributionCol @yanboliang

Test build #62108 has started for PR 14112 at commit 2b13262.

Test build #62108 has finished for PR 14112 at commit 2b13262.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62108/
Test PASSed.

I agree it will be hard to do a proper unit test, but we should definitely test offline.  I've made a JIRA for designing backwards compatibility for the long term: https://issues.apache.org/jira/browse/SPARK-15573
I'll take a look at this now

What will happen in the future if the model changes, such as storing another val?  We will need to update the model loading logic and should follow different code paths for models saved in 1.6 vs. 2.x.  I'd recommend we isolate the 1.6 code path by checking metadata.sparkVersion.  Even though a single code paths works for 1.6 and 2.0, isolating the special logic for 1.6 might make it easier to update in the future.  What do you think?

Thank for the PR!

I agree that it will make thing easier to separate the loading logic here in LDA due to its extra complexity. Yet maybe we should not extend the pattern to previous changes about loading compatibility (LR, NaiveBayes, feature). I'd appreciate your suggestions.
@GayathriMurali I think we should cover the DistributedLDAModel and ideally, LDA for loading compatibility and avoid code duplication.

+1 for separate loading logic. The recent commit includes separate code paths depending on sparkVersion

Test build #62125 has started for PR 14112 at commit 08e5b55.

Test build #62125 has finished for PR 14112 at commit 08e5b55.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62125/
Test FAILed.

@hhbyyh I agree about not changing the other models' loading code unless it becomes necessary.  I hope we can design a better long-term solution during 2.1.
We should definitely cover the other LDA classes.

@GayathriMurali I'd like to accelerate getting this merged.  Please let me know if you'd like help with it, especially with adding the fix for other LDA classes.  (We can collaborate on the same PR.)

@jkbradley I am sorry, I have been held up with something else. I am looking on ways to add this to DistribtedLDA model. I will have something by EOD today.

Test build #62293 has started for PR 14112 at commit 0c2e51c.

Test build #62293 has finished for PR 14112 at commit 0c2e51c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62293/
Test FAILed.

Test build #62295 has started for PR 14112 at commit 216777f.

Test build #62295 has finished for PR 14112 at commit 216777f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62295/
Test FAILed.

Test build #62298 has started for PR 14112 at commit 58384d4.

Test build #62298 has finished for PR 14112 at commit 58384d4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62298/
Test FAILed.

Test build #62337 has started for PR 14112 at commit 8848f0e.

Test build #62337 has finished for PR 14112 at commit 8848f0e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62337/
Test PASSed.

@jkbradley I implemented model loading logic for DistributedLDA as well. I am using a versionRegex  for robustness in version checking. Using as[Data].head() is producing a scala match error on Jenkins but not when I run locally on my machine . For now I removed that and I am using .select(....).head()  and all test cases are passing on Jenkins. I am investigating why it should fail. Meanwhile, it would be great if you can leave your comments on the recent commits.

Test build #62567 has started for PR 14112 at commit a8bdd7a.

Test build #62567 has finished for PR 14112 at commit a8bdd7a.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62567/
Test FAILed.

Merged build finished. Test FAILed.

Test build #62568 has started for PR 14112 at commit b16b368.

Test build #62568 has finished for PR 14112 at commit b16b368.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62568/
Test PASSed.

@jkbradley Can you please help review this?

@jkbradley Please let me know if I can do anything to help get this merged

@jkbradley Can you please help review this?

Test build #3234 has started for PR 14112 at commit b16b368.

@GayathriMurali Apologies for the long delay!  It slipped past the release, and I'm trying to catch up on PRs now.  I'll make a final review pass ASAP

Test build #3234 has finished for PR 14112 at commit b16b368.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Done with review for now; I'll check back for updates.  Thanks!

@GayathriMurali Btw, I know it's been a long time.  If you no longer have time to work on this, please say so, and I'd be happy to take it over.  Thanks!

@jkbradley  I am so sorry I couldn't respond to this on time! I am in a transition process and might not be able to drive this JIRA to completion at this point in time. Thanks!

@GayathriMurali No problem; you've had to wait quite a while.  I'll be happy to take it over.
Could you please close this PR for now?
I'll send a new PR based on your commits (so you'll still be the primary author).  Thanks!

@jkbradley Sure! Thanks.


Nullable enum causes failure when generating swagger.json

As shown in the image, there is an error when swagger.json is created and the return type or the method argument type contains a nullable enum field/property in it.

new release checks for nullable types, can you check if your issue is fixed now?

assuming it's fixed... please reopen if you have any issue


Add forward/back buttons for month

I find I get much more utility out of a forward/back button setup on a calendar than I do a dropdown. Give me the CHEVRON_LEFT please!

boi
these exist
theyre the big left/right chevrons on the left and right sides of the page
or if ur on mobile on the bottom of the page

🤡 hjonk


Problems using EnumerationFields in queries

Since the format values are now saved, the Equals clause in queries doesn't work anymore.
This is a side effect of #8789 , which saves the EnumerationField value in a different way then before, as shown by the following screenshot from Orchard_Projections_StringFieldIndexRecord table:

As you can see, the new version of the Value column contains now the separator character ";" at the start and at the end of the actual value, even when only one value is selected.
There are two topics to discuss about:

Values inside the table are now ambiguous and should be coherent, perhaps with a migration step replacing old values with new ones. As a side note: saving a content item is enough to replace the "old" value format with the new one and using the "Value" property of the field works as expected.
Queries filtering on the Value of an EnumerationField do not work anymore, because the value is now saved with ";" characters even if a single option is selected. For this reason, the Equals clause cannot be used and currently needs to be replaced by the Contains clause. Creating a migration step to change queries isn't a viable solution: any suggestions on how to make EnumerationFields compatible with the old query usage?

I add to the discussion @MatteoPiovanelli-Laser and @BenedekFarkas because they worked on the referenced pull request and @sebastienros who approved it.

https://github.com/OrchardCMS/Orchard/blob/6e4fefd873dc17a9b098493afbe511a614cce82e/src/Orchard.Web/Modules/Orchard.Fields/Fields/EnumerationField.cs#L14
If we do not add separators to the Value property of the field, queries seems to work properly and I haven't noticed any side effects.

It seems the changes weren't completely backwards-compatible. :(
Updating the StringFieldIndexRecord.Value and/or StringFieldIndexRecord.LatestValue entries in a migration is fairly simple, but we can also change the filter to use an additional condition to match the value both with and without the separators at the beginning/end.

I used Upgrade module to create a scheduled task to update EnumerationField values, because content items needed to be re-published to ensure infosets to be updated too. This may be moved to a migration to ensure the automatic upgrade of values and avoid the manual operation of a back office user, but this may be a little tricky because of circular dependencies between Orchard.Projections and Orchard.Fields. This is also a very long task, potentially.
I am still working on a viable solution to ensure query compatibility with the newer value format, because creating a new condition isn't really an acceptable solution, since most back office users usually lack the access to the query configuration options and, ideally, the "Equals" condition should still be the right one for single selection EnumerationFields.
If interested, you can find current work in progress on the branch https://github.com/LaserSrl/Orchard/tree/fix/enumerationfieldvaluesmigration, which is based on Laser's fork of Orchard but should give you an idea of what I am working on.

@BenedekFarkas in the same branch, I found a working solution to the "query" problem. I added a specific IFilterProvider that is almost identical to current ContentFieldsFilter, filtering the fields inside the "Describe" method to only work on EnumerationFields. Consequentially, I modified the original ContentFieldsFilter to exclude from its Describe method the EnumerationFields (https://github.com/LaserSrl/Orchard/blob/acda3e32b37370423cb8cac17c5f29adfe46cc7d/src/Orchard.Web/Modules/Orchard.Projections/Providers/Filters/ContentFieldsFilter.cs#L39).
The ApplyFilter function for the EnumerationFieldsFilter modifies the Value parameter of the context object to properly add ';' separator characters when needed (see https://github.com/LaserSrl/Orchard/blob/acda3e32b37370423cb8cac17c5f29adfe46cc7d/src/Orchard.Web/Modules/Orchard.Projections/Providers/Filters/EnumerationFieldsFilter.cs#L77).
Since Category and Name parameters for the filter are the same as the original content fields filter, this solution works without a migration (old filters for EnumerationFields are now applied using the new provider).
The Upgrade procedure for the fields is needed to make everything work properly and has to be executed separately for each tenant. I excluded the upgrade of the values through a migration because the operation potentially involves thousands of content items for each tenant and may lock all tenants for a long time.
I released the branch on a test environment and will post a pr for the community as soon as possible.

Thanks for the update, I'll check get back to this towards the end of September (after Harvest).

Let's take a step back to have a clearer picture:

The original issue (#8460) was raised, because changing the ListMode of an EnumerationField can cause the editor not to pick up the existing value (and lose it upon saving the editor) when ListMode changes from one of the multi-select flavors (ListBox, Checkbox) to a single-select one (Dropdown, RadioButton). That is because a multi-select flavored editor wrote to SelectedValues, which surrounds the value with the separator (;) even if a single value is selected, while Value remains empty. On the other hand, the single-select flavored editors operate with Value directly, so the value won't be surrounded with separator characters.
The applied fix (#8789) updated EnumerationField property setters so that when a single value is saved, it's surrounded by  separator characters.
This issue is raised, because the changes in #8789 caused projection filters not to match the exact value with the Equals operator for a single value, because it's saved with separator characters around it.
#8801 is opened to fix this by adding a new filter specific to EnumerationField and some other changes, but it feels like we're getting into a complexity spiral.

What are our options?
On second thought, changing the editor flavor of an EnumerationField sounds like a bit of an extreme, so I'm inclined to say that if that happens, you'll need some custom code to take care of the associated changes anyway.

We can revert the first PR and change EnumerationFieldDriver or the associated template to make sure that the editor is correctly populated with a value after the editor flavor is changed from a multi-select to a single-select one (e.g., use the first entry from SelectedValue).
Can you please confirm that the current code works if you use the Contains operator (instead of Equals) for every EnumerationField? Looking at the code, I think it does, so that would be an easy win.
Depending on your business logic, you could surround your single-select values with ; before they are passed to the projection filter, so that the Equals operator continues to work. However, that would require updating the all the content items that use an EnumerationField.


Close upon focus left

When I have opened the fullscreen and tab away from it, I'd like to have it close automatically. Any way to do this?

@jmuheim I think that it is necessary to make this feature optional


[Doc] improve style of shell commands

Search before asking

[X] I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?
When I read the admin interface doc, I found that it's hard to distinguish between shell command and output.
For example:

What is your suggestion?
I suggest unifying the style of all shell commands:

separate output and command this way:

if it is a multi-line command, start with an indent and end with a slash, for example:

Any reference?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

cc @Anonymitaet @momo-jun

@labuladong thanks for the finding. It makes sense to improve as you suggest.

Good catch! @labuladong


It says Password list not found

Select your issue type: (check at least one)

[ ] Bug
[x ] Question
[ ] Suggestion
[ ] Other (please describe):

Describe your issue:
It says Password list not found. I tried to add the path, shifted the .txt file to other location, but nothing seems to work. Please help me.
Ways to Reproduce the issue (optional):

I am having the same issue
#28

Same Issue

put password list in any folder,click on properties and see the path  and it must be txt file
ex:
i kept my passwords.txt file in downloads its path is
/home/kali/Downloads/passwords.txt
so command will be
instagram-py -u hacker.123 -pl /home/kali/Downloads/passwords.txt

use command
$locate rockyou.txt
to find path to link to


User name dropdown menu css issue .

There seems to be a positioning issue with the dropdown menu which is dependent on the size of username.
I would like to self assign this issue

I would like to take up this issue


Cluster queries

associated with https://github.com/K2InformaticsGmbH/imem/pull/290

travis build is failing because imem is set to master branch.
https://github.com/K2InformaticsGmbH/erlimem/blob/afee5d2795cb91075c8838f8888bcc6be0127174/rebar.config#L51-L56
using cluster_queries branch works fine

travis build is failing because imem is set to master branch.
https://github.com/K2InformaticsGmbH/erlimem/blob/afee5d2795cb91075c8838f8888bcc6be0127174/rebar.config#L51-L56
using cluster_queries branch works fine

That is fine since it will be fixed automatically after imem PR is merged 👍

Pull Request Test Coverage Report for Build 44

0 of 7 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 44.69%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/erlimem_session.erl
0
7
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/erlimem_session.erl
1
43.0%

Totals

Change from base Build 39:
-0.2%

Covered Lines:
101

Relevant Lines:
226

💛  - Coveralls


Feature: support prometheus/grafana for camellia-id-gen

If you have similar needs, please leave a message in this issue.

#186


Error using codex

Selecting codex gives this error:
HTTP Error: {"message":"The model:code-davinci-002does not exist","type":"invalid_request_error","param":null,"code":"model_not_found"}
Maybe the model changed name?

Codex is now deprecated. Just removed codex option from select.


IPython kernel hangs and does not restart when running files with Automatic graphics backend and using Wayland

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
When using the Graphics backend toAutomatic, running files (F5) hangs and it is not possible to restart the IPython kernel with Spyder 5.1.3 on Linux.
What steps reproduce the problem?

Set Graphics backend to Automatic
Try to run a file: IPython hangs (may take a couple of runs)
Try to restart a IPython kernel: nothing happens

What is the expected output? What do you see instead?
I should be able to run files and restart kernels without IPython hanging.
 I can't reproduce this problem, so please upload an animated gif that shows us how to do it in our side.

@ccordoba12 I hope this can help:
https://user-images.githubusercontent.com/26257211/133003750-7c5b0478-04cf-4b73-b2a9-724b82fdd742.mp4

I have the same problem on windows.
I have manage to replicate the bug on 3 different computer, all with W10, some with fresh environment or anaconda installation.
On python 3.8.11 the bug appear when using a graphics backend other than inline (the bug appear with either Automatic, Qt5, Qt4 and Tkinter) and selected "Remove all variable before execution".
On temp.py the bug doest appear all the time, but with another file(for example an untitled) it appear all the time.
I manage to replicate it on spyder 5.0.5 and 4.2.5 but only on python 3.8. I haven't manage to replicate it with python 3.9.
It's possible to de-freeze the kernel by opening, or closing, or interacting with another console.
I might be able to show an animated gif latter

I have the exact same issue, including after updating to 5.1.4.

Hey @remisalmon, thanks for the video. I think this problem has to do with Wayland because Conda/Conda-forge Qt packages don't have support for it.
Could you run Spyder under an Xorg session and report back again?

@PhanAlexandre, about your problem (which is totally different), please see issue #16138.

@ccordoba12 you're right: no issue restarting the kernel under Xorg, only when using Wayland + the automatic graphics backend.

Ok, glad to know. What if you switch the backend to Inline in our Preferences, restart the kernel, and then run this code in the console?
import os
os.environ['XDG_SESSION_TYPE'] = 'x11'
%matplotlib qt

After that, please try to create a plot. That should work because it makes the Qt conda-forge packages to fallback to Xorg and avoid trying to use Wayland.

Forcing os.environ['XDG_SESSION_TYPE'] = 'x11' did work (qt plots + able to restart the kernel).
Not sure why it did not work right away since Spyder print this in the terminal before starting:
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.

Ok, that's really good to know. We'll try to fix this before the end of the year.

This problem can be found in Spyder 5.0.0 and higher version. Spyder 4.2.5 and lower version can work smothly without such problem.

Looks like this issue was fixed somehow, closing since I can't reproduce anymore with Spyder 5.3.3.

There's nothing that has changed in Conda/Conda-forge packages or in our side, so we still need to address it.

I still have this problem in 5.4.2

@James-F1dev, this is a Linux only issue. Since you problem is different, please open a new issue about it.


Warning if flushingCounter is used with prometheus

As seen below, the default metricType is the flushingCounter. This is not a good default if you use a pulling metric system like prometheus.
https://github.com/prebid/prebid-server-java/blob/69042cdb84beaf41f388e561ebf525125da0249b/docs/config-app.md?plain=1#L222
We also had this problem and collected wrong metrics for nearly two years.
I would suggest to show a warning when prometheus is used in combination with the flushingCounter, so you have a chance to change the metricType when using prometheus as metrics collector.

Can you elaborate on why this is a bad combination? Or is there any other documentation around this? The only thing I can find is what's described in that config. It's not entirely clear to me what each metric type means. Is there a recommendation for which one to use when prometheus is used?

Hi @ngjmcdonald
If you use a metric system that receives values via push (e.g. OpenTSDB) it's the systems responsibility when and what metrics are being pushed. Each push resets the metrics and retries may appear, but the counter is only reset once and the values are only read once. Or during rolling deployments each system that startsup starts fresh and pushes appear always in the same time period.
In a pulling system (e.g. prometheus) this works differently. If the metrics endpoint is called twice, you will see different results even if the metrics may have not changed, which is wrong. A GET call by a prometheus scraper should not alter the metrics. Only the system itself should alter the metrics. Retries, devs or other healthcheck systems calling the metrics endpoint will all alter the metrics, making them invalid.

Clarified with Amy: We use counter instead of flushingCounter

https://github.com/prebid/prebid-server-java/pull/1909

Resolved in https://github.com/prebid/prebid-server-java/pull/1909


[Storage] Updates from arch review for STG81

API changes have been detected in azure-storage-blob. You can review API changes here

API changes have been detected in azure-storage-file-share. You can review API changes here


token's circulating supply

I didn't see a way to get a token's circulating supply, did I just miss it?

hi @al-matty, that should be get_total_supply_by_contract_address (example) :)

hi @al-matty, that should be get_total_supply_by_contract_address (example) :)

Wow, thanks for your work. Since I'm new to this, what'd be the best way to dive into the usage of etherscan-python?

Wow, thanks for your work. Since I'm new to this, what'd be the best way to dive into the usage of etherscan-python?

hmm I would say you should brainstorm about how a blockchain explorer, such as Etherscan, could be of help to you and what kind of projects you can build based on the data you download from there. Then, you can visit the API and see what types of data are actually available and how you can adjust them to the needs of your project (or maybe how to adjust the project to the types of data that you have access to). Be mindful though, Etherscan allows for 5 queries per second, so try to mindful with your queries otherwise you might end up getting temporarily restricted from accessing it :)

hmm I would say you should brainstorm about how a blockchain explorer, such as Etherscan, could be of help to you and what kind of projects you can build based on the data you download from there. Then, you can visit the API and see what types of data are actually available and how you can adjust them to the needs of your project (or maybe how to adjust the project to the types of data that you have access to). Be mindful though, Etherscan allows for 5 queries per second, so try to mindful with your queries otherwise you might end up getting temporarily restricted from accessing it :)

That's perfect, thanks.

That's perfect, thanks.


can't use inside ng-grid/ui-grid

I am trying to use bootstraptoggle withing ng-grid (newer version is called ui-grid)- http://angular-ui.github.io/ng-grid/ .
I can not see toggle button. I can see checkbox instead of toggle. Not sure is it still in developement or what.

you need to make sure the checkbox has data-toggle="toggle"
here's a demo of this working with ng-grid
http://plnkr.co/edit/qkx9NsQcmKaxtCbQO1TO?p=preview


VT-X/AMD-v Detection...

AMD FX-8370 Eight-Core Processor
Windows 10 Pro Version 1803 (Build 17134.753)
Docker version 18.09.3, build 774a1f4eee
VBoxManage Version 6.0.6r130049
I see there was some changes regarding VT-X detection in the recent release.
by any change did this break something?
I'm honestly not sure how to roll back the software as I kinda just updated on a whim (my fault).
Playing around with docker-toolbox at the moment and attempting to recreate my "default" machine seems to be giving me some grief...
$ docker-machine create default
Running pre-create checks...
Error with pre-create check: "This computer doesn't have VT-X/AMD-v enabled. Enabling it in the BIOS is mandatory"

I attempted to look for related issues regarding this and really saw nothing that would help; (So my apologize if I'm duplicating) some peoples examples had issues with "nested virtualization" and that doesn't fit my case as I'm just running toolbox on bare-metal windows.

Issues just keep piling on and nobody is merging fixes.
See https://github.com/docker/machine/issues/4669 for a fix you'll have to build yourself

Had the same problem too, but try to check out this one (https://github.com/docker/machine/issues/4271). docker-machine create default --virtualbox-no-vtx-check worked for me.

Had the same problem too, but check out this one (https://github.com/docker/machine/issues/4271). Adding --virtualbox-no-vtx-check worked for me.


AuthorizeRemoteTxRequests key functional implementation

Hello Matth,
We are considering the functional implementation of AuthorizeRemoteTxRequests key in the library. Could you provide any guidance on how to get started?
Thank you in advance for your assistance.
Regards,
Imanol

Hi @imanolmc,
The relevant point in the code is here:
https://github.com/matth-x/MicroOcpp/blob/8b1f0fdbae8785c49453f0b2d54a1a8db2fbe3ed/src/MicroOcpp/Operations/RemoteStartTransaction.cpp#L100
beginTransaction_authorized assumes that the given idTag is already successfully authorized. In constrast, beginTransaction would try authorizing it again, including sending an Authorize request.
You can alter the configuration mutability here: https://github.com/matth-x/MicroOcpp/blob/8b1f0fdbae8785c49453f0b2d54a1a8db2fbe3ed/src/MicroOcpp/Model/ConnectorBase/ConnectorsCommon.cpp#L39
The parameters for R/W configs look like this:
https://github.com/matth-x/MicroOcpp/blob/8b1f0fdbae8785c49453f0b2d54a1a8db2fbe3ed/src/MicroOcpp/Model/ConnectorBase/Connector.cpp#L50
Again back to RemoteStartTransaction, you can read the configuration value by declaring it there and using the getBool() function similar to here:
https://github.com/matth-x/MicroOcpp/blob/8b1f0fdbae8785c49453f0b2d54a1a8db2fbe3ed/src/MicroOcpp/Model/ConnectorBase/Connector.cpp#L264


Improve settings page's user interface

Some changes have been made to the looks in Settings page

Thanks @anirudhjain75 ! Closing to match your helpful expectation-setting on #1959 that you won't be working on this for now.
For @anirudhjain75 and anyone else pursuing this issue: one thing that would help make it easier to merge and to help us converge on a high-quality result would be to identify in the commit message what the changes are, and where there are several independent changes to break the PR up into separate commits for each change. Details in this doc: https://zulip.readthedocs.io/en/latest/contributing/version-control.html

@anirudhjain75 I hope this was educational for you. Not every PR gets merged, but every PR leads to learning. 👍


Doc viewing in GitHub note

Insert a document viewing note in the repo's README.md. This is a follow up to #1758.

Probably needs to be replicated on every repo unfortunately.

That's fine, I'll do it.


JSPool default folder

Hi,
How can I set the default folder for the JSPool file watcher? right now seems like it is pointing to my whole root directory.
Thanks

Found the answer at:
https://github.com/reactjs/React.NET/issues/253
But does not work, JSPool watching entire user directory is still an issue


Update README.md

Update README.md for instructions on using xdebug

@felixfbecker should I go more into detail with using the  VSCode PHP debug plugin?


Add tests for height and anchor

Add additional tests for height and anchor

Shouldn't VerificationActivity also be update?


Final Amendments To Use Case Section

Final Amendments To Use Case Section

This is the main change for all use cases:

To follow the Use Cases (particularly MSS and Extensions) format from Tutorial
No "Use case ends." at the end of extensions. It needs to be inside each extension.
If the extension is an error, then "Use case ends."
If the extension is just some invalid value, then ""Use case resumes from Step X."


Consider running cargo-hack and cargo-unused-features in CI

We don't really have a great story today for ensuring that our feature dependencies are 100% correct, both in terms of building crates in isolation or non-typical scenarios, and in terms of being truly minimal. There are tools out there that claim to be able to detect these cases, namely https://crates.io/crates/cargo-hack and https://crates.io/crates/cargo-unused-features (and maybe others?). I don't think running these on PR gates makes sense given their likely long runtimes over our large codebase, but maybe running them on a daily job would make sense?

There's also apparently the unused-crate-dependencies lint, which can get much more precise than our current cargo-machete-ish approach, but requires actually building. Combining it with cargo-hack could be nice, but would probably take some work to get clean.


Added UniqueTransactionIdException to handled exceptions

Hi Vegard,
I don't want to bother you to much but could you please look at my pull request? It would be great if I could get this one in also.  👍

Thanks. Deployed as 0.1.4.


Application Insight ConnectionString

Recently, Some Azure services require the Application Insight connection string instead of the Instrument key.
Shall I request to add the connection string property to application insight State?
Thanks
Steven

Do you mind providing some examples?


[BACKLOG-31992] Remove MDC calls

These calls aren't needed with the new approach.
The --uuid option for Pan/Kitchen isn't really either, but it probably will be for future work, and those are very low impact, so we'll leave them in for now.

:gear: Build finished in 17m 11s with command:
mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -pl engine

:ok_hand: All tests passed!

Total
Failed
Skipped

3579
0
7

Details

:information_source:  This is an automatic message


Picker Issue on iOS Maximum update depth exceeded

I have gone through these following points

[x]   Check latest documentation: https://docs.nativebase.io/
[x]   Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
[x]   Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
[x]   Check examples from NativeBase KitchenSink https://github.com/GeekyAnts/NativeBase-KitchenSink
[x]   For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/
[]   For queries related to theme, check Theme Variables from Docs and live NativeBase Theme Editor http://nativebase.io/customizer/

Issue Description

node, npm, react-native, react and native-base version, expo version if used, xcode version
package.json
# node v10.16.0 npm v6.9.0
{
  "main": "node_modules/expo/AppEntry.js",
  "scripts": {
    "start": "expo start",
    "android": "expo start --android",
    "ios": "expo start --ios",
    "eject": "expo eject"
  },
  "dependencies": {
    "@expo/vector-icons": "^10.0.3",
    "axios": "^0.18.0",
    "expo": "^33.0.0",
    "expo-constants": "^5.0.1",
    "expo-facebook": "~5.0.1",
    "expo-font": "~5.0.1",
    "expo-image-picker": "~5.0.2",
    "expo-location": "~5.0.1",
    "expo-permissions": "~5.0.1",
    "expo-web-browser": "^5.0.3",
    "firebase": "^5.11.0",
    "firebase-admin": "^7.0.0",
    "moment": "^2.24.0",
    "native-base": "^2.13.0",
    "prettier": "^1.18.2",
    "react": "16.8.3",
    "react-native": "https://github.com/expo/react-native/archive/sdk-33.0.0.tar.gz",
    "react-native-axios": "^0.17.1",
    "react-native-keyboard-aware-scroll-view": "^0.8.0",
    "react-native-modal-overlay": "^1.3.1",
    "react-navigation": "^3.3.2",
    "react-redux": "^6.0.1",
    "redux": "^4.0.1",
    "redux-form": "^8.1.0",
    "redux-logger": "^3.0.6",
    "redux-saga": "^1.0.2",
    "redux-saga-firebase": "^0.15.0",
    "relative-date": "^1.1.3",
    "sentry-expo": "~1.13.0"
  },
  "devDependencies": {
    "babel-preset-expo": "^5.0.0",
    "remote-redux-devtools": "^0.5.16"
  },
  "private": true
}

Expected behaviour
Picker does not throw a Maximum update depth executed error.
Actual behaviour
Picker throws Maximum update depth executed error
Steps to reproduce

Removing this code will not give the error, but I need to use a picker.
                                    <Item picker>
			              <Picker
			                mode="dropdown"
			                iosIcon={<Icon name="arrow-down" />}
			                style={{ width: undefined }}
			                placeholder="country"
			                placeholderStyle={{ color: "#bfc6ea" }}
			                placeholderIconColor="#007aff"
			                selectedValue={this.state.country}
			                onValueChange={this.onCountryChange.bind(this)}
			              >
			                <Picker.Item label="Canada" value="Canada" />
			                <Picker.Item label="United States" value="United States" />
			              </Picker>
			            </Item>

Is the bug present in both iOS and Android or in any one of them?
iOS
Any other additional info which would help us debug the issue quicker.

x2

Same problem with version 2.13.0. I made a downgrade of native-base to 2.12.1 to solve the problem

@pierol, unfortunately. The downgrade did not work for me :(

same here!!! getting crazy with this... I need the picker.. everything was working perfect with this:
"expo": "^32.0.0",
"native-base": "^2.12.1",
"react": "16.5.0",
"react-native": "https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz"
Now with these configs:
"expo": "^33.0.0",
"native-base": "^2.13.0",
"react": "16.8.3",
"react-native": "https://github.com/expo/react-native/archive/sdk-33.0.0.tar.gz",
I get the same error!

Ps. Picker is not the only component with problems after upgrading to 2.13. The SwipeRow has a problem with the "this._panResponder" being undefined!
TypeError: TypeError: undefined is not an object (evaluating 'this._panResponder.panHandlers')
This error is located at:
in SwipeRow (at connectStyle.js:392)

Same issue with the 2.13.0 release, going back to 2.12.2 resolved the issue for me.

Trying to find the culprit, i'm  suspecting from commit 5abaf57c3c93cf81bd0ccf5f04d92497b4230515
Downgrading to 2.12.2 solved it.
Fix ASAP

Seem like all controlled components has the same issue with 2.13.0 release.

setState in componentDidUpdate causing issue there should have been a proper code review before merging any PR
I am also facing issue on TextInput while onChangeText fix it locally by removing setState in the node modules files but this is not a proper solution I have seen this issue also happening in other controlled components

Yes, noticed it, in the process of adding getDerivedStateFromProps as we speak. Should be out in an hour or two.

@mubashiralisiddiqui Can you please share the use case for issue with TextInput?
How do we reproduce it?

Downgraded from 2.13.0 to 2.12.2  but It's not working with expo 33

@mubashiralisiddiqui Can you please share the use case for issue with TextInput?
How do we reproduce it?

simlply when you call the onChangeText method on

<INPUT onChangeText={(text) => onChange(text)} />

and when you start typing  that issue will produce
secondly, there are some other bugs I found
1)Tabs active color not working while changing the Tab

in Icon tab icon color not working
3)SwipeRow not working crashing the app

these are major bugs how can we proceed development under these situations?
please fix these ASAP

Please create separate issues for the above or they might go unattended.
If it is seriously hindering your development please consider creating PR's to fix the issues :)

The picker issue has been fixed with the latest release.
Currently figuring out a fix for the Tab text color.
Please raise separate issues with reproducible steps.

npm install native-base --save use this command and resolve issue (100% resolved)


Add jitpack Java client

So

Tests seem to be broken, which must be prior to this commit as it doesn't touch the tests or the service.

Also the tests are abstracted away from the workflow file enough that there's no useful debugging info in the output

The docker build is coded to fail if the target branch isn't master (why is it running in that case...?)
The 2 tasks marked as required don't run at all based on the current GHA workflows

All I want to do it publish a client jar,which has nothing to do with any of this stuff and it completely orthogonal.
You can see the published jars here: https://javadoc.jitpack.io/com/github/kbase/sample_service/24ee07f
Javadoc: https://javadoc.jitpack.io/com/github/kbase/sample_service/24ee07f/javadoc/
... so it's clear the changes here work.
I'm proposing that if you're ok with the changes here we go ahead and merge and deal with the broken build some other day.

not sure why tests are broken now. But this PR certainly shouldn't affect tests. so 👍


Could not find grgit-core-4.0.1.jar

Current Behavior
When use Idea with gradle 6.8.3 to build project, got error: Could not find grgit-core-4.0.1.jar (org.ajoberstar.grgit:grgit-core:4.0.1)
Searched in the following locations:
https://plugins.gradle.org/m2/org/ajoberstar/grgit-core/4.0.1/grgit-core_4.0.1.jar
And we checked repo.maven.apache.org/maven2/org/ajoberstar/grgit/grgit-core/
the min version is 4.1.1
Does 4.0.1 deleted？
Expected Behavior
Should can download from https://plugins.gradle.org/m2/org/ajoberstar/grgit-core/4.0.1/grgit-core_4.0.1.jar
Context (optional)
No response
Steps to Reproduce
Any new project is ok
Gradle version
6.8.3
Build scan URL (optional)
No response
Your Environment (optional)
No response

Please check https://blog.gradle.org/portal-jcenter-impact and https://jfrog.com/blog/jcenter-sunset/
I suppose the org.ajoberstar:grgit-core:4.0.1 is only available from JCenter.
JCenter will vanish completely on August 15th, if you can't update whatever requires the library then you need to make a backup of the dependencies that are on JCenter to keep your build working after August 15th.


Destroy not working on resize

while I am resized window destroy method is not working, can you please give an example of destroy method used

Hi.  Can you show me the page?
Cheers!

Yes I need to destroy slider on greater 640px window size and Re init while window resize less then 640px screen
let me share Code pen example for it.
https://codepen.io/pixlogix/pen/bjXXmE

By the way, you should put some logs inside the IF...ELSE statements and see if the code inside is executed.


Switch from S3 to Google Drive and automate with concourse

Trello: https://trello.com/c/vk9FZSzS/204-work-out-if-how-we-can-automate-the-data-extraction-and-sharing-of-files
This reflects a change in the automation strategy where we have stopped using the Amazon S3 to upload files and are instead using Google Drive. It also covers a recent product development to provide a hashing functionality for email and phone fields.
This PR ends up doing a bunch of stuff (apologies it should have been separate PR's, I just kept adding to the same branch 😞 ). Things are explained in commits but here is a summary:

Remove S3 integration and the s3_export task
Creates a drive_export task and integrates with Google Drive API to share files
Integrates with Notify to share links to files
Includes two extra columns in Data Labs' export (hashed_email and hashed_phone) which use a SHA256 function and a salt (defined by SECRET_KEY env var) to anonymise the hash
Adds a concourse pipeline file with the automatic job and the means to run a one off test job
Outputs a slack message text file on the drive_export task which is used to create a dynamic Slack notification

Thanks @issyl0 👍


'Meter number is not registered (Error code: 8001)' in production

Hello, i am triying go to production, with use_test_server=False and date productions for meter number and more, but fedex create_shipment display: 'Meter number is not registered (Error code: 8001)'.
Help me please, thank you

I ran into this when using updated WSDL for shipping service too.


is this product still being developed? (Enterprise State Roaming)

I tried the implementing ESR in my environment but could not get certain things to sync:
Store apps application settings + desktop settings + ease of access settings + mouse settings
Any advice would be helpful
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 470c6ca6-d2d1-e9b6-c5ae-cceeee3865d6
Version Independent ID: e7d1f96f-a470-76ba-ec0e-0b649dc0aac2
Content: What is enterprise state roaming in Azure Active Directory?
Content Source: articles/active-directory/devices/enterprise-state-roaming-overview.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@Eurosome
Thanks for your feedback! We will investigate and update as appropriate.

Hi @Eurosome,
It does synchronize most of the settings and should synchronize the mouse settings as long as you have enabled it to do so. Most of your personalized Windows settings should port over. I know that the left/right swap for the mouse wasn't working, and there was a feedback item open to include that.
Stale data may also not be included. https://docs.microsoft.com/en-us/azure/active-directory/devices/enterprise-state-roaming-enable
Details about which settings are synchronized are included in the reference guide: https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/active-directory/devices/enterprise-state-roaming-windows-settings-reference.md
Let me know if this helps! If you have further questions I would recommend posting to Microsoft Q&A. https://docs.microsoft.com/answers/topics/azure-active-directory.html?filter=unanswered


Test inventory + scanner with CAI enabled vs disabled

This will run 2 scans: one with CAI enabled and one with CAI disabled. It will compare the violations for these scanners: Bucket, Firewall, IAM, Location.
Resolves #3486

/gcbrun

/gcbrun

@goofiva Latest test results look good:
✔  inventory-cai-enabled-vs-disabled: Command: `sudo gsutil cp -r gs://forseti-server-6e5f37fa/rules $FORSETI_HOME/`
     ✔  Command: `sudo gsutil cp -r gs://forseti-server-6e5f37fa/rules $FORSETI_HOME/` exit_status should eq 0
     ✔  Command: `forseti model use CaiEnabled5d60ef6ff17` exit_status should eq 0
     ✔  Command: `forseti model use CaiEnabled5d60ef6ff17` stdout should not match /Error communicating to the Forseti server/
     ✔  Command: `forseti scanner run` exit_status should eq 0
     ✔  Command: `forseti scanner run` stdout should match /Scan completed/
     ✔  Command: `forseti scanner run` stdout should match /Scanner Index ID: ([0-9]*) is created/
     ✔  Command: `sudo python3 /home/ubuntu/forseti-security/integration_tests/tests/forseti/scripts/update_server_config.py set_cai_enabled false` exit_status should eq 0
     ✔  Command: `forseti model use CaiDisabled5d60ef6ff17` exit_status should eq 0
     ✔  Command: `forseti model use CaiDisabled5d60ef6ff17` stdout should not match /Error communicating to the Forseti server/
     ✔  Command: `forseti scanner run` exit_status should eq 0
     ✔  Command: `forseti scanner run` stdout should match /Scan completed/
     ✔  Command: `forseti scanner run` stdout should match /Scanner Index ID: ([0-9]*) is created/
     ✔  Command: `mysql -u forseti_security_user -pLhCbuY03Kjq7CiuU --host <IP_ADDRESS> --database forseti_security --execute "SELECT COUNT(resource_id) FROM (SELECT V.violation_type, V.resource_id, V.resource_type, V.rule_name FROM violations V JOIN scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>302643 UNION ALL SELECT V.violation_type, V.resource_id, V.resource_type, V.rule_name FROM violations V JOIN scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>401947) Violations WHERE violation_type in ('BUCKET_VIOLATION', 'FIREWALL_BLACKLIST_VIOLATION', 'IAM_POLICY_VIOLATION', 'LOCATION_VIOLATION') GROUP BY violation_type, resource_id, resource_type, rule_name HAVING COUNT(*) = 1;"` exit_status should eq 0
     ✔  Command: `mysql -u forseti_security_user -pLhCbuY03Kjq7CiuU --host <IP_ADDRESS> --database forseti_security --execute "SELECT COUNT(resource_id) FROM (SELECT V.violation_type, V.resource_id, V.resource_type, V.rule_name FROM violations V JOIN scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>302643 UNION ALL SELECT V.violation_type, V.resource_id, V.resource_type, V.rule_name FROM violations V JOIN scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>401947) Violations WHERE violation_type in ('BUCKET_VIOLATION', 'FIREWALL_BLACKLIST_VIOLATION', 'IAM_POLICY_VIOLATION', 'LOCATION_VIOLATION') GROUP BY violation_type, resource_id, resource_type, rule_name HAVING COUNT(*) = 1;"` stdout should match //
     ✔  Command: `sudo python3 /home/ubuntu/forseti-security/integration_tests/tests/forseti/scripts/update_server_config.py set_cai_enabled true` exit_status should eq 0
     ✔  Command: `forseti inventory delete<PHONE_NUMBER>302643` exit_status should eq 0
     ✔  Command: `forseti model delete CaiEnabled5d60ef6ff17` exit_status should eq 0
     ✔  Command: `forseti inventory delete<PHONE_NUMBER>401947` exit_status should eq 0
     ✔  Command: `forseti model delete CaiDisabled5d60ef6ff17` exit_status should eq 0


RDG001 warning /5

Fixes #30423

Internal previews

📄 File
🔗 Preview link

aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/RDG001.md
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/RDG001

@guardrex  check the build, all blazor errors.

@captainsafia do you want something like this?

@Rick-Anderson ... It looks like the 🧀 moved on the API for the RC1 release because these didn't throw when I placed them. They have different namespaces now. I'll create a new PR now to fix them up.

It looks like the 🧀 moved on the API for the RC1

Common for early APIs, I'm guessing no more   🧀 moving
Thanks for the fix

Replaced by #30446


Updated TLD list

Source http://data.iana.org/TLD/tlds-alpha-by-domain.txt
Closes #621

Travis is failing because of #620

@mhujer
Thanks! :+1:


[DEFECT] For some ROMs especially those that use KDtree, it reaches maximum recursion times.

the following error: 'Maximum recursion depth exceeded while calling a python object' appeared when using Gaussian polynomial with stochastic collocation.
Describe the defect
errors out:'Maximum recursion depth exceeded while calling a python object' appeared when using Gaussian polynomial with stochastic collocation.
What did you expect to see happen?
nothing.
What did you see instead?
Rom was not trained.
Do you have a suggested fix for the development team?
Describe how to Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.
Screenshots and Input Files
Please attach the input file(s) that generate this error.  The simpler the input, the faster we can find the issue.
Platform (please complete the following information):

OS: [e.g. iOS]
Version: [e.g. 22]
Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

@Jimmy-INL do you have a test case that can replicate the error?

This was encountered by our intern, I am not sure that I will have a test case. But I remember that @PaulTalbot-INL  suggested a fix for that and it worked.


Support stdout/stdin as output/input file

Looks like the relevant code is here for stdout and here for stdin. Maybe - could be replaced with a stdout/in operation, as it is a convention for both stdin and stdout in many Unix programs.

It would make most sense to simply read from STDIN when no input files given, and write to STDOUT when no --out-file option specified.


Post monocart-reporter installation, execution happens only on chrome

Post monocart-reporter installation, execution happens only on chrome/first browser in config file.
was there any config file change/update needed?
if i uninstall monocart-reporter package, i can run on all browsers.
again after installation, the execution happens only on chrome browser or /first browser in config file.
also by default the execution is headless even i opted for headless=false.
Thank you.

Can you provide us reproduction steps? So we can reproduce it locally?

I have 8 tests in one file and monocart-reporter not installed yet.
enabled 3 browsers in config file and executed the file and got 24 test results.
then installed monocart-reporter:
$ npm i -D monocart-reporter
added 62 packages, and audited 71 packages in 10s
5 packages are looking for funding
run npm fund for details
found 0 vulnerabilities
added below options to config file:
const date = new Date().toISOString().slice(0, 10); //2022-10-10
const outputDir = ./test-results/${date};
module.exports = {
reporter: [
['list'],
['monocart-reporter', {
name: NursingHomeAssessment-html-report ${date},
outputFile: ${outputDir}/index.html,
trend: './test-results/report.json',
  // custom columns
  columns: (defaultColumns) => {

    // insert custom column(s) before a default column
    const index = defaultColumns.findIndex((column) => column.id === 'duration');
    defaultColumns.splice(index, 0, {
      // define the column in reporter
      id: 'owner',
      name: 'Owner',
      align: 'center',
      searchable: true,
      styleMap: {
        'font-weight': 'normal'
      }
    })
  },
}
]

]
};
Ran the same file with same command as before:
now the execution is headless
the execution happened only on chrome which is my 1st option in config file.
report generated for only 8 tests and other 2 browsers are not executed on.
now i commented chrome in config file and ran again:
this time again 8 tests are executed on Edge browser but Firefox is not used for execution.
i uninstalled monocart-reporter and uncommented chrome and ran same file with 8 tests:
now i got 24 test results and browsers are opened even i did not change headless true or false.
if you are looking for specific details, please let me know.

That's weird.  Technically speaking, custom reporter will not affect the operation of Playwright.
here is a exmaple for multiple browsers:
https://github.com/cenfun/monocart-reporter-examples/blob/main/tests/projects/playwright.config.js
It seems works well

Did you used latest version of Playwright? and what is the version of monocart-reporter, and also Node.js version?

Can you share the full playwright config file?
You said that you enabled 3 browsers in config file, I didn't see these in the config you provided.

Please see the full config file:
import { defineConfig, devices } from '@playwright/test';
// playwright.config.ts
import { PlaywrightTestConfig } from '@playwright/test';
const config: PlaywrightTestConfig = {
// For browser actions
testMatch: /.*.js/,
use: {
},
}
const configa = {
use: {
screenshot: 'on',
setTimeout: 600000,
},
launchOptions: {
slowMo: 2000,
args: ["--start-maximized"],
},
};
const date = new Date().toISOString().slice(0, 10); //2022-10-10
const outputDir = ./test-results/${date};
module.exports = {
reporter: [
['list'],
['monocart-reporter', {
name: NursingHomeAssessment-html-report ${date},
outputFile: ${outputDir}/index.html,
trend: './test-results/report.json',
  // custom columns
  columns: (defaultColumns) => {

    // insert custom column(s) before a default column
    const index = defaultColumns.findIndex((column) => column.id === 'duration');
    defaultColumns.splice(index, 0, {
      // define the column in reporter
      id: 'owner',
      name: 'Owner',
      align: 'center',
      searchable: true,
      styleMap: {
        'font-weight': 'normal'
      }
    })
  },
}
]

]
};
//export default config;
export default defineConfig({
testDir: './tests',
// testDir: './pomtests',
/* Run tests in files in parallel /
fullyParallel: false,
retries: 0,
testMatch: ["login.test.ts"],
/ Fail the build on CI if you accidentally left test.only in the source code. /
forbidOnly: !!process.env.CI,
workers: process.env.CI ? 1 : undefined,
/ Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: [["dot"], ["json", { outputFile: "test-result.json" }], ["html", { open: "always" }],
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. /
use: {
/ Base URL to use in actions like await page.goto('/'). /
// baseURL: 'http://<IP_ADDRESS>:3000',
baseURL: "",
headless: false,
/ Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: 'on-first-retry',
//screenshot: 'only-on-failure',
screenshot: 'on',
//video: 'retain-on-failure',
video: 'on',
},
/* Configure projects for major browsers */
projects: [
{
name: 'chromium',
// use: { ...devices['Desktop Chrome'] },
  use: {
    ...devices['Desktop Chromium'],
    viewport: null,

    launchOptions: {
      args: ["--start-maximized"]
    }
  },
},

{
  name: 'Microsoft Edge',
  use: {
    // Supported Microsoft Edge channels are: msedge, msedge-beta, msedge-dev, msedge-canary
    channel: 'msedge',
    launchOptions: {
      args: ["--start-maximized"]
    }

  },
},

{
  name: 'firefox',
  use: { ...devices['Desktop Firefox HiDPI'], launchOptions: { args: ["--start-maximized"] } }, //device names can be displayed when ctrl+space is pressed inside the devices array[]
},

/*

  {
    name: 'webkit',
    use: { ...devices['Desktop Safari'] },

  },

},
// Test against mobile viewports.
{
name: 'Mobile Chrome',
use: { ...devices['Pixel 5'] },
},
{
name: 'Mobile Safari',
use: { ...devices['iPhone 12'] },
},
  // Test against branded browsers.
   {
     name: 'Microsoft Edge',
     use: { ...devices['Desktop Edge'], channel: 'msedge' },
   },
   {
     name: 'Google Chrome',
     use: { ...devices['Desktop Chrome'], channel: 'chrome' },
   },
   */

// Run your local dev server before starting the tests
// webServer: {
//   command: 'npm run start',
//   url: 'http://<IP_ADDRESS>:3000',
//   reuseExistingServer: !process.env.CI,
// },

],
});

I found the problem, you have the wrong playwright config with a syntax error.
You can't write the js code export default defineConfig( and module.exports = { in the same file.

No. I use typrescript I'm beginner with JS.

I guess so and wish you luck.
It recommend you to use some tools such as VSCode and ESLint, they can alert you if there are any syntax errors.


Extension crash when selecting an image and trying any interaction (filter, caption)

Hi, I have images with a .txt file for each, and after updating right now the extension I get an error when I try to apply a caption
With this error :
 img_paths, _ = dataset_tag_editor.get_filtered_imgpath_and_tags(filters=[path_filter, tag_filter, tag_filter_neg])
TypeError: DatasetTagEditor.get_filtered_imgpath_and_tags() got an unexpected keyword argument 'filters'

And this red error before doing any interaction (excepted selecting an image)

Can you check the followings?

The commit hash is the same as latest one (3c5987e588ad780f6799c2495b4162c9b6fb22bc)?
Have you reboot the webUI after update this extension? The webUI cannot reload whole scripts of this extension.

Thank you.

I indeed had the latest commit, clicked to "apply and restart UI", but it worked only when I rebooted automatic1111 webui-user.bat.
Thanks


Changed code section

Unified the code sections to one box so the document is easier to use and follow

#sign-off


⚠ Bofrost.fr has degraded performance

In 494c234, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1307 ms

Resolved: Bofrost.fr performance has improved in 3813915.


fix '!' has type 'WidgetsBinding' | Flutter 3

Description
Fix
/lib/camerapreview.dart:146:20: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding'
which excludes null.

problems in flutter 3
Checklist
Before creating any Pull Request, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

[ ] 📕 I read the Contributing page.
[X] 🤝 I match the actual coding style.
[X] ✅ I ran flutter analyse without any issues.

Breaking Change

[ ] 🛠 My feature contain breaking change.

If your feature break something, please detail it

THank you for your help


chore: ignore apollo errors - to be reverted after candlesConnection API will be fixed

no formatting error, tests pass locally, pipeline should pass. thanks for re-triggering the unit tests and build @macqbat


Empty configuration during create panics the binary, but ideally should output actionable data

hi! I was trying to set this up and seems like credential resolution panics the binary instead of outputting something like "Empty ~/,harbor/config, please " - the patch for this is rather easy, should I start a PR or is this a candidate for the mentorship program?
Cheers and thanks!
Abhinav.

Hey @AbhinavMir and @Vad1mo.
I was just checking in on the issue, wanted to see if this is an OK solution :) (if so let me know I'll create a PR)
Given the error we can have at this point are regarding config issues it would make sense to exit quitely.
//pkg/utils/credential_store.go

func resolveCredential(credentialName string) (Credential, error) {
	credentialStore, err := readCredentialStore()
	if err != nil {
		return Credential{}, fmt.Errorf("failed to read credential store: %s", err)
	}

...
	if credentialName == "" {
		return Credential{}, fmt.Errorf("current credential name not set, please login again")
	}
...
	return Credential{}, fmt.Errorf("no credential found for the name: %s, please login again with the credential name: %s", credentialName, credentialName)
}

//pkg/utils/utils.go
func GetClientByCredentialName(credentialName string) *v2client.HarborAPI {
	credential, err := resolveCredential(credentialName)
	if err != nil {
		fmt.Print(err) // If error come from resolveCredential, it make sense to exist and print the user friendly message.
		os.Exit(1)
	}
...
}

Hi, I was planning to close this myself, but good for you! I am not a reviewer, and have no idea if this is the correct solution. Possibly start a PR for a review, I'm not aware of the review etiquette of this repo.
Cheers.

already fixed
// @Vad1mo


Feature request: disallowDotNotation

We'd like to enforce ES3 compatibility for the bootstrapping file for our project, so that IE8/etc. won't just JS-fatal and break other things.
Right now we have:

es3: true,
requireDotNotation: { 'allExcept': [ 'keywords' ] }

… but that's not enough. It lets us write obj[ 'default' ], but it doesn't give us a warning if we use obj.default.
Something like:

es3: true,
disallowDotNotation: { 'keywords' }

… would be helpful. Does this seem reasonable?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/25961330-feature-request-disallowdotnotation?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

I'm usually using jshint for these checks. Seems like you too. Is there some troubles with that?

I'm putting an orphaned label to note this issue isn't planned to be worked on, but might be a good contribution as a custom rule (not in core). We can all check back on this list for future rule ideas/options.
We released 3.0 recently! We also wrote a post about how 3.0 will be our last major release (since we are deprecating the project) and that we are merging with ESLint!
Thus we won't be working on any new features moving forward which includes new rules/options. We will continue to fix bugs and work on CST/better autofixing for current rules in the upcoming months both to help JSCS users and to gain experience that we can hopefully use in ESLint. But otherwise we both teams will be working on getting ESLint feature parity with JSCS and just a nice transition for our users.
I would encourage anyone who wants the rule to try writing it themselves: I would either write a custom rule or submit an issue to ESLint and if accepted a PR. Otherwise a custom rule that won't be in core repo itself.
JSCS rules are also very similar to ESLint rules: here are some resources to get started:

Project-specific Lint Rules with ESLint
Creating Custom Rules for ESLint
Maintaining JavaScript Code Quality with ESLint


Pugs and permission fixes. Uninstall fixes also.

Need more investigate what is wrong.
When installing non root user i get error in webpage.
Error in RaspiMJPEG:
Restart RaspiMJPEG (./RPi_Cam_Web_Interface_Installer.sh start) or the whole RPi.
I mast make more fresh install tests...

Test successful. Fresh Jessy install + ./RPi_Cam_Web_Interface_Installer.sh. + Apache
Installed when logged in with regular user pi. No errors. Camera working correctly.


minor spelling/typo fixes

resolves #54

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 86.252%

Files with Coverage Reduction
New Missed Lines
%

contracts/vaults/OptimisticRewards.sol
4
69.57%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
446

Relevant Lines:
503

💛  - Coveralls