Expose CesiumSunSky date and time properties to Sequencer

See https://github.com/CesiumGS/cesium-unreal/issues/760 - Previously, you could not animate the date or time in Sequencer. This PR exposes CesiumSunSky's Solar Time, Day, Month, Year, and Time Zone parameters to Sequencer.

Note that currently, CesiumSunSky's UpdateSun function must be called every frame in order for the animation to reflect in the scene. The best way I could find around that was to add a Repeater Event Track on CesiumSunSky in the sequencer, then binding that event to UpdateSun. Steps to do that below, since I'm not sure where else to document them:

Add CesiumSunSky to the Sequencer track
Click the "+ Track" button and select Event>Repeater from the menu
Double-click the new Event Track - it will create a new Sequence Director blueprint. Connect an Update Sun node to the event.

Keyframe your animation
To make sure it's working, right click on the event track and select Properties>Call In Editor.

Of course, there's a lot that could be improved here - it would be great if people didn't have to add the event track. But I imagine that would involve refactoring the SunSky so this is probably enough for now.

Thanks for the pull request @argallegos!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

There's actually a way to trigger UFUNCTIONs when sequencer-exposed variables are animated on a sequencer track:
https://docs.unrealengine.com/4.26/en-US/AnimatingObjects/Sequencer/HowTo/GameplayAnimBlending/#2-animationandcharacterblueprintsetup
It would make the most sense to implement this in C++. I can make the changes if that's most convenient.

Thanks @xuelongmu, that would be great!

Thanks again for your contribution @argallegos!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Hi, I tried adding the interp specifiers to the CesiumSunSky script in UE5 to expose the properties but does not reveal them in the sequencer.  Are there other changes required to make this work with UE5?

Adding Interp should work, but only if you recompile the plugin. Unreal won't pick up code changes that you make to an Engine plugin. You can try copying the plugin to your project's Plugins directory instead.

Great thanks for advice!

Hi... I'm a newb and so apologize for what is probably a stupid question:  How does one find the CesiumSunSky script in UE5, find the interp code necessary to expose the parameter in the sequencer, add the interp code, and then recompile the plugin.  Any help you can offer will be hugely appreciated!

If you've installed the plugin via the Epic Launcher, the code is usually found in C:\Program Files\Epic Games\UE_5.3\Engine\Plugins\Marketplace\CesiumForUnreal or similar for your UE version. The necessary change in this this PR; see the Files Changed tab. This is an old PR, though, so the files will have changed in the meantime, so you may have to adapt accordingly. The easiest way to recompile the plugin is to add it to your project's Plugins directory (copy the entire CesiumForUnreal directory there) and then Unreal will compile it on load, as long as your project is a C++ project. Convert a Blueprint-only to a C++ project by adding a C++ source file to it from the UE Editor. You'll need Visual Studio.

If you've installed the plugin via the Epic Launcher, the code is usually found in C:\Program Files\Epic Games\UE_5.3\Engine\Plugins\Marketplace\CesiumForUnreal or similar for your UE version. The necessary change is this this PR; see the Files Changed tab. This is an old PR, though, so the files will have changed in the meantime, so you may have to adapt accordingly. The easiest way to recompile the plugin is to add it to your project's Plugins directory (copy the entire CesiumForUnreal directory there) and then Unreal will compile it on load, as long as your project is a C++ project. Convert a Blueprint-only to a C++ project by adding a C++ source file to it from the UE Editor. You'll need Visual Studio.

This is beyond me, could you elaborate with a step-by-step instruction on how to make this work in UE5.3?
I'd very much appreciate your help with this.

No, we can't provide more detailed instructions than what I've already provided. If you have specific questions we may be able to answer them. Otherwise, you'll have to wait until this is incorporated into an official version of the plugin.

My specific question is: Is this supposed to also work in UE 5.3.2? On the instructions, the screenshots are for 4.26.
I have followed every step, copied the plugin folder, installed Visual Studio, created a project in C++, added the event repeater and connected the UpdateSun node, but nothing for time/date in the CesiumSunSky sequencer shows up.

As far as I know, the approach in this PR should work in 5.3.2 as well, but I haven't tried it.  If that doesn't help, I'm afraid I don't know what the problem might be, sorry.

Maybe I missed something, but what is the way to implement this PR?

Maybe I missed something, but what is the way to implement this PR?

Sorry, I don't understand your question.

Hi, finally managed to add the Interp specifier to CesiumSun&Sky properties in C++ file in Visual Studio, then tried to recompile plugin by copying the entire CesiumForUnreal folder (directory C:\Program Files\Epic Games\UE_5.1\Engine\Plugins\Marketplace)
to my project's Plugins directory (C:\Program Files\Epic Games\UE_5.1\Engine\Plugins) but UE crash when I restart ... Error message : "The following modules are missing or built with a different engine version" ... Tried to download the game development C++ package along with the Visual Studio update and generate new Visual Studio project file but nothing works !
Starting to be a bit annoyed with all of these too complex settings :(

The following modules are missing or built with a different engine version

That's normal when you put the plugin in your project directory.

Tried to download the game development C++ package along with the Visual Studio update and generate new Visual Studio project file but nothing works !

I can't help you unless you tell me in what way it doesn't work.

Starting to be a bit annoyed with all of these too complex settings

Sorry you're having trouble, but keep in mind you're trying to make the plugin do something it isn't meant to do by modifying it. That's always going to have some complexity, especially if you're not used to working with C++ code bases and don't already have a development environment set up.

Thank you for the following up Kevin. I understand that I'm trying to make the plugin do something it isn't meant to do. Hope there will be an update soon !
Once the CesiumforUnreal folder has been deplaced to Plugin folder, my uproject. don't open anymore. I have the "following modules are missing" error message and despite attempts to convert in C++ project (supposition found on forums) nothing works ... The only thing I can do is to trash the entire uproject and restart from zero

@mathieuvannereux First, try putting the CesiumForUnreal folder in your project's plugin folder, rather than your installed Unreal version's plugin folder. If your .uproject file is at C:/Dev/my-project, the plugin folder should be C:/Dev/my-project/Plugins/CesiumForUnreal. You might need to create the plugins folder if it doesn't exist already. Second, you're going to need to use Unreal 5.2 or newer, or revert to Cesium for Unreal 2.5.0 (the last version that supported Unreal 5.1). Third, try right-clicking on your uproject file and selecting "Generate Visual Studio project files" (you might need to click "Show more options" at the bottom of the right click menu first). This will create a .sln which you should open. At the top of the window, the three dropdowns next to the start button should be set to "DebugGame Editor," "Win64," and whatever your project name is. Now click the play button in Visual Studio ("Local Windows Debugger") to build and launch the editor.

Thank you @azrogers for your reply ! As you can see attached, I don't have Plugin folder in my project folder. Maybe because I use Unreal 5.1 and Cesium 2.2.0, it's probably for this reason I don't get the same directory hierarchy.


Calculate and Post Tax Settlement

Please document how to use "Calculate and Post Tax Settlement" with Sales Tax in US
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af8e82f4-8ef0-fdc8-384e-6a40e52b0095
Version Independent ID: 826c7b3b-6807-05b6-413d-7d393aa1cfd6
Content: Reporting Sales Tax in the US Version - Business Central
Content Source: business-central/LocalFunctionality/UnitedStates/us-sales-tax.md
Service: dynamics365-business-central
GitHub Login: @edupont04
Microsoft Alias: edupont

Hello,
Apologies for the wait. The Calculate and Post Tax Settlement feature work similarly to report requests in the application. You can learn more about the available options at the Run and print reports article. You can also hover over the available fields to read a short description.
Specifics about how to use the page with sales tax should be discussed with a tax expert on a case-by-case basis.

@rubenseishima thank you for answer
It is not question about how tax in general works, instead what exactly it does in BC , technically as a product documentation.
For example, which tables does it use, which statuses does it change (fields) etc.
I have some old documentation in old - de practiced NAV , so it should be updated and put here as information on how to use this functionality and its options

Hi,
Similar to the question about tax clauses, at the moment we can't promise an in-depth article on tax settlements.
Having said that, feel free to submit a documentation request on the Ideas site. Depending on the community support the idea may be fast-tracked.
I am sorry I couldn't be of more help.

Hello, I do not agree. This is not related to product or improvement or feature request or Idea.
This is related to documentation of the Product.


Adds PerceivedType to preview handler registration

Summary of the Pull Request
Adds PerceivedType to the registration of SVG and QOI Preview Handlers so that Windows will cast a shadow in the images as it does for other image file types.

PR Checklist

[X] Closes: #29766
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed
Manual validation.

/azp run

@jaimecbernardo
Does only the ci makes strange things or is there a problem with the code changes? 🤔 I am unsure what is going on that the build failed two times. 🤨

first build first failed on the unit tests... I then just rebased on latest "main" and force-pushed, now seems build is fine with the tests (no changes there) but failed further ahead...

/azp run

@pedrolamas , @crutkas
deps.json task fails and reports mismatch for one dependency.

I'm afraid there is nothing to sync, this PR is already done on top of the latest main branch!
I also ran this script locally, can back with no issues...

I've seen the PT CI build break for no reason at all, seems to me this is yet another example of that!

There's been a CI build machine update, which seems to have brought different dependencies which are conflicting. I'm on it ;) THank you!

Thanks for clearing that @jaimecbernardo! 🙂

Fixed by https://github.com/microsoft/PowerToys/pull/29858. Waiting to make sure CI passes there.

Merging main here should fix CI here too now that the fix is merged ;)

Thank you, build has gone green! 🙂

We need this for GCode and STL these formats are 3D images

Thanks @htcfreek, I've given this some thought to this, and I am not sure I agree.
Gcode files are not images. Gcode files contain CNC instructions, and some extra metadata (such as thumbnails, which is what we extract and expose).
STL files are not 3D images, they are 3D models. What we do here is render a representation of the model and then take a 2D shot of that rendering so we can use it as a thumbnail.

Think of these like PDF files: I think we can all agree that PDF files are not images, even though we get an image representation of these.

@pedrolamas
That's a true point. Then keep as is and wait for user feedback.


Updates on this library?

Hello, are there any updates on this library? ì
I have seen it has been called a continuation of Instagram4J but I cannot make it work
https://gist.github.com/nicecraftz/287ffd4e3437ac8b96f26cd86d4a0455
I am getting this error just when creating the instance of JxInsta with valid credentials.
Exception in thread "main" java.lang.IndexOutOfBoundsException: Empty list doesn't contain element at index 0. 	at kotlin.collections.EmptyList.get(Collections.kt:36) 	at kotlin.collections.EmptyList.get(Collections.kt:24) 	at com.errorxcode.jxinsta.Utils.getCrsf(Utils.java:100) 	at com.errorxcode.jxinsta.JxInsta.<init>(JxInsta.java:71) 	at it.alessandrocalista.Main.main(Main.java:22)

Please also share the code to reproduce the issue. What type of authentication were you using?

Is it happening only in WEB_AUTHENTICATION mode?

Really sorry for the no reply about this issue, will try tomorrow if i happen to remember it, lol.
sorry again.


Add TypeScript support

Typings are based on inspecting the properties available at runtime. Would be good to have them validated before merging.

ping @muaz-khan


python3Packages.ghrepo-stats: init at 0.3.1

Motivation for this change
Python module and CLI tool for GitHub repo statistics
https://github.com/mrbean-bremen/ghrepo-stats
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 151293 run on x86_64-linux 1

2 packages built:

ghrepo-stats (python39Packages.ghrepo-stats)
python38Packages.ghrepo-stats


Null-Pointer Exception on RN 0.33?

See https://github.com/orhan/react-native-android-blurryoverlay/pull/1#issuecomment-244776063

I have managed this to work without Activity, works fine with RN 0.33. Will make a PR later this week.

@priezz How did you manage to work without Activity
I am getting the same error:
Attempt to invoke virtual method 'android.view.View android.app.Activity.findViewById(int)' on a null
Thanks

Yes, I did. However, as I remember I have changed the logic of the module (applied it to parent Image only). Unfortunately I decided not to use blur at all because of the very slow processing - there is a noticeable delay (half a second or something) before the effect is applied and that looks really ugly from the user's side.

@priezz Thanks Ill give it a try


Update ES & KB for EE v3.14.4

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.


提交项目初始化代码

提交项目初始化代码。通过编译和测试用例，可以打包出附带havenask runtime环境的docker镜像

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


some errors when install kaldi-python

ubuntu 14.04.
use thi command(.setup.py install) to setup kaldi-pthon, I have set $KALDI_ROOT already
the errors are as follows:
/usr/include/python2.7/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
#warning "Using deprecated NumPy API, disable it by "
^
/usr/bin/ld: /home/jtang/Kaldi/kaldi-trunk/src/matrix/kaldi-matrix.a(kaldi-matrix.o): relocation R_X86_64_32 against .rodata' can not be used when making a shared object; recompile with -fPIC /home/jtang/Kaldi/kaldi-trunk/src/matrix/kaldi-matrix.a: error adding symbols: Bad value collect2: error: ld returned 1 exit status make[1]: *** [kaldi_io_internal.so] Error 1 make[1]: Leaving directory /home/jtang/Attention_ASR/kaldi-python/kaldi_io'
make: *** [all] Error 2
thse errors seem to happen in creating kaldi_io_internal.so, if I don't use these .a file  $(KALDI_SRC)/matrix/kaldi-matrix.a  $(KALDI_SRC)/util/kaldi-util.a $(KALDI_SRC)/base/kaldi-base.a ,
kaldi_io_internal.so can create(of course this file can't  be used)

As far as I remember Kaldi has to be compiled differently for Kaldi-python installation to be successful. @dmitriy-serdyuk , @janchorowski , can you please comment on that?

Can you tell me the methods you compile kaldi.......(aslo means : how can you get the file like kaldi_matrix.a.........)
<EMAIL_ADDRESS>From: Dzmitry Bahdanau
Date: 2015-11-20 23:34
To: rizar/attention-lvcsr
CC: Entonytang
Subject: Re: [attention-lvcsr] some errors when install kaldi-python (#2)
As far as I remember Kaldi has to be compiled differently for Kaldi-python installation to be successful. @dmitriy-serdyuk , @janchorowski , can you please comment on that?
—
Reply to this email directly or view it on GitHub.

Right, sorry, that I didn't mention this. Kaldi should be compile with shared flag:
./configure --shared --use-cuda=no # No need for cuda, we don't train models with kaldi
make

Could you please change the documentation? I guess it makes sense to do it our private repository, since we are going to make what we have there the new master pretty soon.

After change the configure command, problem solved......
this steps: $LVSR/bin/run.py train wsj_paper6 $LVSR/exp/wsj/configs/wsj_paper6.yaml
this default configuration trains model using CPU.......how to use GPU instead.......

You can use GPU in the same way as you usually do it with Theano. Please
read Theano documentation.
On 23 November 2015 at 05:51, Entonytang<EMAIL_ADDRESS>wrote:

After change the configure command, problem solved......
this steps: $LVSR/bin/run.py train wsj_paper6
$LVSR/exp/wsj/configs/wsj_paper6.yaml
this default configuration trains model using CPU.......how to use GPU
instead.......
—
Reply to this email directly or view it on GitHub
https://github.com/rizar/attention-lvcsr/issues/2#issuecomment-158903325
.

After adding "device =gpu3" while I find GPU Process in GPU 2(device K40).....using default wsj_paper6.yaml.....
it costs 65 seconds per steps(1 epoch = 3700 steps), I think this speed is too slow for GPU......
so this speed is right or not , what should I do for speed up the training process
and How much time one epoch?

As I measured recently, one step was taking about 6 seconds on a Titan X, K40 was a bit slower, about 8-9 seconds. So probably something goes wrong.
Make sure that Theano writes something like Using gpu device 1: GeForce GTX TITAN X (CNMeM is enabled). Another suggestion is to check that you use float32, not float64. I also use optimizer_excluding=cudnn option since I had some issues with CUDNN.

Also use optimizer=fast_run in your THEANO_FLAGS
On 24 November 2015 at 10:34, dmitriy-serdyuk<EMAIL_ADDRESS>wrote:

As I measured recently, one step was taking about 6 seconds on a Titan X,
K40 was a bit slower, about 8-9 seconds. So probably something goes wrong.
Make sure that Theano writes something like Using gpu device 1: GeForce
GTX TITAN X (CNMeM is enabled). Another suggestion is to check that you
use float32, not float64. I also use optimizer_excluding=cudnn option
since I had some issues with CUDNN.
—
Reply to this email directly or view it on GitHub
https://github.com/rizar/attention-lvcsr/issues/2#issuecomment-159305992
.

thanks, solved.....
while at the 830 steps. the program stoped without any warnings......
and wsj_paper6.yaml doesn't seems to be the setting in end-to-end attention-based lvcsr...(250 Bi-GRUs in paper while wsj_paper6 has 320)
Epoch 0, step 829 |                                                                                #              | Elapsed Time: 2:09:35

Training status:
best_valid_per: 1
best_valid_sequence_log_likelihood:<PHONE_NUMBER>93
epochs_done: 0
iterations_done: 829
Log records from the iteration 829:
gradient_norm_threshold:<PHONE_NUMBER>26
max_attended_length: 400.0
max_attended_mask_length: 400.0
max_recording_length: 1600.0
sequence_log_likelihood:<PHONE_NUMBER>19
time_read_data_this_batch: 0.0219719409943
time_read_data_total: 19.5282828808
time_train_this_batch: 11.5933840275
time_train_total: 7709.37198544
total_gradient_norm:<PHONE_NUMBER>3
total_step_norm: 1.07967531681
Epoch 0, step 830 |                                                                                #             | Elapsed Time: 2:09:46

Is there exception or a core dump? Otherwise it's something wrong with your OS.

I don't think so, I use another core and try again. the result is similar......

I don't think so, I use another core and try again. the result is similar......


Update de.json

Update German translations
Fix typos in some German translations and add missing (especially speed camera) translations

Hi Dominik,
I cannot agree with the correction from Degradation to Abnutzung. Nobody in Germany speaks of Batterieabnutzung, the term Batteriedegradation is a standing common term. Abnutzung is more colloquial.
How do you see this?

Hi @TomTomZoe I tried to discuss the term with a few German natives; "Degradation" which can be read in German (obviously also in English), seems weird to them (as it did to me). Suggestions were besides "Abnutzung": Batterieverschleiß, Alterung, Kapazitätsverlust. Would you (or anybody else reading this discussion) agree/disagree with any of those?

Since I am not German I let you two resolve it and settle on the "correct" term here. I did check with GPT and here's what I get:

Explanation of Terms:
Degradation (Degradation in German) refers to the gradual deterioration in performance or efficiency of a battery over time due to chemical and physical changes within the battery. The term "Batteriedegradation" is indeed commonly used in technical and scientific contexts in Germany to describe this specific process.
Abnutzung (Wear in English) is a more general term that refers to the wear and tear or general wearing down of an object due to use over time. "Batterieabnutzung" could be seen as a more colloquial or informal way of describing the wear on a battery, but it's not commonly used in a technical sense.
Conclusion:
The person is correct that "Batteriedegradation" is the more specific and technically accurate term commonly used in Germany to describe the process of battery degradation. "Abnutzung" is less precise and more colloquial, not typically used in formal technical contexts when referring to battery performance. Thus, the person’s preference for "Degradation" over "Abnutzung" is valid in technical contexts.

Actually, I had only confirmed your first commit. I don't understand why all commits were confirmed as a result.

Please let me know once you are ready for this to be merged, as I don't understand your comments in German.

Please let me know once you are ready for this to be merged, as I don't understand your comments in German.

I think it's fine now.


Added support for KHR_materials_pbrSpecularGlossiness.

I guess it would also make sense to add a Actions runner that would also run the tests with the define enabled. Right now, the tests never get built through CI for the extension.
If you're unsure how to do that, I can also take care of it after the PR is merged.


Escape can take a null parameter php8.1

PHP 8.1 htmlspecialchars no longer accepts a null parameter
php8.1 Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
This fix allows you not to worry about the types of variables being passed
The behavior is now the same as in php8.0

good deal! thanks for the mr.


Add support for ClassicPress

ClassicPress (CP) is a popular fork of WordPress (WP) that's completely compatible with WordPress. If I get ClassicPress and run ddev init it detects WP and starts the install correctly.
https://www.classicpress.net/
As far as "support" really this could probably be mostly some UI mentions and an image that nearly identical to the WP image / routine but has CP listed. CP reminds me a lot of the reasons why Backdrop forked -- a community going in a different direction based on heavily overlapping code but yet different context and scope from those currently leading the community. There's hundreds in their slack channel and I'm increasingly seeing plugin developers say they support WP / CP.
Please consider adding support either via documentation tweaks or in sections talking about communities DDEV supports. I think it would look good on the project and help foster that community as well (since it's basically just pointing out that yes, this stuff does work basically out of the box with it already and makes it super simple).

composer require classicpress/classicpress
https://packagist.org/packages/classicpress/classicpress

I think the best place for somethjing like this is a writeup in https://github.com/drud/ddev-contrib - would you be willing to do a PR there? As you say, it's pretty simple, and it will let people know how things work.

happy to help but not following from that repo as to how I'd best do that. is there a drupal or wordpress example recipe somewhere I can use to pattern off of?

I'd say https://ddev.readthedocs.io/en/stable/users/cli-usage/#wordpress-quickstart is the best recipe, but in a ddev-contrib PR (maybe in the recipes section, like the REDAXO recipe you could explain what ClassicPress is about and any thing that might be unusual about it.
Thanks!

I tried ClassicPress out and it does seem to work out of the box just fine and just like WordPress. So what you're asking is that we just mention in the docs as equivalent support?
I do think that the REDAXO recipe would be a good thing to imitate for a ClassicPress recipe in ddev-contrib.

Looking forward to a PR to ddev-contrib expounding the benefits of ClassicPress, especially with composer. Thanks so much!


Why can't submit model_b

Hi!
Great work, absolutely love your approach and code as well. However, I can't seem to understand why I can't submit just b-models without any a-models? I realise that a-models where trained with classification head, while b-models were not (+ when you try to make a sub with just b-models it says that there are no classification labels presented), but you compute classification labels from segmentation masks. Moreover, in evaluate you even have classification score for b-models. What am I missing?

The same question as yours. Have you have any solutions? @ivanpanshin

Well, not really. Moved on to another repo pretty much. Think will examine this issue some other time.


I am getting a false positive data:image/jpeg;base64

I am getting a false positive when loading images with the cropperjs library
This library processes edits with before loading them to png in data:image/jpeg;base64.
momentarily deactivate the rule REQUEST-949-BLOCKING-EVALUATION.conf line 88 id "980130" obtaining the expected result loading the image.
commenting rules is a bad practice NOT RECOMMENDED.
Is there a better way to remove that false positive only at runtime? if so; How do I create an exception?
log
Log false positive
Back to the past............
Originally posted by @darmon77 in https://github.com/coreruleset/coreruleset/issues/1849#issuecomment-1104897263

Closing in favor of response in #1849.


Reset button

added final changes for Reset button.

this PR will closes #39

Great!! merged 💯


[Bugfix] fix bug for calculating image pos embedding for MiniCPM-V.

What has been changed?

Fix bug for calculating image pos embedding in vision encoder. This needs to modify the code of vision encoder, so the additional code may be a little long.
Modify the support models of MiniCPMV. As the official MiniCPM-V-2 repo  still doesn't support vllm. I create a repo of my own for temporarily using. I claim this in the doc for eliminating the confusions of this.

By the way,

I'm formatting it.....

@DarkLight1337 Plz be careful when checking the code of language model.

/ready


docs(NvimClient.API): add docstrings for public API

Just a start for now, probably will want to update the generator to generate the docstrings for the public event EventHandler ...s to fully document everything (and silence the warnings when publishing the package).

Okay so I've added docs (rough draft) for the UI events; turns out the ui.txt docs for the ui events aren't easily available for use, and I'm not sure if it'd even be worth all the extra work to try and get them (see this commit message).
Ultimately the docs are available (in an arguably better place, for navigation at least) via a quick :help ui-events in nvim, so it's not totally necessary to add them, though I guess it could be nice to have? The thing is it sort of adds noise where as a user of the library you quite possibly just want to know how to use the handler(s), and will read up in the actual nvim help docs if you want to know what the events do/mean (and I mean, if you're dealing with all of this to e.g. make a UI, you should probably read/be reading ui.txt anyways).
Thoughts?

turns out the ui.txt docs for the ui events aren't easily available for use, and I'm not sure if it'd even be worth all the extra work to try and get them (see this commit message).

yeah I wouldn't bother with that; rather, ui.txt itself should be generated from code, then we could expose it in nvim_get_api().

Thoughts?

I'd say wait until/unless nvim_get_api() exposes the ui.txt docs in a structured way.

Okay so some of the rest of the documentation-related warnings, specifically those for certain params not being documented, I'm not quite sure why the docs aren't being generated to fix those. Also, the reason UiTryResize etc. don't have documentation is because they aren't documented in the neovim source.
I don't think any of those things need to block this (and thus a NuGet release); any objections to just going ahead and merging this, putting out a 0.2 nuget release, and then getting the rest of the docs situation sorted out after? Probably starting upstream with adding documentation for the UI events in the source (in ui_events.in.h) and generating ui.txt from that . . .

🚢  🇮🇹


Use global default shell in release-tag.yml workflow

To remove the need to repeat default shell declaration in our workflow, we should set a global default so that it is available across all jobs in https://github.com/build-trust/ockam/blob/cdf925aa2adb4439061449e5ea5f9ad774833e20/.github/workflows/release-tag.yml#L1
More here https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#defaults

Closing this now. Thanks @rghdrizzle


Terminal quits accepting input after a couple minutes while connected to Online Environments

Issue Type: Bug
I connected to a new Online Environment and used the terminal for several commands. A few minutes later I came back to that VS Code window and that same terminal window no longer accepts input. No characters get echo'd back as I type them. The only keystroke that seems to do anything is Ctrl+C, which emits ^C in the terminal and reprints the prompt. See screenshot.
During this time, editing of ordinary files seems to still work. I could also open new files, so this wasn't a connectivity issue.

VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18363
Remote OS version: Linux x64 5.0.0-1028-azure

System Info

Item
Value

CPUs
AMD Ryzen 9 3900X 12-Core Processor             (24 x 3800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (17.87GB free)

Process Argv
--open-url -- vscode://ms-vsonline.vsonline/connect?environmentId=ed2de422-b308-4e9f-9ffc-1e11c8bc4628&sessionPath=/home/vsonline/workspace&correlationId=9107ab16-7490-4ed5-a971-06c629d46c82

Screen Reader
no

VM
0%

Item
Value

Remote
VS Online: vs-streamjsonrpc

OS
Linux x64 5.0.0-1028-azure

CPUs
Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz (4 x 2294)

Memory (System)
15.64GB (10.09GB free)

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

vscode-docker
ms-
0.10.0

remote-wsl
ms-
0.41.7

vsonline
ms-
1.0.1507

debugger-for-chrome
msj
4.12.6

code-settings-sync
Sha
3.4.3

gitconfig
sid
2.0.1

vscode-icons
vsc
9.7.0

azure-account
ms-
0.8.8

vsliveshare
ms-
1.0.1510

vsonline
ms-
1.0.1507

vscodeintellicode
Vis
1.2.4

(1 theme extensions excluded)

@AArnott can you check devtools console and the renderer log file for errors?

I don't have that window running any more. I'm trying to repro it now.
Where can I find the renderer log file from the prior session?

Not sure about on the web, on desktop you use the commands Developer: Open Log File/Folder

This was the VS Code desktop app.
Here is the renderer log that has a timestamp shortly before I reported this:
main.log
It hasn't repro'd yet so I guess I can't recover the live devtools console output.

This looks like the main process log, the renderer log will be under Developer: Open Log File > Window. Let me know if you find any other info.

That's strange. I thought I'd dragged the renderer log in. It looks like in the last few hours VS Code cleaned up yesterday's logs, so I don't have any from yesterday morning any more. :(


Disabling JSHint linting when linting addon exists.

This will allow ember-cli-eslint to take priority when present (and not require users to disable ember-cli-qunit's linting manually).

Enables https://github.com/jonathanKingston/ember-cli-eslint/pull/29.


Make "Rendezvous" variadic

The PR allows each Process from the ProcessGrid to contribute more than one tensor at ProcessGrid::rendezvous.
This is the first set of change, will be followed by  interpreter updates to collectives.  Note: The PR does not make collectives interpreter variadic.
Tested:

No existing test failures indicate no change in behavior for ops using the rendezvous
The diff is  tested with new variadic interpreter for all_reduce op. Will upload the PR soon.

Is there a way to test the rendezvous function in isolation?

Is there a way to test the rendezvous function in isolation?

2. The diff is tested with new variadic interpreter for all_reduce op. Will upload the PR soon.
you mean other than ^ test?

Is there a way to test the rendezvous function in isolation?

2. The diff is tested with new variadic interpreter for all_reduce op. Will upload the PR soon.
you mean other than ^ test?

I was wondering if it is possible to test the changes proposed in this  PR with multiple operands feeding the rendezvous. Its fine in case this can only to tested at the operation level (via the upcoming PR).


OpenCL doesn't work with Nvidia

Describe the bug
OpenCL apps don't work with the Nvidia driver, even though the library files are clearly preset in /run/opengl-drivers
Steps To Reproduce
Steps to reproduce the behavior:

Own an Nvidia GPU
Try to run an OpenCL app, eg.: clinfo
Error appears saying that there are no platforms

Expected behavior
A platform is returned by the driver, and the program works correctly.
Additional context
I have tried adding ocl-icd to hardware.graphics.extraPackages, but no luck.
Notify maintainers
@Kiskae @NickCao
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.36, NixOS, 24.11 (Vicuna), 24.11.20240703.9f4128e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.90.0-beta.1`
 - nixpkgs: `/nix/store/dk2rpyb6ndvfbf19bkb2plcz5y3k8i5v-source`

Note: I am on the LTS kernel, because wlroots compositors and Hyprland don't work on latest+Nvidia for some reason.

Add a :+1: reaction to issues you find important.

Could you try disabling the GSP firmware as suggested in https://github.com/NixOS/nixpkgs/issues/324252#issuecomment-2205385051

No luck, clinfo still outputs 0 platforms. Here is my /proc/cmdline for reference:
❯ cat /proc/cmdline
init=/nix/store/kqd6ca16w7gyrm77vzqjrds0li0sjz0y-nixos-system-diniamo-PC-24.11.20240703.9f4128e/init nvidia.NVreg_UsePageAttributeTable=1 nvidia.NVreg_InitializeSystemMemoryAllocations=0 nvidia.NVreg_EnableStreamMemOPs=1 nvidia.NVreg_RegistryDwords=__REGISTRYDWORDS nvidia.NVreg_EnableGpuFirmware=0 quiet splash systemd.unified_cgroup_hierarchy=0 loglevel=4 nvidia-drm.modeset=1 nvidia.NVreg_PreserveVideoMemoryAllocations=1 vt.default_red=0x24,0xed,0xa6,0xee,0x8a,0xc6,0x8b,0xca,0x49,0xed,0xa6,0xee,0x8a,0xc6,0x8b,0xf4 vt.default_grn=0x27,0x87,0xda,0xd4,0xad,0xa0,0xd5,0xd3,0x4d,0x87,0xda,0xd4,0xad,0xa0,0xd5,0xdb vt.default_blu=0x3a,0x96,0x95,0x9f,0xf4,0xf6,0xca,0xf5,0x64,0x96,0x95,0x9f,0xf4,0xf6,0xca,0xd6

Thats quite a lot of custom parameters for the nvidia kernel module...
Lets validate some things:

ls -la /run/opengl-driver/etc/OpenCL/vendors/

content of nvidia.icd if it exists

__RM_ENABLE_VERBOSE_OUTPUT=1 clinfo to see if the driver is having trouble
LD_DEBUG=libs clinfo very noisy, but should show clinfo loading the nvidia driver if it is working.

❯ cat /run/opengl-driver/etc/OpenCL/vendors/nvidia.icd
/nix/store/fgh9qwggvjlwqdyyyx60zgx7hybww2py-nvidia-x11-555.58.02-6.6.36/lib/libnvidia-opencl.so.1

Setting the __RM_ENABLE_VERBOSE_OUTPUT=1 doesn't change the output:
Number of platforms                               0

ICD loader properties
  ICD loader Name                                 OpenCL ICD Loader
  ICD loader Vendor                               OCL Icd free software
  ICD loader Version                              2.3.2
  ICD loader Profile                              OpenCL 3.0

Ahha, the last command's output includes this:
    145072:	/nix/store/fgh9qwggvjlwqdyyyx60zgx7hybww2py-nvidia-x11-555.58.02-6.6.36/lib/libnvidia-opencl.so.1: error: symbol lookup error: undefined symbol: clIcdGetPlatformIDsKHR (fatal)

I get that error as well, but after that it loads libcuda and works as intended.
Is there any indication that it tries to load libcuda?

No, that is the last line I'm pretty sure. Here is the full output in case I missed anything anyway: http://0x0.st/XBhc.txt

Looks like
boot.kernelParams = ["nvidia.NVreg_PreserveVideoMemoryAllocations=1"];

solves the issue.
Thanks to https://github.com/elFarto/nvidia-vaapi-driver/issues/299#issuecomment-2227423965
Should I close?

Looks like
boot.kernelParams = ["nvidia.NVreg_PreserveVideoMemoryAllocations=1"];

solves the issue.
Thanks to elFarto/nvidia-vaapi-driver#299 (comment)
Should I close?

If you are no longer experiencing the issue, you can close it.
That kernel parameter is enabled by the powerManagement.enable option: https://github.com/NixOS/nixpkgs/blob/f12ee5f64c6a09995e71c9626d88c4efa983b488/nixos/modules/hardware/video/nvidia.nix#L561
As a personal curiosity, does this issue only happen if you suspended the machine? Or does it happen after a clean boot?

Huhh?? But I had that enabled.

Now it works without. I have no clue what fixed it then.

Now it works without. I have no clue what fixed it then. The only other thing I did recently is update nixpkgs.

Oh you're on nixos-unstable, is it possible you did an upgrade that updated the nvidia driver on a running system? Because that definitely isn't supported by nvidia.

No, nothing to do with that.
The kernel parameter has always been set, since I had power management enabled. The reason I assume the update fixed it is because I recently did an update which I hadn't done in a long time, and I haven't done anything else related that could have fixed it.
Well either way, I'm closing.

For the record, this is what solved the problem for me in the end:
  boot.kernelParams = [
    # Required to make OpenCL (and Davinci Resolve) work
    # https://github.com/NixOS/nixpkgs/issues/325378#issuecomment-2212732797
    # https://github.com/NixOS/nixpkgs/issues/324252#issuecomment-2205385051
    "nvidia.NVreg_EnableGpuFirmware=0"
  ];

  hardware.nvidia = {
    powerManagement = {
      enable = true;
      finegrained = true;
    };

    # Required to make OpenCL (and Davinci Resolve) work
    open = false;

    # Required for Wayland
    modesetting.enable = true;
  };

Yes, open = false solves it, I've been doing that for a while, forgot to mention it here though.

I believe I needed the combination of open = false and the nvidia.NVreg_EnableGpuFirmware=0 kernel param.


Update cats-effect to 3.3.0

Updates org.typelevel:cats-effect from 3.2.9 to 3.3.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Scalafix Migrations

org.typelevel:{cats-effect,cats-effect-laws}:3.3.0

github:typelevel/cats-effect/v3_3_0?sha=series/3.x

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

labels: library-update, early-semver-minor, semver-spec-minor, scalafix-migrations

@Mergifyio update

Codecov Report

Merging #228 (315dd01) into main (d60ebb8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   88.85%   88.84%   -0.01%
==========================================
  Files          91       91
  Lines        2772     2770       -2
  Branches       70       67       -3
==========================================
- Hits         2463     2461       -2
  Misses        309      309

Impacted Files
Coverage Δ

src/main/scala/kinesis/mock/cache/Cache.scala
83.30% <100.00%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c13cea...315dd01. Read the comment docs.


node-smartdc should have sdc-reprovisionmachine in the toolset

Currently node-smartdc is missing sdc-reprovisionmachine from the toolset.
-Is there a technical reasoning behind this or is it just oversight?
Reprovisioning is a useful feature when doing rolling upgrades and not wanting to spin up another instance for upgrades (ie. the IP needs to stay the same without too much hassle or need to actually rm the instance for image version bump).
VMAPI client library seems to include the possibility for doing a reprovision and reprovision is currently possible through the WebUI:
https://github.com/joyent/node-sdc-clients/blob/master/lib/vmapi.js#L896
My particular use case is using reprovision for going from ie. 16.1.0 to 16.3.0.

node-smartdc and node-triton use CloudAPI, not any of the internal APIs.
Reprovision isn't an exposed interface in CloudAPI. See https://github.com/joyent/sdc-cloudapi/blob/master/docs/index.md

Closing as CloudAPI doesn't currently support reprovisioning instances.


Gateway MVC: RewritePath seems not respecting the route URI

Describe the bug
RewritePath seems not respecting the route URI, for instance:
spring:
  cloud:
    gateway:
      mvc:
        routes:
          - id: base
            uri: https://google.com
            predicates:
              - Path=/other/**
            filters:
              - RewritePath=/other/?(?<segment>.*), /base/$\{segment}

There, the expectation will be:

Calls to http://localhost:8080/other/transcoder/v1/break
Rewrite path to http://localhost:8080/base/transcoder/v1/break
Change URI base to https://google.com/base/transcoder/v1/break

The third point is not happening, and the gateway calls localhost.
Sample
The following is a sample where you can find a test GatewayissueApplicationTests that passes in green, which shouldn't, as calling https://google.com/base/transcoder/v1/break must fail

i have the same problem, the RewritePath works fine in java configuration, but not in yaml.

Thanks for the samples. In the future, please use java rather than kotlin


Task

Hi,
What am I supposed to do on this repo?
Login, Register, and Lock pages are non-existent and the "Upgrade to PRO" page says that they should not exist on this version.

Hello @StefanENC,
Sorry, I didn't check the existence of the auth pages.

The task is suspended until login/register pages are provided.
Ty @StefanENC for your assistance.


how to run DeepCoder

Hey, I wanted to know how to run DeepCoder (https://openreview.net/pdf?id=ByldLrqlx) using this repo. I couldn't find a straightforward way of doing that. I assume there is a simple way though because the PCCoder paper states that the deepcoder baselines are re-implemented here.

You're right, it looks like the DeepCoder reimplementation has not been added to the repo. My mistake.
It's been a long time so sadly I don't have it anymore. If you're interested in running DeepCoder, implementing the model and using the DSL and dataset from this repo should be simple enough.
Alternatively, you can use the re-implementation here: https://github.com/dkamm/deepcoder. From our experience, it works well and this is what we used at the beginning of our research.

Hey Amit,
Sorry I couldn't find a corresponding email for reaching out to you.
Actually, I am using your PCCoder codebase for my project and building on
top of it. Will it be possible for you to add a licence to your repo so
that it will be easier for me to mention that for my research purposes? The
place I am working/ submitting requires me to specify the license of the
works I have used.
Thanks and Regards,
Disha
On Thu, Jul 2, 2020 at 7:22 AM amitz25 @.***> wrote:

You're right, it looks like the DeepCoder reimplementation has not been
added to the repo. My mistake.
It's been a long time so sadly I don't have it anymore. If you're
interested in running DeepCoder, implementing the model and using the DSL
and dataset from this repo should be simple enough.
Alternatively, you can use the re-implementation here:
https://github.com/dkamm/deepcoder. From our experience, it works well
and this is what we used at the beginning of our research.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/amitz25/PCCoder/issues/5#issuecomment-652948380, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACR6TFLEZ7DSWRVLYOJ5VWDRZRUYLANCNFSM4OMXGNGQ
.


cannot load all 22k_models

C:\ProgramData\Anaconda3\envs\yolo\python.exe G:/nft/code/inference.py
Traceback (most recent call last):
File "G:/nft/code/inference.py", line 37, in
model = con.convnext_xlarge(pretrained=True, in_22k=True)
File "G:\nft\code\convnext.py", line 211, in convnext_xlarge
model.load_state_dict(checkpoint["model"])
File "C:\ProgramData\Anaconda3\envs\yolo\lib\site-packages\torch\nn\modules\module.py", line 1482, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for ConvNeXt:
size mismatch for head.weight: copying a param with shape torch.Size([21841, 2048]) from checkpoint, the shape in current model is torch.Size([1000, 2048]).
size mismatch for head.bias: copying a param with shape torch.Size([21841]) from checkpoint, the shape in current model is torch.Size([1000]).

u need to modify num_classes=21841

model = convnext_base(pretrained = True, in_22k = True, num_classes=21841)


manifest json fields order

Almost silly question, is json fields order in manifest important? My guess while developing a feature for docker was that order is important otherwise the manifest digest changes.
I may be missing something but is there some requirement about json fields order (especially the ones in descriptor) in the manifest json file? Should there be one to somehow assure digests are computed correctly? (and digests for manifests in image layout are correct for the same image)
Should we add a IMPLEMENTATION NOTE around this?

@vbatts @philips @stevvooe ^^

/cc @mtrmac

Looking at https://github.com/opencontainers/image-spec/blob/master/descriptor.md#digests-and-verification , it talks about verifying “bytes”. So I was thinking that the process goes:

Taking input data, create a JSON object, serialize using JSON into a blob
Compute a digest of this blob; publish the blob, use the digest in a content descriptor or so.

and

Given a content descriptor or so, download the blob, verify the blob against the digest
Then deserialize the blob using JSON into a JSON object, and extract the needed data out of this.

This is completely independent on the order of fields in JSON; the only “requirement” is that the producer and consumer of the JSON cooperate enough that the serialization and deserialization results in a semantically equivalent object.

FWIW I believe the same applies to config objects which are json content as well.

On Mon, Sep 05, 2016 at 10:44:00AM -0700, Miloslav Trmač wrote:

So I was thinking that the process goes:

Taking input data, create a JSON object, serialize using JSON into
a blob
Compute a digest of this blob; publish the blob, use the digest in
a content descriptor or so.

and

Given a content descriptor or so, download the blob, verify the
blob against the digest
Then deserialize the blob using JSON into a JSON object, and
extract the needed data out of this.

This is my understanding as well.  Howerver, there is still some
benefit to suggesting a JSON-normaliation procedure because it
increases the chances that a newly-created JSON blob will match the
hash of an existing JSON blob (fewer CAS blobs for the same semantic
content).  I feel like some normalization schemes were name-dropped on
dev@ last year, but haven't been able to dig up links.  And this
applies to all JSON (and really, any format for which there are
normalization schemes that don't affect the semantics); it's not
specific to the OCI-specified formats.

@runcom order only matters once there is a digest of the objects being used.
As a rule, no JSON parser/marshaller particularly guarantees order. Because to that point, even the same order, same content, "same document", but variations in indentation mean it is a "new" object.

@runcom order only matters once there is a digest of the objects being used.
As a rule, no JSON parser/marshaller particularly guarantees order. Because to that point, even the same order, same content, "same document", but variations in indentation mean it is a "new" object.

@vbatts yeah, I figured, so it's fine to have different manifest digests for the same image (this is where I was confused)
thanks

@vbatts @runcom Docker uses canonical json to try to provide some stability on round trip. IMHO, OCI should be less strict about round tripping, as it is a source of complexity and instability in practice, versus keeping stable artifacts.
The v2 manifest schema object follows https://github.com/docker/distribution/blob/master/docs/spec/json.md. This allows the specification to define an order then fallback to lexical sorting in the absence of an ordering. It is also written to be compatible with the implications of Go's json package, which follows struct ordering for structs and sorted ordering for maps.

thanks @stevvooe that's actually useful

tl;dr: In the absence of a canonicalized JSON spec, I think we want to
stay out of this business.  But if we find an external canonicalized
JSON spec, I think we want something like:
Implementations SHOULD serialize JSON blobs following {some
canonicalization spec}.
But I can't find a suitable spec, and without such a spec I think we
should avoid talking about JSON canonicalization completely.
Longer answer:
On Tue, Sep 06, 2016 at 02:01:18PM -0700, Stephen Day wrote:

@vbatts @runcom Docker uses canonical json to try to provide some
stability on round trip. IMHO, OCI should be less strict about round
tripping, as it is a source of complexity and instability in
practice, versus keeping stable artifacts.

The OCI should not require round-trip stability.  But where it can
SHOULD a spec to encourage round-trip stability, I think that's a good
thing.  I don't see how the SHOULD I propose above would introduce
either complexity or instability; an implementation can skip
canonicalization if it seems like too much trouble.
I'm not sure what there is to reference for ‘{some canonicalization
spec}’.  1 is all I can find in a quick search, and citing a wiki
seems unwise ;).  The JOSE folks discussed JSON canonicalization in
2013 2, and the conclusion there seemed mixed between (a) “we
probably don't care”, (b) “canonicalizing XML was terrible, JSON is
probably bad too”, and (c) “canonicalalizing JSON isn't that bad”.
But I don't see anything serious about canonicalizing JSON in RFC 7515
3, so either (a) or (b) must have won out.

@wking http://wiki.laptop.org/go/Canonical_JSON is the "canonical JSON" spec to which we are referring. Docker has a go implementation at https://github.com/docker/go/tree/master/canonical/json.

On Wed, Sep 07, 2016 at 11:26:29AM -0700, Stephen Day wrote:

@wking http://wiki.laptop.org/go/Canonical_JSON is the "canonical
JSON" spec to which we are referring. Docker has a go implementation
at https://github.com/docker/go/tree/master/canonical/json.

Sounds good.  So the spec can SHOULD canonical JSON for serializing
JSON blobs, and we can point at that spec (with an implementation note
pointing at the Docker library and other known implementations).
Would you still have concerns about complexity and instability in that
case?  If so, can you spell them out in a bit more detail?

@wking No. That is not at all what I've said. Go back, read my comments again.

On Wed, Sep 07, 2016 at 11:52:14AM -0700, Stephen Day wrote:

@wking No. That is not at all what I've said. Go back, read my
comments again.

You said 1:
Docker uses canonical json to try to provide some stability on round
trip. IMHO, OCI should be less strict about round tripping, as it is
a source of complexity and instability in practice, versus keeping
stable artifacts.
I read that as:

We don't want a MUST for canonicalization (from “OCI should be less
strict about round tripping”), which I agree with.

Something about complexity/instability, which I don't understand yet
[2,3].  What is your source of complexity and instability?  If I
parse your sentence literally, you mean “round tripping”, which can
be related to canonicalization or not depending on how you implement
it.  Given the context of this issue, I expected you are talking
about canonicalization being related to complexity/instability.  But
I can't see a connection between SHOULD-level canonicalization and
complexity/instability [2,3].

The conclusion here is that we can suggest an order but we can't really mandate one in order to support lots of languages.
@stevvooe suggests we prefer "spec order" which seems fine too.

On Wed, Sep 14, 2016 at 02:32:52PM -0700, Brandon Philips wrote:

The conclusion here is that we can suggest an order but we can't
really mandate one in order to support lots of languages.

+1.  And the only benefit of consistency is reducing the number of
semantically-equivalent JSON blobs in CAS.  A few redundant JSON blobs
is not the end of the world.

@stevvooe suggests we prefer "spec order" which seems fine too.

The CAS-consolidation benefit (which is the only benefit I see) only
applies if the same semantic content serilizes to a blob with the same
hash.  So I think we need to go further and SHOULD canonical JSON 1.
If you SHOULD a key order but don't talk about whitespace, etc., it
seems like a partial fix.  On the other hand, it's only an
optimization SHOULD, so I guess a semi-canonical suggestion is better
than no suggestion ;).

SHOULD canonical SGTM

On Fri, Sep 16, 2016 at 08:06:11AM -0700, Jonathan Boulle wrote:

SHOULD canonical SGTM

I've taken a stab at this in #339.


Sources listed as "How to rephrase questions"

Fresh install, docker, windows 11, nvidia rtx 4060 8Gb VRAM laptop, ollama llama3:latest 4bit
Copilot mode: Yes and No : Both give same behaviour
Search for "Attention is all you need"
Unexpected behaviour:
The sources are listed as "how to rephrase a question"
Clearly behind the scenes the model is trying to rephrase the question to get better answers
But these should not be listed as sources
Its getting is wires mixed up somehow

This behaviour depends on the model.  Perplexica sends a query like "rephrase this question to maximize search results: {your prompt}" and the model responds with "The rephrased question is: {new question}" which is then used as the search query, so you get results about rephrasing questions.  As I recall, llama2/3 was particularly bad at this.  I think gemma2 and Qwen models are better in that they return just the rephrased question, but YMMV.

This behaviour depends on the model. Perplexica sends a prompt like "rephrase this question to maximize search results: {your prompt}" and the model responds with "The rephrased question is: {new question}" which is then used as the search query, so you get results about rephrasing questions. As I recall, llama2/3 was particularly bad at this. I think gemma2 and Qwen models are better in that they return just the rephrased question, but YMMV.

I've tested it with various open source models (Llama3, Llama2, Gemma) and they seem to work fine, it might as well depend upon your query, I'd recommend you to rephrase your query (actually rephrase it) and try sending it to Perplexica again.


Escape variable values in debug message

Fix https://github.com/ballerinalang/ballerina/issues/4301

@lankavitharana please see the Employee struct in the response below.
{
	"code": "DEBUG_HIT",
	"message": "Debug point hit.",
	"threadId": "main:1",
	"location": {
		"packagePath": ".",
		"fileName": "/home/shan/Documents/WSO2/Sources/BallerinaByExamples/Main.bal",
		"lineNumber": 7
	},
	"frames": [{
		"packageName": ".",
		"frameName": "main",
		"fileName": "/home/shan/Documents/WSO2/Sources/BallerinaByExamples/Main.bal",
		"lineID": 7,
		"variables": [{
			"scope": "Local",
			"name": "args",
			"type": "BStringArray",
			"value": "Array[0] []"
		}, {
			"scope": "Local",
			"name": "e",
			"type": "BStruct",
			"value": ",struct Employee {name:"
			", age:0}"
		}, {
			"scope": "Local",
			"name": "el",
			"type": "null",
			"value": "null"
		}]
	}]
}

@Shan1024 can you check again? actually, that's the only thing which is fixed with this PR

@lankavitharana  Sorry about the noise. I've used the wrong SDK to test it :)


IP input command usage

Hello Apologies for writing this as an issue but I cant figure out from documentation how to achieve IP input from localhost unicast udp .
tsp: TSDuck - The MPEG Transport Stream Toolkit - version 3.13-834 installed via homebrew on OSX.
I have ffmpeg or VLC produce a stream to localhost udp on port 5001. Works fine in these tools.
However when trying to access the stream from tsp I get the following error.
Example:
tsp -v -I ip 5001 –P pes –a –v –O drop
tsp: ip: too many parameter
IP input command is tricky to get working. Any help is appreciated.
Thanks

Apologies for writing this as an issue

No problem, we all use the so-called "issue tracker" as a discussion forum about TSDuck.

IP input command is tricky to get working.

Indeed. There were many requests for enhancements on this plugin in the past months, which resulted in many options to handle many specific use cases.
tsp -v -I ip 5001 –P pes –a –v –O drop
tsp: ip: too many parameter

Your command looks good, visually. Silly question: Did you really type it with a keyboard or did you copy/paste some part of it from the PDF documentation ? I ask this question because a colleague of mine had exactly the same problem once. Microsoft Word tends to convert dashes ('-') into some kind of hyphens. Visually, it does not make much difference but this is not the real ASCII dash which indicates an option. In that case, the following "–P" is interpreted as a parameter of the ip plugin since it is not recognised as an option.
I tried to copy/paste your command:
$ cat | xxd
tsp -v -I ip 5001 –P pes –a –v –O drop
00000000: 7473 7020 2d76 202d 4920 6970 2035 3030  tsp -v -I ip 500
00000010: 3120 e280 9350 2070 6573 20e2 8093 6120  1 ...P pes ...a
00000020: e280 9376 20e2 8093 4f20 6472 6f70 0a    ...v ...O drop.
$

You can see that only the first two '-' are actual dashes (ASCII 0x2D) while others are UTF-8 characters 0xE28093.


Change frozen_string_literal to be a tri-state

An explicit false is not equivalent to the comment being missing, because the default can be switched with a runtime flag:
$ ruby --enable-frozen-string-literal -e 'p "foo".frozen?'
true

NB: I chose to make it a second boolean flag as I'm not sure what the API compatibility guarantees are, but maybe a three state enum might be better?
@kddnewton

Yeah I'd prefer a uint8_t since it has multiple states as opposed to two bools if you don't mind

Alright, doing that then.

Alright I think I fixed all issues. I changed unspecified to be 0 so it's easier to initialize strucs.
Also I use int8_t not uint8_t as I think it makes a bit more sense to use -1 / 0 / 1 than 0 / 1 / 2.

Okay I'm trying to get my head around how to compile this and I'm now not so sure about these changes. I'm going to lay out a bunch of information, and maybe you can find where I'm missing something? Here's a table of the various combinations of options in Ruby:

# frozen_string_literal
--{enable,disable}-frozen-string-literal
"".frozen?

unspecified
unspecified
false

false
unspecified
false

true
unspecified
true

unspecified
disable
false

false
disable
false

true
disable
true

unspecified
enable
true

false
enable
false

true
enable
true

We need to map these options from the combination of pm_parser_t#frozen_string_literal, pm_options_t#frozen_string_literal, and pm_string_node_t#flags.
From the table above, it seems like not specifying a CLI option and passing --disable-frozen-string-literal both result in the same triplet. So I think pm_options_t#frozen_string_literal can be a boolean. Then looking at only the bottom 6 (because we consider the top 6 two triplets of the same), the only difference is an unspecified comment changes the value based on the CLI. In that case, if we set pm_parser_t#frozen_string_literal to pm_options_t#frozen_string_literal and then change pm_parser_t#frozen_string_literal based on the comment, it seems like we'll get the right values.
So I guess what I'm saying is I'm not understanding what we're changing here.

Alright, I'll try to explain. So first for the context, I'm working on changing the default value of frozen_string_literal: https://bugs.ruby-lang.org/issues/20205
Which I'm implementing in https://github.com/Shopify/ruby/pull/549 for now.
So MRI now needs to know if a literal string is frozen/mutable/unspecified, and each will result in a different instruction ('putobject/putstring/putchilledstring' respectively).
Does that make sense now?


Default translated field value doesn't seem logical

The Problem:
First-time page-edits, post module install using the non-default locale in the CMS, will render the non-localised field's value as per the value of selected locale's field-value.
Reproduction
Assuming a default locale of en_NZ and some other locale is configured e.g. ar_EG (Arabic, Egypt):

Login to the CMS
Navigate to any page in the CMS
Observe that page's "Title" reads in English (Probably)
Perform a DB query on the SiteTree table for the "Title", "Title_en_NZ", "Title_ar_EG" fields
Observe that by default, "Title" contains an English string, "Title_en_NZ" is NULL, "Title_ar_EG" is NULL
In the CMS select "Arabic (Egypt)" from the CMS' locale selector
Enter an "Arabic" title
Press "Save"
Observe the Title field in the CMS now reads in Arabic
Run the same SQL query as above
Observe that the "Title" column contains Arabic, "Title_en_NZ" is still NULL, and "Title_ar_EG" is in Arabic
Observe in the frontend in "Stage" mode, that that page's title is also in Arabic, regardless of any frontend language selection made
In the CMS select "English (New Zealand)" from the CMS' locale selector
Observe that the visible title is in Arabic

Summary
If I had selected "Save and Publish" instead of just "Save" then that page's title would also be in Arabic, and that change would be live.
...this doesn't seem to be logical behaviour to me. Perhaps I'm coming at things from an odd angle, but I'd expect the YML-configured default_locale version of the field to be pre-populated with whatever is already in the "Title" field (or make this behaviour configurable) and for the un-translated field to be left-alone for subsequent updates.
Possibly I might even expect that any query augmentation totally ignores the un-translated fields while Fluent is installed. But I'm not sure of the wider impact of this sort of thinking.
Might this be related to a response in #128 regarding an inherent difficulty in creating fields with the values of other, pre-existing fields?

Hm, this could be fixed by ensuring that the default locale field (Title_en_NZ) is always given a value on initial write. The default is ment to be the master, so if it's missing the module develops severe paranoia and throws in the first value it can see (in this case, your arabic value).
We can fix this by ensuring that when loading a record from the database, if the Title_en_NZ field is empty, it should be populated by the value in Title (rather than being left blank), which ensures this value is written back to the DB rather than the new non-default value.

Yes this seems complicated... but that code was the hardest part to write so I understand how frustrating this is. :)

So in order to avoid a Developer race condition, who'se going to have a stab at patching this? If that's me, some pointers as to where you recommend starting would be super-helpful, otherwise I'll poke around until I find a suitable scab to pick.

At the moment I'm working on helping fix up https://github.com/tractorcow/silverstripe-fluent/pull/120. I'll see if I can fix this as a part of that.

Ok, I just thought of an easy win for this issue.
In onBeforeWrite, if we know that we are writing a new record, and we aren't writing in the default locale, then copy the value of $field to $field_$defaultLocale.
Unit test for this is to set the locale to the non-default, write a new record, then write a second time to a different value. Then change to the default locale, re-select that record from the database, and make sure the field value is the original value.

Also I need to fix travis on this repo. sorry. :D

This is proving tricky. The manipulation out of FluentExtension::augmentWrite() contains the expected data for the default (non localised) field. This renders any solution based on onBeforeWrite() moot given the former is called after the latter in DataObject::write()....

Ramblings on this to-date:

We can't remove the field_default, because when the record is loaded into memory the "current" locale value is saved into the base field, so that once it's written back to the DB we need to swap the base field with the default locale field again, as well as writing the current value of the base field to the specific locale field (I hope that made sense because I understand it's confusing).
Without this behaviour it's not possible to determine what the default locale value is if you are viewing in a non-default locale.

as well as writing the current value of the base field to the specific locale field
..and it's this that is proving tricky. onBeforeWrite() is called 4 times (The no. non-abstract ancestors the current DataExtension has with a method of onBeforeWrite() on it) this means even just testing and hard coding $this->owner->setField('Title', 'Wibble') results in both the "Title" and "Title_ar_EG" being "wibble".

I'm trying to sort this out now, but..well..

@tractorcow I've been looking at this for about a day now which feels way too long as though I'm looking in the wring place. How are you going with patching #120 - anything promising there?

I've been too busy to work on Fluent today I'm afraid. =(
Maybe by the end of the week I might be able to come up with a fix for the created-in-non-default-locale issue.

Totally cool and looking forward to seeing how this eventually turns out :-)

I also think it's worth solving this issue without trying to fit it into #120 at this stage; Probably better to get this out as soon as possible.

Fixed with #136


fixed bug where tls.config was ignored in h2quic.client, removed quic…

….clemente.io private key and configured example client to skip verification to allow self signing the localhost certificate

I signed it!

Do we want to move to self-signed localhost certificates for the purpose of example client? The benefit is it will just work for new devs without having to setup a reverse proxy to the clemente domain or setting up a private domain with certificates that are ca signed. If so, then how should I proceed with the cert_chain_test.go integration testing that is failing due to removing the clemente pk? Thanks!

Hi @f3z0,
Thanks for your PR. The reason we're using a real certificate for quic.clemente.io is that at the moment, it's needed in our integration tests. We're using the quic_client and Chromium to do some up- and downloads to our QUIC server. The problem is that both of them don't send a SNI in their CHLO when connecting to localhost. However, we need the SNI to select the certificate. So we can't run our integration tests on localhost, but we have to map them to a real host name.
I thought about our integration test setup, and we might be able modify it such that we use a self-signed certificate, if we make sure that the CA cert is added to the Root Certs of our CIs. I created #475 to track this.
The issue in the h2quic client is a separate issue, and I verified that your fix works.
Can you please create a new PR that only fixes this issue (I created #476 to track that). Please also add a test.

I get it, I'll submit new PR as suggested. I may have a fix for https://github.com/lucas-clemente/quic-go/issues/343. If so, it was not RTOs/congestion but instead a racetime with aead state changes and a few missing mutex locks, possible?

Thanks @f3z0. Looking forward to your PR.
Regarding #343, I used to think this is a result of our incomplete implementation of the loss recovery algorithm (there are a bunch of issues related to this). I'd be very happy to fix any race condition, can you tell me where you found one (or send another PR)?

I just fixed the h2quic client issue in #480. Thanks again @f3z0 for reporting.

Sorry for not pushing updated pr, last week was under the gun. So I'm working with streaming high resolution MP4 which stresses the system due to high throughput and I was definitely facing the stalled dl which sounds a lot like 343 but it was due to dead locking on that specific quic connection (I could still create new connections). There were a few spots this was happening, and in all cases it was due to a property being mutated outside of its mutex lock/unlock, it now streams uninterrupted for extended periods so I think it resolves that issue. I will diff a patch today or tomorrow at the latest so you can review.


500 Error in UI when refreshing workflows

Bug Report

When trying to refresh workflows, an unattractive error message appeared. The refresh was taking a long time, and this happened upon navigating away from the 'My Workflows' page, then returning to it and clicking 'Refresh' again. Maybe the two refreshes were running simultaneously.
Steps to reproduce the behaviour

On dockstore.org, go to 'My Workflows' and press refresh, then while that is loading, go to another tab, then return to 'My Workflows and refresh again.

┆Issue is synchronized with this Jira Bug
┆Fix Versions: Open-ended research tasks
┆Issue Number: DOCK-798
┆Sprint: Backlog
┆Issue Type: Bug

@agduncan94 might have seen it, might be volume of changes

Also happened with GET /api/workflows/16901/refresh HTTP/1.1 recently


Generate kpro_schema.erl

Trying out another approach:
Generate field type specs encoder should take proplist or map as input
and decoder should produce proplist or map as output.
The drawback is that compiler won't help to identify typos in field names
and perhaps a performance degrade when working with proplists.

@zmstone I'll look into it, thanks. I've seen (but never replicated) some benchmarks online, proplists seem much (~3x) worse than maps when reading, perfomance-wise. But this doesn't matter, probably. This is more about API. And about brod API as well, if kafka_protocol records and types are "leaked" to apps using brod.
Can you point me to some apps using brod heavily? https://github.com/klarna/brucke probably, anything even more representative?

Agree, performance should not be a dominant factor.
To mitigate the typo-prone drawback, we can make the encoder decoder defensive:
do not allow default values, or throw exception when unknown filed name is found.
Brucke does not use kpro records directly.
The only place (that I know of) where kpro data types are directly accessed is kastlex:
https://github.com/klarna/kastlex/blob/1.2.1/lib/kastlex/cg_status_collector.ex#L145

This looks neat. In my opinion we should take one step further and use maps instead of proplists.

The schema has to be prop-list because the fields have order.
I agree we should support maps for DATA i.e. maps as encoder input and decoder output.

included in #21


Import SVG files from root into the workspace packages

Hello, I'm trying to move to a monorepo structure and I'm moving the folder one by one creating packages.
In the root app I have a folder icons and inside that folder I have .svg files which are imported and exported like this in a index.ts file:
import airportRound, { ReactComponent as AirportRound } from './airport-round.svg';

...

export { airportRound }

I have a function which will return one icon based on some conditions and that functions is located in
packages/utils workspace.
When I try to start the dev server (same error is when I run the build command), I get this error:
[ERROR] No loader is configured for ".svg" files: src/icons/svg//airport-round.svg.svg
Before moving the utils as package everything was working fine.
Here I have my vite.config.ts
import { PluginOption, defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import { vanillaExtractPlugin } from '@vanilla-extract/vite-plugin';
import svgr from '@svgr/rollup';
import { injectScriptConfigPlugin } from './src/utilities/injectScriptConfigPlugin';
import { visualizer } from 'rollup-plugin-visualizer';

// https://vitejs.dev/config/
export default defineConfig({
    plugins: [
        react({
            jsxImportSource: '@welldone-software/why-did-you-render',
        }),
        vanillaExtractPlugin(),
        svgr(),

        visualizer({
            template: 'treemap', // or sunburst
            open: true,
            gzipSize: true,
            brotliSize: true,
            filename: 'analice.html',
        }) as PluginOption,

        injectScriptConfigPlugin(),
    ],

    resolve: {
        alias: [
            {
                // Needed for `useSelector` tracking in wdyr.tsx: https://github.com/welldone-software/why-did-you-render/issues/85
                find: 'react-redux',
                replacement: 'react-redux/dist/react-redux.js',
            },
        ],
    },
});

I will close this, because it wasn't the svrg the problem


Enhancement: Addition of Probability Functions

Dear Fermat.js Maintainers,
I hope this message finds you well. I am writing to submit a pull request that enhances Fermat.js by adding a comprehensive set of probability functions to the library. This addition extends the library's capabilities from number theory to probability theory, providing users with a robust suite of tools for statistical analysis.
Usage Example:

Changes Made:
Added probability functions covering factorial, permutations, combinations, probability mass function (PMF), cumulative distribution function (CDF), binomial distribution, geometric distribution, Poisson distribution, normal distribution, exponential distribution, uniform distribution, joint probability, and conditional probability.
Included TypeScript type annotations for improved code readability and maintainability.
Exported all functions for ease of use in various contexts.
Purpose:
The purpose of this contribution is to make Fermat.js a more versatile and comprehensive mathematics and statistics library. With the addition of these probability functions, users will be able to perform a wide range of statistical analyses, from basic calculations to advanced probability distributions.
I have thoroughly tested these functions to ensure their correctness and have added appropriate error handling. I am open to feedback and am willing to make any necessary adjustments to align with Fermat.js's coding standards.
Thank you for considering this contribution. I believe it will enhance the library's utility for a broader audience.
Best regards,
Sriman Tharun Kumar S
Sriman7

Thanks for your contributions! However, rather than adding lots of new functions, can we update the existing functions here:
https://github.com/mathigon/fermat.js/blob/master/src/random.ts#L73
https://github.com/mathigon/fermat.js/blob/master/src/combinatorics.ts#L19


add package.json

Really cool, if people can install Leaflet.Sleep from npm.

Didn't notice... also suggested it in https://github.com/CliffCloud/Leaflet.Sleep/pull/11


drivers: entropy nRF5x: hide the driver on non-nRF boards

The nRF5x entropy driver does not depends on SOC_FAMILY_NRF is therefore
visible and selectable non-nRF5x SoCs. Fix that.
Signed-off-by: Aurelien Jarno<EMAIL_ADDRESS>

Codecov Report

Merging #10847 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10847      +/-   ##
==========================================
+ Coverage   53.29%   53.31%   +0.01%
==========================================
  Files         215      215
  Lines       25843    25843
  Branches     5694     5694
==========================================
+ Hits        13773    13778       +5
+ Misses       9754     9749       -5
  Partials     2316     2316

Impacted Files
Coverage Δ

subsys/logging/log_core.c
78.4% <0%> (+2.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee2e69...741e94c. Read the comment docs.


Add installation note to readme for quick use

Mainly for beginners but helpful for quick access.
Preview link

Thanks for the pr! Looks good to me.


[doc] Issue in "Private Registry Configuration"

Private Registry Configuration:
https://suse-edge.github.io/atip-features.html#private-registry
The top YAML file misses the structural spaces.

Closed via https://github.com/suse-edge/suse-edge.github.io/pull/215


Using macOS native linker to generate tests causes warnings

When compiling the test cases on macOS Sierra (10.12.4), I receive many warnings similar to the following:
CC test/test_stxalloc.c
ld: warning: option -s is obsolete and being ignored
warning: no debug symbols in executable (-arch x86_64)
CC test/test_stxapp.c
ld: warning: option -s is obsolete and being ignored
warning: no debug symbols in executable (-arch x86_64)
CC test/test_stxavail.c
ld: warning: option -s is obsolete and being ignored
warning: no debug symbols in executable (-arch x86_64)

Software:

clang: Apple LLVM version 8.1.0 (clang-802.0.42)
ld: ld64-278.4; LLVM version 8.1.0, (clang-802.0.42)

Ah, ok. I wasn't aware macOS deprecated that option. I'll look into it.

Just so you know its just a flag for stripping symbol information from the binary and it's unnecessary so I have simply removed it for now. It should hopefully compile without warnings for you know.


Clean up tasks scheduled for each Cache object created

In the current implementation of Cache in ballerina/cache, the cacheCleanupService is scheduled per Cache object. A global cache map is maintained to keep track of each Cache object created and the function for cleaning up expired cache entries cleans up each of the cache in this cache map. Since now cleanup tasks are scheduled per object using this same cleanup function, this leads to concurrent modification issues, with keys already being cleaned up by another task when one task tries to clear invalid cache entries.

Note - Creating a  new task when creating a new a Cache is created is redundant. This will create lots of tasks which will affect the performance AFAIS. Ideally, one (global) task is enough to clean cache.
AFAIS, moving the timer creation, scheduling (https://github.com/ballerina-platform/ballerina-lang/blob/master/stdlib/cache/src/main/ballerina/src/cache/cache.bal#L74-L78) and starting (https://github.com/ballerina-platform/ballerina-lang/blob/master/stdlib/cache/src/main/ballerina/src/cache/cache.bal#L86) to the top level should solve this issue.

Hi Shan,
Yes, but the issue is that if we put the task creation to the top level,
the task will start running when we import the cache module. That also
affects the performance.
But we have to come to a conclusion here on what are we going to compromise
on.
On Mon, Aug 12, 2019 at 11:43 AM Shan Mahanama<EMAIL_ADDRESS>wrote:

Note - Creating a new task when creating a new a Cache is created is
redundant. This will create lots of tasks which will affect the performance
AFAIS. Ideally, one (global) task is enough to clean cache.
AFAIS, moving the timer creation, scheduling (
https://github.com/ballerina-platform/ballerina-lang/blob/master/stdlib/cache/src/main/ballerina/src/cache/cache.bal#L74-L78)
and starting (
https://github.com/ballerina-platform/ballerina-lang/blob/master/stdlib/cache/src/main/ballerina/src/cache/cache.bal#L86)
to the top level should solve this issue.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ballerina-platform/ballerina-lang/issues/16703?email_source=notifications&email_token=AJRJROIGNFPNKTMRSNLUXW3QED5QLA5CNFSM4IDULAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BUNCY#issuecomment-520308363,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJRJROO227HHMKEJ3L5KMSTQED5QLANCNFSM4IDULAHQ
.

--
*Thisaru Guruge *| Software Engineer | WSO2 Inc.
(m) +94 71 720 9 720 | (e<EMAIL_ADDRESS>https://wso2.com/signature


input-date allow months dropdown

added selectMonths option to input-date directive to support month selection dropdown
as listed in Materialize Docs

Looks good to me.


ActionHeader Port from clinical

Summary
There exists an action header in the terra-clinical repo already. We would like to push this into terra-core and deprecate the clinical package. To make upgrading easiest, we would like to try to maintain the api for passivity.
Existing Props

Prop
Type
Required
Default
Description

title
string
optional
undefined
Text to be displayed as the title in the header bar

level
number
optional
1
Sets the heading level. One of 1, 2, 3, 4, 5, 6. (ADDED)

onClose
func
optional
undefined
Callback function for when the close button is clicked. The back button will not display if this is not set. On small viewports a back button will be displayed instead of a close button when a separate onBack callback is not set.

onBack
func
optional
undefined
Callback function for when the back button is clicked. The back button will not display if this is not set.

onMaximize
func
optional
undefined
Callback function for when the expand button is clicked. The expand button will not display if this is not set or on small viewports. Only the expand button will be rendered if onMaximize and onMinimize are set.

onMinimize
func
optional
undefined
Callback function for when the minimize button is clicked. The minimize button will not display if this is not set or on small viewports. Only the expand button will be rendered if both onMaximize and onMinimize are set.

onNext
func
optional
undefined
Callback function for when the next button is clicked. The previous-next button group will not display if neither this or onPrevious are set.

onPrevious
func
optional
undefined
Callback function for when the previous button is clicked. The previous-next button group will not display if neither this or onNext are set.

keepCloseButton
bool
optional
undefined
A Boolean indicating if close button should be displayed on small viewports when separate onBack callback is not set.

children
element
optional
undefined
Child element to be displayed on the right end of the header. This is intended to be used with the CollapsibleMenuView.

Changes

Currently the back button, and the expand/collapse buttons appear to be mutually exclusive as they share the same spot and change based off screen size https://github.com/cerner/terra-clinical/blob/master/packages/terra-clinical-action-header/src/ActionHeader.jsx#L129 . They will no longer be mutually exclusive as the back button, and expand/collapse will now be in 2 different sockets.
The existing action header uses functions specific to each special button (maximize, minimize, next, previous) to determine if they should be shown. These props will be kept for passivity, but it will be documented that they will be removed in the next major release, and instead the consumer should be passing them into their collapsible menu as children.
Button styles have been changed to utility
@mjhenkes  , we discussed with @neilpfeiffer, and he thought we should put the buttons from legacy function props in their same existing position (between the back button and title) for now.

How to deprecate the props
Seen here, https://discuss.reactjs.org/t/proposal-add-isdeprecated-to-react-proptypes/4037 something like this would work
import React from 'react';

class Component extends React.Component {
  render() {
    const {oldProp, newProp} = this.props;
    if (process.env.NODE_ENV !== 'production' && typeof oldProp !== 'undefined') {
      console.warn('oldProp is deprecated, use newProp instead');
    }
    ...
  }
}

React chose not to add an isDeprecated function for prop-types https://github.com/facebook/react/pull/6357 . Dan Abramov did make a package for this https://github.com/Aweary/react-is-deprecated but its not worth pulling in
Questions

Do the buttons' icon need to be themable? I'm assuming atleast some of them do since I see a vertical ... and a horizontal version in different spots.
Digging in more now, I see ActionHeader has a dependency on the terra-clinical-header. Is this also a component we want ported over directly (I don't see anything about it in callouts)? I assume we don't want a dependency from core -> clinical. We could probably get most of the functionality we need utilizing arrange, heading, and truncating the text.

I think we should decouple action-header from the header component, I'm guessing there are going to be theming differences between the two that require them to be decoupled.

Just to clarify, we are NOT planning to create a core version of terra-clinical-header, but rather integrate it as part of the action-header component itself. Is this correcxt?

@alex-bezek - I updated the props table above to include a new item level since consumers will need to be able to change up which-ever h1/2/3... level they need for correct screenreader accessibility expectations based on nesting order.
It is based on these comments realized for section-header: https://github.com/cerner/terra-core/pull/1313#issuecomment-370591792 and https://github.com/cerner/terra-core/pull/1313#discussion_r172290552

@ChaseSinclair We are not planning on creating a core version of terra-clinical-header. Anything terra-clinical-header provided terra-clincal-action-header should be coded directly into terra-action-header.

Do the buttons' icon need to be themable?

Yeah, let's assume so and make the icons like the back, close, more, prev, next, etc icons themable.
+1 on tech design.

+1 on the tech design

+1 on tech design