Unexpected # symbol in the URL after logging in

Library
<EMAIL_ADDRESS>Framework

JavaScript
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Description
After logging in, I do not expect to have an additional # symbol at the end of the URL.
I get this new behaviour when upgrading msal from 1.2.2 to 1.3.3.
In the Release notes, I did not notice any breaking change regarding that point.
Maybe I don't use msal in the right way, in that case feel free to add the question label.
// Before (i.e<EMAIL_ADDRESS>https://mywonderfulapp.com

// After (i.e<EMAIL_ADDRESS>https://mywonderfulapp.com/#

Note that the # symbol then disappears when navigating to another page of the application.
Error Message
None
Security

Is this issue security related? → No

Regression

Did this behavior work before? → Yes, it worked with<EMAIL_ADDRESS>
MSAL Configuration
// auth-provider.js
import { LoginType, MsalAuthProvider } from 'react-aad-msal'

export default () => {
  const msalConfig = {
    auth: {
      clientId: 'abcdefgh-1234-5665-4321-ijklmnopqrst',
      authority: 'https://login.microsoftonline.com/zyxwwxyz-1234-5665-4321-ijklmnopqrst/',
      validateAuthority: true,
      redirectUri: 'https://mywonderfulapp.com',
      postLogoutRedirectUri: 'https://mywonderfulapp.com',
      navigateToLoginRequestUrl: true
    },
    cache: {
      cacheLocation: 'sessionStorage',
      storeAuthStateInCookie: false
    },
    system: {
      loadFrameTimeout: 6000,
      tokenRenewalOffsetSeconds: 300,
      navigateFrameWait: 500
    }
  }
  const authenticationParameters = {
    scopes: [...]
  }
  const options = {
    loginType: LoginType.Redirect,
    tokenRefreshUri: 'https://mywonderfulapp.com/auth'
  }

  return new MsalAuthProvider(
    msalConfig,
    authenticationParameters,
    options
  )
}

// app.js
ReactDOM.render(
  <BrowserRouter>
    <AzureAD provider={authProvider()} forceLogin={true} reduxStore={store}>
      {...}
    </AzureAD>
  </BrowserRouter>,
  document.getElementById('root')
)

Reproduction steps

Open a fresh session in a private window
Log in to the application
Observe the difference in URL after redirection between versions 1.2.2 and 1.3.3

Expected behavior
I expect not to have an additional # symbol at the end of the URL after logging in.
Browsers/Environment
Tested in Chrome 84.0 & Firefox 79.0 with Windows 10, in both normal & private modes.

Hi @devfservant. This is a known side effect of the redirect handling process and should not cause any breaking behavior. Can you please clarify if this is causing a bug in your application? If so, please provide more context on how your application is affected.

Hello @technical-boy.
Actually, except the unexpected # symbol, it does not really affect the application: the additional # symbol would be the "bug".
Is there a way to prevent this "side-effect"? Do you know why we have not that behaviour with<EMAIL_ADDRESS>Maybe there should be a mention of that in the Release notes?
Thank you very much

Hey @devfservant . If you're interested in clearing the URL hash entirely after the redirect (including the anchor tag ('#')), you can use the following workaround:

Implement handleRedirectCallback and inside that callback, make sure you get a valid response object.
If you do have a valid response object, check that the URL hash has been cleared (basically, that it looks like 'https://mywonderfulapp.com/#' with nothing after the anchor tag). This step is important because otherwise, you may interrupt the redirect logic before the hash has been properly processed.
At this point, you can access the window.location.href value and change it to whatever you want (setting it to an empty string should clear the # tag and leave the user at the redirect URI.)

The reason why<EMAIL_ADDRESS>doesn't remove the "#" tag is that, as mentioned in the last point, doing so would force a page refresh.
Thanks again for raising the issue and please let me know if the workaround above produces the desired behavior so we can close the issue.

Hello @technical-boy,
Thank you for your help. I used handleRedirectCallback as follows:
// auth-provider.js
export default () => {
  ... // Defining `msalConfig`, `authenticationParameters`, `options`

  const res = new MsalAuthProvider(
    msalConfig,
    authenticationParameters,
    options
  )

  const { UserAgentApplication } = res
  UserAgentApplication.handleRedirectCallback((authErr, response) => {
    if (authErr) {
      throw authErr
    }
    window.history.pushState({}, '', '/') // Remove anchor tag ('#')
  })

  return res
}

and it works fine. Closing the issue,
Thanks


Feature/password reset

This will need slight changes once we have a website to enter the new password

Won´t merge until the coding gods approve

NVM I AM THE CODE GOD!


Update session information in Redis if the client recover from UDP to TCP/WebSocket connection

Done. https://github.com/turms-im/turms/commit/96b2f46d851524a3c4dbb8f4791ff05205e64a58


YAML-formatted HEREDOC strings break VSCode syntax highlighting

Description
YAML-formatted HEREDOC strings break VSCode syntax highlighting
Ruby LSP Information

Ruby LSP Information
VS Code Version
1.94.2
Ruby LSP Extension Version
0.8.7
Ruby LSP Server Version
0.20.1
Ruby LSP Addons

Ruby LSP Rails

Ruby Version
3.3.1
Ruby Version Manager
shadowenv
Installed Extensions

Click to expand

markdown-mermaid (1.25.0)
vscode-tailwindcss (0.12.11)
gitlens (15.6.2)
prettier-vscode (11.0.0)
copilot (1.241.0)
copilot-chat (0.21.2)
vscode-graphql-syntax (1.3.6)
remote-containers (0.388.0)
remote-ssh (0.115.0)
remote-ssh-edit (0.87.0)
remote-explorer (0.4.3)
ruby-extensions-pack (0.1.12)
ruby-lsp (0.8.7)
sorbet-vscode-extension (0.3.37)
markdown-all-in-one (3.6.2)

Ruby LSP Settings

Click to expand
Workspace
{}

User
{
  "enableExperimentalFeatures": false,
  "enabledFeatures": {
    "codeActions": true,
    "diagnostics": true,
    "documentHighlights": true,
    "documentLink": true,
    "documentSymbols": true,
    "foldingRanges": true,
    "formatting": true,
    "hover": true,
    "inlayHint": true,
    "onTypeFormatting": true,
    "selectionRanges": true,
    "semanticHighlighting": true,
    "completion": true,
    "codeLens": true,
    "definition": true,
    "workspaceSymbol": true,
    "signatureHelp": true,
    "typeHierarchy": true
  },
  "featuresConfiguration": {},
  "addonSettings": {},
  "rubyVersionManager": {
    "identifier": "auto"
  },
  "customRubyCommand": "",
  "formatter": "auto",
  "linters": null,
  "bundleGemfile": "",
  "testTimeout": 30,
  "branch": "",
  "pullDiagnosticsOn": "both",
  "useBundlerCompose": false,
  "bypassTypechecker": false,
  "rubyExecutablePath": "",
  "indexing": {},
  "erbSupport": true
}

Reproduction steps

Start the Ruby LSP with VSCode
Open a Ruby file
Add a HEREDOC with YAML syntax
See unexpected behavior

After adding the sample YAML string, or any string of YAML format:
    bad_heredoc_highlighting = <<~YAML
      property: abc
      another_property: def
    YAML

The closing HEREDOC and every line thereafter are formatted incorrectly.

btw here's where that code lives: https://github.com/microsoft/vscode/tree/main/extensions/yaml
I notice there was a recent revert which might affect this.

Thanks, I've confirmed.

@gerardo-navarro that is the same issue as #2492, which is the problem of interpolation in the middle of a heredoc using a language identifier. There's a lot more context in that issue.
The essence of the problem is that the grammar gets confused with the interpolation. Using GQL as the heredoc delimiter will assign the code inside the string as GraphQL, but the interpolation part is not valid GraphQL, which throws off the highlighting.
The best solution would be to not assign the heredoc to the GraphQL identifier if there's interpolation involved, but we haven't designed a solution yet.
You can also just use a different delimiter for the heredocs that have interpolation, which should no longer assign the GraphQL identifier and mitigate the issue (e.g.: <<~QUERY).


[tests-only] bump core commit id 2021/04/06

With this PR:

core commit ID is bumped to the latest up to 2021/04/06

@kiranparajuli589 tests are now failing https://drone.cernbox.cern.ch/cs3org/reva/1167. Can you take a look?

parellal bump PR in ocis https://github.com/owncloud/ocis/pull/1890

@kiranparajuli589 tests are now failing https://drone.cernbox.cern.ch/cs3org/reva/1167. Can you take a look?

@ishank011 previous(most recent) builds were behaving strangely failing most of the sharing tests. But at the date of the comment...CI seems stable (fails only on licence-check part of build suite)
So, expected failures need not be updated.


Use current movie as default for /watch (in certain time-periods)

time-period: Sun 20:00 -> Mo 00:00

probably needs api support to store votes

I think this feature is too much effort/too dump to actually do this.
Additionally, if we watch a different movie than the one voted for (which has happened) this might cause the wrong movie to be marked as watched.


bug: Having IonButton in an IonModal header breaks all IonTextarea's in the modal

Bug Report
Ionic version:
[x] 4.11.7
Current behavior:
When there is a modal with buttons (anywhere in the modal), any IonTextarea components with autoGrow={true} will have their inner textarea's height set to 0 until some input regardless of the value assigned to the rows prop.
GIF: https://share.getcloudapp.com/bLuGKz7l
Expected behavior:
It is expected that the inner textarea will have the number of rows equal to the rows prop at first render, and then grow from there if necessary.
Steps to reproduce:
Just have an IonButton and IonTextarea in the same modal.
Related code:
https://stackblitz.com/edit/ionic-v4-11-7-textarea-grow
      <IonModal isOpen={open} onDidDismiss={() => setOpen(false)}>
        <IonContent>
          <IonButton onClick={() => setOpen(false)}>
            Close Modal
          </IonButton>
          <IonTextarea
            rows={3}
            autoGrow={true}
          />
        </IonContent>
      </IonModal>

Other information:
N/A
Ionic info:
Ionic:

   Ionic CLI       : 5.4.13 (/Users/evan/.config/yarn/global/node_modules/ionic)
   Ionic Framework : @ionic/react 4.11.7

Capacitor:

   Capacitor CLI   : 1.4.0
   @capacitor/core : 1.4.0

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v13.5.0 (/usr/local/Cellar/node/13.5.0/bin/node)
   npm    : 6.13.4
   OS     : macOS Catalina

Any update on this? It's still an issue as of today.


"npm outdated" may span across multiple lines

I see the following at https://michaelcurrin.github.io/dev-cheatsheets/cheatsheets/ci-cd/github-actions/persist.html :

Examples
Get output from npm outdated command, if any.
steps:
 - name: Check for outdated packages
   id: vars
   run: |
     OUTDATED=$(npm outdated) || true

     echo "OUTDATED={OUTDATED}" >> $GITHUB_OUTPUT

 - name: Upgrade
   if: ${{ steps.vars.outputs.OUTDATED != '' }}
   run: npm upgrade

I think this example is just wrong and misleading. The output of npm outdated may span across multiple lines, breaking the expected syntax of GITHUB_OUTPUT.
AFAIK, the right solution is this:
https://github.com/github/docs/pull/21599/files

What do you think about this?
echo "OUTDATED='$OUTDATED'" >> $GITHUB_OUTPUT

To give this.
OUTPUT='Package                           Current  Wanted  Latest  Location                                       Depended by
@types/mocha                       10.0.1  10.0.3  10.0.3  node_modules/@types/mocha                      ...
...
'

Well, unfortunately the problem is that the syntax expected to be stored in GITHUB_OUTPUT is not bash code. The apostrophes would be literal characters stored as the value of property OUTDATED, breaking the condition ${{ steps.vars.outputs.OUTDATED != '' }} as well.
See https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings


Add a Gitter chat badge to README.md

Xenapto/mailchimp_api_v3 now has a Chat Room on Gitter
@dominicsayers has just created a chat room. You can visit it here: https://gitter.im/Xenapto/mailchimp_api_v3.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Added manually


Tekst doesn't render orange on a Ubuntu Phone

On a Ubuntu Phone, the text doesn't render orange. When I run the test, the last test "Your h1 element should be orange" fails.
First I thought it was a Ubuntu Phone bug or at least a ubuntu browser app bug but... If I copy the text in a independent html-file en browse to it, the text renders nicely orange.

Challenge Waypoint: Override Class Declarations by Styling ID Attributes has an issue.
User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

Hello World!

The code from your screenshot is incorrect and is making the text green. I can't repro this in Firefox mobile -- it works fine in my tests. Given that the code you took a screenshot of is incorrect I am going to close this until someone else can repro it.

Thanks for the quick follow-up. The code under 'My code:' is correct. I feel stupid to ask but what is the error in the code from the screenshot?

@RDominique this has happened to me as well. Did u figure a way to bypass the challenge?
@ltegman  I use mint which is also an ubuntu based OS.
`
Hello World!
`
Cheers

I opened the browser sources and checked that the variable "common.challengeSeed" did not have the id related html/css code in it.
Hitting enter into the last character of the browser makes the mobile display to refresh and display Hello World! orange as expected.
However, the "common.challengeSeed" variable is not refreshed with the new code and thus I cannot complete the challenge

@AngelKyriako your problem probably is just the :after the #orange-text

@hallaathrad thanks, I retried in windows and it worked. But I guess it worked cause I skiped : and not because of the OS
cheers


Fix formData Polyfill for radios&co

This is a fix for the FormData Polyfill. It does not handle radio, checkboxes and other special input types correctly. Feel free to copy the changes if this PR can not directly merged (sorry for the commit messages ;)).
all the best
gexx

@GexxOn Thanks for bring this issue to attention.  Looks like the core issue is there is a typo in the logic that inspects a full form element passed to the FormData constructor.  The radio and select check should be on element.type instead of element.value.  I won't be able to address this issue any time soon.  Please file a issue, if you have the time.

Since we don't accept pull requests. We will be tracking this issue with our internal issue tracker and will further release the plugin with fix.


Add IPC A600 to standards section

Why: So that boards can be specified to follow the A600 standard when delivered by a manufacturer.

@tojanpedersen I decided against adding this to the testing section as that would change how this question is categorised for users. As this is a standard I think it is best to have this in the standards section so that users can find it in the expected place.
Let me know what you think.

@tojanpedersen I decided against adding this to the testing section as that would change how this question is categorised for users. As this is a standard I think it is best to have this in the standards section so that users can find it in the expected place.
Let me know what you think.

I agree on that!


DB2  Chinese characters is garbled

Description
Encoding of tables in DB2 is iso-8859-1， Chinese characters in query result is garbled。
DBeaver Version
Community Edition 23.3.5
Operating System
Win10
Database and driver
DB2
Steps to reproduce
No response
Additional context
No response

Hello @zidian
Please provide screens of your issue, as well as your database and driver versions.

Hello @zidian
Please provide screens of your issue, as well as your database and driver versions.

screens   like this：

Hello @zidian,
You can't encode Chinese characters with Latin-1 encoding. Use UTF-8 instead.

Hello @zidian,
You can't encode Chinese characters with Latin-1 encoding. Use UTF-8 instead.

I have used other tools，such as SqlDbx or DB2 command tools, Chinese characters  in query result  can well display。So， I think  encode Chinese characters with Latin-1 encoding is not problem。

Please, try to change the encoding to UTF-8, the current used iso-8859-1 is 8 bits which does not fit well for Chinese.

Please, try to change the encoding to UTF-8, the current used iso-8859-1 is 8 bits which does not fit well for Chinese.

We cannot change the encoding 。But we have solved this problem  by using costumed driver with Apache Druid。

Thank you for update. As far as I understood, the issue is solved. So, I'm closing the issue.


[WIP] ARROW-2574: [Python] Add Cython and Python code coverage

After spending a non-trivial time wrestling with Cython and our build system, we're now able to generate and upload Python and Cython coverage results as part of a Travis-CI run (in addition to C++ coverage).
TODO:

[ ] try to enable tracing nogil sections in Cython code
[ ] reenable stuff I disabled in the Travis-CI setup

Here is an example coverage report: https://codecov.io/gh/pitrou/arrow/list/5bd7b0e261b2b72b2b0c14d0ceb80de03e1e3c06/

Codecov Report

Merging #2050 into master will decrease coverage by 1.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
- Coverage   87.44%   85.79%   -1.65%
==========================================
  Files         189      229      +40
  Lines       29368    40091   +10723
==========================================
+ Hits        25682    34398    +8716
- Misses       3686     5693    +2007

Impacted Files
Coverage Δ

cpp/src/arrow/memory_pool-test.cc
96.55% <0%> (-3.45%)
:arrow_down:

cpp/src/arrow/python/helpers.h
88.88% <0%> (-1.12%)
:arrow_down:

cpp/src/arrow/io/io-file-test.cc
91.76% <0%> (-0.92%)
:arrow_down:

cpp/src/arrow/util/thread-pool-test.cc
98.87% <0%> (-0.57%)
:arrow_down:

cpp/src/arrow/python/builtin_convert.cc
91.31% <0%> (-0.5%)
:arrow_down:

cpp/src/arrow/python/python_to_arrow.cc
88.14% <0%> (-0.07%)
:arrow_down:

cpp/src/arrow/python/common.h
100% <0%> (ø)
:arrow_up:

rust/src/memory_pool.rs

rust/src/list_builder.rs

rust/src/array.rs

... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48eee79...5bd7b0e. Read the comment docs.


Using fork_from instead of resume in wandb.init

Resolves #32

This feature is in preview atm https://docs.wandb.ai/guides/runs/forking


How to avoid checking for problems in VSCODE interactive

It looks like this
[{
	"resource": "/Interactive-1.interactive",
	"owner": "_generated_diagnostic_collection_name_#3",
	"severity": 8,
	"message": "SyntaxError: Expected `except` or `finally` after `try` block",
	"source": "Ruff",
	"startLineNumber": 1,
	"startColumn": 1,
	"endLineNumber": 1,
	"endColumn": 7
},{
	"resource": "/Interactive-1.interactive",
	"owner": "_generated_diagnostic_collection_name_#3",
	"severity": 8,
	"message": "SyntaxError: Expected ',', found name",
	"source": "Ruff",
	"startLineNumber": 1,
	"startColumn": 27,
	"endLineNumber": 1,
	"endColumn": 45
},{
	"resource": "/Interactive-1.interactive",
	"owner": "_generated_diagnostic_collection_name_#3",
	"severity": 8,
	"message": "SyntaxError: Expected ',', found string",
	"source": "Ruff",
	"startLineNumber": 1,
	"startColumn": 45,
	"endLineNumber": 1,
	"endColumn": 89
},{
	"resource": "/Interactive-1.interactive",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": {
		"value": "F821",
		"target": {
			"$mid": 1,
			"path": "/ruff/rules/undefined-name",
			"scheme": "https",
			"authority": "docs.astral.sh"
		}
	},
	"severity": 8,
	"message": "Undefined name `con`",
	"source": "Ruff",
	"startLineNumber": 1,
	"startColumn": 1,
	"endLineNumber": 1,
	"endColumn": 4
},{
	"resource": "/Interactive-1.interactive",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": {
		"value": "F821",
		"target": {
			"$mid": 1,
			"path": "/ruff/rules/undefined-name",
			"scheme": "https",
			"authority": "docs.astral.sh"
		}
	},
	"severity": 8,
	"message": "Undefined name `carteira`",
	"source": "Ruff",
	"startLineNumber": 1,
	"startColumn": 65,
	"endLineNumber": 1,
	"endColumn": 73
},{
	"resource": "/Interactive-1.interactive",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": {
		"value": "F821",
		"target": {
			"$mid": 1,
			"path": "/ruff/rules/undefined-name",
			"scheme": "https",
			"authority": "docs.astral.sh"
		}
	},
	"severity": 8,
	"message": "Undefined name `safra`",
	"source": "Ruff",
	"startLineNumber": 1,
	"startColumn": 76,
	"endLineNumber": 1,
	"endColumn": 81
},{
	"resource": "/Interactive-1.interactive",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": {
		"value": "F821",
		"target": {
			"$mid": 1,
			"path": "/ruff/rules/undefined-name",
			"scheme": "https",
			"authority": "docs.astral.sh"
		}
	},
	"severity": 8,
	"message": "Undefined name `con`",
	"source": "Ruff",
	"startLineNumber": 1,
	"startColumn": 1,
	"endLineNumber": 1,
	"endColumn": 4
}]

I'm not sure I understand what you're asking for. Could you share some more details?
Do you want Ruff to stop checking the /Interactive-1.interactive file? What kind of file is it? Is it a notebook? Any chance that you specified the language Python in VS Code?

Yes, interactive1 is an interactive notebook on vscode that I run using Run in interactive Window > Run Selection/ Line in interactive Window

I don't think the extension has a dedicated setting for this. Maybe we should consider adding one (CC: @dhruvmanila).
For now, you'd have to create  ruff.toml and set extend-exclude = ["*.ipynb"] as described in the 0.6 announcement blog post

It looks like this

Can you tell me where do you get this output from? I don't really see any diagnostics surfaced by Ruff in the interactive window:

Additionally, it seems that Ruff is already ignoring those files?
2024-12-09 13:37:14.574 [info] [Trace - 1:37:14 PM]   12.583897833s DEBUG      ruff:main ruff_server::resolve: Ignored path as it's not in the inclusion set: /Interactive-1.interactive

I don't think the extension has a dedicated setting for this. Maybe we should consider adding one (CC: @dhruvmanila).

Are you referring to a setting to explicitly disable linting and formatting Jupyter Notebooks in VS Code ?

For now, you'd have to create  ruff.toml and set extend-exclude = ["*.ipynb"] as described in the 0.6 announcement blog post

I don't think this will work because the interactive file doesn't have a .ipynb extension.

It is not a jupyter notebook, is is just an interactive window that spawns when you click run in interactive window, I think vscode behind the screens create a temporary python file

I am on a company pc so I can't post the pictures from vscode directly but here it is image

I dont think so, I am using F9

Thanks, but the "Run selection/line in interactive window" doesn't give me any warnings either :(
I at least see the diagnostics from Pylance but not from Ruff:

When I click on the diagnostics from Pylance, it opens up an empty "Interactive-1.interactive.py" file which tells me that they might be "copying" the code into a temporary file and then running it.
I'm still not seeing the diagnostics from "Interactive-1.interactive"


Project CRUD functionality

We need to be able to create, read, update, delete projects on Firebase storage.
They need to be assigned unique IDs and be associated with a given user.
This needs to be hooked to the UI for #513, #728 , #729, #730.

Related to #71


Add support for contextual schema in validation

This pull request achieves the same goal as #9 except I used Ruby’s lambda. The code is isn’t changed much and it’s still adds the needed flexibility of dynamic per-record schema.
I also took the time to write proper documentation for values supported for the :schema option.

:+1:


WFLY-10084 Add support for the proxy protocol

https://issues.jboss.org/browse/EAP7-974
https://issues.jboss.org/browse/WFLY-10084
https://github.com/wildfly/wildfly-proposals/pull/40

Retest this please

Retest this please


Provides metaclass to simplify GPflow Model creation workflow

In my work with GPflow, constructing a new model often has a workflow similar to the following:

subclass GPflow.models.Model and create a build_likelihood function
all the terms that need to go into build_likelihood are too complicated, maybe have some bugs ... so split into smaller build_foo functions that compute individual terms and are combined in build_likelihood
to be able to interact with the individual terms, I need to write separate compute_foo functions, that do nothing other than calling build_foo but are wrapped using @AutoFlow().

E.g.
import tensorflow as tf
import GPflow

class Demo(GPflow.model.Model):
    @GPflow.param.AutoFlow(tf.float64, [None, 2])
    def compute_foo(self, x):
        return self.build_foo(x)

    def build_foo(self, x):
        return tf.reduce_sum(x)

With the metaclass in this module, the code can be simplified to the following:
import tensorflow as tf
import GPflow, GPflow.metaautoflow

class Demo(GPflow.model.Model, metaclass=GPflow.metaautoflow.MetaAutoFlow):
    @GPflow.param.AutoFlowify(tf.float64, [None, 2])
    def build_foo(self, x):
        return tf.reduce_sum(x)

and the compute_foo function will be constructed automatically. This saves typing, making mistakes in writing compute_... functions, and leads to more readable code, particularly if there is a large number of build_... functions...
As it stands, this would not change any of the existing codebase, so would be completely backwards-compatible. If this would turn out to be useful to many other people, it would eventually be possible to add the metaclass directly to GPflow.model.Model so that the functionality would be inherited by all subclasses, but it can also stand alone and anyone who does find it useful can add it to their own models.

Hello and welcome, @st--!
I like the idea of eliminating the need for both an "original" Tensorflow function and an AutoFlowed alternative which simply calls the original. I have thought about this a bit in the course of implementing #398 and I think it might be nicer to make AutoFlow smater instead of adding another decorator: It should be doable to simply use tensors supplied as arguments and only do the magic replacement of numpy arrays by tensorflow variables if neccessary. I did not (yet) implement this since #398 is quite complicated already and I thought it would probably be a good idea to tackle this as a separate PR. In terms of code the change should not be that significant.
I do however think that both your method and an even more magic AutoFlow are at risk of being quite unpythonic, since so much logic is created implicitly and it might be hard to discover this functionality as a new user. What do you think?

Hi, thanks for pointing out #398 / #383 - that had come up for me, too, and would be really nice to have that sorted out! (I like the proposed keyword syntax.)
I guess it should be possible to add a clause inside AutoFlow that checks whether arguments are tf Tensors (in that case leave them alone and just call the wrapped method and pass them on directly) or np arrays (in that case do all the AutoFlow-magic before calling the wrapped method with the tf variables), though might want an extra check to ensure that all "free" arguments are either np or tf, not mixed... (On a related but separate note, AutoFlowed functions also seem to give rather unhelpful error messages e.g. when called with the wrong numbers/types of arguments, so something else worth looking at.) Don't know how long that'd take to implement, test & merge though.
This metaclass has the advantage of not changing any functionality, at the moment a user would have to explicitly add this metaclass to their model for it to work, and I'd hope they'd then read through the documentation as well... I think this is a perfectly pythonic use of metaclasses, actually:) Discussed this with @jameshensman who seemed in favour.
Obviously if/once AutoFlowed functions can cope both with being called inside a tensorflow graph and "from the commandline" with numpy arrays, this module becomes redundant and could be removed again - until then, it might make life easier for others.
I've split this up into issue #427 ...

I agree that for the development process, this PR would sure be convenient. My thoughts concerning discoverability were directed towards essential functions like predict_f or compute_log_likelihood which I think should probably be defined explicitly to make the life of both new developers and IDEs as easy as possible. This new functionality being optional is a strong argument however since, as you say, people basically need to read the documentation to use it anyway.

NB- commit 797a442793dfe9428e07a38e707a9e96c2661a6b only adds the file metaautoflow.py and does not import this module in the __init__.py. So, at the moment, one would have to explicitly import GPflow.metaautoflow (rather than import GPflow and being able to use GPflow.metaautoflow out of the box). Should this be added to the pull-request?


Error in gobot_tutorial!

Hi, I am trying to run gobot_tutorial jupyter noteebok and I get a strange error when trying to interact with the bot. In the training I did not have any problems but when I try to run the 2nd cell of "Interact with the bot", which is "
bot(['good evening, bot'])", I get the following error:

ValueError                                Traceback (most recent call last)
 in
----> 1 bot(['good evening, bot'])
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/core/common/chainer.py in call(self, *args)
205
206     def call(self, *args):
--> 207         return self._compute(*args, param_names=self.in_x, pipe=self.pipe, targets=self.out_params)
208
209     @staticmethod
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/core/common/chainer.py in _compute(failed resolving arguments)
228                 res = component.call(**dict(zip(in_keys, x)))
229             else:
--> 230                 res = component.call(*x)
231             if len(out_params) == 1:
232                 mem[out_params[0]] = res
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/core/models/tf_backend.py in _wrapped(*args, **kwargs)
26     def _wrapped(*args, **kwargs):
27         with graph.as_default():
---> 28             return func(*args, **kwargs)
29
30     return _wrapped
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/models/go_bot/network.py in call(self, batch, user_ids)
471
472                 _, predicted_act_id, tracker.network_state =
--> 473                     self._infer(tokens, tracker=tracker)
474
475                 tracker.update_previous_action(predicted_act_id)
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/core/models/tf_backend.py in _wrapped(*args, **kwargs)
26     def _wrapped(*args, **kwargs):
27         with graph.as_default():
---> 28             return func(*args, **kwargs)
29
30     return _wrapped
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/models/go_bot/network.py in _infer(self, tokens, tracker)
425                               [[action_mask]], [[tracker.network_state[0]]],
426                               [[tracker.network_state[1]]],
--> 427                               prob=True)
428         return probs, np.argmax(probs), (state_c, state_h)
429
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/core/models/tf_backend.py in _wrapped(*args, **kwargs)
26     def _wrapped(*args, **kwargs):
27         with graph.as_default():
---> 28             return func(*args, **kwargs)
29
30     return _wrapped
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/deeppavlov/models/go_bot/network.py in network_call(self, features, emb_context, key, action_mask, states_c, states_h, prob)
516         probs, prediction, state =
517             self.sess.run([self._probs, self._prediction, self._state],
--> 518                           feed_dict=feed_dict)
519
520         if prob:
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/tensorflow/python/client/session.py in run(self, fetches, feed_dict, options, run_metadata)
948     try:
949       result = self._run(None, fetches, feed_dict, options_ptr,
--> 950                          run_metadata_ptr)
951       if run_metadata:
952         proto_data = tf_session.TF_GetBuffer(run_metadata_ptr)
~/Workspace/virtualenvs/research/lib/python3.6/site-packages/tensorflow/python/client/session.py in _run(self, handle, fetches, feed_dict, options, run_metadata)
1147                              'which has shape %r' %
1148                              (np_val.shape, subfeed_t.name,
-> 1149                               str(subfeed_t.get_shape())))
1150           if not self.graph.is_feedable(subfeed_t):
1151             raise ValueError('Tensor %s may not be fed.' % subfeed_t)
ValueError: Cannot feed value of shape (1, 1, 112) for Tensor 'features:0', which has shape '(?, ?, 129)'

Could anyone help me, please?
I would appreciate it so much!
Thanks,

Exact same problem here. With the new release, I noticed some things are changed. My previous working code for simple gobot, now getting the same error. Judging by the error, this seems to be caused by some changes in 'network.py' file, possibly something to do with the new trackers' split implementation. For the time being, try downgrading to previous version.

Hey!
Thanks for rising an issue: we are working on go bot refactoring, debugging and improvement right now and such a feedback is extremely helpful.
The updated version is work-in-progress though and I think that for now some hacks are the best way to deal with bugs in the released version.
I suggest you to simulate the batched dialogue inference by wrapping the replics onto the batch of single dialogue of length 1 (the batch of dialogues is the list of lists of dicts usually).
So the bot call will look like this:
>>> bot([[{"text": "the weather is clooudy and gloooomy"}]])
[['Then you should cycle!']]


[BE] Nightly Release has been failing but no alerting

🐛 Describe the bug
Nightly release has been failing for a couple of months, but we weren't aware. Figure out alerting on these failures
https://github.com/pytorch/data/actions/runs/11031708385
Versions
main

It turns out there is a rule that sends any failing CI job as a task to the current torchdata oncall. We should make a butterfly rule to surface test failures more broadly

Closing since this doesn't seem to be an issue anymore


investigate a more async interface

In current implementation every write blocks until the data is flushed.
This used to be a calculated delay which was replaced by flush as the timing was not correct / reliable.
Making this change made me think that blocking per character can cost more time than writing all characters and after the last is written do one flush for all of them. This is especially useful if one needs to do calculations or sensor readings etc between two or more characters.
Need to investigate if it is worth adding to the library.
Interface might look like:
int asyncWrite(uint8_t byt);
int asyncWrite(uint8_t * buffer, uint8_t length);

// At the end call RS485.flush(); to block until all flushed.

Q: is the length of the outgoing queue retrievable / portable ? SWS?

Needs low level control over sending and IO buffers + maybe even a worker background thread or so.


Update New-CsAutoAttendantCallableEntity.md

Update for Nested AA/CQ transfers.

@mkbond007 Please and thanks.... this can be released prior to our GA of Nov.7


Rare pokemon at Transfer

I sense we've already fixed this buut,
here is the case it doesn't work at
Seems when I do conversion from other than BSX address it appears?
https://beta.kodadot.xyz/transfer/?target=EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU&usdamount=52930000000

at here it worked https://beta.kodadot.xyz/transfer/?target=bXj1N8PuXSaZAR3TdMxmXAce32FhZpW3qy8NSj9djB1SAPhz7&usdamount=0

tested right now with multiple kusama / moonsama addresses and it worked without a problem


Pull request to merge default branch to TG-T12023

@ascaria - merging for development purpose

@ascaria - reviewed and approved


Got killed when training box corrector

Hi, may I ask how big is your RAM? I got killed process when deriving the coco_proposals_trainval_results.pkl.

I have the same problem. My RAM is 64G. Feel free to contact me by<PHONE_NUMBER>(QQ).

I guess it is because the array of res is too big, it should be saved into separate files.

Could you explain it more specifically? Like how to edit the code. Sorry I am a beginner.

I am also working on it, hopefully, it works.


security risk -- memumeters has no hash check

"sha256 :no_check"
"""
$ curl -s 'https://raw.githubusercontent.com/caskroom/homebrew-cask/master/Casks/menumeters.rb' | egrep -i 'sha[0-9]'
sha256 :no_check
"""
And because this blob is downloaded over plaintext HTTP, potential for meddling the download is easy and elevates the security threat.

Many casks have no check. We can’t check them when the url is unversioned, or the cask would constantly break.

Have you asked the distributor to version them? If not let's start there.
On Tue, Jul 21, 2015 at 3:21 PM Vítor Galvão<EMAIL_ADDRESS>wrote:

Many casks have no check. We can’t check them when the url is unversioned,
or the cask would constantly break.
—
Reply to this email directly or view it on GitHub
https://github.com/caskroom/homebrew-cask/issues/12749#issuecomment-123496611
.

Please do.

If I understand correctly, the publisher would need to move from:
http://www.ragingmenace.com/software/download/MenuMeters.dmg
to something like:
http://www.ragingmenace.com/software/download/MenuMeters-v1.8.1.dmg
To resolve the issues so that versioning can be performed for the cask. If the author does not respond or does not accommodate homebrew for Mac users in this manner, I propose that versioning can still be done by HTML scraping, since the version is there. Is there a reason why that is not being done?
"""
$ curl -s 'http://www.ragingmenace.com/software/menumeters/index.html' | egrep 'MenuMeters\ .*dmg'
MenuMeters 1.8.1 compressed disk image (dmg)
"""

If I understand correctly

You do, that’s it.

versioning can still be done by HTML scraping

No.

Is there a reason why that is not being done?

Yes, because it’s crazily inefficient and extremely prone to breakage. We’re not going to parse HTML in such a manner.
In addition, you’re thinking backwards. It’s not the version that matters, the download url is. version follows from that, not the reverse.

Seems like homebrew could sha256 hash the binary and have a small lookup table of recent versions to compare against, but yes, I understand this creates more issues...

Again, no. Are you suggesting we download it every day and check the hash? That’s unreal. Not only would we be hammering the developer’s servers, we don’t have the money or the resources for such an operation.

No, I was suggesting using something less wasteful like...
"""
$ curl -s -I -X HEAD 'http://www.ragingmenace.com/software/download/MenuMeters.dmg'
HTTP/1.1 200 OK
Date: Mon, 27 Jul 2015 17:03:17 GMT
Server: Apache
Last-Modified: Thu, 23 Oct 2014 03:43:12 GMT
ETag: "12170a-5060edd19d6cd"
Accept-Ranges: bytes
Content-Length: 1185546
Content-Type: application/octet-stream
"""
You don't download unless Last-Modified / ETag / Content-Length are outdated...

For code blocks use triple backticks, not """.
That’s better, but we’d still need a server (or someone) to do the checks regularly.

Author says it will be too much effort and not guarantee much anyway. The author suggests the following instead using the DMG signature:
"I'd suggest investigating signature verification in HomeBrew using SecCodeCheckValidity()"

Many casks have no check. We can’t check them when the url is unversioned, or the cask would constantly break.
Then why not remove these casks by default, or issue a warning when user attempts to install such package?

Because they’re still useful and many people don’t mind. Breaking the experience for everyone makes no sense. Regardig showing a warning, there’s an open issue discussing that (search for it, I’m on a phone).


Adding Python support

It looks nice as a first approach. Does it contain service support?

Yes, it is. All CfWebApp entities inherit from CloudFoundryWebApp which defines a generic service support.

Great, LGTM


Loggerd: 100% CPU- should not use bz2 compression on camera video

Describe the bug
When simulating with Carla, I observed 100% usage of the CPU core that loggerd runs on. The roadCameraState is being handled through the logger_log routine that uses bz2 compression. The video is not compressible by that lossless method, and the high data rate (~60MB/s) causes loggerd to be overloaded.
OS Version
Ubuntu20.04LTS
openpilot version or commit
53e095343de56ff838f36ed9feda9f31ff6358b6
Additional info
I tried fixing it by changing line 334 of loggerd.cc to:
if (!it.should_log || strstr(it.name,"CameraState")) continue;
This prevents any of roadCameraState, driverCameraState, or wideRoadCameraState from being logged through the bz2 path, and seems to solve the immediate problem. The camera video is compressed to .hvec by the encoder threads. There is a question of how this issue should be fixed, whether simply applying my one-liner to loggerd.cc, or perhaps some sort of system-level solution that coordinates the should_log boolean from services.py together with the .hvec logging done by the encoder threads.

We'd like to keep our issue tracker focused on comma two/three, so I'm gonna close this. loggerd for PC mostly exists for allowing the tests to run on PC. We'd certainly merge PRs to improve the PC experience though!
As for the frames being the in cameraState packets, we should fix this. CARLA uses a fake camera in camerad called "frame stream" as it was easier to stuff the frames in the capnp messages than send over visionipc from python as camerad normally does. However, we now have a nice python visionipc server implementation, so we can do this properly now. I started that in #21324 but didn't have time to finish it. Feel free to take that PR and finish it up.

First, my apologies, I didn't intend to misuse the "Issues". I'm still learning how things are done in this community.
I will look into that PR #21324 and see what I can figure out. It is a little difficult for me to see how things work- I only have the PC simulation environment, and I don't have much understanding of the "big picture" yet. I've just been finding and fixing bugs in the simulation.
So, the cereal implementation supports the ...CameraState messages (and loggerd erroneously applies bz2 compression), but that was just to provide a temporary "hack" for the PC simulation. Am I correct that they should be removed from the cereal code when the PR gets finished, or is something else intended?
Thank you for the guidance.

No worries :)
Check out our new docs at https://docs.comma.ai. Fortunately, fixing the simulator should be a great way to learn the codebase. Basically, loggerd indiscriminately subscribes to all the services defined in cereal/services.py that specify the should_log flag.
Here's a more in-depth overview:
camerad captures frames at 20Hz and for every frame. it sends out the frame over visionipc and the xxxCameraState metadata packet over msgq. When the CARLA bridge was initially written, there wasn't an easy way to send frames over visionipc from python, so an image field was added to the FrameData struct. The "frame stream" camera was written to have camerad listen for the xxxCameraState packets instead of sending them out like it normally does, then send out the image stuffed in the image field over visionipc.

Thank you, that helps a lot. So, the intent is to keep logging the CameraState messages for the metadata, but removing the video image stream from Carla and instead get it into openpilot using visionipc (and log it normally through the encoder threads). Did I get that right?

I think you've got the right idea, but didn't quite understand what you said. The goal is to send the frames over visionipc, which allows us to stop stuffing them in roadCameraState. In this case, we also  wouldn't run camerad at all for CARLA, as the bridge would handle all of its functionality. The encoders currently work correctly as camerad's frame stream takes care of sending the frames over visionipc (they're just in two places now - visionipc and roadCameraState).

Sorry if I wasn't clear, but I think we are on the same page now. Yes, it makes sense that the bridge would take on the role of camera, sending a video stream to visionipc and also publishing metadata in roadCameraState. Thank you!


cen64: init at 20200220-git

Motivation for this change
cen64 is an emulator that's useful for n64 development
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113750 at 8d117ad7 run on x86_64-linux 1

1 package built:

cen64

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/misc/emulators/cen64/default.nix:17:3:
   |
17 |   installPhase = ''
   |   ^


3.0.4: update from main

This merges current main into v3.0.4-dev, resolving the two merge conflicts in

.gitignore: taken from main
validate-markdown.yaml: taken from v3.0.4-dev

Same question here- why are we doing this when we're about to merge in the other direction?

From a DM conversation, apparently this is how it's preferred to resolve conflicts, which seems messy to me but I won't object to it.


ERROR: ProcessNewBlock: AcceptBlock FAILED (Transaction check failed (tx hash d14522db4b7d4cacd1c4c3982b6a71ab74f5d8ea72be87405170d2b6f640789c) )

3.0.1 is stuck at 37 week(s) behind, tried -rescan, -reindex, even deleted ~/.nix/{blocks,chainstate} but it keeps getting stuck. The debug.log is flooded with this line:
2019-06-04 08:55:34 ERROR: ProcessNewBlock: AcceptBlock FAILED (Transaction check failed (tx hash d14522db4b7d4cacd1c4c3982b6a71ab74f5d8ea72be87405170d2b6f640789c) )

getblockchaininfo:
{
  "chain": "main",
  "blocks": 53032,
  "headers": 230440,
  "bestblockhash": "111fc7ff438c9f5f5e578f5165d8627a037a0f7394afd9d8f2603de2283f690c",
  "difficulty":<PHONE_NUMBER>640576,
  "mediantime":<PHONE_NUMBER>,
  "verificationprogress": 0.2802159764612827,
  "initialblockdownload": true,
  "chainwork": "0000000000000000000000000000000000000000000000002267da98578cca63",
  "size_on_disk": 61931819,
  "pruned": false,
  "softforks": [
    {
      "id": "bip34",
      "version": 2,
      "reject": {
        "status": true
      }
    },
    {
      "id": "bip66",
      "version": 3,
      "reject": {
        "status": true
      }
    },
    {
      "id": "bip65",
      "version": 4,
      "reject": {
        "status": true
      }
    }
  ],
  "bip9_softforks": {
    "csv": {
      "status": "active",
      "startTime":<PHONE_NUMBER>,
      "timeout":<PHONE_NUMBER>,
      "since": 6
    },
    "segwit": {
      "status": "active",
      "startTime":<PHONE_NUMBER>,
      "timeout":<PHONE_NUMBER>,
      "since": 6
    }
  },
  "warnings": ""
}

@stintel are you building from the tag, or using gitians?

Building from https://github.com/NixPlatform/NixCore/archive/v3.0.1.tar.gz which apparently changed since I built. Once a release tarball was published it should never be changed anymore. If changes are needed, a new release should be made.

Build from current tag and reindex. Older tag has issues and was not production ready.

It works after rebuilding the "new" 3.0.1. But please, don't do this in the future. If a release is bad it's bad. Accidents happen. You should have tagged 3.0.2 or <IP_ADDRESS> instead of "rewriting history". This is a nightmare for package maintainers.

Agreed. An issue on our behalf. Apologies for the inconvenience!

No worries. Glad we're on the same page!


let client know if the server is not accepting new connections

Use Case
While we're working to set up autoscaling on the backend, if too many concurrent users use the website, they could overload the server. It would be nice if a client could warn them that the server is under high load rather than the blank viewer spinning forever.
Acceptance Criteria
A client that tries to connect to the server when it is unable to accept new connections due to traffic gets a warning message back from the server.
Details
from @EricJIsaac: We will need something outside the server to identify crashes & hangs (Kubernetes?), since the application would be unable to broadcasts its own death

Will revisit with new server implementation


Remove use of INotebookModel when using NativeNotebooks (serializer)

With the new Content provider code in VS Code we will not be provided the Uri when asked by VS Code to translate the bytes into a Notebook document.
https://github.com/microsoft/vscode/issues/121974#issuecomment-826668767
This is a good thing, we can remove the use of these old wrappers else these will never go away and we'll keep using these wrappers & extending them.
We have a few places where INotebookModel is used:

Trust (that's going to be handled by VSC Code, hence this won't be required for trust)
Export (we can get the details of the document from the VS Code document)
Context variables (we can use VS Code document instead)

Note:
This is not a breaking change in VSC, but the old content provider will not be maintained either. Hence we'll need to move to the new one (e.g. to get around a few bugs that users have reported, when opening ipynb as json, etc).

Upstream issue https://github.com/microsoft/vscode/issues/121974#issuecomment-836763770

Validated. Also validated by the test plan.


Added UIViewTests

More tests, more ❤✅💪🚀

          2 Messages

  :book:
  Executed 105 tests, with 0 failures (0 unexpected) in 0.982 (1.159) seconds

  :book:
  Executed 101 tests, with 0 failures (0 unexpected) in 0.839 (1.019) seconds

  Generated by :no_entry_sign: danger

Current coverage is 30.85% (diff: 100%)

Merging #275 into master will increase coverage by 0.14%

@@             master       #275   diff @@
==========================================
  Files            45         45
  Lines          2016       2016
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            619        622     +3
+ Misses         1397       1394     -3
  Partials          0          0

Powered by Codecov. Last update 6889c1c...85de54c

@piv199 done!

@piv199 what do you think?


WIP: Initial Prometheus Metrics Endpoint

Description
I've added an initial metrics endpoint using Prometheus exporter to hook into Dapr's HTTP and gRPC pipeline. Due to the incompatibility between fasthttp and net/http this is a bit more messy than I'd like.
This is built on the existing work in #950
Issue reference
Please reference the issue this PR will close:  #959
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation
[ ] Specification has been updated
[ ] Provided sample for the feature

/ok-to-test

LGTM overall.

@jjcollinge I upgraded components-contrib to the latest. Please fix the conflicts.

/ok-to-test

@jjcollinge are you ready to merge it?

shortly, just want to resolve the outstanding comments. Are you happy with the current labels?
grpc: {grpc_code="Aborted",grpc_method="CallActor",grpc_service="daprinternal.DaprInternal",grpc_type="unary",instance="nodeapp-dapr.dapr-system.svc.cluster.local:5000",job="dapr"}
http:
{host="localhost:3500",instance="nodeapp-dapr.dapr-system.svc.cluster.local:5000",job="dapr",method="POST",name="daprd",path="/v1.0/state/statestore",status="200"}

shortly, just want to resolve the outstanding comments. Are you happy with the current labels?
grpc: {grpc_code="Aborted",grpc_method="CallActor",grpc_service="daprinternal.DaprInternal",grpc_type="unary",instance="nodeapp-dapr.dapr-system.svc.cluster.local:5000",job="dapr"}
http:
{host="localhost:3500",instance="nodeapp-dapr.dapr-system.svc.cluster.local:5000",job="dapr",method="POST",name="daprd",path="/v1.0/state/statestore",status="200"}

Looks good to me. as long as we filter or aggregate metrics by job="dapr", I believe we would not need prefix.

Ok, CLI issue opened: https://github.com/dapr/cli/issues/275 - think we're ok to merge

/ok-to-test


BillableStatus defaults to empty string in JournalEntryLineDetail

See: https://github.com/sidecars/python-quickbooks/blob/b25449332e0f8bd80479d5e8aca9fb2b3f6b3350/quickbooks/objects/journalentry.py#L34
(Tested at: https://github.com/sidecars/python-quickbooks/blob/b25449332e0f8bd80479d5e8aca9fb2b3f6b3350/tests/unit/objects/test_journalentry.py#L37)
Similar issue to https://github.com/sidecars/python-quickbooks/issues/133.   If BillableStatus is left as an empty string, the API will throw a ValidationError (since that's not a valid value for BillableStatus).

You are correct. If you would like to submit a PR, I will merge it in soon.

Thank you!  Submitted: https://github.com/sidecars/python-quickbooks/pull/161


PDI-15681- Fixed removing row when parsing a null field

Fixed removing row when parsing a null field using JSON Input step. Now if the json field is null and the row has another input fields then Json Input step wont skip the row and will set the missed value to null

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-json-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/kettle-json-plugin/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  plugins/kettle-json-plugin/src/org/pentaho/di/trans/steps/jsoninput/JsonInput.java
  plugins/kettle-json-plugin/test-src/org/pentaho/di/trans/steps/jsoninput/JsonInputTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.jsoninput.JsonInput

Branch Change:  + 4.11%
Complexity Change:  + 3.56%
Instruction Change:  + 1.39%
Line Change:  + .52%


[REMOVAL] Consider removing or further discourage the use of Authy

Title
Authy
Removal Reason
Reasons already stated:

Authy is proprietary
Increased attack surface due to cloud sync

Further developments:

Authy already has been hacked, leaking user data (August 2022)
Vendor lock-in: a complete lack of export features, even though there used to be a way (https://gist.github.com/gboudreau/94bb0c11a6209c82418d01a59d958c93) and the risk of completely getting yourself locked out of your accounts if you delete your Authy account: https://gist.github.com/gboudreau/94bb0c11a6209c82418d01a59d958c93?permalink_comment_id=4829538#gistcomment-4829538
The discontinuation of their desktop solutions (March 19), even earlier than previously announced (August)
Uncertain future of the company: several rounds of significant amounts of layoffs have been seen over the last few years

Association Disclosure
None
Would you like to submit a PR?
No.
Please tick the boxes

[X] You have filled out this form accurately, and to the best of your knowledge
[X] You have indicated whether or not you are associated with this project or a competitor
[X] A similar submission has not already been opened for this software/ service
[X] You agree to the code of conduct

Thanks @ltguillaume :)


Bootstrap V4-Alpha Support

Basically just added the new V4 classes "dropdown-link" and "dropdown-item" and the "hidden" attribute to the dropdown HTML to add proper Bootstrap 4 styling.

Bonjour! Is the fabulous bootstrap-select ready to make its debut to Bootstrap v4 Alpha yet?
Thank you

+1 for the v4 compatible version of bootstrap-select
Any release plan please
Thanks in advance

Bootstrap 4 support has been added as a part of v1.13.0-beta, available here: https://github.com/snapappointments/bootstrap-select/releases/tag/v1.13.0-beta. Please post any issues in that repo from now on.

Bootstrap 4 support has officially been added in v1.13.0!


Fix/node rewritten soure with multi line array

Hi
issue #4
I decided to edit Node#rewirtten_source.
Now, it will detect whether arguments have multiple lines or not by count of lines.
Review?

@rail44 I didn't have time to fix #4, thanks for contributing.

@flyerhzm Thank you for merging!


Strong typed events

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Problem with devcontainer.json

devcontainer.json does not build in JetBrains IDE 2024.1 and VSCode.
JetBrains IDE Welcome screen -> DevContainers -> New DevContainer (from VCS Project, Docker must be installed.) Insert the git@ link of the repository with devcontainer.json. -> "Build container and Continue"

I apologize for the delay in reviewing this issue.
I'm in the process of a code rewrite for this repository, and the process will be some time...sorry.


exec.Command security

I think it's vulnerable, I need to check it later.

2c6f822
I was unable to create a PoC. I don't think this fix prevents anything.
(The nested for-s are ugly)


Data loader directly use loaded state dict when save right after load

Summary: If no iterator is created in the middle of load_state_dict and state_dict calls, we should be able to directly return the original state dict without triggering reading service because the states are unchanged
Reviewed By: xunnanxu
Differential Revision: D54102267

PR already merged in the main branch - https://github.com/pytorch/data/commit/39b3497517d5850c600c6b18e73cf5a346a539bf


Rewrite Deque

Move toward more use-case-driven docs, probably!

Hi @0xFable! Most of Confio devs are currently working on this new docs portal, and we're using these tickets to organize our work. We were going to tackle this one soon. Are you trying to submit your proposal here?

Hey all, I see one piece of feedback left on vercel but I cannot see what it is, could you add me to the team on vercel or add the comment elsewhere ?

The feedback is from @hashedone that the links don't render right.

Did you manage to get a live preview of the docs with npm run dev? You can run it locally!


Wait for the tunnels connected before executing the query

What problem does this PR solve?
Issue Number: close #7611
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-unit-test

/rebuild

/run-all-tests

/run-integration-test

After discussion, there may be an impact on performance


ignore enumeration order when comparing maps or sets in R.equals

Thank you for bringing this to my attention, @jdalton!

This sounds awfully familiar.  :+1:

Thinking about it again, I'm really not thrilled with a toString implementation of this.  I wonder, given how heavyweight toString has to be, whether an implementation based on bi-directional tests of otherSet.has(nextEltOfThisSet) would be horribly slower.  Or, I suppose for value equality, perhaps using containsWith(equals) on the iterable output of the Set.

Would you like to take a crack at an alternative implementation, @CrossEye?

@davidchambers
I've sketched one out in another thread:

The algorithm is simple and will perform much better than what this PR does.

Compare size of set. If not equal, the sets are not equal.

Iterate over each element in first set while checking for presence in other set with Set.prototype.has. If an item is missing the sets are not equal. Otherwise they are.

Yes, if nobody beats me to it, I'll get to this in a few days, either as Simon says with Set.prototype.has or using containsWith(equals).
Even though Simon had pointed out our earlier, I missed the fact that this doesn't have to be symmetric.   A length comparison captures half the test.

Yes, if nobody beats me to it, I'll get to this in a few days

:+1:

or using containsWith(equals).

Unless I'm mistaking something that would be an n^2 algorithm at it would still not satisfy R.equals(set1, set2) === true -> set1.has(x) === set2.has(x).
My proposal should be n*log(n) and would satisfy the above property.

The question is whether to use value-based equality, as we do for other data types, or the identity-based equality of the set itself.
Choosing identity-based equality would lead to an interesting contradiction:
> R.equals(new Set([]), new Set([]))
true
> R.equals(new Set([new Set([])]), new Set([new Set([])]))
false

We'd be comparing the container by value, but its contents by identity. Two empty containers would be equal, but two sets each containing one (non-identical) empty container would not be equal.
Value-based equality is more internally consistent. It is, though, inconsistent with built-in methods such as Set.prototype.has. This isn't necessarily a problem. After all, value-based equality is also inconsistent with Array.prototype.indexOf. We address this issue by providing R.indexOf and R.contains. We could update the latter to operate on sets as well.
The one remaining problem is that a value such as new Set([{}, {}]) makes no sense in the presence of value-based equality. This suggests we should provide functions for creating sets, and for deriving sets from other sets.

@davidchambers:
You beat me to it by minutes.  I was going to note that
var s = new Set([{a: 1}, {a: 1}]);
arrayFromIterator(s.values()).length; //=> 2

And this would make it difficult to do value-based equality directly.  If we're going to interact with native sets, we might have nothing better than dealing with identity equality, using has.

@paldepind:

Unless I'm mistaking something that would be an n^2 algorithm at it would still not satisfy R.equals(set1, set2) === true -> set1.has(x) === set2.has(x)

I was thinking that's what we would want, that has was too strong.  But I believe I'm coming around to your view on this.  I'm struggling a bit though, and would like to hear more of David's ideas of providing "functions for creating sets, and for deriving sets from other sets."

Here's a rough outline of what I have in mind:
> R.createSet([1, 2, 3, 1, 2, 3])
new Set([1, 2, 3])
> R.createSet([{}, {}])
new Set([{}])
> R.union(R.createSet([1, {}]), R.createSet([2, {}]))
new Set([1, 2, {}])

This is a problem, though:
> new Set([0, -0]).size
1

It looks like I need to create my own Set type!

@davidchambers

We address this issue by providing R.indexOf and R.contains. We could update the latter to operate on sets as well.

I discuss that here. Note this in particular:

And we have no way to redefine Set.prototype.has because then we lose the performance benefit and the entire reason for using Sets in the first place.

It looks like I need to create my own Set type!

Exactly. But then you wont get the performance benefits that native sets has.

@davidchambers:

It looks like I need to create my own Set type!

Yes, that's what worries me about any attempts at value-equality.
Think also:
var s  = R.createSet([{}, {}]); //=> new Set([{}])
s.add({})
arrayFromIterator(s.values()).length; //=> 2

So we'd need to override add as well...

Rather than s.add({}) one could write s = R.union(s, R.createSet([{}])).

Rather than s.add({}) one could write s = R.union(s, R.createSet([{}])).

Right.  But then essentially we're not using native sets at all except as backing stores.  That's not necessarily a bad thing.  It certainly fits with our ideas of immutability.  But it begs the question of how we deal with Sets not created through such calls.  It's difficult to say we simply ignore them.  But we really do want to be dealing with value equality as best we can, and these are not going to make it easy.  They may well make it impossible.  As @paldepind pointed out, at the very least they will make it less performant.

Value-based equality doesn't seem viable for the built-in Set type. I look forward to seeing an implementation of the alternative approach.

Well my (not-so-good-)idea was for an attempt to maintain value equality.  I think we're left with the approach Simon presented.  That should be quite simple to implement.

So y'all are cool with:
equals(new Set([{a:1}]), new Set([{a:1}])); // false

?

@jdalton: No, and I'm still trying to figure out a good answer to that.
I'm not sure there is a good answer.  We can deal with that case in a fairly straightforward manner, but it would likely give us an odd answer to
equals(new Set([{a:1}]), new Set([{a:1}, {a:1}]));

The problem is to even figure out what answer we would want from that second one.  As native Sets, we have a two-element Set compared to a one-element one, and hence should be unequal..  As value-based Sets, they should each only contain a single element, and hence should be equal.
This is one of the first times where I'm feeling that the language may leave us no good way to respond.

This is one of the first times where I'm feeling that the language may leave us no good way to respond.

I'm currently treating maps and sets as wrappers around the values so I dig in and perform and unordered comparison on them. My isEqual method is a loose equivalence method and not the single source or comparison truth in the lib though.

Since we're going to try a different approach, I'll close this pull request.

Yes, if nobody beats me to it, I'll get to this in a few days,

Someone beat me to it, or at least to something closely related: #1374.


Publish a devcontainer template for Meltano projects

Background
VS Code supports Dev Container Templates which are pre-designed devcontainer definitions tuned to work with specific dev user cases. For example, there is a Python 3 devcontainer template and a Python 3 & PostgreSQL template officially supported by Microsoft/GitHub. There is also the ability for anyone to publish a community template which would populate into the list below:

Each of these templates can also request inputs from the developer when the devcontainer is created - for instance prompting for a preferred python version or asking if certain optional components should be installed.
Proposal
It could be very helpful to the Meltano community if we published a "Meltano Project" or "Meltano Data Project" which would then be discoverable in this list.
UX for existing Meltano users
Once published, Meltano users could follow the below instructions to setup dev containers for their own project:

From VS Code, add the Dev Containers extension if not already installed.
From the command pallete select "Dev Containers: Add Configuration Files". Type 'meltano' in the list to filter to our image and select it from the drop down.
Answer any prompts or accept the defaults. For example, the desired Python version, the desired Meltano version, and maybe a true/false on whether they want optional components like Postgres pre-installed.
Commit the result back to the repo.
Once complete, the user will be able to launch their Meltano project in a dedicated container, which is compatible with local development as well as cloud development experiences (Codespaces and similar).

Challenges / Caveats
Overall scope
On the face of it, this seems like a quick win. Admittedly though, we don't know what we don't know - so it could get more difficult than expected.
The authorship process itself seems pretty straightforward. There are quickstart examples for template (link below), which we could probably combine with Devcontainer examples we already have 'in the wild' which could be copy-pasted for the initial template version.
Publishing those dev container definitions also seems straightforward. They ask that you edit their Collections Index yaml file (linked below) to add yourself - similar to how we publish/maintain our JSON Schema definitions on schemastore.org.
Templates vs Features
These two concepts have interesting interplay, and it's helpful to keep both in mind as separate concepts:
Dev container templates allow anyone to add Devcontainer support to their new project in a streamlined manner. After using the template, the user has full control over any changes they want to make, and there is no long-term or "Day 2" dependency on that template.
Dev container features provide capabilities to any compatible Devcontainer definition. So, for instance, popular features allow anyone to add Go/Python/PowerShell/Git and other capabilities directly to their dev container experience without managing the lifecycle of those installation and configuration scripts. Consuming the feature is as simple as giving the feature URI in your devcontainer.json and adding any option config.
Templates and Features are in no way mutually exclusive - for instance the "Python 3" devcontainer template references the Python feature. Templates and features are published to the 'collection index' (link below) using the same method, which makes them discoverable to users on supporting IDEs. Here are the full listings of both:

Available Features
Available Templates

Regarding other IDEs
The above instructions give bias to VS Code because that is what I tested with, but my understanding is that other IDEs are also planning to support dev containers and dev container templates.
Related Links

https://github.com/meltano/sdk/issues/1207
https://containers.dev/implementors/templates/
Collections Index where we would want to be added.
Yaml file to edit (via PR) to add our own Collection to the index.
Template quickstart repository

@tayloramurphy There exists a community contributed Meltano dev-container, which we've used for a few things:
https://github.com/devcontainers-contrib/features/tree/main/src/meltano
We can make changes to it via PRs in that repository. As such I think this issue can be closed.

Ah nevermind, I missed a key part in this issue:

Dev container templates allow anyone to add Devcontainer support to their new project in a streamlined manner. After using the template, the user has full control over any changes they want to make, and there is no long-term or "Day 2" dependency on that template.
Dev container features provide capabilities to any compatible Devcontainer definition. So, for instance, popular features allow anyone to add Go/Python/PowerShell/Git and other capabilities directly to their dev container experience without managing the lifecycle of those installation and configuration scripts. Consuming the feature is as simple as giving the feature URI in your devcontainer.json and adding any option config.
Templates and Features are in no way mutually exclusive - for instance the "Python 3" devcontainer template references the Python feature. Templates and features are published to the 'collection index' (link below) using the same method, which makes them discoverable to users on supporting IDEs.


Avoid including an unexpected doctype in result

Fix the issue #4, using the following suggestion : https://github.com/bluetel/twig-truncate-extension/pull/3#issuecomment-379131633.
Requires PHP 5.4.0 or more.

Since PHP 5.4.0 and Libxml 2.6.0, you may also use the options parameter
— Source

Can we merge this?

Sorry for the late response on this one. Have been meaning to get this tested and merged in to the main line for a while but have since never had a chance. Will try to get this properly reviewed and tested later this week 👍


Add brackets around HMM_MIN, HMM_MAX, and HMM_MOD

I ran into an issue with operator precedence weirdness with the HMM_MIN and HMM_MAX macros. So I added brackets around them to solve those issues.

Added brackets around HMM_MOD, while we're here

Good catch, thanks for the fix!


Implement character attributes/stats

Ranging from the basics:

Health
Energy
Movement Range

To combat-focused:

Strength
Agility
Skill
Tech

Also need to think about races/classes for the characters.

To elaborate on some of the core concepts of the gameplay attributes for characters:
Character Combat Attributes
Base attributes that influence more complex aggregate attributes. Not all influences of these skills are listed here, continued development may change this.
Power / Might: [PWR / MHT / MGT]
Physical might and hardiness.
Influences:

Physical Attack Damage
Physical Hardiness / Damage Resistance
Equipment Load Maximum (should this mechanic be added)

Reflexes/Skill: [REF / SKL]
Reaction time, speed and efficacy with complex weapons.
Influences:

Ranged Attack Damage
Overall Physical/Ranged Hit Chance
Overall Dodge Chance
Movement Range(?)

Expertise / Proficiency / (other?) [EPT / PRF / ?]
Proficiency and knowledge of technological arts and abilities
Influences:

Tech Ability / Attack Damage Values
Tech Damage Resistance
Increases effect of Tech-based items (?)

Character Aggregate Attributes
These are typically influenced by many different sources and represent certain holistic attributes.
Health: [HLT / ?]
Life-points of the character, when this reaches zero, the character dies
Influenced by:

Power
Equipment
Items (temporary / permanent)

Energy: [ENG / EGY / ENY]
Energy capacity of the character, starts each battle at set level, and recharges throughout battle (environment can influence recharge/discharge rate)
Influenced by:

Tech
Equipment
Items (temporary / permanent)

Armor: [ARM]
Physical hardiness, used as a modifier on physical attack damage.
Influenced by:

Power
Equipment
Items (temporary)

Field: [FLD]
Tech defense value, used as a modifier on tech attack damage.
Influenced by:

Expertise / Proficiency / (other?)
Equipment
Items (temporary)

Physical Dodge / Hit Chance [PCH]
Physical dodge and hit chances, used as part of the dice roll when determining if an attack lands. Is a pair of values rather than a single one, so asymmetric builds are possible (e.g. a caster character could have super high physical dodge but almost non-existent physical hit).
Influenced by:

Reflexes / Skill
Stealth
Equipment
Items (temporary)

Tech Dodge / Hit Chance [TCH]
Tech dodge and hit chances, used as part of the dice roll when determining if an attack lands. Is a pair of values rather than a single one, so asymmetric builds are possible (e.g. tank character has high tech dodge and low tech hit).
Influenced by:

Expertise / Proficiency / (other?)
Stealth (?)
Equipment
Items (temporary)

Stealth [STH]
Overall stealth of the character, influences other aggregate attributes. Has a fixed base value from equipment/class, but can increase/decrease depending on map position and item use.
Influenced by:

Map position / Tile type
Equipment
Items (temporary)
Character Class

Jump Type [JMP]
Capability of a character to jump when moving.
Influenced by:

Character Class
Equipment

Movement Range [MOV]
Distance that a character can move in a single turn
Influenced by:

Terrain traveled
Character Class
Equipment
Items (temporary)


Can't update Label text inside Event ( button.ButtonSig.Connect )

Hi, im trying to simply update the label's text to Updated Text when clicking the given button. But nothing happens.
Is this a bug or am i missing something ?
This is my codebase:

import (
	"fmt"
	"github.com/goki/gi"
	"github.com/goki/gi/gimain"
	"github.com/goki/gi/oswin"
	"github.com/goki/ki"
)

func main() {
	gimain.Main(func() {
		mainrun()
	})
}

func mainrun() {
	width := 1024
	height := 768
	win := gi.NewWindow2D("gogi-basic", "Basic Test Window", width, height, true)

	vp := win.WinViewport2D()
	updt := vp.UpdateStart()

	mfr := win.SetMainFrame()

	rlay := mfr.AddNewChild(gi.KiT_Layout, "rowlay").(*gi.Layout)
	rlay.Lay = gi.LayoutHoriz
	rlay.SetProp("text-align", "center")

	rec := ki.Node{}
	rec.InitName(&rec, "rec")

	button1 := rlay.AddNewChild(gi.KiT_Button, "button1").(*gi.Button)
	button1.Text = "Update Label Text"

	displayLabel := rlay.AddNewChild(gi.KiT_Label, "label1").(*gi.Label)
	displayLabel.Text = "init Text"

	button1.ButtonSig.Connect(rec.This, func(recv, send ki.Ki, sig int64, data interface{}) {
		if sig == int64(gi.ButtonClicked) {
			displayLabel.SetText("Updated Text")
			fmt.Println("Updated label Text")
		}
	})

	appnm := oswin.TheApp.Name()
	mmen := win.MainMenu
	mmen.ConfigMenus([]string{appnm, "Edit", "Window"})

	amen := win.MainMenu.KnownChildByName(appnm, 0).(*gi.Action)
	amen.Menu = make(gi.Menu, 0, 10)
	amen.Menu.AddAppMenu(win)

	emen := win.MainMenu.KnownChildByName("Edit", 1).(*gi.Action)
	emen.Menu = make(gi.Menu, 0, 10)
	emen.Menu.AddCopyCutPaste(win)

	win.OSWin.SetCloseCleanFunc(func(w oswin.Window) {
		go oswin.TheApp.Quit()
	})

	win.MainMenuUpdated()

	vp.UpdateEndNoSig(updt)

	win.StartEventLoop()
}```

Cheers

use SetTextAction instead of SetText -- most "Set" methods have an "Action" version that triggers updating and sending of signals. In this case, all it does is call UpdateSig on the label which is the general way to trigger updating of something.

actually now that I look at this again, SetText should definitely be wrapped in UpdateStart / UpdateEnd and you should not need to call the Action version -- the Action version is only for sending signals, not for triggering updates.  I'm fixing this right now, so don't change your code!

Thank you @rcoreilly

I just tried to use SetTextAction(txt), it updates the label but does not delete it's old state, the same behavior happens when using
label.SetText(txt) label.UpdateSig()
I tried to find the bug, but unfortunately im not that familiar with the codebase.

add:	displayLabel.Redrawable = true
labels are transparent by default and write over top of themselves.  this flag sets them to draw a background to overwrite..

assuming all good? reopen if not.


strums dont show up

I'm trying to port 6 and 9k to og psych engine and the strums dont show up the only strum that shows up is the left one

i feel like thats an issue for shadowmario/psych-engine


typeof with an open generic type with 2 type params

typeof with an open generic type with 2 type params
Fixes #11257

Thanks, @BillWagner. Very good suggestion.

Closing and reopening to trigger new CLA check.


Add Plan.max_collaborators_per_project to control the maximum premium collaborators per project

Task linked: QF-2019 Add configuration how many collaborations per private project are enabled per subscription plan

Task linked: QF-2023 Add max organization members configuration


fix(controller): force uniqueness for default app name.

Fixes #2831

code LGTM. Another question would be how we're gonna handle this problem when we theoretically use up at least half of the available app names since we're more or less going to come up with name collisions fairly often.

Another question would be how we're gonna handle this problem when we theoretically use up at least half of the available app names

Yeah, that could start to cause problems. Luckally I don't think too many people have a significant number of apps with random names. Worst case scenario we can add more weird adjectives and nouns ( or the generate name algorithm can be rewriten to limit itself to selecting names that already exist, but that's much less fun)! :smiling_imp:

The CI seems to have timed out. Could somebody please restart it?

This doesn't solve the problem of "diminishing randomly-generated app namespace", but it avoids the occasional collision which I think is of higher concern.
I think it might be cleaner to have select_app_name implemented in models.py itself. The utils.py module was blissfully unaware of all the Django machinery until it imported the api module.

I think it might be cleaner to have select_app_name implemented in models.py itself. The utils.py module was blissfully unaware of all the Django machinery until it imported the api module.

I agree. If we're using the models anyways, we should move it over there.

I moved the function to models.py but the tests timed out again.

but the tests timed out again.

Not your PR - we're looking into an issue caused by leftover cruft.

Code LGTM and Jenkins has passed.

Code LGTM.

If we're using the models anyways, we should move it over there.

this is something we can clean up after we merge this :)

this is something we can clean up after we merge this :)

He already did it in this PR?

Oh! I meant by attaching it to the App model rather than as a standalone function. Not really a huge issue, just nitpicking.


crash

crash.txt
config.ini.txt
hotkeys.ini.txt
pens.ini.txt
@pubpub-zz

Hi @leo6686,
Thanks for the report
Some fixes have been implemented since. Can you try to with the latest beta version
ppInk64_RestWidth06a.zip
Can you also tell me if you found a scenario which is then creating the crash.

您好，您发给我的邮件已经收到，谢谢。
------------姚

@leo6686,
any update ? (in english please)

------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2022年3月28日(星期一) 凌晨3:26
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [pubpub-zz/ppInk] crash (Issue #182)
@leo6686,
any update ? (in english please)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@leo6686
your message is unreadable

Message ID: @.***>


Question about adapter in API Manager

Hi, to whom it may concern,
please, help me
I published two APIs (A1 and A2) in API Manager.
And my purpose now is creating adapter for this APIs.
I need to send one request to adapter API and in response get answers from A1 and A2 - combine response.
I try to find description of this solution in documentation, but it wasn't successful.
Is it possible to do this with Message Mediation xml-config?
If yes, could you please provide example of this case.
Or there is only way to implement adapter as common service and publish it to API Manager?
Thanks in advance

Hi @pubudu538,
Thanks for your answer.
I have one more question. Is there only one way to implement such adapter - through xml-config.
Is there any other variants?


How to modify column content on code side?

I want to set value to column on code. So i tried to modify related property's getter but no luck
xyzColumns.cs
`    [ColumnsScript("Tanimlamalar.PerIlce")]
    [BasedOnRow(typeof(Entities.PerIlceRow))]
    public class PerIlceColumns
    {
        [EditLink, DisplayName("Db.Shared.RecordId"), AlignRight]
        public Int32 Id { get; set; }

        [DisplayName("İl")]
        public string Il { get { return "İstanbul";} set {} }
        [DisplayName("İlçe")]
        [EditLink]
        public String IlceAdi { get; set; }

        [DisplayName("Belediye Adı")]
        public String BelediyeAdi { get; set; }
    }`

I realized that transfered data comes from sql query result directly to the grid. Even i put breakpoints, it didn't got to debug to any code that i can operate.

I also tried custom attribute on xyzRow.cs
        [ClientSide()]
        public String Test {
            get { return "İst"; }
            set { }
        }

nothing happened.
How can i solve this situation?

on dialog you can put this in constructor
if(this.isNew())
    this.form.Test.Value = "istanbul"

Hi, thank you for your reply.
I'm trying to customise value on grid. Your solution is related with dialog.

If database doesn't have İstanbul, why do you want to show İstanbul there? What you ask is something like a formatter. Anyway if you still want such a thing, override your MyListHandler OnReturn method, traverse response.Entities, and fill in values you would like to.

I just wanted to see how can i customize values so i put it static in this example.
I modified MyListHandler.OnReturn :
 private class MyListHandler : ListRequestHandler<MyRow> {             protected override void OnReturn()             {                 foreach (var row in Response.Entities)                     row.Il = IL.arrIL.GetEntityWithIndex("ID", row.ILID).ILAdi;                 base.OnReturn();             }         }
I have related properties on xyzRow.cs :
`[DisplayName("İl"), Column("ILID"), NotNull, QuickSearch, QuickFilter]
[LookupEditor(typeof(PerIlRow), InplaceAdd = true)]
public Int32? ILID
{
get { return Fields.ILID[this]; }
set
{
Fields.ILID[this] = value;
}
}
    private string m_il;
    [DisplayName("İl"), Column("Il")]
    public String Il
    {
        get { return m_il; }
        set { m_il = value; }
    }`

Also I have column on xyzColumns.cs:
        [DisplayName("İl")]         public string Il { get; set; }
This changes seems ok for me but i cannot see values on grid. How can i check returned json or what could be the solution?
Thanks for your help

You can see it in chrome dev tools (F12) xhr tab

I added LookupInclude and problem solved. It was good to learn xhr tab. Thanks a lot.


fix: css class name misleading when using css modules other than unocss

🐛 The bug
I started a new Nuxt project and installed the https://nuxt.com/modules/tailwindcss module, when adding css classes, the IDE sugguest me there is a w-100 class, then I added that class to an element but it does not works.
You can see the IDE found the .w-100 classes from devtools' entry.xxxxxxxx.css, but you cannot use it as tailwindcss dose not have such class:

🛠 To reproduce
https://github.com/DevDengChao/nuxt-devtools-css-class-name-misleading-bug-report
🌈 Expected behavior

Exclude that file from IDE suggestion index ? (Maybe I should tweak my IDE, asked as WEB-63569)
Generate proper css files to enhance IDE suggestion ?

ℹ Additional context
No response

I am not sure how your question related to Nuxt DevTools. Can you elaborate more?

Close as it is a bug of WebStrom .


refactor: rename ComponentConfig struct

Stack:

#3006 ⬅
#3004

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is


Output Runner will only run each unique command+args once

Prospective feature that would really help us, just putting it out there as a proposal.
Goes along with #421

This seems entirely reasonable to me! Could I have you add an e2e test to validate the behavior? Here is a preexisting output runner test that you can duplicate and extend to validate your new functionality.
Thanks so much for your contribution! This is a really good usability improvement

This seems entirely reasonable to me! Could I have you add an e2e test to validate the behavior? Here is a preexisting output runner test that you can duplicate and extend to validate your new functionality.

+1, not the most straightforward, but crafted a test to write words to the sentinel file based on requested commands. So we can test that each word was unique.

+1, not the most straightforward, but crafted a test to write words to the sentinel file based on requested commands. So we can test that each word was unique.

Thanks for doing that. Out of curiosity, do these pass on your box locally?

+1, not the most straightforward, but crafted a test to write words to the sentinel file based on requested commands. So we can test that each word was unique.

Thanks for doing that. Out of curiosity, do these pass on your box locally?

Shoot, it's still failing on buildkite. But yeah, they pass fine when I run bazel test //e2e/output_runner/.... I have another idea which shouldn't require a sentinel file in this manner, so let me give that a shot.

Ok, maybe it'll work now. I'd actually been using --test_filter to just run my test locally, and it was passing. It seems the issue is that the tests aren't actually hermetic, and the main-dir doesn't get reset between them (an assumption I'd made), so when running as the full suite, the defs.bzl file actually keeps the content put into it by TestOutputRunner (print("not it")). This is likely why it was breaking with the old mechanism as well: it wasn't actually getting the signal to run any commands when executing as a suite!
While I'm sure some form of ensuring the hermeticity would be preferred, I for now just made TestOutputRunner and this new test both overwrite defs.bzl with what they expect before they act.

While I'm sure some form of ensuring the hermeticity would be preferred, I for now just made TestOutputRunner and this new test both overwrite defs.bzl with what they expect before they act.

I believe splitting the test data into two sets of targets would provide you this flexibility and make the tests more hermetic. WDYT about that as a solution?

Friendly ping on this

Hah, sorry, crazy week (moving houses + work makes me forgetful)
I'll try and wrap this up this upcoming week!

No rush at all, just wanted to make sure I didn't scare you off 😁

Ok, so looking at the way TestMain works, I'd have to move some of the tests to a separate package I believe. It sets up the tests and then runs them all, and at the moment the helpers for setting up the directory are not available outside of the bazel_testing package.
So did you mean for me to fully create a separate suite?

Ok, so looking at the way TestMain works, I'd have to move some of the tests to a separate package I believe. It sets up the tests and then runs them all, and at the moment the helpers for setting up the directory are not available outside of the bazel_testing package.

If you don't think this is possible, then please don't do it. I'd rather have the feature in. My expectation was that you could do something like this:
const mainFiles = `
-- single/defs.bzl --
def fix_deps():
  print("runacommand")
-- single/BUILD --
load("//single:defs.bzl", "fix_deps")
fix_deps()
sh_binary(
  name = "test",
  srcs = ["test.sh"],
)
sh_binary(
  name = "overwrite",
  srcs = ["overwrite.sh"],
)
-- single/test.sh --
printf "action"
-- single/overwrite.sh --
printf "overwrite"
-- multiple/defs.bzl --
def fix_deps():
  print("runacommand")
  print("runacommand")
  print("runacommand")
  print("runacommand")
-- multiple/BUILD --
load("//:defs.bzl", "fix_deps")
fix_deps()
sh_binary(
  name = "test",
  srcs = ["test.sh"],
)
sh_binary(
  name = "overwrite",
  srcs = ["overwrite.sh"],
)
-- multiple/test.sh --
printf "action"
-- multiple/overwrite.sh --
printf "overwrite"
`

Then you could target //single:test and //multiple:test in the tests. Would that work?

facepalm
Yes! That works fine! Honestly for a minute when you said add targets I was thinking of the actual bazel e2e test call, not the inner generated rules.
And duh, just creating a second internal package should work I think.

Ok, updated :D


dropdown onChange callback fires before dd item changes

Docs say: on Change Is called after a dropdown value changes. Receives the name and value of selection and the active menu element
http://codepen.io/avalanche1/pen/GJyJZe
If you select any item, alert shows your previous dd value, while it should show newly selected value.
I understand that I can get text argument of onChange, but .dropdown('get text') sd work as well.

I think it makes sense to update text before.


Could the found optimizations be integrated to pnpm?

From the description, it looks like ultra works similarly to how pnpm woks. It creates a node_modules without symlinks but pnpm has also an option to create a flat node_modules (via using node-linker=hoisted). So I am curious what is the motivation to work on a new package manager instead of contributing to pnpm. And whether the found optimizations would work in pnpm as well.
Now I realized this should've probably been a discussion not an issue. Feel free to convert it.

Hello, first of all I want to clarify that Ultra is based a lot on PNPM, as you can see in how it works, when I was working on Ultra I used a lot the PNPM documentation to learn a lot of things.
About the question of why create a new package manager and not contribute to PNPM, is because the development of this was something casual, I didn't plan to release this until I started with the benchmarks.
As you can see in the README history I started this project to learn about package managers.
In the next few days I will try to take a closer look at the PNPM code and try to implement some of the improvements I have implemented in this project.
I'm going to turn this issue into a discussion in case anyone wants to add something.


Check texture dimension and warn when exporting for mobile/web platforms

Godot version:

3.x
OS/device including version:

iOS and Android
Issue description:

It would be better to check texture dimension for mobile when exporting.
Steps to reproduce:
Minimal reproduction project:

same work webbrowsers, Godot mipmap does not work in Web at all

Similar HTML5 problem: When the clipping plane is near infinite, nothing is rendered at all.

@LinuxUserGD Please create a separate issue about that :slightly_smiling_face:

You want to add "foolproof".
It is not right. Game developers must know the features of the platform.
If we add this feature, in the end, developers will complain about removing this restriction.

This makes me wonder if instead of warning on export, textures should be automatically downsized on export. You can already limit a texture's size without modifying the source data using the Size Limit import option, but this can't be done when targeting specific platforms only.


error on compile

hi
after adding antd-colorpicker as the example
i had an error
Failed to compile.
./node_modules/antd-colorpicker/node_modules/antd/es/form/Form.js
Attempted import error: 'useWatch' is not exported from 'rc-field-form'.
any clue ??

I cannot reproduce it. What steps did you make? Can you provide the code or reproduce it in Codesandbox for example?


Nice!

I am waiting for your good news, I believe this will be the best package on npm for markdown editor!

Thanks for your supporting! The package is keeping update! If you have some new ideas, please talk to me!

Good, I am thinking how to advertise this package so that more people can download and give you  feedbacks


Fix when checking person detection select result

I am out until February, so there will be a slight delay on this one. Thank you very much for implementing this!


change conf_file_path to /etc/varnish/varnish.params

conf_file_path should always be /etc/varnish/varnish.params in debian distros when using systemd

kind bump?


Add screenshot instead of a demo only

Hi,
The demo is crashed
Fatal error: Call to undefined function is_error() in /kunden/whyeye.org/webseiten/idleberg.com/demo/Bootstrap-Listr-2/listr-template.php on line 8
You should add screenshot instead of relying on demo only that can crash.

@tristanbes -- i understand your point and it is a valued one. The thing with Bootstrap-Listr is that a screenshot wouldn't do justice to the functionnalities of the 'app'. It's unfortunate that you got problem with the demo. Hopefully you got everything sorted.
After 22 days of writing this issue report;
DID YOU get the demo to work? If so, please reply here and close your issue.
@Idleberg: never had a problem with the demo myself but just in case, maybe you should add (for the demo only) this code in the index.php file
ini_set('display_errors', '0');

I was thinking about hosting a static HTML version on GitHub pages, because I agree, that screenshots don't do much justice.


Fix: camelCase instead of kebab-case for vue attributes

Prop Name Casing for vue:
https://vuejs.org/guide/components/props.html#prop-passing-details

I'm afraid I don't understand this one? As per the docs you linked:

Technically, you can also use camelCase when passing props to a child component (except in DOM templates). However, the convention is using kebab-case in all cases to align with HTML attributes:
<MyComponent greeting-message="hello" />

Seems the problem was not the camelCase but instead a misspelling of the attribute name. Will send another PR for that.
(Should be is-web-authn-supported instead of is-webauthn-supported)


Audit Frame is showing the Buy License Action as both a Debit and Credit

The Audit Frame is improperly showing the "Buy License Action" incorrectly with the Cost of purchase ($50) and both a Debit and A Credit
The Remote Clients are not showing the correct Cash for the Corporations after the Purchase

Identified the 'Add License Effect' extended the 'Cash Transfer Effect' which caused this to get the debit/credit, and the 'Cash Transfer Effect' (as a separate Effect) did the same.
Modified this to just extend the 'ToEffect'.
This prevents the Audit Frame from double-reporting.
This will also prevent remote clients from double-applying the Effect for two Cash Transfer Effects


update-2.9.1

Checklist before submitting

[X] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes # (issue).
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

Remote feedstock added


Doc types with "Allow varying by culture" do not save.

I had an issue with the doc type editor not saving content if "Allow varying by culture" on the property. I doubt this value would have any effect inside a grid, so i don't think it should be supported. But could be useful information in the documentation.

Thanks for reporting this, you are right, it does seem like the value isn't saved.
I have marked this as a bug, that needs to be fixed :)

I think that dtge should only allow doctypes which has "Allow varying by culture" set to false. We already have variation covered on editor level?

Sounds like a good solution to this. Maybe we need some way of telling the user, that the document type selected (if in single type mode) can't be used, because its not an element or is varying by culture :)

Fixed in f5453dbddcf42fc4a87e4a8de8b40023f43ca5c5