state handling not working using @headlessui/react via preact/compat

I'm trying to use preact/compat to leverage @headlessui/react, but running into
In the "imports" of my deno.json I have
    "@headlessui/react": "https://esm.sh/@headlessui/react@1.7.17?alias=react:preact/compat,react-dom:preact/compat<EMAIL_ADDRESS>    "react"<EMAIL_ADDRESS>
The input renders, and fires the callback, but something about the useState seems off as I see some minified property is not a function, as in the attached image.
Here is my implementation of the component within this repository featuring a minimal reproduction of the issue.
Thanks in advance!

Turns out this does work with a slight change to the import statement
https://github.com/hapaxlife/test-fresh-headless-ui/tree/main

The fix is a bit strange. I got it to work on my end by doing this:
  {
    "imports": {
-     "@headlessui/react": "https://esm.sh/@headlessui/react@1.7.17?alias=react:preact/compat,react-dom:preact/compat<EMAIL_ADDRESS>+     "@headlessui/react": "https://esm.sh/@headlessui/react@1.7.17?external=react,react-dom&alias=@types/react:preact/compat",
+     "react-dom"<EMAIL_ADDRESS>      "react"<EMAIL_ADDRESS>    }
  }

The fix is a bit strange. I got it to work on my end by doing this:
  {
    "imports": {
-     "@headlessui/react": "https://esm.sh/@headlessui/react@1.7.17?alias=react:preact/compat,react-dom:preact/compat<EMAIL_ADDRESS>+     "@headlessui/react": "https://esm.sh/@headlessui/react@1.7.17?external=react,react-dom&alias=@types/react:preact/compat",
+     "react-dom"<EMAIL_ADDRESS>      "react"<EMAIL_ADDRESS>    }
  }

if I change the version of @headlessui/react to the latest one, 2.0.3, I encounter the following error:
An error occurred during route handling or page rendering.
ReferenceError: document is not defined
    at _ (https://esm.sh/v135/@react-aria/utils@3.24.0/X-YS9AdHlwZXMvcmVhY3Q6cHJlYWN0L2NvbXBhdAplL3JlYWN0LHJlYWN0LWRvbQ/denonext/utils.mjs:2:1401)
    at we (https://esm.sh/v135/@react-aria/utils@3.24.0/X-YS9AdHlwZXMvcmVhY3Q6cHJlYWN0L2NvbXBhdAplL3JlYWN0LHJlYWN0LWRvbQ/denonext/utils.mjs:2:1449)
    at ee (https://esm.sh/v135/@react-aria/interactions@3.21.2/X-YS9AdHlwZXMvcmVhY3Q6cHJlYWN0L2NvbXBhdAplL3JlYWN0LHJlYWN0LWRvbQ/denonext/interactions.mjs:2:15601)
    at Ce (https://esm.sh/v135/@react-aria/interactions@3.21.2/X-YS9AdHlwZXMvcmVhY3Q6cHJlYWN0L2NvbXBhdAplL3JlYWN0LHJlYWN0LWRvbQ/denonext/interactions.mjs:2:17960)
    at V (https://esm.sh/v135/@react-aria/focus@3.17.0/X-YS9AdHlwZXMvcmVhY3Q6cHJlYWN0L2NvbXBhdAplL3JlYWN0LHJlYWN0LWRvbQ/denonext/focus.mjs:2:12169)
    at vl (https://esm.sh/v135/@headlessui/react@2.0.3/X-YS9AdHlwZXMvcmVhY3Q6cHJlYWN0L2NvbXBhdAplL3JlYWN0LHJlYWN0LWRvbQ/denonext/react.mjs:6:45501)
    at Object.t (https://esm.sh/stable/preact@10.21.0/denonext/compat.js:2:1545)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:3237)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:2543)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:5050)

Seeing preact-render-to-string in the traceback, I'd assume the component is rendered in a server context, even though it is defined as an island?
As a side note, how do I even debug such errors? I am lost as to where to put the breakpoint or add logging provided this kind of traceback.

See

https://github.com/denoland/fresh/issues/2480#issuecomment-2140904121
https://github.com/denoland/fresh/issues/2426#issuecomment-2142902156

Currently nothing new. The stacktrace suggests that react-aria is incorrectly determining if it's SRR-ing or not based on window variable, not the document variable.

preact-render-to-string in the traceback, I'd assume the component is rendered in a server context, even though it is defined as an island?

I went to close this tab, but figured I'd address this: islands are SSRed, then hydrated. Islands get rendered on both the server and the client. The bug is that react-aria thinks that it's being CSRed while on the server b/c Deno supplies a window global, so it gets confused. Deno 2 will fix this, but for now, the above comments provide workarounds.

Deno 2 will fix this

What would I use?
That does not work with Deno 2:
"@headlessui/react": "https://esm.sh/@headlessui/react@2.1.10?external=react,react-dom&alias=@types/react:preact/compat",
"react-dom"<EMAIL_ADDRESS>"react"<EMAIL_ADDRESS>

What error are you getting?

Here is the code. I did:

Start with denoland/merch
Upgrade to Tailwind (All works fine till now)
Add HeadlessUI and its deps to imports (Now 500)

https://github.com/perguth/denoland-merch

2.1.10

Did this work for you on Deno Deploy? In my project everything works perfectly fine when running from dev.ts, and also when I build and preview, which is supposed to mimic the prod environment but once I deploy to production I get the same error saying "ReferenceError: document is not defined" even though it builds without issues on Github Actions

Here is the code. I did:

Start with denoland/merch
Upgrade to Tailwind (All works fine till now)
Add HeadlessUI and its deps to imports (Now 500)

https://github.com/perguth/denoland-merch

(https://discord.com/channels/684898665143206084/991511118524715139/1296751674442125323)
Updates:

Just using one version of preact in the deps fixes the error.
But then actually using some HeadlessUI (denoland/merch@2e0d105) breaks it again:

Invalid type passed to createElement(): [object Object]
Error: Invalid type passed to createElement(): [object Object]
    at a.__b (https://esm.sh/stable/preact@10.22.0/denonext/debug.js:23:9)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:2611)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:2543)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:5050)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:2543)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:5050)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:5050)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:5050)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:2543)
    at m (https://esm.sh/v135/preact-render-to-string@6.3.1/X-ZS8q/denonext/preact-render-to-string.mjs:2:5050)

🎉 Got it to work with those imports:

  "imports": {
    "@/": "./",

    "$fresh/"<EMAIL_ADDRESS>    "preact"<EMAIL_ADDRESS>    "preact/"<EMAIL_ADDRESS>    "@preact/signals": "https://esm.sh/*<EMAIL_ADDRESS>    "@preact/signals-core": "https://esm.sh/*<EMAIL_ADDRESS>    "tailwindcss"<EMAIL_ADDRESS>    "$std/"<EMAIL_ADDRESS>    "swr": "https://esm.sh/v98/swr@1.3.0?alias=react:preact/compat&external=preact/compat",

    "@heroicons/react/24/outline": "https://esm.sh/@heroicons/react@2.1.5/24/outline?alias=react:preact/compat,react-dom:preact/compat&external=react,react-dom",
    "@headlessui/react": "https://esm.sh/@headlessui/react@2.1.10?alias=react:preact/compat,react-dom:preact/compat&external=react,react-dom",
    "@floating-ui/react": "https://esm.sh/@floating-ui/react@latest?alias=react:preact/compat,react-dom:preact/compat&external=react,react-dom",
    "@tanstack/react-virtual": "https://esm.sh/@tanstack/react-virtual@latest?alias=react:preact/compat,react-dom:preact/compat&external=react,react-dom",
    "@react-aria/interactions": "https://esm.sh/@react-aria/interactions@latest?alias=react:preact/compat,react-dom:preact/compat&external=react,react-dom",
    "@react-aria/focus": "https://esm.sh/@react-aria/focus@latest?alias=react:preact/compat,react-dom:preact/compat&external=react,react-dom",

    "preact/hooks"<EMAIL_ADDRESS>    "react"<EMAIL_ADDRESS>    "react-dom"<EMAIL_ADDRESS>  },

Did this work for you on Deno Deploy? In my project everything works perfectly fine when running from dev.ts, and also when I build and preview, which is supposed to mimic the prod environment but once I deploy to production I get the same error saying "ReferenceError: document is not defined" even though it builds without issues on Github Actions

Did this work for you on Deno Deploy? In my project everything works perfectly fine when running from dev.ts, and also when I build and preview, which is supposed to mimic the prod environment but once I deploy to production I get the same error saying "ReferenceError: document is not defined" even though it builds without issues on Github Actions

That's a different issue. This is about incorrect versions, while your previous comment, #2426 is about that issue. See my comment over there.
If you want to fix it, feel free to go tackle adobe/react-spectrum#6534 (at least thumbs it up).

Did this work for you on Deno Deploy? In my project everything works perfectly fine when running from dev.ts, and also when I build and preview, which is supposed to mimic the prod environment but once I deploy to production I get the same error saying "ReferenceError: document is not defined" even though it builds without issues on Github Actions

That's a different issue. This is about incorrect versions, while your previous comment, #2426 is about that issue. See my comment over there. If you want to fix it, feel free to go tackle adobe/react-spectrum#6534 (at least thumbs it up).

Thank you for this, it drove me nuts today. I was happy that I finally was able to run headlessui v2 with deno but it seems like some dependencies need to be patched to make it work

Thank you for this, it drove me nuts today. I was happy that I finally was able to run headlessui v2 with deno but it seems like some dependencies need to be patched to make it work with deno deploy

Yeah, it's pretty annoying. I'm still unsure why Deno Deploy doesn't support it. I think it's technically a separate runtime that reuses Deno's crates, and so it's probably not included to avoid breaking existing apps, but I'd sure wish they'd offer an option. Maybe I'll file an issue.

Thank you for this, it drove me nuts today. I was happy that I finally was able to run headlessui v2 with deno but it seems like some dependencies need to be patched to make it work with deno deploy

Yeah, it's pretty annoying. I'm still unsure why Deno Deploy doesn't support it. I think it's technically a separate runtime that reuses Deno's crates, and so it's probably not included to avoid breaking existing apps, but I'd sure wish they'd offer an option. Maybe I'll file an issue.

Was thinking something similar today. Deno build + preview has to mimic a prod environment (deno deploy in this case) afaik.
Made me wonder so I found this https://github.com/denoland/deploy_feedback/issues/764, that's the right answer here, they're not even using Deno v2 so I'm guessing that we'll have to wait a little bit more

Made me wonder so I found this denoland/deploy_feedback#764, that's the right answer here, they're not even using Deno v2 so I'm guessing that we'll have to wait a little bit more

Yeah, it's partially chagrining to be because they'd said it was ready, so I almost merged a PR to remove the compat layer. Always test with a production build running on real servers!
Also related: denoland/deploy_feedback#666.

Made me wonder so I found this denoland/deploy_feedback#764, that's the right answer here, they're not even using Deno v2 so I'm guessing that we'll have to wait a little bit more

Yeah, it's partially chagrining to be because they'd said it was ready, so I almost merged a PR to remove the compat layer. Always test with a production build running on real servers!
Also related: denoland/deploy_feedback#666.

True, thank god it was a personal project and not something critical, next time I'll trust but verify


More Plugin Methods

It would be nice to have the following methods added to the plugin interface:

Initialize - Some plugins require some initialization to be done before any patching occurs, would be nice to have this be its own method.
PostPatch - Some plugins are purely meant to notify users when the files are done being touched. Would be nice to have this method to more accurately be able to notify users.

I'm thinking about turning this into an issue to track something like 'Plugins v2'.
#8 will require a new / extended Plugin interface anyway and I haven't seen much use of Plugins outside of AT. With that, we can bundle AT-only with an improved interface.
It's a bit difficult to gauge because I haven't gotten much direct feedback and there isn't a community space with reach such as Discord to ask on.


specifying binarization method in python

Hello!
I'm trying to specify binarization methods and/or use all at once using demo.py as my starter template.
Here's the latest that I tried:
# Loop through all binarization algorithms
binarize_algos = [BERNSEN, NIBLACK, SAUVOLA, WOLF, NICK, SU, TRSINGH, BATAINEH, ISAUVOLA, WAN, GATOS]
for ba in binarize_algos:
    algo = doxapy.Binarization(doxapy.Binarization.Algorithms.ba)
    algo.initialize(grayscale_image)
    algo.to_binary(binary_image, {"window": 75, "k": 0.2}) # algorithm params are optional

    # Display our resulting image
    Image.fromarray(binary_image).show()

I also tried with the list's methods in quotes, mixed in with 3 or so variations on this line:
algo = doxapy.Binarization(doxapy.Binarization.Algorithms.ba)
(str(ba), for example, pluses (for both str(ba) and just ba like you see above)
Any idea what I'm doing wrong?

You can do something like this:
for ba in doxapy.Binarization.Algorithms.__members__.values():
    algo = doxapy.Binarization(ba)

An issue you may run into is that each algorithm needs to be tuned with its own set of parameters.
You can either omit the parameters, and stick with the library defaults, or you can create a dictionary that looks up the custom parameters in the loop for the algorithm.  I hope that helps!

You can do something like this:
for ba in doxapy.Binarization.Algorithms.__members__.values():
    algo = doxapy.Binarization(ba)

An issue you may run into is that each algorithm needs to be tuned with its own set of parameters.
You can either omit the parameters, and stick with the library defaults, or you can create a dictionary that looks up the custom parameters in the loop for the algorithm.  I hope that helps!


@eessex => Fixes caption re-sizing on mobile

Addresses: https://waffle.io/artsy/publishing/cards/5a062bef5304860102841aa7
Problem is that iPhone is resizing text that it thinks is too small --
https://blog.55minutes.com/2012/04/iphone-text-resizing/. This change prevents the text from growing. It also sets the viewport scale and adjust for mobile (disable zoom)
Note that this change affects main_layout/stylesheets/index.styl.

Ooh good catch!  I think we may want a different scale declaration for accessibility -- checking that out now.


Probably a bug with applying effects

Previously I used V11, and it was very convenient to use macro panel and drag here most commonly used effects from the whole list. I used buttons 0-9 to add and remove effects from tokens.
Pressing button caused an effect to be created on a token. Pressing it again caused an effect to be deleted from a token.
But after I updated to V12 it never works. If I try to apply an effect this token never has, there is a warning message, as an example:
Your controlled actor 'Commoner' does not have an Active Effect with name 'Invisible'.
The script in macro is: dnd5e.documents.macro.toggleEffect("Invisible")
How it possible to return previous behavior?
Everything works fine if you previously put such an effect manually on a token. But it takes a lot of time if we speak about common effects I have to use quickly.

This is a known "bug", and there isn't really anything I can do. It's because the dnd5e system also creates a macro when you drag an ActiveEffect onto the macro bar. In reality, two macros are being created; my macro and the dnd5e macro. The dnd5e macro is taking priority in the slot when dragging it in. You'll find both macros if you open the macro directory.

@DFreds Thank you for the answer.
I'm sorry, but can you tell me exactly when I should look for the correct macro code? I'm not sure that I understand correctly where this directory is located and what kind of files or/and data I have to look for.

Next to the hotbar is a little folder icon. Click that and you'll see all macros created for the world


Cannot include a per-view stylesheet

The Documentation states that it's possible to include a per-view resource, such as a stylesheet at: http://aurelia.io/docs.html#templating
However, when I attempt to do the same:
<link rel="stylesheet" href="/static/css/work.css" type="text/css">

<template>
    Other content here
</template>

I get:
ERROR [app-router] Error: Cannot read property 'querySelectorAll' of undefined
Error loading http://localhost:9000/dist/work/work-list.html!template-registry-entry
at TemplateRegistryEntry.setTemplate (http://localhost:9000/jspm_packages/github/aurelia/loader@0.9.0/aurelia-loader.js:38:38)
at http://localhost:9000/jspm_packages/github/aurelia/loader-default@0.10.0/aurelia-loader-default.js:22:15
at f (http://localhost:9000/jspm_packages/npm/core-js@0.9.18/client/shim.min.js:1415:56)
at http://localhost:9000/jspm_packages/npm/core-js@0.9.18/client/shim.min.js:1423:13
at b.exports (http://localhost:9000/jspm_packages/npm/core-js@0.9.18/client/shim.min.js:453:24)
at b.(anonymous function) (http://localhost:9000/jspm_packages/npm/core-js@0.9.18/client/shim.min.js:1625:11)
at Number.f (http://localhost:9000/jspm_packages/npm/core-js@0.9.18/client/shim.min.js:1596:24)
at q (http://localhost:9000/jspm_packages/npm/core-js@0.9.18/client/shim.min.js:1600:11)

I have verified that the path to the stylesheet is correct and its contents are loading as expected. What am I doing wrong?

Apologies! We missed that in our docs update. That link technique only works with HTML Imports loaded views, which are not the standard. Aurelia has a more powerful mechanism now. You can use our require element to bring in css, like this:
<template>
  <require from="my.css"></require>

  ...html here...
</template>

If you are targeting shadow dom, then you can scope that css to your component's shadow dom tree like this:
<template>
  <require from="my.css" as="scoped"></require>

  ...html here...
</template>

Thanks @EisenbergEffect. That works perfectly. Aside from a few hiccups, Aurelia is awesome and I'm really enjoying working with it.

Great to hear! Feel free to continue to expound on the hiccups here so that we can learn how to make things better for the future.

I can post this in a separate issue, but I had opened this question on Stack Overflow relating to setting the page title: http://stackoverflow.com/questions/32802219/appending-a-value-to-the-aurelia-router-config-title Any insight you could offer on that one would be super.

On that specific point, can you create an issue on the router repo? @bryanrsmith may have a solution for that, and if not, he may be able to add that to the queue for future features.

For cross-reference on the title issue: https://github.com/aurelia/router/issues/218

Makes sense. Thanks for adding that!

You're welcome. I would love to see this framework eclipse Angular :)

Sounds good to me :)

When you <require from="./login.css"></require> It seems it is not scoped to that template only, with or without as="scoped" . In all my tests it seems to be globally inserted. Is there a workaround, except inline styling on the html elements directly? :-)

That capability only works if your component is using native shadow dom or if the browser supports scoped styles.

Feature 'scoped' has removed from specifications. See https://caniuse.com/#feat=style-scoped
Would be interesting if there is a convenient way to have 'per-view stylesheets'... blz. let me know ;-)

@gbreeze I highly recommend that you look into CSS Modules.


RubyConft Portugal blog post

Co-written by @chriscarter90

Would be a good blog post to use the dual ownership PR that Charlie worked on: https://github.com/unboxed/ubxd_web_refresh/pull/230 when it's merged. Not that this should hold up this being merged!

:shipit:


Increasing PIP reliability even further, attempt to fix speed-up bug

It is also worth mentioning that fixing the speed-up bug is not working if:

Pausing the video manually before dismissing (although only happened to me once).
The device has been locked long enough for the app to stop running in the background, either after pausing the video manually or after it is finished (for some reason PIP will not dismiss itself when it's finished).


Leniency flag for cross compatibility

The program is strict in its parsing (and it should be) but can we have it to be lenient when we explicitly ask for it (e.g. using a flag or config)?
Usecase: SSH to some machine and there is markdown slides written in one of many other popular tools.
Concretely, I got the following error:
invalid presentation metadata: unknown field `marp`, expected one of `title`, `sub_title
`, `author`, `theme`, `options` at line 2 column 1

When attempting to read
---
marp: true
size: 16:9
layout: cover
invert: true
---

<!-- class: invert -->

# Discharges expected for today using LOS model
Jan 15th 2024

I'm would be happy with any behaviour, including rendering as-is, when encountering this, instead of crashing altogether. This would vastly increase the usability of the tool in edge-cases.
Thank you.

This is fixed in #190. You can now parse that example presentation using a config file like:
options:
    strict_front_matter_parsing: false
    # needed so that the `class: invert` command is ignored
    command_prefix: "presenterm:"


digdag on window; sh> doesn't work

Hi,
Is it possible for someone taking a look at my issue here?
https://stackoverflow.com/questions/66415245/digdag-shell-script-tasks-complete-instantaneously
To provide another example:
_export:
sh:
shell: ["powershell.exe"]
+setup:
sh>: step1.ps1
+finish:
echo>: finish ${session_time}
In step1.ps1, I just sleep for 5 seconds. But the second task starts immediately without waiting. I do not know what is wrong with my workflow. Could someone please adivse?
Thanks,
Sean

Hello, @seanxz1124

Have you ever tried the following? sh operator options
What digdag version are you using?

I saw a user can't work sh> operator with PowerShell properly using digdag 0.10.X. It worked 0.9.23. If you use digdag 0.10.X, could you try 0.9.23?
_export:
  sh:
    shell: ["powershell.exe", "-"]

+step1:
  sh>: step1.exe

+step2:
  sh>: step2.ps1
Next  Previous

Hello, @seanxz1124

Have you ever tried the following? sh operator options
What digdag version are you using?

I saw a user can't work sh> operator with PowerShell properly using digdag 0.10.X. It worked 0.9.23. If you use digdag 0.10.X, could you try 0.9.23?
_export:
  sh:
    shell: ["powershell.exe", "-"]

+step1:
  sh>: step1.exe

+step2:
  sh>: step2.ps1
Next  Previous

The example in documentation will crash: shell: ["powershell.exe", "-"]
I need change it to shell: ["powershell.exe"]
I'm running 0.10.0
How to download 0.9.23?
I downloaded the latest version by following this page: http://docs.digdag.io/getting_started.html
PowerShell -Command "& {[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::TLS12; mkdir -Force $env:USERPROFILE\bin; Invoke-WebRequest http://dl.digdag.io/digdag-latest.jar -OutFile $env:USERPROFILE\bin\digdag.bat}"

You can download the latest digdag from this page. digdag supports selfupdate command. but AFAIK, It doesn't work correctly on windows environment.
https://dl.bintray.com/digdag/maven/
First question answer.
Does your Python script exist status non-zero?
Digdag will fail if a command returns non-zero.

Thanks. I should not download the latest version, right? You suggested that I should try 0.9.23.
I modified my Python script (first task) to just raise ValueError, and the second task still runs immediately after the first task runs. So I think the problem is with sh>.

I downloaded 0.9.42 and it's working for me now.
Thanks!

Yes. 0.9.23  incorrect. 0.9.42 correct version number.
Could you write the detail the problem on (ex. sample script and stack trace) 0.10.0?


"Deploy failure" cucumber feature is failing

This may be due to a recent RuboCop auto-correction gone awry?
Feature: Deploy failure

mkdir -p config/deploy
mkdir -p lib/capistrano/tasks
  Background:                                          # features/deploy_failure.feature:3
    Given a test app with the default configuration    # features/step_definitions/setup.rb:1
    And a custom task that will simulate a failure     # features/step_definitions/setup.rb:46
      undefined local variable or method `test_file' for #<Object:0x007f867daf97f8>
      Did you mean?  test_file_exists (NameError)
      ./features/support/remote_command_helpers.rb:19:in `safely_remove_file'
      ./features/step_definitions/setup.rb:47:in `/^a custom task that will simulate a failure$/'
      features/deploy_failure.feature:5:in `And a custom task that will simulate a failure'
    And a custom task to run in the event of a failure # features/step_definitions/setup.rb:51
    And servers with the roles app and web             # features/step_definitions/setup.rb:5

I'm looking into this. It looks like it might be e7592dbf9dc61702d48913981e1c6dc27019905c.
diff --git a/features/support/remote_command_helpers.rb b/features/support/remote_command_helpers.rb
index 91420c1..bafdf56 100644
--- a/features/support/remote_command_helpers.rb
+++ b/features/support/remote_command_helpers.rb
@@ -17,8 +17,8 @@ module RemoteCommandHelpers

   def safely_remove_file(_path)
     run_vagrant_command("rm #{test_file}")
-  rescue
-    VagrantHelpers::VagrantSSHCommandError
+  rescue VagrantHelpers::VagrantSSHCommandError
+    nil
   end
 end

I'm playing with why this might be an issue.

Ah, so I didn't understand how the rescue modifier form worked…
Turns out that the argument to the rescue modifier is actually the return value upon rescue, not the error class being rescued.
To make sure blame is placed where it belongs, Rubocop autocorrect was actually right, and I thought they messed it up and made another manual change to "fix" it. Bah.
Fix in https://github.com/capistrano/capistrano/pull/1637

Fix merged. @mattbrictson could you confirm?
Thanks!

Confirmed! Tests now pass. :+1:


Implement PostAsync

Introducing IAmAnAsyncMessageStore and IAmAnAsyncMessageProducer;
Added constructors to CP for async message store and async message producer
Re-factored MessagingConfiguration and CommandProcessorBuilder to allow usage of async message store and async message produce via the fluent API
In addition made some test methods truly async to prevent future hard to find errors.

Thanks. We should probably use the Async Polly methods. I'll review everything else to check on it


Validation step with multiple dataloaders

🐛 Bug
I tried to follow the directions for using multiple validation loaders from here:
https://pytorch-lightning.readthedocs.io/en/0.4.9/LightningModule/RequiredTrainerInterface/#validation_step
When I do so, I get the following error:
/usr/local/lib/python3.6/dist-packages/pytorch_lightning/trainer/connectors/logger_connector.py in _log_on_evaluation_epoch_end_metrics(self, epoch_logs)
    184
    185             # track the metrics
--> 186             logger_metrics = reduced_epoch_metrics.get_epoch_log_metrics()
    187             pbar_metrics = reduced_epoch_metrics.get_epoch_pbar_metrics()
    188             self.logged_metrics.update(logger_metrics)

AttributeError: 'dict' object has no attribute 'get_epoch_log_metrics'

I'm guessing I'm missing something that I need to do, but if so, it would be great for the documentation to be expanded. Also, is there a complete example using multiple validation data loaders?
BoringModel reproduction
(Edited: updated to correct link ~ with stable pip version of pytorch-lightning)
https://colab.research.google.com/drive/1K1BHSWkS2xT0hahopSeZ0r81QMG4X1ti?usp=sharing
To Reproduce
In addition to the BoringModel, you can also reproduce in image_classifier example easily:
can  add "dataloader_idx" to validation_step and then make a list of val_loaders (for example, [val_loader, val_loader]) when calling fit.
Expected behavior
Run validation on each dataloader, logging result for each one.
Environment

CUDA:

GPU:

Tesla P100-PCIE-16GB

available:         True
version:           10.1

Packages:

numpy:             1.18.5
pyTorch_debug:     True
pyTorch_version:   1.7.0+cu101
pytorch-lightning: 1.0.6
tqdm:              4.41.1

System:

OS:                Linux
architecture:

64bit

processor:         x86_64
python:            3.6.9
version:           #1 SMP Thu Jul 23 08:00:38 PDT 2020

was fixed here: https://github.com/PyTorchLightning/pytorch-lightning/pull/4480
can you try master?

It looks like it works after updating to master: https://colab.research.google.com/drive/1xjRGw9tVcCB587UpZsQ2Y2fSf8k_lxxV?usp=sharing
Thanks!


Error 403: The caller does not have permission, forbidden`

error is googleapi: Error 403: The caller does not have permission, forbidden when calling iam api, while I am owner of the project.
https://github.com/hashicorp/terraform/issues/13109#issuecomment-297719601

Same here, GCP permissions are simply defective.


Add metrics to the home page

Per user feedback (see below), we will investigate adding metrics to the Home Page.
We can start with our current set of past challenges.
Organizer Feedback
"So the first thing that I would, I would want to see as I'm seeing that page right now is somewhere indicating the community engagement of this challenge. How many challenges are currently listed in our inventory? How many users are there? How many participants do they follow that? It could be something as simple as underneath the register button with white font on top of the green color mentioning, you know, we're currently have exactly over there. We currently have a list of X challenges, you know, a thousand or 120 challenges we have in our community, 10,000 participants. We have 10 organizers. So what is, so that will show me immediately the level of engagement from the community, with this, with this platform, with this inventory."
Tasks:

[ ] Backend - @tschaffter
[ ] Frontend - @vpchung

Assigned to @tschaffter. Including @vpchung due to the Home page dependency on this.

Implementation:

[ ] https://github.com/Sage-Bionetworks/rocc-schemas/pull/202
[ ] Service TBA
[ ] DB client TBA
[ ] Client for Angular TBA
[ ] App TBA

The new path /registry provides the following metrics about the registry:

number of challenges
number of users
number of organizations

This change is implemented at the server level. I'll update the client shortly. I'll update the client shortly and display this numbers on the home page.


Update index.md

Broken link. The new link is the closest one I could find.

Thanks. But this doesn't have AccountContract, it should be account/contract.ts


[FEATURE] Remove dependency on terraform-aws-eks

Is your feature request related to a problem? Please describe
The use of the terraform-aws-eks module is problematic for a couple of reasons both technical and cultural.
Firstly wrapping a complex Terraform module in another complex module makes the resultant code exponentially harder to understand, made even worse by needing to jump between two repos to follow the code paths. As the terraform-aws-eks module has a number of architectural issues that you need to work around you end up having to put almost as much work in to fixing these as it would have taken to write the code from scratch but you don't get a clean implementation. All of this means that anyone starting here as a beginner is going to find it harder to increase their knowledge by reading the code than it should be.
Secondly, and more importantly, ever since just before v18 of terraform-aws-eks was released the module is no longer operating as a "community" and the maintainers have not behaved in a way that is conducive to it being one. I don't want to air dirty laundry in public, and until I discovered that AWS was using the module I was happy to just stop contributing, but now that AWS has made this module feel "official" I feel that I need to bring this up. The way that the v18 release was made, the functionality it removed, the closing of all issues and PRs and the way users who questioned this were spoken to was very much not OK and not how a community should operate. After this happened I made an attempt to work with the module and the maintainers a few times but each time it was made clear that the project was theirs and that only their opinions mattered. I don't think that this behaviour is something that an organisation like AWS should condone let alone promote?
Describe the solution you'd like
I'd like the terraform-aws-eks module dependency to be removed and the implementation to be written directly in this module.
Describe alternatives you've considered
n/a
Additional context
I'd be interested in if you started using terraform-aws-eks before or after the v18 release?

CC @kcoleman731

I just want to better understand the concern here. Is the issue you have with terraform-aws-eks technical, political/social, or both?

@spotaws both, but I probably wouldn't have taken the time to open an issue on a project that I only have a passing academic interest in if it was only technical.

Hi @stevehipwell - thank you taking the time write this issue and share your concern. At this time, we don't have plans to remove the dependency on the terraform-aws-eks module.


Array Destructuring an object throws ambiguous error.

Example
var [b, c] = {a: 5};
// throws "TypeError: undefined is not a function"

I spent a long time trying to figure out what was happening, only to discover that a function was returning an object, not an array.
I'm not sure what kind of error the native version will eventually throw, but I'd appreciate something along the lines of Invalid attempt to destructure non-iterable object [object Object] or something.

It looks like the change needs to take place here
Something like this:
(function (arr, i) {
  if(!arr || !arr[Symbol.iterator]) {
    throw new Error('Invalid attempt to destructure non-iterable instance "' + arr + '"');
  } else if (Array.isArray(arr)) {
    return arr;
  } else {
    var _arr = [];
    for (var _iterator = arr[Symbol.iterator](), _step; !(_step = _iterator.next()).done;) {
      _arr.push(_step.value);
      if (i && _arr.length === i) break;
    }
    return _arr;
  }
});

+1 but specifically throw TypeError

Good call, thanks! The spec doesn't actually specify error messages, only error types which means we can make up our own. There's currently no native implementation of this stuff so there are no references.

@sebmck will be better:
if (Array.isArray(arr)) {
  // ...
} else if(Symbol.iterator in arr) { // core.$for.isIterable() in selfContained
  // ...
} else throw TypeError(/* ... */);

@zloirock Good idea, done.

@zloirock Actually that'd be way slower.

Fixed as of 3.6.1, thanks!

@sebmck maybe. But it's work with array w/o polyfill, don't cause side effect with get [Symbol.iterator]() and TypeError more suitable than Error :)

@zloirock Hmm, I'll see.

Thanks guys, impressed with your promptness!

Perhaps move the "get Symbol.iterator or throw TypeError" bit to a helper, and use in for-of loops as well?


fix PR issue with CI

Ah, looks like it's working with that change. Strange that it would just hang without this. Thanks!


Add customLegendTypes prop to customise covered legend types

Added customLegendTypes prop in LegendWidget and LegendWidgetUI to customise legend types.
Example:
const CUSTOM_LEGEND_TYPES = {
      'my-custom-legend': MyCustomLegend
}

function App {
      return <LegendWidget customLegendTypes={CUSTOM_LEGEND_TYPES} />
}

function MyCustomLegend () {
      return
Test

}

//

dispatch(
  updateLayer({
    id: '...',
    layerAttributes: {
      legend: {
        type: 'my-custom-legend',
        ...
      }
    }
  })
)

Result:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.026%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1186

Relevant Lines:
1613

💛  - Coveralls

After talking with @borja-munoz, we decided to use customLegendTypes to allow to only add custom legend types instead of having the possibility to add and modify the current ones. When the legend type isn't one of the covered by default, the LegendWidgetUI checks the customLegendTypes object, if it doesn't exists, it renders an error message.

@zbigg yes, we need one more approval since this is an enhancement. Btw, you commented, not approved.


Support to dicate where injected snippet is placed.

Currently, livereload is appending itself to the end of the HTML response which means its outside the outer HTML tag.
Is there any to specify a placeholder of where it can inject the snippet. Example - it would be great to set it inside the head tag.
Here's a screenshot of what my current HTML output looks

This is not currently supported and also not really planned. We deliberately do not use any HTML parser/templating library/... to keep complexity and dependency count low. Do you experience any problems with the placement of the script tag, or is this purely an aesthetic preference?

When using htmx, if you use the history push state feature, when the library attempts to restore a previous state of the page they will re-render anything in the body (by default), this means that any script tag in the body will be parsed again. So when I navigate back and forth, the polling causes the server to stop responding.
I am able to configure htmx to restore a different DOM element, but it does mean by default tower livereload placement of its script is problematic.
May I suggest an alternative that also keeps the complexity low since this seems to be a goal of the library.
What if you could pass a flag to disable injecting the script, leaving the application in charge of placing the snippet? This also means you will need to expose the snippet HTML so that the app code can reuse the same js script and place where they prefer.

Ah, I think users previously have experienced a similar issue in #2. My comment in #3 shows an example of how to fix it with HTMX specifically. I am only somewhat familiar with the internals of HTMX, so there might be a reason this does not work with the "history push" functionality, but in my limited testing, reloading keeps working even when I navigate back and forth a bunch of times.

Yes I already have a solution for not adding livereload to requests not triggered by htmx.

I assume you mean "not adding livereload to requests not triggered by htmx"?

This is a different issue. You have to leverage the hx-push-url attribute.

I've tried to reproduce this issue on my end, but I'm not experiencing the same issue as you do. When I use hx-push-url, tower-livereload will connect to the poll endpoint multiple times, which is probably undesirable and should be fixed, but for me this does not result in the server stopping to respond. If you could provide me with a minimal reproducible example that would be of great help.

Any thoughts on allowing app code to turn off the auto-injection and exposing the snippet? Seems like it would be the simplest solution and provide app devs with more control.

Not a huge fan of the idea of exposing the JS snippet. Maybe exposing the poll/back-up URLs so that app developers can write their own reload logic would be a more elegant solution. However, at that point adding a very simplistic </head> scanner might be more beneficial for more users. I will have to think about it.

While the fix in #3 worked for me it took a while to understand at which point things go wrong and that the issue is related to tower-livereload. Would be nice to make this lib compatible by default or to do as @pbouzakis suggested, or maybe mention this detail in readme idk.

I would like to report that I am also having an issue with the placement of the livereload snippet and it's interaction with HTMX.
I do not use hx-push-url attribute directly. Instead, I have set hx-boost on my <body> element which I assume uses hx-push-url under the hood when any link is clicked.
If I click on a link, press my browser back button, then click the link again. After about 7-9 cycles of that, the link (and any other link on the page) doesn't work anymore. The request never hits the backend.
I think it might be because the "long-poll" is made again every time I go back:

It specifically only happens if I use the browser back button, navigating through pages via link clicks on the pages still works after 9 clicks (and it doesn't make an extra long-poll request in the network log).
Also, this sounds very similar to the same issue this commenter had with forms: https://github.com/leotaku/tower-livereload/issues/2#issuecomment-1806729931

I put the liveReload middleware at the end of the routes, it working fine. But after I click my button 7 times to do POST request with htmx, the button stopped working.

I am using HTMX with tower-livereload in an axum server. I only enable livereload in debug mode.
I added the not_htmx_predicate from #3 which does remove the livereload snippet from HTMX responses, however it did not fix the issue of links not loading after 8 redirects.
All links work okay after the 8th link if I remove tower-livereload. Maybe this is more of an HTMX issue, but I think it would be nice to be able to configure where the snippet goes if it is in fact an issue with it's placement in the body element.

Same issue


Update MSDocs for ACS Web UI Library teams interops file-sharing

Still a few changes might be needed together with this PR, we'll move it out of draft after feature is released to beta =)

@anjulgarg and @ddematheu2

fyi, after @jimchou-dev takes this out of draft mode, can you review your respective article changes in this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@ddematheu2, @anjulgarg can you please help to sign-off

#sign-off

@Jak-MS I have a question regarding owner/author, since ddematheu2 has left Microsoft are we allow to change the author so other people will be allowed to sign-off? And to change the author is it just to modify this? (Is there a way to have multiple authors)

Hi @jimchou-dev,
Yes - to update the author metadata, open a PR in the private repo, azure-docs-pr. Note that the author attribute is the author's GitHub alias. I don't think you can list more than one author.

@jimchou-dev, @anjulgarg - It looks like the new link on line 25 in file-sharing-tutorial.md has caused a warning. Can you resolve the warning and sign off again?

#sign-off


misplaced and confusing section

In the IOS section "OPTION 2: Using token-based authentication", right after using token based authentication is a section called "Configure the notification hub for APNS" which I believe was meant to be at the bottom of OPTION 1 because it comes right after having configured the notification hub using tokens.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f503e37-b16e-c92c-8668-313428451053
Version Independent ID: edc66d3e-bf88-3c4d-a148-6288a7022f16
Content: Add push notifications to your Xamarin.Forms app - Azure Mobile Apps
Content Source: articles/app-service-mobile/app-service-mobile-xamarin-forms-get-started-push.md
Service: app-service-mobile
GitHub Login: @elamalani
Microsoft Alias: emalani

@KAnderson Thanks for the feedback. We are actively investigating and will get back to you soon.


Gmdrec crashes on some special characters

Gmdrec would crash when encountering e.g. a backslash \ or caret ^.

Fixed in b5d47a0427815dbb4608d75496b97b45b2e4113d


Security update for libtiff

Motivation for this change
Backport for the master change that updates libtiff, which has multiple CVEs.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

I guess asking @grahamc @fpletz for a merge is the right thing to do ... ? :)
(And paging @ckauhaus just for good measure in case I'm screwing something up here.)

Sorry for the noise. I accidentally created the PR with master as target first ... that's fixed now. staging-17.09 is hopefully the right target.

Thanks for making us aware of this. :+1:
Two things:

staging-17.09 was a temporary branch that was used during the freeze of 17.09. I've deleted it.
Please use cherry-pick -x to backport commits to retain a reference to the commit that was cherry-picked.

I've cherry-picked and pushed that commit.

Forgot to mention this PR in the commit. Here it is: ea0c4b592d45c39dbc3f2429e26db7015dc8513a

Thanks a lot @fpletz! I'll try to remember the cherry-pick thing. Is there a page where I can look this up in case I forget this when making the next PR?


Update webpack and babel 7

Plan was to update it separately but they somewhat come hand in hand.

Thanks @pedroabreu but no longer needed now singe the re-write/upgrade.


Missing image 6.0-nvidia

Hello
FFMPEG 6.0 docker image with Nvidia is missing on Docker Hub.

5.1 exists:

I wonder if this will ever make it to Dockerhub. Could really use it.


⚠ Bofrost.at has degraded performance

In 7563666, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1367 ms

Resolved: Bofrost.at performance has improved in 21eadd6.


Consider factoring out "bitcoins" string in AskPassphraseDialog

The Bitcoin-Qt GUI contains the word "bitcoins" in two strings in AskPassphraseDialog.  In the same spirit as https://github.com/bitcoin/bitcoin/pull/7192 , it would be nice to factor that out into a single constant string, so that translations are more consistent, and forks that call their coins something other than "bitcoins" can decrease their diff size relative to upstream.  Seems like maybe the BitcoinUnits class could be used for this, since it already defines the string "Bitcoins".

If you want to make changes that improve the code here, that's fine, but

and forks that call their coins something other than "bitcoins" can decrease their diff size relative to upstream.

that alone is not going to be a reason for us to make changes in our codebase.

If you want to make changes that improve the code here, that's fine, but

and forks that call their coins something other than "bitcoins" can decrease their diff size relative to upstream.

that alone is not going to be a reason for us to make changes in our codebase.

Yes, I know.  The primary reason I'd hope for this change to be made is just that it makes the code cleaner, as with the merged PR that I linked.


error codes: add support for specifying operation

What have you changed? (required)
error codes: add support for specifying operation. Operation becomes a standard field in error information that is lifted to the top level.
Inspiration is taken from upspin error handling. Seeing a trace of operations in a distributed system gives a great understanding of what occurred. Note that we don't currently have support for stacking up errors: the plan is to add that when it is needed.
What are the type of the changes (required)?
Improvement/New feature.
One error code changed its "operation" field from "remove" to "store.remove". However, that field was just recently added.
How has this PR been tested (required)?
make check && make test

/rebuild

@siddontang PTAL

I just added an additional commit that improves the interface for adding operations (usage shown in two pd locations).

As the error_code.go file is getting more and more complex, I suppose it is an appropriate time to separate it into multiple files. For example, a file contains the most basic errorCode structure and interface, a file contains additional functions related to HTTPCode, and a file contains additional functions related to Operation.

I have found that one large file versus multiple smaller files is largely dependent on community convention, developer preference, and how a language treats files as modules. In this case with go, a split up of files will maintain them all as the same package, so go will treat them like they are all one file. Community conventions do not seem that strong in go. So it seems to be mostly developer preference. In that case, there is no way to make everyone happy.
One issue I do have when browsing source of packages that are split up into files is that I have to jump between two files to understand the package because neither file makes much sense on its own. Keeping that in mind, I think I can find an approach to split it up in a future PR.


Can we make sure Netbox runs on FreeBSD 10.3

I am a very keen user of FreeBSD. I use Netbox on FreeBSD; however, I would like DO to fully test Netbox on FreeBSD for the many users they have on the FreeBSD droplets and other users of FreeBSD.

This isn't something we at DO are likely to undertake. Others in the community are of course welcome to contribute their efforts.

@jeremystretch is there any particular reasons why this is the case?
I am happy to do so in my spare time. It might require a few more people to keep up with your own developments.
How accepting of external developers are DO for Netbox?

Is there any particular reasons why this is the case?

We don't have any need to run NetBox on FreeBSD. That said, NetBox is essentially just like any other Django project. If you can run Django on FreeBSD, you can run NetBox.

How accepting of external developers are DO for Netbox?

Only three of the ten contributors listed in Github work for DO.


Refactor discovery registry

Describe what this PR does / why we need it
重构并优化部分代码
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: livk-cloud:x: livklivk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[SPARK-50644][FOLLOWUP][SQL] Fix scalar cast in the shredded reader.

What changes were proposed in this pull request?
We mostly use the Cast expression to implement the cast, but we need some custom logic for certain type combinations. We already have special handling for long/decimal -> timestamp in VariantGet.cast, so we should do the same thing in ScalarCastHelper to ensure consistency. ScalarCastHelper also needs special handling for decimal -> string to strip any trailing zeros.
Why are the changes needed?
To ensure that cast on shredded variant has the same semantics as cast on unshredded variant.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests. They would fail without the change.
Was this patch authored or co-authored using generative AI tooling?
No.

@cloud-fan could you help review? Thanks a lot!

thanks, merging to master!


Recommend against running Kubernetes instructions from a cloud shell

This can be confusing for users because the port-forward method of
viewing the admin UI only works if you're port-forwarding from your
local machine.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/344fb622d706cf79fa7f80404463e8614b18b023/

The note in the Monitor Cluster section might be overkill. I'm very interested in your opinions on that.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/01896115d9cab72919325201696fb0c8bfc833f6/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b676411805753289381d6077723dd8a21987ebb5/

LGTM - thanks Alex!

, too!

Comments from Reviewable


Remove redirected pages from the sitemap

Including pages in the sitemap that are redirects is a bad idea:

if the page redirects to an internal location, then that location will already be in the sitemap;
if the page redirects to an external location, then it shouldn't be in our sitemap anyway.

Can anyone think of a use-case where a redirecting page should be in the sitemap?

Coverage remained the same at 94.444% when pulling e733b0d5192437a95c4eafd1babc02385fb4fcf7 on mkoistinen:no_redirects_in_sitemap into 8814a8f6d8b958fc998d1ff60870fac554dd1e2b on divio:develop.

Coverage remained the same at 94.444% when pulling e733b0d5192437a95c4eafd1babc02385fb4fcf7 on mkoistinen:no_redirects_in_sitemap into 8814a8f6d8b958fc998d1ff60870fac554dd1e2b on divio:develop.


AbstractMemoryHttpData#renameTo corrupts the data

Expected behavior
AbstractMemoryHttpData#renameTo produces a file that has the same checksum as the input
Actual behavior
AbstractMemoryHttpData#renameTo corrupts the resulting file, however it does have the same size
Steps to reproduce
Call AbstractMemoryHttpData#renameTo with a memory file with multiple parts (composite byte buf)
Minimal yet complete reproducer code (or URL to code)
See https://github.com/micronaut-projects/micronaut-core/issues/4413
Netty version
4.1.53
JVM version (e.g. java -version)
JDK 8
OS version (e.g. uname -a)
macOS

Might be related to #10623 where an old bug were found:

when the buffer exceed 1MB, discardReadBytes is called to remove old part of memory
but the way it is done, especially when using in memory, it could change the real bytes associated (if at least 1 HttpData is already found before this call is made)
The issue and associated fix should clear this old bug (very rare so difficult to find out).

@jameskleeh can you check ?

@normanmaurer That is in fact the issue. What release is this scheduled to be included in?. I also discovered that HttpPostMultipartRequestDecoder does not honor the javadoc of setDiscardThreshold:
    /**
     * Set the amount of bytes after which read bytes in the buffer should be discarded.
     * Setting this lower gives lower memory usage but with the overhead of more memory copies.
     * Use {@code 0} to disable it.
     */
    @Override
    public void setDiscardThreshold(int discardThreshold) {

Setting it to 0 does not disable the behavior:
        if (undecodedChunk != null && undecodedChunk.writerIndex() > discardThreshold) {
            undecodedChunk.discardReadBytes();
        }


Delete predict_uses_y

Pull Request Description
Fixes #2961

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@angela97lin Done!


Remove react-router dependency

parent application needs to specify a custom link renderer if they want to use a react router Link. This would be a breaking change for anyone using the paragraph component and expecting it to work with React Router out of the box
Fixes #282
related #223
Checklist:

[ ] Documentation
[ ] Tests N/A
[ ] Ready to be merged

Next publish after merging this should update to v0.3.0

Codecov Report

Merging #403 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #403   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          77     76    -1
  Lines         358    356    -2
  Branches       16     15    -1
=====================================
- Hits          358    356    -2

Impacted Files
Coverage Δ

components/paragraph/src/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61685d4...864ad27. Read the comment docs.

Deploy preview for affectionate-nobel-f3a8ec processing.
Built with commit b458f92a017b42022a3c1d27f8103fccc97576b6
https://app.netlify.com/sites/affectionate-nobel-f3a8ec/deploys/5bd2f1c73813f02551da37a7


sepolia deploys fail (incorrect gas?)

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
0.2.0
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
If I try to deploy a simple Foo contract on Sepolia it fails due to "(code: -32000, message: insufficient funds for gas * price + value, data: None)". If i do the same on goerli, etc. it works fine. i have funds on sepolia as well. please let me know if i can provide more info.

Can you provide more info to reproduce? Sepolia deploys should work, it sounds like you may have accidentally specified the wrong deployer to one that has no funds. Alternatively, the cost to deploy on sepolia may be higher (either higher gas price, or more gas used due to e.g. interactions with other contracts), so you may not have had enough balance


New options and refactoring

Controls:

Add option to change the home button command from Move Home to Find Home.

Device:

Add hardware parameter to invert value (in addition to swapping position) of end-stops.

+ refactoring and tests

Coverage decreased (-4.0e-05%) to 90.863% when pulling 6069fadf78deae5e93c16d5a921ae2c028b953a6 on gabrielburnworth:master into 9ab6fa3d813374578ecf93106c14f62ce9ea91ba on FarmBot:staging.


Reproduce #3057

Reproduces the infinite recursion
Also speeds up the normalisation by passing various -e to sed.

@crusso I am a bit split whether this should live in tests/fail, but I think this is not intended to fail. Rather it fails due to a bug now, but should be fixed some time.

I'll merge. When fixing #3507 this must be touched. Null problemo.


Pin requests for compatibility

Description of changes:

Pinned requests dependency to 2.29.0 for microservices to avoid conflict with urllib3. https://github.com/boto/botocore/issues/2926

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

Triggered build and deployment cycle for microservices in this PR.
Inspected build logs to make sure there were no dependency warnings/errors.
Tested functionality of microservices affected by this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yes, this was also the recommendation for the Requests 2.30.0 release notes. I would strongly advise against pinning users to older versions of Requests as it's compatible with all versions of Boto3/Botocore.


Add monkeypatch for group definitions to fix jurigged bug

Add monkeypatch for group definition
better explain monkeypatches

Jurigged is adding a blank line between things. It's not clear to me why. This creates a bug where the line numbers diverge from reality.
This PR also improves the explanations for the monkey patches.

It would be better that this was fixed in jurigged. I noticed the author was active very recently so I'll bring up these concerns there


Trait Error after installing SynthStrip

What happened?
I installed the newest versions of FSL and Freesurfer, and also installed SynthStrip using the install instructions, but I am still receiving the error: traits.trait_errors.TraitError: The 'model' trait of a _SynthStripInputSpec instance must be a pathlike object or string representing an existing file, but a value of '' <class 'str'> was specified.
What command did you use?
mriqc bids mriqc_folder participant --participant-label sub-001

What version of the software are you running?
23.1.1
How are you running this software?
Local installation ("bare-metal")
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
No response
Additional information / screenshots
No response

Can you provide execute this in the same shell you were running mriqc?
echo $FREESURFER_HOME

Thanks for reporting - I've added all necessary details here https://mriqc--1254.org.readthedocs.build/en/1254/install.html#execution-system-dependencies and improve the feedback to the user.
Please reopen if this remains a problem after the documentation update.


Update to pug

Jade has been renamed to Pug, and it's appropriate for this module to depend on Pug instead of Jade now.
I also volunteer to maintain this under the umbrella of @pugjs, as we now do for pug-loader.

Here is another loader pug-html-loader, but it works differently
For example, chaining like ng-cache!pug-html doesn't works with Willyelm's loader,
but with this loader all is ok:
{
    test: /\.pug$/,
    loader: 'ng-cache!jade-html'
}

Need only remove jade from peerDependencies

@iboozyvoozy
you can use pug-html with ngtemplate.
pug-html returns module.exports = "your_html" but not the HTML string itself.
ngtemplate has
    if (content.match(/^module\.exports/)) {
        var firstQuote = findQuote(content, false);
        var secondQuote = findQuote(content, true);
        html = content.substr(firstQuote, secondQuote - firstQuote + 1);
    } else {
        html = content;
    }

but ng-cache hasn't and accepts html only because of
    try {
        source = htmlMinifier.minify(source, extend({}, opts));
    } catch (e) {
        this.emitWarning(e.toString() + '\nUsing unminified HTML');
    }

Takes for me about 2 hours to understand what the problem.


Unexpectedly found nil while unwrapping an Optional value

Every time I start a timer, I must stop all current alarms (even if they are inactive). The error probably happens here. Different code affection this I don't think that ran at that time. This error crashed the application.
await Future.wait(TimerType.values.map((e) async => await Alarm.stop(e.id))); // stops all alarms related to a timer
await Alarm.set(alarmSettings: alarmSettings);

In the alarmSettings is an id stopped on the previous line.
This is where it crashes in the plugin. I assume that the value passes through the check, but in the meantime, the alarm at that index is stopped. Maybe the await doesn't work.
if loopAudio {
      self.audioPlayers[id]!.numberOfLoops = -1
 }

I am sorry, but I cannot create a pull request as I have no idea how to do that.

Hi @Musta-Pollo
Thanks for reporting this issue.
I'll take a look at it very soon.

Hey @Musta-Pollo
Which version of the plugin are you using ?
In the 0.2.7 release, a change was added that fixed an issue that looked very similar to yours. Here's the commit.
This fixes the case where an invalid audio asset is given.
Please update the dependency to the latest version, double check your asset path and then let me know if you still have the issue.
Check out the iOS installation guide to help you with the import of your assets. It's a bit tricky for iOS:
https://github.com/gdelataillade/alarm#ios-installation-steps

Hi @gdelataillade, thank you for quickly looking at the issue.
I was looking at this, but I didn't though it related. I never had problems with setting up the audio asset. I followed the tutorial, and all worked smoothly. I had only this problem once. Still, I thought it necessary to report it as crashing is a big problem.
At that time, I had a version alarm: ^0.2.3. After the error, I upgraded to the latest version, alarm: ^0.2.9, and didn't encounter the error yet. It seems more like an edge case or race condition.
private func stopAlarm(id: Int, result: FlutterResult) {
     .......
      self.audioPlayers.removeValue(forKey: id) //there the audio player is removed
  }

  private func setAlarm(call: FlutterMethodCall, result: FlutterResult) {
  ....
    if loopAudio {
      self.audioPlayers[id]!.numberOfLoops = -1. // Before you check if it exists, but is it possible that the stopAlarm function can modify the self.audioPlayers in the meantime even with the await?
    }
  .....
  }

@Musta-Pollo You totally right, a crash is a big problem. Thank you again for reporting the issue, I really appreciate it.
The loopAudio condition is supposed to be ran instantly at the moment the alarm is set (the code here is synchronous), so its alarm player is never supposed to be null. I hope your issue is definitely fixed in the latest versions.
If the error happens again, please let me know. In that case, it will be necessary to add a null check for the player.

Thank you for understanding my point of view and explanation.
Ok, let it be so.


[ENH] Add initialization from efficient backprop

Page 13 of Efficient Backprop
http://yann.lecun.com/exdb/publis/pdf/lecun-98b.pdf

closed by #101


WebsocketClient RangeError

Using Node v6.6.0 on Mac OSX - 2.3GHz i7 w. 16gb RAM
Usually happens within the first 10 seconds.
/path/to/project/node_modules/ws/lib/Receiver.js:382
    default: srcBuffer.copy(dstBuffer, dstOffset, 0, length); break;
                       ^

RangeError: out of range index
at RangeError (native)
at fastCopy (/path/to/project/node_modules/ws/lib/Receiver.js:382:24)
at Receiver.add (/path/to/project/node_modules/ws/lib/Receiver.js:82:3)
at TLSSocket.firstHandler (/path/to/project/node_modules/ws/lib/WebSocket.js:775:22)
at emitOne (events.js:96:13)
at TLSSocket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:176:18)
at TLSSocket.Readable.push (_stream_readable.js:134:10)
at TLSWrap.onread (net.js:543:20)

Also getting:
SyntaxError: Unexpected end of JSON input
    at Object.parse (native)
    at WebsocketClient.prototype.onMessage (/path/to/project/node_modules/gdax/lib/clients/websocket.js:68:31)

I had the same problem after updating from Node 6.2.2 to 6.3.0, which seemed to be resolved by updating ws to the latest version, 1.1.1

Duplicate of https://github.com/coinbase/gdax-node/issues/3

Resolved


fix: check NEXT_DISABLE_NETLIFY_EDGE value rather than if truthy

Hey Netlify Team, please let me know if you have comments or questions!
If you do not want to move forward with this change, what is the intended workaround for configuring Netlify Edge use based on context?
Summary
This update now checks that process.env.NEXT_DISABLE_NETLIFY_EDGE is either 'true' or 'false' rather than checking that process.env.NEXT_DISABLE_NETLIFY_EDGE is truthy.
Why?
This allows Netlify Next.js users to have fine-grain control over setting environment variables for their deploys. By switching to the string value check, users of this runtime can disable Netlify Edge functions for a single branch, and leave it enabled for all others (or vice versa). This is especially helpful for debugging issues (e.g. Netlify Support #104849)
Fixes Netlify Support #106611

This is an example of how I would like to control the Netlify Edge based on context.

Test plan

Deploy a site with NEXT_DISABLE_NETLIFY_EDGE=false. Inspect the build logs and look for a console.log in bright red. To get the best performance and use Netlify Edge Functions
Deploy a site with NEXT_DISABLE_NETLIFY_EDGE=true. No console.log will be present.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

[ ] Check the Deploy Preview's Demo site for your PR's functionality
[ ] Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

If this is approved, we should probably update the tests for this. I looked at the readme, and it doesn't seem to need any updates.

Hey @ascorbic,
Thanks for the quick reply. I see the logical bug in my suggested fix. Thank you for pointing that out.
Would you like me to make the update you suggested? I can see that this logic adds a bit of complexity to the code, but from a user perspective, I think this would be a nice change.
If you and your team do not want to make a change to this plugin, do you have a suggested workaround for unsetting NEXT_DISABLE_NETLIFY_EDGE based on context? I attempted to add an empty string in the Netlify UI to the env var but that doesn't work. Perhaps my team could add a pre-build script to unset the env var in our build pipeline.
How would you like to move forward with this? Thanks!

I think it's a reasonable addition, so if you're up for making the change then we can do it in this PR

Great, sounds good. I'll update the logic in the files and will update the readme.
Are there specific tests you would like me to update? Please feel free to add changes yourself.
Thanks for the help!

Thanks for the help, @ascorbic.

Hey @orinokai,
Thank you for the reply! I'm just getting the notification from GitHub now saying you left a comment so apologies for my late response.

thanks @charkour, i'm just sorting out some failing tests this morning (looks like auth issues) and then hopefully we'll get this shipped

Sounds good. Thanks for your help!

Thanks for getting this looked at @orinokai and @ascorbic!


account blocked ??

how many times can this be used until Instagram blocks the account under spam ?

Not sure if you can get block for just scrolling but idk.


Fixed issue allowing user to edit network connection

NOTES: WAITING FOR NEW VERSION OF AUGUR.JS

Coverage remained the same at 64.687% when pulling dc10202b96182882acde55ad299563934edb70ef on juliyasmith/ch15774/use-current-transport-name-to-determine-if into ec0ad4f1c1c0486eecd7fc5cf553b1f44c82f12d on master.

Coverage remained the same at 64.687% when pulling dc10202b96182882acde55ad299563934edb70ef on juliyasmith/ch15774/use-current-transport-name-to-determine-if into ec0ad4f1c1c0486eecd7fc5cf553b1f44c82f12d on master.

Is there a Clubhouse task for this?

@bthaile Yes, the CH task is shown in the branch name, ch15774.  @justinbarry @bthaile @unparalleled-js this PR has been open for quite a while, what's needed to merge this?

Getting this error, have confirmed I have ethrpc version 5.5.5, seems something got missed.

Did you pull in the new commits?

On Sep 13, 2018, at 11:53 AM, phoebemirman<EMAIL_ADDRESS>wrote:
@phoebemirman requested changes on this pull request.
i still get same error as before and tom's
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/AugurProject/augur-ui/pull/2236#pullrequestreview-155223686, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUFBcCITrnQZMR_3xi8w0_2ajEPF2eYks5uaqmhgaJpZM4WV6D8.

yep

Looks good!


funzzy: init at 0.6.0

https://github.com/cristianoliveira/funzzy
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

[x] package name fits guidelines
[x] package version fits guidelines
[x] package build on x86_64-linux
[x] executables tested on x86_64-linux

Neat program, thanks for packaging it :)


fix(docs): Fix docs structure

Changes

Moved documentation to docs folder
Renamed testing.md to qa.md

Codecov Report
Patch and project coverage have no change.

Comparison is base (217c73e) 96.34% compared to head (58453da) 96.34%.

:exclamation: Current head 58453da differs from pull request most recent head 36efa0e. Consider uploading reports for the commit 36efa0e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   96.34%   96.34%
=======================================
  Files           4        4
  Lines          82       82
=======================================
  Hits           79       79
  Misses          3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[help] How to buy this book?

Hello. I read a sample of your know go book. Do you have any plans to put it on Amazon or something? I can't use the payment system of your website in my country.

On 23 Dec 2022, at 21:28, AtlanCI @.***> wrote:
Hello. I read a sample of your know go book. Do you have any plans to put it on Amazon or something? I can't use the payment system of your website in my country.

Hi,
No, I'm afraid you won't be able to buy the book through Amazon—only through my website. However, if you have another way to make payment, such as international bank transfer, I'm happy to accept that.
Regards,
John


Support ArcMap symbolset

I can help with this.  This was one of the primary reasons I asked about un-forking this repo from maki.  I have a util I wrote to create styles from maki (https://github.com/williamscraigm/makiArcGISStyle) and it can be adapted for this repo.

Great!


Rename "torch_iree" plugin to "input_torch".

Progress on https://github.com/openxla/iree/issues/15468
Bikeshedding galore. Most of the non-mechanical parts of the code moves for input dialect plugins have been completed, so now we can see the plugins side-by-side and decide on how we want them to look.
We have top level plugin folders:

compiler/plugins/input/Torch
compiler/plugins/input/TOSA
compiler/plugins/input/StableHLO
compiler/plugins/target/CUDA
compiler/plugins/target/... (coming soon)

Then each input plugin has compiler/plugins/input/[DIALECT]/[dialect]-iree/PluginRegistration.cpp with the input_[dialect] plugin name.

I'm also considering making the folder name match what the plugin is called directly, so we'd have e.g. compiler/plugins/input/Torch/input-torch/PluginRegistration.cpp (name "input-torch" with a dash?)
Alternately, we could have plugins called torch-iree, stablehlo-iree, and tosa-iree. IMO since these are all IREE compiler plugins the "iree" is redundant and we should instead highlight "input" in the name.

We could further collapse these trees if we wanted, but Torch currently also has sibling torch-mlir/ and torch-mlir-dialect/ folders.

yeah not sure -iree in every name of an in-tree IREE plugin is great - why have the redundancy?
(remember path length limits on windows :)

yeah not sure -iree in every name of an in-tree IREE plugin is great - why have the redundancy? (remember path length limits on windows :)

Agreed... I copied that style from Torch when I set up TOSA and StableHLO

I did hit path length limits on https://github.com/openxla/iree/pull/15568 with compiler/plugins/input/StableHLO/stablehlo-iree/InputConversion/*
If I rework the torch CMake files / folders (input/Torch/torch-mlir, input/Torch/torch-mlir-dialects) from being small siblings, then I could collapse to just input/Torch, input/StableHLO, input/TOSA...
(I think some of that is independent from the code in this PR, but it's worth having the discussion before moving more code around)

yeah, input/torch/ and input/tosa/ for the torch and tosa plugins seems more than sufficient

yeah, input/torch/ and input/tosa/ for the torch and tosa plugins seems more than sufficient

How about input_torch and input_tosa right under plugins (https://github.com/openxla/iree/tree/main/compiler/plugins) as siblings, instead of nesting under input/? (Then could do the same for target/CUDA -> target_cuda)
Having an unambiguous directory name at the root of the plugin helps with namespacing header includes and deps.

seems like a fine start - can always renest in the future, though requiring unique names reminds me of old playstation emulator plugins from back in the day :P

I was busy and didn't get to bike shed. My brain can't process include paths that are not globally unique. That's why the convention was in there like that (vs input-torch). Can't conflict with other random software it is coexisting with ..

I was busy and didn't get to bike shed. My brain can't process include paths that are not globally unique. That's why the convention was in there like that (vs input-torch). Can't conflict with other random software it is coexisting with ..

How's this for TOSA?

https://github.com/openxla/iree/compare/main...ScottTodd:plugin-collapse?expand=1
https://github.com/ScottTodd/iree/tree/plugin-collapse/compiler/plugins

I could also set the directory name as plugins/iree_input_tosa/ to make the includes more unique.
The deeply nested directories like https://github.com/openxla/iree/tree/main/compiler/plugins/input/TOSA/tosa-iree are trickier to set up and still feel some mix of ambiguous / imprecise / verbose.

I think my brain is done for the day... maybe I'll try a few other directory layouts later.

Matching directory names to plugin names is nice, but not strictly required (plugin names are seen in logs and a few source code locations, while directory names are used for includes)
In-tree plugins should try to look like out-of-tree plugins
Grouping related plugins alphabetically is helpful, so I like putting input-torch instead of torch-iree. If we had multiple torch plugins I could see torch-input, torch-custom-ops, etc.
Redundant file paths bloat the path lengths, making supporting Windows annoying in some cases
Adjusting dep paths, includes, etc. too far from the file layout makes Bazel -> CMake conversion difficult

I don't care super strongly, although, I did fiddle with a number of things over time and can attest that some options are just hard and should be avoided.


Fix memory leak for Transaction Controller using parent samples

Description
Follow issue in this issue
Basically, there's a memory leak, specifically when transactions are set as a parent. All the sub results maintains their data until the end of the thread, which can build up significantly, especially when there are large (uncompressed) responses
This PR fixes this, and improves the memory usage of JMeter by a lot, even without using transactions. Because we're cleaning all the SamplerResult data after it's sent to all the listeners. There is no reason to maintain the sampler data for that specific thread. It now clears all fields with large data and removes the parent reference, so GC can actually clear it.
Motivation and Context
JMeter is very memory intensive and by far the majority of the memory is used for processed samplers, just holding memory until the end of the thread run.
How Has This Been Tested?
I've done a lot of testing, made fixes and looks like it is working out well and preserving all the sampleresults/httpsamplerresults to all the listeners.
I've made a couple of scripts to test with a lot of transactions, with and without parent usage. Some synthetic scripts with a lot of 1MB json requests
Screenshots (if appropriate):
This is a graph of original 5.6.3 version, with 30 transactions, using parents, and a single 1MB.json file in it. Running 30 threads and 1 second think time between the transaction (meaning a thread runs 30 seconds + response times)

Then ran the exact same jmx against this fix:

Memory is a LOT lower.
Also ran the same tests without the usage of transaction as a parent:
5.6.3 baseline:

This fix:

Without the fix, we can see actual heap usage is hovering between 150MB and 200MB, with a max heap 420MB. With the fix, it is hovering between 50MB and 100MB with a max heap of 247MB. Also much more stable.
I've done some aggressive manual full GCs to see the real usage, and after the fix, the low end was significantly lower.
Here's a run against a realistic real website, 5 pages (transactions) with parent=true:
5.6.3 baseline:

After the fix:

Types of changes
It creates a deep copy of the sampler result and then forwards that to the listeners. After that we can safely remove all the values from the sampler.
It now only clears data after a root sampler is done, because if it's not on the root and generateParent is enabled, subresults keep building up.
Checklist:

[ ] My code follows the code style of this project.
[ ] I have updated the documentation accordingly.

memtest.jmx.zip
I've added a memtest script. Here you can play with enabling parent mode for transactions. When enabled, in 5.6.3 it runs out of 1GB heap, or just hangs just below it.
With the fix, heap is stable around 100MB.

@vlsi I've added an example script, added heap dump screenshot and improved to code. I only needed a workaround in the JMeterTest.java code or else I was getting serialization errors.
Maybe you can take a look further, I think this is a major improvement when it comes to memory consumption. My current workaround is to disable parents for transactions to keep memory at ease

@jgaalen , thanks for the reproducer. I've got 1G dump, and I'll take a look into it


Delegate upnext to start the next video

Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another one Pull Requests opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[x] Feature change (non-breaking change which change behaviour of an existing functionality)
[ ] Improvement (non-breaking change which improve functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Description

as title
Ref. https://github.com/im85288/service.upnext/pull/133
Sidenote: makes the transition between video smooth and fast
In case of Feature change / Breaking change:
Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

Very very fast - great job!

This should work now with Up Next master branch and the upcoming v1.1.0 release !

I'll wait till it comes out thanks

Don't wait to test it though ;-)


replace links to /docs/concepts/containers/container-lifecycle-hooks/ with /ja/docs/

closes #28760

/assign @nasa9084

/lgtm

/approve


Allow to set up global layout

It would be great if in locals we'd have ability to setting up global layout instead of write every time
{%extends 'master' %} in each view.

Not sure how much difference it will make. You will save 1 line but removes the transparency/clarity from your code, since anyone looking at the has no idea from where it is getting the base markup and have to look into the config file to find out the reason.

Maybe store layout in locals is not great idea. For example PHP framework Yii2 rendering flow:

Yup it is better to be explicit. Closing the issue

Ok, suppose I have a view "login" and I want to use it in the modal popup and in a single page.
It would be pretty simple if we can pass some param to view, that disable or include other layout:
response.sendView(login, {layout: false}) response.sendView(login, {layout: 'empty'})

Hey @howardEagle !

This is how Nunjucks works.

Hi, i'm looking the docs and can't understand very good the layout system (I'm coming from RoR)
Just out of curiosity, there is a possibility that the layouts may be somehow similar to how rails do it; a default layout, and specify, if necessary ... another in particular within the controllers?


no reply memory leak

Rabbot is subscribing to a postal channel with the requestId and not unsubscribing until the reply is sent. If the reply is not sent the subscriptions just build up. Watch the memory usage in the example below.  Should there be a timeout on the reply? idk
'use strict';

const rabbit = require('rabbot');
const topology = {
  connection: {
    server: 'localhost',
  },

  exchanges: [{
    name: 'test.ex',
    type: 'direct',
  }],

  queues: [{
    name: 'test.q',
    noAck: true,
  }],

  bindings: [{
    exchange: 'test.ex',
    target: 'test.q',
    keys: 'test',
  }],
};

rabbit.configure(topology).done( function() {
  rabbit.handle('test', (message) => {
    console.log(`received ${message.body}`)
    //message.reply(`${message.body}`);
  });

  rabbit.startSubscription('test.q');

  (function send(num) {
    const options = {
      body: num.toString(),
      type: 'test',
    };

    rabbit.request('test.ex', options).then((message) => {
      //never gets called
      console.log(`replied ${message.body}`)
    });

    setTimeout(send.bind(undefined, num+1), 0);
  }(1));
});

@brandonpsmith - thanks for pointing this out, I have put replyTimeout in place and updated the README to explain it. Basically, if a publishTimeout exists and no replyTimeout was specified, it just doubles that for the timeout. Let me know what you think, the code is available in NPM as version 1.0.0-9.

Looks good. If I find anything else. I'll let you know.


Wrong happend in yolox pruning

Describe the issue:
load yolox model:
name = "yolox-s"
exp = get_exp(None, name)
model = exp.get_model()
model.to(device)

config_list:
config_list = [{
        'sparsity': 0.5,
        'op_types':['Conv2d'],
    }]

compress:
pruner = L1NormPruner(model, config_list)
_, masks = pruner.compress()
pruner._unwrap_model()
ModelSpeedup(model, torch.rand([10, 3, 64, 64]).to(device), masks_file=masks).speedup_model()

Error:
ModelSpeedup(model, torch.rand([10, 3, 64, 64]).to(device), masks_file=masks).speedup_model()
  File "/home/*/miniconda3/lib/python3.8/site-packages/nni/compression/pytorch/speedup/compressor.py", line 546, in speedup_model
    self.infer_modules_masks()
  File "/home/*/miniconda3/lib/python3.8/site-packages/nni/compression/pytorch/speedup/compressor.py", line 383, in infer_modules_masks
    self.update_direct_sparsity(curnode)
  File "/home/*/miniconda3/lib/python3.8/site-packages/nni/compression/pytorch/speedup/compressor.py", line 237, in update_direct_sparsity
    _auto_infer = AutoMaskInference(
  File "/home/*/miniconda3/lib/python3.8/site-packages/nni/compression/pytorch/speedup/infer_mask.py", line 80, in __init__
    self.output = self.module(*dummy_input)
  File "/home/*/miniconda3/lib/python3.8/site-packages/nni/compression/pytorch/speedup/jit_translate.py", line 245, in __call__
    result = self.func(*self.positional, **self.keyword)
TypeError: arange() received an invalid combination of arguments - got (Tensor, pin_memory=bool, device=torch.device, layout=torch.layout, dtype=NoneType), but expected one of:
 * (Number end, *, Tensor out, torch.dtype dtype, torch.layout layout, torch.device device, bool pin_memory, bool requires_grad)
 * (Number start, Number end, Number step, *, Tensor out, torch.dtype dtype, torch.layout layout, torch.device device, bool pin_memory, bool requires_grad)

I have 2 question:

how to decide the dummy_input in ModelSpeedup()
what's wrong with my code?

Environment:

NNI version:2.10
Training service (local|remote|pai|aml|etc):local
Client OS:linux
Server OS (for remote mode only):
Python version:3.8
PyTorch/TensorFlow version:pytorch
Is conda/virtualenv/venv used?:conda
Is running in Docker?:no

hello @Sugar929 , could you show us the yolox?

result = self.func(*self.positional, **self.keyword)

TypeError: to() takes from 0 to 4 positional arguments but 5 were given
↑↑↑↑↑↑↑↑↑↑↑↑↑similar error


Remove pywin32 dependency

This finally implements locking through supplied msvcrt module #2. And should make AppVeyor in #9 happy. Docs used:

http://linux.die.net/man/2/flock
http://effbot.org/librarybook/msvcrt.htm

Coverage remained the same at 87.736% when pulling 6d7a084b6d3417b1e42f89c306c03d79620db5fd on techtonik:patch-3 into 49b4474cfce6e813a6d87f917b19373b550dcc10 on WoLpH:develop.

Coverage remained the same at 87.736% when pulling eb477a7f0cc3c44f7140a2217e59a3af3b451a84 on techtonik:patch-3 into 49b4474cfce6e813a6d87f917b19373b550dcc10 on WoLpH:develop.

Thanks so much for the help :) I honestly wasn't really sure what to do with the issue as I don't have any windows systems to easily test...

Trying to replace everything with msvcrt. Must say that your tests are really helping here.

Coverage remained the same at 87.736% when pulling 1c8370753197bd9a0b3bd305d5d1316dae9a8d3b on techtonik:patch-3 into 49b4474cfce6e813a6d87f917b19373b550dcc10 on WoLpH:develop.

@WoLpH it is now ready to be merged. There are some missing point to check - I am not sure that seek should fail for file that was locked exclusively

Thanks a lot for the help :) I'm pushing out a new release right now


Debian 32 Bit client

Hello,
Can u please give 32 bit client please

See https://github.com/yinghuocho/firefly-proxy for download links.

Hello thank you so much .
On 2 August 2016 at 12:28, yinghuocho<EMAIL_ADDRESS>wrote:

See https://github.com/yinghuocho/firefly-proxy for download links.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yinghuocho/firefly-proxy/issues/30#issuecomment-236817973,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOSTKWnir3ZLRuf_glk0D4sEYtSFLBz4ks5qbuqwgaJpZM4JV3_X
.

No problem.


No error on missing module

Move your existing distribution out of the way:
 mv ~/.ceylon{,.bak}

Build the dist:
 cd ~/git/ceylon/ceylon; ant dist

Build the SDK:
 cd ../ceylon-sdk; ant publish

Clone ceylon.ast if you don’t have it yet:
 cd ..; git clone https://github.com/ceylon/ceylon.ast.git

Try to build it with the following incorrect command:
 cd ceylon.ast
 rm -rf modules # just in case you didn’t need the previous step and still have this left over
 ../ceylon/dist/dist/bin/ceylon compile-js {,test.}ceylon.ast.{core,create}

Actual output (abridged):
source/test/ceylon/ast/core/CeylonExpressionTransformer.ceylon:12: error: package not found in imported modules: 'ceylon.ast.samples.completeCompilationUnit' (add module import to module descriptor of 'test.ceylon.ast.core')
import ceylon.ast.samples.completeCompilationUnit {
       ^
source/test/ceylon/ast/core/CeylonExpressionTransformer.ceylon:25: error: function or value does not exist: 'completeCompilationUnit' (did you mean 'ceylon.ast.core::CompilationUnit'?)
    completeCompilationUnit.transform(CeylonExpressionTransformer());
    ^
2 errors

The module descriptor for test.ceylon.ast.core does in fact contain an import for ceylon.ast.samples, so it’s odd that the compiler didn’t complain when this module was nowhere to be found, instead only barfing when the module was actually needed.

Moving to 1.2.2, there's a clear workaround.


Use the React frontend in helm-server by default

Makes helm-server use the React frontend by default
Removes the --react flag
Adds the --jquery flag for falling back to the legacy frontend

Waiting for #2291 to be closed before I merge this.

Actually, I will merge this now and we can address the rest of the todos later.


Add missing favicon

We forgot to add a favicon! :grimacing:

Sir, Where is it missing? I want to contribute.
Thanks

@decause I used the favicon used in about.twitter.com
Does this look good? Preview - https://orkohunter.github.io/twitter.github.io/

@Saurabh3333 The favicon file referenced from the HTML was missing. :D

Thank You @OrkoHunter
I think the issue has been already fixed.

I don't see a change live, was there a PR you wanted to mention @Saurabh3333


Issue with RiotGames.RiotClient (#16141)

Brief description of your issue
Problem 1
The version is not determined and what in turn is a problem with winget upgrade --all. And because of problem 2 is somewhat unpleasant. But this was already mentioned in #16287.
Problem 2:
Riot/League of Legends has different servers (EUW, NA and so on). But in #16141 the NA client was used. This leads to problems with an EUW installtion because a) the language and b) the server are changed.
What would need to change?
Riot would have to provide an installer that a) sets the version in the software center and b) is independent of the server and does not change the settings. Or it would have to provide different installers (RiotGames.RiotClient.NA, RiotGames.RiotClient.EUW and so on).
Steps to reproduce

install: https://lol.secure.dyn.riotcdn.net/channels/public/x/installer/current/live.euw.exe
run winget upgrade --all

Expected behavior
The update is performed only once and does not change the server and language settings.
Actual behavior
The update is executed again each time winget upgrade --all is called and changes the language and server settings each time.
Environment
Windows Package Manager v1.0.11451

Windows: Windows.Desktop v10.0.19043.1023
Package: Microsoft.DesktopAppInstaller v1.11.11451.0

For problem 2,maybe we need to write a multi-locale yaml file which use different installer for different locale.

I don't think this will help. Since the installer is server based rather than language based.
(In my example, the language was only changed because many of the European languages are not available for selection on the NA server (for whatever reason)).
So someone from the USA (NA) could also play on a EUW (EU-West) server (even if it makes little sense for ping reasons). But a realistic example would be Poland. There is also EUNE (EU-North-East). Whether someone from Poland plays on EUW or EUNE is up to the player and cannot really be determined by the language "pl-PL" (especially since it is common to play in English).

@ivey @riot-rmarin
I know it's definitely not your area/department. But can you forward this to the position/colleague who could be helpful here?

Duplicate of #24222


Add 2001: A Space Odyssey (1968)

Checklist for submitting a pull request to Movies For Hackers:

[x] I have carefully read and comply with the Contributing Guidelines of this repo.
[x] I have searched the PRs of this repo and believe that this is not a duplicate.

Title:
Link:
Genre:
Rating:

Description:

Merged in favour of #170.


Conferencing: How to trigger Calendar actions from OAuth callbacks

Description
I'm trying to build a conferencing addon for Google calendar that kind of works like Google Meet. It requires authentication so in the createConference function, I'm throwing an error of type ConferenceDataService.ConferenceErrorType.AUTHENTICATION while attaching an authentication URL. I brought in the oauth package, defined an authentication function authCallback and it seems to work as expected.
The problem is that I need to trigger createConference after the authentication is successful so it can update the calendar event with the conferencing tool. I'm aware that createConference needs to return the dataBuilder object for the frontend to receive that update, but since authentication is required, I have to return the authentication error so it displays the login button for the user to login. Logging in works successfully so how do I update the conference on Google calendar event with the conferencing tool?
It's quite unclear from the documentation what needs to happen after the authCallback.
Here's what the auth callback looks like:
function authCallback(request) {
  const args = JSON.parse(request.parameter.args);
  const eventData = {
    ...args,
    ...request.parameter,
  };

  create3rdPartyConference(eventData);
  return HtmlService.createHtmlOutput('Success! You can close this window.');
}

Currently, what it does is to trigger create3rdPartyConference (nothing happens), even after building the conference data and triggering databuilder.build().
Additional

The calendar event isn't created by the time createConference is called, but it does pass an eventId and getting this event returns 404 since it's not created yet.
The end goal here is to take away the login button below and display the actual conferencing tool when authentication is successful and authCallback is triggered.

Closing this, I just figured appscript automatically calls createConference again if the authentication callback is successful 😄


Return error from clustering

@joshhjacobson, as you known, the k-means clustering algorithm searches for a local minimum based on randomly generated initial starting points for the clustering search. Since it does not guarantee a global minimum, comparing multiple clustering runs is necessary if you want to select the best clustering configuration. Because of this, we need to have access to the error related to each centroid from kmeans() to inform the user of the error associated with each clustering run. These errors would have to be aggregated across centroids to provide a single metric for the user.
This video does a nice job expressing what we need to do. Instead of having multiple panels, however, the user would just have to remember what the lowest value was.
I'm not sure what the best way to return this information would be. Do you have any ideas on that?
Specifically, I would like to display the aggregate error across clusters as text on the web application like this (the XXX represents where the error would be displayed):

Correction: can we return the aggregate within sum of squares deviation across the clusters instead of just the error?

Here's what a basic call to the clustering library looks like (note that we do not specify an initialization, but we do provide the user the ability to do so):
let result = kmeans(data, 2, { initialization: centers });
console.log(result);
/*
KMeansResult {
  clusters: [ 0, 0, 1, 1 ],
  centroids:
   [ { centroid: [ 1, 1.5, 1 ], error: 0.25, size: 2 },
     { centroid: [ -1, -1, -1.25 ], error: 0.0625, size: 2 } ],
  converged: true,
  iterations: 1
}
*/

As you can see, we have the error term for each centroid. I'm not sure I understand exactly what you want, but can we use this information to compute it?

Yes, I think we can. To calculate the within cluster sum of squares we need to do the following:

Source: stats.stackexchange.com
We also need to have the observations and to which cluster they belong so we can do the calculation. Does that seem feasible?

@wraseman Based on our last meeting, this is no longer something we are planning to implement. Is that right?

True, I'll close the issue.