Beta 3185.1.0: ignition fails to create partition on second disk (vmware)

Description
With Beta 3185.1.0 and ignition v3 we observe issues when vSphere VM has more than one disk.
Impact
Cannot deploy VM.
Environment and steps to reproduce

Set-up: Flatcar VM deployed in vSphere 7 using terraform-provider-vsphere v2.0.2
Task: Deploy Flatcar Beta 3185.1.0 OVA using Ignition v3 spec file (as vapp)
Error: Ignition fails with: create partitions failed: Failed to pretend to create partitions: exit status 4. Stderr: Could not create partition 1 from 4194304 to<PHONE_NUMBER>3. Sometimes ignition fails without an error message. In both cases entering  Emergency shell is not possible (reboot loop).

Expected behavior
VM is deployed as it is the case with Flatcar Stable 3139.2.0 OVA with Ignition v2 spec file
Additional information
To narrow it down to Beta release, same ignition json is used (just few lines edited that differ between v2 and v3 spec file).
Attaching both files to the issue.
VM config to reproduce:
provider "vsphere" {
  user                 = "user"
  password             = var.password
  vsphere_server       = "vc-server-url"
  persist_session      = true
  client_debug         = true
}

data "vsphere_datacenter" "dc" {
  name = "DC"
}

data "vsphere_datastore_cluster" "datastore" {
  name          = "datastore"
  datacenter_id = "${data.vsphere_datacenter.dc.id}"
}

data "vsphere_compute_cluster" "cluster" {
  name          = "cluster"
  datacenter_id = "${data.vsphere_datacenter.dc.id}"
}

data "vsphere_virtual_machine" "template" {
  name          = "flatcar_production_vmware_beta"
  datacenter_id = "${data.vsphere_datacenter.dc.id}"
}

data "vsphere_network" "network" {
  name          = "network"
  datacenter_id = "${data.vsphere_datacenter.dc.id}"
}

data "local_file" "ignitions" {
  filename = "ignition.json"
}

resource "vsphere_virtual_machine" "vm" {
  name             = "beta-ignition-v3"
  resource_pool_id = "${data.vsphere_compute_cluster.cluster.resource_pool_id}"
  datastore_cluster_id = "${data.vsphere_datastore_cluster.datastore.id}"

  num_cpus = 2
  memory   = 1024
  guest_id = "${data.vsphere_virtual_machine.template.guest_id}"
  scsi_type = "${data.vsphere_virtual_machine.template.scsi_type}"

  network_interface {
    network_id   = "${data.vsphere_network.network.id}"
    adapter_type = "${data.vsphere_virtual_machine.template.network_interface_types[0]}"
  }

  disk {
    label            = "disk0"
    size             = "64"
    unit_number      = "0"
    eagerly_scrub    = false
    thin_provisioned = true
  }

  disk {
    label            = "disk1"
    size             = "64"
    unit_number      = "1"
    eagerly_scrub    = false
    thin_provisioned = true
  }

  clone {
    template_uuid = "${data.vsphere_virtual_machine.template.id}"
  }

vapp {
    properties = {
      "guestinfo.ignition.config.data"          = base64gzip(data.local_file.ignitions.content)
      "guestinfo.ignition.config.data.encoding" = "gz+base64"
    }
  }
}

Just confirmed that same is happening with latest beta 3227.1.0.

Hi @defo89, looked into this:
Right now the ignition conversion does not handle ignition version 2.1.0, that's why ignition-v2.json is failing on newer Flatcar's. You can make it work by manually editing it in the following way:
--- a/ignition-v2-example.json.txt
+++ b/ignition-v2-example.json.txt
@@ -2,7 +2,7 @@
     "ignition": {
         "config": {},
         "timeouts": {},
-        "version": "2.1.0"
+        "version": "2.3.0"
     },
     "passwd": {
         "users": [
@@ -15,13 +15,13 @@
     "storage": {
         "disks": [
             {
-                "device": "/dev/disk/by-path/pci-0000:00:07.0",
+                "device": "/dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:1:0",
                 "partitions": [
                     {
                         "label": "etc-test",
                         "number": 1,
-                        "size": 10240000,
-                        "start": 2048,
+                        "sizeMiB": 5120000,
+                        "startMiB": 1024,
                         "typeGuid": ""
                     }
                 ]

The older "size" and "start" properties are expressed in sectors, which is mostly 512 bytes.
As to ignition-v3.json is not working: are you sure your disk is 10TB in size? It is also possible that things are failing because the disks are getting reordered (/dev/sda swapped with /dev/sdb). Things might be better if you attach the disk to a separate scsi controller instead of having both disks under the same one.

Thanks for looking at this @jepio. For now I worked this around by switching to a single vsphere disk for the affected VMs.
On the related note, is there an ETA for bringing ignition-v3 to stable release (in other words, when >=3185.0.0 will become stable)?

Seeing this quite often when updating and replacing Flatcar with an attached durable disk:
Ignition finished successfully
Ignition 2.15.0
Stage: kargs
no configs at "/usr/lib/ignition/base.d"
no config dir at "/usr/lib/ignition/base.platform.d/azure"
kargs: kargs passed
Ignition finished successfully
Ignition 2.15.0
Stage: disks
no configs at "/usr/lib/ignition/base.d"
no config dir at "/usr/lib/ignition/base.platform.d/azure"
disks: createPartitions: op(1): [started]  waiting for devices [/dev/disk/azure/scsi1/lun1]
disks: createPartitions: op(1): [finished] waiting for devices [/dev/disk/azure/scsi1/lun1]
disks: createPartitions: created device alias for "/dev/disk/azure/scsi1/lun1": "/run/ignition/dev_aliases/dev/disk/azure/scsi1/lun1" -> "/dev/sda"
disks: createPartitions: op(2): [started]  partitioning "/run/ignition/dev_aliases/dev/disk/azure/scsi1/lun1"
disks: createPartitions: op(2): op(3): [started]  reading partition table of "/run/ignition/dev_aliases/dev/disk/azure/scsi1/lun1"
disks: createPartitions: op(2): op(3): [finished] reading partition table of "/run/ignition/dev_aliases/dev/disk/azure/scsi1/lun1"
disks: createPartitions: op(2): running sgdisk with options: [--pretend --new=0:0:+0 /run/ignition/dev_aliases/dev/disk/azure/scsi1/lun1]
disks: createPartitions: op(2): [failed]   partitioning "/run/ignition/dev_aliases/dev/disk/azure/scsi1/lun1": Failed to pretend to create partitions. Err: exit status 4. Stderr: Could not create partition 3 from 0 to 33
Error encountered; not saving changes.
disks failed
Full config:
{
  "ignition": {
    "config": {
      "replace": {
        "verification": {}
      }
    },
    "proxy": {},
    "security": {
      "tls": {}
    },
    "timeouts": {},
    "version": "3.5.0-experimental"
  },...

Isn't that a different issue, related to terraform: https://github.com/flatcar/flatcar-website/pull/296 ?

Isn't that a different issue, related to terraform
No, this is not related. This is a problem with an already existing disk when recreating the flatcar VM.

So there is some race involved and it doesn't always happen? The same error message was reported in https://github.com/coreos/bugs/issues/2100#issuecomment-499003464


Orpen weather/validation patterns

On this PR:

Pattern of variables names;
Pattern to instances names;
Validation of subscription webhook to not accept duplicate subscriptions;
Validation to clear the string params;

Must have make a hotfix to solve the db insertion challenge


Install optional dependencies manually, if Yarn on GitHub Actions won't.

it worked locally...
😅

I'll take the liberty of merging it, because the ❌ status on the main page looks pretty bad :P

Why exactly did we make docosarus optional in the first place?


Edit text string to have consistent case

Change "You win!" and "You lose!" in the description to to "You Win!" and "You Lose!" to match the test descriptions further down the page. Note the test itself is case insensitive. This PR is to reduce confusion for beginners.

[ x] I have read freeCodeCamp's contribution guidelines.
-[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[ x] My article does not contain shortened URLs or affiliate links.

If you read the test, it doesn't actually care about the case, so I'm not sure the change is meaningful.

Good call out @lynxlynxlynx . I have changed the PR to reflect that this is for consistency, to avoid confusion, rather than to pass the test.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


RFC: Display Zotistics graph on hover

The other blue buttons lead to an external page, so it would make sense if this one does as well. The graph should display on hover, which would be more convenient as well IMO. We'd have to think about how it would work on mobile though.

Expected completion time: 1 week


Implement modifying user settings

API command CMD_API_MODIFY_USER

Hmm this isn't an easy one, judging by https://forum.directadmin.com/showthread.php?t=51235 and http://forum.directadmin.com/showthread.php?t=33636&p=170106#post170106 that call is a mess. I'll look into it though.

I see, as I understand it the problem is that you need to send the complete package data. Maybe it's an idea to have 2 options within the new modify function:

You either pass the complete data into the function (if you have the info stored, or you rewrite it completely)
Or you pass only certain values and a separate call is internally made to collect the existing data, then it gets merged with the new data, and then it sends the complete modified data to the modify api call.

Well the internal caches already hold the output of user config and usage. If the forward call is parameter-compatible the implementation is actually trivial. The major problem (as oft) is in this case that the documentation boils down to "look at the templates" which is barely better than none.
All classes are internally set up to store and access multiple string buckets, so it may just boil down to this pseudocode:
public function modify(array $modifications)
{
  invoke('CMD_API_MODIFY_USER', array_merge($oldSettings, $modifications));
}

I'll have to dive into the options there though  :)

Ah I didn't realize it was such a mess.
I've done a quick compare based on the documentation (full list below). But as the documentation isn't complete (the KB article gives the language (even with a typo!) option in the example for MODIFY_USER, and language isn't in the documentation for MODIFY_USER but it is for SHOW_USER_CONFIG), I would assume that it would take nearly all parameters it also gives you from SHOW_USER_CONFIG.
Comparison of documentation (I'm guessing nearly all inconsistencies are just poor documentation, with the exception of the keys that provide information in italic). The 10 listed under SHOW_USER_CONFIG may need double checking what effect they may cause.
Both SHOW_USER_CONFIG and MODIFY_USER have:
aftp
bandwidth
cgi
cron
dnscontrol
domainptr
ftp
mysql
nemailf
nemailml
nemailr
nemails
ns1
ns2
nsubdomains
quota
skin
spam
ssh
ssl
sysinfo
vdomains
MODIFY_USER unique has:
php
ubandwidth
udomainptr
uftp
umysql
unemailf
unemailml
unemailr
unemails
unsubdomains
uquota
user
uvdomains
SHOW_USER_CONFIG unique has:
account
additional_bandwidth
catchall
domain
email
ip
language
login_keys
package
suspend_at_limit
Gives info:
creator
date_created
docsroot
lastquotaupdate
sentwarning
suspended
username
usertype
Deprecated:
zoom

That's actually really helpful, thanks  :)   I've just dived into debug mode, and php is actually present in SHOW_USER_CONFIG, so docs are off there, and user makes sense to be set-only as it's only used to change the username. That leaves only the 'unlimited' options which we can patch internally from NULL values. I've created a feature branch to do some R&D on this.

Implementation in feature branch seems to hold up to some simple tests:
$user->modify([
    'bandwidth' => 500,
    'quota' => 250,
    'php' => 'ON',
    'ssl' => 'ON',
    'vdomains' => 10,
]);
$user->modify([
    'bandwidth' => null,
    'quota' => 500,
    'vdomains' => 5,
    'ssl' => 'OFF',
]);

Afaics these tests are applied just fine and only modify the settings I'd want to.

This looks great. In this example when you're setting bandwidth to null, it won't change?

Just pushed another commit. NULL is considered unlimited. I've added accessor functions so in most cases you don't need to go through modifyConfig (which should in a perfect world be protected instead of public anyway).

I see. These nicely documented wrappers are the way to go indeed :+1:

I'll pull this back into the main branch when I've added some unit tests  :)


Support for expressions as column defaults in DDL statements

Only literals are supported right now. See #104

https://github.com/liquidata-inc/dolt/pull/857


'Lark' and 'Moon' are too similar.

Hello,
'Lark' and 'Moon' look too similar. Perhaps there is a problem with 'Lark'.

Good point, looking at the code the single difference between the two is 0.02 (2%) change in brightness, which doesn't align with what the comment explaining the filter expects it to do.
https://github.com/hsbijarniya/colorfilter_generator/blob/fd08bdf5afbc08241d001cd17b6826e58cda8831/lib/presets.dart#L47-L65


Rename "Critical" to "Popular"

This is just a random idea, but a non-trivial number of people have concerns over the use of the word "critical" and what that implies about their project.
There's already emails and campaigns going out using the word critical, so it may not be worth changing now, but we may want to consider switching to a term that may have less connotations. "Popular" could be useful here, since (most) of these projects are included by nature of their download counts.
Maybe it's fine though, I dunno. Just throwing it out there.

"Popular" was my first thought too, but then I realized that it could be misunderstood by all the package users who want PyPI to do a better job at curating and telling them which packages to use. Like they might think "Popular" = "Recommended". I guess this would only be an issue if exposing this metadata in the UI, but your second post mentioned that :-)
I guess one strategy would be to start exposing basic download statistics in the UI, since that's a super popular feature request anyway, and then you can point to it and say "2FA is mandated for all projects where that number is greater than this threshold". (Also makes it easier to move the threshold down incrementally over time, if that's the plan.)

From the beginning, I translated “critical” as “crucial” for this very reason.


The response.content_type is not add to headers in ASGI

Perhaps the response.content_type is add to headers here.

See the fix in #1654. Thanks for bringing this up.


Azure OpenAI: use "deploymentName" instead of "deploymentId"

What this PR does:
Azure OpenAI: use "deploymentName" instead of "deploymentId"
Which issue(s) this PR fixes:
Fixes #1126
Checklist

[x] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

We agreed not to do this. Closing


guarantee table names are unique

What

Table names may conflict with scalar type names.

How

Prevent conflicts by:
-- assigning unique aliases to tables during introspection, if needed
-- preserving customized aliases during update operations

It might be helpful to have a test here - I don't think you need it to verify correctness, but to avoid future breakage. You have an unwritten rule that type names should be iterated in a consistent order to get consistent aliasing on re-introspection. If someone someday changes the type under TablesInfo from BTreeMap to HashMap then everything will look fine, but there will be a subtle bug of inconsistent aliasing.
Anyway, looks good!

Good call on the test, but I'm actually quite unsure about how to go about testing for non-deterministic behavior. We already have tests that will tells us if introspection yields a different configuration, and being snapshots these will catch incidents of ordering changing.
But I'm not sure how to specifically write a test for ordering becoming non-deterministic, and have that test try to guarantee failure. Besides running a couple times.


fix the circle ci build

Removing the setup.sh file and step is just a bit beautifying.
Usually you can simply set a project property "foo" via environment variable by setting "ORG_GRADLE_PROJECT_foo" to the desired value. But unfortunately many shells including Bash and the CircleCI implementation have problems setting environment variables which contain dots.
So I kept your PUBLISH_KEY and PUBLISH_SECRET environment variables, but simply set the correct project properties from the build script, instead of doing file manipulation.

Regarding the failed builds, well, we were at a boundary of 4 GiB memory usage in multiple processes. There were the gradlew call, the Gradle Daemon that is now activated by default, a Gradle worker process and a Gradle test executor process. Those 4 processes together often touched the 4 GiB boundary which CircleCI enforces and then starts to kill processes. Gradles native monitoring of course cannot work, as there is plenty RAM and CPU available in the system, so it is also given to the JVM and Gradle does not see that it is reaching any boundary.
To fix the situation I did the following steps:

I disabled the Gradle Daemon completely, which is recommended for CI systems anyway. It is ultimately useful for development machines to speed up work, but for the sake of reliable reproducible builds, it should always be off on CI systems. This is also recommended by the documentation.
I set the max memory for the gradlew process to 1 GiB
I set the max memory of the test executor process to 1 GiB if the build is running on CircleCI

Before these changes, the build failed in 50% - 90%.
With these changes I ran the build 30 times without a single failure.
I'd really wonder if your change of setting the max memory to 2 GiB in the org.gradle.jvmargs would have had any effect.
I don't think so, as this should only affect the Gradle Daemon process, which by default is restricted to 1 GiB, so you just allowed it to consume more memory, while it was not even the culprit.
I guess it just accidentally worked and if you would start 30 builds, you would get quite some failing.

I also removed the --stacktrace option and added the --info option instead
--stacktrace is usually too noisy, e. g. you get a full stracktrace for each deprecation warning and also each build failure, even if the message is clear enough
I would not enable this by default.
But having --info level output in a CI build usually is more appropriate than lifecycle level, at least that is what the past has told me. :-)

Yes --info is better - I threw --stacktrace in there when I was trying to debug the build failure on circle and then forgot to remove it.
Thanks for figuring this out!

Oh and as far as setting the max memory - I did that because the build would also fail intermittently with heap-dumps, but I don't think that was the actual issue as you said.

Yeah, I would really wonder if 1 GiB is not enough max daemon memory for this build


Update User.php

Add method for get token
I fix method to cache query. but some one dont like this way)

Could you please send one pull-request which covers all your changes (#547, #546, #545), so I can review them all at one moment.

ok, i try it


Add a github actions CI workflow to detect typescript, linting and build errors

Raised a PR with the required changes. Please take a look.


text-wrap problem inside the table cells

Problem:
the column values are long and the text is not wrapped inside the cell and the td width is increasing

This is probably a problem best-tackled via CSS.


SDP-711 Disable profile update

Make sure you include the related JIRA issue in the title e.g. '[SDP-007] Fixed navbar issue'
Make sure you have checked off the following before you issue your Pull Request:

[x] Added unit tests for new functionality
[x] Passed all unit tests using rails test with 90%+ coverage
n/a Added cucumber tests for any new functionality
[x] Passed all cucumber tests using bundle exec cucumber
[x] Passed overcommit hooks, including running all code through Rubocop
n/a If any database changes were made, run rake generate_erd to update the README.md
n/a If any changes were made to config/routes.rb run rake jsroutes:generate
n/a If any HTML was added or modified check to make sure it was still 508 compliant with WAVE tool / carried over any attributes from similar sections

Closing this as the assertions upon further inspection are a bit iffy in whether or not they work as expected.


feat: Default view configuration setting

@apotterri for your review and enjoyment:
https://www.loom.com/share/a0035c6ee67543dab6aada7b4b49b335

:tada: This PR is included in version 0.34.0 :tada:
The release is available on:

v0.34.0
GitHub release

Your semantic-release bot :package::rocket:


sass web worker and cndjs

Hi,
using sass worker with cdnjs ins't possible for access domain origin. Can be possible pass a blob with js sass worker code, or passing directly an instance of the worker?
Thanks

same problem with sass_sync  and access domain origin
caught could not load memory initializer ./libsass.js.mem

Interesting. At this point we can't XHR the file to inject it into the Worker instance as a blob, because libsass.js.mem is loaded relative to the worker path. In earlier versions emscripten required us to work with a separate mem file because of the emterpreter - but this is no longer the case. Once get around to taking another look at #40, we can get rid of the mem file and see what we can do about the blob.

the webworker and the mem file should be injected from extern for resolve this problem.
This is an example for using pdf.js with a blob worker.
http://colonelpanic.net/2014/08/using-pdf-js-web-worker-cross-domain-cors/

I've just released 0.9.5, which inlines the memory file. This means there's only one file left that's loaded in the worker: dist/sass.worker.js. You should now be able to load that file via XHR, make it a blob-url and pass that to new Sass('<your-worker-blob>').
I'm not sure about baking this into sass.js itself. I'd have probably used the fetch API and required the implementor to load a polyfill for non-supporting browsers. But since you can do this externally, I did not include it in 0.9.5.

@francescoagati does this problem still exist?

@rodneyrehm Hi, stumpled over your project and would like to use it in an angular2 application using angular-cli and it's preconfigured webpack-configuration. Sync. version of the project works like a charm, but well, i would rather like to have the compilation run async. To get the async. version running i have to load the worker file, but the angular-cli only outputs one 'vendor.cachebustinghash.js' file for all imports and therefore i can't set a relative path to the worker-file - as i would have to import it to which would include it into vendor.cachebustinghash.js too... is their a possibility to set the worker-import directly instead of defining the path. Like:
import Sass from 'sass.js/dist/sass.sync';
import * as SassWorker from 'sass.js/dist/sass.worker.js';
  constructor() {
    console.log( 'SASS CONSTRUCTOR' );
    Sass.setWorker( SassWorker );
    this.$sass = new Sass( );
 }
Tought this sounded related to this question.
Thx in advance and all the best, Florian

@FloNeu there are ways to serialize a function to run as a worker, maybe that's a viable approach for you if you can load sass.worker.js as a string?

Well, that looks promising - thanks for your response, didn't know about that methods - highly appreciate it, will get back to you if i can make it work...

I write the error message to improve SEO of this answer.
sass.js:94 Uncaught DOMException: Failed to construct 'Worker': Script at 'https://cdnjs.cloudflare.com/ajax/libs/sass.js/0.11.0/sass.worker.js' cannot be accessed from origin 'null'.
    at new Sass (https://cdnjs.cloudflare.com/ajax/libs/sass.js/0.11.0/sass.js:94:18)

<script src="https://cdnjs.cloudflare.com/ajax/libs/sass.js/0.11.0/sass.js"></script>

<script>
  var sass = new Sass();
  var scss = '$someVar: 123px; .some-selector { width: $someVar; }';
  sass.compile(scss, function(result) {
    console.log(result);
  });
</script>


getaddrinfo EAI_AGAIN graph.microsoft.com

Hi,
We have AzureAd-LDAP-wrapper 2.0.2 running on Container with DSM 7.2.1-69057 Update 5.
The logs of the container shows a graph error: "getaddrinfo EAI_AGAIN graph.microsoft.com".
This seems to be linked to a problem with the DNS.
The logs:
graphErrorDetail: null 2024/07/10 14:02:30	stdout	  error: 'getaddrinfo EAI_AGAIN graph.microsoft.com', 2024/07/10 14:02:30	stdout	  opts: {}, 2024/07/10 14:02:30	stdout	  endpoint: "https://graph.microsoft.com/v1.0/users?$count=true&$select=businessPhones,displayName,givenName,jobTitle,mail,mobilePhone,officeLocation,preferredLanguage,surname,userPrincipalName,id,identities,userType,externalUserState,accountEnabled&$filter=userType%20eq%20'Member'%20and%20companyName%20ne%20null%20and%20assignedLicenses%2F%24count%20ne%200", 2024/07/10 14:02:30	stdout	ERROR: 2024-07-10T12:02:30.011Z:  graph.fetch.js callApi error with { 2024/07/10 14:02:22	stdout	WARN: 2024-07-10T12:02:22.032Z:  graph.fetch.js getGroups() no groups found 2024/07/10 14:02:22	stdout	}
Any idea to fix this ?
Thanks
Etienne

Do you use a proxy or something similar in your network?
If not: maybe it's enough to just set a dns server like this:

Thank you for the response, I really appreciate your work.
I'm still in the observation phase but I think I've found the solution. Of course, i started by changing the DNS of the Synology by testing with <IP_ADDRESS> without improvements.
I read on some forums that the node version could influence this error. so I changed "NODE_VERSION" parameters from 18.17.0 to 22.4.1. So far no errors, knock on wood.
Have a good day!
Etienne

Thanks for the feedback, I'll update the nodejs version used in the dockerfile with one of the next updates :)


The middleware now returns a new promise to allow for chaining.

This should take care of issue #7.

Any thoughts on this @svrcekmichal ?

@nmaves hi finally I have time to review, I've been quite busy lately.

what's the argument for returning { payload, meta: { ...responseMeta }, action: newAction } or error value respectively? I believe returning just new action object is enough, because every one can create config to set what he need there

If error is instance of Error, what should happened? There will be unfinished promise waiting for resolve in memory forever.

result of client.request(...).then(...) is Promise, so why not use this one and create new? You can do return Promise.reject(newAction) in error handler or just return newAction in success handler and you will have the same functionality

I was just trying to remain consistent with what your middleware already was returning.  I don't have a problem just returning the resolution action on success.

Good catch, but I am not sure why we are checking for a type of Error.  Do we really need this check?

I am not sure what you are thinking here but maybe a code example might clear things up for me.

To remain consistent, you should return newAction, because if you return { payload, meta: { ...responseMeta }, action: newAction } you are sending payload in .payload and .action.payload and you are sending all meta in .meta and .action.response. So it's all duplicate. Please, just return newAction object, this way everyone who will change onSuccess or onError handler in config will stay consistent with whatever he want

It's from axios documentation of handling errors. Maybe we can use something, for me this was the fastest solution and maybe not so good. I will try to check how other middlewares handle errors. Maybe we can just send this error and make user resolve it later or just create new config options which will know how to handle this errors. User will be than able to pass function like this:

e => process.env.NODE_ENV !== 'production' ? console.log(e) : Raven.captureException(e) // for xample if project use sentry

You don't need to create new promise

const promise = somePromise().then(function(response){
  //do whatever you want;
  return response;
}, function(error) {
  //do whatever you want;
  return Promise.reject(error);
})

If you do it this way, you can use promise.then(...) anywhere you want, you don't need to do:
return new Promise((resolve,reject)=>{
  const promise = somePromise().then(function(response){
    //do whatever you want;
    resolve(response);
  }, function(error) {
    //do whatever you want;
    reject(error);
  })
})

I have updated per your suggestions.  The only thing I was unsure about was the rejection with the fatal axios error.  I don't like that we have two different objects being rejected.

I have created issue #10 . Please, if you have time make a little review, if you will be okay, I will create PR with that. I believe this solves the last issue. According to default action change, I would again suggest to return newAction from middleware, because it has information about current response and action which trigger this new action

Michal, I have updated the middleware.js to reflect your suggestions.  I will be away on holiday for the next week but I will check back in when I can.

@nmaves Enjoy your holiday. I have published package with version 1.0.0-rc.0 in case there's some bug ... you can check it out 👍


Unable to change hotkey

Describe the Bug
I would like to change the hotkey, but i'm unable to do so. How can I change the hotkey?

fixed in https://github.com/Kryeit/Missions/commit/7506b6b75e0ae7d2138ff4c3b782eb0983ad3a76


ci: added github action build/release workflow

Should we remove the double items from circle? Or you want to clean that up in another PR?

Should we remove the double items from circle? Or you want to clean that up in another PR?

Circle ci is removed in a separate pr when all functionality has been moved to gha


CRS.datum.to_epsg() segfaults

I am creating a CRS for EPSG:31370 (https://epsg.io/31370), and accessing the datum gives again a CRS object, but then accessing the to_epsg method of it gives a segfault:
In [1]: import pyproj

In [2]: pyproj.__version__
Out[2]: '2.1.2'

In [3]: crs = pyproj.CRS.from_epsg(31370)

In [4]: crs
Out[4]:
<CRS: epsg:31370>
Name: Belge 1972 / Belgian Lambert 72
Ellipsoid:
- semi_major_metre: 6378388.00
- semi_minor_metre: 6356911.95
- inverse_flattening: 297.00
Area of Use:
- name: Belgium - onshore
- bounds: (2.5, 49.5, 6.4, 51.51)
Prime Meridian:
- longitude: 0.0000
- unit_name: degree
- unit_conversion_factor: 0.01745329
Axis Info:
- Easting[X] (east) EPSG:9001 (metre)
- Northing[Y] (north) EPSG:9001 (metre)

In [5]: crs.datum
Out[5]:
<CRS: DATUM["Reseau National Belge 1972",ELLIPSOID["Inte ...>
Name: Reseau National Belge 1972
Ellipsoid:
- semi_major_metre: 6378388.00
- semi_minor_metre: 6356911.95
- inverse_flattening: 297.00
Area of Use:
- UNDEFINED
Prime Meridian:
- longitude: 0.0000
- unit_name: degree
- unit_conversion_factor: 0.01745329
Axis Info:
- UNDEFINED

In [6]: crs.datum.to_epsg()
Segmentation fault (core dumped)

The proj4 docs say that proj_identify is implemented for GeodeticCRS, ProjectedCRS, VerticalCRS and CompoundCRS (https://proj4.org/development/reference/functions.html#_CPPv313proj_identifyP10PJ_CONTEXTPK2PJPKcPPCKcPPi). So we might need to do a check on the self.projobj first.
There is a proj_is_crs function, but might not be restrictive enough.

Definitely a good catch here. Some better error handling would be appropriate here.

Probably need to check if proj_list is NULL here: https://github.com/pyproj4/pyproj/blob/236538976e3e7193339737ed013c218a5a6d3982/pyproj/_crs.pyx#L523


solution: add balance to token selector

Codecov Report

Merging #1217 (f492eb1) into master (5cdc256) will increase coverage by 0.02%.
The diff coverage is n/a.

:exclamation: Current head f492eb1 differs from pull request most recent head 9e4535a. Consider uploading reports for the commit 9e4535a to get more accurate results

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
+ Coverage   37.19%   37.21%   +0.02%
==========================================
  Files         412      412
  Lines        9525     9525
  Branches     1759     1636     -123
==========================================
+ Hits         3543     3545       +2
- Misses       5707     5965     +258
+ Partials      275       15     -260

Impacted Files
Coverage Δ

src/transaction/CreateTx/CreateTx.tsx
52.87% <0.00%> (-3.38%)
:arrow_down:

src/Asset.ts
38.88% <0.00%> (ø)

src/ethrpc.ts
0.00% <0.00%> (ø)

src/decoder.ts
82.66% <0.00%> (ø)

src/triggers.ts
18.33% <0.00%> (ø)

src/create-store.ts
25.00% <0.00%> (ø)

src/redux-logger.ts
26.92% <0.00%> (ø)

src/ChainListener.ts
0.00% <0.00%> (ø)

src/hwkey/reducer.ts
42.10% <0.00%> (ø)

src/jsonrpc/Batch.ts
56.33% <0.00%> (ø)

... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


DTU Quantitative results

Hi, I recently ran the training code in Generic mode and extract the mesh, then use the scripts
https://github.com/jzhangbs/DTUeval-python to evaluate the Chamfer Distance for 15 test scenes according to the Table 1 of your paper.
However I found the quantitative results I got are worse than those in Table 1, eg:

scan24:   2.2(I got)  VS  1.68(Paper)
scan37:  5.15(I got) VS  3.06(Paper)
scan50:   3.2(I got)  VS  2.25(Paper)

I use --mode val in command line to extract the mesh. In conf file I set the test_ref_view = [23]. In your paper I don't find the ref-view settings in experiment. So maybe you use other pairs.txt in Chamfer Distance test? Can you share some details in your experiment?
Thanks a lot.

Hello. We use two pairs in each scene to do the evaluation.
Before calculating the chamfer distance for all the neural-based methods, we use the input image masks to clean the reconstruction results. This is because for all the neural-based methods, there will be many free surfaces in the background parts. Directly calculating the chamfer distance with ground truth point cloud and comparing it with the SOTA methods doesn't make much sense.
The evaluation input image pairs we used can be downloaded here: https://connecthkuhk-my.sharepoint.com/:u:/g/personal/xxlong_connect_hku_hk/EU22HEv48nRLnnnliRvJNA0BILozsMLbhsnMQh1WZLY5kg?e=Lh7kWM
I will upload the full evaluation code this week.

Hello. We use two pairs in each scene to do the evaluation. Before calculating the chamfer distance for all the neural-based methods, we use the input image masks to clean the reconstruction results. This is because for all the neural-based methods, there will be many free surfaces in the background parts. Directly calculating the chamfer distance with ground truth point cloud and comparing it with the SOTA methods doesn't make much sense.
The evaluation input image pairs we used can be downloaded here: https://connecthkuhk-my.sharepoint.com/:u:/g/personal/xxlong_connect_hku_hk/EU22HEv48nRLnnnliRvJNA0BILozsMLbhsnMQh1WZLY5kg?e=Lh7kWM
I will upload the full evaluation code this week.

Hi, @flamehaze1115 ,thanks for your reply.

I have noticed the testing dataset has set0 and set1. What's the difference between them? Maybe set0 corresp. lod0, set1 corresp. lod1? Or just select the best result in set0 and set1?
the image mask files in testing dataset how to use?  shall we have other evaluation  scripts to utilize the image mask files？

@flamehaze1115
Sorry to bother you, but where is the full evaluation code?
Thanks a lot.

@jerryxu9905 HI, guys, I meet the same problem. Did you solve it?
The results of my run is bad, the details can be found in this.
Can you offer some suggestions?


Change text definitionintratelencepalic-projecting glutamatergic neurons in CL. Consider including their morphological and transcriptomic characteristics and just insert the layer of origin in the "comment" section

Change text definition for intratelencepalic-projecting glutamatergic neurons in CL. Mention transcriptomic distinction, include morphological and electrophysiological definition where possible, mention soma location where possible. Add standard transcriptomic reference data from CellxGene census.

I will review the text definition for the CL terms listed below and see if I can include more morphological, electrophysiological, transcriptomic informations. In the comment section, I will mention that historically these cells were defined based on their layer positioning, but this definition has changed with transcriptomic informations.
This is the list of CL terms:
L2 intratelencephalic projecting glutametergic neuron
L2/3 intratelencephalic projecting glutamatergic neuron
L2/3 intratelencephalic projecting glutamatergic neuron of the primary motor cortex
L3 intratelencephalic projecting glutamatergic neuron
L4 intratelencephalic projecting glutamatergic neuron
L4/5 intratelencephalic projecting glutamatergic neuron
L4/5 intratelencephalic projecting glutamatergic neuron of the primary motor cortex
L5 intratelencephalic projecting glutamatergic neuron
L5 intratelencephalic projecting glutamatergic neuron of the primary motor cortex
L6 intratelencephalic projecting glutamatergic neuron
L6 intratelencephalic projecting glutamatergic neuron of the primary motor cortex
L6 intratelencephalic projecting Car3 glutamatergic neuron
L6 intratelencephalic projecting glutamatergic neuron of the primary motor cortex
L2/3 bipolar vip GABAergic interneuron (Mmus)
L5 vip GABAergic interneuron (Mmus)
L2/3 bipolar vip GABAergic interneuron (Mmus)
L5/6 cck, vip GABAergic interneuron (Mmus)
L5/6 near-projecting glutamatergic neuron
Another point to consider:
the SST IT GABAergic cortical interneurons have in their text definition and in their cell label a specific link to Mmus (Also the VIP neurons mentioned above). Is it worth considering revising these definitions to see if there can be a universal definition encompassing also Homo sapiens and other primates?
These are the cells:
L2/3/5 fan Martinotti sst GABAergic interneuron (Mmus)
L4 sst Martinotti interneuron (Mmus)
L5 non-Martinotti sst GABAergic interneuron (Mmus)
L5 sst T-Martinotti interneuron (Mmus)
L5/6 non-Martinotti sst GABAergic interneuron (Mmus)
L6 th sst GABAergic interneuron (Mmus)

TEXT DEFINITIONS TO CHANGE
Main points:

I haven't been able to find enough informations about L2 IT and L3 IT neurons, nowadays all the papers refer as L2/3 neurons expect for the hippocampal paper. I am not sure whether we should consider to define these terms as obsolete.
NTR -> L2 marginal neurons, L2MNs (https://www.frontiersin.org/articles/10.3389/fnana.2017.00115/full)
For the L2/3 IT motor cortex neuron, the reference paper does not have the data on CxG. however this other paper references to the primary motor cortex L2/3 neurons, we could include this as a reference and also include their transcriptomic signature which is mentioned in the paper perhaps?
L4 IT neurons are quite complex, require some more work for their definition

L2 intratelencephalic projecting glutametergic neuron
Old definition:
A transcriptomically distinct intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 2 in the Mmus. The standard transcriptomic reference for this cell type can be found in the CellxGene census under the collection: "A taxonomy of transcriptomic cell types across the isocortex and hippocampal formation", dataset: "Single-cell RNA-seq for all cortical & hippocampal regions (10x)", Author Categories: "subclass_label",  L2 IT ENT EN, L2 IT ENTm EN.
L2/3 intratelencephalic projecting glutamatergic neuron
Old definition:
An intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 2/3.
New definition:
A transcriptomically distinct intratelencephalic-projecting glutamatergic neuron with a soma found between cortical layer 2-4. This intratelencephalic-projecting glutamatergic neuron has thin-tufted apical dendrites and extends its axonal projection into L5 in the neocortex. This neuronal type has a hyperpolarised resting membrane potential. The standard transcriptomic reference data for this cell type can be found on the CellxGene census under the collection: "Transcriptomic cytoarchitecture reveals principles of human neocortex organization", dataset: "Supercluster: IT-projecting excitatory neurons", Author Categories: "CrossArea_cluster", clusters L2/3 IT_1-6.
https://www.nature.com/articles/nn.3917#Tab2
Comment:
Hystorically, the L2/3 intratelencephalic projectic glutametergic neuron was known to have its soma in cortical layer 2/3. MERFISH data showed that this intratelencephalic-projecting glutametergic neuron can have its soma in layer 2/3, 4B, 4C. The position of the soma in layer 4b and 4C is less frequent for this neuronal type in comparison to cortical layer 2/3.
L2/3 intratelencephalic projecting glutamatergic neuron of the primary motor cortex
Old Definition
An intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 2/3 of the primary motor cortex.
New defintion:
A transcriptomically distinct intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 2/3 of the primary motor cortex. The standard transcriptomic reference for this cell type can be found in the CellxGene census under the collection "An integrated transcriptomic and epigenomic atlas of mouse primary motor cortex cell types", dataset: "An integrated transcriptomic and epigenomic atlas of mouse primary motor cortex cell types", Author_categories: "BICCN_subclass_label", L2/3 IT.

L3 intratelencephalic projecting glutamatergic neuron

Old definition:
An intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 3.
New definition:
A transcriptomically distinct intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 3. The standard transcriptomic reference for this cell type can be found in the CellxGene census under the collection: "A taxonomy of transcriptomic cell types across the isocortex and hippocampal formation", dataset: "Single-cell RNA-seq for all cortical & hippocampal regions (10x)", Author Categories: "subclass_label",  L3 IT ENT.
[L4 intratelencephalic projecting glutamatergic neuron](L4 intratelencephalic projecting glutamatergic neuron)
Old definition:
An intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 4.
New Definition:
A transcriptomically distinct intratelencephalic-projecting glutamatergic neuron with a soma found in cortical layer 3-4. This neuron type can have a pyramidal, star-pyramidal or spiny stellate morphology and projects its output to L2/3 and L5A/B. The reference for this neuron type

@aleixpuigb @dosumis Please review when you can :)
and I will turn this ticket into a PR.

I think this is a good start.
Some thoughts:

For all transcriptomic references  we should generate taxonomies from datasets & use the cell set IDs from these to generate formal links to the reference cell sets in the ontology.
For CL this should be restricted to a small set of agreed reference datasets, but we can be broader in PCL (as we already are)
We need to discuss whether we can/should reference multiple cells sets in a definition (we don't have formal linking mechanisms to cover this right now.

For CL, I think we need to concentrate on cell types defined in Jorstad for now (crossArea_subclass)
e.g. => something like
A transcriptomically distinct near-projecting glutamatergic neuron with a soma found in cortical layer 5/6. The standard transcriptomic reference data for this cell type can be found on the CellxGene census under the collection: "Transcriptomic cytoarchitecture reveals principles of human neocortex organization", dataset: "Supercluster: Deep layer (non-IT) excitatory neurons", Author Categories: "CrossArea_subclass", L5/6 NP.
(But we may also be able to add NS-Forest markers.

Dear David,
Thanks for your comments!

For all transcriptomic references we should generate taxonomies from datasets & use the cell set IDs from these to generate formal links to the reference cell sets in the ontology.

Waiting to see what Jason and Brian say

For CL this should be restricted to a small set of agreed reference datasets, but we can be broader in PCL (as we already are)
We need to discuss whether we can/should reference multiple cells sets in a definition (we don't have formal linking mechanisms to cover this right now.

Agreed, I think we need to run some bioinformatics analysis and justify why we believe those cell types can be referenced by two datasets. We could consider to use one dataset as the main reference in the text definition and have additional dataset where the cell types also appears in the comment section.
For the Analysis I suggest running an integration across the two datasets and a person correlation to see how transcriptomically related the same cell type is across the two datasets.

For CL, I think we need to concentrate on cell types defined in Jorstad for now (crossArea_subclass)

For now, I will add on CL the new text definitions for Jorstad crossArea_subclass cell types. I will turn this into a PR.
Best,
Alida

We need to discuss whether we can/should reference multiple cells sets in a definition (we don't have formal linking mechanisms to cover this right now.

Agreed, I think we need to run some bioinformatics analysis and justify why we believe those cell types can be referenced by two datasets. We could consider to use one dataset as the main reference in the text definition and have additional dataset where the cell types also appears in the comment section. For the Analysis I suggest running an integration across the two datasets and a person correlation to see how transcriptomically related the same cell type is across the two datasets.

We have some experience using a computational approach call FR-Match, to link cell types together from multiple datasets.  There are a couple of other tools developed by other groups for doing this as well.  Here's a link to our paper, where we compare how they perform - https://www.nature.com/articles/s41598-022-14192-z

For the Analysis I suggest running an integration across the two datasets and a person Pearson correlation to see how transcriptomically related the same cell type is across the two datasets.

We have some experience using a computational approach call FR-Match, to link cell types together from multiple datasets.

Let's see if we have resources. This could be a good place we could collaborate.  Scores could be very useful to add to CL-KG.


feat: Support non-browser requests for development/staging environments

Type of change

[ ] 🐛 Bug fix (non-breaking change which fixes an issue)
[x] 🌟 New feature (non-breaking change which adds functionality)
[ ] 🔨 Breaking change (fix or feature that would cause existing functionality)
[ ] 📖 Docs change / refactoring / dependency upgrade to change)

Description
For development/staging environments, try to detect if that's a non-browser request (e.g. script) based on the request User Agent and prevent interstitial rendering
Related Issue (optional)
#35

@chanioxaris shall we include the fix for treating the empty auth header as logged out?


Timezone dropped from JU_GetISO8601TimeStamp()

In order to fulfill ISO8601 the timezone needed to be removed from the timestamp.
closes #25

Additionally the comment above the function was updated.


Pitch adjustment

Hello, great plugin!
Is it possible to add Pitch adjustment?
With this functionality you will be able to simulate the voices of multiple characters.
Thanks in advance.

Pitch support was added in #5 (tts.set_pitch(float)). Available range and granularity depends on OS and voice (quite small difference on Windows, a bit bigger on macOS, not tested on Linux).


All user to set user data on Scan, include in log messages on server side

Create an api method, like ScannerOptions.setUserData(String), that will allow the user to set a unique id or some other data on the scan that will allow them to correlate scan messages across servers and clients. The user data should be included in all scan msgs and exceptions.

Could possibly show this information in the list scans shell command output and on the monitor also.


[Bug] Inconsistency caused by 65535f16*0f16 after using compute_inline

TENSOR_0 = te.compute([14], lambda rck:te.max_value("float16")*te.min_value("uint16"), name ="TENSOR_1")
TENSOR_1 = te.compute([11], lambda oco:te.max_value("uint16")*TENSOR_0[oco], name ="TENSOR_2")

The tir program before compute_inline:
@main = primfn(TENSOR_1_1: handle, TENSOR_2_1: handle) -> ()
  attr = {"from_legacy_te_schedule": True, "global_symbol": "main", "tir.noalias": True}
  buffers = {TENSOR_1: Buffer(TENSOR_1_2: Pointer(float16), float16, [14], []),
             TENSOR_2: Buffer(TENSOR_2_2: Pointer(float16), float16, [11], [])}
  buffer_map = {TENSOR_1_1: TENSOR_1, TENSOR_2_1: TENSOR_2}
  preflattened_buffer_map = {TENSOR_1_1: TENSOR_1_3: Buffer(TENSOR_1_2, float16, [14], []), TENSOR_2_1: TENSOR_2_3: Buffer(TENSOR_2_2, float16, [11], [])} {
  for (rck: int32, 0, 11) {
    TENSOR_1[rck] = 0f16
  }
  for (oco: int32, 0, 11) {
    TENSOR_2[oco] = (65535f16*TENSOR_1[oco])
  }
}

The tir program after compute_inline:
@main = primfn(TENSOR_1_1: handle, TENSOR_2_1: handle) -> ()
  attr = {"from_legacy_te_schedule": True, "global_symbol": "main", "tir.noalias": True}
  buffers = {TENSOR_1: Buffer(TENSOR_1_2: Pointer(float16), float16, [14], []),
             TENSOR_2: Buffer(TENSOR_2_2: Pointer(float16), float16, [11], [])}
  buffer_map = {TENSOR_1_1: TENSOR_1, TENSOR_2_1: TENSOR_2}
  preflattened_buffer_map = {TENSOR_1_1: TENSOR_1_3: Buffer(TENSOR_1_2, float16, [14], []), TENSOR_2_1: TENSOR_2_3: Buffer(TENSOR_2_2, float16, [11], [])} {
  for (oco: int32, 0, 11) {
    TENSOR_2[oco] = 0f16
  }
}

Actual behavior
AssertionError:
Not equal to tolerance rtol=1e-05, atol=1e-07

x and y nan location mismatch:
 x: array([nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan],
      dtype=float16)
 y: array([0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.], dtype=float16)

Environment
Operating System: Ubuntu 18.04, TVM version: tag0.9.0 [d361585]
Steps to reproduce
import os
import numpy as np
import tvm
from tvm import te, auto_scheduler, topi
import tvm.testing

TENSOR_0 = te.compute([14], lambda rck:te.max_value("float16")*te.min_value("uint16"), name ="TENSOR_1")
TENSOR_1 = te.compute([11], lambda oco:te.max_value("uint16")*TENSOR_0[oco], name ="TENSOR_2")
s = te.create_schedule(TENSOR_1.op)
tensor_list = [TENSOR_0,TENSOR_1]

dev = tvm.cpu(0)
pre_list = []
after_list = []
for tensor in tensor_list:
    shape = [x.value if 'value' in dir(x) and isinstance(x.value, int) else 1 for x in tensor.shape]
    params = (5*np.random.uniform(size=shape)).astype(tensor.dtype)
    pre_list.append(tvm.nd.array(params.copy(), dev))
    after_list.append(tvm.nd.array(params.copy(), dev))

pre_mod = tvm.lower(s, tensor_list, simple_mode=True)
with tvm.transform.PassContext(opt_level=4):
    f = tvm.build(pre_mod)
f(*pre_list)

s[TENSOR_0].compute_inline()

now_mod = tvm.lower(s, tensor_list, simple_mode=True)
with tvm.transform.PassContext(opt_level=4):
    f = tvm.build(now_mod)
f(*after_list)

tvm.testing.assert_allclose(pre_list[1].numpy(), after_list[1].numpy(),rtol=1e-5)

@cxx122 Thanks for the report. It seems you are trying to compute "65535f16 * 0f16" which returns "nan" as an undefined behavior.

Since its output is "nan" and according to IEEE 754 that "nan" is not comparable, I don't think it is suitable to regard this as an inconsistency bug since the computation itself is ill-formed and undefined. From a fuzzing prespective, IMO, those should be regarded as false alarms that the algorithm should try to avoid sythesizing programs with undefined behaviors.

Similarly in many rest bugs reports, as opt_level=4 is specified which indicates fast math optimization, it is highly possible to have those numerical "inconsistency" when the computation is not well-formed.

Thanks, when I submitted this bug I also considered that it might be because of this problem. This may not be a bug in the strict sense.

Actually there is no "65535f16", should be nan because it exceeds maximum of fp16, it seems to be an issue in literal construction and constant folding.

@wrongtest-intellif Good point. "65535f16" is actually inf. But inf * 0 gets us a nan. :-)


Fix #1011 Non-localized stablecoin type

Fix #1011 Non-localized stablecoin type
add-liquidity.tsx

use collateral type to key into localization file

dayjs-locale-es.js

update to Day.js locale object as detailed in docs

dayjs-locale-ko.js

same as above

es.json

add stablecoin type translation

_app.tsx

set locale object for day.js localization as detailed in docs

Would like a sanity check that this is the way to go for the above solutions. If so, I can update all the localization json specific to day.js, but will need additional translations for stablecoin types to add to general localization files.
Could not replicate bug of "Unbonded" not being translated, although it's wrapping in certain languages.

also included fix for a key error in the Connect Wallet Modal


GPIOs for PIR and button and temperature sensor should be configureable

Add to both config files and use the config in initialization of PIR, button and dsb18b20 temperature sensor.

Hi, I'd like to contribute to this project. What is the starting point regarding this issue?

In util/button.js and util/motion.js the GPIOs are hard coded. Those should use values specified in the config files instead

@wildan3105  you still doing this ?  Let me know .


Update NuttX apps side

Summary
Need to pull a few patches for px4 kernel mode
Impact
Let's hope it is nothing (well, you never know). The changes look safe enough.
Testing
On my desk with px4 kernel mode build

No need for this PR; we don't have any own fixes on top of the apps, so you can just push the head of the upstream master to out branch master, and make a pr to update the submodule hash in px4 repo.

No need for this PR; we don't have any own fixes on top of the apps, so you can just push the head of the upstream master to out branch master, and make a pr to update the submodule hash in px4 repo.
I mean that there is nothing to really review, so it is better to just push.. This also keeps the hashes the same as in upstream master.

Sure, I'll point to the upstream head instead


[iOS] Tron never logs ComponentWillUnmount when killing app

Hey there! Ignite CLI seems to be having a problem, eh?
Welllllll, it just might be. First, search the issues to make sure it's not already
here, and if not head over to http://community.infinite.red to
get some help. If you've identified that it's really an Ignite CLI issue, then:

Explain what's going on and preferably how to replicate the issue (bonus points for a repro app)
Run ignite doctor and paste the result below, including the lines with 3 backticks
Delete these instructions! We don't want to look at them. ;)

What's going on?
create new project using ignite boilerplate, put console.tron.log in ComponentWillUnmount.
Display the log properly when running on android but never show on iOS.

Steps to reproduce

ignite doctor results:
JavaScript
node               9.11.0
npm                5.8.0
yarn               1.6.0
React Native
react-native-cli   2.0.1
app rn version     0.51.0
Ignite
ignite             2.0.0
iOS
xcode              9.3

@Yusiro85 I believe this is an issue with React Native itself. I've never been able to use unmounting functions in the app shutdown case. I think React Native would need to be extended in order to support shutdown callback functions.


Added blog post

I think we should add a picture of the group, but let's not let that hold it up, we can edit it later.


fix: handling of back tap in select products list screen

What

On back gesture, Instead of moving back to previous tab, select product screen now gets popped off and fields are reset.

Screenshot
https://user-images.githubusercontent.com/55742309/190456605-ba983d71-8e35-46e7-90c5-3eb66178d19b.mp4
Fixes bug(s)
#2986

Besides that @anshpathania7 are you participating in tomorrows hackathon, if so I'd say we leave this PR open for that.

@M123-dev which hackathon? I am not aware of any.

@M123-dev which hackathon? I am not aware of any.

There is this grace hopper celebration going on 16th September for female candidates, if you fit u could probably check it out

Oh, I don't think I am eligible for that hackathon :p

For some reason the formatting tests are failing, you can automatically fix this by running flutter format .

Could you revert the changes to the device_preview as well as in the gradle.properties, besides that everything looks great now ✅

Done, Reverted the changes.

Though this issue was for the grace hopper celebration, and I see no other people working on this one, perhaps we could make an exception here, and merge this, even if it's not from from some participating in grace hopper

Congrats on your first PR here 🎉


[FEATURE] update Demo notebooks to include the required packages

Each of the demo notebooks have several requirements that aren't part of the requirements[-dev].txt. can we consider to include required packages to run the notebooks to be part of the notebooks?
Example:
Notebook -  demo_transformer_model_train_save_upload_to_openSearch
Above notebook has several dependencies like boto3, datasets, detoxity, rich. Including them in a cell at the start of the notebook can make it easier to use the notebooks

Or would it be weird to have a requirements-notebooks.txt? That way the installation of them could be a one-liner. We could put it in the folder with them as well.

@dtaivpp, that might become a problem when someone is directly using documentation website.

I just realized that the required packages are already mentioned in the notebooks. The one in my local, i accidentally deleted the cell which has the command to install extra dependencies.


python2 and python3: build unoptimized bytecode again

In 9d03ff52229f36ff4b4e9d0ee2db4a46b90512bb I made the CPython builds reproducible. This required not generating default unoptimized bytecode. I was under the impression the optimized bytecode would be used then, but you need to opt-in on that. Not having the default bytecode resulted in a significant performance hit. Therefore, bytecode is generated again in this commit, and thereby the builds are no longer reproducible.
https://bugs.python.org/issue29708

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Not having the default bytecode resulted in a significant performance hit.

I don't remember where, but indeed I read somewhere that the change in #107965 caused downstream projects to recompile the python stdlib basically every time it's used, since it wouldn't use the optimized ones without flags and couldn't save the compiled ones.
That indeed sounds like an obvious significant performance hit (even without seeing numbers), so as much as I'd like to have python reproducible, it sounds reasonable to merge this and keep looking for another solution.
How do other distributions solve this? Perhaps they don't ship the compiled artifacts, but are more lenient in allowing writing them somewhere when they're first compiled? Or don't they have reproducible python packages either? https://ismypackagereproducibleyet.org/?pkg=python&query=query suggests OpenSUSE has a reproducible python package, but I haven't investigated what's in there yet.

for what it's worth, I pulled this PR and built it on two different architectures:
model name	: Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
model name	: AMD Ryzen 7 5800X 8-Core Processor

and I got:
$ nix-build . -A python37
/nix/store/j7i1899n9bszm3lchg5az4d5zg56imw5-python3-3.7.10
$ nix-store --dump $(nix-build . -A python37) | md5sum
52dc7b6e6218c89321b14f7da8424721  -

On both.

Python 3.7 and up pyc files should be reproducible: https://www.python.org/dev/peps/pep-0552/

Python 3.7 and up pyc files should be reproducible: https://www.python.org/dev/peps/pep-0552/

No, they are not. There is still an upstream issue. The PEP only covers the header.

Does setting PYTHONHASHSEED do anything? Or was that already attempted?

Does setting PYTHONHASHSEED do anything? Or was that already attempted?

That's already being taken care off.
I don't want to be dismissive to help but all that's keeping us from fully reproducible builds is an upstream bug: frozensets lose order when serialized.

all that's keeping us from fully reproducible builds is an upstream bug: frozensets lose order when serialized

Cool, I wasn't aware this was pinned down yet! So this is https://bugs.python.org/issue37596 ?

Cool, I wasn't aware this was pinned down yet! So this is https://bugs.python.org/issue37596 ?

Correct!

Backported as c32a9d41585cdade9bc7c06949703e8ae15b82d5 to staging-21.05.

How do other distributions solve this? Perhaps they don't ship the compiled artifacts, but are more lenient in allowing writing them somewhere when they're first compiled?

Debian compiles them in a post-installation script afaik.

I was under the impression the optimized bytecode would be used then, but you need to opt-in on that.

Could you elaborate on how this "opt-in" works?

I was under the impression the optimized bytecode would be used then, but you need to opt-in on that.

Could you elaborate on how this "opt-in" works?

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#optimizations-optimizations
final: prev:
let
  opimizedPython = mypython: prev."${mypython}".override {
    enableOptimizations = true;
    reproducibleBuild = false;
    self = opimizedPython mypython;
    pythonAttr = mypython;
  };

  overridePython = mypython:
    if builtins.hasAttr "reproducibleBuild" prev."${mypython}".override.__functionArgs then
      opimizedPython mypython
    else
      prev."${mypython}";
in
{
  # python27 = overridePython "python27";
  # # python34 = overridePython "python34";
  # # python35 = overridePython "python35";
  # python36 = overridePython "python36";
  # python37 = overridePython "python37";
  # python38 = overridePython "python38";
  # python39 = overridePython "python39";
  # python310 = overridePython "python310";
}

@SuperSandro2000 Thanks! But I'm still confused about the relation between --enable-optimizations for Python itself and optimized bytecode; AFAIK you can use the latter w/o the former.

Could you elaborate on how this "opt-in" works?

Run the interpreter as python3 -O for opt-1 and python3 -OO for opt-2. Note things can break. --enable-optimizations is orthogonal to the bytecode optimizations.

Could you elaborate on how this "opt-in" works?

Run the interpreter as python3 -O for opt-1 and python3 -OO for opt-2. Note things can break.

@SuperSandro2000 Thanks! But I'm still confused about the relation between --enable-optimizations for Python itself and optimized bytecode; AFAIK you can use the latter w/o the former.

--enable-optimizations is orthogonal to the bytecode optimizations.

Thanks! That matches what I know.
So do I then understand correctly that when not expliticly using -O (or -OO) no bytecode will be used at all?
And that, because of this, the decision was made to generate the (unreproducible) default bytecode after all?
And that making -O the default (somehow) is not an acceptable/workable solution?

Correct entirely.
On Fri, 30 Jul 2021, 22:10 Felix C. Stegerman, @.***>
wrote:

Could you elaborate on how this "opt-in" works?
Run the interpreter as python3 -O for opt-1 and python3 -OO for opt-2.
Note things can break.
@SuperSandro2000 https://github.com/SuperSandro2000 Thanks! But I'm
still confused about the relation between --enable-optimizations for Python
itself and optimized bytecode; AFAIK you can use the latter w/o the former.
--enable-optimizations is orthogonal to the bytecode optimizations.
Thanks! That matches what I know.
So do I then understand correctly that when not expliticly using -O (or
-OO) no bytecode will be used at all?
And that, because of this, the decision was made to generate the
(unreproducible) default bytecode after all?
And that making -O the default (somehow) is not an acceptable/workable
solution?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/120858#issuecomment-890128354, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQHZ37X4IYAR5QA2YKR6O3T2MBMVANCNFSM43U4EHUA
.


Fix invalid cast exception for /v command

Assets.find(EAssetType.VEHICLE, id) can now return VehicleRedirectorAsset introduced in <IP_ADDRESS> update

It works fine, I also tested this in game


chore: do not escape strings in snapshots

Summary
Makes the snapshots easier to read (without requiring external jest-snapshot-serializer-raw)

Test plan
Green CI

Codecov Report

Merging #12303 (efbcfe2) into main (5f63582) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12303      +/-   ##
==========================================
- Coverage   67.29%   67.29%   -0.01%
==========================================
  Files         329      329
  Lines       17336    17336
  Branches     5074     5074
==========================================
- Hits        11667    11666       -1
- Misses       5637     5638       +1
  Partials       32       32

Impacted Files
Coverage Δ

packages/expect/src/utils.ts
96.09% <0.00%> (-0.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f63582...efbcfe2. Read the comment docs.


feature: 加一个返回链接

Is your feature request related to a problem? Please describe.
无法返回上级目录
Describe the solution you'd like
加一个返回链接
Describe alternatives you've considered
NULL.
Additional context
NULL.

@tangent-heng Please try your best to add this feature.

I've done


Update hacktoberfest-template.md

Added language RE: spam solutions and tests to the issue template.

If your pull request as spam, it will not be counted toward your participation in Hacktoberfest.  You can be reported and will be ineligible to participate in Hacktoberfest, as per Digital Ocean's rules.


chore(deps): update common-dev-assets digest to d58f089

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
45f17e6 -> d58f089

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.4.30 :tada:
The release is available on:

GitHub release
v1.4.30

Your semantic-release bot :package::rocket:


Make setup script more robust and idempotent

While doing some development work for a different feature, I kept running into issues with make setup. I'd run it after rebooting my laptop and it would fail, or I'd run it and receive a weird error that I wouldn't be able to reproduce. To address this, I've added more robust error handling and have taken the opportunity to make the script idempotent. You should be able to run make setup on a fully running system and have nothing happen except for the API server and client containers roll.

Hmm. I've signed the CLA, but I must've done something wrong.


Want to Fix Dark mode text-vviblity issue

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'dark mode'

See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I would like to work on this issue, please assign this issue to me under GSSoC'24 @abhay-raj19 .


Validation for every user action should be light weight

Right now every user action on atlasmap UI invokes /mapping/validate which is full validation for the entire mapping. This would soon slow down the UI with bigger real mappings. We should add single mapping entry level validation for that purpose, and make that full validation as optional.
UX question:
Do we need "Validate" or "Save" button for the full mapping instead of auto saving?

Maybe do a field-level validation from onBlur events?  Or even an explicit validate button in the detail panel perhaps?


Updates stop being sent to client after a few minutes from connecting.

Hello,
I have been getting complaints from users that the client stops receiving updates after a few minutes (around 4 minutes) from connecting. I have seen this happen once with me as well. It is difficult to replicate and happens to some clients but not all.
When I encountered it I opened another client to see if it the server is still sending updates and it was sending updates to the second client. There is no errors nor does the socket gets closed it just doesn't get any updates. Restarting the server seems to resolve the issue temporarily until it starts happening again.
I would appreciate if anyone can give me guidance on how to diagnose this bug. Since it is difficult to reproduce, I am having trouble debugging it.
Notes:

The client that faces this issue will keep facing it even after restarting the client (only restarting the server fixes it for a while).
I am using Deepstream Java v2.2.2 client.

This is using the old protocol v3 with this docker image (deepstreamio/deepstream.io:5.1.8) for the server.
Thanks

I do notice seeing "INFO | Heartbeat missing on websocket, terminating connection" log message a lot more in the newer versions. I don't remember seeing them in older versions of the server.
Also, does socket.destroy() notifies the client the the socket is closed? Or does the client remains open waiting for updates from the server even though the socket is closed on the server side?
I am starting to think this heartbeat mechanism might be the cause behind this bug.

hey!
Thanks for raising this. Unless you're using apple silicon can you see if you can replicate this with 5.1.5? After that most fixes are related to heartbeats and pre v4 versions don't have tests running against it.

I will try the older version of the server (pre 5.1.5) and see how it goes.

I made a quick test for JS client (deepstream.io-client-js ) connecting to the latest version (5.2.3).
The client is using the text v3 protocol.
Here is the setup and what I have observed:

The server has just started with no records or any other connection.
I made a single connection from the JS client.
After one minute (2 heartbeat intervals) the socket was destroyed with the following message:
INFO | Heartbeat missing on websocket, terminating connection
On the client side the socket was not closed and isn't aware that the connection is lost.
I replaced destroy() with close() and the client closed properly and was aware of the disconnection.

It does seems that this new heartbeat implementation is causing issues with older clients that don't have heartbeats or aren't sending pings.

Hi, what's your heartbetInterval on server and on client? And versions for both?

Hello,
The server heartbetInterval interval is the default (30000). For the client I am using the Java client v2.2.2 which doesn't have a setting for heartbetInterval. It does respond to pings from the server though. There server versions I noticed the issue with are 5.1.8 and higher.
Another possibility is that the Java client pong might be slow to reach the server if the socket is very busy sending large amount of packets (or a slow connection). This might be even more true for slower devices (Android). It might explain why some users experience it persistently while others don't.

And which server are you using: node-http or uws ?

node-http

The bug is still occurring with older versions of the server (pre 5.1.5).
I am guessing this rules out it's a heartbeat issue.
It could be something with the Java client. I am seeing the client disconnect in the server log but no connection change event on the client side.

I will close the issue now. I don't believe it is server related.

hey,
Reopening this as the problem is it will happen with all older SDKS, plus development on any prior to v4 sdks is not a thing anymore. Also, heartbeats are dealt with seperately in the test-protocol parser which means it can fixed in server.
@jaime-ez any thoughts?

Well, on the server side the text protocol implementation should send a PING every heartbeatInterval, and the JAVA client should  respond with a PONG. That incoming PONG message to the server should update the lastMessageReceivedAt timestamp and therefore prevent the connection from being closed from the server side. I don't see what could it be, maybe as done for the JS client, the JAVA client should send the PING message to server every heartbeatInterval to prevent this?....those are my 2 cents

yeah i don't have any recollection over the java sdk setup, it was build to be identical to the v2 js client and it wasn't exactly a deterministic client (which did allow it to perform faster). I'll see if I can get a quick idea on the logic, should in theory be the same as the v2 js client.

https://github.com/deepstreamIO/deepstream.io/blob/master/src/connection-endpoint/websocket/text/connection-endpoint.ts#L39
Looks like we send a ping on a timeout instead of in an interval which would result in a heartbeat issue.
@jaime-ez does that make sense?

Edit: Sorry made an incorrect analysis.
@jaime-ez i seem to have come to the exact conclusion as you.
The text protocol sends the ping every x seconds
The java sdk should reply with a pong: https://github.com/deepstreamIO/deepstream.io-client-java/blob/master/src/main/java/io/deepstream/Connection.java#L269
The server then ensures we recieved any message (doesn't have to be a pong)
https://github.com/deepstreamIO/deepstream.io/blob/0175edbac33d5cb6d822240d80ae3096fe1ef861/src/services/http/node/node-http.ts#L138
Generally @redlock what you can try to do is just send a 'heartbeart' event (or any other useless even noone is subscribed to) and see if that still breaks. If it does it means it's the server not running the code properly:
https://github.com/deepstreamIO/deepstream.io/blob/0175edbac33d5cb6d822240d80ae3096fe1ef861/src/services/http/node/node-http.ts#L151
Hope that makes sense.

Hi,
The javascript client (older versions) disconnects from the server after two heartbeats.

Hi, what do you mean by older versions ? I can not reproduce this

The javascript client (older versions) disconnects from the server after two heartbeats.

using server "@deepstream/server": "5.2.3", and client "deepstream.io-client-js": "^2.3.4"
The server sends the ping and the client responds with pong.

@redlock is it possible you have mistmatching heartbeat config?

I was using the /deepstream-v3 endpoint.

Hi @redlock,
Sorry for this out of topic question,
I'm working on a new project where I need a native android app to connect to deepstream server,
I've a deepstream server with no auth running on localhost (default setup),
could you please show me the minimal code required in java to connect to deepstream server.
Thank you,

Hi everyone, I'm going to close this since it's not a server issue and there are no active maintainers for the JAVA sdk. Best of luck figuring it out!


feature(test): add full dns support to host names in test-generator

@aslakknutsen did you have a chance to look at why both e2e_tests jobs are failing?

@bartoszmajsak No, but it might be that the change is kicking in due to how make variables are setup. It's, in that case, exposing #370 :)
I'll have a look


RawFrames not saved on Raspberry PI Bullseye and Windows 11 with indi_pylibcamera driver

On Raspberry Pi Bullseye I have compiled latest version of Astra_Lite 0.0.61 from GitHub.
When I press "Start Save Lights" button RAW frames should be saved to /home/[user]/Astro/RawFrames. But progress indicator always stays at 0 / 10 and no RAW frames are saved.
I have tested with indi_pylibcamera driver and actual Raspberry PI HQ Camera.
Image and log for Raspberry PI OS Bullseye:

astra_lite_2023-05-10_08-17-13.log
On Windows 11 I used latest released precompiled binary 0.0.58.
Image and log for Windows 11:

astra_lite_2023-05-10_08-34-23.txt
Log file on Windows was huge, over 250MB so I've uploaded only part of it.
I have capture frames with front cap covering telescope. Not under real sky. Maybe that the problem?
With indi_simulator_ccd driver and Windows 11 it worked.
Livestacking is not working either. Probably same issue.

Hi, @sajmons
Only pictures that have been quality checked are saved.
Look at light frame history. Starts ovality is red. It means app found several false stars in frames (because you cover telescope with cap) and they are not round. If you to test raw frames saving, just uncheck "Max stats ovality" in "Light frame quality" section

And livestacking works only with real stars because stars are used to align images

@art-den thank you for explination. After unchecking "Max stats ovality" savinf RAW frames did work.
I guess this test will have to wait for clear skies. I will close this issue then.

Hi, @sajmons Only pictures that have been quality checked are saved. Look at light frame history. Starts ovality is red. It means app found several false stars in frames (because you cover telescope with cap) and they are not round. If you to test raw frames saving, just uncheck "Max stats ovality" in "Light frame quality" section

Saving RAW files on Windows 11 don't work after unchecking "Max stats quality". Error in logfile is:
<setNumberVector device="indi_pylibcamera" name="CCD_EXPOSURE" state="Busy" timeout="60">
    <oneNumber name="CCD_EXPOSURE_VALUE">
0.9999237060546875
    </oneNumber>
</setNumberVector>
[2023-05-10 12:05:38.529952 +02:00] ERROR indi_api: 'Malformed XML. 1:1 Unexpected characters outside the root element: w' for XML
wkFCQEJAAkCCP0JAQj+CP4JBAkECP4I/wkHCQkI/gkBCP8JAQkDCP8JAwkCCQIJAwkCCQEJCgkECQAJCQkGCP4JAQkACQMJAgkDCQUJBwkDCQEJAwkACQQI/ "I cut the rest of base64 image"
</oneBLOB>
</setBLOBVector>

Folowed by very large base64 encoded image that I cut away.

It looks like problem with XML parsing from network. I will investigate


Add support for yarn Berry

Fixes #521
@melloware could you give this a try?
Also it should work with yarn berry on the local machine, but the tests are made for yarn 1 installed. I am not sure how we could solve this cleanly since we tests both auto-install and manual.
For auto-install we currently follow MFP until they provide better (https://github.com/eirslett/frontend-maven-plugin/pull/1012#issuecomment-1742613857):
"If your project is using Yarn Berry (2.x or above), the Yarn version is handled per project but a Yarn 1.x install is still needed as a "bootstrap". The plugin will try to detect .yarnrc.yml file in the current Maven project/module folder, at the root of the multi-module project if relevant, and in the folder from which the mvn command was run. If detected, the plugin will assume your project is using Yarn Berry. It will install the 1.x Yarn version you specify with yarnVersion as bootstrap, then hand over to your project-specific version."

I just did a fresh checkout and confirmed all tests pass with mvn clean install !!!!


Feeders push checkpoints even if they are equivalent

The feeder previously short circuited if the witness had already witnessed an equivalent checkpoint. This meant that logs would get stale timestamps from the witnesses. This change makes it so that the witness will keep updating their timestamps on checkpoints.

Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.30%. Comparing base (3c58af4) to head (c57c23a).
Report is 119 commits behind head on main.

Files with missing lines
Patch %
Lines

internal/feeder/feeder.go
0.00%
4 Missing and 1 partial :warning:

:exclamation:  There is a different number of reports uploaded between BASE (3c58af4) and HEAD (c57c23a). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (3c58af4)
HEAD (c57c23a)

4
2

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #283       +/-   ##
===========================================
- Coverage   51.05%   31.30%   -19.75%
===========================================
  Files          11       23       +12
  Lines         903     1757      +854
===========================================
+ Hits          461      550       +89
- Misses        374     1109      +735
- Partials       68       98       +30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add additional checks to detect if operator is running

Add additional checks to detect if operator is running
resolves https://github.com/open-cluster-management/backlog/issues/18566
Signed-off-by: Yu Cao<EMAIL_ADDRESS>

@jnpacker @ch-stark FYI

/hold

@dhaiducek Yeah, I don't think checking subscription status field is enough. I found CSV is more reliable based on my testing. If for some reason the pods are not installed an running, CSV would return phase Failed or Installing. Subscription couldn't show that granularity.

/unhold


Fix rename for MEDS

Summary by CodeRabbit

Bug Fixes

Improved clarity in the renaming process for data results.
Ensured consistent mapping from "subject_id" to "patient_id".

New Features

Added test cases for handling duplicate rows in the extract_subtree function.
Enhanced functionality to maintain data integrity when processing duplicate entries.

Looking into #73

Closing as I added a complete test in #110


Multi plugins not working as result gets overwritten

I need to use @zeit/next-css and @zeit/next-sass at the same time, but this is failing by just using module.exports = withCSS(withSass(...)) as only one type gets compiled.
I'm trying to provide a simple example including the result map to get the issue resolved. I'm referencing to the issues
https://github.com/zeit/next-plugins/issues/34
https://github.com/zeit/next-plugins/issues/69
https://github.com/zeit/next-plugins/issues/58
https://github.com/zeit/next.js/issues/3852
This is a simple example what I'm doing and what the result looks like.
static/styles/style.css
#content {
  font-size: 3rem
}

static/styles/style.sass
#title
  font-size: 1rem

next.config.js
const withCSS = require('@zeit/next-css')
const withSass = require('@zeit/next-sass')

module.exports = withCSS(withSass({
  webpack: (config) => {
    return config
  }
}))

components/Header.js
import Head from 'next/head'
import '/static/styles/style.css'
import '/static/styles/style.sass'

export const Header = props => {
  return (
    <Head>
      <meta httpEquiv='content-type' content='text/html;charset=UTF-8' />
      <meta charSet='utf-8' />
      <title>Title</title>
      <link rel='stylesheet' href='/_next/static/style.css' />
    </Head>
  )
}

The result /.next/static/style.css content is only:
#content {
  font-size: 1rem
}
/*# sourceMappingURL=style.css.map*/

I'm missing the compiled sass file.
If I switch next.config.js to withSass(withCSS({..})) the result is only:
#title {
  font-size: 3rem; }
/*# sourceMappingURL=style.css.map*/

The map for the last one is:
{"version":3,"sources":["/Users/project/static/styles/style.sass"],"names":[],"mappings":"AAAA;EACE,gBAAgB,EAAE","file":"static/style.css","sourcesContent":["#title {\n  font-size: 3rem; }\n\n\n\n// WEBPACK FOOTER //\n// ./static/styles/style.sass"],"sourceRoot":""}

#58 is just another pattern for combining plugins. It gives additional functionality (every plugin has his own config), but it will be useful if #55 will be merged. Then will be easy to create 2 or more style files (for example vendor.css and app.css). And it will not resolve your problem.
Your trouble can be fixed by passing your own extractTextPlugin instance:
const withCSS = require('@zeit/next-css')
const withSass = require('@zeit/next-sass')
const ExtractText = require('extract-text-webpack-plugin')
const commonsChunkConfig = require('@zeit/next-css/commons-chunk-config')

const extractCSSPlugin = new ExtractText('style.css')

module.exports = withCSS(withSass({
  extractCSSPlugin,
  webpack: (config, { isServer }) => {
    config.plugins.push(extractCSSPlugin)
    if (!isServer) {
      config = commonsChunkConfig(config, /\.(sass|scss|css)$/)
    }
    return config
  }
}))

The reason of that bug is CommonChunkPlugin which is working just for one extension (withCSS pass undefined and it used /.css$/, sass pass /.(sass|scss)$/, etc). You can find it here and (here)[https://github.com/zeit/next-plugins/blob/8a9f5a89c835e2c4c18398521a361d95c0d80f40/packages/next-css/commons-chunk-config.js#L1]

This doesn't work for me in production. I have a library used called namespace-ee/react-calendar-timeline on github, and by including the library it also requires the css file directly.
import Timeline from 'react-calendar-timeline/lib';
I'm using this method because nextjs doesn't support some typescript/flow thing in there by default.
And I notice in production, the css included by the timeline keeps overwriting my other default scss which I included later in the page.
None of the solutions above works for me. (e.g. next-compose, commonsChunkConfig)

even with suggestions from @JerryCauser it doesn't work for me.
I have a project with antd (less) and my own sass stylesheets and the result is:
a) if I don't include my sass file - less get's compiled, but sass doesn't
b) if I do - less doesn't, sass does

I've come across two issues at the same time which are #21 and this one.
This is because, I use some third party libraries which required to include css (react-datepicker). And I prefer to develop component using SASS instead of styled jsx (I haven't use less)
In the end, I've create withSSSS to combine all css, sass, scss, less and it seem to solve my case (may be this case)
const ExtractTextPlugin = require('extract-text-webpack-plugin')
const cssLoaderConfig = require('@zeit/next-css/css-loader-config')
const commonsChunkConfig = require('@zeit/next-css/commons-chunk-config')
const MergeFilesPlugin = require('merge-files-webpack-plugin')

module.exports = (nextConfig = {}) => {
  return Object.assign({}, nextConfig, {
    webpack(config, options) {
      if (!options.defaultLoaders) {
        throw new Error(
          'This plugin is not compatible with Next.js versions below 5.0.0 https://err.sh/next-plugins/upgrade'
        )
      }

      const { dev, isServer } = options
      const {
      	cssModules,
      	cssLoaderOptions,
      	postcssLoaderOptions,
      	sassLoaderOptions = {},
      	lessLoaderOptions = {},
      } = nextConfig

      // Support the user providing their own instance of ExtractTextPlugin.
      // If extractCSSPlugin is not defined we pass the same instance of ExtractTextPlugin to all css related modules
      // So that they compile to the same file in production
      let extractCSSPlugin =
        nextConfig.extractCSSPlugin || options.extractCSSPlugin

      //the ORIGINAL from next-css
      if (!extractCSSPlugin) {
        extractCSSPlugin = new ExtractTextPlugin({
          filename: 'static/style.css'
        })
        config.plugins.push(extractCSSPlugin)
        options.extractCSSPlugin = extractCSSPlugin
        if (!isServer) {
          config = commonsChunkConfig(config, /\.(sass|scss|less|css)$/)
        }
      }

      //the OVERWRITTEN
      //using MergeFilesPlugin to combile all css files into one file
      //ref: https://github.com/zeit/next-plugins/issues/21
      if (!isServer && !dev) {
    	// Override next-css configuration
    	options.extractCSSPlugin.filename = 'static/[name].css';
    	// Merge all CSS in one file
    	config.plugins.push(
      	  new MergeFilesPlugin({
            filename: 'static/style.css',
            test: /\.css/,
            deleteSourceFiles: true,
      	  })
    	)
      }

      options.defaultLoaders.css = cssLoaderConfig(config, extractCSSPlugin, {
        cssModules,
        cssLoaderOptions,
        postcssLoaderOptions,
        dev,
        isServer
      })

      options.defaultLoaders.sass = cssLoaderConfig(config, extractCSSPlugin, {
        cssModules,
        cssLoaderOptions,
        postcssLoaderOptions,
        dev,
        isServer,
        loaders: [
          {
            loader: 'sass-loader',
            options: sassLoaderOptions
          }
        ]
      })

      options.defaultLoaders.less = cssLoaderConfig(config, extractCSSPlugin, {
        cssModules,
        cssLoaderOptions,
        postcssLoaderOptions,
        dev,
        isServer,
        loaders: [
          {
            loader: 'less-loader',
            options: lessLoaderOptions
          }
        ]
      })

      config.module.rules.push({
        test: /\.css$/,
        use: options.defaultLoaders.css
      })

      config.module.rules.push({
      	test: /\.scss$/,
      	use: options.defaultLoaders.sass
      },{
      	test: /\.sass$/,
      	use: options.defaultLoaders.sass
      })

      config.module.rules.push({
        test: /\.less$/,
        use: options.defaultLoaders.less
      })

      if (typeof nextConfig.webpack === 'function') {
        return nextConfig.webpack(config, options)
      }

      return config
    }
  })
}

@supadits Have you considered creating an NPM package for withSSSS?


Issue with DevOps Build in Blazor 0.7.0

Functional impact
This stops us accessing our Blazor Application from an Azure App Site.
Minimal repro steps

Create New Blazor Application 0.7.0 from the template
Run the build process below
Run the publish process below
Navigate to the Application URL

Expected result
The application should run, as it did with Blazor 0.6.0
Actual result
If I access the application with https:, I get the following error in the Browser (Chrome) Console:
WASM: The assembly mscorlib.dll was not found or could not be loaded.
WASM: It should have been installed in the `/mnt/jenkins/workspace/test-mono-mainline-wasm/label/ubuntu-1804-amd64/sdks/out/wasm-runtime-release/lib/mono/4.5/mscorlib.dll' directory.
go-micro.azurewebsites.net/:1 Uncaught (in promise) ExitStatus {name: "ExitStatus", message: "Program terminated with exit(1)", status: 1}message: "Program terminated with exit(1)"name: "ExitStatus"status: 1__proto__: Error
at https://go-micro.azurewebsites.net/_framework/wasm/mono.js:1:204993
Promise.then (async)
(anonymous) @ blazor.webassembly.js:1
(anonymous) @ blazor.webassembly.js:1
callRuntimeCallbacks @ mono.js:1
preRun @ mono.js:1
run @ mono.js:1
runCaller @ mono.js:1
removeRunDependency @ mono.js:1
receiveInstance @ mono.js:1
receiveInstantiatedSource @ mono.js:1
Promise.then (async)
doNativeWasm @ mono.js:1
(anonymous) @ mono.js:1
(anonymous) @ mono.js:1
If I access the application using http, I get:
WASM: Runtime critical type Mono.RuntimeStructs/HandleStackMark not found
blazor.webassembly.js:1 Uncaught (in promise) abort(). Build with -s ASSERTIONS=1 for more info.
Finally if I publish directly from Visual Studio, using Azure Publish, it works to a new App Service, but does not to an existing one.
I'm sure it's me, but am a bit stuck!
Further technical details
I followed the instructions to upgrade my Blazor Client Application to 0.7.0 first. I then recreated a brand new application from the template.
I am using Visual Studio Enterprise 2017 Preview (2) Version 15.9.0 Preview 6.0
We're using Azure Devops to build and then releasing to Azure Web Applications.
After much fiddling, I have an application which runs, but only runs using http.
If I access the aplication with https:, I get the following error in the Browser (Chrome) Console:
WASM: The assembly mscorlib.dll was not found or could not be loaded.
WASM: It should have been installed in the `/mnt/jenkins/workspace/test-mono-mainline-wasm/label/ubuntu-1804-amd64/sdks/out/wasm-runtime-release/lib/mono/4.5/mscorlib.dll' directory.
Uncaught (in promise)
The Build pipeline does the following:

Use .NET Core SDK 2.1.500
Use NuGet 4.8.1
NuGet restore
Build solution ***.sln with the parameters: /p:DeployOnBuild=true /p:WebPublishMethod=Package /p:PackageAsSingleFile=true /p:SkipInvalidConfigurations=true /p:PackageLocation="$(build.artifactstagingdirectory)\"

We then copy the produced Zip file and publish to Azure using the Deploy Azure App Service function
All was working perfectly in Blazor 0.6.0

Ok.
After forcibly clearing all browser data, Ensuring my build created the Release version, we are all back up and running with 0.7. Great work folks!


Scale

So this function does a lot of mapping through image data. getImageData returns an Array Int however. Should we keep it that way? Maybe it should be List Int.
In making it Array Int, I assumed that users would want to change particular values with Array.set. Now I am not so sure. At least, when scaling, I had no use of Array.set.

I got all this together, but its surprisingly slow. Im just going to forgo including it for now, so I can move onto other things.


"Unexpected token ILLEGAL" error on valid UTF-8 identifier

Hi,
in my UTF-8 encoded js source, a var name contains the é character (common in french).
Afaik, this is a perfectly valid Ecmascript var name.
However, flow reports an "Unexpected token ILLEGAL" error.
I have not found a configuration option to prevent this.
Thank you in advance for your help.

I'm seeing this too for other alphabetic characters that are valid in JavaScript identifiers.
Examples: ª, º, Δ, Ω
See this tool to find out what is and is not valid JavaScript identifiers: https://mothereff.in/js-variables

Thanks for the report! This was reported again in #521 and @gabelevi commented with a good description of the challenge in fixing this, so I'm gonna close this one even though this one came first.


ignore websocket routes

atm websocket routes get documented automatically
Is there a way to avoid that, since it doesn't support any documentation properties on it?

you can filter out unwanted routes in the plugin-configuration with pathFilter.


How do I save an assets-library:// disk?

I have an assets-library:// link to an image in my Camera Roll.  How can I save it to my apps Documents folder?

@wootwoot1234 hey, did you solve it?

Yes, try this out:
https://github.com/wootwoot1234/react-native-save-asset-library


Roll Flutter Engine from 3ccf66bed335 to 00c9e3eb624e (1 revision)

https://github.com/flutter/engine/compare/3ccf66bed335...00c9e3eb624e
2024-01-10<EMAIL_ADDRESS>Roll Skia from ae30afc7b79a to 51a0ad17b147 (1 revision) (flutter/engine#49665)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Broken Playground since 1.5.5

This issue pertains to the following package(s):

[x] GraphQL Playground - Electron App

What OS and OS version are you experiencing the issue(s) on?
Mac OS 10.13.3
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
1.5.5
What is the behavior?
The editors are completely broken. Syntax colorization is gone, so is the autocompletion. I can't even click the "play" button to query my api.
What steps may we take to reproduce the behavior?
Not sure yet, I've just updated the playground and got it broken this way.

Thanks for reporting @Weakky. We just released a pre-release that aims on this problem.
https://github.com/graphcool/graphql-playground/releases/tag/v1.5.6
Can you manually download the .dmg from the release page and try it out?
Thanks!

Just released 1.5.6. Please let me know if this is still in issue.


Update ns-winuser-rawinputdevice.md

Clarify RIDEV_NOLEGACY and legacy keyboard/mouse messages

@DJm00n : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fixed broken links in Update index.md - #1954

What we seem to need is a tool that also checks internal links. I think the github action we added recently can do that, but we explicitly configure it not to.

Merging these changes. Will also check how to go about the internal link checker.