v0.23.2 causing OOM

Using this script which tries running AudioLM end-to-end (basically the demo notebook in a single python script), I found that 0.23.2 reliably resulted in OOM on the A100 GPU during inference when fine transformer got to around 93%. I just tried it again on 0.22.3 and it was able to finish (and by rough approximation i.e. running nvidia-smi repeatedly in a separate terminal), I found the older version uses about 10k MiB less memory. Has anyone else been able to replicate this?
I haven't looked closely at the code changes yet so I don't have a hypothesis for what causes this, but I thought to look at the most recent change because the OOM stack trace included audiolm_pytorch.py", line 955, in forward: attn_bias = self.pos_bias_mlp(rel_dist.float()) which was introduced here.

@LWprogramming thanks for raising a valid issue again! it was exactly what you thought it was, the computing of the 2d relative positional bias in the fine transformer
do you want to see if this commit helps? (would also appreciate a code review, as this has always been super confusing for me :dizzy_face: )

@LWprogramming if this doesn't work, i may just have to turn to other techniques to generate relative positions across the quantize positions

@lucidrains
yes, I understand that this is about the fine transformer. I guessed that this is due to the recent updates.
Could you please guide me on which part of the model consumes that much memory.
1 second audio takes 4 GB memory, 2 seconds audio takes  5.5 GB ( with the batch size of 1).
Could you please illustrate the reason for such a behaviour?

do you want to see if this commit helps? (would also appreciate a code review, as this has always been super confusing for me 😵)

Fine Transformer is definitely substantially faster now! I'm also new to this, so I watched some videos for how relative 2-d encodings work but I'm still working through some confusion. Is there a specific paper you're following here?

@LWprogramming nice! thanks for testing out the changes and confirming it is fixed!
i think it was in some old vision transformers paper, but forgot the name of the paper. no worries, i'll just review the code once or twice later this week


clrModalOpenChange fires twice when a modal closes.

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior

When a modal closes, the clrModalOpenChange should only fire once.
Actual behavior

When a modal closes, the clrModalOpenChange should only fires twice.
Reproduction of behavior

Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:

Environment details

Angular version: 5.1.1

Clarity version: 0.10.10

OS and version: MacOSX 10.13.2

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

I have the same issue. Is this bug fixed? On what build?

@VickyYoung
We haven't been able to reproduce this issue. Could you create a stackblitz reproduction in 0.12 or 0.11?

@mathisscott Stackblitz link https://stackblitz.com/edit/clarity-light-theme-v11-oqn2sx

@lohiaad - this is a duplicate of #3149. Please subscribe to that issue for updates to progress on it.
Fwiw - the issue stems from the way a modal close() and the fadeDone() methods are handled for that component. In the case where users close modals with the built in close button the closeChange observable is fired from both the close method and the fadeDone() method.


[FEAT] Dark theme configure

Pull Request Title
Thank you for contributing to our project! Please provide a summary of your changes and reference any related issues below.
This PR adds dark theme compatibility to the wallet and wallet-adapter pages, ensuring all UI elements adapt seamlessly for better readability and user experience in dark mode.
Issue Number: Fixes # (220)
🛠 Type of Change

[ ] 🐛 Bug fix
[X] ✨ New feature
[ ] 🚨 Breaking change
[ ] 📚 Documentation update

✅ Checklist
To ensure a smooth review process, please check off each item as you complete it:

[X] Code Style: My code adheres to the project’s style guidelines.
[X] Self-Review: I have reviewed my own code and made improvements.
[ ] Comments: I’ve added comments to explain complex or non-obvious parts of the code.
[ ] Documentation: I’ve updated the documentation to reflect my changes.
[X] Warnings: My changes introduce no new warnings.
[ ] Tests: I’ve added tests to verify that my changes work as expected.
[X

Passes Locally: All new and existing unit tests pass on my local machine.

We appreciate your contributions! If you have any questions or need further assistance, feel free to reach out.

@Ayushjodd Where has the wallet detail component disappeared in the Screenshot?
Also, we removed the right sidebar from this page
And center the "Making Solana apps consumer ready" section on the wallet-adapter page

@Ayushjodd can you again provide the screenshot of the wallet details page
Including the swap,receive,send component
It will be great if you provide

@Rudra-Sankha-Sinhamahapatra

Can you show that how the receive,send,swap component is looking in dark mode ?

@Rudra-Sankha-Sinhamahapatra  @cb7chaitanya

Fixes #220


allow SDK versions to be configurable

This PR allows the versions of the following SDK versions to be configurable

awscli
mc
minio-dotnet
minio-go
minio-java
minio-js
minio-py

This is required for gateway tests, since there was a mismatch between the latest version and the lastest available version from this URL https://dl.minio.io/client/mc/release/linux-amd64/mc.${MC_VERSION}
By explicitly allowing the version to be set, we can avoid the above issue.
The existing behavior is maintained if the versions are not explicitly set.

@nitisht
I originally did this because few of the SDKs did not work while running gateway tests - minio-java would not finish executing. mc build was looking for a non-existent version. This change parametrizes the versions. Other than allowing me to pin the versions to get over above hurdles, this will also enable testing multiple versions of the SDK for a release of minio.

@wlan0 initial vision while developing mint was that if sdk has an issue we fix the sdk and make a release instead of reverting to a working version. So we did not make the version configurable.

IMHO this goes against that initial philosophy. Is there any specific reason to do this ?

I didn’t know about the philosophy. I understand your concern. Essentially, this change enables users to choose a version if they wanted to, and gives them the keys to revert to working version if they so chose, instead of fixing a broken SDK.
Given your concerns,  and given that mint tests seem to be going smoothly now, I dont think this PR is needed anymore. I’m happy to close this, any thoughts @nitisht @vadmeste?

We should discuss this again once @wlan0 @nitisht  with @abperiasamy - if there are benefits in this approach we can keep the PR for now.

This PR doesn't change the old behavior by default, it only does that when we set SDK_VERSION in the environment. I would say this can be useful for us for debugging.

Moved to blocked, pending discussion with @abperiasamy .


[Linux] More notes spawn even off screen, while Windows doesn't causing more lag on Linux.

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
There seems to be more notes being rendered when on Linux than Windows. This causes more lag.
Command Prompt/Terminal/Crash logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
1. Be on Linux
2. Play using JS Engine
3. Play any super spammy song.
4. Way more lag than what you would experience on Windows

Are you modding a build from source or with Lua?
Lua
What is your build target?
Linux
Did you edit anything in this build? If so, mention or summarize your changes.
No
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
 Thanks for the help!

LOL you're welcome though, sometimes we all make easy-to-fix mistakes


[ILVerify] Probably false negative in a specific case with generics

For the following code, I get
Assert::AreEqual(!!0, !!0)][offset 0x0000000A][found ref 'T'][expected ref '[mscorlib]System.IEquatable´1<T>'] Unexpected type on the stack.
The code is
using System;

namespace ILVerifyBug
{
    static class Assert
    {
        public static bool AreEqual<T>(T a, T b) where T : IEquatable<T>
        {
            return a.Equals(b);
        }
    }
}

(I have minimized it as much as possible.)

I can avoid this by changing the method signature to
public static bool AreEqual<T>(IEquatable<T> a, IEquatable<T> b) where T : IEquatable<T>

Cc @ArztSamuel

Thanks for the simple reproducer sample code. This is indeed a false negative.
This is caused by the TypeConstraints of generic parameters not being instantiated correctly before they are passed to the casting check. Therefore the constraint is still IEquatable<!0> inside the CastingHelper and the cast to IEquatable<T> fails.
We had a very similar problem in the CheckConstraints code, which was fixed by introducing the InstantiationContext, but I think it would not be good practice to also pass this context to the CastingHelper.
I think it would make sense to make sure that the constraints are instantiated when the method verification is started.
I hope to be able to commit a fix for this in the next few hours.


Add sort method

It is very helpful to user to sort the doctors on basics of their profession. so, add a sorting method would be great

Hey there! I want to work on this issue, can assign me?

I want to work on this issue please assign me this issue


Do not check in the transpileModule API

Suggestion

🔍 Search Terms

transpileModule
skip typechecking
no typechecking

Semi-related issues found:

Skip typechecking; only emit (support --transpileOnly in tsc, re-open of #4176) #29651
[FEATURE REQUEST] Please supply a minified version with only transpilation functionality #9245
Allow transformers to run without type-checking #41986

✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Modify the transpileModule API to mostly do the following:

Parses a source string
Runs the corresponding transforms to get to the target ES version
Emits a resulting string with a sourceMap string

The API itself would be unchanged but would be guaranteed to not hit the type-checker if a certain set of compatible compiler options is set. (deoptimizing options TBD)
Achieving this without modifying TypeScript is currently not possible with the current TypeScript API: there is currently no way to just apply the transforms without running the checker as a Program has to be created in the process.
Alternatively, if changing transpileModule is not possible we would be interested in exposing more minimal API primitives so we could build up this API ourselves:

A public Printer API that can issue sourcemaps
A way to run transforms on TS ASTs without the need to build up a Program (and run the checker...)

📃 Motivating Example

In our build system, for certain workflows, we introduced a new build mode that runs transpileModule instead of compiling and type-checking the full project. transpileModule is run on a per-file basis as we are reading files into our build stream, meaning there are no inter-file ordering dependencies.

Approximative `transpileModule` API usage
const result = ts.transpileModule(tsFileStr, {
    compilerOptions, // <- with an ESNext target
    reportDiagnostics: true,
    moduleName: tsFilePath,
    fileName: tsFilePath,
});
if (result.diagnostics) {
    // report syntax errors
    if (result.diagnostics.length > 0) {
        return;
    }
}
const jsFilePath = tsFilePath.replace(/\.tsx?$/, ".js");
const jsFileStr = result.outputText;
const sourceMapPath = jsFilePath + ".map";
const sourceMapStr = result.sourceMapText;
// ...

With this new mode, we managed to get 4x faster than an equivalent fully-typechecked build! This is an amazing speedup that is appreciated for running common workflows (while VSCode continues to type-check things in the editor).
We are still trying to get faster: most of the time is now spent type-checking inside transpileModule, as seen in the CPU flamecharts.

We researched using alternative build tools such as swc or esbuild but using their transpile API alone in our setup is not significantly better than using transpileModule! (I could do a writeup on this if anyone is interested in that research) However, those other tools do tend to get really fast when they are run standalone and handle file I/O but unfortunately this does not fit our use case.
At this point, a pure js-based transform might be the better option and simply using the TypeScript compiler infrastructure would make sense since all the tools to create a relatively fast module type-stripping system should be there but are not exposed through the current API.
💻 Use Cases

Our goal is to be able to keep transpileModule and have it go faster if the options don't require checking:
// ✅ doesn't require checking, fast path:
ts.transpileModule(tsFileStr, {
    compilerOptions: {
        target: "esnext",
    },
});

// ❌ requires checking, slow path:
ts.transpileModule("class c { @x f: string };", {
    compilerOptions: {
        target: "esnext",
        emitDecoratorMetadata: true,
        noEmitHelpers: true,
    },
});
// emits with some type system info:
class c { f }
__decorate([], x, __metadata("design:type", String), c.prototype, "f", void 0);

By avoiding type-checking code paths when possible (deoptimizing options TBD), we could speed things up significantly again for the users of transpileModule.
In the future, it could also be the base to then introduce a tsc flag for fast unchecked builds as suggested in #29651.This would permit tsc to be significantly faster if opted into with the flag.
Deoptimizing options
This is a temporary list that we intend to build up over time:

emitDecoratorMetadata
... TBD ...

If you can provide some guidance on whether this would be a good thing to change/fix, along with any implementation constraints/tips, I would be happy to attempt an implementation.

I could do a writeup on this if anyone is interested in that research

Me. I'm interested in that research!

I think I want to have the whole story before going there so I'd like to try the proposed optimizations here and compare them. Also to be clear, it was within our very specific setup. When using swc/esbuild "as intended" the results are different!

Well transpileModule is mostly a wrapper around creating a Program to compile a single file. The checking happens and is relatively fast compared to a multi-file project but is ignored as diagnostics around checking are not reported.

Paging @DanielRosenwasser for thoughts

I believe this is because the checker is doing this for grammar checks - but the cost comes from the walk, plus the fact that some checking necessarily happens from the checker's walk.
The upside of this is that we have parent pointers (which makes things easy for us), and it reduces time-to-interactive in editor situations (since it's not part of the up-front always-on cost of parsing/binding).
The downside is that it's still a separate tree walk and there's some incidental type-checking, and that adds up.
I think @sandersn's work on #45349 is also relevant - we've spoken about whether or not grammar checks  could be folded into a lighter grammar walk that the full checker can periodically jump into - or possibly brought back into the parser/binder.

My guess is that if someone spent a day or two trying to optimize and eliminate work from transpileModule, they would find some fairly low-hanging fruit, and some fruit not reachable without an architectural overhaul.

I think it's a good idea since type checking for complicated types can be costly, but there are some TypeScript features that require type information to emit JavaScript code, like const enum NotAnObject, import { SomeType } from "some-module";.
For example the following TypeScript code
const enum NotAnObject {
  Foo = 1,
}
console.log(NotAnObject.Foo);

will be transpiled into JavaScript code:
"use strict";
console.log(1 /* NotAnObject.Foo */);

TypeScript needs to know NotAnObject is not a reference to an object (unlike normal enum objects), and NotAnObject.Foo should be transpiled to the enum value 1.  But without type information of the whole project, TypeScript cannot find how NotAnObject is defined -- it can be a global declaration in other files of the project, although I think it's not good coding style. And import { SomeType } from 'some-module' without declaring type only import like import { type SomeType } from 'some-module' or import type { SomeType } from 'some-module' also requires type information to know those named imports should not be emitted in the JavaScript code, otherwise the JavaScript code may not work correctly (as ES Module).
In other words, does this API implicitly require isolatedModules to be configured to true?

Yes, isolatedModule means transpiler-friendly. Any single-file transpiler, including our transpileModule API, may produce broken code if the program doesn’t check without errors with isolatedModules enabled.

I think this is now fixed by #58364. Thanks @weswigham!


Add go.sum

Pull Request Test Coverage Report for Build 827

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.061%

Totals

Change from base Build 815:
0.0%

Covered Lines:
751

Relevant Lines:
807

💛  - Coveralls


Port spline interpolation

Port of spline_interpolation as it is required by obstacle_avoidance_planner

@sgermanserrano  I opened https://github.com/tier4/Pilot.Auto/pull/65 few days before but i can close mine if you would prefer?

I will close this for now since this is a duplicate of https://github.com/tier4/Pilot.Auto/pull/65

Makes sense, thanks for merging #65


why does the threshold change in matching.linear_alignment?

Look at line 210, line 232, line 254 .
Why those 'thresh's are all different and how does it influence on the tracking results?
Also, I realized that if the iou distance value between two objects is 0.9, they don't associate with each other.
IoU distance is vey high but why do they unmatched?

Let's clarify the iou distance before you asserting two objects is 0.9.
IoU distance seems large due to 1 - cost_matrix ....
Like two objects have a touch of intersection, say the IoU of them is 0.1.
For matching, we use Hungarian Method/Linear Assignment to associate objects. The cost is lesser the more likely would be the same object.
So, 1 - 0.1(orignal IoU) = 0.9(cost IoU).  Not sure which value of IoU you're referring to
Other way of doing so is to multiply the value by -1. The largest (same object) becomes smallest value inside the cost matrix.

Btw, I'm still understanding why there are three different thresholds for the linear_assignment...


[BUG] hide gui thingy does not work at all

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
yeah the title says it all, and yes i am in the roblox group
the weirdest part about it is the fact that it worked just ONCE, afterwards it just stopped working completely 😭😭
Bloxstrap Log
N/A

This isn't an issue with Bloxstrap, the issue here would be Roblox not recognizing the keystrokes for some reason. Can't really help you out there, sorry.


broken verbose command

crystal 1.cr --release --verbose
cc "${@}" -o '/home/kostya/.cache/crystal/crystal-run-1.tmp'  -rdynamic  -lpcre -lgc -lpthread /home/kostya/crystal-0.24.1/share/crystal/src/ext/libcrystal.a -levent -lrt -ldl -L/usr/lib -L/usr/local/lib _main.o

It expected to work when copy and execute manually. It works sometimes ago. it is useful when need  to debug some cc flags.

So the issue here is that --verbose flag doesn't work with implicit crystal run syntax. I'm not sure that needs to be supported because if you want more options, you can just use crystal run explicitly. But then the compiler should at least error on --verbose flag.
$ crystal test.cr --verbose --
$ crystal run test.cr --verbose
cc _main.o -o /home/johannes/.cache/crystal/crystal-run-test.tmp  -rdynamic -L/usr/bin/../lib/crystal/lib -lpcre -lm -lgc -lpthread /usr/share/crystal/src/ext/libcrystal.a -levent -lrt -ldl

issue was: long ago, i can copy this command and just run, and compile my project (to debug some link keys), but now it impossible, wrong paths, or smt.

I think the problem is libcrystal, which needs to be compiled separately on the target machine

When I ran this for test:
$ crystal run  1.cr  --verbose

The output was:
cc _main.o S-lice40U-I-nt841.o P-ointer40U-I-nt841.o A-rgumentE-rror.o E-xception5858C-allS-tack.o A-rray40P-ointer40V-oid4141.o ....... C-rystal.o -o /home/user/.cache/crystal/crystal-run-1.tmp  -rdynamic -L/opt/crystal-0.35.1-1/bin/../lib/crystal/lib -lpcre -lm -lgc -lpthread /opt/crystal-0.35.1-1/share/crystal/src/ext/libcrystal.a -levent -lrt -ldl

Any idea why the erroneous "-" is inserted after every uppercase letter? (e.g. S-lice40U-I-nt841.o)

i think problem that _main.o without correct path.

The dash is there to avoid clashes between different names thar are the same in OSS where filenames are case insensitive (Mac).
What otter char can we use instead?

Ah ok, thanks.
But yes, @kostya is otherwise right in saying that copy-pasting and executing this line stopped working at some point, because the paths reported are no longer valid relative to the process' cwd.

I think I know what happened. We used to run the linker command on the current dir but it ended up being too long, so now we cd into a nested dir and do the linking there. But that's not needed for the verbose output... the problem is that verbose is actually showing the command that was executed so I'm not sure what's the best way to fix this

Maybe it would be just fine if, above the cc line, simply the cd ...nested dir... was printed.
This would allow users to repeat it themselves.


Update to selenium webdriver 3.0.0

The new stable release of selenium declare to support more native and up to date drivers.
In particular include the support required for testing version of firefox > 48
reference: https://github.com/SeleniumHQ/selenium/blob/master/dotnet/CHANGELOG

Biggest change is the addition of the SELENIUM_PROMISE_MANAGER  environment variable, which allows disabling the proprietary Promise manager. This has been the cause of many headaches, and I would love to get a version of protractor that also works without it.

This depends on #3689 and #3691


Add a structured op matcher for 2d convolutions

This adds a matcher similar to the existing one for reductions. Currently only matches named 2d convolutions (linalg.conv_2d_nchw_fchw and linalg.conv_2d_nhwc_hwcf) with an optional fill op for the output and an optional trailing elementwise op. Adds a capture rule for convolution dims based on the dim classifier upstream.

rebase for CI failure

FYI, I'm turning matchers into transform dialect ops in https://reviews.llvm.org/D148017.

Nice, happy to start upstreaming the matchers here then. I have some improvements to im2col planned which will affect this matcher so I can look into making ops once I've figured out what that looks like.


Are collections created with "unlimited" storage capacity?

The Azure Portal allows to create collections either with fixed size of 10GB without using partitions, or unlimited storage / partitioned:

I could not figure out how to influence this when using pydocumentdb when creating a collection. There also doesn't seem to be a way to specify the partition key path when doing so. I find this all quite confusing and would be happy if this is clarified in the docs and/or the library is changed to support everything the Azure Portal supports.

Closing this issue due to age. Active development of our Python SDK has moved to https://github.com/Azure/azure-sdk-for-python. We have also released 4.0 which includes many updates and new features. If this issue still needs our attention, please reopen it in the new repository.


WithSubclasses breaks with late binding

Create a function like
class bar: ...

@type_enforced.Enforcer()
def foo(b: WithSubclasses(bar)): ..

Then in a later imported file, create a subclass of the target type
class baz(bar): ...

If you try to call foo(baz()) you get an error.  This is because WithSubclasses immediately looks through the list of subclasses, rather than doing so when the function in question is called.
Additionally, abstract base classes are unsupported because it uses this approach.  A simpler approach would be to make WithSubclasses be a higher priority check that uses isinstance to defer the actual check to at runtime.  Unfortunately I don't see a trivial way to fix this.

Thanks for creating an issue @perkinslr.
I do not see an immediate clean fix for this issue as well. The reason we do immediate checking for subclasses at initialization instead of at function call time is for performance reasons.
You could always push the validation to run time using a custom constraint. I might be able to generalize this with a few caveats.
In your Foo class definition, you could do:
import type_enforced
from type_enforced.utils import WithSubclasses, GenericConstraint

class Bar:
    pass

# Using a generic constraint runs the constraint at call time
BarWithSubclass = GenericConstraint({
    'bar_with_subclass':lambda x: type(x) in WithSubclasses(Bar)
})

@type_enforced.Enforcer
def foo(x: BarWithSubclass) -> None:
    pass

The challenge with this is that Constraints are not validated in the same way as types. First types are validated and then constraints are validated. If you want to pass other type checks with this constraint for foo(x) it may have other implications.

You could also define your foo function after importing baz which would then work as is. I understand that this is not necessarily ideal so the above custom constraint would be a more generic solution.

Delayed the callable until inital check in 1.7.0
Closing with: https://github.com/connor-makowski/type_enforced/commit/34e1dd297eb7a5b1e781d03c47e8c9908c1e0f3a


Pull in Serilog's default JSON formatter

...to break dependency on Serilog.Formatting.Json.JsonFormatter virtual extension points (serilog/serilog#819)

The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Unhandled Exception: GitTools.WarningException: It looks like the branch being examined is a detached Head pointing to commit 'acafa4f'. Without a proper branch name GitVersion cannot determine the build version.

It looks like some more work may be required for GitVersion to work for PRs, or perhaps it could just default to some fixed version when in detached head state? CC @mivano

Any guidance on this one folks? Never having used GitVersion I'm not sure where to start; would using the versioning scheme from the other Serilog repos help here? (I can PR if so).

Hmm that is a nice one. We are using gitversion with TFS builds and never run into this. For PRs (feature branches) it creates nice x.y.z-branchname0001 versions. Which are nuget compatible. Are you aware of an option in Appveyor to tell it to get the branch by its name? Otherwise we need to make it optional for PRs and just use a random version number. But that defeats the nice gitversion way...

I checked in to dev an updated build.ps1 file that ignores gitversion when on a head less branch. Can you try and see if this fixes the issue?

@mivano :white_check_mark: ready to go!

Great, I merged it back to dev.

Thanks :+1:


Index or size is negative or greater than the allowed amount

When trying to use Crooper with an large image we get the following error:
"Index or size is negative or greater than the allowed amount"
The dimension of the image used is: 3954 x 710

What's the browser and version?

Firefox
40.0.3

I test this with the following conditions, and everything is fine:

Windows 10
Firefox 41
A huge image with 5600 × 3600 (px)


Lost recent saves

Been working on a brew for a while, making sure it saved along the way.
Somehow it reverted to about a week ago, even though it had been closed and reopened without problems several times since then
I really hope there is a way to recover previous versions, cause I lost quite a bit of work that i cant really remember.
http://homebrewery.naturalcrit.com/edit/Hyx1kNt8dg
Additional Details
Share Link :
or
Brew code to reproduce : Click to expand
PASTE BREW CODE HERE

@calculuschild, I think this issue can be closed as "aged out"/"cannot reproduce"

Unfortunately this was never fixed when it was first reported, so there's nothing more we can do now.


Refactor to be React App w/ Flask Backend

Now that the app is functional as a prototype with Plotly's Dash platform, I'd like to try and refactor this to have a distinct FE and BE so that the visual experience is cleaner / more modern. With a React FE, there would be more flexibility for the interactivity, which also might solve some of the PWA issues (not leveraging the url params).
This will be a significant refactor which will take more time, but I'd like to grow this full-stack skillset. I think it will be worth the investment. This resource seems useful as a good place to start.
Overall Vision

Monorepo structure

BE (Python - Flask)
FE (React)

Still deploying via Render but this way:

Static Site for the FE
Python Web Service for the BE
Likely still just the raw code vs. containerizing/docker, but we'll see
Render Suggestion 1 Render Suggestion 2

FE specifics

Would like to use Mantine - will be good to have a simple but useful component library.
Will shift to more Client-Side rendering vs. Server-side rendering, which will impact some of the current BE API calls.

BE Specifics

Will stick with Python w/ Flask.

That way I can reuse a lot of what I know (ex: Flask Caching, etc.)
Also able to more easily repurpose the already working core components (Libby search, Library Searches, Goodreads parser, etc.)

With more client-side rendering, the BE API needs to not return components/children, but JSON data.

Refactor Concerns

Decoupling FE and BE might cause more Bandwidth usage on Render (need to monitor this more carefully)

Use something like https://tools.pingdom.com/ to check page size and performance.
Currently, page size is 3.2MB and load time was 555ms w/ 63 requests.

Mantine UI Components

Started with create react app, but might want to look into their pwa template: https://create-react-app.dev/docs/making-a-progressive-web-app/

This might be needed for awaiting components to finish? https://stackoverflow.com/questions/71778278/how-can-i-ensure-that-a-react-component-is-loaded-only-after-some-api-call-has-b
Or loading behavior?

https://stackoverflow.com/questions/66444067/react-display-loading-animation-for-api-call-duration
Loading behavior example

https://dev.to/will_yama/how-to-render-responses-96c
Another helpful article

Looks like I need to go with a Vite template because create react app doesn’t work maybe?
https://help.mantine.dev/q/can-i-use-mantine-with-cra

Might need this for changing the URL without refreshing the page?
https://stackoverflow.com/questions/57101831/react-router-how-do-i-update-the-url-without-causing-a-navigation-reload

Backend: Might need to consider the BE returning ALL the books, so that the FE can avoid using bandwidth to simply get a random selection.
Frontend: This might mean a refactor to use ReactQuery and manage the cache that way.


Broken link - Avocado example page

AvocardoLab link is broken from add-entry page.
Reference:
(https://github.com/diybiosphere/sphere/blob/master/docs/tutorials/add-entry.md)

Good reference materials are the Writing Guide and the example entry of the Avocado Lab webpage which is rendered from this file

Hey thanks @sctv for reporting this! I fixed the broken link now! 😄


Color of status bar

Color choice of status bar is odd. Otherwise colors of editor are muted but then for some reason this status bar strikes to your eyes and takes your attention. On UX field it's known that bright colors should be avoided in the background layers. Other elements than code editor are definitely in the background. The color should be possible to change somewhere. I just need to hide it all the time.

This is customizable, just add the following to your settings and tweak the colors to your likings:
"workbench.colorCustomizations": {
    "statusBar.background": "#000000",
    "statusBar.foreground": "#dddddd",
    "statusBar.debuggingBackground": "#007acc",
    "statusBar.debuggingForeground": "#dddddd"
}


Chat Scrolling

For some reason now when i enter chat and press PAGE UP or DOWN it does not scroll through the chat log.

How many lines would you like it to scroll? A constant 12? Size of the chatbox - 3?


Crash when launching debug build from iOS home screen

Steps to reproduce
When launching a debug build of a Flutter app from the home screen of iOS, the app will crash when trying to register plugins:
Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Codes: 0x0000000000000001, 0x0000000000000000
VM Region Info: 0 is not in any region.  Bytes before following region:<PHONE_NUMBER>
      REGION TYPE                 START - END      [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->
      __TEXT                   104fbc000-105c5c000 [ 12.6M] r-x/r-x SM=COW  /var/containers/Bundle/Application/7B913006-58CD-46F2-8AA4-1CDC1EE0E0C1/Runner.app/Runner
Termination Reason: SIGNAL 11 Segmentation fault: 11
Terminating Process: exc handler [8436]

Triggered by Thread:  0

Thread 0 name:   Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   libswiftCore.dylib            	       0x18b58369c swift_getObjectType + 40
1   connectivity_plus             	       0x107f32210 static SwiftConnectivityPlusPlugin.register(with:) + 64
2   connectivity_plus             	       0x107f325a8 @objc static SwiftConnectivityPlusPlugin.register(with:) + 56
3   connectivity_plus             	       0x107f30048 +[ConnectivityPlusPlugin registerWithRegistrar:] + 72
4   Runner                        	       0x104fc4074 +[GeneratedPluginRegistrant registerWithRegistry:] + 116
5   Runner                        	       0x104fc4a04 AppDelegate.application(_:didFinishLaunchingWithOptions:) + 100
6   Runner                        	       0x104fc4e8c @objc AppDelegate.application(_:didFinishLaunchingWithOptions:) + 196

This is a known problem:
https://github.com/flutter/flutter/issues/67624
https://github.com/flutter/flutter/issues/60657
In particular this is helpful:
https://github.com/flutter/flutter/issues/67624#issuecomment-801971172
This was supposed to be fixed by displaying an error message to the user rather than crashing, in Flutter 1.22:
https://github.com/flutter/engine/pull/20980
However, on Flutter 3.22, this dialog does not show for some reason.
Why can the underlying crash not be fixed, rather than displaying the error message?
Why is the error message not showing on latest Flutter?
Expected results
The app should not crash -- or at the very least, the error message should be shown.
Actual results
The app crashes 100% of the time on launch.
Code sample
N/A
Screenshots or Video
N/A
Logs
See full log at https://github.com/fluttercommunity/plus_plugins/issues/2912#issuecomment-2136095430
Flutter Doctor output
Doctor output
% flutter doctor -v
[✓] Flutter (Channel beta, 3.22.0-0.3.pre, on macOS 14.5 23F79 darwin-x64, locale en-US)
    • Flutter version 3.22.0-0.3.pre on channel beta at /Users/luke/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 87b652410d (5 weeks ago), 2024-04-23 21:41:18 -0500
    • Engine revision b4bfd45986
    • Dart version 3.4.0 (build 3.4.0-282.3.beta)
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/luke/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.89.20240501

[✓] Connected device (3 available)
    • iPhone SE (2nd generation) (mobile) • 00008030-000C38343C23402E • ios            • iOS 17.4.1 21E236
    • macOS (desktop)                     • macos                     • darwin-x64     • macOS 14.5 23F79 darwin-x64
    • Chrome (web)                        • chrome                    • web-javascript • Google Chrome 125.0.6422.77

[✓] Network resources
    • All expected network resources are available.

• No issues found!

OK, so actually I do see the error on the console:
[ERROR:flutter/runtime/ptrace_check.cc(75)] Could not call ptrace(PT_TRACE_ME): Operation not permitted
Cannot create a FlutterEngine instance in debug mode without Flutter tooling or Xcode.

To launch in debug mode in iOS 14+, run flutter run from Flutter tools, run from an IDE with a Flutter IDE plugin or run the iOS project from Xcode.
Alternatively profile and release mode apps can be launched from the home screen.

Is there some way to display this on the device screen as a pop-up dialog?

Debug builds use the JIT dart VM. iOS does not allow applications to launch JIT (essentially by blocking combinations of writable + executable memory that a JIT would need to create), unless there is a debugger attached.

@jonahwilliams Thanks for explaining. Can Flutter just pop up a native error dialog on launch in this case? I have been trying for weeks to figure out why my app was crashing when launched from the home screen, and didn't see the console error until just now.

I thought we used to do that, but I don't know what happened to it. its possible it broke along the way, or perhaps there were other changes that required it to be removed. I'll label the issue for triage and let the iOS team fill in the details.

The debug warning check is still there: https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm#L481-L492

Possibly the problem is that we never hit this point because something fails during plugin initialization instead.

Well it is plugin registration that is failing, yes. Specifically GeneratedPluginRegistrant::registerWithRegistry fails because registrarForPlugin returns null, which is then passed to a non-nullable Swift parameter registry in the plugin's register(with:) method.

registrarForPlugin is annotated as nullable`, so our generated registrant code is wrong; we should update it so that each line is a call to a static helper function that checks the registrar and no-ops if it's null.

https://github.com/flutter/flutter/blob/bc097c619af17c9c66531a085b9d99874a944c5f/packages/flutter_tools/lib/src/flutter_plugins.dart#L400

Ugh I remember now, the nullability is different between iOS and macOS...
- (nullable NSObject<FlutterPluginRegistrar>*)registrarForPlugin:(NSString*)pluginKey;

https://github.com/flutter/engine/blob/5ada2e116e9d5b2ae190e96ba224ab012f43296c/shell/platform/darwin/ios/framework/Headers/FlutterPlugin.h#L408
- (nonnull id<FlutterPluginRegistrar>)registrarForPlugin:(nonnull NSString*)pluginKey;

https://github.com/flutter/engine/blob/5ada2e116e9d5b2ae190e96ba224ab012f43296c/shell/platform/darwin/macos/framework/Headers/FlutterPluginRegistrarMacOS.h#L137


Combination of Sentence BERT and Naive Bayes raises error

Describe the bug
When I combine in ASReview the Feature extractor Sentence BERT and the Classifier Naive Bayes, it reports the following error: "ValueError: Negative values in data passed to MultinomiaINB (input X)"
To Reproduce
Steps to reproduce the problem:
Screenshots
See also the screen shots of the command line in the attached file.
SBERT_Naive Bayes.docx
Version information

OS: Windows
ASReview version 1.2

Additional context
Add any other context about the problem here.

Hi @taleevenhuis, Naive Bayes is only compatible with TFIDF features. For using SBERT features, you have to use other classifiers.

Ah, thanks for your quick and useful reply, Rohit!

Indeed, the error message is not informative, but the combination should not be possible at all (just like some other combinations are ruled out)


Integrate with GeoConcerns

Work in progress to add GeoConcerns to plum.

Coverage remained the same at 100.0% when pulling 08611d68a98a757e042c58ecd2ec83d70f81de38 on geo_concerns into 9688451be22ee54e08bda8bd418b474049321208 on master.

Coverage remained the same at 100.0% when pulling 9b77aed48771f940546a7fedd3b3dfa01159eeae on geo_concerns into 9688451be22ee54e08bda8bd418b474049321208 on master.

Coverage remained the same at 100.0% when pulling 862232e8d8492671e861bee2af7b4972e6829d89 on geo_concerns into 9688451be22ee54e08bda8bd418b474049321208 on master.

Coverage remained the same at 100.0% when pulling b2cba13e87bbd074ac07594ebce4c9926e4f911b on geo_concerns into 9688451be22ee54e08bda8bd418b474049321208 on master.

Coverage remained the same at 100.0% when pulling fa533676c57be2ce86fd7b21e031a8e808dbb243 on geo_concerns into 9688451be22ee54e08bda8bd418b474049321208 on master.

Coverage remained the same at 100.0% when pulling d50563d664c73d22902ecf01b0b5cdd960903c85 on geo_concerns into 9688451be22ee54e08bda8bd418b474049321208 on master.

Coverage decreased (-3.9%) to 96.056% when pulling 70990625abd915d7d4ac6fa8227c5ee8b2c96a9f on geo_concerns into baddd23bff040ef8a69705267b92a995bc8013e2 on master.

Coverage decreased (-4.01%) to 95.986% when pulling 88c6921dc8f5700d4470eca4f415b8fa51c2a3b1 on geo_concerns into 9688451be22ee54e08bda8bd418b474049321208 on master.

Coverage remained the same at 100.0% when pulling 70990625abd915d7d4ac6fa8227c5ee8b2c96a9f on geo_concerns into baddd23bff040ef8a69705267b92a995bc8013e2 on master.

Coverage remained the same at 100.0% when pulling df79daf6aeb2d5d38d12cf4fd48be961e37c17c3 on geo_concerns into baddd23bff040ef8a69705267b92a995bc8013e2 on master.

Coverage remained the same at 100.0% when pulling df79daf6aeb2d5d38d12cf4fd48be961e37c17c3 on geo_concerns into baddd23bff040ef8a69705267b92a995bc8013e2 on master.

Coverage remained the same at 100.0% when pulling dcda02252b4ecf3e14f9578f4d853257c397f236 on geo_concerns into baddd23bff040ef8a69705267b92a995bc8013e2 on master.

Coverage remained the same at 100.0% when pulling cfbfa5df83d7573ef7d3aa6103a3c6fdb9a70efd on geo_concerns into baddd23bff040ef8a69705267b92a995bc8013e2 on master.

Coverage remained the same at 100.0% when pulling e2d31c1c4f0a3391c062b31e34a6efeed40e75fe on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling 8f8ec2f08542a3f17d345724e3b062f940ffc6b7 on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling 7f1b13fb080776dba7238d317383c3ad43df6eeb on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling c7d91e56558eda75796b27d6079a44693aee39f7 on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling 16386fdeccce4944169a0c3dcdc12966b054b5cb on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling 44b1badad090b5871c2397541969afe6bb41bce8 on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling a4fe9c2e5fcc3eb70b7d21309033b51719400766 on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling a4fe9c2e5fcc3eb70b7d21309033b51719400766 on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling 224d30fccbb854fc4f80a1d20196d37d8b14e3a6 on geo_concerns into 84919a29943b7853ddf3ed18b4098944c90363da on master.

Coverage remained the same at 100.0% when pulling 0f2a72e4e6d9a91cfeb72c23dc61d1014cef7c78 on geo_concerns into d30f219960a8d9b0b25fe2a3eee6635c89daa8ce on master.

Coverage remained the same at 100.0% when pulling b2e94cbbe93e760aca1443ebc66d6c450552c915 on geo_concerns into d30f219960a8d9b0b25fe2a3eee6635c89daa8ce on master.

Coverage remained the same at 100.0% when pulling e343f461717e425b923c20e77874391d7b79464e on geo_concerns into d30f219960a8d9b0b25fe2a3eee6635c89daa8ce on master.

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>feb16043d20c2ccecc3fef2ce59d3c on geo_concerns into d30f219960a8d9b0b25fe2a3eee6635c89daa8ce on master.

Coverage remained the same at 100.0% when pulling 92be3249434c08fd4b2cecb20bef4015748272db on geo_concerns into d30f219960a8d9b0b25fe2a3eee6635c89daa8ce on master.

:tada:


After User settings → {Email, Full name, Password} → Esc, clicks leak through the settings modal

In User settings, when you click on the Email, Full name, or Password setting to open a nested modal, then press Esc, then try to click on one of these settings again, the second click doesn’t work; it leaks through to the view behind the settings modal.
This was introduced by #10985: opening the nested modal sets pointer-events: none on #settings_overlay_container, and Esc does not unset this.
Cc @Z0Marlin.

@zulipbot claim

@andersk PR for review #16693
I have added an event listener for Escape Click which reset what you mentioned. Still I am getting Backend test failure(on Ubuntu 20.04).
On Circle Ci It passes on Ubuntu 18.04 bionic.

@zulipbot abandon

The last commit of https://github.com/zulip/zulip/pull/16062 should have fixed this.
https://github.com/zulip/zulip/pull/16693#issuecomment-721551490

#16062 isn’t merged.


ENH: Allow step scan to not fill events

Cherry-picking from #186 for imminent tagging of 0.1. The rest can go in a micro release and be deployed with minimal effort.

@ericdill, @tacaswell convinced me that we should just merge this more or less as is (but for now make it non-verbose by default) while we discuss a long-term plan.


Support WHERE on querybuilder insert as part of conflict resolution

Is your feature request related to a problem? Please describe.
I'm attempting to insert into a table using querybuilder. This table has a partial unique index. In order to correctly do this, Postgres needs the partial index to be specified in a WHERE clause. See https://stackoverflow.com/a/54169587 for more details.
However, it appears that when adding a WHERE clause to an insert query, it's entirely ignored.
Describe the solution you'd like
When specifying a WHERE condition using an insert query builder, it will be appended to the ON CONFLICT clause (at least in Postgres).
Describe alternatives you've considered
Arguably a better solution (though not mutually exclusive) would be to provide ON CONFLICT resolution as part of entity manager's create options. If I could just issue a create command and specify that I want conflicts to be ignored, that would be even better.

After digging into the code, it appears that WHERE conditions are already in use as part of the on conflict, but are only used as merge resolution and not as part of the actual conflict clause itself.


Use prepared statement metadata to decode results of prepared statements

As of now (075ad419649984b7d901ae04b8bfa56783340095), when executing a statement - no matter if prepared or unprepared - we always request full result metadata to be returned in response. This metadata contains information about the type of each column returned in response, and we use it to decode rows from the response.
However, for prepared statements, this information is not necessary - the same metadata can be returned by the DB when the statement is being prepared and can be cached by the driver. When executing prepared statements, we can request the metadata to be omitted in response and use the cached metadata instead, which will save some bandwith.
There is at least one problem this approach is known to have, so we should discuss how to handle it: https://docs.datastax.com/en/developer/java-driver/3.0/manual/statements/prepared/#avoid-preparing-select-queries

Requesting the full metadata on every SELECT could cause significant overhead.
Recently a user reported that on the same workload Rust driver uses 60MiB/s while the C++ driver uses only 23MiB/s. (https://scylladb-users.slack.com/archives/C01D7LCL44D/p1695956648707279)
For a SELECT with only a few int values sending the metadata could easily double the used bandwidth.
I suspect that this could be caused by us not using the skip_metadata flag.


feat(texture): add TextureManager

This PR introduces the TextureManager, an in-memory cache for THREE.Textures used to render model formats.

Codecov Report
Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (4d672be) 29.47% compared to head (c516a48) 27.45%.

Files
Patch %
Lines

src/lib/TextureManager.ts
0.00%
44 Missing and 5 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   29.47%   27.45%   -2.03%
==========================================
  Files           8        9       +1
  Lines         665      714      +49
  Branches      164      176      +12
==========================================
  Hits          196      196
- Misses        390      434      +44
- Partials       79       84       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


corrected description of event_type 1 records

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Approach

Commands to test

Screenshots

Learning

fixes #6471

Thank you, Jonathan! Based off of @jpomfret's response, this seems like a reasonable change.


Aligned calendar's _dateAllowed with other layers

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable


IMPORTANT! Rollback of stable branch

I noticed that the code in the stable branch was completely broken. I rolled it back to the last PR before the refactor PR of Thomas. I would like to mention some things that would maybe improve our workflow and code quality (open for discussion):

Don't immediately remove the branches after merging... Why? Because if we have a situation like this, where the code has to be rolled back. I can't get back the code in the deleted branches, losing all the commit history.. Remove it after the code has been fully tested and merged in to stable..
Don't merge the PR if you are not the creator of the PR.
Don't set PR destination from topic-* branches to stable branch. Create the PR to main branch instead.
Main branch is used to provide beta releases. Stable is Stable.. Meaning stable has tested* and working software
Don't ignore the workflows. Workflows give really good indication of the code being merged or proposed in PR.
When refactoring, refactor everything including tests, if you don't understand how to refactor certain parts, ask for help.. Don't make pr of half complete code. It will break literally everything.
When working on refactor,  it is important that the other people in the repo know that you are working on it. Because refactors are risky because they tend to break code.. We should find a way to make that clear.. Maybe make an issue and when proposing in PR set title to REFACTOR! [Things refactored].
I made some mistakes too. I didn't criticize the code in PR well enough.. and let this all happen :disappointed:

The way i have written this message might come over as rude or direct. Don't mean to be rude.. But want to make this clear.
*Some software in stable still has no unit tests :disappointed:

If we all come to agreement.. I will close this issue

Discussed!


How to request with OAuth2 Toolkit

my environment:
Python==3.6.1
Django==1.11.6
djangorestframework==3.7.1
django-rest-swagger==2.1.2
django-oauth-toolkit==1.0.0
i've request using [Try it out!] button like below.
but headers does not contain "Authorization Bearer blablabla"

my settings:
SWAGGER_SETTINGS = {
    'SECURITY_DEFINITIONS': {
        'petstore_auth': {
            'type': 'oauth2',
                 'description': 'test',
                 "flow": "password",
                 "tokenUrl": "http://localhost:9010/token/",
                 "scopes": {
                         "read": "read scode",
                         "write": "write scode"
                 }
        }
    },
 "SHOW_REQUEST_HEADERS": True,
 "SECURITY": [{
         "password": ["read", "write"]
 }]
}

The button on the top right is shown below.
[Authorize] button on the top of right  is shown below.

It does't show Client_ID and Client_Secret
How to fix it???

Any update on this?
@googolhkl  were you able to solve the issue? Kindly share your experience. I'm facing the same issue.

I changed the platform to built in API document.
see detail: Built-in API documentation

have a good time :)
@prafulbagai

For me also it is same, When I click authorize it redirects to a page like this

Is there anyway to provide the client_id parameter?

@TharinduDR I also got the same problem now, but you can pass that error by copy pasting your client id in the url and set appropriate redirect uri in your application ( it wants to redirect to o2c.html ). But i got invalid scope error after that and the redirect uri from the swagger io doesn't make sense. it want to go to o2c.html. I search it but didn't find another solutions. Hope someone can solve this

@bloodb4th How did you manage to include client id in the url? can you show me your SWAGGER_SETTINGS section?

@TharinduDR I add it manually by editing the url in the browser. Now i realize it after a further research that OpenAPI that use in this swagger is already in version 3.x while in this package is still version 2.x. Here is the issue in the swagger-ui repo: https://github.com/swagger-api/swagger-ui/issues/2837. Pretty frustrating how to solve this issue.


changes in error shown

Notes for Reviewers
This PR fixes #11414
Signed commits

[ ☑] Yes, I signed my commits.

Thanks! We need to ensure that there is a central location in which mesheryctl identities the need for authentication and offers the same (written in only one place in the code) message back to the user.

@pranjalg1331 thanks, can you fix conflicts please

Can you fix conflicts, your branch seems not to be sync with master

I think the conflict is solved now


Cleanup legacy services in favor for CodeAnalysis.Razor alternatives

Today we have copies of several of our public API services in Microsoft.VisualStudio.LanguageServices.Razor. We should remove those and export the newer variants of those from Microsoft.CodeAnalysis.Razor.Workspaces.

[x] EditorSettingsManager
[x] RazorIndentationFactsService
[x] RazorSyntaxFactsService
[x] TagHelperCompletionService
[x] TagHelperFactsService
[x] Internalize RazorTemplateEngineFactoryService, TagHelperResolver, RazorDiagnosticJsonConverter
[x] Delete RazorEditorParser

44a47182b229ef998c9e520eb5d3a4f5d8c7fae1
de23788019fc83400be7f60335eed6032c60162c
44e58740290f8622f8f83ecf7c3ff5c7728b64b6
44b4bf6bc607a3748feb6b1b8a91c42b5e539579
520876e55d3bb86d90b3bf22e4c71db07283dd58
458111ad03c8b46a8a1ebab472f3b23f845415c3
6cf78ceb1bbdfd0a8d573925f09fd540f5f146c1


Selecting time does not work very precisely when finger's outside of the clock.

Title. As soon as I move my finger inside the clock, everything works fine.

Please add reproducible snack so we could fix this, currently it takes too much work to reproduce issues like this

Literally just create a basic component and try my issue. I didn't proceed further than that.


Revert "Remove ardana-init.bash script"

The package uses this script as source so it is still needed.
Reverts SUSE-Cloud/automation#2394

Deobfuscating the above description for future reference: "the package" is referring to https://build.suse.de/package/show/Devel:Cloud:8:Staging/ardana-ansible


extension-home-page: the secret life of badges

What code changed, and why?
Adding feedback channels and adding new badges.

About Badges
It is difficult to say when badges first started being used in top-level README.md files, but they have definitely hit their stride when it comes to providing quick access to key facts about a VS Code extension. There are a lot of extensions that do not use them, but those that do have a certain... panache to them... so naturally it makes sense to use them for our Styra extension. 😁
The starting point for all-things-badge is https://shields.io/, the premier source of badges deemed acceptable by Microsoft in VS Code extensions. (Almost all of the other badge providers listed there are for specific products, whereas shields.io is not product-specific.)
And, indeed, 5 of the 6 badges I am using come from shields.io.

Badge
Static or Dynamic
Parameterized?
Link Target

Slack
static
color set in the "file name"
https://styracommunity.slack.com/

License
static
color set in the "file name"
https://www.apache.org/licenses/LICENSE-2.0

Version
dynamic from marketplace data
color parameter in URL
none

Code coverage
static/from README.md file--must be updated by running npm test
color based on scripted thresholds
none

CI status
dynamic from github data
color (presumably) set by status
https://github.com/StyraInc/vscode-styra/actions/workflows/main.yaml

Closed PRs
dynamic from github data
none
https://github.com/StyraInc/vscode-styra/pulls?q=is%3Apr+is%3Aclosed

A note on code coverage: unlike things like CodeCov that have dynamically-sourced badges, I am not using anything special for code coverage, just the coverage generation built into jest. So whenever one runs tests (npm test) there is a post-test script that updates the code coverage value and color in the README.md with the results from the test run. So the only thing the developer has to do is commit that change in their PR. Lest he or she forget, I have also added a "staleness" check for that, attached to the github test action. At the high level, the test check would show failure; and the details would show this (I have highlighted where the code coverage hypothetically changed from 65% to 70%):

Definition of done

[x] Adding Styra community slack to readme and to rego_help snippet.
[x] Adding GitHub issues and discussions links to readme.
[x] Adding additional badges to top of readme (slack, CI status, PR count).
[x] Add staleness check for committing the updated code coverage.
[x] Bonus: Added documentation line in readme for recently added VS Code setting.
[x] Bonus: A few minor doc/comment tweaks.

How to test
You can install either from source code or from GitHub.
Install from source

Switch to current branch.
Run npm install.
Open project in VSCode.
In the debugger be sure you have "Run Extension" mode selected.
Invoke "run" (F5).

Install from GitHub

Go to the latest release on the release page.
Download the additional version piggybacked into that release, labelled vscode-styra-n.n.n-next.N.vsix.
Install via the standard command: code --install-extension vscode-styra-n.n.n-next.N.vsix

Exercise the Code
Review extension home page
Related Resources
STY-16136

@mstade Regarding your comment on the long feedback loop: yes, it is (both long and annoying).  It requires running the full test suite so that would make the push take perhaps a full minute. So going to stick with the current approach for now.


Login account does not work after running qemux

After building qemux86, I was asked to login but have no idea of the account.
Should we add "debug-tweaks" when building?

I tested with below commands,

jinyo@cdp2:~/work/openwebos/open0814$ runqemu BUILD/deploy/images/qemux86/bzImage-qemux86.bin BUILD/deploy/images/qemux86/webos-image-qemux86.ext3 ext3

But I can't login

qemux86 login: root
password : (Enter)
Login incorrect


dotnet sln add broken in our project generation

I've just generated a new API, and the solution file is empty. Running dotnet sln add path/to/csproj I get an error message of:

Project '...Project.csproj' has an unknown project type and cannot be added to the solution file. Please contact your SDK provider for support.

I suspect this is related to the VS15.8 update...

Looks like it's due to this: https://github.com/dotnet/cli/issues/9477
It appears to be fixed in SDK 2.1.400, so we could potentially update to that?
cc @chrisdunelm for thoughts.

Upgrading to 2.1.400 seems like the best option to me (assuming it really is fixed there!)

It's definitely fixed there, yes - temporarily updating to that generated the correct solution file. My only concern is Travis/AppVeyor/Kokoro support. Will investigate.

sgtm


fix: secondary button test case

Background

Modification

Caveats

Testing

Results/Screenshots

Type of Deploy/Submission Required?

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support jest-like moduleNameMapper in vitest

Clear and concise description of the problem
Sometime we have to deal with non-standard third-party packages, such as replace xxx/es/ to xxx/lib which are no need in "vite dev / build" so that CANNOT set with resolve.alias but ONLY need in testing phase, and it's also NOT satisfy vitest deps.fallbackCJS mode.
Suggested solution
Maybe support some configuration like jest moduleNameMapper.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Use config option resolve.alias.

@sheremet-va  such as replace xxx/es/ to xxx/lib which are NO need in "vite dev / build" but ONLY need in testing phase

@sheremet-va such as replace xxx/es/ to xxx/lib which are NO need in "vite dev / build" but ONLY need in testing phase

Use process.env.VITEST or mode === 'test' to distinguish between test and dev env.

Ugly, and that's why vitest has a fallbackCJS mode to do those alias.

Expose the capability to the user is better than hide everything behind guessCJSversion.

We expose this capability with resolve.alias.
guessCJSversion is a fallback option that was enabled some time ago to run wrongly packaged nom packages. It is disabled by default now, and might be removed in the future, because we found a better solution. Please, use resolve.alias, deps.inline or vitest.config.ts to run your tests with different config. If you write "ugly" code, there is nothing we can do to help you, sorry.

"because we found a better solution" <- What is that?

"because we found a better solution" <- What is that?

Check isValidNodeImport.

Strictly speaking, packages should define valid exports field. If cjs version should be loaded, it should be defined with "require": "cjs". If they are not, this is not a problem with Vitest.
More about this: https://github.com/sheremet-va/dual-packaging

Is that deps.inline not compatible with jsdom environment？

vitest config here:
  test: {
    include: ['src/**/*.test.(ts|tsx)'],
    globals: true,
    environment: 'jsdom',
    deps: {
      inline: true,
    },
  },

Should this needs open with an new issuse?

Strictly speaking, packages should define valid exports field. If cjs version should be loaded, it should be defined with "require": "./file.cjs". If they are not, this is not a problem with Vitest.
More about this: https://github.com/sheremet-va/dual-packaging

There is no doubt, that's exactly correct, I couldn't agree more!
However, as this issue said at first,
Sometime we have to deal with non-standard / wrongly / uncontrolled third-party packages  ☹

Should this needs open with an new issuse?

Do you have jsdom installed?
deps.inline: true means every file will be processed by Vite, including node_modules. You can use string or RegExp to inline only needed packages.

Sometime we have to deal with non-standard / wrongly / uncontrolled third-party packages ☹

I hope you are also opening issues in this packages, so others don't need to deal with it 😄

Yes, I have tell those maintainers about the issues for fix some days ago before open this issue in vitest.

Because of the time, I want to try some way to bypass the problem before they fixed and publish a new version.
I have tried to use deps.inline: true (with install jsdom fix the error above) and also vitest.config.ts with resolve.alias, but nothing works.
With resolve.alias, the reason maybe vite use @rollup/plugin-alias which use @rollup/plugin-node-resolve cannot make alias for sub-dependencies with  PNPM。

In my research I found this solution:
https://divotion.com/blog/how-to-configure-import-aliases-in-vite-typescript-and-jest
And in my case it worked.


Offline version of .NET API browser

Is your feature request related to a problem? Please describe.
Lack of proper offline access to .NET Core API Reference is really frustrating.
Describe the solution you'd like
One of the best offline experience I had was with https://devdocs.io/, exposing docs to this common dev reference would be the best option.
Describe alternatives you've considered

Even offline/online align to WHATWG support on main docs page would be incredibly useful.
Least amount of work but also supporting my use case would be PDF with hyperlinks.

Additional context
Using dotnet core during prolonged offline session like in airplane or regions with low 3G/LTE coverage can be extremely frustrating.

Thanks for your feedback @rwarzycha. Do you develop using Visual Studio? If so, there are offline books available for Visual Studio for a couple of docsets including .NET Core API reference.

Hi @mairaw, most of the time I'm using Visual Studio Code. Where can I find these docsets from Visual Studio 2019? I was able for all namespaces of should I download them separately.

@rwarzycha - thank you for the feedback! We definitely have room for improvement for our offline documentation experience. Tagging this for myself to investigate.

@rwarzycha for Visual Studio, this article explains how to obtain the offline books: https://docs.microsoft.com/en-us/visualstudio/help-viewer/installation

Any news on this? Is there a way to get .NET 6 API Docs for VS Code or through other means?

@philippjbauer I'll chime in as an uninvested third-party, since I no longer work at the company, but the only way to do this is to download the documentation locally and build IntelliSense files from it. mdoc might be helpful here: http://docs.go-mono.com/index.aspx?link=man:mdoc-export-msxdoc(1) (tagging @joelmartinez as the expert here).

Thank you @dend, I'll look into this!


Robustness metrics

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #497

[x] Tests for the changes have been added (for bug fixes / features)
[x] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
Adds the xclim.robustness module with its robustness function. It takes in the ensemble distribution of an indicator and returns a categorical map qualifying the level of agreement between members. Implementation is following articles listed in box 12.1 of Chapter 12 of the Working Group 1 AR5 Report (IPCC).

This PR will implement method "C", Knutti and Sedlacek (2013), which returns a floating robustness metric R and method "D", Tebaldi et al. (2011), which returns a mapping with values for "no significant change", "change but no agreement on sign", "change and agreement on sign".
In the perspective of expanding the available methods, the submodule is structured similarly to xclim.analog : a master function takes DataArrays and a method name as input and then runs a apply_ufunc call for the given method, vectorizing it along the spatial dimensions. Metrics are defined as functions accepting numpy arrays and wrapped with the metric decorator that does some overhead work and registers the method.

Does this PR introduce a breaking change?
No.

Other information:
Translating scientific articles to python functions has proven quite difficult here. If someone can compare the code with the article, I would be grateful. I haven't found other implementations of these metrics elsewhere to compare.

Pull Request Test Coverage Report for Build 2415

0 of 53 (0.0%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.4%) to 91.217%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xclim/robustness.py
0
53
0.0%

Files with Coverage Reduction
New Missed Lines
%

xclim/subset.py
3
62.5%

Totals

Change from base Build 2414:
-1.4%

Covered Lines:
3365

Relevant Lines:
3689

💛  - Coveralls

Thinking that would better organize the code, I moved the "ensembles" module to a folder, dividing the methods in to 3 files: "base", with create_ensemble and the ensemble statistics, "reduce", with the kkz and kmeans ensemble reducing methods and "robustness" with the new ensemble robustness metrics.
Also, added tests are a bit fragile. For the "knutti_sedlacek" metric I tested my code against itself, so yeah.

@martinleduc @RondeauG Est-ce que vous avez déjà utilisé ce genre de métrique ? Êtes-vous capable de valider ce PR ?

Possibly ? I would have to read the paper to see how it compares to what I'm currently implementing (based on Sanderson, Knutti & Caldwell 2015). Given that Knutti is involved in both, there are probably parallels to be done. I can look at it tomorrow or next week.

Allô,
Je suis en train de faire des choses sur ce sujet pour les vents dans le projets éolien à partir des méthodologies cités dans plusieurs études CORDEX. Dans mon cas, la conclusion serait que les membres de l'ensemble s'entendent sur l'insignifiance du changement. Je suis trop dans le jus (finir le dit projet éolien!) pour regarder le code, mais je sais déjà qu'il faut préalablement détecter un changement significatif dans un certain pourcentage des membres. Si je n'est pas dans les références citées, nous allons publier sur ça (j'en discute surtout avec @martinleduc ). Je vous envoie quelques diapos.
Il devrait y avoir de la flexibilité sur:

le choix du test statistique
choix du niveau de signification
le choix du % des membres qui ont détecté un changement significatif
-le choix du % de membres de l'ensemble pour le niveau de consensus sur le signe du changement
WEC2100_steering_commitee_20200505_HCote_extrait.pdf

Last commit is a draft of a refactor following reviews.
My suggestion is to divide ensemble_robustness in two:

ensemble_robustness : Calculate the fraction of members showing significant change and the fraction of those members agreeing on the sign of change. Takes in ref and fut, the reference and future period values of the given indicator, both along realization and time. Also takes the name of the statistical test used for testing significant change (as the  stat argument) and kwargs related to that test. Returns a dataset with two variables : change_frac and sign_frac.
Right now, the tebaldi_et_al method as been translated to stat='ttest'. I'm understanding that what @RondeauG  calls the "IPCC" method, would simply ignore the "significant change" part.

robustness_map : From the results of ensemble_robustness and user-provided threshold X and Y, returns a categorical map with integers 0, 1, 2. This one would thus be more a convenience method, given its simplicity. We could offer a possibility for having two Y thresholds, like in the IPCC reports.

knutti_sedlacek would be a third (standalone) method of the submodule.
From what I understand from this thread, this should cover most use cases?
If we go back to box 12.1 of chapter 12 of the AR5 contribution of WG1 (or in short AR15WG1C12B12.1):

Methods A and B need 500 years of pre-industrial runs to compute climate internal variability. I am guessing that this quite a niche thing to come by. However, we could let the user provide it's own estimation of  internal variability. But that doesn't quite plug into the suggest framework...
Method E could also be implemented in the future. AFAIU, it would also be a second standalone method, because its categories are different than the suggested robustness_map. This is why I first suggested a function returning different categories, but I realize that this was too narrow in its generality.

Ok, so I abandoned the robust_map method, it seems so easy yet so customizable that I can't see a solid use case for a "hardcoded" xclim method.
Also, ensemble_robustness was renamed to change_significance and it outputs 2 DataArrays instead of a dataset. I added Welch's T-test, as this is what @cothel seem to use and it's easy to add those.
Also added the None  method, that acts like all members show significant change and only computes the sign agreement fraction. It seems that @RondeauG, was doing that a some point?
I renamed hist to ref and sims to fut.
Let me know what you think of all this. Sorry for the multiple refactoring...

I think this is good to go !

Last commit made some fixes to the documentation : I moved the "ensembles" api higher in the API page, divided it between base/reduction/robustness and added a introduction paragraph to robustness with a reference to AR15WG1C12B12.1.
And bumped the version.

Adaptation to be able to pass deltas as first argument. Also, new test threshold for simple absolute or relative delta thresholds.
New test and example in the docstring.
This adds complexity and a few conditional cases in the docstring... I hope it is still clear.

Peut-être c'est la fin?
I fixed some edge cases with the new nan policy. Also adapted tests and completely implemented accepting Datasets as inputs. It was already feasible, but with some edge cases. When using datasets, fut and ref must be of the same type and have the same variables, otherwise it's quite transparent.
          _      _      _
          >(.)__ <(.)__ =(.)__
           (___/  (___/  (___/

Two tests are failing on my end:

================================================================================================ FAILURES =================================================================================================
__________________________________________________________________________________ test_change_significance_delta[True] ___________________________________________________________________________________
robust_data = (<xarray.Dataset>
Dimensions:  (lon: 4, realization: 4, time: 40)
Dimensions without coordinates: lon, realization, ti..., time
Data variables:
tas      (lon, realization, time) float64 dask.array<chunksize=(1, 4, 40), meta=np.ndarray>)
def test_change_significance_delta(robust_data):
    ref, fut = robust_data
    delta = fut.mean("time") - ref.mean("time")
    chng, sign = ensembles.change_significance(delta, test="threshold", abs_thresh=2)
    if isinstance(ref, xr.Dataset):
        chng = chng.tas
        sign = sign.tas

  np.testing.assert_array_equal(chng, [0, 0, 0.5, np.nan])

tests/test_ensembles.py:561:

x = array([0. , 0. , 0.5, 0. ]), y = array([0. , 0. , 0.5, nan]), func = <ufunc 'isnan'>, hasval = 'nan'
def func_assert_same_pos(x, y, func=isnan, hasval='nan'):
    """Handling nan/inf.

    Combine results of running func on x and y, checking that they are True
    at the same locations.

    """
    x_id = func(x)
    y_id = func(y)
    # We include work-arounds here to handle three types of slightly
    # pathological ndarray subclasses:
    # (1) all() on `masked` array scalars can return masked arrays, so we
    #     use != True
    # (2) __eq__ on some ndarray subclasses returns Python booleans
    #     instead of element-wise comparisons, so we cast to bool_() and
    #     use isinstance(..., bool) checks
    # (3) subclasses with bare-bones __array_function__ implementations may
    #     not implement np.all(), so favor using the .all() method
    # We are not committed to supporting such subclasses, but it's nice to
    # support them if possible.
    if bool_(x_id == y_id).all() != True:
        msg = build_err_msg([x, y],
                            err_msg + '\nx and y %s location mismatch:'
                            % (hasval), verbose=verbose, header=header,
                            names=('x', 'y'), precision=precision)

      raise AssertionError(msg)

E           AssertionError:
E           Arrays are not equal
E
E           x and y nan location mismatch:
E            x: array([0. , 0. , 0.5, 0. ])
E            y: array([0. , 0. , 0.5, nan])
../../.conda/envs/xclim/lib/python3.6/site-packages/numpy/testing/_private/utils.py:740: AssertionError
__________________________________________________________________________________ test_change_significance_delta[False] __________________________________________________________________________________
robust_data = (<xarray.DataArray 'tas' (lon: 4, realization: 4, time: 40)>
array([[[274.58932717,<PHONE_NUMBER> ,<PHONE_NUMBER>2, 273.62...<PHONE_NUMBER>7,<PHONE_NUMBER>8,<PHONE_NUMBER>8,<PHONE_NUMBER>6]]])
Dimensions without coordinates: lon, realization, time)
def test_change_significance_delta(robust_data):
    ref, fut = robust_data
    delta = fut.mean("time") - ref.mean("time")
    chng, sign = ensembles.change_significance(delta, test="threshold", abs_thresh=2)
    if isinstance(ref, xr.Dataset):
        chng = chng.tas
        sign = sign.tas

  np.testing.assert_array_equal(chng, [0, 0, 0.5, np.nan])

tests/test_ensembles.py:561:

x = array([0. , 0. , 0.5, 0. ]), y = array([0. , 0. , 0.5, nan]), func = <ufunc 'isnan'>, hasval = 'nan'
def func_assert_same_pos(x, y, func=isnan, hasval='nan'):
    """Handling nan/inf.

    Combine results of running func on x and y, checking that they are True
    at the same locations.

    """
    x_id = func(x)
    y_id = func(y)
    # We include work-arounds here to handle three types of slightly
    # pathological ndarray subclasses:
    # (1) all() on `masked` array scalars can return masked arrays, so we
    #     use != True
    # (2) __eq__ on some ndarray subclasses returns Python booleans
    #     instead of element-wise comparisons, so we cast to bool_() and
    #     use isinstance(..., bool) checks
    # (3) subclasses with bare-bones __array_function__ implementations may
    #     not implement np.all(), so favor using the .all() method
    # We are not committed to supporting such subclasses, but it's nice to
    # support them if possible.
    if bool_(x_id == y_id).all() != True:
        msg = build_err_msg([x, y],
                            err_msg + '\nx and y %s location mismatch:'
                            % (hasval), verbose=verbose, header=header,
                            names=('x', 'y'), precision=precision)

      raise AssertionError(msg)

E           AssertionError:
E           Arrays are not equal
E
E           x and y nan location mismatch:
E            x: array([0. , 0. , 0.5, 0. ])
E            y: array([0. , 0. , 0.5, nan])
../../.conda/envs/xclim/lib/python3.6/site-packages/numpy/testing/_private/utils.py:740: AssertionError
============================================================================================ warnings summary =============================================================================================


Visual Studio compatibility

This patch has two minor fixes for compatibility with Visual Studio, and adds project files for the examples. The project files expect python 2.7 installed in C:\Python27, but if you have Python 2 installed in another directory you can set an environment variable named PYTHON pointing to the proper directory.

Awesome!
Would you care to add the information about the PYTHON environment variable to the readme?
Then I'll merge it.

Updated the readme with instructions
I have also added a small note about installing the python-dev package under Linux. I hope you don't mind me shoving that in with this pr.

Nice.


Add UniqueAssignmentList to class diagrams

Codecov Report

Merging #227 (96a48c7) into master (c4c1eec) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #227   +/-   ##
=========================================
  Coverage     53.90%   53.90%
  Complexity      684      684
=========================================
  Files           126      126
  Lines          2805     2805
  Branches        381      381
=========================================
  Hits           1512     1512
  Misses         1170     1170
  Partials        123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c1eec...96a48c7. Read the comment docs.


Re -render

I am refactoring my code using xstate, in the class components I have used xstate machine and passed service as a prop to its children but when I am updating the machine state component is not re-rendering.
I have started the machine service in ComponentDidMount, anything else we have to do while using service in the class component

Did you solve the issue?


V8 async implementation

With removing the deno_core dependency, the onUpdate and onStart functions were implemented as sync functions.
The runtime API implemented (only the EngineApi) is now a blocking-sync API instead of async.
For async functions such as fetch, WebSocket and EthereumController, it'll be required to implement an event loop and async support.

https://github.com/decentraland/godot-explorer/pull/41


Prevent backend from crashing

Errors on requests to javascript backend cause app to crash rather than returning a reasonable HTTP error (even just a 500 would be preferred to crashing). Crashing should only occur if there is something unrecoverable that requires the docker container to restart. Ideally this isn't something to worry about and we'll just be responding to 500 errors that exist.

Might require to be watched in the future. A limitation is that it does not have except and capture. Fix for now, but a lil shaky. A global exception filter was previously enabled, but @memosys disabled.


refreshenv not working

My 'refreshenv' is not working. After I commented out @echo off at the first line of refreshenv.cmd I found this logs on my command prompt.Any ideas why?

Please open this in https://github.com/chocolatey/choco


support client_id param in get user roles endpoint

https://github.com/edenlabllc/ehealth.api/issues/744

Changes Unknown when pulling dbe020c9adb9787fd828a59fc5e1d10479884931 on current_user_roles_endpoint#744 into ** on master**.


fix(readme): update readme

Using fix to verify semantic-release is functional through GitHub Actions.

:tada: This PR is included in version 2.10.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Rule 1.4.1 typo and doesn't work unless lines already exist (cis_2.0.1 branch)

Describe the Issue
Fails to create a bootloader line on fresh installs where the line doesn't already exist
Expected Behavior
Should create the bootloader line even if the entries are not there yet
Actual Behavior
Control(s) Affected
1.4.1 Ensure bootloader password
Environment (please complete the following information):

Ansible Version:  ansible [core 2.15.2]
Host Python Version: Python 3.8.10
Ansible Server Python Version: Python 3.10.12
Additional Details: branch is cis_2.0.1

Additional Notes
Anything additional goes here
Possible Solution
Enter a suggested fix here

hi @dderemiah
Thank you for raising this issue, apologies for the time it has taken to get addressed. We believe it the fix has now been applied and merged today.
Please let us know if this is still an issue?
many thansk
uk-bolly

hi @dderemiah
Have managed to fix the issue with the pipeline and all is now merged into devel. Thank you again fr your feedback and PR.
uk-bolly


Vstest.console.exe exited with code -1073741819.

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: VsTestV2
Environment

Server - Azure Pipelines

Agent - Private

OS is Windows 10 2004, Agent version is 2.175.2
Issue Description
One of our pipelines is throwing the following exception or completely locking up when running tests. The exception/lockup always occurs after the same amount of time. I have ruled out it being related to a test by removing the test it normally happened on but the issue still occurred. This is a large pipeline running automated UI tests and normally takes about 11 hours to run and runs about 1000 tests, the issue seems to occur after about 4 hours into the test run. I have many other pipelines that are running fine and this issue seems isolated to one specific pipeline. This issue seems to have randomly started happening and this pipeline has been running fine for years until this point. We have many agents and this seems to be occurring on all agents with this pipeline.
Task logs
I have attached two sets of logs. One zip contains logs without debug turned on but this contains the Vstest.console.exe exited with code -1073741819 exception, the other zip contains logs with debug turned on but this pipeline froze and I had to manually cancel it.
LogsNoDebugWithError.zip
LogsDebugHang.zip
I also took a dump of the vstest.console whilst it was hung. This is too big to attach so I've uploaded it, you can download it here: https://1drv.ms/u/s!AuEBsQuFR6hBixnddXg4AG3Sn9Ln?e=8Pkk4C
Error logs
Vstest.console.exe exited with code -1073741819.
**************** Completed test execution *********************
Test results files:
##[error]Error occurred while publishing test results : MS.VS.TestService.VstestConsoleAdapter.NoTrxFoundException: No trx files found in the specified test results directory C:\Build Agent\_work\_temp\TestResults.
##[error]Skipping marking test run as complete as test run id 0 is invalid.
Completed TestExecution Model...
##[warning]Vstest failed with error. Check logs for failures. There might be failed tests.
##[error]Error: The process 'C:\Build Agent\_work\_tasks\VSTest_ef087383-ee5e-42c7-9a53-ab56c98420f9\2.170.1\Modules\DTAExecutionHost.exe' failed with exit code 1
##[error]Vstest failed with error. Check logs for failures. There might be failed tests.

hey @tomaustin700, seems the issue is specific to vstest.console.exe. you can raise the issue here

Hi @hvinett, can you explain what you mean by 'try one with vstest.console.exe'? Apologies.
Tom

@tomaustin700 I'm transferring this issue to the vstest repo.
Can you get a repro with system.debug = true (which will include the testplatform diag log) that will help the testplatform team get to the bottom of this.

Thanks @ShreyasRmsft, I've turned on debug so will report back when I have some logs. Thanks


Tag translation/20160817.01 breaks npm installation

VSCode Version: 1.4.0
OS Version: Windows 10

npm install vscode --save-dev
The installation of vscode as a dependency seems to be broken because of the new tag translation/20160817.01. The script "node ./node_modules/vscode/bin/install" fetches all tags from the repository and parses them via semver. This operation fails because 20160817.01 is not a valid semver.

@dennisfrostlander I cannot reproduce, are you sure you are using latest vscode as dependency? I think this bug was fixed already in previous releases. Maybe you are on an older vscode version?

Yes, sorry, for some reason I was getting vscode 0.11.0, and I can see now that in 0.11.17 this is already fixed. Apologies for false alarm.

I got the same error last night, but for a different reason. Took me quite a while to figure it out. I use arch for an OS, and the existing packages on the AUR for vscode don't build the nightlies/are broken. So I made my own package that builds from from HEAD.
Anyway, a few days ago I started getting this message:
==> Creating package "vscode-insiders"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
/usr/bin/makepkg: line 1176: /home/rozzzly/Projects/cssculpt/build/misc/vscode-build/package/vscode-insiders-translation/20160817.01.r99.g3d0aea0-1-x86_64.pkg.tar.xz: No such file or directory
bsdtar: Write error
==> ERROR: Failed to create package file.

I waited a few days to see if a fix would come from downstream, and then eventually got impatient and proceeded to spend a few hours of ripping out my hair. I finally realized the issue was that my (arch) package was trying to compress the compiled source into an archive with a name like this.

vscode-insiders-translation/20160817.01.r99.g3d0aea0-1-x86_64.pkg.tar.xz

The bold part is most recent git tag (found via: git describe --tags). Normally, when the tagged version is something like v1.4.0/0.10.1-extensionbuilders/etc, everything works fine. But as of earlier this week, the most recent git tag on master is translation/20160817.01.
This was causing bsdtar to fail because filenames cannot contain /s. I remedied this by using sed to substitute / with . so the file name was was no longer invalid and everything worked.
I didn't bother making an issue for this before because I don't expect the vscode team to support every distro/let alone self-built packages... But I saw this issue so I though I'd post my story here so perhaps someday a dev with a similar issue can find it when googling for fixes.

I see that git tags have caused a very similar issue in the past. Apparently that particular instance of the issue was fixed from within the vscode build script itself, but that didn't prevent that git tag from breaking my package build script. Might I humbly suggest that the vscode team caution contributors against pushing tags containing /s? Such git tags will no longer break my package, nor the vscode build script, but who knows, it could be breaking packages for other distros. Requiring semver-compatible tags would be a bit much, but at least something that could be a valid file name? I think that's reasonable.
Anyway, thanks for the awesome IDE everyone! Much :heart:


Azure Search soft delete from Azure Storage IsDeleted flag

Azure Storage Blob service supports it's own soft-delete feature. Would it be possible to use the IsDeleted state from the Azure Storage blob to detect soft-delete in Azure Search, rather than a custom metadata field on a blob?
Sorry if this is not the right place to file this issue.

@rozele Feel free to ask your question either on Stack Overflow and tag it with "azure-search", or on the MSDN forums. We monitor those two sites, so if you ask your question there, an engineer will be assigned to answer it.
Since this is a product question and not an issue related to the .NET SDK, I'm going to close it.


incorrect versions in requirements.txt

Hi FaceSwap,
Please state the correct versions in requirements.txt:

ERROR: Could not find a version that satisfies the requirement torch==1.6.0+cu101 (from versions: 1.7.1, 1.8.0, 1.8.1, 1.9.0, 1.9.1, 1.10.0, 1.10.1, 1.10.2, 1.11.0, 1.12.0, 1.12.1, 1.13.0)
ERROR: No matching distribution found for torch==1.6.0+cu101
ERROR: Could not find a version that satisfies the requirement torchvision==0.7.0+cu101 (from versions: 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.2.0, 0.2.1, 0.2.2, 0.2.2.post2, 0.2.2.post3, 0.8.2, 0.9.0, 0.9.1, 0.10.0, 0.10.1, 0.11.0, 0.11.1, 0.11.2, 0.11.3, 0.12.0, 0.13.0, 0.13.1, 0.14.0)
ERROR: No matching distribution found for torchvision==0.7.0+cu101
ERROR: Could not find a version that satisfies the requirement onnxruntime-gpu==1.4.0 (from versions: none)
ERROR: No matching distribution found for onnxruntime-gpu==1.4.0
ERROR: Could not find a version that satisfies the requirement mxnet-cu101mkl (from versions: none)
ERROR: No matching distribution found for mxnet-cu101mkl
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
conda-repo-cli 1.0.4 requires pathlib, which is not installed.
anaconda-project 0.10.1 requires ruamel-yaml, which is not installed.

Look at this. I've done the heavy lifting for you. But you need to know some docker basics.
https://github.com/ai-forever/ghost/issues/51


option to disable showing screenshot just before starting a game

After last beta upgrade (31.X) I see that screenshot is shown just before starting a game.
It would be great to have an option to disable that feature.

Ok. I showed on windows & did not activate it in x86 linux. It was a simple forgetting.. Fixed in my next PR


Add method to search for data assets

Acceptance criteria:

[ ] get_data_assets
[ ] a method called search_data_assets
[ ] exposes all parameters of the data asset API
[ ] if start and limit are passed, return the requested number of assets
[ ] if start and limit are not passed, return all matching assets (make multiple requests)

[ ] Create a separate method called search_data_assets

[ ]  Create a separate method called search_data_assets

Updated the acceptance criteria, thanks.

Acceptance criteria:

[ ]  ~get_data_assets~
[ ]  a method called search_data_assets
[ ]  exposes all parameters of the data asset API
[ ]  if start and limit are passed, return the requested number of assets
[ ]  if start and limit are not passed, return all matching assets (make multiple requests)

^ @dyf I think we should use the default behavior provided by codeocean if start and limit are not passed

Acceptance criteria:

[ ]   ~get_data_assets~
[ ]   a method called search_data_assets
[ ]   exposes all parameters of the data asset API
[ ]   if start and limit are passed, return the requested number of assets
[ ]   if start and limit are not passed, return all matching assets (make multiple requests)

^ @dyf I think we should use the default behavior provided by codeocean if start and limit are not passed

We can make it a separate ticket if you want, but I this is functionality I would like.

Acceptance criteria:

[ ]    ~get_data_assets~
[ ]    a method called search_data_assets
[ ]    exposes all parameters of the data asset API
[ ]    if start and limit are passed, return the requested number of assets
[ ]    if start and limit are not passed, return all matching assets (make multiple requests)

^ @dyf I think we should use the default behavior provided by codeocean if start and limit are not passed

We can make it a separate ticket if you want, but this is functionality I would like.

I put this as a separate ticket.


[WIP]: Simple neuroconv deployment

Introduces the one-line helper function deploy_conversion_from_yaml_and_upload_to_dandi to perform the entire cloud deployment stack, along with necessary changes to the batch submission utility introduced in the base of this PR.
Note the one-liner isn't working yet, but I attached detailed instructions for running the utility function in separate stand-alone scripts which is still much easier than doing the entire thing manually.

@CodyCBakerPhD thanks for sharing this. Would you like to convert it to a Draft PR?

TODO

add optional status table updates to YAML conversion side (needs to run in docker image after upload to DANDI)
CI tests

TODO - add cosideration for ctrl-C based termination of job submission - how is cleanup handled?
Example: EFS is created but CLI terminates before jobs are submitted. Ensure EFS gets cleaned up in that case

I am closing this one as all the PRs have been merged and the future TODO is here:
https://github.com/catalystneuro/neuroconv/issues/1103