Officially allow small videos (e.g. mp4)

I saw this was touched on over at #1500, but I figured I'd make a dedicated issue for it:
Any chance of officially blessing mp4 videos for inclusion, either in addition to or in place of gifs?
Could be with the same <2.5MB size guidance, or a stricter (say <1MB) requirement.
I am asking because mp4 files tend to be significantly more size-efficient than gifs; I happen to generate both for my weekly Slow Rush newsletter so I did a quick size comparison using the videos from 5 of my recent newsletter updates:

(source: gif-vs-mp4.ods)
This is not a fair comparison because the gifs are generated at half the size and less than half the framerate of the mp4, but mp4 still gives an 80% size reduction on average. Such a large saving may not universally be the case for all footage (my game is pixel art oriented and, well, kinda ugly and monotonous-looking right now), but from a bit of poking around, to me it seems that to have mp4 do worse than gifs you'd have to actually put in effort to pick bad encoding settings.
FYI, here are the ffmpeg invocations I used (extracted from my png frames -> video conversion script):
# create a 60fps h264-encoded mp4
ffmpeg -nostdin -y -framerate 60 -i $frames_dir/%d.png -c:v libx264 -pix_fmt yuv420p $output_dir/$dest_name.mp4

# create a 24fps gif at _half_ the source resolution
ffmpeg -nostdin -y -framerate 60 -i $frames_dir/%d.png -vf fps=24,scale=iw/2:-1:flags=lanczos", $output_dir/$dest_name.gif

# (in no way am I claiming to be an expert in video codecs.. those invocations may not be optimal!)

It would make sense to require gifs if the newsletter was sent out via email (that's why I generate both gif and mp4 files), but that doesn't seem to be the case here?
Lastly, I get that mp4 is just a container format, and so there's the question of what codec, is h264 legally okay to use, is it morally okay to encourage use of a patented codec, etc. As far as I understand, it is at least royalty-free to distribute free h264-encoded videos.
And if the moral angle is a concern, I'd also be totally fine with allowing webm videos (or animated webp images!), but as of earlier this year, (at least some) iOS web browsers couldn't play the webm movies I was encoding.

TIL, thanks!
The newsletter is planned to be sent via email (#24), so that is certainly something to consider.

Ah, I totally overlooked #24! In that case, AFAIK you can't really get away from including gifs in the emailed version, unless you do something like static image previews of videos that link to the real video.
Or have a build step that transcodes the videos to gifs, stores them elsewhere, and thereby keep the repo size a little more under control. Depends on how much complexity you are willing to deal with.
Since I am already generating gifs, it is not a problem for me to keep submitting them - I was just surprised at how long it took to clone this repo and that mp4s were preferred over videos in the contributing guidelines.

Yep, the repo size is definitely a problem. See https://github.com/rust-gamedev/rust-gamedev.github.io/issues/636.

Update: https://github.com/rust-gamedev/rust-gamedev.github.io/pull/1529 added an {{ embed_video }} shortcode (thanks @caspark!).
I'll close this issue once we've documented that somewhere.


Task26,27,28

completed Task26 , Task27 ,Task28

SourceCode/2023/Sep2023/Basics/Sandhya/Task19/Task19/project.json

File: Main.xaml

Issue: Could not load file C:\VSTS_BA1\_work\1\s\SourceCode\2023\Sep2023\Basics\Sandhya\Task19\Task19\Main.xaml. Reason: Cannot create unknown type {http://schemas.uipath.com/workflow/activities}ReadTextFile.

Fix: Looks like there's an issue with the 'ReadTextFile' activity. Check if it exists in your UiPath Studio and if you've imported the necessary package for it. If it's a custom activity, ensure you've added it correctly.

2. Project Analysis:

Issue: Cannot perform project analysis because some workflows have errors.
Fix: The error in your Main.xaml file prevents the project from analyzing properly. Rectify the error in the Main.xaml file, and then try to perform the project analysis.

SourceCode/2023/Sep2023/Basics/Sandhya/Task26/Task26/project.json
The issue appears to be in your Main.xaml file within the Task26 directory. The error message indicates that there is an unknown type '{http://schemas.uipath.com/workflow/activities}MessageBox'.
This usually suggests that there may be a missing or incorrect namespace reference in your XAML file. One easy fix would be to go through your XAML file and ensure that all activity namespaces are correctly included.
In simpler terms, imagine your code as a book. The error is like a word that the book doesn't recognize. You have to make sure that the book has a reference (like a dictionary) to understand what the word (in this case, 'MessageBox') means.
Secondly, the project analysis cannot be performed due to the errors in your workflows. Fixing the first issue may also solve this one.
Please fix this issue and make a new commit. We got this!

SourceCode/2023/Sep2023/Basics/Sandhya/Task27/Testing1/project.json

Issue: "An exception was thrown while activating UiPath.Studio.Platform.Contracts.IPlatformWrapper."
Solution: Looks like there's an issue initializing the IPlatformWrapper. Update your UiPath Studio, or reinstall if the issue persists.

Issue: "Could not load file C:\VSTS_BA1_work\1\s\SourceCode\2023...unknown type '{http://schemas.uipath.com/workflow/activities}ForEachRow'"
Solution: There seems to be a problem loading Main.xaml. The error points to an unknown type 'ForEachRow'. Check that you've correctly set up 'ForEachRow' activity in UiPath. Reinstall necessary dependencies if required.

Issue: "An exception was thrown while activating UiPath.Studio.Platform.Contracts.IPlatformWrapper."
Solution: Similar to the first one, there's an issue initializing the IPlatformWrapper. Try checking your UiPath Studio version and make updates or reinstall the software, if necessary.

Issue: "Cannot perform project analysis because some workflows have errors."
Solution: A bug in one or more of your workflows is preventing project analysis. Review each workflow for errors, and fix these to make the project work. Be surgical, kill those bugs.

SourceCode/2023/Sep2023/Basics/Sandhya/Task28/Task28/project.json
To the developer,
Whilst checking through the Main.xaml in your Task28 directory, I've hit a roadblock. Looks like your code is calling a type {http://schemas.uipath.com/workflow/activities}CommentOut which the system can't quite decipher. Might be worth revisiting and confirming this {http://schemas.uipath.com/workflow/activities}CommentOut type to ensure it's correctly defined and used.
Additionally, there seems to be a problem with the project analysis because some of the workflows contain errors.  Your task now is to debug your workflows, sort out these errors. Resolving these glitches should make the project analysis smooth sailing.
Keep improving and remember, every bug is a lesson learned. Keep it up.

@Sandhyathota1
Task-23
Code verified.
Task-26
Code verified. Default activity names

Task-27
Code verified. Default activity names

Task-28
Code verified. Default activity names


Missing focus indicators

Describe the bug
When navigating the sandbox or demo site by keyboard-only, two instances are showing a missing focus indicator:

The search icon in the utility navigation:

The hierarchical tree view:

To Reproduce
Steps to reproduce the behavior:

Navigate the demo or sandbox site by keyboard only.

Expected behavior
According to SC 2.4.7 Focus Visible (Level AA) (https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html), a vertical bar should be displayed in the field, indicating that the user can insert text. This happens, when the user clicks (or hits enter) on the search icon, but not before
In the hierarchical tree view, there is are no focus elements around the subject categories when navigating with keyboard only.

@hostle83: I was able to reproduce the error in the search facets, currently there is a deadlock preventing to access that link so I added that fix to this PR. For the first issue I can see a focus indicator on the latest version of DSpace, so could you perhaps check if this still happens for you?


Vim mode in web - not able to change language in insert mode

Found out that in web version, when changing language in vim insert mode, it changes to normal. Not able to use russian language in insert mode because of it. I would lable this new issue as low-level importance as anybody that is using vim, most probably will use just plugin to native app.
https://github.com/user-attachments/assets/678b6e0a-3090-4733-a965-35d2fcbd9525

What keybinding are you using to switch/toggle layouts? I use Alt-Shift which seems to work.
$ setxkbmap -query
rules:      evdev
model:      pc105
layout:     us,ru
options:    ctrl:nocaps,grp:alt_shift_toggle

kb-layout-switch.webm


Replace deprecated oauth2.NoContext by allowed one.

oauth2.NoContext is deprecated. context.Backgound() should be used
instead.

This change is

/lgtm
/approve

/approve no-issue


VhostUser:report() error when not connected

The VhostUser app causes an error when its report() method is called before the socket has connected. This should not trigger an error.
See backtrace in this blog entry by @mwiget.

Fixed by #539.


Feature✨ : Adding a Scroll to the top button

A Scroll to the top button offers several benefits:
Improved User Experience: Allows users to quickly return to the top of the page, especially on long pages.
Enhanced Navigation: Makes navigating through extensive content more efficient and less frustrating.
Increased Engagement: Keeps users on your site longer by making it easier to explore more content.
Professional Appearance: Adds a polished, user-friendly feature that can enhance the overall look and feel of your website.

Hey @codervivek5!
I am a contributor selected for GirlScript Summer of Code and I would like to work on this issue in your repository. Could you please assign it to me?
Thank you!

some one is working in it


Add API-Doc to https://doclets.io

Adds documentation to doclets.io service. Future tags and master branch will be published automatically.
Preview generated with my account
@TooTallNate  If you like this, you are very welcomed to login to https://doclets.io with GitHub OAuth. If you don't like it, I'd be happy to hear what you don't like about it :)
Steps required (3min):

nate logs in to doclets.io
nate adds node-spotify-web
someone merges this PR

@TooTallNate What do you think?

:+1: looks awesome!

@TooTallNate ping :)

@TooTallNate @adammw pinging :)


Refuses to work.

Hi there,
This extension has been very helpful while I was writing a docusaurus-based software documentation site.  However, it recently stopped working and I'm struggling to understand why.
I'm using the latest VS Code (v1.83.1).
I've tried:

Disabling/Enabling extensions,
ReInstalling VS Code,
ReInstalling Extensions,
Installing Old Version of VS Code
Adding the documentation folder to trusted locations in VS Code
Deleting "extensions" folder for VS Code.
Installing only Markdown Image extension.

Tried launching Developer Tools and looking in there:

Extensions Output log shows this message when I try and Paste Image:
2023-10-23 14:24:50.562 [info] ExtensionService#_doActivateExtension hancel.markdown-image, startup: false, activationEvent: 'onCommand:markdown-image.paste'
I would greatly appreciate if you can advise me on what could go wrong on my side.
It used to work just fine, but just stopped working recently.

What‘s your OS?

Oh~I see. Can you copy a image, and then execute this script ? https://github.com/imlinhanchao/vsc-markdown-image/blob/master/asserts/pc.ps1

What‘s your OS?

Windows 10

Oh~I see. Can you copy a image, and then execute this script ? https://github.com/imlinhanchao/vsc-markdown-image/blob/master/asserts/pc.ps1

This is what it returns:

Active code page: 65001
Add-Type : Cannot add type. Definition of new types is not supported in this language mode.
At C:\Users\Valentin.Belets\Documents\ps1.ps1:6 char:1
+ Add-Type -Assembly PresentationCore
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : PermissionDenied: (:) [Add-Type], PSNotSupportedException
    + FullyQualifiedErrorId : CannotDefineNewType,Microsoft.PowerShell.Commands.AddTypeCommand

Unable to find type [Windows.Clipboard].
At C:\Users\Valentin.Belets\Documents\ps1.ps1:7 char:8
+ $img = [Windows.Clipboard]::GetImage()
+        ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Windows.Clipboard:TypeName) [], RuntimeException
    + FullyQualifiedErrorId : TypeNotFound

Unable to find type [Windows.Clipboard].
At C:\Users\Valentin.Belets\Documents\ps1.ps1:10 char:12
+     $img = [Windows.Clipboard]::GetFileDropList()
+            ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Windows.Clipboard:TypeName) [], RuntimeException
    + FullyQualifiedErrorId : TypeNotFound

no image

Although image was clearly in my clipboard:

You should execute the script in PowerShell

You should execute the script in PowerShell

PS C:\Users\Valentin.Belets\Documents> .\ps1.ps1
Active code page: 65001

execute like this  .\ps1.ps1 image.png

PS C:\Users\Valentin.Belets\Documents> .\ps1.ps1 image.png
Active code page: 65001
image.png

Is the file image.png you copy picture? It look like work.


Firefox is not added to environment path

For example after trying to start Firefox Profile manager to restore a profile

C:\Windows\system32>firefox -P
'firefox' is not recognized as an internal or external command,
operable program or batch file.

FF version is 70.0b7

If you installed firefox-beta, please use firefox-beta -P instead of firefox -P

Current executable filename is

D:\scoop\apps\firefox-developer\current\firefox.exe

Anyway there's a nasty UX problem when people backup and uninstall firefox and jump on the scoop variant - the backup is not detected properly even when redacted profiles.ini and during -P time you must create a FRESH one profile then pasting backup content in it. Ok, this seems fine at first but if the user picks again the wrong one or deletes it in this profile manager while already deleted the backup it's possible to reach 1 meter before the finish line without wheels (data) :}

https://github.com/lukesampson/scoop/issues/3649#issuecomment-533232293 is informative.

Why do you link to a comment in this issue?

please see https://github.com/lukesampson/scoop/issues/3657#issuecomment-534435083
Click text below to expand!

 moreover...
people attribute incorrect meanings to ambiguous emojis, creating miscommunication and other issues, for a over-simplified example- Attitude polarization due to confirmation bias; which can then lead to living in multiple delusions.

Hi@quantuumsnot
There may be an issue with making Firefox portable. Chrome seems to have a few issues with setting it as a default browser for example.
But is also possible the hardlink  current may be the issue
Could you try changing the path to the actual real folder location and avoid using current?
I have personally had issues setting the path to the java sdk location when I had current hardlink in the path. Instead I used the real path.  It also happens from IDEA for example when is trying to look for an SDK it won't recognize any path with current hardlink in it.

Already stated that I fixed the problem, FF is fully portable for me through scoop, ye the current directory is probably a no-go for most of the apps as persistent user data storage location

also possible the hardlink current may be the issue

is it hardlink or junction? its junction on my machine.

It's a junction:

D:\scoop\apps\firefox-developer>dir
Volume in drive D has no label.
Volume Serial Number is 10A7-C1D1
Directory of D:\scoop\apps\firefox-developer
10/05/2019  03:26 PM    <DIR>          .
10/05/2019  03:26 PM    <DIR>          ..
10/05/2019  02:15 PM    <DIR>          70.0b12
10/05/2019  03:26 PM    <JUNCTION>     current [D:\scoop\apps\firefox-developer
70.0b12]

@quantuumsnot @trip23app I was reading that creating a junction is possible on a networked drive.


FIeld update error - 502 Bad Gateway

field > 06:16:40.881    FIELD        Field update error to field.carriota.com: 502 null                                                                                field > <title>502 Bad Gateway</title>
field >
field >
502 Bad Gateway

field >
nginx
field >
field >

This is due to the load balancer being offline for a short period of time. Nothing to worry about.


Unable to do GIT push

Hi,
I just added cluster to my new computer (Mac).
When I try to do git push it's asking me for GIT username and password.
Username for '###':  Password for '###':  remote: Authentication required fatal: Authentication failed for '###'
I have already done this https://flynn.io/docs/cli#adding-clusters
Typing in flynn cluster shows cluster fine.
Any solution?

What is the output of running this?
GIT_TRACE=1 GIT_CURL_VERBOSE=1 git push flynn master

Hi @titanous
I get this result:
06:57:19.718126 git.c:350               trace: built-in: git 'push' 'flynn' 'master'
06:57:19.746441 run-command.c:336       trace: run_command: 'git-remote-https' 'flynn' 'https://git.XXX.flynnhub.com/XXX.git'
* Couldn't find host git.XXX.flynnhub.com in the .netrc file; using defaults
*   Trying XXX.XXX.118.9...
* Connected to git.XXX.flynnhub.com (XXX.XXX.118.9) port 443 (#0)
* TLS 1.2 connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate: XXX.flynnhub.com
* Server certificate: Flynn Ephemeral CA
> GET /XXX.git/info/refs?service=git-receive-pack HTTP/1.1
Host: git.XXX.flynnhub.com
User-Agent: git/2.9.3 (Apple Git-75)
Accept: */*
Accept-Encoding: gzip
Pragma: no-cache

< HTTP/1.1 401 Unauthorized
< Content-Length: 24
< Content-Type: text/plain; charset=utf-8
< Date: Fri, 02 Dec 2016 06:57:20 GMT
< Www-Authenticate: Basic
< X-Content-Type-Options: nosniff
<
* Connection #0 to host git.XXX.flynnhub.com left intact
06:57:20.286374 run-command.c:336       trace: run_command: 'git credential-osxkeychain get'
06:57:20.290735 run-command.c:195       trace: exec: '/bin/sh' '-c' 'git credential-osxkeychain get' 'git credential-osxkeychain get'
06:57:20.299605 git.c:563               trace: exec: 'git-credential-osxkeychain' 'get'
06:57:20.300346 run-command.c:336       trace: run_command: 'git-credential-osxkeychain' 'get'

Is there any more output? That looks incomplete.

I got a similar output. The output is complete.

flynn info shows
Web URL
but there is no Git URL

I can run git push flynn master on the flynn host.
But I cannot push from a remote host.

I am facing a similar problem as the 2 posters above.
I initially first faced an issue concerning the SSL-cert, which I addressed by:

Exporting SSL certificate from browser
adding SSL certificate here: /etc/ssl/certs/ca-certificates.crt

I setup my Flynn cluster via the web-interface and it has been successfully created.
Is there a git user and password being stored somewhere that we can use as a stop-gap measure?
Also, please re-open this issue, as 3 different people are experiencing it.

@Kentoseth you are having a different issue, please open a new issue.

getting the same error, any update on this?
GIT_TRACE=1 GIT_CURL_VERBOSE=1 git push flynn master
10:14:11.921286 git.c:344               trace: built-in: git 'push' 'flynn' 'master'
10:14:11.923479 run-command.c:627       trace: run_command: 'git-remote-https' 'flynn' 'https://git.fsp.lunarct.ie/fourstartest.git'
* Couldn't find host git.fsp.lunarct.ie in the .netrc file; using defaults
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to git.fsp.lunarct.ie (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /Users/salvatorevaccarino/.flynn/ca-certs/default.pem
  CApath: none
* error:0407006A:rsa routines:RSA_padding_check_PKCS1_type_1:block type is not 01
* stopped the pause stream!
* Closing connection 0
fatal: unable to access 'https://git.fsp.lunarct.ie/fourstartest.git/': error:0407006A:rsa routines:RSA_padding_check_PKCS1_type_1:block type is not 01
Salvatores-MacBook-Pro:fourstarpizza_web salvatorevaccarino$ GIT_TRACE=1 GIT_CURL_VERBOSE=1 git push flynn master
10:16:00.374931 git.c:344               trace: built-in: git 'push' 'flynn' 'master'
10:16:00.378300 run-command.c:627       trace: run_command: 'git-remote-https' 'flynn' 'https://git.fsp.lunarct.ie/fourstartest.git'
* Couldn't find host git.fsp.lunarct.ie in the .netrc file; using defaults
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to git.fsp.lunarct.ie (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /Users/salvatorevaccarino/.flynn/ca-certs/default.pem
  CApath: none
* error:0407006A:rsa routines:RSA_padding_check_PKCS1_type_1:block type is not 01
* stopped the pause stream!
* Closing connection 0
fatal: unable to access 'https://git.fsp.lunarct.ie/fourstartest.git/': error:0407006A:rsa routines:RSA_padding_check_PKCS1_type_1:block type is not 01

same issue here:
GIT_TRACE=1 GIT_CURL_VERBOSE=1 git push flynn master                   ✘ 1 master
11:38:40.930109 git.c:340               trace: built-in: git 'push' 'flynn' 'master'
11:38:40.934672 run-command.c:626       trace: run_command: 'git-remote-https' 'flynn' 'https://git.demo.localflynn.com/example.git'
* Couldn't find host git.demo.localflynn.com in the .netrc file; using defaults
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* SOCKS5 communication to git.demo.localflynn.com:443
* SOCKS5 connect to IPv4 <IP_ADDRESS> (locally resolved)
* SOCKS5 request granted.
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 1086 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /Users/leo/.flynn/ca-certs/demo-virtualbox.pem
  CApath: none
* LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to git.demo.localflynn.com:443
* stopped the pause stream!
* Closing connection 0
fatal: unable to access 'https://git.demo.localflynn.com/example.git/': LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to git.demo.localflynn.com:443

Vagrant 2.1.1
macOS 10.13.2
curl 7.54.0 (x86_64-apple-darwin17.0) libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz HTTP2 UnixSockets HTTPS-proxy


Restore Portability in Master

Recently, the project was coupled to the union/blast build system. This was done to improve development lockstep with other projects that develop simultaneously with allegro_flare (and because this particular repo is not experiencing a lot of traffic/usage during that time).
To make allegro_flare more approachable and easier to use, the build coupling should be removed and an alternative build system should be introduced that allows this project to float independent of the other projects.
cc @aviallon because of your advocacy for CMake.
Related issue: https://github.com/allegroflare/allegro_flare/issues/174

I'm closing this for being stale. For the most part, allegro_flare development is coupled with the blast build system (union has been removed and is now integrated in blast).
The blast build system has been aligned and is now used internally across all projects. It's wonderful to use, and there currently isn't a plan to change that.
It's unclear what benefit would be made by switching from make to CMake.

@MarkOates if you want to test other build systems, another good candidate is meson.
It looks good enough that some big projects are switching to it.


adding tests and fix for throwing an exception when nested model not defined

Might be useful to throw an exception to developer when the field.nested class does not exist.

Good idea. Merging :)


Web: glitch when using native fullscreen and vscode fullscreen

Steps to Reproduce:

latest selfhost build
open in chrome (macOS)
go into native fullscreen (via window buttons)
leave native fullscreen
go into vscode fullscreen

=> 🐛 there is a grey bar below the editor

I cannot reproduce this anymore.


add KosyAbone

Fixes Issue
Changes proposed

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Hello, please revert the package-lock.json file, if you need any help feel free to ping us.
__   Summary: 🛠 This code needs a fix

I have reverted the package-lock.json file. Kindly review.

Hello, please revert the package-lock.json file, if you need any help feel free to ping us.
__

Hey! Kosy there are still modifications in the package-lock.json, can you please revert it?
Feel free to reach us out, for help__
  Summary: :hammer_and_wrench: This code needs a fix

If you check the diff you can see that it’s just the versions that are out of sync with each other. If you can update so that the versions match then this should be good to merge

If you check the diff you can see that it’s just the versions that are out of sync with each other. If you can update so that the versions match then this should be good to merge

Thank you Emma. I'll try and figure it out and fix.

I believe it's all good now. Kindly review and merge. Thank you.

Thank you so much everyone for helping me out. I look forward to more contributions.

I still cant see my profile show up on the live site http://linkfree.eddiehub.org/. Why could that be, please?

@KosyAbone it’s because the site doesn’t redeploy automatically when a profile gets added.

@KosyAbone it’s because the site doesn’t redeploy automatically when a profile gets added.

Oh I see. Thank you Emma😊


Make viz.plot_alignment() continue on topological defects; make coreg display a suitable head surface even if it has topological defects

I wanted to run viz.plot_alignment() and it crashed with an exception because there were a few topological defects (as is often the case with our data).
So now, I'm passing on_defects='warn' to the read_bem_surfaces() call inside plot_alignment().
At first I made this parameter user-configurable, but then I thought, plot_alignment() is used when the user wants to see the data they have, so I felt it's not only okay, but expected to always pass on_defects='warn'.
Not sure how to test this, though – maybe it's okay as-is? I can confirm that this works for me.

I encountered a similar problem with the coreg UI, only that it wouldn't crash when the exception was raised, but the displayed head surface would be unusable for a proper coregistration. I'm addressing this in 43cd114


DBZ-1201 Always store SET commands

https://issues.jboss.org/browse/DBZ-1201

Applied, thx,@jpechane!


Updated Python 3 version check to use sys.version_info

The string sys.version should not be used for version checks as there are no guarantees regarding its contents. Instead sys.version_info should be used.

Thank you!


JOSS publication

Submit CATS to the Journal of Open Source Software

Brief update on this - I now have a very rough first draft (on google docs). I'll ask @sadielbartholomew and/or @Llannelongue to take a look before I migrate it to the repository (and to markdown) in a couple of weeks. In drafting, I've found a couple of issues / potential things we could improve. I'll open new issues for these. Oh, and we should also check the JOSS requirement checklist for anything else we need to do to the codebase.


Accept function arguments?

I realize that this would be a deviation from the standard, but any interest in accepting arguments to be passed to the callback? For example...
queueMicrotask(myFunction, something) // Calls myFunction(something) as a microtask
This functionality is available with setTimeout/setImmediate  and can help make code more readable.
I'm happy to submit a PR, just let me know.

Hey, thanks for the suggestion! The goal of this package is to match the standard so I don't want to add non-standard additions like this.


Allow swipe to close the sidebar after search is cancelled

Summary
When filtering the sidebar is cancelled the flag to allow the sidebar to be closed by a swipe was not included in the cancel handler.
Ticket Link
https://mattermost.atlassian.net/browse/MM-27527

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/9445
https://circleci.com/gh/mattermost/mattermost-mobile/9444

Artifact links:
https://9445-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://9444-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa


Added section dedicated to upgrade

See #134

Hey @adriens,
I went ahead and simplified this language a bit in e515d4f01a5868a7e1889e477ba06c68907c8911. Merged! :star2:

Yeah, that's cool ! Thanks. I'm using your tool as often as i can... maybe should you create a section dedicated to examples where people could thank you for the tool and show what they did with it ;-p


php82Extensions.soap: fix tests

Description of changes
Closes #339074
cc @Brawl345
Builds for me on Darwin again (Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020 arm64 arm Darwin).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Works for me too with this PR, thanks!

@Ma27 Can you please take care of the backport and ping me in?

Sure.

@drupol just noticed, 24.05 has doCheck = false;, so we're good there. Personally, I don't think it's worth the effort to backport all relevant commits (excluding the libxml parts that are probably not relevant). wdyt?

if you're asking me, I would backport it to facilitate potential future backports. It doesn't cost anything to do it so...


doesn't run on windows?

Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"freebsd,darwin,linux","arch":"any"} (current: {"os":"win32","arch":"x64"})

it won't download and install this plug-in, is homekit on windows not supported?

@morningla I just released v2.0.0, which no longer uses the dependency that was failing on windows.  Are you still interested in trying it?  If so, let me know how it works for you.

I would like to try it.  Currently I am using IFTTT with my blinds.
Can I download directly from homebridge add-ons?
Thank you.
From: Dusty @.>
Sent: August 7, 2021 5:03 PM
To: @.>
Cc: @.>; @.>
Subject: Re: [yungsters/homebridge-mylink] doesn't run on windows? (#13)
@morninglahttps://github.com/morningla I just released v2.0.0, which no longer uses the dependency that was failing on windows. Are you still interested in trying it? If so, let me know how it works for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/yungsters/homebridge-mylink/issues/13#issuecomment-894716159, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APQUPQCSG4QAQ5QGHXYVWN3T3W3S5ANCNFSM4M5BG4MA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.


Node projects that require node-gyp fail to build without custom nixpacks config

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Node projects that require node-gyp fail because python and build-essential are missing.
To reproduce

Clone https://github.com/ModupeD/Gatsby-site (this app is a new gatsby app created with gatsby new)
Delete nixpacks.toml
nixpacks build . --install-cmd 'npm install' --build-cmd 'gastby build' --start-cmd 'echo 0'

Expected behavior
App builds successfully
Environment
nixpacks 1.6.0
Workaround
add nixpacks.toml
[phases.setup]
nixPkgs = ['...','python311']
aptPkgs = ['build-essential']

Issue
I am attempting to deploy a Next.js application using coolify. My project utilizes node-gyp for building certain packages. Despite trying your suggested workaround, it was unsuccessful. I have included a screenshot for reference.

@flybayer can you help me with this

To solve this, create nixpacks.toml in your repo:
providers = ["node", "python"]

@pranavp10 not sure if you ever solved the issue, it has been one and half months but...
So, today I stumbled on the same issue when trying to deploy a bun application in coolify through nixpacks. After some trial and error ended up with that working with the following settings:

Creating nixpacks.toml and adding providers = ["...", "python"] to install python, which is necessary to node-gyp
Adding node-gyp as a dependency with bun install node-gyp

For anyone that ends up here with the same issue, try the steps above.

bun install node-gyp

Thanks this work
my config
[phases.setup]
nixPkgs = ['...','python312']
aptPkgs = ['build-essential','libudev-dev']
providers = ["node", "python"]


Add SessionPoolOptions.setFailIfPoolExhausted in SpannerAccessor

Configures SpannerAccessor to set the setFailIfPoolExhausted SessionPoolOption which ensures that the Spanner client throws an error if the session pool is exhausted.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Can you explain why you believe this is necessary to add?
The default session pool options in Java are:

MinSessions =100
MaxSessions = 400
WriteSessionsFraction = 0.2

These will apply to each worker indivudually.
@olavloite for comment.

This is my primary motivation -
https://github.com/googleapis/java-spanner/blob/main/session-and-channel-pool-configuration.md#automatically-clean-inactive-transactions
Currently, there is no way to set setWarnAndCloseIfInactiveTransactions(). SpannerAccessor is used in Dataflow templates like DatastreamToSpanner, which customers use as a black box, therefore, having this enabled by default makes sense.

In theory there should never be an inactive transaction left open by SpannerIO.
If there is, then it is a bug in SpannerIO.
Writes use blind writes by calling DatabaseClient.writeAtLeastOnce, which internally uses the single_use_transaction feature of the Commit API so that a transaction is automatically started and closed by the Spanner server.
Reads use a single read transaction, which is shared across all workers. By their nature these are long-running transactions.
SpannerIO is intended to isolate users from needing to worry about transactions, and to just pass their data in and let the connecter deal with it.
If you are experiencing issues with session pool exhaustion, and believe that there may be a bug, then please raise an issue.

Bump! @nielm @olavloite

Result of out-of-band discussion between @manitgupta  and @olavloite  - Change the PR such that SpannerAccessor always sets
SessionPoolOptions.setFailIfPoolExhausted()

to avoid expanding the SpannerIO public API surface while also catching potential session leak bugs.

LGTM
Precommit fails for unrelated reason in
org.apache.beam.sdk.io.gcp.spanner.changestreams.it.SpannerChangeStreamOrderedWithinKeyIT > restOrderedWithinKey

reverted in #32694


Restarted Wallaroo server doesn't restart to INIT PHASE III

Is this a bug, feature request, or feedback?
Bug
What is the current behavior?
Several senders send some data to a 2-worker Wallaroo cluster, then worker2 is killed and restarted.  The restarting worker2 advances only to INIT PHASE II and stalls before reaching III.
What is the expected behavior?
The Wallaroo cluster would resume processing data after the worker2 worker finishes rejoining the cluster.
NOTE that I've seen 100% failure (out of 6 runs) on the bad commit (see below) and 100% success (out of 20 runs) on the commit immediately prior to the gensource branch merge today.
What OS and version of Wallaroo are you using? If you have a stacktrace and/or steps to reproduce the issue, that also helps a lot.
Commit https://github.com/slfritchie/wallaroo/commit/d9bea736e822714313bdfb7bad0d93778b26f797 which is based on master's commit https://github.com/slfritchie/wallaroo/commit/7db49c22b116e33cf7a10fad3815b3cb34ff5ffe.  Testing on Ubuntu Xenial 64-bit, using the sequence of commands:
cd demos/resilience-demo
sh ./10-setup-slf-repo.r=on.sh
./VERIFY.2worker.simple-restart.sh

Script output:
To stop everything, run: env WALLAROO_BIN=./testing/correctness/apps/multi_partition_detector/multi_partition_detector ./99-stop-everything.sh
Stopping all Wallaroo procs on <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>
Start DOS server
Start MUI
Start receiver via external var
Start initializer
Start worker2
Check Wallaroo worker on <IP_ADDRESS>: ..|~~ INIT PHASE III: Application is ready to work! ~~|
Check Wallaroo worker on <IP_ADDRESS>: .|~~ INIT PHASE III: Application is ready to work! ~~|
Start sender via external var
Start sender via external var
Start sender via external var
Start sender via external var
Start sender via external var
Start sender via external var
Sleep 4 before restarting worker2
Kill worker2
Restart worker2 on server 2 with same TCP ports
'/tmp/run-dir/multi_partition_detector2.out' -> '/tmp/run-dir/OLD/multi_partition_detector2.out'
Use DOS server but skip starting it
Check Wallaroo worker on <IP_ADDRESS>: .|~~ INIT PHASE III: Application is ready to work! ~~|
Check Wallaroo worker on <IP_ADDRESS>: ..............................TIMEOUT

Full server logs are available at http://sendence-dev.s3.amazonaws.com/wallaroo/outstanding-problems/T100.a.tgz

I compiled with PONYCFLAGS='--verbose=1 -d -D checkpoint_trace' and put the failing logs into http://sendence-dev.s3.amazonaws.com/wallaroo/outstanding-problems/T100.b.tgz

Working backward from the head of the gensource branch, I discovered this:
# Source branch name to test with
REPO_BRANCH=gensource~1 ## ./VERIFY.2worker.simple-restart.sh FAILS worker restart
REPO_BRANCH=gensource~2 ## ./VERIFY.2worker.simple-restart.sh FAILS worker restart
REPO_BRANCH=gensource~3 ## ./VERIFY.2worker.simple-restart.sh COMPILE ERROR
REPO_BRANCH=gensource~4 ## ./VERIFY.2worker.simple-restart.sh FAILS worker restart
REPO_BRANCH=gensource~5 ## ./VERIFY.2worker.simple-restart.sh WORKS!

... where gensource~5 is: HEAD is now at b90da64... Use internal source for crash-recovery tests

Oops, my repo's view of gensource was isn't the same as John's.  He created a branch called gensource-clone so we could look at the same thing.  I've tested three commits, mentioned below by symbolic name and commit number.

REPO_BRANCH=gensource-clone~3 ## commit a94d5dc, FAILS bug #2507

While testing #2535, I didn't reproduce this bug once.  Closing.


Add crumbl plugin

Simple port of https://github.com/rob-3/crumblbot/

Could we use buttons for pagination rather than posting all cookies at once?

There's only every 4-5 cookies, so I feel like pagination just needlessly slows things down. Are you worried it is too much embed spam?

I just think it's cleaner. I really like lions crumbl plugin

Hmm ok well I could manually build the pagination but it would be nice to have a helper for pagination where you just pass in the array of embeds and it sets up the buttons and editing for you.

I just think it's cleaner. I really like lions crumbl plugin

I agree, especially on mobile, sometimes 4-5 embeds can take up the entire chat view. Also buttons makes pagination more user friendly IMO.


docs: re-word onboarding link to have fewer words

Right now, the link to schedule an onboarding session with us contains alot of words (e.g. Schedule a personalized on-boarding session with us.).
This PR reduces those words to simply "Schedule a live session with us" to make it easier to read and more compelling to engage with.
Changelog picked up from commits here:
docs: re-word onboarding link to have fewer words

Closing this in favor of #157


cloudflareR2bindings: Fixed getItemRaw()

TLDR: Files saved to Cloudflare R2 were not returned correctly by .getItemRaw(), this PR fixes that.

I tried to save files into Cloudflare R2 from a Cloudflare worker by a binding. Saving was no problem by use of .setItemRaw(), the file was added correctly to R2. But getting the item I had weird results:

.getItem() returns a string, e.g. when the file was a pdf, the response was the markup of the pdf as a string. (btw this is because it is calling .text(), not sure if this is usefull at all)
.getItemRaw() returns an empty object

I checked the docs and they do it like this:
export default defineEventHandler(async (event) => {
    const object = await globalThis.__env__.BINDING.get('key')`
    return object.data;
});

In this example above, object is of type R2ObjectBody, reference is here
In the current implementation object.arrayBuffer() is returned instead of .body. I am not exactly sure why the author chose to do that, because:

It doesnt work (i tried to return image and pdf)
I would expect a "raw" function not to call a function that obviously does transformations

Therefor I changed getItemRaw() to return .body which now returns files correctly.

I have pushed some better tests (#518) to validate getItemRaw behavior against actual platform behavior, and it works as expected.
It is strange that you are getting an empty object. How do you test it? console.log might be misleading (please consider always sharing a reproduction this way we can help faster and better 🙏🏼)
raw methods return a raw buffer (ie: resolve value) and .body is a stream which is why.
We could return a Uint8Array to be more consistent with other drivers but it will be a behavior change.
From this point:

As an enhancement, we could support .getItemRaw(key, { type: 'stream' }} if you like to have stream type like this PR changes
As a (possible) fix, we need a minimal reproduction that shows currently there is a bug. Addtional tests work as expected so it might not be a bug.

~> To allow specify raw type: https://github.com/unjs/unstorage/pull/519

What did you test exactly that arrayBuffer was correct? Did you upload a file to R2 using setItem?
I saved an uploaded file like this, and I only tested deployed to Cloudflare worker.
Upload file:
export default defineEventHandler(async (event) => {
  const files = await readMultipartFormData(event);

  await useStorage('files').setItemRaw('some-key', files[0].data);

  return 'ok';
});

Get file:

getItem() returns the text of a pdf

export default defineEventHandler(async (event) => {
  return useStorage('files').getItem('some-key');
});

Response:
�PNG

���
IHDR�����*����W���biTXtXML:com.adobe.xmp�����
<?xpacket begin="" id="W5M0MpCehiHzreSzNTczkc9d"?>
<x:xmpmeta xmlns:x="adobe:ns:meta/" x:xmptk="XMP Core 6.0.0">

getItemRaw() returns an empty object:

export default defineEventHandler(async (event) => {
  return useStorage('files').getItemRaw('some-key');
});

Response:
{}

Btw. on localhost using memory driver this works with both: getItem() and getItemRaw().

Tests: https://github.com/unjs/unstorage/blob/main/test/drivers/cloudflare-r2-binding.test.ts
getItemRaw('some-key') returns an ArrayBuffer and I guess h3 does not support it as direct response (it handles Buffer and Buffer-like like Uinit8Array) you might want to do something like:
const val = await useStorage('files').getItemRaw('some-key')
return new Uint8Array(val)

(another option is return new Response(val))
Regardless there is no issue with unstorage driver itself and next release allows you to specify what raw type you want.

Opened here: https://github.com/unjs/h3/issues/931


Signed and unsigned values not matching in switch()

Repro is with Zed commit bcb1697. This issue was found while helping a community user craft conditional logic for a Zed shaper script.
Start with this CSV data:
$ cat data.csv
event_id
3
4

When read in, these values are treated as floats, as indicated by the . in the values in the ZSON output.
$ zq -version
Version: v0.29.0-512-gbcb16977

$ zq -z -i csv data.csv | tee float-data.zson
{event_id:3.}
{event_id:4.}

The user's first problem was that these values didn't match in their switch() statement.
$ cat switch.zed
switch event_id (
  3 => put note := "I saw a three";
  4 => put note := "I saw a four";
)

$ zq -I switch.zed float-data.zson
[no output]

I wasn't sure if that was supposed to work since I know float/integer equality is not a given in some languages. I thought some casting during preprocessing would do the trick as a workaround, but that didn't work either.
$ zq -z -i csv 'put event_id:=uint64(event_id)' data.csv | tee uint64-data.zson
{event_id:3(uint64)}
{event_id:4(uint64)}

$ zq -I switch.zed uint64-data.zson
[no output]

It's only when I casted to a signed int that it started working.
$ zq -z -i csv 'put event_id:=int64(event_id)' data.csv | tee int64-data.zson
{event_id:3}
{event_id:4}

$ zq -I switch.zed int64-data.zson
{event_id:4,note:"I saw a four"}
{event_id:3,note:"I saw a three"}

In conclusion, I'm almost certain the failed quality test between signed/unsigned is a bug. I'm less sure of the float one.

I happened to revisit this one in an issue scrub and have confirmed that it's still with us as of Zed commit f967c99. Here's an update of the repro to be aligned with current switch syntax.
$ cat switch.zed
switch event_id (
  case 3 => put note := "I saw a three"
  case 4 => put note := "I saw a four"
)


What makes the JetBrains plugin so large?

Validations

[ ] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem

Solution
Not an issue per se. Would've started a discussion if GitHub Discussions were enabled for the repo.

Hey @dandv , good question. The extension comes bundled with a few binaries which are what causes the bloat. Here's the main culprits:
156M    continue-binary ## This is the `core` folder written in node, compiled into a binary to share across IDEs
 68M    index.node ## LanceDB
2.1M    build ## build/Release/node_sqlite3.node


Minor casing typo in code sample

Under the section titled "Backup Reliable Services", there exists a code sample where the first line contains:
new BackupDescription(backupOption.Incremental
The B of "backupOption" should be capitalized as in BackupOption as it's an enum provided by Service Fabric.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2afe5075-3fb3-d79f-98b6-9fdcc634da7a
Version Independent ID: 45ac5f69-1db0-5b37-852b-8351bf40accc
Content: Service Fabric Backup and Restore - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-reliable-services-backup-restore.md
Service: service-fabric
GitHub Login: @mcoskun
Microsoft Alias: mcoskun

@WhitWaldo Thanks for pointing this out. I have raised a PR for fixing this and changes will go live soon.


Time Display on TimetableGrid is Off by One Hour

Idea Description
The time displayed on the TimetableGrid is one hour behind the actual scheduled time.

For now, we released a hotfix veresion that we remove the time as 1.6.1.

Reference images and links

🙋

Thank you for your help! Assigned!

There may be a problem in calculating the values below.
https://github.com/DroidKaigi/conference-app-2023/blob/e52ff00429ff30d1b58433f74b20cef83763e7c7/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/section/TimetableGrid.kt#L360

It's possible that dayStart always needs to be set to 10:00(JST).

It seems to be correct, so I'll try implementing it.

Thanks


Add problem 1365 solution and examples

Features

Added problem_1365 module.

Added fn solve() function.
Added examples as test cases. e.g.) fn example_1()

Screenshots

close #19

@harry-cluml
현재 코드는 너무 긴 것 같습니다.  iter, map, filter 로 간략하게 구현하는게 좋아보입니다.


[docs request] Indicate which scopes are required for a Personal Access Token

The docs mention Pre-requisite: Create a ${HOME}/.pr-train file with a single line which is your GH access token (you can create one here).
It would be great to specify which scopes are required. :)
You can see the list of scopes at: https://github.com/settings/tokens/new
Thanks!

Ah, great suggestion, thanks! Do you think you could open a PR? :-P

Ah yep, can do, I'll have a look at which scopes you're using... 😬

I think we need Full control of private repositories (because GH still doesn't have read-only / create-pr only scopes).


[FreeBSD] Simplify page

Currently, there is two types of cycles on the FreeBSD page :  stable and releng cycles.
releng are just point releases so it should be handled like, for instance, Debian point releases: using the latest / latestReleaseDate fields. This way :

it reduces a lot the number of cycles,
it makes automation possible (using https://distrowatch.com/table.php?distribution=freebsd).

We could collapse the older branches into a single row (4-11), while keeping separate rows for 12.x, and 13.x point releases.
stable/x is treated like a proper release branch by freebsd, since it has advisories issued against it (unlike say debian rolling, which would equate with freebsd main). So I still think we'll need stable/12, and stable/13 rows, since your installation could be directly using it.
Read through https://www.freebsd.org/where/ again, which mentions

Pre-RELEASE versions of FreeBSD, not intended for use in production environments:

CURRENT – the main branch, the core of development
STABLE – branched from CURRENT, long-term preparations for release engineering
release engineering – ALPHA, BETA, release candidates (RC) – branched from STABLE.

So you could install STABLE, it is not recommended in production use, so we could probably skip it from the table. Don't think we can still use automation for point releases, since multiple point releases are supported at the same time.
Will file a PR once this is merged


Simplify application

In response to user feedback, simplified the code for this room so that it uses a library to handle the room registration and extracted the configuration to it's own class. Also added support for running locally in docker.

This change is

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


CHAOS-5676 Add content

Prominence of two types of onboarding
Definition for the onboarding types

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://665dcc9f8484c06fe5e452df--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://665dccf5979a3ed168b1f28a--harness-developer.netlify.app


Fix HighCharts resize bug for zero case

We're revising the design for the profile page entirely anyway, so this bug is a wontfix.


On-click menus from systray icons appear under windows rather than on top

What I mean by that is that when clicking on a systray icon, for example nm-applet, the context menu appears under the windows rather than over them, as I was expecting. I think this can be done by setting the layer for these menus as the overlay layer, but I don't know how to do that, or if it's even possible.
Edit: This only happens on Hyprland. On other compositors, such as River, The Systray dropdown menu still shows up weirdly, but this time it has black lines separating sections of the popup window, and shows up in the correct layer.

I found a fix! I set the "layer": "top", // Waybar at top layer config option and that worked! Closing as completed.


Extending properties with $ref

Considering the following schema
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "title": "Schema",
  "type": "object",
  "definitions": {
    "ref": {
      "type": "integer"
    }
  },
  "properties": {
      "prop": {
          "$ref": "#/definitions/ref",
          "minimum": 10
      },
      "propWithAllOf": {
          "allOf": [{
            "$ref": "#/definitions/ref",
          }, {
            "minimum": 10
          }]
      }
  }
}

I currently get the following results when validating against a range of input objects

Input Object
Valid

{ "prop": 10 }
true

{ "prop": 1 }
false

{ "propWithAllOf": 10 }
true

{ "propWithAllOf": 1 }
false

According to the JSON spec

Any members other than "$ref" in a JSON Reference object SHALL be ignored.

Does that mean the second result should be true? Thanks!

You are right.
Ajv doesn't comply with this provision, it allows extending $refs with additional keywords.
I was going to address it in the next major version change.
I was also considering adding the option in the current version that would allow to choose between:

failing schema compilation (I think it should be the default to be honest)
ignoring extra keywords (as per spec, should log warning)
using extra keywords (current behaviour).

In this case the 1st or 2nd option could become the default in the next version.

@epoberezkin can you expand on what we need to change here? I'm getting this warning now and it pointed me here but I'm not quite sure what the implications are.
I'm currently using $ref to reference a definition which is a oneOf a number of schemas with custom keywords in it - are you saying this will not be possible in the upcoming release?

Oh. I think this is a false positive for my case, after reading this more closely.  My schema looks like:
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "title": "Schema",
  "type": "object",
  "definitions": {
    "date": {
      "oneOf": [
        { "instanceOf": "Date" },
        { "type": "string", "coerceTo": "Date" },
        { "type": "number", "coerceTo": "Date" }
      ]
    }
  },
  "properties": {
      "prop": { "$ref": "#/definitions/ref" }
  }
}

"coerceTo" and "instanceOf" are custom keywords, but as far as the definition goes there is no other keyword other than $ref in my definition - yet the warning is popping up

Could you please submit a new issue - it may be a bug

ah! apologies after some deep diving I discovered I am indeed auto-generating some schema bits that use a custom keyword with $ref, is that not going to be possible in the next major version?

There will be an option to preserve the current behaviour.
By spec everything but $ref should be ignored, the correct way to extend $ref is to use allOf keyword.

in 4.4.0

You are right.
Ajv doesn't comply with this provision, it allows extending $refs with additional keywords.
I was going to address it in the next major version change.
I was also considering adding the option in the current version that would allow to choose between:

failing schema compilation (I think it should be the default to be honest)
ignoring extra keywords (as per spec, should log warning)
using extra keywords (current behaviour).

In this case the 1st or 2nd option could become the default in the next major version.

Dear @epoberezkin first of all thank you for so nice and powerful project,
we find weird issue wrt extending of $ref (BTW such extending is a great fetaure)
We trying to create some base schema inside definition and also extend this schema by extra fields inside the same definitions, e.g.
 {
    '$schema': 'http://json-schema.org/draft-07/schema',
    '$id': 'http://www.mydomain.com/definitions.json',
    'type': 'object',
    'definitions': {
        "basic-definition": {
         },
        "extended-basic-definition": {
          //reference to the basic, but extra properties are ignored
          "$ref": "http://www.mydomain.com/definitions.json#/definitions/basic-definition"
           "properties": {
               extra properties....
            }
        }
     }
  }

and AJV in this case just ignore extra filed and uses on properties from the basic.
Could we achieve such extending somehow?
If $ref in properties e.g
 {
    '$schema': 'http://json-schema.org/draft-07/schema',
    '$id': 'http://www.mydomain.com/definitions.json',
    'type': 'object',
    'definitions': {
        "basic-definition": {
         },
        "extended-basic-definition": {
           "properties": {
              "my-property": {
                  **//reference to the basic, works great**
                   "$ref": "http://www.mydomain.com/definitions.json#/definitions/basic-definition"
                    "properties": {
                         extra properties....
                     }
               }
            }
        }
     }
}

Thank you in advanced.

Ajv now ignores all siblings to $ref but it can be changed with options. See the docs.

Ajv now ignores all siblings to $ref but it can be changed with options. See the docs.

Thank you for quick response, so TBH quite difficult to find correct option :-), I tried to play with extendRefs: true, inlineRefs: false}
What option do you mean? Maybe it could be a specific option of add/compileSchema methods?
Thank you in advanced.


NRN Admin POC (using @api-platform/admin)

…sh history needs a DOM"

[GitHub Actions]
Deployment SUCCESS
Commit 7dcf89e3b834e7d0be684418aaafa177fdb7fae4 successfully deployed to https://nrn-admin-cbwdbv0pc.now.sh
Deployment aliased as https://nrn-admin-api-platform-admin.now.sh

[GitHub Actions]
E2E tests FAILED
Download artifacts (screenshots + videos) from checks section at the top


Could not load type 'HotChocolate.Utilities.TypeConverterServiceProviderExtensions'

Is there an existing issue for this?

[X] I have searched the existing issues

Product
Hot Chocolate
Describe the bug
Upgraded to 13.2.0 and started recieving the following error when running the snapshot unit test in our project with no other changes.
1. Could not load type 'HotChocolate.Utilities.TypeConverterServiceProviderExtensions' from assembly 'HotChocolate.Types, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'.

  Stack Trace:
     at HotChocolate.Configuration.TypeInitializer.DiscoverTypes()
   at HotChocolate.Configuration.TypeInitializer.Initialize()
   at HotChocolate.SchemaBuilder.Setup.InitializeTypes(SchemaBuilder builder, IDescriptorContext context, IReadOnlyList`1 types)
   at HotChocolate.SchemaBuilder.Setup.Create(SchemaBuilder builder, LazySchema lazySchema, IDescriptorContext context)
   at HotChocolate.SchemaBuilder.Create(IDescriptorContext context)
   at HotChocolate.SchemaBuilder.HotChocolate.ISchemaBuilder.Create(IDescriptorContext context)
   at HotChocolate.Execution.RequestExecutorResolver.CreateSchemaAsync(ConfigurationContext context, RequestExecutorSetup setup, RequestExecutorOptions executorOptions, IServiceProvider schemaServices, TypeModuleChangeMonitor typeModuleChangeMonitor, CancellationToken cancellationToken)
   at HotChocolate.Execution.RequestExecutorResolver.CreateSchemaServicesAsync(ConfigurationContext context, RequestExecutorSetup setup, CancellationToken cancellationToken)
   at HotChocolate.Execution.RequestExecutorResolver.GetRequestExecutorNoLockAsync(String schemaName, CancellationToken cancellationToken)
   at HotChocolate.Execution.RequestExecutorResolver.GetRequestExecutorAsync(String schemaName, CancellationToken cancellationToken)
   at HotChocolate.Execution.RequestExecutorServiceProviderExtensions.BuildSchemaAsync(IRequestExecutorBuilder builder, String schemaName, CancellationToken cancellationToken)
   at Schema_Matches_Snapshot() in

The test:
    public class SchemaTests
    {
        private readonly ITestOutputHelper _outputHelper;

        public SchemaTests(ITestOutputHelper output)
        {
            _outputHelper = output;
        }

        [Fact]
        public async Task Schema_Matches_Snapshot()
        {
            // arrange
            var schema = await new ServiceCollection()
                .AddGraphQLServer()
                .ConfigureHotChocolate() //This is our method that encapsulates all of our HC setup/configuration
                .BuildSchemaAsync();

            try
            {
                // act
                var schemaSdl = schema.ToString();

                // assert
                schemaSdl.MatchSnapshot();
            }
            catch (HotChocolate.SchemaException)
            {
                throw;
            }
        }
    }

ConfigrueHotChocolate method
public static class GraphqlExtensions
{
    internal static class HPHGraphQLExtensions
    {
        public static IRequestExecutorBuilder ConfigureHotChocolate(this IRequestExecutorBuilder b)
        {
            b.RegisterDbContext<CoreDbContext>()
            .AddHttpRequestInterceptor<RequestInterceptor>()
            .AddQueryType<Query>()
            .AddMutationType<Mutation>()
            .AddSubscriptionType<Subscription>()
            .AddGlobalObjectIdentification()
            .AddInMemorySubscriptions()
            .AddFiltering()
            .AddProjections()
            .AddSorting()
            .AddAuthorization()
            .AddType<UploadType>();

            //...
        }
    }
}

### Steps to reproduce

1. Using HC 13.0.5
2. Add the above unit test to a test project
3.  Run the test ensure that it succeeds
4. Upgrade to HC 13.2.0
5. Observe the thrown exception

### Relevant log output

_No response_

### Additional Context?

_No response_

### Version

13.2.0

We have a technical breaking change in the patch. Do you have a package that references a previous HotChocolate version? If so update it to 13.2

@michaelstaib thanks! I bumped all packages to 13.2.1 and it now appears everything is working as expected.


Rename CHIP to Matter for ESP32 doc

Issue Being Resolved
Fix for issue #22771
Change overview
Rename CHIP to Matter for ESP32 doc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I have signed the CLA.


[Examples] Update Google Fonts

[ ] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Google Fonts now recommends forcing https instead of detecting the protocol as shown on their site.
https://www.google.com/fonts#UsePlace:use/Collection:Roboto:400,300,500

@OmgImAlexis That looks good to me 👍 . Could we also update the browserify example for consistency? Thanks

@oliviertassinari force pushed an edited commit with both changes.


Pass mutable slices

The SszEncode::to_ssz helper function would pass a Vec to ssz_write where a mutable slice would be faster, so I fixed that.

looks good to me!


import timesearch_modules error

D:\software\timesearch-master>python timesearch.py get_submissions -r gifs
Traceback (most recent call last):
File "D:\software\timesearch-master\timesearch.py", line 16, in
import timesearch_modules
File "D:\software\timesearch-master\timesearch_modules_init_.py", line 282, in
DOCSTRING = betterhelp.add_previews(DOCSTRING, MODULE_DOCSTRINGS)
AttributeError: module 'voussoirkit.betterhelp' has no attribute 'add_previews'
This is what I get after installing python 3.10 form 3.8 version

Hi, could you do a git pull on the timesearch repository? You could also pip install voussoirkit --upgrade to make sure that is most up to date as well. It looks like your timesearch files are a little older and I have since made changes to the voussoirkit library.
Let me know what happens. Thanks!

After redownloading the files every thing works fine
thanks

Glad to hear it, let me know if anything else comes up.


 It is a dupe of this PR, which we had to revert due to more standalone releases being necessary.
Fixed Issues

https://github.com/Expensify/Expensify/issues/445668
Tests

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Hey @AndrewGable, could you please review. Pullerbear won't work for review assignment 😫
This is the 2nd attempt to stop deploying standalone to prod channels. I am not going to merge this until these force upgrade modal changes pass my testing. But your approval here will save me 1 day as I can hopefully merge tomorrow.

This and delisting the app store pages are the next steps in delisting NewDot standalone app.
We are getting close to the holidays and merging this ensures it'll be included in the first checklist of next week. Giving us the best odds of delisting the app before the end of the year.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


boost scores if query matches item exactly

Scores should be boosted if the query matches the item exactly.
example:
const FuzzySearch = require('./dist/FuzzySearch');

const searcher = new FuzzySearch(
  [{ name: 'r' }, { name: 'rust' }, { name: 'ruby' }, { name: 'prolog' }], ['name'],
  { sort: true } );

console.log(searcher.search('r')); // the first item must be 'r' and the last item must be 'prolog'

@wouter2203 what do you think of it?

Sorry for the delay, I'll look into it tonight!

Hi,
I've added boosts in v2.0.0 for scores that are exact matches. I also added a test to check for this (this is way I did not use your code).
It now sorts in this order:

Exact match
Strings starting with search query
Distance between indexes in matches for query

Feel free to open an issue if something is unclear or if you'd like to see more improvements!

Thanks. It seems exactly what I want 👏


inference & input/output question

I have read your paper but still have some questions:

inference code? there are only two evaluation codes in your project
the input is image data and yaw value, the output is new embedding, but how to remapping it to frontal face visually.
Is it possible to implement in large scale, not the interesting result in your paper? only sample dataset is given
Thank you very much, I think the module is similar as the classical STN network, Good job~

@guoxiaolu
Hello! I am also inteststed in this work,  and i want to ask some questions about this paper. BTW, this is my email<EMAIL_ADDRESS> I look forward to getting in touch with you. Thank you!

Thanks for asking.

For visualization, please refer to this repo #11
"implement in large scale" means implement our algorithm on large dataset? Actually, experiment results reported in our paper are all implemented on large scale dataset. But those datasets we used, such as MsCeleb-1M belong to sensetime and I have no right to make them public available. So I only release a sample dataset to make sure you could go through the whole pipeline successfully and have a rough idea of how the training data should be organized.

okay, Thank you, Good job~


TS2304: Cannot find name xxx but no errors with tsc

Expected behavior:
Complete successfully without any errors like running npm run tsc does
Actual behavior:
Error messages logged includes:
error TS2304: Cannot find name 'Promise'
error TS2304: Cannot find name 'Map'
error TS2304: Cannot find name 'MapConstructor'
error TS2304: Cannot find name 'Iterator'

96 semantic errors
emit succeeded (with errors)
Your gulpfile:
Include your gulpfile, or only the related task (with ts.createProject).
https://github.com/angular/angular2-seed/blob/systemjs/gulpfile.js
//Typescript Config;
var tsProject = ts.createProject(tsConfig.compilerOptions);

//compile app typescript files
gulp.task('compile:app', function(){
  return gulp.src('src/**/*.ts')
    .pipe(ts(tsProject))
    .pipe(gulp.dest('./dist'))
    .pipe(connect.reload());
});

tsconfig.json
Include your tsconfig, if related to this issue.
https://github.com/angular/angular2-seed/blob/systemjs/tsconfig.json
Code
Include your TypeScript code, if necessary.
https://github.com/angular/angular2-seed/tree/systemjs/src

The problem is that the definition files from the typings directory aren't passed to TypeScript with that configuration (https://github.com/angular/angular2-seed/blob/b476ad20d00cc7452a315f5f85d1b6c499644743/gulpfile.js#L45). So this is a configuration problem. You can fix this by changing that line to:
return gulp.src(['src/**/*.ts', 'typings/browser/**/*.d.ts'])

Thanks for the quick reply. This works now as expected. But why does tsc work then without any errors?


[SPARK-15738][PYSPARK][ML] Adding Pyspark ml RFormula str method similar to Scala API

What changes were proposed in this pull request?
Adding str to RFormula and model that will show the set formula param and resolved formula.  This is currently present in the Scala API, found missing in PySpark during Spark 2.0 coverage review.
How was this patch tested?
run pyspark-ml tests locally

Test build #59892 has started for PR 13481 at commit c2e8d4b.

Test build #59892 has finished for PR 13481 at commit c2e8d4b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59892/
Test PASSed.

Test build #59911 has started for PR 13481 at commit 043e9bf.

Thanks @MLnick , I made those changes.  The string representation for the RFormulaModel is really ugly - it has lots of WrappedArray types.  I took all that out of the doc test, so let me know if what is there is ok.  I'm not really sure how it is even useful, maybe for debugging I guess?

Test build #59911 has finished for PR 13481 at commit 043e9bf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59911/
Test PASSed.

Merged build finished. Test PASSed.

Yeah actually looking at it the Scala side is a bit ugly. We can make it prettier there and then just call into it from PySpark, e.g.
scala> val formula = new RFormula().setFormula("clicked ~ country + hour + country:hour").setFeaturesCol("features") .setLabelCol("label")
formula: org.apache.spark.ml.feature.RFormula = RFormula(clicked ~ country + hour + country:hour) (uid=rFormula_7e1422944cda)

scala> val model = formula.fit(dataset)
model: org.apache.spark.ml.feature.RFormulaModel = RFormulaModel(ResolvedRFormula(label=clicked, terms=[country,hour,{country,hour}], hasIntercept=true)) (uid=rFormula_7e1422944cda)

and
In [8]: rf._call_java("toString")
Out[8]: u'RFormula(y ~ x + s) (uid=RFormula_495190a2bd89e76b710f)'

In [9]: model._call_java("toString")
Out[9]: u'RFormulaModel(ResolvedRFormula(label=y, terms=[x,s], hasIntercept=true)) (uid=RFormula_495190a2bd89e76b710f)'

This is achieved by amending RFormula.toString (by the way on second thought I prefer your approach of empty string instead of None):
override def toString: String = s"RFormula(${get(formula).getOrElse("")}) (uid=$uid)"

And overriding ResolvedRFormula.toString:
private[ml] case class ResolvedRFormula(
  label: String, terms: Seq[Seq[String]], hasIntercept: Boolean) {

  override def toString: String = {
    val ts = terms.map {
      case t if t.length > 1 =>
        s"${t.mkString("{", ",", "}")}"
      case t =>
        t.mkString
    }
    val termStr = ts.mkString("[", ",", "]")
    s"ResolvedRFormula(label=$label, terms=$termStr, hasIntercept=$hasIntercept)"
  }
}

cc @yanboliang

+1 @MLnick

That looks pretty good to me too, thanks @MLnick! I'll put that in soon.

Test build #60057 has started for PR 13481 at commit 7400448.

@MLnick , I added the nicer string override for ResolvedRFormula and updated the doc tests accordingly

Test build #60057 has finished for PR 13481 at commit 7400448.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60057/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

Can this be merged @MLnick ?

LGTM2

@yanboliang do you want to go ahead and merge this one?

I was trying to merge this, but looks like the merge script is not happy. Please feel free to merge this.

Merged to master/2.0. Thanks!

Thanks Yanbo!
On Jun 10, 2016 1:38 PM, "Yanbo Liang"<EMAIL_ADDRESS>wrote:

Merged to master/2.0. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/13481#issuecomment-225289257, or mute
the thread
https://github.com/notifications/unsubscribe/AEUwddz_Gr2ko_ByNrhCrU4fx934N9qlks5qKctMgaJpZM4ItDSN
.


ISO XML Measured Parameters Update for DSWx-HLS

[x] Creation of the Measured Parameters Description YAML config

Latest product spec can be found in Artifactory under the following path: general/gov/nasa/jpl/opera/sds/pge/dswx_hls/documentation/OPERA_DSWX_HLS_R4_ProductSpec.docx

[x] Update the existing ISO XML template to use a jinja2 for-loop construct for the MeasuredParameters section. This should be performed after creation of the Parameter Description file described above

[x] Update _collect_dswx_hls_product_metadata() to include a call to augment_measured_parameters() to ensure all metadata is formatted as expected before the template is instantiated

[x] After all changes are made, run the integration test for the PGE (either via Jenkins or locally on dev machine) and inspect the resulting ISO XML product to ensure MeasuredParameters section is filled out as expected.

Closed by #540


上传文件大小限制

Why do you need it?
Is your feature request related to a problem? Please describe in details
请问是否支持上传文件大小限制？最好通过global配置实现，而不是在 Ingress Annotation 中实现。Thanks。
How could it be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

不是helm的参数，通过gateway自动加载，类似nginx Ingress：

nginx-configuration配置参考：

所以你需要的是一个全局的配置能力，而不是 Ingress 这种路由级的配置，我理解的对吗？

可以通过插件实现这个能力，应该很简单，只需要在 onRequestBody 阶段统计下 size 就行

pls~ ,assgin me

Please assign to me. Thanks~

pls~ ,assgin me

I assign this issue to LeBW, you can focus on the development of  OIDC plugin, haha

pls~ ,assgin me

I assign this issue to LeBW, you can focus on the development of OIDC plugin, haha

Sure, no problem

"Is there any progress? If not, can you hand it over to me to give it a try?"

"Is there any progress? If not, can you hand it over to me to give it a try?"

thanks for your goodness. It’s almost done ❤


Unable to determine correct auth method

Hello, (the installation tutorial is very tortuous, there are many pages, it's really not easy... !)
At the end, when I click on "Link MS365 account" (and I accept), it downloads on my macbook a file named "nativeclient" as the redirection URL was incorrect !
(The other methods doesn't work anymore)

Use Chrome not Safar

Ok thanks... It work... (why I didn't have the idea...)


BEC fixes from ESM

One actual bug-fix and a couple minor improvements.

Codecov Report

Merging #798 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   85.71%   85.83%   +0.11%
==========================================
  Files          18       18
  Lines        4796     4799       +3
==========================================
+ Hits         4111     4119       +8
+ Misses        685      680       -5

Impacted Files
Coverage Δ

bluesky/plans.py
94.25% <ø> (ø)
:arrow_up:

bluesky/callbacks/core.py
89.51% <ø> (+0.87%)
:arrow_up:

bluesky/callbacks/best_effort.py
89% <100%> (-0.58%)
:arrow_down:

bluesky/callbacks/scientific.py
62.96% <0%> (+2.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7d37c...516ffd7. Read the comment docs.


Enable float-singleton test cases

Description:

Describe your task(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

float-singleton2.bal is blocked on https://github.com/ballerina-platform/ballerina-lang/issues/28334 and https://github.com/ballerina-platform/ballerina-lang/issues/32722.


Are document instructions not used for evaluation?

Hi there!  Thanks for the great work!
I was trying to reproduce the MTEB evaluation and noticed that it seems like the instructions for documents are not used.  Is that correct?
See: https://github.com/xlang-ai/instructor-embedding/blob/e749023b14d36cdff234398de57d9b6c519e776a/evaluation/MTEB/mteb/abstasks/AbsTaskRetrieval.py#L738 referencing sentences instead of new_sentences that contain the instructions.
Totally fine, if that is true (even if unintentional - just trying to reproduce it).

Thanks for pointing out! See here for the latest version!

Ah nice, I see it was updated! Sorry, I had started using this repo before then and didn’t realize there had been a change.
Appreciate your time!


Apple rejected the app due to missing "Merchant name" on the apple pay payment sheet

Describe the bug
My app got rejected using the stripe plugin because there is no merchant name that the user can see on apple pay Payment Sheet.
To Reproduce
Steps to reproduce the behavior:
Create and open the apple pay sheet
Expected behavior
I need to be able to show a merchant name on the apple pay payment sheet
Screenshots

Smartphone:

Device: iPhone 1 1 Pro Max
OS: ios 14

Is there any way to display the merchant name after the "PAY" text?

I was able to resolve this. You can display the merchant name by adding it as the last Summary Item. Ex.:
const summaryItems = [
    ...itemsInPurchase,
    {
        label: 'Food Company Inc.',
        amount: 50 // This needs to be the purchase total
    }
]

@flavioribeirojr Did you adapt this plugin for production? If yes, please tell us what app. Please help us to develop this plugin in 2022.
https://github.com/capacitor-community/stripe/issues/145
Thanks.

Hello,
I have the same issue with @stripe/stripe-react-native V0.19.0, I have tried your fixed but the merchant name does not appear on apple pay popup window so apple rejected my app.
const response = await presentApplePay({             cartItems: [                 {                     label: "My CompanyName Limited",                     amount: "0.00",                     paymentType: "Deferred",                     deferredDate: Date.now(),                 },             ],             country: CONFIG_PAYMENT.country,             currency: CONFIG_PAYMENT.currency,         });

@nicks78 have you managed to resolved that ?
I have the same problem with "@stripe/stripe-react-native": "0.23.3" and "react-native": "0.71.8"

Finally I managed to solve this by **setting the payment type to Immediate instead of defered.
A lot of trial and errors to fix that 🥵 Hope it helps
Here is my before / after code:


BERT Classifier: Loss is 0?

Hey,
I am trying to run the BERT Classifier example with the MRPC task.
I get the following error:
Traceback (most recent call last):
  File "C:\Program Files\JetBrains\PyCharm 2018.3.3\helpers\pydev\pydevd.py", line 1741, in <module>
    main()
  File "C:\Program Files\JetBrains\PyCharm 2018.3.3\helpers\pydev\pydevd.py", line 1735, in main
    globals = debugger.run(setup['file'], None, None, is_module)
  File "C:\Program Files\JetBrains\PyCharm 2018.3.3\helpers\pydev\pydevd.py", line 1135, in run
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "C:\Program Files\JetBrains\PyCharm 2018.3.3\helpers\pydev\_pydev_imps\_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "C:/Development/Git/texar-pytorch/examples/bert/bert_classifier_main.py", line 274, in <module>
    main()
  File "C:/Development/Git/texar-pytorch/examples/bert/bert_classifier_main.py", line 258, in main
    _train_epoch()
  File "C:/Development/Git/texar-pytorch/examples/bert/bert_classifier_main.py", line 156, in _train_epoch
    input_ids = batch["input_ids"]
  File "C:\Development\Git\texar-pytorch\texar\data\data\dataset_utils.py", line 78, in __getitem__
    return self._batch[item]
KeyError: 'input_ids'

Changing the keys as for example in input_ids = batch["input_ids"] to input_ids = batch["data_input_ids"] seems to fix these errors.
However, then i tried the script like this
python bert_classifier_main.py --do_train --do_eval
and get the following logs:
python bert_classifier_main.py --do_train --do_eval
Pretrained model loaded from bert_pretrained_models/uncased_L-12_H-768_A-12\bert_model.ckpt
INFO:root:step: 50; loss: 0
INFO:root:step: 100; loss: 0
INFO:root:step: 150; loss: 0
INFO:root:step: 200; loss: 0
INFO:root:step: 250; loss: 0
INFO:root:step: 300; loss: 0
INFO:root:eval accu: 0.8578; loss: 0.3904; nsamples: 408

Is this correct?

The KeyError was the result of the addition of a new data module; we'll fix this soon. Just to confirm, have you also added the "data_" prefix to "segment_ids" and "label_ids"?
For the loss part, I'm not sure what happened. This should not be correct. We're still looking into this problem.

Hey, yes I added the "data_" prefix to all related dataset keys (segment_ids, label_ids, input_ids). After that I could train the model with the script. Not sure what happen with the loss, though.

Is the loss still 0 after you change these keys? I'm not very sure which commit induces this bug but hopefully, this version can work. We're still working on this.

hey, i changed the keys and I did
git checkout ac3e334e491f524dd01654b07af030fa20c88b34
pip install -e .

to get to the commit you mentioned.
This is the output of the training. So, Loss is still 0.
(env) C:\Development\Git\texar-pytorch\examples\bert>python bert_classifier_main.py --do_train --do_eval
Pretrained model loaded from bert_pretrained_models/uncased_L-12_H-768_A-12\bert_model.ckpt
INFO:root:step: 50; loss: 0
INFO:root:step: 100; loss: 0
INFO:root:step: 150; loss: 0
INFO:root:step: 200; loss: 0
INFO:root:step: 250; loss: 0
INFO:root:step: 300; loss: 0
INFO:root:eval accu: 0.8480; loss: 0.4097; nsamples: 408

Sorry you may want to try this version:
https://github.com/asyml/texar-pytorch/commit/15d04a7ad6c7432ad2e0b9accf434f53be423459#diff-7ab4b40bab7f699ffd21cacea48a51aa
It should be able to give such results:
INFO:root:step: 50; loss: 0.5814850926399231;

This issue is now fixed in 17c44ac. There are actually no bugs in the model -- it's the logging message that was wrong. A %d specifier was incorrectly used for the floating point variable loss (which was less than 1).
Sorry for the inconvenience.


DRA: update testing pod yamls

added pod referencing external resource claim
used ubuntu images for pod-external and pod-inline
run simple test commands to check CDI injection
set pod restart policy to Never

Can you also update test/integration/cdi/example-driver/deploy/example/shared-resource-claim.yaml?

done. modified it and renamed to pod-shared.yaml for the name consistency.


Documentation site is b0rken

There seems to be some JS forcing the page to scroll to top which fights with any attempt to scroll down or keep the revealed text further down in view.
Windows 10,
Google Chrome is up to date
Version 66.0.3359.139 (Official Build) (64-bit)

Happens to me too :disappointed:

You can go around it by opening selecting Event Listeners in Chrome dev tools, click on the scroll listener, and it should give you an option to remove it. That's how I got it working. You have to do it on each page refresh though.

I copied the particular document page in notepad and that's how reading it .


Updating patterns

Is it possible to update the patterns since it changed in season 14 of apex ?
thxx so much for your work :)

yeah that would be awesome


How to properly use it with jQuery.noConflict?

Thanks for the nice plugin! I need to use the with jQuery.noConflict. How ca I do this?

I have no idea. I never used jQuery.noConflict before and the noConflict code I added is just a pattern I copied over from other jQuery plugins.
Try the jQuery documentation, Google or StackOverflow.

I have just replaced code
$ = $ && $.hasOwnProperty('default') ? $['default'] : $;
with
$ = jQuery;
Also the code to install ripples:
jQuery('.homebanr').ripples({
resolution: 500,
perturbance: 0.01
});
have a nice day!


Demo testsuite.js failing with "attempted to assign to readonly property"

When following the directions to run the demo/testsuite.js, the suite fails and emits an "Attempted to assign to readonly property" error.

Thanks for the PR


Error while initializing app TypeError: parentVal.concat is not a function

Version
2.0.0
Reproduction link
https://nuxtjs.org
Steps to reproduce
Upgrade a project to Nuxt 2.0.0.
What is expected ?
No error.
What is actually happening?
Hello. I get the following error that is not easy to understand and debug:
[nuxt] Error while initializing app TypeError: parentVal.concat is not a function
    at mergeHook (commons.app.js:10224)
    at mergeField (commons.app.js:10485)
    at mergeOptions (commons.app.js:10476)
    at Function.Vue.extend (commons.app.js:13793)
    at sanitizeComponent (app.js:4688)
    at _callee$ (app.js:4757)
    at tryCatch (commons.app.js:4154)
    at Generator.invoke [as _invoke] (commons.app.js:4388)
    at Generator.prototype.(anonymous function) [as next] (http://localhost:3000/_nuxt/commons.app.js:4206:21)
    at asyncGeneratorStep (commons.app.js:33)

It seems to be part of the Vue.js framework. Any idea what could cause this in my code? A module, a Vue plugin, an external lib?

This bug report is available on Nuxt community (#c7819)

Same is happening to me after I updated my dependencies.

It's a bug in nuxt-i18n after the last vue-meta release.
Use seo: false in the module options or downgrade vue-meta by one minor version to temporary work around the issue.

I can confirm that turning seo to false fixes the issue for now.
I tried to downgrade vue-meta to 1.5.3 and other issues started happening.

Wow, thank you for the quick workaround!

Yes - after an upgrade of my test project from 1.0.0 to 2.0.0 (same from 1.0.0 to 1.4.x versions) i also figgered out that nuxt-i18n causes this error. Setting seo to false fixed this error.

Any ideas how to fix it without "seo:false" ?
Otherwise, do we have to manually add the alternate url to every page ?
Best,

@manniL
In my nuxt.config.js file, I tried:
modules: [
    ['nuxt-i18n', {
      seo:false
    }]

But this does not fix the issue, am I doing this the wrong way maybe? Thank you
Billal Begueradj

@begueradj There might be another reason as well. Try downgrading vue-meta to 1.5.3

@manniL Thank you for the quick response.
I am not using vue-meta in my Nuxt.js application. All what I did is installing nuxt-i18n and set it as I showed (according to the official documentation), and then when I type npm run dev I get the same error above.

@begueradj You use vue-meta automatically because it's included in Nuxt. Please try it ;)

Resolved with<EMAIL_ADDRESS>

Updating the dependency nuxt from 2.0.0 to 2.2.0 did it.

Shouldn't be related to a nuxt upgrade as nuxt doesn't pin versions. A yarn upgrade or npm update would be sufficient.


Eliminate ⚠ when tabbing to a course detail view in My Tutorials

Each of the icons display, at first, ⚠, as show below. They should not.

how is it that you are getting to this problem? I can't seem to get the same issue to test it


futurebuilder cannot read data from subcollection

i have an application that stores items user favorite in a subcollection tied to the document which is also the uid of the user.Trying to populate a future builder with the data from the subcollection does not yield the desired result

@virtz
Unfortunately, this report does not have any actionable information - it’s not clear if this is a bug in user code, a bug in the framework, or something else entirely.
Please feel free to comment and I will re-open if you can add the following information:
The version of Flutter you’re using
The output of flutter doctor -v
The full exception you see or the result
A minimal reproduction that leads to this exception.