Request: Make a datetimepicker

Thanks for developing an awesome admin template!
Please consider to include a datetimepicker as a standard input component. Would be awesome!
Thanks!

This is one of the hardest things to find in a template. I'll love it ;)

you can use the ng-bootstrap datepicker out of the box with this template:
https://ng-bootstrap.github.io/#/components/datepicker

Yes, but I'm looking for a datetimepicker, not just a datepicker.
Thanks for pointing out a potential solution!

sorry, I overlooked:
https://github.com/akveo/ng2-admin/pull/101

ng-bootstrap timepicker stopped working since project migrated to cli

I think you have to implement your datetimepicker by CustomEditorCell method of this project.
I think this project has not for goal to implement this.


TensorFlow Implementation

Goals
Use TensorFlow for model back-ends to enable better extensibility. This issue will server as a base of operations regarding the progress and/or discussion around the implementation.
Aspects
@tylermzeller and I believe the following would be some of the required implementation plan to enable the above goal:

[ ] Rewrite Server to use TensorFlow as it's testing interface

A simple extension of the existing NodeJS server application wouldn't be possible due to TensorFlow's lack of support for JavaScript bindings.
In light of this a rewirte in Python would probably be most approperate. It supports the largest part of TensorFlows implemented models and documentation while being acessable and preformant

[ ] Rewrite of the Andorid app to use the TensorFlow bindings and TrainingInterface explored and developed in TensorFlow on Android

Lots of setup but we've been good about documenting it mostly
The Java bindings are currently not stable BUT have been made more available for public comment see api_docs

Pre-Requisites
NOTE: most of these can be explored through desktop TensorFlow applications

[ ] Validate that weights can be changed after a model is loaded

If this is not the case a work around must be found (such as a model reload)
EDIT: view the TF documentation on variables.

Structure Project as
Single app vs Library

StackOverflow article on how to [assign values to variables]
in TF (http://stackoverflow.com/questions/34220532/how-to-assign-value-to-a-tensorflow-variable)

Testing with:
import tensorflow as tf

with tf.Session() as sess:

    x = tf.placeholder(tf.float32, shape=[None, 784], name="x")
    y = tf.placeholder(tf.float32, [None, 10], name="y")
    w = tf.placeholder(tf.float32, [784, 10], name="weights_in")

    W = tf.Variable(tf.zeros([784, 10]), name="weights")
    b = tf.Variable(tf.zeros([10]))

    y_out = tf.add(tf.matmul(x, W), b, name="y_out")

    #cross_entropy = tf.reduce_mean(-tf.reduce_sum(y * tf.log(y_out), reduction_indices=[1]))
    cross_entropy = tf.reduce_mean(tf.nn.softmax_cross_entropy_with_logits(labels=y, logits=y_out))
    train_step = tf.train.AdamOptimizer(0.005).minimize(cross_entropy, name="train")

    correct_prediction = tf.equal(tf.argmax(y_out,1), tf.argmax(y,1))
    accuracy = tf.reduce_mean(tf.cast(correct_prediction, tf.float32), name="test")

    init = tf.variables_initializer(tf.global_variables(), name="init")

    tf.train.write_graph(sess.graph_def,
                         './',
                         'mnist_adam_0.005_mlp.pb', as_text=False)

Performance
When running the PR #32 I get the following performance bottleneck with the Data file reading taking up a large majority of the time:

I don't know that there are good alternatives to buffered IO. The only other way that could be possible is reading the data once and keeping all the samples in memory. Just to allocate enough memory for the training features, we need 784 4-byte floats to represent one feature vector. 60000 samples gives us 784460,000 bytes which is ~188 Mb of memory. Thats a bit much.


Window title (sway/window) styling for inactive screen

I have made the following settings in style.css.
Is there any way to stop the window title decoration that is done on inactive screen?
#window {
    font-weight: bold;
    color: black;
    background-color: gold;
    border-radius: 10px;
    padding-left: 10px;
    padding-right: 10px;
}

Window title of active screen:

Window title of inactive screen:

config:
    "modules-center": [
        "sway/window"
    ],

See #1403

#window.empty {
  display: none;
 }

Thanks. But unfortunately it doesn't seem to work.
[2022-03-08 20:58:19.181] [error] style.css:244:9'display' is not a valid property name

The following did not change the display
window#waybar.empty {
    color:            black;
    background-color: black;
    border-radius:    0px;
    padding-left:     0px;
    padding-right:    0px;
}

If you are referring to window#waybar.empty, I'm wondering if this is not an inactive workspace, but a workspace without a single window?
https://github.com/Alexays/Waybar/wiki/Module:-Sway#window
Looking at the Wiki, it doesn't seem like there is an inactive style format yet

Hi, @Alexays, @funcrab.
The hint with setting display: none for #window doesn't work because of the reason given by @funcrab. I had the same problem though and fixed it this way:
#waybar.empty #window {
    background: none;
}

Hope it helps! :)

@mgoral Works perfectly. I'm glad, Thank you!
Window title of active screen:

Window title of inactive screen:

style.css
#waybar.empty #window {
    background: none;
}

I wrote it in the Wiki.
https://github.com/Alexays/Waybar/wiki/Module:-Sway


Add images: Android Basics with Compose

URL of codelab
Section 7. Step 6.
**The hardcoded string is now replaced with a stringResource() function.
I'm not sure if its a typo or outdated but it says "stringResourcestringResource" instead of "getString"
GreetingImage( stringResource(R.string.happy_birthday_text), "From Emma")
in mine Android Stodio it shows
GreetingImage(getString(R.string.happy_birthday_sam), "From Emma")
**
Steps to reproduce?

follow the steps till step 6
see what happens in android studio,  it's slightly different then described.

Versions
Android Studio Hedgehog | 2023.1.1
Build #AI-231.9392.1.2311.11076708, built on November 9, 2023
Runtime version: 17.0.7+0-b2043.56-10550314 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0

oops I see it's noted, closing
Note: Some Android Studio versions replace the hardcoded string with the getString() function. Please manually change the function to stringResource() in such cases.


node / node-sass / CircleCI updates & fixes

Closes:

#414
#415

Description
Allows for building of project in Node 10, 12, 13, and 14.
Does builds (and more) for each runtime in CircleCI.
See: https://circleci.com/blog/circleci-matrix-jobs/
Compatibility
Improves compatibility with Node 13 and 14.
edit: Looks like this CircleCI change will not work with this repo's current checks in GitHub as they need to be explicitly "ci/circleci: build" and "ci/circleci: lint". The matrix jobs now make one build/lint per Node runtime (e.g. "ci/circleci: build-10.20.1", "ci/circleci: lint-10.20.1" ), so that would need to be changed.
Caveats
The CircleCI config could probably be cleaned up.

Very nice one, thank you 👍

Not sure what do to here, looks like the builds are stucked, and because of that I can't merge 😢

@guastallaigor see my comment

Looks like this CircleCI change will not work with this repo's current checks in GitHub as they need to be explicitly "ci/circleci: build" and "ci/circleci: lint".

I'd imagine changing some configuration on this repo's checks will fix it, see also: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-status-checks

@virtuoushub I see, I've tried to change inside the Circle CI settings, but unfortunately I don't have access to it, and I didn't find it anywhere else as of this moment.

@guastallaigor if you are an admin of this repository this should be a direct link to where you can turn on/off checks: https://github.com/nostalgic-css/NES.css/settings/branch_protection_rules/new
If you are not an admin, we will need one to help us; or I will need to refactor this PR to somehow have those checks as well.
@BcRikko / @trezy are you able to assist?

@virtuoushub I'm not a admin of this repository, for me the Settings tab do not exist.
I think it's too much checks to run for every PR, if possible it's better if we found a way to decrease them.

@guastallaigor while I agree the CircleCI config can be cleaned up, part of the point of this PR was to prove the the project can be built/used in multiple versions of Node. A lot of the checks happen in parallel so I do not think they are actually too many.
Having the CI build with various versions of node might help prevent future issues like:

https://github.com/nostalgic-css/NES.css/issues/392
https://github.com/nostalgic-css/NES.css/issues/414

Of the multiple checks per node version currently happening, I think the only one that does not need to happen in every version of node is the lint. I will work on making that one happen only once.

I understand, regardless I can only merge once all the checks that we have right now were successful.
You don't need to go out of your way to make this work, we can also wait for the other members that have admin access to the repo to remove the checks, but it can take a while.

Thank you so much @virtuoushub and @SecretBase for your hard work :tada:
I couldn't have it done better myself for sure.


Update actions/checkout to v4

Thanks for the awesome repo! :pray:

No problem, thanks looks good.
If you're looking to pickup PRs, we could do the same in the other related projects:

https://github.com/nickjj/docker-flask-example
https://github.com/nickjj/docker-rails-example
https://github.com/nickjj/docker-node-example
https://github.com/nickjj/docker-phoenix-example

If not, it's all good, I'll port the change over to them.

No problem, thanks looks good.
If you're looking to pickup PRs, we could do the same in the other related projects:

https://github.com/nickjj/docker-flask-example
https://github.com/nickjj/docker-rails-example
https://github.com/nickjj/docker-node-example
https://github.com/nickjj/docker-phoenix-example

If not, it's all good, I'll port the change over to them.

@nickjj Here you go!
https://github.com/nickjj/docker-flask-example/pull/25
https://github.com/nickjj/docker-rails-example/pull/91
https://github.com/nickjj/docker-node-example/pull/5
https://github.com/nickjj/docker-phoenix-example/pull/15


Value disappear in number field when try to update

When a number is set and I try to edit with the "update" menu voice, the number isn't stored in the popup window.
Increasing function works, as shown.

Hi, good catch. will be fixed in the next release

fixed in 0.1.22x


Playground search by title or tag is broken?

https://doc.babylonjs.com/playground?q=gltf (0 results)
https://doc.babylonjs.com/playground?tag=gltf (0 results)
where as https://doc.babylonjs.com/playground?code=gltf (53 results) including some tagged with glTF and have titles that contain glTF.

The results show up now, but the count of results still say 0.

On it!

PR for the count.


Enabling miner before running setup-for-local-development throws error

Setting
node bin/mn config:set core.miner.address yfMr9oWYGLwAgdyuXUbTDE2bgXahCarMKG
node bin/mn config:set core.miner.enable true

before running setup-for-local-development throws:
  ✔ Wait 20 seconds to ensure all services are running
  ❯ Initialize Platform
    ✖ Failed to perform standard injections with reason: Worker IdentitySyncWorker failed onStart: Worker IdentitySyncWorker failed onExecute: No available addresses for retry: 13 INTERNAL: connect ECONNREFUSED…
    ◼ Register DPNS identity
    ◼ Register DPNS contract
    ◼ Obtain DPNS contract commit block height
    ◼ Register top level domain "dash"
    ◼ Disconnect SDK
  ◼ Stop node

enabling the miner after first running setup-for-local-development works.

I cannot reproduce this from the current master branch. The miner starts fine and generates blocks at the specified interval and to the specified address, even if entered in the config before setting up for local development. @dashameter please ensure you have cleaned up any data and config left over from previous work, e.g. as follows:
mn config:default local
mn reset
mn config:reset
mn config:set core.miner.address yfMr9oWYGLwAgdyuXUbTDE2bgXahCarMKG
mn config:set core.miner.enable true
mn setup-for-local-development
mn start

Can you verify?

I reset everything and tried it again and can confirm I now longer see this error thrown. I had reset and repeated this multiple times before when I saw this error, not sure if master updated in the meantime or if it was a bad config on my local machine that the reset didn't reset.. closing issue for now.


Add --help_markdown flag to generate documentation for the flags

I wanted a page to document the flags. I added a --help_markdown flag to generate the flag usage in a format for the wiki. The output of that flag can be directly pasted into https://github.com/google/closure-compiler/wiki/Flags-and-Options

imported and sent for internal testing and to @lauraharker for review

Hit a snag.
This PR uses an args4j feature (parser.getProperties()) that doesn't exist in args4j 2.0.26,
which is the canonical version used internally at Google.
(Upgrading args4j would require someone to fix all projects that use args4j inside Google,
so not in scope for this PR.)
Our POM was incorrectly changed to use args4j version 2.33.
I'll need to undo that, and this PR needs to be changed to avoid any features not in
args4j 2.0.26.
Sorry.

That's an easy fix on my side when that's changed.

args4j version change submitted internally
it'll be in tomorrow's push

Changes made @brad4d

updates imported and sent for internal testing and review with @lauraharker


Error: connect EADDRNOTAVAIL <IP_ADDRESS> when Azure function app using Prisma, VNet integration enabled

Bug description
Azure function app uses Prisma 2 to select data from MySQL database server on virtual private network. When querying the data, function app crashes with the following error message with changing port number:
2021-02-25T09:21:33.515 [Error] Executed 'Functions.offline-data-exporter' (Failed, Id=b4889147-xxxx-xxxx-xxx-
xxxxxxxxxxx, Duration=1554ms)
Result: FailureException: Error:Invalid `prisma.disconnector.findMany()` invocation
in D:\home\site\wwwroot\dist\shared\offline-data-exporter.js:15:84
connect EADDRNOTAVAIL <IP_ADDRESS> - Local (<IP_ADDRESS>:50306)Stack: Error:Invalid `prisma.disconnector.findMany()`
invocation in D:\home\site\wwwroot\dist\shared\offline-data-exporter.js:15:84
connect EADDRNOTAVAIL <IP_ADDRESS> - Local (<IP_ADDRESS>:50306)at PrismaClientFetcher.request
(D:\home\site\wwwroot\node_modules\@prisma\client\runtime\index.js:78585:15)at processTicksAndRejections (internal/process/task_queues.js:97:5)

How to reproduce

Use Azure App Service Plan: Elastic Premium EP1 to use VNet integration
Configure VNet Integration to function app (database is in 10.0.0.x, function subnet is 10.0.100.x)
Deploy Azure function app using Prisma client
Run export function which queries the MySQL database server
See error above

Expected behavior
Database disconnector table query results should be returned normally.
Database querying has been working properly with the same setup until the beginning of February. Upgrading or downgrading Prisma, or even deploying the last known working version of function app does not solve the problem. Creating a new app with similar settings does not work either.
The same exporter code works fine on two other Azure environments using Azure MySQL for database without VNet integration enabled in function app.
Using mysql2 to connect and query disconnector data from VNet database server works ok.
Prisma information
prisma.schema:
datasource network {
  provider = "mysql"
  url      = "mysql://user:pass@10.0.0.x/database?connection_limit=1&sslmode=disable" // sample, read from env, see below
}

generator client {
  provider = "prisma-client-js"
}

model Disconnector {
  code               String    @id
  name               String
  protectiveEarthing Float?    @map(name: "protective_earthing")
  systemEarthing     Float?    @map(name: "system_earthing")
  totalEarthing      Float?    @map(name: "combined_earthing")
  measurementDate    DateTime? @map(name: "measure_date")
  data               Json

  @@map(name: "disconnector")
}

data-exporter.ts:
const prisma = new PrismaClientFactory().create(network);
try {
      await prisma.$connect();
      const disconnectors = this.asDisconnectorDto(
        await prisma.disconnector.findMany(),
        await prisma.$queryRaw<
          LocationData[]
        >`SELECT code, ST_AsText(loc) AS spatialData FROM disconnector;`,
        projection
      );
      await prisma.$disconnect();
  ....
} finally {
      await prisma.$disconnect();
}

prisma-client-factory.ts - code from last known working commit using Prisma v2.10.2. Reads connection string from env and replaces the database portion:
export class PrismaClientFactory {
  create(network: string): PrismaClient {
    const database = `abcdef_${network}`;
    const prisma = new PrismaClient({
      // log: ["query", "info"],
      datasources: {
        network: {
          url: process.env.MYSQL_CONNECTION_STRING?.replace(
            "${database}",
            database
          ),
          provider: "mysql",
        },
      },
    });
    return prisma;
  }
}

Environment & setup

OS: Azure function app on Windows machine with VNet integration enabled
Database: MySQL 5.7 on private virtual network
Node.js version: v12.18.0, also tested with setting Node 14 LTS in Azure function app settings
Prisma version: 2.10.2 and 2.17.0 both tested

tcpping can reach database server and port 3306 from function app console.
See MySQL connection string example format in Prisma schema code.
Additional checks done
The following have been checked:

database connection string is ok and database user can connect to database and has sufficient rights
deployed function app has been stopped and restarted
database query works normally using mysql2 library
VNet integration subnet 10.0.100.x is connected and working correctly on other function apps not using Prisma

The following have been tried and none of these have worked:

upgrading Prisma version to 2.17.0 and re-deploying the function app
downgrading back to 2.10.2 and re-deploying the function app
building release from the last known working commit and re-deploying the function app
deploying code to new function app with similar configuration built from ground up
removing connection_limit and sslmode from MySQL connection string

@inertica Looks like http bridge is getting closed. Can you please try this workaround?
https://github.com/prisma/prisma/issues/5533#issuecomment-788016345

@pantharshit00 we tried the workaround, but it does not work as the platform deployed on Azure is Windows. Prisma 2.10 was working previously, and UDS problem was introduced in 2.15 according to the referenced issue.
Here is the error:
Executed 'Functions.offline-data-exporter' (Failed, Id=59e4df7b-1451-4775-af14-52ae91ba4848, Duration=5510ms)
Result: FailureException: Error: Unix sockets not supported on this platform
Stack: Error: Unix sockets not supported on this platform
at LineStream.<anonymous> (D:\home\site\wwwroot\node_modules\@prisma\client\runtime\index.js:27139:31)
at LineStream.emit (events.js:315:20)at addChunk (_stream_readable.js:295:12)
at readableAddChunk (_stream_readable.js:271:9)
at LineStream.Readable.push (_stream_readable.js:212:10)
at LineStream.Transform.push (_stream_transform.js:152:32)
at LineStream._pushBuffer (D:\home\site\wwwroot\node_modules\@prisma\client\runtime\index.js:24055:19)
at LineStream._transform (D:\home\site\wwwroot\node_modules\@prisma\client\runtime\index.js:24049:10)
at LineStream.Transform._read (_stream_transform.js:191:10)
at LineStream.Transform._write (_stream_transform.js:179:12)

Hmm, this seems unrelated to binary process then. Try increasing the connection timeout once. It might be failing before attaining a connection.
Add this to your connection string: ?connect_timeout=30&pool_timeout=30&socket_timeout=30

Increasing the timeouts did not make a difference. The EADDRNOTAVAIL error is returned usually right after (less than 1 second) the DB query is executed.

Hey @inertica
Are you able to still reproduce this in the latest version of Prisma?

Please propose a fix for this

A fix for what exactly? Do you have the same problem that inertica had in the beginning? Can you help us to get to a reproduction?

Yes, Same issue - Azure Function (Windows) with VNET Integration.   Happy to create a reproduction to aid testing.

@DavidChristiansen it would be excellent if you could assist with the reproduction of the issue on your environment. At this point, our production environment is not available to set up testing for this and we have already extensively switched ORM to another one to keep production up, running and updateable.

I also get the same Error: connect EADDRNOTAVAIL <IP_ADDRESS> error when the first query is run. Using Azure App Service with windows container.

Why does prisma need internet connection when generating the client?
It's requesting ......../windows/query.engine.dll.node.gz.sha256.

That sounds pretty unrelated @BeGj. Please open a new issue or discussion about this for you unexpected behavior so we can look into it.

@janpio  Sorry. This was the most related issue I were able to find.. Trying again in a  newdiscussion https://github.com/prisma/prisma/discussions/9228

I'm closing this since I think Prisma 4 will fix this with n-api.


Add Catppuccin themes

Clear and concise description of the problem
It would be cool to have Catppuccin support from: https://github.com/catppuccin/vscode/tree/compiled
Suggested solution
Source is here: https://github.com/catppuccin/vscode/tree/compiled
I'm already using those with Shikiji, so I suppose it's going to work properly by just adding the json source in source-themes.ts.
I'm following the contribution guide to open a PR :)
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Happy to have them, PR welcome :)


[Bug]: Application name change , share enable, fork enable - these actions show no commits on git status

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we change application name, enable share, enable fork - these actions show no commits on git status
Steps To Reproduce
https://github.com/appsmithorg/appsmith/assets/101863839/c1564226-6ef5-482d-b737-1864c739bc81
Public Sample App
No response
Environment
Release
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
Cloud

No, this is the first issue raised so far will try to resolve ASAP.

Closing for the reasons mentioned by Rudra above.


App crashes

Hi,
I am getting this error after show bubble and close - re open app several times i get

I am also facing this issue, any one have give a quick solution ?


Blender Guide is blunt

The guide for blender in game development is not upto other guides in the repo,
https://github.com/the-ethan-hunt/first-timers-guide/blob/master/guides/Game Development/Blender.md

@eddygta17 if you can, then please create a better guide for blunt. :smile:

Sure I will do it.


[SPARK-49359][SQL] Allow StagedTableCatalog implementations to fall back to non-atomic write

What changes were proposed in this pull request?

This PR allows StagedTableCatalog#create/replaceTable to return null and Spark will fall back to normal non-atomic write.
Why are the changes needed?

Extending an interface is static but sometimes the implementations need more dynamicity. For example, a catalog may only support atomic CTAS for certain table formats, and we shouldn't force them to implement atomic writes for all other formats.
Does this PR introduce any user-facing change?

no
How was this patch tested?

new test
Was this patch authored or co-authored using generative AI tooling?

no

cc @yaooqinn @huaxingao

Merged to master.

This is a critical issue for catalogs that want to support atomic write. I'm backporting this to 3.5 as it's LTS.

This is a critical issue for catalogs that want to support atomic write. I'm backporting this to 3.5 as it's LTS.

To be align with the above assessment, I converted the issue type from Improvement to Bug, @cloud-fan . +1 for backporting.

It seems that this broke branch-3.5 compilation. Here is a follow-up.

https://github.com/apache/spark/pull/47868


[WIP] Audio primitives

Proposal: #2 (Previous PR: #12)
This is mostly a copy+paste from the previous PR, except I've pulled out the primitives into their own PR to make them slightly easier to discuss. Documentation and nits from the previous PR will be fixed shortly. These hould now be fixed.
Changes to design

IAudioProvider has two new methods, StartAsync and StopAsync

This is to support APIs which have asynchronous initialization, such as PulseAudio.
APIs return ValueTask, as not all backends will require asynchronous initialization, so they can return synchronously without causing any overheads.

IAudioProvider.RequestAudioDevice is now async, returning a ValueTask

Again, this is to support APIs which require asynchronous initialization of devices, such as PulseAudio.
Likewise, not all backends will require asynchronous initialization so it returns ValueTask to allow those which are not asynchronous to use it.

Added AudioDeviceType enum to discern recording from playback devices in IAudioDeviceOptions

This could be expanded in the future to further identify device types, e.g. recording devices which record system-wide sound output, or 'Stereo Mix' devices on Windows.

Open Questions
Do we use IAsyncEnumerable for EnumerateAudioDevices?
In the PulseAudio implementation I have had to use a BlockingCollection to implement it as PulseAudio returns the device list asynchronously. Maybe we could change the interface to return a IAsyncEnumerable<IAudioDeviceOptions> instead and then return some other type, possibly one generated by the compiler.
We should add an IAudioDeviceEnumerable interface supporting sync and async enumeration, and have providers implement this as appropriate.
Do we change EnumerateAudioDevices to return a different type from RequestAudioDeviceAsync?
Currently, we use the same type to implement both. However, this leaves us in a weird state where we're returning mutable information from a method, and also accepting properties which may not even make sense (e.g. Name) when requesting audio devices.
Naming and implementation of StartAsync/StopAsync
What names make most sense? Do we provide sync/async versions? It all depends on provider, but we need a common ground for public API concerns.
We should support both, and allow the user to choose the synchronous or async version - having explicit models which aren't just StartAsync().GetResult() is better anyway.
Further question: Do we provide two interfaces for this? IAsyncAudioProvider and IAudioProvider? The implementation will likely change based on whether a device is being used asynchronously or synchronously. This will also make implementing APIs easier as async providers can implement one interface or the other. However, it will make it harder to consume, so we'd need some middle ground.

Some notes from the previous PR which might be useful to mention:

Does it make sense to Reset the audio decoder pipe? (And by extension, the audio encoder pipe)
Maybe Decode/Encode makes more sense instead of RunAsync in the encoders/decoders
It might be preferable to not have the explicit finalizer
Can an audio device have multiple types or will they always be reported separately? (Seems to be the case)
Is it worth having a common base for encoder/decoder options?
We should have separate interfaces for devices - IAudioPlaybackDevice and IAudioRecordingDevice

Thought for the IAudioDeviceEnumerable type: Should we have an IsAsynchronous and/or IsSynchronous member so we can differentiate between providers that are just implementing sync-over-async and vice-versa? I don't know if this will help for performance or not, but it seems like a good idea to add for those who absolutely need their code to be async or sync for whatever reason, so they can choose the correct implementation for iteration.

Should we have an IsAsynchronous and/or IsSynchronous member so we can differentiate between providers that are just implementing sync-over-async and vice-versa?

I don't think one is strictly needed right now, but we can put it on the back burner as a possibility. I think, for the most part, users won't need to care and will just use the appropriate API for them.

I've slept on a few of the notes from the previous PR, and I've got a few more thoughts.

Having a Reset member on the audio encoder/decoder pipeline would likely be advantageous for re-using instances. We'll have to look into specific implementations of encoders/decoders, to see if they provide functionalities for this though. Worst case scenario, if we add it to the interface, we'd either have to re-create the native encoder, or throw a Not(Supported or Implemented?)Exception and this seems like a poor idea to me.

Encode/DecodeAsync seem like sensible names. We can use the Complete signal in the pipeline to indicate the 'stop' case, so RunAsync/StopAsync naming doesn't seem necessary.

If we remove the explicit finalizer, we should likely document that Dispose(false) is not called automatically, and that implementers have to call it in their own finalizer.

I don't think a common base class for encoder/decoder options really makes sense. Could you suggest a use case? My thinking is that the values might not completely line up so it seems inappropriate to share a base class. Especially for things like bitrate, which are only really relevant when encoding, as when you decode you generally want as much data in the output as you can from the input.

IAudioPlaybackDevice and IAudioRecordingDevice make a lot of sense. I already added them in the code, I forgot to mention in a commit message though.

If we remove the explicit finalizer, we should likely document that Dispose(false) is not called automatically, and that implementers have to call it in their own finalizer.

Generally the pattern is to only expose a Dispose() method that does nothing by default, or making it abstract so the consumer has to implement it properly.

If we remove the explicit finalizer, we should likely document that Dispose(false) is not called automatically, and that implementers have to call it in their own finalizer.

Generally the pattern is to only expose a Dispose() method that does nothing by default, or making it abstract so the consumer has to implement it properly.

Ah, I see. I'm not entirely familiar with Dispose implementations for public APIs. In this case, I suppose we could just inherit IDisposable and have subclassers implement it?

I'm not completely sure about the behaviour of Reset on pipes when they may still be getting read from or written to, so I'm not completely certain about the implementation of Reset I've chosen. I felt it was best to at least complete the input pipe, to stop EncodeAsync if it is running.

In this case, I suppose we could just inherit IDisposable and have subclassers implement it?

Yes, since we have no guarantees that the implementer will have unmanaged resources, letting them decide the appropriate pattern is the right way to go.

There was something I was thinking about earlier about the encoder/decoder stuff - should we have an overload for the encoder/decoder which takes an existing input/output pipe? It'd likely be more efficient to do so, as well as cleaner in some cases. For example:
var decoder = new Mp3Decoder(/*...*/);
var encoder = new OpusEncoder(decoder.Reader);

await Task.WhenAll(
    encoder.EncodeAsync(),
    decoder.DecodeAsync(),
    WriteDataAsync(decoder.Writer)
);

should we have an overload for the encoder/decoder which takes an existing input/output pipe

I think eventually, yes. For this first iteration here though, I don't think we need it.
Long term, we likely want some sort of "effects/shaders/transforms pipeline". That would take in some source data, apply each effect/shader/transform and give you back output data. That would allow you to do things like transcoding, remixing, submixing, changing the speed, pitch, etc...
Ideally such a pipeline would be able to support things like pass-through and/or directly operating on the data as well so-as to minimize overhead, times you have to traverse, avoid copying, etc.

Long term, we likely want some sort of "effects/shaders/transforms pipeline". That would take in some source data, apply each effect/shader/transform and give you back output data. That would allow you to do things like transcoding, remixing, submixing, changing the speed, pitch, etc...

This sounds like a really interesting idea. I'm curious how it'll turn out. And yes, it's likely not necessary for the initial release.

(just a reminder, this is still draft mode and WIP and to fix that up when you think it is ready for merging 😄)

This should be more or less alright to review and merge now. I can't think of anything else that needs to be discussed, other than the sync/async support for IAudioProvider. I can't really think of any way to solve that solution cleanly.


Fixed punctuation and added an npm version badge

Fixed punctuation and added an npm version badge

Hi there ! This is a great way to get started ! Many thanks, LGTM 👍


The "get" script no longer works

Seems like one of the URL's is broken and the get script quits early in the process. Here's the output:
$ ./get
Getting package libc6 location for ubuntu-xenial-amd64
Getting ubuntu-xenial-amd64-libc6
  -> Location: http://security.ubuntu.com/ubuntu/pool/main/g/glibc/libc6_2.23-0ubuntu10_amd64.deb
  -> ID: libc6_2.23-0ubuntu10_amd64
  -> Downloading package
  -> Extracting package
  -> Writing libc to db/libc6_2.23-0ubuntu10_amd64.so
  -> Writing symbols to db/libc6_2.23-0ubuntu10_amd64.symbols
  -> Writing version info
Getting package libc6-i386 location for ubuntu-xenial-amd64
Getting ubuntu-xenial-amd64-libc6-i386
  -> Location: http://security.ubuntu.com/ubuntu/pool/main/g/glibc/libc6-i386_2.23-0ubuntu10_amd64.deb
  -> ID: libc6-i386_2.23-0ubuntu10_amd64
  -> Downloading package
  -> Extracting package
  -> Writing libc to db/libc6-i386_2.23-0ubuntu10_amd64.so
  -> Writing symbols to db/libc6-i386_2.23-0ubuntu10_amd64.symbols
  -> Writing version info
Getting package libc6 location for ubuntu-xenial-i386
Getting ubuntu-xenial-i386-libc6
  -> Location: http://security.ubuntu.com/ubuntu/pool/main/g/glibc/libc6_2.23-0ubuntu10_i386.deb
  -> ID: libc6_2.23-0ubuntu10_i386
  -> Downloading package
  -> Extracting package
  -> Writing libc to db/libc6_2.23-0ubuntu10_i386.so
  -> Writing symbols to db/libc6_2.23-0ubuntu10_i386.symbols
  -> Writing version info
Getting package libc6 location for ubuntu-bionic-amd64
Getting http://ftp.osuosl.org/pub/ubuntu/pool/main/g/glibc/libc6_2.27-3ubuntu1_amd64.deb
  -> Location: http://mirrors.kernel.org/ubuntu/pool/main/g/glibc/libc6_2.27-3ubuntu1_amd64.deb
  -> ID: libc6_2.27-3ubuntu1_amd64
  -> Downloading package
  -> Extracting package
  -> Writing libc to db/libc6_2.27-3ubuntu1_amd64.so
  -> Writing symbols to db/libc6_2.27-3ubuntu1_amd64.symbols
  -> Writing version info
Getting package libc6-i386 location for ubuntu-bionic-amd64
Getting http://ftp.osuosl.org/pub/ubuntu/pool/main/g/glibc/libc6-i386_2.27-3ubuntu1_amd64.deb
  -> Location: http://mirrors.kernel.org/ubuntu/pool/main/g/glibc/libc6-i386_2.27-3ubuntu1_amd64.deb
  -> ID: libc6-i386_2.27-3ubuntu1_amd64
  -> Downloading package
  -> Extracting package
  -> Writing libc to db/libc6-i386_2.27-3ubuntu1_amd64.so
  -> Writing symbols to db/libc6-i386_2.27-3ubuntu1_amd64.symbols
  -> Writing version info
Getting package libc6 location for ubuntu-bionic-i386
Getting http://ftp.osuosl.org/pub/ubuntu/pool/main/g/glibc/libc6_2.27-3ubuntu1_i386.deb
  -> Location: http://mirrors.kernel.org/ubuntu/pool/main/g/glibc/libc6_2.27-3ubuntu1_i386.deb
  -> ID: libc6_2.27-3ubuntu1_i386
  -> Downloading package
  -> Extracting package
  -> Writing libc to db/libc6_2.27-3ubuntu1_i386.so
  -> Writing symbols to db/libc6_2.27-3ubuntu1_i386.symbols
  -> Writing version info
Getting package libc6 location for ubuntu-disco-amd64
Getting http://ftp.osuosl.org/pub/ubuntu/pool/main/g/glibc/libc6_2.29-0ubuntu2_amd64.deb
  -> Location: http://mirrors.kernel.org/ubuntu/pool/main/g/glibc/libc6_2.29-0ubuntu2_amd64.deb
  -> ID: libc6_2.29-0ubuntu2_amd64
  -> Downloading package
Failed to download package from http://mirrors.kernel.org/ubuntu/pool/main/g/glibc/libc6_2.29-0ubuntu2_amd64.deb

Can you provide a pull request with the new ubuntu versions?


multiple queries

allows multiple queries ?, insert and update also begin transaction , commit and rollback inside? , do you have an example ?

There isn't multiple queries support yet. I'm working on new features like this.
Thanks!


fix(axios): resolve security vulnerability

https://nvd.nist.gov/vuln/detail/CVE-2019-10742

:tada: This PR is included in version 3.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


tweak: do not collapse group properties to children if they contain filters.

Some CSS filters have layout properties, a canonical example being:
<svg>
  <defs>
    <filter id="a">
      <feOffset dx="10" />
      <feGaussianBlur …/>
      <feColorMatrix …/>
    </filter>
  </defs>
  <g filter="url(#a)">
    <circle … />
  </g>
</svg>

(This happens to be how Figma does drop shadows, which is how I noticed this.)
When svgo pushes the filter attribute down to the <circle />, the gaussian blur gets awkwardly clipped on the top-left edges of the circle's bounding box. Based on this, I concluded it's best to not push down filters, just like clip-path and so forth.

SVGO v1.1.0 with the fix has been just released.


Byandell posts/01-first-map almost!

See my comment on https://github.com/earthlab-education/Earth-Analytics-AY24/issues/169.
Basically, I did the task, but could not figure out how to create a folder in the posts/01-first-map subfolder, so my files are just laying around. Advice?

I redid this, creating a folder byandell and put in files uwmadison.html and uwmadison.md

Sweet @byandell looks like you figured this out!


Logging Structure for future experiments

We need a more organized way to log timings for each function. A clean method to do so would be to make a scheme for logs and a function that implements this scheme. Something like Log(functionName, arguments, "start"/"finish"). This function can take the system clock time and print the time in a specified format. Once we have such a function, we can call it before and after each function that we are interested in. We can then write a script to parse the log, and then use that script for all future experiments. This will make experiments much simpler.

Included in commit: 031634e746d1068a766e4b72d571430871c440ca


Enable local tests to be run with testing-test SSO

Gives the testing-test SSO admin user permission to assume the MemberInfrastructureAccess role used in testing.
Removes the script to get the testing-ci user credentials as this is no longer needed.
Update the testing documentation.

Closes #1959


Replace sass

This PR removes the dependency on Sass. Or at least that was the original intent.
It ended up being a larger refactor/clean-up attempt.
Some highlights:

Some UX improvements
Performance improvements
Expanded mode for AST Viewer
Dark mode

I'll let @dawedawe play with this a little and eventually just merge this in.
I think everything should still work.

@nojaf, I think there is an issue, at least in dark mode:
#diagnostics li has color: var(--dark) so it gives black on black text.
I'm not sure how you want to fix this in the css declaration, maybe it would be good to have --dark-text-color and --light-text-color variables and use those.


cell line meta data annotation

Superseded by https://github.com/theislab/pertpy-tutorials/pull/16


[Feature Request] Linux app for PC gaming handhelds

Why?
With PC gaming handhelds such as the Steam Deck becoming more popular, it would be nice for to be able to have a game controller-friendly Crunchyroll app.
How?
As a proof of concept, I have already managed to get the crunchyroll-tizen app working on Linux via electron, you can see it in my fork here: https://github.com/aarron-lee/crunchyroll-linux/tree/electron_build
running npm run electron-build generates an AppImage in the electron/dist directory, which can be run on Linux systems.
Screenshot on Linux:
These are screenshots on Linux Desktop, not Tizen. I have also tested this successfully in gamescope-session, aka Steam Deck Game Mode

Next Steps:
If there is interest in adding this to upstream, I can open up a PR for it. Otherwise, I'll keep it in my fork and investigate further improvements.
Examples of further improvements that I will be investigating:

game controller support
external keyboard support for inputting username, password, and general navigation
remove notification for availability in tizen app store
etc

Just realized that there's a discussions board, perhaps this would have been better to open up there.

closing for now since https://github.com/jhassan8/crunchyroll-tizen/pull/112 allows for a linux app


Login form validation message is not translatable yet.

Bug report
Title
Login form validation message is not translatable yet.
Issue Description
On the Login screen, if email and/or password are left blank and user press the Login button,
validation messages will be shown under the related textboxes in red color.
For email, 'The Email value is not valid.' For password, 'The Password value is not valid.'
If I set Japanese as the default locale, It will show, 'The "メールアドレス" value is not valid.'
I have been searching for the phrase only to find it in admin.js or shop.js.
Is there a way to translate these messages?
Preconditions
1. framework Version: 0.2.2

Steps to reproduce
1. Change app.php's locale to 'ja'.
2. Go to Customer Login screen
3. Press Login button (leave the email address and password blank)

Expected result
The messages that appear under the email addres and password textboxes should be shown in the Japanese language.

@michael-arif
You need to write the translation for validation too. Please take a look at the following file:
https://github.com/bagisto/bagisto/tree/master/packages/Webkul/Shop/src/Resources/assets/js/lang

@jitendra-webkul
I already added Japanese translation to the /Webkul/Shop/src/Resources/assets/js/lang/locales.js.
It looks like the following:
export const messages = {
    ja: {
        required : (field) => 'フィールド ' + field + ' は必須です。',
        alpha : (field) => field + ' は文字のみを含める必要があります。',
        alpha_num : (field) => field + ' は文字と数字のみを含めることができます。',
        min : (field) => 'フィールド ' + field + ' 少なくとも{length}文字を含める必要があります。',
        ...
    },
    ar: {
        required : (field) => 'حقل' + field + ' مطلوب',
        alpha : (field) => field + ' يجب ان يحتوي على حروف فقط',
        alpha_num : (field) => field + ' قد يحتوي فقط على حروف وارقام',
        min : (field) => 'الحقل ' + field + ' يجب ان يحتوي على {length} حروف على الأقل',
        ...
    }
}

And then, I also modify /Webkul/Shop/src/Resources/assets/js/app.js as follows:
Vue.use(VeeValidate, {
    dictionary: {
        ja: { messages: locales.messages.ja },
        ar: { messages: locales.messages.ar }
    }
});

Maybe I miss something. Please let me know. Thank you.

I think you didn't compile assets.

I did as you suggested:

npm install (in the /bagisto/Webkul/Shop directory
This creates node_modules with lots of subfolders and files 129MB.
npm run watch
This failed.

Then, I found out that /bagisto/packages/Webkul/publishable/assets/js/admin.js contains the above-mentioned non-translatable message (value is not valid.)
If I translated it, the message will be shown correctly in japanese.

Hi @michael-arif
Just take a new pull of bagisto, install npm in shop packages and do the following changes in app.js file of Shop package.
Import validation language file of Japanese language.
import ja from 'vee-validate/dist/locale/ja';
and add it, like -
Vue.use(VeeValidate, {     dictionary: {         ar: ar,         de: de,         **ja: ja**     },     events: 'input|change|blur', });
and it will start working - https://prnt.sc/riewgc
Thanks

I hope above reply solved your issue. I am closing this issue for now. Feel free to reopen this issue if needed.


W365 Business supports ExpressRoute?

For On-premises connection:  Does Windows 365 Business really support all of these?  "Supported by ExpressRoute, VPN, Azure Gateway, and SD-WAN".  I think it is none of them.  Tried to find docs supporting this and could not find any.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f5820d1-1b49-3c41-62c3-c5fd53f87bb5
Version Independent ID: 30fe88af-8d7b-79da-a179-b25b7063e187
Content: Comparing Azure Virtual Desktop and Windows 365 - Azure
Content Source: articles/virtual-desktop/compare-virtual-desktop-windows-365.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Thanks for the feedback! We are currently investigating and will update you shortly.

@miked1313 Can you please share the doc/link you are referring to, for this statement?
'Supported by ExpressRoute, VPN, Azure Gateway, and SD-WAN'

Hi @Karishma-Tiwari-MSFT - Well that's odd, I submitted this feedback using the page on the article/doc which was https://docs.microsoft.com/en-us/azure/virtual-desktop/compare-virtual-desktop-windows-365 and it appears to have been removed?  Was it moved somewhere else?  It was a great article.
Here is a Google cached version.  Thank you.

@Heidilohr Can you please share your insights on this? Thanks :)

You are right. This document has been removed.
I found the following information from this document though:
We do not recommend ExpressRoute for Microsoft 365 because it does not provide the best connectivity model for the service in most circumstances. As such, Microsoft authorization is required to use this connectivity model for Microsoft 365. We review every customer request and authorize ExpressRoute for Microsoft 365 only in the rare scenarios where it is necessary. Please read the ExpressRoute for Microsoft 365 guide for more information and following a comprehensive review of the document with your productivity, network, and security teams, work with your Microsoft account team to submit an exception if needed. Unauthorized subscriptions trying to create route filters for Office 365 will receive an error message.
Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.

Hi @Karishma-Tiwari-MSFT Can the removed document be restored?  It had a lot of useful information in it.


Dismissal animation not working

Hi! I'm trying to implement a custom animation when present a view controller. However, the dismissal doesn't seem to be working. When doing this
let animation = Animation(presentation: ZoomInAnimation(), dismissal: ZoomOutAnimation())
return .present(vc, animation: animation)

the presentation animation works as expected but not the dismissal. I get the default animation.

Hey @francisbourquestudyo!
Since Animations are used as transitioningDelegate in your viewController and therefore are not held strongly by the viewController itself (but only as a weak reference), you will have to make sure to hold it yourself. What we like to do is defining a static let on Animation.
Example:
extension Animation {
    static let zoom = Animation(presentation: ZoomInAnimation(), dismissal: ZoomOutAnimation())
}

then you can write: .present(vc, animation: .zoom).

Thanks! That solved it


[Bug]: JWT authentication not working

Issue description
When adding or altering a node in firefly with JWT authentication on all API endpoints the following error is thrown:
ClientError: Response error with status code 400: {"error":{"code":"400","message":"missing or malformed jwt, error: code=400, message=missing or malformed jwt"}}
Expected behaviour
Add a node with JWT auth and Firefly applies the JWT correctly, allowing to use the node as normal.
Actual behaviour
When adding or altering a node in firefly with JWT the following error is thrown:
ClientError: Response error with status code 400: {"error":{"code":"400","message":"missing or malformed jwt, error: code=400, message=missing or malformed jwt"}}
This only happens when all API endpoints are restricted. In the case that the default API endpoints (requesting messages etc) are authentication free, the node can be added without issues.
-> Firefly does not check the token, but in case it is used on an restricted API endpoint the latter described error occurs
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue

Restrict entire API of node
create JWT
Add node in firefly and with JWT in token field in the form eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c

Diagnostics
ClientError: Response error with status code 400: {"error":{"code":"400","message":"missing or malformed jwt, error: code=400, message=missing or malformed jwt"}}

Errors
Es ist ein Fehler aufgetreten.

ClientError: Response error with status code 400: {"error":{"code":"400","message":"missing or malformed jwt, error: code=400, message=missing or malformed jwt"}}

Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Have you set up your reverse proxy correctly? I had also a misconfiguration with the reverse proxy and had the same issue. You can also ask in the hornet channel on discord.

I think so. It works fine in with the particular node and the python library with the exact same token.

Have you explicitly configured the path /api in the reverse proxy config?

Reverse proxy for the api subdomain:
ServerTokens ProductOnly ServerSignature Off <VirtualHost *:80>     ServerName my.domain     RewriteEngine On     RewriteCond %{HTTPS} !=on     RewriteRule ^/?(.*) https://%{HTTP_HOST}/$1 [L,R,NE] </VirtualHost> <IfModule mod_ssl.c>         # Display only Apache as server signature         ServerTokens Prod         ServerSignature Off         <VirtualHost *:443>                 ServerName my.domain                 ProxyPreserveHost On                 # Setup the proxy                 <Proxy *>                         SetEnvIf Host "^(.*)$" THE_HOST=$1                         RequestHeader setifempty X-Forwarded-Proto https                         RequestHeader setifempty X-Forwarded-Host %{THE_HOST}e                         ProxyAddHeaders Off                         Order deny,allow                         Require all granted                         AllowOverride All                 </Proxy>                 ProxyPassMatch (.*)(\/websocket)$ ws://<IP_ADDRESS>:14265/$1$2                 ProxyPass / http://<IP_ADDRESS>:14265/                 ProxyPassReverse / http://127:0.0.1:14265/                 SSLEngine on                 Include /etc/letsencrypt/options-ssl-apache.conf                 SSLCertificateFile /etc/letsencrypt/live/my.domain/fullchain.pem                 SSLCertificateKeyFile /etc/letsencrypt/live/my.domain/privkey.pem         </VirtualHost> </IfModule>
No, why is that necessary? the api listening on 14265 and i have a subdomain for each, the API on 14265 and the dashboard on 8081. This should work in my mind (as it does when using the library with jwt) or am i missing something?

@MiKeF05 Is the JWT authentication working for you with the current 1.3.3 version? Trying to figure out if it's something to do with the way we're passing the auth stuff to wallet.rs.

@maxwellmattryan Yes I needed to pass the /api path for the node in the reverse proxy configuration. Then it worked for me. There were also some users with the same problem in the hornet channel. But I think it is not related to Firefly.

@MiKeF05 Yeah it doesn't seem to be related to Firefly :thinking:

So you mean that adding an extra proxy for the location like below should resolve the issue?
ProxyPass                  /api/     http://localhost:14265/
ProxyPassReverse    /api/     http://localhost:14265/

Even though this shouldn't change anything?


Clarify $activity->changes doc

I looked into the source and it looks like attributes will always reflect the current status (even immediately following an update) and old will show the previous values (if changes are detected). I think this will clear up some confusion- at least it will clear my own confusion ;)

Yup, good catch!
My apologies for the confusion.


dirtyrepo exception in proSetStageDir()

a dirty repo exception was added to xpPackageDevel() in this commit https://github.com/externpro/externpro/commit/ea6b1c293213a0da72144e81b32244d871d592fc -- so that if CMakePresetsBase.json is the only thing dirty, we don't append a "dirty repo" marker to git describe --tags -- this is because the launchWorkflow.cmake script can modify CMakePresetsBase.json to override binaryDir (see commit message for links to additional details)
this same exception should be added to the macro proSetStageDir() https://github.com/externpro/externpro/blob/24.06/cmake/macpro.cmake#L235-L248 -- which is used by externpro and webpro to set the staging directory and mark the package and installation directory as "dirty" -- this would help these projects move towards being built via CI (github actions) and cmake presets without being marked "dirty"
credit: this was a suggested enhancement from @camerbam

completed with commit to main branch referenced above, tested by building externpro with
./docker-compose.sh
cd ../workspace/externpro
cmake -DbinaryDir="\${sourceParentDir}/_bld-\${sourceDirName}-\${presetName}" -P .devcontainer/cmake/presets/launchWorkflow.cmake

looking at the ../_bld-externpro-Linux/ directory the staging directory doesn't have dirtyrepo marker, and looking at the source directory while externpro is building shows a diff
diff --git a/CMakePresetsBase.json b/CMakePresetsBase.json
index c602c99..ce2bad8 100644
--- a/CMakePresetsBase.json
+++ b/CMakePresetsBase.json
@@ -4,7 +4,7 @@
     {
       "name": "config-base",
       "hidden": true,
-      "binaryDir": "${sourceDir}/_bld-${presetName}",
+      "binaryDir": "${sourceParentDir}/_bld-${sourceDirName}-${presetName}",
       "cacheVariables": {
         "XP_STEP": "build"
       }


[TASK] GetProjectDependencies modifications

Description
So apps will have dependencies that app users may not have access to (engines).
Before a user is able to use the app, in which they don't have access to all engines for use.  We need to give an opportunity for them to swap with their own engines.
For blocks apps you can find the app dependencies on the variables portion of the JSON we have saved.
There is a type property for each variable, that will point to either
"model" | "database" | "vector" | "storage" | "function"
You can ignore all other types.
For the Front end to display an appropriate modal to swap, can we send this as expected return:
{ 	variable-name-model: { 		...high-level-engine-details, 		hasAccess: false, 	}, 	variable-name-database: { 		...high-level-engine-details, 		hasAccess: true, 	}, 	variable-storage: { 		...high-level-engine-details, 		hasAccess: true, 	}, 	variable-vector: { 		...high-level-engine-details, 		hasAccess: false, 	}, }
Existing
GetProjectDependencies()
Reference
This issue references. . .
Tasks
What are more specific tasks that a developer needs to take to consider this issue resolved.

`String portalsFolder = AssetUtility.getProjectPortalsFolder(project.getProjectId());
File blocksJsonFile = new File(portalsFolder+"/"+IProject.BLOCK_FILE_NAME);
if(!blocksJsonFile.exists() && !blocksJsonFile.isFile()) {
throw new IllegalArgumentException("No blocks json file exists for this app");
}
Map<String, Object> blocksJson;
try {
blocksJson = (Map<String, Object>) GsonUtility.readJsonFileToObject(blocksJsonFile, new TypeToken<Map<String, Object>>() {}.getType());
} catch (IOException e) {
classLogger.error(Constants.STACKTRACE, e);
throw new IllegalArgumentException("Unable to read the blocks json file. Error = " + e.getMessage());
}
	Map<String, Object> resultMap = new HashMap<String, Object>();
	Map<String, Object> engineAccessMap = new HashMap<String, Object>();

	if(blocksJson.containsKey("variables") && blocksJson.get("variables") instanceof Map) {

		Map<String, Object> variables = (Map<String, Object>)blocksJson.get("variables");

		for(Map.Entry<String, Object> entry : variables.entrySet()) {
			String key = entry.getKey();
			Object value = entry.getValue();

			if(value instanceof Map) {
				Map<String, Object> variableDetails = (Map<String, Object>) value;
				Object engineType = variableDetails.get("type");
				String engineId = String.valueOf(variableDetails.get("value"));

				if("database".equals(engineType) || "vector".equals(engineType) ||"storage".equals(engineType) ||"function".equals(engineType) || "model".equals(engineType)  ) {

					Object user = this.insight.getUser();
					Boolean canView = SecurityEngineUtils.userCanViewEngine(this.insight.getUser(), engineId);

					engineAccessMap.put(key, canView);
				}
			}

		}

	}`


Web interface

You mention having a web and LCD interface in your readme but we can't find any code for this in the repo.

Team 18

The code for the interface is now uploaded.


invite users group

add the ability to inv users that are in your game to group with out them being added
this would be helpful for people trying to grow there groups.

Wouldn't that just promote spam inviting people?

no cuz rate limited is a thing. but there could be a cool down or something to stop the spam of invites

yes please add this

This can be done already from the user dialog, as for bulk inviting users in your current instance this isn't planned.


Deposit form: No direct link to creating your own community

In the community selection in the deposit form, there is no direct link to creating your own community. This could/should be added in the following context (with a warning of leaving the current form - and saving draft?):

Related to https://github.com/inveniosoftware/invenio-app-rdm/issues/1463


Should DataForAgent be eliminated and become a oneof in ServerToAgent?

AgentToServer message currently has a oneof field that defines that message that is sent to the Server.
The opposite ServerToAgent message contains DataForAgent which includes all possible messages that can be sent to the Server. We could make the situation more symmetric by moving DataForAgent fields under the oneof Body field of ServerToAgent.
The downside is that the Server may send multiple AgentToServer messages if it needs to deliver more than one piece of information that currently is delivered in one DataForAgent message.
This is worth exploring. If we can arrange the messages such we don't make the message exchange less efficient by increase the number of messages exchanged it can make the protocol easer to understand.

I looked into this and eliminating DataForAgent in favour of oneof in ServerToAgent is not desirable. It results in the Server sending the initial set of responses piecemeal, which then in turn results in more roundtrips back and forth between the Agent, particularly for the very first message exchange after the connection.
So, I think what we can do is eliminate DataForAgent and just moves its fields to ServerToAgent as-is, without making them one of. This keeps the semantics and protocol exchange unchanged, and removes unnecessary message.
Also, it appears we can do the opposite process with AgentToServer, which currently uses oneof Body. We can eliminate oneof and put all fields in AgentToServer which allows to include multiple messages in one AgentToServer. This can reduce the number of roundtrips for initial connection and makes it uniform with ServerToAgent.
I am going to start with first eliminating DataForAgent (but without introducing oneof) for now.


Disambigutation Resolvement UNIFI

Hi, could you please edit the entry for UNIFI to state, that it is UNIFI Labs and not UBIQUITI UniFi, which saves confusion for people.
As the name is ambigous and "UNIFI" is more associated with UBIQUITI than UNIFI labs.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: affe9162-f46f-688d-7089-831f48ef10fc
Version Independent ID: 489c3d6a-0add-93d7-fb7e-a9d8cdc00ba7
Content: Tutorial: Azure Active Directory integration with UNIFI
Content Source: articles/active-directory/saas-apps/unifi-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@PhilippZumdohme, could you please raise an update request in our [portal] (https://microsoft.sharepoint.com/teams/apponboarding/Apps/SitePages/apprequest.aspx) for the name change request?

@PhilippZumdohme , What is the status of it, have you raised the issue?
Without an update request, we'll not update the document for the name change.

Resolving the issue.
#please-close


MAINT: Update Future Warning.

With #4967 merged, we can now finally switch the default, as we should have done 2 release ago.
I just want to note that this is one of the reason I prefer not to put future version numbers with promise of removal/change, as those are rarely followed.

hoping we can get this before the 0.4.17 otherwise we would have to update the doc string again. will merge after 24 hours if no objection since the deprecation should have been done in 0.4.15

I just want to note that this is one of the reason I prefer not to put future version numbers with promise of removal/change, as those are rarely followed.

Agreed.
Added to this to the v0.4.17 milestone. This is a change in behavior rather than a deprecation, but we have previously warned about it, so I think it's fine to add for the release. Will merge after 24 hours unless anyone disagrees.


[coex] add an option to control default coex state

For some developing products, we may expect that the coex code is enabled in the build but it's not turned on by default/

add an option in the radio url instead?

add an option in the radio url instead?

After re-thinking on this, I think it would be better to directly have this option since radio url only works for posix platform. We will probably have more rtos based platform. I think adding such option would be more helpful. Thoughts? @bukepo

This feature is designed for products. But the simulation platform is not a product. It is better to add this configuration to the product platform module rather than OpenThread. Thoughts?

Close it first. Need more discussion.


DL: image segmentation and object detection assignment

https://www.kaggle.com/code/ramsegaurav/object-detection-for-begginner-with-tensorflow


Cluster Port issues

Hello,
I setup 3 instances with ports: 7778, 7779, 7780.
Is I start my servers with arkmanager start @all, the ps aux shows the following:
steam    16420 30.2 15.7 7176708 5171672 pts/0 Sl   16:43   1:44 /home/steam/ARK/ShooterGame/Binaries/Linux/ShooterGameServer Ragnarok?RCONEnabled=True?RCONPort=32330?SessionName=Nameless-Gaming - Ragnarok?Port=7777...
steam    16456 26.2 14.9 6907200 4915080 pts/0 Sl   16:43   1:30 /home/steam/ARK/ShooterGame/Binaries/Linux/ShooterGameServer TheIsland?RCONEnabled=True?RCONPort=32331?SessionName=Nameless-Gaming - Island?Port=7778...
steam    16479 20.1 12.3 6993988 4064240 pts/0 Sl   16:43   1:09 /home/steam/ARK/ShooterGame/Binaries/Linux/ShooterGameServer ScorchedEarth_P?RCONEnabled=True?RCONPort=32332?SessionName=Nameless-Gaming - Scorched Earth?Port=7779...

if I configure the ports: 7777, 7778, 7779
its using 7776, 7777, 7778,
why is it always decrementing my ports? I had really strange problems with server not showing
my configs looks all like this (with+1 port)
# config environment
arkserverroot="/home/steam/ARK"                                     # path of your ARK server files (default ~/ARK)

serverMap="Ragnarok"                                               # server map (default TheIsland)

ark_RCONEnabled="True"                                              # Enable RCON Protocol
ark_RCONPort="32330"                                                # RCON Port
ark_SessionName="Nameless-Gaming - Ragnarok"                                  # if your session name needs special characters please use the .ini instead
ark_Port="7777"                                                     # ARK server port (default 7778)
ark_QueryPort="27015"                                               # ARK query port (default 27015)

ark_AltSaveDirectoryName="SavedArks"                                    # Uncomment to specify a different save directory name

arkautorestartfile=ShooterGame/Saved/.autostart-ragnarok
arkflag_NoTransferFromFiltering=true
arkopt_clusterid=ng1337

The game port (the port the game listens on) is always 1 greater than the Port parameter passed to the ARK server.  The port number specified in the arkmanager config is the port you want the server to listen on.

So I should use +2 on every port?

Specifying Port=7777 in the arkmanager config will pass Port=7776 to the ARK server, which will cause it to listen to port 7777.

I had
cfg1:
ark_Port="7778"
cfg2:
ark_Port="7779"
cfg3:
ark_Port="7780"
and only 2 of my 3 instanced showed in the server browser. Thats why I started investigating

Not showing up in the server browser usually means that either the server hasn't advertised itself to the Steam Master server, or the server isn't answering on its QueryPort.
Do all of the servers show up properly when you use arkmanager status @all?

yes they did and https://arkservers.net/server/ did too but steam server list and ark didnt show the server. If I started connecting via steam parameter, ark found the server but displayed errors like: couldnt query server or something like this. (and every instance had different ports). I changed it to 7777, 7778, 7779 and now its working (I cant figure out why)


Merged Main + Jen's branch + Viet's branch

Description

Types of changes

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

reviewed the sonarcloud bugs, not a bug.


enabled shrinkResources removes every layer from map

Summary:
if the user sets shrinkResources to true in buildTypes from build.gradle the layers on the map are not appearing
Steps to reproduce:
add the line shrinkResources into your buildTypes from build.gradle
Expected behavior:
this line should not impact the layers from the map
Observed behavior:
the layers from the map are not appearing anymore
Device and Android version:
Device OS: Android
Device OS version: 8.0.0
App Version: 1.0.1
Device Brand: HUAWEI
Device Model: VTR-L29
Device Manufacturer: HUAWEI
*this issue happens also for android.enableR8 = true in gradle.properties

Yes, it's still valid. Thank you also.

@zboing I can't reproduce this with the debug build type in the demo app packaged with the library (with master branch at https://github.com/googlemaps/android-maps-utils/commit/122e96b8400af4c2f26f9c6237e3b4394b2a1d6a):
https://github.com/CUTR-at-USF/android-maps-utils/tree/test-shrink-resources
I added:
    buildTypes {
        debug {
            shrinkResources true
            minifyEnabled true
        }

I tested with and without android.enableR8 = true in gradle.properties, but when you go to the "Multi Layer" demo and "Clustering: Custom Look" activities all the layers appear on the map as expected.
Could you provide an example app with steps to reproduce this issue (preferably based on the demo app)?


Include more EventSource detail

MOved from #7413 by @ArjayHawco
Note: this request is similar to the request for updating the EventLog documentation here.
In short:

Details around configuring EventSource.  The only method to add logging is logging.AddEventSourceLogger() which takes no parameters.  As such there is no apparent way to specify the source and log name of the event source provider.  Etw entries appear in the event viewer under "Applications and Services Logs" and can be many levels deep (e.g. Company/Area/Component).
Details around defining an eventsource derived class (or equivalent) that allows the dev to specify the source and event attributes.
Details about embedding event resource strings in the app
Details about generating .etwManifest.??? related artifacts in the build.
Details about registering the .etwManifest.??? artifacts with the etw system.

In .Net 4.5.x, the following blogs were very helpful in getting the EventSource setup and configured. https://blogs.msdn.microsoft.com/dotnet/2013/08/09/announcing-the-eventsource-nuget-package-write-to-the-windows-event-log/
https://blogs.msdn.microsoft.com/vancem/2013/08/10/the-eventsource-nuget-package-and-support-for-the-windows-event-log-channel-support/
https://msdn.microsoft.com/en-us/library/system.diagnostics.tracing.eventsource.aspx?f=255&MSPPError=-2147217396
Of course, these are outdated but the EventSource functionality was implemented by these nuget packages:
Microsoft.Diagnostics.Tracing.EventRegister
Microsoft.Diagnostics.Tracing.EventSource
Microsoft.Diagnostics.Tracing.EventSource.Redist
It would be great to have a similar set of documentation/nuget packages for .Net Core 2.x.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7184a308-a254-9350-a5cd-5bced1f369ae
Version Independent ID: 726e3bf1-f367-d733-8933-bccc04da0e16
Content: Logging in ASP.NET Core
Content Source: aspnetcore/fundamentals/logging/index.md
Product: aspnet-core
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Dup of #7384


Suggest removing Chi Square corrected P value

This issue is to suggest that we remove chi_squared_p_corrected from ICEES output. The correction is set to 1, meaning no correction is applied, so the chi_squared_p_corrected always equals chi_squared_p. I don't think a correction is helpful anyway, as ICEES is intended to support exploratory analysis. Moreover, if we applied a Bonferroni correction, for example, to certain endpoints like the "Association to All Features" endpoint would overcorrect, leaving most/all associations as not significant.
For example, this query:
curl -X 'POST' \
  'https://icees-pcd.renci.org/patient/cohort/COHORT%3A1/associations_to_all_features' \
  -H 'accept: text/tabular' \
  -H 'Content-Type: application/json' \
  -d '{
  "feature": {
    "TotalEDInpatientVisits": {
      "operator": "=",
      "value": "0"
    }
  },
  "maximum_p_value": 1,
  "correction": {
    "method": "bonferroni"
  }
}'

Yields associations such as:

I'll add that the Bonferroni correction available at the "Association to All Features" and "Association to All Features2" endpoints behaves as a filter, not an actual correction. This issue and the above one are known, and I believe there may be an open ticket, but we probably should resolve the issues.
For example, this query:

curl -X 'POST' \
  'https://icees-pcd.renci.org/patient/cohort/COHORT%3A6/associations_to_all_features' \
  -H 'accept: text/tabular' \
  -H 'Content-Type: application/json' \
  -d '{
  "feature": {
    "TotalEDInpatientVisits": {
      "operator": "=",
      "value": "Female"
    }
  },
  "maximum_p_value": 0.5,
  "correction": {
    "method": "bonferroni"
  }
}

Yields only associations with P values <0.5, but chi_squared_p_corrected equals chi_squared_p in the output, for example:

I took a look at the code and it only apply Bonferroni correction if it is specified in the request. So if no correction is desired, the correction method just needs to be removed from the request. I think that should work or I have missed something?

I don't think the Bonferroni correction is being applied correctly. In the example I posted above, the uncorrected and corrected Chi Square P values are the same, even though a correction is in the request. I think the code is applying the correction as a filter, not a correction per se.

@karafecho I looked into the code and believe the main issue with applying the Bonferroni correction is the default alpha or significance level input. This alpha value is set to the default 1 if not specified in input, which leads to what you are seeing here since alpha input is not specified. It seems to be common practice to set alpha input to 0.05, so perhaps we should update code to set the default value to be 0.05 rather than the current 1 so corrected values make more sense?

Okay, so in the query below, max_p_value simply acts as a filter for what associations are returned, and correction is set to 1 as default. As I now recall, Hao and I were planning to let the user set the correction (and also choose the type of correction). Is that possible, sticking with Bonferroni only for now? (I think the code supports multiple correction factors, but I don't think we necessarily need to support all of them.)
curl -X 'POST' \
  'https://icees-pcd.renci.org/patient/cohort/COHORT%3A4/associations_to_all_features' \
  -H 'accept: text/tabular' \
  -H 'Content-Type: application/json' \
  -d '{
  "feature": {
    "Sex2": {
      "operator": "=",
      "value": "Female"
    }
  },
  "maximum_p_value": 0.05,
  "correction": {
    "method": "bonferroni"
  }
}'

Yes, it supports multiple correction method. It uses multpletests() from statsmodels library as shown here and it supports the following methods:
bonferroni : one-step correction

sidak : one-step correction

holm-sidak : step down method using Sidak adjustments

holm : step-down method using Bonferroni adjustments

simes-hochberg : step-up method (independent)

hommel : closed method based on Simes tests (non-negative)

fdr_bh : Benjamini/Hochberg (non-negative)

fdr_by : Benjamini/Yekutieli (negative)

fdr_tsbh : two stage fdr correction (non-negative)

fdr_tsbky : two stage fdr correction (non-negative)

You can update your query above to replace "correction" with the following:
"correction": {
    "method": "bonferroni",
    "alpha": 0.05
  }

which I think should return results that make much more sense.

Well, I changed correction as suggested ran the query with and without maximum_p_value, but no luck: chi_squared_p and chi_squared_p_corrected are the same.

@karafecho You are correct. I looked into code in multitest() in statsmodels library and found the p-value correction using bonferroni method is not affected by alpha input, which is also verified by the comment in the multitest() code: Except for 'fdr_twostage', the p-value correction is independent of the alpha specified as argument. So my previous comment about alpha input is wrong. In looking into the code, I believe the reason we get corrected p-value being the same as input p-value is that we only pass in one p-value indicating it is only one test, and the p-value correction is only computed for multiple tests. If we only has one p-value, it looks like there is no point in correcting p-value.

Oh, that makes total sense, although I'm not sure why we would bother supporting any corrections if we only pass in one p-value indicating one association test. As you note, then there's really nothing to correct. Seems weird, but anyway, it sounds like my original suggestion is the best solution for now, which is to simply remove correction. I'm guessing that you can just update the API example, so that it's not misleading.

@karafecho Sounds good. Will do.

I checked the PCD endpoint and confirmed that the Bonferroni correction has been removed. As such, I'm closing this ticket.


Feature Request - Discord Bot pterodactyl egg

I think it'd be quite useful to have a pterodactyl egg for the bot if we have to run FoundryVTT in pterodactyl!

Makes sense. I will see when I have the time to do that.

Was a bit more difficult than I thought, since I couldn't just use the existing docker container, but I think I got it now.
As soon as the pipeline succeeds, you should be able to install the bot via the egg in pterodactyl_eggs/foundry_world_switcher. Let me know if you have any issues.
Also, be prepared to wait a long time for the server installation. Building the executable took about 10 minutes on my server.


ColiseuPlayer: Singleton

@ricardopereira does this involve dispatch_async?

Yes for different queues but it's a premature optimisation :grin:
Not necessary for now.

@ricardopereira for singleton, should I add static shared instance and make init as private?

@SentulAsia Yes, static shared and the init as @unavailable.

Well, now that I'm thinking about it, maybe we don't need a singleton and we can assume the latest ColiseuPlayer instance will always take control of the audio.
@SentulAsia  What your thoughts about this?

As discussed in #26 :
@ricardopereira static shared is another way to solve this problem...
Multiple audio instance fighting to play audio on the same speaker would be troublesome...
My previous app have a playlist audio which is consistently playing, then when some button is tapped, there is an effect sound (a short 1 sec sound)...
It turns out we need to have only 1 instance of audio object or else, the latest object will get to play audio, while the older instance object will stay in silence...


Support imported files in thrift-gen

This PR adds support for imported thrift files during the code generation phase.

Coverage decreased (-0.09%) to 94.574% when pulling 1278d84001a7e939e0294ae9fe2435de11c3eaa1 on fix/thrift-gen-import into 35a2589c17111d8eedf004db0b02a8327ec95bd0 on dev.

Coverage increased (+0.07%) to 94.738% when pulling 221f384edada56e3302322b9a2d7b879747bbfae on fix/thrift-gen-import into 35a2589c17111d8eedf004db0b02a8327ec95bd0 on dev.

Coverage decreased (-0.02%) to 94.645% when pulling 221f384edada56e3302322b9a2d7b879747bbfae on fix/thrift-gen-import into 35a2589c17111d8eedf004db0b02a8327ec95bd0 on dev.

I'm fine with changing the name to an uuid although it implies more changes.
Feel free to change it or keep it like this (LGTM)

Coverage decreased (-0.09%) to 94.574% when pulling f92ab49cc2f05bee18692061b9ba23accc33e7da on fix/thrift-gen-import into 35a2589c17111d8eedf004db0b02a8327ec95bd0 on dev.

🎉

The failure is a flap:
--- FAIL: TestProtocolStats (5.09s)
	Error Trace:	stats_test.go:89
	Error:		Should not be zero, but was 0

	Error Trace:	stats_test.go:90
	Error:		Should not be zero, but was 0

--- FAIL: TestStatsTestSuite (5.21s)
FAIL
FAIL	github.com/uber/ringpop-go/swim	9.984s

Nothing changed that would impact a failure in swim with this change. Re-running test.

Looks good


Multiple errors running scripts/run.all.sh

I have followed your instructions up to 'bash scripts/run.all.sh' but am getting multiple errors at this point.
Looks like a combination of:

machamp errors (extra parameters passed to MachampPretrainedTransformerMismatchedEmbedder),
broken links to model checkpoints (can't load config for '/data/job-postings/SpanBERT/checkpoint/')
missing data that should be in 'data/Skills/' (e.g. corpus_house_large_doc_split.conll)

stdout and stderr are attached.
err.txt
out.txt
Other notes:

I'm using the same version of allennlp as in the requirements.txt (1.3).
It looks like the de-identified data files hosted on Google Drive were given the affix 'skillspan_', but the code appears to call the same files with the affix 'corpus_'. I made this adjustment in my code.

Hi Tom,
Thanks for your message:

I'm not sure about the machamp related errors but perhaps these errors come from the broken links?
For the broken links, in configs\ could you change in the file for whatever model you want to use .e.g., spanbert.*.json the link to the huggingface model? Since I uploaded our pre-trained spanbert model as well, this should be jjzha/spanbert-base-cased.

Let me know if this resolves the issues. I will edit the links in the near future.
Thanks!

Hi Tom,
I have made two modifications:

I now added the new config files for the models. The change you made with the prefix "skillspan_" is correct.
I have a new version of the .conll files, because they were incorrectly formatted.

Hi Mike,
Thanks for doing that!
The config files for jobspanbert have the directory as "jjzha/jobspanbert-base-cased/", but this should be "jjzha/jobspanbert-base-cased" (without the final forward slash) or the model .config can't be found.
Unfortunately the allennlp.common.checks.ConfigurationError still occurs with the updated model addresses:
allennlp.common.checks.ConfigurationError: Extra parameters passed to MachampPretrainedTransformerMismatchedEmbedder: {'last_layer_only': True}
Removing this parameter from the .config file introduces a new error:
File "/home/acp19tag/SkillSpan/machamp/machamp/modules/pretrained_transformer_embedder.py", line 81, in __init__     if len(layers_to_use) > 1 or layers_to_use != [-1]: TypeError: object of type 'NoneType' has no len()
Additionally, there is still a missing data file:
FileNotFoundError: [Errno 2] No such file or directory: 'data/Skills/corpus_house_large_doc_split.conll'
stdout and stderr files are attached for reference.
err.txt
out.txt
Thanks so much for your time!

Regarding the MachampPretrainedTransformerMismatchedEmbedder - is it possible that the allennlp model has been updated since this project ran?

Hi Tom, the corpus_house_large_doc_split.conll were our Longformer experiments, for which I don't know where the files are now. Regardless, the results of the Longformer weren't that adequate. Hence, I now removed it from the repository.
I'm not seeing that the directory for the config files has a slash  for jobspanbert. Did you pull the new version? From my side I got it running again:
2022-07-08 04:19:15,193 - INFO - allennlp.training.trainer - Epoch 0/19 2022-07-08 04:19:15,193 - INFO - allennlp.training.trainer - Worker 0 memory usage: 3.5G 2022-07-08 04:19:15,194 - INFO - allennlp.training.trainer - GPU 0 memory usage: 414M 2022-07-08 04:19:15,194 - INFO - allennlp.training.trainer - Training   0%|          | 0/151 [00:00<?, ?it/s] .run/Skills/span_f1: 0.0063, .run/.sum: 0.0063, batch_loss: 1939.6017, loss: 1273.7016 ||:   7%|7         | 11/151 [00:02<00:28,  4.92it/s]
I achieved this by installing the requirements.txt from machamp.
Let me know if you manage!

Thank you! This works for most of the models.
I'm still getting the error message when training bert and jobbert:
allennlp.common.checks.ConfigurationError: Extra parameters passed to MachampPretrainedTransformerMismatchedEmbedder: {'last_layer_only': True}
Additionally, there doesn't appear to be a machamp/logs/ directory, which means I can't run the scripts/run.predict.sh on any of the models.
As well, training spanbert didn't create a data/spanbert/ directory, so I can't run scripts/run.evaluate.sh spanbert.
Any ideas on how to fix?

For your first two errors, for some reason, my edits to the config files didn't save and for now, it should work for all.
I edit the path of machamp/logs to just logs as it will create it in your root project directory.
For your last issue, I believe the path for data/*/ should be logs/*/, I changed it in scripts/run.evaluate.sh *, let me know if it works!

Fantastic, thanks so much!


feat: episode 8 with orta

My intention is to ship this later today.
I cut out a little bit of banter at the end to try to get closer to my totally-made-up 35 minute limit. I recall struggling to end the interview because I didn't want to hang up, and @jonallured swooping in to save the day, so I cut out anything between the last important thing Orta said & Jon wrapping it up like a professional.

sorry, I reviewed on my phone but it wasn't logged into GH after the big session wipe - all cool here


Add documentation

Codecov Report

Merging #17 (4496c4a) into main (0fce812) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 4496c4a differs from pull request most recent head d34648a. Consider uploading reports for the commit d34648a to get more accurate results

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   92.37%   92.37%
=======================================
  Files          17       17
  Lines        1496     1496
=======================================
  Hits         1382     1382
  Misses        114      114

Flag
Coverage Δ

unittests
92.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

gpax/gp.py
89.04% <ø> (ø)

gpax/kernels.py
94.00% <ø> (ø)

gpax/vidkl.py
92.19% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Welcome page optimization & tweaks

Image optimization
Images are preloaded on /auth now. For users who auth but do not yet have an account (and are sent to welcome page), this means that images are already loaded and jankiness is prevented.
The videos below shows onboarding flows for users with "Good 3G" connection before and after preloading:
https://user-images.githubusercontent.com/13339581/149637045-479610c3-24e5-4bcf-aa22-c96221a05e3e.mov
https://user-images.githubusercontent.com/13339581/149637062-302e16d8-9461-4edb-b8e6-3cdbdea3cf6e.mov
The loading of each screen is slow regardless (~11 sec), but when preloading the images are fully loaded as soon as /welcome loads, and they do not blink/flicker in
Note: This does mean that we're loading images for any user who visits /auth, but I don't think this is an issue; the sum of all files is ~1200kb and I don't think (?) loading these images in useEffect blocks render
Vertical screen optimization
Images now have different x and y positions on vertical screens (screens with a width/height aspect ratio of < 1).
Before and after:

This is also true on super-tall screens/for users who have zoomed out their display:

(Minor but related, we also removed scrollbars on welcome by adding overflow: hidden)
Bonus interactivity
Tbh we can do with or without this change, but I added a lil rotation on hover effect to each individual image. (This meant creating an <Image /> component for each etc)
It looks like this:
https://user-images.githubusercontent.com/13339581/149637468-e2194772-ea7e-4554-9063-d17cb1922572.mov
I will not be offended if we do not include this lol, was just playing around to learn React and now it exists.
Feel free to review this a bit more critically because this is my first time ever using React

@Robinnnnn No rush on reviewing this as its the weekend and (like you said) these aren't time-sensitive changes
also not sure why Vercel is failing to deploy... i thought it worked last time but now I get a 404 when I visit the preview information page 🤔

@connorrothschild  not sure why you get a 404 for the Vercel deployment page but here's the error I see:

Thanks @kaitoo1! Weird I didn't see those type errors in development. Deploy is fixed now, appreciate it!

LGTM @connorrothschild !
One small thing, any way we can make the Bonus Interactivity a bit more subtle?
Love the animation but the rotation feels a bit jarring and exaggerated to me - curious to see how it would look if we reduced the amount it tilted by maybe half.

And thanks for adding such a detailed description - it made this PR a breeze to review.

Good call @kaitoo1 - I agree!
I applied a ceiling of 5deg so that rotation will never exceed that (see here). Now it looks like this:
https://user-images.githubusercontent.com/13339581/150567479-82bdc54c-0118-4dd5-a8dd-d5bd890e3c8c.mov
A lot more subtle, and we can reduce it more if you see fit.

looks great!! thanks for updating 🙏
MERGE ITTTTTTT


Few shot MultiArith is missing

Few shot run_multiarith.py is missing. Can you please share what are the few shot examples you have used for multiArith.

Hi, I have added multiarith data to the data/ folder. I remember using the first few examples in multiArith training set to obtain the reported results.


WASD=player 1 movement IJKL= player 2 movement

Code
Check off the items that are true.

[ x] The game was made using the Sprig editor.
[ x] The game is placed in the in the /games directory.
[ x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[ x] The game runs without errors.
[x ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[ x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Want to see this merged:) you just need to choose a name for the game

what issues do i have

Just change the name:) Files changed > ... > edit

is that what i needed to change?

is that what i needed to change?

Yep! If I can ask, What made you not answer for so long? just to improve our work:)

I was out for summer break and forgot about it for a bit


Unrecognized magic command for #!share

Describe the bug
#!share is unrecognized when executing cell.
Repro Steps:
Install latest interactive vsix (insiders) on vscode with .NET 6 (etc).
Download this repro and open its folder and the NotebookTestScript in VSCode.
Execute the following cells with the titles "Execute the next two cells" and "Execute the next cell. After execution, the outpute immediately above this should read:"
Expected: All 3 cells should display the appropriate results as described in the test script.
Actual: The 3rd cell fails with the following errors
Error: Unrecognized command or argument '#!share'.
Unrecognized command or argument '--from'.
Unrecognized command or argument 'csharp'.
Unrecognized command or argument 'x'.
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):

OS

Windows 10

Browser

Edge

Frontend

Jupyter Notebook
Visual Studio Code Insiders

Screenshots
If applicable, add screenshots to help explain your problem.

When "#!share --from csharp x " is executed in the last cell from the notebook test script, it works fine so I don't know why it is failing in the above cell.

it is added to the jskernel proxy at this line


Fix GraphiQL v0.9.3

When working on https://github.com/postgraphql/postgraphql/pull/409 I noticed that our GraphiQL hacks to get live schema reloads working were causing errors in GraphiQL version 0.9.3. So this PR fixes the changes and re-pins the GraphiQL version to 0.9.3.

#407 and #410 are both failing on CI in Node 4 for the same reason:
 FAIL  src/postgraphql/http/__tests__/createPostGraphQLHttpRequestHandler-test.js
  ● Test suite failed to run
    SyntaxError: Unexpected token {

      at transformAndBuildScript (node_modules/jest/node_modules/jest-cli/node_modules/jest-runtime/build/transform.js:320:12)
      at Object.<anonymous> (node_modules/koa/lib/application.js:11:18)
      at Object.<anonymous> (src/postgraphql/http/__tests__/createPostGraphQLHttpRequestHandler-test.js:13:11)

Yeah, I think Koa recently published a release that breaks Node.js 4 (which would be why we haven’t seen it before). master has the fix so I updated the branch 👍

Released in 3.1.0 🎉


Enable Swan

Need to use the usable flag for registration process as well
This flag should be properly backed up and used after restore
Both UI restrictions should be with the flag

I've written the swan account enablement code where Ali sir mentioned it.
The UI restriction using isUsable flag is what's left

Tested by @antuz123


🚸⚡ Improve Y-sync accuracy using clientRectangles

Resolves #55
Part of #29

This would really improves quality of Y-sync, almost perfect.


fix(bsppp): add algorithm to fix missing sort

src/bsppp/bsppp.cpp is missing an #include <algorithm>
Compiling vpkedit head results in this error without it:
/home/hurricane/aur/vpkedit-git/src/vpkedit-git/src/shared/thirdparty/sourcepp/src/bsppp/bsppp.cpp:178:8: error: no member named 'sort' in namespace 'std'
  178 |                 std::sort(lumpIDs.begin(), lumpIDs.end(), [this](int lhs, int rhs) {
      |                 ~~~~~^
1 error generated.

It's always algorithm


profile page stop to save change

Describe the bug
change personnal info in profile stop to work
To Reproduce
Steps to reproduce the behavior:

Go to 'profile page and edit'
Click on 'Save'
and nothing change page and come back and you info haven't change

Desktop (please complete the following information):

OS: ubuntu 20.04 lts
Browser Chromium
Version  86.0.4240.111

wrong var in sql query on user_id change by session $_SESSION[user_id]


organize viz tool icons

maybe the simple thing for phase 1 would just be alphabetical? not super useful though..
id imagine the ideal is to organize them by whether they support a single var (excluding strata), two, or more etc.

Would we have headings for the different categories you describe?


CAMEL-20193: camel-openapi-java - add to support OpenAPI 3.1 ModelCon…

…verter
Description

Target

[ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test camel-openapi-java


Add nuget.exe to outputs of _RestoreBuildTools

I had a situation where I wanted to make sure I had the latest nuget.exe,
so I deleted it, assuming that this target would re-download it.  It
didn't, because the only listed output of the target (the
I-downloaded-stuff semaphore) was up to date relative to the inputs.
Adding the .exe as an output resolves this.
Really, we should probablys split this target into two (download nuget.exe
and restore tools) for finer-grained incrementality, but this is quicker
(we should also resolve the race conditions here by moving these tasks to
a separate project so that there's no race created by doing the restore in
all projects).

LGTM

LGTM


HDDS-4421. Fix throwing INTERNAL_ERROR out of LOG.isDebugEnabled() check in OzoneClientProducer.

What changes were proposed in this pull request?
Internal_Error need to be thrown outside of LOG.isDebugEnabled()  check.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4421
How was this patch tested?
Existing tests.

Thank You @ayushtkn for the review.