CC0021:Use nameof on ActionNameAttribute

On code like this:
public ActionResult Create()
{
    return this.View();
}

/// <remarks>POST: /Holidays/Create</remarks>
[HttpPost]
[ActionName("Create")]
[ValidateInput(false)]
[SuppressMessage("Design", "CC0021:Use nameof", Justification = "MVC action name.")]
public async Task<ActionResult> CreateAsync(HolidayViewModel viewModel)
{
    ...
}

It's indidental that there's a method with that name. This attribute is used , mostly, when the convention is not used.
Should this be a hidden diagnostic with a fix?

@paulomorgado I am not sure we should make it hidden, because it is very important to point out string uses of names. But I do agree this is incidental. But not on your case, actually, you want both actions to have the same name, so "Create" actually really refers to the other method name.
Today this is a Warning. Maybe bring it down to an Info?
I have been bit but this same problem. What I have done is, sometimes, change the variable name a little bit, or suppress. I usually use #pragma, though.

I'm really not sure what I think should be done. I wonder if someone else has an opinion.

Seems like info is more appropriate.  Warning to me means something could potentially be broken and this is more of a "proper way to do it " rule.
Is there an equivalent rule for the member referenced by the string not existing in the scope?  I guess that would be an error instead of a warning, though.

@code-cracker/owners What do you think? I also vote for changing it to Info.

For me, it is logical to keep the action name and the name of the same method. In this case.

The same issue is with JSON.NET attributes:

The JSON property names should not be linked to the c# field names. Serialization output should not be affected by renaming a field.


Removes jQuery from nav-primary.

Prep for global search to share JS with nav.
Additions

dom-traverse.js for dom querying not covered by native dom.

Changes

removes jquery from primary nav JS and replaces with native querying.

Testing

Resize site to mobile size and navigate primary menu. Should work as before.

Review

@KimberlyMunoz
@sebworks

FYI I have to fix tests before review.

:+1:

Ready for sign off again!

:+1: Thanks


Initialize MachinePool conditions

As per kube api guidelines, conditions should be placed by the controller as soon as possible, to indicate that it has began processing the resource. If a decision cannot be made regarding the status of the condition at that time, it can be set to Unknown.
This PR initializes MachinePool conditions, and ensures conditions do not have to be "True" to be set for the first time.
xref: https://issues.redhat.com/browse/HIVE-1562
/assign @abutcher
/cc @akhil-rane

/lgtm


rdbreak/rhel8node' could not be found

The box 'rdbreak/rhel8node' could not be found or
could not be accessed in the remote catalog. If this is a private
box on HashiCorp's Vagrant Cloud, please verify you're logged in via
vagrant login. Also, please double-check the name. The expanded
URL and error message are shown below:
URL: ["https://vagrantcloud.com/rdbreak/rhel8node"]
Error: schannel: next InitializeSecurityContext failed: Unknown error (0x80092012) - The revocation function was unable to check revocation for the certificate.

@dhongadeap
I'm facing the same issue :(
did you find any solution for that?
Thank you in advance.

Has there been any fix to this issue? I am experiencing exactly same problem.
If any suggestions please...thanks


fix: table not filling space on larger window sizes

We add extra padding to the last column, which is not wanted. This pr should address that so we fill the space properly.
This only affects the table when the window is larger than the content.

love that, works great for me except for a split second before the content is loaded where the columns are squished together

not super critical

Thanks for testing it, didn't notice that, I guess that means on the first call, it's returning 0 as extra padding, will fix!

this should now be correct and fill out the window to the edge, I could not replicate the error I see in your gif though, could try again? I'll merge this for now and if you get the same behaviour we can create a new PR

Yeah that's a different padding that I'm getting an error removing but the extra padding (that is supposed to fill out the screen should be gone), the extra space you see should have been removed by the scrolloff though, are you on latest?

This is how it's looking for me, if you ignore the 3 extra characters:

This is how it's looking for me, if you ignore the 3 extra characters:

I do only have 3 extra spaces, less then before.

Nice! We can probably get rid of those other 3 soon, it threw an error with the extmarks and those are a pain

Managed to remove the extra 3 now as well!


It would be better to make the error info helpful if the restored tabs contain Azure AD attached tab whose associated account has been removed

Storage Explorer Version: 1.25.0
Build Number: 20220808.4
Branch: hotfix/1.25.1
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Monterey 12.5 (Apple M1 Pro)
Architecture: ia32/x64
How Found: Ad-hoc testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Select one blob container -> Azure AD attach the blob container.
The Azure AD attached blob container auto opens.
Remove the user account -> Restart Storage Explorer (make sure the setting "Preserve Explorer Session" is enabled).
An error info bar prompts after restarting the Storage Explorer.
Check whether the error info is helpful.

Expected Experience
It would be better to make the error info helpful.
Actual Experience
The error info is unhelpful.

Error info:
Cannot read properties of undefined (reading 'id')

Verified this issue on the main build 20220815.1.

This issue has been fixed for blob containers/tables.
This issue also reproduces for queues.

Verified this issue on the main build 20220816.1. Fixed. So, we are going to close it.


Hide the 'thank you' box on new credits page when manual credits present

retest this please

retest this please

retest this please


SPFX OnPremise Illegal Rule Inserted

When I deploy my SPFX web part OnPremise my console is flooded full of
sp-classic-page-assembly_en-us.js?version=1:385 whoops, illegal rule inserted @-o-keyframes animation_tply6e{from{-webkit-transform:rotateZ(0deg);transform:rotateZ(0deg);}to{-webkit-transform:rotateZ(-90deg);transform:rotateZ(-90deg);}}
and a big huge message WARNING
Use of this tool exposes you to potential security threats which can result in others gaining access to your personal Office 365 data (documents, emails, conversations and more). Make sure you trust the person or organization that asked you to access this tool before proceeding.
Is there a way to remove this? I'm getting this even when I deploy to Production and the other developers are thinking it is something with my code as well as our cyber security is freaking out.

There's no way to remove these. The warning is aligned for example on what Facebook and others do to ensure that inexperienced end users would not follow random messages from the Internet.


Tests/alexrb/csl717 toss

@gromakovsky Agreed. I'll fix the style and cosmetic issues right now.

@gromakovsky CI shouldn't have any problems with this, so you can merge when possible.

https://issues.serokell.io/issue/CSL-1208


[1589] fix readme

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.88%. Comparing base (76492e8) to head (d2ecb0b).

:exclamation:  There is a different number of reports uploaded between BASE (76492e8) and HEAD (d2ecb0b). Click for more details.
HEAD has 522 uploads less than BASE

Flag
BASE (76492e8)
HEAD (d2ecb0b)

macOS
24
0

unit
68
2

go-1.23.x
88
1

go-1.22.x
61
1

ubuntu
107
2

integration
71
0

ydb-24.1
23
0

ydb-24.3
18
0

ydb-nightly
10
0

experiment
10
0

windows
18
0

ydb-24.2
30
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1590       +/-   ##
===========================================
- Coverage   71.33%   40.88%   -30.46%
===========================================
  Files         372      371        -1
  Lines       38253    38117      -136
===========================================
- Hits        27289    15584    -11705
- Misses       9852    22011    +12159
+ Partials     1112      522      -590

Flag
Coverage Δ

experiment
?

go-1.22.x
40.87% <ø> (-27.17%)
:arrow_down:

go-1.23.x
40.84% <ø> (-30.47%)
:arrow_down:

integration
?

macOS
?

ubuntu
40.88% <ø> (-30.46%)
:arrow_down:

unit
40.88% <ø> (-0.04%)
:arrow_down:

windows
?

ydb-24.1
?

ydb-24.2
?

ydb-24.3
?

ydb-nightly
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


canbus: isotp: fix single frame state machine stuck issue

it is too late to set ctx->state to ISOTP_TX_WAIT_FIN after send_sf because send_state_machine could be called just between send_sf and ctx->state = ISOTP_TX_WAIT_FIN;  in extremely case. like below:
 		ret = send_sf(ctx);
		-> irq_handler
		ctx->state = ISOTP_TX_WAIT_FIN;

it will cause isotp_send never return.

A bug is created.
The force push to fix commit message format, sorry for the inconvenience.

No worries. Sorry for the bug 😅


SPI2 DMA configuration isses STM32WB55

Describe the bug
In our project we are using DMA2 to handle SPI2 transfers. With following configuration transmission works:
&spi2 {
    dmas = <&dmamux1 10 9 0x00440
            &dmamux1 11 8 0x00480>;
    dma-names = "tx", "rx";
};

but when we want to use dma2 notation, transmission does not work properly:
&spi2 {
  dmas = <&dma2 4 9 0x00440
          &dma2 5 8 0x00480>;
    dma-names = "tx", "rx";
};

To Reproduce
Set SPI dmas configuration to dma2 channel using dma notation.
Expected behavior
Possibility to setup SPI on DMA2 with dma notation in dts files.
Environment (please complete the following information):
OS: Linux
Toolchain Zephyr SDK
Commit SHA or Version used: 3.3.99

Because the stm32wb has a DMAMUX in front of DMA1 and DMA2, you cannot access the DMA directly.
but through DMAMUX channels:

DMAMUX channels 0 to 6 are connected to DMA1 channels 1 to 7
DMAMUX channels 7 to 13 are connected to DMA2 channels 1 to 7
--> DMA1, DMA2, DMAMUX have all 	{ status = "okay"; }

With the dts
&spi2 {
    dmas = <&dmamux1 10 9 0x00440
            &dmamux1 11 8 0x00480>;
    dma-names = "tx", "rx";
};

channels 10 and 11 are on the DMA2

Thank you for reply, but I am little bit confused. In other thread there was suggestion to use access by &dma1 and &dma2:
https://github.com/zephyrproject-rtos/zephyr/issues/55754#issuecomment-1468128986. So I assumed that this approach is valid for all drivers.

Thank you for the clarification. In this case issue could be closed.


Changed CI_ENV to CI_ENVIRONMENT

Add #532

ENVIRONMENT too?
I don't know CI prefix is CodeIgniter or continuous integration.
.//application/Config/Database.php:39:		'DBDebug'     => (ENVIRONMENT !== 'production'),
.//application/Config/Database.php:66:		'DBDebug'     => (ENVIRONMENT !== 'production'),
.//application/Config/Database.php:87:		if (ENVIRONMENT == 'testing')
.//application/Config/Events.php:30:if (ENVIRONMENT != 'production')
.//application/Config/Routes.php:24:// Load the system's routing file first, so that the app and ENVIRONMENT
.//application/Config/Routes.php:91:if (file_exists(APPPATH.'Config/'.ENVIRONMENT.'/Routes.php'))
.//application/Config/Routes.php:93:	require APPPATH.'Config/'.ENVIRONMENT.'/Routes.php';
.//application/Controllers/Checks.php:161:		dd(ENVIRONMENT);
.//application/Views/welcome_message.php:133:				Page rendered in {elapsed_time} seconds. Environment: <?= ENVIRONMENT ?>
.//system/CodeIgniter.php:306:			define('ENVIRONMENT', 'testing');
.//system/CodeIgniter.php:324:		if (file_exists(APPPATH.'Config/Boot/'.ENVIRONMENT.'.php'))
.//system/CodeIgniter.php:326:			require_once APPPATH.'Config/Boot/'.ENVIRONMENT.'.php';
.//system/CodeIgniter.php:778:		if (ENVIRONMENT !== 'testing') {
.//system/Common.php:416:		if (ENVIRONMENT == 'testing')
.//system/Database/Config.php:86:			$group = ENVIRONMENT == 'testing' ? 'tests' : $config->defaultGroup;
.//system/Database/Config.php:142:			$group = ENVIRONMENT == 'testing' ? 'tests' : $config->defaultGroup;
.//system/Format/JSONFormatter.php:52:		$options = ENVIRONMENT === 'production'
.//system/Helpers/html_helper.php:231:		$env                = ENVIRONMENT;
.//system/Log/Logger.php:430:		$replace['{env}']       = ENVIRONMENT;
.//system/Router/RouteCollection.php:901:		if (ENVIRONMENT == $env)
.//system/Session/Session.php:180:		if (is_cli() && ENVIRONMENT !== 'testing')
.//system/Validation/FileRules.php:81:        if (ENVIRONMENT == 'testing')
.//tests/system/Database/BaseConnectionTest.php:16:		'DBDebug'     => (ENVIRONMENT !== 'production'),
.//tests/system/Database/BaseConnectionTest.php:37:		'DBDebug'     => (ENVIRONMENT !== 'production'),
.//tests/system/Log/LoggerTest.php:170:		$expected = 'DEBUG - '.date('Y-m-d').' --> Test message '. ENVIRONMENT;
.//tests/system/Router/RouteCollectionTest.php:543:		// ENVIRONMENT should be 'testing'
.//tests/travis/Database.php:14:		'DBDebug'     => (ENVIRONMENT !== 'production'),
.//tests/travis/Database.php:35:	    'DBDebug'     => (ENVIRONMENT !== 'production'),
.//user_guide_src/autodoc.php:13:define('ENVIRONMENT', 'development');
.//user_guide_src/source/database/configuration.rst:147:			$this->defaultGroup = ENVIRONMENT;
.//user_guide_src/source/general/environments.rst:12:The ENVIRONMENT Constant
.//user_guide_src/source/general/environments.rst:80:There are some places in the CodeIgniter system where the ENVIRONMENT
.//user_guide_src/source/general/environments.rst:87:Setting the ENVIRONMENT constant to a value of 'development' will cause
.//user_guide_src/source/installation/index.rst:39:CodeIgniter, this can be done by setting the ``ENVIRONMENT`` constant, which

nope. ENVIRONMENT should stay untouched. CI is for continuous integration over at TravisCI. The changes you've already made should take care of it. Thanks.

OK.


Histogram charts don't display percentile correctly in the tooltip

See title and screenshot
Screenshots

Environment
(please complete the following information):

browser type and version:
superset version: master

Issue already raised, https://github.com/apache/superset/issues/17550

Ah, good catch, thanks @kamalkeshavani-aiinside . I'll close this one as a duplicate


⚠ ClamAV has degraded performance

In 3a34a87, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in c23c4e7 after 12 minutes.


Cannot load module in JEST

having the import line import clipboard from "clipboardy"; in a test file (that I run with jest) causes the following error to be thrown:
/.../node_modules/clipboardy/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import process from 'node:process';
                                                                                ^^^^^^

    SyntaxError: Cannot use import statement outside a module

https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c


Create Gw2Skin embed

I think this one is done sir.  We can add skins to items now.

@stygiansabyss what were you thinking?
currently you can already give an item a skin with the item embed (see: https://madou.github.io/armory-embeds/?selectedKind=Items&selectedStory=with skin&full=0&down=1&left=1&panelRight=0&downPanel=storybook%2Factions%2Factions-panel).
this issue was originally around creating a "skin only" embed - it could be done today i just haven't really seen anyone need it.


Document webserver deployment for #929

Here's a first go at this - please use / edit as needed.

Great, thanks!


UIKit Consistency error

When I try to set the IsRunning property of an ActivityIndicator to false inside a CachedImage's FinishCommand I get the following error:
"UIKit Consistency error: you are calling a UIKit method that can only be invoked from the UI thread."
I'm currently using version 2.2.0, but have already tried updating to a pre-release version, but with same results.
Due to that error the app crashes. I attached the stack trace to help debugging. Are there any workaround for this issue?
Thanks.
ExceptionLog.txt

You should wrap the call with Device.BeginInvokeOnMainThread call. Currently, OnFinish is not invoked on main thread as it was affecting performance a little. I'll write about it in the release description.

Now, this behavior can be changed with configuration property ExecuteCallbacksOnUIThread (disabled by default)


Tag only filepath

There are plugins to save the cursor position for each file e.g. (n)vim-lastplace, but when i open the file with Grapple it overwrites the cursor position with the one where it was when file was tagged. Is there a way to prevent that and restore the latest cursor position?

With this minimal config:
require("lazy").setup(
{
  {
    "ethanholz/nvim-lastplace",
    config = true,
  },
  {
    "cbochs/grapple.nvim",
    config = function()
      require("grapple").setup()
      vim.keymap.set("n", "<leader>M", require("grapple").toggle)
      vim.keymap.set("n", '<leader>"', require("grapple").popup_tags)
    end,
      dependencies = {
        "nvim-lua/plenary.nvim",
      },
    }
  }, {})

I need to make some changes and write the file to save the cursor position for opening later with Grapple, otherwise it'll load the last saved (when the file was tagged or written) position, while if i just open the file with Netrw i'll get the true last position (thanks to lastplace) without writing the file before that. Is it necessary to provide a bunch of screenshots?

Played around with that a bit, Grapple doesn't save the cursor poition even on writing the file if i exit vim with  mapped to q or :q, i tried both. When i manually enter :q to cmdline, it works well

Seems like if i trigger the CmdLineEnter event with : or ; remapped to :, press <ESC>
and then quit with <C-q> it also saves the cursor position. Is Grapple's cursor saving function listening to this event? Maybe make it listen to BufLeave or something

There is the same problem with Harpoon, and with minimal config i sent there it is not saved even with :q command not in Grapple nor in Harpoon, but with both it is saved at least by :q in my config

@ShinyZero0 thanks for digging into this. I'm working a bit right now on fixing up how grapple handles syncing tags, which should solve the few issues you pointed out above.
As for the (n)vim-lastplace cursor placement, grapple is expected to behave very similar to (and if not the same as) them when setting the cursor location. The fact that is does not should be considered a bug, which I'll look at addressing when I get the chance.
Thanks for feedback!


list alternatives to installing R or Julia kernels

I personally would not use Jupyter for R or Julia. I would use their tools: R Markdown and Pluto.

@MatiasJJ

I agree.

Should we remove that box completely?


fix(website): update example

:tada: This PR is included in version 4.1.0-alpha.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0-alpha.2 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.2-alpha.1 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.0-alpha.1 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:


Teamviewer package is broken

nixos-version 15.09.911.53286a8 (Dingo)
How to reproduce

Set the following in nixpkgs.config:
teamviewer10.sha256 = "10risay1a5a85ijbjaz2vxqbfxygpxslvh0dvzz32k988hr9p1gk"; teamviewer10.url = "http://download.teamviewer.com/download/version_10x/teamviewer_amd64.deb";
Set services.teamviewer.enable = true;
Run nixos-rebuild switch
Run teamviewer
Observe something like
'/nix/store/5mjhg48hih71cp7grddjc9hkv7jf6s1k-teamviewer-10.0.37742/share/teamviewer/tv_bin/script/tvw_exec:             Zeile 33:             /nix/store/5mjhg48hih71cp7grddjc9hkv7jf6s1k-teamviewer-10.0.37742/share/teamviewer/tv_bin/wine/bin/wineserver:             No such file or directory'

Expected
Full functional teamviewer UI

cc @abbradar

I suppose we need to backport my patches for TeamViewer 11 to 15.09, but this is a breaking change -- older TeamViewer versions would be gone. What do you think?

@abbradar note that TeamViewer 11 (nixpkgs-unstable) also seems to have a problem:
sudo teamviewer --daemon start

systemctl start teamviewerd.service
Failed to start teamviewerd.service: Unit teamviewerd.service failed to load: No such file or directory.
fail

Hm, it works for me with services.teamviewer.enable:
 nixpkgs git:(stable) ✗ systemctl status teamviewerd
● teamviewerd.service - TeamViewer remote control daemon
   Loaded: loaded (/nix/store/ja506lgqkdmvfkp9q8i64mvxmqdz86jl-unit-teamviewerd.service/teamviewerd.service; bad; vendor preset: enabled)
   Active: active (running) since Wed 2016-01-13 22:22:04 MSK; 42s ago
  Process: 18435 ExecStart=/nix/store/9v0zqxkppb04g8296xwsygrvx8b36myj-teamviewer-11.0.52520/bin/teamviewerd -d (code=exited, status=0/SUCCESS)
  Process: 18431 ExecStartPre=/nix/store/px21k4y8ysi52ra96ag01r9f2hi7l16k-unit-script/bin/teamviewerd-pre-start (code=exited, status=0/SUCCESS)
 Main PID: 18437 (teamviewerd)
   CGroup: /system.slice/teamviewerd.service
           └─18437 /nix/store/9v0zqxkppb04g8296xwsygrvx8b36myj-teamviewer-11.0.52520/bin/teamviewerd -d...

Jan 13 22:22:04 abbradarbook systemd[1]: Starting TeamViewer remote control daemon...
Jan 13 22:22:04 abbradarbook systemd[1]: teamviewerd.service: PID file /run/teamviewerd.pid not rea...tory
Jan 13 22:22:04 abbradarbook systemd[1]: Started TeamViewer remote control daemon.
Hint: Some lines were ellipsized, use -l to show in full.

Perhaps you tried to install teamviewer from nixpkgs-unstable in the environment, without taking curresponding service from nixos-unstable?

That could be the reason. How can I pick the service from nixos-unstable?

@abbradar what would a backport of your changes to nixos 15.09 break? Can't we just introduce 11.nix?
Anyway, even if older tv versions would be gone when backporting it's still the better option IMO. I mean what's the alternative?

@2chilled Picking a service can be done via combination of imports and nixpkgs.config.packagesOverride (to take newer teamviewer versions. Anyway, I've pushed the update to release-15.09 branch.

Thanks @abbradar ! Can't wait til it's available.
Once again regarding my question:
Would it have been possible to use your teamviewer 11 version from nixpkgs-unstable while staying on the 15.09 channel? If so, how is this done? This would mean one can install different packages from different channels simultaneously using the global configuration.nix

Yes, packages can be installed seamlessly, but with NixOS modules it can get tricky, because we need to "remove" existing module from the configuration tree and I don't know any way to do this.
Example configuration for overriding packages with ones from another channel:
{ config, pkgs, ... }:
  let unstablePkgs = import <nixos-unstable> { };
  in {
    nixpkgs.config.packageOverrides = self: {
      teamviewer = unstablePkgs.teamviewer;
    };
  }

For non-overlapping (non-existent in your current channel) or your custom NixOS modules:
{ config, pkgs, ... }:
  {
    require = [ <nixos-unstable/nixos/modules/services/new-module.nix> ];
  }

For replacing existing NixOS modules (as in your case) I would recommend to instead make your own nixpkgs tree and pick needed patches with git:
git clone -b nixos-15.09 https://github.com/NixOS/nixpkgs-channels nixpkgs
cd nixpkgs
git remote add upstream https://github.com/NixOS/nixpkgs
git fetch upstream
git cherry-pick <commit-1> <commit-2> <commit-3> # cherry-pick needed updates from unstable
nixos-rebuild switch -I nixpkgs=$(pwd)

Great, thanks!

@abbradar Great Comment! That comment should be somewhere prominently in the documentation!

We can make a new package for portable teamviewer: https://github.com/NixOS/nixpkgs/issues/26137


templating fixes

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.22% :warning:

Comparison is base (50f2c78) 72.63% compared to head (582e11e) 72.42%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   72.63%   72.42%   -0.22%
==========================================
  Files          84       84
  Lines        5760     5759       -1
  Branches     1238      939     -299
==========================================
- Hits         4184     4171      -13
- Misses       1311     1323      +12
  Partials      265      265

Files Changed
Coverage Δ

lona/default_views.py
100.00% <100.00%> (ø)

lona/responses.py
77.85% <100.00%> (ø)

... and 11 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix leap year bug

Description

Issue reference
https://github.com/dapr/dapr/issues/3995
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Close this PR and resubmit a new one after resolving the DCO

the new PR: https://github.com/dapr/dapr/pull/4027


Swallowing a loadable error in an Error Boundary leads to an infinite loop

🐛 Bug Report (/feature request?)
If you swallow a loadable error in an error boundary and render the same tree again, loadable will try to load that chunk once more, possibly triggering the same error, and so on.
In dev, this can lead to an infinite loop, in prod builds React might unmount instead.
Context: Some lazy-loaded components are "optional", so in our app we often just want to report that they failed loading in an error boundary, but let the users keep using the page.
To Reproduce

Wrap app in an error boundary that still renders this.props.children after chunk errors.
Provoke a chunk error, for example by blocking that JS-resource in the browser network tab.

Expected behavior
If a lazy loaded component has already failed loading once, I expect the default to be to not try again. Possibly there should be an API to configure number of retries?
Today you would have to wrap every single Loadable in it's own error boundary that renders null on chunk errors, which is very verbose and cumbersome.
Link to repl or repo (highly encouraged)
This codesandbox works by default and because of how codesandbox works you can't block the JS-resource, BUT, you can simulate a chunk error by removing the export default in LazyComponent.
https://codesandbox.io/s/loadable-components-error-handling-xh1nn
Note that in our real app, this same error happens regardless of why the chunk failed to load, so for example timeouts or blocking the resource will have the same result.

This is still an active bug report/feature request.

If a lazy loaded component has already failed loading once, I expect the default to be to not try again. Possibly there should be an API to configure number of retries?

Loadable is stateless and after some component being unmounted (basically because of error thrown) it "forgets" everything.
If you want to handle this situation properly you have to use ErrorComponent (let it render null). ErrorBoundry is just not a correct way of doing this.


Issue in importvirtualmachines.ps1 when additional disks are attached

We are successfully using importvirtualmachines.ps1 when VMs don't have additional disks, but when we have additional disks it seems to fail with the following error:
CreatingOrUpdatingOnlyAllowedForCurrentUser : Creating or updating resources is only allowed for the current user.
Allowed values for user name: [a31d5170-9ad3-47f8-a1f7-27ce199923a1, @me].
+ CategoryInfo          : CloseError: (:) [Invoke-AzureRmResourceAction], ErrorResponseMessageException
+ FullyQualifiedErrorId : CreatingOrUpdatingOnlyAllowedForCurrentUser,Microsoft.Azure.Commands.ResourceManager.Cmd
lets.Implementation.InvokAzureResourceActionCmdlet
+ PSComputerName        : localhost
Failed to migrate VM 'AtlasDemo' from Lab 'PlatformDataGovernanceTestLab' to Lab 'DGXDtl'
+ CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
+ FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException
+ PSComputerName        : localhost

@hintbw, thank you for reporting the issue. Before starting to review the scenario, can you please confirm the repro steps?
Steps to Reproduce

Create a new or use an existing lab (i.e. MyLab1).
Create Lab VM (i.e. MyVm1) of type Linux or Windows in MyLab1.
Add a new disk (i.e. MyDataDisk1).
Create a new or use an existing lab (i.e. MyLab2).
Execute the script as follows:./ImportVirtualMachines.ps1 -SourceSubscriptionId 'MySub1' -SourceDevTestLabName 'MyLab1' -SourceVirtualMachineName 'MyVm1' -DestinationSubscriptionId 'MySub2' -DestinationDevTestLabName 'MyLab2' -DestinationVirtualMachineName 'MyVm2'

Observe reported error.

@leovms Those are the steps to reproduce, the one addition is that there are two data disks

Thank you. Let me take a look.

I'm also happy to submit an Azure Support incident and share the ticket number if that would help get access to any logs that might be helpful. We've had a team that migrated 5 different machines over the weekend all of which didn't have more than just an OS disk.

As you wish. I'm first going to run through the scenario and try to repro it. If I can repro it, then I'll enter a bug in our system and get it worked on.

@hintbw, I just completed a test run on the script. It did successfully create a new VM with the 2 data disks. Can you tell me if the user executing the script owns the source VM and the target lab? Is there something you can share about the permissions of the user executing the script, as it pertains to the source and destination subscriptions/labs/VMs?

I am the one running the script. I am an owner (RBAC role) on the source lab and VM and the target lab. I did some more investigation and I believe there is more to the repo steps that are required. It appears that there were 2 disks with the same names as the data disks being migrated that already existed in the destination subscription. Given the error about updating an existing resource, perhaps that might be related (my user didn't have permissions on those disks). The disks that existed in the destination subscription were unattached so I'm deleting them and am going to try the migration again and will report back when it finishes.
In the case of your repro steps, it would be interesting to see if, when similar disks already existed in the destination subscription, the migration also fails. In my case, the disks were not even in the same resource group as the destination devtest lab.

Unfortunately, even with removing those two data disks in the destination subscription, I received the same error message. It failed on the same step with disks - which I don't understand. I've compared what we are doing between this lab and another lab and still can't understand why there is a failure.

On my side, I've not being able to repro your reported error either. Are you able to create another lab and try the same operation there? Unfortunately, without a repro, I'm afraid I can't do much to help.

@hintbw, I'll be closing this issue. If you come up with new information that can help us repro the scenario, please feel free to re-open it. We'll be happy to take a look again.


Create applications

Add basic code to create the applications

Pls fix the conflicts

closing in favor for #9


Update supported CentOS version for file-system watching

In a weird migration story CentOS 8 (which we did support) has already been deprecated, while CentOS 7 is still supported (but we did not support FSW on it). Now there's CentOS Stream 8 (which we do support, and have tests for it), though it's going to reach end-of-life at the end of May 2024. After that there will only be CentOS Stream 9.
Details: https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/

@bot-gradle merge

The merge queue build has started. Click here to see all failures if any.


GO:0044662 disruption by virus of host cell membrane

From @ValWood in #18692
(thus point was not dealt with):

[ ]  GO:0044662 disruption by virus of host cell membrane
A process by which a virus has a negative effect on the functioning of a host cellular membrane.

I don't understand this one at all what is "negative effect on the functioning of a host cellular membrane"?
5 annotations CACAO
but looking at the paper it should probably merge into
GO:0044659 cytolysis by virus of host cell
Definition (GO:0044659 GONUTS page)
The killing by a virus of a cell by means of the rupture of cell membranes and the loss of cytoplasm. PMID:26728778
it's another way of saying the same thing
i.e I think most of the high level "disruption terms" can be removed as most of the meaningful terms have alternative sensible parents...

[ ] There is one child term, 'GO:0090680 disruption by virus of host outer membrane'

@dsiegele Can the CACAO annotations be re-housed?
Thanks, Pascale

2 mappings:
UniRule:UR000865637 > GO:disruption by virus of host cell membrane ; GO:0044662
UniRule:UR000865639 > GO:disruption by virus of host cell membrane ; GO:0044662

viral release from host cell by cytolysis

[ ] add parent:  is_a GO:0001897 ! cytolysis by symbiont of host cells
[ ] add is_a: GO:0051673 ! membrane disruption in another organism (although this term may be obsoleted)
[ ] remove has_part GO:0001897 ! cytolysis by symbiont of host cells


JsonMergePatchHelper pattern can be simplified

While regenerating an SDK to use stream-style serialization I found that the JsonMergePatchHelper pattern used to turn on and off patch serialization doesn't work correctly for polymorphic types.
When the models support JSON merge patch each model will create an access helper and add a boolean flag to determine whether JSON merge patch serialization should be used when calling toJson. This isn't necessary and can be a single instance on the super type by having the super type expose the patch serialization status to child types. So instead of:
public class Super {

  static {
    // Configure access helper
  }

  private boolean jsonMergePatch;

  public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
    if (jsonMergePatch) {
    ...
  }
}

public class Child extends Super {

  static {
    // Configure access helper
  }

  private boolean jsonMergePatch;

  public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
    if (jsonMergePatch) {
    ...
  }
}

it can be simplified to
public class Super {

  static {
    // Configure access helper
  }

  private boolean jsonMergePatch;

  boolean isJsonMergePatch() {
    return jsonMergePatch;
  }

  public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
    if (isJsonMergePatch()) {
    ...
  }
}

public class Child extends Super {

  public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
    if (isJsonMergePatch()) {
    ...
  }
}

And since there is boilerplate code for each accessor this will simplify that to one instance per polymorphic model hierarchy.
Further investigation could be done to see if it is possible for all models within a single package could use the same access helper.

Thanks Alan for the suggestion, it could be better. Could you explain more on below statement, as I don't quite get the issue with having jsonMergePatch flag for both parent and child classes.

This isn't necessary and can be a single instance on the super type by having the super type expose the patch serialization status to child types.

Thanks Alan for the suggestion, it could be better. Could you explain more on below statement, as I don't quite get the issue with having jsonMergePatch flag for both parent and child classes.

This isn't necessary and can be a single instance on the super type by having the super type expose the patch serialization status to child types.

There isn't an explicit issue, it'll work perfectly fine but a parent type and child types both defining a property result in larger models and a bit of confusion when looking at code (mainly around, does setting this update the parent property or the child property). And this can be simplified to just the parent model defining the value and allowing children to access it, and will remove the number of accessors that need to be generated (for example in what I'm trying to regenerate this will remove 20-30 accessors that are never used as they're child types).


Discovery Plus: Network tool not detecting any m3u8 links

I extracted the cookies into a cookies.txt file.
put in the episode link via the format:
youtube-dl --cookies cookiesurl episodeurl
Got an "unsupported url" error. I then realized I need to give it the m3u8 link.
Tried firefox and edge(using a mac) to grab the m3u8 link. I am unable to find any such link. Only thing I could find was the mpd link(that does not work either)
Sample episode link: https://www.discoveryplus.com/video/fixer-upper-welcome-home/a-neglected-home-for-newlyweds
Screenshot from firefox:

Got it to work. code I used:
yt-dlp --verbose --cookies /Downloads/YTDL/discoveryplus.com_cookies.txt https://www.discoveryplus.com/video/fixer-upper-welcome-home/a-neglected-home-for-newlyweds


general purpose info field in contract

This is something to settle with andrew and victor. For now, we ignore it.


heroku account to be env dependent

How about making it switch heroku account automatically according to an environment variable?
It is quite annoying to switch heroku account on each project while there is already a seperate virtualenv to each of them.

This is not possible with http git. Use something like direnv to automatically switch.


Support rtwdog on rt1180

Added the rtwdog Zephyr driver for RT1180 EVK.

Related hal_nxp PR: https://github.com/zephyrproject-rtos/hal_nxp/pull/482

Related hal_nxp PR: zephyrproject-rtos/hal_nxp#482

Please record your hal_nxp PR in west.yml like : pull/444/head

please add -watchdog to boards\nxp\mimxrt1180_evk\mimxrt1180_evk_mimxrt1189_cm33.yaml

please add -watchdog to boards\nxp\mimxrt1180_evk\mimxrt1180_evk_mimxrt1189_cm33.yaml

Also would be good to document support for this on the board, like we do here: https://github.com/zephyrproject-rtos/zephyr/blob/e60f04096cd8d9227c8279ca830e72bc1b5b8b1c/boards/nxp/rd_rw612_bga/doc/index.rst?plain=1#L53

Please rebase when you have a chance- sorry that the manifest file keeps getting conflicts!


Polish translation

Hi,
I have translated the entire readme into Polish language.
Did some whitespace cleanup as well.
Please review and merge.
Also, thanks for that repo - awesome collection of articles and videos.
Cheers

Hey Dawid, open a new PR and just include the link to the translated repo.


fix(backend): remove settings

Motivation

Changes

Tests

this was a temporary fix to be deployed in staging


CSS custom properties (aka variables)

First of all: Thanks for this awesome tool. I use it every day :+1:
Is there a way to specify where to put all CSS custom properties? For instance, I would like to put all custom properties at the end of the property list:
.button {
    height: 2rem;
    --button-background-color: hotpink;
    padding: 0.2rem;
}

should be reformatted like
.button {
    height: 2rem;
    padding: 0.2rem;
    --button-background-color: hotpink;
}

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Hey @jhnns! Unfortunately, currently there is no way to specify order of css variables.
But I think it's worth implementing, so I'll keep the issue open.

Came here to raise this specific bug. Would be very handy to make sure to specify how native CSS Variables should be sorted.

Hi All!
I'm closing this because unless a PR is created it won't likely be addressed.
If you feel strongly about this request I encourage you to dig in and submit a PR 😸


Add ability to highlight specific words

Task
Allow to share code snippets on desktop using some special characters to delimitate code.
Let's use one backtick at the start and end: example
Implement new collection view items to show formatted code in chats
Design

Implement something similar to this:
Colour #FF9900

Yeah this is exactly how I imagined it!

Would be great to have a Figma link for this

@tomsmith8 Sure, you can find final figma project here
https://www.figma.com/file/L1oq8hh8kYU90bQxPAin3G/Mobile-Design-System---Dark-Version?type=design&node-id=7472%3A9345&mode=design&t=Nc0joYFntzsBCcGe-1

@tomsmith8 I did a first implementation of this feature in both iOS and Mac. It is supported in chat messages, thread header and threads list. The design doesn't match exactly the Figma designs but it's pretty similar. Please help me testing this when new versions are out (uploading them right now)


Allow initContainers in deployment

PVC provisioners do not always spawn a volume with open permissions.
Init containers allow to chown the volume before ngshare is started, and allow many other initializations.
This copies the initContainers idea that is used in z2jh.

LGTM

Can you add a quick note under docs/user_guide/change_log.rst as well? We can bundle it with 0.5.2 which should probably be released in a week or so

Can you add a quick note under docs/user_guide/change_log.rst as well? We can bundle it with 0.5.2 which should probably be released in a week or so

Done!

Thanks a ton!


TS-4195: double free on exit

(cherry picked from commit 1a7c0fc8cdf5ed48870e1507bf337fb2e711226f)
Conflicts:
lib/ts/signals.cc

@zwoop this is the backport of the fix for crash on exit.

test


SROS Partial configure has channel timeout errors

I'm using containerlab 0.49. with the clab and SROS configuration file below. If I use the config as a partial configuration file (sros1.partial.cfg) for the lab I get a channel timeout error in the debug logs and the configuration is not completed. Using the configuration file as a full configuration file (by changing its name and the lab file to remove partial) there is no debug error and the configuration completes.
The expected behaviour is that the configuration should be applied irrespective of the full or partial configuration use.
Debug error with partial config file
DEBU[0098] CRITICAL channel timeout sending input to device
ERRO[0098] failed to run postdeploy task for node sros1: failed to apply config; error: errTimeoutError: channel timeout sending input to device
Config file.
/file copy tftp://<IP_ADDRESS>/cert.pem cf3:/ force
/file copy tftp://<IP_ADDRESS>/cert-key.pem cf3:/ force
/admin system security pki import type key format pem input-url cf3:/cert-key.pem output-file cert-key.pem
/admin system security pki import type certificate format pem input-url cf3:/cert.pem output-file cert.pem
/configure system security tls cert-profile sr-cert-prof entry 1 certificate-file cert.pem
/configure system security tls cert-profile sr-cert-prof entry 1 key-file cert-key.pem
/configure system security tls cert-profile sr-cert-prof admin-state enable
/configure system security tls server-cipher-list "ciphers" tls12-cipher 1 name tls-rsa-with3des-ede-cbc-sha
/configure system security tls server-cipher-list "ciphers" tls12-cipher 2 name tls-rsa-with-aes128-cbc-sha256
/configure system security tls server-cipher-list "ciphers" tls12-cipher 3 name tls-rsa-with-aes256-cbc-sha256
/configure system security tls server-cipher-list "ciphers" tls12-cipher 4 name tls-rsa-with-aes128-gcm-sha256
/configure system security tls server-cipher-list "ciphers" tls12-cipher 5 name tls-rsa-with-aes256-gcm-sha384
/configure system security tls server-tls-profile “sr-server-tls-prof” cert-profile "sr-cert-prof" admin-state enable
/configure system security tls server-tls-profile “sr-server-tls-prof” cipher-list "ciphers"
/configure system grpc tls-server-profile "sr-server-tls-prof"
clab file
name: sros2devices
topology:
nodes:
sros1:
kind: nokia_sros
image: vrnetlab/vr-sros:23.7.R2
type: sr-1
mgmt-ipv4: <IP_ADDRESS>
startup-config: /home/xxxx/srossros/sros1.partial.cfg
license: /home/xxxx/SR_OS_vSIM1_license.txt
binds:
- /home/brad/ca/clab-sros2devices-sros1/cert-key.pem:/tftpboot/cert-key.pem
- /home/brad/ca/clab-sros2devices-sros1/cert.pem:/tftpboot/cert.pem
sros2:
kind: nokia_sros
image: vrnetlab/vr-sros:23.7.R2
type: sr-1
mgmt-ipv4: <IP_ADDRESS>
startup-config: /home/xxxx/srossros/sros2.partial.cfg
license: /home/xxxx/SR_OS_vSIM2_license.txt
links:
- endpoints: ["sros1:eth1", "sros2:eth1"]

the " in the profiles have been replaced by word to be some thing other than a ". SROS takes it and accepts it fine but the partial config seems to get upset about them. retyped with " and the partial config is sent fine. Guess what ever the character is above in the example just upsets the sender in containerlab.


Reenable benchmark sharding

This is reverting the revert of the benchmark sharding support. In addition it fixes the android benchmarking issue that was discovered after submission.

The CI seems to be happy now.

LGTM. Let me know if you need help to merge

Yes. Would be great if you could merge. Thx.


Increase the usage of augmented assignment statements

:eyes: Some source code analysis tools can help to find opportunities for improving software components.
:thought_balloon: I propose to increase the usage of augmented assignment statements accordingly.
Would you like to integrate anything from a transformation result which can be generated by a command like the following?
(:point_right: Please check also for questionable change suggestions because of an evolving search pattern.)
lokal$ perl -p -i.orig -0777 -e 's/^(?<indentation>\s+)(?<target>\S+)\s*=\s*\k<target>[ \t]*(?<operator>[+%^@]|-(?!>)|&(?!&)|\|(?!\|)|\*\*?|\/\/?|<<|>>)/$+{indentation}$+{target} $+{operator}=/gm' $(find ~/Aktivitäten/nerfstudio/lokal -name '*.py')

:crystal_ball: How will the development interests evolve further also according to update candidates in 25 lines of this software?

I think you need to be a bit careful with using augmented assignments and pytorch since they are not equivalent,
ie. https://crazyoscarchang.github.io/2018/10/04/in-pytorch-not-the-same/
We will however happily consider PRs with these changes (assuming it is demonstrated that the code still works).

:thought_balloon: Will the support ever grow also for applications of in-place data modifications?
:thinking: Would you like to influence such an implementation detail by a corresponding software build option?
Do you find any change possibilities reasonable?


can not resolve import path

When I use npm link debug my custom webpack build tool, antd and ts-import-plugin are not at the same level in node_modules, resolve import path fail.

So, what's your node_modules structure look like ?

node_modules
  - antd
  - webpack-build-tool
    - node_modules
      - ts-import-plugin

Oh it's a correct behavior for ts-import-plugin, if you want use npm link to debug your webpack build tool, you could install ant-design as devDependencies in your package.

I think resolve antd like this maybe better.
require.resolve(path.resolve(process.cwd(), 'node_modules', importPath))

Hi @Brooooooklyn
Sorry for leaving comments on this closed issue.
We are using ts-import-plugin and antd-mobile in a yarn workspaces mono-repo structure. Hence, antd-mobile has been hoisted to workspace level.
Directory structure is like below:

<project root>

node_modules

antd-mobile

<project A uses ts-import-plugin>
<project B uses ts-import-plugin>

https://github.com/Brooooooklyn/ts-import-plugin/blob/27ee613ab86d686d8d9ce75065c21c9bca30c516/src/index.ts#L96
is supposing the library is under <project A>\node_modules\antd-mobile. The original code use require.resolve can resolve yarn workspaces structure.
Our current workaround is to put antd-mobile into nohoist section.  As a result, we have each project in the yarn workspace has a copy of antd-mobile.

<project root>

node_modules
<project A uses ts-import-plugin>

antd-mobile

<project B uses ts-import-plugin>

antd-mobile

@aaronchenwei could require.resolve(process.cwd(), importPath) work in your case ?

@Brooooooklyn  Do you mean require.resolve(importPath)? It was your original line of code. That it working with our case.

Hi @Brooooooklyn
Just re-visit the original description of this issue, I'm not sure which case for module resolving is more common.
join(process.cwd(), 'node_modules', importPath) is supposing the imported library located under nohoisted node_modules directory. It is not the case for yarn workspaces or lerna mono-repo directory structure because we have full path prefix for library.
require.resolve(importPath) could resolve the library.  That is because the Node module resolution algorithm is recursive: When looking for package A, it looks in a local node_modules/A directory, then in ../node_modules/A, ../../node_modules/A, ../../../node_modules/A, etc.
with the original issue here, does npm dedupe help or even use NODE_PATH to load module from global?

@Brooooooklyn just tested with v1.5.3, it is working as expected. Thanks.


Emit commandCancel when reason is promptLimit or prompt length is zero

I'm not sure why this was excluded originally, but I noticed it earlier today when someone inadvertently used a command incorrectly and triggered this. The event was never emitted even though the command was in-fact canceled.

در تاریخ شنبه ۲۷ مارس ۲۰۲۱، ۲۰:۲۵ Dragon Fire @.***>
نوشت:

Merged #379 https://github.com/discordjs/Commando/pull/379 into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/discordjs/Commando/pull/379#event-4517190792, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOKVZWWB5EPA6SXGGTZURCLTFX5VRANCNFSM4YOCYDVA
.


example suggestion: basic Dict usage in roc

I would like to contribute to this issue. My PR is here: https://github.com/roc-lang/examples/pull/128
I know I should have first asked in the chat, but i wasn't sure about the result of my code.

I've just noticed the CI script. I'll add tests for it. Keeping the PR as a Draft, for now.

The PR is ready to review. Please.

Thanks @frisoft! I'll try to review today :)

I've made some changes, but it's late for me so I'm going to test and review the final code tomorrow.


Disable Edit & Delete buttons when lacking sufficient permission

Proposal
When clicking on a resource (e.g global variable, project rolebinding..) you don't have the permission to modify, the Edit & Delete button still appear as clickable. The backend is correctly denying the request when attempting such action, still it would be great to have these buttons displayed as grayed out in that case.

I think @Gladorme already did some work around this issue.
Did you have this issue with what is available on the main branch or with the last released version (v0.42.1) ?

He is talking about form editor buttons, there is no check on these one


Gestalt commit hooks for linting and testing

Adds husky and link-staged packages to help lint files and test components locally before they are checked in so that our CI can do less work. This can pave the way to eventually helping standardize commits or even generating changelogs on the fly. Some example commits:

Deploy preview for gestalt ready!
Built with commit 574591f7a0ce4e57cc1c2c5e4e7031e4f3c591fa
https://deploy-preview-258--gestalt.netlify.com

Deploy preview for gestalt ready!
Built with commit 698fd85f9fafcfa678e2862862d923bbd39447dd
https://deploy-preview-258--gestalt.netlify.com


Error: fatal: could not read Username for 'https://github.com': terminal prompts disabled

Describe the bug
All CI fails suddenly without any modification.
To Reproduce
Reproducer here : https://github.com/vasilvestre/status
Expected behavior
CI should work as before, the configuration hasn't changed.

This is happened in the past (https://github.com/upptime/upptime/issues/59). Maybe it's related to https://github.com/actions/checkout/issues/664? Do you remember if you changed your personal access token, MFA, password, etc., recently?

The token simply expired after 90 days. Thank you for your help !

Same here, token expired and you get this obscure error message.


instantiate_contract fails with "Generic error: Error decoding bech32"

Hi everyone,
While following the cosmwasm book, I encounterd the next problem: When running instantiate_contract in tests, the call returns an error.
Here is a code sample:
    let addr = app
        .instantiate_contract(
            code_id,
            owner_addr,
            &InstantiateMsg {
                donation_denom: "uusd".to_owned(),
                fee_collector_addr: "fee_collector_addr".to_owned(),
                projects: vec![
                    ("project1".to_owned(), "creator_addr_1".to_owned()),
                    ("project2".to_owned(), "creator_addr_2".to_owned()),
                ],
            },
            &[],
            "Contract",
            None,
        )
        .unwrap();

And the resulting error:
called `Result::unwrap()` on an `Err` value: Error executing WasmMsg:
  sender: cosmwasm1fsgzj6t7udv8zhf6zj32mkqhcjcpv52yph5qsdcl0qt94jgdckqs2g053y
  Instantiate { admin: None, code_id: 1, msg: {"donation_denom":"uusd","fee_collector_addr":"fee_collector_addr","projects":[]}, funds: [], label: "Contract" }

Caused by:
    Generic error: Error decoding bech32

I was not able to found a solution, and I'm not even sure if that's a bug or if I'm missusing the instantiate_contract function.
Here is a reproduction repository: https://github.com/maxmousse/cosmwasm-test . Just run cargo test and the error should pop up.
If someone can points me in the right direction, I'm willing to submit a PR to eather fix this, or add some examples in the documentation ;)

Hi @maxmousse, please take a look at this: #165. We are currently working on making documentation better...

Hi @maxmousse!
Please take a look at the PR I prepared in your codebase: https://github.com/maxmousse/cosmwasm-test/pull/3.
Hopefully it clarifies all concerns and helps you in further development of your contract.
I am closing this issue, but feel free to reopen it if needed, or file a new one.
Kind Regards,
Darek

Hello @DariuszDepta, thanks a lot for your PR, it is very helpful and answer my questions!


virtio-fs cache problem?

Description of problem
Steps to reproduce the problem:

install docker with kata static tarball -- https://github.com/kata-containers/runtime/releases/download/1.11.3/kata-static-1.11.3-x86_64.tar.xz
cd /opt/kata/share/defaults/kata-containers; ln -s configuration-qemu-virtiofs.toml configuration.toml
docker run --rm -ti centos:7 bash
execute the following command in container: yum install -y libmnl

Expected result
expect the package to be installed with no error
Actual result
yum reported errors:
...
Running transaction
Installing : libmnl-1.0.3-7.el7.x86_64                                    1/1
Verifying  : libmnl-1.0.3-7.el7.x86_64                                    1/1
Traceback (most recent call last):
File "/usr/bin/yum", line 29, in
yummain.user_main(sys.argv[1:], exit_code=True)
File "/usr/share/yum-cli/yummain.py", line 375, in user_main
errcode = main(args)
File "/usr/share/yum-cli/yummain.py", line 281, in main
return_code = base.doTransaction()
File "/usr/share/yum-cli/cli.py", line 817, in doTransaction
resultobject = self.runTransaction(cb=cb)
File "/usr/lib/python2.7/site-packages/yum/init.py", line 1944, in runTransaction
self.verifyTransaction(resultobject, vTcb)
File "/usr/lib/python2.7/site-packages/yum/init.py", line 2007, in verifyTransaction
po.yumdb_info.releasever = self.conf.yumvar['releasever']
File "/usr/lib/python2.7/site-packages/yum/rpmsack.py", line 1936, in setattr
self._write(attr, value)
File "/usr/lib/python2.7/site-packages/yum/rpmsack.py", line 1860, in _write
misc.unlink_f(fn + '.tmp')
File "/usr/lib/python2.7/site-packages/yum/misc.py", line 966, in unlink_f
os.unlink(filename)
OSError: [Errno 5] Input/output error: '/var/lib/yum/yumdb/l/c105e6d2014edce517b7da13bb8b9a085af63d34-libmnl-1.0.3-7.el7-x86_64/releasever.tmp'
Also, the above file could not be manually removed:
[root@6bd06068b8a5 /]# ls -l /var/lib/yum/yumdb/l/c105e6d2014edce517b7da13bb8b9a085af63d34-libmnl-1.0.3-7.el7-x86_64/releasever.tmp
-rw-r--r-- 2 root root 1 Aug  9 21:39 /var/lib/yum/yumdb/l/c105e6d2014edce517b7da13bb8b9a085af63d34-libmnl-1.0.3-7.el7-x86_64/releasever.tmp
[root@6bd06068b8a5 /]# rm -f /var/lib/yum/yumdb/l/c105e6d2014edce517b7da13bb8b9a085af63d34-libmnl-1.0.3-7.el7-x86_64/releasever.tmp
rm: cannot remove '/var/lib/yum/yumdb/l/c105e6d2014edce517b7da13bb8b9a085af63d34-libmnl-1.0.3-7.el7-x86_64/releasever.tmp': Input/output error
If I stat the directory before executing rm, the file can be removed:
[root@6bd06068b8a5 /]# ls /var/lib/yum/yumdb/l/c105e6d2014edce517b7da13bb8b9a085af63d34-libmnl-1.0.3-7.el7-x86_64/
from_repo  reason  releasever.tmp
[root@6bd06068b8a5 /]# rm -f /var/lib/yum/yumdb/l/c105e6d2014edce517b7da13bb8b9a085af63d34-libmnl-1.0.3-7.el7-x86_64/releasever.tmp
[root@6bd06068b8a5 /]#
Further information

tested 9pfs, no problem;

tested kata release 1.11.0 and 1.9.3, all have the same problem;

tested virtio_fs_cache="auto", same problem;

tested virtio_fs_cache="none", saw a different problem:

[root@6f4e9edbf05b /]# yum install -y libmnl
error: db5 error(19) from dbenv->open: No such device
error: cannot open Packages index using db5 - No such device (19)
error: cannot open Packages database in /var/lib/rpm
CRITICAL:yum.main:
Error: rpmdb open failed

Adding @dagrh to the loop.

Further findings:
the problem happens when backing filesystems is ext4; after switching backing filesystems to xfs the problem is gone.

@jcvenegas will look into this

@jcvenegas will look into this

This could be a duplicate of #2580.
Could you try again passing -o xattr as additional args for virtiofs in your configuration?
Edit your configuration.toml file (e.g. under /usr/share/kata-containers/defaults), look for virtio_fs_extra_args, set it so that it contains something like `[ "-o", "xattr" ]

This could be a duplicate of #2580.
Could you try again passing -o xattr as additional args for virtiofs in your configuration?
Edit your configuration.toml file (e.g. under /usr/share/kata-containers/defaults), look for virtio_fs_extra_args, set it so that it contains something like `[ "-o", "xattr" ]

This issue is being automatically closed as Kata Containers 1.x has now reached EOL (End of Life). This means it is no longer being maintained.

Important:
All users should switch to the latest Kata Containers 2.x release to ensure they are using a maintained release that contains the latest security fixes, performance improvements and new features.

This decision was discussed by the @kata-containers/architecture-committee and has been announced via the Kata Containers mailing list:

http://lists.katacontainers.io/pipermail/kata-dev/2020-November/001601.html
http://lists.katacontainers.io/pipermail/kata-dev/2021-April/001843.html
http://lists.katacontainers.io/pipermail/kata-dev/2021-May/001896.html

If you believe this issue still applies to Kata Containers 2.x, please open an issue against the Kata Containers 2.x repository, pointing to this one, providing details to allow us to migrate it.


ScrollPaneListener notifies when the edge has been hitted.

Hi,
since I've needed this functionality for dynamic ScrollPane loading,
I decided to continue the code from this pr https://github.com/libgdx/libgdx/pull/1626 solving the merge conflicts.
I hope everything is OK.

Hello!
You have a new message, please read http://www.familylawhollywood.com/attempt.php?9
<EMAIL_ADDRESS>


Add shopify logo

Linked to https://www.shopify.com/careers/search?locations[]=43&keywords=&sort=
Logo emailed

Done https://github.com/GeekcampSG/geekcampsg.github.io/pull/103


Lerna: way how to add non-core plugins

@tony-shannon @fzaninotto @kbeloborodko
Probably, we discussed this issue later, but I want to remind about it.
What we want to do
We want to use Lerna to manage different versions, based on PulseTile-RA. As version I mean:
PulseTile-RA core + some non-core (plugins + features + pages) = VERSION
Examples of versions are:
Helm (Core + plugins Top3, Vaccinations, Feeds);
Showcase (Core + plugins Top3, Vaccinations, Feeds + multi-patients view);
Scotland (Core + ReSPECT plugin + patient search).
We see the Lerna structure as:
|--versions
|----helm
|----showcase
|----scotland
|--library
|----core
|----plugins
|----features

The problem
This is non-core plugin Vaccinations. It should be absent in core, and should be added in versions, where it is necessary (Helm and Showcase):
https://github.com/PulseTile/PulseTile-RA/tree/master/src/version/plugins/Vaccinations
It consists of 4 files, but we can't add it to core as Ctrl+C and Ctrl+V.
We can only import it as library, like:
import Vaccinations from "pulsetile-vaccinations";

But we can't create this library, because it depends on some files from other parts of our project:
https://github.com/PulseTile/PulseTile-RA/blob/master/src/version/plugins/Vaccinations/VaccinationsCreate.js
import CreateTemplate from "../../../core/common/ResourseTemplates/CreateTemplate";

All these files are located in common/ directory and includes buttons, templates, toolbars etc.:
https://github.com/PulseTile/PulseTile-RA/tree/master/src/core/common
Idea for solution
Suggest to create npm-module for common/ components. We can create this module, and publish it on npmjs.com. Module will be installed to PulseTile-RA as node_module package.
After this they will be imported to required files as library. Not as component for other file.
import { CreateTemplate } from "pulsetile-common";

We can do following:

Create new npm module, based on common/ directory
Upload this npm-module to npmjs.com
Create new branch from master.
Install new npm-module.
Remove common/ directory
In all places, where we use some components from common, we should change import as I described upper
Check, is it work

It gives possibility to create our plugins as separate libraries.
Each version will import only plugins, which should be there.

@tony-shannon @fzaninotto @kbeloborodko
I checked, our idea is workable. What was done:

Created npm-module for common elements:
https://www.npmjs.com/package/pulsetile-ra-common

Created new branch (based on master). All non-core plugins were removed:
https://github.com/PulseTile/PulseTile-RA/tree/for-lerna

Checked, that plugin can be created via npm module pulsetile-ra-common (Allergies plugin as example):
https://github.com/PulseTile/PulseTile-RA/blob/for-lerna/src/core/plugins/Allergies/AllergiesCreate.js

Updated core package in Lerna:
https://github.com/BogdanScherban/PulseTile-Lerna/tree/master/packages/pulsetile-core

Found a way, how to add non-core plugin in Lerna:
https://github.com/BogdanScherban/PulseTile-Lerna/blob/master/versions/helm/src/index.js

This plugins array is passed to package:
https://github.com/BogdanScherban/PulseTile-Lerna/blob/2ad60ddb9b483b976837f6d97f42f5210cff545e/packages/pulsetile-core/src/core/App.js#L24

And it works!
So, we can do following:

Remove all non-core elements from pulsetile-core;
Create packages for all plugins
Create three versions - for Showcase, Helm and Scotland.
All features of each version (custom Topbars, Sidebars, Footers) will be created in version and passed to pulsetile core like:

import React from 'react';
import ReactDOM from 'react-dom';

import Core from "pulsetile-core";

import nonCorePages from "./nonCoreElements/pages";
import nonCorePlugins from "./nonCoreElements/plugins";

import Footer from "./Footer";
import Topbar from "./Topbar";
import Sidebar from "./Sidebar";

ReactDOM.render(
    <Core
        topbar={Topbar}
        footer={Footer}
        sidebar={Sidebar}
        nonCorePlugins={nonCorePlugins}
        nonCorePages={nonCorePages}
    />,
    document.getElementById("root")
);

So, we found a way, how to do this. And we can try to realize Helm, Showcase and Scotland via Lerna!

2 things I don't understand:

I find the name "versions" very misleading. These are applications, websites, examples, implementations, but not versions. If "version" means "application" in the health sector, then you should keep it. Otherwise, change it, it's confusing.
Why separate common and core into 2 packages? What you put in common should be, IMO, in core

About that, you're saying:

But we can't create [pulsetile-vaccinations], because it depends on some files from other parts of our project

I don't understand the problem. If you import the CreateTemplate from 'pulstetile-core', it should work.
Also, you're speaking about publishing to npm for tests. yarn workspaces lets you use a package from the same repository without publishing it to npm, this should ease the tests.
About your second comment, I'm confused about what I should look at. You're linking to 2 separate repositories (for-lerna branch in PulseTile/PulseTile-RA, and master branch in BogdanScherban/PulseTile-Lerna). Are those 2 versions of the same code, or do you plan to have 2 separate repositories in the future?
In the repos you link, in the src/core package, there is still a 'version' directory, and I don't understand what it does. I thought versions were moved up?

@fzaninotto

I find the name "versions" very misleading.

OK, suggest to use "application" for Helm/Showcase/Scotland etc.

Are those 2 versions of the same code, or do you plan to have 2 separate repositories in the future?

In future it should be one project. Now our project is PulseTile/PulseTile-RA.
BogdanScherban/PulseTile-Lerna - it is only for my inverstigation - how Lerna works?

I thought versions were moved up?

I only described an idea. It will be moved.

Why separate common and core into 2 packages?
If you import the CreateTemplate from 'pulstetile-core', it should work.

I tried to import CreateTemplate from 'pulstetile-core' by the ways:
import ListTemplate from "pulsetile-core/lib/core/common/ResourseTemplates/ListTemplate";
// or
import ListTemplate from "pulsetile-core/esm/core/common/ResourseTemplates/ListTemplate";
// and even
import ListTemplate from "pulsetile-core/src/core/common/ResourseTemplates/ListTemplate";

const VaccinationsList = ({ classes, ...rest }) => (
    <ListTemplate
        create={VaccinationsCreate}
        edit={VaccinationsEdit}
        show={VaccinationsShow}
        resourceUrl="vaccinations"
        title="Vaccinations"
        {...rest}
    >
        <TextField label="Vaccination Name" source="vaccinationName" />
        <DateField label="Date and Time" source="dateCreated" />
        <TextField label="Source" source="source" />
    </ListTemplate>
);

In all three cases it doesn't work, I had:

Could you please tell me what I do wrongly?
If it is real to import any component from total "pulsetile-core" - it is very good.

You have to export the components you cant to import so that you can do:
import { ListTemplate } from 'pulsetile-core';

Look at how react-admin does it.

need to cross reference this issue
https://github.com/PulseTile/PulseTile-RA/issues/49


Incremental imports

Grist has support for importing data, but could do a better job when re-importing updated data from the same source.

Hoping this can be implemented - for our use case (hardware asset management) we often have a need to re-import updated details into an existing table. Currently not sure how we are going to achieve this with Grist.

Forgot to say - for matching up/identifying existing records when importing you could ask the user to select the index field in the import options - this way if the value for this field in the import was the same as in the existing data then it would match with that row and update the existing data.

Hi @Chris-ISN. We've started working on incremental imports, and the initial release will work exactly as you described, with an option to select one or more fields for matching. Hoping to have that available very soon.
We have a lot of other exciting improvements we plan on bringing to incremental imports as well beyond this.

@georgegevoian This is great news. Keep up the amazing work!

Grist now has basic support for incremental imports. See the documentation for more details.


Use jekyll-include-cache

This should slightly improve build speed, but there's also slowdown due to remote_include that isn't as easily addressed.
Partially fixes #9928
This change pulls in https://github.com/benbalter/jekyll-include-cache. From the description:
"If you have a computationally expensive include (such as a sidebar or navigation), Jekyll Include Cache renders the include once, and then reuses the output any time that includes is called with the same arguments, potentially speeding up your site's build significantly."

This change is

With this change, TeamCity build generation now takes 80+ seconds, whereas before it took 100+ seconds.

On further thought, it's overzealous/unnecessary to replace all instances of include, especially for things like include_cached copy-clipboard.html. I'll attempt a second pass that's smarter instead of just blanket replacement.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3bf7fe978dd2a1ff676e15a95e33b5394b099ca9/

This seems to speed up the incremental build for me even more than for @rmloveland:
JesseS’s-MacBook-Pro:docs jesseseldess$ make standard
bundle exec jekyll serve --port 4000 --incremental --trace --config _config_base.yml,_config_cockroachdb.yml,_config_cockroachdb_local.yml
Configuration file: /Users/jesseseldess/go/src/github.com/cockroachdb/docs/_config_base.yml
Configuration file: /Users/jesseseldess/go/src/github.com/cockroachdb/docs/_config_cockroachdb.yml
Configuration file: /Users/jesseseldess/go/src/github.com/cockroachdb/docs/_config_cockroachdb_local.yml
            Source: /Users/jesseseldess/go/src/github.com/cockroachdb/docs
       Destination: /Users/jesseseldess/go/src/github.com/cockroachdb/docs/_site/docs
 Incremental build: enabled
      Generating...
                    done in 27.895 seconds.
 Auto-regeneration: enabled for '/Users/jesseseldess/go/src/github.com/cockroachdb/docs'
    Server address: http://<IP_ADDRESS>:4000/docs/
  Server running... press ctrl-c to stop.
      Regenerating: 1 file(s) changed at 2021-03-17 11:47:02
                    v21.1/add-column.md
                    ...done in 9.059219 seconds.

      Regenerating: 1 file(s) changed at 2021-03-17 11:47:19
                    v21.1/add-column.md
                    ...done in 8.368137 seconds.

LGTM once the conflict is resolved.

LGTM, thanks YZ!
This appears to speed things up by about 30% (33s -> 24s) in my very unscientific testing just now :-)
make standard
bundle exec jekyll serve --port 4000 --incremental --trace --config _config_base.yml,_config_cockroachdb.yml,_config_cockroachdb_local.yml
Configuration file: /Users/rloveland/work/code/docs/_config_base.yml
Configuration file: /Users/rloveland/work/code/docs/_config_cockroachdb.yml
Configuration file: /Users/rloveland/work/code/docs/_config_cockroachdb_local.yml
            Source: /Users/rloveland/work/code/docs
       Destination: /Users/rloveland/work/code/docs/_site/docs
 Incremental build: enabled
      Generating...
                    done in 35.663 seconds.
 Auto-regeneration: enabled for '/Users/rloveland/work/code/docs'
    Server address: http://<IP_ADDRESS>:4000/docs/
  Server running... press ctrl-c to stop.
      Regenerating: 1 file(s) changed at 2021-03-17 10:11:54
                    v21.1/spatial-tutorial.md
                    ...done in 26.824129 seconds.

      Regenerating: 2 file(s) changed at 2021-03-17 10:12:21
                    v21.1/spatial-tutorial.md
                    v21.1/.#spatial-tutorial.md
                    ...done in 26.905892 seconds.

      Regenerating: 2 file(s) changed at 2021-03-17 10:12:57
                    v21.1/spatial-tutorial.md
                    v21.1/.#spatial-tutorial.md
                    ...done in 22.116522 seconds.

      Regenerating: 2 file(s) changed at 2021-03-17 10:13:24
                    v21.1/spatial-tutorial.md
                    v21.1/.#spatial-tutorial.md
                    ...done in 24.225246 seconds.

Hi Rich, thanks for testing it out! Glad to see there's some improvement. One quick thing: Can you delete the .XXX.md temp files and see if that helps? Seems like your build might be doing double work?

FWIW, here's my output when adding --profile.
Build Process Summary:

| PHASE      |    TIME |
+------------+---------+
| RESET      |  0.0002 |
| READ       |  2.4739 |
| GENERATE   |  0.9628 |
| RENDER     | 39.2196 |
| CLEANUP    |  0.0483 |
| WRITE      |  3.4468 |
+------------+---------+
| TOTAL TIME | 46.1516 |

Site Render Stats:

| Filename                                                | Count |      Bytes |   Time |
+---------------------------------------------------------+-------+------------+--------+
| v21.1/build-a-spring-app-with-cockroachdb-jpa.md        |     1 |     69.28K |  1.605 |
| sitemap.xml                                             |     1 |    274.76K |  1.536 |
| _layouts/default.html                                   |  3143 | 433341.65K |  1.088 |
| v1.0/functions-and-operators.md                         |     1 |      2.62K |  1.052 |
| v20.2/build-a-spring-app-with-cockroachdb-mybatis.md    |     1 |     56.75K |  1.005 |
| v21.1/build-a-spring-app-with-cockroachdb-mybatis.md    |     1 |     56.75K |  0.994 |
| v1.1/functions-and-operators.md                         |     1 |      2.95K |  0.960 |
| _layouts/page.html                                      |  3142 | 110011.71K |  0.919 |
| v21.1/build-a-spring-app-with-cockroachdb-jdbc.md       |     1 |     96.22K |  0.880 |
| v20.2/build-a-spring-app-with-cockroachdb-jdbc.md       |     1 |     96.23K |  0.814 |
| v20.2/build-a-spring-app-with-cockroachdb-jpa.md        |     1 |     69.28K |  0.716 |
| v20.1/functions-and-operators.md                        |     1 |    303.01K |  0.360 |
| v2.1/functions-and-operators.md                         |     1 |    241.52K |  0.353 |
| v19.2/functions-and-operators.md                        |     1 |    257.32K |  0.347 |
| v21.1/functions-and-operators.md                        |     1 |    542.60K |  0.345 |
| v20.2/functions-and-operators.md                        |     1 |    480.04K |  0.345 |
| v19.1/functions-and-operators.md                        |     1 |    251.28K |  0.331 |
| v21.1/build-a-python-app-with-cockroachdb-django.md     |     1 |     37.90K |  0.271 |
| v20.2/build-a-python-app-with-cockroachdb-django.md     |     1 |     37.89K |  0.255 |
| v2.0/functions-and-operators.md                         |     1 |    179.48K |  0.244 |
| v21.1/build-a-ruby-app-with-cockroachdb.md              |     1 |     19.47K |  0.180 |
| _includes/copy-clipboard.html                           | 30132 |  18567.67K |  0.180 |
| v21.1/build-a-ruby-app-with-cockroachdb-activerecord.md |     1 |     21.69K |  0.176 |
| v20.2/build-a-ruby-app-with-cockroachdb.md              |     1 |     19.47K |  0.167 |
| v20.2/build-a-ruby-app-with-cockroachdb-activerecord.md |     1 |     21.69K |  0.162 |
| v21.1/build-a-java-app-with-cockroachdb.md              |     1 |     44.73K |  0.116 |
| v20.2/build-a-go-app-with-cockroachdb.md                |     1 |     20.52K |  0.101 |
| v20.1/build-a-python-app-with-cockroachdb.md            |     1 |     16.12K |  0.097 |
| v20.2/build-a-java-app-with-cockroachdb-hibernate.md    |     1 |     34.24K |  0.097 |
| v2.1/cluster-settings.md                                |     1 |     17.11K |  0.096 |
| v20.2/build-a-nodejs-app-with-cockroachdb.md            |     1 |     19.86K |  0.096 |
| v20.2/build-a-python-app-with-cockroachdb.md            |     1 |     24.35K |  0.093 |
| v21.1/build-a-go-app-with-cockroachdb.md                |     1 |     20.52K |  0.092 |
| v21.1/cluster-settings.md                               |     1 |     23.86K |  0.092 |
| v20.2/cluster-settings.md                               |     1 |     21.56K |  0.087 |
| v21.1/build-a-python-app-with-cockroachdb.md            |     1 |     24.35K |  0.086 |
| v19.1/cluster-settings.md                               |     1 |     27.19K |  0.085 |
| v20.1/build-a-nodejs-app-with-cockroachdb-sequelize.md  |     1 |     11.22K |  0.084 |
| v20.1/cluster-settings.md                               |     1 |     16.86K |  0.084 |
| v21.1/build-a-nodejs-app-with-cockroachdb.md            |     1 |     19.86K |  0.082 |
| v21.1/build-a-java-app-with-cockroachdb-hibernate.md    |     1 |     34.25K |  0.079 |
| v20.2/build-a-go-app-with-cockroachdb-pq.md             |     1 |     20.31K |  0.079 |
| v21.1/build-a-nodejs-app-with-cockroachdb-sequelize.md  |     1 |     17.78K |  0.078 |
| v21.1/build-a-go-app-with-cockroachdb-gorm.md           |     1 |     20.38K |  0.078 |
| v21.1/build-a-go-app-with-cockroachdb-pq.md             |     1 |     20.31K |  0.077 |
| v20.2/build-a-java-app-with-cockroachdb.md              |     1 |     44.74K |  0.076 |
| v20.2/build-a-nodejs-app-with-cockroachdb-sequelize.md  |     1 |     17.78K |  0.076 |
| v20.2/build-a-go-app-with-cockroachdb-gorm.md           |     1 |     20.38K |  0.076 |
| v19.2/cluster-settings.md                               |     1 |     29.44K |  0.071 |
| v20.1/build-a-nodejs-app-with-cockroachdb.md            |     1 |     13.30K |  0.063 |
+---------------------------------------------------------+-------+------------+--------+
| TOTAL (for 50 files)                                    | 36464 | 565640.26K | 17.427 |

                    done in 46.196 seconds.

Thanks @rmloveland and @jseldess for validating the changes! Would you be able to test again with the latest on branch? Fingers crossed for a bit more improvement.

Thanks for the output, @ianjevans! It does look like a lot of pages that use remote_include to me.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4ade96fd4e7b96957c1be1c72ee52c519ee28179/
Edited pages:

v20.2/build-a-go-app-with-cockroachdb-gorm.md
v20.2/build-a-go-app-with-cockroachdb-pq.md
v20.2/build-a-go-app-with-cockroachdb.md
v20.2/build-a-java-app-with-cockroachdb-hibernate.md
v20.2/build-a-java-app-with-cockroachdb.md
v20.2/build-a-nodejs-app-with-cockroachdb-sequelize.md
v20.2/build-a-nodejs-app-with-cockroachdb.md
v20.2/build-a-python-app-with-cockroachdb-django.md
v20.2/build-a-python-app-with-cockroachdb.md
v20.2/build-a-ruby-app-with-cockroachdb-activerecord.md
v20.2/build-a-ruby-app-with-cockroachdb.md
v20.2/build-a-spring-app-with-cockroachdb-jdbc.md
v20.2/build-a-spring-app-with-cockroachdb-jpa.md
v20.2/build-a-spring-app-with-cockroachdb-mybatis.md
v20.2/functions-and-operators.md
v21.1/build-a-go-app-with-cockroachdb-gorm.md
v21.1/build-a-go-app-with-cockroachdb-pq.md
v21.1/build-a-go-app-with-cockroachdb.md
v21.1/build-a-java-app-with-cockroachdb-hibernate.md
v21.1/build-a-java-app-with-cockroachdb.md
v21.1/build-a-nodejs-app-with-cockroachdb-sequelize.md
v21.1/build-a-nodejs-app-with-cockroachdb.md
v21.1/build-a-python-app-with-cockroachdb-django.md
v21.1/build-a-python-app-with-cockroachdb.md
v21.1/build-a-ruby-app-with-cockroachdb-activerecord.md
v21.1/build-a-ruby-app-with-cockroachdb.md
v21.1/build-a-spring-app-with-cockroachdb-jdbc.md
v21.1/build-a-spring-app-with-cockroachdb-jpa.md
v21.1/build-a-spring-app-with-cockroachdb-mybatis.md
v21.1/functions-and-operators.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/22008ca5239582b65463dcb5acea5e8aeb92c57a/
Edited pages:

v20.2/build-a-go-app-with-cockroachdb-gorm.md
v20.2/build-a-go-app-with-cockroachdb-pq.md
v20.2/build-a-go-app-with-cockroachdb.md
v20.2/build-a-java-app-with-cockroachdb-hibernate.md
v20.2/build-a-java-app-with-cockroachdb.md
v20.2/build-a-nodejs-app-with-cockroachdb-sequelize.md
v20.2/build-a-nodejs-app-with-cockroachdb.md
v20.2/build-a-python-app-with-cockroachdb-django.md
v20.2/build-a-python-app-with-cockroachdb.md
v20.2/build-a-ruby-app-with-cockroachdb-activerecord.md
v20.2/build-a-ruby-app-with-cockroachdb.md
v20.2/build-a-spring-app-with-cockroachdb-jdbc.md
v20.2/build-a-spring-app-with-cockroachdb-jpa.md
v20.2/build-a-spring-app-with-cockroachdb-mybatis.md
v20.2/functions-and-operators.md
v21.1/build-a-go-app-with-cockroachdb-gorm.md
v21.1/build-a-go-app-with-cockroachdb-pq.md
v21.1/build-a-go-app-with-cockroachdb.md
v21.1/build-a-java-app-with-cockroachdb-hibernate.md
v21.1/build-a-java-app-with-cockroachdb.md
v21.1/build-a-nodejs-app-with-cockroachdb-sequelize.md
v21.1/build-a-nodejs-app-with-cockroachdb.md
v21.1/build-a-python-app-with-cockroachdb-django.md
v21.1/build-a-python-app-with-cockroachdb.md
v21.1/build-a-ruby-app-with-cockroachdb-activerecord.md
v21.1/build-a-ruby-app-with-cockroachdb.md
v21.1/build-a-spring-app-with-cockroachdb-jdbc.md
v21.1/build-a-spring-app-with-cockroachdb-jpa.md
v21.1/build-a-spring-app-with-cockroachdb-mybatis.md
v21.1/functions-and-operators.md

yingzhuchin @.***> writes:

Hi Rich, thanks for testing it out! Glad to see there's some
improvement. One quick thing: Can you delete the .XXX.md temp files
and see if that helps? Seems like your build might be doing double
work?

I think you are right - Emacs is auto-creating these .XXX.md temp save
files and then really quickly deleting them when I actually save my
edited file.  So I never see them because they disappear but Jekyll's
file watcher must be seeing them!
So in other words my build is slow and it's kinda my own fault. But I
thank you for speeding things up for me anyway! :-}

Thanks Rich! Merging.