Lost my combos unexpectedly - and hadn't backed up!

I wasn't expecting to lose the combos
They all disappeared: no restart, no PC crash, the only event was resetting Microsoft Outlook 365 password.
Beeftext version 11.1 for Windows 10 desktop PC
I will backup from now on - maybe worth highlighting the risk?

First time I hear about such problem since one of the very first beta.
There is an auto-back mechanism that keeps tracks of the last 50 modifications  (Files➜Preferences➜Advanced➜Automatic backup).
You can also try to locate the combo list file using the Windows file search. it's a text file named comboList.json.

Sorted thanks. Found them
I think the cause was a Microsoft issue not a Beeftext problem


fix(client): fix attribute error when skip uploading frame

Pull Request Test Coverage Report for Build 857149139

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.804%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/client/dataset.py
0
2
0.0%

Totals

Change from base Build 857103318:
0.0%

Covered Lines:
4243

Relevant Lines:
5251

💛  - Coveralls


Roadkill - publish new version

Benefit
Latest version with recent changes and any bug fixes.
Acceptance Criteria
Investigate these:

[x] https://github.com/agrc/roadkill-mobile/issues/311
[x] https://github.com/agrc/roadkill-mobile/issues/312

And these:

It's one button click to publish on google play since it's already passed the review process. But I'm still a little worried.

There also is an issue with the apple review. When they tried to login with facebook it came up in some asian looking language.

Publish to app stores
Notes
No response
Risks
Can of worms
Issue Reference
refs #

v3.0.10 (644) has been published to both app stores.


Add method to make instance of Illuminate\Http\Request for testing

Sometimes maybe you should pass instance of request to test any class such as middleware. This PR adds a method for make instance of  Illuminate\Http\Request to inject any class.
Before This PR :
$middleware = app(UserBannedMiddleware::class);

$request = Request::createFromBase(SymfonyRequest::create(
            '/panel',
            'GET',
        ));

$response = $middleware->handle(
            $request,
            fn () => new Response()
);

After this PR
$middleware = app(UserBannedMiddleware::class);

  $response = $middleware->handle(
            $this->createRequest('get', '/'),
            fn () => new Response()
);

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

We would probably want to be able to provide further data like headers, content, etc.


#560 - my observations - over-scroll header bug fix

@kueda - I think I can make it a conditional state update - meaning, trigger the state update using a debounce (not on every update) + only update in case of over-scroll (when scrolling past the top of the list)


[HELP] svgAsPngUri() not working - need help for usage

I am unable to store the svg image in the server with the specified uri , please guide me how to use it
Thanks

This library isn't designed for server-side creation of PNGs. It relies on in-browser functionality for downloading images.
If you're creating a PNG data URI in-browser and sending it to the server, you'll need to convert the data URI into a binary file. How to do that will depend on the platform/language, and is out of scope for this library.


Retry based on result, e.g. HTTP status 404 during webservice call

Is it possible to retry based on the actual return value? I want for example to retry if my returned response object contains an HTTP status of 404.
Response responseEntity = Failsafe.with(retryPolicy)
    .onFailedAttempt(ex -> log.warn("HTTP POST ({}) failed: '{}'", webTarget.getUri(), ex.getMessage()))
    // fail if responseEntity.getStatus() == 404
    .get(() -> webTarget.request().post(Entity.entity(form, MediaType.APPLICATION_FORM_URLENCODED_TYPE)));

int status = responseEntity.getStatus(); // might be 404

That's what retryIf(Predicate) is for

Can you give me an example? I suppose I need to cast the object somehow?

new RetryPolicy()
    .retryIf((Response response) -> {
        if (!response.isSuccessful()) {
            // Close the body if its not successful
            response.close();
            return true;
        }
        return false;
    })
    .withBackoff(500, 5000, TimeUnit.MILLISECONDS)
    .withMaxRetries(3);

Thanks, works like a charm!


366 selecteditem binding is not working in list view

If selected item is preselecting with dynamic binding its not showing as selected item in UI.

In Android, it works as expected when the default selected item is set and shows the highlighted color. In Windows, it's not working as expected since Itemsource and templetedItems is null


YouTube: Add preference for primary action

Description
Add preference that a user can choose if he/she prefer the browser or show details actions. The default is still show details.
User request from Daniel Post via Slack.
Type of change

Bug fix / improvement for my extension

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I checked that extension's icon has size of 512x512

Is this only working for Search Videos, if yes, then it could be added as a preference only for that command instead?

Is now also available for channels.
Please try out the new impl. about the recent search, should be better now (hopefully).

When searching for "flyf" under search videos this happens

I could not reproduce that. For me that search term works fine.


Repository environment creation fails on private Teams repos

This is related to the discussion on the https://github.com/integrations/terraform-provider-github/issues/1262
In June GitHub made the environments and environment protection rules generally available, however, the wait_timer and  reviewers remains limited to enterprise.
Many developers would like to make use of this great new feature, but the bug in the Terraform provider currently proves to be a blocker.
The provider uses the go-github Go library under the hood and makes the following call:
_, _, err := client.Repositories.CreateUpdateEnvironment(ctx, owner, repoName, escapedEnvName, &updateData)

where the &updateData is a github.CreateUpdateEnvironment struct.
Looking at the code it seems that instead of sending nil value for wait_timer it defaults to 0.
// CreateUpdateEnvironment represents the fields required for the create/update operation
// following the Create/Update release example.
// See https://github.com/google/go-github/issues/992 for more information.
// Removed omitempty here as the API expects null values for reviewers and deployment_branch_policy to clear them.
type CreateUpdateEnvironment struct {
	WaitTimer              *int            `json:"wait_timer"`
	Reviewers              []*EnvReviewers `json:"reviewers"`
	DeploymentBranchPolicy *BranchPolicy   `json:"deployment_branch_policy"`
}

This is causing the issue for us, as the API doesn't expect this parameter and returns 422.
I understand why the omitempty was removed, so I'm looking at what alternative solutions are possible to ensure environments fully work regardless of the payment plan.

Please read #2467 and see if that answers your questions.

@gmlewis do you mean creating separate endpoints based on pricing plan (one for teams/pro where wait_timer is not sent, and one for enterprise where wait_timer defaults to 0 if not set)?
I'm still checking in the TF provider if it's possible to access the pricing plan to decide which endpoint to call.
If not, we might have to call the enterprise endpoint first, and if it returns 422 make an attempt to call the teams endpoint. However, in this case, would it not be better to make a retry attempt here, rather than downstream?

Hi @AnitaErnszt - honestly, I don't know what the best answer is. I also no longer have access to GitHub Enterprise, so it makes it very challenging to experiment and further investigate.
Maybe others who also use GitHub Enterprise might be able to comment?


Epson projector support

Description:
I created epson projector support.
It is based on Android app (packet sniffing) from epson.
Tested with Epson EH-TW5350
Made new PR to get rid of mistakes I made trying to catch up with reality.
Old PR: https://github.com/home-assistant/home-assistant/pull/13416
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#5005
Example entry for configuration.yaml (if applicable):
- platform: epson
  host: <IP_ADDRESS>
  name: Epson Projector

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

Tests passed but needed to change test_feedreader.py date time from 5 to 6.
datetime(2018, 4, 30, 6, 10, 0)

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Merge conflict resolved.

All requested changes are done.

All reviewed changes done.

done


[Task][admin refactor] < API document storage strategy adjustment: from local cache to database persistence.>

Description
Disadvantages of local cache: when the admin cluster is deployed, large objects need to be stored on each instance, and the problem of how to synchronize cluster instances is additionally introduced. After comprehensive evaluation, the method was abandoned.
Task List
API document storage strategy adjustment: from local cache to database persistence.

I will complete this function.


[2.x] refactor: Remove sbt 0.13 in methods

Fixes https://github.com/sbt/sbt/issues/7702
Problem
See https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#Migrating+to+slash+syntax
We should remove scalacOptions in (Compile, console) notation. This was deprecated in https://eed3si9n.com/sbt-1.5.0.
Solution
This renames in to rescope for internal usage, and ports the usages to slash.

yay!!


De-duplicate stickers in output

Feature Description

Stickers in the final story content are simply inline <svg> elements.
When using the same sticker multiple times in a story, which happens frequently in templates, this will result in the same <svg> the page repeatedly. Since some stickers are quite large in file size, this unnecessarily bloats up the document.
We could use <defs> to define these SVG paths only once and then use <use> where the sticker is needed. This way, sticker SVGs are de-duplicated and the response size is decreased. This could improve performance as well.
Props to @divyarajmasani for the idea.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

In OutputStory, add a new function similar to getFontDeclarations or getPreloadResources to go through all sticker elements, get the sticker contents  and then assemble one SVG with <defs>
In StickerOutput, only return a simple SVG with <use> in it

@littlemilkstudio @choumx any thoughts on this proposal? Could there be negative effects?

I think we should do some profiling first to measure the expected benefit (generally this should be done for any performance intervention).
A quick search suggests that we may be surprised by the answer, see this old StackOverflow answer: https://stackoverflow.com/questions/8604999/does-reusing-symbols-improve-svg-performance


fix: extract VRF to a plugin

..in order to remove crypto deps from the core sdk and reduce bundle size.

fixed within https://github.com/warp-contracts/warp/pull/401


CCLA Support

Are there any plans to support CCLA's at any point, instead of just a CLA?

I'm not familiar with CCLA, can you unpack that a little? On a general level I'm happy to accept pull requests with new features. Otherwise if there is demonstrated community need/want for them I can put them in my docket with the understanding that since I only have so much time budgeted to CLAHub non-bug requests often will take longer for me to handle.

A CLA is for an individual contributor, but a CCLA is for a company who's individuals will be contributing on behalf of the company.  There's a whole different set of concerns when development is done as part of a company initiative.
http://oss-watch.ac.uk/resources/cla#corporate-contributor-licence-agreements


[NuGet.org Bug]: 400 Bad Request on Deprecate Request (extended-ASCII)

Impact
It's more difficult to complete my work
Describe the bug
It appears that URI Data Escape (or URL Escape) is happening for extended-ASCII characters (e.g.: ö -- in this case) in NuGet package names, when they are selected for being marked as deprecated on the website. This can be seen in the id field of the payload that's being sent to nuget.org (see screenshot).
However, the alternatePackageId package name field is not escaped; which shows inconsistent behaviour - especially, if these fields are passed as URI parameters.
As a result, this causes a 400 Bad Request error, which manifests as An unknown error occurred when submitting the form. on the website.
Repro Steps
Steps to reproduce:

Create a NuGet package with extended-ASCII characters (e.g.: Möò).
Create a second NuGet package as a replacement for the first (e.g.: Møö)
Publish the NuGet package to NuGet.
Use the website to try to disable all versions of the package from step 1, noting the package in Step 2 as the replacement -- noting the name of the package in the id and alternatePackageId fields, after receiving the 400 Bad Request.

Expected Behavior
The request to deprecate all versions of the package should succeed.
 If yes then please let's know.

I was able to repro this issue in dev. I haven't dug too deep into root causing yet, but I can confirm that it is reliably reproducible using the steps provided.

I was able to repro this issue in dev. I haven't dug too deep into root causing yet, but I can confirm that it is reliably reproducible using the steps provided.

Thank you. I'll follow up about prioritization.

Hey @felsokning, I have a workaround you can try, if you are interested. I am working on bringing https://github.com/NuGet/NuGetGallery/issues/8873 (an API to deprecate package) to a public preview. It's not there yet. But I can enable your user account for a private preview. It tried these extended-ASCII characters on the API and it appears to work just fine. I tried ö in the package ID, the alternate ID, and the message.
I've found your NuGet.org username as the owner of the package IDs mentioned in your error report and enabled this user account for the deprecation API.
The pre-release API docs are here:
https://review.learn.microsoft.com/en-us/nuget/api/package-publish-resource?branch=pr-en-us-2959#deprecate-or-undeprecate-a-package
You can use PowerShell, cURL, or whatever HTTP client you want to submit the request.
I have a .NET tool I wrote (not release by the team, my own proof-of-concept) that you can try if you don't want to script it yourself.
https://www.nuget.org/packages/Knapcode.PackageLifeCycle#readme-body-tab
You need an API key with the "unlist" scope.
I'd love to hear if you are successful with the API or if you have any feedback/ideas/suggestions. Feel free to post your feedback publicly on the deprecation API issue (https://github.com/NuGet/NuGetGallery/issues/8873) or email me directly jver [at] microsoft [dot] com (whichever you prefer).


The device model used in an example doesn't work (dtmi:com:example:TemperatureController;2)

The document  demonstrates a DTDL V2 capability used in the IoT Central on the example for device model dtmi:com:example:TemperatureController;2.
I have tried to import this device model using a multiple ways such as a device provisioning, importing directly from the https://raw.githubusercontent.com/Azure/iot-plugandplay-models/main/dtmi/com/example/temperaturecontroller-2.json or pasted to the empty device template, but without any success result.
It looks like, the IoT Central doesn't support a schema referencing outside of the contents, like it is required in this device model:
  {
  "@type": "Component",
  "displayName": {
    "en": "thermostat1"
  },
  "name": "thermostat1",
  "schema": "dtmi:com:example:Thermostat;1"
},
{
  "@type": "Component",
  "displayName": {
    "en": "thermostat2"
  },
  "name": "thermostat2",
  "schema": "dtmi:com:example:Thermostat;2"
},
{
  "@type": "Component",
  "displayName": {
    "en": "DeviceInfo"
  },
  "name": "deviceInformation",
  "schema": "dtmi:azure:DeviceManagement:DeviceInformation;1"
}

So, is this the IoT Central limitation for DTDL V2 spec or a bug?
Thanks
Roman
p.s.
I will appreciate if the IoT Central allows to import the device model also based on the modelId.  Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eeefa5e3-11cc-08d8-a079-c5c14ca2181c
Version Independent ID: f7afed90-0ade-3110-a8a3-675c1486ea74
Content: What are device templates in Azure IoT Central
Content Source: articles/iot-central/core/concepts-device-templates.md
Service: iot-central
GitHub Login: @dominicbetts
Microsoft Alias: dobett

@romankiss Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.


Export Worker

Argh still connected to this dead repo

@kungfooman  Sorry, took a break from Open Source while working on another thing. This repo is still active, however this PR breaks almost everything except 1 use case. I'm glad you got your use case working, though. This interface behaves as it should until there is basic (real) worker support inside workers at which point it will be a compatibility shim.
If you want a solution using guy bedford's shim, you don't need any of the code here for that and intermingling the 2 very different soultions to that will not do you any favors. You either want perf at the cost of maintainability (using a secondary interface and requiring build ) or you want the opposite (long term maintainability at the cost of perf). trying to straddle the two does you no favors.
Your event enhancements would be welcome as an isolated PR which passes the existing tests which include chrome, firefox, safari and node. Thanks for your interest.

Hey @khrome, interesting marker engine! So funny that I just did a lot of rewriting of the Cannon.js engine aswell :eyes:
My main use case is Transformers.js and the iframe approach unfortunately doesn't work (HTTP Request cache doesn't work), so I had to use approach using Guy Bedform's shim, which supports cache.
I have my fixes to the event handler etc. here: https://github.com/kungfooman/worker-with-import-map/blob/master/src/WorkerWithImportMapViaInlineFrame.js
I'm working on something else currently and consider my work with this basically done, but you can take whatever you need as direct copy or inspiration etc.
Thank you a lot for this library though! It kick started me in the right direction. :heart:


Show Internet connection error

when there is no internet connection, show error message

@Ijaiswalshivam assign me

Asssign me @Ijaiswalshivam and i have also fixed that in notification Decrypt error , just pr generate is pending


Illegal reflective access by org.springframework.util.ReflectionUtils

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.springframework.util.ReflectionUtils (file:/C:/Users/I551448/.m2/repository/org/springframework/spring-core/5.3.8/spring-core-5.3.8.jar) to constructor java.text.DateFormat()
WARNING: Please consider reporting this to the maintainers of org.springframework.util.ReflectionUtils
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Any ideas??

You need to ask at https://github.com/spring-projects/spring-framework as they maintain org.springframework.util.ReflectionUtils

not related to guice at all


Turn it into a Spin component

It's currently WAGI; for now I'm doing minimal change, but it would be nice to make it fully Spin.

Implemented in https://github.com/fermyon/spin-redirect/pull/6.
We should call out this change in the next release; users will need to update their usage (eg remove executor = { type = "wagi" })

@vdice is that going to mean a template change too

@itowlson Ah, thank you, yes!  Shall I create an issue in spin for this?

Thanks - yeah not sure the best place to record the issue - the change needs to be at the same time as we switch the Spin template over to the new redirect version - maybe an issue in the Spin repo to update template to point to the new release when available, and we could capture the executor thing there?  Not sure sorry


Add Python 3.8 to CI

Describe the problem

We should test Python 3.8 in the CI and master builds. Recently, several issues have popped up related to Python 3.8 specifically, so it's good to test. I'm hesitant to add prior to the next release because I just did a big overhaul of the CI and GitHub Actions seems to be throttling the builds.

Inherited from #853

Python 3.8 is not supported by Ray

We are testing Python 3.8 in CI now.


Inline style fix & custom colors enhancement for RaisedButton

Custom inline styles would not work for certain elements that were contained inside a toolbar, this is fixed.
Also, I've added custom color overrides for the RaisedButton, for both the label and background and seperate options for when the button is disabled.

Thanks @alshain !


WEBPACK_IMPORTED_MODULE_0_tslib.a is not a function

What is the current behavior?
Not sure if this is more related to @angular or webpack:
After upgrading to webpack 3.0.0 I'm getting runtime error in @angular/core. Webpack 2.6.1 works fine.
This is the error:
 TypeError: __WEBPACK_IMPORTED_MODULE_0_tslib__.a is not a function
    at core.es5.js:70
    at Object.<anonymous> (core.es5.js:82)
    at Object.c (core.es5.js:14812)
    at __webpack_require__ (bootstrap 5ebe633…:695)
    at fn (bootstrap 5ebe633…:116)
    at Object.VENDOR_PREFIXES (vendor.js:130945)
    at __webpack_require__ (bootstrap 5ebe633…:695)
    at fn (bootstrap 5ebe633…:116)
    at Object.defineProperty.value (vendor.js:130930)
    at __webpack_require__ (bootstrap 5ebe633…:695)
    at webpackJsonpCallback (bootstrap 5ebe633…:25)
    at vendor.js:1

the core.es5.js contains this import statement:
import * as tslib_1 from "tslib";
and webpack 3 seems to have a problem loading this module.
tslib module is located in my node_modules
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Windows 10
node 6.10.0
webpack 3.0.0
@angular 4.2.2

Thanks for your report. It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

After upgrading @angular to version 4.2.4 this problem seems to be gone.


feat(design-system): Add scroll component

I couldnt find a way to style the hover color in firefox, I mean, in chrome you can change the color when you hover the scrollbar itself but for firefox I couldn't find a way to do it, so the scrollbar will change the color when you hover in an x-scroll in any of it parts.
Another thing that I am not sure it is if we should use, scrollbar-gutter.  Can I Use
EX-7956

Hi! I have been checking this article about using CSS @supports to target browsers. Could it be worth using it for only Firefox styles?
On the other hand, scrollbar-gutter seems to be a nice approach, although Safari doesn't support it.


Task - Beginning of chat shown after reassigning task from user you have no chat to recent user

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.53-2
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team
Action Performed:

Open the app and log into the account you have multiple chats
Navigate to a user from the recent contacts
Tap the "+" > Assign task
Enter the task name and proceed to the next screen
Tap "Assignee" and search for a user you have not messaged yet
Assign the task to that user
Tap the "Assignee" again and reassign the task to the same user you are sharing it with
Create the task

Expected Result:
The task is displayed as the last message in the report
Actual Result:
A duplicated beginning of the report is displayed, sometimes task is shown as the first message
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/d49baaf6-21e3-43fd-9ca5-40d449985c91
View all open jobs on GitHub

@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #vip-vsb

Proposal
Please re-state the problem that we are trying to solve in this issue.
Task - Beginning of chat shown after reassigning task from user you have no chat to recent user
What is the root cause of that problem?
when we select assignee we call setAssigneeChatReport.
https://github.com/Expensify/App/blob/e40fba13be231a88c76f789ac94c4a65ec34f280/src/libs/actions/Task.ts#L660
which merge the value with the old value.
https://github.com/Expensify/App/blob/e40fba13be231a88c76f789ac94c4a65ec34f280/src/libs/actions/Task.ts#L623-L625
the root cause is the merge leed to  merge ReportUtils.buildOptimisticChatReport  for new user with ReportUtils.getChatByParticipants for user chated before and this add optimistic fields like isOptimisticReport to the old report
What changes do you think we should make in order to solve the problem?
we need to reset the old value of assigneeChatReport before merge the new value here.
https://github.com/Expensify/App/blob/e40fba13be231a88c76f789ac94c4a65ec34f280/src/libs/actions/Task.ts#L623-L625
we can do that by set it to null then set to the new value.
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
A duplicated beginning of the report is displayed, sometimes task is shown as the first message
What is the root cause of that problem?
When we select an assignee that is a new user, we create an optimistic report here and set it to assigneeChatReport. After we re-select a recent contact, another chat report is set to assigneeChatReport but other fields like isOptimisticReport, pendingFields are in-correct because we merge from old assignee report.
https://github.com/Expensify/App/blob/c915e7f026eddc710dd01a38abc3afc9334002ae/src/libs/actions/Task.ts#L660
And then a created action is created here.
https://github.com/Expensify/App/blob/c915e7f026eddc710dd01a38abc3afc9334002ae/src/libs/ReportUtils.ts#L4813-L4814
What changes do you think we should make in order to solve the problem?
Instead of storing assignReport in task data, we can store the assigneeChatReportID which is the ID of chat report and then get the correct data from Onyx to check here.
https://github.com/Expensify/App/blob/c915e7f026eddc710dd01a38abc3afc9334002ae/src/libs/ReportUtils.ts#L4813-L4814
I checked all use of task.assigneeChatReport and saw that it's only used when we create the task. So we can only store the reportID of chat report and then get the report data from Onyx correctly.
What alternative solutions did you explore? (Optional)

Updated the issue title and description for clarify.

Reviewing today

I'm not able to reproduce this one on latest main :/
https://github.com/Expensify/App/assets/16502320/6e9386b9-459a-4933-9cf9-e383c03bd5cc

Tap "Assignee" and search for a user you have not messaged yet

@hungvu193 You should search and select a new user first that is important step to reproduce this bug.

Tap "Assignee" and search for a user you have not messaged yet

@hungvu193 You should search and select a new user first that is important step to reproduce this bug.

Thank you, I'll try to reproduce today

Ok, I can reproduce.
https://github.com/Expensify/App/assets/16502320/fa7e5fd7-cb1f-4083-b62a-2e9e61160353
But I couldn't reproduce the issue once it already happened with that report. Here's the steps to test:

Open the app and log into an account where you have multiple chats
Navigate to a user from the recent contacts
Tap the "+" > Assign task
Enter the task name and proceed to the next screen
Tap "Assignee" and search for a user you have not messaged yet
Assign the task to that user
Tap the "Assignee" again and reassign the task to the same user you are sharing it with
Create the task => Saw the issue
Reload the app
Repeat step 3 to 8.

My question is can you guys still the see issue with my above reproduction steps? If not, why did it only happen the first time, since both proposals pointed out that we're using wrong optimistic data. Thank you.

@hungvu193

why did it only happen the first time

https://github.com/Expensify/App/blob/e40fba13be231a88c76f789ac94c4a65ec34f280/src/libs/actions/Task.ts#L636-L638
this because we build optimistic chat report only if chatReport gotten by getChatByParticipants not found.
And after that the chatReport = ReportUtils.getChatByParticipants is already exist, so no need to build optimistic chat again

@hungvu193 After the first time, isOptimisticReport of the chat report is updated to false and then if we repeat the step again, isOptimisticReport will be updated correctly in assigneeChatReport because isOptimisticReport is updated correct.
https://github.com/Expensify/App/blob/eba217fcdba3cdfae0fdfadf102fc3b73d3c9129/src/libs/ReportUtils.ts#L5003

Thank you both and sorry for late reply, I was sick last few days, but it's close to select proposal.

@nkdengineer 's alternative proposal here looks good to me. It has correct RCA and solution 🎀 👀 🎀  C+ reviewed.
Thanks @ahmedGaber93, your solution worked but I prefer correct falsely fields rather than do another merge to update task value.

@hungvu193 I think reverse the attribute that cause the issue will solve the current issue, but other similar issues may arise in the future during merge.
My proposal try to fix the root cause, and prevent similar issues in the future.

@hungvu193 I think reverse the attribute that cause the issue will solve the current issue, but other similar issues may arise in the future during merge. My proposal try to fix the root cause, and prevent similar issues in the future.

As I said earlier, the issue here that we've been using wrong optimistic data, so I expect a solution that aims to fix the optimistic data rather than reset it, then merge it. Your solution will always set task to null for every setAssigneeValue called, I don' think that's a good idea. Anyway, that's just my opinion, I'll let @srikarparsi decide. Thanks for your patience 😄

Your solution will always set task to null for every setAssigneeValue called, I don' think that's a good idea.

No, it will set only assigneeChatReport not task to null while replace it from optimistic report (not exist chat) to exist chat report.
here similar case, we set the optimistic report to null before replace it with the real value.
Thanks for your patience.

Your solution will always set task to null for every setAssigneeValue called, I don' think that's a good idea.

No, it will set only assigneeChatReport not task to null while replace it from optimistic report (not exist chat) to exist chat report. here similar case, we set the optimistic report to null before replace it with the real value. Thanks for your patience.

I got your point here, but if you take a look, you can see we used Onyx.set there, which to deleted the optimistic data and we also recommended to use set when you want to delete data completely, but we can't use set here, since we shouldn't combine merge and set together. Also merge are batched, so it will cause another re-render.
Also the case you mentioned is a little different with this issue, in here we already knew that our current optimistic data was wrong so we deleted it and loaded the server response later when we navigated user to that report. In our case, we have valid chat report, we just need to adjust to make sure isOptimisticReport is updated correctly.

you are right about Onyx.setthere.
But here

In our case, we have valid chat report, we just need to adjust to make sure isOptimisticReport is updated correctly.

I think in our case we merge two different reports, the first for userA and is optimistic and the second is for userB one is real.
and here we use Onyx.merge which may keep attributes from one of them into the other, I know we can't use Onyx.set in this case, so my proposal was to merge assigneeChatReport to null then merge second report.
In any case, the decision is yours and the internal developer's.
Thanks!

Hey, is this issue still reproducible? Am I missing a step?
https://github.com/Expensify/App/assets/48188732/483c603e-eeef-4306-9a3c-620d25de2ae8

I still can reproduce
https://github.com/Expensify/App/assets/16502320/b66e162a-a424-404e-852d-a55796680bfe
Tips: I used high traffic account and choose a random account on the list that I've never chatted before

I also can reproduce in the last main.
https://github.com/Expensify/App/assets/41129870/ba6bcf04-55be-4944-969b-3b2bfd3c85e0

In this case, the report data in Onyx is correctly, we only have the problem with assigneeChatReport.  it's used to create new created reportAction if the report is new report and doesn't update anything to report data so we only need to verify that this will display correct in assign task flow and the logic to create report action will be correct.
To not have any concern about saving assigneeChatReport, we also can do with my main solution to only store assigneeChatReportID and then get the correct data in Onyx.

Cool just looked over everything. I also like @nkdengineer alternate solution since it's more straightforward and is better for performance without the double merge.

@hungvu193 The PR is here.

Summarizing payment on this issue:
Contributor: @nkdengineer $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/101873781)
Contributor+: @hungvu193 $500, paid via Upwork
@hungvu193 could you please complete the BZ checklist?

Paid @nkdengineer, just waiting on the checklist now.

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/22778
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22778/files#r1566611957
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug: No

This is an edge case, so I don't think we need regression test for this one.

Thanks!


docs: Add Detailed Guide for Filtering in User Space

Fixes #3388
Enhance Documentation: Add Detailed Guide for Filtering in User Space
This PR updates the "Filtering in User Space" section of the documentation by providing a comprehensive guide on how to use the --filter flag in the ig command. The new content includes a description of the filter syntax, covering operations such as ==, !=, >=, <=, <, >, and ~. Additionally, practical examples are provided to help users understand how to apply these filters in various scenarios.
The enhancement aims to make it easier for users to utilize the filtering functionality effectively, enabling them to narrow down command outputs based on specific criteria.
How to use

Review the updated "Filtering in User Space" section in the documentation.
Verify the accuracy and clarity of the examples provided for each filter operation.
Ensure that the documentation aligns with the current functionality of the --filter flag as described in the ig command's help output.

This looks fine, would you mind rebasing against main, then I'll approve and merge it.


Added Static Maps API

This is my attempt to add in the Static Maps API to node-googlemaps. There are some hackish ways of dealing with the sub-parameters for the optional API parameters, and the test seems to be a bit backwards. I'm sure this could use a second set of eyes and some cleaning up. But overall the API works, as you'll see by consulting the updated README.
Let me know if you have any questions or concerns. I'd be happy to answer.
Glad to contribute!

Looks good!  I'll merge into develop ( and probably roll a new version ) when I have a few minutes.  Thanks

Sure. If you have any criticisms/suggestions, please feel free to send them
my way. I'd appreciate any feedback you have to give.
On Mon, Nov 28, 2011 at 8:36 PM, Colin <
<EMAIL_ADDRESS>
wrote:

Looks good!  I'll merge into develop ( and probably roll a new version )
when I have a few minutes.  Thanks

Reply to this email directly or view it on GitHub:
https://github.com/moshen/node-googlemaps/pull/8#issuecomment-2910793

I was poking at your code and was wondering where the "paths" var is supposed to come from?

Whoops. It should be an optional parameter after styles.
I'm not super happy about the way I'm doing those optional params, so if you have a better approach, I'm all ears. I'm in the #node IRC a lot, btw.

Any further thoughts on this? Want me to update that paths var?

Sorry for the lack of communication, I've been working on another project in my free time lately.  I have a cleaned up version in my local repo, I'll push to develop and get back at you ( hopefully later tonight ).

Thanks! Not a problem.

Pushed to develop , added the paths var, fixed the test.  I made some style fixes, also added some var declarations.  I will probably remove the callback for the method since there is no IO happening, and maybe add another method to actually retrieve the static map image data.

Awesome. I'm looking forward to seeing it in action. Apologies for all the work you had to do on my pull. I'm only about a week into Node, so still muddling my way through.

No problem.  I would suggest installing jshint ( or jslint ) and running it against some of your code.  If you have npm installed, just do: npm install jshint
I would also suggest doing some light reading on javascript.  Maybe start with http://bonsaiden.github.com/JavaScript-Garden/#function.scopes ;)
And move onto something like: Javascript: The Good Parts - http://www.amazon.com/JavaScript-Good-Parts-Douglas-Crockford/dp/0596517742/ref=pd_sim_sbs_b_1
I'm going to close this pull req, but feel free to ping me.


doesn't work on debian 7.8

executing bin in rootdir:
bin/net: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by lib/libbsd.so.0) bin/rpcclient: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by lib/libbsd.so.0)
bin/smbclient: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by lib/libbsd.so.0) bin/smbget: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by lib/libbsd.so.0)
bin/winexe: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.14' not found (required by lib/libbsd.so.0)
debian 7.8 ships with libc 2.13
executing bin in bin/ dir:
./net: error while loading shared libraries: libkrb5-samba4.so.26: cannot open shared object file: No such file or directory
./smbclient: error while loading shared libraries: libpopt_samba3.so: cannot open shared object file: No such file or directory
./smbget: error while loading shared libraries: libuid_wrapper.so: cannot open shared object file: No such file or directory
cannot find this .so in standard debian repo.
resolution like "i don't support debian" is accepted :)
thanks

just making sure but you are running the sh scripts and not the actual binaries right?

first chunk of errors came from scripts in  ~/pth-toolkit/
for example, ~/pth-toolkit/pth-net, the shell script
second chunk is from script in ~/pth-toolkit/bin
for example ~/pth-toolkit/bin/net
I can provide a script(1) logfile if it helps

sure that would be great

http://pastebin.com/Mi6k769k

@theguly your running debian with the standard kernel and repos?

yessir

@theguly ok will fire up a vm later today .. i should probably be able to get this working for ya

@theguly just a quick update: ive manged to get winexe, wmis, and wmic working on debian , the rest of the utilities will be trickier but ill keep trying.
The problem is that debian wheezy ships with libc 2.13 and the utilities require > 2.14

as soon as i get all of them working i'll update the repo

thanks :)
hope i'm not the only one who use debian...

@theguly ideally i would want this to work on every possible *nix system so doesn't really matter what distro your running

hey @theguly i created a branch called debian-fix with the changes.. still haven't managed to get the smb related utilities working but as i said wmic, wmis and winexe work


Command "/lifesteal set" does not work.

When you try to execute that command exactly like it says, in my case I did:
/lifesteal set EditChris 20
...the command does not do anything. It displays the "commandUsage" message from the config file, and that's it. I tried to execute it on different ways to see if maybe the message was outdated or something, but nothing.

Syntax of the set command has changed in the v1.6.2 release - here is the list taken from the spigot's resource page:

/lifesteal health add  <health_points> - adds health points as a maximum health for the specified player
/lifesteal health remove  <health_points> - subtracts health points as a maximum health for the specified player
/lifesteal health set  <health_points> - sets health points as a maximum health for the specified player


Why /dev/sdb is so full but I haven't installed many things in my wsl2 ?

Version
Microsoft Windows [Version 10.0.22000.795]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
5.10.16
Distro Version
ArchLinux
Other Software
No response
Repro Steps
sudo df -h
Expected Behavior
As I know, /dev/sdb is related to the wsl2's file system vhdx, so the size of the space occupied in /dev/sdb should be the same as the size of my ext4.vhdx file.
Actual Behavior
But why the space that has been used in /dev/sdb is so large(168GB) ? my ext4.vhdx file is only 4.15 GB.

Diagnostic Logs
No response

Ok, I find that the huge files are located in /tmp. But I still don't know why it seems that those tmp files don't occupy real space?

WSL2 does not release free space back to disk. See this issue https://github.com/microsoft/WSL/issues/4699. It is possible to release that space.

Shutdown all WSL session with wsl.exe --shutdown command.
Optimize the vhdx file with optimize-vhd -mode full -path C:\archlinux\Arch\ext4.vhdx command in Powershell.

WSL2 does not release free space back to disk. See this issue https://github.com/microsoft/WSL/issues/4699. It is possible to release that space.
1. Shutdown all WSL session with `wsl.exe --shutdown` command.

2. Optimize the vhdx file with `optimize-vhd -mode full -path C:\archlinux\Arch\ext4.vhdx` command in Powershell.

Ok, thanks.


Documentation for different exporter installation methods

Fixes #544
Users have options to define container images or GIT source as exporter installation methods. This documentation covers all possible cases.
This may be usefull when user will be asked to deploy or update exporter with custom image provided by developers or would want to use different releases for different exporter instances.
Small update to the release script to mention last released branch in the Install.md.
Testing Instructions
Testing: https://pelorus--608.org.readthedocs.build/en/608/Configuration/#exporter-installation-sources
@redhat-cop/mdt

/test 4.8-e2e-openshift

/lgtm


Allow Cripts to be used directly as @plugin

An example compiler script would be (for macOS):
#!/bin/sh

SOURCE=$1
DEST=$2
CXXFLAGS="-std=c++20 -I/opt/homebrew/include -I/opt/ats/include"

exec clang++ -undefined dynamic_lookup -shared -fPIC ${CXXFLAGS} -L/opt/ats/lib -lcripts -o $DEST $SOURCE

[approve ci autest]

Cherry-picked to v10.0.x


Warn or fail on unknown tags?

I had a typo here, specifying enumerateValue instead of enumeratedValue, and the parser silently ignored it: https://github.com/riscv-rust/k210-pac/pull/23
Would be convenient if these unknown tags were flagged with a warning at least.

Maybe this issue should be addressed to the parser: https://github.com/japaric/svd

Yes, I'm not really familiar with the inner working of this tool, but that makes sense, the parser would at least need to report this to be able to report this to the user

Filed a PR for this: https://github.com/japaric/svd/pull/69
However, it's just for enumeratedValues, maybe the same problem can happen again somewhere.


SSL documentation improvements

Minor documentation touch-up to add missing kubectl create option and synchronise secret objects spread-around in the documentation.

This change is

thanks


Animationtree set function no longer working

Godot version
Godot 4.0 beta 14 and up
System information
Windows 10 education 21H2, mobile renderer
Issue description
Starting in beta 14 the term used for setting which state a transition node in an animationtreenodeblendtree is set to was changed from current to current_state. In beta 14 and up using neither current nor current_state seems to work. In beta 13 using current would work but beta 14 and up return the error:
"Invalid set index 'parameters/Transition/current_state' (on base: 'AnimationTree') with value of type 'float'
using typoeof() shows it's of type string though using '1' 'state 1' 'state_1' or changing the states name to something like 'hi' (doing so will also break the transition request in the inspector) and using that makes no difference (though doesn't return an error).

image taken from: https://docs.godotengine.org/en/latest/tutorials/animation/animation_tree.html#blend-tree
Steps to reproduce
create a project with an animationtree and animation player as children of the root node. Add an animationtreenodeblendtree to the animationtree and set up a transition like shown below. Then try to transition between animations in gdscript.

Minimal reproduction project
animationtree bugtest 2-1-23.zip

It is changed to transition/request in #71418 to restart same state, the current documentation is out of sync.


PrintSVEvidence Error: inputs are not sorted

Hi, I'm trying to replicate some steps in the workflow of gatk-sv. In the step MatrixQC, I have encountered the following bug, which I have no idea how to fix.
`Using GATK jar /media/atlantis/data_4tb/Exec/sv_workflow/gatk_sv_snakemake/.snakemake/conda/019f9e2664948e9d7669ca9498b81e93/share/gatk4-<IP_ADDRESS>-1/gatk-package-<IP_ADDRESS>-local.jar
Running:
java -Dsamjdk.use_async_io_read_samtools=false -Dsamjdk.use_async_io_write_samtools=true -Dsamjdk.use_async_io_write_tribble=false -Dsamjdk.compression_level=2 -Xmx10G -jar /media/atlantis/data_4tb/Exec/sv_workflow/gatk_sv_snakemake/.snakemake/conda/019f9e2664948e9d7669ca9498b81e93/share/gatk4-<IP_ADDRESS>-1/gatk-package-<IP_ADDRESS>-local.jar PrintSVEvidence --sequence-dictionary resource/Homo_sapiens_assembly38.dict --evidence-file /media/atlantis/data_4tb/Exec/results/GatherBatchEvidence/MergeEvidence/VN_01.pe.txt.gz -L /media/atlantis/data_4tb/Exec/results/EvidenceQC/MatrixQC/regions.pe.bed -O /media/atlantis/data_4tb/Exec/results/EvidenceQC/MatrixQC/local.pe.txt.gz
17:42:28.106 INFO  NativeLibraryLoader - Loading libgkl_compression.so from jar:file:/media/atlantis/data_4tb/Exec/sv_workflow/gatk_sv_snakemake/.snakemake/conda/019f9e2664948e9d7669ca9498b81e93/share/gatk4-<IP_ADDRESS>-1/gatk-package-<IP_ADDRESS>-local.jar!/com/intel/gkl/native/libgkl_compression.so
17:42:31.040 INFO  PrintSVEvidence - ------------------------------------------------------------
17:42:31.041 INFO  PrintSVEvidence - The Genome Analysis Toolkit (GATK) v<IP_ADDRESS>
17:42:31.041 INFO  PrintSVEvidence - For support and documentation go to https://software.broadinstitute.org/gatk/
17:42:31.041 INFO  PrintSVEvidence - Executing as atlantis@atlantis on Linux v5.15.0-43-generic amd64
17:42:31.041 INFO  PrintSVEvidence - Java runtime: OpenJDK 64-Bit Server VM v11.0.13+7-b1751.21
17:42:31.041 INFO  PrintSVEvidence - Start Date/Time: August 3, 2022 at 5:42:28 PM ICT
17:42:31.041 INFO  PrintSVEvidence - ------------------------------------------------------------
17:42:31.041 INFO  PrintSVEvidence - ------------------------------------------------------------
17:42:31.042 INFO  PrintSVEvidence - HTSJDK Version: 2.24.1
17:42:31.042 INFO  PrintSVEvidence - Picard Version: 2.27.1
17:42:31.042 INFO  PrintSVEvidence - Built for Spark Version: 2.4.5
17:42:31.042 INFO  PrintSVEvidence - HTSJDK Defaults.COMPRESSION_LEVEL : 2
17:42:31.043 INFO  PrintSVEvidence - HTSJDK Defaults.USE_ASYNC_IO_READ_FOR_SAMTOOLS : false
17:42:31.043 INFO  PrintSVEvidence - HTSJDK Defaults.USE_ASYNC_IO_WRITE_FOR_SAMTOOLS : true
17:42:31.043 INFO  PrintSVEvidence - HTSJDK Defaults.USE_ASYNC_IO_WRITE_FOR_TRIBBLE : false
17:42:31.043 INFO  PrintSVEvidence - Deflater: IntelDeflater
17:42:31.043 INFO  PrintSVEvidence - Inflater: IntelInflater
17:42:31.043 INFO  PrintSVEvidence - GCS max retries/reopens: 20
17:42:31.043 INFO  PrintSVEvidence - Requester pays: disabled
17:42:31.043 WARN  PrintSVEvidence -
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Warning: PrintSVEvidence is an EXPERIMENTAL tool and should not be used for production
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
17:42:31.043 INFO  PrintSVEvidence - Initializing engine
17:42:31.226 INFO  FeatureManager - Using codec DiscordantPairEvidenceCodec to read file file:///media/atlantis/data_4tb/Exec/results/GatherBatchEvidence/MergeEvidence/VN_01.pe.txt.gz
17:42:31.295 INFO  FeatureManager - Using codec BEDCodec to read file file:///media/atlantis/data_4tb/Exec/results/EvidenceQC/MatrixQC/regions.pe.bed
17:42:31.299 INFO  IntervalArgumentCollection - Processing 24000000 bp from intervals
17:42:31.300 WARN  IndexUtils - Feature file "file:///media/atlantis/data_4tb/Exec/results/GatherBatchEvidence/MergeEvidence/VN_01.pe.txt.gz" appears to contain no sequence dictionary. Attempting to retrieve a sequence dictionary from the associated index file
17:42:31.361 WARN  IntelInflater - Zero Bytes Written : 0
17:42:31.362 WARN  IndexUtils - Index file /media/atlantis/data_4tb/Exec/results/GatherBatchEvidence/MergeEvidence/VN_01.pe.txt.gz.tbi is out of date (index older than input file). Use IndexFeatureFile to make a new index.
17:42:31.367 INFO  PrintSVEvidence - Done initializing engine
17:42:31.370 INFO  ProgressMeter - Starting traversal
17:42:31.371 INFO  ProgressMeter -        Current Locus  Elapsed Minutes    Features Processed  Features/Minute
17:42:31.420 INFO  PrintSVEvidence - Shutting down engine
[August 3, 2022 at 5:42:31 PM ICT] org.broadinstitute.hellbender.tools.sv.PrintSVEvidence done. Elapsed time: 0.06 minutes.
Runtime.totalMemory()=627048448

A USER ERROR has occurred: inputs are not sorted at chr1:248437396

Set the system property GATK_STACKTRACE_ON_USER_EXCEPTION (--java-options '-DGATK_STACKTRACE_ON_USER_EXCEPTION=true') to print the stack trace.`
I have sorted and indexed the input pe file with these commands:
sort -k1,1V -k2,2n  $pe_file | bgzip -c > $pe_final_file
tabix -f -s1 -b2 -e2 $pe_final_file

I have also checked the pe file at the position, where the error occurs.
chr1    248437267       +       chr6    124582055       +       VN_01_00_0005
chr1    248437395       +       chr1    248654316       +       VN_01_00_0007
chr1    248437395       +       chrY    56836874        -       VN_01_00_0007
chr1    248437415       +       chr2    149572447       -       VN_01_00_0001

Hi @giacuong171,
This bug was fixed here on May 6 after the <IP_ADDRESS> release. Can you try compiling gatk from source or using a recent nightly build?

Hi @mwalker174 ,
Thank you for the quick reply. I will try to use the nightly build.


MRD Multi-echo swapping error

Peter mentioned that we swap gas and dissolve.

This was discovered as Peter evaluated our first patient for the LHC Study.
* Peter indicates we have mixed up our gas/dissolved contrast in MRD
* Contrast 1, Set 1 – Gas first echo
* Contrast 2, Set 1 – Gas second echo (should be dissolved first echo)
* Contrast 1, Set 2 – Dissolved first echo (should be gas second echo)
* Contrast 2, Set 2 – Dissolved second echo


stand up multiple agents (single and multi) for local development and testing

While working on load testing for Aries Mediator Service I needed to spin up multiple agents and needed help to see a simple way to do so; at least not vanilla instances that I could run ad-hoc test scripts against.
I required multiple single-tenant mode and a multi-tenant mode to test our mediation between multiple agents. This was a simple way to achieve it. I decided I would stand up the standard faber, alice, acme single-tenant agents and one multi-tenant agent.
I did opt to include a Postgresql server shared across all the agents and included ngrok (easily turned off per agent) for URLs accessible outside the local network.
This was extremely helpful to diagnose and fix #2231

A couple of tweaks - at least fix the CaPiTaLiZaTiOn of ACA-Py :-) .
I think it lacks a bit of “why do this?” motivation for how this can be used, so I think I would add how you are using it as an example, and include the stteps to run what you are running. Not required if you don’t think it is worth it.

Added simple scripts, didn't want to include load testing and additional infrastructure etc as that gets out of date quickly.


Populate IServerAddresses feature for the in process IIS integration

@jkotalik

What do you plan on using it for?

@shirhatti please check with @javiercn & @BillHiebert to see what their scenarios are.

The HttpsRedirect middleware would benifit from it. Not sure if they had other scenarios in mind.

Dup: https://github.com/aspnet/IISIntegration/issues/485


fix: support const char* state type conversion

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugin-sdk
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jasondellaluce
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 0149bd0529683b9dd1c3e41de79b7aaaedf29ec9

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Make it easier to find the phlow action implementation through drilling

When we drill into the button of a Phlow action we can find the implementation like this:

Try to make it at least one step shorter by making the GtPhlowElementContext show the code.

The action source is now visible in the phlow context:

And if we are at it, so is the view source:


Integrate Service Principal key within GitHub Secrets

Integrate the newly created key with Github
DoD: Github action(s) that need to log-in to Azure via CLI execute without log-in issues.

The following files within the .github/workflows direction are modified to achieve this specific goal.
modified:   .github/actions/build-vars/action.yml
modified:   .github/actions/vpn-azure/action.yml
modified:   .github/workflows/alert_cert_expire.yml
modified:   .github/workflows/alert_resource_costs.yml
modified:   .github/workflows/alert_terraform_changes.yml
modified:   .github/workflows/build_hub.yml
modified:   .github/workflows/cleanup_acr_images.yml
modified:   .github/workflows/deploy_terraform.yml
modified:   .github/workflows/deployment_rollback.yml
modified:   .github/workflows/destroy_demo_environment.yml
modified:   .github/workflows/export_cost_data.yml
modified:   .github/workflows/release_chatops_app.yml
modified:   .github/workflows/release_to_azure.yml
modified:   .github/workflows/release_trial_frontend.yml
modified:   .github/workflows/restore_databases.yml
modified:   .github/workflows/start_test_servers.yml
modified:   .github/workflows/stop_test_servers.yml
modified:   .github/workflows/sync-translation-schemas.yml
modified:   .github/workflows/validate_resources.yml

The original setting gets replaced by an environment variable defined within the workflow's env: block
          ## sp-creds: ${{ secrets.SERVICE_PRINCIPAL_CREDS }}
          sp-creds: ${AZURE_CREDENTIALS}

This is what we have done so far:

To avoid any further delays and not to force any changes in the existing configurations, I have updated the GitHub Secret SERVICE_PRINCIPAL_CREDS with the latest JSON configuration (check about example).
In this way, the existing (current) GitHub Workflows/Actions should resume their executions as expected.
I have created a Pull Request (PR) for handling the changes we must have in place for properly using these external GitHub Actions. We need to move away from the hardcoded hashes as it's not a good practice either.
Note: I will explain this in further detail.

This issue is now resolved.

We have encountered these errors but they should be resolved with these latest updates.
ERROR: (AuthorizationFailed) The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/read' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:41:00.1713659Z Code: AuthorizationFailed
2024-12-04T16:41:00.1716898Z Message: The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/read' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:41:00.2877025Z ##[debug]Code: 1
2024-12-04T16:41:00.2878003Z ##[debug]Signal: null
2024-12-04T16:44:00.4901680Z ##[debug]Waited 180037ms
2024-12-04T16:44:00.4902368Z ##[debug]Configured wait: 180000ms
2024-12-04T16:44:00.9369871Z ERROR: (AuthorizationFailed) The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/stop/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:44:00.9372461Z Code: AuthorizationFailed
2024-12-04T16:44:00.9375153Z Message: The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/stop/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:44:01.4161092Z ERROR: (AuthorizationFailed) The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/start/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:44:01.4164029Z Code: AuthorizationFailed
2024-12-04T16:44:01.4166442Z Message: The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/start/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:44:01.5331461Z WARNING: Retry command threw the error Command failed: az container stop --name pdhstaging-sftpserver -g prime-data-hub-staging; az container start --name pdhstaging-sftpserver -g prime-data-hub-staging;
2024-12-04T16:44:01.5355823Z ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
2024-12-04T16:44:01.5356882Z ##[debug]Running command ip=$(az container show --name pdhstaging-sftpserver \
2024-12-04T16:44:01.5357393Z ##[debug]-g prime-data-hub-staging -o tsv --query 'ipAddress.ip')
2024-12-04T16:44:01.5357748Z ##[debug]last_octet=${ip: -2}
2024-12-04T16:44:01.5358067Z ##[debug]if [[ $last_octet -ne 20 ]]; then exit 1; fi on linux using shell bash
2024-12-04T16:44:01.9142450Z ERROR: (AuthorizationFailed) The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/read' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:44:01.9145286Z Code: AuthorizationFailed
2024-12-04T16:44:01.9148141Z Message: The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/read' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:44:02.0661224Z ##[debug]Code: 1
2024-12-04T16:44:02.0662031Z ##[debug]Signal: null
2024-12-04T16:47:02.6383816Z ##[debug]Waited 180100ms
2024-12-04T16:47:02.6384729Z ##[debug]Configured wait: 180000ms
2024-12-04T16:47:03.0216225Z ERROR: (AuthorizationFailed) The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/stop/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:47:03.0219084Z Code: AuthorizationFailed
2024-12-04T16:47:03.0221564Z Message: The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/stop/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:47:03.5057090Z ERROR: (AuthorizationFailed) The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/start/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:47:03.5059979Z Code: AuthorizationFailed
2024-12-04T16:47:03.5062457Z Message: The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/start/action' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:47:03.6164163Z WARNING: Retry command threw the error Command failed: az container stop --name pdhstaging-sftpserver -g prime-data-hub-staging; az container start --name pdhstaging-sftpserver -g prime-data-hub-staging;
2024-12-04T16:47:03.6167982Z ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
2024-12-04T16:47:03.6169294Z ##[debug]Running command ip=$(az container show --name pdhstaging-sftpserver \
2024-12-04T16:47:03.6170126Z ##[debug]-g prime-data-hub-staging -o tsv --query 'ipAddress.ip')
2024-12-04T16:47:03.6170695Z ##[debug]last_octet=${ip: -2}
2024-12-04T16:47:03.6171242Z ##[debug]if [[ $last_octet -ne 20 ]]; then exit 1; fi on linux using shell bash
2024-12-04T16:47:03.9863663Z ERROR: (AuthorizationFailed) The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/read' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.
2024-12-04T16:47:03.9866700Z Code: AuthorizationFailed
2024-12-04T16:47:03.9869115Z Message: The client 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' with object id 'ac21f8dc-f2ee-4a56-bd88-51a5ae230dd8' does not have authorization to perform action 'Microsoft.ContainerInstance/containerGroups/read' over scope '/subscriptions/***/resourceGroups/prime-data-hub-staging/providers/Microsoft.ContainerInstance/containerGroups/pdhstaging-sftpserver' or the scope is invalid. If access was recently granted, please refresh your credentials.

Note: The follow actions were performed by the CDC Cloud Support team:
Cloud Technical Assistance: The Application client id was granted contributor role to the following resource groups:
 prime-data-hub-demo: OCIO-DMZ-C1 [ East US ]
 prime-data-hub-demo1: OCIO-DMZ-C1 [ East US ]
 prime-data-hub-demo2: OCIO-DMZ-C1 [ East US ]
 prime-data-hub-demo3: OCIO-DMZ-C1 [ East US ]
 prime-data-hub-prod: OCIO-DMZ-C1 [ East US ]
 prime-data-hub-staging: OCIO-DMZ-C1 [ East US ]
 prime-data-hub-test: OCIO-DMZ-C1 [ East US ]
 prime-ingestion-dev: OCIO-DMZ-C1 [ East US ]
 prime-ingestion-test: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-demo: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-dev: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-management: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-pentest: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-prod: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-stg: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-test: OCIO-DMZ-C1 [ East US ]
 prime-simple-report-training: OCIO-DMZ-C1 [ East US ]


Move Sortino Ratio To PortfolioStatistics

Expected Behavior

Sortino Ratio is part of the main PortfolioStatistics along side the Sharpe Ratio

Actual Behavior

Currently the Sortino Ratio is part of the trade statistics

Potential Solution

Refactor

Reproducing the Problem

N/A
System Information

N/A
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

Duplicate of https://github.com/QuantConnect/Lean/issues/5594


[5.1] Allow collection of arrays to be easily uniquely filtered

Needs explanation.

array_unique by itself doesn't work on a multi-dimensional array:
array_unique([[1], [1]]);

// PHP error:  Array to string conversion on line 1

In order to use array_unique on an array of arrays/objects, you need the SORT_REGULAR flag:


How do I read a zip file and return it as a stream without printing it to disk？

// I copied a zipfile, put a file to the copefile , and output the modified zipfile as stream.
// I finally deleted the modified file.
// How do I read a zip file and return it as a stream without printing it to disk？
File file = new File(filePath);
File copyFile = new File(copyPath + ".zip");
Files.copy(file.toPath(), copyFile.toPath(), StandardCopyOption.REPLACE_EXISTING);
InputStream input = null;
try {
  ZipFile zipFile = new ZipFile(copyFile);
  zipFile.setFileNameCharset(String.valueOf(StandardCharsets.UTF_8));
  ZipParameters parameters = new ZipParameters();
  parameters.setCompressionMethod(Zip4jConstants.COMP_DEFLATE);
  parameters.setFileNameInZip("info.json");
  parameters.setSourceExternalStream(true);
  byte[] bytes = objectMapper.writeValueAsBytes(object);
  input = new ByteArrayInputStream(bytes);
  zipFile.addStream(input, parameters);
} catch (Exception e) {
  e.printStackTrace();
} finally {
  if (input != null) {
    try {
      input.close();
    } catch (IOException e) {
      e.printStackTrace();
    }
  }
}

try (InputStream inputStream = new FileInputStream(copyFile);
        OutputStream outputStream = response.getOutputStream()) {
  response.setContentType("application/x-download");
  response.addHeader("Content-Disposition", "attachment;filename=" + URLEncoder.encode(templetName, "UTF-8") + ".zip");
  IOUtils.copy(inputStream, outputStream);
  outputStream.flush();
} catch (IOException e) {
  e.printStackTrace();
}

copyFile.delete();

To work with zip files and streams, you have to use ZipInputStream. From your example, it looks like you are using v1.x of zip4j. I would recommend you to use v2.x of zip4j which has better support for streams. There are examples in README.

Can ZIP4J compress multiple files into an outputstream instead of generating disk files?

Yes, it can. You can find the sample code under the section Adding entries with ZipOutputStream in README


chore: adds 'working items' section and 'other relevant documents' section to README.md

This PR takes care of adding links to working items and other relevant documents to the README.md file as per the respective subtask in https://github.com/w3c/WebID/issues/53 . I'm setting the review deadline to 2024-02-17 (in two days) as this PR does not introduce any change to the spec and #53 has been open for more than two weeks and was mentioned in two different chair's overview emails.

Shortcut PR review deadlines are impossible to learn about within that shortcut time frame if a reader is thinking things are conforming to the theoretically now standard practice for this project. Ad-hoc shortcut reviews are not good practice.


Function names missing in profiler log view

Hi,
I'm running micro-profiler on VS2019 Community and was able to enable profiling and run the code (I need to run VS as admin for this because of the installation path to the microprofiler an dthe MICROPROFILEDIR point to a restricted directory location).
I've successfully used this before on VS2017 , but now on VS2019 it seems to work ok other than that in the profiler view afterwards I get the table for running times and all, but the function names column is completely empty?

Please, see other issues. Most probably you have /DEBUG:FASTLINK option set in linker settings. Use simply /DEBUG or /DEBUG:FULL.

Thanks, I don't know how I didn't the issue from before. I had /DEBUG, changed it to /DEBUG:FULL, and now it works. Thanks for a really great tool!

@klukander if you don't mind, please, find a time to star me here and write a review on https://marketplace.visualstudio.com/items?itemName=ArtemGevorkyan.MicroProfilerx64x86
Thanks again for your effort and appreciation!


Getting an override warning when using Makefile

I'm not a Makefile expert, but line 141 of Linux.mk seems to contain a typo:
https://github.com/carla-simulator/carla/blob/a2ae705126151af29c5169e56afdfa6507063973/Util/BuildTools/Linux.mk#L141
I assume it should be setup: downloadplugins instead, especially since the downloadplugins target is already defined below (line 162) and only this second definition is kept, according to this warning that I get everytime I run a make command:
Util/BuildTools/Linux.mk:162: warning: overriding commands for target « downloadplugins »
Util/BuildTools/Linux.mk:141: warning: ignoring old commands for target « downloadplugins »

Changed to pull request: https://github.com/carla-simulator/carla/pull/8167


Remove old stuff

Looks like some stuff was a good idea at the beginning, not sure we really need some stuff anymore:

[ ] oc link (as consumer, you do oc link<EMAIL_ADDRESS>to add it to local oc.json file)
[ ] oc unlink (as consumer, you remove the linked component from oc.json file)
[ ] oc info (to see info about a linked component and in case suggest upgrade)
[ ] oc ls (to see all components for linked registry - we have the web interface now for that)

So, democratically, I am gonna ask top 4 contributors and my vote is gonna be counted only if is gonna be a tie. Please vote for each one until Friday night replying here for keeping or killing each one of those functionalities.
@jankowiakmaria @andyroyle @federicomaffei @tpgmartin

@matteofigus - Good idea to involve contributors. Personally haven't been a huge user of the cli part so far, so a bit difficult for me to make a call.
What are your concerns about those commands? Maybe the fact that they are not useful enough and/or the state of the code (e.g. not tested, not updated as the rest, not enough time to maintain them, etc.)?

The concerns are that if something is not needed, it should be killed asap to keep code smaller and more maintainable. OC is growing and I believe that if we kill what we don't need anymore we can focus on the new stuff.

Sorry I'm a bit late to the party.

We can always add stuff back if necessary

:+1: (sorry for late response)

Let's kill 'em all @matteofigus!

Good :+1:


Optional parameter with initializer is still considered potentially undefined in function body

function foo(x? = "bar") {
    x.toLowerCase()
}

Expected: No error
Actual: Object is potentially 'undefined'. on x.toLowerCase()

This is working as intended. To get the effect you want, simply write:
function foo(x = "bar") {
    x.toLowerCase()
}

This works as expected: foo has an optional parameter, but x is considered definitely assigned within the function. However, once you explicitly include a ? on a parameter we always consider it possibly undefined, regardless of whether it has an initializer. This is analogous to how optional properties with initializers work.

It's an error to have both a ? and a default value.


add Title to MenuEntry

This PR allows to set a title for a MenuEntry in the site config menus.
This allows to render anchor links in menus which have a title attribute:
{{ range .Site.Menus.main }}

                {{ .Pre }}
                {{ .Name }}

{{ end }}

This feature is useful for screenreaders and SEO.
I didn't implement the same in the frontmatter menu field, because the attribute title is too generic. linkTitle or anchortitle might be better names.
I would love if you could merge this and we figure out if the title attribute is something people need in frontmatter menues. I only use site config menues yet.

Hey and thanks for this,
We need to have this on all menu items. I know you say you only need "config menus", which is why I'm insisting on getting both right in one go. Because if I merge this, you will probably never come back to complete the task.
There is another issue asking for a reference to the *Page on a given menu item (which would solve the title case for those).
So:

Add Page to MenuItem and set it when relevant.
Add a Title method on MenuItem - use the local title (from the config) if set, fall back to Page.Title if page is set.

Also, move the test to a standalone test in menu_test.go The setupMenuTests harnish is about to be deleted in a branch I'm working on.

At first I wanted to add my test to menu_test.go, but I didn't understand the code. It was far easier to use the old code.
I also never understood the menu attribute in the frontmatter, that's why I initially decided against trying to implement anything there.
You say MenuItem, do you mean MenuEntry?

Looks like this is the relevant code https://github.com/gohugoio/hugo/blob/master/hugolib/page.go#L1365-L1419
But the test is in menu_test.go and menu_old_test.go.

You say MenuItem, do you mean MenuEntry?

Yes, that is correct. And you found the correct spot. So the MenuEntry needs a Page which can be nill in some cases.
The menu_old_test.go does not exist anymore in my current branch, which means that this PR will be hard for me to manage in the near future. It has some valid tests not inside the new file, but it is pretty fragile, so instead of keeping on fiddling with it, I just deleted it.
From this PR you need some "smoke tests", i.e. a site with a bit of both and check for page + title.

Ok.
One thing, I find irritating is the LinkTitle() func. From the docs this function and variable would be better named anchorText or linkText.
The name linkText creates a collision with what I thought the new vairable / function should be named. How should I name the new variable / function? anchorTitle, aTitle or something different?

One thing, I find irritating is the LinkTitle() func. From the docs this function and variable would be better named anchorText or linkText.

I'm not sure what that method has to do with this. This PR does not involve making any changes to Page.
MenuEntry should get:

A Page pointer.
A Title() method, which gets its value from the menu config, if set, or the Page.LinkTitle() if page is set.

I'm not a native English speaker, so please excuse any confusion.
The relevant code you want me to change is part of page.go, that's why I'm asking.
And there are a few client calls to p.LinkTitle() which doesn't exactly do what the name says. The docs hint it should hold anchor text. I just found the naming confusing, because pages have a title attribute, a linkTitle, and now get a title in the menu.
I added to the test and some of the functionality is already there, because of this line: https://github.com/gohugoio/hugo/blob/master/hugolib/page.go#L1410
Which is very interesting, because as a user, you are free to use any of the available keys in this map.
Also this comment hints in the direction that MenuEntry might be better of as an interface with SiteConfigMenuEntry and PageMenuEntry as the implementations. But I guess this is out of scope.


dracut: init at 059

Description of changes
This PR adds a functioning dracut package. To actually generate an initrd with it, though, you'll want to make a dracut.conf specifying where you want to pull everything (e.g. systemd units, kernel modules, etc.) and set DRACUT_PATH to include any necessarily tools not already in the wrapper
I personally just want this for the lsinitrd and skipcpio commands though, and I do not plan on generating initrd images with it (but generating them did seem to theoretically work in my tests, when I started putting some paths in a dracut.conf)
Supersedes and closes #77868
Closes #77858
@CMCDragonkai Since you had yourself listed as maintainer on #77868, do you want for me to still add you as maintainer on the package in this PR?
cc: @ketzacoatl
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

No I don't have time to maintain this, happy for you to continue. Generating initrd images is important for further customisation of the initrd though, so it would be nice to have.

Generating initrd images is important for further customisation of the initrd though, so it would be nice to have.

It technically does work, and I generated a few initrds while testing the package. To get something practically useful for NixOS, though, would require writing way too much config (and while I am happy to support people trying to generate initrds with it, I really only care about lsinitrd and stuff)


remove unrecognised cops in .rubocop.yml

using the Gemfile robocop (0.87.1) I get, removing these fixes it. Noting i also get these errors with the latest version (0.89) https://rubygems.org/gems/rubocop/
Error: unrecognized cop Layout/EmptyLinesAroundAttributeAccessor found in .rubocop.yml, unrecognized cop Lint/DeprecatedOpenSSLConstant found in .rubocop.yml, unrecognized cop Lint/MixedRegexpCaptureTypes found in .rubocop.yml, unrecognized cop Style/AccessorGrouping found in .rubocop.yml, unrecognized cop Style/BisectedAttrAccessor found in .rubocop.yml, unrecognized cop Style/RedundantAssignment found in .rubocop.yml, unrecognized cop Style/RedundantFetchBlock found in .rubocop.yml, unrecognized cop Style/RedundantRegexpCharacterClass found in .rubocop.yml, unrecognized cop Style/RedundantRegexpEscape found in .rubocop.yml, unrecognized cop Style/SlicingWithRange found in .rubocop.yml

Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

hound linter CI failing https://github.com/zooniverse/panoptes/pull/3460#pullrequestreview-477733952

It's still not clear to me why hound is not able to recognize those new cops, the warning I get implies that Layout/EmptyLinesAroundAttributeAccessor (0.83) was introduced in version 0.83. May be the case that hound is unable to recognize pending cops, which are introduced between major versions. Also strange to me that I'm getting the error locally on vs code but you're not, maybe it's got something to do with one of the other rubocop gems used (rubocop-ast, rubocop-rails, etc).
When I remove that cop, then open up a shell on my local Panoptes docker container and run the command rubocop, I get the same warning that I get in vs code:

The following cops were added to RuboCop, but are not configured. Please set Enabled to either true or false in your .rubocop.yml file: - Layout/EmptyLinesAroundAttributeAccessor (0.83)

To work around this type of warning coming up, I'm thinking we can just enable all new cops of this sort (or alternatively disable, but it seems like we're leaning towards enabling all) with:
AllCops:
  NewCops: enable

Thanks @nciemniak - I won't rule out me doing something stupid here :(
Yes to allcops enable 👍 that sounds useful and more. Feel free to push that change to this PR and if it works for you then merge :)

Awesome, doing it.


feat:  Add evalFileContinous + Write error in file

This PR aims to add:

An evalFileContinous Command to continuously evaluation the current file in case of changes
Writing the result of an  evalFile to an error.json to be able to read it properly

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @julienduchesne would you mind to give it a look ?
It is the first time that i extended a vscode extension and the evaluateContinoulsy is not perfectly working, but nevertheless, this makes it way more convenient to work with jsonnet templates.
I am willing to further improve this PR if needed, if there is any further feedback.

Hi @julienduchesne would you mind to give it a look ? It is the first time that i extended a vscode extension and the evaluateContinoulsy is not perfectly working, but nevertheless, this makes it way more convenient to work with jsonnet templates. I am willing to further improve this PR if needed, if there is any further feedback.

👋 Hey. I think this should be merged into the regular eval commands (with a flag to disable the feature globally). This could be valuable for every format and to add a new command for each format would cause the number of commands to explode.
Could you make this change?


Fix for query editor toolbar actions to show correctly based on file type

This PR fixes #
Fix for query editor toolbar actions to show correctly based on file type when not connected

Coverage decreased (-0.009%) to 40.493% when pulling 9b0f316cc2fa750f51c02ed5d1d9d3582119f52c on queryEditor_toolbar_actions into 5a301f907385f3c33378fdf557833046d28d3c53 on main.

Did you verify that this works correctly if you switch the languages of an opened document? (i.e. switching from sql to kql causes the actions to be updated correctly)

I see one issue that xml as well as kusto have same supported extension ".csl". Should I remove ".csl" from kusto supported extensions for now?


On release 0.18.0, Twig Modal component breaks

On release 0.18.0, the Twig modal component gives the following error:

To reproduce check out https://github.com/international-labour-organization/ilo_base_theme and run make this will install a demo site locally, where the issue is reproducible, then check http://localhost:8080/patterns/modal

During the investigation, I noticed that the modal component is passing the props, but the nested button component doesn't receive them; the problem only appears in ilo_base_theme.

Good catch @GGKapanadze , I'll investigate, it might be a definition problem.


assertThat(streamSupplier.get()).isEqualTo(streamSupplier.get()) Always Fails

Summary
If I have a stream-supplying lambda or a stream-returning method, I ought to be able to compare the result of get()ing it or executing it twice in succession. But apparently I can't (profitably) send aStream to isEqualTo().
Example
  private static Supplier<Stream<Integer>> ss = () -> Stream.of(1, 2);

  @Test
  void compareWithSelf() {
    /*
     This fails:

      org.opentest4j.AssertionFailedError:
      Expecting:
       <[1, 2]>
      to be equal to:
       <java.util.stream.ReferencePipeline$Head@7e0e6aa2>
      but was not.
      Expected :java.util.stream.ReferencePipeline$Head@7e0e6aa2
      Actual   :[1, 2]

     */
    assertThat(ss.get()).isEqualTo(ss.get());
  }

This works:
    assertThat(ss.get()).containsExactly(1,2);

As does this:
    // to compare a stream on RHS, it must be converted to something iterable
    final Iterable<Integer> c = ss.get().collect(Collectors.toList());
    assertThat(ss.get()).isEqualTo(c);

But in my test it would be more natural to do it the first way (providing the result of ss.get() directly to isEqualTo(). I'd like my stream-supplying lambda (ss in my example) to be the source of truth for this assertion.
Is there some good reason why AssertJ doesn't support this, or is it simply a bug?

The behavior is conform to Stream.equals().
.isEqualTo() relies on the equals() method, here the Stream.equals() method that is not overriden (so it is the reference equality).
Here each supplier invocation instantiates a distinct stream object.
Use the same and it should be fine :
  private static Supplier<Stream<Integer>> ss = () -> Stream.of(1, 2);
  Stream<Integer> s =  ss.get();
  assertThat(s).isEqualTo(s);

But in my test it would be more natural to do it the first way

This will break the isEqualTo() semantic that is not designed to perform some conversion. So, I don't think that it is the right way.
This works and is rather acceptable :
assertThat(ss.get()).containsExactly(1,2);

And fon't forget that a stream is not a List or a collection. Comparing two streams with equals() is really not a conventional requirement. You compare rather the stream content or the stream equality (in terms of object)

@ebundy thanks, this is exactly what I would replied. I'm just going to add that assertThat(ss.get()) converts the stream to a list in order to be able to chain multiple assertions.
@Bill any objections for me before I close this issue ?

Not really @joel-costigliola. It's just that the asymmetry here made me think maybe something better (or at least different) was possible. Look again at the error message:
      org.opentest4j.AssertionFailedError:
      Expecting:
       <[1, 2]>
      to be equal to:
       <java.util.stream.ReferencePipeline$Head@7e0e6aa2>
      but was not.
      Expected :java.util.stream.ReferencePipeline$Head@7e0e6aa2
      Actual   :[1, 2]

Notice how the first part shows what appears to be the contents of a collection:
      Expecting:
       <[1, 2]>

And then the second part goes off the rails:
      to be equal to:
       <java.util.stream.ReferencePipeline$Head@7e0e6aa2>

Why the asymmetry?
I figured, perhaps naïvely, that it would be possible to treat streams specially. Clearly, AssertJ is already applying a terminal operation (collecting) one of the streams (otherwise the error message wouldn't contain the 1,2). I was looking for AssertJ to do the same thing for the other half of the assertion.
This asymmetry seems to indicate that I can make no useful assertions about streams directly. I was hoping that the asymmetry could be removed so that the most common case would "just work". Alas.

The asymmetry is to allow assertions on streams as if they were lists, which we believe is quite handy otherwise you need to convert the stream to list yourself, the other option would be for AssertJ to provide assertions specific to streams but they would not be chainable as the first assertion that requires to inspect the stream would consume it.

I was looking for AssertJ to do the same thing for the other half of the assertion.
Maybe, we need to think about that.

This asymmetry seems to indicate that I can make no useful assertions about streams directly
on the expected side yes, on the stream under test you have all the list/iterable at your disposal.


Albums tagged as Original if og in Album name

Albums are tagged as Original Versions if it finds "og" in the Album name:
Album Name: Seasons (Futuristik & Whogaux Remix)

Album Name: Seasons (Futuristik & WhXXaux Remix)

Ahaa ... okay. We can modify that to check for " og " rather than "og". I guess that would fix the issue


Value expression support

Do you plan add support for value expression?

Hello @mad
Cypher for Gremlin currently supports value expressions in most common places (return expressions, projections, property update...).
Do you have any specific query examples?

CASE expression

CASE expression is not implemented yet.
It should be possible to translate it to Gremlin Choose Step.
I will take a look into this.


Will Apple reject my app if I use this plugin?

Hi,
According to Apple's submission guidelines, item 2.7:

Apps that download code in any way or form will be rejected

Has someone submitted an app that uses this plugin with success?

It is allowed. See https://developer.apple.com/programs/terms/ios/standard/ios_program_standard_agreement_20140909.pdf section 3.3.2


"cannot find job file" when inspecting datum after migration from 1.9.0 to 1.10.0

What happened?:
I created a pachyderm 1.9.0 cluster consisting of the following examples

opencv
object-detection
hyperparameter
gatk

I then backed up the cluster using pachctl extract.

I deployed 1.10.0 and then restored the extracted backup to migrate the cluster.
There was a failed job at the top of the list for the detect pipeline (along with many others).  I was able to inspect the job fine, but inspecting the datum resulted in the error "cannot find job file".  Stats were turned on for this pipeline.
What you expected to happen?:
I expected to be able to inspect the datum.
How to reproduce it (as minimally and precisely as possible)?:
(someday I'll post Makefile changes that make this easier.)

deploy 1.9.0 on a clean cluster
check out source and cd to examples, deploy opencv using "make opencv"
add images3.txt and images4.txt to the images repo.
In the makefile for examples, comment out the creation of the images repo for the object-detection target.  It'll share the repo for opencv.
edit  ml/object-detection/detect.json, enabling stats
deploy object detection with "make object-detection".
edit ml/hyperparameter/model.json, changing the name to "hyperparameter-model"
edit  ml/hyperparameter/select.json, changing the repo of the "model" input to "hyperparameter-model" and adding a name attribute "name": model
edit  ml/hyperparameter/test.json, changing the repo of the "model" input to "hyperparameter-model" and adding a name attribute "name": model
deploy hyperparameter with "make hyperparameter"
deploy gatk with "make gatk".
wait for all the jobs to run to completion.
extract the back using pachctl extract to a file
pachctl delete all
pachctl undeploy --all
deploy 1.10.0
pachctl restore from the file from 13
See failed jobs, Try inspect datum on datum that's fingered in a failed job in detect

Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-13T18:08:14Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:07:57Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Pachyderm CLI and pachd server version (use pachctl version):

COMPONENT           VERSION
pachctl             1.10.0
pachd               1.10.0-rc1

Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
docker-desktop on macOS
6G ram assigned
OS (e.g. from /etc/os-release): macOS Catalina 10.15.3 (19D76)
Others:

I've created a PR that adds some Makefile targets to make reproducing this easier:
https://github.com/pachyderm/pachyderm/pull/4678

@pappasilenus I think this one is fixed PR #4680


getPayload only to origin relays issue

As mentioned in PR #342 , I also thought it was a bug that the blocknative relay was receiving getPayload requests for payloads we did not deliver.
But I came to a different conclusion upon seeing growing sentiment from the various block builders and relays to send blocks to each other. Could this behavior been seen as a redundancy feature?
More specifically: If a block gets sent to all relays, and the relay who serves the winning bid goes down in between serving the header and payload, asking the other relays for that block could add redundancy?

That was some of the thinking behind the original implementation (as well as simplicity). But both mev-boost as well as the relays would log errors, users were confused, and there were additional concerns about privacy. Also the relay has to guarantee data availability for bids it sent to proposers. Semi-related - there is also work underway of retrying getPayload call.
For context, PR #342 has been included in the v1.3.2 release. Since then mev-boost only sends getPayload to the relays that served the specific bid.


Sonarcloud security references

Sonarcloud is a false-positive on code that already existed, nothing was added to cause 11% more duplication.

:tada: This PR is included in version 5.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: