Make the E  G  S    T  D    A  M icons in UmpleOnline context sensitive

The 'icons' that allow the user to control the diagram type, whether text or diagrams are displayed, and whether attributes or methods are displayed are currently not sensitive to the current state.
A lighter shade should be shown for currently inactive states. So only one of the E, G or S icons should be in normal shade. If Text is hidden, or diagram is hidden, the T or D should be in lighter shade. And the A or M would also be sensitive to the current state. By default at startup, the E, T, D and A icons would appear normal.
The initial setting of these items occurs in umple.php after line 200, but these would have to be given ids to allow control. css style button2 is set around line 111. There is a button2:active style that is the same as when hovering, but it is never being used.
Initial state is known at php startup for some of these settings, e.g. $diagramType, $showText. But the setting would also have to be controlled by javascript when the various settings change.

I would add a javascript method called something like setDiagramTypeIconState() that would set the style on one of the icons and reset the others.


I can open a jupyter notebook, but I cannot run the notebook with python script in it on my Mac

I have been using jupyter as well as Atom with python for more than a year now. I'm currently using Python 3.7.2 on macOS 10.14. There is no problem running Python from the Terminal and here are the PATH I get after running sys.path:
['', '/Library/Frameworks/Python.framework/Versions/3.7/lib/python37.zip', '/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7', '/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/lib-dynload', '/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages']

I can open a jupyter notebook in jupyter but for some obscure reason, I cannot run the notebook and there is a red Kernel error on the top right of the page with the following error message when I click on it:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/web.py", line 1699, in _execute
    result = await result
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/gen.py", line 736, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/notebook/services/sessions/handlers.py", line 73, in post
    type=mtype))
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/gen.py", line 729, in run
    value = future.result()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/gen.py", line 736, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/notebook/services/sessions/sessionmanager.py", line 79, in create_session
    kernel_id = yield self.start_kernel_for_session(session_id, path, name, type, kernel_name)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/gen.py", line 729, in run
    value = future.result()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/gen.py", line 736, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/notebook/services/sessions/sessionmanager.py", line 92, in start_kernel_for_session
    self.kernel_manager.start_kernel(path=kernel_path, kernel_name=kernel_name)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/gen.py", line 729, in run
    value = future.result()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tornado/gen.py", line 209, in wrapper
    yielded = next(result)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/notebook/services/kernels/kernelmanager.py", line 160, in start_kernel
    super(MappingKernelManager, self).start_kernel(**kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/jupyter_client/multikernelmanager.py", line 110, in start_kernel
    km.start_kernel(**kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/jupyter_client/manager.py", line 259, in start_kernel
    **kw)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/jupyter_client/manager.py", line 204, in _launch_kernel
    return launch_kernel(kernel_cmd, **kw)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/jupyter_client/launcher.py", line 138, in launch_kernel
    proc = Popen(cmd, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 1522, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: '/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7'

here is my PATH (obtained after the command: nano ~/.bash_profile)
# Homebrew
export PATH=/usr/local/bin:$PATH

# Setting PATH for Python 3.7
# The original version is saved in .bash_profile.pysave
PATH="/Library/Frameworks/Python.framework/Versions/3.7/bin:${PATH}"
export PATH

# Setting PATH for Python 3.7
# The original version is saved in .bash_profile.pysave
PATH="/Library/Frameworks/Python.framework/Versions/3.7/bin:${PATH}"
export PATH

I already uninstalled all the python installations on my computer including the anaconda version (except python 2.7 as my mac doesn't accept that I remove it)

hey @bjce - it looks like your Jupyter process is trying to run a Python executable that it doesn't have the permissions to access:
/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7

I'd recommend re-installing the Anaconda distribution, making sure that calling python as well as calling jupyter is using the ones that are bundled with Anaconda, and then re-trying opening a notebook.
(also, just a note that this repository is only to discuss the jupyter.org website, somebody with permission should move this to the notebook repo)

Thank you very much for your quick answer @choldgraf. As I mentioned in my question, I removed manually all the other python installation including anaconda to start afresh (which might be the cause of the problem). If possible, in order to avoid a thousand different python installation path which already caused my a lot of headache and time, I would like to install jupyter notebook WITHOUT anaconda. Is it at all possible?

it is possible but can be more complicated (since really the question would be "how can I install Python on my computer in a way that I can access it?"). I'd recommend following the Jupyter Notebook install instructions

thanks again @choldgraf. I already followed the instructions on this website and ran
python3 -m pip install --upgrade pip
python3 -m pip install jupyter

but it didn't solve the problem

try typing which python3 and see where it points...then type in which jupyter and make sure it's the same Python folder.
Also note that those pip instructions are assuming that you already have a functioning Python installation - the problem here is that you don't currently have a functioning Python installation (that's why the jupyter install docs recommend using Anaconda as a first step)

many thanks @choldgraf. In the meantime, I uninstalled everything and re-installed python and jupyter  through homebrew and so far it works. Many thanks for your time

that's great news! happy to help. think we can close this issue?

yes. I closed the issue. thank you very much again @choldgraf


[Bug] - Missing Newest Season's Challenges

Are there plans to add the newest calling cards? I use this tracker on my stream to show my overall progress.

Fixed in #111 if merged @carlssonemil


artifacthub

https://github.com/topolvm/topolvm/issues/368

@toshipp Thank you for your review, I just wanted to let you know that I fixed what you pointed outs.
Would you review this PR again?

Could you rebase it on the main branch?

continue to #181


⚠ Bofrost.be has degraded performance

In 14f5b89, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1072 ms

Resolved: Bofrost.be performance has improved in 5e12407 after 6 minutes.


System.Collections.Generic namespace not being picked up in .razor files

It looks like we add a using statement for the System.Collections.Generic namespace in the generated code from a .razor file, but it's not getting picked up in intellisense. If you manually type an IList<T> it works, but intellisense will fight you.

This is most likely a combination of a projection buffer issue along side the innability to ctrl . add usings.

along side the inability to ctrl . add usings in Razor documents

Please note that the generated code already has a using statement for System.Collections.Generic. Intellisense just doesn't seem to know about it.

@NTaylorMullen, should we follow up on this with the Completion team or WTE?

@danroth27, I tried this out and it looks like it is working as expected.

The reason it completes to System.Collections.IList is because it thinks you are trying to write the non-generic version of the type which is in a different namespace not in scope.
The reason this still works in cs files is because of the ability to auto add usings. Notice how it auto added using System.Collections even though it wasn't necessary.

There is no actual bug here, it is just that since we don't support auto adding using statements, we have a slightly different behavior than a regular cs file. This is something we have to live with until we implement that feature.

Closing this. Please reopen if there is any action item here for us.


commonize NOC parameters that a shared between host / device

Currently command_queue.hpp inlcudes a device-only file (it is also an arch-specific file),
"tt_metal/src/firmware/riscv/grayskull/noc/noc_parameters.h"
We have to have these in hostdevcommon, or just replicate them in host-side.
These are not changing for arch that is in silicon.
Need to make a solution that works both for GS and WH w/o host re-compile of CQ.
CQ should build as part of make build which will be device agnostic (a separate case owned by KM).
Tests/application should not be re-building tt_metal host impl such as CQ, APIs, etc.
fyi @kkwong10

Stale.


⚠ Bofrost.com has degraded performance

In e187fd9, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 2097 ms

Resolved: Bofrost.com performance has improved in efb7481.


@xtina=starr => Launch ToolTips A/B/C test

Removes admin checks from tooltips, and adds control category.
Hold until QA is complete.

Looks good! 👍


bare bones delegation and agency agreements

Mike, Lisa, and Caleb to work on a gameplan today and get back to team.

Closing this because I think we are likely past bare bones and into the details.  Please reopen if still needed.


[WIP] memory-opt: add check for input, output and return bytes for precompile

TODO
Run testool again.
Description
Add check for input, output and return bytes for precompile (as bus-mapping).
Issue Link
Previous testool result
https://circuit-release.s3.us-west-2.amazonaws.com/testool/default.1687933681.e55d0b0.html

\b run testool


Use e2etestsuccess for mutation test

Fixes https://github.com/stolostron/backlog/issues/19992
Signed-off-by: Yu Cao<EMAIL_ADDRESS>

/test test-e2e-grc-framework

/unhold

/cherry-pick release-2.4


'create a set of radio button' challenge issue

Challenge Create a Set of Checkboxes has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

<form action="/submit-cat-photo">
  <input type="radio" name="personality"> Indoor
  <input type="radio" name="personality"> Outdoor
  <input type="radio" name="personality"> personal
  <input type="text" placeholder="cat photo URL" required>
  <button type="submit">Submit</button>
</form>

Hello.
When i run after this code it's not giving any response.

The <input type= should be "checkbox" you have "radio"

@umutcanaras
Thanks for reporting this. But your code is incorrect.
GitHub Issues are for reporting bugs on the website only.
Please use the Help chat room for getting challenge related help.
Happy Coding.

The name is not correct, it should be indoor-outdoor


ISPN-5423 JavaDoc fixes

separate javadoc generation into a dedicated module and use the
aggregate-jar goal
Fix the public API doclet so that it doesn't break with JavaDoc 8

https://issues.jboss.org/browse/ISPN-5423

Integrated


feature: eliminate distinct for max/min/any_value

Proposed changes
eliminate distinct for max/min/any_value function
max(distinct value) = max(value)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.8 seconds
stream load tsv:          533 seconds loaded<PHONE_NUMBER>9 Bytes, about 133 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size:<PHONE_NUMBER>0 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48 seconds
stream load tsv:          548 seconds loaded<PHONE_NUMBER>9 Bytes, about 130 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>9 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.91 seconds
stream load tsv:          547 seconds loaded<PHONE_NUMBER>9 Bytes, about 130 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size:<PHONE_NUMBER>2 Bytes


⚠ GitLab Server has degraded performance

In 78c115a, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 2208 ms

Resolved: GitLab Server performance has improved in 4c8fa2e.


feat(Modal + Dialog): add image prop to modal

Overview

Adds the new image prop to Modal + Dialog , which renders the image modal when provided.

PR Checklist

[x] Related to designs: here
[x] Related to JIRA ticket: [web-2311]
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change
[x] This PR includes testing instructions tests for the code change
[x] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Check out the image Modal examples in Storybook
Check out the image Dialog examples in Storybook

PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal PR
Portal Env

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.313-alpha.934a00.0@codecademy/gamut-labs@35.14.2-alpha.934a00.0@codecademy/gamut@53.2.0-alpha.934a00.0@codecademy/monaco@0.7.21-alpha.934a00.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://645033d3e0e2413b6b2e6916--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.314-alpha.5f94bc.0@codecademy/gamut-labs@35.14.3-alpha.5f94bc.0@codecademy/gamut@53.3.0-alpha.5f94bc.0@codecademy/monaco@0.7.22-alpha.5f94bc.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://64511badb3b74b11356b0e7d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.314-alpha.d03a83.0@codecademy/gamut-labs@35.14.3-alpha.d03a83.0@codecademy/gamut@53.3.0-alpha.d03a83.0@codecademy/monaco@0.7.22-alpha.d03a83.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-kit@0.6.314-alpha.a2cdeb.0@codecademy/gamut-labs@35.14.3-alpha.a2cdeb.0@codecademy/gamut@53.3.0-alpha.a2cdeb.0@codecademy/monaco@0.7.22-alpha.a2cdeb.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://645e6446f1d2640068c5ae10--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.314-alpha.4da7d0.0@codecademy/gamut-labs@35.14.3-alpha.4da7d0.0@codecademy/gamut@53.3.0-alpha.4da7d0.0@codecademy/monaco@0.7.22-alpha.4da7d0.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6462ad9525f822055a6fb283--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.316-alpha.115f7d.0@codecademy/gamut-labs@35.14.5-alpha.115f7d.0@codecademy/gamut@54.2.0-alpha.115f7d.0@codecademy/monaco@0.7.24-alpha.115f7d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6463b72cb0a9de06d13026ba--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.317-alpha.f75cd9.0@codecademy/gamut-labs@35.14.6-alpha.f75cd9.0@codecademy/gamut@55.1.0-alpha.f75cd9.0@codecademy/monaco@0.7.25-alpha.f75cd9.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://646524166a0fae062950fe61--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.318-alpha.5463a9.0@codecademy/gamut-labs@35.14.7-alpha.5463a9.0@codecademy/gamut@55.1.0-alpha.5463a9.0@codecademy/monaco@0.7.26-alpha.5463a9.0@codecademy/styleguide@66.0.2-alpha.5463a9.0


[Settings V2 UX] Improve logical groupings of the general page

The current General settings page could use some improved structure for the various settings as discussed in #2676.
Here's a proposal:
Running as .. (Title)

Always run as administrator..... (Checkbox)
Run at startup (Checkbox)
Restart as admin (Button)

Appearance (Title)

Choose settings color (Radiobutton group)

About PowerToys (Title) (In the side panel)

Version x.xx.x (clickable link to release notes)

Download updates automatically (Checkbox)

Check for updates (Button)

Various links

@htcfreek Please add your proposal of splitting the update section. I like that idea.

@niels9001 Do you know a WYSIWYG-Editor for XAML/WinUi3?

You could try Blend (it comes with Visual Studio), but most WYSIWYG editors won't give you code that's of high quality imo. Or you can try one of the toolkits for various design tools (e.g. Figma, Sketch or Adobe XD) but that won't give you code obviously.

In the following pictures you can see my proposal on the structure of the general settings page.
I did my best to respect the Guidlines for app settings.
Some of the ideas are my own and the other ideas are based on the issues #1482, #889, #964, #2354 and the comment form @niels9001 in this post.
The idea adding a link to the privacy settings is stolen from the MS Edge settings. 😉
Settings run as user & system telemetry off

Mock up image generated with MS Word and screenshots.
Settings run as administrator & system telemetry on

Mock up image generated with MS Word and screenshots.

Nice, I like this!
My thoughts:

We have a ' Learn about Admin mode' button in the latest build-features branch. I'd add that under the Restart as Admin button.
What are your thoughts around the 'Check for updates automatically' option? By default the app already does this, right? Not sure why we would like to disable this option, it could result in users being stuck on (very) old versions simply because they forgot to check manually?
I like the addition of adding a link to the GitHub read me. Maybe we can add a oneliner to point out the fact that this tool is open source?

@laviusmotileng-ms What are your thoughts?

We have a ' Learn about Admin mode' button in the latest build-features branch. I'd add that under the Restart as Admin button.

Why as button? I think a link would be better and more standardized.
The link could be shown betwen User Informationen and Restart Button. But only if PT is running as user.

What are your thoughts around the 'Check for updates automatically' option? By default the app already does this, right? Not sure why we would like to disable this option, it could result in users being stuck on (very) old versions simply because they forgot to check manually?

For example if PT is installed in companys on clients or servers, where the user had no rights to install software and the software gets updated by SCCM or other tools. (For this scenario normal users shouldn't be able to change the sittings.)
An other scenario would be an user who wants to check only manually every x days.

I like the addition of adding a link to the GitHub read me. Maybe we can add a oneliner to point out the fact that this tool is open source?

Great idea. I like it.
We should add this in the sidebar. We could have this in the "related links" section as a link to https://de.m.wikipedia.org/wiki/Open_Source.

Yep.. that's what I meant with 'button', a 'learn more' HyperlinkButton ;).
Right, I see - you might want to start a new issue for that. Please add the context you just described there as the 'user need'.
I think the oneliner only needs to describe the fact that this project is open source. The button could lead to this repo (with maybe a label like 'Contribute to this project' or something like that :)!

For example if PT is installed in companys on clients or servers, where the user had no rights to install software and the software gets updated by SCCM or other tools. (For this scenario normal users shouldn't be able to change the sittings.)
An other scenario would be an user who wants to check only manually every x days.

These type of choices need to be reviewed, please consult with @crutkas before making any change.

For example if PT is installed in companys on clients or servers, where the user had no rights to install software and the software gets updated by SCCM or other tools. (For this scenario normal users shouldn't be able to change the sittings.)
An other scenario would be an user who wants to check only manually every x days.

These type of choices need to be reviewed, please consult with @crutkas before making any change.

I have mentioned @crutkas in the new issue.

I have updated my mock ups to...

be more in line with the official settings app.
add some missing elements.
make some small text changes.

Settings run as user & system telemetry off

Settings run as administrator & system telemetry on

Link to Windows settings page "Diagnostics & feedback": ms-settings:privacy-feedback

Are you applying an order of importance to these layouts.  Common and important settings at the top.
There is a SystemErrorText ThemeResource you can use so the text is Red in Light and Yellow in Dark

Are you applying an order of importance to these layouts.  Common and important settings at the top.

I think is the best order in relation to how important the settings are. But I am free for other ideas.
Please have in mind that these are only image mock ups.

There is a SystemErrorText ThemeResource you can use so the text is Red in Light and Yellow in Dark

Great tipp.

Is the Telemetry options in the spec? Not seeing it in the latest build-features?

Is the Telemetry options in the spec? Not seeing it in the latest build-features?

#964

@niels9001
I think we should have the "Learn more about admin mode" under the setting "Always run as administrator" and should don't hide them. Then the users can read about it before enabling the setting "Always run as administrator".
What du you think?

@crutkas @laviusmotileng-ms
Do you agree (for the settings that we have at the moment)?
Should be a minor task with just some XAML changes. I can pick this up.

Go nuts

@niels9001
If we change the color setting into a dropdown/select menu button, we should do this on all settings pages, to have the same look and feel everywhere.
I am not shure about which pages are affect. It could be good to have a seperate issue for that.

I'd stick to the radiobuttons since it reduces cognitive load (vs. combobox) since there are only 3 options (that we won't extend). And it is inline with how the W10 Settings app does it.
Nice background info:
“Radio Buttons UX Design” by Nick Babich https://link.medium.com/8Ato02qql6

I'd stick to the radiobuttons since it reduces cognitive load (vs. combobox) since there are only 3 options (that we won't extend). And it is inline with how the W10 Settings app does it.

The default without choosing "Custom" is only a dropdown field.
See color choose win10

@crutkas Whats your thoughts about the following ideas/changes for the general page?
General settings page > Side panel

What about split side pannel in three sections:

About PowerToys
PowerToys is open source software.
Learn more
Github project page
We collect Telemetry data.
But we respect your privacy.
Privacy statement
Request a feature
Report a Bug

Example Images from Win10 Settings app

@niels9001 Why do you changed the text "Restart as administrator to change this setting" to "Restart as administrator to use this setting"? I think change is the better word than use. I wan't to change the setting and not want to use it for doing something.

@crutkas Whats your thoughts about the following ideas/changes for the general page?
General settings page > Updates

We should add a text hint that auto download only works when running in admin mode and not using a metered connection.
User should not be able to change auto download setting when PT run as user and then setting then must be disabled. (#2354)
If the setting is disabled we should have the hint "Only available when running as admin." in a seperate line above caption and control (see Guidlines), without brackets and in red/yellow.
What about having a seperate "Release Notes" link under the "check update" button instead having the number as link? - That would look more like official settings app.

General settings page > Side panel

What about split side pannel in three sections:

About PowerToys
PowerToys is open source software.
Learn more
Github project page
We collect Telemetry data.
But we respect your privacy.
Privacy statement
Request a feature
Report a Bug

@crutkas Can you please give us a feedback on this. Especially the about section changes. Thank you.

@niels9001
What about changing the toggle switch title "Download updates automatically" to "Download updates automatically when running with administrativ permission and I don't use a metered internet connection"? Then the user knows everything what is important and we don't need an explanation text under the toggle switch?
Moved to the issue that we can discuss it here!

@htcfreek, Lets pause and have single items here.  We are going to merge the main item here. This issue will be closed out for the the pending PR.
At this point, tweaks should be individual tracked issues so they can be discussed at their own merit.
Single issue, single topic, single PR

@htcfreek, Lets pause and have single items here.  We are going to merge the main item here. This issue will be closed out for the the pending PR.
At this point, tweaks should be individual tracked issues so they can be discussed at their own merit.
Single issue, single topic, single PR

@crutkas, @niels9001
I will create the issues later and we can merge the existing PR if no critical changes needed anymore.


OAuth vs Keys

@drewroberts I see we have Keys to add the API keys, but I believe this requires each company to add their API keys for each product. I just want to confirm this is still the direction you want to go and not have OAuth to pull in the keys automatically for each account.
@phuclh

When I set it up in the application, I added all of the products to the same Key. I don't think that web endpoint was moved yet to that package. Can you check?
I prefer using Keys so that we can have some Laravel apps that have multiple accounts in there.

@drewroberts I am adding Google Search Console API to the SEO package. So If we using Keys, the customer has to go to the Google Platform Console Dashboard to copy the key and then go to TGER Key resource and create the key while using OAuth, the access token is saved in a JSON file, the customer don' need to go over above steps. Moreover, we still have multiple accounts by creating multiple JSON files.


ComparisonIdentity.Structural.Compare returns different values for Option wrapped types

My regression tests for #513 have shown up the following inconsistency in existing f#:
printfn "%d" <| (ComparisonIdentity.Structural.Compare (SByte.MinValue, SByte.MaxValue))
printfn "%d" <| (ComparisonIdentity.Structural.Compare (Some SByte.MinValue, Some SByte.MaxValue))

Output
-1
-255

It is due to FSharpOption's type generic call to:
LanguagePrimitives.HashCompare.GenericComparisonWithComparerIntrinsic<T>(genericComparer, x, y);

Now I doubt if anyway is using comparers in any other way than < 0 or > 0, but they may be? #513 is a potentially breaking change because it returns -1 for the Option case - i.e. matching the primitive operation (although the affects of this breaking case, to Option comparison operations being sensitive to particular return values - is almost vanishingly small I would say..)
(The good news is that if in my regression limits Compare to (sign of Compare) then I'm getting no regression errors. I'll put my regression test up soon)

Playing around a bit this seems to be the case only for primitives that are < 32 bits. Even more smaller probability that this affects real code...

I have just fixed #513 to regression test properly (I.e. it now acts in same way as existing configuration), but this is still an oddity of the existing configuration along with the #527 & #556 (although this is less severe than those)

I don't think this is worth worrying about. It's well-documented that comparison results should only be considered for 0, < 0 or > 0.

I agree. (For regression purposes trying to just be 100% with what is currently there so I don't have to look at any individual cases, but I would like to achieve ComparerIdentity.Structural as equal to System.Collections.Generic.Comparers.Default where they shouldn't differ - even if it is still "valid": values)

Yes, this is not a bug, will close it as by design


[WIP] etcdserver: filter rpc request to learner

According to learner design doc, in v3.4 implementation, learner should reject all requests other than serializable read and member status API.
This WIP PR does the following:

Hard-coded allowed rpc types for learner node.

Added filtering in grpc interceptor to check if rpc is allowed for learner node. Returns ErrGRPCNotCapable if not allowed.

TODO:

Is this the proper way to filter rpc request to learner?
Filtering in later stage of the request handling chain will cause lots of duplicated code, as the request fans out to different servers (i.e. KV server, Lease server, Cluster server, etc) immediately after the interceptors.

The retry interceptor on client side will keep retry repeatedly for some of the rpc requests. Stop the retry if server returns ErrGRPCNotCapable?

Need to add tests in clientv3/integration to verify the intended behavior.

PTAL @WIZARD-CXY @xiang90 @jpbetz @gyuho. Suggestion wanted.

how about watch and lease stream request  can UnaryServerInterceptor intercept?

@WIZARD-CXY Good point. Those are not unary rpc request, which will need to be rejected in newStreamInterceptor. I'll add this to TODO.

agreed

LGTM

Thanks for all the comments. I am going to merge this, and address the open issues in separate PRs.


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.10.157

from: https://github.com/jenkins-x/jx

/retest


Add Kubernetes Version Support

This PR adds kubernetes version support by adding the KUBERNETES_VERSION env variable in the vagrant-up script.
Supported versions can be found when issuing:
curl -s https://packages.cloud.google.com/apt/dists/kubernetes-xenial/main/binary-amd64/Packages | grep Version | awk '{print $2}'
has to be inserted in the script without the "-00" part

Coverage decreased (-0.1%) to 76.695% when pulling 98304c36716b89b930724d97d904ed83886dc366 on brecode:master into 5524ba36c309d7d58d767f38df7e059e68484061 on contiv:master.


Boostrap loaded from external IE8

Hello everybody!
I'm here breaking my mind reading a lot on web and I would like to understand why this is happening with me. In a project with Symfony (php framework) I have:
<!DOCTYPE html>
<html lang="pt-BR">
    <head>
        <meta charset="utf-8" />
        <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"/>
        <meta name="viewport" content="width=device-width, initial-scale=1" />
        <title>...</title>
        <link rel="stylesheet" href="{{ asset('bundles/mysite/css/bootstrap/css/bootstrap.min.css') }}" />
        <!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
        <!--[if lt IE 9]>
            <script src="{{ asset('bundles/mysite/js/html5shiv.min.js') }}"></script>
            <script src="{{ asset('bundles/mysite/js/respond.min.js') }}"></script>
        <![endif]-->
    </head>
<body>
</body>
</html>

Basic the twig function asset in the code above does is generate the path to the file. In dev environment the path is the local server. Running under prod it adds a url to my Amazon S3 before the path. So in dev I have for example the path /bundles/mysite/css/bootstrap/css/bootstrap.min.css and in prod I have http://assets.mysite.com.br/bundles/mysite/css/custom.css.
The problem is with my responsive layout with IE8, in body I have a div like:
<div class="col-xs-12 col-sm-5">

So, running in dev it renders perfectly (col-sm-5 assumes control). Running with prod = with http://assets.mysite.com.br before css url only col-xs-12 works.
Anybody knows why this difference when bootstrap is loaded with a absolute url and without it?
Another personal issue is with icons render in IE8. I was reading  #9962 and #13657 and http://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/ but need to study more before starts another issue.

If col-xs-12 is what's applying then it sounds like the media queries aren't being parsed at all. Based on your scenario it sounds like you have the cross-domain issue mentioned in the README -- The script is unable to read your CSS files due to cross domain restrictions. Have you tried adding the proxy HTML, JS & GIF as outlined in the doc? The HTML file needs to be served from your CDN/S3 repo and the JS & GIF need to be from the domain serving the base page (invoking the respond.js script).

@cassianotartari Hello, have you found a solution to this problem ? I have the same issue in a Symfony production environment.

@ruslan-fidesio I can't remember what I did... I don't know if I solved the issue or simply abandoned the IE8. Probably this problem was addressed to this webpage.


Measurement widget: content needs some padding

Maybe 8px padding on left/right of content like Properties widget?

released in 0.12.1


CSS Bundling

CSS Bundling doesn't work quite as expected.  See - systemjs/builder#12 (comment)
https://github.com/Swimlane/angular-systemjs-seed/issues/3

Fixed in seed project.


Port swift/Immediate to Windows

Fix _MSC_VER condition to _WIN32
Add WIN32_LEAN_AND_MEAN and NOMINMAX
Fix LoadRuntimeLib to work when compiling with unicode
Change use of dlsym that is not available on Windows

@jrose-apple could you trigger testing for this. I assume I should also apply for testing privileges right?

@hughbe I got you.
@swift-ci please smoke test.

LGTM when @compnerd's happy with it.

@compnerd PTAL a when you have time, thanks

LGTM


(Rescinded) Violating TPDb Terms of Service

Hello,
I'm reaching out on behalf of TPDb and wanted to kindly ask that this repo be taken down as it's in violation of our Terms of Service sections 4, 5, 8, 12, 14, 15, and 17.
We appreciate your cooperation in this matter.
Thanks!

just a passerby, but this request seems to be in questionable faith at best
Re 4 and 5
#4

access or search or attempt to access or search the Services by any means (automated or otherwise) other than through our currently available, published interfaces that are provided by TPDb (and only pursuant to those terms and conditions);

#5

scrape the Services, and particularly scrape User Content from the Services;

by definition the script does not access your services.  It accesses a saved html file that a user provides

Separately, regardless on ones position on TOS, individual in question did not agree to your TOS and, for that simple reason, is not bound by them.

First off, my apologies @CollinHeist.
Thanks for pointing that out @bakerboy448. You're correct. The repo doesn't use any automated means to scrape the site and that was an oversight on my part. I will admit that I wasn't fully focused when submitting the issue, as I stepped away before submitting, and this weekend was exceptionally busy. I deeply regret the oversight and will be more diligent in reviewing and double-checking before sending any future requests.
After looking over the repo carefully, I am going to go ahead and close off the issue as it's out of scope. We've worked with the community on similar repos in the past and without issue.
Once again, I take full responsibility for the oversight and I apologize for any inconvenience it may have caused.

@tpdb-james Sorry for the delayed response, I don't check this repo very often.
No harm done, thanks for acknowledging the mistake! Always good to be diligent, and it is obviously not my intention to violate any TOS.

Thanks @woofwoof4everyonefoundation and @bakerboy448 for the responses.

Oh no worries at all, I totally understand.
My pleasure and thank you for your understanding! It's greatly appreciated 🙂


Cannot change git diff color

Minimal Config
-- Some other code

      lualine_b = {
        { 'fancy_branch' },
        {
          'fancy_diff',
          colored = true,
          diff_color = {
            added = '#98c379',
            modified = '#7199ee',
            removed = '#ee6d85',
          },
        },
      }

-- some other code

I get the error :

I tried editing according to this snippet :
sections = {
  lualine_a = {
    {
      'diff',
      colored = true, -- Displays a colored diff status if set to true
      diff_color = {
        -- Same color values as the general color option can be used here.
        added    = 'LuaLineDiffAdd',    -- Changes the diff's added color
        modified = 'LuaLineDiffChange', -- Changes the diff's modified color
        removed  = 'LuaLineDiffDelete', -- Changes the diff's removed color you
      },
      symbols = {added = '+', modified = '~', removed = '-'}, -- Changes the symbols used by the diff.
      source = nil, -- A function that works as a data source for diff.
                    -- It must return a table as such:
                    --   { added = add_count, modified = modified_count, removed = removed_count }
                    -- or nil on failure. count <= 0 won't be displayed.
    }
  }
}

from here

Update :
I tried using neovim's inherent colors like :
-- Some other code

      lualine_b = {
        { 'fancy_branch' },
        {
          'fancy_diff',
          colored = true,
          diff_color = {
            added = 'green',
            modified = 'yellow',
            removed = 'red',
          },
        },
      }

-- some other code

This didn't throw an error but also shows white text for add, rem and modified

Hi, thanks for reporting this. I will take a look over the week end and let you know.

From reading the Lualine docs, I think the problem is that when you pass a string to added, removed or modified, it expects a highlight (as defined by your color scheme). If you want to pass in custom RGB color, you need to provide a lua table with fg (and optionally bg defined). So for instance, with this:
{
    'fancy_diff',
    diff_color = {
        -- Same color values as the general color option can be used here.
        added = { fg = '#98c379', bg = "red" },
        modified = { fg = '#7199ee', bg = "green" },
        removed = { fg = '#ee6d85', bg = "blue" },
    },
}

you get what you wanted (I added the background color for emphasis):

I have to say the lualine docs are not super explicit about this 😅
I'll close this one as I think your problem is solved. Feel free to re-open if you encounter any problems or have any questions.


Convert to Typscript

Requirements:
Add me to EasyScriptJS organization.
And gimme credits

Add me to EasyScriptJS organization.

I will consider it, but it is not guaranteed as this project is run by the community and it wouldnt be fair to others contributing.

And gimme credits

You get them anyway.

@WilliamDavidHarrison. ig i solved everything, can you merge it.
Also check the issue i created.

uhh oops. reopening..


 It's an important feature if you want to set up the region boundaries precisely and need to playback the regions multiple times while doing fine adjustments.
The problem with the example in the demos is that it always overshoots the ending by  a random amount and using region events simply doesn't work.
Looking through the source code, I found that WebAudio backend supports a slightly more accurate method of pausing the audio at region end. Granted this method doesn't work for HTML audio element backend, but I think it would be worth documenting this feature somewhere, so people don't have to look for it in the sourcecode.
My solution requires the appropriate backend in the Wavesrufer constructor:
wavesurfer = WaveSurfer.create({
    container: '#segmentation-container',
    url: audio_url,
    backend: "WebAudio",
    ...
})

Next I create a playBetween method like this:
function playBetween(start, end) {
    wavesurfer.media.currentTime = start
    wavesurfer.media.play()
    wavesurfer.media.stopAt(end)
  }

Which I can use in various contexts, for example:
    regions.on('region-clicked', (r, e) => {
      e.stopPropagation() // prevent triggering a click on the waveform
      playBetween(r.start, r.end)
    })

Thanks that was useful I was experiencing the same issue with looping regions. I'll let you know once I try it.

Yea, this isn't really perfect for looping, but you could implement something yourself. To see how, you need to look at the implementation of the stopAt function:
https://github.com/katspaugh/wavesurfer.js/blob/2682460402457def3326e5e0bf33a0e1a3a8a799/src/webaudio.ts#L135-L148
It works similarly to the example case, but instead of looking for wavesurfer events, it is using a slightly more accurate buffer node events.
It's worth noting this is still far from perfect. The safest, most perfect approach would simply copy the portion of the buffer to a separate location (say another audio node) and simply play/loop that.

Has loop?

Again, this functionality (unlike stopAt) isn't implemented anywhere in the project. I got something to work, using this function:
 function loopBetween(start, end) {
  if (!wavesurfer.media.paused) return

  wavesurfer.media.paused = false

  wavesurfer.media.bufferNode?.disconnect()
  wavesurfer.media.bufferNode = wavesurfer.media.audioContext.createBufferSource()
  if (wavesurfer.media.buffer) {
    wavesurfer.media.bufferNode.buffer = wavesurfer.media.buffer
  }
  wavesurfer.media.bufferNode.playbackRate.value = wavesurfer.media._playbackRate
  wavesurfer.media.bufferNode.connect(wavesurfer.media.gainNode)

  wavesurfer.media.bufferNode.loop = true
  wavesurfer.media.bufferNode.loopStart = start
  wavesurfer.media.bufferNode.loopEnd = end

  wavesurfer.media.bufferNode.start(wavesurfer.media.audioContext.currentTime, start)
}

However, this won't advance the playhead, even if the audio does loop. You can check out the documentation here:
https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/loop

Hello, can you try to load large files through range slicing in wavesuier?

Again, this functionality (unlike stopAt) isn't implemented anywhere in the project. I got something to work, using this function:
 function loopBetween(start, end) {
  if (!wavesurfer.media.paused) return

  wavesurfer.media.paused = false

  wavesurfer.media.bufferNode?.disconnect()
  wavesurfer.media.bufferNode = wavesurfer.media.audioContext.createBufferSource()
  if (wavesurfer.media.buffer) {
    wavesurfer.media.bufferNode.buffer = wavesurfer.media.buffer
  }
  wavesurfer.media.bufferNode.playbackRate.value = wavesurfer.media._playbackRate
  wavesurfer.media.bufferNode.connect(wavesurfer.media.gainNode)

  wavesurfer.media.bufferNode.loop = true
  wavesurfer.media.bufferNode.loopStart = start
  wavesurfer.media.bufferNode.loopEnd = end

  wavesurfer.media.bufferNode.start(wavesurfer.media.audioContext.currentTime, start)
}

However, this won't advance the playhead, even if the audio does loop. You can check out the documentation here: https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/loop

However, the pointer of the wavesufer waveform does not run synchronously and is not linked to the waveform. Although audio playback is implemented

Thanks for your feedback. It's less about regions and more about the Web Audio playback option.
I'm reluctant to document the stopAt method as it's only available through this option which I see as a fallback for cases when MediaElement fails for some reason. For this same reason, the Regions example uses a crude and imprecise looping mechanism – because it works with the default MediaElement playback.


Feature request: add EnumProperty to improve Kotlin DSL

Expected Behavior
Sample interface:
public interface EnumProperty<T extends Enum<T>> extends Property<T> {
    void set(@Nullable String name);
}

Potential implementation:
@Override
public void set(@Nullable String name) {
    if (getType() == null || !Enum.class.isAssignableFrom(getType())) {
        return;
    }
    if (name == null) {
        set((T) null);
        return;
    }

    String enumName = name.toUpperCase()
            .replace('-', '_')
            .replace(' ', '_');
    T value = Enum.valueOf(getType().asSubclass(Enum.class), enumName);
    set(value);
}

Current Behavior
Currently, the Kotlin DSL has to use fully qualified and imported types to set Property<Enum> whereas the Groovy DSL can simply use string names. It would be nice if the Kotlin DSL could do the same.

An extension function in the DSL could also do the trick.
inline fun <reified T : Enum<T>> Property<T>.set(name: String?) = set(
    name
        ?.splitToSequence('-', ' ')
        ?.joinToString('_')
        ?.let { java.lang.Enum.valueOf(T::class.java, it) }
)

Thanks to the new assignment overloading in Gradle 8.2 (announced as experimental in v8.1.1), this is now possible on an enum-by-enum basis by defining an extension function:
fun Property<Values>.assign(value: String) {
  set(Values.valueOf(value))
}

Example usage
enum class Values {
  FOO,
  BAR,
  BAZ
}

abstract class MyTask : DefaultTask() {
  @get:Input
  abstract val prop: Property<Values>
}

fun Property<Values>.assign(value: String) {
  set(Values.valueOf(value))
}

tasks.register<MyTask>("myTask") {
  prop = Values.FOO // assignment overload provided by Gradle
  prop = "FOO"      // uses custom assignment overload, defined above
}

All enums
This extension function should enable assignment overloading for all Property<Enum<*>> properties, but I suspect this is risky because it's not possible to opt-out of the assignment overloading, and it would affect all Gradle Kotlin DSL files.
inline fun <reified T: Enum<T>>Property<T>.assign(value: String) {
  val enumValue = enumValueOf<T>(value)
  set(enumValue)
}

Perhaps enums could opt-in to string-assignment overload using an interface that the Enum could implement as a marker?
interface EnumStringAssignmentOverload

enum class AssignmentOverloadedValue : EnumStringAssignmentOverload {
  FOO,
  BAR,
  BAZ
}

Example usage
abstract class MyTask : DefaultTask() {
  // string-assignment will be available for this property
  @get:Input
  abstract val prop1: Property<AssignmentOverloadedValue>
  // string-assignment NOT available for this property
  @get:Input
  abstract val prop2: Property<RegularValue>
}

// only enable string-assignment for enums that implement the marker-interface
inline fun <reified T>
    Property<T>.assign(value: String)
    where T : Enum<T>, T : EnumStringAssignmentOverload {
  val enumValue = enumValueOf<T>(value)
  set(enumValue)
}

tasks.register<MyTask>("myTask") {
  prop1 = AssignmentOverloadedValue.FOO // assignment overload provided by Gradle
  prop1 = "FOO"                         // uses custom assignment overload, defined above

  prop2 = RegularValue.FOO // assignment overload provided by Gradle
  prop2 = "FOO" // ERROR Type mismatch
}

What the user wants to say is "prop1 should be set to the FOO value". I agree that having to say prop1 = Values.FOO is more verbose than prop1 = "FOO". However, by allowing string assignment we lose compiler support, which is a biggie.
Ideally, I think we should have prop1 = FOO and have FOO. Can we somehow hint IntelliJ to always do static imports for enum values in the context of Kotlin DSL?

Ideally, I think we should have prop1 = FOO and have Values.FOO be statically imported.

Instead, the language is moving towards allowing unqualified names when in specific contexts: https://youtrack.jetbrains.com/issue/KT-16768
I don't know if that will work with the assignment plugin or if additional effort is required.

That sounds exactly like the right solution to this problem. Let's close this then.

This is an issue with the Kotlin IDE support, which is developed by JetBrains and cannot be addressed in the Gradle Build Tool project.
Please upvote or/and add your use case to https://youtrack.jetbrains.com/issue/KT-16768


Consider dropping support for Python 3.4

The more versions of Python that are supported the harder it is to maintain and extend lifelines.
Forcing users to switch from Python2 to Python3 can be deal-breaking for some people despite Python2 nearing its death. However, moving from Python3.4 to 3.5 or 3.6 is trivial.
Python3.4 is incredibly slow compared to 2.7 and later versions of 3

Another alternative would be to configure Travis so that build failures on 3.4 do not cause the whole build to fail.
This wouldn't really help with the build time but it would be less burdensome for developers going forward.

I’m down with stopping support, but let’s make that change part of a larger release 👍

I can add a warning to users with Python3.4 recommending they change to python3.6/3.7.

mm, I don't think it's necessary to add a warning. I'm sure all the other packages will give the user a warning too.

Let's drop it in 0.16.0. Here's a graph of lifelines installs for 3.4:

From here: https://pypistats.org/packages/lifelines


Add an option to prevent trading with Zebra if Titanium is full

Describe the Enhancement
Add an option to prevent trading with Zebra if Titanium is full
There would be a checkbox under Trading > Zebra, when enabled (maybe with a limit lightning), it would not trade with Zebras if your titanium is full, or nearly full.
Currently, it'll trade every tick, even if your titanium is full.
Your Savegame
No response

I assume there's still blueprints and other resources to be gained from the trade, that's likely why it would still happen so often, even when limited. Otherwise, this might be a bug.
In general, I feel like this would be too specific of a setting to have, that just opens the door for more exceptions to make to trading behavior. This is likely better suited to be solved by a future feature.

I was just looking at this code in the context of blueprints from shark trades. If a trade has any output with limited capacity, and that output is already at or above capacity, then the entire trade is cancelled. The code path is the "Distribute max trades without starving any race" section, and then into getLowestTradeAmount, and then the loop that computes highestCapacity. It should return zero when any trade output is at capacity and the race should be spliced out of the array.  If either titanium or iron are full, there should be no zebra trades anymore. @OlivierGagnon if you can post a savegame I'd like to take a look.

If there is a real bug, it should be fixed, but from a feature perspective, we already have un/limited trading, and sometimes even that isn't enough options. If we want to go further, I feel like all the individual costs and results for a trade should be configurable individually for if they are to be taken into account. I don't like that level of complexity yet.
I am always open to expanding functionality that applies generically, but I don't like adding a singular option that just applies to Zebras and adds another exceptional behavior to the trading. The code is already probably way more complex that it needs to be.

Closing this for now, but always open for further discussion :)


Add sr-only and not-sr-only utilities

This PR adds a new accessibility core plugin that includes sr-only and not-sr-only utilities.
Their implementation is as follows:
.sr-only {
  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  margin: -1px;
  overflow: hidden;
  clip: rect(0, 0, 0, 0);
  white-space: nowrap;
  border-width: 0;
}

.not-sr-only {
  position: static;
  width: auto;
  height: auto;
  padding: 0;
  margin: 0;
  overflow: visible;
  clip: auto;
  white-space: normal;
}

sr-only is based on Bootstrap's implementation, with one notable difference being that we use border-width: 0 to remove the border instead of border: 0. This is to prevent blowing out our default Preflight border styles, so that if you need to apply not-sr-only to an item, the border utilities will start working as expected.
not-sr-only simply resets all of the properties set by sr-only. This class is useful if you want to make something visible at larger breakpoints but keep it visually hidden at smaller ones:

  <svg></svg>
  Settings

It can also be used with the focus variant modifier to make a visually hidden element appear when focused:

  Skip to content

If anyone has any feedback or suggested changes to this implementation let me know!
This blog post suggests that this implementation might actually be better than Bootstrap's:
.sr-only {
    border: 0;
    clip: rect(0 0 0 0);
    height: auto; /* new - was 1px */
    margin: 0; /* new - was -1px */
    overflow: hidden;
    padding: 0;
    position: absolute;
    width: 1px;
    white-space: nowrap;
}

...but since it hasn't been adopted yet by Bootstrap or HTML5 Boilerplate I'm a little hesitant to use it, since there might be issues that haven't been uncovered by mass usage.

I'm not usually a "if it's not broken, don't fix it" kind of guy...but when you're talking about web accessibility and standards that's the answer I would give you. I'd stick to the implementation that's used by governments and companies with a lot of money on the line: Bootstrap's.
I'm still not sure what the blog post is trying to fix or improve. A smaller class in CSS? What do you want in that CSS class? To be reliable and tested or to be a couple lines shorter?

This is awesome, great to see that tailwind is making this easier for people. For what it's worth maybe firing up a few screen readers is the best way to test the classes. Seem like they would work though 😁 (not an expert)

You don't need a tabindex on the skip link. It's an  with an href attribute. The element is already focusable.

the UK govt has a really decent team working on accessibility have their blog has so much on it. If you search stuff like GDS + Topic, normally something good e.g. https://accessibility.blog.gov.uk/2017/02/08/advice-for-creating-content-that-works-well-with-screen-readers/ loads of content and explanations on YouTube.
https://youtu.be/JHaLzm-FGsc This is great to help understand the complexity of forms if you really want to make really accessible interfaces

@adamwathan HTML5 Boilerplate switch to sr-only naming and fix clip : https://github.com/h5bp/main.css/blob/master/dist/_helpers.css#L14

This is great, the first thing I do when I start a project with Tailwind is take .sr-only from Bootstrap. Welcome addition 👍🏻

I've been using the https://github.com/webdna/tailwindcss-visuallyhidden plugin, but I think that it would be a great addition to Tailwind core.

Does anyone know why tools like this are needed when we have aria accessibility guidelines/attributes? I wonder if there are some shortcomings in using aria which is why Bootstrap include this utility out the box?

I think that ARIA and roles like aria-hidden are hiding the content from assistive technologies like screen readers (e.g. if an image is just presentational, so it doesn't need to be read), whereas this is visually hiding elements on the page but doing so in a way that they can still be read by screen readers like display: none would do.

@garygreen Unfortunately ARIA support in assistive technologies with a combination of potentially old browsers is dodgy at best.
Powermapper did a test recently with a few, common browser + screen reader combinations:
https://www.powermapper.com/tests/screen-readers/aria/
aria-label can fail in some instances even with screen readers that otherwise have nice support for it.
JAWS, NVDA and VoiceOver are the most commonly used screen readers and JAWS + IE is at the top in usage.
WebAIM stats from 2017: https://webaim.org/projects/screenreadersurvey7/
Another thing for css driven sr-only, you might want to hide something that's not purely just text. For example, a heading, that a screen reader can quickly jump to, but otherwise in your UI, you might not want anything there (common in app-ui). Or interactive elements just for screen readers, that makes it easier/possible for them to use a certain feature of the site, that would be otherwise impossible without mouse/sight.

This is awesome as a core plugin!!! Thank you for this work.
Just a heads up that VoiceOver has a nasty bug where it inverts the order of screen reader text and reads things backwards, which I've tracked down to the presence of margin: -1px via the references below. I have an open pull request to fix this for the tailwindcss-visuallyhidden plugin. Can you test this particular scenario? https://github.com/webdna/tailwindcss-visuallyhidden/pull/6
For those interested, here are the references where others have hit the same issue, and @nickcolley has done extensive testing with different assistive technologies.
https://github.com/h5bp/main.css/issues/12
https://gist.github.com/nickcolley/19b80ed24d0364cfd3afd3b1b49c4014

Just a heads up that VoiceOver has a nasty bug where it inverts the order of screen reader text and reads things backwards

Yeah I've seen this, and the proposed solution to fixing this is the one I mentioned in the original comment of this thread:

I don't have enough experience with this stuff to test it properly though, so I'm hesitant to deviate from Bootstrap. If this ends up being the better solution I'm sure they will update their class and we can follow suit.

Gotcha. I didn't realize that updated snippet from the blog post referenced was also dealing with the inverted reading. Gonna read that now. 👍

I should've just linked to the GitHub thread, the blog post doesn't mention it until the end, heh.

I should've just linked to the GitHub thread, the blog post doesn't mention it until the end, heh.

Interesting, I dug into bootstrap's version a bit and it looks like the v5 dist file has an updated sr-only class. I know v5 hasn't been officially released yet, but good to know they're giving attention to it.
https://github.com/twbs/bootstrap/blob/master/dist/css/bootstrap.css#L7139-L7157
.sr-only {
  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  overflow: hidden;
  clip: rect(0, 0, 0, 0);
  white-space: nowrap;
  border: 0;
}

.sr-only-focusable:active, .sr-only-focusable:focus {
  position: static;
  width: auto;
  height: auto;
  overflow: visible;
  clip: auto;
  white-space: normal;
}

It's changed a bit even since then, our implementation is based on this recent PR:
https://github.com/twbs/bootstrap/pull/28720

We (Bootstrap) changed the implementation of the .sr-only and .sr-only-focusable, the latest implementation also generates less css:
.sr-only,
.sr-only-focusable:not(:focus) {
  position: absolute !important;
  width: 1px !important;
  height: 1px !important;
  padding: 0 !important;
  margin: -1px !important;
  overflow: hidden !important;
  clip: rect(0, 0, 0, 0) !important;
  white-space: nowrap !important;
  border: 0 !important;
}

We don't have the ability to generate responsive classes like tailwind has though, might be something to look into later
The reason why we used the margin: -1px because of this weird bug: https://github.com/twbs/bootstrap/issues/25686#issuecomment-469910178.
The latest implementation is available via this url: https://twbs-bootstrap.netlify.com/docs/4.3/helpers/screen-readers/

The reason why we used the margin: -1px because of this weird bug: twbs/bootstrap#25686 (comment).

Truly the weirdest bug I've ever seen. Do you know when it shows up in practical situations? The margin: -1px thing causes things to be read in the wrong order by VoiceOver on macOS so have to decide which consequence is the lesser evil I guess.

The issue I linked to is the only scenario I know of. margin: 0 0 -1px; also seems to fix the issue, but I'm not sure what the effect is for the VoiceOver on mac (not sure how that works tbh).

Going to merge this as-is despite the VoiceOver issue because it's good enough for Bootstrap and it's better than offering nothing. We can refine this in the future if a more bullet-proof solution ever surfaces.


Is the TF controller prod ready ?

Hi Team,
Great work !
Wanted to check if the controller is prod ready and what all AWS services are supported at present.
Thanks.

I know of some using this in production, had some issues earlier but they have been iron out. I suggest you try and see if it is in a state you are comfortable with.
As to what is supported, I haven't come across limited functionality in terms of the providers. You should be able to use all of the available AWS provider functionality.
I have seen AWS and Newrelic providers used and I think I've heard use of Azure somewhere as well.
Thoughts @chanwit?

@Nalum thank you for the ping.
@Varsha-Shrivastava we know that some companies are using this in the production environments.
There's no known issue with the AWS provider so far. Some even use it in a special AWS region.
With the Azure provider, we now offer a specific image which bundles required binary, so yes it would be working fine.
For scalability, we have been tested it under high loads. Our implementation is horizontally scalable as it uses the controller-runner architecture. It is known to handle 1,500 Terraform objects concurrently.
But of course, we still have many issues and improvements to address.

Thank you both of you.
I assume same is the case with Flux Subsystem for Argo(FSA).

I have been running it in a staging environment for a few weeks and am comfortable enough to deploy to production in the near future.
My take is that the majority of the features are ready and stable. There might be some kinks to iron out as users try it out with their environment configurations and constraints.
My recommendation is also to try it out and let us know!

Please report this issue to the Flamingo repo. I'll take care of it there.

sure. doing it right away.

@chanwit could you pls check the above query.

Thank you for the ping @Varsha-Shrivastava
Hi @imdurgadas
TF-controller does not support, but do offer equivalent capabilities similar to Terragrunt, including dependency management between root modules.
With Flux Kustomization controller + TF-controller, you would also manage multi-environment infra similar to Terragrunt.

@chanwit - Thanks for the response. Is there any reference that you can share so that we could follow and try it out. That would ensure we are doing it the right way as recommended.

@imdurgadas @phoban01 created a neat POC to demonstrate keeping your TF dry using tf-controller and kustomize-controller: https://github.com/phoban01/flux-terragrunt-poc

For anyone following this issue, my team and I at @masterpointio are investigating production usage of TFController and would love to chat with anyone outside of weaveworks (just want to get some unbiased opinions 😁) who is utilizing the tool in production. Please reach out (email in my profile) if you're willing to chat through your usage of this tool!

Hi @chanwit, do you have plans to support terragrunt in the future?
Although some of the features of tf-controller can replace some of the features that terragrunt has, there are other features such as; remote state configuration DRY, CLI flags DRY, before and after hooks, sops support, etc. which are very useful when managing multiples resources in different directories, and this makes it not easy to migrate a project transparently to tf-controller.

Hi @fabidick22
Support Terragrunt is definitely a useful feature for many users.
I have been spending time investigate this topic and found that it seems to be a big thing to the controller, engineering-wise. It's not as simple as adding Terragrunt binaries to the system because Terragrunt has its own workflow.
if we decided to support it, Terragrunt would be implemented separately as another Custom Resource of the controller.
And both of CRs would share the underlying architecture.
What do you think about it?

Hi @chanwit
Makes sense, especially to avoid the complexity of the manifests and to be able to specify the versions of terragrunt that are compatible with the terraform version.

@chanwit -- Just talking about the idea of TFC + Terragrunt with my team yesterday, and I'd love to get the capabilities of Terragrunt's dependency block within TFC. Whether through direct Terragrunt support or a similar mechanism directly in the CR for the controller. Is that something you folks are thinking about or potentially working on?


Update README with usage information

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           20        20
  Lines          476       476
=========================================
  Hits           476       476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b68dcc...70de692. Read the comment docs.


All the requirements

From enviroment.yaml:
channels:
- http://ssb.stsci.edu/astroconda
- defaults
dependencies:
- pip
- astropy
- scipy
- matplotlib
- scikit-image
- scikit-learn
- pyyaml
- cython
- photutils
- astroquery
- pyregion
- stsci.image
- stwcs
- hstcal
- wfc3tools
- crds
- drizzlepac
- shapely
- boto3
- tqdm
- pip:
  - astro-sedpy
  - astro-prospector
  - sep
  - peakutils
  - extinction
  - descartes
  - git+https://github.com/gbrammer/reprocess_wfc3.git
  - git+https://github.com/gbrammer/eazy-py.git
  - git+https://github.com/gbrammer/tristars.git
  - git+https://github.com/gbrammer/sregion.git
  - git+https://github.com/gbrammer/mastquery.git

From requirements.txt
`astropy
scipy
matplotlib
scikit-image
scikit-learn
pyyaml
cython
photutils<1.1 needed for drizzlepac==3.2.1
#photutils==1.0.2
photutils
astroquery
pyregion
explicit version for gh actions (2.3.5 was causing problems)
#stsci.image==2.3.3
stsci.image
stwcs
hstcal (only works with conda)
wfc3tools
crds
drizzlepac
shapely
descartes
git+https://github.com/benjimin/descartes.git
boto3
peakutils
extinction
tqdm
Needed for template smoothing, doesn't bring whole fsps distro
astro-sedpy
astro-prospector
sep
git+https://github.com/gbrammer/sep.git
coord routines work without pyia
#git+https://github.com/gbrammer/pyia.git
git+https://github.com/gbrammer/reprocess_wfc3.git
git+https://github.com/gbrammer/eazy-py.git
git+https://github.com/gbrammer/sregion.git
sregion>=1.0
git+https://github.com/gbrammer/tristars.git
git+https://github.com/gbrammer/mastquery.git
mastquery>=1.4`

From instructions:
pip
numpy
cython
hstcal
pytest
eazy-py
awscli
boto3
git clone https://github.com/cmccully/lacosmicx.git

Combined list of all the requirements:

pip
astropy
scipy
matplotlib
scikit-image
scikit-learn
pyyaml
cython
photutils
astroquery
pyregion
stsci.image
stwcs
hstcal
wfc3tools
crds
drizzlepac
shapely
boto3
tqdm
pip:

astro-sedpy
astro-prospector
sep
peakutils
extinction
descartes
git+https://github.com/gbrammer/reprocess_wfc3.git
git+https://github.com/gbrammer/eazy-py.git
git+https://github.com/gbrammer/tristars.git
git+https://github.com/gbrammer/sregion.git / sregion>=1.0
git+https://github.com/gbrammer/mastquery.git / mastquery>=1.4
git+https://github.com/gbrammer/pyia.git?

awscli
boto3
git clone https://github.com/cmccully/lacosmicx.git

Combined list of requirements, grouped by requirement:
Build Requirements
These will go into pyproject.toml (along with setuptools & wheel; if #6 is merged)
- cython
- numpy

Runtime Requirements
- astropy
- astroquery
- crds
- drizzlepac
- hstcal
- mastquery>=1.4
- matplotlib
- numpy
- photutils
- pip
- pyregion
- pyyaml
- scikit-image
- scikit-learn
- scipy
- shapely
- stsci.image
- stwcs
- tqdm
- wfc3tools
- pip:
  - astro-prospector
  - astro-sedpy
  - descartes
  - extinction
  - mastquery >=1.4
  - peakutils
  - sep
  - sregion >=1.0
  - git+https://github.com/gbrammer/reprocess_wfc3.git
  - git+https://github.com/gbrammer/eazy-py.git
  - git+https://github.com/gbrammer/tristars.git
  - git+https://github.com/cmccully/lacosmicx.git

Note: descartes, extinction, peakutils and sep have their latest PyPI versions also on conda-forge (which builds directly from PyPI). If we want, we can install them with conda instead of with pip, though to the end user it will make no difference!
Additionals
We may add these under [options.extras_require], with test and hst keys.
Testing
- pytest

AWS
If full HST pipeline reduction is desired.
- awscli
- boto3

Agree that having extras such as test, hst and jwst would be excellent.
Further, we can eventually fix the github action that checks the build to use modern tools as well, as now that the build dependencies are in pyproject.toml, there's no need to install them in the github workflow.
https://github.com/ivastar/grizli/blob/f9e764b97954cff55b5714869f8a07ab5abad700/.github/workflows/python-package.yml#L30-L39

It would also be good to just remove requirements.txt completely so we're keeping track of dependencies in one place and one place only.  If we wanted to make an [all] extra to capture the requirements.txt, that would be fine too I think.
By keeping all requirements in setup, then the install instructions are very simple for all the use cases:
pip install grizli[all]

or
pip install grizli[hst,aws]
pip install grizli[jwst,test]

etc.

Finally we should always prefer installing from pypi instead of conda, unless there's a really strong reason not to (i.e. a binary is needed and the package is not maintained well (doesn't install easily if compile is needed).  I don't think this the case for any of these dependencies though.

Done.


Exclude vendor dirs from git CRLF normalization

Should get rid of a few warnings like at the end of lint-backend like https://drone.gitea.io/go-gitea/gitea/23117/1/4.

@silverwind you have to make vendor and commit with new-old line endings

Done, let's see if it passes now without warnings.

passed :+1:

It passed and warnings are gone: https://drone.gitea.io/go-gitea/gitea/23122/1/4 🎉

first ;)

Codecov Report

Merging #10911 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10911      +/-   ##
==========================================
- Coverage   43.50%   43.48%   -0.02%
==========================================
  Files         597      597
  Lines       83945    83945
==========================================
- Hits        36517    36501      -16
- Misses      42914    42928      +14
- Partials     4514     4516       +2

Impacted Files
Coverage Δ

services/pull/check.go
48.17% <0.00%> (-7.32%)
:arrow_down:

modules/process/manager.go
74.69% <0.00%> (-3.62%)
:arrow_down:

modules/git/command.go
86.95% <0.00%> (-2.61%)
:arrow_down:

services/pull/patch.go
61.93% <0.00%> (-2.59%)
:arrow_down:

services/pull/temp_repo.go
29.05% <0.00%> (-2.57%)
:arrow_down:

models/notification.go
61.68% <0.00%> (-0.79%)
:arrow_down:

models/error.go
30.49% <0.00%> (-0.54%)
:arrow_down:

modules/git/repo.go
48.11% <0.00%> (+0.83%)
:arrow_up:

services/pull/pull.go
35.88% <0.00%> (+0.88%)
:arrow_up:

models/unit.go
44.44% <0.00%> (+2.46%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d99ee2...35da12f. Read the comment docs.


docs: Add favicon to docs site

Adds favicons to the docs site. This change should go live with the
next release.
Fixes #284
Signed-off-by: Charith Ellawala<EMAIL_ADDRESS>

Preview: https://613f3cf186acee524473b277--cerbos-docs.netlify.app/cerbos/0.7.0/index.html


minor grammar fix(second -> section)

Seems like this PR pulled in a lot of un-related files. Could you rebase or open a new PR with just the relevant changes?


Injective improvements

Description and Motivation

Related Issues

Checklist:

[ ] I have read Migaloo's contribution guidelines.
[ ] My pull request has a sound title and description (not something vague like Update index.md)
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation.
[ ] The code is formatted properly yarn lint.
[ ] The project builds and is able to deploy on Netlify yarn build.

you can add changes to my branch next time 👍


ValueChanged callbacks don't document the T

The doc generated for a ValueChanged valued callback doesn't reveal the type of its parameter.
For example see onChanged here: https://docs.flutter.io/flutter/material/Checkbox-class.html

Open this over at https://github.com/dart-lang/dartdoc/issues/1263 (at least, I think this is a dartdoc issue)

Looking into it


ref: Require initializing a client to use the code

The github_sdk module should not read environment variables but rather requiring it to be configuring explicitly.
This will enable further configurations in the future like defining what types of events should be processed rather than hard-coding it.
This also increases the code coverage by calling send_trace.

Codecov Report

Merging #20 (891b6be) into main (7b35a1f) will increase coverage by 17.76%.
The diff coverage is 98.36%.

@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
+ Coverage   53.54%   71.31%   +17.76%
===========================================
  Files           4        3        -1
  Lines         127      122        -5
===========================================
+ Hits           68       87       +19
+ Misses         59       35       -24

Impacted Files
Coverage Δ

src/github_sdk.py
94.73% <98.14%> (+21.31%)
:arrow_up:

src/handle_event.py
100.00% <100.00%> (ø)

src/main.py
0.00% <0.00%> (ø)

cli.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b35a1f...891b6be. Read the comment docs.


Output polyN stretches in .cf_seq file

Changed reduced GFA format to output where polyN stretches occur w.r.t output unitig tiling.
PolyN stretches are encoded N\d, with N prepended to the number of Ns.
Output tilings look like:
$ cat tiny.fa
>I dna:chromosome chromosome:R64-1-1:I:1:230218:1 REF
NNNCACACACCACNCGTATTGAGG
$ cat tiny.cf_seq
Reference:1_Sequence:I	N3 3+ N1 2-

@rob-p @jamshed this might be a breaking change for consumers downstream.

Currently walks from the cf_seq are equivalent to those in the GFA format, hence "reduced GFA" I suppose, implementing this change would break that. This would be nice for looking at homopolymers specifically, but our application for example would require substantially more processing when having to check for the presence of homopolymer notations rather than 1:1 reading node ids. This seems to be a specific case rather than a general case so if pushed please make this optional @jamshed

Hi @rickbeeloo,
This change should apply only to the "reduced GFA" format. However, if you're using this currently and expect that this would be a breaking change, I think it would be possible to either (a) provide the modified output only when an additional flag is provided or (b) add an addition output "format" which is basically "reduced GFA with polyN tracking".  @jamshed — any preference among (a) or (b)?
--Rob

Hi @rob-p and @rickbeeloo: interesting discussion! Outputting the poly-N stretches in the tilings this way would not satisfy the GFA-specs (which the "reduced" format encodes space-efficiently); see these paragraphs: Path line (for GFA 1) and Group (for GFA 2). I think that instead of introducing yet another output format, we can introduce something like a --poly-N-stretch flag, that would output these stretches (and would thus deviate from the GFA-specs). What do you think?
Regards.

I also think that would be the nicest! The tool we are working on will just use the "paths" so using the Cuttlefish reduced format is a big advantage - storage-wise. Currently, we can allow both the traditional GFA and reduced GFA as the path lines are equivalent.

Going to merge this and then add the flag.

Ok, I added the flag in 09f09bd84b64a45b5b379ed5696c8745cb801ced and checked that it works with @theJasonFan's tiny test case (we get the poly-N tiles with --poly-N-stretch and we don't get them without it).
Some command line parameter checking could be improved here by e.g. validating that this flag is only passed when GFA-reduced output format is requested.


Keep the left alignment

This will keep the left alignment of the element. Without this, the element will not stick well using twitter bootstrap col-* for example.
For example, members column should stick and stay right:

but does not

Any feedback?

Hey @chamerling,
Initially I was a little skeptic on where you got the absoluteLeft var from, as the code changes do not create any absoluteLeft variable, but after looking at the code I realized it is already set up in the code, I don't know why I did nothing with it. Sorry for the delay, I've been really busy with another project. I'll merge and update the version number, Thanks a lot! :)

No problem, thx for the merge
++


最新Spring boot集成Dubbo 报错  No application config found or it's not a valid config! Please add <dubbo:application name="..." /> to your spring config.

dubbo-spring-boot-starter  version: <IP_ADDRESS>
Spring Boot version: 2.2.1.RELEASE

application.properties

DemoServiceImpl

HhhhApplication
`
@SpringBootApplication
@EnableDubbo
public class HhhhApplication {
public static void main(String[] args) {
    SpringApplication.run(HhhhApplication.class, args);
}

}`
报错信息

java.lang.IllegalStateException: No application config found or it's not a valid config! Please add <dubbo:application name="..." /> to your spring config.

I will check this problem soon.

There is no error in my side, how to reproduce it?


material-ui

It seems that material-ui react components cannot be displayed with carte-blanche:
Failed Context Types: Required context `muiTheme` was not specified in `CircularProgress`.

@FredericHeem yes you must pass context to the material-ui components.
In theory you can add MuiThemeProvider to the carte-blanche's main component App
import MuiThemeProvider from 'material-ui/styles/MuiThemeProvider';
...

          <MenuButton
            onClick={this.toggleMenu}
            drawerOpen={this.state.drawerVisible}
          />
          {(this.props.children) ? (
            <MuiThemeProvider>
               this.props.children
            </MuiThemeProvider>
          ) : (

Home

Get started by selecting a component on the left 🙌

          )}

@w01fgang did your fork it to get this working?
I was thinking if we allow to create your own container as an options …

@nikgraf no, I didn't fork it because I don't have much time, but I use material-ui for a long time and I know well this error.


pylint: formatting and typo bugfixes

Hi,
Here are some small changes that fixes some issues pointed out by pylint.
Most importantly:

an indentation error
typo in a member
dangerous use of [] as default argument

Thanks for that :)


Handling multiple events in a single transaction

Currently, events will be protected from replay protection by checking against the transaction id + block that they originate. This means that two events coming from the same transaction id + block may be considered as the same event, even when there may be two different events in the same transaction.
We need to make sure we can handle this scenario. This should be handled when we migrate to block/transaction processing through light clients, deprecating current dummy verification

fixed with channels


"End" key should move to the real line end on first press

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

githistory
donjayamanne
0.2.0

jquerysnippets
donjayamanne
0.0.1

python
donjayamanne
0.6.5

php-debug
felixfbecker
1.10.1

php-intellisense
felixfbecker
1.4.1

vscode-phpfmt
guodf
0.0.4

vscode-auto-open-markdown-preview
hnw
0.0.4

ftp-sync
lukasz-wronski
0.3.3

laravel5-snippets
onecentlin
1.3.4

laravel-artisan
ryannaddy
0.0.7

vscode-nginx
shanoor
0.3.1

bootstrap-3-snippets
wcwhitehead
0.0.9

local-history
xyz
1.2.1

Steps to Reproduce:

Set "editor.wordWrap": "on",
Focus a long line
press 'End' key

How can  I  move to the position 2?

Pressing End first takes me to position 1 and the second press takes me to position 2.
Perhaps an extension changes the keybinding for "End"? (You can find this out by searching for "End" in the keybindings editor). Does this reproduce when running code --disable-extensions?

Think you!
I'd like a  "setting" to control this perform. (Press once or twice
要是有“设置”可以控制是否直接到行尾就好了。

Can this be resolved by using extension macros?
settings.json
"macros": {
    "end2x": [
        "cursorEnd",
        "cursorEnd"
    ]
}

keybindings.json
{
    "key": "end",
    "command": "-cursorEnd",
    "when": "editorTextFocus"
},
{
    "command": "macros.end2x",
    "key": "end",
    "when": "editorTextFocus"
}


PrincipalNotFound when using policyAssignments

Description
Hi!
I've a customer which is trying to use the policyAssignments module to assign a policy with a RBAC.
Each time they try to assign a policy, the bicep module doesn't found the principal and ends up in error the first time.
After they restart the pipeline a few minutes later everything is fine.
Steps to reproduce

Assign a policy which needs a RBAC
The deployment ends in error with the message: PrincipalNotFound: Principal xxxxx does not exist in the directory yyyyy
Restart the deployment a few minutes later, everything is fine

Thanks!

@kevinpz , this sometimes happens when AAD DB sync may have some delay when being queried for the same principal ID that has been created for the system managed identity for the policy. There should be a retry mechanism that attempts to redeploy when this happens and usually is successful on the next run. Can you please check if the logs for the deployment contains:
VERBOSE: Resource deployment Failed.. (1/3) Retrying in 5 Seconds..

Hello @ahmadabdalla ,
I'm working with @kevinpz on the issue, I've checked the logs and it doesn't contain
VERBOSE: Resource deployment Failed.. (1/3) Retrying in 5 Seconds..
Could you give us more details on how to implement a retry nechanism?
Thanks

I am not sure what deployment mechanism you're using. The current pipelines use this script to deploy resources, which we've added a retry mechanism in there, set to 3 times as default.

Hello @ahmadabdalla,
Our deployement pipeline are yml file with Stages and Job, which call bicep files that then call the modules in the arm folder, which seems to be really different than the powershell script you're using.
Using YAML pipeline with Stage and Jobs, is there a way to add a retry on fail mechanism?
Here's an exemple of what our pipeline looks like:
`parameters:

name: NameOfServiceConnection
type: string
default: ""
name: scope
type: string
default: 'sub'
name: location
type: string
default: 'TheRegion'
name: environment
type: string
default: 'dev'
name: templateFile
type: string
default: './.pipelines/test/main.bicep'
name: mgmtGroupId
type: string
default: ''

stages:

stage: Validate_Bicep_Stage_${{ replace(replace(parameters.environment, '/', ''), '-', '') }}
dependsOn: []
displayName: "Validate [${{ parameters.environment }}]"
jobs:

job: Validate_Bicep_Job
timeoutInMinutes: 180
displayName: "Validate Bicep [${{ parameters.environment }}]"
steps:

checkout: self
template: ${{ parameters.scope }}.yml # Template reference
parameters:
action: 'validate'
environment: ${{ parameters.environment }}
azureServiceConnection: ${{ parameters.NameOfServiceConnection}}
location: ${{ parameters.location }}
templateFile: ${{ parameters.templateFile }}
mgmtGroupId: ${{ parameters.mgmtGroupId }}

job: What_If_Bicep_Job
timeoutInMinutes: 180
displayName: "What-If Bicep [${{ parameters.environment }}]"
steps:

checkout: self
template: ${{ parameters.scope }}.yml # Template reference
parameters:
action: 'what-if'
environment: ${{ parameters.environment }}
azureServiceConnection: ${{ parameters.NameOfServiceConnection}}
location: ${{ parameters.location }}
templateFile: ${{ parameters.templateFile }}
mgmtGroupId: ${{ parameters.mgmtGroupId }}

stage: Create_Bicep_Stage_${{ replace(replace(parameters.environment, '/', ''), '-', '') }}
displayName: "Create [${{ parameters.environment }}]"
dependsOn:

Validate_Bicep_Stage_${{ replace(replace(parameters.environment, '/', ''), '-', '') }}

- Linter_Bicep_Stage_${{ replace(replace(parameters.environment, '/', ''), '-', '') }}
condition: and(succeeded(), eq(variables['Build.SourceBranchName'], 'main'))
jobs:

deployment: Create_Bicep_Job
timeoutInMinutes: 180
displayName: "Create Bicep Job [${{ parameters.environment }}]"
environment: ${{ parameters.environment }}
strategy:
runOnce:
deploy:
steps:
- checkout: self
- template: ${{ parameters.scope }}.yml # Template reference
parameters:
action: 'create'
environment: ${{ parameters.environment }}
azureServiceConnection: ${{ parameters.NameOfServiceConnection}}
location: ${{ parameters.location }}
templateFile: ${{ parameters.templateFile }}
mgmtGroupId: ${{ parameters.mgmtGroupId }}`

The template:
template: ${{ parameters.scope }}.yml # Template reference

Is that using a Powershell task within it to deploy? What I can think of at the top of my head is implementing a duplicate step that uses a condition Example
condition: and(failed(), eq(variables['Build.SourceBranchName'], 'main'))

which may work as a retry. I haven't tested this obviously, but it is a task that runs on failure, but not sure if that'll fail the pipeline if the previous step already failed.

Hello @ahmadabdalla ,
To your question: "Is that using a Powershell task within it to deploy?", the anser is no.
The Yaml file we have is calling a bicep file, and that bicep file is calling the modules in the arm folder.
So anyway to specify a retry step in our YAML pipeline files, that use Stage, Jobs, etc?

@shanhyland , have a look at this guidance and see if you can add that to the task?

@azMantas , thank you and great suggestion and similar on role-assignments.  I've added this to the policy assignments module - role assignments and will raise a PR accordingly.

@shanhyland , completing the PR closed the issue. Please have a look at the solution provided by @azMantas and add that to the module. I have also updated the policy assignment module to enforce the principal type so others can benefit from it.

@shanhyland , have a look at this guidance and see if you can add that to the task?

@ahmadabdalla  Sorry for the delay, and thanks for the link.
The retry would probably work, but the problem doesn't "happen" in a Task, I'll look at the new code you Push.
Thanks


Case Data still off by one day

According to Frederik there is still an offset in the date of the displayed case data.
e.g. ESID shows 2023-11-19 as the last date of data (the api also has this as the last date of the result).
but according to the metadata of the files uploaded by airflow it should be 2023-11-20.
We may need to investigate whether this is an issue of the upload to the database or if there is an issue when generating the response for the api request.

I think this has been resolved. The issue wasn't in this repo, but rather in an internal pipeline.


add list docs

similar to array.

What about using F# documentation as a reference: https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/lists

I like the look of the F# documentation.  I think we can work towards that incrementally, method level stuff can probably come from docgen... interesting point here is the F# page combines high level conceptual stuff with docgen level api stuff.  So do we do the same and bulk up the list.lean code with tons of big paragraphs, or do we keep them separate, but merge them somehow with some kind of new leanink instruction like {{insert docgen api here}}...

I like the look of the F# documentation. I think we can work towards that incrementally, method level stuff can probably come from docgen... interesting point here is the F# page combines high level conceptual stuff with docgen level api stuff. So do we do the same and bulk up the list.lean code with tons of big paragraphs, or do we keep them separate, but merge them somehow with some kind of new leanink instruction like {{insert docgen api here}}...

I am confused by this PR. In our last weekly meeting, I think I said we should use docstrings and module docstrings to document APIs. Then, I got the PR request review yesterday, and I assumed you wanted to do it using mdbook. I suggested the F# documentation because it is high quality, and I was concerned about the content and explanations in this PR would put Lean users in the wrong direction.

I am confused by this PR.

Well I still think there's a need for a quick conceptual overview on lists which is what this is trying to be.  It is the information I gleaned from various code snippets and samples along the way that I wish I had in this document from the beginning.
The full doc generated pages from doc comments would look more like this: https://fsharp.github.io/fsharp-core-docs/reference/fsharp-collections-listmodule.html
But if you think the content I added is wrong or leading people in the wrong direction then please tell me where.  If you think the whole thing is hopeless and need to go in the trash can then that's fine I'll cancel the PR.
I was just trying to help fill in some of the worst holes in the reference manual in time for the Jan class and I figured this would be an easy one since lists are pretty simple and I was copying the patten I saw in the existing document on arrays.md.

Perhaps this could be a temporary stop gap measure - filling the hole we have in the lean4 manual on Lists until a real Lean Expert gets the time to rewrite it.

@lovettchris Mario is making a lot of progress on the doc strings. We will soon have great doc strings for Lists.
I will close this PR.


Detect cyclic dependency using reflection abstract factory

This is a new feature whereby cyclic dependencies are detected in a bit of an edge case. Example illustrated here: https://gist.github.com/asgrim/72f3ee4c25b901ffed58501657ea98da
I've written the test which demonstrates what I'm trying to do, but the implementation I feel is really sub-par however. My plan to implement was simply to check if $requestedName === $type (i.e. the requested service name is the same as the parameter type being used), but in practice this doesn't work because $requestedName is actually the resolved name:
https://github.com/zendframework/zend-servicemanager/blob/develop/src/ServiceManager.php#L209-L222
On L209 the alias is resolved, and on L222 doCreate is called with the $resolvedName so we never have the actual originally requested service name.
Therefore the only solution I could come up with for now was to check if the $container is a ServiceManager and reverse-engineer the service name to the original alias. Really not keen on this though, but I'm lacking on any better ideas. Feedback welcome here! :+1:
It's worth adding that in real terms, this is a user error, but I just wanted to catch this situation and provide some useful feedback (instead of something unclear Maximum function nesting level of '500' reached, aborting!), so if there's not a practical way to solve this problem, it simply may not be worth the effort.

@asgrim Is this still a WIP? I've scheduled for 3.4.0, but if it's not ready, I'll wait...

Given the hacky nature of this, I wouldn't merge it at all, to be honest...

This repository has been closed and moved to laminas/laminas-servicemanager; a new issue has been opened at https://github.com/laminas/laminas-servicemanager/issues/13.

This repository has been moved to laminas/laminas-servicemanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone laminas/laminas-servicemanager to another directory.
Copy the files from the second bullet point to the clone of laminas/laminas-servicemanager.
In your clone of laminas/laminas-servicemanager, commit the files, push to your fork, and open the new PR.
We will be providing tooling via laminas/laminas-migration soon to help  automate the process.


Jest crashes when requiring Marko templates

Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
Jest is using node 'require()' call to fetch Marko templates.
If the current behavior is a bug, please provide the steps to reproduce and either a repl.it demo through https://repl.it/languages/jest or a minimal repository on GitHub that we can yarn install and yarn test.
https://github.com/Caspinol/jest-marko-problem.git
What is the expected behavior?
The expected behaviour would be (i guess) for Jest to use Marko provided 'require()' call.
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
OS:     OSX
Jest:   v21.1.0
Node: v8.1.3
NPM:  v5.4.2

You'll need to build a custom transformer for Jest that deals with transforming your templates.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions. Thank you :)

Oki doki. Thanks for the pointer.

In case someone else gets lost in here:
const marko = require('marko/compiler');

module.exports = {
  process(src, filename) {
    return marko.compileFile(filename);
  }
};

And then in your package.json:
"jest": {
	    "transform": {
	        "^.+\\.marko$": "./jest-marko.js"
        }
    }

Note the you could (should, IMO) use marko.load instead of the require-hook, then you don't need the transformer

@SimenB how so?

Instead of
require("marko/node-require");
const hello = require("./template.marko");
hello.render({ name: "Frank" }, process.stdout);

do
const marko = require("marko");
const hello = marko.load(require.resolve("./template.marko"));
hello.render({ name: "Frank" }, process.stdout);

I am using load method but still cant test for routes which serve .marko


Accept glslang's new loop behavior

Relevant specification docs:

https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_miscellaneous_instructions
https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_debug_instructions

Addresses https://github.com/KhronosGroup/SPIRV-Cross/issues/2079

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I will double-check that my employer doesn't have any restrictions with me signing the CLA. Apologies for the delay, I will sign it ASAP.

/cc @HansKristian-Work just in case you missed this 😄

Yes, I have set aside some time tomorrow to merge this and look at the other PR.