EULA fails to validate

Describe the bug
I was hoping to try the engine download, yet I keep being faced with EULA Accepted? Please sign the EULA to continue. However, I have already accepted the EULA. After digging around I found out that the EULA fails to load immediately when I open the app.
I'm using Flatpak on Pop_OS! 22.04.
To Reproduce
Steps to reproduce the behavior:

Open the App using the terminal (flatpak run io.github.achetagames.epic_asset_manager), after configuration.
Look at terminal messages
Notice <epic_asset_manager::tools::epic_web> - [ERROR] - Failed to parse EULA json: error decoding response body: invalid type: null, expected struct HasAccountAccepted at line 1 column 743
Go to Engines > Install Engine.
See EULA Accepted? Please sign the EULA to continue message.

OR

Open the App using the terminal (flatpak run io.github.achetagames.epic_asset_manager), after configuration.
Go to Engines > Install Engine.
See EULA Accepted? Please sign the EULA to continue message.
Click Revalidate
"Nothing" happens
Look at terminal messages
Notice <epic_asset_manager::tools::epic_web> - [ERROR] - Failed to parse EULA json: error decoding response body: invalid type: null, expected struct HasAccountAccepted at line 1 column 743

Expected behavior

Open the App after configuration.
Go to Engines > Install Engine.
See EULA Accepted message.
Install UE5

Screenshots

Desktop (please complete the following information):

OS: Pop_OS! 22.04
Browser: Firefox 103

Additional context
I believe the issue is that the graph call is returning null instead of returning the expected values. My guess is that there were changes in the graph callback API or because my account is "old" it makes use of outdated calls.
The terminal logs are the following:
$ flatpak run io.github.achetagames.epic_asset_manager
<epic_asset_manager> - [DEBUG] - /app/share/epic_asset_manager
<epic_asset_manager> - [DEBUG] -
<epic_asset_manager> - [DEBUG] - 3.6.1
<epic_asset_manager::application> - [INFO] - Epic Asset Manager (io.github.achetagames.epic_asset_manager)
<epic_asset_manager::application> - [INFO] - Version: 3.6.1 ()
<epic_asset_manager::application> - [INFO] - Datadir: /app/share/epic_asset_manager
<epic_asset_manager::application::imp> - [DEBUG] - GtkApplication<EpicAssetManager>::startup
<epic_asset_manager::tools::epic_web> - [ERROR] - Failed to parse EULA json: error decoding response body: invalid type: null, expected struct HasAccountAccepted at line 1 column 743

The code seems to end up here:
https://github.com/AchetaGames/Epic-Asset-Manager/blob/470217d80c799d3e5da19b1d4e63a9867c18783b/src/tools/epic_web.rs#L144

The feature is highly experimental, what happens in your case is that you are getting an unexpected result from the Epic API.
Can you please test the following?

In the Library bottom left, click the marketplace button, does it open OK and are you authenticated?
The actual request to authenticate EULA is not a simple one to reproduce(as it requires cookies to be set and particular data to be sent.
I will try adding a bit more output to the failed parsing just so we can see what you actually got.

In the mean time you can download the zip manually from here: https://www.unrealengine.com/en-US/linux it goes through the same EULA validation so it would be curious if you got different results there.
I would like to keep you for testing though as catching the edge cases is important.

If you could install the flatpak from here(download at the bottom of the page) https://github.com/AchetaGames/Epic-Asset-Manager/actions/runs/2755938964 it should provide more output.

Hi! I'm having the same problem. I'd like to help but I could not figure how to install the flatpak you pointed at.
Do I need to add another new remote?

Hi! I'm having the same problem. I'd like to help but I could not figure how to install the flatpak you pointed at. Do I need to add another new remote?

No you just do flatpak install <file> on the file contained within the zip that you can download on the link (I can release the extended output as a patch but did not get to it yet)

Doh! Did not unzip it. .🤦♂
Anyway, here is the log... Which is the exact same output as @RicardoEPRodrigues
❯ flatpak run io.github.achetagames.epic_asset_manager.Devel
<epic_asset_manager> - [DEBUG] - /app/share/epic_asset_manager
<epic_asset_manager> - [DEBUG] - Devel
<epic_asset_manager> - [DEBUG] - 3.6.1-c8c8194
<epic_asset_manager::application> - [INFO] - Epic Asset Manager (io.github.achetagames.epic_asset_manager.Devel)
<epic_asset_manager::application> - [INFO] - Version: 3.6.1-c8c8194 (Devel)
<epic_asset_manager::application> - [INFO] - Datadir: /app/share/epic_asset_manager
<epic_asset_manager::application::imp> - [DEBUG] - GtkApplication<EpicAssetManager>::startup
<epic_asset_manager::tools::epic_web> - [ERROR] - Failed to parse EULA json: invalid type: null, expected struct HasAccountAccepted at line 1 column 743

That is what I get for disabling debug output on final build(I know it says DEBUG right above, but that is before the configuration is read:D). Can you please enable Debug output in settings and try again? (There is a button that rechecks EULA on the download page)

<epic_asset_manager::tools::epic_web> - [ERROR] - Failed to parse EULA json: invalid type: null, expected struct HasAccountAccepted at line 1 column 743
<epic_asset_manager::tools::epic_web> - [DEBUG] - Response: {"errors":[{"message":"EulaQuery/hasAccountAccepted: Request failed with status code 403","locations":[{"line":1,"column":20}],"correlationId":"","serviceResponse":"{\"errorCode\":\"errors.com.epicgames.common.missing_permission\",\"errorMessage\":\"Sorry your login does not posses the permissions 'eulatracking:public:displayagreement:8645b4947bbc4c0092a8b7236df169d1 READ' needed to perform the requested operation\",\"messageVars\":[\"eulatracking:public:displayagreement:8645b4947bbc4c0092a8b7236df169d1\",\"READ\"],\"numericErrorCode\":1023,\"originatingService\":\"com.epicgames.eulatracking.public\",\"intent\":\"prod\",\"errorStatus\":403}","stack":null,"path":["Eula","hasAccountAccepted"]}],"data":{"Eula":{"hasAccountAccepted":null}},"extensions":{}}

Seems like I get a 403 error because of a missing permission

Oh that is interesting, I will take a look into other ways of verifying the EULA is signed... Honestly it is not a technical requirement for me to check but a legal one so I might bypass it for now just to have this working and try to figure out the best way to query this.

Maybe it's just missing when you request the token when you first login

Ok so yeah, you're not requesting any permissions on the token generation:
https://www.epicgames.com/id/login?redirectUrl=https%3A%2F%2Fwww.epicgames.com%2Fid%2Fapi%2Fredirect
I suppose the protocol isn't documented anywhere...

No, the process is the same for everybody and on my side the query works just fine.
Would you be able to go to https://www.unrealengine.com/en-US/linux with Developer tools Network tab it performs two queries to graphql, one of those is the EULA query, does that succeed for you?
And no this is not documented anywhere, kind of reverse engineering this from how their web does it.

Plus if you can post the data sent and data received...

Ok this is on me :D.. will have a fix in a minute...

:smile:
I've got the queries and the response if you still need them, but it seems you figured it out!

Well it just hit me that 8645b4947bbc4c0092a8b7236df169d1 is not your account ID but mine ... would explain why it works for me... :D

Would anyone be able to validate the fix?

Pushing through flathub, or it is available here. If you installed from github actions before you might need to reinstall from flathub. (it is a different app ID so you probably have both at the same time)

Feel free to comment here once the update reaches you... would like a confirmation this works.

Confirmed working in 3.6.2. Thank you for your work @aknarts !

Thanks for the feedback @geowarin . Considering this was my fault do not even mention it:).
That being said that particular post request that I messed up has been haunting me since I first saw it so I might look into it again in the future.

Sorry for my absence. I tried the new build and can confirm that it is working! Great work!

I have version 3.8.4 from FlatHub, but I have a similar issue. (says EULA not accepted, despite having accepted the EULA)
How do I view the log?


Update messaging.md

Added text for optimistic bridges (explanation + security considerations) and hybrid approaches.

In the interest of progress and considering the type of feedback on this PR, I suggest we merge this PR and address any feedback-related changes in separate PRs. I am currently making a few updates to this file as part of issue #7. It would be good to have the changes in this PR integrated as I make those updates to avoid merge conflicts down the line.

Agreed. That will be a good path forward


SAMZA-1336. Session disconnect propagation.

If ZK doesn't receive any communication from a zkClient (including heartbeats), it closes the session with the client. It removes all the ephemeral nodes associated with the client. That's why we need to restore all these nodes - need to re-register.
We are using ZkClient library to connect to zookeeper. This library allows us to get notification when the session is closed and when a new session is created. So when the new session is created we reset all session related state and re-register.
One weird feature of the library/zookeeper is that when a new session is established, it is still possible to receive old notifications. To avoid this we introduced generation number which we pass into each callback. And if the generation number has changed when the callback was invoked, we will ignore this callback.

@prateekm @navina, could you please review?

@shanthoosh @navina  please review.

@navina @shanthoosh @cpettitt-linkedin
I've addressed all of the comments - please review/shipit.


i need version without take screenshot

can you provide me version without taken a screenshot ?

can you provide me version without taken a screenshot ?

Why do you need it? and whats the point in making it. If you don't want screenshot just don't look at it


Bug with parser?

Split from https://github.com/umputun/spot/discussions/135
With latest spot 1.9.2 there is something wrong with generated shell script:
      - name: shell
        script: |-
          f() { export S=passed; }
          f
          # one more line

spot --task=bash  -p test.yml -t s2 --dry converts it to:

But if I use longer names for function it works as expected:
      - name: shell
        script: |-
          f123() { export S=passed; }
          f123
          # one more line

this way is also works:
      - name: shell
        script: |-
          f() { export S=passed; }
          f # make string longer

but removing bash comment inside string field (not yaml itself) is very unexpected behavior. Does spot use some standard lib for yaml processing or some custom lib?

The comment's removal is intentional; I'm just wondering what is unexpected here. The idea behind this - minimizing the size of the transferred file. I can reconsider if you can articulate why having comments in the "executable" script is a good idea.
Single-char string was removed as a part of script creation too. I don't remember the exact reason, but I never expected a valid use of such a short command.

Does spot use some standard lib for yaml processing or some custom lib?

This is not related to yaml parsing, but rather a part of script preparation

Is comments removal documented? If it's not - it's unexpected behavior.
Is provided example of script valid sh script? If yes - it's a valid use even with short command.
Can you be sure removing comments or any editing of script is absolutely safe and doesn't not break the code? I'm worry about edge cases with something like sed 's###' with spaces inside for example. https://github.com/umputun/spot/blob/b3891e4720d793e2db93071f5acc5f48f857176a/pkg/config/command.go#L205 looks danger here.
Some lexer is needed to parse code and to strip comments from lines like  sed 's###' correctly. But sh,ksh,bash,zsh - too many syntaxes, it's large complex work. And it can also be perl (via shebang line in multiline yaml), for example, not bash, or any other language where # is not mark of the comment.
Having minimization as documented(!) option(!) is good and may be desired by default, but skipping empty strings (consisting of only \r and \n symbols) is better way for it I think. And even this way is danger because there can be things like cat to file with heredoc and similar things.
Also, saving few symbols does not make sense if it's too small and the same amount of tcp packets will be sent.

ok, convinced. removing all the processing affecting the source script, see #146

https://github.com/umputun/spot/blob/e2727d6853f67026ad99a3c6d08493f919c64273/pkg/config/command.go#L191
This line is potentially danger too. I suppose there should be check it is first line AND starts from #!, not only starts from #!.

#148 should do it


can't find java_home when build the libmeidapip_jni.so

System information (Please provide as much relevant information as possible)

OS Platform and Distribution (e.g. Linux Ubuntu 16.04, Android 11, iOS 14.4):
#62~20.04.1-Ubuntu SMP Tue Nov 22 21:24:20 UTC 2022
Compiler version (e.g. gcc/g++ 8 /Apple clang version 12.0.0):
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Programming Language and version ( e.g. C++ 14, Python 3.6, Java ):
Java
MediaPipe version:
https://github.com/google/mediapipe/tree/v0.8.11
Bazel version:
bazel 5.2.0
Android SDK and NDK versions (if android):
SDK 30.0.3 NDK 21

I want to build the libmediapipe_jni.so
bazel build -c opt --config=android_arm64 mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu:libmediapipe_jni.so
but it fail.
DEBUG: Rule 'rules_foreign_cc' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "c2cdcf55ffaf49366725639e45dedd449b8c3fe22b54e31625eb80ce3a240f1e"
DEBUG: Repository rules_foreign_cc instantiated at:
/DATA/share/chen_guoting/mediapipe-0.8.11/WORKSPACE:49:13: in
Repository rule http_archive defined at:
/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/build_defs/repo/http.bzl:353:31: in
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/131dda9acc6978aba4740d75ca45f411fbabd726.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from http://mirror.tensorflow.org/github.com/bazelbuild/rules_closure/archive/cf1e44edb908e9616030cc83d085989b8e6cd6df.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/tensorflow/runtime/archive/8700849191dea2ca9c12a3d26ec41fac0814671b.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_absl' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_benchmark' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'flatbuffers' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11_bazel' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_googlesource_code_re2' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_protobuf' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_google_googletest' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'com_github_gflags_gflags' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'zlib' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_rules_apple' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_rules_swift' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'build_bazel_apple_support' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'xctestrunner' because it already exists.
DEBUG: /DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/org_tensorflow/third_party/repo.bzl:132:14:
Warning: skipping import of repository 'pybind11' because it already exists.
INFO: Build options --copt, --cpu, --crosstool_top, and 5 more have changed, discarding analysis cache.
INFO: Repository local_jdk instantiated at:
/DEFAULT.WORKSPACE.SUFFIX:27:6: in
/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/build_defs/repo/utils.bzl:233:18: in maybe
/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/jdk/local_java_repository.bzl:231:32: in local_java_repository
Repository rule _local_java_repository_rule defined at:
/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/jdk/local_java_repository.bzl:202:46: in
ERROR: An error occurred during the fetch of repository 'local_jdk':
Traceback (most recent call last):
File "/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/jdk/local_java_repository.bzl", line 127, column 32, in _local_java_repository_impl
"does not exist." % (java_home, str(java_home_path)))
Error: not all arguments converted during string formatting
ERROR: /DEFAULT.WORKSPACE.SUFFIX:27:6: fetching _local_java_repository_rule rule //external:local_jdk: Traceback (most recent call last):
File "/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/jdk/local_java_repository.bzl", line 127, column 32, in _local_java_repository_impl
"does not exist." % (java_home, str(java_home_path)))
Error: not all arguments converted during string formatting
INFO: Repository rules_java instantiated at:
/DEFAULT.WORKSPACE.SUFFIX:429:6: in
/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/build_defs/repo/utils.bzl:233:18: in maybe
Repository rule http_archive defined at:
/DATA/share/chen_guoting/.cache/bazel/_bazel_chen_guoting/d896184a08a2df64667676d0a6a83c7f/external/bazel_tools/tools/build_defs/repo/http.bzl:353:31: in
ERROR: Analysis of target '//mediapipe/examples/android/src/java/com/google/mediapipe/apps/facemeshgpu:libmediapipe_jni.so' failed; build aborted: not all arguments converted during string formatting
INFO: Elapsed time: 0.106s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 11 targets configured)
currently loading: @bazel_tools//tools/python ... (6 packages)
Fetching @commands_overloads; Restarting.
Fetching @local_execution_config_python; fetching

I have set java_ home,sdk,ndk in the environment @wh173d3v11

Hello @chenguoting
Would you please let us know why are you building libmediapipe_jni.so file? Is there any specific use case in your application that you would want to be catered?

My colleague solved the problem by adding this parameter --java_runtime_version=remotejdk_11


No OPTIONS Header support

Most API frameworks automatically dispatch an OPTIONS header. This one doesn't so whenever you use any kind of AJAX, it just returns 204 No Content and does not dispatch the OPTIONS header with "Access-Control-Request-Method: POST"

I believe @lwcolton's falcon-cors provides this functionality.
When a resource does not implement an on_options() method, Falcon uses a default OPTIONS responder that sets the Allow header. But the default responder does not detect a CORS preflight request, and so it will not respond with Access-Control-* headers.

@Woolworths have you had a chance to look at falcon-cors to see if it does what you need?

@kgriffs I don't know what I was going on about.. The options header works fine :)

OK, no worries.


FR: Right click Youtube  url support

Hi
It would be nice if this addon can be access over right click menu when clicked on a video link like Youtube links so that one can easily pass those urls to PyLoad.
thanks

Hi @gerroon, thank you for the suggestion I will work on it !

Hi @gerroon, I just pushed an update that adds context menu downloads, let me know if it meets your expectations !


[wip] fix(122): Improve deep cloning of NotificationResponse.

Resolves #122.

Will test this after lunch


3.x Change p4d integration tests for MCM pre-flight

Description of changes

Separated p4d multinics test into its own test so that it can be run by itself
Hard-coded capacity reservation has been added to make multiple-nics integ tests use ODCR when running on pd4 instances.

DO NOT MERGE THIS INTO ANY RELEASE OR DEVELOP BRANCH
Checklist

[x] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[x] Check all commits' messages are clear, describing what and why vs how.
[x] Make sure to have added unit tests or integration tests to cover the new/modified code.
[x] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can we move separating p4d tests related changes to the develop branch?

https://github.com/aws/aws-parallelcluster/pull/4654

Can we rename p4d.yaml to p4d-efa.yaml?

Done.


Failed to load resource: the server responded with a status of 404(Not Found) error

i am getting 404 error and my browser not even looking into my app folder.  any solutions?

Do you have any import for angular2/core? It should be @angular/core instead.

thank you @filipesilva 👍


Porting to Cython

Is it possible for you to port this into Cython and release it as PyPI package ?
It would be easy for existing DL users(tf and pytorch users) to use it natively in their code.

Thanks for your suggestion. Let us make this the priority! We'll @ you when it is done.

Thank you @keroro824 !

Sort of related, but I've been building R bindings.

@wrathematics Thanks for contributing 👍

Hi, are there any updates on this?

Is it possible for you to port this into Cython and release it as PyPI package ? It would be easy for existing DL users(tf and pytorch users) to use it natively in their code.

I'm also interested in implementing such a thing. But it seems to me the way to do this would be to implement custom layers instead of builtin ones. This could be added to the main codebase once it is tested rather than a separate package.
For example in pytorch you would first subclass 'torch.autograd.Function' to implement forward and backward operations which calculate the hashing operations and take that into account in forward and back propagation. Cython might not be needed as you might be able to use numba and get better performance more easily.
@keroro824 I've actually started doing what I described. I have a question:
Do you have some justification for only propagating the gradient to active neurons? It's not obvious to me why this would be a good approximation of the true gradient.
There is another method the math would suggest: the gradient w.r.t the input of a linear layer is (repeated indices indicate a sum):
y_i = W_{ij} * x_{j} + b_i
dx_k = dy_i * W_{ik}
So we can use LSH for calculating the backprop but we need more hash tables than the paper suggests. The multiplications in the backprop are by columns of the weight matrix, and the forward prop is multiplication by rows of the weight matrix. Did you try something like this?
It would be very interesting to me to implement this.


Update sqlmesh_macros.md

Updated python macro example with a slight caveat when passing strings with spaces to the macro.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing this PR has it has already been addressed and merged here https://github.com/TobikoData/sqlmesh/pull/2946


Fixing PostgreSQL support

This branch is activating the build for PostgreSQL, which is currently failing. @carltongibson will create some Pull Requests targeted at this branch to fix this.
tasks:

[ ] test coverage
[ ] gather feedback for my changes
[ ] submit changes to the documentation

informations:

q
a

Fixed tickets
none

BC breaks
hopefully none

Documentation PR
none

Update:
Of the originally failing bundles, we're about half way there. #1720, #1725, #1726 fixes Categories, Contacts and Tags respectively. (@danrot: please review at your leisure.)
I have to pause until next week now but I will continue with MediaBundle. The queries here are more complex but, it is exhibiting the same semi-random failures as I found in #1725.
Here's one run:
.............F.....F..................................F.F......  63 / 108 ( 58%)
.............................................

And here's another one straight after:
.................................................F..FF.F.F.....  63 / 108 ( 58%)
.............................................

Same tests. Different failures. :-) Again it'll just be a case of providing Postgres with the correct ordering. (There is an $orderBy parameter being passed around so I need to see exactly what's happening to that but I'm assuming it'll be a single change in the end.)
Having got this far without incident I'm optimistic that ResourcesBundle and SecurityBundle will prove relatively easy to resolve as well. (I haven't yet looked)

@carltongibson The progress already looks quite good, there aren't too many failing tests left. However, it would be good if we don't wait too long on finishing this, I've already seen a new feature failing some tests again :confused:

@danrot Yeah — I didn't think I was far off. IIRC there were remaining ordering issues — with intermittent failures and that was about it.
(I thought ordering the relations may be all that's needed there — but didn't get to check that.)
Will say more in Feb! Ping me on anything relevant so I can keep up.

Replaced by #2703


7638: C# 5 compatibility for Orchard.Glimpse

Adding LangVersion 5 to Orchard.Glimpse.csproj and removing C# 6 code from the Glimpse module, fixes #7638

Someone who worked on this module should review it.

1.11 will ship with C# 7.3 compatibility, so this downgrade is not needed anymore.


[Bug][DevServer]: TypeError: Cannot read properties of undefined (reading 'get') when making network request to compiled asset

System Info
System:
OS: macOS 14.4.1
CPU: (8) arm64 Apple M2
Memory: 70.70 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
Yarn: 1.22.22 - ~/.nvm/versions/node/v20.11.1/bin/yarn
npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
pnpm: 8.15.6 - ~/.nvm/versions/node/v20.11.1/bin/pnpm
bun: 1.1.12 - ~/.bun/bin/bun
npmPackages:
@rspack/cli: 1.0.0-beta.5 => 1.0.0-beta.5
@rspack/core: 1.0.0-beta.5 => 1.0.0-beta.5
Details
After starting the dev server, it crashes as soon as the browser requests one of its compiled assets.
The crash produces the following error (path truncated for brevity):
[...]/node_modules/.pnpm/webpack-dev-middleware@7.4.0_webpack@5.93.0/node_modules/webpack-dev-middleware/dist/utils/getFilenameFromUrl.js:120
        const assetInfo = assetsInfo.get(pathname.slice(publicPathObject.pathname.length));
                                     ^

TypeError: Cannot read properties of undefined (reading 'get')
    at getFilenameFromUrl ([...]/node_modules/.pnpm/webpack-dev-middleware@7.4.0_webpack@5.93.0/node_modules/webpack-dev-middleware/dist/utils/getFilenameFromUrl.js:120:38)
    at processRequest ([...]/node_modules/.pnpm/webpack-dev-middleware@7.4.0_webpack@5.93.0/node_modules/webpack-dev-middleware/dist/middleware.js:393:24)
    at ready ([...]/node_modules/.pnpm/webpack-dev-middleware@7.4.0_webpack@5.93.0/node_modules/webpack-dev-middleware/dist/utils/ready.js:16:5)
    at middleware ([...]/node_modules/.pnpm/webpack-dev-middleware@7.4.0_webpack@5.93.0/node_modules/webpack-dev-middleware/dist/middleware.js:666:5)
    at Layer.handle [as handle_request] ([...]/node_modules/.pnpm/express@4.19.2/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix ([...]/node_modules/.pnpm/express@4.19.2/node_modules/express/lib/router/index.js:328:13)
    at [...]/node_modules/.pnpm/express@4.19.2/node_modules/express/lib/router/index.js:286:9
    at Function.process_params ([...]/node_modules/.pnpm/express@4.19.2/node_modules/express/lib/router/index.js:346:12)
    at next ([...]/node_modules/.pnpm/express@4.19.2/node_modules/express/lib/router/index.js:280:10)
    at compression ([...]/node_modules/.pnpm/compression@1.7.4/node_modules/compression/index.js:220:5)

Reproduce link
https://github.com/mxmason/rspack-repro-dev-crash
Reproduce Steps

run pnpm i
run pnpm run dev:rspack
verify that the server has not crashed yet
navigate to http://localhost:8080
verify that the index.html file is returned, but there's no "hello world" from the main bundle
verify that the dev server has crashed
run pnpm run dev:webpack and verify that "hello world" does render

[!NOTE]
DevServer crashes as soon as the browser requests main.js. If you comment out the plugins array in config.mjs, the server will only crash if you go to http://localhost:8080/main.js.

Closed as fixed by upstream: https://github.com/webpack/webpack-dev-middleware/pull/1927

Thanks, @h-a-n-a. It looks like<EMAIL_ADDRESS>has this fix, but the latest release of rspack doesn't use 7.4.2. Can you say when rspack will upgrade its dependencies?


Interaction between Month Calendar and List Calendar

I have noticed that when I click on some day like 18th of Dec 2016 on the month calendar the list calendar shows me the week starting from 19 Dec and the 18th get hidden on top. So the month calendar and the list calendar should be synchronized perfectly. How can I do that ?

Hi, I'll take a look and fix it asap.

Sorry, I can't reproduce this issue. Can you send me your piece of code when you interact between calendars?

monthCalendar.setOnDayChangeListener(new OnDayChangeListener() {
@Override
public void onDayChanged(Calendar calendar) {
            listCalendar.setSelectedDay(DateUtils.setTimeToMidnight((Calendar) calendar.clone()), false);
        }
    });
    monthCalendar.setOnMonthChangeListener(new OnMonthChangeListener() {
        @Override
        public void onMonthChanged(Calendar calendar) {

            listCalendar.setSelectedDay(DateUtils.setTimeToMonthStart((Calendar) calendar.clone()), false);            }
    });

The code is same as your sample app.

The problem in in scroll position of the recyclerview please find below the attached example.

So I have clicked on 12th of April but the starting day in listCalendar is 16th of April which is wrong. The scroll position should be one step up.

Thanks. I got it. :)

Fixed in 0.2.0.


[C#] Godot 4 .NET 6 takes far too long to free custom node extended classes.

Godot version
3.5, 4.0.beta4
System information
Windows 10, 64bit
Issue description
I created four test projects:

GD Script, Godot 3.5
GD Script, Godot 4 Beta 4
Mono, Godot 3.5
.NET 6, Godot 4 Beta 4

In this minimalist projects, 3000 nodes are added to a node as a child and then removed again.
However, C# under Godot 4 takes a devastatingly long time.
Example output:
# Adding and removing 3000 nodes

# Godot 3.5 Mono

elapsed time (Dummy): 0.782 sec
elapsed time (Node): 0.075 sec

# Godot 4 Beta 4

elapsed time (Dummy): 4.674 sec
elapsed time (Node): 0.079 sec

# Godot 3.5 GD-Script

elapsed time (Dummy): 0.103
elapsed time (Node): 0.068

# Godot 4 Beta 4 GD-Script

elapsed time (Dummy): 0.094
elapsed time (Node): 0.067

In another test project, I have about 2300 nodes that do a little more in the background, such as cutting out random parts from the standard icon and arranging them one after the other in a container node.
Here Godot 4 .Net 6 needs about 14 seconds whereas 3.5 Mono only needs about 4 seconds.
Steps to reproduce
C# example code as used in the 4 sample projects:
// public partial class Dummy : Node { }
// _nodeContainer = GetNodeOrNull<Node>("NodeContainer");

//
// Adding a custom class extended from Godot.Node
//

var millisStartDummy = Time.GetTicksMsec();

for (int i = 0; i < 3000; i++)
{
	var node = new Dummy();
	_nodeContainer.AddChild(node);
}

foreach (Node node in _nodeContainer.GetChildren())
{
	if (node.GetParent() != null)
	{
		node.GetParent().RemoveChild(node);
		node.Free();
	}
}

ulong millisEndDummy = Time.GetTicksMsec();
float millisDummy = millisEndDummy - millisStartDummy;

//
// Add Native Godot.Node nodes
//

var millisStartNode = Time.GetTicksMsec();

for (int i = 0; i < 3000; i++)
{
	var node = new Node();
	_nodeContainer.AddChild(node);
}

foreach (Node node in _nodeContainer.GetChildren())
{
	if (node.GetParent() != null)
	{
		node.GetParent().RemoveChild(node);
		node.Free();
	}
}

ulong millisEndNode = Time.GetTicksMsec();
float millisNode = millisEndNode - millisStartNode;

var text = new string[] {
	"elapsed time (Dummy):", (millisDummy / 1000).ToString("#,##0.000 sec."),
	"\nelapsed time (Node):", (millisNode / 1000).ToString("#,##0.000 sec.")
};

GD.PrintS(text);

Minimal reproduction project
BenchNodeRemoveAdd_GD_Godot3.5.zip
BenchNodeRemoveAdd_GD_Godot4b4.zip
BenchNodeRemoveAdd_Godot3.5.zip
BenchNodeRemoveAdd_Godot4b4.zip

This seems to be related to adding as child nodes.
I changed to the following code for testing.
    private List<Node> _nodeContainer;
    public void OnStart()
    {
        Stopwatch sw = Stopwatch.StartNew();
        sw.Start();
        for (int i = 0; i < ITERATIONS; i++)
        {
            var node = new Dummy();
            _nodeContainer.Add(node);
        }
        sw.Stop();
        Console.WriteLine("create extend nodes cost time:" + sw.ElapsedMilliseconds + "ms");
        sw.Restart();
        foreach (Dummy node in _nodeContainer)
        {
            node.Free();
        }
        sw.Stop();
        Console.WriteLine("delete extend nodes cost time:" + sw.ElapsedMilliseconds + "ms");

        _nodeContainer.Clear();
        sw.Restart();
        for (int i = 0; i < ITERATIONS; i++)
        {
            var node = new Node();
            _nodeContainer.Add(node);
        }
        sw.Stop();
        Console.WriteLine("create nodes cost time:" + sw.ElapsedMilliseconds + "ms");
        sw.Restart();
        foreach (Node node in _nodeContainer)
        {
            node.Free();
        }
        sw.Stop();
        Console.WriteLine("delete nodes cost time:" + sw.ElapsedMilliseconds + "ms");
    }

Here are the results
create extend nodes cost time:9ms
delete extend nodes cost time:11ms
create nodes cost time:5ms
delete nodes cost time:4ms

One possibility is also to remove the parent node and create it afterwards. It also doesn't slow down the next frame. This variant is the fastest in my tests at only 3 ms.
// ...
sw.Start();
_nodeContainer.QueueFree();
_nodeContainer = new Node();
GetTree().Root.AddChild(_nodeContainer);
sw.Stop();

Result:
delete extend nodes cost time: 0.003 sec.

However, 3.5.x was faster when removing nodes in a loop. Maybe there is a possibility that the performance can be improved a bit here. Since GD-Script is faster than anything else here.

I'll look into this when I get some time.

I checked it out in a profiler, and the issue seems to be that InvokeGodotClassMethod is doing a lot of string comparisons.

InvokeGodotClassMethod doesn't do string comparisons. It compares string names, which is a pointer comparison.

#67750 has been merged, can you test again to see if the slowdown is still present ?

#67750 has been merged, can you test again to see if the slowdown is still present ?

Nope, C# still doesn't use GDExtension (it's coming this month), and it already uses StringName internally.

Can you still reproduce this in 4.0.3 and 4.1-beta3 or later?

In 4.1-beta3, the benchmark projects still show a significant difference (C# is about 3x slower), but this is a massive improvement from the originally reported ~50x difference.

It's much better now and appears to have been fixed. I didn't compare it with GD Script or version 3.5, just the  4.x C# versions.
With the same C# code with 3000 nodes that are added and then removed in a loop, I get the following output:
Version 4.0 Beta 3
===================

create extend nodes, cost time: 0.068 sec.
delete extend nodes, cost time: 4.637 sec.
create nodes cost time: 0.013 sec.
delete nodes cost time: 0.068 sec.

Version 4.0.0
===================

create extend nodes, cost time: 0.047 sec.
delete extend nodes, cost time: 4.691 sec.
create nodes cost time: 0.014 sec.
delete nodes cost time: 0.070 sec.

Version 4.1 Beta 3
===================

create extend nodes, cost time: 0.049 sec.
delete extend nodes, cost time: 0.043 sec.
create nodes cost time: 0.013 sec.
delete nodes cost time: 0.015 sec.

Thanks, closing as fixed then.


More representative logo

Hey, thanks a lot for the library, looks great!
But the logo looks like additive light blending? I think it would represent the library better if it looked like pigment mixing.

Hi wrightwriter! I have to admit the logo is made with an AI image generator. I wanted something with nice spectral like colors. I’m a programmer and not a graphic designer.
Feel free to make a new logo that suits your needs and I will use that as the logo if I like it better.
Thanks for reaching out!

Finally had the time to create a better logo, I think this one is a lot better.

Looks cool! Thanks


Add additional instructions to AVD manager

Android Studio recently made changes in accessing the AVD manager - users need to have a project open for the AVD manager to appear.

Perhaps you can merge this with your other related PR?


Toongod.com not working

Steps to reproduce

instal the latest version
install extension
still not working

Expected behavior
Showed the list of manga
Actual behavior
manga list not showed

Crash logs
No response
Tachiyomi version
1.8.4
Android version
Android 10
Device
Xperia xz3
Other details
the same problem accour in Tachiyomi
Acknowledgements

[X] This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.8.4.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

the same problem accour in Tachiyomi
This should have been opened here https://github.com/tachiyomiorg/tachiyomi-extensions


Problem with wifi connection in Firebase Database on Android

Firebase Database has a known unresolved issue with Wifi connection failures with Android SDK . The problem does not occur with Web version and IOS. What are the chances of this problem occurring or not with FlutterFire on Android?
https://github.com/firebase/firebase-android-sdk/issues/1258

If there's an issue on the Android SDK the there'll be an issue on FlutterFire for Android - we use the Firebase Android SDK in the plugins.
I'd recommend tracking that issue there and/or raising an issue with Firebase Support if needed.


Add konveyor tier3 nightly job results badge to the README.md

Add konveyor tier3 nightly job result badge to README.md

@aufi @fabianvf Hello , can you please review merge this PR. Thank You !


调用google 新api 程序卡死不动

调用google 新api 程序卡死不动

Hi,
Sorry I can only answer in English. Could you please provide more details about your question or issue?
Thanks,
Josh, Google Ads API Team

Hi,
I'm closing this out because I haven't heard back in a few months. Please reopen and provide more details if you're still encountering issues.
Thanks,
Josh, Google Ads API Team


fix(arrayvalidator): fixed runaway type instantiation with TypeScript >=5.1

Related: https://github.com/microsoft/TypeScript/issues/54491

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (06ac013) 99.28% compared to head (2417255) 99.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   99.28%   99.28%
=======================================
  Files          58       58
  Lines        3477     3485    +8
  Branches      713      713
=======================================
+ Hits         3452     3460    +8
  Misses         17       17
  Partials        8        8

Flag
Coverage Δ

16
99.28% <100.00%> (+<0.01%)
:arrow_up:

18
99.28% <100.00%> (+<0.01%)
:arrow_up:

19
99.28% <100.00%> (+<0.01%)
:arrow_up:

20
99.28% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/lib/util-types.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@sapphiredev pack

this fix can probably be reverted now that typescript 5.1.5 was released

https://github.com/microsoft/TypeScript/issues/54491

this fix can probably be reverted now that typescript 5.1.5 was released

Fair point but because it's still an issue in older versions of TypeScript and we cannot be guaranteed that everyone uses caret versioning, or that their transitive dependencies are properly updated, we will keep the fix for now.

alright but 5.1.3 is the only stable typescript version that had the problem, there are no other versions with the issue, updating to a new patch release shouldn't be that much of an problem? specially to fix a regression

Why does this pr need to revert tho? are there any issues with the current approach?

Unless there are any glaring issues caused by this PR, we won't be reverting it any time soon, as (as far as we know) there are no issues with keeping it. Should that change, you're free to open an issue / revert


[relates #713] Move tests that depend on betamax to extras

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/499/
Test PASSed.


Update ioredis to latest v3.0.0-1

<EMAIL_ADDRESS>released.

@lpfeup would you mind to send a PR?

Done. PR #27

Released


[AUTOPATCHER-CORE] Upgrade ivykis to 0.43 Azure Linux 3.0 Upgrades

[AUTOPATCHER-CORE] Upgrade ivykis to 0.43 Azure Linux 3.0 Upgrades
Upgrade pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=512304&view=results
buddy build -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=512309&view=results

Version double checking in progress.


⚠ Bofrost.lu has degraded performance

In 0f67e37, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2281 ms

Resolved: Bofrost.lu performance has improved in 6fb646c after 12 minutes.


Support configurable reporter

We have both datadog and stdout but it's hard coded to use datadog.

The current CLI framework is not flexible enough to handle sub commands and positional args. We should move to https://github.com/jawher/mow.cli


A11y_Azure Data Studio_Toolbar_FindNode_Zoom: At resize, the combo box is not visible completely

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:
#A11yMAS; #A11yTCS; #A11ySev2; #SQL Azure Data Studio; #SH-SQL Azure Data Studio-Win32-OCT2022; #DesktopApp; #Zoom; #WCAG1.4.4; #FTP;
Environment Details:
Application Name: Azure Data Studio
Windows Version: Windows 11
Repro Steps:

Launch the "Azure data studio" application.
Connect with the provided "sqltools2019-3" SQL server.
TAB to "New Query" button and hit ENTER key.
Enter the SQL query and TAB to "Estimated Plan" button and hit ENTER key.
"Query Plan (Preview) screen appear.
TAB to the toolbar present at right side of the screen.
TAB to "Find Node" button and hit ENTER key.
Zoom the screen to 200% and observe the issue.

Actual:
At resize, the combo box is not visible completely.
This issue is also observed for the table in the "Properties" section in the below scenario
1)Toolbar - Properties

Launch the "Azure data studio" application.
Connect with the provided "sqltools2019-3" SQL server.
TAB to "New Query" button and hit ENTER key.
Enter the SQL query and TAB to "Estimated Plan" button and hit ENTER key.
"Query Plan (Preview) screen appear.
TAB to the toolbar present at right side of the screen.
TAB to "Properties" button and hit ENTER key.
Zoom the screen to 200% and observe the issue.

Expected Result:
At resize, the combo box should be visible completely.
Attachment:

@Truptik12, can you please retest and close this issue?

Verified the bug in the below environment
Version: 1.40.0-insider (user setup)
Commit: https://github.com/microsoft/azuredatastudio/commit/d5cf088ba7b794859438fd2c1902249fd1e6a947
Date: 2022-10-26T05:45:47.459Z
VS Code: 1.67.0
Electron: 17.4.5
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
The bug does not repro. Hence closing the bug. Please find the screenshot below.


fix: converge on naming for server(s)

Align on naming for server(s) - will need to update the spec and something else later after this lands
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

Note that after that, you'll have to also update the test suite with the new names. After changing the names, do remove your local target/ directory, so the old files don't keep confusing you with "why does the test suite on my system find the old names and the CI doesn't?"

@puiterwijk I believe I've done what you've asked - as for changing the Rust definition from \*Service\* to \*Server\* I'd rather follow up


Check active channel is CLOSED when reopening an ICA channel

We should check here that the channel is not closed instead, because it could be possible to reopen a channel that is going through an upgrade (in FLUSHING or FLUSH_COMPLETE state).

Thinking now if we should change this condition to channel.State != channeltypes.CLOSED... I am thinking of the following scenario: an ICA channel is going through a channel upgrade and the channel state is either FLUSHING or FLUSH_COMPLETE, and a relayer submits a MsgChannelOpenInit with the same metadata version as the channel going through the upgrade. With the current check the opening handshake would go through, right? I guess we should prevent that?
If we need to change this, we can do it in a follow up PR.

Originally posted by @crodriguezvega in https://github.com/cosmos/ibc-go/pull/5562#discussion_r1447835747

done in #5601


Process changes for wave 2

Context
With integration wave 2 on the horizon we need to evaluate what changes we want to make to our processes, in particular with the aim of making wrangling easier and faster.
Resources
brainstorm miro board
actions
Proposed wrangling changes
Tasks:

[ ] get approval for proposed wrangling changes
[ ] get scientists' opinion on need for well label in plate based techniques
[ ] prepare test data
[ ] get test data reviewed
[ ] open documentation ticket

preparing the test data
I need to email Peng and at least another lab

Peng's reply - it sounds like the well label is valuable information for quality control, so the change in wrangling for plate based technique won't go ahead

waiting for confirmation of tier 1 metadata to discuss wrangling changes

closing this because the work for wave 2 went in a different direction and this is no longer relevant


pass kwargs to ansible

Abstract
The keyword arguments in def run_module(self, host, module_name, module_args, become=False, check=True, **kwargs) in testinfra/utils/ansible_runner.py are currently unused. This pull request passes them on to ansible.
Benefit
Passing arbitrary arguments to ansible would among other things allow to pass extra variables to ansible. I've only used the values (not the keys) as it is more api stable and because the ansible command line tool uses short and long options.
Example
With this pull request we can use the ansible debug module to resolve any jnja2 template. This includes templates containing lookup plugins as the ansible lookup plugin. So we can include secrets (e.g. third-party passwords needed for system tests) in testinfra without exposing them in our molecule scenarios.
Motivation
I am currently working on a helper python module for testinfra and molecule. It provides a testvars fixture which itself uses the testinfra host fixture. The testvars fixture resolves and exposes variables provided by roles and testinfra.
It reads variables from yaml files into a python dictionary respecting the ansible variable precedence. It then updates the role vars with host.ansible.get_variables().
Now the testvars are converted to json file which is the result type of the ansible debug module and which is accepted as input format by ansible. In fact, json is the recommended input format of --extra-vars:

Use the JSON format if you need to pass in anything that shouldn’t be a string

It then uses the json testvars in two different ways.

It uses re.sub and an anonymous lambda function to search and replace jinja2 templates in the testvars:

regex_templates = r'{{.*?}}'
testvars_json = \
    re.sub(regex_templates,
    lambda match: _resolve_template_(match.group(0)),
    testvars_unresolved_json,
    flags=re.S)

# load json and unescape characters
testvars = json.loads(testvars_json)

It stores the testvars in a json file in an ephemeral directory provided by molecule. In _resolve_template_ this file is used as an input to the ansible debug module which then resolves the jinja2 templates:

kwargs = {'extravars': '--extra-vars=@' + testvars_dumpfilename}
template_resolved = str(host.ansible('debug', 'msg=' + template_unresolved, **kwargs)['msg'])

# escape resolved template
template_resolved = json.dumps(template_resolved).strip('"')

I forgot to mention that these calculations are so expensive that a live calculation basically spoils test-driven development. I found a solution that works for me™ by using the pytest cache plugin.
The plugin is disabled by molecule by default. It needs to be enabled explicitly in molecule.yml:
verifier:
  name: testinfra
  options:
    p: cacheprovider

Then the fixture can be implemented using the cache:
@pytest.fixture(scope='module')
def testvars(request, host):
    testvars = request.config.cache.get("my_project/testvars", None)
    if testvars is None:
        testvars = Testvars(host).testvars
        request.config.cache.set("my_project/testvars", testvars)
    return testvars

I've published an alpha version of my pytest/testinfra helper plugin testaid.

@RebelCodeBase
Is this PR required to use your testaid plugin ?
Now that you just added the handling of variable with VariableManager in testaid, is this PR still relevant or compatible ?

This PR is not needed for testaid any more as testaid does not use the testinfra host plugin any more. You can merge it if you think it's a good idea but it won't hinder testaid. Thanks for considering the PR!

Closing this in flavor of #526


⚠ LPDM Handbook (hosted on Divio) has degraded performance

In 8fb3c0d, LPDM Handbook (hosted on Divio) (https://repohubdev.tk) experienced degraded performance:

HTTP code: 500
Response time: 5357 ms

Resolved: LPDM Handbook (hosted on Divio) performance has improved in 74479df.


chore: remove hamcrest dependency and modify test case

Codecov Report

Merging #22 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
- Coverage     77.91%   77.79%   -0.13%
+ Complexity     1188     1187       -1
============================================
  Files            77       77
  Lines          6218     6188      -30
  Branches        691      667      -24
============================================
- Hits           4845     4814      -31
+ Misses         1022     1019       -3
- Partials        351      355       +4

Impacted Files
Coverage Δ
Complexity Δ

...google/cloud/bigquery/StandardTableDefinition.java
93.05% <100.00%> (-0.28%)
16.00 <0.00> (ø)

...com/google/cloud/bigquery/StandardSQLDataType.java
73.68% <0.00%> (-1.32%)
7.00% <0.00%> (ø%)

...m/google/cloud/bigquery/StandardSQLStructType.java
84.61% <0.00%> (-1.10%)
5.00% <0.00%> (ø%)

...gle/cloud/bigquery/MaterializedViewDefinition.java
70.00% <0.00%> (-0.97%)
6.00% <0.00%> (ø%)

...ava/com/google/cloud/bigquery/RoutineArgument.java
85.71% <0.00%> (-0.65%)
5.00% <0.00%> (ø%)

...ogle/cloud/bigquery/WriteChannelConfiguration.java
86.17% <0.00%> (-0.65%)
46.00% <0.00%> (ø%)

...om/google/cloud/bigquery/LoadJobConfiguration.java
87.02% <0.00%> (-0.53%)
52.00% <0.00%> (ø%)

...va/com/google/cloud/bigquery/StandardSQLField.java
90.47% <0.00%> (-0.44%)
7.00% <0.00%> (ø%)

...java/com/google/cloud/bigquery/ViewDefinition.java
87.09% <0.00%> (-0.41%)
11.00% <0.00%> (ø%)

...google/cloud/bigquery/ExternalTableDefinition.java
57.69% <0.00%> (-0.41%)
19.00% <0.00%> (ø%)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773edea...7934f5d. Read the comment docs.


Update discardCache in PerformanceClient

This PR moves the deletion of QueueMeasurement to discardCache() and adds the deletion of preQueueTimeByCorrelationId.

Codecov Report

Merging #5645 (efb0992) into dev (479c057) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Flag
Coverage Δ

msal-angular
96.50% <ø> (ø)

msal-browser
86.46% <ø> (ø)

msal-common
84.61% <100.00%> (+0.01%)
:arrow_up:

msal-core
?

msal-node
83.39% <ø> (ø)

msal-node-extensions
75.64% <ø> (ø)

msal-react
94.68% <ø> (ø)

node-token-validation
88.88% <ø> (ø)

Impacted Files
Coverage Δ

...mon/src/telemetry/performance/PerformanceClient.ts
79.51% <100.00%> (+0.30%)
:arrow_up:

lib/msal-core/src/Logger.ts

lib/msal-core/src/utils/WindowUtils.ts

lib/msal-core/src/telemetry/ApiEvent.ts

lib/msal-core/src/utils/RequestUtils.ts

lib/msal-core/src/AuthenticationParameters.ts

lib/msal-core/src/error/AuthError.ts

lib/msal-core/src/index.ts

lib/msal-core/src/telemetry/TelemetryUtils.ts

lib/msal-core/src/utils/Constants.ts

... and 36 more


Add RPC url to providers

Please wait for https://github.com/ERC725Alliance/erc725.js/pull/237 to be merged before merging

Also here:
https://github.com/lukso-network/docs/blob/main/docs/guides/universal-profile/read-profile-data.md?plain=1#L83

@skimaharvey I think we can close this?


Add blog folder

Adding the blog folders and some images.

There seems to be a problem with the image links and there are maybe a few images missing.
This: ![alt text](freezeyt/freezeyt_blog/images/test_driven_development.png "Test Driven Development") should look something like this: ![Test Driven Development](images/test_driven_development.png )


numpy dependency incorrect

As seen in the arraykit requirements.txt (https://github.com/static-frame/arraykit/blob/master/requirements.txt), since arraykit v0.2.4, the numpy dependency is numpy>=1.18.5.  However, this package has the numpy dependency pinned at 1.18.5.

Thanks, @DManowitz , for posting this issue.
I was only trying to pin NumPy at 1.18.5 for Python 3.7 and 3.8, as shown here:
https://github.com/conda-forge/arraykit-feedstock/blob/main/recipe/meta.yaml
Are you using that version of Python, or you seeing this issue in a different context? If you are getting a specific error, please share it. In the mean time, even if you are using conda, you should be able to install arraykit wheels with pip.
I also notice that the Azure builds are failing; I will investigate that as well.

I am using it with Python 3.8.

I have removed the pinned NumPy  for Python 3.7 and 3.8 and the build seems to work.
Thanks again for pointing this out.

I see that the NumPy pin at 1.18.5 has been removed for this package for versions 3.4 and 4.0.  However, there is an additional requirement of numpy >=1.24.3 now also.  The requirements.txt for arraykit only shows numpy >=1.18.5, so why has this additional requirement been added?

Any updates on this?  I see that the numpy >=1.24.3 requirement is still present for recent arraykit packages.


Regarding negative images for object detectors

Regarding this note, as why custom vision object detectors don't need negative examples: "Object detectors handle negative samples automatically, because any image areas outside of the drawn bounding boxes are considered negative."
Cant this risk to introduce some bias and optimistic test results? because we are sampling then only from positive images, context/surrounding of detected objects can have lots of signal, depending on ratio detection/image. Seems if we pass only positive images we are training for a different kind of problem and evaluation: assuming there's an interesting object here, where is it? (so more of a locator, not a detector, we dont even have negative images in evaluation, so a big part of potential false positives is ignored).
Or could be guidance should be provided like: provide images that are representative of the images the detector will receive in production, be they negative or positive. (then there's the technical aspect how are negative images handled or not by the underlying models/pipelines)
thx!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fdb2597d-a612-4cd2-3005-85ab51574f01
Version Independent ID: 84c078ba-b424-e81d-4dd1-1eb14b11d378
Content: Improving your model - Custom Vision Service - Azure Cognitive Services
Content Source: articles/cognitive-services/Custom-Vision-Service/getting-started-improving-your-classifier.md
Service: cognitive-services
Sub-service: custom-vision
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@rquintino Thanks for the question. We shall get back to you on the guidance for negative images/training for object detection based on feedback from our team. Thanks!!

@rquintino Based on feedback from our product team:

Typical object detection model training doesn’t include false positive images, and the model will do both bounding box localization and classification. In general, it can generalize false positive images pretty well.

Our team is also reviewing if the existing custom vision object detection code on false positives to provide guidance if user needs to provide any additional training to handle these scenarios.

@rquintino Based on feedback from our team, the following could be classified as concept of “negative” sample

Negative as a background
Negative as an object but it belonged to a unknown class.

The current object detector should automatically support the first case since we are looking at the object within the bounded boxes.
In the second case the user can just group a bunch of images into a new unknown tag and train the model and use custom vision as it is.
With respect to the models being optimistic of negative images. If the prediction bounding box is actually looking at a background area instead of the trained object, the precision of the object detector will actually drop and hence affecting the score instead of reporting any false positives. Hope this helps.

@rquintino We will now proceed to close this thread. If there are further questions regarding this matter, please tag @RohitMungi-MSFT in your reply.


spi bridge using libgpio

@mmoskal are you seeing anything obviously wrong with this? i am unable to get the spi bridge to respond and raise tx/rx pin events.


ISPN-7926 Add JMX support for Cluster Counters

https://issues.jboss.org/browse/ISPN-7926

@danberindei updated! thanks!

fixed the javadoc!

Integrated, thanks Pedro!
I created https://issues.jboss.org/browse/ISPN-8487 for further improvements on the JMX registration.

ok thanks @danberindei


chore: fix xdg path in macOS, fix GitHub

Signed-off-by: Keming<EMAIL_ADDRESS>

close https://github.com/tensorchord/envd/issues/702


Errors in docker logs

apphub-linux does not exist
/myApp/gaganode_install.sh: line 25: sudo: command not found
/myApp/gaganode_install.sh: line 31: sudo: command not found
/myApp/gaganode_install.sh: line 32: sudo: command not found
/myApp/gaganode_install.sh: line 38: sudo: command not found

In new version you must enter DOWNLOADLINK, FILENAME, TOKEN not just TOKEN.
Please read the README.md file.

In new version you must enter DOWNLOADLINK, FILENAME, TOKEN not just TOKEN. Please read the README.md file.

That's not the problem, is sudo that needs to be installed in the container
The container itself can also be rebased to 24.04 since it's out

Yes, I see the same error. You have to remove sudo from the shell script as it is not installed by default.
cpu_arch=aarch64
DOWNLOADLINK=https://assets.coreservice.io/public/package/61/app-market-gaga-pro/1.0.4/app-market-gaga-pro-1_0_4.tar.gz
FILENAME=apphub-linux-arm64.tar.gz
TOKEN=------------------------------------
apphub-linux does not exist
/myApp/gaganode_install.sh: line 25: sudo: command not found
/myApp/gaganode_install.sh: line 31: sudo: command not found
/myApp/gaganode_install.sh: line 32: sudo: command not found
/myApp/gaganode_install.sh: line 38: sudo: command not found

Thank you

@ElDavoo
You can check again now.


feat(checkstyleconfig): adds a removeDuplicates option to remove duplicate violations

This creates a new optional removeDuplicates option that will filter duplicate violations found while scanning and report them just once.
fix #2
This was specially noticeable in our repo with multi-module setup, where 2 violations ended up being reported as ~40 since they were in a base module imported transitively into almost every other one.
My knowledge of TS is quite limited, so the code might not be the best. I tried adding a new test case and it passes.

@Rouby I'm replying here because I couldn't find a better way to reach out: would it be possible to release a new version soon? The changes were integrated in to the repo, but we don't really like the idea of pointing to a commit hash instead of an actual version.

Yeah sure, I'll trigger a publish run. Sorry for the delays :)


Construct new Curator Training Slides

A curator guide has been developed, but curator training materials are needed to begin training ESDIS curators.

[ ] Slide deck for training
[ ] Share with ESDIS

@deborahUAH Should we close this ticket or move it to the backlog for now?

yes, sounds good


Consolidate (base) images

rancher/rancher and rancher/rancher-agent or on ubuntu:18.04
Most of the logging/alert images are on ubuntu:16.04
Some tools containers are on nginx-alpine
rancher/kube-api-auth use ubuntu:16.04

Would be good to consolidate to one base image. In 1.6 we have server-base/agent-base, maybe a single base image for ourselves would help, to also include common tools (but not the whole world in binaries).

This was proposed and well-received in DAR. This would also likely benefit our CVE scanning/reporting process. The current suggestion is UBI for now, SLES micro later.

rancher/rancher and rancher/rancher-agent are moved to SLE BCI per https://github.com/rancher/rancher/issues/33127

This has been completed in rancher/agent/kube-api-auth. Closing.


Allow setting elevation on any type of View

Moved setElevation from ReactViewManager to BaseViewManager. This allows
setting elevation on any type of view such as Toolbar for exemple.

Awesome! What different view types have you tested this on?

@corbt The main goal was to make it work for Toolbar so I tested that, not sure if there are other type of views that are supposed to produce a shadow when elevation is set.

cc @mkonicek

I've been looking over this PR just now, and it works great. I'm curious though -- would your use case be served by wrapping a ToolbarAndroid inside a View and setting the elevation on the outer View?
There are already a number of properties that are only available on Views and ImageViews like all the border* styles. That said, I'm not sure if there's a particular reason why that's the case. I don't see a reason why we shouldn't make elevation generally available.

@corbt Yes it is possible to wrap it but it would be better not to have to. Like you said I don't think there is a reason to limit it to View, especially since it is a method on the native View class so it is always possible to set it.

Ok @janicduplessis if no one else chimes in I am sufficiently convinced that this is a good idea. I think maybe the border* stuff was only on Views because it couldn't easily be implemented across the board, but since elevation is baked into Android on any view in the hierarchy (at least those that define an outline), it makes sense to make that available everywhere.
Since the Travis build failed and it's been kinda iffy for the last few days, but seems better now, could you rebase this on master, and then I'll merge it!

@corbt Done, all green now.

@facebook-github-bot shipit

:tada:


CORS policy

No matter what I try I get a CORS policy error.
Tried using the CDN to include the script still errors. Uploaded it to perplexity and asked it to give me code that sends a message and gets a response and perplexity says there's an error in the send on line 1575 ;(

hey @jakezz what is the environment you are using the script in?


style method is not called for polygons and linear features

Reference doc shows a style method which is similar to what vanilla Leaflet uses for styling vector features:
https://esri.github.io/esri-leaflet/api-reference/layers/cluster-feature-layer.html
The style method works fine with L.esri.featureLayer, but I do not see it ever getting called when using a polygon or linear feature service. Is there some trick to get it to work - or some known issues? I couldn't find any code examples of it working with the Esri cluster plugin.
And yes - I know it doesn't really make sense to cluster vectors, but I have a generic utility that is not aware of the geometry type of the feature service... though if there is a way to auto detect that I could use L.esri.featureLayer instead, I suppose... but since the documentation says it works, and since I do see implementations of options.style and setStyle / resetStyle in the source, I figured I would try to use it.
Sample code:
var bikePaths = L.esri.Cluster.featureLayer({
    url: 'https://services.arcgis.com/uCXeTVveQzP4IIcx/ArcGIS/rest/services/Bike_Routes/FeatureServer/0',
    onEachFeature: function(feature, layer)
    {
        // this works - called for each feature
    },
    pointToLayer: function (feature, latlng)
    {
        // this works - called for each point feature
    },
    style: function (feature, layer)
    {
        // never called - despite having linear and polygon features
        // the linear and polygon features do show up fine.
        // they don't cluster, but that's to be expected (they are vectors)
        // wth documentation?
    },
  }).addTo(map)

I debugged a bit - seems to be the problem is that features are loaded asynchronously and so the initial call to options.style never happens because the layer is empty.
My workaround hack was to simply call layer.setStyle from within onEachFeature for vector features.
...
onEachFeature: function(feature, layer)
{
    if (feature.geometry.type !== "Point" && feature.geometry.type !== "MultiPoint")
    {
        // explicit call to setStyle to force initial default custom style
        bikePaths.setStyle(bikePaths.options.style);
    }
}
...

Also (originally) posted on GIS stackexchange
https://gis.stackexchange.com/questions/328171/l-esri-cluster-featurelayer-does-not-call-style-function

I have a generic utility that is not aware of the geometry type of the feature service... though if there is a way to auto detect that I could use L.esri.featureLayer instead, I suppose.

something like this would work:
const url = 'https://services.arcgis.com/P3ePLMYs2RVChkJx/arcgis/rest/services/World_Time_Zones/FeatureServer/0'

L.esri.request(url, {}, function (err, response) {
  if (response.geometryType === "esriGeometryPoint") {
    L.esri.Cluster.featureLayer({ url }).addTo(map)
  } else {
    L.esri.featureLayer({ url }).addTo(map);
  }
})

The style method works fine with L.esri.featureLayer, but I do not see it ever getting called when using a polygon or linear feature service.

Internally we're calling, Leaflet's own L.GeoJSON.geometryToLayer, and that method is ignoring style.
L.GeoJSON.geometryToLayer({
  "type": "LineString",
  "coordinates": [
    [20.0, 0.0],
    [100.0, 45.0]
  ]
}, {
  style: function (feature) {
    return { color: 'red' }
  }
}).addTo(map);

I think that's a bug, but I'm also happy to just remove style from our own documentation.

Thanks for clarifying - style does work, it turns out, but there were no features to style when it was initially invoked.
So my solution was to call resetStyle on the feature's ID when it loads and that makes it style correctly. This does require defining the style method on the cluster layer's options (see original question for example.. though of course with returning the actual style object).
For my first attempt I was using setStyle but that styles the whole layer, which seemed wasteful & redundant, especially when there are lots of features that come into view as you pan & zoom the map. After profiling a bit with resetStyle in onAddFeature I found the performance to be acceptable, and it certainly achieves the desired result.
I propose to maybe just update the documentation to note that style may not be used until after the features load. It is useful! Users like the pretty colors ;)

I could push a proposed docs update, but I didn't find the docs in the repo

you can find it here: https://github.com/Esri/esri-leaflet-doc/blob/master/src/pages/api-reference/layers/cluster-feature-layer.md

I didn't realize that ArcGIS tends to have (or can only support?) just one geometry per layer.

That's correct. Polygons and MultiPolygons can live side by side in a single layer, but LineStrings and Polygons can not.

cc/ @patrickarlt for visibility, since he isn't listed as watching this repo.

@nothingisnecessary regarding

Should I close this issue? Standing by on decision about revising the docs.. thanks.

I leave it up to you. We welcome pull requests for documentation changes but we can also close out this issue if you wish.


With update calling create, the returned links will have _self wrong. Factor out the saving logic.

Nope


Furnace Brewingstand Bug

*Description of issue:
If a Player have allready registered a furnace or a brewingstand and adds hopper to auto fill by chest`s
they get no more job XP or money.....can you help me with this..??

oh and by the way i already learned to compile your project..!!

Disable ExploitProtections.Smelt.PreventHopperFillUps option in generalConfig.

Thanks and sry ....


app resets to the root page(starting page) in android

HI,
after picking the image, the application moving  back to the root page and.. the cropping is happening ?
what might be the issue ? need help?

found that.. when u r about to crop.. its calling on resume methods in app.xaml.cs in android..


Add functions related to Genshin Impact fps unlocking

I really need this feature to avoid opening unnecessary applications

120fps，144fps，More frame rate settings should be added

Hello, these functions were requested multiple times and all those times we declined adding such features because we would have to directly modify game files, unlike Honkai Impact 3rd and Honkai: Star Rail that just requires modifying registry settings, and it's something we are not committed to do as it would directly violate their ToS. If you want a more specific answer read here. You can also check our contribution guideline to see what we are more likely to add and whatnot.


Adding always true condition using refined variable prevents subsequent refinement of variable

🔎 Search Terms
narrow, always true
🕗 Version & Regression Information

This changed between versions 5.2.2 and nightly

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.3.0-dev.20231018&ssl=11&ssc=1&pln=13&pc=1#code/C4TwDgpgBAqgdgSwPZygXgFBSgHygbylEgC4oByAQ3IG4oA3SgJwUrmDIEYoBfLXAkXAQyVWg2at2ZAEy9+eQsREUARuV40MGAGYBXOAGNgyVBAAelALZgANhE4AKRrb0r4pgJRklw0dTpGFjYOKDkeATg9W1sCfgQdKGdKVwgAOmUoAEI0NApqTzjsbCYIYD0mVCiYrWw+eMTk1LSgqWB0XKhOQvx+ErKKqujbWvl+UvLKiVStev0jExQoC2s7CBkmtzIPFG9BZX9xVpDZXkjhoqgEpJc3DOFszrEevqgJwahqkf567GvHV63dKZXJ5MRQABkEKgAHoYVAAM4ACyQ0QAJlAUgB3SggBFQVTQYBMNyAlJ3Y7sDp5Tj8F7FN4DKZfUa-WHwgBySCxRCREFK5HxlCEkGWTCYSCY4yZqCBs2082MpmWlhs9gAzJt3Ihdj4RSoxIFJCcwmc8F9Lv8gfdRTkwQVLv1JkMaj9tH9GmTmpkoezESj0ZjbDi8QSiSSIF6KcaqaCunTHYznZ9hqz3X6uTzgHyBUL9WKJVKnR85Rg+EA
💻 Code
type Union =
  | { type: 'a'; variant: 1 }
  | { type: 'a'; variant: 2 }
  | { type: 'b' };

function example1(value: Union): { type: 'a'; variant: 2 } | null {
  if (value.type !== 'a') {
    return null;
  }

  if (value.variant === 1) {
    return null;
  }

  return value;
}

function example2(value: Union): { type: 'a'; variant: 2 } | null {
  if (value.type !== 'a') {
    return null;
  }

  if (
    value.type === 'a' && // should always be true
    value.variant === 1
  ) {
    return null;
  }

  // Now there's a type error
  return value;
}

function example3(value: Union): { type: 'a'; variant: 2 } | null {
  if (value.type !== 'a') {
    return null;
  }

  if (
    value.type && // should always be true
    value.variant === 1
  ) {
    return null;
  }

  // Now there's a type error
  return value;
}

🙁 Actual behavior
Type error
🙂 Expected behavior
No type error
Additional information about the issue
No response

Bisects to #55464

Hmm, yeah, that's not right. The issue here is that the type property isn't classified as a discriminant property in the computed type { type: 'a'; variant: 1 }  | { type: 'a'; variant: 2 } because it has a uniform type. It's only classified as a discriminant property in the declared type Union, but with the change in #55464 we're examining the computed type. I think the fix is to always examine the declared type as long as the computed type is a subset of that type, and only examine the computed type when it isn't a subset (e.g. because of a preceding type predicate narrowing, as in #55425).


OR-TOOLS - Pick-up and Delivery Load and Unload Times

Python, Trying to solve PDPTW, would like to obtain solution with load and unload time
I'm trying to add load and unload times.
I've found to add these load and unload times at the depot.  As demonstrated below.
But I'm solving a Pick- up and Delivery Problem and I want to add load and unload time at every node.
Besides the load and unload times depend for every node.
So how to add this interval for every node and not only on the depot.
solver = routing.solver()
intervals = []
for i in range(data['num_vehicles']):
    # Add time windows at start of routes
    intervals.append(
        solver.FixedDurationIntervalVar(
            time_dimension.CumulVar(routing.Start(i)),
            data['vehicle_load_time'], 'depot_interval'))
    # Add time windows at end of routes.
    intervals.append(
        solver.FixedDurationIntervalVar(
            time_dimension.CumulVar(routing.End(i)),
            data['vehicle_unload_time'], 'depot_interval'))

Why not adding the load/unload time directly to the transit callback ?


feat(tools): do not invoke tasks if not necessary

In dev executes tasks only when a specific file type has changed.
Fix #1432.

@robstoll thanks for the review! It seems vim messed the indentation up during the rebase I did. shallRun is more clear so I renamed it too.


KeyError on 'current_page' in the form cleaned_data

Where does current_page get set in the form?
I've had error reports come in that upon submission our dev site is returning a 500 error, and I'm seeing a KeyError on current_page from;
else:
    messages.success(self.request,
        strip_tags(form.form_definition.post_submit_msg))
    return redirect(
        form.redirect_url or form.cleaned_data['current_page'])

I can only see attempts to get current_page from cleaned_data, but no other mention of it;
https://github.com/mishbahr/djangocms-forms/search?utf8=✓&q=current_page
I've debugged this & I can see what I expected - my form fields, plus form_id and referrer. Oddly this was working locally yesterday.
Should this not be doing form.cleaned_data['referrer'] instead in order to return to the page you've posted from?
I'm running my forked codebase & it seems to work with this fix; https://github.com/mishbahr/djangocms-forms/compare/master...marksweb:referrer_fix

I'll look into this. Thanks for reporting.


I2C->SoftI2C, typos fixed, black formatting

I've successfully used this with the Adafruit AHT20 StemmaQT/Qwiic board, and an ESP32 running MicroPython 1.18.
In doing so:

I2C is marked as deprecated in favour of SoftI2C (updated here)
fixed some typos
formatted with black
noticed in manual testing that umqtt.simple may not connect to some brokers due to a change to the connection handshake. My board didn't have the same sleep capabilities so I didn't test all of the deepsleep sample, but was able to use umqtt.robust and set a keepalive value to resolve this (see e.g. https://github.com/micropython/micropython-lib/issues/466 which discusses the problem; I've not fixed it in this PR)

Just re-checked my notebook, and I believe the MQTT issue I mentioned can be fixed as follows (the umqtt.robust thing is not necessary):
# needs non-zero keepalive for mosquitto 2.0.12+
c = MQTTClient("umqtt_client", "hostname", keepalive=1)

Now added the above MQTT fix to the PR, and also spotted a mistake I'd left in the deepsleep sample, resolved.

Hi @andypiper, you already closed the PR, but do you have any reference regarding I2C deprecation and this SoftI2C? Fixing typos and formatting is a good idea anyway :-)

So I think it was a misunderstanding on my part of a message that came out of the build on MicroPython 1.18. A comment was left on my blog post about it. I was going to dig into this to make sure I was getting this right before re-sending something. Feel free to take a look if you know more about I2C than I do :-)


iOS 10 crash NSInternalInconsistencyException AVPlayerItem was deallocated while key value observers were still registered with it

Bug
Hello, I am using react-native and I see lots of crashes on iPhone 5, iPhone 5c running iOS 10 with this issue:
Fatal Exception: NSInternalInconsistencyException
An instance 0x15eed6e0 of class AVPlayerItem was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x15bbf0c0> ( <NSKeyValueObservance 0x15ea0a30: Observer: 0x15af23b0, Key path: status, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x15ea4e50> <NSKeyValueObservance 0x15ecf130: Observer: 0x15af23b0, Key path: playbackBufferEmpty, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x15aea630> <NSKeyValueObservance 0x15ef5920: Observer: 0x15af23b0, Key path: playbackLikelyToKeepUp, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x15ef5900> <NSKeyValueObservance 0x15ece400: Observer: 0x15af23b0, Key path: timedMetadata, Options: <New: YES, Old: NO, Prior: NO> Context: 0x0, Property: 0x15ab8650> )
Platform

Which player are you experiencing the problem on:

iOS

Environment info

React native info output:
System:
    OS: macOS 10.15.4
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 757.32 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 13.11.0 - /usr/local/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.14.4 - ~/.npm-packages/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK: Not Found
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>92135
    Xcode: 11.4.1/11E503a - /usr/bin/xcodebuild
  Languages:
    Java: javac 11 - /usr/bin/javac
    Python: 2.7.15 - /usr/local/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^16.13.1 => 16.13.1
    react-native: 0.62.2 => 0.62.2
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 5.0.2

Same issue here.


the test have no results

when I test the model for track 1: indoor
it always automatically quit after printing "please wait.."

And the results folder only has a "temp" subfolder.
Could you please help me?
@engindeniz
Thanks in advance.

I got the same problem. Have you solved it?

when I test the model for track 1: indoor
it always automatically quit after printing "please wait.."

And the results folder only has a "temp" subfolder.
Could you please help me?
@engindeniz
Thanks in advance.

when I test the model for track 1: indoor
it always automatically quit after printing "please wait.."

And the results folder only has a "temp" subfolder.
Could you please help me?
@engindeniz
Thanks in advance.

I got the same problem. Have you solved it?

when I test the model for track 1: indoor
it always automatically quit after printing "please wait.."
And the results folder only has a "temp" subfolder.
Could you please help me?
@engindeniz
Thanks in advance.
when I test the model for track 1: indoor
it always automatically quit after printing "please wait.."
And the results folder only has a "temp" subfolder.
Could you please help me?
@engindeniz
Thanks in advance.
I got the same problem. Have you solved it?

No,sorry.

Do you have MATLAB in your environment?

Yes,I have.

Can you look at the logs folders and check if there is an error?

Ok, thanks for your reply. I'll check it out later.

Hello! And  I tried to use this model for my own images, but I got a bunch of incapable image files, such as 'Error interpreting JPED image file' or 'Fatal error reading PNG image file'. Have you encountered this problem?

No, these errors are related to your images.

I have found the reason.first,You should resize your image into 256*256. Second and the most important,In the inference.py ,line 41,the code should be modified as "wb+".


Is there a way to turn off the one probe's manual from being given to the player on world creation?

Making a modpack that utilizes the akashic tome, and don't want this manual spawning in the player's inventory.

Yes, there is a config option in the config file


asuswrt gives a traceback when ipv6 is enabled on the router

When IPv6 is enabled, dnsmasq has a configuration line with the DUID.
This looks like this
61072 b8:27:eb:e1:4e:4d <IP_ADDRESS> domotycoon *
61072 b8:27:eb:b8:10:6b <IP_ADDRESS> pimonitor *
duid 00:03:00:01:ac:22:0b:e9:98:50
When using match.group() without testing if match != None, you get a traceback.

Awesome, thanks!


docker run can exit silently on ENOMEM

Seen under memory pressure: docker run exiting before its contained process, failing to show either:

the contained process' dying moments (it was due to crash because ENOMEM)
any distress of its own

Running docker ps quickly enough showed the container still running.
Running docker logs showed the contained process' dying moments.

closing because no response but feel free to ping me if you are still seeing it

Yeah, I'm OK with that. Sorry for letting it lie fallow.


Attempting to setup nodezoo-system on fuge, and have received the following error: Ready check failed: NOAUTH Authentication required.

Here is the relevant stack trace which I have received:
[nodezoo_dequeue - 70314]: events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: Ready check failed: NOAUTH Authentication required.
    at JavascriptReplyParser.parseResult (/Users/glen/work/nearform/nodezoo-system/services/nodezoo-dequeue/node_modules/redis-parser/lib/javascript.js:90:16)
    at JavascriptReplyParser.tryParsing (/Users/glen/work/nearform/nodezoo-system/services/nodezoo-dequeue/node_modules/redis-parser/lib/javascript.js:117:21)
    at JavascriptReplyParser.run (/Users/glen/work/nearform/nodezoo-system/services/nodezoo-dequeue/node_modules/redis-parser/lib/javascript.js:131:22)
    at JavascriptReplyParser.execute (/Users/glen/work/nearform/nodezoo-system/services/nodezoo-dequeue/node_modules/redis-parser/lib/javascript.js:112:10)
    at Socket.<anonymous> (/Users/glen/work/nearform/nodezoo-system/services/nodezoo-dequeue/node_modules/redis/index.js:223:27)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:153:18)
    at Socket.Readable.push (_stream_readable.js:111:10)
    at TCP.onread (net.js:531:20)
process exit [70314]: nodezoo_dequeue

This looks like a redis issue...as if someone is setting a password somehow. I know it was originally set up without a PW but for prod, we probably want to have one so it doesn't get fussed with.
Here, follow this thread I found on how to go about it:
http://stackoverflow.com/questions/34115213/redis-raise-error-noauth-authentication-required-but-there-is-no-password-setti

Awesome stuff @Georgette @mirceaalexandru nodezoo-system would need to be updated too with some envs.

Yes, and also we need some env vars for base host - as an example. This is required when installing on different machines.


Add more python repls

ptipython and ptpython add  support for a lot of useful features. They work with multiline much like ipython, so this should "just work".

Awesome! Thanks for helping!


Bug: synthesizer fails due to automatically added system hidden files

Hello,
After debugging my issue I've found, that function validateFilesAndReturnPath() from export-backend-asset-handler file fails due to this check:
const allFiles = fs.readdirSync(filePath);
    if (allFiles?.length > 1) {
      throw new Error();
    }

I see 2 issues there:

Firstly, error doesn't have description. If you get it (like I did), then CDK synthesizer will just throw an error without any description, which is very user non friendly.
And the root cause - if there are automatically generated files, like for example .DS_Store file on Mac, then it will fail, because number of files found is greater than 1.

I believe this might be a common issue, since you need to unzip function package manually and then zip it again, if you want to change anything in Lambda function, which is a story for another GitHub issue. I'm not sure, but I believe this file is created after that operation.

Please disable this stale bot, it doesn't make sense to use it, for tool that is not maintained and popular

@PatrykMilewski Yeah, it shouldn't be enabled. I will have it disabled.

I will mark this as a bug it looks like, it should be more selective on what it uploads


Did Not Connect: Potential Security Issue

Browser name and version: Floorp: Version 11.12.2 (64-bit) & Firefox: Version 125.0.3 (64-bit)
Device (mobile or desktop): Desktop (website)
Page where the issue happens: All

Describe the bug
Anytime I try to connect to the SteamDB.info site I get the pictured error. I have tried disabling every extension and change to my network on both browsers and also tried un and re installing firefox and still get this error
Extensions:
DuckDuckGo Privacy Essentials
Privacy Badger
uBlockOrigin
Network:
NextDNS
NordVPN

That's a problem on your end.

what am I to do to fix this?? I have found very little information online and spent over an hour now trobleshooting


Expose nrSessions

Useful for metrics (otherwise the private prop _sessions needs to be accessed to get the nr of sessions)

Nice, that's much easier/cleaner indeed. Updated


need to pay to get the API key

Have you find free alternative way ?

too bad it's not free

Not exactly an issue with the tool so closing.


corsPolicy allowOrigin from virtualService not blocking curl requests from different origins

Bug description
1.2.2/1.2.10/1.4.0/1.5.1/1.5.2/1.5.3/1.5.4/1.6.0 - allowOrigins not blocking curl requests from different origins. Security vulnerability scan has detected this. When I curl if a domain match I get it as  access-control-allow-origin: https://testthat.com, but if doesn't match I get  access-control-allow-origin: *. I am expecting the request to be blocked.
Expected behavior
The specified origin unless being set to * should block everything else exclusively.
Steps to reproduce the bug
Create a virtual service with CORS allowOrigins set to https://testthat.com, simulate REST API to the service behind it assuming another ORIGIN and the request will return 200.
On 1.6.0 I am using the virtualservice below to whitelist only single domain and with the following curl I am receiving 200 on a different, why isn't it blocked: curl -X OPTIONS 'https://api2.qa.testthat.com/v1/test/something' -H "Origin: https://testthat.com" -v
# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  labels:
    app.kubernetes.io/instance: qa-bom
    app.kubernetes.io/managed-by: Tiller
    app.kubernetes.io/name: service-test
    helm.sh/chart: service-test-0.1.0-release-2-7-0-4-227fd9a
  name: service-test
  namespace: qa
spec:
  gateways:
  - api-gateway
  hosts:
  - service-test
  - api2.qa.testthat.com
  http:
  - corsPolicy:
      allowHeaders:
      - Authorization
      - Content-Type
      allowMethods:
      - POST
      - GET
      - PUT
      - PATCH
      - DELETE
      allowOrigins:
      - exact: https://testthat.com
    match:
    - gateways:
      - api-gateway
      method:
        regex: GET|OPTIONS
      uri:
        regex: /v1/test/.*
    route:
    - destination:
        host: service-test
        port:
          number: 8080
        subset: active
      weight: 100

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
./istioctl version --remote
client version: 1.6.0
control plane version: 1.6.0
data plane version: 1.6.0 (57 proxies)

 kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-06T01:36:19Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

helm version
Client: &version.Version{SemVer:"v2.13.0", GitCommit:"79d07943b03aea2b76c12644b4b54733bc5958d6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.0", GitCommit:"79d07943b03aea2b76c12644b4b54733bc5958d6", GitTreeState:"clean"}

cat /etc/*release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.4 LTS"
NAME="Ubuntu"
VERSION="18.04.4 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.4 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

How was Istio installed?
https://istio.io/docs/setup/install/standalone-operator/'
Environment where bug was observed (cloud vendor, OS, etc)
On-premise Ubuntu OS

Still present on 1.6.0.

Not sure if it's related, but in Istio 1.6 all OPTION requests are getting 403, as we have an AuthorizationPolicy enabled. This is our configuration:
Authorization Policy
apiVersion: security.istio.io/v1beta1
kind: AuthorizationPolicy
metadata:
  name: default
  namespace: istio-system
spec:
  action: ALLOW
  rules:
    - when:
        - key: request.auth.claims[iss]
      values:
        - my.domain
    - from:
      - source:
          notRequestPrincipals:
          - '*'
      to:
      - operation:
          methods:
            - POST
          paths:
            - /token*
  selector:
     istio: ingressgateway

Virtual Service
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: my-service
  namespace: default
spec:
  gateways:
  - istio-system/default
  hosts:
  - api.my.domain
  http:
  - corsPolicy:
      allowCredentials: true
      allowHeaders:
      - content-type
      - authorization
      - x-token
      - x-origin
      - refresh-token
      allowMethods:
      - GET
      - POST
      - PUT
      - DELETE
      - PATCH
      - OPTIONS
      allowOrigin:
      - '*'
      maxAge: 300s
    match:
    - uri:
        prefix: /
    retries:
      attempts: 3
      perTryTimeout: 2s
      retryOn: gateway-error,connect-failure,refused-stream
    route:
    - destination:
        host: my-service
        port:
          number: 80

I tried to also let Option requests pass in the Authorization Policy, but no success. There is something up with CORS for sure.

I don't know if this helps but we migrated to 1.6 from 1.5 and we got a lot of CORS errors. We had to introduce the following change in our Virtualservice and this did the trick (it is not documented anywhere which is odd and we will create a PR on docs for this).
Previous config:
      allowOrigin:
      - https://example.com

New Config:
      allowOrigins:
      - exact: https://example.com

Instead of exact you can also use regex etc which may do the trick for wildcards. We had to search here for this: https://github.com/istio/api/blob/d98da5d2d058ed3fccdf1344bd6e7642bbc10bb4/kubernetes/customresourcedefinitions.gen.yaml#L2687
Hope this helps...

@commixon Works for me.

@sessfeld, @commixon does that mean if you curl from non-existing (manually set origin) you will get you request blocked without doing anything else?

For us yes, that's the case. We had this whole setup running as you described with istio 1.5 but got CORS errors upon 1.6 upgrade and had to apply the aforementioned tweak

I havn't tried it for that, our use-case is gRPC-Web.

@commixon, do you mind sharing some example vs/gateway you use, I am concerned that I didn't get any errors at all and I have tried both things.

@dntosas, it's great that this fixes the deprecation related issues, but I think the root cause in this topic is not fixed.
I have been testing with the new api and I get the same behavior. I make an example curl request with simulated fake origin diffrent than the one in the VS allowOrigins sections and when condition is not met the response is 200 with the only limiter of setting the origin to * instead of blocking it.
I don't know if it is possible that I am the only person who gets this, but I know that we are multiple people in the company that reproduce it on each version after 1.2.2. My hope is that I am understanding something incorrectly and I should be doing this differently or this is not supposed to block the request itself.

I have created a new lab on the only version that I didn't have tested - 1.3.8. It is based on bookinfo and it completely proves what I have said earlier, it is simply letting the request go with a 200 instead of blocking the bad ORIGIN.

Hi everyone. Testing CORS using curl can be a bit misleading. CORS is not enforced at the server side; it will not return a 4xx error for example. Instead, headers are returned back which are used by browsers to deny/accept. https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/cors.html?highlight=cors gives a good demo of this, and https://www.sohamkamani.com/blog/2016/12/21/web-security-cors/#:~:text=CORS isn't actually enforced,header in all its responses. is a good explanation.
So Istio's job here is simply to return these headers. I have added a test showing this works: https://github.com/istio/istio/pull/26231

@commixon can we use wildcard for subdomains like
`
allowOrigins:
-regex: https://*.example.com

You may use as below. Notice the dot before the wildcard symbol.
      allowOrigins:       - regex: https://.*.example.com

You may use as below. Notice the dot before the wildcard symbol.  allowOrigins: - regex: https://.*.example.com

Dot means any character, so in your regex wouldn't something like
blahexample&com pass?
I'm having an issue with getting a literal dot to work though in StringMatch.  I get unknown escape character.  But I would've expected it should be https://.*.example.com`