Factscore replication and CommunityLM Analysis

Description
Added the factuality analysis functionality. Replicated the FactScore paper and analyzed the CommunityLM models.
References
FActScore: Fine-grained Atomic Evaluation of Factual Precision in Long Form Text Generation (Min et al., EMNLP 2023).

Hi @AakritiKinra , it looks like mypy is failing, could you check the errors there and fix them? Thanks!


Project status?

Hello,
firstly thanks for good job with develop prometheus client implementation for PHP.
I want to ask this project is still maintained?

I've not seen any changes on this Repo but I'm working to fork this repo and have it actively maintained by my employer! Repo Fork coming soon!

@NoelDavies it's glad to hear! Maybe will be nice, to try put this php client into offical prometheus  org?

Well we've just forked it internally and I've spent a bit of time refactoring it all to php 7.1 with typehints and also updated the unit tests. Watch this space. It will be released soon-ish

@NoelDavies any news? I need to make some tweaks myself, would rather contribute to something maintained.

Apologies for the delay @simPod! We've got a package built and it's being used in production, but as I published the package, I  noticed this - https://github.com/beberlei/metrics - So we're having the internal discussion at the moment regarding to discontinue our implementation and use that one by Beberlei or continue using ours and the API provided by this package.

We've added our fork to github and are now adding this to composer https://github.com/endclothing/prometheus_client_php


Fix append vs. appending in README.

This PR fixes a small typo in a README example.

No changes here, closing.


chore(master): release 0.1.0

:robot: I have created a release beep boop
0.1.0 (2023-06-27)
Features

add $NVIM_APPNAME option (#1186) (5b54212)
ci: add automatic releases (9ecebdf)

Bug Fixes

wrong VSCode selections if cursor is at start of selection #1180 (f9bcd25)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/theol0403/vscode-neovim/releases/tag/v0.1.0 :sunflower:


adding link to colab notebook in README

Hey @PranY, thanks for the PR! It's interesting to have a quick start session at the README, and another possible useful resource to be present there is the class by Zachary Mueller here.
There is just one small problem, the README.md is automatically generated from the index.ipynb file present on the nbs/ folder, so you need to edit this file or the next time someone exports the documentation your changes will be overwritten.

@scart97 Thanks for the info, I'll send an updated PR with a link to Zachary Mueller's class. I'll update the index.ipynb file this time and run the build commands.

Updated and merged PR was #36. Closing this.


Create minihackathon portal with registration form

Create an information page on hackathon, which should contain a link to registration form (modal or new view). Information from the registration form should be stored automatically and a confirmation email should be sent.
Definition of done

[x] Select portal platform.
[x] Create subdomain.
[x] Create pages defined in task #361.
[x] Create registration form with mandatory and optional fields.
[x] Ensure data submission can be exported to csv.
[x] Send a notice of the form submission to an admin email (to be agreed).

Refer e.g. to this: (http://hackathon.affecto.fi/)[http://hackathon.affecto.fi/]

@elnzv Could you take this task?

I suggest to use [https://www.google.com/forms](Google Forms) for registration. It's easier and faster.

Suggested page sections (common for all hackathon web-sites):

About
Register
Schedule
Sponsors
Contact

Related repo: https://github.com/apinf/hackathon


PMX morph doesm't work

No error logs and crash. However, the PMX doesn't have correct morphs. It shows many morphs, but none of them work with mesh. When I drag the slider, nothing happens to model.
KKPMX Version: Release 3.0.2 (Newest up to the time issue submitted)
Blender Version: 3.6
MMD_Tools Plugin Version: 2.10.2 (Newest up to the time issue submitted)

Addition: All in one sequence is used; automatic process is chosen. The KK card has send to author's Discord DM.

This does not appear to be a problem with the software. It's probably a problem with the character card itself.


Top Contributors Added in repo

Displays top contributors

@rkatti Thanks for the contribution.
Couple of issues with this PR.
The summary column is primarily geared towards numbers. Adding name to this list causes the widget to expand and look wierd as shown below. You may want to make the "CONTRIBUTORS" label a link and popup a dialog box with the top contributors. Please rework and resubmit.

@rkatti Reopen when ready.


1.2.4

For 1.2.4， i got results below, any bug in new code?

hope to reply

i havent update any code


Better defaults for StreamingDataset subclasses

With better defaults and new features being added to Streaming, this PR makes sure those improvements are reflected in llm-foundry. Specifically:

Default shuffle_algo changed to py1e: More balanced downloads and cache limit performance
Default partition_algo changed to relaxed: Elastic determinism and resumptions on many more numbers of nodes
Default predownload changed to None: Lower predownload for more balanced download demand. Will be set by StreamingDataset.
Default num_canonical_nodes changed to None: Now set to equal the number of physical nodes, unless using py1s and py2s shuffle algorithms, in which case will equal 64 * physical nodes.
Default shuffle_block_size changed to None: Now set based on num_canonical_nodes to give a consistently good shuffle quality without needing a crazy amount of downloads.

Defaults were changed in Streaming v0.7.0 with this commit: https://github.com/mosaicml/streaming/commit/93bf0549bb1d36092a1488004917b594d2ad251e

Overall looks good to me. Do we need to change the defaults in
https://github.com/mosaicml/llm-foundry/blob/84c86e3b0a3b63c0c71e52f1f762325daa8adc64/llmfoundry/data/denoising.py#L473
as well as in
https://github.com/mosaicml/llm-foundry/blob/84c86e3b0a3b63c0c71e52f1f762325daa8adc64/llmfoundry/data/finetuning/dataloader.py#L127
?

oop yes we do. Changing that now.


agent/httpserver: fix Alt-Svc support

strings.Split() was being called with the arguments reversed, and a "" element was being left on the array

LGTM, builds in codespace, although codebeat begs to differ.....

it's quite annoying as I can't see any way to simplify them further

agent/v0.2.4 tagged


chore: Revert "feat: Only create new witnesses for distinctiveness when duplicates exist"

This PR Reverts noir-lang/noir#2191 -- that PR was actually a breaking change since distinct implies that the user is relying on a particular ordering of witness indices which the optimization would have changed.

More concretely on a concrete order of public inputs, not necessarily witnesses, but yes :nerd_face:


Please bump wat to the newest version or relex the strict version requirement

@Mossaka Thanks for your report. I checked wasmtime and wat crates. The latest version of wasmtime is v14.0.4, and it uses wat of ^1.0.77, while the latest version of wat is 1.0.79. Based on the situation above, we'll update this dep to 1.0, is it ok for you?

Sounds good. Appreciate 🙏


New Metric: Pitch accuracy when all strings are merged to one

Poly Pitch Net models are doing quite well with pitch recognition (up to 82%), however one of the main problems remains the distinction between the strings. Create a new metric that will ignore the strings distinction and will merge all string to one, then check the pitch accuracy, RPA, RCA, RMSE. This new metric will tell how good the pitch recognition is overall, instead of how good the network is at the task of pitch recognition and string separation at the same time

The new metric can be called Full RPA, Full RCA, Full RMSE, I'm not sure what's better. There are thresholds set for periodicity, and again those thresholds are not that accurate (60-80%), it could be due to the network just being better at recognizing the pitch rather than the string. To make those metrics happen, first periodicity has to be evaluated with all evaluated thresholds - this is the way to know which threshold really behaves better in combination of periodicity estimation with pitch estimation:

Get the pitch for all strings at all times
Get the periodicity estimation for all the strings at all times.
Marry the two, sort the results by pitch value
Sort the labels by the pitch value
Finally sent the predicted and truth data to the metrics class, or make a new class with new RPA, RCA and RMSE objects (the latter seems to be better)

MultiPitchMetrics() have to be called from the Metrics class and not really from anywhere else. Keep that in mind!

Plots are not ready for the pitch periodicity information. I'm a bit worried that there is something wrong with the periodicity estimation based on the threshold, but let's see how the training and evaluation goes.

Make the new metric plot multiple threshold outputs on one plot with wandb. Here's a bit on how to do so.

Periodicity does work well, it's now clear that the network struggles tremendously with recognizing the string of source. Next step is to fix the metric, because now is seems that it outputs rubbish

There's a need to make a metric that can tell if the number of present notes was predicted correctly. The metric can either say how well was the number of notes predicted or how many times was it exactly the same.

RCA, RPA and RMSE require pitch in cents, however when passing pitch with possible zero values this is not that much of an option. Try to compare only the values that contain pitch, or set 0s to penn.FMIN in cents.
The new metric could for a example subtract predicted values row by row from the target values and take the minimum difference as a metric. This would tell how good the prediction is no matter the order of the target or predicted values. Apparently both sets of data (predicted, true) are a bit flawed and not always all notes are in the predictions.

Use this as example

Above example is exactly in the range of 4.8-5.3 seconds.

Test FRMSE2 seems very promising on the test example from above showed around 2, that's really good!

Closing the issue, metrics FRMSE2 and FRCA2 are now ready.


Add nth-prime

We can start an issue to track what exercises are being claimed. I'm not expecting to add more for now though.


Filter by source

Now it's possible to filter and sort by source. Closes #4

The Source column is hidden by default to save space.
The Alignment column is also hidden by default, in preparation for the remaster transition. It has been replaced by the Family column.


BUG -  Waypoints don't animate until they are in the camera. This ruins my layout for level 1b.

@wadek2 should be fixed as of commit 6d665fe375a91c5a348e8a757074d9299577d824


Issue using AwsLambdaReceiver for BoltJs - no event is captured or processed by the function.

Description
Hi - I've just started exploring the creation of a Slack app using BoltJS and Lambda (Node.js). I've been through the example provided in the official doc and trying to make it work in my environment. Although it looks like no events are processed/received by the function - even the url_verification sent by the app config page is not captured. I can't figure out what I'm missing here.
Here is the code for my function (similar to your example)
const crypto = require('crypto');
const { App, AwsLambdaReceiver, LogLevel } = require('@slack/bolt');

/**
 *
 * Event doc: https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-input-format
 * @param {Object} event - API Gateway Lambda Proxy Input Format
 *
 * Context doc: https://docs.aws.amazon.com/lambda/latest/dg/nodejs-prog-model-context.html
 * @param {Object} context
 *
 * Return doc: https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html
 * @returns {Object} object - API Gateway Lambda Proxy Output Format
 *
 */

// Initialize the Lambda receiver
const awsLambdaReceiver = new AwsLambdaReceiver({
    signingSecret: process.env.SLACK_SIGNING_SECRET,
});

// Initialize your app with your bot token and signing secret
const app = new App({
    token: process.env.SLACK_BOT_TOKEN,
    receiver: awsLambdaReceiver,
    logLevel: LogLevel.DEBUG
});

app.message('hello', async ({ message, say }) => {
    // say() sends a message to the channel where the event was triggered
    await say(`Hey there <@${message.user}>!`);
});

module.exports.handler = async (event, context, callback) => {
    console.log("Signing token - "+process.env.SLACK_SIGNING_SECRET)
    const handler = await awsLambdaReceiver.start();

    return handler(event, context, callback);
}

I'm also using SAM for running everything locally (I don't have the serverless framework installed). Here is my SAM template.yaml
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Description: >
  babylon-slack-challenge

  Sample SAM Template for babylon-slack-challenge

# More info about Globals: https://github.com/awslabs/serverless-application-model/blob/master/docs/globals.rst
Globals:
  Function:
    Timeout: 3

Resources:
  SlackBoltJsLayer:
    Type: AWS::Serverless::LayerVersion
    Properties:
      LayerName: slack-boltjs-layer
      ContentUri: layers/slack-boltjs-layer/
      CompatibleRuntimes:
        - nodejs14.x
    Metadata:
      BuildMethod: nodejs14.x
  AppSlackEventsService:
    Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
    Properties:
      Environment:
        Variables:
          SLACK_SIGNING_SECRET: 75a1a991248fmasked
          SLACK_BOT_TOKEN: xoxp-3019829214850-3022866883892-3019982683494-masked
      CodeUri: app-slack-events-service/
      Handler: app.handler
      Runtime: nodejs14.x
      Layers:
      - arn:aws:lambda:us-east-1:174253439432:layer:slack-boltjs-layer:1
      # - Ref: SlackBoltJsLayer
      Architectures:
        - x86_64
      Events:
        SlackEventAPI:
          Type: Api # More info about API Event Source: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#api
          Properties:
            Path: /api/slack/events
            Method: post
  AppDefinitionService:
    Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
    Properties:
      CodeUri: app-definition-service/
      Handler: app.lambdaHandler
      Runtime: nodejs14.x
      Layers:
        - !Ref SlackBoltJsLayer
      Architectures:
        - x86_64
      Events:
        SlackEventApi:
          Type: Api # More info about API Event Source: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#api
          Properties:
            Path: /api/v1/definition
            Method: get

And here is the output when I run the url verification from Slack
Invoking app.handler (nodejs14.x)
arn:aws:lambda:us-east-1:174253439432:layer:slack-boltjs-layer:1 is already cached. Skipping download
Skip pulling image and use local one: samcli/lambda:nodejs14.x-x86_64-61ebfee5b6c59bfc1c9a43867.
Mounting /Users/camsellem/BabylonSlack/babylon-slack-challenge/.aws-sam/build/AppSlackEventsService as /var/task:ro,delegated inside runtime container
2022-02-03T04:46:37.619Z        undefined       DEBUG   [DEBUG]  web-api:WebClient:0 initialized
2022-02-03T04:46:37.620Z        undefined       DEBUG   [DEBUG]  web-api:WebClient:0 apiCall('auth.test') start
2022-02-03T04:46:37.622Z        undefined       DEBUG   [DEBUG]  web-api:WebClient:0 will perform http request
2022-02-03T04:46:37.642Z        160d25e1-02c3-4d39-aa48-d609cc7cde42    INFO    Signing token - 75a1a991248fmasked
END RequestId: 160d25e1-02c3-4d39-aa48-d609cc7cde42
REPORT RequestId: 160d25e1-02c3-4d39-aa48-d609cc7cde42  Init Duration: 0.48 ms  Duration: 391.37 ms     Billed Duration: 392 ms Memory Size: 128 MB     Max Memory Used: 128 MB
No Content-Type given. Defaulting to 'application/json'.
2022-02-03 15:46:37 <IP_ADDRESS> - - [03/Feb/2022 15:46:37] "POST /api/slack/events HTTP/1.1" 401 -

Please note that the error 401 is "normal" - since I'm using AWS API Gateway for creating the endpoint - it expects to process a code 200 in the response.
Help is much appreciated.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Hi @camsellem, thanks for writing in!
The only cause of your situation, that I can think of would be that your signing secret may be wrong. The following lines of code are the only part that responds with 401 HTTP status code: https://github.com/slackapi/bolt-js/blob/%40slack/bolt%403.9.0/src/receivers/AwsLambdaReceiver.ts#L136-L138
I hope this helps!

I am also getting a 401 status code with my Lambda setup. I have not been able to figure this out yet. I did double-check my signing secret.

@seratch Here's a screenshot of the error in serverless:

I just get a 401 message in ngrok:

@brennaharden Your issue is related to the SLACK_BOT_TOKEN, not SLACK_SIGNING_SECRET. Can you double-check if your app successfully load a necessary token (xoxb- prefix) for API calls?

@seratch Sorry it took me so long to get back to you, but yes! Thank you, that was the clue I needed. Had to re-export my envs and quit the terminal. Thanks again!

@brennaharden Glad to hear that my suggestion was helpful!
The original issue has been inactive for a month. Let us close this one now but please feel free to write in whenever you have anything! @camsellem


Resolved class getAliases() are not covered by tests

Accidentally found during re-write of said functionality by mistakenly putting patterns instead of actual aliases into the respective set:
https://github.com/opendistro-for-elasticsearch/security/pull/258
There is exactly one place of use for it btw, maybe it's time to drop it altogether?

Hi @DmitryOlshansky,
OpenDistro has since been superseded by OpenSearch. Do you mind pulling latest and checking again?

We are doing some "spring cleaning in the fall", and to make sure we focus our energies on the right issues and we get a better picture of the state of the repo, we are closing all issues that we are carrying over from the ODFE era (ODFE is no longer supported/maintained, see post here).
If you believe this issue should still be considered for current versions of OpenSearch, apologies! Please let us know by re-opening it.
Thanks!


Polylines are distorted in Streetscape compared to other Visualization tool like Kepler or Geojson.io

I am trying to visualize below Geojson in Streetscape.gl
{   "type": "FeatureCollection",   "features": [     {       "type": "Feature",       "properties": {         "stroke": "#FFFF00",         "stroke-width": 2,         "stroke-opacity": 1       },       "geometry": {         "type": "LineString",         "coordinates": [                              [                     -117.1365798525,                     32.8932626536,                     0                   ],                   [                     -117.1365903505,                     32.8932577329,                     0                   ],                   [                     -117.1366009332,                     32.89325346,                     0                   ],                   [                     -117.1366109529,                     32.8932490706,                     0                   ],                   [                     -117.1366214774,                     32.8932444199,                     0                   ]         ]       }     }   ] }
I am generating my visualization using Xviz. However polyline looks more zigzag compared to other tools (Kepler, Geojson.io)
Same visualization looks very smooth in Geojson.io as below

Same visualization looks quite smooth in Kepler.gl  as below

However when I visualise same line in streetscape.gl it seems to far more distorted as below

I have observed same behaviour across many polylines.
Is this issue in streetscape.gl implementation? or any config that I need to configure.? Or are other visualisation tools doing any kind of processing that makes line appear more smoother than in case of streetscape.gl ?

@twojtasz any thoughts about this issue/ behaviour

This might be due to xviz parser packing positions into a Float32Arrray. Most of our data is vehicle relative. Lnglat positions would lose precision in 32 bit.

Yes I m using JSON format . should I move to GLB ?

I moved to GLB dont see any difference .. Could it be that AVS supports higher resolution thank Kepler and other frameworks?

I am not sure if this fix is real issue . Because in order to test I pasted same lat long in direct json generated. So Xviz parsing dosent come into play. I simply edited json file created post xviz manually and put the coordinates

Ok thanks I will try to test it .. Is this merged into master main release or do I need to take any specific version or using streetscape 1.0 release will work for me ?


Pin a list item

Added the ability to pin a list item.
Design:
https://github.com/fabric8-ui/fabric8-ux/issues/734
Example:
https://rawgit.com/dlabrecq/patternfly-ng/pin-dist/dist-demo/#/list

Note that the pin background color does not stretch vertically. @mindreeper2420, can you please take a look?

Adjusted the pin background to stretch properly using flex.


After update Firebase-ESP32 library from version 4.1.0 to version 4.2.0, the error 'method not allow' is occur.

Describe the bug
After update Firebase-ESP32 library from version 4.1.0 to version 4.2.0, the error 'method not allow' is occur. (version4.1.0 work fine.)
Some update methods (setTimestamp, setInt) have error 'method not allow'. Sometime, data in RTDB lost when it is updated.
To Reproduce
call method 'setTimestame' -> result error
call method 'setInt' -> result error
Expected behavior
Data is correctly updated.
Screenshots

IDE and its version:

Arduino IDE
Version 1.8.19

ESP32 Arduino Core SDK version

Version 2.0.5

The update is not affected to all Firebase operations included request and response management i.e. no changes in the RTDB operations.
The update is related to the TCP client which now shared usage from user assigned FirebaseData object and used in authentication process as normally when authentication process was performing, the user FirebaseData object will not be able to connect to the server as usual.
The library v4.2.0 works normally with intensively test with all examples.
Please note that using Strings and string literal joining or concatenation are not allowed in all library functions that accept string as parameter.
I recommend removing all installed Firebase libraries in Arduino libraries folder and install the latest version from library manager to prevent the compiler wrong file links from several files with the same name issue.
If you feel that there is bug, please verify your code changes then create clean and simple example code that replicate the bug post it and describe the bug here.

Ok. After I follow your advise and update to version 4.2.1, it back to work usual.
Thank you very much :)


the results of benchmarking small functions are malformed

Correctly maintaining the gabarge collection mechanisms of the two languages causes benchmarking issues, which can be observed when using Python's timeit.
# julia
using TyPython
using TyPython.CPython

@export_py function add(a::Int, b::Int)::Int
    return a + b
end

@export_pymodule myops begin
      add = Pyfunc(add)
end
# python

import operators
%timeit myops.add(1, 2)  # 500ns
%timeit operator.add(1, 2)  # 49ns

Above benchmark for Python operator.add is fine, but quite unfair for the Julia one, as in the realworld cases, myops.add works much faster:
import time
import sys

def realworld_timeit(code: str, N = 100000, globals: 'dict | None' = None):
    code = compile(f"for i in range({N}): {code}", '<string>', 'exec')
    t = time.time_ns()
    exec(code, globals or sys._getframe().f_globals)
    print((time.time_ns() - t) / N)

realworld_timeit("myops.add(1, 2)")  # 120ns
realworld_timeit("operator.add(1, 2)")  # 80ns

This is because Julia uses a real GC which will scan the heap instead of Python's reference counting. Calling into a small function from a foreign language (like CPython) can trigger a long GC operation.
Besides, WITH_GIL is so far a bit slow as it calls is_calling_julia_from_python. Such process is required when finalizing a Julia wrapped Python object.
https://github.com/Suzhou-Tongyuan/jnumpy/blob/d132c71b4207198b7c8ba9ccae17cdc258af75af/TyPython/src/CPython.APIs.jl#L13-L17
https://github.com/Suzhou-Tongyuan/jnumpy/blob/d132c71b4207198b7c8ba9ccae17cdc258af75af/TyPython/src/CPython.APIs.jl#L193-L196

After #18 and #19 get merged, this issue will get eased a lot:
In [9]: %timeit mylib.add(1, 2)
196 ns ± 159 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

In [10]: %timeit mylib.add(1, 2)
209 ns ± 155 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

In [11]: %timeit operator.add(1, 2)
48.5 ns ± 0.313 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)


Rogue "wrap return expression in Ok" errors

I can't really pinpoint the issue, so sorry for the bad description upfront 🙏.
When I open https://github.com/swc-project/swc/blob/5f261fcd5ca7c07db15632d0e62336fe0c6cf6f8/ecmascript/codegen/src/lib.rs, rust-analyzer reports a bazillion (39 to be exact 😉) errors with the message wrap return expression in Ok. The project compiles just fine though.
First I thought that it doesn't understand the emit! macros, but they expand just fine. Why is wrap return expression in Ok even an error? This sounds more like a code action or a fix for another error. I'm very confused...

The problem here is likely that #[emitter] is not expanded. You can use the following vscode configuration to enable proc-macros:
{
    "rust-analyzer.cargo.loadOutDirsFromCheck": true,
    "rust-analyzer.procMacro.enable": true,
}

I still see the errors even with proc macros enabled. The issue seems to be that the match statements are inferred as ().

Why is wrap return expression in Ok even an error? This sounds more like a code action or a fix for another error.

Well, the error is a type mismatch, we just don't report those yet because they still have too many false positives. In the particular case where we detect a type mismatch that could be fixed by Ok-wrapping, we show the diagnostic and quick-fix. That usually doesn't have too many false positives, but this is one.
The emit! calls getting inferred as () seems correct from the definition. I assume that the #[emitter] macro does something to make these functions typecheck. We don't expand attribute-like macros yet though.

I just came across this, with the following code on Visual Studio Code and the rust-analyzer extension:
pub fn foo() -> Result<(), ()> {
    loop {
        match bar() {
            Ok(_) => continue,
            Err(e) if true => break Ok(()),
            e => break e,
        }
    }
}

fn bar() -> Result<(), ()> {
    Ok(())
}

It will highlight the entire loop:

@Lonami that should be fixed with #4505, which should be in the next weekly release.

Can anyone confirm, that this is already fixed? #4505 landed already.

@ruabmbua the issue I highlighted in https://github.com/rust-analyzer/rust-analyzer/issues/4584#issuecomment-633268257 seems to be solved, but I don't know if OP's problem is any different or is actually the same as mine.

`#[emitter] is an attribute proc macro.
Closing this as a duplicate of #6029 since it's caused by an unexpanded proc macro attribute.

`#[emitter] is an attribute proc macro.
Closing this as a duplicate of #6029 since it's caused by an unexpanded proc macro attribute.


Captcha (Error)

I am encountering the error, that a captcha is showing while I am trying zu login.
Error: Recaptcha found
scheduler       |         at login (/home/node/app/node_modules/youtube-videos-uploader/src/upload.ts:1119:19)
scheduler       |         at processTicksAndRejections (node:internal/process/task_queues:95:5)
scheduler       |         at loadAccount (/home/node/app/node_modules/youtube-videos-uploader/src/upload.ts:896:13)
scheduler       |         at upload (/home/node/app/node_modules/youtube-videos-uploader/src/upload.ts:61:9)
scheduler       | [12:50:20.649] WARN (adonis_app/1): pino.final with prettyPrint does not support flushing
scheduler       | /home/node/app/node_modules/youtube-videos-uploader/dist/upload.js:916
scheduler       |             throw new Error('Recaptcha found');
scheduler       |                   ^
scheduler       |
scheduler       | Error: Recaptcha found
scheduler       |     at login (/home/node/app/node_modules/youtube-videos-uploader/src/upload.ts:1119:19)
scheduler       |     at processTicksAndRejections (node:internal/process/task_queues:95:5)
scheduler       |     at loadAccount (/home/node/app/node_modules/youtube-videos-uploader/src/upload.ts:896:13)
scheduler       |     at upload (/home/node/app/node_modules/youtube-videos-uploader/src/upload.ts:61:9)
scheduler       |
scheduler       | Node.js v18.16.0
I thought that my IP was maybe blocked, but another channel works fine with the upload. Is there any way to fix this from my side?

I am getting the same error, any updates?


Follow-up to dbdeps consolidation [databricks]

replace dbdeps not enabled using profiles, this case is missed in #9182
remove outdated comments

Signed-off-by: @gerashegalov

build

build


JenkinsDownloadArtifactsV1 - fixed typos

Task name: JenkinsDownloadArtifactsV1
Description: fixed typos
Documentation changes required: N
Added unit tests: N
Attached related issue: N
Checklist:

[ x ] Task version was bumped - please check instruction how to do it
[ x ] Checked that applied changes work as expected

...


Bug: Mac OS with Apple Silicon - Unable to update

What happened?
I can see the notification to update to version 2.0.6, however, when I click it, the program hangs after the blue progress bar is filled.
Steps to reproduce
Steps to reproduce

Download Vibe from Github Link.
Try to update when new release becomes available.

What OS are you seeing the problem on?
MacOS
Relevant log output
App Version: 2.0.3
Commit Hash: 370d1ce20e8a69668c76fe44a51f5b71237d69e8
Arch: aarch64
Platform: macos
Kernel Version: 14.5.0
OS: macos
OS Version: 14.5.0
Models: ggml-medium.bin
Default Model: ggml-medium.bin"

CPU feature detection is not supported on this architecture.

Console Log:
Failed to load resource: the server responded with a status of 400 (Bad Request)

Unhandled Promise Rejection: Permission denied (os error 13)

Thanks for report. I also reported about this issue to tauri. seems like It shouldn't happen on most macOS computers. but for some reason it happens on yours. as a workaround you can download newer version from Vibe's website.

Yup, that's what I have been doing. Just deleting and redownloading the app every time there is a new version out.
Thank you for the update, looks like a lot of people are experiencing the same problem while using unprivileged accounts with Tauri.


Css changes has not been applied

Hi @nandomoreirame
Thanks for great work!
I have a small problem with getting updates after changing CSS.
I made changes in _assets/sass/_banner.scss
Then I've run gulp sass:
[15:53:29] Using gulpfile ~/Projects/Jekyll/nandomoreira-jekyll-theme/gulpfile.js
[15:53:29] Starting 'sass'...
[15:53:30] ERROR: Cannot load compass.
[15:53:30] Finished 'sass' after 644 ms

And after running a server everything looks exactly as before.
Could you please give me some hints on how to modify CSS successfully?

Actually, I would be probably better for me to build something from scratch (and treat you project as an inspiration) 😺


Set up new database with Mongo Atlas

mLab was bought by MongoDB and they're going to be shutting down in October of 2019. To get ahead of this, we want to move over to Mongo Atlas (the new solution).

[x] Create dev database on atlas
[x] Create staging database on atlas
[x] Set staging database connection URI on Heroku env vars.

Dev database is setup on Atlas, connection string is in slack.
Staging database is setup on Atlas, connection string is updating in Heroku.

Note that both databases are completely empty now. Please clear your cookies on localhost:3000, localhost:30001, and drawchange.herokuapp.com for the app to work properly.
Also send me an email address I can use to add you as an Admin on MongoDB Atlas!

[x]  Create staging database on atlas
[x]  Set staging database connection URI on Heroku env vars.

By the way, did you mean staging or prod? Will we be running prod in atlas as well?

So we don't really have a prod server running rn. Until we get v1.0 officially launched there won't be prod. What we have running on the heroku is more of a staging or uat (user acceptance testing) box where we are testing our code in a production like environment, but it's not really production ready yet.
When we get closer to releasing v1.0 we can set up the prod db.


[Library Mode] Vite 4 output broken UMD when it is too large

Describe the bug
When output UMD is more than 5MB (not minified), the output js is likely to be cut off. And it is always at this function, probably related to "use strict":

Vite 3 works fine.

esbuild works fine(iife), too.

Reproduction
https://github.com/guoyunhe/vite4-large-umd
Steps to reproduce

git clone
npm install
npm run build
node

System Info
System:
    OS: macOS 13.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 2.28 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.1 - /usr/local/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.15.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 109.0.5414.119
    Edge: 109.0.1518.78
    Firefox: 109.0.1
    Safari: 16.2
  npmPackages:
    vite: ^4.1.1 => 4.1.1

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Works in my macos. Does the reproduction repo miss something?

@sun0day Sorry, I missed something. The repo was updated and you should be able to reproduce it now. Here is always a GitHub Action: https://github.com/guoyunhe/vite4-large-umd/actions/runs/4124121768/jobs/7122988858


add async client suggestion

Adds https://github.com/stefanotorresi/influxdb-php-async as a suggestion.
Please, let me know if you're open to unify the libraries.
Sadly, making something syncronous asyncronous is hardly possible, but maybe we can work together to achieve the quite possible opposite?

I am very happy to try something and I am trying to get some info from the community.. I am happy to have a public discussion here if we can get some good use cases and so on! :)

That's @stefanotorresi at the moment I am very busy, I hope to have time and some idea to get some feedback and to join this together.

no worries @gianarb, meanwhile I'll keep developing the async client.


backend: Consider the base URL for OIDC's redirect URL

If Headlamp is running with a base URL and uses OIDC, the redirect
URL doesn't take into account the base URL which leads to an error.
fixes #238

This needs to be tested.

I have added some more processing to the base URL before joining it so we don't use two / in the URL (usually multiple bars in the requests is fine but since we have URL comparisons going on, maybe it's better to ensure that we always get one / when separating the URL parts).

Lint's failing, I need to move code out of that huge function. Meeting now, will leave it for tomorrow.

@illume , please take a look. I think that with this change we don't allow regressions so we can safely merge.


Text alignment is not respected by placeholder/floating label.

Floating label and placeholder in RPFloatingPlaceholderTextField or RPFloatingPlaceholderTextView are aligned to the left regardless of alignment of the text.
Alignment of the floating label can be fixed programmatically, but since placeholder is drawn manually there is no way to change its alignment

Closed with #24


Integrate Parinfer

http://shaunlebron.github.io/parinfer/index.html looks pretty convenient. I am just checking out whether/how it is possible to integrate it in a minimal invasive fashion.
What do you think about it?
You might want to check shaunlebron/parinfer#24

:+1: Was about to feature-request the same!
One of the things that I miss the most when using gorilla-repl is the lack of paredit. Parinfer looks simple but powerful.

That looks very nice. Definitely interested in getting this going!

I have a very basic proof of concept working. It is in deas/gorilla-repl in the feature/cljs-parinfer branch. I used ClojureScript because there was no JavaScript library version of parinfer available last week. :)
However, there is one available today: https://www.npmjs.com/package/parinfer
Question now is where do you want to go with gorilla-repl?
You wan't the client source to be JavaScript or are you fine with ClojureScript?
PS: Personally, I'd prefer ClojureScript along with Figwheel and all the other goodness.

Cool, that's neat!
Although, I have to say, having now played with parinfer a bit it's currently in the same class as paredit is in my mind, which is "I can see why some people like it, but I find it very annoying"! So if we did integrate it it would definitely have to be optional somehow :-) My feeling - given I have a strong tendency to try and keep Gorilla simple and straightforward - is that it would be better just to stick with simple/obvious code editing, but I am open to being persuaded otherwise.
Regarding cljs: I certainly think cljs shows a lot of potential, but my experience using it is that it's a still a bit rough round the edges. I'm not sure I'd start a new project in it, and I'm definitely sure I wouldn't want to port an existing project like Gorilla to it :-)

I fully understand that you want to be very careful changing code. I also understand that you would like to have parinfer support optional.
I am not suggesting to go the risky route and port gorilla client code in one swoop. But I do think foundation cljs is pretty smooth and stable enough to start building upon. A basic non risky start could be the introduction of figwheel. I think its hot reloading alone is pretty much worth it. Even if you do not have a single line of cljs code.
We could then slowly go one step further by trying out cljs for optional parinfer only.
What do you think?

I think my preference is not to head in the cljs direction with Gorilla. Mainly because I'd have to see a big win from porting to cljs to justify changing a working piece of software, and I don't really see that at the moment. And with that in mind, I don't think I'm inclined to introduce cljs bit-by-bit as it's moving in a direction I don't want to head.
Regarding my opinion on cljs: I think the core of it is great, and it has great potential. I think a few things aren't there yet, like tool support - the dev tool experience is a bit patchy I've found - and the situation around interoperating with external js libraries is somewhat fiddly, although it's improving rapidly. Perhaps more importantly though, things haven't stabilised yet, and while it's fun to play with the bleeding edge, I'm not sure it's a great idea for a shipping project! In particular, while the core of cljs is quite stable, and the build tools are improving, there still seems to be a lot of flux in the libraries, and people are still figuring out what the best way to write apps is (Om, Om next etc ...). Personally, I'd be looking for that to settle a bit before basing a project on cljs.
Regardig figwheel: yes, love it. I'd say the real benefit of using it isn't realised though unless you're going the whole hog and structuring your app to take advantage of it (i.e. having some state container and everything tracking from that). Gorilla isn't really in that form, so I'm not sure there'd be much benefit to integrating it. Also, I find that, because it's possible to save Gorilla worksheets that debugging things isn't too painful with reloads.
Sorry if this all coming off a bit negative ... if it helps, it's not so much negativity as plain old-fashioned conservatism!!

No problem. I fully respect your choice and I am not disappointed. ;)
Personally, I think for gorilla, the choice of the UI library does not really matter since it uses just a handful of services.
However, I would still like to push cljs and I will continue working on my cljs branch. It would be nice if that  easily rebases with develop so things don't diverge too much and we may join later on.
Regarding parinfer, I'll check whether the npm version easily goes on top of develop and let you know -  but going cljs is my priority.

It looks like parinfer is available in javascript now.  My js fu is lacking otherwise I'd take a crack at integrating it with Gorilla.  Do you have any interest in picking this back up?

I want to chime in on the anti-parinfer (and anti-paredit) side of this. I find both paredit and parinfer to be intensely irritating and problematic. If either of these must be added, then I hope they can be made optional.

PS to my comment above, from my perspective (which I acknowledge is a bit idiosyncratic but FWIW is based on decades of teaching and using Lisps), even the "smartish" stuff that Gorilla already does with parentheses is a bit of an anti-feature.
It's not nearly as bad as paredit or parinfer would be, but I routinely see students surprised and fighting with it when they try to fix code, for example when highlighting some code and hitting something like "(" which they expect will replace the highlighted code (as it would in any normal editor), but then it does something "clever" instead.
I understand why people think these features are cool, but in my experience they are counterproductive, especially for newcomers but even for me as a long-time Lisper.
A Lisp editor should absolutely show what matches what (as Gorilla does quite nicely, although something like rainbow-parens could be even nicer), and it should absolutely provide syntax-aware auto-indenting and re-indenting (as Gorilla does perfectly with shift-tab). But from my perspective pretty much any attempt to be "smarter", including the automatic insertion of closing brackets or anything that interferes with normal typing or cut/paste semantics, inevitably does unexpected and confusing in some situations, and should be avoided.
I think that Gorilla is quite usable as it is, and I've been able to deal with (and help my students to deal with) its "clever" editing "assists" without too much trouble. But from my perspective the way to improve it would be to make it a bit less "smart," rather than a bit more.

My be a bit off topic in this context, but I am generally  trying to push  gorilla forward at this time. Tried getting in touch via j-star email  and now accidently invited to join on LinkedIn . :) However,  would you @JonyEpsilon mind having a quick chat on Skype?

FYI Ben Bailey (https://github.com/benfb) has produced a version of Gorilla REPL with a few strategic changes, and several of us have been using and teaching with it. We use it in conjunction with leiningen on the command line as a complete programming environment. For this purpose (with the changes we've made) it's quite wonderful; lightweight and trivial to "install," with all of the features that we need and none of the complexity we don't. A description of how we use it is here.

I believe we've resolved this privately with a fork of Gorilla 🙂

I believe we've resolved this privately with a fork of Gorilla 🙂


feat(tag): migrate tag component (VIV-944)

@AyalaBu Found the original design from vivid-2
https://github.com/Vonage/vivid/pull/1016
Are you sure we don't need sizes?


Error while Training

Hi all
update: I'm trying to train SD 1.5 (the inpaint version)
Getting the following error message
RuntimeError: Error(s) in loading state_dict for LatentDiffusion:
size mismatch for model.diffusion_model.input_blocks.0.0.weight: copying a param with shape torch.Size([320, 9, 3, 3]) from checkpoint, the shape in current model is torch.Size([320, 4, 3, 3]).
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/workspace/Dreambooth-Stable-Diffusion/main.py", line 896, in
if trainer.global_rank == 0:
NameError: name 'trainer' is not defined. Did you mean: 'Trainer'?

i get the same error

I went to line 896 on Main.py, and changed "trainer" for "Trainer", no it's working

Potentially related (NameError: name 'trainer' is not defined):

https://github.com/JoePenna/Dreambooth-Stable-Diffusion/issues/28
https://github.com/JoePenna/Dreambooth-Stable-Diffusion/issues/53
https://github.com/JoePenna/Dreambooth-Stable-Diffusion/issues/86
https://github.com/JoePenna/Dreambooth-Stable-Diffusion/issues/87

@H41907 were you able to get 1.5 to work ? im using the model from runwayml/stable-diffusion-v1-5 and it is constantly erroring out. could you point out how u got it to work ?

No, not resolved. I also stopped looking into it: at the time  I was  thinking  that the inpainting model is different to the standard SD model (1.4/1.5) and therefore not useable for Dreambooth.
size mismatch for model.diffusion_model.input_blocks.0.0.weight: copying a param with shape torch.Size([320, 9, 3, 3]) from checkpoint, the shape in current model is torch.Size([320, 4, 3, 3]).
I did not continue looking into it, maybe nowadays there is a solution or tool which solves the issue.

@H41907 same here. i moved to the Diffuser way of doing things. got it to work well. actually the Huggingface "accelerate" libraries make training much faster with 1.5.
here's my simple notebook on this - https://github.com/sandys/SimpleDiffuserDreambooth


Category and label missing

Hi,
the theme looks very good, but I miss the option to set the category and label for torrents (right click, and set it). It's possible in the default theme.
Thanks,
Feriman

Would love to have this too :-)


⚠ Bofrost.lu has degraded performance

In 610218c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1680 ms

Resolved: Bofrost.lu performance has improved in ad5829a after 6 minutes.


Can synonyms search and fuzzy search can be combined into single query? If not, how to achieve them in single query?

Describe the bug
For my requirement, I wanted to achieve the fuzzy search and synonyms search in single query.
I noticed that the synonym search is considering typo issues with Fuzziness param set to AUTO. But the synonyms are not matched for the corresponding resolved term.
For example, if I search for "ice cream", it retrieves the results related to dessert, gelato and other defined synonym terms which I have configured. But if I search for "iec cream", search provides the result only with ice cream, but the defined synonyms are not considered in result.
If the term ice was resolved by Fuzziness, my expectation was to resolve the terms along with synonyms with some lower score, which is not happening currently.
If this is something that can be achieved in a different way, please let me know. I would like to explore that.
Related component
Search
To Reproduce

Synonyms terms defined in csv and associated with AWS OS cluster:
ice cream, gelato, frozen custard, dessert

Created custom index with this associated synonyms path. { "settings": {  "index": {    "analysis": {      "analyzer": {        "my_analyzer": {          "type": "custom",          "tokenizer": "standard",          "filter": [ "my_synonym_filter"]        }      },      "filter": {        "my_synonym_filter": {          "type": "synonym",          "synonyms_path": "analyzers/F**********",          "updateable": true        }       }    }  } }, "mappings": {  "properties": {    "description": {      "type": "text",      "analyzer": "standard",      "search_analyzer": "my_analyzer"    }  } } }

Now searching for gelato, provides results with synonyms as expected.

But with typo like 'gealto', results are retrieved only for gelato and not for the other synonyms defined. Note: Fuzziness is set to AUTO in search query. { "query": {  "bool": {    "should": [      { "match": { "description": { "query": "gealto", "fuzziness": "AUTO" } } }    ]  } } }
Can someone help to resolve this issue?

Expected behavior
Expected behaviour is to return the results for ice cream, dessert even when there is typo in given input query as the fuzziness is set.
If there is a better way to achieve the same, please let me know. Will explore more on it.
Additional Details
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Below index creation helps to achieve the above request, where the synonyms are hardcoded while creating index:
PUT /my_index_1
{
  "settings": {
    "analysis": {
      "filter": {
        "synonym_filter": {
          "type": "synonym",
          "synonyms": [
            "quick,fast",
            "jumps,leaps"
          ]
        },
        "phonetic_filter": {
          "type": "phonetic",
          "encoder": "double_metaphone",
          "replace": false
        }
      },
      "analyzer": {
        "synonym_analyzer": {
          "tokenizer": "standard",
          "filter": [
            "lowercase",
            "synonym_filter",
            "phonetic_filter"
          ]
        }
      }
    }
  },
  "mappings": {
    "properties": {
      "content": {
        "type": "text",
        "analyzer": "synonym_analyzer"
      }
    }
  }
}

Adding few data into created index
POST /my_index_1/_doc/1
{
  "content": "The quick brown fox jumps over the lazy dog"
}

POST /my_index_1/_doc/2
{
  "content": "A fast brown fox leaps over a lazy dog"
}

Search query:
GET /my_index_1/_search
{
  "query": {
    "match": {
      "content": {
        "query": "quikc",
        "fuzziness": "AUTO",
        "analyzer": "synonym_analyzer"
      }
    }
  }
}

This returns the results which includes the synonyms as well. ie, both records are returned.
But, when providing the synonyms as text file with synonyms_path, this index creation fails with below error:
PUT /my_index_3
{
  "settings": {
    "analysis": {
      "filter": {
        "synonym_filter": {
          "type": "synonym",
          "synonyms_path": "analyzers/F265650900",
          "updateable": true
        },
        "phonetic_filter": {
          "type": "phonetic",
          "encoder": "double_metaphone",
          "replace": false
        }
      },
      "analyzer": {
        "cus_syn_srch_analyzer": {
          "tokenizer": "standard",
          "type": "custom",
          "filter": [
            "lowercase",
            "synonym_filter",
            "phonetic_filter"
          ]
        }
      }
    }
  },
  "mappings": {
    "properties": {
      "DOCUMENTTEXT": {
        "type": "text",
        "analyzer": "cus_syn_srch_analyzer"
      }
    }
  }
}

Error received: analyzer [cus_syn_srch_analyzer] contains filters [synonym_filter] that are not allowed to run in index time mode.


Fixing the hardcoded localhost variable

I've also smuggled in some refactoring here. There's a further refactor needed to move more of the logic into the email viewmodels so that we don't have to attempt to test based off of teh email views. Alternatively, we can add regression tests to the email views where we save the generated HTML email in test resources and require them to be "re-recorded" on a change.

There seems to be a problem with the build


Provide exception information for node to client mini-protocols

Over the past days, we have seen several reports (eg) of local transaction submissions causing disconnects without any information on the error that caused this disconnection, eg:
cardano-cli transaction submit --testnet-magic 42 --tx-file tx-foo.txsigned
MuxError MuxBearerClosed "<socket: 11> closed when reading data, waiting on next header True"

cardano-cli: MuxBearerClosed "<socket: 11> closed when reading data, waiting on next header True"%

It would be greatly beneficial not only for Consensus but for other teams and the Cardano users to get a more detailed error message so that:

People can understand why a failure occurred
IOG teams can debug the problem directly since these kinds of errors are difficult to reproduce.

Important things to consider

We don't want to blindly catch async exceptions since there will be threads that cannot be killed. See how exceptions are handled by the connection manager.
The exception that we catch and relay via the protocol should be also logged.
Addressing this issue will probably involve changing the encoding of some data types, eg ApplyTxErr. We need to guarantee backward compatibility.

Possible solution
To this end, we could catch an exception thrown by addLocalTx and relay this information using the mini-protocol (eg either using SubmitFail or adding a new type of message in the mini-protocol).
https://github.com/input-output-hk/ouroboros-consensus/blob/ee01711da7d6b5557d09d1c508d8233b34278188/ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/MiniProtocol/LocalTxSubmission/Server.hs#L33

Once https://github.com/input-output-hk/cardano-node/pull/5353 is merged, exceptions will be logged in the node. We assume people submitting transactions via the local protocol will have access to the node logs. Therefore there seems to be no justification at the moment for adding this feature.


Can't change tab in tabs in Angular code (not triggering)

I am trying to change tabs in my Angular code by reacting to a click event on an icon. However it doesn't work....
changeTab() {
    this.tabAction.emit({action: 'tabs', params: ['select_tab', 'test3']});
  }

From MaterializeCSS docs:
$(document).ready(function(){     $('ul.tabs').tabs('select_tab', 'tab_id');   });
What am I doing wrong or is this even possible?

See my pull request
https://github.com/InfomediaLtd/angular2-materialize/pull/411
With it, your action works. I was having the same problem.


Copy edits on the /// docXML for the FacebookAdapter-associated files.

[x] Copy edit files (except for outliers, see next bullet).
[ ] Double check the FacebookMessage.cs file with Gary.
[ ] Get a tech review from Gary before marking as ready.

Pull Request Test Coverage Report for Build 105783

0 of 0   changed or added relevant lines in 0 files are covered.
43 unchanged lines in 12 files lost coverage.
Overall coverage decreased (-0.6%) to 79.361%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/Converters/StringExpressionConverter.cs
1
70.0%

/libraries/AdaptiveExpressions/ExpressionFunctions.cs
1
93.25%

/libraries/AdaptiveExpressions/LRUCache.cs
1
82.93%

/libraries/AdaptiveExpressions/TriggerTrees/Trigger.cs
1
85.09%

/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs
1
86.46%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs
1
56.4%

/libraries/Microsoft.Bot.Builder/Inspection/InspectionMiddleware.cs
1
78.89%

/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs
2
75.0%

/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs
2
86.09%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookHelper.cs
6
72.22%

Totals

Change from base Build 105611:
-0.6%

Covered Lines:
10705

Relevant Lines:
13489

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3


feat: use fully qualified registry names

as title, use fully qualified registry names in service Dockerfiles.
fixes #503.

I think we might as well wait for @MiroslavRepka to finish his work, which will deprecate this PR - correct me if I'm wrong

I don't think this regards a registry we use, rather than a tool people will use to build an image. It is explained in the linked issue (#503).
It is nothing we have to worry about for now since we use docker build, however, if we switch to other tools like a podman the issue becomes relevant.

Sorry guys, I completely misunderstood this PR/issue.
I agree we can merge this.
I mistakenly thought this is about the image: field inside the Deployment manifest.
FYI @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf

no worries there :)) @MarioUhrik

I don't think this regards a registry we use, rather than a tool people will use to build an image. It is explained in the linked issue (#503).
It is nothing we have to worry about for now since we use docker build, however, if we switch to other tools like a podman the issue becomes relevant.
Afaik, we can merge this, it will not break anything, since the pipeline built images successfully.

correct, thanks, yes, this concerns the paths of the (base) images used inside the service/x Dockerfiles.

I agree we can proceed with this.

awesome :rocket:


Run special commands, like pdflatex

Hi !
First of all, I'm new to Atom. I'm trying to move from Vim.
Over the years with Vim, I set up a very smooth workflow. Especially for Latex. I use a particular command to compile my .tex files:
exe '!pdflatex -output-directory ./output/ '.e.'.tex; bibtex ./output/'.e.'.aux; pdflatex -output-directory ./output/ '.e.'.tex; pdflatex -output-directory ./output/ '.e.'.tex; mv ./output/'.e.'.pdf ./'

It basically run pdflatex several times, put the output files in a special directory, etc.
I don't exactly know how atom-script work, but I assume somewhere in the code, with a type file goes a command to run. ex:
.py -> python $the_file_name
Am I right ?
So, I wonder if I can add/modify the code to add my special command for Latex.

You could add LaTeX as a grammar (see https://github.com/rgbkrk/atom-script/blob/master/lib/grammars.coffee), but that'd just be weird. Seems more like you'd want this to be part of some build package.

Yeah I know, but I could keep the same shortcut than any other language to build my .tex file.
For example, to run a python script, I press F5.
To compile a tex file, I press F5.

Ok, I'm trying to implement Latex in the grammar. I started simply:
  Latex:
    "File Based":
      command: "touch"
      args: (context) -> [context.filepath]

But of course, when I try to use it on a tex file, I get the error:
Command not configured for LaTeX!

I think I have to assign this command to a Tex file type somewhere, don't I ?

The key for the grammar is case-sensitive. :) Use "LaTex" as the key for
that entry.
On Tue, Jun 9, 2015 at 10:55 AM, rififi<EMAIL_ADDRESS>wrote:

Ok, I'm trying to implement Latex in the grammar. I started simply:
Latex:
"File Based":
command: "touch"
args: (context) -> [context.filepath]
But of course, when I try to use it on a tex file, I get the error:
Command not configured for LaTeX!
I think I have to assign this command to a Tex file type somewhere, don't
I ?
—
Reply to this email directly or view it on GitHub
https://github.com/rgbkrk/atom-script/issues/460#issuecomment-110298511.

--
Sincerely, Erran Carey
Email<EMAIL_ADDRESS>Twitter: @errancarey
Website: http://erran.me

LaTeX has been added to the package, using "latexmk" command which should work for most people.


Add BOOTP and DHCP headers

Aim at fixing #60

Very impressive! I look forward to going through this more. 👍


Fix resource loader not resolving shallow loaded scripts through dependencies

When a script first gets shallow loaded through a dependency and and then requested by the resource loader, that script is already registered in ResourceCache and will therefore not be properly reloaded, which is necessary in order to resolve any Script inheritance. This can lead to errors when assigning objects with that script to a reference of its parent.
GDScript now overwrites set_path_cache which does not register it in the RessourceCache. set_path_cache replaces a call to set_path in get_shallow_script. get_full_script now calls set_path to register the script.

Fixes https://github.com/godotengine/godot/issues/95909

Thanks, and congratulations on your first contribution! 🎉


OpenAI API key

Is it possible to use the API key for authentication?
Thanks

Not really, since OpenAI hasn't launched an API for ChatGPT yet.


enh: channels

[x] user active status indicator
[ ] dm channels
[ ] threads
[ ] emoji reactions
[ ] '@' users/bots
[x] typing indicator

This is shaping up. 👍 I guess there is no way to interact with AI in channels until @ mention is implemented?
Will there be a way to control scope/context sent to the AI? Is it current message only, or entire chat history?


Search Projects

If a user wants to work on a project with a specific theme, say "a java repository to do with natural language processing", or "a C repository with a focus on neural networks", it'd be great to let them search against the project readme to help them find a project.

Hi @hughrawlinson,
Sounds like a good idea to me. I'd take advantage of that feature for sure.
Would you be interested in opening a PR to show how you think the feature would work?

Hi @wadtech, as far as I understand, for the queries given above we will have to search on project description which would become a heavy query with growing number of projects. I guess we should settle for search on project-name for now. What do you say?
Hi @hughrawlinson, if you don't mind, I would like to give this a try.

Hi @wadtech, only just saw this. Not sure I'll have time to do a PR anytime soon, pretty busy with work in the lead up to the holidays.
Hi @tejasbubane - go for it! I don't think a search on project-name would be sufficient I have to say. The whole reason I started this issue was because I was trying to search for audio-related projects to work on. A project-name search almost definitely wouldn't work for what I was trying to do, when projects have names like librosa, marsyas, chuck and meyda. Could it be worth at least seeing how long searching on project description would take? It's not like we'd have to search all of GitHub, just the projects on 24PullRequests. That said, perhaps wrapping a github search and filtering by 24PullRequest projects could work? Their search is pretty fast.

I think we can't use Github APIs. Because not all projects on Github are on 24pullrequests.
@andrew Any ideas? How many total projects do we have as of now? Would it be feasible to search across description with direct SQL? Or do we need a search engine like elastic-search?


Missing strings from app.po translation files

Itemized list of missing strings in DMPTool issue for Portuguese https://github.com/CDLUC3/dmptool/issues/144
Now I see that @briri created a related issue #1339 - feel free to close this one if unnecessary

strings within strings (radio buttons, checkboxes)

ok closing this one in favor of #1339


i18n: DSR update Japanese & Korean

고쳐서 PR하시는 거는 이견이 없습니다.
다만,  그런 이유로 고치려면,  tts 태그를 쓰는게 좋을것 같습니다.

이 케이스의 경우 일본어 haruka는 그다지 문제가 없는데, 한국어 heami는 '='를 읽습니다. 이런 문제도 있어요.

https://github.com/quisquous/cactbot/blob/0df2bb29a48b4985b81aac9dab3d577b0a70674f/ui/raidboss/popup-text.ts#L1363
말씀하신 =>는 그리고로 대체됩니다

https://github.com/quisquous/cactbot/blob/0df2bb29a48b4985b81aac9dab3d577b0a70674f/ui/raidboss/popup-text.ts#L1363
말씀하신 =>는 그리고로 대체됩니다

https://github.com/quisquous/cactbot/blob/0df2bb29a48b4985b81aac9dab3d577b0a70674f/ui/raidboss/popup-text.ts#L1361
Looks like japanese translate '=>' as 'や' which is not consistent, either.
Suggest to change to 'そして'

그리고 제가 쓴 번역 tts유저와 문자 유저 둘다 쓰기 좋았다고 생각하는데요.. 뭐가 부족해서 왜바꾸셨는지 그리고 왜 tts태그를 써야하는지 설명 부탁드려도될까요?

I agree to add an extra tts entry for this. I like the symbols on the screen that is easily recognized. But on the other hand, some TTS engines just ignore these symbols, which would cause problems when someone didn't use system TTS.

Well, I don't think symbols is more easily recognize and readable, but it's very subjective topic, let's talk about other one.
At first, to support this symbol, we have to fix korean font issue, TTS doesn't work issue.
And  only ja,ko, cn(maybe?) use symbol text is not sounds good for consistent, if other en, de, fr texts use symbol too, they have to fix font issue : ○△■ goes small in Arial font.
I think it's better way for revert this and use old localization (means literally "red circle token" etc, normally recognize, TTS can read), if someone want to use symbol, they can change easily using cactbot user config tab.

Well, respect you but I don't think symbols is more easily recognize and readable, but it's very subjective topic,

Yeah, you're right. That's very subjective.

I think it's better way for revert this and use old localization (means literally "red circle token" etc, normally recognize, TTS can read), if someone want to use symbol, they can change easily using cactbot user config tab.

Yeah, that's a way, too.
But when user change the literal text to symbols in the cactbot config page, while accidently his TTS didn't recognize those symbols, then TTS still would not work in this case.

So far here are 3 issues:

[ ] change the replacement text in ja/ko of the arrow symbol (=>).
https://github.com/quisquous/cactbot/blob/0df2bb29a48b4985b81aac9dab3d577b0a70674f/ui/raidboss/popup-text.ts#L1361-L1362
[ ] add a korean font.
[ ] fix the ○△■X symbols, either revert to literal text or add a tts entry.


Add How Workers Works

@adamschwartz added how workers works section. one small thing — not sure if you have thoughts on it, but the background behind the image seems to blur somewhat awkwardly:

The image thing is an existing issue.
It’s a problem here e.g.
https://workers.cloudflaredocs.workers.dev/tutorials/deploy-a-react-app-with-create-react-app
I created an issue to track that:
https://github.com/cloudflare/workers-docs-engine/issues/95
If you’re happy with the content other than that issue, please feel free to merge.
The only thing that’s confusing to me is why it seems you added an import to the NetworkMap on the Cache page (separate from the How Workers workers page). Maybe that one line should be removed. Otherwise LGTM!

Thanks for creating that issue! I removed that cache network map thing, not sure what happened there. Going to merge.


Supporting pasting from Word

covers #664

That looks like the easiest job of handling pasting from Word I've ever seen.


Add stats schema fields to classroom and user

Quite unfamiliar with how to test, and what exactly the issue is as I couldn't repro locally. Only via the proxy.
If these are fields that need to be added in order to pass the schema validation then it looks good.

@jmif can you link the commit that introduced this problem?  Thanks!


Reveal.modal issue

Hi, I'm using reveal.modal in 6.0.0, and find that I can't trigger the modal when I include the 'foundation.min.js', but when I use 'foundation.js' and remove all the " 'use strict;' " code lines, it works.
Just want to notify this bug.

Update to 6.0.1
We had an issue with the mangle feature on minify. It was resolved and pushed to master yesterday.


Is it possible to set nested fields to index in meilisearch?

I have documents in firestore like that
{
    "id": "uuid",
    "company": {
        "name": {
            "legal": "Acme Company Inc.",
            "trade": "Acme"
        },
        "document": {
            "id": "0000000",
            "type": "CNPJ"
        },
        "logo": "https://example.com/logo.png"
    },
   "status": "ACTIVE"
}

I do not what index all subfields of company field.
I what store in meilisearh data like this:
{
    "id": firestore_doc.id,
    "legal_name": firestore_snapshot_doc.get('company.name.legal'),
    "trade_name": firestore_snapshot_doc.get('company.name.trade'),
    "logo": firestore_snapshot_doc.get('company.logo'),,
    "status": firestore_snapshot_doc.get('status'),
}

Unfortunately, this is not possible currently, and I'm not sure this can be achieved with the plugin given that it is used through a dashboard.

In face of this case, I decided to create a Firestore Cloud Function according my needs. Thanks fot the support.


Create ....

👍🏼

Hi,
Can you please explain me what your PR does?
On Sun, May 2, 2021, 18:26 nitsuaaisblink @.***> wrote:

👍🏼
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yonathan95/BinanceTradingBot/pull/9#issuecomment-830826596,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP4P5TYR7AOHLKVBBFFDBZLTLVVMFANCNFSM437EUOGA
.

Yay


local-481 broken?

I have a docker-compose.yml that works with powerpanel-business:local-470.  However powerpanel-business:local-481 will not load with the same docker-compose.yml
HTTP Status 404 – Not Found
Type Status Report
Message /local/login
Description The origin server did not find a current representation for the target resource or is not willing to disclose that one exists.

version: '3'

services:
  powerpanel:
    image: ghcr.io/nathanvaughn/powerpanel-business:local-481
    hostname: powerpanel
    container_name: powerpanel
    environment:
      PUID: 1000
      PGID: 1000
    ports:
      - 2003:2003 # Powerpanel Watchdog Service
      - 3052:3052 # http
      - 53566:53566/udp # unknown
    devices:
      - "/dev/usb:/dev/usb"
    privileged: true
    restart: unless-stopped
    volumes:
      - app_data:/usr/local/ppbe/db_local/
      - /etc/localtime:/etc/localtime:ro
      - /etc/timezone:/etc/timezone:ro
volumes:
  app_data:
    driver: local

I'm a little preoccupied currently, in the process of buying and moving
into a house across the country, but I will say I have seen this before,
and have exactly 0 clue why it's happening or how to fix it. It's on my
personal backlog to try and figure this out, but if anyone figures out
something, please leave it on this issue.
On Wed, Aug 10, 2022, 01:59 fahrenhe1t @.***> wrote:

I have a docker-compose.yml that works with powerpanel-business:local-470.
However powerpanel-business:local-481 will not load with the same
docker-compose.yml
HTTP Status 404 – Not Found
Type Status Report
Message /local/login
Description The origin server did not find a current representation for the target resource or is not willing to disclose that one exists.
version: '3'
services:
powerpanel:
image: ghcr.io/nathanvaughn/powerpanel-business:local-481

hostname: powerpanel

container_name: powerpanel

environment:

  PUID: 1000

  PGID: 1000

  TZ: America/Denver

ports:

  - 2003:2003 # Powerpanel Watchdog Service

  - 3052:3052 # http

  - 53566:53566/udp # unknown

devices:

  - "/dev/usb:/dev/usb"

#privileged: true

restart: unless-stopped

volumes:

  - app_data:/usr/local/ppbe/db_local/

  - /etc/localtime:/etc/localtime:ro

  - /etc/timezone:/etc/timezone:ro

volumes:
app_data:
driver: local

—
Reply to this email directly, view it on GitHub
https://github.com/NathanVaughn/powerpanel-business-docker/issues/14,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACB4QK4CJ4F3P43D7QCY7RLVYNHMVANCNFSM56DK3IRA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I thought the issue might have to do with my volume app_data:/usr/local/ppbe/db_local/, so I changed it to app_data:/usr/local/PPB/.  However it's still broken no matter what path I use.  Good luck on the move 🙏


Latest version of react-onclickoutside breaks date picker

Looks like react-onclickoutside released over the weekend 5.11.0 and 5.11.1. After these releases this error occurs in react-datepicker...
react-datepicker/~/react-onclickoutside/~/create-react-class/factory.js
Module not found: Error: Cannot resolve module 'object-assign'

Not sure if date picker is misusing an internal portion of react-onclickoutside or if react-onclickoutside has a critical bug or should have revved the major version with this release. But perhaps you should consider reverting to 5.10.0 as a quick fix?
To anyone blocked by this issue, you can workaround it by adding  this to your project's package.json:
"react-onclickoutside": "5.10.0",

Can you try doing a fresh npm install?  The latest release of react-onclickoutside brings in additional transitive dependencies that are probably missing.

@rafeememon, thanks for the quick reply, but this broke my build, which does a clean npm install every time. FYI, I'm using Webpack 1.x and npm 2.x

Frustratingly, it looks like create-react-class has an implicit dependency on npm >= 3.  It brings in fbjs which itself brings in object-assign.  This is fine for npm >= 3 when dependencies were changed to be installed in a flat structure, but will cause issues for older versions.  However, since npm 2.x is two major versions old, I highly recommend upgrading =)
cc @Pomax

thanks again, that info is much appreciated. Upgrading npm is on our to-do list, so I guess it just got a bump up the priority list. This is the first time we have encountered a module that has broken compatibility with npm 2.

commenting due to the cc: npm2 only comes with a version of node that was known to go out of LTS this month for the last 18 months, so if you're still using it, it's really time to put "make our code run on the latest LTS" a priority. The current LTS version of Node (6.x), which comes bundled with npm3, and has already been the active LTS for the last six months.


Add IPC property consistency test

I am not quite sure what is the purpose of this test. Moreover the behavior seems to be wrong - when we receive boolProperty1Changed, we expect only this one to be changed. When we receive boolProperty2Changed, we expect it to change. We do not expect cross-changes. From the server POV it is the same property, but from the client POV these are completely separate things. If you need to make it consistent in the proposed way, you should pack it into a structure.

The properties are guaranteed to be equal on the server side and the purpose of the IPC framework is to replicate the interface on the client side, so they have to be equal there as well. We do not want group multiple properties into one for the reasons which I already explained.
FYI, the test passes.

The properties are guaranteed to be equal on the server side and the purpose of the IPC framework is to replicate the interface on the client side, so they have to be equal there as well. We do not want group multiple properties into one for the reasons which I already explained.

This makes no sense. Properties are the same for the server, they should be replicated ASAP to the client. That part is OK. However the assumption that they are the same on the client side is wrong, client does not have this knowledge. Also we do not replicate the interface but its state.
What you have described is the problem with state of the interface that I mentioned in my other comments. If the state of the interface changes, then you have to update all properties, so the only correct way is to send whole state at once, even if properties are not changed. This is not an efficient way. Moving the state towards application rather than interface, and decoupling properties solves this problem.


Roll forward on console tools

This allows the nswag tool to roll forward on to higher major versions, making it usable out of the box for 3.0 preview builds.

So with this the binary will always run on the latest installed version? Will this be enough as the used asp.net core version will still be v2.1 or v2.2?

So with this the binary will always run on the latest installed version?

Kind of. More specifically it will roll forward onto the next higher version. So if you're requesting 2.1.0 and available frameworks are ["2.2.2", "2.2.4", "3.0.0-preview4"] it will select "2.2.4", but if you only have ["3.0.0-preview4", "3.0.0-preview6"] it will select "3.0.0-preview6". The docs defining this behavior are here.
For your second question I'm not entirely sure I follow, but if you're asking if this change will allow a netcoreapp2.1 project to run if only 3.0.0-previewX is installed the answer is yes, I tested it locally.

For your second question I'm not entirely sure I follow, but if you're asking if this change will allow a netcoreapp2.1 project to run if only 3.0.0-previewX is installed the answer is yes, I tested it locally.

The .net core 2.1 binaries are compiled against the latest ASP.NET Core 2.1 version... if the runtime is changed to eg .net core 3.0 it will still run against ASP.NET Core 2.1...
Hope this does not break users, this whole assembly loading stuff is extremely brittle with all the possible version combinations, frameworks, runtimes, etc...
We could just add a .NET Core 3.0 binary - the only reason why it's not added yet is because it is in preview and it would mean that people who clone the repo also need this preview to build the solution...

Good points! @dougbu is taking a stab cross-compiling this tool for netcoreapp3.0 since he's already making other changes, so I'll close this out.

Works fine 😺 for code generation scenarios ❕
For example, in a 3.0-only environment and using a 3.0 solution:
  GenerateNSwagCSharp:
    dotnet --roll-forward-on-no-candidate-fx 2 ...\.nuget\packages\nswag.msbuild\12.5.10\build\../tools/NetCore21//dotnet-nswag.dll swagger2csclient /className:WebApplication3_0_FredClient /namespace:ConsoleClient /input:...\WebApplication3.0\WebApplication3.0\obj\WebApplication3.0_Fred.json /output:obj\WebApplication3.0_FredClient.cs
  NSwag command line tool for .NET Core NetCore21, toolchain v<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))
  Visit http://NSwag.org for more information.
  NSwag bin directory: ...\.nuget\packages\nswag.msbuild\12.5.10\tools\NetCore21
  Code has been successfully generated but not written to file (no change detected).

  Duration: 00:00:01.1127311

@RicoSuter 🆗 w/ you if I include this command addition in a small update to the Microsoft.ApiDescription.Client project?
(I doubt commands that need an inside man and / or load versions of ASP.NET Core packages will work as well.)

@dougbu how would you do that? Wasn't this PR exactly that? Isn't there a way to only roll forward if the requested runtime is not available?

I'll add the --roll-forward-on-no-candidate-fx 2 argument to the command executed in NSwag.ApiDescription.Client.targets. This won't make your command line work everywhere but will help in that specific scenario.

@dougbu fine for me if this is enough.. also this cannot break existing users and will work until we directly support core 3 as target framework directly


Web - Emoji - The square is showing white when typing black_medium_small_square instead of black on Incognito window

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/17624
Action Performed:

Access staging.new.expensify.com
Go to any chat
Type :black_medium_small_square into the composer
Verify you see the emoji suggested, and that it is black

Expected Result:
The square shows in black color
Actual Result:
The square is showing white when typing black_medium_small_square instead of black on Incognito window
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/233796737-aab13d6c-dc48-456e-b696-e988732ad50a.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

We have different results for link PR above.
Some tester has black square in a white frame


How to configure appInsights log level in tomcat linux app service ?

When creating a tomcat linux app service, it is possible to activate appInsights. The appInsights java agent will then be used to forward logs to appInsights. By default, this agent send only logs with WARN level (according to https://docs.microsoft.com/en-us/azure/azure-monitor/app/java-trace-logs#using-the-application-insights-java-agent).
With the tomcat app service, the agent is automatically managed. Where should I put the AI-Agent.xml file to change the log level ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df68e904-7b05-38ba-4203-50eb8491946f
Version Independent ID: 921377f7-e428-143d-70e4-c9efc25e41d1
Content: Configure Windows Java apps - Azure App Service
Content Source: articles/app-service/configure-language-java.md
Service: app-service
GitHub Login: @JasonFreeberg
Microsoft Alias: jafreebe

@RyanHill-MSFT it's been 20 days since my answer saying that it's still not working. This is a major issue preventing our application to move to production.

Apologies for not seeing your mentions from before @jbinard. I will investigate and get back to you.

@jbinard, what project type are you using?

This is a maven project but we haven't added the application insights SDK to it. The logs are managed by logback and we have only a file appender. This is the appInsights java agent already installed in the linux java app service which automatically retrieve the logback logs and transfert them to appInsights.

Hi @RyanHill-MSFT
I have the same problem and I whould like to know if you have any news or suggestions to solve this problem?
Best regards

Hello,
any news about this issue ?


Tokio executor is assumed to be present for Conn cleanup

The crate should not expect a tokio executor to be present.
Perhaps the Pool can contain an (optional) reference to an Executor, similar to how Hyper does it. This gives users the freedom to provide their own executor, or use the default one.
As far as I could see, this is the only place where a future is spawned. Without an executor present, the cleanup is never run.

@blackbeam Do you need any help with this? If I have some spare time I could try to create a PR.

Hi!

Do you need any help with this?

Actually yeah, because i don't have much spare time atm. However the solution is unclear to me.
Consider this test:
https://github.com/blackbeam/mysql_async/blob/bfea5267834b6bf4f6b72da48b0d422b37da2a7e/src/conn/pool/mod.rs#L536-L544
Pool here will outlive the runtime created on line 539. I believe this means that any async cleanup code
won't run, and it actually does not matter if this code works via tokio::spawn or via some in-pool queue.
Now consider the following test:
#[test]
fn disconnect_on_another_runtime() {
    let fut = Conn::new(get_opts());
    let conn = run(fut).unwrap(); // <- first runtime
    run(conn.disconnect()).unwrap(); // <- second runtime
}

Here the connection is created using the first runtime and then disconnected using the second runtime. But this test will panic with reactor gone because reactor handle is weak.
This means, i think, that asynchronous cleanup just can't be executed if Conn outlives the runtime it was created on and i don't see a sane way to enforce Conn to not to outlive it.
Approach that i tried is to unwrap raw handle from tokio TcpStream and perform synchronous cleanup, but it turns out that IntoRawFd is not implemented for tokio TcpStream (because of this, i think).
I might, however, be wrong.
Do you have any thoughts about all this?

I think if the runtime is dropped before the Conn this is the fault of the user for not cleaning up their futures correctly.
I think you misunderstood my issue slightly; I'm using your lib without a tokio runtime, I use my own. However, the cleanup code is hardcoded to use the last used tokio runtime. If this is not present, it will silently fail.
My proposal is to allow a custom Executor impl to be passed (into Pool perhaps), which will then be used instead of the standard tokio one. If nothing is passed, using tokio is fine with me.
Do you agree on this? Is Pool the correct place to add this? (Didn't read into it that much yet)

I think you misunderstood my issue slightly; I'm using your lib without a tokio runtime, I use my own. However, the cleanup code is hardcoded to use the last used tokio runtime. If this is not present, it will silently fail.

Oh. This clears thing a bit. Thanks.

My proposal is to allow a custom Executor impl to be passed (into Pool perhaps), which will then be used instead of the standard tokio one. If nothing is passed, using tokio is fine with me.

Yesterday i've hoped for a blitzkrieg while adding Box<dyn Executor> into the Conn, but i've stalled deciding about Send and Sync bounds, TypedExecutor and possible implications on flexibility. I'll investigate more.

Great! It may be helpful to look at hyper, since they have implemented a similar mechanism (with_executor).

Any progress on this issue?


ingest oral histories: audio/video with captions

audio/video objects with captions need to be ingested into kaltura and captions or transcripts need to be displayed

our alternative is to index the kaltura entry id and use that to display captions. storing captions might be an option down the line, to index transcripts in elasticsearch or find an alternative storage/separate storage.


add github action to lock closed issues

For #4046

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #5770 (c28bec1) into main (b368168) will decrease coverage by 0%.
The diff coverage is n/a.

:exclamation: Current head c28bec1 differs from pull request most recent head 463e551. Consider uploading reports for the commit 463e551 to get more accurate results

@@          Coverage Diff          @@
##            main   #5770   +/-   ##
=====================================
- Coverage     65%     65%   -1%
=====================================
  Files        352     352
  Lines      24148   24148
  Branches    3637    3637
=====================================
- Hits       15823   15816    -7
- Misses      6937    6943    +6
- Partials    1388    1389    +1

Impacted Files
Coverage Δ

...rc/client/datascience/jupyter/debuggerVariables.ts
75% <0%> (-4%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
74% <0%> (-1%)
:arrow_down:

...active-common/intellisense/intellisenseProvider.ts
74% <0%> (-1%)
:arrow_down:

...client/datascience/kernel-launcher/kernelDaemon.ts
54% <0%> (+1%)
:arrow_up:


[Question] How to load wizard type form to a specific page

I have a form created using angular-formio package which is in wizard type mode with multiple pages. When forms loads, I am populating some data to it which all is working fine.
Now I need to set the page number so when wizard form loads, it is automatically displaying the current page as whatever I want to display, instead of always starting with first page of the wizard.
Any idea how can this be done?

@travist
Thank you. I will try this.

@travist
I tried this solution but there is no setPage() function available in either FormioComponent or FormioBaseComponent. Am I missing something?

You can reference the "root" from any component to get access to the wizard object. So it could be the following.
instance.root.setPage(2);


Getting Substituion(s)

There should be a way to get a list of all substitutions and also to get them individually.  This will enable doing substitutions while dynamically adding matches to the system without having to deparse the entire script.


Feature/update deployment logic using factory

[x] Update zkey and wasm
[x] Integration testing using foundry
[x] Integration testing using foundry zksync
[x] Update docs for integration testing using foundry zksync

@SoraSuegami I agree with your opinion. In that case do we add test cases and deployment scripts for  EmailAccountRecoveryZksync? (and RecoveryControllerZksync too)


Updated README and added other files

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   37.38%   37.38%
=======================================
  Files           8        8
  Lines         436      436
=======================================
  Hits          163      163
  Misses        263      263
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f3624...39618f8. Read the comment docs.


Delay PropertySource lookup for VaultPropertySourceRegistrar

VaultPropertySourceRegistrar performs an early bean lookup via beanFactory.getBeansOfType(…) to obtain property sources. While this lookup allows for early initialization of components, it triggers in case of Spring Boot the initialization of VaultAutoConfiguration too early which fails with constructor resolution.
We can delay the initialization but that comes at the cost of vault property sources being activated after running the bean postprocessor.
This issue was originally reported via https://github.com/spring-cloud/spring-cloud-vault/issues/642

Delaying the initialization causes the annotation to miss the point to contribute configuration data early on during bean configuration. We recommend using @VaultPropertySource in combination with AbstractVaultConfiguration to provide the required infrastructure separately from potential auto-configuration.


[ARCTIC-1152]Fix the smooth cancellation issue of Optimizer jobs during runtime in Flink environment

Why are the changes needed?
When the Optimizer job under Flink environment is canceled during runtime, it cannot exit smoothly.
Use variables to optimize the while loop logic in the run method of the FlinkConsumer class in the arctic-optimizer module. When the user cancels the job, control the loop variable to be false to allow the while loop to exit in a timely manner.
Brief change log

Modified the FlinkConsumer class in the optimizer module, adding a loop variable in the run method.

How was this patch tested?

Local testing has been conducted.

fix #1152

@iTodoo Thanks a lot for your contribution!
And very welcome to join our community!
You can find the guides of our community from here: https://docs.google.com/document/d/1Pwv1LflW3z5yq34qDpEYwSxOB3LIE5qoKQ_5Sv0IV1Y/edit?usp=sharing

I recommend you add the comment Resolve #1152  into your PR's description to help GitHub link your PR to the issue so that the issue will be closed automatically after you completed the PR.


[BNS] Incorrect optional argument encoding.

Describe the bug
The functions buildTransferNameTx and buildRenewNameTx incorrectly encode some of the contract call arguments. Optional arguments are either included or omitted (as can be seen here), which results in the created transactions being rejected (either not enough arguments, or a TypeError is thrown because the optional arguments are of the wrong type).
What version of Blockstack.js are you using?
2.0.0-beta.0
To Reproduce
Build a transaction by calling one of the aforementioned buildTransferNameTx or buildRenewNameTx functions (with or without passing the optional arguments), and broadcast the resulting transaction. This will result in an error.
Additional context
While debugging the issue, I've updated the relevant functions to encode the arguments correctly. The required changes can be seen in this commit. I have tested the fixes locally against a mocknet instance, and they seem to address the problem. I have not updated the tests.

I have started working on this issue. Assigning it to myself.


didShowPhotoAtIndex delegate

Nice project. Thank you! The didShowPhotoAtIndex delegate is marked as a required. I think it should be marked as optional.

hi @rockade, thanks your issue. yeah I will fix it

@rockade tag 1.4.2 or latest master is fixed this issue.

Thank you!


[BEAM-13391] Fix temporary file format in WriteToBigQuery

Fixing the issue where for Avro format load, WriteToBigQuery throws an exception: The Apache Avro library failed to parse the header with the following error: EOF reached.
This happens because AVRO format exects non-zero input. This cannot be possible because UpdateDestinationSchema desinged to update a schema with a zero copy-payload.
Current PR:

Fixes a format for copy job in UpdateDestinationSchema to be a JSON. JSON is choosen because it allows a zero-rows payload and nested schema
Add an integereation tests

Testing
Integration tests:
pytest --log-cli-level=INFO --test-pipeline-options='--region=us-central1 --experiment=use_beam_bq_sink --runner=TestDirectRunner --project=... --gcs_location gs://... --temp_location gs://...' -v apache_beam/io/gcp/bigquery_write_it_test.py

cc: @pabloem

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run PythonDocker PreCommit

Are you able to root cause why zero-row writes using Avro format fail?

Not really, the issue happens on BQ side. When the job get submitted to BQ, BQ returns this error. As issue happens on BQ propriety code path and not a Beam side, it's pretty hard to deduce the proper root cause here

Does it only fail for schema update only or for WriteToBigQuery with no rows in general?

Not an expert with WTBQ but the issue happens when load format is AVRO with empty byte stream. Empty byte stream works fine with JSON format.
I've tried to play in the past with beam BQ submission API, in case there're empty rows, beam API throrws exception saying that the argument shoud be non-empty one.

What is the next step on this PR?

@satybald @chunyang - Is this ready for a review by a Beam committer? It looks like there is some open comments and the change needs to be rebased.
R: @pabloem could help with the review once it is ready.

hi folks! sorrrry about the delay on this. Chuck's review seems to have brought the code up to great quality. this LGTM.

I tried to resolve merge conflicts. If all goes well, I'll merge.

Run Python 3.8 PostCommit

failure is unrelated. merging.