NgBootstrap is not working in angular-cli v 1.4.6 with ng 4

During debugging the this.anchors is always coming as empty Object in next step function.

That would happen if the tourAnchor directives haven't been rendered on the screen yet, or if they are registering themselves with a different TourService for some reason.
Try this and see if the tourAnchors are being registered:
this.tourService.anchorRegister$.subscribe(x => console.log(x));

Events are not registered, with the above service nothing is printing in a console. Service initialization is hapennning , which was there in the screenshot-1 . What may be the reason that registering is not happening?

Have you included tourAnchor="start" in some component that is rendered on the page?
Are you importing NgxTourNgBootstrap.forRoot() in more than one module?


Ceph-ansible with docker-ce

When installing ceph using ceph-ansible it conflicts with OpenStack kolla-ansible because kolla-ansible uses docker-ce while ceph-ansible use podman.
I used this command to pass docker-ce to ceph-ansible:
ansible-playbook -i hosts site.yml -e container_package_name=docker-ce
Bug Report
What happened:
How to locate OpenStack controller and Ceph monitor and manager in the same nodes?
What you expected to happen:
Ceph-ansible uses podman to start containers for grafana which is conflicts with docker-ce required by kolla-ansible.
How to reproduce it (minimal and precise):

This issue can be reproduced by colocating the ceph monitor, manager, and grafana-server with openstack controller nodes.
Share your group_vars files, inventory and full ceph-ansibe log
CentOS 8
4.18.0-240.10.1.el8_3.x86_64
Environment:

OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Docker version if applicable (e.g. docker version):
Ansible version (e.g. ansible-playbook --version):
ceph-ansible version (e.g. git head or tag or stable branch):
Ceph version (e.g. ceph -v):

@yemenlinux could you share a full ceph-ansible from the command you tried to run ? (ansible-playbook -i hosts site.yml -e container_package_name=docker-ce)

I think you will need to override the container_binary to docker too otherwise the default value for CentOS 8 will be set to podman
$ ansible-playbook -i hosts site.yml -e container_package_name=docker-ce -e container_binary=docker


Marantz human for prompt

don't prompt for task execution if no person can answer,
this was tested in the testenv and I'll test it live once I hear comments.
@Primer42 @byxorna @defect @maddalab

LGTM :dizzy: :curly_loop: :fire:


Have a way to enable rust-bitcoin's base64 feature

It would be handy to have Psbt::from_str().

Sure, I think we can add a feature here in a point release.
In future we'll pull base64 into rust-bitcoin so that it won't need a feature-flag but that'll be a while.


Don't use an enum for TopLevelDomain.

Why?
Currently there is no way to build a validator that only matches, say, emails with the .dev TLD. Given the huge list of TLDs that are available it probably makes sense to let users write in a custom TLD and not lose that information.
In this context, an enum isn't good enough since there is no way to attach a variable string to the OTHER case.
Open questions

Now that fromString can accept any string, should we be doing validation on the TLDs? There seem to be rules about what can be a valid TLD that could be asserted at the time of creation.
What to do in the case that a tld is created like TopLevelDomain.fromString("test") that is potentially invalid but still well formed.
Should the result of fromString be guaranteed to == another call to fromString? In this implementation TopLevelDomain.fromString("com") will equal TopLevelDomain.DOT_COM with .equals, but not with ==. Its likely okay to make that be true now, but if you wanted to add all the known TLDs as constants doing the lookup could be a performance hit.

''
-

''
0

I'm going to merge this and we can work on validation of TopLevelDomain creation in another change.

@bowbahdoe I added some validation of TLDs in 40853c7, please let me know what you think!

Now that there is validation around fromString it feels more weird to have the empty string and null be valid values there. Maybe just having the NONE constant is enough and we can have those cases throw validation errors?
I can also easily swing the other way since you can imagine a workflow where someone is parsing user supplied data to get a string to make into a TLD and having empty be valid might be okay.

Good point @bowbahdoe. I agree that it feels weird to allow those but not other invalid values. I think it makes sense to just have the NONE constant. Then anyone who has a workflow parsing user-supplied data for TLD would have to guard against null/empty themselves in case they want to treat it as NONE.


Please tag and version this project

Tags and versions aid in packaging for things like .deb files, and for anyone wanting to use Glide and other version based package managers to version their dependencies. It would also help ensure that if you make a breaking change, we don't pull it down until we are ready.

Thanks for the reminder. I totally agree with the tagging, but I forgot to add it.


File Doesn't Exist

Hi Will I trying running but result still "Opppss File does not Exist.."

same for me. It simply don't work.

it might be because of spaces in your path.
You should put the path in quotation like "path/to file"

you have to put path without name of file
name of file : filetocrack
path C:\users\

To solve this, you should put a backward slash at the end for example
C:\users\              -correct
Leaving out the slash leads to the problem.
C:\users               -incorrect-


Shell behaviour

This is more of a question than an issue.
I see the output of SHELL environment variable is bash
echo $SHELL
/usr/local/bin/bash

and yet I don't think .bashrc is read. Also cannot execute the following commands
source .bashrc
Cannot read property 'length' of undefined

. .bashrc
Upterm: command "." not found.

Apologies if this has been already answered or is not even the goal of this project.

Duplicate of #1215?


DP0.2 Tutorial 02. Explore a SN1a Lightcurve

Hello! I just worked through the second tutorial about SN1a lightcurves (https://dp0-2.lsst.io/tutorials-examples/portal-intermediate.html), and noticed that while this is supposed to be plotting the i band lightcurve, the suggested y label in section 3. says it is the "apparent magnitude (r)".
Also, I know that a previous section went over what the psABMag is, but in the section 2 query, it might be helpful to reiterate that.
thank you!!

Thank you @kcdage, the Community Engagement Team will address this issue and report back when it is done.
For Rubin staff: https://jira.lsstcorp.org/browse/PREOPS-1297

Sharp eyes, Kristen! - thanks for noting it.  We fixed it, and merged the updated version into main.  Please feel free to let us know if you see anything else that needs fixing!  --Greg

I think this is now fixed and can be closed.  --Greg


Bulk inserts across tables and control of transactions

Hey guys,
I've used your library in personal apps, and I'm trying to make a push for it at my 9-to-5.  I have a few questions on a use-case that we have here, and I'm unsure if Storio can cover it.
Essentially we have a LARGE json payload that gets synced at initial login (we're talking a potential of 50k+ objects).  Because of this, we will be streaming the objects through a JSON parser, so that we don't load these gigantic JSON arrays into memory at once.
Basically, I want a way so that, when I begin parsing, I can open a transaction through StorIO, and then perform a large number of puts (every element within the array) and then close the transaction.
The issue is exists because I do not want to keep a Collection around, and add elements to it, thus the PreparedCollection functionality in Storio doesn't fit exactly.

In StorIO v1 it's possible with executeAsBlocking()!
storIOSQLite.internal(). beginTransaction();

try {
  // Feel free to do Put, Get, Delete via executeAsBlocking()
  storIOSQLite.internal().setTransactionSuccessful();
} finally {
  storIOSQLite.internal().endTransaction();
}

And of course StorIO will not send any notifications about changes in the db until transaction is not closed!
In StorIO v2 we will make it possible with Rx too.
(StorIO v1 sets subscribeOn() for rx.Observable, so it's not possible to work with db from other threads)

I should have investigated the internal APIs a bit more before I posted an issue.  Thank you for the quick response!
That should definitely work for us, as we're not going to be leveraging the RX functionality yet

@cody1024d JFYI internal is misleading name, it's actually lowlevel (we'll rename it in v2), so don't worry about using API with such name (it's documented and part of public api), just read javadoc carefully and you're good to go!

Thanks @artem-zinnatullin.  Out of curiosity, I should be able to start and end a transaction through the native SQLiteOpenHelper, instead of routing it through StorIO, correct?

You can do it, but StorIO won't know about such transaction, though
SQLiteDatabase won't allow us break its state anyway :)
If you're ok with doing it via StorIO API I strongly recommend to do it via
StorIO, especially because of upcoming features like Interceptors API!
On Fri, Oct 30, 2015, 22:10 Cody Duncan<EMAIL_ADDRESS>wrote:

Thanks @artem-zinnatullin https://github.com/artem-zinnatullin. Out of
curiosity, I should be able to start and end a transaction through the
native SQLiteOpenHelper, instead of routing it through StorIO, correct?
—
Reply to this email directly or view it on GitHub
https://github.com/pushtorefresh/storio/issues/547#issuecomment-152620653
.

--
@artem_zin

Makes sense.  I'll have to adjust my architecture accordingly.  Thanks again!

Hey,
Jumping here cause there's something I can't get.
I tried the following with .useTransaction(false) and .useTransaction(true) :
`
storIOSQLite.lowLevel().beginTransaction();
Log.i("TAG", "start transaction ");

List<User> users = new ArrayList<>();
for (int i = 0; i < 100; i++) {
  User user = new User(i, "yo");
  users.add(user);
}

storIOSQLite
    .put()
    .objects(users)
    .withPutResolver(new UserStorIOSQLitePutResolver())
    .useTransaction(false)
    .prepare()
    .executeAsBlocking();

Log.i("TAG", "transaction end");

storIOSQLite.lowLevel().setTransactionSuccessful();
storIOSQLite.lowLevel().endTransaction();

`
UserStorIOSQLitePutResolver, doesn't override any methods or do something like insertion into another table.
But every insertion is made with a single transaction.
Logcat shows :
I/TAG: start transaction  D/SQLiteDatabase: beginTransaction() D/SQLiteDatabase: beginTransaction() D/SQLiteDatabase: endTransaction() D/SQLiteDatabase: beginTransaction() D/SQLiteDatabase: endTransaction() D/SQLiteDatabase: beginTransaction() D/SQLiteDatabase: endTransaction() D/SQLiteDatabase: beginTransaction() D/SQLiteDatabase: endTransaction() D/SQLiteDatabase: beginTransaction() ...  ... ... D/SQLiteDatabase: endTransaction() D/SQLiteDatabase: endTransaction() I/TAG: transaction end

OK sorry found it, it's because UserStorIOSQLitePutResolver extends from DefaultPutResolver which overrides performPut to do transactional statement.


[Suggestion] Engineer Skill

A skill for things such as railways, hoppers, dispensers, redstone etc.
Probably mostly be good for modded items.

I dont think i can think of enough abilities for this to make it worth it.


feat(git-hook): Install errcheck dep when the setup is made (AEROGEAR-8519)

Motivation
https://issues.jboss.org/browse/AEROGEAR-8519
What
make setup_githooks   install the
go get -u github.com/kisielk/errcheck

Why
in order to avoid the issue
.git/hooks/pre-commit: line 12: errcheck: command not found

How
Adding step in the Makefile
Verification Steps
Run $ make setup_githooks and check that the pkg was installed
$ make setup_githooks
Installing errcheck dependence:
go get -u github.com/kisielk/errcheck
Setting up Git hooks:
ln -sf $PWD/.githooks/* $PWD/.git/hooks/

Run $ make setup and check that the pkg was installed
 $ make setup
Installing errcheck dependence:
go get -u github.com/kisielk/errcheck
Setting up Git hooks:
ln -sf $PWD/.githooks/* $PWD/.git/hooks/
Installing application dependencies:
dep ensure

Checklist:

[X] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Progress

[x] Finished task
[ ] TODO

Additional Notes

Coverage remained the same at 69.403% when pulling 0781d3b7be68bceb18f2cec74bf348560ed6b3d3 on camilamacedo86:git_hook_precommit into bf153617d19502d276b67675df2894b62d9786a4 on aerogear:master.


Leader election

Related to #409 are there plans to add leader election functionality similar to https://docs.openshift.com/container-platform/4.7/operators/operator_sdk/osdk-leader-election.html to the java operator sdk?

see https://kubernetes.slack.com/archives/CAW0GV7A5/p1643798302258639?thread_ts=1643796946.554699&cid=CAW0GV7A5

@shawkins I added this to 3.3 milestone for now.
To summarize it to my understanding there are two cases when running multiple instances of operators is happening and/or desirable, and leader election makes sure only one of them is actively reconciling, thus other than leader instances don't execute reconcilers:

minimize downtime, in cases:

There is an updated version of operator being released, and deployment first creates the new version of the operator pod then stops the old one. (For now to handle this scenario use recreate deployment strategy)
Minimise downtime of an operator crash, so there are multiple instances running all the time. However there are multiple strategies are this. So if an operator not the leader, should it populate the caches? and just not reconcile the events.

make sure fail-over operators are be provisioned on the cluster, so multiple instance are provisioned, therefore in case the active operator's pod is crashed, it cannot happen that a new instance is not provision because of cluster resources are not available.

In summary about implementation, there is one design question:

Should the non-leader operator instances activate event sources, and just don't trigger reconciliation until elected as leader? Or just basically start the operator when it is elected as leader. But has pros and cons, when event sources are activated will consume resources (polling in some cases possibly, cache resources in memory), on the other hand will minimize downtime, in case of the syncing the caches on startup takes long time.

Maybe the strategy should be configurable i.e. the framework would support event replication but let users activate or deactivate it depending on their needs?

Maybe the strategy should be configurable i.e. the framework would support event replication but let users activate or deactivate it depending on their needs?

Yes, a feature flag would be nice for that, agree.

Just one more note, in both cases, if an operator becomes the leader will need reconcile all the resources anyways.


Title is not updating

I am using flamethrower for deserve.deno.dev a documentation site and the title is not updating between page changes, I haven't looked into what's going on but it shows the correct title when I refresh the page

I kind figured out the problem the head tag is not diffed probably I suppose

This is similar to #45

This is similar to #45

pr #46 related to #45 fixes this issue

Fixed in https://github.com/fireship-io/flamethrower/pull/60


Clear Simple Mac Shortcuts

Can you provide proper information about shortcuts for Mac please.  It is annoying to see this desinforming shortcuts showing on Mac machines for VS Code.
For example, F5 - start debugging is what menu shows in VSC but F5 actually starts Voice Over, not debugging.  I know Mac does not respect F keys but then make simple one-hand shortcuts and show them in VSCode for Mac.
I also know I can override Mac to follow F keys but that disables Mac functionality, i.e Volume Up or Volume Down needs to be used with Fn+F11/Fn+F12 which what most people dont want to fudge with.
Considering the maturity and popularity of VSC, I'd say it is time to finally address this annoyance with VSC.

F5 - start debugging is what menu shows in VSC but F5 actually starts Voice Over, not debugging

it seems it's bind to cmd+f5

F5 - start debugging is what menu shows in VSC but F5 actually starts Voice Over, not debugging

it seems it's bind to cmd+f5

Read before you reply with stupid comment and ask for more info please.
you can clearly open your own VSC on your mac and show this screenshot instead of that and figure out of that what the problem is, cant you???

@dbnex14 what I'm trying to figure out is checking what's the default keybinding for Open Voice Over in your system. If it's set to F5, then it will definitely override VS Code's keybindings. By default, on macOS, turning on Voice Over is Cmd+F5 and it doesn't conflict with F5 from VS Code.
I don't doubt that F5 is assigned to Start Debugging on your machine but to figure out why this happens, we need to know why it triggers Voice Over, and if it's done by the OS.


Create CONTRIBUTORS.md

Related Issue

Issue number goes here:

Proposed Changes

i added my name in the file in CONTRIBUTORS.md

Checklist

[ ] Documentation of the code
[ ] Add your name to the CONTRIBUTORS file
[ ] Testing your code in the local machine

Screenshots

Hey @JASKIRAT11011 this contributors page is only for the ones contributing  to our repo and we keep a track of it. If you want to add your name to the contributing  list you can either wait for new issues or can suggest some in our discord server. We will create it.


Setting Last-Modified header

What is the equivalent to Response.Cache.SetLastModified (which sets the Last-Modified response header) in ASP.NET MVC 6? Should I just set it through Response.Headers.Set?

@Daniel15 yes I believe you would just set the header directly. I was never a big fan of the Cache stuff in ASP.NET 4.x (and earlier) because it conflated output cache, client cache, and so many other things.
Adding @Tratcher in case he knows of some other way.

Also is VaryByParam no longer required? I guess that makes sense since ResponseCache is only for response caching, and params are always taken into account with response caching anyways.
Is there an easy way to do server-side caching of a response? I used to be able to use [OutputCache(Location = OutputCacheLocation.Server)] for that.

There's an empty repo here just begging to be implemented :smile: VaryByParams is needed for server output caching, which isn't yet implemented.

Yes, the response caching implementation is incomplete. The middleware @Eilon referenced should be a full implementation and support Vary. We'll have to see how complex the VaryBy support gets though.
IIS and WebListener expose Http.Sys's kernel mode cache. Responses that are marked Cache-Control: public and have an expiration will be considered, but nothing with a Vary header can be cached.

Thank you!


Syntax error in ZCL_DBBR_OBJECT_BROWSER_TREE

I'm getting an error when trying to load ZDBBR.
It says "The parameter "P_LANGUAGE" was not found".
It points to include ZCL_DBBR_OBJECT_BROWSER_TREE==CM00H, line 72, but this error didn't make sense to me.

This issue was related to the version of abap-search-tools. I installed the correct one and this stopped occurring.


baobab: 3.30.0 -> 3.32.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/baobab/versions.
meta.description for baobab is: '"Graphical application to analyse disk usage in any GNOME environment"'.

Checks done (click to expand)

built on NixOS
/nix/store/z926kfvd75dn27jcbdh7mq237l666qy2-baobab-3.32.0/bin/baobab passed the binary check.
/nix/store/z926kfvd75dn27jcbdh7mq237l666qy2-baobab-3.32.0/bin/.baobab-wrapped passed the binary check.
2 of 2 passed binary check by having a zero exit code.
1 of 2 passed binary check by having the new version present in output.
found 3.32.0 with grep in /nix/store/z926kfvd75dn27jcbdh7mq237l666qy2-baobab-3.32.0
directory tree listing: https://gist.github.com/9a5bddcf774670ac9de58609ea14581f
du listing: https://gist.github.com/2414c22105c2b2d9bf2367843bfef232

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
baobab
gnome3.baobab

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z926kfvd75dn27jcbdh7mq237l666qy2-baobab-3.32.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A baobab https://github.com/r-ryantm/nixpkgs/archive/9646528ed2b8e054265b63f577df08aa812d8459.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z926kfvd75dn27jcbdh7mq237l666qy2-baobab-3.32.0
ls -la /nix/store/z926kfvd75dn27jcbdh7mq237l666qy2-baobab-3.32.0/bin

cc @lethalman @jtojnar @hedning @worldofpeace for testing.

already in #57027


[Bug] Error while parsing YAML Files

From chip-certification-tool created by rquidute: CHIP-Specifications/chip-certification-tool#959
Describe the bug
The following test cases are not being displayed in TH because they are falling when parsing the test case.

Test_TC_SC_4_2
Test_TC_SC_4_3
Test_TC_SC_4_4
Test_TC_SC_4_6

In all YAML script files, the disabled property has and extra . at the end of the line, ex:  disabled: true.
Steps to reproduce the behavior
1- Launch TH
2-In logs for each test case the following line is printed in backend log:
ERROR    | 2023-09-06 18:50:23.055 | test_collections.yaml_tests.sdk_yaml_tests:_parse_all_sdk_yaml:82 | Error while parsing YAML File: /app/backend/test_collections/yaml_tests/yaml/sdk/Test_TC_SC_4_2.yaml
Expected behavior
TH launches with no parsing errors.
Log files
ERROR    | 2023-09-06 21:12:06.363 | test_collections.yaml_tests.models.yaml_test_parser:parse_yaml_test:57 | 1 validation error for YamlTest
tests -> 0 -> disabled
  value could not be parsed to a boolean (type=type_error.bool)
ERROR    | 2023-09-06 21:12:06.366 | test_collections.yaml_tests.sdk_yaml_tests:_parse_all_sdk_yaml:82 | Error while parsing YAML File: /app/backend/test_collections/yaml_tests/yaml/sdk/Test_TC_SC_4_6.yaml
ERROR    | 2023-09-06 21:12:26.433 | test_collections.yaml_tests.models.yaml_test_parser:parse_yaml_test:57 | 1 validation error for YamlTest
tests -> 0 -> disabled
  value could not be parsed to a boolean (type=type_error.bool)
ERROR    | 2023-09-06 21:12:26.435 | test_collections.yaml_tests.sdk_yaml_tests:_parse_all_sdk_yaml:82 | Error while parsing YAML File: /app/backend/test_collections/yaml_tests/yaml/sdk/Test_TC_SC_4_4.yaml
ERROR    | 2023-09-06 21:12:31.285 | test_collections.yaml_tests.models.yaml_test_parser:parse_yaml_test:57 | 1 validation error for YamlTest
tests -> 0 -> disabled
  value could not be parsed to a boolean (type=type_error.bool)
ERROR    | 2023-09-06 21:12:31.287 | test_collections.yaml_tests.sdk_yaml_tests:_parse_all_sdk_yaml:82 | Error while parsing YAML File: /app/backend/test_collections/yaml_tests/yaml/sdk/Test_TC_SC_4_3.yaml
ERROR    | 2023-09-06 21:12:35.889 | test_collections.yaml_tests.models.yaml_test_parser:parse_yaml_test:57 | 1 validation error for YamlTest
tests -> 0 -> disabled
  value could not be parsed to a boolean (type=type_error.bool)
ERROR    | 2023-09-06 21:12:35.891 | test_collections.yaml_tests.sdk_yaml_tests:_parse_all_sdk_yaml:82 | Error while parsing YAML File: /app/backend/test_collections/yaml_tests/yaml/sdk/Test_TC_SC_4_2.yaml

PICS file
N/A
Screenshots
N/A
Environment

Test Engine version is TH Fall2023
Test Engine SHA is 22538eb7
Test Engine SDK SHA is 5ccb774

Additional Information
No response

There was a workaround in code to by pass the parsing error and it was already reverted in this PR: https://github.com/CHIP-Specifications/chip-certification-tool-backend/pull/598, since the YAML scripts was fixed.


TypeError: Cannot convert undefined or null to object

ERROR ==> problem loading plugin lando-mutagen from /Users/user/.lando/plugins/lando-mutagen/app.js: TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at Mutagen.availableInProject (/Users/user/.lando/plugins/lando-mutagen/Mutagen.js:29:33)
    at module.exports (/Users/user/.lando/plugins/lando-mutagen/app.js:29:18)
    at Plugins.load (/snapshot/cli/lib/plugins.js)
    at /snapshot/cli/lib/app.js
    at tryCatcher (/snapshot/cli/node_modules/bluebird/js/release/util.js:16:23)
    at MappingPromiseArray._promiseFulfilled (/snapshot/cli/node_modules/bluebird/js/release/map.js:61:38)
    at MappingPromiseArray.<anonymous> (/snapshot/cli/node_modules/bluebird/js/release/promise_array.js:114:31)
    at MappingPromiseArray.init (/snapshot/cli/node_modules/bluebird/js/release/promise_array.js:78:10)
    at MappingPromiseArray._asyncInit (/snapshot/cli/node_modules/bluebird/js/release/map.js:30:10)
    at _drainQueueStep (/snapshot/cli/node_modules/bluebird/js/release/async.js:142:12)
    at _drainQueue (/snapshot/cli/node_modules/bluebird/js/release/async.js:131:9)
    at Async._drainQueues (/snapshot/cli/node_modules/bluebird/js/release/async.js:147:5)
    at Immediate._onImmediate (/snapshot/cli/node_modules/bluebird/js/release/async.js:17:14)
    at processImmediate (internal/timers.js:464:21)
[ { service: 'cli',

I had been getting this error on my machine. Not too familiar with typescript, with I set a condition within the object to make sure keys isn't null in the converted js:
const services =  () => projectConfig ? Object.keys(projectConfig.services) : 0;

Hi,
I'm curious what your Lando configuration file looks like. As your temporary fix suggests, it seems the services key is missing from the project config.
Could you share your Lando file?

Closed due to lack of response.


test for checking if there is a high miss rate

Testing extended added one test checks if accuracy close to somehow real. #2

Thank you @vakhokoto for contributing. These kinds of tests are really important!


URL handling for different versions of the docs

From my point of view we need the following "environments":
next => currently master, specific docs for next major version
stable => currently in the 6.x branch (this should always point to https://rxjs.dev)
all past versions => soo this will be the 6.x
We basically have two different options how to structure the urls. We can use either subdomains of rxjs.dev or we use subfolders.
Pro and cons:
subdomains (v6.rxjs.dev:

toolchain already in place from angular.io (low effort)
allows changes to older versions (likely not happening though)

dedicated deployments
major release cause some effort to setup the docs properly
firebase needs a dns entry configuration

subfolder (rxjs.dev/v6):

easy deployment

html 5 routing might be a bit tricky as every subfolder is an own app
compiled artifacts of archived versions have to be checked in in github
toolchain needs to be changed (a little bit more effort in the beginning)

related to #5793 & #5792

Core Team Meeting: Generally okay with the path-of-least-resistance and using the sub-domain.

Closing this 'cause, AFAICT, the v6 subdomain is now a thing.


3 package.json files

Will it affect the structure of the boilerplate, if package.json files gets merged somehow ?

The intention of using separate package.json files, is to facilitate decoupled deployment of client and backend. For example if you want to deploy the client in heroku, you can easily do so by introducing 'npm start' for the client package.json file. When it comes to development, we wouldn't want to run commands by navigating to each folder. Outer package.json is used to ease this process.

Got it !, closing this issue now 😃


🎉 add: prim's algorithm

Continue to implement prim's algorithm

TODO: Refactoring Prim's Algorithm


One of our Open Search Queries is no longer returning any results

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v14.17.5
Amplify CLI Version
9.0.0
What operating system are you using?
Ubuntu
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No.
Amplify Categories
api
Amplify Commands
Not applicable
Describe the bug
Recently our Open Search Instance lost all of its data. We re-populated the data using the python script provided by Amplify - which has worked for us before when initially populating the Open Search instance.
Two of our indices are returning data via the AppSync search queries, but one is not. I've double-checked that the correct variables were used when populating the data.

analyticsevent
13436
4.46 MiB
90
properties
0

participant
707
769.09 KiB
365
properties
0

resource
1271
2.66 MiB
240
properties
0

analyticsevent
13436
4.46 MiB
90
properties
0
participant
707
769.09 KiB
365
properties
0
resource
1271
2.66 MiB
240
properties
0
The problematic index is resource.
The others are working as expected.
The example below is from the AppSync console:
query MyQuery {
  searchResources {
    nextToken
    total
  }
  searchParticipants {
    nextToken
    total
  }
  searchAnalyticsEvents {
    nextToken
    total
  }
}

{
  "data": {
    "searchResources": {
      "nextToken": null,
      "total": 0
    },
    "searchParticipants": {
      "nextToken": "WyJkOGI4MjZhMi1jMxxxUtYWY3Ny1hOGJkZDY2Y2E0NmUiXQ==",
      "total": 707
    },
    "searchAnalyticsEvents": {
      "nextToken": "WyJmZTMwN2Y3ZS1lxxxQ2NDgtOTBhOC1iZGNkNDViYzg4MWIiXQ==",
      "total": 10000
    }
  }
}

It's also worth noting that we have enabled CloudWatch logs for our Open Search instance and no errors are being reported. There is no error when running the AppSync query either, just no data being returned. We had data returned before the indexed data in Open Search was dropped.
Any help with this would be greatly appreciated.
Thank you in advance!
Expected behavior
All Open Search indices to return items.
Reproduction steps

As above.

GraphQL schema(s)

# Put schemas below this line

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response

Hey @kylekirkby, Thank you for reaching out. I was hoping to see if you could test a sample query(not on appsync) on the opensearch domain and check if any data being returned for the index. Please refer to https://docs.aws.amazon.com/opensearch-service/latest/developerguide/searching.html for additional information.
could you provide us the resolver mapping templates used for the effected index.

Hey @kylekirkby, Thank you for reaching out. I was hoping to see if you could test a sample query(not on appsync) on the opensearch domain and check if any data is being returned for the index. Please refer to https://docs.aws.amazon.com/opensearch-service/latest/developerguide/searching.html for additional information. could you provide us with the resolver mapping templates used for the affected index?

Hi @ykethan,
A colleague did this yesterday and was successfully receiving results via the Open Search dashboard. However, the AppSync console in AWS was not receiving anything.
I've since removed the custom search resolvers for the Resource index and run amplify push. Now we are seeing results in the AppSync console. The weird thing is that the custom resolvers were working... We suspect that an Amplify deployment since we initially deployed the custom resolvers has subsequently broken things. We are unsure how. We needed the custom search resolvers to get the date sorting working correctly.

@ykethan - so I've figured out the root cause.
My initial custom search resolver was using an index path like:
#set( $indexPath = "/resource/doc/_search" )

I checked the index path for the Amplify generated search resolvers and it was actually:
#set( $indexPath = "/resource/_search" )

Updating my custom resolver to use /resource/_search fixed my issue.
So I'm guessing at some point the index path has changed and that caused our custom resolvers to stop working..?

Hello @kylekirkby, thank you for the information. On testing the searchable directive with the CLI version 9.0.0 and 7.6.25. i observed the vtl template generated contained the index as #set( $indexPath = "/<model>/_search"

Glad to hear that you are back up and running. Please do let us know if you require any assistance, I would be happy in diving deeper.

@ykethan - thank you!


Added extra discount info

Useful for when you for example need to inform on which type of discount is provided.
Discount type: e.g. "2 voor 1", "2e halve prijs"
Discount period: e.g. "t/m maandag", "vanaf dinsdag"

Awesome, great addition! I can't find any examples of products that list the discount period, do you have any examples?

Thanks! I just checked and indeed the periods are not mentioned anymore on a lot of products, but I did find this vegan burger one. It probably only shows it when it is in a set number of days from ending/starting. It's still very useful though because it helps distinguish currently active discounts from future ones.

I see, cool! Thanks for the contribution!

Published in 0.2.4.


Any news to support ARM?

I've seen the "Support docker installation on RaspberryPi" #19 thread, but there has been no reply for a couple of years. Is this repo still active, and if so are there any plans of supporting ARM (or providing a tutorial)?

I have started the migration from CircleCI and Docker Automated Builds to GitHub Actions. Once completed, this should make it fairly easy to add support for building ARM images for Docker.

I have build the docker containers for arm64/aarch64 if anyone needs it. So far they work like a charm, with no problems.
https://hub.docker.com/u/ineshi


Securifi Almond websocket support?

hi,
is there a plan to support Securifi Almond router (hub)? it has websocket API.
https://wiki.securifi.com/index.php/Websockets_Documentation
thank you

Only one person interested here...


Windows installation

Very newbie question: I'd love to use xtensor-r before the CRAN release (can't wait to have the Numpy API in Rcpp!). But
conda install -c conda-forge xtensor-r

gives a package not found error. Googling I wasn't able to find a conda-forge xtensor-r package. Building from source is similarly a bit over my head.
Is there a way to devtools::install_github in the meantime? I gave
devtools::install_github("QuantStack/xtensor-r/tree/master/R-package")

a go but no luck.

Hi @alexpghayes , unfortunately, we have not pushed the conda or cran packages yet, so if you want to be on the bleeding edge, the only way is to install it from source.
For example
mkdir build
cd build
cmake ..
make cran

will generate the cran tarball that you can install with R classically.
We will not support the install_github features which requires the GitHub repository to basically contain the content of the cran package, which would mean a lot of generated content and the vendoring of xtensor core. The cran cmake generates something that you can use.

Note, I have just edited the instruction after noticing that you are on windows

Thanks for the quick response!
After adding C:\RBuildTools\3.4\mingw_64\bin;C:\Program Files\R\R-3.4.1\bin to my PATH, I can generate xtensor_0.1.0-0.tar.gz. Now when I run
install.packages('xtensor_0.1.0-0.tar.gz')

I get:
Error in .shlib_internal(args) :
  C++14 standard requested but CXX14 is not defined

It sounds like something akin to this: https://github.com/Microsoft/microsoft-r-open/issues/26#issuecomment-313739668
has to be done in this file here: https://github.com/QuantStack/xtensor-r/blob/master/R-package/src/Makevars.win
E.g. setting
CXX14 = g++
CXX14FLAGS = -O2 -g $(LTO)
CXX14PICFLAGS = -fPIC
CXX14STD = -std=c++14

SHLIB_CXX14LD = $(CXX14) $(CXX14STD)
SHLIB_CXX14LDFLAGS = -shared

But this is just an idea and might not work ...

@alexpghayes can you try with the latest changes in master?

Sorry for the delay. Getting the exact same issue as before (didn't make any changes to most recent Makevars.win).
> install.packages('xtensor_0.1.0-0.tar.gz')
Installing package into 'C:/Users/alex/Documents/R/win-library/3.4'
(as 'lib' is unspecified)
inferring 'repos = NULL' from 'pkgs'
* installing *source* package 'xtensor' ...
** libs

*** arch - i386
Error in .shlib_internal(args) :
  C++14 standard requested but CXX14 is not defined
* removing 'C:/Users/alex/Documents/R/win-library/3.4/xtensor'
Warning messages:
1: running command '"C:/PROGRA~1/R/R-34~1.1/bin/x64/R" CMD INSTALL -l "C:\Us
alex\Documents\R\win-library\3.4" "xtensor_0.1.0-0.tar.gz"' had status 1
2: In install.packages("xtensor_0.1.0-0.tar.gz") :
  installation of package 'xtensor_0.1.0-0.tar.gz' had non-zero exit status

@alexpghayes just removing CXX14 from Makevar.win should do it.
The way R handles this is really an issue. The current version on master does not have that flag anymore.

@alexpghayes I am closing this issue since this seems to work ok when removing CXX14 from the Makevar file (which is now done on master). We are now in the submission process to CRAN.

@alexpghayes the package is on CRAN!

Look forward to giving it a go! Sorry haven't been responsive -- classes just hit full ahead.
Thanks for making this happen!


Bedrock Version

Hi Scommander,
I 'fixed' this code to work in bedrock as well.
There are still some minor bugs, but it works fine for now.
I will be uploading my code to a new repo on my github, if you are oké with that.
I will keep it up to date and provide support if needed.
So please let me know

Miniontoby

I don't have a problem with that at all! I'd just ask you make it very clear it is not maintained by me, and credit myself for the idea. If you could also avoid using the same artwork thumbnail to avoid confusion of it being made by myself (it has my Minecraft skin's face in it)
I hope that feels reasonable :)

Hi Scommander,
I 'fixed' this code to work in bedrock as well.
There are still some minor bugs, but it works fine for now.
I will be uploading my code to a new repo on my github, if you are oké with that.
I will keep it up to date and provide support if needed.
So please let me know

Miniontoby

I don't have a problem with that at all! I'd just ask you make it very clear it is not maintained by me, and credit myself for the idea. If you could also avoid using the same artwork thumbnail to avoid confusion of it being made by myself (it has my Minecraft skin's face in it)
I hope that feels reasonable :)

Sure that's fine!

That is fine with me.
I have added the credits, changed the thumbnail and added README saying no support by you.
The code and pack can be viewed at https://github.com/Miniontoby/ItemTubesAddon

Is it fine if I leave this issue opened, because else people won't see it?
I have edited the first message to tell them all they need to know.

Can you 'redirect' bedrock users to my repo on your youtube video? I cannot do it since youtube just deletes my comments (or you're doing it...)
Btw the code for bedrock is like 90% identical, the only things changed are the paths, some quotes and doing the store success inside the run file. It might be possible for you to make some of these changes and it still should work on java and then with the help of my lang-mc package for bedrock (which I am now also trying to make for mc-builder) it would be possible to keep the code up-to-date and not even needing my repo


Please add a license and a screen shot

I'd like to add this to awesome-zsh-plugins, but I prefer to add themes with screen shots in the readme so that users can see what they look like without having to install them.
Also, please add a license file, some people won't use any code that doesn't have an open source license. If you don't have one in mind, https://choosealicense.com is a good resource to help you select an appropriate one.
Thanks!

Thanks for pointing that out! I've added both of them.


vdc actor needs documentation

https://github.com/Jumpscale/ays_jumpscale8/blob/8.1.1/templates/ovc/vdc/README.md

Please make sure to also point to the documentation here: https://github.com/Jumpscale/jscockpit/blob/8.1.1/docs/usage/Howto/Create_VDC/Create_VDC.md


Fix Zones/Change Detection issues with database

I split out the unrelated commits into #656

@vicb would you mind reviewing this commit? https://github.com/angular/angularfire2/pull/648/commits/2a96fa9521a37d7b519775e058c8b6ed34e47815

I removed the unrelated commits and rebased against master now, so down to just the zone fix.

Ref to https://github.com/angular/angular/issues/4603

@vicb all comments addressed. I pushed a separate commit with the changes so you can see what changed: https://github.com/angular/angularfire2/pull/648/commits/41207e38680c51be91ed1cb9f4d500b71d0eae63
I also updated the commit message with reference to the Angular issue.

LGTM after the comments are addressed

Merged at e18da0eb76b2ce48a3f38ac86bd9a27a4038e45b !


Remove patch from codecov.yml

Based on the cloudcov documentation and what @bachand mentioned here we should remove the patch from the coverage enforcement.

Thanks!


Entity card dynamic icon on scripts

Is your feature request related to a problem?
Dynamic icon based on state in scripts.
Describe the solution you'd like
When script is disabled icon looks gray and colored when enabled. This feature actually working on switches.
Describe alternatives you've considered
No response
Additional context
No response

Hello. What do you mean by disabled script ?

When script is not executing currently.
Example i have scripts when takes 1 hour after execute.   Primary info showing state of scripts but icon is always colored. wył= not currenty working

I didn't know what the best for scripts : always colored or not. Looks like I have the answer 😅

I was using it for visual confirmation a script was running.  Behavior indeed changed.  I would be eager to see it reverted :)


Integrates with Sleuth 2.2

This covers the data format from https://github.com/wavefrontHQ/wavefront-proxy/blob/3dd1fa11711a04de2d9d418e2269f0f9fb464f36/proxy/src/main/java/com/wavefront/agent/listeners/tracing/ZipkinPortUnificationHandler.java
This integrates with Sleuth 2.2, but doesn't use any new apis (would work even in Spring XML 2.5)
I've not been successful getting an account working with wavefront, it kicked out my vmware email and my attempt to register from my google account resulted in no email link (not trash etc)
Would appreciate someone with access verifying this as I noticed this project has no CI to actually integration test with the wavefront service, so hard to tell even before worked.

This project is working off spring-boot snapshot and I have no idea what the aspectj problem is, but someone who wants to try this out can use the following diff against https://github.com/openzipkin/sleuth-webmvc-example you'll notice this is basically drop-in and would still work even if the user are using OpenTracing instrumentation (bc sleuth provides a hook for that)
diff --git a/pom.xml b/pom.xml
index 71f99e2..5f8821e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,10 +28,16 @@
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot-starter-actuator</artifactId>
     </dependency>
-    <!-- Sends trace data to zipkin over http (defaults to http://localhost:9411/api/v2/spans) -->
     <dependency>
-      <groupId>org.springframework.cloud</groupId>
-      <artifactId>spring-cloud-starter-zipkin</artifactId>
+      <groupId>com.wavefront</groupId>
+      <artifactId>wavefront-spring-boot-starter</artifactId>
+      <version>2.0.0-SNAPSHOT</version>
+    </dependency>
+    <!-- TODO: figure out why everything dies on missing ReflectionWorld -->
+    <dependency>
+      <groupId>org.aspectj</groupId>
+      <artifactId>aspectjweaver</artifactId>
+      <version>1.9.5</version>
     </dependency>
   </dependencies>

diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties
index bd50def..9b67cf4 100644
--- a/src/main/resources/application.properties
+++ b/src/main/resources/application.properties
@@ -5,3 +5,4 @@ spring.sleuth.traceId128=true
 spring.sleuth.sampler.probability=1.0
 # Adds trace and span IDs to logs (when a trace is in progress)
 logging.pattern.level=[%X{traceId}/%X{spanId}] %-5p [%t] %C{2} - %m%n
+spring.zipkin.sender.type=none

for those not familiar with sleuth, you can actually co-report to multiple different tracing backends spring.zipkin.sender.type=none intentionally turns off zipkin reporting, which declutters logs so you can focus only on the wavefront part.

It seems I was confused by the micrometer setup, which isn't actually using a bean for the metrics sender. hence tracing can't share it.
Ex. I debugged and found this implicit connection being made inside the bean method.
	@Bean
	@ConditionalOnMissingBean
	public WavefrontMeterRegistry wavefrontMeterRegistry(WavefrontConfig wavefrontConfig, Clock clock) {
		return WavefrontMeterRegistry.builder(wavefrontConfig).clock(clock).httpClient(
				new HttpUrlConnectionSender(this.properties.getConnectTimeout(), this.properties.getReadTimeout()))
				.build();
	}

It seems spring-boot-actuator 2.2.5 brings in a different auto-configuration for micrometer, which doesn't expose the sender bean, while the snapshot version does expose it.
I will change the example app to manually override the spring boot version in hopes it catches the right actuator.. and see if it works via debugger.
@snicoll this is the sort of reason I was not a big fan of bringing sleuth which is based on 2.2 as a dep when the project here only tests against boot 2.3

the sender thing is ok only using latest spring boot snapshot.. progressing further now.

It seems spring-boot-actuator 2.2.5 brings in a different auto-configuration for micrometer, which doesn't expose the sender bean, while the snapshot version does expose it.

@adriancole you need Spring Boot 2.3.0.BUILD-SNAPSHOT. I've tried petclinic against your PR and I don't see any traces in Wavefront FTR.

really wish I had a login.. it is annoying to try to debug only with a debugger

I can give you a login @adriancole please reach out in DM

https://github.com/openzipkin/sleuth-webmvc-example/compare/wavefront try this also
I think the last glitch after snapshot was sleuth set sampling only when zipkin was in the classpath. it might work now. I'll follow-up on that glitch later

handing this over to @snicoll as things communicate now (using the sleuth-webmvc-example above and this branch)

Thanks a lot @adriancole. I've got tracing as well with petclinic.
Integrating with Spring Cloud revealed an issue with the context boostrap that I need to workaround, see https://github.com/spring-cloud/spring-cloud-commons/issues/737
Adrian and I also discuss the @Import he added on  SamplerAutoConfiguration. I need to figure out why that is and how we can avoid that. I'll submit PRs to that affect.

I've added a fix for the context bootstrap problem in #24

incidentally, I looked and the the handler part of this code would work with Sleuth all the way back to 2.0, as well even Spring 2.5 XML.
As folks are in a focused effort towards the upcoming RC, there's probably not enough energy or immediate value to extract this, yet. Just mentioning that if something comes up in the future, it can come in handy. In practice, we routinely get questions of sites mixed between boot and spring XML, and that's one large reason Sleuth uses Brave.

For other reasons we need Spring  Boot 2.3 and Micrometer 1.5 so I think we are fine.
Here is how I would like to get this merged, which I believe is a good summary of our meeting yesterday:

If Sleuth is enabled for the app, use that and export traces based on the proposal in this PR. Sleuth is what the Spring ecosystem will expect so we need to make sure it is a first class citizen
This project has historically OT support and customers are using that. If Sleuth is not configured, fallback to what we currently have on master.

@panghy can I get a review of the wavefront team on this please? If you need my help to setup a sample, please let me know. I am looking specifically at the WavefrontSpanHandler and what is actually exported to Wavefront. I've noticed the dashboard is less rich when the app runs with this PR and Sleuth so I'd love us to collaborate to provide the same information, if possible.
Once I have a review, I will work on the auto-configuration part and the tests, the same way I did for this project initially. I've fixed the Spring Cloud limitation in #24 and I still need to figure out why we have to import an auto-configuration but hopefully we'll find a fix for that too.
Can you give me an ETA for the review? Thanks a lot!

ps sleuth has also had OT users for years https://cloud.spring.io/spring-cloud-sleuth/reference/html/#opentracing

That's good to know! Something to keep in mind.
@adriancole I went to the bottom of why you need to add that import on SamplerAutoConfiguration but I am not sure what to recommend at this point. You have mentioned that to me previously but it didn't click.
SamplerAutoConfiguration and TraceAutoConfiguration are both competing for providing a brave.sampler.Sampler. TraceAutoConfiguration provides Sampler.NEVER_SAMPLE by default. SamplerAutoConfiguration, however, provides an actual Sampler. If the latter isn't contributed to the context, no trace gets exposed which is consistent with the discussion above.
Unfortunately, there is no ordering between those two auto-configurations and I am not even sure what the intention is there really. TraceAutoConfiguration runs first, creates  the no-op Sampler. SamplerAutoConfiguration runs next and backs off because a Sampler bean is already defined.
The import you added in this PR overrides the order. Do you know why Sleuth has two sources for such a bean? How is SamplerAutoConfiguration supposed to work since TraceAutoConfiguration provides a no-op bean?
One way to mitigate the issue would be to create a Sampler bean ourselves here and make sure we run fist but then we lose the logic about the @RefreshScope.

@snicoll terse because on a call, not because of you. don't read into the way it exists. SamplerAutoConfiguration should control the sampler not TraceAutoConfiguration. If there's a nice way to decouple responsibility we should change to that in sleuth and then rely on tests that exists to prove it. I'm not personally good enough at spring boot to know  if that means AutoConfigureAfter or something else. what you think is best.. we should try, but meanwhile probably pragmatic to import here I think with a comment on the PR to sleuth to fix it. Wanna raise a PR to unspaghetti this (in sleuth) otherwise tell me best practice and I'll do it.

So if I read you correctly @snicoll, we would be switching out sleuth and OT by default and if the user plops in the dependency, we'll detect it on the classpath and configure right?
I can take a look at this.

So what I think is missing is the metricization that happens in the OpenTracing SDK that we have and without that, the landing page that we plop people on (the service page) will not show the right things (you can only see traces via the "All Traces" link).
@sushantdewan123 is there some common code from the OT tracer that we can use to do that without reinventing the wheel here?

@panghy I have already something in that direction locally. I am waiting for a review of this PR to massage things a bit so that we can do the right thing based on the classpath. I didn't review the bits Adrian wrote with regard to tracing itself (i.e. WavefrontSpanHandler) so a review of that would be great. Once I have a green light of the team, I can fine tune and merge this one.
IMO the priority is to make sure that both solutions provides a similar user experience. If you can look into that, that would be great!

So what I think is missing is the metricization that happens in the OpenTracing SDK that we have and without that, the landing page that we plop people on (the service page) will not show the right things (you can only see traces via the "All Traces" link).

hmm interesting.. are you doing metrics on spans? does that imply you are doing 100% sampling? If so, it simplifies another discussion. Regardless brave has a concept of "local sampled" which means that you can do 100% aggregation of operations even if they are not remotely sampled.
Here's a simplified example of micrometer which I presume the SDK code, once understood, could be ported to https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/features/handler/SpanMetricsCustomizer.java

SamplerAutoConfiguration should control the sampler not TraceAutoConfiguration. If there's a nice way to decouple responsibility we should change to that in sleuth and then rely on tests that exists to prove it.

Thanks Adrian, I've moved that conversation to https://github.com/spring-cloud/spring-cloud-sleuth/issues/1618

I fixed the config bug where service name wasn't coming through properly. I also added a note as usually spring users like to have least config possible and explicitly setting wavefront.application.name=${spring.application.name} will be a bore to people not already using wavefront.
Further, I know there is some doubt that persists about sleuth and opentracing. I rebased my example branch over the existing sleuth opentracing example to prove it works.
https://github.com/openzipkin/sleuth-webmvc-example/compare/wavefront

Note: we really really should not advise or otherwise pull in configuration from opentracing starters as they are often copies of sleuth in the first place, and as well having duplicate instrumentation will be messy. In other words let's please not begin a problem we don't currently have in sleuth. Right now, users only use OpenTracing for things sleuth is missing, notably custom tracing code.

At first I thought the metrics you were referring to were the health metrics. I integrated them anyway, but I believe it must be the RED metrics. I think I can figure it out from the other code

and yeah as far as I can tell the RED metrics in wavefront are not on sampled data, which makes sense, but I wanted to clarify.

I think I figured out the jist of what's going on with RED metrics by reverse engineering the opentracing code.
It is probably nonsense to layer anything else onto this PR until it is likely to be merged. FWIW here's a rough cut https://github.com/adriancole/wavefront-spring-boot/compare/integrate-sleuth...adriancole:integrate-sleuth-red

I believe what might still be missing is the component heart-beat metrics that are sent as long as it is initialized. @sushantdewan123 can add to this. We don't have a component for sleuth today (or would it be brave?) in the backend but we can certainly add that (essentially recognizing the component metric and showing the service).
Then again, maybe we should just call it the spring boot component? This has implications in the future since Jaegar and Zipkin are just jaegar and zipkin component to us because we don't have a way to tell what's generating them but for Sleuth, should we capture the actual component so that we can customize the landing page as well?

IMHO both the heartbeat and RED metrics stuff are more metrics/micrometer than sleuth brave zipkin or jaeger (or otherwise).
Ex Maybe heartbeat and RED could be callback of of two timestamps and a micrometer tag set?
The interface could say "give me these things for every span in the firehose, regardless of the api implementing the firehose.
Put more specifically, https://github.com/adriancole/wavefront-spring-boot/compare/integrate-sleuth...adriancole:integrate-sleuth-red is mostly just micrometer code... that could be a component indeed.

@snicoll thoughts? this is definitely a tracing/metrics interaction whereby we need:

component heartbeats (regardless of whether there is traffic) and
metricization of spans

Bonus points for 1) to send heartbeats on start-up (once and resume 60s) because then we can immediately draw the proper UI elements. Perhaps that's a question for micrometer (like force a flush after start-up).
Perhaps we can add a WavefrontSender shim that does 2)? thoughts @sushantdewan123
For 1), we'll need to have an inventory of components somehow.

ps @snicoll (who is in a better timezone anyway) offered to polish this up and do follow-ups when he's free. I really didn't initially intend to spend a dozens of hours on this, though that's past :P

Thanks a lot for that @adriancole. I've polished as discussed so that Spring Cloud Sleuth is configured and a fallback configuration with OT is applied if it isn't around.
@adriancole I didn't do anything with the RED metrics you've started working on. Would you be so kind to rebase that work from master and submit another PR so that we can discuss that part?
@sushantdewan123 I've applied your review, thank you very much. I didn't change the prefix of the metrics as I didn't understand why they had to have spring-boot in their names.

@snicoll Thanks for taking this on
here's the other thing you asked about https://github.com/wavefrontHQ/wavefront-spring-boot/pull/35
To finish this after incorporating feedback might be similar to the integration test I made here, except not using a WF span service fake, rather one for the existing heartbeat and red metrics api.


Sign transactions on creation if a key is passed.

Transactions from createTransaction and createSiloTransaction should be signed by default as they can be signed again if the consuming application wants to modify the contents, add tags etc before submitting.

Perhaps this should be added just before posting to avoid duplication of work? As it happens, there is new signAndPost function in the pipeline that will do this.
Closing this issue for now.


Undocumented use of @ for an array of objects

The A key for Target object uses the expression fn:Eval(@A==fn:PageProperty(@P,Annots::@NM)) for possible values. It looks like Annots::@NM tries to reference a key in the array of objects, which is not defined by the internal grammar.

Yes it is - see https://github.com/pdf-association/arlington-pdf-model/blob/master/INTERNAL_GRAMMAR.md#validation-of-predicates-declarative-functions, 7th bullet point.
I may not have been consistent with implementation or usage, but the intention has always been there and documented.

In this case, the problem is a part of path is missing between Annots and @NM

Ahh! OK - I misunderstood.
The issue is for A in Target.tsv (Table 205) trying to encode the last sentence specific to string-text: "If the value is a text string, it specifies the value of NM in the annotation dictionary (see "Table 166 — Entries common to all annotation dictionaries")."
The core issue is that Annots is an array on page objects but the target dictionary could be "deeper" in a page's DOM tree (which is why fn:PageProperty exists), and at some unknown element in the page's Annots array, an annot dict needs to have a specific NM entry with a value equal to @A of the Target dictionary. Semantically this might be more accurate: Annots[*]::@NM but I do NOT want to use [/] as it makes parsing much harder. So I'm left with introducing a new predicate.
For the integer case of A, the current predicate reads OK:

(@A>=0) && (@A<fn:ArrayLength(fn:PageProperty(@P,Annots)))

which also implies fn:PageProperty(@P,Annots) returns an array. Predicates are also limited to only 2 arguments so if the new predicate is fn:FindNMValueInArray(array,value) then the "SpecialCase" for string-text becomes:

fn:Eval(fn:FindNMValueInArray(fn:PageProperty(@P,Annots),@A))

which reads aloud quite similar to the spec wording...


License conflict

Hi.
I have sparked a discussion on the FreeGameDev forums about whether mixing CC BY-SA and CC BY-NC-SA assets is possible. I argue that it's not possible for the assets that go into the game. The details of how I came to that conclusion are in the threads. But I also believe that the songs and images that play in the lobby do not form a derivative work, and there is no conflict (Space Asshole is safe).
Others believe that there is no conflict whatsoever, claiming that CC copyleft is weak copyleft, but providing nothing to support that claim.
Others have brought up the issue of having NC stuff and receiving monetary support through Patreon. The concept o NonCommercial in CC licenses is left purposely vague, but I believe that, in this case, with the transparent accounting and all money going into hosting, it shouldn't be a problem. Still, there's plenty of room for disagreement.
https://freegamedev.net/d/186-what-are-you-playing/10
https://freegamedev.net/d/189-licenses-was-what-are-you-playing
https://freegamedev.net/d/196-space-station-14-uses-cc-by-nc-sa
I would really appreciate if you folks could take your time to consider this issue. Thank you.

I can't speak for the audio assets, but I can speak for all of the sprites. Usual IANAL included.
All of these sprites are taken from Space Station 13, where the exact same arrangement occurs (except, believe it or not, sprites don't even have license information or author attribution immediately available like RSIs) and all parties (authors included) are completely fine with the arrangement regarding both license mixing and patreon with NC assets.
Frankly, it doesn't really matter if the licenses conflict nor if patreon is commercial if the rightsholders are completely fine with it.

Also if you really want to get upset about something, go done the actual SS13 licensing drama rabbit hole (which SS14 is not responsible for).

I argue that it's not possible for the assets that go into the game. The details of how I came to that conclusion are in the threads.

Your argument seems to be that SS14 somehow counts as a derivative work of all of its individual assets--meaning that it would indeed count as an adaptation and thus there would be conflicts because BY-SA and BY-NC assets. On the other hand, we have no idea how the individual assets we use somehow don't count as individual assets just because they are packaged together later.
Who is correct here? No one will ever know, because none of us are lawyers, and this is never going to court--remember, this community has a 19 year history (far messier license-wise than you could ever know).

Others believe that there is no conflict whatsoever, claiming that CC copyleft is weak copyleft, but providing nothing to support that claim.

You are the one that has to substantiate the claim. CC licenses never claim to be infectious; the terms they are distributed under only mention that you must attribute the work and give proper credit. There is literally nothing supporting the claim that CC licenses are hard copyleft.

Others have brought up the issue of having NC stuff and receiving monetary support through Patreon.

CC's description of NC draws the line at "[works] primarily intended for or directed toward commercial advantage or monetary compensation." We are transparent with our Patreon funds, and it's clear that they do not give us a commercial advantage nor are they used to compensate anyone. Is there room for legal games with this? Sure, but they're never going to happen.
Anyone without a law degree who tries to make these points should be laughed out of the room. Please don't bring your pointless license LARPing to our repository and expect us to care about it in any capacity.


Doc examples

@ordirules doc examples as requested by @kevinyager (I think?)

This looks great!

Codecov Report

Merging #40 into master will increase coverage by 0.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage    97.8%   98.09%   +0.28%
==========================================
  Files           5        6       +1
  Lines        1050     1050
==========================================
+ Hits         1027     1030       +3
+ Misses         23       20       -3

Impacted Files
Coverage Δ

shed/tests/test_utils.py
100% <100%> (ø)

shed/tests/test_streams.py
99.3% <100%> (+0.02%)
:arrow_up:

shed/event_streams.py
95.76% <100%> (+0.03%)
:arrow_up:

shed/tests/utils.py
100% <0%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505fabb...907bf86. Read the comment docs.


Two places where tokenization should be standardized

In most places in ExplainaBoard, we use standardized tokenizers to tokenize the source and target texts. However, there are (at least) two places where we use other tokenizers.
First, explainaboard/analysis/sum_attribute.py uses the NLTK punkt tokenizer. This would be nice to remove because (1) it is non-standard for ExplainaBoard, (2) it's the only place where we use nltk so if we remove this we can reduce by one library dependency, and (3) it does download of the punkt tokenizer from the NLTK site, resulting in an extra external data access: https://github.com/neulab/ExplainaBoard/blob/main/explainaboard/analysis/sum_attribute.py#L4
Second, explainaboard/analysis/feature_funcs.py simply splits on white space instead of using the standard tokenizer: https://github.com/neulab/ExplainaBoard/blob/main/explainaboard/analysis/feature_funcs.py#L50

@neubig Is there any consequences that we need to take care when the NLTK tokenizer has been removed? I agree with removing it though (for improving simplicity around data dependency).

I don't think so. The NLTK tokenizer is only used in that one file, everywhere else we already use different tokenizers that achieve very similar results (e.g. the SacreBLEU tokenizer).

@neubig There are utilization of sent_tokenize, word_tokenize, and ngrams from NLTK. It looks word_tokenize can be replaced by SacreBleuTokenizer and ngrams can be implemented by ourselves, and there looks to be no alternatives in this repository for sent_tokenize.

Ah, thanks, I see. It'd be nice to have a wrapper for sentence tokenization too.


Missing Step to Save Model and modification to _modelPath

The step for saving model seems to be missing from this tutorial. I found one in Iris Flowers one though and followed that, should add it here.
Also would modify _modelPath to be:
Path.Combine(Directory.GetParent(Environment.CurrentDirectory).Parent.Parent.ToString(), "Data", "Model.zip");
As "Environment.CurrentDirectory" points to Solution\bin\debug\netcoreapp2.2(folder\file) rather than in the data folder for vs2019... or add a note that it will be found in the bin directory.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8e22825-c4ee-5a36-f911-8ad456970ecc
Version Independent ID: ad0bf640-7dfc-1184-077c-358bb14277a7
Content: Use ML.NET in a sentiment analysis binary classification scenario
Content Source: docs/machine-learning/tutorials/sentiment-analysis.md
Product: dotnet-ml
GitHub Login: @JRAlexander
Microsoft Alias: johalex

Thanks for your feedback, @Amorpheuz!  We'll add a note about the bin directory.

@Amorpheuz - Here's the link to the recently published save and load how-to article: https://docs.microsoft.com/en-us/dotnet/machine-learning/how-to-guides/save-load-machine-learning-models-ml-net
Closing this as I believe it's resolved. Please reopen if that's not the case. Thanks!


Twitter List + filter:hashtag

I'm using a lot Twitter lists to segment signal and diminish noise on the timeline, but what I always missed on Twitter is the ability to display a list content only if it match a specific filter.
let's say I have a list only about "Social Entrepreneurs" this swarm use #socent to tag post related to social entrepreneurship, my goal is to be able to exclude all the content on the twitter list beside tweets with the #socent hashtag.
Does this need to be a new bridge or could be added to the existing twitter bridge option ?
anyway this is clearly a feature request or suggestions :)

Does this need to be a new bridge or could be added to the existing twitter bridge option ?

I added it as option to the existing bridge. Please have a look at PR #545 and let me know if this is working for you. I am a bit uncertain about the filter. Right now it is using an exact match algorithm, so no wildcards or multiple terms.

Can't wait to try this out, will git pull existing install and have a look on Wednesday, thanks a lot for adding it to existing bridge! Will report back how it goes :) On Jul 3, 2017 8:52 PM, LogMANOriginal<EMAIL_ADDRESS>wrote:
Does this need to be a new bridge or could be added to the existing twitter bridge option ?
I added it as option to the existing bridge. Please have a look at PR #545 and let me know if this is working for you. I am a bit uncertain about the filter. Right now it is using an exact match algorithm, so no wildcards or multiple terms.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

Hmm I had to re-install this code, do I get the new twitter list filter when on master ?

Not yet, no. I'll merge asap™


Working with sRGBEncoding

Hi, great work! How could I get this to work with THREE.sRGBEncoding for renderer.outputEncoding?

Thanks!
The examples in this repo use WboitPass it as a stand-alone renderer, however, it is designed as a Pass for EffectComposer. WebGLRenderer.outputEncoding is only respected when rendering to screen. EffectComposer (and in turn WboitPass) use render targets encoded in the linear space. EffectComposer expects processing in the linear space to reduce color conversions during every pass. (source) (further reading). When using post processing, it is possible to use a gamma correction pass at the end of your pass chain to ensure a sRGB encoded output (source).
I have added an example (https://stevinz.github.io/three-wboit/EffectComposer.html) that uses this EffectComposer workflow to demonstrate. You can cycle the gamma correction ShaderPass on / off in the options. Hope this helps.

Thank you for the detailed explanation!
I added in the gamma correction shader, but things appear lighter than they used to be. Do you have any idea why this is happening?
Before:

After (with wOIT and gamma correction)

I tried changing the weight from 0 to 1, but it didn't help.

That is interesting. Initial thoughts is that the textures on the trees aren't sRGB encoded, or that lighting is enabled on the tree material? I have updated the EffectComposer.html example (source - live link) to use sRGB encoded textures.
I am having trouble trying to recreate the issue. I would be willing to spend more time looking into it if you could provide a minimal example demonstrating the problem. (codepen, jsfiddle, etc.)

Thanks for the response! I just found out something weird... The screenshot I produced is on one of my dual monitor setups. I switched it to the other monitor, and everything looked correct. What could be the cause of this?

Hmm, tricky. Monitors have encoding settings as well. I know on mine when I open the monitor settings with the physical buttons on the side / rear of the monitors, under 'Color Settings' I can select 'sRGB', 'P3', 'Warm', 'Cool', etc. Could be a hardware setting? These settings are external of the computer / OS / graphics card...

Weird... I can't seem to find color settings by pressing the buttons. I do see an "input color format" of YCbCr", does that have to do with the issue?

Hard to say, even with different monitor settings the difference you posted the first time looks pretty extreme. Ignoring the monitor issue for a moment... When you're using wboit + gamma correction do you have renderer.outputEncoding set to Linear or sRGB? Now that the sRGB encoding is happening in the Effect Composer the renderer should be set to Linear, otherwise it's possible the encoding is happening twice in some cases.

I just checked and I do have it on sRGBEncoding, but after changing it to LinearEncoding, the effects still persist. Below is my custom shader material:
const material = new ShaderMaterial({
  vertexColors: true,
  fragmentShader,
  vertexShader,
  uniforms: {
    ...UniformsUtils.clone(ShaderLib.basic.uniforms),
    // map: this.uniforms.atlas,
    uSunlightIntensity: this.uniforms.sunlightIntensity,
    uAOTable: this.uniforms.ao,
    uMinBrightness: this.uniforms.minBrightness,
    uFogNear: this.uniforms.fogNear,
    uFogFar: this.uniforms.fogFar,
    uFogColor: this.uniforms.fogColor,
    uTime: this.uniforms.time,
    ...uniforms,
  },
}) as CustomShaderMaterial;

WboitUtils.patch(material);

export const DEFAULT_CHUNK_SHADERS = {
  vertex: ShaderLib.basic.vertexShader
    .replace(
      "#include <common>",
      `
attribute int light;

varying float vAO;
varying vec4 vLight;
varying vec4 vWorldPosition;
uniform vec4 uAOTable;
uniform float uTime;

vec4 unpackLight(int l) {
  float r = float((l >> 8) & 0xF) / 15.0;
  float g = float((l >> 4) & 0xF) / 15.0;
  float b = float(l & 0xF) / 15.0;
  float s = float((l >> 12) & 0xF) / 15.0;
  return vec4(r, g, b, s);
}

#include <common>
`
    )
    .replace(
      "#include <color_vertex>",
      `
#include <color_vertex>

int ao = light >> 16;

vAO = ((ao == 0) ? uAOTable.x :
    (ao == 1) ? uAOTable.y :
    (ao == 2) ? uAOTable.z : uAOTable.w) / 255.0;

vLight = unpackLight(light & ((1 << 16) - 1));
`
    )
    .replace(
      "#include <worldpos_vertex>",
      `
vec4 worldPosition = vec4( transformed, 1.0 );
#ifdef USE_INSTANCING
  worldPosition = instanceMatrix * worldPosition;
#endif
worldPosition = modelMatrix * worldPosition;
vWorldPosition = worldPosition;
`
    ),
  fragment: ShaderLib.basic.fragmentShader
    .replace(
      "#include <common>",
      `
uniform vec3 uFogColor;
uniform float uFogNear;
uniform float uFogFar;
uniform float uSunlightIntensity;
uniform float uMinBrightness;
uniform float uTime;
varying float vAO;
varying vec4 vLight;
varying vec4 vWorldPosition;

#include <common>
`
    )
    .replace(
      "#include <envmap_fragment>",
      `
#include <envmap_fragment>

// Intensity of light is wavelength ** 2
float s = min(vLight.a * vLight.a * uSunlightIntensity * (1.0 - uMinBrightness) + uMinBrightness, 1.0);
float scale = 2.0;

outgoingLight.rgb *= vec3(s + pow(vLight.r, scale), s + pow(vLight.g, scale), s + pow(vLight.b, scale));
outgoingLight *= vAO;
`
    )
    .replace(
      "#include <fog_fragment>",
      `
vec3 fogOrigin = cameraPosition;

float depth = sqrt(pow(vWorldPosition.x - fogOrigin.x, 2.0) + pow(vWorldPosition.z - fogOrigin.z, 2.0));
float fogFactor = smoothstep(uFogNear, uFogFar, depth);

gl_FragColor.rgb = mix(gl_FragColor.rgb, uFogColor, fogFactor);
`
    ),
};

I don't think the shader code matters. I just tried using a MeshBasicMaterial with the same texture atlas and the weird brightness still exists. Could this be related to using CanvasTexture for the generated texture atlas?

Things look normal with a RenderPass:

After running WboitUtils.patch(material), if you then set material.wboitEnabled = false, does the problem still occur on transparent objects? During the WboitPass, normal transparent objects and wboitEnabled transparent objects are rendered separately, I'm wondering if it could be a blending issue.

This is interesting... The problem still occurs on transparent objects.

Hmm, another thought. Are you doing any passes in EffectComposer before the WboitPass? If not, you should probably have WboitPass clear the write buffer by setting a clear color (if you're not already). In order to have WboitPass perform a clear, you need to pass a THREE.Color the constructor. For clearing to black it would simply be:
const wboitPass = new WboitPass( renderer, scene, camera, new THREE.Color() );

Does that make a difference?

I do not have any passes before the WboitPass, and passing a clear color didn't change anything :(
The only two passes I have are these:

Seems like this problem happens to other people too. This is @donmccurdy's solution: link I will try to dig deeper into three-wboit's WboitPass and convert it into postprocessing's syntax locally.

I'm not sure that is the same issue, your colors seem off differently than the colors in that post. Do you have a link to a specific texture that you are having this issue with? It would be nice to have a minimal example...
It shouldn't be necessary, or desired, but someone also suggested to try setting EffectComposer's render target's encoding:
composer.renderTarget1.texture.encoding = THREE.sRGBEncoding;
composer.renderTarget2.texture.encoding = THREE.sRGBEncoding;

I would be curious if that made a difference. You could try changing the encoding on the main render target in WboitPass:
const wboitPass = new WboitPass( renderer, scene, camera );
wboitPass.baseTarget.texture.encoding = THREE.sRGBEncoding;

Okay, I think I've solved it.
The blending methods used in WboitPass result in visually accurate colors, but with alpha value's that vary. For the sRGB conversion the color values should have an alpha value of 1.0... I have created a new shader to encode from Linear space to sRGB space that premultiplies the alpha. I'm almost positive it will fix your issue.
I have updated the library and the build on npm. To use:
import { sRGBShader } from 'three-wboit';

// replace
// composer.addPass( new ShaderPass( GammaCorrectionShader ) );

// with
composer.addPass( new ShaderPass( sRGBShader ) );

Thanks for your help so far!
I just tried out the sRGBShader replacing it with the GammaCorrectionShader, but it seems like transparent objects have turned black, and I'm not sure why :/

Here's the source code for my example:

PR

Let me see if I can setup a minimized example somewhere so it's easier to reproduce the problem.

Very interesting..
It could be an issue with WboitUtils.patch. I haven't tested it with ShaderMaterial. I can check it out, but in the meantime you could try adding the shader code directly into you shader chuck. When you build your shader material, add uniforms renderStage and weight
At then in your fragment shader (shaders.ts)
Add the uniforms:
    uniform float renderStage;
    uniform float weight;

And at the very end, add the wboit code:
    if ( renderStage == 1.0 ) {
       vec4 accum = gl_FragColor.rgba;

	#ifndef PREMULTIPLIED_ALPHA
	    accum.rgb *= accum.a;
	#endif

	float z = gl_FragCoord.z;
        float scaleWeight = 0.7 + ( 0.3 * weight );
        float w = clamp( pow( ( accum.a * 8.0 + 0.001 ) * ( - z * scaleWeight + 1.0 ), 3.0 ) * 1000.0, 0.001, 300.0 );
        gl_FragColor = accum * w;
    } else if ( renderStage == 2.0 ) {
        gl_FragColor = vec4( gl_FragColor.a * gl_FragCoord.z );
    }

And then in index.ts, change
// Old
// WboitUtils.patch(material);

// New
material.wboitEnabled = true;

Hmm, well I just tested it with ShaderMaterial and that's not it...
Does the darkness / blackness go away if you set opacity to a lower value, like 0.5?

Let me try. I'm creating a tiny project and am trying to reproduce the problem. Thanks for your help man 💯

For my actual project, setting opacity to 0.5 doesn't change. I'm starting to wonder whether or not it's the TextureAtlas class's fault 🤔

Ok here's the project: link

Okay, thanks I'll take a look

Okay, so using the original GammaCorrectionShader I do see what you were talking about. The object on the right (the Wboit patched object) looks a little lighter / brighter.
However, I think that's because in your file style.css you have background-color: #242424;. Wboit rendering uses special blend modes and the final rendered image has partially transparent pixels, it needs the background to be black. When I changed it to background-color: #000000;, the colors look identical between the two objects. Does that work for you?

Hmm, that's weird. I removed the background color and pretty much everything in the styles.css, and this is what I got:

The mesh on the right is too bright to be visible. BTW, I've pushed my changes to the same repo.

The background has to be black, not white. Try adding at top of style.css:
:root {
  background-color: #000000;
}

Here's what it looks like in black:

Interesting, here's on my machine:

And lighter background for comparison:

Hmmm.. I see on your machine the one on the right is also slightly brighter. Could it be that my monitor gets affected more by the Wboit pass? I found out that if I turn the material to double side, it would become even brighter, but when I turn the opacity down a bit it isn't as bright.

It is strange.
But, the one on the right is brighter because the renderer's write buffer has partially transparent pixels from the WboitPass and the background color is mixing with the renderers output. That's why setting the background to black should fix the issue.
It's possible your monitor is then taking the resulting pixels and applying more correction on them. Even though visually the two objects should look the same on a black background. The one on the left has an alpha value of 1.0, where the one on the right varies, but in that picture has an alpha value of 0.5. In which case for two pixels to look the same with different alpha values the RGB values must be greater, and then in turn get affected more by any correction your monitor is doing after. The point of the sRGBShader I added was to convert the alpha value to 1. I am going back to it and working on some more tests...

Alright, how does (https://stevinz.github.io/three-wboit/vox/VoxTest.html) look on your machine? Try adjust the opacity slider as well.

Wait it looks exactly the same on both sides! How is this done?

Well, the blending methods used in wboit create alpha values that are different then standard blending. They seemed to be causing a problem on your monitor (and I'm guessing others would have the same issue).
So before doing gamma correction in the sRGBShader, I am setting the alpha channel to fully opaque (1.0).

Got it. Thanks so much for the help!


Error on global install: Maximum call stack size exceeded

Version
3.5.5
Environment info
Can't run since vue-cli is unable to be installed. Here's release info, though.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic

Node version: v11.13.0
NPM version: v6.7.0

Steps to reproduce

Ensure no version of vue/cli is installed.
Run sudo npm i -g @vue/cli inside Ubuntu's terminal.
Observe the Maximum call stack size exceeded error.

What is expected?
vue-cli v3.5.5 should be installed globally, giving global access to the vue command
What is actually happening?
The following error message is received:
npm WARN deprecated<EMAIL_ADDRESS>cross-spawn no longer requires a build toolchain, use it instead
/usr/local/bin/vue -><EMAIL_ADDRESS>npm WARN lifecycle The node binary used for scripts is /snap/bin/node but npm is using /snap/node/1872/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/@vue/cli/node_modules/protobufjs
> node scripts/postinstall

2019/04/03 08:55:34.121225 cmd_run.go:876: WARNING: cannot create user data directory: cannot create "/nonexistent/snap/node/1872": mkdir /nonexistent: permission denied
cannot create user data directory: /nonexistent/snap/node/1872: Permission denied
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>- 14.1.x but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/@vue/cli/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! Maximum call stack size exceeded

I am currently running into this issue on a clean install of Ubuntu 18.04. I have attempted to clean the cache(npm cache clean --force) and rebuild npm (npm rebuild). I also attempted to install other npm packages globally, such as nodemon, with success.

After a complete re-install of Ubuntu and node/npm, installing the vue-cli now works. Hate I can't give any more helpful advice for future readers looking to fix this issue, but I'm closing this issue.

Hi there, I had the identical problem today, with a fresh Ubuntu 18 install. I installed Typescript globally, it didn't work. However, reinstalling NPM, did.
sudo apt install npm

Hello everyone!
I had node installed from snap package. I removed that and installed Node from Nodesource's repository: After that (and running npm install npm@latest -g) vue-cli installed correctly. I think snap version was so sandboxed it couldn't actually install stuff to system.
Another option would have been to use Node Version Manager.


I purchased a license, it doesn't seem to work

I purchased a license, plugged in the license value that I got in the PDF. Nothing works.
I change it to GPLV3 and it starts working...
Tried to contact support, but no reply.

Hi, sorry just found your email in my spam folder, I will reply via email.


[Feature] Redesign manifest generation for helm charts

Currently, for generation of manifests from helm charts, we use Helm.generate_manifest_from_templates function, which creates temp_template.yml file with all resources.
There are two problems with this:

Helm template creates unneeded information: notes, helm-specific resources. That makes it harder to parse created manifest and requires additional code to handle removal of this info.
temp_template.yml is a confusing name for a file with manifests for resources in Kubernetes. Additionally, that file is being created multiple times: in cnfs/<release_name>/temp_template.yml  (seems intended and logical), and in cnfs/temp_template.yml, which doesn't make much sense. That seems to be happening due to call of export_manifest in generate_config.cr during setup process.

Proposed solution:

Create function for gathering manifest from helm deployment based on helm get manifest.
Replace Helm.generate_manifest_from_templates function, remove or rename of all template-related functionality and code.
Rename of temp_template.yml to something reasonable and less confusing (i.e. - generated_manifest.yml)
Fix export_manifest usage (no manifest file should be created in cnfs directory)

Issue is solve in PR: https://github.com/cnti-testcatalog/testsuite/pull/2150


OCPBUGS-34690: Rebase etcd 3.5.14 openshift 4.16

This PR rebases etcd 3.5.14 into openshift-4.16.
After rebasing, running make locally produce
SUCCESS: etcd_build (GOARCH=amd64)
./bin/etcd --version
etcd Version: 3.5.14
Git SHA: b8e830c20
Go Version: go1.21.10
Go OS/Arch: darwin/amd64
./bin/etcdctl version
etcdctl version: 3.5.14
API version: 3.5
./bin/etcdutl version
etcdutl version: 3.5.14
API version: 3.5

This PR drops go toolchain in this commit directive since the image stream in ci still on go1.20
cc @openshift/openshift-team-etcd

/payload 4.16 nightly informing

/payload 4.16 nightly blocking

/retest-required

/assign @geliu2016

/label cherry-pick-approved

/retest-required

/payload 4.16 nightly blocking

/payload 4.16 nightly informing

/retest-required

We've landed master in https://github.com/openshift/etcd/pull/273
/remove-label jira/invalid-bug
/label jira/valid-bug
/hold

/hold cancel
4.16.0 is done, let's merge this

@soltysh I think you have to hit the merge button :rofl: the branch config wasn't found again


Inquiry on Using Custom Mesh in SS 2.0 and Related File Formats

Hi, @ChanganVR ,
I would like to seek further clarification regarding the utilization of my custom mesh in SS 2.0. I have created a quite simple mesh using the code below and generated a JSON file containing semantic labels for the mesh, such as 'floor' and 'ceiling'.
Nevertheless, it appears that these semantic labels are not functioning as expected. Despite SS being able to simulate RIRs, the absorption properties of the acoustic materials do not seem to be worked. I have modified the absorption coefficients of the acoustic materials corresponding to the semantic labels 'floor', 'ceiling', and 'wall' to 0.99 to test their functionality, but without success.
I would be grateful if you could provide guidance on the following questions:

How can I incorporate acoustic properties into my custom mesh?

Could you kindly explain the purpose of the JSON file in the mp3d data (17DRP5sb8fy)? It includes .house, _semantic.ply, and .navmesh files. To my knowledge, the PLY format does not support semantic information. I am interested in understanding the roles of .house and _semantic.ply files and the procedure for assigning semantic label information to my custom GLB mesh file.

Is there any example format of JSON to assign semantic information to my custom and simple GLB mesh?

Thank you for your time and assistance. I look forward to your insights on this matter.
p.s. I kindly request your understanding, as my primary expertise is in acoustics and audio, and I am fairly new to mesh-related concepts and formats. Any guidance or resources you could provide would be greatly appreciated.
## code for build mesh ##
import trimesh
import numpy as np

all_corners3d = np.array([
    [-3, -3, -3],
    [3, -3, -3],
    [3, 3, -3],
    [-3, 3, -3],
    [-3, -3, 3],
    [3, -3, 3],
    [3, 3, 3],
    [-3, 3, 3]
])

floor_faces = np.array([
    [0, 1, 2, 3],
])
ceiling_faces = np.array([
    [4, 5, 6, 7],
])
side_faces = np.array([
    [0, 1, 5, 4],
    [1, 2, 6, 5],
    [2, 3, 7, 6],
    [3, 0, 4, 7]
])

floor_mesh = trimesh.Trimesh(vertices=all_corners3d, faces=floor_faces)
ceiling_mesh = trimesh.Trimesh(vertices=all_corners3d, faces=ceiling_faces)
side_mesh = trimesh.Trimesh(vertices=all_corners3d, faces=side_faces)

mesh = floor_mesh + ceiling_mesh + side_mesh

metadata = {
    "floor": {
        "id": list(range(len(floor_faces))),
        "label": "floor",
    },
    "ceiling": {
        "id": list(range(len(floor_faces), len(floor_faces) + len(ceiling_faces))),
        "label": "ceiling",
    },
    "wall": {
        "id": list(range(len(floor_faces) + len(ceiling_faces), len(floor_faces) + len(ceiling_faces) + len(side_faces))),
        "label": "wall",
    }
}

mesh.metadata = metadata

mesh.export("test_mesh.glb")
with open("test_mesh_metadata.json", "w") as json_file:
    json.dump(mesh.metadata, json_file)

## code for RIR simulation ##
import quaternion
import habitat_sim.sim
import numpy as np
import matplotlib.pyplot as plt

backend_cfg = habitat_sim.SimulatorConfiguration()
backend_cfg.scene_id = 'test_mesh.glb'
backend_cfg.scene_dataset_config_file = 'test_mesh_metadata.json'
backend_cfg.load_semantic_mesh = True
backend_cfg.enable_physics = False

agent_cfg = habitat_sim.agent.AgentConfiguration()
cfg = habitat_sim.Configuration(backend_cfg, [agent_cfg])
sim = habitat_sim.Simulator(cfg)

audio_sensor_spec = habitat_sim.AudioSensorSpec()
audio_sensor_spec.uuid = "audio_sensor"
audio_sensor_spec.enableMaterials = False # make sure _semantic.ply file is in the scene folder
audio_sensor_spec.channelLayout.type = habitat_sim.sensor.RLRAudioPropagationChannelLayoutType.Mono
audio_sensor_spec.channelLayout.channelCount = 1
audio_sensor_spec.acousticsConfig.sampleRate = 8000
audio_sensor_spec.acousticsConfig.direct = False #in our src/mic configuration, we do not need direct sound
audio_sensor_spec.acousticsConfig.indirect = True
audio_sensor_spec.acousticsConfig.indirectRayCount = 5000
audio_sensor_spec.acousticsConfig.diffraction = True
# audio_sensor_spec.acousticsConfig.transmission = False
audio_sensor_spec.acousticsConfig.meshSimplification = True
audio_sensor_spec.acousticsConfig.globalVolume = 1.
audio_sensor_spec.acousticsConfig.threadCount = 8
audio_sensor_spec.position = [0., 0., 0.] #do not need sensor's position on agent robot

sim.add_sensor(audio_sensor_spec)
audio_sensor = sim.get_agent(0)._sensors["audio_sensor"]
audio_sensor.setAudioSourceTransform([0., 0., 0.]) #source position located at origin
audio_sensor.setAudioMaterialsJSON("utils/mp3d_material_config.json") # absorption coefficients of acoustic materials that has label floor, ceiling, and wall are 0.99

# ring-array microphone array that has 10 cm radius from source
mic_pos = np.array([
    [ 5.00000000e-02,  8.66025404e-02,  6.12323400e-18],
    [-5.00000000e-02,  8.66025404e-02,  6.12323400e-18],
    [-1.00000000e-01,  1.22464680e-17,  6.12323400e-18],
    [-5.00000000e-02, -8.66025404e-02,  6.12323400e-18],
    [ 5.00000000e-02, -8.66025404e-02,  6.12323400e-18],
    [ 1.00000000e-01, -2.44929360e-17,  6.12323400e-18]
])
obs = np.zeros((mic_pos.shape[0], 1024)) # [6 mics, rir_length:1024]

agent = sim.get_agent(0)
agent_state = agent.get_state()

for now_mic in range(mic_pos.shape[0]):
    agent_state.position = mic_pos[now_mic, :]
    agent.set_state(agent_state)
    obs[now_mic] = np.array(sim.get_sensor_observations()["audio_sensor"]).squeeze()[:rir_len]

for i in range(mic_pos.shape[0]):
    plt.subplot(mic_pos.shape[0], 1, i+1)
    plt.plot(obs[i, :])
plt.savefig('test_rir.png', dpi=300)

Hi @iyeon915 sorry for the late reply. To debug this, I think the first step is to make sure that the installation is correct and that you can modify the acoustics attributes for existing supported datasets. As mentioned in the other issue (we're still investigating why the materials do not work for HM3D), the material customization should work for MP3D and Gibson. And for example, if you change the coefficients for these environments, you should see the behavior changes accordingly.
Once it works, you can modify your mesh and semantic file accordingly to be close to the format of them in order to be loaded and used by SS 2.


Pb related to PR 209

when the security dialog related to PR 209 (https://github.com/dinsic-pim/tchap-android/pull/209) is triggered:
1/on some phones buttons are invisibles so it seems that we can't do anything
2/The "ne plus me prevenir" option doesn't seem to work

The first point will be fixed by #502.
About the second point (related to the option "Ne plus me prévenir") the dialog may appear twice because there are 2 checks handled separately: one for the accessibility service and another for the notification listener. The second one has been disabled by #339, so presently this option is working correctly.


Add hub-addon docs for policy framework

Updates app to use hub-addon command:

https://github.com/open-cluster-management-io/clusteradm/pull/175

Adds policy-framework clusteradm command:

https://github.com/open-cluster-management-io/clusteradm/pull/170

Fixes some broken links

/hold for clusteradm PRs to merge and its latest release to contain these changes

/hold

/unhold
This is ready for review since clusteradm was released with the changes.


Add esbuild

Rewrites build to use esbuild for bundling JavaScript and CSS.

Rewrites build to use esbuild for bundling JavaScript and CSS.


Completed adding all Flowtypes to more Selector files

Issues in focus: #2971, #3166
As suggested in #3357, I added Flowtypes to all of the selector files that lack them(navSelectors, userSelectors, narrowsSelectors).
Tests ran:

[x] yarn run test
[x] npm run prettier-full

Separately:

yarn run test

Do you recall where you saw that command? It is an obsolete alias of a better command :smile: , namely tools/test. So I'd like to update any sources that are still recommending the alias.

npm run prettier-full

I think perhaps I saw @jainkuniya mention this one to you. This is also an obsolete alias:
$ git grep prettier-full package.json
[...]
package.json:    "prettier-full": "tools/fmt --all",

So tools/fmt --all will do the same thing but more directly.
But also, take a look at the help message for that script:
$ tools/fmt --help
usage: tools/fmt [--all]

Options:
  --all       Run on all files (default: only files changed in this
              branch, as found by `tools/info changed-files`.)

So just plain tools/fmt will do the same thing on all the files you've touched, which is usually much faster.
But you don't even need to run it unless some files actually need reformatting. If tools/test passes, that means the files are formatted correctly already.


[SPARK-37534][BUILD] Bump dev.ludovic.netlib to 2.2.1

What changes were proposed in this pull request?
Bump the version of dev.ludovic.netlib from 2.2.0 to 2.2.1. This fixes a computation bug in sgemm. See [1]. Diff is [2]
[1] https://github.com/luhenry/netlib/issues/7
[2] https://github.com/luhenry/netlib/compare/v2.2.0...v2.2.1

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Can one of the admins verify this patch?

ok to test

@luhenry mind filling other sections in the PR description?

@HyukjinKwon I updated it. Is it enough details, or should I add some more?

👍

Test build #145899 has started for PR 34797 at commit eb6f8cc.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50374/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50374/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50374/

Test build #145899 has finished for PR 34797 at commit eb6f8cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145899/

Can one of the admins verify this patch?