Add Adler32 SSSE3 and AVX2 variants

These implementations are based on work on a Cloudflare zlib fork by Brian Bockelman @bbockelm.

https://github.com/bbockelm/zlib/tree/adler32_vectorized
https://sft.its.cern.ch/jira/browse/ROOT-8465
https://indico.cern.ch/event/754335/contributions/3166227/attachments/1733712/2803236/ROOT_I_O_compression_algorithms-DIANA1.pdf

The SSSE3 detection code for CMake and configure is from https://github.com/mtl1979/zlib-ng/commit/7d2b9e9555c1271999027b6e7d2372e255c08ea8.
I ran benchmarks against the Adler32 variants using Google benchmark:

https://gist.github.com/nmoinvaz/1bf9e4098fe6399a14f829957c2123f8

I know that the code for both variants need to be cleaned up. I am looking for reviewers to help decide the best way to do that.

Codefactor is quite annoying in configure script..

I found quite a lot of possible optimizations in my version... If I drop support for SSE3 then the code gets a lot cleaner...

Rebased.

Two test runs:

@nmoinvaz this is very exciting. This should also accelerate decompression, which you can test with my c_decompress.py. Since the Adler32 computation is identical for compression and decompression, and decompression is faster (though single threaded) I suspect the proportional speedup will be even clearer for decompression. I would be interested to see what @Dead2 's single-threaded benchmark shows for this PR.

@nmoinvaz does the .gz format use Adler32 or only CRC32? I know that Adler32 is used by the .z format (compress), but not sure it is used in .gz (gzip). If gzip does not employ Adler32, you will need to generate .z format files. With pigz, you would need to add -z during compression:
  -z, --zlib           Compress to zlib (.zz) instead of gzip format

and @Dead2 would need to modify minigzip to support zlib format to see a benefit in his single-threaded suite.

Looks like gzip format uses CRC32 in footer. The body of gzip format is DEFLATE. Zlib stream uses Adler32 in footer. The body of Zlib stream is also DEFLATE. So the speed may only improve when using Zlib stream. To produce zlib stream windowBits must be 15 or MAX_WBITS.
So you may be right that I was not producing zlib stream in my initial results.
Here are the results for c_decompress across multiple runs with -z argument:
Method                       ms       mb/s
pigzCloudflare.exe           6619   207.46
pigzng.exe                   5750   238.80
pigznmoinvaz.exe             5789   237.20

Method                       ms       mb/s
pigzCloudflare.exe           6591   208.33
pigzng.exe                   5891   233.10
pigznmoinvaz.exe             5685   241.52

Method                       ms       mb/s
pigzCloudflare.exe           6235   220.24
pigzng.exe                   5889   233.18
pigznmoinvaz.exe             5612   244.68

On a side note it appears zlib is calling adler32 function just to set initial hash value which is always 1 when we call functable.adler32(0L, NULL, 0); in multiple places. We can easily just set it to 1 or in our adler32_stub return 1 when buf is NULL.

@nmoinvaz Such a "return 1 when buf is NULL" should probably be in a define to avoid confusion, but sounds like a good idea.

You mean like #define ADLER32_INITIAL_VALUE (1) and then strm->adler32 = ADLER32_INITIAL_VALUE;?

Yes, exactly like that. Better name than the one I was thinking of too (ADLER32_HASH_EMPTY).

Here is a test run using -z command line arg:

It is really hard to tell since results are not consistent (at least not on my machine). For example, here I copied pigzCloudflare and had it run at the beginning and end and results are a bit strange. @neurolabusc

@Dead2's results may more consistent results, but minigzip would need to be modified to produce zlib format.

@nmoinvaz I think that parallel workloads are often a bit less stable. I created a single threaded benchmark that you should provide more reliable results. It uses the Silesia corpus - which appears to show odd behavior at the extreme compression levels. You can easily adapt this to compile your custom versions of zlib-ng. Unfortunately, it does not test the Cloudflare zlib, as the minigzip in that distribution does not support the -k option. Regardless, I think you have now caught up to CloudFlare and going forward you will want to compare different variants of zlib-ng.

Nice work @neurolabusc! I have made some comments on the initial commit of your benchmark that might be worth taking a look at. You should also be able to test level 1 with minigzip without a problem. It is only with pigz that I have noticed deflate_quick has a problem..

Here are my results (using develop branch):
CompressMethod  Level   Min     Mean    Max     mb/s    %
minigzgcc.exe   1       2648    2771    2895    80      47.70
minigzgcc.exe   2       3646    3702    3757    58      35.54
minigzgcc.exe   3       3838    3851    3864    55      34.22
minigzgcc.exe   4       4236    4242    4248    50      32.95
minigzgcc.exe   5       4441    4461    4480    48      32.67
minigzgcc.exe   6       5023    5182    5340    42      32.51
minigzgcc.exe   7       6974    7065    7156    30      33.61
minigzgcc.exe   8       9846    9880    9915    22      33.52
minigzgcc.exe   9       13188   13455   13721   16      33.51
CompressMethod  Level   Min     Mean    Max     mb/s    %
minigzmsvc.exe  1       1667    1692    1717    127     47.70
minigzmsvc.exe  2       2519    2550    2581    84      35.54
minigzmsvc.exe  3       2907    2934    2960    73      34.22
minigzmsvc.exe  4       3667    3734    3800    58      32.95
minigzmsvc.exe  5       3670    3710    3750    58      32.67
minigzmsvc.exe  6       4214    4314    4414    50      32.51
minigzmsvc.exe  7       5739    5835    5931    37      33.61
minigzmsvc.exe  8       8183    8190    8198    26      33.52
minigzmsvc.exe  9       10915   10926   10937   19      33.51

@nmoinvaz the poor showing of gcc relative to mdvc is surprising. I updated my scripts with your comments and added an optional test of CloudFlare. Surprisingly, on my Linux system zlib-ng performs better with Clang than GCC (mirroring your findings) while the reverse is true for CloudFlare zlib. I know that zlib-ng defaults to -O2 while CloudFlare zlib used -O3, so perhaps this explains the observed pattern. For your Windows data, the difference in compilers is really dramatic.

gcc is generally bad at optimizing code without explicitly setting target processor... This is because AMD and Intel have slight differences in how some instructions behave and gcc generally optimizes for AMD because that means same code works for processors made by both manufacturers. That however results in speed penalty on Intel processors.
When I worked with fixing optimization issues on gcc, I noticed that register intensive code makes gcc spill registers to memory instead of reordering the code so register spill would not be necessary.
Increasing optimization level can help to decrease speed penalty in some cases but it might also introduce more speed penalties due to gcc picking wrong optimization for some code blocks.

Rebased


Google Router distance and duration wrong for single route response

Here's what I did
Google Directions API with single route and multiple legs.

Here's what I got
I got values for distance and duration only from last leg instead of sum of all legs.

Here's what I was expecting
I was expecting the distance and duration values to be the sum of all legs.

Here is the fix:
https://github.com/gis-ops/routingpy/pull/108

Merged in to master.


Error of Makerfabs 16Bit Parallel 3.5" ILI9488 - ESP32-S3

Problem

Lots of error showed in serial monitor.
After printing out the errors, the device will reset itself.
The display does not turn on.

Situation
I am using the ESP32-S3 Parallel TFT with Touch 3.5'' ILI9488.
First, I modified the device selection in main.hpp to include only my device, and I did not modify anything else.
/********************DEVICE SELECTION ******************/
/* Enable one of the devices from below (shift to bsp selection later) */
// #include "conf_WT32SCO1.h"              // WT32-SC01 (ESP32)

// WT32-SC01 Plus (ESP32-S3 + 8Bit Parellel) with SD Card, Audio support
// #include "conf_WT32SCO1-Plus.h"

// Makerfabs ESP32S335D (ESP32-S3 + 16Bit Parellel) with SD Card, Audio support
#include "conf_Makerfabs_S3_PTFT.h"

// Makerfabs ESP32S335D (ESP32-S3 + SPI) with SD Card, Audio support
// #include "conf_Makerfabs_S3_STFT.h"
/********************************************************/

Then, I followed Flash section of README.md
Flash log
Serial port /dev/cu.usbserial-026DC87A
Connecting....
Chip is ESP32-S3 (revision v0.1)
Features: WiFi, BLE
Crystal is 40MHz
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 460800
Changed.
Configuring flash size...
Flash will be erased from 0x00000000 to 0x00005fff...
...
Compressed 20832 bytes to 13280...
Writing at 0x00000000... (100 %)
Wrote 20832 bytes (13280 compressed) at 0x00000000 in 0.6 seconds (effective 261.8 kbit/s)...
Hash of data verified.
Compressed 2002688 bytes to 1127053...
Writing at 0x00010000... (1 %)
...
...
...
Writing at 0x0064e59a... (100 %)
Wrote 524288 bytes (169669 compressed) at 0x00610000 in 5.7 seconds (effective 739.3 kbit/s)...
Hash of data verified.

Leaving...
Hard resetting via RTS pin...
Done

After flashing, I could see LOGs from the board through serial monitor, which indicates the flash is successful.
However, there are the following three problems:

Lots of error showed in serial monitor.
After printing out the errors, the device will reset itself.
The display does not turn on.

Error log
--- idf_monitor on /dev/cu.usbserial-026DC87A 115200 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
5fch (673276)ESP-ROM:esp32s3-20210327
Build:Mar 27 2021
rst:0x1 (POWERON),boot:0xb (SPI_FAST_FLASH_BOOT)
SPIWP:0xee
mode:DIO, clock div:1
load:0x3fce3810,len:0x1684
load:0x403c9700,len:0xbe8
load:0x403cc700,len:0x2e98
entry 0x403c9904
I (25) boot: ESP-IDF v5.0-dirty 2nd stage bootloader
I (25) boot: compile time 12:10:24
I (25) boot: chip revision: v0.1
I (27) boot_comm: chip revision: 1, min. bootloader chip revision: 0
I (34) boot.esp32s3: Boot SPI Speed : 80MHz
I (39) boot.esp32s3: SPI Mode       : DIO
I (43) boot.esp32s3: SPI Flash Size : 8MB
I (48) boot: Enabling RNG early entropy source...
I (54) boot: Partition Table:
I (57) boot: ## Label            Usage          Type ST Offset   Length
I (64) boot:  0 nvs              WiFi data        01 02 00009000 00004000
I (72) boot:  1 otadata          OTA data         01 00 0000d000 00002000
I (79) boot:  2 phy_init         RF data          01 01 0000f000 00001000
I (87) boot:  3 factory          factory app      00 00 00010000 00200000
I (94) boot:  4 ota_0            OTA app          00 10 00210000 00200000
I (102) boot:  5 ota_1            OTA app          00 11 00410000 00200000
I (109) boot:  6 storage          Unknown data     01 82 00610000 00080000
I (117) boot: End of partition table
I (121) boot: Defaulting to factory image
I (126) boot_comm: chip revision: 1, min. application chip revision: 0
I (133) esp_image: segment 0: paddr=00010020 vaddr=3c130020 size=a45fch (673276) map
I (262) esp_image: segment 1: paddr=000b4624 vaddr=3fc99100 size=04c5ch ( 19548) load
I (267) esp_image: segment 2: paddr=000b9288 vaddr=40374000 size=06d90h ( 28048) load
I (274) esp_image: segment 3: paddr=000c0020 vaddr=42000020 size=12ac0ch (1223692) map
I (496) esp_image: segment 4: paddr=001eac34 vaddr=4037ad90 size=0e290h ( 58000) load
I (509) esp_image: segment 5: paddr=001f8ecc vaddr=50000000 size=00010h (    16) load
I (518) boot: Loaded app from partition at offset 0x10000
I (519) boot: Disabling RNG early entropy source...
I (530) esp_psram: Found 2MB PSRAM device
I (531) esp_psram: Speed: 40MHz
I (531) cpu_start: Pro cpu up.
I (531) cpu_start: Starting app cpu, entry point is 0x403755e0
0x403755e0: call_start_cpu1 at /Users/hays/esp/esp-idf/components/esp_system/port/cpu_start.c:142

I (0) cpu_start: App cpu up.
I (957) esp_psram: SPI SRAM memory test OK
I (966) cpu_start: Pro cpu start user code
I (966) cpu_start: cpu freq: 160000000 Hz
I (966) cpu_start: Application information:
I (969) cpu_start: Project name:     ESP32-TUX
I (974) cpu_start: App version:      0.16.0
I (979) cpu_start: Compile time:     Dec  5 2022 12:10:09
I (985) cpu_start: ELF file SHA256:  959501bcf6829e98...
I (991) cpu_start: ESP-IDF:          v5.0-dirty
I (996) heap_init: Initializing. RAM available for dynamic allocation:
I (1004) heap_init: At 3FCB0070 len 000396A0 (229 KiB): D/IRAM
I (1010) heap_init: At 3FCE9710 len 00005724 (21 KiB): STACK/DRAM
I (1017) heap_init: At 3FCF0000 len 00008000 (32 KiB): DRAM
I (1023) heap_init: At 600FE010 len 00001FF0 (7 KiB): RTCRAM
I (1030) esp_psram: Adding pool of 2048K of PSRAM memory to heap allocator
I (1038) spi_flash: detected chip: gd
I (1042) spi_flash: flash io: dio
W (1045) spi_flash: Detected size(16384k) larger than the size in the binary image header(8192k). Using the size in the binary image header.
I (1061) sleep: Configure to isolate all GPIO pins in sleep state
I (1066) sleep: Enable automatic switching of GPIO sleep configuration
I (1073) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (1083) esp_psram: Reserving pool of 32K of internal memory for DMA/internal allocations
E (1093) ESP32-TUX:
Firmware Ver : 0.16.0
Project Name : ESP32-TUX
IDF Version  : v5.0-dirty

Controller   : esp32s3 Rev.1
CPU Cores    : Dual Core
CPU Speed    : 160Mhz
Flash Size   : 8MB [external]
PSRAM Size   : 2MB [external]
Connectivity : 2.4GHz WIFI/BLE

I (1133) ESP32-TUX: Initializing SPIFFS
I (1183) ESP32-TUX: Partition size: total: 474641, used: 282375
I (1183) ESP32-TUX: Initializing SD card
I (1183) ESP32-TUX: Initializing SPI BUS
I (1183) ESP32-TUX: Mounting filesystem
I (1193) gpio: GPIO[1]| InputEn: 0| OutputEn: 1| OpenDrain: 0| Pullup: 0| Pulldown: 0| Intr:0
I (1203) sdspi_transaction: cmd=52, R1 response: command not supported
I (1243) sdspi_transaction: cmd=5, R1 response: command not supported
I (1263) ESP32-TUX: Filesystem mounted
Name: SD16G
Type: SDHC/SDXC
Speed: 20 MHz
Size: 15112MB
CSD: ver=2, sector_size=512, capacity=30949376 read_bl_len=9
SSR: bus_width=1

assert failed: lcd_ll_select_clk_src /IDF/components/hal/esp32s3/include/hal/lcd_ll.h:67 (false)

Backtrace: 0x403761aa:0x3fcf3c80 0x4037ea39:0x3fcf3ca0 0x40385ea9:0x3fcf3cc0 0x42028a02:0x3fcf3de0 0x42028e85:0x3fcf3e20 0x42027f2c:0x3fcf3e50 0x421214a7:0x3fcf3ef0 0x42025a3b:0x3fcf3f10 0x4202424e:0x3fcf3f30 0x4200ef7f:0x3fcf3f50 0x4212a90b:0x3fcf3fb0 0x40381c71:0x3fcf3fe0
0x403761aa: panic_abort at /Users/hays/esp/esp-idf/components/esp_system/panic.c:412

0x4037ea39: esp_system_abort at /Users/hays/esp/esp-idf/components/esp_system/esp_system.c:135

0x40385ea9: __assert_func at /Users/hays/esp/esp-idf/components/newlib/assert.c:78

0x42028a02: lcd_ll_select_clk_src at /Users/hays/esp/esp-idf/components/hal/esp32s3/include/hal/lcd_ll.h:67
 (inlined by) lcd_i80_select_periph_clock at /Users/hays/esp/esp-idf/components/esp_lcd/src/esp_lcd_panel_io_i80.c:475

0x42028e85: esp_lcd_new_i80_bus at /Users/hays/esp/esp-idf/components/esp_lcd/src/esp_lcd_panel_io_i80.c:152 (discriminator 2)

0x42027f2c: lgfx::v1::Bus_Parallel16::init() at /Users/hays/Github/ESP32-TUX/components/LovyanGFX/src/lgfx/v1/platforms/esp32s3/Bus_Parallel16.cpp:96

0x421214a7: lgfx::v1::Panel_Device::init(bool) at /Users/hays/Github/ESP32-TUX/components/LovyanGFX/src/lgfx/v1/panel/Panel_Device.cpp:60

0x42025a3b: lgfx::v1::Panel_LCD::init(bool) at /Users/hays/Github/ESP32-TUX/components/LovyanGFX/src/lgfx/v1/panel/Panel_LCD.cpp:31

0x4202424e: lgfx::v1::LGFX_Device::init_impl(bool, bool) at /Users/hays/Github/ESP32-TUX/components/LovyanGFX/src/lgfx/v1/LGFXBase.cpp:3099

0x4200ef7f: lgfx::v1::LGFX_Device::init() at /Users/hays/Github/ESP32-TUX/components/LovyanGFX/src/lgfx/v1/LGFXBase.hpp:1138
 (inlined by) app_main at /Users/hays/Github/ESP32-TUX/main/main.cpp:267

0x4212a90b: main_task at /Users/hays/esp/esp-idf/components/freertos/FreeRTOS-Kernel/portable/port_common.c:131 (discriminator 2)

0x40381c71: vPortTaskWrapper at /Users/hays/esp/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:151

ELF file SHA256: 959501bcf6829e98

Rebooting...
ESP-ROM:esp32s3-20210327
Build:Mar 27 2021
rst:0x3 (RTC_SW_SYS_RST),boot:0xb (SPI_FAST_FLASH_BOOT)
Saved PC:0x40375ad1
0x40375ad1: esp_restart_noos_dig at /Users/hays/esp/esp-idf/components/esp_system/esp_system.c:46 (discriminator 1)

At the last 5 lines, the device starts to reboot and the Error-Reboot loop continues on and on.

@hayschan I just upgraded the project to IDF 5.0 which also needs develop branch of LovyanGFX.
LovyanGFX for Parallel TFT is broken for now and you can follow the issue here
SPI devices are working fine for now.

@hayschan As mentioned in that issue workaround, for now the fix is to add the following just before
esp_lcd_new_i80_bus(&bus_config, &_i80_bus);
// add this line
bus_config.clk_src = LCD_CLK_SRC_DEFAULT;

file name
16bit
LovyanGFX\src\lgfx\v1\platforms\esp32s3\Bus_Parallel16.cpp
8bit
LovyanGFX\src\lgfx\v1\platforms\esp32s3\Bus_Parallel8.cpp

Thanks for the help.
I tried to build again today. Before building, I make sure I download the latest code by:

deleting the original directory
git clone --recursive https://github.com/sukesh-ak/ESP32-TUX.git

I also changed to use ESP-IDF v4.4.3. But this time, the build fails. The error log is attached. It is problem related to esp_partition.
Error log
Building in: /Users/hays/eclipse-workspace/ESP32-TUX/build
Configuring in: /Users/hays/eclipse-workspace/ESP32-TUX/build
cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=/Users/hays/esp/esp-idf/tools/cmake/toolchain-esp32s3.cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCCACHE_ENABLE=1 -DIDF_TARGET=esp32s3 /Users/hays/eclipse-workspace/ESP32-TUX
-- Found Git: /usr/bin/git (found version "2.32.1 (Apple Git-133)")
-- Component directory /Users/hays/eclipse-workspace/ESP32-TUX/components/ConfigBase does not contain a CMakeLists.txt file. No component will be added
CMake Warning at /Users/hays/esp/esp-idf/tools/cmake/project.cmake:291 (message):
  enabled ccache in build but ccache program not found
Call Stack (most recent call first):
  CMakeLists.txt:24 (project)

-- The C compiler identification is GNU 8.4.0
-- The CXX compiler identification is GNU 8.4.0
-- The ASM compiler identification is GNU
-- Found assembler: /Users/hays/.espressif/tools/xtensa-esp32s3-elf/esp-2021r2-patch5-8.4.0/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-gcc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Users/hays/.espressif/tools/xtensa-esp32s3-elf/esp-2021r2-patch5-8.4.0/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Users/hays/.espressif/tools/xtensa-esp32s3-elf/esp-2021r2-patch5-8.4.0/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building ESP-IDF components for target esp32s3
-- Checking Python dependencies...
Python requirements from /Users/hays/esp/esp-idf/requirements.txt are satisfied.
Processing 2 dependencies:
[1/2] espressif/fmt (9.1.0)
[2/2] idf (4.4.3)
-- LovyanGFX use components = nvs_flash;efuse;esp_lcd
CMake Error at /Users/hays/esp/esp-idf/tools/cmake/build.cmake:201 (message):
  Failed to resolve component 'esp_partition'.
Call Stack (most recent call first):
  /Users/hays/esp/esp-idf/tools/cmake/build.cmake:227 (__build_resolve_and_add_req)
  /Users/hays/esp/esp-idf/tools/cmake/build.cmake:507 (__build_expand_requirements)
  /Users/hays/esp/esp-idf/tools/cmake/project.cmake:384 (idf_build_process)
  CMakeLists.txt:24 (project)
-- Configuring incomplete, errors occurred!
See also "/Users/hays/eclipse-workspace/ESP32-TUX/build/CMakeFiles/CMakeOutput.log".

cmake --build . -- -v
ninja: error: loading 'build.ninja': No such file or directory
Build complete (0 errors, 0 warnings): /Users/hays/eclipse-workspace/ESP32-TUX/build
Total time taken to build the project: 6,545 ms

This is weird. As far as I know, the esp_partition problem should only relate to projects that need migration to v5.0, as listed by Espressif in their document.

If you are on IDF 4.4.3 you can use this version (just before IDF 5.0 upgrade)
If you are planning to do this, copy sdkconfig.defaults.* files from this branch which has the default values set. Or, you can make changes to the settings using idf.py menuconfig

Sorry, I just found out this comment. I will try this method. Thx

If you are on IDF 4.4.3 you can use this version (just before IDF 5.0 upgrade)
If you are planning to do this, copy sdkconfig.defaults.* files from this branch which has the default values set. Or, you can make changes to the settings using idf.py menuconfig

Sorry, I just found out this comment. I will try this method. Thx

Parallel related bug is fixed today by LovyanGFX. Will update the repo later today with the the fix.

Is it this one ? https://github.com/lovyan03/LovyanGFX/commit/e8baed4f71d6975a9aea552ef9581fc780d42420

Is it this one ? lovyan03/LovyanGFX@e8baed4

Yes.

@hayschan
Project is updated with LovyanGFX fix.
Also check the readme for updated instructions including the link for Wi-Fi provisioning app.
Closing this issue since the bug is fixed and readme is updated with required instructions.


Updating Latest Mimikatz Support

Hello,
Is there a roadmap for upgrading the Mimikatz to latest version by @gentilkiwi which supports Windows 10 Anniversary update & Windows Server 2016 (1607 - build 14393) ?

@c0d3xpl0it will be realising v4.0 hopefully by the end of the month and it will include the latest mimikatz version.
Cheers

Is this issue addressed in v4 release ?

CME v4 and v5 are using Invoke-Mimikatz.ps1 script from Powersploit repo to dump lsass. To get latest version of Invoke-Mimikatz.ps1 use latest binary from cme (check action panel)


Disconnecting client after NatIntroductionSuccess in NAT hole punching scenario

I've met a disconnection scenario, it's quite unstable, but happens not so rarely. I'm using NAT hub server (dotnetcore on Linux) to connect two clients (Android phone and Unity editor on Windows 10) with NAT hole punching, it's quite a sample-like setup (HolePunchServerTest), with almost all listening got from there. In some cases client that is connecting to other client, is like getting NatIntroductionSuccess event, but after that receiving connection request, accepting it and receiving more and more ones. All in all it ends with "connection failed". Maybe later I'll try to reproduce it in some test environment, but that's what I know for that moment. Is that somehow expected? Thanks!
Library version: 0.9.2
Framework: Unity + Unity editor + dotnetcore
OS: Unity: Android, Unity editor: Windows 10, dotnetcore: Linux

There is can be some problems when you try connect simultaneously from both sides (client1 to client2 and client2 to client1). I will look into this.

Running the HolePunchServerTest in LibSample also results in similar behavior.

Running manually from the bin folder works fine. It's deterministic, running F5 debugging it will fail, but running from bin folder it works every time:

@sondreb i know about bug and what cause it. It's just a bit complex to do this in 2 hours :)

@amazedevil @sondreb should be fixed in master. You can check on your sides. Will push into new release a bit later.

Great work, thanks! Gave you a couple of coffee 👍

@sondreb thanks!


icon fix 2

Two separate little fixes.
First commit is the same fix as https://github.com/a-b-street/abstreet/pull/568/commits/d98e2556bc14f445bc725c8f8fd455ccf187403d but for the other challenge: Traffic Signal Survivor.
Second commit  fixes #572
I think eventually we should default to the new day theme for all widgetry apps, but this is slightly non-trivial because game still needs to use pregame and allows overriding the theme in options...
One eventuality that would simplify things is, when we redesign the pre-game sequence, to do so using styles consistent with day theme and just delete the pregame theme all together.

Thanks for the fixes!

I think eventually we should default to the new day theme for all widgetry apps
just delete the pregame theme all together

I agree with both. It's worth noting the pre-game design came from one of the first DemocracyLab hackathons, where some other designers had a go at creating the title screen. (Before that day, you were just dumped into sandbox mode with no context!) Making it use the day/night theme and cleaning up the special case would be great both code- and design-wise.


undefined method `all_build_train_numbers' for nil:NilClass (NoMethodError)

New Issue Checklist

[x ] Updated fastlane to the latest version
[ x] I have read the Contribution Guidelines

Issue Description
download_dsysm failed when updating fastlane to 1.68
Complete output when running fastlane, including the stack trace and command used
/Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/actions/download_dsyms.rb:19:in `run': [!]
> undefined method `all_build_train_numbers' for nil:NilClass (NoMethodError)
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:143:in `block (2 levels) in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:129:in `block in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:128:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:128:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/fast_file.rb:149:in `method_missing'
	from Fastfile:29:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:110:in `try_switch_to_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/fast_file.rb:141:in `rescue in method_missing'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/fast_file.rb:136:in `method_missing'
	from Fastfile:38:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:52:in `block in execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:46:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/runner.rb:46:in `execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/lib/fastlane/command_line_handler.rb:30:in `handle'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/bin/fastlane:38:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.41.0/lib/fastlane_core/ui/fastlane_runner.rb:23:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/bin/fastlane:156:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.68.0/bin/fastlane:162:in `<top (required)>'
	from /usr/local/bin/fastlane:23:in `load'
	from /usr/local/bin/fastlane:23:in `<main>'

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
  lane :upload do
    download_dsyms
    upload_symbols_to_crashlytics(binary_path: "./ios/Crashlytics.framework/uploadDSYM")
  end

Environment
fastlane version (fastlane -v): fastlane 1.68.0
Do you use bundler, rbenv or rvm? no bundler

@anback Thanks for reaching out. We are looking into this! :+1:  Does this happen when you run 'fastlane run download_dsyms'?

yep,
just ran it
Cheers

On 31 Mar 2016, at 16:58, Todd Burner<EMAIL_ADDRESS>wrote:
@anback https://github.com/anback Thanks for reaching out. We are looking into this!  Does this happen when you run 'fastlane run download_dsyms'?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/fastlane/fastlane/issues/3997#issuecomment-203975583

Hey @anback I am going to close this issue as it appears to have been fixed in recent releases. Please feel free to reopen the issue if you are still running into issues! 🐙


[Request] Add fuels for the Railcraft Blast Furnace

Would it be possible to create a handler for adding new fuels to the Railcraft Blast Furnace?

It would be possible to add / remove items to the filter (accepted items) but you can't specify the fuel value for the items.

I know that current fuels in the Blast Furnace have differing fuel values.  Perhaps it uses the default value of the fuel itself?

The blast furnace uses some hard coded fuel values for coal coke, blaze rods and so on. If it doesn't know the fuel value, it will retrieve the value from the vanilla furnace.
So if you want adding new fuels to the railcraft blast furnace, you have to add a valid fuel source for the vanilla furnace and then add this item to the item filter for accepted items.
We could add a handler to manipulate the filter.

Well, it would be possible to edit the vanilla fuel value Railcraft wants to grab. How would you imagine the manipulation @Zixxl?

I original thougt the same way as zixxl that Tailcraft uses vanilla furnace fuel list.
But looking at https://github.com/CovertJaguar/Railcraft/blob/master/src/main/java/mods/railcraft/common/util/crafting/BlastFurnaceCraftingManager.java#L37 it seems the build an own list.
Shouldn't that complicated to modify.

Seems like the Railcraft lib in the repository is outdated. If it includes a list in newer versions, we could add a handler.

fuels = Collections.unmodifiableList(fuel);
Someone really wants to prevent modifications :disappointed:

So it will be possible or not to set new Fuels with the newest Version?

Kind of. I've added the handlers to my dev branch. But you can only modify the filter, it must be a valid fuel item known by the vanilla furnace.

So it can be added to but it's limited to anything that's registered as a fuel for vanilla furnaces?

Exactly, you can burn your sticks for example or remove coal coke as a valid input.
If you want to add custom fuels, you have to register it first with MineTweaker as a vanilla fuel. E.g. you want to use redstone, you can use:
furnace.setFuel(<minecraft:redstone>, 100);

How breaking would it be to register an item as a vanilla fuel, then add it to the furnace, then remove the item as a vanilla fuel?
I'm going to assume Railcraft won't know what to do with the item anymore since it's no longer a fuel, but it was registered as one at the time of being enabled as a furnace fuel.

Sadly doesn't work this way. Railcraft has a list with all the items which can be used as an input. This list can be modified with the changes. But the fuel value will be fetched everytime the fuel will be used. Your method will lead to an exception.

Darn, I was afraid of that.

Cool!  That's functionality enough, I think.  After all, what would be used in a blast furnace as fuel that wouldn't be burnable everywhere else?

@Zixxl this doesn't seem to work very well - it just churns through the fuel in a matter of seconds although I set the burn time to 4000000. Proof

http://pastebin.com/GmYUjSwa
my Error

With error I meant that you should post your script, MT log and a description of the issue.

@Yulife Fixed?

it works for me with Railcraft 9.7.0, Modtweaker latest git version


About Lora checkpoint

In the training process , this code: parser.add_argument('--lora_ckpt', type=str, default='/home/txz/github_code/SAMed/output/sam/results/AISD_512_pretrain_vit_b_epo199_bs12_lr0.005/epoch_159.pth', help='Finetuned lora checkpoint').  Can I think it as the continue training based on exists fintuned  lora version? But I have a bad results.

I did not adopt continue training during the SAM adaptation, but only load the SAM model. Please leave this choice None.

if args.lora_ckpt is not None:
    net.load_lora_parameters(args.lora_ckpt)

this is your code, your learnable parameter concludes lora, mask decoder. and default prompt embedding. so if i just load lora, its SAM parts parameter is not loaded, so has worse result.  right ?

Yes, you are right.

ok, 栓Q

And，Maybe it bothers you a lot, I have 4 RTX 3090, and I set bs = 15, which means batch size is 60. and Max epoch=999. But ,when epoch =19, my dc loss from 0.1 - 0.2 level to 0.4-0.6 level, it just  rises suddenly, and  I can't understand.

i am looking forward to your reply.

ok, thanks a lot


Adds defaultHostname output to Microsoft.Web/sites and Microsoft.Web/staticSites modules

Description
Adds defaultHostname output to Microsoft.Web/sites and Microsoft.Web/staticSites modules. This output is required for Bicep templates that deploy Azure Front Door or App Gateway with App Services, Functions and Static Websites.
Type of Change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)
[X] Update to documentation

Checklist

[X] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[X] My code follows the style guidelines of this project
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation (readme)
[X] I did format my code

Fixes #1788


changed URL of add your profile to automatically scroll to Add profile section in markdown

Description
when Add your profile link is clicked on website, it should automatically scroll to the Add your profile section.
Related Issues
#287
Changes Proposed

changed the URL of the Add your profile

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[ ] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

This small feature will auto scroll for the users, so they don't have to navigate to the section.

@07prajwal2000 Thank you for the contribution.


Anisotropic response bugfix

Removing erroneous factor of 1/4pi from anisotropic responses.

Thanks for finding this bug Alexander. Have you done a sample run with the factor removed to check if recoveries are consistent? Just want to make sure that we are not missing the factor being removed somewhere else in the code or something else that we might have overlooked.

See plots below for consistency check in the data generation.

I also performed a short test run simulating with the pixel-basis anisotropic method and recovering with the ISGWB analysis and see no issues. The corner and spectral plots are below; the posterior is slightly undersampled and was for a short observing duration/constrained frequency band, but the results are unbiased (which is the main thing). I can try the reverse case as well, if you like, but everything is behaving identically.

@criswellalexander Sorry for the late reply and thank you for the plots! The other case would be good to check because all of our published recoveries are with the anisotropic/spherical harmonic model. It would be good to check that everything is consistent and that, for e.g. we haven't missed some other factor somewhere else that was accounting for the 4*pi.

Ah, yeah, good idea to cover all the bases. The sph case is consistent, see plots below for an isotropic signal simulated with the sph basis and recovered with the ISGWB analysis.

I also considered an otherwise identical dataset created with the isotropic routines and recovered with the sph analysis, but this duration is too short to achieve reliable results. It would be good to rerun this case with a 6mo or 1yr duration. That said, while the analysis doesn't produce good quality results and shows some bias, the bias it does show is << 4pi and is a known phenomena for any of the anisotropic analyses without a sufficient duration to "see" the whole sky as the sensitive parts of the LISA antenna patterns sweep across it.

(the truevals aren't showing up because I forgot to alias the model and injection names, but the spectral values should be the same as above)

As you can see, the inferred spatial distribution is far from isotropic, hence the bias:

I've submitted a 6 month run and will provide those results when it finishes.

The 6 month run finished; the results are still poor due to the model misspecification, but they continue to be consistent with having no additional factor of 4pi floating around --- if we did, I would expect to see a large bias in the astrophysical reconstruction. See plots, below.

As an aside, it is interesting to note that these results (with the numpyro sampler) cling to those bimodalities a bit more that what we see with dynesty, as handling multimodalities is a strength of the latter approach.

Thanks Alexander! By model misspecification, do you just mean the fact that the run is anisotropic while the signal is isotropic? In that case, the posterior should still eventually converge to the right values no? Anyway, looks like this numpyro chain hasn't converged, so can restart and continue the sampling a bit more please? Sorry for assigning more work to you but I think it would be good to see one successfully converged run to convince ourselves we didn't miss anything else haha.

I've set it running for another 15k samples. My worry, though, is that we've never actually looked closely at the behavior of the anisotropic search applied to an isotropic background. From the corner plots, the sampler is converging to extremal (and opposite) values of the sph. harm. component amplitudes, presumably trying to cancel each other out; I don't necessarily see that behavior damping out and converging to zero in each. I'll also consider another more in-depth run here while I'm finishing up some dev work for the re-analyses for my thesis, but after that I'll need to be allocating resources to those analyses.
Overall, the behavior of the sph search for an isotropic signal is probably worth investigating as that will be important to understand, but I'm at this point I'm confident that we're not seeing any effects on the order of the 4pi bias. I appreciate the desire for a nice converged run, though :)

@criswellalexander yeah that's a fair argument. And the spectral plots are convincing at any rate. After thinking about it, I do feel comfortable merging this PR.
As for doing anisotropic analysis with an isotropic background, I'm fairly sure I did some way back when we were developing the method haha, and they were consistent with what we expect. The behavior you're seeing could purely be an issue with numpyro. I've been finding that depending on the number of walkers and dimensionality, it's sometimes not very good at converging.


Unhandled lock retrieval error in iRODS delete request accepting

I was reported this failure upon accepting iRODS delete requests:

500 internal server error
 irods_request_accept event in timeline with the status of OK
file still existing on the server

Looking into sentry this appears to be caused by the project being locked by e.g. a landing zone write operation. Apparently we don't handle the exception at all?
What needs to happen is:

Don't raise a 500 (should be self-explanatory eh)
Report error by user via either a Django message if synchronous or app alert if async

See #1499
Can't remember right now whether this was async?

Update the timeline status properly

This should be handled by #1500 as long as we provide the timeline event UUID to taskflowbackend

It seems this has the same root cause as #1496, just with a different outcome. Does not occur as long as the REDIS_URL env var is set and the redis server properly optional, but I need to ensure this is nicely caught and handled.

Fixed, to be merged into dev.


Remove Code Copy + Add GPUs to Main Navigation

@osg-cat It looks like he had it as

My mistake, I misclicked on the close with comment button


add launch script for vscode

[Is your feature request related to a problem? Please describe.
with recommended vscode launch script from electron official docs, breakpoints in the main script is not working.
Describe the solution you'd like
add a working, debuggable launch script for vscode.
Describe alternatives you've considered
add a working, debuggable launch script for webstorm.
Additional context
https://github.com/cawa-93/vite-electron-builder/discussions/541

Just as a kickstart, seems to be done resolved here allready: https://github.com/electron-vite/electron-vite-vue/tree/main/.vscode (they teaser it on the github main page)


Add set of chrono types guarded behind the chrono feature.

Closes #46

Give me any feedback, basically I'm not quite familiar with Rust development and how the Cargo treats the dependencies yet.

Thanks for the PR @xkikeg !
Overall LGTM, I've rebased and tweaked it a little (see review comments above).

Thanks! LGTM.


Added Amazon coding round questions

Added coding round questions asked in Amazon interview for SDE position in Auguest 2021.

Added coding round questions asked in Amazon interview for SDE position in Auguest 2021.

Please fix the typo. Also try adding atleast three questions. Guidelines


Prevent adding extra blank items

It is related to https://github.com/nolimits4web/Swiper/pull/2150
Sorry, I forgot to update the situation that if slides.length can be divided by slidesPerGroup.
In this case, there will be one more blank group in the end.

Thanks


fix: parse ORGS environment variable properly

Ran into the issue fixed by this PR. Would love to see this merged 😄 Thanks!

bump @saied-nawaz @Rucknar

@saied-nawaz


asciidoctor-pdf fails to process a menu macro inside a section title

The following code is processed and styled correctly in asciidoctor with HTML5 output, but asciidoctor-pdf fails to process it:
:experimental:
== menu:File[Open]

I get the following traceback:
Traceback (most recent call last):
	26: from /usr/local/bin/asciidoctor-pdf:23:in `<main>'
	25: from /usr/local/bin/asciidoctor-pdf:23:in `load'
	24: from /var/lib/gems/2.5.0/gems/asciidoctor-pdf-1.5.0.alpha.16/bin/asciidoctor-pdf:31:in `<top (required)>'
	23: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/cli/invoker.rb:112:in `invoke!'
	22: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/cli/invoker.rb:112:in `each'
	21: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/cli/invoker.rb:129:in `block in invoke!'
	20: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1589:in `convert_file'
	19: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1589:in `open'
	18: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1589:in `block in convert_file'
	17: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1473:in `convert'
	16: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor.rb:1361:in `load'
	15: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/document.rb:565:in `parse'
	14: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/parser.rb:96:in `parse'
	13: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/parser.rb:328:in `next_section'
	12: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/parser.rb:290:in `next_section'
	11: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/parser.rb:1605:in `initialize_section'
	10: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/abstract_block.rb:299:in `title'
	 9: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/substitutors.rb:150:in `apply_title_subs'
	 8: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/substitutors.rb:106:in `apply_subs'
	 7: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/substitutors.rb:106:in `each'
	 6: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/substitutors.rb:117:in `block in apply_subs'
	 5: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/substitutors.rb:574:in `sub_macros'
	 4: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/substitutors.rb:574:in `gsub'
	 3: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/substitutors.rb:596:in `block in sub_macros'
	 2: from /var/lib/gems/2.5.0/gems/asciidoctor-<IP_ADDRESS>/lib/asciidoctor/inline.rb:39:in `convert'
	 1: from /var/lib/gems/2.5.0/gems/asciidoctor-pdf-1.5.0.alpha.16/lib/asciidoctor-pdf/converter.rb:118:in `convert'
/var/lib/gems/2.5.0/gems/asciidoctor-pdf-1.5.0.alpha.16/lib/asciidoctor-pdf/converter.rb:2019:in `convert_inline_menu': asciidoctor: FAILED: /home/tiagoma/menu.adoc: Failed to load AsciiDoc document - undefined method `menu_caret_content' for nil:NilClass (NoMethodError)

This could be related to #313, which is in progress.

Confirmed, I have the same issue.

The problem here is that the text of a section or block title is converted before the convert phase. As a result, the PDF theme has not been loaded, so we get a nil object exception. I fixed this by loading the theme lazily so it's available when the processor invokes the method to convert the menu.

This problem is not related to #313.


Typo fix in CONTRIBUTING.md

Just a typo fix in CONTRIBUTING.md

Looking forward to work more on this project.

Thanks!


Mongoose deep thrown error appended messages

Errors that are thrown inside the scope of a Mongoose validators are bound to have some text appended by Mongoose's internals e.g. orders validation failed: client: ERROR_ORDER_CLIENT_NAME_GREATER_THAN_MAX_LENGTH.
Those texts might have the following patterns:
${MODEL_NAME} validation failed: ${INHOUSE_ERROR},
sometimes multiple validation errors can happen at the same transaction:
orders validation failed: client: ERROR_ORDER_CLIENT_NAME_GREATER_THAN_MAX_LENGTH, operator: ERROR_ORDER_OPERATOR_INVALID.

Fixed at #3


Email

Add email verification to make it more safer and less chance of alt accounts

Add a way so it doesn't let you do anything except settings without verifying your email


⚠ Bofrost.nl has degraded performance

In 0078596, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 807 ms

Resolved: Bofrost.nl performance has improved in 2cddc79.


Failed installing cvat on ubuntu 18.04

I try to install cvat on ubuntu 18.04. but the installation procedure faild at this point
Successfully built 6589b39062ca
Successfully tagged cvat:latest
Building cvat_ui
Step 1/17 : FROM ubuntu:18.04 AS cvat-ui
---> 7698f282e524
Step 2/17 : ARG http_proxy
---> Using cache
---> 7363be2f907b
Step 3/17 : ARG https_proxy
---> Using cache
---> fd397f6e388f
Step 4/17 : ARG no_proxy
---> Using cache
---><PHONE_NUMBER>4b
Step 5/17 : ARG socks_proxy
---> Using cache
---><PHONE_NUMBER>6b
Step 6/17 : ENV TERM=xterm     http_proxy=${http_proxy}       https_proxy=${https_proxy}     no_proxy=${no_proxy}     socks_proxy=${socks_proxy}
---> Using cache
---> 2dfc665d1b08
Step 7/17 : ENV LANG='C.UTF-8'      LC_ALL='C.UTF-8'
---> Using cache
---> fc0b353e2ba2
Step 8/17 : RUN apt update && apt install -yq nodejs npm curl &&     npm install -g n && n 10.16.3
---> Running in 327556caa49b
WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
 Mirror sync in progress? [IP: <IP_ADDRESS> 80]
Hashes of expected file:

Filesize:944473 [weak]
SHA256:788d8f45d75965dd2488c7e7544abf405cda2d344e1aafd52173605a87545c6b
SHA1:77c8a594b696d2b4c1b57d648b67ab3805fac60d [weak]
MD5Sum:8526e702a621000576befde8d0c18dc1 [weak]
Release file created at: Tue, 10 Sep 2019 08:16:28 +0000
Fetched 16.1 MB in 13s (1256 kB/s)
Reading package lists...
E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/bionic-updates/main/binary-amd64/Packages.gz  File has unexpected size (944475 != 944473). Mirror sync in progress? [IP: <IP_ADDRESS> 80]
Hashes of expected file:
- Filesize:944473 [weak]
- SHA256:788d8f45d75965dd2488c7e7544abf405cda2d344e1aafd52173605a87545c6b
- SHA1:77c8a594b696d2b4c1b57d648b67ab3805fac60d [weak]
- MD5Sum:8526e702a621000576befde8d0c18dc1 [weak]
Release file created at: Tue, 10 Sep 2019 08:16:28 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.
ERROR: Service 'cvat_ui' failed to build: The command '/bin/sh -c apt update && apt install -yq nodejs npm curl &&     npm install -g n && n 10.16.3' returned a non-zero code: 100

@marcobevih2o
Is this error reproduced in every built?

i solved installing nodejs before start steps in the installation guide

@marcobevih2o , I don't think that your step helped your resolve your problems. It was a network issue. I will close the issue for now. Let's see if somebody else has a similar problem.

why not just uploading your final official successful image on the docker hub even alpha edition? Then we can just pull it.

@QuarTerll
Unfortunately it isn't simple because of bureaucracy and legal issues.


Handle Pointer.malloc(0)

This should probably raise. Extracted from #1342

Or maybe not

I'd tend to say it should raise, we could have the Slice case handled there by returning a Null object, Slice::Empty(T) or so.

How about:

Pointer(T).malloc(0) raises
Pointer(T).malloc_empty works

?

And :+1: to null object idea for slice too

I don't think so. Using pointers is an unsafe operation so you must know what are you doing IMO. Returning a null object means now there is always a union and that means slow down on such critical and primitive objects.
If you malloc 0 then it's probably a corner case after the result of some calculation (or a bug, but then just fix it) and that means the code will never try to use the pointer at all.
So, for me malloc(0) should return a null pointer.

Yes, malloc(0) can result from some math and for me it should be valid. Also, one expects to be able to call GC.free on that pointer because Pointer.malloc asks from the GC. Right now the GC does allocate some memory for the case of 0, so that memory can be safely freed. Returning Pointer.null in this case will break that contract (if we want that obey that contract). So for me the current behaviour is good.

But when do you manually allocate memory? If you intend to pass it to an external library. Which library does expect to be given a pointer it can not write anything to or read anything from? Why would it take the pointer in the first place in that case?

Yes it allocates the minimum which is a word size.
I was thinking an example of where a null pointer would me more efficient. For example, if a class has an array member, which is seldom used, but instead of making it nilable, initialize it with Array(T).new(0). That will avoid to allocate the buffer and only allocated when needed.

There are two viewpoints here: making the runtime faster, or warning the developer about a bug. I like both, but in this case I'm not sure we're helping the developer too much.
@jhass many libraries receive an optional buffer. Also, it would crash if you didn't reserve enough memory. You must probably have to specify the buffer size anyway, and the buffer is smaller than the size specified it won't work, even if the size is not zero.

Code that calls malloc(0), as already said, has likely calculated it from need, and since the need is zero, no accesses will be made. So whatever is the most efficient way of letting it run, I vote for. Raising would be erroneous behaviour afaic.

Raising or returning nil makes no sense. Performance is paramount.

I'm closing this. Pointer.malloc should return a pointer that you can later call realloc on. Some classes, like Array, use an explicit Pointer.null for the zero case and later consider this case separately.


Libravatar, although enabled at install time, is not working

Description
I've deployed a new Gitea from current main branch v1.19.0-dev-263-gefa708501 and libravatar lookup is not occurring.
It may or may not be related to the recent deprecation of app.ini setting. The install procedure allows you to configure it and writes it into app.ini but evidently doesn't write it in database where it now belongs ?
Gitea Version
v1.19.0-dev-263-gefa708501
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
From build tree
Database
PostgreSQL

Things only work after I enable federated avatar from the admin screen, where it appears as disabled despite the corresponding checkbox being checked at install time. The database table system_setting did not contain any record with setting_key = picture.enable_federated_avatar which was taken by Gitea as meaning DISABLED . I guess the previous behavior was for the default to be ENABLED judging from the install screen checkbox being checked by default.

Another problem (needs a separate ticket?) is that you can NOT re-enable gravatar after disabling it from the admin screen, as it has no effect (reloading the page keeps shows the control turned on even if you try to turn it off)

I'm re-doing the process from scratch, from empty database and no app.ini -- doing so I realized that "libravatar" was NOT enabled by default, so I must have done that myself.

The libravatar enabling at install time is fixed by #22326 so I'm closing this. Will file a new ticket for the inability to change configuration.


Remove SQLDebugging class

This is partially related to the project merge, partially cleanup. It's a breaking change (since I'm proposing the removal of a public API surface) but I don't think the public API surface is ever actually used. I was hoping to make this change after the removal of SQL 2000 support, but the major version bump is a pretty rare opportunity to make this kind of breaking change to the API surface, so I've pulled it forward.
System.Data.SqlClient in the .NET Framework contains a COM-visible SQLDebugging class, and this was ported over to the .NET Framework version of Microsoft.Data.SqlClient. I feel that porting this over was originally problematic, because the COM GUID associated with this class wasn't changed (and thus, someone registering the M.D.S DLL would have overwritten part of the .NET Framework's COM registration)
Looking at the functionality of this class though, we essentially see this act as a relay between the COM ISQLDebug interface and a memory-mapped file ("Global\SqlClientSSDebug" + [process ID]). A version of SQL Server would instantiate the SQLDebugging class via COM, call ISQLDebug.SQLDebug and have these values written out to the memory-mapped file. The client half of this is still present (link): if a SqlConnection is connected to a SQL 2000 or a SQL 7.0 instance and the debugger is attached, it'll read data from the memory-mapped file and execute the sp_sdidebug stored procedure with these values.
This would only work if the SQL 2000 instance was running locally. The OS requirements for SQL 2000 and for .NET Framework 4.6.2 are mutually exclusive, so this part of the API would never be supportable. The API also isn't present in the .NET Core library, so it contributes (slightly) to the project merge.
I've left the client-side part of this (and associated PInvoke cleanups) alone in the hope that it'll make the PR small enough to review and fit into preview3. Is this possible?

what about DCOM? Could the client connect to the SQL 2000 instance via DCOM?

The client might technically be able to use DCOM to instantiate the SQLDebugging class on the server, but this wouldn't do anything; the other half of the comms. pathway (a memory-mapped file) relies upon the client and the server both running on the same computer.

I'd like to get another senior eye on this one real quick @cheenamalhotra @saurabh500 or @David-Engel ?


Fix "Subscriber count" -> "Subscription count"

As pointed out by Erik Boasson, the latter is what is actually
printed.
Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>

@mergifyio backport galactic foxy dashing


now air_brother not supported to the flutter app

'https://rouninlabs.jfrog.io/artifactory/rounin-libs-external/com/brother/brsdk/common/1.0.0/common-1.0.0.pom'.
> Could not HEAD 'https://landing.jfrog.com/reactivate-server/rouninlabs'. Received status code 409 from server: Conflict

Hi @IT19174822 ,
Thanks for reaching out about this. Unfortunately JFrog has dropped support for open source initiatives so the artifact server for this library is no longer available. We also don't have the AAR for that version anymore so it would take some time to integrate the newer version.
Thanks again for reporting this,

how long its take  to upgrade the air_brother flutter package
On Wed, Nov 20, 2024 at 9:14 AM Frank E. Hernandez @.***>
wrote:

Hi @IT19174822 https://github.com/IT19174822 ,
Thanks for reaching out about this. Unfortunately JFrog has dropped
support for open source initiatives so the artifact server for this library
is no longer available. We also don't have the AAR for that version anymore
so it would take some time to integrate the newer version.
Thanks again for reporting this,
—
Reply to this email directly, view it on GitHub
https://github.com/CodeMinion/air_brother/issues/1#issuecomment-2487287955,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQMQRWGVHGE2YYSZ2ALGQZ32BQAQLAVCNFSM6AAAAABRICOFDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBXGI4DOOJVGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update go.mod

Fix: #90

@lorin, @prytoegrian, @anotherchrisberry, @d6o, @aplsek, @sbasgall, @shawnps, @haleyw, @adamdmharvey, @oremj, @robzienert Can anyone please review this PR which fixes #90 ?

Thanks for reviewing / approving this @d6o.
I see the message "Only those with write access to this repository can merge pull request" so @lorin, @prytoegrian, @anotherchrisberry, @d6o, @aplsek, @sbasgall, @shawnps, @haleyw, @adamdmharvey, @oremj, @robzienert please do the needful to merge this PR whoever has the write access.

Thanks @robzienert for merging this.

You got it. Thanks for opening it!


Stadium Controllers - so not switch off or stay paired

BlueRetro firmware version
24.04
BlueRetro firmware specification
HW1
BlueRetro firmware variant
Universal
BlueRetro hardware type
Internal install modkit
Manufacturer
Laserbear
System used
Nintendo GameCube
Bluetooth controller brand & name
Google Stadia
What is problem? (only list ONE problem per report)
Controller pairs fine
When I switch of the console, controller stays on until I manually turn it off
When I switch the console and controller on again - they are no longer pair
They need to be re-paired everytime
What did you expect to happen?
I hoped that when I turned the console off, the controllers would auto turn off (my 8BitDo Pro 2s do this)
I hoped that when I turned the console/controllers on they would remain paired (not need to be re paired every time)
Attach files like logs or Bluetooth traces here
No response

Ditto on issue. Occurs across two controllers and two blue retro modules. Additional issues exist within the same setup with regards to Stadia controllers staying connected; will submit seperate req.

For the controller not turning off, its a bug on the Stadia FW. Nothing I can do. They ignore the turn off command.
The other issue is a dup of #622


[1.9.4] Datachannel casting exception

WorldEdit 6.1.3 nightly, SpongeVanilla 1.9.4 hand-built from c9dbc55a.
WorldEdit threw the bug here. It's triggered by attempting to use WECUI.
https://gist.github.com/phroa/fdbf6b99a745ecd1a6b401f8286800fc

@Minecrell I was trying to fix the intrinsics and your push didn't merge nicely so can you check if it broke anything else you changed in your commuit.


Rotate device

Is there any simple way to change center point and radius when rotating device?

Anything new about aaShareBubbles and rotating device ?


Fixing esVersion to match Elastic Search version

This will hopefully save some folks a bit of trouble with the "Support for Elasticsearch versions after their end-of-life (currently versions < 7.10)" error.

Sorry, I totally forgot about this fork. I will merge this just in case, but overall better to use original repo if it is working.


SharePointPnP.Modernization.Framework\Transform\PageTransformator.cs missing handler to get page data for PublishingPage type pages

I already reported the same issue with ID 189, but I'm not sure why after submitted the issue, I can't find out the issue by URL https://github.com/SharePoint/PnP-Tools/issues/198 , so re-submit the issue.
We have SharePoint Online environment with SharePoint Server Publishing feature enabled. When we do page transformation by using either of below solution

.NET version sample page transformation project(https://github.com/SharePoint/PnP/tree/master/Samples/Modernization.PageTransformation) or

PowerShell
version sample script(https://github.com/SharePoint/PnP-Tools/blob/master/Solutions/SharePoint.Modernization/Scripts/PageTransformation/TransformPageSample.ps1).

We always got exceptions as below:

Object reference not set to an instance of an object

After I did a basic investigation I found in SharePointPnP.Modernization.Framework\Transform\PageTransformator.cs , the code have treat our pages as PublishingPage type, but when do source page analysis to get page data, it only support WikiPage type and WebPartPage type, in this case the PublishingPage Type page data variable pageData will be null.

But when calling the variable pageData, there have no check on whether it was null.

Could you please help to add handler in SharePointPnP.Modernization.Framework\Transform\PageTransformator.cs for PublishingPage type pages to get the page data?

Thx for the feedback. I've added a more clear error message for this case. Going forward we're looking into offering support for publishing pages, timing most likely will be early next year.


Fix depreciation warning from archives replacements

https://goreleaser.com/deprecations/#archivesreplacements

what's with removing type: doc ?

Hm. OK.


Multiple entry points?

I can get hot reloading working with a single "index" entry point, but not with multiple entry points (as allowed by rewired).
My config-overrides.js file currently looks like this:
const paths = require('react-scripts/config/paths');
const path = require('path');
const publicPath = paths.servedPath;
const HtmlWebpackPlugin = require('html-webpack-plugin');
const rewireReactHotLoader = require('react-app-rewire-hot-loader');

// Paths to javascript & HTML files
paths.appJs = paths.appSrc + '/du.js';
paths.appHtml = paths.appPublic + '/du.html';
paths.rlglJs = paths.appSrc + '/rlgl.js';
paths.rlglHtml = paths.appPublic + '/rlgl.html';

// Utility function to replace plugins in the webpack config files used by react-scripts
const replacePlugin = (plugins, nameMatcher, newPlugin) => {
  const pluginIndex = plugins.findIndex((plugin) => {
    return plugin.constructor && plugin.constructor.name && nameMatcher(plugin.constructor.name);
  });

  if (pluginIndex === -1) {
    return plugins;
  }

  const nextPlugins = plugins.slice(0, pluginIndex).concat(newPlugin).concat(plugins.slice(pluginIndex + 1));

  return nextPlugins;
};

module.exports = function override(config, env) {
  // Define entry points
  config.entry = {
    du: [
      require.resolve('react-scripts/config/polyfills'),
      paths.appJs,
    ],
    rlgl: [
      require.resolve('react-scripts/config/polyfills'),
      paths.rlglJs,
    ]
  };

  // Split code into chunks for du & rlgl
  config.output = {
    path: paths.appBuild,
    pathinfo: true,
    filename: 'static/js/[name].bundle.js',
    chunkFilename: 'static/js/[name].chunk.js',
    publicPath: publicPath,
    devtoolModuleFilenameTemplate: info =>
      path.resolve(info.absoluteResourcePath),
  };

  // Create a HTML entry for du that only includes code for the du bundle
  const duHtmlPlugin = new HtmlWebpackPlugin({
    inject: true,
    title: 'DU',
    chunks: ['du'],
    filename: 'du.html',
    template: paths.appHtml,
  });

  // Create a HTML entry for rlgl that only includes code for the rlgl bundle
  const rlglHtmlPlugin = new HtmlWebpackPlugin({
    inject: true,
    title: 'RLGL',
    chunks: ['rlgl'],
    filename: 'rlgl.html',
    template: paths.rlglHtml,
  });

  // Replace the default HTML entry in the webpack config used by react-scripts with the du HTML entry
  config.plugins = replacePlugin(config.plugins, (name) => /HtmlWebpackPlugin/i.test(name), duHtmlPlugin);

  // Add the second HTML plugin for other entry point
  config.plugins.push(rlglHtmlPlugin);

  // Enable hot loading
  config = rewireReactHotLoader(config, env);
  return config;
};

When I make a change in the source code, no hot-reloading occurs.
If I comment out pretty much everything from here, and move one of my entry points (du.js for example) to index.js, hot reloading works OK. So the hot reloading changes in the app component are fine, I think.
Am I doing something wrong, or is this not possible currently?

Just add require.resolve('react-dev-utils/webpackHotDevClient') to your customized entry arrays.
You can also remove the rewireReactHotLoader() wrapping at the end.

hey @dddoronnn, I just tried your suggested solution, but did not succeed… Do you have any working example?

Any luck?

[Video clip of Homer Simpson receding into hedge]
I don't even remember which project I was working on when I needed this! Enough upvotes that I'm not just going to close it; hopefully a solution is found though for you and anyone who needs this in future.


Update build/icon.icns to conform to Big Sur style

Updates the app icon to conform to macOS Big Sur style:

Thanks for this! The icon looks great!
The only concern I'd have is that it does boost the size of the icon quite a bit (especially compared to other icons), is there a way to reduce the size at all?

Great question @MasterOdin ! I'm not an icon expert — I used a tool called image2icon to generate the file. It looks like maybe it just has too many resolutions packed into it? I'll see if I can extract a couple of them.

Thanks for doing this!


Return ResourceExhausted errors when memory limit is exceed in  GroupedHashAggregateStreamV2 (Row Hash)

Which issue does this PR close?
Doesn't close, but works towards #3940 (need to migrate V1 as well
Rationale for this change
Ensure that users don't run out of memory while performing group-by operations. This is esp. important for servers or multi-tenant systems.
What changes are included in this PR?

small clean up regarding async usage (first commit)
use a a nested construct (BoxStream) for GroupedHashAggregateStreamV2 so we can call into the async memory manager (I thought about NOT doing this but I think it's worth to consider because on the long run a group-by can get another splillable operation to spill)

Are these changes tested?

new test (test_oom)
perf results (see below)

Perf results:
❯ cargo bench -p datafusion --bench aggregate_query_sql -- --baseline issue3940a-pre
    Finished bench [optimized] target(s) in 0.08s
     Running benches/aggregate_query_sql.rs (target/release/deps/aggregate_query_sql-e9e315ab7a06a262)
aggregate_query_no_group_by 15 12
                        time:   [654.77 µs 655.49 µs 656.29 µs]
                        change: [-1.6711% -1.2910% -0.8435%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
  1 (1.00%) low mild
  5 (5.00%) high mild
  3 (3.00%) high severe

aggregate_query_no_group_by_min_max_f64
                        time:   [579.93 µs 580.59 µs 581.27 µs]
                        change: [-3.8985% -3.2219% -2.6198%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
  1 (1.00%) low severe
  3 (3.00%) low mild
  1 (1.00%) high mild
  4 (4.00%) high severe

aggregate_query_no_group_by_count_distinct_wide
                        time:   [2.4610 ms 2.4801 ms 2.4990 ms]
                        change: [-2.9300% -1.8414% -0.7493%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking aggregate_query_no_group_by_count_distinct_narrow: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.4s, enable flat sampling, or reduce sample count to 50.
aggregate_query_no_group_by_count_distinct_narrow
                        time:   [1.6578 ms 1.6661 ms 1.6743 ms]
                        change: [-4.5391% -3.5033% -2.5050%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
  2 (2.00%) high mild
  2 (2.00%) high severe

aggregate_query_group_by
                        time:   [2.1767 ms 2.2045 ms 2.2486 ms]
                        change: [-4.1048% -2.5858% -0.3237%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe

Benchmarking aggregate_query_group_by_with_filter: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.5s, enable flat sampling, or reduce sample count to 60.
aggregate_query_group_by_with_filter
                        time:   [1.0916 ms 1.0927 ms 1.0941 ms]
                        change: [-0.8524% -0.4230% -0.0724%] (p = 0.02 < 0.05)
                        Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
  2 (2.00%) low severe
  1 (1.00%) low mild
  4 (4.00%) high mild
  2 (2.00%) high severe

aggregate_query_group_by_u64 15 12
                        time:   [2.2108 ms 2.2238 ms 2.2368 ms]
                        change: [-4.2142% -3.2743% -2.3523%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking aggregate_query_group_by_with_filter_u64 15 12: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.5s, enable flat sampling, or reduce sample count to 60.
aggregate_query_group_by_with_filter_u64 15 12
                        time:   [1.0922 ms 1.0931 ms 1.0940 ms]
                        change: [-0.6872% -0.3192% +0.1193%] (p = 0.12 > 0.05)
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) low mild
  4 (4.00%) high severe

aggregate_query_group_by_u64_multiple_keys
                        time:   [14.714 ms 15.023 ms 15.344 ms]
                        change: [-5.8337% -2.7471% +0.2798%] (p = 0.09 > 0.05)
                        No change in performance detected.

aggregate_query_approx_percentile_cont_on_u64
                        time:   [3.7776 ms 3.8049 ms 3.8329 ms]
                        change: [-4.4977% -3.4230% -2.3282%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

aggregate_query_approx_percentile_cont_on_f32
                        time:   [3.1769 ms 3.1997 ms 3.2230 ms]
                        change: [-4.4664% -3.2597% -2.0955%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

I think the mild improvements are either flux or due to the somewhat
manual memory allocation pattern.
Are there any user-facing changes?
The V2 group-by op an now emit a ResourceExhausted error if it runs out of memory. Note that the error is kinda nested/wrapped due to #4172.

I think this is looking great
https://github.com/apache/arrow-datafusion/pull/4202/files?w=1 shows the diff clearly
What are your thoughts @milenkovicm ?

I think @crepererum did fine job here.
Not sure if he will move
memory_consumer.alloc(allocated).await?;

Just before return statement, otherwise it is spot on.

I'll move the alloc statement, give me a few minutes...

I'll move the alloc statement, give me a few minutes...

done


Allow custom association between file names and grammars

Closes #1718

Cool! People will be really happy with this.

Right now, the config key is core.fileTypesByScope, and works like so:
'*':
  core:
    fileTypesByScope:
      'source.ruby': ['Cheffile', '.also-ruby']
      'source.cpp': ['h']

What do you all think @atom/feedback?

Right now, the config key is core.fileTypesByScope [..]

Not falling in love with the name, but other than that this is awesome. The name might grow on me.

One comment, otherwise it looks good to me! Great job, @maxbrunsfeld! :sparkles:

Not falling in love with the name

Yeah, I feel that. fileTypesByScope communicates the structure of the object pretty exactly, but maybe it would be better to give it a simpler name like customFiletypes and leave it up to the description to describe the name.

Right now, the config key is core.fileTypesByScope, and works like so:

Any reason these couldnt be a minimatch pattern. Maybe overkill, but could be a little more flexible:
'*':
  core:
    fileTypesByScope:
      'source.ruby': ['Cheffile', '*.this-is-also-ruby']
      'source.cpp': ['*.h']
      'source.js': ['i-am-crazy*.*']

For the record, I dig the name for its clarity.

Any reason these couldn't be a minimatch pattern.

I wanted to make them use the same system as the grammars use for matching files (exact suffix matches), so it would be easiest to understand which matches take precedence. Right now, longer matches win, and ties are broken by choosing the users' custom filetypes.

I wanted to make them use the same system as packages' grammars use

:+1:

Ok, I'm leaning toward renaming it from fileTypesByScope to customFiletypes. Anybody care?

I like customFileTypes... less precise but more descriptive somehow.

Ok, I think this is ready. Anywhere else I should document this new setting?

nice ship :ship: :sunglasses:

For anyone looking for how to use this featured: Customizing Language Recognition


Raw assignee and location date

I see that we can get raw inventor first and last names from the API, but the raw assignee names (first, last, and organization) and raw location data (city, state, etc.) are not available. It would be great it if we could get the raw data as well for these entities. Would it be possible to add these fields? I noticed that the raw fields are available in your data dumps.
Thanks,
Chris

Thanks for the suggestion! We will add this to the list of requests and will let you know when that gets added!


Install fails under OSX Lion

Hi,
I try to install with
npm install bcrypt

I am running with node 0.4.7 and npm 1.0.106 under Mac OSX 10.7 Lion.
I have openssl and pkg-config installed and compiled node with
./configure --openssl-libpath=/usr/local/ssl/lib --openssl-includes=/usr/local/ssl/include

This is the error log I get:
><EMAIL_ADDRESS>install /Users/elias/myApp/node_modules/bcrypt
> make build

rm -f bcrypt_lib.node
rm -Rf build
node-waf configure
Checking for program g++ or c++          : /usr/bin/g++
Checking for program cpp                 : /usr/bin/cpp
Checking for program ar                  : /usr/bin/ar
Checking for program ranlib              : /usr/bin/ranlib
Checking for g++                         : ok
Checking for program gcc or cc           : /usr/bin/gcc
Checking for gcc                         : ok
Checking for node path                   : ok /usr/local/lib/node
Checking for node prefix                 : ok /usr/local
Checking for function RAND_bytes         : no such environment: default
Traceback (most recent call last):
  File "/usr/local/bin/node-waf", line 16, in <module>
    Scripting.prepare(t, os.getcwd(), VERSION, wafdir)
  File "/usr/local/bin/../lib/node/wafadmin/Scripting.py", line 145, in prepare
    prepare_impl(t, cwd, ver, wafdir)
  File "/usr/local/bin/../lib/node/wafadmin/Scripting.py", line 135, in prepare_impl
    main()
  File "/usr/local/bin/../lib/node/wafadmin/Scripting.py", line 188, in main
    fun(ctx)
  File "/usr/local/bin/../lib/node/wafadmin/Scripting.py", line 241, in configure
    conf.sub_config([''])
  File "/usr/local/bin/../lib/node/wafadmin/Configure.py", line 221, in sub_config
    self.recurse(k, name='configure')
  File "/usr/local/bin/../lib/node/wafadmin/Utils.py", line 634, in recurse
    f(self)
  File "/Users/elias/myApp/node_modules/bcrypt/wscript", line 27, in configure
    uselib_store='OPENSSL')
  File "/usr/local/bin/../lib/node/wafadmin/Tools/config_c.py", line 444, in check
    ret = self.run_c_code(*k, **kw)
  File "/usr/local/bin/../lib/node/wafadmin/Tools/config_c.py", line 521, in run_c_code
    o = bld(features=kw['features'], source=test_f_name, target='testprog')
  File "/usr/local/bin/../lib/node/wafadmin/Build.py", line 343, in __call__
    return TaskGen.task_gen(*k, **kw)
  File "/usr/local/bin/../lib/node/wafadmin/TaskGen.py", line 118, in __init__
    self.env = self.bld.env.copy()
AttributeError: 'NoneType' object has no attribute 'copy'
make: *** [configure] Error 1
npm ERR! error installing<EMAIL_ADDRESS>Error<EMAIL_ADDRESS>install: `make build`
npm ERR! error installing<EMAIL_ADDRESS>`sh "-c" "make build"` failed with 2
npm ERR! error installing<EMAIL_ADDRESS>   at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/exec.js:49:20)
npm ERR! error installing<EMAIL_ADDRESS>   at ChildProcess.emit (events.js:67:17)
npm ERR! error installing<EMAIL_ADDRESS>   at ChildProcess.onexit (child_process.js:192:12)
npm ERR<EMAIL_ADDRESS>install: `make build`
npm ERR! `sh "-c" "make build"` failed with 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the bcrypt package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     make build
npm ERR! You can get their info via:
npm ERR!     npm owner ls bcrypt
npm ERR! There is likely additional logging output above.
npm ERR!
npm ERR! System Darwin 11.2.0
npm ERR! command "node" "/usr/local/bin/npm" "install" "bcrypt"
npm ERR! cwd /Users/elias/myApp
npm ERR! node -v v0.4.7
npm ERR! npm -v 1.0.106
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/elias/myApp/npm-debug.log
npm not ok

Do you have any ideas what I could try?

That looks like a python error. What version of python do you have installed?

Python 2.7.1 (r271:86832, Jun 16 2011, 16:59:05)
[GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)] on darwin

Yea, it's not looking for the includes where you've specified. That's a terrible omission on my part. At the moment it is, by default, looking in:
libpath = ['/lib', '/usr/lib', '/usr/local/lib', '/opt/local/lib', '/usr/sfw/lib']
includes = ['/usr/include', '/usr/includes', '/usr/local/includes', '/opt/local/includes', '/usr/sfw/lib']

If you want to get this to work, move your ssl includes and lib files to one of those locations. Otherwise, I'll work on adding cli based install options for that. Thanks for the bug!

Alternatively, you can, in your clone, modify the wscript lines I posted above to include your directories.

Ok, here are my files:

Folder "openssl" (71 *.h files) --> /usr/include

Folder "ssl" (With subfolders "bin", "certs", "include", etc) --> /usr/local/lib

openssl binary [$ which openssl] --> /opt/local/bin/openssl

Is there something wrong? Build still fails.

It's looking for the ssl directory in one of the lib directories and for openssl/rand.h in the include directory (although I've never been convinced that this check works everywhere).
Check the /usr/include/openssl directory for rand.h. Check for libssl.<something> in /usr/lib/. The binary file doesn't matter here.
If you have those then the check should work. I haven't tried this with Python 2.7 but I can't imagine it's an issue.

Under /usr/lib I have
libssl.0.9.7.dylib
libssl.0.9.8.dylib
libssl.dylib (Symlink)

rand.h does exist under /usr/include/openssl
In my path I have added:
export PATH="/usr/include:$PATH"
export PATH="/usr/lib:$PATH"

I also installed Python 2.6 to be completely sure.
But it is still failing with the same error message.

Well, I just solved the issue. Seems like it has nothing to do with bcrypt.
Open the following file: /usr/local/lib/node/wafadmin/Build.py
And change the line
return self.env_of_name('default') to return self.env_of_name(DEFAULT)
Source: http://archive.cnblogs.com/a/2178519/

Huh. Well, sorry about the delay and run around. Glad I'm not that crazy though. :)
Thanks for getting back to me.
As a note, why downgrade?

Because I want to play with node on heroku which at the time supports only 0.4.7.


Integration Test - Release - 2019/09/11 14:45:57

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Create language configuration for conditional rendering of tabs

Description

Part of #2463. Depends on #2461. Persists the current language configuration (the entire SALanguage object), beyond just the chapter and variant.
Also adds "flags" to SALanguage to dictate whether to use the subst visualizer or the environment visualizer instead.
Using these flags will improve the scalability when we make the visualizers support more languages.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

How to test

Checklist

[x] I have tested this code
[ ] I have updated the documentation

@ianyong perhaps we can move the check for multi-file support (!== Chapter.SOURCE_1) into this language configuration object as well.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 8 (75.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 34.747%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/features/playground/PlaygroundActions.ts
1
2
50.0%

src/features/playground/PlaygroundReducer.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4898

Relevant Lines:
13157

💛  - Coveralls

@ianyong perhaps we can replace the check for multi-file support (!== Chapter.SOURCE_1) to use a flag like supportsMultiFile in this language configuration object as well. Thoughts on this?

Sure, that would be great! Thanks.

@ianyong based on the discussion above in terms of what will be in scope for this PR, is the current state of it okay to be merged?


failed to connect to localhost:9089 inside namespace

How to solve this error ?

@cloud-66 Can you give more context please?

@cloud-66 Seems like you need to need to enable portforwarding. The default grpc request is sent to port 32767 for fetching policy data. You can specify you preferred port by adding the KUBEARMOR_SERVICE=port_number environment variable .


Private keyword lost in getter

Issue created from telplin-online
Implementation
module Telplin

type X() =
    member private this.Y with get() = "meh"

Signature
module Telplin

type X =
    new: unit -> X
    member Y: string with get

Problem description
private is missing from the signature.
Extra information

[X] The proposed signature has problems.
[ ] I or my company would be willing to help fix this.

Also questionable if it should be excluded by default.


Support for DOM altering Angular directives in the row definition

The grid currently does not support DOM altering directives on the table elements, which unfortunately blocks us from using the grid in a couple of very nice scenarios. These directives includes ng-repeat, ng-if, ng-switch, and the like.
The resolution to this task has a dependency on #91.

Duplicate of #91.


Possible loss of logging setup in #2220

Opening up to track issue so that we can merge.
...needs checking. We had slf4j-simple here since in this module we RUN the test and so we need a runtime binding. #2089 made some changes in this area.
We may need slf4j-api - but that's compile time, and if the fvt code hasn't changed I can't see how we now need it. slf4j-simple is runtime, and we do need something.
Originally posted by @planetf1 in https://github.com/odpi/egeria/pull/2220

See also https://github.com/odpi/egeria/issues/2265

See review comments in 2265 for multiple references to slf4j configuration

ui-security-spring is also pulling in logback as a logging implementation which may conflict

From dependency inspection I don't spot any significant regressions that are a concern, though there are some anomolies found even in master.
For example server chassis ends up including both slf4j-simple and logback-classic. Ideally only a single logger implementation  would be included
The ui-chassis contains only slf4j
Deferring but leaving open to revisit.

change was reverted so closing this


【Bug】最新版文章使用封面会造成首页文章标题显示不清

Describe the bug

Reproduction
依旧如此
System Info
win

Used Package Manager
npm
Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

能否提供摘要内容，以方便快速复现。

明白问题了。

我也发现了，justify-center垂直居中逼成这样的


Readme has a placeholder name

Replace yourname with your actual username in the readme

Good catch! Fixed
https://github.com/cyclotruc/gitingest/commit/8edb7993265c989d778180c3446cb35bf51515dc


Update service-fabric-get-started-linux.md

Update the version of .Net Core to use to something recent.  Service Fabric DLLs are netstandard 2.0 so .Net Core 3.x can still consume those binaries.
To uninstall the npm packages elevation is required.

@ChrisBurgessMS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add the Firebase Class for establishing the connection with Firebase and Add a User Class

Firebase class and User class have been added to local machine and Checked if the data is loaded to the database.


remove dbs no one uses

add pebbledb
use latest pebble
added a ton of test rigor and fixed linting
if always false we don't need the param
really we don't need that
remove databases no one uses

I am okay with codecov propblems.  We should rip it out anyhow.

Sorry closing this one too.
Informal system should not use the pebble code for any reason at any time.

Hi @faddat , thank you for the benchmarks and insights. As @adizere  stated, we don't want to abruptly remove support for all other databases as we have a very large userbase still using them. We have plans to converge to one DB backend in the future but this requires an extensive study on what users are using. I would therefore separate the concerns of adding Pebble and removing other backends and keep in the PR only the addition of Pebble.

ok, I will change this to draft in that case.

Just so you know, somebody has written a universal converter. I just don't know who. It may have been The team that starts on a p but isn't persistence but I always forget their name

personally I dont care about tenths of a percent of on codecov.  Please let me know if it matters.

I think that this PR remains a good idea.

The PR would be a lot better without this commit a574117f5f01279e2d480135ce13a3ea32d481a7. It's difficult to review right now. Can you revert that commit?

100%

closing in favor of #115


Redirection after save or update to collection view page

I am trying to redirect after save or update to collection view page but not able to achieve it. Any knows how to do it or is there any way to do it. Thanks.

@JarrodMFlesch  I tried that approach but not getting how to do it? can you provide any example it will be so helpful. Thanks.

I tried same but it is not working. It is showing  /collections/users/:userId
code as below
`import { Button } from 'payload/components';
import * as React from 'react'
import {
CustomSaveButtonProps,
} from 'payload/types'
import { useHistory  } from "react-router-dom";
export const CustomSaveButton: CustomSaveButtonProps = (props) => {
const { DefaultButton, save } = props;
const history = useHistory();
const cancel = (e)=>{
e.preventDefault();
history.push({pathname:"/editor/collections/users?limit=10"});
}
const saveOn = React.useCallback(()=>{
save();
history.push({pathname:"/editor/collections/users"});
},[save, history]);
return (<div className='user-btn'>
  <Button buttonStyle='secondary' onClick={cancel}>Cancel</Button>
  <DefaultButton label={'Add the User'} save={saveOn}/>
  </div>)

}`

Sorry I am unable to recreate. You will need to link a reproduction for us to assist further!
Uploading CleanShot 2023-10-30 at 9 .57.57.mp4…

Sorry I am unable to recreate. You will need to link a reproduction for us to assist further!
https://github.com/payloadcms/payload/assets/30633324/e049153f-2ede-4597-8cec-5b9ca86aa5b9

After writing await on save it started working. Thanks for your help