window.open popup not return correct URL in onCreateWindow event function

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.7.5-stable

Plugin version
^5.7.2+3

Android version
10

Device information:
Description
onclick function that use window.open not return URL as expected in onCreateWindow
Expected behavior:
CreateWindowAction.request.url inside onCreateWindow should return correct url.
For example when onclick button function call window.open("https://www.w3schools.com", "", "width=400,height=400");
CreateWindowAction.request.url should return https://www.w3schools.com
Current behavior:
onCreateWindow

CreateWindowAction.request.url return null

Steps to reproduce
Example: window.open("https://www.w3schools.com", "", "width=400,height=400");

create simple html page in server

<html>
<head>
<title>page 1 </title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
</head>
<script language="javascript">

function openPage(){
	window.open("https://www.w3schools.com", "", "width=200,height=100");
}
</script>

<body>
page 1
<button type="button" onclick="openPage()">open window.open</button>
</body>
</html>

Use this code in Flutter

InAppWebView(
  initialUrlRequest: URLRequest(url: Uri.parse(value),headers: _cookieHeader),
  initialOptions: options,
  onWebViewCreated: (controller) {
	webViewController = controller;
	print('#onWebViewCreated');
  },
  onCreateWindow: (controller, cwa ) async{
	Uri? aaa = await controller.getUrl();
	String? bbb = await controller.getHtml();
	Uri? oriUrl = await controller.getOriginalUrl();
	print('### web view : ${cwa.request.toJson()}');
	print('### get URL : $aaa');
	print('### get HTML : $bbb');
	print('### ori Url : $oriUrl');
	return true;
  },
  androidOnPermissionRequest: (controller, origin, resources) async {
	return PermissionRequestResponse(
		resources: resources,
		action: PermissionRequestResponseAction.GRANT);
  },
  shouldOverrideUrlLoading: (controller, navigationAction) async {
	var uri = navigationAction.request.url!;
	var url = await controller.getUrl();
	print('#shouldOverrideUrlLoading uri:$uri');
	print('#SOUL:navigationAction: ${navigationAction.toJson()}');
	print('#SOUL controller.url:$url');
	if (![ "http", "https", "file", "chrome",
	  "data", "javascript", "about"].contains(uri.scheme)) {
	  return NavigationActionPolicy.CANCEL;
	}

	return NavigationActionPolicy.ALLOW;
  },
)

Images

Stacktrace/Logcat
W/chromium( 2463): [WARNING:aw_contents.cc(1148)] Blocking popup window creation as an outstanding popup window is still pending.
W/cr_WebSettings( 2463): getForceDark() is a no-op in an app with targetSdkVersion>=T
D/EGL_emulation( 2463): app_time_stats: avg=592.32ms min=186.41ms max=998.23ms count=2
I/flutter ( 2463): ### web view : {url: null, headers: null, method: GET, body: null, iosAllowsCellularAccess: null, iosAllowsConstrainedNetworkAccess: null, iosAllowsExpensiveNetworkAccess: null, iosCachePolicy: null, iosHttpShouldHandleCookies: null, iosHttpShouldUsePipelining: null, iosNetworkServiceType: null, iosTimeoutInterval: null, iosMainDocumentURL: null}

I also have the same problem.  cant get the url or html  after opening webview.

I also have the same problem. cant get the url or html after opening webview. ps: only on flutter web.

Did you find any solution for this?

Hi, same problem here with latest version.

Same problem here


What might be the reason to cause the performance difference between on WebQ and WebQSP

Really appreciate it for your contribution to the domain of semantic parsing.
May I ask the question as shown in the title of this issue?
Notice that in "Semantic Parsing via Staged Query Graph Generation: Question Answering with Knowledge Base" the F1 score on WebQuestion is over 50., and this gated GNN method get over 25. F1 score on WebQSP
Thanks a lot. Your answer will be of great help.

Hi,
the difference is mainly due to a mismatch between the Wikidata that we use in our experiments and Freebase that was used to get the previous results.
See also Section 5.3 in the paper:
"Overall, in 32% of the cases the error was caused by the gap between the KB and the data set. This lets us put the current results into a perspective with the previously reported numbers for the Freebase KB. If we approximately adjust our results for this kind of errors, we achieve between 0.469 and 0.51 F-score."
Best,
Daniil


swc-plugin-coverage-instrument incompatible with middleware

Steps to reproduce:

run npx create-next-app minimal-reproduction --typescript --eslint --no-tailwind --no-src-dir --app --import-alias '@/*'
run npm i -D swc-plugin-coverage-instrument
add plugin to next.config.mjs:

const nextConfig = {
    experimental: {
        swcPlugins: [['swc-plugin-coverage-instrument', {}]]
    }
}
export default nextConfig;

clean up layout.tsx to avoid other compilation issues

export default function RootLayout({children}: Readonly<{children: React.ReactNode}>) {
  return ({children});
}

create middleware.ts

import { NextResponse } from 'next/server'
export async function middleware() {
    return NextResponse.next()
}

run npm run build
run npm start
visit http://localhost:3000

Result
First a code dump, and then many errors like:
EvalError: Code generation from strings disallowed for this context
    at new Function (<anonymous>)
    at j (/Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:13:1314)
    at 841 (/Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:13:28509)
    at t (/Users/christian/Projects/minimal-reproduction/.next/server/edge-runtime-webpack.js:1:127)
    at /Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:13:119656
    at r (/Users/christian/Projects/minimal-reproduction/.next/server/edge-runtime-webpack.js:1:1169)
    at /Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:1:51
    at Script.runInContext (node:vm:148:12)
    at runInContext (node:vm:300:6)
    at evaluateInContext (/Users/christian/Projects/minimal-reproduction/node_modules/next/dist/server/web/sandbox/context.js:407:38)
/Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:2
Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime`}process!==n.g.process&&(process.env=n.g.process.env,n.g.process=process),Object.defineProperty(globalThis,"__import_unsupported",{value:function(e){let t=new Proxy(function(){},{get(t,n){if("then"===n)return{};throw Error(_(e))},construct(){throw Error(_(e))},apply(n,r,i){if("function"==typeof i[0])return i[0](t);throw Error(_(e))}});return new Proxy({},{get:()=>t})},enumerable:!1,configurable:!1}),w();class y extends Error{constructor({page:e}){super(`The middleware "${e}" accepts an async API directly with the form:
                                                                                ^

TypeError: Cannot redefine property: __import_unsupported
    at Proxy.defineProperty (<anonymous>)
    at 841 (/Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:2:155)
    at t (/Users/christian/Projects/minimal-reproduction/.next/server/edge-runtime-webpack.js:1:127)
    at /Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:13:119656
    at r (/Users/christian/Projects/minimal-reproduction/.next/server/edge-runtime-webpack.js:1:1169)
    at /Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:1:51
    at Script.runInContext (node:vm:148:12)
    at runInContext (node:vm:300:6)
    at evaluateInContext (/Users/christian/Projects/minimal-reproduction/node_modules/next/dist/server/web/sandbox/context.js:407:38)
    at getRuntimeContext (/Users/christian/Projects/minimal-reproduction/node_modules/next/dist/server/web/sandbox/sandbox.js:71:9)
/Users/christian/Projects/minimal-reproduction/.next/server/middleware.js:2
Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime`}process!==n.g.process&&(process.env=n.g.process.env,n.g.process=process),Object.defineProperty(globalThis,"__import_unsupported",{value:function(e){let t=new Proxy(function(){},{get(t,n){if("then"===n)return{};throw Error(_(e))},construct(){throw Error(_(e))},apply(n,r,i){if("function"==typeof i[0])return i[0](t);throw Error(_(e))}});return new Proxy({},{get:()=>t})},enumerable:!1,configurable:!1}),w();class y extends Error{constructor({page:e}){super(`The middleware "${e}" accepts an async API directly with the form:

https://github.com/kwonoj/swc-plugin-coverage-instrument/issues/226


Background Image is not to device scale

Hello,
First of all, nice app you have here.
Ok, I am having a hard time trying to figure out how to scale the background image to every device. Every time I pick a background image from the photo library, the image gets blown up and is way too big to see in the background.
Do you have a solution for this?
Thank you.

Looks need to scale the image size like so:
func scaleImageToSize(size: CGSize, image: UIImage) -> UIImage {
	UIGraphicsBeginImageContextWithOptions(size, false, 0.0);
	image.drawInRect(CGRectMake(0.0, 0.0, size.width, size.height))
	let imageR = UIGraphicsGetImageFromCurrentImageContext()
	UIGraphicsEndImageContext();
	return imageR;
}

self.board.backgroundColor = UIColor(patternImage: self.scaleImageToSize(self.view.bounds.size, image: backgroundImage))

where will this be placed? in board.swift?
Thanks

@natedkin
You can put it in the ViewController.swift :)

I don't know what i'm doing wrong but it's still not working.  Can you upload the ViewController.swift file here?
Thanks

func scaleImageToSize(size: CGSize, image: UIImage) -> UIImage { // added
	UIGraphicsBeginImageContextWithOptions(size, false, 0.0);
	image.drawInRect(CGRectMake(0.0, 0.0, size.width, size.height))
	let imageR = UIGraphicsGetImageFromCurrentImageContext()
	UIGraphicsEndImageContext();
	return imageR;
}

func setupBackgroundSettingsView() { // replace the original method
    let backgroundSettingsVC = UINib(nibName: "BackgroundSettingsVC", bundle: nil).instantiateWithOwner(nil, options: nil).first as! BackgroundSettingsVC

    self.addConstraintsToToolbarForSettingsView(backgroundSettingsVC.view)

    backgroundSettingsVC.view.hidden = true
    backgroundSettingsVC.view.tag = 2
    backgroundSettingsVC.setBackgroundColor(self.board.backgroundColor!)

    self.addChildViewController(backgroundSettingsVC)

    backgroundSettingsVC.backgroundImageChangedBlock = {
        [unowned self] (backgroundImage: UIImage) in
        self.board.backgroundColor = UIColor(patternImage: self.scaleImageToSize(self.view.bounds.size, image: backgroundImage))
    }

    backgroundSettingsVC.backgroundColorChangedBlock = {
        [unowned self] (backgroundColor: UIColor) in
        self.board.backgroundColor = backgroundColor
    }
}

Thanks @zhangao0086


vim-polyglot is not updated

Why not change vim-polyglot to especific syntax and etc by language?
I run the build script and many packages are outdated.
We can run these plugins only on specifics filetypes for example:
Plug 'hdima/python-syntax', {'for': 'python'}
@avelino @lerrua, what do you think?

We had some bugs after merge this PR for example the issue #231 by missing vim-polyglot, without it we'll missing support for nginx, less, puppet and others file types.

As discussed with you personally, i have another solution to make everboady happy, i will submit a PR asap.

@lerrua it's Alive! 03a03d23e1921e1527e12e36637144d7d26cebc3 Vim-polyglot is now updated!
We've still with problems with print, but the simplest solution is deactivate polyglot on this case or similar.

great! 🍺


fix edit button

note: I haven't tested this.
Fixes #13

+1 to that, I created a commit that did a similar thing but forgot to put in the PR! https://github.com/robinlovelace/docs/tree/patch-2


Graph: Add Breadth-first Search algorithm with grouping support

JIRA: MADLIB-1102
Graph: Add Breadth-first Search algorithm with grouping support.
This algorithm searches or traverses connected nodes in a graph in breadth-first order starting at a user-specified origin node.
Documentation and install-check to follow in subsequent commits

Can one of the admins verify this patch?

@njayaram2 Thank you for your review and comments. I will take a look and work on them.

jenkins, ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/85/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/92/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/97/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/99/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/102/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/105/

LGTM

Closed with commit 8c9b955
@raghur1 Can you please close this PR?

Code merged separately. Closing the PR manually.


Ensure copy_container role follows cifmw conventions

As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

Testproject: https://review.rdoproject.org/r/c/testproject/+/49365

/approve

/lgtm
The question now is, how is using the legacy names? Just to track and delete them, and come back to delete those when finished

/lgtm
The question now is, how is using the legacy names? Just to track and delete them, and come back to delete those when finished

sooo - for now we have to make sure role is converged. Next step may be to add a "warning" and, eventually, a "fail" in case old names are used. We have to fix jobs, not break them further, at least as a first step :D


Add script for verifying image cache operations

This change introduces a script to test cache related operations and modifies README to explain how to test image caching operations.

/hold for beta freeze

/retest-required

/test glance-operator-build-deploy-tempest

/test glance-operator-build-deploy-tempest


Consider adding alias to Momentum.of()

Hi,
It would be consistent if there is alias for Momentum.of<ControllerName>()  to controller<ControllerName>(context);

I've been actually thinking about this long ago. The reason I use .of<T> was to follow the traditional way of naming it and of looks cute and it's easier to type :)
Maybe I'll add this alias on next release. I'm also thinking if I should go with controller<T> or getController<T> because we currently have getService<T>.

I personally think, it's easier to confuse getController as user defined function as usually most of the devs use getXYZ. controller<T> or snapshot<T> and 'service` could easily identify it is part of package instead of user defined function.

Thanks for the idea, I'll consider it.

This suggestion was included in the new release, v1.1.7
API Reference for Momentum.controller<T>(context)
and for Momentum.service<T>(context)


Error creating binding : invalid index <0x80070585>

Error creating binding : invalid index <0x80070585>
Windows server 2008 r2
IIS Version 9
wacs Lasted version
Log
Error creating binding mywebsite.in.th: Invalid index. (0x80070585) System.Runtime.InteropServices.COMException (0x80070585): Invalid index. (0x80070585)    at Microsoft.Web.Administration.Interop.IAppHostElement.GetPropertyByName(String bstrSubName)    at Microsoft.Web.Administration.ConfigurationElement.SetAttributeValue(String attributeName, Object value)    at PKISharp.WACS.Clients.IIS.IISClient.AddBinding(IISSiteWrapper site, BindingOptions options)    at PKISharp.WACS.Clients.IIS.IISHttpBindingUpdater2.AddBinding(TSite site, BindingOptions options)
at PKISharp.WACS.Clients.IIS.IISHttpBindingUpdater2.AddOrUpdateBindings(TBinding[] allBindings, TSite site, BindingOptions bindingOptions)    at PKISharp.WACS.Clients.IIS.IISHttpBindingUpdater2.AddOrUpdateBindings(IEnumerable1 identifiers, BindingOptions bindingOptions, Byte[] oldThumbprint)

IIS 9 doesn't exist, but it's curious that you mention this, because I can see only the program crashing this way if the IIS version is for whatever reason reported as 9 on a Windows 2008 operating system. Does the program actually report the IIS version as 9? If so it must be misconfigured in the registry under HKLM\Software\Microsoft\InetStp


🐞[Bug]: Back button not working in About Page

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The back button present in the About page is not working showing a 404 Error page.
Expected behavior
The back button should redirect to the main page.
Add ScreenShots
https://github.com/sk66641/Random-Disco-Light-Simulator/assets/153659573/7b6a3609-e6fc-4cb8-a83b-79ec2841d3ba
What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hey, @AkshitGarg24 , Assign this issue to me!!

It seems that someone has already fixed it in the previous PR. If you have any additional issues, feel free to reach out.


bug

ReactiveCocoa/ReactiveCocoa.h  file  not  found

Please using the command in the README to clone this repository, because it contains submodules.


[AIRFLOW-3479] Keeps records in Log Table when delete DAG & refine related tests

Jira

https://issues.apache.org/jira/browse/AIRFLOW-3479

Description
Problem This PR Tries to Address
Currently when we delete a DAG (using API or from the UI), it will delete all related records in all tables (all tables in which "dag_id" is available), including "log" table.
However, the records in "log" table should be kept (by default). This would be ideal for multiple reasons, like auditing.
What This PR Does

When we delete DAG using API: provide one boolean parameter to let users decide if they want to keep records in Log table when they delete a DAG. Default value it True (to keep records in Log table).

When we delete DAG from UI: will keep records in the Log table when delete records for a specific DAG ID (pop-up message is updated accordingly).

Tests
Test cases are added to cover:

Delete a DAG which doesn't exist.
Delete a DAG which is still in DagBag.
Successfully delete a DAG + keep records in Log table.
Successfully delete a DAG + delete records in Log table as well.

Hi @ashb @kaxil , PTAL. Earlier I asked for your inputs for this on Slack.
Cheers.

I can say that for my use case when I delete a dag I have no need for the log table. It would be awesome if this could be done from the UI. Maybe instead of alerting message changing it to a derision message where the user can confirm or deny the delete of log table and it would set the flag accordingly.

1 test (Py35-sqlite) failed due to transient error. May you help re-trigger it? @ashb Thanks!

1 test (Py35-sqlite) failed due to transient error. May you help re-trigger it? @ashb Thanks!

Codecov Report

Merging #4287 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4287      +/-   ##
==========================================
+ Coverage   78.08%   78.09%   +<.01%
==========================================
  Files         201      201
  Lines       16458    16460       +2
==========================================
+ Hits        12851    12854       +3
+ Misses       3607     3606       -1

Impacted Files
Coverage Δ

airflow/api/common/experimental/delete_dag.py
88% <100%> (+5.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f036e...008237f. Read the comment docs.

Tried to rebase & force-push to trigger Travis CI.
1 (out of 9) test failed (likely due to transient error).

Awesome @XD-DENG , I have re-triggered the failing test.


sublime text plugin

I think it would be pretty cool to have an htmllint plugin for sublime text. It's a bit too early for this, but I figured I'd make an issue, just to remember it later.

If this is done, preferably it is through the plugable http://www.sublimelinter.com/
It has existing infrastructure and support that aids development and use. It's also very popular - somewhat the go to linting tool on sublime.

I don't think anyone on the project has enough interest to do this now (it was a project for a class in college, and the class is over, and none of us really need a linter...). I don't use Sublime, but if you would like to submit htmllint as a SublimeLinter plugin, I would be happy to help with anything you need on our end.

along the same lines would be nice to have a linter plugin for atom as well https://github.com/steelbrain/linter

@hanakin (and perhaps @mlochbaum), just wanted to let you know that as of a few days ago a plugin for Atom does exist! You can find it as linter-htmllint 🎉


Upgrading from 1.15.0 to 1.15.1 breaks jquery-validation-unobtrusive when using Browserify setup

Subject of the issue
I am using a Browserify-based setup for developing ASP.NET MVC application using jquery-validation and jquery-validation-unobtrusive:

This works fine using jquery-validation up to version 1.15.0 but suddenly breaks when I upgrade the package to 1.15.1.
Your environment
Version: 1.15.1
Browser: Firefox 48.0b10 and Chrome 52.0.2743.82 m
Steps to reproduce
In an ASP.NET MVC Core web application, use Browserify setup like above, refer from the MVC View page, then test using a View Model and Form like these:
public class TestModel
{
    [Required]
    public string Name { set; get; }
}

@model Models.TestModel

<form method="post">

        <input class="form-control" asp-for="Name" />

        <button class="btn btn-primary" type="submit">Submit</button>

</form>

Expected behaviour
jquery-validation-unobtrusive works.
Actual behaviour
This error appears in browser console Uncaught TypeError: Cannot set property 'unobtrusive' of undefined
in jquery-validation-unobtrusive source: $jQval.unobtrusive = {
where var $jQval = $.validator
So apparently $.validator becomes not defined due to upgrading from 1.15.0 to 1.15.1!
When I actually commented out the part about requiring jquery-validation-unobtrusive, something like:
global.derp = require('jquery');
require('jquery-validation');
//require('jquery-validation-unobtrusive/jquery.validate.unobtrusive');

Version 1.15.0, derp.validator invoked in console gives me function [7]</</e.validator(),
while version 1.15.1, derp.validator invoked in console gives me undefined instead!

Just tested and everything works as expected. I roughly used the same code you provided:
Structure
.
├── bundle.js
├── index.html
├── main.js
├── script.js
└── node_modules
    └──<EMAIL_ADDRESS>        └──<EMAIL_ADDRESS>
script.js
"use strict";

// you can also use `$`
global.jQuery = require("jquery");
require("jquery-validation");

main.js
"use strict";

require("./script");

index.html
<!DOCTYPE html>

<EMAIL_ADDRESS>with browserify</title>

    <form id="myform">
        <input type="text" name="name" required=""></input>
        <input type="submit" value="submit"></input>
    </form>

In 1.15.1 we didnt change anything build or AMD related.. its unlikely we broke things with 1.15.1.. maybe with 1.15.0 but not with the latest release.

I have a similar issue using webpack.  I'm still getting used to webpack, but I found that a change in 1.15.1 in the additional-methods.js file on line 718 from jQuery.validator.addMethod( "notEqualTo", function( value, element, param ) { to this $.validator.addMethod( "notEqualTo", function( value, element, param ) { is what's breaking it for me, notice the $ from jQuery change.

I'm one of the maintainers on jquery-validation-unobtrusive. While trying to add UMD support we've run into basically the same issue, though in my debugging it doesn't appear to be dependent on 1.15.1 vs 1.15.0.
As @Arkni has said, you can prevent Uncaught TypeError: Cannot set property 'unobtrusive' of undefined under the CommonJS/Browserify/Node pattern if you have
global.jQuery = require("jquery");
require("jquery-validation");

But that has the problem that we've defeated the point (as I understand it) of using modules by polluting the global namespace. In diagnosing and toying around with this issue I found that if we return $; inside jquery.validate.js then use the result of that inside jquery.validation.unobtrusive it works without having to pollute the global.
Is there some reason why making it return the extended jquery wouldn't work or would be wrong/bad? Or are we missing some existing way to use jquery-validation in the CommonJS pattern without polluting the namespace (or maybe I misunderstand, and that wouldn't actually be bad)?

In diagnosing and toying around with this issue I found that if we return $;

+1 to this. We can follow this interesting approach (background umdjs/umd#68) which should fix the problem:
module.exports = function( root, jQuery ) {
    if ( jQuery === undefined ) {
        // require("jQuery") returns a factory that requires window to
        // build a jQuery instance, we normalize how we use modules
        // that require this pattern but the window provided is a noop
        // if it's defined (how jquery works)
        if ( typeof window !== "undefined" ) {
            jQuery = require("jquery");
        } else {
            jQuery = require("jquery")(root);
        }
    }

    factory(jQuery);

    return jQuery;
};

I'm using webpack and jquery-validation works in 1.15.0 and is broken in 1.15.1. error message is:
TypeError: $(...).validate is not a function

When inspecting the generated file, it looks like webpack is trying to replace the Require.js definition instead of the CommonJS require statement.
	(function( factory ) {
		if ( true ) {
			!(__WEBPACK_AMD_DEFINE_ARRAY__ = [__webpack_require__(1)], __WEBPACK_AMD_DEFINE_FACTORY__ = (factory), __WEBPACK_AMD_DEFINE_RESULT__ = (typeof __WEBPACK_AMD_DEFINE_FACTORY__ === 'function' ? (__WEBPACK_AMD_DEFINE_FACTORY__.apply(exports, __WEBPACK_AMD_DEFINE_ARRAY__)) : __WEBPACK_AMD_DEFINE_FACTORY__), __WEBPACK_AMD_DEFINE_RESULT__ !== undefined && (module.exports = __WEBPACK_AMD_DEFINE_RESULT__));
		} else if (typeof module === "object" && module.exports) {
			module.exports = factory( require( "jquery" ) );
		} else {
			factory( jQuery );
		}
	}(function( $ ) {

Reverting to 1.15.0 in my project for now. :+1:

Does @Arkni's patch posted above work for you?

@staabm I fixed it locally (before reverting to version 1.15.0) by switching the order of the if statements. If the CommonJS check for module.exports is put first, then it works fine

I've made #1838 with my proposed fix for this issue.

I just hit this error when upgrading from 1.15.0 to 0.17.0, so this still appears to be a problem. What's the solution?
I'm using webpack 3 with AMD disabled. I'm trying with
const $ = global.$ = global.jQuery = require('jquery');
require('jquery-validation');

@mnpenner
Managed to resolve a similar issue I was hacking by using v1.17.0 and changing my webpack.config.js file:
import webpack from 'webpack';

module.exports = {
  module: {
    rules: [
      {
        test: /.js$/,
        use: [
          {
            loader: 'babel-loader',
          }
        ]
      }
    ]
  },
  plugins: [
    new webpack.ProvidePlugin({
      'window.jQuery': 'jquery',
      'window.$': 'jquery',
      'jQuery': 'jquery',
      '$': 'jquery',
    }),
  ],
  resolve: {
    alias: {
      jquery: 'jquery/src/jquery',
      validate: 'jquery-validation/dist/jquery.validate.js'
    },
    modules: [
      path.resolve('./src/**/js/'),// path to my JS source files
      path.resolve('./node_modules/')// path to my node modules folder
    ]
  }
}

And in my main JS file:
import 'validate';

Works for me now.

This resolved the issue for me:
import 'imports-loader?jQuery=jquery,define=>false,module.exports=>false!jquery-validation'


code release

Hi, when will the code  be released?

Hi,
Sorry, I've just been very busy with a conference deadline and then starting an internship. It will be up during next week!


Error typing command gulp

If I type gulp, it prints an error saying  TypeError: this.queueTask is not a function
Although if you type the command gulp jsx works.

I'm getting the same error whether using gulp, gulp jsxor gulp watch.

It looks like the npm package hasn't been updated, but it's been fixed in #3
Try using npm install ryanwinchester/elixir-react-jsx --save to snatch the master branch.

try now


Add support for the ADC peripheral

This adds the ability to run single AD conversions similar to what was suggested in #92.
Here are a few potential issues with this implementation:
RCC and clocks
Right now, the prescaler for the ADC is set to divide the system clock by 6 as
I read somewhere that it is required to get accurate readings when the sysclock
is running at 72 MHz.
Hardcoding this value is kind of ugly since you could do less prescaling when the sysclock
is slower than 72 MHz. Is that a problem for this initial implementation?
Type safety
This implementation makes sure that the ADC can only be used on a pin which is configured
as an analog input and also maps pins to their corresponding channel.
However, this means that you can't run the ADC on channels without an associated pin like
chanel 16 which is a temperature sensor. Do we want to make Adc::read pub? What happens
if you run a conversion on a pin that is not configured as analog input?
Also, is there a nicer way to implement the mapping between pins and channels?

Are you planning make this compatible with #https://github.com/rust-embedded/embedded-hal/pull/101 ?

Hmm, I didn't know that PR was a thing. I'll have a closer look later but it looks like it could be supported fairly easily

@TheZoq2 It would be great if you could also address:

Hardcoding this value is kind of ugly since you could do less prescaling when the sysclock
is slower than 72 MHz. Is that a problem for this initial implementation?

Not really a problem but why not address this right away?

Not really a problem but why not address this right away?

Mostly because for my application, I don't need maximum speed. Als because I couldn't find the page where I originally got the idea to set it to 6. I can look into doing it properly tonight.

I found the place in the manual where they explain the required timings and updated the branch to reflect that. It should now ensure that the ADC clock runs at 14 MHz or less

Good catch! I updated it with both suggestions

I did, but for some reason I thought changing it to > instead of >= would fix that.
I changed it back to >= since we want to "round up" the division and updated the divisors, does it look correct now?

72 MHz / 14 MHz = 5.14 > 4
Div = 6
Real speed 72 / 6 = 12 MHz

72 MHz / 14 MHz = 5.14 > 4
Div = 8
Real speed 72 / 8 = 9 MHz

Unless i'm misstaken, the code, as it looks after my latest commit divides by 6 in this case which gives a real speed of 72/6 = 12 MHz which is correct, right?

Yes.

I made screen from CubeMX.
You should use APB2 speed as base instead of sysclk

Yes, another good catch. Thanks!
I pushed a new commit with a fix

implementation of em-hal adc for L0x1:
https://github.com/thenewwazoo/stm32l0x1-hal/blob/master/src/adc.rs

Great work @TheZoq2!. Just to let you know, the ADC traits have been published in<EMAIL_ADDRESS>

I finally got around to rebasing this against the current version. I'll try and find some time to rewrite it to use the embedded-hal implementation soon.
@tib888 I assume you're talking about allowing the user to chose the frequency, if so I'll try and implement that as well

I have now implemented the embedded_hal adc traits to replace the pin handling I did before

Looking good.

I finally got around to rebasing this against the current version. I'll try and find some time to rewrite it to use the embedded-hal implementation soon.
@tib888 I assume you're talking about allowing the user to chose the frequency, if so I'll try and implement that as well

Not only that, it actually implements the divider calculation (more precise version) and the config register setting too, so you could have been used the whole file as is.
    let adcpre_bits = match pclk2 / (self.adcclk.unwrap_or(14_000_000) + 1) {
            0...1 => 0b00,
            2...3 => 0b01,
            4...5 => 0b10,
            _ => 0b11,
        };

    let adcclk = (pclk2 >> 1) / u32(adcpre_bits + 1);
    assert!(adcclk <= 14_000_000);

   rcc.cfgr.modify(|_, w| unsafe {
        w.ppre2()
            .bits(ppre2_bits)
            .ppre1()
            .bits(ppre1_bits)
            .hpre()
            .bits(hpre_bits)
            .usbpre()
            .variant(usbpre)
            .sw()
            .variant(if pllmul_bits.is_some() {
                SWW::PLL
            } else if self.hse.is_some() {
                SWW::HSE
            } else {
                SWW::HSI
            })
            .adcpre()
            .bits(adcpre_bits)                     //  <= sets the adc pre here
    });

@TheZoq2 have you tested the read_raw implementation?
Repeatedly calling it while waiting for the result will run the first two lines of code many times.
I'm afraid that it will cause coninous restarts of conversion and never return a result.
I hope I'm wrong...

@tib888 I tested it briefly by running the examples/adc.rs and it seems to work. Though it might not be a bad idea to check if a conversion is already happening...

I'm not sure why my test didn't catch this earlier, but @tib888 was right, it does get stuck in an infinite loop. Unfortunately I can't reproduce it in the example but I did experience it in my main project.
I have pushed a fix which works but does have issues when running more than one read at a time:
let (mut chan1, mut chan2) = (None, None);

while chan1 == None && chan2 == None {
    if let Ok(val) = pa1.read() {chan1 = Some(val)};
    if let Ok(val) = pa2.read() {chan2 = Some(val)};
}

In this case, the values of chan1 or chan2 would depend on the timings of the read function and the rest of the system. The best solution I can come up with is to add an Error::AdcBusy which would be returned if you try to start a conversion on another channel while the ADC is already running. Does that sound like a good idea or is there a better option?

@TheZoq2  What about this solution below?
It is using type states to block starting a new conversion while an other is running.
Also in this case you do not need to check if a conversion is started already or not.
pub struct Adc<ADC> {
    adc: ADC
}

pub struct AdcConversion<ADC, PIN> where
PIN: Channel<$ADC, ID=u8>,
{
    adc: Adc<ADC>,
    pin: PIN
}

impl<ADC> Adc<ADC> {

    /// powers up the ADC...
    pub fn init(adc: ADC, apb2: &mut APB2, clocks: &Clocks) -> Self {
        ...
    }

    /// takes the ownership of the adc and the given pin for the time of the conversion(s)
    pub fn start_conversion<PIN>(self, pin: PIN) -> AdcConversion<ADC, PIN> where PIN: Channel<$ADC, ID=u8>,
    {
        unsafe {
            self.adc.sqr3.modify(|_, w| w.sq1().bits(PIN::channel()))
        };
        self.adc.cr2.modify(|_, w| { w.adon().set_bit()});

        AdcConversion<ADC, PIN> {
            adc: self,
            pin: pin
        }
    }
}

impl<ADC, PIN> AdcConversion<ADC, PIN> where
PIN: Channel<$ADC, ID=u8>,
{
    /// tries to read the result of adc conversion
    pub fn read(&mut self, restart_on_success: bool) -> nb::Result<u16, Void> {
        // Check if the data is ready for reading
        if self.adc.sr.read().eoc().bit() == false {
            Err(nb::Error::WouldBlock)
        } else {
            self.adc.sr.modify(|_, w| w.strt().clear_bit());
            let value = self.adc.dr.read().data().bits();
            if restart_on_success {
                unsafe {
                    self.adc.sqr3.modify(|_, w| w.sq1().bits(PIN::channel()))
                };
                self.adc.cr2.modify(|_, w| { w.adon().set_bit() });
            }
            Ok(value)
        }
    }

    /// returns the ownership of adc and the pin so new conversions can be started
    pub fn split(self) -> (Adc<ADC>, PIN)
    {
        if self.adc.sr.read().strt().bit_is_set() {
            //todo stop the conversion here??
        }
        (self.adc, self.pin)
    }
}

It could be used like this:
let adc = adc::Adc::adc1(p.ADC1, &mut rcc.apb2, &clocks);
let conversion = adc.start_conversion(pb1);

// adc, pb1 is not accessible anymore...

let reading = block!(conversion.read(false)).unwrap();
let (adc, pb1) = conversion.split();

// adc, pb1 can be used here again...

@tib888 That's defenitively a solution that I would prefer over runtime errors. However, as far as I can tell, it is not compatible with the Adc trait in embedded_hal.

@TheZoq2 I agree, so we could propose there an improvement in embedded_hal.
However before that it would be nice to try it out in a real environment.
Also, lets think how this concept could be extended to achieve multi channel conversion sequences...


Configuration errors not saved in log

When running DIGITS as a service, the server fails silently on an invalid configuration file. Nothing is printed in the log, so the user doesn't know what went wrong.
The trick is, we load the logfile location from the config file. So, we need to:

Read the config file[s] for a logfile location
Set the logfile
Check the other configuration options
If something is invalid:
If running digits-devserver, prompt the user for a valid value
If running digits-server, log the error before killing the script

Fixed in deb packaging by piping stderr to the log.


Fixes#2997: Added validator in report bug prompt

Fixes #2997
Describe the changes you have made in this PR -
Added text validator in report a bug prompt
Screenshots of the changes (If any) -

Coverage remained the same at 81.785% when pulling 9291f5354ed8e1cebce9b161cced98bd7ffe19e8 on aashimawadhwa:empty-request-validator#2997 into 058a67eb4298194b5dd9965f38ea8d1ca7e11bfc on CircuitVerse:master.

@pavanjoshi914 Any feedback for this?


Feature/action improvements

Made actions more flexible and require less boilerplate

Also merged parts of the menu changes into here already


Book Recommendation System

Issue no - #432
i have added entire folder including all mandatory files.
@suryanshsk is there any confilcts let me know !

This is  not related with our projects

This is not related with our projects

@suryanshsk but i had mentioned entire description in issue!

This is not related with our projects

According to that what changes I have to make

@suryanshsk can you please change level as it include one entire important concept !

@suryanshsk  can you please change level !

Your issue is related to level 1 according to GSSoC Guidelines


"Getting Started" Tutorial fails to build apko.

I hit a build error in the excellent tutorial Getting started with Melange
I entered the command:
docker run --rm -v ${PWD}:/work cgr.dev/chainguard/apko \
  build apko.yaml hello-minicli:test hello-minicli.tar \
  --arch host \
  -k melange.rsa.pub

and I got this build failure:
Error: failed to load image configuration: unable to fetch remote include from git: failed to parse git reference apko.yaml: not enough path data available
2023/12/24 03:38:41 error during command execution: failed to load image configuration: unable to fetch remote include from git: failed to parse git reference apko.yaml: not enough path data available

version info:
Darwin c-24-62-68-202.hsd1.ma.comcast.net 21.6.0 Darwin Kernel Version 21.6.0: Wed Oct  4 23:55:28 PDT 2023; root:xnu-8<IP_ADDRESS>4.15~1/RELEASE_X86_64 x86_64

  __  __   _____   _          _      _   _    ____   _____
 |  \/  | | ____| | |        / \    | \ | |  / ___| | ____|
 | |\/| | |  _|   | |       / _ \   |  \| | | |  _  |  _|
 | |  | | | |___  | |___   / ___ \  | |\  | | |_| | | |___
 |_|  |_| |_____| |_____| /_/   \_\ |_| \_|  \____| |_____|
melange

GitVersion:    v0.5.5
GitCommit:     3a7d2fcf7c05beee78d2e1315eaa441b879f129d
GitTreeState:  clean
BuildDate:     '2023-12-22T09:48:16Z'
GoVersion:     go1.21.5
Compiler:      gc
Platform:      linux/amd64

docker version                                                                                1 ↵ ──(Fri,Dec29)─┘
Client:
 Version:           24.0.7
 API version:       1.43
 Go version:        go1.20.10
 Git commit:        afdd53b
 Built:             Thu Oct 26 09:04:20 2023
 OS/Arch:           darwin/amd64
 Context:           orbstack

Server: Docker Engine - Community
 Engine:
  Version:          24.0.7
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.10
  Git commit:       311b9ff
  Built:            Thu Oct 26 09:05:28 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.8
  GitCommit:        8e4b0bde866788eec76735cc77c4720144248fb7
 runc:
  Version:          1.1.9
  GitCommit:        82f18fe0e44a59034f3e1f45e475fa5636e539aa
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Thanks for the report! Will take a look as soon as we can.

...I... don't suppose it has something to do with the way git-go handles local clones?
https://github.com/go-git/go-git/issues/672


AttributeError: 'NoneType' object has no attribute 'eval'

run demo.py

Hi, run_demo.py was part of the original CLOVA AI code. It has not been modified to support ViTSTR. This is one of the items in the todo list.


⚠ Bofrost.be has degraded performance

In 65783f3, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 922 ms

Resolved: Bofrost.be performance has improved in 006dc9e after 20 minutes.


docs(toasts): fix missing comma

Before submitting the PR:

[x] Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
[x] Did you update and run tests before submission using npm run test?
[x] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
[x] Did you update documentation related to your new feature or changes?

What does your PR address?
There is a missing comma in the Toasts example.
Tips

Tap "convert to draft" to indicate this is work in progress.
Link to an issue using the verbiage Fixes #XX
Linked issues will auto-close when the PR is merged.

Thanks!


old button config

can you please revert the change or add a new option to make the button replace report bugs button?

the change that cam with the 1.21 update where there was no longer an option to make modmenu button replace just report bugs button and instead it just replaces give feedback and report bugs


Fails to run tests with federated module

Describe the bug
Hey folks, I found a problem that I don't know how to solve. I'm using module federation (@originjs/vite-plugin-federation) to get a remote module with routes for the react router and since I've added config my tests a failing,
Here is my config:
    federation({
            name: 'host',
            remotes: {
                remote: `https://domain.com/community/assets/community-feed.js`,
            },
            shared: ['react', 'react-router-dom'],
    }),

and when I run the tests I got this error:
Error: Failed to load url https://domain.com/community/assets/community-feed.js (resolved id: https://domain.com/community/assets/community-feed.js). Does the file exist?
 ❯ loadAndTransform node_modules/vite/dist/node/chunks/dep-df561101.js:54939:21

One more thing to mention is that I do not use lazy loading to get the remote module since it has route configs that I use in the parent router. If I switch to lazy loading and mock imported module tests are okay (but I cannot use that approach).
Normally I'm mocking network requests with MSW but this request seems to be out of reach.
Needless to say, the remote entry file is accessible.
So is there any way to work around it and get my test working?
Reproduction

System Info
"vitest": "^0.34.1"
"Node.js": v18.16.1
"vite": "^4.4.9",
"@originjs/vite-plugin-federation": "^1.2.3",

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Can't help without a reproduction. Do you use separate configs? Do you have something (a plugin) to process external imports?


Sdk 750 loginanonymous dart ruby typescript

Codecov Report

Merging #753 (e666656) into main (4713a9b) will decrease coverage by 26.62%.
The diff coverage is 49.39%.

@@             Coverage Diff             @@
##             main     #753       +/-   ##
===========================================
- Coverage   53.93%   27.30%   -26.63%
===========================================
  Files          14       55       +41
  Lines         432     5914     +5482
===========================================
+ Hits          233     1615     +1382
- Misses        199     4299     +4100

Impacted Files
Coverage Δ

ruby/lib/services/service_base.rb
84.21% <ø> (ø)

dart/lib/src/account_service.dart
60.65% <5.26%> (ø)

ruby/lib/services/account_service.rb
45.00% <30.76%> (ø)

ruby/lib/services/wallet_service.rb
70.58% <33.33%> (ø)

ruby/lib/services/credential_service.rb
82.60% <50.00%> (ø)

ruby/lib/services/template_service.rb
73.68% <50.00%> (ø)

ruby/lib/services/provider_service.rb
62.50% <66.66%> (ø)

ruby/lib/services/trust_registry_service.rb
86.20% <66.66%> (ø)

ruby/lib/security.rb
95.65% <100.00%> (ø)

ruby/lib/trinsic_services.rb
86.53% <100.00%> (ø)

... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02922e6...e666656. Read the comment docs.


camera extension mouse translation

when using the camera extension zooming out breaks the mouse position, but only if the camera is moved away from 0,0
when its at 0,0 there is no error in the reported possition, but when the camera isnt at 0,0 it all breaks down and the mouse position starts reporting wrong values by significant bit

Screen recording 2023-08-02 4.20.17 AM.webm
here is an example video of the bug

Screen recording 2023-08-02 4.20.17 AM.webm
here is an example video of the bug

The camera is only showing the costume, not the actual position

Screen recording 2023-08-02 4.20.17 AM.webm
here is an example video of the bug

The camera is only showing the costume, not the actual position

i feel like you have missed the entire point of the video

Screen recording 2023-08-02 4.20.17 AM.webm here is an example video of the bug

https://github.com/TurboWarp/extensions/assets/113154360/a61db7d2-a501-449d-8221-b6c6fb7ccb4d
here is another example

Merging into #930


CableReady installer

I've taken a first stab at the new unified CableReady Installer, and borrowed heavily from https://github.com/hotwired/turbo-rails/blob/main/lib/tasks/turbo_tasks.rake
Let me break it down for you a bit:

basically we have 2 install tasks, cable_ready:install:importmap, and cable_ready:install:node, where the main cable_ready:install task switches on the presence of an importmap.rb file
both installers do a sanity check if Redis and ActionCable are available, and optionally asks the user if Redis should be installed (https://github.com/stimulusreflex/cable_ready/pull/179/files#diff-e469da9bc01523658da7d880f0c454118061110611e92e21c3d69e0232ae983aR8)
the installers then do their pin/yarn add actions
finally, initializing CableReady in the application's entrypoint. I've taken my own experience as a heuristic here:

`import CableReady from "cable_ready"
if a ./channels/index.js is present, we're likely in a webpacker setup. Use that consumer to initialize CR.
if no such channels index is present, we can fall back on using the cable module exposed by @hotwired/turbo-rails.
else ask the user to do it manually.

I've tested many scenarios locally, but doing a bit of testing certainly wouldn't hurt 🙏

Hey :wave:
I've been playing with CR and SR on a greenfield app that's using Vite and ran into a couple of issues with some of the install tasks for both. I took some rough notes:
The helpers_generator here fails with Vite:
https://github.com/stimulusreflex/cable_ready/blob/1bded053b64e8f497fcf368a258b0326ea4c886f/lib/generators/cable_ready/helpers_generator.rb#L12-L22
It assumes the main_path is "app/javascript" and the entrypoint directory is named "packs".
A slight adjustment makes it work for either:
    main_folder = defined?(Webpacker) ? Webpacker.config.source_path.to_s.gsub("#{Rails.root}/", "") : "app/javascript"
++  main_folder = "app/frontend" if defined? ViteRuby

    filepath = [
      "#{main_folder}/controllers/index.js",
      "#{main_folder}/controllers/index.ts",
      "#{main_folder}/packs/application.js",
      "#{main_folder}/packs/application.ts",
++    "#{main_folder}/entrypoints/application.js",
++    "#{main_folder}/entrypoints/application.ts"
    ]

There are some similar install tasks in SR that also break in Vite but just need a very slightly different path. And there's this Webpacker-specific line that gets added during setup:
StimulusReflex.debug = process.env.RAILS_ENV === 'development'

which throws an error with Vite. It works with a slight (Vite-specific) adjustment:
--StimulusReflex.debug = process.env.RAILS_ENV === 'development'
++StimulusReflex.debug = import.meta.env.DEV

Obviously it's annoying AF having to cater to Webpacker / Shakapacker(!) / Importmaps / jsbundling-rails / Vite, but from the DX side of things it's really nice if the install tasks Just Work™ without any issues :man_shrugging:

Yeah, so this PR is about the main CR installer (which even doesn’t exist yet!)
shall we pull out your comment into an issue?

Closing in favor of #233


TLS MQTT Server Setup

Hello. I am trying to setup MQTT server via TLS. I can create TCP MQTT server but I couldnt create TLS MQTT server. I used this at commands for setup TCP mqtt server. It is working fine
AT+MQTTUSERCFG=0,1,"mrijxgpu","mrijxgpu","zPx3hoYuBRl5",0,0,""
AT+MQTTCONN=0,"hairdresser.cloudmqtt.com",16743,0
AT+MQTTSUB=0,"topic1",1
AT+MQTTPUB=0,"topic1","test1",1,0
AT+MQTTCLEAN=0
I will try to use thesee at commands for TLS MQTT server,
AT+CIPSNTPCFG=1,8,"ntp1.aliyun.com"
AT+CIPSNTPTIME?
AT+MQTTUSERCFG=0,3,"mrijxgpu","mrijxgpu","zPx3hoYuBRl5",0,0,""
AT+MQTTCONNCFG=0,0,0,"lwtt","lwtm",0,0
AT+MQTTCONN=0,"hairdresser.cloudmqtt.com",16743,0
AT+MQTTSUB=0,"topic",1
AT+MQTTPUB=0,"topic","test",1,0
AT+MQTTCLEAN=0
But the second at commands part When I send AT+MQTTCONN=0,"hairdresser.cloudmqtt.com",1883,0
It gives me error. What is wrong? I couldnt fix it. Please help!

@hiflord it looks ssl handshake failed.
Had you instead of CA certificates and re-compile?
here is a demo will show you how to connect to AWS by SSL, but it was written by Chinese.
ESP-AT 应用: AT+MQTT 对接亚马逊云
One more, you could collect the AT log for checking whether ssl handshake failed.

I am not good about network knowladge but here is my log

If I try to setup normal TCP server it is successfull. Here is my succesfull log

I tried AWS and it is failled too. What am I doing wrong?

Should I send any certificate for TLS?

I need document about load certificates.

@hiflord For easily understand, you could connect to your MQTT broker on PC firstly, via mosquitto or mqttfx.
then try with ESP32, maybe it could help you to understand.

Thank you for advice. it is logical.


Create Software Requirements Spec Template

Template for SRS is uploaded to Team A's Teams instance.

Uploaded USPS Informed Delivery App Enhancements SRS - Team A template to files under Milestone 1 folder.


Cleanup Kubernetes tests using fixtures

This PR creates fixtures for all resources used in the various Kubernetes tests from test_csi.py, test_flexvolume.py, and test_provisioner.py. These are the new fixtures added:

flexvolume (to create a Flexvolume that is directly attached to a pod)
pod
csi_pv (to create the PV and Longhorn volume needed in CSI volume testing)
pvc
storage_class

All these fixtures come with finalizers attached to them and will automatically clean themselves up regardless of whether or not the test passed.
These helper functions have been added for the fixtures to use for quickly accessing API instances (such as in the finalizers):

create_storage_api
create_core_api
create_longhorn_client

This PR has already been tested against Kubernetes v1.9.7 and v1.10.2.
This PR resolves #57.

Function names have already been fixed.
Yes, I've already tested the scenario in which the cases fail. The fixtures still run and clean up the resources left over by the test.


crio: add more artifacts for debugging

Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

/cc @runcom

Pushed up the changes. You might want to cast a narrower net, but that's up to you


Redifined style for Snake game

Redifined style for Snake game

Thanks a lot for this fix. I have reviewed and tested this fix as well. This is working fine as expected.


Please update

Is the current version available
使用manjaro 编译报错，
make: *** [Makefile:1232：moc_mainwindow.o] 错误 1

I'm working on it.. it takes 5 hours to compile a static Qt, and I misconfigured it so I need to recompile it.


Ajay/assign admin role to others

Addresses #42
If current admin leaves the room, someone from room is made as admin
If admin wants to make someone else admin he can click or right click on any of the user tiles and assign admin role to someone else
both click and right click does the same and both are enabled since right click on mobile devices - touch screens might not work as expected
Pending : Show a button to leave room and capture tab close : in both cases show an alert to admin to make someone else as host

I will review this


Better naming of cluster log files

I don’t like the format the names of the cluster log files have been changed to. It makes it impossible to figure out what log file relates to what job without digging into the snakemake stderr log (which is one of the main things I hate about nextflow).
Current implementation
self.logdir / "{jobid}_{random_string}.err".format(jobid=self.jobid, random_string=self.random_string)

Proposal
self.logdir / self.rule_name / self.wildcards_str / "jobid{jobid}_{random_string}.err".format(jobid=self.jobid, random_string=self.random_string)

Contrasting both implementations
# current
'logdir/2_random.out'
# proposed
'logdir/search_fasta_on_index/i=0/jobid2_random.out'

There are two major advantages I see to the new naming scheme.

It is easier to find the log file for a specific job without having to search for its jobid in the snakemake log.
For large pipelines that produce tens or hundreds of thousands of jobs, this will prevent there being potentially 200,000 log files in one directory. Which I guess might send the cluster into meltdown :sweat_smile:

I totally agree with this idea, it is indeed a very nice improvement!
I am not sure if we should worry about this (from https://unix.stackexchange.com/questions/32795/what-is-the-maximum-allowed-filename-and-folder-size-with-ecryptfs):
.

Linux has a maximum filename length of 255 characters for most filesystems (including EXT4), and a maximum path of 4096 characters.

filename length is not an issue, but when we add all wildcards of a rule to the log filepath, its length increases a lot. Sometimes I have rules where the wildcards are full paths to other files, but I don't think I ever hit the limit. Anyway, we can ensure the path has at most 4096 character, and cut some of the wildcards in case it exceeds, but I am just wondering if we should address this or not (seems like a rare corner case)?
That is the only possible issue I see we need to tackle, the rest is all fine. I really like this proposal

I think 4096 characters is more than sufficient. If someone hit that due to wildcards I would suggest there might be some changes they could make to their pipeline.
I think enforcing it is hard as I guess it could vary from file system to file system?

Yeah, I would just consider common linux filesystem, probably just EXT4. I think we should drop this. Hard to do it properly (work on any filesystem), and will tackle an extremely rare corner case.


This document needs updating to point people to Endpoint Manager - not the Azure Portal

Screenshots also need updating.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7df27add-73fe-4f0b-7e30-face0f95cda3
Version Independent ID: 3ec647d9-3470-8d8b-a941-d56f6522a35e
Content: Create a Windows Information Protection (WIP) policy with MDM using the Azure portal for Microsoft Intune (Windows 10) - Microsoft 365 Security
Content Source: windows/security/information-protection/windows-information-protection/create-wip-policy-using-intune-azure.md
Product: w10
GitHub Login: @Dansimp
Microsoft Alias: dansimp

Closing via #9575
Thank you


Add BitcrowdEcto.Changeset.auto_cast/3

This patch consolidates some versions of automatic casting we had flying around. This version features casting scalars & embeds as well as required validations based on :required or :optional options.
Additionally, this adds BitcrowdEcto.Assertions.assert_cast_error_on/2.

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Use-case is documented here https://bitcrowd.atlassian.net/browse/SIS-4357, but the code originated in another project and has existed in some variant in all our PDF/mail apps for ages.

I see, thanks for the reference. I am not a big fan of the auto_ prefix in the function since I don't see the "auto" in the implementation itself, it is just plain casting (less powerful than the Ecto.Changeset one but still). I would vote for removing the auto_ (not a strong opinion)

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Use-case is documented here https://bitcrowd.atlassian.net/browse/SIS-4357, but the code originated in another project and has existed in some variant in all our PDF/mail apps for ages.

I see, thanks for the reference. I am not a big fan of the auto_ prefix in the function since I don't see the "auto" in the implementation itself, it is just plain casting (less powerful than the Ecto.Changeset one but still). I would vote for removing the auto_ (not a strong opinion)

Open for other names, but just cast conflicts with Ecto.Changeset and client modules are likely to import both (in fact, BitcrowdEcto.Schema users do that automatically).
I thought auto_ because it's automatically figuring out the fields. How about inflect_cast?

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Use-case is documented here https://bitcrowd.atlassian.net/browse/SIS-4357, but the code originated in another project and has existed in some variant in all our PDF/mail apps for ages.

I see, thanks for the reference. I am not a big fan of the auto_ prefix in the function since I don't see the "auto" in the implementation itself, it is just plain casting (less powerful than the Ecto.Changeset one but still). I would vote for removing the auto_ (not a strong opinion)

Open for other names, but just cast conflicts with Ecto.Changeset and client modules are likely to import both (in fact, BitcrowdEcto.Schema users do that automatically).
I thought auto_ because it's automatically figuring out the fields. How about inflect_cast?

Sounds good, either that or apply_cast as well.

renamed to cast_all @ammancilla


Various updates for 0.7.0, including updating travis versions, plugin versions

Use latest Spark versions
Enable mima again for 2.12
Update version to 0.7.0
Clarify support in docs
Various plugin version updates

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   87.81%   87.81%
=======================================
  Files          14       14
  Lines         763      763
  Branches       62       62
=======================================
  Hits          670      670
  Misses         93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7399c74...84bb5f9. Read the comment docs.


Adding ochttp startOpts to exclude junk spans

https://github.com/fnproject/fn/issues/1525
Added startOptions to ochttp wrapper in server.go, excludes http traces with useragents that are blacklisted. Also reduces the ochttp sampler load by ignoring spans that dont need sampling.
Currently removes kube-probe and Prometheus requests
Used ochttp.GetstartOptions in handler https://godoc.org/go.opencensus.io/plugin/ochttp#Handler
Before:

Also possibly time to phase out
https://github.com/fnproject/fn/blob/efc3e3e4a495fe4b0b2693897101b36775726c7d/api/server/server.go#L705
Will require some extra changes but might as well get it out of the way


Updating UKIT009

This PR contains:

@MeliTaliani commit with MKIT009 update;
the refactor of the post-flashing operations after jetpack installation: now, this information is stored in the dedicated pages, so the Jetpack installation page is shorter and clearer now
the procedure to setup the Orin NX to be used with FRAMOS-IMX415 cameras

What is missing:

[x] software instruction about the UKIT009 update
[x] review of the kinematics of the new UKIT009

I'll keep the PR in draft until the previous points are addressed.
For the time being, I generated the documentation on my fork to see the output:

https://martinaxgloria.github.io/documentation/

cc @Nicogene @pattacini

I don't know if it is the cause of the CI failure, but I'm using a link whose target is not already present in the documentation (i.e. I wrote that in iKin the new iCub version will be available since release v2024.11.0 with the reference to the markdown that not exist yet). When I do mkdocs serve to build the page locally, I retrieved only a warning and the page is built anyway.

I removed the reference to the page that doesn't exist yet and I will add that once we have the release v2024.11.0

Thanks heaps for the contributions!
I'll be reviewing the PR in the next few days.

Hi @pattacini, thanks for the review!
About:

Ubuntu 18.04 is far away in the past and I guess we no longer need to address it.
That said, it could be still convenient to keep this info about installing the latest CMake wrt the version shipped with a specific Ubuntu distro.
If this is the case, then I would only rephrase the intro saying when these instructions may apply and why.

you're right, I kept this info since, if I remember well, the Xavier NX is Ubuntu 18.04 based yet. But this board will become outdated with the UKIT009 update, so we could think about removing it from the documentation and refactoring the CMake installation instructions depending on the OS version.
About the number of pages for the post-flashing operations, instead, talking with @Nicogene we agreed that the Jetpack installation page was too long and that it'll be better to remove the post-flashing operations from that page and re-organize this section into small dedicated pages. Tomorrow or in the next few days we can align f2f on that

About the number of pages for the post-flashing operations, instead, talking with @Nicogene we agreed that the Jetpack installation page was too long and that it'll be better to remove the post-flashing operations from that page and re-organize this section into small dedicated pages. Tomorrow or in the next few days we can align f2f on that

Disagree with that 😉

Honestly I don't like the final rendering that is split into so many pages.
Also, an intro page for the post-flashing is missing, which is, I think, the only page we may refer in the navigation section.

In https://github.com/icub-tech-iit/documentation/pull/370/commits/33e7dc75d1bacbc973337663fcc487e1e9643e0b I applied the suggested changes after the f2f chat we had yesterday (cc @Nicogene @pattacini). In particular, I:

created an introduction page for the post-flashing operations with a table of context in which are listed the available optional procedures (I removed the "optional" from the title of each page)
removed from the navigation tree those pages and I added only the introduction page for both iCub and ergoCub installation
added an admonition with a reference to the jetpack installation page: in this way, each page can self-exists
removed the procedures for the creation of the backup image (not working) and cmake installation for Ubuntu 18.04 (not needed)

I regenerated the pages if you want to see the output now

Hi @pattacini,
here https://github.com/icub-tech-iit/documentation/pull/370/commits/40ff57e5e91d04f90c8c9d9db2afcabaf0a9620a you can find the changes you suggested. I added the CMake installation instructions again but for Ubuntu 20.04 since it is required for yarp v3.10.0 and we had to follow this procedure on the laptop of iCubGenova11 which has Ubuntu 20.04 yet
Please, let me know if it's ok now, thanks!


I'm using it to generate PDF's from a database and it's working brilliantly until I try to change the page size to 'A4' from the default. The PDF still gets generated and appears to be OK until it comes to printing and I get a PostScript error:
ERROR: invalidfont
OFFENDING COMMAND: xshow
Switching from:
var doc = new PDF;
to
var doc = new PDF({     size: 	'A4' });
causes the problem.
Any suggestions as to what I'm doing wrong?

Found this closed issue: https://github.com/devongovett/pdfkit/issues/69
That fixed the problem. Convert the font to SVG and back to TTF and everything is fine.


Uncaught Error: The specified module could not be found./?~\AppData\Local\atom\app-1.54.0\res...

Seemingly any keyboard input

Atom: 1.54.0 x64
Electron: 6.1.12
OS: Microsoft Windows 10 Home
Thrown From: Atom Core
Stack Trace
Uncaught Error: The specified module could not be found.
\?\C:\Users\admin\AppData\Local\atom\app-1.54.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At electron/js2c/asar.js:138

Error: The specified module could not be found.
\\?\C:\Users\admin\AppData\Local\atom\app-1.54.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.func (electron/js2c/asar.js:138:31)
    at process.func [as dlopen] (electron/js2c/asar.js:138:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:828:18)
    at Object.func (electron/js2c/asar.js:138:31)
    at Object.func [as .node] (electron/js2c/asar.js:147:18)
    at Module.load (internal/modules/cjs/loader.js:645:32)
    at Function.Module._load (internal/modules/cjs/loader.js:560:12)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:16:16)
    at customRequire (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:1:723602)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:14:2799883)
    at get_manager (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:14:2799985)
    at Object.getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:14:2800111)
    at e.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:14:1057803)
    at KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:11:1228079)
    at KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:11:1226064)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.54.0/resources/app/static/<embedded>:11:284879)

Commands
     -1:58 core:copy (span.syntax--markup.syntax--underline.syntax--link.syntax--https.syntax--hyperlink)
  2x -1:03.6.0 core:save (input.hidden-input)

Non-Core Packages
atom-beautify 0.33.4
autocomplete-wordpress-hooks 0.2.3
color-picker 2.3.0
ftp-remote-edit 0.18.0
lorem 4.0.0
minimap 4.30.2
minimap-bookmarks 0.4.2
wordpress-api 1.2.2

Fixed by reinstalling Atom.

Fixed by reinstalling Atom.

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/21285. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.a

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/21285. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.a


Poor sinf/cosf performance compared to the Segger math libraries

The performance of the sinf/cosf functions in NEWLIB on Zephyr seems very poor compared to the Segger C libraries used in the nRF5 SDK for the nRF52 series.
Preliminary numbers (until I have time to do a more controlled test) imply a runtime of around 15us on the nRF53 @ 128MHz, vs ~2.5us on the nRF52 @ 64MHz.
An interesting aspect is that replacing cosf with cos only leads to a 30-40% increase in runtime, which indicates that the cosf implementation doesn't properly utilize the floating point unit in the nRF53 (32-bit floating point with HW acceleration should be significantly faster than 64-bit float without HW acceleration).
Update:
I did some more testing, and to my surprise found that in a simpler test the difference between the SES libraries and the NEWLIB libraries was much smaller.
The following code snippet ran at 2.65ms in the SES build vs 2.95ms using the current Zephyr master branch with NEWLIB.
#define ITERATIONS 1000
float PI = 3.141592653f;
float input = -2.0f*PI;
float epsilon = 4.0f*PI / (float)ITERATIONS;
float result;
// Start measurement
for(int i = 0; i < ITERATIONS; i++)
{
  result = cosf(input);
  input += epsilon;
}
// Stop measurement

The CONFIG_NEWLIB_LIBC_NANO parameter did not appear to have an impact.
Investigating my original algorithm I realized that the input values to the cosf/sinf functions were much larger, and when I changed my test above to initialize input to -200PI instead of -2PI the results were dramatically different.
The Zephyr runtime increased to 39.6ms (more than 13 times slower), while the SES implementation only increased runtime by about 1%.
So I think this explains why I saw very poor performance in the first place. Either the NEWLIB implementation is not very well suited to handle large positive or negative input values to the cosf/sinf function, or something is wrong in my project configuration.

The newlib libm implementation is in C and there is currently no ARM-optimised (asm) implementation available (hence, slow performance).
I expect these math performance issues to be mostly addressed by adding the CMSIS-DSP library support (I am currently working on this; there is a preliminary PR for it too: #21600).

If you can, please try benchmarking against arm_sin_f32 and arm_cos_f32 in the PR; tests/lib/cmsis_dsp/fastmath would be a good base to use.

which indicates that the cosf implementation doesn't properly utilize the floating point unit

Please check/post the asm listing of the sinf and cosf functions.

I tried using PR #21600, but I don't see improved performance (actually it is slightly slower, 3.0/40.6ms vs 2.96/39.6ms).
I use this prj.conf, with floating point enabled:
CONFIG_GPIO=y
CONFIG_NEWLIB_LIBC=y
.map file added for reference:
zephyr_map.zip
Do I need to do something to enable the new math libraries?

@too1 When running performance tests, please make sure that all operational variables are declared volatile so that the compiler doesn't try anything funny (e.g. nuking them).
I have tested newlib cosf and CMSIS-DSP arm_cos_f32 functions and I see quite a significant performance difference between them:

input
cosf(newlib)
arm_cos_f32(CMSIS-DSP)

2 * pi
1,408,960
577,594

200 * pi
15,040,964
578,479

(in cycles, measured with DWT on Cortex-M7; ATSAME70 Rev. B)
Test code: https://gist.github.com/stephanosio/3a2de5e7f192acd5860d9ce866e1f2ba
You can also checkout the following test branch and run the modified samples/hello_world:
https://github.com/stephanosio/zephyr/tree/cmsis_dsp_perf_test/samples/hello_world

Closing this since the relatively slow performance of the trigonometric functions provided by the newlib (libm) on ARM is really an upstream newlib issue and not a Zephyr issue.
A workaround has been provided through the CMSIS-DSP library, which provides the optimised high performance trigonometric function implementations for the ARM targets.


Issue #90 Add codeReadyContainer as invoker for installer

This change will make it easy to search the codeReadyContainer invokers
from the telemeter side.

After introducing the OPENSHIFT_VERSION environment variable, are we really going to be using both the env var and the tagging?

@cfergeau yes, if I want to just spin up a cluster which I find in the tag then I checkout the tag (don't set the environment variable) and good to go. If I want to spin cluster (4.1.10) which is not tagged but near to tag-4.1.13 I can checkout that tag and set the environment variable and good to go.


Question - Load dropdown menu from anywhere

Hi,
I am currently working on a project where I have a grid with an action column that has an action button that I want to display a menu dropdown.
The grid can have thousands of rows, so I don't want to create a menu for each row, just create one menu that is displayed under which ever row action button is clicked.
Is this possible with ng2-bootstrap dropdown? Or do I need to find another component/build one myself/extend yours that does this?
Many thanks

See #1838

@psaussure Not sure how that issue answers my question?

Sorry, mistake. It wasn't.

It sure would be nice to see how to do this with ng2-bootstrap but you can also take a look at PrimeNG components. They have a lot of non-bootstrap based components.
https://github.com/primefaces/primeng

@ctrl-brk your answer is not directly linked to question, stack overflow gives readonly status for such ;)

@pgeyman support for such feature is in roadmap for v3 :)


Type-only boolean props do not work in production mode

Version
3.2.21
Reproduction link
Repo: github.com
Example: https://confident-agnesi-a384b9.netlify.app/
Steps to reproduce

Define a component with a boolean prop using the type-only defineProps syntax.

defineProps<{ checked?: boolean }>()

Render the component using a prop with no value

<Child checked />

Build for production

What is expected?
The child component should be rendered with the prop defined as true. The correct behavior occurs in development mode.

What is actually happening?
The prop is defined as an empty string and interpreted as false

It looks like the minified code is not matching what is described in the documentation

In prod mode, the compiler will generate the array format declaration to reduce bundle size (the props here will be compiled into ['foo', 'bar'])

But looking at the dist files, I see props:{checked:null}

Closing, looks like a duplicate of https://github.com/vuejs/vue-next/issues/4783 and I expect will be fixed with the next patch release.


"CURL_IPRESOLVE_V4" bug  on hhvm

/bugsnag/bugsnag/src/Bugsnag/notification.php line 110;
curl_setopt($http, CURL_IPRESOLVE_V4, true);
problem with php-hhvm system. If close the this option everything works well

This is not a bug with this package.

@barisbora when you say "close this option" what do you mean?
Could we add a check that skips this line on hhvm?

On hhvm, Laravel 5.0.26 with bugsnag;
i am getting this error "option 1 in not a valid",
/bugsnag/bugsnag/src/Bugsnag/notification.php line 110;
when i was delete curl_setopt($http, CURL_IPRESOLVE_V4, true); line, problem resolved.
Note: only hhvm installed server is getting this error.
if (!defined('HHVM_VERSION')) {
curl_setopt($http, CURL_IPRESOLVE_V4, true);
}
its worked for me. Both hhvm and normal ngix server

Would this work?
if (defined('HHVM_VERSION')) {
  curl_setopt($http, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
} else {
  curl_setopt($http, CURL_IPRESOLVE_V4, true);
}

It looks like HHVM might just have a different interface to set this

yes work and its better

Fixed in v2.5.4 of bugsnag-php. Thanks


iOS: No OpKernel for Pow op

We're running a model on iOS and finding that the tf.pow Pow op is not supported; we added a line with tensorflow/core/kernels/cwise_op_pow.cc to tensorflow/contrib/makefile/tf_op_files.txt, rebuild TensorFlow, and after that, the model worked.
Could this op be added to the iOS makefile so that in the future other folks do not run into this problem?
(I would submit a PR but this is at a company that has not signed the TensorFlow CLA so for such a small change it is not worth the hassle.)

This has been taken care of by the referenced PR, so I am closing this.


Added nested associations resolver

The new resolver function is a followup of discussion #34. Added support for multilevel associations. Also added a few unit tests for different relationships.

I'll be adding more unit tests for the resolver. @DanielHreben please review and lmk the necessary changes to be made.
Thanks

I will update the PR, Thanks!!

@DanielHreben Can you review the PR again? Also could you please help me with the failing checks.
There should be some easy fix which I'm unable to figure out.

I think CodeClimate checks failing because tests are not configured to be checked by codeclimate and ignored. But your new tests are placed other directory, and for some reason codeclimate decided to check them. I suggested to merge your new tests with existing tests suite, that should help. Good job, btw!

👍

Awesome. Thanks


Support projects that log something on startup

This should fix #1
@joao-maria-bose would you mind checking if this works for you?
If you want to use docker, I pushed an image with the following tag studzien/graf:support-projects-logging-at-startup

This works, thanks @studzien!
It'll however fail for projects that keep logging stuff but I guess that is an edge case and documenting it should be enough

Do you mean when a log message is printed after the result of either of the mix commands (checking if a project is an umbrella or getting the compile path?), but before the mix exits?
I'll try to reproduce something like this in a testcase.

Yes, something like a discovery service logging stuff at a fixed interval, for example. But again, this might just be a really edge case that properly documented has a quick and easy workaround - disabling Logger for a specific env 🤷♂


Integrate with argoCD to support continuous delivery

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #51
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm


updates to readme file

request for pull request from development team.

As an integrator u can accept/merge the pull request or deny it.. am good with this change.


Automated E2E Tests

We have some tests in https://github.com/extism/go-sdk/blob/main/extism_test.go


Issue with rust 1.47 while building the discovery handler docker file -  rust version 1.54 fixes this.

Hi,
I tried to build the discovery handler docker and was facing the below error related to tower-http as shown in the screenshot. Later figured out that if we update the rust version to 1.54 it fixes the issue.  Perhaps somebody can update the dockerfile with the 1.54 rust version  ?!?

FROM amd64/rust:1.54 as build
RUN rustup component add rustfmt --toolchain 1.54.0-x86_64-unknown-linux-gnu
RUN USER=root cargo new --bin dh
WORKDIR /dh
COPY ./Cargo.toml ./Cargo.toml
RUN cargo build --release && \
    rm ./src/*.rs && \
    DEP_PATH=`echo "./target/release/deps/{{project-name}}*" | tr - _` && \
    rm $DEP_PATH
COPY ./src ./src
RUN cargo build --release

FROM amd64/debian:buster-slim
RUN apt-get update && \
    apt-get install -y --no-install-recommends libssl-dev && \
    apt-get clean
COPY --from=build /dh/target/release/{{project-name}} /{{project-name}}
ENTRYPOINT ["/{{project-name}}"]

@vinaypuranik great find! Would you be interested in contributing the fix?

Yeah, sure. I would need repo access to create PR

Yeah, sure. I would need repo access to create PR

@vinaypuranik you should be able to fork the repository and then create a PR with the changes from that fork. This blog is a good summary of the proper workflow.

@kate-goldenring Ah, okay :) Thanks Kate.  I have created the PR for the same here -> https://github.com/deislabs/akri-discovery-handler-template/pull/3


Issues with translation + level/skills editing doesn't work

The translation file from English to Italian is kind of lackluster. Some translations don't make much sense in context, while there are also some mistakes. I fixed a couple of them in the file (which I'm willing to share in a fork so this issue can be fixed), but I also noticed that some parts of the form don't translate at all regardless of language, namely the "Truck" button and all the Trailer settings buttons. I took a peek into the code, but I'm not a C# developer so I couldn't do much.
Another issue I found out is editing level and skills, which straight up does not work. I tried editing level and skills alone, then adding/removing money to confirm that the save was being edited, but neither attemps worked.

Same thing happened to me

I have same issue with editing player level and skills, it doesn't even work. Even when I open the save file immediately after editing the save file it is not showing what I changed.

Can confirm the same issue: money works but levels and skills don't work

But I tried the previous version, in that the skills and levels works. So used the previous version for the levels and skills and the latest version for the rest of it. Try the previous version for this issue.

I imagined you could go back to a previous working version, it's just that this version (I haven't seen any of the previous) is so not refined and poorly kept together. The developer also doesn't seem to contribute much anymore either, this GitHub version appears to be older than the one found on external forums. I wish the developer were more in the picture so other people could suggest what to fix since this seems to be the only tool that allows this type of modifications.

Fixed with new version.
Translation can be sent via email.


Probe label

is there a better way to rerender the pragma to instantly store the label than with
...
self codeContentChanged.
self containingBrowser codeTextMorph accept.

Pull Request Test Coverage Report for Build 880125901

42 of 173 (24.28%)  changed or added relevant lines in 15 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.08%) to 64.257%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Babylonian-UI.package/BPProbeMorph.class/instance/updateFrom..st
0
1
0.0%

packages/Babylonian-UI.package/BPStyler.class/instance/unstyledTextFrom..st
0
1
0.0%

packages/Babylonian-UI.package/BPProbeMorph.class/instance/setLabelButtonClicked.st
0
7
0.0%

packages/Babylonian-UI.package/BPProbeMorph.class/instance/updateExpressionMorphIfNecessary.st
0
17
0.0%

packages/Babylonian-UI.package/BPProbeMorph.class/instance/newAddLabelMorph.st
0
20
0.0%

packages/Babylonian-UI.package/BPProbeMorph.class/instance/defaultLabel.st
0
23
0.0%

packages/Babylonian-UI.package/BPProbeMorph.class/instance/newLabelMorph.st
0
31
0.0%

packages/Babylonian-UI.package/BPProbeMorph.class/instance/updateLabelMorphIfNecessary.st
0
31
0.0%

Totals

Change from base Build 879674766:
-1.08%

Covered Lines:
4284

Relevant Lines:
6667

💛  - Coveralls


Release target, Debug output

Brief Issue Summary
Target is Release by setting "CMAKE_BUILD_TYPE": "Release" in the CMakePresets.json file.
using the CMake Debugger I see inconsistent values set:

Output from build:
[build]   Building Custom Rule G:/dev/cmaketest/CMakeLists.txt
[build]   main.cpp
[build]   cmaketest.vcxproj -> G:\dev\cmaketest\bin\Debug\cmaketest.exe
CMake Tools Diagnostics
[main] Building folder: cmaketest
[expand] expanding cmake
[main] Saving open files before configure/build
[expand] expanding cmake
[expand] expanding cmake
[build] Starting build
[driver] Start build
[expand] expanding --build
[expand] expanding g:/dev/cmaketest/build/vs_release
[expand] expanding --parallel
[expand] expanding 34
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" --build g:/dev/cmaketest/build/vs_release --parallel 34
[proc]   with environment: {"ALLUSERSPROFILE":"C:\\ProgramData","AMDRMSDKPATH":"C:\\Program Files\\AMD\\RyzenMasterSDK\\","APPDATA":"C:\\Users\\tengai\\AppData\\Roaming","APPLICATION_INSIGHTS_NO_DIAGNOSTIC_CHANNEL":"1","CHROME_CRASHPAD_PIPE_NAME":"\\\\.\\pipe\\crashpad_40236_FRQZBGHRRJHZTDPK","COMPUTERNAME":"MSI_MAG","ComSpec":"C:\\Windows\\system32\\cmd.exe","CommonProgramFiles":"C:\\Program Files\\Common Files","CommonProgramFiles(x86)":"C:\\Program Files (x86)\\Common Files","CommonProgramW6432":"C:\\Program Files\\Common Files","DriverData":"C:\\Windows\\System32\\Drivers\\DriverData","EFC_6040":"1","ELECTRON_RUN_AS_NODE":"1","HOMEDRIVE":"C:","HOMEPATH":"\\Users\\tengai","LOCALAPPDATA":"C:\\Users\\tengai\\AppData\\Local","LOGONSERVER":"\\\\MSI_MAG","NUMBER_OF_PROCESSORS":"32","ORIGINAL_XDG_CURRENT_DESKTOP":"undefined","OS":"Windows_NT","OneDrive":"C:\\Users\\tengai\\OneDrive","PATHEXT":".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC","PROCESSOR_ARCHITECTURE":"AMD64","PROCESSOR_IDENTIFIER":"AMD64 Family 25 Model 97 Stepping 2, AuthenticAMD","PROCESSOR_LEVEL":"25","PROCESSOR_REVISION":"6102","PSModulePath":"C:\\Program Files\\WindowsPowerShell\\Modules;C:\\Windows\\system32\\WindowsPowerShell\\v1.0\\Modules","PUBLIC":"C:\\Users\\Public","Path":"C:\\Program Files (x86)\\Common Files\\Oracle\\Java\\javapath;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\Windows\\System32\\OpenSSH\\;","ProgramData":"C:\\ProgramData","ProgramFiles":"C:\\Program Files","ProgramFiles(x86)":"C:\\Program Files (x86)","ProgramW6432":"C:\\Program Files","SESSIONNAME":"Console","SystemDrive":"C:","SystemRoot":"C:\\Windows","TEMP":"C:\\Users\\tengai\\AppData\\Local\\Temp","TMP":"C:\\Users\\tengai\\AppData\\Local\\Temp","USERDOMAIN":"MSI_MAG","USERDOMAIN_ROAMINGPROFILE":"MSI_MAG","USERNAME":"tengai","USERPROFILE":"C:\\Users\\tengai","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_CODE_CACHE_PATH":"C:\\Users\\tengai\\AppData\\Roaming\\Code\\CachedData\\611f9bfce64f25108829dd295f54a6894e87339d","VSCODE_CRASH_REPORTER_PROCESS_TYPE":"extensionHost","VSCODE_CWD":"C:\\Users\\tengai\\AppData\\Local\\Programs\\Microsoft VS Code","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","VSCODE_IPC_HOOK":"\\\\.\\pipe\\e3ec2487-1.90.1-main-sock","VSCODE_L10N_BUNDLE_LOCATION":"","VSCODE_NLS_CONFIG":"{\"locale\":\"en-us\",\"osLocale\":\"en-us\",\"availableLanguages\":{},\"_languagePackSupport\":true}","VSCODE_PID":"40236","windir":"C:\\Windows"}
[build] MSBuild version 17.10.4+10fbfbf2e for .NET Framework
[build]
[build]   1>Checking Build System
[build]   Building Custom Rule G:/dev/cmaketest/CMakeLists.txt
[build]   main.cpp
[build]   cmaketest.vcxproj -> G:\dev\cmaketest\bin\Debug\cmaketest.exe
[driver] Build completed: 00:00:00.676
[cmakefileapi-parser] Read reply folder: g:\dev\cmaketest\build\vs_release\.cmake\api\v1\reply
[cmakefileapi-parser] Found index files: ["cache-v2-4cdfd5cd365193e95fa0.json","cmakeFiles-v1-a99b99d1dcae1d8b6cbe.json","codemodel-v2-5aa90601171cace3b494.json","directory-.-Debug-d0094a50bb2071803777.json","directory-.-MinSizeRel-d0094a50bb2071803777.json","directory-.-Release-d0094a50bb2071803777.json","directory-.-RelWithDebInfo-d0094a50bb2071803777.json","index-2024-06-13T21-59-33-0164.json","target-ALL_BUILD-Debug-4f031107cb65c5d86a82.json","target-ALL_BUILD-MinSizeRel-4f031107cb65c5d86a82.json","target-ALL_BUILD-Release-4f031107cb65c5d86a82.json","target-ALL_BUILD-RelWithDebInfo-4f031107cb65c5d86a82.json","target-cmaketest-Debug-583dc167010728bf41c2.json","target-cmaketest-MinSizeRel-7b20aa68503247c998bd.json","target-cmaketest-Release-caf7a8a5d9ac7faaddd3.json","target-cmaketest-RelWithDebInfo-201f29ce9bf298a820d7.json","target-ZERO_CHECK-Debug-6262fa8b4446a7988aa8.json","target-ZERO_CHECK-MinSizeRel-6262fa8b4446a7988aa8.json","target-ZERO_CHECK-Release-6262fa8b4446a7988aa8.json","target-ZERO_CHECK-RelWithDebInfo-6262fa8b4446a7988aa8.json","toolchains-v1-9a5931a20e5c7dd3bed0.json"]
[expand] expanding cmake
[expand] expanding G:/dev/cmaketest
[build] Build finished with exit code 0
[expand] expanding cmake
[cache] Reading CMake cache file g:/dev/cmaketest/build/vs_release/CMakeCache.txt
[cache] Parsing CMake cache string
[expand] expanding cmake
[extension] [1603] cmake.build finished (returned 0)
[expand] expanding cmake
[cache] Reading CMake cache file g:/dev/cmaketest/build/vs_release/CMakeCache.txt
[cache] Parsing CMake cache string

Debug Log
No response
Additional Information
configurePresets": [
{
"name": "vs_release",
"displayName": "VS Release Custom preset",
"description": "Sets Visual Studio generator, build and install directory",
"generator": "Visual Studio 17 2022",
"binaryDir": "${workspaceFolder}/build/${presetName}",
"architecture": {
"value": "x64",
"strategy": "external"
},
"cacheVariables": {
"BOOST_ROOT": "G:/dev/boost_1_85_0",
"CMAKE_BUILD_TYPE": "Release"
}
}
]

CMAKE_BUILD_TYPE is not set by CMake when using a multi-config generator such as "Visual Studio 17 2022." This is because all build types will be generated in a single configuration pass.  If you would like to select which build types are generated, you can use the CMAKE_CONFIGURATION_TYPES variable.  Otherwise, if you need for CMAKE_BUILD_TYPE to exist during generation, you will need to switch to a single-config generator, such as Ninja.

Ok, but  VC is only building a debug exe. Why wouldn't it be buidling all types?  How do I get a release build?
And want about this CMAKE_BUILD_TYPE_INT being set to debug? What is its purpose and how is it set to "release"?

And what about this CMAKE_BUILD_TYPE_INT being set to debug? What is its purpose and how is it set to "release"?

I don't see any documentation for it, so I suppose it is an internal variable and probably matches the first build type in the CMAKE_CONFIGURATION_TYPES list.  You could probably test out that theory by changing CMAKE_CONFIGURATION_TYPES to something else. (e.g. Release;Debug;RelWithDebInfo;MinSizeRel)

Ok. I think I'm starting to understand how "configurePresets" and "buildPresets" work.
I believe the understanding is: "many to one", many "buildPresets" to one "configurePresets". Originally, I thought it was "one to one".
For example here are Release/Debug "buildPresets" for different "configurePresets".

{
    "version": 6,
    "configurePresets": [
        {
            "name": "VS_x64",
            "hidden": false,
            "generator": "Visual Studio 17 2022",
            "binaryDir": "${workspaceFolder}/build/${presetName}",
            "description": "Visual build.",
            "cacheVariables": {
                 "BOOST_ROOT": "G:/dev/boost/boost_1_85_0"
            }
        },
        {
            "name": "Ninja_x64",
            "hidden": false,
            "generator": "Ninja",
            "binaryDir": "${workspaceFolder}/build/${presetName}",
            "description": "Ninja build.",
            "cacheVariables": {
                "CMAKE_EXPORT_COMPILE_COMMANDS": "YES",
                "BOOST_ROOT": "G:/dev/boost/boost_1_85_0"
            }
        }
    ],
    "buildPresets": [
        {
            "name": "Release_VC",
            "hidden": false,
            "description": "",
            "displayName": "",
            "configuration": "Release",
            "configurePreset": "VS_x64"
        },
        {
            "name": "Debug_VC",
            "hidden": false,
            "description": "",
            "displayName": "",
            "configuration": "Debug",
            "configurePreset": "VS_x64"
        },
        {
            "name": "Release_Ninja",
            "hidden": false,
            "description": "",
            "displayName": "",
            "configuration": "Release",
            "configurePreset": "Ninja_x64"
        },
        {
            "name": "Debug_Ninja",
            "hidden": false,
            "description": "",
            "displayName": "",
            "configuration": "Debug",
            "configurePreset": "Ninja_x64"
        }
    ]
}

Ok, now this makes sense. However, I need to urge Microsoft they need to do a better job at explaining how "buildPresets" and "configurePresets" work in the IDE.
For example, this needs to be better explained:

single-config generators (e.g. Ninja) do not need buildPresets unless you want to set up different command line options for the build. The build type is already set during the configuration step.
multi-config generators (e.g. Visual Studio, Ninja Multi-Config) do need buildPresets - at the very least to select the active build type for the build.
When to add "CMAKE_BUILD_TYPE": "Release|Debug" and when to use "configuration": "Release|Debug" (so important!)

Unfortunately, the CMake documentation doesn't make these real-use-case very clear.
I was coming from Mac Visual Code and everything is working correctly. But this is because it uses "Unix makefiles" which is single-config generator and I was convinces the Visual Code and CMake on Windows was broken.
Thanks for the clarification!
Patrick

Ok, now this makes sense. However, I need to urge Microsoft they need to do a better job at explaining how "buildPresets" and "configurePresets" work in the IDE.
For example, this needs to be better explained:
...
Unfortunately, the CMake documentation doesn't make these real-use-case very clear.

I've almost encountered the same issue as you, and these discussions have now helped me understand. I couldn't agree with you more; the documentation indeed lacks some crucial (and conspicuous) explanations.

@inkbottle-9 Thank you very much for your reply, our developers will continue to improve this document!

@inkbottle-9 @tengai650 Thanks for the feedback. We've made notes on our side, but to best help move this forward, could you also create an issue on the Kitware repository so that they can be made aware of this feedback as well?
https://gitlab.kitware.com/cmake/cmake/-/issues


[Feature Request] 1.20.1 update, please and thank you!

Title.

Will be coming soon, is this an urgent request for a release on your side or could that wait a month until I am done with other stuff?

take your time! i can always add it into my modpack :)


Using discriminated unions with switch cases throws errors if not returned inside case block

TypeScript Version:  2.2.2
Code
interface Square {
    kind: "square";
    size: number;
}
interface Rectangle {
    kind: "rectangle";
    width: number;
    height: number;
}
interface Circle {
    kind: "circle";
    radius: number;
}

type Shape = Square | Rectangle | Circle;

// Works fine
function area(s: Shape) {
    switch (s.kind) {
        case "square": return s.size * s.size;
        case "rectangle": return s.height * s.width;
        case "circle": return Math.PI * s.radius ** 2;
    }
}

function area2(s: Shape) {
    let result: number = 0;
    switch (s.kind) {
        case "square":
            result = s.size * s.size;
        case "rectangle":
            result = s.height * s.width; // ERROR: Property 'height' does not exist on type 'Square | Rectangle'. Property 'height' does not exist on type 'Square'.

        case "circle":
            result = Math.PI * s.radius ** 2; // ERROR: Property 'radius' does not exist on type 'Shape'. Property 'radius' does not exist on type 'Square'.'
    }
    return result;
}

Expected behavior:
area2 function should compile.
Actual behavior:
area2 function does not compile.

case implicitly falls-through in JavaScript. Use the break keyword to stop that. The compiler rightfully complains, because s might be any of the preceding types if you don't "escape" from the case when you have your job done.
function area2(s: Shape) {
    let result: number = 0;
    switch (s.kind) {
        case "square":
            result = s.size * s.size;
            break; // <--- stops the following code from execution
        case "rectangle":
            result = s.height * s.width;
            break; // <--- stops the following code from execution

        case "circle":
            result = Math.PI * s.radius ** 2;
    }
    return result;
}

@gcnew thanks. I am seriously considering a special label for these "Nonworking code reports error in TS" issues!


godot_net.h includes reference types

I believe the header files are meant to be C-compatible, but godot_net.h includes reference types (for example int &r_received on line 54).
Means I can not compile C code using GDNative if I want to #include "net/godot_net.h"

Indeed! @faless probably overlooked that when creating the C headers

I updated the files based on Godot 3.1 stable, did that get these changes included? if so this issue is probably resolved.

@BastiaanOlij yep, that was merged before 3.1 release, and the changes are already there in the 3.1 branch:
https://github.com/GodotNativeTools/godot_headers/blob/3.1/net/godot_net.h
The issue can be closed

Perfect!


Vickel: Watch usamedzz.com

Vickel requests the watch of the watch_keyword usamedzz\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

usamedzz\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


kvm: fix docker volume semantics

Closes #2534
Reverts #2535

LGTM but needs rebase: let's create a rebased PR: https://github.com/coreos/rkt/pull/2558