Repositories with >1000 tags experience a performance hit with the changes to how tags are evaluated

See #22.

We are noticing a performance hit where it take 2 minutes just to bump the version. We have about 300 version tags in our repo. Another one of our repos has about 600 version tags and it take 4 minutes just to do a version bump. We have the same performance hit when looking up the version. Also, if one cookbook depends on other cookbooks that have a lot of version tags the performance hit just keeps compounding.
Can't we accomplish all we need by just checking the latest tag instead of iteration through all the tags in the branch? Wouldn't something like git describe --abbrev=0 work for the purposes of thor-scmversion?


Running two consecutive COUNT aggregations breaks the analysis

Example: Running Points to Polygon analysis (Which can at the moment only be aggregated by count), then intersecting that to obtain a count from a points dataset breaks the analysis & viz. Deleting broken analysis and refreshing page breaks builder.
Error: column "count_vals" specified more than once

Hey @namessanti it can be aggregated by other operations as well. Is that not showing you other options when clicking?

cc/ @javisantana

Another example
1.3 - ATM Network Performance (on 2016-10-13 at 23.18.19).carto.zip

@saleiva @xavijam In my opinion, this is a key workflow that should be solved. For instance, I have Madrid neighborhoods and a set of points layers such as hospitals, green areas, libraries and so on. I could intersect one by one with the neighborhoods layer, and then use the autostyle to show the variability both geographically and thematic.

Added next so we can attack this sooner

+1, BCG also reporting this behavior.

I'm looking into this.
The problem is that both the aggregate-intersection/"Insersect second layer" and group-points/"Group points into polygons" (convex-hull, boundix-box, concave-hullnodes) analysis add columns named count_vals when agregating by count.
Son in our case, which chains two such analyses, camshaft tries to create an analysis cache table like this one (with two count_vals columns):
CREATE TABLE analysis_b194a8f896_dcb3c5cac4fbf0062380d58a0b3497ab0d531320 AS
SELECT * FROM (
  SELECT
    _cdb_analysis_source.cartodb_id,
    _cdb_analysis_source.category,
    _cdb_analysis_source.the_geom,
    _cdb_analysis_source.count_vals, count(_cdb_analysis_target.cartodb_id) as count_vals,
    count(_cdb_analysis_target.cartodb_id) / GREATEST(0.0000026, ST_Area((ST_Transform(_cdb_analysis_source.the_geom, 4326))::geography)) as count_vals_density
  FROM (
    SELECT
      row_number() over() as cartodb_id,
      distrito as category,
      ST_ConvexHull(ST_Collect(the_geom)) AS the_geom,
      count(1) as count_vals
    FROM (
      SELECT * FROM points_table
    ) _analysis_source
    GROUP BY distrito
  ) _cdb_analysis_source,
  (SELECT * FROM points_table) _cdb_analysis_target
  WHERE ST_Intersects(_cdb_analysis_source.the_geom, _cdb_analysis_target.the_geom)
  GROUP BY _cdb_analysis_source.cartodb_id, _cdb_analysis_source.category, _cdb_analysis_source.the_geom, _cdb_analysis_source.count_vals
) _analysis_create_table_query
LIMIT 0;

With other aggregates different from count it is also possible this kind of problem, if the second analysis uses the same aggregate function on a columns with the same name (in this case the doplicated column would be named {aggregate_function}_{base_column}.
I see no obvious way of preventing this kind of problem in general without introducing much uglier column names.

I think this is a very important workflow for any client. Better to have ugly column names than useless analysis right?

Yep, let me give it a thought

What about count_vals_1, count_vals_vals_2 and so on?

It might not be trivial to apply such as naming-scheme (notice that each node's query is independently generated, and it should be deterministic based on the parameters used for hashing the node's id), but I think we can detect possible collisions and do some renaming similar to that, given that we can know the source node's column names (with getColumns() method, thanks to @dgaubert for the info).
I will look for some simple way to handle this.

I've just noticed we've had a ticket for this for some time: https://github.com/CartoDB/camshaft/issues/235
I've also open a new ticket for the solution I'm working on: https://github.com/CartoDB/camshaft/issues/330

I intended to suffix the ambiguous column names with something meaningful to the user (the a0, a1, etc. identifiers that Builder uses), but I've realised that we cannot do that, so we'll have to just use numerical (_2, _3, ...) suffixes. I'm afraid it will be hard for the user to determine which column corresponds to which analysis, but I see no easy way to fix it.

Hm, what about an identifier for what analysis it came from? For example centroid_count_1, centroid_count_2, etc

That's feasible if we don't correlate the _N numbers with different analyses. Can get a little verbose for my taste, but easy to implement.
All in all I think it could be worth, since it would make clear where the column belongs in most cases.

Fixed and deployed, thank you all!

Vamos!!!


Broken links in NHS Number Client wiki

I'm  trying to download and use the NHS Number client, but the instructions in the wiki are linking to resources hosted at services.developer.nhs.uk which doesn't seem to exist anymore.
Can you update the links and let me know where I can download it from (assuming it's still supported)?

I'm also looking for the java library which claims to be on GitHub, but there are no links to it on that page.

Facing the same issue. Download links given don't work and also couldn't find the jar files mentioned anywhere. I think this project is discontinued but NHS website is still referencing this page as the site is not updated.


Initial fee grant does not transfer anything

I see "Fee Granted" and in mintscan I see it revoked again.

Grant revocation should be reflected in the dashboard, otherwise it is confusing that a fee got granted but there is a 0 balance. Why would it be revoked? Should it be possible to get a new grant?
Also, the grant seems to be too small to do an initial unwrap of sSCRT

A initial fee grant is only valid for 1 day. To give out a new fee grant after 1 day, we first revoke the old fee grant (that's the revoke allowance) and then give out a new one. Looks like the new grant allowance transaction wasn't correctly included in a block, you didn't receive a new fee grant. Even if you do receive a fee grant, your SCRT balance will still be 0. A fee grant pays for your transactions with the balance from a different account, you don't directly get SCRT sent to your wallet.
The fee grant amount is enough to do an initial unwrap of sSCRT.


Devel ergo cub sn002

Updates from ergoCubSN002.

Hi @S-Dafarra @GiulioRomualdi
We have some conflicts here that we need to sort out.
In particular the one on ergoCubSN001/extra/applications/xbg.xml.
Can you deal with that?
I'll address the other two.

You can drop all the modifications to the 001 folder. I guess the issue arose when editing https://github.com/robotology/robots-configuration/pull/665/commits/465ce9445c6f034c01334b76cc22dbd0f1446a2a

Conflicts resolved. Awaiting CI before merging.


correct makefile

Most coins have a makefile.unix, Namecoin does not, Do not recycle the build docs without documenting the wierd changes you make!

Thanks for doing this! Hopefully a Namecoin dev comes along soon to take a look at this.
That file as a whole is quite incorrect. For one, Qt is the framework being used instead of wxWidgets.
Focusing specifically on the part you corrected, there are still some issues or possible optimizations (make expects the makefile to be named Makefile by default, so you don't need to specify the name in that case). I have made some more fixes. I suggest you update your pull request with them.
make # Namecoin with Qt GUI
make namecoind # Headless namecoin


debug: thread_analyzer: Add option to print ISR stack usage

Extracting stack usage calculation from k_thread_stack_space_get to z_stack_space_get so it can be used also for interrupt stack.
Updated thread analyzer to use it and include information about isr stack(s) usage in the report.
Updated shell kernel_service to use that function as well.

@carlescufi Why did you re-request my review? I approved it and there are no changes.

@carlescufi Why did you re-request my review? I approved it and there are no changes.

my mistake


Can anybody help with this issue?

Lotus seems to be connected with powergate. But still I am getting RPC error..


CXF-8706: CXF MTOM handler allow content injection

CXF MTOM handler allow content injection

@deki wondering if you have time to check this one out, thank you!

I don't think this is the "right" fix for this.   The Soap w/ Attachement spec allows for http URL's for the cid and actually shows that use in the examples ( https://www.w3.org/TR/SOAP-attachments/ ).  Thus, I think the better fix would be to pass a flag into LazyDataSource to allow flipping to URLDataSource if the CID isn't present as a direct attachment.

Thus, I think the better fix would be to pass a flag into LazyDataSource to allow flipping to URLDataSource if the CID isn't present as a direct attachment.

@dkulp thanks, I think I got your idea, but it solves a bit different problem: it does not help with the original issue, namely to limit href scheme cid: usage for xop:include, unless I am missing something ...

The main issue is that SOAP w/ Attachments doesn't have that limitation.  Thus, applying that limitation in AttachmentUtils is not the right place unless an extra flag is passed in to enable/disable the check and that's just set for the xop cases.

The main issue is that SOAP w/ Attachments doesn't have that limitation. Thus, applying that limitation in AttachmentUtils is not the right place unless an extra flag is passed in to enable/disable the check and that's just set for the xop cases.

Exactly, I am looking at how to distinguish xop / non-xop cases, this information is "lost" when MTOM decorator calls AttachmentUnmarshaller::getAttachmentAsDataHandler (if you have something in mind, please share), thanks!

@dkulp relied on isXOPPackage() flag of the AttachmentUnmarshaller to distinguish xop / non-xop cases, what do you think of it? Thank you!


google oAuth not work

How are you running Flagsmith

[X] Self Hosted with Docker
[ ] Self Hosted with Kubernetes
[ ] SaaS at flagsmith.com
[ ] Some other way (add details in description below)

Describe the bug
Google oAuth not work
Steps To Reproduce

I use this template https://raw.githubusercontent.com/Flagsmith/flagsmith/main/docker-compose.yml
Configure environment: OAUTH_CLIENT_ID & OAUTH_CLIENT_SECRET

version: '3'

volumes:
  pgdata:

services:
  postgres:
    image: postgres:15.5-alpine
    environment:
      POSTGRES_PASSWORD: password
      POSTGRES_DB: flagsmith
    container_name: flagsmith_postgres
    volumes:
      - pgdata:/var/lib/postgresql/data
    healthcheck:
      test: ['CMD-SHELL', 'pg_isready -d flagsmith -U postgres']
      interval: 2s
      timeout: 2s
      retries: 20
      start_period: 20s

  flagsmith:
    image: flagsmith.docker.scarf.sh/flagsmith/flagsmith:latest
    environment:
      DJANGO_ADMIN_SSO_OAUTH_CLIENT_ID: skippp
      DJANGO_ADMIN_SSO_OAUTH_CLIENT_SECRET: skippp
      OAUTH_CLIENT_ID: skippp
      OAUTH_CLIENT_SECRET: skippp
      # All environments variables are available here:
      # API: https://docs.flagsmith.com/deployment/locally-api#environment-variables
      # UI: https://docs.flagsmith.com/deployment/locally-frontend#environment-variables

      DATABASE_URL: postgresql://postgres:password@postgres:5432/flagsmith
      USE_POSTGRES_FOR_ANALYTICS: 'true' # Store API and Flag Analytics data in Postgres

      ENVIRONMENT: production # set to 'production' in production.
      DJANGO_ALLOWED_HOSTS: '*' # Change this in production
      ALLOW_ADMIN_INITIATION_VIA_CLI: 'true' # Change this in production
      FLAGSMITH_DOMAIN: localhost:8000 # Change this in production
      DJANGO_SECRET_KEY: secret # Change this in production
      ENABLE_ADMIN_ACCESS_USER_PASS: 'true'
      # PREVENT_SIGNUP: 'true' # Uncomment to prevent additional signups
      ALLOW_REGISTRATION_WITHOUT_INVITE: 'true'
      AXES_ONLY_USER_FAILURES: 'false'

      # Enable Task Processor
      TASK_RUN_METHOD: TASK_PROCESSOR # other options are: SYNCHRONOUSLY, SEPARATE_THREAD (default)
    ports:
      - 8000:8000
    healthcheck:
      test: ['CMD-SHELL', 'python /app/scripts/healthcheck.py']
      interval: 2s
      timeout: 2s
      retries: 20
      start_period: 20s
    depends_on:
      postgres:
        condition: service_healthy

  # The flagsmith_processor service is only needed if TASK_RUN_METHOD set to TASK_PROCESSOR
  # in the application environment
  flagsmith_processor:
    image: flagsmith.docker.scarf.sh/flagsmith/flagsmith:latest
    environment:
      DATABASE_URL: postgresql://postgres:password@postgres:5432/flagsmith
      USE_POSTGRES_FOR_ANALYTICS: 'true'
    depends_on:
      flagsmith:
        condition: service_healthy
    command: run-task-processor

I followed documents https://docs.flagsmith.com/deployment/hosting/locally-api#environment-variables and configure my Flagsmith for Google oAuth, but I not find buttom for google login.
What I am doing wrong?
PS And which Authorized redirect URI for oAuth?
Expected behavior
I see form for google login
Screenshots

Those environment variables are used to use Google OAuth to log in to Django admin, not to Flagsmith itself. You need to configure the oauth_google Flagsmith on Flagsmith feature flag to log in to Flagsmith using Google: https://docs.flagsmith.com/deployment/overview#oauth_google
I'll close this issue for now, let me know and we can re-open if needed.

Okay, Thank you
Would do you like show me example full flag value for  https://docs.flagsmith.com/deployment/overview#oauth_google becouse origin google json something other.
And I not found example for redirect_uris


cannot load io/fs: malformed module path "io/fs": missing dot in first path element

ubuntu 20.04
go version go1.13.8 linux/amd64
go get github.com/segmentio/kubectl-curl@latest
build github.com/segmentio/kubectl-curl: cannot load io/fs: malformed module path "io/fs": missing dot in first path element

Hello @wajika
I believe you need a Go version which had the io/fs package avaialble, Go 1.13 did not, which is why compilation is breaking.
The program was built with Go 1.17, so using 1.17 or 1.18 should resolve the issue.


Added Git Service

Test setup:

Deploy to a kind cluster

make deploy

Apply the ConsoleApplication YAML:

apiVersion: apps.console.dev/v1alpha1
kind: ConsoleApplication
metadata:
  name: github-successes
  namespace: avik
  labels:
    app.openshift.io/name: github-success
spec:
  applicationName: github-success-app
  git:
    url: https://github.com/openshift-console/console-application-operator
    contextDir: /
    reference: main
  importStrategy: builder-image
  buildConfiguration:
    builderImage:
      name: golang
      image: docker.io/hello/golang:latest
    buildOption: BuildConfig
    env:
      - name: hello
        value: world
  deploymentConfiguration:
    resourceType: deployment
    env:
      - name: hello
        value: world
    expose:
      targetPort: 8080
      createRoute: true

Check the status of the  ConsoleApplication

Also I see the project now allows to merge without approval. Should we configure it so that it requires one approval for merging ?


Update to spyder3 so that plugin works again

I should say that I changed the default back from nosetest to py.test so that I can check that everything works. I'm happy to remove this change from the Pull Request.

I rebase and updated the pull request. @Nodd any comments or do you want me to merge it?

Sorry, I wasn't watching the repo so I didn't get the notification. I initially planned to add an option to choose between pytest and nostests (or other when the are added).
Thanks for the PR.


a experiment about meta-test

Hi. I delete Line 384-385 and Line 447 of learner.py to avoid fine-tuning in the support set during the meta-test? Is this right? Thanks.

Hi @wjczf123, yeah. If you remove the #384-385 and #447 of learner.py,  the code'll skip fine-tuning on meta-test support set.

I understand the performance will drop, but it performs poorly.

Thanks for your reply. I ran it once under inter 5-way 1-shot setting and the results looked very bad.
2022-09-20 22:57:35 INFO: - span_f1 = 0.7218073781712385 2022-09-20 22:57:35 INFO: - span_p = 0.7370060346505719 2022-09-20 22:57:35 INFO: - span_r = 0.7072229140722269 2022-09-20 22:57:35 INFO: - type_f1 = 0.156973848019738 2022-09-20 22:57:35 INFO: - type_p = 0.156973848069738 2022-09-20 22:57:35 INFO: - type_r = 0.156973848069738 2022-09-20 22:57:35 INFO: - 9.445,9.063,9.250,73.701,70.722,72.181,15.697,15.697,15.697,0.000,0.000,0.000

Sorry, I made a mistake earlier. You can't direct remove #447 in the type classification stage, which has some logit to generate the type embedding.
The solution should be keep #447, and change #165 to self.model.eval(). You may also need to remove #191-192

Thanks. The new result seems to be correct.
2022-09-24 20:43:14 INFO: - ***** Eval results inter-test *****
2022-09-24 20:43:14 INFO: -   f1 = 0.6104350036041772
2022-09-24 20:43:14 INFO: -   f1_threshold = 0.6133144703132174
2022-09-24 20:43:14 INFO: -   loss = tensor(4.1757, device='cuda:0')
2022-09-24 20:43:14 INFO: -   precision = 0.6232885601193933
2022-09-24 20:43:14 INFO: -   precision_threshold = 0.6340790479672884
2022-09-24 20:43:14 INFO: -   recall = 0.5981008717310069
2022-09-24 20:43:14 INFO: -   recall_threshold = 0.5938667496886657
2022-09-24 20:43:14 INFO: -   span_f1 = 0.7218073781712385
2022-09-24 20:43:14 INFO: -   span_p = 0.7370060346505719
2022-09-24 20:43:14 INFO: -   span_r = 0.7072229140722269
2022-09-24 20:43:14 INFO: -   type_f1 = 0.8474159401741568
2022-09-24 20:43:14 INFO: -   type_p = 0.8474159402241568
2022-09-24 20:43:14 INFO: -   type_r = 0.8474159402241568
2022-09-24 20:43:14 INFO: - 62.329,59.810,61.044,73.701,70.722,72.181,84.742,84.742,84.742,63.408,59.387,61.331

I am very sorry to interrupt again. The 5-way 5-shot results under inter setting are worse than the 1-shot.
The results under 5-shot are:
2022-09-27 12:34:24 INFO: - ***** Eval results inter-test *****
2022-09-27 12:34:24 INFO: - f1 = 0.4713394738913809
2022-09-27 12:34:24 INFO: - f1_threshold = 0.4678844439614423
2022-09-27 12:34:24 INFO: - loss = tensor(5.6218, device='cuda:0')
2022-09-27 12:34:24 INFO: - precision = 0.6559220937309791
2022-09-27 12:34:24 INFO: - precision_threshold = 0.680110921612789
2022-09-27 12:34:24 INFO: - recall = 0.36782895994320486
2022-09-27 12:34:24 INFO: - recall_threshold = 0.3566065041094392
2022-09-27 12:34:24 INFO: - span_f1 = 0.5238582587165661
2022-09-27 12:34:24 INFO: - span_p = 0.7290079123554465
2022-09-27 12:34:24 INFO: - span_r = 0.4088141331949865
2022-09-27 12:34:24 INFO: - type_f1 = 0.9226715451538331
2022-09-27 12:34:24 INFO: - type_p = 0.9226715452038331
2022-09-27 12:34:24 INFO: - type_r = 0.9226715452038331
2022-09-27 12:34:24 INFO: - 65.592,36.783,47.134,72.901,40.881,52.386,92.267,92.267,92.267,68.011,35.661,46.788
The recall of span detection seems to low.

I am very sorry to interrupt again. Why is the performance in 5-shot worse than 1-shot after ablating fine-tuning in meta-test?
For example, the F1 under inter 5way-5shot is about 54. However, the performance under 1-shot is 61.04. Have you ever observed this phenomenon before? It doesn't seem normal. Thanks.

Hi @wjczf123, this may be reasonable, although we have not done the corresponding ablation experiments on 5shot. First of all the 5shot and 1shot datasets cannot be compared in parallel, they are both just a sampled subset of Few-NERD. Of course, according to our experimental results on inter 5-1 and inter 5-5, it seems that the 5shot results are better. Secondly, we found in our experiments that more fine-tuning steps are needed for inter 5-5 and inter 10-5 in the meta-test. Removing the fine-tune may have a greater impact on 5shot. Hope this helps.

Thanks. Hope you have a good day.


Add a prop to configure whether <kbd>esc</kbd> should close the panel

This change is useful when you have multiple components listening to esc and you don’t want to close them all at the same time (e.g. if you render this component inside a modal or a side panel).

Coverage remained the same at 91.319% when pulling 273181d5cc2d23808d4302d763bbb7f7fa440c11 on fretlink:master into 77862aea6a529152c46fd43dee5fc48fce8100e8 on react-component:master.

It may be possible to toggle some state in onClose and to decide to close your other components or not based on this state but merging this fix would make it much easier.


Add skaffold

https://github.com/GoogleContainerTools/skaffold
https://skaffold.dev/

Tracked in #2684


Fix typo in transactional-ntfs-portal.md

@teknixstuff : Thanks for your contribution! The author(s) have been notified to review your proposed change.


mstats.winsorize documentation needs clarification

stats.mstats.winsorize documentation needs some clarification:
From https://github.com/scipy/scipy/pull/7717#issuecomment-322436936:

This shows the difference (look at the number of values at start/end that are identical):
In [11]: data
Out[11]:
masked_array(data = [77 87 88 114 151 -- 219 246 253 262 296 299 306 376 428<PHONE_NUMBER> 2611],
             mask = [False False False False False  True False False False False False False
 False False False False False False False],
       fill_value = 999999)

In [12]: mstats.winsorize(data, (0.2, 0.2))
Out[12]:
masked_array(data = [114 114 114 114 151 515 219 246 253 262 296 299 306 376 428 515 515 515
 515],
             mask = [False False False False False False False False False False False False
 False False False False False False False],
       fill_value = 999999)

In [13]: mstats.winsorize(data, (0.2, 0.2), inclusive=(False, False))
Out[13]:
masked_array(data = [151 151 151 151 151 428 219 246 253 262 296 299 306 376 428 428 428 428
 428],
             mask = [False False False False False False False False False False False False
 False False False False False False False],
       fill_value = 999999)

I think it's the description of inclusive in the docstring that's a little confusing, it talks about number of data being masked while the truncation is about indices used to construct the lowidx-upidx interval of data to keep. Can you try to reformulate that description?

According to the documentation, if inclusive is True then the number of data being masked on each side should be rounded and if False, then it should be truncated. But the code in scipy/scipystats/mstats_basic.py line 1763
if low_include:          #low_include is the first entry of the inclusive tuple
       lowidx = int(low_limit * n)
else:
       lowidx = np.round(low_limit * n).astype(int)

does the opposite.
So, either the documentation has to be changed or the if clause. Shall I make a PR?


after_sign_in_path_for does not work

Hi everyone,

Ruby v 2.6.3p32
Rails v <IP_ADDRESS>
Devise v 4.7.1

I use three different Devise model with two domains. My routes.rb looks like this;
Rails.application.routes.draw do
  constraints host: 'domain1.com' do
    ActiveAdmin.routes(self)
    devise_for :users, ActiveAdmin::Devise.config.merge(path: 'user')
    devise_for :admin_users, ActiveAdmin::Devise.config.merge(path: 'admin')
    root to: "users/dashboard#index", :as => :user
  end

  constraints host: 'domain2.com' do
    resources :lists
    devise_for :influencers
    get '/lists' => 'lists#index', as: :influencer_root
    root to: "lists#index", as: "All_List_Objects"
  end

end

Also I added
def after_sign_in_path_for (resource)
    stored_location_for(resource) ||
    if resource.is_a?(Influencer)
      return "/"
      # return "/lists"
    elsif resource.class == User
      return "/"
    else
      root_path
    end
  end

to my Aplication_Controller.rb
Current behavior
I got these logs;
Redirected to http://localhost:3000/lists
Completed 302 Found in 126ms (ActiveRecord: 4.6ms | Allocations: 13282)

Expected behavior
I want to redirect to "/" after Influencers signed up with 200 code.
How can I solve it?

From looking at it, I'm imagining that there might be a stored location that it could be using. If that's not the case, can you please provide a sample app that shows the issue? If possible, without active admin involved.

I'm also not able to use after_sign_in_path_for currently. I have tried adding the method to both application controller and a custom sessions controller and neither are being hit.

From looking at it, I'm imagining that there might be a stored location that it could be using. If that's not the case, can you please provide a sample app that shows the issue? If possible, without active admin involved.

what is the recommended ways to override default devise method?
did putting the overrided code on application_controller.rb okay? or there is preferable way than that?
class ApplicationController < ActionController::Base
  before_action :authenticate_user!

  def after_sign_in_path_for(resource_or_scope)
    signed_in_root_path(resource_or_scope)
  end
end

@laptopmutia I think that's fine to have it in application controller.
@muhammedtufekyapan feel free to send a sample app that reproduces this issue ad I'll reopen it. Thanks!


Examples

Add Jupyter Notebook examples on US simulations of particle in a model potential (in OpenMM), for:

[x] 1D US
[x] 1D to phi-ensemble reweighting
[x] 1D to 2D reweighting
[ ] 2D US
[ ] Sparse sampling

@apallath Thank you so much for sharing this insightful package! The example you provided on umbrella sampling in 1D for a potential varying in 2D is incredibly detailed and helpful. Would you be able to provide a similar tutorial for the 2D US cases? I'd greatly appreciate it!


[ActionMenu.Button] onClick doesn't function

Description
When trying to pass a function to ActionMenu.Button  it doesn't get invoked.

Steps to reproduce

Goto: https://primer.style/react/ActionMenu
Overload onClick and see it doesn't get invoked on clicking.

Version
^36.19.1
Browser
No response

Not an expert on this, but I think the idea is that you'd leverage the onOpenChange property on the ActionMenu, rather than trying to catch the click on the button itself (which already has the behaviour attached to it to open/close the menu).

Not an expert on this, but I think the idea is that you'd leverage the onOpenChange property on the ActionMenu, rather than trying to catch the click on the button itself (which already has the behaviour attached to it to open/close the menu).

I see what you are saying.
The thing is I just need a simple onClick and I don't want to recreate this state just to overload my method.

Hey! Can confirm that the onClick is overwritten. Can classify as bug.
Out of curiosity, what are you planning to do in the onClick handler?

Hey! Can confirm that the onClick is overwritten. Can classify as bug.
Out of curiosity, what are you planning to do in the onClick handler?

I want to trigger a check to filter out options from the dropdown.

I want to trigger a check to filter out options from the dropdown.

That's interesting, can you share more? (Note: This repository is open source. Transferring issue to github/primer which is private)

👋 @DavidMeu, this came up in the prioritisation call today. Can I get some context around what you are working on, that will help us if we need to prioritise a fix or recommend the workaround Patrick mentioned.

👋 @DavidMeu, this came up in the prioritisation call today. Can I get some context around what you are working on, that will help us if we need to prioritise a fix or recommend the workaround Patrick mentioned.

This is part of [devportal](devportal.github app.com) pipeline runs.
Recently Heaven UI got deprecated and devportal will replace it by the end of the quarter.
Here is the official release post.

WIP: https://github.com/primer/react/pull/4648

Hi @DavidMeu, sorry this fell through the cracks!
Would this still be useful for you?

Hi @DavidMeu, sorry this fell through the cracks!
Would this still be useful for you?

Yes 🙏🏽

@DavidMeu, this is now completed, should be part of the next release: https://github.com/primer/react/pull/4942


[WebToolsE2E][Aspire] Creating Aspire project, there are warning icons displayed on Dependencies | Packages of the AppHost project.

REGRESSION
INSTALL STEPS

Clean machine: Win11 x64 22h2 ENU
Install SDK 9.0 RC2
Install VSCode or VS
Install Aspire 9.0 Preview 4

REPRO STEPS

Open CMD, create an Aspire Starter App using following commands:
dotnet new aspire-starter -o AspireStarterApp
Open this project using VSCode or VS.

ACTUAL
Dependencies | Packages show warning icon. No warnings in Error List.

EXPECTED
There should be no warning icons displayed

Should be a similar issue caused by SDK 9.0 RC2 as https://github.com/dotnet/sdk/issues/43341.

Is there any indication for what is being warned?
cc @tlmii @BillHiebert

This a duplicate issue.  Tracked by https://github.com/dotnet/aspire/issues/5436 which indicates it is fixed in Aspire 9.0.0-preview.4.24454.4.

This a duplicate issue. Tracked by #5436 which indicates it is fixed in Aspire 9.0.0-preview.4.24454.4.

I don't think this is a duplicate, the referenced one was around project nodes and we ended up figuring out the issue for that, but this is about NuGet package dependencies, so I don't think this is a dupe. Re-opening to ensure we get to the bottom of the issue.

I think I found out what the problem is. The issue is likely caused by the new feature in NuGet to surface vulnerabilities in dependencies. There is a vulnerability declared in NuGet for package System.Text.Json version 8.0.0 which is a transitive dependency for package Aspire.Hosting.AppHost. VS recently started surfacing these errors into the solution explorer, so that is likely what is happening here. The fix would be to make sure that we "pin up" our dependency of System.Text.Json so that new Aspire projects don't have these warnings.
Here is the dependency chain of how System.Text.Json 8.0.0 is coming to the picture:
dotnet nuget why .\AspireApp.AppHost.csproj System.Text.Json
Project 'AspireApp.AppHost' has the following dependency graph(s) for 'System.Text.Json':

  [net8.0]
   │
   └─ Aspire.Hosting.AppHost (v9.0.0-dev)
      ├─ Aspire.Hosting (v9.0.0-dev)
      │  └─ Microsoft.Extensions.Hosting (v8.0.0)
      │     ├─ Microsoft.Extensions.Configuration.Json (v8.0.0)
      │     │  └─ System.Text.Json (v8.0.0)
      │     ├─ Microsoft.Extensions.Configuration.UserSecrets (v8.0.0)
      │     │  └─ Microsoft.Extensions.Configuration.Json (v8.0.0)
      │     │     └─ System.Text.Json (v8.0.0)
      │     ├─ Microsoft.Extensions.Logging.Console (v8.0.0)
      │     │  └─ System.Text.Json (v8.0.0)
      │     └─ Microsoft.Extensions.Logging.EventSource (v8.0.0)
      │        └─ System.Text.Json (v8.0.0)
      └─ Microsoft.Extensions.Hosting (v8.0.0)
         ├─ Microsoft.Extensions.Configuration.Json (v8.0.0)
         │  └─ System.Text.Json (v8.0.0)
         ├─ Microsoft.Extensions.Configuration.UserSecrets (v8.0.0)
         │  └─ Microsoft.Extensions.Configuration.Json (v8.0.0)
         │     └─ System.Text.Json (v8.0.0)
         ├─ Microsoft.Extensions.Logging.Console (v8.0.0)
         │  └─ System.Text.Json (v8.0.0)
         └─ Microsoft.Extensions.Logging.EventSource (v8.0.0)
            └─ System.Text.Json (v8.0.0)

VS recently started surfacing these errors into the solution explorer, so that is likely what is happening here.

Yes, after manually updating 'System.Text.Json' to 8.0.4, the warning disappeared.
Here is the known issue 3047 tracks the vulnerable package.

This issue is now fixed in Aspire 8.2.1 and the latest build of 9.0.


Error: Unable to post episode to anchorfm: TimeoutError: Waiting for selector input[type=file] failed: Waiting failed: 30000ms

Hello, do you have an idea of this bug?
Running on MAC
Logged in
Uploading audio file
Error: Unable to post episode to anchorfm: TimeoutError: Waiting for selector input[type=file] failed: Waiting failed: 30000ms exceeded
at postEpisode (/Users/jordan/perso/youtube-to-anchorfm/src/anchorfm-pupeteer/index.js:174:11)
at async main (/Users/jordan/perso/youtube-to-anchorfm/src/index.js:36:3)
Thanks

Are running this on your local computer?
I have yet to hear of anyone who's tried this project locally on a mac
Could it be an issue may be related to that
:shrug:

This issue appears mostly locally(I run it on a Linux distribution - KDE Neon) and this issue is not consistent, sometiems it appears, sometimes it doesn't.

@matevskial I actually faced the same issue a week ago running the Github action several times

@matevskial I also got very similar issue running it on Github Actions (2 times out of 21 runs). The only difference I see is that I got the error on title instead of input[type=file].
Here's my full error:
Error: Unable to post episode to anchorfm: TimeoutError: Waiting for selector #title failed: Waiting failed: 30000ms exceeded     at postEpisode (/src/anchorfm-pupeteer/index.js:174:11)     at async main (/src/index.js:36:3)

Where are y'all located? My hunch is that this happens because of the EU cookies popup, but I'm not sure.
When I run outside of headless mode and manually click the "Accept Cookies" button, Puppeteer happily proceeds to upload the episode. I tried to spoof my geolocation to be in the US as follows:
src/anchorfm-pupeteer/index.js:82

async function postEpisode(youtubeVideoInfo) {
  let browser;
  try {
    console.log('Launching puppeteer');
    browser = await puppeteer.launch({ args: ['--no-sandbox'], headless: false });
    const page = await browser.newPage();

    const context = browser.defaultBrowserContext();
    await page.setGeolocation({latitude: 47.75, longitude: -120.74});

    const navigationPromise = page.waitForNavigation();
    await context.overridePermissions('https://anchor.fm/dashboard/episode/new', ['geolocation']);

    await page.setGeolocation({ latitude: 90, longitude: 0 });
    await page.goto('https://anchor.fm/dashboard/episode/new');
    await page.setViewport({ width: 1600, height: 789 });
    await navigationPromise;

    console.log('Trying to log in');
(...)

But this didn't work. If anyone understands Puppeteer better maybe they can chime in how to spoof the location to avoid the cookie popup. Or how to click the accept button if it appears.

I am in the us and also have this issue randomly.
I support your hunch that it may be related to the cookie pop up
We could have pupeteer to first except the cookies then proceed to login.

I have the same issue when running with GitHub Action ...
https://github.com/jordanscience/youtube-to-anchorfm/actions/runs/5073577077/jobs/9112763736

I have had the same issues and I am in the EU.

It happens to me today which brought me here. Tried to re-run the failed job but keep getting similar error:
Posting episode to anchorfm
Launching puppeteer
Trying to log in
Logged in
Uploading audio file
Waiting for upload to finish
-- Adding title
Error: Unable to post episode to anchorfm: TimeoutError: waiting for selector `#title` failed: timeout 30000ms exceeded
    at postEpisode (/src/anchorfm-pupeteer/index.js:1[57](https://github.com/jzvi12/youtube-to-anchorfm/actions/runs/5177297618/jobs/9327426723#step:4:58):15)
    at async main (/src/index.js:37:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node src/index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /github/home/.npm/_logs/2023-06-05T13_03_15_839Z-debug.log

I am having the same issue, anyone found a fix or a workaround?

This is the end for youtube-to-anchorfm. Every week we have a new YouTube video but the Action keep failing. Now we have to upload manually

We are aware of the issue.
The issue is most likely due to the cookie popup.
We are going to try to tackle the problem.

Can we close this issue @matevskial ?


Add docs for Helm values.yaml

Description:
Add user facing docs allowing user to override fields in value.yaml https://github.com/envoyproxy/gateway/blob/main/charts/gateway-helm/values.tmpl.yaml
[optional Relevant Links:]

Any extra documentation required to understand the issue.

cc @Xunzhuo


BatchUpdate - Use Correct Sql Parameter Type

When using the .BatchUpdate(..) / .BatchUpdateAsync(..) the update body sql parameters should have the same .DbType / .SqlDbType that EF uses for queries against the column.
Example:
public class Something
{
    private string _phoneNumber;
    public string PhoneNumber { get => _phoneNumber; set => _phoneNumber = value; }
}

public class TestDbContext : DbContext
{
    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        var somethingEntityBuilder = modelBuilder.Entity<Something>();
        somethingEntitybuilder.Property(something => something.PhoneNumber)
                .HasColumnType("varchar(12)").HasMaxLength(12).HasField("_phoneNumber").IsRequired();
    }
}

public class SomethingService
{
    private readonly TestDbContext _testDbContext;

    public async Task DoSomethingAsync(CancellationToken canclleationToken)
    {
        var oldPhoneNumber = "7756789999";
        var newPhoneNumber = "3606789999";

        _ = await _testDbContext.Set<Something>()
            // The sql parameter for oldPhoneNumber will be of the correct type (DbType.AnsiString) / SqlDbType.VarChar)
            .Where(something => something.PhoneNumber == oldPhoneNumber)
            .BatchUpdateAsync(
                 // The sql parameter for newPhoneNumber will not match, and instead will be DbType.String / SqlDbType.NVarChar
                something => new Something { PhoneNumber = newPhoneNumber),
                cancellationToken
            )
            .ConfigureAwait(false);
    }
}

@borisdj
I have a working update ready for the EFCore3.1 branch. It wasn't clear though what your merge strategy is between the 3 different version branches.
Do you update each branch EFCore2.2, EFCore3.1, and master independently? Or do you apply the fix into one branch and then merge the changes from there to the other branches?

Prior branches were created when switch to next versions was made.
They are not actively supported, meaning new features not be integrated there, only some mayor bug fixes.
2.2 is deprecated and on 3.1 there been several commit since split.
So should there be need for updates into both master and 3.1 then separate commits have to be made.
I'll check this PR on 3.1 but if same issue if on 5.0 then changes should copied there also.

Thanks much. I did 3.1 first as that's the version that we require for the time being.
I'll put together a 2nd PR with the equivalent update for the master branch.

Merged,
Thx for Contrib.


Demzne 1019 eosdac cleanup remains of recent migrations

This PR cleans out the unused tables custodians2, state2 and config2

Task linked: DEMZNE-1019 eosdac: Cleanup remains of recent migrations


validate debtor data

Codecov Report

Merging #5 into master will decrease coverage by 0.12%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   93.64%   93.52%   -0.13%
==========================================
  Files          59       59
  Lines        1322     1328       +6
  Branches      114      116       +2
==========================================
+ Hits         1238     1242       +4
- Misses         82       83       +1
- Partials        2        3       +1

Flag
Coverage Δ

#python_unittests
96.84% <66.66%> (-0.29%)
:arrow_down:

Impacted Files
Coverage Δ

ppr-api/src/schemas/party.py
93.33% <66.66%> (-6.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5644c74...8be55dc. Read the comment docs.


"hello"

Nicely done!
Do you feel like contributing a chapter on solving some other classic Euler
problem, e.g. p13?
On Wed, 29 May 2019 at 14:52, dog star<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/kparc/kcc/pull/4
Commit Summary

solved riddle

File Changes

A poc https://github.com/kparc/kcc/pull/4/files#diff-0 (3)

Patch Links:

https://github.com/kparc/kcc/pull/4.patch
https://github.com/kparc/kcc/pull/4.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kparc/kcc/pull/4?email_source=notifications&email_token=AALVXXVHMMEKM6IEMXWXDZDPXZ4CVA5CNFSM4HQMOZ32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWPIEQQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALVXXUHZ4O2F4DQOEXI7CLPXZ4CVANCNFSM4HQMOZ3Q
.

sure, might take me a moment to figure out a nice way to do it, but i'll take a stab at it and get back to you :)

side note, because i don't know how else to send a message:
"Rank zero, or niladic functions do not exist in k."
per a discussion in the k tree (https://chat.stackexchange.com/transcript/message/50491742#50491742) it looks like something like {[]1+2} might create a (useless?) niladic function?

right, `0 does exist, and it is mentioned at the bottom of the document,
and they are of some use.
kcc follows kiss principle
On Thu, 30 May 2019 at 11:31, dog star<EMAIL_ADDRESS>wrote:

side note, because i don't know how else to send a message:
"Rank zero, or niladic functions do not exist in k."
per a discussion in the k tree (
https://chat.stackexchange.com/transcript/message/50491742#50491742) it
looks like something like {[]1+2} might create a (useless?) niladic
function?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kparc/kcc/pull/4?email_source=notifications&email_token=AALVXXUPGDNJRBQ7Y2AYUKLPX6NG7A5CNFSM4HQMOZ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWR3KRY#issuecomment-497268039,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALVXXXNO7QALEQ4SJTUW7TPX6NG7ANCNFSM4HQMOZ3Q
.


[Storage] Migrate test_blob_access_condtitions to test proxy

Migrating test_blob_access_cnditions and test_blob_access_conditions_async to test proxy.

API change check
API changes are not detected in this pull request.


set_schedule_departure not working anymore?

These are the two functions I'm using to control scheduled departure and they don't turn it off/on anymore. I haven't used them in a few weeks but they worked very well last winter. Has anything changed in the way those parameters are passed?
All my other 'POST" calls are working but my 'set_schedule_departure' calls don't do anything, although they return a response of 200 in the 'notify' callback.
Thanks
PS. It's written in Monkey C for my Garmin watch.
    function stopDeparture(vehicle, notify) {
        var url = "https://owner-api.teslamotors.com/api/1/vehicles/" + vehicle.toString() + "/command/set_scheduled_departure";

        Communications.makeWebRequest(
            url,
            {
                "enable" => false
            },
            {
                :method => Communications.HTTP_REQUEST_METHOD_POST,
                :headers => {
                    "Authorization" => _token
                },
                :responseType => Communications.HTTP_RESPONSE_CONTENT_TYPE_JSON
            },
            notify
        );
    }

    function startDeparture(vehicle, notify, departureTime) {
        var url = "https://owner-api.teslamotors.com/api/1/vehicles/" + vehicle.toString() + "/command/set_scheduled_departure";

        Communications.makeWebRequest(
            url,
            {
                "enable" => true,
                "departure_time" => departureTime,
                "preconditioning_enabled" => true,
                "preconditioning_weekdays_only" => false
            },
            {
                :method => Communications.HTTP_REQUEST_METHOD_POST,
                :headers => {
                    "Authorization" => _token
                },
                :responseType => Communications.HTTP_RESPONSE_CONTENT_TYPE_JSON
            },
            notify
        );
}

Do you get vehicle ID number thanks to the vehicles command result and
search the VIN then the vehicleId?
Tesla changed this value some time ago, then if you are using a previously
stored value, it will fail.
I use those commands several times a day and it work well today. The
difference is that I sent all parameters at once, not only the one you set.
Le ven. 22 avr. 2022 à 15:21, SylvainGa @.***> a écrit :

These are the two functions I'm using to control scheduled departure and
they don't turn it off/on anymore. I haven't used them in a few weeks but
they worked very well last winter. Has anything changed in the way those
parameters are passed?
All my other 'POST" calls are working but my 'set_schedule_departure'
calls don't do anything, although they return a response of 200 in the
'notify' callback.
Thanks
PS. It's written in Monkey C for my Garmin watch.
function stopDeparture(vehicle, notify) {
    var url = "https://owner-api.teslamotors.com/api/1/vehicles/" + vehicle.toString() + "/command/set_scheduled_departure";

    Communications.makeWebRequest(
        url,
        {
            "enable" => false
        },
        {
            :method => Communications.HTTP_REQUEST_METHOD_POST,
            :headers => {
                "Authorization" => _token
            },
            :responseType => Communications.HTTP_RESPONSE_CONTENT_TYPE_JSON
        },
        notify
    );
}

function startDeparture(vehicle, notify, departureTime) {
    var url = "https://owner-api.teslamotors.com/api/1/vehicles/" + vehicle.toString() + "/command/set_scheduled_departure";

    Communications.makeWebRequest(
        url,
        {
            "enable" => true,
            "departure_time" => departureTime,
            "preconditioning_enabled" => true,
            "preconditioning_weekdays_only" => false
        },
        {
            :method => Communications.HTTP_REQUEST_METHOD_POST,
            :headers => {
                "Authorization" => _token
            },
            :responseType => Communications.HTTP_RESPONSE_CONTENT_TYPE_JSON
        },
        notify
    );

}
—
Reply to this email directly, view it on GitHub
https://github.com/timdorr/tesla-api/issues/567, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADUNWNLG5274VFXWYUKKTLTVGKRUVANCNFSM5UCJ4TLQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}  Thanks for the reply. The other commands still work so I doubt it's a vehicle ID issues, unless that command uses a different one, but unlikely.I'll try sending all parameters and see if that has any effect. It used to work 'as is last winter though so something did change.                                                                                De : @.é : 22 avril 2022 13 h 39À : @.épondre à : @. : @.; @.*** : Re: [timdorr/tesla-api] set_schedule_departure not working anymore? (Issue #567)
Do you get vehicle ID number thanks to the vehicles command result and
search the VIN then the vehicleId?
Tesla changed this value some time ago, then if you are using a previously
stored value, it will fail.
I use those commands several times a day and it work well today. The
difference is that I sent all parameters at once, not only the one you set.
Le ven. 22 avr. 2022 à 15:21, SylvainGa @.***> a écrit :

These are the two functions I'm using to control scheduled departure and

they don't turn it off/on anymore. I haven't used them in a few weeks but

they worked very well last winter. Has anything changed in the way those

parameters are passed?

All my other 'POST" calls are working but my 'set_schedule_departure'

calls don't do anything, although they return a response of 200 in the

'notify' callback.

Thanks

PS. It's written in Monkey C for my Garmin watch.

function stopDeparture(vehicle, notify) {

var url = "https://owner-api.teslamotors.com/api/1/vehicles/" + vehicle.toString() + "/command/set_scheduled_departure";

Communications.makeWebRequest(

        url,

        {

            "enable" => false

        },

        {

            :method => Communications.HTTP_REQUEST_METHOD_POST,

            :headers => {

                "Authorization" => _token

            },

            :responseType => Communications.HTTP_RESPONSE_CONTENT_TYPE_JSON

        },

        notify

    );

}

function startDeparture(vehicle, notify, departureTime) {

var url = "https://owner-api.teslamotors.com/api/1/vehicles/" + vehicle.toString() + "/command/set_scheduled_departure";

Communications.makeWebRequest(

        url,

        {

            "enable" => true,

            "departure_time" => departureTime,

            "preconditioning_enabled" => true,

            "preconditioning_weekdays_only" => false

        },

        {

            :method => Communications.HTTP_REQUEST_METHOD_POST,

            :headers => {

                "Authorization" => _token

            },

            :responseType => Communications.HTTP_RESPONSE_CONTENT_TYPE_JSON

        },

        notify

    );

}

—

Reply to this email directly, view it on GitHub

https://github.com/timdorr/tesla-api/issues/567, or unsubscribe

https://github.com/notifications/unsubscribe-auth/ADUNWNLG5274VFXWYUKKTLTVGKRUVANCNFSM5UCJ4TLQ

.

You are receiving this because you are subscribed to this thread.Message

ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I changed it to this and it's working again. It even needs 'end_off_peak_time' to be set, even when off peak is disabled. Go figure... Since I'm passing everything, I made just one function instead of two for stop and start, I'll close this 'non' issue.
    function setDeparture(vehicle, notify, departureTime, enable) {
        var url = "https://owner-api.teslamotors.com/api/1/vehicles/" + vehicle.toString() + "/command/set_scheduled_departure";

        Communications.makeWebRequest(
            url,
            {
                "enable" => enable,
                "departure_time" => departureTime,
                "preconditioning_enabled" => enable,
                "preconditioning_weekdays_only" => false,
                "off_peak_charging_enabled" => false,
                "off_peak_charging_weekdays_only" => false,
                "end_off_peak_time" => 360
            },
            {
                :method => Communications.HTTP_REQUEST_METHOD_POST,
                :headers => {
                    "Authorization" => _token
                },
                :responseType => Communications.HTTP_RESPONSE_CONTENT_TYPE_JSON
            },
            notify
        );
    }


UI settings read only

Describe the bug
In the case that users ssh keys are handled via gitlab, it would be good to have the keys displayed in settings in the UI as read only, without having the ability to delete them.

We've stopped syncing ssh keys from gitlab


--expandkeywords fails in some cases

On large files log.html concurrent expanding is processed for failed keywords and argument expandkeywords in order to show them initially when log.html is opened. This concurrent expanding fails in some cases due to conflicting concurrency.
Sample and Details
While using robot argument
--expandkeywords name:SeleniumLibrary.CapturePageScreenshot
setting css via jquery has no effect in some rare cases:
children.css({'display': 'block'});
Result: some screenshots are not visible.

Hi there,
Guys is there a way to disable the auto expand of failed cases?
I just want to see all tests closed and expand them as I need
Thank you!
Lily

you can use report.html instead (no expansion) and click on the tests, which failed.


Bugfix/adjust

Fixes #91

I can approve your PR, but you need to add a line in CHANGELOG.md, otherwise the tests will fail.


Add unit test for MTPHashData

This one is not required for first release so I will move it from milestone.


polarity in ont concepts

https://github.com/WorldModelers/Ontologies/blob/45d9aa80ffcff538dd45f1ff5489ce08072de733/CompositionalOntology_v2.1_metadata.yml#L48
I struggle to understand what a polarity of -1 means when attached to a concept in the ontology. can someone add to the README something about this?
i do understand the concept in extractions (as an aspect of the KR, not of the ontology). for example, i can say "the prices are unstable" and represent that as either using property/stability with polarity -1 or using property/instability with polarity 1 (and for "stable" i would use the same concepts but reversing polarities). in this case the polarity reflects a relation between a particular concept and its realization in an utterance. but in the ontology the latter is missing, which is why i struggle to understand what the polarity sign means there.
unless there's a good reason to keep the polarity in there, i would advocate for its removal.

I can add something to the readme (and I'll leave this issue open to ensure I do)
but, the basic idea is that the polarity encodes some sense of the inherent "goodness" of the concepts.
The only use for it (and AFAIK eidos is the only reader using it) is to resolve extractions where the final representation depends on an interaction between this inherent "polarity" and the inherent sentiment/polarity of a verb.  This is the example I use to explain it:
To account for this:

X worsens drought 	==> 	X increases/promotes dought
X worsens wages 	==> 	X decreases/inhibits wages

Essentially, the final polarity of the “node” to be represented in the UI/used in modeling can only be resolved through the combination of the polarity of the concept (here in the ontology) and the polarity of the edge (e.g., "worsen" = NEG and "improved" = POS). Note: as Lucian observed, other discrete values for polarity are possible; they will be added as needed

and we're definitely using it, and I am pretty sure that @bgyori is working on incorporating it in INDRA (if he hasn't already).

so it's just a signal for how these concepts get affected by verbs such as "worsen"?
then why does a "solitary locust" get polarity -1? can you worsen a solitary locust? and does that mean it's increased? a single locust can only increase in size!
[[ha! i finally found a hook to get something off my chest, not about the WM ontology, but about... i don't know, biologists' use of language? wtfh is "solitarious"?? i almost flagged that as some kind of typo, and then i googled it! turns out that hoppers can be "solitarious", the darn critters! i really think biologists should all be forced to use just Latin -- over the last couple of years I've become convinced that English is simply too much for them.]]

so it's just a signal for how these concepts get affected by verbs such as "worsen"?

yes

then why does a "solitary locust" get polarity -1? can you worsen a solitary locust? and does that mean it's increased? a single locust can only increase in size!

meh.  we're going for pragmatic > purity, I'd argue that worsened locusts = more locusts...

[[ha! i finally found a hook to get something off my chest, not about the WM ontology, but about... i don't know, biologists' use of language? wtfh is "solitarious"?? i almost flagged that as some kind of typo, and then i googled it! turns out that hoppers can be "solitarious", the darn critters! i really think biologists should all be forced to use just Latin -- over the last couple of years I've become convinced that English is simply too much for them.]]

haha, I agree! :)

ok, thanks for clearing things up. i know i asked before, but this polarity thing just doesn't seem to stick. i may ask again a couple months hence.

:)
On Thu, Sep 24, 2020 at 10:32 PM lgalescu<EMAIL_ADDRESS>wrote:

External Email
ok, thanks for clearing things up. i know i asked before, but this
polarity thing just doesn't seem to stick. i may ask again a couple months
hence.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/WorldModelers/Ontologies/issues/85#issuecomment-698729012,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCM4KRBUHSRGRXGJ24LSHQTPPANCNFSM4RYZO4BA
.


Reduce allocations

This change reduces the number of allocations which are required to execute HandleCompilationStart for the various analyzers. These calls are made many times while users are working in the IDE, so the benefits of this change are most visible there. The potential benefit is at least hundreds of allocations each time the user makes a change while typing in the editor.
Currently the work is complete for documentation and layout rules, and partially complete for the remaining rules.

Current coverage is 79.37%

Merging #1683 into master will increase coverage by +0.01% as of bc96df1

@@            master   #1683   diff @@
======================================
  Files          545     545
  Stmts        32203   32316   +113
  Branches      8974    8975     +1
  Methods          0
======================================
+ Hit          25557   25652    +95
- Partial       5211    5213     +2
- Missed        1435    1451    +16

Review entire Coverage Diff as of bc96df1

Powered by Codecov. Updated on successful CI builds.

:+1:


DBZ-5229 define centralized and modular aproach for debezium storage

@jpechane Thank you very much. I did the changes.
There are some questions left:

How we want to handle the default value of database.history? [Since `KafkaDatabaseHistory now is in the separate package]
How we want to handle database.history related test? [shall we test each connector compatibility on the storages module or  reverse?

@jpechane
Thank you for notes,
could you please answer my questions above?

@blcksrx

Please introduce dependency on debezium-storage-kafka to connectors as it should be provided by default in the installaton package.
I am not sure what exactly do you mean - could you please elaborate more - point to a test example?

@jpechane
Thank you very much.
About second note. Im gonna mention this KafkaDatabaseHistoryTest as an example in the mysql-connector

@jpechane Do you need smth to do on my side about this PR?

@blcksrx Applied thanks a lot!

Thanks. Im going to work on S3 Storage

On 12 Jul 2022, at 17:31, Jiri Pechanec @.***> wrote:

@blcksrx Applied thanks a lot!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


Use contracts stubs only for unit tests

For unit tests, we want to deploy some stubs, but we don't want to use them if we deploy the contracts as dependencies in other projects. To explicitly request for stubs deployment we provide TEST_USE_STUBS_* flag and use it in unit tests only.
Depends on https://github.com/keep-network/keep-core/pull/3058

@nkuba build fails. I think we should split this PR into 2 to make the build pass, ie one for /random-beacon changes and another one for /ecdsa, because it has a /random-beacon dependency in it. /ecdsa doesn't see the latest changes in /random-beacon and it runs out of gas

@nkuba build fails. I think we should split this PR into 2 to make the build pass, ie one for /random-beacon changes and another one for /ecdsa, because it has a /random-beacon dependency in it. /ecdsa doesn't see the latest changes in /random-beacon and it runs out of gas

The checks are passing now.


chore: aggregate data regarding API types and versions usage

What/Why/How?
Aggregate data regarding API types and versions usage.
~Important: it's better to wait until https://github.com/Redocly/redocly-cli/pull/1493 is merged. Otherwise could run into multiple merge conflicts.~
Reference
Resolves https://github.com/Redocly/redocly-cli/issues/1297
Testing

[x] Additionally checked the push command
[x] Additionally tested with the push action

Screenshots (optional)
Check yourself

[x] Code changed? - Tested with redoc/reference-docs/workflows (internal)
[x] All new/updated code is covered with tests
[ ] New package installed? - Tested in different environments (browser/node)

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Please update the related docs as well /docs/usage-data.md to add these fields to the data collection list.


set react-error-overlay iframe ID

This will make it easier to style (#react-error-overlay { display: none; })
Reference: https://github.com/facebook/create-react-app/issues/6530#issuecomment-662104135
Verified the changes locally:

Please see https://github.com/facebook/create-react-app/issues/6530#issuecomment-662914362.


ddev npm run dev does not reload the page in the browser when changes are made in laravel blade view files

Preliminary checklist

[X] I am using the latest stable version of DDEV (see upgrade guide)
[X] I have searched existing issues
[X] I have checked the troubleshooting guide
[X] I have run ddev debug test to include output below

Output of ddev debug test
Expand `ddev debug test` diagnostic information

======== Please make sure that you have already looked at troubleshooting guide ========
Troubleshooting guide: https://ddev.readthedocs.io/en/stable/users/usage/troubleshooting/
Simple things to check:
* ddev poweroff
* Restart Docker Provider
* Reboot computer
* Temporarily disable VPN and firewall
Press any key to continue:

======== Output file will be in /tmp/ddev-debug-test.txt ========

======== Existing project config ========
ddev installation alternate locations:
/usr/bin/ddev
/bin/ddev

These config files were loaded for project experiencemeghalaya: [/home/skg/Developer/laravel/experiencemeghalaya/.ddev/config.yaml]
name: experiencemeghalaya
type: laravel
docroot: public
php_version: 8.2
webserver_type: nginx-fpm
webimage: ddev/ddev-webserver:v1.23.1
additional_hostnames: []
additional_fqdns: []
database: {mariadb 10.11}
project_tld: ddev.site
use_dns_when_possible: true
composer_version: 2
nodejs_version: 20
default_container_timeout: 120

======== existing project customizations ========

======== installed DDEV add-ons ========
No registered add-ons were found. Add-ons installed before DDEV v1.22.0 will not be listed.
Update them with `ddev get` so they'll be shown.

======== mutagen situation ========
looking for #ddev-generated in mutagen.yml in project /home/skg/Developer/laravel/experiencemeghalaya
.ddev/mutagen/mutagen.yml not found

======== Creating dummy project named tryddevproject-3554 in ../tryddevproject-3554 ========
Creating a new DDEV project config in the current directory (/home/skg/Developer/laravel/tryddevproject-3554)
Once completed, your configuration will be written to /home/skg/Developer/laravel/tryddevproject-3554/.ddev/config.yaml

Configuring a 'php' project with docroot 'web' at /home/skg/Developer/laravel/tryddevproject-3554/web
Configuration complete. You may now run 'ddev start'.

======== OS Information ========
Linux eos-desktop 6.6.32-1-lts #1 SMP PREEMPT_DYNAMIC Sat, 25 May 2024 20:20:51 +0000 x86_64 GNU/Linux

======== User information ========
uid=1000(skg) gid=1000(skg) groups=1000(skg),3(sys),962(docker),981(rfkill),998(wheel)

======== DDEV version ========
 ITEM             VALUE
 DDEV version     v1.23.1
 architecture     amd64
 cgo_enabled      0
 db               ddev/ddev-dbserver-mariadb-10.11:v1.23.1
 ddev-ssh-agent   ddev/ddev-ssh-agent:v1.23.1
 docker           26.1.3
 docker-api       1.45
 docker-compose   v2.27.0
 docker-platform  linux-docker
 mutagen          0.17.2
 os               linux
 router           ddev/ddev-traefik-router:v1.23.1
 web              ddev/ddev-webserver:v1.23.1

======== proxy settings ========

 HTTP_PROXY=''
 HTTPS_PROXY=''
 http_proxy=''
 NO_PROXY=''

======== DDEV global info ========
developer-mode=false
disable-http2=false
fail-on-hook-fail=false
instrumentation-opt-in=false
instrumentation-queue-size=0
instrumentation-reporting-interval=0s
instrumentation-user=
internet-detection-timeout-ms=3000
last-started-version=v1.23.1
letsencrypt-email=
mailpit-http-port=8025
mailpit-https-port=8026
mkcert-caroot=/home/skg/.local/share/mkcert
no-bind-mounts=false
omit-containers=[]
performance-mode=none
project-tld=ddev.site
required-docker-compose-version=v2.27.0
router=traefik
router-bind-all-interfaces=false
router-http-port=80
router-https-port=443
simple-formatting=false
table-style=default
traefik-monitor-port=10999
use-docker-compose-from-path=false
use-hardened-images=false
use-letsencrypt=false
wsl2-no-windows-hosts-mgt=false
xdebug-ide-location=

======== DOCKER provider info ========
docker client location: -rwxr-xr-x 1 root root 26246872 May 17 20:28 /usr/bin/docker

docker client alternate locations:
/usr/bin/docker
/bin/docker

Docker provider: linux-docker
docker version:
Client:
 Version:           26.1.3
 API version:       1.45
 Go version:        go1.22.3
 Git commit:        b72abbb6f0
 Built:             Fri May 17 14:58:53 2024
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          26.1.3
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.22.3
  Git commit:       8e96db1c32
  Built:            Fri May 17 14:58:53 2024
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.17
  GitCommit:        3a4de459a68952ffb703bbe7f2290861a75b6b67.m
 runc:
  Version:          1.1.12
  GitCommit:
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

DOCKER_DEFAULT_PLATFORM=notset
Docker platform: linux-docker
Using Docker context: default (unix:///var/run/docker.sock)
docker-compose: v2.27.0
Using DOCKER_HOST=unix:///var/run/docker.sock
Docker version: 26.1.3
Able to run simple container that mounts a volume.
Able to use internet inside container.
Docker disk space:Filesystem                Size      Used Available Use% Mounted on
overlay                 125.2G     34.8G     84.0G  29% /

======== Existing docker containers ========
CONTAINER ID   IMAGE                                   COMMAND                  CREATED        STATUS                      PORTS     NAMES
e13da9eb6294   bitnami/mariadb:10.3.27-debian-10-r84   "/lando-entrypoint.s…"   6 days ago     Exited (137) 5 days ago               phpsite_database_1
8587c03c8663   devwithlando/php:8.2-apache-4           "/lando-entrypoint.s…"   6 days ago     Exited (137) 5 days ago               phpsite_appserver_1
539b794e391e   lamp-web                                "docker-php-entrypoi…"   7 days ago     Exited (1) 6 days ago                 lamp-web-1
5623396edf18   mysql:8.1.0                             "docker-entrypoint.s…"   7 days ago     Exited (0) 6 days ago                 lamp-db-1
3a75aa21d581   phpmyadmin/phpmyadmin                   "/docker-entrypoint.…"   7 days ago     Exited (0) 6 days ago                 lamp-phpmyadmin-1
562ec02e018a   redis:5                                 "/lando-entrypoint.s…"   2 weeks ago    Exited (137) 10 days ago              experiencemeghalaya_cache_1
c3d15dddef77   mailhog/mailhog:v1.0.1                  "/lando-entrypoint.s…"   2 weeks ago    Exited (137) 10 days ago              experiencemeghalaya_mail_1
316d95109403   bitnami/mariadb:10.3.27-debian-10-r84   "/lando-entrypoint.s…"   2 weeks ago    Exited (137) 10 days ago              experiencemeghalaya_database_1
4e47e1b403b7   devwithlando/php:8.2-apache-4           "/lando-entrypoint.s…"   2 weeks ago    Exited (137) 10 days ago              experiencemeghalaya_appserver_1
07ec8c8f00fc   node:18                                 "/lando-entrypoint.s…"   2 weeks ago    Exited (137) 10 days ago              experiencemeghalaya_node_1
2628634873f3   mailhog/mailhog:v1.0.1                  "/lando-entrypoint.s…"   3 weeks ago    Exited (137) 3 weeks ago              experiencemeghlaya_mail_1
1e021e70c13e   bitnami/mariadb:10.3.27-debian-10-r84   "/lando-entrypoint.s…"   3 weeks ago    Exited (137) 3 weeks ago              experiencemeghlaya_database_1
60c6782f8868   redis:5                                 "/lando-entrypoint.s…"   3 weeks ago    Exited (137) 3 weeks ago              experiencemeghlaya_cache_1
501d4b7f654e   devwithlando/php:8.2-apache-4           "/lando-entrypoint.s…"   3 weeks ago    Exited (137) 3 weeks ago              experiencemeghlaya_appserver_1
55a3681d7f1d   node:18                                 "/lando-entrypoint.s…"   3 weeks ago    Exited (137) 3 weeks ago              experiencemeghlaya_node_1
9c227cff88f8   redis:5                                 "/lando-entrypoint.s…"   4 weeks ago    Exited (137) 2 weeks ago              sccollege_cache_1
8171c1a13c60   mailhog/mailhog:v1.0.1                  "/lando-entrypoint.s…"   4 weeks ago    Exited (137) 2 weeks ago              sccollege_mail_1
3ada7eb610f9   bitnami/mariadb:10.3.27-debian-10-r84   "/lando-entrypoint.s…"   4 weeks ago    Exited (137) 2 weeks ago              sccollege_database_1
a4a8f13d53a2   devwithlando/php:8.2-apache-4           "/lando-entrypoint.s…"   4 weeks ago    Exited (137) 2 weeks ago              sccollege_appserver_1
9b9ae7f811f4   node:18                                 "/lando-entrypoint.s…"   4 weeks ago    Exited (137) 2 weeks ago              sccollege_node_1
695c5b2d55c5   traefik:2.2.0                           "/lando-entrypoint.s…"   4 weeks ago    Exited (137) 5 days ago               landoproxyhyperion5000gandalfedition_proxy_1
b5361f1d6e8a   hello-world                             "/hello"                 6 weeks ago    Created                               unruffled_swanson
e950495af5de   phpstorm_helpers:PS-233.14808.18        "/bin/sh"                2 months ago   Created                               phpstorm_helpers_PS-233.14808.18
b3982bb881ba   bitnami/mariadb:10.3.27-debian-10-r84   "/lando-entrypoint.s…"   2 months ago   Exited (137) 2 months ago             shillongcommerce_database_1
40be7bfcf761   devwithlando/php:7.4-apache-4           "/lando-entrypoint.s…"   2 months ago   Exited (137) 2 months ago             shillongcommerce_appserver_1
821425c31a8c   phpstorm_helpers:PS-233.14475.35        "/bin/sh"                2 months ago   Created                               phpstorm_helpers_PS-233.14475.35

======== mkcert information ========
/usr/bin/mkcert
/bin/mkcert
/home/skg/.local/share/mkcert
total 8
-r-------- 1 skg skg 2484 May 24 09:53 rootCA-key.pem
-rw-r--r-- 1 skg skg 1716 May 24 09:53 rootCA.pem

======== ping attempt on ddev.site ========
PING dkdkd.ddev.site (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.020 ms

--- dkdkd.ddev.site ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 0.020/0.020/0.020/0.000 ms

======== ddev debug refresh ========
Rebuilding project images...
Rebuilding web image with `/home/skg/.ddev/bin/docker-compose -f /home/skg/Developer/laravel/tryddevproject-3554/.ddev/.ddev-docker-compose-full.yaml build web --no-cache`
#0 building with "default" instance using docker driver

#1 [web internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.23kB done
#1 DONE 0.0s

#2 [web internal] load metadata for docker.io/ddev/ddev-webserver:v1.23.1
#2 DONE 0.0s

#3 [web internal] load .dockerignore
#3 transferring context: 2B done
#3 DONE 0.0s

#4 [web 1/7] FROM docker.io/ddev/ddev-webserver:v1.23.1
#4 CACHED

#5 [web 2/7] RUN (groupadd --gid 1000 "skg" || groupadd "skg" || true) && (useradd  -l -m -s "/bin/bash" --gid "skg" --comment '' --uid 1000 "skg" || useradd  -l -m -s "/bin/bash" --gid "skg" --comment '' "skg" || useradd  -l -m -s "/bin/bash" --gid "1000" --comment '' "skg" || useradd -l -m -s "/bin/bash" --comment '' skg )
#5 DONE 0.2s

#6 [web 3/7] RUN export XDEBUG_MODE=off; composer self-update --stable || composer self-update --stable || true; composer self-update --2 || composer self-update --2 || true
#6 0.399 Storing "stable" as default update channel for the next self-update run.
#6 3.334 You are already using the latest available Composer version 2.7.6 (stable channel).
#6 3.975 You are already using the latest available Composer version 2.7.6 (2.x channel).
#6 DONE 4.0s

#7 [web 4/7] RUN mkdir -p /home/skg && chown skg /home/skg && chmod 600 /home/skg/.pgpass
#7 DONE 0.3s

#8 [web 5/7] RUN apt update
#8 0.317
#8 0.317 WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
#8 0.317
#8 1.106 Get:1 https://deb.nodesource.com/node_20.x nodistro InRelease [12.1 kB]
#8 1.364 Get:2 http://deb.debian.org/debian bookworm InRelease [151 kB]
#8 1.408 Get:3 http://nginx.org/packages/debian bookworm InRelease [2860 B]
#8 1.434 Get:4 https://dl.cloudsmith.io/public/platformsh/cli/deb/debian bookworm InRelease [3675 B]
#8 1.520 Get:5 http://deb.debian.org/debian bookworm-updates InRelease [55.4 kB]
#8 1.537 Get:6 https://deb.nodesource.com/node_20.x nodistro/main amd64 Packages [7636 B]
#8 1.572 Get:7 http://deb.debian.org/debian-security bookworm-security InRelease [48.0 kB]
#8 1.612 Get:8 http://nginx.org/packages/debian bookworm/nginx amd64 Packages [7975 B]
#8 1.621 Get:9 http://deb.debian.org/debian bookworm/main amd64 Packages [8786 kB]
#8 1.901 Get:10 http://deb.debian.org/debian bookworm-updates/main amd64 Packages [13.8 kB]
#8 1.935 Get:11 https://packages.sury.org/php bookworm InRelease [7542 B]
#8 1.944 Get:12 http://deb.debian.org/debian-security bookworm-security/main amd64 Packages [157 kB]
#8 1.980 Get:13 https://dl.cloudsmith.io/public/platformsh/upsun-cli/deb/debian bookworm InRelease [3675 B]
#8 2.344 Get:14 http://packages.blackfire.io/debian any InRelease [28.0 kB]
#8 2.409 Get:15 https://packages.sury.org/php bookworm/main amd64 Packages [229 kB]
#8 2.729 Get:16 https://dl.cloudsmith.io/public/symfony/stable/deb/debian bookworm InRelease [4422 B]
#8 3.040 Get:17 https://dl.cloudsmith.io/public/platformsh/cli/deb/debian bookworm/main amd64 Packages [3310 B]
#8 3.251 Get:18 https://dl.cloudsmith.io/public/platformsh/upsun-cli/deb/debian bookworm/main amd64 Packages [2193 B]
#8 3.766 Get:19 https://dl.cloudsmith.io/public/symfony/stable/deb/debian bookworm/main amd64 Packages [6917 B]
#8 3.838 Get:20 http://packages.blackfire.io/debian any/main amd64 Packages [26.3 kB]
#8 3.852 Fetched 9557 kB in 4s (2719 kB/s)
#8 3.852 Reading package lists...
#8 4.086 Building dependency tree...
#8 4.138 Reading state information...
#8 4.145 8 packages can be upgraded. Run 'apt list --upgradable' to see them.
#8 DONE 4.2s

#9 [web 6/7] RUN curl -I https://www.google.com
#9 0.296   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#9 0.296                                  Dload  Upload   Total   Spent    Left  Speed
#9 0.296
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
#9 0.897 HTTP/2 200
#9 0.897 content-type: text/html; charset=ISO-8859-1
#9 0.897 content-security-policy-report-only: object-src 'none';base-uri 'self';script-src 'nonce-3H3GKPw_LYZ30y95vKMDCw' 'strict-dynamic' 'report-sample' 'unsafe-eval' 'unsafe-inline' https: http:;report-uri https://csp.withgoogle.com/csp/gws/other-hp
#9 0.897 p3p: CP="This is not a P3P policy! See g.co/p3phelp for more info."
#9 0.897 date: Wed, 29 May 2024 05:09:56 GMT
#9 0.897 server: gws
#9 0.897 x-xss-protection: 0
#9 0.897 x-frame-options: SAMEORIGIN
#9 0.897 expires: Wed, 29 May 2024 05:09:56 GMT
#9 0.897 cache-control: private
#9 0.897 set-cookie: 1P_JAR=2024-05-29-05; expires=Fri, 28-Jun-2024 05:09:56 GMT; path=/; domain=.google.com; Secure
#9 0.897 set-cookie: AEC=AQTF6Hz0YQCIXoeRmdtxgZvsSK9SVXGuY9IFE1ksrCpWkFyp_vLCNYxYwg; expires=Mon, 25-Nov-2024 05:09:56 GMT; path=/; domain=.google.com; Secure; HttpOnly; SameSite=lax
#9 0.897 set-cookie: NID=514=ETe5Vg69ypRlup0ZP68rB6csHqxvv6g78Fh9n8LkzWH4EEV8Roe9H3mJBclsqUhK-OcGNB9PJUsS2az5qoSW4PbozEQj1CT2AbWcrh1ydF-bPErgAz0roKemRcH8xqBwH7zegkkSxHnHObIY2POpgJ_uO28-l4-faLFsoryEATk; expires=Thu, 28-Nov-2024 05:09:56 GMT; path=/; domain=.google.com; HttpOnly
#9 0.897 alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
#9 0.897
#9 DONE 0.9s

#10 [web 7/7] RUN chmod 777 /run/php
#10 DONE 0.3s

#11 [web] exporting to image
#11 exporting layers
#11 exporting layers 1.4s done
#11 writing image sha256:fec27f3aae58d5a74ea39a2866c4599d52c8bfd3416927eb076a5c46abb35274 done
#11 naming to docker.io/ddev/ddev-webserver:v1.23.1-tryddevproject-3554-built done
#11 DONE 1.4s
Refreshed Docker cache for project tryddevproject-3554 in 11s
Network ddev_default created
 Container ddev-ssh-agent  Created
 Container ddev-ssh-agent  Started
ssh-agent container is running: If you want to add authentication to the ssh-agent container, run 'ddev auth ssh' to enable your keys.
Building project images...
.Project images built in 1s.
 Network ddev-tryddevproject-3554_default  Created
 Container ddev-tryddevproject-3554-db  Created
 Container ddev-tryddevproject-3554-web  Created
 Container ddev-tryddevproject-3554-web  Started
 Container ddev-tryddevproject-3554-db  Started
Waiting for web/db containers to become ready: [web db]
Starting ddev-router if necessary...
 Container ddev-router  Created
 Container ddev-router  Started
Waiting for additional project containers to become ready...
All project containers are now ready.

======== Project startup ========
Internet connection not detected, DNS may not work, see https://ddev.readthedocs.io/en/stable/users/usage/faq/ for info.
2024-05-29T10:40:17.902 No internet connection.
Starting tryddevproject-3554...
2024-05-29T10:40:17.922 Pulled image for ddev/ddev-webserver:v1.23.1
2024-05-29T10:40:17.923 Pulled image for busybox:stable
2024-05-29T10:40:17.923 Pulled image for ddev/ddev-ssh-agent:v1.23.1
2024-05-29T10:40:17.923 Pulled image for ddev/ddev-traefik-router:v1.23.1
2024-05-29T10:40:18.877 chowning /mnt/ddev-global-cache and /var/lib/mysql to 1000
2024-05-29T10:40:19.449 done chowning /mnt/ddev-global-cache and /var/lib/mysql to 1000
2024-05-29T10:40:19.453 host.docker.internal='' runtime.GOOS==linux and docker 20.10+
2024-05-29T10:40:19.484 Pulled image for ddev/ddev-dbserver-mariadb-10.11:v1.23.1
2024-05-29T10:40:19.484 Pulled image for ddev/ddev-webserver:v1.23.1
2024-05-29T10:40:19.484 Pulled image for ddev/ddev-ssh-agent:v1.23.1
2024-05-29T10:40:19.485 Pulled image for ddev/ddev-traefik-router:v1.23.1
The hostname tryddevproject-3554.ddev.site is not currently resolvable, trying to add it to the hosts file
DDEV needs to run with administrative privileges.
This is normally to add unresolvable hostnames to the hosts file.
You may be required to enter your password for sudo or allow escalation.
DDEV is about to issue the command:
  sudo --preserve-env=HOME /usr/bin/ddev hostname tryddevproject-3554.ddev.site <IP_ADDRESS>

Building project images...
2024-05-29T10:40:23.978 Executing docker-compose -f /home/skg/Developer/laravel/tryddevproject-3554/.ddev/.ddev-docker-compose-full.yaml build --progress=plain
.Project images built in 1s.
2024-05-29T10:40:24.979 Executing docker-compose -f /home/skg/Developer/laravel/tryddevproject-3554/.ddev/.ddev-docker-compose-full.yaml up -d
 Container ddev-tryddevproject-3554-web  Recreate
 Container ddev-tryddevproject-3554-db  Recreate
 Container ddev-tryddevproject-3554-db  Recreated
 Container ddev-tryddevproject-3554-web  Recreated
 Container ddev-tryddevproject-3554-db  Started
 Container ddev-tryddevproject-3554-web  Started
2024-05-29T10:40:36.724 VIRTUAL_HOST=tryddevproject-3554.ddev.site for web
2024-05-29T10:40:36.724 HTTP_EXPOSE=80:80,8025:8025 for web
2024-05-29T10:40:36.724 HTTPS_EXPOSE=443:80,8026:8025 for web
2024-05-29T10:40:37.063 Copied /home/skg/Developer/laravel/tryddevproject-3554/.ddev/traefik:CopyIntoVolume_uuavkmcxkzwf into /mnt/v/traefik in 58.886765ms
2024-05-29T10:40:37.081 Exec chown -R 1000 /mnt/v/traefik stdout=, stderr=, err=<nil>
2024-05-29T10:40:37.288 Copied Traefik certs in /home/skg/Developer/laravel/tryddevproject-3554/.ddev/traefik/certs to ddev-global-cache/traefik
2024-05-29T10:40:37.288 Running /start.sh in ddev-webserver
Waiting for web/db containers to become ready: [web db]
2024-05-29T10:40:40.255 Copied /home/skg/.ddev/commands:CopyIntoVolume_qijvxhynkhgo into /mnt/v/global-commands in 60.200105ms
2024-05-29T10:40:40.272 Exec chown -R 1000 /mnt/v/global-commands stdout=, stderr=, err=<nil>
2024-05-29T10:40:40.596 Testing to see if /mnt/ddev_config is properly mounted
Starting ddev-router if necessary...
2024-05-29T10:40:41.064 Copied /home/skg/.ddev/traefik:CopyIntoVolume_orqxwrphhdqc into /mnt/v/traefik in 52.373862ms
2024-05-29T10:40:41.081 Exec chown -R 1000 /mnt/v/traefik stdout=, stderr=, err=<nil>
2024-05-29T10:40:41.347 Copied global Traefik config in /home/skg/.ddev/traefik/certs to ddev-global-cache/traefik
 Container ddev-router  Running
2024-05-29T10:40:41.373 Waiting for ddev-router to become ready. docker inspect --format "{{json .State.Health }}" ddev-router
2024-05-29T10:40:41.875 ddev-router is ready
Waiting for additional project containers to become ready...
All project containers are now ready.
Successfully started tryddevproject-3554
Project can be reached at https://tryddevproject-3554.ddev.site https://<IP_ADDRESS>:32774

======== Curl of site from inside container ========
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/1.1 200 OK
Server: nginx
Date: Wed, 29 May 2024 05:10:43 GMT
Content-Type: text/html; charset=UTF-8
Connection: keep-alive
Vary: Accept-Encoding

======== curl -I of http://<IP_ADDRESS>:32775 (web container http docker bind port) from outside ========
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/1.1 200 OK
Server: nginx
Date: Wed, 29 May 2024 05:10:43 GMT
Content-Type: text/html; charset=UTF-8
Connection: keep-alive
Vary: Accept-Encoding

======== curl -I of http://tryddevproject-3554.ddev.site (router http URL) from outside ========
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/1.1 200 OK
Content-Type: text/html; charset=UTF-8
Date: Wed, 29 May 2024 05:10:43 GMT
Server: nginx
Vary: Accept-Encoding

======== Full curl of http://tryddevproject-3554.ddev.site (router http URL) from outside ========
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   198    0   198    0     0   116k      0 --:--:-- --:--:-- --:--:--  193k
Success accessing database... db via TCP/IP<br />
ddev is working.<br />
The output file for Discord or issue queue is in
<b>/tmp/ddev-debug-test.txt</b><br />
file:///tmp/ddev-debug-test.txt<br />

======== Full curl of https://tryddevproject-3554.ddev.site (router https URL) from outside ========
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   198    0   198    0     0  33154      0 --:--:-- --:--:-- --:--:-- 39600
Success accessing database... db via TCP/IP<br />
ddev is working.<br />
The output file for Discord or issue queue is in
<b>/tmp/ddev-debug-test.txt</b><br />
file:///tmp/ddev-debug-test.txt<br />

======== Curl google.com to check internet access and VPN ========
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/2 200
content-type: text/html; charset=ISO-8859-1
content-security-policy-report-only: object-src 'none';base-uri 'self';script-src 'nonce-h2Td_xGSjJEviiqtjZmWaQ' 'strict-dynamic' 'report-sample' 'unsafe-eval' 'unsafe-inline' https: http:;report-uri https://csp.withgoogle.com/csp/gws/other-hp
p3p: CP="This is not a P3P policy! See g.co/p3phelp for more info."
date: Wed, 29 May 2024 05:10:44 GMT
server: gws
x-xss-protection: 0
x-frame-options: SAMEORIGIN
expires: Wed, 29 May 2024 05:10:44 GMT
cache-control: private
set-cookie: 1P_JAR=2024-05-29-05; expires=Fri, 28-Jun-2024 05:10:44 GMT; path=/; domain=.google.com; Secure
set-cookie: AEC=AQTF6HxaJbjTTIF-Kwg1NH44uQKMrK1KVWnSQEzLTofUt8QoYtau29A9Cg; expires=Mon, 25-Nov-2024 05:10:44 GMT; path=/; domain=.google.com; Secure; HttpOnly; SameSite=lax
set-cookie: NID=514=B2WmEPmQU63ti81xUnFl8Z1Jb0Q5qVQnEK8jYDQ09TC_rTWSP79p0KCWN62VLSEJsEodrlPJUwlUsPSDQm30JiiJ8y0DH5icTo9GsUAwFT9Cm8ydEyQFLP7r2yLaxmbD7M1smFhTgCP6iQ1KpiNWYsCCV6l9CKTFz-Jt6Osq-_c; expires=Thu, 28-Nov-2024 05:10:44 GMT; path=/; domain=.google.com; HttpOnly
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

======== host.docker.internal status ========
PING host.docker.internal (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from host.docker.internal (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.044 ms

--- host.docker.internal ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 0.044/0.044/0.044/0.000 ms

======== Project ownership on host ========
drwxr-xr-x 4 skg skg 4096 May 29 10:39 ../tryddevproject-3554

======== Project ownership in container ========
drwxr-xr-x 4 skg skg 4096 May 29 05:09 //var/www/html

======== In-container filesystem ========
Filesystem     Type 1K-blocks     Used Available Use% Mounted on
/dev/nvme0n1p3 ext4 351655640 31277768 302441488  10% /var/www/html

======== Thanks for running the diagnostic! ========
Running ddev launch in 3 seconds
Running ddev launch
Waiting for ddev launch to complete before deleting project
Opening in existing browser session.

Cleanup: deleting test project tryddevproject-3554
 Container ddev-tryddevproject-3554-db  Stopped
 Container ddev-tryddevproject-3554-web  Stopped
 Container ddev-tryddevproject-3554-db  Stopped
 Container ddev-tryddevproject-3554-web  Stopped
 Container ddev-tryddevproject-3554-db  Removed
 Container ddev-tryddevproject-3554-web  Removed
 Network ddev-tryddevproject-3554_default  Removed
DDEV needs to run with administrative privileges.
This is normally to add unresolvable hostnames to the hosts file.
You may be required to enter your password for sudo or allow escalation.
DDEV is about to issue the command:
  sudo --preserve-env=HOME /usr/bin/ddev hostname --remove tryddevproject-3554.ddev.site <IP_ADDRESS>

Volume tryddevproject-3554-mariadb for project tryddevproject-3554 was deleted
Volume tryddevproject-3554-postgres for project tryddevproject-3554 was deleted
Volume tryddevproject-3554_project_mutagen for project tryddevproject-3554 was deleted
Project tryddevproject-3554 was deleted. Your code and configuration are unchanged.

Please remove the files from this test with 'rm -r ../tryddevproject-3554'

Expected Behavior
In my laravel project when changes are made to any blade files the page should reload in the browser when ddev npm run dev is running.
Actual Behavior
The page stays the same and only when i manually refresh it do i see the changes.
Steps To Reproduce
No response
Anything else?
When i use lando as a local development environment for the same project with the exact same files I have no issues.

Hi! Which version of Laravel do you use? A version with Vite?
See: https://ddev.com/blog/working-with-vite-in-ddev/#laravel

Thank you.. this worked. Am using version Laravel version 11


Narrow allowed values for DateTime and NaiveDate.

This also solves a part of #30.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

216 of 217 (99.54%)  changed or added relevant lines in 8 files are covered.
12 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 92.287%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

imap-types/src/imap4rev1/datetime.rs
136
137
99.27%

Files with Coverage Reduction
New Missed Lines
%

imap-types/src/imap4rev1/datetime.rs
12
90.57%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
7885

Relevant Lines:
8544

💛  - Coveralls


@damassi => Client-side backbone views for "classic" layouts

Adds client file for "classic" views -- not sure how I missed this before but we are missing client-side JS for all non-editorial channels atm.

LGTM, will merge on 🍏

👍


error opening device /host/dev/falco0 for aws ECS

I am trying to run the falco container in ECS and it fails below
command : docker run -i -t --name falco --privileged -v /var/run/docker.sock:/host/var/run/docker.sock -v /dev:/host/dev -v /proc:/host/proc:ro -v /boot:/host/boot:ro -v /lib/modules:/host/lib/modules:ro -v /usr:/host/usr:ro  falcosecurity/falco:latest
Error Message:
Status: Downloaded newer image for falcosecurity/falco:latest
* Setting up /usr/src links from host
* Running falco-driver-loader with: driver=module, compile=yes, download=yes
* Unloading falco module, if present
* Trying to dkms install falco module
* Running dkms build failed, couldn't find /var/lib/dkms/falco/96bd9bc560f67742738eb7255aeb4d03046b8045/build/make.log
* Trying to load a system falco driver, if present
* Trying to find locally a prebuilt falco module for kernel 4.14.173-137.229.amzn2.x86_64, if present
Detected an unsupported target system, please get in touch with the Falco community
2020-05-29T17:27:28+0000: Falco initialized with configuration file /etc/falco/falco.yaml
2020-05-29T17:27:28+0000: Loading rules from file /etc/falco/falco_rules.yaml:
2020-05-29T17:27:28+0000: Loading rules from file /etc/falco/falco_rules.local.yaml:
2020-05-29T17:27:28+0000: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
2020-05-29T17:27:29+0000: Unable to load the driver. Exiting.
2020-05-29T17:27:29+0000: Runtime error: error opening device /host/dev/falco0. Make sure you have root credentials and that the falco module is loaded.. Exiting.

OS Detail:
[ec2-user@ip-172-xxxx-xxx-xxx ~]$ cat /etc/system-release
Amazon Linux release 2 (Karoo)
[ec2-user@ip-172-xxxx-xxx-xxx  ~]$ cat /etc/os-release
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"

Seems to be them same issue: https://github.com/falcosecurity/falco/issues/1239

figured it out it look like it failed becasued I did not add -v /etc:/host/etc:ro. Once this was added it started running

How you resolved this issue?


Ignores fonts

I can’t install my fonts, neither through themes nor through text styles, judging by the code, it generally ignores fonts from the text style

This is possible. However, the usual Compose methods won't work for now. I created this library using Android Views in order to very quickly build it from the Markwon library. This means the underlying text field is actually an EditText View.
As a workaround to set the text fonts and style, one get a reference to the underlying EditText View and set the font using the Views system. Put the font in the res/font resources folder. In this example, res/font/test_font.ttf.
val text = rememberSaveable { mutableStateOf("") }
val view = remember { mutableStateOf<EditText?>(null) }
MarkdownEditor(
    value = text.value,
    onValueChange = { text.value = it },
    setView = { view.value = it }
)
LaunchedEffect(Unit) {
    val tf: Typeface = resources.getFont(R.font.test_font)
    view.value?.setTypeface(tf)
}


Refactor load in checkpoint connector

What does this PR do?
Refactor checkpoint load in CheckpointConnector.
Only refactoring for code-health, no functional changes.
Two main refactored points:

align restore (normal load) & hpc_load (hpc load)
common hpc file check/selection

Commits are well-separated based on refactored parts.
If changes are no apparent in "Files changed" diff, please check "Commits" diff.
Before submitting

[n/a] refactoring <= Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[n/a] Did you make sure to update the documentation with your changes?
[n/a] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 👍

Hello @tarepan! Thanks for updating this PR.

In the file pytorch_lightning/trainer/connectors/checkpoint_connector.py:

Line 117:58: W291 trailing whitespace

@tarepan how is it going here, ready to co?
cc: @tchaton

@Borda Yes, ready to go.


Ch.2 iPhone/Firefox Mobile Longhold bug

When I longhold in firefox, a menu appears that isn't styled correctly.
https://github.com/saving-satoshi/saving-satoshi/assets/32662508/4593d098-0ec4-4992-8f84-179279708eac
It should look like this.

We are going to stick with monaco so we should address this issue. Removing the "blocked" flag.

Actually I'm not sure the fix is to color the background but instead to prevent the menu from popping up on a long hold. Instead the option to paste should appear.

Let's disable menu option but also preserve ability to copy/paste with long-hold if the default pasting feature is still available.
https://stackoverflow.com/questions/44750658/how-to-disable-monaco-context-menu
Shashwat will investigate and update this issue.

@afterburn @ecurrencyhodler
I was experimenting with removing the context menu for the Monaco editor by using,
contextmenu: false

However, after disabling the context menu, the iPhone's default paste option was not enabled, and hence there was no way to paste text in the editor.
Should we go forward with removing the context menu?

Is the normal flow that people would paste by using the context menu?

Seems to me that way. It's the standard behavior for mobile devices.
A better option would have been to show only iPhone's standard cut, copy, paste options. However, the Monaco editor is not allowing that to happen.

We can disable the contextmenu for mobile:

export const monacoOptions: editor.IStandaloneEditorConstructionOptions = {
  readOnly: false,
  minimap: { enabled: false },
  scrollBeyondLastLine: false,
  wordWrap: 'on',
  theme: 'vs-dark',
  contextmenu: false // <--------
}

@afterburn
After making the following change:
--- a/ui/lesson/ScriptingChallenge/config.ts
+++ b/ui/lesson/ScriptingChallenge/config.ts
@@ -13,6 +13,7 @@ export const monacoOptions: editor.IStandaloneEditorConstructionOptions = {
   scrollBeyondLastLine: false,
   wordWrap: 'on',
   theme: 'vs-dark',
+  contextmenu: false
 }

The desktop (Macbook Pro, chrome) shows the following general menu:

While there are no cut, copy, paste options. We can still perform these options using keyboard shortcuts.
However, for mobile devices (iPhone 13, Safari), the long press leads to no menu/options popping up:
https://github.com/saving-satoshi/saving-satoshi/assets/85434418/977c1f39-bf51-4b7f-900f-b0e2ac554be4

Okay thanks for taking a look @shaavan. Is there a way to perhaps change the styling of the menu? Right now it looks transparent. I wonder if it having a simple grey background would be an easier fix. Could you post a screenshot if that's possible?

I found one discussion that was not so promising but left one possible avenue of approach
https://github.com/Microsoft/monaco-editor/issues/1138
The relevant comment
https://github.com/Microsoft/monaco-editor/issues/1138#issuecomment-998223879

@benalleng
I looked through the reference you mentioned, but my hopes are low after reading this comment.

Seems like since version 0.21 it's no longer possible to style using CSS (the context menu is rendered inside a shadow root). This makes this issue more important IMO.

@ecurrencyhodler
I think you will agree that this is a low-priority issue for the moment. So we can be patient in finding a robust solution for this in the future.

I have done a lot of finding on how to inject CSS for the context menu in Monaco Editor, but I could not find a reliable way.
The best resource I came about was this article (2nd Answer). However, I am unable to translate the solution to our codebase.
@afterburn, please look at the article, and see if it should be a reliable method for solving this issue. Thanks!

@shaavan the following code makes it so my context menu background is red:
monaco.editor.defineTheme('satoshi', {
      base: monacoOptions.theme,
      inherit: true,
      rules: [],
      colors: {
        'menu.background': '#FF0000FF', // <--------------
        'editor.background': '#00000000',
        'editor.lineHighlightBorder': '#00000000', // 4th channel is for transparency
      },
    })

Does this not work?

Moved this to the backlog based on our convo 6/20/23

Unassigning myself for now from this issue. Let's tackle this later when we are ready to finish it up!

this may be fixable through disabling the https://microsoft.github.io/monaco-editor/typedoc/interfaces/editor.IDiffEditorConstructionOptions.html#useShadowDOM?