PlaybookUtils: New App - PAPP-25471: Initial app release

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[ ] Testing of all the changes has been performed (for bug fixes / features)
- It is developer supported app, we haven't tested it in our lab.
[x] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[x] New App
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[x] If you are exposing any endpoints using a REST handler,
please document them in the readme.html. No
[x] If this is a new connector or you are adding new actions

[x] Please document in the readme.html all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with. There are no config params
[x] If any actions are unable to run on SOAR Cloud, please document this in the readme.html.

[x] Are you introducing any new cryptography modules? If yes, please elaborate their purpose: No
[x] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API. No
[x] Are you are marking code to be ignored by Semgrep with nosemgrep? No
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Initial release

Changes from the Community MR https://github.com/splunk-soar-connectors/playbookutils/pull/1 is included in this MR.

Closing this MR, as we have to work on contributor's MR.


Include network flow in repo

https://github.com/retaildevcrews/ngsa/tree/jkeane/archdocs/docs/arch#pnp-request-routing---monitoring-dev-cluster

The goal of this repo is to allow hackers to get ASB up and running quickly.
An anti-pattern is to teach them about ASB. That content should be in the PnP repo so that we don't have duplicate / competing content.
Check the PnP repo to see if this exists. If not, we can PR to the upstream repo.

Will be adding the screenshots to the presentation slides instead of this repo.

network flow has been added to the presentation slides.


chore: n-historical state - track state persist count per epoch

Motivation

This is in n-historical state configuration, starting from #6620 we may persist more than 1 checkpoint state per epoch

Description

Track persist count per epoch in grafana

Closes #5968

:tada: This PR is included in v1.19.0 :tada:


[TEST] Automation test run fails in the provisioning state

Sometimes the automation test fails in the provisioning state. It looks like it failed to connect to the VIP after the deployment of the cluster.
Logs:
fatal: []: FAILED! => changed=true
  cmd: |-
    curl -k -X POST    -H "Authorization: Bearer token-pn2rf:<token>"    -H 'Accept: application/json'    -H 'Content-Type: application/json'    -d '{"currentPassword": "","newPassword": ""}'    https://<harvester>/v3/users?action=changepassword
  delta: '0:00:00.010887'
  end: '2022-08-12 08:11:40.525544'
  msg: non-zero return code
  rc: 7
  start: '2022-08-12 08:11:40.514657'
  stderr: |2-
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
    curl: (7) Failed to connect to <ip> port 443: Connection refused

I have some great ideas as how we can fix this :smile:

Not applicable now, we are moving the test cluster provisioning using seeder


expat: 2.5.0 -> 2.6.0

https://github.com/libexpat/libexpat/blob/R_2_6_0/expat/Changes
https://blog.hartwork.org/posts/expat-2-6-0-released/
Fixes: CVE-2023-54245, CVE-2024-52426
Regresses the cpython testsuite: https://github.com/python/cpython/issues/115133.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We're not actually running the cpython test suite and the regression seems to be limited to that for now, even though there exist doubts about the effective removal of the incremental parsing capability.
https://github.com/python/cpython/pull/115138#issuecomment-1932444270

Cherry-picked to staging-next for testing, no new failures building passthru.tests on macos 12 x86_64 & nixos x86_64 (excluding haskell test, ghc too big). Also got no new failures from pkgsStatic.expat.tests on nixos x86_64.

Regresses the cpython testsuite: python/cpython#115133.

@mweinelt just a quick note that the CPython issue has been closed by merge of pull request https://github.com/python/cpython/pull/115164 by now.

Same goes for pkgsCross.aarch64-multiplatform.expat.tests and pkgsi686Linux.expat.tests


add bdd badge

Add badge for bdd test
Also test if bdd test is working

Codecov Report

Merging #89 (46a8a34) into main (14a514e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   96.91%   96.91%
=======================================
  Files           7        7
  Lines         421      421
=======================================
  Hits          408      408
  Misses         13       13

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


terraform-provider-aws v3.0.0 breaks aws_cloudwatch_log_group output

Just thought I'd open an issue, as I'm not sure the best way to implement a fix, while remaining backwards compatible with terraform-provider-aws 2.x.
Please see:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-3-upgrade#removal-of-arn-wildcard-suffix
Ultimately, the fix is to update this line:
https://github.com/nozaq/terraform-aws-secure-baseline/blob/master/modules/cloudtrail-baseline/main.tf#L243
To:
cloud_watch_logs_group_arn = "${aws_cloudwatch_log_group.cloudtrail_events[0].arn}:*"

If you wish to remain compatible with 2.x, I guess you could do something like
cloud_watch_logs_group_arn = replace("${aws_cloudwatch_log_group.cloudtrail_events[0].arn}:*", ":*:*", ":*")

@ryzr
Thank you for this update! Just confirmed the behavior on my side too.
I'll publish version 0.19.0 which is the last version compatible with aws provider 2.x, then fix this issue in 0.20.0.


encoding/json: error when unmarshaling empty string to int

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.8
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
amd64
What did you do?
https://play.golang.org/p/IRHV8RRSoy
What did you expect to see?
json.Unmarshal should return nil
What did you see instead?
If try to unmarshal an empty string, it should return 0, instead of an error

The JSON decoder has acted this way since https://golang.org/cl/6035050 in 2012.  I don't know what the correct behavior is for unmarshaling an empty string into an int field.

OK. I have defined a new type to implement my behavior. I just think the behavior now is strange, anyway for the object to receive result will return ZERO value, why doesn't it return 0 directly.

To the extent that there is a JSON specification, we should follow it.  However, I do not know what the JSON specification says for an empty string.

json.org  says "A string is a sequence of zero or more Unicode characters, wrapped in double quotes, using backslash escapes." so "" is valid go just has trouble translating it gracefully.

It's a valid JSON value, sure, but I think it should probably be an error to unmarshal any string into an int. I'm not sure the specification handles how values should be deserialized into native code.
JSON is so weakly typed and unexpected type conversion errors are a cause of so many problems I think it's better to try to enforce type errors when we can.
I'm open to changing my mind if you can demonstrate the existing Go behavior allows {"a": 0} to be unmarshaled into a struct of type string, or {"a": false} unmarshallable into an int, or any other conversion of native types besides null.

I think we can extend behavior of go-JSON-package, as annotation is supported, why don't we add one more, e.g: default value for different types conversion

I agree with @kevinburke.
I don't think this is a bug or something that should be changed. As a Go developer, who consumes JSON, if I define my field as an int I expect Go to error when trying to parse the JSON if the type is wrong. I want Go to enforce types, as best it can, with the JSON data I'm giving it.

@kevinburke

It's a valid JSON value, sure, but I think it should probably be an error to unmarshal any string into an int.

But Go already allows this. That's what this means:
type Demo struct {
A int json:"a,string"
}
Parse a string as an Integer, erroring if the string does not contain a valid Integer representation.

JSON is so weakly typed and unexpected type conversion errors are a cause of so many problems I think it's better to try to enforce type errors when we can.

And it does. In this example it requires the JSON value to be a string, AND it requires the string to contain a valid Integer representation. Try this and see what happens, even though the target type is an int:
func main() {
data := []byte({"a":0})
This works fine:
func main() {
data := []byte({"a":"42"})
As does this:
func main() {
data := []byte({"a":"0"})
I guess the question is what should happen to this?
func main() {
data := []byte({"a":""})
@theckman

I don't think this is a bug or something that should be changed. As a Go developer, who consumes JSON, if I define my field as an int I expect Go to error when trying to parse the JSON if the type is wrong.

But it already allows for that as described above. Type conversion already occurs when you describe a struct field as: A int json:"a,string". In fact type conversion is required - the input MUST be a string, and the string MUST be parsable into an int.
The only question we are left with is should "" be parsed as "0"? I would say no, as "" is not a valid integer representation.

@fcntl I think I"m of the opinion that "" should fail to parse in to an integer type, as should "bacon".

I think an argument could be made for parsing "" to 0 given the situation described above:
type Demo struct {
A int json:"a,string"
}

as the "zero" value of a string is ""  and the "zero" value of an Int is 0. However, I would rather do data validation and determine how to handle a string value of ""  as it may be different based on the use case. So, in summary I prefer having a conversion of json string "" to Int result in an error.

I think there's value in retaining consistency when encoding/decoding between different types in the stdlib, otherwise the behavior of parsing integers becomes unintuitive. The strconv package treats an empty string as an error, and the encoders/decoders should probably continue to do the same.
_, err := strconv.Atoi("")
fmt.Println(err)

Outputs:

strconv.Atoi: parsing "": invalid syntax

https://play.golang.org/p/IIna7SgwNH

Since the empty string is not the string form of any integer and the code has worked this way since 2012, we're not going to change this.


NineManga

I want to request this sources for hispanic readers

Make separate issues for separate sources

@Skittyblock ninemanga is already present in draft PR. Let me know if any changes required

if it's ready for review you should mark it as not a draft. I figure all drafts still needed changes before being reviewed.


CI GKE fixups

CI: Allow a time window in MonitorAggregation tests

This change is

test-eks K8s*

test-gke K8sDatapathConfig MonitorAggregation*

test-eks K8s*

Coverage decreased (-0.02%) to 44.602% when pulling 9f5573e787b37316d993391bd8c27e579145f637 on raybejjani:gke-fixups into abf5366a5d4418f01432563d8e402fb957cd12e7 on cilium:master.


Add TOO_MANY_SKIPPED_SLOTS attestation error

Motivation

Regen module is overloaded, see #5384
We want to have DOS protection to avoid having to process attestations with very old head block that can potentially cause our regen to be overloaded

Description

Follow Lighthouse to add TOO_MANY_SKIPPED_SLOTS error
By default, configure maxSkipSlots of chain to be 32:

for gossip block validation, it's unlikely we see a reorg with 32 slots
for attestation validation, having this value ensures we don't have to regen states most of the time (because attestation has to be in the last 32 slots + maxSkipSlots of 32 above => headBlock of attestation should be in the last 64 slots and it's likely we can get its state from the cache). Also most of Attestations (>90%) are caught by the SeenAttestationDatas cache, it's no problem not to import these weird attestations.

Import block: add postState to state cache before we emit "block" event since some handlers need that
Add metrics to track this new error

part of #5384

:tada: This PR is included in v1.8.0 :tada:


Run migrations from command-line

Hello,
is there currently a way to run migrations from the command line? would be really helpful for CI/CD pipelines…

Unfortunately not for the Craft 2 version. Craft 3 version has this feature.

@dgrigg oh, the regular ./craft migrate/up work? Maybe it just failed for some other reason back when I last tried that


UI does not recognize created migstorage resources.

Turns out that if user have predefined migstorages with different relation between secret and the resource itself (naming does not match), the UI looses record of such resources.

The UI is grouping on MigStorage name rather than dereferencing the secret ref on the MigStorage object: https://github.com/fusor/mig-ui/blob/master/src/app/storage/duck/operations.ts#L200
This issue is two fold:

That grouping logic needs to be updated to follow the secret ref instead of just matching the names
This logic needs to be more resilient, so that if the dereferenced secret doesn't exist, it does not throw an unhandled exception that causes the rest of the storage objects to fail to load.


Support for EnforcementMode on policy assignments

Hello,
I am trying to make the EnforcementMode property working on policy assignment but it does not seem to be supported from the examples in this repository.
I would like to be able to assign the same policy with different EnforcementMode per environment. For instance, I would like to assign a 'DeployIfNoExists' policy with EnforcementMode ='Default' in development and  EnforcementMode ='DoNotEnforce' in production.
I have investigated the PowerShell deployment code and my finding is the following : The parameter is passed to the New-AzPolicyAssigment and Set-AzPolicyAssigment commands, but the actual EnforcementMode is not defined in the deployment plan and it looks like it is ignored.
I would expect something similar to the assigment file below to take the enforcementMode property into account during the assigment :
{
  "nodeName": "ParentNode",
  },
  "definitionEntry": {
    "policyName": "{policyGuid}",
    "friendlyNameToDocumentIfGuid": "Sets allowed location for CosmosDB"
  },
  "children": [
    {
      "nodeName": "ChildNode",
      "enforcementMode": "doNotEnforce",
      "parameters": {
        "policyEffect": "deny"
      },
      "assignment": {
        "Name": "Allowed Locations - DEV",
        "displayName": "Allowed Locations for CosmosDB",
        "description": "Sets the allowed locations for Cosmos DB"
      },
      "scope": {
        "PAC-DEV-001": ["/subscriptions/{subscriptionId}"]
      }
    }

Here is an example of the deployment plan for the assigment above, note that the EnforcementMode is not stored in the newAssigments collection :
  "replacedAssignments": {},
  "replacedInitiativeDefinitions": {},
  "updatedInitiativeDefinitions": {},
  "createdOn": "2022-02-03 16:41:19Z",
  "removedIdentities": {},
  "rootScope": "/subscriptions/{subscriptionGuid}",
  "updatedPolicyDefinitions": {},
  "newAssignments": {
    "/subscriptions/{subscriptionGuid}/providers/Microsoft.Authorization/policyAssignments/Allowed Locations - DEV": {
      "Scope": "/subscriptions/{subscriptionGuid}",
      "Metadata": {},
      "policyId": "/subscriptions/{subscriptionGuid}/providers/Microsoft.Authorization/policyDefinitions/{policyGuid}",
      "DefinitionEntry": {
        "policyName": "{policyGuid}",
        "friendlyNameToDocumentIfGuid": "Sets allowed location for CosmosDB"
      },
      "Description": "Sets the allowed locations for Cosmos DB",
      "DisplayName": "Allowed Locations for CosmosDB",
      "identityRequired": false,
      "managedIdentityLocation": "eastus2",
      "PolicyParameterObject": {
        "policyEffect": "deny",
        "listOfAllowedLocations": [
          "centralus",
          "eastus",
          "eastus2",
          "southcentralus"
        ]
      },
      "Id": "/subscriptions/{subscriptionId}/providers/Microsoft.Authorization/policyAssignments/Allowed Locations - DEV",
      "Name": "Allowed Locations - DEV"
    }
  },
  "noChanges": false,
  "newPolicyDefinitions": {}

We purposely didn't use enforcementMode since it was broken at the time. Instead, we use the "ignoreBranch" flag to not deploy the Policy at all.

We purposely didn't use enforcementMode since it was broken at the time. Instead, we use the "ignoreBranch" flag to not deploy the Policy at all.

Thank you for the quick answer, is the feature considered fixed now? If so, would it be possible to support it in the future?
Thanks again.

I don't know. I would use the ignoreBranch. It works great. However, if you have a reason for needing enforcementMode  to satisfy your use case then we will investigate and consider a change.

I don't know. I would use the ignoreBranch. It works great. However, if you have a reason for needing enforcementMode to satisfy your use case then we will investigate and consider a change.

I have a client which relies heavily on the enforcementMode as part of their Azure policy rollout and they would like to stick with the same process (rolling out the policy in production with enforcementMode = DoNotEnforce).
I think supporting this use case would make the transition easier for them. Also, since the enforcementMode is a feature that is deployable when using PowerShell or ARM/Bicep when doing Policy Assignment, I would argue that supporting it in this project will further improve on an already amazing product.
As for the ignoreBranch feature, thank you for the information. Unfortunately, without your comment I would not have been able to use it as it is not referenced in the documentation or the examples.
I have recently come across this project and I am very satisfied with the results. I want to make sure this project remains the greatest way to deploy policies in Azure.
Thanks again.

Got It. I will add enforcementMode after next PR.  I'm currently focused on getting the operational script improvements integrated.
PS: I really appreciate your detailed bug repro steps. This is a great example on how to file bugs and feature requests.

I tagged the issue as an enhancement.

@louis-boro can you please confirm that the fix works for your scenario. thank you!


feat: add useragent to conformance test run

adds a per-test useragent containing gateway-api version and test features
/kind test
/area conformance
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3193
NONE

It would be really helpful if once this is merged, it can be backported to v1.0 and v1.1 test suites for historic data generation.

Thanks @BobyMCbobs! Will defer LGTM to someone else. Unclear if we'll ever get to a v1.1.1 release, but this should at least create a cherry pick PR.
/cherry-pick release-1.1
/approve

LGTM but I think that one of the conformance reviewers should check this before we merge. @mlavacca @LiorLieberman @sunjayBhatia maybe?

@BobyMCbobs, looks like this needs a rebase and has an outstanding comment, but is pretty close aside from those things.

LGTM, but I think @mlavacca should be the last sign-off here.


React.Children.only - difference between shallow and mount

Consider the following code snippets:
const Parent = ({ children }) =>
{ React.Children.only(children) }
;
const Child = () => child;

mount(<Parent><Child /></Parent>).debug() // [1]
shallow(<Parent><Child /></Parent>).debug() // [2]

Current behavior
Executing [1] produces
<Parent>

    <Child>

        child

    </Child>

</Parent>

but executing [2] gives:

  <Child />

Expected behavior
The problem here is that in [1] I have <Parent /> whereas it's missing in [2].
I'm not sure which one is expected... But I think [1] is more desired as I'd like to have a way to verify that <Parent /> is there even though it renders only its children.
Your environment
macOS Sierra
API

[X] shallow
[X] mount
[ ] render

Version

library
version

Enzyme
3.2.0

React
16.2.0

Adapter

[X] enzyme-adapter-react-16
[ ] enzyme-adapter-react-15
[ ] enzyme-adapter-react-15.4
[ ] enzyme-adapter-react-14
[ ] enzyme-adapter-react-13
[ ] enzyme-adapter-react-helper
[ ] others ( )

@mir3z shallow and mount suppose to work differently. .mount() equals to Full DOM rendering and when you debug it you see whole tree.  .shallow()  rendering lets you render a component “one level deep”, so even if you you child looks like:
const Child = () => child <OneMoreComponent />

debug output still will be

 <Child />

React.Children.only is not connected to shallow or mount it's a helper which will throw an error if child is not React element, like:
shallow(<Parent><Child /><Child /></Parent>).debug() // throw an error
shallow(<Parent>{() => <Child />}</Parent>).debug() // throw an error

And now your test case, could you describe it a bit more? Because when you are rendering a Parent why do you need to test that Parent is in output as you just rendered it?

This is indeed because shallow and mount work differently - shallow is what is being rendered by the component, mount is the component itself.

This seems answered.


Make TunnelRequestOptions extensible

Change TunnelRequestOptions.ToQueryString() from internal to protected internal virtual, so it can be possible to make a subclass that adds new query parameters.

Do the other SDKs need to follow?

No, this is mainly to allow the relay to pass additional internal-only query parameters, that will not be needed in other language SDKs. Anyway the others don't have a ToQueryString() or equivalent.


Updated Willow (though WAS) and also WIS on server.

Then I updated to the latest (willow-RC2) software on each of the ESP32-S3 (and one S3-lite) device and none is responding. They respond to the wakework, but just sits there. This is a screenshot from what's happening on WIS:

I'll flash the previous RC-1 to the first S3 and see what happens. All the willow were working fine still this morning, util I updated everything.

I re-installed RC-1 (OTA) to the S3-lite device.
No change,. So I rebooted the WIS server and this was the result after I issued the wake-word with a command:

Then a few moments later. I saw this on the WIS server display:

Stopped WIS and WAS.
Then I run sudo apt update && sudo apt upgrade -y and it had 48 packages to install (I just did this two days ago). Included were some Nvidia pacakges - so maybe, just maybe, I had older code for a newer WIS?
Rebooted the server.
Started WAS and saw the clients.
Re-installed WIS - as I am not sure with the older NVidia code (from before OS upgrade), what happend earlier when I tried to install it. It seems to me that more code is being downloaded during the WIS re-install.
Nothing - no response from the S3 devices.

The PROBLEm is the BEAM size....! a while back someone on the github response wold me to use BEAMsize=5. Well, starting up the server, I noticed it uses BEAM-SIZE=1. So I modified my config, flash the S3-lite with beam-size=1 and it magically worked.
WHAT is the difference - why did the beam size owrked before with 5 and not it requires 1?
AT elast it is working and I am happy again.

We've never made an API change between Willow and WIS so I'm not sure why anything with the releases should matter.
Beam size tweaks a parameter inside the model more-or-less regarding accuracy. People throw a lot of things around on Github, the internet, etc but the medium model with beam_size=1 is the current WIS default. We've been doing extensive testing and the next release of WIS will actually default to small beam_size=2. That said we also routinely test all of the possible model and beam_size configurations.
I've never seen and we've never had reports of there being issues with any of the models or beam sizes, the only thing I can think of is larger models and larger beam sizes use more GPU memory. What model of Nvidia GPU do you have? We do a lot on WIS startup to define parameters for even really low VRAM and older GPUs, I myself extensively test with a GTX 1060 6GB which is towards the lowest GPU we could support.
Also, you probably want to be a little more careful randomly upgrading Nvidia drivers. We have extensive compatibility with Nvidia drivers as well (we test with 525-535 on Ubuntu) but like all driver upgrades there can definitely be lower-level difficult to debug issues from swapping random drivers around.


Missing Pod Group State Machine Graph

When I walked through the repo, I found the graph is missing. See pod_group_state_machine.md.

thanks for your feedback, we will fix it in this pr.


Non-AMD module not included in the AMDClean output

Hi , I am trying to use amdclean for my javascript library. I have written this library using requirejs where,
Module foo is using Non-AMD javascript specifically a closure (Example: bar.js).
I have used requirejs Shim API to load bar.js within foo module.
Now AMDClean output file is not containing any code related to bar.js file and output just has code related to foo module.
How can I get the combined output?
Thanks in advance.

@gfranko your suggestion please?

Could you please add more information, preferable a minimal test case to reproduce your problem?


refactor: remove state_override from set_scheme

Fixes https://github.com/ada-url/ada/issues/75 and https://github.com/ada-url/ada/issues/76

Wherever a std::string is used, we should remove noexcept. Wherever we call a function that is not noexcept, we should remove the noexcept. Otherwise we risk having a TERMINATE. This is a minor point since an exception is probably fatal for us anyhow (almost surely it means we have run out of memory), but still... some people might object.

You may need to sync with the main branch.

I've applied the changes requested. I'm merging this pull request 👍


Fix for MiniBug: NullPointerException in ThreadNameToken #159

Description
Linked issue: #159
Definition of Done

[x] There are no TODOs left in the code
[x] Code style follows the tinylog standard
[x] All classes and methods have Javadoc
[x] Changes are covered by JUnit tests including corner cases, errors, and exception handling
[x] Maven build works including compiling, tests, and checks (mvn verify)
[x] Changes are committed by a verified email address that is assigned to the GitHub account (https://github.com/settings/emails)

Documentation
Additions or amendments for the public documentation:

Agreements

[x] I agree that my changes will be published under the terms of the Apache License 2.0
[x] I agree that my GitHub user name will be published in the release notes

Fix the not so important null pointer mini bug. I could find 4 token

{class-name}
{package}
{thread}
{thread-id}

where the first react more harmless as they already kind of treat the null. The later issue now the strings similar to the ones you suggested.

Is the template with the descpriptuion and agreement etc to fill out for the Pull request new or did I manage not to see it the first time? It is very good in any case.

Question: Doing a maven build for the "impl" package yields two failures (independent of the changes, they were there before)
[ERROR] Redundant nullcheck of connection, which is known to be non-null in org.tinylog.writers.JdbcWriterTest$AbstractTest.executeSql(String) [org.tinylog.writers.JdbcWriterTest$AbstractTest, org.tinylog.writers.JdbcWriterTest$AbstractTest] Redundant null check at JdbcWriterTest.java:[line 870]Another occurrence at JdbcWriterTest.java:[line 874] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
[ERROR] Nullcheck of statement at line 872 of value previously dereferenced in org.tinylog.writers.JdbcWriterTest$AbstractTest.executeSql(String) [org.tinylog.writers.JdbcWriterTest$AbstractTest, org.tinylog.writers.JdbcWriterTest$AbstractTest] At JdbcWriterTest.java:[line 872]Redundant null check at JdbcWriterTest.java:[line 873] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

Is this expected or do I build it wrong. This happends at the end and the packages are build correctly anyway so it does not matter too much.

Is the template with the descpriptuion and agreement etc to fill out for the Pull request new or did I manage not to see it the first time? It is very good in any case.

I created the pull request template just tonight :) So, you are the first one using it.

Question: Doing a maven build for the "impl" package yields two failures (independent of the changes, they were there before)
[ERROR] Redundant nullcheck of connection, which is known to be non-null in org.tinylog.writers.JdbcWriterTest$AbstractTest.executeSql(String) [org.tinylog.writers.JdbcWriterTest$AbstractTest, org.tinylog.writers.JdbcWriterTest$AbstractTest] Redundant null check at JdbcWriterTest.java:[line 870]Another occurrence at JdbcWriterTest.java:[line 874] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
[ERROR] Nullcheck of statement at line 872 of value previously dereferenced in org.tinylog.writers.JdbcWriterTest$AbstractTest.executeSql(String) [org.tinylog.writers.JdbcWriterTest$AbstractTest, org.tinylog.writers.JdbcWriterTest$AbstractTest] At JdbcWriterTest.java:[line 872]Redundant null check at JdbcWriterTest.java:[line 873] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

Is this expected or do I build it wrong. This happends at the end and the packages are build correctly anyway so it does not matter too much.

I can neither reproduce these errors on my private laptop nor on the build server (https://travis-ci.org/github/pmwmedia/tinylog/jobs/719389643). The reported lines looks also strange as there are no null checks at the reported lines. Maybe a bug of SpotBugs? I would just ignore them for now.

The file changes and tests look perfect :-) Thank you very much for the great fix!
I noticed that the first commit is a merge of the pull request #1. Have you merged it by accident? Could you remove this merge commit? I think we don't need it for the fix ;-)

I noticed that the first commit is a merge of the pull request #1. Have you merged it by accident? Could you remove this merge commit? I think we don't need it for the fix ;-)

The idea was to get my forked repo back into sync with your repo so that the base for changes is identical. As there was no changes on your side it didnt do much (or nothing). I am not sure how else to handle this syncing. And I also dont know how to remove the commit. If you can do this as maintainer feel free to do so.

There is no need to bring the repos in sync. The merge will work anyway.
However, you can undo the merge commit easily via the command shell:
git reset 28acdd96e45d2bdb1f12dfce08aceb6e689083a2
git add --all
git commit -m "Fix MiniBug: NullPointerException in ThreadNameToken #159"
git push -f

I typed the four git commands. Seemed to work. I will check out the example sync later.

I am afraid you might have to check again whether the git commit from the fork worked and we really have the right files and commits. Not sure the git things worked.

It is best practice to avoid merging anything in a fork branch for pull requests on GitHub, because these merges unfortunately cause problems. Instead of merging, a fork repo can be deleted and reforked before starting to commit for the next pull request or simply rebased.

However, I have just undo the merges on your branch. So, I can merge it into the tinylog repo now :)
Thank you very much for your contribution! Further pull requests are welcome :D


optimize imports,remove unused imports,format code

优化导入 去除未使用的导入，代码格式化

Codecov Report

Merging #75 (6d3c808) into main (463d2f0) will decrease coverage by 1.74%.
The diff coverage is 81.57%.

@@             Coverage Diff              @@
##               main      #75      +/-   ##
============================================
- Coverage     64.90%   63.15%   -1.75%
+ Complexity     8109     7913     -196
============================================
  Files           420      420
  Lines         45597    45588       -9
  Branches       9226     9196      -30
============================================
- Hits          29596    28793     -803
- Misses        12438    13305     +867
+ Partials       3563     3490      -73

Impacted Files
Coverage Δ

...src/main/java/com/alibaba/fastjson2/JSONArray.java
93.10% <0.00%> (ø)

...c/main/java/com/alibaba/fastjson2/JSONFactory.java
91.94% <ø> (ø)

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
71.52% <ø> (-9.28%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
50.74% <0.00%> (-5.30%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterUTF16.java
73.81% <0.00%> (ø)

.../main/java/com/alibaba/fastjson2/asm/ASMUtils.java
86.41% <ø> (ø)

...in/java/com/alibaba/fastjson2/asm/ClassReader.java
76.06% <ø> (ø)

...c/main/java/com/alibaba/fastjson2/asm/Opcodes.java
0.00% <0.00%> (ø)

.../java/com/alibaba/fastjson2/asm/TypeCollector.java
78.84% <ø> (ø)

.../alibaba/fastjson2/modules/ObjectReaderModule.java
0.00% <ø> (ø)

... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463d2f0...6d3c808. Read the comment docs.


Document Confusion

I am following this to install hare rpms but got the below error. I solved it by building hare rpms locally instead. I think that's because my VM is not within seagate. Maybe revising related document is needed.

Also, Hare Developer Guide, Hare User Guide and cluster-setup contain duplicated and minor different content. I suggest updating or merging those files.

@Saumya-Sunder
http://cortx-storage.colo.seagate.com/releases/ links will not be accessible from outside. Hence we need to put alternative for that in document.
Also Create a VM will not be applicable.

@shailesh-vaidya, I do understand that this cannot be accessible from outside but cant we implement the same as we had build the CORTX packages locally using Docker Image for external community as a solution?

@shailesh-vaidya, I do understand that this cannot be accessible from outside but cant we implement the same as we had build the CORTX packages locally using Docker Image for external community as a solution?

@mukul-seagate11  - Yes.  Docker image to build CORTX outside Seagate is ready and currently under testing and docuementaion phase. Details are available at https://github.com/Seagate/cortx-re/issues/167
For this issue - We should include steps to build Motr, Hare before using them. Following links can be added with consultation of respective component teams.
Hare - https://github.com/Seagate/cortx-hare/blob/dev/README.md#installation
Motr - https://github.com/Seagate/cortx-motr/blob/main/doc/Quick-Start-Guide.rst

@mukul-seagate11  - Yes.  Docker image to build CORTX outside Seagate is ready and currently under testing and docuementaion phase. Details are available at https://github.com/Seagate/cortx-re/issues/167
For this issue - We should include steps to build Motr, Hare before using them. Following links can be added with consultation of respective component teams.
Hare - https://github.com/Seagate/cortx-hare/blob/dev/README.md#installation
Motr - https://github.com/Seagate/cortx-motr/blob/main/doc/Quick-Start-Guide.rst

@PengMacro, So as suggested, Docker image to build CORTX for external community is ready and currently under testing and documentation phase so hope we are good to close the issue?

@PengMacro, So as suggested, Docker image to build CORTX for external community is ready and currently under testing and documentation phase so hope we are good to close the issue?


Fix LspInfo when filetypes not defined

Closes #663
CC: @cloggier
Will now warn you if filetypes not defined for a server.

I think this fix is not complete. I'm locally on latest master (at time of writing) and still get this error for line 66. Changing this locally solves it. So it appears to be the last occurrence.

I think this fix is not complete. I'm locally on latest master (at time of writing) and still get this error for line 66. Changing this locally solves it. So it appears to be the last occurrence.

How do you have an attached/active client without filetypes defined?

How do you have an attached/active client without filetypes defined?

This is the case for my efm-langserver setup. The following is a snippets that hides some parts of my setup, but eventually you can find some information. But for me it works...
lua require('lspconfig').efm.setup({
    \   init_options = {
    \     documentFormatting = true,
    \     hover = false,
    \     documentSymbol = false,
    \     codeAction = false,
    \     completion = false,
    \   },
    \   settings = {
    \     rootMarkers = { "package.json", "pyproject.toml", "Cargo.toml", ".git/" },
    \     languages = {
    \       sh = {
    \         require('efm_config.linting').shellcheck,
    \         require('efm_config.formatting').shfmt,
    \	    }
    \     },
    \   }
    \ })

This is the case for my efm-langserver setup. The following is a snippets that hides some parts of my setup, but eventually you can find some information.  EFM never starts for me if I don't define filetypes, and if I don't define filetypes, it won't be an active or attached client, so it won't be triggered by that help function.

I can't reproduce this. EFM never starts for me if I don't define filetypes, and if I don't define filetypes, it won't be an active or attached client, so it won't be triggered by that help function.

Okay. Idk. For me it works. If I comment out the specified line, the LspInfo command successfully lists the EFM server.
@lukas-reineke sorry to pull you in here. But I got inspired for EFM by your Reddit post and also took your dotfile as template how to setup. Moreover I remember that you implemented to the server the feature to support the config update capability. Maybe you know why this works even it apparently is unexpected.

Okay. Idk. For me it works. If I comment out the specified line, the LspInfo command successfully lists the EFM server.
@lukas-reineke sorry to pull you in here. But I got inspired for EFM by your Reddit post and also took your dotfile as template how to setup. Moreover I remember that you implemented to the server the feature to support the config update capability. Maybe you know why this works even it apparently is unexpected.

This made me realize LspInfo won't work when you manually launch a client (which doesn't have filetypes set), so I fixed it. try the PR and lmk if it works for you

This made me realize LspInfo won't work when you manually launch a client (which doesn't have filetypes set), so I fixed it. try the PR and lmk if it works for you

I'm not 100% sure I understand the problem, but

How do you have an attached/active client without filetypes defined?

you don't need to specify a filetype, the client defaults to start with BufReadPost
https://github.com/neovim/nvim-lspconfig/blob/87900ffcccd47bb6a09483ccf0d6840dc1d0d0d6/lua/lspconfig/configs.lua#L72-L76
Then the client can decide if it can handle that filetype or not. efm works like this, so it can also do wildcard matching, and you don't have to specify the filetypes twice.

I'm not 100% sure I understand the problem, but

How do you have an attached/active client without filetypes defined?

you don't need to specify a filetype, the client defaults to start with BufReadPost
https://github.com/neovim/nvim-lspconfig/blob/87900ffcccd47bb6a09483ccf0d6840dc1d0d0d6/lua/lspconfig/configs.lua#L72-L76
Then the client can decide if it can handle that filetype or not. efm works like this, so it can also do wildcard matching, and you don't have to specify the filetypes twice.

I realized this about the FT fallback after posting (and merged the PR fixing concatenating nil filetypes), not sure why I never ran into an issue with filetypes being unlisted. IMO this is undesirable behavior and we should have a wildcard attribute under filetypes. Otherwise if someone sets up a server and forgets the filetype attribute, the language server will unduly launch.

I realized this about the FT fallback after posting (and merged the PR fixing concatenating nil filetypes), not sure why I never ran into an issue with filetypes being unlisted. IMO this is undesirable behavior and we should have a wildcard attribute under filetypes. Otherwise if someone sets up a server and forgets the filetype attribute, the language server will unduly launch.


Error: [introspection-engine\connectors\sql-introspection-connector\src\re_introspection.rs:378:14] Could not find relation field Transaction on model Account.

This could be related to the recent relation lifting refactoring.
Command: prisma db pull
Version: 3.4.0
Binary Version: 1c9fdaa9e2319b814822d6dbfd0a69e1fcc13a85
Report: https://prisma-errors.netlify.app/report/13562
OS: x64 win32 10.0.22000
JS Stacktrace:
Error: [introspection-engine\connectors\sql-introspection-connector\src\re_introspection.rs:378:14] Could not find relation field Transaction on model Account.
    at ChildProcess.<anonymous> (D:\work\open_source\financeNext\node_modules\prisma\build\index.js:45755:30)
    at ChildProcess.emit (events.js:376:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)

Rust Stacktrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: <unknown>
  17: <unknown>
  18: <unknown>
  19: <unknown>
  20: <unknown>
  21: <unknown>
  22: <unknown>
  23: <unknown>
  24: <unknown>
  25: <unknown>
  26: BaseThreadInitThunk
  27: RtlUserThreadStart

Closing as a duplicate of https://github.com/prisma/prisma/issues/10453


Add Rewind/Forward option in Video Player

Description
LEARNER-7701

Add rewind and forward button in video player
on clicking rewind button video will be rewind for 10 secs
on clicking forward button video will be forwarded for 15 sec

@farhan-arshad-dev your suggestions look good to me!
The only reservation I have is, we'll need to make sure the layout and animation work on older devices that we support e.g. like Galaxy S3.


[RFC] improve readability of time literals

We have various expressions like:
if (hrt_elapsed_time(&start_time) > 8000000)

The number of 0's are hard to read, and we cannot use 8e6, since this is of type double.
C++11 introduced user-defined literals, which allows to write the following:
if (hrt_elapsed_time(&start_time) > 8_s)

As an example, I adjusted the land_detector to use the new literals. Commander would be a good candidate as well. We could also be more verbose if desired, for instance 8_sec or even 8_seconds.
I consider this as a start towards using more units throughout the code, for all the SI units we use, not only time. A potential library for this is https://github.com/nholthaus/units, as pointed out by @dagar . Some notes about it:

Uses double by default as underlying type, but it can be customized
requires the <chrono> header
not specifically targeted towards embedded, but it's efficient as conversions are done at compile-time
only very limited literal support, so it's kind of orthogonal to this PR / it will be simple to adjust later on.

Thoughts?
@MaEtUgR @RomanBapst @Stifael

good idea.
the potential library is built on c++14 though.
What speaks against having our own operators?

What speaks against having our own operators?

IMO nothing, but once we grow & extend it and add for example a meter class, it will be less effort to just use an existing and already tested library.

@bkueng You finally found a nice solution for the annoying trailing zeroes with all these microsecond values. Thanks a lot! I totally support the use of such useful language features.


[PackageModel] Clean up some legacy uses of "module" term.

@swift-ci please smoke test

omg, thank you

Note: there is no auto-merging to swift-4.1-branch, you may want to cherry-pick.

@swift-ci please smoke test


Persistence problem with Schlage FE599NX

Hi, Thank you for the app; however, I am struggling with a persistence problem.  I felt like I had a successful install and was able to set up the lock an several users and Pins.  For a time, they were there and could see the details of the 3 assigned slots.  Then it all disappears (classic app on iphone).  I've been through several cycles where the same thing happens.  When I say disappear, not just the user info.  I go back and the lock manager smart app is gone.  Even in the IDE, I go to My Devices and it's gone, yet I can go to Locations, click on the devices link there and see the device.  Any help appreciated!

I have the same problem as you, as soon as I exit the app and comeback, all installed locks and users are gone.

Hi SalourPublic, Sorry to hear that, and I'm not too sure I can be helpful.  I was able to get it working, but it's a classic case of having tried things numerous times and not being sure of exactly what worked.  I basically redid things numerous times, through the Samsung/Smarthings panel and the mobile app.  At one time I thought setting up a separate app on my wife's phone was interfering but that now works and I don't think it was the underlying problem.  Be sure to catch each opportunity to save on the mobile screens.  It might also be a case where something has to propagate, so patience might also be a factor.
I use it for a weekly-rental property and once it is working, it's awesome.  Good luck.


Update copy dependencies

More updates for #705

I think it's fine to copy compile-scoped transitive dependencies of provided-scoped dependencies...   I think this ends up being equivalent to "copy provided-scoped top-level and provided-scoped transitive dependencies".     It goes along with the simple approach of always including transitive dependencies.. so that's fine.
Finally, I was worried about the copyDependencies-only dependency.. however I debugged into it and see this is pretty well-defined as another "provided" scope dependency, looking at https://github.com/OpenLiberty/ci.maven/blame/master/liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/AbstractLibertySupport.java#L419-L420
from stack:

DeployMojo(AbstractLibertySupport).resolveArtifactItem(ArtifactItem) line: 411
DeployMojo(AbstractLibertySupport).createArtifact(ArtifactItem) line: 358
DeployMojo(AbstractLibertySupport).getArtifact(ArtifactItem) line: 159
DeployMojo(AbstractLibertySupport).getArtifact(String, String, String, String) line: 210
DeployMojo(AbstractLibertySupport).getResolvedDependencyWithTransitiveDependencies(String, String, String) line: 240
DeployMojo.copyDependencies(String, String, String, String, String, boolean) line: 166

I think we should be thorough and doc this too so I'll make that comment.


#60 Feat: Add output message for result bucket

I signed it on behalf of myself. I really just need this change in order to download some stuff from the bucket the results get stored in :c


After updating to Flutter version 3.22.3, I encountered an error when trying to run my web application.

Steps to reproduce
fvm run flutter run -d chrome
Expected results
Its should be run on chrome
Its working in mobile emulator
Actual results

Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
    at Object.W (http://localhost:55850/stack_trace_mapper.js:893:15)
    at bD.cr (http://localhost:55850/stack_trace_mapper.js:3807:3)
    at ez.$2 (http://localhost:55850/stack_trace_mapper.js:4432:5)
    at Object.kn (http://localhost:55850/stack_trace_mapper.js:2316:5)
    at http://localhost:55850/stack_trace_mapper.js:5794:21
    at a.<computed> [as iE] (http://localhost:55850/stack_trace_mapper.js:24:36)
    at Object.hR (http://localhost:55850/stack_trace_mapper.js:2449:33)
    at Object.R (http://localhost:55850/stack_trace_mapper.js:1820:6)
    at Object.eV (http://localhost:55850/stack_trace_mapper.js:2725:35)
    at dL.$2 (http://localhost:55850/stack_trace_mapper.js:5324:5)
    at dK.$0 (http://localhost:55850/stack_trace_mapper.js:5306:10)
    at Object.cr (http://localhost:55850/stack_trace_mapper.js:2731:9)
    at Object.jb (http://localhost:55850/stack_trace_mapper.js:2719:16)
    at cX.je (http://localhost:55850/stack_trace_mapper.js:2718:16)
    at aG.m (http://localhost:55850/stack_trace_mapper.js:3290:20)
    at Object.dR (http://localhost:55850/stack_trace_mapper.js:1664:16)
    at Object.a3 (http://localhost:55850/stack_trace_mapper.js:1676:23)
    at Object.jD (http://localhost:55850/stack_trace_mapper.js:2776:5)
    at Object.f7 (http://localhost:55850/stack_trace_mapper.js:2752:34)
    at cX.la (http://localhost:55850/stack_trace_mapper.js:2825:17)
    at Object.jp (http://localhost:55850/stack_trace_mapper.js:394:69)
    at kj (http://localhost:55850/stack_trace_mapper.js:2841:10)
    at http://localhost:55850/stack_trace_mapper.js:2835:42
    at dart._StackTrace.new.toString (http://localhost:55850/dart_sdk.js:13530:19)
    at Object.str (http://localhost:55850/dart_sdk.js:12460:43)
    at DiagnosticsStackTrace._applyStackFilter (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:4014:32)
    at new assertions.DiagnosticsStackTrace.new (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:4027:160)
    at assertions.FlutterErrorDetails.new.debugFillProperties (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:3741:24)
    at http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:2823:26
    at get builder (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:2826:30)
    at get builder (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:4048:27)
    at assertions._FlutterErrorDetailsNode.new.getProperties (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:2839:71)
    at [_debugRender] (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:1463:37)
    at diagnostics$.TextTreeRenderer.new.render (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:1369:34)
    at dumpErrorToConsole (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:3851:128)
    at FlutterError.reportError (http://localhost:55850/packages/flutter/src/foundation/_platform_web.dart.lib.js:3943:31)
    at [_invokeFrameCallback] (http://localhost:55850/packages/flutter/src/scheduler/binding.dart.lib.js:939:35)
    at binding$5.WidgetsFlutterBinding.new.handleDrawFrame (http://localhost:55850/packages/flutter/src/scheduler/binding.dart.lib.js:893:37)
    at http://localhost:55850/packages/flutter/src/scheduler/binding.dart.lib.js:766:16
    at internalCallback (http://localhost:55850/dart_sdk.js:35267:11)
2024-09-24 12:57:46.411 INFO Remote Config: The config is not updated..

Flutter Doctor output
Doctor output
fvm flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.3, on macOS 14.5 23F79 darwin-arm64, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.80.2)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Hi @r723, do you have a custom initialization script in your web/index.html file? Can you try https://docs.flutter.dev/platform-integration/web/initialization#upgrade-an-older-project to see if it helps?

Hi @danagbemava-nc  its already there ...
I m getting error after splash screen

Hi @r723, I did not ask if the index.html file exists but rather if you were doing custom initialization in that file. What version of flutter did you create your project with? If it was before 3.21, you will need to follow the steps in https://docs.flutter.dev/platform-integration/web/initialization#upgrade-an-older-project

Hi @danagbemava-nc Follow this step and still same error

Hi @r723, your logs do not show the web files being recreated. Can you share the current content of your web/index.html file?
Please provide the content in plain text.
In the future, do not share screenshots of logs. Please share the logs in plain text.
Thank you

Hi @danagbemava-nc Here my index.html :

AlertAware

Hi @r723, you do not appear to be loading the flutter.js script in your application. Can you add the script and see if you still experience this issue?

Hi @danagbemava-nc  Can you guide me on how to run the script? and where I get flutter.js script ?

Hi @r723, See https://docs.flutter.dev/platform-integration/web/initialization#flutter_bootstrap-js for how to initialize the script.
Also, See https://docs.flutter.dev/platform-integration/web/initialization#example-display-a-progress-indicator for how you can load a custom progress indicator in flutter 3.22 onwards

Hi @danagbemava-nc See the attachment I have this file

(()=>{var I=()=>navigator.vendor==="Google Inc."||navigator.agent==="Edg/",T=()=>typeof ImageDecoder>"u"?!1:I(),E=()=>typeof Intl.v8BreakIterator<"u"&&typeof Intl.Segmenter<"u",S=()=>{let o=[0,97,115,109,1,0,0,0,1,5,1,95,1,120,0];return WebAssembly.validate(new Uint8Array(o))},p={hasImageCodecs:T(),hasChromiumBreakIterators:E(),supportsWasmGC:S(),crossOriginIsolated:window.crossOriginIsolated};var w=U(L());function L(){let o=document.querySelector("base");return o&&o.getAttribute("href")||""}function U(o){return o===""||o.endsWith("/")?o:${o}/}var f=class{constructor(){this._scriptLoaded=!1}setTrustedTypesPolicy(e){this._ttPolicy=e}async loadEntrypoint(e){let{entrypointUrl:n=${w}main.dart.js,onEntrypointLoaded:r,nonce:t}=e||{};return this._loadJSEntrypoint(n,r,t)}async load(e,n,r,t,i){if(i??=s=>{s.initializeEngine(r).then(a=>a.runApp())},e.compileTarget==="dart2wasm")return this._loadWasmEntrypoint(e,n,i);{let s=e.mainJsPath??"main.dart.js",a=${w}${s};return this._loadJSEntrypoint(a,i,t)}}didCreateEngineInitializer(e){typeof this._didCreateEngineInitializerResolve=="function"&&(this._didCreateEngineInitializerResolve(e),this._didCreateEngineInitializerResolve=null,delete _flutter.loader.didCreateEngineInitializer),typeof this._onEntrypointLoaded=="function"&&this._onEntrypointLoaded(e)}_loadJSEntrypoint(e,n,r){let t=typeof n=="function";if(!this._scriptLoaded){this._scriptLoaded=!0;let i=this._createScriptTag(e,r);if(t)console.debug("Injecting

Hi @r723, can you share what your index.html file looks like at this point?

AlertAware

Up, same error!

Hi @r723, you have not followed the migration guide shared in https://github.com/flutter/flutter/issues/155590#issuecomment-2384880153.
Please follow the guide to see if you still experience the issue. If you do, please provide a complete minimal reproducible code sample so that we can properly investigate this.
Thank you


Could I use the lattice planner without the hdmap in Apollo5.0?

I noticed that the lattice planner + relative map works in Apollo3.0 from the previous issues,  could I use the lattice planner without the hdmap in Apollo5.0?

@HTL2018 No you won't be able to use lattice planner without HDMap. HDMap is mandatory. Thanks again for using Apollo. This issue is being closed. Please feel free to raise new issues if needed. Thanks again for using Apollo.


Installation Honeycomb

Going on day three trying to set Honeycomb up in a 64bit Ubuntu 16.04LTS VMware image. Installed Oracle-java8-installer, git, and puppet. Have followed instructions on /marsbard/puppet-alfresco/ as well as tried the install process of http://fcorti.com/2015/07/20/alfresco-honeycomb-edition-how-to-run/ --- neither of which work. I am working with a clean Ubuntu image, what step am I possibly missing? The ./install process runs but has a lot of red errors - see attached.
Need to get this concept installed and proven to get my company to fund my BeeCon2017 trip!
install-error.txt

We had such trouble with the change in java versions between 14.04 and later versions. TBH I'm not sure why it's trying to install openjdk 7 unless you changed the java version here: https://github.com/marsbard/puppet-alfresco/blob/08150909bd755bb2bf62f1886d916ecd5010ac9d/manifests/install/jdk.pp#L3 - try making sure the version is '8' and see how you get on. Looks like fonts-droid has been removed too, try using fonts-droid-fallback here: https://github.com/marsbard/puppet-alfresco/blob/08150909bd755bb2bf62f1886d916ecd5010ac9d/manifests/packages.pp#L65

Both of those files were exactly as expected. Does MySql have to be installed to localhost first or is that not loaded as a part of the install? No idea why nothing is getting deployed into /opt/alfresco

Nothing's going to /opt/alfresco because it hasn't got past the java dependency. I think I've fixed that now in commit 0e3ad1e381687ba8d683f781a29a7662daaff31f, seems to be building OK for me, can you try it and see if you get any further?

In the end (my test rig is very slow right now for reasons I won't elaborate) I got the following error
Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install libt1-dev' returned 100: Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libt1-dev
Error: /Stage[main]/Alfresco::Install/Package[libt1-dev]/ensure: change from purged to present failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install libt1-dev' returned 100: Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libt1-dev

In the morning I'll see what replaces libt1-dev. If memory serves I think we can just do without it.

Did a fair bit on this yesterday and today; it still doesn't start >.< but it gets a lot further.
Currently it's bombing out with a lack of a service file for tomcat; I'll try to look at that tomorrow if I can get a chance. If you can work out how to make the service file and pull request it in the files/ folder I can make sure it gets where it needs to in puppet. The tomcat it needs to run is in /opt/alfresco/tomcat/

Attempting this install, all looks better already; will owe you a few beers in Spain!
Thanks,
Mark Goodnight, PMP, ERMp
Sent from my iPhone

On Feb 10, 2017, at 12:44, Martin Cosgrave<EMAIL_ADDRESS>wrote:
Closed #118 via 4cee588.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

You don't owe me anything, thanks for helping prevent bitrot ;-)
---- On Fri, 10 Feb 2017 20:25:06 +0100 Mark Goodnight<EMAIL_ADDRESS>wrote ----
Attempting this install, all looks better already; will owe you a few beers in Spain!
Thanks,
Mark Goodnight, PMP, ERMp
Sent from my iPhone
> On Feb 10, 2017, at 12:44, Martin Cosgrave<EMAIL_ADDRESS>wrote:
>
> Closed #118 via 4cee588.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Martin,
I will look deeper into this, everything works as advertised except the Ubuntu menu disappeared in my test environment. I would deploy via server only for performance but odd that the Ubuntu interface would be affected by this install??
Mark
From: Martin Cosgrave<EMAIL_ADDRESS>Reply-To: marsbard/puppet-alfresco<EMAIL_ADDRESS>Date: Friday, February 10, 2017 at 2:32 PM
To: marsbard/puppet-alfresco<EMAIL_ADDRESS>Cc: Mark Goodnight<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [marsbard/puppet-alfresco] Installation Honeycomb (#118)
You don't owe me anything, thanks for helping prevent bitrot ;-)
---- On Fri, 10 Feb 2017 20:25:06 +0100 Mark Goodnight<EMAIL_ADDRESS>wrote ----
Attempting this install, all looks better already; will owe you a few beers in Spain!
Thanks,
Mark Goodnight, PMP, ERMp
Sent from my iPhone
> On Feb 10, 2017, at 12:44, Martin Cosgrave<EMAIL_ADDRESS>wrote:
>
> Closed #118 via 4cee588.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Added support for consul 0.5.0 features:

Added support for checks with service_id, http, and timeouts
Added address to consul::service
Switch checks to array in consul::service
Added consul_validate_checks.rb to handle the validation logic for checks in both consul::service and consul::check

Super great!!!

Thanks!

@split3 you are now an official contributor!
Feel free to work directly on this remote, no need to fork. But please continue to do PR's with any non-trivial changes.

Awesome will do, thank you very much!


Implement first migration model

Add to the model all the following fields to complete it:

[x] Add a product_family or a subcategory, apart from product_category to add more organization.
[x] Add data about packaging formats to improve product data.
[x] Add the possibility to track if a product is 'available' or 'discontinued'.
[x] Add the possibility to track if a provider_product is 'available' or 'discontinued'.
[ ] Articles/inventory_provider_product represent what you bought, next step from provider_product. As you cannot keep track of a product 1 by 1 (it would imply to paste a unique id to each article in the shop), articles will be updated automatically using ascending sorting by buy_date. Articles will contain:

id + inventory_id
provider_product_id
buy_date
expected_expiration_date
buy_price
suggested_sale_price
timestamps

[x] add web_page field to manufacturers and providers.
[x] add catalog_link field to manufacturers and providers.
[ ] Create a list of the products to order as raw_order. Contains:

product_id::int
quantity::int
notes::text
urgent::boolean

[x] Modify manufacturer and provider reals to have 3 decimal numbers on ¿Prices?
[ ] Generate a list of products to order by provider as provider_order and add fields as:

order_date
order_sent_date
order_reception_date
order_pay_date

[x] keep track of the quantity of a product in product table as we cannot trust the count in articles. This will imply to create a way to check diff between product.quantity and article.COUNT
[x] Product.expiration_period add expiration_quantity and expiration_unit as enum of ['year', 'month', 'day']
[x] product_stock with quantities of each product in each inventory
[ ] Add customers table
[ ] Add errands and sales
[ ]

Provisional state


ubuntu20.04 arm，compile errors:

cmake .
make -j6

concepts are part of C++20 and your compiler may not support it yet. I suggest three solutions:

use -std=c++20 compiler flag to enable c++20 features (e.g. for gcc v.9.4)
upgrade your compiler
pass the NO_OCL CMake flag to the build HWinfo with c++11

I hope, this solves the issues.


MODIFY NAVBAR : Make the Navbar Sticky and Improve Its Visual Appeal

The current navbar can be improved to enhance user experience by making the following changes:

Sticky Navbar: Make the navbar sticky to remain visible during scrolling, allowing users to navigate easily.
Visual Enhancements: Update the design with a consistent color scheme, padding, and hover effects on the menu items to improve aesthetics and interactivity.

@dhairyagothi
Can you please assign me this issue?
@falakniyaz94

i want to contribute on this project .please assign me this project


Recommended Setting for Oculus Quest

I thought it would be nice to add to the docs the recommended setting for
using with the Oculus Quest.
I noticed a huge improvement moving to 5Ghz wifi.
but I'm not sure if 30Mbps and H.265 is the best settings.
Once everyones played with it a while, we should consolidate the wisdom down.

I've experimented very little, but what I've found so far is increasing the render resolution very nice.  I'm running at 150% and 27MB/s bitrate on H.265 and it looks great.  I've very curious to hear as well what others are running to see if I can further tweak it.
Specs:
dedicated 5ghz network
i7 6700k
GTX 1080

You can get lower latency with H.264, H.265 has better video quality but this isn't as important as low latency.

If you use a AMD RX400 or RX500 series take for sure the H.265. The hardware encoder for 265 is way stonger than 264. In my installation it did render 264 even in Software increasing the latency from around 60ms to 220ms with all components on the limit.

Using H.264 with 30Mbps and 150% scaling, work ok but occasionally will get drops and picture is all wrong, 5Ghz obviously.

I found H.264, 100mbps @ 150% worked best for my setup in Elite Dangerous with 2.0 Supersampling.
Ryzen 5 2600x, 16GB, RTX2070
H.265 looks way better but the latency kills it for me unfortunately.
The intermittent Picture Arfifacts every 5 minutes or so are beig discussed in another thread right now and seem to be a common problem.

I found H.264, 100mbps @ 150% worked best for my setup in Elite Dangerous with 2.0 Supersampling.
Ryzen 5 2600x, 16GB, RTX2070
H.265 looks way better but the latency kills it for me unfortunately.
The intermittent Picture Arfifacts every 5 minutes or so are beig discussed in another thread right now and seem to be a common problem.

What buffer size are you using?

standard 200

I achieved a 20-30ms latency with H.265, 50Mbs bitrate, and 150% resolution by first enabling the Windows 10 mobile hotspot (5Ghz only), and then connecting the Quest to it. I did this with a Lenovo X1 Extreme Laptop.


eip2930: add payload methods for TxEip2930

Related https://github.com/paradigmxyz/reth/pull/10623

looks like we need to bump msrv

looks like we need to bump msrv

@mattsse done here https://github.com/alloy-rs/alloy/pull/1219

hmm, not sure we need those? we already have encoded_len_with_signature and encode_with_signature which accept with_header: bool

Oh that's true thanks


Question about dynamic elements

Hi,
I'm struggling with the markdown and angular2 links/hrefs. I need the relative links within my MD documentation between the specific pages.
Let's assume that I have page doc1.md and doc2.md. I want to have on the page doc1.md link to page doc2.md but I would like to serve it and render by single component (which is of course part of entire page which has navbar, etc. - just normal case).
Because I cannot use just links but I have to replace the displayed content for the component which render my docs I was thinking about MarkdownService.renderer.link customization. Something like that:
this._markdown.renderer.link = (href: string, title: string, text: string) => {
      return '' + text + '';
};

And the path would be replaced by rendering component, something like that:

Unfortunately when I prepare custom render angular doesn't recognize the link click on given a element. Do you know or could give a hint is it possible to deal with the problem by angular2-markdown - I don't know some kind of dynamic generation or something like that?
Thanks for any advice.
BR

sounds like an item i am thinking about right now.
i am thinking of making a "wiki" in angular x  with this package and i think i have an idea of what needs to happen.
the answer has a lot to do with routing ....
so part of the thing is we need to make a route that has optional child routes that map to the component / view.
possibly inject routing table entries into the angular routing table (may not be needed)
possibly make the links that are "app relative" become angular router link items, that would cause the angular runtime to call the router to do the Navigation for us.
look here https://angular.io/tutorial/toh-pt5
and at the section on router links and dynamic router links

this might work, use dynamic component module along with the router link tag..... when the link is in the angualr app and not a link to another web site
https://stackoverflow.com/questions/42123385/angular2-dynamic-html-with-functional-routerlink

I've used the following approach: https://plnkr.co/edit/mcvILwmOLvrS2PxIrXX8?p=preview


Terraform: Logger issues with NetPlan

aws_instance.logger (remote-exec): /etc/netplan/01-netcfg.yaml:1:5: Error in network definition: unknown key 'eth0'
aws_instance.logger (remote-exec):     eth0:
aws_instance.logger (remote-exec):     ^
aws_instance.logger (remote-exec): Device "eth0" does not exist.
aws_instance.logger (remote-exec): Incorrect IP Address settings detected. Attempting to fix.
aws_instance.logger (remote-exec): /opt/DetectionLab/Vagrant/bootstrap.sh: line 94: ifdown: command not found
aws_instance.logger (remote-exec): Device "eth0" does not exist.
aws_instance.logger (remote-exec): /opt/DetectionLab/Vagrant/bootstrap.sh: line 96: ifup: command not found
aws_instance.logger (remote-exec): eth0: error fetching interface information: Device not found

The core issue here seems to be that the AMI is now using ens5 instead of eth0. I'm not entirely sure how that seems to have changed recently.

Should be fixed now


mypfp.io, an anime-like NFT avatar generator service

Thanks for publishing a very useful model and sample code. We've been using your "Face Portrait v2 model" in our experimental NFT project mypfp.io, an anime-like NFT avatar generator service. Since it was implemented in PyTorch, we were able to quickly develop an API using Flask.
We've put a sample video on mypfp.io for you to play with if you want and we would be happy if you could add some collaboration projects section on the README.md.
Thanks!
mypfp.io
NFT minted in the video
https://user-images.githubusercontent.com/94442111/141962737-b5d1ad1f-9729-447f-b9fa-c82ce5b27972.mp4

Thanks for publishing a very useful model and sample code. We've been using your "Face Portrait v2 model" in our experimental NFT project mypfp.io, an anime-like NFT avatar generator service. Since it was implemented in PyTorch, we were able to quickly develop an API using Flask.
We've put a sample video on mypfp.io for you to play with if you want and we would be happy if you could add some collaboration projects section on the README.md.
Thanks!
mypfp.io NFT minted in the video
mypfp_short.mp4

You sure license allows that?

MIT License

MIT License
there is no training code available in this repo -> you didn't train anything yourself and just used weights trained on dataset you didn't own or even saw, and most likely is original animegan2 dataset.  original animegan2 and it's dataset is "for non-commercial purposes such as academic research, teaching, scientific publications." as written on project page.

About Face Portrait v2 model, it says they used training sets prepared by themselves to derive weights and publish its weight and model under the MIT license. It is not related to the original project.

there is no proof of their words since dataset and train code are not provided, and results (weights) cant be replicated.

Have you ever checked original datasets? Are there face portrait datasets? Anyone who has studied machine learning even a little bit can easily imagine how difficult it would be to create such a portrait-specific model from the original data set.

ha, have YOU seen datasets weights you used was trained on? was able to reproduce the weights with ~same result thus claims of author are believable true? So far it looks like model is trained on random googled images/movies with zero respect to rights, and author claims "all ok it is mit" while providing zero proof

If you don't believe the author, then you just don't use it.

If you feel that way, then why don't you just not use it yourself?

 Pathetic.

I'm actually curious what the authors of this repository intended with the license. My non-legal interpretation is that the MIT license would include the weights, but I'd like to here from the repo owner themselves.
My understanding is that the copyright and licensing associated with a dataset need not necessarily apply to the model and consecutive generated outputs. Working with separate licenses for the code, datasets, weights and outputs can be incredibly confusing, and it's fair to say that it's up in the air.

This could be really interesting. I think such someone will be interested in NFT Avatars. If someone is looking for an answer whether it is worth investing in nft avatars, I highly recommend this post: https://gamerseo.com/blog/are-nft-avatars-worth-the-hype-around-them/


not working with bootstrap 3.3.7 and jquery 3.3.1

i use  bootstrap 3.3.7 and jquery 3.3.1 but bootstrap-select not workin, what's problem?
see my demo at  jsfiddle.

Remove bootstrap select copy paste as js file within jq331 and add boostrap-select.js bootstrap.js file in the resources then it worked.
Check it out here: https://jsfiddle.net/xs8y38o6/9/


Show the dependency of a source, view, materialized view.

Is your feature request related to a problem? Please describe.
drop XXX cascade may not always be an option in a production environment, e.g. disabled on purpose for safety.
People may want to see the dependencies and drop them one by one.
select matviewname, definition from pg_matviews; can show the raw SQL and thus find out the dependency by SQL, but it's sort of cumbersome, and we want to show the dependency by inputting the one that others depends on and show the others.
Describe the solution you'd like
even recursively
Describe alternatives you've considered
No response
Additional context
No response

Does the dashboard applicable in this case?

is the desired syntax show dependencies [for object (optional)]?
> show dependencies for v;
name | type
-------------------------
t1  |  table
w  | materialized view

> show dependencies;
object | dependencies
------------------------------
v   | [t1, w]

is the desired syntax show dependencies [for object (optional)]?

> show dependencies for v;

name | type

-------------------------

t1  |  table

w  | materialized view

> show dependencies;

object | dependencies

------------------------------

v   | [t1, w]

I think this already quite good for terminal, it seems hard to demonstrate a long lineage of dependency in terminal

Now the Dashboard UI can show the dependency as lines. Closed now.


There is nothing between the comma and the close bracket

FORMAT = 'CSV', PARSER_VERSION = '2.0',     )
I am not sure we have an excess comma or something is missing between the comma and the close bracket.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d9e4b4c-1d1f-4d81-9ad9-0201c7734b53
Version Independent ID: 42e48906-2585-c602-51e8-1342ff559d44
Content: Store query results to storage - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql/create-external-table-as-select.md
Service: synapse-analytics
Sub-service: ****
GitHub Login: @vvasic-msft
Microsoft Alias: vvasic

@dudu-markovitz Thank you for making us aware of this issue. We are evaluating this and will update the the documentation as appropriate.

@dudu-markovitz I believe the correct formatting should be: FORMAT = 'CSV', PARSER_VERSION = '2.0' ) but I was attempting to walk through this tutorial to confirm this and found that the prerequisites section details a setup_script that needs updating as well.
Part 2 of the setup_script is generating the following errors:

Msg 40514, Level 16, State 1, Line 96
'CREATE CREDENTIAL' is not supported in this version of SQL Server.
Msg 105056, Level 16, State 1, Line 111
CREATE EXTERNAL DATA SOURCE statement failed because the 'TYPE' option is not specified. Specify a value for the 'TYPE' option and try again.
Msg 105056, Level 16, State 1, Line 118
CREATE EXTERNAL DATA SOURCE statement failed because the 'TYPE' option is not specified. Specify a value for the 'TYPE' option and try again.
Msg 105056, Level 16, State 1, Line 122
CREATE EXTERNAL DATA SOURCE statement failed because the 'TYPE' option is not specified. Specify a value for the 'TYPE' option and try again.
Msg 105056, Level 16, State 1, Line 125
CREATE EXTERNAL DATA SOURCE statement failed because the 'TYPE' option is not specified. Specify a value for the 'TYPE' option and try again.
Msg 15151, Level 16, State 1, Line 154
Cannot find the external data source 'SqlOnDemandDemo', because it does not exist or you do not have permission.
Msg 103010, Level 16, State 1, Line 168
Parse error at line: 5, column: 5: Incorrect syntax near 'OPENROWSET'.
Msg 103010, Level 16, State 1, Line 178
Parse error at line: 5, column: 6: Incorrect syntax near 'OPENROWSET'.
Msg 103010, Level 16, State 1, Line 208
Parse error at line: 5, column: 5: Incorrect syntax near 'OPENROWSET'.

Completion time: 2020-06-03T13:11:49.7120356-07:00

I am going to have the content author review this and make updates as appropriate. @jovanpop-msft and @vvasic-msft for awareness.

@Mike-Ubezzi-MSFT script should be executed on SQL on-demand.
@dudu-markovitz is correct about the comma.

@jovanpop-msft do you want to make the change?

@Mike-Ubezzi-MSFT - I added explicit checks in the script that will throw an error if someone execute it on master database or some endpoint different than SQL on-demand.
@dudu-markovitz - sample is corrected - thanks.

#please-close


fix(docs): Fixed creating Windows service commands

escaping " to "

Codecov Report

Merging #8979 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8979      +/-   ##
==========================================
- Coverage   41.25%   41.25%   -0.01%
==========================================
  Files         546      546
  Lines       71037    71037
==========================================
- Hits        29307    29306       -1
- Misses      38006    38013       +7
+ Partials     3724     3718       -6

Impacted Files
Coverage Δ

modules/indexer/indexer.go
44.73% <0%> (-10.53%)
:arrow_down:

modules/task/migrate.go
25% <0%> (-3.95%)
:arrow_down:

models/error.go
32.67% <0%> (-1.19%)
:arrow_down:

models/repo.go
46.56% <0%> (+0.04%)
:arrow_up:

models/gpg_key.go
55.59% <0%> (+0.55%)
:arrow_up:

modules/migrations/gitea.go
9.45% <0%> (+0.63%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

modules/migrations/migrate.go
23.75% <0%> (+1.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad67ca...e94cb38. Read the comment docs.

@WarsFeng I wonder if you'd be able to test #8964 to see if after that Gitea shuts down gracefully - e.g. it doesn't just drop ongoing connections.


[FEA] Fix Databricks failed cases when Time zone is non-UTC

Is your feature request related to a problem? Please describe.
Spark-Rapids currently does not support legacy rebase mode when TZ is non-UTC.
For non-UTC time zone, DB failed some cases because of DB default timestamp rebase mode is legacy which is different with regular Spark.
Describe the solution you'd like

[ ] Fix existing cases
[ ] Add cases that do not rely on default mode: Testing all the rebase mode.

Describe alternatives you've considered
Additional context

Not planing work on this for release 24.04, unassign it from me.


Unset field

This Changes the way fields are unset, so that by a single update query, changes fields get updated and unset fields get removed from the document.

This PR includes PR #1664 and is backward incompatible as well.

It also covers #1468.

Hi there,
This PR contains a breaking change and will be released within next version.
Closing for now.
Thanks.

@divine I am glad this project became active. I'll send a PR within a day.


Prettier extension causing remote extension server restart loop

Prettier extension seems to be causing remote extension server to restart over and over again.
Version: 1.78.0
Commit: 252e5463d60e63238250799aef7375787f68b4ee
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.1 Safari/605.1.15
Embedder: codespaces

\causedbyextension

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Integrate sentry for Simulator

Push errors to sentry for better tracking.

Refer: https://docs.sentry.io/platforms/javascript/

/assign

@tachyons sir could you please review the merge request

can you please assign me this issue ?

/assign

/assign

Really intrested to work on the issue, Can I?

is there an existing Sentry DSN ? @tachyons

Since this issue is open, plz assign this to me

There’s already a pull request but I would like to know if additional contributions are needed.
@tachyons


Launch menu should list peers available on Hub and on the LAN

UI Impact
This is what the Tray's Launch submenu looks like:

The "Launch SS console" presumes there's a single local to the machine peer running. The menu item will go away. Instead we will have two new dynamic menu items:

Local Peers
Remote Peers

Each of these menus will list peers by human readable name. The names of peers will appear as menu subitems. The user can select the peer to launch a browser to that specific peer's SS console.
Local Peers
These peers will be peers that are present on the local LAN. SSDP (Simple Service Discovery Protocol) which is used by RH's to discover local peers can be used by the Tray application to find Peers on the LAN. This way users need not configure anything.
Remote Peers
The Hub will be used to get a list of peers owned by the user who is logged into the hub via the tray. Remote peers will be peers that are:

NOT present on the LAN
AND registered on the Hub

Some peers on the LAN may be registered so they might be returned from the listing provided by the Hub. WARNING: You will need to remove these local registered peers so they are not offered in duplicate on both menus.

We also need to modify about dialog to make updates of RH and RH management possible.

We also need to modify about dialog to make updates of RH and RH management possible.

Yes we can do these step by step.


Missing @Nullable

Just got a NPE from kotlin :)

Build failure is unrelated. Flaky tests are the worst!


Milliseconds in timestamp lost in translation

For a custom syslog parser I have the following input:
2023-02-16T20:50:45.106263+01:00 leaf2 sr_chassis_mgr: chassis|1172|1172|00122|W: Interface lag1 is now down for reason: standby-signaling

After processing in sc4s and splunk, this appears in the logs as
2023-02-16T19:50:45.000+00:00 leaf2 sr_chassis_mgr: chassis|1172|1172|00122|W: Interface lag1 is now down for reason: standby-signaling

    host = leaf2
    source = sc4s
    sourcetype = nokia:router

My parser uses template('t_everything') - what could be causing the loss of those 106ms?

@jbemmel can you please provide the parser in the comment? I will take a look.

The parser is at https://github.com/jbemmel/srl-splunk/blob/main/app-syslog-nokia_srlinux.conf

Thanks for looking into this, I'll try

Hello, @jbemmel !
Please let me know is it working for you?


Quick comments

Being able to use Ctrl/Command + FORWARD_SLASH would be nice when editing RPG, CL, etc. I can easily do this one.
Might involve creating a command which looks at the activeEditor, etc.

Okay, I went ahead and created the commenter but I don't think it's the right way to do it since it doesn't work with the usual Cmd+/.
I couldn't find in the docs where to implement it.. I guess it's tied to an LSP or language implementation?

@worksofliam do you mind if I steal this one lol?
https://github.com/barrettotte/vscode-ibmi-languages/issues/67

@barrettotte yes lol! Please let me know when you've got that deployed so I can remove the dumb functionality I added.
Thanks for your work there!

@worksofliam Yeah I just happened upon that VS Code documentation page today while fixing another issue. I just have one last bug to fix and I should have everything pushed up here shortly. I'll at you when its ready

@barrettotte I saw you made two releases, so I'm gonna remove my stuff in prep now.
Thanks!

@worksofliam  ah yeah my bad, the notification might not have come through on a different issue I closed. It should be all set, thanks!


auto craft update

ive turn on fireworks rocket, but the flight duration is 1, which i wanted is 3, can you add more advance in autocraft things,
can you turn on chat in this github, maybe other github member will answer my question about scripting, see in my github repository everybody can chat without create new issue.

I don't think anyone is really sitting here in github and check issues/chat (besides me).
You can join matrix and ask about scripts.
I will check fireworks, but from what I remember this recipe for lvl 3 fireworks is not displayed inside crafting menu. Maybe I will need to hardcode this exact scenario.

I enabled "discussions"

As I thought there is a problem with fireworks. Proper firework recipe exists only on the server side. But it is CustomRecipe meaning it has custom logic to generate crafting output because of firework stars and gunpowder amount.
So, really the simplest option could be to just hardcode fireworks are craft level 3.

yeah fireworks has many variations, that maybe in future can be toggled, like firework shape, or color, or else that maybe hard to do,
sometimes we need just flight duration to 3 using 1 paper and 3 gun powder just for elytra things, sometimes else we need so many kind of fireworks that for celebration or else,
but I think in this new Minecraft version no need to hurry coding on this, because Minecraft also have vanilla auto crafter, i just need to see how it works, maybe it hard in begining to create redstone building or maybe Minecraft server has redstone limit which i must find another way, but after that it will easy to use.
and thanks for adding discussion, now i will not create new issue for my suggestions for this mod.

Yeah, I abandoned the idea of supporting level 3 fireworks. The problem is current code calls place recipe method, and the game moves ingredients automatically:
RecipeHolder<CraftingRecipe> holder = findRecipe(config);
if (holder != null) {
    boolean shift = holder.value().getResultItem(mc.level.registryAccess()).getItem().getDefaultMaxStackSize() > 1;
    mc.gameMode.handlePlaceRecipe(craftingScreen.getMenu().containerId, holder, shift);
    state = State.RECIPE_CLICKED;
}

And since there is no recipe for custom fireworks I would need to code completely different approach.

i hope i can code java, the syntax kinda manny things called for simple task so far i just know PHP language, because i can create some little application that run in browser you can visit my github to see it, java and c++ is my next language, for me coding is just for fun or hobby, thanks because to create this mod, this mod is the one mod that i must have, second is sodium or optifine.


I can't get the cell's location of screen

I want to get the element by mouse point,but when I use GetNodePathAt It return the table ,not the cell inside, I can get the table's Children ,But the cell can't show  me the location of it ,?so can you tell me how to do it ?

@fjwgrace Look here https://docs.oracle.com/en/java/javase/14/access/java-access-bridge-api.html#GUID-C79D9A13-0922-49DC-A28B-DFECDCFA79DD
You should also remember that you need to select a table or a cell if you want to get correct data from JAB

@fjwgrace Look here https://docs.oracle.com/en/java/javase/14/access/java-access-bridge-api.html#GUID-C79D9A13-0922-49DC-A28B-DFECDCFA79DD
You should also remember that you need to select a table or a cell if you want to get correct data from JAB

may be you don't understand what I'm saying,I mean how to get the cell by mouse position,just like the function "find Accessibility element using mouse pointer" of the Access Bridge Explore. When I use the tool to find cell in table ,It also just Highlight the table, not the cell.

@fjwgrace  hi solved issue??,
even for me also "find Accessibility element using mouse pointer" gives wrong elements. wrong coordinates.