Enable typed queries for threads

Description
@liveblocks/react

useThreads now handles typed queries

Example:
  useThreads({
    query: {
      metadata: {
        organization: {
          startsWith: "liveblocks:",
        },
      },
    },
  })

@liveblocks/node

getThreads now handles typed queries

  client.getThreads<{
    status: "open";
    priority: 3;
    organization: "liveblocks:engineering";
  }>({
    roomId: "room1",
    query: {
      metadata: {
        status: "open",
        priority: 3,
        organization: {
          startsWith: "liveblocks:",
        },
      },
    },
  })

⚠  Still TODO, fix the typescript error on objectToQuery

@FlowFlorent Let me know once you're done with this PR. I'm happy to play devils advocate and try to come up with unit tests that won't pass.

@nvie Thanks for all your comments, I've adjusted the PR.
I am still a bit uncertain about the escaping part though 🤔


ci: Fix the Envoy Mobile Traffic Director YAML

Discovered the issue through a manual run of the workflow: https://github.com/envoyproxy/envoy/actions/runs/5257781938/jobs/9501080688

/retest


Show all the users

@andreaparisi96 add a function to the database.py file that shows all the users it the database.

I implemented the display_all_users function for admin user here


Print other features for each problem

Hi,
Thank you for this great dataset. I have two questions:

How can we print the description of the problems and solutions (including correct, wrong, etc) and test cases? do you have any list of features that can help us to fetch other attributes?
for example "CODEFORCES 1569_A" as a source, means the problem is fetched from codeforces but what is 1569_A or_B? It seems more than an index to me.

Thank you :)

Not an author so don't have an exact answer, but check out this tutorial if you haven't already, it outlines how to use proto2 files for simple I/O in python (and what the file contents actually mean!)

Thank you, I will try.


[Chef 18] chef_client_config breaks with rights in the current code base

The way this resource works has changed since Chef 17 where if the directory existed it just did nothing. I can see how that would not deliver desired state configuration outcome and agree this was not the best course of action.
We are keen on security and have had the following code snippet in our company baseline cookbook to ensure the chef folder is secure.
  directory 'c:\chef' do
    only_if { File.directory?('c:\chef') }
    rights :full_control, 'Administrators'
    rights :full_control, 'SYSTEM'
    inherits false
    recursive true
  end

If you add this to a chef infra client 18 run you end up in a chicken/egg issue where the current resource overrides this, or tries to, as it does not use the rights option, which is windows only...
The current chef_client_config resource does not provide options to setup rights OR windows specific requirements as such.
My first idea was to make a distinction here between windows and rest and provide the rights option on the resource, but am not sure that is the best way forward.
The relevant code is here for infra client 18:
https://github.com/chef/chef/blob/4d66a5dc552a37f856dc59516a31d629d44a4769/lib/chef/resource/chef_client_config.rb#L256-L271
Curious to hear your thoughts around how we can achieve the lockdown we desire and not break the complete chef folder.
For the record:
doing chef_client_config and this code leaves the c:\chef folder without any permissions at all. We needed to do takeown and icacls to get access and restore permissions and it broke directly again so it is reproduceable.

There is a weirdo bug that appears to be a Ruby problem. In the file_access_control\windows.rb file the code incorrectly detects a nil object - acls.nil? returns false when it is in fact nil. That results in a borked ACL object that fails and resets permissions or otherwise does bad things. I'm working on a PR to address that.

Corrected with this PR. Released in Chef 18.4.x


Cert

Version: 3.0-SNAPSHOT
Build: 2018-03-18 00:21
OS: Windows 10 10.0
JDK: 1.8.0_161 amd64 Oracle Corporation
The Cert changes to "G" every time I edit a movie, please remember the right one.

thanks for the report - should be fixed in the next build


Numpad keys not detected

Numpad keys are not detected with normal handlers (they can be detected under the '*' handler, but not under a regular handler)
Demo:
https://jsfiddle.net/fk1o32a9/7/
Actual:
Using Digit1, event is detected for both events (both 1 and *)
Using Numpad1, event is detected only for "*" event
Expected:
Using Digit1, event is detected for both events (both 1 and *)
Using Numpad1, event is detected for both events (both 1 and *)

@swd120 I need to buy a keyboard.

Let me know if there's any additional info you might need.

It works for me (mac).
@swd120 No offense - you sure that the keypad num is enabled?

@bichotll I was able to reproduce the issue with my keypad turned on and numlock off. It's like the library believes that the '1' from the keypad was a different key. The key does get captured under '*' but not under '1'.

It seems to be a Windows issue.
Works fine on MAC.
Maybe because the KeyboardEvent.which is different between Mac and Windows.
That's my current Workaround:
hotkeys('*', ({key}) => {
   const keyValue = parseInt(key, 10)
   if(keyValue){
      doSth(keyValue)
   }
})

Yes, the issue is with windows. Does anyone have any solution?

I'm using react-hotkeys-hook ... @ishan576 are you suggesting that var.js needs to be modified and then build?  I would then need to do a custom build of react-hotkeys-hook as well?
@jaywcjlove this looks pretty straightforward... any chance you could make the fix?

I'm using react-hotkeys-hook ... @ishan576 are you suggesting that var.js needs to be modified and then build?  I would then need to do a custom build of react-hotkeys-hook as well?
@jaywcjlove this looks pretty straightforward... any chance you could make the fix?

@CourtHive: My usage was in a pure js mode. But yes, I think you'll have to modify and re-build.

thanks @ishan576 appreciate the reply

Same problem happening with me, trying to debug I noticed that only it only happen on Firefox on Chrome works fine. I'm using the react wrapper react-hotkeys-hook but the same problem happens in this lib's homepage.

@gimoteco are you saying that the numeric keys work for you on Chrome?  We have tested in Chrome on Windows and it does not work.  Based on @ishan576 comments above and looking at the code I don't think the key codes for numeric keypad are handled at all.  I don't understand why this issue can't be addressed as the solution seems to be fairly straightforward...

Yeah, testing in https://wangchujiang.com/hotkeys/ the numpad keys work on chrome and don't work on firefox (just the numpad digit keys).
I'm using MacOS 10.15.6, Firefox 80 and Chrome Version 85.0.4183.83 (Official Build) (64-bit)


Add calculation property to Subnet Data Source

Hi,
Is it possible to add the calculation property to Subnet exported attributes? They are available via raw rest api.
It will be nice to have also the nameseververs composite property: now we have the id but there is no data source to obtain this information.
Thank you

Hi @Gianlu
This terraform provider use API that provide phpipam software to receive data.
In the phpIPAM documentation https://phpipam.net/api/api_documentation/ I don't see any API method to get nameserver hostname or fqdn. If you have information about such API endpoint please show some example.
What did you mean by calculation property to Subnet exported attributes?

Hi,
when I query subnet endpoint (subnets/169/ for example) in my phpipam install, it returns this structure:
{
    "id":  "169",
    "subnet":  "<IP_ADDRESS>",
    "mask":  "24",
    "sectionId":  "3",
    "description":  "My-Subnet",
    "firewallAddressObject":  null,
    "vrfId":  "0",
    "masterSubnetId":  "107",
    "allowRequests":  "0",
    "vlanId":  "105",
    "showName":  "1",
    "device":  "0",
    "permissions":  "{\"4\":\"1\",\"6\":\"2\",\"7\":\"1\",\"8\":\"2\"}",
    "pingSubnet":  "0",
    "discoverSubnet":  "0",
    "DNSrecursive":  "0",
    "nameserverId":  "2",
    "DNSrecords":  "0",
    "scanAgent":  "0",
    "isFolder":  "0",
    "isFull":  "0",
    "tag":  "2",
    "editDate":  "2021-08-16 10:30:08",
    "threshold":  "0",
    "linked_subnet":  null,
    "location":  "9"
    "nameservers":  {
                        "id":  "2",
                        "name":  "Zone DNS",
                        "namesrv1":  "<IP_ADDRESS>;<IP_ADDRESS>",
                        "description":  null,
                        "permissions":  "3;17",
                        "editDate":  "2021-05-07 14:21:08"
                    },
    "gatewayId":  "8086",
    "gateway":  {
                    "ip_addr":  "<IP_ADDRESS>",
                    "id":  "8086"
                },
    "calculation":  {
                        "Type":  "IPv4",
                        "IP address":  "/",
                        "Network":  "<IP_ADDRESS>",
                        "Broadcast":  "<IP_ADDRESS>",
                        "Subnet bitmask":  "24",
                        "Subnet netmask":  "<IP_ADDRESS>",
                        "Subnet wildcard":  "<IP_ADDRESS>",
                        "Min host IP":  "<IP_ADDRESS>",
                        "Max host IP":  "<IP_ADDRESS>",
                        "Number of hosts":  254,
                        "Subnet Class":  "private A"
                    },
    "links":  [
                  {
                      "rel":  "self",
                      "href":  "/api/appssl/subnets/169/",
                      "methods":  "GET POST DELETE PATCH"
                  },
                  {
                      "rel":  "addresses",
                      "href":  "/api/appssl/subnets/169/addresses/",
                      "methods":  "GET"
                  },
                  {
                      "rel":  "addresses/{ip}",
                      "href":  "/api/appssl/subnets/169/addresses/{ip}/",
                      "methods":  "GET"
                  },
                  {
                      "rel":  "usage",
                      "href":  "/api/appssl/subnets/169/usage/",
                      "methods":  "GET"
                  },
                  {
                      "rel":  "first_free",
                      "href":  "/api/appssl/subnets/169/first_free/",
                      "methods":  "GET"
                  },
                  {
                      "rel":  "slaves",
                      "href":  "/api/appssl/subnets/169/slaves/",
                      "methods":  "GET"
                  },
                  {
                      "rel":  "slaves_recursive",
                      "href":  "/api/appssl/subnets/169/slaves_recursive/",
                      "methods":  "GET"
                  },
                  {
                      "rel":  "truncate",
                      "href":  "/api/appssl/subnets/169/truncate/",
                      "methods":  "DELETE"
                  },
                  {
                      "rel":  "permissions",
                      "href":  "/api/appssl/subnets/169/permissions/",
                      "methods":  "PATCH"
                  },
                  {
                      "rel":  "resize",
                      "href":  "/api/appssl/subnets/169/resize/",
                      "methods":  "PATCH"
                  },
                  {
                      "rel":  "split",
                      "href":  "/api/appssl/subnets/169/split/",
                      "methods":  "PATCH"
                  }
              ]
}

In this provider, we have nameserverId but in API response I see a structure with DNS IP (nameservers).
Moreover I have a structure calculation with some network info.
For nameservers IP, the endpoint is tools/nameservers/{nameserverid}/ (you can find it in section 3.9 of phpipam doc).
I hope it helps and thank you for your project.
Bye

I have submitted a PR for the phpipam-go-sdk project to include this information: https://github.com/pavel-z1/phpipam-sdk-go/pull/5


[11.x] PDO modes on query builder

PDO modes
This PR adds the ability for developers to customize the underlying PDO mode for a query. Particularly, this is beneficial for certain queries like pluck() since they can be retrieved more efficiently using a specific PDO fetch mode.
The gist of this PR is the addition of the $query->mode() function which can be called with a set of predefined modes that changes PDO settings just before executing/fetching the $statement in the Connection class.
Features
Improved $query->pluck()
Faster $query->pluck() retrieval (see benchmarks below) by utilizing the PDO::FETCH_KEY_PAIR mode (now built into the pluck function). The end-result of the pluck function remains unchanged and the original pluck behavior has already been added to the tests in https://github.com/laravel/framework/pull/48657.
Additionally, raw DB statements can now be added for the $key parameter as well.
// Improved speed + simplification of query `pluck()` + ability to use raw expressions for both key and column:
User::query()->pluck('name', 'group');
User::query()->pluck(DB::raw('UPPER(name)', DB::raw('UPPER(group)'));

Added $query->mode(DB::mode()->keyed())
The "keyed" mode consumes the first column of the result and uses it as the key for the returned collection. It can be set using $query->mode(DB::mode()->keyed()) on a query builder. Rows with duplicate keys will overwrite the previous entry, just as the $collection->keyBy('...') function.
This provides a nice optimization (see benchmarks below) for cases where you previously would have called User::query()->get()->keyBy('...') (retrieving a query, after which the collection is looped and keyed using PHP). Now, the result is keyed as it comes back from PDO which saves a complete processing loop.
// New syntax to key a result instantly as it comes from PDO,
// without needing to call Collection `keyBy()`:
User::query()->mode(DB::mode()->keyed())->get(['group', 'users.*']);

Added $query->mode(DB::mode()->buffered(false))
The "buffered" mode changes the buffer setting (only applicable to MySQL) which may provide memory optimizations for processing large datasets using a cursor.
// (un)buffered mode (MySQL) for use with (very) big datasets in conjunction
// with cursors (unbuffered can reduce memory in these cases):
User::query()->mode(DB::mode()->buffered(false))->cursor();

Added $query->mode(DB::mode()->scrollableCursor($nth))
The "scrollableCursor" mode changes how the cursor runs and skips through the result set. For instance, providing the parameter $nth = 2 takes only every second result from the cursor. This functionality is only available on Postgres and MS SQL.
// Scrollable cursor mode (Postgres+MSSQL), which fetches every nth item lazily:
User::query()->mode(DB::mode()->scrollableCursor($nth))->cursor();

Notable changes

Created src/Illuminate/Database/PDO/Mode.php which has common PDO modes for the developer to use.
Created src/Illuminate/Database/PDO/Statement.php which is a wrapper around PDO Statement. (it is purposively not extended since that may introduce difficulties when providing support for different PHP versions).
Signatures changes in src/Illuminate/Database/ConnectionInterface.php namely the addition of the new $mode:

public function select($query, $bindings = [], $useReadPdo = true, Mode $mode = null);
public function cursor($query, $bindings = [], $useReadPdo = true, Mode $mode = null);

Changed src/Illuminate/Database/Query/Builder.php:

Removed protected function onceWithColumns() and used $this->clone() in those cases where it was used, to simplify and flattten the function.
Changed public function pluck() to use the new mode
Removed the protected functions stripTableForPluck(), pluckFromObjectColumn() and pluckFromArrayColumn() since those functions are no longer necessary for pluck(). The pluck result is now always returned as ['key' => 'value'] (no longer in object format), so no further parsing is needed.

Changed some tests to fix the select() function mock, since a new (optional) parameter was added which was no longer recognized by mockery (even though it is an optional parameter).

Benchmarks
Benchmark (gist) of 1000 iterations on various amounts of rows:

Operation (rows)
Branch (ms)
Master (ms)
Percentage Difference (%)

Pluck (10)
0.263409443
0.275019577
-4.400

Pluck (100)
0.288879615
0.304758434
-5.491

Pluck (1000)
0.552295596
0.64445222
-14.358

Pluck (10000)
2.981094529
4.101525242
-27.545

Keyed (10)
0.27759889
0.27788213
-0.102

Keyed (100)
0.3193552
0.346400055
-8.478

Keyed (1000)
0.658895505
0.882822845
-25.433

Keyed (10000)
4.333648892
6.390425972
-47.436

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


New Project/Theme Name?

I want to remove the word Bootstrap out of this project. Something closer to Universal Theme (UT), because I see this theme as being very versatile.

APEX Next
APEX Flex (I like this one because it refers to both Flexbility and Flexbox)
APEX Loop

Or maybe including the word "Theme", which would acronym closer to UT.

APEX Next Theme: short for APEX NT
APEX Flex Theme: short for APEX FT

Any idea is welcome.

Leaning toward APEX Flex Theme


[python_oop] remove no-execute tags in rst to allow for generated error output

remove no-execute tags in rst to allow for generated error output
Support for '.. code-block:: none' is incomplete in Jupinx #26

No longer required as jupinx can skip these blocks through sphinx-build flag.
https://github.com/QuantEcon/sphinxcontrib-jupyter/pull/129


Editor height shrinks upon click events in standalone mode

Steps to Reproduce

Install dependencies: create-react-app > npm install --save ketcher-react > npm install --save ketcher-standalone. The resulting package.json is the following:

{
  "name": "editor",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@testing-library/jest-dom": "^5.13.0",
    "@testing-library/react": "^11.2.7",
    "@testing-library/user-event": "^12.8.3",
    "antd": "^4.16.2",
    "ketcher-react": "^2.2.1",
    "ketcher-standalone": "^1.0.0",
    "react": "^16.13.1",
    "react-dom": "^16.13.1",
    "react-scripts": "4.0.3",
    "web-vitals": "^1.1.2"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

Render the Editor component in App.js. This step is essentially a copy pasta from the documentation. Note that I tried to render a non-full-size editor by placing it inside a fixed <Card /> container, as instructed in #415. But the result is the same if I try to render a full size editor.

import 'ketcher-react/dist/index.css'
import { StandaloneStructServiceProvider } from 'ketcher-standalone'
import { Editor } from 'ketcher-react'
import { Card } from 'antd';
const structServiceProvider = new StandaloneStructServiceProvider()

function App() {
  return (

      <Card style={{width: 700, height:500 }}>
        <Editor
          staticResourcesUrl={process.env.PUBLIC_URL}
          structServiceProvider={structServiceProvider}
        />
      </Card>

  );
}

export default App;

Click on the canvas, and the height shrinks.

Expected behavior
Height should be fixed upon user interaction
Actual behavior
Height decreases upon user interaction
Screenshots
Initial render:

After a few clicks on the canvas:

Desktop (please complete the following information):

OS: [e.g. iOS] Ubuntu 20.04
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22] 89

Smartphone (please complete the following information):

Device: [e.g. iPhone6] n/a
OS: [e.g. iOS8.1] n/a
Browser [e.g. stock browser, safari] n/a
Version [e.g. 22] n/a

Additional context
Trying to include this component as part of a dashboard, so I hope to be able to resize this component and keep its size fixed. If I downgrade ketcher-react to 2.1.0, the problem goes away (i.e height is fixed), but placing <Editor /> in a fixed parent container doesn't resize the component.

Dear @Theophylline ,
I have analyze your case and want to  inform you non-full-size works without any issues if you set fixed size of parent element. In your case antd lib adds some additional elements (please see screen below):

To fix this issue please wrap  with
.

Please inform me if this solution works for you.
Best regards,
Andrei

Nice this works, thank you!


Scan user's lib/icons directory for dynamic node's icon feature

Before you hit that Submit button....
Please read our contribution guidelines
before submitting a pull-request.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

If you want to raise a pull-request with a new feature, or a refactoring
of existing code, it may well get rejected if it hasn't been discussed on
the mailing list or
slack team first.
Proposed changes
This change enables it to scan icon files in {settings.userDir}/lib/icons directory for dynamic nodes's icon feature.
With this feature, a user can use his/her own icon files to change a node appearance.
Checklist
Put an x in the boxes that apply

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[x] I have added suitable unit tests to cover the new/changed functionality

Coverage decreased (-0.006%) to 86.586% when pulling 270a1dc27c1903c4dc306cf0f28085e5c10f47a1 on node-red-hitachi:0.18-iconlibrary into f737ea96f309f1e5f59fc94a5f2687fae3d5d806 on node-red:0.18.

Coverage decreased (-0.006%) to 86.586% when pulling 270a1dc27c1903c4dc306cf0f28085e5c10f47a1 on node-red-hitachi:0.18-iconlibrary into f737ea96f309f1e5f59fc94a5f2687fae3d5d806 on node-red:0.18.


Additional audio features

The current spatial envelope is very tight, I would think about 4 or 5m before it falls off completely? Decreasing the volume drops this distance even further. Would be great if this could be widened to cover a much larger area.  Especially useful for environmental sounds which needs to blend into each other from location to location.
Different play modes for the audio files. For instance, play once, loop forever or play N times (it's quite often useful that audio can be used multiple times, for instance a church bell. Only would require 1 sample and then some logic to play the hour of the day... 2 rings, 5 rings etc.
Shameless request:
A fade in (but not based on spatial location) would be an handy feature, but I'm not sure if that could be considered a API request since it's possible to do with your volume control and some logic. It's just such a common feature which would be nice to have available quickly. At the moment all sounds are played at the set volume immediately, I noticed it feels less jarring in VR when there is a slight fade up from nothing (like half a sec). Anyway, feel free to ignore this one!

Regarding the volume, I have been experimenting with it and I think perhaps it's decreasing the spatial envelope, instead of actually decreasing the sound volume? The reason I think this might be the case, is that if you were to spawn your avatar/user in the same exact space as the origin of the sound, increasing or decreasing the volume seem to have no effect. Only if you move away slightly from the audio source location, the volume change can be noticed.


[Existing API Name] : Demo Issue

Brief Description 🤓
Demo Issue
Provide reference!
Demo Issue
Select the open source program you are contributing to
hacktoberfest-23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @daccdacc🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gdsc to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gdsc

Hey @daccdacc ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Fix permission deny warrning if the fixture file has read-only permission

If the fixture file has read-only permission function fopen throw a warning because r+ mode is used

thanks @filevgenij
Even though the building is still running can you provide a test where the file is non writable and see if the behavior is still maintained?
Thank you agian!

As this has not been followed up, I think it is safe to say that the suggested behaviour is not been subject to popular demand. Therefore, I'm closing this PR.


make "freeze_version" freeze them in the "super-dataset" instead of the ReproNim/containers

as we realized/documented while going through https://github.com/ReproNim/containers#walkthrough with @asmacdo recently, freeze_versions modifies this repository/dataset locally and thus require resharing for that modification.  That is inconvenient.
Instead, in cases where used YODA way, thus being embedded into super-dataset for results, I think we can "freeze" via copying that container definition into super-dataset and just adjusting the path to the versioned image to reside in the sub-dataset!  Then users can easily upgrade containers subdataset, while still using the container of the original version since that is what they have in superdataset.
Instead of freeze_version I guess we could formalize it as a new helper, e.g. use_container. It would imply use in superdataset, but I don't want to make the name too verbose/long.

ha -- script already has an option --save-dataset= which is barely used to provide dataset path for datalad save which seems to be a bit detached from the rest of the logic.  I will RF so whenever we point with that option to some other dataset above -- that is where to we copy the invocation section while adjusting the paths etc.

I still like it, using that should be part of the standard workflow.
maybe s/freeze/install/. ?

I thought about install but disliked it since it doesn't really copy the container image, just merely "registers" it in .datalad/config file.

why not also copy the container?
maybe the containers dataset should only be what they use, rather than all
ReproNim containers.
On Fri, Mar 3, 2023, 3:57 PM Yaroslav Halchenko @.***>
wrote:

I thought about install but disliked it since it doesn't really copy the
container image, just merely "registers" it in .datalad/config file.
—
Reply to this email directly, view it on GitHub
https://github.com/ReproNim/containers/issues/86#issuecomment-1454120182,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH3EMIPGKIF6XBCQVVQTBLW2JLNHANCNFSM6AAAAAAVPAGJNM
.
You are receiving this because you were mentioned.Message ID:
@.***>

why not also copy the container?

well, in principle indeed could have a command for a full copy of the container, which would need to use datalad copy-file.
pros:

only container(s) used are contained
no need to install heavier ReproNim/containers

cons:

would need copy also of the shim script and ensuring the possibly needed similar setup for isolated HOME, licenses/ etc.  Sounds like a burden not worth taking
if container image availability information updated in ReproNim/containers -- it will not be anyhow sync'ed back to the superdataset
if shim is copied, then also would need to be similarishly copied on upgrades

overall -- feasible but probably not worth pursuing because of the cons ATM

maybe the containers dataset should only be what they use, rather than all ReproNim containers.

we do not restrict people to create their own container datasets.  people could even trim this dataset with git rm to what they want ... the point is that they can use this one and get benefits (big collection at fingertips, shim to ensure various aspects, later metadata to discover).

It was addressed by #88


fix(#128 #124 #153): form item design fixes and notification buttons

Closes #128 (Form Item error styling)
Closes #124 (Notification component styling)
Closes #153 (Toggle Inline form item)
See tickets for Images and more info on changes.

@ycliu0953 @theurbanspectacle can you review?


[DMC5] Ultrawide fix in-game UI issue

While the ultrawide fix is working properly for removing the black bars on the side, it scales UI alongside it, making your HP bar invisible, as it's beyond the screen region.
Would it be possible to force UI elements to move only on horizontal axis and prevent them moving in vertical axis?
If it's just a camera-zoom-esque fix, I understand that it's pretty much not possible.

Whilst not the perfect fix for this, I've found a workaround in the mean time.

In-game, set your resolution to be the NON-UW equivalent of your resolution, i.e 3440x1440 users set it to 2560x1440(Would also recommend increasing your "Render Scaling" to something like 120%+
Set your game to "Fullscreen" mode
Press the "Insert" button(REFramework default key)
Go to "Graphics" and toggle "Ultrawide/Aspect Ratio Fix" and "Ultrawide: Override FOV"
Set FOV value to something like 1.4/15(1.4 looked perfect to me)
Profit (Note that things like screen recorders or Steams screenshot thingy will record in the 16:9 res and not the 21:9 res)

Whilst not the perfect fix for this, I've found a workaround in the mean time.

In-game, set your resolution to be the NON-UW equivalent of your resolution, i.e 3440x1440 users set it to 2560x1440(Would also recommend increasing your "Render Scaling" to something like 120%+
Set your game to "Fullscreen" mode
Press the "Insert" button(REFramework default key)
Go to "Graphics" and toggle "Ultrawide/Aspect Ratio Fix" and "Ultrawide: Override FOV"
Set FOV value to something like 1.4/15(1.4 looked perfect to me)
Profit (Note that things like screen recorders or Steams screenshot thingy will record in the 16:9 res and not the 21:9 res)

Thanks, I didn't think about that. I'll try that asap

For me the resolution doesn't actually change when trying this. So far no combination of settings scales the GUI properly when the resolution is actually correct, but I'm also on a 32:9 aspect ratio if that's a problem?


Shopping billing website

Describe the project you want to add with tech stack
Make a website where the name of the item purchased and its price can be entered. Hence calculating the total amount.
Expected behavior
The result page will how the total amount and redirected a thank you page
Screenshots (optional)

Additional context (optional )

@pranjay-poddar please assign me this issue


The Load balancer can't schedule the last invoker when exist more than one invokers

After installed multiple invokers, access http://controller:10001/invokers, all the invoker's status is up, but when execute wsk -i action invoke --result <action> multiple times, the last invoker can't be scheduled by controller's loadbalancer to deal the action request.
I do several tests as below(in centos7, memory:16G, cpu:8 physical cpu total, 8 logic cores total)

test case one: only deploy two invokers
status for invokers: {"invoker0":"up","invoker1":"up"}
only invoker0 deals the request,  invoker1 seems don't recevie the request

test case one: deploy three invokers
status for invokers: {"invoker0":"up","invoker1":"up", "invoker2":"up"}
only invoker0 and invoker1 deal the request, invoker2 don't recevie the request.

test case one: deploy four invokers
status for invokers: {"invoker0":"up","invoker1":"up", "invoker2":"up","invoker3":"up"}
only invoker0 and invoker1  and invoker2 deal the request, invoker3 don't recevie the request.

test case one: deploy five invokers
status for invokers: {"invoker0":"up","invoker1":"up", "invoker2":"up","invoker3":"up","invoker4":"up"}
only invoker0 and invoker1  and invoker2 and invoker3 deal the request, invoker4 don't recevie the request.

So my test conclusion is that: since all invokers's status is ok, may be there has some bug on controller's load balancer‘s scheduling strategy, it leads to the last invoker can't be sheduled by load balancer to deal the action request

The last invoker is per default only used for blackbox actions. The fraction of invokers used for blackbox invocations is configurable but it's always at least one invoker (today). Arguably, we can adjust that logic to be disablable.

What's mean for  The blackbox actions, i do not know what role he has.
Where the configuration for the fraction of invokers?
regarding Arguably, we can adjust that logic to be disablable., you mean remove the blackbox actions used the last invoker logic?

Blackbox actions are actions based on user-provided docker images. Configuration is per environment variable and the code you posted.
We can adjust that logic, so you can completely disable that blackbox actions get their own invokers and are rather shared with all the other invokers.

This is working as designed.

Does the change to make any invoker pick up blackbox image require changes in source to "ShardingContainerPoolBalancer.scala" or is this configurable in the env variable somewhere?

@hsane2001 this PR https://github.com/apache/incubator-openwhisk/pull/3751 makes it possible to use all the invokers (for small N). Otherwise we don't have a way to disable the blackbox isolation when your N is high enougn (10 invokers for a 10% fraction).


fix #1446: monitor dies when exceptions raised before monitor created.

Summary

Fix the problem of monitor dies if an exception raised during reconnect before monitor created.
Add a unit test test_interactions_with_disconnection for Slack server side request to disconnect.

Category (place an x in each of the [ ])

[ ] slack_sdk.web.WebClient (sync/async) (Web API client)
[ ] slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
[x] slack_sdk.socket_mode (Socket Mode client)
[ ] slack_sdk.signature (Request Signature Verifier)
[ ] slack_sdk.oauth (OAuth Flow Utilities)
[ ] slack_sdk.models (UI component builders)
[ ] slack_sdk.scim (SCIM API client)
[ ] slack_sdk.audit_logs (Audit Logs API client)
[ ] slack_sdk.rtm_v2 (RTM client)
[ ] /docs-src (Documents, have you run ./scripts/docs.sh?)
[ ] /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
[ ] /tutorial (PythOnBoardingBot tutorial)
[x] tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Fix the problem of monitor dies if an exception raised during reconnect before monitor created.
Add a unit test test_interactions_with_disconnection for Slack server side request to disconnect.

To test server side disconnect and reconnect, the unit test will call client.issue_new_wss_url(), so I had to modify the mocked web server and related tests to return a URL that is able to be used.
This test only able to test is disconnect and reconnect working fine so both the fixed version and the old version can pass it. It's hard to mock the behavior of the exception I mentioned in #1446 and I didn't find a good way... As a result, I did some patch to the client (locally) and run the test (also locally). Only the fixed version can pass the test with patched client. The patch is here: https://github.com/woolen-sheep/python-slack-sdk/pull/1

cc @hello-ashleyintech , please kindly review this and do necessary tests if you want.

Thank you so much for taking the time to send this PR. I am (and will be for a while) out of the office now, but will check the changes within a few business days.


Error: V plot index is missing

Hi there,
I'm receiving an error:
00:00:00.283	Error (/bds_atac/atac.bds, line 211, pos 26): V plot index is missing ( '-tss_enrich' )!
I suppose its at the QC step - would it be possible for someone to perhaps suggest how to provide this? Thank you!

Hi,
Which genome are you using? We currently have files for hg19 and mm9 but we plan to add support for other genomes (and genome builds) soon.
The relevant files can be downloaded using the instructions listed here:
https://github.com/kundajelab/bds_atac#genome-data
You may wish to modify the parts of the script that build the bowtie index if you already have one.
Let us know if you have any further issues.
Thanks!

For mm10 and hg38, genome data for ATAQC are currently not avaiable.
I have changed that error to a warning. c1c89d0b85a91f48e6f4ad980ba1ec076ea6ec5f
If genome data is missing for ATAQC, then the pipeline will disable ATAQC.

Hi, it was mm9.
I ended up re-loading genome files - appears it fixed the error. Thank you!


Investigate Performance Hit following 0.7.0 release

From Adhara:
I ran performance tests against EthSigner this morning and noticed a severe decline. Performance went down from 100 tx/s to 30 tx/s. When I roll back to a previous version, before commit 68f8676 (version 0.7.0), the performance is still as before. There has been a lot of changes and upgrades since then and I thought it worth asking if you maybe have an idea what could cause this before I try to find the problem myself?

I used an AT to do some tests and saw:
I just ran a few tests - and I saw (avg over 1000 txns):
2eb9aa5b = 15ms/txn (60/sec)
eb1c6ec4 = 50ms/txn (20/sec)
HOWEVER - eb1c uses a dockerised Besu, rather than "native" - so that MAY impact speed?

From Marelize @ Adhara:
Back to 1 tx/s :disappointed: Looking up private or public parts of key pairs via the AWS CloudHSM JCE Provider has always been REALLY slow. This is due to a more general problem with JCE providers in the sense that they were never really designed for the purpose of many key look-ups but rather 1 key look-up and then many cryptographic operations. We got around this previously by caching the private key handles (minimising key look-ups) and got usable results. We will have to cache the public key handles also (after the refactor) for it to be usable again. For comparison, native PKCS11 (with no caching) yields around 50 tx/s using AWS CloudHSM.
So, I am fairly certain that the problem in performance is the extra public key management that was added. For keystore files, I think you are decrypting the file twice, once to get the public key and once to produce a signature. For actual hardware (and SoftHSM) the decline is due to having to do two look-ups as well after the refactor. The impact is not so great (but still significant) cause for that we are using native PKCS11. (edited)


electron-packager produces '.app' (macOS) executable in Debian 10.

ran commands as per .README and electron-packager produced Reactide-Darwin-x64 directory containing Reactide.app which isn't executable on linux (to my understanding).
are there arguments i can pass electron-packager to explicitly ask to compile for linux?

resolved by editing "electron-packager" script in package.json, changing argument '--platform=darwin' to '--platform=linux'


Error: Cannot find transform for node Node<"heading">

"heading" is not recognized:

"isHeading" function isn't checking the node type "heading":

Hello. Thanks for your feedback!
Every transform in slate-to-react matches the type type against corresponding html tag, so in order for it to work, your node must have the h<level> type. Because Slate does not enforce any specific schema rules, other than children field for elements and text for leaves, I simply cannot cover every possible scenario for matchers. This is what createElementTransform, createLeafTransform, createElementNodeMatcher and createLeafNodeMatcher are for, so you can bring your own components to render Slate nodes the way that fits your own needs.
This is how you can create your custom element element matcher & transform:
import {createElement} from "react"
import {createElementNodeMatcher} from "slate-to-react"

export interface Heading {
  type: "heading"
  level: 1 | 2 | 3 | 4 | 5 | 6
  children: InlineDescendant[] // This would be your own type
}

export const isHeading = createElementNodeMatcher<Heading>((node): node is Heading => (
  node.type === "heading"
    && typeof node.level === "number"
    && node.level >= 1
    && node.level <= 6
))

export const HeadingElement = createElementTransform(
  isHeading,

  ({key, attributes, element, children}) => createElement(
    element.level,

    {
      ...attributes,

      key
    }
  )
)

I also recommend disabling all default transforms so you can see where you need to add custom elements by setting the defaultTransforms option to false. See: https://github.com/octet-stream/slate-to-react#type-transformnodesoptions
To be clear, this is the convention taken from Plate's schema – they typically place tag names in the type field and this is why I made it in my package by default.

@octet-stream Thank you for the quick response! :)

I'm closing this. Hope your issue is resolved. Feel free to reopen if not.


Fix Flipper integration on iOS and update it

Summary

The integration of Flipper on iOS was crashing the template, and test_ios_e2e were failing because of it.
Flipper integration must be wrapped inside FB_SONARKIT_ENABLED.
Flipper's issues with Yoga and YogaKit were solved in Flipper 0.28.0, so let's update our integration to it, and we'll need to use Swift.
We will be able to ship this in 0.62 (cc @grabbou, @axe-fb, @priteshrnandgaonkar), and it should fix test_ios_e2e (cc @hramos) 🤞 .
Changelog

[iOS] [Fixed] - Fix Flipper integration on and update Flipper to 0.30.0
Test Plan

Initialized an app with my branch as source.
Added [AppDelegate initializeFlipper:application]; to didFinishLaunchingWithOptions.
Launched Flipper.
Ran the app (debug).

Ran the app (release).
Everything succeeds, no Flipper connection available in release.

Thanks for working on this. I have imported this, and should be able to land this soon.

Should we separate the version update into a separate PR, just to keep this things clean ?

I'm not sure if it will work fine with the original Flipper version as I'm on Xcode 10. 😬

Thats find them. Just imported it, once it is  reviewed, we can land it.

why Swift.swift file?

Flipper requires Swift compiler for YogaKit, and maybe Yoga too as we're using modular header. In order to get it compiled correctly, we need to have at least one Swift file in our project.
Maybe there's a way without this additional Swift file, but I didn't succeed, even with ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES.

👋 Thanks for the fixes - Just a few quick questions related to this:

How will the now included Swift standard libraries impact binary size (if at all)?
If the Swift file is removed from an app project (that does not use Flipper), is the compiler smart enough to also exclude the Swift standard libraries, or are additional settings required?
SWIFT_VERSION = 5.0 and SWIFT_OPTIMIZATION_LEVEL = "-Onone" - Are these the defaults? Can it safely be set to something else?
Swift.swift is the first and only Swift file in the entire react-native repository (almost 4000 files) - And it sounds like the only reason it's there is to "trick" the compiler. Are there any other potential solutions that achieve the same without the dummy file and embedding the Swift standard libraries?

Sorry for all the questions - Swift newbie here 😇

I have same questions too 😇

@charpeni @axe-fb - I know there has already been some discussion on Discord, but to close the loop it would be great if you could post a quick reply here too.

ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES might add 5mb to an app size

@friederbluemle never be sorry for asking questions!

How will the now included Swift standard libraries impact binary size (if at all)?

@dulmandakh is right. We depend on YogaKit, which includes YGLayoutExtensions.swift, and then there's not much we can do for the binary size with Swift, I'm afraid.
But, since Flipper is only running in Debug, we should be able to set ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES to NO in Release. I'll have a look at this.

If the Swift file is removed from an app project (that does not use Flipper), is the compiler smart enough also to exclude the Swift standard libraries, or are additional settings required?

Yes, Xcode is smart enough the change all settings related to this. The same thing applies when you add a swift file to a project. I wasn't able to keep that configuration, because the moment I removed the Swift file, Xcode removed everything related to Swift, even if we still have Swift pods. The template folder is not the most pleasant way to deal with that, I'll retry with a sample app and compare the diff with git, it may be more helpful. 😄

SWIFT_VERSION = 5.0 and SWIFT_OPTIMIZATION_LEVEL = "-Onone" - Are these the defaults? Can it safely be set to something else?

Yes, it can be safely set to something else. This Podfile script will set the SWIFT_VERSION for YogaKit to 4.1 anyway, but I wouldn't go lower than that.
https://github.com/facebook/react-native/blob/438891f35577a7cf3d82e4a10af3f9b000264a33/template/ios/Podfile#L16-L22

Swift.swift is the first and only Swift file in the entire react-native repository (almost 4000 files) - And it sounds like the only reason it's there is to "trick" the compiler. Are there any other potential solutions that achieve the same without the dummy file and embedding the Swift standard libraries?

Well, some say the only reason I did that was to introduce a Swift file into a Facebook repo silently. But this is not completely true.

it sounds like the only reason it's there is to "trick" the compiler.

Exactly, I wasn't able to keep a Swift compiler, or in that case, standard libraries without a Swift file. Weird, right? I can't believe this is not possible, because having a placeholder Swift file seems really odd to me. I didn't look more than a few minutes into that as the goal was to start testing Flipper with React Native and fix tests. As I said earlier, I'll retry that, and use git to compare changes in the project with and without a Swift file. That way, we may be able to trick the compiler without a Swift file.
Thanks for raising those concerns, I'll have a closer look to make sure we release something enjoyable in RN 0.62.
I hope this answers your questions, feel free to reach out again. Otherwise, I'll let you know or cc you into upcoming pull requests.

@charpeni have you looked into "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES to NO in Release"? Seems like that would smooth over the app size increase. As for upgrades, how would that flag impact people who already use swift?


contact catalog item owner from dropdown

Feature Suggestion
A little widget that can be a drop in replacement of the owner field in the catalog table list view that instead of linking to the group/user, renders a drop down offering options such as: email, slack, discord links as well as bringing them to their profile if they prefer.
Possible Implementation
I would imagine that the dropdown list would be driven by annotations (e.g. slack or discord links) on the user or group entity as well as profile info such as email.
Context
The idea is that users would be able to more quickly contact owners of components from different parts of the backstage application without having to drill in with a few clicks.

Do you want to try and mock something like this up? :pray: Sounds pretty interesting!

If I understand the idea right, the outcome basically is one less click. Well - same number of clicks, but not having to go to the user's page to find a card that has the same action items on it.
Bear in mind that at the time that the link is rendered, we usually don't have all of the user data present, so we'd have to load the entity asynchronously from the catalog based on the ref, to know what items to show. I'd really want the click on the ref itself to not have its behaviour change at all, so if there were to be a dropdown like this it'd probably have to hang off of some little chevron icon to the right of the user, or be shown in a popover on hover. This also lets us defer the catalog query so we don't have to do that eagerly all the time for every single link that's rendered.
I gotta say I like the idea as such. It makes for a neat interface feature to be able to hover over entity ref links and seeing a popover card (almost like a tooltip) with some peek info. It could be extra useful in result tables, to be able to quickly hover over entries one by one to see some more details about them that isn't rendered in the table itself. Like the description, which is kinda nice to NOT have a column for because it eats so much screen real estate.
It could actually be a pretty rich little card. It could show the ref, title and description standard fields. For users and groups it could show the avatar image and other profile data. It could indeed have action items for stuff like sending an email to the person etc.
All of the above would be builtin behaviors though. Circling back to your actual issue, what you may want in the end is to make this a tweakable card that can render MORE contact details and custom things as well. But maybe it would be a good start to just make it "good enough" for starters, supporting some well known annotations / profile fields. Then eventually, we might be able to put that card into createApp({ components: { EntityPeekCard: ... } })
Would you like to whip something up to this effect? 🙏

Commenting to keep this issue alive since I think it's a neat idea :smile:

Does something like this look like a good start:

I created a pull request to look something like that.


URGENT: Unable to Upgrade Server Certificate, Expiration Date Closing In

We have a very simple 5 node, x509 secured cluster that we are trying to upgrade the server certificate on. We have tried the following things:
Add ThumbprintSecondary to the configuration with the new certificate thumbprint.
The updated cluster configuration in this circumstance looks like the following:
{
  "Properties": {
    "GoalStateExpirationReminderInDays": 0,
    "Security": {
      "$id": "1",
      "CertificateInformation": {
        "$id": "2",
        "ClusterCertificate": {
          "Thumbprint": "69 4B 3E F7 9F 56 1C DD 0C 15 F9 63 57 4F 55 BC F0 C6 32 AC",
          "X509StoreName": "My"
        },
        "ServerCertificate": {
          "Thumbprint": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A",
          "ThumbprintSecondary": "69 4B 3E F7 9F 56 1C DD 0C 15 F9 63 57 4F 55 BC F0 C6 32 AC",
          "X509StoreName": "My"
        },
        "ReverseProxyCertificate": {
          "Thumbprint": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A",
          "X509StoreName": "My"
        },
        "ClientCertificateThumbprints": [
          {
            "IsAdmin": true,
            "CertificateThumbprint": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A"
          }
        ]
      },
      "ClusterCredentialType": "X509",
      "ServerCredentialType": "X509"
    },
    "NodeTypes": [
      {
        "Name": "NodeType0",
        "ClientConnectionEndpointPort": 19000,
        "HttpGatewayEndpointPort": 19080,
        "ReverseProxyEndpointPort": 19081,
        "LeaseDriverEndpointPort": 19002,
        "ClusterConnectionEndpointPort": 19001,
        "ServiceConnectionEndpointPort": 19003,
        "ApplicationPorts": {
          "StartPort": 20001,
          "EndPort": 22024
        },
        "EphemeralPorts": {
          "StartPort": 49152,
          "EndPort": 65535
        },
        "IsPrimary": true
      }
    ],
    "AddonFeatures": [
      "BackupRestoreService"
    ],
    "FabricSettings": [
      {
        "Name": "Setup",
        "Parameters": [
          {
            "Name": "FabricDataRoot",
            "Value": "C:\\ProgramData\\SF"
          },
          {
            "Name": "FabricLogRoot",
            "Value": "C:\\ProgramData\\SF\\Log"
          }
        ]
      },
      {
        "Name": "BackupRestoreService",
        "Parameters": [
          {
            "Name": "SecretEncryptionCertThumbprint",
            "Value": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A"
          }
        ]
      }
    ],
    "EnableTelemetry": true,
    "DiagnosticsStore": {
      "StoreType": "FileShare",
      "DataDeletionAgeInDays": 21,
      "Connectionstring": "C:\\ProgramData\\SF\\DiagnosticsStore",
      "IsEncrypted": false
    },
    "FabricClusterAutoupgradeEnabled": true
  },
  "Nodes": [
    {
      "NodeName": "Node_5",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE6",
      "FaultDomain": "fd:/dc1/r5",
      "UpgradeDomain": "UD5"
    },
    {
      "NodeName": "Node_3",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE4",
      "FaultDomain": "fd:/dc1/r3",
      "UpgradeDomain": "UD3"
    },
    {
      "NodeName": "Node_2",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE3",
      "FaultDomain": "fd:/dc1/r2",
      "UpgradeDomain": "UD2"
    },
    {
      "NodeName": "Node_1",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE2",
      "FaultDomain": "fd:/dc1/r1",
      "UpgradeDomain": "UD1"
    },
    {
      "NodeName": "Node_0",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE1",
      "FaultDomain": "fd:/dc1/r0",
      "UpgradeDomain": "UD0"
    }
  ],
  "ApiVersion": "06-2018",
  "Name": "dev",
  "ClusterConfigurationVersion": "7.0.0"
}

Replace Thumbprint outright with the new certificate thumbprint.
{
  "Properties": {
    "GoalStateExpirationReminderInDays": 0,
    "Security": {
      "$id": "1",
      "CertificateInformation": {
        "$id": "2",
        "ClusterCertificate": {
          "Thumbprint": "69 4B 3E F7 9F 56 1C DD 0C 15 F9 63 57 4F 55 BC F0 C6 32 AC",
          "X509StoreName": "My"
        },
        "ServerCertificate": {
          "Thumbprint": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A",
          "ThumbprintSecondary": "69 4B 3E F7 9F 56 1C DD 0C 15 F9 63 57 4F 55 BC F0 C6 32 AC",
          "X509StoreName": "My"
        },
        "ReverseProxyCertificate": {
          "Thumbprint": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A",
          "X509StoreName": "My"
        },
        "ClientCertificateThumbprints": [
          {
            "IsAdmin": true,
            "CertificateThumbprint": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A"
          }
        ]
      },
      "ClusterCredentialType": "X509",
      "ServerCredentialType": "X509"
    },
    "NodeTypes": [
      {
        "Name": "NodeType0",
        "ClientConnectionEndpointPort": 19000,
        "HttpGatewayEndpointPort": 19080,
        "ReverseProxyEndpointPort": 19081,
        "LeaseDriverEndpointPort": 19002,
        "ClusterConnectionEndpointPort": 19001,
        "ServiceConnectionEndpointPort": 19003,
        "ApplicationPorts": {
          "StartPort": 20001,
          "EndPort": 22024
        },
        "EphemeralPorts": {
          "StartPort": 49152,
          "EndPort": 65535
        },
        "IsPrimary": true
      }
    ],
    "AddonFeatures": [
      "BackupRestoreService"
    ],
    "FabricSettings": [
      {
        "Name": "Setup",
        "Parameters": [
          {
            "Name": "FabricDataRoot",
            "Value": "C:\\ProgramData\\SF"
          },
          {
            "Name": "FabricLogRoot",
            "Value": "C:\\ProgramData\\SF\\Log"
          }
        ]
      },
      {
        "Name": "BackupRestoreService",
        "Parameters": [
          {
            "Name": "SecretEncryptionCertThumbprint",
            "Value": "FB 11 E3 73 BF 4E 10 41 E6 9B 24 AB 12 1C 49 76 5C 40 5D 8A"
          }
        ]
      }
    ],
    "EnableTelemetry": true,
    "DiagnosticsStore": {
      "StoreType": "FileShare",
      "DataDeletionAgeInDays": 21,
      "Connectionstring": "C:\\ProgramData\\SF\\DiagnosticsStore",
      "IsEncrypted": false
    },
    "FabricClusterAutoupgradeEnabled": true
  },
  "Nodes": [
    {
      "NodeName": "Node_5",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE6",
      "FaultDomain": "fd:/dc1/r5",
      "UpgradeDomain": "UD5"
    },
    {
      "NodeName": "Node_3",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE4",
      "FaultDomain": "fd:/dc1/r3",
      "UpgradeDomain": "UD3"
    },
    {
      "NodeName": "Node_2",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE3",
      "FaultDomain": "fd:/dc1/r2",
      "UpgradeDomain": "UD2"
    },
    {
      "NodeName": "Node_1",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE2",
      "FaultDomain": "fd:/dc1/r1",
      "UpgradeDomain": "UD1"
    },
    {
      "NodeName": "Node_0",
      "NodeTypeRef": "NodeType0",
      "IPAddress": "SFNODE1",
      "FaultDomain": "fd:/dc1/r0",
      "UpgradeDomain": "UD0"
    }
  ],
  "ApiVersion": "06-2018",
  "Name": "dev",
  "ClusterConfigurationVersion": "7.0.0"
}

Errors
The resulting errors during the upgrade are non-deterministic, but always revolve around an FABRIC_E_SERVER_AUTHENTICATION_FAILED error occurring on a random node during the upgrade process. For example:
'System.Hosting' reported Error for property 'FabricDownload:7.0.464.9590:22'.
There was an error during download. Failed to download 'WindowsFabricStore\ClusterManifest.22.xml' from ImageStore. Error 'FABRIC_E_SERVER_AUTHENTICATION_FAILED'. Check if the file or folder is present in ImageStore by using 'Get-ServiceFabricImageStoreContent -RemoteRelativePath WindowsFabricStore\ClusterManifest.22.xml'.

Answers to Obvious Questions

Yes, the certificate in question is installed on all of the nodes, in all of the recommended stores, and NETWORK SERVICE has access to the certificate.
Yes, I've tried adding fresh nodes and removing nodes exhibiting the error. The error still persists on new, cleanly created nodes.
Yes, we've already performed the certificate rollover on the ClusterCertificate with no problems.
Yes, if we run Get-ServiceFabricImageStoreContent -RemoteRelativePath WindowsFabricStore\ClusterManifest.22.xml on the node exhibiting the error, it runs successfully.

In Conclusion
We are effectively hosed unless a workaround or fix is provided this issue. The server certificate, at this moment in time, is impossible to upgrade. We would greatly appreciate any insight into this issue.

Hi,
Im facing the same issue, Can you please tell me how you fixed it.

No the issue is they are not able to download the image store file, with in the given timeout you have manually copy the files from one machine to other fixed the issue, Since I was doing it on production i didn't tried to explore much maybe I'll create dedicated R&D environment to know more about this issue ®

As it turns out there is a bug in Service Fabric related to rolling over certificates using thumbprints. While the MS support ticket is now closed (as they assisted us in finding a workaround for our specific situation), as far as I know the bug still exists and will hopefully be patched in the future. We are staying in contact with them around this issue since thumbprints are common in small, private deployment scenarios.
The workaround was quite obscure, and I'd recommend opening a ticket with MS if you need similar production support. I'll be sure to update this thread if they ever patch the issue.

@JustinKaffenberger which bug are you referring to, do you happen to have a GH issue number, or at an internal reference (bug description, contact info etc.)
I diffed your before/after configurations and they are identical. From your description, you attempted to replace in place the thumbprint of a certificate, which is not supported/won't work. Deploying a configuration upgrade creates a partitioning of the cluster - nodes in upgraded domains will use the new settings, whereas un-upgraded nodes are on the initial/starting settings. When the changes in question are security settings, this reflects directly on to the mutual authentication of nodes and can cause loss of availability. For that reason, certificate changes are always orchestrated in 2 steps - in your case, to add a secondary thumbprint.
Certificate-based authentication in SF clusters is described here; there is a section dedicated to rotation of certs declared by thumbprint.
Note there may be, indeed, a bug - I'd still like to get more details, if you can share. If you'd rather not do so on a public forum, please email me directly - dragosav at microsoft etc.

@dragav yes we followed all of the docs at first, any other strange attempts were made by us out of desperation. We had a week long troubleshooting session with Microsoft Support in which we ended up at the conclusion that there was a bug. Would it be helpful if I gave you the ticket number or our support contact?
The other reason we landed on this 'bug' conclusion was that we were able to reproduce the issue on all of our clusters running on the latest SF runtime, however we had one cluster which was behind a few versions, and that cluster was able to upgrade via thumbprint rotation successfully.

@dragav This is the final mitigation comments provided by Microsoft Support:

XXX cluster - 7.0.466 - Mitigated

generate the secondary cert using this powershell script - C:\Program Files\Microsoft SDKs\Service > Fabric\ClusterSetup\Secure\CertSetup.ps1
add the sec cert into the nodes using the below query(Install-ClusterCertificate).
add the secondary cert to all section like server, cluster and client using below commands.
But upgrade failed but this time they captured the error(refer below).
Get-ServiceFabricClusterConfiguration > NewClusterConfig.json
Start-ServiceFabricClusterConfigurationUpgrade -ClusterConfigPath NewClusterConfig.json

'System.Hosting' reported Error for property 'FabricDownload:7.0.466.9590:1'.
There was an error during download. Failed to download 'WindowsFabricStore\ClusterManifest.1.xml' from ImageStore. Error > 'FABRIC_E_SERVER_AUTHENTICATION_FAILED'. Check if the file or folder is present in ImageStore by using 'Get-> ServiceFabricImageStoreContent -RemoteRelativePath WindowsFabricStore\ClusterManifest.1.xml'.

Current Scenario: Cluster got stuck in upgrading status after adding new secondary cert over cluster config json file.  Once we > got into the situation. We should follow the below mitigation for now.
Cause: This is a bug.
Mitigation: Delete the new cert from all nodes. Once we deleted, upgrade will resume i believe and eventually it will be > succeeded and we can install new cert on all nodes.
Mitigation was successful.
Resolution: It looks like an bug on cluster manifest XML generation code from standalone configuration file json.

In case the team isn't aware, this msftbot is marking things as 'status-olderthan1year' that are not older than one year.

Hi @JustinKaffenberger, this matches a bug in certificate rotations in service fabric standalone clusters. This bug was identified and is fixed in 7.2. RTO. Unfortunately it doesn't look like the fix is captured in the Rel Notes. I will try to get this publicly noted. After upgrading to 7.2., cert rotations by thumbprint should smooth out. Please let us know if you are still having issues or need guidance for a cluster which cannot come onto 7.2. before rotation. Thanks

@amenarde thanks for the reply! We have since moved to CommonName based cert configuration but thumbprint-based is still really nice to have for edge (sometimes even offline altogether) deployments. I will be sure to try it out the next time I get a chance. Closing this for now.


need to stop autocorrect function when the date is invalid

Is your feature request related to a problem? Please describe.
We need input date manually and allow the invalid date displaying(we will give validation message but not autocorrect)
Describe the solution you'd like
Provide a property to control autocorrect function.
Describe alternatives you've considered
Additional context

1 on this. So far soulution is to disable it with
onChangeRaw={e => e.preventDefault()}
But then you cant insert your own custom validation if that event is disabled

1 on this. So far soulution is to disable it with
onChangeRaw={e => e.preventDefault()}
But then you can't insert your own custom validation for invalid input if that event is disabled

Yes, the trouble is that we need to input manually.

Workaround that could help is to do custom validation onChangeRaw, and add another check for invalid date onBlur, and if so it will reset field and show error. Pseudo code:
   <DatePicker                 onChange={onChange}                 onBlur={(event) => customBlur(event, onChange)}                 onChangeRaw={(event) => {                   customValidation(event);                 }}                 dateFormat={format}                 placeholderText={placeholder}                 className="form-control"               />

Workaround that could help is to do custom validation onChangeRaw, and add another check for invalid date onBlur, and if so it will reset field and show error. Pseudo code:
 <DatePicker onChange={onChange} onBlur={(event) => customBlur(event, onChange)} onChangeRaw={(event) => { customValidation(event); }} dateFormat={format} placeholderText={placeholder} className="form-control" />

But we should stop the autocorrect function, because the autocorrent date is not the one that the user wanted.

Yes, but there is no way to stop it. Instead i let it happen
and immediately after reset field to empty and show error that invalid date
is entered.
On Wed, Mar 3, 2021, 09:45 alan-anchen<EMAIL_ADDRESS>wrote:

Workaround that could help is to do custom validation onChangeRaw, and add
another check for invalid date onBlur, and if so it will reset field and
show error. Pseudo code:
<DatePicker onChange={onChange} onBlur={(event) => customBlur(event,
onChange)} onChangeRaw={(event) => { customValidation(event); }}
dateFormat={format} placeholderText={placeholder} className="form-control"
/>
But we should stop the autocorrect function, because the autocorrent date
is not the one that the user wanted.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Hacker0x01/react-datepicker/issues/2756#issuecomment-789544760,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHZS6WL4GOTYSYJRMJUMBWLTBXZLPANCNFSM4X77HKVQ
.

This just is the trouble.

Hi,
I solved this problem using customInput property.
I created my own custom component as a Datepicker wrapper. In it I used a simple button as customInput. Doing so, I could open calendar just clicking on that button (in my case i used a button styled with a font awesome calendar icon).
Furthermore i created an input type="text" to manage date text.

Set as "selected" the date you saved in your internal state and set as "onChange" a function that changes that state based on what date you selected in your calendar.
This will allow you to manage data selection and to set text into a input type="text".
Almost done! To let user type in the input type="text" and to let datepicker know you changed the date, you need to manage the onChange event of the input type="text".
In this function, you need to check text validity (if it's a valid date or not) and then set your date as internal state (the same state set as "selected" property).
Pseudo code to help you understand better:
`
const DatepickerWrapper = () => {
// save date state
const [date, setDate] = useState();
const renderInputText = () => {
// render your input type text
return
}
function onChangeText(text) {
// check if text set in input type text is a valid date
if(isValidDate) {
setDate(new Date(text));
}
}
const renderCustomInput= (props, ref) => (
// render button with calendar icon
// do not forget this ref or calendar won't open. Check customInput section in documentation

   // render button with icon

}
// do not forget this forwardRef or calendar won't open. Check customInput section in documentation
const DatepickerCalendarButton = forwardRef(renderCustomInput);
const onDatepickerChange = (value) => {
// check if text set in input type text is a valid date
if(isValidDate) {
setDate(new Date(text));
}
}
return (
<DatePicker
selected={date}
onChange={value => onDatepickerChange(value)}
customInput={}
/>
);
}`
Further suggestion: i also checked text in input type="text" length and property "strictParsing" to reach the behave you are asking for.
Hope this could help.

Is your feature request related to a problem? Please describe.
We need input date manually and allow the invalid date displaying(we will give validation message but not autocorrect)
Describe the solution you'd like
Provide a property to control autocorrect function.
Describe alternatives you've considered
Additional context

Hi,
I solved this problem using customInput property.
I created my own custom component as a Datepicker wrapper. In it I used a simple button as customInput. Doing so, I could open calendar just clicking on that button (in my case i used a button styled with a font awesome calendar icon).
Furthermore i created an input type="text" to manage date text.

Set as "selected" the date you saved in your internal state and set as "onChange" a function that changes that state based on what date you selected in your calendar.
This will allow you to manage data selection and to set text into a input type="text".
Almost done! To let user type in the input type="text" and to let datepicker know you changed the date, you need to manage the onChange event of the input type="text".
In this function, you need to check text validity (if it's a valid date or not) and then set your date as internal state (the same state set as "selected" property).
Pseudo code to help you understand better:
`
const DatepickerWrapper = () => {
// save date state
const [date, setDate] = useState();
const renderInputText = () => {
// render your input type text
return
}
function onChangeText(text) {
// check if text set in input type text is a valid date
if(isValidDate) {
setDate(new Date(text));
}
}
const renderCustomInput= (props, ref) => (
// render button with calendar icon
// do not forget this ref or calendar won't open. Check customInput section in documentation
// render button with icon
} // do not forget this forwardRef or calendar won't open. Check customInput section in documentation const DatepickerCalendarButton = forwardRef(renderCustomInput);
const onDatepickerChange = (value) => {
// check if text set in input type text is a valid date
if(isValidDate) {
setDate(new Date(text));
}
}
return (
<DatePicker
selected={date}
onChange={value => onDatepickerChange(value)}
customInput={}
/>
);
}`
Further suggestion: i also checked text in input type="text" length and property "strictParsing" to reach the behave you are asking for.
Hope this could help.

if(isValidDate) {
setDate(new Date(text));
}

Thanks for your help! Actually, I had implemented it as the same way you provided before, but encountered another problem. Anyway, this is a good solution. Thanks again!


fix(migrate): use the right node version (without >=)

My previous fix for this was bugged because of a mis-interpretation of the node version to a redirect.

@clementprevot I refactor the code. Can you merge master?

I saw that, I was merging the conflicts. You are way too fast for me :wink:

haha, but you resolve the conflict using the previous version!

Really? Hum that's weird, let me check that

@Kikobeats Are you sure? When I look at the changes of the PR, I only see the changes to use the right node version (variable name currentVersion in both index.js and switcher.js files

@clementprevot lol you're right, I added comments 👍

Need to resolve the pending reviews before merge this

I don't see any pending review

was (again) my fault, check now 😄

I commented on your reviews. I think you misunderstood what I wanted to do :wink:

yay!


Compiled module cache is not shareable/swappable

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
The in-memory compiled module cache used inside webpack is isolated to each compiler instance. This means it is not possible to re-use the cache between instances.
What is the expected behavior?
It would be very useful to be able to control/swap the cache implementation, especially if the caching API was async. This would open up the possibility of advanced features such as sharing module caches across machines/networks (e.g. multiple compiler instances running on separate hosts all sharing the same compiled module cache in a redis cluster).
If this is a feature request, what is motivation or use case for changing the behavior?
See my recent lightning talk at React London conference about how at Qubit we are running webpack across multiple hosts at scale - https://www.youtube.com/watch?v=mkUK2SZ8moY
Currently whenever a new instance of our compiler service starts up it has a cold compiled module cache, which means upon every deploy or scaling event our builds get a big spike in duration.
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
This is continuation of a discussion with @TheLarkInn on twitter earlier today - https://twitter.com/TheLarkInn/status/855373050195456000

Very interesting plugin, @niieani ! Thanks for linking it, i've not seen it before. That's definitely along the lines of what we want to achieve, so its awesome that it might be possible with a plugin instead of needing work done inside webpack itself. I'd need to have a look to see if we could adapt HardSourceWebpackPlugin to support different types of caches (i.e. remote ones like redis) so it would fit into our model.

@oliverwoodings you can experiment with the https://github.com/webpack-contrib/cache-loader.
It allow to cache on disk, but you need to make sure that loader configuration is equal or loader options have a unique ident.

@sokra ah awesome, thanks! What about if i wanted to share that cache across the network, i.e if the instances are running on separate VMs/entirely different machines? Would you suggest making the cacheing mechanism of cache-loader pluggable, or making an entirely separate loader e.g. redis-cache-loader?

Sometimes you're naughty @webpack-bot, but we still love you ❤ !

btw. there is a PR for making the caching stuff in the cache-loader plugable.


Web hot restart tests flaky timeout frequently causing web_tool_tests failure

See https://ci.chromium.org/p/flutter/builders/prod/Windows web_tool_tests
In particular:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8843718898922094865/+/u/run_test.dart_for_web_tool_tests_shard_and_subshard_web/stdout?format=raw
It looks like this started happening with an Engine roll containing only a Fuchsia SDK roll, so it is probably unrelated.
/cc @yjbanov @shihaohong

@annagrin

test/web.shard/hot_reload_web_test.dart also flaky timeout on Linux on head-head-head bots:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8843692410606035153/+/u/flutter_test_web_tool_tests/stdout
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8843646616757342784/+/u/flutter_test_tool_tests/stdout

looking in the logs I see some canvaskit errors. ill switch the apps to use html

@yjbanov ptal

The test failed on the head-head-head bot today in the following way:
01:57 +1 ~15 -1: test/web.shard/hot_reload_web_test.dart: hot restart works without error [E]
  Exception: Exception: Received app.stop event while waiting for app.started event

  [ +101 ms] FINE: Pub 2.14.0-edge.d5a97be46681feb703031587bfc35945d9d36744
  [  +44 ms] SLVR: fact: test is 0.0.0
  [  +13 ms] SLVR: derived: test
  [  +29 ms] SLVR: fact: test depends on flutter any from sdk
  [   +1 ms] SLVR:   selecting test
  [        ] SLVR:   derived: flutter any from sdk
  [  +19 ms] SLVR:   fact: flutter 0.0.0 from sdk depends on characters 1.1.0
  [        ] SLVR:   fact: flutter 0.0.0 from sdk depends on collection 1.15.0
  [        ] SLVR:   fact: flutter 0.0.0 from sdk depends on meta 1.7.0
  [        ] SLVR:   fact: flutter 0.0.0 from sdk depends on typed_data 1.3.0
  [        ] SLVR:   fact: flutter 0.0.0 from sdk depends on vector_math 2.1.0
  [        ] SLVR:   fact: flutter 0.0.0 from sdk depends on sky_engine any from sdk
  [   +1 ms] SLVR:     selecting flutter 0.0.0 from sdk
  [        ] SLVR:     derived: sky_engine any from sdk
  [        ] SLVR:     derived: vector_math 2.1.0
  [        ] SLVR:     derived: typed_data 1.3.0
  [        ] SLVR:     derived: meta 1.7.0
  [        ] SLVR:     derived: collection 1.15.0
  [        ] SLVR:     derived: characters 1.1.0
  [   +4 ms] SLVR:       selecting sky_engine 0.0.99 from sdk
  [   +8 ms] SLVR:         selecting vector_math 2.1.0
  [   +6 ms] SLVR:         fact: typed_data 1.3.0 depends on collection ^1.15.0
  [        ] SLVR:           selecting typed_data 1.3.0
  [   +3 ms] SLVR:             selecting meta 1.7.0
  [   +2 ms] SLVR:               selecting collection 1.15.0
  [   +2 ms] SLVR:                 selecting characters 1.1.0
  [  +87 ms] SLVR: Version solving took 0:00:00.192917 seconds.
  [        ]     | Tried 1 solutions.
  [        ] FINE: Resolving dependencies finished (0.236s).
  [  +68 ms] IO  : Writing 1105 characters to text file ./pubspec.lock.
  [        ] FINE: Contents:
  [        ]     | # Generated by pub
  [        ]     | # See https://dart.dev/tools/pub/glossary#lockfile
  [        ]     | packages:
  [        ]     |   characters:
  [        ]     |     dependency: transitive
  [        ]     |     description:
  [        ]     |       name: characters
  [        ]     |       url: "https://pub.dartlang.org"
  [        ]     |     source: hosted
  [        ]     |     version: "1.1.0"
  [        ]     |   collection:
  [        ]     |     dependency: transitive
  [        ]     |     description:
  [        ]     |       name: collection
  [        ]     |       url: "https://pub.dartlang.org"
  [        ]     |     source: hosted
  [        ]     |     version: "1.15.0"
  [        ]     |   flutter:
  [        ]     |     dependency: "direct main"
  [        ]     |     description: flutter
  [        ]     |     source: sdk
  [        ]     |     version: "0.0.0"
  [        ]     |   meta:
  [        ]     |     dependency: transitive
  [        ]     |     description:
  [        ]     |       name: meta
  [        ]     |       url: "https://pub.dartlang.org"
  [        ]     |     source: hosted
  [        ]     |     version: "1.7.0"
  [        ]     |   sky_engine:
  [        ]     |     dependency: transitive
  [        ]     |     description: flutter
  [        ]     |     source: sdk
  [        ]     |     version: "0.0.99"
  [        ]     |   typed_data:
  [        ]     |     dependency: transitive
  [        ]     |     description:
  [        ]     |       name: typed_data
  [        ]     |       url: "https://pub.dartlang.org"
  [        ]     |     source: hosted
  [        ]     |     version: "1.3.0"
  [        ]     |   vector_math:
  [        ]     |     dependency: transitive
  [        ]     |     description:
  [        ]     |       name: vector_math
  [        ]     |       url: "https://pub.dartlang.org"
  [        ]     |     source: hosted
  [        ]     |     version: "2.1.0"
  [        ]     | sdks:
  [        ]     |   dart: ">=2.12.0 <3.0.0"
  [   +3 ms] IO  : Writing 826 characters to text file ./.packages.
  [        ] FINE: Contents:
  [        ]     | # This file is deprecated. Tools should instead consume
  [        ]     | # `.dart_tools/package_config.json`.
  [        ]     | #
  [        ]     | # For more info see: https://dart.dev/go/dot-packages-deprecation
  [        ]     | #
  [        ]     | # Generated by pub on 2021-07-12 12:52:47.642237.
  [        ]     | characters:file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/characters-1.1.0/lib/
  [        ]     | collection:file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/collection-1.15.0/lib/
  [        ]     | flutter:file:///b/s/w/ir/cache/builder/flutter/packages/flutter/lib/
  [        ]     | meta:file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/meta-1.7.0/lib/
  [        ]     | sky_engine:file:///b/s/w/ir/cache/builder/flutter/bin/cache/pkg/sky_engine/lib/
  [        ]     | typed_data:file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/typed_data-1.3.0/lib/
  [        ]     | vector_math:file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/vector_math-2.1.0/lib/
  [        ]     | test:lib/
  [   +9 ms] IO  : Writing 1645 characters to text file ./.dart_tool/package_config.json.
  [        ] FINE: Contents:
  [        ]     | {
  [        ]     |   "configVersion": 2,
  [        ]     |   "packages": [
  [        ]     |     {
  [        ]     |       "name": "characters",
  [        ]     |       "rootUri": "file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/characters-1.1.0",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     },
  [        ]     |     {
  [        ]     |       "name": "collection",
  [        ]     |       "rootUri": "file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/collection-1.15.0",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     },
  [        ]     |     {
  [        ]     |       "name": "flutter",
  [        ]     |       "rootUri": "file:///b/s/w/ir/cache/builder/flutter/packages/flutter",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     },
  [        ]     |     {
  [        ]     |       "name": "meta",
  [        ]     |       "rootUri": "file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/meta-1.7.0",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     },
  [        ]     |     {
  [        ]     |       "name": "sky_engine",
  [        ]     |       "rootUri": "file:///b/s/w/ir/cache/builder/flutter/bin/cache/pkg/sky_engine",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     },
  [        ]     |     {
  [        ]     |       "name": "typed_data",
  [        ]     |       "rootUri": "file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/typed_data-1.3.0",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     },
  [        ]     |     {
  [        ]     |       "name": "vector_math",
  [        ]     |       "rootUri": "file:///home/chrome-bot/.pub-cache/hosted/pub.dartlang.org/vector_math-2.1.0",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     },
  [        ]     |     {
  [        ]     |       "name": "test",
  [        ]     |       "rootUri": "../",
  [        ]     |       "packageUri": "lib/",
  [        ]     |       "languageVersion": "2.12"
  [        ]     |     }
  [        ]     |   ],
  [        ]     |   "generated": "2021-07-12T19:52:47.656560Z",
  [        ]     |   "generator": "pub",
  [        ]     |   "generatorVersion": "2.14.0-edge.d5a97be46681feb703031587bfc35945d9d36744"
  [        ]     | }
  Failed to establish connection with the application instance in Chrome.
  This can happen if the websocket connection used by the web tooling is unable to correctly establish a connection, for example due to a firewall.

  #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
  #1      ResidentWebRunner.run (package:flutter_tools/src/isolated/resident_web_runner.dart:328:7)
  <asynchronous suspension>
  #2      AppDomain.launch.<anonymous closure> (package:flutter_tools/src/commands/daemon.dart:595:9)
  <asynchronous suspension>
  #3      AppDomain.launch (package:flutter_tools/src/commands/daemon.dart:593:5)
  <asynchronous suspension>
  #4      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:552:15)
  <asynchronous suspension>
  #5      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1126:27)
  <asynchronous suspension>
  #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
  <asynchronous suspension>
  #7      CommandRunner.runCommand (package:args/command_runner.dart:196:13)
  <asynchronous suspension>
  #8      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:288:9)
  <asynchronous suspension>
  #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
  <asynchronous suspension>
  #10     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:236:5)
  <asynchronous suspension>
  #11     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
  <asynchronous suspension>
  #12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
  <asynchronous suspension>
  #13     main (package:flutter_tools/executable.dart:92:3)
  <asynchronous suspension>

01:57 +1 ~15 -1: loading test/web.shard/hot_reload_web_test.dart
Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'pub run test --chain-stack-traces'.

@alexmarkov could you please share a link to the failure? I am only seeing engine tests failing currently...

@annagrin Here is the link: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8841900348628040752/+/u/flutter_test_tool_tests/stdout

Looks like the HHH bot is fine now, so the issue seems to be intermittent. Created a separate issue to investigate (above).

@annagrin Would you mind taking this issue? This is outside my domain.

@yjbanov I assigned it to myself. I have a potential fix in webdev, will see if it works after it gets to flutter.

@annagrin This issue has a tag indicating that a test was disabled for it. Did you also re-enable the tests that were disabled?

It looks like this is still happening https://ci.chromium.org/ui/p/flutter/builders/prod/Windows web_tool_tests/2880/overview

The failing test is "hot_reload_web_test.dart: newly added code executes during hot restart - canvaskit"
This one should still be disabled since the flakiness is caused by downloading canvaskit over the network

https://github.com/flutter/flutter/pull/86885

My understanding is that the current status of this is that it is waiting for the canvaskit pin to re-enable the disabled test. Dropping priority based on that.

@annagrin This issue has a tag indicating that a test was disabled for it. Did you also re-enable the tests that were disabled?

@zanderso Looks like this issue bundles a few issues together - hot restart hangs, errors on connection to chrome, and canvaskit binding errors. I enabled two tests in packages/flutter_tools/test/web.shard/hot_reload_web_test.dart but it looks like one of them is still failing due to canvaskit issue. Thanks for disabling it!
I'll keep monitoring this issue to see if my fix stops flakiness due to hot restart  hangs.

@annagrin I'm not sure @jonahwilliams is reading here anymore if that question was directed at him. If a retry there could succeed after an initial failure, then that sounds like something that could deflake the test.

@zanderso I will add the retries to see if it has any effect, but it looks like the occurrences are pretty rare at the moment.

Closing this as there have been no flakiness for a month, please feel free to reopen if needed!


Update Japanese and English READMEs

This PR updates the Japanese and English README files.
Though minor, installation following current instructions will fail on systems running OS X 10.11 (El Capitan) or macOS 10.12 (Sierra).
This is due to a newer feature of the OS, called System Integrity Protection, a security measure which prevents even root-level access to a number of directories, including /usr/bin.
The Portuguese README has already been updated accounting for this.

Coverage decreased (-0.06%) to 51.376% when pulling b6471fec5e5d522f809427d5a11ea73c399358bc on nrebhun:update-readme-sip into 991f3cac6c4ee4da4b4bc156bc86d9c9cd9eb87c on phpbrew:master.


TEST DO-NOT-MERGE: Delete build script to break the build

This is to test the cncf-ci bot. I hope it comments about the build breaking.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: devaii
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [devaii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix: remove Immutable flag before writing efi vars

EFI vars are marked as Immutable on many Linux systems. In those cases, the library would fail to write variables.
This change fixes that by removing the Immutable flag beforehand, and adding it back afterwards. It's essentially equivalent to the commands:
chattr -i /sys/firmware/efi/efivars/$VAR
# write to variable...
chattr +i /sys/firmware/efi/efivars/$VAR

Thank you :)


Hope for the release of fine-tuned video retrieval checkpoint

Hi~ Thank you for your awesome work!
But in Video-Text-Retrieval task, till now only the pre-trained ViT weights of CLIP can be reached, and when will the fine-tuned video retrieval checkpoint be released? We all hore for it~

Hi, you can download our fine-tuned checkpoints by filling out this form.

Hi, you can download our fine-tuned checkpoints by filling out this form.

Thanks very much for your opening these checkpoints~ But the checkpoint of MSR-VTT in retrieval task seems to be unreachable, when I enter the link, it shows 'This XML file does not appear to have any style information associated with it'. Maybe there exists some error?

Hi, you can download our fine-tuned checkpoints by filling out this form.

Thanks very much for your opening these checkpoints~ But the checkpoint of MSR-VTT in retrieval task seems to be unreachable, when I enter the link, it shows 'This XML file does not appear to have any style information associated with it'. Maybe there exists some error?

Same issue

Thanks for pointing out this issue! We have already fixed the link for the checkpoint of MSR-VTT in the retrieval task. @oenewbee @igodogi


Form "Export CSV" fails with non-ASCII characters

If I try to export form entries that contain non-ASCII characters I get an error like "'ascii' codec can't encode character u'\u2013' in position 107: ordinal not in range(128)".
The CSV module docs have a recipe to export CSVs as UTF-8 and I'm happy to take a stab at fixing this in Mezzanine.  Go ahead?

That fix does the trick.  Thanks!


MINIFICPP-382: Implement SUSE release support for SUSE and SLES12

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

How fitting, a unit test is seg faulting....I'll check and update.

grabbed me some ISOs, will scope out

Looks good.

@phrocker I had run into a small hiccup when initially reviewing on SLES 12 SP3 which was probably more a product of my lack of familiarity with SUSE.  I needed to first enable the SLES SDK repository after activating my install.  This was accomplished via yast.  After that, I was able to pull down all the devel dependencies.  Build and testing went fine.  +1 from me.  Might be helpful to have a note about that dependency first.  not sure if bootstrap or readme makes more sense.

@apiri I made an update to the readme last night.
https://github.com/apache/nifi-minifi-cpp/pull/260/commits/7a3e81066c007053adc77a315f490e44671cbd34

@phrocker great, thanks will get this merged. sorry didn't notice the update.


Registry Migration - review and update retagger synced images - Tinkerers

For the first step of the registry migration story (see the RFC more detailed information) we need every team to review and update the retagger synced images that are used by the team. You can find the configures images here.
Therefore you need to do two things:

[ ] remove images that are not needed anymore at all
[ ] bump versions for images that are known to not use certain old versions any more

This will help us to keep the registry cleaner and in the end also cheaper.

I went through all of the Team Tinkerers specific images (there's not many) and they're all still valid. The majority of them actually use mutable tags (e.g. latest and debug) so the storage of them is already pretty cheap! 😁


Asset list?

Fully restoring the project file and obtaining all the required assets is left as an exercise to the reader.

Would you be able and willing to provide a list of music & sound effects used in the fight simulator?
Made you any of the redacted assets yourself? If so, where can one find them?

Unfortunately, there isn't much that I can do in this matter without expending a huge amount of effort. I don't have a complete list of sources for all asset files. Many of the assets were also custom-made. The game credits are the best resource I can provide.
I am also not able to share the assets themselves, since:

their licenses do not allow redistribution,
they're derivative works based on copyrighted content, and so they cannot be relicensed.

There are no licensing issues as long as I distribute the original game binary, and not its raw assets. The game binary is still available for download with all of the assets intact!
Don't use community tools, such as UndertaleModTool, to extract the original assets and publicly share them, because doing this would be very illegal! Using tools like UndertaleModTool to extract the contents of the data.win file, along with the asset names which conveniently happen to be unobfuscated and identical with the original source code, could put you at a legal risk if these assets are redistributed. I certainly don't recommend using the Bleeding Edge release of UndertaleModTool, which is compatible with the release version of the game, to extract all the required asset files along with their names. Especially don't use the "ExtractAllSprites" and "ExtractAllSounds" plugins of UndertaleModTool, which are located in the Scripts -> Resource Unpackers menu, as this could put you in a risk of violating licensing and copyright laws.
I hope my response was helpful 😊


Cannot opam install flow_parser on OCaml 4.08

opam install flow_parser
The following dependencies couldn't be met:
  - flow_parser -> ocaml < 4.08.0
      base of this switch (use `--unlock-base' to force)
  - flow_parser -> ppx_tools_versioned = 5.2 -> ocaml < 4.08.0
      base of this switch (use `--unlock-base' to force)

Is 4.08 yet to be supported or am I doing something wrong?

we only officially support 4.07, but we've been slowly unblocking the things that were keeping us from upgrading to 4.08, notably sedlex 1.99 -> 2.0. it might not be much work left at this point. patches are welcome!

see #8362


ciao-deploy: do not use latest for cnci version, use last known good

It turns out that the "latest" file that is located on clearlinux.org
only refers to the latest generated image, but that image may not
necessarily end up in download.clearlinux.org/image if it does not
pass QA for some reason. Therefore, any cloud image located in
clearlinux.org/image is the last known good image and should be
used. Modify getCNCIURL() to download the images listing and look
for the cloud image filename to use from there.
Signed-off-by: Kristen Carlson Accardi<EMAIL_ADDRESS>

Coverage increased (+0.005%) to 65.18% when pulling ae90827737842ed031c6171470e40a3d037746ff on kaccardi:topic/update-cnci-image into db55062a061a9a0529759f3ea96532c3437d7b79 on ciao-project:master.

Coverage remained the same at 64.544% when pulling e0501e5d4a29d9be484d91f9dd08d9204650d0ba on kaccardi:topic/update-cnci-image into c6ea21083acc969871d86f012b465ea09d0cf1c4 on ciao-project:master.

Coverage increased (+0.009%) to 64.5% when pulling c270198ad52f75be58209f09a66931d8a444147d on kaccardi:topic/update-cnci-image into bd853cbf8b56de8fa149968d6b03919370bbc239 on ciao-project:master.