Extensions for UI events

In order to create Observable on top of UI events, we need to do this:
Observable.FromEventPattern<RoutedEventHandler, RoutedEventArgs>(
    h => IncrementButton.Click += h,
    h => IncrementButton.Click -= h
).Subscribe(…)

I think it is a lot of code for a simple action. My proposal is to write Extension methods so we can do this:
IncrementButton.ObserveOnClick().Subscribe(…)

Here is an the extension method related:
public static IObservable<EventPattern<RoutedEventArgs>> ObserveOnClick(this Button button)
{
    return Observable.FromEventPattern<RoutedEventHandler, RoutedEventArgs>(
        h => button.Click += h,
        h => button.Click -= h
    );
}

We need to write every Extension method for every event on any platform (UWP, WPF, WInForms, Xamarin, etc..). I think it's feasible but my questions are

Is there any existing library that does what I say? I did not find it but maybe it exists.
Should this library be in this repository?

Sounds pretty much like the ReactiveUI.Events library from https://github.com/reactiveui/ReactiveUI, it does exactly that

@flagbug Any example? I don't see how to do that with this library.

Take look at ReactiveProperty as well; this technology plugs directly into XAML.

Well, the thing is that I do not want to depend on PropertyChanged pattern. I want to listen to any kind of Event on any kind of UIElement.
It is basically syntactic sugar to turn the Observable.FromEventPattern into an Extension method based on the sender and the type of Event.

@Odonno see https://reactiveui.net/docs/handbook/events/ and NuGet

Thanks @benoitjadinon. Seems to work pretty fine.


Update incorrect (older) reference to "Field Guide"

I don't know if this qualifies for a bug or not, but this page wrongly refers to "Field Guide" in navigation menu which seemingly has been changed to "Guide" only. Just felt like reporting it for update.
http://www.freecodecamp.com/challenges/waypoint-browse-our-field-guide

@sunnyspecs Thanks for the letting us know! This typo will be fixed.

Thanks - I've fixed this.

Thanks.


Views: MongoDB view @id field requires @map

Bug description
Currently, when defining a view in your Prisma schema while using MongoDB you are required to @map("_id") the view's unique identifier.

Example:
generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["fullTextSearch", "views"]
}

datasource db {
  provider = "mongodb"
  url      = env("DATABASE_URL")
}

model User {
  id      String   @id @default(auto()) @map("_id") @db.ObjectId
  email   String   @unique
  name    String?
  profile Profile?
}

model Profile {
  id     String @id @default(auto()) @map("_id") @db.ObjectId
  bio    String
  userId String @unique @db.ObjectId
  user   User   @relation(fields: [userId], references: [id])
}

view UserInfo {
  id    String  @id  // ❌ Invalid
  email String?
  name  String?
  bio   String?
}

view UserInfo {
  id    String  @unique  // ❌ Invalid
  email String?
  name  String?
  bio   String?
}

view UserInfo {
  id    String  @id @map("_id")  // ✅ valid
  email String?
  name  String?
  bio   String?
}

Context: https://github.com/prisma/docs/pull/4476#discussion_r1096064225
How to reproduce
Create a view in your Prisma schema with mongodb as the datasource provider.
Attempt to identify the unique identifier of the view with @id or @unique.
Expected behavior
This should not require @map("_id").
Is it possible to allow @unique here to identify the unique identifier of the view?
Prisma information

datasource db {
  provider = "mongodb"
  url      = env("DATABASE_URL")
}

view UserInfo {
  id    String  @id
  email String?
  name  String?
  bio   String?
}

Environment & setup

OS:
Database:
Node.js version:

Prisma Version
prisma                  : 4.10.0-dev.80
@prisma/client          : 4.10.0-dev.80
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine 9bde8bbe3bc34fa749e3cf03285929cd9c4e078a (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 9bde8bbe3bc34fa749e3cf03285929cd9c4e078a (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.10.0-74.9bde8bbe3bc34fa749e3cf03285929cd9c4e078a
Default Engines Hash    : 9bde8bbe3bc34fa749e3cf03285929cd9c4e078a
Studio                  : 0.481.0
Preview Features        : fullTextSearch, views

Thanks for this issue. We will need to investigate the requirements for views in MongoDB to understand if the same _id requirement applies to it or not. I hope not, as it would simplify the mental model for views in MongoDB a lot.

So, reading through their docs on documents. All documents must either have a self-defined _id or something that maps onto it, i.e. an id must map to _id.
Per their docs, views also use the indexes of the underlying collections. From what I've read, views do no themselves function as "documents" and therefore do not necessitate their own _id.
This is how I understand it:
model User {
  id String @id @map("_id") // *here
  ...
}

view UserInfo {
  id String @unique // map to _id is already defined*
  ...
}

views do no themselves function as "documents" and therefore do not necessitate their own _id.

I think this is exactly what we were hoping. It would simplify the concept for users (and relieve some confusion in regards to view fields vs. model fields) a ton if they could use @unique rather than essentially rewriting the entire document unique identifier.


IPROTO-163 Remove javax.annotation-api dependency from core

https://issues.redhat.com/browse/IPROTO-163

merged in 4.3.x and master


Improve cross-listings parsing

Cross-listings should be an empty vec when there are no cross-listed courses rather than a vec populated by a single empty string.
Cross-listings should have classes broken up into multiple strings rather than all classes in one string.

Example class that has multiple cross-listed classes: NIS 655 Queuing Systems with Computer Applications I


add tests for compat_v1 encdoing

What have you changed?
Add some tests for compat_v1  encoding.
What is the type of the changes?
Engineering
How is the PR tested?

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect tidb-ansible?
NO
Refer to a related PR or issue link (optional)
#6132

Please fix conflicts, thank you

@HunDunDM

/merge

/merge


[Feature Request]: Add erasing feature in the draw section

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
currently there is no option to erase the things we have drawn
Use Case
Since the application is a drawing application , eraser is one of the important thing that should be present in it.
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I want to work on this issue

@singodiyashubham87  please assign me this issue

Could I try working on this?

Unassigning due to inactivity @AnshikaAg03 .

@shreyarao9 Proceed!


Remove CSIBlockVolume from tech preview in 4.2

CSIBlockVolume support was enabled in 4.1 via this PR: https://github.com/openshift/api/pull/278
This feature is alpha in k8s v1.13 (Openshift 4.1), however, the feature turned beta in v1.14 (which 4.2 is based on).
Since we're looking into making this feature generally available for Openshift 4.2, I believe we should remove this line from the tech preview list of features.
CC @j-griffith, @humblec, @jarrpa, @openshift/storage

CC @eparis

/assign @eparis

LGTM !! Thanks @bertinatto

@eparis, can you check if this makes sense, please?

/assign @deads2k @sttts

/lgtm
You'll need to bump the operators of affected binaries and whatever drives the kubelet.

OK, checking which components I need to bump.

I don't think we really care if they get bumped. Since this is enabled by default in 4.2 having this present or not is irrelevant, no?

I don't think we really care if they get bumped. Since this is enabled by default in 4.2 having this present or not is irrelevant, no?

After looking into this for a while, that's my understanding as well.
As far as I understand, it would be relevant if it was the other way around (enabling a previously disabled feature, for example). @deads2k, are we missing anything here?


Refactoring YAML Config

Defines a Config structure to hold configurations, to be more strict, and to allow to define it without YAML.
Defines parsers from YAML to Config, with a lot of informative error messages for the user.
Refactorize ReadCalibrationFiles as read_calibration_files_from_yaml, now there is three passes:

first pass goes through each category and gather every possible file, based on their dirpath and filename only.
second pass collect keywords on the set of all gathered files ; the keywords needed for the set of all filters.
third pass goes through each category and keep only files who are valid for the filters of the category.
This refactoring permits to read a FITS header only twice, compared to the previous process where a FITS header was read for each category. The only regression is that now, a keyword present in two different categories must have the same type for both categories. I believe this situation should be very rare, but tell me, a workaround is easy.

Provides intensive test for the refactored code
Reworks documentation accordingly to the modifs, and improved existing one.
title  setting is back
fix hdu integer or string
removes verb setting, and uses @debug calls
dir system is clarified, now read_calibration_files_from_yaml takes a basedir keyword parameter, which is the folder from which eventual relative path in the YAML will be resolved. Default is pwd().
added a new constructor for CalibrationData, which takes a Config as input

sounds great!


💡 [REQUEST] - 官方是否用TensorRT-LLM 跑过 Qwen-14b-chat-Int4 模型？效果如何？提速几倍？

起始日期 | Start Date
No response
实现PR | Implementation PR
No response
相关Issues | Reference Issues
No response
摘要 | Summary
官方是否用TensorRT-LLM 跑过 Qwen-14b-chat-Int4 模型？效果如何？提速几倍？
基本示例 | Basic Example
none
缺陷 | Drawbacks
none
未解决问题 | Unresolved questions
No response

+1

We haven't try TensorRT-LLM ourselves and consequently we don't have any data to share.


Add text color argument to .bg-variant mixin

While extending bootstrap for my own project I realized that I had to create many more background utility classes based on 7 grays I have in my project. I thought of using the existing bg-variant() mixin for creating for the variant but I see that the color property is hard coded to be #fff !important.
https://github.com/twbs/bootstrap/blob/v4-dev/scss/mixins/_background-variant.scss#L5
This doesn't really work well for lighter colors. Can the mixin be changed to accomodate a text-color argument and have it set to #fff as default rather than hard coding it?
@mixin bg-variant($parent, $color, $text-color:#fff) {
  #{$parent} {
    color: $text-color !important;
    background-color: $color !important;
  }
  a#{$parent} {
    @include hover-focus {
      background-color: darken($color, 10%) !important;
    }
  }
}

This definitely requires some additional changes in the references but it makes it possible for the text color to be adjusted while creating these classes.

Going to probably avoid doing this and instead opt for those utilities to have a single declaration—background-color—and leave the color to another utility. Haven't put toooo much thought into it, but definitely want to try that out.

Eager to know how that'll work. Set color from another mixin?

I'd suggest to combine that with an auto-adjusting approach:

@mixin bg-variant($parent, $bg-color, $text-color:#fff) {
	#{$parent} {
		@if( lightness($bg-color) > 50 ) {
			color: darken($text-color,lightness($bg-color)) !important;
		} @else {
			color: $text-color !important;
		}
		background-color: $bg-color !important;
	}
	a#{$parent} {
		@include hover-focus {
			background-color: darken($bg-color, 10%) !important;
		}
	}
}

Above is a very simplified approach. It might benefit from trying this with a variant of background-color sets and maybe use hue() and/ or saturation() to calculate a working text color.

No plans to do this anymore—our utilities are more often going to be single purpose, offering more control and customization but with an extra class here and there.


req.body does not have method hasOwnProperty: Fix

Fixes an error that is occuring on modern stacks: req.body does not have a method called hasOwnProperty;  I think this is because sometimes the value coming back is an array not an object, and so this fix resolves that.

This has been fixed in v0.12.6, see the new fork: https://github.com/freewil/express-form/pull/24


Fix full-screen map when browser is full-screen

Fixes brunob/leaflet.fullscreen#121

@brunob Anything I can do to help get this merged and released?

Thx for the issue and the PR, just let me a couple of days to find a moment to review it.

I hate to ask (again), @brunob, but any progress on this?

The fix seems good, but i have a doubt on performance impact of calling invalidateSize() every times. Any thoughts @BePo65 ?

The fix seems good, but i have a doubt on performance impact of calling invalidateSize() every times. Any thoughts @BePo65 ?

Not sure what you mean by "every time". The calls to invalidateSize() only happen upon entering full-screen (via the button), and when exiting full-screen (both via the button and via the Escape key).

IMHO @gjvoosten is right: invalidateSize() should be triggered only, when the fullscreen state changes. So I do not see any performance penalties.

Nice, let's merge this :)

published with version 3.0.2, thx again @gjvoosten !


can't install on ReactJs v17+

is it safe to force installation on v17? If so, dependencies should be fixed to allow it

fixed in v0.3.0 (don't forget to update the rete package)


provideLocalStorageDataClass with initial content + Orders from local storage

The data used for "local storage" is directly taken from the current response of PisaSales with example content.
Needs new content: https://edit.scrivito.com/d0a154d76edf2a7bd991fc658e700a1d~https://improved-providelocalstorage.scrivito-portal-app.pages.dev/orders-02d09ad2dd7d2332?_scrivito_workspace_id=je305f894b0a1bb4&_scrivito_display_mode=view

REVIEW (0c89b32)


Fix when FactoryGirl appears twice on same line

If a spec has two FactoryGirl declarations on the same line, it would only replace the first command. We need to have a g to replace all occurrences.

LGTM, thanks!

this appears to have been resolved by another commit


Arbitrary number of arguments

Is there any way to support arbitrary number of arguments?

@click.argument('name', nargs=-1)


infinity loop on checking packages

since last week I can't upgrade packages. It stucks on this step:

⠧ Checking npm registries for updated packages.

npm -v

6.14.7

node -v

v14.8.0

npm-check

v5.9.2

same problem when i use with RPI4 (2GB)
const npmCheck = require('npm-check');

npmCheck(options)
  .then(currentState => console.log(currentState.get('packages')));

CPU : ~100 %
Memory : ~100%
I wait 10 min and stop the process

Same Problem, running on
npm
6.14.8
node(snap)
v14.9.0

Same
npm 6.14.8
node v12.18.3
Found no reason or workaround so far.

I'm experiencing this too.  What's also interesting is that npm-check -ug will work and let me update my global packages, but it just get stuck checking NPM when running within a project using npm-check -u.  Maybe this is because I have very few globally installed dependencies?
I've been trying to go to older versions of npm-check to see where the bug go introduced but haven't had any luck yet.


[SPARK-42559][CONNECT][TESTS][FOLLOW-UP] Disable ANSI in several tests at DataFrameNaFunctionSuite.scala

What changes were proposed in this pull request?
This PR proposes to disable ANSI mode in both replace float with nan and replace double with nan tests.
Why are the changes needed?
To recover the build https://github.com/apache/spark/actions/runs/4349682658 with ANSI mode on.
Spark Connect side does not fully leverage the error framework yet .. so simply disabling it for now.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually ran them in IDE with ANSI mode on.

LGTM

Merged to master and branch-3.4.


[RFR] Fixed an error in mq-px2em

When value is unitless, we go recursive after converting the value to pixels. We need to make sure to pass the given base font size as well. Also, there is no reason the conversion can fail.

Thanks, good catch! What is the argument for having $n * 1px instead of $n + 0px?

What is the argument for having $n + 0px instead of $n * 1px?

You tell me!

Also, I am not sure we need to go recursive here. Doesn't make much sense to me, we could just redefine $px.

I feel like it makes more sense to multiple by 1 unit than to add 0 unit. Thoughts?

I really don't mind, thanks for the fix!


RTCMultiConnection not work android 6

I need permission camera, I have written in my config.xml file
<config-file parent="/*" target="AndroidManifest.xml">
    <uses-permission android:name="android.permission.READ_CONTACTS" />
</config-file>

but it do not work in Android 6+ version device
If someone has a similar problem help me
I use cordova 7.0.1 version

Did you check this?

https://play.google.com/store/apps/details?id=rmc3.videoconference

via: http://webrtcweb.com/cordova-apps/video-conferencing/

<config-file parent="/*" target="AndroidManifest.xml">
     <uses-permission android:name="android.permission.CAMERA" />
     <uses-feature android:name="android.hardware.camera" />
</config-file>

http://webrtcweb.com/cordova-apps/video-conferencing/#AndroidManifest.xml


Fix #26 by adding an MIT license

Add an MIT license to the project.

Motivation
The project is still missing an open source license.

Solution
I'm suggesting an MIT license based on the related projects mentioned in the README. Both ethers.js and rust-web3 use an MIT license, while ethcontract-rs uses a similar Apache license.

Hey @andrekorol, thanks for the PR! I have chosen to dual license it under MIT/Apache 2 in https://github.com/gakonst/ethers-rs/pull/28. Closing this PR in favor of that


[question][web] Do you have any idea how to handle smooth transition of subpages?

Hello,
I am asking here, because you handled this package very well so you might have answer for that (or I will put this question in official flutter issues) :)
When I am using nested routing in web, where only part of the screen is being changed (without scaffold), then I have such situation:
https://user-images.githubusercontent.com/54472480/112757908-f676cf00-8feb-11eb-9253-dc5e11bd21a5.mp4
The situation is a little annoying (because for 1 second I see two pages overlapped), but the worse situation is when I am disabling "mobile" animation of navigation:
https://user-images.githubusercontent.com/54472480/112757917-fc6cb000-8feb-11eb-9c1b-d342e94917bf.mp4
Could be something connected to this plugin or it is rather flutter problem/limitation?

Hi @mordivgor
I'm not sure is it a problem of Beamer or a general one. Did you extend BeamPage with custom transition? Can you show it?

Hi @slovnicki
No, I did not extend - I just modified a little bit your nested example to show the problem.
For changing the transition (to no-animation) I just used 'pageTransitionsTheme' as a parameter of 'ThemeData', which is the parameter of MaterialApp.router

I see. You can also try to put no-transition as described at https://github.com/slovnicki/beamer/issues/51#issuecomment-799861789, maybe it behaves differently.
Within few days, this will also be available for easier setup; https://github.com/slovnicki/beamer/issues/141

@slovnicki  thanks for your tips :)
I tried no-transition and looks the same like my setup with "no transition".
Fade transition looks better:
https://user-images.githubusercontent.com/54472480/112758892-d72e7080-8ff0-11eb-8af8-e7954e7784a6.mp4
But still, there is a moment when two subpages are visible..
After these changes, I bet it is rather some flutter issue/limitation. I will raise the official issue.
Please decide whether you want to close this issue or leave to monitor this case.

@mordivgor Still, I think this is expected behavior of Navigator.transitionDelegate.
You mentioned you are not using Scaffold. Does this mean your containers are transparent and that's why you are seeing both?

Generally, I have a use case when I want to change only part of my screen without touching rest. The reason is that I have a AppBar which is being loaded again when changing the page in normal (non-nested) way - it is making bad user experience when some widgets in appBar are loaded in async way.
The above examples show jumping between two child pages (the "parent" page - this one with Scaffold - is not being changed). Or in beamer nomenclature - I have parent location with parent screen and child location with two different screens :)

just FYI - I have raised this case officially:
https://github.com/flutter/flutter/issues/79271
But I am not able to provide pure code as this navigator 2.0 is quite complicated to dig into it :/

@mordivgor there's been some major improvements. Can you try setting
BeamerRouterDelegate(
  transitionDelegate: NoAnimationTransitionDelegate(),
  ...
)

looks like the pages are transparent, did you tried to wrap them with a Material() widget?

@slovnicki @talski  thanks guys for tips, right now I needed to switch to some other solution :) But I confirm that Material() does the job!

Thanks for the feedback @mordivgor !


Mute and unmute audio

When muting and unmuting the audio, audio level jumps to 1. Would be nice if it jumped to the audio level before muting the audio instead of max.

Hey,
It's on the "to-do" list, it will probably be released in a few days

Thanks! If you want me to take a stab at this with a PR, let me know. Be happy to do it.

@subhero24,
Thank you, it was not necessary, as it was already in my plans to work on it.
in fact, it has been launched in the last commit along with some improvements to the volume range input, try it out! Thanks.


Train 35

#278, #379, #387, #391
Revert: #365. It broke the AWS CF templates.

Launched a CF stack of this PR. The reverts make it so the clusters come up again.
Mesos UI sandbox download links work properly now.


[Feature Request] Use recommended deck for triple triad

It would be nice if the TT module could use the recommended deck, instead of having to choose one of the already built decks.

This is already a feature however it's been bugged. If you don't select a deck from the dropdown and don't tick to automatically select, it will default to the recommended button. Latest update fixes this.


Not compiling/reading files correctly

- [x ] bug report
- [ ] feature request

Versions.
@angular/cli: 1.0.0
node: 7.7.4
os: darwin x64
@angular/common: 4.0.0
@angular/compiler: 4.0.0
@angular/core: 4.0.0
@angular/forms: 4.0.0
@angular/http: 4.0.0
@angular/platform-browser: 4.0.0
@angular/platform-browser-dynamic: 4.0.0
@angular/router: 4.0.0
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.0
When i modify and save my files, i see Angular-cli generating the chunks again - However its not reading the files content and is still giving errors. I have to exit and re-run ng serve before it stops giving errors.
For instance, i have an interface:
export interface ISignup {
  email: string;
  password: string;
  companyName: string;
  companyRole: string;
  firstName: string;
  lastName: string;
  phone: string;
  country: string;
}

Which i renamed to SignupInterface but the compiler is still giving error:

Module '"/app/signup/signup.model"' has no exported member 'SignupInterface'.

After exiting and re-running ng serve the problem gets fixed but its really annoying having to change properties/class/interface names and then re-running compiler

Heya, does this only happen on interfaces?

@filipesilva it happens for classes aswell.
Renaming a class doesn't register unless i restart the CLI.

Same happens to me with ng test (4.0.0-rc.5)

@hassanasad I was not able to replicate it on classes. But I can confirm it only happens in the case of interfaces so seems to be an issue with interfaces. On running ng serve it only picks the interfaces already defined. Making any consecutive change in the interface doesn't pick up the changes. Shows below error.
ERROR in /Users/sumitarora/workspace/open-source/temp/aa/src/app/app.component.ts (17,5): Type '{ email: string; p2: string; }' is not assignable to type 'Signup'.
  Object literal may only specify known properties, and 'p2' does not exist in type 'Signup'.

Changing password to p2 in the interface.
export interface Signup {
  email: string;
  password: string;
}

@sumitarora that is weird - its same for me on classes and interfaces both. Perhaps might be because i have both in the same file which i am testing with?

@filipesilva, @sumitarora  Ah - it  happens for classes as well IF the file contains an interface.
For instance:
export class SignupModel {
  constructor(
    email: string,
    password: string,
    companyName: string,
    companyRole: string,
    firstName: string,
    lastName: string,
    phone: string,
    country: string,
  ) {  }
}

export interface SignupInterface {
  email: string;
  password: string;
  companyName: string;
  companyRole: string;
  firstName: string;
  lastName: string;
  phone: string;
  country: string;
}

I'm having the same issues. I previously had the issues in beta 30, but got around it by downgrading @ngtools/webpack to version 1.2.4
Changes to html files will be reflected in the browser after rebundling. Changes to .ts files seem to trigger a rebundle, however do not get reflected in the browser until a new ng serve is run
@angular/cli: 1.0.0
node: 7.7.4
npm: 4.3.0
os: windows 10
"@angular/common": "4.0.0",
"@angular/compiler": "4.0.0",
"@angular/core": "4.0.0",
"@angular/forms": "4.0.0",
"@angular/http": "4.0.0",
"@angular/platform-browser": "4.0.0",
"@angular/platform-browser-dynamic": "4.0.0",
"@angular/router": "4.0.0",
"@angular/cli": "1.0.0",
"@angular/compiler-cli": "4.0.0",

+1

Same issues. "@angular/cli": "1.4.1"

Still seeing this in "@angular/cli": "1.4.2"

still in  "@angular/cli": "1.4.5",

+1 I have the same issue with class based typing's and the class doesn't contain any interfaces.

Ok, I've changed all the classes to interfaces, seems to be working now.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.


chore(deps): bump https://github.com/jenkins-x/jx-git-operator to 0.0.85

Update jenkins-x/jx-git-operator to 0.0.85
Command run was jx step create pr regex --regex version: (.*) --version 0.0.85 --files charts/jx-labs/jx-git-operator.yml --repo https://github.com/jenkins-x/jxr-versions.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign macox
You can assign the PR to them by writing /assign @macox in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add comment to make it clear how the code is working

The logic isn't technically necessary but it seems helpful to list the exceptions we expect to fit into this bucket.

@mergifyio refresh

Mergify rules have changed since this was opened thus no automerge - doing so manually


🗑 clean-up SHOW_SPONSORS feature flag

@AnthonyBuisset We should add a story for project cards with sponsors


Media keys stop working after long periods of time

OS:
macOS Sierra 10.12.6
Issue Descriptions:
Searched through all the tickets and couldn't find anything quite like this. Media keys work fine, even without the fn key. However, if I leave the app open for long periods of time they stop working. A simple restart fixes the issue for the day. Don't know anything about the implementation, but some sort of periodic refresh( 3 -4+ hours ) would be great. Love the app! Use it everyday. Thanks for putting in the time!
Steps to Reproduce:
Leave app open for long ( 12+ hours ) time. Close over night etc.
Attempt to use media keys. They stop working.
Restart app. They work again.

same on Windows 10 1703

@pbsladek I tried to repro this and I couldn't, left my mac logged in for 12 hours then left it on overnight, next morning the hotkeys still worked.  Tried this a few different days as well.
That said, I can see this kind of thing happening, if macOS decides you don't get the hotkeys anymore, it's just gonna take them 😆 .  I can add like a loop that checks every 15 minutes or so whether the hotkey is still registered but this would
a) Have an impact on battery life (timers are not nice)
b) Still leave you with a period of time where the hotkey isn't working
I think the best thing to say here is, if the hotkey stops working, just quickly restart GPMDP 😆 It takes a few seconds and everything will be back working again 👍
Sorry I can't do more with this one


Parallel.each does not pass index and list to the callback, just the value

Documentation of Parallel.each says

The callback takes three arguments: the current element being processed, the index of the current element, and the input list.

but actually only the list value is passed, as can be seen in the signature

each<T1, T2>(list: T1[], action: {(value: T1): Promise}, concurrency?: number): Promise

Parallel.each should pass all three parameters, as Array.forEach does.

Yes, you're right, I'll get this fixed.

OK, this should be fixed now, will publish out to npm in the next day or so if no issues are found. Thanks again for your feedback!

Is the fix already supposed to be available? Nothing to see in v1.2.3.

dead project?

Not dead, still actively using and maintaining it.
Other than the issue above (which it looks like I totally overlooked, sorry for that) it's been pretty rock solid.
Do you have any new issues or feedback?

Hi, good to hear. No I just checked my list of open issues. Thanks for responding, I am still using the lib and am happy with it :)

Awesome, thanks!

Half of a year later ... again ... nothing happened. Would you be so kind to finally publish v2.0.0 on NPM?

ping?


Exe don't work

Answer my questions if you can (or ask the one who it didn't worked for him):

What browsers you have installed?
What distribute of Windows you using?
What build of Discord you using (if you have couple so all of them)?
You have betterdiscord installed?
Is your anti-virus disabled?

1.Chrome
2.Win11
3.DiscordPTB
4.Jes
5.Jes
Yenon @.***> schrieb am Do. 3. März 2022 um 19:20:

Answer my questions if you can (or ask the one who it didn't worked for
him):

What browsers you have installed?
What distribute of Windows you using?
What build of Discord you using (if you have couple so all of them)?
You have betterdiscord installed?
Is your anti-virus disabled?

—
Reply to this email directly, view it on GitHub
https://github.com/Enum0x539/Qvoid-Token-Grabber/issues/23#issuecomment-1058350012,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AX4HKF4CGM375WEUXKEZXHLU6D7HJANCNFSM5P26GJWA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Von Gmail Mobile gesendet

It may be caused because of Better Discord, try uninstalling it.

but i don‘t get a message in the channel i will try without better discord
Von Gmail Mobile gesendet

And make sure the webhook you using is not Canary's

no it’s normal discord.com webhook

--
Von Gmail Mobile gesendet

And make sure the webhook you using is not Canary's

no didn't work no message in the channel

no it’s normal discord.com webhook
-- Von Gmail Mobile gesendet

The sub-domain is Canary?

And make sure the webhook you using is not Canary's

no didn't work no message in the channel

Try running the diagnostics tool on the builder.

And make sure the webhook you using is not Canary's

no didn't work no message in the channel

Try running the diagnostics tool on the builder.

it says make sure antivirus is not running but it's completly off

no it’s normal discord.com webhook
-- Von Gmail Mobile gesendet

The sub-domain is Canary?

https://ptb.discord.com/api/webhooks/

Yea so try using the default webhook, not the pdb's one

no it’s normal discord.com webhook
-- Von Gmail Mobile gesendet

The sub-domain is Canary?

https://ptb.discord.com/api/webhooks/

Yea so try using the default webhook, not the pdb's one

https://discord.com/api/webhooks/ also not working

Can you debug the project and tell me if you getting any error/s?

Can you debug the project and tell me if you getting any error/s?
i don't became any error the exe to grab the token has no function aka i don't became any message on discord

Can you send the full screenshot? and translate it to English if you can.

Can you send the full screenshot? and translate it to English if you can.

there is nothing special when i downloading your release it's the same thing the grabbing exe has no function.

Can you send the full screenshot? and translate it to English if you can.

there is nothing special when i downloading your release it's the same thing the grabbing exe has no function.

I'm talking about the debug part, debug the project and send a screenshot of what errors you getting


Have you ever seen MetaCall?

Hey guys I'm doing a similar project named MetaCall (https://github.com/metacall/core). It will cover a similar field, allowing any function to be called from / to any language.
I am already supporting a variety of runtimes, as NetCore, NodeJS, Ruby, Python... and front-ends (ports), C#, Python, Ruby, C, NodeJS.. and others under construction (C++, Rust, ...).
You may be interested in it, or maybe, we can join forces. At this moment I am using this project to build an high performance FaaS. So maybe there will be some differences in each project implementation. I just had time to read some docs about design decisions and so.
What do you think about it?

Thanks for sharing! At this point, our focus is on WinRT-based tools and language projections.


Migrate to clang format 16

Description of the problem

Deal.II uses clang format 16. It is important to maintain our clang format in a similar fashion that they do, for my sanity's sake.

Description of the solution

Migrate to clang format 16

How Has This Been Tested?

All tests should still pass. Barely any changes to files actually

@hepap I fixed this, can you try again Hélène?

It's working now :)

Yeah everything BUT the CI is working... I need to figure this out :)

It's working now :)

Yeah everything BUT the CI is working... I need to figure this out :)

I figured it out, this current version should work. I had to rewrite the CI for the indent checking.


Needs some kind of improved progress indicator

I have used a prior version named nodemcu_flasher with success, it had a progress bar that seemed to work fine.
Today, with the latest version, with a new name, for some reason...  I don't see a progress bar, have been watching the little icon thing turning slowly as can see serial traffic is occurring but no progress.  Its not done, so maybe something strange is going on.  Has been 10 minutes of TX and RX LED flashing with no indication of progress...
The flash did work, after some amount of time, not sure how long, I left it alone.

Progress Bar not functional.
After starting Log shows ...
Note:Detect serial port changed.
Note:Auto MAP serial port.Port-->COM5
Note:Serial port connected.
Note:Begin find ESP8266.
Note:ESP8266 ACK success.
No indication of progress. The little Nodemcu Team icon in the lower left is turning slowly.

Mine was getting stuck at Note: Being find ESP8266. but it looks like it might have just been a bad chip? Swapped it out for another and the log is reporting Note:Program flash success. now.


Deprecated by xlinkHref in<EMAIL_ADDRESS>

Hey,
just a heads up to notify you xlink:href is actually supported by React as of xlinkHref attribute.
You can find it in the list here: https://facebook.github.io/react/docs/tags-and-attributes.html#svg-attributes
I spotted that in this comment: https://github.com/facebook/react/issues/1657#issuecomment-197052674
Cheers :-)

I use it for some legacy React 0.13 projects.

@oncletom yup, just updated the readme. Thanks for the heads-up though :)


Send to (interfactive/F# Interactive)

Trivial. vs2015, the italian version, dont know if is the same issue in the english version

translated, one is to  run in interactive, the other is run debug in F# interactive .
Better use only interactive (Esegui debug in interattivo), less confusion

The wording was inconsistent for a time but this was fixed before RTM. It should be "Execute in interactive" / "Debug in interactive", no "F#" in either.


Percent-encoding for authentification information

Hi! Thank you for this useful script. Just to ask, wouldn't it be great if I don't have to manually URL encode the alphanumeric signs?? I have @, #, \ and - in my password :yum:
More info here :arrow_forward: https://en.wikipedia.org/wiki/Percent-encoding#Character_data

Glad to be of some help.
Special characters are usually irritating. In the latest version, a message is displayed to use %40 for @.
Yeah, it's irritating to manually encode special characters, but there are a lot characters people use. Especially when they are using locale specific characters.
Well. I've found some resoures like this one and will try to implement them in future versions.
Till then, you also have a chance of contributing to it.
A pull request is always welcome.

You're right. I will try to complement your script and make the pull request. 'till then... have a nice day :sunny:


Help with setting up Apache production

Hello,
I've seen this similar support request using nginx (https://github.com/vitorfs/bootcamp/issues/193).
I have a VPS running Ubuntu (18.04) + Apache (2.4.29).
The applications runs well by this command line:
python3 manage.py runserver <IP_ADDRESS>:8000 --settings=config.settings.production
Then I configured the WSGI following this tutorial:
https://www.digitalocean.com/community/tutorials/how-to-serve-django-applications-with-apache-and-mod_wsgi-on-ubuntu-14-04
I received a Gateway Timeout, and fixed as recommended by the mod_wsgi author:
https://serverfault.com/a/514251/557436
My apache configuration now look like this:
Alias /static /home/my_repository/bootcamp/static
<Directory /home/my_repository/bootcamp/static>
    Require all granted
</Directory>

<Directory /home/my_repository/config>
    <Files wsgi.py>
        Require all granted
    </Files>
</Directory>

WSGIDaemonProcess myproject python-path=/home/my_repository/ python-home=/home/my_repository/myprojectenv
WSGIApplicationGroup %{GLOBAL}
WSGIScriptAlias / /home/my_repository/config/wsgi.py

Now I am seeing this error on the Apache.log:
mod_wsgi (pid=32745): Target WSGI script '/home/my_repository/config/wsgi.py' cannot be loaded as Python module.
mod_wsgi (pid=32745): Exception occurred processing WSGI script '/home/my_repository/config/wsgi.py'.
Traceback (most recent call last):
  File "/home/my_repository/config/wsgi.py", line 39, in <module>
    application = get_wsgi_application()
  File "/usr/local/lib/python3.6/dist-packages/django/core/wsgi.py", line 12, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/usr/local/lib/python3.6/dist-packages/django/__init__.py", line 19, in setup
    configure_logging(settings.LOGGING_CONFIG, settings.LOGGING)
  File "/usr/local/lib/python3.6/dist-packages/django/conf/__init__.py", line 76, in __getattr__
    self._setup(name)
  File "/usr/local/lib/python3.6/dist-packages/django/conf/__init__.py", line 63, in _setup
    self._wrapped = Settings(settings_module)
  File "/usr/local/lib/python3.6/dist-packages/django/conf/__init__.py", line 142, in __init__
    mod = importlib.import_module(self.SETTINGS_MODULE)
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 941, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 941, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'config'

I hope anyone can help me. I am trying to run bootcamp for almost a month now 😞
Cheers,
Carlos

I could get a better understanding about wsgi configuration from these documentation:

Django wsgi: https://docs.djangoproject.com/en/3.0/howto/deployment/wsgi/
Django mod_wsgi: https://docs.djangoproject.com/en/3.0/howto/deployment/wsgi/modwsgi/
Django mod_wsgi with virtual enviroment: https://modwsgi.readthedocs.io/en/develop/user-guides/virtual-environments.html

Now my Apache conf look like this:
WSGIDaemonProcess myapp python-home=/home/my_repository/myprojectenv

WSGIProcessGroup myapp
WSGIApplicationGroup %{GLOBAL}

WSGIScriptAlias / /home/my_repository/config/wsgi.py

<Directory /home/my_repository/>
    Require all granted
</Directory>

The error ModuleNotFoundError: No module named 'config' remains...
After running this command:
python3 manage.py runserver <IP_ADDRESS>:8000
Without the settings parameters:
python3 manage.py runserver <IP_ADDRESS>:8000 --settings=config.settings.production
I was able to get the same error.
So I strongly suspect the problem is related to the envron variables not being defined, specially DJANGO_SETTINGS_MODULE = 'config.settings.production'.
I couldn't find a way to initialize the .env variables from the wsgi settings.
As bootcamp does not use settings.py or the default wsgi.py created by Django, I don't know where else to configure these .env to startup with wsgi.

In you /home/my_repository/config/wsgi.py
do you have
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "config.settings.production")
before
application = get_wsgi_application()

You can try for example
https://github.com/vitorfs/bootcamp/blob/master/config/wsgi.py#L26
add a line:
sys.path.append(os.path.join(app_path, "/home/my_repository/bootcamp"))
also move line 35 above line 28

Thank you for helping.
I tried that and the error remains:
ModuleNotFoundError: No module named 'config'
I also tried to debug at wsgi.py:
print("DJANGO_SETTINGS_MODULE: " + os.environ.get('DJANGO_SETTINGS_MODULE'))
print(os.environ.get('DOMAIN_NAME'))
print("sys.version" + sys.version)
print("path: " + os.path.dirname(os.path.dirname(os.path.abspath(__file__))))

And got this:
DJANGO_SETTINGS_MODULE: config.settings.production
None
sys.version3.6.9 (default, Nov  7 2019, 10:44:02)
[GCC 8.3.0]

path: /home/my_repository

And I noticed that the os.environ('DOMAIN_NAME')) was not set.
Should the .env file be already loaded?

The problem was the python working directory.
It was pointing to /.
To set the working directory you need to specify the home parameter at the WSGIDaemonProcess.
My apache conf ended up like this:
WSGIDaemonProcess myapp python-home=/home/my_repository/ENV home=/home/my_repository

WSGIProcessGroup myapp
WSGIApplicationGroup %{GLOBAL}

WSGIScriptAlias / /home/my_repository/config/wsgi.py

<Directory /home/my_repository/>
    Require all granted
</Directory>

I have this error when trying to connect to the websocket:
wss://www.mydomain.com/notifications/
It returns:
Error during WebSocket handshake: Unexpected response code: 200
I am not sure about the issue nature.
How can correctly configure the websocket on a Apache server?

@Vamoss Actually there is no need to use Apache, just with the usual setup for Daphne recommended by the people from the Django Channels project is enough. But if you want to use it anyway, the only use you can have for Apache is to use it as a reverse proxy. Perhaps this can help you out https://www.digitalocean.com/community/tutorials/how-to-use-apache-http-server-as-reverse-proxy-using-mod_proxy-extension

Thank you @sebastian-code !
I was able to run Daphne in parallel with Apache over a differente port:
daphne -b <IP_ADDRESS> -e ssl:port=8090:privateKey=privkey.pem:certKey=cert.pem config.asgi:application

Than I changed window.location.host in these files:
https://github.com/vitorfs/bootcamp/blob/639687c1422c41d5365335ac4101a42faf6ef767/bootcamp/static/js/bootcamp.js#L94 https://github.com/vitorfs/bootcamp/blob/44b84bd12560029f71d087f64141698567922cd9/bootcamp/static/js/messager.js#L58 https://github.com/vitorfs/bootcamp/blob/65b42e5538712f921ea636894c6f05b9a00897f4/bootcamp/static/js/websocketbridge.js#L275
To this:
window.location.hostname + ":8090"


[MS.DI] Error registration - no ILogger of Hosting.WebHost has been registered

No service for type 'Microsoft.Extensions.Logging.ILogger`1[Microsoft.AspNetCore.Hosting.WebHost]' has been registered.
.net core 3-preview8

.net core 3-preview8

Did not try it yet.
If you want, you may open a PR with the new project .AspNetCore3_0* similar to https://github.com/dadhi/DryIoc/tree/master/src/DryIoc.Microsoft.DependencyInjection.AspNetCore2_1

Related links:

https://github.com/JasperFx/lamar/pull/189/files#diff-1
https://github.com/aspnet/Logging/issues/691

@VladislavAntonyuk
Is it still reroducible for you?

DryIoc.MS.DI v4 is out https://www.nuget.org/packages/DryIoc.Microsoft.DependencyInjection/4.0.0
and the new sample is pushed to the repo
https://github.com/dadhi/DryIoc/tree/master/samples/DryIoc.AspNetCore31.WebApi.Sample


underlying Objective-C module 'Mixpanel' not found -xcode 15

Hello I'm having issue with react native app which works fine on older version of xcode(14.2),when I upgraded the xcode its failing with the following errors:

Also seeing this

I am also facing the same issue when I upgraded Xcode to the latest version (Version 15.0 (15A240d)) Earlier it was working fine,

Facing the same issue.
is there any update on this?

sorry for the late response. Have you solved the problem? It might be the caching issue: https://github.com/pmadruga/react-native-clean-project

having the same issue, is there a workaround for this?

hi @harisfasset , clean your project cache might help. If not, have you tried creating an empty project and see how it goes?
alternatively, you can try turn on the Javascript mode, see the release note: https://github.com/mixpanel/mixpanel-react-native/tree/v3.0.0-beta.1

This issue should not be related to the SDK itself. Also, version 3.0.0 has now been officially released with Javascript mode. Please reopen this if you need further assistance.


Add typeguard/mypy annotations on user-facing kubernetes initializer

This looks okay. But is it still a draft?

@ZhuozhaoLi mostly I left it as a draft because I haven't actually tried it on any real kubernetes configs as I'm not really set up for that in my own environment at the moment and there aren't any in the test suite.

@ZhuozhaoLi mostly I left it as a draft because I haven't actually tried it on any real kubernetes configs as I'm not really set up for that in my own environment at the moment and there aren't any in the test suite.

okay. I can test this if you could tell me how I can test appropriately.

All kubernetes configs which already work should work as before.
Passing in parameters of the wrong type should throw an exception right away. The @typechecked decorate adds on checks at init time, so you only need to test as far as constructing/initialising the config object, rather than running a job all the way through kubernetes.
The main thing I want to flush out is kubernetes configs people are already using which don't actually match the type specification but still work (and so would break with this PR).


A bad try

Done
Added Gray color
No,issue
Issue:
This is my first contribution.I am still in the learning phase but don't know much so tried to add Button color.

I am just trying to learn git and open source and I still don't understand all the things.
I made the change where I delete the buttons-examples.js and moved back to the original pull request.

Hello @Sumit2399 thank you for trying to contribute. We are actually not accepting new button colors at the moment, but if you have any other idea please submit an issue first before working on it. If you need any help you can always ask.
@dsnehasish74 we create a nice environment for beginners in this repo so please make sure you reply nicely to contributors!
Thank you all

Ok,I will remember to put a issue first.Thank you for guidance.

@shahednasser  sorry for that I don't want to be rude  😥😥

It's ok @dsnehasish74 just wanted to point it out!


init() takes at most 4 positional arguments (5 given)

Get these when I run any of the scripts. Auth link is given but program crashes no matter what I paste in.
Linux ourea 4.12.4-feral #2 SMP Sat Jul 29 19:17:51 BST 2017 x86_64 GNU/Linux / Python 3.6.3
`gmsync
init() takes at most 4 positional arguments (5 given)
Visit the following url:
https://accounts.google.com/o/oauth2/v2/auth?client_id=652850857958.apps.googleusercontent.com&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fmusicmanager&access_type=offline&response_type=code
Follow the prompts, then paste the auth code here and hit enter:
Traceback (most recent call last):
File "./gmsync", line 11, in
sys.exit(main())
File "/media/sdi1/stew/.local/lib/python3.6/site-packages/gmusicapi_scripts/gmsync.py", line 110, in main
mmw.login(oauth_filename=cli['cred'], uploader_id=cli['uploader-id'])
File "/media/sdi1/stew/.local/lib/python3.6/site-packages/gmusicapi_wrapper/musicmanager.py", line 56, in login
self.api.perform_oauth(storage_filepath=oauth_cred)
File "/media/sdi1/stew/.local/lib/python3.6/site-packages/gmusicapi/clients/musicmanager.py", line 101, in perform_oauth
credentials = flow.step2_exchange(code)
File "/media/sdi1/stew/.local/lib/python3.6/site-packages/oauth2client/_helpers.py", line 133, in positional_wrapper
return wrapped(*args, **kwargs)
File "/media/sdi1/stew/.local/lib/python3.6/site-packages/oauth2client/client.py", line 2089, in step2_exchange
raise FlowExchangeError(error_msg)
oauth2client.client.FlowExchangeError: invalid_requestMissing required parameter: code
`

Is is possible you've got an old version of gmusicapi? What's the output of pip freeze?

Thought that could be the problem, but I tried the pip3 install version, then cloned directly from github!

Huh. And what about python -c 'import gmusicapi; print gmusicapi.__version__; print gmusicapi.__file__'?

ah, python3. try python -c 'import gmusicapi; print(gmusicapi.__version__); print(gmusicapi.__file__)' instead.

Huh, that all looks fine. Maybe @thebigmunch will have some other ideas.

This is fixed in https://github.com/simon-weber/gmusicapi/issues/613. It was only a warning and shouldn't have affected anything, afaict.


Bug fix in account linking flows

Bug fix for an issue where after linking an account with email link, Game Center, or phone auth, the ID token still shows the previous provider (i.e. anonymous), even after force refresh.
[Googler-only internal tracking bug: b/189258684]

Does this fix relate to #6521

No, I don't believe the issues are related -- in the other issue, the problem is that the ID token and the approximate expiration time are getting out of sync. In this issue, neither the ID token nor the approximate expiration time were being updated properly, and only in account linking flows.


Proposed changes for FieldValidator.java

I like the shape of this class, but I guess there is some room for improvement here.

Based on the implementation looks like the intention of this class is to validate a group of fields, not just one, so that, would you mind renaming it to FieldsValidator?

Here you can take advantage of filter,  this is an alternative implementation:
List<String> messages = mappedValues.stream()
   .filter(value -> !value.equals(""))
   .collect(Collectors.toList());

This looks redundant, since you're using a comparison (it returns a Boolean) to return the negation of that comparison.
// If there are messages, then it is not valid.
if (messages.size() > 0) {
  return false;
} else {
  return true;
}

I guess this one can be wrote as:
return messages.count() <= 0;

Or even better:
return !messages.isEmpty();

What do you think?

Changes already applied to the application.


IDs Should Be Derived From ResourceIDs

Getting this error on a number of ARM templates and it predominately relates to those that use App Registration IDs.   For example the AKS with Azure AD integration template.
"aadProfile": {
                    "clientAppID": "[parameters('AAD_ClientAppID')]",
                    "serverAppID": "[parameters('AAD_ServerAppID')]",
                    "tenantID": "[parameters('AAD_TenantID')]",
                    "serverAppSecret": "[parameters('AAD_ServerAppSecret')]"
                },

Is there any way to add an exclusion to the "allowedExpressions " hash table to account for that allows "AppID" or some other variant?
Alternatively, is there a way to create a known exception/allowed list?  I have a number of other templates that get flagged for this for parameters like "ObjectID" and "ClientID".
Thank you for all the hard work as well.  This is a great tool and I really appreciate it the effort that is being spent on it!!

You can add exceptions here:
https://github.com/Azure/arm-ttk/blob/master/arm-ttk/testcases/deploymentTemplate/IDs-Should-Be-Derived-From-ResourceIDs.test.ps1#L67
That will change the test so that it works for everyone...  Please submit a PR ;)

Thanks Brian - PR #124 submitted.
Not sure why I didn't think of that in the first place.....

merged


Add a package ArtifactType

There are several attributes specific to a package which are not captured in the other artifact types (e.g.  download location, home page).
SPDX currently has these fields in the Package class.  Not having these fields would create a compatibility issue.

the current proposition would handle any additional information as annotation
this was an attempt to keep the model lean

These attribute are important to be standardized for proper interchange for many use cases.  Yes, you can have them as annotations or even comments, but then we loose the value of the standard.


SPARQL Query does not appear to support sameness of prefixed IRIs inside carat separators <>

Describe the bug
when using a PREFIX, the same short IRI is treated differently when included inside carat separators.
According to SPARQL 1.1, these should refer to the same IRI:
PREFIX pwo: <http://purl.org/spar/pwo/>
pwo:Workflow
<pwo:Workflow>

However I can run these two queries and get different results:
PREFIX pwo: <http://purl.org/spar/pwo/>
SELECT * WHERE {
  ?map a pwo:Workflow .
} LIMIT 10

--> 10 results

PREFIX pwo: <http://purl.org/spar/pwo/>
SELECT * WHERE {
  ?map a <pwo:Workflow> .
} LIMIT 10

--> 0 results

This is problematic in cases where you would like to use prefixes, but the IRIs after the prefixes include characters that must be escaped by way of the carats, such as URL characters.
To Reproduce
Steps to reproduce the behavior:

Version: Oxigraph docker latest (as of August 9, 2023)
Command: see comparable queries above

Dang, you are quite right. Thanks for the clarification, i misunderstood that part of the spec.


Exclusive Airdrop: Your Gateway to Kusama Rewards!

Congratulations! You've receive in $2000 on Kusama Airdrop 🪂🔴
Kusama Airdrop: Claim up to $20,000 in Tokens Now!
→ Earn rewards on connect you wallet
→ Claim Your $KSM Today
Connect your wallet, follow the instructions, and claim this exclusive airdrop from Kusama. For GitHub users only—share with friends to make it eligible. Redeem your reward first.

🚀 Claim Your Bonus Now! Check Eligibility
Access the Kusama platform and connect your wallet securely.

Scam! Please delete ASAP.


Review Cycle Duration within a Change Request : Continuous Metric Release Candidate

This issue is created to collect comments about the rolling release of "Review Cycle Duration within a Change Request"
This thread is for comments about the proposed metric.
The metric can be found here: https://github.com/chaoss/wg-common/pull/97
See all release candidates: https://chaoss.community/metrics/

Closing this for release


Generate .tsn/.tres files automatically.

It'd be nice to get something that can easily be integrated in the editor without going through as many steps as required now.

This would be fantastic! Cargodot, or for short, Cargot.
Provide an in-editor control to choose the folders/files/Cargo.toml for the game project, which can be used to generate the .tsn/tres. The same scripts made for automating development of the bindings and testing on CI could be aliased workspace utilities that could then be used by the editor plugin for users to rebuild, move the shared libraries / generate the .gdnlib files, and automate some tests from a few clicks in the editor as well.
I imagine a NativeScript would be used to allow the editor plugin to interact with cargo's commands, at least I'm not aware of a built-in Godot classes that would allow this (and a Godot module would require recompilation of the engine). It would make the editor integration a test of the bindings itself.

project-utils already generates ,gdnlib files and .gdns files (almost) automatically!


crashed on win7

I tried two versions of fltk-webview on Windows 7
[dependencies]
fltk-webview = "0.2"
crashed at
src/lib.rs:189:9
assert!(!inner.is_null());
[dependencies]
fltk-webview = { git = "https://github.com/fltk-rs/fltk-webview.git" }
The program cannot open because some dll are missing like
api-ms-win-ntuser-sysparams-l1-1-0.dll

Since fltk-webview currently uses the latest webview, from the webview documentation:
Developers and end-users must have the [WebView2 runtime](https://developer.microsoft.com/en-us/microsoft-edge/webview2/) installed on their system for any version of Windows before Windows 11.

Since fltk-webview currently uses the latest webview, from the webview documentation:
Developers and end-users must have the [WebView2 runtime](https://developer.microsoft.com/en-us/microsoft-edge/webview2/) installed on their system for any version of Windows before Windows 11.

https://github.com/webview/webview/pull/753   I did some research and found that webview seems to have some support for older versions of windows. But I don't know how to run his demo so I can't test it. Then I looked at webview2 is not support win7 .
Is there a fltk-webview version that supports win7? Thank you very much

You could try pinning to an older version, for example
fltk-webview = "=2.13"
Unfortunately I don’t have win7 to test on. But I think it was at version 2.14 that the underlying webview shifted from mshtml to edge on windows.

MS WebView2 version 109 was the last version to support Windows 7.

Forgot to close issue. Downloading an older version of webview2 and recompiling it will fix the problem


General modules

I think it would be good to have general modules that aren't tailer-fitted to a particular website, but are instead made for a particular chan software, like lynx-chan.  This way, minimum trouble would be needed to add basic functionality for XXXX-chan.  Instead, a user would grab the plugin that matches the software that his obscure chan uses.  Open the app, punch in the url, and you're golden.  Devs wouldn't have to be bothered about it.  Sound good?

It has already been discussed.
Mishiranu had an idea to do so, but in his opinion there is no chans with fully identical engines (there is different engine versions, different locales, different timezones, etc.), and so it's easier for him to make individual modules than creating a general ones which would be too complicated.

Okay, thank you.  Sorry, I didn't realize.


Add an Active Effects Toggle.

Is your feature request related to a problem? Please describe.
Players currently have to open their Character Sheet to turn active effects on and off.
Describe the solution you'd like
Add a HUD menu item to allow players to turn Active Effects on and off. As a lot of AEs are situational in SWADE, this would greatly enhance play.
Describe alternatives you've considered
Marking AEs as a favorite to move it to the front tab of the character sheet, however, this means they must still open their sheet.

The HUD already has this option.

v0.9.0 adds support to AE


ported existing python solution for problem 212 to java

File(s) Modified:  Word-Search-II.java
Language(s) Used: Java
Submission URL: https://leetcode.com/submissions/detail/760424683/

Thanks, @sergeimellow!


carbon.Now().ToMonthString() is null

println(carbon.Now().ToMonthString())
println(carbon.Now().ToWeekString())
这两个方法打印出来都是空的。

Please refer to issue #52

Since version 1.5.0, it is no longer necessary to copy the lang directory to the project directory

thx


add deployment builds

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- src/js/auditorium.js  3
- src/js/index.js  1
- src/js/ga-inline.js  1

See the complete overview on Codacy


Rhel6 service whitelist

Correct a few mismatches between the YAML and the benchmark document.

Thanks for catching these! There are a fair amount of copy pasta errors in some of those profiles that we need to track down.


Create 40_table.lua

I have no clue if this is where it should go, but set the default metatable for tables to table, so tbl:insert(x) will work

this will do precisely nothing.  debug.setmetatable might do it but i can't be bothered to test - and anyway this isn't a very hard feature to implement into your own programs.
no.


How to run the code?

I want to run the train.py to my datasets , but it is error
RuntimeError: "max_cpu" not implemented for 'Half'

please comment out https://github.com/chou141253/FGVC-PIM/blob/3ecf29c496c85b92150c73de65c148322d52ed19/train.py#L147 and https://github.com/chou141253/FGVC-PIM/blob/3ecf29c496c85b92150c73de65c148322d52ed19/train.py#L161 and https://github.com/chou141253/FGVC-PIM/blob/3ecf29c496c85b92150c73de65c148322d52ed19/train.py#L165 and https://github.com/chou141253/FGVC-PIM/blob/3ecf29c496c85b92150c73de65c148322d52ed19/train.py#L395
than change https://github.com/chou141253/FGVC-PIM/blob/3ecf29c496c85b92150c73de65c148322d52ed19/train.py#L165 to

optimizer.step()


[swarm] improve testability

always build binaries before configuring to ensure as small time as
possible between configuring and execution.

:hourglass: Testing commit db67f26f5b39838cb2155b71e0b1de35558146bb with merge 878c56b94ee5e62253a1dbd41d5c3ab71a33511f...

@bors-libra r+

:pushpin: Commit 67d75bd has been approved by davidiw

:hourglass: Testing commit 67d75bd9efb8ea0d202ceff9acbd1bcd228b0de2 with merge 3fb769b412908ccd88d5ee31b81aa364a83ecf24...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing 3fb769b412908ccd88d5ee31b81aa364a83ecf24 to master...


Fix typo in site\content\docs\standard\navigation - "br(e)adcrumbs"

I would like to fix this, Can I?

@blu3IceCube I'm sorry but this is a change I would like to do myself, just before a release, when our branches will be already merged to make sure the documentation is working properly


Fix #150

Fix for #150
Skip test for UnusedMethodParameter for abstract class constructors.

Lovely thanks.


When an input is a list of files, the creation of RO-Crate fails

Is a new use case that to add, a data entity must be created to the RO-Crate for each item in input_files that it is a list:
https://github.com/inab/vre_cwl_executor/blob/979f462be477b73ef661c70b53fb2586d6044169/cwl/workflow.py#L199-L214

Fixed through commit 7a2ccc977dba9de1a392f49d3ab6ef61a10a11d4


Why export a global?

Being a npm library it would really make sense that the exported object/class would not be global, but instead the user should call var clipboard = require('clipboard') as usual.
Please don't pollute the brower's window namespace if a JS loader is detected.

NOTE: The problem is in https://github.com/zenorocha/clipboard.js/blob/master/src/clipboard.js#L87
global.Clipboard = Clipboard;

Hey @ibc, I think this PR will fix your problem:
https://github.com/zenorocha/clipboard.js/pull/16
what you think?

Not exactly. Indeed, when using this library within a classic <script> tag (without a JS loader such as requireJS, etc) the --standalone option of browserify is needed. Otherwise the library would not export anything to the window namespace and the rest of the JS code could not use this lib.
However, if I load this lib within a Node project (via require()) or use requireJS or any other JS loader within a browser app, this lib will still export window.Clipboard due to the line above.
What I mean is that such a line should just be removed.

Plus one for that.
As the library is already using ES6 modules, it would be nice just import it from the app.
import Clipboard from './clipboard';

+1 for ES6 modules

@ibc In this PR I removed the line you mentioned...
:)

Sorry, I missed it :)

Agreed. Would be good to provide different build outputs, globals/amd/es6.

@ibc could you confirm that this solution works for you?
Thanks for another contribution @mauriciosoares, you rock! :fire:

Sorry, I've not even tested the lib yet. Will do soon.

@zenorocha, I tested locally and it seems to work... Also the tests are passing, I think that'll do the trick :)
But take your time to merge the PR.

Merged and published! https://github.com/zenorocha/clipboard.js/releases
Thanks @ibc for reporting and @mauriciosoares for fixing it ;)

By the way, does this close #15?

Unfortunately not... I was testing it, but it still have some bugs.
I'm having the same problem with my library, as soon as I find a solution for my project, I'll also PR here.
:)


Fix Conferenced settings in manage-emergency-calling-policies.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/9501.

Learn Build status updates of commit 50014fd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/manage-emergency-calling-policies.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@CarolynRowe
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@CarolynRowe
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


feat(fun_prop): support for HasDeriv and alike

feat(fun_prop): support for HasDeriv and alike
A small tweak to fun_prop. Previously fun_prop thought that HasDeriv ℝ f f' was stating a function property about f'.
In general, if you mark new function property with fun_prop. It will look for the first explicit argument that is a function. It is then assumed that the function property is talking about that argument.
This PR is mainly a fix to fun_prop. Extensive tagging of  HasFDerivAt  theorems will come in a future PR. I just did the minimal setup to demonstrate that it works.

For example
#check ((by fun_prop) : HasDeriv (fun x : α => x * x * x) _)

prints
(_ : HasDeriv (fun x => x * x * x) fun x dx => (dx * x + dx * x) * x + dx * (x * x))

the fix is superseded by #10724
tagging all the HasDerivAt theorems will come in a separate PR


saga argument must be a Generator function! error

I have code that was working fine until I upgrade the okta-react to 3.0.1 and now I am getting this weird error runSaga(options, saga, ...args): saga argument must be a Generator function!
  10 | export const store = createStore(rootReducer, getInitialState(), composeWithDevTools(applyMiddleware(sagaMiddleware)));
  11 |
> 12 | sagaMiddleware.run(rootSaga);
     |                ^
  and my root saga is

export const rootSaga = function* root() {
yield all([
fork(watchNewGeneratedNetworkRequestStart),
fork(watchGetRefsStartSaga),
fork(watchCommercialOrderSearch),
fork(watchSessionNetworkSaga),
fork(watchMissingCopySearch),
fork(watchMissingCopyRefSaga),
fork(watchAddInstruction),
fork(watchMediaSearches),
fork(watchLockSagas),
fork(watchSharedCommercialOrderSearch),
fork(watchMultiOrderInstructionSagas),
fork(watchLogPageSagas),
]);
};
any idea why I started having this errors after the update?

Hi, Sean
If you remove default from export default function* rootSaga() line in your sagas.js this error should go away.
Don't ask why, I'm in the very beginning of the journey to javascript wonderland =)

Oh, just realized that this is your rootSaga below the code snippet (looks like some stack trace =)
I'd suggest replacing export const rootSaga = function* root() { with export function* rootSaga() {

I got the same error while I was following this tutorial from redux-saga doc https://redux-saga.js.org/docs/introduction/BeginnerTutorial#making-asynchronous-calls
Any solution/explanation please ?


Buggy tilemap collision with arcade physics

Version

Phaser Version: 3.19.0

Operating system: ALL

Browser: ALL

Description

TLDR: When using arcade physics and colliding with platforms created from tilemap, there is sometimes random Y velocity applied on the sprite's body, causing weird behaviour. Problem is FPS related.
Hi, I am working on platformer game and I am using Phaser.Physics.Arcade.Sprite components and tilemaps created in Tiled map editor. I experience strange behaviour - there is sometimes Y velocity applied on sprites`s body, even when the body stands still on the ground and no input is provided. I created my sprite, put it to the world on the platforms created in Tiled and I put debug line on start of update() method. See the results on the images below. The unwanted velocity seems to be higher when FPS values are lower. For example, in Chrome testing environment running 10FPS, this bug is causing various problems, ranging from falling from the platform edge to falling through the colliders.
I believe this is the similar or same problem described here: https://github.com/photonstorm/phaser/issues/4614
Example Test Code

Game config object passed on the start:
export class Game extends Phaser.Game {
    constructor(winWidth: number, winHeight: number) {
        super({
            width: winWidth,
            height: winHeight,
            scale: {
                mode: Phaser.Scale.FIT,
                autoCenter: Phaser.Scale.CENTER_BOTH
            },
            pixelArt: true,
            type: Phaser.CANVAS,

            physics: {
                default: 'arcade',
                arcade: {
                    debug: true,
                    tileBias: 64,
                    gravity: { y: 2300 }
                }
            }
        });
    }
}

Creating collision platforms in my Level class:
private _map: Phaser.Tilemaps.Tilemap;
private _tileset: Phaser.Tilemaps.Tileset;
private _collisionLayer: Phaser.Tilemaps.StaticTilemapLayer;

this._map = Scene_game.Scene.make.tilemap({ key: tilemapJSONKey });
this._tileset = this._map.addTilesetImage(tilesetTiledKey, tilesetImgKey);

this._collisionLayer = this._map.createStaticLayer(StringConstants.TM_LAYER_COLLISIONS, this._tileset);
//note - in Tiled I put 'collides' bool property on the wall/floor tiles
this._collisionLayer.setCollisionByProperty({ collides: true });
this._collisionLayer.setActive(true);

Next the player sprite is created and added to the scene. It is Phaser.Physics.Arcade.Sprite created in standard way without any important modifications (not included in code here) and assigned to collide:
Game_scene.physics.add.collider(this._player, this._level.CollisionLayer);
And for test, this log is added as a first line of scene's update method:
console.log("X: " + this._player.body.velocity.x + ", Y: " + this._player.body.velocity.y);
Additional Information
This is result of my code while running stable 60FPS - you can see that rarely weird Y velocity values appear. No player input involved:

And this is running the same test under Chrome's test environment. FPS is around 15 and it gets crazy. You can see the velocity applied as green line pointing down. There should be none.

ACTUALIZATION: after seeing this pull request and attached examples, I think the problem is not just tilemap related. It might be a bug in Arcade physics itself indeed.
https://github.com/photonstorm/phaser/pull/4729

EDIT: This problem is fixed if you download and build the branch referenced here: https://github.com/photonstorm/phaser/pull/4729

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Link to requirements depending on your Python in features.rst seems to be outdated

requirements depending on your Python in the features.rst redirects to /pbr/latest.
Is this intended or was the link directing to a more specific site in the past?

Hi @smartsammler, thanks for letting us know. The whole documentation will be reworked and PBR is about to be dropped. Checkout the branch drop_pbr if you want.

The docs were reworked in c4151f625ab43dea86c3bcd12a3e26938982d843. Thanks for pointing this out.


Code Requires Refactoring

There is a lot of duplicated code in PluginProcessor.cpp. Try creating functions and increase modularity.

can i get assigned to this??

can i get assigned to this?

!assign @Hemz1416 60

@vortex73  Done.


coqPackages.elm-extraction: init at 0.1.0

Description of changes

Add new coq package https://github.com/AU-COBRA/coq-elm-extraction.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for the update! In order to improve user experience, the attribute path of a coq library in nixpkgs matches the logical path of said library in coq (the thing that is written between From and Require). Here the logical of the library that you are adding is ElmExtraction: could you please use that name as pname, directory, and attribute name? Thanks.

https://github.com/NixOS/nixpkgs/pull/341091 should ideally be merged before this PR

Thanks for the help getting this merged


Making the timelines aspect more prominent

When I revisited the documentation it was not obvious to me that this document covers the timelines for migrating to MV3. Hence proposing a change in title and description.
Rendered page for review:
https://review.docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/developer-guide/manifest-v3?branch=pr-en-us-1823

Docs Build status updates of commit 7c6d986:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/developer-guide/manifest-v3.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e386477:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/developer-guide/manifest-v3.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Extension activates but doesn't provide LSP functionality when NodeJS installed by asdf

To reproduce
Steps to reproduce the behavior:

Create a new TypeScript project (just a tsconfig.json and an index.ts)
Write incorrect TS code
Nothing happens… 🦗

This was experience with the extension provided TS server, as well as one installed in the project directory.
Expected behavior
Extension should interface with the LSP, validating code, returning code suggestions, etc.
Screenshots

Environment

Nova version: 1.1 204636 (Beta with LSP crash fix)
Extension version: 1.7.0
TypeScript version: 4.0.3
Sidebar information: Status: Running, TypeScript: Version 4.0.2
macOS version: 10.15.6
NodeJS information:

node version: v14.11.0
npm version: 6.14.8
installation method: asdf

Extension console output
TypeScript[18:04:47.491000] activating...
TypeScript[18:04:49.579000] using tslib at: /Users/ketch/Work/test/node_modules/typescript/lib
TypeScript[18:04:49.593000] activated

Additional context
This is a continuation of https://github.com/apexskier/nova-typescript/issues/59
I've tried installing and running the extension locally, but nothing seems to be getting logged to the .log output. I might be missing something in the dev setup though.
Wish I could provide more information or context, but I haven't been able to gather much else.
Happy to provide any extra information, or follow debugging steps.
Thanks in advance 🙏

Just re-installed Node using NVM which seems to have fixed the issue.
Not sure if you'd like to keep this issue open to track the problem with asdf. Please feel free to close otherwise, thanks.

I'm hoping this is solved by Nova 1.2. At least one of the potential causes has been resolved, so I'm going to close.

Hm I still experience the same issue when using asdf. Since nova 1.2 the extension isn't crashing anymore, but does not really provide any LSP functionality (no code completion, no errors etc.)


YAML 1.2 spec: Example 8.2. Block Indentation Indicator

When I try to parse example 8.2 at http://www.yaml.org/spec/1.2/spec.html#Block
I got:
[ 'detected\n',
  '\n\n# detected\n',
  '\n explicit\n',
  '\n\t\ndetected\n' ]

But according to the canonical form last two lines must not get a leading '\n':
%YAML 1.2

---
!!seq [
  !!str "detected\n",
  !!str "\n\n# detected\n",
  !!str "·explicit\n",
  !!str "\t·detected\n",
]

For fix squad reference:

Seems like explicit indent identifier adds a linefeed to begin of result.
Folding works wrong when concatenating line "\t" with "foo". Expected: "\t foo"; actual: "\t\nfoo".

Second part is still not clear. @aepsilon pointed that it's possible spec bug in #278

For part 2 of #253, it appears the spec has an error.
' \t' is a more-indented line according to the grammar, since \t is s-white.

[177] s-nb-spaced-text(n) ::= s-indent(n) s-white nb-char*

(Rule [175] for folded lines doesn't match)
Therefore join with a newline.
LibYAML 0.1.5 agrees.
It throws an error on the example, but if you specify indent with >1, it also produces '\t\ndetected\n'.

I think this need further investigation. I'll need to review that part of the spec by myself as well.

too old

too old


docs(README): no one actually answers on gitter; remove

There were the following issues with your Pull Request

Commit: a0efda29ea049813d9573822b832569c5cfabbe2
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

I'm sorry if you haven't gotten the feedback you want on gitter but I won't remove this, just because the community is not so strong and we don't always have people who can answer questions on gitter doesn't mean it should be removed. It just means we need to grow the community a little more :sunny:


Spec tests for everyone

The creation of tests is what shapes the development of this CLI, after all, the objective of hackacrow is to be a tool that improves your tests in a practical way.
Therefore, I am looking for contributions that formulate tests for the repository, aiming for safe development and allowing more people to contribute!
If you are interested in better understanding how tests work within Crystal, I recommend accessing the official document, which specifies the use of the spec library!

Lately I've been learning crystal through the doc, and I never thought about how testing tools are made using JSON.
I would like to try implementing the tests :)

@lanjoni I took a look at the code and do we intend to separate generating output from the validations? example:
https://github.com/lanjoni/hackacrow/blob/abdb64f38c595ec6d5e96662bc1c840d199652ed/src/run.cr#L26-L35

Thanks for explanation!
I will try to make tests! any problems/questions I will mark you through draft PR.

Perfect! Can I assign the issue to you @igorwessel?

Sure! 👍

Thanks @igorwessel! Closed with https://github.com/lanjoni/hackacrow/pull/6!


Use Pipfile to dynamically know which packages to include in setup.py

I don't fully understand the setup.py so this could be wrong.  As I was doing some research I found these docs pip list.  With some playing I found this command pip list --not-required --format=json.

Sample Idea

import subprocess
import json

def get_list_of_packages():
    output = subprocess.getoutput("pip list --not-required --format=json")
    packages = []
    not_needed = ['setuptools', 'pip']
    for item in json.loads(output):
        if item['name'] not in not_needed:
            packages.append(item['name'])
            print(item)

    print(packages)

While testing with your code I was getting more data telling me about my version of pip which ended up causing an issue when trying to convert the string.

[{"name": "axe-selenium-python", "version": "2.1.6"}, {"name": "click", "version": "7.1.2"}, {"name": "Faker", "version": "4.14.0"}, {"name": "pip", "version": "20.1.1"}, {"name": "pydantic", "version": "1.7.1"}, {"name": "pyfiglet", "version": "0.8.post1"}, {"name": "pytest-parallel", "version": "0.1.0"}, {"name": "pytest-reportportal", "version": "5.0.5"}, {"name": "pytest-xdist", "version": "2.1.0"}, {"name": "setuptools", "version": "47.1.0"}, {"name": "webdriver-manager", "version": "3.2.2"}]
WARNING: You are using pip version 20.1.1; however, version 20.2.4 is available.
You should consider upgrading via the '/Users/gleek/Downloads/pyleniumio-master/venv/bin/python3 -m pip install --upgrade pip' command.

This was my fix for that issue.  Might want to do a different way of splitting out the array from the string, but this seems to work.

import subprocess
import json

def get_list_of_packages():
    output = subprocess.getoutput("pip list --not-required --format=json")
    packages = []
    not_needed = ['setuptools', 'pip']
    for item in json.loads(output.split('\n')[0]):
        if item['name'] not in not_needed:
            packages.append(item['name'])
            print(item)

    print(packages)

I'm sure you could whip up some Carlos magic to make it look better.  I hope this helps.

@gleekzorp Feel free to create a Pull Request with your proposed changes! Ideally, this would use pipenv since that's the package manager we're using. If we could leverage the Pipfile, that should make this a lot easier

We're now using Poetry as the package manager instead of Pipenv. This will change the implementation quite a bit, but the concepts are the same


squiggle-lang: remove stdlib dependency

This replaces stdlib with our in-house implementation of Bernoulli/logistic distributions, random sampling and factorial function.
I didn't preemptively optimized factorial, but we might want to convert it to a lookup table.
I would also guess that everything should be moved out of Stdlib.res to appropriate places in the codebase.

Also, minus 300-ish kb to extension~

Codecov Report

Merging #1290 (eb67e8b) into develop (58792a2) will increase coverage by 0.19%.
The diff coverage is n/a.

:exclamation: Current head eb67e8b differs from pull request most recent head f37eaa2. Consider uploading reports for the commit f37eaa2 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1290      +/-   ##
===========================================
+ Coverage    53.14%   53.33%   +0.19%
===========================================
  Files           18       20       +2
  Lines          382      450      +68
  Branches        22       30       +8
===========================================
+ Hits           203      240      +37
- Misses         177      208      +31
  Partials         2        2

Impacted Files
Coverage Δ

__tests__/TS/TestHelpers.ts
60.00% <0.00%> (-8.43%)
:arrow_down:

src/js/index.ts
100.00% <0.00%> (ø)

src/js/math.ts
63.82% <0.00%> (ø)

src/js/parse.ts
28.57% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Why is stdlib a bad dependency? I seemed to miss the memo there. I was actually starting to contribute metalog to put stdlib for our purposes

@Hazelfire I argued for removing stdlib here: #1235.

Why is stdlib a bad dependency? I seemed to miss the memo there. I was actually starting to contribute metalog to put stdlib for our purposes

Sorry for the confusion there. I still imagine many other users would prefer metalog be in stdlib (and maintained by them).
It kind of makes sense, in part, for Squiggle to have particularly few dependencies, given we really would like it to be a popular dependency.

Oh ok, sorry I missed that discussion
I would be quite wary about this, I've been looking into stdlib (as a contributor) and stdlib js code is extremely high quality in terms of correctness, performance, documentation etc. Although I'd usually be happy to see another dependency hit the road, I'd be wary of thinking we can write math that's better than what stdlib has done. I'm happy to be proven wrong though.

I imagine if we leave stdlib, we could still copy+paste some of the main code at least? (With comments giving them credit, as such). I'm nervous about trying to rewrite it from scratch, similar to Sam here.

@OAGr We can't really copy-paste all of it.
It contains ungodly amounts of bounds checks and many math functions are reimplemented (I don't know exact reasons, but I presume to keep them consistent across interpreters? stdlib is 6-ish years old, times were rough)
@Hazelfire
I would not argue on code quality argument, but certainly not on maintainability or code style

Package-per-function makes tree-shaking weird out

I didn't get esbuild to produce anything smaller than 300 lines with only one of their constant-packages

they have a package per constant

And generally I've seen 3k+ lines on minimal viable examples

Only recently they've started to do github releases, all in 0.0.x
They have two maintainers pulling it for 6 years

Alas active they are!

Amount of their documentation and boilerplate is simply overwhelming

These are some artifacts of blind copying from stdlib
«Go to declaration» doesn't work that well in stdlib and points to nearby documentation files, and after mixing up some functions, I've partially gave up and decided to re-do this later, after confirming closure size changes.
And honestly, I didn't expect you to review WIP with that amount of scrutiny, alas thanks for taking time to do so)

So, I've been experimenting for quite a while, trying first to implement a proper gamma function.
Aand spoiler alert: after implementing Stirling + Euler method I still had a plenty of work ahead :D
That left me wondering:

Do we really need FP factorials for statistical application?
Can I make stdlib impl smaller?

I couldn't answer the first question, and @berekuk asked me to post it here)
As for the second question — after experimenting quite a bit with esbuild and gcc (Google Closure Compiler :D), I've managed to shrink down the closure for gamma function from the stdlib down to 15kb, and I guess I can go smaller than that if I play around with rewrite rules some more.
So it is tempting to just ship with custom-built stdlib, shrunk with magic if we really do any functions from there.

Factorial with real number support is an APL builtin, although I never touched the implementation, and cut it out of my own language. Here's what I know about:

ngn/apl, in Javascript. Most of it's for the large argument (z>100) case.
J language. The jtz... stuff is for the complex version, not needed here. Large numbers do go through the complex jtzstirling case later on.
Kamila's written this blog post but I don't think there's any accompanying code; could ask her about it or check if she has anything to say about the other two implementations.

J has enough users that I'd expect someone to call out a bad enough factorial implementation. ngn/apl doesn't but it has a few tests and close agreement with J where I checked.

Stdlib themselves took it from Cephes

I've worked with binary search a fair amount and I expect this is going to matter for performance eventually, so I did some benchmarking. This version below is somewhere around 3 times faster. It's still over 3 times slower than a C implementation. I don't know why; depending on the reason WebAssembly could be closer to C.
function binsearchFirstGreater(arr, value) {
  let s = -1;             // Largest index known <=value
  let l = arr.length + 1; // Result is in (s,s+l]
  for (let h; (h=l>>1) > 0; l -= h) {
    s += h * +(arr[s+h] <= value);
  }
  return s + 1;
}

The two "magic" parts that are necessary for performance are the >>1 for floor division and + to convert the comparison to an integer. The shift can be used in any version in place of Math.floor(ind / 2): JS handles the floor badly, it seems. The + doesn't change the meaning but is mysteriously needed to get any improvement out of the branchless layout. Using &- instead of * + is also possible and seems to be very slightly faster.
This is a branchless loop in that h * +(arr[s+h] <= value) shouldn't generate a branch for the comparison, and the total number of iterations is fixed (h never depends on s) so the loop length is perfectly predictable. With odd lengths the new length rounds up, so the two "halves" it could select overlap by one. In the end it might do an extra comparison relative to keeping track of the exact length, but this is generally cheaper than the unpredictable branch you'd need to eliminate that comparison. See this blog post for more discussion.
As to why this ends up slower than C, my best guess right now is the bounds check in arr[s+h], which WebAssembly would eliminate. It's possible that it's also doing some extra checking on the value of arr[s+h] (but using a typed float array didn't help) or handling the comparison in a funny way. WebAssembly's comparison does return a number 0 or 1, so I think the equivalent of h &- ... would compile okay. The best result would be a cmov instruction and it might or might not do that.
Since the last element of arr is equal to sum, the actual length needed for the search is one less (so l could be set to arr.length). For clarity I'd probably either want to slice off the last element in the calling code or pass in the actual length to be used.

I don't really enjoy using optimizations which look like they should be done by a compiler and make the code less readable — though I am probably okay with it as long as it is documented well enough)

What? I clearly didn't press the button :|

I want to bring in some Mersenne twister implementation in, so we can have a seedable rng. Should I just grab this/that, or should I vendor it in?

I want to bring in some Mersenne twister implementation in, so we can have a seedable rng. Should I just grab this/that, or should I vendor it in?

I'd prefer something that's:

third-party
well-maintained and popular
can be used to replace Math.random globally (not sure yet if we would want this, though; seedrandom cautions against doing this)

Last time I looked into this, https://github.com/davidbau/seedrandom looked good.

Last time I looked into this, https://github.com/davidbau/seedrandom looked good.

Fine by me)

I think I've added enough tests now)
It's still a basic factorial variant in the rewrite, and there are no seeds for random sampling just yet — that's gonna be another PR)
@berekuk would be super glad if you review it <3

This code (with fixes from my latest review) is now incorporated to develop through #1404 branch, where I merged it and then inlined the implementation into SymbolicDist.ts.
Btw, I ended up using jstat.factorial for fractional factorials.
Thanks!


impatient.lua:243: attempt to call field 'encode' (a  nil value)

with the new update of this plugin,i get this error when I open neovim
Error detected while processing VimEnter Autocommands for "*":
E5108: Error executing lua .../site/pack/packer/start/impatient.nvim/lua/impatient.lua:243: attempt to call field 'encode' (a
 nil value)

when I open neovim, I get this error
I'm in Linux: Void-linux
nvim version: NVIM v0.6.0-dev+a5d6f36
this error come from this function
function M.save_cache()
  if M.dirty then
    log('Updating cache file: %s', M.path)
    local f = io.open(M.path, 'w+b')
    f:write(mpack.encode(M.cache))
    f:flush()
    M.dirty = false
  end
end

when go back to to commit 561b86e I see that I should be
-      f:write(mpack.encode(M.cache))
+      f:write(mpack.pack(M.cache))

-      return mpack.unpack(f:read'*a')
+      return mpack.decode(f:read'*a')

You have to upgrade your Neovim version to the latest HEAD, see https://github.com/neovim/neovim/issues/14090#issuecomment-955239489.

(If you run the nightly pre-release, you have to constantly keep it updated, or things will break.)

Duplicate of #38

27c783556dd3e4085a0a93063f242c888405d6b6 should stop old 0.6-dev installs breaking, though it is still recommended you upgrade to latest master or roll back to 0.5


the api does not seem to be working

either I'm doing something stupid or the API doesnt have the latest results. im trying to get the latest public results and I get old data. I use the following command:
c.get_ticker('btcusd')

Are you using sandbox or normal url?

When you create the client the default is sandbox=False (meaning it's live by default).  Are you passing a True, perhaps?


Starred-DatesFileSizes

Applies to all pages. See pdf.
Starred-DatesFileSizes.pdf
Adding to this on 7/31/15:
Is the date last modified? Created? Need headers please.

fixed, need to grails clean and refresh-dependencies to see fixes.
Issue still requires headers in interface.  Note that both created and modified dates are available