hwinfo: 21.78 -> 21.80

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/hwinfo/versions.
meta.description for hwinfo is: "Hardware detection tool from openSUSE"
meta.homepage for hwinfo is: "https://github.com/openSUSE/hwinfo"
meta.changelog for hwinfo is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80/bin/getsysinfo passed the binary check.
/nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80/bin/check_hd passed the binary check.
/nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80/bin/convert_hd passed the binary check.
/nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80/bin/hwinfo passed the binary check.
Warning: no invocation of /nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80/bin/mk_isdnhwdb had a zero exit code or showed the expected version
3 of 5 passed binary check by having a zero exit code.
3 of 5 passed binary check by having the new version present in output.
found 21.80 with grep in /nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80
found 21.80 in filename of file in /nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
hwinfo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A hwinfo https://github.com/r-ryantm/nixpkgs/archive/0096067d52cc3859dfccbbc8fd12e645286e9f1d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80
ls -la /nix/store/pz19dhi21di6x6a9g3f4zbdh215f5xdc-hwinfo-21.80/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

hwinfo

Maintainer pings
cc @bobvanderlinden for testing.

Change looks good to me

Donot close the open tray after read_cdrom_info.
fix logic around cdrom detection

Change looks good to me

Donot close the open tray after read_cdrom_info.
fix logic around cdrom detection


Chameleon UI just doesn't work

Description

Like #25219, chameleon gear just doesnt show any option when opening the UIs
Reproduction

Try to use chameleon gear
Screenshots

Additional context

could be related to #25219

Yeah, we admins are getting a lot of ahelps regarding it.

pretty sure this is resolved as all chameleon clothes work atm

Seems to be fixed now.


Test3

Checking analysis of application shiftleft-java-demo against 1 build rules.
Using sl version 0.9.2070 (53e7344f3a6fc703c52832505930e9148c9a9d17).
Checking findings on scan 20.
Results per rule:

No critical or high SAST findings: FAIL
(13 matched vulnerabilities; configured threshold is 0).
First 5 findings:

ID
CVSS
Rating
Title

93
9.0
critical
Remote Code Execution: Code Injection Through Attacker-controlled Data via foo in SearchController.doGetSearch

94
9.0
critical
Directory Traversal: Attacker-controlled Data Used in File Path via request in CustomerController.checkCookie

95
9.0
critical
Directory Traversal: Attacker-controlled Data Used in File Path via request in CustomerController.saveSettings

73
8.0
high
Deserialization: Attacker-controlled Data Used in Unsafe Deserialization Function via request in AdminController.doGetPrintSecrets

74
8.0
high
Deserialization: Attacker-controlled Data Used in Unsafe Deserialization Function via auth in AdminController.doPostLogin

Severity rating
Count

Critical
3

High
10

Medium
0

Low
0

Category
Count

Cross-Site Scripting
8

Directory Traversal
2

Deserialization
2

Remote Code Execution
1

OWASP 2021 Category
Count

A03-Injection
9

A08-Software-And-Data-Integrity-Failures
2

A01-Broken-Access-Control
2

1 rule failed.


[Divider] Support "middle" variant with "vertical" orientation

(Using 4.11.2) The Divider component applies
.MuiDivider-middle {
  margin-right: '16px';
  margin-left: '16px';
}

When the orientation is vertical, this doesn't do anything helpful. It would make sense to add margin-top and margin-bottom to have a similar effect for vertical dividers.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

It would make sense to add margin-top and margin-bottom to have a similar effect for vertical dividers. Here is the CSS I use in the example below to achieve something like what I want.
.MuiDivider-vertical.MuiDivider-middle {
  margin-top: 1%;
  margin-bottom: 1%;
}

Examples 🌈

This is the behavior I would like to achieve, which I'm able to do with the code above.

Motivation 🔦

This is just a nice-to-have look and feel. I'm using it with Tabs and it makes the distinction between tabs in a Desktop experience more apparent.

@PanopticaRising This makes sense. It does make sense with the semantic of the props. Regarding the actual style. I wonder if we shouldn't use some fixed pixels values.

Hi, can I take this issue?


hipchat support and dep as dependency tool

Looks like a huge PR because of dependency changes, other than that simple changes to support hipchat.
Refer to sample screenshot

Kindly provide comments
I am not quite sure about supporting >= 1.8 golang change, is that reasonable to ask?

we should move to newer version of golang anyway
just a bit concerned with that docker/distribution dependency, why is that needed ?

Its not a new dependency, following from the godeps
I can dig more whats pulling it in once i get to work
{
"ImportPath": "github.com/docker/distribution/digest",
"Comment": "docs-v2.4.1-2016-06-28-16-g07f32ac",
"Rev": "07f32ac1831ed0fc71960b7da5d6bb83cb6881b5"
},

coming from kubernetes client:
find . -name '*.go' | grep -v docker | xargs grep 'docker/distribution'
./vendor/k8s.io/client-go/pkg/util/parsers/parsers.go:	dockerref "github.com/docker/distribution/reference"

@sebgoa let me know if you have more questions

no that's fine, I will merge your PR thanks a lot.
We can probably clean up a lot of the dependencies by moving to client-go

awesome, thanks very much for merging this.
can u let me know what do u mean by "We can probably clean up a lot of the dependencies by moving to client-go".
may be i can try this out later this week
between, i do plan to use this in our deployment of k8s cluster. is the new image pushed automatically?

Hi @rajatjindal thank a bunch for supporting hipchat. The new image is not pushed automatically yet. I just pushed it to dockerhub at skippbox/kubewatch:v0.0.4. A PR for client-go will be very welcomed 👍

BTW, a switch to use dep is good. I am open to learn a new "vendoring" tool :-)


WLS2 Ubuntu 22.04

Possible install-time or require-time problem

[x] I have read and understood all of the documentation relating to installation.

You must confirm both of these before continuing.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest,
please open an issue against that package instead.

[x] I am using Node.js with a version that satisfies ^18.17.0 || ^20.3.0 || >=21.0.0

If you cannot confirm any of these,
please upgrade to the latest version
and try again before opening an issue.
Are you using a supported package manager and installing optional dependencies?

[x] I am using npm >= 9.6.5 with --include=optional

If you cannot confirm any of these, please upgrade to the latest version of your chosen package manager
and ensure you are allowing the installation of optional or multi-platform dependencies before opening an issue.
What is the complete error message, including the full stack trace?

What is the complete output of running npm install --verbose --foreground-scripts sharp in an empty directory?

make: Entering directory '/home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build'
touch Release/obj.target/libvips-cpp.stamp
g++ -o Release/obj.target/sharp/src/common.o ../src/common.cc '-DNODE_GYP_MODULE_NAME=sharp' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_GLIBCXX_USE_CXX11_ABI=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DBUILDING_NODE_EXTENSION' -I/home/john/.cache/node-gyp/21.6.1/include/node -I/home/john/.cache/node-gyp/21.6.1/src -I/home/john/.cache/node-gyp/21.6.1/deps/openssl/config -I/home/john/.cache/node-gyp/21.6.1/deps/openssl/openssl/include -I/home/john/.cache/node-gyp/21.6.1/deps/uv/include -I/home/john/.cache/node-gyp/21.6.1/deps/zlib -I/home/john/.cache/node-gyp/21.6.1/deps/v8/include -I../../../../nan -I/usr/include/libgsf-1 -I/usr/include/libxml2 -I/usr/include/x86_64-linux-gnu/ImageMagick-6 -I/usr/include/ImageMagick-6 -I/usr/include/orc-0.4 -I/usr/include/OpenEXR -I/usr/include/openjpeg-2.4 -I/usr/include/poppler/glib -I/usr/include/poppler -I/usr/include/librsvg-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/openslide -I/usr/lib/x86_64-linux-gnu/hdf5/serial/include -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/x86_64-linux-gnu -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -fPIC -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++17 -std=c++0x -fexceptions -Wall -O3 -Wno-cast-function-type -MMD -MF ./Release/.deps/Release/obj.target/sharp/src/common.o.d.raw   -c
In file included from /home/john/.cache/node-gyp/21.6.1/include/node/v8-handle-base.h:8,
from /home/john/.cache/node-gyp/21.6.1/include/node/v8-local-handle.h:12,
from /home/john/.cache/node-gyp/21.6.1/include/node/v8-array-buffer.h:12,
from /home/john/.cache/node-gyp/21.6.1/include/node/v8.h:24,
from /home/john/.cache/node-gyp/21.6.1/include/node/node.h:73,
from ../src/common.cc:22:
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h: In static member function ‘static constexpr int v8::internal::SmiTagging<4>::SmiToInt(v8::internal::Address)’:
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h:86:3: error: body of ‘constexpr’ function ‘static constexpr int v8::internal::SmiTagging<4>::SmiToInt(v8::internal::Address)’ not a return-statement
86 |   }
|   ^
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h: In static member function ‘static constexpr int v8::internal::SmiTagging<8>::SmiToInt(v8::internal::Address)’:
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h:111:3: error: body of ‘constexpr’ function ‘static constexpr int v8::internal::SmiTagging<8>::SmiToInt(v8::internal::Address)’ not a return-statement
111 |   }
|   ^
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h: In function ‘void v8::internal::PerformCastCheck(T*)’:
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h:976:38: error: ‘remove_cv_t’ is not a member of ‘std’; did you mean ‘remove_cv’?
976 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                      ^~~~~~~~~~~
|                                      remove_cv
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h:976:38: error: ‘remove_cv_t’ is not a member of ‘std’; did you mean ‘remove_cv’?
976 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                      ^~~~~~~~~~~
|                                      remove_cv
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h:976:50: error: template argument 2 is invalid
976 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                                  ^
/home/john/.cache/node-gyp/21.6.1/include/node/v8-internal.h:976:63: error: ‘::Perform’ has not been declared
976 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                                               ^~~~~~~
In file included from /home/john/.cache/node-gyp/21.6.1/include/node/v8-object.h:9,
from /home/john/.cache/node-gyp/21.6.1/include/node/v8-array-buffer.h:13,
from /home/john/.cache/node-gyp/21.6.1/include/node/v8.h:24,
from /home/john/.cache/node-gyp/21.6.1/include/node/node.h:73,
from ../src/common.cc:22:
/home/john/.cache/node-gyp/21.6.1/include/node/v8-maybe.h: At global scope:
/home/john/.cache/node-gyp/21.6.1/include/node/v8-maybe.h:106:27: error: ‘std::enable_if_t’ has not been declared
106 |   template <class U, std::enable_if_t<!std::is_lvalue_reference_v>>
|                           ^~~~~~~~~~~
/home/john/.cache/node-gyp/21.6.1/include/node/v8-maybe.h:106:38: error: expected ‘>’ before ‘<’ token
106 |   template <class U, std::enable_if_t<!std::is_lvalue_reference_v>>
|                                      ^
/home/john/.cache/node-gyp/21.6.1/include/node/v8-maybe.h:123:25: error: ‘std::enable_if_t’ has not been declared
123 | template <class T, std::enable_if_t<!std::is_lvalue_reference_v>* = nullptr>
|                         ^~~~~~~~~~~
/home/john/.cache/node-gyp/21.6.1/include/node/v8-maybe.h:123:36: error: expected ‘>’ before ‘<’ token
123 | template <class T, std::enable_if_t<!std::is_lvalue_reference_v>* = nullptr>
|                                    ^
In file included from ../src/common.cc:22:
/home/john/.cache/node-gyp/21.6.1/include/node/node.h:687:8: error: ‘optional’ in namespace ‘std’ does not name a template type
687 |   std::optionalstd::string builder_script_path;
|        ^~~~~~~~
/home/john/.cache/node-gyp/21.6.1/include/node/node.h:687:3: note: ‘std::optional’ is only available from C++17 onwards
687 |   std::optionalstd::string builder_script_path;
|   ^~~
/home/john/.cache/node-gyp/21.6.1/include/node/node.h:739:28: error: ‘std::string_view’ has not been declared
739 |     Environment* env, std::string_view main_script_source_utf8);
|                            ^~~~~~~~~~~
make: *** [sharp.target.mk:178: Release/obj.target/sharp/src/common.o] Error 1es/favicons/node_modules/sharp (node install/
make: Leaving directory '/home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/john/Sites/steel/slicing/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (node:events:519:28)
gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:294:12)
gyp ERR! System Linux <IP_ADDRESS>-microsoft-standard-WSL2
gyp ERR! command "/home/john/.nvm/versions/node/v21.6.1/bin/node" "/home/john/Sites/steel/slicing/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp
gyp ERR! node -v v21.6.1
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok

What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
System:
OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
CPU: (8) x64 Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
Memory: 6.28 GB / 7.70 GB
Container: Yes
Shell: 5.1.16 - /bin/bash
Binaries:
Node: 21.6.1 - ~/.nvm/versions/node/v21.6.1/bin/node
npm: 10.2.4 - ~/.nvm/versions/node/v21.6.1/bin/npm
I got the issue when I am installing the sharp

@lovell Could you help me resolve the issue?

make: Entering directory '/home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build'

It looks like you're installing favicons rather than sharp.
Please provide the complete output of running npm install --verbose --foreground-scripts sharp in an empty directory.

@lovell
npm WARN deprecated<EMAIL_ADDRESS>Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>Use the original unforked package instead: postcss-markdown
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This module is no longer supported.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>this package is now deprecated
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm http fetch GET 200 https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.665.tgz 9065ms (cache miss)
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm http fetch GET 200 https://codeload.github.com/bem-tools/bem-tools-core/tar.gz/9a5c91b198a7ce1f2a6b6e64c505aefead27fc8f 4701ms (cache revalidated)
npm http fetch GET 200 https://codeload.github.com/bem-tools/bem-tools-create/tar.gz/bee9b839b6c89b956464be0cf8057d40f332f832 4715ms (cache revalidated)
npm WARN deprecated<EMAIL_ADDRESS>This SVGO version is no longer supported.
Extracting tar contents (via spawned process)
Removing /home/john/Sites/steel/slicing/node_modules/phantomjs-prebuilt/lib/phantomde_modules/phantomjs-prebuilt node insta
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1707534895212/phantomjs-2.1.1-linux-x86_64 -> /home/john/Sites/steel/slicing/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js fileeify:core-js: info run<EMAIL_ADDRESS>install node_modules/phantomjs-prebuilt node insta
Done. Phantomjs binary available at /home/john/Sites/steel/slicing/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
npm info run<EMAIL_ADDRESS>install { code: 0, signal: null }
npm info run<EMAIL_ADDRESS>install node_modules/sharp node install/check

<EMAIL_ADDRESS>install
node install/check

npm info run<EMAIL_ADDRESS>install { code: 0, signal: null }
npm info run<EMAIL_ADDRESS>install node_modules/favicons/node_modules/sharp (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)

<EMAIL_ADDRESS>install
(node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)

info sharp Detected globally-installed libvips v<IP_ADDRESS>.4 install node_modules/favicons/node_modules/sharp (node install/
info sharp Building from source via node-gyp
gyp info it worked if it ends with ok info run<EMAIL_ADDRESS>install node_modules/favicons/node_modules/sharp (node install/
gyp verb cli [
gyp verb cli   '/home/john/.nvm/versions/node/v20.10.0/bin/node',
gyp verb cli   '/home/john/Sites/steel/slicing/node_modules/.bin/node-gyp',
gyp verb cli   'rebuild'
gyp verb cli ]
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb find Python Python is not set from command line or npm configurationles/favicons/node_modules/sharp (node install/
gyp verb find Python Python is not set from environment variable PYTHON
gyp verb find Python checking if "python3" can be used
gyp verb find Python - executing "python3" to get executable path
gyp verb find Python - executable path is "/usr/bin/python3"install node_modules/favicons/node_modules/sharp (node install/
gyp verb find Python - executing "/usr/bin/python3" to get version
gyp verb find Python - version is "3.10.12"
gyp info find Python using Python version 3.10.12 found at "/usr/bin/python3"
gyp verb get node dir no --target version specified, falling back to host node version: 20.10.0
gyp verb command install [ '20.10.0' ]
gyp verb install input version string<EMAIL_ADDRESS>install node_modules/favicons/node_modules/sharp (node install/
gyp verb install installing version: 20.10.0
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version is already installed, need to check "installVersion"
gyp verb got "installVersion" 11
gyp verb needs "installVersion" 9-js: info run<EMAIL_ADDRESS>install node_modules/favicons/node_modules/sharp (node install/
gyp verb install version is good
gyp verb get node dir target node version installed: 20.10.0
gyp verb build dir attempting to create "build" dir: /home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build
gyp verb build dir "build" dir needed to be created? Yes
gyp verb build/config.gypi creating config file
gyp verb build/config.gypi writing out config file: /home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build/config.gypi
gyp verb config.gypi checking for gypi file: /home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/config.gypi
gyp verb common.gypi checking for gypi file: /home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/common.gypi
gyp verb gyp gyp format was not specified; forcing "make"
gyp info spawn /usr/bin/python3
gyp info spawn args [
gyp info spawn args   '/home/john/Sites/steel/slicing/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/john/Sites/steel/slicing/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/john/.cache/node-gyp/20.10.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/home/john/.cache/node-gyp/20.10.0',
gyp info spawn args   '-Dnode_gyp_dir=/home/john/Sites/steel/slicing/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/home/john/.cache/node-gyp/20.10.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp verb command build []ify:core-js: info run<EMAIL_ADDRESS>install node_modules/favicons/node_modules/sharp (node install/
gyp verb build type Release
gyp verb architecture x64
gyp verb node dev dir /home/john/.cache/node-gyp/20.10.0
gyp verb which succeeded for make /usr/bin/make
gyp info spawn make
gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build'
touch Release/obj.target/libvips-cpp.stampun<EMAIL_ADDRESS>install node_modules/favicons/node_modules/sharp (node install/
g++ -o Release/obj.target/sharp/src/common.o ../src/common.cc '-DNODE_GYP_MODULE_NAME=sharp' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DBUILDING_NODE_EXTENSION' -I/home/john/.cache/node-gyp/20.10.0/include/node -I/home/john/.cache/node-gyp/20.10.0/src -I/home/john/.cache/node-gyp/20.10.0/deps/openssl/config -I/home/john/.cache/node-gyp/20.10.0/deps/openssl/openssl/include -I/home/john/.cache/node-gyp/20.10.0/deps/uv/include -I/home/john/.cache/node-gyp/20.10.0/deps/zlib -I/home/john/.cache/node-gyp/20.10.0/deps/v8/include -I../../../../nan -I/usr/include/libgsf-1 -I/usr/include/libxml2 -I/usr/include/x86_64-linux-gnu/ImageMagick-6 -I/usr/include/ImageMagick-6 -I/usr/include/orc-0.4 -I/usr/include/OpenEXR -I/usr/include/openjpeg-2.4 -I/usr/include/poppler/glib -I/usr/include/poppler -I/usr/include/librsvg-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/openslide -I/usr/lib/x86_64-linux-gnu/hdf5/serial/include -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/x86_64-linux-gnu -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -fPIC -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++17 -std=c++0x -fexceptions -Wall -O3 -Wno-cast-function-type -MMD -MF ./Release/.deps/Release/obj.target/sharp/src/common.o.d.raw   -c
In file included from /home/john/.cache/node-gyp/20.10.0/include/node/v8-local-handle.h:12,
from /home/john/.cache/node-gyp/20.10.0/include/node/v8-array-buffer.h:12,
from /home/john/.cache/node-gyp/20.10.0/include/node/v8.h:24,
from /home/john/.cache/node-gyp/20.10.0/include/node/node.h:73,
from ../src/common.cc:22:
/home/john/.cache/node-gyp/20.10.0/include/node/v8-internal.h: In function ‘void v8::internal::PerformCastCheck(T*)’:
/home/john/.cache/node-gyp/20.10.0/include/node/v8-internal.h:893:38: error: ‘remove_cv_t’ is not a member of ‘std’; did you mean ‘remove_cv’?
893 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                      ^~~~~~~~~~~
|                                      remove_cv
/home/john/.cache/node-gyp/20.10.0/include/node/v8-internal.h:893:38: error: ‘remove_cv_t’ is not a member of ‘std’; did you mean ‘remove_cv’?
893 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                      ^~~~~~~~~~~
|                                      remove_cv
/home/john/.cache/node-gyp/20.10.0/include/node/v8-internal.h:893:50: error: template argument 2 is invalid
893 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                                  ^
/home/john/.cache/node-gyp/20.10.0/include/node/v8-internal.h:893:63: error: ‘::Perform’ has not been declared
893 |             !std::is_same<Data, std::remove_cv_t>::value>::Perform(data);
|                                                               ^~~~~~~
In file included from /home/john/.cache/node-gyp/20.10.0/include/node/v8-object.h:9,
from /home/john/.cache/node-gyp/20.10.0/include/node/v8-array-buffer.h:13,
from /home/john/.cache/node-gyp/20.10.0/include/node/v8.h:24,
from /home/john/.cache/node-gyp/20.10.0/include/node/node.h:73,
from ../src/common.cc:22:
/home/john/.cache/node-gyp/20.10.0/include/node/v8-maybe.h: At global scope:
/home/john/.cache/node-gyp/20.10.0/include/node/v8-maybe.h:106:27: error: ‘std::enable_if_t’ has not been declared
106 |   template <class U, std::enable_if_t<!std::is_lvalue_reference_v>>
|                           ^~~~~~~~~~~
/home/john/.cache/node-gyp/20.10.0/include/node/v8-maybe.h:106:38: error: expected ‘>’ before ‘<’ token
106 |   template <class U, std::enable_if_t<!std::is_lvalue_reference_v>>
|                                      ^
/home/john/.cache/node-gyp/20.10.0/include/node/v8-maybe.h:123:25: error: ‘std::enable_if_t’ has not been declared
123 | template <class T, std::enable_if_t<!std::is_lvalue_reference_v>* = nullptr>
|                         ^~~~~~~~~~~
/home/john/.cache/node-gyp/20.10.0/include/node/v8-maybe.h:123:36: error: expected ‘>’ before ‘<’ token
123 | template <class T, std::enable_if_t<!std::is_lvalue_reference_v>* = nullptr>
|                                    ^
In file included from ../src/common.cc:22:
/home/john/.cache/node-gyp/20.10.0/include/node/node.h:711:28: error: ‘std::string_view’ has not been declared
711 |     Environment* env, std::string_view main_script_source_utf8);
|                            ^~~~~~~~~~~
In file included from ../src/common.cc:24:
../../../../nan/nan.h: In function ‘bool Nan::IdleNotification(int)’:
../../../../nan/nan.h:688:63: warning: ‘bool v8::Isolate::IdleNotificationDeadline(double)’ is deprecated: Use MemoryPressureNotification() to influence the GC schedule. [-Wdeprecated-declarations]
688 |     return v8::Isolate::GetCurrent()->IdleNotificationDeadline(
|            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
689 |         idle_time_in_ms * 0.001);
|         ~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/john/.cache/node-gyp/20.10.0/include/node/v8-initialization.h:13,
from /home/john/.cache/node-gyp/20.10.0/include/node/v8.h:34,
from /home/john/.cache/node-gyp/20.10.0/include/node/node.h:73,
from ../src/common.cc:22:
/home/john/.cache/node-gyp/20.10.0/include/node/v8-isolate.h:1293:8: note: declared here
1293 |   bool IdleNotificationDeadline(double deadline_in_seconds);
|        ^~
make: *** [sharp.target.mk:183: Release/obj.target/sharp/src/common.o] Error 1es/favicons/node_modules/sharp (node install/
make: Leaving directory '/home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/john/Sites/steel/slicing/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (node:events:514:28)
gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:294:12)
gyp ERR! System Linux <IP_ADDRESS>-microsoft-standard-WSL2
gyp ERR! command "/home/john/.nvm/versions/node/v20.10.0/bin/node" "/home/john/Sites/steel/slicing/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp
gyp ERR! node -v v20.10.0
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok
npm info run<EMAIL_ADDRESS>install { code: 1, signal: null }
npm verb stack Error: command failed
npm verb stack     at ChildProcess. (/home/john/.nvm/versions/node/v20.10.0/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:53:27)
npm verb stack     at ChildProcess.emit (node:events:514:28)
npm verb stack     at maybeClose (node:internal/child_process:1105:16)
npm verb stack     at ChildProcess._handle.onexit (node:internal/child_process:305:5)
npm verb pkgid<EMAIL_ADDRESS>npm verb cwd /home/john/Sites/steel/slicing
npm verb Linux <IP_ADDRESS>-microsoft-standard-WSL2
npm verb node v20.10.0
npm verb npm  v10.4.0
npm ERR! code 1
npm ERR! path /home/john/Sites/steel/slicing/node_modules/favicons/node_modules/sharp
npm ERR! command failed
npm ERR! command sh -c (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)
npm verb exit 1
npm verb unfinished npm timer reify<PHONE_NUMBER>208
npm verb unfinished npm timer reify:build<PHONE_NUMBER>330
npm verb unfinished npm timer build<PHONE_NUMBER>335
npm verb unfinished npm timer build:deps<PHONE_NUMBER>338
npm verb unfinished npm timer build:run:install<PHONE_NUMBER>468
npm verb unfinished npm timer build:run:install:node_modules/favicons/node_modules/sharp<PHONE_NUMBER>253
npm verb code 1

I dont know why favicons because i started npm install --verbose --foreground-scripts sharp

npm info run<EMAIL_ADDRESS>install node_modules/favicons/node_modules/sharp

You're using an out of date version of favicons that depends on an out of date version of sharp (0.23.4 was released in 2019), please upgrade.

Best guess would be a package.json and/or  package-lock.json file  in the same (or parent) directory with an outdated dependency. Also watch out for any globally-installed packages (run npm ls -g to list these).

Best guess would be a package.json and/or package-lock.json file in the same (or parent) directory with an outdated dependency. Also watch out for any globally-installed packages (run npm ls -g to list these).

Thank you :)


Change epetition wording to petition

For https://www.pivotaltracker.com/story/show/97092986
Other than lots of renaming, the main change is the use of locale definitions for email signoff, making it easier to change it in future.

Thorough work!


Refined Github has been loaded twice

Vivalid 3.7.2218.52 / Chrome 89.04389
GHE 3.0.6
https://github.com/sindresorhus/refined-github/-equivalent
Both with and without token (except delete-repo)

(also edit-readme 21.5.1 fails: Cannot read property 'textContent' of undefined, if that has anything to do with that)

Thank you for the issue, does this happen on your GHE site? Not on github.com?

I am not signed in on GitHub.com from the computer that browses GHE.

Noticed the same issue today, only happening on GHE, not GH.

All pages?

Yes.

Confirmed, testing on http://neverssl.com/
Looking into this now. It might just be https://github.com/fregante/content-scripts-register-polyfill


Don't use test artifacts from other projects

Fixes #2597

Let's see what Travis says on this one..

Rebased on top of #2610


Adding Solution for Microsoft Windows SQL Server Database Audit

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Please verify all hunting queries description as it has spelling mistakes like below. Refer below one of the example for reference.
Instead of This its his in description. Instead of hunting its hunitng.
Please verify other files as well and do repackage it again.

let us know once all changes are done


[Bug]: SSH URL pattern for private repo check does not accommodate custom port in the check

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The current pattern makes it so that the port is included as part of the path of the URL where the private repo check is made
Steps To Reproduce
Connect to a git repo on a custom port and debug through private repo check
Public Sample App
No response
Environment
Production
Severity
Low (Inconsistent UI/UX)
Issue video log
No response
Version
Cloud

@brayn003  - didn't we close this?

Hi @nidhi-nair, Could you please provide additional details regarding how the private repo check should ideally handle the custom port?

Hi @nidhi-nair When users attempt to connect to a GitHub private repository using a custom port, and the connection fails due to a timeout error. and in the UI we are not getting ant error message.
The URL format I provided (ssh://git@github.com:2222/shanid544/appsmith-app.git) is valid for SSH connections, but GitHub typically uses port 22 for SSH. Custom ports like 2222 may not be accepted by GitHub, leading to connection timeouts.
Currently, when a timeout occurs, users are not receiving any feedback or error messages in the UI, which can lead to confusion.
What fix we need to do on this? Should we show proper error message in the UI. or anything else, Please confirm

@nidhi-nair Could you please update?


why use darknet train command still cause 'CUDA status Error'

I adapt tag: gpu-cv-cc80 as yolo train image,
I fisrt trid use train command :

but it seems just display model summary, and not start training.

Secondly,  I tried to compile darknet file by make command , but it threw out error:

Finally , I also try use detect command , no exception ,  it threw a error:

So I think it is due to missing cuda file, but  I think doesn't it should be a completely darknet environment ? Could you give some idea to solve this problem

What GPU are you using?
The images in this repository were built using multi stage build to reduce image size. So the image doesn’t contain build environment, only contain runtime. So I think your second error is correct behavior.
In your third image, CUDA outputs message about compatibility. cc80 tag expects your GPU supports compute capability 8.0. Does your GPU satisfy it? You can check GPU’s compute capability in this page

Thanks for your reply.  I'm using RTX 2080Ti ,  nvidia-smi display cuda version =11 , but no nvcc . If you mean these images only for runtime but no for training?

RTX 2080 Ti ’s compute capability is 7.5 which is described GeForce and TITAN Products section in this page. So could you try gpu-cv-cc75?
I mean docker images in this repository only contain runtime for executing not for developing. So you can do everything which darknet supports like detection and training but can't build darknet executable inside docker image.

But why it display 'gpu not used' and not start training process when I training

Now I can use darknet to test image in this image, but it still not allow to training .

I don't know what the problem is from your image.
Could you try darknet_yolo_v4_pre-gpu-cv-cc75? The darknet_yolo_v3 was released about 2 years ago, and at that time yolo v4 wasn't released.
And I guess your problem isn't docker problem, it's darknet problem. So I recommend that you check AlexeyAB/darknet:Issues too.

I might be something stupid, but, who knows, it might be a reason.
I actually tried to use the libdarknet.so instead of using the executable darknet. While doing so, I have copied the libdarknet.so to the /user/local/lib and also copied the include/darknet.h to /user/local/include. When I tried to use the libdarknet.so it gave me an error with the CUDA lib.
See below:
#0 41.72 /usr/bin/ld: warning: libcuda.so.1, needed by /usr/local/lib/libdarknet.so, not found (try using -rpath or -rpath-link)
#0 41.72 /usr/bin/ld: /usr/local/lib/libdarknet.so: undefined reference to `cuCtxGetCurrent'
#0 41.72 collect2: error: ld returned 1 exit status

@daisukekobayashi : I was also on the gpu cc 75. I used your repo as a base, but modified the build & runtime to copy the libdarknet.so and darknet.h. And I added a runtime where the go could also build/run (just for the sake of testing basic code).
Maybe when we install the cuda libraries, the libs are not added in the user/local folders.

@Nordes
This repository uses two stage build to reduce docker image size. First building darknet binary based on nvidia/cuda:11.2.2-cudnn8-devel-ubuntu20.04 and then packaging darknet based on nvidia/cuda:11.2.2-cudnn8-runtime-ubuntu20.04. So there are no cuda development library in this docker image.
I guess you want to build some program using libdarknet and cuda. So I think it's easy to use nvidia-cuda-devel image instead of my image. If you reuse my dockerfile, you should try removing stage two from dockerfile. You can use libdarknet.so based on cuda-devel based image.


Zooming and resizing on website causes numerous bollinger bands to be visible

When zooming or resizing http://scottlogic.github.io/d3fc/ without reloading the page, bollinger bands are constantly drawn but previous ones are still visible.

Thanks @djmiley, nice find!
I know you're trying to learn your way around the library, so if you fancy trying to fix it: the bug was caused by this change and you'll need to change this line to fix it. No worries if you don't.


Conduit-plugin [2]: Plugin registry

Description
This creates the plugin registry interface that knows how to spin up a plugin. There are two registry implementations:

standalone registry - is using go-plugin to spin up a plugin in a separate process and communicates with it via gRPC (same as the old approach)
builtin registry - adds support for running a plugin in the same process as Conduit by bypassing the go-plugin library entirely

Related to #65
Quick checks:

[X] I have followed the Code Guidelines.
[X] There is no other pull request for the same update/change.
[X] I have written unit tests.
[X] I have made sure that the PR is of reasonable size and can be easily reviewed.

Thanks @hariso, I will create issues later today, among them the followup you mention in your comment!


README: Add description of local-semihosting

The new opensbi defaults to using semihosting simulation as the serial output device, so it is necessary to start DebugServer using local-semihosting mode.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Changed background of ListView and added selection model

Closes #145

Codecov Report

Merging #254 (b44dc0d) into dev (7de92b2) will increase coverage by 0.98%.
The diff coverage is 49.53%.

@@            Coverage Diff             @@
##              dev     #254      +/-   ##
==========================================
+ Coverage   12.00%   12.99%   +0.98%
==========================================
  Files         223      225       +2
  Lines        5296     5372      +76
  Branches      871      892      +21
==========================================
+ Hits          636      698      +62
- Misses       4582     4590       +8
- Partials       78       84       +6

Impacted Files
Coverage Δ

...main/kotlin/tools/aqua/bgw/builder/FXConverters.kt
0.00% <0.00%> (ø)

...main/kotlin/tools/aqua/bgw/builder/SceneBuilder.kt
0.00% <0.00%> (ø)

...ain/kotlin/tools/aqua/bgw/builder/UINodeBuilder.kt
0.00% <0.00%> (ø)

...bgw/components/container/GameComponentContainer.kt
62.00% <ø> (ø)

...aqua/bgw/components/gamecomponentviews/DiceView.kt
0.00% <ø> (ø)

...tlin/tools/aqua/bgw/components/layoutviews/Pane.kt
0.00% <ø> (ø)

...tools/aqua/bgw/components/uicomponents/ComboBox.kt
0.00% <0.00%> (ø)

...ools/aqua/bgw/components/uicomponents/TableView.kt
0.00% <ø> (ø)

...w-gui/src/main/kotlin/tools/aqua/bgw/core/Scene.kt
0.00% <ø> (ø)

...s/aqua/bgw/observable/lists/ObservableArrayList.kt
50.00% <ø> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de92b2...b44dc0d. Read the comment docs.


Read config from pyproject.toml

try to configure the mirror url in pyproject.toml doesn't work:
[tool.poetry.plugins.pypi_mirror]
url = "https://pypi.tuna.tsinghua.edu.cn/simple"

using:
poetry 1.8.3
poetry-plugin-pypi-mirror 0.4.2
I guess poetry doesn't support access tool.poetry.plugins.* via poetry.config interface?

It is possible to retrieve pypi_mirror.url from poetry._pyproject.poetry_config object, but obviously this is not an public API:
(Pdb) pp poetry._pyproject.poetry_config['plugins']['pypi_mirror']
{'url': 'https://example.net/simple'}

Hi @georgexsh,
Could you explain your use-case a bit more? Typically this plugin is used when all requests for PyPI.org are intended to be directed to a mirror/pull-through cache, without introducing changes to pyproject.toml that would make it difficult to collaborate with others who would not be using the same mirror.
If you're going to be editing pyproject.toml, why not declare a new primary source without adding PyPI?

why not declare a new primary source without adding PyPI?

changing the primary source would indroduce too much noise to the lock file.

without introducing changes to pyproject.toml that would make it difficult to collaborate with others

this makes sense, I've switched to using environ to config the mirror, thanks!


chore: default log level to info, as it should be

but why? If you don't call Zap.Level.SetLevel at all, the default is 0, which means zapcore.InfoLevel.

if log level is not explicitly specified, it will be set to info.


cnp-pci-dss-1.2-ingress.yaml

@deepakcys This context can be done with auto discovered policies. Hence closing the PR.


Add policy-related relations #444

Add relation guides: A relation between a policy instrument and a transformative measure where a policy instruments guides a transformative measure.
Add relation has bearer as inverse of bearer of: A relation between a specifically and an independent continuant (the bearer) dependent continuant (the dependent), in which the dependent specifically depends on the bearer for its existence
Add axioms to classes policy and policy instrument
Closes #444.

Well spotted. I added this missing axiom.


fix(issue-reports): Remove encoded solution

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX
None

Description

This commit removes the encoded solution from the URI to make issue submission cleaner.


[SILGen] Fix a bug where the wrong convention was being used for lowering a closure to a C++ function pointer

Use the C function pointer convention instead of the block convention.
rdar://122977380
(cherry picked from commit d76dbb1a64cc48d8dd3813797c54d53b9dbee668)

@swift-ci please test

Explanation: Swift compiler crashes when a swift closure is passed to a C++ function that takes a pointer to a function taking a non-trivial C++ type like std:vector<int>. The crash is caused by a bug where the block convention is used instead of the C function pointer convention to get the SIL function type.
Scope: The change I made impacts SILGen.
Original PR: https://github.com/apple/swift/pull/73039
Risk: Low.
Testing: Added a compiler test.
Reviewer: @egorzhdan @DougGregor


edit in README.md

Disclaimer: I'm a noobie both to GitHub issues and Linux.
So under "Compilation", it says to use the line "sh configure.sh". It's not working for me. It gave a lot of 'no permission' errors.

So I tried using sudo. ( sudo sh configure.sh) and it worked.
If editing the readme is correct, let me know. This could my first opportunity to commit to a public repo. :)

It looks to me like your permissions are a bit messed up with respect to the cloned git repository. My guess is that the repository was cloned using superuser permissions, so the repository folder on your machine is owned by root. This means that when you use the configure script and try to modify the folder, it rejects the changes because your folder is controlled by root. Obviously, you can run the configure script with superuser permissions to get around this. The other option is to try cloning the repository again, this time with regular permissions. Then, the configure script should work as specified in the README.

My guess is that the repository was cloned using superuser permissions, so the repository folder on your machine is owned by root

You mean i might have done " sudo clone https://github.com/dmhacker/arch-linux-surface" instead of "clone https://github.com/dmhacker/arch-linux-surface"?
I'll check it.

Ok I checked it. I have followed the readme exactly. I am getting the same Permission denied errors during "sh configure.sh".

Enter the same location where you usually run sh configure.sh  and do ls -al
What is the output?

Not sure how I can contribute to this now.
I'll just leave these details,
Surface Pro 2017
I had secure boot off during this process.
I wasn't working on any dual boot. Full Manjaro.
As i mentioned, I was anyway able to go through 'configure.sh' step by giving it sudo. I was able to complete the process, but not much changed. In the sense, the touch screen didnt work, the auto rotate didnt work, the ambient light detection for auto brightness didnt work. One thing I noticed that worked was battery got detected.
Due to time constraints, I just switched over to Ubuntu 19 so that i can use jayday's kernel. And have everything working as it should.
I wish i could wait and get all the errors here, so they could be solved as i prefer Manjaro. But alas.

I am getting the same permissions errors while running configure.sh. Pretty sure I followed the readme exactly. Running configure.sh with superuser privileges solved the problem. This is exactly what I did in case it helps:
~/code $ git clone https://github.com/dmhacker/arch-linux-surface
Cloning into 'arch-linux-surface'...
remote: Enumerating objects: 70, done.
remote: Counting objects: 100% (70/70), done.
remote: Compressing objects: 100% (51/51), done.
remote: Total 505 (delta 28), reused 45 (delta 15), pack-reused 435
Receiving objects: 100% (505/505), 232.87 KiB | 201.00 KiB/s, done.
Resolving deltas: 100% (267/267), done.
~/code $ cd arch-linux-surface/
~/code/arch-linux-surface $ sudo sh setup.sh
[sudo] password for drew:
This script was created to simplify the setup process for Surface devices running Arch Linux.

Updating cache ...
Cloning into 'linux-surface'...
remote: Enumerating objects: 78, done.
remote: Counting objects: 100% (78/78), done.
remote: Compressing objects: 100% (49/49), done.
remote: Total 113116 (delta 30), reused 57 (delta 24), pack-reused 113038
Receiving objects: 100% (113116/113116), 221.61 MiB | 2.61 MiB/s, done.
Resolving deltas: 100% (43854/43854), done.

Copy config files from jakeday's kernel to root? [y/N] y
Unpacking files to / ...
Making /lib/systemd/system-sleep/sleep executable ...
Done copying config files.

Replace suspend with hibernate? [y/N] y
Symlinking suspend target/service to hibernate target/service ...
Done replacing suspend with hibernate.

Install WiFi firmware (marvel, mwlwifi)? [y/N] y
Unpacking files to /lib/firmware/mrvl ...
Archive:  .cache/linux-surface/firmware/mrvl_firmware.zip
  inflating: /lib/firmware/mrvl/pcie8897_uapsta.bin
  inflating: /lib/firmware/mrvl/pcie8997_wlan_v4.bin
  inflating: /lib/firmware/mrvl/pcieuart8997_combo_v4.bin
  inflating: /lib/firmware/mrvl/pcieusb8997_combo_v4.bin
  inflating: /lib/firmware/mrvl/sd8688.bin
  inflating: /lib/firmware/mrvl/sd8688_helper.bin
  inflating: /lib/firmware/mrvl/sd8787_uapsta.bin
  inflating: /lib/firmware/mrvl/sd8797_uapsta.bin
  inflating: /lib/firmware/mrvl/sd8801_uapsta.bin
  inflating: /lib/firmware/mrvl/sd8887_uapsta.bin
  inflating: /lib/firmware/mrvl/sd8897_uapsta.bin
  inflating: /lib/firmware/mrvl/sdsd8997_combo_v4.bin
  inflating: /lib/firmware/mrvl/usb8766_uapsta.bin
  inflating: /lib/firmware/mrvl/usb8797_uapsta.bin
  inflating: /lib/firmware/mrvl/usb8801_uapsta.bin
  inflating: /lib/firmware/mrvl/usb8897_uapsta.bin
  inflating: /lib/firmware/mrvl/usbusb8997_combo_v4.bin
Done installing marvel firmware.
Unpacking files to /lib/firmware/mwlwifi ...
Archive:  .cache/linux-surface/firmware/mwlwifi_firmware.zip
  inflating: /lib/firmware/mwlwifi/88W8864.bin
  inflating: /lib/firmware/mwlwifi/88W8897.bin
  inflating: /lib/firmware/mwlwifi/88W8964.bin
  inflating: /lib/firmware/mwlwifi/88W8997.bin
Done installing mwlwifi firmware.

Install device-specific firmware (touchscreen, wireless, GPU)? [y/N] y
What Surface model is your device? Enter the number corresponding to your selection.
 Installing firmware ...
Unpacking files to /lib/firmware/intel/ipts/ ...
Archive:  .cache/linux-surface/firmware/ipts_firmware_v78.zip
  inflating: /lib/firmware/intel/ipts/SurfaceTouchServicingDescriptorMSHW0078.bin
  inflating: /lib/firmware/intel/ipts/SurfaceTouchServicingKernelSKLMSHW0078.bin
  inflating: /lib/firmware/intel/ipts/SurfaceTouchServicingSFTConfigMSHW0078.bin
 extracting: /lib/firmware/intel/ipts/SurfaceTouchServicingTouchBlobMSHW0078.bin
  inflating: /lib/firmware/intel/ipts/config.bin
  inflating: /lib/firmware/intel/ipts/iaPreciseTouchDescriptor.bin
  inflating: /lib/firmware/intel/ipts/intel_desc.bin
  inflating: /lib/firmware/intel/ipts/ipts_fw_config.bin
  inflating: /lib/firmware/intel/ipts/vendor_desc.bin
  inflating: /lib/firmware/intel/ipts/vendor_kernel.bin
Unpacking files to /lib/firmware/i915/ ...
Archive:  .cache/linux-surface/firmware/i915_firmware_skl.zip
  inflating: /lib/firmware/i915/skl_huc_ver01_07_1398.bin
  inflating: /lib/firmware/i915/skl_guc_ver6_1.bin
  inflating: /lib/firmware/i915/skl_dmc_ver1_26.bin
  inflating: /lib/firmware/i915/skl_guc_ver9_33.bin
  inflating: /lib/firmware/i915/skl_dmc_ver1_23.bin
  inflating: /lib/firmware/i915/skl_dmc_ver1_27.bin
  inflating: /lib/firmware/i915/skl_guc_ver1.bin
  inflating: /lib/firmware/i915/skl_guc_ver4.bin

Setup process finished!
Install your patched kernel and then reboot.
~/code/arch-linux-surface $ sh configure.sh
Which kernel version do you want to build?
1) 4.19
2) 5.0
#? 2
Updating cache ...
fatal: could not create work tree dir 'linux-stable': Permission denied
error: cannot open .git/FETCH_HEAD: Permission denied
Installing fresh set of template files ...
mkdir: cannot create directory ‘build-5.0.10’: Permission denied
cp: cannot stat 'base/templates/*': No such file or directory
configure.sh: line 76: cd: build-5.0.10: No such file or directory
Adjusting PKGBUILD version ...
cat: PKGBUILD: No such file or directory
configure.sh: line 84: PKGBUILD: Permission denied
Creating symlink to kernel source code ...
ln: failed to create symbolic link 'linux-stable': Permission denied
Creating symlink to Arch upstream patches ...
ln: failed to create symbolic link 'patches': Permission denied
Creating symlink to Surface device patches ...
ln: failed to create symbolic link 'linux-surface/linux-surface': Permission denied
Copying v5.0 .config file ...
cp: cannot create regular file './config.5.0': Permission denied
mv: cannot stat 'config.5.0': No such file or directory

Build files for patched Linux kernel v5.0.10 are in build-5.0.10.
The following commands can be used to build the kernel packages.

cd build-5.0.10
MAKEFLAGS="-j4" makepkg -sc

You can optionally provide the -i flag to makepkg to install the kernel after build.
~/code/arch-linux-surface $ sudo sh configure.sh
Which kernel version do you want to build?
1) 4.19
2) 5.0
#? 2
Updating cache ...
Cloning into 'linux-stable'...
remote: Counting objects: 7491222, done.
remote: Compressing objects: 100% (1118408/1118408), done.
remote: Total 7491222 (delta 6325111), reused 7491157 (delta 6325089)
Receiving objects: 100% (7491222/7491222), 1.20 GiB | 2.60 MiB/s, done.
Resolving deltas: 100% (6325111/6325111), done.
Checking out files: 100% (63873/63873), done.
Already up to date.
Installing fresh set of template files ...
Adjusting PKGBUILD version ...
Creating symlink to kernel source code ...
Creating symlink to Arch upstream patches ...
Creating symlink to Surface device patches ...
Copying v5.0 .config file ...

Build files for patched Linux kernel v5.0.10 are in build-5.0.10.
The following commands can be used to build the kernel packages.

cd build-5.0.10
MAKEFLAGS="-j4" makepkg -sc

You can optionally provide the -i flag to makepkg to install the kernel after build.
~/code/arch-linux-surface $ ls -al
total 48
drwxr-xr-x 6 drew drew 4096 May 13 08:48 .
drwxr-xr-x 9 drew drew 4096 May 13 08:34 ..
drwxr-xr-x 5 drew drew 4096 May 13 08:34 base
drwxr-xr-x 2 root root 4096 May 13 08:49 build-5.0.10
drwxr-xr-x 4 root root 4096 May 13 08:37 .cache
-rwxr-xr-x 1 drew drew 3273 May 13 08:34 configure.sh
drwxr-xr-x 8 drew drew 4096 May 13 08:34 .git
-rw-r--r-- 1 drew drew   67 May 13 08:34 .gitignore
-rw-r--r-- 1 drew drew 1069 May 13 08:34 LICENSE
-rw-r--r-- 1 drew drew 2180 May 13 08:34 README.md
-rwxr-xr-x 1 drew drew 6603 May 13 08:34 setup.sh
~/code/arch-linux-surface $ ls -al ..
total 44
...
drwxr-xr-x  6 drew drew  4096 May 13 08:48 arch-linux-surface
...

Thanks for bringing this to my attention guys. I figured out the issue. The setup.sh and configure.sh scripts have been using the same internal cache. If you created the cache using superuser permissions in setup.sh, you would have been unable to access as a non-superuser.
To fix this problem, run:
git pull
rm -rf .cache

This will get the most recent update to the setup script and will remove your old cache, so it can be recreated without superuser permissions.

See https://github.com/dmhacker/arch-linux-surface/commit/30257020b1649d2521a974cbea9bbaaf710b43ed for resolution of this issue.


build, golang1.17: sloppy ip parsing

Adds backwards compatibility to existing pools by providing a custom unmarshaller of the IPAMConfig struct.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

40 of 66 (60.61%)  changed or added relevant lines in 7 files are covered.
18 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 54.529%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/reconciler/controlloop/dummy_controller.go
2
3
66.67%

cmd/whereabouts.go
14
18
77.78%

pkg/config/config.go
5
10
50.0%

pkg/storage/etcd.go
0
6
0.0%

pkg/allocate/allocate.go
15
25
60.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/api/whereabouts.cni.cncf.io/v1alpha1/zz_generated.deepcopy.go
18
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
885

Relevant Lines:
1623

💛  - Coveralls

/hold
Let me try another approach first - trying to write custom marshall / unmarshall functions for the IPAMConfig type.

@dougbtv ready to review.
I'd appreciate if we kept things separate and merged #223 first. I would then rebase this one, which would show a lot less differences.
Finally, I think releasing a whereabouts version before bumping golang & kubernetes versions is a good move.


Attachment embedding in PDF

Hi Team,
While performing a POC on client side PDF generation tools, wanted to check if PDFKit is having functionality to embed external documents into PDF and show it as icon, further on clicking it will open document.
Found no content/articles related to this topic anywhere so raising issue here.
Also, if it is not supported, please suggest till when this will get supported.
Thanks in advance.

+1
We are testing this library to replace our current PHP - TCPDF way of generating PDFs and this is the only feature we are missing in order to switch.
Unfortunately, we don't have enough knowledge about PDF format to contribute with this awesome library.

@devongovett Do you have any idea how difficult it is to implement such feature? And how to do it?

@natcohen Perhaps https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf section 7.11.4 together with some samples:

http://openpreservation.org/blog/2013/01/09/what-do-we-mean-embedded-files-pdf/
https://blog.didierstevens.com/2009/07/01/embedding-and-hiding-files-in-pdf-documents/

Is enough to get you started?

Hi All,
There will be a pull request with embedded file (attaching a file without linking to it) and file attachment annotation (attaching a file and linking to it) functionality soon.

Some backstory for this PR:
My workplace is creating PDFs with pdfmake which is using PDFKit, and we absolutely need embedded files / attachments in our PDFs. They allowed me to work on this feature on company time and then share it with everyone else as a pull request.
@ashijay I know it's been about four years since you opened this issue, but bpampuch/pdfmake#956 is next on my todo list

@blikblum - Since PR #1226 ha now been merged, consider closing this issue and issue #740


Bulk exclude backlogged reportbacks on node 362

FEATURE OVERVIEW
User Story
As an admin, I want all fids on node 362 with a quantity under 200 to be marked as excluded before it relaunches on Thursday.
Additional Information (optional)
Campaigns team was trying to go through the backlog and the number of reportbacks went from ~600 to ~1500. Got these numbers from Lizzy. 600 felt doable, 1500 seems unreasonable between now and then. Also a few reports of "Illegal choice detected" error when intern was running through things.
Why This Matters
Since campaign relaunches on Thursday and reportbacks are listed as oldest to newest the campaigns team won't realistically be able to get to current reportbacks without this being cleared out. Only other option I can think of is that we adjust the script to include only reportbacks that match one of the previous run ids which would buy us a little time I suppose and allow us to get the work done later this week.
@angaither let's chat about this in the AM

@mikefantini I'm not sure what you mean by all "fids with a quantity under 200 to be marked as excluded" - isn't quantity attached to reportbacks, not reportback items?
Also, admins review these reportbacks at /node/362/rb?

@chloealee right sorry I guess the FIDs are what need to be marked as excluded and we should do that for any that are currently pending and associated with RBIDs with a quantity under 200

From what I understand, four things need to happen:

all FIDs associated with a RB with a quantity under 200 get marked as excluded
these photos no longer appear in the queue
these RBIDs should have a status of 0 in the DB
FIDs associated with RBIDs with a quantity 201 and over should still be pending and appear in the inbox

@namimody @chloealee one caveat to the above, we only want FIDs that are currently pending and quantity under 200 to be marked as excluded.
i.e. if an FID is already approved, we don't want it to change to be excluded.

Also if the RBID is already 1 we don't it to change to 0.

Thanks @mikefantini! So then this work should only touch RBIDs with status NULL? cc @chloealee

@mikefantini @namimody should this be ONLY for node 362 or for all campaign nodes?

Only 362 @chloealee!

cool, thanks @namimody !

@namimody I'm pretty sure that flagged status can stay 0 or 1 for a file that is pending. Consider if it's a second file on an existing reportback that had a file that was previously reviewed.
i.e. fid 1 is approved and rbid flagged status is now 0. fid 2 (2nd file on the same reportback) is pending but rbid flagged status is still 0. So I'm pretty sure you need to look for all files with status pending regardless of whether flagged status is 0, 1, or NULL @chloealee

Ohh now I follow @mikefantini -- so even if we make mark files of partially reviewed reportbacks as excluded, their RBID status will stay 0 or 1. Therefore:

all not yet reviewed FIDs associated with a RB with a quantity under 200 get marked as "excluded"
these photos should no longer appear in the queue
these RBIDs should have a status of 0 or 1 in the DB (depending on if other assoicated FIDs have been reviewed and been marked as approved/excluded/promoted or flagged previously)
unreviewed FIDs associated with RBIDs with a quantity 201 and over should still be pending and appear in the inbox

this failed on thor
Dosomething_reportback  7034  Bulk excludes backlogged reportbacks on node
                               362.  Updates any fid with a pending status to
                               be marked as excluded if the quantity in the
                               reportback is less than 200.
Do you wish to run all pending updates? (y/n):
y
array_flip(): Can only flip STRING and INTEGER values!               [warning]
entity.controller.inc:219
PHP Fatal error:  Call to a member function getFids() on a non-object in /var/www/www.dosomething.org/releases/20160406175520/lib/modules/dosomething/dosomething_reportback/dosomething_reportback.install on line 935
Fatal error: Call to a member function getFids() on a non-object in /var/www/www.dosomething.org/releases/20160406175520/lib/modules/dosomething/dosomething_reportback/dosomething_reportback.install on line 935

@angaither I'm getting these errors now too:
WD Apache Solr: HTTP Status: 0; Message: : php_network_getaddresses: getaddrinfo failed: Name or service not known; Response: ; Request: Unknown; Caller: apachesolr_views_views_data() (line 43 [error]
of /var/www/dev.dosomething.org/html/profiles/dosomething/modules/contrib/apachesolr_views/apachesolr_views.views.inc)
WD Apache Solr Views: HTTP 0; : php_network_getaddresses: getaddrinfo failed: Name or service not known

Do you know why these files might be triggered?

@chloealee where are you seeing this?

@angaither when I run drush up db -y this is the only error now returning (I got rid of the other error because I realized when I was cleaning up the code, I accidentally deleted rb.rbid from the SELECT statement).

@angaither I got everything to work but that error still pops up - is it okay to submit another PR even with this error?

@chloealee yeah

Just leaving some notes here (will clean up in AM):
First the great news: my new reportbacks not on the run were not touched. Woo.
Now some funkiness:
When I went to review reportbacks on node 362 it initially seemed like there were still thousands of images:

I then went to actually review what was left in the inbox.
After reviewing 25 in the inbox I got a 503, hit refresh, and inbox went down to 91.
I then did it again, 503, refresh, inbox went down to 66 with lots of illegal choice detected.
I reviewed again. 503. refresh. Inbox was at 44 with 3 reportbacks that I had already reviewed still in the inbox with a radio button selected and 21 illegal choice detected errors.
Reviewed again. No 503. Inbox was at 41 with 3 illegal choice detected errors and 22 photos I had already reviewed still in the inbox with a radio button selected. And then 3 new reportbacks at the bottom.
Reviewed again. 503. Inbox at 17. 16 illegal choice detected. I previously reviewed still in inbox with radio button selected.


Android Basics: display-list-cards

url of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-display-list-cards?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-2%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-display-list-cards&authuser=1#1
In which task and step of the codelab can this issue be found?
"Initialize list of affirmations with images"
Describe the problem
missing the line which should be
"Affirmation(R.string.affirmation3, R.drawable.image3),"
from the code sample, the code has "2" and on the next line "4", missing "3".
Steps to reproduce?

Go to codelab and read section

Versions
4.1.1

@SoulProtagonist
Thank you so much for reporting this issue. This is fixed and will be published soon.


Corrected duplicate test-id

What this PR does / why we need it:
Corrected duplicate test-id
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

@ILpinto @vatsalparekh is that the real ID from polarion?

@rmohr yes.


support setting multi-line values for dotenvx set

Repro steps:

Generate a sample key with ssh-keygen -t ed25519 -f key -N ""
Copy the sample key with cat key | pbcopy
Attempt to write the secret with dotenvx set SECRET_KEY "<paste>"

At this point, I receive an error: unknown option error:
❯ dotenvx set SECRET_KEY "-----BEGIN OPENSSH PRIVATE KEY-----
b3Bl...uAQ==
-----END OPENSSH PRIVATE KEY-----"
error: unknown option '-----BEGIN OPENSSH PRIVATE KEY-----
b3Bl...uAQ==
-----END OPENSSH PRIVATE KEY-----'

I've noticed if I wrap the secret with double and single quotes ("'<paste>'"), it works, but the single quotes are in the secret.
❯ dotenvx set SECRET_KEY "'-----BEGIN OPENSSH PRIVATE KEY-----
b3Bl...uAQ==
-----END OPENSSH PRIVATE KEY-----'"
✔ set SECRET_KEY with encryption (.env)

It feels like the option parsing is getting tripped up by the - characters.

thanks for surfacing this.
for anyone else running into this issue, for now:

paste it instead into your .env file
run dotenvx encrypt

we'll work on adding multiline support to the set command.

i see, you're right, this is related to flag options. it interprets any string starting with a dash as a flag.
you can use a double dash (--) to signal the end of flag options:
dotenvx set SECRET_KEY -- "-----BEGIN OPENSSH PRIVATE KEY-----
          b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAAAMwAAAAtzc2gtZW
          -----END OPENSSH PRIVATE KEY-----"

or you can add a space:
dotenvx set SECRET_KEY " -----BEGIN OPENSSH PRIVATE KEY-----
          b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAAAMwAAAAtzc2gtZW
          -----END OPENSSH PRIVATE KEY-----"

i documented this in the README (under advanced) and also put it in the help text for the set command (>= 1.5.0):
Usage: @dotenvx/dotenvx set [options] <KEY> <value>

set a single environment variable

Arguments:
  KEY                        KEY
  value                      value

Options:
  -f, --env-file <paths...>  path(s) to your env file(s) (default: ".env")
  -c, --encrypt              encrypt value (default: true) (default: true)
  -p, --plain                store value as plain text (default: false)
  -h, --help                 display help for command

Examples:

  \`\`\`

  $ dotenvx set KEY value
  $ dotenvx set KEY "value with spaces"
  $ dotenvx set KEY -- "---value with a dash---"
  $ dotenvx set KEY -- "-----BEGIN OPENSSH PRIVATE KEY-----
                        b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAAAMwAAAAtzc2gtZW
                        -----END OPENSSH PRIVATE KEY-----"
  \`\`\`

that's the best we can do given how cli's parse flags.

If I use a double dash like in this  example
dotenvx set SECRET_KEY -- "-----BEGIN OPENSSH PRIVATE KEY-----
          b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAAAMwAAAAtzc2gtZW
          -----END OPENSSH PRIVATE KEY-----"

how would I pass extra options to this like --encrypt and -f .env.dev?

yeah, they just have to be ahead of the double dash. glad you got it.


Adding action.yml

Fixes jakejarvis/wait-action#2

I opened this in case #3 never gets merged

if jake ignores this PR as this other, we'll be as the same stage :'(
@jakejarvis you seem active on GH, any reason not to merge the PR? thanks :)

Maybe someone can drop him an email? Maybe he got lost in this, or turned off notifications 😅?

I sent him an email 18th April regarding this merge just in case...


Timer module

Design and implement a Mir-native time module that would replace the explicit handling of Tick events by the protocol.

Hey, I created an ADR proposal for dealing with time in Mir. It’s on Hackmd for now for easier collaboration on it, I’ll put it in the repo when we confirm it. Please have a look and let me know if you’d like to change anything or directly add other “Considered decisions” if you have other proposals or pros/cons to existing ones.

ADR merged.


Cannot find libskiko-linux-x64.so.sha256 Kotlin 1.9.10

Describe the bug
/usr/lib/jvm/java-17-openjdk/bin/java...
Exception in thread "main" java.lang.ExceptionInInitializerError
	at androidx.compose.ui.awt.WindowComposeBridge.<init>(WindowComposeBridge.desktop.kt:40)
	at androidx.compose.ui.awt.ComposeWindowDelegate.<init>(ComposeWindowDelegate.desktop.kt:53)
	at androidx.compose.ui.awt.ComposeWindow.<init>(ComposeWindow.desktop.kt:62)
	at androidx.compose.ui.awt.ComposeWindow.<init>(ComposeWindow.desktop.kt:60)
	at androidx.compose.ui.window.Window_desktopKt$Window$3.invoke(Window.desktop.kt:179)
	at androidx.compose.ui.window.Window_desktopKt$Window$3.invoke(Window.desktop.kt:173)
	at androidx.compose.ui.window.Window_desktopKt$Window$10.invoke(Window.desktop.kt:405)
	at androidx.compose.ui.window.Window_desktopKt$Window$10.invoke(Window.desktop.kt:402)
	at androidx.compose.ui.window.AwtWindow_desktopKt$AwtWindow$2.invoke(AwtWindow.desktop.kt:74)
	at androidx.compose.ui.window.AwtWindow_desktopKt$AwtWindow$2.invoke(AwtWindow.desktop.kt:73)
	at androidx.compose.runtime.DisposableEffectImpl.onRemembered(Effects.kt:81)
	at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchRememberObservers(Composition.kt:1137)
	at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:828)
	at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:849)
	at androidx.compose.runtime.Recomposer.composeInitial$runtime(Recomposer.kt:1041)
	at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
	at androidx.compose.ui.window.Application_desktopKt$awaitApplication$2$1$2.invokeSuspend(Application.desktop.kt:219)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Caused by: org.jetbrains.skiko.LibraryLoadException: Cannot find libskiko-linux-x64.so.sha256, proper native dependency missing.
	at org.jetbrains.skiko.Library.findAndLoad(Library.kt:105)
	at org.jetbrains.skiko.Library.load(Library.kt:59)
	at org.jetbrains.skiko.SkiaLayer.<clinit>(SkiaLayer.awt.kt:32)
	... 32 more

Affected platforms
Select one of the platforms below:

Desktop

Versions

Kotlin version*: 1.9.10
Compose Multiplatform version*: 1.5.1
OS version(s)* (required for Desktop and iOS issues): Arch Linux
OS architecture (x86 or arm64): x86
JDK (for desktop issues): openJDK17

To Reproduce
Upgrade runing Project with Kotlin 1.8.0 to 1.9.10
Additional context
build.gradle.kts (:desktop)
....

kotlin {
    jvm {
        jvmToolchain(17)
        withJava()
    }
    sourceSets {
        val jvmMain by getting {
            dependencies {
                implementation(project(":common"))
                implementation(compose.desktop.currentOs)
            }
        }
        val jvmTest by getting
    }
}

compose.desktop {
    application {
        mainClass = "MainKt"
        nativeDistributions {
            targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb)
            packageName = "demo"
            packageVersion = "1.0.0"
        }
    }
}

I can't reproduce your problem.
Can you please try to reproduce on my repository https://github.com/dima-avdeev-jb/issue-3717-desktop-linux

Hello Dima,
thanks for looking at it. I tested your project and had the same behaviour.
But in the meantime I also became aware of https://github.com/JetBrains/compose-multiplatform/issues/3123, which seems very similar to me.
When I run MainKt as Kotlin via Intellij(CE2023.2), I have this problem.
Not with gradle :desktop:run.
However, it is not clear to me why this happens from 1.8.0 to 1.9.20.

@456634
What JVM version and vendor do you have in Gradle settings of this project?

Hello Dima,
corresponds exactly to your screenshot, with the difference that I use Project SDK for Gradle Jvm(17.0.8).

@456634
Can you please delete gradle and maven cahces:
rm -rf ~/.gradle
rm -rf ~/.m2

@dima-avdeev-jb
Deleted gradle an maven caches. Same behaviour.
With Gradle configuration works.
With Kotlin configuration the skiko error comes.
In both projects (yours, mine).

Do I correctly understand, what you are trying to run from the gutter icon near the fun main ?

Do I correctly understand, what you are trying to run from the gutter icon near the fun main ?

Yes, that's what I'm talking about. Is that wrong? I honestly never thought about it, since there were no problems with it until 1.9.x. Sorry if I wasted your time and was not clear in https://github.com/JetBrains/compose-multiplatform/issues/3717#issuecomment-1732424625

I was trying to do so with Linux Manjaro - and it was succesfully runs on IDEA 2023.2

Thank you for your suggestion. I will try to use a multi-window program to achieve the above requirements.

I am having the same problem on MAC Intel.
kotlin.version=1.9.10 || 1.9.0
compose.version=1.5.2

Exception in thread "main" java.lang.ExceptionInInitializerError
	at androidx.compose.ui.awt.WindowComposeBridge.<init>(WindowComposeBridge.desktop.kt:40)
	at androidx.compose.ui.awt.ComposeWindowDelegate.<init>(ComposeWindowDelegate.desktop.kt:53)
	at androidx.compose.ui.awt.ComposeWindow.<init>(ComposeWindow.desktop.kt:62)
	at androidx.compose.ui.awt.ComposeWindow.<init>(ComposeWindow.desktop.kt:60)
	at androidx.compose.ui.window.Window_desktopKt$Window$3.invoke(Window.desktop.kt:179)
	at androidx.compose.ui.window.Window_desktopKt$Window$3.invoke(Window.desktop.kt:173)
	at androidx.compose.ui.window.Window_desktopKt$Window$10.invoke(Window.desktop.kt:405)
	at androidx.compose.ui.window.Window_desktopKt$Window$10.invoke(Window.desktop.kt:402)
	at androidx.compose.ui.window.AwtWindow_desktopKt$AwtWindow$2.invoke(AwtWindow.desktop.kt:74)
	at androidx.compose.ui.window.AwtWindow_desktopKt$AwtWindow$2.invoke(AwtWindow.desktop.kt:73)
	at androidx.compose.runtime.DisposableEffectImpl.onRemembered(Effects.kt:81)
	at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchRememberObservers(Composition.kt:1137)
	at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:828)
	at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:849)
	at androidx.compose.runtime.Recomposer.composeInitial$runtime(Recomposer.kt:1041)
	at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
	at androidx.compose.ui.window.Application_desktopKt$awaitApplication$2$1$2.invokeSuspend(Application.desktop.kt:219)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:771)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:722)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:716)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:741)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Caused by: org.jetbrains.skiko.LibraryLoadException: Cannot find libskiko-macos-x64.dylib.sha256, proper native dependency missing.
	at org.jetbrains.skiko.Library.findAndLoad(Library.kt:105)
	at org.jetbrains.skiko.Library.load(Library.kt:59)
	at org.jetbrains.skiko.SkiaLayer.<clinit>(SkiaLayer.awt.kt:32)
	... 32 more

But it does work in these versions
kotlin.version=1.8.0
compose.version=1.5.2

Hello, Same issue on Ubuntu 22.04.3 LTS
Exception in thread "main" java.lang.ExceptionInInitializerError
at androidx.compose.ui.awt.WindowComposeBridge.(WindowComposeBridge.desktop.kt:40)
at androidx.compose.ui.awt.ComposeWindowDelegate.(ComposeWindowDelegate.desktop.kt:53)
at androidx.compose.ui.awt.ComposeWindow.(ComposeWindow.desktop.kt:62)
at androidx.compose.ui.awt.ComposeWindow.(ComposeWindow.desktop.kt:60)
at androidx.compose.ui.window.Window_desktopKt$Window$3.invoke(Window.desktop.kt:179)
at androidx.compose.ui.window.Window_desktopKt$Window$3.invoke(Window.desktop.kt:173)
at androidx.compose.ui.window.Window_desktopKt$Window$10.invoke(Window.desktop.kt:405)
at androidx.compose.ui.window.Window_desktopKt$Window$10.invoke(Window.desktop.kt:402)
at androidx.compose.ui.window.AwtWindow_desktopKt$AwtWindow$2.invoke(AwtWindow.desktop.kt:74)
at androidx.compose.ui.window.AwtWindow_desktopKt$AwtWindow$2.invoke(AwtWindow.desktop.kt:73)
at androidx.compose.runtime.DisposableEffectImpl.onRemembered(Effects.kt:81)
at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchRememberObservers(Composition.kt:1137)
at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:828)
at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:849)
at androidx.compose.runtime.Recomposer.composeInitial$runtime(Recomposer.kt:1041)
at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
at androidx.compose.ui.window.Application_desktopKt$awaitApplication$2$1$2.invokeSuspend(Application.desktop.kt:219)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
Caused by: org.jetbrains.skiko.LibraryLoadException: Cannot find libskiko-linux-x64.so.sha256, proper native dependency missing.
at org.jetbrains.skiko.Library.findAndLoad(Library.kt:105)
at org.jetbrains.skiko.Library.load(Library.kt:59)
at org.jetbrains.skiko.SkiaLayer.(SkiaLayer.awt.kt:32)
... 32 more

Hello, Same issue on Ubuntu 22.04 LTS (New project by Full Stack Compose Multiplatform pluggin)

Same in Macos， This issue does not occur frequently.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Capybara/SpecificFinders conflicts with Rails/DynamicFindBy

Capybara/SpecificFinders suggests the following change:
# bad
find('#some-id')
find('[visible][id=some-id]')

# good
find_by_id('some-id')
find_by_id('some-id', visible: true)

However, find_by_id is going to be flagged by Rails/DynamicFindBy.
These two cops can't be enabled together. If I had to choose from the two, Rails/DynamicFindBy would be my choice and Capybara/SpecificFinders would be disabled.

Expected behavior
Capybara/SpecificFinders could somehow respect Rails/DynamicFindBy.
Actual behavior
They have conflicting opinions on code like these.
RuboCop version
➜  rubocop -V
1.43.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.24.1, running on ruby 3.1.3) [arm64-darwin22]
  - rubocop-performance 1.15.2
  - rubocop-rails 2.14.2
  - rubocop-rspec 2.18.0

Hi, thanks for your feedback! I also recognize the issue.
FYI, rubocop-rails provides a measure to mitigate false positives for this capybara-derived method.
https://github.com/rubocop/rubocop-rails/pull/785
https://docs.rubocop.org/rubocop-rails/cops_rails.html#configurable-attributes-15
How about doing the following to avoid this?
Rails/DynamicFindBy:
  AllowedMethods:
    - find_by_sql
    - find_by_token_for
    - find_by_id

I don't entirely understand, can you please provide an example of an offence raised by DynamicFinders?
It should ignore an implicit receiver and page, right? Also, when multiple arguments are passed.

How about doing the following to avoid this?

@ydah Thanks for your suggestion. I've seen this somewhere, but I don't really want to whitelist those methods for Rails/DynamicFindBy. I think having find_by_id calls on ActiveRecord  in production code is worse than not having a capybara derived method call in tests. Currently I've disabled Capybara/SpecificFinders for that reason.

can you please provide an example of an offence raised by DynamicFinders?

@pirj I have this code:
expect(page.find("#id")).to be_checked

Capybara/SpecificFinders auto-corrects this to
expect(page.find_by_id('user_remember_me')).to be_checked

which is flagged by Rails/DynamicFindBy:
Offenses:

spec/test.rb:9:14: C: [Correctable] Rails/DynamicFindBy: Use find_by instead of dynamic find_by_id.
      expect(page.find_by_id('id')).to be_checked
             ^^^^^^^^^^^^^^^^^^^^^

@FunnyHector Ah. I overlooked one thing, but if you keep rubocop-rails up-to-date, I don't think that problem will occur.
Some of the following changes to Rails/DynamicFindBy have already been incorporated into rubocop-rails, which should be at least 2.17.3 or higher.

https://github.com/rubocop/rubocop-rails/pull/862
https://github.com/rubocop/rubocop-rails/issues/778

@ydah ah ye my rubocop-rails isn't very up to date. #862 should resolve this issue. Thanks to everyone for this! We can close this issue now I believe.

Sorry for the hi-jack but I have a quick question.
Having just started using rubocop-capybara I was presented with this error. The exact error message is:
Prefer find_by over find.

Thank you for your feedback! We will open the next Pull Request to improve the message.

https://github.com/rubocop/rubocop-capybara/pull/32


Improve list performance (round 3rd)

Describe the task
Improve list performance (round 3rd):

[ ] History list
[ ] Browser - category list
[ ] NFT list (re-check in case have multiple NFT)

Will resolve in https://github.com/Koniverse/SubWallet-Mobile/issues/1169


some charts don't render correctly on load (but then render correctly when you perturb them)

Description:

Steps to reproduce:

https://develop--squiggle-documentation.netlify.app/docs/Features/Distributions#mixture
click With Continuous and Discrete tab
observe chart not rendering correctly
do a idempotent operation to the squiggle string (like remove a ) and re-add it)
observe chart that we want

Expected behavior:
the chart that shows in step 4 should be on load
What I got instead:
chart seems borked.

That seems very odd. I think I know why that happens

Right now the memoization is kinda hacky. It probably would be good to submit the entire Squiggle string to the FunctionChart, for it to use as one of the keys for memoization.

This is due to docusaurus rendering all tabs in advance (https://github.com/facebook/docusaurus/pull/3706), and squiggle-components using useSize, which assigns zero width for tabs rendered offscreen.

I thought I'd need useMeasure or Resize Observer API to detect when the component appears on screen, but turns out there's a lazy option for <Tabs>. Yay.
PR incoming.

Some are still broken:


Nodes Not Duplicated When Reused In Certain Ways

Example
@spatial class SimplePipelined extends SpatialTest {
  override def runtimeArgs: Args = "3"

  def main(args: Array[String]): Void = {
    val xIn = args(0).to[Int]
    val tileSize = 16

    val x = ArgIn[Int]
    val out1 = ArgOut[Int]
    val out2 = ArgOut[Int]
    val out3 = ArgOut[Int]
    setArg(x, xIn)

    Accel {
      val bram = SRAM[Int](tileSize)
      Foreach(tileSize by 1){ ii => bram(ii) = ii }
      Foreach(tileSize by 1){ ii =>
        val grab = ii === x.value
        val used_val = x.value + ii
        val ctrval = x.value * ii
        'USECTRVAL1.Foreach(ctrval by 1){i => out2 := i}
        'USECTRVAL2.Foreach(ctrval by 1){i => out2 := i}
        if (grab) 'USEGRAB1.Foreach(3 by 1){i => out1 := bram(ii) + used_val}
        Pipe{out2 := bram(ii)}
        if (grab) 'USEGRAB2.Foreach(3 by 1){i => out3 := bram(ii) + used_val}
      }
    }

    println(r"Got:      $out1 $out2 $out3")
    println(r"Expected: ${3*xIn} 15 ${3*xIn}")

    val chkSum = out1.value == 3*xIn && out2.value == 15 && out3.value == 3*xIn
    assert(chkSum)
    println("PASS: " + chkSum + " (SimplePip)")
  }
}

Both of the ifs use grab as their condition.  The Pipe Inserter correctly puts grab = and used_val = in their own unit pipe and writes their values to registers.  The used_val register's two reads are correctly connected to bufferPorts 1 and 3 since they are used inside the controllers.  However, the grab only has one RegRead on bufferPort 1 and this same sym is used for the condition of both ifs. It looks like the TransientCleanup creates the correct substitution rules for grab but it doesn't apply them until after visiting the Switch, so they don't get used for the node itself.
ctrval is also not duplicated in TransientCleanup because the _.blk of both of its users, which are CounterNew nodes, are equal to each other even though their parents are not.
Also an issue, the Foreach will be scheduled as Sequential because the flow only sees the Pipe{out2 := bram(ii)} as a child and does not see the IfThenElses as children when it first creates the IR.
Also an issue is

See #87


Failure to save profiles containing specific anointment and weapon combinations

Hi,
When I created a number of items and pressed the save button, I noticed that a dialog box appeared saying that the save failed.
After some experimentation, I found out that the GPart_Siren_PhaseflareDamage anointment on some of the weapons was causing this error.
However, this anointment does not cause problems with all weapons, only some (e.g. S3RV-80S-EXECUTE and Psycho Stabber) cause save failures.
Sorry the information is not complete, but I hope it can be fixed.
[31m2021/09/07 22:34:52 [Recovery] 2021/09/07 - 22:34:52 panic recovered:
runtime error: index out of range [150] with length 2
/opt/hostedtoolcache/go/1.14.15/x64/src/runtime/panic.go:88 (0x4343f9)
/home/runner/go/pkg/mod/github.com/cfi2017/bl3-save-core@v1.2.4/pkg/item/item.go:178 (0x634acd)
/home/runner/work/bl3-save/bl3-save/internal/server/character.go:242 (0x9d5ab4)
/home/runner/work/bl3-save/bl3-save/internal/server/profile.go:122 (0x9d847a)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.6.2/context.go:156 (0x9b9fb1)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.6.2/recovery.go:83 (0x9cdb66)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.6.2/context.go:156 (0x9b9fb1)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.6.2/logger.go:241 (0x9ccc57)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.6.2/context.go:156 (0x9b9fb1)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.6.2/gin.go:409 (0x9c400c)
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.6.2/gin.go:367 (0x9c36d4)
/opt/hostedtoolcache/go/1.14.15/x64/src/net/http/server.go:2836 (0x874439)
/opt/hostedtoolcache/go/1.14.15/x64/src/net/http/server.go:1924 (0x86fce2)
/opt/hostedtoolcache/go/1.14.15/x64/src/runtime/asm_amd64.s:1373 (0x464430)

[GIN] 2021/09/07 - 22:34:52 | 500 |       1.995ms |             ::1 | POST     "/profile/bank"

This might be an out-of-date item database, is this a new anointment?


Add pre-commit hooks?

What's your opinion on adding pre-commit hooks to run unit tests and do other processing before a commit (like formatting, linting, etc.).
There's a Python package that provides support for it. I've found it to be useful on other projects for maintaining code quality. I can set it up if we agree it would be useful here.
Another pre-commit action I've found useful is preventing commits if there is a NO_COMMIT comment in the code. That way I can do experimentation and know that I'll be reminded that I want to delete specific code before a commit.

Not opposed, but perhaps the better place would be before merge into develop and main? Could we get Github actions to do something like that?

Not opposed, but perhaps the better place would be before merge into develop and main? Could we get Github actions to do something like that?

I assume something similar could be done with GitHub actions run on PRs, but I'd need to investigate. It's nice to have something developers can use locally (without requiring GitHub) prior to commit/push. Otherwise, they would need to push commits for the checks to be run.

Can it be the same in both places? With a way of skipping the local one for local-only checkins half-way through a refactor, for example?

Can it be the same in both places? With a way of skipping the local one for local-only checkins half-way through a refactor, for example?

You can use the git commit ... --no-verify option to opt-out of pre-commit checks. You can also explicitly run the pre-commit checks at any time prior to commit.

The pre-commit also supports hooking into the pre-push event. That might be a better fit for your workflow.
https://pre-commit.com/#advanced

Would you like to take a stab at what you have in mind there @steve-bate ?


[WIP] Code Improvements

Current coverage is 88.14% (diff: 94.87%)

Merging #116 into master will increase coverage by 4.66%

@@             master       #116   diff @@
==========================================
  Files            29         29
  Lines          1992       1999     +7
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1663       1762    +99
+ Misses          329        237    -92
  Partials          0          0

Powered by Codecov. Last update ad37074...055c864