64-bit windows binary on AppVeyor

There is 32-bit binary provided here: https://github.com/rainers/cv2pdb/releases/tag/v0.38
Shouldn't there be a 64-bit version as well?
Or is that possible to use 32-bit one to work with 64-bit exe/dll?

You can use the 32-bit version to convert 64-bit executables, there's just a lower limit on the maximum size (about 1GB IIRC).

@leavittx there are now binaries being built as part of the GitHub workflow and offered as build artifacts (called "bin"). See for example https://github.com/rainers/cv2pdb/actions/runs/1563947603. Does that address this ticket?

@dscho Sadly, artifacts expire after a few weeks.

@olback good thing that you can push the branch to your fork, then, to build the artifacts yourself :grin:

There are also permanent releases available here: https://github.com/rainers/cv2pdb/releases
I have added a 64-bit binary to the latest release.


Some functions

I have added some maybes in Transaction Type (needed for my tests)
Maybe you do not need them, tell me. I can remove it.

0 examples, 0 failures
Why only caml case since with _ I find it easier to read (and it compiles of course) ?

0 examples, 0 failures

Heh, yeah I've just been testing this locally. I didn't want to deal with the headache of making fake OANDA credentials just for integration tests, dealing with flaky CI tests because of network errors or rate limits, and also dealing with keeping those test credentials secret in CI.

Why only caml case since with _ I find it easier to read (and it compiles of course) ?

I just find camelCase more consistently used in the Haskell community. What's more important than any particular style choice is just having a consistent style.
By the way thanks for the PR! I'm extremely busy this week but I have reviewing this PR on my todo list.

Ok, I understand. I have just pushed a fix. Then all checks should be ok now.

Hello,
"flaky CI tests because of network errors or rate limits" You mean you get these errors:
InternalException (HandshakeFailed (Error_Packet_unexpected "Alert [(AlertLevel_Fatal,HandshakeFailure)]" " expected: change cipher"
I do not know how to deal with it.

Hah, I actually encountered that in production a couple months ago and never files an issue. I simply catch the exception, ignore it, and retry the function.

flaky CI tests because of network errors or rate limits

I wasn't referring to this error specifically, but to flaky tests in general. The only real way to test this library is by talking to OANDA directly. This poses a problem because we will inevitably get network errors that we have to investigate, and also OANDA will only return the correct responses for some endpoints during certain times on weekdays. I just don't want to deal with the headache of maintaining the test suite.


Feature/proofList

Added new object that contains the arrays of potential credentials for proof requests
getRequestedCredentialsForProofRequest returns the new object
Added autoSelectCredentialsForProofRequest to have similar functionality as before
Indy credential info is now stored in RequestedPredicate and RequestedAttribute objects

Codecov Report

Merging #329 (aeb03fe) into main (ca6fb13) will increase coverage by 0.01%.
The diff coverage is 85.41%.

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   88.28%   88.29%   +0.01%
==========================================
  Files         220      224       +4
  Lines        4004     4042      +38
  Branches      465      446      -19
==========================================
+ Hits         3535     3569      +34
- Misses        469      473       +4

Impacted Files
Coverage Δ

src/storage/fs/index.ts
0.00% <0.00%> (ø)

src/modules/proofs/services/ProofService.ts
85.53% <84.61%> (+3.42%)
:arrow_up:

src/modules/proofs/ProofsModule.ts
88.31% <100.00%> (+0.31%)
:arrow_up:

src/modules/proofs/models/RequestedAttribute.ts
100.00% <100.00%> (ø)

src/modules/proofs/models/RequestedCredentials.ts
70.83% <100.00%> (-29.17%)
:arrow_down:

src/modules/proofs/models/RequestedPredicate.ts
100.00% <100.00%> (ø)

src/modules/proofs/models/RetrievedCredentials.ts
100.00% <100.00%> (ø)

src/modules/proofs/models/index.ts
100.00% <100.00%> (ø)

src/modules/indy/services/IndyHolderService.ts
89.47% <0.00%> (-5.27%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6fb13...aeb03fe. Read the comment docs.


Update utils.py for compatibility with Django 1.10 +

Updated for compatibility with Django 1.10 +
Replaced the get_all_field_names and get_field_by_name methods, which have been removed from the Model._meta API.
https://docs.djangoproject.com/en/2.0/ref/models/meta/#migrating-from-the-old-api

Hi,
I'm not maintaining this repository anymore. If it's useful to you, please let me know and we can discuss adding you as a maintainer.
Regarding the travis failure, it seems that you've used tabs, while the project is using spaces. Also, this will probably need some kind of backwards compatibility.
Thanks for your contribution!

Hey Matheiu,
Thanks for letting me know. I’ve overridden that method in my code and so am not too worried about the source being changed. But happy to make the changes if it’ll help others, seeing as I’m half way there!
Becky
From: Mathieu Agopian<EMAIL_ADDRESS>Reply-To: magopian/django-inspect-model<EMAIL_ADDRESS>Date: Friday, March 9, 2018 at 9:51 AM
To: magopian/django-inspect-model<EMAIL_ADDRESS>Cc: Becky Smith<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [magopian/django-inspect-model] Update utils.py for compatibility with Django 1.10 + (#5)
Hi,
I'm not maintaining this repository anymore. If it's useful to you, please let me know and we can discuss adding you as a maintainer.
Regarding the travis failure, it seems that you've used tabs, while the project is using spaces. Also, this will probably need some kind of backwards compatibility.
Thanks for your contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/magopian/django-inspect-model/pull/5#issuecomment-371765742, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AgEaNKnQgrIR_eMZRBIciE5I8Rm06Vscks5tclCFgaJpZM4Si_sS.
Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800.
Jisc Services Limited is a wholly owned Jisc subsidiary and a company limited by guarantee which is registered in England under company number 2881024, VAT number GB 197 0632 86. The registered office is: One Castle Park, Tower Hill, Bristol BS2 0JA. T 0203 697 5800.


Use graphql service from package

There was a import to the old local graphql service. Changed import to point to the new package.

Sorry for overlooking this and thank you for your contribution! Do you mind signing our contribution agreement if you haven't done already so we can merge this?

Thanks!


[REF] Drop system calls and separate out CLI

Closes #4 and references #2.
The only thing I'd watch out for is the fact that I removed a lot of calls to past functions (e.g., old_div). I review those changes and I don't think this should introduce any differences, but if we do find differences down the line, we should double-check those specific changes.
Changes proposed:

Remove most of the system calls that could easily be replaced with nibabel or nilearn code.
Format the remaining system calls so they're more readable. Most of these are FSL calls (e.g., MELODIC).
Split CLI code out of other workflows. Now these files are in a cli/ folder and are included in the setup.py as console scripts.
Add classification plotting code.

I've converted this to a draft because, the more I think about it, the more convinced I am that we should get an integration test up and running before we merge these changes.

I'm starting to think that this PR should be merged. I'm going crazy trying to make AROMA work. I'm finding all sorts of issues and having to apply changes you already made on this PR.

Basically, I can run it up to the point where the CSF and edge features are extracted. On that step I get an error because mask_csf.nii.gz does not exist.
Do you have this same issue?

I haven't tested it yet, but how about we just use the original version of AROMA for our integration test, so we don't have to worry about it for this PR? We can move forward with this PR and then get the outputs from the original AROMA workflow for the test afterwards.
I don't want to make too many changes to the repo before we have integration tests set up, because it will make it harder to track down the source of differences if there are differences, but we don't have to be too strict about it if the changes in this PR are useful.

Could you please check that you can run the entire pipeline?

Okay, it runs now.

@tsalo what do you think? Is there anything left on this PR?
If we merge this we can ask @CesarCaballeroGaudes to work on #6 and I could start #5 and #10 today for example.
Also, I think we can close #4 too.

I don't think there's anything else we need to do in this PR. Most of the remaining system calls will need more thought (e.g., removing MELODIC as a dependency and replacing regfilt).

Shall we merge then? It will be very helpful to tackle the remaining issues.


Fix broken links to docs_src/get_started/get_started.md

Fix broken links to tensorflow/tensorflow/docs_src/get_started/get_started.md

Can one of the admins verify this patch?

I signed it!

Can you repro that the links are broken? They seem to be working on tensorflow.org. If there is a bug, we would want to fix our custom link generator rather than short-circuiting it and using raw markdown.

I don't know why I cannot access tensorflow.org, so I can only learn TensorFlow from github, Is there anyway that the links work well in both link generator and markdown environment?

It sounds like the root issue to debug is that you can't access tensorflow.org. I don't think we're aiming to maintain the doc links in pure-markdown, but I'll let @josh11b comment on that.

I agree with @dandelionmane , our strategy is described in https://github.com/tensorflow/tensorflow/tree/master/tensorflow/g3doc
Maybe @martinwicke can offer suggestions for accessing these docs without tensorflow.org (a case we would like to support, for e.g. people who know they will be offline).

Actually, you can follow the instructions in that README, to generate an offline copy of the docs with the links fixed.

Closing this PR since the site is working as intended.

I got it, thank you.


Consider sending metadata required for decoding in-band

We could add new frame types: descriptors for registry data or something.
A registry should send it's name (we could limit the length of registry names), the current registry CRC (so if it changes we know telem is stale), the index into the total number of registry config frames there are, and then the payload.

This makes it simpler for single clients to be able to eventually figure everything out that they need to as well as adapt on the fly.
The HTTP interface is probably best used for debugging.

Probably we need to come up with a frame for sending registry data (in fragments?).
We can use the strategy of "cleaning" a registry config into a simple structure (like index<->value maps) that can be sent as fragments. For non-stream-oriented transmissions, we can encode the "fragment index" (i.e. out of some total) and just set some rate to send the fragments in order.

If we can define a registry as a "map" of integers to Strings, we can probably come up with a simple frame type for sending these kinds of maps. Maybe we can leave a field in for identifying what the map is (just a name?) where the protocol has reserved names for maps we know are of interest.

We should implement a CBOR sender maybe?

Closing this issue, it's very generic and the "consider" part of the title is complete, implementation occurring on other issues.


Add Testing framework & investigate SonarQube/SonarCloud Integration

To do

[ ] Select testing framework (nUnit, xUnit, MS test)

[ ] Add selected framework to project

[ ] Investigate SonarCloud/SonarQube integration with selected testing framework (how to export test results and coverage)

https://github.com/SonarSource/sonarcloud-github-action

https://github.com/SonarSource/sonarcloud-github-action


SerialPortReader

Hi,
I am using your library to communicate with a serial device. I can write to the serial port, but I am only able to read from the serial port using the read() method. I can't use the SerialPortReader() to perform the same action. This is how I use it:
 /// read when response is enabled
  Future<String> readSerial() async {
     // _sp is the the serial port I am working with.
    // This works
    print('num bytes available: ${(_sp.bytesAvailable)}');
    var data = _sp.read(_sp.bytesAvailable);
    print('data is ${utf8.decode(data)}');
    return utf8.decode(data);

    // This doesnot work
    log.info('reading from the serial port');
    final reader = SerialPortReader(_sp);
    if (reader != null) {
      log.info('listening to serial port');
      reader.stream.listen((data) {
        log.info('received: $data');
        return data.toString();
      });
      reader.close();
    }
    return null;
  }
}

Any help is appreciated.
P.S. It would be nice to mention in your example that the SerialPortConfig should be configured before opening the serial port. I assumed a default configuration was used and it took me a while to figure out that this should've been done. Thanks!

I'm unable to stream the data too. I had followed these steps to

Hi,
I am using your library to communicate with a serial device. I can write to the serial port, but I am only able to read from the serial port using the read() method. I can't use the SerialPortReader() to perform the same action. This is how I use it:
 /// read when response is enabled
  Future<String> readSerial() async {
     // _sp is the the serial port I am working with.
    // This works
    print('num bytes available: ${(_sp.bytesAvailable)}');
    var data = _sp.read(_sp.bytesAvailable);
    print('data is ${utf8.decode(data)}');
    return utf8.decode(data);

    // This doesnot work
    log.info('reading from the serial port');
    final reader = SerialPortReader(_sp);
    if (reader != null) {
      log.info('listening to serial port');
      reader.stream.listen((data) {
        log.info('received: $data');
        return data.toString();
      });
      reader.close();
    }
    return null;
  }
}

Any help is appreciated.
P.S. It would be nice to mention in your example that the SerialPortConfig should be configured before opening the serial port. I assumed a default configuration was used and it took me a while to figure out that this should've been done. Thanks!

I'm unable to stream data either. I defined the ports, configured them and opened to read, but the streamer doesn't seem to provide any kind of data. Is there a reason this happens?

Maybe it's because you call reader.close(); right away?


feat: document symbols

Current dependencies on/for this PR:

main

PR #69   👈

This comment was auto-generated by Graphite.

👀


Update turbiniactl output to handle high task counts

Because of the way the partition and docker explorer enumeration works we end up with a lot more Tasks being run now.  A couple ideas for things we can update so that the output is not too cluttered:

Aggregate Tasks with similar status output in default status view
Update the logging output to remove or aggregate task names when waiting for the Turbinia run to complete

These are now aggregated in the status view (when full details are not being shown).


Value seen selected in protocol dropdown is incorrect

On master-head - commit id: 33f755f18

Dashboard --> Workloads --> Deployments -->Create deployment --> Add Port
Protocol dropdown has default value TCP
Click on the protocol dropdown and select UDP
Click on protocol dropdown again
Value seen selected in protocol dropdown is TCP

This is part of the generic upstream dropdown component that we use

Reproduced the issue 2.5-head,
Steps:

From Dashboard --> Deployments -->Create deployment --> Add Port
Select UDP protocol
If you click the drop-down menu, TCP is high lighted as a select protocol

Tested with 2.5-head, commit v2.5-3d7ffc9
steps

From Dashboard --> Deployments -->Create deployment --> Add Port
Select UDP protocol
If you click the drop-down menu, UDP is highlighted as a select protocol

The fix looks good.


Fixing undefined behavior reported externally.

Fixing undefined behavior reported by Ian McCormack (@icmccorm).
Fix has been verified.

I think that this type of issue can only reliably detected by Miri. Once Miri has support for foreign function calls or Krabcake is ready, then you'd be able to check for this by running existing tests in CI.

Released 0.2.1.
Thanks @victor-m-alvarez!


Project outdated

This project seems to be outdated, most likely the author forgot about or doesn't have the time anymore.
I'll make a fork and will try to make updates from time to time.

No I did not! :)


Problems with long running connections

Hi, I'm using SNC Redis with multiple connections - default is for things I care about, while cache is for things that may die.
Now, my problem is that when I use the default connection (blocking on blpop) together with a second connection for the cache, the cache blows up when blpop returns and I start using the cache since the cache connection has timed out.
Should I use connection_persister:true here or is there another parameter I should use ?

I think this issue can be closed because it is very old and the issue did not occur again for 2-3 years.


Add system test repo specific fields to grinder job template

We need to add the following three system test repo specific fienls to grinder job template :

Field Name
Description
Default value

ADOPTOPENJDK_SYSTEMTEST_OWNER_BRANCH
Personal Adoptopenjdk/openjdk-systemtest repository owner:branch
AdoptOpenJDK:master

OPENJ9_SYSTEMTEST_OWNER_BRANCH
Personal eclipse/openj9-systemtest repository owner:branch
eclipse:master

STF_OWNER_BRANCH
Personal stf repo owner:branch
AdoptOpenJDK:master

FYI @ShelleyLambert @llxia

Hi can you please tell me more about this issue so that I can work on it like what files to look etc, @Mesbah-Alam @ShelleyLambert @llxia .
Thank You.
PS: I am an Outreachy applicant

Hi @2001asjad - the changes required to address this issue is to add these parameters with their descriptions and default values (as mentioned in the table above) into the testJobTemplate file just after the TKG_SHA parameter.  You can see based on the other parameters being set in this file the pattern to follow.
If you want to take this issue, let me know and I will assign it to you.  Once you have a PR, we can help you test your changes at the ci.adoptopenjdk.net Jenkins server.

Thank You @smlambert and yeah I definitely wanna work on this issue, please assign this to me.
Gonna update you soon with a PR.
Once again thank you so much for providing the info above.

Made a PR, @smlambert can you please take a look. Eagerly waiting for your suggestions


Delegate the care of a directly given block from cipop() to cipush()

Outlines:

Removed mrb_callinfo::blk
Added mrb_callinfo::flags
Added MRB_CI_COMPANION_BLOCK flag

Evaluation of benchmark/ by valgrind --tool=cachegrind.

ref
commit hash

3.2.0
87260e7bb1a9edfb2ce9b41549c4142129061ca5

3.3.0
32279e4128527bab4c961854b9cce727a060abea

master
0a11af74f46f3dadf7a63c18350582f56967897f

This PR
ad2e626e7a937fb4de9a1647aa58ea45aa3936ec

The first half is the result of building with gcc13 -O3 and the second half with gcc13 -Os.
###  cachegrind.report.bm_ao_render.rb (-O3)  ###
         52,089,700,230 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/87260e7bb1a9edfb2ce9b41549c4142129061ca5
         51,181,880,488 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/32279e4128527bab4c961854b9cce727a060abea
         49,868,402,004 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/0a11af74f46f3dadf7a63c18350582f56967897f
         49,142,003,384 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec
###  cachegrind.report.bm_app_lc_fizzbuzz.rb (-O3)  ###
        113,142,773,218 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/87260e7bb1a9edfb2ce9b41549c4142129061ca5
        109,835,348,760 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/32279e4128527bab4c961854b9cce727a060abea
        111,130,342,606 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/0a11af74f46f3dadf7a63c18350582f56967897f
        109,632,457,055 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec
###  cachegrind.report.bm_fib.rb (-O3)  ###
         40,929,715,169 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/87260e7bb1a9edfb2ce9b41549c4142129061ca5
         40,577,677,322 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/32279e4128527bab4c961854b9cce727a060abea
         40,969,219,903 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/0a11af74f46f3dadf7a63c18350582f56967897f
         40,031,097,122 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec
###  cachegrind.report.bm_so_lists.rb (-O3)  ###
          8,522,235,407 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/87260e7bb1a9edfb2ce9b41549c4142129061ca5
          7,631,663,865 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/32279e4128527bab4c961854b9cce727a060abea
          7,727,386,309 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/0a11af74f46f3dadf7a63c18350582f56967897f
          7,541,325,048 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-O3/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec

-----

###  cachegrind.report.bm_ao_render.rb (-Os)  ###
         74,225,703,810 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/87260e7bb1a9edfb2ce9b41549c4142129061ca5
         73,476,286,317 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/32279e4128527bab4c961854b9cce727a060abea
         72,352,438,226 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/0a11af74f46f3dadf7a63c18350582f56967897f
         71,751,683,217 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec
###  cachegrind.report.bm_app_lc_fizzbuzz.rb (-Os)  ###
        152,467,661,758 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/87260e7bb1a9edfb2ce9b41549c4142129061ca5
        152,848,538,722 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/32279e4128527bab4c961854b9cce727a060abea
        152,391,614,189 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/0a11af74f46f3dadf7a63c18350582f56967897f
        151,519,743,117 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec
###  cachegrind.report.bm_fib.rb (-Os)  ###
         60,395,889,742 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/87260e7bb1a9edfb2ce9b41549c4142129061ca5
         61,333,665,848 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/32279e4128527bab4c961854b9cce727a060abea
         61,412,528,682 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/0a11af74f46f3dadf7a63c18350582f56967897f
         60,787,116,179 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec
###  cachegrind.report.bm_so_lists.rb (-Os)  ###
         12,963,015,554 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/87260e7bb1a9edfb2ce9b41549c4142129061ca5
         11,787,324,255 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/32279e4128527bab4c961854b9cce727a060abea
         11,823,083,270 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/0a11af74f46f3dadf7a63c18350582f56967897f
         11,619,017,677 (100.0%)  PROGRAM TOTALS  /var/tmp/mruby/-Os/ad2e626e7a937fb4de9a1647aa58ea45aa3936ec

Addendum.
Regarding MRB_CI_COMPANION_BLOCK, this patch uses “companion” as the opposite of “orphan”.
However, I don't know the exact term, nor do I have any evidence for it.
So I hope you will change MRB_CI_COMPANION_BLOCK to the correct name.

One more addition.
The current MRB_PROC_ORPHAN is 512.
So, to make it “orphan” when creating the proc object,

MRB_PROC_ORPHAN = 0.
MRB_PROC_COMPANION = 512 (name is temporary)

There may be a future with such a change.


Phpcbf command with wordpress standard throws fatal error

I see phpcs -standard=wordpress works fine but in the case of phpcbf it throws fatal error. It does not hapen when I use phpcbf without WordPress standard.
The issue happens when running this command:
➜  ~ phpcbf --standard=WordPress /Users/muhammadzaki/"Local Sites"/max-slider/app/public/wp-content/plugins/rex-slider/public/class-rex-slider-public.php
Error I am seeing:
PHP Fatal error:  Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/muhammadzaki/wpcs/WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php on line 280 in /Users/muhammadzaki/.composer/vendor/squizlabs/php_codesniffer/src/Runner.php:604
I am using php 8.2
installed latest phpcs and wpcs from GitHub.

Closing as duplicate of various issues, all already fixed.
For the next time, please:

Search the issues before reporting.
Use the issue/bug template.
Any report without a code sample to reproduce is useless.
Check against the developbranch.


[Feature] Support to Supabase Storage

Feature Request
Supabase is an open-source Firebase alternative. That allows us to start a project with a Postgres Database, Authentication, instant APIs, Realtime subscriptions, and Storage.
My feature request is to support Supabase Storage as one of the storage providers of libcloud.
Many solutions use libcloud internally, so adding Supabase will allow many developers to integrate their solutions more easily, augmenting/improving both the libcloud and Supabase ecosystems.
https://supabase.com/docs/guides/storage

Do you happen to know if they expose S3 / OpenStack Swift sompatible or similar API so we could re-use existing primitives in the Libcloud?
Or they have a custom / home grown REST API?

EDIT: It appears they expose custom / home grown swagger based REST API - https://supabase.github.io/storage-api/


feat: display an upgrade message for the CLI

This PR displays an upgrade message for the CLI if there's an update available

Issue Reference(s):
Fixes #930
Build & Testing:

[x] I ran cargo test successfully.
[x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

/claim #930

@tusharmath
Could I get a review on this?

This is a lot of code to maintain. Is there a crate for this? Posted this on reddit to get some help - https://www.reddit.com/r/rust/comments/196f0kr/crate_for_checking_if_a_newer_version_of_the/

@tusharmath Could I get a re-review on this?
I refactored the code use update-informer crate

@meskill
Pushed a new commit

Getting the following error.
❯ APP_VERSION=0.5.0 cargo run -- check ./examples/jsonplaceholder.graphql
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/tushar/Documents/Projects/tailcall/cloudflare/Cargo.toml
workspace: /Users/tushar/Documents/Projects/tailcall/Cargo.toml
    Finished dev [unoptimized + debuginfo] target(s) in 0.40s
     Running `target/debug/tailcall check ./examples/jsonplaceholder.graphql`
[2024-01-27T06:33:45Z INFO  tailcall::cli::file] File read: ./examples/jsonplaceholder.graphql ... ok
[2024-01-27T06:33:45Z INFO  tailcall::cli::tc] Config successfully validated
N + 1: 1

thread 'main' panicked at /Users/tushar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/runtime/blocking/shutdown.rs:51:21:
Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@tusharmath
Fixed


Add a ConverterProgressBar class

... that automatically converts a byte input into a fitting output format (kb, MB, etc.) either according to the size of the max bits input or trough a method parameter.

Added with commit 85c6172


docker rate limits in CI

This is going to get worse as we expect more contributors, so we should nip in the bud.
Hit on this job: https://github.com/0xPolygonZero/zk_evm/blob/f65fbd0d45f04cc923edb2b51b526cfa3de05fff/.github/workflows/jerigon-native.yml#L63
https://github.com/0xPolygonZero/zk_evm/actions/runs/10282343424/job/28453842425?pr=469#step:10:152
Error:  An error occurred running the pre-validation-and-run function
  Caused by: An error occurred creating a new Kurtosis engine client
...
  Caused by: Tried pulling image 'timberio/vector:0.31.0-debian' with platform '' but failed
  Caused by: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

We should check with devops, there are probably existing CI credentials to log in to dockerhub on the start of the job CC @praetoriansentry

Hit this again in https://github.com/0xPolygonZero/zk_evm/actions/runs/10725019808/job/29741954893?pr=596


Discussion-Forum-Admin-App - Sprint 2

Description:
Build the Screen to match the Figma design.
Integrate Screen with the Backend

I will work on this issue

hello @Honeyloveet , I'll like to work on this. kindly assign it to me. Thank you


Fix Oregen Pattern Info received to late

Fixes https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/14081
The packet with the oregen pattern used by the server i sent by GT on PlayerEvent$PlayerLoggedInEvent. However, VP builds the client cache on EntityJoinWorldEvent, which is fired earlier. Thus, VP only has GT's default to work with, unless the player disconnects and then reconnects to the same server. This PR delays the client caching by also using PlayerEvent$PlayerLoggedInEvent but with low priority.
BS update and a small cleanup included for free.

Work and tested mp by HelffirePVP


non-codeblock admonitions broke in 6.2.8

Hello.

Settings:

Markdown:
!!! ad-danger

test

--- admonition

Think this is fixed now...sorry for the issues!


HTML of resistances and immunities uses "data-weakness"

I found this in the debugger of HTML elements when opening an NPC actor sheet:

Apparently, all three of IWR use "data-weakness" - a misleading name, when only one is about weakness while the other two are about the opposites.
This bug doesn't affect users, but it confused me as a modder.

Sure thing, when this refactor happens I'll just need to remember to patch https://github.com/itamarcu/pf2e-see-simple-scale-statistics

Feel free to make a PR if you need it fixed for your module.

Seems like this was fixed anyway! :]


Add tip about --no-verify to CONTRIBUTING.md

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Changelog fragments have been written (if appropriate)
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[x] Targeting master unless this is a cherry-pick backport
[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Another way to make a commit outside of the nix shell is to install pre-commit.
While you are at it, can you mention this option and link to https://pre-commit.com/#install?

I've merged Lorenzo's. Closing this.


MarGo fails with newest version of Go.

| GoSublime error: MarGo build failed
|                > This is possibly a bug or miss-configuration of your environment.
|                > For more help, please file an issue with the following build output
|                > at: https://github.com/DisposaBoy/GoSublime/issues/new
|                > or alternatively, you may send an email to<EMAIL_ADDRESS>|                >
|                >
|                > cmd: ['/usr/local/go/bin/go', 'build', '-v', '-x', '-o', 'gosublime.margo_r13.08.31-1_go1.1.2.exe', 'gosubli.me/margo']
|                > stdout: WORK=/tmp/go-build104457796
|                > stderr: ../../../../GoSublime/src/gosubli.me/margo/broker.go:4:2: cannot find package "bufio" in any of: |                > 	~/go/src/pkg/bufio (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/bufio (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/broker.go:5:2: cannot find package "bytes" in any of: |                > 	~/go/src/pkg/bytes (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/bytes (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:5:2: cannot find package "encoding/base64" in any of: |                > 	~/go/src/pkg/encoding/base64 (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/encoding/base64 (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/broker.go:6:2: cannot find package "encoding/json" in any of: |                > 	~/go/src/pkg/encoding/json (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/encoding/json (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/package.go:5:2: cannot find package "errors" in any of: |                > 	~/go/src/pkg/errors (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/errors (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/main.go:7:2: cannot find package "flag" in any of: |                > 	~/go/src/pkg/flag (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/flag (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:7:2: cannot find package "fmt" in any of: |                > 	~/go/src/pkg/fmt (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/fmt (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:8:2: cannot find package "go/ast" in any of: |                > 	~/go/src/pkg/go/ast (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/go/ast (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_play.go:5:2: cannot find package "go/build" in any of: |                > 	~/go/src/pkg/go/build (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/go/build (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:9:2: cannot find package "go/parser" in any of: |                > 	~/go/src/pkg/go/parser (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/go/parser (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:10:2: cannot find package "go/printer" in any of: |                > 	~/go/src/pkg/go/printer (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/go/printer (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_lint.go:6:2: cannot find package "go/scanner" in any of: |                > 	~/go/src/pkg/go/scanner (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/go/scanner (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/common.go:11:2: cannot find package "go/token" in any of: |                > 	~/go/src/pkg/go/token (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/go/token (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/config.go:7:2: cannot find package "io" in any of: |                > 	~/go/src/pkg/io (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/io (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:9:2: cannot find package "io/ioutil" in any of: |                > 	~/go/src/pkg/io/ioutil (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/io/ioutil (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/main.go:10:2: cannot find package "log" in any of: |                > 	~/go/src/pkg/log (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/log (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/types/const.go:12:2: cannot find package "math/big" in any of: |                > 	~/go/src/pkg/math/big (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/math/big (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/server.go:5:2: cannot find package "net" in any of: |                > 	~/go/src/pkg/net (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/net (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_pkgdoc.go:7:2: cannot find package "net/http" in any of: |                > 	~/go/src/pkg/net/http (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/net/http (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/client.go:7:2: cannot find package "net/rpc" in any of: |                > 	~/go/src/pkg/net/rpc (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/net/rpc (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_pkgdoc.go:8:2: cannot find package "net/url" in any of: |                > 	~/go/src/pkg/net/url (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/net/url (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:10:2: cannot find package "os" in any of: |                > 	~/go/src/pkg/os (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/os (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/os_posix.go:8:2: cannot find package "os/exec" in any of: |                > 	~/go/src/pkg/os/exec (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/os/exec (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_doc.go:7:2: cannot find package "path" in any of: |                > 	~/go/src/pkg/path (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/path (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:11:2: cannot find package "path/filepath" in any of: |                > 	~/go/src/pkg/path/filepath (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/path/filepath (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/config.go:10:2: cannot find package "reflect" in any of: |                > 	~/go/src/pkg/reflect (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/reflect (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/margo/m_lint.go:9:2: cannot find package "regexp" in any of: |                > 	~/go/src/pkg/regexp (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/regexp (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:12:2: cannot find package "runtime" in any of: |                > 	~/go/src/pkg/runtime (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/runtime (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:13:2: cannot find package "sort" in any of: |                > 	~/go/src/pkg/sort (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/sort (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/client.go:10:2: cannot find package "strconv" in any of: |                > 	~/go/src/pkg/strconv (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/strconv (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/decl.go:10:2: cannot find package "strings" in any of: |                > 	~/go/src/pkg/strings (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/strings (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/decl.go:11:2: cannot find package "sync" in any of: |                > 	~/go/src/pkg/sync (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/sync (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/package.go:13:2: cannot find package "text/scanner" in any of: |                > 	~/go/src/pkg/text/scanner (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/text/scanner (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/autocompletecontext.go:14:2: cannot find package "time" in any of: |                > 	~/go/src/pkg/time (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/time (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/cursorcontext.go:6:2: cannot find package "unicode" in any of: |                > 	~/go/src/pkg/unicode (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/unicode (from $GOPATH) |                > ../../../../GoSublime/src/gosubli.me/something-borrowed/gocode/cursorcontext.go:7:2: cannot find package "unicode/utf8" in any of: |                > 	~/go/src/pkg/unicode/utf8 (from $GOROOT) |                > 	~/.config/sublime-text-2/Packages/GoSublime/src/unicode/utf8 (from $GOPATH)
|                > exception: None
|   install state: busy
| sublime.version: 2221
| sublime.channel: stable
|       about.ann: a13.09.07-1
|   about.version: r13.08.31-1
|         version: r13.08.31-1
|        platform: linux-x64
|            ~bin: ~/.config/sublime-text-2/Packages/User/GoSublime/linux-x64/bin
|       margo.exe: ~bin/gosublime.margo_r13.08.31-1_go1.1.2.exe (missing)
|          go.exe: /usr/local/go/bin/go (ok)
|      go.version: go1.1.2
|          GOROOT: ~/go
|          GOPATH: ~/go/bin
|           GOBIN: (not set) (should usually be (not set))
|       set.shell: []
|       env.shell: /bin/bash
|       shell.cmd: ['/bin/bash', '-l', '-c', '${CMD}']

i get the same trouble！

I got this issue on Windows using go 1.5. Go version was not picked up and defaults to "go?" in the Margo compiled filename which is an invalid under windows. Suspect the regex is wrong in .\GoSublime\gosubl\about.py but since my regex is rusty, I just changed DEFAULT_GO_VERSION to "go1.5". Compiles OK now.


 How do you reproduce it?
Currently using the Chrome extension, version 2.2.2. By using "Show All Fields" command on a form, all fields get marked dirty as well. Saving the form after showing all fields erroneously triggers plugins and flows that have filter criteria different than the fields that are actually changed.
What is the expected behavior?
Clicking "Show All Fields" should not set fields to dirty if they are not changed. Perhaps before setting the field visibility, the dirty-ness of the field can be tracked and set accordingly after the visibility change.
Please tell us about your environment:**
Chrome, using the 2.2.2 version of the Toolbox. Latest version of Dynamics (2020 Release wave 1; 9.1.0000.2251).
Other information
End-user here complained about this problem describing it as such: they have a flow that triggers on a field that is not visible by default. They used Show All Fields, updated a different field, and then hit save. The flow was still triggered although the field that's supposed to trigger it was not actually changed. Unfortunately, flows still do not have support for pre/post-image type comparisons, so it's not possible to just add a condition to the flow to check before/after for non-updates.

From the user: "and just another observation...if you use the dirty fields functionality in the toolbox it will only show you the one(s) you updated as dirty, but in the background it's really sending all fields on the form as described above"

Thanks so much for the detailed report! Super helpful.
I'm guessing this is the Unlock All Fields feature? If so, it's probably the setSubmitMode call here that is doing it.
I'm guessing instead of always it should be set to dirty, but if you could help confirm that, I can definitely patch it up and push a new version!

Assuming I was right, this should be fixed in #38 (v2.2.3) for v9+.

The person who originally submitted this to me confirmed that the update you pushed fixed their issue. Thanks Dibbs!! You are way too good to us with that super fast turnaround.


Perturbations don't have effect in the gMLV model

Describe the bug
Would be good to look at the perturbations in the gMLV model as they don't seem to have an effect at the moment.
To Reproduce
You can see this in the gLV examples.

This is fixed now. It was an issue in specifying the perturbation information.


Deploying ceph multiple times causes authentication error.

Is this a request for help?:
Yes
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:
kubernetes 1.8.3
Which chart:
ceph
What happened:
I have a kubernetes deployment running. When I try to deploy ceph for the first time, it works fine.
But when I purge ceph helm chart and redeploy ceph, ceph-mon, ceph-mon-check works fine but ceph-mds, ceph-mgr have an authentication failure and timeout connecting to ceph-mon.
What you expected to happen:
I would expect that all the services are able to connect to monitor without any authentication issues.
How to reproduce it (as minimally and precisely as possible):
Deploy ceph, purge ceph chart, deploy ceph again.
Anything else we need to know:
Something to note: I am not deleting the hostpath folder in the nodes on which ceph is being re deployed. I was expecting that redeploying would persist the content of ceph.

You need to delete /var/lib/ceph-helm/ceph/mon/* manually on each ceph-mon host before a re-run.
We haven't been able to work on fixing this yet

@alram Would that persist the data ?


Every several hours (10 to 24) cookies expire or something...

And my bot just sends me this message:
.
But if I refresh cookies from the site, it will work again for the next 10-24 hours.
Cookies expirationDate is in two weeks and in a month for some of them.
Should I really change the cookies every ~10 hours?
Or what am I doing wrong?

Expires if you log in again / use web browser

So, please, guide me, what can I do to avoid it?
Log out in browser?
Do not ever restart the script when runned, once I set new cookies?
 Additional context

I made it a telegram bot, work in progress, so I need to restart it for testing purposes.
I've noticed that sometimes it works until you restart, and sometimes it just stops working, so to speak, the next morning.
I've never seen it work for more than a day without updating a cookies.

What happens when I restart the script? Why does it stop working?
Did cookies being updated while running script (in runtime)?
Maybe we then should save them back to file if it so?
Then we can restart without such problems.

You can use translation to understand.
我的建议是,你应该拥有两个Microsoft帐户,并同时申请New Bing.
其中一个帐户在 登陆、打开bing官网、获取cookie后粘贴到txt文本中,随后应立即退出此Microsoft帐户.
之后,将之前保存出来的包含cookie的txt文件存为json并按照要求保存至目录.
随后在自己设备的浏览器上登录自己的另一个帐户.
以上的操作意义在于:为逆向工程提供一个专属的cookie,而平时通过自己设备浏览器使用的是另一个帐户,与服务器不冲突
我的操作,仅作参考.

我将尝试这种方法并回来反馈，谢谢

no, that didn't help. still logs off after no more than 12 hours

Still relevant

same probleme.

@ynizon I created #378, like it if you still have to deal with it


DATAGEODE-137 - Fix typo in documentation

[x] You have read the Spring Data contribution guidelines.
[x] You created a JIRA ticket in the bug tracker for the project.
[x] You formatted the code according to the source code style provided here and have specifically applied them to your changes. Do not submit any formatting related changes.
[ ] You submitted test cases (Unit or Integration Tests) backing your changes.
[ ] You added yourself as the author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
[ ] If applicable, you have complied with and taken steps necessary to report any security vulnerabilities at Pivotal Security Reporting.

Closing this PR as John as fixed this.


Simplify JS generation

Previous version was declaring types + members with an API, so it created reflection information while generating types and members. Now that information is duplicated, since already provided by the compile-time generation reflection plugin. Also maybe it improves startup time a bit if js engines can properly cache the initial state.

Doing this, the startup time has been reduced noticeably which is great.


v0.11.2

:+1: I need this patch

I don't need this anymore... I rolled back to the 0.10.5.

@AndrewCarterUK completely agree. It's baffling that there are over 33 valid pull requests and not a single action.

@jharding What's the status on this project? It seems temporarily abandoned.

@Downchuck There is a tweet from one of the lead developers that states they are only fixing issues in version 1.0 which, as you can see, is semi-vaporware. It would be nice if these simple things could be merged to tide us over though.

https://twitter.com/JakeHarding/status/598947982881390592

@tm1000 looks like they should have release 0.11 as 1.0, regardless of bugs, as it's an API change from 0.x.

The fix in 173b4b5 appears to be a sufficient fix for the litany of issues and PRs around this issue. Any chance of this release getting fast tracked so we can close out #1212, #1224, #1284, #1316, #1319, #1331, and #1332 (among others)?

:+1: Please fast track

It's been almost a year (just a few days left) since the last release
Is there a schedule for next release?

Will it be merged into master once ?

This project is essentially dead and only twitter knows why.

Updated library in active development (a fork of this one from some great users)
https://github.com/corejavascript/typeahead.js

Legacy software is so legacy

I really wonder why this thing is not released for a whole year
Maybe no one is maintaining it?

I really wonder why this thing is not released for a whole year
Maybe no one is maintaining it?

That is exactly why!

Personally and for my company we started to use
https://www.npmjs.com/package/jquery-typeahead

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 4 committers have signed the CLA.:x: jharding:x: Jake Harding:x: chip-miller:x: evverxJake Harding seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove MANIFEST and ensure retrocompat with Bazel < 7.0.0

See commits

Closing this since my contribution was stolen


Problems with building workspace

Hello!
When I try to run the "LonaStudio.xcworkspace" in Xcode Version 9.0 beta 5 (9M202q).
The build failed:

Okay I found more information:
According to the beta 5 release notes:
"Building macOS apps with the AVFoundation framework is not supported with Xcode 9 beta 5."
Is it possible to fix this?
Thanks in advance
Dennis

Hmm... based on that error message, I'm wondering if it'll build for you in Xcode 9 non-beta? I use AVFoundation for exporting animations to video, so I don't think I can solve that.

I can’t vouch for beta but built with no issues in Xcode 9.
Make sure you’ve run pod install and opened the workspace.
Maybe try clearing the derived data folder and doing a build clean.
Harry Walter
M: +44 (0)784 9503 950tel:+44 784 9503 950
W: harrywalter.co.ukhttp://harrywalter.co.uk/
On 4 December 2017 at 20:22:36, Devin Abbott (notifications<EMAIL_ADDRESS>wrote:
Hmm... based on that error message, I'm wondering if it'll build for you in Xcode 9 non-beta? I use AVFoundation for exporting animations to video, so I don't think I can solve that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/airbnb/Lona/issues/28#issuecomment-349093341, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAUqnCgMq8jresV-0orMQo9qQOIje9wOks5s9FSLgaJpZM4QwRrO.

Hi @dabbott, @haswalt,
I downgraded my Xcode. I'm now able to build Lona and that has solved the problem!
Thanks for your support.
Dennis


Release Version 1.0.6

Coverage: 93.694%. Remained the same when pulling 292ab123ac854466bdbadccab6ba9e76548c8825 on cody-version-1.0.6 into 793168652dd7ea45649d29ae9c4833a5f0df77fb on main.


Support parsing python pre-release versions

Proposed changes
Python pre-release versions aren't quite the same as standard semver. This change parses that case and transforms them into standard semver.
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)

Checklist

[x] I have read the
CONTRIBUTING
doc
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

It looks like this is the python docs on versions:
https://peps.python.org/pep-0440/#public-version-identifiers

@JoshuaTheMiller You know what they say, if you have a problem that requires a regular expression to solve it, now you have two problems.


Dev > Master

Many thanks to contributing to nf-core/chipseq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist

[ ] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/chipseq branch on the nf-core/test-datasets repo
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[x] Make sure your code lints (nf-core lint .).
[x] Documentation in docs is updated
[x] CHANGELOG.md is updated
[x] README.md is updated

Learn more about contributing: https://github.com/nf-core/chipseq/tree/master/.github/CONTRIBUTING.md

I think it'll be good to mention all the param changes in the CHANGELOG in a deprecated section.
cf: https://github.com/nf-core/sarek/blob/master/CHANGELOG.md#deprecated
And since we're not warning about all changes anywhere, I think it could also be good to have a similar warning message in the main.nf just in case someone is trying to use and old param.
cf: https://github.com/nf-core/sarek/blob/05c6e0b63251af83b9e7d5b259cec9e679fccf57/main.nf#L107-L113

I think it'll be good to mention all the param changes in the CHANGELOG in a deprecated section.
cf: https://github.com/nf-core/sarek/blob/master/CHANGELOG.md#deprecated
And since we're not warning about all changes anywhere, I think it could also be good to have a similar warning message in the main.nf just in case someone is trying to use and old param.
cf: https://github.com/nf-core/sarek/blob/05c6e0b63251af83b9e7d5b259cec9e679fccf57/main.nf#L107-L113

I think theres a fine line between bloating both main.nf with warnings and the CHANGELOG. You have to bear in mind that I have changed ~16 parameters 😓 Im happy to add this change to the top of the CHANGELOG in bold.

+1 for adding to the changelog and only there. Will hopefully have parameter linting soon anyway.. 😉 ✨

What do you think about adding a single line for this at the top of the relevant section i.e.
Change all parameters from camelCase to snake_case
as opposed to listing them all explicitly?

Your going to hate me, but I would list then all...

This ok now?
https://github.com/drpatelh/chipseq/blob/master/CHANGELOG.md#deprecated

Updated the atacseq pipeline appropriately too.

Thanks you!! 👍

Thanks @MaxUlysse . Ill merge in the changes from dev and release this on Monday then 👍


breakout-v0 with  initial parameter got a terrible performance

hi, i run this code with the  initial parameters: model='m1' with game breakout-v0. after about 8days' gpu training, when the program finished, i evaluated the model and got average-reward 22.0， which has a big difference with your screenshot(score=300+)。
And another experiment only with the switch(duel=True, double_q=True) on, the model's average-reward equals 5.4. Even worse than the original DQN.
Is there any trick  i missed ? thanks for your replay!

hi, i run this code with the initial parameters: model='m1' with game breakout-v0. after about 8days' gpu training, when the program finished, i evaluated the model and got average-reward 22.0， which has a big difference with your screenshot(score=300+)。
And another experiment only with the switch(duel=True, double_q=True) on, the model's average-reward equals 5.4. Even worse than the original DQN.
Is there any trick i missed ? thanks for your replay!

i also want to konw it

I wrote a dqn myself, but I also got a bad score. I suspect it's the environmental problem of gym

you can use 'BreakoutNoFrameskip-v0' instead 'Breakout-v0' ,because the environment in 0.17 version gym is diffrent


Typo in name of dependency update bot: Renovate

Describe the bug
Spelling error in name of dependency bot in these file(s):
https://github.com/ossf/scorecard/blob/c6d76807b76b7b72659525e103d6b1284c7b01b5/checks/raw/dependency_update_tool.go#L91
https://github.com/ossf/scorecard/blob/c6d76807b76b7b72659525e103d6b1284c7b01b5/e2e/dependency_update_tool_test.go#L84
Reproduction steps
Steps to reproduce the behavior:

Open the ossf/scorecard repository
Search for string Renovabot
Find these two files

The bad spelling also shows up in the response body:
curl -X 'GET' \
  'https://api.securityscorecards.dev/projects/github.com/renovatebot/renovate' \
  -H 'accept: application/json'

    {
      "name": "Dependency-Update-Tool",
      "score": 10,
      "reason": "update tool detected",
      "details": [
        "Info: Renovabot detected: renovate.json:1"
      ],
      "documentation": {
        "short": "Determines if the project uses a dependency update tool.",
        "url": "https://github.com/ossf/scorecard/blob/c61f6bc297ee71dc4b5f2511144d6c031b946089/docs/checks.md#dependency-update-tool"
      }
    },

Expected behavior
Change Renovabot to Renovate.
Additional context
I don't know how hard it is for a newcomer to fix this problem? It looks like I can just rename the two entries in the files, and then create a PR?
Related issue:

#2055

@naveensrinivasan would you be able to take this on?


.python-version overrides inline script metadata required-python for uv run

I ran a script with uv run, and .python-version in the current directory overrode required-python in the inline script metadata. The version in .python-version wasn't in the range of required-python. When the script ran with the wrong Python version, it failed. The problem took me five minutes to debug. I am not sure what should happen in this situation, but it confused me, so I am reporting it. (I think I'd prefer uv to either report a conflict in the  Python version requirements and not run the script or to ignore .python-version in favor of required-python.)
I encountered this conflict on Ubuntu 24.04 on x86-64. uv was installed with pipx. Here is a POSIX shell script to reproduce it.
#! /bin/sh
set -e

uv --version

cat >demo.py <<EOF
#! /usr/bin/env -S uv run
# /// script
# dependencies = [
#   "httpx<2",
# ]
# requires-python = ">=3.10"
# ///

import sys
print(sys.version)
EOF

chmod +x demo.py

rm .python-version || true
./demo.py

echo 3.7 >.python-version
./demo.py

Output:
uv 0.4.1
Reading inline script metadata from: ./demo.py
Installed 7 packages in 4ms
3.12.1 (main, Jan 31 2024, 04:48:37) [GCC 11.4.0]
Reading inline script metadata from: ./demo.py
Installed 9 packages in 3ms
3.7.17 (default, Oct 16 2023, 22:17:29)
[GCC 11.4.0]

Definitely wrong, thanks!


Add tkong-redhat and Tafhim to reviewers list & remove jwai

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.94%. Comparing base (07010d8) to head (fc927be).

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #169       +/-   ##
===========================================
- Coverage   80.22%   54.94%   -25.28%
===========================================
  Files           6        7        +1
  Lines         359      637      +278
===========================================
+ Hits          288      350       +62
- Misses         64      277      +213
- Partials        7       10        +3

see 1 file with indirect coverage changes

/retest

/retest

/lgtm

/approve


Kontra.js doesn't work on Internet Explorer 11

I been trying to test kontra.js on Windows phone with Internet explorer 11 but none of the games or examples will load. Any ideas as to why? IE11 supports canvas and webgl.

It's because kontra is written in ES modules as of v6. You'll need to compile it using something like Rollup into non-es module code.

Oh I see. Is such a pity 😢 Well thanks for letting me know.


Session is no longer valid (code: 4006)

When my bot is in a voice channel for too long
I am facing this problem
{
op: 'event',
reason: 'Session is no longer valid.',
code: 4006,
byRemote: true,
type: 'WebSocketClosedEvent',
guildId: ''
}
Output of java -version:
java version "18" 2022-03-22
Java(TM) SE Runtime Environment (build 18+36-2087)
Java HotSpot(TM) 64-Bit Server VM (build 18+36-2087, mixed mode, sharing)

Version:        c47990b9493f224773a45ef23244b11e4aeadf7c-SNAPSHOT
Build:          1353
Build time:     10.06.2022 18:37:07 UTC
Branch          dev
Commit:         c47990b
Commit time:    10.06.2022 18:28:37 UTC
JVM:            18
Lavaplayer      1.3.97-original

I wouldn't really say this is an issue within Lavalink, more that your session expired which is normal behaviour. If your library supports it, you can listen for these WebSocketClosedEvents and reopen the connection if you so wish, however as stated this isn't really an issue so I'll go ahead and close this.
If you wish to discuss this further you can join the Discord server linked in the README.


IndexError: index 1 is out of bounds for axis 1 with size 1

I am trying to apply series2graph (from TSB_UAD.models.series2graph import Series2Graph) to my data set. However, once I run the following code :
label = df[:max_length,1].astype(int)
Result is :
IndexError                                Traceback (most recent call last)
Cell In[21], line 1
----> 1 label = df[:max_length,1].astype(int)
IndexError: index 1 is out of bounds for axis 1 with size 1
When I apply the dataset uploaded to https://github.com/TheDatumOrg/TSB-UAD/tree/main/data/benchmark/ECG,        no errors occur.
Please help me solve this issue.
Thanks in advance

solved


fetch_overfeat_weights_and_biases 404 error

The zip of overfeat weights to be downloaded in fetch_overfeat_weights_and_biases seems to have an invalid link.  I get a 404 when running the function & when trying to navigate to the link manually.
Is there a separate location to get the weights now?
(url in function: https://dl.dropboxusercontent.com/u/15378192/net_weights.zip)

I can validate this is true as well. #105 is relevant as well.

Dropbox must have changed folder sharing settings: this link should work https://www.dropbox.com/s/9brp4f5spheybwo/net_weights.zip?dl=0 .
However, given recent ecosystem changes, this project isn't really maintained any more (Theano is end-of-life, and PyTorch/TF have similar functionality to this package). I plan to write something in the README about this soon - but for now here are the weights, have fun!

Thanks Kyle!

Of course, I still hope to fix the fetcher/dropbox issue since Theano isn't dead just yet :) Will see about doing that in the upcoming week.


COLMAP stuck if increase image_width

Hi. Thanks for this wonderful work. I have a question regarding the usual processing & training time. I’m trying to work on my own image set on Colab. I found that when I increase the image_width to something bigger than 400 (for example 720), then the processing time will be drastically increased, specifically it will stuck at this step for a very long time, resulting in Colab to timeout and disconnected:
==============================================================================
Exhaustive feature matching
==============================================================================

Matching block [1/1, 1/1]

May I know what is the expected processing and training time if I want to render high resolution output, and what is the recommended hardware I’ll need? Thank you :)

Feature matching takes a long time because there has a lot of features. So, I recommend you decrease the number of features.
There is two approach.
1.limit the feature
You can add the argument  --SiftExtraction.max_num_features to the COLMAP feature_extractor
2.Manipulate the calibration Run feature matching on low-resolution (Eg, width 400), and you can use this calibration in any resolution you want. However, you have to change the principal point and focal length. This requires you to understand how the camera's intrinsic and extrinsic work. Maybe check this article
I recommend you try the first approach first, but it may degrade the camera calibration, leading to a poor result. If the first approach does not satisfy you, you have to take time to understand how camera calibration work.
For COLMAP's part, it takes about an hour for 50 images on Threadripper 3960x.
For the expected processing time, the neural network part depends on how many iterations to train. A bigger image is likely to take more iteration to converse. I expected a day of training for width 800x800 on Nvidia V100.
However, I would recommend you to check out Nvidia's Instant-NGP, which targets a similar view synthesis which our work and can be trained in 5 minutes.

Hi @pureexe , thanks for the reply. I've installed the latest version of COLMAP 3.8 (if you install via apt install colmap, you'll get 3.6 instead) on colab and enabled GPU (removed --SiftExtraction.use_gpu=false and --SiftMatching.use_gpu=false options). Now the Run SFM step is a lot faster, but I'm getting this error:
/content/nex-code
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
[<ipython-input-17-4c90f959bb10>](https://localhost:8080/#) in <module>
      2 get_ipython().run_line_magic('cd', '/content/nex-code')
      3 from utils.colmap_runner import load_colmap_data, save_poses
----> 4 poses, pts3d, perm, hwf_cxcy = load_colmap_data(PROJECT)
      5 save_poses(PROJECT, poses, pts3d, perm, hwf_cxcy)

[/content/nex-code/utils/colmap_runner.py](https://localhost:8080/#) in load_colmap_data(realdir)
     83   cam = camdata[list_of_keys[0]]
     84
---> 85   h, w, fx, fy, cx, cy = cam.height, cam.width, cam.params[0], cam.params[1], cam.params[2], cam.params[3]
     86
     87   hwf_cxcy = np.array([h, w, fx, fy, cx, cy]).reshape([6,1])

IndexError: index 3 is out of bounds for axis 0 with size 3

For the full output, you can see this colab notebook:
https://colab.research.google.com/drive/1eK22cev7AD1nOdNHZixKvRiObQxwuaMq#scrollTo=RjhVd5ME0vAM
Do you know how shall I fix this issue? Thanks :)

The shape of camera model is incorrect.
Please add --ImageReader.camera_model="PINHOLE" when running the feature extractor.


chore: pull out deploy into separate yml file

The risks on this are too great. Gonna leave this to the EDHRec folks to handle once it’s migrated to Next


feat: Add exists service method and request/response messages.

Exists takes a list of keys as input and returns a list of bools. results[i] is True if keys[i] exists, else False.
We decided on returning a list as opposed to the count of items. By doing this we can support rich iteration use cases on the client side. For example:
response = client.exists("my-cache", *keys)
if not response.all():
   log.info(f"Expected {len(keys)} to exist but got {response.num_exists()}")
   for missing_key in response.missing_keys():
       # Do things

Hey - I am a bit behind on the details here hence my questions

Does exists mean that we need to support for all key-value pairs and advanced data structures?
What is the reasoning behind list of keys and not single key? Is it because Redis/memcache have similar APIs? Or have customers asked for this explicitly? Is there a limit on how many keys can be queried for?

Closing for now. Will revisit when a priority.


Marker positions don't update when dragging them

I recently discovered that dragging markers would'nt update their longitude and latitude.
As it appears to be happening on the example pages too, I think it is a general bug.
http://tombatossals.github.io/angular-leaflet-directive/#!/examples/dragging-markers

Confirmed.

Is this a dupe of #690 ?

Yes dupe, closing.


how to make the model move？

I look at the latest sceneform demo (ChromaKeyVideo), without .mp4, how to make the model move.Such as skeletal animation of 3D models.

@siny-yao - Thanks for your question.  We've marked this as an enhancement request and we'll update this thread when there is an update.

Thanks for adopting my suggestion and looking forward to the next update.


Morphology-based Operations

I was looking for mathematical morphology support in Images.jl and found base operations (dialtion, erosion, opening, closing).
Before I take a stab at additional morphology functions, wanted to check, if the community is open for these to be added to the library. I've just started using/looking into Images.jl

morphgradient -  Morphological gradient
morphlaplace - morphologically-based Laplacian filter
tophat - Top-hat filtering
bothat - Bottom-hat filtering

Yes, these would be great.
If you're looking at code in Images, you might notice that there's a lot of use of Base.Cartesian. You might still need it for some operations, but I have on my agenda to rewrite a lot of those algorithms using the CartesianIndex iterators in julia 0.4. Now many more arbitrary-dimensional algorithms can be implemented efficiently without resorting to metaprogramming.
That said, if your intention was to implement them just for 2d, that's also fine. My own work usually involves 3d and 4d (space+time) images, but I don't want to make that a barrier for others for whom that might be irrelevant.

I think this issue can be closed.


Stop auto indentation when pressing enter

when I press enter the line is auto indented. This conflicts with the project I am working on. Because it has different indentation rules. So I always have to go back to un indent the previous line. Can we make that feature configurable? I can't use this thing on the project i'm working on if I have to go back and fix every SINGLE line I edit.

Now that you mention it, I think I would also turn it off =)


Validation on donor status and aid package status

[ ] Should not be able to have a donor status as "pledged" and an aid package status as "shipped".
Statuses should align this way:

When aid package is "published", donor status can be "pledged"
When aid package is "awaiting payment", donor status can be "payment initiated" or "payment confirmed"
When aid package is "ordered", "shipped", "received at MOH" or "delivered", donor status must be "payment confirmed"

shall I work on this?

shall I work on this?

sure. go ahead

@YaiyaSam What is the email and PW for login to the admin portal?

@YaiyaSam What is the email and PW for login to the admin portal?
login username<EMAIL_ADDRESS>pw: liveSession10

@ManojLL also change these two lines in the config.json file

"signInRedirectURL": "http://localhost:3000",
"signOutRedirectURL": "http://localhost:3000",

@ManojLL @YaiyaSam
I think this has to be handled on the backend. Not from the front end.
In order to achieve the requirement. The pledge status should be changed when changing the status of a package.
CC: @anupama-pathirage @AmilaJ

Update: This has to be validated on the front end.
@ManojLL Any reason for closing this PR?
https://github.com/LSFLK/MedicinesforLK/pull/243

Edited: added 2nd line, term in bold.
When aid package is "published", pledge status can be "pledged"
When aid package is "awaiting payment", pledge status can be "pledged",  "payment initiated" or "payment confirmed"
When aid package is "ordered", "shipped", "received at MOH" or "delivered", pledge status must be "payment confirmed"


There is no HWPFDocment class, I find the testcase, any plans to add this?

+1

I have migrated NPOT HWPFDocment to the .NET Core to support read .doc Word 2003 format.
I have not full tested it, but I will fix the bug in the feature.
https://github.com/RockNHawk/NPOI.NetCore


Removed blackbox attribute.

This was causing simulations to output 1'bx for all CARRY4_VPR outputs.
This does not fix DRAM test error output problem, but it does fix autosim for cases where a sim model exists.

Should this be a (* whitebox *)?

Should this be a (* whitebox *)?

I'm looking into that.

Should this be a (* whitebox *)?

No, whitebox has the same behavior.


issues installing the library via cocoapods

I'm getting the following issue:
Installing rabbitmqc (0.6.7)
[!] The 'Pods-xxx App' target has transitive dependencies that include static binaries: (/Users/xxx/xxx/Pods/OpenSSL-Universal/lib-ios/libcrypto.a and /Users/xxx/xxx/Pods/OpenSSL-Universal/lib-ios/libssl.a)
Any ideas as to fixing this issue? Trying to figure this out, but seem to be unable to. This is my podfile:
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'
use_frameworks!
target 'xxx' do
pod 'MSDynamicsDrawerViewController'
pod 'PLCrashReporter', '~> 1.2'
pod 'OLRabbitMQ'
pod 'IntentKit'
pod 'Alamofire', '~> 3.0.0-beta.3'
pod 'HanekeSwift'
pod 'QRCodeReader.swift', '~> 5.1.0'
pod 'XCGLogger', '~> 3.0'
pod 'SnapKit', '~> 0.15.0'
pod 'rabbitmqc', '~> 0.6'
pod 'OpenSSL-Universal', '1.0.1.l'
pod 'librabbitmqc'

end

Hi, you use directive 'use_frameworks!'. Please change this on build static library. Please remove 'use_frameworks!' and try again.

Well it seems getting libraries that are written in swift and objective-c to coexist, is still not possible. I was changing my usage of Alamofire and other swift libraries. Still not possible to do so it seems. Still have to manually import everything atm.


Collision shapes created through CollisionObject2D APIs are not visible

Godot version: 3.2
OS/device including version: Windows 10
Issue description: Collision shapes created using CollisionObject2D APIs work but are not visible on enabling "Visible Collision Shapes".

Steps to reproduce: Create collision shape using shape_owner* APIs
	var own = create_shape_owner($Child)
	var shape = CircleShape2D.new()
	shape.radius = 20
	shape_owner_add_shape(own, shape)

Minimal reproduction project:
CollisionVisibilityBug.zip

CircleShape2D (and any other shape) are resources so they can't be drawn outside the scene tree if they weren't assigned via CollisionShape2D node in editor which actually enables editor/in-game visibility on them.
When you add those shapes via shape_owner* API (or even with Physics2DServer) it means that they are added to CollisionObject2D directly bypassing CollisionShape2D.
The solution might be that it's better to draw those shapes directly and not only via CollisionShape2D.

I have a PR which can help this on the scripting side: #37903, but doesn't solve the underlying issue.


[5.2] Optimize Filesystem moveDirectory

When move directory with overwrite flag, the first step is deleting the target directory.
In the delete step, we should check the return value, we could go on if it succeed.
After deleting the target directory, we use rename function to move the directory instead of coping and deleting.

Oh look, the line below does exactly the same 😉 You may therefore just drop the rename inside the if statement 👍
It is also possible to condense the nested if-clause into the first, however keeping it like this is clearer as it separates the condition from the action.


fix: attachment menu position

Details

This PR fixes the contextMenuActions position i.e the report actions attachment menu position.
Fixed Issues

$ https://github.com/Expensify/App/issues/50818
PROPOSAL: https://github.com/Expensify/App/issues/50818
Tests

Login into any account
Navigate to any 1:1 DM
Send any video/image attachment
Send another video/image attachment
Hover over the first image/video attachment and click on the "..." button
While the context menu of the first attachment is still open, Hover over the second image/video attachment and click on the "..." button.

[x] Verify that no errors appear in the JS console

Offline tests

Login into any account
Navigate to any 1:1 DM
Send any video/image attachment
Send another video/image attachment
Hover over the first image/video attachment and click on the "..." button
While the context menu of the first attachment is still open, Hover over the second image/video attachment and click on the "..." button.

QA Steps

Login into any account
Navigate to any 1:1 DM
Send any video/image attachment
Send another video/image attachment
Hover over the first image/video attachment and click on the "..." button
While the context menu of the first attachment is still open, Hover over the second image/video attachment and click on the "..." button.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/747a2c94-f9b2-4890-a8cc-aaa8e31df239

Android: Native

iOS: Native

iOS: mWeb Safari

MacOS: Desktop

@teneeto Strange. I can reproduce the problem with the changes in the PR. Here is a test video demonstrating the same. Am I missing something here?
https://github.com/user-attachments/assets/864c6d54-ecde-4b53-b77c-1912c042f3eb

Hi @rojiphil, having a look

O I see, I Solved for a completely different bug I guess. Let me do a recording to share more info on what I did. I possibly tested for the wrong issue.

I'm still trying to wrap up for the videoplayer context menu. Couldn't complete it yesterday, but giving it a try again today.

and for that i intend to agree with Shahinyan11's earlier proposal

@rojiphil can you check again?

can you check again?

I just checked again and my initial assessment is that it is fixed now. I will continue with the review and again update later today.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


implementation

I write a pytorch version of Lookup-Free Quantization in https://github.com/0nutation/Lookup-Free-Quantization.

@0nutation looks good! so torch sign produces 0 for 0, which is an edge case you'll have to handle (one way is (x > 0) * 2 - 1)


:sparkles: Support orderingKey in GCP Pub/Sub

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#661  👈 (View in Graphite)
#660
#659
#658
#655
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


feat: Disabling profiling results from "secret" datasets

Feature or Bugfix

Feature

Detail

For datasets that are classified as "Secret", data preview is disabled. In the same way, data profiling results should alse be denied.

Relates

#478
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nikpodsh I just tested the 3 scenarios: secret, official and unclassified and it works as expected:
With the following error appearing for secret and official datasets (tables):


TaskLostIntegrationWithoutGCTest is marked as unstable

Closed by https://github.com/mesosphere/marathon/commit/b0421b42ba9d0d6d28bf1ad3170ca785aea26cb4


Error: more than one library with package name 'com.reactlibrary'

Hey guys, I've noticed after using react-native-create-library for more than one library, I'm getting this error message when building for android:
Error: more than one library with package name 'com.reactlibrary'
This is telling me that when you create the library, the library has the same package name. Can you fix this so it's unique next time? Also, where do I change this within my android code so it does work? Thanks!

I can do a more detailed writeup, but in the meantime, take a look at this brief explanation!

With the PR merged from above we are preventing creating libraries with the default name now. I will close this issue, please reopen if you don't think it's resolved. Thanks!


Report standard deviation in benchmarks

Our benchmark charts currently displays only score which is an average of one benchmark iteration in milliseconds.
Since JMH can, and does, output stddev, it would be nice to:
### Tasks
- [ ] Make sure stddev is saved in the XML generated by the JMH benchmark runner
- [ ] Make sure that this stddev is displayed in the charts, if present in the XML artifact.

stddev is a very important metric as it tells us basically how much we can trust the results for a particular benchmark.

As noted, the std-dev allows us to easier differentiate benchmarks like the navy vs orange ones from this analysis (one has very high variance and the other is very 'stable').

Just a note that in #8091 I added displaying stdev within the Enso runner for the benchmarks. This is a bit perpendicular, because this is not the runner used on CI so the ticket remains open - but it is slightly related so I thought it may be worth noting.

We can see how the stdev allows us to better judge the benchmarks - for example the high stdev in the Enso variants may show that the warmup time is insufficient and should be made larger if we want to see the peak performance.


Schematic using deprecated methods?

(FAWE) @CuboidClipboard used by EffPasteSchematic.execute():58 is deprecated.
When using your schematic syntax?
Using latest skript dev30 by bensku and using your latest version of sharpSK

This is in most cases considered normal unless it interrupts your placement of schematics. It just lets you know that its working with an older method that is no longer used (but still there) to place the schems. Does it prevent you from placing schems with the syntax?


Upgrade checkout flow to use window.xchild and window.xprops

Rather than doing ppxo.Checkout.attach() and window.paypalCheckout

Done, awaiting push.

Pushed.


Added import for talents from oggdude dataset dump.

NOTE:

To use place the zip file in the foundry data folder at the root (/foundrydata/Data).
Open Configure Settings then go to System Settings
Top most select is OggDude Importer.
select file in drop down and click Load File
Boxes will enable based on data available.
Select boxes to import (only Talents is configured so far) and click import
The items will be imported and appear in a compendium pack called oggdude.talents
The import window will close when the import is complete.

Want to get it out there for anyone to test.  I will be doing localization and the other data imports soon.


Add contributing section

Motivation
Example coverage could be crowdsourced more effectively with more direction.
Solution
Add contributing section to end of Cookbook.

Happy hunting! The game is afoot! :smile:


[BUG] Correct headers are not installed when using Debian Buster backports kernel such as 5.4

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[x] I have read and understood the contributors guide.
[x] The issue I am reporting can be replicated.
[x] The issue I am reporting can be is directly related to the pivpn installer script.
[x] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Describe the bug
Wireguard service does not start because correct headers are not installed when using an other kernel than DEbian Buster 4.19 (in my case 5.4 via Backports)
To Reproduce
Log:
_sudo apt -t buster-backports install wireguard
(some stuff)
Setting up wireguard-dkms (0.0.20200215-2~bpo10+1) ...
Loading new wireguard-0.0.20200215 DKMS files...
Building for 5.4.0-0.bpo.4-amd64
Module build for kernel 5.4.0-0.bpo.4-amd64 was skipped since the
kernel headers for this kernel does not seem to be installed.
Setting up wireguard (1.0.20200206-2~bpo10+1) ...
Processing triggers for libc-bin (2.28-10) ...
Scanning processes...
Scanning processor microcode...
Scanning linux images...
Running kernel seems to be up-to-date.
The processor microcode seems to be up-to-date.
No services need to be restarted.
No containers need to be restarted.
No user sessions are running outdated binaries._
Solved by:
apt install linux-headers-5.4.0-0.bpo.4-amd64
in seems only headers-4.19 are installed by the script, even when kernel 5.4 is running.

Looks like that installing linux-headers-amd64 (what the script does) indeed installs linux-headers-5.4.0-0.bpo.4-amd64 on Buster backports: https://packages.debian.org/buster-backports/linux-headers-amd64

I'm on ARM Debian buster-backports (for wireguard) too. I opted to manually install the header dependency and remove the dependency from the script. Otherwise I'd try to install AMD64 headers.

Is this still happening now that Wireguard ships by default on linux kernel?

I haven't retried. I set-up an OpenVPN instead. If this has been fixed, I may replace it with WireGuard after all.

@Ghostbird ITs ARM64 right?

It was armv7l

might need testing then .. not sure if its gone or not.

If I try to install wireguard from buster-backports, it wants to install a realtime kernel. I don't think that would be a good idea in my case. However, it's probably unrelated to this repository. At least it doesn't seem to try to install amd64 packages.

Wonder if this is still a thing and needs real investigation .. been quite dead and not many comments or issues related to this ... 🤔🤔🤔

I'll close this, I have no way to test this, since I upgraded that system to a Raspberry Pi 4, which is ARM64, so it will resolve different packages.

will close if needed can be reopened.


Virtual Scroll Component not being destroyed when displayed in Modal Component

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Description:
Virtual Scroll component not being destroyed when being presented inside a Modal.
Expectation:
Proper deletion and un-referencing of component
Steps to reproduce:

Take a heap snapshot to compare with.
Open a modal with a Virtual Scroll component inside the modal.
Dismiss the modal. *repeat steps 2 & 3 a few times
Take a Heap Snapshot and compare with your first and realize the additional Virtual Scroll Components that remain in memory.

I created an example below in plnkr:
http://plnkr.co/edit/8egskJTVU7IRcylj7TEm?p=preview

I've been struggling to find the root cause of this issue and have failed to find a fix for it.. So before I head home for the day, I've chosen to let the community and DriftyCo to take a crack at it.

You're awesome for getting this fixed so fast! Thank you so much @manucorporat


Gross Margin

Hi there,
I was just messing around with stocks and orders and I noticed gross margin never changes and is always zero. Is this a common problem? Or am I doing the testing wrong?

Hey @MAkcanca, thanks for pointing that out. There's definitely a bug in the code that calculates these prices, we'll fix that.


added key generation method to data helper class

I found this to be useful when used with user registration and confirm registration emails.

Does this also work in PHP 7 I ask because as of now the framework is completely PHP 7 compatible and just need to keep it that way?

Speaking of which Dave will you be making sure that any future pull request is PHP 7 compatible and backwards compatible to PHP 5.5?

I haven't tried it in PHP 7. I honestly haven't read the changes in PHP 7.

You said this is for user registration however password is already built into the framework so where and why would you use it just curious.

I've used it for database relation keys, confirm email links, and unique keys in rows. I don't like using the a_i id as a way to fetch information from database so I use this to generate a unique key to every user, message, page, comment, post, etc.

i think we already have a 32 char string generator the method is on Csrf helper
class Csrf {
public static function makeToken() {
    $csrf_token = md5(uniqid(rand(), TRUE));
    return $csrf_token;
}

}

What version of the framework is that method in? V2.2 makeToken method is different.
    public static function makeToken()
    {
        $max_time    = 60 * 60 * 24; // token is valid for 1 day
        $csrf_token = Session::get('csrf_token');
        $stored_time  = Session::get('csrf_token_time');

        if ($max_time + $stored_time <= time() || empty($csrf_token)) {
            Session::set('csrf_token', md5(uniqid(rand(), true)));
            Session::set('csrf_token_time', time());
        }

        return Session::get('csrf_token');
    }

eh you are right maybe this was a previous version sorry.

I wonder wich one is better
str_shuffle(md5("!@#$%^&*)_+-=0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHJIKLMNOPQRSTUVWXYZ"));
or
 md5(uniqid(rand(), TRUE));

Either one works fine. They will both create a 32 char string, so its up to preference.

also it would be usefull if you could set the string length
function randomkey($length = 32) {
        $chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890";
        $key = "";

        for ($i = 0; $i < $length; $i++) {
            $key .= $chars{rand(0, strlen($chars) - 1)};
        }

        return $key;
    }

+1
That's a great idea.
Changed the contribution

thanks really useful!.


replace mkdirp in favour of fs with { recursive: true }

This replaces all instances that depend on the mkdirp package with the node native fs.mkdir (available as of node v10.12.0) with the recursive option passed.
There appears to be numerous issues with mkdirp such as specifying an unavailable drive letter on windows causing it to enter an infinite loop and eat all available memory; but it appears the mkdirp package is no longer maintained.
What kind of change does this PR introduce?
Ultimately this removes an unnecessary (and unmaintained) dependency as well as fixing some bugs.
Did you add tests for your changes?
I have modified the tests to pass but the fs functionality isn't really tested so this should not matter.
Does this PR introduce a breaking change?
I don't know what version of node Webpack is expected to support as a minimum. But at least node v8 is in LTS until December 2019. So this could be considered a breaking change.
What needs to be documented once your changes are merged?
Nothing.

We can't use it in webpack 4 and 5 but min supported node.js is at least 8.

When https://github.com/sindresorhus/make-dir/pull/7 is merged, you can use make-dir, which will use the native option when available.

mkdirp has been removed in webpack 5