Revisit gas costs of having Crowdsale deploy the token itself

The bytecode that results from having Crowdsale deploy the token itself is too big and causes the deployment to be too costly.
Related to #351. Should be fixed the same way.

I'm having the same issue when deploy the sample crowdsale code to Ropsten, even it fails, still costing me 0.5 ether for gas. How did you guys solve this issue?

Setting the truffle gas limits manually. @spalladino maybe remembers the exact parameters we used.

The problem was deploying a customised version, so that exact same value
would not apply. You may want to check on etherscan what gas limit is being
set by truffle, and try increasing it.
On Sat, Aug 12, 2017, 18:10 Francisco Giordano<EMAIL_ADDRESS>wrote:

Setting the truffle gas limits manually. @spalladino
https://github.com/spalladino maybe remembers the exact parameters we
used.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenZeppelin/zeppelin-solidity/issues/358#issuecomment-322006229,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaOJIxdmiFLYXsAOaxmYm-MdxYkeUNTks5sXhS-gaJpZM4O1BqD
.

I'm having the same/similar problem. I cannot deploy the SampleCrowdsale. Im attempting on Ropsten, using Remix, and passing in these parameters to "Create" for SampleCrowdsale(300, 172800, 1000, 20, 30, "0xADDRESS") Is there a way to deploy this? I've tried increasing the gas limit super high in Remix, no such luck callback contain no result Gas required exceeds block gas limit: 300000000

I'm also having the same/similar problem. I posted about it to stackexchange. I'd appreciate it if you could help me.
https://ethereum.stackexchange.com/questions/26012/is-it-possible-to-divide-my-crowdsale-contract-into-multiple-files-in-order-to-s

I think the error might be caused by the constructor arguments - the first and second Crowdsale constructor arguments are timestamps, not block numbers. Probably this check throws:
function Crowdsale(uint256 _startTime, uint256 _endTime, uint256 _rate, address _wallet) {
    require(_startTime >= now);

Thanks! @gundas As you mentioned, I could deploy it after change to timestamp. I'm sorry please forget my issue. I updated my stackexchange post.

I keep getting this error while trying to deploy Crowdsale contract to ropsten network:
Error: The contract code couldn't be stored, please check your gas amount.
The last block gas limit is 6993557, so I set the gas limit to 6990000 in truffle configurations. I struggle to find what's wrong.
BTW, I use timestamps for the first constructor arguments, as @gundas mentioned.

@tomericco keep in mind that that error is also thrown when there is an error during the constructor execution, and may actually be unrelated to the gas amount. Make sure you are not breaking any precondition of the Crowdsale constructor, such as timestamps needing to be in the future, with start less than end.

@spalladino Here is my Truffle deployment script:
const Crowdsale = artifacts.require('zeppelin-solidity/contracts/crowdsale/Crowdsale.sol');

module.exports = function(deployer, network, accounts) {
    const startTime = web3.eth.getBlock(web3.eth.blockNumber).timestamp + 1;
    const endTime = startTime + (86400 * 30); // 30 days
    const ethRate = new web3.BigNumber(1000);
    const wallet = accounts[0];

    deployer.deploy(Crowdsale, startTime, endTime, ethRate, wallet);
};

Do you see anything suspicious?

Yup, startTime is not enough in the future. You are using 1 second after
the timestamp of the current block, and the contract won't be included
until at least the next block, which will be mined about 20s after the
current one. Try changing start time to +120 instead of +1.
On Tue, Oct 10, 2017 at 10:23 AM, Tomer Gabbai<EMAIL_ADDRESS>wrote:

@spalladino https://github.com/spalladino Here is my Truffle deployment
script:
const Crowdsale = artifacts.require('zeppelin-solidity/contracts/crowdsale/Crowdsale.sol');
module.exports = function(deployer, network, accounts) {
const startTime = web3.eth.getBlock(web3.eth.blockNumber).timestamp + 1;
const endTime = startTime + (86400 * 30); // 30 days
const ethRate = new web3.BigNumber(1000);
const wallet = accounts[0];
deployer.deploy(Crowdsale, startTime, endTime, ethRate, wallet);

};
Do you see anything suspicious?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenZeppelin/zeppelin-solidity/issues/358#issuecomment-335470684,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaOJM6qz8WCZsXtXVIWEQcByvkDFF5Lks5sq2-_gaJpZM4O1BqD
.

It works now. This is why it worked on the local TestRPC, and not on Ropsten.
Thanks a lot @spalladino!

my setting
rinkeby: {
      host: 'localhost',
      port: 8545,
      network_id: 4,
      gas: 6000000
    }

and set   const startTime =  latestTime() + duration.seconds(120); // + immediately
it works! :) thanks for everyone's help

@spalladino your answer to @tomericco solved me a several days lasting frustration!

@spalladino Nice changes !


Timestamps shouldn't rely on current frame

This way of creating timestamps is actually wrong.
We should actually use the current time in microseconds, like we did in Akihabara.
https://github.com/vignetteapp/MediaPipe.NET/blob/73cd0429f8e1d75644ca5d63db8974a7a9b08928/Mediapipe.Net/Calculators/CpuCalculator.cs#L29

I consider this a regression if we're doing something backwards from Akihabara, so you might need to either port that back in or rewrite in a manner that preserves that previous behavior.

Things had changed on 0.9.1 so I don't think this is relevant anymore.


Update review status element

This updates the review status element on the manual pages.

Displays the date of the last review so the reader knows whether or not the page is likely to be accurate
Fixes relative dates module
Updates design

See commits for details.
Before

After

To fix:
https://govuk-tech-docs-pr-579.herokuapp.com/manual/dns.html

This page was last reviewed 185 days ago. It needs to be reviewed again 1 days ago by the page owner #2ndline.

https://govuk-tech-docs-pr-579.herokuapp.com/manual/rebooting-machines.html

This page was last reviewed 94 days ago. It needs to be reviewed again 3 months from now by the page owner #2ndline.

Looks good, I think we can do less and remove the blue background potentially though?

Without using the blue banner the element looks a bit lost, blurring in between the related items and the footer (View source / Report problem / GitHub Repo).

The blue banner breaks up the page a bit, which I think makes it more easier to distinguish the elements.

In terms of priority, last reviewed date is the most important metadata that we provide. It's roughly analogous to the Publishing metadata component in the new GOV.UK designs (https://gov-uk.atlassian.net/wiki/spaces/GFED/pages/186351726/Sprint+1+designs), that's why I chose the (existing) blue banner.

Is the #name referring to a Slack channel? Would it be possible to link to the web URL for this?


SC-CEN-2

I've created new layers from scratch: OSS component and OSS projects. OSS project is parent of OSS component.
I've created two entities of type OSS components. The platform, automatically set one of them as parent of the other and viceversa. However they are both of type OSS component. The should have not parent as they don't belong to any OSS project at this stage.
I'm not able to change it.

Update: it is not a bug, but a confusion in the procedure. By default the field "parent" shows the fist element of a list of potential parents. And I was confused. The procedure is:

Choose a parent from the list.
Click "add parent".
Clic "save".

It should be:

Choose a parent from the list.
Click "add parent".

And by default, the list should show something like "choose a parent". To avoid confusions.
I'm changing the issue to "enhancement"

Regarding the behaviour, the save behavior for all the platform is the same:
1.- the users made all the changes in one object
2.- the user click on the Save button
We choose this option in order to minimise the calls to the sever, one when the user saves instead of for every change.
There is only an exception for this, the contextual information in the layer form.  The user can save the modifications in one contextual information (using also the button save).


Error: Render header on pages

When we set displayHeaderFooter on true, header will not render. It works only when we set margin to @page in CSS, but then page height is increased by margin value and page content is rendered outside of the page. Is there a solution for the headline to appear on every page without bugs ?

Hi @pawelruminkiewicz option headerTemplate has been added and should do the trick for you!


⚠ Jenkins Plugins Artifactory has degraded performance

In 1934b7a, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1216 ms

Resolved: Jenkins Plugins Artifactory performance has improved in d554999 after 12 minutes.


Sparrow causing node to shut down

Recently I’ve experienced an issue where my full node running on my Futurebit Apollo shuts down after being connected to sparrow. I’ve attempted running sparrow both locally and remotely, both with the same result. I’ve also tried running previous versions of sparrow which worked in the past. Same issue. Futurebit support says that it’s a known issue so I am adding this ticket to see if there some more info anyone might have/raising the issue if it’s unknown to sparrow.

Not sure if you resolved this, but upgrading to v1.7.7 or later is the answer.

Unfortunately it looks like the problem is persisting.

The connection now works nicely but after a couple hours, my node shuts down.

On the Apollo, please run the following command after the node has been running for a couple of hours, and report the results here:
time bitcoin-cli getrawmempool false

Can you also confirm you are running v1.7.7?

futurebit@futurebitbtc:~$ time bitcoin-cli getrawmempool false
bash: bitcoin-cli: command not found
real	0m0.010s
user	0m0.001s
sys	0m0.007s
And yes, I can confirm I have updated to 1.7.7. Thanks again, for the assistance.

Unfortunately you are not actually executing anything - see bash: bitcoin-cli: command not found. If you run
ps aux | grep bitcoind

you might see the folder where bitcoin-cli is located. You will need to specify the full path to it when you run it.
If you can't find bitcoin-cli, the alternative is to run Sparrow with DEBUG logging using the -l DEBUG command line flag, then then searching sparrow.log in the Sparrow home folder (see FAQ) for log lines with with BitcoindClient. This will contain all the communication with Bitcoin Core that Sparrow is making, and should help determine the call that is causing the issue.

Any progress on this?

Unfortunately no. I found the folder with all the other files related to bitcoin core but no bitcoin-cli file. I also tried the -l DEBUG line but it said bash: -l: command not found. Apologies for my lack of technical ability. The machine it's running on only has 4gb of memory so that could be what is causing the issue. If you have any suggestions that would be great but I might be helpless.

I also tried the -l DEBUG line but it said bash: -l: command not found.

Can you confirm you tried to start Sparrow from the terminal like fullPathToSparrowFolder/bin/Sparrow -l DEBUG?

Is there an easy way to find the full path?

Ah sorry I thought you'd run Sparrow directly from source and would know its path :D I guess you're on a linux machine? Then it's /opt/sparrow/bin/Sparrow if I see correctly.
So to run in debug mode you'd use /opt/sparrow/bin/Sparrow -l DEBUG. Note that once you close the terminal your Sparrow shuts down. You could also try to add the debug level logging to the launcher (try righ-clicking on the Sparrow icon where you normally start. Sometimes there's a menu option like "Edit Application" where you can find the command which is executed once you click on the icon. It will also be /opt/sparrow/bin/Sparrow. Add there the -l DEBUG and save. Now if you click on the icon it should run without terminal but also with debug logging.
The log file is under the following directories

Platform
Location

OSX
~/.sparrow

Linux
~/.sparrow

Windows
%APPDATA%/Sparrow

2023-07-17 21:24:51,529 WARN No response from server, setting read timeout to 34 secs
2023-07-17 21:24:51,782 ERROR Connection error
com.sparrowwallet.sparrow.net.ElectrumServerRpcException: Error getting fee rate histogram
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.SimpleElectrumServerRpc.getFeeRateHistogram(Unknown Source)
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.ElectrumServer.getMempoolRateSizes(Unknown Source)
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown Source)
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$6(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$7(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: com.sparrowwallet.sparrow.net.ServerException: Retries exhausted
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.RetryLogic.getResult(Unknown Source)
... 12 common frames omitted
Caused by: java.lang.IllegalStateException: I/O error during a request processing
at simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.RequestBuilder.executeRequest(Unknown Source)
at simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.RequestBuilder.executeAndConvert(Unknown Source)
at simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.RequestBuilder.execute(Unknown Source)
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.SimpleElectrumServerRpc.lambda$getFeeRateHistogram$13(Unknown Source)
... 13 common frames omitted
Caused by: java.io.IOException: No response from server
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.TcpTransport.readResponse(Unknown Source)
at com.sparrowwallet.sparrow@1.7.7/com.sparrowwallet.sparrow.net.TcpTransport.pass(Unknown Source)
... 17 common frames omitted
DEBUG bwt_jni                           > shutdown signal received
DEBUG bitcoincore_rpc                   > JSON-RPC request: getblockhash [799156]
DEBUG bitcoincore_rpc                   > JSON-RPC request: getblockhash [799156]
DEBUG bitcoincore_rpc                   > JSON-RPC failed parsing reply of getrawmempool: JsonRpc(Transport(HttpErrorCode(503)))
WARN  bwt::electrum                     > rpc #12 mempool.get_fee_histogram failed: JSON-RPC error: transport error: unexpected HTTP code: 503
TRACE bwt::electrum                     > rpc #13 <- mempool.get_fee_histogram []
DEBUG bitcoincore_rpc                   > JSON-RPC request: getrawmempool [true]
DEBUG bitcoincore_rpc                   > JSON-RPC failed parsing reply of getblockhash: JsonRpc(Transport(SocketError(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" })))
DEBUG bitcoincore_rpc                   > JSON-RPC failed parsing reply of getblockhash: JsonRpc(Transport(SocketError(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" })))
WARN  bwt                               > failed syncing with bitcoind: JSON-RPC error: transport error: Couldn't connect to host: Connection reset by peer (os error 104)
WARN  bwt                               > failed syncing with bitcoind: JSON-RPC error: transport error: Couldn't connect to host: Connection reset by peer (os error 104)
DEBUG bitcoincore_rpc                   > JSON-RPC failed parsing reply of getrawmempool: JsonRpc(Transport(SocketError(Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })))
WARN  bwt::electrum                     > rpc #13 mempool.get_fee_histogram failed: JSON-RPC error: transport error: Couldn't connect to host: Connection refused (os error 111)
WARN  bwt::electrum                     > [<IP_ADDRESS>:52996] handling failed: failed to send {"error":"JSON-RPC error: transport error: Couldn't connect to host: Connection refused (os error 111)","id":13,"jsonrpc":"2.0"}
TRACE bwt::electrum                     > [<IP_ADDRESS>:52996] shutting down connection
INFO  bwt::electrum                     > [<IP_ADDRESS>:52996] disconnected peer
DEBUG bitcoincore_rpc                   > JSON-RPC request: getblockhash [799156]
TRACE bwt::electrum                     > stop accepting new RPCs
DEBUG bitcoincore_rpc                   > JSON-RPC failed parsing reply of getblockhash: JsonRpc(Transport(SocketError(Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })))
WARN  bwt                               > failed syncing with bitcoind: JSON-RPC error: transport error: Couldn't connect to host: Connection refused (os error 111)
TRACE bwt::electrum                     > closing 0 RPC connections
TRACE bwt::electrum                     > waiting for 0 RPC threads
TRACE bwt::electrum                     > RPC connections are closed
TRACE bwt::electrum                     > RPC server is stopped
DEBUG bwt_jni                           > daemon stopped successfully
TRACE bwt::electrum                     > acceptor shutting down
DEBUG bitcoincore_rpc                   > JSON-RPC request: getblockhash [799156]

this of course wasn't the entire return but it was the part right before the node shut down

This isn't related to your logs (Craig could tell you what's going on) but

The machine it's running on only has 4gb of memory so that could be what is causing the issue.

I've had a similar issue with my RPi. Its bitcoind process got killed shortly before running out of memory.
You could search for such an occurence in your systems log file:
sudo cat /var/log/syslog | grep -C 10 "Out of memory"
For me something like the following showed me that the system killed the process
# /var/log/syslog
Mar 16 13:04:02 debian kernel: [17352780.421814] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0,global_oom,task_memcg=/,task=bitcoind,pid=1659642,uid=1001
Mar 16 13:04:02 debian kernel: [17352780.422033] Out of memory: Killed process 1659642 (bitcoind) total-vm:6718536kB, anon-rss:1547428kB, file-rss:0kB, shmem-rss:0kB, UID:1001 pgtables:10384kB oom_score_adj:0
Mar 16 13:04:02 debian kernel: [17352780.723486] oom_reaper: reaped process 1659642 (bitcoind), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

Ok this is fairly clear now - you need to upgrade your Apollo to use Bitcoin Core v24 or later. Using an older version of Bitcoin Core means Sparrow cannot use it's newer Cormorant library. The BWT library still has the original issue that was fixed in Cormorant with v1.7.7.


Remove assert.equal

This PR is part of the work for #118667
This removes assert.equal from the core tests and replaces it with assert.StrictEqual.
There are a few TODOs:

Replace assert.notEqual with assert.notStrictEqual
Replace assert.deepEqual with assert.deepStrictEqual
Remove the deprecated asserts from built in extensions

@jrieken and @sandy081 There were a few tests which you two made awhile back that I couldn't make strict equal please take a look at them (I've marked them with TODO comments, you can also just search for assert.equal and look for places where it hasn't been changed)

Thanks @lramos15 - Fixed.


[SPARK-29886][SQL] Add support for spark style hash patitioning to v2 data sources

https://issues.apache.org/jira/browse/SPARK-29886
WARNING: this is a preview of a potential way in which to add spark style hash partitioning to v2 datasources.
What changes were proposed in this pull request?
Adds support for spark style hash partitioning to v2 datasources which allows for bucket joins.  Adds concrete classes that are usable by users to define this type of partitioning.
Why are the changes needed?
Currently V2 Datasources are unable to provide support for bucket joins.
Does this PR introduce any user-facing change?
Yes this adds a concrerte implementation of v2 datasource partitioning and cluster so that users can specify spark style hash partitioning.
How was this patch tested?
Unit tests

@rdblue Here's that POC that I was mentioning to you

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@AndrewKL Are you planning on continuing this PR? I would like this feature as well, so if you're not, I can take a stab at it.


Python 3.11 package

Fixes #190

I'm going to work on some of the failing tests, but for all the tests that fails with:
 TypeError: fork_exec() takes exactly 23 arguments (21 given)

We'll need to wait for multiprocess  0.70.15 release (or work on removing the need for it):  https://github.com/uqfoundation/multiprocess/issues/122
I'm leaving the PR in draft untill that's released.
We could build the main branch for the dependency, but I'd prefer to wait for a proper release here.

Another issue was caused by python 3.11 adding a default __getstate__() implementation for the object type, which returns None. Our encoder only checked for the existence of the method, and use that result, so I added a check for is not None on the result of the __getstate__ call.

Since we removed the dependency from multiprocessing in a recently merged PR, I rebased this on top of the current main, let's see if everything else work.


disable optimize, may speed up

Codecov Report

Merging #93 (4bd07b7) into master (ecad7fc) will increase coverage by 0.15%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   83.67%   83.83%   +0.15%
==========================================
  Files          10       10
  Lines         962      971       +9
==========================================
+ Hits          805      814       +9
  Misses        157      157

Impacted Files
Coverage Δ

src/jetcache.jl
78.68% <0.00%> (-2.98%)
:arrow_down:

src/JET.jl
50.00% <100.00%> (ø)

src/abstractinterpretation.jl
96.15% <100.00%> (+0.19%)
:arrow_up:

src/abstractinterpreterinterface.jl
93.54% <100.00%> (+2.63%)
:arrow_up:

src/reports.jl
87.78% <100.00%> (+0.39%)
:arrow_up:

src/typeinfer.jl
98.38% <100.00%> (-1.62%)
:arrow_down:

src/print.jl
79.79% <0.00%> (+1.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecad7fc...4bd07b7. Read the comment docs.

Codecov Report

Merging #93 (4bd07b7) into master (ecad7fc) will increase coverage by 0.15%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   83.67%   83.83%   +0.15%
==========================================
  Files          10       10
  Lines         962      971       +9
==========================================
+ Hits          805      814       +9
  Misses        157      157

Impacted Files
Coverage Δ

src/jetcache.jl
78.68% <0.00%> (-2.98%)
:arrow_down:

src/JET.jl
50.00% <100.00%> (ø)

src/abstractinterpretation.jl
96.15% <100.00%> (+0.19%)
:arrow_up:

src/abstractinterpreterinterface.jl
93.54% <100.00%> (+2.63%)
:arrow_up:

src/reports.jl
87.78% <100.00%> (+0.39%)
:arrow_up:

src/typeinfer.jl
98.38% <100.00%> (-1.62%)
:arrow_down:

src/print.jl
79.79% <0.00%> (+1.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecad7fc...4bd07b7. Read the comment docs.


[SDK] test: add unit tests for delete_job() method

What this PR does / why we need it:
add unit tests for delete_job() method
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Ref: #2161
To verify run:
pytest -v sdk/python/kubeflow/training/api/training_client_test.py -k test_delete_job

Checklist:

[ ] Docs included if any changes are user facing

New PR created following conversation in  #2202

Please rebase your PR @Bobbins228.

@andreyvelich both PRs are updated :+1:

@bhupc I think, we need one more rebase since we recently push changes to the training client tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 33.469%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller.v1/mpi/mpijob_controller.go
2
81.05%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.02%

Covered Lines:
3949

Relevant Lines:
11799

💛  - Coveralls

@andreyvelich rebased

Thanks for the update @Bobbins228!
/lgtm
/approve


Fix problem with dashes in arg name and remove dependency of arg order

👋 Hi @ntsvetanov thanks for the contribution! Will take a closer look over the next day or two and do a proper review.


Remove API dependency on Tuple in runtime-field

We currently use Tuples to store operands in field predicates, but this causes some problem since it requires all Speedment project to depend on the Tuples library. When we make changes to Tuple, we also indirectly make changes to the entire core API. Instead we should create the interfaces required to specify the operands of predicates directly in runtime-field.

This allows com.speedment.common.tuple to be transitively used by only the join module and so the minimum runtime can be smaller.


Fixes a wrong logging format in QueryIdCachingProxyHandler

Context
A small fix for a logging format in QueryIdCachingProxyHandler.

@Barbayar please submit a CLA

Sorry for a delayed response. Just signed and submitted.

No worries @Barbayar .. it will probably take a bit until we get to process it.

@Chaho12 I'm not sure if dumping the whole object is a good idea. It already contains the user information. Also, we don't know who is going to add a sensitive data into QueryHistoryManager.QueryDetail in the future.

@cla-bot check

I agree that we dont want to leak the full query details into the log.


Add tree markers to woodcutting plugin

Nice little feature that osbuddy has to mark the trees you want to cut down so they're easier to tell apart at a glance.

Also, the dense essence rocks mined when Zeah runecrafting to tell the difference between to depleted rock. Furthermore, the markers are removed when your inventory is full to combat you not knowing whether or not your inventory is full when the notification blocks part of your inventory as shown in the image

Could you snap a screenshot of these osbuddy features for the issue thread? It'd help those of us who aren't familiar with the client (I dunno if they're paid features or not).

osb just puts a little axe icon on the marked trees, I dunno if I'd want to do that or highlight the whole model.

(To clarify how it works, there's a toggle for each type of tree, so if you're chopping oaks then you toggle Oak on and it puts the axe icon on all oak trees)

Thanks, this sounds helpful and easy to use. Support!

Im currently working on this.
I think i will PR it in a few days as its very WIP atm.

Sexy! Bonus points if you make the axe icon show the axe you're holding lol

i was thinking about making an icon. but i guess thats a nice idea.

#3386 adds redwood trees to the woodcutting plugin. I do not think showing any other type of tree is useful.

Yew, oak, and normal trees all look similar from above. Differentiating them is useful.


Error reported

Peek function does not currently support Babel ES6 Javascript files. New to React and Atom so if there's a config file you want to see let me know.

Hey, just send me an example of the function you're trying to peek and I'll see if I can reproduce it. Also, the type of file shown at the bottom matters. If you could tell me what that is or see if it's in this list (https://github.com/DFreds/code-peek-atom/blob/master/lib/supported-files.coffee), that'd be great.

[image1.jpeg]
Tom Hare
On Jul 5, 2018, at 8:33 PM, DFreds <notifications<EMAIL_ADDRESS>wrote:
Hey, just send me an example of the function you're trying to peek and I'll see if I can reproduce it. Also, the type of file shown at the bottom matters. If you could tell me what that is or see if it's in this list (https://github.com/DFreds/code-peek-atom/blob/master/lib/supported-files.coffeehttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDFreds%2Fcode-peek-atom%2Fblob%2Fmaster%2Flib%2Fsupported-files.coffee&data=02|01||e2c5daa4d31e4dc4375f08d5e2f136d9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636664447983383736&sdata=z4mltbQHDiMyerADMhO5kzg2MPZ4FuGYXkdUTqsYlcE%3D&reserved=0), that'd be great.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDFreds%2Fcode-peek-atom%2Fissues%2F41%23issuecomment-402915646&data=02|01||e2c5daa4d31e4dc4375f08d5e2f136d9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636664447983383736&sdata=aireInQAIJV4x76uFPXSkWOBiAdEZQd3Vo9yVNSVWc8%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMLxFJPby0N0eLqRy47ykrLoME56o-nhks5uDtp9gaJpZM4VENbP&data=02|01||e2c5daa4d31e4dc4375f08d5e2f136d9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636664447983383736&sdata=CSZH8oU6DFk0Uo2k5yi%2Fu%2B%2FjG9yOttsXE99NivQS3BI%3D&reserved=0.

I think something went wrong there.

If I click one of the references and select peek I get the error.
Tom Hare
On Jul 5, 2018, at 8:53 PM, DFreds <notifications<EMAIL_ADDRESS>wrote:
I think something went wrong there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDFreds%2Fcode-peek-atom%2Fissues%2F41%23issuecomment-402918209&data=02|01||9fba8c2bf943404d8c8908d5e2f41a20|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636664460385108505&sdata=Iyc3F1xGt%2BEdRPM9FxUkH88eeTw2HtV3zl1PKf35ZCs%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMLxFElsJbZ-vijl2_9B04oXEpyzFb8uks5uDt9VgaJpZM4VENbP&data=02|01||9fba8c2bf943404d8c8908d5e2f41a20|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636664460385108505&sdata=4S7iG%2Bzpxyj6mewc0w7tQe8sUnrCxlZXySW8IQfrqqc%3D&reserved=0.

I mean that I can't see the image. Please send me some code and a picture of your atom window.

I don't know if I have exactly the same problem, but after a fresh package install of code-peek, the javascript functions should be found I guess, however, when I select the description text of a function or the part where I import it, the ctrl-alt-e shortcut returns an error: "Could not find {functionName} in project".
However if the function is declared within the scope of the same file it does not return an error. It feels like code-peek does not search through all of the files in the project. Is that correct? And if so, would you know a fix?
TLDR; ctrl-alt-e only works within the same file

Hm, I wrote code peek a long time ago. It uses the Atom API to search through all the files for a match based on some regular expressions. It's possible that Atom has updated it's API since I've looked at it. I'll check it out

@HanJoHibender Can you send me an example of the function declaration you're trying to match?

@HanJoHibender Can you send me an example of the function declaration you're trying to match?

These are async functions used in a React environment, async and const are not part of the normal declaration. I think unfilled they are called anonymous functions, but anonymous declarations are out of scope.
Example:
export const functionName = async ( variables ) => { code }


Better preconditioning

Following the "Stable Implementation of Probabilistic ODE Solvers" paper by Nico Krämer and Philipp Hennig.

Codecov Report

Merging #53 (96c02b8) into main (784db72) will decrease coverage by 92.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #53       +/-   ##
==========================================
- Coverage   92.12%   0.00%   -92.13%
==========================================
  Files          21      20        -1
  Lines         813     837       +24
==========================================
- Hits          749       0      -749
- Misses         64     837      +773

Impacted Files
Coverage Δ

src/caches.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/preconditioning.jl
0.00% <0.00%> (-95.46%)
:arrow_down:

src/priors.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/smoothing.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/solution.jl
0.00% <0.00%> (-92.50%)
:arrow_down:

src/integrator_utils.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/solution_sampling.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/state_initialization.jl
0.00% <0.00%> (-98.53%)
:arrow_down:

src/diffusions.jl
0.00% <0.00%> (-97.85%)
:arrow_down:

src/ProbNumDiffEq.jl
0.00% <0.00%> (-93.75%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784db72...96c02b8. Read the comment docs.


[Bug]: generics - should return T of [class] but returns [class] #9934

Larastan Version: #.#.#
--level used: 9

Description
Phpstan error: Method App\Repositories\BaseRepository::create() should return T of Illuminate\Database\Eloquent\Model but returns Illuminate\Database\Eloquent\Model.
I've checked https://github.com/phpstan/phpstan/issues/4411 https://github.com/phpstan/phpstan/issues/4412 but I am still not sure what's wrong with the code
Laravel code where the issue was found
<?php

namespace App\Repositories;

use App\Contracts\BaseRepositoryInterface;
use Illuminate\Database\Eloquent\Model;

/**
 * @phpstan-template T of Model
 */
class BaseRepository implements BaseRepositoryInterface
{
    protected Model $model;

    /**
     * @param Model $model
     *
     * @phpstan-param T $model
     */
    public function __construct(Model $model)
    {
        $this->model = $model;
    }

    /**
     * @param array<string, mixed> $attributes
     * @return Model
     *
     * @phpstan-return T
     */
    public function create(array $attributes): Model
    {
        return $this->model->create($attributes);
    }
}

Hello Arpit! 👋🏻
Could you try the following?
    /** @phpstan-var T */
    protected Model $model;

@szepeviktor this works, but is there some way we can automatically assign these generics or something ?

No. There is none.

@szepeviktor Hey sorry I was wrong, for some reason it's still not working.. any other ideas ?

Hi,
This does not have anything to do with Larastan itself.
But this is expected. PHPStan does not have enough information while analyzing the class itself. But it'll work correctly with child classes: https://phpstan.org/r/9787ed3d-7034-4fda-b297-5f08825814ac


Edited malay

Fixed grammar mistakes and some words not being properly translated

Merged successfully, I'll add this in patch 3.0.3 next week.


I wrote a rich rich editor based on draft-js

Do you want to request a feature or report a bug?
feature
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/gmertk/e61z7nfa/.
What is the expected behavior?
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
0.11.7
I wrote a rich rich editor based on draft-js, It's very powerful and I need some star, anyone help me,  look at https://github.com/gland2015/gland

That looks pretty neat, @gland2015! That's the most feature-complete editor based on Draft.js I've seen so far. I especially like that it supports floating images and tables. Nicely done!

hahaha，thank you！ @robbertbrak


[CDC] Potential violation in SPI DEVICE

There is a direct path from cmd_info_i to cmd_info_o as follows.
cmd_info_i comes from IO_DIV4 and cmd_info_o is on SPI clock domain.

cmd_info_i can be latched to cmd_info_q but I am not sure if one stage latch is OK with CDC.

Just an FYI: cmd_info from the CSRs is expected to be quasi-static. Software is supposed to have them set up before SPI clock may begin switching.
There may be some robustness concerns for cases where OT can't make that guarantee (since OT can only set that up with out-of-band control, such as control of the host's reset pin), but I'm not sure if that is a consideration.

@a-will thanks for info. @eunchan can you review?

@tjaychen @msfschaffner FYI

yep @a-will is right. similar to other configs, SW configures the command information data prior to enable the SPI_DEVICE.

@eunchan thanks for confirmation. I added this waiver in https://github.com/lowRISC/opentitan/pull/16673.


installing nmodl on macos with setup.py does not seem to create .so file in site-packages

I am using python 3.7 from homebrew and ran
python3 ./setup.py install

setup.py has updated during last month and working correctly.


'403 Forbidden' for facebook photoURL in Ionic

Hi,
I can suddenly no longer load the profile images from the Facebook Auth provider in my Ionic app. I just get '403 Forbidden'. I have the 'cordova-whitelist-plugin' and have set < access origin="*"/> in my config.xml, and have not done any code changes. This worked before.
Can it be anything related to this library?
I'm able to get around the problem by fetching the image manually, so it doesn't seem to be a whitelist/content-security-policy issue.
$firebaseAuth().$onAuthStateChanged(function (user) {
   if (user) {
      user.providerData.forEach(function (profile) {
         if (profile.providerId === "facebook.com") {
            user.updateProfile({
               photoURL : "https://graph.facebook.com/" + profile.uid + "/picture?height=200"
            });
         }
     });
   }
});

Thanks

Hi @remisture! We have a required issue template. I'm going to close this for now, but feel free to open with an issue that follows the template.


[HOTFIX] Remove ‘hive-service’ from carbondata assembly jar

Problem: In some environments, there will occur 'No Such Method: registerCurrentOperationLog' exception while execute sql on carbon thrift server.
Cause: spark hive thrift module rewrite class 'org.apache.hive.service.cli.operation.ExecuteStatementOperation' and add method 'registerCurrentOperationLog' in it, but when start carbon thrift server, it maybe load class 'ExecuteStatementOperation' first from carbondata assembly jar (includes 'org.apache.hive:hive-service'), this class 'ExecuteStatementOperation' which is from hive-service jar doesn't have method 'registerCurrentOperationLog', so it throws NoSuchMethodException.
Solution: remove all artifacts of 'org.apache.hive' when assemble carbondata jar.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed? No

[ ] Any backward compatibility impacted?  No

[ ] Document update required?  No

[ ] Testing done  No need
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/404/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/404/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/403/

+1

@jackylk @ravipesala please kindly review, thanks.

LGTM


Log statement listener

Is your feature request related to a problem? Please describe.
While NativeDatabase(..., logStatements) is great feature itself, I would like see is there a possibility to add a listener to DB statements. Problem lies, if I want to log these DB statement in file or send to BE service, I can't find clear way to do it.
Describe the solution you'd like
For example, Dio package (https://pub.dev/packages/dio) allows you to add interceptors to listen to onRequest, onResponse, onError calls. Bloc package (https://pub.dev/packages/bloc) allows you to add BlocObserver to listen to its states. But for Drift Sqlite DB solution, seems like there is none for SQLite raw query or I just couldn't find it

I've tried driftRuntimeOptions.debugPrint but it doesn't work. It still printout the log using default print @simolus3


Improve Color Parser

The library only takes in hex and that to only 6 digit hex color codes.

Add in handling for 3 digit color hex.
Add utility to parse a certain input into hex.
eg: rgb(255,255,255) should be detected as rgb and then rgbToHex() it and return the hex value
eg: hsl(0°, 0%, 0%) should be detected as hsl and then hslToHex() it and return the hex value

https://github.com/barelyhuman/tocolor/commit/903c7da8cde25cb87fd511433f6187bee14c477c


Add method into OrientDB class that creates database alongside with passed in users and passwords

Add a method into the OrientDB class that creates a database alongside passed-in users and passwords so users of the embedded database will not suffer anymore.

It was fixed by https://github.com/laa/orientdb/commit/7cda453afae90f47c5ea744aa26ab7da6188d740 .


Locking records epic

Epic about locking

[ ] https://github.com/ugent-library/biblio-backend/issues/565
Lock or unlock record (librarian)
[ ] https://github.com/ugent-library/biblio-backend/issues/564
See if record is locked or unlocked (librarians and researchers) in overview
[ ] https://github.com/ugent-library/biblio-backend/issues/576
See if record is locked or unlocked (librarians and researchers) in detail page
[ ] https://github.com/ugent-library/biblio-backend/issues/574
Make locked records non-editable for researchers and administrative support
[ ] https://github.com/ugent-library/biblio-backend/issues/522
Filter on locked records

@nics @nicolasfranck @netsensei are the stories in this epic okay? Is anything missing? I think I failed to write the comments down.

@mietcls Done. Closing this one.


WEAVE_CIDR ignored: How do I assign an IP to a container at docker run?

With the 1.6.0 release I no longer seem able to access the documentation which led to how I am doing things now.
I am launching weave like so:  $WEAVE launch --ipalloc-range $WEAVE_SEGMENT --ipalloc-default-subnet $IPAM_SEGMENT $PEERS How do I now assign a predetermined static address to a container?  I've tried including on the docker run cli, both 'IP="--ip $NFS_IP"' but also this: 'IP="-e WEAVE_CIDR=net:${NFS_IP}/24"', where I then interpolate $IP into the docker run invocation.  former gives me: flag provided but not defined: --ip ; latter lets ipam provide a lease.

The WEAVE_CIDR environment variable is only used with the proxy; Docker do not pass environment variables through to the plugin.
However, so long as you specify a subnet for your network, you can use --ip. There is an example of the commands at the top of https://github.com/weaveworks/weave/issues/2046; I couldn't quickly find it in the docs either.
General plugin docs are at https://www.weave.works/docs/net/latest/plugin/

Thanks @bboreham but this is what I get:
+ docker run -d --net ymdweave --ip <IP_ADDRESS> --dns <IP_ADDRESS> --dns-search=weave.local. --dns-search=zone1.weave.local --dns-search=yourmessagedelivered.com --name=nfs.yourmessagedelivered.com -h nfs --memory=8gb --restart=always -v /data/var/log/nfs.yourmessagedelivered.com/daemon.log:/var/log/daemon.log -v /data/etc/nfs.yourmessagedelivered.com/exports:/etc/exports nfsv4

flag provided but not defined: --ip

Ah yes, --ip came in with Docker 1.10; I'd guess you're still using 1.9

ok, looking to upgrade then.  Thanks for clarifying that.


Stackoverfow on deeply nested join/map

The following code will trigger a stack overflow.
extern crate futures;

use futures::{Future, done};

const FUTURE_COUNT: usize = 10_000;

fn main() {
    let f = (0..FUTURE_COUNT)
        .map(|_| done::<i32, i32>(Result::Ok(42)))
        .fold(done(Result::Ok(0)).boxed(),
              |acc, f| acc.join(f).map(|(a, b)| a + b).boxed());

    let r = ::futures::task::spawn(f).wait_future();
    assert_eq!(r, Ok(42 * FUTURE_COUNT as i32));
    println!("Hello, world!");
}

gdb backtrace

Thanks for the report! This is indeed the case where massively recursive futures like this may stack overflow. This is similar to massively recursive functions in Rust, however, which may also stack overflow. Unfortunately this is likely to be a "WONTFIX" issue in the sense that the design of the Future trait precludes any mitigation being done here.
Note that while developing this library this was an issue that we were quite aware of. Initially we tried mitigations through trait methods and such but unfortunately it never panned out, it ended up always imposing a cost on downstream consumers.
Another important point we found, though, is that almost all examples which lead to this sort of recursion can typically be written in such a way to avoid it. For example here instead of 10K Join futures it'd be far more efficient to, for example, use the collect future (and this would also avoid the stack overflow problem).
Does that make sense? Did you hit this particular case n the wild though where it was tough to work around?

Closing due to my previous comment


Refactor functions warned by clippy::cognitive_complexity lint

          > > * Add `allow(clippy::cognitive_complexity)` for the `service_daemon` module, [the lint](https://rust-lang.github.io/rust-clippy/master/index.html#/cognitive_complexity) rates the complexity of a function and warns if it is exceeded, in this case 2 functions pass the default threshold, the solution to this is to make it smaller by refactoring, splitting it into multiple functions etc (or maybe not possible in some cases), I've added this as solving it would be outside of the PR's scope, so lets make CI pass.

It's cool to learn about this (for me). Although I opted not to mandate cognitive_complexity lint, I'm curious what the two functions are. (A quick local run didn't turn up such warnings unless I missed them).

Yeah, very interesting to see that clippy nursery suggests splitting big chunks of code/complexity.
    Checking mdns-sd v0.11.0 (/Users/cosminpatrinjan/Github/_contributing/mdns-sd)
error: the function has a cognitive complexity of (50/25)
   --> src/service_daemon.rs:624:8
    |
624 |     fn exec_command(zc: &mut Zeroconf, command: Command, repeating: bool) {
    |        ^^^^^^^^^^^^
    |
    = help: you could split it up into multiple smaller functions
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cognitive_complexity
    = note: `-D clippy::cognitive-complexity` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::cognitive_complexity)]`

error: the function has a cognitive complexity of (26/25)
    --> src/service_daemon.rs:1970:8
     |
1970 |     fn handle_query(&mut self, msg: DnsIncoming, ip: &IpAddr) {
     |        ^^^^^^^^^^^^
     |
     = help: you could split it up into multiple smaller functions
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cognitive_complexity

error: could not compile `mdns-sd` (lib) due to 2 previous errors

Originally posted by @CosminPerRam in https://github.com/keepsimple1/mdns-sd/issues/202#issuecomment-2084783071

I took a look at the lint. I think exec_command is indeed due for refactoring, and handle_query seems to be okay for now. Opened PR #215 to fix exec_command.

done.


2024-10-02_01-35-16_master-next_amazon-ssm-agent

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-9787-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-9787-to-kirkstone-next
git checkout -b backport-9787-to-kirkstone-next
ancref=$(git merge-base a057e508a493e2ec5af3c31f72e5d40fc41bcb13 d4c63f6310ca1903d6eebe4e4d8795317a556a67)
git cherry-pick -x $ancref..d4c63f6310ca1903d6eebe4e4d8795317a556a67

Backport failed for scarthgap-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally.
git fetch origin scarthgap-next
git worktree add -d .worktree/backport-9787-to-scarthgap-next origin/scarthgap-next
cd .worktree/backport-9787-to-scarthgap-next
git checkout -b backport-9787-to-scarthgap-next
ancref=$(git merge-base a057e508a493e2ec5af3c31f72e5d40fc41bcb13 d4c63f6310ca1903d6eebe4e4d8795317a556a67)
git cherry-pick -x $ancref..d4c63f6310ca1903d6eebe4e4d8795317a556a67

Backport failed for styhead-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally.
git fetch origin styhead-next
git worktree add -d .worktree/backport-9787-to-styhead-next origin/styhead-next
cd .worktree/backport-9787-to-styhead-next
git checkout -b backport-9787-to-styhead-next
ancref=$(git merge-base a057e508a493e2ec5af3c31f72e5d40fc41bcb13 d4c63f6310ca1903d6eebe4e4d8795317a556a67)
git cherry-pick -x $ancref..d4c63f6310ca1903d6eebe4e4d8795317a556a67


Trustfall Language vs others?

Not an issue but i'd love to see documentation outlining what the design goals and benefits of the Trustfall Language has over, say, SQL, EdgeQL or etc.
Not that it needs justification of course, but i have a bit of friction when deciding if i really want to embrace the Trustfall query language. Given that the language will be the primary UX for interaction it feels very important. Yet i'm left a bit unsold on if it's the "right" choice. Not that i'm the biggest fan of SQL, for example, but i'd love to see what Trustfall QL (what do we call it?) does better than existing solutions - or where existing solutions fail in this context.
edit: As an aside, Github Discussions might be a useful feature to enable for this repo

Good question and good suggestion — Discussions are now enabled. Thanks! I'll move this there.


[rlgl] restore draw batch state after limit check

The intention behind rlCheckRenderBatchLimit is to occasionally call it to ensure buffer space is available for the next set of vertices to be sent, however if that threshold is reached and rlDrawRenderBatch called to draw existing buffers, the state of all draw batches is reset to default (RL_QUADS and default texture).
This means calling code needs to call rlBegin / rlSetTexture after each rlCheckRenderBatchLimit which returned true; proposed fix automatically restores mode and texture of the active batch so calling code won't need to care if batch did overflow or not.

@mausimus Thanks for the improvement! :D


IO::Handle "replace" deprecated method ins with kv

Hi,
i found IO::Handle method ins (current line number) has been 'replaced' with kv.
for "sample.txt".IO.lines.kv -> $ln, $line {     say "[$ln] $line"; }
See https://github.com/rakudo/rakudo/commit/77fc44d9c0fb6025be0ed1b2506cde996f6c8db6 but ins is still documented.
I think we can't easy replace ins with kv because kv comes from somewhere else.
I can't find the class or role where kv comes from, i have no clue.
But i think it is useful to document this.
Thx.

I looked a bit through rakudo source and the documentation and found that "foo.txt".IO.lines returns a sequence. My guess is that the sequence has the feature when we ask for .kv to return the current position or index and the value.
But how should this documented and where? I like to see it in the IO::Handle docs, because for me it's the natural location for the line number.

I have removed the documentation for method ins which solves one part of this issue.

On 02/17/2016 09:57 PM, jantz wrote:

Hi,
i found |IO::Handle| method |ins| (current line number) has been
'replaced' with |kv|.
|
for "sample.txt".IO.lines.kv -> $ln, $line {
say "[$ln] $line";
}
|
See rakudo/rakudo@77fc44d
https://github.com/rakudo/rakudo/commit/77fc44d9c0fb6025be0ed1b2506cde996f6c8db6
but |ins| is still documented.
I think we can't easy replace ins with kv because kv comes from
somewhere else.
I can't find the class or role where |kv| comes from, i have no clue.
But i think it is useful to document this.
Thx.

Indeed, kv does come from somewhere else. You can see in the example
that it's used on the result of a .lines method called on the IO object.
In fact, kv comes from the List class:
http://doc.perl6.org/routine/kv#class_List
For lists, it simply gives you an index and a value.
Note, however, that usually people would assume a line number would
start at 1, not at 0. So in that example code, it might be wise to at
least point it out, or explicitly write $ln + 1 or something.
Hope that helps, and thanks for contributing to the documentation!

Timo

In 5to6-perlvar, $*IN.ins is still documented as the way to get the input line number like perl5 $., $NR.  That no longer works.


[645] Listening Mode Unsupported Feature

closes #645
Description of Work
When a device does not support listening mode (if the device's language is not set to English or if Siri is disabled), the listening mode toggle will now be disabled and have an explanation footer explaining the feature is not supported on the device.

@jsmorgan42 @SashankPatel @moyerr @Clstroud
Per a conversation in our standup on 05/18:

the expected behavior may need to be that the feature is OFF altogether. In other words, we hide the 'Listen' category and 'Listening Mode' settings.

This solves our issue of what happens for a user that installs the app fresh or updates from a version that did not already have listen mode. An issue tracked by ticket #672

In the case that a user has already enabled listening mode from a supported language, and then toggles their device to an unsupported language, we would still want to present the "device is not supported" message.

Re-tested an can confirm our expected behavior, given recent conversations about this feature. @moyerr said he approved this PR and that I am free to merge when tested. Therefore I am going to go ahead and merge. 👍


There is no export button in dataverse for Teams anymore

Hello MSFT Team,
I tried to backup my solution in a Dataverse for Teams environment and was a little bit shocked, that the export button is completly missing. About last week I was able to export the solution but now I can not do an update?
This docs document says, the button and the functionality should be still there?
best Matthias
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 998b6a1a-a578-f7ce-52e6-1d504e55bbd1
Version Independent ID: 0189e16d-f8af-e510-3b01-939dd6afd84a
Content: Move customizations between environments - Power Apps
Content Source: powerapps-docs/teams/import-solution-in-teams.md
Service: powerapps
Sub-service: teams
GitHub Login: @wimcoor
Microsoft Alias: wimcoor

Thanks for your comment, @mfahsold. This issue has been assigned to the doc author for review.

@Mattp123 @wimcoor Any update on this? I need this urgently as I have customized the Inspections app and need to roll it out to multiple teams

I'm still seeing the Export button in my Dataverse for Teams environment (runnign Teams browser client). However, if in your environment the button is missing, have you tried accessing the Maker portal and doing a solution export from there? You can access it via the Apps view and clicking on "Open in Power Apps".
You'll need to create the solution explicitly since the UX is different from the Export experience in DV4T. For more gotchas related to solution management, check out my blog post: Working with solutions in Dataverse for Teams

@mfahsold - This works in my basic testing from the Power Apps teams app. Make sure you have one or more components selected to trigger the commands otherwise they don't appear.


[BUG] [Remote Store] Missing remote metadata in some cases of concurrent flush and refresh executions

Describe the bug
Use cases like taking snapshots from a local commit requires corresponding remote metadata file to be present which refers to the segments files of the local commit.
As a best effort, snapshot flushes the shard to create a fresh commit and to have respective remote metadata file to be uploaded in remote. Snapshot flow then fetches the latest metadata for the given primary term and generation of the commit. But there are race conditions in which we can not always guarantee remote metadata to be present for the newly created local commit as well.
Scenario 1

Invoke Flush - creates a commit and invokes refresh.
Refresh of flush uploads segments of new commit and then uploads respective metadata file.
Acquire last commit.
More index operations get executed and now another refresh is triggered.
More segments get uploaded and another metadata file referring to the same primary term and generation gets uploaded.
Now, request is made to fetch the metadata file for the primary term and generation of the acquired commit.
Retrieved metadata file won't be referring the segments files of the acquired commit.

Scenario 2

Invoke Flush - creates a new commit.
Before the refresh of flush gets triggered, another scheduled refresh or an external refresh uploads segments which are same as present in the new commit.
New index operations come in.
Now, the refresh of flush gets triggered which possibly merges some of the segments as well.
As expected, the metadata file will no longer be referring to the segments of the newly created commit.

Related component
Storage:Durability
To Reproduce
Integ tests can be written exactly by replicating the steps mentioned in the issue above but those won't be deterministic in nature and may require many iterations before issues can start showing up.
Expected behavior
For every new commit, there should be a respective metadata file in remote store which should consist of references to segments exactly same as the segments of new commit.
There are 2 things which can be done to solve this

Always fetch the oldest metadata file for the given primary term and generation. This will ensure scenario 1 doesn't occur.
Always upload a metadata file referring the segments of the commit in case a new commit is seen first in refresh listener and then trigger the expected upload of segments of reader.

Additional Details
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

[Storage Triage] - Attendees 1 2 3 4
@vikasvb90  : Can you please add an IT to replicate this even if it reproduces this issue in good number of iterations ?


Refactor getURL() in tests to remove hosted URL dependency

As of now, testing is currently taking place with a hosted server. This server should be replaced with a LocalTestServer from the com.azure.core.test.http library to allow for offline testing and to remove the dependency of the hosted server.
Good examples of how to instantiate this LocalTestServer can be found in the azure-core-http-jdk-httpclient tests. Paths should be set in the instantiation to define the server behaviour needed in the tests. For example, a path of '/closeConnection' could be used to terminate the connection between the client and server to ensure that the client is capable of recognising the connection being terminated.

I'll be working on this shortly.


dfu-util: Last page at 0x90061c6f is not writeable

Hi, I just built a GuitarPedal1590b-SMD and I'm trying to flash the Daisy Seed. I followed the instructions to set up the build environment and compile the code, which all worked correctly, but when I try to run make program-dfu I get:

dfu-util -a 0 -s 0x90040000:leave -D build/guitarpedal.bin -d ,0483:df11
dfu-util 0.11
Copyright 2005-2009 Weston Schmidt, Harald Welte and OpenMoko Inc.
Copyright 2010-2021 Tormod Volden and Stefan Schmidt
This program is Free Software and has ABSOLUTELY NO WARRANTY
Please report bugs to http://sourceforge.net/p/dfu-util/tickets/
dfu-util: Warning: Invalid DFU suffix signature
dfu-util: A valid DFU suffix will be required in a future dfu-util release
Deducing device DFU version from functional descriptor length
Deducing device DFU version from functional descriptor length
Opening DFU capable USB device...
Device ID 0483:df11
Device DFU version 011a
Claiming USB DFU Interface...
Setting Alternate Interface #0 ...
Determining device status...
DFU state(2) = dfuIDLE, status(0) = No error condition is present
DFU mode device DFU version 011a
Device returned transfer size 1024
DfuSe interface name: "Internal Flash   "
Downloading element to address = 0x90040000, size = 138352
dfu-util: Last page at 0x90061c6f is not writeable
make: *** [libDaisy/core/Makefile:330: program-dfu] Error 64

I'm able to flash the Blink program from DaisyExamples just fine - any idea what's going on?

Never mind, had to follow these instructions: https://forum.electro-smith.com/t/resolved-error-when-using-program-dfu-with-diasy-bootloader-and-the-app-type-sram/3934/4
and it seems to be working now! thanks so much for this project, really excited to play around with it!


[BUG FIX] Fix error when checking configs before network resolves

Context: https://github.com/statsig-io/android-sdk/issues/8
Test Plan:

Reproduced the error via the StatsigCacheTest when updating the mocks
Removed the lateinit in the network class to prevent the error
Updated initialization path with synchronous local storage which was incorrectly moved (and the test had mocked improperly)

hmm tests pass locally but arent working on github.  Still trying to figure that out


How to set up bridge mode

Hey, how would I need to configure the bridge mode to connect to my vaccum cleaner/robot?
I've used Parallels Desktop before and it was just straigt-forward by selecting Wifi Adapter via "Bridged: Wifi".
Now with UTM Virtual Machine and Ubuntu 22.04, I can't get the bridge mode set up correctly to connect/ping my vacuum cleaner when I connect my Macbook with the robot's Wifi. Keeps receiving "Host unreachable".
What are the correct bridge settings here?
Bridge Interface, Emulated Network Card and MAC Adress?

UTM Version: latest
OS Version: Apple Silicon/M1

Rather simple. Go to the UTM manager and select your VM and click on 'Settings'. Go to Network and select in modes 'Bridged', default it is set to 'Shared network' which cannot find other devices in your LAN.
When 'Bridged' it can connect to other devices.

Jup, I am aware of that and that was not really the question, which is the correct network card to emulate for the Macbook's Wifi? Can't get it running.
This is what I receive directly from my Macbook when I do ping <IP_ADDRESS>
patrick@MacBook-Pro ~ % ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: icmp_seq=0 ttl=64 time=17.440 ms

this is out of the UTM VM:
patrick@ubuntu:~$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
From <IP_ADDRESS> icmp_seq=1 Destination Host Unreachable

So bridged seems not to work.

What is the address of you Macbook ? It should be 192.168.8.XXX and the address of your device should also start with the same prefix: 192.168.8.YYY.
And the router (which determines the IP addresses) should also have an address like 192.168.8.ZZZ.
And this cannot be reached from an address like 192.168.10.x as it is a different subnet. This has nothing to do with network virtualization.

I would like to create a bridge and redirect all traffic of this bridge through Tor, and then use it in UTM, does seems possible to you?

There is no Manager on my app

Is there no Android UTM?
---- Replied Message ----
| From | @.> |
| Date | 01/01/2024 02:56 |
| To | @.> |
| Cc | @.***> |
| Subject | Re: [utmapp/UTM] How to set up bridge mode (Issue #4085) |
There is no Manager on my app
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Is there no Android UTM?
---- Replied Message ----
| From | @.> |
| Date | 01/01/2024 02:56 |
| To | @.> |
| Cc | @.***> |
| Subject | Re: [utmapp/UTM] How to set up bridge mode (Issue #4085) |
There is no Manager on my app
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Question concerning sports AI

Hello, I am interested to find out more about OpenSteer entree into the .NET realm, especially this SharpSteer.
I am interested to apply this in a sports genre, American Football to start with, likely headless (no, or at minimum crude, visualization, only "simulation" as it were, to start with). Unless needed, definitely no XNA. Do not need/want that as a dependency just now.
If I visualize anything it is likely to be using something like Unity 3D, but more like Helix Toolkit based approach. This is neither here nor there, but to say that if I can use OpenSteer to simulate those motions in a loosely coupled way, the it really shouldn't matter (in theory) which head I use.
I'll check it out, but also interested in some feedback along these lines. I am also encouraged by the fact that, although OS seems to be well beyond end of life, SS seems to be actively maintained, even though extremely niche.
Certainly something that helps to bridge between goals/instructions/skills of underlying AI actors into "tangible" behaviors is just what I want.

i.e. Notes like "Modified to completely remove XNA dependency from the library" is just the sort of thing that would work with me.

Hi Michael
SharpSteer ought to work fairly well for a sports simulation - it works
really well for primitive behaviours (path following, obstacle avoiding)
which can be used by higher level AI (some kind of tactical simulation of
the game and passing the ball etc). I use it in my own game as the the
basis of all AIs in the game, that's a co-operative multiplayer stealth
game with some shooting/combat elements - so as you can imagine the AI at a
high level is seriously complex - but it all builds on SS just fine :)
As you note in your second email, SS itself no longer depends on XNA. Only
the demo project currently depends on XNA.
If you have any specific questions related to SS feel free email me again,
or to open up issues on the SS repo :)
Martin
On 11 October 2015 at 18:48, Michael Powell<EMAIL_ADDRESS>wrote:

i.e. Notes like "Modified to completely remove XNA dependency from the
library" is just the sort of thing that would work with me.
—
Reply to this email directly or view it on GitHub
https://github.com/martindevans/SharpSteer2/issues/13#issuecomment-147228004
.

--
http://martindevans.me

Sounds great! No specific questions right at the moment. I'm certain when I approach a moment of intersection that I actually start adapting my modeling artifacts with SS, I will have a ton more questions. No promises, but as opportunities present themselves, also contribute to unit testing, which in turn I find helps increase the understanding as well.


Armor HUD does not update on settings change

Describe the bug
Changing settings like "Display Total Durability" will not be immediately reflected in the HUD (unless updated via other means like durability change, armor equipping or unequipping, or item change).
To Reproduce
Steps to reproduce the behaviour:

Wear some piece of armor
Open settings for the mod
Go to "Equipment Status"
Change any setting under the "Equipment Elements" section
Save settings and go back to game
Observe that the settings haven't been applied
(workaround to make settings apply) Switch to another item, equip or unequip a piece of armor, or use the durability or armor, or something that updates the HUD.

Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Minecraft (please complete the following information):

Game Version 1.20.4
Mod Version: 4.7.0

Additional context

Oh yep, I recreated the same issue on all game versions; I forgot to invalidate the cache on config updates; it's a simple fix; thanks for bringing it to my attention.


Check-in with the BatchRegistry contract

Goal
Check-in into the BatchRegistry contract.
💡 This issue doesn't require you to raise a PR, just get yourself checked-in. Create a local branch to work on this.
BatchRegistry contract
The BatchRegistry contract is deployed on Optimism.

Check it out on Etherscan
Check it out on abi.ninja

You can find the contract code in packages/hardhat/contracts/BatchRegistry.sol. It's also available in the externalContracts.ts file in packages/nextjs/contracts/ (for front-end use in future issues).
You can see/interact with the contract on the Debug page of SE-2: Clone this repo, run yarn install and yarn start and go to http://localhost:3000/debug.

💡 You can check if you wallet address is in the allowList ;)
Checking-in
There are many ways to check-in into the Contract. Here we'll use the Scaffold-ETH 2 way ™.
1. Create your own branch
Before you begin, make sure you're working on a separate branch. Here's how:

Clone the repo to your local machine (If you haven't already)
Navigate to the cloned directory in your terminal.
Create a new branch using git checkout -b [your-branch-name]

2.  You should see SE-2 app.

💡 You'll notice that the dApp points to the Optimism chain. Check the scaffold.config.ts file to see how it's configured.
3. Understand the checkIn function
Go the the BatchRegistry.sol contract and check the checkIn function. You'll see that in order to check in, 3 things are required:

The Batch is open (should be open already :D)
Your EOA address is on the allowed list (ping us if you are not on the list)
To be able to call the functions, they must be called from a contract (not an EOA!)

So you'll need to deploy a contract that calls the checkIn function on the BatchRegistry contract.
4. Set up the local environment
Instead of deploying a contract on Optimism, we'll deploy it locally so we can test.

Start your local hardhat node: yarn chain
Deploy the BatchRegistry contract: yarn deploy
a. Check packages/hardhat/deploy/00_deploy_your_contract.ts
Change the dApp chain to hardhat in scaffold.config.ts (targetNetwork should be chain.hardhat)
Start the front-end if you haven't already: yarn start

If you go to the Debug page, you should see the BatchRegistry contract (but this time is deployed locally!)
💡 You'll need to tweak the deploy script to make yourself the owner of the BatchRegistry contract (so you can update the allowList, etc.)
5. Deploy a contract that calls the checkIn function
Now it's time to create a contract that calls the checkIn function. E.g.

Create a CheckIn.sol contract in packages/hardhat/contracts/
Declare an interface for the BatchRegistry contract (More info here: Interfaces in Solidity By Example)
The constructor should receive the address of the BatchRegistry contract
Implement a function in your contract that calls the checkIn BatchRegistry function.
(Optional) You can implement an owner pattern to avoid other people calling the function in your contract ;)
Tweak the 00_deploy_your_contract.ts script to deploy your contract (and pass the address of the BatchRegistry contract)

Test it!
6. Check-in live
Once you have tested that your contract works, it's time to deploy it to Optimism and check-in live!

😯 We're dealing with real money now that we're deploying to Optimism!  You should have some oEth from your onboarding process. And don't worry, the Optimism chain is much less expensive to deploy on than mainnet.

Create a deployer account to deploy your contract (yarn generate)
Send some Optimism ETH to it
Check your account balances (yarn account)
Tweak the 00_deploy_your_contract.ts script to only deploy your contract to Optimism (you don't want to deploy the BatchRegistry contract, which is already deployed by us!)
Deploy your contract to Optimism (yarn deploy --network optimism)
Change the dApp chain to Optimism in scaffold.config.ts
Go to the Debug page and check that your contract is there
Call the checkMeIn function!

✅ You should be checked-in! (You can check it by calling the yourContractAddress function)
In future issues, we'll be showing this info on the UI.

Deployed to https://optimistic.etherscan.io/address/0x554c93002C230e8A0d483A26C606A17D6E518086 and checked in

Checking in.
https://optimistic.etherscan.io/address/0xEee6A7cd13D2E3017893BC5095b0A22C4b76D416

Great job, @aspiringLilCoder and @pbkompasz!


--typeNames option for vector export does not work

Supplying a value for this option results in an error.

This issue is resolved with PR #1669

#1669 has been merged.


Silently changing JAX default config

I run into an error while trying to load a JAX NN model, and it took me a while to realize the problem was caused by import pymbar. Here JAX global default is changed to x64, which was incompatible with my stored model.
I solved by setting force_no_jax = True here, but probably it would be nice to have a warning somewhere about this global config change, or mention it somewhere in the doc.

Thanks for opening this bug report @invemichele :heart:
@mrshirts or @Lnaden you both are more familiar with JAX than me, do we need to set 64bit support?
(At first I thought this was about CPU architecture but it is about 64 bit floats https://jax.readthedocs.io/en/latest/notebooks/Common_Gotchas_in_JAX.html#double-64bit-precision)

Looks like we do need 64 bit floats (which is what I thought)
@invemichele I can add a warning and improve documentation, is that sufficient? It doesn't look like we can dynamically change Jax global configs after startup unfortunately

yes, that would be useful info for people that want to use JAX and pymbar in the same script

I've been tinkering with this some more, and I don't think there is a reasonable way to expect PyMBAR to operate in 32 bit mode. Implementing setting 32-bit mode is a bit tricky, but I have an implementation. The problem is there is no reliable way to expect useful outputs. You can get them, but its not reliably accurate or converging.
@invemichele (and others) Is a loud warning sufficient for you use case here, or would it be extremely useful to be able to force 32-bit mode for PyMBAR under the assumption that you're not guaranteed converged results (I would also issue a very loud warning about using 32-bit floats from PyMBAR if thats the case).

To be clear, I am not interested in pymbar using float32. The issue is that by changing the global JAX default, pymbar is in practice incompatible with other JAX code. My notebook with some JAX neural network, stopped working as soon as I imported pymbar and, since the error came from one of my JAX lines, it was not clear to me that the problem was pymbar until I went through its source code.
A warning about the changed JAX global setting would be very useful for debugging.
A solution to the issue would be to give the possibility of setting force_no_jax=True somehow from the import instead of having to recompile pymbar.
Another possible solution could be to automatically fall back to the non-jax implementation if JAX had already been imported outside of pymbar. This would be a safety-first approach, since according to the documentation jax_enable_x64 should be set at startup and could otherwise create problems.

Another possible solution could be to automatically fall back to the non-jax implementation if JAX had already been imported outside of pymbar

That would be a viable option. I think we can expand that to have the safest and most user-controllable approach. From what I can interpret; so long as the JIT'd functions haven't been called yet, we can still set the 64-bit mode. So how does this sound:

On import of pymbar (and JAX), check if 64bit is set, issue a warning that pymbar needs it set and running its code will set it unless disabled, but otherwise dont do anything yet.
Add a API features to the main MBAR code which will disable the JAX pathways so users can toggle that as they need.
Create a call in mbar_solvers which toggles JAX globally for its functions that the main MBAR code can toggle as well. Simplest implementation but relies on module-level "global" variable.
Issue another warning when/if 64bit jax is enabled.

Magic word closed this, my mistake. Not ready to close until the API to toggle JAX is in.

In trying to develop the API side of this, I realize this warning doesn't do any real good because the JIT decorators all activate on import before any of the actual functions are called because of how they work. I can disable the jit of functions with a global parameter, but I don't know how to check each function once its called to set the x64 flag and then jit. I need to delay the actions of the decorator until execution. Re-thinking the code. now.
Even though the current merged version doesn't stop the 64-bit setting on import, it will very loudly warn you at least for now.

Got a fix in #505. Once in I can can carry this over to the API.


Move Classes from OrbitCore to OrbitClientData and OrbitClientModel

This is another step of getting rid of OrbitCore. It moves all the
data classes to OrbitClientData and basically SamplingProfiler and
CaptureData to OrbitClientModul.
After http://b/166238019 is fixed, we can also move CaptureData to
OrbitClientData, as it will be then not dependent to SamplingProfiler
anymore (but only the resuling data class).
TracepointEventProcessor had a dependency to Threading.h, that should
be not moved. So in order to move that class, this also uses
absl::Mutex here, instead of using the typdefs from Threading.h.
Test: Compile & run tests

@florian-kuebler Since you already have two approvals: Is there something I should have a look at in particular? Otherwise I would skip that review. :innocent:

@florian-kuebler Since you already have two approvals: Is there something I should have a look at in particular? Otherwise I would skip that review. 😇

Feel free to skip that. I'll basically wait for the CI to run and then submit this ASAP.


Will the code fully release?

Hello, I apologize for the delay in the release of the code. I am really busy this summer and did not get time to fix the code base. I have set some time in the first week of September to push the whole code.

I more or less released all the code at this point. Please raise an issue if something is missing.


Add webdav storage location in keeanywhere settings

Hello,
new feature request
I know keepass is able to open databases via webdav URLs, but, if i use this vanilla feature, it lacks the offline sync ...
Could you think about adding "simple webdav" to the list of storage location available in keeanywhere and treat it just like the others (user/paswd)
(or add nextcloud/owncloud storage provider)
Thanks

As explained several times: no I will not - KeePass can handle it natively.
khrel<EMAIL_ADDRESS>schrieb am Mo., 13. Jan. 2020, 19:32:

Hello,
new feature request
I know keepass is able to open databases via webdav URLs, but, if i use
this vanilla feature, it lacks the offline sync ...
Could you think about adding "simple webdav" to the list of storage
location available in keeanywhere and treat it just like the others
(user/paswd)
(or add nextcloud/owncloud storage provider)
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Kyrodan/KeeAnywhere/issues/201?email_source=notifications&email_token=AACWW2R6ZH7QPXA44ZEJT2TQ5SXSTA5CNFSM4KGGZ6JKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IF2W4UQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWW2T7GZHKPWLA5ZBF57TQ5SXSTANCNFSM4KGGZ6JA
.

As explained several times

sorry for that ...
I understand that keepass may sync the database locally in a temp folder when openning from a wedav storage ... but when offline i didn't find a way to open that last synced copy ...
nevermind, thanks for your answer ...

Sorry for my rude reaction. It was not my intention to annoy you. I
understand that offline caching is an interesting part of this plugin -
beneath the file picker. And I already asked for integrating this into
KeePass itself (like KeePass2Android does).
Initially I wrote this plugin for my personal use and was overwhelmed of
it's success. Now I'm in the situation to maintain an active Open Source
project - which I really really love to. But my spare time is short, so I
often feel not be able to give the support that is "right". I have a kind
of responsibility for my happy users. So I have to decide things like this:
keep this plugin maintainable by myself - and clipping away these kind of
feature requests.
khrel<EMAIL_ADDRESS>schrieb am Mo., 13. Jan. 2020, 20:51:

Closed #201 https://github.com/Kyrodan/KeeAnywhere/issues/201.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Kyrodan/KeeAnywhere/issues/201?email_source=notifications&email_token=AACWW2QD4OOI7O25MLXDSPTQ5TA23A5CNFSM4KGGZ6JKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOV6BB7EY#event-2944540563,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWW2WKY4JG3QJQ4P4RTNDQ5TA23ANCNFSM4KGGZ6JA
.

no prob ... user requests on good program is a nether ending story ...
I think i will make the trick i need with a trigger to export "on open" to a local folder
Thanks again ;)


Fix Hail installation instructions

Thank you for updating the docs!
We might wanna use the official hail package here though See also populationgenomics/hail#150

Thanks for the suggestion, updated this PR!