Add files via upload

unlock my jetbrain

@Nhat030102 I am sorry, the domain sis.hust.edu.vn is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


fix(card): Input to change the card elevation

Fixes #4233

@jefersonestevo I really appreciate your work, but wouldn't it be better to discuss those features before implementing? If the team doesn't like the idea you've done your efforts for nothing.

@dahaupt I agree with you that it may be a waste of time if the team doesn't like the idea, but I had it already implemented this as a directive on my app, so the real 'extra' work I did here besides the one I had already done was to create the card.spec.ts. Anyway the next time I'll wait for the discussion prior to really make the PR

Thanks for the PR!
I'd really like to keep the card as behavior-free as possible. In this case, I don't think it's necessary to add an input and associated cost of binding / generated code to accomplish what's normally done with a css class.


fix: remove offending action

This fixes an error in the push-to-main github action.

Assume we can remove this step since we're already doing this in the CI workflow?

It's not valid in this context and was causing the action to fail. It is hooked up in the CI workflow though.


Update build of Color package to allow nested import

Fixes 4939 .

Changes proposed in this Pull Request:

Allow nested import for branding

Screenshots / Screen Recording (if applicable)

To Test:

Run yarn build
Copy branding and dist folder in RN showcase demo to check colors.
Use the above image for reference to import
Update readme

Any specific feedback you are looking for?

Please update the changelog.

Done. Please check.


Improve .retry() method functionality with delays and prevent calling on successful request

This PR adds new functionality:

The ability to specify the callback of .retry() as an async function. The purpose is to enable awaiting a Promise within the callback. This could be to used to fetch some external data, or by simply utilizing a setTimeout to resolve the promise after a specified delay. The result is that the .retry() is delayed by the given amount (or after the data is received). It does not break existing functionality i.e. the .retry() method can still be a normal synchronous function without any difference in behavior.

This PR also Resolves #1526

It prevents the .retry() method from being invoked on a successful request, and only allows it to invoke when there is a specified non-null error passed to .callback()

I'm not understanding why the build is failing, can someone explain?

@IAMtheIAM it seems that the tests fail due to unhandled promise rejection related to retry tests https://travis-ci.org/visionmedia/superagent/jobs/610131622?utm_medium=notification&utm_source=github_status
if you fix + also fix merge conflicts (perhaps rebase to latest in our master branch and then add your work on top is best approach) - I would def merge and release this fix

Closing until you submit a better PR

Re-opened

ping @3imed-jaberi

@niftylettuce I resolved the merge conflicts by rebasing master onto my branch
I'm not sure about resolving the test yet, I'll take a look.

Yes you forgot to update yarn lockfile and also you were missing adding @babel/plugin-transform-runtime to dev dependencies

One moment, I'm fixing

@IAMtheIAM can you please pull the latest from master branch?  I pushed commit 0c4f96f but the tests are still failing.  Please resolve and let me know.

@IAMtheIAM see https://travis-ci.org/github/visionmedia/superagent/jobs/709314173 for failing tests

I have reverted https://github.com/visionmedia/superagent/commit/62eae787fa3212b863b5f0320dca9c8f0cb3a889 until tests are passing and this PR is re-submitted.

I'm going to leave the revert as is.  This would be a major breaking change, as some may be using the retry callback to retry the request completely, even if no error occurred.  Albeit it should be intended that a retry only happens when an error occurs, however we should leave this up to the user to override.  If you do not want anything that has an error to even hit the shouldRetry function, then you could make a custom retry function callback.

With regards to the async/promise support, that would be nice to have, but it seems your PR broke all the tests.  If you can fix this and then re-submit (taking out the err !== null portion, then let me know.


AOL Desktop (extra regex) and AOL Shield (added)

[x] AOL Desktop Browser - https://github.com/WhichBrowser/Parser-PHP/issues/144
[x] AOL Shield Browser - https://github.com/WhichBrowser/Parser-PHP/issues/145

Coverage remained the same at 100.0% when pulling 8b9c169b46dc8ce564fec5d9fd2e668c463b3e70 on ayumi-cloud:aol into 4899110cd2f87b01e04ced62dbb9dec541031dee on WhichBrowser:master.

@NielsLeenheer Please can you merge this pr.


Add validator for UUIDs

Hi @garydgregory !
A lot of times I need to check the validity of incoming parameters and use the Commons Validator library. Thanks for that!
Since I validate UUIDs a lot of times, I wanted to contribute a thoughtful and fast UUID check to Commons Validator. It would be so kind if you could include this.
Thank you very much!
Daniel

Very cool @sheelprabhakar ! What are the next steps? Will someone merge this PR?

I will review this by thelis weekend.

@garydgregory So cool, thank you very much!

@garydgregory Okay, if your opinion and understanding of tests is a problem and you don't want additional validators, then I'll close this PR.

So we're just going to let this die? Ive been looking for basically this to allow an annotation based validation of UUID parameters or at a minimum a nice concise way to somehow say isValid outside of just a parsing exception. IMHO the reason this is necessary is there are places it would be better to have validation rather than just parse errors.

So we're just going to let this die? Ive been looking for basically this to allow an annotation based validation of UUID parameters or at a minimum a nice concise way to somehow say isValid outside of just a parsing exception. IMHO the reason this is necessary is there are places it would be better to have validation rather than just parse errors.

Hi @benrhine ! The folks from Hibernate Validators were able to read my tests without problems, liked my implementation and merged it into the new version. It will go into version 8.0.0 https://github.com/hibernate/hibernate-validator/pull/1199

sad about seeing this closed :-(. So to validate a string to be an UUID in Java still needs to copy paste the regex around? pulling hibernate seems to be a bad option

From my point offside the test coverage looks fine and while it is a bit unusual it’s easy to read and allows for good error messages. So if nothing else speaks against it, i will merge it.

From my point off view the test coverage looks fine and while it is a bit unusual it’s easy to read and allows for good error messages. So if nothing else speaks against it, i will merge it.

So, is it merged?


Nginx 403 display is incorrect

After installing modsecurity, I customized the 403 page., but it always redirected to nginx's own 403. Does modsecurity force the 403 page to redirected to the default 403 page?
This is my config:
error_page  403       /403.html;
location = /403.html {
root html;
}
location = /wangjun {
return 403;
}
when I curl /wangjun It‘s working for 403  But when I triggered the modsecurity rule and jumped to nginx default 403, why?
the mod audit.log show
"---UlxxkFzx---E--
\x0d\x0a403 Forbidden\x0d\x0a\x0d\x0a403 Forbidden\x0d\x0anginx\x0d\x0a\x0d\x0a\x0d\x0a
---UlxxkFzx---F--
HTTP/2.0 403
Server: nginx
Date: Thu, 28 Mar 2019 02:31:08 GMT
Content-Length: 146
Content-Type: text/html
Connection: close"

Hi @Hello-Linux
This is known limitation and it's being tracked at https://github.com/SpiderLabs/ModSecurity-nginx/issues/76.
Please check the issue and follow up with your observations there.
Thanks!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/SpiderLabs/ModSecurity/issues/2051#event-2240760726, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AuXGFlDDT5C2mN2FEyThWCo5geI0XMauks5vbr8GgaJpZM4cG1Eu.

thank you


perf(shell/zsh.rs): avoid hook-env execution on Enter without command

Some zsh configuration are intentionally optimized to work really fast and it's important to keep it feels this way. And while mise hook-env is really fast (0.008 sec on my system) and slowdown isn't noticeable when running any command (even builtin one like echo or true) it still result in noticeable slowdown when just pressing Enter without any command.
At a glance proposed optimization shouldn't break any functionality, and it fixes mentioned above noticeable slowdown.

Also, if mise activate zsh will now output code which runs mise hook-env, then this doc should be updated: https://mise.jdx.dev/dev-tools/shims.html#zshrc-bashrc-files

It could be my particular setup, but I'm finding that the chpwd and precmd hooks are both executing whenever I change directory (in that order), so I've replaced the _mise_hook in my .zshrc as follows to ensure they're mutually exclusive:
source <(mise activate zsh)

function _mise_hook {
  source <(mise hook-env -s zsh)
  ZLAST_COMMANDS=""  # prevent precmd hook also triggering
}
ZLAST_COMMANDS="_"  # ensure the precmd hook executes initially

ZLAST_COMMANDS="_"  # ensure the precmd hook executes initially

I think it's better to do eval "$(mise hook-env -s zsh)" instead here (after mise activate) - this way is mentioned in the docs, it doesn't mangle ZLAST_COMMANDS and it doesn't makes any assumptions about current hook optimizations.

  ZLAST_COMMANDS=""  # prevent precmd hook also triggering

This may breaks other things which use ZLAST_COMMANDS. So, it's more safe to use own flag instead:
+typeset -g mise_skip_hook_cmd
 _mise_hook() {
   eval "$(mise hook-env -s zsh)";
+  mise_skip_hook_cmd=1
 }
 _mise_hook_cmd() {
-  if [[ -n "$ZLAST_COMMANDS" ]]; then
+  if [[ -n "$ZLAST_COMMANDS" && -z "$mise_skip_hook_cmd" ]]; then
     _mise_hook;
   fi
+  mise_skip_hook_cmd=
 }

If you like to avoid this extra complexity then this one will works too in most (but not all) cases:
-  if [[ -n "$ZLAST_COMMANDS" ]]; then
+  if [[ -n "$ZLAST_COMMANDS" && "$ZLAST_COMMANDS" != "cd" ]]; then

Good point, @powerman
I ended up with this solution, which seems to work well for me, and doesn't rely on ZLAST_COMMANDS (I don't always use cd to change dirs, sometimes just directly typing the directory name as I have the AUTO_CD option enabled):
_last_mise_hook_trigger=""

function _mise_hook_chpwd {
  _mise_hook
  _last_mise_hook_trigger="chpwd"
}
chpwd_functions[1]=_mise_hook_chpwd

function _mise_hook_precmd {
  if [[ ${_last_mise_hook_trigger} == "precmd" ]]; then
    _mise_hook
  fi
  _last_mise_hook_trigger="precmd"
}
precmd_functions[1]=_mise_hook_precmd


Replaced property macros in headers

Related: Itseez/opencv_contrib#189

replaced CV_PURE_PROPERTY macros with actual code for convenience
moved CV_IMPL_PROPERTY macros to private core header to use in implementations only
enabled wrapping of ml modules in java and python

Known issues:

cv::ml::ParamGrid class can not be wrapped in python due to some linker problems
documentation for many property accessor methods is occasional

:+1:


Logging improvements

Changed log levels to follow what we did in AspNetCore
Added new overload for internal logger implementation to avoid unneeded allocations

template <size_t N>
void log(trace_level level, const char (&entry)[N]) const

Added is_enabled checks to all currently allocating log calls (those that use std::string and append)
Write directly to stream instead of making a temporary string for trace level string

This looks good but do we want to do more structured logging? (Like the extension methods we have today built on top of ILogger).

Like LogDebug? Not really worth it, it's not like we're publishing a logging library.

Like LogDebug? Not really worth it, it's not like we're publishing a logging library.

No, more like https://github.com/dotnet/aspnetcore/blob/90c45d94ac5f2127063e841964f87188fbda05bc/src/Servers/Kestrel/Transport.Sockets/src/Internal/ISocketsTrace.cs#L11-L21

Some of that would be nice, but I think we should hold off until we do a pass through of all the logs to clean them up and make them consistent.


⚠ Processors has degraded performance

In a23d762, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 114 ms

Resolved: Processors performance has improved in 8c0bddf.


Assign any M365 license to a User with Disabled plan not working

Hi Author,
I tried to assign an M365 E5 license to a user in my tenant and the script failed (https://learn.microsoft.com/en-us/microsoft-365/enterprise/assign-licenses-to-user-accounts-with-microsoft-365-powershell?view=o365-worldwide#assigning-licenses-to-user-accounts). This account has some other existing subscriptions with a few disabled services.
The script you have above works fine but only if other subscriptions are not assigned or they don't have disabled services. I need an example script where we can set another subscription (e.g. M365 E5) with disabled services (e.g. Sway) and the user had some other subscription assigned with some disabled services.
Regards

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 073b885d-191e-8c00-fa59-ad83ba79ec10
Version Independent ID: 4bd5799d-9baf-90b6-634d-398fbea6b66f
Content: Assign Microsoft 365 licenses to user accounts with PowerShell - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/assign-licenses-to-user-accounts-with-microsoft-365-powershell.md
Service: microsoft-365-enterprise
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@NiteshSharma2K19 Thank you for your feedback. We shall update and add a new script to the document for this scenario if need be.
Thanks
Sri

@NiteshSharma2K19 Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/10314
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @NiteshSharma2K19 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Refactor retrieveTransactionType

Move retrieveTransactionType to Transaction class and override methods for specific operations

Coverage decreased (-0.8%) to 99.21% when pulling 2209d1446dcacd9bc66bf85401fcbd0dfec0078b on Trimnosh:refactor_retrieveTransactionType into 82995d46ef4cb683fe905fe3ad046021021129cc on wirecard:90-paypal.

Coverage decreased (-0.8%) to 99.211% when pulling 0ac8f30ab93efb73dbc21c8b235167cb2b8e0621 on Trimnosh:refactor_retrieveTransactionType into 82995d46ef4cb683fe905fe3ad046021021129cc on wirecard:90-paypal.

Coverage decreased (-0.8%) to 99.211% when pulling 0ac8f30ab93efb73dbc21c8b235167cb2b8e0621 on Trimnosh:refactor_retrieveTransactionType into 82995d46ef4cb683fe905fe3ad046021021129cc on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling 3d9b8aac2e6dfe9b7bffbf0aa2f71c517ac8ab1f on Trimnosh:refactor_retrieveTransactionType into 82995d46ef4cb683fe905fe3ad046021021129cc on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling b10204d1a8390f6fb2a91fce181e145129bb6bf0 on Trimnosh:refactor_retrieveTransactionType into 82995d46ef4cb683fe905fe3ad046021021129cc on wirecard:90-paypal.

Coverage decreased (-1.3%) to 98.738% when pulling bd00558a6de4b02fa1db5d7e07f6c73a13e615db on Trimnosh:refactor_retrieveTransactionType into 8b1fa146f9b902e79ef95667b5eaf8d15223db12 on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling ee4d516a1ddb6e58521baca17dc04d99c5ef670e on Trimnosh:refactor_retrieveTransactionType into 8b1fa146f9b902e79ef95667b5eaf8d15223db12 on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling 0faffcedacc84ce5bfe725c5111c05a02682456e on Trimnosh:refactor_retrieveTransactionType into 8b1fa146f9b902e79ef95667b5eaf8d15223db12 on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling d8c958ef86798b7c7a2948e478a23a1d355e8692 on Trimnosh:refactor_retrieveTransactionType into 8b1fa146f9b902e79ef95667b5eaf8d15223db12 on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>d77be21dc4c9efab4064b8c3a622b9 on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling bcb2cccf13ab4bf54e44bb3e96970aa25000a983 on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling 16c9127c1b98f03d5af11b0b3ffa36ab3e2add4a on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling dba096785eb39a836fff0db63db411b5f9ffde05 on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.

Coverage decreased (-0.3%) to 99.678% when pulling 1e87fff81a300748293ccbbe9a0df6d9e3fdff41 on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.

Coverage decreased (-0.3%) to 99.678% when pulling 1e87fff81a300748293ccbbe9a0df6d9e3fdff41 on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling 3f9d4ef213a1863f1f9dbbce897c9e83d20f80b7 on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.

Coverage remained the same at 100.0% when pulling 10bdcd98fe6d70ea977b91458889fc5b815273c5 on Trimnosh:refactor_retrieveTransactionType into 403401d77d9663e5756aae01f2df4ca240c369ea on wirecard:90-paypal.


Update scripting to include mongo credentials

Fixed by e782481d3b641298d770694c667e8e89ae586dfd.  We will probably deprecate remoteUserInsert (should be manageable now by userInsert) and eventually deprecate the scripts that generate javascript which will not be needed once we migrate to tunebank-frontend.


Interactive Proposer

Implement interactive challenger (withdraw reward)

Add test for successful withdrawal of stake and fee by block proposers


access token renewal via setTimeout not being called when browser tab inactive

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Use anonymous auth type, retrieve access token from Azure Maps via Function App and managed identity service principal.
Put tab in background.
setTimeout function is not called
azure-maps-leaflet.js line 2097
Any log messages given by the failure

Token Expired
Expected/desired behavior

setTimeout function is called before token expiry.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Odd. The timeout does offset itself to trigger a period of time before the expiry (300ms according to the tokenRefreshClockSkew constant value). Digging into this, it looks like Chrome and Firefox throttle setTimeout in inactive tabs so that they don't fire more than once a second. but the timeout should still fire after that second. Android, however, has a minimum timeout for inactive tabs of 15 minutes which seems crazy. It looks like there might be a workaround to create a timeout inside a web worker. I'll investigate that.

Interestingly, I helped someone with an issue around timers and inactive tabs previously and came up with a workaround there that will likely work here: https://stackoverflow.com/questions/72534800/web-audio-when-mobile-screen-turns-off-settimeout-slows-down/72534877#72534877 Going to try adding this into the project today.

I have updated the code to support this scenario. It should also work if using the map in a mobile browser and the device lock screen is on.


JBrowse label obscures features.

Is there any way to prevent this?

the features are often under the label.  It is difficult to scroll to position them so that they are not under the label.

I don't know of a solution apart from having shorter labels.

perhaps #1588 will fix it?

I think that's about the features labels rather than the track labels.

Ah ok.  that would be daft.

actually I can see the features and read the labels.  this wasn't clear when I was looking. Maybe  a different (stronger) feature colour would help?

Maybe a different (stronger) feature colour would help?

I tried a few colours and they were all a bit hard to see.  Darker colours were more visible but were also ugly.

ok we will stay as we are...

I tried a few colours and they were all a bit hard to see.

That didn't work but in the documentation it says:
Set "trackLabels": "no-block" to enable the trackLabels to be out of the way
of the features.

I've made the config change.  Let me know if we should keep it or revert to what we had.

much better

I think it will be better not to obscure the features. It wasn't so bad here but sometimes it can be tricky


Remove ambiguity from the grammar in the specification

There are a couple of constructions in the current grammar that are ambiguous.
For example, the current grammar could technically accept this:
message group {}
message foo {
    optional group g = 1;
}

But this is actually not allowed -- group is a valid name for the message definition on line 1, but it's not allowed as the type name of a field. In a field declaration it instead indicates a group field, which must have a body (instead of ending with a semicolon).
Another example that the current grammar could technically accept:
package stream;
message Foo
service FooService {
    rpc Do(stream.Foo) returns (stream.Foo);
}

The current grammar could interpret stream.Foo as the qualified name of a message type. However, the correct way to parse this would be as a streaming RPC that uses .Foo as the request and response types. (In that case, the file is not valid because .Foo is not defined, though .stream.Foo is.)
There was some other text in the spec that attempted to explain constraints that are due to how protoc uses a predictive parser (so some tokens are not allowed in some contexts). I have removed all of that prose and codified in the grammar instead.
The example grammars are also updated. They are much more verbose since they do not support a "subtraction" operation in the grammar (which I added to the spec's EBNF variant purely to make the productions shorter and hopefully 🤞 easier to read).

cc @pkwarren, this is follow-on work from the cleanup I did in https://github.com/bufbuild/protocompile/pull/138

Interesting parsing choices?

For sure.  "Whatever protoc does" is how the language was effectively specified, and many "choices" are simply unconsidered consequences of implementation details in protoc (particularly the bits about resolving relative references 🤮).
Our hope was to get this language spec accurate enough that it could eventually become the authority (maybe not this document, but an equivalent one formally published by Google). The intent was to move Protobuf towards being a language with an authoritative specification, instead of a language with an authoritative reference implementation.


[Feature]: DeployStack CLI Tool

Description
Create a command-line interface tool that allows users to run open source applications from our catalog with a single command, similar to how npm works for packages.
Current Process
Currently, to run an open source application locally, users need to:

Visit the GitHub repository
Clone the repository
Navigate to the project directory
Run docker-compose up
Configure any necessary environment variables

Suggested Solution
Create a CLI tool that simplifies this to a single command:
deploystack up <APP_NAME>

Core Features
Application Management

deploystack up <APP_NAME> - Run an application
deploystack down <APP_NAME> - Stop an application
deploystack list - Show available applications
deploystack info <APP_NAME> - Show application details

Integration with DeployStack Catalog

Connect to our existing application database
Pull docker-compose configurations automatically
Handle required Docker images

blocked by #4


react-native >=0.61.0-rc.0 can not update View Component style translateX

React Native version:
bad version of react-native info:
info Fetching system and libraries information...
System:
    OS: macOS Mojave 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
    Memory: 1.60 GB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.15.1 - ~/.nvm/versions/node/v10.15.1/bin/node
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.1/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 21, 27
      Build Tools: 26.0.2, 27.0.3
  IDEs:
    Xcode: 11.1/11A1027 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.0-rc.0 => 0.61.0-rc.0
  npmGlobalPackages:
    react-native-cli: 2.0.1

bad version of react-native info with react-native v0.61.2:
info Fetching system and libraries information...
System:
    OS: macOS Mojave 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
    Memory: 915.73 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.15.1 - ~/.nvm/versions/node/v10.15.1/bin/node
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.1/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 21, 27
      Build Tools: 26.0.2, 27.0.3
  IDEs:
    Xcode: 11.1/11A1027 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.2 => 0.61.2
  npmGlobalPackages:
    react-native-cli: 2.0.1

good version of react-native info:
info Fetching system and libraries information...
System:
    OS: macOS Mojave 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
    Memory: 1.97 GB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
    Yarn: 1.13.0 - ~/.nvm/versions/node/v8.9.4/bin/yarn
    npm: 5.7.1 - ~/.nvm/versions/node/v8.9.4/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 21, 27
      Build Tools: 26.0.2, 27.0.3
  IDEs:
    Xcode: 11.1/11A1027 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.6 => 0.60.6
  npmGlobalPackages:
    react-native-cli: 2.0.1

Steps To Reproduce
clone follow repo and run the code.
POC:
bad version: https://github.com/xqin/react-native-view-transform-bad
bad version with react-native v0.61.2: https://github.com/xqin/react-native-view-transform-bad-v0.61.2
good version: https://github.com/xqin/react-native-view-transform-good
App.js
class App extends React.Component {
  constructor (props) {
    super(props)

    this.state = {
      c: 60,
    }

    let n = 1;

    setInterval(() => {
      let { c } = this.state;

      c += n;

      if (c > 150) {
        n = -1;
      } else if (c < 60) {
        n = 1;
      }

      this.setState({c})
    }, 16)
  }

  render () {
    const { c } = this.state;

    return (
      <Fragment>
        <StatusBar barStyle="dark-content" />
        <SafeAreaView>
          <ScrollView
            contentInsetAdjustmentBehavior="automatic"
            style={styles.scrollView}>
            <Header />
            <View style={styles.body}>
                <View style={[styles.container, { backgroundColor: '#F00'}]}>
                  <View style={[styles.inner, {transform: [{translateX: c}]}]}>
                    <Text style={styles.welcome}>X: {c}</Text>
                  </View>
                </View>
                <View style={[styles.container, { backgroundColor: '#0F0'}]}>
                  <View style={[styles.inner, {transform: [{translateX: c}, {translateY: 0}]}]}>
                    <Text style={styles.welcome}>X: {c}, Y: 0</Text>
                  </View>
                </View>
                <View style={[styles.container, { backgroundColor: '#00F'}]}>
                  <View style={[styles.inner, {left: c}]}>
                    <Text style={styles.welcome}>Left: {c}</Text>
                  </View>
                </View>
              </View>
          </ScrollView>
        </SafeAreaView>
      </Fragment>
    );
  }
};

screenshot

Describe what you expected to happen:
The red block always stay in translateX: 60 since react-native version >=0.61.0-rc.0.
But in the previous version, its behavior was correct.
All version i have tested has been marked.
"0.61.2": "2019-10-02T19:07:56.322Z",        bad
"0.61.1": "2019-09-25T09:41:00.827Z",
"0.61.0": "2019-09-24T19:41:03.466Z",        bad
"0.60.6": "2019-09-24T15:21:26.986Z",        good
"0.61.0-rc.3": "2019-09-10T17:13:38.854Z",
"0.61.0-rc.2": "2019-09-04T16:09:03.174Z",   bad
"0.61.0-rc.0": "2019-08-27T14:41:13.822Z",   bad
"0.60.5": "2019-08-13T17:26:20.325Z",        good
"0.60.4": "2019-07-18T12:59:22.263Z",        good
"0.60.3": "2019-07-11T18:40:32.917Z",
"0.60.2": "2019-07-11T16:23:46.215Z",
"0.60.1": "2019-07-11T15:57:55.193Z",
"0.60.0": "2019-07-03T13:01:09.729Z",        good

@react-native-bot   NO.
I do not think you understand my description.

@xqin don't worry about the bot, your description is fine.

I have this issue with translateY :( it broke after upgrading from 0.59 to 0.60

same problem in 0.61.4
After update style translateX, the view's appear is no change

@xqin - This bug is really annoying.
Since I had no issues with translations (also under RN 0.60+) when I animated transforms using react-native-reanimated, I wondered if switching from RN View to Reanimated View would help
And it turns out it works, so you can treat this as a temporal workaround
import Animated from 'react-native-reanimated';
(...)

<Animated.View style={[styles.inner, {transform: [{translateX: c}]}]}>
    <Text style={styles.welcome}>X: {c}</Text>
</Animated.View>
(...)

No idea what happened here, or why transforms don't work when they're based on state changes, but my hacky workaround is to just set a key on the view based on the changing state value. This forces a layout (which may not be ideal in all cases, but fine for mine).
                   <View key={this.state.results.length}
                      style={
                       {
                          transform: [
                            {
                              translateY:this.state.results.length*100,
                            },
                          ],
                        }}
                    >
 </View>```

@dested 's comment doesn't nearly have the amount of likes it deserves.

I can confirm translateY has the same issue.

Experiencing the same issue with rotate. Setting the key was not an option for me as it resetted drawings on a rotated canvas, but @bpampuch's workaround (<Animated.View />) was a great help, thank you! 👍

Same issue with rotate

I had a similar issue when trying to apply dynamic rotation after migrating to RN 61+.
Using Animated.View from react-native-reanimated fixed it for me.

I can confirm: on iOS the bug is present, on Android it works like expected.
react: 16.11.0
react-native: 0.62.2

Bug Scenario: passing a prop that define the animation state
The component renders correctly the state name in a Text component and the animation is triggered. But the animation/transition does not take place on the screen. It only gets executed when I tap the screen.
const statePosition = {
  preview: 120,
  open: 160,
  closed: 0,
};
// viewState can be 'preview', 'open', or 'closed'
const AnimationTestPreview = ({viewState}) => {
  const positionRef = useRef(new Animated.Value(statePosition.closed)).current;
  useEffect(() => {
    Animated.spring(positionRef, {
      toValue: statePosition[viewState],
      useNativeDriver: true,
    }).start();
  }, [viewState]);

  return (
    <Animated.View
      style={{
        position: 'absolute',
        height: 100,
        transform: [
          {
            translateY: positionRef,
          },
        ],
      }}>
      <Text>{viewState}</Text>
    </Animated.View>
  );
};

I don't know if it's related, but I leave this info here:
If viewState is changed by a setInterval the animation works fine. If it's changed by an async call (in my case I retrieve data from a remote source) it is causing the bug.

Update: apparently when I use debugging the bug appears, when I turn of debugging it works as expected

Discussion
On Sat, Aug 29, 2020 at 17:01 stale[bot]<EMAIL_ADDRESS>wrote:

Hey there, it looks like there has been no activity on this issue
recently. Has the issue been fixed, or does it still require the
community's attention? This issue may be closed if no further activity
occurs. You may also label this issue as a "Discussion" or add it to the
"Backlog" and I will leave it open. Thank you for your contributions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/27003#issuecomment-683261173,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVBYC4NLDJ33T6XDGHHSTSDC7UXANCNFSM4JFAV3GQ
.

Discussion

I had the same issue with RN 0.61.5 and rotate.
@dested's answer worked for me too. 🚀

@dested u are my god.

Unsubscribe
William Pope Jr
On Thu, Sep 21, 2023, 1:04 AM github-actions[bot] @.***>
wrote:

This issue is stale because it has been open 180 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/27003#issuecomment-1728823650,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNSC3CY3DEQJNDUW6BMAJTX3PDGDANCNFSM4JFAV3GQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Add VSFAvatar support

VSFAvatar are only VMR files with custom shaders built in.
I didn't find a way to export VSF avatars from vseeface so I think this issue will not be that useful


Add ability to export .deb and .rpm

vcpkg contains all needed dependency information and is built in the similar way as linux package managers are.
vcpkg also already has similar export (#6891 )
It would great if vcpkg could export set of inter-dependent linux packages (deb, rpm, ...).
Later these packages could be used in custom package source and installed in the custom tailored distribution via native package manager.

+1
And packages in .ipk format, please.


fix(routing): match when server_name have port

I don't think server_name should contain a port.

Disregard my previous comment.
I am not sure if your proxying setup is correct. If you reverse proxy to your WSGI server, you should apply ProxyFix to correct the port.

yup, it could be
anyway  i am not working on that project no more :)


Improve docker events handling

There is a lot of events and their processing must be as fast as possible.
It turned out that events may lost if client is busy: docker server wont wait for a client.
The main idea is to minimize inspect calls if we just want to determine container's status.
This PR may partially fixes #187

merged; thanks @stokito !


Indexing of Js.t

plugin version:
0.75
Description
let oo = {"age": 1};

oo##<cursor>

I'd expect to get "age" in the autocompletion list.
Should be very handy when working with graphql_ppx generated modules and parsed responses (related issue https://github.com/reasonml-editor/reasonml-idea-plugin/issues/164)
module Test = [%graphql {|
{
  user {
    name
  }
  allUsers {
    id
  }
}
 |}];

let query = Test.make()
let data = query.parse(someJsonString);

Autocompletion will work with data and nested objects too
data##<cursor> /* will show user and allUsers */
data##user##<cursor>   /* will show name */

I got some basic autocomplete working but not for a deep fields. Will also try to add support to deep records and js obj methods.

First js.t improvements #171

merged in v0.77


How to enable cppcheck addons?

I'm trying to use the MISRA addon in cppcheck. The corresponding cppcheck command is:
 cppcheck --addon=misra .\test.c
How can I enable it in cpp-check-lint?

try v1.4.3
CppCheck:--addon=["misra"]
support
cppcheck --addon=cert --addon=y2038 src/test.c
unsupport
cppcheck --dump --quiet src/test.c
python cert.py src/test.c.dump
python misra.py --rule-texts=~/misra_rules.txt src/test.c.dump

Thanks, QiuminGe! The MISRA warning now shows.
One more question:
Possible to support the following method to use misra_rules.txt? I tried this way, but seems not working.

I updated read me in v1.4.4
Can it solve your problem？

"args": [
"--rule-texts=misra.txt"
]
Do you know how to use relative paths?

"args": [
"--rule-texts=misra.txt"
]
Do you know how to use relative paths?

Great thanks! The misra descriptions show now.
I'm not sure about relative paths. But, it seems from the Cppcheck manual that the idea is to create a json file with "--script" and "--args", then probably you can use the relative path of the json file in the "--addon" argument when calling cppcheck.


double callback on change of color pane

Hi,
I've noticed that, using a pane with a color input, the callback on the color change by the user is called two times per color change.
You can see the issue here: https://jsfiddle.net/robertoranon/zkwr7upt/
Thanks for help!

Thank you for reporting the issue. It seems that only S-V pad and H slider has this problem and text inputs work fine.

In addition, keyboard input fires a single event correctly and pointer input fires multiple events.

Yes, text input works fine as well as selection between options. However, I see the problem also on the RGB pane, not just HSV (see my previously linked jsfiddle)

Fixed in e9acfa3. Thank you for reporting the issue and please wait for the next release.

In addition, I have to add E2E testing to simulate mouse events. (jsdom doesn't have a support of it)


Save files in picked directory

Hey there! First of all thank you for this lovely package! So far it works absolutely flawless!
I just have one question: How can I save files to a persistent directory that the user chose?
I would like to auto-export backup files into the folder and asking the user every time for that would kind off defeat the purpose of auto backups... So: Is there any way to save files to the picked directory? If I overlooked it in the documentation I apologize and thanks in advance for your response!

Hello, thanks a lot for the sweet words!🌟
Unfortunately, I just noticed that it is missing this functionality. But hey, adding it seems easy, and it's an important feature.
I'll look into it, and if everything goes well, I'll have it ready in a few days.
Thanks a lot for bringing this issue up.

Thank you so much for your nice reply :D
I'd love to help implement this / similar operations but unfortunately I (as of yet) don't know how android native code works ^^'
If there is anything on the Dart / Flutter side you'd like help with, I'll gladly try my best :)

Thank you so much for your nice reply :D
I'd love to help implement this / similar operations but unfortunately I (as of yet) don't know how android native code works ^^'
If there is anything on the Dart / Flutter side you'd like help with, I'll gladly try my best :)

Hello @florian-obernberger ,
Sorry for the delayed update; I've been busy with other tasks and forgot about this. But finally, I implemented this in the plugin.
To test it, you can use the GitHub project as a dependency:
  dependencies:
    pick_or_save:
      git:
        url: https://github.com/chaudharydeepanshu/pick_or_save.git

Example dart code:
// Picking Directory
String? pickedDirectoryUri = await PickOrSave().directoryPicker(
  params: DirectoryPickerParams()
);

// Saving to picked directory
List<String>? result = await PickOrSave().fileSaver(
  params: FileSaverParams(
    saveFiles: [
      SaveFileInfo(
          filePath: filePath,
          fileName: "File.png")
    ],
    directoryUri: pickedDirectoryUri,  //<---------- New parameter for saving to the picked directory directly
  )
);
String savedFilePath = result[0];

You can also run the example app to test it:

I will test it and clean up the old code before publishing it on pub.dev in a few days. So, please feel free to give it a try and let me know your feedback.
Thank you for your patience and support.

Thank you so much!! I will test it out in the coming test and let you know if any problems arise :)

So, I finally came around to testing it and I found one bug / issue: Even when called only once the same file is often saved multiple times resulting in not just <filename>.<ext> but also <filename> (1).<ext>, <filename> (2).<ext> and so on. This occurred both in my own implementation as well as your test app.
Is there something I missed? Should I close this issue and create a separate one?
Also thanks again for this amazing plugin!

Thanks for testing it! Finally got some time to re-work the whole old code and fix all known issues. I'll roll a pre-release by maybe tomorrow!
Also, we will track it here until it's bug-free.


Disable default search path when cross-compiling for Android

Problem
When cross-compiling on linux host, cmake find host library /usr/lib32/librt.so instead of NDK's one
-- Looking for clock_gettime in /usr/lib32/librt.so
-- Looking for clock_gettime in /usr/lib32/librt.so - not found
-- Looking for clock_nanosleep in /usr/lib32/librt.so
-- Looking for clock_nanosleep in /usr/lib32/librt.so - not found
-- Looking for nanosleep in /usr/lib32/librt.so
-- Looking for nanosleep in /usr/lib32/librt.so - not found

As result:
/Users/camobap/.conan/data/log4cplus/1.2.1/bincrafters/stable/build/8a9ebf49259b50bc3e8502b3075e3ed240faf122/source_subfolder/src/sleep.cxx:61:4: error: no nanosleep() or clock_nanosleep()
#  error no nanosleep() or clock_nanosleep()
   ^
1 error generated.
make[2]: *** [source_subfolder/src/CMakeFiles/log4cplus.dir/sleep.cxx.o] Error 1

Proposed solution
log4cplus internally use https://github.com/log4cplus/log4cplus/blob/1.2.x/android/android.toolchain.cmake#L1568
Which define:

set( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM ONLY )
set( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY )
set( CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY )

Also 'official' google cmake toolchain do the same https://android.googlesource.com/platform/ndk/+/master/build/cmake/android.toolchain.cmake#290
So maybe make sense to enable it by default (PR for conan) IDK I'm ready to discuss this

/cc @theodelrieu

@SSE4 @theodelrieu I propose (if have objection of course) to merge this PR, and I will create separate ticket on conan repo
How do you think?

yep, please create a ticket for conan. as a previous one (with ANDROID_NDK define), it doesn't scale well. I am merging it for now.

https://github.com/conan-io/conan/issues/4629
cc @SSE4 @theodelrieu


Can't seem to update azure with any data?

// Application Insights
        ApplicationInsightsModule.forRoot({
            instrumentationKey: '{myKey}', //Commented out for post
        })
    ],
    bootstrap: [
        AppComponent
    ],
    providers: [
        { provide: LOCALE_ID, useValue: 'pt-BR' },
        { provide: BlockUIModule },
        { provide: ErrorHandler, useClass: CustomErrorHandler },
        AppInsightsService
    ]

})

export class AppModule {
    constructor(applicationInsightsService: AppInsightsService){
        applicationInsightsService.init();
      }
}

import {ErrorHandler, Injectable} from '@angular/core';
import { AppInsightsService } from '@markpieszak/ng-application-insights';

@Injectable()
export class CustomErrorHandler extends ErrorHandler implements ErrorHandler {
  constructor(
    private appInsightsService: AppInsightsService
  ) {
    super();
  }

  handleError(err: any): void {
    this.appInsightsService.trackException(err);
    throw err;
  }
}

Using the CustomErrorHandler to send all exceptions to Insights, but I am not getting any data sent.
Also not getting any errors so not sure where to start fixing the issue.

Edit: It was AdBlock blocking the data


Make plugin responsible for managing dependencies

Currently users of the library should manually add necessary dependencies, such as roborazzi artifacts and robolectric.
My suggestion is to make RoborazziPlugin responsible for managing dependencies.
I see roborazzi is split into 3 artifacts, so plugin could install at least core artifact and robolectric.
I can work on this, if you ok with external contributions

Thank you for sharing your ideas and for your willingness to contribute. Your suggestion to simplify the setup process indeed sounds promising.
Regarding your comment that the "plugin could install at least the core artifact and robolectric," I agree that it could be beneficial to have the roborazzi module installed by default.
We might be able to provide Robolectric by using implementation or api in the build.gradle of the roborazzi module. I was initially uncertain about the direction of roborazzi, but I believe usability should be our main concern. (See https://github.com/takahirom/roborazzi/issues/12 for more discussion.)
https://github.com/takahirom/roborazzi/blob/main/roborazzi/build.gradle#L25
Still, I'm pondering whether we should proceed with this installation. For example, JetBrains Compose Multiplatform provides an extension rather than directly installing the dependency.
https://github.com/JetBrains/compose-multiplatform/blob/master/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt
Given these considerations, what are your thoughts on proceeding with the installation? Or do you think the extension approach used by JetBrains Compose Multiplatform is more applicable in our case?

With the latest feature of AGP (Android Gradle Plugin), we now have the ability to capture Compose Preview screenshots. This feature seems to use a different source set from test/. While we can inspect the source code, the artifact has not been published yet, so it's unclear whether Roborazzi can be incorporated into this new structure. If Roborazzi can be integrated, it may require dependencies that are not testImplementation.
Therefore, it might be prudent to wait until more information becomes available.

But, in any case, we can provide an extension for users. It would be used like this: testImplementation(roborazzi.rule).

Let's wait for AGP then.

I have rethought this, and it makes our build settings lose their single source of truth, so I can't support this. However, JetBrains Compose style can still be used.


How can I get the intermediate layers if I used the nn.Sequential to make a Module

Hi guys,
I am reproducing the DeepLabV3+ these days,
and I write a Module like this,
        self.entry_flow = nn.Sequential()
        # entry_flow的第一个卷积层
        self.entry_flow.add_module("conv1", nn.Conv2d(3, 32, 3, 2, 0, bias=False))
        self.entry_flow.add_module("bn_relu1", BNReLU(32))
        self.entry_flow.add_module("conv2", nn.Conv2d(32, 64, 3, bias=False))
        self.entry_flow.add_module("bn_relu2", BNReLU(64))
        # 添加三个Block模块
        self.entry_flow.add_module("block1", XceptionBlock(64, 64, [1, 1, 2]))
        self.entry_flow.add_module("block2", XceptionBlock(128, 128, [1, 1, 2]))
        self.entry_flow.add_module("block2", XceptionBlock(256, 256, [1, 1, 2]))

and I am wondering if I can get the the intermediate output of inner module "block1" and "block2"?
Any answer or suggestion will be appreciated!

No, you can't. That's the whole point of an nn.Sequential: perform all operations successively and only return the final result. If you do depend on the intermediate results you should use an nn.Module and implement a custom forward() method. In your case that might look like this:
from torch import nn

class BNRelu(nn.Module):
    def __init__(self, *args, **kwargs):
        super().__init__()
        raise RuntimeError

class XceptionBlock(nn.Module):
    def __init__(self, *args, **kwargs):
        super().__init__()
        raise RuntimeError

class MyModule(nn.Module):
    def __init__(self, return_intermediate=True):
        super().__init__()
        self.block0 = nn.Sequential(
            nn.Conv2d(3, 32, 3, 2, 0, bias=False),
            BNRelu(32),
            nn.Conv2d(32, 64, 3, bias=False),
            BNRelu(64),
        )
        self.block1 = XceptionBlock(64, 64, [1, 1, 2])
        self.block2 = XceptionBlock(128, 128, [1, 1, 2])
        self.block3 = XceptionBlock(256, 256, [1, 1, 2])

        self.return_intermediate = return_intermediate

    def forward(self, x):
        intermediate_results = {}
        x = intermediate_results["block0"] = self.block0(x)
        x = intermediate_results["block1"] = self.block1(x)
        x = intermediate_results["block2"] = self.block2(x)
        result = self.block3(x)

        if self.return_intermediate:
            return result, intermediate_results
        else:
            return result

If you construct this with model = MyModule(return_intermediate=True) you get a dict with all intermediate results additionally to the final result:
output, intermediate_results = model(input)

If you set return_intermediate=True it behaves like a regular nn.Sequential.

@pmeier , hi, Philip!
Thanks sincerely for your kind reply and detailed suggestions.
And I have a little question why there adds a raise RuntimeError in the constructors of the modules?

I've simply added these classes to make the example "complete", since you have not given us an implementation for BNRelu and XceptionBlock. They are raiseing the RuntimeErrors just to remind you that these classes need to be implemented. Just use whatever you used before.

@pmeier , OK, your codes inspired me a lot,
and I read some more materials yesterday, and I found there is another implementation style of hook, (and I didn't see this style in your suggestions).
So I want to know how do you think about using register_forward_hook  to realizing getting intermediate ouputs of the intermediate modules?

I don't think register_forward_hook() will help you here. The documentation states:

The hook will be called every time after forward() has computed an output.

Thus, if you use an nn.Sequential the output you get in the hook is only the final result and you have no option the retrieve the intermediate ones. The only option to use a forward hook is to store the intermediate results during calculation and retrieve them within the hook. I would advise against this, since:

you still need to implement a custom forward() method that stores the intermediate results and thus this approach has no advantage over my solution and
storing the current state in an nn.Module can get you in a lot of other trouble (think state_dict()).

@pmeier , I think there is a way to realize my idea, let me describe it below:

wrap the the intermediate layers using nn.Module and name it with some specific names, so that we can retrieve them, no matter how deep these inner modules inside the top network;
In the hook function of the top network, get all the chidren modules using model.named_children() and use the specific names to find them, then get their output,
like, searching certain specified files in large directory folder, like walk() in Python.

Just to be sure: you want to have access to every intermediate result not just the "top level"? If that is the case named_children() will not help you as it only yields the immediate children of the nn.Module.

If I understand your approach correctly, your approach has two major flaws:

The input to your model is not the same as the input to the module you want  to know the output from: Besides the first layer the model input has to be passed to every layer before you can pass it through the wanted module.

With your solution you are computing the outputs multiple times. This is a twofold problem:

You perform the calculation multiple times. This is not only inefficient but also
the gradient will be different depending on the number of inspected modules and if you inspect at all.

@pmeier , sorry for my mistake, in fact, my idea is to use model.named_modules() to get every inner intermediate modules so that we can access every intermediate result.

@songyuc  I think the best way without code modification is to use forward hooks as @pmeier mentioned. Another way would be to modify the forward of the module to return the elements that you want, but that requires more code.
Let us know if you have further questions.


Small additions for 0.96.7

Q
A

Bug fix?
yes

New feature?
yes

Needs wipe?
no

Fixed issues
#661, #671, #692

Description:
Small fixes requested/reported by tickets.
Content:

[x] Move save interval to config file for easier adjustment, if needed
[x] Fix missing removal of "on water error" message when building a sector storage
[x] Add an array for steamUIDs in whitelist and add it to the action manager

Successfully tested on:

[ ] Local MP
[ ] Dedicated MP

Not yet tested in game, but should be fine. Quick implementation, nothing special or fancy. Testing will be done until end of the weekend, but could already be reviewed by now.


Make section on control systems

I know of ModelingToolkit.jl, ControlSystems.jl, and ModelPredictiveControl.jl within this space. I have used 2 of them, but only slightly, and would love to have someone better equipped compare the packages. In any case, I will give it a go at some point unless someone else does.

Closed by https://github.com/JuliaPackageComparisons/JuliaPackageComparisons.github.io/commit/e20a576f19bf34cbec86e40f3eeed8824777788e


ddev logs --json-output (ddev logs -j) no longer works (just emits normal logs)

Describe the bug
ddev logs -j should present logs in json format, and it used to (and I think it's important to ddev-ui). It doesn't any more.
To Reproduce
ddev logs -j
Expected behavior
Logs encapsulated by json
Version and configuration information (please complete the following information):
ddev v0.20.0

https://github.com/ddev/ddev/blob/master/pkg/output/sirupsen_orig/json_formatter.go.sirupsen
This PR look like it might have been the last one where said feature worked.
https://github.com/ddev/ddev/commit/d7b5745c00d253cb003d39cb33fdb7afd81a4d40#diff-c0a58b146c62bd1f23410e7f387a07d9be492cd2c4e3a629fcb7167cd8c1bbaf

I wonder if the reason this does not work is the same as why.
ddev debug --json-output does not work.
It seems like both are missing github.com/ddev/ddev/pkg/ddevapp

Actually it might be the fact is missing this package "github.com/ddev/ddev/pkg/output"

Want to fix it @bmartinez287 ? It would be welcome!

It might tricky to fix since it's the oldest issue but I will give it a go.

I was going to start looking at this but then I realised - I don't really know what the output should look like.
Should it be an array with each line as its own entry?
And how should it behave when the --tail flag is used?

I'm starting to lean towards "ddev logs should not support json output"

I'm ok with that. Maybe just make it so if it's used with -j it gives an info statement saying not supported or something.

Are there any other commands (other than composer) which currently don't respect that flag? And if so do they also output a similar message?

I don't think so. And I think that 6-7 years ago this one may have worked with -j :)


IPAddress.each may have unsafe problems?

Summary

IPAddress.each may have unsafe problems (Pointer)[]= ?
I have encountered problems with Pointer in my other projects.
In my other projects, this usually causes the program to crash after a period of time.
I am not sure if it will happen in this project.

Problem
ipcidr = IPAddress.new "<IP_ADDRESS>/8"

ipcidr.each do |ip_address|
  STDOUT.puts [ip_address]
end

Verbose
In _app.cr:8:15

 8 | STDOUT.puts [ip_address]
                 ^-
Error: no overload matches 'Pointer(IPAddress::IPv4)#[]=' with types Int32, (IPAddress::IPv4 | IPAddress::IPv6)

Overloads are:
 - Pointer(T)#[]=(offset, value : T)
Couldn't find overloads for these types:
 - Pointer(IPAddress::IPv4)#[]=(offset : Int32, value : IPAddress::IPv6)

Update

It seems internally needs to be redesigned to prevent type conversion problems.

Finally

Eventually it needs to solve the problem of type conversion, may need to start from parse_u32, parse_u128.

Temporary solution
require "ipaddress"

module IPAddress
  class IPv4
    def self.parse_u32_address(u32, prefix = 32_i32) : IPAddress
      octets = [] of Int32

      4_i32.times do
        octets.unshift u32.to_i! & 0xff
        u32 >>= 8_i32
      end

      address = octets.join '.'
      IPAddress.new "#{address}/#{prefix}"
    end

    def each : Nil
      (network_u32..broadcast_u32).each do |item|
        yield self.class.parse_u32_address item, @prefix
      end
    end
  end

  class IPv6
    def self.parse_u128_address(u128 : BigInt, prefix = 128_i32) : IPAddress
      str = IN6FORMAT % (0_i32..7_i32).map { |i| (u128 >> (112_i32 - 16_i32 * i)) & 0xffff }

      IPAddress.new str + "/#{prefix}"
    end

    def each : Nil
      (network_u128..broadcast_u128).each do |item|
        yield self.class.parse_u128_address item, @prefix
      end
    end
  end
end

# IPv4

ipcidr = IPAddress.new "<IP_ADDRESS>/8"
ipcidr.each { |item| STDOUT.puts [item] }

# IPv6

ipcidr = IPAddress.new "::1/8"
ipcidr.each { |item| STDOUT.puts [item] }

In addition

I encountered an interesting problem while debugging this.
Crystal bug appeared when I specified the type &block: IPAddress -> .
If anyone is interested, you can report this to Crystal officials.

Module validation failed: Function return type does not match operand type of return inst!
  ret i32 %2, !dbg !20
 %"(IPAddress | IPAddress::IPv6+)" = type { i32, [1 x i64] } (Exception)
  from Crystal::CodeGenVisitor#finish:Nil
  from Crystal::Compiler#codegen<Crystal::Program, Crystal::ASTNode+, Array(Crystal::Compiler::Source), String>:(Tuple(Array(Crystal::Compiler::CompilationUnit), Array(String)) | Nil)
  from Crystal::Compiler#compile<Array(Crystal::Compiler::Source), String>:Crystal::Compiler::Result
  from Crystal::Command#run_command<Bool>:Nil
  from Crystal::Command#run:(Bool | Crystal::Compiler::Result | Nil)
  from __crystal_main
  from main
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

require "ipaddress"

module IPAddress
  class IPv4
    def self.parse_u32_address(u32, prefix = 32_i32) : IPAddress
      octets = [] of Int32

      4_i32.times do
        octets.unshift u32.to_i! & 0xff
        u32 >>= 8_i32
      end

      address = octets.join '.'
      IPAddress.new "#{address}/#{prefix}"
    end

    def each(&block : IPAddress ->) : Nil
      (network_u32..broadcast_u32).each do |item|
        yield self.class.parse_u32_address item, @prefix
      end
    end
  end

  class IPv6
    def self.parse_u128_address(u128 : BigInt, prefix = 128_i32) : IPAddress
      str = IN6FORMAT % (0_i32..7_i32).map { |i| (u128 >> (112_i32 - 16_i32 * i)) & 0xffff }

      IPAddress.new str + "/#{prefix}"
    end

    def each(&block : IPAddress ->) : Nil
      (network_u128..broadcast_u128).each do |item|
        yield self.class.parse_u128_address item, @prefix
      end
    end
  end
end

# IPv4

ipcidr = IPAddress.new "<IP_ADDRESS>/8"
ipcidr.each { |item| STDOUT.puts [item] }

# IPv6

ipcidr = IPAddress.new "::1/8"
ipcidr.each { |item| STDOUT.puts [item] }

Most likely it's a Crystal issue, and I cannot replicate it using Crystal 1.7.3.
It has been fixed in the meantime it seems.


resolve issue with existing reports/dashboards and a wiped analytics db

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1359
Originally created by @derek-knox on 2019-12-04 15:53:06

We just ran into an issue where:

on our meltano.meltanodata.com we wiped the analytics db but had existing reports and dashboards
accessing the reports and dashboards errored as there was no data to query (due to the wiped analytics db)

This is likely a unique/exception case as we don't want to have an empty analytics db.
This may be a non-issue, but I created this in case we want to handle in the UI (message to re-run transformations if the analytics db has been wiped) or do a check on the backend and re-run transformations automatically.

View 1 previous comment from the original issue on GitLab


Content Denylist fixes

With the on-chain validations implementation, a few deployments were detected that needed to be deny-listed as there was a bug in the validations.
The deny-listed entities:

don't have to be served by the catalyst /active-entities endpoint.
should still be added to the snapshots so that they are propagated on the synchronization aiming for snapshots convergence.

Merged https://github.com/decentraland/catalyst/pull/1489.

Merged https://dcl.tools/ops/global-config/-/merge_requests/17.


xcproj not running

Cocoapods is supposed to run xcproj to convert the .xcproj file to ASCII instead of XML. However when using
plugin 'cocoapods-acknowledgements', :settings_bundle => true
in the podfile, this does not happen and the .xcproj stays in xml form instead of converting back to ASCII form. This causes major merge issues and makes merging a headache.

CocoaPods hasn't used xcproj for over a year.

How come the acknowledgements plugin then changes everything to xml instead of leaving it ASCII?

I don't know -- can you share an example project that demonstrates the issue?

sure, give me a few days to get some downtime and create one.

I had the same issue. I've attached an example project.
demo-plugin-bug.tar.gz
Steps:
tar -xf demo-plugin-bug.tar.gz
cd DemoPluginBug/
cat DemoPluginBug.xcodeproj/project.pbxproj # not xml
pod install
cat DemoPluginBug.xcodeproj/project.pbxproj # now xml

Xcode Version 7.3 (7D175)
local-gems.txt

@BarakatX2 there's an issue with xcodeproj 0.28.2, which CocoaPods 0.39 uses. Please update CocoaPods (and cocoapods-acknowledgements) to 1.0.0 to fix it.


Is it ready to be compiled in an actual iOS9 app ?

Hi Folks ! Thanks for the conf today was awesome.
I've actually loved the schedule app as a proof of concept.
Is it ready to be compiled in an actual iOS9 app ? It seems that after adding platform ios, building it and running it, an older version shows without maps in a iOS9 device, without speakers list neither and with only a breakfast entry in the schedule tab.
The ionic serve command works perfectly.
Do I miss something ?

@numerized - That is currently an issue we are working through.
Currently, we are using the DatePipe to format dates shown in the schedule.
According to the Angular.io documentation about the DatePipe, it is only usable in Chrome and Opera, unfortunately.
From the docs:

WARNING: this pipe uses the Internationalization API. Therefore it is only reliable in Chrome and Opera browsers.
Formats a date value to a string based on the requested format.

We are currently working on the issue. We have outlined a temporary fix in the meantime to work around using DatePipes.
Stay tuned!

Hey, I removed the DatePipe from the code and reverted back to using a custom date-format Component. The issue Josh mentioned explains it more and links to the original issues where we converted to using the DatePipe. The app is now working on iOS 9, but we found some new issues with iOS 8.
I submitted an issue for iOS 8 here: https://github.com/driftyco/ionic-conference-app/issues/49
The work around is to not use a <form> to wrap the <ion-segment> but then <ion-segment> loses it's functionality. We will be working on a fix for this.

Ok great! That works much better now !
Thanks


Issue 532: Change deps and remove Dagger for pipeline

This PR closes #532 .
The way in which I've addressed problems described in #532 around using RCall and Dagger in the pipeline execution is to:

Move the usage of RCall into an extension of EpiAwarePipeline. This means we can still call to scoringutils in post-processing but it doesn't need to installed for a pipeline main inference compute.
Removed Dagger and replace with pmap. This is a bit disappointing but it works fine for this problem.

Nice good solution. A shame about Dagger

Agreed.


Simplify the filters used for EventsQuery and EventsSubscribe

Currently the filters used for EventsQuery and EventsSubscribe which will primarily be used for selective sync support many different filters.  However this adds a level of complexity that may not be currently needed.
Reduce the filters to what we need for the MVP of selecive sync and add additional filters later on as needs arise with more specific behavior.
The most important filter would be protocol which would allow DWNs to selectively sync all of the relevant data associated with a particular protocol.
This specific ask may require additional enhancements to truly sync all the data a user may need to support a protocol such as Permissions, ProtocolConfgires and Records.

This is done!


Support Alternate Task States

Would love it if it could handle multiple states.  With my old-school analog way of task management, I use symbols to give me a feeling of traction.  I realise this can be handled by tags, with a css snippet it would make my Cardboard so much more visual and a perfect replica of my analog method.
- [ ] Unchecked
- [+] In Progress
- [?] Need More Info
- [>] Scheduled / Deferred / Delegated
- [!] Important
- [x] Completed

I thought I already had an issue for this, but I don't seem to (there is a discussion tho #66) sop thank you for adding.  I would defo like to support this - as I see that some themes support this concept too.
After I've finished off my current few items I will be working on drag and drop, so it will be a while before I get to this but I am tagging it as accepted and needing some thought (as I will need to ensure that I will be compatible with themes).
Many thanks.  I'll keep this issue updated as there is any progress or with any related thoughts I have before I get to working on it.

as mentioned in #130 - some support for this is in hand in the Tasks plugin:

Test build of Tasks with custom status support - for testing and feedback
Project: Custom Statuses for Tasks Plugin

From discord:
ClareMacrae
—
Yesterday at 23:03
I'm aware of the following themes and snippets for custom checkboxes in Obsidian:
Minimal Theme:
https://minimal.guide/Block+types/Checklists
ITS Theme:
https://github.com/SlRvb/Obsidian--ITS-Theme/tree/main
SlRvb's Alternate Checkboxes snippet - same options as ITS Theme...
https://github.com/SlRvb/Obsidian--ITS-Theme/blob/main/Guide/Alternate-Checkboxes.md
Are there any other commonly-used ones I should know about?
ypsyav
—
Today at 00:00
the AnuPpuccin theme has alternate checkboxes.
ClareMacrae
—
Today at 00:03
Ah interesting. Thank you. That references the Primary theme, whose custom checkboxes I was also unaware of.
https://github.com/ceciliamay/obsidianmd-theme-primary#-alternative-checkboxes
This is really useful @gypsyav - thank you!
Oddly Primary does not show up as available on my Phone.
efemkay
—
Today at 00:53
i believe if you don't already have it installed, primary theme won't show up in community theme search. it's still in "legacy" mode, not yet updated for obsidian v1
https://github.com/AnubisNekhet/AnuPpuccin

It would be great if CardBoard supported custom statuses because atm adding a custom status to a task removes it from the Boards since the task is not recognized as such anymore.

Yeah - I may well bump this up the stack as this is prob happening for a few people now that Tasks supports these.  I would prob prioritize reading them so they appear on the boards with theme custom checkboxes and leave being able to change the state to a later release - as I don't want to minimize the other work I take on whilst I get the drag and drop stuff out of the way.

@roovo also it seems to me that changing the state would maybe greatly build upon the drag'n drop stuff. If that is done we could have a "new" board type by custom checkbox status, where dragging and droping would simply change the checkbox :)

see  also: #66


Fix missing serDe properties post migration from hiveSync to glueSync

Change Logs
Add serDe properties to table DDL if missing after migration from hive sync to glue sync.
More context :  https://github.com/apache/hudi/issues/11397
Impact
Describe any public API or user-facing feature change or any performance impact. : NA
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks. : NA
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none". : NA

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@prathit06 Can you check the test failures?

Azure CI is green

@prathit06 Thanks for the contribution, I'm asuming you have done the e2e test offline on AWS GLUE.


Draft updates for multiple labels per tracer, multiple tracers per animal, and multiple labels per peak data rec

Summary Change Description
I only spent a portion of today on this.  I know others have this in their wheelhouse, but I thought maybe this effort was taking second seat to other more time sensitive items, so I thought I would throw together some draft edits for multi-tracer/label support.
This PR is only to get the ball rolling.  I only updated the model classes and did a migration.
Affected Issue Numbers
Partially addresses:

#391
#364
#408

Code Review Notes
There are 3 commits.  I separated the edits of models linking to and modifying the animal model from the ones associated with the peakdata table.  The last commit was migrations.
Note I couldn't find the documentation on the agreed upon model names, so I used the ones I'd documented.  I suggest we use this PR to create issues that identify the desired model names.
It's notable that I had to remove the unique constraint from the peakdata class because the labeled_count and labeled_element fields moved to a different model.  I wasn't sure if I could add a reverse path to the list of ordering fields, but if you guys think we should retain such a constraint, I can dig into it.
I didn't mess with the cached "properties".  Still a lot to do.  Just wanted to touch base on this.
26 tests fail
Checklist

[ ] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
[ ] Tests implemented (or no code changes)
[ ] All tests pass

Quick question(s) [because it will probably take a while to digest the whole]: in the Issues #391 and #408 , there was a suggestion that PeakData be affiliated with a presumptive PeakDataLabel model (one-to-many). I see the peakdata-integral references to labeled_element and labeled_count were removed in this draft, and the concept of a LabelObservation was added. Is LabelObservation equivalent to the PeakDataLabel suggested in the issues?

Yes.  Not a new concept, just a different name.  I had looked for the slides Lance presented in the meeting while back that I believe contained all the names we'd talked about, but I couldn't find it, so I worked from my UML instead, which is virtually identical in structure.  It just made it a lot quicker to implement all the edits.  I knew that the Models would have to be renamed, so thanks for pointing this one out.

[ ] Rename LabelObservation to PeakDataLabel

Should the peak_group referenced in the unique constraint be peak_data, instead?
https://github.com/Princeton-LSI-ResearchComputing/tracebase/blob/ce9b9f5739334e4cf0333bb628765c785d11663c/DataRepo/models/label_observation.py#L58-L60

Oh yeah!  Good eye.

[ ] Change label observation's unique constraint from peak_group to peak_data

By the way @jcmatese - I just noted the means to change the name in VS Code, which updates references to it in other files, is called "Rename Symbol".  When you enter the new name (for say, a class like this), it updates the name in other files:

I know we talked about wholesale changes like these before, so I thought I would mention it.  When I used it to rename the LabelObservation class in label_observation.py, it updated in __init__.py as well.  It even updated the LabelObservation string in that file.  The only place it didn't update was in comments.
I also changed the file name using a similar context menu selection:

...and that updated the import line in __init__.py as well.
VS Code's renaming features don't always catch everything, but they definitely take care of a lot of it.

Closing this after splitting the effort into 2 independent branches...


QR code box styling

This PR moves the Toolbar outside of the Scanner component and adjust the way the scanner view gets masked.
This ensures the Toolbar doesn't overlap the Camera view - see below
The new mask setup also creates a square vs rectangle for the Camera view
See:
https://trello.com/c/EXAVYf4W/1280-ensure-qr-scanning-screen-works-on-all-screen-sizes
How is this working?

Result:

Example current (iPhone)
Scan area is rectangular shape

Toolbar Issues from Beta testing
Pixel 4a
Toolbar gets cutoff

iPhone 12
Toolbar overlap with extra space

Without "the mask" applied

Landscape iPhone SE

iOS build

iOS 12 Pro Max - test

Might follow this up later with a PR detecting aspect ratio
In the Scanner package we can look at:
private void layoutViewFinder(int left, int top, int right, int bottom) {
    if (null == mViewFinder) {
      return;
    }
    float width = right - left;
    float height = bottom - top;
    int viewfinderWidth;
    int viewfinderHeight;
    double ratio = this.mViewFinder.getRatio();
    // Just fill the given space
    if (ratio * height < width) {
      viewfinderWidth = (int) (ratio * height);
      viewfinderHeight = (int) height;
    } else {
      viewfinderHeight = (int) (width / ratio);
      viewfinderWidth = (int) width;
    }
    int viewFinderPaddingX = (int) ((width - viewfinderWidth) / 2);
    int viewFinderPaddingY = (int) ((height - viewfinderHeight) / 2);
    mLeftPadding = viewFinderPaddingX;
    mTopPadding = viewFinderPaddingY;
    this.mViewFinder.layout(viewFinderPaddingX, viewFinderPaddingY, viewFinderPaddingX + viewfinderWidth, viewFinderPaddingY + viewfinderHeight);
    this.postInvalidate(this.getLeft(), this.getTop(), this.getRight(), this.getBottom());
  }


Sweep: Add a standard tailwind footer to main layout.tsx file

Add a standard footer to the src/app/layout.tsx file.
Please use something from Tailwind's standard components.

Hey I took a look at this PR, I don't have access to the Vercel logs so can't tell why it didn't build but otherwise, overall the PR looks solid.


State of the project. (Archiving soon, please read)

I'm thinking about archiving this project and choosing a "true successor" fork to link in the README.
Please leave your thoughts here or feel free to send me e-mails/DM me, etc.
Best case scenario: someone from SFML team picks it up and forks it.
OK scenario: someone who contributed to this project picks it up and forks it (I can also transfer this repo to their account).
Worse-case scenario: there's no one willing to fork it and I'm archiving the repo as-is.
Also see the previous issue which I posted about this. Since then, no one reached out to help, sadly.
This repo will be archived on 01.03.2022.
I've been maintaining this repo for almost 7 years. I think it's time to move on.
I haven't used SFML for almost 3 years since moving to SDL and have managed to move to Ebitengine since then.
It's hard for me to test changes now since I don't follow SFML's development and don't have much time to follow Dear ImGui's development closely either.
This project is free and open source software. You're free to fork it and do whatever you want with it (just give proper attribution as specified by MIT license). I want for people to be able to find "the best" fork out of 140 forks which were currently made. That's why I want someone to take control over ImGui-SFML.
I'm glad that this project was useful to many people (I've used it myself for many years). I think I'll make one last release soon (2.6) and currently pending PRs won't be included.

What about scenario 4 and 5?

Keep the repository and add some of the past contributors as collaborators
Transfer the repo to someone who's willing to pick it up

You shouldn't underestimate the visibility of "original source". If I hit a repo that is fork, I always question, whether this is "best" fork I've chosen. It's also why most forks don't work, because people prefer the "original", even if the fork might be more up-to-date and superior in some ways.

I know the SFML team is pretty busy all the time, but would it make sense to have a shared ownership or transfer it to the SFML org?
I do think it is fair that you do not want to work on it and maintain it. And I want to thank you for everything you did.

I see, I'm OK with doing this. :)

Hi! Although I'm not putting mich energy into SFML-related projects lately, I'd prefer to be added to this repo so I can keep it alive, rather than having it archived or forked.
I do still maintain https://github.com/oprypin/crystal-imgui-sfml, anyway.
Do consider "scenario 4" - just keep it under your name and add people. The downside is only if you're concerned what people will do to the repo while still having it under your name.

@oprypin, thank you. Would you be OK with me transferring this project to you?

Do consider "scenario 4" - just keep it under your name and add people. The downside is only if you're concerned what people will do to the repo while still having it under your name.

Yeah, I'm somewhat concerned about having low-quality stuff in it and people going to me with demands instead of current maintainers. And if, at some point, I would want to delete my GitHub account, it would be harder to do so with an "active" repo.

Would love to see it become part of the SFML org personally. It's compact and powerful and has become an essential tool for a lot of SFML users, I think it becoming part of the org should be considered by the SFML maintainers. If not maybe one of them would be willing to take it over.
I know this is a much loved library for SFML users and the work you did keeping it up to date has been much appreciated. It's power is in how simple it is for a user to grab and get going with ImGui & SFML, something I have benefitted from time & time again. I'm more than willing to contribute again to this in future but I don't think I can take full ownership of it.

I've created a proposal for the SFML Team to take it up into the org, but it wouldn't become an "official" maintained repository, instead the main contributors will be invited as maintainers.

Can I get a link to it, please?

There's no public link for it 🙂

Okay. I'll wait until the decision is done, then.
Also, I'm thinking that making "one last release" wouldn't make sense. Since releases/tags are needed for Conan/vcpkg folks to update their recipes, so it's better if they update the repo link and the tag at the same time instead of doing it twice.

@eXpl0it3r, any updates?

We got positive responses, as such, we'd be happy to add it to the organization and add maintainers such as @oprypin. I believe it would give the project additional visibility and we could always transfer it to someone else if the need arises. 🙂

That's great to hear!
See this: https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository

To transfer repositories to an organization, you must have repository creation permissions in the receiving organization. If organization owners have disabled repository creation by organization members, only organization owners can transfer repositories out of or into the organization.

Looks like you'll need to give me a permission to add repos in SFML organization so that I'm able to transfer this repo.

You should have a pending invitation 🙂

The repo has moved. Thanks a lot, everyone!
I'm not completely abandoning this project. Feel free to request reviews from me if needed. I might also occasionally manage issues and answer the questions people have.
But the project can no go on on its own and I trust SFML team and other contributors to make imgui-sfml even better than it is now. :)

Nice!
Can I be added to the repo? 🙂

🥳
@oprypin: You should have received an invite.


Update docker_cli_build_unix_test

part of #16756
Signed-off-by: Hu Keping<EMAIL_ADDRESS>

LGTM. There is no need to change the assert comments, they are okay where they are right now.

LGTM