Code Quality Recommendations from ToB

Reported by Trail of Bits from their EthStaker Deposit CLI Security Assessment DRAFT report presented on October 8 2024.
The following recommendations are not associated with any specific vulnerabilities. However, they will enhance code readability and may prevent the introduction of vulnerabilities in the future.

[x] Review the use of eval in the build workflow. The eval function is used in a subshell to obtain the first 7 characters of the commit hash, but its use appears to be unnecessary.
[x] Review and resolve shellcheck warnings in the CI workflows. The shellcheck tool points out multiple warnings in the shell script snippets included in the CI workflows. Many of those are instances of potentially undesirable globbing and word splitting due to the lack of double quoting.
[x] Review the return in the init function. The JITOption.__init__ function contains a return statement. The __init__ function is used to initialize objects and not create them, and as such does not return a value.
[x] Consider specifying the encoding to be used in open(...) calls. The program opens multiple files in text mode (see #183 for examples). These open calls do not specify an encoding for these files. By default, open(...) uses device locale encodings, which may corrupt files with special characters. Specify the encoding to ensure cross-platform support when opening files in text mode.
[x] Lock the version of test and linting tools. Several unversioned test tools are installed in the runner workflow, such as coverage and @prantlf/jsonlint.

All of these recommendations were applied.


Need more Chinese and Korean fonts

Need more Chinese and Korean fonts. Fonts should be for programming (monospace, distinguishing between the letter "O" and the number "zero", etc.) and its license allows us to use it in this package.

Yet another great CJK monospaced font here: Inziu Iosevka made by Belleve Invis (@be5invis).

wait
does Atom support ttc?

Atom doesn't support TTC as webfont. But I think the TTF format should work.

@jmlntw I think you should separate families into multiple packages. And the "Inziu Roboto" is proportional, it should not be included.

You already have Source Han Sans, but I would recommend you to add Noto Sans Mono CJK which has latin symbols with half-width of the CJK-characters.
Source Han Sans (Adobe brending) is the same as Noto Sans CJK (Google branding), but as far as I know Adobe doesn't provide a monospaced CJK variation of it, while Google does.

@laughedelic Noto Sans Mono CJK does'nt distinguish between the letter "O" and the number "zero" which isn't suitable for coding, I think. Also Adobe has Source Han Sans HW, which are as same as Noto Sans Mono CJK.

Adobe has Source Han Sans HW, which are as same as Noto Sans Mono CJK.

Thanks, I didn't know it.

isn't suitable for coding

I think none of the fonts in this package is suitable for coding, however they can be useful for writing markdown documents or any other texts. And I think that usage of Source Han Sans HW / Noto Sans Mono CJK would significantly improve mixed language texts over the currently provided non-monospaced fonts.

Sorry, I didn't missed the requirements in the top post. I should have probably opened another issue..

Currently I have no plan to add more new fonts to this package, so I decided to close this issue.
If you have any font suggestions, please open a new issue.


instruction tuning on other datasets

Appreciate the provided code.
I have a question regarding the training process. While the LLM is in the process of learning to generate images, it generates the same text as the input. Nevertheless, during inference, the model is able to produce sensible responses for the input. Consequently, I'm curious if there are any other instruction datasets utilized for fine-tuning the model's ability to follow instructions. If such datasets are indeed employed, could the instruction fine-tuning resources be made publicly accessible?

We do not use any instruction datasets, the model is only finetuned on the CC3M image + caption data. I do think that GILL would benefit greatly from finetuning on instructions, though!


⚠ Bofrost.fr has degraded performance

In 7b400ca, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1185 ms

Resolved: Bofrost.fr performance has improved in 46f6678 after 15 minutes.


Switch audio-device

I used this feature to switch device on call in other software, so it will be good to have this in baresip
And it will be great if you show me where to looks for this  in the code.

what kind of "device" are you looking to switch? Audio-device, interface-device ?

audio device

the code for setting/changing audio-device can be found in audio.c,
look for ausrc_alloc and auplay_alloc:
https://github.com/alfredh/baresip/blob/master/src/audio.c#L1032
can you please describe your desired behaviour of switch audio-device?

are you using baresip program, do you want to update config and update audio-device ?
are you using libbaresip as a library, do you need exposed functions to set audio dev ?
do you need to switch input-device, output-device, or both ?

we have big project which is using freeswitch, for voip we used freeswitch module pa  and know we moved to baresip, in pa module we had functionality to change audio in/output device in eny moment, even during call
so we hope to see the same in baresip

the new API looks like this:
int  audio_set_source(struct audio *au, const char *mod, const char *device);
int  audio_set_player(struct audio *au, const char *mod, const char *device);

please try it out :)


feat(batch): Implement Lookup Join

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?

Summarize your change (mandatory)

Added the LOOKUP JOIN option for LEFT or INNER joins
The parsing, binding, and planning of Lookup Join has been added, however the implementation of LookupJoinExecutor is still incomplete as it is being blocked by the lack of IndexScan.
Note that LogicalJoin now has an extra is_lookup_join attribute. Similarly, all JoinOperator enums besides CrossJoin have an additional bool indicating whether they're lookup join or not (although Lookup Joins can only be used for LEFT and INNER joins).

Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
#2754

There maybe some misunderstanding about the lookup join implementation. The choice of join implementation(lookup join, hash join, nestedloop join) should left to planner, so we don't need to change parser and logical plan node. And to keep this PR small, I would suggest not to leave changes to frontend in next PR, and we focus on executor and plan node first.

The design document, states that the user will be the one to decide whether to use LookupJoin or not. Are we moving the choice of which one to use from the user to the planner/optimizer instead? @liurenjie1024

There maybe some misunderstanding about the lookup join implementation. The choice of join implementation(lookup join, hash join, nestedloop join) should left to planner, so we don't need to change parser and logical plan node. And to keep this PR small, I would suggest not to leave changes to frontend in next PR, and we focus on executor and plan node first.

Currently, since we do not have CBO, I suggested using join hint or SET in this PR. But after a short discussion with @liurenjie1024 , it might be better to decide what join algorithm to use by using SET to 1) keep the syntax consistent with pgsql, 2) keep the query syntax consistent between batch and stream,3) we used SET to decide when to use delta join.

There maybe some misunderstanding about the lookup join implementation. The choice of join implementation(lookup join, hash join, nestedloop join) should left to planner, so we don't need to change parser and logical plan node. And to keep this PR small, I would suggest not to leave changes to frontend in next PR, and we focus on executor and plan node first.

Currently, since we do not have CBO, I suggested using join hint or SET in this PR. But after a short discussion with @liurenjie1024 , it might be better to decide what join algorithm to use by using SET to 1) keep the syntax consistent with pgsql, 2) keep the query syntax consistent between batch and stream,3) we used SET to decide when to use delta join.

Closing this and creating another pull request at #3614 to make it cleaner


Add how-to for setup of bsddb3 on Mac

Coverage remained the same at 94.023% when pulling 74f9cc60da372f98daa04fa96f815cffb8c6358e on mac-bsddb-instructions into 1ff1065ebd98176149c4a49deae0a3365a2c8fc4 on master.


Feat : Add Dynamic serial and model no

-> Add support for file based model no and serial no of device

Signed-off-by: Nabendu Maiti<EMAIL_ADDRESS>

not separate repo used, duplicate


How do I use it in real time, what parts should I change, what tools should I use？

I have the same question.  Does the demo code support real time?


Add ResourseId when move an event

When we move a task from one resource to another the event information don't have the resource id

Python = 3.12.5
Streamlit = 1.38.0
Streamlit_Calendar = 1.2.0

Hello, indeed i'd be also interested in this feature in order to track when a given event is moved from a resource to another one, i fail to make it work for now, any idea ? (without just forking the repo and try to redo things ?!!)

Hi, it should fixed in 1.2.1


Extract into classes code for fetching membership lists and ID mappings

This pull request hopefully separates out the code that (a) goes to remote services (such as a Morph scraper, the Wikidata SPARQL endpoint and EveryPolitician) to generate lists of memberships and ID mappings from (b) the code left in in the prompt_prototype.rb script, which takes those and produces a list of discrepancies between the sources.
Hopefully this makes it easier to look at the prompt_prototype.rb script to work out what might be the next functionality that could be factored out.
The MembershipLists classes return an array of one hash via their to_a method, where each hash has properties of a particular membership.
n.b. I haven't added automated tests for this because before doing extra work to do that, I'd quite like feedback on whether this generally looks like a sensible refactoring.

@tmtmtmtm Good idea about the README / Rubocop. I've fixed a few of the things you've highlighted, but I'm not finished yet (e.g. making the sparql_results code more clear)
Just defining public methods of to_h and to_a is indeed an interim step - I wanted to get the fetching of data out of the way and return it in as simple a structure as possible, so it'll be easier to look at the main script and see what we're going to do with that data and if a different representation would make that easier.


Add and improve some translations (de_DE)

I improved translations regarding grammatics and spelling and added one new translation.
I'm willing to put more effort and work in this if there isn't enough help already :)

Coverage decreased (-0.01%) to 61.712% when pulling 378cfa6480c7ccc3cf964a81f7e382098ea8a3da on l34kr:patch-1 into 1f89371815e71e4e38336d4064ca80a8ed430420 on codecombat:master.

Coverage decreased (-0.01%) to 61.712% when pulling a44d3bf97b22d0b274fb8ebd0e17b49d2faa6771 on l34kr:patch-1 into 1f89371815e71e4e38336d4064ca80a8ed430420 on codecombat:master.

Can someone help? Why is my coverage decreased? Do I have an old version of the file or something? :/
I editted the file right in the CodeCombat repo which than (on save/commit) "became" a file on a new branch in my fork.

I think your workflow is correct and the diffs  -in my opinion - do not indicate that you had an old version or some text was lost
I am sure Brykh will give you a feedback if there should be any issues with your translation or he will fix minor mistakes if there should be any.
BTW, I like your improvements and I am sure your help here would be much appreciated!

I checked it too and at least the number of lines (or sloc) is identical. The history of both files (in my fork and in the original repo here) seem to be identical too.
I will wait for further feedback :)

@l34kr Thanks. Could you sign our CLA so we could accept your pull request?

Done :)

Thanks. Merged.


NODE_VERSION_MODULE error

SerialPort Version: v6.0.3

NodeJS Version:  v7.1.0

Operating System and Hardware Platform: Mac OSX 10.11 El Capitan

Have you checked the right version of the api docs?: yes

Are you having trouble installing and you checked the Installation Special Cases docs? yes

Are you using Electron and have you checked the Electron Docs?: not using electron

Summary of Problem
installing serialport with clang, then running that task, below error apperas
Here is the error stack:  Error: The module '/Users/sempark/mbed/vscode_extension_mbed/node_modules/serialport/build/Release/serialport.node' extensionHostProcess.js:28 was compiled against a different Node.js version using NODE_MODULE_VERSION 51. This version of Node.js requires NODE_MODULE_VERSION 54. Please try re-compiling or re-installing the module (for instance, using npm rebuild ornpm install). 	at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20) 	at Object.Module._extensions..node (module.js:598:18) 	at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:173:20) 	at Module.load (module.js:488:32) 	at tryModuleLoad (module.js:447:12) 	at Function.Module._load (module.js:439:3) 	at Function.G.X.o._load (/Users/sempark/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:28:422043) 	at Module.require (module.js:498:17) 	at require (internal/module.js:20:19) 	at bindings (/Users/sempark/mbed/vscode_extension_mbed/node_modules/bindings/bindings.js:81:44)
Steps and Code to Reproduce the Issue
$CXX=clang npm i serialport
then run. that's all

Are you sure you are not using Electron at runtime as it appears to be the case. The NODE_MODULE_VERSION for Node.js v7.1.0 is 51 (see https://nodejs.org/en/download/releases/). There is node version of Node.js that uses NODE_MODULE_VERSION 54. Electron does however appear to use NODE_MODULE_VERSION 54.

I'm going to assume this was an installation/configuration issue and go ahead and close this issue. If it turns out to be an issue with serialport the issue can of course be reopened.


tmp fix

fixed tmp dir
completing tmp fix

going to go a different direction with this and do it in smaller parts


Website style fixes

Summary
Whilst browsing the site on mobile, I noticed a couple things off center and a pretty high line-height on h2s on the docs which looked a little off. Thought I could patch those couple things real quick. Hope it helps.
Test plan
I looks good in browser to me, but let me know if I can improve.
H2 Before:

H2 After:

Spacing Before:

Spacing After:

Header Before (off center):

Header After:

Good improvements, thanks @jeremybise 👍

Actually never bothered to open the docs on mobile, this definitely looks a lot better! 👌


feat(FX-4535): mark specific notification as read when clicking on an entry in the activity panel

The type of this PR is: Feat

This PR solves FX-4535
Review app: mark-notification-as-read
Demo
https://user-images.githubusercontent.com/3513494/213193037-3bdd51be-1f56-4058-a9d6-64c7c6d3cfe9.mp4

Non-blocking but I think it would be wise to create an upkeep ticket to setup some more robust tests that allow to us exercise some of the tap/click behavior in the activity panel UI

Yes, it's a good idea. I originally planned to add tests, but due to some limitations of how we mock relay env for tests, this could not be done.


test

22

Advertisement :)

pica - high quality and fast image
resize in browser.
babelfish - developer friendly
i18n with plurals support and easy syntax.

You will like those projects!

h1 Heading 8-)
h2 Heading
h3 Heading
h4 Heading
h5 Heading
h6 Heading
Horizontal Rules

Typographic replacements
Enable typographer option to see result.
(c) (C) (r) (R) (tm) (TM) (p) (P) +-
test.. test... test..... test?..... test!....
!!!!!! ???? ,,  -- ---
"Smartypants, double quotes" and 'single quotes'
Emphasis
This is bold text
This is bold text
This is italic text
This is italic text
Strikethrough
Blockquotes

Blockquotes can also be nested...

...by using additional greater-than signs right next to each other...

...or with spaces between arrows.

Lists
Unordered

Create a list by starting a line with +, -, or *
Sub-lists are made by indenting 2 spaces:

Marker character change forces new list start:

Ac tristique libero volutpat at

Facilisis in pretium nisl aliquet

Nulla volutpat aliquam velit

Very easy!

Ordered

Lorem ipsum dolor sit amet

Consectetur adipiscing elit

Integer molestie lorem at massa

You can use sequential numbers...

...or keep all the numbers as 1.

Start numbering with offset:

foo
bar

Code
Inline code
Indented code
// Some comments
line 1 of code
line 2 of code
line 3 of code

Block code "fences"
Sample text here...

Syntax highlighting
var foo = function (bar) {
  return bar++;
};

console.log(foo(5));

Tables

Option
Description

data
path to data files to supply the data that will be passed into templates.

engine
engine to be used for processing templates. Handlebars is the default.

ext
extension to be used for dest files.

Right aligned columns

Option
Description

data
path to data files to supply the data that will be passed into templates.

engine
engine to be used for processing templates. Handlebars is the default.

ext
extension to be used for dest files.

Links
link text
link with title
Autoconverted link https://github.com/nodeca/pica (enable linkify to see)
Images

Like links, Images also have a footnote style syntax

With a reference later in the document defining the URL location:
Plugins
The killer feature of markdown-it is very effective support of
syntax plugins.
Emojies

Classic markup: :wink: :crush: :cry: :tear: :laughing: :yum:
Shortcuts (emoticons): :-) :-( 8-) ;)

see how to change output with twemoji.
Subscript / Superscript

19^th^
H~2~O

<ins>
++Inserted text++
<mark>
==Marked text==
Footnotes
Footnote 1 link[^first].
Footnote 2 link[^second].
Inline footnote^[Text of inline footnote] definition.
Duplicated footnote reference[^second].
[^first]: Footnote can have markup
and multiple paragraphs.

[^second]: Footnote text.
Definition lists
Term 1
:   Definition 1
with lazy continuation.
Term 2 with inline markup
:   Definition 2
    { some code, part of Definition 2 }

Third paragraph of definition 2.

Compact style:
Term 1
~ Definition 1
Term 2
~ Definition 2a
~ Definition 2b
Abbreviations
This is HTML abbreviation example.
It converts "HTML", but keep intact partial entries like "xxxHTMLyyy" and so on.
*[HTML]: Hyper Text Markup Language
Custom containers
::: warning
here be dragons
:::


add config to no generate "onCreate" method

The general way I use is that do ButterKnife.bind(this); in BaseActivity, no need generate OnCreate method todo it.

@laomo
Maybe you can try this. If it helps you, please give me a star.
https://github.com/avast/android-butterknife-zelezny/issues/164


Mod is on nexus and accepting donation

Just wanted to be extra sure you were ok or knew that your fix is up on Nexus and the person seems to be using yourt pictures as his icon !
also ppl are donating to him.
found it strange that the picture of your avatar is lowres.
I just hope it's you or you are aware of it !

I appreciate the concern, that's me though! You can see it's the same username I use on Patreon. I've started uploading stuff on Nexus Mods so that I can make sure they're kept up to date.

I appreciate the concern, that's me though! You can see it's the same username I use on Patreon. I've started uploading stuff on Nexus Mods so that I can make sure they're kept up to date.

OH !!! ok ! 😅
I got a little overzealous thinking someone took your Mod for for granted and thrived on the responses like a lot of your other Mods uploaded on Nexus.
My bad !

No worries, I'll close this issue now.


Aptos address might be invalid if there is a leading 0

Reported from community, it was introduced in pr https://github.com/trustwallet/wallet-core/pull/3497 and the test was ignored

I confirmed by checking Petra and Pontem

We should make sure the address length is correct too.

Not an issue, confirmed with aptos team


Add python client

#4 will make this 1000x easier.

should that be a dependency? i'd be interested in working on this one but don't want to do throwaway code if you're planning new transport.

By that, I think you mean #4. I absolutely believe it should be a dependency--it will be quite easy to write the gRPC based API (should take a day or two, max), since it autogenerates half of the code we must write manually.
Before hacking on code, we should write up a design document. We can make a folder called design_docs with 2 subfolders, pending and implemented. That's where we can work out how these clients will work.
Some of the open questions for the python client, off the top of my head:

All our APIs can be async, which means that while the request is in-flight, the user application could do other things. In python, should the API expose this? If so, is there an async standard we should follow? (yield, twisted, threads, something else?).
We need to come up with a SQLlite schema for storing data. How should we store the data? Can we have turn-key SQL queries that are easy to use from Java and Python? Can we leverage the sqlite FTS5 engine to provide better search capabilities for jobs?

You can also take a stab at thinking about the gRPC schemas themselves. We'll need Job, URI, and Instance protobufs. We'll need a few rpcs: submit (same as POST), delete (same as DELETE), query (same as GET), and subscribe (like query, but returns a stream of instance updates, so that after the initial burst, further updates come incrementally).
The bigger question is how to prioritize the milestones: Fenzo gives us faster task scheduling and constraint-aware placement for hybrid cloud and varying machine classes. gRPC gives us a command line tool suite and simplified integration. Spark improvements will make productionalizing Spark jobs easier. They're all great, which should we do?

Async is landing in the language in 3.5 https://www.python.org/dev/peps/pep-0492/
Right now I think the simplest way is to return a Future and yield on it to wait.  Motor (the async python driver for mongodb) does this in addition to a callback api: https://motor.readthedocs.org/en/stable/tutorial.html#using-motor-with-gen-coroutine
In my limited experience, twisted is not fun.

Hm, I'm not sure, does this issue mean that pyspark doesn't work with Cook? Or this issue is entirely about non-spark workloads?

This is about non-spark workloads--specifically, a native API for
interacting with the cook preemptive scheduler from Python.
On Wed, Oct 21, 2015 at 2:52 PM Paul Colomiets<EMAIL_ADDRESS>wrote:

Hm, I'm not sure, does this issue mean that pyspark doesn't work with
Cook? Or this issue is entirely about non-spark workloads?
—
Reply to this email directly or view it on GitHub
https://github.com/twosigma/Cook/issues/5#issuecomment-149992192.

grpc doesn't support python 3 yet, this ticket has been open for over a year.  I'm going to take a stab at an asyncio/aiohttp based library targeting the existing rest api.

Cleaning up old issues. This python client is no longer on our roadmap. Closing.


Update local cli executor to use same filename strategy as docker

Replaces #1954

Why are these changes needed?

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

@sonichi can you run oai tests?


webhook-certs data is not created

Expected Behavior
all pods including webhook pod should be running.
Actual Behavior
webhook pod can't run due to server key missing
2020/08/23 16:23:22 http: TLS handshake error from <IP_ADDRESS>:59268: server key missing
...

This could be due to webhook-certs data is not getting updated as it should be.
apiVersion: v1
kind: Secret
metadata:
  name: webhook-certs
  namespace: knative-serving
  labels:
    serving.knative.dev/release: "v0.17.0"
# The data is populated at install time.

Steps to Reproduce the Problem
apply knative-serving core from version 0.17.0
KNATIVE_VERSION=v0.17.0
curl -L https://github.com/knative/serving/releases/download/${KNATIVE_VERSION}/serving-crds.yaml > kubectl/01-knative-serving-crds.yaml
curl -L https://github.com/knative/serving/releases/download/${KNATIVE_VERSION}/serving-core.yaml > kubectl/02-knative-serving-core.yaml

Additional Info
WebhookCertificates said Reconcile succeeded but webhook-cert is not updated with cert data.

{"level":"info","ts":"2020-08-23T16:23:21.643Z","logger":"webhook","caller":"leaderelection/context.go:134","msg":"webhook.webhookcertificates.00-of-01 will run in leader-elected mode with id \"webhook-85758f4589-kcn59_f14e6f6e-e220-42d6-95bd-f0789bdd8092\"","commit":"427b2bf"}
{"level":"info","ts":"2020-08-23T16:23:21.643Z","logger":"webhook.WebhookCertificates","caller":"controller/controller.go:444","msg":"Starting controller and workers","commit":"427b2bf"}
{"level":"info","ts":"2020-08-23T16:23:21.643Z","logger":"webhook.WebhookCertificates","caller":"controller/controller.go:454","msg":"Started workers","commit":"427b2bf"}
{"level":"info","ts":"2020-08-23T16:23:21.643Z","logger":"webhook.WebhookCertificates","caller":"controller/controller.go:520","msg":"Reconcile succeeded. Time taken: 4.718µs","commit":"427b2bf","knative.dev/traceid":"31c4416c-2ff7-4a54-bfe7-e9d5756c5f1f","knative.dev/key":"knative-serving/webhook-certs"}

I confirm the above issue is fixed when I add  --disable-ha
       containers:
       - args:
         - --disable-ha

A complete reproducer using kafka channel webhook https://github.com/knative/eventing-contrib/issues/1554#issuecomment-692342180

@pmorie any idea how ha is impacting on webhook certs?

/assign @mattmoor

Judging from the linked eventing issue, I think this is a bad interaction with the liveness probe.
This was recently changed in Serving to double the number of liveness probes needed to fail before restarting the process, but a periodSeconds: 1 and defaults means the container has 3s to be up and functionally serving HTTPS, which is probably not very realistic.
Here's the kafka-channel config: https://github.com/knative/eventing-contrib/blob/096b0925bf501a42db28b760152b302b80dccd11/kafka/channel/config/deployments/webhook.yaml#L69
Here's the (new) serving config (6 attempts): https://github.com/knative/serving/blob/64a83f80930bd85a50fabac28bfa1b662d978b4a/config/core/deployments/webhook.yaml#L105
I still think 6s is probably a bit low for initial installation flow, which requires the pod to boot up, sync informers, become leader, promote the bucket (resync TLS key), get back the TLS key via informer watch, and serve a successful liveness probe.
One other note on why 3 (and even 6) feels low:  The default leader election retry period is 2s.
I sort of think that we want initialDelaySeconds: 10 or so on the liveness probes as well.
cc @julz @markusthoemmes @tcnghia

/reopen


Install instructions point to wrong package

in README your install instructions are
#### NPM

    npm install stage-js --save

#### Bower

    bower install stage-js --save

I think you meant to have planck-jsinstead of stage-js

@veswill3 Thank you! Fixed it.


Setting right options of command based new connections

Previously, right options for command-based connections were not set. Now, I am making the connection type as default so that the connection can be saved in OE.
Issue: #23833

Can you also check group: undefined for dashboard connection when created directly with new connection?
The OE connection now works and clicking Manage does open the dashboard tab with default group id populated - but it seems to be missing when its launched from here.


[Docs] Clarify expected interface for running distutils.commands

Summary
I am the maintainer of py2exe and I am in the process of migrating it from distutils to setuptools. While reading the new documentation, I found out this extremely useful page that carefully explains how to add a new command and even new keywords for the setup() method, effectively mimicking what has been possible up to now with distutils. If this API is supposed to be actively supported in the future, changes on py2exe would most likely be relatively minimal.
However, at the end of the very same page, under Final Remarks there is this sentence:

Directly calling python setup.py ... is considered a deprecated practice. You should not add new commands to setuptools expecting them to be run via this interface.

which seems to contradict the point of the whole page. I think I am missing something here: what is then the expected way to run a distutils.commands entry point? Do you plan to discontinue the python setup.py ... command interface?
Thanks for this clarification and for maintaining setuptools.
OS / Environment
No response
Additional Information
The linked page should clarify what is the command line interface that should be used to run commands added to setuptools via the supported distutils.commands entry point.
Code of Conduct

[X] I agree to follow the PSF Code of Conduct

Hi @albertosottile thank you very much for opening this discussion.

I think I am missing something here: what is then the expected way to run a distutils.commands entry point?

Command objects are useful in different contexts, not only when called via the CLI. Two major examples here would be when an user wants to add a custom build step (e.g. transpiling typescript files into javascript files to be embedded in a wheel for distribution) or when a plugin wants to overwrite one of the default build steps (e.g. build_py, build_ext).

Do you plan to discontinue the python setup.py ... command interface?

I believe that this is the long term plan. I joined the project as a maintainer after this decision was made, but so far there are many items in the changelog point to this direction. One of the setuptools maintainers has created this article explaining the situation.
The tendency is that setup.py will be reserved as an internal implementation detail for setuptools own use, instead of being exposed as a public interface.

The linked page should clarify what is the command line interface that should be used to run commands added to setuptools via the supported distutils.commands entry point.

As far as I am aware, the is no plan to support a command line interface to run custom commands.

I am really sorry @ronaldoussoren I don't have that information for you.
I joined the team after setuptools started giving indications that it wanted to go in this direction, so there are many things I don't know yet...

@abravalheri Sorry if I keep asking about this, but I am still trying to find the best/suggested approach for changing this in py2exe.

Command objects are useful in different contexts, not only when called via the CLI. Two major examples here would be when an user wants to add a custom build step (e.g. transpiling typescript files into javascript files to be embedded in a wheel for distribution)

Suppose that, in this scenario, the user wants to run just the transpiling step, without building the full wheel. How is the user supposed to do that? What would be the preferred way to create/expose a CLI for running this transpiling step (internally implemented as a setuptools command)?

Suppose that, in this scenario, the user wants to run just the transpiling step, without building the full wheel. How is the user supposed to do that? What would be the preferred way to create/expose a CLI for running this transpiling step (internally implemented as a setuptools command)?

I believe that the direction setuptools has chosen to follow (even before I joined as a maintainer) is to use standardized workflows (e.g. the one described in PEP 517) and deprecate exposing CLI capabilities. This definitely limits what can be done (not everything will work, e.g. it is a clear intention of the project that users don't run the install "build step").
Therefore, we can infer that this goal would have to be achieved via Python APIs instead of running python setup.py in a sub-processes.
The safest way of doing that is to create a third-party CLI tool that calls the build hooks in setuptools.build_meta as specified in PEP 517, if possible. This set of APIs is definitely the most stable interface setuptools offers since they are closely tied to the PyPA specs.
Projects like enscons, also use the Command(dist_obj).run API. Note however that (despite not currently planned) setuptools eventually may introduce API changes in future major versions (e.g. add a deprecation warning, changes in arguments, etc...). This is a natural part of the life cycle of software (it is impossible to foresee the future), so standard practices to protect against dependency changes are applicable depending on how conservative/reactive you want the project to be (e.g. adding strategic major version caps that are bumped after testing recently published versions).

The original title of this issue is [Docs] Clarify expected interface for running distutils.commands. My understanding is that setuptools effectively deprecated built-in user-facing mechanisms of doing so, therefore I am not sure if there is something to be documented here. Currently there is an entry in the "deprecated practice" docs with a warning section specifically alerting for this deprecation: https://setuptools.pypa.io/en/latest/deprecated/commands.html#upload-upload-source-and-or-egg-distributions-to-pypi.
Alternatively, we could interpret the issue as a request to add documentation about lower-level setuptools Python APIs (such as the aforementioned Command(dist_obj).run). Would that be the case?
If so, this issue might be a duplicate of https://github.com/pypa/setuptools/issues/3401 since it specifically mentions API Reference, and related to https://github.com/pypa/setuptools/issues/2387. A dependency to proceed with that issue is to build consensus and clarify which parts of the low level API are intended and which parts of the API are accidental.

setuptools effectively deprecated built-in user-facing mechanisms of doing so

Could you specify who user is in this sentence?
IMO, it’s fine for the developers of the project to use commands specific to their build tools, like python setup.py build_js, even if people who want to use the project should not use setup.py directly.  Otherwise there’s a lot of work needed for setuptools to offer another command API, and the benefits of that are dubious.

Hi @merwok, the best reference that we have so far is linked post. I can highlight the following parts:

all direct invocations of setup.py are effectively deprecated in favor of invocations via purpose-built and/or standards-based CLI tools like pip, build and tox.

The setuptools project no longer wants to provide any public CLI, and will be actively removing the existing interface (though the time scale for this is long).

So presumably this applies to every single invocation of python setup.py that is outside of the setuptools code base (and users refers to anyone including developers).

The original title of this issue is [Docs] Clarify expected interface for running distutils.commands. My understanding is that setuptools effectively deprecated built-in user-facing mechanisms of doing so, therefore I am not sure if there is something to be documented here.

IMHO, because the documentation invests a lot of effort in explaining how to extend setuptools commands, it should also specify what is the "supported/recommended" way in which these commands should be executed. I would be in favor of any addition to the documentation based on either this approach

The safest way of doing that is to create a third-party CLI tool that calls the build hooks in setuptools.build_meta as specified in PEP 517, if possible.

or this approach

Projects like enscons, also use the Command(dist_obj).run

or even something else entirely.
The goal would be that maintainers of other projects that currently depend on the setup.py CLI know exactly where they should go when departing from distutils.

FYI: There's a blog about the deprecation here: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html


[Query] Error in create subscription

Hi @michalvasko,
We see an error in create subscription. Can you please help to understand the root cause for the error.
1970-01-02 00:02:29.800194 ORU3668_MAIN info netopeer2-server[1127]: EV ORIGIN: "/notifications:create-subscription" "rpc" ID 3 priority 5 for 1 subscribers published.
1970-01-02 00:02:29.803551 ORU3668_MAIN info netopeer2-server[1127]: EV ORIGIN: "/notifications:create-subscription" "rpc" ID 3 priority 5 succeeded.
1970-01-02 00:02:29.803851 ORU3668_MAIN info netopeer2-server[1127]: EV ORIGIN: "/notifications:create-subscription" "rpc" ID 3 priority 0 for 1 subscribers published.
1970-01-02 00:02:29.804399 ORU3668_MAIN info netopeer2-server[1127]: EV LISTEN: "/notifications:create-subscription" "rpc" ID 3 priority 0 processing (remaining 1 subscribers).
1970-01-02 00:02:30.201155 ORU3668_MAIN info netopeer2-server[1127]: EV ORIGIN: "ietf-netconf-notifications" "notif" ID 9 priority 0 for 1 subscribers published.
2023-11-09 07:40:43.915386 ORU3668_MAIN err netopeer2-server[1127]: Waiting on a conditional variable failed (sr_shmext_notif_sub_add: Connection timed out).
2023-11-09 07:40:43.915439 ORU3668_MAIN err netopeer2-server[1127]: EV ORIGIN: "notif" ID 9 processing timed out.
2023-11-09 07:40:43.915581 ORU3668_MAIN info netopeer2-server[1127]: Generated new event (netconf-session-end).
2023-11-09 07:40:43.915617 ORU3668_MAIN info netopeer2-server[1127]: EV LISTEN: "/notifications:create-subscription" "rpc" ID 3 priority 0 fail (remaining 1 subscribers).
Thanks!

What netopeer2-server version are you using?

What netopeer2-server version are you using?

Hi @michalvasko
Sorry for late reply. I somehow missed your response.
We are using the netopeer2 version 2.1.59

Then please use the latest release, there were lots of concurrency improvements that should get rid of errors like this.

Then please use the latest release, there were lots of concurrency improvements that should get rid of errors like this.

Sure, we are already in process of upgrading to latest released version. Will check with that if it works.


Known Issue building Documentation with Doxygen 1.8.16

What issue(memory leak, slow renders, docs fix etc.) did you face?
It is a documentation build issue, shouldn't effect any users.
The issue happens with doxygen 1.8.16

The issues seems to have been gone with doxygen 1.8.17 release. However, some styles corruption issues seem to linger. Not yet sure if they if doxygen is root cause of that.

Resolved in 27abb19a6b47d9a08218ff210df568a2f428fe95


Print enabled Kokkos devices during configuration

It is helpful to know what devices are enabled when building ArborX without having to go to CMakeCache.txt.

So it prints
-- Kokkos devices: Serial,OpenMP

It does not say anything about enabled memory spaces. Do we want that?

@aprokop I would rather address this through something like kokkos/Kokkos#2508


perf(clustering) improve calculate hash performance by utilizing string buffer and tablepool

Summary
Improve calculate hash performance by utilizing string buffer and tablepool.

A small improvement (so far):
-rw-r--r--  1 bungle staff 395M Dec 15  2021 kong.json
reading file done in 0.16999983787537 secs
decoding json...
decoding json done in 2.0450000762939 secs
calculating hash...
c5c725a9b2776f947c198379a54a65d6
calculating hash done in 2.8819999694824 secs
calculating hash new...
57bfa7fc4fa1ec577f3b0a464dd6e96a
calculating hash done in 2.2009999752045 secs```

Small test:
Inserted 200000 routes in 5 seconds
Inserted 200000 consumers in 4 seconds
Inserted 200000 upstreams in 4 seconds
Inserted 200000 targets in 5 seconds
Inserted 200000 plugins in 5 seconds
Inserted 200000 services in 4 seconds
Inserted 200000 upstreams in 4 seconds```

```2022/07/08 16:50:09 [error] 99950#0: *7 [lua] wrpc_control_plane.lua:111: took 18718 ms to export config, context: ngx.timer```

```2022/07/08 16:50:19 [error] 99950#0: *7 [lua] wrpc_control_plane.lua:125: took 10302 ms to calculate hash, context: ngx.timer```


[cherry-pick]  Fix! Linseed controller needs get and create for secrets

Description
Cherry-pick https://github.com/tigera/operator/pull/2605
For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

@asincu @Brian-McM let's revert this commit please, these permissions are already present: https://github.com/tigera/operator/blob/658facf45b18ee00e1e72e7cc445887bfb731324/pkg/render/logstorage.go#L470-L486


After a service upgrade, external LB IP goes through multiple retries before being accessible

Rancher Version:1.0.1
Docker Version:1.11.0
Steps to Reproduce:

Configure an external LB
Add a service with two containers, ports, label associated with the external LB
Upgrade the service without any changes

Results:
The external LB IP goes through multiple retries before being accessible.
Please see below:
soumyas-MacBook-Pro:~ soumya$ wget http://<IP_ADDRESS>/name.html
--2016-04-25 14:52:29--  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.
--2016-04-25 14:52:30--  (try: 2)  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.
--2016-04-25 14:52:32--  (try: 3)  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.
--2016-04-25 14:52:35--  (try: 4)  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.
--2016-04-25 14:52:39--  (try: 5)  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.
--2016-04-25 14:52:44--  (try: 6)  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.
--2016-04-25 14:52:50--  (try: 7)  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.
--2016-04-25 14:52:57--  (try: 8)  http://<IP_ADDRESS>/name.html
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 13 [text/html]
Saving to: 'name.html.3'
name.html.3                         100%[===================================================================>]      13  --.-KB/s    in 0s
2016-04-25 14:52:57 (747 KB/s) - 'name.html.3' saved [13/13]
Expected:
The external LB IP should be readily accessible after a service upgrade

One more case:
Upgrade a service. Before finishing or rolling back, two new containers are created and the older ones are stopped. Even in this case, the external LB IP goes through multiple retries before being accessible.

As far as I can tell I am experiencing the same issue.
Tried Rancher v1.0.0, v1.0.1 and 1.1.0-dev2-rc3, Docker v1.11.1.
Is this a regression? I'm pretty sure I tried this with v0.63.1 and it didn't work either.
Also, I am not sure if it is a case of setting up the health check parameters correctly, so that the LB knows when an instance is up or being shutdown.

Closing due to inactivity, please reopen if you think this is still relevant to current releases & important. I'm not sure what else we can do with this issue.  Isn't the LB just waiting until the container can respond?


It is possible to launch multiple copies of Decentraland

Build version:
0.44
Issue Description:
Decentraland launcher does not check if Decentraland is already running and launchers an extra copy.
STR:

Run Decentraland
Run Decentraland

❌ Actual Result:
Two copies of Decentraland running.
✔ Expected Result:
One copy of Decentraland running.
Repro Index:
10/10
Evidence:

Additional Notes:
Windows 11

It should be possible to disable the single instance restriction with a command line argument, but the default should be one instance only.


Error - WS_ERROR_UNDERLYING_IO_ERROR

I got the following error from the speechRecognizer.Canceled event a few times yesterday and am not sure what caused it:
ConnectionFailure WebSocket operation failed. Internal error: 3. Error details: WS_ERROR_UNDERLYING_IO_ERROR
Trying to resume the recognition using StartContinuousRecognitionAsync then returned the following error:
SPXERR_START_RECOGNIZING_INVALID_STATE_TRANSITION
Are you able to see what caused the error? I don't have a log file, but below are the session IDs incase you can see anything in the service logs:
4dda6759092a4bf4b04ce4ba0840538c
df82d2eb497646bbbb8504fcdf1da9c7

Any update on this issue please? I got the same error again yesterday, session IDs:
c7ae6a2bd07640c699dd1a160bb7eef1
6ae5bd31d498418f9cce24e06464b590

Same problem.
[ERR][TPFive.Extended.AzureSpeech.AzureSpeechServiceProvider] "SynthesisCanceledHandler" SYNTHESIS CANCELED: ErrorCode="BadRequest" ErrorDetails="Connection was closed by the remote host. Error code: 1007. Error details: Invalid deploymentId 64fe1e87-48f0-4337-a7ed-006f1bfc13de USP state: TurnStarted. Received audio size: 0 bytes."

Once a recognizer cancels recognition, the internal state machine often can't be reset, leading to state transition errors.
IO connection errors are client side, and typically need a client log do diagnose. Also, as the base network layer is different for each OS, knowing that would also help.

Thanks, it was from an Azure Windows VM.


[Drawer] Create the unstyled component and hook

This is the place to gather ideas, measure interest and discuss the API and implementation details of the drawer component and hook.
See mui/base-ui#10 for the umbrella issue to track progress on Base UI and mui/material-ui#6218 for the problem this project solves.

Can you add something that is simliar to this


Improve component exports

Improve component exports

Refactor and change CardBlock to Card.Block
Update documentation + tests for Card.Block
Export Scrollable, Portal, PortalWrapper, and RouteWrapper

Coverage remained the same at 100.0% when pulling f53ba5d24598a4eb8835a00963706b961833df3f on improve-component-exports into 7753b8da9e18432dc807795bbe87b16142b5d515 on master.


Add the init and destroy method in the XATransactionManger

Fixes https://github.com/sharding-sphere/sharding-sphere/issues/1357

Pull Request Test Coverage Report for Build 5401

25 of 28 (89.29%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.02%) to 63.41%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-transaction/src/main/java/io/shardingsphere/transaction/manager/xa/atomikos/AtomikosTransactionManager.java
2
3
66.67%

sharding-transaction/src/main/java/io/shardingsphere/transaction/manager/xa/AbstractXATransactionManager.java
23
25
92.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-reg/src/main/java/io/shardingsphere/orchestration/reg/newzk/client/zookeeper/base/Holder.java
1
73.77%

sharding-transaction/src/main/java/io/shardingsphere/transaction/manager/xa/atomikos/AtomikosTransactionManager.java
1
94.29%

Totals

Change from base Build 5316:
0.02%

Covered Lines:
8093

Relevant Lines:
12763

💛  - Coveralls

@terrymanu please merge this PR to dev-3.1.0


support config host name and proxy address. and fix a docker bug

as describe in #25
remerge of #19
related issue #15
Changes:
fix: add proxy to bingai too
Add more information in env.example.
Give current host address when HOST=<IP_ADDRESS>
fix: use quotes outside of key=value in docker-compose.yml
fix: set HOST=<IP_ADDRESS> by default in api's dockerfile
update readme, add proxy and host information

I've tested this and looks like it's good to go. I had some issues when changing PORT env variable, as nginx.conf would need to change to match it, but I can just make note of this for whoever needs that

Aha I just noticed there is a nginx.conf .
I used to write a script to generate this conf, (just a sh file with lots of echo xxx). so it can change by the env PORT


kube-apiserver is too spammy and I can not exclude it

On one of my clusters, kube-apiserver generates a lot of messages (more than 400 MB/day).
Unfortunately, it seems that I can not use EXCLUDE_* to filter Kubernetes components collected here.
Maybe we can filter severity I messages as suggested to me by @fikander, but a mechanism similar to the EXCLUDE ones would be more general.
P.S. This is not related to: https://github.com/SumoLogic/fluentd-kubernetes-sumologic/issues/13

@mfornasa :There are multiple ways to filter the data.  if you want to do it at the source.kubernetes.conf, you would need to use the fluentd tail plugin option, exclude_path, which I believe does not accespt regex.  You can also use some environment variables to specify a regex pattern to exclude by host, pod, namespace or container.  This is documented in the README in the options section.  Does this not meet your requirement?

@frankreno my understanding is that all the EXCLUDE options operate only on containers that are collected trough source.containers.conf.
The problem here is with a Kubernetes component called kube-apiserver which is explicitly collected trough source.kubernetes.conf (in this line). So, I don't see a way to exclude logs from kube-apiserver using EXCLUDE directives.
This is a generic problem, as kube-apiserver is installed part of Kubernbetes.

@mfornasa : My apologies, I see now.  So we need to expose the environment variables in the  source.kubernetes.conf and that should then give you this capability.  I will look at this as soon as I can.

Any news on this?

@mfornasa: The image with the fix for this is now in docker hub.  Thanks for your help @flah00!

Tried:
   - name: EXCLUDE_PATH
          value: "/mnt/log/kube-apiserver.log"

Seems good. Thanks.


Update 04-public-api.md

Wondering why other exposed functions use lowercase, and Server uses upper. It seems inconsistent. Users receive a TypeError otherwise.

Server is a constructor, and server is legacy code, which we forgot to remove in 1.0. https://github.com/karma-runner/karma/blob/master/lib/index.js#L10


CI improvements

Proposed changes
This PR includes various improvements to the "PR checks" CI pipeline:

Add code coverage measurement on codecov.io

NOTE: to finish setting up coverage, a secret token for thin-edge/thin-edge.io repository may have to be generated on codecov.io and added to the repository secrets in settings. But it might also start working immediately, as we have used codecov previously and the token might already be there.

Add cargo doc check, which checks if API documentation for the workspace can be generated
Expand testing to include all targets, e.g. examples and doc tests
Sped up PR checks a bit by adding cache to jobs, fixing it where it wasnt taking effect, or reducing amount we build unnecessarily, and starting more jobs in parallel

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Codecov Report
Patch coverage: 75.85% and project coverage change: +9.95 :tada:

Comparison is base (720f390) 62.66% compared to head (814302a) 72.62%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
+ Coverage   62.66%   72.62%   +9.95%
==========================================
  Files         115      278     +163
  Lines        7455    30299   +22844
  Branches        0    30299   +30299
==========================================
+ Hits         4672    22004   +17332
- Misses       2783     6750    +3967
- Partials        0     1545    +1545

Impacted Files
Coverage Δ

crates/common/flockfile/src/lib.rs
100.00% <ø> (ø)

crates/common/tedge_config/src/mqtt_config.rs
0.00% <0.00%> (ø)

...s/common/tedge_config/src/system_services/error.rs
0.00% <0.00%> (ø)

...on/tedge_config/src/system_services/manager_ext.rs
0.00% <ø> (ø)

...edge_config/src/tedge_config_cli/config_setting.rs
63.63% <ø> (ø)

...n/tedge_config/src/tedge_config_cli/models/flag.rs
89.58% <ø> (ø)

...n/tedge_config/src/tedge_config_cli/models/port.rs
85.71% <ø> (ø)

...mmon/tedge_config/src/tedge_config_cli/settings.rs
0.00% <0.00%> (ø)

.../tedge_config/src/tedge_config_cli/tedge_config.rs
50.72% <ø> (ø)

...nfig/src/tedge_config_cli/tedge_config_defaults.rs
98.66% <ø> (ø)

... and 118 more

... and 235 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Workflow for chef-server cookbook?

I believe this cookbook is basically meant to help with running and maintaining an omnibus-based Chef Server - and run the underlying cookbook located here: https://github.com/opscode/omnibus-chef-server
That repo doesn't have an Issues set up yet, so I;m uncertain as to where to discuss proposed changes to add/change functionality to that cookbook, since this one seems to only pass along an open-ended Hash of configuration options.

Closing this as we're now using https://github.com/chef/chef-server/issues or https://github.com/chef/opscode-omnibus/issues w/ Chef Server 12.


[BEAM-13909] improve coverage of Provision package

Improve coverage of provision package. Part of effort to improve overall code coverage of Go SDK.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @jrmccluskey @damccorm @youngoli


Run tests on built wheels.

Thanks @jlaine for spotting this.
Fix #683.

Ha! Tests are running and failing now...


intellicode sometimes not working or take a long time

Product and Version [VS/VSCode]: VScode 1.40.0
OS Version [macOS/Windows]: win10 1903
IntelliCode Extension Version: 1.2.0
Target Platform or Language [e.g. Node.js]: Python 3.6.4

Intellicode sometimes not working:
 figure 1

even intellicode can toggle suggest after a long time (approximately 3min at least), intellicode still cannot toggle suggest on python module.

setting.json:
{
    "sync.gist": "xxx",
    "python.jediEnabled": false,
    "[python]": {
        "editor.defaultFormatter": "ms-python.python"
    },
    "workbench.colorTheme": "Monokai Pro",
    "workbench.iconTheme": "Monokai Pro Icons",
    "window.zoomLevel": 0,
    "editor.fontSize": 18,
    "terminal.integrated.inheritEnv": false,
    "extensions.ignoreRecommendations": true,
    "editor.suggestSelection": "first",
    "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
    "python.linting.pylintEnabled": true,
    "python.linting.flake8Enabled": true,
    "python.dataScience.sendSelectionToInteractiveWindow": true,
}

@potoo0 thanks for raising this issue. It seems like you are having general issues with IntelliSense completion in Python in VS Code; IntelliCode is a supplementary feature that provides recommendations (the "stars" that raise the most likely completions to the top of the list). The right place to raise general Python IntelliSense issues when using the new Python language server (which I see from your settings you are doing) is on the Python Language Server repo issues list. They have a troubleshooting guide that can hopefully help you out.
If you see problems with the IntelliCode "stars" once you have IntelliSense working, please do raise a new bug here!
Thanks
Mark

Thanks.


Subclass WGL and move theme code

Subclass vtkWin32OpenGLRenderWindow and move all Windows related code (dark theme) there.

There is a conflict to fix

@mwestphal PTAL again


Add sqlite_stat1(-4) tables to hidden table list

Running ANALYZE creates a new visible table called sqlite_stat1: https://www.sqlite.org/fileformat.html#the_sqlite_stat1_table
This should be added to the default list of hidden tables in Datasette.

Depending on the SQLite version (and compile options) that ran ANALYZE these can be called:

sqlite_stat1
sqlite_stat2
sqlite_stat3
sqlite_stat4

Relevant code: https://github.com/simonw/datasette/blob/00a2895cd2dc42c63846216b36b2dc9f41170129/datasette/database.py#L339-L354


XState + Mobx/Redux

Hi,
I was wondering how this library is intended to work together with other state management tools.
I am not really experience with any of these tools, but from my understanding and your comments in #15, I assume that you could use xState to handle the immutable part of your state, while using another form of state management for the rest of your state.
Based on that I tried to modified the example provided in the Readme and refactored it to use a Mobx Store instead of setState. I would be really interested in your opinion about the general implementation approach and if you like I can add the example to the Readme with some comments.
import React, { Component } from 'react'
import { observer } from 'mobx-react'
import { observable, action, useStrict, runInAction } from 'mobx'
import { Machine } from 'xstate'

useStrict(true)

const ROOT_URL = `https://api.github.com/users`
const myMachine = Machine({
  initial: 'idle',
  states: {
    idle: {
      on: {
        CLICK: 'loading'
      }
    },
    loading: {
      on: {
        RESOLVE: 'data',
        REJECT: 'error'
      }
    },
    data: {
      on: {
        CLICK: 'loading'
      }
    },
    error: {
      on: {
        CLICK: 'loading'
      }
    }
  }
})

class AppState {
  @observable data = {}
  @observable dataState = 'idle'
  @observable input = ''

  commands = {
    loading: this.searchRepositories
  }

  @action
  transition (action) {
    console.log(this.dataState, action)
    const newState = myMachine.transition(this.dataState, action).value
    const command = this.commands[newState]

    this.dataState = newState

    if (command) {
      command.call(this)
    }
  }

  @action
  async searchRepositories (){
    try {
      const data = await fetch(`${ROOT_URL}/${this.input}`).then(response => response.json())
      runInAction(() => {
        this.data = data
        console.log(this.data)
        this.transition('RESOLVE')
      })
    } catch (error) {
      runInAction(() => {
        this.transition('REJECT')
      })
    }
  }

  @action changeText(text) {
    this.input = text
  }
}

const store = new AppState()

@observer
class App extends Component {
  render() {
    const { data, dataState } = store
    const buttonText = {
      idle: 'Fetch Github',
      loading: 'Loading...',
      error: 'Github fail. Retry?',
      data: 'Fetch Again?'
    }[dataState]
    return (

        <input
          type="text"
          value={store.input}
          onChange={e => store.changeText(e.target.value)}
        />
        <button
          onClick={() => store.transition('CLICK')}
          disabled={dataState === 'loading'}
        >
          {buttonText}
        </button>
        {dataState === 'error'?

Error!!!
 :
          data &&
{JSON.stringify(data, null, 2)}
}

    )
  }
}

export default App

Closing this, as XState itself can be used as a state management tool, and with the interpreter emitting updated state, it can be consumed in any state management tool by listening for state changes.

@davidkpiano I have a question about XState and Redux differences. I will write it here but I can move to a new issue or other place if you think does not belong here.
Basically I left the question on stack overflow also but I will quote myself:

I've been using Redux for most of my React applications.
I think I will start using XState as I don't have to use effects as a plugin all the time.
And I think is a more complete pattern.
One thing that I want to understand is it's connection with React (hooks and classes) and it's interaction with reactive programming in general:
Can I (and should I) use XState context as Redux data store in the same way, having a single source of truth on a shared by React Components way? Will my components be able to "connect" and "mapToProps" the XState context and rerender only when those values changes and not every time the state machine state changes?
From what I understand Redux lacking side effects is so it can adhere to a pure functional paradigm. But that breaks with side effects usage, that is a lot of times needed in web apps or games for example.

can't I just make an HOC to do the same as react-redux connect() and map XState's send and parts of the context to React's props?Or there is better way to do this on XState? XState already seems to have a good integration with Redux Dev tools by itself.

Basically I know I can use onTransition to map context changes to react's state. But let's say I want to have clean components (using classes for now) and I want part of the context only, by making an HOC I can fully replace redux, right?
Should I use sub machines for each component state? Actors?
I've been testing and I like it a lot but I want to understand a good, advisable and clean way to integrate with React in a scalable app. And replace redux and side effects libs.
Thanks

@RuiOrey This would be a good conversation for spectrum.chat/statecharts, but in general yes use a machine (like local state) for each component.

Thanks, will question there


Add tutorials like chainer doc

Chainer documentation has Guide and Neural Net Examples that is quite friendly to beginners, with its slower pace, and not as overwhelming as the reference and source code for starter. It'll be quite cool to do the same for Chainer RL as well.

quickstart guide is good (https://github.com/chainer/chainerrl/blob/master/examples/quickstart/quickstart.ipynb). Maybe can fit that shoe, maybe can be moved to the doc site so it's easier to access.

The quickstart guide is already linked from the documents. http://chainerrl.readthedocs.io/en/latest/index.html
I agree it is better to add more tutorials, especially for other algorithms than DQN.

The quickstart guide is already linked from the documents.  Oh there, I missed that, thanks for the link.
Still the tutorial style feels better to me, it's like a story telling, where notebook is more like presenting the code with some comments.


[Question] Why do we have policies & roles in shield?

Not a bug
This is a design question, why do we have policies & roles in Shield? This should be handled by spicedb and Shield can work only as a passthrough for it right? I feel we are trying to re-implement spicedb in Shield. For example, having our own yaml structure to define relations and permissions(resource_config) for spicedb. Which is not only more complicated, it is also restricting users from using spicedb UI to validate/visualize relations by https://play.authzed.com/ tool.

@AkarshSatija @krtkvrm @mabdh @ishanarya0

Looks like it is because Spicedb doesn't provide reflection APIs.


cannot launch live share extension

Issue Type: Bug
After install "live share extension pack", and trying to start a session the following message appear: "command 'liveshare.startFromActivityBar' not found" and the session don't start(in a remote container).
Extension version: 1.0.1123
VS Code version: Code 1.40.0 (86405ea23e3937316009fc27c9361deee66ffbf5, 2019-11-06T18:14:08.920Z)
OS version: Linux x64 5.0.0-32-generic snap
Remote OS version: Linux x64 5.0.0-32-generic

Hey @dexterBEN , looks like the extension failed to activate, which is likely a dependency issue. You could try looking in the developer tools window for additional diagnostics - Help -> Toggle Developer Tools. You can also find more documentation about setting up Live Share on Linux here. Let me know how that goes.


Correctly normalize package names. Fixes #2956 and #3002

Fixes #2956 and #3002

@techalchemy I don't know much about this aspect of pip. Note that @uranusjr just opened this PR which touches this very code: https://github.com/pypa/pip/pull/5875
Does that PR address the issue being raised here?

We don't even communicate that well when we are co-maintainers of the same projects
I don't think that one will fix this issue, but it is another case where this code is in disagreement to be sure

Yeah, I figured that might have been happening so wanted to be sure you were at least alerted here!

@uranusjr nope, as far as I understand we don't need that change for this to work

closing for now since we will catch this upstream in the next release of pip, thanks for the PR and thanks for the input all


Codespace zany engine wjwx9gvp799354xg

👷 Deploy Preview for fascinating-daffodil-881e02 processing.

Name
Link

🔨 Latest commit
b4f78bb96e602037c530dd0591ae18c1cde38411

🔍 Latest deploy log
https://app.netlify.com/sites/fascinating-daffodil-881e02/deploys/6533f782a585a100084409fe


Add dependency locking

The current setup with a single requirements.txt files do not provide version for dependencies. This works in the short term, but in the longer term when things stop working it would be really complicated to know what version of each dependency we were using.
The best practice should be to commit a lock file under version control, such as a pipenv.lock. However, we could also take the opportunities to move to poetry, which is more popular (25 k stars vs 4.7k stars compared to hatch), and a better support from tools in the ecosystem (mypy, flake8, etC)

This sgtm.
Tagging @nqn for any thoughts.

@edmondop With your poetry update, this should be fixed right?

That's correct. There is a poetry.lock under version control .
If you check the pyproject.toml, for example, the declared version for langchain is here https://github.com/log10-io/log10/blob/main/pyproject.toml#L31 and says: "anything including or above  0.0.242"
but the last time I performed an install and locked the dependencies, exactly 0.0.242 was installed (there was probably any newer). The poetry.lock is under version control, and shows this piece of information:
https://github.com/log10-io/log10/blob/main/poetry.lock#L994C1-L1004C2
So, whe you do a poetry install, the versions of the libraries are taken from the poetry.lock and not the pyproject.toml to ensure reproducibility over time, but you can update versions locally for development poetry install --upgrade I think


DDC dsend crashes for generic methods with metadata

Test runs as expected with dartdevc.
I was anticipating a dynamic/Object mismatch but not a crash.
If I comment out the o.memberFn calls, the o.map calls fail in a different way.
Runtime error:
TypeError: Cannot read property 'length' of undefined
at Object.dart._checkApply (http://<IP_ADDRESS>:34193/root_build/gen/utils/dartdevc/js/amd/dart_sdk.js:4812:36)
    at Object.dart._checkAndCall (http://<IP_ADDRESS>:34193/root_build/gen/utils/dartdevc/js/amd/dart_sdk.js:4916:14)
    at Object.dart.callMethod (http://<IP_ADDRESS>:34193/root_build/gen/utils/dartdevc/js/amd/dart_sdk.js:4981:17)
    at Object.dart.dsend (http://<IP_ADDRESS>:34193/root_build/gen/utils/dartdevc/js/amd/dart_sdk.js:4984:17)
    at function_call_generic_test.main (http://<IP_ADDRESS>:34193/root_dart/out/ReleaseX64/generated_compilations/dartdevk-checked-strong-sdk/tests_language_2_function_call_generic_test/function_call_generic_test.js:81:120)

exit code:
0

--- Re-run this test:
python tools/test.py -m release -c dartdevk -r chrome --checked --strong --use-sdk language_2/function_call_generic_test

The cause is the emit-metadata flag (which for some reason, is incorrectly defaulting to true in DDK) ... it's failing because of the @NoInline() annotation which is kept around in the signature data for dart:mirrors support. Dynamic call helper for generic methods in DDC doesn't expect to find metadata there. Should be an easy fix.

https://dart-review.googlesource.com/c/sdk/+/51040


Cannot  add a user that  is isolated from other users completely

I had several users to share the azkaban , so I gave a user READ,WRITE,EXECUTE,CREATEPROJECTS,SECHUDEL permission, but this user could still run flows that belong to another user,  upload files to another user's project, almost everything except delete another user's project.
That's not what I want. What I want is different user isolated from each user, can't see projects that belongs to another user. of couse, user with ADMIN permission can see everything from all users. can I do that?

METRICS does the trick


AIRFLOW__CORE__XCOM_BACKEND can't find modules

What is the bug?
I tried to set AIRFLOW__CORE__XCOM_BACKEND with my custom xcom backend, plugins.xcom_backend.S3XComBackend but when I upgraded helm release, it couldn't find out the modules(workers keep dying)
So I set PYTHONPATH so that it could find plugins module but it still couldn't find out the module either.
It looks like loading plugins.xcom_backend.S3XComBackend had been executed before PYTHONPATH was defined.
The directory structure in the cluster (tree /opt/airflow/dags/repo):
|- README.md
|- requirements.txt
|- tests
|- dags
|- plugins
    |- xcom_backend.py

How can I handle this problem?
What version of the chart are you using?:
I am using version 8.1.3
What is your Kubernetes Version?:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.12-eks-7684af", GitCommit:"7684af4ac41370dd109ac13817023cb8063e3d45", GitTreeState:"clean", BuildDate:"2020-10-20T22:57:40Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

What is your Helm version?:
$ helm version
version.BuildInfo{Version:"v3.6.0", GitCommit:"7f2df6467771a75f5646b7f12afb408590ed1755", GitTreeState:"dirty", GoVersion:"go1.16.4"}

Please copy your custom Helm values file:
airflow:
  extraEnv:
    - name: PYTHONPATH
      value: "/opt/airflow/dags/repo"

  config:
    AIRFLOW__CORE__XCOM_BACKEND: "plugins.xcom_backend.S3XComBackend"

@rightx2 can you post logs from the workers which die?

@thesuperzapper
 ➜ kubectl logs -p airflow-worker-0 -c check-db
[2021-06-30 05:36:06,520] {configuration.py:459} ERROR - No module named 'plugins'
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/configuration.py", line 457, in getimport
    return import_string(full_qualified_path)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/utils/module_loading.py", line 32, in import_string
    module = import_module(module_path)
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'plugins'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/airflow/.local/bin/airflow", line 8, in <module>
    sys.exit(main())
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/__main__.py", line 40, in main
    args.func(args)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/cli/cli_parser.py", line 47, in command
    func = import_string(import_path)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/utils/module_loading.py", line 32, in import_string
    module = import_module(module_path)
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/cli/commands/db_command.py", line 24, in <module>
    from airflow.utils import cli as cli_utils, db
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/utils/db.py", line 26, in <module>
    from airflow.jobs.base_job import BaseJob  # noqa: F401 # pylint: disable=unused-import
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/jobs/__init__.py", line 19, in <module>
    import airflow.jobs.backfill_job  # noqa
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/jobs/backfill_job.py", line 29, in <module>
    from airflow import models
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/__init__.py", line 20, in <module>
    from airflow.models.baseoperator import BaseOperator, BaseOperatorLink
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/baseoperator.py", line 55, in <module>
    from airflow.models.taskinstance import Context, TaskInstance, clear_task_instances
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/taskinstance.py", line 58, in <module>
    from airflow.models.xcom import XCOM_RETURN_KEY, XCom
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/xcom.py", line 289, in <module>
    XCom = resolve_xcom_backend()
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/xcom.py", line 279, in resolve_xcom_backend
    clazz = conf.getimport("core", "xcom_backend", fallback=f"airflow.models.xcom.{BaseXCom.__name__}")
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/configuration.py", line 460, in getimport
    raise AirflowConfigException(
airflow.exceptions.AirflowConfigException: The object could not be loaded. Please check "xcom_backend" key in "core" section. Current value: "plugins.xcom_backend.S3XComBackend".

@rightx2 have you got an__init__.py file in your plugins folder?

@thesuperzapper Yes, of course. Moreover, I checked that PYTHONPATH is set properly when I didn't set AIRFLOW__CORE__XCOM_BACKEND: "plugins.xcom_backend.S3XComBackend". I think that airflow configuration setting runs first before PYTHONPATH is declared.....

@rightx2 this is a fun issue, thanks for raising it, I might not have noticed.
I believe the issue is caused by volumes not being mounted on init-containers, and have raised an issue to track that: https://github.com/airflow-helm/charts/issues/253
I am currently working on a PR to fix this, hopefully finished very soon.

@rightx2 I have raised PR: https://github.com/airflow-helm/charts/pull/255 to fix this

@rightx2 can you confirm if version 8.4.0 has resolved this issue for you?

Hi, I'm @rightx2 's teammate.
At first, The reason for this issue is that airflow config has xcom settings, but the actual related file cannot be found in the dag volume mount location.
The initial chart probably did not support init-container and job separately because mostly they don't need dag volume.
Anyway, It was solved as just attaching the AIRFLOW__CORE__XCOM_BACKEND environment variables on only the worker and scheduler.
FYI. It's was not solved as PR, adding extraVolumes, extraVolumeMounts. Because, In init-container they can't communicate data with volume mount even if the order is correct. (I don't know why they can't communicate data in init-container)

@tyg03485 are you sure that this issue was not solved after version 8.4.0
The 8.4.0 version included PR https://github.com/airflow-helm/charts/pull/255, which made sure that init-containers mounted extraVolumes, extraVolumeMounts, and git-sync's dags-data volume.

Yes, I also tested on 8.4.0 and It didn't work. check-db init-container is problem which i said above.

Maybe you can check it with below override value
...
airflow:
  extraEnv:
    - name: PYTHONPATH
      value: {{ PYTHON PATH }}
    - name: AIRFLOW__CORE__XCOM_BACKEND
      value: plugins.xcom_backend.S3XComBackend
...

@tyg03485 can you share a version of your plugin so I can test it on my end?

@rightx2 I believe that this should be resolved in version 8.5.0 of the chart, can you verify this?

What is final solution to this ? because I am still facing it.

@v-lohana this is quite an old issue, what version of the chart are you running, and can you clarify the exact problem you are experiencing (preferably with logs)?


Picking video takes time and freeze gallery  [🐛]

Description
When I try to get video from gallery, image picker freeze by time proportional to the file size
(1min video is like 5-10 sec to unfreeze and get informations about it)
Is there something that I don't understand or that I'm doing wrong ?
How to repeat issue and example
-Launch launchImageLibrary  method
-Pick video
launchImageLibrary({       mediaType: 'video',       storageOptions: {         skipBackup: true,       },     }, (res) => {...});
Solution
I have the impression that the lib generates a temporary file?
The longer the video, the longer it takes (tested with includeBase64: false)
The Graal would be to get the information from the video instantly.
Additional Information

Image Picker version: [^3.1.4]
React Native version: [react-native-cli: 2.0.1 - react-native: 0.63.4]
Platform: [Android]
Development Operating System: [MacOS]
Dev tools: [Xcode, Android] navigation crash for Android

Image picker 3.x.x version does not have storageOptions.  So make sure you'r using the correct version, in v3.x.x only image files are copied to app specific temp folder, videos are not.

I also tried without storageOptions , doesn't change anything :(.

I have no idea, create a new react-native project and try, check if the issue is on the device or any particular video file etc.

Yup I'll try.
Just to get sure before closing issue, is normal business of the library is to instantly get video information ?

Yes

Thx !


Add link to K3s

K3s seems like a good fit for people wanting to experiment with Tye.

Only issue with adding k3s to this list is current the list is pretty Windows-centric while k3s is (by default) a linux-based solution and somewhat weird to get up and running in WSL.

We definitely don't intend to be windows-centric. Lot of people are dev'ing .net on windows/wsl/mac/linux

@rynowak Absolutely. Just saying it has some caveats. Maybe at some point closer to maturity doing something like: https://docs.tilt.dev/choosing_clusters.html

We definitely don't intend to be windows-centric. Lot of people are dev'ing .net on windows/wsl/mac/linux

@rynowak yeah just as one data point, I work at a wholly .NET shop and probably 50% of our devs use a Mac laptop running OS X :)


PipelineExecutionStepState should expose environment id in addition to label

Currently the object PipelineExecutionStepState only exposes some environment label with https://github.com/AdobeDocs/cloudmanager-api-docs/blob/38265737eb4ac3bd54fa4324094e962f8017dc1c/swagger-specs/api.yaml#L1689. This is only useful for UI purposes, but not for follow-up API calls like https://github.com/AdobeDocs/cloudmanager-api-docs/blob/38265737eb4ac3bd54fa4324094e962f8017dc1c/swagger-specs/api.yaml#L1086 which requires the environmentId. Looking up the environmentId for a specific phase currently requires an additional call to https://github.com/AdobeDocs/cloudmanager-api-docs/blob/38265737eb4ac3bd54fa4324094e962f8017dc1c/swagger-specs/api.yaml#L269 to figure out the connected environment id.
It would be nice to expose the environmentId in addition also in PipelineExecutionStepState to not be forced to do an additional API call for e.g. calling the logs related to failed "deploy" phase.

Actually PipelineExecutionStepState only has identifier phaseId which is not used in PipelinePhase, therefore currently there is no way to do the mapping between PipelineExecutionStepState and the environmentId!

This has been corrected -- there is an environmentId property on the step state that was missing for some reason.


chore: Put EOF structure behind an Arc

This is the ISSUE
DaniPopes: EOF structure is present inside of Bytecode, and is cloned internally in AccountInfo and other places. It would improve performance to put behind an Arc to avoid cloning the underlying memory.
cc: @rakita @DaniPopes

I'm taking a look at why the tests are failing, it seems to be something else and not the changes made here

I'm taking a look at why the tests are failing, it seems to be something else and not the changes made here

It is a malformed json file https://github.com/ethereum/tests/pull/1384
It is not related to this PR.

Thanks for the recommendation, I will start using it.


sharded_jit cleanup

Add sharding utilities to xla_bridge
Change partitions argument to in_parts and out_parts
Add unit tests
Reuse more pxla functionality
Remove stale translation rule
Fail on non-TPU platforms
Add docstring
And more!

@jekbradbury sorry this is so long, lemme know if I should break it up into smaller changes.
I verified that the tests pass internally. I think we should be able to run these on Cloud TPUs too, but it requires a jaxlib change to enable SPMD partitioning without the flag.

@gnecula LGTM's offline. I also verified that the tests still pass on TPU.


New var name in nc_rename_var() is not normalized for utf8. Should it be?

In nc_rename_dim() the new name is run through nc_utf8_normalize().
But this doesn't happen with nc_rename_var().
Shouldn't it?

yes, it should be normalized.
Sent from my iPad

On Dec 26, 2017, at 5:46 AM, Ed Hartnett<EMAIL_ADDRESS>wrote:
In nc_rename_dim() the new name is run through nc_utf8_normalize().
But this doesn't happen with nc_rename_var().
Shouldn't it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

What kind of string can I pass to make sure that normalization is taking place?
That is, what string can I pass that comes out differently after being normalized?
I would like to write some tests before fixing...

There should be a utf8 test case that tests normalization.
Sent from my iPad

On Dec 26, 2017, at 2:50 PM, Ed Hartnett<EMAIL_ADDRESS>wrote:
What kind of string can I pass to make sure that normalization is taking place?
That is, what string can I pass that comes out differently after being normalized?
I would like to write some tests before fixing...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

OK, I will hunt one down and add a test.

not obvious we need a rename normalization test specifically sine i presume you will use same
name check code used in e.g. nc_def_var

If we had a rename normalization test then this bug would have been noticed before. So of course we need a test for it.

I am confused. Did normalization fail or was it just missing?

Normalization is actually happening as I've just confirmed with a test. I will add the test to my current PR. When it's merged this ticket will be closed.


Support SHALLOW CLONE for Delta Lake

Description
This PR introduces support for SHALLOW CLONE for both Delta and Parquet table on Delta Lake, specifically the following command:
CREATE [OR REPLACE] TABLE [IF NOT EXISTS] target SHALLOW CLONE source [VERSION AS OF version | TIMESTAMP AS OF timestamp] [TBLPROPERTIES clause] [LOCATION path]
This enables the following use cases:

Create a target table with Delta log pointing to the files from the source table. The source table can be either a Delta table or a Parquet table.

You may also specify a custom path to create as an external table in a path, a clause for additional table properties to append to, or a version to create the target table as a time-travelled version of the source table (if is Delta).
E.g. CREATE TABLE target SHALLOW CLONE source

Replace/restore a table by shallow-cloning itself. This requires the table to be empty by the time of cloning to avoid data duplication.

E.g. REPLACE TABLE source SHALLOW CLONE source VERSION AS OF 1
How was this patch tested?
Unit tests.
Does this PR introduce any user-facing changes?
No.

There seem to be something wrong with the test infra @scottsand-db

@jackierwzhang, @vkorukanti, it seems the config name doesn't follow the same pattern used by recent features, should we change it?
clone.replaceEnabled -> clone.replace.enabled?
Example:
val DELTA_CONVERT_ICEBERG_ENABLED =
buildConf("convert.iceberg.enabled")
.internal()
.doc("If enabled, Iceberg tables can be converted into a Delta table.")
.booleanConf
.createWithDefault(true)
val DELTA_CONVERT_ICEBERG_PARTITION_EVOLUTION_ENABLED =
buildConf("convert.iceberg.partitionEvolution.enabled")
.doc("If enabled, support conversion of iceberg tables experienced partition evolution.")
.booleanConf
.createWithDefault(false)


Eventless transition actions are passed different events

Description
Eventless transition actions are getting passed different events depending on if they are a built in (assign, pure) or just a normal function.
Expected Result
They would all receive the same event (preferably the one logged in the function, as that is more useful than a null event).
Actual Result

assign, pure (didn't test other built in actions) receive a null event (ie: { type: '' })
a normal function is passed the event that transitioned into the current state

Reproduction
https://codesandbox.io/s/brave-wildflower-7t649

This is something that we are aware of and something that is going to be fixed in the next major version.

Ah thanks, good to know! Is there a workaround? For assign actions it looks like I can grab the event from the meta.state.event, but the meta is not available for send/pure.

As a workaround I've simply replaced always in favor of entry + send
'transient-state': {
  entry: [
    ....
    send('finished'),
  ],
  on: {
    'finished': '#next-state',
  },
},

A partial workaround for the assign action - use the meta object passed as the 3rd argument to some actions.
assign((ctx, event, meta) => {
  console.log("assign", event.type, meta.state.event); // meta.state.event will be the correct event
  return ctx;
}),

Alas, this does not work for the pure and send action creators (I haven't checked others).

This is a breaking change in v4, but is fixed for v5: https://github.com/statelyai/xstate/pull/2824


update cypress version

https://issues.redhat.com/browse/RHOAIENG-7071
Description

Updating cypress in hopes that certain flakes stop. After investigating the linked issue, there doesn't seem to be anything specifically causing this flake from our tests. Instead there's a related cypress bug that may be the culprit. Unfortunately that bug has yet to be fixed.
How Has This Been Tested?

Run tests.
Test Impact

N/A
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm


FastAPI unable to resolve user_id in /chat endpoint

In case a user doesn't enter their OpenAI API key in https://docdocgo-nextjs-basic.vercel.app/ (or include it in the API post body), relying instead on the .env file DEFAULT_OPENAI_API_KEY key in the running FastAPI server, you will not be able to resolve the user_id. This results in the user's collections being invisible. I fixed the problem by changing lines 302, 303 like this:
        openai_api_key: str = data.openai_api_key or DEFAULT_OPENAI_API_KEY
        user_id: str | None = get_short_user_id(openai_api_key)

The general principle I have adopted is that DEFAULT_OPENAI_API_KEY is meant to be a community key (costs are paid by the person who hosts the backend, collections are public). I can make it so BYPASS_SETTINGS_RESTRICTIONS being set changes that default behavior in the API, just as it does in the Streamlit app.

I think you just need to make the change I proposed. I don't think it'll change your intent, unless you don't want the community key (DEFAULT_OPENAI_API_KEY) to be used via the API. Maybe setting BYPASS_SETTINGS_RESTRICTIONS as you suggest is better.


Unable to visualize available metric points in a whisper file

Given a whisper file with the archive (1s:14d)
whisper-info.py direction.wsp
maxRetention: 1209600
xFilesFactor: 0.5
aggregationMethod: average
fileSize: 14515228

Archive 0
retention: 1209600
secondsPerPoint: 1
points: 1209600
size: 14515200
offset: 28

having data points for 16 July 2017.
...
321184:<PHONE_NUMBER>,          0
321187:<PHONE_NUMBER>,          0
321190:<PHONE_NUMBER>,          0
321193:<PHONE_NUMBER>,          1
321198:<PHONE_NUMBER>,          0
...

$ for i in<PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER> ; do  echo "$i - `date -d @$i`"; done
1500199984 - Sun 16 Jul 11:13:04 BST 2017
1500199987 - Sun 16 Jul 11:13:07 BST 2017
1500199990 - Sun 16 Jul 11:13:10 BST 2017
1500199993 - Sun 16 Jul 11:13:13 BST 2017
1500199998 - Sun 16 Jul 11:13:18 BST 2017

When viewing the same data from graphite-web, there are no results.
http://localhost/render?from=10%3A00_20170716&until=14%3A00_20170716&width=400&height=250&target=direction&_uniq=0.24008196147297345&title=DEVICE_3375.direction&rawData=1

Empty result

Can someone please explain why this happens? Is graphite-web performing some kind of aggregation and considering most data points as null? For some time durations (over several seconds) in the whisper file, all available slots are not filled.

Right now whisper always calculates available data from the current time, so it won't be able to retrieve data older than 14 days.  You can work around it via the render API if you're running master or the 1.1.x branch by passing now=14%3A00_20170716 in your render request.

Sorry, I do not understand your comment completely as I managed to read data points in the whisper file using whisper-dump utility.
# Searching for interested data points based on timestamp
whisper-dump.py direction.wsp  | grep 150019

why do you say that i cannot visualize data older than 14 days?

@raghavan20 : You have single 1s:14d archive in whisper. That means "Store data every 1 second and keep last 14 days of data". So, Graphite by default takes 14 days from current date and renders data - but there's no data for last 14 days - then it shows nothing.
The proper solution for that situation - change your storage schema. If you need to keep more that 14 days of data, please change it accordingly  - or increase retention or add another archive.
But if you need to just render data for that period once - then you can trick Graphite to think that today is 16 july 2017 - add  now=14%3A00_20170716 to your render request, but it will work only in Graphite 1.1 or newer.

thanks @deniszh  for the answer. our original intention was to create a backup for a  historic event and visualize later in time. i was thinking if i just copied the whisper file immediately soon after the interested event occurred and assuming that no new data went in ( hence no aggregation happens ), i should be able to visualize historic data. i guess we should have set retention like 1s:2y if we wanted to visualize data at 1s granularity in the next two years. i originally did not think about it considering that all data except the interested event duration is waste of file space.
but from what you have explained graphite-web would not work like that. the amount of data that can be visualized from whisper files is based on archives and points. now given that i have the whisper file which holds 14 days of historical data, is it possible to run through some tools so that i can visualize from Graphite apart from the now query parameter supported with 1.1+ version of graphite-web application?

Hi, I tried to run the latest version of graphite-web so that i can use the now query parameter.
I believe I am using 1.1+ of graphite-web based on the below output. I am running a Docker container from graphiteapp/graphite-statsd.
# ls /opt/graphite/lib/* | grep py2
lib/carbon-1.1.1-py2.7.egg-info

Exception while viewing the direction.wsp file from graphite/exception.log
 2018-02-05,15:54:52.884 :: Exception encountered in <GET http://localhost/render?from=09%3A00_20170713&until=17%3A00_20170717&width=400&height=250&target=DEVICE_3375.direction&_uniq=0.9074819190254235&title=DEVICE_3375.direction>
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/graphite/webapp/graphite/render/views.py", line 117, in renderView
    data.extend(evaluateTarget(requestContext, targets))
  File "/opt/graphite/webapp/graphite/render/evaluator.py", line 15, in evaluateTarget
    prefetchData(requestContext, pathExpressions)
  File "/opt/graphite/webapp/graphite/render/datalib.py", line 255, in prefetchData
    for result in STORE.fetch(pathExpressions, startTime, endTime, now, requestContext):
  File "/opt/graphite/webapp/graphite/storage.py", line 137, in fetch
    raise Exception("Fetch for %s failed: %s" % (str(patterns), str(job.exception)))
Exception: Fetch for [u'DEVICE_3375.direction'] failed: 'NoneType' object is not iterable

That's strange. Are you sure that you mount all volumes properly? Can you render other targets? (e.g. carbon or statsd statistics)

I've been able to duplicate this error when the whisper file exists but whisper.fetch returns None, will open a PR to fix that shortly


Login does not save user to session

On refresh, it does not deserialize the user. Which is killing me.
Presumably, one of the many dependencies has had a version bump, and broke the world.

Oh god.
https://github.com/jaredhanson/passport/issues/222

I also bumped into this.. tried to follow the resolutions but not working still.. any ideas?

@shawnxusy The fix just pushed fixed it makes it work on http connections, but I'm still looking for a fix for trusting proxies over a HTTPS connection. Something related to config settings. :D

https://github.com/choonkending/react-webpack-node/commit/dfdc8c514f7906c3bfff45ebc55609b417b560c3

Closing as fixed :D. @shawnxusy Feel free to ask any questions if u still encounter this issue.

Thanks @choonkending, works great :D


updatePresence not working

Does anyone know why the updatePresence() function doesn't work?
I even tried literally copying and pasting what's on the site
$game = $discord->factory(Game::class, [
    'name' => 'i am playing a game!',
]);

$discord->updatePresence($game);

Did the function change in any of the new updates?
or is there a specific place you're supposed to put it in?
I was putting it in $discord->on('ready'

Works for me, make sure you import the Game class with use Discord\Parts\User\Game; at the top of your file.

Thanks, that was what the problem was!
Perfect! This might even solve some of the other issues I was having. I wasn't important libraries like that.