Initial Planificator (aka PlannerController) implementation

and refactor existing code to use Planificator.
This PR is just reorganizing the existing functionality, all improvements will come in the next PRs.

@sjmiles I could swear it worked yesterday, but today exactly what you were describing in that TODO in arc-steps happened, and plans were getting reset before step was being added. So I tweaked the wiring to pass a struct with latest instantiated plan instead. Would you like to take a look and make sure it looks legit? Thanks!

LGTM


Upstream rttov 13.1 on Piz Daint not found by Spack v<IP_ADDRESS>

When trying to install the new spack environment config/cscs/spack/v<IP_ADDRESS>/daint_cpu_nvhpc for ICON, the following Error appears:
==> Installing rttov-13.1-e7smktodxbus6aq5u3xnkec6e2tyi5so
==> No binary for rttov-13.1-e7smktodxbus6aq5u3xnkec6e2tyi5so found: installing from source
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
==> Error: FetchError: All fetchers failed for spack-stage-rttov-13.1-e7smktodxbus6aq5u3xnkec6e2tyi5so
==> Warning: Skipping build of icon-develop-yywcbfutebz6ovohhr7zs5mvte3i6fad since rttov-13.1-e7smktodxbus6aq5u3xnkec6e2tyi5so failed
==> Error: icon-develop-yywcbfutebz6ovohhr7zs5mvte3i6fad: Package was not installed
==> Error: rttov-13.1-e7smktodxbus6aq5u3xnkec6e2tyi5so: Package was not installed
==> Error: Installation request failed.  Refer to reported errors for failing package(s).

However, the upstream can be found with spack find -v rttov:
-- cray-cnl7-haswell /<EMAIL_ADDRESS>-------------------------------
<EMAIL_ADDRESS>build_system=generic patches=3be8d26
==> 1 installed package

That's the output of spack concretize -f:
==> Concretized<EMAIL_ADDRESS>[^]  nwqrppf  libxml2<EMAIL_ADDRESS>build_system=autotools patches=3e06d42 arch=cray-cnl7-haswell
[^]  7f3y7vq      ^libiconv<EMAIL_ADDRESS>build_system=autotools libs=shared,static arch=cray-cnl7-haswell
[e]  bpn35ql      ^pkg-config<EMAIL_ADDRESS>build_system=autotools arch=cray-cnl7-haswell
[e]  q6ds6lb      ^xz<EMAIL_ADDRESS>build_system=autotools libs=shared,static arch=cray-cnl7-haswell
[^]  fndyky5      ^zlib<EMAIL_ADDRESS>build_system=makefile arch=cray-cnl7-haswell

==> Concretized<EMAIL_ADDRESS> -   e7smkto  rttov<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" +hdf5~netcdf~openmp build_system=generic patches=3be8d26 arch=cray-cnl7-haswell
[+]  ewtyrxg      ^hdf5<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~cxx+fortran+hl~ipo~java+mpi+shared~szip~threadsafe+tools api=default build_system=cmake build_type=Release generator=make arch=cray-cnl7-haswell
[^]  dfxozm3          ^cmake<EMAIL_ADDRESS>build_system=generic build_type=Release arch=cray-cnl7-haswell
[^]  d5axuws              ^ncurses<EMAIL_ADDRESS>abi=none build_system=autotools arch=cray-cnl7-haswell
[^]  iozk2ko              ^openssl<EMAIL_ADDRESS>build_system=generic certs=mozilla arch=cray-cnl7-haswell
[^]  bbljduw                  ^ca-certificates-mozilla<EMAIL_ADDRESS>build_system=generic arch=cray-cnl7-haswell
[e]  sr5fn5g                  ^perl<EMAIL_ADDRESS>build_system=generic patches=0eac10e,8cf4302 arch=cray-cnl7-haswell
[e]  sj2pwux          ^gmake<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~guile build_system=autotools patches=ca60bd9,fe5b60d arch=cray-cnl7-haswell
[e]  ucef7go          ^mpich<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~argobots~cuda+fortran+hwloc+hydra+libxml2+pci~rocm+romio~slurm~two_level_namespace~vci~verbs+wrapperrpath build_system=autotools datatype-engine=auto device=ch4 netmod=ofi pmi=pmi arch=cray-cnl7-haswell
[e]  bpn35ql          ^pkg-config<EMAIL_ADDRESS>build_system=autotools arch=cray-cnl7-haswell
[^]  fndyky5          ^zlib<EMAIL_ADDRESS>build_system=makefile arch=cray-cnl7-haswell
[e]  crpojro      ^nvidia-blas<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm"  build_system=generic arch=cray-cnl7-haswell
[e]  7a7oqvv      ^nvidia-lapack<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm"  build_system=generic arch=cray-cnl7-haswell
[e]  ftdfawn      ^perl<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~cpanm+open+shared+threads build_system=generic patches=0eac10e,8cf4302 arch=cray-cnl7-haswell

==> Concretized<EMAIL_ADDRESS>[+]  ewtyrxg  hdf5<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~cxx+fortran+hl~ipo~java+mpi+shared~szip~threadsafe+tools api=default build_system=cmake build_type=Release generator=make arch=cray-cnl7-haswell
[^]  dfxozm3      ^cmake<EMAIL_ADDRESS>build_system=generic build_type=Release arch=cray-cnl7-haswell
[^]  d5axuws          ^ncurses<EMAIL_ADDRESS>abi=none build_system=autotools arch=cray-cnl7-haswell
[^]  iozk2ko          ^openssl<EMAIL_ADDRESS>build_system=generic certs=mozilla arch=cray-cnl7-haswell
[^]  bbljduw              ^ca-certificates-mozilla<EMAIL_ADDRESS>build_system=generic arch=cray-cnl7-haswell
[e]  sr5fn5g              ^perl<EMAIL_ADDRESS>build_system=generic patches=0eac10e,8cf4302 arch=cray-cnl7-haswell
[e]  sj2pwux      ^gmake<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~guile build_system=autotools patches=ca60bd9,fe5b60d arch=cray-cnl7-haswell
[e]  ucef7go      ^mpich<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~argobots~cuda+fortran+hwloc+hydra+libxml2+pci~rocm+romio~slurm~two_level_namespace~vci~verbs+wrapperrpath build_system=autotools datatype-engine=auto device=ch4 netmod=ofi pmi=pmi arch=cray-cnl7-haswell
[e]  bpn35ql      ^pkg-config<EMAIL_ADDRESS>build_system=autotools arch=cray-cnl7-haswell
[^]  fndyky5      ^zlib<EMAIL_ADDRESS>build_system=makefile arch=cray-cnl7-haswell

==> Concretized<EMAIL_ADDRESS>[+]  mg5m4ce  eccodes<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~aec~fortran~ipo~memfs~netcdf~openmp~png~pthreads+shared~tools build_system=cmake build_type=Release definitions=auto generator=make jp2k=openjpeg samples=auto arch=cray-cnl7-haswell
[^]  dfxozm3      ^cmake<EMAIL_ADDRESS>build_system=generic build_type=Release arch=cray-cnl7-haswell
[^]  d5axuws          ^ncurses<EMAIL_ADDRESS>abi=none build_system=autotools arch=cray-cnl7-haswell
[^]  iozk2ko          ^openssl<EMAIL_ADDRESS>build_system=generic certs=mozilla arch=cray-cnl7-haswell
[^]  bbljduw              ^ca-certificates-mozilla<EMAIL_ADDRESS>build_system=generic arch=cray-cnl7-haswell
[e]  sr5fn5g              ^perl<EMAIL_ADDRESS>build_system=generic patches=0eac10e,8cf4302 arch=cray-cnl7-haswell
[e]  sj2pwux      ^gmake<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~guile build_system=autotools patches=ca60bd9,fe5b60d arch=cray-cnl7-haswell
[^]  sntpinw      ^openjpeg<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~codec~ipo build_system=cmake build_type=Release generator=make arch=cray-cnl7-haswell
[e]  5eyt64v          ^cmake<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~doc+ncurses+ownlibs~qt build_system=generic build_type=Release patches=1c54004,bf695e3 arch=cray-cnl7-haswell

==> Concretized icon@develop%nvhpc+art~coupling+dace+ecrad+grib2+rte-rrtmgp+rttov fcgroup=DACE.externals/dace_icon.-O1
 -   yywcbfu  icon<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~active-target-sync+aes+art+async-io-rma+atmo~cdi-pio~coupling~cuda~cuda-graphs+dace~eccodes-definitions+ecrad+edmf~emvorado+grib2~infero+jsbach+les+loop-exchange~mixed-precision+mpi~mpi-gpu~nccl+ocean~openmp~parallel-netcdf~pgi-inlib~realloc-buf+rte-rrtmgp+rttov~sct+silent-rules~testbed+upatmo~vectorized-lrtm~waves~yaxt build_system=autotools claw=none dev_path=/scratch/snx3000/alauber/icon-test dsl=none fcgroup=DACE.externals/dace_icon.-O1 gpu=no serialization=none arch=cray-cnl7-haswell
[^]  dfxozm3      ^cmake<EMAIL_ADDRESS>build_system=generic build_type=Release arch=cray-cnl7-haswell
[^]  d5axuws          ^ncurses<EMAIL_ADDRESS>abi=none build_system=autotools arch=cray-cnl7-haswell
[^]  iozk2ko          ^openssl<EMAIL_ADDRESS>build_system=generic certs=mozilla arch=cray-cnl7-haswell
[^]  bbljduw              ^ca-certificates-mozilla<EMAIL_ADDRESS>build_system=generic arch=cray-cnl7-haswell
[e]  sr5fn5g              ^perl<EMAIL_ADDRESS>build_system=generic patches=0eac10e,8cf4302 arch=cray-cnl7-haswell
[+]  mg5m4ce      ^eccodes<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~aec~fortran~ipo~memfs~netcdf~openmp~png~pthreads+shared~tools build_system=cmake build_type=Release definitions=auto generator=make jp2k=openjpeg samples=auto arch=cray-cnl7-haswell
[e]  sj2pwux          ^gmake<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~guile build_system=autotools patches=ca60bd9,fe5b60d arch=cray-cnl7-haswell
[^]  sntpinw          ^openjpeg<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~codec~ipo build_system=cmake build_type=Release generator=make arch=cray-cnl7-haswell
[e]  5eyt64v              ^cmake<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~doc+ncurses+ownlibs~qt build_system=generic build_type=Release patches=1c54004,bf695e3 arch=cray-cnl7-haswell
[^]  nwqrppf      ^libxml2<EMAIL_ADDRESS>build_system=autotools patches=3e06d42 arch=cray-cnl7-haswell
[^]  7f3y7vq          ^libiconv<EMAIL_ADDRESS>build_system=autotools libs=shared,static arch=cray-cnl7-haswell
[e]  bpn35ql          ^pkg-config<EMAIL_ADDRESS>build_system=autotools arch=cray-cnl7-haswell
[e]  q6ds6lb          ^xz<EMAIL_ADDRESS>build_system=autotools libs=shared,static arch=cray-cnl7-haswell
[^]  fndyky5          ^zlib<EMAIL_ADDRESS>build_system=makefile arch=cray-cnl7-haswell
[e]  ucef7go      ^mpich<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~argobots~cuda+fortran+hwloc+hydra+libxml2+pci~rocm+romio~slurm~two_level_namespace~vci~verbs+wrapperrpath build_system=autotools datatype-engine=auto device=ch4 netmod=ofi pmi=pmi arch=cray-cnl7-haswell
[e]  dm2pmeq      ^netcdf-c<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" +blosc~byterange~dap~fsync~hdf4~jna+mpi~nczarr_zip+optimize+parallel-netcdf+pic+shared+szip+zstd build_system=autotools patches=cb928a9 arch=cray-cnl7-haswell
[e]  awb67u3      ^netcdf-fortran<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~doc+pic+shared build_system=autotools arch=cray-cnl7-haswell
[e]  crpojro      ^nvidia-blas<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm"  build_system=generic arch=cray-cnl7-haswell
[e]  7a7oqvv      ^nvidia-lapack<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm"  build_system=generic arch=cray-cnl7-haswell
[e]  ftdfawn      ^perl<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~cpanm+open+shared+threads build_system=generic patches=0eac10e,8cf4302 arch=cray-cnl7-haswell
[e]  uyqzatt      ^python<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" +bz2+crypt+ctypes+dbm~debug+libxml2+lzma~nis~optimizations+pic+pyexpat+pythoncmd+readline+shared+sqlite3+ssl+tix+tkinter+uuid+zlib build_system=generic patches=0d98e93,ebdca64,f2fd060 arch=cray-cnl7-haswell
 -   e7smkto      ^rttov<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" +hdf5~netcdf~openmp build_system=generic patches=3be8d26 arch=cray-cnl7-haswell
[+]  ewtyrxg          ^hdf5<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm" ~cxx+fortran+hl~ipo~java+mpi+shared~szip~threadsafe+tools api=default build_system=cmake build_type=Release generator=make arch=cray-cnl7-haswell

==> Concretized nvidia-blas%nvhpc
[e]  crpojro  nvidia-blas<EMAIL_ADDRESS>fflags="-lnvcpumath -lnvhpcatm"  build_system=generic arch=cray-cnl7-haswell

I see a bunch of warnings after spack concretize -f
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs cmake-5eyt64v
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs gmake-sj2pwux
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs zlib-fndyky5
==> Warning: Missing dependency not in database: ncurses/d5axuws needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: util-linux-uuid/bqmrc6a needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: openssl/iozk2ko needs zlib-fndyky5
==> Warning: Missing dependency not in database: python/2p3rqgb needs bzip2-t3jngut
==> Warning: Missing dependency not in database: python/2p3rqgb needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: python/2p3rqgb needs xz-q6ds6lb
==> Warning: Missing dependency not in database: python/2p3rqgb needs zlib-fndyky5
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs cmake-5eyt64v
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs gmake-sj2pwux
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: hdf5/4ewopfl needs zlib-fndyky5
==> Warning: Missing dependency not in database: ncurses/d5axuws needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: util-linux-uuid/bqmrc6a needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: openssl/iozk2ko needs zlib-fndyky5
==> Warning: Missing dependency not in database: python/2p3rqgb needs bzip2-t3jngut
==> Warning: Missing dependency not in database: python/2p3rqgb needs pkg-config-bpn35ql
==> Warning: Missing dependency not in database: python/2p3rqgb needs xz-q6ds6lb
==> Warning: Missing dependency not in database: python/2p3rqgb needs zlib-fndyky5

Maybe there's something wrong with the upstream. Maybe it's related to https://github.com/spack/spack/issues/15977. I don't think Daint's upstream satisfies https://spack.readthedocs.io/en/latest/chain.html#using-multiple-upstream-spack-instances

@jonasjucker Can you have a look at this?

It is strange, for BB the dependencies are found and no rttov is built.
@AnnikaLau Can you check if using spack concretize -f --reuse has an impact?

It is strange, for BB the dependencies are found and no rttov is built.
@AnnikaLau Can you check if using spack concretize -f --reuse has an impact?

I already had tried this and it didn't make a difference.

It is strange, for BB the dependencies are found and no rttov is built.
@AnnikaLau Can you check if using spack concretize -f --reuse has an impact?

I already had tried this and it didn't make a difference.

Hmm, it seems to work now...

According to the documentation --reuse is the default. So you may ommit it.

According to the documentation --reuse is the default. So you may ommit it.

But if I run spack concretize -f and spack install it fails, while it works with spack concretize -f --reuse and spack install

This is where the default is set: https://github.com/spack/spack/blob/e8658d6493887ef702dd38f0e9ee5870a1651c1e/etc/spack/defaults/concretizer.yaml#L12-L18
--reuse overwrites it with True.

This is where the default is set: https://github.com/spack/spack/blob/e8658d6493887ef702dd38f0e9ee5870a1651c1e/etc/spack/defaults/concretizer.yaml#L12-L18 --reuse overwrites it with True.

Something has to go wrong there. Because when I run spack concretize -f and spack concretize -f --reuse, I get different results.

No thats correct. Spack has 3 conretizer options:

reuse: True
reuse: dependencies
reuse: False

spack concretize -f results in reuse: dependencies, whereas spack concretize -f --reuseresults inreuse: True`

Solved by #845


Title: WCAG 4.1.2: Ensures every form element has a label (.PrivateSwitchBase-input-317[value=""][data-indeterminate="false"])

Issue: Ensures every form element has a label (label - https://accessibilityinsights.io/info-examples/web/label)
Target application: Luminate Portal - http://localhost:7777/local-dev/plans/663b1af80f7ed815d83846bf/shipments
Element path: #mfe;.PrivateSwitchBase-input-317[value=""][data-indeterminate="false"]
Snippet:
How to fix:
Fix any of the following:
Form element does not have an implicit (wrapped)
Form element does not have an explicit
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element has no placeholder attribute
Element's default semantics were not overridden with role="none" or role="presentation"
Environment: Chrome version <IP_ADDRESS>
====
This accessibility issue was found using Accessibility Insights for Web 2.41.0 (axe-core 4.7.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Version: "@material-table/core": "^6.2.1"

Ok a few things.
Local host is your computer. That cannot be access by anybody else.
Can you verify it with the newest version.
Can you add the code/reproducible example in a code sandbox with just the code that does not work?


[spi_device] Revise readcmd to use cmd_info CSR

This commit revises the spi_readcmd submodule in the spi Flash mode.
It previously used the pre-defined opcode values and the configurations
to parse the address, the existance of the dummy cycle, read IO modes
(Single/ Dual/ Quad).
Now it uses the SW configurable cmd_info CSR to get the command
structures.
It introduces mbyte_en field too. It is not fully implemented yet. It is
a stopgap to support MByte transition. Full functionality will be
implemented later to reduce the amount of the commit size.

Hey All,
This is not a full functional SPI Flash read command yet. I created this PR to not have big changes in a PR. Please take a look at the cmd_info used in spi_readcmd first and ignore mbyte_en field for now.
I will create a series of PRs on top of this one. So please expect upcoming PRs looked like big changes in but ignore this commit.

Am I the only one seeing this CI error?

Am I the only one seeing this CI error?

no i saw it earlier too. i ended up re-pushing my PR to kick things off again.

Am I the only one seeing this CI error?

no i saw it earlier too. i ended up re-pushing my PR to kick things off again.

Hum.. Thanks. I tried multiple pushes but didn't help. Let me try again tonight.


Refactor to deal with truncation in config writing

By defining a new interface that handles seeks and truncating, we
can move that logic into tstune.configFileState.WriteTo. This
removes redundant code and improves testability since we can now
create a test interface that also seeks and truncates for testing
those code paths.

Codecov Report

Merging #29 into master will increase coverage by 1.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   87.43%   88.63%   +1.19%
==========================================
  Files          16       16
  Lines         796      792       -4
==========================================
+ Hits          696      702       +6
+ Misses         86       78       -8
+ Partials       14       12       -2

Impacted Files
Coverage Δ

pkg/tstune/tuner.go
78.2% <ø> (+1.47%)
:arrow_up:

pkg/tstune/backup.go
85% <ø> (+6.73%)
:arrow_up:

pkg/tstune/config_file.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8262e79...ba50719. Read the comment docs.


Photoshop template is out of date, UI overlay does not match what is displayed on screen

Photoshop template is out of date, UI overlay does not match what is displayed on screen
Clock dosnt fit, and the message text below dosnt fit
Please supply an updated accurate template, or delete the current one so we wont have to waste our time with it.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 25a70665-5bf1-14f7-1df0-7596effcaf48
Version Independent ID: 813cf005-2777-9419-d1ce-3f9401ac267c
Content: Remotely manage Microsoft Teams Rooms device settings - Microsoft Teams
Content Source: Teams/rooms/xml-config-file.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Hello @TAz00 I am working on this

Hello @TAz00
I could confirm that the file will be updated in the near future.

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Support object type spread

Resolves https://github.com/gcanti/babel-plugin-tcomb/issues/169

Thanks @voldern, released in https://github.com/gcanti/babel-plugin-tcomb/releases/tag/v0.3.26


Feature: Creating/Updating multiple orders

Hi,
I was recently working on a project that required us to update multiple orders. Due to throttling limits, we were going over our allotted quota frequently. After speaking to the ShipStation technical team, we were advised to use the bulk update/create endpoint to create/update orders.  This seems to be the preferred way of update/creating orders in bulk.
Here is the doc link to this API
Since I was unable to find the implementation of this API in this project, I wrote my own implementation of it.
I forked the repo and committed my changes here .
If you are satisfied with this addition I can create a pull request.
Kudos to your team for writing this great library. It was very intuitive to use and modify. 🥇 👍 🥳
Regards

i think it was integrated starting with version 1.0.0 of the package.
Please see https://github.com/marketvision/ShipStation4Net/blob/dba0c6b556f563bc011b5a6173afa7945acd6cd3/ShipStation4Net/Clients/Orders.cs#L150


Consensus: Events & metrics need to be correlated by labels, but we want to accommodate a shortcut

.

Cue Stackdriver/OpenCensus trace ids.


docker driver: use POSIX shell and support more linux package systems

'bash -c' ==> '/bin/sh -c', when build image, we may not have bash installed
default Dockerfile will install bash, cause login_cmd() will always use bash (why not only use /bin/sh)
add support more pkg system: apk, pacman, dnf, emerge

Nice work @gzm55 🚀


Expose console messages

We are working with React components and now and then developers tend to forget updating propTypes. React then in runtime would console.error about that, but with Gemini there is no access to read console messages back to the tests. There are many other cases when browsers emit warnings and I think it's in scope of Gemini to provide API for reading that. Is there any workaround for that?
Just for reference here for example how it could be done with direct access to webdriver for Chrome:
const webdriver = require('selenium-webdriver'),
      logging = require('selenium-webdriver/lib/logging'),
      chrome = require('selenium-webdriver/chrome')

const opts = new chrome.Options()
opts.addArguments('no-sandbox')
const prefs = new logging.Preferences()
prefs.setLevel(logging.Type.BROWSER, logging.Level.ERROR)
const caps = webdriver.Capabilities.chrome()
caps.setLoggingPrefs(prefs)
const webdriver = new webdriver
     .Builder()
     .forBrowser('chrome')
     .setChromeOptions(opts)
     .withCapabilities(caps)
     .build()

webdriver
  .then(browser => browser.get('http://localhost:8080'))
  .then(() => driver.manage().logs().get(logging.Type.BROWSER))
  .then(logs => {
    if (logs.length)
      throw new Error('console.error messages found')
  })

Do you guys agree to accept PR for that? I've implemented it already in my fork, essentially it's this commit https://github.com/gemini-testing/gemini/commit/a4a9618af18b6f5d78f32eb04ae403bc6e5c8bff

Hi.
Sorry for delay.
Yes, you can send us your PR - we'll merge it

Cool, thanks! I'll do it in a proper way and update docs as well some time later 👍

@artemyarulin Does it work with you changes shared in https://github.com/gemini-testing/gemini/commit/a4a9618af18b6f5d78f32eb04ae403bc6e5c8bff?

Hi, haven't used this project for a while, don't even remember, but most probably yeah, closing :)

We are looking into a way to capture browser logs for accessibility testing through axe-core, I am unable to figure out a way to do so.

Following snippet seems to work
.capture('default', (actions) => {
          actions.executeJS(function(window) {
            window.axe.run(function(error, results) {
              console.error('A11Y:' + JSON.stringify(results.violations));
            });
          }).wait(3000).logs(function(logs) {
            console.error(logs.filter((log) => log.level === 'SEVERE' && log.message.indexOf('A11Y:') > -1)[0]);
          });
        })


extend interface to enable logging with context

The current interface only routes pure message logging calls to the underlying logger implementation.
This PR extends the logger interface with new methods that take an additional context parameter of type map[string]interface{}. The logging context is converted if needed and then passed to the underlying logger implementation.

Codecov Report

Merging #1 (bdfb31f) into main (a089ab7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           96       166   +70
=========================================
+ Hits            96       166   +70

Impacted Files
Coverage Δ

adapter/std/adapter.go
100.00% <100.00%> (ø)

adapter/zap/adapter.go
100.00% <100.00%> (ø)

adapter/zlog/adapter.go
100.00% <100.00%> (ø)

wrapper.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a089ab7...bdfb31f. Read the comment docs.

Renamed logging context to fields as discussed.

@nalxnet thanks for contributing


Add PICOJSON_NO_EXCEPTIONS define to optionally remove throw-catch

For compatibility with builds for resource restricted systems which don't support exceptions

Typo fix also included other changes that I didn't intent to make.  Closing this until I get the PR fixed.


Fix live routes filter (order by progress, filter active or done)

For the live routes page I would need the schedule_assignments endpoint to support a filter for whether a student is still doing the round or is done, as well as being able to sort by progress (what percentage of buildings is done).


Consider not using --force-exclude by default

Contrary to #19,  making --force-exclude an implicit default can cause confusing behaviors. As some CI environments might run under paths that are excluded by default or excluded by custom configuration.
For example, the Bitbucket pipeline runs under /opt/atlassian/pipelines/agent/build, which is excluded by default (build), so running pre-commit run --all-files takes no effect at all, but it totally works as expected under local repo, really confusing!
Take me quite some time to figure out why our CI is not working, apparently, others have the same problem.
I suggest making the --force-exclude an opt-in, or at least add a reminder in README for setting --no-force-exclude.

Agreed, this has recently caught me out too, i think the best option is to just add it to the readme for now. Its trivial to remove if we do make the decision to drop it as a default argument. I have submitted a PR for this here: #72

Alternatively, I'm going to remove build from the default exclusion list in v0.3.0. It causes all sorts of problems (like this), and it's the only default for which we get issues like this.

See: https://github.com/astral-sh/ruff/pull/10093.

Yeah that makes sense :) Do we still think it's worth mentioning its the default? I spent quite a bit of time digging into this and really would have appreciated it being pointed out in the README 😆

I don't want to run with --force-exclude. This should be an option. Also I went crazy for an hour trying to figure out why it was ignoring files I had in a .github/scripts folder (hidden, thus excluded). Please move this to args

Actually, sorry. I'm still going crazy. --force-exclude doesn't seem to change whether or not my .github/scripts folder is evaluated. It works in cli but not in pre-commit.


Fix style inconsistencies in Bash completion

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? 👉 N/A
[x] Have you successfully run brew tests with your changes locally?

By now we have a pretty clear style for our Bash/shell code, but our Bash completions, that predate all this code, massively diverge from this style, to a point where it's just not fun to edit that file. This starts with the four-space indent, but includes a lot more than that. This is a follow-up to #654 and makes sure to obey all the rules that have been mentioned there.
Like #654 this focuses on style changes and tries to keep functional changes (even seemingly trivial ones) to an absolute minimum. Consequently, a few shellcheck warnings remain. They be addressed in a follow-up PR.
Note: I made multiple commits, so interested reviewers can pick out some of the finer changes that would be otherwise hidden by the indentation change. I intend to squash them on merge.

👍 as long as it's working for you.


Alternative dimension 5 isn't a void but a flat world instead.

In the newest version of immersive portals 1.16.3 on both fabric and forge the alternative dimension 5 doesnt create a void.

Above is a picture with the 5 dimension above the overworld

Fixed. Will be in the next version

Thank you very much!


fix message handler

Just tried out the example and ran into issues.
Here is the fix.
Thanks for the addon!

Thanks! someone else opened an identical PR


inet datatype docs

Closes #2016.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d255b519905bc928e584cabc84889f622b8a68e6/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/1fa7369811d3258419f95178c33d3a44ec1ec737/

Thanks for the review @nvanbenschoten!

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2c52f8d30de8599aefee020a1f06d1758d3826dd/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6cc13ba4add8373dcd73acdec26f8835ee35ab4a/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/08500c5a418ffe60bae322946d2296a28ef4c697/

LGTM!

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dd8f93b2d3fa3c0073ce935a7b41ddef8be58fb0/


feat(list.stories.tsx): add horizontal stories

[x] I have followed the Your First Code Contribution section of the Contributing guide

Add list horizontal stories
There are no breaking API changes.

@SutuSebastian This PR is ready to be merged 🙏


after move to .netcore 3.0, remove usage of NewtonsoftJson and use System.Text.Json

after move to .netcore 3.0, remove usage of NewtonsoftJson and use System.Text.Json so that Microsoft.Actions.Actors package has no external pkg dependency.

Should this porting guide be used when replacing ?
https://github.com/dotnet/corefx/blob/61024c30b966ee63c357a491370a2daf94c4c42f/src/System.Text.Json/porting_guide/README.md


fix(content-blog): Fix blog feeds not generated

Motivation
Blog feeds are not generated anymore due to a typo in a recent refactor 😓
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
no :'( we should probably add some tests though

we should probably add some tests though

Do you mean build simple site as Jest test? We had something like that in v1. https://github.com/facebook/docusaurus/blob/docusaurus-v1/packages/docusaurus-1.x/lib/tests/build-files.test.js

Do you mean build simple site as Jest test? We had something like that in v1. docusaurus-v1/packages/docusaurus-1.x/lib/tests/build-files.test.js

Yes, this kind of test can probably be done after the end of the e2e workflow, not sure where to put the files though because it shouldn't execute by default when running yarn test

Prettier has a separate repo with fixtures for testing new releases. Maybe we can make a mock site repo as well🧐


Fixed double using of CMAKE_INSTALL_PREFIX

SUPPORT_TARGET_DIR is defined at set(SUPPORT_TARGET_DIR "${RETDEC_INSTALL_SUPPORT_DIR_ABS}") when RETDEC_INSTALL_SUPPORT_DIR_ABS is defined as set(RETDEC_INSTALL_SUPPORT_DIR_ABS  "${CMAKE_INSTALL_PREFIX}/${RETDEC_INSTALL_SUPPORT_DIR}").
If you put some real path inside CMAKE_INSTALL_PREFIX, for example /path/to/somewhere, it is installed all ords into /path/to/somewhere/.../path/to/somewhere/ordinals/.

Hi, thanks for the PR. I wasn't able, however, to reproduce your issue locally. There is no difference in installation paths on my system when I use -DCMAKE_INSTLAL_PREIX=install vs -DCMAKE_INSTALL_PREFIX=$(realpath install).
What cmake are you using? In the code there should be, indeed, RETDEC_INSTALL_SUPPORT_DIR_ABS used and it should contain a correct absolute path all the time. The *_ABS variables are used through the project and we must ensure that they contain value as their name promise -> real path to some installation (sub)directory.
I looked into the definition and there is a variable CMAKE_INSTALL_DATADIR used that I think was expected to have a relative path "share" set all the time. The variable is set by CMake and is used to eliminate using share explicitly. Can you check that the variable has an absolute path set on your system? Can you also check DATAROOTDIR  variable?

@xkubov I've encountered this issue when I've created a port for MacPorts.
To build it on the right path and never leave sandbox I've hacked cmake related files like this:
post-patch {
    reinplace "s|\${CMAKE_INSTALL_PREFIX}|${destroot}\${CMAKE_INSTALL_PREFIX}|" ${worksrcpath}/CMakeLists.txt
    reinplace "s|\${CMAKE_INSTALL_PREFIX}|${destroot}\${CMAKE_INSTALL_PREFIX}|" ${worksrcpath}/support/CMakeLists.txt
    reinplace "s|DESTINATION \${SUPPORT_TARGET_DIR}/|DESTINATION \${RETDEC_INSTALL_SUPPORT_DIR}|" ${worksrcpath}/support/CMakeLists.txt
}

This PR is related to the last line, but I made introduce some site effects by the first two ;)


Command line arguments passed to knife solo silently clobbered if they contain "sudo" chars

I have a recipe called "sudoers" and want to run this via knife solo's "-o" option.
[shyouhei@kickhost chef-repos]$ mkdir -p recipes
[shyouhei@kickhost chef-repos]$ echo 'file "/etc/sudoers" do action :touch end' >> recipes/sudoers.rb
[shyouhei@kickhost chef-repos]$ knife solo cook target -o 'recipes[sudoers]'
Running Chef on target...
Checking Chef version...
Generating node config 'nodes/target.json'...
Installing Berkshelf cookbooks to 'cookbooks'...
Resolving cookbook dependencies...
Uploading the kitchen...
WARNING: Local cookbook_path '/home/shyouhei/chef-repos/cookbooks' does not exist
Generating solo config...
Running Chef...
/opt/chef/embedded/apps/chef/lib/chef/run_list/run_list_item.rb:59:in `initialize': Unable to create Chef::RunList::RunListItem from String:"recipes[sudo": must be recipe[] or role[] (ArgumentError)
        from /opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:147:in `new'
        from /opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:147:in `block (2 levels) in <class:Solo>'
        from /opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:146:in `map'
        from /opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:146:in `block in <class:Solo>'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/mixlib-cli-1.5.0/lib/mixlib/cli.rb:236:in `call'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/mixlib-cli-1.5.0/lib/mixlib/cli.rb:236:in `block (3 levels) in opt_parser'
        from /opt/chef/embedded/lib/ruby/2.1.0/optparse.rb:1390:in `call'
        from /opt/chef/embedded/lib/ruby/2.1.0/optparse.rb:1390:in `block in parse_in_order'
        from /opt/chef/embedded/lib/ruby/2.1.0/optparse.rb:1346:in `catch'
        from /opt/chef/embedded/lib/ruby/2.1.0/optparse.rb:1346:in `parse_in_order'
        from /opt/chef/embedded/lib/ruby/2.1.0/optparse.rb:1340:in `order!'
        from /opt/chef/embedded/lib/ruby/2.1.0/optparse.rb:1432:in `permute!'
        from /opt/chef/embedded/lib/ruby/2.1.0/optparse.rb:1454:in `parse!'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/mixlib-cli-1.5.0/lib/mixlib/cli.rb:192:in `parse_options'
        from /opt/chef/embedded/apps/chef/lib/chef/application.rb:84:in `configure_chef'
        from /opt/chef/embedded/apps/chef/lib/chef/application.rb:47:in `reconfigure'
        from /opt/chef/embedded/apps/chef/lib/chef/application/solo.rb:180:in `reconfigure'
        from /opt/chef/embedded/apps/chef/lib/chef/application.rb:56:in `run'
        from /opt/chef/embedded/apps/chef/bin/chef-solo:25:in `<top (required)>'
        from /usr/bin/chef-solo:40:in `load'
        from /usr/bin/chef-solo:40:in `<main>'
ERROR: RuntimeError: chef-solo failed. See output above.
[infra@goadev5001 chef-pfsys]$

I looked into the chef-solo process.  It seems chef-solo was called with broken arguments form the beginning.
I suspect knife-solo is clobbering the given parameter at some point.

Yeah, it definitely is. This line would be where I suspect.
It's trying to replace calls to "sudo" with different calls depending on the environment you're running on.
Switching to .sub might be good enough to fix it, but I'd want to do a full integration test run to be sure.


Tool to automate security problem detection with dependencies

This tool must installed on the CI.
Task list :

[x] does code QL make the job ?
[ ] if not, find a tool that scans dependencies for ansible and terraform

Please add your planning poker estimate with Zenhub @ad2ien

CodeQL does not scan ansible nor terraform code : https://codeql.github.com/docs/codeql-overview/supported-languages-and-frameworks/

KICS seems to do the job


EOF validation fuzzing issues

EOF validation fuzzing issues / missing test cases found by fuzzers.

evm1: invalid_container_section_index
revm: 1
code: ef0001010004020001000504ff0300008000023a60cbee1800

evm1: invalid_non_returning_flag
revm: 1
code: ef000101000c020003000400010003041d0000008000000080000000000000e300020000e50001

evm1: success
revm: 0
code: ef00010100040200010001040000000080000000

evm1: unreachable_code_sections
revm: 1
code: ef000101000c02000300030001000304000000008000000080000000800000e50001fee50002
size: 38

evm1: success
revm: 0
code: ef00010100100200040008000a00040007040000000080000200000001008000000000000260006000e3000100600035e10001e4e50002e3000300612015600155e4
size: 66

evm1: success
revm: 0
code: ef00010100100200040008000a00040002040000000080000200000001008000000000000060006028e3000100610034e10001e4e50002e30003005be4
size: 61

evm1: invalid_non_returning_flag
revm: 1
code: ef000101000c02000300040003000104000000008000000000000000000000e3000100e5000200
size: 39

All above seems fixed.

evm1: incompatible_container_kind
besu: 1
code: ef000101000402000100060300010014040000000080000260006000ee00ef00010100040200010001040000000080000000
size: 50

Can you add the version git commit being tested with each finding?

Latest tested revm: #b30dff48.

Besu stack overflow.
git: e57c811e472b7f9fc4d229ac5c9fd30983c9de52
crash.txt

evm1: invalid_max_stack_height
besu: 1
besu git: e57c811e472b7f9fc4d229ac5c9fd30983c9de52
code: ef0001010004020001001004002f0000800004444444440444e10003e10000444419001f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f1f
size: 82

evm1: stack_underflow
besu: 1
besu git: e57c811e472b7f9fc4d229ac5c9fd30983c9de52
code: ef00010100040200010016040000000080000544e200000444e100084444444444e100000444e50000
size: 41

evm1: success
besu: 0
besu git: e57c811e472b7f9fc4d229ac5c9fd30983c9de52
code: ef00010100040200010051040000000080000b424444e1fffc44e1fffc44e1fffc0244444480024444e1fffc4444e1fffc44e1fffc44e1fffc44e1fffc44e100054444e1fffc44e1fffc44e1fffc44e1fffc444480024444e1fffc44e1fffc44e1fffc00
size: 100

Can you add the version git commit being tested with each finding?

There were two non implemented checks, non-returning and container-kind (Initcode/Runtime) with container access checks.
Commits related to Revm fixes
Added missing CALLF/JUMPF non-returning check. and Later commit is a fix on misunderstanding on spec.
https://github.com/bluealloy/revm/pull/1663 and https://github.com/bluealloy/revm/pull/1664

42bbc74c - fix(EOF): returning to non-returning jumpf, enable valition error (#1664) (4 days ago)
dc2b3340 - feat(EOF): Add non-returning CALLF/JUMPF checks (#1663) (4 days ago)

This was a regression on e1236000 commit; code access must have a tracker. https://github.com/bluealloy/revm/pull/1659

9eabd4bd - fix(EOF): Validate code access in stack (#1659) (5 days ago)

Added missing Container kind check and container tracker (If it is used): https://github.com/bluealloy/revm/pull/1648

e1236000 - feat(EOF): EOF Validation add code type and sub container tracker (#1648) (6 days ago)

overflow panic https://github.com/bluealloy/revm/pull/1656

d71acb54 - fix(EOF): Overflow on num_sections (#1656) (6 days ago)

evm1: stack_height_mismatch
besu: 1
code: ef0001010004020001000b04000000008000024744e10003e10000e0fff5
size: 30

https://github.com/hyperledger/besu/pull/7419 appears to fix all the besu failures above -

https://github.com/ipsilon/eof/issues/146#issuecomment-2258029799 now fails with an underflow
https://github.com/ipsilon/eof/issues/146#issuecomment-2258045321 now succeeds
https://github.com/ipsilon/eof/issues/146#issuecomment-2262588486 now fails on backwards jump test

Except for the stack exceptionsin https://github.com/ipsilon/eof/issues/146#issuecomment-2257859537, which  is fixed by https://github.com/hyperledger/besu/pull/7396 which removes the recursive validation call

Geth RETF check (same as revm bug?)
besu: EOF Code Invalid : No RETF or qualifying JUMPF
geth: OK
evm1: err: invalid_non_returning_flag
code: ef00010100080200020005000d0400000000800002010200025fe3000100e1000760016005e000025f5f00
size: 43

This wasn't from the initial corpus, so it needs a unit test

[ ] write unit test

Geth invalid jump destination (RJUMPV)
besu: OK
geth: err(18): invalid jump destination
evm1: OK 60c9e2c9000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000fe6800
code: ef00010100040200010199040000000080000160c9e2c9000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000fe6800
size: 428

Geth invalid backwards jump
[encoded data, 61804 characters]


ensembles.ensemble_percentiles retains 'realization' dimension

xclim version: 0.15.0
Python version: 3.7
Operating System: Linux

Description
output dataset of ensembles.ensemble_percentiles() retains an unused "realization" dimension. Not a huge issue when working in xarray or netcdf but export to .csv via ds.to_Dataframe.to_csv causes n = len(ds.realization) copies of the percentiles data to be exported to the output .csv
adding a ds.drop('realization')  to  ensembles.ensemble_percentiles() before the return should fix the issue

@davidcaron FYI


Add support for custom property implementation

Allow a class to have a custom implementation of a property, as per methods  - at the moment you get a duplicate definition

Great upgrade.. I've also added support for events so now it should work for methods, properties, indexers and events. Also, there is language proposal 'Static abstract members in interfaces' so I've excluded static members.


Rename README.md to README.rst

to use pbr, we should use .rst format for the README

Thank you for contributing to stackforge/terracotta!
stackforge/terracotta uses Gerrit for code review.
Please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


flutter_platform should use package:build_runner_core when it becomes available

Running Dart programs from source in Dart 2 has non-trivial overhead compared to running from kernel. To improve the developer workflow for iterating on tests, we should leverage package:build_runner_core to modularly build and run flutter tests from kernel.
This is blocked on:
https://github.com/dart-lang/build/issues/1428
https://github.com/dart-lang/build/issues/1427

Note as a part of this work we should also create some benchmark tests.

The linked issues are fixed.

I believe this work falls on the Build and Test team and @jakemac53 is looking into it.

There is currently a problem blocking CI environments for packages with a lot of tests - probably blocked on that https://github.com/dart-lang/sdk/issues/33952. We might actually be able to get around that though for flutter because they might already have the plumbing to work with modular kernel files.

@jakemac53  dart-lang/sdk#33952 seems to be fixed.

Yes, we need to give that a chance to make its way into the flutter sdk as well - but I don't know the best way to track that :thinking:

we also need to update build_vm_compilers to use it first, which I can work on as soon as it is in a dev release which should be soon if one isn't already available

@jakemac53 friendly ping

We currently run flutter_tests from kernel today, though we don't use build_runner.

We can probably close this issue given that we are pretty much going in the opposite direction at this point for flutter at least. This is assuming the frontend_server has some way of sharing work across tests, otherwise build_runner may be better.

SGTM


cloudflare provider thoroughly breaks cdktf convert

Confirmation

[X] This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
[X] I have searched the issue tracker and my issue isn't already found.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.8.4
on darwin_amd64

provider registry.terraform.io/cloudflare/cloudflare v4.33.0
provider registry.terraform.io/hashicorp/aws v5.49.0
cdktf: 0.20.7

Affected resource(s)
all
Terraform configuration files
# Add a record to the domain
resource "cloudflare_record" "example" {
  zone_id = var.cloudflare_zone_id
  name    = "terraform"
  value   = "<IP_ADDRESS>"
  type    = "A"
  ttl     = 3600
}

# Add a record requiring a data map
resource "cloudflare_record" "_sip_tls" {
  zone_id = var.cloudflare_zone_id
  name    = "_sip._tls"
  type    = "SRV"

  data {
    service  = "_sip"
    proto    = "_tls"
    name     = "terraform-srv"
    priority = 0
    weight   = 0
    port     = 443
    target   = "example.com"
  }
}

Link to debug output
https://gist.github.com/infowolfe/599ecee5575b24ef3bdf01c32e78dd7c
Panic output
Adding package @cdktf/provider-cloudflare @ 11.11.0
Internal Error: unexpected array
Error: unexpected array
at Parser.renderAttributeType (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:205:23)
at Parser.renderAttributesForBlock (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:264:31)
at Parser.resourceFrom (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:124:31)
at ResourceParser.parse (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:466:33)
at /usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/provider-generator.js:94:121
at Array.map ()
at TerraformProviderGenerator.buildResourceModels (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/provider-generator.js:94:75)
at /usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/hcl2cdk/lib/index.js:93:31
at Array.reduce ()
at convertToTypescript (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/hcl2cdk/lib/index.js:91:79)
Collecting Debug Information...
/usr/local/lib/node_modules/cdktf-cli/node_modules/yoga-layout-prebuilt/yoga-layout/build/Release/nbind.js:53
throw ex;
^
Error: unexpected array
at Parser.renderAttributeType (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:205:23)
at Parser.renderAttributesForBlock (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:264:31)
at Parser.resourceFrom (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:124:31)
at ResourceParser.parse (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/resource-parser.js:466:33)
at /usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/provider-generator.js:94:121
at Array.map ()
at TerraformProviderGenerator.buildResourceModels (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/provider-generator/lib/get/generator/provider-generator.js:94:75)
at /usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/hcl2cdk/lib/index.js:93:31
at Array.reduce ()
at convertToTypescript (/usr/local/lib/node_modules/cdktf-cli/node_modules/@cdktf/hcl2cdk/lib/index.js:91:79) {
language: 'python',
__type: 'Internal'
}
Node.js v20.13.1
Expected output
cdktf should have given me the python code matching the example configfile for a cloudflare_record.
Actual output
see Panic output.
Steps to reproduce

install cdktf
create a project
add the cloudflare/cloudflare provider
try to convert some hcl to your favorite programming language

Additional factoids
Some of cloudflare's decisions with this provider are incredibly frustrating #2407.
The fact that I can't allow_overwrite=True without doing Fn.trimsuffix() is beyond belief (and causes a bunch of downstream headaches trying to work around it).
References
No response

thanks for the report!
we don't do anything specific for cdktf nor do we maintain anything related to it so i'd suggest chatting with the maintainers at https://github.com/cdktf/cdktf-provider-cloudflare or the cdktf core folks depending on what the specific bug you are hitting.
if you have specific improvements that come from those discussions, i'm happy to review PRs to get that working.

Ah, I wasn't explicitly using the prebuilt provider, so I'll ping them and raise this.


Error: resource name may not be empty

Expected Behavior
It should work
Actual Behavior
Complains in log:
{"level":"error","logger":"controller.taskrun-controller","caller":"controller/controller.go:345","msg":"Reconcile error","knative.dev/controller":"taskrun-controller","error":"resource name may not be empty","stacktrace":"github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).handleErr\n\t/workspace/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:345\ngithub.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).processNextWorkItem\n\t/workspace/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:331\ngithub.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).Run.func1\n\t/workspace/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:282"}

Steps to Reproduce the Problem

Add TaskRun

apiVersion: tekton.dev/v1alpha1
kind: TaskRun
metadata:
  name: git-mirror-run
spec:
  serviceAccount: git-mirror
  taskRef:
    name: git-mirror-task
  inputs:
    params:
      - name: srcRepo
        value<EMAIL_ADDRESS>      - name: destRepo
        value: git@github.com:foo/bar_common.git

Additional Info
Seems to be similar to https://github.com/tektoncd/pipeline/blob/master/examples/taskruns/private-taskrun.yaml. By now I am worried whether it is ensured, that all examples actually work.
It might be related to https://github.com/tektoncd/pipeline/issues/685.
Although this is a TaskRun that was created before - and has never been successfully run yet.
Even removing the TaskRun and creating anew (with different name) leads to the same problem.

@abergmeier thx for the issue. Can you attach the task definition used for the taskrun ?
There was some validation problems on the example, that are fixed by https://github.com/tektoncd/pipeline/pull/1081

/kind question

Can you attach the task definition used for the taskrun

There you go:
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: git-mirror-task
spec:
  inputs:
    params:
    - name: srcRepo
      description: The repo to pull from
    - name: destRepo
      description: The repo to push to
    - name: ws
      description: The workspace to use
      default: /workspace
  steps:
  - name: pull
    image: alpine/git
    command: ["sh"]
    args:
    - "-c"
    - "git -C ${inputs.params.ws} fetch --prune --all || git clone -n --mirror ${inputs.params.srcRepo} ${inputs.params.ws}"
  - name: push
    image: alpine/git
    command: ["git"]
    args: ["-C", "${inputs.params.ws}", "push", "--mirror", "${inputs.params.destRepo}"]

There was some validation problems on the example, that are fixed by #1081

If there is something wrong with the CRD, I cannot for the life of me figure it out :(

So I now boiled this down to:
---
apiVersion: tekton.dev/v1alpha1
kind: TaskRun
metadata:
  name: git-mirror-run1
spec:
  taskSpec:
    steps:
    - image: busybox
      command: ['/bin/sh']
      args: ['-c', 'sleep 3 && touch foo']

And still get the same error. So either the example is wrong, or this is not a question but a bug IMO.

I was curious and just manually ran that yaml you posted in the most recent comment and I don't think I got an error.
Are you still seeing
Message:               All Steps have completed executing
    Reason:                Succeeded
    Status:                True
    Type:                  Succeeded

when describing the taskrun?

The problem is probably related to some special handling in OpenShift.
For us we decided to no longer try to get Tekton running on OpenShift <=3.11 and instead rather go with Google Cloud Build.


Add catalogsConfigmapOverride

This to provide ability to use our own configmap for the catalogs instead of adding the catalogs inline in the values.yaml, for example :
catalogsConfigmapOverride: my-trino-catalog-configmap
Thanks.

@soft-titus can you rebase, and configure it in https://github.com/trinodb/charts/blob/main/test-values.yaml, so we can see if it works?

This is a good suggestion, but this PR is abandoned, so I'm closing it.


ref(controller): remove unused abstract exception class

pylint spit out some warnings for exceptions.py, and on further inspection I couldn't see anywhere the AbstractDeisException class was being called. less == more.

less == more.

Preach it, brother. Code LGTM.

At one point we had one exception utilizing this exception class, but I don't see it any more so it must've been cycled out. Code LGTM!


java.lang.RuntimeException: Error during attachToGLContext (see logcat for details)

webview_flutter: ^0.3.19+8
flutter version:
Flutter 1.12.13+hotfix.7-pre.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 0b8abb4724 (10 days ago) • 2020-02-11 11:44:36 -0800
Engine • revision e1e6ced81d
Tools • Dart 2.7.0

Hi @ithour
Which device you running this on?
Thank you

Hi @ithour
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore
reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any
more information for us; we will reopen it right away!
Thanks for your contribution.

huawei dub-al00 crash!

I encountered the same problem with huawei phones
My environment

Could everyone who still has this problem please file a new issue with the exact descriptions
what happens, logs and the output of 'flutter doctor -v' please.
All system setups can be slightly different so it's always better to open new issues and reference
related issues.
Thank you


Increase build command speed.

Currently it sets height everytime it generates a shard (takes longer then generating the shard). Add an option to set height every x shards (don't forget to always set the last time).
Possible do a binary search for resume point it case its continuing a build.

Added set_height_interval option to build command. By default it will set the height every 25 shards. RandomIO.read now seem to be the lowest component next to hashing the file.

Build will now also do a binary search for the resume point see filter_to_resume_point, this should speed things up quite a bit.


CI wait_clean function doesn't actually do anything

In the CI test.sh script, we call the cleanup_resources function followed by the wait_clean function.
...
source tests/common.sh

trap cleanup_resources EXIT

wait_clean
...

The wait_clean function checks 30 times effectively for the operator pod to not be running.
function wait_clean {
  for i in {1..30}; do
    if [ `kubectl get pods --namespace ripsaw | grep bench | wc -l` -ge 1 ]; then
      sleep 5
    else
      break
    fi
  done
}

However, the cleanup_resources function does not include commands to stop the operator pod.
function cleanup_resources {
  echo "Exiting after cleanup of resources"
  kubectl delete -f resources/crds/ripsaw_v1alpha1_ripsaw_crd.yaml
  kubectl delete -f deploy
  marketplace_cleanup
}

This results in the wait_clean function simply running through its 30 iterations, doing nothing.
I'm not entirely sure of the intention, so I don't want to propose a solution, but I will point out that the cleanup_operator_resources function is defined and does include the commands to delete the operator pod, but this function is not actually used anywhere.
function cleanup_operator_resources {
  delete_operator
  cleanup_resources
  wait_clean
}

wait_clean function doesn't just check for the operator pod to not be running, but it effectively waits for any pods that are still in terminating state. This is to provide a buffer time for all pods to safely terminate, before the next build begins on same executor, this is also why we start with a wait_clean when we start[1].
It's all to ensure that when we're checking for number of pods through check_pods we're actually getting the right count from just this build.
About cleanup_operator_resources function, it was defined to be made use of when running a full e2e tests without restarting operator pod, and it's used in the full_test.sh [2].
I hope that this clears up and gives an idea of why things were done in the above manner, it might not be the perfect way, but it was just to get the job done.
Since it's not necessarily a bug, I'm removing the label bug. Leaving the issue open for you to close when you feel that it's been resolved.
[1] https://github.com/cloud-bulldozer/ripsaw/blob/master/test.sh#L8
[2] https://github.com/cloud-bulldozer/ripsaw/blob/master/full_test.sh#L6

Still looks like a bug to me.
In this if statement from wait_clean:
if [ `kubectl get pods --namespace ripsaw | grep bench | wc -l` -ge 1 ]; then

The -ge 1 will always evaluate to true if the operator pod is running. If we expect the operator pod to not be running at this point, then we should be calling commands to stop it prior to running this if loop.
If we expect that the operator pod may be running, and it is OK for it to be running, then the function should be extended to check for that so that it can pass instead of waiting 30 retries.
I'm also curious why after we wait for 30 retries, we will simply pass and move forward instead of failing out.

We're not expecting that any pod may be running.

Then it seems to make sense to replace cleanup_resources with cleanup_operator_resources in the test.sh script so that we are explicitly deleting the operator pod before continuing.

That would cause issues as well, because operator pod is being deleted in the individual test already. So if it were to be deleted again, it'd throw an error. Thats the reason why we use cleanup_resources instead of cleanup_operator_resources

Closing this issue, as wait_clean() is not being used anymore following the merge of #120


Https Proxy: Support attaching managed ssl certs

Currently, we cannot create managed certs through gyro because the REST API does not have the ability to do so. Through the console though, one can be created. The https proxy should be updated so that the "sslCertificates" variable is a list of strings instead of ssl certificates, and those strings are self links to certificates.
This would allow me to create a GCP managed certificate in the console, update the gyro file with the self link, and have gyro not replace my managed cert.
To expand on managed certs not being supported in REST API, this link would need to have an attribute for "type" which can be set to managed, which it does not. Also, the docs to create them has no API tab.

The list of sslSertificateResource that the targetProxy accepts, can also handle supplying just the selfLink as that is the field annotated with @Id and is sufficient enough to fulfill the reference


v.0.1.1 release

Will you be releasing a prebuilt v0.1.1 dmg package?

Just released the v0.1.2 binary. Thanks!

https://github.com/nolze/tiny-wifi-analyzer/releases/tag/v0.1.2

Thank you @nolze !


Ports in use?

Great article, it would be nice to see what ports need to be open by ATA when using the gateway agent.  Tyipcally this would be in the architecture documenation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8aef862a-ca68-b031-0d7e-f34ba1e05600
Version Independent ID: 687b3e16-69ec-a0af-7ce8-db750bb4f1da
Content: Advanced Threat Analytics architecture
Content Source: ATADocs/ata-architecture.md
Product: advanced-threat-analytics
GitHub Login: @mlottner
Microsoft Alias: mlottner

@JamesFKoenig Thanks for the time to give us feedback. Typically, we list ports in the prerequisites and leave specific technical details out of the high level architecture articles. For Advanced Threat Analytics, port details are provided in the prerequisites like in other services. Would you also want to see a reference to port information in the architecture, or just a link letting you know where to find the information?

#please-close


Release/2.0.0

Description
I moved and renamed files to make it easy to find some templates and besides that, I implemented Digital Ocean app deployment and Docker image publish, and changed some tasks to be optional.
Type of change
Please delete options that are not relevant.

[x] :sparkles: New feature (non-breaking change which adds functionality)
[x] :boom: Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] :memo: This change requires a documentation update

How Has This Been Tested?
I executed a new CICD using the new features
Definition of Done

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Does this add new dependencies?

👌


add s2i metrics to exporter

Signed-off-by: soulseen<EMAIL_ADDRESS>

/cc @runzexia @magicsong

Add some docs to explain the fields?

Add some docs to explain the fields?

already have Help description.

/lgtm /approve

/lgtm
/approve


Deoplete gocode panicked

Updated NeoVim to latest version (0.1.5) and now gocode panics, not sure if deoplete-go is using it incorrectly or something with gocode itself.
gocode and deoplete-go is latest version as well.

Solved issue, had to restart gocode daemon:
gocode close


icon does not appear

Hi sorry, please help because the icon does not appear.
thanks.

The icons are loaded from a CDN so make sure you're connected to the internet when using the theme.


How to get bots to dm someone?

Please describe the problem you are having in as much detail as possible:
Include a reproducible code sample here, if possible:

Further details:

discord.js version:
node.js version:
Operating system:
Priority this issue should have – please be realistic and elaborate if possible:

[ ] I found this issue while running code on a user account
[ ] I have also tested the issue on latest master, commit hash:

The issue tracker is only for bug reports and enhancement suggestions. If you have a question, please ask it in the Discord server instead of opening an issue – you will get redirected there anyway.


WASM Default Verify Function

WASM Default Verify Function
Description
Fixes #760. When using the Cairo verifier with WASM, one must provide Proof Options. This PR adds another method, verify_cairo_proof_wasm_100_bits, that allows verification of a proof with an automatic 100 conjectured bits of security set for the Proof Options.
Type of change
Please delete options that are not relevant.

[ ] New feature
[ ] Bug fix
[x] Optimization

Checklist

[x] Linked to Github Issue
[ ] Unit tests added
[ ] This change requires new documentation.

[x] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eb12381) 95.36% compared to head (0037a1b) 95.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   95.36%   95.36%
=======================================
  Files         140      140
  Lines       31393    31393
=======================================
  Hits        29938    29938
  Misses       1455     1455

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Meta-actions

It might be cool for Actors to conduct "Meta-actions", e.g. subscribing to another Actor // removing subscriptions. Could also involve meta-questions (give me all actors I can subscribe to or something like that). Currently we do support sending actions to other actors, but no real way for an agent to control subscriptions (subscriptions are managed when creating the environment).

With the implementation of emits in version 0.1.0 this is actually possible. Implement receive! logic for specific entity combinations and make sure to implement the correct emits logic


Add two usefull tools for normalization and imputation in single-cell analyses

scPLS and VIPER

Thanks, and welcome to the contributor club!


Cannot reset value unless truthy

I think this line should be:
https://github.com/christianalfoni/formsy-react/blob/master/src/main.js#L145
if (data && data.hasOwnProperty(name)) {

Yes, that makes sense

Fixed in 6767a6b9eba9c0a7c255c46ce2d6f84dc69eeeb4


in renaming cases, if node has > 1 identifier child, all get renamed

For instance, with PropertyAssignments, we just want to rename name.
 interface PropertyAssignment extends ObjectLiteralElement {
        _propertyAssignmentBrand: any;
        name: DeclarationName;
        questionToken?: Node;
        initializer: Expression;
    }

original:
function getFileAndName(): { fileName: string, qname: string } {
    var fileName = 'hello';
    var blah = 'world';
    return { fileName, qname: blah };
}

renaming:
function getFileAndName(): { $: string, _: string } {
    var fileName = 'hello';
    var blah = 'world';
    return { fileName, _: a };
}

blah gets renamed to a even though it is not a property name because it is an identifier node.
in a PropertyAssignment:
initializer: Expression; but Expression might be an Identifier
Possible fix: Check if (<any>node).name exists, if so, compare to child. If node.name === child, we can rename?

Proposed fix:
let hasName = (<any>node).name;
      if (renameIdent && child.kind === ts.SyntaxKind.Identifier && hasName === child) {
        childText = this._renameIdent(child);
      } else {
        childText = this.visit(child);
      }

As discussed object literal destructuring cannot be handled well, because it contains a property declaration or access (things we rename) and a local variable expression (something we leave to uglifyJS).
var {a} = foo;

is sugar for
var a = foo.a;

which should be renamed to
var a = foo.$

but there is no way to do that while keeping the sugar.
Similarly for property declaration {a} is sugar for {a: a} and we rename that to {$: a}. For now I suggest we detect these and throw an error.


Design Analytics Artist View

Design the artist view for the analytics application.

The same as the normal library view with a filter applied.


Testing arity of functions no longer works

🐛 Bug Report
After the introduction of this commit, testing array-like structures and function arities no longer works with .toHaveLength. This used to behave correctly previously.
To Reproduce
Pass in a function as the argument to .toHaveLength
const myFunction = require('./my-function');

test('should return a function of arity 2', () => {
  expect(typeof myFunction).toBe('function');
  expect(myFunction).toHaveLength(2);
});

Test will fail with:
 FAIL  src/feature/my-function.test.js
  ● should return a function of arity 2

    expect(received).toHaveLength(expected)

    Matcher error: received value must have a length property whose value must be a number

    Received has type:  function
    Received has value: [Function myFunction]

Expected behavior
Test should pass. Also the returned error message ("have a length property whose value must be a number") is rather misleading as the argument being passed clearly conforms to that description. This is a breaking change in a minor release.
envinfo
  System:
    OS: macOS 10.15.4
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
  Binaries:
    Node: 12.16.1 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm

Also, since this was a breaking change introduced as a minor bump in a transitive dependency on the expect package, downgrading jest version to 25.2.7 does not resolve the problem. According to the changelog should not contain https://github.com/facebook/jest/pull/9626/files#diff-99739ad11655a4534ce3ab4222dbddbcR633 - but does.

Did you make sure expect was downgraded? It's in semver range

/cc @G-Rath, typeof function has a length property

@nfantone I'd personally find such an assertion a bit confusing, I'd recommend a toHaveArity that only accepted functions. It shouldn't have broken of course

Yeah that's fair enough - sorry about that.
TypeScript knows that functions have .length, so it's just a matter of adjusting the guard.
(I'm looking forward to having in be a guard someday so we can just do 'length' in x for things like this and call it a day 😬)

@SimenB

Did you make sure expect was downgraded? It's in semver range

I know it is - that's why downgrading jest didn't solve the issue. But the thing here is: I believe users shouldn't care. We don't typically install expect individually. We use jest as a module. You go to the release notes and you'd expect (no pun intended) things listed there to be true for jest as a tool. Which is not the case even though that clearly how it is laid out. There is no mention of expect anywhere in there.

I'd personally find such an assertion a bit confusing, I'd recommend a toHaveArity that only accepted functions. It shouldn't have broken of course

I understand where you're coming from. And I agree: having a .toHaveArity matcher would be nice, semantically speaking! But at the end of the day, .toHaveArity would just be a duplicate of .toHaveLength and me and the team don't find that to be confusing at all. The concept of arity and function length are synonymous in the JS world (and have always been); albeit with some quirks.
@G-Rath

Yeah that's fair enough - sorry about that.
TypeScript knows that functions have .length, so it's just a matter of adjusting the guard.

Hey, no need to apologise at all! Great work contributing to an awesome project like jest. Keep at it. And thanks for the PR!


Cannot interact with Modal if called from a Popover on iOS - V2 RC4

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x  RC4
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
I have one modal which is called from various places to edit some data. It works all of the time unless it's presented from within a popover. From the popover 1) it takes two clicks to open the modal and 2) once the modal is open, I cannot interact with any elements on that page. Scrolling still works, and I can click back in the header, but I cannot touch or click on anything else.
This issue is specific to being ran on a device, iPhone 6 in this case, it works normally in all scenarios when running on desktop browser.
Expected behavior:
I would expect a Modal, when presented from a Popover, to behave normally just like it is when presented from any other page.
Steps to reproduce:
Unfortunately I cannot reproduce since the issue does not present itself when running in a browser, only on device. However, it is consistently misbehaving whenever ran on device. To reproduce simply;

From any page present a Popover
With that Popover have a link which presents a Modal
Throw a button on that Modal
Try to click that button, on that Modal, when presented from a popover

Related code:
Nothing interesting or out of the ordinary in my code but below lists the popover and modal present options. I have a selector to display the filter icon, on-click it displays the popover, then an on-click element inside the popover presents the modal.
Present Popover
    displayFilters(e) {
      this.popoverCtrl.create(FiltersPopover, {filters: this.filters, applyFilters: this.applyFilters, resetFilters: this.resetFilters}).present({
        ev: e
      });
    }

Present Modal
  selectType() {
    let typesModal = this.modalCtrl.create(TypesModal, {type:this.filters.selectedType, isSelector:true});
    typesModal.present();
    typesModal.onDidDismiss(data => {
      if(data) this.filters.selectedType = data;
    });
  }

And the modal itself is pretty brainless, just a little ngFor with (click) events on the elements.
Other information:
To repeat; this issue does not occur when testing on desktop browser. It only happens on the actual device (same exact code being ran of course).
I have tried to track down the problem since I'd guess it's z-index related, to no avail - tried to add z-index:99999 !important to modal in question. Also tried to trace around what was going on with backdrop or whatever.
Based on my preliminary investigations it's looking like the popover-overlay is capturing all clicks from the modal instead of allowing the click events to register on the modal.
I'd be content enough to just use nav.push(view) instead of displaying the modal; however, as you can see in the code snippet above I am passing data back via dismiss and catching on onDidDismiss, which is required, and I can't see an easy path to restructure to allow the desired functionality.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.47
ios-deploy version: 1.9.0
ios-sim version: 5.0.9
OS: macOS Sierra
Node Version: v6.2.0
Xcode version: Xcode 8.2.1 Build version 8C1002

Update- issue is still exactly as I described. I was able to still get desired behavior with the mentioned workaround, pushing view instead of displaying as modal and catching data with eventEmitter. Code below incase anyone else needs it. With this setup is works fine sometimes as a modal and sometimes as a pushed view, I just pass in a param for isFromViewPush and route accordingly. Still thing it's a bug that should be fixed though...
Present the Modal (or now, push the View)
    // setup emitter
    var typeEmitter = new EventEmitter<Type>();
    // subscribe
    typeEmitter.subscribe(data => {
      if(data) this.filters.selectedType = data;
    })
    // push the view
    this.navCtrl.push(TypesModal, {type:this.filters.selectedType, isSelector:true, isFromViewPush:true, eventEmitter: typeEmitter});

Handle the selection and pass back data
    if(this.isFromViewPush) {
      this.typeEmitter.emit(type);
      this.navCtrl.pop();
    }
    else this.viewCtrl.dismiss(type);

Hello, thanks for using Ionic! Did this work in RC3? The issue is most likely that the modal is being presented from the root nav of the popover instead of the root navcontroller.

@jgw96 Hey I'm not sure about RC3, was building in browser on RC0 and jumped to RC4 when I started testing on device. Makes sense about the navcontroller, maybe could have navcontroller get pulled in from the presenter's scope instead of using root nav. P.S. even with the bugs here and there y'all have really made an amazing framework!

I confirmed this issue using 2.0.0 and launching the ScheduleFilterPage from the AboutPopover. This is the rule preventing clicks:

hi, have you got some news on this issue ? i'm using some popover instead of a modal to bypass this problem but I really want to use the modal view.
Thanx !

Any known workarounds to this? Or other updates?

hi there again, no news ?

I added the below to app.scss.
.disable-scroll .ion-page {
    pointer-events: auto;
}

It works and no side-effects are found yet.
Does anyone know any possible side-effects for this workaround?

@sim0629 this worked for me . Any news on the side effects ?

This has been an issue for me as well. @sim0629 's fix is working for me without any ill-effects so far.
The only change I made was to specify that the css change only is in effect on ios devices
 .ios.disable-scroll .ion-page {     pointer-events: auto; }

I m facing this issue with Ionic 3 as well.
Ionic info :
ionic/cli-utils : 1.19.0
ionic (Ionic CLI) : 3.19.0
Node : v6.11.5
npm : 3.10.10
OS : macOS Sierra

I added the css below to my app.scss.
.disable-scroll .ion-page {
    pointer-events: auto;
}

It works and no side-effects are found yet.
Does anyone know any possible side-effects for this workaround?

When the Popover is presented, the background Page becomes scrollable with this change.


multiple different kernels running on the Alevo card

excuse me, has anyone done a similar project using vitis ?
i want to make an application project about muti_different kernels on the Alevo card.
i hve tried to make it.  it didn't show some errors about src. However, it failed to build Emulation-SW.
i don't know how to deal with it.
do you have some demo about this? thanks a lot.

Hi,
you can use the following designs as reference where multiple kernels are running.

concurrent_kernel_execution
https://github.com/Xilinx/Vitis_Accel_Examples/tree/master/host/concurrent_kernel_execution

kernel_swap
https://github.com/Xilinx/Vitis_Accel_Examples/tree/master/sys_opt/kernel_swap

Thanks,
Vishnu


java.sql.SQLException: Catalog can not be null when closing a connection with explicit catalog

This is the question that I have posted on SO and I feel that it might be a HIkariCP issue :)
I'm trying to use HikariCP in a java app to implement connection pooling to MySQL.
Because of a DB design flaw, the app uses different databases and I have to explicitly call connection.setCatalog() to change the database when needed.
When I try to close the connection that uses the default database (with no call to setCatalog() ) everything is fine and the connection returns back to the pool. But If this is a connection to another database (using setCatalog()) I get the following exception when I call close() method:
java.sql.SQLException: Catalog can not be null
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1074)
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:988)
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:974)
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:919)
at com.mysql.jdbc.ConnectionImpl.setCatalog(ConnectionImpl.java:5324)
at com.zaxxer.hikari.pool.PoolElf.resetConnectionState(PoolElf.java:263)
at com.zaxxer.hikari.pool.PoolBagEntry.resetConnectionState(PoolBagEntry.java:122)
at com.zaxxer.hikari.proxy.ConnectionProxy.close(ConnectionProxy.java:193)
at someapp.repository.MySqlRepository.closeConnection(MySqlRepository.java:198)...
Needless to say that I have checked if the catalog is null:
public void closeConnection() throws SQLException{
System.out.println("trying to close with catalog:"+connection.getCatalog());
    if(connection!=null){

    //connection.setCatalog("defaultdb");
        connection.close();

    }
    this.connection=null;
}

If I uncomment the the connection.setCatalog("defaultdb") to set the catalog back to the default, the problem still persists.
The only situation where everything is fine is when I don't use setCatalog() method at all.
Is this an issue with hikaricp when the catalog is explicitly set? Is there a way to close the connection and send it back to the pool?

@danrah You shouldn't need to do this at all.  Set the catalog property in the configuration.

and how to change the catalog at runtime?

Just as you would normally, call setCatalog().  No matter what you set
the catalog to, when you close the Connection HikariCP will automatically
reset the catalog to the default defined in the configuration.


How to handle retries?

Hi there!
Our app have some flaky specs and we are retrying using --only-failures to retry just the flaky specs, which in general just works.
We are generating the junit.xml in the first try and then if a spec fails, we run the failed specs again a second time without it but this creates an issue where the CI interfaces says that the build didn't pass (because there are failed specs in the XML) but actually it did pass.
When that happens, we need to look at the build exit status to confirm if it failed or not.
What you think about updating/integrating with the --only-failures to update the previous XML somehow to make the interface more reliable?
PS: We can't use rspec-retry because we to do some cleanup between the retries and also looks more reliable to use the native --only-failures than a 3rd gem.

This is intentionally a pretty simple formatter and doesn't attempt to read or compose with existing results.
I'd suggest creating separate output files and merging them together afterwards.


Release 0.11.1 ?

@marijnh I would like to know when you think you could create a release for tern 0.11.1?
I would like to create a release for https://github.com/angelozerr/tern-lint and https://github.com/angelozerr/tern-browser-extension, but I need https://github.com/marijnh/tern/issues/557 and https://github.com/marijnh/tern/pull/550
Thanks!

I've just tagged 0.12.0 and pushed it to NPM.

Many thanks @marijnh !


Reset() doesn't properly re-initialize internal variables

I'm building a hot plate for SMD soldering with a k-type thermocouple and a plate heater controlled by a SSR. I use a relay-like control for the SSR, with 2 sec window and the SSR on for a fraction of that time. I built an Arduino program to auto tune my physical setup. Here's the simplified version
//user settings. PWM cycle is 2 seconds, 0-100% is 0-2000
const uint32_t testTimeSec = 600;
float outputStart = 200;     // 10% start
float outputStep = 400;   // 20% step
const uint16_t samples = 600;
const uint32_t settleTimeSec = 300; //5 minutes to settle

float Input = 0, Output = 0, Setpoint = 30, Kp = 0, Ki = 0, Kd = 0;

void setup()
{
sTune tuner = sTune(&Input, &Output, tuner.zieglerNicholsPID, tuner.directIP, tuner.printALL);
  tuner.Configure(outputStart, outputStep, testTimeSec, settleTimeSec, samples);
  reflowStatus = REFLOW_STATUS_ON;
  Output = outputStart;
  /*while (true)
  {
    lcd.setCursor(0, 1);
    lcd.print(analogRead(A0));
    lcd.print("    ");
  }*/
}

void loop()
{
  // Current time
  unsigned long now;

  switch (tuner.Run())
  { // active while sTune is testing (non-blocking)
  case tuner.inOut:
    // Time to read thermocouple?
    if (millis() > nextRead)
    {
      // Read thermocouple next sampling period
      nextRead += SENSOR_SAMPLING_TIME;
      // Read current temperature
      Input = thermocouple.readCelsius();
    }
    break;

  case tuner.tunings:                                         // active just once when sTune is done
    tuner.SetAutoTunings(&Kp, &Ki, &Kd);                      // sketch variables are updated by sTune
    outputStart += 200;
    outputStep += 200;
    if (outputStep > 2001)
    {
      digitalWrite(ssrPin, LOW);
      Serial.println("end");
      while (true) {}
    }
    Output = outputStart;

    tuner.Reset();
    tuner.Configure(outputStart, outputStep, testTimeSec, settleTimeSec, samples); // restart autotune
    break;
  }

  // SSR control
    now = millis();
    if ((now - windowStartTime) > windowSize)
    {
      // Time to shift the Relay Window
      windowStartTime += windowSize;
    }
    if (Output > (now - windowStartTime))
      digitalWrite(ssrPin, HIGH);
    else
      digitalWrite(ssrPin, LOW);
  }
}

As it's now. the loop runs once, and when I try to reset the autotuner to create a step response for different PWM value, it exits immediately without a settling period nor a full analysis.
In order to make it work for me, I need to change the Reset function into
void sTune::Reset() {
  _Ku = 0.0f;
  _Tu = 0.0f;
  _td = 0.0f;
  _kp = 0.0f;
  _ki = 0.0f;
  _kd = 0.0f;
  _tunerStatus = inOut;
  usPrev = micros();
  settlePrev = micros();
  pvTangentPrev = 0;
  dtCount = 0;
  ipCount = 0;
  plotCount = 0;
  sampleCount = 0;
  pvPkCount = 0;
}

I'm not sure if all of those are needed, but there are a lot of internal variables that are initialized to 0 only when declared, so the second time sTune is invoked, those have the previous values. I didn't want to fully unravel all your code to see which ones really needed to be changed, so I simply reset to 0 (or the right values) all the internal variables that are declared = 0 in your code (lazy, I know :)
Also, your example code only works if the Arduino is restarted and sTune is called before a long enough time has elapsed, since it assumes that usPrev and settlePrev are close enough to 0 when sTune is called. By adding   usPrev = micros(); and   settlePrev = micros(); in the Reset() function, it works even as part of a cycle like in my case. Otherwise, if those are not initialized properly on reset(), this line of code simply skips the settling time  if (settleElapsed >= _settlePeriodUs) {           // if settling period has expired

Running multiple tests shouldn't be too difficult to implement ... I'll make this high priority for the next release (soon). Thanks for the simplified code and comments (very helpful).

resolved in sTune 1.1.0


Change sorting preference

When I open the LinkedIn feed, I would like the feed to be automatically sorted according to my preference - either Top or Recent.
Manually this is done on desktop LinkedIn by switching the sort dropdown (class="sort-dropdown__icon"). It seems that the selected value is stored for some time in a cookie named feed-sort with values feed (top) or chronFeed (recent).
The extension might do the switch if the preference stored in the extension would be different than the currently selected value. On the other hand, if the current sorting would be equal to the one set in the extension, the extension should not change anything regarding the sorting.

Simply setting the cookie to the correct value works, but the UI updates only after reload.
document.cookie = "feed-sort=chronFeed"
The cookie can be made to not expire by adding properties.
An alternative, or maybe addition to this would be automatically triggering the change to recent.
That would go something like this
// If cookie doesn't match the setting in extension
document.querySelector('button[data-control-name="feed_sort_dropdown_trigger"]').click();

// If setting is top
document.querySelector('button[data-control-name="feed_sort_toggle_relevance"]').click();
// If setting is recent
document.querySelector('button[data-control-name="feed_sort_toggle_chron"]').click();


Issue with retraining interactive learning

Rasa Core version:
0.11.12
Python version:
Python 3.6.5
Operating system (windows, osx, ...):
MacOS
Issue:
I am using the quickstart bot provided in the rasa core documentation and running interactive learning on it. I am also using a corresponding nlu model for the intents for it. After running a few iterations I stop and export the stories.md file which is correctly updated and appended as well.
Now if I try retraining the model I am thrown with this error:
Samarths-MacBook-Pro:axio_bot samarth$ python -m rasa_core.train   --online -o models/dialogue   -d domain.yml -s stories.md   --endpoints endpoints.yml --nlu models/current/nlu
/anaconda3/lib/python3.6/site-packages/h5py/init.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
:0: UserWarning: You do not have a working installation of the service_identity module: 'No module named 'service_identity''.  Please install it from https://pypi.python.org/pypi/service_identity and make sure all of its dependencies are satisfied.  Without the service_identity module, Twisted can perform only rudimentary TLS client hostname verification.  Many valid certificate/hostname mappings may be rejected.
/anaconda3/lib/python3.6/site-packages/rasa_nlu/extractors/entity_synonyms.py:85: UserWarning: Failed to load synonyms file from 'models/current/nlu/entity_synonyms.json'
"".format(entity_synonyms_file))
2018-10-15 10:18:12.544627: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
INFO:tensorflow:Restoring parameters from models/current/nlu/intent_classifier_tensorflow_embedding.ckpt
2018-10-15 10:18:12 INFO     tensorflow  - Restoring parameters from models/current/nlu/intent_classifier_tensorflow_embedding.ckpt
/anaconda3/lib/python3.6/site-packages/pykwalify/core.py:99: UnsafeLoaderWarning:
The default 'Loader' for 'load(stream)' without further arguments can be unsafe.
Use 'load(stream, Loader=ruamel.yaml.Loader)' explicitly if that is OK.
Alternatively include the following in your code:
import warnings
warnings.simplefilter('ignore', ruamel.yaml.error.UnsafeLoaderWarning)
In most other cases you should consider using 'safe_load(stream)'
data = yaml.load(stream)
Processed Story Blocks:   0%|               | 0/5 [00:00<?, ?it/s, # trackers=1]Traceback (most recent call last):
File "/anaconda3/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/anaconda3/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/anaconda3/lib/python3.6/site-packages/rasa_core/train.py", line 239, in
additional_arguments)
File "/anaconda3/lib/python3.6/site-packages/rasa_core/train.py", line 185, in train_dialogue_model
training_data = agent.load_data(stories_file, **data_load_args)
File "/anaconda3/lib/python3.6/site-packages/rasa_core/agent.py", line 472, in load_data
debug_plots)
File "/anaconda3/lib/python3.6/site-packages/rasa_core/training/init.py", line 57, in load_data
return g.generate()
File "/anaconda3/lib/python3.6/site-packages/rasa_core/training/generator.py", line 282, in generate
trackers = self._process_step(step, incoming_trackers)
File "/anaconda3/lib/python3.6/site-packages/rasa_core/training/generator.py", line 477, in _process_step
tracker.update(event)
File "/anaconda3/lib/python3.6/site-packages/rasa_core/training/generator.py", line 136, in update
self._append_current_state()
File "/anaconda3/lib/python3.6/site-packages/rasa_core/training/generator.py", line 106, in _append_current_state
self._states.append(frozenset(state.items()))
AttributeError: 'NoneType' object has no attribute 'append'
I am not sure why this is happening. By my understanding, if I retrain the model again interactive learning should be infulenced by the changes I made last time right? If some intent for misclassified it should get it right with a better confidence after the retrain? Please corrent me if I am wrong.
Here is the command I running to train the basic quickstart bot:
python -m rasa_core.train   --online -o models/dialogue   -d domain.yml -s stories.md   --endpoints endpoints.yml --nlu models/current/nlu
Content of domain file (if used & relevant):

domain.yml
intents:
  - greet
  - goodbye
  - mood_affirm
  - mood_deny
  - mood_great
  - mood_unhappy

actions:
- utter_greet
- utter_cheer_up
- utter_did_that_help
- utter_happy
- utter_goodbye

templates:
  utter_greet:
  - text: "Hey! How are you?"

  utter_cheer_up:
  - text: "Here is something to cheer you up:"
    image: "https://i.imgur.com/nGF1K8f.jpg"

  utter_did_that_help:
  - text: "Did that help you?"

  utter_happy:
  - text: "Great carry on!"

  utter_goodbye:
  - text: "Bye"

Please let me know if you need any further details, thank you!

Thanks for raising this issue, @tmbo  will get back to you about it soon.

happy path

greet

utter_greet

mood_great

utter_happy

sad path 1

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_affirm

utter_happy

sad path 2

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_deny

utter_goodbye

say goodbye

goodbye

utter_goodbye

Generated Story -2569380633689073020

greet

utter_greet

mood_unhappy{"person": "I"}

action_default_fallback
rewind

mood_unhappy{"person": "I"}

action_default_fallback
rewind

The new stories are being appended to the stories file, but I have tried this multiple times with different combinations as well. Gives me the same error unless I refresh the stories to the default stories. This story is just a random generation if the story matters in retraining it I would be happy to provide you with a perfectly logical story as well. But I think that shouldn't be the issue.
Thank you for such a swift response!

Just a little update: If I remove the lines appended to stories.md after running an iteration of interactive learning, it runs completely fine just as normal.

happy path

greet

utter_greet

mood_great

utter_happy

sad path 1

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_affirm

utter_happy

sad path 2

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_deny

utter_goodbye

say goodbye

goodbye

utter_goodbye

Generated Story<PHONE_NUMBER>240434445

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_affirm

utter_happy

goodbye

utter_goodbye

None

action_default_fallback
rewind

Here is another iteration where I followed an existing story path while interacting. It still gives me the same error.

Why was this issue closed? I'm still getting the same error under identical conditions.

@larsmehrtensef21 make sure the stories you develop through interactive learning make sense, else it throws an error. Like in the above example, leaving a story at default_fallback or rewind action would not work.
Also, naming new intents doesn't seem to work sometimes. These are things I discovered through multiple iterations of testing.

@samarth12 are there other open issues for these points? just want to make sure we keep track of them and fix them

The problem seems to be the action

rewind

in the generated story. If you delete "rewind" from your stories, the error
'NoneType' object has no attribute 'append'
while training will disappear.


range fields not initialised to min value

the range fields should have value set to min value.

ideally the survey designer would enable user to specify a default value.
for now though have made the default value the min value.


PROG: Refactor deserialize and fix inactive code

This is a follow-up to #4500, #4509, #4518, #4567

Split ZCL_ABAPGIT_OBJECTS_PROGRAM->DESERIALIZE_PROGRAM into smaller methods
INSERT_PROGRAM now uses standard RPY_PROGRAM_INSERT and only does INSERT REPORT in exceptional cases like function groups (see below)
Special case of Code Inspector variants is handled by ZCL_ABAPGIT_OBJECT_PROG->DESERIALIZE_WITH_EXT since these aren't actual programs (but includes containing data)

Using the standard function fixes the issue of inactive code that can't be accessed after a pull. This used to happen, for example, when a program contained syntax errors.
Closes #4567

thanks 👍


Total lack of docs

Given the complexity of this cmdlet, having NO documentation for any of the parameters isn't helpful. The parameters listed are just common ones, what does "CompanyName" for example do in the case of a WSS migration??

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5d569cd-4428-2d98-4353-ebe47443b1a8
Version Independent ID: 3793f067-254d-1fca-7e0f-28be94d3f122
Content: Start-WssConfigurationService (wsssetup)
Content Source: docset/winserver2012r2-ps/wsssetup/Start-WssConfigurationService.md
Product: powershell
Technology: powershell
GitHub Login: @andreabarr
Microsoft Alias: v-anbarr

The page now has complete descriptions of all cmdlet parameters.
There has been an ongoing effort for quite a long time to provide with the missing descriptions on some cmdlets similar to this one.
Thanks for bringing this to attention, and stay well and safe.


.notice bug

I can't seem to find why '.notice [target] [message]' is not working.

fixed in version 0.7.4+