[Improve][Connector-V2][Iceberg] Support for S3 in hadoop catalog

Purpose of this pull request
We use S3 as iceberg warehouse storage.
If catalog_type is hadoop, only hdfs is supported, so it is being customized and used.
I want to contribute my customized code, so I push a pull request.
Does this PR introduce any user-facing change?
we can use the iceberg table saved in s3.
config example
source {
  iceberg {
    catalog_name = "seatunnel"
    catalog_type = "hadoop"
    warehouse = "s3a://your_bucket/spark/warehouse"
    namespace = "your_iceberg_database"
    table = "your_iceberg_table"
    result_table_name = "iceberg_test"
    fs.s3a.endpoint = "xxx"
    fs.s3a.aws.credentials.provider = "org.apache.hadoop.fs.s3a.SimpleAWSCredentialsProvider"
    access_key = "xxx"
    secret_key = "xxx"
    bucket = "s3a://xxx"
    hadoop_s3_properties {
      "fs.s3a.path.style.access" = "true"
      ...
      "fs.s3a.connection.timeout" = "3000"
    }
  }
}

How was this patch tested?
After downloading the seatunnel 2.3.3 binary file, I created an iceberg_to_console.conf config file and tested running the script below.
cd apache-seatunnel-2.3.3
./bin/start-seatunnel-spark-3-connector-v2.sh \
--master "local[4]" \
--deploy-mode client \
--config ./config/iceberg_to_console.conf

I don't know how to do the e2e test.
So, I ran a maven test as shown below, but an error message occurred and I could not proceed.
mvn -pl :connector-iceberg-e2e -Dtest=IcebergSourceIT test

error message
Could not resolve dependencies for project org.apache.seatunnel:connector-iceberg-e2e:jar:2.3.4-SNAPSHOT: Failed to collect dependencies at org.apache.seatunnel:connector-assert:jar:2.3.4-SNAPSHOT

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

cc @ic4y

Shall we add a test case for this feature?

I don't think it's going to be easy because it requires an S3 bucket.

I think we can create a minio container in e2e test case for s3a file read.

@EricJoy2048
Thank you so much for the review.

I made an additional commit today by adding the e2e test case.
However, your previous review was automatically dismissed by the system.
I apologize for that.

I think we can create a minio container in e2e test case for s3a file read.

I created minio test container and added e2e test case.
It passes on spark3, but fails on flink/seatunnel/spark2.
I think I need to add hadoop-aws/aws-java-sdk jar file to the test container docker image and need your help.

spark2 : hadoop-aws-2.7.5, aws-java-sdk-1.7.4

I'm also looking to see if there are other workarounds.

Thanks @4chicat , I will take a look in the few days.

Thanks @4chicat , I will take a look in the few days.

I modified to only run e2e tests for seatunnel engine and spark 3.3. (except flink and spark 2.4)

@Hisoka-X  @ic4y  PTAL.
@Carl-Zhou-CN  @liugddx

Look like this PR bring new leak thread in seatunnel server. Can you try closing these leaking threads? If not, please add it to the known issues list. https://github.com/apache/seatunnel/blob/92f847c99f219077b4d45c25d2b379d42879f613/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/seatunnel/SeaTunnelContainer.java#L291

This PR is very valuable and I think we need to look at it again and review it.

I think we can create a minio container in e2e test case for s3a file read.

I created minio test container and added e2e test case. It passes on spark3, but fails on flink/seatunnel/spark2.
I think I need to add hadoop-aws/aws-java-sdk jar file to the test container docker image and need your help.

spark2 : hadoop-aws-2.7.5, aws-java-sdk-1.7.4

I'm also looking to see if there are other workarounds.

Like the driver, you can add hadoop-aws and aws-java-sdk to the test container docker like seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-oss-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/oss/OssFileIT.java
@TestContainerExtension
    private final ContainerExtendedFactory extendedFactory =
            container -> {
                Container.ExecResult extraCommands =
                        container.execInContainer(
                                "bash",
                                "-c",
                                "mkdir -p /tmp/seatunnel/plugins/oss/lib && cd /tmp/seatunnel/plugins/oss/lib && curl -O "
                                        + OSS_SDK_DOWNLOAD);
                Assertions.assertEquals(0, extraCommands.getExitCode());

                extraCommands =
                        container.execInContainer(
                                "bash",
                                "-c",
                                "cd /tmp/seatunnel/plugins/oss/lib && curl -O " + JDOM_DOWNLOAD);
                Assertions.assertEquals(0, extraCommands.getExitCode());

                extraCommands =
                        container.execInContainer(
                                "bash",
                                "-c",
                                "cd /tmp/seatunnel/plugins/oss/lib && curl -O "
                                        + HADOOP_ALIYUN_DOWNLOAD);
                Assertions.assertEquals(0, extraCommands.getExitCode());

                extraCommands =
                        container.execInContainer(
                                "bash",
                                "-c",
                                "cd /tmp/seatunnel/lib && curl -O " + OSS_SDK_DOWNLOAD);
                Assertions.assertEquals(0, extraCommands.getExitCode());

                extraCommands =
                        container.execInContainer(
                                "bash", "-c", "cd /tmp/seatunnel/lib && curl -O " + JDOM_DOWNLOAD);
                Assertions.assertEquals(0, extraCommands.getExitCode());

                extraCommands =
                        container.execInContainer(
                                "bash",
                                "-c",
                                "cd /tmp/seatunnel/lib && curl -O " + HADOOP_ALIYUN_DOWNLOAD);
                Assertions.assertEquals(0, extraCommands.getExitCode());
            };


Bug: Parent Transform dropdown arrow disappears in Context-sensitive Prefab Mode

Unity Version 2020.3.0
Describe the bug
Parent Transform dropdown arrow disappears in Context-sensitive Prefab Mode.
To Reproduce (If applicable)

Create a new prefab
Create some objects in the prefab
Give the last object in the prefab one or more children
Drag the Prefab into the scene and open it in context-sensitive mode
The last object (containing some children) does not appear to have any children, and can only be opened with Right Arrow

Ah I can't believe this got past me...
Will fix this later today, shouldn't take too long.
Due to how I handle checks for drawing the foldouts again, I think I know what the issue is
Cheers,
Wooshii

This should be fixed in v<IP_ADDRESS> 🙂
If there are any follow up issues with foldouts I'll reopen this with a link to the created issues.
Thanks,
Wooshii


why three special token is ignored in label

The label just consists of image token, with the special token <|image start|> ignored. Why compute sft loss like this?

This might partly answer the question: https://github.com/baaivision/Emu3/blob/main/emu3/mllm/processing_emu3.py#L178-L183
During inference, the boi_token (which is "<|image start|>" in string form), the resolution information, and the img_token (which is "<|image token|>") are directly provided as a starter for the generation. (BTW, the mismatch between the string form and the variable naming is confusing and annoying, lol)
That said, i am also curious why the authors limited the supervision to the first visual token id and the last visual token id, while ignoring eol_token, eof_token, and eoi_token.


Screenshot urls are not matching in pabot logs

When executing browser extension with pabot, screenshot url includes pabot process id (e.g. 0 or 1) and url in log.html doesn't contain this pabot prosess id.
Workspace file: 1-TC1_FAILURE_SCREENSHOT_1.png
Url in log.html: TC1_FAILURE_SCREENSHOT_1.png
To Reproduce
Steps to reproduce the behavior:

Execute test case which fails by using pabot

Expected behavior
Url in log.html should match with workspace file
Screenshots
Desktop (please complete the following information):

OS: robotframework-browser docker container and same behavior in macOS 10.15.7
Browser [chromium]
robotframework-browser: 3.0.0.

I was comparing results to pabot with selenium hub+nodes setup and there are screenshot url's ok. On the other hand, screenshot url's are in pabot with selenium hub+nodes same (including these pabot process id's) but url's in log.html are correct ones. Is this behavior/bug in pabot/robot instead of browser extension?

I was comparing results to pabot with selenium hub+nodes setup and there are screenshot url's ok. On the other hand, screenshot url's are in pabot with selenium hub+nodes same (including these pabot process id's) but url's in log.html are correct ones. Is this behavior/bug in pabot/robot instead of browser extension?

This is pabot behaviour. It is renaming screenshot files during log composing.

This is pabot behaviour. It is renaming screenshot files during log composing.

Ok, what might be the reason, that log.html file has different url with browser vs selenium?

Ok, what might be the reason, that log.html file has different url with browser vs selenium?

Perhaps you are using older Pabot version which does not yet have this feature. Another option is that you are not using feature correctly. Example we use Pabot to transfer  png and webm files from subfolders. Please check your configurations.
In any case this is pabot feature and nothing to with Browser library and therefore I am closing this issue.


joint_state_broadcaster: improve docs

To be honest (maybe out of scope), I think having an example on what "has to be used in combination with" would be beneficial. Especially in terms of different scenarios to using map_interface_to_joint_state.
Also, explaining what leaving the lists empty means would be beneficial in my opinion.

Originally posted by @fmauch in https://github.com/ros-controls/ros2_controllers/pull/652#discussion_r1456406138

Closed with https://github.com/christophfroehlich/ros2_controllers/pull/4, kudos to @fmauch


Confusing behaviour with href='#'

Using 0.1.9,  did not cause the parent to be highlighted, as only fragments with text were ignored[1]. This changed starting with 0.1.10[2], which breaks our usage.
I believe using <a href='#' to expand submenus on small screens is common enough to deserve special consideration, as it is the approach recommended by bootstrap.[3]
I'd suggest special-casing href='#'. Alternatively, I think that the docs should probably mention this and suggest a workaround.
What do you think?
[1] https://github.com/hellysmile/django-activeurl/blob/2b0092cfe7d46874728082909cc46a388d4aca37/django_activeurl/utils.py#L79
[2] https://github.com/hellysmile/django-activeurl/blob/dfc561cc265b3a4a7377cfd33ba85015d86282c0/django_activeurl/utils.py#L116
[3] https://getbootstrap.com/docs/4.0/components/navs/#tabs-with-dropdowns

Any pull request is more than welcome!

Great! I'll look into it :)


fix(aot, npm5): resolve AOT issues, add compatibility with npm5

Add Inject token to the Apollo class constructor to resolve AOT
Expose types in index.ts
Fixes #363
Fixes #340
Closes #360
Closes #362

I just checked if the recent changes allow to use apollo-angular with Angular 5's AoT. It seems that it works fine.
It's published as kamilkisiela-apollo-angular a not under apollo-angular until I do more tests.
Does my release works for you too?

@kamilkisiela The latest release does not resolve #363

@CaerusKaru Example app with AoT, Angular 5 and the master branch of apollo-angular published as kamilkisiela-apollo-angular
https://github.com/kamilkisiela/apollo-angular-reproduction/tree/aot-5.0.0

@kamilkisiela On fresh install, I get the exact same warning as in #363:
Warning: Can't resolve all parameters for Apollo in /Users/main/apollo-angular-reproduction/node_modules/kamilkisiela-apollo-angular/Apollo.d.ts: (?). This will become an error in Angular v5.x

Thanks!

Many thanks! when will this change be added to the npm apollo-angular? Will it be 13.2?

You can install these today with: npm i github:apollographql/apollo-angular


Mittag und Abendsmensa

currently menser portrays all entires of the day for mensa1
including duplicate entries for noon and evening dishes. Since they aren't always the same, it would be useful to have an indication if a given dish is served during evening or noon times.
the API provides the "time" tag for every dish, which is (currently) either "noon" or "evening",you can maybe use that

also, the reason for the ID change is that now the location itself has it's opening hours listed. meaning that you don't need to rely on picking a meal from the menu to get those.

I will group meals by their opening hours and re-render the table with said differences


feature: Need Documentation for KCP Installation

Feature Description
Need Documentation for KCP Installation
Proposed Solution
ReadMe to have step kcp installation
Alternative Solutions
No response
Want to contribute?

[X] I would like to work on this issue.

Additional Context
No response

Hey @ChocolatePadmanaban, thanks for opening this ticket. I see that you have checked the checkbox for contributing this yourself, I'm happy to support you if you're up for it.

Hi @ChocolatePadmanaban, following up on this. #3113 added a new "Setup" part of our documentation, I've briefly mentioned the Helm chart there. If you are interested in this, feel free to extend those pages.


Add traversal method to Document and Identified

Add a method to both Document and Identified that will allow a user to pass a function that will be invoked on every object contained in the Document or the Identified. In the case of Identified, that means all child, or owned, objects.

Consider the visitor pattern. Document.validate() could be recast in terms of such a traversal function.

We'll likely want to have filtered and dynamically ordered versions of this as well, e.g., invoke on all ExternallyDefined, invoke on all prov:Activities ordered by their relations


test

add some text

some more test

1 2 3

test

one more

foo

one more

another one

one more

Closing

another one

I think it's working now...
--
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Add github actions

Based on the github actions in the sriov-operator project, add the same kind of actions here.
We did not have a non-rhel Dockerfile in this project, so I added one
Signed-off-by: Manuel Buil<EMAIL_ADDRESS>

There was a non-rhel Dockerfile in images, so we will use that one instead

Hmm, i see #328 #329 #332 address build and test, so perhaps we should limit this to just the image push parts ?
@martinkennelly @manuelbuil WDYT?
About the PR labeler workflow, i think it may need additional inputs from @zshi-redhat @pliurh if they found it useful in network operator.

Ok! Let me just do the image push parts

/cc @pliurh

LGTM


Development, testing, acceptance and production

I realize it is a bit out of place, but I'm hoping someone here has an answer.
Is it correct to assume that for "development, testing, acceptance and production" we should only make use of 1 Watson Conversation Service, or would it be advisable to use multiple?

Its really up to you. Lite/Standard instances are free so its no problem to have multiple. I typically don't, I just keep them in a single instance with multiple workspaces, its just easier for us to manage. Most clients do the same. But a few do have multiple instances because they want the separate credentials to avoid any possible confusion or accidental pushing to prod.

Thanks a lot, I guess it really does depend on multiple factors!


Add a stock if the store is robbed recently

This is for we buy from the store and automatically return 0 if the store is robbed.

Please check the new callback from the updated version of actor_robbery,, this should fix the issue.
forward OnPlayerRequestRobbery(playerid, actorid);


Inconsistent level of indentation in docs/tutorials/google/reservations

Sometimes things are indented with two spaces and sometimes with four. Python and Cirq use four. When you open this notebook in jupyter, the syntax highlighting looks very bad for the 2-indent cells

Does it happen in more notebooks, or only in this one?

Keeping open until we have a tool


Rearrange elif to check 'if metal' before spin-selection

Not sure if you want to do this fix differently @utf, but here's a suggestion. I believe all that is needed is to change the ordering of the elif statements, so that 'if metal' comes before spin-selection when setting the truth value of is_vb. Also, get_vbm() is not called in dosplot, so I think this is all that needs to be changed.

(As a fix for issue #94 )

Thanks for taking a look at this.
Unfortunately, I don't think this would have worked because that if_metal line also includes is_spin_polarized, which then be true whether or not you had selected the spin.
So I did the switch of the lines and also added an additional check to see if the spin was set...
 elif self._bs.is_metal() or (self._bs.is_spin_polarized and not spin):


Amam/styled component

Can you add a description to this PR? Easier for us to keep track in the future.


Add description parameter to SelectListItem constructor

All of the list item types have a description parameter in their constructors except for SelectListItem, so I added it to SelectListItem to ensure consistency and obviously make it easier to add a description to a SelectListItem.

Thanks for the PR!
How do they look in the app? It shouldn't change anything but I just want to make sure it doesn't break something visually

I checked and everything looks fine, it behaves just like descriptions behave with other list item types!

Okay great!


Should cities data get served over HTTPS

I can see that city data comes from a mysql server (3306), which gets blocked by many corporate firewalls and VPNs... Also presumably ££$$ to operate.
json version of this data is currently 13MB, gzipped is 4.5k - So easily downloadable by the client.
Could potentially then just locally search the json? It's not a frequent activity, so the processing overhead shouldn't be a big issue?
This would allow the file to be served up from github/github-pages, or even just bundled with each release - eliminating issues of search not working for people.
Just a thought!

@geftactics thanks for idea!


Future region us-central2 (Unknown)

The future region us-central2 is reported during execution of coverage-published test case. This issue will track that region's progress to GA and support in this module.

Not stale

Not stale

Not stale

Not stale

Not stale

Not stale

Not stale

Not stale

Not stale

The region us-central2 is still present in GCP metadata but is not yet online.


Bump minor version to 1.21.19

Description of changes:
Fixes an issue where metrics-server promotion was not copying over the 1.21 image.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

maybe something like
git checkout main
git reset --hard upstream main
git branch -D feature/bump-metrics-server-helm-chart-minor-19
git checkout -b feature/bump-metrics-server-helm-chart-minor-19
git cherry-pick cb1cd72

and if that looks good, force push?

maybe something like
git checkout main
git reset --hard upstream main
git branch -D feature/bump-metrics-server-helm-chart-minor-19
git checkout -b feature/bump-metrics-server-helm-chart-minor-19
git cherry-pick cb1cd72

and if that looks good, force push?

Yes, about time to reset the upstream. thanks Terry. This change no longer necessary, closing out.


feat(otlp-transformer): Do not limit @opentelemetry/api upper range peerDependency

Today, some packages define a peer dependency on @opentelemetry/api that explicitly excludes future versions in the 1.x range. IMHO this is not helpful because 1.x release have to be backwards compatible anyhow, but this can lead to version conflicts when using different packages. I believe that it should be safe enough to simply have ^1.3.0 as peer dependency?
Fixes https://github.com/open-telemetry/opentelemetry-js/issues/4815

@pichlermarc I am also following this thread.
I struggle to understand the reasoning for clamping the version range like this. Especially considering the spec you linked:

When new functionality is added to the OpenTelemetry API, a new minor version of
the API is released. These API changes are always additive and backwards compatible
from the perspective of existing Instrumentation packages which import and call
prior versions. Instrumentation written against all prior minor versions of the
API continues to work, and may be composed together into the same application without
creating a dependency conflict.

To me, this would very much indicate that it is absolutely safe to allow for a specific version and above within a major (^). I might totally be missing something.
Do you happen to have an example for how this is necessary?
I understand that extending an interface will be fine for consumers, but break for implementors, however, that seems to be forbidden by the spec and instead replacement interfaces should be provided:

Instead of breaking a Plugin Interface, a new interface is created and the existing interface
is marked as deprecated. Plugins which target the deprecated interface continue
to work, and the SDK provides default implementations of any missing functionality.
After one year, the deprecated Plugin Interface may be removed in a major version
release of the SDK.

Do you happen to have an example for how this is necessary?

Example: Adding a new instrument to the Meter interface in the API.

I understand that extending an interface will be fine for consumers, but break for implementors, however, that seems to be forbidden by the spec and instead replacement interfaces should be provided:

Instead of breaking a Plugin Interface, a new interface is created and the existing interface
is marked as deprecated. Plugins which target the deprecated interface continue
to work, and the SDK provides default implementations of any missing functionality.
After one year, the deprecated Plugin Interface may be removed in a major version
release of the SDK.

There's a difference between the API and the SDK.
This Section relates to the SDK (and Plugin interfaces - like Instrumentation, SpanExporter, SpanProcessor, etc.). Compared to the API the SDK may actually receive major version bumps where these deprecated types can be removed. The API spec is much more restrictive on that.

I updated this to only unclamp this for otlp-transformer! @pichlermarc thanks for the explanations!

Me and @mydea thought a lot about this offline and I settled my mental model on the fact that SemVer is sometimes actually really hard to properly get right when you have implementors. It becomes a trade-off between wanting to be super correct, and being user-friendly but risking breakage. In theory, even simple stuff that you may think will never break anybody, like for example turning the return type of a simple exported function from void to string may break somebody's implementation.
In our packages in the Sentry JS SDKs we probably don't adhere to SemVer in the strictest of ways (still we never had anybody complain). The only API where we are careful is our Client (which is the only realistic API surface that people actually may implement themselves): https://github.com/getsentry/sentry-javascript/blob/5eafa401c076796fba7663dad9ca254ab6f1972f/packages/types/src/client.ts#L30
Here, whenever we want to add surface, we first add it as optional field, and then in a major we may make it non-optional. This comes with a bit of internal implementation complexity but it is probably worth it. I am not familiar enough with the OTEL implementations and whether OTEL already has this pattern but I still wanted to bring it up for posterity.

I added a changelog entry, I figure this is an enhancement 🤔


Helm values in ship init should show comments

Expected behavior
When running ship init , the helmValues step should show the values.yaml, with comments, exactly as the repo contains.
Actual behavior
The keys are stripped from the values.yaml, and shown without comments.
Information

Ship version: 44e24a4
Command line run: ship init github.com/helm/charts/stable/grafana

@divolgin is this issue addressed?

#706


chore: refactor multi-hop state tracking to avoid duplicate states and associated logic

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5745   👈

This stack of pull requests is managed by Graphite.


Add support for formatted start time in emailable-report.html

TestNG Version
7.1.1 for the sample below, but the master branch version can also have the new feature applied.
Expected behavior
When I run my TestNG tests using maven and the maven surefire plugin, I would like to be able to specify a formatted start datetime in the emailable-report.html file.
Actual behavior
The start datetime of a test is displayed in millisceonds from the epoch, which is not human readable.
Is the issue reproductible on runner?

[x] Maven
[x] Shell
[x] Gradle
[ ] Ant
[ ] Eclipse
[x] IntelliJ
[ ] NetBeans

Test case sample

run TestNG tests with maven and the maven-surefire-plugin, check the Start column in the emailable-report.html file
Screenshot attached...

Other
I have come up with a fix in my local dev environment to support this feature by adding a protected method to the EmailableReporter2 class which will return the formatted start datetime.
The method can then be overridden in a sub class to return the human readable String, which will be added to the report.
A Sample output would be

@bazzani - Would you like to raise a Pull Request for this ? We will be gladly be able to help you with reviewing it and getting it merged.

@bazzani - Would you like to raise a Pull Request for this ? We will be gladly be able to help you with reviewing it and getting it merged.

@bazzani - Would you like to raise a Pull Request for this ? We will be gladly be able to help you with reviewing it and getting it merged.

I certainly would @krmahadevan!
I have already forked this repo, and pushed an interim commit to a feature branch on my fork.
I will have another look at the code to see if adding any unit tests are prudent for this change, and then get back to you.

@bazzani - Would you like to raise a Pull Request for this ? We will be gladly be able to help you with reviewing it and getting it merged.

I certainly would @krmahadevan!
I have already forked this repo, and pushed an interim commit to a feature branch on my fork.
I will have another look at the code to see if adding any unit tests are prudent for this change, and then get back to you.

@krmahadevan can i ask when my fix for this issue will be released?
aka when is the next release of testng due?

@bazzani - TestNG 7.4.0 has been released to Maven central.


Add support for TxPool event subscriptions

Description
This PR adds support for TxPool event subscriptions.
Supported events:

Transaction added
Transaction enqueued
Transaction promoted
Transaction dropped

Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have tested this code
[ ] I have updated the README and other relevant documents (guides...)
[x] I have added sufficient documentation both in code, as well as in the READMEs

Additional comments
Additional docs PR: https://github.com/0xPolygon/polygon-edge-docs/pull/56

@brkomir
Coverage tests added with a52e0f8 & 6b6640b 👍


Why there is no justify-evenly class?

Hi, I was just wondering why there's no class for  justify-content: space-evenly, any particular reason for not including  .justify-evenly?

We chose not to include it originally because it has no Edge or IE support but I think could be worth adding to core after the Chromium-based version of Edge has replaced the current version.

Let's add it pls 🙏

How to add it in custom config? (as workaround)

@vintprox can't add it to the config file because the justifyContent isn't configurable (values can only be a few keywords). You can add a class to your stylesheet to extend core/plugin utils like this: https://github.com/tailwindcss/tailwindcss/pull/22#issuecomment-358400087

@adamwathan this was added in #1083. Can we close the issue?

@hacknug it's not added to the docs yet
https://tailwindcss.com/docs/justify-content


Invalid_scope

Hi !
I try to use your script, but i have an issue !
i follow all the step and all is ok, but,  when i click on the link in the side panel, the new page show this code :

{"error":"invalid_scope","error_description":"The requested scopes either don't exist, or are not valid for this client"}

Thank you.

Did you go back into your dev application and add the three new scopes?
esi-industry.read_character_jobs.v1
esi-characters.read_blueprints.v1
esi-markets.read_character_orders.v1

yes, i selected all of this :

esi-calendar.respond_calendar_events.v1
esi-calendar.read_calendar_events.v1
esi-location.read_location.v1
esi-location.read_ship_type.v1
esi-skills.read_skills.v1
esi-wallet.read_character_wallet.v1
esi-search.search_structures.v1
esi-clones.read_clones.v1
esi-universe.read_structures.v1
esi-assets.read_assets.v1
esi-markets.structure_markets.v1
esi-corporations.read_structures.v1
esi-corporations.write_structures.v1
esi-characters.read_loyalty.v1
esi-industry.read_character_jobs.v1
esi-markets.read_character_orders.v1
esi-characters.read_blueprints.v1

Select all of the ESI scopes.  This issue is because you do not have a scope set in your dev app that is used in GESI.
You can see all the scopes used in GESI on line 199 where it says .setScope('.....');  But, again, it would just be easier to add them all so when I add another endpoint you do not have to go back and add the new one every time.
Any other problems, open a new issue.

Thank you !
I didn't see that they had to be defined !
Sorry for the disruption.


Add target_pdf method to reduce code duplication

metanorma/bipm-si-brochure#108

@ronaldtse @opoudjis I noted that we have two initialize methods with the same signature, should we remove the first one?

Probably an error, @opoudjis ?

@ronaldtse @opoudjis removed first initialize


(feature request) add optimization to memory so it could be used< 8GB?

Hi, so I integrated memory optimization myself by forcing half-precision and split memory from basujindal fork but when I do text2img, I still get Cuda out of memory, since I'm not a programmer, maybe I failed in the process, it would be great if someone could optimize the memory for this fork for us.

try the diffusers library


CPU Scheduling algorithms in Java

🚀 Feature
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
CPU Scheduling is a process of determining which process will own CPU for execution while another process is on hold. The main task of CPU scheduling is to make sure that whenever the CPU remains idle, the OS at least selects one of the processes available in the ready queue for execution. CPU Scheduler selects one of the processes in memory that are ready for execution.
Will implement -

[ ] FCFS (First come first serve)
[ ] RR (Round Robin)
[ ] SJF (Shortest Job First)
[ ] SRTF (Shortest Remaining time first)

@atarax665 @HarshCasper Please assign me this issue under DWOC.

I would like to take up this issue. I'm a part of GSSOC'21 and would like to contribute.

I would like to take up this issue. I'm a part of GSSOC'21 and would like to contribute.

Hi @saaiswetha
GSSoC Issues will open in some time. Kindly have patience till then :)

@HarshCasper Should I make individual PRs or make only 1 PR consisting of all algorithms?


Add Figma link to README

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like
https://www.figma.com/file/qwBWs4i7pJMpFbcjMffDZU/Jury-(Gavel-Plus)?node-id=8%3A100&t=egLV7iVmwvNRXef5-1
^ Literally just add this to a reasonable place in the README my branch is too messy and im lazy
Additional context
No response

hey shall i also improve your readme??


Hyper links are not supported in PDF JS version 1.1.1

Hi , I am using pdf js stable version 1.1.1 .
Hyperlinks are not supported in pdf js 1.1.1 and we are able to open the hyper links from  version (1.1.114) . Can you please suggest any changes to be made in 1.1.1 version to enable hyper links , as of now we can not change the files of other version.

No changes have been made to the Link annotation code recently as far as I know (except for #6281, which appears to be unrelated). Version 1.1.1 is pretty old; the latest stable version is 1.1.215. You should really consider updating, and otherwise you would have to go through the last commits manually to find out which commit fixed the situation for you. Closing as answered.


modified math.rb to include more math methods and likes_candy method, th...

:)

Nicely done. Code looks good. Try to think about getting more descriptive with the expected behavior in your tests. Instead of "multiplies two numbers", think about the output and the expected datatypes:  ie 'it "returns the product of two numbers as a Fixnum" do'.


Was working on a different computer, Need help with opening kanan.

https://puu.sh/tqjjh/6a52f84485.png
Did the same on another computer, it worked but on this computer?
No clue.

Try temporarily removing/disabling AutoSetMTU.js and let me know what happens.

https://puu.sh/tqkxu/5ba2eab86a.png
Here ya go

Yeah, I'm getting the same issue when I use the latest version of frida. They must have changed something, I will check.

much thanks!

Ok, so the latest commit (d1d530c) should fix the issue you discovered. Thanks for bringing it to my attention and please give it a try by redownloading the project 😄

thank you!

Ive been wondering, What is Kanan auto start with morg? tried to run it as admin but it says im not running as admin? should i mess with it?

It runs Mabinogi with Kanan and Morrighan, a mabinogi packet analyzer.

so im not great with programming and what not, and having a problem with #152, how do i fix it?
https://gyazo.com/667b70c62d5a6204749fb1c92073a09b

Have you downloaded the latest version of the kanan files recently?

i think so, friend sent me the files last night

The only version of kanan supported here is directly from this Github page https://github.com/cursey/kanan (click the green 'Clone or download' button then press the 'Download ZIP' link).

ill try that

If you would rather use your friends version, you can fix the problem you're encountering by installing an older version of frida. Open a windows console and type pip install frida==7.2.14.

ok looks like its working now besides those 2 scripts ( i think their scripts lol)
https://gyazo.com/0481803952381340e879c1f3de8111fe

Yep, those two need to be fixed still. Glad its working though! :smile:

turns it on for the first time- curious, is there a mod in here that makes the sky just white? and i probably shouldnt message that here lol

@logancrow3 NoRenderSky.js is the name of it.

thanks again owo;;;


Add BuildConfig support

Remove the Job-based build manager.
Use the pull secrets from the builder ServiceAccount by default.
/cc @ybettan @yevgeny-shnaidman @enriquebelarte @fabiendupont

/hold

/lgtm


Investigate adding support for different frequencies of data

Currently, we only officially support daily returns and positions streams. Some tear sheets and plots work okay with other frequencies of data (e.g. monthly). Other plots and performance functions, namely the beta and Fama-French factors, will fail to compute accurate measures because they compare their daily reference data to whatever is thrown at them.
It would definitely be useful to support different frequencies if we can do it in a way that's elegant. I'm not sure what the best way to do this is, open for input and help.

@kitovh has expressed interest in looking into this! Duplicate of #456.
I took a cursory glance at the code, and this issue looks like it'll take more reading than writing code. Unfortunately I'm not free right now to whip up a PR, but I'd be happy to help anyone who wants to take this up.

Most of pyfolio's output is a matplotlib graph. The easiest thing to do would be to use pandas' built-in plotting capabilities, and do something like returns.plot(), and then adding legends, colors, etc. afterwards if necessary. This way, all graphs will have x tick labels with the correct time period. It looks like most pyfolio functions are already doing this, but it would be good to make sure they all did.
Most of the summary stats are simply call-throughs to empyrical. Luckily for us, empyrical already supports different time periods, and it's only a matter of making sure pyfolio sets the right flags. The nicest thing to do would be to make pyfolio smart enough to read the freq argument of the DatetimeIndex in the input dataframes.
There might be some other problems that I'm not anticipating... Particularly the perfomance attribution and Bayesian tear sheets, since they perform statistical analyses that assume daily frequency.

Thoughts?


Resolve: Toggle dark/light mode

Screencast from 16.04.2023 15:45:21.webm

[x] Add ThemeToggle button to header
[x] Provide ThemeContext to handle state
[x] Store theme persistant in cookie - needed because of SSR and to avoid flickering

This approach is heavily inspired by Learning Leptos: v0.1.0, cargo-leptos, & the World's Best Dark-Mode Toggle and https://github.com/benwis/benwis_leptos/
Closes #77

looks good at first glance! @larrysalibra or @LightRider5 can you review?

The body size issue is fixed now but the dark background doesn't appear anymore in the main part of the view. Text color changes for example but bg stays white.

ACK, works as expected now


Amazon Retail Module - Lists Title and Price of URLS containing ASINs

Notes

Requires an Amazon Account with root AWS credentials
Amazon Account must be signed up through Amazon Associates

Affiliate ID is used for awsTag

Example Usage
<gmackie> : https://www.amazon.com/dp/B00B361NJM/
<suebot>  : Leviton IPS02-1LW 300-Watt Incandescent, 150-Watt LED/CFL Occupancy Sensor (Auto ON/Auto OFF), Single Pole, White - [$25.99]

Heyooooo!
Does it work with URLs like https://smile.amazon.com/gp/product/B01IRK301U/?

@LinuxMercedes  Regex looks like it ignores the domain completely and just looks at /gp/product/ABCXYZ, so probably so.

it would fail to parse the /gp/product/B01I... because its looking for /gp/, /o/, /dp/, or /-/?
TIL /gp/product/ is a valid URL

Just looking for ASINs sounds fine to me!

LGTM FISI

monthly beeping sound on this @gmackie

monthly gentle @gmackie beep.

@gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie @gmackie

beep boop


new(ci): added gha support.

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

/hold for now; when CI will be green, i will drop circleci jobs.

I disabled buildmode pie and tested that:

i could run driverkit-amd64 on my machine
i could run driverkit-amd64 inside an ubuntu:18.04 docker container
i could run driverkit-amd64 inside an alpine:latest docker container
i could run driverkit-arm64 on an ubuntu-aws ec2 arm64 instance
i could run driverkit-arm64 inside an arm64 ubuntu:18.04 docker container
i could run driverkit-arm64 inside an arm64 alpine:latest docker container

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @dwindsor @EXONER4TED
If this is ok for you, i can update required checks on test-infra and we can move on with this!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: EXONER4TED, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [EXONER4TED,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Opened test-infra pr: https://github.com/falcosecurity/test-infra/pull/1329

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EXONER4TED pushed a small fix :D

/unhold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: EXONER4TED, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [EXONER4TED,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Customize and expand toolbar icons

[x] Add option to customize the toolbar icons
[x] Expand the toolbar icons

[x] Code
[x] Horizontal rule

Done.


Information about dependencies for this to work

Sorry that this is not an Issue but I'm having trouble deploying the dashboards.
I've successfully deployed this plugin on a new Grafana instance, it delpoyed the "snaps" and then I configured the connection to my cluster using certificates. The moment I try to see any dashboard, it complains I don't have a datasource.
For what I understood, the datasource is Graphite but I have no idea on how to deploy it or where to get it.
Can anyone point me out on how to have the full solution? Thanks in advance.

Answering my own question, I found a Docker image for Graphite and created a deployment/service for it.
Both can be checked on: https://github.com/carlosedp/kubernetes-kit/tree/master/graphite
The image used is from https://github.com/nickstenning/docker-graphite


Garbage collect hook resources after release deletion

This addresses the same use case brought up in #3128, deleting hook resources when the corresponding release is deleted.
In the helm community project a similar behavior is described:

In Helm 2, resources with hook annotations were unmanaged. In Helm 3, the owner reference is set on those, and they will be removed when the chart is deleted. There will be a way to override the management policy by setting an annotation for helm.sh/hook-policy: unmanaged

I think the existing helm.sh/resource-policy: keep annotation should work for opting out of this behavior.
CRDs should probably be an exception.

Hi, @jlegrone - Thank you for your ideas to improve Helm. I see that some related PRs have been merged. We now have a defined process so that if you'd like, you can submit a Helm Improvement Proposal so as to work in the community to make the remaining ideas here a reality: https://github.com/helm/community/blob/master/hips/hip-0001.md - meanwhile, I will close this issue. Thanks!

@bridgetkromhout @jlegrone Has there been any follow up on this feature request? The docs say it might be implemented some time in the future:

Garbage collection of hook resources when the corresponding release is deleted may be added to Helm 3 in the future, [...]

Is there some work item that I can watch to see the plans about it? (I've looked through the HIPs, but there doesn't seem to be a matching one.)


Add Inbound intermediate connector element template

We support both start event and intermediate event inbound connectors, but this repository only contains a template for start event connector.
We need to add an example of the element template for an intermediate event.

@chillleader WDYT about replacing this with the element template generator?


Align QueryImage and QueryImageResponse XML with the spec

Problem
QueryImage is not using a list where it should and QueryImageResponse does not have various fields marked as optional.
Change overview
Fix those issues.
Testing
Ran manual test of ota-requestor and ota-provider.
@carol-apple @holbrookt Would it make sense to change HandleQueryImage to just take the response struct as an arg instead of the individual args?

@carol-apple @holbrookt Would it make sense to change HandleQueryImage to just take the response struct as an arg instead of the individual args?
Yes, we discussed doing this for OTA Requestor cluster as well. I would support that change

@carol-apple @holbrookt Would it make sense to change HandleQueryImage to just take the response struct as an arg instead of the individual args?

Yes, we discussed doing this for OTA Requestor cluster as well. I would support that change

Yes, please!

Please make the changes you suggested - to change the signature of HandleQueryImage to take in the command args struct

Done, and same for HandleApplyUpdateRequest.  And fixed a few bugs in the caller of that while I was dealing with it anyway.....

@msandstedt @saurabhst @LuDuda @Damian-Nordic @jepenven-silabs @jmartinez-silabs Could you please take a look?


Allow to use other drives for distro installation

Describe the solution you'd like
Currently, when we install from Microsoft store, we use C:\ by default, however, we have the ability to select whatever drive we can use if we install manually (sacrificing having to do first time user setup however). I think we should have the distro launchers support selecting a host drive instead of relying on just C:,  this is useful for multi-drive laptops where the SSD is only used as a system drive, and are expected to use the hard drive.
Describe alternatives you've considered
wsl --import or wsl --install works fine but it lacks the first-time user install experience.

Packages/Programs from Windows Store runs in a jail/container/sandbox like environment. If Windows Store allows to install in another drive it would be a sweet spot for you-know-who. You can grab the .tar.gz file from Windows Store installed folder and use it to install in another drive.

Packages/Programs from Windows Store runs in a jail/container/sandbox like environment. If Windows Store allows to install in another drive it would be a sweet spot for you-know-who. You can grab the .tar.gz file from Windows Store installed folder and use it to install in another drive.

We already can migrate apps over other drives. Plus DistroLauncher is just an application to unpack or launch the distro installed. I don't see in a security standpoint it would be insecure since we already have the feature set for it.

You can change MS Store install drive in Win10 Settings > System > Storage for Apps or migrate already installed apps to another drive.
If you feel that MS Store is rightfully the worst one there is, there's a feedback button for it.
I don't think this belongs here at all however. You can install your own distro into WSL without relying on MS Store so WSL itself is working as intended.

You can change MS Store install drive in Win10 Settings > System > Storage for Apps or migrate already installed apps to another drive.
If you feel that MS Store is rightfully the worst one there is, there's a feedback button for it.
I don't think this belongs here at all however. You can install your own distro into WSL without relying on MS Store so WSL itself is working as intended.

I don't think this is the desirable response here, while I agree to allowing feedback, I think the WSL experience could be far more improved if the installation path of WSL followed on where the DistroLauncher apps for the respective distros are. So far, DistroLauncher distros are stuck only in the C:\ Drive - that's something we can work on in the long run since we already have the feature for it - we're just not readily using it. This concerns WSL as a whole as well since DistroLauncher is actually a part of WSL - it's primary purpose is to launch the supplied distro. As a user who might be just getting into the Linux ecosystem via WSL, you might want to move your stuff as easy as clicking it over at the settings, we want to have that as well for DistroLauncher distros.

I think this would be a good idea - it allows some flexibility. I do not necessarily disagree with Biswa96, but to me I think this is more a usability question than a security question. You can always provide the information given here, use with caution etc... while allowing it still. (A few years ago, or perhaps ... 2 years ago I think, with WSL, I used to reason that the whole customization/installation should be very flexible, and also inform the user what has happened, in regards to distribution-installations. I am hugely forgetful and literally with all the multitasking I do in general, being flexible is great, while also keeping track of what has happened in files and GUIs etc... - so I think this would be a usability suggestion more than a security-related problem set really. That being said, I am mostly really just neutral on this, I am fine either way, just giving my opinion. :-) )


Fix dump in Repo Overview for offline repos

Closes https://github.com/larshp/abapGit/issues/3742

looks good, thanks 👍


Cannot comment outside block statement levels

If a comment statement appears outside a block statement level, it cannot be commented.
For example an import statement cannot be commented.

This by design in Ballerina. Comments are only allowed within functions/resources and actions


Create evaluation form (Excel)

It's nearly finished. Only the last three lab assignments need to be added.


Use generic sniff for forbidden functions

Note from Wiki:

[!NOTE]
This sniff also has a forbiddenFunctions property inherited from the Generic.PHP.ForbiddenFunctions sniff, but it should not be used. If you want to customise the list of discouraged functions, use the Generic.PHP.ForbiddenFunctions sniff directly.

Okay.


Add an option to customize and style the component

[ ] Style by attributes
[ ] Style with xml styling
[ ] Set custom layouts

Please provide support for android.support.design.widget.TextInputLayout a.k.a. Floating Label

@yenpei how do you imagine it? since currently it have the "hint" inside.. I guess they can't work both


Update README.md

Update blog post link to Tech Comm. Fix for #96.

I think, this PR can be closed. The current link in README.md is https://techcommunity.microsoft.com/t5/virtualization/sneak-peek-taking-a-spin-with-enhanced-linux-vms/ba-p/382415, which is the same as proposed in this PR.


Project Roadmap

As stated here :

Most of the maintainers of this project have slowly gotten busy with other things and haven't been able to keep up as of late (this includes and is really referring to myself).
I still think this project can provide a lot of value to people so it's a bit of a shame to see the issues piling up.

New maintainers have been onboarded lately to address the current situation (including me and @mvila). Our goal is not only to update the current list of implementations with ongoing submissions but also to answer issues and feature requests.
Here are some changes we plan to apply to the project.
As we are still defining the new roadmap of the project, this issue will be updated from time to time.
Maintenance of GoThinkster implementations
Current state
When this project came out, as a way to demonstrate implementations, several repositories have been created into the GoThinkster organization, featuring a frontend or backend language/framework :
Node/Express
Ember
React/Redux
Angular
Vue
..
Beyond this list, several community implementations have been added to the GoThinkster organization.
Most of these implementations (former ones and community ones) are left unmaintained. While maintainers have been fully dedicated to this project, they now are busy with other projects and can’t contribute to it anymore.
These projects still work (the demo is based on the angularjs implementation and the API based on the rails one) and follow the current specs but they don’t use the latest versions of the related language/framework: there are ‘RealWorld’ but not so modern implementations.
There are over 500 issues/pull requests opened on the related repositories.
Our goal
We don’t plan to maintain and admin these projects.
Having to maintain a given list of implementations means the maintenance team is tied with the skills required over a large number of repositories. Given the large scope of ‘official’ implementations, it’s hard to guarantee such an organization would work (as it failed once already).
To fix the current situation, we decided not to maintain them (i wouldn’t say ‘anymore’ as, as a new maintainer team, we never maintained them previously).
Our plan is to replace them with community implementations.
If you want to contribute to this effort, we encourage you to submit a related implementation.
Provide up to date implementations
Current state
A lot of listed implementations aren’t up to date with the language/framework latest versions.
Our goal
The maintainer of implementation should keep an eye on new versions.
At some point, we might consider removing an implementation to price an up-to-date one.
Official implementations
Current state
The deployed api is the rails implementation.
The front end deployed is the angularjs.
Our goal
While we don’t plan to maintain current implementations, we need to keep a frontend and a backend implementation up to date to :

illustrate how the specs are used
to test future versions of the specs

We plan to create and maintain 1 frontend and 1 backend implementation to do so.
We still need to consider which language/framework we will use as we don’t want them to be gatekeepers for new maintainers.
The criteria being :

using popular language/framework
be as agnostic as possible
avoid language/framework having regular breaking changes on new versions
avoid language/framework having a lot of new versions
favor code readability

There is an open RFC going on #694
Issue Triage
Current state
The issues panel includes :
bug reports
feature requests
open discussions
implementations requests
implementations wip
implementations review requests
Our goal
We are happy to welcome new implementations and to give a space for work in progress implementations to let the community be aware of them. However, a lot of these projects are still WIP after a few years.
We chose to close WIP Issues and to invite creators to open a related discussion on Github Discussions.
Github allow to move an issue to Github Discussions but us ch a move was also a way to clear up abandoned projects.
Implementation submission workflow
Current state
You currently need to open an issue whether:

to let the community know there is a work in progress
to ask the maintainer team to add it to the list of implementations once done

Our goal
We want to simplify the current workflow and enhance it with new features.
About Work in progress
The ‘work in progress’ implementations are now moved to Github Discussions.
About submissions
The submission is now available on CodeBaseShow.
New version of the specs
Current state
There are a lot of issues we can't address right now because it would integrate breaking changes for current implementations.
We need to consider feature requests to make the specs more 'real'.
Our goal
The best way to answer such solicitations is to work on a brand new version of the spec.
We'll open a related issue soon to give you more insights about that.
We'll be open to ideas and suggestions.
Testing
Current state
We provide a way to test the API
Our goal
We want to provide a way to test the frontend too.
Open Source standards
Current state
The standards of a healthy open source project have evolved since the project has been created.
Our goal
We want to provide a better experience for contributors by adding :

a more complete contributing guide
issues template
pull request template

A code of conduct has already been added.
We plan to update the Readme as well to challenge current content.

That is amazing! I'm glad some live gets put into this project again

To keep track of updates on this project as it involves more than 1 repository, I created a related category in GitHub Discussions where you'll find weekly updates: https://github.com/gothinkster/realworld/discussions/categories/weekly-updates


[Pods] DCOS-9986: Using Table instead of CheckboxTable on PodInstancesTable

Removing checkboxes from PodInstancesTable. However I am keeping the logic of the CheckboxTable since this is something we will roll-back into when we have the per-instance kill functionality.

@wavesoft the tests have failed... could you please have a look?

@orlandohohmeier I am trying to figure out why...

Ok, finally fixed the unit tests, using the following magic words ✨
<Table
        ...
        itemHeight={TableUtil.getRowHeight()}
        ...
/>

😮

LGTM 🎆


[2.0]: Manage themes modal: Numbers shown next to themes incorrect + inverted singular / plural

singular / plural inverted on the hints here for n styles
i also noticed those counts are not reflecting the actual state. try creating a bunch of variables / styles - the number does not seem to make sense

Added to Featurebase Roadmap-	💚 Theme management enhancements - QOL


Request: make belt items and class feature toggles stay on between battles/rests

Holy symbol of Iomedae: invaluable item for bypassing DR, but I have to waste a hotbar slot on it so I remember to activate it between battles or if I faint or rest, change areas etc.
Focused element stays active no matter what, but elemental bloodline arcana deactivates itself.

Holy symbol of Iomedae has been fixed

thanks again!


MRS1000 IMU calibration

Hello,
I'm working on an MRS1000 with ROS2 foxy, unfortunately the lidar is not perfectly mounted on the robot on a horizontal plane, resulting in a bias on the IMU reading...
Is there any way to provide a calibration file or to perform an online calibration to handle those biais with sick_scan_xd ?
Best regards,
Loïc

There is no direct way to configure the IMU. We recommend you to write a ROS node that receives the IMU data, compensates the BIAS error and retransmits the so corrected IMU message.


Test that Unmarshal doesn't do any allocations

The various Unmarshal functions are low-level functions that
should not do any extensive parsing.  Anything that requires
allocations should be done in a user-callable function so that
applications can call Unmarshal without concern for efficiency.

This currently fails for H264, H265 and AV1.  If either #265 or #266 gets applied, it will pass for AV1.  Once that happens, I'll fix H264 and H265.

If #266 and #268 are applied, this passes for AV1 and H.264.  I'm not going to fix H.265, since I'm not interested in single-platform codecs.


Fix broken link to Feature Branches docs.

This poor forgotten link was in a different place than the others.

Good man @threehams!


ReferenceError: "ScriptDb" is not defined

When I follow the instructions (lower half of http://zen.lk/magpie/) then after step 11 I see
ReferenceError: "ScriptDb" is not defined. (line 2, file "Code")Dismiss

https://gsuite-developers.googleblog.com/2014/10/reminder-scriptdb-is-shutting-down-soon.html says

To summarize: ScriptDb will shut down on November 20, 2014, so please ensure you migrate your scripts before then!


[NEW GAME]: Valorous Rabbit

Description
This game is made by using HTML, CSS and JavaScript.
In this game a player has to make the running rabbit jump by clicking on "click to jump" to save  the rabbit life from the dangerous cat. The longer the rabbit run the greater the score will be.
Screenshots

Additional information
No response

Please assign me this issue under gssoc'23.

Hi @uzmaansari23, I am assigning this to you. Kindly complete your work within a week.

@panwar8279 okay!


Update java

Bump Java gRPC package semantic version
Support Java gRPC generation when no gapic yaml is provided, as per common protos

Current coverage is 90.38% (diff: 0.00%)

Merging #150 into master will decrease coverage by 0.12%

@@             master       #150   diff @@
==========================================
  Files             3          3
  Lines           727        728     +1
  Methods         150        150
  Messages          0          0
  Branches        118        118
==========================================
  Hits            658        658
- Misses           69         70     +1
  Partials          0          0

Powered by Codecov. Last update aec026e...6735f4d

LGTM


Fresh install of z2m addon doesn't work - restoring 1.4.x backup and updating to 1.5.x works

I friend of mine has a strange issue. It looks like it's related to the newest version(1.5.1) of the addon.
On a fresh hassio install he is not able to install the z2m addon.
If he restores an old backup (1.4.x) and updates z2m 1.5.1 works fine.
We noticed that in the fresh installation of hassio the z2m doesn't create new files in the share folder.
So it looks like it's only able to update, if these files/folders already exist.
Maybe this has something to to with the backup feature?
Unfortunately I only have picture of his log:

Should be fixed by #204

Releasing v<IP_ADDRESS>, which includes the above fix. I'll close for now but re-open if you're still experiencing problems.

<IP_ADDRESS> doesn’t show up yet, can you tell when will it be available?

@danielwelch <IP_ADDRESS> still doesn’t appear as an update.

Just want to note that this update fixed the issue. Thanks


Enhancements and cleanup in scipy.integrate

Since the introduction of nquad, the integrate package has had two different ways of evaluating multivariate integrals. This PR removes the duplicate code, converting scipy.integrate.dblquad and scipy.integrate.tplquad to thin wrappers around nquad. The API for these (which is backward from the nquad API) is preserved.
Additionally, an option is added to return the total number of integrand function evaluations required by the integration.
Finally, I had to add a link to my work's BSD license, disclaimer, and copyright assertion in the THANKS.txt. I hope this is an acceptable way to reconcile their need to assert copyright with the needs of scipy.

@@            master   #5892   diff @@
======================================
  Files          238     238
  Stmts        43567   43575     +8
  Branches      8174    8180     +6
  Methods          0       0
======================================
+ Hit          34003   34006     +3
- Partial       2598    2600     +2
- Missed        6966    6969     +3

Review entire Coverage Diff as of c43b3dc

Powered by Codecov. Updated on successful CI builds.

I've taken another stab at the copyright attribution. I was also able to get an abbreviated statement, hopefully making it easier to understand exactly what is being claimed (and not reproducing the BSD license).

The statement seems short enough to be added to thanks.txt, I'd rather not clutter the top-level with contributor-specific copyright clause files.
I do not think we should allow contributor-specific license clauses that add restrictions not compatible with the main BSD license. In this case, the statement "If software is modified to produce derivative works, such modified software should be clearly marked, so as not to confuse it with the version available from LANL." seems to add an additional restriction beyond BSD, although this probably depends on how this lawyerese should be interpreted. IANAL, so I do not know.

If I were to release this through some other channel using the LANL BSD-3 license, how difficult would it be to upstream changes into the main repository?

Perhaps the new #5906 will resolve the license problems.

Seems to be superseded by gh-5906, so this can be closed now, @woodscn ?


placement: support batch deletions, with insertions

What problem does this PR solve?
Related to #2680.
Now one can post an array of operations(insert/delete) to /config/rules/batch in one request. In case there is an error, all modifications are cancelled.
Two notable points:

Operations should be independent. Their IDs should be different.
I noticed that this PR and the previous PR is not completely safe. See https://github.com/xhebox/pd/blob/delete/server/schedule/placement/rule_manager.go#L294-L299.

Check List
Tests

Unit test
Integration test

Code changes

Has HTTP API interfaces change

Release note

atomic POST api /config/rules/batcch for batch(insert/delete) rules in one request

It seems currently one batch request couldn't guarantee that the inserting and deleting rules can be executed atomically. I think we can leave an issue to solve how to provide atomically batch rules api (if needed).

why cannot ensure atomic?

I think the contributor have explained on the following. @disksing
				// TODO: it is not completely safe
				// 1. in case that half of rules applied, error.. we have to cancel persisted rules
				// but that may fail too, causing memory/disk inconsistency
				// either rely a transaction API, or clients to request again until success
				// 2. in case that PD is suddenly down in the loop, inconsistency again
				// now we can only rely clients to request again

LGTM

/merge


feat: allow changing the default revisionHistoryLimit

Description
You may want to clean up old replicasets so that these don't appear in metrics, OPA violations, ArgoCD UI and so on.
Therefore you want to overwrite the Kubernetes default revision history limit.
See Kubernetes Clean up Policy.
Checklist

[x] I've read the guidelines for contributing to this repository.
[ ] I've added tests that prove my fix is effective or that my feature works.
[ ] I've updated the documentation with the relevant information (if needed).
[x] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Thomas Berreis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@tberreis thank you for the contribution, look lgtm 🚀  you'll have to run make generate-helm-docs to update helm docs


Add an action creator

Just wondering if you want something like this in ngrx-undo, no problem if not. But I believe it's best practice to work with action creators when working with Redux which will create the desired action object for you. It could be added to ngrx-undo as well in, for example, the following form.
import { undo } from 'ngrx-undo';

store.dispatch(action);
store.dispatch(undo(action));

instead of
import { UNDO_ACTION } from 'ngrx-undo';

store.dispatch(action);
store.dispatch({type: UNDO_ACTION, payload: action});

Let me know what you think, happy to do a PR.

Sounds like a great plan Sam! Your PR would be most welcome! Thanks for being involved!

Thanks for being involved!

I love the project, I use it in every angular 2 app where I use redux so glad I can give something in return ;).

how to use store.dispatch(undo(action)); with that model?


All BigQuery samples should poll to wait for completion

There isn't really a difference between "sync/asynch" queries. I'm working to remove this distinction from the docs.
Please update all query samples to look more like this one, where they poll for results:
https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/06d9eb392e600051145285aa73bb48a785e20666/bigquery/api/GettingStarted/BigqueryTest/BigqueryTest.cs#L164
Even if the "synchronous" request times out, the job is still running. Most people will want to wait for the results.

When creating a job, it's best to set an explicit Job ID, as well. (It should be unique, such as a UUID)

The job ID is now always created automatically, and GetQueryResults waits for the job to complete before returning the BigQueryResults anyway now.
Closing as obsolete.


Scale Input Boxes to Improve visability of numbers

Report from DavidPagnon that the spin boxes were not large enough to display text:

Documenting target appearance of GUI:

Also, for reference, this is how the charuco should update when paper size changes:

Hi @mprib,
Thank you for taking into account all these suggestions!
I'm still not sure I understand:
Let's say you set the board to have 4 rows x 3 columns. Let's say you specified that the square size is 5.4 cm. Then the Charuco board should be 21.6 x 16.2 cm².
If you specified that the board size should be 25 x 20 cm², shouldn't you have margins on all sides? More specifically, 1.7 cm on top and bottom, and 1.9 on the right and left sides?

Actually, I think I got it: if we did not manage to print the board properly, this can be fixed before proceeding to the next stage by correcting the actual square edge length. Is this it?

this can be fixed before proceeding to the next stage by correcting the actual square edge length. Is this it?

Yes, it is this exactly. The scale of the world is set by the actual size of the squares. In practice there is generally a small deviation of the final printed page from the "perfect" intended measurement.
This number ultimately just goes into the charuco board definition in OpenCV: https://docs.opencv.org/3.4/d0/d3c/classcv_1_1aruco_1_1CharucoBoard.html

Note that in https://github.com/mprib/caliscope/issues/652, it is reported that the width is getting capped at 100, and a0 format will exceed that. Need to expand viable inputs here as well.

@davidpagnon,
I've just pushed some changes and updated to PyPI. I believe that the charuco widget will now not constrain the widget width in such a way that it clips the text.
If you have a moment. could you confirm if the change worked? I can't duplicate the original issue on my machines (I'm guessing because of my resolution?)
Thank you!
Mac

Hi, this is great on most text fields, aside from a few of them:

@davidpagnon,
Thank you for looking at this. I really appreciate it.
I've just pushed changes to main that attempt to set the text box based on an assessment of the font metrics for the font being used, along with some extra padding. Hopefully that will do that trick.... 🤞
Mac


Release Flatcar Container Linux Alpha 3654.0.0, Beta 3602.1.2, Stable 3510.2.4

Release Flatcar Container Linux Alpha 3654.0.0, Beta 3602.1.2, Stable 3510.2.4
The release of Flatcar Container Linux of the following version is planned for July 4th, 2023.

Alpha 3654.0.0
Beta 3602.1.2
Stable 3510.2.4

Tasks

[x] Go / No Go hackmd doc created from previous one for test tracking and release notes: link (@dongsupark )
[x] Check that the kernel PR are merged for the channel(s) to be released. (@dongsupark )
[x] All planned changes are merged & blocker bugs are fixed, last nightly reviewed for problems (@dongsupark )
[x] Branch off main (only new major) (@dongsupark )
[x] Tag build branch (@dongsupark )
[x] Start Jenkins builds, post links as comment (@dongsupark)
[x] Test status captured in hackmd doc (@sayanchowdhury)
[x] All tests are green (@sayanchowdhury)
[x] Release notes / announcements added to Go/No Go doc from container/image_changes job by selecting Timestamps: None (@dongsupark )
[x] QA: check diff for image file list, packages, and image size in the image job output (@dongsupark)
[x] Matrix Go/No Go meeting (inc. release notes review) (@sayanchowdhury)
[x] Update payload signed/uploaded (@dongsupark)
[x] scripts release created on GitHub (@sayanchowdhury)
[x] Release job container/release ran (@sayanchowdhury)
[x] Images uploaded with copy-to-origin.sh (@sayanchowdhury)
[ ] Azure offer updated & publishing started ()
[ ] Azure Go Live ()
[ ] GCP Offer deployment package uploaded to Google bucket and submitted for verification ()
[ ] GCP Offer submit for verification ()
[ ] GCP Offer Publish ()
[ ] For new Stable: Manually run ./azure-sig.sh to create new Shared Community Gallery Images
[ ] For new Stable: build and provide images for supported Cluster API providers ()
[x] Symlink to "current" updated with set-symlink.sh (@sayanchowdhury)
[ ] Website updated with ./update-flatcar-versions.sh and PR merged (@sayanchowdhury)
[ ] Release package published in Nebraska (@dongsupark)
[ ] Send announcement to Mailing Lists ()
[ ] Send Tweet out (@miao0miao, @ahrkrak)
[ ] Brief version announcement in slack (k8s slack #flatcar) and the Flatcar matrix channel

Alpha 3654.0.0: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/896/cldsv/
Beta 3602.1.2 http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/2101/cldsv/
Stable 3510.2.4 http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/2100/cldsv/

Flatcar website PR: https://github.com/flatcar/flatcar-website/pull/270


docs: add more specific docs for linux users using voice

Pull Request Type

[ ] Feature addition
[ ] Bugfix
[x] Documentation update
[ ] Code refactor
[ ] Tests improvement
[ ] CI/CD pipeline enhancement
[ ] Other: [Replace with a description]

Description

This PR adds more specific documentation for linux users trying to use the voice framework
Changes

Fix incorrect pip lines
Add an installation guide for linux deps

Related Issues

Test Scenarios

Python Compatibility

[ ] I've ensured my code works on Python 3.10.x
[ ] I've ensured my code works on Python 3.11.x

Checklist

[ ] I've run the pre-commit code linter over all edited files
[ ] I've tested my changes on supported Python versions
[ ] I've added tests for my code, if applicable
[ ] I've updated / added  documentation, where applicable

Codecov Report
Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (ba44e99) 47.74% compared to head (62a823d) 47.72%.

:exclamation: Current head 62a823d differs from pull request most recent head ea647df. Consider uploading reports for the commit ea647df to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #1333      +/-   ##
==========================================
- Coverage   47.74%   47.72%   -0.03%
==========================================
  Files         139      139
  Lines       14284    14284
==========================================
- Hits         6820     6817       -3
- Misses       7464     7467       +3

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update the js components so they match the docs

Cool new feature: tabs-navigation can be used without specifying ids
(if you're brave)

ping @lifeiscontent

@agius looks pretty good man! Nice work.
Do you like the show/shown/hide/hidden convention I talked about for events better than open/opened/close/closed? Or how do you feel?

I'm open to show/shown - maybe make that a separate PR? Would prefer to end fractal branching ASAP


feat: add nav bar theme feature to entire os-code website 🪄✨

Close #1493
Screenshots

SAMPLES FROM TWO PAGES

HOME

CONTACT

Note to reviewer

This feature is in beta stage for all of the major browsers like Firefox, Chrome.
But for now it can finely work on Mobile Chrome, Safari & Vivaldi Etc.
The screenshots are taken on Vivaldi Browser for demonstration.

Checklist:

[x] I have linked the PR to the correct issue.
[x] I have read the Contribution Guidelines
[x] I have built and tested the changes, and they do not break or show any errors.

@Vaishnavi-Patil2211 Please merge this PR.


How to link a playnite entry with a custom game entry

Hello,
Here is my problem:
I admit I cracked Kingdom Hearts and I think that's why ludusavi can't find my savegame automatically (I even checked the manifest because I thought it was an update problem, but it's not). Too bad, so I make a custom entry following the paths indicated by PCGamingwiki but Playnite still tells me that it doesn't find any data. So the question is : how to make ludusavi-playnite know that my Kingdom Hearts entry corresponds to such custom entry, so that it can finally find my savegame, no matter if my game is cracked or not ? I can always backup my savegame manually with ludusavi but it's more convenient with the playnite extension.
Thanks a lot.

Hi! I don't know whether I'm allowed to comment on cracked games specifically, but that doesn't affect Ludusavi's behavior anyway. For any game (custom entry or otherwise), you just need to make sure that Playnite and Ludusavi are using the same name. Double check that the game title in your custom entry (and/or in the manfiest) matches the game title you have in Playnite. The titles have to be 100% identical, including capitalization and spaces, or else they won't link up.

Thanks for your answer
So I've modified the custom entry in ludusavi and it works properly now, the custom entry name was actually a little bit different ... So my bad lol. Thanks a lot for your help and thanks a lot for ludusavi, it works a LOT better than similar softwares I've used before :)

Thanks, I appreciate the kind words :D


Username being blocked by absence of validation

Hi,
I've created an account from work today without realizing that I didn't had access to my e-mails. Hence, I wanted to activate it later when I came back home. But, the validation is expired and now, my username is bagysied: Username has been already taken. :cry:
Expected result: a username is really booked only when the account has been properly activated.
EDIT: the password recovery works as a work around though.

Thanks your feedback!

Expected result: a username is really booked only when the account has been properly activated.

So what to do when both users are activated at the same time?

Since, it managed to be fixed by going for the lost password session. It could tell something along those lines.
Ooops, it seems that this username already exists. If it's yours, you may want to Sign in.

Ooops, it seems that this username already exists. If it's yours, you may want to Sign in.

This looks good but too verbose in my opinion.
Account already exists tells enough information that username is used by you or someone else.

Perhaps delete the account if the validation expires and hasn't been activated yet?

@matt-h that is what exactly in my mind, a expiration time for inactive account(PS: admin can remove them manually in admin panel right now).

@Unknwon Yup, you're probably right.
Probably then, the activation page should (or could) give you a way to re-send a fresh activation link or something.

@greut I believe there is a re-send button....

Dammit, epic fail ;-) Let's close this then.

@greut :wink:


How to specify the imagePullSecrets in the Grafana.yaml

How to specify the imagePullSecrets in the Grafana.yaml?
not able to make this work, tried a couple of configs similar to this one none of them seems to works, please advise
spec:
  ingress:
    enabled: True
  baseImage: private-repo/grafana:7.3.10
  imagePullSecrets:
    - name: private-repo

is your image pull secret linked to the grafana-serviceaccount? If you're using openshift then the command would look like this.
oc secrets link service-account-name <pull_secret_name> --for=pull
This is assuming that you have created a secret already.

yes it is linked, and it works, bu we want to see if its possible to configure as I mentioned above

@maximiano86 image pull secrets are part of spec.serviceAccount, so in your CR it should look like:
spec:
  ingress:
    enabled: True
  baseImage: private-repo/grafana:7.3.10
  serviceAccount:
    imagePullSecrets:
      - name: private-repo

Hi @maximiano86, can you try out Peter's suggestion and tell us if it works? We still need to document this. Thanks!

We have generated API docs that now is up to date, you can find it here for future reference: https://github.com/grafana-operator/grafana-operator/blob/master/documentation/api.md#grafanaspecserviceaccount


Magic comments that contain frozen_string_literal: true with other directives are marked as violations

Rubocop correctly approves of files that have a comment like # frozen_string_literal: true. You can also combine multiple magic directives by writing something like # -*- encoding: ASCII-8BIT; frozen_string_literal: true -*-. This doesn't work for me right now.
Example / steps to reproduce:
$ cat example.rb
# -*- encoding: ASCII-8BIT; frozen_string_literal: true -*-

foo = 'bar'
puts foo.frozen?

$ ruby example.rb
true

$ rubocop example.rb
Inspecting 1 file
C

Offenses:

example.rb:1:1: C: Missing frozen string literal comment.
# -*- encoding: ASCII-8BIT; frozen_string_literal: true -*-
^

1 file inspected, 1 offense detected

$ rubocop -V
0.41.1 (using Parser <IP_ADDRESS>, running on ruby 2.3.1 x86_64-darwin15)

It is also valid to split these magic comments into multiple lines:
$ cat example.rb
# encoding: ASCII-8BIT
# frozen_string_literal: true

foo = 'bar'
puts "encoding: #{foo.encoding}"
puts "frozen:   #{foo.frozen?}"
$ ruby example.rb
encoding: ASCII-8BIT
frozen:   true

Maybe the better solution here would be for the ruby style guide to take a stance on these options. I think the preferred style should be one magic comment per line. Then rubocop could enforce this rule instead and the frozen string magic comment cop wouldn't have to do more complicated parsing

Hm. I agree that the style guide could take sides here, but I think even if it does, it would be nice to have the cop tell you to split it into separate lines rather than (incorrectly) saying it's missing. That could also open up for auto-correct.
@backus: Do you have a link to where this is documented? I had honestly never seen it before.

I learned about it through Parser's codebase
I can't find any explicit documentation. Best links I can find just point me to the parsing logic for irb and ruby itself:

IRB's magic-file.rb
MRI's parse.y

Here is how it is used in Parser: https://github.com/whitequark/parser/blob/master/Rakefile#L39

@Drenmi this is the only other resource I can really point you too: documented via assertions in rubyspec. Ruby's magic comments try to support both emacs and vim style. It doesn't include it in the example but I believe the example I gave works because emacs style magic comments are separated with semicolons (https://www.gnu.org/software/emacs/manual/html_node/emacs/Specify-Coding.html).

Awesome @backus! Thanks for the research effort.

Interesting, thanks for the info @backus and @Drenmi. Even if the style guide takes a stances on this, it is still something that RuboCop should be able to parse in multiple formats. That does unfortunately add complexity to RuboCop. As far as I can tell, there are 3 possible magic directives that can be specified in Ruby encoding, frozen_string_literals, and warn_indent. RuboCop has a cop for frozen_string_literal and encoding. Both of these cops would to be able parse magic directives in any form or order.

I think we should have a style guide entry favouring one directive per line and the use of the Ruby comment syntax, but that being said - obviously it'd be better if we processed properly all valid scenarios.

On the topic of magic comments: it would be nice if the style guide also included a rule that said that magic comments should be separated from source code by a blank newline. Example:
*Good
# frozen_string_literal: true

class Foo
end

Bad
# frozen_string_literal: true
class Foo
end

As far as I can tell, there are 3 possible magic directives that can be specified in Ruby encoding, frozen_string_literals, and warn_indent. RuboCop has a cop for frozen_string_literal and encoding. Both of these cops would to be able parse magic directives in any form or order.

@rrosenblum Esoteric ruby trivia: warn_past_scope is also a magic comment but you'll probably never see it because it needs a special compiler flag. I'm looking into this issue now so figured I would add this factoid :smile:

PR here to fix this issue https://github.com/bbatsov/rubocop/pull/3879
I also opened a style guide PR for the things we discussed here https://github.com/bbatsov/ruby-style-guide/pull/616

Esoteric ruby trivia: warn_past_scope is also a magic comment but you'll probably never see it because it needs a special compiler flag.

You are right, I did not know about this one. I have not seen any information on it before now.

@bbatsov @rrosenblum updated. I updated Style/Encoding as well. As far as I can tell there was two test cases that were testing invalid encoding comments (# vim:fileencoding=utf-8). See the commit message for more context

On the topic of magic comments: it would be nice if the style guide also included a rule that said that magic comments should be separated from source code by a blank newline.

Hey, sorry for bringing this up again, but is this just a style decision or is there a reason for this to be found in the Ruby parser?
It's a also a bit weird to see in the Ruby styleguide, first it's ok to have it, then on the bottom it isn't anymore.


Test updates. Begin Reflex Search test

Jeremy should be an assignee too.

I agree. I asked him to request membership of RapturePlatform/Rapture project in order to do this.


work out why "how are my brakes" isn't working

Reported by Gianfranco - I don't think I've been able to reproduce this

closing as it's now a duplicate - suspension / brake damage reporting enable flag rework will fix this issue


Revert "Fix singletonof(TableType, ::IteratorRow)"

This reverts commit f03d25dcb03ad360f25be0e0b4dafb359265a8db.
https://github.com/tkf/BangBang.jl/commit/f03d25dcb03ad360f25be0e0b4dafb359265a8db didn't work with Transducers.jl: https://travis-ci.com/tkf/Transducers.jl/builds/136061826
https://github.com/tkf/Transducers.jl/pull/82

Codecov Report

Merging #47 into master will decrease coverage by 0.81%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   91.43%   90.62%   -0.82%
==========================================
  Files          18       18
  Lines         292      288       -4
==========================================
- Hits          267      261       -6
- Misses         25       27       +2

Impacted Files
Coverage Δ

src/NoBang/singletonof.jl
100% <100%> (ø)
:arrow_up:

src/zygote.jl
0% <0%> (-100%)
:arrow_down:

src/BangBang.jl
66.66% <0%> (-33.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03d25d...c5ba241. Read the comment docs.

I think the main problem was:
julia> Tables.istable(Vector{Union{}})
true


Swapping variable values using destructuring technique

What version of this package are you using?
<EMAIL_ADDRESS>What operating system, Node.js, and npm version?
ubuntu 18.04.4 LTS
node v12.16.1
npm 6.14.2
What happened?
Unexpected behavior when linting this short piece of code to swap values from two variables using destructuring technique.
let val1 = 1
let val2 = 2;
[val2, val1] = [val1, val2]

Only when adding a semicolon as shown above, the Linter validates the code as correct.
What did you expect to happen?
I was expecting that no semicolon was necessary. If I remove the semicolon, many errors are thrown.

@jluisgarcia thank you for using Standard and for taking the time to report your issue. This is one of the few cases where is semicolon is necessary, because the [ would otherwise be understood as an accessor to the value resolved from the expression before it. I recommend placing the semicolon at the start of that line: ;[val2, val1] = [val1, val2]


Fabric from environment variable

When configuring fabric using SKYDIVE_ANALYZER_TOPOLOGY_FABRIC, for example "TOR1->*[Type=host]/eth0" the analyzer do not start and log "Fabric configuration should be a list of entries"
This started post the commit  https://github.com/skydive-project/skydive/commit/b762f2b4c23f16dd6ef29f35e1ca54724796607d#diff-8b4b9d729a1da4e230b1b3002a9485ca
@lebauce @hunchback

We tried:
SKYDIVE_ANALYZER_TOPOLOGY_FABRIC='{"item1":"TOR1->*[Type=host]/eth0"}' ~/go/bin/skydive
analyzer
and
SKYDIVE_ANALYZER_TOPOLOGY_FABRIC="["TOR1->*[Type=host]/eth0"]"  ~/go/bin/skydive analyzer
and got:
Failed to create analyzer: Fabric configuration should be a list of entries

Addressed by https://github.com/skydive-project/skydive/pull/1713


Provide offsets into the read to explicitly search

This could be useful if we want to search at the start of the read.
Consider a second option to end a given number bases from the end of the read.

will not fix, use #13 instead


discord won't display that you left ingame or use /vanish

It seems that the vanish fake leave doesn't show in the discord.

Check your vanish config. Is it configured to show fake leave/join messages?

Yes, it is.

Are you using the latest version of the mod? (1.7.0)

Yes. Do I have to delete old files? as show above picture. It is 1.7.0

Could you give me a modlist?

Modlist is all the mods install in the server right?

Yes, I need that

Here's all the mods that our server uses. Thank you very much.

I'm not sure if this is related, but i get this in my startup log when using vanish + d4f
https://pastebin.com/TeNnki01


PROGRAM: Health Bar

takes damage accordingly and dies at 0 health. health bar changes with damage taken


Drone - Server ROS

Drone - Server communication.

This issue pertains to a [drone]_client repo. Please see DjiMatrice_client and Mavros_client for more.


Add failed test stories to artifact of model regression workflow

What problem are you trying to solve?
We have seen a couple of instances of performance drops in scheduled model regression workflow (this and this) over the past 2 months but we couldn't reproduce any of them post-hoc. We tried reproducing these by just re-running the workflow, however none of the manual re-runs (done at least 10 times) displayed a drop in performance.
Moreover, both the times the drop is observed only on the sara dataset with rules + ted config. Here's a filtered view in metabase that shows the drop in two instances on this specific pair of config and dataset
We suspect this could be one of the two problems:

The test dataset has an unknown skew towards a particular action which sometimes is not being learnt by the pipeline resulting in a failure on particular test stories.
Something is problematic with the infrastructure on which the scheduled runs are carried out. There has been some discussion on this in the past but nothing conclusive came out.
There is a weird bug in how numbers are collected from the runs of rasa test and stored in metabase / how performance drop triggers are calculated.

We would like to be completely sure that its not a dataset / algorithmic issue to rule out the possibility of (1). While we have done multiple re-runs of these workflows in order to try and reproduce the drop but we haven't got any far with it. We would need to collect more diagnostic data as part of these runs in order to investigate further.
What's your suggested solution?
When you run rasa test core, it outputs two artifacts - results/failed_test_stories.yml and results/story_confmat.png (assuming results is the folder where the output is generated). It would be great if we can add these two artifacts to the output artifact bundle that is generated by the workflow run.
Since there will be many reports created (one for each combination of config and dataset), here's a suggestion on how this could be structured in the artifact bundle:
diagnostic_data
|
|--- <dataset-name>
|           |
|           |
|           |---- <config-name>
|           |             |
|           |             |
|           |             |------ failed_test_stories.yml
|           |             | ------ story_confmat.png

Note that these artifacts will only be generated for the configs which evaluate dialog policy performance, i.e. the ones present here and mentioned in the config-map here
Examples (if relevant)
No response
Is anything blocking this from being implemented? (if relevant)
No response
Definition of Done

[ ] Above suggestion implemented for scheduled and on-demand (for debugging purposes) model regression workflow runs
[ ] Tested by a member of the research team to verify if the output is indeed what's needed.

@dakshvar22 this isn't actually supposed to be on our board, right? I'm wondering if the tool:model-regression-tests label triggers rasabot to move it to our Inbox?

Yeah looks like a "feature" of the automated setup. I'll move it to infra