Role-Based authorization not working in asp.net core 2.1

Describe the bug
I followed the instruction on documentation and online about the role authorization, but the authorize since doesn't work even after I add the role type to my database. It always lets the user access the resources no matter what the user role is. I don't see why and have not idea what I am missing in my startup. Any helps will be appreciated.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '2.1'
Run this code '....'
With these arguments '....'
See error

Expected behavior
It should reject the user request to the API, but it doesn't.
My startup.cs
    public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

        public IConfiguration Configuration { get; }

        // This method gets called by the runtime. Use this method to add services to the container.
        public void ConfigureServices(IServiceCollection services)
        {
            services.Configure<CookiePolicyOptions>(options =>
            {
                // This lambda determines whether user consent for non-essential cookies is needed for a given request.
                options.CheckConsentNeeded = context => true;
                options.MinimumSameSitePolicy = SameSiteMode.None;
            });

            services.AddDbContext<ApplicationDbContext>(options =>
                 options.UseMySql(Configuration.GetConnectionString("DefaultConnection")));
            //role service
            services.AddIdentity<IdentityUser, IdentityRole>()
                .AddRoles<IdentityRole>()
                .AddEntityFrameworkStores<ApplicationDbContext>()
                .AddDefaultTokenProviders();

            services.AddTransient<IEmailSender, AuthMessageSender>();
            //Disable the Password Hash
            services.AddScoped<IPasswordHasher<IdentityUser>, MyPasswordHasher>();

            var migrationsAssembly = typeof(Startup).GetTypeInfo().Assembly.GetName().Name;
            //using the aspnetIdentity, the server will read the userdata via identity API

            services.AddIdentityServer()
                  .AddDeveloperSigningCredential()
                  .AddConfigurationStore(options =>
                  {
                      options.ConfigureDbContext = builder =>
                       builder.UseMySql(Configuration.GetConnectionString("DefaultConnection"),
                       sql => sql.MigrationsAssembly(migrationsAssembly));
                  })
                  .AddOperationalStore(options =>
                   {
                       options.ConfigureDbContext = builder =>
                           builder.UseMySql(Configuration.GetConnectionString("DefaultConnection"),
                           sql => sql.MigrationsAssembly(migrationsAssembly));

                       // this enables automatic token cleanup. this is optional.
                       options.EnableTokenCleanup = false;
                       options.TokenCleanupInterval = 30;
                   })
                    .AddAspNetIdentity<IdentityUser>();

            services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Version_2_1);
        }

        private void AddAspNetIdentity<T>()
        {
            throw new NotImplementedException();
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IHostingEnvironment env, IServiceProvider serviceProvider)
        {
            if (env.IsDevelopment())
            {
                //InitDatabase(app);
                app.UseDeveloperExceptionPage();
                app.UseDatabaseErrorPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
                app.UseHsts();
            }
            app.UseAuthentication();
            app.UseHttpsRedirection();
            app.UseStaticFiles();
            app.UseCookiePolicy();
            app.UseIdentityServer();

            app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller=Home}/{action=Index}/{id?}");
            });
            //CreateRoles(serviceProvider).Wait();

        }

        /// <summary>
        ///
        /// </summary>
        /// <param name="serviceProvider"></param>
        /// <returns></returns>
        private async Task CreateRoles(IServiceProvider serviceProvider)
        {
            var RoleManager = serviceProvider.GetRequiredService<RoleManager<IdentityRole>>();
            var UserManager = serviceProvider.GetRequiredService<UserManager<IdentityUser>>();
            IdentityResult roleResult;
            string[] roleNames = { "Admin", "User" };
            foreach (var roleName in roleNames)
            {
                var roleExist = await RoleManager.RoleExistsAsync(roleName);
                if (!roleExist)
                {
                    roleResult = await RoleManager.CreateAsync(new IdentityRole(roleName));
                }
            }
            await<EMAIL_ADDRESS>"Admin", serviceProvider);
            await<EMAIL_ADDRESS>"User", serviceProvider);
            await<EMAIL_ADDRESS>"User", serviceProvider);
            await<EMAIL_ADDRESS>"User", serviceProvider);
            await<EMAIL_ADDRESS>"User", serviceProvider);

        }
        private async Task AddRoles(string Email,string Role ,IServiceProvider serviceProvider)
        {
            var UserManager = serviceProvider.GetRequiredService<UserManager<IdentityUser>>();
            IdentityUser user = await UserManager.FindByNameAsync(Email);
            await UserManager.AddToRoleAsync(user, Role);
        }

### The API I want to protect
[Authorize(Roles = "Admin")]
        public IActionResult About()
        {
            ViewData["Message"] = "Your application description page.";

            return View();
        }

Additional context
Thanks, guys. I will update more information later.

When you put a break point in your about function and look at the user does it actually have roles in?

Also you're not adding authorization anywhere.
You need to

We're closing this issue as no response or updates have been provided in a timely manner. If you have more details and are encountering this issue please add a new reply and re-open the issue.


Duplicate Event Attributes

Problem
When submitting a transaction that is executed by either the init or handle function in a smart contract, when events are emitted, attributes are duplicated. This happens for all event types except message. This only happens during smart contract transactions. No dup events are produced when calling blockchain modules directly via RPC or CLI.
wasmd version =  v0.15.1 ; See here
Example
See here as an example of the steps to demonstrate this issue.
Simply storing then instantiating the above integration test contract will produce the following output.
{
  "height": "17",
  "txhash": "9B84C4DE0C8582DE5D6B10AC227EECA57C0ACA1EDB9F6DC9BE80C44C8658039F",
  "codespace": "",
  "code": 0,
  "data": "0A3A0A0B696E7374616E7469617465122B0A2974703138766438667077787A636B3933716C776768616A3661726834703763356E383978386B736B7A",
  "raw_log": "[{\"events\":[{\"type\":\"message\",\"attributes\":[{\"key\":\"action\",\"value\":\"instantiate\"},{\"key\":\"module\",\"value\":\"wasm\"},{\"key\":\"signer\",\"value\":\"tp1f2ecech5swn8na2scfdxshhqjpapgdcq9dywh0\"},{\"key\":\"code_id\",\"value\":\"1\"},{\"key\":\"contract_address\",\"value\":\"tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz\"}]},{\"type\":\"name_bound\",\"attributes\":[{\"key\":\"address\",\"value\":\"tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz\"},{\"key\":\"name\",\"value\":\"name-itv2.sc.pb\"},{\"key\":\"address\",\"value\":\"tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz\"},{\"key\":\"name\",\"value\":\"name-itv2.sc.pb\"}]},{\"type\":\"wasm\",\"attributes\":[{\"key\":\"contract_address\",\"value\":\"tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz\"},{\"key\":\"integration_test\",\"value\":\"v2\"},{\"key\":\"action\",\"value\":\"provwasm.contracts.name.init\"},{\"key\":\"contract_name\",\"value\":\"name-itv2.sc.pb\"},{\"key\":\"contract_owner\",\"value\":\"tp1f2ecech5swn8na2scfdxshhqjpapgdcq9dywh0\"},{\"key\":\"contract_address\",\"value\":\"tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz\"},{\"key\":\"integration_test\",\"value\":\"v2\"},{\"key\":\"action\",\"value\":\"provwasm.contracts.name.init\"},{\"key\":\"contract_name\",\"value\":\"name-itv2.sc.pb\"},{\"key\":\"contract_owner\",\"value\":\"tp1f2ecech5swn8na2scfdxshhqjpapgdcq9dywh0\"}]}]}]",
  "logs": [
    {
      "msg_index": 0,
      "log": "",
      "events": [
        {
          "type": "message",
          "attributes": [
            {
              "key": "action",
              "value": "instantiate"
            },
            {
              "key": "module",
              "value": "wasm"
            },
            {
              "key": "signer",
              "value": "tp1f2ecech5swn8na2scfdxshhqjpapgdcq9dywh0"
            },
            {
              "key": "code_id",
              "value": "1"
            },
            {
              "key": "contract_address",
              "value": "tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz"
            }
          ]
        },
        {
          "type": "name_bound",
          "attributes": [
            {
              "key": "address",
              "value": "tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz"
            },
            {
              "key": "name",
              "value": "name-itv2.sc.pb"
            },
            {
              "key": "address",
              "value": "tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz"
            },
            {
              "key": "name",
              "value": "name-itv2.sc.pb"
            }
          ]
        },
        {
          "type": "wasm",
          "attributes": [
            {
              "key": "contract_address",
              "value": "tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz"
            },
            {
              "key": "integration_test",
              "value": "v2"
            },
            {
              "key": "action",
              "value": "provwasm.contracts.name.init"
            },
            {
              "key": "contract_name",
              "value": "name-itv2.sc.pb"
            },
            {
              "key": "contract_owner",
              "value": "tp1f2ecech5swn8na2scfdxshhqjpapgdcq9dywh0"
            },
            {
              "key": "contract_address",
              "value": "tp18vd8fpwxzck93qlwghaj6arh4p7c5n89x8kskz"
            },
            {
              "key": "integration_test",
              "value": "v2"
            },
            {
              "key": "action",
              "value": "provwasm.contracts.name.init"
            },
            {
              "key": "contract_name",
              "value": "name-itv2.sc.pb"
            },
            {
              "key": "contract_owner",
              "value": "tp1f2ecech5swn8na2scfdxshhqjpapgdcq9dywh0"
            }
          ]
        }
      ]
    }
  ],
  "info": "",
  "gas_wanted": "149128",
  "gas_used": "147619",
  "tx": null,
  "timestamp": ""
}

It can be seen that the attributes have been duplicated for both our custom blockchain module (type name_bound), as well as those attributes emitted by the integration test smart contract (type wasm).

It seems that with the release of wasmd v0.16.0, we're no longer seeing dup events in Provenance for our smart contracts.  Unsure if this is related to our updates or wasmd updates, but it seems this is no longer an issue.  Feel free to close unless you'd like to investigate further.

Yeah, there were a lot of fixes in wasmd 0.16. I assume this one was intentionally fixed, just not closed on the issue.
@alpe you meant to do this, right? Want to close?

This still needs to be fixed but it did not make it into v0.16.0. We also have https://github.com/CosmWasm/wasmd/issues/448 which seems to be related

I have watched some events on init and can not see or replicate the issue.
Closing this now.


Can't update or uninstall microsoft.tye

Describe the bug
I'm updating a solution from .netcore 3.1 to .net6.
As part of that I am trying to update my install of Tye. I keep getting the following error.
I have closed all applications and restarted but still the same.
To Reproduce

Further technical details

Include the output of tye --version

The platform (Linux/macOS/Windows)

Windows 11

List of all global tools installed

To workaround this issue for now. I manually deleted the files related to Tye in the .dotnet\tools folder and then install Tye again.


crash on android 5.1.1, ID #0x2040003 error

Bug description:

I upgrade my expo sdk from 35 to 36, and Webview from react-native is removed. Therefore I have to use Webview from "react-native-webview".
android 5.1.1 will produce error String resource ID #0x2040003, I googled it and it seems like most of this happen on 5.1.1.  There was no problem before but it is happening after I upgrade my sdk. Anyone can fix this? otherwise I have to downgrade my sdk : (
To Reproduce:

expo sdk 36

use WebView normally it will produce the error.  I try all kind of version but it failed on expo client and standalone app they all has this error.

Expected behavior:

Expected work normally.
Screenshots/Videos:

String resource ID#0x2040003
Environment:

OS: Android
OS version: 5.1.1
react-native version: 0.61
expo-sdk: 36
react-native-webview version: all version

I downgraded my expo sdk to 35, and still having this issue. I tried to reinstall my expo client (EXPONENT 2.13.0), and it works again.

I think it is expo run-time issue.
https://github.com/expo/expo/issues/6665

i have the same problem on sdk 33 34

This is a bug found on androidx.appcompat:appcompat:1.1.0 which is expo currently to use.
1.2.0 will fix it, and expo waiting for the 1.2.0 stable version.


Change test timeout for extension unit tests to 10sec

It was previously at 600sec which seems like a bit much for these tests and would mean any hanging test would slow down everything else as it waited for the huge timeout to be reached (and usually just end up hitting the build timeout or something in the lab). I see no reason these tests should be taking nearly that long so moving the timeout down to a more reasonable 10sec.

Do we know how long these tests usually take?  i.e., is 10 seconds enough to provide adequate buffer for typical execution time variability.

I don't have hard metrics, but a couple ad-hoc runs on my machine don't show any above 4 seconds. These are essentially unit tests (no network access or UI manipulation) and so they should be short. I figure 10 seconds is a good baseline to start with and if we run into issues we can address them then, although if a test is taking more than 10 seconds I would typically be more in favor of trying to reduce the test time than increasing the timeout since these are ran as part of PR validation.


refactor Refactor stats

update docs
session variable
update docs
update docs
ut
ut
add more test
remove enable_auto_sample
core function finished
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Help wanted, temporary not able to maintain the repo

Hi,
I wanted to let you know that I'm temporarily not able to maintain this repo and integration. Unfortunately I have been struck with a lot of misfortune.
A year ago I had a stroke due to a trauma to my neck and have struggled quite a bit with the late effects of that. Despite this, I have been working at my day job as a software developer and, among other things, made this integration on a hobby basis.
In January, my youngest child was diagnosed with Leukemia (AML blood cancer) and we have been hospitalized since.
Unfortunately, I haven't had the opportunity or energy to follow up on any of the issues that have come in here on github, so I hope that maybe there is someone else who has the time and opportunity to join as a maintainer and help me until I'm back again.
I love to make integrations and share with the community and I know many of you use this every day and I really want to make this integration easier and better for everyone.
If you have any questions please feel free to reach out to me.

Agh, sad to hear all this, brother. But stay strong!
They say:

Tough times don't last. Tough people do.

Thank you for kind words!
I'm happy to say that my youngest is much better and we are finished with chemotherapy!
I added @ohshazbot to the repo, and I will gradually return to normality.
Thank you for your patience! <3

Great integration and great news


Export static icons

Export static icons so people can create custom buttons without having to host buttons for them.

I don't understand how this fails and main doesn't. Diving in deeeper...


[FEA] Support Triton ensemble runtime for SageMaker multi-model deployment

🚀 Feature request
I was wondering if it is possible to support the SageMaker multi-model deployment using the Triton ensemble of Merlin models.
SageMaker already supports multilpe hosting modes for Model deployment with Triton Inference Server, including the Multi-model endpoints with ensemble hosting mode. I tried to use that hosting mode with the Triton ensembles of Merlin models, but according to the last update of the Merlin SageMaker example implementation #1040, the --model-control-mode=explicit control mode (required by multiple models hosting for dynamic model loading) was removed.
I hypothesize that the cause of this incompatibility is due to the generated Merlin executor_model is not a proper Triton ensemble (since its config.pbtxt file doesn't have the correct platform platform: "ensemble", neither the required ensemble_scheduling: {...} section), but just another Triton model that executes the 0_transformworkflowtriton and 1_predictpytorchtriton steps internally. Therefore, the executor_model it's not automatically recognized as the ensemble of the 0_transformworkflowtriton and 1_predictpytorchtriton models to be executed.
EDIT: I realized that in merlin-systems PR#255 the Triton ensemble runtime was deprecated and changed to the current executor model. It is possible to support the option of exporting the recommender system artifacts as a Triton ensemble, at least for Transformers4rec systems deployment?

Moved this issue to the merlin-systems repo: #393.


How to use a callback for specialized lexing?

In short, instead of passing a token or regex pattern, I want to pass a function that would return Option.
such as:
#[derive(Logos)]
enum Keyword {
  #[token(let)] Let,
  #[token(if)] If,
  /* ... */
  #[error] Error,
}

#[derive(Logos)]
enum Token {
  #[error] Error,
  #[/*here would go some way to lex a str into a Keyword*/] Keyword(Keyword)
}

currently I have to do the following:
#[derive(Logos)]
pub(crate) enum Keyword {
  #[token("let")] Let,
  #[token("if")] If,
  /* ... */
  #[error] Error,
}

fn lex_keyword(lex: &mut Lexer<Token>) -> Keyword {
  Keyword::lexer(lex.slice()).next().unwrap()
}

#[derive(Logos)]
pub(crate) enum Token {
  #[regex(r"let|print", lex_keyword)]
  Keyword(Keyword),

  #[error]
  Error,
}

which isn't very ergonomic

@jvcmarcenes are you wanting to write a callback inside the #[regex(..)] macro? You can write the callback in the macro too like is shown throughout some of the examples by the author:
https://github.com/maciejhirsz/ramhorns/blob/9f2ed4d3d173cc835dc0a281662b0a8e87a348f2/ramhorns/src/template/parse.rs#L21-L26


Customize Figure/Equation references

When I reference an internal equation/figure/section the first letter of the resulting text is always capitalized (e.g. Section, Figure, Equation). Is there a way to make the text appear in lower case, or for the linked reference to appear in text as a different user defined string (eg Figure X would appear as Fig. X)?

Also here #117.

Also section (header) references fit into the category


Set status for console command transactions

Currently console command transactions are added with status unknown. As a result, the error rate in queues is incorrect if a message was produced in a console command. This change sets the status ok if the exit code is 0 and the status internal error otherwise.

Thanks!


Variable-Dependent Results

I apologize if the issue name isn't very clear.  I am super new to JSON, and I'm not even sure how to summarize what I'm trying to achieve.
I would like to be able to use one variable to base other variable generation upon.
For instance:

"We are {groceryQty} groceries this week. Please go buy {groceryList}."

{groceryQty} table might look like,
"out of"
"low on"
"good on"
"fully stocked on"
If groceryQty = "out of", then {groceryList} would generate a string of 3d4 items from {purchaseList}.
If groceryQty = "low on", then {groceryList} would generate a string of 2d4 items from {purchaseList}.
If groceryQty = "good on", then {groceryList} would generate a string of 1d4 items from {purchaseList}.
If groceryQty = "fully stocked on", then {groceryList} would output "No Groceries Needed".
Furthermore, if it's possible, I would love to add some "required" items to the list.  It'd be even more awesome if this could be based on the {groceryQty} result.
If groceryQty = "out of", then {groceryList} would add "Pizza" to the list.
If groceryQty = "low on", then {groceryList} would add "Salad" to the list.
If groceryQty = "good on", then {groceryList} would add "Cheese-Its" to the list.
If groceryQty = "fully stocked on", then {groceryList} would add nothing to the list.
If there happens to already be a way to do any of these things, I would really appreciate an example/tutorial.

I would use something like this:
{
"resultPattern": "We are {groceryQty} groceries this week. Please go buy {var:item{var:num}}.",
"variables": {
"item1": "{purchaseList}",
"item2": "{var:num1} {purchaseList}",
"item3": "{var:num2} {purchaseList}",
"item4": "{var:num3} {purchaseList}",
"item5": "{var:num4} {purchaseList}",
"item6": "{var:num5} {purchaseList}",
"item7": "{var:num6} {purchaseList}",
"item8": "{var:num7} {purchaseList}",
"item9": "{var:num8} {purchaseList}",
"item10": "{var:num9} {purchaseList}",
"item11": "{var:num10} {purchaseList}",
"item12": "{var:num11} {purchaseList}"
},
"tables": [
{
"name": "groceryQty",
"entries": [
{
"v": "out of",
"set": {
"num": "{dice:3d4}"
},
"v": "low on",
"set": {
"num": "{dice:2d4}"
}
}
]
}
]
}

Thank you so much for your response!
I've got some of how this works hashed out, but I'm not sure how the items/purchase list are supposed to work.  Can you explain the theory to me and I might be able to figure it out from there?

It's a recursive pattern (at least I intended this :-) ):

you roll e.g. 3d4 and get 7
this will produce var:item7
item7 will call var:item6 and append {purchaseList}
item6 will call var:item5 and append {purchaseList}
...
item1 just contributes {purchaseList}
in the end you'll get 7 times {purchaseList} (one from item1, which gets used in item2 plus the one appended in item2 gets you 2, which get used in item3 plus one appended by item3 which gets you 3, etc. until item7 append its purchaseList to the six from item6

You may want to add a comma or linebreaks (\r\n) between purchaseList calls.

Thank you for your response!!
I broke up the ideas you gave into pieces to see if I could get each one working individually.  I did manage to figure out how to get the grocery list to call last night--and even figure out how to get the commas in there and pick unique values by using {!purchaseList}.  I used the variable list like you suggested, plus I added 2 tables: an Item table with an entry of each var:item#, and a purchaseList table for the grocery item options.  When I call "resultPattern":"{item}", it selects a random {var:item#} from the item table and outputs lists of varying lengths, all unique values.  So far, so good.
Then I started working on the "groceryTable" part you suggested, but I'm getting a weird result occasionally that maybe you can help me out with.  I'm not sure my syntax is correct when I set up the "groceryQty" table, with the "v" value and "set" num quantity.  The values don't seem to matching the set values, and occasionally the values won't be displayed at all--resulting in "We are grocieries this week" (however, it does still output the list at the end).
"tables": [
	{
		"name": "groceryQty",
		"entries": [
			"v": "out of",
				"set": {
				"num": "12"
				},
			"v": "low on",
				"set": {
				"num": "{dice:3d4}"
				},
			"v": "okay on",
				"set": {
				"num": "{dice:2d4}"
				},
			"v": "fully stocked on",
				"set": {
				"num": "{dice:1d2}"
				}
	]
	},

We are okay on groceries this week. Please go buy Spaghetti.

This output should be at least 2 items (2d4 = minimum of 2)

We are fully stocked on groceries this week. Please go buy Lunch Meat, Juice, Eggs, Soup, Bread.

This output should only be 1 or 2 items

We are groceries this week. Please go buy Pizza.

This output doesn't have a value at all.
I cannot figure out why it's doing this.

So I just realized I got a little bit ahead of myself there.
It's disconnected because I'm not using the attached "num" value, I'm pulling the list from a totally separate table.  I did this just to see if I could get the list working at all, and then added it to the table without remembering that I still need to have the value and the number connected.
So the real issue is that when I set the resultPattern to include {var:item{var:num}} (which should still call from the variable list just fine) I get this error:
{var:item<error calling non-existent variable 'num' from 'User-defined Generator JSON'>}
Plus I am still getting blank-value returns (We are  groceries this week).

Try adding curly braces to complex entries:
"tables": [ 	{ 		"name": "groceryQty", 		"entries": [ 			{ "v": "out of", 				"set": { 				"num": "12" 				} 			}, 			{ "v": "low on", 				"set": { 				"num": "{dice:3d4}" 				} 			}, 			{ "v": "okay on", 				"set": { 				"num": "{dice:2d4}" 				} 			}, 			{ "v": "fully stocked on", 				"set": { 				"num": "{dice:1d2}" 				} 			} 	] 	},

That was part of the problem, for sure.  No more blank values, and it looks like the number is matching up properly to the value.  We are almost there!!
However, I am still getting "{var:item#}" instead of the list.
This is my resultsPattern:
"resultPattern": "We are {groceryQty} groceries this week.\r\r{var:item{var:num}}",

I figured it out!!!  I moved some things around.  I thought maybe putting one variable inside another right in the resultPattern was causing the issue, so I tried moving the variables.  It ended up looking like this:
{
	"resultPattern": "{var:item}",
	"variables": {
	"item": "We are {groceryQty} groceries this week.\rPlease buy {var:item{var:num}}.",
	"item1": "{!purchaseList}",

I don't know if this is very good practice, so if there's a more proper way to set this up, I'd love to know.
Other than that, it works!!!

Hey, so I used the Grocery Generator as a basis to create a much more complex Town Generator.
I feel like such a newbie, but I've never done this before.  Do I just upload my generator for public use?

Congratulations!
You can create your own branch in this repository and upload your generator there. If you want more visibility and perhaps even feedback, you could announce the generator in the Campaign Logger Google+ group: https://plus.google.com/u/0/communities/109734413216289457602
I'm eager to see what you have come up with!

@evesala , I'm not sure how to do that.  I looked up how to make a new branch, but either the method changed or I'm just totally missing something.  =/

Ok, I think I got it.


Convert min & max to Number

I received an error because min/max were strings.  Here's how I changed the code to fix it.
var translationMap = {
	title: {key: 'label'},
	minimum: {key: 'min', type: Number},
	maximum: {key: 'max', type: Number},
	exclusiveMinimum: {key: 'exclusiveMin', type: Number},
	exclusiveMaximum: {key: 'exclusiveMax', type: Number},
	minLength: {key: 'min', type: Number},
	maxLength: {key: 'max', type: Number},
	minItems: {key: 'minCount', type: Number},
	maxItems: {key: 'maxCount', type: Number},
	'default': {key: 'defaultValue'}
};
...
_.each(translationMap, function(spec, jKey) {
	if (typeof source[jKey] !== 'undefined') {
	     target[spec.key] = spec.type ? spec.type(source[jKey]) : source[jKey];
	}
});

This has been implemented and deployed to atmosphere. The only change I had was to change the type for exclusiveMin and exclusiveMax to Boolean instead of Number. Thanks again for your contributions.


Getting 503s for basic Thorchain routes (ETH<>FOX) in Gome

Overview
Currently in Gome, while testing rFOX, I was able to recreate swapper errors related to Thorchain that do not exist and are unable to be recreated in prod
References and additional details
Jam of the issue: https://jam.dev/c/1815a467-fe05-407c-b9bc-9d388ef892ae
Unable to be recreated in production currently.
Acceptance Criteria
Users are able to use TC trade routes through swapper and we do not have errors when fetching TC quotes.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

Related to current midgard bork in develop, see pools calls in prod vs. develop endpoints:


Fix focused state color for library navigation tabs

Bug Description
Currently library navigation tabs just use action color for showing focus. Once UX has decided, replace with proper color.
Current design without focus:

Current design with focus:

Desired design with focus:
TBD
Expected Behaviour
TBD
Steps to Reproduce

Click a library tab
Press tab and then shift + tab to see tab with and without focus.

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Closed by #544


Object::read should check eof

Currently, object::read  (layer::read, or others...) is not checking eof, it acts like it read successfully even though it failed to read

:octocat: cibot: Thank you for posting issue #698. The person in charge will reply soon.

After adding this, a lot of test fails because they are sharing model.bin.

closed with #720


[move] Hello world mutation testing

Motivation
Creates the boilerplate for mutation testing, allowing the user to introduce a single mutation of operation (addition to subtraction), as a proof-of-concept.  This PR does not attempt to change the testing framework directly, leaving that work for a separate PR, since I both want to separate the work here to avoid delaying this PR and to get feedback on this direction before delving into using the check-inconsistency flag as a reference.  Instead, this PR just introduces a pass (which may be a no-op) to the bytecode compiler.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Testing is done manually for this commit, though I'm open to trying to introduce negative testing (since the mutations being done ought to lead to errors).

/land


Particle transport mini-app

A mini-app that randomly sources particles in the global bounding box and transports them throughout the model w/ some sampled isotropic scattering, providing diagnostic information along the way would be really useful. Optical thickness could be fixed or sampled w/in some range each time a particle enters a new volume.

Addressed by #16


Update Share Report Modal

Before:

After:
https://user-images.githubusercontent.com/39493102/133440199-375e68a0-b501-4ba5-bf9b-4520bcd304df.mp4

Merged with View Report Revamp


add event for playfield transfer

fix #540

Coverage increased (+0.0005%) to 92.827% when pulling fcdccc2d7ff5ef8479cc543aecc33fe4f4fa392c on playfield_transfer_event into b1f74a0e9d273cc04d9f470de9fc8c075e42d73c on dev.

Coverage increased (+0.02%) to 92.844% when pulling fcdccc2d7ff5ef8479cc543aecc33fe4f4fa392c on playfield_transfer_event into b1f74a0e9d273cc04d9f470de9fc8c075e42d73c on dev.


Proxy fix http auto shutdown

Problem
I found a bug in hyper_util::server::conn::auto where graceful_shutdown on Connection while it's in the ReadVersion state is a no-op.
Summary of changes

Vendor the code from hyper_util::server::conn::auto.
Remove any dead code.
Call read_version manually and remove the ReadVersion state from Connection.
Add a timeout for read_version so we can shutdown properly.
Make use of the alpn to skip read_version.

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Actually, looks like the bug was fixed, only in the main branch of hyper-util atm.


Payment Channel

Payment channel implementation

See https://github.com/Zondax/filecoin-signing-tools/pull/257


An error occurred while handling textDocument/codeAction request: NoSuchMethodError: The getter 'id' was called on null.

I'm getting the following error whenever I hover over some underlined problems in my code in VS Code.
Many problem types don't cause this, but it is consistently reproducible on, for example, this problem:

[Error - 12:13:03 PM] Request textDocument/codeAction failed.
  Message: An error occurred while handling textDocument/codeAction request
  Code: -32001
[Error - 12:13:03 PM] An error occurred while handling textDocument/codeAction request: NoSuchMethodError: The getter 'id' was called on null.
Receiver: null
Tried calling: id
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:54:5)
#1      FixProcessor._addFixFromBuilder (package:analysis_server/src/services/correction/fix_internal.dart:1741:22)
#2      FixProcessor._addFromProducers.compute (package:analysis_server/src/services/correction/fix_internal.dart:1768:9)
<asynchronous suspension>
#3      FixProcessor._addFromProducers (package:analysis_server/src/services/correction/fix_internal.dart:1782:11)
<asynchronous suspension>
#4      FixProcessor.compute (package:analysis_server/src/services/correction/fix_internal.dart:1724:5)
<asynchronous suspension>
#5      DartFixContributor.computeFixes (package:analysis_server/src/services/correction/fix_internal.dart:185:19)
<asynchronous suspension>
#6      CodeActionHandler._getFixActions (package:analysis_server/src/lsp/handlers/handler_code_actions.dart:311:23)
<asynchronous suspension>
#7      Future.wait.<anonymous closure> (dart:async/future.dart)
<asynchronous suspension>
#8      CodeActionHandler._getCodeActions (package:analysis_server/src/lsp/handlers/handler_code_actions.dart:261:21)
<asynchronous suspension>
#9      ServerStateMessageHandler.handleMessage (package:analysis_server/src/lsp/handlers/handlers.dart:187:22)
<asynchronous suspension>
#10     LspAnalysisServer.handleMessage.<anonymous closure> (package:analysis_server/src/lsp/lsp_analysis_server.dart:302:26)
<asynchronous suspension>

Dart SDK Version (dart --version)

PS> dart --version
Dart SDK version: 2.13.4 (stable) (Wed Jun 23 13:08:41 2021 +0200) on "windows_x64"

Thanks for the report.
It's a little hard to tell because the stack trace doesn't line up with the current version of the code, but based on the method in which the exception occurred and the name of the getter being invoked it looks like this has been fixed:
  void _addFixFromBuilder(ChangeBuilder builder, CorrectionProducer producer) {
    var change = builder.sourceChange;
    if (change.edits.isEmpty) {
      return;
    }

    var kind = producer.fixKind;
    if (kind == null) {
      return;
    }

    change.id = kind.id; // <--
    change.message = formatList(kind.message, producer.fixArguments);
    fixes.add(Fix(kind, change));
  }

There doesn't appear to be any way for id to be invoked on null.
However, I don't know how to verify that the null check, which was added on 4/12/21, isn't in 2.13.4. The dates make that seem unlikely, but I can't think of any other way you could be seeing what you're seeing.

I deleted flutter/bin/cache and then had the Dart SDK reinstalled. Still same issue.
flutter/bin/cache/dart-sdk/bin/snapshots/analysis_server.dart.snapshot has a file date of 6/30/2021 (as do all the other files in that folder).
Flutter + Dart versions from doctor -v output:
[√] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.19043.1165], locale en-US)
    • Flutter version 2.2.3 at C:\flutter
    • Framework revision f4abaa0735 (9 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

Do you have reproduction steps you could send? Even an update stack trace would likely be helpful.

In looking at the tag list on the commit that introduced that check (https://github.com/dart-lang/sdk/commit/050fa8a70a5c4b4df36d70176a00eb3bc3ae5369), 2.13.4 is not one of them. In fact, that commit has never been included in any non -dev tag.

Yeah, I don't think those tags are accurate. We aren't developing directly on GitHub anymore, the source is somewhere else and mirrored to GitHub. My guess is that the non-dev tags aren't being copied over for some reason.

This appears fixed in the changeset linked above. The changeset was not included in v2.13.x SDKs:
https://github.com/dart-lang/sdk/commits/2.13.4
But was included in v2.14.x SDKs:
https://github.com/dart-lang/sdk/commits/2.14.0?after=4c8a4f0d7ad055fa7dea5e80862cd2074f4454d3+2290&branch=2.14.0&qualified_name=refs%2Ftags%2F2.14.0
I verified the current latest code also still has the null check noted above.
Please post back if you see it on an SDK >= v2.14.0.


Automate.log output in the Web UI

Chapter 3.1 recommends to monitor automation.log, but doesn't say how:
either SSH into the appliance then
$ vmdb
$ less log/autiomation.log
OR navigate to Automation, Automate, Log in the Web UI

several chapters ask for checking the automate.log, e.g chapter 3.4 Start VM Pre-Migration, but there is no information what the user should look for. It might be helpful to give a bit more clues.

Good point. Adding reminders of it in the doc as it is only explained in 2.4

Added!.


Bump version number to 1.3.0

Hi and thanks for the effort, but I had to adjust some stuff anyway, so I bumped myself (usually do this anyway directly in concert with tagging and pushing the pod).

thank you!


Authentication missing in OAS

Your OAS file is missing authentication. Looking at your OAS with Swagger, all paths appear to be unsecured and do not require authentication, even though they do. Can you fix this?

hi @henning410 , given that opportunity i have also added a swagger ui available at path /ui.
Please feel free to check it and provide any feedback!


Still able to reply in archived workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging dot on chrome and login with User 1
Create a new workspace and change the name of the workspace to identify easily
Invite User 2
Go to announce of the workspace and send any message
Next login with User 2 on another web chrome and go to same announce
Click on reply on thread and send any message
Now come back to User 1 Account , go to #announce room and now delete the workspace. After that for few moments, app crashes.
Go to User 2 account and click on the workspace unavailable (archived)
Result : Try to send message again and see that the user 2 is still able to reply to messages on archived workspace. (if you check from the User 1 account, refresh the page and see still messages are being delivered)

Expected Result:
Should not be able to reply in archived workspace
Actual Result:
Still able to reply in archived workspace
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.16-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/35b9e99f-43bd-41e4-808e-2c9d207f5f40
https://github.com/Expensify/App/assets/43996225/dbbdb113-cc04-409c-9c54-de5d7c005c9d
Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684385991118289
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Still able to reply in archived workspace
What is the root cause of that problem?
We are checking if the current report isArchiveRom in order to hide the footer, but in this case the parent of the report is archived, but the children is not archived yet. That's why we still can reply to the thread.
https://github.com/Expensify/App/blob/8180113819532fe5503bc3719ba46ffc566e4ead/src/pages/home/report/ReportFooter.js#L67-L74
What changes do you think we should make in order to solve the problem?
We should update the logic of isArchiveRoom, if the report has parentReportID we also should to check if the report from parentReportId is already archived.
/**
 * Whether the provided report is an archived room
 * @param {Object} report
 * @param {Number} report.stateNum
 * @param {Number} report.statusNum
 * @returns {Boolean}
 */
function isArchivedRoom(report) {
    if (report.parentReportID) {
        const parentReport = lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]);
        return lodashGet(parentReport, ['statusNum']) === CONST.REPORT.STATUS.CLOSED && lodashGet(parentReport, ['stateNum']) === CONST.REPORT.STATE_NUM.SUBMITTED;
    }
    return lodashGet(report, ['statusNum']) === CONST.REPORT.STATUS.CLOSED && lodashGet(report, ['stateNum']) === CONST.REPORT.STATE_NUM.SUBMITTED;
}

What alternative solutions did you explore? (Optional)
NA
Result
https://github.com/Expensify/App/assets/16502320/1da6dbfc-8e73-4ef7-8740-18fc52c29945

it looks like we're still waiting for proposals / for @mollfpr to review proposals.

Thanks for the ping @maddylewis!

@hungvu193 The solution for archived reports looks good to me, and we can use isThread to check the report. What do you think about the crashing issue? Did you find any root cause?

@mollfpr which crashing issue, may I know it?

@hungvu193 You can check the first video attached at 1:22 and step 7 in the OP.

Ah I see. I couldn't reproduce after applying my solution. But I'll take a look after a while

@mollfpr
I found the error, somehow Bootsplash.hide() get called. The stype inside hide() function is now undefined since we already removed it after the app hide the splash screen. That's pretty weird, but we can add null safety here to prevent crash. Anw, I couldn't reproduce after applying my proposal.

We optimistically set the reports' workspace status to archived, but we are missing the thread report key from the DeleteWorkspace API response. Navigate to the deleted workspace thread report also does not receive the status archived from the OpenReport API response.

Optimistic archived thread
https://github.com/Expensify/App/assets/25520267/325fba2b-5eee-4e93-9549-00d73b88f379

 Open thread report from the deleted report should return the `statusNum` to `2`
https://github.com/Expensify/App/assets/25520267/17b30afd-9c4e-4e17-a57d-3c3e70ac2f40

@MariaHCD I think this needs an update on OpenReport and DeleteWorkspace to return the thread report archived status.

Here is the screenshot for the crash issue. I can't reproduce it often and don't have a step for it.

@MariaHCD I think this needs an update on OpenReport and DeleteWorkspace to return the thread report archived status.

Oh, interesting. I will take a closer look on Monday.

@MariaHCD I think this needs an update on OpenReport and DeleteWorkspace to return the thread report archived status.

@mollfpr Some questions for you :)

DeleteWorkspace optimistically sets all reports under that workspace as closed (status 2) here, right? Why do we need to return the status of each thread report from the API?
You're suggesting to have OpenReport also return the report status, correct? Is this in addition to the frontend changes that @hungvu193's proposal outlines?

DeleteWorkspace optimistically sets all reports under that workspace as closed (status 2) here, right? Why do we need to return the status of each thread report from the API?

Correct. We can do nothing in here. My only concern is the OpenReport response still presents the thread report status as 0, and it's not aligned with the optimistic data.

We will probably go with the proposal from @hungvu193 makes sense to check with the parent if it's archived—no hassle to update the API.
@MariaHCD Let me know if this makes sense to you.

My only concern is the OpenReport response still presents the thread report status as 0, and it's not aligned with the optimistic data.

Oh, nice catch. We definitely need this information to be correct in the backend. I'm going to double check that the API is correctly marking thread reports as archived when DeleteWorkspace is called.

So it does look like we're not currently archiving thread reports when a workspace is deleted. I've started an internal discussion about this and will update here once I know more!

Discussed with maria on slack. I believe this should be an internal issue.

Continuing to work on this internally.

Internal issue is here: https://github.com/Expensify/Expensify/issues/289694
This will be on HOLD for the above issue. We can retest this after the backend changes are complete.

We're still working on this internally

We're working on outlining an internal fix for this. Downgrading this to match the internal issue: https://github.com/Expensify/Expensify/issues/289694

still waiting on this one - https://github.com/Expensify/App/issues/19361#issuecomment-1580570249

still holding! https://github.com/Expensify/Expensify/issues/289694

No updates to report just yet

Just got back from ooo, no updates yet

Sorry, I'm focusing on other priorities at the moment. Trying to see if anyone else can pick this up.

No updates just yet.

@MariaHCD - just checking to see if this one is still on hold

Still on hold, sorry, no progress just yet!

Unable to make progress on this due to other higher priorities :(

Still on hold for the backend issue.

No updates just yet.

Still no updates

Focusing on higher priority issues currently

Hiya Kev, I dropped BZ so I am going to remove myself from this issue since there's no immediate action no take. This is an internal issue and we're waiting for Maria to have some space to take another look at this one.
lmk if you have any questions about anything!

Hey @MariaHCD any update on this one?

Any update on this @MariaHCD ?

Back from ooo, will try to resume on https://github.com/Expensify/Expensify/issues/289694

still on hold

No updates on the backend changes required for this just yet: https://github.com/Expensify/Expensify/issues/289694

Progress is being made in the internal issue: https://github.com/Expensify/Expensify/issues/308026
Internal PRs:

https://github.com/Expensify/Auth/pull/9297
https://github.com/Expensify/Web-Expensify/pull/40590

Still on hold for the internal PRs above.

This should be fixed now. @kevinksullivan would you please verify if it's fixed and let us know if anything else is needed?

Tested on the latest main branch, this issue is fixed 🚀


Update install-document-routing-agent.md

:x: Organization membership check failed
Members of the MicrosoftDocs organization should use the private repo. Please move your changes to https://github.com/MicrosoftDocs/Dynamics-365-Operations, and close this pull request.


Necessary tasks to make --compacting-gc the default

(YOU CAN LOOK, BUT THINKOS MAY BE INSIDE...)
8459514233 reverted the GC strategy to copying, this is the commit that needs to be backed out.
Methods with pros/cons
So I propose to do the dumbest thing that works, for now. From what I understood we have two alternatives:

allocation-time check with 3GB limit (pros: simple; cons: Cycles overhead per allocation, dead data may trigger rejection, queries could be penalised unnecessarily)
post-GC check with 3 GB limit (pros: cheap, dead data not counted, query-fairness; cons: stable variables’ footprint may overshoot the (de)serialisation limits of 1 GB when streaming).

Hazards
Several hazards lurk in the upgrade process

DAG-like stable variable data gets serialised to trees, blowing up size
serialisation buffer may overflow due to huge stable variable volume (FIXED: #3149)
stable memory may get exhausted (if many regions allocated already)
deserialisation buffer eats up too much heap space to successfully unpack
streaming back stable variables overshoots the heap

The danger of overshooting the serialisation buffers is intuitively tallied in the following table.

Superseded by incremental GC.


How to install this? Im a newbie here!

Hello ! I don't know how to install smooth scroll from zip?
Im running Sierra 10.12 now!!
Please can anyone help me out with steps?

are you making websites? this is for website developers
If you are a regular user
Also available as a Mac app
http://www.smoothscroll.net/mac/
Or as a Chrome extension
https://chrome.google.com/webstore/detail/smoothscroll/nbokbjkabcmbfdlbddjidfmibcpneigj
And Opera extension
https://addons.opera.com/extensions/details/smoothscroll-3/


No errors are reported in JS

Completion works, but Oni doesn't report errors in JS files for me. Here is an example file and my jsconfig.json:

Should it work in general? I saw the feature in README.md but not listed here (like "error reports" with a "+"):
https://github.com/extr0py/oni/wiki/Languages#javascript-and-typescript
EDIT:
Some versions ago I saws the error "Unreachable return statement", but this doesn't show up anymore. This was the only error I saw reported by Oni.

It looks like the TypeScript language server requires you to 'opt-in' to JavaScript errors - https://github.com/Microsoft/TypeScript/wiki/Type-Checking-JavaScript-Files
Seems like there are two ways to opt-in:

Set the checkJs option to true in your jsconfig.json
Add // @ts-check to the top of your js file.

I just tried out the latter - adding // @ts-check, and it worked for me (it picked up the javascript errors).  Seems like VSCode behaves the same way. Let me know if that works - might be worth adding to the wiki if so.

// @ts-check is enough to get error reports working. Unfortunately this isn't a option for me, so I stick with Neomake till this is fixed in the language server. Do you by chance found a ticket somewhere which tracks this?
checkJs does nothing for me.

Thanks @hoschi for trying it out! I'll keep this open since it's a blocker. There might be a way to set this as a default in the typescript standalone server settings, so I'll use this to track that.

@bryphe thanks, this would be great!


Jens Modell to RainbowModel Software Architecture, Performance Test

LeaveOneOut
More epochs
less sensors

In order to do the LeaveOneOut tests, it makes sense to bring Jens Model in our own software architecture
Before: Get the same performance on the sensor subset (ca 88% accuracy) without LeaveOneOut

windowize creates much more windows in our version -> compare

where are the window differences (in the beginning of each activity) time dependency

same labeling?

i think this issue is already processed and probably even already merged so it will be closed


Scope of cloud operating environment claims

@bharveyTX  do later

We need to expand upon the concept that a TOE Developer/ST Author must define in their TOE Platforms what public cloud resources. For instance a TOE developer must claim Product Version X on Cloud Provider Y with Compute Resource Z. All mandatory SFRs must map to this Cloud OE. If the Cloud OE can not fulfill an SFR, then that Cloud OE can not be included in the evaluation as it is not an appropriate TOE Platform.


New package: TPLib v0.1.0

Registering package: TPLib
Repository: https://github.com/JuliaTPLib/TPLib.jl
Created by: @JuliaTPLib
Version: v0.1.0
Commit: cf4d4c0c21e589c54987a59f3ddb85f49d950077
Reviewed by: @JuliaTPLib
Reference: https://github.com/JuliaTPLib/TPLib.jl/commit/cf4d4c0c21e589c54987a59f3ddb85f49d950077#commitcomment-100572661
Description: Julia wrapper for the Tropical Polyhedra Library

Hi,
I understand that the auto-merge has failed because the name of this package is similar to that of there packages. However, that it to be expected for libraries that follow the conventional names ending in Lib. In these cases, the preceding letters are most often meaningful acronyms, and the risk of confusion is minimal. For example, in the 5 other packages listed as having a similar name, none of them contain both letters TP except TSPLIB. This library reads .tsp files associated to the Travelling Salesman Problem, and therefore cannot be confused with TPLib.
Finally, this library provides a wrapper for the TPLib library written in OCaml, and therefore it would make sense for it to share the same name.
I would therefore appreciate a manual review for this request. Thanks a lot !


fixes: #405 Formatted the code using prettier

Closes #405
formatted the code using prettier and added required packages
Changes

formats every *.js or *.jsx file in the “scripts/”
Related Issues

Issue #405

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[x] Extend the documentation, if necessary
[x] Merging to master from fork : master

I tried my level best to solve this , I signed all the commits but the last one is always left out , please help me out @irmerk

If you're unable to solve it, I would recommend just starting a new branch and ensuring you put the signoff on the commit(s) when you begin and open a new PR.
So when you commit: git commit --signoff -m 'INSERT TEXT'

If you're unable to solve it, I would recommend just starting a new branch and ensuring you put the signoff on the commit(s) when you begin and open a new PR.
So when you commit: git commit --signoff -m 'INSERT TEXT'

should I close this PR and create a new one?


Time Svaer Duplication issue still persistent

Hi @tduniec,
I have tried using the latest version of the TimeSaver plugin backend (4.1.0), but unfortunately, it still did not resolve the issue. The problem persists even with the updated package.
Originally posted by @Venkat279A in https://github.com/tduniec/backstage-timesaver-plugin/issues/35#issuecomment-2462517527

Hi tduniec,
Hi @tduniec,
Just checking in to see if you had a chance to look into the issue we discussed. Any insights on implementing those would be greatly appreciated!
Thanks again for your support!

Hello @Venkat279A
I think the issue should be fixed now in 4.1.1 -> please check it out (I have some data problems to test it on my own now)


test: do not run load tests on deployed dev env

References: https://github.com/omisego/elixir-omg/issues/1428
Overview
As currently tests of load tests do not measure performance drops and are just smoke tests of load test scenarios functionality I removed running them from CI job.
Changes
Removes running smoke load tests on build_test_deploy CI job.

wait, why?

wait, why?

They just do not test anything regarding deployed env at the moment. We do not collect anything, compare it with prev. runs, etc. No point in running it unless we measure performance on the dev env.
Smoke tests alone are still being run on PRs. But they just test if scenarios themselves are working.

we do have something. At least you can go to Datadog afterward and see what is there. It can also potentially trigger error to be catch as regression though not on performance but on load. (Though there is no hook back to flag test as failed at this point)
However, my biggest concern is that unless we are sure that we do not want to automate this as a future goal. Otherwise we need step by step code merge anyway. This is discouraging moving that path. Also, it has seen to be a SOP that we want some load in new env from what I see in recent releases/deployment.

btw, I am looking at the new configs today. So if we want to move forward with this and keep the style of lots of env var. Probably we can just put all configs into one to simplify the configs 🤔
The only reason to have multiple configs was to 1:1 mapping with environments we have, which I think will get a lot more stable after the release process get fixed. I personally still think that makes good sense and fit greatly into a CI/CD pipeline with multiple env.
Meanwhile, the config file could be like ENV_VAR || default_vale so that we don't need to pass the env var in MakeFile. It looks weird to me 🤔. I don't really think that makes much sense actually. (the contract addresses, private key, urls in make file) I think config should be preferred unless you are looking for extra control or the data is confidential.

Meanwhile, the config file could be like ENV_VAR || default_vale so that we don't need to pass the env var in MakeFile. It looks weird to me thinking. I don't really think that makes much sense actually. (the contract addresses, private key, urls in make file) I think config should be preferred unless you are looking for extra control or the data is confidential.

On one hand it makes a lot of sense and makes things easier for our devs. But on the other, those default values are crafted for us. If people from outside omsisego clone the repo, starts running it, those default values probably won't make sense for them.
I agree that putting those env vars in Makefile isn't cool, but I have no good ideas how to handle it differently.

we do have something. At least you can go to Datadog afterward and see what is there. It can also potentially trigger error to be catch as regression though not on performance but on load. (Though there is no hook back to flag test as failed at this point)

I think I get your point. I agree, proper automation of running perfomance test should be done. But I don't think it's now. We have just one smoke test running that puts a couple thousands of utxos into the child chain. We don't know yet
what that tells us about degradation in performance. You are right we can check DataDog, but is anyone doing it? To make it sustainable it should be automated.

Also, it has seen to be a SOP that we want some load in new env from what I see in recent releases/deployment.

That makes sense.

If people from outside omsisego clone the repo, starts running it, those default values probably won't make sense for them.

I think I messed up a bit on the paragraph so leads a bit confusion. If we are going your way and give up automation until we are perfect, my proposal is having single config with default value to local host (docker-compose). So even an open source contributor can run against the default local service. Whoever wants to run in different environments, pass in the env var.
But honestly I am not really buying "other people might run it" concept personally. I know it is controversial, but practically speaking nobody else is running beside us. And even there are, I don't see reason to not optimize for ourselves. This code is mainly for us anyway. We can make their life easier only after we have made our life easier.

We have just one smoke test running that puts a couple thousands of utxos into the child chain

We do have other scenarios in omg-load-testing not ported yet though.

what that tells us about degradation in performance. You are right we can check DataDog, but is anyone doing it? To make it sustainable it should be automated.

So what is the next step? My feeling is that we would just stop here, write some more scenarios and that is it. It is fine if we agree to do that due to resource/priority reason. But I don't think that is the ideal path.

To make it sustainable it should be automated

probably we could try to call data dog api at the end of the test for two things:

General Error rate. This can potentially be used as an indication to rollback the deployment.
Performance metric.

Even we might not know what is a good threshold yet, it is worth to have report to learn just like the gas cost in contract repo. 🤔
But I guess this depends on what feat-launch-n-load team want to do. cc. @ unnawut @kevsul


Failed to add reference to 'System.Runtime'. Please make sure that it is in the Global Assembly Cache.

Not sure where to post this...
I have the following project.json using several frameworks from .NET 4, all the way up to 4.6.1 and also Serilog is added as a global dependency, while all the frameworks except .NET 4 also have Serilog.Sinks.EventLog as an additional dependency. If I remove the System.Runtime references I get 37 of these errors:

Severity  Code    Description Project File    Line    Suppression State
Error   CS0012  The type 'Exception' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.    Bridge.Logging..NET Framework 4.5, Bridge.Logging..NET Framework 4.5.1, Bridge.Logging..NET Framework 4.5.2, Bridge.Logging..NET Framework 4.6  C:\Bitbucket\Bridge.Logging\Source\Bridge.Logging\LogEventEnrichers\ExceptionEnricher.cs    52  Active

If I publish my NuGet package and then try to install it, I get the following error:

Failed to add reference to 'System.Runtime'. Please make sure that it is in the Global Assembly Cache.

Why am I being forced to add System.Runtime and what does this achieve?

We've also just hit this, see https://github.com/elastic/elasticsearch-net/issues/1774
Setting "type": "build" as @RehanSaeed mentioned above does seem to do the trick, but I have no idea what the implications are.  Is there any documentation on this?

Also just ran intom this. Same concern as gmarz.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


PR for issue/73

Fixes #73

Current coverage is 100.00%

Merging #80 into master will not affect coverage as of a96c9e7

@@            master     #80   diff @@
======================================
  Files           35      22    -13
  Stmts          356     410    +54
  Branches        37      26    -11
  Methods          0       0
======================================
+ Hit            356     410    +54
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of a96c9e7

Powered by Codecov. Updated on successful CI builds.


Servlet backends should provide session as a request attribute

Anything that uses this is not portable outside a servlet container, but it offers better integration with servlets, which is probably why most users would use a servlet container over blaze in the first place.
A more radical suggestion would be to provide the HttpServletRequest in an attribute key.  In addition to the session, we'd get request attributes and the servlet context (which is available through the session, but only if there is a session).   We'd also get dangerous things, like the ability to start an async servlet context.  If we go this far, it would be a deeper servlet integration, but it would also come with sharp edges.
See also #104 and https://github.com/hgiddens/http4s-session
/cc @toby5box

The HttpSession has been exposed for quite some time.


Zeek v4.1 compatibility

Plugin updates for Zeek v4.1.x compatibility

Rename deprecated (now removed) "bro" references to "zeek"
Fixed various issues in .cc and .pac files for namespaces, renamed
types, intrusive pointers, include file locations, etc.
Standardized some of the btest files and regenerated
test output with btest.

Tested to install in both Zeek v4.0.4 and Zeek v4.1.1.

LGTM. Thanks for the contribution, and apologies for the delay in reviewing/merging!


clean top level driven experience

I would like if we could upstream some of the work on #46 to utop or dune so that rtop can be integrated automatically on it.
A standard dune utop that detected that most of the project is in Reason or dune utop where you can setup an automated #required "rtop";; that changes the parser of utop would also do it.
Related
#46

This is what we want to achieve
#! /bin/sh

set -e

TMPDIR="$cur__target_dir/tmp";
mkdir -p $TMPDIR;
dune top | sed "s/\;\;/\;/g" > "$TMPDIR/$cur__name.re";
rtop -init "$TMPDIR/$cur__name.re" "$@"

This script also replaces #46

Dune utop works fine now.


Provide an NR1 CSS stylesheet for starter apps

Describe the solution you'd like
It would be very helpful if New Relic provided a NR1 CSS stylesheet to help developers get started without spending too much time creating their own stylesheets.
Describe why this important to you
Provide basic starter CSS code will help a new developer get up an running faster when building apps for the first time.
We already provide a few helper libraries, but perhaps we can expand these:  https://github.com/newrelic?q=layout&type=&language=

@jpvajda Does the nr1-community library satisfy this requirement? That provides some out-of-the box components for devs to use in their own custom apps. Thoughts?

@jerelmiller  I think it does for now, we can close this, though it would be nice to enhance that CSS library over time from outside contributors.


Rate limiter doesn't work at high frequencies?

I am trying to download ticker history for ~10k different symbols, and I am using the rate limiter to do so. This works if I ask it to limit my requests to one every two seconds or greater, but it seems to just ignore the rate limit if I ask for one request every second or even faster.
Two part question - what would be a reasonable speed at which to request this data? I didn't see any specific parameters on Yahoo's terms of use but maybe I missed them.
Second, is this a limitation by design? Should it be possible and I am doing it wrong? Or is it just a bug?

Nevermind, what was happening was that it was retrieving previously cached data although I was looking for new data. Disregard!

Nevermind, what was happening was that it was retrieving previously cached data although I was looking for new data. Disregard!


Add support for HTTP/2 with server push

One of the most powerful things about react-server is that the server-side knows, in a structured way, about all of the associated resources for a page (JS, CSS, JSON XHR) and could push them pro-actively. Not only would this theoretically be faster than the current code, it would also obviate the need for the ReactServerAgent cache, which would simplify the logic a lot in the HTTP/2 case.

Migrated from #50

From @kcjonson

When we took a look at this one at a Hackathon, Redfin was limited by our CDN, Akamai, on actual HTTP/2 deployment. I'm SUPER SUPER excited about HTTP/2 and the benefit for end users, so I'd love to help out with this in any way possible.
For this generic body of work, do we want to consider killing CSS and JS bundles for HTTP/2 requests? We'll still need to look at the dependency tree for a given route so that we know what to push, and we'll probably still need bundles deployed for non HTTP/2 browsers.
What does this mean for our loaders on the client? How does it relate to the other work item of allowing RootElements to have their own CSS?

FYI for anyone thinking of working on this issue: I know that @roblg poked at it and built a working prototype. Also, the biggest problem he ran into was that Express is not compatible with node's http2 library (for extremely byzantine reasons). He had to migrate from Express to connect to get it to work.
cc @withinboredom

From @withinboredom in #259:

I lately implemented a wordpress plugin for my workplace that turns this on. This is actually simpler than you'd think. I'm going to take a look under the hood of react-server and document the work that needs to be done and then we can figure out what to do about it.

Thanks @withinboredom!

I was able to use the spdy module to get an HTTP2 example together with express, code here: https://github.com/kcjonson/http2-boilerplate/tree/master

@withinboredom Any news on this?

I've been trying to keep my eye on this.  Work has been progressing pretty well on http2 in node core -- it looks like they're targeting having it available behind an experimental flag in node 8.  I've been periodically building and tinkering with the in-progress http2 branch, and I believe that barring anyone else having implemented this, I should have a PR open sometime in April.

@doug-wade great, thanks for the update!

FWIW, my thinking on this has changed a bit since I filed it in #50 after I went to Velocity this past fall and started poking at server push for a few weeks.
One of the talks I saw at Velocity (lightly) suggested that server push is generally probably a bad idea at this point. It turns out that, at least as of October or so, no browsers implement client cancellation of push streams when a resource is already in cache. So if you always blindly push all your affiliated static resources, you will lose the entire benefit of the browser cache on repeat visit, at least as far as bandwidth is concerned.
Additionally, the speaker I saw suggested that even if browsers did support cancelling push streams, it wouldn't result in a lot of perf saving because in many cases the server would end up sending down a lot of the pushed resource before getting the cancellation. (I vaguely remember the speaker saying something about a situation where the server can easily get most of the pushed resources into the network buffers before the stream cancellation comes back from the client, but don't quote me on that.)
There is a rough plan to fix this situation but it's pretty early days. There's a draft spec for Cache Digests, which would allow browsers to send a compressed digest of all the server's URLs in the browser cache. The server can check what's in the client's cache and use that to decide what to push and what not to push. Due to some clever math, the digest is quite compact over the wire, although that compactness comes at a price: the digest is probabilistic and allows for some chance of false positives. In case of a false positive, the server incorrectly will believe that the client has the resource in cache, but that turns out to be fine; it just means the browser will request the resource as usual.
I believe that no current browsers support cache digests, but I might be wrong. Until they do, though, I feel like http/2 push is probably not a great feature for react-server. There are some implementations, like the h2o server, that have hacked together cache digests implemented in HTTP cookies, but that feels pretty brittle to me and not worth the effort if real cache digest support is on its way eventually. YMMV, of course.
There's a good, long article about some of the tradeoffs here: http://calendar.perfplanet.com/2016/cache-digests-http2-server-push/

Wow, didn't know about the downsides, good points. This is something that should be communicated loud and clear in the infrastructure / performance communities.

That blog post mentions that Service Workers can polyfill HTTP/2 cache digests. On first load, the H2 server pushes everything. On second load, the browser hits the Service Worker, which can compute the cache digest itself and add it as a custom header to the request. The server can use the cache header to decide what to push and what not to push in the subsequent response.


combined circuit libraries, combined api references

What are the issues this pull addresses (issue numbers / links)?
n/a
Did you add tests to cover your changes (yes/no)?
No
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary

combined circuite library into one page
combined API references into one section

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I had approved this one. Just documenting since it does not show from the history.


Any work happening with this? I'd love to help

Hi, I'm also a developer, and would love to be able to turn off the device. How did you get the payload?

Unfortunately, it looks like Microsoft hasn't enabled any functionality outside of turning the Xbox on.  There are additional proprietary functions like the ones used by the smart glass app, but they all appear to be encrypted.
This module is a port of the original python version, and the payload was obtained using wireshark and a lot of trial and error.
Will definitely update this module to include additional functions if possible, but I'm afraid we're kinda stuck for now!

And thanks for the offer, would love to collaborate if any other news comes up!

Thanks for such a quick reply. I tried to use burp as a proxy but because
it's hitting the IP it's not doing the man in the middle attack to see the
payloads.
On Tue, Jun 28, 2016 at 5:17 PM Adam Robertson<EMAIL_ADDRESS>wrote:

And thanks for the offer, would love to collaborate if any other news
comes up!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arcreative/xbox-on/issues/5#issuecomment-229222177,
or mute the thread
https://github.com/notifications/unsubscribe/ABu5yloQCf6LZfv3OFoVONhLeRsoCfJBks5qQbmlgaJpZM4JAp4Q
.

Not sure, my network-level foo is not so strong lately :-)


fix kepare connect stack overflow

Codecov Report
Attention: Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (167acf8) to head (5fff18b).

Files with missing lines
Patch %
Lines

taos-ws-sys/src/lib.rs
88.67%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   70.98%   70.99%   +0.01%
==========================================
  Files          97       97
  Lines       34010    34060      +50
==========================================
+ Hits        24141    24180      +39
- Misses       9869     9880      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Generate scaladoc for all subprojects.

Use aggregate to run project tasks in subprojects
Use sbt-unidoc to generate combined scaladoc for project and subprojects.

lgtm

Unfortunately, due to the way sbt (doesn't) deal with subproject plugins, this requires adding the plugin to parent project plugins. We may wish to revisit this.


Modify docs build script

Changes proposed in this pull request:

Remove invalid command  cp -rf homepage/. target

Codecov Report

Merging #4404 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4404   +/-   ##
=========================================
  Coverage     53.19%   53.19%
  Complexity      351      351
=========================================
  Files          1048     1048
  Lines         19478    19478
  Branches       3619     3619
=========================================
  Hits          10362    10362
  Misses         8460     8460
  Partials        656      656

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b1feb...a2781cf. Read the comment docs.

Pull Request Test Coverage Report for Build 9695

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.623%

Totals

Change from base Build 9685:
0.0%

Covered Lines:
11029

Relevant Lines:
19478

💛  - Coveralls


Issue #558 Keepachangelog labels

This PR addresses issue #558 and adds support for the six standard categories of changes listed in keepachangelog (three more categories—deprecated, removed, security—are added to the three that already exist).
This functionality might be covered by the add_sections option, but I couldn't find any documentation around add_sections or configure_sections so it does not appear to be easy to do.
Besides, Keepachangelog is the current standard reference for changelogs and arguably the six categories it lists should be included as the standard default sections. Including these standard sections/labels in a changelog should not require a user to implement a custom configuration.
This is my first contribution to open source, so go easy! But I have found your gem very useful and I found an issue I could address that would help improve changelogs everywhere.

Point of order: Thank you so much for this PR!
(If you are up to documenting the new options, do that in a follow-up PR. This one is completely fine to merge in itself.)

Merging!

Hey, thanks for this feature.
I'd like to use but I don't know how. Could you add docs to README/Wiki/Links?

Hi there! A short note: the only metadata read by this tool is the Label data. You can add Labels to Issues and to Pull Requests.
Commit messages are not read or used.
Adding Labels matching these grouped lists of names will present that Issue or PR under a specific heading in the generated Markdown file.
I hope this helps!

I understand that, but that would kill me for existing projects with years of history :(
Sort by label is just one (now default) implementation of sorting issues/PRs. How to use own function to sort this by issue or PR message?
I know PHP only

@jennyknuth Thank you for adding this feature, just what I was looking for in this tool. And congratulations on your first contribution to open source! :cake: 🎆


Fix false-negative on EmptyLinesAroundAccessModifier

Fixes false-negative for EmptyLineAccessModifier when next line is a string starting with "end":
  class Test
    private
    end_this!
  end

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

After some thinking, decided to revert changes and just fix regex:

While I don't like regex here - it works
I need to rewrite whole class to keep code clear and solid. There are no enough reasons to do that.

👍


Add Awesome macOS open source applications.

https://github.com/serhii-londar/open-source-mac-os-apps
List of awesome open source applications for macOS. This list contains a lot of native and cross-platform apps. The main goal of this repository is to find open source and free apps and start contributing.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either fullwidth or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.
Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of sub-lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Drop all the A / An prefixes in the descriptions.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

@sindresorhus Can you review it? Or just give some feedback?

Not done:

Drop all the A / An prefixes in the descriptions.
Appropriate License: That means something like CC0, not a code licence like MIT, BSD, Apache, etc.

@legodude17 Thanks for your review!
I've fixed all issues. Please check it again.

Not done:

Drop all the A / An prefixes in the descriptions. - Try searching for  - A in the readme and looking through the results.
Doesn't include a Travis badge.

@legodude17 Thanks for your response! Done. Please check!

Suggestions:

Remove App that and phrases to that effect
You don't need to mention that they're open source
Remove the Sources folder?

@serhii-londar Can you address @legodude17 feedback and resolve the merge conflict so I can merge this?

@sindresorhus Thank for your review! I've just fixed all suggestions except removing Sources folder. I need it for the future to keep helping scripts. Can you check it?

@sindresorhus Thank you so much for merging it! 🎉 🎉 🎉


How to define Ingress annotations

The Kubernetes Ingress resource is a very shallow abstraction. Thus many ingresses use custom annotations to configure their behavior. For example traefik, nginx, kong, alb ingress controller.
What is the preferred way with acorn to set those annotations?

We currently don't support setting those. But, we're going to be doing more in the area of ingress and routing. Keep an eye out.

@hikhvar Are the examples of must have features that are provided through annotations.
One of the tricky things is that we want to ensure that the Acornfile stays infrastructure agnostic so we separate setting between what is in the Acornfile and what is conifgured at deploy time.
From a practical point we will be adding the ability to add labels/annotations to basically everything but I wonder if there's any value we can add by making some settings first class in the Acornfile DSL.
I'll personally also read through the referenced docs. Thanks.

So things I have configured in the past via ingress annotations:

Basic Auth Setup
Timeouts and Buffer sizes
In case of ALB ingress controller the used ACM certificate
Supported TLS Ciphers

Sadly, all those annotations are ingress controller specific. Moreover, it's very hard to identify which ingress controller ist used since the ingress class allows multiple ingress controllers to be deployed.

Time to just right our own ingress @ibuildthecloud? How hard could it be?

Another usecase: cert-manager will automatically manage certs for the ingress if a certain annotation is present
https://cert-manager.io/docs/usage/ingress/#how-it-works

Addressed in https://github.com/acorn-io/acorn/pull/632

Docs:

https://docs.acorn.io/authoring/labels
https://docs.acorn.io/running/labels


"SA1600 Elements must be documented" not working

It seems that the rule SA1600 is not working (anymore?), but the status page tells it has an implementation.
I tested this with an empty WPF project and beta008. The MainWindow constructor has no documentation, but no warning about SA1600 is given.

:question: Is MainWindow a partial class? If so, the applicable warning would be SA1601 instead of SA1600.

I found the issue. SA1600 is automatically disabled any time SA1652 is reported. This is the case for new WPF projects.
You need to enable documentation comment diagnostics for your project as described in SA1652 before any of the related diagnostics will be active.

Thanks - problem solved. Wasn't aware of that constraint as it was not present in the "old StyleCop".
As a side note: I had to disable CS1591 (which is basically the same as SA1600), because that one complained about missing XML documentation in the auto-generated Settings.Designer.cs files. But as SA1600 checks that "correctly" thats fine IMO (and avoids "double warnings" form both rules).

Glad it's fixed :+1:
Please feel free to stick around and comment on feature proposals and consider filing bugs/enhancement request if you run into trouble. :smile:

Wasn't aware of that constraint as it was not present in the "old StyleCop".

It's a limitation imposed by Roslyn that we unfortunately have little control over aside from reporting it as its own warning. We actually introduced SA1652 because of the number of bug reports that were filed related to this.

I actually disabled SA1652 because I thought it was not necessary, as I did not read the description :stuck_out_tongue_closed_eyes:. May add a little hint directly to that warning:
Enable XML documentation output - required by SA16xx or similar?
Thanks again for your feedback and great work!

I was today running into the same problem. But all the hints given here didn't help.
First, SA1652 went to SA0001, I've read. None of the changes (I tried all possibles) didn't help.
Then I installed StyleCop 1.1.0-beta006 and the problem was gone. I could force SA1600 to be an error when alanyzing in VS2017. There was no need do change SA0001/1652.
But then I pushed that project to CI. And there SA1600 was not reported as error, neither as warning. This I've again tried to change SA0001, also without success.
How can I force SA1600 to be an error on msbuild? I also tried the nuget package StyleCop.msbuild, unfortunately with the same result. For this package there is no beta which (I thought) could have fixed the issue.


Readme

Pull Request Test Coverage Report for Build 575

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 569:
0.0%

Covered Lines:
571

Relevant Lines:
571

💛  - Coveralls


CRAFT 4 info

Hey :)
You said you merged PR for craft 4 ..
but still not avaible to download in Craft store..
any info on that

I contacted Craft CMS, hope they can update it soon. Cheers!
cc @brandonkelly

thats all automatic,,
https://craftcms.com/docs/4.x/extend/updating-plugins.html#high-level-notes


Improve font icon management, sizing and sharpness

I was hoping to make a dead-simple PR to fix the icon blurriness (well, at least on a Mac OS with Retina, not sure how it looks otherwise), but I ended up spending waaaay too much time on this and also improving sizing, management, and some transitions.
Changes
From the commit messages:

Improve font icon rendering with font-smoothing
This makes all icons look sharper, and reproduces what is applied on the FontAwesome CSS

Define icon font only once and fix sizing

This commit applies the following across the whole style:

font statement is now the same as official FontAwesome CSS
Ensure icons are never italic or bold or that other variants can be applied
Ensure font-size and line-height of icons are inherited from parent
font-family and font-smoothing is now defined only once

A few (mostly positive) side effects from these and related changes:

Header icons (main menu, context menu and user list) are now vertically centered!
Same applies to the Send icon, but it's more subtle there
Alignment of the footer icons are shifted a tiny bit
Server window icons are a wee bit bit bigger to match the server name font-size
The "Play sound" icon and text are now both 14px (was 14px / 16px)

Add/fix/remove some CSS transitions

Transition on the search icon was removed, because why was it even here?!
A transition was added to the "Play sound" button
Transition on the Send button is now consistent with the others

Centralize all icon definitions for better management

Results
Note that these are are screenshots from Chrome 51 on Mac OS X El Cap with Retina, but I noticed extremely similar (if not identical) results with Firefox on the same machine.
Let me know if you see different results on other OS.

Le What
Before
After

Sharpness

Sharpness

Sharpness

Text/Icon alignment

Sizing

Nice, LGTM 👍 .

Looks all good to me, just look at my comment and then 👍

@maxpoulin64, ping on my answer to your comment? Are you good to go with this PR?


⚠ Bofrost.de has degraded performance

In 7e15bb1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1170 ms

Resolved: Bofrost.de performance has improved in dc79259.


Add parsing of contract abi types && Fix symbol precision bug

Add missing abi number types and contract abi types parsing. Fix symbol precision format bug where symbol's precision length is 0.

Thanks for the PR! Adding more additional types to enable more contracts to perform properly is always a good step forward.
Do you have an example contract/action where these types are used so we can test these out?

For token (fix symbol precision bug); jungle testnet, ram.token contract, symbol RAM

@aaroncox on jungle testnet you can test this PR with turbotest123 smart contract. In this contract there are two actions buy and sell with type parameter ttl_t which is a type alias for int32

Confirmed, seems to work well. We'll merge this into develop and get it released with the next build.


chisel !edit fails if !traces enabled

Component
Chisel
Have you ensured that all of these are up to date?

[ ] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.2.0 (cd7850b 2023-02-02T00:55:54.773018765Z)
What command(s) is the bug in?
chisel !edit
Operating System
Linux
Describe the bug
Trying to edit the source of the run function with !edit fails in this quite recent build. Rebuilding to latest master would take me too long, so just posting so:
alltrdz@beefy-dev:~/repos/beefy-onchain-harvester$ chisel
Welcome to Chisel! Type `!help` to show available commands.
➜ !edit
Traces:
  [135] 0xBd770416a3345F91E4B34576cb804a576fa48EB1::run()
    └─ ← ()

⚒ Chisel Error: Failed to execute edited contract!
➜ !so
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;

import {Cheats} from "forge-std/Vm.sol";

contract REPL {
    Cheats internal constant vm = Cheats(address(uint160(uint256(keccak256("hevm cheat code")))));

    /// @notice REPL contract entry point
    function run() public {}
}

➜ !t
Disabled traces!
➜ !edit
Successfully edited `run()` function's body!
➜ !so
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;

import {Cheats} from "forge-std/Vm.sol";

contract REPL {
    Cheats internal constant vm = Cheats(address(uint160(uint256(keccak256("hevm cheat code")))));

    /// @notice REPL contract entry point
    function run() public {
        uint256 ui = 88;
    }
}

➜ ui
Type: uint
├ Hex: 0x58
└ Decimal: 88
➜

is this still an issue?
@clabby mind taking a look at this?

I am not able to replicate this, edit works properly in latest version even with traces off

Please reopen if still an issue, thank you!

oops, sorry , the issue was traces enabled which still fails, reopening


[BUG] "Loading packages" not translated

Please confirm these before moving forward

[X] I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions.
[X] This issue is about a bug (if it is not, please use the correct template).

UniGetUI Version
3.1.0
Windows version, edition and architecture
Win 11
Describe your issue
The text "Loading packages" that is displayed in the tab Software updates is not translated (in Dutch)
Probably a fault pointer
Steps to reproduce the issue
Open the tab Software Updates
Click Refresh
UniGetUI Log
See attachment

Package Managers Logs
N.A.

Relevant information
No response
Screenshots and videos
UniGetUI-logboek.txt

More untranslated in 3.10

Ah, those are new ones in Tolgee.
I took care of these. Let's keep an eye for the next update.

Yes, they will take 24/48h to get updated


Allow more than one server behind traefik to manage their own certificates themselves via let's encrypt

Do you want to request a feature or report a bug?

Feature
What did you expect to see?

Allow more one server behind traefik to manage their own certificates themselves and via let's encrypt.
It is currently not possible to allow several servers behind traefik to manage their own certificates themselves via let's encrypt.
This can be done via a TCP router and a TLS passtrough for one server, but not for several : https://stackoverflow.com/questions/59971646/is-there-a-way-to-let-some-traefik-services-manage-their-tls-certificates-themse.
The likely cause of this limitation may be due to the following rule from https://docs.traefik.io/routing/routers/#configuring-tcp-routers:
It is important to note that the Server Name Indication is an extension of the TLS protocol. Hence, only TLS routers will be able to specify a domain name with that rule. However, non-TLS routers will have to explicitly use that rule with * (every domain) to state that every non-TLS request will be handled by the router.

Thanks for your interest in the project.
I'm not sure to understand your use case, and I'm not sure if it's not already possible to do what you need.
In order to give us more information about this, could you please join our Community Forum and reach out to us on the Traefik section.

Hello Julien,
I had already asked the community forum. I have just added some explanations to my question which is here: https://community.containo.us/t/is-there-a-way-to-let-some-services-manage-their-tls-certificates-themselves/4143/2
Please check if this seems more understandable to you and if necessary consider reopening my feature request.
Regards,
Jean-Mathieu

De: "Julien Salleyron"<EMAIL_ADDRESS>À: "containous/traefik"<EMAIL_ADDRESS>Cc: "Jean-Mathieu Chantrein"<EMAIL_ADDRESS>"Author"
<EMAIL_ADDRESS>Envoyé: Mercredi 22 Avril 2020 17:27:00
Objet: Re: [containous/traefik] Allow more than one server behind traefik to
manage their own certificates themselves via let's encrypt (#6716)

Thanks for your interest in the project.

I'm not sure to understand your use case, and I'm not sure if it's not already
possible to do what you need.

In order to give us more information about this, could you please join our [
https://community.containo.us/ | Community Forum ] and reach out to us on the [
https://community.containo.us/c/traefik | Traefik section ] .

—
You are receiving this because you authored the thread.
Reply to this email directly, [
https://github.com/containous/traefik/issues/6716#issuecomment-617848861 | view
it on GitHub ] , or [
https://github.com/notifications/unsubscribe-auth/AESLTE76NMWG5JREMJHCRUDRN4EEJANCNFSM4MN6LDGA
| unsubscribe ] .


Support BTRS3 (bai3)

Hey, any chance you can support both version 2 and 3? I have BTRS (bai3) files that are parsed correctly by this CLI if I just change the header field. I am happy to open a PR allowing files with version either 2 or 3 in the first line...

I think a PR with a test that asserts behavior would be great!

Do you have a doc with the Version 3 specification?

Yes! At least I guess, this is what I got from the bank I am working with


Fix when corrected depth is negative

Closes #197.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.695%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1345

Relevant Lines:
1483

💛  - Coveralls

Looks good to me.

LGTM! maybe add a test?