[FIX] iconElementRight not shown if menu is hidden

A work around is to use an empty  for the iconElementLeft props

@mattapperson can you sync with master please?

Replaced by #1295


fix: explicitly handle invalid endpointId

:pencil: Description

Properly sets status code of 403 (unauthorized) if the provided endpointId is not a valid encoded URL
Currently sets generic 500 error

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Handling responses for difference POST in the same controller

i write a method, in my method i need post two POST methods to my web service and get data json returned for every method. How can process response for separate post? Ex: in my view, i have:
[[RKObjectManager sharedManager] postObject:joeBlow
delegate:self];  (1)
[[RKObjectManager sharedManager] postObject:joeBlow_1
delegate:self];  (2)
How can i handle response for (1) and (2) in the same controller. Thanks

You can check which objectLoader came back using the userData property or by checking the URL


add coverage test for develop branch

Changes Unknown when pulling 6c6a0158930f8a526179c4165477da9d2c4d146b on sen-coverage into ** on develop**.

@coveralls If I understand coveralls correctly, it will find the source code ./ here, while our source code is not here. We did this https://github.com/HazyResearch/deepdive/blob/sen-coverage/test/submit_coverage.sh to let coveralls access the source code. Do you a better way to do this, e.g., a parameter to set path of source code?

Spotted a few errors.  Please fix them.

Changes Unknown when pulling c3861753fac6012ed85196a03cf5c06bc9444976 on sen-coverage into ** on develop**.

Changes Unknown when pulling f658718d05ddf5a7300f8ab397924725ea4fcfc8 on sen-coverage into ** on develop**.

Changes Unknown when pulling f658718d05ddf5a7300f8ab397924725ea4fcfc8 on sen-coverage into ** on develop**.


support scalar output in lm

this is just a simple update to the code to ensure that scalar function output are supported. Although less of interest, might be considered an edge case.

Hello Amir!
Thanks for that! Did you check that the current code did not pass your test?

Ok I checked. Indeed the current code does not pass the test.
In the future, it may be better not to use operators such as @ and keep jax/numpy operators, or, even better, make sure that the code can work with pytrees.


could not find symbol: glGetnTexImage

I'm cheating but it gives the error like issue in the title
star-wars-battlefront-2 - dx11 - fullscreen

This seems like a graphic driver issue. Which Graphic Drivers are you using and are they're updated? glGetnTexImage should be part of OpenGL 4.5

This seems like a graphic driver issue. Which Graphic Drivers are you using and are they're updated? glGetnTexImage should be part of OpenGL 4.5


Added truncateMiddle method.

This method truncates a string in the middle of it. This keeps start and end of string visible, so when you have, as an example, numbered properties you can truncate them safely.
StringHelper::truncateMiddle('Hello world number 2', 10) produces "Hello...ber 2".
There are no tests because i don´t have learned yet to use them. If some of the team consider interesting this function and want do develop the test i´ll be thankful.

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
yes

Tests pass?
--

Overall idea looks OK to me.

To me, too.

https://twitter.com/sam_dark/status/934398410958036992

OK. Seems to be useful enough. Let's continue...

Well, then what do you think is the best about html?  Do i create a truncateMiddleHtml method or all the logic under the same function and an optional parameter (asHtml) like in other methods.?

IMHO, all logic should be within the same function, especially for such a rare method

Same as existing truncate methods.

Such a method would definitely be used in my project to display portion of "sensitive" info (such as full name of the member) on default view and reveal full info on explicit request (and hiding/blurring) the rest.

Also, the same method used to displaying an email.


timeline for migration path from mobile CLI to amplify CLI

We have already built an app using Mobile CLI but want to transfer to amplify CLI. Can you please provide timelines for the migration path from Mobile CLI to Amplify CLI (i.e. support/import existing resources from mobile hub to amplify). We want to invest resources for the transition and we (and many other people using Mobile hub) would better utilize their resources if they knew rough timelines for the migration. For instance is it ~1-2 months, ~6-7 months or over a year.

@sadooghi We just released a Mobile Hub to Amplify CLI migrator that you can access here: https://github.com/awslabs/amplify-mobilehub-migrator. This will help you import your Mobile Hub resources into an Amplify project, give you an exports file, and allow you to leverage Amplify CLI features such as GraphQL APIs, Codegen, and the GraphQL Transform. Would love your feedback.


Interactively gather site argument

In the old Terminus we had a way of running more interactively to pick up common args like site and env. This used the local data cache to quiz the user for the value if a required one was not provided.
While I don't think there's a built in "pick a value from this list" thing in our current framework, and I don't want to copy the old code, but from a DX perspective I miss this. It's probably worth trying to add so that people can discover the power of Terminus in a more exploratory mode.
https://github.com/pantheon-systems/terminus/blob/master/terminus.drush.inc#L4139
Original arguments handled:

site
env
organization
product
team member
service-level
branch
element (of a backup)
bucket (for a backup)

Another idea is to store The config in the git config: git config psite.uuid foo-bar-baz...

Hmmm ... that's an interesting idea as well

based on this article btw http://www.triquanta.nl/blog/automatically-switch-drush-versions-project I have been using this system to seperate my D7 / D8 stuff

While it's a neat idea, I believe terminus.yml > git config
Reasons:

Terminus should be self-contained. We should assume as little as possible about the user environment. Most users will have a working install of git, but maybe not all.
Git config has multiple scopes (global, user, repository) which could get screwy.
Plenty of other things may affect git config, which could lead to unpredictable behavior.
If Terminus owns its own config, it's much easier to debug. (e.g. "Gist me your terminus.yml file" is an easy request.)

good arguments, and probably what I would choose.
I simply have an aversion to adding files to my repo :) I get tired of typing ls and seeing 15 files in my site root that are all tiny config files for each and every dev tool the team is using (such as a gemfile, guardfile, gruntfile, package.json, travis.yml...and the list grows as everybody uses their favorite tool) so simply not having another file to worry about versioning or not is appealing.
That said, as a 'fits the most cases' use, a terminus.yml is probably better even if it is less convenient for some like me.
for the sake of fun and giggles, couldn't you also generate a file in a user's .terminus directory with a key of the docroot location and a value of the pantheon uuid? Not that it's better, but it's another way to not add yet another file to the repository that some users may use.
</ armchairpotstirring>

I'd be in favor of having a ~/.terminus dir. I think we're already doing that for data caching, so no reason we couldn't have that be a default place for stuff like this to live.

I think this issue has evolved to become a dupe of #221.


refactor(): add generic to post, patch and put body

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[] Tests for the changes have been added (for bug fixes / features)
[] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?
Currently bodies of the methods post, put and patch are typed as any>. This pr adds a generic argument for those methods with any as default.
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This doesn't seem to be required


Introduce DepthAI-SDK package

DepthAI SDK is a Python package, containing convenience classes and functions that help in most common tasks while using DepthAI API.
Package preview - https://test.pypi.org/project/depthai-sdk/
To install package right now, please run the following command
pip install --extra-index-url https://test.pypi.org/simple/ depthai-sdk

To see this package in action, you can check the migrated experiments here - https://github.com/luxonis/depthai-experiments/pull/192

gen2-people-counter: https://github.com/luxonis/depthai-experiments/tree/sdk/gen2-people-counter
gen2-human-pose: https://github.com/luxonis/depthai-experiments/tree/sdk/gen2-human-pose
gen2-road-segmentation: https://github.com/luxonis/depthai-experiments/tree/sdk/gen2-road-segmentation

TODO

[x] Add generating docs from python docstrings using Sphinx - https://github.com/luxonis/depthai/pull/469/commits/e1f2fab1fd78a1bbddce7884550d3f3f37f52434
[x] Add docs subproject (on docs.luxonis.com) - https://docs.luxonis.com/projects/sdk/en/latest/
[x] Add python docstrings - https://docs.luxonis.com/projects/sdk/en/latest/api/
[x] Add Examples/Recipies/Tutorials that will show the SDK usage (basic usecases for now) - https://docs.luxonis.com/projects/sdk/en/latest/getting_started

Thanks @Erol444. Yes, we should add them for sure. Eventually we would have a pair of decode and show functions for each NN we support, under a convenient module. So something like below shows the "usage" idea
from depthai_sdk.nn.openpose2 import decode, show

This PR will start a 1.0.0 version and we'll add improvements like these in the following PRs, bumping the versions and making a new release

Awesome, thanks!


x/vuln/cmd/govulncheck: check against toolchain/go directive version

Should govulncheck use the Go version specified by toolchain or go directive in go.mod files? Currently, we use the Go version at PATH.
This issue was created based on discussions here and here.

This broke all our govulncheck CI jobs when running with setup-go and 1.21.x. Our go.mod specify go1.18 and they won't start unless we run go mod tidy before hand.

If this is happening in Github Actions, then I suggest for the time being looking into govulncheck-action. It recently added support for specifying whether the version in go.mod should be used. (it can be fetched @master currently, but we'll release a new version soon)

@zpavlinovic That's basically forcing people to change a their CI files, we have +30 files. This shouldnt be a breaking change.
I don't understand why the Go team is forcing a toolchain. The default value for GOTOOLCHAIN should be "local" or "path", with "auto" go forces you to run go mod tidy if your go.mod files specify a version other than 1.21.

We are trying to find the approach that is most useful for most people.    We've tried to document the new behavior as many places as we could.  Sorry for the trouble.

@ianlancetaylor What are all the teams developing applications in Go using to run tests/etc on their CI if not for Go itself?
We also noticed that all the dependabot jobs stopped and are failing because when go mod tidy runs it cant parse go 1.21 as seen here https://github.com/golang/go/issues/62278
Also related https://github.com/dependabot/dependabot-core/issues/7895

Personally I expect them to use Go, and I expect them to set GOTOOLCHAIN=local in the environment or in a go.env file, as discussed at https://go.dev/doc/toolchain.  I agree that there is a transition cost, but I think we can get through it.

Personally I expect them to use Go, and I expect them to set GOTOOLCHAIN=local in the environment or in a go.env file, as discussed at https://go.dev/doc/toolchain. I agree that there is a transition cost, but I think we can get through it.

Not sure what to say, when even Dependabot doesnt work anymore. I will remove 1.21 from the CI, until a solution is available.


Add information about -Didea.kotlin.plugin.use.k2 VM Option to K1 -> K2 guide

Not entirely sure, but it seems that we should stick to "K2 Mode" instead of "K2 plugin"


nixos/usbguard - add usbguard-notifier option and service

Add a option to usbguard module to enable a systemd service with usbguard-notifier application. The application displays pop-ups when new USB devices are detected allowing the users for easy accept/reject actions without going to command line.
Description of changes
I have no idea how to test this. The service part is taken from my configuration.nix and is working. the option is copy pasted and edited from other option. I'm not sure about the systemPackages optional assignment if it's done correctly.
I will appreciate instructions on how to test this and will appreciate any pointers on improvements.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools


Swap "prev" and "next"

The prev and next seem to be reversed.
I can see that JetBrains calls "backward" what should be called forward, but I think that was a mistake.  Now with the current polarity, I'm forced to have the unfortunate inconsistently named bindings:

VS Code and Vim agree that "next" means looking forward past the cursor.

I've answered this on your other query hope that helps.

I've just check in Jetbrains IDE it works exactly like this, Cyclic Expand Word (Backward) searches from cursor to bottom of the file just like hippie-completion.prev

That's what I'm saying.  That JetBrains works like this, but I think they made the wrong decision, unlike VS Code and Vim.  it's intuitive for "Next" to mean "forward" and "Previous" to mean "backward", not the other way around, which is the way JetBrains has it.
I'm suggesting that you eschew JetBrains' terminology and instead go with the convention set by VS Code.  Just look at my screenshot again and you will see the inconsistency of "next" being assigned to ^P where P stands for "previous".

Ok, then "prev" means "next" and "next" means "prev". Got it :)


Clarification on cv_selection_metric

Hi all,
Thanks for the great work.  Just had a quick question about the cv_selection_metric.
When you choose it does it actually use the selected metric as a loss function or
is MSE still used and metrics later computed on the CV splits?
Best,
George

Hi @ggerogiokas the loss function depends on the fit algorithm and its parameters you choose. For example, if you fit ridge regression, the loss function will be MSE (default loss function in sklearn.linear_model.ridgeCV). If you fit a tree model, you may be able to use quantile loss or so. These are independent of the cv_selection_metric.  The CV computes metrics on the fitted results and choose the best model according to the cv_selection_metric.


[Enhancement] Touchbar support

It would be cool to see the newer MBPs w/ Touchbars gain some Hermes goodness!

display current station name
display song artist/album/artist
display 'now playing' album art
display song time/progress scrubber (w/ min:secs)
ability to thumb-up/down; skip ahead
switch stations 'pop-up' (it's a thing)

I haven't looked into the API at all, but there is a bit of a UX issue for apps like Hermes that would typically be run in the "background". Namely, the running app can push app-specific buttons on to the bar, but as soon as the focus is gone, the app buttons are gone. I'm wondering if there's a way to override that so that Hermes can always be present while playing.
Anyway, just a suggestion. Love this app.

Something much smaller. The touchbar play/pause button works with Hermes (which is awesome!) but it doesn't switch between the play and pause icons like iTunes or other media does. It would be awesome if it could!

For posterity, in case this ticket ever gets interest, as an example iTunes behaves as such:
When the app is open, a 'music player' icon appears (it's not an iTunes icon, but I'm not sure if it's generic to represent any music player):

When you tap the icon, the control bar opens:

From left to right:

Close control bar icon (tap to close bar)
iTune icon (tap to switch to app)
Song scrubber (tap and drag to scrub back/forward through song)
track back, play/pause (toggles between icons depending on state), fwd

I think Hermes could actually do much better than what iTunes has implemented.

Unrelated but you can take screenshots of the touchbar with cmd+shift+6

I've done a first pass at the 'background' pieces.  Play/pause works at least; will need to keep digging as to why the scrubber doesn't but right now I've got bigger fish to fry (#285).

I've been using this touchbar enhancement (honestly, one of the only touchbar integrations I've found useful) for a bit. Figured I'd throw my two cents in here in case anyone comes back to it...  I also understand there's limitations due to the touchbar SDK/Pandora API -- just getting it all down here in case Apple/Pandora improve their support in the future.

The hermes icon is nice because it will raise the app (even switching spaces as necessary) -- my personal preference would be to overload the app icon w/ the album art as Hermes does on the Dock or in the Menu bar.
Artist, Album, and Track titles would be more useful (to me) than the scrubber bar
although, the "play head" and total track time values are nice to see (e.g., 2:21/3:50)
thumbs up/down would be nice, including an indication if one is already pressed
play/pause button is cool -- you can see I have that same button on right permanently exposed
skip track would be cool too.

Really awesome app.

I discovered this feature "accidentally" today and was delighted. Well done!


Reach idea for version 1.8.9

I have an idea to make the client less blatant: ignore water/lava, ladders, sneaking..

my code is horrible, I just wanted to show what was my idea in practice.

Hello, sorry for the delay, I won't add any more features. I will just update the mod to the newest minecraft versions. I keep the issue open if someone wants to open a PR including your feature


added repo_proxy parameter

currently this is only used on RedHat and allows specifying a proxy
server to access the virtualbox yum repository.
this could also be used for other distributions.

Thank you!!


Set image-name for download

Hey,
is it possible to specify the name to use when downloading the image? I do base64 strings as src for the images instead of urls. The name of the downloaded files is then very cryptic (it seems to be the end of the src string) and usually without the correct file extension.

Not at the moment, I'm using the name of the image from its path to create the filename.
However there are some limitation about image download in modern browsers, so I'm still thinking and searching a better approach. Right now, I don't want to add other features about this topic, because probably I'll rewrite it from scratch.
If you have a good idea to download images automatically also from different origins (for instance from another server) bypassing browsers security features feel free to share it.

Maybe you can add a option to use the 'title' or 'alt' as name for the downloaded image?

Yes this is an option, but I scheduled to investigate about better alternatives for image download in 7.0.0.
I'll update you when I'll find something new.

I decided to add a new propertie into Image class to choose the file name. I'll release it as 6.1.0.
When I'll find a new way to download images, probably I'll change it, but for now this should be ok.

6.1.0 release with this feature

It works fine! Thanks!


core: support multiple cache configs for upstream remote cache

Adds support for providing separate import/export configs for upstream remote cache and for providing multiple values of each (separated by ;).

@sipsma are we still interested in taking this? Glancing through the code, it SGTM :tada:


A preliminary version of HACL* extracted to safe Rust

Proposed changes
Preliminary support for Rust extraction of HACL*. This is joint work with @R1kM.
Enough work has gone into this that I would like to see things being put under CI so as to make sure nothing regresses. I have no intention of advertising this as things are pretty rough still.
Types of changes
This leverages the work of the past several months on the Rust backend of KaRaMeL and enables it within HACL*. Notably, this creates:

a new subdirectory, dist/rs
puts under version control a complete extraction of HACL* to Rust, modulo KaRaMeL failures for some of the functions
adds some hand-written files for the library modules (hacl.rs, lib.rs, etc.), the machine integers (eventually should be extracted, but hand-written for now)
adds targets in the main Makefile to extract and build with cargo

What to look for in this review

Many small, non-threatening changes had to be enacted on the original F* source in order to comply with the restrictions of the Rust borrow-checker. As such, the first thing to review is the diff for dist/gcc-compatible; I would need some performance benchmarks to make sure there are no regressions.
Then, one can look at the shape of the generated Rust code, the build, and debate whether this is an acceptable layout, etc.

Limitations

Many of these modules compile, but have run-time errors. @R1kM has a plan to fix this once and for all, but for now, only the addition of tests and/or fuzzing will help us figure out which modules have issues.
More modules need to be rewritten to observe a buffer ownership pattern that is compatible with Rust. HMAC, HKDF, Ed25519 all requires modifications in the source.
More modules need to be rewritten to obey aliasing restrictions and avoid in-place APIs (Ed25519).
There are likely many performance issues, the chief one that I'm aware of being the fact that we take mutable pointers to globally-allocated constants, which generates a copy of the constant per the corresponding Rust warning. This is quite concerning, and I don't know if this will be optimized at the LLVM level. In any case, this is something I'd like to fix. While we could try to port the source to leverage LowStar.ConstBuffer more, this is likely going to be a herculean task, and I'd rather implement a const-analysis phase in krml in order to automatically decorate all pointers (and function signatures) with const whenever possible. It's still a fair amount of work, but not as bad as fixing the source.

@pnmadelaine can you add uucp to the build? I thought I had fixed the karamel flake properly but I must've done something wrong...?

@franziskuskiefer bringing your attention to this, as it might impact performance on HACL packages

@pnmadelaine @twal @W95Psp
hey Nix gurus, I added cargo here: https://github.com/hacl-star/hacl-star/pull/918/commits/d354afe29fb33877da9066b9475ba986b03dd6b6 but I'm still getting "cargo: command not found" in the build logs
can someone help me on the path to Nix enlightenment?
thanks!!

hacl-star> error: could not find `Cargo.toml` in `/build/source/dist/rs` or any parent directory

the source files that make it into the Nix build are filtered here: https://github.com/hacl-star/hacl-star/blob/0dfadb6fb997020c372d2201c200f260b5c812c0/.nix/hacl.nix#L47-L73

the source files that make it into the Nix build are filtered here:

ugh... the directory is a mix of hand-written files and autogenerated files, do I really need to manually list all the files that are hand-written?

FYI CI is now green, and includes extracting, building and testing the Rust code.

HACL packages CI is now green, which should allow us to get a perf comparison between:

HACL/main and HACL/afromher_rs, in C -- how many of these source changes slow down the C code?
HACL/afromher_rs, in C vs. HACL/afromher_rs, in Rust -- how much slower are the Rust versions?

@franziskuskiefer sounded like he would give this a stab, since eventually we want all of this to go into libcrux.

Sorry, I missed the notifications about the Nix questions!

ugh... the directory is a mix of hand-written files and autogenerated files, do I really need to manually list all the files that are hand-written?

I know it is a bit tiresome, but this is really useful to avoid rebuilding when only the generated files change!

@msprotz it seems like the source filter can be written a little bit more compactly, see https://github.com/hacl-star/hacl-star/tree/pnmadelaine/afromher_rs

Awesome, can you submit a PR?

What is the status of this? We'd like to use it here: https://github.com/cryspen/libcrux/issues/225 for ElectionGuard integration.

@msprotz and myself are working this week on significant improvements to the codebase (especially related to the pervasive use of mutable borrows). The version currently on the branch is still considered experimental, however, modules that are not commented out in hacl.rs compile and pass tests, although with variable performance depending on the algorithms.

Thanks! This solves the issue we had with compiling to wasm https://github.com/cryspen/libcrux/issues/225
Are you planning to release this as a separate crate?

Right now we have isolated the bignums as a standalone crate. @marshray said that this should work for him to integrate into electionguard. how about concordium?
If the standalone bignum crate works for you, we could contemplate splitting up more algorithms as separate crates.

would you be ok consuming the entire HACL* library as Rust? or do you need hmac in a separate sub-crate like bignum?
do you need it published on crates.io or are you ok consuming directly from a branch of HACL*?

@bshvass made a version of EG with HACL* hmac here:
https://github.com/bshvass/electionguard-rust/tree/hacl-star-rs
@marshray may want to wait with including this until @msprotz has made a release.
The work above does not include the HACL* bignums yet.

Is there any feedback on the integration? Happy to take comments, suggestions for improvement...


Broken status bar octicons

The Azure Repos extension looks like this in the latest insiders:

Did we break them somehow?

Someone else reported this in https://github.com/microsoft/vscode/issues/82511 and I’m not sure why the extension is referencing icons this way since our documentation says to use ‘$(icon-name)’, @bpasero does this sound familiar?
Looks like https://github.com/microsoft/azure-repos-vscode/issues/572 already has a PR that fixes this.

No, never heard of, but did we change the names of icons?

We didn’t change any icon names, but we did switch from Octicons to use Codicon. I did a search on GitHub for the use of $(icon octicon-) to see if others use it and the azure repos extension appears to be the only one.

Then we can just give them an issue for them to start using codicons?

I left a comment on https://github.com/microsoft/azure-repos-vscode/issues/572 since that's tracking the issue on their side.


[Cloud Run] Add Structured Logging Sample

@kurtisvg , I'm having an issue getting my script to run:
github/java-docs-samples/.kokoro/tests/run_tests.sh: line 109: github/java-docs-samples/.kokoro/tests/build_cloud_run.sh: No such file or directory

Still not running. Error:
github/java-docs-samples/.kokoro/tests/run_tests.sh: line 109: /tmpfs/src/github/java-docs-samples/.kokoro/tests/build_cloud_run.sh: Permission denied

I removed the test updates from this PR. This includes a new sample plus fixes formatting of other samples.


Issue #82: Create lifecycle events routes

API Endpoints

[ ] POST submit : Send the latest state of a form to the database.

The state can either be final or transient.

sequenceDiagram
    title FertiScan Submit Form
    participant C as Client
    participant FE as Frontend
    participant BE as FertiScan
    participant DS as DataStore
    participant DB as SQL

    C ->> FE: submit_form()
    FE ->> BE: POST /submit JSON
    note right of BE: Authorization: Basic (email as user_id)\nContent: JSON (Form)

    alt form.confirm == true
        BE ->> DS: submit_final_form()
        note left of DS: the final version of\n the form.
    else
        BE ->> DS: submit_update_form()
        note left of DS: Update the given form.
    end

    DS ->> DB: execute_query()
    DB -->> DS: //SQL_CODE//
    DS -->> BE: //label_id, HTTP_CODE//

    alt HTTP_CODE == success
        BE -->> FE: //label_id, 200//
    else
        BE -->> FE: //Database error, HTTP_CODE//
    end

[ ] POST discard : Remove all transient states of a form.

sequenceDiagram
    title FertiScan Discard Form
    participant C as Client
    participant FE as Frontend
    participant BE as FertiScan
    participant DS as DataStore
    participant DB as SQL

    C ->> FE: discard_form()
    FE ->> BE: POST /discard/label_id
    note over BE: The label_id of the form you want to discard.

    BE ->> DS: discard_form()
    DS ->> DB: execute_query(query)
    DB -->> DS: //SQL_CODE//
    DS -->> BE: //SQL_CODE, HTTP_CODE//

    alt HTTP_CODE == success
        BE -->> FE: //Successfully discarded, 200//
    else
        BE -->> FE: //Database error, 500//
    end

Closes tasks in #82

So what this PR only contains documentation for commit and discard. Let me your thoughts.
@Francois-Werbrouck @Youllou @Endlessflow

I personally do not like the terminology "commit" since there are no where in the user's interaction where they commit something. They either confirm, validate or send a form with feedback. So commit is a bit confusing.
For the Sequence graph, I'd like to better see the interaction FE - BE - DS. Does the FE gives the user_id to track the form, is it his email? The user_id will be requiered to register an analysis. Will it be within the form or as a parameter?
Btw there wont be queries created to deal with the database. Everything will be dealt with functions from the DS which will be called by the BE depending on the scenario.
It would also be a great bonus if we can differentiate the type of errors, because it wont only be a database error, The DS will return specific error type (user not registered, a requiered field is empty, etc) or an Exception which reprensent an unhandled/un-expected type of error. I know this is far fetched but it is something we on Nachet are trying to improve atm since it's really hard to know what doesn't work on the application if the error management from the FE-BE is not well established with a code ruling. Still, kudos on labeling your errors in the graph this is more than expected 🥇

I also really advise to use mermaid within markdown because this is a great way to write documentation and also draw graphs in the same document without requiering png to be added to the repo.

I also really advise to use mermaid within markdown because this is a great way to write documentation and also draw graphs in the same document without requiering png to be added to the repo.

I personally do not like the terminology "commit" since there are no where in the user's interaction where they commit something. They either confirm, validate or send a form with feedback. So commit is a bit confusing.

It's the "sending with feedback" I interpreted as commit. The feedback from his perspective is effectively the changes made to the form. Each time update in the confirmation or confirmation is tied to submission of the form. Maybe "submit" is better since it's in same lexicon as "form".

For the Sequence graph, I'd like to better see the interaction FE - BE - DS. Does the FE gives the user_id to track the form, is it his email? The user_id will be requiered to register an analysis. Will it be within the form or as a parameter?

I implemented the Basic auth scheme. I left the authentication part out from this since I was still unsure about how it would be dealt in the future but we can go with what's already there.

Btw there wont be queries created to deal with the database. Everything will be dealt with functions from the DS which will be called by the BE depending on the scenario.

Thanks, I imagine they are/will be documented in the datastore soon?

I also really advise to use mermaid within markdown because this is a great way to write documentation and also draw graphs in the same document without requiering png to be added to the repo.

I also use the images in the wiki, that's why :/. If we can just link the mermaid file in the wiki it'd be optimal.
I'm taking note of the rest (errors/exceptions,  interaction FE - BE - DS, terminoly of endpoints). Thanks for the feedback!

API Endpoints
Following the meeting with @k-allagbe and @Endlessflow , I came to the conclusion that the API should be refactored because it's doesn't handle well the creation of the form in the database. I would have worked if we limit the user to one form but that's not ideal in the long run.
Workflow

POST /forms
sequenceDiagram
    title FertiScan Create Form
    actor C as Client
    participant FE as Frontend
    participant BE as FertiScan
    participant DS as DataStore
    participant DB as SQL

    C ->> FE: create_form()
    FE ->> BE: POST /forms
    Note right of BE: Authorization: Basic (email as user_id), Content: JSON (Form)
    BE ->> DS: create_form()
    Note right of BE: Creates a new unconfirmed form in the backend for the user.
    DS ->> DB: execute_query()
    DB -->> DS: //SQL_CODE//
    DS -->> BE: //JSON, HTTP_CODE//
    alt HTTP_CODE is success
        BE -->> FE: //JSON, 200//
        Note right of BE: {"message": "...", "form_id": "<form_id>"}
    else
        BE -->> FE: //Database error, HTTP_CODE//
    end

PUT /forms
sequenceDiagram
    title FertiScan Update Form
    actor C as Client
    participant FE as Frontend
    participant BE as FertiScan
    participant DS as DataStore
    participant DB as SQL

    C ->> FE: submit_form()
    FE ->> BE: PUT /forms/form_id
    Note right of BE: Authorization: Basic (email as user_id), Content: JSON (Form)
    alt form.confirm == true
        BE ->> DS: submit_final_form()
        Note left of DS: the final version of the form.
    else
        BE ->> DS: submit_update_form()
        Note left of DS: Update the given form.
    end
    DS ->> DB: execute_query()
    DB -->> DS: //SQL_CODE//
    DS -->> BE: //message, HTTP_CODE//
    alt HTTP_CODE is success
        BE -->> FE: //message, 200//
    else
        BE -->> FE: //Database error, HTTP_CODE//
    end

DELETE /forms
sequenceDiagram
    title FertiScan Discard Form
    actor C as Client
    participant FE as Frontend
    participant BE as FertiScan
    participant DS as DataStore
    participant DB as SQL

    C ->> FE: discard_form()
    FE ->> BE: DELETE /forms/form_id
    BE ->> DS: discard_form()
    DS ->> DB: execute_query(query)
    DS -->> DB: //SQL_CODE//
    DS -->> BE: //message, HTTP_CODE//
    alt HTTP_CODE is success
        BE -->> FE: //Successfully discarded, 200//
    else
        BE -->> FE: //Database error, 500//
    end

@snakedye 👌. For good measure, I suggest adding a GET route. We should not care too much about how the frontend will use the API. Pas besoin de faire du "sur mesure".

I'd like to point out, the email isn't the user_id. Each user must be registered with their emails and their id is returned. Therefore the BE can operate directly with the user_id instead of the email.
I'm also wondering where and when the pictures are sent over to the Datastore to be saved and linked with the form.

Thanks for clarifying that @Francois-Werbrouck , I'll remove the mention of the email in the diagrams.

I'm also wondering where and when the pictures are sent over to the Datastore to be saved and linked with the form.

POST /forms and/or PUT /forms.
I was thinking of an object like this:
{
	"confirmed": "false",
	"form": {
	},
	"images": [
	]
}

Or as send it as form data like with analyze. It'd be the same object but without the "images" key.
This is up to you. Whatever is more convenient for the datastore.


SAMZA-1410 make tests pass in different Junit versions for testPlanIdWithShuffledStreamSpecs and testGeneratePlanIdWithDifferentStreamSpec

More details are in https://issues.apache.org/jira/browse/SAMZA-1410.
gradlew build and test passed.

Thanks @sborya ! The original import lines were importing Assert class with *, so there is nothing to remove there.
Depending on the code style and best practice, most recommend not to use * to do wildcard matching (which I prefer), but some may think it is better to keep the existing style for consistency purpose. Anyway, we can discus about that one and determine an import practice horizontally for all files. For this PR, I think it is OK to not touch since it is out of the scope of the purpose.

@sborya Thanks. Reformatted the lines to make lines shorter.


err: /Stage[main]//Node[node1.wang.com]/Ohmyzsh::Install[wangshihchieh]/Exec[ohmyzsh::git clone wangshihchieh]/returns: change from notrun to 0 failed: /usr/bin/git clone git://github.com/robbyrussell/oh-my-zsh.git /home/wangshihchieh/.oh-my-zsh returned 128 instead of one of [0] at /etc/puppet/modules/ohmyzsh/manifests/install.pp:35

err: /Stage[main]//Node[node1.wang.com]/Ohmyzsh::Install[wangshihchieh]/Exec[ohmyzsh::git clone wangshihchieh]/returns: change from notrun to 0 failed: /usr/bin/git clone git://github.com/robbyrussell/oh-my-zsh.git /home/wangshihchieh/.oh-my-zsh returned 128 instead of one of [0] at /etc/puppet/modules/ohmyzsh/manifests/install.pp:35

Changing the install method from exec to vcsrepo fix the problem for me
https://github.com/acme/puppet-acme-oh-my-zsh/pull/9


Rake tasks don't appear in rake -T

It would be nice to have the rake tasks listed when I do a rake -T. I though the gem hadn't installed correctly when I didn't see that.

Yeah, that's unfortunate I know. The reason is that Turnout doesn't technically have any Rake tasks. It has Rake rules and rules don't show up with rake -T.
The rules are used so that named_maintenance_file_paths can be supported so you can do things like rake maintenance:server:start to shut down every app on a server, or whatever other sort of categories of apps you want to set up.
So for now, unfortunately, it looks like there's no good way to get the tasks to show up in rake -T unless somebody knows a trick that I don't.

Hmm, fair enough. It is worth mentioning probably though in the documents.
On Mon, Nov 2, 2015 at 1:28 AM, Adam Crownoble<EMAIL_ADDRESS>wrote:

Yeah, that's unfortunate I know. The reason is that Turnout doesn't
technically have any Rake tasks. It has Rake rules
https://github.com/biola/turnout/blob/master/lib/tasks/maintenance.rake
and rules don't show up with rake -T.
The rules are used so that named_maintenance_file_paths can be supported
so you can do things like rake maintenance:server:start to shut down
every app on a server, or whatever other sort of categories of apps you
want to set up.
So for now, unfortunately, it looks like there's no good way to get the
tasks to show up in rake -T unless somebody knows a trick that I don't.
—
Reply to this email directly or view it on GitHub
https://github.com/biola/turnout/issues/26#issuecomment-152950202.

--
Michael Christenson II
Senior Ruby Developer
p.<PHONE_NUMBER>
e<EMAIL_ADDRESS>e<EMAIL_ADDRESS>g. http://github.com/m3talsmith


Can ApexCharts make a Funnel type chart?

Good day,
I am starting to use ApexCharts in my projects and congratulated them because it helps a lot.
A client has request us to display a chart specifically with the Funnel type. I have seen that the closest thing is to start from the horizontal bar graph, but I do not know how to make the bars are centered.
I give you an example of the funnel chart:
https://i.imgur.com/MQE1ebM.png

Are there plans to add funnel chart type?


Implement ju.TreeMap

Depends on #4797.

@sjrd I'm not sure whether this is enough test coverage. It does re-use RedBlackTree, so we don't really need to test the core more, but probably some "minor" forwarders are untested.

The CI says:
[error] C:\projects\scala-js\test-suite\shared\src\test\scala\org\scalajs\testsuite\javalib\util\TreeMapTest.scala:68:33: inferred type arguments [K,?0] do not conform to method comparing's type parameter bounds [T,U <: Comparable[_ >: U]]
[error]     val natural = ju.Comparator.comparing((_: K).asInstanceOf[Comparable[Any]])
[error]                                 ^
[error] C:\projects\scala-js\test-suite\shared\src\test\scala\org\scalajs\testsuite\javalib\util\TreeMapTest.scala:68:62: type mismatch;
[error]  found   : java.util.function.Function[K,Comparable[Any]]
[error]  required: java.util.function.Function[_ >: T, _ <: U]
[error]     val natural = ju.Comparator.comparing((_: K).asInstanceOf[Comparable[Any]])
[error]                                                              ^
[error] two errors found
[error] (testSuite2_12 / Test / compileIncremental) Compilation failed

Rebased and addressed review comments.

The following commands are failing in the CI:
sbt "set scalaJSLinkerConfig in testSuite.v2_12 ~= makeCompliant" testSuite2_12/test

On JDK 16, the JVM test suite fails:
sbt testSuiteJVM2_12/test testSuiteExJVM2_12/test

Seems this is affected by: https://bugs.openjdk.org/browse/JDK-8259622?subTaskView=unresolved

Updated. For ease of review, I have made two commits to be squashed.


Couldn't find Delete directory option in Azure Active Directory admin center

Couldn't find Delete directory option on Azure Active Directory admin center page.
I found Delete tenant instead that i believe is the right option here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8adb403b-fded-7b9c-c093-915ca9bb348d
Version Independent ID: df08fc6b-a752-084b-448a-a253db2a40d5
Content: Close your account
Content Source: microsoft-365/commerce/close-your-account.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@grzegorz-silarski Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/3280
You are correct the option is changed to Delete tenant now.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @grzegorz-silarski Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Thank you @msbemba @yogkumgit. I'm happy that I could help here.


Insomnia for snap not starting on Fedora 33

Describe the bug
After upgrading to Fedora 33 Insomnia is not starting when installed via snap
To Reproduce
Steps to reproduce the behavior:

Go to the terminal
Run the following command: snap run insomnia
Error will be shown in terminal

Expected behavior
Insomnia is starting
Desktop (please complete the following information):

OS: Fedora 33 with kernel 5.8.16-300
Installation Method: snap
App Version: 2020.4.2

Additional context
Error message shown in terminal:
WARNING: cgroup v2 is not fully supported yet, proceeding with partial confinement 11:05:56.496 › Running version 2020.4.2 Error org.freedesktop.DBus.Error.Failed: cannot find snap for connection: not supported Segfault (dump written)
dmesg output is:
insomnia[13218]: segfault at 208 ip 000055bafebdbec3 sp 00007ffd3f640f30 error 4 in insomnia[55baf9040000+5cb5000]
snap info insomnia output is:
name: insomnia
summary: Insomnia REST Client
publisher: Insomnia (gschier1990)
store-url: https://snapcraft.io/insomnia
contact: https://support.insomnia.rest
license: unset
description: | A powerful HTTP and GraphQL Client with cookie management, environment variables, code generation, and authentication for Mac, Window, and Linux.
commands:
insomnia
snap-id: ZtF4mLp5Bededu3S65ocO6HfGXCtcvZ9
tracking: latest/stable
refresh-date: today at 10:26 CET
channels:
latest/stable: 2020.4.2 2020-10-26 (109) 97MB -
latest/candidate: ↑
latest/beta: ↑
latest/edge: 2020.4.2 2020-10-26 (109) 97MB -
installed: 2020.4.2 (109) 97MB -

same here


Add tests for hash-byte-limit option

Test for https://github.com/OISF/suricata/pull/5813

happy new year and ping @rtkjweeks
Could you do the requested changes ?


docs: update "Development" guide

Signed-off-by: Navendu Pottekkat<EMAIL_ADDRESS>Updates the "Development" guide and makes it consistent with APISIX guide.

The lint error is from a different PR. We can merge this if there are no issues.

I have fixed the link check error in a different PR. All checks will pass here.


Repeatable tasks by day of week

Instead of interval in days I would love to see seven small buttons to click the day of the week.
Like in the clock app but more minimal

Not sure if such small icons are best way to go (it's quite painful on smaller screens/resolutions), but for sure we'd benefit from something like an init date for interval, because currently it always starts from the day you've finished the last one

I want to keep interval in days, so repetitive attribute will be a variant since the next release:


Mapping to multiple data sources

Does Legend supports the mapping of one model artefact (e.g. class or enumeration) to multiple mapping sources?
My experience is that one model artefact (left side of the mapping panel) can only have one mapping source.
The work-around that I have been trying is to create one mapping object per model artefact, represent the various mapping sources on the left side of the mapping panel and the model artefact on the right side.  The obvious downside with such approach is the multiplication of mapping objects.
I would be interested to hear whether a better approach already exists, or whether there is a plan to support the ability to associate several data sources to a model artefact.

Hi @pierrelamy! Thanks for reaching out. Could @erwin-jeanlouis-gs help you with this already or is this still an open item for you?


Recurate wang2019

@sgebel  discussion closed

why was this pull request closed? After discussion is closed, the branch with the recurated documents will be merge. Only issues in GITLAB are closed. @trushaadeshara8 Trusha, please confim that the branch can be merged.

@sgebel discussion closed


requirify integration test

grunt integration_test

Reviewed files:

Gruntfile.coffee @ r1
src/integration/core.spec.ts @ r1
src/integration/gtalk_credentials.js @ r1
src/integration/gtalk_credentials.ts @ r1
src/integration/integration.json @ r1
src/integration/oauth_view_mock.ts @ r1
src/integration/test_connection.ts @ r1

Gruntfile.coffee, line 515 [r1] (raw file):
How does this deal with files that exist in both paths?

Gruntfile.coffee, line 584 [r1] (raw file):
It seems like this might work a bit better as /integration/*.spec.ts, any reason why that was not done?

src/integration/core.spec.ts, line 36 [r1] (raw file):
Having the refreshToken as a property of the class feels incredibly wrong, would it be possible to move it to a constructor argument and then pass in a function returning the correct object to the freedom call (pretty much how it's actually done in Chrome-land)

src/integration/core.spec.ts, line 47 [r1] (raw file):
Any way to do better typings here?  Regardless though, semicolon should be to the left of the comment.

src/integration/oauth_view_mock.ts, line 7 [r1] (raw file):
I think MockOAuth might be a better name here.  Where did View come from?

src/integration/oauth_view_mock.ts, line 29 [r1] (raw file):
Is there a reason this is not in the OAuthView class?

Comments from the review on Reviewable.io

Gruntfile.coffee, line 515 [r1] (raw file):
I don't understand this question.

Gruntfile.coffee, line 584 [r1] (raw file):
oauth_view_mock.ts and gtalk_credentials also need to be compiled.

src/integration/core.spec.ts, line 36 [r1] (raw file):
Wait I don't get this, how is it done in chrome-land(or what is chrome land?), socialprovider calls constructor of oauth.
Also I don't think it's that bad to have a hacky mock class, mock classes are hacky by design.

src/integration/core.spec.ts, line 47 [r1] (raw file):
Yeah good point, I forgot to address this, do we have a type that also has once?

src/integration/oauth_view_mock.ts, line 7 [r1] (raw file):
haha legacy naming.

src/integration/oauth_view_mock.ts, line 29 [r1] (raw file):
i copied this code from freedom, so I don't know, but yeah class member function makes sense.

Comments from the review on Reviewable.io

Reviewed files:

src/integration/core.spec.ts @ r2
src/integration/oauth_view_mock.ts @ r2

Gruntfile.coffee, line 515 [r1] (raw file):
Ah, sorry, my mistake.  I thought I also saw something copying the extension code, I mis-read.

Gruntfile.coffee, line 518 [r2] (raw file):
It looks like this already gets copied in the copy:dev rule.

src/integration/core.spec.ts, line 36 [r1] (raw file):
Way it is done in Chrome (I was referring to the Chrome App when I said that) if I remember that:
[() => { return new OAuth(); }]

src/integration/core.spec.ts, line 47 [r1] (raw file):
No, I don't think we have one at the moment in the Freedom types.

Comments from the review on Reviewable.io

Gruntfile.coffee, line 518 [r2] (raw file):
Done.

src/integration/core.spec.ts, line 36 [r1] (raw file):
Done.

src/integration/core.spec.ts, line 47 [r1] (raw file):
I'm leaving this as any, I don't think it's worth adding types just for tests.

Comments from the review on Reviewable.io

:thumbsup:

Comments from the review on Reviewable.io


Unable to debug ndk code using breakpoints in Android Studio

Hi
I tried all possible ways to try debugging ndk code using Breakpoints, but coudn't acheive it.
Could I please know if you were able to hit breakpoints in ndk code, if so please tell any additional settings you have made
Thanks

With this current setup I wasn't able, no. But Google only included this a few months back I think. You would need to watch some of the latest tutorial videos for NDK debugging in Android Studio because I think they changed a lot.

Thanks, I was able to debug when I use 'Cmakelists.txt' instead of 'Android.mk'
Incase you were able to debug using 'Android.mk', please let me know

Hello ashok, how can i hit the breakpoints using ndk/cmake

Hi Sorry, I haven't been able to hit breakpoints
On Oct 23, 2017 14:25, "venkateshpappu"<EMAIL_ADDRESS>wrote:

Hello ashok, how can i hit the breakpoints using ndk/cmake
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Qualeams/Android-Face-Recognition-with-Deep-Learning-Test-Framework/issues/22#issuecomment-338592136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJjYUH6xnV81kxMa6a7X3cbgoASnpFitks5svFSCgaJpZM4NvEaJ
.

Thanks for the reply, which version of android studio you are using

I am using 2.3.3 version
On 23 Oct 2017 3:29 pm, "venkateshpappu"<EMAIL_ADDRESS>wrote:

Thanks for the reply, which version of android studio you are using
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Qualeams/Android-Face-Recognition-with-Deep-Learning-Test-Framework/issues/22#issuecomment-338609547,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJjYULc3v7ZZCjRFRLUNZvJpEicnwlRrks5svGOZgaJpZM4NvEaJ
.


VectorSearchVectorStore.add_texts assumes metadatas is a List[dict] when it should be List[List[dict]]

Each text should be able to have a list of metadatas, however, current version only accepts List[dict]

@jzaldi

Hi @raulescalantem we follow the signature of langchain_core.vecorstores.VectorStore where add_texts is
 @abstractmethod
        def add_texts(
            self,
            texts: Iterable[str],
            metadatas: Optional[List[dict]] = None,
            **kwargs: Any,
        ) -> List[str]:
            """Run more texts through the embeddings and add to the vectorstore.

            Args:
                texts: Iterable of strings to add to the vectorstore.
                metadatas: Optional list of metadatas associated with the texts.
                kwargs: vectorstore specific parameters

            Returns:
                List of ids from adding the texts into the vectorstore.
            """

The metadata for each text is a dict.
For example:

texts = ["This is the page 1", "This is the page 2"]
metadatas = [{"page": 1, "source": "a_document.txt"}, {"page": 2, "source": "a_document.txt"}]

Am Im missing someething?


Editing as yaml of a registry secret creates a duplicate secret in the list view

Version: master-build(b85ea695f)
Steps:

Create a secret "testreg" "by choosing type "registry" option
Edit the secret using "Edit as Yaml" option and Save

A duplicate registry is created in the list view as below:

Note:
After a refresh,  the duplicate registry is removed from the list view
The duplicate is created even if no data is changed during edit and just saved as is.

This is a second case of https://github.com/rancher/dashboard/issues/644 that I missed.. verified that they're all updated now.

Validated with updated master-build(dea919fb2)
Steps:

Create a secret "testreg" "by choosing type "registry" option
Edit the secret using "Edit as Yaml" option and Save

The secret gets edited correctly and is listed in the list view. Duplicate entries are not created after editing.


Create a requirements file (for pip and conda)

Consider creating a requirements.txt with the dependencies:

matplotlib
basemap
numpy
scipy
pandas
gsw
seawater

It's done.


Feature request: Ability to add (not replace) updated time

In my head it's quite useful to have a list of updates/times you've touched the note.
I'd be happy to avoid overriding and just to attach "udpated" time, e.g.
updated:
  - 2022-12-12
  - 2023-12-12
  - ....

Ofc not everybody needs it, but being able to turn this enhancement will keep on making this plugin the ultimate one and will cover "list" property. The same way this PR has covered numerics https://github.com/beaussan/update-time-on-edit-obsidian/pull/67
Yes, the note may get bloated, so by default it should be off. It's an advanced setting for those, who need.
But not required, ofc.

I like this idea. I also thought about it. It is interesting to save info to see how frequently a note was edited.
You might like the compromise that I came up with then: using Git. I got it set up this way that it only tracks *.md, and .gitignore files. Then using restore command I can make the files appear as they were on a chosen commit. That allows me to see if a note was edited on a commit, which gives me a rough idea how frequently it was edited in total. You can also schedule Git commits to be every day or every week.

I like this idea. I also thought about it. It is interesting to save info to see how frequently a note was edited.
You might like the compromise that I came up with then: using Git. I got it set up this way that it only tracks *.md, and .gitignore files. Then using restore command I can make the files appear as they were on a chosen commit. That allows me to see if a note was edited on a commit, which gives me a rough idea how frequently it was edited in total. You can also schedule Git commits to be every day or every week.

Yep. Another option - using restoration tool. For non-tec-savy people. Yet, having this in my front-matter is where it makes the most sense to me. I want it to be somewhat in my face. Moreover, it should not be a hard change. Sooo...🤷♂

I second this append option. There is another plugin that does this with a YAML checkbox to selected notes from alangrainer. It could be great to unify everything in one plugin.

I second this append option. There is another plugin that does this with a YAML checkbox to selected notes from alangrainer. It could be great to unify everything in one plugin.

Does it behaves like I've described? I mean multiple updates as a list.


Cuda out of memory while using Keras.fit_generator and multiprocessing

I am using keras from Tensorflow-2 with cudatoolkit-10. So by default my program is running in egar execution.
I have two senarios:

which works fine but slow
model.fit_generator(generator=trgen,validation_data=trgen,epochs=10,verbose=2,use_multiprocessing=False)

which give cuda memory error
model.fit_generator(generator=trgen,validation_data=trgen,epochs=10,verbose=2,use_multiprocessing=True)

I am not sure why multiprocessing is not working.
My generator looks like:
`
class Generator(tf.keras.utils.Sequence):
def __init__(self, filenames, batch_size):
    self.filenames = filenames
    self.batch_size = batch_size
    self.on_epoch_end()

def __len__(self):
    return int(np.floor(len(self.filenames) / self.batch_size))

def __getitem__(self, idx):
    indexes = self.indexes[idx*self.batch_size:(idx+1)*self.batch_size]

    list_IDs = [self.filenames[k] for k in indexes]
    X = self.__data_generation(list_IDs)
    return (X,X)

def on_epoch_end(self):
    # Update and shuffle indexes after each epoch
    self.indexes = np.arange(len(self.filenames))
    np.random.shuffle(self.indexes)

def __data_generation(self, list_IDs):
    temp=[]

    for i, ID in enumerate(list_IDs):
        out=read_file(ID)     #dummy tf function that returns a tensor
        temp.append(out)

    X_temp = tf.stack(temp,axis=0)

    return X_temp`

@Jamesswiz
Moving this issue to closed status as there has been no activity, in case you still face the error please create a new issue.


[WIP] Adding local builds

OK, cool. This is gonna be a great option. Please read the following as constructive :) This will likely be a user's first view of this tool and it's still pretty heavily geared toward more sophisticated usage / actual brew usage, could use some dumbing down UX improvement for a local build. I see what you mean about --local requiring logic all over the place though. Not saying all this has to be fixed right away, just pointing out the rough edges I noticed that users are sure to run into as well.

doozer --local -i logging-curator5 images:rebase

requires -m even though who cares?
requires --version although again, who cares?
if you don't supply --version then you get a TypeError stacktrace trying to match the version regex against None, instead of a helpful error

doozer --local -i logging-curator5 images:build

requires --repo-type ... might be nice to explain why, or what the options mean, or default to unsigned if not supplied; something more helpful than "No repos specified. --repo-type or --repo is required."
also specifying --repo alone gets you an error --
unable to copy transient context into container: stat .oit/None.repo: no such file or directory
when imagebuilder fails, the error Unable to start imagebuilder is misleading -- imagebuilder may start fine, but the build itself failed. should be something like error while running imagebuilder
the experience does kinda suck without realtime output :( yum install takes forever... every time you run. output would be nice i guess, at least in the single-build case. imagebuilder now seems to send everything to stdout the way it should so maybe this would not be so bad. low priority though.
with unspecified release, it's put in image tag as "?" so get error:
 Committing changes to openshift3/ose-logging-curator5:v3.11.59-? ...
; err=unable to commit build container: API error (500): {"message":"invalid tag format"}
with version and release of something already built, you get Image already built instead of testing the build
maybe skip Image build metrics: since there won't be any brew builds?
images can actually build in OSBS with imagebuilder or docker. each has its place. it would be best if the local build could switch to use imagebuilder or docker build according to {default_,}image_build_method

Thanks @adammhaile

I wonder if this might work better as images:local-build? I'm not sure shoehorning the local logic alongside the brew use case is the safest approach.

@sosiouxme
I had the same local-build thought but rebase/update-dockerfile also needs to be "local". And others will need the same treatment eventually. So I felt it deserved more of a global option. This also means that you can add local: true to your ~/.config/doozer/settings.yaml and it will always build local. Which I feel would be handy for some (though then I should give the ability to pass --no-local or something to temp turn it off).
rest of answers numbered...

Agreed, that should be made optional for local. But I knew there would be debate on how to handle the local aspect.  Honestly, that would be a tick in the column for having a separate verb (as -m is required currently)

Same answer as #1

Yeah, I saw the same thing. That just needs to be fixed in general and have that option be required or update the logic to make that mean "don't change the version in the Dockerfile"

Damnit, your numbers started over :P

--repo-type will go away very soon. But for now I think default it to unsigned makes sense.

Well... that's just a bug :P That click option should require a parameter after --repo

Fixed.

Yeah, I just need to make a cmd_realtime or something in exectools that does this. Easy to do. But would probably have to only run that when I detect it's a single image build.

Oops. Hmm... what do you suggest? Just always set to 1 maybe if unspecified?

Testing the build? Is imagebuilder supposed to do that?

Yeah... that needs to come out. Working on it.

Hmmm... interesting. I'll see what I can manage.

On Thu, Dec 20, 2018 at 10:18 AM Adam Haile<EMAIL_ADDRESS>wrote:

That click option should require a parameter after --repo

It does, but the build is still looking for a local repofile. I guess
--repo doesn't really jive with --local anyway. But the errmsg suggests it!

Oops. Hmm... what do you suggest? Just always set to 1 maybe if
unspecified?

Probably the best approach.

Testing the build? Is imagebuilder supposed to do that?

No, I mean because there was an existing build w/ same NVR in brew, the
local build didn't run at all.

Ah... good call Luke. It's on my list to tackle after the break :)
On Fri, Dec 21, 2018 at 9:25 AM Luke Meyer<EMAIL_ADDRESS>wrote:

One other thing... we should enable configuring the build concurrency, as
most machines won't do well with 20 running at the same time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/doozer/pull/18#issuecomment-449401628, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA6a6j2zgsicfMGeogZw_vo5b3wH9Hmwks5u7O9egaJpZM4ZaxSL
.

@sosiouxme

Regarding -m, I have made it optional when --local is specified
--version now works correctly if not provided and is not required at all for --local
--repo-type now defaults to unsigned
Fixed --repo issue
Fixed unable to commit build container tag error
Metrics are now skipped

Working on concurrency now...


Can we use blob fuse for this?

Hi Team,
Can we use blob fuse as i don't see the option mentioned.
https://docs.microsoft.com/en-us/azure/storage/blobs/storage-how-to-mount-container-linux

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24c37d16-5a77-29d4-7994-9c0e3e0dc1e9
Version Independent ID: 4b841eb4-2fc7-e9ca-090a-3a6477f837c6
Content: SAP HANA Azure Backup on file level
Content Source: articles/virtual-machines/workloads/sap/sap-hana-backup-file-level.md
Service: virtual-machines-linux
GitHub Login: @hermanndms
Microsoft Alias: juergent

@aquibqureshi26
Thanks for the Question! I have assigned the issue to the content author to answer your question  and update the document as appropriate.

@hermanndms please answer the users question and update the doc as needed

Hi Team,
Still waiting for confirmation

sorry for the big delay. I overlooked this in the past for several reasons.
We have to differentiate two scenarios :

HANA backup to the file system
As long as HANA sees a standard files system ( I always use XFS for HANA ) on OS level it should work to do
a backup directly on it. I personally never touched blob fuse. As long as we talk about an officially supported
solution on Azure it's fine. Best would be to simply run a test backup and a test restore with HANA to also
verify performance.

copy HANA backup files
Same thing as above. One can copy files to whatever target is supported and works.

In general one should review the usage of third party backup software which supports HANA backups on Azure
or of course the native HANA backup support of the Azure backup service. These solutions have one key
advantage - they help to manage all the backups. Doing backups to the file system means that one has to
take care of this management on his own ( retention times, what's the latest backup to use for restore ……. )

Best Regards
Hermann

so sorry, overlooked this in the past .... too many emails, too much other stuff, confusing times …..
Just enetered a comment.
From: Aquib Qureshi<EMAIL_ADDRESS>Sent: Mittwoch, 13. Mai 2020 02:09
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Hermann Daeubler<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Can we use blob fuse for this? (#51953)
Hi Team,
Still waiting for confirmation
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F51953%23issuecomment-627665440&data=02|01|hermann.daeubler%40microsoft.com|54fc0aa1fc48409ef69e08d7f6d1e000|72f988bf86f141af91ab2d7cd011db47|1|0|637249253578393143&sdata=pu8sbTFniKVWwzPPKORVICDaB%2B0ALdx%2BPp0Lu1mQzTY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACZNIF44UQUSUHNQC7AMPKTRRHQKXANCNFSM4MDVTPEQ&data=02|01|hermann.daeubler%40microsoft.com|54fc0aa1fc48409ef69e08d7f6d1e000|72f988bf86f141af91ab2d7cd011db47|1|0|637249253578403105&sdata=tH37On%2BswkqR18jEAitW0fo7wp9AzinsL80lLGlaG4c%3D&reserved=0.

thanks Herman, as currently we're able to take backup on blobfuse and it's working I thought just confirm if someone has tried and that comes under supported/unsupported scenario.
anyways you mentioned about xfs as preferred filesysyem and blobfuse has its own system.
Im using this backup strategy for dev/uat and definitely will use some backup solution for prod.
Thanks for sharing.
Stay safe and positive :)

We are currently cleaning up old issues and closing out items that are greater than 90 days old. If an issue is still present, please open a new feedback item on the document so we can prioritize correctly.
#please-close

thanks Herman, as currently we're able to take backup on blobfuse and it's working I thought just confirm if someone has tried and that comes under supported/unsupported scenario.
anyways you mentioned about xfs as preferred filesysyem and blobfuse has its own system.
Im using this backup strategy for dev/uat and definitely will use some backup solution for prod.
Thanks for sharing.
Stay safe and positive :)

Hi Aquib,
I'm currently trying to achieve the same (direct SAP HANA Backup (data / log) to Azure Blob Storage via blobfuse.
It's not working for me - can you tell me how you mounted the container and what I have to consider?
ERROR   BACKUP   SAVE DATA finished with error: [447] backup could not be completed, [2000008] Error during asynchronous file transfer (io_getevents), rc=22: Invalid argument; $fileCallback$=[W] , buffer= 0x00007fcadc000000, offset= 4096, size= 8781824/83886080, file= "/.COMPLETE_DATA_BACKUP_XXX_databackup_2_1" ((open, mode= W, access= rw-r-----, flags= ASYNC|DIRECT|TRUNCATE|UNALIGNED_SIZE), factory= (root= "/backup/blobfuse/xxxadm/XXX/" (access= rw-r-----, flags= AUTOCREATE_PATH|DISKFULL_ERROR, usage= DATA_BACKUP, fs= UNKNOWN (fuse), config= (async_write_submit_active=on,async_write_submit_blocks=all,async_read_submit=on,num_submit_queues=1,num_completion_queues=1,size_kernel_io_queue=512,max_parallel_io_requests=64,min_submit_batch_size=16,max_submit_batch_size=64))) {shortRetries= 2, fullRetries= 11 (10/10)}
Manual copying of a local backup to the same container is working perfect.
Thanks
Benjamin


Back Icon Does Not Display On Android

Version
Tell us which versions you are using:

react-native-router-flux v3.43.0
react-native v0.55.4

Expected behaviour
The back icon for the navbar does not show on android.
Actual behaviour
The back icon does not display when i navigate to a new screen on android, but does in iOS
Steps to reproduce
Below is what the scene looks like.
<Scene key='Login' component={LoginScreen}
  hideNavBar={true} hideTabBar={true}
  backButtonImage={backIcon.icon}
  leftButtonIconStyle={[Styles.navbar.imageIcon, Styles.navbar.back]}
  navigationBarStyle={Styles.navbar.container}/>

It's quite sad I've come so far into the project i'm in only to realise so many problems with this package.
:(

Please try to reproduce it with Example project and latest version 4.0.0-beta.40. Feel free to open if the issue still exists


Revisit documentation part 1: divio-like landing page, installation page, configuration page

First PR to revisit a bit the documentation. Goal is to invest some time in revisiting the documentation but to still make those changes incrementally. See https://github.com/huggingface/huggingface_hub/pull/1226 for a more exhaustive list of what can be planned/what is planned to be improved "at some point".
PR includes:

update the landing page to adopt the divio framework
add guides / tutorials / concepts / references folders and section. Currently some are empty. Existing guides have been kept in the same place to avoid breaking urls
add a installation page to detail how to install huggingface_hub
add a configuration page to describe environment variables
(very) slightly revisit the quickstart page but no big changes

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks a lot @LysandreJik  and @stevhliu for the feedback ! I integrated all of your comments. They helped a lot :+1: :+1:


Patch 1 3.10.1 updated typing extensions

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@kevin-bates Could you take a look please, updated meta.yaml to build version 3.10.1 and bumped the cap on typing-extensions to match the code.


Address difference in JsArray and Array argument orders

resolves https://github.com/Risto-Stevcev/bastet/issues/28
This includes tests in the same vein as bastet/src/Array where applicable.
Per https://github.com/Risto-Stevcev/bastet/issues/28#issuecomment-603578667, I replaced calls to Js.Array.concat with calls to Alt.alt.

It would have been my preference to somehow further abstract the difference between Test.Array and Test.JsArray so that the same test suite could be run against both, but this seems a little more attainable without going to nuts.


NBS: Multiple writers may attempt the same compaction concurrently

Thankfully, this is not incorrect behavior, but it can be very wasteful, especially for a large compaction -- and worse the larger the compaction, the more likely that multiple writers will attempt it because the need for the big compaction will be visible for alot longer.
We need some way to help writers avoid doing alot of pointless read/write work that is already underway.

Summary of meatspace discussion w/ @cmasone-attic:
Near-term tactic: When writers go to commit, compute a threshold value for compaction, something: numTables/maxTables. If Rand() > thresh, compact. This will mitigate the probability of multiple writers computing the same compaction, but will result in far higher write amplification.
Long-term strategy: prevent (or something close to it) writers from attempting the same compaction, but allow concurrent writers to continue to commit. This has two steps:
-Effectively remove maxTables (basically set is to something very high).
-Create a mechanism for writers to "lock" a compaction (prevent other writers from attempting it). for File:, this will simply be flock, for AWS, this will likely be setting an attribute on the manifest table which must be kept alive by the active writer.

Closing in favor of more specific bugs.


Fix runner param override

Add enum to the list of overridable attributes and update documentation.

As far as documentation goes, I think it would be a good idea to add a script which generates a table with which parameters can be overrided based on the value of RUNNER_PARAM_OVERRIDABLE_ATTRS and include this file in the docs.
This way code and docs won't get out of sync (we already do this in other places).
I"m also happy to do this change myself.

The change for auto-generating this list is here - https://github.com/StackStorm/st2docs/pull/11


Showcase Identity provider update

Remove custom class for reusing the one provided by kie-identity-session-provider

@csadilek this and https://github.com/droolsjbpm/jbpm-console-ng/pull/294 PRs are simple configuration switch and removal of unnecessary class on the showcase app. It is probably not worthwhile testing if the new provider class was loaded in this case.

master: ac1983264576384a90e1a17d91b978a1f0949c5a


Leaderbord dead nodes

Hello! I see my node in the vault leaderboard.
5EeQqU4hHNDHiPcgRJHb5q7hU3WsRx5R7SwEBXmzJf8nkuNF  SLA score 6.44 right now. I have a screenshot. But I turned off this node a few days ago.
How is this possible?

When your vault is offline, its account is still registered on the parachain. Vaults don't need to be online to accept new issue requests and this is purely decided on the parachain level. In your case, the vault might be assigned an issue request that then was leading to an increase in the SLA.


create a main() method

Nice script. However, the code below
if __name__ == "__main__":

is too long. It would look much better if you called a method and you put everything in there:
if __name__ == "__main__":
    main()

You can also split up the main() method to smaller functions/methods.

Thanks! I am really new to python and seriously dont know what I am doing.  i will take some time this weekend to look through a style guide and see if I cant clean it up.

What took 6 years?


[playground] Bug Fix: change default dev port to 3000

Description
npm run dev (and associated npm run start) used to start on port 3000, which was the old vite default. The default changed to 5173, but no reason we can't keep the previous behavior https://github.com/facebook/lexical/pull/6018#pullrequestreview-2039349437
Test plan
Before
npm run dev listens on port 5173 (after #6018 was merged)
After

npm run dev listens on port 3000
tests and other commands that also specify a port still get the desired choice

Does it make sense to put the port in the vite config files, rather than extend the npm scripts. I think it's cleaner, no strong opinion on this. Approved.

@ivailop7 I also don't have a strong opinion about it either way. server: {port: 3000} in the vite.config.ts does that. If you specify multiple ports on the command line it takes the last one, so practically speaking other than where the setting is it's not a very observable difference. We manually specify the port elsewhere in the package.json files so I just did it in the same place.

@ivailop7 I also don't have a strong opinion about it either way. server: {port: 3000} in the vite.config.ts does that. If you specify multiple ports on the command line it takes the last one, so practically speaking other than where the setting is it's not a very observable difference. We manually specify the port elsewhere in the package.json files so I just did it in the same place.

Fair enough


Unhandled rejection HeadlessError: Phantom immediately exited with: 255

Hi. First of all, thanks very much for such project.
I am trying to use phantom-prebuilt with horseman and the following error came up when I tried to launch it.
Do we have a list of all these error code and what it means? May I also ask how could I debug it? Thanks.
Unhandled rejection HeadlessError: Phantom immediately exited with: 255
    at ChildProcess.immediateExit (http://localhost:3000/dist/bundle.js:210237:24)
    at ChildProcess.g (events.js:286:16)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

The meanings of the error codes are not from Horseman. You need to look at PhantomJS probably.

I seem to be bumping into this (or something similar) as well.
Phantom Simple is getting SIGSEGV
I noticed the node-phantom-simple build is failing and I'm wondering if that has anything to do with it.

@awlayton Hi, this is cause of Horseman, there is no error code with 255 number is phantomJS, also I have tested phantomJS with webdriverio it works as expected.

It is not horman @sharifzadesina. The message clearly states that phantom is exiting with code 255. Horseman doesn't have or define any exit codes.

@awlayton of course horseman doesn't. but it does some thing that cause this. you can test this by yourself, for example try and use horseman in electron or node-webkit, you will get 255 return code, but if you use phantomjs with webdriverio you won't.

What do you mean use "use horseman in electron or node-webkit"? Horseman doesn't run in anything except NodeJS, and the only browsers it supports and phantom and slimer.
I cannot try it myself because for me phantom-prebuilt works just fine with Horseman. There must be something about your setup.

@awlayton !!! man electron and node-webkit are node.js way for building desktop applications!!! they are node.js!!!
I told you how you can test, just try to run horseman on electron or node-webkit you will get this error.
Start here, it will take only 10 minute of you.

I know what electron and node-webkit are. What would you use them with Horseman though? Horseman would still need phantom or slimer to work.

@awlayton Yes, I install phantomjs-prebuilt, horseman can access to the phantomjs binary and it can run it, but it doesn't work and throws 255 error, for unknown reason, in the other hand with phantomjs works well with webdriverio.

I understand webdriverio. I do not understand what electron and node-webkit have to do with this.

@awlayton I want to use horseman through electron/node-webkit desktop applications. but it throws 255 error.

I do not really have time lately for debugging Horseman issues, which is why there are so many.
Using electron should have no effect on horseman. If I had time to debug, I would start by figuring out under what circumstances phantom exits with code 255.
If you post code I can run to try to reproduce the error on my system, I will try to run it. Or you could try the phamtomjs npm package, or installing phantomjs globally for horseman to find (it checks the $PATH).


fix: typo in personaldetails prop

Details

Fixes crash on login due to incorrect typo of the prop added in https://github.com/Expensify/App/pull/9642

Fixed Issues

$ https://github.com/Expensify/App/issues/9238
Tests

Tested by logging in with the email address
Retested the cases in https://github.com/Expensify/App/pull/9642

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

 Wouldn't this have errored on dev?

@mananjadhav How did this get past testing? Wouldn't this have errored on dev?

Thats what I am not sure of. I did test all the platforms and even created Announce rooms during the testing. What I did was, I pulled the latest main branch for another PR of mine and I logged out and I logged in - it crashed!!

Yeah it would have definitely failed on dev. Not sure how it was missed but glad it was addressed soon since puneets code is not on staging yet :)

Yeah it would have definitely failed on dev.

I even attached a screenshot of the test on mobile with this branch in this comment https://github.com/Expensify/App/pull/9642#issuecomment-1188246769

glad it was addressed soon since puneets code is not on staging yet :)

👍

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

It was strange but I have found what happened here. So https://github.com/Expensify/App/pull/9560 has removed myPersonalDetails key which we used at that PR and at that time https://github.com/Expensify/App/pull/9560 wasn't merged so it was working fine but because  myPersonalDetails has been removed so we got errors. However we still need one more PR because the it's not working as expected now. I will raise the PR soon.
cc: @mananjadhav @thienlnam @chiragsalian

Thanks for the detailed analysis @Puneet-here. I had reached the point of identifying #9560, and was going to investigate if we need more fixes. Would be great if you can raise the PR. Thanks again for the diligence.

Found the solution. Now raising the PR 🚀

PR is up, feel free to review.
cc: @mananjadhav, @thienlnam

🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅