[Minor] Am decoder refactor

Description
Refactoring of the Attention model's decoder.
Motivation and Context
By outsourcing the computation of glimpse_<q,k,v> and logit_k tensors into separate functions, we allow for more flexibility when reusing this decoder for other models. In scheduling for example, we need to select the embedding of the next operation for each job. This can now be achieved by simply overwriting the _comput_kvlfunction.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of examples)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.

@fedebotu ok just realized it might also be useful to have an exchangeable Pointer haha

ok just realized it might also be useful to have an exchangeable Pointer haha

Yeah we had a similar issue in another project and had to copy-paste everythin :rofl:  this will help


Anerdw: Watch SR University

Anerdw requests the watch of the watch_keyword SR University. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

SR University has been seen in 4 true positives, 0 false positives, and 0 NAAs.

Self-rejected by Anerdw in Charcoal HQ. Reason: 'Missing fancy space; superseded by 13939'


⚠ Processors has degraded performance

In 63b4b62, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 53 ms

Resolved: Processors performance has improved in bbe3e54.


Server side missing indigo: Unable to load library '.../libindigo.so': Native library not found in resource path

Hi,
I managed to get the whole bundle up and running using docker compose up. However, I have encountered a problem regarding what seems to be an error on the side of Indigo toolkit: whenever I try to save or import a structure in the Ketcher editor, nothing seems to happen. For example, nothing changes in the reaction scheme window:

At the same time, JS browser console and terminal log the same error, here is a link to a gist. It seems that somehow ELN application cannot locate Indigo library.
I've tried tinkering around the code, but I wasn't able to resolve this probem. Any help would be greatly appreciated!

I encountered this error too. Is there a solution? @mkviatkovskii

I encountered this error too. Is there a solution? @mkviatkovskii

Could you provide proper link!

I have also encountered this issue recently. I don't have a fix, but my suspicion is a problem with the BingoDB cartridge. Text, numerical and files are all saved to the DB, but the chemical structures (from Ketcher) aren't getting into the DB. As reported by others, I see the same error when attempting to save a Ketcher structure to the ELN:
2024-04-10 17:00:37 indigoeln-server-1  | java.lang.UnsatisfiedLinkError: Unable to load library '/tmp/indigo8da420a34c5340161cbe4c60a8df4dc8/libindigo.so': Native library (tmp/indigo8da420a34c5340161cbe4c60a8df4dc8/libindigo.so) not found in resource path

Fixed by https://github.com/epam/Indigo-ELN-v.-2.0/pull/15

the problem did not encounter in docker version.

@saurabhgayali Do you mean it's fixed now under docker? Or it never appeared under docker? If latter, I had the same error with docker until it was fixed


add 1-28 as a supported release branch

Issue #, if available:
Description of changes:
Add EKS-D 1.28 build support
Add 1-28 as a supported release branch
Add 1-28 metrics server
Add 1-28 cluster autoscaler
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm
/approve


10 ➡ 11 (main)

10 ➡ main Forward port
Port ign-transport10 to main
Branch comparison: https://github.com/ignitionrobotics/ign-transport/compare/main...ign-transport10
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Are the Homebrew warnings new?

Are the Homebrew warnings new?

I've seen them there for a while, they were also on https://github.com/ignitionrobotics/ign-transport/pull/259. I think there's a new ZMQ version?

It doesn't sound very critical but I'll try to take a look.


Drop dependency on mocha-jsdom in favor of explicit solution

Instead of doing something mysterious with mocha-jsdom we now do as suggested in https://github.com/facebook/react/issues/5046#issuecomment-146222515.

@gaearon: I have been using a similar solution to this for my tests for quite some time. Recently we have switched to using the shallow renderer, which has allowed us to remove jsdom from our tests completely. This has given our tests a significant speed boost. Shallow rendering also forces you to keep each component relatively simple since it prevents you from testing heavily nested components.
Just thought I'd share a tip on something that we've found to be valuable.

We are using shallow rendering too, take a closer look :-) The only reason we use jsdom is to prevent React from blowing up with errors when using setState with shallow renderer. (#4019) I have heard people say that actually shimming global.document = {} is enough for React to work properly. If that's really so, we can drop jsdom from instructions.


Remove pipeline env

A Pipeline doesn't seem to have the concept of envs. This field is returned in the API, but is not settable (thus always an empty object {}). I have tried with POST and PUT.
This field is not settable through the UI neither.
If this field is supposed to be settable, then it is an issue with the API!.

Hey @unrealcloud thanks for the PR. @jayco and I are looking into exactly what is going on here, and what is supposed to be going on.


Remove whitespace: pre because of extra empty lines bug

Details
This PR is reverting partially what was done here: https://github.com/Expensify/App/pull/9025/files
The whitespace: pre seems to be making empty divs have height and appear as an empty line. We end up with these empty divs when messages came from an email response.
When testing / QA we should make sure that the test / QA from these PRs also passes:

https://github.com/Expensify/App/pull/9025
https://github.com/Expensify/App/pull/6975

Fixed Issues
$ https://github.com/Expensify/App/issues/8088
Tests

Open a chat in NewDot and get the reportID and the accountID of the participants

Insert in the database a comment with weird spaces (replace  and  with values from step 1):
INSERT INTO reportActions (created, reportID, accountID, action, message) VALUES
('2022-05-28 16:10:10', <reportID>, <accountID>, 'ADDCOMMENT', '{"html":"

Hi SomeName, <\/p>
<\/p>
<\/p>
\u00a0<\/p>
Will tomorrow at 34 est. work?<\/p>
<\/p>
<\/p>
\u00a0<\/p>
Thanks,  Test<\/p>
<\/p>
<\/p>
\u00a0<\/p> <\/div>xxxxxx xxxxxxxx xx xxx: xxxx x-xxxx xxx xxxxxxxxxx xx xxxxxxxxxxxxx xx xxxxxxxxxxxx xxxxx x.x. xxx, xx xxx xxxxxxx xxxxxxx xx xx xxxxxxxxx xx xxxxxxx x xxxxxxxxxx xxxxxxx xx xxxxxxx. xxx xxx xxxxxx xxx xx xxxxxxx xxxxxxxxxxx xxx xxxxxxxxxxx xxxxxxxx xxxx xxxxx  xxx (xxxxxx xxx xxx xxxxx.xxx xxxxxxx, xxxxx xxxxxx x-xxxx xxxxxxxxxxx xxxxxxx x xxxxxxxx xxxxxxx) xx xxxx x-xxxx xxxxxxx xx xxxxxxxxxx xxxx xxxxxxx xx<EMAIL_ADDRESS>xx xxx xx xx, xxx xxxxxx xx xxxx xxxxxxx xxxx xx xxxxxxxx xxxxxxxx. xxx xxxxxxxxx  xxxxxx xxxxxxx xx 225 x xxxxxx xxxxx, xxxxx 2600, xxxxxxx, xx 60602-4903.  xxxx xxxxx xxxxxxx xx xxxx xxxxx xxx xx xxx xx xxx xxxxxxxxxxxx xxx xxx xxxxxxx xxxxxxxxxx xx xxxxxxxxxxxx xxxxxxxxxxx  xx xxxxx xxxxxxxxxxx xxxxxx xxxx xxxxxxxxxx xxxxx xxxxxxxxxx xxx. xx xxx xxx xxx xxx xxxxxxxx xxxxxxxxx, xxxxxx xxxxxx xxx xxxxxx xx xxxxx xxxxx xxxxxxxxxxx xxx xxxxxx xxxx xxxxxxx xxxxxxx xxxxxxx xxxxxxx xx xxxxxxxxxx xx xxxxxx. xxxx xxxxx xx xxx xxxxxxxx  xx xx x xxxxxxxx xx xxxxx xxxxxxx xxxxxxx xxxxxxxxxx, xxx xxx xxx xxxxxx xxxxxxxxx xx xxxx xxxxx xxxxxx xxx xx xxxxxxxxx xx x xxxxxx xxx xxxxxxx xxxxxx xxxxxxxxx xxxxxx. xxxxx xxx.xxxxx.xxx\/xxxxxxxxxx xxx xxxx xxxxxxxxxxx xxxxx xxxxx xxx xxx xxx xxxxxxxxxxxx.     "}');

Send a comment with the following content (without codeblock):

0 spaces
 1 spaces
  2 spaces
   3 spaces
    4 spaces

Send another comment with the following content (including a code block)

0 spaces
 1 spaces
  2 spaces
   3 spaces
    4 spaces
some code

You should see that whitespaces are respected and that there aren't extra white lines added

[ ] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Before fixAfter fix

Mobile Web

Desktop
iOS

Android

Before fixAfter fix

@parasharrajat since you are somewhat familiarized with the problem... do you know of any regressions this PR could cause by removing whiteSpace: 'pre',?

I can see that this breaks in some cases when you copy/paste HTML stuff that had white spaces. I.e. copy the sample text from test step 3) and paste it as comment using CMD + SHIFT + V, whitespaces will be lost:

The whitespaces are simply gone when looking at the DOM. The spaces seem to be getting lost in the rendering process because I can see them coming from the backend in the Report_History:
"0 spaces
 1 spaces
  2 spaces
   3 spaces
    4 spaces

some code

some more      code

asdad asd asd. asda.       asd

1. Some item
    i. Some subitem 1
    ii. Some subitem 2
2. Some item 2"

And this is one that looks fine:
"0 space
  2 spaces
    4 spaces
      6 spaces"

I'm not sure about what is the difference yet.

I will dig this over the weekend and let you know. Thanks for waiting.

Without the changes from this PR you should see:

With the change (remove whitespace:pre) from this PR you will see:

Sorry, I wasn't able to look into this on the weekend but I will follow up tomorrow. For now, I see that there is a issue with whitespace:pre as you mentioned. But I am curious to see that how the whitespaces are preserved without it. Will debug this and let you know.

That is exactly an option I was considering, I'll test it today later
On Wed, Jun 8, 2022, 11:19 Rajat Parashar @.***> wrote:

Looking at the code, I can say that removing whitespace:pre is not
completely safe. It will not preserve whitespaces in HTML. Your explanation
is correct #8088 (comment)
https://github.com/Expensify/App/issues/8088#issuecomment-1149340794.
What if we convert the   to normal whitespace.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/pull/9195#issuecomment-1150242703, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AU2LVBU5RKQF3Q2TCPRWWHDVODPZZANCNFSM5XCRBU7Q
.
You are receiving this because you were assigned.Message ID:
@.***>

I gave it a try to converting the   to normal spaces, but it looks the same. We still have empty divs taking space.
For the purpose of testing it quicker, I did it in the front here (ReportActionItemFragment):

I also tested adding enableExperimentalBRCollapsing and enableExperimentalGhostLinesPrevention to TRenderEngineProvider, but didn't help.

Got it. Then backend would be the only viable option.

Got it. Then backend would be the only viable option.

Not necessarily. I'm somewhat confident in that email replies will very often contain &nbsp. We could check if they contain that, and if they do don't force the white-space: pre;
And by "backend would be the only viable option", what kind of processing would you suggest? because now we know that just replacing the   by ' ' won't work

because now we know that just replacing the   by ' ' won't work

Yeah, it would be too much work. Normally Markup of emails is complex.

We could check if they contain that, and if they do don't force the white-space: pre;

Sounds like it will work. Remove the styles from baseFont and apply it to the wrapper.

cc @tgolen since you participated in this convo and in case you want to have a look

I'll try and remember to check this, but please remind me if I forget to review this once the other PR is merged.

Update: DRYer code

I'll try and remember to check this, but please remind me if I forget to review this once the other PR is merged.

@Julesssss I merged the other PR, just letting you know in case you want to review this

Removed hold for https://github.com/Expensify/Web-Expensify/pull/33993 (it has been deployed to production).. fixing conflicts now.

Bump, had to resolve conflicts, need an approval again to get this merged :)

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


The state of AWS Lambda Go Streaming support

Is your feature request related to a problem? Please describe.
I had been trying make the AWS Lambda response streaming work with aws-lambda-go runtime and I was not able to succeed. Neither the Lambda Function URLs or direct API call using InvokeWithResponseStream work and instead I was retrieving the entire response serialized to JSON.
I made my Lambda function return the events.LambdaFunctionURLStreamingResponse, but the entire response had been serialized and returned as JSON. The passed io.Reader had not been proceesed and suprisingly enough the response contain JSON serialized representation of the io.Reader implementation i.e.
{"StatusCode":200,"Headers":{"Content-Type":"application/octet-stream"},"Body":{"ReadCloser":{}},"Cookies":null}

I had been runing the GO Lambda function on al2023 runtime, compiled the binary with -tags lambda.norpc option and set up the Function URL.
 Even the documented in code example is not working correctly:
// Example:
//
//	lambda.Start(func() (*events.LambdaFunctionURLStreamingResponse, error) {
//		return &events.LambdaFunctionURLStreamingResponse{
//			StatusCode: 200,
//			Headers: map[string]string{
//				"Content-Type": "text/html",
//			},
//			Body: strings.NewReader("Hello World!"),
//		}, nil
//	})
//
// Note: This response type requires compiling with `-tags lambda.norpc`, or choosing the `provided` or `provided.al2` runtime.

Which results in response from Function URL:
{"StatusCode":200,"Headers":{"Content-Type":"text/html"},"Body":{},"Cookies":null}

Is Response Streaming not supported with Go runtime?
Describe the solution you'd like
I would like to use Lambda Response Streaming with my Go runtime.
Describe alternatives you've considered
I am not using AWS Lambda for this use case today.
Additional context
github.com/aws/aws-lambda-go v1.47.0

Streaming URLs is supported! I'm sorry to see that you're having issues!

The passed io.Reader had not been proceesed and suprisingly enough the response contain JSON serialized representation of the io.Reader implementation i.e.
{"StatusCode":200,"Headers":{"Content-Type":"application/octet-stream"},"Body":{"ReadCloser":{}},"Cookies":null}

Can you provide a code sample that produces this response?  Even the documented in code example is not working correctly
{"StatusCode":200,"Headers":{"Content-Type":"text/html"},"Body":{},"Cookies":null}

The example code works for me when I tested today.
My main.go:
package main

import (
        "strings"

        "github.com/aws/aws-lambda-go/events"
        "github.com/aws/aws-lambda-go/lambda"
)

func main() {
        lambda.Start(func() (*events.LambdaFunctionURLStreamingResponse, error) {
                return &events.LambdaFunctionURLStreamingResponse{
                        StatusCode: 200,
                        Headers: map[string]string{
                                "Content-Type": "text/html",
                        },
                        Body: strings.NewReader("Hello World!"),
                }, nil
        })
}

My template.yaml:
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Resources:
  StreamingFunction:
    Type: AWS::Serverless::Function
    Metadata:
      BuildMethod: go1.x
    Properties:
      CodeUri: .
      Handler: .
      Runtime: provided.al2023
      Architectures: [ arm64 ]
      Timeout: 10
      FunctionUrlConfig:
        AuthType: AWS_IAM
        InvokeMode: RESPONSE_STREAM
Outputs:
  StreamingFunctionURL:
    Description: "Streaming Lambda Function URL"
    Value: !GetAtt StreamingFunctionUrl.FunctionUrl

Deployed and tested sam build && sam deploy --region us-west-2 --profile "$USER".

Thank for the comprehensive response. I realized that the main reason why I run into this problem is that I had use BuildMethod: makefile once I change it into BuildMethod: go1.x and remove the Makefile from the project the response has been process fully and was not serialized as JSON.
"{\"statusCode\":200,\"headers\":{\"Content-Type\":\"text/html\"}}\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000Hello World!"

I guess my question is, is there still possible to make this work with a custom Makefile?
The makefile I had been trying to use
build-Function:
	GOOS=linux GOARCH=arm64 go build -o bootstrap -tags lambda.norpc .
	cp ./bootstrap $(ARTIFACTS_DIR)/.


Add API docs to repo

Description
Ensure that API docs are generated correctly, and are added to readthedocs.io
Done Checklist (Development)

[x] Docs on readthedocs.io

Docs are now live at:
stellargraph.readthedocs.io

@adocherty can this be closed?


Make install a little bit less aggressive

I think that it's better to let people use the script without having to install it in their systems permamnently

You're correct that is is no real reason it needs to be on their system in /usr/local/bin , but it's helpful for people new to Linux since it can be accessed without having to have it in their cwd.
So Im going to keep it as is since this helps the newbies and people who know they don't want it on their system will know they don't need to move it there. Thanks for the suggestion though 😃


Cleanup work for launching single task executions.

Updated EntityDetails to pass the correct props when launching a Task
Updated RelaunchExecutionForm and underlying hooks/functions to generate the correct initial parameters based on whether the source execution was a single task or a workflow.

Codecov Report

Merging #102 into single-task-execution will decrease coverage by 0.17%.
The diff coverage is 42.16%.

@@                    Coverage Diff                    @@
##           single-task-execution     #102      +/-   ##
=========================================================
- Coverage                  68.58%   68.40%   -0.18%
=========================================================
  Files                        382      383       +1
  Lines                       6254     6299      +45
  Branches                     973      986      +13
=========================================================
+ Hits                        4289     4309      +20
- Misses                      1965     1990      +25

Impacted Files
Coverage Δ

src/components/Launch/LaunchForm/types.ts
100.00% <ø> (ø)

...ts/Launch/LaunchForm/useLaunchWorkflowFormState.ts
98.78% <ø> (ø)

src/components/Entities/EntityDetails.tsx
44.11% <20.00%> (-4.16%)
:arrow_down:

...cutions/ExecutionDetails/RelaunchExecutionForm.tsx
26.19% <21.62%> (-27.15%)
:arrow_down:

...Launch/LaunchForm/useMappedExecutionInputValues.ts
31.81% <31.81%> (ø)

...ExecutionDetails/ExecutionDetailsAppBarContent.tsx
95.65% <100.00%> (ø)

...omponents/Executions/ExecutionDetails/constants.ts
100.00% <100.00%> (ø)

...rc/components/Executions/ExecutionDetails/utils.ts
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71b307...48fde89. Read the comment docs.


Landing Page

We need to create the landing page for scuffle.tv
The first page where users will go.

In the beginning, we wont have any streams to feature so we should opt to create a landing page as more of an introduction to what this project is about, what we aim to do, why we are doing it, where they can find updates ect.
The typical approach would be to make a landing page which features the channels which are currently live however in our early stages we wont have anyone live so it would just make us look bad and look like a poor attempt of a twitch clone.
Open to ideas on this.


Import from Splitwise

Splitwise offers an "Export as spreadsheet" feature. It would be useful to be able to import this data into Spliit for continuity of groups that were created before.
Splitwise exports CSV files with the following headers:

Date
Description
Category
Cost
Currency
UserA
UserB
...

Values in the User columns are calculated as (Paid - Owe). For example, if UserA paid $100 for an item whose cost was split evenly, UserA's entry would be $100 - $50 = $50 and UserB's would be $0 - $50 = -$50.

Date
Description
Category
Cost
Currency
UserA
UserB

2024-01-01
Something
General
100.00
USD
50.00
-50.00

The final row is the total balance per user, which is the column sum for that user. There is no need to import this, but for the record, a positive value represents that the user "gets back" some amount, whereas a negative value represents that the user "owes" the amount.
This would require #6, at least the ability to split unevenly by dollar amount.
I'd suggest matching users by column name and error if a match isn't found; it's very easy to edit the CSV file if the name needs to be changed, no need to create new UI for it.

I have the beginnings of an implementation as a script here: https://github.com/ChristopherJohnston/spliit2/blob/import-splitwise/src/scripts/import.ts
This was created before the recent uneven split addition, and also assumes implementation of expenseDate and categories per my recent PRs....I'll update it accordingly once these are done.
I was able to match balances on a split wise group that has ~2800 lines in the export (granted this is a group of 2 participants where all of the expenses are equal split)
This script would require hosting your own instance of the app but could probably be used as part of a future "create group from csv" implementation

I love this! It shouldn’t be too hard to develop a MVP of an import feature (e.g. assuming that the user names match exactly). @ChristopherJohnston tell me if you’re interested to work on such a feature, otherwise I’ll take care of it 😃

@ChristopherJohnston tell me if you’re interested to work on such a feature, otherwise I’ll take care of it 😃

I'm not particularly skilled at the UI part, so the file upload part would probably slow me down somewhat!

The export is essentially a ledger so some of the information about how the expense was split is lost. It's possible to infer but not sure if this is always going to be correct.
A few hurdles I've seen so far:
Splitwise allows multiple payees for an expense which is shown as a positive number for each participant who made a payment and does not owe and a negative number for each participant who owes.
E.g
Participant A and B pay 75 each for an expense split equally between 3:
Total: 150
ParticipantA: 25
ParticipantB: 25
ParticipantC: -50
Expenses with costs that are Odd numbers (eg 1.55 paid by A, split between 2 participants) are sometimes split unevenly (A=0.78, B=-0.77), sometimes rounded up (A=0.78, B=-0.78), sometimes rounded down (A=0.77, B=-0.77)
Sometimes the expense amount is more than the total split. E.g £100 bill paid by A, split £90 of that evenly between 2 participants (A=45, B=-45)
I'm sure there are some others I haven't seen yet.

In cases like above where multiple payees have net positive contribution in a transaction we will need to either create multiple entries or we will require the support for multi-payer feature #14

Import script here: https://gist.github.com/ChristopherJohnston/a6e69bd8894f20ecfe127fa4149bd013
This is not going to be exact - rounding differences will accumulate. That said, I have a ~3000 row export tying out to within around £0.15

Many thanks for the script. Sadly I am using the Docker image and so as I understand it I can't run it (as the Docker image only contains the runtime bin -right?). Looking forward to this being implemented soon to finally be able to switch from Splitwise.

Many thanks for the script. Sadly I am using the Docker image and so as I understand it I can't run it (as the Docker image only contains the runtime bin -right?). Looking forward to this being implemented soon to finally be able to switch from Splitwise. 🎉

If you download the source code and point to the db used by the container then you should be able to run the script to achieve your goal

Thank you very much. That worked well! I just had to change my splitwise account to English, as "Payment" is otherwise "Zahlung", and remove all the empty lines in the csv file.

Given that this will add the import logic, would it also be possible to make it so one could import from Spliit's own JSON file?

Given that this will add the import logic, would it also be possible to make it so one could import from Spliit's own JSON file?

this should probably be tackled first. Splitwise import is a bit more tricky.

Given that this will add the import logic, would it also be possible to make it so one could import from Spliit's own JSON file?

Here's a script to do that https://gist.github.com/scimetfoo/4331b233091662d7d81f141291567dc1


[Question]  how to  debug tests running with testling with webstorm?

Hi, has anyone figured out a way to debug tests running with testling with webstorm?
I run these tests with "browserify test/index.js | testling"

Seems like more of a webstorm question than a testling question.


[Feature Request] Option to disable link suggestion to the current file

Not sure if I missed an existing option or ticket for this, but it would be so handy. Whenever I'm writing about a topic on its own page, the plugin keeps suggesting to link to the same page I'm already on which is completely pointless to my workflow, and is just an annoyance.

Hi, @kazerniel :)
I’ve been unsure about adding this option before, but I’ll consider it.


Drag n drop from related to playlist

Be able to drag a video from the related videos in the fatbar directly to the playlist in the right column.

We don't have related anymore.


picamera.exc.PiCameraError: Unable to determine default GPIO LED pin for RPi revision 3 and camera num 1

I think I have found a bug in the camera.py file in version 1.13.
I think I have the solution to the bug BUT you will need to confirm.
I have a Compute Module with a Pi3 with Dual Cameras.
When I try and address camera 1  ( myCamera = PiCamera(1) )  I get the error:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/picamera/camera.py", line 345, in init
}[(GPIO.RPI_REVISION, camera_num)]
KeyError: (3, 1)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "test2.py", line 4, in
camera = PiCamera(1)
File "/usr/lib/python3/dist-packages/picamera/camera.py", line 350, in init
GPIO.RPI_REVISION, camera_num))
picamera.exc.PiCameraError: Unable to determine default GPIO LED pin for RPi revision 3 and camera num 1
I CHANGED the following line in the file :
(0, 1): 30, # compute module (default for cam 1)
to
(3, 1): 30, # compute module (default for cam 1)
I could probably have added a new line of code for that but i was trying to work out what was goign on so only managaed a quick and dirty fix.
The Camera now correctly detects and was accessible in my code.

I got the same error with a compute module V3 with dual cameras. Your suggestion resolved my problem thanks.
When I analyze the RPI_REVISION it outputs the RPI3 model instead of compute module. The updates of raspbian and the firmware updates did not solve that, but this did.
Thank you!

Unfortunately I don't have a CM3 to play with, but it definitely looks like this needs updating (I can probably nick some code from GPIO Zero to do "proper" detection of the CM3).

I had the same error too! Compute Module 3 with 2 PiCameras (NoIR 2.1) attached, fortunately your solution worked for me!! Thanks

The docs at https://picamera.readthedocs.io/en/latest/api_camera.html#picamera do say

The led_pin parameter can be used to specify the GPIO pin which should be used to control the camera’s LED via the led attribute. If this is not specified, it should default to the correct value for your Pi platform. You should only need to specify this parameter if you are using a custom DeviceTree blob (this is only typical on the Compute Module platform).

You are using a custom dt-blob.bin (as the CM doesn't enable the cameras by default) and are on a Compute Module, therefore you should really be specifying led_pin to the constructor.
RPI.GPIO seems to be returning 3 for any unknown revision, partly as it is now supposedly a revision of the GPIO header (ie 26pin vs 40pin). The CM1 is special cased to return 0, but not the CM3 or CM3+.
Conversely the list is missing many of the more recent Pi variants, but on many of those the LED is controlled via an GPIO that isn't accessible via RPi.GPIO.

The same solution works for me on rpi4 compute module also. But unable to use DISP0 instead using DISP1 and both the camera on CAM1 and CAM0 are working fine. also need to connect both the jumper on J6 on the IO Board.

I'm also using a rpi4 CM (attached to a stereopi, if that matters), and this solution worked for me. For anyone curious, you can find camera.py on your pi board at "/lib/python3/dist-packages/picamera"


Fix Events definitions in the DTS

As we discussed on slack, here is a more relevant Events definition.
User will define custom Events following the Events interface and the App will both use the user Events defined interface and the DefaultEvents interface.
Side effect : Emit will not show keyof Events anymore in VS Code intelisense

@Swizz Side effect : Emit will not show keyof Events anymore in VS Code intelisense

What was that?

This feature :

@Swizz We want to have that, but only for our own Events that extend Hyperapp.Events. Any way we can have it?

I think we dont need it at the moment. I will read a bit more about that and make a new change


Skip when file is a font/exe/zip

Type

[x] General question or discussion
[ ] Propose a brand new feature
[x] Request modification of existing behavior or design

What is the problem that your feature request solves
When link is a font, it trys to make a pdf or screenshot, which didnt make sense.
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Skipping the script when filetype is a font or others which didnt make sense, like exe or zip
What hacks or alternative solutions have you tried to solve the problem?
actually nothing.
EDIT: I notice that the problem is not happend with pdf files,
so I may can find the correct line to expand them.
How badly do you want this new feature?

[ ] It's an urgent deal-breaker, I can't live without it
[ ] It's important to add it in the near-mid term future
[x] It would be nice to have eventually

[x] I'm willing to contribute dev time / money to fix this issue
[x] I like ArchiveBox so far / would recommend it to a friend
[ ] I've had a lot of difficulty getting ArchiveBox set up

You're looking for the URL_BLACKLIST config option.
Try setting URL_BLACKLIST= .+\.(exe|woff|otf|ttf)$


Spanner Documentation not current: read and executeSql

Submitting for @mkmg
The documentation for the Database module still lists the methods read and executeSql, but these were recently removed.
cc/ @lukesneeringer

To clarify, the build is broken, the docs session works just fine, but it never runs because the Spanner system tests have been broken for weeks.

Hmm, I'm not sure what the breakage is.  Emulating CircleCI locally:
$ git fetch upstream && git merge upstream/master
Already up-to-date.
$ cd spanner
$ CIRCLECI=true nox -e "system_tests(python_version='3.6')"
nox > Running session system_tests(python_version='3.6')
nox > virtualenv .../google-cloud-python/spanner/.nox/sys-3-6 -p python3.6
nox > chdir .../google-cloud-python/spanner
nox > pip install --upgrade mock pytest ../core/
nox > pip install --upgrade ../test_utils/
nox > pip install --upgrade .
nox > py.test --quiet tests/system
......................................
38 passed in 120.88 seconds
nox > Session system_tests(python_version='3.6') successful. :)

@tseaver Run it with the same account and project?

@dhermes Yes, I was running with those creds.

@dhermes do we have docs for building / pushing manually?  I just tried with:
$ CIRCLE_BRANCH=master PATH=".nox/docs/bin:$PATH" test_utils/scripts/update_docs.sh

and had it fail:
GH_OWNER='GoogleCloudPlatform'
GH_PROJECT_NAME='google-cloud-python'

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd
 dirname "${BASH_SOURCE[0]}"

# Function to build the docs.
function build_docs {
    rm -rf docs/_build/
    sphinx-build -W -b html -d docs/_build/doctrees docs/ docs/_build/html/
    return $?
}

# Only update docs if we are on CircleCI.
if [[ "${CIRCLE_BRANCH}" == "master" ]] && [[ -z "${CIRCLE_PR_NUMBER}" ]]; then
    echo "Building new docs on a merged commit."
elif [[ -n "${CIRCLE_TAG}" ]]; then
    echo "Building new docs on a tag (but will not deploy)."
    build_docs
    exit $?
else
    echo "Not on master nor a release tag."
    echo "Building new docs for testing purposes, but not deploying."
    build_docs
    exit $?
fi
Building new docs on a merged commit.

# Adding GitHub pages branch. `git submodule add` checks it
# out at HEAD.
GH_PAGES_DIR='ghpages'
git submodule add -q -b gh-pages \
    "git@github.com:${GH_OWNER}/${GH_PROJECT_NAME}" ${GH_PAGES_DIR}

# Determine if we are building a new tag or are building docs
# for master. Then build new docs in docs/_build from master.
if [[ -n "${CIRCLE_TAG}" ]]; then
    # Sphinx will use the package version by default.
    build_docs
else
    SPHINX_RELEASE=$(git log -1 --pretty=%h) build_docs
fi
git log -1 --pretty=%h
Running Sphinx v1.6.3
making output directory...
loading pickled environment... not yet created
loading intersphinx inventory from https://google-auth.readthedocs.io/en/stable/objects.inv...
loading intersphinx inventory from https://gax-python.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from http://www.grpc.io/grpc/python/objects.inv...
intersphinx inventory has moved: http://www.grpc.io/grpc/python/objects.inv -> https://grpc.io/grpc/python/objects.inv
loading intersphinx inventory from http://docs.python-requests.org/en/master/objects.inv...
loading intersphinx inventory from http://pandas.pydata.org/pandas-docs/stable/objects.inv...
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 117 source files that are out of date
updating environment: 117 added, 0 changed, 0 removed
reading sources... [100%] vision/index
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] vision/index
generating indices... genindex py-modindex
highlighting module code... [ 34%] google.cloud.gapic.language.v1.language_servihighlighting module code... [ 36%] google.cloud.proto.language.v1.language_servihighlighting module code... [ 37%] google.cloud.gapic.language.v1beta2.language_highlighting module code... [ 39%] google.cloud.proto.language.v1beta2.language_highlighting module code... [ 44%] google.cloud.logging.handlers.container_enginhighlighting module code... [ 50%] google.cloud.logging.handlers.transports.backhighlighting module code... [ 63%] google.cloud.gapic.pubsub.v1.subscriber_clienhighlighting module code... [ 65%] google.cloud.pubsub_v1.subscriber.policy.threhighlighting module code... [ 95%] google.cloud.gapic.vision.v1.image_annotator_highlighting module code... [ 98%] google.cloud.proto.vision.v1.image_annotator_highlighting module code... [ 99%] google.cloud.proto.vision.v1.text_annotation_highlighting module code... [100%] google.cloud.proto.vision.v1.web_detection_pb2
writing additional pages... search
copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

# Get the current version.
# This is only likely to work from within nox, because the google-cloud
# package must be installed.
CURRENT_VERSION=$(python ${DIR}/get_version.py)
python ${DIR}/get_version.py
Traceback (most recent call last):
  File "/home/tseaver/projects/agendaless/Google/src/gcp-docs/test_utils/scripts/get_version.py", line 21, in <module>
    print(get_distribution('google-cloud').version)
  File "/home/tseaver/projects/agendaless/Google/src/gcp-docs/.nox/docs/lib/python3.6/site-packages/pkg_resources/__init__.py", line 562, in get_distribution
    dist = get_provider(dist)
  File "/home/tseaver/projects/agendaless/Google/src/gcp-docs/.nox/docs/lib/python3.6/site-packages/pkg_resources/__init__.py", line 436, in get_provider
    return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]
  File "/home/tseaver/projects/agendaless/Google/src/gcp-docs/.nox/docs/lib/python3.6/site-packages/pkg_resources/__init__.py", line 981, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/home/tseaver/projects/agendaless/Google/src/gcp-docs/.nox/docs/lib/python3.6/site-packages/pkg_resources/__init__.py", line 867, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'google-cloud' distribution was not found and is required by the application

@tseaver I just do some like this:
$ git fetch official  # you call it `upstream` I believe
$ git branch gh-pages-pr-XYZ official/gh-pages
$ nox -s docs  # no special env. vars
$ mv docs/_build/html somewhere/out/of/repo
$ git checkout gh-pages-pr-XYZ
$ rm -fr latest/
$ mv somewhere/out/of/repo latest
$ git add latest/
$ git commit -m '...'
$ git push official gh-pages-pr-XYZ

Then I make a PR onto gh-pages and ask for a token LGTM.
Note that I avoid pushing to my own remote because I don't have any of the gh-pages history there, which would make the push take much longer / use much more data.


[magnum] Move static debug libraries to root lib/ folder

:wave: This PR fixes an issue with static debug libraries not being moved to the root lib/ folder correctly. This is inconsistent with static release libraries and breaks MSBuild integration.
I also went ahead and replaced the deprecated _cmake() functions.

Which triplets are supported/not supported? Have you updated the CI baseline?
No changes to the current port version

Does your PR follow the maintainer guide?

Yes

Thanks for the fix!


Support for multiple containers in a Windows Container Group

Hi,
Is there a plan to support multiple containers in a Windows Container Group? Currently getting this failed deployment Error when trying it.
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.","details":[{"code":"BadRequest","message":"{\r\n  "error": {\r\n    "code": "MultipleWindowsContainersNotSupported",\r\n    "message": "Multiple containers are defined in the Windows container group 'abc'. A Windows container group can only have one container."\r\n  }\r\n}"}]}
Thanks
Nathan

Hi Nathan,
We currently we don't support multiple windows containers in a group but this will change by GA.
Thanks,
Ria

ACI is in GA and I just ran into this issue using ACI... Was this enhancement released?

Also run into this problem, doesn't appear this "enhancement" was completed prior to GA.

it's absurd, the primary advantage of "Containers" is to scale out. Let alone in-built feature, if ARM template itself doesn't allow ? :-/


Rename security-release-process.md to security-release-process.md

👍

This looks like a no-op PR. If there is an issue which you meant to correct, please update your PR and re-open.


[BUG]

Describe the bug (🐛 if you encounter this issue)
Longhorn overload api-server.
To Reproduce
Have many volumes
In our case:

1254 Healthy
424 Detached
0 to others

set etcd in read-only mode one or two minutes.
Expected behavior
Lonhorn stop trying to do api-server call or slow down api call
Environment

Longhorn version: 1.5.1
Installation method : Kubectl:
Kubernetes distro : On Premise 1.25

Number of management node in the cluster: 5
Number of worker node in the cluster: 300

Node config

OS type and version: Ubuntu 22.04
Kernel version: 5.15.0-58-generic
CPU per node: 16
Memory per node: 64
Disk type(e.g. SSD/NVMe/HDD): ssd
Network bandwidth between the nodes: 10G

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Openstack
Number of Longhorn volumes in the cluster: 1678
Impacted Longhorn resources: many

Additional context
On our cluster we have api-server issue (etcd in read-only mode for 2 minutes).
Starting here, we see many (a very LOTS) of request from longhorn trying to make api-server call. Api-server overload. So even when etcd run in read-write mode, api-server respond slowly.
And it was a storm.
Many applicative pod trying to attach volume crash, so they try and try again, overloading poor slow longhorn, and longhorn overload more and more api-server, and the infernal loop until we finaly decide , for a moment only, to change flavor of our master node to BIG FLAFOR (64 vcpu / 512Go RAM).
With monster node master, api-server begin to respond faster, a longorn begin to success api-call.
Once all is return to normal state, we can change to smaller flavor for master node.
Is there a way to prevent longhorn to slow down api request call ?

On our cluster we have api-server issue (etcd in read-only mode for 2 minutes).
Starting here, we see many (a very LOTS) of request from longhorn trying to make api-server call. Api-server overload. So even when etcd run in read-write mode, api-server respond slowly.

It appears that your cluster encountered performance issues following a brief etcd incident, primarily due to a surge in API requests from Longhorn, which led to an overload on the API server.

Many applicative pod trying to attach volume crash, so they try and try again,

Given the scale of your cluster and the number of attached volumes, this process reflects significant activity while trying to update the status and salvage the volumes.

Is there a way to prevent longhorn to slow down api request call ?

My initial impression is that Longhorn's behavior is expected, as most API calls are likely related to CR movements while attempting to salvage the volumes.
Maybe https://kubernetes.io/docs/concepts/cluster-administration/flow-control/ might help, I am not sure.
Alternatively, if you are open to sharing the observation regarding the API server calls from Longhorn and the logs or support bundle around the time of the etcd incident, we can also do more investigation to see if there are any potential improvements.

Thx for the answer
My initial impression is that Longhorn's behavior is expected, as most API calls are likely related to CR movements while attempting to salvage the volumes.
Absolutely true. (we have more than 23000 pods)
Alternatively, if you are open to sharing the observation regarding the API server calls from Longhorn and the logs or support bundle around the time of the etcd incident, we can also do more investigation to see if there are any potential improvements.
Sure, next time we encounter same situation (hope not ...). I will look for extracts of logs.
And i will check for flow-control


Evaluations without human blind evaluation

Hi, have you evaluated the model using only GPT3.5/Claude without HBR? This is important for the research community to compare against your work.

Sure, you can refer to Table K10 and Table K11 in the Appendix of our paper

Thank you very much for your reply.
Best regards
On Tue, 3 Sept 2024, 17:46 EnxinSong, @.***> wrote:

Sure, you can refer to Table K10 and Table K11 in the Appendix of our paper
—
Reply to this email directly, view it on GitHub
https://github.com/rese1f/MovieChat/issues/78#issuecomment-2326719292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL3UZJAO3MQBGOPP7BE7ODDZUXDT7AVCNFSM6AAAAABNRVNPWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRWG4YTSMRZGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi can you provide the moviechat+ model using  GPT3.5/Claude without HBR ? I didn't find the results in moviechat+ paper.


Migrations: Multiple providers

In EF7 we're going all in with provider specific migrations, so if I target SQL Server and PostreSql then I need to gen two sets of migrations. Our migrations commands aren't setup to deal with two (or more) sets of migrations though.
We probably need a first class concept of a provider (also needed for reverse engineer) and then we can have migrations identify which provider they are for (possibly in the attribute we use to identity which context they are for).

We should atleast implement enough that we don't have breaking changes later

Parts of this depend on #1904

Notes from today's design meeting:

We can have one model differ that diffs "all" annotations

Annotations can be filtered by provider prefix for all participating providers

Some core/relational metadata should be overridable per provider (e.g. StoreType & DefaultExpression)
Some core/relational metadata doesn't need to be overridable (e.g. DefaultValue)

I chatted with @rowanmiller today, and we decided to do the following for RTM.
We'll scaffold migrations that are specific to the active provider. For example, given the following model...
modelBuilder.Entity<Person>()
    .SqlServerTable("People")
    .SqliteTable("people");

...the following migration would be generated if SQL Server was the active provider at design-time.
migrationBuilder.CreateTable(
    name: "People"
    /* ... */);

However, to unblock people from hand-crafting migrations that can run against multiple providers, we'll implement #2258. With that, you could write a migration that looks something like this:
migrationBuilder.CreateTable(
    name: activeProvider == "EntityFramework.SqlServer"
        ? "People"
        : "people"
    /* ... */);

...and once we have everything working we can look at scaffolding something like the conditional code in the final snippet when there are multiple providers registered... but that will presumably be post 7.0.0.
Also worth noting that by having the current provider accessible to the migration code we are already better than EF6, so we easily clear the "EF6 parity" bar.

The investigation work here is done; I have enough context to avoid breaking changes in the future. We can move this issue to the backlog now.

We already have the flag to allow you to do different things based on the active provider. We think this is enough and we don't need to scaffold for multiple providers.


WIP? — Update the library

Added resize: none to the .tweet div to not be able to change the size of the input on the smartphone.
Async JS code
Autofocus to the Generate button
Changed textContent to 274 because Twitter add a final space at the end of the tweet

I can add some text to resolve the #9 issue like "What is The Library of Babel?" and link to this GitHub repo.

that's great, thx a lot :smiley:
if you want to work on #9, yes go ahead :+1:

@rocambille I see your repository on DEV for the Hacktoberfest event ☕👏🏼

@rocambille I see your repository on DEV for the Hacktoberfest event ☕👏🏼
I didn't know the Library of Babel 👀

@thomasbnt worth the read, but you can first check the hints I just added in the issue :wink:


Error callback with IE9

When i upload a file with chrome or ff , ie 10 11 everything is fine but not with ie9
my problem : i have an endpoint that send an error (in order to reproduce the bug) like this :
@RequestMapping(method = RequestMethod.POST)
    public ResponseEntity<String> handleFileUpload(@RequestParam("name") String name, @RequestParam("file") MultipartFile file) {
        return new ResponseEntity<>("Error when uploading file", HttpStatus.BAD_REQUEST);

and in js i have this :
file.upload({
      url: '/api/upload',
      headers: {
        Authorization: 'Bearer ' + this.get('session.content.access_token'),
        Accept: 'text/plain'
      }
    }).then((response) => {
      this.sendAction('uploadSuccess', response.body, this.get('model'));
    }, (errors) => {
      this.sendAction('uploadError', errors);
    });

but errors parameter is not as i expected :
in chrome i have this :

And in IE 9 i have this :

Oh dear. I think this might require setting up sauce to test against IE9.


Pop-up Menu CSS Logic Errors and Share menu CSS Logic Errors

Incorrect Color Design on a pop-up menu when hovering over power-up tag

Recreation
Take a rem that you can view in unzoomed view, tag it with Disable Descendant Cards, and hover over the identifier. ex.

Incorrect Color Design viewing shared article
Recreation
Just share an article, and let Remnote take you to the self-share-view page.

I wrote this on a whim because I noticed it while studying. Please let me know if you would like more info. I plan to tackle this issue myself soon.

I guess that got closed in the new PR?

No mot yet. These were not fixed yet.


Optimize Mass Processors

General

[ ] Audit all places LineTraceSingleByChannel and related methods are used to see if we need result or just bool; if just bool, switch to LineTraceTestByChannel and related methods
[ ] Reduce number of actors in DA_MassSoldier_Team1 and DA_MassSoldier_Team2?
[ ] Consider optimizing Mass processors in multiplayer by taking short cuts if no human players nearby, i.e. simulation LOD will be calculated based on multiple observers instead of just one
[ ] https://www.intel.com/content/www/us/en/develop/documentation/vtune-cookbook/top/tuning-recipes/frequent-dram-accesses.html to find frequent RAM hits instead of using CPU cache
[ ] If memory usage becomes a concern, auditing fragments and change it so we add and remove fragments that won’t be on entities for a long time, e.g. FTargetEntityFragment could be added when we detect target and removed afterwards; then do we even need a tag to track having a target, or can we just rely on presence of the fragment?

Entity Spawning

[ ] Spawning of lots of projectiles each tick is slow. Might be faster if we batch all spawning of projectiles in each tick, e.g. in FireProjectileTask add to a queue or array and then have some code that runs at end of tick that spawns them in single call to SpawnEntity for each EntityTemplateID. Maybe a subsystem. Make it generic so can be reused for effect entities too.

MassStateTreeProcessor

[ ] Fix MassStateTreeProcessor spikes every n seconds; perhaps variable firing rate by AI will fix?
[ ] Audit places where we use entity view in state tree tasks; switch to using pattern: MassContext.GetEntitySubsystemExecutionContext().DoesArchetypeHaveTag<FMassNeedsNavMeshMoveTag>();

UMassCoverQueryProcessor

[ ] Always fail cover for off LOD?
[ ] Switch to ParallelForEachEntityChunk. UEnvQueryManager is not thread safe, but perhaps can create an instance for each parallel call. Note that variable tick with ParallelForEachEntityChunk is broken in 5.0.3 and 5.1. Perhaps we should switch to ParallelFor.

UMassScreensizeLODCollectorProcessor

[ ] Once we're on UE 5.2 and ParallelForEachEntityChunk is available and doesn't crash for queries with chunk filters, we should switch this processor to use ParallelForEachEntityChunk. If that's not feasible, we can switch to ParallelFor.

UMassNavMeshMoveProcessor

[ ] Reduce number of RAM reads required during processor execution possibly by caching data in fragments
[ ] What if Squad was a single Mass Entity with array of all data needed e.g. object with transform for each soldier, move target etc.  Then all processors would need to be updated to handle squad correctly. Alternatively, can we make all squad entities packed in order within single chunk so that we don't have to hit RAM?
[ ] Instead of checking if entity is Squad leader or squad member via EntityView RAM access, set Mass tags

UMassSoundPerceptionSubsystem

[ ] UMassSoundPerceptionSubsystem: grid cell size may not be ideal
[ ] FSoundPerceptionHashGrid2D: 2 levels of hierarchy, 4 ratio between levels may not be ideal

UMassAudioPerceptionProcessor

[ ] Make variable tick?

[ ] We'd just need to also adjust this value here so that sounds stay alive more than just 2 frames: https://github.com/LeroyTechnologies-Org/ProjectM-Private-Staging/blob/1b181e4b864e00b869de58c83f5bc3d382189c96/Source/ProjectM/Public/MassSoundPerceptionSubsystem.h#L43
[ ] Add logic so that a soldier never "processes" the same sound more than once, maybe by keeping the LastProcessedSoundID in a fragment

[ ] Is there a low level line trace function that doesn’t require locking which may be faster when doing parallel line traces?

UMassNavigationSubsystem

[ ] UMassNavigationSubsystem: has grid cell size of 2.5m, might be too small to fit tank agent radius thus all tanks go into spill list

UMassEnemyTargetFinderProcessor

[x] Instead of using Masked Occlusion Culling algorithm, consider chunking 90 deg FOV into buckets e.g. 10 degrees where we bucket every friendly into array where index is degree bucket and value is closest friendly distance. If very close, bucket them in multiple buckets. Then when we consider each enemy, we check if there is a closer friendly in that bucket and if so, skip.
[ ] Can we filter PostSphereTraceEntityQuery somehow to only include entities that had sphere trace, e.g. via a Mass tag?
[ ] UMassEnemyTargetFinderProcessor: Would it be faster to measure distance to each unhittable entity and ignore those that are farther than found enemy target? Add a flag and measure
[ ] UMassEnemyTargetFinderProcessor: Would it be faster to have two separate THierarchicalHashGrid2D for each team, and only scan those for enemies? That way teammates are already ignored. Would still have to scan same team's grid for obstacles in the way though.
[ ] Instead of FCollisionQueryParams::DefaultQueryParam, use FCollisionQueryParams with bTraceComplex=false. See how we do it in DoLineTraces() in MassAudioPerceptionProcessor.cpp.

UInvalidTargetFinderProcessor

[ ] UInvalidTargetFinderProcessor: Currently when entity and target entity are offset a lot by x and y coordinates, we search a large box unnecessarily. Instead we could break down search into lots of small boxes covering the line between entity and target entity. Would need to measure if this is actually faster though, as running many small queries might not be a win.
[ ] UInvalidTargetFinderProcessor: Use ParallelForEach. Need a queue for stuff done in ProcessEntity().
[ ] UInvalidTargetFinderProcessor: Break search into phases like UMassEnemyTargetFinderProcessor if needed.

UMassProjectileDamageProcessor

[ ] Could we avoid having to use FMassEntityView which is slow since it requires RAM access? We could store more data in the 2D hash grid. Data needed: Capsule (collision), FTeamMemberFragment (for adding sound perception), FTransformFragment (for splash damage), FMassHealthFragment (for dealing damage), FProjectileDamagableFragment (for deciding if can deal damage), FMassPlayerControllableCharacterTag (for handling player death).

UMassTargetGridProcessor

[ ] Parallelize some of the work, e.g. finding which entities need to be updated
[ ] Variable tick?

Optimizations attempted that regressed performance

MassEnemyTargetFinderProcessor: Use ParallelFor instead of ParallelForEachEntityChunk. This makes things worse because there are a lot of chunks which means this creates tons of small ParallelFor calls with extra overhead for each.
MassEnemyTargetFinderProcessor: Use ParallelFor within ParallelForEachEntityChunk. See perf benefit of reverting this here: https://github.com/LeroyTechnologies/ProjectM/commit/d7ec42d6cfc3b6a60a152b24782dacc453fb964c
MassEnemyTargetFinderProcessor: In AreEntitiesBlockingTarget use ParallelFor. Slower with ParallelFor because in regular for we could short circuit the loop.

ParallelFor

I.Max	I.Avg	I.Med	I.Min
29.77	3.97	2.78	0.41

regular for

I.Max	I.Avg	I.Med	I.Min
8.53	1.32	1.18	0.07

Hey! Any chance to access the updated repo? I like the idea of the project and I deal with MassEntity and would be interested in contributing as well

@aelmod can you message me on Discord? My username is Leroy#9486.


Readme

Whilst the icalendar specification may be used to describe just about any activity or event, typically there are some use-cases that are more widely used than others.
Such use-cases may include birthdays and other anniversary-style observances, scheduling activities such as timetables, and historical activities including recording of meeting minutes.
ical4j-templates offers an opinionated view of how such popular activities may be structured, providing a simpler and consistent approach to event management.

Templates should be as specific as possible, and generally avoid free text input (i.e. provide consistent formatting of input data).
Domain-specific templates provide easily understandable structures without concern for underlying data formats.
e.g. Music domain:

Artist -> VCARD
Song, Album, Playlist -> VJOURNAL
Concerts -> VEVENT
Venues -> LOCATION
Tickets -> VAVAILABILITY


As a DevOps, I would like to change the email address of cert-manager inside the GKE Cluster

Change the email email address of cert-manager inside the GKE Cluster. You can find the content inside kubernetes/system/cert-manager/issuer.yml

Maybe create a<EMAIL_ADDRESS>

Great idea, we could have<EMAIL_ADDRESS>for anything related internally and<EMAIL_ADDRESS>for any potential issues. Regarding production, will we have access to the DNS inspection.canada.ca?

Regarding production, will we have access to the DNS inspection.canada.ca?

Let us cross that bridge once we get there.


DelegateHandler instead of Retry Interface

This commit refactors the HTTP retry logic for the kernel and its services by using DelegatingHandler subclasses instead of custom interfaces. It also adds a new HttpRetryConfig class that can be used to configure the default retry parameters for the kernel. The commit uses the Polly library and its extensions to implement the retry policies, and provides some examples of different retry handlers. The commit also updates the tests, the documentation, and the OpenAI clients to reflect these changes.

Found a bug, DelegatingHandler cannot be shared, so changing to implement a Factory so each HTTPClient can create its own.


Allow memoryview of .NET arrays

Would be nice to allow use of memoryview on .NET arrays, for example:
memoryview(System.Array[int]([1,2,3]))

This was supported with buffer in IronPython 2.
@BCSharp if you have any thoughts about this.

I agree it would be nice for interop, just am not sure how it could be practically implemented. memoryview (and Python Buffer in general) works under an assumption that the size/structure of the underlying buffer does not change until the memoryview object wrapping it is released.
Also, it immediately prompts for support of other cases, like ArraySegment or String (the latter RO only). So maybe instead supporting .NET arrays directly, we could support System.Memory? It is immutable in size, supports strings, arrays/array segments of various types, and it is easy to obtain a Memory from an array. The limitation is of course lack of support for multidimensional arrays. I don't know how to work around it.

This was supported with buffer in IronPython 2.

How did it work in IronPython 2?
IronPython 2.7.10 (<IP_ADDRESS>0)
[.NETFramework,Version=v4.5 on .NET Framework 4.8.4180.0 (64-bit)]
Type "help", "copyright", "credits" or "license" for more information.
>>> import System
>>> memoryview(System.Array[int]([1,2,3]))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: expected IBufferProtocol, got Array[int]

Isn't the size/structure of a .NET array immutable? I would be fine with using System.Memory if it solves the issue.
While String would be interesting to support we would need to be careful not to break things in the future. For example, if we ever come up with a flexible string representation (https://github.com/IronLanguages/ironpython3/issues/252) would memoryview("abc") still be valid?
In IronPython 2 it doesn't work with memoryview but it does with buffer (which is essentially the predecessor of memoryview):
import System
b = buffer(System.Array[int]([1,2,3]))
assert b[1] == 2

Isn't the size/structure of a .NET array immutable?

I was thinking about a scenario when a memoryview is constructed around an instance of a .NET array, and then that array is shortened with System.Array.Resize(...). Technically an new array is created and the content copied over, but practically, all existing references get redirected to the new array so it appears as if the array itself were shortened. This doesn't fit the memoryview usage patterns.
If a System.Memory object is created from the array, it will still represent the original array before resize, so it fits perfectly wit the memoryview. We could provide a convenience constructor accepting an array that would simply call AsMemory() under the hood, but again, it makes an exception in the pattern, because the object wrapped by the memoryview would not be the one given to the constructor. I think it would be better for the user to decide if this is what they intend and if so, let them call AsMemory() explicitly.

If we stick with Memory support, then support for strings is implied, as anybody can create a ReadOnlyMemory over a .NET string and pass it to a memoryview constructor. With a flexible string representation, we can implement AsMemory() on those objects any way we see fit. But the question with strings is, what typecode to use for System.Char? H, I, C?... This is BTW also a valid question for arrays of chars.

I'm not quite sure Array.Resize is a valid argument. It doesn't replace all existing references, it only replaces the single reference:
var arr = new int[] {1,2,3};
var arr2 = arr;
Array.Resize(ref arr, 0);
Debug.Assert(arr2.Length == 3);

With IronPython it's even clearer, you would have to explicitly reassign to the variable:
arr = System.Array[int]([1,2,3])
x = System.Array.Resize(arr, 0) # here x is the resized array, arr is unchanged
assert x.Length == 0
assert arr.Length == 3
arr = x

If you're curious, to use it by reference:
a = System.Array[int]([1,2,3])
arr = clr.Reference[System.Array[int]](a)
System.Array.Resize(arr, 0)
assert arr.Value.Length == 0
assert a.Length == 3

For System.Char:

H: I would expect indexing (e.g. mv[0]) to return an integer value (which may be ok)
I: this would reflect the size of the char which is probably an issue
C: this one also seems like a valid option, however, would indexing return a single character string or a System.Char? It seems like the single character string would be more Pythonic?

Personally I would have no issue with only supporting the primitive value types and excluding char. Support for it could be added in the future if there is a demand for it.

It doesn't replace all existing references, it only replaces the single reference:

My mistake. I expected this behaviour but when testing to confirm it I tested it wrong. Thanks for the elaborate examples (esp. the last one; I didn't know how call a method with a ref argument). I have no further objections against wrapping over an array.

C seems to be most Pythonic, and indeed, I'd expect it to return a single character string. But just because it is most Pythonic, I have my reservations: it is not unthinkable that CPython may at some point introduce C to represent either wchar_t (wchich may be 16 or 32 bit) or a single Python character (rune in .NET speak), which is always 32 bit wide but accepts only the Unicode range, or maybe char32_t... System.Char is always 16 bit so making such assumption may not be forward-compatible. So I would stay away from it.
Both H and I would work but carry an assumption that strings are represented as UTF-16 or UTF-32. Since the flexible string representation is still not implemented, I would not make such assumption at this stage. So this rules out wrapping memoryview over strings. Also Python disallows wrapping memoryview over str.
For simple char[] arrays, I think a numeric H would be OK. But I am also OK with not supporting it yet.

For simple char[] arrays, I think a numeric H would be OK. But I am also OK with not supporting it yet.

Another option might be to use u (which you just removed). It's use in array is basically the same thing as a char array and it returns single character strings on indexing. It's deprecated in CPython so it's unlikely to make a comeback...

Another option might be to use u

This actually sounds like a good idea. I too think it is unlikely to come back in CPython.


push sync integration testing

Requirements for syncing integration testing:

generate random chunk data
upload the data to bee http api, register the content addressed hash returned by the api
iterate over all node addresses with DistanceCmp function, and for each chunk that is being uploaded, check which node address is closest to a given chunk address, i.e. which node should store that chunk
after a certain amount of time given to the nodes to sync, check for each chunk, that the closest node in the cluster has the chunk using the chunk debug api. if this fails the operation should be retried for resilience, until a certain timeout is reached
tests should be done on a cluster of minimum 3 nodes
should be tested ideally on larger clusters of 50 or 100 nodes
test should not test that chunk exists only on closer node, since intermediate node caching might occur, so for now, at least - this is not needed
multiple chunks should be uploaded on each run, not one chunk per run
seeds for random number generator that creates the data for the random chunk should be determined from time.Now().UnixNano() and should be logged in order to reproduce scenario in case of faliure

test should not test that chunk exists only on closer node, since intermediate node caching might occur, so for now, at least - this is not needed

Why is this the case? I never heard about caching on push-sync and also doesn't sound to me as something desired.

This is done: https://github.com/ethersphere/bee/runs/666827823?check_suite_focus=true


Image backbone

how did you attach swin-T on image backbone?

I want to do the same, do you know the solution?


New cop to suggest replacing case/when with hash lookup

When case/when represents a simple 1:1 mapping, suggest to replace it with a hash lookup.
# bad
case country
when "europe"
  "http://eu.example.com"
when "america"
  "http://us.example.com"
end

# good
SITES = {
  "europe"  => "http://eu.example.com",
  "america" => "http://us.example.com"
}
SITES[country]

I'm propose to name it Style/CaseHashMapping (is there a better name?). Maybe it would be wise to add a Min config option, specifying for how many branches should be to consider an offense.
@bbatsov Interested in your thoughts on this.

I love the idea! As for the name -> something like HashLikeCase or StaticMappingViaCase sound reasonably good to me, although not great. Naming is hard! :laughing:

Cool, will implement it then 😄

Should this be in rubocop-performance? Or is there another goal here?
Will that be limited to string values?

Keys can be strings and symbols, values can be any [recursive]_basic_literal.
Yes, it will be faster, but the main goal is to make the code easier. So I believe this should go to the Style department here.

Hm. Intuitively, this rule seems to belong to Performance department. I think Style can provide the opposite option, but it doesn't seem to be the case.
Also, I think that conversion to Hash constant is limited only when Hash values have the same type.

The correction can be without variable:
{
  "europe"  => "http://eu.example.com",
  "america" => "http://us.example.com"
}[country]

The inline version that @tejasbubane suggested would be the easiest to implement with auto-correct. I think extracting a constant to the correct location within the file will prove to be tricky. However, I do think using a hash would be a better solution.
I also agree with others that this sounds like a good candidate for performance rather than style. Do we have any metrics to back this up?

The correction can be without variable:
{
  "europe"  => "http://eu.example.com",
  "america" => "http://us.example.com"
}[country]

Building a hash is expensive, this is a bad idea

Benchmark
# frozen_string_literal: true

require 'bundler/inline'

gemfile(true) do
  gem 'benchmark-ips'
end

SITES = {
  "europe"  => "http://eu.example.com",
  "america" => "http://us.example.com",
  "australia" => "http://au.example.com"
}

def case_when(country)
  case country
  when "europe"
    "http://eu.example.com"
  when "america"
    "http://us.example.com"
  when "australia"
    "http://au.example.com"
  end
end

def constant_hash(country)
  SITES[country]
end

def inline_hash(country)
  {
    "europe"  => "http://eu.example.com",
    "america" => "http://us.example.com",
    "australia" => "http://au.example.com"
  }[country]
end

Benchmark.ips do |x|
  x.report('case-when')     { case_when(SITES.keys.sample) }
  x.report('constant hash') { constant_hash(SITES.keys.sample) }
  x.report('inline hash')   { inline_hash(SITES.keys.sample) }
  x.compare!
end

Results
Comparison:
       constant hash:  4367232.1 i/s
           case-when:  4263872.0 i/s - same-ish: difference falls within error
         inline hash:  3369430.3 i/s - 1.30x  (± 0.00) slower

Just FYI: As @fatkodima's benchmark suggests, MRI applies the similar optimization internally.  For every trivial case/when statement, the interpreter builds an internal hash from literal keys to bytecode addresses at the compilation, and lookups the hash and just jumps during execution.  So, I think this is just a matter of coding styles.

But why is a hash considered better style than a case? I personally find the case style much more readable, but what am I missing?

Well, there's always subjectivity but if something is essentially a dictionary-structure it's usually a good idea to represent it as such (meaning a hash in Ruby). For me this reduces the cognitive overhead.

That's a little bit tautilogical, but it seems you aren't alone in feeling that way :-) luckily I can always turn it off.


Replace linux neko with standalone version (-rpath)

See http://community.openfl.org/t/stand-alone-neko-executables-with-neko/770/
Used https://github.com/HaxeFoundation/neko/pull/57

Thanks! What version of Linux do you use to build it?

I built it on my openSUSE 13.1, with gcc 4.8.1 if that's what you are asking.
ldd templates/neko/bin/neko-linux
linux-gate.so.1 (0xf77f3000)
libneko.so => not found
libpthread.so.0 => /lib/libpthread.so.0 (0xf7770000)
libc.so.6 => /lib/libc.so.6 (0xf75c0000)
/lib/ld-linux.so.2 (0xf77d0000)

(disregard the not found I have a 64 bits neko install, works if you put the 32 bits libneko.so next to it)
ldd templates/neko/bin/neko-linux64
linux-vdso.so.1 (0x00007fff2c960000)
libneko.so => /usr/lib/libneko.so (0x00007fdccca80000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fdccc860000)
libc.so.6 => /lib64/libc.so.6 (0x00007fdccc4b0000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007fdccc2a8000)
libgc.so.1 => /usr/lib64/libgc.so.1 (0x00007fdccbf48000)
libm.so.6 => /lib64/libm.so.6 (0x00007fdccbc40000)
/lib64/ld-linux-x86-64.so.2 (0x00007fdcccca0000)


Move BIP32 to the crypto package

Merge this PR as it's mainly a code refactoring with no breaking changes.


Can't build for Windows from Darwin with Go 1.16

My project builds and runs on Darwin using Go 1.16. But when I use fyne-cross to build a Windows binary, several dependency libraries fail to compile because—it appears—the Go version in the Docker containers are older.

The latest release does have Go 1.16 inside the containers. Are you sure that you have the latest release installed and the latest images pulled?
You can install the latest fyne-cross using go install github.com/fyne-io/fyne-cross@latest and pulling the latest images using fyne-cross windows —pull.

@unquabain did you had a chance to test the steps suggested by @Jacalz ?

@unquabain Can you still reproduce this using the steps mentioned above?

Many updates have been applied since this ticket, closing


Switch to a more visible color for HTML details

As a colorblind person, I cannot read the <details> content. This PR fixes
this :)

Thanks Will!


Error. Command line: winget uninstall --name "Windows Camera"

2023-09-04 05:23:05.030 -07:00 [INF] Uninstall: 3D Viewer
2023-09-04 05:23:05.098 -07:00 [INF] Skipped uninstall of 3D Viewer since not installed
2023-09-04 05:23:05.101 -07:00 [INF] Registry: Enabled
2023-09-04 05:23:05.103 -07:00 [INF] HKCU\Software\Microsoft\Windows\CurrentVersion\AdvertisingInfo\Enabled to 0
2023-09-04 05:23:05.106 -07:00 [INF] Skipped registry entry HKCU\Software\Microsoft\Windows\CurrentVersion\AdvertisingInfo\Enabled since value already correct
2023-09-04 05:23:05.108 -07:00 [INF] Skipping 'Calculator' since it is not included by default an has not been explicitly included
2023-09-04 05:23:05.114 -07:00 [INF] Uninstall: Windows Camera
2023-09-04 05:23:05.405 -07:00 [FTL] Failed invoking command
System.Exception: Error. Command line: winget uninstall --name "Windows Camera" --disable-interactivity --exact --silent --accept-source-agreements.
ExitCode: -1978335230
Output: Windows Package Manager v1.2.10691
Copyright (c) Microsoft Corporation. All rights reserved.
Argument name was not recognized for the current command : '--disable-interactivity'
Uninstalls the selected package, either found by searching the installed packages list or directly from a manifest. By default, the query must case-insensitively match the id, name, or moniker of the package. Other fields can be used by passing their appropriate option.
usage: winget uninstall [[-q] ] []
The following arguments are available:
-q,--query                  The query used to search for a package
The following options are available:
-m,--manifest               The path to the manifest of the package
--id                        Filter results by id
--name                      Filter results by name
--moniker                   Filter results by moniker
-v,--version                Use the specified version; default is the latest version
-s,--source                 Find package using the specified source
-e,--exact                  Find package using exact match
-i,--interactive            Request interactive installation; user input may be needed
-h,--silent                 Request silent installation
-o,--log                    Log location (if supported)
--header                    Optional Windows-Package-Manager REST source HTTP header
--accept-source-agreements  Accept all source agreements during source operations
More help can be found at: https://aka.ms/winget-command-uninstall
Error:
at WinGet.Throw(String arguments, RunResult result) in C:\projects\windebloat\src\WinDebloat\WinGet.cs:line 88
at WinGet.Uninstall(String name) in C:\projects\windebloat\src\WinDebloat\WinGet.cs:line 51
at Program.HandleUninstall(UninstallJob job) in C:\projects\windebloat\src\WinDebloat\Program.cs:line 162
at Program.HandleJob(IJob job) in C:\projects\windebloat\src\WinDebloat\Program.cs:line 116
at Program.Inner(String[] excludes, String[] includes) in C:\projects\windebloat\src\WinDebloat\Program.cs:line 62
at Program.<>c.<b__0_0>d.MoveNext() in C:\projects\windebloat\src\WinDebloat\Program.cs:line 13
--- End of stack trace from previous location ---
at ArgumentParser.<>c__DisplayClass0_0.<b__5>d.MoveNext() in C:\projects\windebloat\src\WinDebloat\Cli\ArgumentParser.cs:line 57
2023-09-04 05:23:05.471 -07:00 [INF] Time: 9463ms
2023-09-04 06:17:07.171 -07:00 [INF] Uninstall: 3D Viewer
2023-09-04 06:17:07.219 -07:00 [INF] Skipped uninstall of 3D Viewer since not installed
2023-09-04 06:17:07.225 -07:00 [INF] Registry: Enabled
2023-09-04 06:17:07.227 -07:00 [INF] HKCU\Software\Microsoft\Windows\CurrentVersion\AdvertisingInfo\Enabled to 0
2023-09-04 06:17:07.230 -07:00 [INF] Skipped registry entry HKCU\Software\Microsoft\Windows\CurrentVersion\AdvertisingInfo\Enabled since value already correct
2023-09-04 06:17:07.232 -07:00 [INF] Skipping 'Calculator' since it is not included by default an has not been explicitly included
2023-09-04 06:17:07.233 -07:00 [INF] Uninstall: Windows Camera
2023-09-04 06:17:07.475 -07:00 [FTL] Failed invoking command
System.Exception: Error. Command line: winget uninstall --name "Windows Camera" --disable-interactivity --exact --silent --accept-source-agreements.
ExitCode: -1978335230
Output: Windows Package Manager v1.2.10691
Copyright (c) Microsoft Corporation. All rights reserved.
Argument name was not recognized for the current command : '--disable-interactivity'
Uninstalls the selected package, either found by searching the installed packages list or directly from a manifest. By default, the query must case-insensitively match the id, name, or moniker of the package. Other fields can be used by passing their appropriate option.
usage: winget uninstall [[-q] ] []
The following arguments are available:
-q,--query                  The query used to search for a package
The following options are available:
-m,--manifest               The path to the manifest of the package
--id                        Filter results by id
--name                      Filter results by name
--moniker                   Filter results by moniker
-v,--version                Use the specified version; default is the latest version
-s,--source                 Find package using the specified source
-e,--exact                  Find package using exact match
-i,--interactive            Request interactive installation; user input may be needed
-h,--silent                 Request silent installation
-o,--log                    Log location (if supported)
--header                    Optional Windows-Package-Manager REST source HTTP header
--accept-source-agreements  Accept all source agreements during source operations
More help can be found at: https://aka.ms/winget-command-uninstall
Error:
at WinGet.Throw(String arguments, RunResult result) in C:\projects\windebloat\src\WinDebloat\WinGet.cs:line 88
at WinGet.Uninstall(String name) in C:\projects\windebloat\src\WinDebloat\WinGet.cs:line 51
at Program.HandleUninstall(UninstallJob job) in C:\projects\windebloat\src\WinDebloat\Program.cs:line 162
at Program.HandleJob(IJob job) in C:\projects\windebloat\src\WinDebloat\Program.cs:line 116
at Program.Inner(String[] excludes, String[] includes) in C:\projects\windebloat\src\WinDebloat\Program.cs:line 62
at Program.<>c.<b__0_0>d.MoveNext() in C:\projects\windebloat\src\WinDebloat\Program.cs:line 13
--- End of stack trace from previous location ---
at ArgumentParser.<>c__DisplayClass0_0.<b__5>d.MoveNext() in C:\projects\windebloat\src\WinDebloat\Cli\ArgumentParser.cs:line 57
2023-09-04 06:17:07.573 -07:00 [INF] Time: 6512ms

as an update they all seem to fail with this parm --disable-interactivity is there a way to work around it?

what version of winget do u have?

@SimonCropp  looks like 1.2.10691 - its whatever came with this version of windows 11 i haven't updated anything other than generic windows updates - is there a prereq to force update of winget to a newer version?

yeah it turns out i rely on some features in newer versions. i have deployed a new version of WinDebloat that checks the version of winget and prompts people to update

after updating "App Installer" from the Windows Store it worked great. thanks!


Use ec-automation account and sign the commit

Worth a try, I can see that the commits that do not bring up the Red Hat Konflux check have the GitHub App identity whereas we have the $GITHUB_ACTOR, which might not be the GitHub App identity at all times (e.g. when manually run). Also, the commits are signed using GitHub's GPG key. We can't access that one, so perhaps using the SSH key might do the trick.

An alternative would be to use the GitHub's Content API, as this is what the release service does to create those update PRs

It failed with:
error: user.signingKey needs to be set for ssh signing

I thought it was a typo so I pushed https://github.com/enterprise-contract/infra-deployments-ci/commit/87b4bf5adf09304b3d733379179f524abb8ba1dc to main. The error did not change.


Feature request:  limit the number of dots visible

This is an example of how the dots display when there's a lot of images in the slideshow.

Hey @i300220 please check out the contribution guidelines--in general it's pretty critical for debugging to have a reduced test case in a fiddle or codepen so we require it for issues--although in this case I can understand how its pretty well illustrated by the screenshot.
Im gonna go ahead and close this because I wouldn't really call this a bug--that said if you have a reasonable idea as to some default way to handle this case I'd be curious to hear it!
I thought I remembered someone else with something similar and found this issue. Often times if you search past issues you can find something relevant. Anyway you should be able to customize a solution pretty easily or just turn dots off.
Hope that helps!

Awesome.  Thanks for the kind help!

I would just like to point out that I have this issue too. I have sliders with over 60 images with lazy-load on, and I get like 3 rows of dots. It would be nice to have an arrow to loop through them if they have more than 100% of the width of the slider.
Fiddle:
https://jsfiddle.net/qg7g9n8p/
I couldn't make dots look beautiful, but it reproduces the behaviour neverthless :)

I have try above css but it doesn't work properly for my case. So I create this code, I hope that it's helpful :)
code
p/s: I cannot use insert code feature of comment blog to add highlight code

@vonhutrong added a couple of fixes to your code.  it wouldn't work as is.  using it right now.  thanks so much for that wonderful feature!

@i300220 I have add more comment, I hope that it is clear enough for other one who want to use it :).

is this issue have work around?

CSS selectors :nth-child(n) ?
Gesendet von Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 für Windows 10
Von: Grand<EMAIL_ADDRESS>Gesendet: Freitag, 9. März 2018 10:25
An<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Betreff: Re: [kenwheeler/slick] Feature request: limit the number of dots visible (#2130)
is this issue have work around?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/kenwheeler/slick/issues/2130#issuecomment-371759440, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFmRU950gzUN65IHCYSu89-8touXI8YAks5tckqNgaJpZM4Hcdh6.


:robot: Allow testing immucore from branches

What this PR does / why we need it:
Just allows to build immucore from a given branch and inject it into the final iso for easy testing
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

I don't really want to merge this without having a dispatcher or something to manually trigger it.
I did not really expected it to pass this soon 😝

now it should allow to trigger it manually and provide the parameters


getMessage() not work?

Hi.
latest version lib, use code:
$cm = new ClientManager([
                'options' => [
                    'fetch' => \Webklex\PHPIMAP\IMAP::FT_PEEK,
                    'fetch_order' => 'desc',
                ],
            ]);

            $imap = $cm->make([
                'host'  => $account_info->account_server,
                'port'  => $account_info->account_port,
                'protocol'  => 'imap', //might also use imap, [pop3 or nntp (untested)]
                'encryption'    => $account_info->account_encryption ,
                'validate_cert' => true,
                'username' => $account_info->account_login,
                'password' => $account_info->account_password,
                'authentication' => null,
            ]);

$folder = $imap->getFolder($folder_title);
$message_info = $folder->query()->getMessage($message_msgn);

and... not work. i try test witch msgn or uid.

Hi @reimax ,
thanks for your report. I need some more information:

Do you get any exceptions?
Whats the value of $message_info?
Have you updated your imap.php config file?
What the output of var_dump(ClientManager::$config['options']["sequence"]);?
How have you obtained the message number / uid you are trying to query?

Best regards,

"Webklex \ PHPIMAP \ Exceptions \ MessageHeaderFetchingException
no headers found"

after last line i try
$message_info->move($folder_title);

yes

3

$email_list = $folder->query()->leaveUnread()->since(date('d.m.Y', $time))->get();
.....
$uid = $value->getUid();
$msgn = $value->getMsgn();
...

Hi @reimax ,
thanks for the fast response.
The message numbers are not stable. They change if you move / remove messages from a folder. Please switch to using a uid based sequence. You can do this by updating options.sequence to IMAP::FT_UID.
Best regards,

Here is an updated example:
$cm = new ClientManager([
    'options' => [
        'fetch' => \Webklex\PHPIMAP\IMAP::FT_PEEK,
        'fetch_order' => 'desc',
        'sequence' => \Webklex\PHPIMAP\IMAP::FT_UID,
    ],
]);

$imap = $cm->make([
    'host'  => $account_info->account_server,
    'port'  => $account_info->account_port,
    'protocol'  => 'imap',
    'encryption'    => $account_info->account_encryption ,
    'validate_cert' => true,
    'username' => $account_info->account_login,
    'password' => $account_info->account_password,
    'authentication' => null,
]);

$folder = $imap->getFolder($folder_title);
$message = $folder->query()->getMessage($message_uid);

Have you checked your solution?
If you use uid instead of msdn-then nothing changes, the exception also. But a non-working leaveUnread () is also added to the specified error. I checked now and if put ST_MGN - leaveUnread () works, if FT_UID() - leaveUnread() does not work.

Hi @reimax ,
well I can't "check" the solution, because I can't reproduce the problem with my accounts. However I could imagine a possible problem and tried to provide a solution ;)
Are you sure you are querying the correct folder?
$headers = $folder->overview();
if (isset($headers[$message_uid])){
    var_dump($headers[$message_uid]);
}else{
    echo "Message not in folder";
}

What do you mean by "a non-working leaveUnread () is also added to the specified error"? Has the exception changed?
Best regards,

yes, i get message info: subject, body, date and other.
then i try
$email_list = $folder->query()->leaveUnread()->since(date('d.m.Y', $time))->get();
all message in folder get read flag.

This is so strange..
To recap:

You can't query the message directly using Query::getMessage() -> results in an exception no headers found
But you can query the headers using Folder::overview()
If options.sequence is set to IMAP::ST_MGN Query::leaveUnread() works as expected
But if options.sequence is set to IMAP::ST_UID or IMAP::FT_UID, Query::leaveUnread() does not work

Can you confirm this?
I have to think about it. If you have any additional information, please let me know.
Best regards,

yes.
I don't understand why this is happening. If it helps, I'll use yandex mail.
before i use https://github.com/SSilence/php-imap-client
and for this mail and other mail service with php-imap-client there were no such errors

Hello, I have a similar error with Yandex Mail.
Webklex\PHPIMAP\Exceptions\MessageHeaderFetchingException : no headers found
 /var/www/html/vendor/webklex/php-imap/src/Message.php:430
 /var/www/html/vendor/webklex/php-imap/src/Message.php:237
 /var/www/html/vendor/webklex/php-imap/src/Query/Query.php:284
 /var/www/html/vendor/webklex/php-imap/src/Message.php:909
 /var/www/html/app/Api/Imap.php:31
 /var/www/html/tests/Unit/ImapApiTest.php:20

The error occurs with the parameters:
 'options' => [
        'delimiter' => '|',
        'fetch' => \Webklex\PHPIMAP\IMAP::FT_PEEK,
        'sequence' => \Webklex\PHPIMAP\IMAP::ST_MSGN,
        'fetch_body' => true,
        'fetch_flags' => true,
        'message_key' => 'list',
        'fetch_order' => 'asc'
]

But 1 letter is moved to the "Done" folder (or any other), after which the error falls.
If you use parameter IMAP::ST_UID, then there is no error, but the message is not moved to the folder, and the flag changes to read (SEEN) and that's it.
My code:
        $client = Client::account('default');
        $client->connect();

        /** @var Folder $folder */
        $folder = $client->getFolder(self::FOLDER_INBOX);

        $messages = $folder
            ->messages()
            ->whereFrom(self::FROM)
            ->get();

        /** @var \Webklex\PHPIMAP\Message $message */
        foreach ($messages as $message) {
            if ($message->move(self::FOLDER_DONE) == true) {
                dump('Move');
            } else {
                dump('Not move');
            }
        }

yes.
I don't understand why this is happening. If it helps, I'll use yandex mail.
before i use https://github.com/SSilence/php-imap-client
and for this mail and other mail service with php-imap-client there were no such errors

I'm trying out that library and I wanted to ask you how do you search by date? SSilence/php-imap-client

Hi @reimax @dobrynin-andrey @alexv96 ,
please update to the latest release v2.3.1 and let me know if the issue persits.
Best regards,