unable to detach

hi,
thanks for the great project. i am running ubuntu inside of docker. while i am able to attach to a running process, when i do detach, the attached process doesnt exit till i interrupt it using ctrl+c. it is unable to attach to the process again.

Hi @tumble-weed, it sounds like there's two issues you're running into.

After calling detach, the process created with the command python -m pdb-attach ... is still running, but no longer communicating with the original process that you're trying to debug.
Calling python -m pdb-attach ... again fails.

Is that a correct summary? Just want to make sure I understand correctly before debugging.

thanks for the quick reply. here is the relevant code.
the process i want to attach to (lets call this the target):
import pdb_attach
pdb_attach.listen(50000)  # Listen on port 50000.
import time
i = 0
while True:
    time.sleep(5)
    i+=1

the command i am using to attach ( assming pid is 506), lets call the attachment
python -m pdb_attach 506 50000

after calling detach, the attachment doesnt exit, and no longer communicates with the  target. its like it is hung. hard exiting ( ctrl+c) makes it come out. however spawning another attachment seems to hang (i.e. fails but doesnt crash and exit).

Thanks for the clarification. I'll take a look at this and patch it up.

I am seeing the same issue. Also running ubuntu inside docker.

Sorry for the delay in fixing this. The past couple months have been hectic between a long distance move and major project deadlines at work. I have not forgotten about this though and will be returning my attention to it in July.


[TE] Ignore completeness entries that does not need to be updated

Reduce the entries of data completeness check to be updated by omitting the ones that have been updated previously. This change is to expect to reduce the runtime of cleanup of data completeness check and hence to alleviate the issue that worker threads are blocked by this task.

It's not measure by how much time we could save. It's about whether our workers could still be working after days of execution.
Current issue that we encountered is that every cleanup task of data completeness could take 3-4 hours because it needs to update 10s of thousands of entries. The task is scheduled every 15 mins. Eventually, most threads or all threads will be used to perform the cleanup task.
This code could alleviate the problem because if the entries that have been updated (i.e., isTimeOut=true), then it is omitted and hence reduce the overhead to communicate with the database.

I see. Thanks for the explanation and the fix.


First version

LGTM
Next things to do:

Integrate with CircleCI for automatic builds
Save the ACI in the CircleCI build artifact store
Update https://kinvolk.io/aci/ so that rkt fetch  automatically fetches the ACI from the CircleCI artifact store. The manifest.tmpl.json name will need to match.


feat(plus): add method to mount raw volume to a container

This is the best way I have found to use kplus and allow mounting to all the various k8s volume types.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iliapolo Any thoughts on this?  If it isn't something the team wants, I can extract it to an addon in my local project.  Just want to know if I should close it.

@abierbaum Sorry for the delay.
I understand the use case of this PR, but we deliberately try not to expose the underlying L1 spec.
So I feel this needs a different approach.
I'm ok with leaving it open for now just so we will have it on the radar for later. Added the needs-discussion label to signal that.

@iliapolo I don't disagree that it is ugly and should be improved.  In the meantime, what is your recommended way to do something like add a host volume.  I only added this path because I couldn't see another way to do it.

Hi @abierbaum - Apologies for the delayed response. I think the best option right now is to use escape hatches, which we've just recently added:
https://cdk8s.io/docs/v1.0.0-beta.3/concepts/escape-hatches/
Going forward i think we should add Volume.fromHostPath API, similar to like the ones we already have. WDYT?
Thanks

Hi @abierbaum - Apologies for the delayed response. I think the best option right now is to use escape hatches, which we've just recently added:
https://cdk8s.io/docs/v1.0.0-beta.3/concepts/escape-hatches/
Going forward i think we should add Volume.fromHostPath API, similar to like the ones we already have. WDYT?
Thanks

Seems reasonable.  One thing I would suggest considering is exposing the Volume constructor to allow more directly use when requested.  The JSONPatch support could be used, but seems like it would be a bit of a pain to do things that are abnormal.
For my cases I just created a custom construct that extends Volume and supports the use cases I need.


[AutoPR signalr/resource-manager] Add new property for CORS settings

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6478

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5532


BTEvents.READ callback with latency

Mobile Device Environment

Device: Xiaomi Mi A3 & Samsung Galaxy Tab A
OS: API 28

Application Environment

React Native version: 0.63.1
RN Bluetooth Classic version: 0.10.9

Describe the bug
Handling data received by BTEvents.READ. I discovered that the data is processed with a certain delay (almost 1 second) and the data does not arrive in the same amount of messages per second as that sent by the device. Finally, after a certain time the listener stops processing anything.
To Reproduce
Steps to reproduce the behavior:

Add the listener in componentDidMount() and define the function to handling the data

handleRead = data => {
    console.log(data.data);
    this.setState({sensorValue: data.data});
};

componentDidMount() {
...

this.onRead = RNBluetoothClassic.addListener(
      BTEvents.READ,
      this.handleRead,
      this
    );

...
}

Connect to the device
See the data in the device and the output log

Expected behavior
Receive data as close as possible to real time and never stop of receive data.
Screenshots
Screenshoot of the data received by the bluetooth serial terminal app

There are two possible issues here:

Is that there is a 500ms timeout included in the Java native code, I don't know why it was put there but it is a hold over from the original implementation which I forked and modified.  I haven't had a chance to add the ConnectionConfiguration that I had planned yet.  But this timeout will eventually be customizable.

You're using setState({data}) which is not linear.  I'm assuming that the Terminal app (which I also use, is native and not react native) therefore it has much better performance for output.  If set state is called too quickly, it is lumped and only the last setState will be updated. https://reactjs.org/docs/state-and-lifecycle.html#state-updates-may-be-asynchronous

With regards to the issue of stopping listening all together, that is really weird and may be something that I can look into.  The negative here is, the only two devices I have are:

Barcode scanner
microchip scanner

which are pretty low data devices.  I'd need to find some other way of testing something with higher data.
If you're using this module for time sensitive functionality, you may be out of luck, you may want to use a more customized native module that allows you to have finer control over the data stream, or use an alternate to setState.

I tried again, commenting the setState({data}) and only writting the data in the output console log to avoid to asynchronous method.
I shared some extract of the log and I mark the discontinuities that I found, I hope that could be helpful.
react-native-bluetooth-classic.log

Thanks, I have some questions though, and I'm sorry I don't really understand what the problem is (finer detail), you're sample data doesn't make sense to me, the numbers are neither:

In order
nor unique

so how exactly are you sure that the first #56 is a discontinuity?  Is the 56:

Not supposed to be there?
Supposed to be in a different order
Etc.

Could you provide details on:

What your device is?
What these values are which it's sending?
How often they are being sent?

If I'm going to replicate it, I'm going to need to know how and what to replicate.   Right now I just see a stream of integers/strings with no order or uniqueness, and no way of validating.

The device is an Arduino with a HC-06 bluetooth module and a pressure sensor which sends the value readed each 25ms. I understand that there was a discontinuity, because the gap between 2 samples it was much higher than 25ms.
In the log are shown 2 timestamp.

The first one in when the data is processed by the handleRead method, listening to the event BTEvents.READ
The second timestamp is added by BluetoothMessage class when is readed.

So because of that I understand that the latency can be measured with the diference between the first and the second timestamp.
I don't know why the messages are not in order, but probably the sendEvent method doesn't guarantee this order??
I you pay attention in the second timestamp, although some events are processed at the same time, the data was readed in different time instances.

The discontinuities look like they are at pretty regular intervals, this is probably due to the SLEEP in the native read method.  What happens is:

Wait for data
Reads data into Buffer
Reads buffer from start to end looking for delimiter(s)
Each delimiter is then sent in an individual message
Sleep
Loop

I think you're seeing the reason why almost all the forks of this project REMOVE the sleep, or reduce it to a smaller value.  I just haven't gotten around to allowing for further customization of the connection, there are a number of changes required for this:

Delimiter
Size
Sleep
Etc

that I need to go through all the Forks and pull their changes into a ConnectionProperties object, so that it's more configurable.
I'm leaning towards the sleep being your enemy, specifically with this kind of data.

I just tried to increment the delay between messages in the Arduino project to 100ms and I'm still detecting that periodically discontinuity, so probably you are right and that sleep is my enemy.
What could be the reason about this Thread.sleep(500)?? Sounds like a magic number
I'm going to try to remove this sleep  and look if something breaks. :)

It's 100% a magic number, that is just a hold over from the original project react-native-bluetooth-serial.  If you look at almost all the forks, they've removed the sleep - so I assume this poses no problems for them.   I don't really think it needs to be there, I just haven't gotten around to removing it since the reason I reworked the module doesn't require this type of speed (it's a manual communication process).

I removed that sleep and It works! xD Now I have the samples with a good latency and responds quickly.
Notice that my idea of measuring the latency with the difference beetween the first timestamp and the second one was wrong, probably the first timestamp is written by my computer and the second one is my android device =)
The only problem that I found now is that after a while (1 minute) , I stops of receiving any message and I need to reconnect to the device in order to start to receive data. And I don't know if really there was a disconnection, because I didn't receive any BTEvents.BLUETOOTH_DISCONNECTED event.
Don't worry, I understand your preference with being outside, I'm from a very rainy place (Galicia) and when there is a minimum opportunity to enjoy the sun is an moral obligation. :)

Nice!  If you're not getting a BLUETOOTH_DISCONNECTED then I'm not sure what's up.  If you debug it definitely update the ticket (leaving open) with your findings and we should definitely get it fixed.  There are a number of places where a message could be dropped, or I could be missing an instance of a disconnect and not sending that event.
Do you have your arduino code posted?  I have a couple bluetooth modules laying around and could probably replicate the issue.

I'm gonna take a look and I tell you if I found something.
Also I'm gonna compare this behaviour with the obtained with the Serial Bluetooth Terminal App, because maybe is a problem related with the arduino side instead of Android :)
I have the arduino project posted, you can find it here https://github.com/eipporko/folimetro

Sounds like a plan, the BluetoothClassicExample is a react native version of the Serial Bluetooth Terminal App, which I also use for comparing communication with our hardware.  I appreciate all the details you've been providing, this project has definitely taken off more than I anticipated (specifically since the purpose of it was for IOS, not even Android features).

Sorry about the delay in this response but I was doing some kind of research about the problem related with stop receiving data from the bluetooth device.
I found the next:

I was testing with different Android 10 devices (Xiaomi Mi A2, Xiaomi Mi A3 & OnePlus 5T)
The only one where I found this weird behaviour was in the Xiaomi Mi A3.
Before a while (not always at the same time) the app stops of receiving data.

Checking the log with adb logcat I found that after the next messages, the application stops of receiving data from the InputStream.
08-20 14:17:41.175   683  2902 I<EMAIL_ADDRESS>DeviceSleep: TX Awake, Sending SLEEP_IND
08-20 14:17:41.175   683  2902 D<EMAIL_ADDRESS>SerialClockVote: vote for UART CLK OFF
08-20 14:17:41.326   683  2755 D<EMAIL_ADDRESS>Release wakelock is released

The thread related with the task of reading data from the InputStream, gets stuck waiting for input data available to write in the buffer. You can find this process here->bluetooth/RNBluetoothClassicService.java:468
At first I thought that could be something related with the socket between android and the bluetooth device, but despite not been receiving data if I turn off the bluetooth device the thread which was stuck waiting for data, gets an exception and stops gracefully showing in the log the next message Disconnected - was it cancelled?  false
So seems that the socket is open and working but something related with the communication protocol between the Android and the Bluetooth device is wrong.

Thanks for the update, I still will look at it at some point - since if you're using the native app we discussed (Terminal) and it doesn't have this problem, then it may have to do with:

The method in which the library connects to the device, there are numerous to choose from.  I'm hoping to have those customizable in v11

Unless the issue exists in the native app (Terminal), but you said it was not.

Maybe I explained it wrong, but the behaviour with the native app (Terminal) is the same, when the logcat shown the messages commented before the application stops to receive data.
Probably is something related with the OS, but I don't know if there is any way to manage this and avoid this behaviour.
08-20 17:23:46.120   683  2902 I<EMAIL_ADDRESS>DeviceSleep: TX Awake, Sending SLEEP_IND
08-20 17:23:46.121   683  2902 D<EMAIL_ADDRESS>SerialClockVote: vote for UART CLK OFF
08-20 17:23:46.282   683  2755 D<EMAIL_ADDRESS>Release wakelock is released


Please add my code to your master

Dear,
As you can see I changed something about:
overdue tasks and added two new options:
--group - group all overdue tasks for all projects in one email
--admin - get all overdue tasks for selected project
translation
added new translation for Bosnian language
fix about destroy session
detect that message in debug log
adapt code for new functionalities

There are conflicts detected in your pull-request, you should update your local branch with master.

By the way, you should refactor the method sendOverdueTaskNotifications, there is too much code in it and you should not depend of Symfony\Component\Console\Input\InputInterface in a model.
And it would be better to send a separate pull-request only for the new translation so I can merge that one quickly.
Thanks

I added your Bosnian translation in master but the rest need to be fixed to be merged.
Thanks

Dear,
As you can see I synced my code with your and please merge code now.

Hi Frédéric,
Please add this code in your branch. I need new functionalities, specially for overdue tasks.
BR

Please add this code in your branch. I need new functionalities, specially for overdue tasks.

Sorry, but if I would maintain this project, I would be not very motivated to merge your changes by such a behaviour. If you need this so urgent, what is holding you back to use your own fork and merge upstream changes regularly back?

I agree with you. Do not worry. If you require that I need change my code, adapt, whatever, please tell me.
I used my fork of course, ...
BR

Dear,
As you can see I added new functionalities:

task can be search by comments
activities are searchable now
added quick link (option) for adding child task

BR

If you would like to have your pull-request merged into master you have to fix the issues mentioned in previous comments.

Send a pull-request by feature/subject, smaller PR are easier to review, here you have 4 or 5 different subjects in a single PR
The unit tests are broken with your changes, all tests must pass
There are 24 commits here, try to have one single clean commit by PR

Thanks for your cooperation.


[Question] Emulator speech - available voice options?

System Information (Required)

SDK Language: Node.js
Development Environment: localhost,

I have tried to change the voice of bot, in the RollerSkill example. But the voice remained unchanged in the emulator. I want to change it to a female's voice. The generated SSML is as following:
<speak version="1.0" xml:lang="en-US"><voice name="Microsoft Server Speech Text to Speech Voice (en-US, ZiraRUS)" gender="Female" xml:lang="en-US">I'm roller,
the dice rolling bot. You can say 'roll some dice' or play one of the games I know how to play.</voice></speak>
Suppose I have the speech API key. How can I put the information to the bot so that it is integrated?
Anything I missed? Thank you!

@YanXuHappygela The SSML voice configuration options are specific to the Bing text to speech API you asked about in your previous question, the Bot Framework Emulator does not support that same level of voice options.

@nwhitmont Thank you for clarification. So how can I test change of voice, in other channel, like Cortana?

@YanXuHappygela Cortana only has one voice available.

@nwhitmont what channels can SSML take effect? only on voice enabled web?

Speech is available in Direct Line WebChat when you enable it via speechOptions.
Example:

        BotChat.App({
            directLine: { secret: DIRECTLINE_SECRET_HERE },
            user: { id: 'userid' },
            bot: { id: 'botid' },
            speechOptions: {
                speechRecognizer: new BotChat.Speech.BrowserSpeechRecognizer(),
                speechSynthesizer: new BotChat.Speech.BrowserSpeechSynthesizer()
            }

        }, document.getElementById("bot"));

So the problem is that in the given ssml. gender is "Female", which is rejected by Cognitive Services. Changing “Female” to "female" will work.

thanks for the update @w-Yuan


Back buttons

I've got feedback that there is a lack of Back buttons in different places.

Buttons were added.
b7a399f0ae6e77de543f3f6d18635ce7116cc070


Tweak ANSI color output

Previously, lsif-java used default color output settings when shelling out to Maven and Gradle. Now, lsif-java uses --batch-mode for Maven and TERM=dumb for Gradle to reduce ANSI color output (helpful for CI logs). Additionally, we upgrade to the latest moped release so that setting NO_COLOR=true disables all ANSI colors (including output from lsif-java).
The motivation for this PR was to reduce noise in the Sourcegraph auto-indexing CI logs, which currently render ANSI escape codes.

@Strum355 I thought about it but it didn't feel worth the development effort. Most users run lsif-java in CI and I think it makes sense to enable --batch-mode and TERM=dumb by default out of the box


Feature request: Function on data object could return Promise.

I belive it would be a nice feature if a ractive identified a promise as the result of a function on the data object, and rendered the data when the Promise is resolved.
I have tried the promise plugin, but as I understand that only supports the hole data object to be a promise not a function on the object.

This actually works fine - you can use the promise wherever you like in your data object. Here's a (super crude, but functional) example using the promise-alt adaptor - you can even mix and match data types on the same keypath (e.g. preview is sometimes a promise, sometimes null): http://jsfiddle.net/rich_harris/752ksc1b/

hmm Thank you,  then it was just me missunderstanding the concept of promise in the template.
I will invetigate this futher!


feature: show status in floating window

Did you check the docs?

[X] I have read all the vscode-neovim docs
[X] I understand the fundamental limitations of the plugin and believe this request to be reasonable

Is your feature request related to a problem? Please describe.
VSCode has support for floating windows where you can move a file or group of files to a separate window. Currently, the output of Vim commands are printed in the status bar of the main window, which may be minimized, hidden, etc.
Describe the solution you'd like
It would be useful to have an option to show the output of commands in the status bar of the (floating) window where they are run from.

in the status bar of the editor group where the command was run from instead of the main window.

Oh I see, that clarifies the idea. I think this would require vscode-neovim to declare its statusbar item as "document specific" (in the vscode API this implies a right position instead of left). Then it would appear in the floating window, if this screenshot maps to what you mean (else show a screenshot of what you mean):

But that would technically violate vscode's UX guidelines, since vscode-neovim status is "global", not document-specific.

I was hoping there was a way to show the commands and outputs at the bottom left.

I haven't looked, but maybe vscode has a setting that enables the left-side status items for its floating editors.


[SR-3481] Fix for memory leak in NSURLComponents

PR for master branch : #897
Commit Hash for master branch PR : ba78d522f89b64936ccaab647ee4536fab3718cf

@swift-ci please test


HBASE-26215 The backup master status page should use ActiveMasterManager instead of MasterAddressTracker

Since the backup master status page will remove the MasterAddressTracker, and there is no direct method to obtain ActiveMasterManager (I saw that ActiveMasterManager is a private member of HMaster, and all values in ActiveMasterManager should be returned through HMaster’s public methods). I added some code to make the backup master status page easily retrieve the information it needs.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 21s
master passed

+1 :green_heart:
compile
4m 56s
master passed

+1 :green_heart:
checkstyle
1m 37s
master passed

+1 :green_heart:
spotbugs
3m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 57s
the patch passed

+1 :green_heart:
compile
4m 34s
the patch passed

+1 :green_heart:
javac
4m 34s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 41s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

58m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 14266e45351c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6ed03d98ef

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 26s
master passed

+1 :green_heart:
compile
1m 33s
master passed

+1 :green_heart:
shadedjars
8m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
8m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-zookeeper in the patch passed.

-1 :x:
unit
139m 19s
hbase-server in the patch failed.

173m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2ababb6a0d2a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6ed03d98ef

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/testReport/

Max. process+thread count
4819 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 36s
master passed

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
shadedjars
11m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  7s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  7s
the patch passed

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

+1 :green_heart:
shadedjars
11m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 54s
hbase-zookeeper in the patch passed.

-1 :x:
unit
159m 26s
hbase-server in the patch failed.

203m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3bac1c7a92d8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6ed03d98ef

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/testReport/

Max. process+thread count
3571 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
compile
3m 41s
master passed

+1 :green_heart:
checkstyle
1m 17s
master passed

+1 :green_heart:
spotbugs
2m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 40s
the patch passed

+1 :green_heart:
compile
3m 39s
the patch passed

+1 :green_heart:
javac
3m 39s
the patch passed

-0 :warning:
checkstyle
0m 13s
hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 28s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

51m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 0dfe187885f5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d781113a08

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 59s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  0s
master passed

+1 :green_heart:
compile
1m 38s
master passed

+1 :green_heart:
shadedjars
9m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 48s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

+1 :green_heart:
shadedjars
9m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 48s
hbase-zookeeper in the patch passed.

-1 :x:
unit
204m 23s
hbase-server in the patch failed.

242m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 45814b60e90f 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d781113a08

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/testReport/

Max. process+thread count
3590 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 20s
master passed

+1 :green_heart:
compile
1m 27s
master passed

+1 :green_heart:
shadedjars
9m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  8s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
9m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 46s
hbase-zookeeper in the patch passed.

-1 :x:
unit
211m  8s
hbase-server in the patch failed.

247m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bc59c7789580 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d781113a08

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/testReport/

Max. process+thread count
3538 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 43s
master passed

+1 :green_heart:
compile
5m 11s
master passed

+1 :green_heart:
checkstyle
1m 38s
master passed

+1 :green_heart:
spotbugs
4m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 13s
the patch passed

+1 :green_heart:
compile
4m 35s
the patch passed

+1 :green_heart:
javac
4m 35s
the patch passed

+1 :green_heart:
checkstyle
1m 45s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
26m 18s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

71m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 6d54b9d8acff 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ce2f9336f

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 57s
master passed

+1 :green_heart:
compile
1m 38s
master passed

+1 :green_heart:
shadedjars
9m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 51s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

+1 :green_heart:
shadedjars
9m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-zookeeper in the patch passed.

-1 :x:
unit
205m  9s
hbase-server in the patch failed.

243m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6e581536b8e8 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ce2f9336f

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/testReport/

Max. process+thread count
3365 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s
master passed

+1 :green_heart:
compile
1m 20s
master passed

+1 :green_heart:
shadedjars
9m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
9m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-zookeeper in the patch passed.

-1 :x:
unit
211m 15s
hbase-server in the patch failed.

246m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a69c877f42aa 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ce2f9336f

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/testReport/

Max. process+thread count
3193 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Is this issue branch-2 specific? Usually we should open a PR against master branch first, unless the issue is specific to some branches.
Thanks.

Oh, wrong place, I was trying to reply to another PR, sorry...

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  8s
master passed

+1 :green_heart:
compile
3m 49s
master passed

+1 :green_heart:
checkstyle
1m 21s
master passed

+1 :green_heart:
spotbugs
2m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
3m 46s
the patch passed

+1 :green_heart:
javac
3m 46s
the patch passed

+1 :green_heart:
checkstyle
1m 20s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

55m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux bdb536395225 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ce2f9336f

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  6s
master passed

+1 :green_heart:
compile
1m 38s
master passed

+1 :green_heart:
shadedjars
10m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 48s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

+1 :green_heart:
shadedjars
9m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 50s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
204m  6s
hbase-server in the patch passed.

243m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7ca0bf237cad 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ce2f9336f

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/testReport/

Max. process+thread count
3704 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
10m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 59s
master passed

+1 :green_heart:
compile
1m 25s
master passed

+1 :green_heart:
shadedjars
9m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 30s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

+1 :green_heart:
shadedjars
9m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 52s
hbase-zookeeper in the patch passed.

-1 :x:
unit
220m 30s
hbase-server in the patch failed.

267m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3621

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7ca8803083cd 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ce2f9336f

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/testReport/

Max. process+thread count
3228 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3621/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Values do not update

Testing communications with BH1745NUC. I can successfully scan sensor, read part id and read mft id. When I read color data I get an initial set of values. These do not change on successive read or after power cycle. Do you have any idea on what might be going on?
I've got a couple of different sensors and getting same data from both

I wasn't able to reproduce this issue with the current version of the library. What Arduino are you using? You could try running ROHM example code, to see if that leads to the same issue.

thanks for taking a look at it. I am using a mega 2560. Which ROHM example code are you referring to?

I'm referring to the example code provided for the sensor by ROHM. You can download it here. Try uploading it and see if the issue still persists.

Got it working. Have a few sensors on the i2c bus that were all working fine with the exception of the BH1745NUC. My assumption was that it would not be a wiring issue given everything that was working. I was wrong. I put the BH1745NUC on its own circuit and now I am communicating with it just fine. Don't know what the issue is yet (some combination of resistors and capacitors) but I will figure that out later.

It might be worth looking at the I2C communication with a scope and maybe using stronger pull-ups when there's more sensors on it. Also, try to have the I2C cables as short as possible, since the bus was originally designed for short ranges only. And finally, try to keep the SDA and SCL lines separated and not right next to each other. I've had an issue before with long I2C that was using a ribbon cable with the lines next to each other. Fairly often, voltage changes on SDA induced spikes on SCL, which were then interpreted by the microcontroller as another clock cycle, so the communication started to break down. Anyway, good luck :).


Add screen reader text describing program preview page links

Description
Add new sr text to be translated. Not used yet.
This will be used for the program preview page links. Currently it always reads "Edit" to screen readers, even when the visual labels are "Start here" and "Continue".
Release notes:
N/A
Checklist

[ ] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
#3559

Codecov Report

Merging #3709 (5fadc66) into main (b1ec0ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #3709   +/-   ##
=========================================
  Coverage     80.53%   80.54%
  Complexity     2431     2431
=========================================
  Files           295      295
  Lines          9619     9621    +2
  Branches        658      658
=========================================
+ Hits           7747     7749    +2
  Misses         1619     1619
  Partials        253      253

Impacted Files
Coverage Δ

server/app/services/MessageKey.java
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Improve CLI

In this MR, we introduce two changes to improve src-fingerprint CLI.

First, the default export format is now gzip-jsonl to make the standard command shorter for our users.
Second, we renamed and reworked CLI options. All options that refine the repositories to include or not in the fingerprints are now named --include-***-repos. This exists for forked, archived and public repos. All these options are set to false to limit the quantity of fileshas to compute to the essential repos that could be at risk.

Eventually, we changed the README in accordance.

If the default format is gzip-jsonl, I think we should also set a default output file. Otherwise src-fingerprint will print the gzip into the console which does make sense as it's unreadable and the random characters may break the terminal.


fix: polish components

feat: implement some properties of TextShape

font
fontSize adjusted to 12 units ~ 1meter
width, height
textAlignMode
outlineWidth and color
textColor

fix: component AvatarShape not working
fix: use player identity to sign headers (signed fetch)
fix: materials: enable bloom in worlds environment
fix: det == 0 in most of the cases
chore: skip auth tests (they require a manual action)
chore: add codecov badget
chore: remove custom callable made in gdscript, now it uses a rust function with instance_id
fix: nft shape crash with texture null
chore: change all callable getting from self.base

Codecov Report
Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (e78fd49) 50.14% compared to head (3a0c8de) 49.88%.

Files
Patch %
Lines

...ot-lib/src/scene_runner/components/avatar_shape.rs
0.00%
34 Missing :warning:

...decentraland-godot-lib/src/avatars/avatar_scene.rs
0.00%
22 Missing :warning:

...traland-godot-lib/src/dcl/js/fetch/signed_fetch.rs
0.00%
19 Missing :warning:

...odot-lib/src/scene_runner/components/text_shape.rs
79.68%
13 Missing :warning:

rust/decentraland-godot-lib/src/auth/wallet.rs
0.00%
8 Missing :warning:

...land-godot-lib/src/godot_classes/dcl_ui_control.rs
0.00%
6 Missing :warning:

...raland-godot-lib/src/godot_classes/dcl_ui_input.rs
0.00%
6 Missing :warning:

...and-godot-lib/src/godot_classes/dcl_ui_dropdown.rs
0.00%
3 Missing :warning:

...rc/scene_runner/components/transform_and_parent.rs
70.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   50.14%   49.88%   -0.26%
==========================================
  Files         123      124       +1
  Lines       15172    15280     +108
==========================================
+ Hits         7608     7623      +15
- Misses       7564     7657      +93

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


start: Add a parameters hidden section to experiments to merge params/metrics into experiments

This one adds a hidden section to explain parameters in more detail.
The final goal of this series is to merge "Params/Metrics/Plots" into the experiments trail.
Related #3051

Took care of the review points. PTAL. Thank you @jorgeorpinel @shcheklein

Thank you @iesahin !

So can https://dvc.org/doc/start/metrics-parameters-plots be removed now?

So can dvc.org/doc/start/metrics-parameters-plots be removed now?

I think nope, not yet, after #3050 split and merged completely. These changes does not include visualization/plots.


fix(uninstall): require the -n flag to be set

This is a stop gap fix for issue #392.

What if I have a chart that purposely creates things in more than one namespace? Specifying -n would only fix some of the warnings in that case.
And what if a chart never included a specific namespace (i.e., assumed default). This makes helm uninstall fail now unless I add -n default, which seems detrimental to simple charts or to those hacking on charts...
Seems like actually inspecting each manifest file for its namespace and then passing that to kubectl is the correct fix, although I agree this would help in some cases.

Yup, @mboersma, those are the problems. But I feel like this is a better short-term move than having things get destroyed errantly.
The solution proposed here:

Does not solve edge cases
Does prevent kubectl from deleting things in a surprising way
And will be a stand-in until we get to a more complete solution (which I think will involve inspecting manifests)

If we'd rather not do a stop-gap, I'll just leave this issue hanging open and go ahead and cut a release without a fix.

I think on balance this probably helps. :+1:


add filterFunc to model

I think the FilterFunc stuff is pretty solid, but I think I need to spend some more time working on the way that the column sizes are calculated. There's a bunch of unnecessary copying of the m.columns slice.

I'm using both features in tandem locally, but if it makes more sense to have them as two PR then I'll split them

Would we want the filter function on the column or the table?
I'm wondering if the table itself might be better, so that there's a single filter func attached to the table.  Then, when filtering, instead of checking the filterable columns, it instead checks the filter func for each row.  This would allow someone to use data in the row that isn't in any column, or combine data across columns, etc.

Would adding both make sense? In my use case I'm filtering on all the data in the table, but I could imagine where a per-column filter makes more sense.

I suppose both would work.  Technically you could do everything if you had the table-wide filter, but you would have to go through the extra step of checking for the column yourself.  So having a shortcut on the columns could be nicer in some situations.
My only concern would be clarity of use.  If I define a column filter, and a table filter, what happens?  How can that be made clear? :thinking:

My only concern would be clarity of use. If I define a column filter, and a table filter, what happens? How can that be made clear? 🤔
That's a good point. In that case, I think I should refactor my changes to focus on just the table-level filtering. If I hit a case where that isn't good enough in the tools I'm working on, I'll see if I can come up with a solid solution to the table vs column filter.

One quick way I think would solve the issue is if all the filters get popped into an array, and the results are OR'd together, but then someone will want to do just ANDs which means having to also have a toggle for the "joining" of the filters. In my experience dealing with a collection of filters is a pain 🫤

Yeah, I think the table level filtering is a good catch-all for all scenarios someone might have when they really want to go for custom filtering.  We can revisit later to add more convenience wrappers around it if it makes sense.

In my experience dealing with a collection of filters is a pain

Also my experience!

I'm off work next week and am aiming to wrap up the changes when I've got some time to "relax". All I believe I need to do is move the FilterFunc into a Table method instead of on the Column, and then I'll update the PR.

Ok finally found some time to change the filterFunc. Should have more time this week to make any adjustments that you think might be needed @Evertras

I may further fiddle a little with wording later but that's separate from the functionality, which seems reasonable. Now it just needs some tests.

Wasn't 100% sure how to implement testing since the FilterFunc either does nothing, or it does something that's set outside of the scope of the repo. Any ideas?

It's more testing that the filter func is called and applied.  As a simple test, you could have a table with rows that contain '1', '2', and '3', and then a filter func that checks for 'a', 'b', and 'c' and should match 1/2/3.  It can be totally arbitrary, we just need to make sure that it's applied.


page.url not round-trippable when URL is non-ASCII

The implementation of page.url calls QUrl::toString() with no special options, which produces a Unicode string, with all non-ASCII characters decoded assuming UTF-8.  This is fine when what you want is to display the URL to an end-user, but it's broken when you want to be able to store the URL and re-access the same webpage later. Many websites still use ISO-8859-n, KOI8-R, or other "legacy" encodings in their URL structure; when such a URL is decoded as if it were UTF-8, you get a bunch of U+FFFDs and information is lost.
Please add a way to get the string that QUrl::toEncoded() would return.  (I'm not sure this is enough for my purposes, but to the extent it isn't, it's a problem with QUrl itself and you probably can't do anything about it. :-/ )

Is there any way you can rebase your version up to at least the latest 1.x version?

It's 2.x as of a couple weeks ago, is that not new enough?

Does 2.x change any user APIs from 1.9.8?

Is there any way to build this for osx/linux and windows (without having to be on each machine)?

@knownasilya I am not aware of any significant user-visible API changes between 1.9.8 and 2.0.  The main reason for the major version bump is a huge upgrade to Webkit.
Regrettably, I don't think our build system can handle cross-compilation.

Fixed in https://github.com/ariya/phantomjs/commit/1c203a39279ae556f84bf7b525415e50845419b3

:+1: excellent!


Update bug-check-0x49--page-fault-with-interrupts-off.md

@AyyyAndreanna - Thanks for this PR. I'm investigating the usage of this stop code in Windows.

@AyyyAndreanna - Thanks for this PR. I'm investigating the usage of this stop code in Windows.

@AyyyAndreanna - Thanks for this PR. It looks like this stop code is not active at all, so I don't have a basis to describe this stop code. Your description does sound very logical, but we have had some stop codes that have been implemented in ways that don't always reflect what you would expect. Thanks for your interest in the Windows stop code documentation and good luck with your debugging work.

@AyyyAndreanna - Thanks for this PR. It looks like this stop code is not active at all, so I don't have a basis to describe this stop code. Your description does sound very logical, but we have had some stop codes that have been implemented in ways that don't always reflect what you would expect. Thanks for your interest in the Windows stop code documentation and good luck with your debugging work.


lvm-osds: test with a partition and an lv as journals

This adds support to the lvm_journals scenario so that you can use an lv for a journal. It also modifies the test so that it uses a partition for the other journal instead of a raw device, as ceph-volume is changing to not allow raw devices for journals.

I ran a successful test here using the wip branch from ceph for the ceph-volume changes: https://2.jenkins.ceph.com/job/ceph-ansible-scenario/12/console
This is the corresponding PR for ceph.git https://github.com/ceph/ceph/pull/17403

The CI failures here are unrelated to this PR. I'm going to merge so we can get ceph/ceph#17403 tested.


feat(codesandbox): add examples

Related Ticket(s)
#754
Description
Add codesandbox examples for each component.
Updated small issues with cdn example.
Changelog
New

component folder containing a codesandbox folder for each component

Changed

text for tag from "This is not a tag" to "This is a tag"

Removed

{{removed thing}}

just have a couple of questions:
should we update basic/.gitignore to also ignore the components directory? that way they won't show up in the existing CSB example if we still want to keep that example https://codesandbox.io/s/github/carbon-design-system/carbon-web-components/tree/feat/codesandbox/examples/codesandbox/basic

yeah good catch! will check with team if we still want to keep that example and if so then ignore the components directory

also should we set a width of 300px on the container around each component like the current basic CSB example? https://github.com/carbon-design-system/carbon-web-components/blob/feat/codesandbox/examples/codesandbox/basic/index.html#L19-L21

I wasn't sure about that either. I was looking at Carbon's react codesandbox and they didn't set the width. I'll check with our team as well on that!

other than that looks good to me!


Add TODO comment to plugin registry import line

Signed-off-by: Julius Volz<EMAIL_ADDRESS>

Codecov Report

Merging #87 (2144ebd) into main (15fc72b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   55.39%   55.39%
=======================================
  Files          54       54
  Lines        2381     2381
=======================================
  Hits         1319     1319
  Misses        880      880
  Partials      182      182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fc72b...2144ebd. Read the comment docs.

ah yeah I was a bit too fast. thanks !


Using play button after running selection in terminal use DOS syntax at Python ">>>"

Visual Studio Code Python Extension Play button seems to be using DOS syntax on Python command prompt ">>>".
Does not matter which command line is select in terminal (Python or Cmd)
===
I can highlight lines and run Python code
(from command pallet "Python: Run Selection/Line in Python Terminal").
===
But, when I try pressing the PLAY BUTTON I get message (note triple python prompt, but DOS/cmd syntax)
">>> C:/Users/JimCa/AppData/Local/Programs/Python/Python38/python.exe c:/Users/JimCa/Documents/campaign/CampaignFinance/hello.py
File "", line 1
C:/Users/JimCa/AppData/Local/Programs/Python/Python38/python.exe c:/Users/JimCa/Documents/campaign/CampaignFinance/hello.py
^
SyntaxError: invalid syntax"
===
The paths are correct (even though AppData is hidden)
===
"Run without debugging" from the Run menu works
===
From Help About:
Version: 1.44.2 (system setup)
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T16:36:23.138Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Environment data

VS Code version: 1.44.2
Extension version (available under the Extensions sidebar): 2020.4.74986
OS and version: Windows_NT x64 10.0.18363
Python version (& distribution if applicable, e.g. Anaconda): Python 3.8.2 (from Python.org)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: XXX
Relevant/affected Python-related VS Code extensions and their versions: XXX
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): XXX
Value of the python.languageServer setting: XXX

Expected behaviour
Run hello.py
Actual behaviour
">>> C:/Users/JimCa/AppData/Local/Programs/Python/Python38/python.exe c:/Users/JimCa/Documents/campaign/CampaignFinance/hello.py
File "", line 1
C:/Users/JimCa/AppData/Local/Programs/Python/Python38/python.exe c:/Users/JimCa/Documents/campaign/CampaignFinance/hello.py
^
SyntaxError: invalid syntax"
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

create hello.py
file save
highlight code and select  "Python: Run Selection/Line in Python Terminal"
from command palette -- codes runs OK
Notice setting of terminal (is it "Cmd" or "Python" either setting will cause error;; if it is set to "CMD" it will flip to "Python" after pressing PLAY button)
Press the triangular PLAY button
Will receive syntax error message with text that shows CMD/DOS syntax on a Python ">>>" prompt. The CMD/DOS syntax has the correct file paths, but does not belong at a
Python ">>>" prompt

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python) NONE
XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)
XXX

Good news and bad news.
Good news per advice from Chris Sams @cssams I uninstalled python extension,, quit VS Code, restarted VS Code and reinstalled python extension and problem was cleared up,
but
then I tried loading a Jupyter Notebook .ipynb file which had a kernel issue and the problem recurred -- so the Play button issue seems to be a side effect of a Jupyter Notebook malfunction.
I went through another cycle of reinstalling Python extension and play button issue fixed again.
So, as long as I don't encounter Jupyter Notebook kernel  malfunction PLAY button is fine.

As long as I know, the "play button" (Run Python File in Terminal), in this extension, runs the command python file in the integrated terminal.
And I also experienced that the the "play button" will create a terminal named "Python" before run the above command. If this terminal already exists, it will be used.
So, if you have a terminal named "Python" running CMD, the above command will be ok. If you have a terminal named "Python" running python REPL, the above command will give you an error.

Hey everyone. This is just to inform you that we can confirm the issue.
Using command Run selection in Python terminal followed by clicking the play button results in this error, as the command is sent to the same terminal instead of creating a new one.

Just to give another information: the logic I've posted before "If this terminal already exists, it will be used" is not always true.
I had see it in another issue here in Github (sorry, can't find it to refer here)
I tried to create a new CMD terminal and renamed it with "Python". But the "play button" created another terminal named "Python" anyway. (figure below)
So (at least for my case), the logic that works is:
If this terminal already exists - and it was created with the play button - it will be used, otherwise the "play button" will create a new terminal named "Python" before run the above command.

Is it ok?

Yes, that's expected. Thanks for helping others earlier!

Hi all! Are there any updates on this thread? I've also run into the issue described, and though uninstalling and reinstalling the Python extension resolves it, the problem very quickly reemerges.

It will be good if the the command "Run Python File on terminal" recognizes that there is an already active opened Python terminal running. This would avoid this issue.
As an alternative, the command triggered with the play button could run the reload() function on the active file as a module.
At least it could let us customize this command, or hide the Play Button. I ended up stopping using this command and build another in terminal command line.

Closing as dup of https://github.com/microsoft/vscode-python/issues/2997.


Navbar that shouldn't expand, expand

It seems we broke the navbar because currently navbar expand by default when it shouldn't expand see :
https://codepen.io/Johann-S/full/owYgLR/
/CC @mdo

Works on Firefox 53.0.3 on mac

I took the examples here : https://github.com/twbs/bootstrap/blob/v4-dev/docs/4.0/examples/navbars/index.html

Finally I understood, my bad sorry for /CC


notebooks/iclr2022: Split plots.ipynb into separate notebooks

Refactors plots.ipynb by splitting into separate notebooks.

Move first two cells of plots.ipynb into utils.py
Split notebook into separate files based on what they plot

There's some code duplication in checkpoint-transfer.ipynb and elo-vs-visits.ipynb but I didn't bother de-duplicating it since we don't expect to want to rerun those plots often

Addressed comments.

The notebooks currently set formatting parameters by setting globals in utils.set_plot_formatting(), and then overriding some components such as figure size on a per-cell basis. I was wondering why you chose to do this rather than using matplotlib style sheets and context managers like with plt.style.context(utils.STYLES['default'], utils.STYLES['1-col']).

I've added style sheets now. I didn't know about this feature of Matplotlib

Do we really want the PGF files to be comittted to this repo? I'd be inclined to add them to .gitignore and instead just commit them in the go-attack-paper repo, but open to arguments to the contrary.

Maybe it's mildly useful to check whether notebook changes have changed the plots, and it's less likely that someone will accidentally upload old plots to go-attack-paper. But removing them seems fine — the plots are visible in the notebooks anyway

I think the only resolved comment is this one on win-rate-vs-training-steps.ipynb:

The code in this particular notebook feels fundamental enough that we likely want to move it outside of a notebook into a Python module -- but that can be another PR.

I'll make a kanban task to clean up the notebooks more


fix(TDI-38952):remove the warning around the components.

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:

please fill the description and the checks for the PR, you need to follow the PR process.


No primary key

I tried to define table without primary key , but I got error message when query in this table, it always show the id column not exist. My table doesn't have id column. How can i query in this table ?
Please help me. Thanks

What does your table definition look like?
I don't believe ORM will work very well if there's a table with no keys, but you can try explicitly passing in:
ids: []

to the table definition but I'm not sure if it will work.

`module.exports = function (orm, db) {
db.define('user_club', {
club_id: {type: 'integer'},
user_id: {type: 'integer'},
player_state: {type: 'integer'},
club_chip: {type: 'integer'},
accept: {type: 'integer'},
created_at: {type: 'date', time: true},
updated_at: {type: 'date', time: true}
});
};
My table is pivot table, i want to save data to pivot table,  , i don't want to create associations. Now I can define table model, but I can't update data because it need id column to save. Do you have any idea to update into DB ? I can use raw query to update but I don't know how to use orm model to update


Asp.net Core web app doesn't throw any exception when feature flag free quota limit is reached

This is something that we faced in production recently.
Accidentlally we were using Free tier of App Configuration in production workload for our web app.
We were deploying the new changes in the production environment and we were getting 500.30 service unavailable error, when we were trying to access the API's
We tried running the command *dotnet .dll from kudu using dotnet .dll command and it just hangs doesn't show any error in console.
At last we tested on local env and found it was due to feature flag free quota limit is reached application was not running and no exception was shown in console, making it hard to understand what is the root cause of the issue.
below is our code for program.cs
`{
                 var builtConfig = builder.Build();

                 var azureServiceTokenProvider = new AzureServiceTokenProvider();

                 var keyVaultClient = new KeyVaultClient(
                     new KeyVaultClient.AuthenticationCallback(
                         azureServiceTokenProvider.KeyVaultTokenCallback));

                 builder.AddAzureKeyVault(
                     $"https://{builtConfig["KeyVaultName"]}.vault.azure.net/",
                     keyVaultClient,
                     new DefaultKeyVaultSecretManager());

             })

            .ConfigureAppConfiguration((ctx, builder) =>
            {
                var builtConfig = builder.Build();
                builder.AddAzureAppConfiguration(options => {
                    options.Connect(builtConfig["feature-flag-connection-string"])
                        .UseFeatureFlags();
                });
            })`

Hello @sailleshPawar, this issue is for the Azure App Configuration provider for .NET Core. I have moved the issue there: https://github.com/Azure/AppConfiguration-DotnetProvider/issues/170


fixed cdv clsp uncurry help for --treehash flag

the treehash returned is that of the uncurried puzzle, not that of the curried one.

Apologies for the delay here - but the commit isn't signed. Closing PR - feel free to reopen or create a new PR with a signed commit


feat: cdc table & generated column & auto schema mapping

after https://github.com/risingwavelabs/risingwave/pull/19112 the generated column still can not defined on cdc table with auto schema mapping.

Can "generated column" be applied to the meta columns? https://docs.risingwave.com/integrations/sources/postgresql-cdc#metadata-options


[BUG] roleArn is being checked at create time instead of provision time

What is the bug?
I am trying to setup a Workflow using the Flow Framework to connect to Claude using the create_connector provision type. I am setting up a variable for the roleArn so that I can inject the actual role when the workflow gets provisioned. Example:
"credential": {
    "roleArn": "${{ AWS_BEDROCK_ROLE_ARN }}"
}

When I go to CREATE the workflow using POST _plugins/_flow_framework/workflow, I receive a 502 error. If I replace just the variable placeholder with an actual invalid IAM Role, I get an error that says I'm not authorized to pass that role. This error tells me there the CREATE process is trying to pass a role at CREATE time. This shouldn't be happening, because the Flow Framework template wouldn't know what the role actually is at CREATE time. In this example, the Flow Framework would only know the actual role arn at PROVISION time (_provision). That is when the AWS_BEDROCK_ROLE_ARN would get injected, and would be available to be passed / validated.
How can one reproduce the bug?
You can run the following example workflow in DevTools. This will generate a 502 error because it tries to pass the placeholder variable at CREATE time. Then you can substitute it for an actual AWS Role Arn, like: arn:aws:iam::123456789012:role/MyCoolRole. This will generate a Pass Role error, demonstrating that something is happening at CREATE time that shouldn't be happening. Finally, if you want you can substitute in an actual role that has permissions.
POST _plugins/_flow_framework/workflow
{
    "name": "Deploy Claude Model",
    "description": "Deploy a model using a connector to Claude",
    "use_case": "PROVISION",
    "version": {
        "template": "1.0.0",
        "compatibility": [
            "2.12.0",
            "3.0.0"
        ]
    },
    "workflows": {
        "provision": {
            "nodes": [
                {
                    "id": "create_claude_connector",
                    "type": "create_connector",
                    "user_inputs": {
                        "name": "Claude Instant Runtime Connector",
                        "version": "1",
                        "protocol": "aws_sigv4",
                        "description": "The connector to BedRock service for Claude model",
                        "actions": [
                            {
                                "headers": {
                                    "x-amz-content-sha256": "required",
                                    "content-type": "application/json"
                                },
                                "method": "POST",
                                "request_body": "{ \"prompt\":\"${parameters.prompt}\", \"max_tokens_to_sample\":${parameters.max_tokens_to_sample}, \"temperature\":${parameters.temperature},  \"anthropic_version\":\"${parameters.anthropic_version}\" }",
                                "action_type": "predict",
                                "url": "https://bedrock-runtime.us-east-1.amazonaws.com/model/anthropic.claude-instant-v1/invoke"
                            }
                        ],
                        "credential": {
                            "roleArn": "${{ AWS_BEDROCK_ROLE_ARN }}"
                        },
                        "parameters": {
                            "endpoint": "https://bedrock-runtime.us-east-1.amazonaws.com/",
                            "content_type": "application/json",
                            "auth": "Sig_V4",
                            "max_tokens_to_sample": "8000",
                            "service_name": "bedrock",
                            "temperature": "0.0001",
                            "response_filter": "$.completion",
                            "region": "us-east-1",
                            "anthropic_version": "bedrock-2023-05-31"
                        }
                    }
                }
            ]
        }
    }
}

What is the expected behavior?
The workflow can be provisioned with a placeholder variable in the roleArn section.
What is your host/environment?
Managed OpenSearch 2.13. User that is making the call is configured as an AWS IAM Role in backend security.
Do you have any screenshots?

Do you have any additional context?
n/a

Attempted to reproduce this with a local cluster and it works fine; something must be different on AOS with this.   Also, nothing in Flow Framework would produce a 502 error.
Placeholders work elsewhere in the template so it's possibly related to the fact that the credentials are encrypted.
@amitgalitz @owaiskazi19 do you have any ideas here?


Phasic Policy Gradient

@rodrigodesalvobraz I would like to know whether Phasic Policy Gradient is implemented https://arxiv.org/abs/2009.04416. If it's not then I would like to try implementing it and add it to Pearl.

Hi, @cvnad1 . That is not implemented in Pearl. If you do that, that would be much appreciated. Thank you.

@cvnad1. I think it is fine to keep the policy and value networks separate. Do you have any specific concern about separating them?

@yiwan-rl Crct me if I am wrong, but I believe in official PPO implementation by the majority of libraries, the network has a common base, a value head, and a policy head as this gives better results as compared to training them separately.
Of course, it is not wrong to train them separately but this would result in poor performance. PPG exactly addresses this. The authors noticed that separating policy and value networks results in poor performance and keeping a common base results in noise and reduced sample efficiency. To get the optimum of both worlds, they proposed the PPG algorithms as detailed in the linked paper above.
In PPG, we have two neural networks in total,
Policy network -> common base + policy head + auxiliary value head
Value network -> Normal vanilla value network
There are two training phases,
Training Phase -> Update Policy network + Update Value Network separately
Auxiliary Phase _> Update auxiliary value network using Joint Loss + Update Value network again (Sampling efficiency)
I just wanted to give a summary to you of how I am planning to implement PPG as PPG is just a modification to PPO with some additional losses and training updates.
Again, I will be delighted to hear your thoughts or suggestions that can help me.

Thanks for the explanation. To implement this idea, you could write a new history summarization module that implements the shared base network, similar to this LSTM module https://github.com/facebookresearch/Pearl/blob/main/pearl/history_summarization_modules/lstm_history_summarization_module.py. The history summarization module's goal is to produce a vector, based on past history, that represents the agent's current state, which is the input of the actor and the critic. I think the best place to implement this shared base is there.

@yiwan-rl Will check the module and revert back in case of doubts.


community moderator can't save edits to template or delete them

Error occurs when community moderator tries to save an edited template or delete them. Interestingly I can do it successfully as an admin.
@thewilkybarkid any chance you can please

[ ] Check why community moderators can't do the above action correctly
[ ] Check that templates that are saved correctly show up as available templates to load in full PREreview by community members

I've been able to recreate this as a community moderator and not as an admin too: the former gets a 403 Forbidden response when editing or deleting a template, but can create them successfully.


Path variables in wrong order

Example:
  url <-
    sprintf("https://www.googleapis.com/compute/v1/projects/%s/zones/%s/instances/%s/stop",
            instance, zone, project)

It looks like they are in the order the function arguments should be in...


haskell

Haskell如何判断一个数列为等差数列？

import Data.List ( nub )

a :: [Int]
a = [1, 3, 5, 7, 9, 11]

b :: [Int]
b = [2, 4, 6, 8, 10, 11]

check :: [Int] -> Bool
check l = (==) 1 $ length $ nub $ zipWith (-) (init l) (tail l)

main :: IO ()
main = do
  print $ show $ check a
  print $ show $ check b

main = print $ check [1,2,3,4,5]
diff :: (Num a) => [a] -> [a]
diff xs = zipWith (-) (tail xs) (init xs)
check xs = all (== 0) $ diff $ diff xs

`
main = print $ check [1,2,3,4,5]
diff :: (Num a) => [a] -> [a]
diff xs = zipWith (-) (tail xs) (init xs)
check xs = all (== 0) $ diff $ diff xs
`


Various doc fixes

This is a small pull-request to fix a couple inaccuracies that I recently found in manual/custom_codecs/extras/README.md.

The commit "Update README.md" had already been merged to 3.0.x as 6a1b89.


Update images for release N and N-1 with 2024a commit db8bd76

Update images for release N and N-1 with 2024a commit db8bd76
Related-to: https://github.com/red-hat-data-services/notebooks/pull/241/files
Automated action failed: https://github.com/red-hat-data-services/notebooks/actions/runs/8810764452
Related-to: https://issues.redhat.com/browse/RHOAIENG-6349
https://issues.redhat.com/browse/RHOAIENG-6271
https://issues.redhat.com/browse/RHOAIENG-6280

Merging to get the ready the fix for the rc build

/approve


Get included in the official list of known backends

Once this library is released to the general public and has been tested in a few use cases, we should get it included in the list of official list of known backends (see the docs for the process).

PR created: https://github.com/fsspec/filesystem_spec/pull/1344

Closing, since the PR was merged 🎉


Why can't I drop a node after the last one if the last one has childs?

If I try to drop a node after the last node (in the same parent or in another one) it won't work.
This is the code in $scope.options:
accept: function(sourceNodeScope, destNodesScope, destIndex) {
     console.log("type source:", sourceNodeScope.$modelValue.type);
     console.log("type dest:", destNodesScope.$modelValue[destIndex].type);
     return (sourceNodeScope.$modelValue.type == destNodesScope.$modelValue[destIndex].type);
}

This will allow to drop only if source element type is equal to destination element type (types are custom fields that are more or less like the depth of the element).
If the destination item is the last one and it has childs, on the console.log I can see that the destination type (depth) is the higher or the lower one, and the tree graphics doesn't show me the placeholder.
It works only if I remove the accept function from the $scope.options or if I remove childs belonging to the mentioned above nodes.
Anyone knows how can I fix this?
Thanks in advance!

I'm facing similar issue and realize that all nodes need to have a children property, even an empty array, otherwise we can't drop a node inside it.

I managed to get this working simply by adding a little extra space with CSS, like this:
.my-tree-node-class:last-child {
  padding-bottom: 1em;
}

It of course changes the resulting appearance a little, but not by much, and dragging below the last item works flawlessly with that change made.

Closing this issue due to inactivity. See #815 for more information.
Please create a new issue is this still occurs with the current version of the component.


feat(core): add support to code view github

Fixes #12

any update on this?
when will it release

I have an issue to handle the navigation on subfolders, I will merge the current version. To display button will be needed to reload the page only when navigate on subfolders


Fixes bind local port problem in 2.2

https://github.com/redhat-developer/kestrel-linux-transport/issues/91

I merged this just in case. 2.2 is EOL by now.


brew info doesn't re-read available formulae after auto-tap

brew config output
HOMEBREW_VERSION: 3.0.0
ORIGIN: https://github.com/Homebrew/brew
HEAD: ebc7cc36a0e029d58fac8cebd1b5ff583b3fd95b
Last commit: 5 days ago
Core tap ORIGIN: https://github.com/Homebrew/linuxbrew-core
Core tap HEAD: 627a335d2d645ff7166b2f53f98705d4ecf24134
Core tap last commit: 5 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 6
Homebrew Ruby: 2.6.3 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: hexa-core 64-bit skylake
Clang: N/A
Git: 2.29.0 => /usr/bin/git
Curl: 7.47.0 => /usr/bin/curl
Kernel: Linux 5.4.0-65-generic x86_64 GNU/Linux
OS: Ubuntu 16.04.7 LTS (xenial)
Host glibc: 2.23
/usr/bin/gcc: 5.4.0
/usr/bin/ruby: N/A
glibc: N/A
gcc: N/A
xorg: N/A
brew doctor output
Your system is ready to brew.

[X] The brew doctor above contains no "Warning" lines.

What were you trying to do (and why)?
I was trying to figure out where formula install-time options were saved, to expand on my reply to https://github.com/Homebrew/discussions/discussions/748#discussioncomment-353804 , so I chose the third-party mongodb-community formula to experiment on. To verify that it had options, I ran brew info on it.
What happened (include all command output)?
mongodb/brew was auto-tapped, but brew info still failed to find the formula:
$ brew info mongodb/brew/mongodb-community
==> Tapping mongodb/brew
Cloning into '/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/mongodb/homebrew-brew'...
remote: Enumerating objects: 30, done.
remote: Counting objects: 100% (30/30), done.
remote: Compressing objects: 100% (29/29), done.
remote: Total 533 (delta 9), reused 6 (delta 1), pack-reused 503
Receiving objects: 100% (533/533), 114.71 KiB | 255.00 KiB/s, done.
Resolving deltas: 100% (247/247), done.
Tapped 11 formulae (39 files, 265.3KB).
Error: No available formula or cask with the name "mongodb/brew/mongodb-community".

But the formula clearly exists:
$ brew search mongodb
==> Formulae
mongodb/brew/libmongocrypt                    mongodb/brew/mongodb-community<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>          mongodb/brew/mongosh
mongodb/brew/mongocli                         mongodb/brew/mongodb-community-shell<EMAIL_ADDRESS><EMAIL_ADDRESS>          mongodb/brew/mongodb-database-tools
==> Casks
homebrew/cask-versions/mongodb-compass-beta                          homebrew/cask/mongodb-compass                                        homebrew/cask/mongodb-compass-readonly                               homebrew/cask/nosqlbooster-for-mongodb
homebrew/cask/gcollazo-mongodb                                       homebrew/cask/mongodb-compass-isolated-edition                       homebrew/cask/mongodb-realm-studio

And a second brew info does find it:
$ mongodb/brew/mongodb-community: stable 4.4.3
High-performance, schema-free, document-oriented database
https://www.mongodb.com/
Not installed
From: https://github.com/mongodb/homebrew-brew/blob/HEAD/Formula/mongodb-community.rb
==> Dependencies
Recommended: mongodb-database-tools ✘
==> Options
--without-mongodb-database-tools
	Build without mongodb-database-tools support
==> Caveats
Warning: mongodb-community provides a launchd plist which can only be used on macOS!
You can manually execute the service instead with:
  mongod --config /home/linuxbrew/.linuxbrew/etc/mongod.conf

What did you expect to happen?
Auto-tapping on any operation should trigger a load of the newly-available formulae before resuming that operation, so brew info should have worked the first time.
Step-by-step reproduction instructions (by running brew commands)
$ brew untap mongodb/brew
$ brew info mongodb/brew/mongodb-community   # first run fails
$ brew info mongodb/brew/mongodb-community   # second run succeeds

I'm not sure if it's meant to auto-tap. The thing doing the auto-tapping is actually the Cask loader.

The thing doing the auto-tapping is actually the cask loader.

I agree that.
In NamedArgs#load_formula_or_cask,  if only != :formula  function two things these returning Cask info and auto-tapping.
It Should be separated return Cask and auto-tapping


WIP: Wait 10 seconds for video to be there instead of 1

@famewolf See if this fixes your problem.

I implemented that patch and have it running...so far so good.

It made it to page 182 out of 201 before it started skipping sweeps and those could have been the flash ones mentioned.  It was pretty obvious when it was happening on page 1 vs page 182.   I'll run it a couple more days and see how it does.

Closing this PR as I bumped up the video wait time to 5 seconds in latest release. Hopefully that is long enough.


Moo over Moose

have you considered using the lighter weight Moo / Moo::Role / Type::Tiny over Moose / Moose::Role / TypeConstraints?

I haven't yet, I do need some subclassing and advanced functionality. But thanks for the suggestion, I will look into it. I will keep this issue open for now.
Cheers!

Looks like it works fine with Moo. I had to get rid for some type validation for some params but its probably better to implement those checks at the user level.


Routed parent/child component communication not working

Using ui-router RC1,
does the child need to have a child state of the parent in order to get the foo-binding on the  ?
Is it possible with:
parent : .state('hello, ...
child : .state('world', ...

or do we need to have:
parent: .state('hello', ...
child: .state('hello.world', ...

I have <div ui-view foo-binding="$ctrl.bar"> on my root component template, but the routed child is not receiving the fooBinding.

It should send the binding down through the ui-view as long as it's routing to a component inside the ui-view.
Can you show me a simple plunker that demonstrates the issue?
http://plnkr.co/edit/xJD0qgct6u8PaIjQ1LWc?p=info

Here is the plunkrs :
in this case it works : http://plnkr.co/edit/JI7BtA2uhW1t1txFanYp
the bindings (fooBar and myCoolFunction) from the div of the rootobj are sent to the login component.
but if there is an intermediate state with a redirect it's not working anymore : http://plnkr.co/edit/CLpaq25Fe1ZagNbgvKBa
in this case the bindings are not available in the login component

I just ran into this exact issue.
I have a non-abstract intermediate state that is just <ui-view></ui-view> so I can have a UI tab in my application that

Points to an intermediate state, that way I can utilize ui-sref-active for the tab UI so that any child state marks that tab as active.
Redirects to a landing state for that tab.

I tried making the intermediate state abstract with a redirect but this does not seem to work. When I click a link to this abstract state, it does not redirect, it just throws an error that I cannot navigate to an abstract state.
If I remove the intermediate state, which is really only there for the purposes of using ui-sref-active on my tab, then it works.

It you put a template on the abstract state, it will carry your binding down from the parent to the child:
template: '',


Updating workflows

This PR adds the following workflows:

R-CMD-check.yaml via usethis::use_github_action_check_standard()
CodeCov test-coverage

This turned out to be a mess...


The pretrained model for WACV‘23 paper?

I would like to know where to find the pretrained model for the WACV'23 paper. Thank you~

They are listed at https://istvansarandi.com/dozens/ if you scroll down below the code example.