Feature request: "the ability to disable the display of the group label"

Hi Andrei,
First of all thanks for the brilliant set of nodes you have created.
I would like to propose following feature:

The ability to disable the display of the group labels.
I am asking this because the group labels are using precious space on my smartphone.

For me it would be OK If this could be set globally for all groups:
e.g. by having the following line in the settings.js
contribUIdisplayGroupLabel:false
In that case for those groups that I still would like to give a label I can use the node-red-contrib-ui text node to give the group a label.
kr
Jan.

how about
.md-title {
    display: none;
}

?


[Event Hubs] Improve the current implementation of Sender

The current sender has a promise wrapper around the rhea sender which is based on event emitter pattern. Every time a message is sent, event handlers are added and removed and the promise is resolved or rejected based on the type of event received. This design works well as long as the customer is awaiting on the previous send (i.e an eventhub client is sending one message at a time).
If too many messages are sent, then this causes the node.js error too many listeners attached, by default only 11 (max) are allowed.
A better appraoch would be add all the event handlers at the time of creating the sender link and then maintaining an internal map of the messages being sent. The promises would be resolved or rejected based on the type of event received.
Things that make this approach a little complex are:

rhea internally has a circular buffer that throttles the number of messages being sent. If the messages cannot be sent then we need to wait for sometime before attempting to send them.
How do we handle retry attempts?

This can now be done using the new awaitable sender introduced in https://github.com/amqp/rhea-promise/pull/44

Yes, it should be possible now to do that. The current EventHubsSender or ServiceBusSender has the retry logic baked in, which the rhea-promise AwaitableSender does not have. You can call await AwaitableSender.send() and if the promise is rejected then retry in the EH/SB sender. We are sending the SenderBusyError in EH and SB which is then translated into an AmqpError. The SenderBusyError is a retryable Error. This information is then used by the retry config to determine whether it should make an attempt to send the message again. However, in rhea-promise it throws InsufficientCreditError. In the wrapper method you will have to catch this and covert it to SenderBusyError or may be add support in amqp-common to treat InsufficientCreditError as a retryable error.
In actionAfterTimeout, in SB and EH we throw ServiceUnavailableError (retryable), which is also translated into an AmqpError and then the promise is rejected. Whereas in rhea-promise we are throwing OperationTimeoutError which is not a retryable error. You will have to catch this as well in the EH/SB sender method and do the right thing.
Another option is to simply reimplement what is done in AwaitableSender in rhea-promise in EH/SB and handle error and retry the way it is being done currently.
Both the options will work well.

Based on the discussion here so far here's my summary:
Overview
We should switch to using the AwaitableSender from rhea-promise to mitigate the too many listeners attached node.js error we can get today.
Current State
Link recreation

onClose
onSessionClose

We don't attempt to recreate a link on session or sender errors.
Retry logic
We currently rely on the retry operation within core-amqp to determine if an error is retryable.
Sender details
We use an event-based sender and attach the following event handlers each time we call send:

onAccepted
onRejected
onReleased
onModified

None of these check if the error is retryable directly, instead leaving that to the retry method.
Proposed Changes
Sender to AwaitableSender

Where we currently call connection.createSender, call createAwaitableSender instead.
Continue passing in the on*Close handlers when calling createAwaitableSender. These should attempt to recreate the link if it has closed.

Send implementation
Update to wrap the awaitable send method in a new Promise. We need to keep 3 features in mind:

Cancellation
Retryable errors
Timeout

To support these 3 features, we'll need to create a new Promise that wraps the awaitable send call as we do today.
Cancellation
The awaitable send method doesn't accept an abort signal. We can either update rhea-promise to accept an AbortSignalLike, or handle it in a function that wraps the send method.
In the latter case, cancellation would work similarly to the current implementation wherein the abortSignal abort event calls the wrapper's reject function.
Retryable errors
We can continue to rely on the retry function from core-amqp to handle most retryable errors. We can either update the retry function to treat InsufficientCreditError and OperationTimeoutError errors as retryable (this would impact the receiver and management clients as well), or catch the error thrown by send, call translate on it ourselves and set its retryable property.
I'd rather go with the 1st approach since if these errors could be retryable for receiver/management links as well, but otherwise the 2nd approach would be safer.
Timeout
We can handle timeouts the same as we do currently.
Questions
Did sender_error and session_error always indicate the a disconnect, or is that new with AwaitableSender? I'm wondering if our existing code intentionally doesn't attempt to recreate the link. It's possible we didn't notice since subsequent send calls should create the link if it was closed.

@amarzavery

in rhea-promise we are throwing OperationTimeoutError which is not a retryable error.

As we discussed offline while working on https://github.com/amqp/rhea-promise/issues/42, we arrived at the conclusion that OperationTimeoutError should be a retryable error. As a follow up on that discussion I had logged #2891. Therefore, consumers of core-amqp package will find OperationTimeoutError as a retryable error. Consumers of amqp-common will not. This is fine as we intend to use the awaitable sender from rhea-promise only via core-amqp
@chradek

We don't attempt to recreate a link on session or sender errors.

A sender_error event is always followed by a sender_close event
A sessoin_error event is always followed by a session_close event.
Therefore the link recreation (by using onDetached()) is being taken care of on session or sender errors

@chradek @ramya-rao-a
Following are some notes on the implementation at - https://github.com/Azure/azure-sdk-for-js/pull/4446

About timeout, since rhea-promise's AwaitableSender accepts sendTimeoutInSeconds (which has a default value of 20 seconds) and throws the OperationTimeoutError (retryable), it seems like we should be able to simplify and not have to have the timeout handling from SDK side and allow users to configure, pass in this value directly.
A challenge here though, is that because this option is set at time of creating the sender, we are losing context/control over being able to have control over time taken by init.

If we don't make any changes, then we retain the timeout handling, but rhea-promise will almost always throw the OperationTimeoutError much earlier (at default 20 sec mark), and our timer handling is never going to be hit, unless timeout happened due to some other reason, such as due to init() taking too long.

About cancellation, yes - current mechanisms seem sufficient. However, we may need to update rhea-promise as well which is not trivial because it's not in our mono-repo to begin with. @amarzavery @ramya-rao-a thoughts on this?

Also, discussed offline with @ramya-rao-a about having a sample/repro to verify the original problem being solved, and so below is the sample being used to test.
Based on the value supplied for setMaxListeners on the sender which is set to 1000.
If senderCount exceeds this value then Node throws a warning -> MaxListenersExceededWarning: Possible EventEmitter memory leak detected..
With changes in linked PR, this test failed previously and now succeeds, validating our approach!
     const senderCount = 1200;
      try {
        const producer = client.createProducer();
        const promises = [];
        for (let i = 0; i < senderCount; i++) {
          debug(">>>>> Sending a message to the hub when i == %d", i);
          promises.push(producer.send([{ body: `Hello World ${i}` }]));
        }
        await Promise.all(promises);
      } catch (err) {
        debug("An error occurred while running the test: ", err);
        throw err;
      }

@chradek @ramya-rao-a let me know if there are any other comments on this. Looks like https://github.com/amqp/rhea-promise/issues/48 is related and takes care of the updates to rhea-promise

Good point on timeout being configured at sender creation time. Logged https://github.com/amqp/rhea-promise/issues/49
For now, lets use the approach as described in https://github.com/Azure/azure-sdk-for-js/pull/4446#issuecomment-516216761

#4446 is now merged.
@ramya0820 You have a test case mentioned in the comment above. Can you please send a PR that adds that test to our code before closing this issue?

Can you please send a PR that adds that test to our code before closing this issue?

Sent https://github.com/Azure/azure-sdk-for-js/pull/4637
In sender tests, 2 of them are failing - to do with message size checks, currently skipped these in this PR. cc: @ShivangiReja
Receiving a mEssagingError instead of MessageTooLargeError from service side with following rejection message
Sender \'eventhubtest-1c003fb5-0c3d-4c4f-8490-420321cff636\' on amqp session \'local-2_remote-2_connection-4\', received a \'rejected\' disposition. Hence we are rejecting the promise.

@ramya0820
It looks like errors returned by the awaitable sender get converted to a SendOperationFailedError, which is also considered retryable.
We can get the original error from the [https://github.com/amqp/rhea-promise/blob/454e557be5dc1ed94b96fe3316039eddd644d4f5/lib/errorDefinitions.ts#L59] field.
So the change in evetHubSender.ts would be changing
https://github.com/Azure/azure-sdk-for-js/blob/70563f408cd9753d11b9ce29a8434a8765300043/sdk/eventhub/event-hubs/src/eventHubSender.ts#L647
to err = translate(err.innerError || err);

Completed by #4446 and #4637.


BlueWallet Multisig Option?

BlueWallet for Android/iOS/macOS has the ability to create multisig wallets using hardware devices. Could this option be expanded on in Setup Computer/App somewhere?

IIRC it only works when connected to the internet (won't work in airplane mode) and doesn't support testnet?
I'd be open to it (with appropriate disclaimers about the danger of mobile) if it could work offline and on testnet.

Yeah, testnet I don't think is an option, but I don't know why internet connectivity is an issue. Something has to broadcast the transaction and BlueWallet would broadcast the transaction just like Specter would broadcast the transaction.
You don't have to keep any keys with BlueWallet as all the keys can be in hardware wallets. BlueWallet also has a macOS version just like Specter so it doesn't have to be a mobile device.

For coordinator it could work (with obvious warnings about how bad it is for your privacy), but I meant as a consigner it needs those basic things.
Specter-Desktop has 10x as many eyeballs and is full featured, I see no reason to recommend bluewallet as coordinator for now.

UPDATE: Bluewallet claims they support offline usage. With testnet support, it'd be worth checking out.
https://twitter.com/bluewalletio/status/1359255767849836549


Showing 1.java in MacOS terminal title when Hello World executed

Description:
Followed https://ballerina.io/learn/quick-tour/ to run HelloWorld and in the Terminal Title showing as 1.java
Lang-> Ballerina 0.970.0
OS -> MacOS 10.13.2 (17C88)

This issue is not reproducible in ballerina 0.981.1 so closing this issue.


Select2 focus as select

WHY
BEFORE - What was wrong? What was happening before this PR?
A lot of normal behavior was broken because auto-open select2.
https://github.com/Laravel-Backpack/PRO/pull/81
https://github.com/Laravel-Backpack/CRUD/issues/4606
https://github.com/Laravel-Backpack/CRUD/issues/4605
AFTER - What is happening after this PR?
Auto-open select2 was update to auto-focus, and add style to emulate normal field halo border.
HOW
How did you achieve that, in technical terms?
firstField.trigger('open'); was updated to firstField.trigger('focus');
Is it a breaking change?
Yes, because early update broke many normal fields attribute like "min_rows" as example
How can we test the before & after?
First test, just focus any select2 need to be able to press "space" key and open list, up and down to navigate.
Second, check all this bugs
https://github.com/Laravel-Backpack/PRO/pull/81
https://github.com/Laravel-Backpack/CRUD/issues/4606
https://github.com/Laravel-Backpack/CRUD/issues/4605

Heads-up @jorgetwgroup - I see A LOT of changes to CSS and JS files - maybe you've run npm update or something? Are these changes really necessary? If not, please remove these changes from this PR, that'll make it a lot easier to review and test this.
Thanks! 🙏


Guided Attention Loss

Hi guys, I have been trying guided attention inspired from DC-TTS. Having been added this attention loss the convergence speeds up and at the same step the total loss is even lower than before. So I think it worth trying for all of you. So I opened my mandarin branch for you. Enjoy it.
Unfortunately the guided attention has to be set fixed size for the alignment weights where there is always the max length of the text and the mel frames and therefore the training has to be lagged. Any better idea is welcome!
As for the illustration of guided attention, please refer to https://github.com/mozilla/TTS/issues/13#issuecomment-384276551

This is a very interesting idea.
I do not quite understand why the guided attention mask needs to be fixed size. As I understand, there should be one guided attention loss per sample (not even per batch, since padding is affecting attention loss). In my opinion, it should be something like:

For each training sample alignment:

"Remove" padding and calculate guided attention loss for the sample

Another interesting idea would be to implement a decaying weight for this loss, since guiding the attention becomes less important as the model learns to align.

Your idea sounds brilliant but it is too hard to implement dynamic weighted alignment in tensor with Tensorflow and do alignment operations elementwise. It took me 2 days but I did not work it out. I had to use numpy instead where fixed size is needed.

I can imagine...I am not experienced in Tensorflow so I can't be of much help here. Let's hope for someone to take a closer look to this issue. Thanks anyway for sharing your efforts :)

Before

After

@begeekmyfriend 你好，请问你的attention_loss会有变化吗？我试了一下guide_attention，在我的数据里，attention_loss几乎没什么变化。

Guided attention is aimed to quick alignment by supervising the attention formation. And the total loss is less than that without it.
By the way, please sync my latest commit fix https://github.com/begeekmyfriend/Tacotron-2/commit/4083fdfdf53aba3bad9f3f2d2bc561f4154fd294

Here is my fastest convergence record

Thanks for your sharing. During my training, I set tacotron_teacher_forcing_mode='scheduled', and losses was very low, but without any alignment. With the decreasing of teacher_forcing_ratio, loss grow up quickly. I wonder how you set your training?

@zhangyi02 I am using hyper parameters on my fork.

I checked your hparam, but more confused about the result.
During training, with/without teacher forcing I can always get much smaller loss than your experiment, but no alignment at all. And eval loss was very high, ~1. It doesn't make sense for overfitting, since I got  ~0.3 training loss in the very beginning.
I doubt something must be wrong in my code.
Do you have any idea help me out of here ? And what do you mean checkout dataset ? What should I do ?

@zhangyi02 I am using hyper parameters on my fork. Please checkout whether your dataset is good enough.

Lower loss might be overfitting. The scheduled teacher forcing constraint it. I think you need to checkout your dataset or you can use LJSpeech or other open corpus to verify it. Note that my branch is only for Chinese mandarin and therefore you need to change the dictionary.

guided attention loss use T,N  should represent max_text_length and max_mel_frames of overall dataset or of one batch?

No it is the average value of all samples. You have to estimate it ahead.

No it is the average value of all samples. You have to estimate it ahead.
In  espnet
espnet
and moliza/TTS repo, N,T represent max_text_length and max_mel_frame of a batch


upgrade packages

Description
Motivation
Link to any open issues here
Fixes:

Changes:

Tests included/Docs Updated?

[ ] Included for each change/fix?
[ ] Passing? (Merge will not be approved unless this is checked)
[ ] Docs updated?

Extra Information/Screenshots

reviewing


tentative fix for artifactory

In a weird twist of events, we have moved to artifactory. And helm deploy started failing. The fix for this is trivial. The header  X-JFrog-Art-Api is documented in the official documentation to be needed. Take a look and let me know what you think. thank you

If I read the documentation correctly:

Artifactory's REST API supports these forms of authentication:

Basic authentication using your username and password
Basic authentication using your username and API Key.
Using a dedicated header (X-JFrog-Art-Api) with your API Key.

Upload with API Key authentication should also work via Basic Auth hence with the existing implementation. Did you try that?

you' right. (face-palm). This was indeed a problem at our end. :( closing.


Updated german translation

I went ahead and updated my german translation from version 10p to 11a.

Thanks!


Cloning error

Hey all? i am getting this error when attempting to clone
Cloning into 'byteball'...
error: RPC failed; result=56, HTTP code = 0
fatal: The remote end hung up unexpectedly

If the error is from git, I think it is not a byteball issue.

Resolved thank you


Unicode Encode Error

Hi! thanks for this useful tool.
Trying to use it the tool (macOS Catalina, strings file) it returns this error, any clue to fix it?
Thanks in advance!
Franky

original:"Miscellaneous Arrows" = "Flechas Varios";
translated:"Miscellaneous Arrows" ="Várias setas";
Traceback (most recent call last):
File "/usr/local/bin/translate", line 33, in
main()
File "/usr/local/bin/translate", line 29, in main
mkTranslator().translate_doc(filepath=args.file_path, destination=args.dest_language,sourcelanguage=args.sourcelanguage,channel=args.channel)
File "/Library/Python/2.7/site-packages/mkTranslation/translator.py", line 165, in translate_doc
self.write_tx(filepath,newFile,r"=\s*"(.+?)"\s*;",'="'+'content'+'";',destination,sourcelanguage,channel)
File "/Library/Python/2.7/site-packages/mkTranslation/translator.py", line 116, in write_tx
f.write(txd)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 169: ordinal not in range(128)

Just in case, I was trying to translate from EN to PT using Google Translate.

sam issue here

did you use pip install mkTranslation ?
Then use pip3 install mkTranslation that worked for me

I can confirm that works
note that catelina defaults to pyhton2.7 so be aware which one you pick

You may need sudo -H pip3 install mkTranslation


BSD support

kqueue has been available since the early 2000s and is available on older MacOS systems as well as all BSD variants I am aware of.
This would be a nice fallback for pre-FSnotify Mac's and BSDs

sorry for late reply.
yes, BSD support and fallbacks would be a nice addition, but unfortunately, I don't have much time nor use for them anymore.
PRs are welcomed.

As much as I would love to contribute kqueue support for the BSD's and older Mac's, I don't think it would be healthy for the maintainability for the code.
dmon.h currently tops off at 1622 lines and adding ontop would only make the situation worse.


feat(RingTheory/Localization/FractionRing): fieldEquivOfAlgEquivHom is injective

This PR adds a short lemma stating that fieldEquivOfAlgEquivHom is injective.

Note that there's also galRestrict which this might be able to replace.

I think galRestrict goes the other way (restricting from the fields to the rings, as opposed to extending from the rings to the fields).

Thanks!
bors merge


Coveralls Appveyor Path Issue

Hi
I am trying to get coveralls to work with my appveyor build and have been successful in getting the data posted to appveyor. The issue I have is in coveralls the paths are in windows format which it cannot then parse correctly. I cannot use it to view the lines that are covered on the coveralls website. An example of what happens is shown below.

It looks like coveralls is trying to find the files in the format folder\file instead of folder/file and the HTML path it uses doesn't work.
I have run it with debug and have attached it coveralls debug.txt
Thanks
Jordan

Closing as a sort-of-duplicate of #159, but I do appreciate the report!

@jborean93 @RazerM @thatslch this issue should now be resolved as of release 1.5.0.


where is the Prior Knowledge?

Great work!
Buy the way, I don’t know wether I missed some important information in this paper, it seems that there are no details about  the Prior Knowledge (a prior knowledge base (ICP))?
Becides, "Later we will show that our model can accurately generate the PKG, i.e., the commonsense that is captured from perceptions during training."
I don’t seem to find the corresponding part.
thanks again :)

Thank you @hackerchenzhuo for your interest! :) Sorry for the late response.
The prior knowledge base is a split of triples from Visual Genome. So we take the full VG and use 90% (or 99%) of the triples as a separate knowledge base.
Table 1, Schemata - PKG shows the results for predicting the PKG. You can find the details in bullet point 3 of the Evaluation section.
Please let me know if this still does not answer your question so I can elaborate further.


Update version for the next release (v0.5.1)

Changes:

#119
#116
#118
#113

All the changes related to release v0.5.1 were merged into v0.5.0, I spotted a problem that prevented releasing a new release with the same tag. Since the v0.5.0 wasn't completed released, I removed the tag from the remote and regenerated it again. Now containing, of course, all the PR's merged for the v0.5.1.


Tokenization changes when a trailing space is added.

I found a puzzling thing. If you tokenize たてまつ by itself you get a single token たてまつる. However, if you add a trailing space to the string, you get two tokens たてる and まつ.
Does this make any sense, or is it a bug?

Hi,
I try to reproduce it on my configuration and I get たてまつ...
Check if you don't have an entry in your synonym or dictionary file.
If you don't have entries in your files can you provide more information about the analyzer you use.
Hope it can help.

I reproduce it. And Lucene's Kuromoji is same behavior.
curl -XGET "http://localhost:9200/_analyze?analyzer=kuromoji&text=%e3%81%9f%e3%81%a6%e3%81%be%e3%81%a4"
{
   "tokens": [
      {
         "token": "たてまつる",
         "start_offset": 0,
         "end_offset": 4,
         "type": "word",
         "position": 1
      }
   ]
}

curl -XGET "http://localhost:9200/_analyze?analyzer=kuromoji&text=%e3%81%9f%e3%81%a6%e3%81%be%e3%81%a4%20"

{
   "tokens": [
      {
         "token": "たてる",
         "start_offset": 0,
         "end_offset": 2,
         "type": "word",
         "position": 1
      },
      {
         "token": "まつ",
         "start_offset": 2,
         "end_offset": 4,
         "type": "word",
         "position": 2
      }
   ]
}

As we just expose here a Lucene feature, I'd suggest to open an issue on Lucene side if it makes sense to fix that.
Closing here as I don't think the plugin code itself is buggy here.


Add 'how to organize HTML code for better SEO' section

in the next new update, if it is possible to add  new table of contents or a section that explains how to structure and organize the HTML code for  better SEO results it would be really helpful
like what should the HTML code contains
how to order it
what should be avoided
what is the best practice
what is recommended to use
how to use role or aria-* atts
etc....

I feel like SEO is a bit outside the scope of this guide, but there might be some value to roles and ARIA attributes.

I do not think so, because the guide explains how to organize CSS and HTML code  so also if a new section is added explaining how to organize the code for better SEO it would still relevant,
and I think adding something for SEO would make the guide the best content online explaining such things because it is written by someone who has many years of experience working with things like that.


CSS classes for Grid

Description
Add CSS classes for grids just like Tailwind. These will need to be custom rolled.
Links
No response
Additional context
No response

Closing due to #175 since Tailwind has grids.


Fixes resourceServiceBuilder to work on Windows

Fixes #5240
I have tested the fix on Windows and Linux, and it works.

@satorg Any idea, when the new release will be :) ?

@mabasic you can use the snapshot version: 0.23.16-266-5c8acee-SNAPSHOT.
Make sure to add:
ThisBuild / resolvers += Resolver.sonatypeOssRepos("snapshots")


Folds

The way it is right now the minimal definition for Foldable is the right fold.
This came from the old project, emulating Haskell but here in .NET, with strict evaluation we don't have any benefit of using a right fold as main foldable function.
It would probably make more sense to derive other functions from the left fold, but I was thinking that even more sense would make to derive everything from ToSeq so we can have laziness and if we're lucky derive some lazy functions from that. Another benefit is that IEnumerable is everywhere in .NET collections so we can hope to get more methods derived for free. Any thoughts?

Fixed in 2a49daf4347338f8e8e0fca19fe73cd0d94fe207


add notification monkey-patch, closes #38

Any time a new Notification is constructed, atom is notified and the badge is displayed.
I wasn't able to test this much, so LMK how it works for you.

This is really good!

Awesome, I've tested it on http://www.bennish.net/web-notifications.html and it appears to work, thanks!


HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER files for Apache HAWQ binary release

This commit includes:

The LICENSE, NOTICE, and DISCLAIMER files for Apache HAWQ c/c++ components for the binary release.
The build process to add the LICENSE, NOTICE, and DISCLAIMER files in Apache HAWQ binary package.

@rvs, @edespino, @paul-guo- @radarwave, please review and let us know your feedback.

@huor I'm a bit confused -- it appears that both LICENSE and NOTICE files you added are copies of what already exists in the repo. For the binary distribution we need a much more expanded set (as per your Google doc spreadsheet) right?

@rvs, thanks for the review and feedback.
You are right. We expand the LICENSE for source release by adding extra dependency to get that for binary release.
Please let us know your comments for further refinement. Thanks.

@rvs, we have separate rpm packages for hawq c/c++ components, and java components (pxf, ranger).
├── apache-hawq-<IP_ADDRESS>-el7.x86_64.rpm
├── apache-tomcat-7.0.62-el6.noarch.rpm
├── hawq-ranger-plugin-<IP_ADDRESS>-1.el7.centos.noarch.rpm
├── pxf-<IP_ADDRESS>-1.el6.noarch.rpm
├── pxf-hbase-<IP_ADDRESS>-1.el6.noarch.rpm
├── pxf-hdfs-<IP_ADDRESS>-1.el6.noarch.rpm
├── pxf-hive-<IP_ADDRESS>-1.el6.noarch.rpm
├── pxf-jdbc-<IP_ADDRESS>-1.el6.noarch.rpm
├── pxf-json-<IP_ADDRESS>-1.el6.noarch.rpm
└── pxf-service-<IP_ADDRESS>-1.el6.noarch.rpm

It contains LICENSE, NOTICE, and DISCLAIMER files for hawq c/c++ components in this PR, i.e., apache-hawq-<IP_ADDRESS>-el7.x86_64.rpm.
For pxf (pxf-*.rpm, apache-tomcat-7.0.62-el6.noarch.rpm) and ranger (hawq-ranger-plugin-<IP_ADDRESS>-1.el7.centos.noarch.rpm), there are incompatible license and we will do them in separate PR once your feedback for pxf and ranger part is available.

LGTM!

LGTM +1

Thanks @edespino for your feedback. I have bundled the license/* in hawq binary release.

@huor - As this has been committed, can you please close this PR now?  Thanks buddy.

@edespino, closing the PR. Thanks for the notification.


Assembly files

Some assembly files have comments, some loop for ever, on my pi 4 the arm assembly doesn’t work so Edit: see #1010, the others might need tested and a lot don’t even print “Hello World” (see #999)

#1003 removes comments.


Disable header copying

Recently, XcodeGen gained the ability to copy files for headers. This
behavior doesn't really add value for XCHammer and slows down project
gen for some cases by ~ 1 order of mangitude.
Fixes #58

The travis result is close approximation to the perf boost I'm seeing locally 👍
Result of run_perf on this branch:
Tulsi: ** Completed bazel_extract_source_info in 28.9929s
Tulsi: ** Completed extract_source_info in 29.7331s
XCHammer: ** Completed read_aspects in 38.1530s
XCHammer: ** Completed query_genfiles in 2.5339s
XCHammer: Generating project Frankenstein
XCHammer: ** Completed compute_deps_hash in 0.0025s
XCHammer: Converting to XcodeGen specification
XCHammer: ** Completed convert_targets in 4.0394s
XCHammer: Writing project
XCHammer: ** Completed xcode_gen in 28.0237s
XCHammer: ** Completed make_schemes in 0.0302s
XCHammer: ** Completed generate_project in 32.1317s
XCHammer: Replacing old project
XCHammer: Overwrote project

Result of run_perf on previous commit:
Tulsi: ** Completed bazel_extract_source_info in 27.3231s
Tulsi: ** Completed extract_source_info in 28.1009s
XCHammer: ** Completed read_aspects in 35.8080s
XCHammer: ** Completed query_genfiles in 2.7078s
XCHammer: Generating project Frankenstein
XCHammer: ** Completed compute_deps_hash in 0.0027s
XCHammer: Converting to XcodeGen specification
XCHammer: ** Completed convert_targets in 3.7376s
XCHammer: Writing project
XCHammer: ** Completed xcode_gen in 422.2108s
XCHammer: ** Completed make_schemes in 0.0330s
XCHammer: ** Completed generate_project in 426.0155s
XCHammer: Replacing old project
XCHammer: Overwrote project


[MINOR][SS][DOC] Fix wrong Python code sample

What changes were proposed in this pull request?
This patch fixes wrong Python code sample for doc.
Why are the changes needed?
Sample code is wrong.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Doc only.

Can one of the admins verify this patch?

+1, LGTM. Merging to master, 3.1, 3.0.
Thank you @Hisssy , and @viirya for your review.


Generalize vfs.rs test to address fsevents timing-dependent behavior.

Generalize tests/vfs.rs processing to address wildly-varying timing-dependent behavior from fsevents (i.e. on Mac OS X).
Fix #734

Yeah, this seems like a pretty reliable approach to me. Well, pretty reliable compared to the status quo. I am a bit concerned that, if the test receives fewer than max_count events it will have to wait the whole timeout, but that should be solved by not running VFS tests with the rest of the testsuite, which we will achieve when moving vfs to a dedicated repo.
bors r!

bors r+

I am a bit concerned that, if the test receives fewer than max_count events it will have to wait the whole timeout

This is a good point. I should probably put a if cfg!(macos) { 7 } else { 0 } in the max event count here:
https://github.com/rust-analyzer/rust-analyzer/blob/da04eb3770eb14dadb6a2904269fe1ea0aef987f/crates/ra_vfs/tests/vfs.rs#L86

(did the above in PR #838)


Some TCK test assertions do not report the expected versus the actual value

For example TckTests#joinWithOneResource. Reporting this information provides the developer with a quicker route to tracking down the root cause.
Remark: this issue overlaps with issue #314 . However the fix for issue #314 (pr #315 ) still does not show the expected versus the actual values.

I have marked this issue as "Waiting for feedback" because issue #314 invalidate the current issue.

PR #315 fixed this issue so I am closing it as done.

@mmusgrov the PR is not merged yet so don't close the issue, please.

Yes but that PR fixes issue #314 which subsumes issue #296. If you take a look at #314 and also its PR (#315) you will see that the current issue is no longer required. Can you re-close this issue please.

Sorry if I misunderstood. The PR contains a reference to this issue "fixes #296" in the description and it will close this issue when the PR is merged as I believe it correctly should.

So I made it explicit in the issue description. We don't want add extra work by having multiple issues that cover the same requirement.

@mmusgrov I am still not following you. "Remark: this issue overlaps with issue #314 . However the fix for issue #314 (pr #315 ) still does not show the expected versus the actual values." but as you want.
@mmusgrov closed this as a duplicate of #314


_oc.Me.GetProductAsync(id, user.AccessToken); throwing Object not found

When in the buyer app, I click on a product and this is the network error I receive:
Data: "Object reference not set to an instance of an object."
ErrorCode: "InternalServerError"
Message: "Unknown error has occured."

Digging in a bit, it looks like like _oc.Me.GetProductAsync(id, user.AccessToken); is is not getting the product even though it shows up with the https://[middleware]/me/products query.
This is a bare bones, single product catalog with no additional properties - could that be it? Please let me know if you need more details.

Which buyer was being used? My assumption is that user didn't have permissions to read products, but I can say for sure once I know which buyer. Thanks!

Is this resolved after nuking the old org and creating it again? @naspinski-emergent-software

yes, no longer an issue

closing


[release/8.0] Ensure xUnit project is in .sln file & fix hyphen in name

This is a manual backport of #3959 for GA that only includes the changes for the xUnit scenarios that was already approved in shiproom.
Microsoft Reviewers: Open in CodeFlow

@danmoseley the change to use the TestFramework symbol is only in main, not in release/8.0, as it was introduced to support the MSTest and NUnit variants.


After closing all windows, File > Open doesn't show Finder

Mac OS X 10.12.5
atom --version:
Atom    : 1.18.0
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0
Steps to Reproduce

Launch Atom as normal. Last project or new window will be in view.
Close window (don't exit out of Atom)
Go to File, select Open

Expected behavior: Finder window opens, allowing for new file selection
Actual behavior: No Finder window appears
Reproduces how often: 100%

Workaround right now is File > New Window, then File > Open

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #12508. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


d9937fc Breaks League of Legends constraints on Double Monitor

Hyprland Version
d9937fcdba978af4f36be6cb20311e08f43841f5
Bug or Regression?
Regression
Description
When using a double monitor, starting the game on the one in the right makes the mouse be constrained in a little rectangular window to the right making it unplayable. Worked fine before, works fine in gamescope but it's annoying/partially unusable since cursor icons are rendered half way, the window is unmovable since it grabs the mouse and the game needs to be started from a launcher (client).
EDIT: It also works fine if I set the secondary monitor to -1600 instead of 0. (I used to have my primary one at +1600,0)
Works fine on a single monitor.
How to reproduce
Start the game, focus it, the mouse is constrained incorrectly.
Crash reports, logs, images, videos
Monitor Config:
monitor=HDMI-A-1, 1600x900, 0x0, 1
monitor=DP-3<EMAIL_ADDRESS>1600x0, 1 (The one where the game is launched)
Client:
Window 55c66ed4a830 -> League of Legends (TM) Client:
mapped: 1
hidden: 0
at: 1600,0
size: 1920,1080
workspace: 2 (2)
floating: 0
monitor: 1
class: league of legends.exe
title: League of Legends (TM) Client
initialClass: league of legends.exe
initialTitle: League of Legends (TM) Client
pid: 17625
xwayland: 1
pinned: 0
fullscreen: 1
fullscreenmode: 0
fakefullscreen: 0
grouped: 0
swallowing: 0
https://github.com/hyprwm/Hyprland/assets/10902117/efb6d632-676c-4da7-a089-3078db704e70

thats good, we dont want people playing league of legends

love your MOTD (Message of the day) :)

thats good, we dont want people playing league of legends

Still, it's something that regressed after a commit, and only under certain circumstances (secondary monitor on a positive offset), I'm sure it's not limited to League of Legends, it's just the first issue I've encountered so I think it's worth investigating it.

y'all need to understand that league of legends misbehaving is a feature, not a bug

please test #3381

#3381 Fixed it on my end, I'll wait for other feedback before closing it


Reimplement VecKinds as DMTypes

After removing them for #180, we reimplement them again.
By including them into the dmtype hierarchy, we can have typevariables for veckinds.
First commit in 9fd73c27c1420df9253b1cedd5fb3b2e50b182b1.

We change stuff again slightly, and include matrices in the hierarchy.
Implementation: 6c446391b7257835fed324deab9a76e6737ba0bd.


how sird work with routes file

Hello，I want write the route in conf/routes, when I add "routes" file under /conf and write :
GET			/                      controllers.Application.index
in" routes" file, but this route is not effect, how to sird work with "routes" file?
Thanks!
Shifu

If you want to use the router file, just follow this example:
https://www.playframework.com/documentation/2.5.x/ScalaCompileTimeDependencyInjection#providing-a-router
I don't think you can mix Sird with conf/routes file, you have to choose one approach or the other. If you created a conf/routes file, you should have a access to the generated class router.Routes. Just replace val router = Router.from with val router = new Routes(...) in AppLoader.
I find it easier to use Sird with Compile Time Injection, but that might just be a matter of taste.

Thanks！


Gemma.cpp on the Android arm64-v8a

I have made Gemma executable to run on Android arm64-v8a with below option.

cmake -DCMAKE_TOOLCHAIN_FILE=/usr/lib/android-sdk/ndk/25.1.8937393/build/cmake/android.toolchain.cmake .

And it runs on my Android.
However there is error for reading weights.

/# gemma --tokenizer tokenizer.spm --compressed_weights 2b-it-sfp.sbs --model 2b-it
cache.path.c_str() : 2b-it-sfp.sbs
2b-it-sfp.sbs:3163184640
BlobReader::Open open
BlobReader::Open Read
BlobReader::Open Allocate
3163184640, 0
Cached compressed weights does not exist yet (code 155), compressing weights and creating file: 2b-it-sfp.sbs.

There is a failure in the "BlobReader::Open" function, on the line "blob_store_->CheckValidity(IO::FileSize(filename))".
The expected value of "IO::FileSize(filename)" is<PHONE_NUMBER>, but it is currently returning 0.
However, before the line "hwy::CopySameSize(&bs, blob_store_.get())" in the "BlobReader::Open" function, the "IO::FileSize(filename)" is functioning correctly.
Anyway,
The comments in https://github.com/google/gemma.cpp/issues/21, it should work well.
Could you help me to figure out what I missed?

Hi, the error codes are simply line numbers, but it looks like your code is quite different.
On both main and dev, if (file_size_ != file_size) return __LINE__; should be line 218, not 155. Is the code modified?
I think the issue is that off_t on Android defaults to 32-bit. You can build with -D_FILE_OFFSET_BITS=64 which fixes it for 15c and above. We'll also change to lseek64, thanks for pointing this out :)

I think this is fixed now, please reopen if not.

It works well!!
But sentencepiece with add_definitions(-D_FILE_OFFSET_BITS=64) has an error.

/usr/lib/android-sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/c++/v1/fstream:968:9: error: use of undeclared identifier 'fseeko'
if (fseeko(_file, __sp, SEEK_SET))

I put the definition like this

FetchContent_Declare(sentencepiece GIT_REPOSITORY https://github.com/google/sentencepiece GIT_TAG 53de76561cfc149d3c01037f0595669ad32a5e7c)
FetchContent_MakeAvailable(sentencepiece)
add_definitions(-D_FILE_OFFSET_BITS=64)
FetchContent_Declare(highway GIT_REPOSITORY https://github.com/google/highway.git GIT_TAG da250571a45826b21eebbddc1e50d0c1137dee5f)
FetchContent_MakeAvailable(highway)

Thank you very much!

Please help us out by searching for such error messages on the web :)
This one is mentioned in https://developer.android.com/ndk/guides/common-problems, it seems we have to raise minSdkVersion to 24.


Patch the OS-level packages and remove unneeded dependencies

This is to reduce the vulnerabilities.
Note this does not address all the fixable vulnerabilities.

Let us wait for the base image to pick up these vulnerability fixes.


[Model][LoRA]LoRA support added for MolmoForCausalLM

[Model][LoRA]LoRA support added for MolmoForCausalLM
LoRA supported for inference in MolmoForCausalLM
Need some help with verifying this works correctly since my own tests revealed the same results for base_model and base_model+ lora.
ping @jeejeelee
FIX #11431

i might have done goofed by syncing my fork and pushing to the PR branch

@ayylemao  could you plz address the branch conflict ?

Thank you for your review.
I will get back to it after christmas!

@ayylemao I've added modules with LoRA support. Could you test if it generates reasonable results?

@ayylemao I've added modules with LoRA support. Could you test if it generates reasonable results?

After testing i still get the same results for the base model and base_model+lora when serving via vllm serve.
I think my lora adapter still does not get applied correctly, even though when evaluating via transformers+peft it works as expected.
I am not sure how to test more accuratly if the lora adapters get correctly applied or not beyond just comparing the actual model output.
Do you have any idea what might be the issue or how to pinpoint further?

@ayylemao I've added modules with LoRA support. Could you test if it generates reasonable results?

@jeejeelee After testing i still get the same results for the base model and base_model+lora when serving via vllm serve. I think my lora adapter still does not get applied correctly, even though when evaluating via transformers+peft it works as expected.
I am not sure how to test more accuratly if the lora adapters get correctly applied or not beyond just comparing the actual model output. Do you have any idea what might be the issue or how to pinpoint further?

I'm training a LoRA model for this model and will test it tomorrow.

@ayylemao I've added modules with LoRA support. Could you test if it generates reasonable results?

@jeejeelee After testing i still get the same results for the base model and base_model+lora when serving via vllm serve. I think my lora adapter still does not get applied correctly, even though when evaluating via transformers+peft it works as expected.
I am not sure how to test more accuratly if the lora adapters get correctly applied or not beyond just comparing the actual model output. Do you have any idea what might be the issue or how to pinpoint further?

I'm training a LoRA model for this model and will test it tomorrow.

@ayylemao  After merging with https://github.com/vllm-project/vllm/pull/11551, when testing 100 samples, 99 generated results matched exactly with the transformers output. The remaining one also produced a reasonable result.

@ayylemao I've added modules with LoRA support. Could you test if it generates reasonable results?

@jeejeelee After testing i still get the same results for the base model and base_model+lora when serving via vllm serve. I think my lora adapter still does not get applied correctly, even though when evaluating via transformers+peft it works as expected.
I am not sure how to test more accuratly if the lora adapters get correctly applied or not beyond just comparing the actual model output. Do you have any idea what might be the issue or how to pinpoint further?

I'm training a LoRA model for this model and will test it tomorrow.

@ayylemao After merging with #11551, when testing 100 samples, 99 generated results matched exactly with the transformers output. The remaining one also produced a reasonable result.

Thank you for testing.
Could you share the lora modules you targeted? Or directly your Peft Config? It would help me a lot.

@ayylemao  This is a known issue and is not related to this PR.


Cursor Pagination - Invalid cursor value

Hi, I tried playing a little with cursor pagination, but whatever I tried I just get this error every time:

{
"detail": "Invalid cursor value"
}

Here is my code snippet for simple endpoint:
import typing
from contextlib import asynccontextmanager

from alchemical.aio import Alchemical
from fastapi import Depends, FastAPI
from fastapi_pagination import add_pagination
from fastapi_pagination.cursor import CursorPage
from fastapi_pagination.ext.sqlalchemy import paginate
from pydantic import BaseModel
from sqlalchemy import Column, Integer, String, select
from sqlalchemy.ext.asyncio import AsyncSession

db = Alchemical("sqlite:///test.db")

class User(db.Model):
    __tablename__ = "users"

    id = Column(Integer, primary_key=True)
    name = Column(String)

class UserSchema(BaseModel):
    id: int
    name: str

async def get_session() -> typing.AsyncIterator[AsyncSession]:
    async with db.Session() as session:
        yield session

@asynccontextmanager
async def lifespan(_app: FastAPI):
    await db.create_all()
    async with db.begin() as session:
        session.add_all([User(name=str(i)) for i in range(50)])
    yield
    await db.drop_all()

app = FastAPI(lifespan=lifespan)
add_pagination(app)

@app.get("/users", response_model=CursorPage[UserSchema])
async def get_users(session: AsyncSession = Depends(get_session)):
    return paginate(session, select(User).order_by(User.id))

Hi @Gamattowicz,
What version of fastapi-pagination are you using?
I can run you snippet without any error (you missed await in one place):
import typing
from contextlib import asynccontextmanager

from alchemical.aio import Alchemical
from fastapi import Depends, FastAPI
from pydantic import BaseModel
from sqlalchemy import Column, Integer, String, select
from sqlalchemy.ext.asyncio import AsyncSession

from fastapi_pagination import add_pagination
from fastapi_pagination.cursor import CursorPage
from fastapi_pagination.ext.sqlalchemy import paginate

db = Alchemical("sqlite:///test.db")

class User(db.Model):
    __tablename__ = "users"

    id = Column(Integer, primary_key=True)
    name = Column(String)

class UserSchema(BaseModel):
    id: int
    name: str

async def get_session() -> typing.AsyncIterator[AsyncSession]:
    async with db.Session() as session:
        yield session

@asynccontextmanager
async def lifespan(_app: FastAPI):
    await db.create_all()
    async with db.begin() as session:
        session.add_all([User(name=str(i)) for i in range(50)])
    yield
    await db.drop_all()

app = FastAPI(lifespan=lifespan)
add_pagination(app)

@app.get("/users", response_model=CursorPage[UserSchema])
async def get_users(session: AsyncSession = Depends(get_session)):
    return await paginate(session, select(User).order_by(User.id))

if __name__ == "__main__":
    import uvicorn

    uvicorn.run(app)

curl -X 'GET' \
  'http://localhost:8000/users?cursor=Pmk6MTA%253D&size=10' \
  -H 'accept: application/json'

{
  "items": [
    {
      "id": 11,
      "name": "10"
    },
    {
      "id": 12,
      "name": "11"
    },
    {
      "id": 13,
      "name": "12"
    },
    {
      "id": 14,
      "name": "13"
    },
    {
      "id": 15,
      "name": "14"
    },
    {
      "id": 16,
      "name": "15"
    },
    {
      "id": 17,
      "name": "16"
    },
    {
      "id": 18,
      "name": "17"
    },
    {
      "id": 19,
      "name": "18"
    },
    {
      "id": 20,
      "name": "19"
    }
  ],
  "total": null,
  "current_page": "Pmk6MTA%3D",
  "current_page_backwards": "PGk6MjE%3D",
  "previous_page": "PGk6MTE%3D",
  "next_page": "Pmk6MjA%3D"
}

I still get the same error. I use fastapi-pagination 0.12.17. The python version is 3.12.1.
This is a list all of packages or libraries installed in the virtual environment in which I run applications:
aiosqlite==0.19.0
annotated-types==0.6.0
anyio==4.2.0
click==8.1.7
colorama==0.4.6
databases==0.8.0
fastapi==0.109.0
fastapi-pagination==0.12.17
greenlet==3.0.3
h11==0.14.0
idna==3.6
pydantic==2.5.3
pydantic_core==2.14.6
sniffio==1.3.0
SQLAlchemy==1.4.51
starlette==0.35.1
typing_extensions==4.9.0
uvicorn==0.25.0

What version of alchemical are you using?
When I try to run your code snippet with the library versions that you provided I am receiving this error:
Traceback (most recent call last):
  File "/mnt/d/projects/fastapi-pagination/temp.py", line 4, in <module>
    from alchemical.aio import Alchemical
  File "/home/uriyyo/.cache/pypoetry/virtualenvs/fastapi-pagination-qCLVCiBY-py3.11/lib/python3.11/site-packages/alchemical/__init__.py", line 1, in <module>
    from .core import Alchemical, Model  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/uriyyo/.cache/pypoetry/virtualenvs/fastapi-pagination-qCLVCiBY-py3.11/lib/python3.11/site-packages/alchemical/core.py", line 6, in <module>
    from sqlalchemy.orm import DeclarativeBase, sessionmaker
ImportError: cannot import name 'DeclarativeBase' from 'sqlalchemy.orm' (/home/uriyyo/.cache/pypoetry/virtualenvs/fastapi-pagination-qCLVCiBY-py3.11/lib/python3.11/site-packages/sqlalchemy/orm/__init__.py

My bad. I use Alchemical 1.0.1.
And its updated list (with added Alchemical and SQLAlchemy versions):
aiosqlite==0.19.0
alchemical==1.0.1
annotated-types==0.6.0
anyio==4.2.0
click==8.1.7
colorama==0.4.6
databases==0.8.0
fastapi==0.109.0
fastapi-pagination==0.12.17
greenlet==3.0.3
h11==0.14.0
idna==3.6
pydantic==2.5.3
pydantic_core==2.14.6
sniffio==1.3.0
SQLAlchemy==2.0.27
starlette==0.35.1
typing_extensions==4.9.0
uvicorn==0.25.0

Sure.
This is curl:
curl -X 'GET' \
  'http://<IP_ADDRESS>:8000/users?cursor=5&size=10' \
  -H 'accept: application/json'

And this is Response body with 400 status code:
{
"detail": "Invalid cursor value"
}

It's not the correct cursor value, you should use the value that the endpoint will gonna return to you.
First, you need to call endpoint:
curl -X 'GET' \
  'http://localhost:8000/users?size=50' \
  -H 'accept: application/json'

In response you will see cursor values:
{
  "items": [
    {
      "id": 51,
      "name": "0"
    },
    ...
    {
      "id": 100,
      "name": "49"
    }
  ],
  "total": null,
  "current_page": "Pg%3D%3D",
  "current_page_backwards": "PGk6MTE%3D",
  "previous_page": null,
  "next_page": "Pmk6MTA%3D"
}

Now you can take next_page value and use it as the cursor value when you call the endpoint:
curl -X 'GET' \
  'http://localhost:8000/users?cursor=Pmk6MTA%3D&size=10' \
  -H 'accept: application/json'

And then response will look like this:
{
  "items": [
    {
      "id": 11,
      "name": "10"
    },
    ...
    {
      "id": 20,
      "name": "19"
    }
  ],
  "total": null,
  "current_page": "Pmk6MTA%3D",
  "current_page_backwards": "PGk6MjE%3D",
  "previous_page": "PGk6MTE%3D",
  "next_page": "Pmk6MjA%3D"
}

You can take a look at the example - https://github.com/uriyyo/fastapi-pagination/blob/main/examples/cursor/app.py

I had to install also sqlakeyset, but now it's working. Thank you for your help and patience.

Great, happy to hear that!


[SPARK-46929][CORE][CONNECT][SS] Use ThreadUtils.shutdown to close thread pools

What changes were proposed in this pull request?
This PR propose use ThreadUtils.shutdown to close thread pools.
Why are the changes needed?
ThreadUtils provided the shutdown to close thread pools. ThreadUtils wraps common logic to shutdown thread pools.
We should use ThreadUtils.shutdown to close the thread pool.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
'No'.

ping @srowen @dongjoon-hyun @LuciferYang

cc @zhengruifeng

Merged to master

@srowen Thank you!


Write Design Guidelines Intro (principles)

Do we feel like this is complete enough now? I recall you making a commit to the docs.

This is now complete.


docs(plugins): revise DefinePlugin

Closes https://github.com/webpack/webpack.js.org/issues/5087

cc @matthias-ccri Do you think the revised version is appropriate?

Hi @chenxsan thanks for doing this! I see the phrase "arbitrary code" which at least to me is very similar to "arbitrary code execution", which is a bad thing in the area of software vulnerabilities. That's just my perspective, but it might be good for the docs to say "values or expressions" instead of "arbitrary code".
The `DefinePlugin` allows you to replace variables in your code with other values or expressions at **compile** time.

I see the previous effort to emphasize "at compile time", which I missed previously, but it reads like "this plugin does stuff at compile time" which is true for everything webpack, since webpack is a compiler. It can be removed:
The `DefinePlugin` allows you to replace variables in your code with other values or expressions.

And it could be even more direct:
The `DefinePlugin` replaces variables in your code with other values or expressions.

@matthias-ccri Actually webpack does have runtime code running in the browser, and I believe plugins can contribute to that as well.
What about:
The `DefinePlugin` replaces variables in your code with other values or expressions at **compile** time.

That looks good to me!

@matthias-ccri Thank you, I'm grateful for your help.


feat: done first beta version

只做了 getOAuthToken api

@Zxilly @nodece plz review

I left some suggestions:

Add eslint to check this codebase.
Add prettier to format this codebase.
Add husky and lint-staged to check and format your commit.

It seems that your PR is currently in WIP, you can convert this PR to draft status.

Sorry, I missing take closed this PR, just now.
Pls review new PR: https://github.com/casdoor/casdoor-nodejs-sdk/pull/3


Fix: Error thrown when fetch argument is not a string or a Request object.

Hello,
When using fetch and the first parameter of fetch is undefined, raven is throwing an error:
> fetch(undefined)
< Uncaught TypeError: Cannot read property 'url' of undefined

This fix covers the cases where the first arg of fetch is neither a string or a Request object.

We also need a test case for this scenario

Hello, @kamilogorek ,
I've made the requested changes and updated the pull request.
Thank you!

Thanks!

@vierno so, I agree Raven shouldn't choke when it gets an argument like this, but I'm curious if there's any actual defined behavior for fetch(123) or fetch(undefined)? The browser lets me do it, but it's not clear what's actually happening.

@benvinegar , the browser uses the string representation of the argument as the url. So fetch(undefined) gives the same result of fetch("undefined")

Unfortunately this test is failing on IE10/11/Safari10, but I'll try to fix it. Unfortunately, our setup at the moment doesn't allow to run SauceLabs tests for non-organization members. We're working on fixing this setup as well.

the browser uses the string representation of the argument as the url. So fetch(undefined) gives the same result of fetch("undefined")

@vierno – Ah, thanks for the clarification.


Change main .py shebang line

I wonder if you would mind changing sushi.py's shebang line to #!/usr/bin/env python2.
In any system that has python3 as it's main python interpreter this error will be thrown as things are right now:
Traceback (most recent call last):
  File "/usr/local/bin/sushi", line 9, in <module>
    from itertools import takewhile, izip, chain
ImportError: cannot import name 'izip'

Done.


Automated cherry pick of #3492: fix: 避免version输出不正确

Cherry pick of #3492 on release/2.10.0.
#3492: fix: 避免version输出不正确

/lgtm

/approve


[5.0] [DeclChecker] Don't try to derive conformances for invalid enums

If one of the cases is invalid, let's mark parent enum as invalid
as well, and avoid trying to derive any conformances related to it.
Resolves: rdar://problem/36989792

@swift-ci please clean smoke test Linux platform

@shahmishal Looks like there a problem with 5.0 branch PR testing on Linux "Foundation/Data.swift:998:15: error: type 'Data' does not conform to protocol 'Collection'"

Can you file a bug on Jira? We are seeing this on regular CI jobs too.
https://ci.swift.org/view/swift-5.0-branch/job/oss-swift-5.0-incremental-RA-linux-ubuntu-16_04/139/console
This started on Feb 1st:
Git (git git@github.com:apple/swift.git)
[TypeChecker] Mark perf test-case for rdar://problem/22282851 as fast (detail)

Git (git git@github.com:apple/swift-corelibs-foundation.git)
Apply same CountableRange changes as in apple/swift#12913 (detail)
fix copypasta error (detail)
Additional remove(integersIn:) (detail)
Minor changes for consistency with SDK version (detail)

@gparker42 Have you seen this?

@shahmishal I've created https://bugs.swift.org/browse/SR-6933

@swift-ci please clean smoke test Linux platform

@swift-ci please clean smoke test Linux platform

@airspeedswift Looks like now it fails with:
Foundation/IndexSet.swift:466:48: error: cannot convert value of type 'CountableRange<Int>' to expected argument type 'Range<Int>'
            return Index(value: value, extent: extent, rangeIndex: rangeIndex, rangeCount: rangeCount)
                                               ^~~~~~
Foundation/IndexSet.swift:929:39: error: value of type 'Range<IndexSet.Element>' (aka 'Range<Int>') has no member 'startIndex'
            try rangeContainer.encode(range.startIndex, forKey: .location)
                                      ^~~~~ ~~~~~~~~~~

@swift-ci please smoke test Linux platform


Project Page Navigation Idea

Issue Type:
[  ] Bug Report
[x ]  Feature Request
[  ] Documentaion
Describe the bug
As for now, we can go on each project page separately but can we add the link of the remaining two pages as a button below the content of each page this will help for quick navigation !

@himanshu007-creator  Please have a look here

I would like to contribute here. Can you assign me and just guide me a bit. I am new to open source.

@himanshu007-creator

@himanshu007-creator

Please assign me the task

I have almost completed it.

I want to create a pull request. Am ain't able to do it as you have not yet assigned me the task.

@rohan-kulkarni-25 and @himanshu007-creator I have done the work. It is complete. I want t create a PR. Please assign me the task.

SFC-foundations-master- corrected.pdf
Here is the ss of the thing I did. I did it in all the 3 project pages. Linked them properly.


Issue for accessing hr/v1/corporate-contacts

When we are trying to access : hr/v1/corporate-contacts in it showing error :
"scope for this service is invalid or undefined"
meanwhile if we try to access hr/v2/workers its working for us.

Hi,
Can you provide the correlation ID of the error to us?
Thanks,
Kirthi

Correlation Id is : 50690f5b-96914d17-b3a0639893bed0e5
With error code 403, forbidden

We dont see any logs with the correlation ID you have provided. Are you an existing client to ADP?

Yes, we are existing client for ADP.
Please find attached screenshot for your reference.

We see that you do not have access to this API due to which you are seeing this error. Please reach out to your ADP Account Representative who has initially provided you with API access for adding this scope.

We are having Workforce Now as ADP product, looks like it doesn't support call to "hr/v1/corporate-contacts" end point as per documentation we have received, to filter employee based on there name which end point we should be using.
Thank You

Hi,
As of now there is no API which supports a filter to to retrieve a worker based on their name.
Thanks,
Kirthi


[Bug Report] Transformer_lens should be pinned to 1.1.1 for Attribution_Patching demo

Describe the bug
If I click "run all" on this notebook:
https://colab.research.google.com/github/neelnanda-io/TransformerLens/blob/main/demos/Attribution_Patching_Demo.ipynb
It fails with this error:
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
[<ipython-input-19-a9774221fd88>](https://localhost:8080/#) in <cell line: 19>()
     17     return value.item(), ActivationCache(cache, model), ActivationCache(grad_cache, model)
     18
---> 19 clean_value, clean_cache, clean_grad_cache = get_cache_fwd_and_bwd(model, clean_tokens, ioi_metric)
     20 print("Clean Value:", clean_value)
     21 print("Clean Activations Cached:", len(clean_cache))

3 frames
[/usr/local/lib/python3.10/dist-packages/transformer_lens/HookedTransformer.py](https://localhost:8080/#) in check_hooks_to_add(self, hook_point, hook_point_name, hook, dir, is_permanent, prepend)
    233             ), f"Cannot add hook {hook_point_name} if use_hook_mlp_in is False"
    234         if hook_point_name.endswith("attn_in"):
--> 235             assert (
    236                 self.cfg.use_attn_in
    237             ), f"Cannot add hook {hook_point_name} if use_attn_in is False"

AssertionError: Cannot add hook blocks.0.hook_attn_in if use_attn_in is False

The notebook was made in this commit on Feb 4 2023. On Feb 4, 2023, version 1.1.1 was released. Pinning transformer_lens to 1.1.1 with:
!pip install transformer_lens==1.1.1
Lets the notebook run to the end with no errors.
I also had errors because pysvelte wouldn't install. Based on this issue: https://github.com/neelnanda-io/TransformerLens/issues/530
I fixed it by replacing %pip install git+https://github.com/neelnanda-io/PySvelte.git with %pip install git+https://github.com/austinleedavis/PySvelte-fixColabSetup.git. It looks like it could also be fixed with this pull request: https://github.com/neelnanda-io/PySvelte/pull/21
I attempted to create a pull request, but after experimentation with nbstripout, manual edits, etc, I was unable to make the change without a 1,085 line diff.
Code example
Click Run All on Colab Notebook.
System Info
Google Colab, T4 instance
Additional context
Checklist

[x] I have checked that there is no similar issue in the repo (required)

The issue with PySvelte is resolved, so no need to change that URL anymore. The demo has also been locked to 1.1.1 for the time being. I will also get it up to date with the current version of TransformerLens, but you shouldn't have any more issues using it as is.


Update Lux Header links

Please update header links to AI, Credit, Finance, Market, Network, Team, with AI->lux.chat and Team->lux.partners.


lg washer not working

Hi, after i updated i can see the lg washer, but all the entities are alwayes off line. I try many time to delete and add the integration, but it is not working. So, please can you help me?
thank you so much

When you open an issue you must compile the template and provide all required info or it will not possible to analize the problem


LongPoll support

Hi, there!
Are you planning to add support for LongPoll, just like in https://github.com/phoenixframework/phoenix/blob/master/assets/js/phoenix.js#L730 ?
Cheers!

I don't think that I will personally implement this, but I would be open for a PR.
Regarding a PR: I think it should be a pure Elm implementation and not just a thin wrapper around the phoenix.js implementation.


adding Sweden central

@seligj95 : Thanks for your contribution! The author(s) have been notified to review your proposed change.