Removing an implicitly added node from built-in nodes causes a silent crash

Godot version:
3.2.1
OS/device including version:
Windows 10
Issue description:
Some built-in nodes, like ScrollContainer, implicitly add various child nodes that can only be seen when the project is running. If you accidentally delete any of them, the running process silently crashes without any error reported by the engine.

While I knew that there could be additional nodes, it still took me some time to figure out why there was a crash when I had been trying to replace a single child node of a ScrollContainer. It is not obvious that there are other child nodes inside of the built-in node unless you run the project and look at the Remote tab. The situation is worsened by the fact that the crash, due to its nature, does not report any errors (I'm guessing some reference gets corrupted and the entire engine just panics?).
Ideally, I think that there are two things that need to be done.

User scripts should not be able to remove any nodes required by built-in nodes to exist. Like scrollbars in case of ScrollContainer. Calling remove_child on such a node should err and the process should recover and move on.
It would be really handy to be able to see implicit nodes in the Scene Tree dock. Such nodes should be disabled, of course. Maybe with some visibility toggle to reduce noise. I understand, that not all of the nodes can be presented that way unless the project is running, and to achieve anything we'd need to introduce some get_implicit_nodes virtual method that would report such nodes in each individual case. But silently modifying the tree away from the user's view is not a good idea.

Steps to reproduce:

Create a ScrollContainer.
Run the project.
Remove all child nodes from the ScrollContainer:

	for child in scroll_container.get_children():
		scroll_container.remove_child(child)
		child.queue_free()

Hover over ScrollContainer's bounding box.

Minimal reproduction project:
bug-scrollcontainer-crash.zip

User scripts should not be able to remove any nodes required by built-in nodes to exist. Like scrollbars in case of ScrollContainer. Calling remove_child on such a node should err and the process should recover and move on.

Can't we just add null checks in the C++ source to solve the issue at hand?

It may very well be more difficult, but what kind of behavior would we assume to be normal after a user accidentally deletes a node that is needed for the other node to function properly? Do we continue on with a broken ScrollContainer or other node of that sort? I can't imagine what type of behavior would be acceptable for the node in question after that.
As a user I'd prefer to be immediately aware that I've done something terribly wrong. Since we don't like Godot crashing in any case, and we'd prefer to recover from any error, yet we can't guarantee any reasonable continued behavior for the node missing its essentials, I'd prefer that the ability to shoot yourself in the foot be blocked completely by extending remove_child logic.

Problem with overriding remove_child is that it doesn't stop you from get_child and calling queue_free on it, which would likely cause a similar crash.
I don't think showing all children for a node to function is intuitive really. User will add a ScrollContainer and suddenly there's 3 children (each with possibly more children themselves) and wonder why there's extra children they didn't want.
Best approach here is to trap cases where the children are being used and throw an error in the command line without crashing. Alongside this perhaps throw up a Configuration Warning on the node.

I don't think showing all children for a node to function is intuitive really. User will add a ScrollContainer and suddenly there's 3 children (each with possibly more children themselves) and wonder why there's extra children they didn't want.

Well, this is still the case, only the user finds it out after they run the scene (and maybe something goes awry). So wouldn't it be better to inform beforehand? But I do get that it can be excessive for some, which is why I've suggested some visibility toggle that would hide/show those extra nodes. It can even be off by default. Like the "Show hidden folders" option in Windows' File Explorer, you know. Visually such nodes should be as distinct as possible, of course.
It would be one thing, if the scene tree was not affected and it was just an implementation detail. But the problem is that this implementation detail is "leaking" into the user space.

Best approach here is to trap cases where the children are being used

Alright, but how do you propose we trap them? It seems to be to the same effect I'm hoping for anyway. We still need to check the node before freeing it or removing it from the parent. I guess both things can happen independently (remove_child without freeing it and queue_free without explicit removing), so both can be a problem.

Alright, but how do you propose we trap them? It seems to be to the same effect I'm hoping for anyway. We still need to check the node before freeing it or removing it from the parent. I guess both things can happen independently (remove_child without freeing it and queue_free without explicit removing), so both can be a problem.

I've developed a control that quietly adds controls and keeps a reference to them in memory, like most nodes do in the engine. Difference being is I listen to their tree_exited signal to then set the memory to null, at which point when it tries to use the object in any way, a check for null is first executed. That approach could work well.

There's a PR that solves this by making the nodes inaccessible: #30391

@KoBeWi So the idea is the same, mark them in a specific way and then exclude from user-initiated operations? Also, what's the status? Is it waiting on core contributors' approval?

Yes, it's waiting for approval (it got PR meeting label recently).

Confirmed in 3.2
CrashHandlerException: Program crashed
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[0] Range::get_value (C:\Godot\Version 3.2\scene\gui\range.cpp:131)
[1] Range::get_value (C:\Godot\Version 3.2\scene\gui\range.cpp:131)
[2] ScrollContainer::_gui_input (C:\Godot\Version 3.2\scene\gui\scroll_container.cpp:92)
[3] MethodBind1<ScrollContainer,Ref<InputEvent> const &>::call (C:\Godot\Version 3.2\core\method_bind.gen.inc:867)
[4] Object::call_multilevel (C:\Godot\Version 3.2\core\object.cpp:764)
[5] Object::call_multilevel (C:\Godot\Version 3.2\core\object.cpp:865)
[6] Viewport::_gui_call_input (C:\Godot\Version 3.2\scene\main\viewport.cpp:1669)
[7] Viewport::_gui_input_event (C:\Godot\Version 3.2\scene\main\viewport.cpp:2265)
[8] Viewport::input (C:\Godot\Version 3.2\scene\main\viewport.cpp:2828)
[9] Viewport::_vp_input (C:\Godot\Version 3.2\scene\main\viewport.cpp:1446)
[10] MethodBind1<Viewport,Ref<InputEvent> const &>::call (C:\Godot\Version 3.2\core\method_bind.gen.inc:867)
[11] Object::call (C:\Godot\Version 3.2\core\object.cpp:922)
[12] Object::call (C:\Godot\Version 3.2\core\object.cpp:848)
[13] SceneTree::call_group_flags (C:\Godot\Version 3.2\scene\main\scene_tree.cpp:275)
[14] SceneTree::input_event (C:\Godot\Version 3.2\scene\main\scene_tree.cpp:431)
[15] InputDefault::_parse_input_event_impl (C:\Godot\Version 3.2\main\input_default.cpp:442)
[16] InputDefault::parse_input_event (C:\Godot\Version 3.2\main\input_default.cpp:260)
[17] InputDefault::flush_accumulated_events (C:\Godot\Version 3.2\main\input_default.cpp:679)
[18] OS_Windows::process_events (C:\Godot\Version 3.2\platform\windows\os_windows.cpp:2548)
[19] OS_Windows::run (C:\Godot\Version 3.2\platform\windows\os_windows.cpp:3243)
[20] widechar_main (C:\Godot\Version 3.2\platform\windows\godot_windows.cpp:162)
[21] _main (C:\Godot\Version 3.2\platform\windows\godot_windows.cpp:184)
[22] main (C:\Godot\Version 3.2\platform\windows\godot_windows.cpp:196)
[23] __scrt_common_main_seh (d:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[24] BaseThreadInitThunk
-- END OF BACKTRACE --

The PR I mentioned was merged and these nodes are no longer available (unless you explicitly want it). So this is resolved.


Model not loading from server https://sdeuc1.eu-central-1.shapediver.com

The URL is not working for Iframe with sdeuc1.eu-central-1.shapediver.com.
Giving the error "Embedding not allowed for origin http://localhost:3000".

https://help.shapediver.com/doc/setup-domains-for-embedding


add back in coverage for php 5.4

looks good!

closed in favor of bff593556a62572c947681acc74b75924eae7e75, as the yaml was slightly off.


[BUG] beginDeleteSecret().waitForCompletion() recently meets timeout more frequently

Describe the bug
Hi,
i code like this:
this.secretClient.beginDeleteSecret(secretName).waitForCompletion(Duration.ofSeconds(30L))
it works fine before. but recently , it always meet timeout error, wired thing is, i also check the log in key vault, there's no failed or slow response, every request response is within 10s from key vault side.
Exception or Stack Trace
java.lang.RuntimeException: java.util.concurrent.TimeoutException
at com.azure.core.util.polling.PollingUtil.pollingLoop(PollingUtil.java:62)
at com.azure.core.util.polling.SimpleSyncPoller.waitForCompletionHelper(SimpleSyncPoller.java:142)
at com.azure.core.util.polling.SimpleSyncPoller.waitForCompletion(SimpleSyncPoller.java:96)
Caused by: java.util.concurrent.TimeoutException: null
at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204)
at com.azure.core.util.polling.PollingUtil.pollingLoop(PollingUtil.java:56)
... 152 common frames omitted
To Reproduce
Steps to reproduce the behavior:
set up akv in West Europe, try to
1.create a secret
2. get that secret
3. delete that secret
Code Snippet
Add the code snippet that causes the issue.
this.secretClient.beginDeleteSecret(secretName).waitForCompletion(Duration.ofSeconds(30L))
Expected behavior
A clear and concise description of what you expected to happen.
since key vault doesn't fail or slow response. it should behave the same.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS]
IDE: [e.g. IntelliJ]
Library/Libraries:
azure.resource.management.sdk.version:2.22.0
azure-security-keyvault-secrets：4.5.2
Java version:11

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please check out Troubleshoot dependency version conflict article first. If it doesn't provide solution for the problem, please provide:

verbose dependency tree (mvn dependency:tree -Dverbose)
exception message, full stack trace, and any available logs

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@waboqin this is somewhat related to #30648 where the wait for completion timeout would be reset for every intermediate poll operation. In #30587 we redesigned the synchronous poller to correctly timeout the operation if a terminal polling status wasn't reached during the wait for completion timeout instead of resetting on each poll operation. A workaround for this would be increasing the timeout to allow for the entirety of polling to complete.
We'll be working on offering better timeout handling in polling and will have updates for this issue as we progress.

Thank you @alzimmermsft for the response.
@waboqin
If you'd prefer the old behaviour of Polling timeout, let us know too, as that data will be helpful to offer better timeout options to our users.


Building optimizers...

Hello
I run your project, but it's been there for several hours. what is the reason?

Did you use GPU? It will take a lot of days to train the model on CPU machine, where a few hours on GPU machine.

Hello.
Thank you for answering.
Yes, I run with CPU, and it's in the Google colab environment.
Will the performance break off by disconnect colab?


Adding back API Client

see https://github.com/buehler/dotnet-operator-sdk/discussions/515

@buehler @georgevella

Hey @ewassef
Absolutely, can do :-)

You'll need to reorder the property in the implementation and the interface to please the linter.

You got it @buehler


[Pixel] Group Pixel 6, 6 Pro and 7, 7 Pro

group that four devices into two groups, like is done for the first five generations

See #3187.


Notebook dev mode: code scan research

how to split page.dart code to notes snippet?

done #81 #82


Consider offering a full jitter backoff policy

Here is a write up on full jitter. Apparently the java clients do this.
With pure exponential backoff policy we might have backoff ranges like:
req1: (.5, 1)
req2: (1, 2)
req3: (2, 4)
....
With full jitter, these backoff ranges would look like:
req1: (0, 1)
req2: (0, 2)
req3: (0, 4)
....
(make up your own units)

For some services (storage comes to mind) a minimum back off is recommended.

@dbolduc is going to research some more and make a recommendation.

This is the code to run the simulation in the article: https://github.com/aws-samples/aws-arch-backoff-simulator/blob/master/src/backoff_simulator.py
I added our backoff algorithm:
34a35,39
> class ExpoBackoffCloudCpp(Backoff):
>     def backoff(self, n):
>         v = self.expo(n)
>         return random.uniform(v/2, v)
>

And a MinJitter (i.e. full jitter, but it doesn't start at 0)
39a45,49
> class ExpoBackoffMinJitter(Backoff):
>     def backoff(self, n):
>         v = self.expo(n)
>         return random.uniform(self.base, v)
>

Results:

To summarize (with these exact settings, in this exact model), min jitter is indistinguishable from full jitter. Our strategy is indistinguishable from the jitter strategies in terms of total calls, but takes more time to complete the work.
I will phone a friend before making a recommendation...

Seems like other client library languages do full jitter only. Given the supposed, slight performance benefit, I think we should implement min-jitter (which is like full jitter, but slightly more general).
I think we should modify the implementation of the existing ExponentialBackoffPolicy, with minimal behavior changes for the current constructor. I think this means: the upper bound of the range should match, and the initial lower bound should match. (The lower bound will not match for subsequent calls to OnCompletion(). This is a change of behavior, but not a breaking change of our API.).
I think our default backoff policy should use full jitter.
Background
Our API accepts three parameters:

minimum delay
maximum delay (Note that this is an overall maximum.)
scaling factor

https://github.com/googleapis/google-cloud-cpp/blob/9737c4bfc27eea6c593dcbe2d59af41d266acc0c/google/cloud/internal/backoff_policy.h#L125-L128
Aside: I don't agree with the range it sets. I think we should multiply by scaling, not 2. Whatever. https://github.com/googleapis/google-cloud-cpp/blob/9737c4bfc27eea6c593dcbe2d59af41d266acc0c/google/cloud/internal/backoff_policy.h#L131
Min-jitter requires four parameters:

minimum delay (0 in the case of full jitter)
initial delay upper bound
maximum delay
scaling factor

Design / Work:
I would send one PR to do each of the following:
Implement min-jitter

add a new constructor + a minimum_delay_ member.

I'd probably rename  s/current_range_delay_/current_range_upper_bound_/, too.

map the parameters for the existing ctor to the members. (requires thinking!)
update clone() and OnCompletion() implementations.
add/update tests
update documentation

Update library defaults

tell the generator to use full-jitter:
https://github.com/googleapis/google-cloud-cpp/blob/main/generator/internal/option_defaults_generator.cc#L156-L157
run the generator

Can we close this?

Yes


Optional Date Parse

I'm hoping this is possible and my hope is that my functional foo is not high enough yet to understand how to do this properly yet.
Effectively what I'd like to do is decode a JSON.String into a NSDate and fail if it doesn't decode properly and for another decode a JSON.String into a NSDate?. For the sake of this discussion the two properties are always and sometimes. As you can probably infer always should fail decoding if it doesn't decode properly and sometimes should decode successfully and return Optional.None if it doesn't.
Below is some code that gets me most of the way there.
struct DecodedObj: Decodable {
  let always: NSDate
  var sometimes: NSDate?

  internal static func decode(json: JSON) -> Decoded<DecodedObj> {
    return curry(DecodedObj.init)
      <^> json <| "always"
      <*> json <|? "sometimes"
  }
}

extension NSDate: Decodable {
  public typealias DecodedType = NSDate

  static func parseISO8601(string: String,
    locale: NSLocale = NSLocale.autoupdatingCurrentLocale(),
    timeZone: NSTimeZone = NSTimeZone.systemTimeZone()) -> NSDate?
  { ... }

  public static func decode(json: JSON) -> Decoded<NSDate> {
    switch json {
    case .String(let jsonString):
      guard let result = NSDate.parseISO8601(jsonString).map(pure) else { fallthrough }
      return result
    default:
      return .typeMismatch("ISO8601 Date", actual: json)
    }
  }
}

{
  "always": "2016-01-05T070808.34+00:00",
  "sometimes": "2016-01-05T070808.34+00:00"
}

:heavy_check_mark:  Expect sometimes to be Decoded.Success(Optional.Some(NSDate)).
{
  "always": "2016-01-05T070808.34+00:00",
  "sometimes": "TODO"
}

:x: Expect sometimes to be Decoded.Success(Optional.None). Get Decoded.Failure()
{
  "always": "2016-01-05T070808.34+00:00",
  "sometimes": null
}

:heavy_check_mark: Expect sometimes to be Decoded.Success(Optional.None).
I guess the first question: is this even possible with Argo? The second is how would you go about it?
(Sorry if this is the wrong place. Or if it's been asked, I tried searching to no avail.)

Easiest way to get the behavior you want is to use the alternative operator <|> like this: json <|? "sometimes" <|> pure(nil). That means, if the expression on the left fails, the expression on the right is used instead. See 'Alternative.swift` for more detail.

Gracias. So simple I wish I had realized that without asking. I feel foolish now.
Again thank you. :clap:

Interesting use case! Don't feel foolish. This stuff isn't easy. Please feel free to open issues any time you have any questions.


unepxected indent can occurred when input something on comment with multi-cursor, in python file

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
Assume that we have the following file:
main.py
#first line:
#    indent line1
#second line:
#    indent line2

If we put the cursor at the following line(| indicate the cursor)
#|first line:
#|    indent line1
#|second line:
#|    indent line2

Then I press any character like "a", the result will be:
#afirst line:
#a    indent line1
#asecond line:
    #a    indent line2

As we can see, the last line is indented...
Additionally, if the first line and third line don't ends with :, it works as expected.
Expected behavior
The last line shoudn't indent, the body should be something like this:
#afirst line:
#a    indent line1
#asecond line:
#a    indent line2

Environment
Zed 0.59.0 – /Applications/Zed.app \nmacOS 12.6 \narchitecture x86_64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue
No response

@JosephTLyons @WindSoilder Would like to mention -- I hit this issue all the time, it is very annoying.
Please fix!!


Add main file

Add the main file for functional trainer, evaluator.

@Ashutosh-Adhikari I'll wait for your changes on the data loader before I go ahead and merge this. That would give us a better idea of how we would need to change the driver method.

Sure!

Sure! Thank you.

LGTM! Thanks for the pull request.
We may have to refactor some things but I suppose that's not the priority right now.


pkg/logger

Logging! It's finally here!
Took heavy inspiration from https://github.com/rs/zerolog in the architecture and pretty console output.
The code base may seem bloated, but I think it's way more readable than zerolog's source code.
Dont be afraid of bashing it even though it has all those pretty comments in it.
Preview
Sample output of the different pre-packaged Sink types.
pkg/logger/consolepretty

pkg/logger/consolejson
{"level":"debug","date":"2021-06-18T15:01:29+02:00","caller":"wharf-core/main.go","line":20,"scope":"TEST","message":"Sample","hello":"world"}
{"level":"info","date":"2021-06-18T15:01:29+02:00","caller":"wharf-core/main.go","line":21,"scope":"TEST","message":"Sample","hello":"world","error":"EOF"}
{"level":"warn","date":"2021-06-18T15:01:29+02:00","caller":"wharf-core/main.go","line":22,"scope":"TEST","message":"Sample","hello":"world","someSpan":1000000000}
{"level":"error","date":"2021-06-18T15:01:29+02:00","caller":"wharf-core/main.go","line":23,"scope":"TEST","message":"Sample","hello":"world"}
{"level":"debug","date":"2021-06-18T15:01:29+02:00","caller":"gorm@v1.21.11/callbacks.go","line":133,"scope":"GORM","rows":0,"elapsed":120476,"sql":"SELECT * FROM \"users\" WHERE \"users\".\"id\" = 125 AND \"users\".\"deleted_at\" IS NULL"}
{"level":"warn","date":"2021-06-18T15:01:29+02:00","caller":"fmt/print.go","line":205,"scope":"GIN-debug","message":"Running in \"debug\" mode. Switch to \"release\" mode in production.\n - using env:\texport GIN_MODE=release\n - using code:\tgin.SetMode(gin.ReleaseMode)"}
{"level":"debug","date":"2021-06-18T15:01:29+02:00","caller":"fmt/print.go","line":205,"scope":"GIN-debug","message":"Environment variable PORT is undefined. Using port :8080 by default"}
{"level":"debug","date":"2021-06-18T15:01:29+02:00","caller":"fmt/print.go","line":205,"scope":"GIN-debug","message":"Listening and serving HTTP on :8080"}
{"level":"debug","date":"2021-06-18T15:01:37+02:00","caller":"gin@v1.7.1/logger.go","line":268,"scope":"GIN","clientIp":"::1","method":"GET","path":"/","status":404,"latency":311}
{"level":"debug","date":"2021-06-18T15:01:38+02:00","caller":"gin@v1.7.1/logger.go","line":268,"scope":"GIN","clientIp":"::1","method":"GET","path":"/favicon.ico","status":404,"latency":391}

Before I review this, I have an important question.
Is this flog compatible? :D

Before I review this, I have an important question.
Is this flog compatible? :D

Hehe the JSON variant is, but will add support for our custom syntax

@fredx30
For 2000+ lines of new functionality we could have an rfc.
The description is good in the aspect that it describes what it is. It need a description of why this. Why not any other exsisting plug and play log library?

Have updated the description with this:

The requested feature set was this:

LogLevel
Multiple writers/sinks (ex: JSON for Kibana & pretty for console)
Scope per-module configs (ex: warn for Gin, info for API audits)
Easy integration with Gin-Gonic
Easy integration with GORM
Easy integration with io.Writer's, ex gin.DefaultWriter & gin.DefaultErrorWriter
Fields (WithString, WithInt...)

When coding this I tried to find an existing logger with similar features, and then wrap it inside some abstraction. I then noticed that the concrete implementation is so small so I chose to not depend on any external logging library.

Hopefully that answers your wonder.
It was quite difficult to split this one up into smaller PRs.
An RFC would've been suitable here, yes.


www subdomain does not redirect

http://www.elementary.io appears as a standalone site which hurts SEO. It should instead redirect to http://elementary.io

Seems to display the page for me

It displays the page but does not redirect to the non-www subdomain. This creates effectively a duplicate site.

(likely a server-side config)

The in-repository nginx.conf is set to work like this, but since we hide the SSL portion I'm not sure how to change it.

We have the same nginx configuration as this repo, with the exception of the ssl certificates added, but that's just a few lines and has nothing to do with routing, so no idea why this won't work

I'm saying that the config here doesn't include that, maybe use the first two server blocks from here. https://github.com/eustasy/letsencrypt-with-nginx/blob/master/nginx.conf

I'm going to leave this open until I either see changes propagate, or figure out what is wrong.

Fixed: https://www.google.co.uk/search?q=site%3Awww.elementary.io&oq=site%3Awww.elementary.io


add subscription http endpoints

Description
Adds http endpoints to list or get subscribers. This allows for tooling to detect whether a server is currently connected to hegel to determine how it should proceed.
Example Output
$ curl -s localhost:50061/subscriptions | jq '.'
{
  "abcdefab-cdef-abcd-efab-abcdefabcdef": {
    "id": "abcdefab-cdef-abcd-efab-abcdefabcdef",
    "ip": "<IP_ADDRESS>",
    "init_duration": 2000004,
    "started_at": "2020-08-11T20:55:04.56156941Z"
  }
}

$ curl -s localhost:50061/subscriptions/abcdefab-cdef-abcd-efab-abcdefabcdef | jq '.'
{
  "id": "abcdefab-cdef-abcd-efab-abcdefabcdef",
  "ip": "<IP_ADDRESS>",
  "init_duration": 2000004,
  "started_at": "2020-08-11T20:55:04.56156941Z"
}

$ curl -s localhost:50061/subscriptions/abcdefab-cdef-abcd-efab-abcdefabcdee | jq '.'
{
  "error": {
    "comment": "item not found",
    "error": "abcdefab-cdef-abcd-efab-abcdefabcdee not found"
  }
}

@kdeng3849 tagging you on here for visibility. I've had to make quite a few changes in order to make hegel backwards compatible with osie/osie preinstall. Issues were primarily with metadata instance, and storage attributes.

This commit message is actually missing the most important part, that the suffix is very important to tools we run that uses this data, so needs to stay (sgdisk)

@mikemrm ^

Sorry, missed that. I've added more details about the sgdisk in the comment.


Bug 1273650 event status not updating by fanout

Coverage decreased (-0.004%) to 84.802% when pulling a71fe098e5de15490593b40e19a6ed3c100926dc on peterbe:bug-1273650-event-status-not-updating-by-fanout into 7192ff4b72b02224c7d4d7f116f0f5a4b7773dca on mozilla:master.


export SelectPanel draft from @primer/react/drafts

Changelog
New

the new SelectPanel draft component can be imported like this
import { SelectPanel } from '@primer/react/drafts'

Changed

Removed

Rollout strategy

[x] Patch release
[ ] Minor release
[ ] Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

I was looking for some kind of smoke test to verify what components are exported but couldn't find it. If one exists I'd add a test that verifies that SelectPanel can be imported from @primer/react/drafts found it 🤦🏼
Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[ ] Added/updated previews (Storybook)
[ ] Changes are SSR compatible
[ ] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

could you please run npm run test -- -u and commit the snapshot changes?

already did via 6f15574, shortly before you commented. Sorry that I missed that at first

I tested it and it worked! This is ready to be merged and released 🙏🏼


Cannot develop or commit.

Hey, I can't develop on your repo. When I do npm install it shows me No matching version found for webpack@beta. Solved this by setting webpack to 3.10.0.
When I want to commit it shows me ./node_modules/pre-commit/hook: line 49: : command not found.

Question 1:
Ah, I think that's because I forgot to make a package version lock file for npm install (like the yarn.lock as yarn). Is it package-lock.json? (I usually use yarn recently, so I'm not sure what's for npm.)
I made it for test,  but it's seems like not working for me. It got the Cannot read property 'match' of undefined issue. Maybe we should just revise the webpack's version to ^3.10.0 in package.json. What do you think?
Question 2:
Could you find how to solve it at pre-commit's repo? It looks like that it's a setting issue.


Bump up GoCD app version to 18.11.0

/lgtm /approve

/test

/test pull-charts-e2e

/test pull-charts-e2e

/retest

/lgtm

/retest

@bdpiparva - the 400 Bad request is from the elastic profiles API for the PodConfiguration. I suspect its because of https://github.com/gocd/gocd/pull/5258.

The error is
com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Invalid escape sequence at line 11 column 88 path $.properties[1].value

@varshavaradarajan - yes, https://github.com/gocd/gocd/blob/174bb81cc294480539cd886f83373bb1402c0039/api/api-base/src/main/java/com/thoughtworks/go/api/util/GsonTransformer.java#L45 is not able to parse pod configuration properly to JsonElement. I am working on it.

/lgtm


Add tests for callback_shortcuts.0.dart API example.

This PR contributes to https://github.com/flutter/flutter/issues/130459
Description

Corrects the name for examples/api/test/widgets/shortcuts/callback_shortcuts.0_test.dart test file
Update tests for examples/api/lib/widgets/shortcuts/callback_shortcuts.0.dart

Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is [test-exempt].
[X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
[X] All existing and new tests are passing.

@bleroux @TahaTesser thanks a lot for the review!


Update documentation.yml

The upstream PR was merged so we can drop this step.

@stephencelis just an FYI that when adding the documentation workflow to the ReactiveSwift TCA fork I found I still needed the chown step, otherwise I would get permission errors. See here
I noticed that the documentation workflow here hasn't been run since this step was removed. You will probably have to add it back.

@mluisbrown Seeing this now, thanks! Will revert.


Nullable @Field()

see this closed issue: https://github.com/trevorwang/retrofit.dart/issues/73
this comment (https://github.com/trevorwang/retrofit.dart/issues/73#issuecomment-546771470) does not helps at all
this (https://github.com/trevorwang/retrofit.dart/issues/73#issuecomment-546347644) is working but we must edit generated files manually

I second this, we just need an option to indicate a parameter may be null in the @Field() annotation, and the generator should just not add the ArgumentError.checkNotNull() method call for that particular parameter in the generated method.
In its current state, this is a really big issue when it comes to optional parameters in API calls, I can just add the optional parameters as null in 1 call or use many conditional statements to call the Retrofit functions with just the parameters needed (I prefer not to touch the generated files, especially during heave development when I'm just adding/removing api endpoints all the time).


Add Norwegian translation

Thank you @palengh
Fixes #123

Wait for confirmation on changing suffix to .nb


Issues with subscription

[ ] price should be send to gopay times 100
[ ] after payment the status is still CREATED

Fixed by 5aeb9286ede0e572cb271c3d0f9b57c1cacd4240.
This is tricky part, because payment is updated by a callback from gopay and this callback is set to anatom.cz). You can force to update status of payments by executing ./manage.py refresh_payments.


Allow Presto LDAP credentials to pass through via catalog property (not extraCredentials)

Allow catalog properties (ie mysql) to refer to each user's presto LDAP credentials WITHOUT the user having to pass extraCredentials parameter in their JDBC connection string
eg
Catalog properties (ie server side)
connection-user=<LDAP>
connection-password=<LDAP>

When set to <LDAP> then each user's credentials from their Presto client connection pass through to the catalog JDBC source (ie mysql, oracle, postgres..etc)
Why? 2 problems with extraCredentials being client-side:

Numerous client-side tools (and users) have to make an update to put the property in their connection. ie Superset, Alteryx, PowerBI, Jupyter PyHive, DBeaver, Tableau, various Java apps.etc.
Logging is more problematic as sensitive credentials appear in JDBC connection strings (UID/PWD is not something often masked) in some client tools

a challenge with this ldap passthrough approach is when using impersonation (ie via superset) the principal is the superuser and the user is the enduser but the enduser's password is not supplied in the connection (just the superuser's username/passw is) so the JDBC catalog will not have access to the end users password

any idea which classes to change? @Praveen2112


[Bug]: SQL error in spatial data type production

ODC version
odc430
OB version
ob4310
What happened?
https://github.com/oceanbase/odc/assets/143492234/c1684270-604d-49a6-ad35-2ead12a9401e

What did you expect to happen?
SQL execution successful
How can we reproduce it (as minimally and precisely as possible)?

Creating Tables
CREATE TABLE spatial_table (
id INT PRIMARY KEY,
point SDO_GEOMETRY,
linestring SDO_GEOMETRY,
polygon SDO_GEOMETRY,
multipoint SDO_GEOMETRY,
multilinestring SDO_GEOMETRY,
multipolygon SDO_GEOMETRY,
collection SDO_GEOMETRY
);
Add data
INSERT INTO spatial_table (id, point) VALUES (1, SDO_GEOMETRY(2001, NULL, SDO_POINT_TYPE(12, 34, NULL), NULL, NULL));
Copy the current row within the table data
Copy and execute again

Anything else we need to know?
No response

we may check the input parameter for the first time and second time:
first time:

second time:

we take column 'POINT' as an example, the front end set the column type to 'SDO_GEOMETRY' for the first time and set to 'GEOMETRY' for the second time and this is the direct reason of this issue.
further more, the back end use OBOracleGeometryConverter to generate sql literal, this class can only support geometry.

@HSunboy may check that why does the front end give different parameters between the first time and second time


fix: handle multiple webauthn origins

:tada: This PR is included in version 0.108.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cannot update region id.

Register and update address cannot set region id from frontend.
customer_address_entity region_id = 0 but region = '大阪府'.

Could not reproduce. Could you try again with latest codes & 2.0.7 or 2.1.0?

I'm very sorry.
It was re-made again built 2.1.0 environment, then no longer reproduce.
This issue has already resolved.


Use 'vyxal.encoding.codepage' instead of 'codepage' for k⟇

k⟇ was implemented as codepage instead of vyxal.encoding.codepage (which is not imported). Trivial fix.

This is such a trivial change that I'll just forcemerge it.


Remove Transaction dependency on Dataset

Instead imply the dataset ID from the mutations added throughout the transaction.
Needed to finish #477

See #447 as well


Add Contributing section

A decent stub: https://github.com/WebVRRocks/webvrrocks/blob/master/OUTLINE.md#contributing

Some layout/content inspiration:

https://community.algolia.com/ (a bit visual and overwhelming)
https://www.rust-lang.org/en-US/community.html (a bit verbose but content is easily searchable within the page)
https://www.consul.io/community.html
https://www.packer.io/community/
https://www.terraform.io/community.html
https://teamweek.com/about.html

I like how the rust community page is super clear and straightforward.   Even if it is a bit wordy.
The other idea in the examples that are good is how contributors are highlighted on the page.


provide env ordering via "order" key

Introducing an optional "order" key to the env object.
The sorting takes a look at if "order" field is specified or not. If not,
the key is prompted last. If specified, it sorts them by the value of the
"order" field.
The order is still non-deterministic if env objects don't specify an
"order" value. (i.e. this patch still doesn't preserve map order).
Fixes #205.
cc: @jamesward

Awesome! Thank you.

Awesome! Thank you.


chore(deps): update terraform terraform-ibm-modules/landing-zone-vpc/ibm to v7.13.1

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/landing-zone-vpc/ibm (source)
module
patch
7.13.0 -> 7.13.1

Release Notes

terraform-ibm-modules/terraform-ibm-landing-zone-vpc (terraform-ibm-modules/landing-zone-vpc/ibm)
v7.13.1
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/resource-group/ibm to v1.1.4 (#671) (f03b300)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 2.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cutome file video name & format video

how i can change the file name and format video become .mp4

Hello, this library is just a wrapper over https://github.com/yt-dlp/yt-dlp
I recommend to check the documentation there 🙂


upgrade to support swagger v2 spec

I vote to upgrade and support swagger-ui that can handle swagger v2 spec., any one?

Indeed that would be cool!

Is this going to happen? It's been a couple years without activity it looks like.


[Web] Flutter Canvaskit WebGL issue in Chrome

Hi, currently when I am developing the Flutter web app I encounter a weird effect. When I am running my web app in Chrome and sometimes when I hot restart the app or during navigation between pages. The text and the svg icon will be in square boxes as follows. This shows occasionally. I am not sure what is really happening. However, when I look into Chrom DevTools Console it shows something is wrong with the WebGL in Canvaskit. I am using both fonts (download from google fonts) and svgs from assets.
Case 1:

Case 2:

The error message from Chrom DevTools Console:

Flutter doctor
[√] Flutter (Channel stable, 2.5.3, on Microsoft Windows [Version 10.0.19043.1288], locale zh-TW)
    • Flutter version 2.5.3 at C:\flutterDevelopment\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (3 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2020.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.61.2)
    • VS Code at C:\Users\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.27.0

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 95.0.4638.54
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 95.0.1020.40

Hi @AscentionOne
Can you please provide a minimal complete reproducible code sample?
Thank you

@mamuseferha Sure, my brief investigation is that this only happens on my AMD Radeon graphic card. Nvidia graphic card seems not to have this issue.

@AscentionOne do you use any external plugin to render the svg assets? Can you also confirm if this behaviour occurs when you use flutter's icon?

@AscentionOne do you use any external plugin to render the svg assets? Can you also confirm if this behaviour occurs when you use flutter's icon?

I am using flutter_svg to render the svg assets. Yes, I just confirm that the flutter's build-in icon will also have the same issue. I found out that this will happen after I hit the hot restart button. If I don't hot restart everything will be fine.

@AscentionOne can you try running the app with the html renderer and see if the issue still occurs flutter run -d chrome --web-renderer html?  Also, can you please include a simple reproducible code with HtmlElementView and flutter's icon so I can replicate on my end.

@mamuseferha It seems to have related to this issue #86809.

Hi @AscentionOne
Given your last message I feel safe to close this issue, if you disagree please write in the comments and I will reopen it.
Thank you


Build issue with STM32L4 series

Hi,
It seems that STM32L4 series have no APB1ENR register causing the build to fail.
Here is a dump of the issue:
3rdparty/libuavcan/libuavcan_drivers/stm32/driver/src/uc_stm32_clock.cpp: In function 'void uavcan_stm32::clock::init()':
3rdparty/libuavcan/libuavcan_drivers/stm32/driver/src/uc_stm32_clock.cpp:41:39: error: 'struct RCC_TypeDef' has no member named 'APB1ENR'; did you mean 'AHB1ENR'?
 #  define TIMX_RCC_ENR           RCC->APB1ENR

Regards,

This could be a patch if needed:
diff --git a/libuavcan_drivers/stm32/driver/src/uc_stm32_can.cpp b/libuavcan_drivers/stm32/driver/src/uc_stm32_can.cpp
index 2fe8ad67..ebd21a69 100644
--- a/libuavcan_drivers/stm32/driver/src/uc_stm32_can.cpp
+++ b/libuavcan_drivers/stm32/driver/src/uc_stm32_can.cpp
@@ -993,9 +993,9 @@ void CanDriver::initOnce()
         modifyreg32(STM32_RCC_APB1RSTR, RCC_APB1RSTR_CAN2RST, 0);
 # endif
 #else
-        RCC->APB1ENR  |=  RCC_APB1ENR_CAN1EN;
-        RCC->APB1RSTR |=  RCC_APB1RSTR_CAN1RST;
-        RCC->APB1RSTR &= ~RCC_APB1RSTR_CAN1RST;
+        RCC->APB1ENR1  |=  RCC_APB1ENR1_CAN1EN;
+        RCC->APB1RSTR1 |=  RCC_APB1RSTR1_CAN1RST;
+        RCC->APB1RSTR1 &= ~RCC_APB1RSTR1_CAN1RST;
 # if UAVCAN_STM32_NUM_IFACES > 1
         RCC->APB1ENR  |=  RCC_APB1ENR_CAN2EN;
         RCC->APB1RSTR |=  RCC_APB1RSTR_CAN2RST;
diff --git a/libuavcan_drivers/stm32/driver/src/uc_stm32_clock.cpp b/libuavcan_drivers/stm32/driver/src/uc_stm32_clock.cpp
index 1a4cd1e6..120343e6 100644
--- a/libuavcan_drivers/stm32/driver/src/uc_stm32_clock.cpp
+++ b/libuavcan_drivers/stm32/driver/src/uc_stm32_clock.cpp
@@ -38,10 +38,10 @@
 # endif

 # if UAVCAN_STM32_TIMER_NUMBER >= 2 && UAVCAN_STM32_TIMER_NUMBER <= 7
-#  define TIMX_RCC_ENR           RCC->APB1ENR
-#  define TIMX_RCC_RSTR          RCC->APB1RSTR
-#  define TIMX_RCC_ENR_MASK      UAVCAN_STM32_GLUE3(RCC_APB1ENR_TIM,  UAVCAN_STM32_TIMER_NUMBER, EN)
-#  define TIMX_RCC_RSTR_MASK     UAVCAN_STM32_GLUE3(RCC_APB1RSTR_TIM, UAVCAN_STM32_TIMER_NUMBER, RST)
+#  define TIMX_RCC_ENR           RCC->APB1ENR1
+#  define TIMX_RCC_RSTR          RCC->APB1RSTR1
+#  define TIMX_RCC_ENR_MASK      UAVCAN_STM32_GLUE3(RCC_APB1ENR1_TIM,  UAVCAN_STM32_TIMER_NUMBER, EN)
+#  define TIMX_RCC_RSTR_MASK     UAVCAN_STM32_GLUE3(RCC_APB1RSTR1_TIM, UAVCAN_STM32_TIMER_NUMBER, RST)
 # else
 #  error "This UAVCAN_STM32_TIMER_NUMBER is not supported yet"
 # endif

Thanks, @JeremySavonet! The patch would break other MCUs though. Would it not be possible to implement the fix in a way that wouldn't have any destructive consequences for other MCUs? We would gladly accept that into the upstream.

Here is a cleaner fix without breaking build for other MCUs:
https://github.com/UAVCAN/libuavcan_stm32/pull/3

Fixed in #3


Dark mode?

Is it possible to add a dark mode?

Sure! Great idea, I’ll start working on it!

Done!


Text Copy paste Selections not working on Android devices

Environment
Flutter 1.12.13+hotfix.7
Dart 2.7.0
all Android devices got same issue
Description
This bug is not appeared on IOS, but all android devices could not paste or copy text into webview input tags.
Selection toolbar is working, but try to copy and paste will show you the problem.
Thanks!

same problem.

This might be helpful: https://github.com/pichillilorenzo/flutter_inappwebview/issues/235#issuecomment-569251361
I think this problem is related to Platform View. Platform View is still in a developer preview and has some limitations (https://github.com/flutter/flutter/wiki/Android-Platform-Views#limitations-2).
You can use InAppBrowser or ChromeSafariBrowser for now.
Similar issue:  https://github.com/flutter/flutter/issues/24585

is there any news on #286?


issue with Jikan API

Thank you for the wonderful API
Recently i am testing the Characters Section of Anime
It give me only one  character from the Anime [All Animes ]
I have no idea why this happen
https://api.jikan.moe/v3/anime/16353/characters_staff
It was working perfectly before now
Can you fix it soon?
Thank you very mush

Hey, this issue was already resolved:
https://github.com/jikan-me/jikan/issues/362
What you're seeing is cache. I've gone ahead and invalidated that so the appropriate response should now be visible.
I'm closing this issue as it's duplicate. Feel free to ping me on the linked issue if any other cache appears bugged!


Add ReadWritePaths for datadir

I had issues running lighthouse with its datadir on a separate ssd /mnt/extra/. Adding ReadWritePaths solved it but I only verified it for lighthouse but might be useful for the others as well.

@tthebst the treefmt check has failed, would you mind running it? :)

Hi @tthebst make sure to compact those two commits into one and add a meaningful description to the commit (like "feat: add support to ReadWritePaths for datadir" or something like that).
Also, review the tests for lighthouse as those are failing.

Yes I saw that some tests fail so I put it back into draft.


More testcases

There have been a lot of testcases commented out during refactoring. Needs to be updated

Done https://github.com/tabdulradi/troy/pull/27


poor performance and mayastor-io-engine consumes only 2 cores

testing a 2 replica volume, performance is unexpected with roughly 3K IOPS
the underlying nvmes have one million IOPS and this is over 200GBit mellanox ethernet with roughly 0.1 ms latency.
kernel nvme-of  can saturate the link at 20GB/s while maya doesnt even reach 200MB/s
i noticed that the mayastor-io-engine process is spawning a single tokio worker according to the log.
I'm not super familiar with tokio but this sounds low? a single threaded IO thread would not be able to reach a million IOPS simply because the cpu isnt that fast.
  2023-10-12T10:54:43.007538Z  INFO actix_server::builder: starting 1 workers
    at /build/cargo-vendor-dir/actix-server-2.2.0/src/builder.rs:200

  2023-10-12T10:54:43.007564Z  INFO actix_server::server: Tokio runtime found; starting in existing Tokio runtime
    at /build/cargo-vendor-dir/actix-server-2.2.0/src/server.rs:197

according to htop, mayastor-io-engine has two threads, each at 100% even while idle. i'm assuming this is due to SPDK polling in a busy loop, so its expected.  But the cpu usage doesnt go up with load, its just constant. i would have expected non SPDK things to go in a different thread?

Are you binding to the correct network? You can check this by inspecting the status.attachmentMetadata.uri from the volumeattachment.
That is the server for the rest interface, it's not used by the IO path.
Depending on how you are testing you might want to add more parallel jobs from the initiator side.
As you've pointed out we're polling so the cpu usage will remain high, that's expected at the moment. Have you isolated the mayastor cores as well?

the uri is a bit confusing because it just shows one target although this is a replica-2
the IP shown there just seems to be the host where the pod is running
root@benchr:~# kubectl describe volumeattachment
Name:         csi-f8b704573038afd0f5b0d7086ae9ff48a3be4aaee55bc97b57b1f9136228f290
Namespace:
Labels:       <none>
Annotations:  csi.alpha.kubernetes.io/node-id: benchr
API Version:  storage.k8s.io/v1
Kind:         VolumeAttachment
Metadata:
  Creation Timestamp:  2023-10-15T12:48:50Z
  Finalizers:
    external-attacher/io-openebs-csi-mayastor
  Resource Version:  35362
  UID:               6086fa3a-4dcf-4fea-8781-0d615015ad44
Spec:
  Attacher:   io.openebs.csi-mayastor
  Node Name:  benchr
  Source:
    Persistent Volume Name:  pvc-391aa8e9-bde9-4aa3-b85f-eaf6e1e82a2f
Status:
  Attached:  true
  Attachment Metadata:
    Io Timeout:  30
    Uri:         nvmf://<IP_ADDRESS>:8420/nqn.2019-05.io.openebs:391aa8e9-bde9-4aa3-b85f-eaf6e1e82a2f?hostnqn=nqn.2019-05.io.openebs:node-name:benchr
Events:          <none>

ok i'm super confused.

created a StorageClass with repelica: 1
created a pvc and a pod
observed where the pod was created, then deleted the pod and recreated it with nodeselector on a different node without touching the pvc
now i get 300K iops read, 160k write, which is about 50% of native.

kubectl-mayastor get volumes -o yaml
- spec:
    num_replicas: 1
    size:<PHONE_NUMBER>0
    status: Created
    target:
      node: benchr
      protocol: nvmf
    uuid: 7de16c85-ed4b-4d72-a485-948d9814d0fe
    topology:
      pool_topology: !labelled
        exclusion: {}
        inclusion:
          openebs.io/created-by: operator-diskpool
    policy:
      self_heal: true
    thin: false
    num_snapshots: 0
  state:
    target:
      children:
      - state: Online
        uri: bdev:///d53cd54b-ca53-4826-85f8-888670685f5b?uuid=d53cd54b-ca53-4826-85f8-888670685f5b
      deviceUri: nvmf://<IP_ADDRESS>:8420/nqn.2019-05.io.openebs:7de16c85-ed4b-4d72-a485-948d9814d0fe?hostnqn=nqn.2019-05.io.openebs:node-name:benchl
      node: benchr
      rebuilds: 0
      protocol: nvmf
      size:<PHONE_NUMBER>0
      state: Online
      uuid: 2d006470-a1b0-4748-97e5-c1a0ee6b5650
    size:<PHONE_NUMBER>0
    status: Online
    uuid: 7de16c85-ed4b-4d72-a485-948d9814d0fe
    replica_topology:
      d53cd54b-ca53-4826-85f8-888670685f5b:
        node: benchr
        pool: benchr2
        state: Online
        child-status: Online
        usage:
          capacity:<PHONE_NUMBER>0
          allocated:<PHONE_NUMBER>0
          allocated_snapshots: 0
          allocated_all_snapshots: 0
    usage:
      capacity:<PHONE_NUMBER>0
      allocated:<PHONE_NUMBER>0
      allocated_replica:<PHONE_NUMBER>0
      allocated_snapshots: 0
      allocated_all_snapshots: 0
      total_allocated:<PHONE_NUMBER>0
      total_allocated_replicas:<PHONE_NUMBER>0
      total_allocated_snapshots: 0

this looks like its on node benchr, but the pod is on benchl
root@benchr:/tmp# kubectl describe pods
Name:             fio
Namespace:        default
Priority:         0
Service Account:  default
Node:             benchl/<IP_ADDRESS>
Start Time:       Sun, 15 Oct 2023 15:28:49 +0200
Labels:           app=fio
Annotations:      <none>
Status:           Running
IP:               <IP_ADDRESS>
IPs:
  IP:  <IP_ADDRESS>
Containers:
  fio:
    Container ID:  cri-o://9cf98b5164229029e03562bcd70558adf118f2e152d1863059cb52ced596231d
    Image:         mayadata/fio
    Image ID:      docker.io/mayadata/fio@sha256:05ed68f71aa7f8d713b440befa645758b6fc609a18e3264aaa93a70864c3faee
    Port:          <none>
    Host Port:     <none>
    Args:
      sleep
      1000000
    State:          Running
      Started:      Sun, 15 Oct 2023 15:28:56 +0200
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-w7vq9 (ro)
    Devices:
      /dev/xvda from ms-volume
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  ms-volume:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  pvc-1
    ReadOnly:   false
  kube-api-access-w7vq9:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:              kubernetes.io/hostname=benchl
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s

300K iops also appears to be the total IOPS of a node, even when the volumes are on different pools.
i'm still super confused how this all works. I guess this is because there's two thread spinning and all IO goes through that anyway?
Can i really not increase the thread count?

the uri is a bit confusing because it just shows one target although this is a replica-2

That is the volume target and not the individual replicas. Mayastor exposes volumes to the application hosts as nvme-tcp targets. The target controller itself (Nexus) is the one talking to the replicas.

observed where the pod was created, then deleted the pod and recreated it with nodeselector on a different node without touching the pvc

What was the intention of doing this? Mayastor does not (at the moment co-locate) the data with the application node since it can be reached from anywhere in the cluster. We also have an item in the backlog to enable this behaviour when using volumeBindingMode: WaitForFirstConsumer.

i also rebuilt the test system from scratch to make sure all IP traffic is on the mellanox network.

You can just configure mayastor (via helm) to use the mellanox subnet for example: https://github.com/openebs/mayastor-extensions/blob/27e9da9260de5fdbfbf655bd652c6eff4094287b/chart/values.yaml#L339

Can i really not increase the thread count?

The thread count on mayastor? You can change the coreList: https://github.com/openebs/mayastor-extensions/blob/27e9da9260de5fdbfbf655bd652c6eff4094287b/chart/values.yaml#L356
Btw you probably will want to change the coreList for the cores which you've isolated.
Which workload are you running?

The thread count on mayastor? You can change the coreList: https://github.com/openebs/mayastor-extensions/blob/27e9da9260de5fdbfbf655bd652c6eff4094287b/chart/values.yaml#L356

https://github.com/openebs/mayastor-extensions/blob/27e9da9260de5fdbfbf655bd652c6eff4094287b/chart/values.yaml#L353
this indicates we can change it from 2 to something bigger? going to try
btw i also tested longhorn and it has the exact same bottleneck.
i wonder if spdk is just not as good as it claims to be.
nvmeof target + initiator  do not bottleneck like this, but of course they don't have replication

Which workload are you running?

the fio example from the docs.
https://mayastor.gitbook.io/introduction/quickstart/deploy-a-test-application#run-the-fio-tester-application

You can ignore cpuCount if you use coreList.
There shouldn't be anything specific to spdk, unless something specific on your hardware, but shouldn't be the case..
One thing to be aware is if your system is numa aware depending on where fio is running and you place the mayastor cores, where your network card and disks are etc it makes a difference..
Did you create your pools using AIO, URING or PCIe ? This can make big differences..
Did you isolate your cores? This is quite crucial.

Did you create your pools using AIO, URING or PCIe ? This can make big differences..

i did not change any such setting.

Did you isolate your cores? This is quite crucial.

yes but i dont think it works.
cat /sys/devices/system/cpu/isolated
17-23

kubectl mayastor upgrade -n mayastor  --set-args 'io_engine.coreList={17,18,19,20,21,22,22,23}'

ps aux | grep io-engine
3425

 cat /proc/3425/cpuset
/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod1152379c_3ce5_4a07_ae37_1ee2f2c6de3c.slice/crio-7b8dc7c121474bce54a4d0e5b7d22e32305385523266959704f3e250e96d3f9b.scope

cat /sys/fs/cgroup/system.slice/crio-conmon-dc28287efcf2bd56b36efcff148a6782df88d17ba49423bab2cb9747b38554d0.scope/cpuset.cpus

# nothing

htop shows cpu thread 1 and 2 being at 100%, which is not what i set it to

i did not change any such setting.

When you create a diskpool, example with /dev/nvme0n1 by default we use aio protocol, equivalent to:
aio:///dev/nvme0n1
You can try to create pool with uring, example: uring:///dev/nvme0n1 or even better pcie: pcie:///81:00.0
For PCIe you base to unbind from the kernel, we don't do this automatically at the moment.
You can either do it manually or use a script such as https://github.com/spdk/spdk/blob/master/scripts/setup.sh

htop shows cpu thread 1 and 2 being at 100%, which is not what i set it to
Did you restart the mayastor-io-engine pods? Otherwise config won't apply

Did you restart the mayastor-io-engine pods? Otherwise config won't apply

i did kubectl  -n mayastor  delete pod  mayastor-io-engine-...
maybe this isnt how to do it?

also please note this:
root@benchr:~# kubectl  -n mayastor logs mayastor-io-engine-zfkct io-engine

[2023-10-16T15:46:31.304191494+00:00  INFO io_engine::core::env:env.rs:873] Total number of cores available: 2
[2023-10-16T15:46:31.310608681+00:00  INFO io_engine::core::reactor:reactor.rs:182] Scheduled SPDK thread 'init_thread' (0x55b86379bd10) on core #1

kubectl describe pod indeed says
    Limits:
      cpu:            2
      hugepages-2Mi:  2Gi
      memory:         1Gi
    Requests:
      cpu:            2
      hugepages-2Mi:  2Gi
      memory:         1Gi

or even better pcie: pcie:///81:00.0

unfortunately i cant get that working.
root@benchl:~/spdk/scripts# ./setup.sh  status
Hugepages
node     hugesize     free /  total
node0   1048576kB        0 /      0
node0      2048kB      518 /   1024

Type     BDF             Vendor Device NUMA    Driver           Device     Block devices
NVMe     0000:01:00.0    144d   a80a   0       vfio-pci         -          -

kubectl -n mayastor logs -f mayastor-io-engine-qhbg9  io-engine

EAL: Driver cannot attach the device (0000:01:00.0)
EAL: Failed to attach device on primary process
[2023-10-16T16:24:21.739602960+00:00 ERROR mayastor::spdk:nvme.c:815] NVMe ctrlr scan failed
[2023-10-16T16:24:21.739609501+00:00 ERROR mayastor::spdk:bdev_nvme.c:5300] No controller was found with provided trid (traddr: 0000:01:00.0)
[2023-10-16T16:24:21.739613261+00:00 ERROR io_engine::lvs::lvs_store:lvs_store.rs:481] Failed to create pool bdev: CreateBdevInvalidParams { source: ENODEV, name: "0000:01:00.0" }
[2023-10-16T16:24:21.739617841+00:00 ERROR io_engine::lvs::lvs_store:lvs_store.rs:444] error=InvalidBdev: Failed to create a BDEV '0000:01:00.0': invalid parameters

kubectl mayastor upgrade -n mayastor  --set-args 'io_engine.coreList={17,18,19,20,21,22,22,23}'

I don't think plugin supports that when upgrading to the same version, maybe we can add this, but for now you can just use helm:
helm upgrade mayastor mayastor/mayastor -n mayastor --reuse-values --set 'io_engine.coreList={17,18,19,20}'

thanks so much for your guidance. Will re-try with this.
in the meantime i have tested spdk by hand and it does not appear to have a performance bottleneck. actually it is a few percent faster than the native kernel nvme target, so whatever is happening sounds like misconfiguration.
I'm going to attempt starting the nexus by hand. If i understand correctly, nexus is exposing an nvme target while writing into multiple spdk blobstores, so it should be possible to isolate that for instrumentation/callgrind etc

Could you try casperf with your pcie link, example for mine:
docker run --rm -v /dev/hugepages:/dev/hugepages --privileged -it openebs/mayastor-casperf:develop /bin/casperf -b 512 -q 16 -t randread 'pcie:///81:00.0'
[2023-10-16T21:36:13.860062524+00:00  INFO io_engine::core::reactor:reactor.rs:182] Scheduled SPDK thread '81:00.0n1' (0x56534ec65230) on core #1
 81:00.0n1           :     815710 IO/s        398: MB/s
 ==================================================== +
 Total               :     815710 IO/s        398: MB/s

casperf

docker run --rm -v /dev/hugepages:/dev/hugepages --privileged -it openebs/mayastor-casperf:develop /bin/casperf -b 512 -q 16 -t randread 'pcie:///0000:01:00.0'
[2023-10-17T06:45:41.352791274+00:00  INFO io_engine::subsys::config:mod.rs:220] Applying Mayastor configuration settings
EAL: Error creating '/var/run/dpdk': No such file or directory
EAL: No DPDK runtime directory created
TELEMETRY: No legacy callbacks, legacy socket not created
[2023-10-17T06:45:41.468637156+00:00  INFO io_engine::core::mempool:mempool.rs:50] Memory pool 'bdev_io_ctx' with 65535 elements (24 bytes size) successfully created
[2023-10-17T06:45:41.470137653+00:00  INFO io_engine::core::mempool:mempool.rs:50] Memory pool 'nvme_ctrl_io_ctx' with 65535 elements (72 bytes size) successfully created
[2023-10-17T06:45:41.470148513+00:00  INFO io_engine::core::env:env.rs:892] Total number of cores available: 1
[2023-10-17T06:45:41.476474391+00:00  INFO io_engine::core::reactor:reactor.rs:182] Scheduled SPDK thread 'init_thread' (0x556bcc9376d0) on core #1
[2023-10-17T06:45:41.476490721+00:00  INFO io_engine::core::reactor:reactor.rs:158] Init thread ID 1
[2023-10-17T06:45:41.476494091+00:00  INFO io_engine::core::env:env.rs:927] All cores locked and loaded!
[2023-10-17T06:45:41.616366467+00:00  INFO io_engine::core::reactor:reactor.rs:182] Scheduled SPDK thread 'iscsi_poll_group_1' (0x556bcc9174d0) on core #1
[2023-10-17T06:45:41.616414167+00:00  INFO io_engine::core::env:env.rs:821] RPC server listening at: /var/tmp/mayastor.sock
[2023-10-17T06:45:41.616635497+00:00  INFO io_engine::bdev_api:bdev_api.rs:108] create uri="pcie:///0000:01:00.0"
[2023-10-17T06:45:41.905364873+00:00  INFO io_engine::core::reactor:reactor.rs:182] Scheduled SPDK thread '0000:01:00.0n1' (0x556bcc9da400) on core #1

 0000:01:00.0n1      :     335221 IO/s        163: MB/s
 ==================================================== +
 Total               :     335221 IO/s        163: MB/s

this is a samsung 980PRO. looks a bur whatever it does with spdk works out of the box

this is a samsung 980PRO. looks a bit low but whatever it does with spdk works out of the box

Sorry I didn't get you, is this what's expected for 512block size and 16qdepth?
But I'm confused, pcie link works with casperf but not with io-engine from helm chart? :\

@aep any updates here, did you manage to get pcie working?

No problem at all @aep, thanks for coming back to us!
Please reopen or ping us again if you ever pick this back up, it'd be great to get to the bottom of this.


Add a basic API wrapper for the transforms library

@bamader the general idea was that Workbench is now a series of building blocks like the stuff in this PR. I'm game to rename it something else if it makes sense


Update delegate.md

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://672ba282b320862e5d501f46--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://672ba31beb7d0800bad8cd5b--harness-developer.netlify.app


Huge lags and thousands of errors when loaded

If I start new game with mod, getting codes, enabling loop with museum statue, then die, game becomes unplayable due lags and errors. Restarting the game helps, but I think it's not a good option.

fixed with Nightly


linux/bfd.c unable to compile with binutils 2.29

I noticed that I'm unable to compile honggfuzz on Debian testing due to following issue:
cc -c -O3 -D_GNU_SOURCE -Wall -Werror -Wframe-larger-than=131072 -Wno-format-truncation -std=c11 -I/usr/local/include -I/usr/include -Wextra -Wno-override-init -funroll-loops -D_FILE_OFFSET_BITS=64 -D_HF_ARCH_LINUX -o linux/bfd.o linux/bfd.c
linux/bfd.c: In function ‘arch_bfdDisasm’:
linux/bfd.c:164:51: error: incompatible type for argument 1 of ‘disassembler’
     disassembler_ftype disassemble = disassembler(bfdh);
                                                   ^~~~
In file included from linux/bfd.c:28:0:
/usr/include/dis-asm.h:276:27: note: expected ‘enum bfd_architecture’ but argument is of type ‘bfd * {aka struct bfd *}’
 extern disassembler_ftype disassembler (enum bfd_architecture arc,
                           ^~~~~~~~~~~~
linux/bfd.c:164:38: error: too few arguments to function ‘disassembler’
     disassembler_ftype disassemble = disassembler(bfdh);
                                      ^~~~~~~~~~~~
In file included from linux/bfd.c:28:0:
/usr/include/dis-asm.h:276:27: note: declared here
 extern disassembler_ftype disassembler (enum bfd_architecture arc,
                           ^~~~~~~~~~~~
Makefile:247: recipe for target 'linux/bfd.o' failed
make: *** [linux/bfd.o] Error 1

It looks like binutils have changed the interface of disassembler function between 2.28 and 2.29 from:
extern disassembler_ftype disassembler (bfd *);

to:
extern disassembler_ftype disassembler (enum bfd_architecture arc,
                                        bfd_boolean big, unsigned long mach,
                                        bfd *abfd);

Interesting, lemme try to update the code

Some ugly fix in https://github.com/google/honggfuzz/commit/fe2934bd59e7a1dbe58dafcd71bb8383505de092
Needs some more testing with >= 2.29

Seems it works well.


Reflected Light from Camera Flash or other Bright Sources

Lighting Sources

[ ] Nearby sources, such as lamps or overhead lighting (creates distinct, defined reflections)
[ ] General ambient lights (produces diffuse, soft-edged reflections)

Effects

[ ] Glare spots from reflective surfaces (e.g., glass, shiny paper) that can fully or partially obscure content
[ ] Softly illuminated larger shapes or glowing areas, possibly encircling glare spots, resembling reversed shadows, mildly obstructing content; glass surfaces such as a computer screen may exhibit sharper edges in reflections; (the effect may be similar to shadows, except in reverse)
[ ] Reflected glare revealing surface texture (for paper sources, not screen displays) by reflecting white/light colors that obscure content along the raised portions of the surface texture

Examples of light or flash reflected from contents surface
Shiny Paper

Shiny Photo Paper or Glass

Computer Display

This is now done in this pull request: https://github.com/sparkfish/augraphy/pull/293.


Bugfix: Python3 incompatibility in drawgraph.py (Python 2.7 compatible)

Graph display mode (%display diagram) will not work with Python 3; the syntax used in this fix will also work on Python 2.7.
Fixes issue Diagram does not work with python 3

thanks for the PR, I've added a fix in the 1.3.0 branch based on popitem()

1.3.0 (which contains these fixes) is merged now


Fix markdown syntax

This fixes incorrectly nested links and code spans in docs/Basics.md

Woop, thanks!


Add Farms page e2e tests

are the files inside packages/app/src/test/e2e/hars/1-ngt-farm-with-0-apy/ supposed to be pushed? Can't see such files anywhere


feat: convert c-sharp exam tests to Playwright

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Note
Should show prerequisites alert and have "start exam" button disabled' is covered inexam-show-qualified.spec.ts

Alright @moT01 this should be good now.

It does use an additional parameter, but sure, no worries. Thanks for the help.
The Firefox tests seem to be failing though.

@moT01 Can you give this one another look?


Have better documentation for version support please

Talked with @Sarabeth-Jaffe-Microsoft offline about this a little bit. It's quite difficult finding online which MSBuild versions correlate to which VS/.NET/etc. versions.

Team triage: we're happy to take suggestions on https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild but we don't plan to dedicate time to this at the moment.


Example of usage?

Hey,
I've been spending a couple of days now trying to figure out how to set up authentication with sails in a proper way. After lots of tinkering and problems, I ran into your fork. Now I'm not an expert on sails so maybe there is an obvious answer, but it is not clear to me how we can use this package.
I installed the hook and tried calling the endpoint, but it seems like there is no routing / reference to the  endpoints. I also cloned this repo and tried running it but ran into some errors which I expected.
I saw the other issue (https://github.com/conceptainc/sails-hook-permissions/issues/1) but it is already over a year old, is it still necessary to reference every single file with an import?
Thanks in advance, I hope to get a conversation started, I'm really invested into fixing this issue.

Hi Youssef!
Yes, the import is still required. The company I work for that supports the development of this hook still uses the explicit imports in all of our projects. For us it still a bit painful, but we customize the models and controllers quite a bit, so in the end is not too bad.
If you have some time to make a contribution, I can provide a template of the new hook loader pattern we use for newer modules, and you might be able to take a shot at the refactoring.
Can you briefly describe the challenges of your project? I can review and see if this hook is a good fit for you.
Regards,
Marshall

Hi MrMaz,
Thanks for the quick reply!
I'll be happy to at least give it a try, but I'm not 100% sure what you mean by refactoring.
What I'm really looking for is a push in the right direction on how to set up a simple sails project using this hook. If this means I have to help modify it I'm up for it, I've looked into the source code a fair amount by now considering it's not a lot to begin with fortunately.
The project I'm working on is just a simple REST api, but I need to have the ability to support a fair amount of login providers simultaneously. I basically need the 3rd party access tokens to make API calls to these respective platforms (twitch, youtube, facebook). My idea was to use PassportJS in combination with Sails because I come from a background in Rails and liked the simplicity of the framework. Naturally I ended up running into the sails-auth package which looked promising but very outdated, but solved the exact problem I'm having, which is dealing with a large amount of external providers in a clean way. Hence running into your fork I was happy to see someone was continuing work on the Hook.
I'm still in the setup phase of the project, so I'm open for 'radical' changes, but if you have any other ideas or suggestions I'm also happy to hear them! In the end all I want is the most straightforward solution that isn't outdated by the time npm install has finished running.


Include Geekcreit 2 Channel AC 85V-250V

Hello,
The module Geekcreit 2 Channel AC 85V-250V can be linked to ewlink. It appears as a switch at Home assistant (instead of two) and it doesn´t work. Here they are the parameters that appear in devices.json:
devices.txt
Regards,

Just went through the file, don't see a reason for it to not work.
Could you please add the custom components to your configuation.yaml under your logger: component
logger:
  default: warning
  logs:
    custom_components.sonoff: debug
    custom_components.switch.sonoff: debug

And then restart HA and go to dev-info, press the refresh icon (not the word refresh) at the bottom right of the page and then share the relevant debug/warning/error messages.

I have found that it is working one of the two switches of the module and the module is not reporting any state. It seems as it is trying to assign the same name to both switches and rising an error. I have substituted the item name for xxxxxxxxx in the log but wherever you find xxxxxxx it is only a number, always the same number. This is the log:
log.txt

thanks for posting the info! this seems a bit tricky, but on the first sight it should definitely work.
more than that, it should show up 4 (in theory) switches instead of just 1 😄.
from what i gathered so far these kind of devices use sort of the same firmware but they are defined by a few particular characteristics if they should "reveal" 2,3 or 4 switches.
also, this particular device (PSF-B04-GL) has a lot of custom rules defined in the ewelink app (seems like it might not work in the same way as the others). buuut, the rules seem to stop somewhere around firmware 2.1.0 and you currently have 2.0.1. IF, and only IF, you consider it might not affect your current environment, could you please update the firmware to the latest version displayed in ewelink app and do a HA restart ?
ps: don't forget do completely stop HA or disable the sonoff component while attempting the firmware update!

Thanks. I will update it. Just one question. I created another account in ewelink and shared to it only two components. This second account is the one I configured at HA. If I update the device with the original account, I don't need to stop HA, isn't it?

Thanks. I will update it. Just one question. I created another account in ewelink and shared to it only two components. This second account is the one I configured at HA. If I update the device with the original account, I don't need to stop HA, isn't it?

Exactly! if you use main account to do upgrade of firmware it should be ok, as long as the 2nd one is used for HA. from experience the upgrade takes like 30-60sec

currently i'm working on a re-write of this component, making it a bit faster and somehow more reliable and after that i'll be back to this ;)
if it works with ewelink app it should definitely work with this component too. patience!

Bad news. I have updated to version 2.7, restarted HA and it continues with the same behaviour. Just one switch appears...

after some further investigations, i still do not understand why you get only 1 switch listed in HA :| are you 100% sure it's only 1 (please look better in the entities list)? does the name of the device has some not-so-common characters? do the switches share the same name? any information regarding this area could help me debug further.
alternatively, you could also try the websocket branch. I just pushed some interesting updates there but take a good look at the boot log, you might have to change back username -> email in config (the work is not done)

@peterbuga. I have removed the device and  paired it again. Just in case it could solve something. I have the same behaviour. In the log appears 3 times the error of duplicated device. Previously I saw a switch with the name of my device followed by an space and the number 2. And I was able to act to ch2. Now I have the name of the device followed by an space and the number 3. Now it doesn't act anything.
I think the problem is ghe routine is giving the same noun to all channels of the device. Is it possible to assign an individual name for each channel?
I have searched for the missing switches all over HA. It only creates one followed by three error messages of duplicated devices.

@jgyoldi can you please give it another try and let me know if it works now ? i pushed a little fix

Great @peterbuga!!! With last fix it works fine. Good job!!!

Awesome! @jgyoldi thanks for reaching out in order to fix this 👍


Integration of a Blog

During the Blog short information shall be posted out (content which is really created by ASRG).
It shall be easy to create a new Blog entry.
Additionally ASRG could provide this News as RSS Feed, which is then readable with Feed Reader Tools for the people who like this.
Example Blog:

Blog Overview page:
https://media.hardwear.io/
Example RSS Feed:
https://defcon.org/defconrss.xml

@SvenSchran, actually we can already have a simple Blog using the CMS.  In the future we can integrate more functions and RSS feed, however a blog is now possible.  If you have Blog content, please let me know, and we can integrate easily.


Allow using default fetch headers for all requests

In situation where the server requires some specific headers, this allows to set them once and then use on each request
const feathers = require('feathers')
const rest = require('feathers-rest/client')
const fetch = require('node-fetch')
const headers = {
   whatever: 'I need'
}
const restClient = rest('https://my.url').fetch(fetch, {headers})
const app = feathers().configure(restClient)

Currently only request module supports defaults http://docs.feathersjs.com/clients/rest.html#request via its own mechanism

That is a great change. Would you mind adding the same thing for jQuery (at https://github.com/feathersjs/feathers-rest/blob/master/src/client/jquery.js#L5) as well?

will do tomorrow, thanks for quick look!


Optionally hide Saved Queries from Frontend

Codecov Report

Merging #806 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   73.28%   73.29%
=======================================
  Files          51       51
  Lines        4754     4755    +1
  Branches      547      547
=======================================
+ Hits         3484     3485    +1
  Misses       1114     1114
  Partials      156      156

Impacted Files
Coverage Δ

helpdesk/settings.py
90.69% <100.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9358e...e8ce1ba. Read the comment docs.

Hi,
we're trying to reduce the number of configuration options that can be put in settings, not increase them. In this case, such an option is not necessary. You can accomplish this by creating new named blocks in the template and over-riding those blocks in your own new versions of the templates.

Thank you for feedback; I understand you point ;)


Risk check failed with error 16 , followed by error 13

Avoid duplicates

[ ] Bug is not mentioned in the FAQ
[x] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[ ] Bug is not already reported in another issue

Technical details

Device name: iPhone 6
iOS version: iOS 12.5.5
App version: cwa 2.14.1

Describe the bug

I just opened the cwa to check my risk status, but instead saw the error message (Fehler 13). See screenshot.
The timestamp (23:43 UTC) shows that the ~risk check~ error message was triggered at the moment when I opened the app (00:43 local time).
The error message below shows that the last successful check was more than 24 hours ago (vorgestern 05:42).
This matches with the ENF log.
Note: The device has no SIM card. Today it had WLAN coverage the whole day, so I would have expected risk checks.
Note: I can provide my error log, in case you are interested.
Steps to reproduce the issue

open the app
see error message for failed risk check

Expected behaviour

Possible Fix

Additional context

Internal Tracking ID: EXPOSUREAPP-11005

My ENF log as screenshot ...

... and ENF log as JSON file
ExposureChecks-2021-12-12.json.txt

The error log file shows ENError 16 (Database inaccessible) at 2021-12-11T01:23:22Z.
After this cwa retries several times at 04:43:54 / 04:43:58 / 08:40:50 / 12:38:36 / 16:41:39, all with error 16.
Finally it retries at 20:39:19 and from now on it gets error 13 (Max per-day API limit reached: 6).
So, the root cause for the failing risk check seems to be error 16, but this is not shown at the user interface, only in the error log.

Apple documentation for ENError 16 tells us:
"Declaration
case dataInaccessible = 16
ENError.Code.dataInaccessible
The user must unlock the device before it can access data."
What does this mean?

Good morning @ndegendogo Thanks: Internal Tracking ID: EXPOSUREAPP-11005

Corona-Warn-App Open Source Team

Officially this means to access the secure enclave after a reboot you have to enter your passcode, to access ENF information.
We saw this error also on unlocked device,  the recommendation was to not show this error to the user because it will recover automatically. Be aware on iOS 12.5 only once a day is a check by iOS guaranteed.

Thanks @thomasaugsten.
And, yes, you are right. It has indeed recovered, and I am not aware of any special actions on my side except that I waited patiently.
😁😅
Still one question remains:
In contrary to our understanding, this error seems to have counted against the rate limit. See also this discussion "The feedback from Apple at the beginning of the project was that errors are not count into the quota."
So, maybe that information is meanwhile outdated? Would it be a candidate for clarification with Apple?

Is it still necessary to have this issue open?

@Ein-Tim thanks for grooming through all the old tickets!
The new solution to handle (or rather suppress) error 13 fixes this issue well from a user's perspective.
Closing as resolved. 🎉🎉

@ndegendogo Thanks for reporting and feedback. @Ein-Tim Thanks again for "house keeping"! Best wishes, DS


IRSPIRVAsmOperandInst instructions may not have IRBlock as the immedi…

…ate parent. Previously special case was added to handle IRDecoration similarly. Replace this with a common method getBlock that traverses the parent chain till it gets to the Block
Fixes bug #3432

@csyonghe kindly review


Textarea wont auto resize in 0.98.2

Hi
Textarea will not auto resieze after upgrade to 0.98.2. It works after revert the version back to 0.98.1

Please follow the contributing guidelines
and provide a way to reproduce it. like a codepen

Do you mean https://github.com/Dogfalo/materialize/issues/4613? Still not landed as release.


sortField for custom component column

Im curious if there is a way to have a sortField for custom components? I have a column setup like so:
{
                        name: '__component:ip-column',
                        title: "last ip",
                        sortField: 'ip'
                    },

but i cant click/sort the column. Thanks!

@z1haze It was done since v1.5.0.

might explaining it then? am i doing this incorrectly in my example? because it doesnt work.

Don't know what to explain. The sortField will do what it will do. The field definition you've given is already correct and should work. If it's not, you need to look into your code.
I'm quite busy at the moment and will only able to answer simple question, anything more complex will have to wait to be inspect during the weekend.
I'm glad that you are able to find solution from other tickets, but I think the next thing you should do is learning from the source code. I think the code is very easy to understand and you will learn a lot more. I just hope that once you've learned, you would contribute back in term of PR for bug fixes, documentation, or feature suggestion. It would help me and the other a lot.


Add global site notice

This issue is imported from pivotal - Originaly created at Feb 5, 2021 by Thijs Kinkhorst
As an operator I want to be able to show a global notice to all users of Engineblock to use in exceptional circumstances where I want to notify them of important changes or issues.
The site notice can be configured as a parameter in parameters.yml. If set to anything nonempty, it will be shown. The site notice should be placed above the content of any page that is not an error message or the spinner page. HTML is passed through unfiltered so I can include links or other markup, the content is trusted because set by the deployer of EB.

@thijskh Two questions:

does this also have to be present in the material theme?
is all html allowed?  Or do we only allow a list like this:    '' (if a list: not sure what's missing?)
(Koen Cornelis - Apr 20, 2021)

Yes please (but can be kept simple).
The allowlist is OK. But the people able to set this can set the core secets. so are considered fully trusted. (Thijs Kinkhorst - Apr 20, 2021)


Update INSTALL.md

Hi @ZekeLandon! Welcome to the Omnia community!
Could you make a bug report issue for this, and link to that issue in this pull request description (e.g., Fixes #<x>, where <x> is the issue number)?
I do not see that this PR comes from your fork of the repository. Please be sure you are working in your own personal fork.
Also, we need you to sign off on each commit with the Developer Certificate of Origin (DCO). When making commits, please be sure to use the --signoff flag:
git commit --signoff

We have instructions for contributions in https://github.com/dellhpc/omnia/blob/devel/CONTRIBUTING.md.
I apologize for the process. If you have suggestions for improving the process, please create an issue so that we can discuss ways to improve it!
Again, welcome to Omnia!
-Luke

Hey @lwilson, let me create an issue and raise pull request against it. For now, I am closing this pull request and initiating a new one.
Regards,
Zeke


Ignore back ticked function names in max_line_length rule

When writing unit tests, it is a common pattern enclose the function name enclosed between back-ticks. Those function names can however not be split into multiple lines. Therefore such function names should be excludes from the max_line_length rule.
@Test
fun `Should return something when passing something and something and the other thing is in this or that state`() {...}

Originally posted by @k1dbl4ck in https://github.com/pinterest/ktlint/issues/659#issuecomment-664319682
Would like to add that back ticked function names in tests should also be handled / ignored:

I am not sure that ktlint should allow such behaviour by default. In the the end max line constraint exists to ensure that code is readable on width constraint text areas.
Probably could be optionally enabled via .editorconfig.

That is a fair point. I will make it optional.

Closed by #1008


[Bug]: Smithing table book overlapped with window title with some languages

What happened?

Modloader
Fabric (Default)
Minecraft Version
1.20.4
Mod Version
1.9
Relevant log output
Not needed

Is it possible to remove the recipe book from the Smithing Table GUI?

Not currently, no. Where do you recommend the button go?

Perhaps we should move the armor stand preview a little to the left and a book will fit on the right? Or maybe try to make the button with the book smaller. Or use it instead of a hammer.
It seems to me that it would be correct to make several display options in the modmenu settings (including the ability to selectively disable the recipe book in GUIs separately)


SKY UX import path

Current coverage is 100% (diff: 100%)

Merging #9 into master will not change coverage

@@           master    #9   diff @@
===================================
  Files          14    14
  Lines         265   265
  Methods        24    24
  Messages        0     0
  Branches       30    31     +1
===================================
  Hits          265   265
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 6ed385e...3c8fdfc


Any interaction with Ptyxis terminal profiles results in empty black pane

Describe the bug
If I try to manipulate the profiles in the Ptyxis preferences, I get an empty black pane. This occurs if I try to activate a profile by clicking on it or attempting to edit it. The panel immediately turns black and I have to restart the Ptyxis app to get rid of it.
What did you expect to happen?
Expected to see profile preferences, etc.
Output of rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:gts
                   Digest: sha256:38dca9730b1bee4f70cc3bf6ec491e1f36ef29c59d38f2b8ebf2713a971329e3
                  Version: 39.20240811.0 (2024-08-11T05:52:38Z)
          LayeredPackages: 1password 1password-cli

  ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:gts
                   Digest: sha256:9a07e503aedae790207b38e9d26b3c6dd0b6f0fa2d3913878d72b5e23236b370
                  Version: 39.20240804.0 (2024-08-04T05:53:21Z)
          LayeredPackages: 1password 1password-cli

Output of groups
fonnesbeck wheel incus-admin lxd docker libvirt

Extra information or context
No response

This is because of the old version we're putting in bluefin-gts. This will get updated in the fall, there's not much we can do about it now.
However if you ujust rebase-helper then rebase to bluefin:stable, which is currently Fedora 40, which fixes the issue:
https://github.com/ublue-os/bluefin/issues/1286


Backport master changes to next

Current coverage is 67.82%

Merging #314 into next will decrease coverage by -19.31% as of 1ac2396

@@             next    #314   diff @@
=====================================
  Files          94      42     -52
  Stmts        1609     519   -1090
  Branches        0       0
  Methods                 0
=====================================
- Hit          1402     352   -1050
  Partial         0       0
+ Missed        207     167     -40

Review entire Coverage Diff as of 1ac2396

Powered by Codecov. Updated on successful CI builds.

Well maybe not the best idea I had.

This is easier than the other way.

The other way is #300 and it's not easier since they are conflicts, the same conflicts.

Not sure if merging master into next and then merging next into master make more sense.
I will unprotect and rebase next on master.

I won't mess with #300. That's a can of worms


Payments with no date paid sorting incorrectly

Issue #487
Description
Payments were being sorted by date_paid, this was causing that payments without date_paid were not being sorted.
To fix this problem the sort was changed from date_paid to date_incurred in ClientPayments.js
Proof

@Ovifer13 note the commit here: https://github.com/setlife-network/trinary/pull/497/commits/00d0bdc4a535d47517fcb5a9dd834106ae8f1405
I was able to improve upon this by adding date_incurred as a 2nd backup sorting option since orderBy supports this
that was the most recent confirmed payments come up first, then at the bottom the unconfirmed payments will show next


Official NuGet package for Nini

There are some "unofficial" NuGet packages for Nini, but having "official one" could greatly promote Nini use in various kinds of projects, and possibly draw more contributors.

@bmatzelle Any motion on that front?  Anything the community, including myself, can help with?

No, I haven't done anything but I would appreciate the help.


Request: Addition of a Sunburst plot

A sunburst plot which would visualise the hierarchy of the samples that have moved through ToLA.

Will require mapping data together in a somewhat odd way:
  "labels": ["Insecta", "Mammalia","Plant","Hymenoptera", "Coleopteran", "iyTipFemo1"]
  "parents": ["", "", "" ,"Insecta" ,"Insecta", "Hymenoptera"]

A basic network of how these bind together would need to exist first as above and then the label of species happened to labels, and the taxonomicidentifier added as parent. ID column of sunburst isn't needed.


Auto import suggestion not working with Angular 5, typescript 2.7.1 with the latestvisual studio code

Issue Type
Bug
Description
So I have a Angular component but when i went to app.module.ts file to import it. I have mentioned the component name in the declarations but it was not suggesting which file to auto-import with typescript version 2.7.1 but this clearly working with version 2.5.1.
VS Code Info
VS Code version: Code 1.20.0 (c63189deaa8e620f650cc28792b8f5f3363f2c5b, 2018-02-07T17:10:15.949Z)
OS version: Linux x64 4.13.0-32-generic

System Info

Item
Value

CPUs
AMD A10-7300 Radeon R6, 10 Compute Cores 4C+6G (4 x 1500)

Load (avg)
1, 1, 1

Memory (System)
6.75GB (1.74GB free)

Process Argv
/usr/share/code/code --unity-launch

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

beautify
Hoo
1.3.0

html-css-class-completion
Zig
1.16.1

path-intellisense
chr
1.4.2

gitlens
eam
8.0.0

vscode-html-css
ecm
0.2.0

Angular2
joh
2.12.0

typescript-hero
rbb
2.2.0

vscode-icons
rob
7.19.0

Reproduces without extensions

Do you still see this issue in the latest VS Code builds using typescript 2.9?

No.. I don't see this issue. Thanks for the fix.
checked in :
Version: 1.25.1
Commit: 1dfc5e557209371715f655691b1235b6b26a06be
Date: 2018-07-11T15:40:20.190Z
Electron: 1.7.12
Chrome: 58.0.3029.110
Node.js: 7.9.0
V8: 5.8.283.38
Architecture: x64


Magit: When deleting local branch, give option to check out upstream instead of main

For repos w/ long-running feature branches, it can be useful to directly check out feature-branch. Magit interface, however, only allows for checking out either main or the current commit as a dangling head.
Let's see if this is configurable.

I suspect this is not directly configurable, given these lines upstream.
Might submit an issue.

Opened magit/magit#4549.


[silx view] show NXentry title

Could Silx show the NXentry title in the viewer? NXentry names are typically chosen for easy access by software (e.g. just a number) but are not very informative for humans.

It is enough to replace NXentry in the type column by the title dataset if present.

Done. Let's see if it gets approved. For the ESRF perhaps is better to append it to the entry name. However for the other facilities using longer entry names it can be a problem.


Adding labels to dependabot

Codecov Report

Merging #55 (ae9398e) into main (262092e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          364       364
=========================================
  Hits           364       364

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262092e...ae9398e. Read the comment docs.


Combined all the scheme files into a single json fragment extension

PR for issue #17
This PR streamlines the installation of color schemes, but not the themes.
Read issue for more info, might have to leave this cooking until v1.20 to avoid complicating installation of themes.

Looks like the pre-release for 1.21 with the update required for this change was released! Hopefully we can get this merged soon when 1.21 is fully released and I'd like to Whiskerify this port after that.


First column values is bigger then second colum values NOT work properly

Medoo Query like:
			$links = $this->db->debug()->select("links", "*", [$isBot."[<]" => "limit_".$isBot, "ORDER" => ["created_at" => "ASC"], "LIMIT" => 100]);
$isBot - is string.
Generate an sql query like:
SELECT * FROM "links" WHERE "yandex" < 'limit_yandex' ORDER BY "created_at" ASC LIMIT 100
But must:
SELECT * FROM "links" WHERE "yandex" < "limit_yandex" ORDER BY "created_at" ASC LIMIT 100
Quotes are not properly working

If limit_yandex is column, you should use
[
	$isBot . "[<]limit_" . $isBot,
	"ORDER" => ["created_at" => "ASC"],
	"LIMIT" => 100
]

https://medoo.in/api/where Columns Relationship section


[6.14] After a symfony update, fresh laravel installation incorrectly return a "text/xml" content type if the request's headers say they prefer xml

Laravel Version: 6.14.0
PHP Version: PHP 7.3.11
Database Driver & Version: N/A

Description:
In a sympfony minor (?) version update, the behavior of web requests was changed, to return "text/xml" if the requester seems to prefer it. This isn't correct as html which isn't valid xml ends up being returned with a text/xml content type.
Steps To Reproduce:
composer create-project --prefer-dist laravel/laravel blog
Set up a webserver for this on localhost.
curl -v -H "Accept: application/xml,application/xhtml+xml,text/html" http://localhost 2>&1 >/dev/null | grep 'Content'
Observe that the returned content type is "text/xml"
Put the output of the front page through an xml linter and observe that it is not valid XML.
$ curl -s localhost | xmllint -
-:65: parser error : Opening and ending tag mismatch: link line 10 and head
    </head>
           ^
-:87: parser error : Opening and ending tag mismatch: meta line 5 and html
</html>
       ^
-:88: parser error : Premature end of data in tag meta line 4

^
-:88: parser error : Premature end of data in tag head line 3

^
-:88: parser error : Premature end of data in tag html line 2

^

Expected behavior:
The content type returned is text/html, as it was during Symfony version v4.3.8.

If this was a symfony update we can't do anything about this ourselves. Please open an issue on their repo or send in a PR for better support of said content types.


[zh-cn] sync logging system-logs

content/zh-cn/docs/concepts/cluster-administration/logging.md
content/zh-cn/docs/concepts/cluster-administration/system-logs.md

/lgtm