U-Boot on SPI flash

The Unmatched has an on-board 32MiB SPI flash that the mask ROM can be configured to boot from (MSEL=0110). U-Boot SPL boots just fine, and we need to investigate what's needed for it to load the next stage from the SPI flash as well (like Unleashed).

Relevant patches are already upstream, see: https://github.com/u-boot/u-boot/commit/6a863894ad53b2d0e6c6d47ad105850053757fec

Thanks @NickCao! Apparently I haven't been following the development closely. I just made an SPI installer image so it's easier to install U-Boot to the SPI flash.


Unsupported Cipher

Describe the bug
Unsupported cipher or incorrect key length. Supported ciphers are: aes-128-cbc, aes-256-cbc, aes-128-gcm, aes-256-gcm.
To Reproduce
It appears ookla updated their cipher requirements and the base64 key you're handing out on your dev website no longer works to run this application.

Do you have the full key set in env value?
Make sure it contains the base64 at the start and the = at the end.

Do you have the full key set in env value? Make sure it contains the base64 at the start and the = at the end.

I did -- I'm honestly not sure what caused my issue but it seems resolved now. One thing I did notice is the docker compose in your github readme differs from the docker compose you supply in your documentation and on linuxserver.io. When I switched over to the documentation version it began working. Not sure if coincidental but one thing it removes is APP_URL.

I will check out the docker compose examples.
Glad it all works now


[REQUESTS]: Improved CSV dumps

Issue Name
Improved CSV dumps
Issue Description
The csv exports of the search results were found to be less helpful and sometimes messy. This can be improved by:

[x] Prioritizing the metadata fields exported (with most important fields in the left-most column)

[x] Top 3 should probably be _id/identifier, name, description
[x] @EmilyHaag can you look into prioritizing the next 3-5 fields? After that, the order probably won't matter

[ ] Cleaning up the description field (removing html tags)

Issue Discussion
This issue was raised at the biweekly meeting dated 2024.10.29
Request Type
Update material (make a change to an existing mock up, page, feature, etc.)
Material URL
No response
Related WBS task
https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/2
For internal use only. Assignee, please select the status of this issue

[ ] Not yet started
[ ] In progress
[ ] Blocked
[ ] Will not address

Status Description
No response
Request status check list

[X] The request has been scoped
[ ] Some immediate discussion or action on the matter was started, but additional information needed
[ ] One or more new GitHub Issues, Pull Requests, or files in Google Drive have been created to address the request
[ ] The request is awaiting approval to move to staging
[ ] The request is awaiting approval to move to production
[ ] The request is awaiting approval for closeout
[ ] The request has been addressed and closeout of the issue is approved

Recommendation for next 5 fields (after identifier, name, description): @type, healthCondition.name, infectiousAgent.name, species.name, author.name

Perfect! Thanks, @EmilyHaag

Note that after discussions on implementation for cleaning up html tags, it was determined that the best way forward is to have a helper function that could perform the clean up on the backend to ensure consistent results between the .csv dump and the API; as well as, minimizing impact to the .csv dump time.
The issue for cleaning up html tags is here: https://github.com/NIAID-Data-Ecosystem/nde-crawlers/issues/220


Exported track is silent when adding two oscillators

@wayfu encountered a problem with exporting one of their synths to executable, which I debugged down to this minimal example:
Adding two oscillators will play back correctly in the tracker, but export to silence when played back from assembled binary.
I attached the yaml file that reproduces the problem, along with the two exported versions (exported from tracker, exported from binary).
addp_broken.zip
EDIT: I used Sointu at<PHONE_NUMBER>5d16b234463138386919259c63f9a7 to reproduce, which is equivalent to the current master.

Stack overflow. The second oscillator uses some temporary variables and there's already 6 elements on the stack (x87 FPU stack has 8 items max). The binary uses the native x86 assembly written synth to render the song; please use -native ending executables to have matching capabilities. It gave stack overflow error right-away when loading your broken file.
The patch can be fixed by reorganizing it as
oscillator-oscillator-addp-envelope-mulp-...
Does this resolve your issue?

Retested; this is exactly what happens. Thanks!

This is such a foot-gun but I don't know immediate way to avoid this, short of artificially limiting the non-native synth or supplying only -native ending executables.


Refactor and cleanup CsvTokenizer

I made an independent embulk-util-csv (https://github.com/embulk/embulk-util-csv), but it didn't work compatibly in #11. It looks to be some difference in Exception structures. Hard to investigate all the causes, and difficult to prove a fix is correct.
Instead, I'm going to have another try by refactoring them inside embulk-parser-csv iteratively, then move them to embulk-util-csv overridden.
Upcoming PRs would be the refactoring.

#20
#21
#22
#23

Thanks!


(cleanup) Add "+ Add" Button at Firewall -> Alias Page

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
When clicking on Firewall->Groups, Firewall->Rules->LAN, VPN->OpenVPN->Clients, etc., there is always a +Add button on the top right. In Firewall->Aliases this button is missing. Instead there is a small +button at the end of the alias list.
To Reproduce
Steps to reproduce the behavior:

Go to 'Firewall'
Click on 'Aliases'

Expected behavior
I would expect the +Add Button to be at the same right upper corner as within the other pages.
Screenshots

Relevant log files
no log files
Additional context
no additional context
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 20.7.8-amd64
FreeBSD 12.1-RELEASE-p12-HBSD
OpenSSL 1.1.1i 8 Dec 2020

same as https://github.com/opnsense/core/issues/4381 and https://github.com/opnsense/core/issues/4216

same as https://github.com/opnsense/core/issues/4381 and https://github.com/opnsense/core/issues/4216

same as #4381 and #4216

Indeed, but #4381 was closed as duplicate (correctly so) and #4216 was already bot-closed (which is not so helpful I suppose?)
So perhaps we could re-open #4216? As the new menu-item "categories" under "firewall" was copied from "aliases" (I guess, as it uses the same icon and the page is also missing the +Add button ;)) I think that would help weeding out those differences. :)

Likely not going to fix anything as long as nobody is planning to do the work, just to be clear, the new format doesn't have big buttons on top, the older pages might have them. Cleaning up means removing the big top buttons.
Since grid styles are different on these pages as well, it doesn't make much sense only to remove the big buttons now without rebuilding the component into an mvc one (which is quite some work).

I'm all for unification and making the UI consistent! And don't take that the wrong way, but I had quite a few customers where I did remote support and they ALL searched for the big and colorful(!) button on top rather then a tiny little plus that don't stand out the least (no color, no text, nothing) and - on top of that - is on the bottom of the list.
I'd really recommend to add color and/or text to the button and include a top-row in addition to the bottom row as the people just don't find it in a sea of lines with various other similar looking buttons right above it. The big Add button actually was a better idea then I first thought and will be missed for sure!
I'd love to see some color indicators that draw attention to the little [+] guy. Even me knowing it's there have sometimes problem with larger rulesets or tables to find it. And yeah, normally list is capped to 7-10 entries, but in larger rulesets you have to display more if you want to keep track, what the customer has done there ;)

#4216 is open, closing this now.


Setup integration testing infrastrucutre

What is the idea?
We need to be able to run integration testing in our test suite for the authentication schemes we want to support.
Why is this needed?
In order to properly test these authentication schemes, it makes sense to have an integration testing system in place (or at least a strategy for how we intend to do this type of testing).
What should happen?

[ ] https://github.com/conda-incubator/conda-auth/issues/3 (this issue should be completed first)
[ ] Setup integration testing to support HTTP Basic Authentication.
[ ] Write several new integration tests to demonstrate how this will work
[ ] Don't forget local testing! Make sure this can be done on a local setup as well (probably using a docker-compose.yml file)

Additional Context
To accomplish this, we will most likely take advantage of GitHub Action's "service containers". More information about those can be found here:
https://docs.github.com/en/actions/using-containerized-services/about-service-containers

This is one testing scenario that I believe needs to be covered in this repository:

https://github.com/conda/conda/pull/12911#discussion_r1291046564

This is the reposerver that is currently used by the mamba project:

https://github.com/mamba-org/mamba/blob/main/mamba/tests/reposerver.py

It could be helpful for setting up integration testing for this project.

This could be a nice resource to use once we are ready to test anything related to OAuth2/OpenID:

https://github.com/zmartzone/lua-resty-openidc


Are you searching for developers?

Are you searching for developers? If so:

What is your current roadmap, schedule?
What is your code of conduct and your coding standard policy?
What is your workflow, design? DDD in mind or?
Do you plan to work with any framework such as ZF3 or Symfony for development ease?
Do you plan to switch to Doctrine for Object-relational mapping?

Thank you.

Hello Nuxwin,
We are currently establishing many of the facets you ask about. We are interested in expanding the development base but wish to do so with a working release.
There is much to do yet as we decouple and clean up known problems and any new ones that present as we progress.

Our current roadmap is in its beginning state with a primary milestone of Circle Billing v1.0 - a tested and working version. We will publish a more comprehensive roadmap as we are able to decipher needs and clear known issues.

Our coding standards will be PSR-2. Code of conduct is currently in draft form and we will release that soon. It will be as any developer might expect.

We have no hard and fast workflow/design methodology established at this time. We are evaluating possibilities and perhaps Domian Driven Design would fit. Thank you for suggesting it.

At this time we are not planning to add in any frameworks. We desire to understand the current code base fully before introducing any layers or to restructure existing code to work with a framework. I am not saying it won't happen, but we agree right now to not use a given framework.

Do time and ORM are interesting possibilities, and may be of value. I can see some advantages there in the future. Just getting to stable is our primary focus. Nothing is completely off the table at this time.

Thank you for expressing interest and for sharing your insight into the possibilities before us. I look forward to communicating again soon.

@62BRAINS
Thank you for your clarification. That is much appreciated.
I'll continue follow you and perhaps contribute with some PR in near future.

@nuxwin Nice the hear :)
Nuxwin is a great Developer :) and i bet he do some great PR's :)


Model Request : bge-large-v1.5 & m3e-large

What model would you like?
https://huggingface.co/BAAI/bge-large-en-v1.5
https://huggingface.co/BAAI/bge-large-zh-v1.5
https://huggingface.co/moka-ai/m3e-large

Thanks for opening the request, in the meantime there are some community options here too:
https://ollama.com/search?q=bge
https://ollama.com/search?q=m3e


Update copy based on accounting integration

Details

Update copy based on accounting integration selections.
Fixed Issues

$ https://github.com/Expensify/App/issues/44297
PROPOSAL: https://github.com/Expensify/App/issues/44297#issuecomment-2195591119
Tests

Connect a workspace to QuickBooks Online
Click Export > Export company cards as
Toggle the options between Credit card, Debit card and Vendor bill
Verify the Account menu below shows Credit card account, Bank account and Accounts payable respectively
Press the menu
Verify the header title shows as Step 4
Verify the translations in Spanish in Step 4 and 6: Cuenta de la tarjeta de crédito, Cuenta bancaria and Cuentas por pagar

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.4-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@Beamanator I noticed this PR skipped the production build, any idea why ?

@ikevin127 hmm I know a few days back the production build failed silently, so maybe that's why it hadn't made it in - but is it in prod now? 😅

@Beamanator Looks like it only reached staging and got stuck - that's why I asked because it should've been on production by now and have the contributors paid out for the work, but right now it's being delayed 🤒

Hmm @ikevin127 are you talking about just the automated Deployed to <environment> messages? I can see that https://github.com/Expensify/App/blob/production/src/libs/ConnectionUtils.ts exists in staging which came from this PR, so I'm pretty sure this did get to prod, just the automated deployment message didn't get posted (it's def not a perfect system)

@Beamanator I did not know that it got to production, usually when the Deploy Checklist is closed, the PR goes to staging and usually 1-2 days later it goes to production.
If it did get to production, there are two issues here:

We didn't get any "deployed to production" message from the automation.
Because of ^, the issue did not get the HOLD for Payment and corresponding labels - issue is still labeled as Reviewing and Weekly.

Either ^ that or it didn't reach production yet. Can you please help sort this out ?

1. is definitely known, and I hopefully just fixed 2. in the linked issue 👍

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Migrate Services to create generic modal

Description

Migrate Services to create generic modal. We should use the patterns as the rest of Create Resource.
Reasons

To be consistent with the rest of the app.

We don't have create view for Services.


refactor: unify the same field type definition in different places

Signed-off-by: fengzixu<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did

reduce using of extra fields which were included in anthor definition

Ⅱ. Does this pull request fix one issue?

#363
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
I run all unit-test in the dfget package.
Ⅴ. Special notes for reviews
For 「use int32 or int64 instead of int」, I think that using 'int' is ok for the dfget package. We don't need to revise all variables whose type is int into a wider type.
For 「unify the same field type definition in different places」, I revise the code which was written in the package called downloader. Because I consider that we should not add extra variables that are already defined elsewhere.

Codecov Report

Merging #612 into master will increase coverage by 0.04%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   46.09%   46.13%   +0.04%
==========================================
  Files          99       99
  Lines        5832     5829       -3
==========================================
+ Hits         2688     2689       +1
+ Misses       2922     2919       -3
+ Partials      222      221       -1

Impacted Files
Coverage Δ

...core/downloader/back_downloader/back_downloader.go
66% <71.42%> (+3.73%)
:arrow_up:

supernode/daemon/mgr/scheduler/manager.go
25.98% <0%> (+0.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd1698...b45ce13. Read the comment docs.

@Starnop Request review.

Thanks for your contribution. However, maybe it's not a good solution. And in fact, I am trying to fix the issue #370 which is just the opposite of what you did. 😢
And for issue issue #363, I think what should we do is just as title described. For example, we think that int32 is enough for pieceSize. However, it's defined with int64 here. And that is exactly what we should make a change.
And the other similar fields but not completely, just FYI:

pieceNum (expected int64)
port (int32/int both OK but should be unified)
......

unified

Ok. Let me fix the problem about integer type. I will give up the modification of configuration type.

Any updates?

@Starnop Sorry. I am too busy at the current time. I will finish it asap.

Don't worry about that. I just want to get the latest progress.  Whatever, thanks for your work. 😄


[Sample] Empty the tenant recycle bin from SharePoint

Add new sample for emptying the tenant recycle bin from SharePoint

Adds new sample

Closes #1142

Thanks! We'll go through it ASAP

Thanks! We'll go through it ASAP

Merged manually. Thank you! 👏

Merged manually. Thank you! 👏


MNT: Re-render the feedstock

Hi! This is the friendly conda-forge-admin automated user.
I've re-rendered this feedstock with the latest version of conda-smithy (0.9.2) and noticed some changes.
If the changes look good, then please go ahead and merge this PR.
If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).
Remember, for any changes to the recipe you would normally need to increment the version or the build number of the package.
Since this is an infrastructural change, we don't actually need/want a new version to be uploaded to anaconda.org/conda-forge, so the version and build/number are left unchanged and the CI has been skipped.
Thanks!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


⚠ Bofrost.lu has degraded performance

In 5c9923b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2160 ms

Resolved: Bofrost.lu performance has improved in 32b946d after 13 minutes.


Job Tracking URL in yarn/MRv2/new API

In MAPREDUCE-3243, the tracking URL output was removed from o.a.h.streaming.StreamJob. I think this was done for a few reasons:

From the description in the JIRA: 'The tracking URL for streaming jobs currently display "http://N/A"' (this might be related to the next point)
In MRv2 they've radically changed the API to the point where there is no JobTracker anymore, some of its responsibilities have been taken over by the new ResourceManager and some by the ApplicationMaster
The class o.a.h.mapreduce.Job already logs the tracking URL in submit() as: LOG.info("The url to track the job: " + getTrackingURL());

This raises a number of issues for luigi:

The code in luigi.hadoop.run_and_track_hadoop_job() would need to change to grep for "The url to track the job: " in addition to "Tracking URL: "
For us, the new log message goes to stdout rather than stderr, so the luigi code would need to change to also grep through stdout rather than just stderr
It appears that the current code will only read one line of stderr at a time while the subprocess is running. If a bunch of lines are printed right before the subprocess exits, several of them could be missed. I think it would make more sense to send both stderr and stdout to a tempfile.TemporaryFile() and grep through those files for the interesting strings afterward.
Even if the tracking URL is found, the code in luigi.hadoop.fetch_task_failuers() would need to change in order to handle the new tracking page that's used in hadoop2.0 (I don't think it's specific to yarn, even the new jobhistory server uses a new layout)

It seems like any one of the following changes would have broken this code, it's just that all three are sort of happening at once:

New web UI layouts (seems to be different between hadoop1.x to hadoop2.x)
New Map/Reduce api: org.apache.hadoop.mapred to org.apache.hadoop.mapreduce changing how and where the job tracking URL is logged
MRv1 (with jobtrackers and tasktrackers) to MRv2/YARN (with resourcemanagers, nodemanagers, and applicationmasters): different services that manage different pieces of data

I'm running in to this, too. In Hadoop 2.6 I was able to grab the job tracker url from stderr. There's a quick and dirty fix here. To grab the logs will take a little more effort - the right thing to do is probably read the hadoop version from config, and go to different URLs based on "apache1" or "apache2".

If you find a solution to this and send a PR, we will probably happily merge. :)

Would be awesome if you can fix. This has been bothering me for a while. Should be possible to unit test using the minicluster functionality too

This also grabs the logs, now, too.  Still needs a test. I'm not sure how to get the minicluster stuff running - I'm getting a connection refused from 50030 when I try to run the Hadoop tests as is. I thought it might have something to do with the fact that the main Hadoop dashboard seems to be at 8088 in Hadoop 2, but changing 50030 to 8088 in minicluster.py didn't fix the issue.

@jdangerx The port 50030 is not the dashboard port but the NameNode port. The easiest way to run the test is probably to change the url here with the hadoop version you want to test and run the test with
tox -e hdp

I'm using hadoop 2.6 and the minicluster is running without issue.

Awesome, thanks!

I'm closing this issue.

[x] It has been inactive for +4 months.
[ ] It's not about luigi core, so not as many users are affected about this.
[ ] The change seems quite big, it's unlikely to be sporadically picked up.
[ ] The owner haven't responded or disappeared.
[ ] I don't understand what this is issue is about.
[ ] There exists a reasonable workaround for this.
[ ] We need to check if this hasn't been fixed by now (for old issues).
[ ] This is kind of by design and not a bug.

Every open issue adds some clutter, and we try to make the issues fewer and make it easier for new collaborators to find. Currently we try to close any issue that meets the first checkbox + one other.
Feel free to reopen this issue at any point if you have the intent to continue to work this. :)


Tasks for Spring Boot:3.0.0-M2 (3.0.0 GA on 2022-11-24)

Context
Refs: https://github.com/Azure/azure-sdk-for-java/wiki/Spring-Cloud-Azure-tasks-for-a-new-Spring-Boot-release
Goal
Make sure Spring Cloud Azure libraries are compatible with spring-boot:3.0.0-M2
Solution

[x] Create a new issue to track the following tasks. Sample: #27864.
[ ] Create draft PR to upgrade external dependencies' version according to spring-boot-dependencies and spring-cloud-dependencies. Refer to related readme
[ ] Run tests by commands:

/azp run java - spring - tests
/azp run java - cosmos - tests
/azp run java - keyvault - tests

[ ] Fix the test failures.
[ ] Close draft PR.

@chenrujun @moarychan  is this issue still valid?

Confirmed, the 6.0.0-beta.3 is the latest version to support Spring Boot 3.


[Feature Request] Fullscreen SeedQR export

Currently, when exporting a seed phrase via QR code, the two options given (Standard and Compact) do not display the QR code using the entire screen of the device. This makes it difficult to scan using phones, hardware wallets (including SeedSigner), and backup devices like SeedHammer. An option to display the SeedQR using the whole display like is done when exporting xpubs would make it much easier to export the seed.

Just to clarify, the above image is not large enough and you want the SeedQR to display from edge to edge?

@newtonick Correct. I am not able to import this QR into other HWWs and other wallet software.


Slot is "grouplabel", but type is "groupLabel"

Version

Vue version: 3

Description
When trying to use a template with Multiselect, like so:
<template #groupLabel="{ group }">

          {{ group.label }}

</template>

groupLabel does not work as a slot name, but the type is 'groupLabel':
(property) groupLabel: globalThis.VNode<RendererNode, RendererElement, {
    [key: string]: any;
}>[]

if I change it to grouplabel:
<template #grouplabel="{ group }">

          {{ group.label }}

</template>

it works, but it throws a type error:
Property 'grouplabel' does not exist on type '{ placeholder: VNode<RendererNode, RendererElement, { [key: string]: any; }>[]; afterlist: VNode<RendererNode, RendererElement, { ...; }>[]; ... 12 more ...; spinner: VNode<...>[]; }'. Did you mean 'groupLabel'?ts(2551)
Multiselect.d.ts(202, 5): 'groupLabel' is declared here.

Thanks for reporting the issue. Fixed in 2.6.7.


[KOGITO-4602] - Create Go module for product kogito operator

Many thanks for submitting your Pull Request :heart:!
Jira issue : https://issues.redhat.com/browse/KOGITO-4602
Please make sure your PR meets the following requirements:

[ ] You have read the contributors' guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains a link to the JIRA issue
[ ] Pull Request contains a description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

I did a quick review, please disregard my KogitoBuild comments since we agreed to support it for dev purposes.
Some files that I think we must preserve:

the LICENSE file
the README file with some information about this repository and a link to kogito-operator
RELEASE_NOTES should be preserved with a link to upstream. Only RHPAM jiras should be added
examples/example-custom-build-images.yaml
examples/quarkus-jvm.Dockerfile and examples/springboot.Dockerfile. These files help users to get started on building their own images. Common use case for enterprise users.
I didn't understand why we need to remove examples/service-labels.yaml
SpringBoot runtimes is out of question here? examples/springboot.yaml
I think we need to keep go.tools.mod since we will still use some tooling in this repo.

Thanks for the hard work man!

I had removed these all files because I take approach where first I remove all files from this git repo and then added only necessary file.
I had added back all files which you had mentioned above

I had removed these all files because I take approach where first I remove all files from this git repo and then added only necessary file.

Try to avoid this, please. We want to preserve the authoring of all our files that came from upstream.

Right, they will just need adjustments...

I had tested some sceneios of KogitoBuild and KogitoRuntime locally on crc. They are working fine.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b6f0115). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 777ea75 differs from pull request most recent head 21d2b91. Consider uploading reports for the commit 21d2b91 to get more accurate results

@@           Coverage Diff            @@
##             master      #2   +/-   ##
========================================
  Coverage          ?   0.00%
========================================
  Files             ?       3
  Lines             ?     107
  Branches          ?       0
========================================
  Hits              ?       0
  Misses            ?     107
  Partials          ?       0

Flag
Coverage Δ

controllers
0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f0115...21d2b91. Read the comment docs.

I had removed these all files because I take approach where first I remove all files from this git repo and then added only necessary file.

Try to avoid this, please. We want to preserve the authoring of all our files that came from upstream.

@ricardozanini I had squash all my commit in this PR. Git history(authoring) of all files are back which I deleted and added back.

I am not able to make a KogitoBuild running.
When I deploy example from https://github.com/vaibhavjainwiz/rhpam-kogito-operator/blob/KOGITO-4602/example/process-quarkus-example.yaml I get an error in operator:
021-03-18T13:05:57.433Z	ERROR	kogitoBuild-controller	Failed to update KogitoBuild	{"name": "example-quarkus", "namespace": "ksuta-test", "build_type": "source", "error": "KogitoBuild.rhpam.kiegroup.org \"example-quarkus\" is invalid: status.conditions: Required value"}
github.com/go-logr/zapr.(*zapLogger).Error
	/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
github.com/kiegroup/kogito-operator/core/kogitobuild.(*statusHandler).HandleStatusChange
	/go/pkg/mod/github.com/kiegroup/kogito-operator@v0.12.1-0.20210316163042-b2f90df9984d/core/kogitobuild/status.go:80
github.com/kiegroup/rhpam-kogito-operator/controllers.(*KogitoBuildReconciler).Reconcile
	/workspace/controllers/kogitobuild_controller.go:109
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.3/pkg/internal/controller/controller.go:244
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.3/pkg/internal/controller/controller.go:218
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.3/pkg/internal/controller/controller.go:197
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
	/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
	/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.Until
	/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:90

KogitoRuntime seems to work.
I am ok with merging this PR and addressing the issues in next PRs.

KogitoRuntime seems to work.
I am ok with merging this PR and addressing the issues in next PRs.

Let's have @vaibhavjainwiz evaluate the fix. If it's a small thing, we can wait until tomorrow (my) morning.

+1 for merging this.

@ricardozanini This issue has been caused because in HandleStatusChange method of KogitoBuild we are hard code creating condition object of v1beta.KogitoBuildCondition which is belong to community kogito-operator whereas it should be interface dependent.
We had already fixed this scenario in KOGITO-4469, those PR is currently under review.


Can't disable jsonEditor for one endpoint

Context

hapi-swgger version: 9.1.1
any other relevant information:

What are you trying to achieve or the steps to reproduce ?
I have set jsonEditor: true on my main plugin initialization but one of my services requires a raw json dump. it seems I cannot get the large json textbox to appear when jsonEditor is true.
When I try to disable it for one service via:
config: {
      plugins: {
        'hapi-swagger': {
          jsonEditor: false,
          options: {
            jsonEditor: false
          }
        }
      }

I still get no text entry field
What result did you get?
jsonEditor produces a +/- box with no ability to enter any text.
What did you expect ?
A full text json field

Anyone know if this is possible?

json editor support was dropped in recent versions of swagger-ui which hapi-swagger uses for json editor support. PRs are welcome to fix older versions.


If you login in with a user account other than the jupyterhub installation account, user spwaning does not work

There are huge bugs in this open source. Problem: If you login in with a user account other than the jupyterhub installation account, user spwaning does not work, and a '404 not found' page is displayed.
Because of this module, I'm in tears once again while switching from jupyterhub to jupyterlab. Should I master labextension development? Please confirm.
jupyterlab : 3.4.7>=3.3.2

It's my fault. You forgot to specify the user group. So the problem was solved.

Hi @gigascake,
I'm glad you found the solution to your problem.
However, I just wanted to stress some important problems in your first comment of this issue:

"There are huge bugs in this open source": I think this is not appropriate to open an issue with this kind of introduction. This doesn't make maintainers in a good position for helping you. Please moderate your words, even if you're upset. At the end of the comment, I can see a "Please", but it sounds more like an order to me.
Your problem is really unclear, it's impossible to understand the link with your problem and this repository. Please try to better explain the bug you encounter the next time you open an issue.

I hope this module is still useful for you, and you'll keep in mind my answer here for any issue you might raise here or in other open source projects.

sorry. I'm not used to English, so it was rude. Thanks for making a great module.


[fix] Install commands for all the packages

Status
PRODUCTION / DEVELOPMENT
Description
#1853
Required by #1813
Requires #1664 #1812

@sgermanserrano indeed. Only libraries that are used outside its own node are installing headers.

@sgermanserrano thank you so much for testing.! I’ll merge once I test the ouster submodule. Which is also missing install commands.

Fixed  ouster as well


iOS: duplicated border if multiple toolbars in ion header

Short description of the problem:
If I put multiple toolbars in an ion-header there is an border between this toolbar
What behavior are you expecting?
No Border between the toolbars
Steps to reproduce:
See Plunkr http://plnkr.co/edit/7trkahTuBd6xK9Rx7kNs?p=preview
Here is a workaround
.ios .toolbar-background:last-of-type{
  border-bottom-width: 1px;
}

.ios .toolbar-background:first-of-type{
  border-top-width: 1px;
}

.ios ion-header .toolbar .toolbar-background{
  border-top-width: 0;
  border-bottom-width: 0;
}

Versions
Your system information:
Cordova CLI: 6.2.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10
Ionic CLI Version: 2.0.0-beta.30
Ionic App Lib Version: 2.0.0-beta.16
OS: Distributor ID:	Debian Description:	Debian GNU/Linux 8.5 (jessie)
Node Version: v5.12.0

This is the intended behavior as we don't know which toolbars you want/don't want borders on. You can use no-border-top and no-border-bottom to remove borders. See the changelog: https://github.com/driftyco/ionic/blob/master/CHANGELOG.md#200-beta10-2016-06-27
Thanks for the issue!


Use Symfony as root namespace

Panthere\ becomes Symfony\Panthere\

PR description should be updated though, to describe the right namespace


IpGroups Changes

Reference Pull Request that has been review : https://github.com/Azure/azure-rest-api-specs/pull/7129
The files are same and moved from August to October release branch.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Reference Pull Request that has been review : #7129
The files are same and moved from August to October release branch.

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

Automation for azure-sdk-for-go

@ssripadham please resolve merge conflicts

/azp run

SDK jobs are failing with Error response from daemon: received unexpected HTTP status: 503 Service Unavailable
Will retry later

/azp run

/azp run

/azp run


Move to ES6

I would like to (re)evaluate if we should port our code base from CoffeeScript to ES6. Atom is slowly moving away from CoffeeScript as well.
My main motivation is to move Hydrogen closer to nteract and be able to use all ES6 features.
I just made a quick example plugin for Hydrogen in ES6 and was really surprised how easy it was.
We don't need a build step, we only need to add 'use babel'; on top of the file and Atom takes care of the rest.
I don't feel strongly against CoffeeScript but if think we should have this discussion.
@rgbkrk @n-riesco @nikitakit What do you think?

I'm certainly more likely to contribute if it's ES6 instead of CoffeeScript.

Also note that since the latest Atom uses Node v4.4.5, in some cases 'use babel'; may be avoided too.

I'm certainly more likely to contribute if it's ES6 instead of CoffeeScript.

For me this argument is sufficiently to switch. 😄
And I imagine you are not the only one.
@n-riesco Node 4.4.5 doesn't support all ES6 features so this could lead to strange errors. With babel we would be definitely on the save side.
One sad thing, we would lose our position in the github developers ranking for coffeescript 😜

On 11/11/16 16:44, Lukas Geiger wrote:

@n-riesco https://github.com/n-riesco Node 4.4.5 doesn't support all ES6 features http://node.green/ so this could lead to strange errors. With babel we would be definitely on the save side.

I chose my words carefully for that reason. A few more thoughts:

I think the most compelling argument to start using Javascript is to lower the hurdle our contributors have to jump.

Using all the ES6 features may put off some developers that work mostly with browsers.

Since version 1.0.0 is coming soon, this is a perfect time to plan this transition.

Do you have anything in mind about what this transition to JS would look like?

I think the most compelling argument to start using Javascript is to lower the hurdle our contributors have to jump.

That's the reason why I raised this discussion.

Using all the ES6 features may put off some developers that work mostly with browsers.

I agree. I'm not familiar with them either but we could use them if we need to.

Do you have anything in mind about what this transition to JS would look like?

If we really wan't to move to JS I would propose this short term plan (post 1.0.0):

I'll be traveling to NY on monday (wooo 🎉 ) and have some time during the flight to do boring tasks, so I volunteer to move the entire codebase to JS (including eslint). Probably with the help of decaffeinate. The only thing I fear and will probably miss is the existential operator in coffeescript.
Then we should discuss (probably in a dev meeting) how we'd like to move forward. I really want to make use of more code from nteract (kernelspecs, enchannel, rx-jupyter, ...).

I don't have the background in JS you have. So if you say moving to JS just for the sake of change doesn't make sense, I'm absolutely OK with it.

No opinion on language change.
But if you do end up switching to JS, please make sure that all the files use strict mode. ('use babel' should include this, but otherwise you may need  'use strict' at top of each file)

I'm happy even if I'm writing vanilla ES5, we probably aren't going to use most ES6 features. Even node 4 was a dramatic improvement.

The only thing I fear and will probably miss is the existential operator in coffeescript.

Our best bet here is to rely on lodash heavily with _.has, _.at and _.get. Lodash has excellent deep path support. We already have it as a dependency if I recall correctly.

It would be neat to see if you can convert single files within the code base to JS (with use babel; at the top) yet still require them from coffeescript in Atom.

It would be neat to see if you can convert single files within the code base to JS (with use babel; at the top) yet still require them from coffeescript in Atom.

That totally works!

The only thing I fear and will probably miss is the existential operator in coffeescript.

I never tried to convert a project from CS to JS, so this is going to be a good opportunity to gain some experience. At first, I'd try to decaffeinate only one module.
As Kyle suggests above, taking the route of _.has et al. seems the most straight forward replacement for ?. This route will raise the hurdle for new contributors and make more difficult to remove the dependency on lodash (if we ever wanted to). As a guideline, mostly for the sake of a lower hurdle for new contributors, I'd try to limit the use of lodash to the necessary cases.

I don't have the background in JS you have. So if you say moving to JS just for the sake of change doesn't make sense, I'm absolutely OK with it.

This was Slava's thought, but in this case there is a reason for changing to JS: gaining new contributors.


Bug: argv issue while running metacall-deploy with metacall runtime

🐛 Bug Report
metacall/install#23
When we execute metacall-deploy with the metacall runtime, it throws a warning like:
! 0x223eb60, 0x7f8c8d873e00 does not exists as a valid command.
Expected Behavior
metacall-deploy should have been able to parse the argv (--version) and should have returned the version of metacall-deploy.
Current Behavior
metacall-deploy is taking some pointers as argv which is not an expected behaviour
Possible Solution

Steps to Reproduce

Install @metacall/deploy somewhere inside /gnu/lib using metacall npm i -g --prefix=/gnu/lib/some_folder @metacall/deploy
Execute @metacall/deploy dist/index.js with metacall runtime like below

metacall<EMAIL_ADDRESS>--version
Context (Environment)
Operating System -> MintOS (Linux)

@aakritiawasthi thanks for reporting, I have solved this bug in the last commit on my PR: https://github.com/metacall/core/pull/504
I will merge this into develop and tag a new version as soon as possible.


if auth server revoke the refresh token, refreshToken() method call …

infinite loop of refreshToken() method calls if auth server revokes the refresh token.

Hi @okrad
When you revoke the refresh token and auth token manually from your OAuth server,  this error occurs.  So I have a Keycloak auth server and when I revoke all the sessions, I faced this issue,
in this case most important modifications was to me is replacing tokenStorage.deleteToken(scopes ?? []); with the tokenStorage.deleteAllTokens() , because  tokenStorage.deleteToken(scopes ?? []);  will not clear the refresh token completely  so it will try to refresh using the existing refresh token and it keep getting fails because when I revoke the refresh token from the server.
I think you can check it if you try to recreate this problem as I mentioned.

I think what's most important to understand is why deleteToken doesn't clear the refresh token...
Could it be that the value of the scopes parameter when the deleteToken is called doesn't match with an actual stored token?

I 'm having the same issue of infinite loop using keycloak. It happens randomly, maybe some automatic rule revoke something.


defining new css file and using it as class

I'll have to rename this later, but might give you a good idea what I would like to do

BTW, before approving / merging, can we have a quick chat about this?

The question is, does this work?   I didn't think Foundry automatically reads CSS files from the "styles" directory.    I have seen most other projects use some kind of 3rd party tool (like less) to split up their CSS into manageable chunks, and then combine it into a single CSS for Foundry.  But I am NOT a CSS (or a Foundry expert).

I'm not a web developer either, but I generally don't like to hardcode sizes into things, generally preferring to use relative measures (like % or fr). Also;  I like to name the container and then use child selectors to individually size the sub-elements.

I found out that we can separate our CSS, so long as we identify it in the system.json, so we CAN break it apart (and we have started to do so).
As for that particular html, it is a direct copy of the HTML export that GCS creates..   If Rich changes his HTML output and we want to use it, we will either need to copy it whole again and reapply all of our framework changes or we will have to go through it manually to figure out how the HTML has changed and then apply the CSS/HTML changes.    Not a good situation in either case.
Finally, I agree wholeheartedly with Jeff... I am learning this whole CSS stuff, and I can certainly see the advantages.

Good stuff, lads!
I'm happy to continue with my implementation of this.
I was unable to put in any time into it the last few days because of boring
stuff like people actually paying me for my time... Hehe!
On Sun 6 Dec 2020, 02:19 Chris Normand<EMAIL_ADDRESS>wrote:

I found out that we can separate our CSS, so long as we identify it in the
system.json, so we CAN break it apart (and we have started to do so).
As for that particular html, it is a direct copy of the HTML export that
GCS creates.. If Rich changes his HTML output and we want to use it, we
will either need to copy it whole again and reapply all of our framework
changes or we will have to go through it manually to figure out how the
HTML has changed and then apply the CSS/HTML changes. Not a good situation
in either case.
Finally, I agree wholeheartedly with Jeff... I am learning this whole CSS
stuff, and I can certainly see the advantages.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/crnormand/gurps/pull/76#issuecomment-739444572, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABY65UXRARAQOMVFLGUBZZTSTLS4VANCNFSM4UKX6V5A
.

Took me a little while to start contributing again, but here I am!!!

Took me a little while to start contributing again, but here I am!!!


Is there a way to pass the client's timezone with login?

I see that zoneinfo is one of the default profile claims in OpenId Connect. I'm trying to figure out how to pass the client's timezone to the server on login to populate this claim. Is there a way to do this with OIDC client?

extraQueryParams? https://github.com/IdentityModel/oidc-client-js/wiki


[FileDrop] accept prop not working for drag-and-drop

Describe the bug
The accept prop in FileDrop is not validating the file type for 'drag-and-drop' style file imports.
The 'browse' variant properly validates.
To Reproduce
Steps to reproduce the behavior:

Go to https://carbon-addons-iot-react.com/?path=/story/watson-iot-filedrop--accept-json
Import a file that's not .json
See that it successfully uploads

Expected behavior
It should only allow files of the types specified in the accept prop.

I would recommend refactoring to use FileUploader instead of FileDrop. FileDrop was created before FileUploader (from Carbon) supported drag and drop. Now that FileUploader has drag and drop support, is there anything preventing you from using FileUploader instead of FileDrop?
We absolutely can keep it around and fix this specific issue if needed, but so far we haven't heard anything preventing deprecating FileDrop, https://github.com/carbon-design-system/carbon-addons-iot-react/issues/611

Won't fix. Component will soon be deprecated as it should be replaced by Carbon version https://carbon-addons-iot-react.com/?path=/story/fileuploader--drag-and-drop-upload-container-example-application


Include ROM API symbols

Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝

[x] I have updated existing examples or added new ones (if applicable).
[x] I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
[x] My changes were added to the CHANGELOG.md in the proper section.
[x] I have added necessary changes to user code to the Migration Guide.
[x] My changes are in accordance to the esp-rs API guidelines

Extra:

[x] I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖
Description
Since users seem to struggle with including the rom_functions.x from esp-wifi we now include everything needed in esp-hal which shouldn't hurt. Hopefully also the process of updating is a bit easier now.
Once this PR landed there will be a follow up PR to remove the linker scripts from esp-wifi-sys.
skip-changelog because of changes in esp-hal
Testing
Examples still work

skip-changelog because of changes in esp-hal

To be fair I'm pretty sure that "No need to include rom_functions.x manually" belongs to the changelog :D

skip-changelog because of changes in esp-hal

To be fair I'm pretty sure that "No need to include rom_functions.x manually" belongs to the changelog :D That, or the migration guide is in the wrong crate :)

mhhhh - but that applies to esp-wifi not esp-hal (and it's mentioned in esp-wifi's changelog)

But the migration guide you edited applies to esp-hal 🙃

But the migration guide you edited applies to esp-hal 🙃

oops - yeah that's the wrong crate

skip-changelog again - see above


Partial rollback of #2260

This has caused training divergences in some LM setups using bfloat16.
Temporarily rolling it back until we better understand this issue.

I did part of the requested analysis. The float32 numerics generally agree for all versions of log_softmax. In bfloat16, the stop_gradient version is closer to the f32 numerics than without stop_gradient when measured with inputs & cotangents sampled from jax.random.normal.
This is surprising, given that the version without stop_gradient matches the f32 training curve, while including it causes a divergence. I don't have a strong conclusion for why this may be the case.
I did identify that grad(log_softmax) in bf16 is biased to be too high, because exp when computed in f32 and casted to bf16 is biased to be too low. The errors in the version without stop_gradient oppose this bias; it's possible that this helps during training.
I implemented a jax.custom_vjp for log_softmax following the TensorFlow gradient definition. It's both faster and closer to the f32 numerics than both the alternatives. This still doesn't match the f32 curves, but is closer than the current version.
Given that we don't understand why the version with worse numerics and slower runtime seems to imitate f32 better in practice, I think we should not merge this PR. Everyone using f32 benefits from current HEAD, and the benefits for bf16 folks are unclear.
I've worked around this by just computing log_softmax in f32.
The aforementioned custom_vjp gives a small speedup and reduction in activations stored. If it can be rewritten as a custom_jvp (not sure how), I'd recommend adding it to HEAD:
@jax.custom_vjp
def log_softmax(x):
  return jax.nn.log_softmax(x)

def lsm_fwd(x):
  out = log_softmax(x)
  return out, out

def lsm_bwd(res, g):
  out = res
  dx = g - jnp.sum(g, axis=-1, keepdims=True) * jnp.exp(out)
  return (dx,)

log_softmax.defvjp(lsm_fwd, lsm_bwd)


"Hook can only be invoked from render methods" on Next.js + Preact

Using next-plugin-preact :

Can you show how do you use Counter and the full code of Counter file?

Can you show how do you use Counter and the full code of Counter file?

components/Counter.tsx
import React from 'react'
import { MdAdd, MdRemove } from 'react-icons/md'
import { useStore } from '@nanostores/preact'
import { _counter, increment, decrement } from '@/store/counter'

function Counter() {
  const counter = useStore(_counter)

  return (

      <button
        className='rounded-full bg-white p-1 text-2xl text-gray-800 opacity-70'
        onClick={() => decrement(1)}
      >
        <MdRemove />
      </button>
      {counter}
      <button
        className='rounded-full bg-white p-1 text-2xl text-gray-800 opacity-70'
        onClick={() => increment(1)}
      >
        <MdAdd />
      </button>

  )
}

export default Counter

store/counter.ts
import { atom } from 'nanostores'

export const _counter = atom(0)

export function increment(num: number) {
  _counter.set(_counter.get() + num)
}

export function decrement(num: number) {
  _counter.set(_counter.get() - num)
}

You can check the template in here https://github.com/NekoChanTaiwan/nextjs-lite-template

Sorry, I used Preact only a few times and have no enough experience with this bug.

It's ok, same as me, I just try to play around Preact and make a lightweight template for Next.js.
And I found a solution for this problem, I copied the useStore.js from this repo,I just replaced
import { useState, useEffect } from 'preact/hooks' to import { useState, useEffect } from 'react' ,
and it is working, I think the bug is because I'm using next-plugin-preact plugin for Next.js.
here is my modified version:
code: https://github.com/NekoChanTaiwan/nextjs-lite-template/blob/main/hooks/useStore.ts#L4
I also test the @nanostores/preact in Vite + Preact + TS, and It is work fine.
repo: https://github.com/NekoChanTaiwan/preact-nanostores
preview: https://preact-nanostores.vercel.app/

Seems like the issue coming from Next.js Preact hacks. I am closing issue since it is envrionment related.


error loading the template

I received this notification when trying to deploy this template:

There was an error loading the template from URI 'https://raw.githubusercontent.com/Azure/azure-devtestlab/master/ARMTemplates/301-dtl-create-lab-with-existing-vnet/azuredeploy.json'. Ensure that the template is publicly accessible and does not have any comments.

Any suggestions as to how to fix it?

Hey, am trying to clone the reo to local machine, customize the script and run the code from my private repository is giving me error "There was an error loading the template from URI 'https://'. Ensure that the template is publicly accessible and does not have any comments". Can yu help me, i need to run this from private repo.

@NawazishS, you need to give us more information. Can you provide which template you are working with, what changes you made, and what parameters you are passing to the template?


cache.update_file_date() only works on skins, not capes

It's called by cache.update_timestamp and only updates 'face' images. Of course that doesn't work when it's called with the hash of a cape file.
I think updating file dates was originally (thought to be?) used by the cleaner to delete the oldest files, but that's not the case currently. It also doesn't delete cape files, either.

Obsolete as we no longer have that function.


l real estate job denver

Challenge Name

Issue Description

Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

Screenshot

Closing as this is not an issue with the website. Please fill out the issue template if you have an issue. Happy coding!


How to add border radius to images in a composite image?

I am using the sharp library in my Node.js project to composite a grid of images into a single image.
I have successfully created the composite image, but I need to apply a border radius to each of the images in the grid.
How to remove the black color background?
Thank You.

const sharp = require('sharp');
const axios = require('axios');
const fs = require('fs');

//dummy image lists, the real data will be fetched by api
const imageUrls = Array(25).fill("").map((el, i) => `https://picsum.photos/id/${i}/1280/720`)

//basic setting
const productWidth = 1080
const productHeight = 1080
const row = 5
const col = 5
const gapSize = 10;

//length - padding * 2 - gap * row
const imageWidth = (productWidth - gapSize * (row - 1) - gapSize * 2) / row; //204
const imageHeight = (productHeight - gapSize * (col - 1) - gapSize * 2) / col; //204
const borderRadius = 20;
console.log(imageWidth, imageHeight)
//for border radius
const mask = Buffer.from(
  `
  <svg xmlns="http://www.w3.org/2000/svg" width="204" height="204">
    <g>
      <rect
        transform="rotate(45 102 102)"
        rx="20"
        height="135"
        width="135"
        y="34.5"
        x="34.5"
      />
    </g>
  </svg>
  `
);

const imagePromises = imageUrls.map(async (url) => {
  const response = await axios.get(url, { responseType: 'arraybuffer' });
  const image = sharp(response.data);

  if (image) console.log('downloaded image')

  return image.resize(imageWidth, imageHeight, { fit: 'cover' }).composite([{
    input: mask,
    blend: 'dest-in'
  }]).toBuffer();
});

async function compositeImages() {
  try {
    const images = await Promise.all(imagePromises)
    //init canvas
    const canvas = sharp({
      create: {
        width: productWidth,
        height: productHeight,
        channels: 4, // RGBA
        background: { r: 255, g: 255, b: 255, alpha: 1 }
      }
    });

    //draw images
    const compositeArr = images.map((buffer, index) => {
      const colValue = index % col
      const rowValue = Math.floor(index / col)
      const x = gapSize + colValue * (imageWidth + gapSize)
      const y = gapSize + rowValue * (imageHeight + gapSize)
      return {
        input: buffer,
        left: x,
        top: y,
        blend: 'atop'
      }
    })
    //download final product
    canvas.composite(compositeArr)
      .png()
      .toBuffer()
      .then((buffer: any) => {
        fs.writeFileSync('banner.png', buffer);
      });
  } catch (error) {
    console.log(error)
  }

}

compositeImages()

It looks like imagePromises contains an array of JPEG images, which do not support an alpha channel. Perhaps use PNG for the intermediate images, something like the following:
     blend: 'dest-in'
-  }]).toBuffer();
+  }]).png().toBuffer();
 });

I hope this information helped. Please feel free to re-open with more details if further assistance is required.

Worked for me, thanks

I had to tweak the code a bit, but it worked like a charm. The only problem was that I was using .jpg for my images which was showing black corners at the edges while I was applying border-radius. It turns out the solution was to use .png image format. As @lovell said above, that png supports background: transparent property. While JPG format does not support an alpha (transparency) channel.


what happened to Position and Velocity pass?

I'm looking at this older example:
http://www.neveroccurs.com/lab/three.js/gpu_particles/index.html?particles=256
and see that they use two passes that aren't available:
WagnerPositionPass.js
WagnerVelocityPass.js
I was wondering why they got dropped, or if they still exist but are called something else?
I'm working on a project that has tens of thousands of particles and I need to animate them using vertex shaders -- would using wagner be a viable solution?

Hi, they didn't get dropped, those were done by @fazeaction as an experiment. There's an ongoing development to add generic simulation passes to Wagner.
Even though this answer probably comes very late for your project, yes, you can use Wagner as an FBO/DataTexture manager to run simulations on the GPU.


Add SGR 51, framed.

Implements SGR 51 and draws a frame around each glyph. Tested using shell command
echo -e "Hello \e[51mFramed\e[54m" and not
Currently the result looks like in the image below where each letter is surrounded by a box.

Is this the desired result or should it be more like
      ----------
Hello | Framed | and not
      ----------

I'm not sure how to do the second version.

Many thanks for your contribution.
The second could be achieved using cell attributes grouping. I do that already to optimize performance for background renders as well as for proper text shaping.
But I think the first version is right. Although it looks like the lines are too thick? What's the pixel line width?

Many thanks for your contribution.
The second could be achieved using cell attributes grouping. I do that already to optimize performance for background renders as well as for proper text shaping.
But I think the first version is right. Although it looks like the lines are too thick? What's the pixel line width?

I think this is due to drawing the right line of 1 box and the left line of the adjacent box. The thickness of the lines are
auto const thickness = max(lineThickness_ * baseline / 3, 1u);

Hey,
I managed to make it look slightly more interesting:

with the following diff:
diff --git a/src/terminal_view/DecorationRenderer.cpp b/src/terminal_view/DecorationRenderer.cpp
index f119c94..cb0ca6b 100644
--- a/src/terminal_view/DecorationRenderer.cpp
+++ b/src/terminal_view/DecorationRenderer.cpp
@@ -188,20 +188,21 @@ void DecorationRenderer::rebuild()
     } // }}}
     { // {{{ framed
         auto const cellHeight = screenCoordinates_.cellHeight;
-        auto const thickness = max(lineThickness_ * baseline / 3, 1u);
+        auto const thickness = max(lineThickness_ * width / 20, 1u);
         auto image = atlas::Buffer(width * cellHeight, 0u);
+        auto const gap = thickness;

         // Draws the top and bottom horizontal lines
-        for (unsigned y = 0; y < thickness; ++y)
-            for (unsigned x = 0; x < width; ++x)
+        for (unsigned y = gap; y < thickness + gap; ++y)
+            for (unsigned x = gap; x < width - gap; ++x)
             {
                 image[y * width + x] = 0xFF;
                 image[(cellHeight - 1 - y) * width + x] = 0xFF;
             }
-
+
         // Draws the left and right vertical lines
-        for (unsigned y = 0; y < cellHeight; y++)
-            for (unsigned x = 0; x < thickness; ++x)
+        for (unsigned y = gap; y < cellHeight - gap; y++)
+            for (unsigned x = gap; x < thickness + gap; ++x)
             {
                 image[y * width + x] = 0xFF;

The smaller the font, the lesser obvious it is that those frames are disconnected. I don't think that's an issue at all, because I think that one would want to make only a single cell framed, and multiple connected ones at once (unless it is for TUI debugging or so? :D)
You can apply that diff on top of your PR.

Wow nice, you are still awake. If you feel ready, just move out of draft mode.

We've merged it behind the wall of Github.


Hi, is this project still active?

Same question here

I would be open to taking & maintaining this project. @IT-MikeS let me know how best to go about this if you're interested! Lots of great work you have here that I would love to uphold.

@coopbri sure thing, I’ll add you as a collaborator for now that way you can play with the repo more freely.

@IT-MikeS tried to ping you on Twitter, would you mind following me there so I can DM you about this project or send e.g. an email address?


API Documentation - Common / DataSource mgmt. and Query / Connection mgmt.

Is your feature request related to a problem? Please describe.
In order to facilitate the maintenance of source code changes, the API documentation needs to be processed within the source code project.
First, create parts of common, data source management/query and connection management.
Describe the solution you'd like

Create an API guide document by assigning the API document directory in the project.
When the API related source code is changed, the document is also modified so that it can be released at the same time.
Uses Asciidoc as the text document format.

Additional context
We will continue to add document about APIs

@alchan-lee check uri "/docs/api-guide.html"


HL7-2523 Create CosmoDB Proxy on lib-dex-commons

NEEDS TO BE ADDRESSED:  To avoid pushing hardcode access key for cosmos, I redacted it from CosmosClientTest.kt file.  With this redaction, the tests will fail.  Need to implement solution for this type of software packaging and deployment.
Also, I faced build difficulties due to another test.  Will investigate.


[Create Workshop] - Handler for loading images

Display error snack bar message that some images was not loaded properly.
Capture this error and display message about the existed error

Message Bars:

show the success message bar if workshop is created/updated;

if there is only one error picture -> show an index of this error picture + error
if there is more than 1 image picture, show the quantity of the error images + the type of error


Bug: cannot cancel source statement by ctrl-c

Steps
ydsh-0.18$ source! /dev/dri/renderD128

Problem
cannot interrupt by ctrl-c

now the above example is not work (semantic error). close in 03e390707647c3e8258e1cc8b7c3526b09ebec13


Added Timor Leste

I propose to add Timor Leste

🚀 Deployed: https://welcome.osm.be/asia/east-timor/list


UX improvements for the expand mechanism

UX of the expand mechanism can be improved in many points:

[ ] It's not navigable by keyboard
[ ] The button is a lot smaller and thus harder to hit than before (Fitts' law)
[ ] The button says "Show/Hide package details" even when searching options
[ ] Placing the button onto the separator line is a weird choice. This makes it feel like the button is not related to one search entry, but between two. It also isn't 100% clear whether it refers to the item above or below the line.

From https://github.com/NixOS/nixos-search/issues/272#issuecomment-766807288_. Sorry @garbas, no medal for me today ^^

@piegamesde Do you maybe have some suggestion how would you fix the expand mechanism?

@piegamesde Do you maybe have some suggestion how would you fix the expand mechanism?

Did the old site do something wrong in that regard? If I remember correctly, the whole list item was a button and it worked just fine. Alternatively, I see two approaches:

Related to the previous way of doing it, have a toggle button on the side that expands the item down (think of Accordion menu)
Have a "show more"/"show less", which would be more similar to the current implementation. Important there:

Make the button permanently visible and accessible by keyboard
Move the button above the separator line

Did the old site do something wrong in that regard? If I remember correctly, the whole list item was a button and it worked just fine. Alternatively, I see two approaches:

Related to the previous way of doing it, have a toggle button on the side that expands the item down (think of Accordion menu)
Have a "show more"/"show less", which would be more similar to the current implementation. Important there:

Make the button permanently visible and accessible by keyboard
Move the button above the separator line

Sorry for jumping in but I think I might be best equipt to clarify few things.
Before I do so I want to make it clear that we're glad that you've opened the issue because every data-point counts. That's being said for sake of tracking all the information I'll link few things related to the points.

It's not navigable by keyboard

This is not true. In fact the reason why the whole item is no longer clickable is to make keyboard navigation possible. See this issue: https://github.com/NixOS/nixos-search/pull/259 . When whole item was clickable browser was unable to find any focusable element so keyboard navigation was not working. Fix to this issue than caused this issue https://github.com/NixOS/nixos-search/issues/271 since having the focusable button element also means it's not possible to select text within the element.
TL;DR issue like this are hard to resolve because different people care about different things and it's hard to keep everyone happy.
Anyway the keyboard selection does in fact work. as you can see:

All you need to do is to use tab to select the title of item you want to expand and then press enter.

The button is a lot smaller and thus harder to hit than before (Fitts' law)

you can still click on title as far as I know before there was no button at all and thing opened by clicking on item. But then it was hard to select text - see https://github.com/NixOS/nixos-search/pull/261#issuecomment-758348509

Placing the button onto the separator line is a weird choice

This was raised before as well in https://github.com/NixOS/nixos-search/pull/261#pullrequestreview-573543088 and we hope to address it soon

Sorry for jumping in but I think I might be best equipt to clarify few things.
Before I do so I want to make it clear that we're glad that you've opened the issue because every data-point counts. That's being said for sake of tracking all the information I'll link few things related to the points.

It's not navigable by keyboard

This is not true. In fact the reason why the whole item is no longer clickable is to make keyboard navigation possible. See this issue: https://github.com/NixOS/nixos-search/pull/259 . When whole item was clickable browser was unable to find any focusable element so keyboard navigation was not working. Fix to this issue than caused this issue https://github.com/NixOS/nixos-search/issues/271 since having the focusable button element also means it's not possible to select text within the element.
TL;DR issue like this are hard to resolve because different people care about different things and it's hard to keep everyone happy.
Anyway the keyboard selection does in fact work. as you can see:

All you need to do is to use tab to select the title of item you want to expand and then press enter.

The button is a lot smaller and thus harder to hit than before (Fitts' law)

you can still click on title as far as I know before there was no button at all and thing opened by clicking on item. But then it was hard to select text - see https://github.com/NixOS/nixos-search/pull/261#issuecomment-758348509

Placing the button onto the separator line is a weird choice

This was raised before as well in https://github.com/NixOS/nixos-search/pull/261#pullrequestreview-573543088 and we hope to address it soon

Doing some issue maintenance while I plan my work. The expand mechanism is going to be address with #286 .


[Documentation] Specify the default compiled sqlite extensions

Is your feature request related to a problem? Please describe.
Looking through the documentation, I couldn't find anything about which extensions were enabled during compilation by default.
For example, not all sqlite amalgamations in different languages choose to turn on the FTS5 extension, I wanted to know if it would work with this driver or not out of the box.
Describe the solution you'd like
Document the important sqlite extensions compiled here: https://github.com/xerial/sqlite-jdbc/blob/master/Makefile#L80-L104
If this was something thought about at some point, it would be nice to mention why or why not certain extensions get enabled,  and what the criteria for a new one to get added would be. For example, would this project ever consider adding community sqlite extensions? I'd guess not, but it's not super clear.
Describe alternatives you've considered
Having users read through the code and find the Makefile... not great.
Additional context
N/A

PRs are welcome :-)


Why we can not get the same curves especially on ResNet 34 and ResNet 101 ?

Thank you for your Resnet implementation with MxNet. This is a good example especially for beginner.
I still follow this project and follow the train steps for imagenet. We want to reproduce your results.

However, except ResNet 18, ResNet 34 and ResNet 101 we can not get the same curves. It is shown as below:

we follow the instruction step by step and set the same size of input image and learning rate schedule. Only batch size and GPUs is different. Such as, in ResNet 34, the batch size is 256 and 2 M40 GPUs are utilized; in ResNet 101, the batch size is 96 and 4 M40 GPUs are used. We have executed experiments on cifar 10 with ResNet 164 among different batch size (16, 64 and 128). The performance almost same and even better when smaller batch size is used. So, we don't know why we can not get the same curves. Please tell us more detailed information how to train ResNet 34 or even deeper ResNet from scatch. Thank you very much.

@zhoubinxyz hi, differents gpu has no influence on the training curve,but batch-size influence not, especially for imanget, which is more bigger than cifar10.
i suggest using batch-size in [256, 512].
anther, all the training log and detail is in the log directory, you may found more information to check your training. and do not using the rec quality=80. thanks.

@tornadomeet
Thanks for your prompt reply.
We are now training with ResNet-34 with batch-size 512, see if we can get same result.
We are using quality=90 according to your instruction. Do you think we need to set quality=100?
Best Regards,
Zhou Bin

no need quality=100, you'd better using 90 or 95(which caffe using, and the default value in MXNet is changed form 80 to 95). another, i'm not sure whether the newest mxnet will influence the training. you may try the mxnet version in log description.

@tornadomeet
Thanks for your prompt reply.
Ok, we use quality = 90. We just begin train ResNet 34 with batch size 512 on 4 M40 GPUs. Let us to see the error curve whether can get the same curve as yours. This also can give a clue whether different version will influence the training. Thanks!

@bruinxiong   any news?

@austingg Based on the suggestion from @tornadomeet , we retrain ResNet-34 with batch-size 512 (256 is adopted at first time). We obtained the similar results. We also try ResNet-50 with the same batch-size and learning rate schedule. The similar results also be obtained. For ResNet-101, because we haven't 8 GPU, we can not get the similar results as @tornadomeet did. So, we are curious the reason that different batch size have large difference on performance.  We think there must not be the larger the better. Different dataset has different situation, because for cifar 10, smaller batch size even get better results. So, we have a question, is there any relationship between batch size and the scale of dataset, theoretical ?

In this figure, xxxx-2 is our second time experiment with the suggested batch size.

@bruinxiong thanks. I am also doing some experiments on resnet-18 with batch size 256. 256 is worse than  512. and there is no theoretical relationship between batchsize and dataset size, currently it is still a hyperparameter :sob:

the difference of bigger and smaller batch-size will lie in >=95 epoch, so should train more.
actually, there is some theoretical about batch-size, it relates to variance, ref paper: Coupling Adaptive Batch Sizes with Learning Rates

@bruinxiong, I have trained a renset-18 using this code with batch-size 256, after 4 days training, the result is a little better(30.4% error rate) than 512 batchsize. You may try resnet-34 with batch size 256, but should be patient, bigger batch size converge faster at the begining.

@austingg Thank you for your sharing. If you apply batch-size 256, do you change the learning rate schedule ? Based on many researches (some come from university, some come from industry) suggestions, for batch size, the larger the better, specially for large dataset (maybe it is not strictly and need to be verified.).  Maybe randomness is not larger the better. We are training ResNet 101, due to the GPUs resource, we use 4 M40 GPUs only and batch-size 225 not 480, with the similar learning rate schedule as ResNet 50. The curves are shown as below

the purple curve is our third time training result.

@bruinxiong lr decreases at 30, 60, 90, and at 98 remove the imgressive data augmentation.

@bruinxiong lr decreases at 30, 60, 90, and at 98 remove the imgressive data augmentation.

Hi austingg, do you know why removing the imgressive data augmentation in the last few epoches? From the curve it seems improving the result, but why do this?


create_result returns x with lowest observed f(x), not lowest predicted f(x)

This seems wrong to me. The optimizer seems to be aware of its uncertainty, re-evaluating the "fluke point" and discovering that it's actually not usually that great. But then it gives me the fluke point at the end! This is especially problematic when variance is non-uniform and lower near the true minimum.
Ideally, the convergence plot would be updated as well, showing the expected minimum as well as the variance around that estimate. This would lead to the convergence plot being non-monotonic, but it would converge on the true minimum rather than some other point.

Hi,
Maybe you are looking for skopt.utils.expected_minimum?
See https://github.com/scikit-optimize/scikit-optimize/blob/master/skopt/utils.py#L197

Thanks, I'm embarrassed to admit I discovered that function after posting the issue.
Still, I think my point holds, for two reasons. First, it's not intuitive that you would have to use another function to get the expected best value. The expected value is what you really care about (right?) so this should determine the primary value returned, i.e. result.x. Second because expected_minimum is not constrained to points that have been evaluated, it can return an x from a relatively unexplored part of the space. Empirically, I've found it to perform worse than the best of the tested points:
gp = res.models[-1]
res.x_iters[gp.predict(res.x_iters).argmin()]

I am not convinced there is a "right" or "wrong" answer for that.
i) At present, we return the minimum among the function evaluations. We have chosen to return that because this is the only truth we have access to. The GP is only a model of these evaluations and therefore can be wrong.
ii) expected_minimum is supposed to return the expected minimum among the predictions of the GP over the entire domain. It might indeed return a point that has not been tested.
iii) you suggest the return the expected  minimum among the predictions of the GP, over the points that have been tested.
I think all three approaches are reasonable. Maybe we could have another function for iii) (or a flag in expected_minimum). What do you think?

I'd be -1 on changing what create_results returns. It would cause confusion about what is in res.x if we change it and the current approach has the benefit of being easy to understand. Hopefully people can quickly work out what actually is in res.x and then go "ahrg, this isn't what I wanted". Combine that with some better documentation on finding expected_minimum and the difficulty of deciding what the "right" answer is. IMHO that would be pretty good.
My proposal: write a short tutorial highlighting the three choices @glouppe outlined, when you might want which one, and how to get it.

For my education: do we have an example where expected_minimum picks a point in an unexplored area? I'd have expected that the minimization procedure would place at least some samples in the vicinity of the minimum of the model.

OK, I'm convinced that res.x shouldn't change. I did some more experimentation, and found results conflicting with what I reported above—res.x now seems to perform better than expected_minimum (ii) or expected_minimum(tested_points_only=False) (iii). I think a more careful controlled experiment is in order, which could be written up as a tutorial. I'm happy to do this.
@betatim, I think your intuition is correct. This was the only explanation I could come up with for (iii) beating (ii). I was getting those results with few iterations on a very noisy objective function. So I can imagine that the final test point could dramatically change the GP and hence the expected minimum.

What do you think about writing a short notebook for the examples section that demonstrates the three different options for "the minimum"?

I would be quite interested in this myself. I often train all kinds of neural networks, and there I often get quite noisy results with fixed parameters. So for my work to be reproducible, I would be rather interested in finding points where the  expected objective value (loss at termination of training algo) is best. However, for practical applications I am simply looking for a situation with best objective. So I think it is a great idea have a notebook as you describe highlighting this. I think this will help many people to make better use of skopt.


Fix "kata-oc" node role handling

This PR modifies handling of the "kata-oc" node label so that changes of the pool of kata-enabled workers can be handled correctly.
The OSC controller now processes user-supplied label requirements internally and doesn't "publish" them in its "kata-oc" MCP nodeSelector.  Instead, if the new internal label processing results in a match for a Node the node is labelled with the "kata-oc" node role, and similarly on mismatch the controller ensures the pertinent Node does not have the node role.  The "kata-oc" node role is the single unambiguous externally-visible sign whether a Node labels did or did not match KataConfig.spec.kataConfigPoolSelector.
This, with an introduction of Node resource watching, allows us to handle correctly any changes in Node labeling that affect whether a Node question should or should not have kata installed on it.
Fixes: KATA-1928

Force-push just to fix the typo pointed out by @littlejawa .
Thanks a lot to reviewers!


Bump subgraph version to 0.1.0

Fixes #1836

@tomstuart123 please give this a test.  you SHOULD see that an existing Safe that you created that you added a snapshot ens to (and did nothing else on), should automatically load up properly without anything else on your end.


editorconfig: trim trailing spaces

Fixed the issues in test/core/prompt.spec
Added root = true
Added URL on info about EditorConfig

😲  Why didn't I think of that? 😄
Thanks, @docwhat


Add permissions to workflows

Description
When Dependabot pushes branches, or automatically merges PRs, it currently doesn't have permissions to create docker images, causing builds to fail.
Motivation and Context
Dependabot is by default given only read permissions on repositories, but it respects the repos permissions set in the workflow [1]. In order to be able to push docker images it needs packages: write permission.
You can set explicit workflow permissions by setting a permissions key in the workflows [2]. Setting these should actually be more secure then our previous configuration, as the defaults are quite permissive.
I was worried that this might give too much permissions to PRs from forks, but we don't run the docker-build workflow on forks and from the blog post:

Pull requests from public forks are still considered a special case and will receive a read token regardless of these settings.

How Has This Been Tested?
Since this is scoped to our actions workflows, the CI passing on this PR should give confidence this is working.
Checklist

[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.

My understanding from https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions is that once you set a permission in a workflow, you override all the defaults, and don't get any permissions other then the ones you specify. So changing org level permissions shouldn't change the perms in this repo.


build: explicitly pass the path to python2,python3

Explicitly pass the path to the python interpreter on macOS by using
xcrun to find the tools.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test

CC: @shahmishal @drexin

Build failed
Swift Test Linux Platform
Git Sha - fa6bedeccddb5c270c9c2fbb46e73cdbf882e527

@swift-ci test Linux