ehl_crb: tests/kernel/context tests failed

Describe the bug
kernel_cpu_idle_atomic and kernel_cpu_idle tests failed
To Reproduce
Steps to reproduce the behavior:

twister -W -p ehl_crb --device-testing --device-serial /dev/ttyUSB0 -T tests/kernel/context/ --west flash="/home/user/EHL_X86_PXE.sh"
Test results

Expected behavior
Tests should pass
Logs and console output
*** Booting Zephyr OS build zephyr-v2.5.99-ww13.4  ***
Running test suite context
===================================================================
START - test_kernel_interrupts
PASS - test_kernel_interrupts in 0.1 seconds
===================================================================
START - test_kernel_ctx_thread
Testing k_current_get() from an ISR and thread
Testing k_is_in_isr() from an ISR
Testing k_is_in_isr() from a preemptible thread
PASS - test_kernel_ctx_thread in 0.13 seconds
===================================================================
START - test_busy_wait
Thread busy waiting for 20000 usecs
Thread busy waiting completed
Thread busy waiting for 20000 usecs (irqs locked)
Thread busy waiting completed (irqs locked)
PASS - test_busy_wait in 0.56 seconds
===================================================================
START - test_k_sleep
thread sleeping for 50 milliseconds
thread back from sleep
Testing k_thread_create() without cancellation
thread (q order: 2, t/o: 500) is running
got thread (q order: 2, t/o: 500) as expected
thread (q order: 3, t/o: 750) is running
got thread (q order: 3, t/o: 750) as expected
thread (q order: 0, t/o: 1000) is running
got thread (q order: 0, t/o: 1000) as expected
thread (q order: 6, t/o: 1250) is running
got thread (q order: 6, t/o: 1250) as expected
thread (q order: 1, t/o: 1500) is running
got thread (q order: 1, t/o: 1500) as expected
thread (q order: 4, t/o: 1750) is running
got thread (q order: 4, t/o: 1750) as expected
thread (q order: 5, t/o: 2000) is running
got thread (q order: 5, t/o: 2000) as expected
Testing k_thread_create() with cancellations
cancelling [q order: 0, t/o: 1000, t/o order: 0]
thread (q order: 3, t/o: 750) is running
got (q order: 3, t/o: 750, t/o order 1) as expected
thread (q order: 0, t/o: 1000) is running
got (q order: 0, t/o: 1000, t/o order 2) as expected
cancelling [q order: 3, t/o: 750, t/o order: 3]
cancelling [q order: 4, t/o: 1750, t/o order: 4]
thread (q order: 4, t/o: 1750) is running
got (q order: 4, t/o: 1750, t/o order 5) as expected
cancelling [q order: 6, t/o: 1250, t/o order: 6]
PASS - test_k_sleep in 5.340 seconds
===================================================================
START - test_kernel_cpu_idle_atomic
Assertion failed at WEST_TOPDIR/zephyr/tests/kernel/context/src/main.c:350: _test_kernel_cpu_idle: (tms2 < tms is true)
Bad ms value computed,got 5482 which is less than 5483
FAIL - test_kernel_cpu_idle_atomic in 0.20 seconds
===================================================================
START - test_kernel_cpu_idle
Assertion failed at WEST_TOPDIR/zephyr/tests/kernel/context/src/main.c:350: _test_kernel_cpu_idle: (tms2 < tms is true)
Bad ms value computed,got 5516 which is less than 5517
FAIL - test_kernel_cpu_idle in 0.20 seconds
===================================================================
START - test_k_yield
PASS - test_k_yield in 0.1 seconds
===================================================================
START - test_kernel_thread
PASS - test_kernel_thread in 0.1 seconds
===================================================================
START - test_kernel_timer_interrupts
PASS - test_kernel_timer_interrupts in 0.4 seconds
===================================================================
Test suite context failed.
===================================================================
PROJECT EXECUTION FAILED

Environment (please complete the following information):

OS: Fedora33
Toolchain: zephyr-sdk-0.12.3
Commit ID: ecac194448da

Ok, I see this is one of those tests sensitive to timing (off by 1ms). Let's see what we find in debug. Thanks!

FWIW This/similar issue was recently resolved with patch 148769c "sched: timeout: Do not miss slice timeouts".  I can also use that as a last-known-working for git bisect to find where/why this broke again.

Perhaps this bug is not reproduceable on all EHL platforms? I'll keep trying on a different board next, because first device passed. Then debug once it's isolated.

@jenmwms : I retested this on EHL_CRB now and tests are passing. So closing this issue.

Thank you @yerabolu !


feat: Flux integration

Flux Integration With Medulla Chart

[x] You've read the Contributor Guide and Code of Conduct.
[x] You've included unit or integration tests for your change, where applicable.
[x] You've included inline docs for your change, where applicable.
[x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes
Integrated flux into the medulla chart.
Description
helm install will launch medulla chart along with the following dependancies:

flux
Istio
tidb
dapr
gitea

Fixes #99

PR is ready for review.


Automated method of setting default Start and taskbar layout for images?

I don't see a completely automated method in the documentation for setting the default Start layout and default taskbar layout for new users in an automated fashion.
Group Policy: does not set a simple default layout; instead, it locks the layout so that the user cannot make persistent changes.
ICD: sets a default layout but requires manual intervention from the IT professional.  The last step in the documentation directs the IT professional to "double-click the ppkg file and allow it to install."
Most IT professionals would want this to be automated as part of the imaging process so that no manual intervention is required at all.
Would a solution be setting the default Start layout and taskbar layout via the Import-StartLayout PowerShell cmdlet?  Would that import both the Start layout and taskbar layout for new users without locking either one from the user?  (As far as I am aware, this cmdlet uses the same XML file referenced in the documentation.)  If so, this would also allow IT professionals to make it part of the imaging deployment process as an automated script, requiring no intervention from the IT professional.
In addition, regardless of whether this works or not, is it a supported method?

Admins can use either Group Policy or MDM to deploy a partial Start layout which permits users to add their own tile groups.
Import-StartLayout applies the XML to a mounted image, and is referenced in this topic: https://technet.microsoft.com/en-us/itpro/windows/manage/customize-windows-10-start-screens-by-using-group-policy#bkmk-howstartscreencontrolworks
I will open a request for adding instructions for default Start layout to the documentation on imaging Windows 10. I can't give you an estimate of when that might be added, since it will need to be prioritized with other work requests. Thanks for the suggestion!

That cmdlet can be used with both mounted images and the online image (i.e., the image you're currently using). That's why I felt that it belongs in the existing documentation because it accomplishes a default layout just like ICD does, just without manual intervention from the IT professional.
In any case, thanks for looking.


[Tutorial Getting started with FREME development] error during "Start FREME from the command line"

See attached command line output. The error occurs then executing bin/start_local.sh

bin/start_local.sh
readlink: illegal option -- f
usage: readlink [-n] [file ...]
Fehler: Hauptklasse org.springframework.boot.loader.JarLauncher konnte nicht gefunden oder geladen werden

freme-getting-started-log.txt

It workes on my ubuntu machine. This problem might be mac specific.

I have the same problem in my MAC machine. The next code worked for me:

BASEDIR='dirname' "$0"
BASEDIR='( cd "$BASEDIR" && pwd )'

This code does not work out for me. It never finishes. Maybe we should have two start scripts, one for mac and one for linux.

+1.

I added start_local_osx.sh to the package-maker. This should start FREME from OSX. I also upgraded the broker-simple package to  use the latest snapshot version of FREME so it includes the latest start script. @fsasaki or @jmschnei can you please test to download the broker-simple package, do mvn package and then start FREME using start_local_osx .sh ?
We need to remember to switch broker-simple to the next stable version after the next release because otherwise it will stop working after a while when one of the snapshot artifacts is no longer available.

I tried the installation and it works. The script start_local_osx .sh did not work. but the script start_local.sh worked :)

Great. I tried the start_local.sh script and it works on linux as well. So I deleted the start_local_osx.sh script and the problem is solved.
I think I can explain: The artifact package-maker, that contains these start script, was used in version 0.3. There was a version 0.4, that (I guess) contained the start_local.sh file that fixes this problem. But this version was never used. When I updated the version of the package-maker in the broker-simple package I used version 0.5-SNAPSHOT, that contains the fixed start_local.sh and the new start_local_osx.sh.


Branch recommendation

Hey there!
If you are pushing people to push the develop branch...you should just make that the default branch. :)

Agreed, this was long overdue. I've merged in the develop branch to master.
Thanks!


Memory leak in blob logger

Some customers observe a memory leak when using Azure Blob logging.
Examining a memory dump showed lots of log messages stuck in the outgoing queue.
My current thinking is that writing loop somehow fails and stops consuming messages from queue.
Additionally, queue size limit is disabled by default causing the queue to grow indefinitely.

@pakrym, we are also seeing this memory leak. Here is a dump screenshot:

Any progress on this? we have to disable our logging on blob now.

@muratg 2.1.3 candidate.

@pakrym What's the risk?
If you'd like this in 2.1.5, could you fill out the shiproom template? Thanks.

We don't have a fix. Risk is an application running out of memory and crashing.

Of course I mean the risk of the potential fix.
If we need to send it to the ship room, you'll need to have a PR with the fix.

(After talking to Pavel in person, punting this to 2.1.6)

cc @DamianEdwards

Let's get this fixed for 2.2.0 then consider for servicing in 2.1.6 please.

@pakrym could you fill out the shiproom template (in the PR #823) please?

Shouldn't we fill a template when we have a fix?

My bad, yes we'll need a PR.

https://stackoverflow.com/questions/52405552/how-to-read-microsoft-logger-extension-high-memory-usage-from-dump

Is this being fixed yet folks?

Currently, I'm trying to finish all ANCM shim work before it gets locked down.

@yufeih can you please share your memory dump? How much are you logging per request? How many request per second were you getting when hitting this issue?

@pakrym Could you add the workaround here?

From what I was able to gather in my investigations it looks like it's not a memory leak per se. Current thinking is that log write falls back because of the number of logs written and we don't cap log queue by default.
The workaround is to cap the queue size and uncap the batch size in ConfigureServices:
           serviceCollection.Configure<AzureBlobLoggerOptions>(options => {
                options.BackgroundQueueSize = 1000;
                options.BatchSize = null;
            });

            serviceCollection.Configure<AzureFileLoggerOptions>(options => {
                options.BackgroundQueueSize = 1000;
                options.BatchSize = null;
            });

@pakrym - we tried the suggested configuration:
           serviceCollection.Configure<AzureBlobLoggerOptions>(options => {
                options.BackgroundQueueSize = 1000;
                options.BatchSize = null;
            });

Unfortunately another issue occurred - threads hang at adding message.
Here's the call stack from the memory dump - threads blocked at the same method

And also from the dump the queue is already full (count = 1000):

Any fix or workaround for this?


How to get user's orders and pull orderbook for one pair

as title

https://binance-chain.github.io/api-reference/dex-api/paths.html
check the api docs.
/api/v1/depth is for orderbook
/api/v1/orders/* is for user's orders


Plugin rbac-backend Fails to Initialize after upgrading to version > 5.0.0

Issue: Plugin rbac-backend Fails to Initialize after upgrading to version > 5.0.0
Description:
When attempting to initialize the rbac-backend plugin in Backstage, an error is encountered, preventing the plugin from starting properly. This issue occurs consistently, but only after the second execution of the Backstage.
Steps to Reproduce:

Set up a fresh instance of Backstage with a local PostgreSQL database.
Install the rbac-backend plugin following the official installation guidelines.
Start Backstage backend for the first time (no errors occur).
Stop the Backstage backend service.
Start Backstage backend for the second time.

Expected Behavior:
The rbac-backend plugin should initialize without errors in all executions, allowing it to function as intended within Backstage.
Actual Behavior:
An error is thrown during the initialization process, preventing the rbac-backend plugin from starting. The following error message is displayed:
backstage error Plugin 'permission' thew an error during startup type=initialization
.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:334
              throw new ForwardedError(
                    ^

ForwardedError: Plugin 'permission' startup failed; caused by Error: Failed to store policies [[role:default/rbac_admin, policy-entity, read, allow],[role:default/rbac_admin, policy-entity, create, allow],[role:default/rbac_admin, policy-entity, delete, allow],[role:default/rbac_admin, policy-entity, update, allow],[role:default/rbac_admin, catalog-entity, read, allow]]
    at <anonymous> (.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:334:21)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async <anonymous> (.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:333:13)
    ... 3 lines matching cause stack trace ...
    at async BackstageBackend.start (.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackstageBackend.ts:38:11) {
  cause: Error: Failed to store policies [[role:default/rbac_admin, policy-entity, read, allow],[role:default/rbac_admin, policy-entity, create, allow],[role:default/rbac_admin, policy-entity, delete, allow],[role:default/rbac_admin, policy-entity, update, allow],[role:default/rbac_admin, catalog-entity, read, allow]]
      at EnforcerDelegate.addPolicies (.\backstage\node_modules\@janus-idp\backstage-plugin-rbac-backend\src\service\enforcer-delegate.ts:109:15)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async addAdminPermissions (.\backstage\node_modules\@janus-idp\backstage-plugin-rbac-backend\src\admin-permissions\admin-creation.ts:125:9)
      at async setAdminPermissions (.\backstage\node_modules\@janus-idp\backstage-plugin-rbac-backend\src\admin-permissions\admin-creation.ts:149:9)
      at async Function.build (.\backstage\node_modules\@janus-idp\backstage-plugin-rbac-backend\src\policies\permission-policy.ts:108:11)
      at async Function.build (.\backstage\node_modules\@janus-idp\backstage-plugin-rbac-backend\src\service\policy-builder.ts:152:16)
      at async Object.init (.\backstage\node_modules\@janus-idp\backstage-plugin-rbac-backend\src\plugin.ts:71:11)
      at async <anonymous> (.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:333:13)
      at async Promise.allSettled (index 6)
      at async BackendInitializer.#doStart (.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:278:21)
      at async BackendInitializer.start (.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackendInitializer.ts:187:5)
      at async BackstageBackend.start (.\backstage\node_modules\@backstage\backend-app-api\src\wiring\BackstageBackend.ts:38:11)
}

Versions of software used and environment
Backstage v1.32.4
Node v20.18.0
@janus-idp/backstage-plugin-rbac-backend: "^5.1.2",

I am having the exact same problem. Same versions as well.

Good news: version released with fix v5.2.1 :pray:

Bug fixed in v5.2.1


defaultsearch parameter from configuration doesn't seem to be loading on page

When changing the defaultsearch we don't seem to see this data populated into to page:
Worked around using this in opacuserjs:
// Uncomment the following line to re-enable EDS plugin in the opac.
$.getScript("/plugin/Koha/Plugin/EDS/js/EDSScript.js");
// This overrides the defaultsearch param in plugin config which doesn't seem to be working
$("head").append("");

great tip! no need to patch plugin anymore in version16.110X+.
Plugin inserts and removes code in opacuserjs to enable/disable plugin via configure screen.
Code used is
/eds{/var defaultSearch="eds";$(document).ready(function(){$.ajax({url:"/plugin/Koha/Plugin/EDS/js/EDSScript.js",dataType:"script",cache:true}); });/}eds/
defaultSearch variable is either set to eds or koha depending on selection.


[suggestion] Add option to create .m3u files to list the CHD-disks per game

Some emulators like RetroArch will show game duplicates as they recognize each CHD file for a multi-disk games as a separate games.
To solve this, we have to create .m3u files which list CHD disk images per game.
Examples:
https://www.reddit.com/r/RetroArch/comments/hwalg5/guide_combining_multiple_disc_on_chd_format/
https://gist.github.com/questionlp/1ea65e8ca86964b8269551d4c60fcb84

Could you please  create a new flag for creating those m3u files?
Thanks for your work and attention.

I'm actually familiar with this https://docs.libretro.com/guides/disc-swapping/#using-m3u-playlists and always had it in mind to support. I guess analyzing the filenames with "(Disc 1)" and so on could work. Right now I'm a bit busy with some other stuff, but will look into this when going back to tochd.


Error: unauthorized (first run) Everything is installed/configured perfectly

Hi, thanks for making & sharing this!
Fresh Ubuntu 18.04 install

I installed python3-pip fresh
I followed the python3 setup instructions exactly
I tried deleting and recreating my key (updated in config.yaml)
Account ID and bucket ID are definitely correct. I've checked everything at least 5x.
I also tried running b2fuse with command-line params instead of the config.yaml file and got exactly the same error output.

bob@freshpc:/opt/b2_fuse-master$ sudo chown bob:bob -R /opt/b2_fuse-master /home/bob/ /mnt/test-b2/

bob@freshpc:/opt/b2_fuse-master$ python3 -m "b2fuse.tier1_tests"
Hello world Heeeo world Heeeo world
........
----------------------------------------------------------------------
Ran 8 tests in 0.016s

OK

bob@freshpc:/opt/b2_fuse-master$ cat config.yaml
accountId: (12 char lowercase hex code)
applicationKey: K001(another 27 alphanumeric upper and lowercase chars)
bucketId: (24 char lowercase hex code)

#(note that colons and spaces in above file are correct)

bob@freshpc:/opt/b2_fuse-master$ b2fuse /mnt/test-b2
Traceback (most recent call last):
  File "/usr/local/bin/b2fuse", line 11, in <module>
    load_entry_point('b2fuse==1.3', 'console_scripts', 'b2fuse')()
  File "/usr/local/lib/python3.6/dist-packages/b2fuse-1.3-py3.6.egg/b2fuse/b2fuse.py", line 126, in main
  File "/usr/local/lib/python3.6/dist-packages/b2fuse-1.3-py3.6.egg/b2fuse/b2fuse_main.py", line 54, in __init__
  File "/home/bob/.local/lib/python3.6/site-packages/logfury/v0_1/trace_call.py", line 84, in wrapper
    return function(*wrapee_args, **wrapee_kwargs)
  File "/home/bob/.local/lib/python3.6/site-packages/b2/api.py", line 126, in authorize_account
    response = self.raw_api.authorize_account(realm_url, account_id_or_key_id, application_key)
  File "/home/bob/.local/lib/python3.6/site-packages/b2/raw_api.py", line 163, in authorize_account
    return self._post_json(realm_url, 'b2_authorize_account', auth)
  File "/home/bob/.local/lib/python3.6/site-packages/b2/raw_api.py", line 159, in _post_json
    return self.b2_http.post_json_return_json(url, headers, params)
  File "/home/bob/.local/lib/python3.6/site-packages/b2/b2http.py", line 302, in post_json_return_json
    return self.post_content_return_json(url, headers, data, try_count, params)
  File "/home/bob/.local/lib/python3.6/site-packages/b2/b2http.py", line 275, in post_content_return_json
    response = _translate_and_retry(do_post, try_count, post_params)
  File "/home/bob/.local/lib/python3.6/site-packages/b2/b2http.py", line 119, in _translate_and_retry
    return _translate_errors(fcn, post_params)
  File "/home/bob/.local/lib/python3.6/site-packages/b2/b2http.py", line 55, in _translate_errors
    int(error['status']), error['code'], error['message'], post_params
b2.exception.Unauthorized:  (unauthorized)

The only unusual thing is I'm trying this on an i386 CPU (not x86_64) but that shouldn't affect anything?
This is what the manual says about Unauthorized:
https://help.servmask.com/knowledgebase/backblaze-b2-error-codes/
Code: 401 ‘Unauthorized’
Returned while uploading, indicates the upload URL has expired; A new upload URL can be obtained from b2_get_upload_url or b2_get_upload_part_url
Returned from b2_authorize_account, indicates the account ID is wrong, the account does not have B2 enabled, or the application key is not valid
For all other APIs, there is a problem with the Authorization Token as indicated in the human-readable message. A new Authorization Token can be obtained from b2_authorize_account

I only have one backblaze account, which is a b2 account. I normally upload files manually using the b2 cloud web-interface. I got the account code inside the b2 area and created the application key right there also.
When creating the key, it said the expiry is optional, so I left it blank for the first key that I tried. After the first key didn't work, I deleted it and created a new key with expiry of 864000 seconds (10 days). The backblaze said expiry must be in seconds, less than some huge number. I updated the config.yaml with the 2nd key. I tried supplying everything via commandline params for both keys. I got the same error above, even when trying a non-existent key (after deleting the key).

You should use master application token

Using the master application key does indeed work, but is a horrible security practice.

Have the exact same issue. Master app key works but as stated it's bad practice.

B2Fuse was developed before Backblaze introduced application keys, as such B2Fuse does not support application keys. I have briefly looked into this new feature and it seems to me that it would add a lot of overhead to B2Fuse as it is possible to limit application keys to less than a complete bucket (individual file prefixes). I see the argument about security and I agree, but personally I don't see that adding support to application keys is worth the additional complexity required to support them in B2Fuse.
That being said, if someone was to implement a prototype and provide a pull request it would likely be accepted ;)

Project now works with application keys as far as I can tell. I am using it now with a key that is not the master key but has access to all my buckets.


JarSigner Private and Public Key Issue

Hello everyone,
Today, I was trying to use this action in your project. Whenever it starts generating the APK through It, then it gives me this error.
> Run r0adkll/sign-android-release@v1
>   with:
>     releaseDirectory: android/app/build/outputs/bundle/release
>     signingKeyBase64: ***
>     alias: ***
>     keyStorePassword: ***
>     keyPassword: ***
>
> Preparing to sign key @ android/app/build/outputs/bundle/release with signing key
>
> /usr/bin/jarsigner -keystore android/app/build/outputs/bundle/release/signingKey.jks -storepass *** -keypass *** android/app/build/outputs/bundle/release/app-release.aab ***
>
> jarsigner: Certificate chain not found for: ***.  *** must reference a valid KeyStore key entry containing a private key and corresponding public key certificate chain.
>
> Error: The process '/usr/bin/jarsigner' failed with exit code 1

How can I sort out this problem.

i had similar issue, and I created a new jks with name that matches what is in the build env....so the new jks was named signingKey.jks and that solved the issue for me

@kojofosu  just encountered this error. Do you mean the keystore.jks should ideally be named same as your github secret?


irmin: remove cache for tree values

This is an experiment to always re-hash the tree leaves - this is a bit slower (as expected) but uses a lot less memory.

Note: there are some use-cases where caching the hash for tree contents is super important (basically when it's very costly to hash the contents) so we should probably put this behind a flag somewhere if we plan to merge this.

Closing because out of date. Referenced by issue #1938


Bugfixes

Coverage decreased (-4.02%) to 68.383% when pulling a317923269da62355ea48e4446309caa2f86d9c6 on bugfixes into db0f5d0aa60447bbe2c49e5b4cb4402708480eb3 on master.


Design system website usability testing

Reviewed POC with design system team and determined net steps based on the current situation and needs.
Next steps

[ ] determine how much we can edit and style the Github pages website to align with our design system
[x] plan usability testing for developers and designers
[ ] team alignment on using github pages

Originally posted by @twjeffery in https://github.com/GovAlta/ui-components/issues/262#issuecomment-995205545

https://miro.com/app/board/uXjVOap0Ngk=/
Usability test framework

Testing was completed.


fix: display mfa prompt during hosting domains fetching

Description of changes
I've added import of singleton spinner from cli core, in order not to create a new ora spinner that blocks the mfa input
below is the output of amplify status
Before:

After:

Issue #, if available

Description of how you validated changes
Manual testing + yarn test
Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #12175 (e143ff6) into dev (984c0f8) will decrease coverage by 2.38%.
The diff coverage is 52.82%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev   #12175      +/-   ##
==========================================
- Coverage   49.45%   47.07%   -2.38%
==========================================
  Files         692      830     +138
  Lines       33424    37955    +4531
  Branches     6840     7707     +867
==========================================
+ Hits        16529    17869    +1340
- Misses      15370    18444    +3074
- Partials     1525     1642     +117

Impacted Files
Coverage Δ

...sync-simulator/src/data-loader/opensearch/index.ts
45.45% <0.00%> (ø)

...s/amplify-appsync-simulator/src/type-definition.ts
100.00% <ø> (ø)

...sync-simulator/src/velocity/util/dynamodb-utils.ts
6.55% <0.00%> (ø)

...y-appsync-simulator/src/velocity/util/map-utils.ts
10.00% <ø> (ø)

...tor/src/velocity/util/transform/dynamodb-filter.ts
4.93% <0.00%> (ø)

...ync-simulator/src/velocity/util/transform/index.ts
21.05% <0.00%> (ø)

...appsync-simulator/src/velocity/value-mapper/map.ts
86.88% <ø> (ø)

...ackages/amplify-category-auth/src/commands/auth.ts
0.00% <0.00%> (ø)

...es/amplify-category-auth/src/commands/auth/help.ts
0.00% <0.00%> (ø)

.../amplify-category-auth/src/commands/auth/import.ts
0.00% <0.00%> (ø)

... and 569 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Nice, great addition 🚀. Would it be worthwhile to follow up and write another PR that removes the other ora.spinners?


unable to write or read

To help us fix your issue, please provide the information in the below template. If something causes a crash, provide as much information as you can gather.
Just imagine: we do not know what you are doing!

Note: There is often little we can do without a minimal reproducible sample of the issue, so please provide that in a standalone git repository and link it here.

Steps to reproduce
1.using DemoBletooth
2.try to use await mycharacteristic.WriteAsync(c) or  await mycharacteristic.ReadAsync(c).
3.never finish to run
Expected behavior
read and write
Actual behavior
await forever
code:
var by = new byte[] { 0x20, 0x20 };
var wa = await characterRxTx.WriteAsync(c)
Crashlog
If something causes an exception paste full stack trace + Exception here
Configuration
Version of the Plugin: e.g. 1.0.0 / 1.0.1-alpha3
Platform: e.g. iOS 10.1 / Android 4.4 / ... (including version!!! e.g. Android 5.1 / i0S 10)
Device: e.g. HTC Sensation /i Phone 7 ...

i am trying to test readAsync and writeAsync inside this method below!!!
private async void DevicesList_OnItemSelected(object sender, SelectedItemChangedEventArgs e)
{
device = DevicesList.SelectedItem as IDevice;
        var result = await DisplayAlert("AVISO", "Deseja se conectar a esse dispositivo?", "Conectar", "Cancelar");

        if (!result)
            return;

        //Stop Scanner
        await adapter.StopScanningForDevicesAsync();

        try
        {
            await adapter.ConnectToDeviceAsync(device);

            await DisplayAlert("Conectado", "Status:" + device.State, "OK");

        }
        catch (DeviceConnectionException ex)
        {
            await DisplayAlert("Erro", ex.Message, "OK");
        }

        var serviceRxTx = await device.GetServiceAsync(Guid.Parse("0000ffe0-0000-1000-8000-00805f9b34fb"));
        var characteristics = await serviceRxTx.GetCharacteristicsAsync();
        var characterRxTx = await serviceRxTx.GetCharacteristicAsync(Guid.Parse("0000ffe1-0000-1000-8000-00805f9b34fb"));

        var cw = characteristics[0].CanWrite;
        var cr = characteristics[0].CanRead;
        var uu = characteristics[0].Uuid;
        var by = new byte[] { 0x20, 0x20 };

        var wa = await characterRxTx.WriteAsync(c);
        var ra = await characterRxTx.ReadAsync();
    }

Hi @juCortez,
I'm the friendly issue checker.
Thanks for using the issue template :star2:
I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.

I am having the same problem. "await characteristic.ReadAsync()" takes forever.
@juCortez Was you able to solve it?

I have a similar problem.
In you're case. Do you need run characterisct.StartUpdateAsync() for indicate to device bluetooth.
But in my android 10 dons't not work. On run await  characterisct.StartUpdateAsync() my code jumping break points and don't catch exeption. On iOS and Android 8.0 run normal.
`  carac.ValueUpdated += (o, args) =>
{
var bytes = args.Characteristic.Value;
};
                            await carac.StartUpdatesAsync();

`


update reanimated

Summary
There was an issue that appeared at times where the derived value for a reanimated variable was not being updated when a shared value changed in another component, this led to the modal for the bottom sheet to show up but not the actual component blocking the entire screen.
By updating the reanimated library this issue seems to have been gone away.
for me it was really easy to replicate the problem by setting up an EMM provider with the inAppPinCode enabled and having the app sit in the background for more than 5 mins.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53991
https://mattermost.atlassian.net/browse/MM-53367
Release Note
NONE

@lindalumitchell please build and test the PR as is going to be less effort if the issue is not yet fixed

Building app in separate branch.


[hi] Add  content/hi/docs/concepts/overview/what-is-kubernetes.md

Added one file
Localized what-is-kubernetes.md to Hindi.
Follow -up to #30732

@anubha-v-ardhan , @divya-mohan0209 please merge this PR? I have updated this file.

@ashish-jaiswar
Please review the comments I have entered previously. They haven't been addressed.

hey @divya-mohan0209 , you haven't reviewed this PR yet. I think you have commented in different PR. Because  I don't see your review comment.

Hello @ashish-jaiswar , the reviews will be marked as outdated.

Re-reviewed it again.

hi @divya-mohan0209 , @anubha-v-ardhan  I have updated this file, if it looks good please merge this PR.

hey, @anubha-v-ardhan please merge this PR.

/label tide/merge-method-squash
/assign

/lgtm
/approve
Thank you @ashish-jaiswar, @kranurag7


Chores list doesn't work !  :-(

Hi guys,
I'm big fan of TM1py !...
... and I need i little help.
I'm create a python script to list all my objects on TM1 server.
The cubes and dimension works fine but the chores list doesn't.
My chores.py

#Open connection with TM1
with TM1Service(address=address, port=port, user=user, password=password, namespace=namespace, ssl=ssl) as tm1:
    server_name = tm1.server.get_server_name()
    version = tm1.version

    #Write output file
    with open("TM1_Summary{}.txt".format(server_name),"w+") as file:

        #Server name
        file.write("# Server Name: {a}\n".format(a=server_name) )
        file.write("# version: {a}\n".format(a=version) )

        #CHORES
        chores = tm1.chores.get_all_names()
        for chore in chores:
            file.write("\nCHORE:{}\n".format(chore))

When I try to run the error is show:
Traceback (most recent call last):
  File "chores.py", line 33, in <module>
    chores = tm1.chores.get_all_names()
  File "C:\Users\my_User\AppData\Local\Programs\Python\Python35\lib\site-packages\TM1py\Services\ChoreService.py", line 69, in get_all_names
    response = self._rest.GET(request)
  File "C:\Users\my_User\AppData\Local\Programs\Python\Python35\lib\site-packages\TM1py\Services\RESTService.py", line 30, in wrapper
    self.verify_response(response=response)
  File "C:\Users\my_User\AppData\Local\Programs\Python\Python35\lib\site-packages\TM1py\Services\RESTService.py", line 214, in verify_response
    raise TM1pyException(response.text, status_code=response.status_code, reason=response.reason)
TM1py.Exceptions.Exceptions.TM1pyException: Text: {"error":{"code":"","message":"'Chores' resource can not be resolved on type 'EntityContainer'."}} Status Code: 404 Reason: Not Found

My output( TM1_Summary.txt)
# Server Name: myserver
# version: 10.2.20000.50183

Thank you in advance and congratulations by the awesome library.
The TM1 looks like much more funny with that...

Hi,
you get this Error because your TM1 Server is running a very old version.
After you upgrade to TM1 10.2.2 FP 7 or TM1 11 it will work.

Nice one. Thanks


Need to trap and report errors better

I have a very large solution (which I cannot share, alas) and a variety of errors are surfaced but not actionable by the user:
I see

which gives me little information on what to do.
I also see

which appears to be an internal error.

For index-out-of-range, change CMProject.cs line 1528 to
while (startIndex < text.Length)
to prevent starting a scan past the end of the string.
For the illegal characters, change CMProject.cs line 1476 to
if (path1 == "" || path1 == """")
to handle the case where VS 2017 uses $INHERIT in quotes that expands to nothing.

Thank you for your report.
The first one is reproduced, and I made an issue #11.
And I'm now confirming the second one.

Another issue is that you are inconsistent in how you call Utility.ToUnixPath.  I would suggest doing this when you extract paths from vcCfg.
Otherwise, you end up with CMake.txt files that have a mixture of / and \ and many tools (macOS) don't like the .

You have ToUnixPath and ModifyPath that appear to do the same thing.  I'd suggest picking one.

I get "Illegal characters in path" when I run this on my 21-project solution.
Maybe someone could implement the fix suggested above at https://github.com/DaisukeAtaraxiA/VSslnToCMake/issues/10#issuecomment-434499817


[vcpkg-tool] Missing newline in error message somewhere.

E:\all\vcpkg>vcpkg x-package-info libtorch --overlay-ports=../my-vcpkg-ports
This command requires --x-jsonnote: updating vcpkg by rerunning bootstrap-vcpkg may resolve this failure.

 --x-jsonnote: should probably have a newline between the end of json and note

Fixed by https://github.com/microsoft/vcpkg-tool/pull/1412


Changed warmup ping path variable

Context
The introduction of magic links in an earlier PR resulted in the application failing to start because it was looking for a warmup path that no longer exists. This path has now been changed to a page that does exist.
Changes proposed in this pull request
Simply changed the warmup ping path from "/personal-details/new" to "/sign-up".
Guidance to review
This is a simple single line change.
Link to Trello card
N/A

Not super confident with azure pipelines so forgive me if this is a silly question.
Is there a reason that the routes/personal-details/new or /sign-up are used instead of just using /?

This is to prove that the 200 OK I'm looking for from the webserver is definitely from our app and not a from a webserver welcome page which could potentially also be served up if something went wrong with deploying the container image if we were looking at the root of the webserver for a response.


Safari selectors state bug

I cannot use any selector from bubble menu on safari.
When I try to click on for example colors, bubble menu i rerendered or changes it's state to hidden and open once again.

Migrated selectors to Shadcn-ui


Search input localization

Is there a chance to be able to replace search input placeholder text with a localized version?
PS. Awesome package, thanks!

I think it would actually be a great idea to implement a localization system overall since things like #28 will just make a need for more strings.
However I am not sure what would be a best practice here for implementing, I don't see many packages ship localisation.


set origin= for distutils.spec

set origin so spec finding reports the correct location -- https://docs.python.org/3/library/importlib.html#importlib.machinery.ModuleSpec
Summary of changes
Closes https://github.com/asottile/reorder_python_imports/issues/210
Pull Request Checklist

[x] Changes have tests
[x] News fragment added in changelog.d/.
(See documentation for details)

Inferring from the bug report, the issue is that the DistutilsMetaFinder is creating a spec without a valid origin, creating a spec that is inferred to be a namespace package.
I might re-arrange the test a bit, but this is great. Thanks for the contrib.

I confirmed that 91ce77e captures the failed expectation when run with SETUPTOOLS_USE_DISTUTILS=local, which is run in CI, so I believe it to be a more selective and less entangled test.


feat: add cache ttl extension point

Description
Adds the setting CMS_CACHE_LIMIT_TTL_MODULE that should have the
limit_page_cache_ttl function that would be called to limit the cache
ttl of a page using business logic.
Closes #7296

Related resources

the issue #7296
previous PR #7297

Checklist

[x] I have opened this pull request against develop
[x] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines  and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

It will need a test so the interface of the extension point is preserved for the future.
If merged, this new feature would need to go to the docs.
The idea of this PR is to complement the issue.

Thank you @igobranco 👍

@marksweb I've renamed the setting to CMS_CACHE_LIMIT_TTL_CLASS; included the requested documentation and added new tests. I think with this changes it is ready to a new review.

@marksweb can you review the PR?

One thing I can see though is it needs an entry in the unreleased section of the changelog

Added!


optimize: remove useless if judgments.

Ⅰ. Describe what this PR did
remove useless if judgments.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3505 (8589611) into develop (5a09c25) will decrease coverage by 0.12%.
The diff coverage is 75.00%.

@@              Coverage Diff              @@
##             develop    #3505      +/-   ##
=============================================
- Coverage      51.60%   51.48%   -0.13%
+ Complexity      3390     3389       -1
=============================================
  Files            621      621
  Lines          20529    20527       -2
  Branches        2559     2526      -33
=============================================
- Hits           10594    10568      -26
- Misses          8873     8875       +2
- Partials        1062     1084      +22

Impacted Files
Coverage Δ
Complexity Δ

...ta/spring/annotation/GlobalTransactionScanner.java
47.74% <75.00%> (+0.42%)
17.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
95.45% <0.00%> (-4.55%)
3.00% <0.00%> (ø%)

... and 16 more

Codecov Report

Merging #3505 (8589611) into develop (5a09c25) will decrease coverage by 0.12%.
The diff coverage is 75.00%.

@@              Coverage Diff              @@
##             develop    #3505      +/-   ##
=============================================
- Coverage      51.60%   51.48%   -0.13%
+ Complexity      3390     3389       -1
=============================================
  Files            621      621
  Lines          20529    20527       -2
  Branches        2559     2526      -33
=============================================
- Hits           10594    10568      -26
- Misses          8873     8875       +2
- Partials        1062     1084      +22

Impacted Files
Coverage Δ
Complexity Δ

...ta/spring/annotation/GlobalTransactionScanner.java
47.74% <75.00%> (+0.42%)
17.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
95.45% <0.00%> (-4.55%)
3.00% <0.00%> (ø%)

... and 16 more


[Bug]: Deleting a page when present on the query page causes an RBAC error to pop up on cloud instance

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Deleting a page when present on the query page causes a GAC error to pop up on cloud instance

Steps To Reproduce

Create a CRUD app
Navigate to a query page
Deleting this page by selecting delete option from the entity explorer as seen in the video and notice the error message for GAC

Public Sample App
No response
Issue video log
https://www.loom.com/share/9931c6551d6349c099fb19a2db2178e5
Version
Cloud

@ramsaptami - I could not replicate this in release.app.appsmith.com, app.appsmith.com, release-ee.appsmith.com` and local BE. Is there a particular scenario I need to test?
Also, can you share the app where this issue happened?
https://user-images.githubusercontent.com/16632903/220038055-57da65e5-48d1-4ed7-98ed-2c907d74f456.mov

@infinitetrooper seems you're missing a step here, you'll need to be on a query page when you delete the page. Not from the canvas
I can repro this on prod too

Yes, my bad. This is reproducible on prod. The action is going ahead but, the error is showing up.
@trishaanand @nsarupr - We need to take a look at this. This is medium priority though, a UX issue but, not a blocker to the core flow.


credit Jack

'Thanks to Jack Salt, who sent in his beatbox track from Goa'
at the bottom of the card page

17f12f9df6b50ab0436d4c663921aec838de4fff


[Enhancement] Enhance version graph capture_consistent_versions performance by reduce hashmap access

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

reduce hashmap access
fix memory leak when delete verion

run starrocks_be_unittest

run starrocks_be_unittest


implement Connector::createFrom($socket) for existing sockets.

allows custom socket options to be set in advance. see #237, #238.
Connector's interface unmodified, though can be if needed.

Thanks for opening this PR @leeoniya, I very much appreciate the discussion.
However, this PR has been WIP for quite some time now and things have changed considerably since then :-)
React now consists of individual components that are maintained individually. Supporting this is now related to the react/socket-client component.
As such, I suppose it makes sense to focus our related efforts on this component. If you feel this is not already supported or tracked as an issue, please feel free to open a new ticket in this component. Thanks!


Using a button, not a menu

It could make use of your browser without using a menu? I would like to use it with a single button.

FakeSearchView it's just an view, so yeah, basically you can add it to any XML view.


Having a single index.ts entry point both for services and models

For Now
Today, only the models are grouped into a single index.ts. In my case, I am creating a new index.ts at the root which is grouping models and services.
Expected
When using typescript path mapping, it is useful to have a single index.ts that could contain all generated code (schemas + services)
We could specify something like import { PetsService, PetDto } from @orga/api-pet per example.
Problem
I understand that the current configuration is specifying 2 different paths for schemas and services (alias target). So it will be difficult to know where the index.ts should be generated.
It should be related to the mode selected.
What do you think?

You are not the first person which asks for I could easily add an index.ts for the services. I just need to check the better way to do it for each mode

Correct, a mode oriented solution is better than what I proposed ;)

Added with the 6.0.0. You can try it now with orval@next

I close the issue leave me a comment if you have any problem

@anymaniax thanks a lot for this library, I just discovered it and I already love it, nice job!
I don't manage to generate a single file pour model despite the version 6.0.0. Here is my config :
export default defineConfig({
  ecom: {
    output: {
      mode: 'single',
      schemas: 'src/queries/models',
      client: 'react-query',
      mock: false,
      target: 'src/queries/api/types.ts',
      override: {
        mutator: {
          path: './src/common/services/fetchApi/client.ts',
          name: 'fetchClient',
        },
      },
    },
    input: {
      target: 'src/queries/schema.json',
    },
  },
});

it generated me one file per type in the models directory as I would expect a single file for all types. Exactly as for the types generated for custom hooks.
Is this an expected behavior or an additional feature ?
Thanks

Hi @ClementLevesque, you can just remove the schemas property for that and you will have one file with everything in it


Must be using test environment to run tests

I almost drop my development database because of this.

What version are you using? RSpec shouldn't be running tests in dev.  That's just how Rails works https://github.com/zipmark/rspec_api_documentation/blob/d3892cc7388460a98476734963face5a7a2ac158/lib/tasks/docs.rake


Ignore role bindings in default namespace for RBAC

SelfSubjectRulesReview errantly considered role bindings in the default namespace for cluster scoped access. A namespace is required for SelfSubjectRulesReview, so a completely invalid namespace is provided to avoid this. rbac-api-utils was updated to do this by default.
Relates:
https://issues.redhat.com/browse/ACM-10162

/hold good point @dhaiducek

Here is the rbac-api-utils PR:
https://github.com/stolostron/rbac-api-utils/pull/5

/unhold

@dhaiducek and @yiraeChristineKim could you please review this again?


Race condition with listening server "port in use"

When the NotificationListener port is in use, it will try the next on, but the SonosSystem init() method just uses the current (blocked) port.
So I added an new event emitter to the listening event.
Greetings.

Ah, good catch. This might be an issue on the players as well, maybe getting the endpoint should be a promise instead, it would allow all codepaths the possibility to wait for it to finish and wouldn't be missed if attached to late.

Yeah sure promises would fit the general style, but I didn't want to break something else where, so the event emitting seemed like a quick fix :)

I just checked the code, and it seems that the players are initialized after at least the 1st event is received (Subscriber is initialized). At this point the listener already found the right port. and is used in the Players. So I think this should be ok. But of course you know your code mush better ;)

Ah, right, it needs to receive the topology before it can initialize the players.

Updated tests and merged


es6 import functionality

Wondering if we could get the ability to import using es6 modules.

You mean rewriting the code base to es6 modules? Importing using es6 is already possible, like
import * as timesyncServer from 'timesync/server'


added set local support in the parser

@chaudum  please review

from the documentation:

DEFAULT can be written to specify resetting the parameter to its default value (that is, whatever value it would have had if no SET had been executed in the current session).

i'm not sure if this should be in the parser


Would you consider compiling a FreeBSD version as well?

Thanks for all the different Linux, OSX, WIndows versions of this great software.
Would it be possible to compile a FreeBSD 12 version as well?
Thanks

Thanks for the feedback. Unfortunately, I can only target compilation for the runtimes that dotnet supports. These are listed here. BSD isn't listed here, so unless the Linux version works you may need to build Sanchez from source.
Sorry about that!
M


Typo in XMCOLOR::XMCOLOR function document

🛑 IMPORTANT: You can get your feedback addressed faster if you use the comment section for the article in which you encountered a problem.
Link to article: https://docs.microsoft.com/en-us/windows/win32/api/directxpackedvector/nf-directxpackedvector-xmcolor-xmcolor(float_float_float_float)
Tell us where exactly a problem occurs.
Problem: It looks typo, am I right?

Thank you for reporting this issue. This has been fixed in the content source. The change should be on the live site within 24 hours.


Updating Grafana from v8.1.2 to v8.1.6

Updating Grafana from v8.1.2 to v8.1.6

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @emilymye @fernando-wizeline

LGTM
How can we test this?

LGTM How can we test this?

wiki has instructions (https://cwiki.apache.org/confluence/display/BEAM/Community+Metrics#CommunityMetrics-UpdatingandDeploying) but I have not tried those. Assuming that this would be "fine" because it is a patch version change.
If anyone has an existing local setup I would appreciate if you can test it. I would take me a while to go over the local testing instructions.
I was hoping that the CommunityMetrics precommit will have sufficient tests but it does not seem to be the case.

LGTM How can we test this?

wiki has instructions (https://cwiki.apache.org/confluence/display/BEAM/Community+Metrics#CommunityMetrics-UpdatingandDeploying) but I have not tried those. Assuming that this would be "fine" because it is a patch version change.
If anyone has an existing local setup I would appreciate if you can test it. I would take me a while to go over the local testing instructions.
I was hoping that the CommunityMetrics precommit will have sufficient tests but it does not seem to be the case.

Hi @aaltay!
It shouldn't break anything since it is a minor version update.
I don't have bandwidth to test today, but maybe during the week I can test using the docker image which I used a few weeks ago to test the version change from 6 to 8

LGTM How can we test this?

wiki has instructions (cwiki.apache.org/confluence/display/BEAM/Community+Metrics#CommunityMetrics-UpdatingandDeploying) but I have not tried those. Assuming that this would be "fine" because it is a patch version change.
If anyone has an existing local setup I would appreciate if you can test it. I would take me a while to go over the local testing instructions.
I was hoping that the CommunityMetrics precommit will have sufficient tests but it does not seem to be the case.

Hi @aaltay! It shouldn't break anything since it is a minor version update. I don't have bandwidth to test today, but maybe during the week I can test using the docker image which I used a few weeks ago to test the version change from 6 to 8

Thank you @fernando-wizeline. I would appreciate that very much. If you think that this would be safe, we can merge it and if it breaks anything roll it back.

LGTM How can we test this?

wiki has instructions (cwiki.apache.org/confluence/display/BEAM/Community+Metrics#CommunityMetrics-UpdatingandDeploying) but I have not tried those. Assuming that this would be "fine" because it is a patch version change.
If anyone has an existing local setup I would appreciate if you can test it. I would take me a while to go over the local testing instructions.
I was hoping that the CommunityMetrics precommit will have sufficient tests but it does not seem to be the case.

Hi @aaltay! It shouldn't break anything since it is a minor version update. I don't have bandwidth to test today, but maybe during the week I can test using the docker image which I used a few weeks ago to test the version change from 6 to 8

Thank you @fernando-wizeline. I would appreciate that very much. If you think that this would be safe, we can merge it and if it breaks anything roll it back.

Don't mention it @aaltay! Glad I can help.
By looking at the release notes, I'd say it is safe to upgrade. If we have to rollback I can take a look later in the week to pinpoint the issue.

Merging based on the discussion. Please report if you notice any issues.

Update: Dashboard is running with 8.1.6. It does not seem to have visible issues.


Extract standalone proxy into own repository

Currently this repo is a mix between graphql go tools and a standalone proxy.
After getting the current backlog done I'd like to extract the standalone proxy into its own repository to have clean separation between a low level library and a ready to use high level tool for the graphql community.

Solved via the next branch.


Add alisterburt as maintainer

@alisterburt can you confirm that you'd be ok being listed as a maintainer on this recipe? As you probably know it's not very onerous, it just means you have the power to merge PRs like #4 when needed.

@jni - use https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-add-user-username to add a maintainer. Otherwise this will end up in one more package build we don't need :D

Adding on https://github.com/conda-forge/napari-animation-feedstock/pull/4


UNet with different input resolutions bringup

Describe the solution you'd like
Bringup the shallow UNet variant with the following input resolutions:

256x512
512x512
1024x1024

Additional context
this should be developed on WH (N150)

Hi,
I pushed the changes for 256x512 resolution support. I am attaching the perf sheet for the same.
ops_perf_results_Shallow_unet_2024_05_09_07_24_32.csv

Hi,
I tried running shallow unet 256x512 with group=2 and batch=2 and It is failing the following error,
RuntimeError: TT_THROW @ tt_metal/impl/allocator/allocator.cpp:118: tt::exception E       info: E       Out of Memory: Not enough space to allocate {} B {} buffer across {} banks, where each bank needs to store {} B E       33554432 E       L1 E       64 E       524288
occuring at
models/experimental/functional_unet/tt/ttnn_shallow_unet.py:256: in __call__ output_tensor = unet_concat([output_tensor, save_c1_2_out], dim=-1, perf_mode=perf_mode)

I am attaching the profiler for shallow unet 256x512 with group=2 and batch=1.
ops_perf_results_unet_2024_05_14_14_55_02.csv

@keerthana-r-mcw Could you please attach the command you ran to generate this sheet here?


restore examples from README to runnability

default value for number of words permits call from flamethrower to work

^ This seems to still be the case - It's a cool tool, I would love to see this in the gem!!


Fixed bug of balances not displaying properly in Balances.js

The balances screen is currently buggy because it shows the proper custom amount at the top but the old code with pre-evenly split amounts at the bottom.
Now with this update, balances should show the proper custom split amount at the bottom within the grey background box.
Closes Issue #155

Proper custom amounts shown. However, currently cannot scroll down to see all the transactions in the transaction log (gray container)

LGTM, Balances page works as expected now


Card component missing details in playbook

Hi! Browsing the playbook I discovered the Card component and I wanted to use it but in the show info tab is nothing usefull about how to use it and its properties. Can someone fix that, please? Thank you!

Hi @AdrianM20! 👋 Unfortunately this is a limitation of Storybook and its associated info plugin. For full details and source, can always view the story itself in our repo. We're hoping to add some additional plugins that will make this kind of information available from the website directly, so be on the lookout for that!

Story Link
Source Link

Going to close this for now, feel free to re-open if you feel like I haven't addressed the issue!


feat: unique number into button

Added a button that lets users copy the unique course ID. There's a checkmark that pops up indicating that the ID has been successfully copied. Button design follows figma wireframe.
Resolves #359

This change is

Please include screenshots of before/after your changes

Before
After

I looked at the Chromatic error and it seemed like the error was stemming from the CourseCatalogInjectedPopup component, but I don't think anything in PopupCourseBlock.tsx has any elements from CourseCatalogInjectedPopup and I haven't modified CourseCatalogInjectedPopup besides pulling from the main branch.


Controllers misplacing when changing orientation

Hi
I tried to use the library but when rotating the screen sometimes  the controllers are misplacing. This is also happening with the sample you provided too. Can you please tell us the way to fix this issue. I am running in Android devices

c9a0c38


Removed the "ZeroMemory" macro

...in favour of using memset. ZeroMemory is not a cross platform or portable macro and is exclusive to the windows operating system. Therefore, the vroomjs library cannot be cross platform or mono friendly whilst it's using ZeroMemory instead of memset.

Yeah, my bad, must have missed one. I'll close and open another pull request.


Alert on core-dns pods not working properly

Story
- As a cluster admin, I want to be alerted if a percentage of core-dns pods are not working properly (e.g. not responding to DNS queries) in order to have the core-dns deployment horizontally scaled based on cpu usage.
Background
In a recent incident 50% of the core-dns pods were not serving any DNS requests, but all pods were seen as ready. This lead to the horizontal pod autoscaler not reacting to scale the deployment. CPU usage was very high for just 50% of the pods and when looking at the data as an average the horizontal pod autoscaler didn't see any need to scale out. The autoscaler did it's job as soon as the core-dns pods were fixed and serving requests,
Proposed changes

add a new alert to identify if a certain percentage of core-dns traffic are not serving requests (or very few compared to the other pods);

Questions

[ ] What percentage should be used? 50%, 30%, ...? We could start with 20% and adapt.

This is the expected load given the number of replicas
100 /count(sum by (pod) (coredns_build_info))

This returns how much in percentage a pod is handling compared to what he should be handling
abs((sum by (pod) (rate(coredns_dns_requests_total[10m])) / ignoring (pod) group_left sum(rate(coredns_dns_requests_total[10m])) * 100) - ignoring (pod) group_left 100 / sum(coredns_build_info))

A dashboard to visualize data.
coredns-load.txt

Check if there is a difference between HPA metrics and number of pods scraped

@whites11 Unless I'm misunderstanding, doesn't this show that 1 pod ended up dealing with 100% of requests?
https://prometheus.g8s.antelope.sin.aws.k8s.3stripes.net/pap01/graph?g0.expr=sum by (pod) (rate(coredns_dns_requests_total[10m]))%20%2F%20ignoring%20(pod)%20group_left%20sum(rate(coredns_dns_requests_total%5B10m%5D))%20*%20100%0A&g0.tab=0&g0.stacked=0&g0.show_exemplars=0&g0.range_input=6h&g0.end_input=2022-02-16%2021%3A39%3A38&g0.moment_input=2022-02-16%2021%3A39%3A38

yes, but that's because there was only one replica.
otherwise the yellow line should have continued at "0", right?

Metrics as seen by HPA are different, but still not useful.
The "ghost" pods are not visible.

OK this query seems to work
(sum by (pod) (rate(coredns_dns_requests_total[10m])) / ignoring (pod) group_left sum(rate(coredns_dns_requests_total[10m])) * 100) - ignoring (pod) group_left 100 / sum(kube_deployment_status_replicas{deployment=~"coredns|coredns-cp"}) > 20

It detects the incident pretty well


How can I exclude the space separator from StringSliceP?

How can I exclude the space separator from StringSliceP?
 These are the standard ways to use parameters with spaces.

 These are the standard ways to use parameters with spaces.

I apologize for the delay in responding.
I was able to identify that the problem is not with pflag, apparently my bug fell on the strange behavior of Cobra with pflag. When working with the Cobra I get the duplicate sections and neglecting quotation marks when setting parameters.
In any case, if someone needs an answer with an example of pflag:
package main

import (
	"fmt"
	"os"

	"github.com/spf13/pflag"
	"github.com/spf13/viper"
)

var defaultSlice = []string{}
var sliceName = "slice"

func main() {
	viperConfig := viper.New()

	pflag.StringSliceP(sliceName, "s", defaultSlice, "slice")

	pflag.Parse()
	if err := viperConfig.BindPFlags(pflag.CommandLine); err != nil {
		fmt.Println(err)
		os.Exit(1)
	}

	fmt.Println(viperConfig.GetStringSlice(sliceName), "len:", len(viperConfig.GetStringSlice(sliceName)))
}

go run main.go run -s "test1,spaces test,test2"


Add missing comment trigger

The rest of the job was actually set up assuming comment triggers, the trigger itself was just missing

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @liferoad

R: @Abacn

The comment trigger is making lots of problems. We can enable it for this specific postcommit though


Clarify why you can't order products

When I want to order a product, but I am not allowed to, it says Maximum reached. This can be for multiple reasons:

the shift has is at its capacity
I can't order any products in that shift anymore
I can't order that specific product in that shift anymore

This should be clarified to the user

This is partly fixed in #64


Cypress/e2e/fixed cypress test cases

Summary
fixed cypress test cases
Screenshots

/release-note-none

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Cherry pick is scheduled.


jquery free version?  anyone find something suitable/similar that they like?

Just wondering if anyone has switched from jquery-validation to something else that is jquery free - that they like and does a similar job?  With the newest bootstrap going jquery free most plugins seem to be following suite.  I've done some searching of course and everything I've come across doesn't seem to be maintained, doesn't have a lot of features, etc.  Any information would be appreciated.

Yes, I found some, but that library charges, https://formvalidation.io/ , although jQuery is no longer used in bootstrap, I prefer the operation mode of jQuery. It is an excellent encapsulated library,

feel free to discuss this further. will close the issue as there is no todo for our lib.


Create helper script (duct-suite plot?) to generate plots of memory/cpu through time

Might complement #105 nicely
I think with that we should initiate a helper "entry script" we could call duct-suite (or anything else) which would have support commands like this one to plot based on the stats collected for a process.  Could probably be by default overlap of memory and CPU consumption with left "y" axis to have CPU and right - memory.  Example for two graph plot with different scales: https://matplotlib.org/stable/gallery/subplots_axes_and_figures/two_scales.html
Then we can define extra-depends for the duct[suite] to use matplotlib etc as desired for the duct-suite.
Note that might want to code right away so we might later provide different plotting backends (may be for inclusion online etc)

I imagine the usage would look something like:
duct --output-prefix myprefix_ sleep 2
duct-suite render --matplotlib myprefix_usage.json
@yarikoptic  does that match what you are thinking?

yeap, something like that.
duct-suite render --backend matplotlib -o myprefix_usage.png myprefix_usage.json

and if no -o -- just display on screen.  Eventually tricky part could become if we get various backends, and decide to get them backend specific options. For datalad-installer @jwodder ended up with quite evolved solution for smth like that. Hopefully we would not fall into such a rabbit hole here, just let's start somewhere ;-)

POC  https://github.com/asmacdo/fancy-duct


Using HiOp NLP optimizer in topology optimization problem

Hi everyone!
I am trying to use MFEM in combination with HiOp to solve a topology optimization problem, where the target is to minimize the compliance while being subjected to a volume constraint. I noticed that there is a PR related to a similar issue (#3400), where the same optimization problem was solved using a mirror descent algorithm. However, I would like to use a more standard method (using the pre-implemented classes and functions within OptimizationProblem) in order to being able to further expand the optimization problem, e.g. introducing for instance a stress constraint.
I looked at the example ex9.cpp within the HiOp folder. I am still though a bit confused on how to pass the value of the objective function and the calculation of the sensitivities to the OptimizationProblem routine.
Ideally, what could help me a lot would be a version of ex35.cpp (from #3400) solved instead with the HiOpNlpOptimizer and OptimizationProblem classes.
Can anyone guide me towards the correct direction? Maybe @brendankeith?
Furthermore, while playing around with the script in ex35.cpp, I noticed that the script does not provide the expected results if linear elements are used (standard practice in TO problems to reduce the computational cost). The only changes I made to the original code are in line 176 (int order = 1) and lines 259-261:
H1_FECollection filter_fec(order, dim); // space for ρ̃
L2_FECollection control_fec(order, dim, BasisType::Positive); // space for ρ

What might be the cause of this issue?
In advance, thanks.
Riccardo

Hi Riccardo,
Thanks for the comments.
@jwang125 is an expert on HiOp. Perhaps, he can help you out there.
Regarding your modifications to the code, it appears that you are using a broken linear finite element space for the control variable and a continuous linear space for the fields. That would mean that the control has more dofs than the first PDE constraint, which is likely going to lead to numerical instability. Can you please elaborate on what you would like your modification to do? Maybe I can still help.
As a rule, MFEM are designed to run without installing external packages. @jwang125 and @bslazarov, perhaps we should add some optional support for other optimizers to ex35.cpp?

Hi @brendankeith,
Thank you for your prompt reply.
What I wanted to achieve by modifying the code of ex35 was solving the TO problem using first order finite elements (as opposed to second order elements). There was no other purpose than simply testing, given that if the problem is to be expanded in 3D, using second order elements become computationally expensive.
What changes to the code are required to make this possible?
I hope @jwang125 can contribute w.r.t. the HiOp part.
In advance, thanks.
Riccardo

@ricgross I looked again at this once I got to the office. I think your problem may be that you didn't run on a fine enough mesh. Generally, you will need a finer mesh if you want to use a lowest-order discretization. Also, keep in mind that many MFEM features are designed for high-order discretizations, so it is possible that you will see better performance with high-order topology optimization in MFEM than you are used to in other codes. If you see any performance issues with high-order TO in MFEM please let me know.
Try the following:
   H1_FECollection state_fec(order, dim); // space for u
   H1_FECollection filter_fec(order, dim); // space for ρ̃
   L2_FECollection control_fec(order, dim, BasisType::Positive); // space for ρ

and then run on a fine enough mesh. For example, try
./ex35 -r 5 -o 1 -alpha 5.0 -epsilon 0.01 -mi 50 -mf 0.5 -tol 1e-5

This worked for me. See the attached screenshot. It also works if you use a second-order discretization for the physics, e.g.,
   H1_FECollection state_fec(order+1, dim);

Hi @brendankeith,
Thank you for your prompt reply once again. I have modified the inputs as you described, and I managed to obtain the same results as you did.
However, I have also tried to modify the dimensions of the beam and the point of application of the force, such that the load case resembles the one presented in Figure 5 of the paper "Efficient topology optimization in MATLAB using 88 lines of code" (Andreassen, E., Clausen, A., Schevenels, M., Lazarov, B. S., & Sigmund, O.) . It is a cantilever beam discretized by 80 elements (160 in the paper) along the x-direction and 50 (100 in the paper) along the y-direction. The point force is applied on the lower corner of the free end of the beam.
The result obtained from your script seems to differ quite largely w.r.t. the one in the paper and I am unsure what the cause might be.
On a side note, are there any other examples where optimization problems (and their related classes and functions within MFEM) are utilized? There seems to be only one, which is the same where the HiOp implementation is shown.
In advance, thanks.
Best regards,
Riccardo

@ricgross, I’m glad to read that the code is now running for you. :)
There are several reasons why the results may differ from the MATLAB paper. Please note that this is a non-convex optimization problem, so there is no reason to expect only one unique solution. The solution you converge to will depend on the initial guess as well as the optimization algorithm and it’s parameters. Also, there are subtle differences between the MFEM implementation and the MATLAB one.
@bslazarov is one of the coauthors of the MATLAB paper you are referring to and has also reviewed and approved the MFEM PR you are concerned about.
@bslazarov do you have any advice for @ricgross?

Hi @brendankeith,
Thank you for your help.
I actually have another small question related to the discretization choices. You decided to use a discontinuous L2 space for the control variable (i.e. the unfiltered density), which is in theory constant within each element. The TrueVSize is equal to four times the total number of elements, which makes sense, as the L2 space is linear, and a linear quadrilateral element has 4 nodes.
The question is: would it be possible to define a FE space, whose size is equal to the number of elements?
One of the reasons why I am asking is because I am planning to re-write the problem as a mass minimization with a stress constraint. The stress constraint is to be formulated as an aggregate function (P-norm), where (usually) one stress value per element (e.g. Von Mises) is used, and it is calculated in the center of the element itself (as it is a superconvergent point for a linear element).
Do you see it as a feasible approach? Or would I need to define a L2 space, calculate the stress in its center and then copy the value to the element nodes?

Happy to help, @ricgross.
The quick answer to your question is that running with control variable order = 0 is possible. I updated the PR to do this by default when you use the flag -o 1.
I also added a new sample run for users interested in running with the lowest order setting you want to use.
Finally, I must emphasize that running at the lowest order setting requires a very fine mesh. Because the discretization is not positivity preserving, you can get in the density field on coarse meshes that make the Young's modulus negative. If this happens, it will cause the code to crash in the conjugate gradient solver. You can fix this problem using a higher-order discretization, refining the mesh, or increasing rho_min.


Drop canTokenizePanElementValue

What

Why

Test Plan

✅ | ❌ I've added unit tests for this change.
✅ | ❌ The reviewer should manually test the changes in this PR.

Demo

How

Current dependencies on/for this PR:

main

PR #68

PR #93

PR #97

PR #98   👈

This comment was auto-generated by Graphite.

 I ended up moving it into #68 so I'm going to close this PR


hitEnd does not behave correctly

The following code behaves differently in scala.js and on the JVM. I assume the JVM work correctly:
val regex = """\d\d\.?\d\d\.?\d\d\d\d""".r

def check(s: String) = {
  val m = regex.pattern.matcher(s)

  if (m.matches()) println("ok")
  else {
    m.reset(s)
    if (m.hitEnd()) println(s"$s partially matches")
    else println(s"$s does not match")
  }
}

check("")
check("1")
check("17")
check("17.01")
check("17.01.2018")
check("1701")
check("17a")
check("a")
check(" ")

on the JVM:
partially matches
1 partially matches
17 partially matches
17.01 partially matches
ok
1701 partially matches
17a does not match
a does not match
  does not match

in scala.js:
does not match
1 does not match
17 does not match
17.01 does not match
ok
1701 does not match
17a does not match
a does not match
  does not match

Thanks for the report.
It looks like hitEnd() is not even trying to do the right thing. I believe we misunderstood the very contract of that method when we implemented it 5 years ago.
The problem is, JavaScript doesn't have any similar feature. So in fact the correct contract of that method simply cannot be implemented.
I'm afraid you'll have to look for a custom solution, for example this one from StackOverflow. It is not universal, though. Some regexes cannot be handled by this solution.
For Scala.js, what it means is that I think we should wipe that method altogether. Because it is currently completely wrong, and we have little hope to correctly implement it any time soon. Instead of doing the wrong thing at run-time, it should fail to link.


extended kusk version

Signed-off-by: jasmingacic<EMAIL_ADDRESS>fixes #810
# go run main.go version
Kusk version
https://github.com/kubeshop/kusk-gateway/releases/latest

kusk-gateway-manager:  kubeshop/kusk-gateway:v1.3.3, gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
kusk-gateway-api:  kubeshop/kusk-gateway-api:v1.1.5
kusk-gateway-envoy-fleet:  docker.io/envoyproxy/envoy:v1.23.1
kusk-gateway-private-envoy-fleet:  docker.io/envoyproxy/envoy:v1.23.1
kusk-gateway-dashboard:  kubeshop/kusk-gateway-dashboard:v1.2.0

Yes we can have it any way we want.
We should also provide status of kusk installed or running.
I was thinking maybe we provide json output as well. It could be handy for automation.

How does this behave if the cluster is unreachable?

How does this behave if the cluster is unreachable?

When I'm running the cluster I get this output:
$ go run main.go version
Kusk version
https://github.com/kubeshop/kusk-gateway/releases/latest

Error: Get "https://<IP_ADDRESS>:8443/api?timeout=32s": dial tcp <IP_ADDRESS>:8443: connect: no route to host
Usage:
  kusk version [flags]

Flags:
  -h, --help   help for version

Global Flags:
      --config string   config file (default is $HOME/.kusk.yaml)
  -v, --verbose         Help message for toggle

❌ Get "https://<IP_ADDRESS>:8443/api?timeout=32s": dial tcp <IP_ADDRESS>:8443: connect: no route to host
exit status 1

Perhaps, you could read the manifests from the kusk binary to get the versions, if the cluster isn't up?

I just tweaked so it shows like this:

The reason for this is that our manager pod has two containers. One is ours kubeshop/kusk-gateway:v1.3.3 and the other one is added by the kubebuilder gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0


Move the Centos SSH configuration script out of the Vagrantfile

We don't lint/check/test embedded scripts, so we should move the inline scripts that enables password authentication for SSH connections out of the Vagrantfile, so it can verified along with the other scripts.

ahahah I've seen the new label "technical debt" nice and violet :-)

We deserved one :D


Tabs show notification but not message

The first time im opening chatterino and not having opened every tab once, it doesnt show the message in the tab, not opened. Just happens in tabs that were empty before the posted message. (Most noticeable in mentions tab)

I don't understand the issue that you are describing after reading it multiple times. Please create another issue and use short and simple sentences.


[Question] Forcing version type

I read all of the extensive documentation, but I see that the CLI has no options for forcing a type of versioning.
For example pnpm changesets --patch
I'm trying to provide a simple command for an application like pnpm release-to-prod that runs changesets with some of the options answered for. Is there a way to do this?

Nope, this is currently not possible - but that would be a good feature. PRs are welcome.


fix(element-templates-modal): filter invalid templates

Which issue does this PR address?
Closes #2110
Acceptance Criteria

[ ] Corresponds to the concept
[ ] Corresponds to the design

Definition of Done

[ ] corresponds to the design principles
[ ] corresponds to the code standards
[ ] passes Continuous Integration checks
[ ] available as feature branch on GitHub

[ ] contains the cleaned up commit history
[ ] commit messages satisfy our commit message guidelines
[ ] a single commit closes the issue via Closes #issuenr

auto-merge seems to be gone ...

Just taking a break I guess.


ext/hal/st: stm32cube Kconfig fix

Fix inconsistencies (spelling, duplicates, ordering) in stm32cube Kconfig file.
Signed-off-by: Erwan Gouriou<EMAIL_ADDRESS>

@nashif, don't know if ext/ is frozen before moving to modules.


Losslessly compressed images (149.8 MB saved)

Compressed all images through ImageOptim. Result as per ImageOptim: Saved 149.8 MB out of 670.2 MB. 18.9% per file on average (up to 96.7%)
Signed-off-by: Jens Oliver Meiert<EMAIL_ADDRESS>

@bzier, do you know who can help get this PR reviewed? I believe it means some real gains, and as it’s been work to process I’d like to avoid it getting stale. (Happy to respond to any questions about this internally.)


docs: add a console.log to the js example

Its a small thing , but when I first copied the code and run it  I left wondering for a sec why there is no output and if its working, so this just makes life easier
Also what about generating a main.ts (with deno task wasmbuild new) that have the example ?

what do you think about this part ?

Also what about generating a main.ts (with deno task wasmbuild new) that have the example ?

Sorry, missed that. Yeah, I just looked at the output and it's not super clear so I think it would be good to do that, but probably a mod.ts instead because probably most people will be using this for libraries.


Correct annotations.

@radekosmulski Hi
Have you modified annotations by hand or just left them as is?
There are a lot of images in this dataset like

person class is not selected and this can degrade the accuracy.
Thanks

I have not made any changes to the labels

I think you are using we explore dataset feature OID website, there if you select only single class bounding boxes then it will show for single class @dreambit  un check that to get multi class bounding boxes


add include-paths option to additionally search for releaseable work

I am trying to setup release-please to work with a monorepo that has separate entry points but largely uses the same code.
For instance my structure is using golang and
cmd/
  -pkgA
  -pkgB
  -pkgC
data
  -models
  -migrations
...

where cmd/pkgA and cmd/pkgB will have different deployment strategies (on-prem and cloud) and pkgC might only handle database migrations and not have other server API dependencies.
Ideally changing anything in migrations would trigger pkgC to have a release, and nearly anything else would trigger both pkgA and pkgB.

Hopefully we could prioritise this!
This will be really useful for our current setup and is actually blocking us from using release-please

Another option would be to add a footer such as Release-As that would allow you to force a particular component. It is less awesome than automatic, but it gives a lot of control.

+1 to this

came here looking for this config option for terraform monorepo.
we have internal modules that support many of our terraform modules in our monorepo and it would be great if changing an internal module triggered a release for all the modules that use it.

+1

+1

Another option would be to add a footer such as Release-As that would allow you to force a particular component. It is less awesome than automatic, but it gives a lot of control.

Can you provide example? Not sure in what context this applies.

+1 we need this to trigger releases of the various flavors of our protobuf libs


Import of hello-world Docker image fails for unknown reason.

Get the rootfs tarball:
  id=`docker create hello-world`
  docker export $id -o hello-world.tar
  docker rm $id

Import it to WSL 1:
wsl --import hello-world ./hello-rootfs hello-world.tar --version 1

Try to run:
wsl -d hello-world /hello

The wsl process exits with error code 1. If I extract /hello from the tarball  and run in WSL directly ./hello it prints the text to console  and exits.
Basically I followed https://docs.microsoft.com/en-us/windows/wsl/use-custom-distro and seems there are magical files are missing so WSL fails.
There is no way to debug issue. Are there any log/diagnostics available?

@gavenkoa to run hello use -e argument, like wsl -d hello-world -e /hello.
The hello-world container does run inside WSL and prints Hello from Docker! string. Here's sample output:
PS C:\Users\elsaco> wsl -d hello-world -e /hello
Processing fstab with mount -a failed.

<3>init: (8) ERROR: CreateProcessEntryCommon:352: getpwuid(0) failed 2
<3>init: (8) ERROR: CreateProcessEntryCommon:356: getpwuid(0) failed 2

Hello from Docker!
This message shows that your installation appears to be working correctly.

To generate this message, Docker took the following steps:
 1. The Docker client contacted the Docker daemon.
 2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
    (amd64)
 3. The Docker daemon created a new container from that image which runs the
    executable that produces the output you are currently reading.
 4. The Docker daemon streamed that output to the Docker client, which sent it
    to your terminal.

To try something more ambitious, you can run an Ubuntu container with:
 $ docker run -it ubuntu bash

Share images, automate workflows, and more with a free Docker ID:
 https://hub.docker.com/

For more examples and ideas, visit:
 https://docs.docker.com/get-started/

OK, closing. I missed -e option:
    --exec, -e <CommandLine>
        Execute the specified command without using the default Linux shell.

For default Linux shell I expect a record in /etc/passwd is necessary.

With a Makefile:
.PHONY: minimal
minimal:
	wsl --unregister minimal || :
	rm -rf rootfs-minimal
	wsl as -64 -o minimal.o minimal.s
	wsl ld -melf_x86_64 -o minimal minimal.o
	tar cf minimal.tar \
--mode=a=rx --xform='s#^passwd#/etc/\0#' passwd \
--xform='s#^minimal#/\0#' minimal
	wsl --import minimal rootfs-minimal minimal.tar --version 1
	wsl -d minimal -e /minimal

and passwd file:
user:x:0:0:user:/root:/minimal

it is possible to run wsl without -e option:
bash# wsl -d minimal
Hello, world!

bash# wsl -d minimal /non-existing-cmd
Hello, world!

I remember I read somewhere that first line of passwd file defines default WSL user (unless you override it with echo -e "[user]\ndefault=$myUsername" >> /etc/wsl.conf ).


[PIP 86][Function] add funtion api to support preload and release external resources

Motivation
This patch is based on #11112, I have talked with @wuchenxi123 and I will continue the work for this feature.
Modifications
Introduce RichFunction interface extends Function,  which provide setup and tearDown API.
setup is called only once when function instance started. tearDown is called when function instance closed.
User could use these interface to initialize and release their external resources such as RedisClient.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

The public API: ( yes)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] doc-required
I think we need to add chapter to tell user how to use the API in functions-develop.md

@wangjialing218 Did you call a vote for the PIP-86 in the dev@pulsar mailing list?
It's good if we can get feedback from the community. And then start the review work.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@nlu90 @eolivelli please have a check again

The change looks good. But in your test your are not testing that the new methods are executed. I suggest to add some static variables in the function in order to be able to check that the function runs

@eolivelli I tried to add static variables in function but failed to get correct value in test code, may be caused by different class loader, could you give some suggestion?
Anyway, in the test funtion, process() will throw exception if initialize() did not run, and test code could check whether all messages received.

@eolivelli Could you help take a look again when you are available?


SuspensionManager.SessionStateForFrame()  method explaination

I  am deeply going through all the codes in Cortana  Voice Command sample "Adventure Works". I have a question why u are creating a new Dictionary<String, Object> as an Object of a Dictionary. If u can make me understood that I will be very pleased.
`public static Dictionary<String, Object> SessionStateForFrame(Frame frame)
{
var frameState = (Dictionary<String, Object>)frame.GetValue(FrameSessionStateProperty);
        if (frameState == null)
        {
            var frameSessionKey = (String)frame.GetValue(FrameSessionStateKeyProperty);
            if (frameSessionKey != null)
            {
                // Registered frames reflect the corresponding session state
                if (!_sessionState.ContainsKey(frameSessionKey))
                {
                    _sessionState[frameSessionKey] = new  Dictionary<String, Object>();
                }
                frameState = (Dictionary<String, Object>)_sessionState[frameSessionKey];
            }
            else
            {
                // Frames that aren't registered have transient state
                frameState = new Dictionary<String, Object>();
            }
            frame.SetValue(FrameSessionStateProperty, frameState);
        }
        return frameState;
    }`

Not sure what your question is. What's wrong with having a dictionary as an object in a dictionary? (You don't want to use the main dictionary directly because it is shared with other clients of the frame.)

Thanks for your answer.


Not working in VS Enterprise 2022 17.10.0 Preview 1.0

Guidelines no longer show up in VS Enterprise 2022 17.10.0 Preview 1.0.

Confirming that it doesn't work on Professional & Community 2022 17.12.3 either 🤔.

@ravindUwU Can you describe the symptoms you're seeing?

In my case, the symptom was just that the guidelines didn't show up in editors, with guidelines = 100 included in the .editorconfig. 🤔 I recall re-opening the solution, and the .editorconfig file within the solution, and neither worked.
I say was because, curiously, it seems to work now (as I opened Visual Studio to gather some screenshots for this comment)? 🤷 Thanks for investigating this issue! I'll post another comment if I notice it again 😓.

Ohkay this is embarrassing. It turns out that I had, at some point, set the colour of my guidelines to white and they just weren't visible in light mode 🤣🤦.
The extension works just fine 😊.

No worries, @ravindUwU
I'm going to close this for now since the original report is old and it appears to be working now.
@bruno-brant, please re-open if you're still having trouble.


Environment Variables don't work

🐞 Bug Report
Affected Services [REQUIRED]

 The issue is located in:
All core services.
Is this a regression?

 Yes, the previous version in which this bug was not present was: v2.3.0
Description and Minimal Reproduction [REQUIRED]
🔥 Exception or Error

  core-data:
...
    environment:
      EDGEX_SECURITY_SECRET_STORE: "false"
      SERVICE_HOST: edgex-core-data
      SERVICE_REQUESTTIMEOUT: "50s"
...

🌍  Your Environment
Deployment Environment:
**EdgeX Version [REQUIRED]: v3.1.0
Anything else relevant?

@cloudxxx8 @lenny-intel

@jiekechoo , you can only override Private settings on a service if they exist in the local private configuration.yaml.
https://docs.edgexfoundry.org/3.1/microservices/configuration/CommonEnvironmentVariables/#service-configuration-overrides
The RequestTimeout is in the Common Config and must be overridden on the core-common-config-bootstrapper service (applies to all services) i.e. ALL_SERVICES_SERVICE_REQUESTTIMEOUT
Or add Service.RequestTimeout to the individual service's configuration.yaml so it can be overridden on the individual service as you are trying.

Thanks for you help, @lenny-intel
I got the solution in https://github.com/orgs/edgexfoundry/discussions/216
Closed.


UB: Bitmap::get_color_of_pattern returns a dangling reference

https://github.com/boozook/playdate/blob/30fc871ad0edbd8c00af96a467da44935c3c6e88/api/gfx/src/bitmap/bitmap.rs#L302-L313
The &mut LCDPattern returned is not dependent on the lifetime of &self, in fact it isn't dependent on any lifetime at all. The pointer is constructed from an integer. Running this code in MIRI (after stripping the sys API parts) reports:
   Compiling playground v0.0.1 (/playground)
    Finished dev [unoptimized + debuginfo] target(s) in 0.27s
     Running `/playground/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo-miri runner target/miri/x86_64-unknown-linux-gnu/debug/playground`
warning: integer-to-pointer cast
  --> src/main.rs:37:13
   |
37 |         let ptr = color as *mut c_void as *mut u8 as *mut LCDPattern;
   |                   ^^^^^^^^^^^^^^^^^^^^ integer-to-pointer cast
   |
   = help: This program is using integer-to-pointer casts or (equivalently) `ptr::from_exposed_addr`,
   = help: which means that Miri might miss pointer bugs in this program.
   = help: See https://doc.rust-lang.org/nightly/std/ptr/fn.from_exposed_addr.html for more details on that operation.
   = help: To ensure that Miri does not miss bugs in your program, use Strict Provenance APIs (https://doc.rust-lang.org/nightly/std/ptr/index.html#strict-provenance, https://crates.io/crates/sptr) instead.
   = help: You can then pass the `-Zmiri-strict-provenance` flag to Miri, to ensure you are not relying on `from_exposed_addr` semantics.
   = help: Alternatively, the `-Zmiri-permissive-provenance` flag disables this warning.
   = note: BACKTRACE:
   = note: inside `Bitmap::get_color_of_pattern` at src/main.rs:37:13: 37:33
note: inside `main`
  --> src/main.rs:45:14
   |
45 |     let color = bitmap.get_color_of_pattern();
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: Undefined Behavior: dereferencing pointer failed: 0x2a[noalloc] is a dangling pointer (it has no provenance)
   --> /playground/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mut_ptr.rs:686:57
    |
686 |         if self.is_null() { None } else { unsafe { Some(&mut *self) } }
    |                                                         ^^^^^^^^^^ dereferencing pointer failed: 0x2a[noalloc] is a dangling pointer (it has no provenance)
    |
    = help: this indicates a bug in the program: it performed an invalid operation, and caused Undefined Behavior
    = help: see https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html for further information
    = note: BACKTRACE:
    = note: inside `std::ptr::mut_ptr::<impl *mut [u8; 16]>::as_mut::<'_>` at /playground/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mut_ptr.rs:686:57: 686:67
note: inside `Bitmap::get_color_of_pattern`
   --> src/main.rs:39:12
    |
39  |         unsafe { ptr.as_mut() }.unwrap()
    |                  ^^^^^^^^^^^^
note: inside `main`
   --> src/main.rs:45:14
    |
45  |     let color = bitmap.get_color_of_pattern();
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The integer-pointer cast warning suggests that the pointer may have been intended to be created from a reference to color, but this also would not work! That would return a reference to a stack allocation. Short of Bitmap owning some state that this method references, there is no way to return a loan like this.
Another issue is the size disparity between LCDColor and LCDPattern. Even if you did cast an LCDColor reference to an LCDPattern reference, that would result in out-of-bounds accesses.
Probably what was intended is returning an owned LCDColor, which doesn't involve pointer casting shenanigans.

Thanks for the find and research!
From headers in the SDK:
typedef uint8_t LCDPattern[16]; // 8x8 pattern: 8 rows image data, 8 rows mask
typedef uintptr_t LCDColor; // LCDSolidColor or pointer to LCDPattern

I'm not sure what's really wrong and what to do 🤷🏻♂. It because I do not see any errors (just assert seems unnecessary and null-check needed), but I must cast int to ptr because of 2. (see next point)
Dangling reference (without provenance) is "by-design" as it invented in the SDK. And that's probably ok - just check that int > 3 and so it's a pointer. Yes, pretty unsafe. I'm not sure what we can do with it.

Ha! There is all wrong!

@parasyte,
Probably when I wrote this I was tired and sleepy and didn't realize what I was doing.
Is that write solution?

LOL! Yeah, I like that solution. AFAICT, set_color_to_pattern already does the right thing.