Dependabot for Swift stopped working

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
Swift
Package manager version
Swift Package Manager - Swift 5.9
Language version
Swift 5.9
Manifest location and content before the Dependabot update
vapor/penny-bot/Package.resolved
dependabot.yml content
vapor/penny-bot/.github/dependabot.yml
Updated dependency
No dependencies are no longer updated.
One example, Package.resolved specifies swift-nio version 2.60.0, but 2.61.0 has been out for 3+ days.
The schedule is set to daily, so the update-dependencies-PR should have already happened.
What you expected to see, versus what you actually saw
Dependabot still updates github-actions based on the configuration file, but doesn't update the Swift dependencies anymore. It should update the Swift dependencies as well.
Native package manager behavior
SPM - swift package update: Just works and updates package per usual of the last year or more.
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
I have a theory that Dependabot is incompatible with Swift 5.9 and that's why it's failing, but just a guess.
gh-codeql also doesn't work on Swift 5.9 for reasons i don't recall, which makes me think the same thing might be true for Dependabot.
Nevermind, there has been a Dependabot PR on Oct 6th after we moved to Swift 5.9 on Sep 24th.

After more investigations, it appears the updates are unrelated to Swift 5.9 (updated the description). They have stopped right after Add GH actions to Dependabot config PR.
The PR adds github-actions to be updated by dependabot. Basically:
version: 2
enable-beta-ecosystems: true
updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    groups:
+     dependencies:
+        patterns:
+         - "*"
  - package-ecosystem: "swift"
    directory: "/"
    schedule:
      interval: "daily"
    groups:
      dependencies:
        patterns:
          - "*"

After this we're seeing no updates to Swift packages.

Sounds like the PR arrived 15' ago? Not sure if you did something there or the PR look a bit longer to show up? The daily schedule does not apply to weekends, so that's probably why?

Sounds like the PR arrived https://github.com/vapor/penny-bot/pull/133

yeah we did notice, we removed "gh-actions" from Dependabot just to test, might be related.

Not sure if you did something there

We're investigating this on our own side, i'll keep you updated again.

The daily schedule does not apply to weekends

That's good to know, didn't know about that.

Removing another ecosystem from the configuration should be unrelated, but it should've triggered Dependabot to run on your repo, since currently Dependabot reacts to any configuration change and re-runs everything.
But even if you had not changed the configuration, the PR should've arrived during the day anyways.
I think there's no issue here, but feel free to run more investigations on your side and let us know!

I think there's no issue here

The thing is Penny and SwiftNIO were just an example. I have other private projects that aren't being updated too.

Ah ok, I'll wait for more information/examples then!

To be clear, i'm still trying 🙂 I'll let you know when i have updates, at worst in the next 2 weeks.

@deivid-rodriguez It appears that Dependabot is only updating the packages that are explicitly defined in dependencies of the top-level package declaration in Package.swift (those with URLs). Is there a way i can tell Dependabot to go for all dependencies of the whole package instead? We do commit Package.resolveds, so i would expect Dependabot to be able to read the dependencies off of that?

You probably want to configure allow.dependency-type?

Thanks for the pointer, that solves the problem.
This was quite confusing just because this wasn't the behavior from the beginning, but i notice that swift-support is still in beta and this behavior will match other ecosystem supports more closely, so it's understandable.
Thanks again for the debugging session.


React Native ^0.60 compatibility

This PR makes it possible to use this module in RN > 0.60 as well as the earlier ones.
In case you are going to merge, please Squash and Merge.

Thanks!


Module Header has changed

Module Header used to be a container section

Now it's wrapping the children inside of an <h1>

The component should be open to flexibility.
Most of the time it's just going to be a normal h1, but sometimes additional UI will be introduced like buttons and such.

[ ] make ModuleHeader component flexible for html children

Thanks for pointing this out.
Also, we also recognize that we shouldn't  be using <h1> and other heading tags in our components for visual styling since it can lead to confusing screen-reader navigation (see https://github.com/carbon-design-system/carbon-components/pull/154#issue-233643947 for more details).
If no one assigns themselves to this in time, feel free to assign yourself to this issue and submit a PR.

Should the styling be all the same, but the semantic html be up to developer?

☝  Yes. That is correct.

Hi @jzhang300! Just wanted to check back in on this issue to see if the original question/concern has been addressed? I know you've submitted a couple of PRs related to Module Header, wanted to see if any of those addressed this as well.
Thanks again for taking the time to make an issue! 🎉


missing the first character in everyfile

I have the directory with such structure
$tree
.
└── ABC
    ├── ABC
    │   ├── ABC
    │   │   └── a
    │   ├── abc1
    │   ├── abc2
    │   └── abc3
    ├── abc1
    ├── abc2
    └── abc3

However the nerdtree display is

You can see that the first charactor is not display.
However, when I copy it out, it's right

What a strange proplem.
My environment is ubuntu14.04 with kernel3.13

This appears to be a problem concerning nerdtree (or some nerdtree variant), and not something concerning vundle. I suggest you raise your issue on the issue tracker for the appropriate repository.

If this only occurs in the file directory as @davidlowryduda mentions then it seems highly unlikely it is related to Vundle. For now closing, re-open if the behavior only occurs when using Vundle.


fix: [vite-plugin-hot] Failed to import "/@vite/client" when using nuxt.config "app/buildAssetsDir"

🐛 The bug
Nuxt devtools doesn't load and console throws some errors, especially the [vite-plugin-hot] Failed to import "/@vite/client" one. Even after this commit.
We're using a custom value for buildAssetsDir.
Solution: when commenting out this buildAssetsDir, everything works. So maybe just getting that value from config when loading the Vite client ?
🛠 To reproduce
https://stackblitz.com/edit/github-cwjhut?file=nuxt.config.ts
🌈 Expected behavior
Devtools should load even when using a custom buildAssetsDir path
ℹ Additional context
No response

Hey @edgarrroussille, what version of devtools are you using? It should be fixed in the latest version #375

@arashsheyda I'm encountering the same issue even on edge release that implements #375. I still observe the following error:
http://localhost:5314/_nuxt/@vite/client net::ERR_ABORTED 404 (Page Not Found: /_nuxt/@vite/client)

It appears window.__NUXT__.config evaluates to the following at the point of connection:
{
    "baseURL": "/__nuxt_devtools__/client",
    "buildAssetsDir": "/_nuxt/",
    "cdnURL": ""
}

Yet evaluating the config in the browser equates to:
{
    "baseURL": "/",
    "buildAssetsDir": "/customdir/",
    "cdnURL": ""
}

Hey @arashsheyda I'm using v0.7.6, same as in repro link

Aww I found the problem, I will open PR as soon as possible. thanks

Aww I found the problem, I will open PR as soon as possible. thanks

Is it related to the window context? Perhaps the config is referring to the devtools window rather than the parent?

Is it related to the window context? Perhaps the config is referring to the devtools window rather than the parent?

exactly!

Is it related to the window context? Perhaps the config is referring to the devtools window rather than the parent?

exactly! PR welcome if you want

Happy to spin up a PR later today 👍


Bundle TypeScript type definitions

Hi,
I'm using your library from my TypeScript code. In order to use a JavaScript code from a TypeScript code, it's necessary to provide a ".d.ts" file that provides declarations. I can bundle this file with my code but I think that it would be nice if it would be available to others as well.
OTOH, I would understand if you would not like the idea of distributing this file with your code. In that case, I would attempt to upload it to http://definitelytyped.org/, a repository of type declarations. The benefit of distributing it with the library is that its authors may try to keep it up-to-date [1]. I can maintain it here for you if you want.
Please let me know if there is any problem/ugliness. I will be happy to make the contribution as perfect as possible. E.g. would you like me to add a test? I think it would follow [2] in that case.
Please note that according to our laws, the contribution copyright belongs to MEDIA CHECK s.r.o. (my employer).
[1] http://blog.johnnyreilly.com/2015/09/authoring-npm-modules-with-typescript.html
[2] http://definitelytyped.org/guides/contributing.html#tests

Emm… I've never mixed open-source license (especially for such a simple project) with corporate license, don't know what that exactly means. So you'd better patch it yourself.
This package is really simple. You may consider rewrite it in TypeScript. The test scripts looks complicated but they are simple too, though a little tricky.

Well, the license is still the same... The only difference is that the contribution is made by "MEDIA CHECK s.r.o." instead of "Radek Holý".

And BTW, if the only problem with this is that it comes from a company, IANAL but I am pretty sure that there is really nothing original in the file (everybody else would write it the same) so I think you can commit it yourself and nobody could complain or accuse you from illegal copying...

Ah, so simple. Please put your credit in index.d.ts or README.md and I will merge this request. If someone complain about the test suit, I can call you then.

OK, take a look at index.d.ts. Is this what you meant?

The copyright info should be more explicit just like this one: http://choosealicense.com/licenses/mit/
After that please combine your commits with git rebase -i master and push again.

So, is this OK?

Well done. :)

v0.9.7 is out. Oh man, why did you deactivate your account so quickly… :-(
radek-holy @ 2015/11/9:

OK, take a look at |index.d.ts|. Is this what you meant?
—
Reply to this email directly or view it on GitHub
https://github.com/jakwings/node-temp-fs/pull/2#issuecomment-154853552.

OK, they have made my account available again. Said to see you reverted my commit :(

Well, maybe you account is too fresh on GitHub. Anyway, please advise GitHub to change the strategy of spam detection: Notify the user and visitors first before hiding the profile.
Sorry for reverting your commit, now I want to keep it simple and only export the vanilla JavaScript interface to npm users. Just glanced through the repository of DefinitelyTyped definitions, it seems much easier to integrate TypeScript with npm for long time development.

Anyway, please advise GitHub to change the strategy of spam detection: Notify the user and visitors first before hiding the profile.

I did. Believe me that I'm really disappointed with this incident. An apology from them is not enough.

Sorry for reverting your commit, now I want to keep it simple and only export the vanilla JavaScript interface to npm users. Just glanced through the repository of DefinitelyTyped definitions, it seems much easier to integrate TypeScript with npm for long time development.

Not sure I understand you. Anyway, I'm going to push it there then...


Upgrade 'openssl' dependency to 0.10.42

This is mainly to allow using OpenSSL 3 through native-tls.

This is not necessary. Just run cargo update.


Be more defensive when iterating over sequence that changes dynamically

Otherwise you'll get into troubles.

Is this in relationship to #42? I'm hesitant to merge this, because while it won't throw an exception, the parsing logic could actually be wrong and I don't want to come out of the loop without parsing all the data. Perhaps we can resolve #42 first before this?

You modify sequence you're iterating over by pop()'ing from it, this is only check we still have anything left to consume in the sequence, it does not skip anything.
Other option could be to iterate over a shallow copy.


Add possibility to alternate between dim up and down by button hold actions

Is your feature request related to a problem? Please describe.
I would like to be able to control both on/off and dim of a lamp using a single button.
Describe the solution you'd like
Let's say I have a single button remote which supports short press and hold actions. I would like to be able to both toggle on/off of a lamp using short press of the button, but also be able to dim the same lamp up and down but using the hold action. The hold action should alternate between dim up and dim down. The speed of dimming should preferably be controllable via config. The dimming should occur as long as I hold the button, and stop once i release the button.
Describe alternatives you've considered
Currently I'm solving this by using ControllerX via Appdaemon, but would like to move this logic into z2m to get rid of the dependency to external applications.
Additional context
Thanks for the great extension :)

Hi,
thank you for your interest.
The feature proposed is very interesting.
I will think about how to implement it.
Did you try tuya scene button? If you bind it to a device does what you want I guess.

I have not tried the Tuya scene button. But if I bind for example the Ikea STYRBAR to an Ikea Lamp, the 4 buttons are pre-configured to control brightness and colors.
With my proposed feature, it would be possible to control on/off state and brightness of 4 different lamps/groups of lamps using a single STYRBAR device. The big win for me would be to be able to reduce the number of remotes I need to place in each area of my home, which in turn makes it easier for other family members who want lamps to "just work" from the single remote on the wall, and they can stop trying to remember which remote goes to what :)
There is also another nice use case which I'll try to explain as short as possible. See https://www.domoticz.com/forum/viewtopic.php?p=257557&sid=249401700a7750402f3c8f201666407a#p257557
Basically solder cables to the switches on the remote PCB, which allows you to control presses with regular wall switches. This is gives great acceptance factor as no new devices needs to be introduced to the rest of the family :)
Thanks for considering the proposal!

I had an idea about how to get this result. I will work on it as soon as I will have time but I guess it can work.


jsx-first-prop-new-line: autofix

Hi I have made an autofix for the rule jsx-first-prop-new-line for a fork and I thought it would be useful to have it on the main repo.
I am aware and monitoring #883. Will update the autofix after that is approved! Meanwhile, PR for visibility and to start the process :)

Rebased on top of #883. No major changes except for adding outputs to test cases.
However, I would like to take this moment to point out that the current code uses a foreach loop:
        if (
          (configuration === 'multiline' && isMultilineJSX(node)) ||
          (configuration === 'multiline-multiprop' && isMultilineJSX(node) && node.attributes.length > 1) ||
          (configuration === 'always')
        ) {
          node.attributes.forEach(function(decl) {
            ...collapsed code...
         }

This results in multiple errors being thrown in fail cases with multiple props:
options: ['always']

<Foo propOne="one" propTwo="two"/>

Seeing that this rule is only concerned with amending the position of the first prop, should the function be only checking for the first prop and throwing error if the first prop fails?
Possible fix:
// We check for at least one prop to ensure we can safely use node.attributes[0] inside
        if (
          (configuration === 'multiline' && isMultilineJSX(node) && node.attributes.length > 0) ||
          (configuration === 'multiline-multiprop' && isMultilineJSX(node) && node.attributes.length > 1) ||
          (configuration === 'always' && node.attributes.length > 0)
        ) {
          var decl = node.attributes[0];
         //Code to verify and fix decl

@snowypowers while i think it makes sense to only throw for the first error as long as the autofixer results in no remaining cases of the error.

Included the fix for multiple props on the first line causing lint to throw 1 error per prop, causing AssertionError. First Invalid test case amended to include such a scenario.
Hope that is all :)

To be clear, if we can get this completed and merged and the Readme updated with the --fix command included
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-first-prop-new-line.md
Then I'd like to donate $50 American to @snowypowers. I can Paypal or Venmo this if you shoot an email to<EMAIL_ADDRESS>with the email you want it delivered to.
That would take care of this 930
My team could also greatly benefit from closing out 929 with a --fix command for jsx-max-props-per-line.
I'd donate another $50 American for whoever can get this working, completed and merged with the readme updated.
Have any questions, find me on twitter. Go team open source.
@revisionfour

I'll give this a day or two to be reviewed by other collabs, then I'll merge it in.

$50 donated to @snowypowers.
Thanks Yak Jun Xiang!
If you or anyone else is up for it, 929 has a $50 bounty on it.
Go team open source!

Hey thanks @revisionfour for the generous donation! Glad to know that my code will be utilised immediately!


Prevent PokePointer from returning zero-vector normals

Overview
The implementation of TryGetNormalToNearestSurface() for PokePointer always returned true, even when no proximate collider was found. This could cause zero-vectors to be returned by that function, which created mathematical errors and log spam down the line.
Changes
I've altered this implementation to return false when there's no nearby collider and set the output to a valid unit vector regardless (this is the same output as GrabPointer in this situation).

/azp run

/azp run

/azp run


PSCore-Preview.3 - Instructions missing to install PowerShell in Ubuntu 18.04

Steps to reproduce
Following current documentation link Ubuntu 18.04 from the landing page in the "Instruction" section:
https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-linux?view=powershell-6#ubuntu-1804

Expected behavior
To show PowerShell Core installation instructions for Ubuntu 18.04.

Actual behavior
Information is missing.

Environment data

> $PSVersionTable

Please include the Ubuntu 18.04 repository information.
I try the following but didn't work.
curl -o /etc/apt/sources.list.d/microsoft.list https://packages.microsoft.com/config/ubuntu/18.04/prod.list

Guys! Is the documentation also only be update when the product has reached GA?

Hi @iSazonov
I will open the issue in PowerShell-Docs.
Thanks!

@iSazonov I think PowerShell-Docs repo should contain only GA-related information. Ubuntu 18.04 is not supported for PowerShell Core 6.0.2.

@alexandair PowerShell-Docs has a branch for the 6.1.0 release where these vNext issues can be addressed. https://github.com/PowerShell/PowerShell-Docs/tree/release-ps61

I would expect some type of documentation to be provided for the Preview releases instead of doing trial and error figured out yourself kind-of-thing.
If is not documented in the Microsoft Docs, then why not create another doc section on Github for updated Preview installation instructions?
:)

as per @markekraus point above this is already in place with v6.1 branch of the docs with the benefit that when 6.1 GA's then the docs are already there

IMO, preview releases are intended for a technical audience that should not require specific documentation on installation unless there is some major change to the installation process. That kind of information should be present in the release notes for the RC/Preview release.
The 6.1.0-preview.3 release page provides links to deb packages and the installation of deb  packages is pretty straight forward. IMO, There should be a realistic expectation from technical users testing Preview and RC releases that live documentation will reflect the latest GA release, and not the RC and preview releases.
As the information relevant to this issue is already present in the correct documentation branch in PowerShell-Docs I am closing this issue.


Fix UnicodeDecodeError while installing using setup.py

On a current version, installing by given pip or setup.py, the error thrown:
(venv) C:\Users\OWNER\Documents\_github\test>pip install jax
Collecting jax
  Using cached jax-0.4.1.tar.gz (1.2 MB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\OWNER\AppData\Local\Temp\pip-install-3uze50ne\jax_2313d4a2790f4c34bb54679a87916fff\setup.py", line 38, in <module>
          _long_description = f.read()
      UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 1301: illegal multibyte sequence
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.

So I fixed it by passing argument encoding="utf-8" and it works.

Hi - thanks for the PR. It looks like this issue has been fixed already in #13884

Why you merged your PR and closed mine?


Arch Linux AUR package

I created AUR package for Arch Linux: https://aur.archlinux.org/packages/jql/
The installation instructions for Arch Linux users:
yay -S jql

Describe the solution you'd like
I suggest adding this (as installation instructions or just a mention of the link) to the README

Hi @frol !
This is just awesome, thanks a ton!
I'll do it ASAP! :bowing_man:

@frol Thanks a lot for your contribution! A new release has been created.


[CARBONDATA-2610] Fix for datamap creation failed on table having loaded data with null value on string datatype

Problem: Datamap creation having null values already loaded in string datatype of table fails.
Solution: Check for null before converting data to the string.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed? No

[ ] Any backward compatibility impacted? No

[ ] Document update required? No

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required? Yes
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5184/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5294/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6346/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5296/

LGTM


:val() cannot match boolean value

i try it in demo
.preferred:val(true)
the function :val() cannot match any thing, the val is only using in string ?

ok
i try this can work
.preferred:expr(x=true)


Refactor migrate password page to functional component

Details
Migrate PasswordPage.js to functional component.
Fixed Issues
$ https://github.com/Expensify/App/issues/16283
PROPOSAL: https://github.com/Expensify/App/issues/16283#issuecomment-1608050469
Tests

Open NewDot App.
Navigate to Setting => Security => ChangePassword.
Add an incorrect password to Current Password field and only letters to New Password field and click on Save button.
Verify Your password must have at least 8 characters, 1 capital letter ... error is displayed.
change the New password field to password that fulfills the above requirement and click on Save button.
Verify Your password changes could not be saved because the old password entered is incorrect error is displayed assuming you added an incorrect password in Current Password field.
Add the correct password to Current Password field and click on Save button.
Verify that Password Updated! screen is shown.

[x] Verify that no errors appear in the JS console

Offline tests

Open NewDot App.
Navigate to Setting => Security => ChangePassword.
Add an incorrect password to Current Password field and letter only to New Password field and click on Save button.
Verify Your password must have at least 8 characters, 1 capital letter ... error is displayed.

QA Steps
Same as Tests section above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/39636266/11d2df7e-4d15-494b-b111-bef7dd534a21

Mobile Web - Chrome
https://github.com/Expensify/App/assets/39636266/8b1d0771-a0c9-41a8-9a41-e09cb9424271

Mobile Web - Safari

Desktop
https://github.com/Expensify/App/assets/39636266/97ceb908-9b41-4337-93b9-df4838ac1c7c

iOS

Android
https://github.com/Expensify/App/assets/39636266/7de385a9-45dc-4620-b816-8c946a2081c2

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.38-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add functionality to use temporary session token for authentication to s3

📑 Description

This merge request added functionality to support session tokens for authentication on S3, enabling it to work with temporary credentials, such as those used in an AWS Lambda environment.

@coderabbitai summary

✅ Checks

[ ] Added test cases for my code

@hwbrzzl please review this mr and merge if possible.

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 5.32%. Comparing base (8a7fae9) to head (cf4203d).
Report is 72 commits behind head on master.

Files with missing lines
Patch %
Lines

s3.go
0.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #123      +/-   ##
=========================================
- Coverage    5.53%   5.32%   -0.21%
=========================================
  Files           3       4       +1
  Lines         307     319      +12
=========================================
  Hits           17      17
- Misses        289     301      +12
  Partials        1       1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Out of date template code

The html template code on this page is out of date.
{% load staticfiles %} < !-- Instruct Django to load static files -->
should be
{% load static %} < !-- Instruct Django to load static files -->

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a1cd413-a2a8-9cb5-3f3a-94822a96af51
Version Independent ID: feadb7ab-ebba-051d-e68c-a758235ce514
Content: Learn Django tutorial in Visual Studio step 3, static files and pages
Content Source: docs/python/learn-django-in-visual-studio-step-03-serve-static-files-and-add-pages.md
Product: visual-studio-windows
Technology: vs-python
GitHub Login: @JoshuaPartlow
Microsoft Alias: joshuapa

@JoshuaPartlow -- Joshua, please review this update in private PR 7999.


Improve UX of existing widgets

Lets do a second pass of the UI once we have basic functionality in place

Closing because this issue is duplicated in the lab-grid/flow project.


Missing file or assembly Newtonsoft.Json

Currently getting an issue finding Newtonsoft.Json:
C:\Projects\test>dotnet watch
[DotNetWatcher] fail: Error(s) reading project file 'C:\Projects\test\project.json':
[DotNetWatcher] fail: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>,
Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies.
The system cannot find the file specified.
[DotNetWatcher] info: Fix the error to continue.
^C
C:\Projects\test>dotnet --version
1.0.0-rc2-002374

The project restores and builds without issue for the follow project.json and NuGet.config.
project.json
{
	"dependencies": {
		"src": "0.1.0-*",
		"Microsoft.AspNetCore.Diagnostics": "1.0.0-*",
		"Microsoft.AspNetCore.HttpOverrides": "1.0.0-*",
		"Microsoft.AspNetCore.Server.Kestrel": "1.0.0-*",
		"Microsoft.NETCore.App": {
			"type": "platform",
			"version": "1.0.0-rc2-23931"
		}
	},
	"frameworks": {
		"netcoreapp1.0": {
			"imports": [
				"portable-net45+wp80+win8+wpa81+dnxcore50"
			]
		}
	},

	"compilationOptions": {
		"emitEntryPoint": true,
		"debugType": "portable"
	},

	"tools": {
		"dotnet-watch": "1.0.0-*"
	}
}

NuGet.config
<?xml version="1.0" encoding="utf-8"?>
<configuration>
	<packageSources>
		<clear />
		<add key="AspNetCIDev" value="https://www.myget.org/F/aspnetcidev/api/v3/index.json" />
		<add key="NuGet" value="https://api.nuget.org/v3/index.json" />
	</packageSources>
</configuration>

@victorhurdugaci

I can reproduce this. Investigating...

The fix is to add imports to the tool and re-restore (make sure you clear the packages folder first because it doesn't work otherwise):
"tools": {
        "dotnet-watch": {
           "version": "1.0.0-*",
           "imports": "portable-net451+win8"
        }
    }

We believe this will be fixed in a future CLI

@victorhurdugaci  On a mac, where can I find this packages folder that needs to be cleared? I deleted ~/.local/share/NuGet/* but it still errors.

it should be under ~/.nuget

Yep, that worked. Thanks


Test PoseExtrapolator

@wally-the-cartographer merge

Merge requested by authorized user gaschler. Merge queue now has a length of 1.


Feature: Add acapy-cache-redis plugin

This adds the acapy-cache-redis plugin to the Dockerfile. Additional configuration will need to be provided to the plugin via the following config options. In addition to having the plugin in the container and adding it to the list of external plugins, the plugin will need ACA-Py 0.7.4 (specifically this PR https://github.com/hyperledger/aries-cloudagent-python/pull/1774) in order to run.
plugin-config-value: 'redis_cache.connection="redis//redis-server:6379/"'

# Optional
plugin-config-value: 'redis_cache.credentials.username="redis-user"'
plugin-config-value: 'redis_cache.credentials.password="password"'

If relevant, see if stuff can be cherry picked, otherwise close. This is an old PR, if there was no need to merge it until now, there probably still isn't any.


libepoxy: disable more cgl tests on x86_64-darwin

Description of changes
Closes #210861.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

AFAIK it was fine on aarch64-darwin, in case you wanted to be a little more "precise".  But mainly I hope the failure really wasn't related to any practical issues.

Let's not wait (for feedback) anymore.


Osra 403

Add "View All", "View Sponsored", "View Unsponsored" filter to orphans#index

something is wrong here with the commits.
Does it need a rebase or is this branch merged with develop?

lets talk about this feature in the scrum, tonight

There's a lot of duplication with the different partials here (not following the DRY principle).
It would be better to have a single partial where the condition to apply to the orphans is passed in as a parameter (eg set up something in the locals: of the partial).

Ok thanks for the tip

You are missing the tests for the views, helpers and models.

There is a merge conflict. Checkout the develop branch and rebase your branch. If you don't know how to do it ask us.

Ok I will check out!


Unable to load 70B llama2 on cpu (llama cpp)

error loading model: llama.cpp: tensor 'layers.0.attention.wk.weight' has wrong shape; expected  8192 x  8192, got  8192 x  1024
The exact same settings and quantization works for 7B and 13B.  Here is my .env
MODEL_PATH = ""
if MODEL_PATH is "", default llama.cpp/gptq models
will be downloaded to: ./models
Example ggml path:
#MODEL_PATH = "./models/llama-2-7b-chat.ggmlv3.q4_0.bin"
MODEL_PATH = "./models/llama-2-70b-chat.ggmlv3.q4_0.bin"
#MODEL_PATH = "./models/llama-2-13b-chat.ggmlv3.q4_0.bin"
options: llama.cpp, gptq, transformers
BACKEND_TYPE = "llama.cpp"
only for transformers bitsandbytes 8 bit
LOAD_IN_8BIT = False
MAX_MAX_NEW_TOKENS = 2048
DEFAULT_MAX_NEW_TOKENS = 1024
MAX_INPUT_TOKEN_LENGTH = 4000
DEFAULT_SYSTEM_PROMPT = ""

@Dougie777 the env looks good to me. might be the error from 70b model.


support for composer

I like to use composer for get updates.

very nice not reply a message but close item instead! @fengyuanchen
Here is a solution for still using composer with workaround!
`{
"require": {
"twbs/bootstrap": "^4.4"
},
"scripts": {
"post-update-cmd": [
"rm -rf public_html/Bootstrap/latest",
"cp -R vendor/twbs/bootstrap/dist/ public_html/Bootstrap/latest",
        "rm -rf git/datepicker",
        "git clone https://github.com/fengyuanchen/datepicker git/datepicker",
        "rm -rf public_html/datepicker/latest/",
        "cp -R git/datepicker/dist/ public_html/datepicker/latest"
    ]
}

}`


Plugin dialogs

@jonnywray - Plugin dialogs (search, preferences, login, etc.) are not yet respected or translated into Roku dialogs.

I just committed a change that takes care of plugin preferences.  Taking a look at search next.

Search appears to be working now (was #17, fixed it somewhat accidentally by doing #37).

@scyber squared this away, closing.


Setup Kanban board

Hello!
This is the link of my project: project link
In this project we are working in a team of two people :
@RolandM99 and @Tumworobere

Hi Team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻

[ ] Great job setting up the board 👍 however according to the requirements all cards should be assigned to team members. You should see a circle with the user's avatar on each card.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Approved project!  💯 ✅ 🥳 🎈 🎉
Hi  Team
Amazing job implementing suggestions from the previous reviewer! 💯
Your Kanban Board is complete!
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


4.4 not working

Has anyone tried the translation tool for 4.4? It didn't seem to work. The apps can be installed but would crash upon starting.

yeah apps crash for me too.


SEGW

SEGW
Commit:<PHONE_NUMBER>1ec345e2150f1a09fa70f7b931dfb9

suggest noting "SEGW is not released for the ABAP Cloud Programming model"
perhaps add a link to https://community.sap.com/t5/technology-blogs-by-members/proof-of-concept-migrating-segw-project-to-abap-cloud/ba-p/13577941 ?

Added in SDTR 2024.6


Upgrade Aspire.Hosting.AppHost to 8.2.0

To address the issue of "eShop.AppHost is a .NET Aspire AppHost project that needs a package reference to Aspire.Hosting.AppHo
st version 8.2.0 or above to work correctly" when first running the solution of eShop.AppHost.csproj, this PR bumps package of Aspire.Hosting.AppHost to 8.2.0.

AspireVersion was updated globally since then, so this PR can be closed.


Gibberish text for dialog options and spoken text

What's the expected benefit of the feature you are requesting?
I have seen this on one of a game developers streams of his work and he didn't want to show dialogs between characters, he used that option to hide all text between them.
Describe the solution you'd like
After turning specific project options, all text would be changed to gibberish.
For example :

"Hello" => "klabt"
"[wave]bye bye[/wave] => "[wave]hjk wqm[/wave]

https://github.com/carenalgas/popochiu/assets/22888465/1f51993e-fb52-441f-ab50-8aed0d096063

Closed with #218


Enables pvcreate to assume "yes" on all questions and not to wait on user confirmation in order to proceed

If there is file system signature on device then pvcreate will prompt user to confirm to wipe FS signature. When this happens, d-s-s will silently ignore this,and will not create desired storage backend ( in this case thin lvm  ) and will start docker using loop lvm storage configuration.
d-s-s at time only checks if there is/are partition(s) on device(s) we specify in "DEVS" section. Device can have ( due to usage of device for file system sometimes before ) file system signature - even there is not any partition on it.
This PR enables pvcreate to assume "yes" on all questions during pvcreate step.

You seem to have two patches which contain overlapping contents. You will need to fix that.
Secondly, I am not sure if overwriting the existing fs is always the right thing to do. Somebody might complain that don't overwrite it by default.
I tested and pvcreate does fail if disk already had a valid fs. "sfdisk" did succeed though after giving warning.
Jul 20 08:08:06 vm2-f22 docker-storage-setup[6447]: Failed to get offset of the xfs_external_log signature on /dev/vda1.
Jul 20 08:08:06 vm2-f22 docker-storage-setup[6447]: 1 existing signature left on the device.
Jul 20 08:08:06 vm2-f22 docker-storage-setup[6447]: Aborting pvcreate on /dev/vda1.

Actually above pvcreate error does not get resolved even if I use "-y". Looks like this is not a question at all and it might be a bug with pvcreate.

@rhvgoyal ok, check also lvcreate in d-s-s, ( thought it does not ( or at least not in man ) -y switch )
if you add -y to lvcreate line have you same bahaviour?

Tools like pvcreate abort in this situation for a reason.  Why wouldn't we require system administrators to use tools like wipefs to take explicit action?  We don't want a configuration typo to blow away critical data.

@cgwalters we assume here that there are not partitions ( as first requirement for d-s-s ) on device and want to use it for storage, and it is added in DEVS section. So after we setup device ( we decided to do that , we want to use it ) in DEVS="" section afterwards pvcreate fails - admin will already do all what is needed, if device added in DEVS="" section then I guess that is what is wanted.Anyway I think at least we need to print that error message - as of d-s-s will silently fail and start docker with loop lvm.

@ekuric
I think lvcreate does not have any switch -y. So how are you using it?
w.r.t the error I am seeing, I am checking with lvm developers. There seem to be multiple discrepancies.
First of all sfdisk goes ahead and create the partition table despite the fact that it detects xfs signature. And it does not delete that existing signature and creates partition table signature on top.
/dev/vdb: device contains a valid 'xfs' signature; it is strongly recommended to wipe the device with wipefs(8) if this is unexpected, in order to avoid possible collisions
Checking that no-one is using this disk right now ... OK
I agree with @cgwalters that if a valid signature is there on the disk passed in DEVS=, then we should bail out with proper error message and ask user to wipefs to wipe signature clean and retry. We don't want to destroy user's critical data due to configuration error.

@rhvgoyal no I am not using it, I was just hoping it has it somewhere hidden and not documented. I agree with you and @cgwalters, then we should send that error message informing why device was not possible to use as pv, what do you think?

@ekuric
If you are not using it and if you have not tested it (lvcreate -y), I am not sure why are you generating the patch? Atleast please test the patch before you request a merge. Otherwise this just increases the work for reviewers.

@ekuric
Can you paste the error you are facing with "pvcreate"?

@rhvgoyal ok,will reproduce it and will come back, of course I tested it...but seems only -y with pvcreate worked in this particular case - you can see I edited that in second patch...will follow up, thank you

Ok, I came to know about couple of more things.

lvcreate does support --yes option. It is supposed to part of generic lvm commands.
I noticed warning during "lvcreate" which says whether you want to wipe xfs signature or not. As we are running from systemd service context, default answer is "no". Still signatures get wiped out anyway. Because lvm seems to have another default --zero=yes which wipes first 4K of block.

I think it should be ok to make sure nobody can add a disk with data in pvcreate. Once we have passed that step, we should not have any need to check preserve signature and we can use "-y" in
lvcreate. I will create another pull request for this and see what does @cgwalters think.

@rhvgoyal I thought that when I faced this issue, but if it is risky to use -y,then at least we need to inform user  that pvcreate failed.

I think at the time of "pvcreate" we should not use -y. But once disk has been added to volume group, it might be reasonably safe to wipe signatures on logical volumes.

This is fixed by https://github.com/projectatomic/docker-storage-setup/pull/57 right?

Part of it  is fixed by #57 (lvcreate -y). Other part we don't want to fix (pvcreate -y). So I think it can be closed it now.


Edit menu shortcuts are invisible

On Macos with the latest dev version, shortcuts for the edit menu are not visible

They are disabled because you need to have something selected for Copy and Cut, and also something to make a Redo.
I don't see a problem with that :-)

No, I mean there is no shortcut! What is the shortcut for Indent? or for toggel Uppercase

Ohhh, is it for all menus or just the Edit one?

Only edit :-|


TensorBoard not syncing with wandb

Describe the bug
Tensorboard is not being synced with wandb, even when specifying wandb.init(sync_tensorboard=True)
To Reproduce
Steps to reproduce the behavior:

Initialize wandb: wandb.init(sync_tensorboard=True)
Log to tensorboard using tf.summary.scalar()

Simple TensorFlow training script to reproduce this manner:
https://gist.github.com/sff1019/8870a9e15e95b9e469cd3419b7891c2e
Expected behavior
It was expected to log metrics by syncing TensorBoard (Followed the directions as shown here: https://docs.wandb.ai/integrations/tensorboard)
Screenshots
As shown in the screenshot, no metric / TensorBoard was logged.

Desktop (please complete the following information):

OS: Ubuntu 20.04.1
Browser: Chrome
Version:

wandb==0.10.15
tensorflow==2.3.0
tensorboard==2.4.1

Additional context
I haven't tested with logging into TensorBoard using tensorboard_callback = tf.keras.callbacks.TensorBoard(log_dir=log_dir, histogram_freq=1).

Hey @sff1019
Thanks for a great repro along with the ticket
I would add to the issue here that
# Sync TensorBoard with WandB.
wandb.tensorboard.patch(root_logdir=train_log_dir)
wandb.init(entity="xxx", project="xxx")

Aslo fails to track the tfevent files
Tagging @vanpelt  for some expertise in this ticket.

@sff1019 can you share how you're logging to tensorboard in your script if you aren't using the keras tensorboard callback?

@sff1019 never mind, I see your gist now.  We'll take a look ASAP.

@vanpelt @ariG23498 @sff1019  I am having same issue with TensorboardX #1696

same issue. Anyone could find a solution to it

Hey folks,
Just a heads up, and we’re going to emphasize this in the docs, but you have to create the file_writers after calling wandb.init
Let us know if this helped! 😄

@ariG23498 Thank you for the info! This seems to work! 😄

@sff1019 could you explain

Simple TensorFlow training script to reproduce this manner:
https://gist.github.com/sff1019/8870a9e15e95b9e469cd3419b7891c2e
In this training script I have modified the following:

# Sync TensorBoard with WandB.
wandb.tensorboard.patch(root_logdir='logs/gradient_tape/')
wandb.init(entity="xxx", project="xxx")

current_time = datetime.datetime.now().strftime("%Y%m%d-%H%M%S")
train_log_dir = 'logs/gradient_tape/' + current_time + '/train'
test_log_dir = 'logs/gradient_tape/' + current_time + '/test'
train_summary_writer = tf.summary.create_file_writer(train_log_dir)
test_summary_writer = tf.summary.create_file_writer(test_log_dir)

model = create_model()

EPOCHS = 5

for epoch in range(EPOCHS):
    for (x_train, y_train) in train_dataset:
        train_step(model, optimizer, x_train, y_train)
    with train_summary_writer.as_default():
        tf.summary.scalar('loss', train_loss.result(), step=epoch)
        tf.summary.scalar('accuracy', train_accuracy.result(), step=epoch)

    for (x_test, y_test) in test_dataset:
        test_step(model, x_test, y_test)
    with test_summary_writer.as_default():
        tf.summary.scalar('loss', test_loss.result(), step=epoch)
        tf.summary.scalar('accuracy', test_accuracy.result(), step=epoch)

    template = 'Epoch {}, Loss: {}, Accuracy: {}, Test Loss: {}, Test Accuracy: {}'
    print(
        template.format(epoch + 1, train_loss.result(),
                        train_accuracy.result() * 100, test_loss.result(),
                        test_accuracy.result() * 100))

    # Reset metrics every epoch
    train_loss.reset_states()
    test_loss.reset_states()
    train_accuracy.reset_states()
    test_accuracy.reset_states()

I am closing this issue for the time being. Please let us know if the problem persists! :smile:

Very relevant:

https://github.com/wandb/wandb/issues/1782#issuecomment-779161203

Just a heads up, and we’re going to emphasize this in the docs, but you have to create the file_writers after calling wandb.init


Feature request: iperf3 server and client

It would be great to have a configurable istance of iperf3 in
Interfaces/Diagnostics
Two menu items in it:
Server and Client
At the moment:
from command line I installed iperf3 as well
pkg install iperf3

@peppelinux you can get the server in a simple implementation

Hi Fabian, thank you for your attention.
Actually I'm very busy at the job and hopefully I'll try to push this feature soon as possible but not before January. I'd like also to see my arpscanner plugin in the stable release (not development) before start some other application in OPNsense.


chore: minor updates to gwas catalog pathnames

Codecov Report
Attention: 178 lines in your changes are missing coverage. Please review.

Comparison is base (42b366c) 85.67% compared to head (e8680a4) 85.99%.
Report is 88 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #440      +/-   ##
==========================================
+ Coverage   85.67%   85.99%   +0.31%
==========================================
  Files          89       96       +7
  Lines        2101     2627     +526
==========================================
+ Hits         1800     2259     +459
- Misses        301      368      +67

Files
Coverage Δ

src/airflow/dags/common_airflow.py
90.38% <100.00%> (ø)

src/airflow/dags/dag_preprocess.py
100.00% <ø> (ø)

src/airflow/dags/finngen_preprocess.py
100.00% <100.00%> (ø)

src/airflow/dags/gwas_curation_update.py
100.00% <100.00%> (ø)

src/gentropy/__init__.py
100.00% <ø> (ø)

src/gentropy/assets/__init__.py
100.00% <ø> (ø)

src/gentropy/assets/data/__init__.py
100.00% <ø> (ø)

src/gentropy/assets/schemas/__init__.py
100.00% <ø> (ø)

src/gentropy/cli.py
91.66% <100.00%> (ø)

src/gentropy/common/Liftover.py
80.64% <ø> (ø)

... and 81 more

... and 10 files with indirect coverage changes


Setting timeout_ms for AuthService does not seem to be wokring

We would like to control timeout of AuthService which right now is default to 5000 ms. Currently there seem to be now setting in ambassador to control the same. We have the following config ->

apiVersion: v1
kind: Service
metadata:
name: example-auth
namespace: development
annotations:
getambassador.io/config: |
---
apiVersion: ambassador/v0
kind:  AuthService
name:  authentication
auth_service: "getuserinfo:80"
path_prefix: "/auth/"
ambassador_id: ambassador-development
Something like  "timeout_ms: 8000" for mapping would be useful

Is there a workaround for setting this via envoy config parameters?


About the constraint term in the objective function J^{LSD}

Thank you for your interesting work!
I wonder if the constraint term in the objective function J^{LSD} of the optimization φ is considered in the code implementation? And why is there no constraint term in equation (7)?
Looking forward to your reply!

Hi Pengyu, thank you for your interest in the work. As mentioned in Section 3 and Appendix C, we implement the Lipschitz constraint in Eq (6) by using Spectral Normalization (--spectral_normalization=1).  We do impose the same constraint for the per-transition reward in Eq (7) as well, but we didn't explicitly write this constraint in Eq (7) again for simplicity.


#213: Update references to Tailor website to use HTTPS

Resolves #213.

Current coverage is 88.35%

Merging #232 into master will not affect coverage as of 4249d97

@@            master    #232   diff @@
======================================
  Files           40      40
  Stmts         1597    1597
  Branches       267     267
  Methods          0       0
======================================
  Hit           1411    1411
  Partial         70      70
  Missed         116     116

Review entire Coverage Diff as of 4249d97

Powered by Codecov. Updated on successful CI builds.

:+1:


Spider's shadow

360 Spider's shadow tends to cull often. What's curious is that the original Xbox version of OT2 has those black sprites that the traffic & rivals have to simulate AO kind of thing in addition to the real time shadows but c2c doesn't have them. Perhaps it was originally meant to mask the culling. Idk.
https://github.com/emoose/OutRun2006Tweaks/assets/92535412/1b31b708-2bcf-4d3f-93f9-73f64cd8d182
It'd be nice if something could be done about this.

Should mostly be fixed with d0d4cd70f02a09af51341cb3df0e3e15a1664837 now, that restores the base shadow at least,
Stencil shadow still has some issues though, the main one you showed gets masked by the base shadow, but I noticed sometimes end screens that have your car shown at an angle have weird stencil shadows behind it (eg. if you do one of the single gf mission levels, when you end it on the highway it almost always bugs the shadow out, I'll see if I can get a pic soon...)
Wonder if console vers also have issues with the stencil shadow too, apparently stencil shadowing can have a lot of pitfalls if they aren't implemented properly :/


Keyboard nav: Translations loses contrast on hover

Description
When navigating the "Edit" page the text in the pill that says "Translations" turns white (cannot be read) when hovered.
Steps to reproduce

Go to /fr/form-builder/0000/edit to create a new form
Tab through the parts of the page until you get to "Traductions"
See how the text disappears

Details

Browser: Edge
Operating system: Windows
Environment: QA Testing PR
Language: French
Viewport: Tablet

Expected behaviour
Be able to read the text in the pill
Screenshots or videos

Fix is merged.

@anikbrazeau can you re-test? :)

It's fixed!


path does not working if cwd is not the cfg file location

Describe the bug
path does not working if cwd is not the cfg file location since path accepts glob
To Reproduce

move the mkdocs.yml into a folder, for example tools/mkdocs
run command mkdocs build -f ./tools/mkdocs/mkdocs.yml -d ../../site
See error

Ha, indeed, I didn't think about that when merging the feature. Globs must be expanded, and for that the CWD must be right. I'll review you PR, thanks!

Fixed in 0.8.1.


feat: upgrade argo to 2.12.4

What this PR does:
Which issue(s) this PR fixes:

Fixes onepanelio/core#
Special notes for your reviewer:
Checklist
Please check if applies

[ ] I have added/updated relevant unit tests
[ ] I have added/updated relevant documentation

Required

[x] I accept to release these changes under the Apache 2.0 License

@Vafilor have a conflict here - also we updated manifests to 2.12.5 just in case we need to change anything here.

@Vafilor have a conflict here - also we updated manifests to 2.12.5 just in case we need to change anything here.


React issue - Cannot recognize locators on React panels

The base of our website uses angular but on top of that we have implemented React panels for most of our new features. We cannot get robotframework to interact with any of the elements/ locators on these panels. Are there any suggestions for how to work around this? Or anything planned for improvements around React + robotframework?

I do not think anyone can help without any code snippet...

This issue tracker is for bug reports and enhancement requests related to Robot Framework itself. Issues related to external libraries and tools belong to their trackers and questions are typically better asked on dedicated support forums listed at http://robotframework.org.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-21-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 723

Questions ?
Please refer to the Backport tool documentation


can't build/run the project

I've downloaded the project, imported into Android Studio and I get
Gradle 'ListViewAnimations-master' project refresh failed
Error:Cause: repository not found: C:\Users\K-\Desktop\ListViewAnimations-master
Tried to import it multiple times, restarted Android Studio, restarted computer..
I've managed to make it run in Eclipse. But in Android Studio (latest version) it won't work. Do I need to do anything else other than importing the project?

I have the same problem.
Must clone it?


Bug/adding histograms

@Brennan1994 please take a look at the math we're using to add histograms, it is not very good. I think we need a better way, but I am not sure how. My initial thought was independent random sampling as we do for AAEQ and damage reduced, but I know the field is going to look to see that the numbers add up by quantile across the various dimensions, and I don't think that will be guaranteed by independent sampling - something that has me concerned about the AAEQ and damage reduced stuff.


More but shorter server rules

The server rules aren't much good - they're too long, badly ordered and they don't cover nearly enough of what we want to say. Let's make them better.

It may well be just not built for this sort of configuration.

Starting work in my fork on reworking the rules, let me know if there's any specific changes to be made (may go on hold over Christmas).

Have created a PR for an initial update to the server rules under #33, let me know any thoughts.


Mention TITLEPREFIX in the tutorial about tab titles

I'm not sure if this is worth mentioning, but when using git-bash (probably one of the more popular bashes for Windows), then the simpler suggested command in the documentation didn't work for me, but this one did:
export TITLEPREFIX="Git Bash"

From here: https://stackoverflow.com/a/48740679/521799

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 349883e2-58e8-1c35-1414-0440ffda64a3
Version Independent ID: 46a673fd-9560-6c8d-5b0b-e1723c184b73
Content: Windows Terminal Tab Title Setup
Content Source: TerminalDocs/tutorials/tab-title.md
Service: terminal
GitHub Login: @cinnamon-msft
Microsoft Alias: cinnamon

Thanks for the suggestion @lukaseder. It's a good tip, but doesn't feel necessary to include in our docs at this time.


Unable to reference the properties defined in form-data in overwriteRequestBody

Hello there.
I have a POST endpoint called /vehicles which has been implemented as multipart/form-data and accepts 3 properties, namely-

files (json file uploaded by client)
vehicleType (alphanumeric string)
release (alphanumeric string)

In postman, this request would look like below screenshot-

and, the OpenAPI spec is as follows-
{     "/v1/vehicles": {         "post": {           "operationId": "VehicleController_addVehicle",           "parameters": [],           "requestBody": {             "required": true,             "description": "Vehicle data",             "content": {               "multipart/form-data": {                 "schema": {                   "$ref": "#/components/schemas/AddVehicleDto"                 }               }             }           },           "responses": {             "200": {               "description": "Vehicles added successfully"             },             "401": {               "description": "Authorization is required",               "content": {                 "application/json": {                   "schema": {                     "$ref": "#/components/schemas/UnauthorizedExceptionDto"                   }                 }               }             },             "404": {               "description": "Vehicle type does not exists",               "content": {                 "application/json": {                   "schema": {                     "$ref": "#/components/schemas/NotFoundExceptionDto"                   }                 }               }             },             "500": {               "description": "Internal Server Error",               "content": {                 "application/json": {                   "schema": {                     "$ref": "#/components/schemas/UnknownExceptionDto"                   }                 }               }             }           },           "tags": [             "Vehicles"           ],           "security": [             {               "bearer": []             }           ]         }     } }
Alternatively, please find the above spec in jsonblob
My overwrites.yml code looks like below:
- openApiOperation: "POST::/v1/vehicles"     overwriteRequestBody:       - key: 'files'         value: 'files:tests/portman/create-vehicle.json'       - key: 'vehicleType'         value: '6703abea1c0324d0e17d5afb'       - key: 'release'         value: '6703abf51c0324d0e17d5b28'     overwriteRequestHeaders:       - key: Content-Type         remove: true
In the overwrites.yml file, I'm referencing the form-data props as key: 'files', key: 'vehicleType' etc
But, I don't think this works as expected.
When running the tests locally, got the following error from API-

Could you please guide me what I'm doing incorrectly.

hi @Arrow2dknee
The jsonblob mentions $ref elements, but the actual $ref values are missing.
Would it be possible to share the endpoint and related components/schemas, that way we can try to reproduce your setup and investigate your issue.

Hi @thim81,
The API looks like below:

AddVehicleDto (from $ref) looks like below

The form-data needs the below required information-
'files' - a json file
'vehicleType' - string representation of a mongo id
'release' - string representation of a mongo id
I have written my overwrites for this endpoint as below:

Let me know if this helps.

Hi @thim81 , Could you please have a look into my comment above?

Hi @thim81 , I'm still having this issue.
Could you please let me know if you have all the information to assist me with this issue? If not, let me know what you need.

hi @Arrow2dknee
Would it be possible to share the OpenAPI endpoint as YAML or JSON, only that endpoint?

hi @Arrow2dknee
We still want to help figure out what is going wrong, would you be able the OpenAPI endpoint as YAML or JSON, only that endpoint?


Use Blazor 0.8.0 preview

This is work required to make Logging extension work with Blazor 0.8.0 preview which is hybrid version between original Blazor and Razor Components based Blazor
This is change for informational purposes only, to serve as sample for those who want to try 0.8.0-preview bits of Blazor
I order to use pre-compiled version of this PR, you could add to you project file
  <PropertyGroup>
    <RestoreAdditionalProjectSources>
      https://dotnet.myget.org/f/blazor-dev/api/v3/index.json;
      https://www.myget.org/F/blazor-experiments/api/v3/index.json;
    </RestoreAdditionalProjectSources>
  </PropertyGroup>

Nuget was created using dotnet pack Blazor.Extensions.Logging.csproj /p:Version=0.1.11-preview1 /p:Configuration=Release to those who want to create package manually from branch

Updated to preview4


openliberty_microprofile_tck failed with jdk11

https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/440/console
openliberty_microprofile_tck failed with
13:15:04  16 errors
13:15:04
13:15:04  FAILURE: Build failed with an exception.
13:15:04
13:15:04  * What went wrong:
13:15:04  Execution failed for task ':com.ibm.ws.componenttest:compileJava'.
13:15:04  > Compilation failed; see the compiler error output for details.
13:15:04
13:15:04  * Try:
13:15:04  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Can we try with a newer version: https://github.com/OpenLiberty/open-liberty/releases/tag/gm-<IP_ADDRESS> to see if its the same issue?

Rerun recent got another error ( old tag):
15:27:33  error  : Unexpected ProjectBuilder init,  error A Jar can only accept a file or directory that exists: /root/.m2/repository/org/apache/commons/commons-lang3/3.8.0/commons-lang3-3.8.0.jar
15:27:33
15:27:33  FAILURE: Build failed with an exception.
15:27:33
15:27:33  * What went wrong:
15:27:33  Execution failed for task ':com.ibm.ws.org.apache.commons.lang3:jar'.
15:27:33  > com.ibm.ws.org.apache.commons.lang3 has errors, 2 errors were reported
15:27:33
15:27:33  * Try:
15:27:33  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
15:27:33
15:27:33  * Get more help at https://help.gradle.org/
15:27:33
15:27:33  BUILD FAILED in 28m 25s
15:27:35
15:27:35  openliberty_microprofile_tck_0_FAILED
15:27:35

rerun with latest tag:
https://ci.adoptopenjdk.net/view/work-in-progress/job/grinder_sandbox_new/559/consoleFull


Dashboards for monitoring tutorial

Summary of the changes / Why this is an improvement
Needed for https://github.com/crate/cloud-tutorials/pull/92
Checklist

[x] CLA is signed

Do you need to add new lines to the end of the JSON files?


Added Hovering to more details button

Description

List out your changes
Link the Issue which this resolves

Affected Dependencies
How has this been tested?
GIF Before

If any UI Changes, Use this to record or else specify NA

GIF After
Checklist

[x] I have followed the Contribution Guidelines.
[x] My changes do not edit/add any unrequired files.
[x] My changes are covered by tests.

@Praful932 @maneprajakta I've closed earlier pr due to some issues and created this new one. Now can you pls review my pr for issue #249

Pls merge my pr @Praful932 @maneprajakta


Not an issue, but more of an update/proposal/question thing ;)

@joshbrw
I've noticed your commit history and you're secretly still active ;)
I've created a fork and updated/refactored some parts most current PR's talk about. Update the tests using PHPUnit 11 and brought those tests up to date.
If by change there is any interest to bring this package up to date, we could go through the changes (it isn't that much). The readme is up to date on the changes it brings.
If the interest is just mine, don't feel bothered and have a good day :)
Cheers.

Hi @wize-wiz,
Thanks for this.
You're right - I am active, but I only work on commercial work now. I originally created this project to assist me in a commercial project.
If you're happy to maintain this, I can mark this project as abandoned with your repo as the suggested alternative.
Thanks

@joshbrw

You're right - I am active, but I only work on commercial work now. I originally created this project to assist me in a > commercial project.

That's good to know.

If you're happy to maintain this, I can mark this project as abandoned with your repo as the suggested alternative.

Hmm I wasn't really aiming to replace your repository with mine and I don't think it's a solution that will last. This package in its current state does its job very well but can't really do much, which seems to be fine for a lot of folks :)
After posting my suggestion to get this package to do a little bit more, I started writing my own version using this package as a starting point. I will commit my last changed to my fork and then I will work on my own version on gitlab. You can do with my fork whatever you want.
Your package was mentioned in some topic called Publishing modules to auto-install modules using composer require. Here I got the idea these two packages somehow work together.
The only solution I see is to incorporate this package in nwidart/laravel-modules and then you can abandon this repo ;)
Thanks for your reply and cheers!


desktop - DeFiChain Wallet

What kind of PR is this?:

/kind feature
What this PR does / why we need it:
Creates initial desktop structure for Electron.

Added electron-build.yml to trigger dev builds on PR and push to main

Notarization step for Mac OS

To run the app, go to desktop-app directory and run npm run start:dev

It will run expo local server and trigger initiate-electron.js
initiate-electron.js will wait for the expo server to be available before creating the window

Added basic menu for Window
On dev, it will run with Playground screen.
If you want to test out a binary, you can run a specific command for your OS.

example: npm run build:win - will trigger a binary build for Windows. It will be on your desktop-app/dist

Fixed linking.ts to open web to new tabs instead of same app
Added index.html and webpack.config.js from @expo/config to customize paths for Web and Desktop. Reference - https://docs.expo.dev/guides/customizing-webpack/

Which issue(s) does this PR fixes?:

Fixes #864
Fixes https://github.com/DeFiCh/wallet/issues/865
Fixes https://github.com/DeFiCh/wallet/issues/867 (Mac)
Additional comments?:
Developer Checklist:

[ ] Read your code changes at least once
[ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[ ] No console errors on web
[ ] Tested on Light mode and Dark mode*
[ ] Your UI implementation visually matched the rendered design*
[ ] Unit tests*
[ ] Added e2e tests*
[ ] Added translations*

Looking at this PR now


Use neondatabase/ library changes for tokio-tar

Based on https://github.com/neondatabase/tokio-tar/pull/1
If the tokio-tar approach is right, for the library management, we can merge it in master there and use rev=$SHA here instead of the branch.

https://github.com/neondatabase/tokio-tar/pull/1

this is fine for us in the meanwhile

merging


Cannot build mill assembly from a release source archive

When building assembly from the source tarball:
$ curl -LO https://github.com/lihaoyi/Ammonite/archive/2.3.8.tar.gz
$ tar -xf 2.3.8.tar.gz
$ cd Ammonite-2.3.8
$ mill 'amm[2.13.3].assembly'
Compiling /home/ro/workspace/github/Ammonite-2.3.8/build.sc
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
os.SubprocessException: CommandResult 128

  os.proc.call(ProcessOps.scala:85)
  ammonite.$file.build.$init$(build.sc:11)
  ammonite.$file.build$.<clinit>(build.sc:40)

It looks like build.sc expects the source to be in git repo.
Is building from the release archive supported? I could not find any docs on that.

What is the use case for this?
You can just clone this repo and then run that command.

Just jumping in here to say one use case for adding support for this would be putting tools on to conda / conda-forge https://conda-forge.org/ and other similar package / environment managers. As is attempting to build from a release tar ball for a package that uses mill to build it will not work since release tar balls are not git repos. And since conda-forge requires using release tarballs such that they can be checked vs a sha256 / md5 checksum'd this means that tools that use the mill build script to compile themselves at present cannot be distributed on conda-forge.


Autocomplete after the eol command

Hello,
This is a draft to resolve #125.
As the project is using argparse, I thought it was a good idea to use argcomplete.
This implementation is very simple but it seems to do the trick.
# register eol with the shell's completion framework by running register-python-argcomplete:
eval "$(register-python-argcomplete eol)"
# use it
eol ne
nextcloud  nextjs  netbsd  nexus  neo4j  neos  --

Cheers 🍰

Thanks for this!

# register eol with the shell's completion framework by running register-python-argcomplete:
eval "$(register-python-argcomplete my-python-app)"
# use it
eol ne
nextcloud  nextjs  netbsd  nexus  neo4j  neos  --

Is my-python-app correct here?

Hello

Is my-python-app correct here?
Sorry no, it should be replaced by eol. Fixed in the PR description.

Thanks, so does the eval need to be run just once, or once per new shell or something?

@hugovk the use of eval is for one time activation (for the current shell), there is several options that are nicely described in the Pytest documentation for bash completion.
I pushed a commit to support global completion.

The eval works for me, but
I've run activate-global-python-argcomplete (on macOS with iterm2):
❯ activate-global-python-argcomplete
Defaulting to system-wide installation.
Installing /Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/site-packages/argcomplete/bash_completion.d/_python-argcomplete to /opt/homebrew/share/zsh/site-functions/_python-argcomplete...
Installed.
Installing /Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/site-packages/argcomplete/bash_completion.d/_python-argcomplete to /opt/homebrew/etc/bash_completion.d/python-argcomplete...
Installed.
Please restart your shell or source the installed file to activate it.

And opened a new shell, but it's not completing:
❯ eol ne

Do you know why?

Yes:
❯ head --lines 2 src/norwegianblue/cli.py
#!/usr/bin/env python3
# PYTHON_ARGCOMPLETE_OK

❯ pip install -e . --quiet

❯ eol ne<tab>

New terminal tab:
❯ eol ne<tab>

Sorry for that.
The script python-argcomplete is located on my side at

/usr/local/share/zsh/site-functions/_python-argcomplete for zsh
/usr/local/etc/bash_completion.d/python-argcomplete for bash

Seems that on your side it's installed at the following locations.

/opt/homebrew/share/zsh/site-functions/_python-argcomplete for zsh
/opt/homebrew/etc/bash_completion.d/python-argcomplete for bash

Could you please try to source the one corresponding to your shell to check if it exists and if it solves the problem?
source /opt/homebrew/share/zsh/site-functions/_python-argcomplete

Sorry for that. The script python-argcomplete is located on my side at:

/usr/local/share/zsh/site-functions/_python-argcomplete for zsh
/usr/local/etc/bash_completion.d/python-argcomplete for bash

Seems that on your side it's installed at the following locations:

/opt/homebrew/share/zsh/site-functions/_python-argcomplete for zsh
/opt/homebrew/etc/bash_completion.d/python-argcomplete for bash

That's right.

Could you please try to source the one corresponding to your shell to check if it exists and if it solves the problem?
source /opt/homebrew/share/zsh/site-functions/_python-argcomplete

Yes, that works.

I don't know why it is not sourced automatically by your shell 🤔?

I've no idea...
python3.13 is the default interpreter on this machine, I also have:
❯ locate _python-argcomplete
/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/argcomplete/bash_completion.d/_python-argcomplete
/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/argcomplete/bash_completion.d/_python-argcomplete
/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/site-packages/argcomplete/bash_completion.d/_python-argcomplete
/opt/homebrew/Cellar/pipx/1.6.0/libexec/lib/python3.12/site-packages/argcomplete/bash_completion.d/_python-argcomplete
/opt/homebrew/share/zsh/site-functions/_python-argcomplete

activate-global-python-argcomplete on my path is for 3.13:
❯ which activate-global-python-argcomplete
/Library/Frameworks/Python.framework/Versions/3.13/bin/activate-global-python-argcomplete

But when I run it, it installs from 3.13 to a Homebrew path:
❯ activate-global-python-argcomplete
Defaulting to system-wide installation.
Installing /Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/site-packages/argcomplete/bash_completion.d/_python-argcomplete to /opt/homebrew/share/zsh/site-functions/_python-argcomplete...
Installed.
Installing /Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/site-packages/argcomplete/bash_completion.d/_python-argcomplete to /opt/homebrew/etc/bash_completion.d/python-argcomplete...
Installed.
Please restart your shell or source the installed file to activate it.

I don't use Homebrew Python for anything other than letting Homebrew manage it for its own use, so it feels like a bug that the 3.13 activate-global-python-argcomplete installs completion for another interpreter, let alone the Homebrew one.
Anyway, it also works if I source that 3.13 one in a new tab. What do you suggest? Should I add manual sourcing of that to my ~/.zshrc or something?

zsh
From this helper.

Completion functions for commands are stored in files with names beginning with an underscore _, and these files should be placed in a directory listed in the $fpath variable. You can add a directory to $fpath by adding a line like this to your ~/.zshrc file:

So you can check if your fpath variable contains the location of the autocomplete script installation.
echo $fpath | grep /opt/homebrew/share/zsh/site-functions

If it's not the case you could add a line in your ~/.zshrc file.
fpath=(/opt/homebrew/share/zsh/site-functions $fpath)

bash
Based on my understanding of this answer.
A .bash_completion script doing this kind of source.
for bcfile in ~/.bash_completion.d/* ; do
  [ -f "$bcfile" ] && . $bcfile
done

So you can check if your fpath variable contains the location of the autocomplete script installation.
echo $fpath | grep /opt/homebrew/share/zsh/site-functions

Yes, it's the first (and second) entry in my $fpath.


Hot reloading only working in Template pages

Describe the Bug
Hot reloading for both JSX and JSS seems to work fine if you are editing a template page.
However, if you have - for example - building blocks outside of the 'template' context (as example: a 'utils' folder with Footer or ContentBlock) changes will not trigger a reload. This console indicates: [vite] hmr update instead of [vite] page reload.
If I'm missing something, let me know. I couldn't find samples with this structure. At least in my opinion - could be wrong - it would be nice to have some reusable generic blocks with prefilled content & styling so only the basics are in your email templates.
Workaround
Create a template so it behaves like an email template but also export other stuff that can be reused over emails.
Example:

Which package is affected (leave empty if unsure)
No response
Link to the code that reproduces this issue
/
To Reproduce
/
Expected Behavior
Everything inside the email folder is watched for reloading.
What's your node version? (if relevant)
No response

Oops, this is with JSX-EMAIL, not React-email. apologies!


Block Reward Restructure - Reducing Block Reward due to high Inflation Rate

Introduction
At the start of Oxen's inception I was tasked with helping develop the token economics of the Service Node layer, this resulted in multiple economic papers and a great monetary policy to create sybil resistance network. I'd like to revisit the tokeneconomics of Oxen now that we are years into it's life and aim to create a more sound economic model into the future.
The current Oxen Block Reward is 18.333 per block which creates a yearly inflation rate of ~9%, this in turn means each Oxen will lose ~9% of it's purchasing power over the next year. The inflation rate in my opinion is the only metric that is letting the Oxen network down in regards to token economics, which is where most of my focus will be for this proposal.
It is in our best interest for the network to reduce the inflation rate as much as possible as this in turn:

reduces the purchasing power lost per Oxen per year
reduces the sell side pressure on the market

We need to keep in mind that the inflation rate directly relates to the rewards service node operators receive so we need the inflation rate high enough to incentivise a service node to operate.
I understand that a Service Node operator may initially think "Reducing the rewards!? This isn't in my best interest" however they may not realise that their rewards are losing purchasing power by the inflation rate on the token and thus they are already experiencing this reduction.
AIM
Ideally we should be aiming for the lowest inflation rate possible while maintaining a high enough ROI to incentivise SN operators. My target's for this proposal will be the following:

Goal
Target
Reasoning

Inflation Rate
As low as possible
Reduce selling pressure and loss of purchasing power

ROI(in Oxen)
Greater than 8%
Incentivise Service Nodes to operate

Having the ROI in Oxen greater than 8% will continue to keep an incentive for Service Node's to come onto the network.
Reducing the inflation rate as low as possible will increase the dollar value of each Oxen through time.
Assumptions
Cryptocurrency token economics is complicated especially with so many moving parts so reducing the complexity is key to gathering any quick insights.
A lot of the complexity comes from variables that are dynamic and that change based on market conditions such as the dollar value of each Oxen and the number of Service Nodes active at any given point.
Lock up Ratio
The lock up ratio measures how much of the supply is locked into Service Nodes. The higher the lock up ratio the more sybil resistant the network is.
A lock up ratio of 50% is ideal as a 100% lock up means no Oxen is available to be used and a Lock up ratio of 0% means no Service Node operators.
To reduce the complexity of the problem an assumed Lock up ratio of 50% is set for this study.
Demand
We will assume the demand for Oxen is static and that the demand for Oxen matches the sell side pressure therefore assuming that the price of Oxen does not change.
This assumption reduces the complexity drastically however in reality demand fluctuates. Reducing the block reward allows for a lower demand to maintain price.
Dollar value of Oxen
To reduce the complexity of the problem we will assume the price of Oxen to not change and only measure ROI in Oxen, rather than dollars.
Keep in mind that inflation rate reduces purchasing power of each Oxen and if demand does not meet emission the price of Oxen will fall. This is why one of the aims of the proposal is to decrease the inflation rate as much as possible.
Data
The following graphs depict 3 case studies where the only variable we change is the Block Reward.

Case
Block Reward

1. Current
18.33333 Oxen

2. 25% reduction in BR
13.75 Oxen

3. 50% reduction in BR
9.17 Oxen

Circulating Supply
Circulating supply was calculated by adding the block reward for 3 different case studies. This data was used to generate Fig 2 and 3.
The circulating supply data does not give us any insights into if we should make the proposed changes however it is the basis to work out the Inflation Rates.

Figure 1. Circulating Supply
Yearly inflation Rate
In this chart the inflation rate seems way to high and will continue to be high for several years into the future. In the current schedule our inflation rate is 9% and will only drop below 5% in the year 2030.
We desire an inflation rate that is the lowest possible however we need to look into what reducing the emission does to the ROI and make a decision based on the two graphs.

Figure 2. Inflation Rate
Return on Investment
The return on investment is calculated from the 15,000 Oxen staked, the block reward and the number of service nodes on the network at each given point. One major assumption for this graph is that SN count increases through time and the network maintains a 50% lockup.
As you can see the Inflation rate chart(Fig 2) and the ROI chart (Fig 3) are near identical, this is because as you reduce the emission, the inflation is reduced but the ROI is also reduced.

Figure 3. Return on Investment measured in Oxen where the lock up ratio stays at 50%
Proposal
After reviewing both the ROI and Inflation Rate charts in my opinion a block reward reduction of 25% to create a static BR of 13.75 Oxen will create better economic conditions for the longevity of the project.
Other considerations
Reducing block reward may cause initial decommissions
Reducing the block reward may result in an initial reduction in Service Node operators as each operator has a different threshold of ROI that they prefer.
This is counteracted by two scenarios.

As Service Nodes leave the network the ROI is increased per service node as they have a larger share of the overall network.
The reduction in rewards also results in a reduction of inflation rate, thus increasing the potential for each Oxen they hold to go up in value.

Operating expenses
This study does not take into consideration the operating expenses of running a Service Node.
I chose to remove this from the study as it costs approximately $10 per month to run a node. The rewards in dollar value greatly outweighs this cost and I found this portion of the study to be negligible. The only time this would become to much of an issue is if the price of Oxen drops drastically however by reducing the emission we assume that Oxen has better conditions to go up in value rather than down.

+1 For this

I am completely against further reducing the block reward. #Sub 12% ROI is not attractive in the context of crypto and I would not consider operating my service nodes at that return.
Instead of punching in some code and reducing the block reward as a band-aid measure, more effort should be made in offsetting the inflation with the proposed burning programmes.
Saying the current inflation rate is "the only metric that is letting the Oxen network down in regards to token economics" is wildly naive. There are other highly successful project with much higher inflation rates - most notable THORChain.

In my view emissions have no relationship to Service Node ROI, Service Node ROI is determined by the market and whether new people want to start nodes at the current rate of return. Keep in mind the Service Node count has been continually increasing at about the same rate since we started the network. People keep starting new nodes so clearly we haven't reached a point where Service Node ROI has reached equilibrium.
Emission's do have a direct relationship with the size of the Service Node network, the less reward the less overall Service Nodes are required before there are too many nodes sharing the same rewards and ROI compresses to equilibrium. So the question in my view is, how many Service Nodes do we need? and what level of rewards is required to reach that number of nodes before equilibrium is reached.
I don't really have answers to those questions because that depends on network usage (Lokinet/Session usage) and what other market participants consider a good enough ROI to start new Service Nodes.

this in turn means each Oxen will lose ~9% of it's purchasing power over the next year

Respectfully disagree with this.  Purchasing power is determined by price inflation rather than money supply inflation and the two are only loosely linked.
Essentially this makes an assumption that Oxen's market cap will remain fixed over time, but that in itself is not merely an unreasonable assumption, but in fact a self-contradictory one: if everyone believed that that was true then Oxen would have no speculative demand, and that in turn would tank the price, thus changing the market cap and violating the assumption.
Case in point: from 1y ago to today, price went from $0.32 to $1.16, that's price deflation of 72%.  Or from 2y ago to 1y ago: deflation of 58%.
The point is: the coin emission rate has a very small impact on the price (and the price is purchasing power), which means tweaking it is only going to have a very small impact on anything.

Keep in mind the Service Node count has been continually increasing at about the same rate since we started the network.

That was true up until about 2 months ago, but then the pattern broke: SN counts went substantially above trend just after the Chainflip airdrop announcement because that airdrop effective increased the ROI from staking service nodes.
In terms of ROI, there is already a huge reduction in SN ROI looming on the horizon on June 30th.

I understand that a Service Node operator may initially think "Reducing the rewards!? This isn't in my best interest" however they may not realise that their rewards are losing purchasing power by the inflation rate on the token and thus they are already experiencing this reduction.

This is a bit misleading as written: SN stakers would still be unequivocally negatively impacted by a reduction in SN rewards; the conjectured reduction in price inflation offsets this a bit, but not entirely.  For example: if SN stakers are earning 9% (nominally) of the total supply and have 50% stake lockup, this means they are earning 18% on their investment.  If price inflation just happens to equal coin emission inflation then that means in real terms (i.e. after adjusting for price inflation) they are earning 9%: 18% nominal minus 9% price inflation.
If you reduce emission to 6% of circulating supply, then 50% staked earns 12% ROI nominally, and that works out to 6% real -- and so in real terms, you reduced the SN return by one-third.
Effectively SN stakers earn all of the new coins, but only incur 50% of the inflation cost of new emissions (since any resulting inflation is borne by all OXEN holders, of which SN stakers are only 50%).  And because of that, any cut to SN rewards will hurt SN stakers even under an assumption that emission inflation = price inflation.
Or another way to look at it: any SN reward is a transfer in value from non-staking holders to staking holders, and any reduction in SN reward is tilting things back the other way.  There's no correct tradeoff here, but we need to be clear that any change in the SN reward emission is about making one party better off at the expense of the other.

I'll also add: I think we should be extremely hesitant about changing the emissions schedule, in general.  Sometimes changes are justified, but I think our bar for justifying such a change should be high, and I'm not seeing a strong enough justification here.


Package esdb_topo.py

This Python script, needed for automatic topology updating from the published ESDB topology data, should be packaged.
It's not clear at this point whether it should go into the oscars-backend package or exist separately (leaning toward separate).  It depends on having the neg-tools/esnet-python stuff installed for parsing the today topology from ESDB, although as I'm writing this right now, I'm not sure if there's any OS native packaging for those files (so computing dependencies might be hard).

At this point, we have esdb_topo.py in the oscars-backend RPM.  Depending on the outcome of the esnet-python packaging issue, the current state might be sufficient.

We're going to use a manually generated RPM for the esnet-python packaging issue.  What we have now should work fine.
We need to test this with a build, which will hopefully be happening soon.

It got packaged correctly.  Closing.


VSL-106: Updated versions so overflow testing works with emulator

Updated go to 1.18.0
Updated overflow, cadence, flow-go-sdk and other dependencies
Updated transactions and tests as a result from updating libraries

LGTM
Do the updated libraries require arguments being passed explicitly? For example from RemoveSigner(signerToBeRemoved) to RemoveSigner(_signer:signerToBeRemoved)

LGTM Do the updated libraries require arguments being passed explicitly? For example from RemoveSigner(signerToBeRemoved) to RemoveSigner(_signer:signerToBeRemoved)

Yeah, the cadence library that was referenced was asking to add these arguments to be passed. Note: I had to downgrade it a bit in order to work with the overflow library, but we might need some updates of dependencies again soon so when we return to the latest version of cadence these arguments can be removed


Not opening

After doing everything and stuff, I was able to build the DLL and UI just fine, however opening the UI, nothing popped up, does anyone have this issue, if so were you able to fix it and if so, how?

You have built the project in wrong configuration and it will crash. Do not build the project yourself unless you know what you are doing

what


+Infinity and n/a in table.

Good morning.
Here's a new issue. The table shows +Infinity for coins that have been deposited, or are not possible to withdraw (like SC).

Deposits and withdrawals are now also taken into account. Get version 0.0.31.  I'll close up this one for now.

@codesonzh Works as intended. Thanks!