Unnecessary precision loss in compressed animation tracks

Tested versions
Reproducible in Godot v4.4.dev [bbc54692c].
System information
Windows 10.0.19045. Compiled with MSVC.
Issue description
Compressed animation tracks are losing half of their precision due to the choice of rounding in unorm conversion. The visual impact is very small in most cases, but the fix is simple so I hope it's worth considering.
In Animation::_compress_key, the various conversions to unorm are done with int32_t(float_value * 65535.0). This rounds towards zero, so an input of 0.999999 will be encoded as 65534 and decompressed to 0.999985 (difference: ~0.000014).
Changing the conversions to int32_t((float_value * 65535.0) + 0.5f) would make them round to nearest, doubling the precision. So an input of 0.999999 would be encoded as 65535 and decompressed to 1.0 (difference: ~0.000001). In case it's relevant, this is the conversion used by most graphics APIs (e.g. DirectX).
I can make a PR if desired. Note that I've also filed a separate bug that involves the same unorm code (https://github.com/godotengine/godot/issues/99794). I will roll both fixes into the same PR unless advised otherwise.
And some bonus notes:

The unorm compress/uncompress triggers an unnecessary double <-> float conversion because the scaling constant is a double literal.

Changing it to float is probably a negligible performance improvement, but seems like a safe change that can be folded into the other changes.

There's a few other cases of unorm conversions with rounding towards zero, including mesh vertex compression.

I haven't tested these yet to confirm if they have the same precision loss.
I can file these as separate issues if desired.

Steps to reproduce
I don't have a good repro as the visual difference is very subtle.
In case it's useful, https://github.com/greeble-dev/godot/commit/30a5e9afbe27a87e3a033b8053fa889765ed369d is a hacky code change I used to test a few values with the original conversion and proposed fix. If the change is applied, reimporting any compressed animation should trigger this debug output:
scene\resources\animation.cpp:4776 - Original: 1.000000 quantizes to 1.000000 (unorm 65535)
scene\resources\animation.cpp:4782 - Updated: 1.000000 quantizes to 1.000000 (unorm 65535)
scene\resources\animation.cpp:4776 - Original: 0.999999 quantizes to 0.999985 (unorm 65534)
scene\resources\animation.cpp:4782 - Updated: 0.999999 quantizes to 1.000000 (unorm 65535)
scene\resources\animation.cpp:4776 - Original: 0.000014 quantizes to 0.000000 (unorm 0)
scene\resources\animation.cpp:4782 - Updated: 0.000014 quantizes to 0.000015 (unorm 1)

Minimal reproduction project (MRP)
N/A

Are you able make a code contribution?

@fire, yes, I can make a PR.


Add Width height setter

Adding width and height @setter to TextEntry

I think is good to go @benmoran56


playing with sockets in kernel space

Needs review

@salazar, I think we shouldn't merge PRs before we have it reviewed; you can just keep working in a separate branch, then you can rebase/merge the reviewed PR in your work branch.

@lneto, Good point. In this case I merged before your review because we are working on a separate directory (staging) and it does not change a lot merging it or not.
Thanks for the tips :+1:


watermarks don't always appear

I have permanent water marks set for my mpeg-ts channels however they only seem to appear half the time when switching to the channel.
they seem to reappear when the next media item is played

Please paste the ffmpeg arguments from the log when no watermark appears and when the watermark is visible.

ffmpeg arguments -nostdin -threads 0 -hide_banner -loglevel error -nostats -fflags +genpts+discardcorrupt+igndts -re -ss 00:39:51.4412913 -i /home/liam/tvshows/TV/The King of Queens/Season 03/S3.E24.E25. Pregnant Pause.mp4 -i /root/.local/share/ersatztv/cache/artwork/watermarks/D5/D5ECA4C9E33B49FF772249B5915E860EBE389AAB -video_track_timescale 90000 -filter_complex [0:1]loudnorm=I=-16:TP=-1.5:LRA=11,apad=whole_dur=2692401ms[a];[0:0]scale=950:720:flags=fast_bilinear,setsar=1,pad=1280:720:(ow-iw)/2:(oh-ih)/2[vt];[1:v]scale=192:-1[wmp];[vt][wmp]overlay=x=W-w-13:y=H-h-7[v] -map [v] -map [a] -c:v libx264 -flags cgop -sc_threshold<PHONE_NUMBER> -b:v 2000k -maxrate:v 2000k -bufsize:v 4000k -b:a 192k -maxrate:a 192k -bufsize:a 384k -ar 48k -c:a ac3 -movflags +faststart -muxdelay 0 -muxpreload 0 -map_metadata -1 -metadata:s:a:0 language=und -metadata service_provider="ErsatzTV" -metadata service_name="Comedy" -f mpegts -t 00:05:00.9597087 pipe:1

ffmpeg arguments -nostdin -threads 0 -hide_banner -loglevel error -nostats -fflags +genpts+discardcorrupt+igndts -re -ss 00:29:31.0692440 -i /home/liam/tvshows/TV/Game of Thrones/Season 04/S4.E9. The Watchers on the Wall.mp4 -i /root/.local/share/ersatztv/cache/artwork/watermarks/2D/2D6466FCE4FA483E7D9F62B4BC9A5CD277A4CCDD -video_track_timescale 90000 -filter_complex [0:1]loudnorm=I=-16:TP=-1.5:LRA=11,apad=whole_dur=3034268ms[a] -map 0:0 -map [a] -c:v libx264 -flags cgop -sc_threshold<PHONE_NUMBER> -b:v 2000k -maxrate:v 2000k -bufsize:v 4000k -b:a 192k -maxrate:a 192k -bufsize:a 384k -ac 2 -ar 48k -c:a ac3 -movflags +faststart -muxdelay 0 -muxpreload 0 -map_metadata -1 -metadata:s:a:0 language=und -metadata service_provider="ErsatzTV" -metadata service_name="Other" -f mpegts -t 00:21:03.1987560 pipe:1

the first one shows the watermark and the second doesn't despite it being in both FFmpeg arguments

Can you confirm that video normalization is enabled on the Other channel where the watermark doesn't display?

Actually the arguments indicate video normalization is enabled - no need to confirm.
This is a bug and I'll get it fixed for the next release.


Simplify conditional removing 'else' statement

This Pull Request has a very small and simple change. It simplifies a if statement
by removing the else block once it has no logical effect on how code will execute.
It is a very small contribution. Thank you for this helpful project.

thanks @pantuza
please rebase

@pantuza bump =)

Hey guys, I've resolved the merge conflict and rebased the changes. Hope that is what you were expecting.


Port WriteTracker and DiskWriteTracker

Take next step in #9
Need to implement this:
https://github.com/diffplug/selfie-python-wip/blob/main/jvm/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/WriteTracker.kt#L57-L97

Finished by #42


lsof on CoreOS does not support -M

While using Mayday, I noticed the lsof output was empty. I tried the command listed in mayday_commands for myself, and it looks like -M is not supported for the lsof on CoreOS machines.
Output from lsof -b -M -n -l on the CoreOS machine, which is what mayday runs:
core@ip-10-0-14-207 /tmp/201707051651.319096864 $ sudo lsof -b -M -n -l
lsof: illegal option character: M

Output from lsof -h on a CoreOS machine that's part of my kubernetes cluster, where -M is not listed:
core@ip-10-0-14-207 /tmp/201707051651.319096864/mayday_commands $ lsof -h
lsof 4.89
 latest revision: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/
 latest FAQ: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/FAQ
 latest man page: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_man
 usage: [-?abhKlnNoOPRtUvVX] [+|-c c] [+|-d s] [+D D] [+|-E] [+|-e s] [+|-f[gG]]
 [-F [f]] [-g [s]] [-i [i]] [+|-L [l]] [+m [m]] [-o [o]] [-p s]
 [+|-r [t]] [-s [p:s]] [-S [t]] [-T [t]] [-u s] [+|-w] [-x [fl]] [--] [names]
Defaults in parentheses; comma-separated set (s) items; dash-separated ranges.
  -?|-h list help          -a AND selections (OR)     -b avoid kernel blocks
  -c c  cmd c ^c /c/[bix]  +c w  COMMAND width (9)    +d s  dir s files
  -d s  select by FD set   +D D  dir D tree *SLOW?*   +|-e s  exempt s *RISKY*
  -i select IPv[46] files  -K list tasKs (threads)    -l list UID numbers
  -n no host names         -N select NFS files        -o list file offset
  -O no overhead *RISKY*   -P no port names           -R list paRent PID
  -s list file size        -t terse listing           -T disable TCP/TPI info
  -U select Unix socket    -v list version info       -V verbose search
  +|-w  Warnings (+)       -X skip TCP&UDP* files     -- end option scan
  -E display endpoint info              +E display endpoint info and files
  +f|-f  +filesystem or -file names     +|-f[gG] flaGs
  -F [f] select fields; -F? for help
  +|-L [l] list (+) suppress (-) link counts < l (0 = all; default = 0)
                                        +m [m] use|create mount supplement
                                        -o o   o 0t offset digits (8)
  -p s   exclude(^)|select PIDs         -S [t] t second stat timeout (15)
  -T qs TCP/TPI Q,St (s) info
  -g [s] exclude(^)|select and print process group IDs
  -i i   select by IPv[46] address: [46][proto][@host|addr][:svc_list|port_list]
  +|-r [t[m<fmt>]] repeat every t seconds (15);  + until no files, - forever.
       An optional suffix to t is m<fmt>; m must separate t from <fmt> and
      <fmt> is an strftime(3) format for the marker line.
  -s p:s  exclude(^)|select protocol (p = TCP|UDP) states by name(s).
  -u s   exclude(^)|select login|UID set s
  -x [fl] cross over +d|+D File systems or symbolic Links
  names  select named files or files on named file systems
Anyone can list all files; /dev warnings disabled; kernel ID check disabled.

And here is the output from my local laptop running Fedora 25, which does list -M:
$ lsof -h
lsof 4.89
 latest revision: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/
 latest FAQ: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/FAQ
 latest man page: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_man
 usage: [-?abhKlnNoOPRtUvVX] [+|-c c] [+|-d s] [+D D] [+|-E] [+|-e s] [+|-f[gG]]
 [-F [f]] [-g [s]] [-i [i]] [+|-L [l]] [+m [m]] [+|-M] [-o [o]] [-p s]
 [+|-r [t]] [-s [p:s]] [-S [t]] [-T [t]] [-u s] [+|-w] [-x [fl]] [-Z [Z]] [--] [names]
Defaults in parentheses; comma-separated set (s) items; dash-separated ranges.
  -?|-h list help          -a AND selections (OR)     -b avoid kernel blocks
  -c c  cmd c ^c /c/[bix]  +c w  COMMAND width (9)    +d s  dir s files
  -d s  select by FD set   +D D  dir D tree *SLOW?*   +|-e s  exempt s *RISKY*
  -i select IPv[46] files  -K list tasKs (threads)    -l list UID numbers
  -n no host names         -N select NFS files        -o list file offset
  -O no overhead *RISKY*   -P no port names           -R list paRent PID
  -s list file size        -t terse listing           -T disable TCP/TPI info
  -U select Unix socket    -v list version info       -V verbose search
  +|-w  Warnings (+)       -X skip TCP&UDP* files     -Z Z  context [Z]
  -- end option scan
  -E display endpoint info              +E display endpoint info and files
  +f|-f  +filesystem or -file names     +|-f[gG] flaGs
  -F [f] select fields; -F? for help
  +|-L [l] list (+) suppress (-) link counts < l (0 = all; default = 0)
                                        +m [m] use|create mount supplement
  +|-M   portMap registration (-)       -o o   o 0t offset digits (8)
  -p s   exclude(^)|select PIDs         -S [t] t second stat timeout (15)
  -T qs TCP/TPI Q,St (s) info
  -g [s] exclude(^)|select and print process group IDs
  -i i   select by IPv[46] address: [46][proto][@host|addr][:svc_list|port_list]
  +|-r [t[m<fmt>]] repeat every t seconds (15);  + until no files, - forever.
       An optional suffix to t is m<fmt>; m must separate t from <fmt> and
      <fmt> is an strftime(3) format for the marker line.
  -s p:s  exclude(^)|select protocol (p = TCP|UDP) states by name(s).
  -u s   exclude(^)|select login|UID set s
  -x [fl] cross over +d|+D File systems or symbolic Links
  names  select named files or files on named file systems
Anyone can list all files; /dev warnings disabled; kernel ID check disabled.

What version of Container Linux are you using?  lsof -M should be enabled starting in 1451.2.0.

@bgilbert Ah there's the issue.
cat /etc/*-release
DISTRIB_ID="Container Linux by CoreOS"
DISTRIB_RELEASE=1409.5.0

This is the version that was installed by tectonic.

That fix should be in the next major Container Linux stable release.
lsof defaults to -M, so in principle that flag could be dropped from Mayday, but it seems safer to leave it in place.

@bgilbert How long is the dev cycle to where Alpha will move to stable? I'm not sure how much mayday is used, but it leaves the file completely blank which is unexpected behavior.


Trying to run the code examples from Book and Rust-by-example frequently result in lots of errors

See the screenshot below (sorry for some Dutch language, I will clarify things if desirable).
This is my experience using Firefox (on Linux).
I now decided to open de dev tools console to see what errors it's reporting, and it's not good.
I know these books are clearly using the Playground via some API, that's why I am reporting it here and not for each of those books.
Also note that the first time I noticed those timeout problems was close to the beginning this year, when I was reading the Book for the first time. So my impression is that the problems are not new at all.
But what I now noticed is that in many cases the Ctrl+Enter also fails to execute completely (nothing happens), while pressing the run button with the mouse still works.

Duplicate of #955


added dp algorithm knapsack in typescript

Added the knapsack algorithm. All contribution guidelines followed.

Add comments in the code and use proper test names.

Added comments and proper test names.

@appgurueu applied the suggested changes.

@raklaptudirm pr is not progressing, anything that needs to be changed or modified?

I seem to have missed it's notification.


Properly handle both v1 and v2 span-ids.

Summary:
The SPAN_ID is a decimal number in v1 of the trace-context API,
but a (16-digit) hexadecimal number in v2:
https://cloud.google.com/python/docs/reference/cloudtrace/1.2.0/google.cloud.trace_v1.types.TraceSpan
https://cloud.google.com/python/docs/reference/cloudtrace/1.2.0/google.cloud.trace_v2.types.Span
Stackdriver uses only v2 these days:
https://issuetracker.google.com/issues/338634230?pli=1
Unfortunately, the X-Cloud-Trace-Context may still be using the
v1 API.  We try to detect that situation and convert it to a v2
compatible trace-id by formatting the number in hex.
We cannot perfectly detect whether we're v1 or v2, because
there are some decimal numbers that look like 16-digit hex
numbers.  But not very many; we'd expect the logic below to
make a mistake about 1 in every 2,000 log entries.  In such
cases, we will use the wrong span-id, making it harder to
associate log-messages with the requestlog that spawned it.
Issue: https://console.cloud.google.com/support/cases/detail/v2/53379415?project=khan-academy
Test plan:
Fingers crossed, it can't be any worse than what we have now!

Should we send a PR to https://github.com/andyfusniak/stackdriver-gae-logrus-plugin?

Already done: https://github.com/andyfusniak/stackdriver-gae-logrus-plugin/pull/2

And is google taking any action for them to fix this? Like should we have a TODO somewhere?

I'm still following up with them.  Last I heard, at least some people believe the current behavior is a bug -- perhaps specific to us -- and they're looking into it.  I'm going to wait to hear back from them before landing this.

@csilvers im happy to land this and we can leave a TODO to clean up once the dust has settled.  If anything, it would be a short term fix.  Up to you tho.  Sadly we dont have a sync with google this week.


Dependency Tree View for Api Scopes

Introduced Dependency Tree View for Api Scopes regarding Api Resources, Clients, Personal Access Tokens
See #38

Hurray 🎉  it made it in the master! 👏


GraphQL Middleware support, API update, exaxmple

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


upload dataset with float weights on edges

The dataset runs with no bugs on chem_tensorflow_gcn.py, but with large error.
The code to generate the dataset is here: https://github.com/B-C-WANG/MoleculeCoordinatesToGraph, but data I used is from VASP (a DFT software).
More details in CHO_on_Pt_dataset.md.
I hope it helps to improve your algorithm.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: B-C-WANG sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Panic with binary release "no such file or directory"

Using binary release https://github.com/aiven/terraform-provider-aiven/releases/download/v1.0.1/terraform-provider-aiven-linux_amd64
I get this error:
panic: Failed to read integration_endpoints_user_config_schema.json: stat /home/rikonen/go/src/github.com/aiven/terraform-provider-aiven/templates/integration_endpoints_user_config_schema.json: no such file or directory
2018-10-08T12:03:10.265Z [DEBUG] plugin.terraform-provider-aiven:
2018-10-08T12:03:10.265Z [DEBUG] plugin.terraform-provider-aiven: goroutine 1 [running]:
2018-10-08T12:03:10.265Z [DEBUG] plugin.terraform-provider-aiven: main.readUserConfigJSONSchema(0xab5825, 0x2d, 0xc420075f78)
2018-10-08T12:03:10.265Z [DEBUG] plugin.terraform-provider-aiven: 	/home/rikonen/go/src/github.com/aiven/terraform-provider-aiven/user_config.go:17 +0x3db
2018-10-08T12:03:10.266Z [DEBUG] plugin: plugin process exited: path=/root/.terraform.d/plugins/terraform-provider-aiven
2018/10/08 12:03:10 [ERROR] root: eval: *terraform.EvalInitProvider, err: plugin exited before we could connect
2018/10/08 12:03:10 [ERROR] root: eval: *terraform.EvalSequence, err: plugin exited before we could connect

The binary tries to read config files from directory /home/rikonen/go/src/github.com/aiven/terraform-provider-aiven/

The application tried to load packr managed files before the embedded versions were made available causing the app to fail to start when source code was not available. The binaries were patched and should work now. Thanks for reporting this.


Code in precip-freq.ipynb not executing during build

ERROR: Execution Failed: /home/runner/work/cmip6-cookbook/cmip6-cookbook/notebooks/example-workflows/precip-freq.ipynb

This might be because it takes too long; there are four plots and one took about 15 minutes. The notebook runs fine on the binder hub.

Temporary solution: I limited the code to only use one model.

This can be reverted now that we can run the notebooks elsewhere.


Change input/output handling and default format

After refactoring (#32) and checking that everything is working as expected, I would like to have a consistent way of managing input/output formats before releasing version 1. This requires:
User side:

[x] Output consistent format: BAM with information in the tags will be the best approach as a default output to store raw reads. I have to decide if every tool will allow output a FASTQ file or just one tool will convert BAM to FASTQ using the tags. Edited: Only BAM files will be output, and one tool will standardize the FASTQ
[x] Input raw reads: now only single FASTQ/BAM files, paired FASTQ files (1 file per pair) and paired BAM files (one after the other in name order) are allowed. We should allow other kind of inputs, as interleaved FASTQ files.

Developer side:

[x] Readers returning only one type of read: even if the input is a FASTQ file, the readers should return a SAMRecord and/or GATKRead. Thus, this requires implement a FASTQ reader wrapper which transform the reads.
[x] Methods should be apply to only one read source (SAMRecord or GATKRead).
[x] Common interface for output reads: only one generic writer type should be implemented. Implementations of tools will decide how the read will be transform.
[x] Common walker for raw reads (single and paired end): the GATK framework is awesome to create walker over the data. The best way is implement a walker for reads which takes one/two arguments, determine the type of source (paired vs. single) and iterates through one read or two applying a function (apply(single) or apply(first, second)). That will be much more easier than the current way of managing the tools.

Probably use Path instead of File to allow other filesystems. It will make easier to implement tools which works with HDFS files.

Iterator over a FASTQ file using htsjdk and returning GATKRead implemented in 593929d2bade5ff38d5ad3ccdd16317b3ba9ec2b

Input raw reads as FASTQ/BAM files, both as interleaved and split files, implemented in a100f7e575b5d5b32079f8bc2c63bc04c08a950c

The common interface for writting the reads is going to be the GATKReadWriter from GATK4. Split by different sources will be done with #64.

Walker implementation in ab3e0b4b53b4cdb3cf081d00b5d2530f9332dec2

The output argument collection (7876f3e7197289445624d92544703a6019e5c1c6) only allows BAM/SAM/CRAM files. If a different output is required it will be tool-specific.

Apllication of trimming methods to GATKRead already in 5ca9909b68404bde012345e8735e71631027ed3b

BarcodeDetector already includes a GATKRead method.

Closing in favor of #92/#93 for remove all developer framework for FastqRecord/SAMRecord and #74/#94 for the user side.


GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL

Using OpenSSL causes various issues like https://github.com/apache/arrow/pull/33808#issuecomment-1408247269 and https://github.com/apache/arrow/issues/34111. We should try to use aws-lc for libcrypto and libssl. We need to hide them inside s2n-tls to avoid name conflicts with OpenSSL used by other libraries.

Closes: #34157

Closed in favor of https://github.com/apache/arrow/pull/34159


Account management journeys

Account management all on one screen in the manage registers app. The design indicates one thing per page.
URL:
https://managing-registers-staging.cloudapps.digital/users/19
Steps to recreate:

Log in
Click the user name in the header

Expected result:

Actual result:

not required for this release - next iteration

Will reopen this one when we get more clarity on accounts.


Font size: add a small gap

When the label is long, make sure there is a small gap before and after the label so that it's not right up against the node edge.

Details see the commit (https://github.com/SunnyXu/SBMLDiagrams/commit/b001b537b2f4e4eb64ccd4b2594a8753e9532748)


[MRG] ENH: Update laplacian function introducing the new copy option

introduce the new copy option, to save 1/2 memory with copy=False
Reference issue
Partially closes #10826 and https://github.com/scikit-learn/scikit-learn/issues/8834
What does this implement/fix?
introduce the new copy option

Thanks @lobpcg. Good start, I think we should test the parameter. And looking at the discussion in the issue, it would be good to document the copying mechanism in more details.

If you could suggest a unit test, I would appreciate it. I'll update the documentation.

If you could suggest a unit test, I would appreciate it. I'll update the documentation.

I am on the road with only a phone for another week. I would do something simple like passing an array and check that the original array is either modified or not.

If you could suggest a unit test, I would appreciate it. I'll update the documentation.

I am on the road with only a phone for another week. I would do something simple like passing a graph and check that the original graph is either modified or not.

Yes, I thought about it and it's easy to code, but this does not explicitly checks the memory usage.

Could anyone please advice? I do not know how to properly format to pass values in
@pytest.mark.parametrize("dtype", [np.float32, np.float64])
@pytest.mark.parametrize("inplace", ["FASLE", "TRUE"])
@pytest.mark.parametrize("normed", ["FASLE", "TRUE"])
@pytest.mark.parametrize("use_out_degree", ["FASLE", "TRUE"])

so getting errors:
scipy/sparse/csgraph/tests/test_graph_laplacian.py:107:18: F821 undefined name 'dtype'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:109:12: F821 undefined name 'normed'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:109:23: F821 undefined name 'use_out_degree'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:116:8: F821 undefined name 'normed'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:116:19: F821 undefined name 'use_out_degree'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:123:12: F821 undefined name 'normed'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:123:27: F821 undefined name 'use_out_degree'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:130:8: F821 undefined name 'normed'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:130:23: F821 undefined name 'use_out_degree'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:137:18: F821 undefined name 'dtype'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:138:18: F821 undefined name 'dtype'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:140:29: F821 undefined name 'normed'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:141:37: F821 undefined name 'use_out_degree'
scipy/sparse/csgraph/tests/test_graph_laplacian.py:142:30: F821 undefined name 'inplace'

The unit tests unfortunately require some deep and time consuming reorganization, replacing loops with @pytest.mark.parametrize, since testing inplace cannot evidently be run in a loop...

There are so many clearly unrelated to this PR errors that I am unsure where to find or to check the lack of the relevant errors...

There are some issues with other dependencies right now which should be fixed very soon.

The dense part seems working - passing all tests.
The space part inline=True is not actually inline so far. My current description of the conversion logic is inaccurate. It appears from the code that all sparse formats are converted to coo, except for dia.  The code logic is strange, so I am unsure if this is intentional or a bug.

I have renamed inplace to copy to simplify the logic and be consistent with other functions..

There is one test for dense matrices where copy=False has no effect, unsure why:
________________________ test_symmetric_graph_laplacian ________________________
scipy/sparse/csgraph/tests/test_graph_laplacian.py:79: in test_symmetric_graph_laplacian
    _check_symmetric_graph_laplacian(mat, normed, copy)
        copy       = False
        mat        = 'np.arange(10) * np.arange(10)[:, np.newaxis]'
        normed     = True
        symmetric_mats = ('np.arange(10) * np.arange(10)[:, np.newaxis]', 'np.ones((7, 7))', 'np.eye(19)', 'sparse.diags([1, 1], [-1, 1], shape... 'sparse.diags([1, 1], [-1, 1], shape=(4, 4)).toarray()', 'sparse.diags([1, 1], [-1, 1], shape=(4, 4)).todense()', ...)
scipy/sparse/csgraph/tests/test_graph_laplacian.py:62: in _check_symmetric_graph_laplacian
    assert_array_almost_equal(laplacian, mat)
E   AssertionError:
E   Arrays are not almost equal to 6 decimals
E
E   Mismatched elements: 80 / 100 (80%)
E   Max absolute difference: 80.
E   Max relative difference: 1.0162564
E    x: array([[ 0.      , -0.      , -0.      , -0.      , -0.      , -0.      ,
E           -0.      , -0.      , -0.      , -0.      ],
E          [-0.      ,  1.      , -0.032513, -0.040291, -0.047088, -0.0533  ,...
E    y: array([[ 0,  0,  0,  0,  0,  0,  0,  0,  0,  0],
E          [ 0,  1,  2,  3,  4,  5,  6,  7,  8,  9],
E          [ 0,  2,  4,  6,  8, 10, 12, 14, 16, 18],...
        copy       = False
        explicit_laplacian = array([[ 0.        , -0.        , -0.        , -0.        , -0.        ,
        -0.        , -0.        , -0.        ...7784, -0.10783277, -0.13363062, -0.15617376,
        -0.1767767 , -0.19611614, -0.21459877, -0.23249528,  1.        ]])
        laplacian  = array([[ 0.        , -0.        , -0.        , -0.        , -0.        ,
        -0.        , -0.        , -0.        ...7784, -0.10783277, -0.13363062, -0.15617376,
        -0.1767767 , -0.19611614, -0.21459877, -0.23249528,  1.        ]])
        mat        = array([[ 0,  0,  0,  0,  0,  0,  0,  0,  0,  0],
       [ 0,  1,  2,  3,  4,  5,  6,  7,  8,  9],
       [ 0,  2,  4, ...35, 42, 49, 56, 63],
       [ 0,  8, 16, 24, 32, 40, 48, 56, 64, 72],
       [ 0,  9, 18, 27, 36, 45, 54, 63, 72, 81]])
        n_nodes    = 10
        normed     = True
        sp_laplacian = <10x10 sparse matrix of type '<class 'numpy.float64'>'
	with 82 stored elements in COOrdinate format>
        sp_mat     = <10x10 sparse matrix of type '<class 'numpy.int64'>'
	with 81 stored elements in Compressed Sparse Row format>
        tested     = array([[ 0.        ,  0.        ,  0.        ,  0.        ,  0.        ,
         0.        ,  0.        ,  0.        ...7784, -0.10783277, -0.13363062, -0.15617376,
        -0.1767767 , -0.19611614, -0.21459877, -0.23249528,  1.        ]])

It appears from the code that all sparse formats are converted to coo, except for dia. The code logic is strange, so I am unsure if this is intentional or a bug.
Anyway, PR  is basically completed and ready for review/merge.

There are more issues to address with this same script, which I could try doing after this PR is merged:

https://github.com/scikit-learn/scikit-learn/issues/21274
https://github.com/scipy/scipy/issues/10827
https://github.com/scipy/scipy/issues/14490
https://github.com/scipy/scipy/issues/10006
https://github.com/scikit-learn/scikit-learn/issues/21274

LGTM, could someone please review/merge?

@tupui - thanks for another review!
Could you please resolve your conversations yourself where/after you feel that they were resolved?

ci/circleci: build_scipy appears broken at the moment. All other tests pass. LGTM


PostCSS Config Invalid Object

Hey there!
After installing this boilerplate, slice machine ran okay, but both Nuxt and Storybook failed at building because of this:
Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
ValidationError: Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
 - options has an unknown property 'order'. These properties are valid:
   object { postcssOptions?, execute?, sourceMap?, implementation? }
    at validate (/Users/***/Sites/***/node_modules/schema-utils/dist/validate.js:105:11)
    at Object.loader (/Users/***/Sites/***/node_modules/postcss-loader/dist/index.js:43:29)

I don't even know where to see, any idea?
Note: I use Nuxt in a lot of projects, also Storybook, but this never happened to me, that's why I think it could be related to this boilerplate. Thanks!

I tried again and the error changed to the same but css-loader instead of PostCSS-loader.
I added css-loader to devDependencies and the error changed, but I saw a warning when builidng Nuxt, about the<EMAIL_ADDRESS>was expected (not the current 6th version), so I added it to my package and the error has been fixed.

Hey, great to hear @sergiocerrutti! One thing you could try also is deleting lock files & node modules, then fetching dependencies again, this may solve this kind of dependency resolving issues ☺

Seeing this issue as well. Started from scratch via prismic theme --theme-url https://github.com/prismicio-community/slice-library-starter-nuxt --conf sm.json

Ah yes, I think this was accidentally removed in some recent updates I've readded this as a dev dependency again :)


BUG: include_usage implementation doesn't seem to work.

This feature seems to be switched on to true by default in the OpenAI client (correct?). However, the StreamingChatCompletionUpdate.Usage property is always null. This appears to be a bug.
Before CompleteChatStreamingAsync(messages, options) is called when I inspect the options object, Stream=null and StreamOptions.IncludeUsage=true. However, immediately after CompleteChatStreamingAsync(messages, options) is called when I inspect the options object, Stream=true and SteamOptions is null.
Client version: Azure OpenAI
Azure client version: 2.0.0 Beta 2
OpenAI Client version: implicit (>= 2.0.0-beta.5)
OpenAI API version option: AzureOpenAIClientOptions.ServiceVersion.V2024_06_01
OpenAI API provider : Azure OpenAI
Model name: GPT-4o

Thank you for reaching out, @janaka ! And thank you for all the useful debug information you provided!
The Azure OpenAI service does not yet support include_usage (a.k.a. stream_options).
Also, for future reference, this repo corresponds to the OpenAI library. If you're using the Azure.AI.OpenAI library instead and are having trouble with it, you can file issues in the Azure repo here: 🔗 https://github.com/Azure/azure-sdk-for-net. Thank you!

@joseharriaga hi, the inference service now have this option? given it's in the specs?
https://github.com/Azure/azure-rest-api-specs/blob/3c4ddfa53535e9e2b775d885d91aa1ab57a7a7fd/specification/cognitiveservices/data-plane/AzureOpenAI/inference/preview/2024-07-01-preview/inference.json#L267

I confirm this works for me now. Tested against eastus and sweden with Postman.
When I checked last week it appears the original issue I reported is still the behaviour. I think it's a bug caused by the constructor of one of the classes missing the param.
@joseharriaga any idea when fixing this might get prioritised?

it would be great it somebody can confirm or deny this bug exists. afaik the class hasn't been touched in the last month.

@joseharriaga  or somebody working on this project, can you please acknowledge that this and reopen the issue 🙏🏾


[feature][connector][hudi] add hudi json read function and sql read/write

The Hudi Connector based on Hudi version 0.13 provides JSON read and sql read/write capabilities

approve sql read/writer

About hudi json read
hudiReader will produce org.apache.hudi.table.data.ColumnarRowData ,but the type required by all ChunjunWriters is com.dtstack.chunjun.element.ColumnRowData

ok

No data for sqlservercdc to hudi


Add integration of infiniteloader with custom or 3rd party tables (for example material-ui's table)

I use material-ui in my project and it seems that InfiniteLoader cannot be used with  table from this library. I only able to render rows using rowRenderer, but table, thead, tbody  tags cannot be rendered since react throws error:
Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <tbody>

Sorry @apedyashev. InfiniteLoader is only intended to work with other react-virtualized components. It's not realistic for me to support integration with arbitrary 3rd party libraries since I don't control their Apis.

for anyone has similar errors, try to set component and variant on the tablecell
  <TableCell component="div" variant="body" />;


Always use open on osx

Bringing this up for discussion. I don't know the rationale for the current behavior. I realize this is a bit of an edge case, and not the highest priority issue. I'll PR if there's interest.
Description
I run two instances of chrome on my computer. create-react-app is the only program that opens in the second browser instance on OSX.
To reproduce (warning, will use some HD space):
env '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome' --user-data-dir=~/.chrome-profile/foo

Leave that running, and then npm start in another terminal.
It opens in the second chrome instance.
Expected behavior
Should follow the normal OSX behavior of opening in the primary chrome instance, like open http://localhost:3000 does, or chat clients, etc.
Actual behavior
Opens in second instance.
Environment
$ npm ls react-scripts
<EMAIL_ADDRESS><dir>
└──<EMAIL_ADDRESS>$ node -v
v6.10.0
$ npm -v
3.10.10

Operating system: OSX
Browser and version: Chrome stable

It happens because we try to reuse the existing tab when opening Chrome, and this is only possible with AppleScript (rather than opn). It seems that reusing existing tab is more valuable to most people than supporting running two instances of Chrome so I think this is in wontfix territory. However you can force it to just use opn directly by passing BROWSER=open (this might work on master only).


add configure await to async calls where missing

regex:
\bawait\b(?![^;]*ConfigureAwait)[^;]*;

excludes
**/test/**/*.cs,**/AspNetCore/**/*.cs,**/benchmark/**/*.cs,**/benchmark10/**/*.cs

is this one ready?

@michaelstaib  yes


Error while loading EEF file.

Hi!
I am trying to run MAJA (v.3.3.2) without CAMS option on L1C tiles downloaded from peps.
At the moment I am getting such error:
vns::Data::ERROR: EarthExplorerXMLFileHandler(0x7af7d0): XMLFileHandler::LoadFile: Error while loading the file [.../Start-MAJA/temp_files/T22KHB/22KHB/GIPP_united/in/S2A_TEST_GIP_L2COMM_L_ALLSITES_00001_20190626_21000101.EEF]. Parsed with errors.
Will be grateful for any ideas or suggestions.

Hi Slavko,
we have had issues with products that did not include the full information requested by MAJA, regarding viewing angles for instance, but it was with early S2 products.
Does it happen for each product you process, or just for this specific one ?
Could you please provide us the command line, log printed on the screen, and log file of the product for which the error is observed ?
Thanks in advance,
Olivier

I tried different dates for the same tile - it resulted in the same error.
By the way, I found that I can use another tile for which 2A data is available, so at the moment I will close the issue.
By the way, thank you for the development and continuous support of the project - it is great!

Hey, don't give up.
there was an error in the xml file (a missing bracket '<' in the xml)
If you download the GIPP files again, this error should not happen anymore.
Olivier

In fact, 4 L2COMM GIPP files for Sentinel2-TM in the repository also have the same bug (at line 111, absence of '<'), after fixing that it started working!
Thank you for pointing that out!

I did the correction too quickly, I must have forgotten to push the file, sorry.
Glad it works !
I will be happy to get feedback
Olivier

At the moment I run the script without CAMS option and compared result with neighboring tile for which 2A data was available (at the same day). It looks similar, but there is some color difference (probably because of CAMS). So in the nearest future I will probably run it with CAMS and give more feedback.
Thanks again!

Hi Slavko,
Theia is not running with CAMS option either (as ECMWF changed the CAMS format in July and our adaptation is not fully ready yet). The colour difference you seem to have observed probably lies in the residual inaccuracy of MAJA, given that the tiles are processed independently (and although MAJA should have lower residuals than usually observed with Sen2cor).
Best regards,
Olivier

Ok, thanks for the info!

Let's say I want to use WASP for L2A->L3A conversion.
Is there any way to use in on L2A data from scihub.copernicus (2A data is available there, but it has a different format)?
Maybe, there is a way to convert one format to another, or there are some missing parts in copernicus format?
Maybe, the only way is to convert 1C data to 2A using MAJA first?
Thank you again!

Hi Slavko,
we did not write an interface to Sentinel-2 L2A from ESA. We could imagine it, but WASP is not adapted to Sen2cor (the processor behind ESA's L2A). WASP requires a very good cloud mask, and, well, Sen2cor cloud masks are not good enough, and would result in data gaps, and artefacts
Olivier


Fixed cell computation by using the correct geometries

The code made the assumption, that the spar is a straight line in component
segment coordinates. This is not true for tapered wings.
Now, we simply compute the intersection between the spar midplane line
and the rib face. This will be slower but should be more accurate.
Fixes #536

@rmaierl Can you please check this? I had a problem from a DLR user (see your EMail) when computing the wing cells.
This change should be more accurate but also slower. Could you please check this modification with some of your examples as well?

@rainman110 you are right, the code made the wrong assumption that the spar is a straight line in eta-xsi space. We already recognized this problem and fixed it in a different way, by computing the intersection in 3d space instead of the eta-xsi space. I generated a separate pull request #541 for it.
Please have a look at it and let's discuss afterwards which solution might be the better one.

Since also the tests work on Airbus /Risc side, I will merge this now.


Api

Why not there is Api!

It's in the works it will soon be available!

I will just close this since there is already https://github.com/cyclotruc/gitingest/issues/24


1.21 PLZZZZZZZZ!!!!!!

1.21 PLZZZZZZZZ!!!!!!

It is compatible with 1.21 but I forgot to mark it as compatible on modrinth and curseforge

You can use Dynamic FPS — it already has this feature (disabled by default though)


#838 Use default name priority if Spring controller method is unknown

What does this PR do?
Use default name priority if Spring controller method is unknown
Checklist

[ ] This is an enhancement of existing features, or a new feature in existing plugins

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

[ ] This is a bugfix

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that would fail without this fix

[ ] This is a new plugin

[ ] I have updated CHANGELOG.asciidoc
[ ] My code follows the style guidelines of this project
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have updated supported-technologies.asciidoc
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.

[ ] This is something else

[ ] I have updated CHANGELOG.asciidoc

@felixbarny Can you review these changes. I will add test cases once you approve of my changes.

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

Expand to view the summary

Build stats

Build Cause: [Pull request #1342 opened]

Reason: The PR is not allowed to run in the CI yet

Start Time: 2020-08-14T08:31:27.701+0000

Duration: 4 min 13 sec

Commit: c328f61f9a429364e9bbb57777ec569e211cb386

Steps errors
Expand to view the steps failures

Name: Error signal

Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Duration: 0 min 0 sec

Start Time: 2020-08-14T08:35:37.303+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-08-14T08:35:11.169Z]  > git fetch --no-tags --progress -- git@github.com:elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2020-08-14T08:35:12.847Z] Cleaning workspace
[2020-08-14T08:35:12.870Z] Using shallow fetch with depth 3
[2020-08-14T08:35:12.870Z] Pruning obsolete local branches
[2020-08-14T08:35:12.769Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-14T08:35:12.782Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-08-14T08:35:12.795Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-14T08:35:12.810Z]  > git rev-parse --verify HEAD # timeout=10
[2020-08-14T08:35:12.820Z] No valid HEAD. Skipping the resetting
[2020-08-14T08:35:12.820Z]  > git clean -fdx # timeout=10
[2020-08-14T08:35:12.836Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-08-14T08:35:12.837Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-14T08:35:12.842Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/apm-agent-java.git +refs/pull/1342/head:refs/remotes/origin/PR-1342 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-08-14T08:35:13.514Z] Merging remotes/origin/master commit 9541c3e9ddd351802fde59953eab6201a6129ffe into PR head commit c328f61f9a429364e9bbb57777ec569e211cb386
[2020-08-14T08:35:13.769Z] Merge succeeded, producing c328f61f9a429364e9bbb57777ec569e211cb386
[2020-08-14T08:35:13.769Z] Checking out Revision c328f61f9a429364e9bbb57777ec569e211cb386 (PR-1342)
[2020-08-14T08:35:13.486Z]  > git config core.sparsecheckout # timeout=10
[2020-08-14T08:35:13.495Z]  > git checkout -f c328f61f9a429364e9bbb57777ec569e211cb386 # timeout=15
[2020-08-14T08:35:13.697Z]  > git remote # timeout=10
[2020-08-14T08:35:13.702Z]  > git config --get remote.origin.url # timeout=10
[2020-08-14T08:35:13.712Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-14T08:35:13.715Z]  > git merge 9541c3e9ddd351802fde59953eab6201a6129ffe # timeout=10
[2020-08-14T08:35:13.725Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-08-14T08:35:13.737Z]  > git config core.sparsecheckout # timeout=10
[2020-08-14T08:35:13.742Z]  > git checkout -f c328f61f9a429364e9bbb57777ec569e211cb386 # timeout=15
[2020-08-14T08:35:17.631Z] Commit message: "#838 Removed unwanted indentation"
[2020-08-14T08:35:17.632Z] First time build. Skipping changelog.
[2020-08-14T08:35:17.632Z] Cleaning workspace
[2020-08-14T08:35:17.722Z]  > git --version # timeout=10
[2020-08-14T08:35:17.731Z] fatal: bad object 1da495471ce25b8d7f1f5f910207a97fb80cec40
[2020-08-14T08:35:17.618Z]  > git rev-parse --verify HEAD # timeout=10
[2020-08-14T08:35:17.626Z] Resetting working tree
[2020-08-14T08:35:17.626Z]  > git reset --hard # timeout=10
[2020-08-14T08:35:17.653Z]  > git clean -fdx # timeout=10
[2020-08-14T08:35:18.504Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2020-08-14T08:35:18.578Z] Timeout set to expire in 1 hr 0 min
[2020-08-14T08:35:18.609Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2020-08-14T08:35:18.910Z] [INFO] Number of builds to be searched 10
[2020-08-14T08:35:19.172Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2020-08-14T08:35:19.198Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1342/src/github.com/elastic/apm-agent-java
[2020-08-14T08:35:19.240Z] [INFO] gitCheckout: Checkout SCM PR-1342 with some customisation.
[2020-08-14T08:35:19.273Z] [INFO] Override default checkout
[2020-08-14T08:35:19.344Z] Sleeping for 10 sec
[2020-08-14T08:35:29.513Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2020-08-14T08:35:29.540Z] Cloning the remote Git repository
[2020-08-14T08:35:29.558Z] Cloning repository git@github.com:elastic/apm-agent-java.git
[2020-08-14T08:35:29.586Z]  > git init /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1342/src/github.com/elastic/apm-agent-java # timeout=10
[2020-08-14T08:35:29.604Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-java.git
[2020-08-14T08:35:29.605Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-08-14T08:35:29.605Z]  > git --version # timeout=10
[2020-08-14T08:35:29.622Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-14T08:35:29.629Z]  > git fetch --tags --progress -- git@github.com:elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-08-14T08:35:30.737Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-14T08:35:30.742Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-08-14T08:35:30.750Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-14T08:35:30.762Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-08-14T08:35:30.762Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-14T08:35:30.765Z]  > git fetch --tags --progress -- git@github.com:elastic/apm-agent-java.git +refs/pull/1342/head:refs/remotes/origin/PR-1342 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2020-08-14T08:35:31.490Z] Checking out Revision c328f61f9a429364e9bbb57777ec569e211cb386 (origin/PR-1342)
[2020-08-14T08:35:31.680Z] Commit message: "#838 Removed unwanted indentation"
[2020-08-14T08:35:31.698Z]  > git --version # timeout=10
[2020-08-14T08:35:31.706Z] fatal: bad object 1da495471ce25b8d7f1f5f910207a97fb80cec40
[2020-08-14T08:35:32.501Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-08-14T08:35:31.483Z]  > git rev-parse origin/PR-1342^{commit} # timeout=10
[2020-08-14T08:35:31.492Z]  > git config core.sparsecheckout # timeout=10
[2020-08-14T08:35:31.497Z]  > git checkout -f c328f61f9a429364e9bbb57777ec569e211cb386 # timeout=10
[2020-08-14T08:35:33.139Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2020-08-14T08:35:34.147Z] Archiving artifacts
[2020-08-14T08:35:34.871Z] + git rev-parse HEAD
[2020-08-14T08:35:35.254Z] + git rev-parse HEAD
[2020-08-14T08:35:35.576Z] + git rev-parse origin/pr/1342
[2020-08-14T08:35:35.632Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-08-14T08:35:35.848Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-08-14T08:35:36.851Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-java/pulls/1342/reviews return 0 elements
[2020-08-14T08:35:36.925Z] [INFO] githubPrCheckApproved: Title: #838 Use default name priority if Spring controller method is unknown - User: antrix190 - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-08-14T08:35:37.325Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2020-08-14T08:35:37.325Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2020-08-14T08:35:37.412Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2020-08-14T08:35:37.439Z] Sleeping for 5 sec
[2020-08-14T08:35:38.523Z] Stage "Build" skipped due to earlier failure(s)
[2020-08-14T08:35:38.744Z] Stage "Tests" skipped due to earlier failure(s)
[2020-08-14T08:35:38.965Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2020-08-14T08:35:38.980Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2020-08-14T08:35:38.994Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2020-08-14T08:35:39.012Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-08-14T08:35:39.027Z] Stage "Javadoc" skipped due to earlier failure(s)
[2020-08-14T08:35:39.217Z] Failed in branch Unit Tests
[2020-08-14T08:35:39.228Z] Failed in branch Smoke Tests 01
[2020-08-14T08:35:39.239Z] Failed in branch Smoke Tests 02
[2020-08-14T08:35:39.251Z] Failed in branch Benchmarks
[2020-08-14T08:35:39.264Z] Failed in branch Javadoc
[2020-08-14T08:35:39.566Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-08-14T08:35:39.667Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-08-14T08:35:39.712Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-08-14T08:35:40.054Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1342
[2020-08-14T08:35:40.208Z] [INFO] getVaultSecret: Getting secrets
[2020-08-14T08:35:40.284Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-14T08:35:41.376Z] + chmod 755 generate-build-data.sh
[2020-08-14T08:35:41.376Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1342/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1342/runs/1 ABORTED 253403
[2020-08-14T08:35:41.927Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1342/runs/1/steps/?limit=10000 -o steps-info.json

Hi @antrix190 , we recently changed the default name strategy with https://github.com/elastic/apm-agent-java/pull/1906, thus this PR is quite likely no longer relevant. As a result we will very likely close it soon.

@SylvainJuge Sure let me know if i can help in any other issue.


Why different replay table setup for R2D2 in Jax vs. TF agent?

Specifically why does the JAX version have 2 options while the TF version has 1 option. I assume there's some benefit?
JAX: https://github.com/deepmind/acme/blob/dbd70073fffedef86bb933e88d5e675a2630f3e2/acme/agents/jax/r2d2/builder.py#L111
TF: https://github.com/deepmind/acme/blob/dbd70073fffedef86bb933e88d5e675a2630f3e2/acme/agents/tf/r2d2/agent.py#L84

@wcarvalho our development was mostly focused on JAX for quite some time now and the TF agents may have fallen behind. If in doubt, I'd always suggest referring to the JAX implementations.
The two options in the jax version are there in order to support running R2D2 in both local and distributed setups. In case you want to run DistributedR2D2, you'd probably want to use the reverb rate limiter and tweak samples_per_insert. In the single-process synchronous version you don't need the rate limiter. In fact it can deadlock if you enable it, so you'd better set samples_per_insert to 0.
I hope this was clear enough. Feel free to reopen if it was not.

Thank you! This was helpful.


If using multiple sets in a shader, they may be ordered incorrectly when creating a descriptor [fixed]

This is because they are coming from an unordered_map and the sets might get shuffled around, the following code in Pipeline.cpp inserts them into a vector in essentially random order:
        // Create a descriptor set layout for pipeline creation and returning externally.
        auto result = pipeline->CreateDescriptorSetLayouts();
        if (result != VK_SUCCESS)
        {
            delete pipeline;
            return result;
        }

        // Create the pipeline layout handle.
        std::vector<VkDescriptorSetLayout> setLayouts;
        for (auto it : pipeline->m_descriptorSetLayouts)
            setLayouts.push_back(it.second->GetHandle());

Change it as follows to solve this issue:
        // Create the pipeline layout handle.
        std::vector<VkDescriptorSetLayout> setLayouts( pipeline->m_descriptorSetLayouts.size() );
        for (auto it : pipeline->m_descriptorSetLayouts)
            setLayouts[ it.first ] = it.second->GetHandle();

NOTE: This isn't a complete fix, if you have a situation where your sets have gaps (i.e. set 0 and set 2, but no set 1) then you would create an array too small and cause issues. There are also other spots in Pipeline.cpp where a similar change is needed.

A more complete fix is to include this version of CreateDescriptorSetLayout in Pipeline.cpp, which identifies shaders with gaps in the sets and fills them with empty descriptors. It also ensures the array size is large enough to avoid the issue mentioned above:
    VkResult Pipeline::CreateDescriptorSetLayouts()
    {
        // Iterate over each set binding and create a DescriptorSetLayout instance.
        uint32_t maxSetUsed = 0;
        for (auto it : m_bindings)
        {
            DescriptorSetLayout* descriptorSetLayout = nullptr;
            auto result = m_device->GetDescriptorSetLayoutCache()->CreateLayout(it.first, it.second, &descriptorSetLayout);
            if (result != VK_SUCCESS)
                return result;

            m_descriptorSetLayouts.emplace(it.first, descriptorSetLayout);
            maxSetUsed = std::max( maxSetUsed, it.first );
        }

        // Did we create gaps?
        if ( maxSetUsed != m_descriptorSetLayouts.size() - 1 )
        {
            // Fill the holes with empty descriptor sets
            std::vector<VezPipelineResource> emptySet;
            for ( uint32_t i=0; i<maxSetUsed; ++i )
            {
                if ( m_descriptorSetLayouts.find(i) == m_descriptorSetLayouts.end() )
                {
                    DescriptorSetLayout* descriptorSetLayout = nullptr;
                    auto result = m_device->GetDescriptorSetLayoutCache()->CreateLayout(i, emptySet, &descriptorSetLayout);
                    if (result != VK_SUCCESS)
                        return result;

                    m_descriptorSetLayouts.emplace(i, descriptorSetLayout);
                }
            }
        }

        // Return success.
        return VK_SUCCESS;
    }


export TableDataModifier

Proposed Changes

Potential Breaking Changes

Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1388 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
+ Coverage   99.23%   99.23%   +<.01%
==========================================
  Files         476      476
  Lines        9955     9956       +1
  Branches     2278     2278
==========================================
+ Hits         9879     9880       +1
  Misses         76       76

Impacted Files
Coverage Δ

...t-vapor/src/components/tables/TableDataModifier.ts
100% <100%> (ø)
:arrow_up:

packages/react-vapor/src/components/drop/Drop.tsx
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac977d7...9138157. Read the comment docs.


Feature/dev 7418

Updated initial state for Download Link in Data Table

@Atash3000 this needs additional work. It's a good start to default everything on, but what if users decide to turn the option off in the editor panel? We'll need to hide those options as well, and use the coveUpdateWorker in core to default previous configs download options to true.


[python3:x64-osx] Unable to install Python3 on macOS

Hello,
when trying to ./vcpkg install python3 on macOS I get the following error:
The following packages will be built and installed:
    python3[core]:x64-osx
Starting package 1/1: python3:x64-osx
Building package python3[core]:x64-osx...
-- Using cached /Users/toxe/suite/build/vcpkg/downloads/python-cpython-v3.7.3.tar.gz
-- Extracting source /Users/toxe/suite/build/vcpkg/downloads/python-cpython-v3.7.3.tar.gz
-- Using source at /Users/toxe/suite/build/vcpkg/buildtrees/python3/src/v3.7.3-1161ad7a91
-- Building /Users/toxe/suite/build/vcpkg/buildtrees/python3/src/v3.7.3-1161ad7a91-Lib-static-crt-dynamic/PCBuild/pythoncore.vcxproj for Release
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:58 (message):
    Command failed: msbuild /Users/toxe/suite/build/vcpkg/buildtrees/python3/src/v3.7.3-1161ad7a91-Lib-static-crt-dynamic/PCBuild/pythoncore.vcxproj /p:Configuration=Release /t:Rebuild /p:Platform=x64 /p:PlatformToolset=external /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /p:WindowsTargetPlatformVersion= /m /p:WholeProgramOptimization=false
    Working Directory: /Users/toxe/suite/build/vcpkg/buildtrees/python3/x64-osx-rel
    Error code: No such file or directory
    See logs for more information:

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_msbuild.cmake:119 (vcpkg_execute_required_process)
  ports/python3/portfile.cmake:37 (vcpkg_build_msbuild)
  scripts/ports.cmake:73 (include)

Error: Building package python3:x64-osx failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: python3:x64-osx
  Vcpkg version: 2019.06.26-unknownhash

I am using the current version of Vcpkg (master, commit e024dd7) and a custom installed clang 8.0.1-rc3 on macOS Mojave 10.14.5. I am not using Apple LLVM/Clang that comes with Xcode.

you can try this PR #8055

Hello, sorry I am a bit late but I just checked your PR and it worked for me.

Issue has been resolved.


added template for list

PR for #159
Followed prevalent code structure.

Hey @swapagarwal have you looked into this?


Added a project Drum-site

added a project to experience virtual-band

i have added my name in contribution .md and made a pull request #58 please
accept
On Wed, 21 Oct 2020 at 09:11, Saksham Singh<EMAIL_ADDRESS>wrote:

Merged #55 https://github.com/SakshamSingh-v2/First-Projects/pull/55
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SakshamSingh-v2/First-Projects/pull/55#event-3901703851,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSHVUNZIWM5CWICACUT7G3SLZJ5TANCNFSM4SYUZZEQ
.


Unable to start orientdb service on windows 8

I have followed the instructions mentioned on below page and installed orientdb as a service but unable to start that.
http://orientdb.com/docs/2.1/Windows-Service.html
I am getting below exception
Windows could not start the OrientDB GraphEd X.X.X on Local Computer. For more information, review the System Event Log. If this is a non-Microsoft service, contact the service vendor, and refer to service-specific error code 4.
FYI - event log
OrientDB GraphEd X.X.X
%%4
Thanks for your help in advance.
Thanks
Konda Reddy.

Hi,
Thanks for opening this issue. OrientDB 2.1 is EOL. I wonder if this is still happening with 2.2-GA or 3.0-snapshot?
I'll give this a try on Windows 10 as soon as it will be possible
Link to the 2.2. doc: http://orientdb.com/docs/2.2.x/Windows-Service.html
Many thanks,


Apply template before applying control theme to children

What does the pull request do?
Apply the fix proposed in https://github.com/AvaloniaUI/Avalonia/issues/10226#issuecomment-1421052366. I can add unit tests if needed.
What is the current behavior?
Expander styles broken in Simple Theme, see https://github.com/AvaloniaUI/Avalonia/issues/10226#issue-1571433120.
What is the updated/expected behavior with this PR?
Expander styles work as expected.
How was the solution implemented (if it's not obvious)?
Described in https://github.com/AvaloniaUI/Avalonia/issues/10226#issuecomment-1421052366.
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
Technically it's a breaking change, but this code is recent so it shouldn't be a problem.
Fixed issues
Fixes #10226

Actually, this is wrong, closing until I fix this correctly.


[Feature] Option to keep the container width fixed even when the canvas is responsive

Summary
Option to keep the container width fixed even when the canvas is responsive

@rishabhsaxena @marks0351 @riodeuno Could this be solved by making both of these a container property?


Enhance helper Pod interface and configuration.

Make the helper Pod receive only environment variables instead of args (this changes the interface in a non-backward compatible way but is simpler to use and potentially provides more backward compatibility in the future; #175).
Adds the manager options --pvc-annotation[-required] to pass through annotations from the PVC to the PV and to the helper Pod (#164).
Merge the helper Pod's data VolumeMount with the one provided with the template to be able to specify mountPropagation within the template (#165).
Rename helperPod.yaml to helper-pod.yaml (more convenient and if we break sth we can break this as well).
Expose --helper-pod-timeout option (#178).
Provide a basic usage example of the new features (examples/cache).
Support forceful termination of the manager binary (2xctrl+c - since this is annoying during development otherwise; #179).

Closes #164.
Closes #165.
Closes #175.
Closes #178.
Relates to #179.
Relates to #127.

@yasker please have a look

@yasker please have a look

I just rebased this PR and resolved the conflicts.

Thanks for the contribution.
It looks you want to solve several issues or enhancements, so I would suggest to seperate this PR first, so we can focus on each problem you are resolving and it will be better for review.

@innobead okay, I moved the mountPropagation feature into a new PR now: #176 - though I've also added the env var support to it (to reduce merge conflicts within other PRs) but in a backward compatible way.

In regards to https://github.com/rancher/local-path-provisioner/pull/177 having been merged. I'm getting the following err:

In the local-path helper Pod. I deployed from https://raw.githubusercontent.com/rancher/local-path-provisioner/master/deploy/local-path-storage.yaml as the ReadMe describes - and I did so today.
Sure enough I haven't provided this VOL_DIR parameter anywhere. Where am I to do so? I can't seem to find it described anywhere.
Thank you very much.

Yeah! That made it work! Thank you very much @derekbit


Use source dir in Asciidoctor converter

This solves my comment https://github.com/gohugoio/hugo/pull/7281#issuecomment-632644621 for me

Ah thanks!! I didn't see that you were faster than me - I just fixed it in a similar way!

I was wondering if that functionality isn't provided by Hugo out of the box, instead of redundantly implementing and fixing the source vs destination logic ourselves. I was expecting some function like GetDestinationDir or something.
Your go formatting over at https://github.com/gohugoio/hugo/pull/7281 is wrong. That fails the build.

I pushed to this pull request with a fix for the formatting


CropCircleWithBorderTransformation - border radius incorrect

TransformationUtils.circleCrop(...) is working with minimal edge (Math.min(destWidth, destHeight)), but CropCircleWithBorderTransformation is drawing border radius using maximal edge.
https://github.com/wasabeef/glide-transformations/blob/8144929b636e19323289a240a4d5e18949f00049/transformations/src/main/java/jp/wasabeef/glide/transformations/CropCircleWithBorderTransformation.java#L73
As a result border is not around image when target width and height are different.

Fixed transform function should look like this:
  @Override
  protected Bitmap transform(@NonNull Context context, @NonNull BitmapPool pool,
                             @NonNull Bitmap toTransform, int outWidth, int outHeight) {

    Bitmap bitmap = TransformationUtils.circleCrop(pool, toTransform, outWidth, outHeight);

    setCanvasBitmapDensity(toTransform, bitmap);

    Paint paint = new Paint();
    paint.setColor(borderColor);
    paint.setStyle(Paint.Style.STROKE);
    paint.setStrokeWidth(borderSize);
    paint.setAntiAlias(true);

    int outMinEdge = Math.min(outWidth, outHeight);
    Canvas canvas = new Canvas(bitmap);
    canvas.drawCircle(
      outMinEdge / 2f,
      outMinEdge / 2f,
      outMinEdge / 2f - borderSize / 2f,
      paint
    );

    return bitmap;
  }

I would create PR myself, but I do not have rights to push, since I am not marked as contributor.


⚠ Bofrost.at has degraded performance

In 818f4ec, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1166 ms

Resolved: Bofrost.at performance has improved in 1b4eb99 after 20 minutes.


CI: Setup auto publish when merge into main

[ ] CI publishing.
[ ] Update package.json to implement lock-step publishing across packages.


[Q] how can I remove log?

For instance,
wandb.log({f"score" : 0.1})
wandb.log({f"speed" : 0.99})
Then, how can I remove the previous log named "score"?

Hi @LifeBeyondExpectations , could you please explain your use-case a bit more? As in why do you want to remove the score metric? As of now, one cannot remove or delete any metric once it's logged, however, if you want to hide the panel in your workspace, you could move this score panel to the Hidden Panels section. Please let me know if this is helpful.

Hi @LifeBeyondExpectations, I wanted to follow up on this request. Please let us know if we can be of further assistance or if your issue has been resolved.

Hi @LifeBeyondExpectations , since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!


Status 400 when play fairplay content

Hi I am using the v4.9.5 version shaka player demo, I am trying to play fairplay content, it need set "Custom Licenses Certificate URL", I put certificate.der file on Amazon S3 bucket, so I use the URL on S3 for certificate file.
After I try to play the content with available header value, the status 400 pops up, could you please give me some suggestions about this error? Thanks.

I see you are using Verimatrix. Please note that the default Demo does not support Verimatrix, but some changes need to be included, please see: https://shaka-player-demo.appspot.com/docs/api/tutorial-fairplay.html

Thanks for your reply. If I use the verimatrix, I need modify the patchedmediakeys_apple_unit.js file under \test\polyfill, like below screenshot? do I need modify other part? do I need compile the library again?

That would be the only thing. There is no need to compile the player again.

OK, thanks. But  the result is same. the status 400 pops up, do you know which JS file mention the location of certificate.der?

I recommend that you talk to your DRM provider so they can tell you what the error is due to.


fix: Profile Query Keys and User Permissions loading state

Description 📝

Fixes profile query keys causing some mutations to not invalidate the correct query key
Relates to https://github.com/linode/manager/pull/9987
I left useProfile alone because the parent/child project needs headers functionality. Other profile query keys were reverted to their old format
This bug is a perfect example of why we need a query key factory 🏭😖
Also fixes an unrelated bug with User Permission loading state

How to test 🧪
Query keys:

Check out this PR
Test profile related features such as...

Revoking a trusted device
Enabling / disabling 2FA
Creating, updating, and deleting SSH keys

Verify the changes to useGrants does not break anything
Do you best to verify all query keys "match up"

Loading state:

Have a restricted user on your account.
Go to http://localhost:3000/account/users and select the "User Permissions" for that restricted user
Confirm that the loading spinner displays while the queries load and then the Full Account Access is disabled and toggled to false; we should not see the page load with the Full Account Access toggled to true and enabled and then later change to false (the bug)

As an Author I have considered 🤔

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@bnussman @mjac0bs the two-factor-auth e2e failure seems legit?

@abailly-akamai I believe I've pushed a fix. Parent child folks, please double check my work. I'm not super familiar with how useProfile should work anymore 😵💫


Update Dockerfile to create epel repo config when NO_PROXY is undefined

I saw this change in the other PR, but my eyes can't spot what the change actually is here other than a newline at the end? Also a small typo fix in the comment?

I saw this change in the other PR, but my eyes can't spot what the change actually is here other than a newline at the end? Also a small typo fix in the comment?

- "${NO_PROXY:__ZZZZZ}" == "__ZZZZZ"
+ "${NO_PROXY:-__ZZZZZ}" == "__ZZZZZ"

- "${NO_PROXY:__ZZZZZ}" == "__ZZZZZ"
+ "${NO_PROXY:-__ZZZZZ}" == "__ZZZZZ"

The original is ${NO_PROXY-__ZZZZZ}, it's the : that is missing, not the -

I'm submitting this as an interesting curiosity, then I'm forcing the merge since we're having CI issues and this is trivial.
$ echo "${NO_PROXY:-__ZZZZZ}"
__ZZZZZ

$ echo "${NO_PROXY-__ZZZZZ}"
__ZZZZZ

$ NO_PROXY=true

$ echo "${NO_PROXY:-__ZZZZZ}"
true

$ echo "${NO_PROXY-__ZZZZZ}"
true

I don't see anything in the bash manual[1] that suggests the : is optional, but okay. I still like this version better.
https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html


Add some more methods to classes

Some methods that were needed for some of the skins we are rendering now

oh yea, forgot to remove them from the megalist of implemented functions hah


ZIP archive contains unsupported data structures.

Hi all,
When I add 3.1.1 from nuget in Visual Studio 2015, I find I get several errors managing nuget packages from then on.

The installed packages tab in Visual Studio won't list any project packages and shows the attached error.

I can't update OR uninstall any packages in nuget, even those which have no dependencies on UA.

Perhaps there is something strange in the nuget package which is causing this PM error, which subsequently "breaks" package manager?
WORKAROUND:
Remove UA package from project.  Other packages can then be managed.  When done, add UA package back in.
Thanks!
Kurt @ nbb

@khnbb Not sure whats going on here. Is this for iOS or Android?

Closing due to lack of activity. Please reopen if you are still having issues.


Show comments in explorer view

Would it be possible to show review comments for the current change in the editor itself, rather than a separate view?
I realize this may not be feasible, due to difficulties figuring out where to anchor the comment, but even showing the comment at the top of the page if the specific location can't be determined, like gerrit itself does, would be incredibly useful.

That should already be the case if you've checked out a change. If you go to the gerrit tab, check out a change by clicking the down-arrow and then go to any file that contains a comment you should see it inline. Or is there another type of comments or situations that you mean?

If I open the "gerrit" tab I can see the files with their diffs and the comments inline, sure, but it's read-only and I can't edit it. I meant like, comments in the actual writable files, I can't see any comments in those even when I check it out directly. Is that supposed to work? What source is that info coming from, because git-review has been a bit inconsistent for me.

You should see them. If you go to the gerrit panel you should see a little comment balloon behind files containing comments. Then in the diff view (clicking the file) you should indeed see the comments. Then if you check out that patch (by clicking the checkout icon) and then you navigate to the file you'll see any unresolved comments inline and resolved ones as expandable.
The source is the HTTP API for comments. git-review is only used for pushing patches.

It doesn't show up for me :(. The checkout name when I do that in git is "review/unknown/[change number]" and doing "next unresolved comment" gives me "Cannot read properties of null (reading '0')" if that helps at all. The "comments" tab is also empty when on the file. How would I debug this? I don't see any specific errors for it in the gerrit output. I can see it issuing valid requests to the correct address for that change in the output when I reload on the file, but no comments show up, with the comments tab saying "no comments in this workspace yet" :c

The review/unknown/[change number] part sounds good, that's what gerrit does by default when you git-review -d [change number] on the command line. The unknown part is a bit weird though, it should contain the author name. Unless you have anonyous/unnamed users on your gerrit instance, just haven't personally seen that before.
I've now fixed the Cannot read properties of null issue, thanks for reporting that :)
I think maybe easiest to start debugging whether the comments are coming through at all. Do you see any comment balloons in the gerrit tab at all (for files where you'd expect them of course)? If not then it sounds like the comments aren't coming through. You said clicking the URLs leads to you a JSON file with no comments. Can you confirm that, for a change where you'd expect comments, the URL {gerrit_host}/a/changes/{project}~{branch}~{changeID}/comments/ (you probably don't have to type it out and can find in the logs) returns a JSON file with no comments once visited in the browser? If so then somehow your gerrit instance is not exposing the comments to the web API for some reason.

Ahh, I think I miscommunicated, the json bundle is fine, I meant no comments show up on the file in the editor despite it clearly making a valid web request for the comments. Additionally, the "gerrit" tab works great, it's just the file in the actual editor that lacks comments, or even a comment side bar.

Thanks for looking into it! There's indeed a pretty big chance that that is the issue. I've fixed it in the below package, can you give that one a try? Note that those changes are based on top of the other file I sent you, maybe good to know.
vscode--gerrit-1.2.34.zip

It doesn't fix the issue but it helps, it's.. very weird.  So, opening the file normally does not show comments or even the comment gutter. However, not only does the side-by-side view show comments, it now lets me edit the file! I can also press the "open file" button to open the file by itself, and that lets me edit and shows comments, but it's missing error highlighting (but not semantic autocomplete??)
What I think is going on, is that when I open the file normally it shows like subfolder/filename.cpp and when I open in the gerrit view, it's the full path /home/me/reponame/subfolder/filename.cpp and it's treating those as separate files. It seems like there is an issue with using the full path, and vscode just wants the path from the workspace root. But the path is correct now at least! It's just that vscode wants a relative path from the workspace root, not an absolute path, to recognize the file as the same.

Ah yeah that's a bit of a running issue that is separate from your case. I'll merge the fix and try to solve that issue after. Thanks for testing!

I'm pretty sure I've fixed the issue, including making comments work for the opening-the-file-normally case. I'll be publishing these changes in version 1.1.36 so let me know if it works. I'll just close the issue for now, but feel free to re-open if it turns out something doesn't work.


Target

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (de63257) 31.60% compared to head (af2a4a8) 31.42%.
Report is 4 commits behind head on master.

Files
Patch %
Lines

src/sampler.jl
95.23%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   31.60%   31.42%   -0.19%
==========================================
  Files          12       11       -1
  Lines         734      716      -18
==========================================
- Hits          232      225       -7
+ Misses        502      491      -11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


arm64 couldn't find "libsqlitejdbc.so"

Please advise if this is a mistake or if I did something wrong.
java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/app.text-y0ZqgH1vwIgRDVtkTETz7g==/base.apk"],nativeLibraryDirectories=[/data/app/app.text-y0ZqgH1vwIgRDVtkTETz7g==/lib/arm64, /system/lib64, /system/product/lib64]]] couldn't find "libsqlitejdbc.so"
Libs from Linux/Android are located here in project - https://github.com/mironoff2007/xerial_test
xerial = "<IP_ADDRESS>"

device info

x86 emulator works fine

did you read https://github.com/xerial/sqlite-jdbc/blob/master/USAGE.md#how-to-use-with-android ?

did you read https://github.com/xerial/sqlite-jdbc/blob/master/USAGE.md#how-to-use-with-android ?

Sorry, but I missed that. Thank you very much.


Move some definitions to cpp file to improve compilation time

Codecov Report

Merging #5 (e4b6c89) into master (bb1b25b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        14    -2
  Lines          482       447   -35
=========================================
- Hits           482       447   -35

Impacted Files
Coverage Δ

coil/include/coil/Bindings.h
100.00% <ø> (ø)

coil/include/coil/Expected.h
100.00% <ø> (ø)

coil/include/coil/Utils.h
100.00% <ø> (ø)

coil/include/coil/detail/StringWrapper.h
100.00% <ø> (ø)

coil/include/coil/NamedArgs.h
100.00% <100.00%> (ø)

coil/include/coil/TypeSerializer.h
100.00% <100.00%> (ø)

coil/include/coil/detail/FunctorCaller.h
100.00% <100.00%> (ø)

coil/include/coil/AnyArgView.h
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1b25b...e4b6c89. Read the comment docs.


fix: Gatsby Plugin Feed wants names export  wrapRootElement in ThemeProvider

:tada: This PR is included in version 0.9.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Default to AWS region and profile from standard cli config

It would be great if rather than requiring a separate config file, you could simply inherit the current configuration of the CLI (profile, region etc).

+1

Or as a parameter would also be very useful.

I think it would be more sensible to either have no overwrites and let boto3 look at your AWS_DEFAULT_PROFILE and AWS_DEFAULT_REGION variables. Or add parameters for these in the cli tool. The config file in the package is not so handy for parameters that change.

@DaanRademaker you are absolutely right. At the moment, I do not have time to fix this. PRs are welcome, and otherwise I can pick this up in two weeks time.

@DanielRieske  would you be able to pick up this.
The rational way would be if AWS_PROFILE and/or AWS_REGION is not set in the configuration for this utility, it won't set it and uses the default AWS SDK settings instead of prompting.

I might have some time to create pull request!

What would be the preferred override of for example profile?
I was thinking:

option (--profile)
config (as it is currently implemented)
fallback to AWS_DEFAULT_PROFILE environment variable?

@DaanRademaker Let me know if there is anyway I can assist, I also have some time at hand.
For now, I would let --profile take precendence over everything, config being the default and using AWS_DEFAULT_PROFILE to override the profile in config

If the aws-ssh-tunnel config file does not contain a profile or region, it will use the AWS SDK defaults when creating the aws.Session.
The --profile and --region override the aws-ssh-tunnel config.

Pull request with the changes.
https://github.com/binxio/aws-ssh-tunnel/pull/10

@DanielRieske will we do a release soon? This issue is solved but main has not been released yet.

Aah yes sounds good. If you want I can help setup a more pythonic way to build and deploy the package (using poetry). We for example implemented that already in repo of your sister company (xebia data) here. This way you can just release patch, minor major from github action.


Latest packages are not accessible for Msbuild auto restore.

After the issues with Nuget today. I can not do CI due to an error I get trying to update a nuget package. The latest version of the package can not be found by nuget restore. Its like some data has rolled back to older data (check point).
I have problems with:
New Relic for Windows Azure Web Sites (x86) 4.5.90
and
NewRelic.Agent.Api 4.6.29

I'm having the same issue with JWT 1.3.4...

Today is a nightmare. I have more than 10 packages failing right now.

Same here it seems that the latest versions of the packages are failing.

This package fails too (and this is not the latest but the one from May 2):
nuget install WindowsAzure.ServiceBus -Version 2.6.6 -nocache

So nuget.org is hosted on Azure and the trafficmanager is the load balancer. Is it Azure issue or nuget issue? I think it is Azure issue because I can download all failing packages from the website using the download button. => https://www.nuget.org/packages/WindowsAzure.ServiceBus/2.6.6
Or it is something else. Please someone explain to us what is going on so I know if I have to update all 20 servers manually. 10x
C:>nslookup www.nuget.org
Server:  UnKnown
Address:  <IP_ADDRESS>
Non-authoritative answer:
Name:    nuget-prod-0-v2gallery.cloudapp.net
Address:  <IP_ADDRESS>
Aliases:  www.nuget.org
nuget-prod-v2gallery.trafficmanager.net

Installations via the Package Manager Console in VS appear to be succeeding, restores via API calls to NuGet.org do not appear to find the latest package.

"Installations via the Package Manager Console in VS appear to be succeeding, restores via API calls to NuGet.org do not appear to find the latest package." <= Same here. The BUILD server is dead. RIP

Same error. Does not work nuget restore for recently updated nuget packages and outdated packages in the VS "Manage Nuget Packages" window.
(RestorePackages target) ->
  ...\.nuget\NuGet.targets(100,9): error : Unable to find version '2.1.4' of package 'jQuery'.

This was caused by an issue on www.nuget.org. It should be resolved right now. Feel free to respond to this issue in case you are still seeing issues.

This was caused by an issue on www.nuget.org. It should be resolved right now. Feel free to respond to this issue in case you are still seeing issues.

It works for me

Looks like it's started to work. Thanks, Maarten!

NuGet.exe install packages.config -OutputDirectory packages
This command fails with the same error.


Escape key to exit UNFLoader

Currently when uploading, rom uploads can get stuck in a failure process that's uninterruptible. Allowing Esc key exiting would allow for quick restarts if issues occur.

As said on N64Brew, I'll implement this for ESC instead just to keep consistent with the program's controls :smile:

Edited!! Thanks buu

I'll get this done after my exam on the 4th :smile:

Confirmed working.


FlowFieldSpooler cleanup

After a FF result is not collected for X(?) iterations, delete it

Also fix log messages


Links under Realtime dashboard > Pages section are broken

Issue: https://i.imgur.com/3I3XQrK.png
Realtime Dashboard > Pages
I am using v1.6.0.

You don't have a domain defined for your website?

I do have. https://i.imgur.com/DEeUSSv.png

Do you only have one website setup?

Yes. I do have a second account set up for a friend from the same installation and it has the same bug though.


[BUGFIX] Don't use DiagnosticsEngine without initialization.

This PR fixes a bug in src/command_line.cc -> RunQueryDbThread(). The DiagnosticsEngine was used without being properly initialized.

CI fails due to some weird spacing mismatches in test cases. Let me know if you would like me to look into that.

Init is called after the initialize message. Is this causing a crash?


Added Javascript Interview Questions

Added a javascript interview question repo, it will help people to prepare for the interviews.

Added some cool UI tools

Added a website link that contains portfolio for developers working in big companies


New article under Power Automate guidance

Title: Require approval of documents in SharePoint using Power Automate
Category

[ ] Content fix
[ ] New article
[x] Example checked item (delete this line)

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
(DELETE THIS PARAGRAPH AFTER READING)

Related issues:

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

If this fixes (aka: closes) or references an issue, please reference it here. This helps maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.
(DELETE THIS PARAGRAPH AFTER READING)

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
(DELETE THIS PARAGRAPH AFTER READING)

Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to 'master' branch. Released documents are in live branch.
(DELETE THIS PARAGRAPH AFTER READING)

Observations @chakkaradeep @jackwi-alt :

please complete the new PR template form
markdown formatting doesn't meet MSDOCS guidelines such as:

do not use explicit numbers in bullets for numbered lists... always use 1. and use indentation to create sub-bullets (let the rendering engine define the bullet numbers to use)
do not use empty lines between bullets

@chakkaradeep and @jackwi-alt  - we seriously need to set the example. It takes few mins to fill in the PR. Microsoft cannot have exception on the submissions if we expect others to follow our standard processes. Can you please fix this, thx.

Fixed.
From: Andrew Connell<EMAIL_ADDRESS>Sent: Wednesday, May 20, 2020 3:08 AM
To: SharePoint/sp-dev-docs<EMAIL_ADDRESS>Cc: Jack Wight (Steyer Associates Inc<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-docs] New article under Power Automate guidance (#5766)
Observations @chakkaradeephttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchakkaradeep&data=02|01|v-jwight%40microsoft.com|bd88a9b11eb647428c2208d7fca5a94a|72f988bf86f141af91ab2d7cd011db47|1|0|637255660752856273&sdata=%2FmeQVxKdSo2gV1h6DIY5AqDq9kuDRYftuxezamARlrY%3D&reserved=0 @jackwi-althttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjackwi-alt&data=02|01|v-jwight%40microsoft.com|bd88a9b11eb647428c2208d7fca5a94a|72f988bf86f141af91ab2d7cd011db47|1|0|637255660752856273&sdata=ywHdO3wXwGh%2FTygMrbUXXJhwTt72aeshUlWsTtiSmG4%3D&reserved=0 :

please complete the new PR template form
markdown formatting doesn't meet MSDOCS guidelines such as:
*   do not use explicit numbers in bullets for numbered lists... always use 1. and use indentation to create sub-bullets (let the rendering engine define the bullet numbers to use)
*   do not use empty lines between bullets

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSharePoint%2Fsp-dev-docs%2Fpull%2F5766%23issuecomment-631379111&data=02|01|v-jwight%40microsoft.com|bd88a9b11eb647428c2208d7fca5a94a|72f988bf86f141af91ab2d7cd011db47|1|0|637255660752866263&sdata=GIQ6htFhSb1rUYI3WuiNzLUESBC20dMYycseywAnKzM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOP3HNMKWBILJSTHTVBN6P3RSOTXTANCNFSM4NFIK6IA&data=02|01|v-jwight%40microsoft.com|bd88a9b11eb647428c2208d7fca5a94a|72f988bf86f141af91ab2d7cd011db47|1|0|637255660752866263&sdata=w1OwweqzcJHlqZjk6Fvbgh43tCMQKcZ8mc30G7GKvpQ%3D&reserved=0.


Expose some functions directly

Hi Scott, thank you very much for the awesome extension!
I am proposing in this PR to expose some kind of picker#File and picker#String functions directly...
Sometimes it is easier to call the functions directly, instead of using picker#Register & picker#Execute.

@abravalheri I recommend updating the docs and readme to document these functions.
I'm not a fan of exposing low level functions in the API, since that commits a project to implementation details that are substantially difficult to change later.  I've retained hope that neovim will eventually have a generic named pipe API that will allow vim-picker to write lists of data into the selector program via stdin instead of building a shell command with string parsing (see #24) and suffering errors from escape codes and expansions.
However, this change should provide a fix for #54 by allowing users to dynamically generate the list command.
Deferring to @srstevenson's judgement on the matter.

@boxofrox thank you very much for your comments and suggestions. Glad to see that the PR accidentally solves an existing issue :P
To be completely fair, the new API introduced (picker#File and picker#String) expose the exact same amount of information/low lever implementation details as picker#Register. They consume 2 of the same arguments, but instead of requiring a selection_type, this is informed directly in the name of the function... So, in a way, the APIs of picker#File and picker#String offers more or less the same level of commitment  to internal implementation as picker#Register.
But I agree with you. If you guys don't think the use case is common, it is better to keep the project as lean as possible and avoid future incompatibility.

To be completely fair, the new API introduced (picker#File and picker#String) expose the exact same amount of information/low lever implementation details as picker#Register.

Indeed, you are correct.  I withdraw my reservations.  Thanks for updating the docs.  LGTM :+1:
ping @srstevenson

Given the addition of these functions, I'm considering deprecating picker#Execute() and picker#Register()

I wholeheartedly agree.  I wasn't sure how to handle the deprecation smoothly for any users that've adopted those, but you've addressed that simply enough in #59.  Just rip the band-aid off and move along.  I don't see this happening again for a long while, if ever (knock on wood).
I've been facepalming about that feature since I overlooked dynamic generation of shell list commands with the custom user commands and am happy to see them replaced with this simpler and more versatile API.
Thanks for the PR @abravalheri

Awesome guys! Thanks a lot! Always happy to contribute.


Can't run minifer command

What's happened
After commit d407cd9675e8, I can't run minifier command.
Reproduction
git checkout d407cd9675
echo "console.log('hi')" >> a.js
cargo build --example minifier --release && ./target/release/examples/minifier ./target/a.js

Error occurs:
 Finished release [optimized] target(s) in 0.37s
<jemalloc>: Error allocating TSD
fish: Job 1, './target/release/examples/minif…' terminated by signal SIGABRT (Abort)

Also try the following:

cargo clean
remove from .cargo/config.toml

[build]
rustflags = ["-C", "target-cpu=native"]

Give me your rustup show, I have a feeling that you have misconfiguration somewhere ...

Lol as is turns out you are using x86_64-apple-darwin on your M1.


Trying to update a previously made Token, and add a new NFT.

Trying to update the decimal count from 0 to 9 for a previously made Token, and add a new NFT.
Everything looks good, other than the error for duplicate address for the token I previously made and was just updating.
https://github.com/abskurz/token-list
PR link https://github.com/solana-labs/token-list/pull/24684
Originally posted by @abskurz in https://github.com/solana-labs/token-list/issues/24684#issuecomment-1094304311

reopened with PR link


Move badge below title

For consistency with other languages

confirming via grep -C5 'travis-ci.org' ~/.gem/ruby/*/gems/trackler-*/tracks/*/README.md
Above h1:

C++

In h1:

C
Crystal
ECMAScript
Java
Javascript
Kotlin
TypeScript

Between h1 and text:

C#
Delphi
Elixir
Elm
F#
Go
Haskell
Julia
LFE
Lua
Nim
Perl6
PHP
Pony
Prolog
Python
Ruby
Rust

Below text:

Ceylon
Lisp

Yeah, sure, Ceylon and Lisp are in the minority here. It'd be great if we can hear an argument for why the new placement is good. For example "all contributors have a uniform place to look for when looking for build status" (emphasising the consistency) or "the status image is more important than the introductory text, so the image should go above the text" (emphasising the position, without regard to consistency)

By "Title" I was referring to the header tag # xceylon. I think the badge should be immediately below the title because, as you pointed out, the majority of other language tracks structure their READMEs like this. Consistency allows users to quickly parse a new Language's README for information. This is also how Standard Readme suggests structuring the README.

immediately below

I'm going to have to edit both the commit message and PR title to say that, since otherwise it's a no-op (the badge is already below the title). As well as amend the explanation into the commit message, otherwise one won't be able to see the explanation without internet access

Thanks!


Dictionary with optional keys

I believe there is currently no way to create a dictionary with optional keys, since Partial can't be applied to a Dictionary. All keys are required for a runtype Dictionary.
Is this a bug or known gap, or am I missing how to achieve this?
// this works
type PartialDict = { ["bar"]?: string } // or Partial<Record<"bar", string>>
const dict: PartialDict = {}  // ok

// Dictionary is equivalent to { ["bar"]: string | undefined }
const RuntypePartialDict = Dictionary(Optional(String), Literal("bar"))
type RuntypePartialDict = Static<typeof RuntypePartialDict>

const rdict: RuntypePartialDict = {}
// Error: Property 'bar' is missing in type '{}' but required in type '{ bar: string | undefined; }'.ts(2741)

For comparison, a Record with an Optional value allows the omission of the corresponding key. However, in a real world scenario, "bar" would be a set of keys which makes it difficult to just define the type as a Record.
const T = Record({ bar: Optional(String) })
type T = Static<typeof T>

const foo: T = {}  // ok

Hm, this should be a bug. Originally I just didn't intended Optional to be used within a dictionary, but it's a shame this doesn't work. We must support this.


position of pause/play button should be placed first

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
On the exemple of an accessible carousel with pause/play button, the button is placed behind carousel.
The good pratice of accessibility say that this button should be placed first to let users choose to pause or play it before the carousel.
Motivation and context
Users of assistives technologies need to have the choice to pause or play a carousel before receiving the information.

@Aniort thoughts?

Nice, excellent remark, we should raise an issue to correct ! @julien-deramond

Let's tackle it when we will try to introduce the play/pause button within the carousel.

After a discussion with designers, developers and a11y experts, we're going to integrate the play/pause button within the carousel before the carousel indicators. The target for this issue will be the v5.3.