[BUG]

Describe the bug
When starting the container I receive the following error:
2023-08-19 20:55:09,745 :: ERROR :: icloudpy.base :: base.py :: 186 :: Missing apple_id field
To Reproduce
Steps to reproduce the behavior:
Start container with docker compose up
Expected behavior
start of the container and run
Screenshots

Configuration
If applicable, please share the configuration details
app:
logger:
# level - debug, info (default), warning or error
level: "info"
# log filename icloud.log (default)
filename: "icloud.log"
credentials:
# iCloud drive username
username: "my-apple-id"
# Retry login interval - default is 10 minutes
retry_login_interval: 600
Drive destination
root: "icloud"
smtp:
## If you want to receive email notifications about expired/missing 2FA credentials then uncomment
# email<EMAIL_ADDRESS>## optional, to email address. Default is sender email.
# to<EMAIL_ADDRESS># password:
# host: "smtp.test.com"
# port: 587
# If your email provider doesn't handle TLS
# no_tls: true
region: global # For China server users, set this to - china (default: global)
drive:
destination: "drive"
remove_obsolete: false
sync_interval: 300
#filters: # Optional - use it only if you want to download specific folders.
# File filters to be included in syncing iCloud drive content
#folders:
#  - "folder1"
#  - "folder2"
#  - "folder3"
#file_extensions:
# File extensions to be included
#  - "pdf"
#  - "png"
#  - "jpg"

Login manually if ENV_ICLOUD_PASSWORD is not specified and/or 2FA is required
docker exec -it icloud /bin/sh -c "icloud --username=<icloud-username> --session-directory=/app/session_data"

I‘m sorry - apparently I forgot to mention, I have already used the ENV_ICLOUD_PASSWORD in my .env.icloud
Do I need to add a seperate ENV value for the appleid itself?

No. You don't need apple ID environment variable. It takes from the config.yaml file. Please still try manually logging in using below command:
docker exec -it icloud /bin/sh -c "icloud --username=<icloud-username> --session-directory=/app/session_data"
If it still doesn't work, please share your docker compose file.

Thanks for the feedback.
I managed to put in the command while the container was starting - it seems as it is doing something now - at least when I pull up docker container stats it shows the container being active every few seconds, before it was just stuck at 0.
Is there any way how I can verify if it is working or not?

Please share your docker-compose file. What you're experiencing is highly unusual.

I hope this helps to figure out was is going on...
I start the container either by using "docker compose up" directly in the folder or I use "docker container start icloud"
icloud-drive-docker.zip

To keep it simple, please try below configuration -
docker-compose.yaml
version: "3.4"
services:
  icloud:
    image: mandarons/icloud-drive
    env_file:
      - icloud.env #should contain ENV_ICLOUD_PASSWORD=<password>
    container_name: icloud
    restart: unless-stopped
    volumes:
      - /etc/timezone:/etc/timezone:ro
      - /etc/localtime:/etc/localtime:ro
      - ${PWD}/config.yaml:/app/config.yaml
      - ${PWD}/data:/app/icloud
      - ${PWD}/session:/app/session_data

For ENV_ICLOUD_PASSWORD, use your iCloud login password and not an app password.

I tried to login with those settings - also changed the password to my usual icloud password, the problem is I can't login as I have 2FA enabled - where do I put in my 2FA Code?

I also found the option how to change the directory where the data will be stored - already downloaded 5.5Gb - so apparently truly working.
Would be great if it would be possible to use a App-Password in the future - but I guess there still needs to be done some work if it's even possible.

This app pretends like a web client of iCloud.com. It is not registered with Apple. I think, you can use app passwords only with the apps that are registered with Apple through their developer account (which costs money).
Yes, it would be ideal to have this officially registered with Apple and using CloudKit API. It would unlock many possibilities. But that might also mean I will need to charge $$$ for this app to cover Apple's costs. I want to keep it free and open for everyone to use. Cheers!

Oh, didn't know that to be honest, completely understandable with that knowledge, can you tell me how long one login will last?
So how long until a new 2FA code is needed to be able to use the service again?
On another note, is the usage of the CloudKit API only bound to having a developer account or would you need to pay for that usage on top of it?

It will not ask for a new 2FA for at least a few weeks. If you configure SMTP settings in config.yaml, the app will send you email indicating 2FA is required.
Regarding Apple registered app - I quickly scanned through their developer API offerings and it doesn't seem like there is any that allows access to iCloud Drive and Photos outside of their ecosystem. Only way to access it is through iCloud.com on non-Apple devices. There is no web service I could find besides authentication (i.e. login with Apple) that is exposed on non-Apple devices. I might be missing something but wouldn't know without doing some prototypes with Apple dev account.
I don't think Apple charges extra to developer of app besides developer account for operations. They may charge for development activities like cloud hosted testing etc.

Ok thanks, I will configure the mail-settings so I get notified
About CloudKit - no worries, was just thinking about it 😊


why does the falcon 1 first stage have a totally different structure than other vehicles?

No good reason, probably should be the same for consistencies sake.

This is very similar to #53, we can add this to the list of things to accomplish in that issue 👍


[Proposal] : Parameterize the NotBefore validity of token for NTP sync issues more than 1 sec

I am using docker auth and has been working fine. Lately with AWS multi AZ setup and cross AZ load balancing, we observed that the time on the hosts was not in sync to the sec.
I understand from #41 and #59 that NotBefore flag cannot be made optional, however can we make the hardcoded 1 sec value optional/configurable from the config yaml file.
This will certainly help users like us where we are getting this issue despite the ntp configuration.
I have already tested the same from my fork and will generate the pull request shortly.
Please let me know your thoughts.

so, what value would you use? would, say, 3 seconds be enough? in that case we can just change the value.

In my case it was 8 secs. I am thinking having it configurable will allow users to decide. I have generated a pull request keeping default as 1. I can put an upper limit as well if you feel. But i guess keeping it us to user will help.

+1, think this should be parametrized, so that it is flexible for people to use as is.

8 seconds? this really doesn't sound right. properly working NTP should not get that far out of sync.
1 might be too tight, that's true.
let me think about it. we need to balance flexibility with proliferation of knobs.

in my experience, a machine with properly configured NTP will not get off by whopping 8 seconds, this just doesn't happen, unless the machine's RTC is misbehaving. it also sometimes happens after boot, when a machine that's been long off comes back. but in that case ntpdate during boot should bring it in sync before starting services.
so, i don't think we need a knob to control this.
that said, i'm willing to relax the threshold to 10 seconds, which should be more than enough. feel free to send me a PR to do that.

Submitted PR #76 for this.

i see, but it does more than i'm willing to accept. please squash it to one commit and leave just the 1 -> 10 seconds change.

Thanks for merging....One last question....when can we have the new image pushed to docker hub.

built and pushed to latest, will let it soak there for a few days before pushing to stable


Log invites by director

Save who is inviting who.
We need to know who accepted someone as a matter of collaboration between directors and organizers

Added field in application to see who invited an application. Merged #99


Remove babel-eslint in package.json

Remove "babel-eslint": "^10.1.0", from package.json to remove FE error on start.
The error is caused by babel-eslint being installed through devDependencies. It gets installed automatically as a dependency to react-scripts. So, if it gets installed as a devDependency as well, it will conflict.

It looks like this was fixed with this PR.
https://github.com/Lambda-School-Labs/story-squad-fe/pull/52/files


Migrate to Checkstyle 8.28

Demonstrating migration of Checkstyle.

Close as it has been merged into upstream.


localMode not working

Neither when trying to implement this nor the demo at: http://www.infinite-scroll.com/trigger.html

Implemented by @ryleyb, see https://github.com/paulirish/infinite-scroll/pull/106 for usage. (Its a behaviour)


Feature request: Add recipe to shopping list

Hi!
I would like to be able to add a recipe to the shopping list from the app. I think there is some space left on the recipe cards for an additional button. Perhaps a popup could be shown to select the shopping list to add to. What do you think? 😄

And to add to this... a button to start a recipe action would also be great. I just created an integration to add a recipe to my supermarkets shopping service using the recipe actions :)


fix missing support for inline images

Add missing support for inline property to be able to send inline images in messages. closes #140

@jbaranguan  Could you please fix merge conflicts, so I can merge the PR?


Could not parse action route

Environment
Nuxt project info:

Operating System: Windows_NT
Node Version:     v20.9.0
Nuxt Version:     3.8.0
CLI Version:      3.9.1
Nitro Version:    2.6.2
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, modules, googleFonts
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
Try to reproduce the example on https://form-actions-nuxt.pages.dev/usage/form-actions page.
Describe the bug
The following error is called :  ERROR  Cannot start nuxt:  Could not parse action route from C:\path\to\project\server\actions\login.ts
Additional context
No response
Logs
ERROR  Cannot start nuxt:  Could not parse action route from C:\path\to\project\server\actions\index.ts                                                                                18:26:01

  at getActionRoute (/C:\path\to\project/node_modules/.pnpm/@hebilicious+form-actions-nuxt@0.2.4_h3@1.8.2_nitropack@2.6.2_nuxt@3.8.0_vite@4.5.0_vue@3.3.7/node_modules/@hebilicious/form-actions-nuxt/dist/module.mjs:15:11)
  at /C:\path\to\project/node_modules/.pnpm/@hebilicious+form-actions-nuxt@0.2.4_h3@1.8.2_nitropack@2.6.2_nuxt@3.8.0_vite@4.5.0_vue@3.3.7/node_modules/@hebilicious/form-actions-nuxt/dist/module.mjs:159:27
  at async initNitro (/C:\path\to\project/node_modules/.pnpm/nuxt@3.8.0_vite@4.5.0/node_modules/nuxt/dist/index.mjs:2833:3)
  at async initNuxt (/C:\path\to\project/node_modules/.pnpm/nuxt@3.8.0_vite@4.5.0/node_modules/nuxt/dist/index.mjs:3684:3)
  at async NuxtDevServer._load (/C:\path\to\project/node_modules/.pnpm/nuxi@3.9.1/node_modules/nuxi/dist/chunks/dev2.mjs:255:5)
  at async NuxtDevServer.load (/C:\path\to\project/node_modules/.pnpm/nuxi@3.9.1/node_modules/nuxi/dist/chunks/dev2.mjs:187:7)
  at async NuxtDevServer.init (/C:\path\to\project/node_modules/.pnpm/nuxi@3.9.1/node_modules/nuxi/dist/chunks/dev2.mjs:182:5)
  at async Object.run (/C:\path\to\project/node_modules/.pnpm/nuxi@3.9.1/node_modules/nuxi/dist/chunks/dev-child.mjs:103:5)
  at async runCommand$1 (/C:\path\to\project/node_modules/.pnpm/nuxi@3.9.1/node_modules/nuxi/dist/shared/nuxi.c6444792.mjs:1647:7)
  at async runCommand$1 (/C:\path\to\project/node_modules/.pnpm/nuxi@3.9.1/node_modules/nuxi/dist/shared/nuxi.c6444792.mjs:1638:11)

I took the time to read the source code a bit and realized that your regex did not include Windows support.
I just adapted the two regex functions getActionRoute() and getLoaderRoute().
I also removed the ":" character from the virtual:loader-types.d.ts file and changed it with ".". I didn't find any usage reported in the module, don't hesitate to modify that if necessary. Just know, if you forgot or didn't know, that the ":" character is prohibited in Windows paths. Thanks Microsoft :)
Thank you in any case for this module and for the review of the PR ;)

Another problem detected yesterday but I didn't have time to report it. It's clear that this is a Windows compatibility issue and despite the time I've spent trying to find the problem, I don't know where it comes from.

The only thing I'm sure of is that it came from your library. I tried starting a new nuxt project with just your library and it threw the above error.
I'm available to answer your questions if needed.
Thank you for your time.

Hi Evan, I'll comment on your PR directly.

Hi Hebilicious,
I think that the second bug is strictly related to the first bug. I haven't saw in my console that the following warn was printed : " WARN  "Z:directpathtoprojectfolderwithoutantislashserveractionsindex.ts" is imported by "virtual:#internal/nitro/virtual/server-handlers", but could not be resolved – treating it as an external dependency."
After explored your package's folder inside my node_modules folder, the unique file that isn't correctly referenced by Windows is the file that you talked inside the PR.
Hope I can use your package correctly without having to switch on a Unix filesystems next time you release a new version including my "fix" haha !
Thanks for your time.
Regards


Overflow menu jumps on rendering in all browsers

Detailed description

Describe in detail the issue you're having.

On all browser, with the latest 2.0.7 release, I see that clicking on the overflow menu causes for the page to jump up and down and lose its position on the page.

Is this a feature request (new component, new icon), a bug, or a general issue?
Bug

Is this issue related to a specific component?
Overflow menu

What did you expect to happen? What happened instead? What would you like to see changed?
For the overflow menu to position properly and focus properly

What browser are you working in?
Chrome, firefox, IE

What version of the Carbon Design System are you using?
2.0.7

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
ADI

Additional Info
Here was a slack conversation from carbon-ng channel for other details.
https://ibm-systems-z.slack.com/archives/CBZC0LM2N/p1541805021153200
Additional information

Screenshots or code
Notes

Also since a recent update, we are noticing the overflow menu is displaying 1 row lower on our carbon Table with overflow menu.

I've added https://github.com/IBM/carbon-components-angular/issues/285 to cover some more issues i've noticed were recently introduced for the overflow menu, these issues look to be related.

I've got a fix for this incoming ... we were setting the focus before the component was positioned, which was jumping the page down


Connection Refused

hi
i keep getting below error for JC21
[Global   ] › ✖  error     connect ECONNREFUSED <IP_ADDRESS>:3306
whichever DB variant I try, I'm getting the same result:
connect ECONNREFUSED <IP_ADDRESS>:3306
i am using raspberry pi 4
pls advise

Your mysql server is not running so you'll need to inspect the logs for that container.
Alternatively, use the sqlite database option.

Thanks. Can you pls guid how to install sqlite db on the existing installation for raspberry pi 4.
I am new to linux and trying to learn. Sorry if i hav askd a weird question. FYI maria db works fine on raspberry pi 4. Just the jc21 proxy manager giving trouble.

The docker-compose files in the setup instructions contain all information you need. You just need to remove the DB_MYSQL_... environment variables and add the DB_SQLITE_FILE variable.

thanks.
the suggestions you gave me to use sql-lite worked and is working well.
🙏🙏
On Sat, Aug 7, 2021 at 12:04 PM chaptergy @.***> wrote:

The docker-compose files in the setup instructions
https://nginxproxymanager.com/setup/ contain all information you need.
You just need to remove the DB_MYSQL_... environment variables and add
the DB_SQLITE_FILE variable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jc21/nginx-proxy-manager/issues/1291#issuecomment-894622276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJSI5M3JIZ55CL3FJTJL77DT3TSKNANCNFSM5BVSVN4A
.

Good Day again
after setting username and password on nginx i logged out and tried to
login using new email and password but couldnt login.
is there a way to reset password.
pls advise.
thanks
On Sat, Aug 7, 2021 at 9:50 PM Yankie ddl @.***> wrote:

thanks.
the suggestions you gave me to use sql-lite worked and is working well.
🙏🙏
On Sat, Aug 7, 2021 at 12:04 PM chaptergy @.***>
wrote:

The docker-compose files in the setup instructions
https://nginxproxymanager.com/setup/ contain all information you need.
You just need to remove the DB_MYSQL_... environment variables and add
the DB_SQLITE_FILE variable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jc21/nginx-proxy-manager/issues/1291#issuecomment-894622276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJSI5M3JIZ55CL3FJTJL77DT3TSKNANCNFSM5BVSVN4A
.

See https://github.com/jc21/nginx-proxy-manager/issues/230. Maybe your password contained a hash (#), don't add a hash to the password (https://github.com/jc21/nginx-proxy-manager/issues/1120).

thanks for prompt response.
apologize again. i am not used to the terminology. how do i connect to
database and run the script UPDATE user SET is_deleted=1;?
thanks
On Sun, Aug 8, 2021 at 3:06 PM chaptergy @.***> wrote:

See #230 https://github.com/jc21/nginx-proxy-manager/issues/230. Maybe
your password contained a hash (#), don't add a hash to the password (
#1120 https://github.com/jc21/nginx-proxy-manager/issues/1120).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jc21/nginx-proxy-manager/issues/1291#issuecomment-894780621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJSI5M2SVFHEG5KV6CLH6R3T3ZQK3ANCNFSM5BVSVN4A
.

I have changed my comment to include a link to a specific comment which explains step by step what to do.

thanks.
after first command it asked me enter root password. i tried all but none
works. it keeps giving me following error. pls note i am using sqlite and
not MYSQL
$ sudo  docker exec -it nginx_db_1 sh
/ # mysql -u root -p
Enter password:
ERROR 2002 (HY000): Can't connect to local MySQL server through socket
'/run/mysqld/mysqld.sock' (2)
/ #
On Sun, Aug 8, 2021 at 4:08 PM chaptergy @.***> wrote:

I have changed my comment to include a link to a specific comment which
explains step by step what to do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jc21/nginx-proxy-manager/issues/1291#issuecomment-894787931,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJSI5MY6JHL4ULPGPTOSONDT3ZXTBANCNFSM5BVSVN4A
.

I forgot that you are using the sqlite file, not the mysql database. You don't even need the mysql container anymore, you can remove it from the docker-compose.
You will have to edit the database file you specified in the docker-compose using a tool like SQLite Browser. Change to the user table, and set is_deleted to 1. Then follow step 2 and 3, and at the end, set it to 0 again.
If you haven't done much yet it might be easier to just delete the containers and the volumes and just start again.

I can also recommend using litecli for connecting to sqlite db's.


Intl not served to Sogou Explorer 1.0

We're seeing errors from users who are not getting the Intl polyfill in Sogou Explorer 1.0.  Sentry reports this for the User-Agent:
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.22 Safari/537.36 SE 2.X MetaSr 1.0

I'll happily put together a pull request, but I'm uncertain how this browser name might appear in the config.json.

To see how we parse the UA for a browser, you can use the ua param:
https://polyfill.io/v2/polyfill.js?ua=Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.22 Safari/537.36 SE 2.X MetaSr 1.0

This means that currently we recognise this browser as its own family - sogou explorer, and we have no polyfills for it.  The easiest solution is to create an alias to an existing browser family, but I don't think there's a version-compatible mapping to another browser.  Do you know anyone from Sogou who might be able to help here?

OK, in the absence of interest from Sougou, the only thing we can suggest is to use the unknown attribute to change the policy you want to apply to unknown browsers.  unknown=polyfill will serve all the polyfills to the unknown browser.


Update alert contract deployment script

Also check that verify correctly posts alerts.

verify successfully alerted:
https://stellar.expert/explorer/testnet/contract/CBCBPQGGHU3KF37KMVSXROYHHRO2PHCTOPV2CC4GRE6P3HAFMH5BHK2K

See #103


add ServiceAccount kube type support

What does this PR do?
Adds a new Kubernetes type
Why is it important?
Cloudbeat's kube fetcher will need to have this type supported.

see: https://github.com/elastic/beats/pull/31122

@cmacknz I need to be an approved contributor here also

I've added the cloud posture security team with write permissions here. Probably the state won't refresh so I'll start the build manually.


5.x.x/scene item request tests

@ChristopheCVB i wont, just wanted to wait for the PR to get merged

@ChristopheCVB Updated the list in #74


New release 140

Cutting a new release since we're breaking stored passwords compatibility with this upgrade.

Also mention dropping support for Python 2.6 and 3.3?


Add new instance type snow supports

Issue #, if available:
Part 1 of https://github.com/aws/eks-anywhere/issues/4880
Description of changes:
Add instance types snowball newly supports.
Testing (if applicable):
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

/cherrypick release-0.14


[WIP] add exception trace to error messages

You can run this by starting python scripts/shell.py and running
>>> example_functions.throw_exception()

Currently, the message printed here is not useful. If we start python scripts/shell.py and call example_functions.throw_exception(), it basically prints something like
Traceback (most recent call last):
  File "/Users/rkn/Workspace/ray/lib/python/ray/worker.py", line 278, in process_task
    outputs = worker.functions[func_name].executor(arguments) # execute the function
  File "/Users/rkn/Workspace/ray/lib/python/ray/worker.py", line 313, in func_executor
    result = func(*arguments)
  File "/Users/rkn/Workspace/ray/scripts/example_functions.py", line 25, in throw_exception
    raise Exception("This function intentionally failed.")
Exception: This function intentionally failed.


Question: Any appetite at Valve to maintain an official Godot plugin?

@lakulish I have a proof-of-concept Godot Steam-Audio repo that I hope to expand to a fully featured plugin when I get time. However, I work full-time outside the games industry and generally just get cycles to tinker here and there in my spare time. And given recent events at Unity, there's an influx of new users to Godot and some have expressed an interest for Steam-Audio support. Has Valve thought of officially supporting the engine with their own release? I suspect demand may go up over the next few months.

I am also asking for the same thing.

@jams3223 check out https://github.com/stechyo/godot-steam-audio

@jams3223 check out https://github.com/stechyo/godot-steam-audio

I just discovered it, we need to help this guy out.


[NTR] add CCD sensor binning read mode setting

Preferred term label
CCD sensor binning read mode setting
Synonyms
Textual definition
A setting datum that specifies the binning read mode of a device with a CCD sensor.
Suggested parent term
IAO:setting datum
Examples
Attribution
ORCID:0000-0002-1595-3213

This issue was created retrospectivly to have a term tracker item to link to within the ontology, for future discussions about and the tracking of possible changes of this term.


Develop to master

GitGuardian's results are false positives for us. The Access tokens there are not useful.


Nonprofit Projects

Hello, it's been 6 days since I contacted @CodeNonprofit by writing an email to<EMAIL_ADDRESS>(as seen in his github profile) and still no answer.
This was the original issue post https://github.com/FreeCodeCamp/FreeCodeCamp/issues/9787
Is there any other way to contact him?

Hi @ucshadow apologies for the delay in getting back. Michael normally responds to his emails very fast, not sure if he is away/busy with something.
We will get back to you asap.

Hi @ucshadow,
Thank you for filing an issue. In the email @BerkeleyTrue gave you, Michael is spelled wrong. I have not received your email. Please forward to<EMAIL_ADDRESS>and I will get back to you today.

@ucshadow Additionally, you should have received an email from us after receiving all 3 certifications. If you did not receive this email, you do not have an email address on file with Free Code Camp. This outlines the next steps for the nonprofit projects.

@ucshadow please follow as directed. Closing as resolved.


MySQLDatabase returns different results to MySQLPDODatabase

Affected Version
Affects "silverstripe/framework": "4.4.1"
Description
Using DB::query("") returns different results when using the different adapters.
Steps to Reproduce
The query being run inside of DB::query(""):
SELECT SiteTreeLocalised.ID, SiteTreeLocalised.RecordID
FROM `SiteTree_Localised` SiteTreeLocalised
    LEFT OUTER JOIN `ContentReviewLog` ContentReviewLog
        ON ContentReviewLog.SiteTreeID = SiteTreeLocalised.RecordID
    LEFT OUTER JOIN (
                   SELECT MAX(iContentReviewLog.ID) as ID,
                   MAX(iContentReviewLog.Created) as Latest,
                   iContentReviewLogLocalised.Locale as Locale
                   FROM `ContentReviewLog` iContentReviewLog
                          LEFT JOIN `ContentReviewLog_Localised` iContentReviewLogLocalised
                            ON iContentReviewLog.id = iContentReviewLogLocalised.RecordID
                   GROUP BY iContentReviewLogLocalised.Locale, iContentReviewLog.SiteTreeID) CRL_NEW
        ON CRL_NEW.ID = ContentReviewLog.ID
WHERE SiteTreeLocalised.NextReviewDate IS NOT NULL
  AND SiteTreeLocalised.NextReviewDate <= '2019-06-24 00:00:00'
  AND CRL_NEW.Locale = SiteTreeLocalised.Locale
  AND ContentReviewLog.Created >= SiteTreeLocalised.NextReviewDate
  OR SiteTreeLocalised.NextReviewDate IS NULL

A backup of the tables of the database:
# ************************************************************

/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
/*!40101 SET NAMES utf8 */;
SET NAMES utf8mb4;
/*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0 */;
/*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */;
/*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;

# Dump of table ContentReviewLog
# ------------------------------------------------------------

DROP TABLE IF EXISTS `ContentReviewLog`;

CREATE TABLE `ContentReviewLog` (
  `ID` int(11) NOT NULL AUTO_INCREMENT,
  `ClassName` enum('App\\Models\\ContentReviewLog') COLLATE utf8mb4_unicode_ci DEFAULT 'App\\Models\\ContentReviewLog',
  `LastEdited` datetime DEFAULT NULL,
  `Created` datetime DEFAULT NULL,
  `Note` mediumtext COLLATE utf8mb4_unicode_ci,
  `ReviewerID` int(11) NOT NULL DEFAULT '0',
  `SiteTreeID` int(11) NOT NULL DEFAULT '0',
  PRIMARY KEY (`ID`),
  KEY `Created` (`Created`),
  KEY `ClassName` (`ClassName`),
  KEY `ReviewerID` (`ReviewerID`),
  KEY `SiteTreeID` (`SiteTreeID`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

LOCK TABLES `ContentReviewLog` WRITE;
/*!40000 ALTER TABLE `ContentReviewLog` DISABLE KEYS */;

INSERT INTO `ContentReviewLog` (`ID`, `ClassName`, `LastEdited`, `Created`, `Note`, `ReviewerID`, `SiteTreeID`)
VALUES
	(1,'App\\Models\\ContentReviewLog','2019-06-24 01:16:08','2019-06-24 01:16:08','Reviewed',1,4),
	(2,'App\\Models\\ContentReviewLog','2019-06-24 01:16:13','2019-06-24 01:16:13','Reviewed',1,8);

/*!40000 ALTER TABLE `ContentReviewLog` ENABLE KEYS */;
UNLOCK TABLES;

# Dump of table ContentReviewLog_Localised
# ------------------------------------------------------------

DROP TABLE IF EXISTS `ContentReviewLog_Localised`;

CREATE TABLE `ContentReviewLog_Localised` (
  `ID` int(11) NOT NULL AUTO_INCREMENT,
  `RecordID` int(11) NOT NULL DEFAULT '0',
  `Locale` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `Note` mediumtext COLLATE utf8mb4_unicode_ci,
  PRIMARY KEY (`ID`),
  UNIQUE KEY `Fluent_Record` (`RecordID`,`Locale`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

LOCK TABLES `ContentReviewLog_Localised` WRITE;
/*!40000 ALTER TABLE `ContentReviewLog_Localised` DISABLE KEYS */;

INSERT INTO `ContentReviewLog_Localised` (`ID`, `RecordID`, `Locale`, `Note`)
VALUES
	(1,1,'en_NZ','Reviewed'),
	(2,2,'zh_CN','Reviewed');

/*!40000 ALTER TABLE `ContentReviewLog_Localised` ENABLE KEYS */;
UNLOCK TABLES;

# Dump of table SiteTree_Localised
# ------------------------------------------------------------

DROP TABLE IF EXISTS `SiteTree_Localised`;

CREATE TABLE `SiteTree_Localised` (
  `ID` int(11) NOT NULL AUTO_INCREMENT,
  `RecordID` int(11) NOT NULL DEFAULT '0',
  `Locale` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `LastEdited` datetime DEFAULT NULL,
  `Created` datetime DEFAULT NULL,
  `NextReviewDate` date DEFAULT NULL,
  `DesiredPublishDate` datetime DEFAULT NULL,
  `DesiredUnPublishDate` datetime DEFAULT NULL,
  `PublishOnDate` datetime DEFAULT NULL,
  `UnPublishOnDate` datetime DEFAULT NULL,
  `Title` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `MenuTitle` varchar(100) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `Content` mediumtext COLLATE utf8mb4_unicode_ci,
  `MetaDescription` mediumtext COLLATE utf8mb4_unicode_ci,
  `ReportClass` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `PublishJobID` int(11) NOT NULL DEFAULT '0',
  `UnPublishJobID` int(11) NOT NULL DEFAULT '0',
  PRIMARY KEY (`ID`),
  UNIQUE KEY `Fluent_Record` (`RecordID`,`Locale`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

LOCK TABLES `SiteTree_Localised` WRITE;
/*!40000 ALTER TABLE `SiteTree_Localised` DISABLE KEYS */;

INSERT INTO `SiteTree_Localised` (`ID`, `RecordID`, `Locale`, `LastEdited`, `Created`, `NextReviewDate`, `DesiredPublishDate`, `DesiredUnPublishDate`, `PublishOnDate`, `UnPublishOnDate`, `Title`, `MenuTitle`, `Content`, `MetaDescription`, `ReportClass`, `PublishJobID`, `UnPublishJobID`)
VALUES
	(1,1,'en_NZ','2019-06-24 01:16:04','2019-06-24 01:16:03','2019-06-17',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Shouldn\'t show',NULL,0,0),
	(2,2,'en_NZ','2019-06-24 01:16:05','2019-06-24 01:16:04','2019-07-01',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Shouldn\'t show because next week',NULL,0,0),
	(3,3,'en_NZ','2019-06-24 01:16:06','2019-06-24 01:16:06',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Should show because has no review',NULL,0,0),
	(4,4,'en_NZ','2019-06-24 01:16:08','2019-06-24 01:16:07','2019-05-24',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Should show because has review since that date',NULL,0,0),
	(5,5,'zh_CN','2019-06-24 01:16:09','2019-06-24 01:16:08','2019-06-17',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Shouldn\'t show',NULL,0,0),
	(6,6,'zh_CN','2019-06-24 01:16:10','2019-06-24 01:16:10','2019-07-01',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Shouldn\'t show because next week',NULL,0,0),
	(7,7,'zh_CN','2019-06-24 01:16:12','2019-06-24 01:16:11',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Should show because has no review',NULL,0,0),
	(8,8,'zh_CN','2019-06-24 01:16:13','2019-06-24 01:16:12','2019-05-24',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'Should show because has review since that date',NULL,0,0);

/*!40000 ALTER TABLE `SiteTree_Localised` ENABLE KEYS */;

When you run the query:

Against MySQL directly you get a count of 4,
Against MySQLPDODatabase you get a count of 4
Against MySQLDatabase you get a count of 3

MySQLPDODatabase result:
result = {array} [4]
 3 = "Should show because has no review"
 4 = "Should show because has review since that date"
 7 = "Should show because has no review"
 8 = "Should show because has review since that date"

MySQLDatabase result:
result = {array} [3]
 3 = "Should show because has no review"
 7 = "Should show because has no review"
 8 = "Should show because has review since that date"

At a guess this relates to the date comparisons. Try this alternate query and see what's returned to shed some light on it.
SELECT SiteTreeLocalised.ID, SiteTreeLocalised.RecordID, SiteTreeLocalised.NextReviewDate,  '2019-06-24 00:00:00' as compared_to, (SiteTreeLocalised.NextReviewDate <= '2019-06-24 00:00:00') AS comparsion_result
FROM `SiteTree_Localised` SiteTreeLocalised
    LEFT OUTER JOIN `ContentReviewLog` ContentReviewLog
        ON ContentReviewLog.SiteTreeID = SiteTreeLocalised.RecordID
    LEFT OUTER JOIN (
                   SELECT MAX(iContentReviewLog.ID) as ID,
                   MAX(iContentReviewLog.Created) as Latest,
                   iContentReviewLogLocalised.Locale as Locale
                   FROM `ContentReviewLog` iContentReviewLog
                          LEFT JOIN `ContentReviewLog_Localised` iContentReviewLogLocalised
                            ON iContentReviewLog.id = iContentReviewLogLocalised.RecordID
                   GROUP BY iContentReviewLogLocalised.Locale, iContentReviewLog.SiteTreeID) CRL_NEW
        ON CRL_NEW.ID = ContentReviewLog.ID
WHERE SiteTreeLocalised.NextReviewDate IS NOT NULL
  AND CRL_NEW.Locale = SiteTreeLocalised.Locale
  AND ContentReviewLog.Created >= SiteTreeLocalised.NextReviewDate
  OR SiteTreeLocalised.NextReviewDate IS NULL

Other comment I would make is that  CRL_NEW.Locale = SiteTreeLocalised.Locale should probably be moved from the "where" clause to the "on" clause of CRL_NEW.
It's not clear why that would work one way in PDO another in mysqli, but it's a dodgy filter (if CRL_NEW.Locale is null, then the comparison will fail, meaning that the row will be excluded, turning CRL_NEW into an effective inner join, which I assume is not the design goal)

Thanks for the set of assets - i've been unable to replicate this, sorry

Closing issue as diving deeper it looks like this is caused by the rewind function on the iterator for MySQLQuery. Will raise a new bug with the issues more documented


Remove custom control plane bootstrap

This isn't really needed, it can just go through the same code path as a
normal workload. The only "weird" thing here is that these are yaml
files, so I added some special logic to handle this.
For https://github.com/istio/istio/issues/21222

https://github.com/istio/istio/pull/11212 was the origin. Looks like we wanted to support custom template files, but this broke the control planes which were already using incompatible template files at the time


Redirect on Action

Thanks for your work and the great tool - saved a lot of time!
Yet I encountered one issue, where I´m actually not sure if it can be resolved at all. I have an Action that in some cases returns a Redirect action like this:
return Action::redirect(url('/resources/xxx/' . $related->id));
This redirect is not working when calling the action via your button, on the action menu and the inline actions it works fine.
When I return a message like:
return Action::danger('Not allowed!');
it is displayed correctly, also the button switches to "success"
Is there any way to make the redirect work?
Thanks!
Bastian

I think such a thing can be build it, i could try it when i have some spare time on my hands, else feel free to make a PR.

@itbul support for redirects added in v1.0.19

Great, thanks a lot for adding this!

@itbul you can thank @marcorivm who added it


chore: add lock threads robot config

ref #2889
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: add lock threads robot config

What is the current behavior?

Issue Number: #2889
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Add Chinese to the description?


Change the RawKey class from Iso to Lens'

We currently have
class RawKey a where
  rawKey :: Iso a ByteString

but we really don't ever use the from rawKey :: RawKey a => ByteString -> a method at all. We should change the class to
class RawKey a where
  rawKey :: a -> ByteString

Might this create a problem with #254 though? I assume currently we never read key bytes from store and deserialize into the type, but when iterating through the Map presumably we would need to be able to turn those bytes back into keys.

Might this create a problem with #254 though? I assume currently we never read key bytes from store and deserialize into the type, but when iterating through the Map presumably we would need to be able to turn those bytes back into keys.


systemd: fix build on musl

Description of changes
disabling systemd-boot for now
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Hm I guess someone broke master. :D

Broken by https://github.com/NixOS/nixpkgs/pull/229186.

Triggering eval after it was fixed on master.
@ofborg eval


[Bug] : There is nothing inside Programming Fundamentals section, adding fundamentals.

🐛 Bug Report
Describe the bug
The Programming Fundamentals section is empty or incomplete, lacking any relevant content or documentation. This creates confusion and doesn't provide the necessary information.
To Reproduce
Steps to reproduce the behavior:

Go to the 'Programming Fundamentals' section.
Click on it to view the content.
Notice that there is no information or content inside the section.

Expected behavior
The Programming Fundamentals section should contain comprehensive information on basic programming concepts such as variables, loops, conditionals, functions, and data structures.
Additional context
This section is crucial for beginners, so it needs to be populated with well-structured, beginner-friendly content and examples for a variety of programming languages.
Would you like to work on this issue?

[x] Yes
[ ] No

Hello @ajay-dhangar ,
I am interested in this issue. Could you please assign it to me? Thank you!

Thank you for your interest in working on this issue. @Ruksina01 and @AbhijitMotekar99, this issue has several different topics that need to be addressed. Please let me know which topics you would like to work on.

@ajay-dhangar ,
I understand that the course topics are vast, so I think starting with these foundational concepts is the best approach.
Topics such as variables, loops, and conditionals.
I wanted to clarify in what format I should present these topics. Should I choose a specific programming language to focus on, or would an overview of these concepts suffice?

Hey @ajay-dhangar
In the programming fundamentals section, I will be working on basic programming concepts such as variables, loops, conditionals, functions, and data structures.


Dev configuration

As some values are hardcoded, it's complex to dev locally.
https://github.com/cenotelie/cratery/blob/main/src/model/config.rs#L441

No remaining hard-coded path on the file system. All paths can be configured through the environment.


Implementing SSL Pinning with Flutter GraphQL

Hi there,
I'm trying to implement SSL Pinning using your library with another library called http_certificate_pinning. The issue is gqlClient always returned connection secure even if the allowedSHAFingerprints is not valid.
Here's my stackoverflow question to help you see my code: link
Thank you.

Please provide some more details on what you're expecting vs what you're seeing and a reproducible example.

I'm expecting gqlClient throwing error on query perform here:
final secureClient = GetIt.I<Service>().gqlClient;
final options = QueryOptions(
  document: gql(homePageQuery),
);
final result = await secureClient.query(options);

Because I set the wrong allowedSHAFingerprints on class Service constructor
The actual result is connection success and it fired a snackbar like in my code above.

Alright, so this is really a problem with how the HttpLink (gql_http_link) works with the secure secureClient.
If you have a look at the HttpLink implementation, you'll notice that it's calling .send on the provided HTTP client https://github.com/gql-dart/gql/blob/master/links/gql_http_link/lib/src/link.dart#L169. Now,  the secure client doesn't implement any checking for the send method: https://github.com/diefferson/http_certificate_pinning/blob/master/lib/src/http_client/secure_http_client.dart#L63.
It seems like you have two options:

Change the implementation in either gql_http_link or http_certificate_pinning.
Implement your own link.

Personally, I'd go for the second option.
Regardless, this is not a bug in this package, so I'll close the issue. I hope you find a solution and please feel free to share it here if you do!

Finally solved this problem.
I'm using dio and another library called gql_dio_link
Here's my implementation of Service class now:
import 'package:dio/dio.dart';
import 'package:gql_dio_link/gql_dio_link.dart';
import 'package:graphql_flutter/graphql_flutter.dart';
import 'package:http_certificate_pinning/http_certificate_pinning.dart';

class Service {
  final List<String> _allowedSHAFingerprints;

  late GraphQLClient _secureGqlClient;
  GraphQLClient get secureGqlClient => _secureGqlClient;

  late Dio _secureDioClient;
  Dio get secureDioClient => _secureDioClient;

  Service(this._allowedSHAFingerprints) {
    _secureDioClient = Dio(BaseOptions(baseUrl: 'https://dummy.com'))
      ..interceptors.add(CertificatePinningInterceptor(
          allowedSHAFingerprints: _allowedSHAFingerprints));

    final link = Link.from([
      DioLink(
        '/graphql',
        client: _secureDioClient,
      ),
    ]);

    _secureGqlClient = GraphQLClient(
      link: link,
      cache: GraphQLCache(),
    );
  }
}

@serpentarius-hollow thanks for sharing your solution!

Thinking if we should create a Q&A document to include all these solutions, looks like that dio solve different problems for graphql_flutter.
What do you think?


ipvsadm compile fails, sometimes.

Had a report, by way of #25 that the make -j$CPU bits of (at least) the ipvsadm compilation script cause issues on certain stemcells.  I think it might be more related to the number of cores on any 315+ Xenial stemcell, but we ought to investigate.

Fixed in #25


Fix #34

Fixes the issue about contacts not showing up, but still leaving #36 as a follow-up issue.
Here's a screenshot from the fix-34 branch:

Fix added here
https://github.com/pondersource/oc-sciencemesh/pull/37/

@parhamin2010 I think your last two comments were about #37, not about this PR, right?

@michielbdejong Yes correct.


Revise tech docs in README to favour GOV.UK Docker

This makes several changes to refactor and revise the README to better match our other repos. The end result follows the pattern established in https://github.com/alphagov/content-publisher/pull/2257. See the commit messages for more details.
Trello Card

Thanks @benthorner, I think I've addressed all your comments now.

@thomasleese I realised the changes here aren't quite accurate, as this is one of the few apps GOV.UK Docker doesn't fully support. To help you out I've raised a couple of PRs to add the support in - see here and here.
Would you like to review those?
You also had some bad luck that the Imminence isn't supported either. What would you like to do there?

You also had some bad luck that the Imminence isn't supported either. What would you like to do there?

Hmm interesting. I don't think I'm going to have the time to get imminence working with GOV.UK Docker - perhaps we should revert my PR which changed the readme for now until we've figured out a way forward?

That's fair. It's somewhat out-of-scope for the README changes. I decided I'd like to get it working, so here's a couple of PRs to do that. Would you like to review them?

https://github.com/alphagov/govuk-docker/pull/475
https://github.com/alphagov/imminence/pull/632


Using IR and calorimetry for a low-cost haemoglobin measurement device for low resource settings

This project aims to generate a low-cost haemoglobin measurement device for low resource settings.
Contact: Kyata Chibalabala (kc461)

Hi ! Our team is gong to apply to develop a device measuring protein fluorescence. In the end we would like to be able to measure whole blood samples and potentially would be facing same issues as the haemoglobin device designers. Would be nice to work together and share resources and knowledge<EMAIL_ADDRESS>


Update documentation

Read the notes in this ticket for this change! Our PRs now have a canary version too, which you can see attached to this PR!

Update CONTRIBUTING.md to reflect versioning and pushing to the package repository is handled by a github action
Update readme with details for installing from the github package repository

📦 Published PR as canary version: 0.19.2-canary.129.5cb491f.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.20.0 :rocket:


Native module cannot be null - have added swift file and created bridging header

Configuration
System:
OS: macOS 10.15.1
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Memory: 2.75 GB / 32.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 10.17.0 - /usr/local/bin/node
npm: 6.11.3 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 26, 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>77832
Xcode: 11.2/11B52 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-track-player version: 1.1.8
Issue
Created a fresh build using react-native init and installed react-native-track-player. Added the swift file to create the bridging header file. Built app and the app runs but have the issue "Native module cannot be null".
Swift language version is 4.2
If I update pods the app no longer builds and produces the error "redefinition of module 'react_native_track_player'"
Should I still be linking and updating the pods or is this where the error is coming from?
Really appreciate any help - had an app working with react-native-track-player but needed to create a new one and now have this issue. Thanks!

Thank you @waqas19921 Your comment fixed my issue! https://github.com/react-native-kit/react-native-track-player/issues/503#issuecomment-513427501.


Not working in IE Edge

Hi all,
In IE Edge, i am getting the following error Unable to get property 'Paragraphs' of undefined or null reference after i installed this plugin.

Which language in the editor you are using?

Greek an english. Please have in mind that i have installed all the languages inckeditor.
Thanks in advanced.

at least with the latest version i can not reproduce the problem. the only explanation is that the language file for the plugin is missing.


move search.md

Investigating whether the site should use the same placement of the search page as the Docsy theme.
The Docsy theme sample site lists search.md directly under content/en.
With this change, the search page no longer displays as a docs page.
This also helps to clean up single files from docs/.

/assign

/lgtm
Pinging @celestehorgan for approval
/assign @celestehorgan

@kbhawkey Please remove the [wip] if you are okay for this to be merged.

Let me look at this again for a few minutes. My main reason for starting this change was to remove the search file
from the docs root (and prevent the file from displaying in the local build) and investigate whether the search bar
could be moved around.

Just so you know, GitHub is struggling (at the moment) to render this PR's changes.
I plan to check again when things are healthier there.

https://deploy-preview-23083--kubernetes-io-master-staging.netlify.app/search/?q=kubectl

Tangentially: After this merges, I'd like to investigate whether it's possible to render a prettier results page. That may well be an upstream issue.
Leaving approve to another chair/tech lead, but otherwise:
/lgtm

/approve
Thanks for the improvement!


Update for new strings and tidy

Add in the new missing strings and get rid of the unnecessary extra linebreaks.
Thanks Nammi for reminding me.

Thanks merged!


Adding "The Road to learn React"

Free ebook to learn plain React while building on larger application on 200 pages. At this point in time, it was downloaded by ~13.000 people and I hope it is a great addition for newcomers to React :)

Wow! Thanks for sharing this ebook!


Excuse me,I dont touch Linux System.Can Windows System run your code?I find 'stty' in progressbar.py is not available.

Comment progressbar related code in solver.py, and just directly use print function(already provided).


chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.27.2

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.26.5 -> v1.27.2

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.27.2
Compare Source
Bug Fixes

deps: update module github.com/ibm/platform-services-go-sdk to v0.56.3 (#749) (2f431a0)

v1.27.1
Compare Source
Bug Fixes

deps: update module github.com/ibm/platform-services-go-sdk to v0.56.2 (#747) (d6dbbcb)

v1.27.0
Compare Source
Features

delete iam policy (#745) (82603f4)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix date

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

@mistyhacks ?

@mistyhacks

WTF how does it keep getting conflicts?

Not sure what happened here but this is now merged...


React UI: Add better docs for the React UI

Signed-off-by: Julius Volz<EMAIL_ADDRESS>

@boyskila @hooten

In overall looks pretty good :)


Missing saleor-signature header produces TypeError

It is probably a small thing, but when an App receives a webhook request without a saleor-signature header, the TypeError is raised (and 500 is returned):
error - TypeError: Cannot read properties of undefined (reading 'split')
It happens when withWebhookSignatureVerified is used.

Assuming that app developer put withWebhookSignatureVerified in his/her code, we should, in a situation that signature is not available, return 400 BAD REQUEST here.


crash on android launchImageLibrary when WRITE_EXTERNAL_STORAGE denied and resize

Description
App crashes, no logs from react native
instead, from adb logcat
11-18 15:01:27.119 10381 10381 E AndroidRuntime: java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=13002, result=-1, data=Intent { dat=content://media/external/images/media/34633 flg=0x1 }} to activity {com.PanDi/com.pandi.MainActivity}: java.lang.NullPointerException: uri
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.ActivityThread.deliverResults(ActivityThread.java:4398)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.ActivityThread.handleSendResult(ActivityThread.java:4440)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:49)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1816)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:193)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6718)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: Caused by: java.lang.NullPointerException: uri
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.android.internal.util.Preconditions.checkNotNull(Preconditions.java:128)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.content.ContentResolver.query(ContentResolver.java:786)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.content.ContentResolver.query(ContentResolver.java:753)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.content.ContentResolver.query(ContentResolver.java:711)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.imagepicker.Utils.getResponseMap(Utils.java:308)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.imagepicker.ImagePickerModule.onImageObtained(ImagePickerModule.java:130)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.imagepicker.ImagePickerModule.onActivityResult(ImagePickerModule.java:161)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.facebook.react.bridge.ReactContext.onActivityResult(ReactContext.java:308)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.facebook.react.ReactInstanceManager.onActivityResult(ReactInstanceManager.java:758)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.facebook.react.ReactDelegate.onActivityResult(ReactDelegate.java:90)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:112)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:68)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.Activity.dispatchActivityResult(Activity.java:7462)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	at android.app.ActivityThread.deliverResults(ActivityThread.java:4391)
11-18 15:01:27.119 10381 10381 E AndroidRuntime: 	... 11 more
11-18 15:01:27.129  2421  2728 D SurfaceFlinger: duplicate layer name: changing Surface(name=345d5db StatusBar)/@0xc3843f1 - animation-leash to Surface(name=345d5db StatusBar)/@0xc3843f1 - animation-leash#1
11-18 15:01:27.135  3392  3808 W ActivityManager:   Force finishing activity com.PanDi/com.pandi.MainActivity
11-18 15:01:27.148  3392  5390 I OpenGLRenderer: Initialized EGL, version 1.4
11-18 15:01:27.148  3392  5390 D OpenGLRenderer: Swap behavior 2
11-18 15:01:27.152 10381 10381 I Process : Sending signal. PID: 10381 SIG: 9
11-18 15:01:27.172  3392  5390 D mali_winsys: EGLint new_window_surface(egl_winsys_display*, void*, EGLSurface, EGLConfig, egl_winsys_surface**, egl_color_buffer_format*, EGLBoolean) returns 0x3000,  [1218x934]-format:1
11-18 15:01:27.287  3392  3480 I WindowManager: WIN DEATH: Window{a20684c u0 com.PanDi/com.pandi.MainActivity}
11-18 15:01:27.288  3392  5518 I ActivityManager: Process com.PanDi (pid 10381) has died: fore TOP

How to repeat issue and example

lauch launchImageLibrary and negate the permission request
pick an image from the library
the app crashes

Solution
What needs to be done to address this issue?
The app should not crash, it should answer with a response that has errorCode: permission
Additional Information
    Image Picker version: ├─<EMAIL_ADDRESS>    React Native version: ├─<EMAIL_ADDRESS>    Platform: Android, not tested on ios
    Development Operating System: Linux

This library does not require any permissions unless you use saveToPhotos, check docs for more info.
Tell your test device info to debug.

This library does not require any permissions unless you use saveToPhotos, check docs for more info.
well if, that option is given, the library could just check (without asking) the permission, avoiding the crash (just a matter of application code style, and the documented errorCode: permission makes you think that way even more)
Tell your test device info to debug.
SM-G903F with android 9 (lineage 16.0)

thank you

well if, that option is given, the library could just check (without asking) the permission, avoiding the crash (just a matter of application code style, and the documented errorCode: permission makes you think that way even more)

Yes when you set saveToPhotos it will check for permission(does not ask), and  return if permission is not satisfied. This is how the library works.

ok, then, lauch launchImageLibrary without permission, it will crash

If you have any other device, can you test it on that. Because I cant reproduce your issue in my device. I need to know if its device specific issue.

Having the same issue.

@herbertvuijk can you paste the traceback printed here from https://github.com/react-native-image-picker/react-native-image-picker/blob/main/android/src/main/java/com/imagepicker/Utils.java#L183
The best approach would be to check the write permission only if a resize should be applied, even before launching the gallery intent; if resize will not be applied, then there is no need for asking the permission.
anyway we workarounded this in our app by checking the permission before calling the library

WRITE_EXTERNAL_STORAGE is only required when you use saveToPhotos: true in all other cases its not required. If you can add more details it help to diagnose.

I hope the issue is solved, if not reply here with details I am happy to fix it.


I want to know the host specifications.

My tests use some memory and cpu/gpu resources of the host where the browser is displayed.
Therefore, it is necessary to know the specifications of the host on which the test actually runs.
I couldn't find it anywhere in azure playwright testing.
What are the specifications?
AB#1910145

Hi @gatsukichi , Thanks for writing to us.
Currently, each browser is hosted on a container instance that has 2 cores of CPU and 5 GB of memory. These specifications might be adjusted in the future based on requirements.
Feel free to reach out if you have more questions.


Setting ticks for secondary yaxis prevents graph generation

Hi, thank's a lot for this wonderful library!
A bug: setting the Ticks für a secondary yaxis does not work. If you set them, the whole diagram is not generated (=empty). Just switching the primary and secondary yaxis works, so it should not be a problem of my usage.
BTW: we could use a little bit of usage docs ;-)

Experiencing the same issue. Any chance for a fix? The error I get is infinite secondary y-range delta. Any chance for a fix?

it looks like pul request #118 is a fix for this?


Fixed section Enable your custom provider

In section Enable your custom provider by following an error was coming in halyard's pod
Was passed main parameter 'hal' but no main parameter was defined in your arg class
I fixed it by separating in 2 steps
1- Configure the parameters
2- Enable the oauth2 feature with authn oauth2 enable

@brian-armory  Hi brian a small improvement to the oauth enablement.
please check it out when you get some time.


Include acbuild from master for new OCI build mode support.

Travis isn't happy with the GPG key import. Is this a transient issue?

The Travis issue started in https://github.com/woofwoofinc/rktmachine/commit/a2197db6605c45bab54ad6b6a9adedc797fa2375 where we needed an updated Ruby for https://github.com/travis-ci/travis-ci/issues/6307 and it just keeps running.

You aren't going to like the fix...


WIP: Fix passed timeout with backwards searchpair

searchpair(pos) might return an invalid value in case a timeout is used.
This can be triggered using searchpairpos('(', '', ')', 'bnW', '', 1, 500) (not reliably, but very often from line 1818 of
https://github.com/vim-jp/vim-vimlparser/blob/9eb216ff880d7b7fee036f096b6ad822651ea4db/py/vimlparser.py#L1818).
This is a WIP PR to check if any existing tests are failing.
For Neovim: https://github.com/neovim/neovim/pull/7852

can you please write a test for the change?

Bram,
thanks for applying the fix.
I agree with Christian that a regression test for this would be nice to have.
Is the timeout feature tested somewhere already?


Update regarding Sending SMS using Pinpoint

For SMS using Pinpoint, RDS Campaigns and workshop is setup to use a dedicated long code that the users can obtain using AWS pinpoint console. Starting Feb 15, Pinpoint has introduced some changes to the process of registering a long code with campaigns in Pinpoint.  -[1]
With the new process, it is first required to register one's company and create a 10DLC (10-digit long code) Campaign using the console. After this, the campaign is sent to a 3rd party campaign registry, which approves or rejects the campaign based on the information provided. Some campaigns might take a week or longer for approval. This will affect the current setup in Retail Demo Store and will require some changes to the workshop and campaign used for sending SMS to the users.
Resolution Steps:

Update the instructions to get a long code in the Pinpoint Workshop
Update the CFN template parameter description
Update campaigns to follow the registering process (this might lead to more changes; might need to verify if the auto deployment works even with unregistered campaign

-[1] The information about the change can be found here: https://docs.aws.amazon.com/pinpoint/latest/userguide/settings-10dlc.html

Hi people. To avoid the 10DLC, it is possible to register a short-code toll-free number? The restriction (3 messages x min) is ok for testing purposes.

@changux Yes it is OK to register a toll-free number in the US and it works fine in my testing - you do not need a short-code. See PR https://github.com/aws-samples/retail-demo-store/pull/255 for updated instructions on this.
PR https://github.com/aws-samples/retail-demo-store/pull/251 also enables you to send messages to toll-free numbers that you registered with AWS (but not the same number that you are sending from).


pilot & deliver team parameters are misnamed

The pilot & deliver tools have the team-related command line parameters (pilot shown):
-q, --team_id [VALUE] The ID of your team if you're in multiple teams (PILOT_TEAM_ID)
-r, --team_name STRING The name of your team if you're in multiple teams (PILOT_TEAM_NAME)

For comparison, sigh also has these parameters:
-b, --team_id STRING The ID of your team if you're in multiple teams (SIGH_TEAM_ID)
-l, --team_name STRING The name of your team if you're in multiple teams (SIGH_TEAM_NAME)

Unfortunately these refer to completely different things - the former refers to the iTunes Connect provider, the latter to the Dev Centre Team. This is enormously confusing and inconsistent. to make matters worse:

the error message returned if the wrong value is specified for Team ID is incredibly vague: (invalid request body)
these parameters are ignored unless the apple ID is connected to more than one iTunes Connect account (which has only been possible recently), meaning an incorrect team ID may work correctly for a long time, and then mysteriously fail when the user is granted access to another account.

As far as I’m aware, Apple don’t use the term ‘Team’ to refer to iTunes Connect - in public documentation they call it an ‘Account’, internally it appears to be labelled a ‘provider’.
These parameters should be renamed (with a suitable deprecation period) - I suggest something like:
-q, --itc_account_id [VALUE] The ID of your iTC account if you have multiple accounts (PILOT_ITC_ACCOUNT_ID)
-r, --itc_account_name STRING The name of your iTC account if you have multiple accounts (PILOT_ITC_ACCOUNT_NAME)

and the tools should return a sensible error message if the parameters are incorrect (this may require pre-flighting). It would be great if these were always validated, rather than only if the user has multiple accounts.
Migrated from #1526

@samritchie Hope you are doing well! Are you interested in submitting a PR for this? I'd love to see that and work with you 👍 Let me know!

@TKBurner I could give it a go. A couple of questions though:

How do you deprecate an option (in particular, retain the short switch, but change the key & env var)? If it’s just duplicated, how is the short switch resolved?
It looks like @mfurtak added PILOT_ITC_PROVIDER and DELIVER_ITC_PROVIDER env-only options; these would appear to duplicate the team_id options, but I’m not really clear on how they’re used?

Hi @samritchie 👋
PILOT_ITC_PROVIDER and DELIVER_ITC_PROVIDER are used to pass a provider name through the iTMSTransporter. "provider" is just what the iTMSTransporter calls this organizational entity. While this value is commonly equal to the Developer Portal team ID, for teams that have existed a very long time, it is not.
See https://github.com/fastlane/fastlane/pull/4746#issuecomment-223482891 for a way to get the right values for this from Apple.

@KrauseFx Can you give your thoughts on this ticket?

Hey @samritchie,
Thanks for raising this issue, that's super helpful - a very good point! These are the things that are really hard to change, as we have to be backwards compatible to not break any setups with a new release.

the error message returned if the wrong value is specified for Team ID is incredibly vague: (invalid request body)
That's far from ideal, and definitely something we should fix, regardless of if we change the parameter names. Is it reproducible on every run? If so, do you feel like you could submit a PR adding a test + nice error message?

meaning an incorrect team ID may work correctly for a long time, and then mysteriously fail when the user is granted access to another account.
Is that something we can detect? e.g. when a Team ID or Team Name is provided, but the user is only in one iTC team, we should a clearly visible warning? I thought we already do so.

To sum up, I wouldn't change the available parameters, as it would break existing setups, and implementing an alias is a lot of extra work, with not a lot of advantages. Instead let's focus on improving the error messages and warnings, and also the documentation around those parameters (both in the source code, and in the user-facing documentation)
What do you think? 👍

@mfurtak there’s a third ID. Awesome. I’d never seen that provider short name before.
I’ve read through all the issues & I think I’m managing to grasp what’s going on:

older versions of pilot/deliver never passed a provider ID through to transporter; immediately post-multi-account iTunes, iTunes Connect used some sort of metadata inspection to locate the appropriate provider.
pilot/deliver DID require the iTC team ID for multi-account users, however this was still not passed through to transporter (presumably it was just a spaceship thing)
at a later point, (May/June timeframe?), iTunes Connect started requiring an explicit provider for multi-account users. However, the provider is not specified via its provider ID, because that would be too sensible, but instead uses a short name that’s normally the dev centre ID, but not always.
the :dev_portal_team_id option was added as a workaround, under the assumption that this was always the same as the short name.
when apparent it wasn’t, the itc_provider option was then added to explicitly set the short name for the older accounts.

Well, that’s just spiffy. Ideally fastlane would look up the short name using transporter if it’s not supplied, which should be feasible if the itc provider name or id is specified. I assume :dev_portal_team_id can be deprecated?
@KrauseFx:

That's far from ideal, and definitely something we should fix, regardless of if we change the parameter names. Is it reproducible on every run?

I last tested about a month ago, I assume it’s still in place. I’ll recheck. It looks like a generic message and might require explicit preflight validation to reliably test, I can try and have a go at this, my Ruby is not great though.

when a Team ID or Team Name is provided, but the user is only in one iTC team, we should a clearly visible warning? I thought we already do so.

It doesn’t look like it (at least, not from pilot). Personally, the logic I’d use is ‘IF the itc team ID or name is supplied, THEN validate against the user iTC teams and print a warning/error if invalid’. Maybe it could be a warning for single-team users and an error for multi-team users; this will cover off the vague error issue as well.

I wouldn't change the available parameters, as it would break existing setups, and implementing an alias is a lot of extra work, with not a lot of advantages. Instead let's focus on improving the error messages and warnings, and also the documentation around those parameters (both in the source code, and in the user-facing documentation)

I think people tend to underestimate the long-term cost of bad naming - ideally there’d be better support for deprecation/renaming in ConfigItem (possibly something like deprecated_aliases, deprecated_short_options, deprecated_env_names etc). However, I don’t have the knowledge or time to do a change this invasive. I can update the parameter descriptions & I’ll have a look at the docs though.

the error message returned if the wrong value is specified for Team ID is incredibly vague: (invalid request body)

This has been solved with the most recent spaceship release 👍


PerfBullets integration?

Pretty much what title says. Since both plugins cover one niche game genre, some degree of integration seemed reasonable to me, but there was no info on that. I've opened a similar issue in PerfBullets repository: https://github.com/Moonzel/Godot-PerfBullets/issues/3 , and would appreciate if you gave it a look.

Moonzel made his plugin 'cause I didn't have the time to rewrite everything in C++. I'm also working on another plugin right now and told myself it'd be my last 'cause I don't wanna make plugins anymore... You know, with enough willpower and motivation, I might, given Moonzel agrees to help, but my schedule is full for now.
Do I think it's a good idea ? Yes
Will I sacrifice any feature for optimisation ? No
Do I have the free time required ? No
In conclusion, maybe...

Do I think it's a good idea ? Yes Will I sacrifice any feature for optimisation ? No Do I have the free time required ? No In conclusion, maybe...
I think it would benefit the plugin for sure, but from working with your code previously, it is very complex with lots of moving parts. It definitely could be done, but at the moment, I do not have the time to devote to it. Given enough demand, I may be able to, but I would absolutely need your help to make it happen.

@temhotaokeaha If you were able to find someone that is willing to put in the time, and knows a little about GDExtension, I could always give them a contact to help them with any questions they may have.
I would love to see this happen, but like @Dark-Peace, I personally do not have the time right now.

@temhotaokeaha If you were able to find someone

IDK anyone, sorry, but hey, at least the discussion happened and people will know what to expect.


Inherit source code to causes as well as related errors

At the moment outer source code is supplied to inner related errors but not to causes. This PR changes that.
This allows late-supplied source code to be supplied using concrete types. Compare, if we wrap our inner error with some well-typed outer wrapper:
Concrete types
#[derive(thiserror::Error, Debug, miette::Diagnostic)]
#[error("inner-error")]
struct InnerError {
    #[label("inner-label")]
    label: (usize, usize),
}

#[derive(thiserror::Error, Debug, miette::Diagnostic)]
#[error("outer-error")]
struct OuterError {
    #[source_code]
    source_code: String,

    #[diagnostic_source]
    inner: InnerError,
}

fn main() -> miette::Result<(), miette::Report> {
    Err(OuterError {
        source_code: "source code".to_string(),
        inner: InnerError { label: (7, 4) },
    })?
}

Output:
Error:
  × outer-error
  ╰─▶   × inner-error

Wrapped in Report
On the other hand, if we wrap using miette::Report, losing type information, we get the source code:
#[derive(thiserror::Error, Debug, miette::Diagnostic)]
#[error("inner-error")]
struct InnerError {
    #[label("inner-label")]
    label: (usize, usize),
}

fn main() -> miette::Result<(), miette::Report> {
    Err(miette::Report::new(InnerError { label: (7, 4) }).with_source_code("source code"))?
}

Output:
Error:
  × inner-error
   ╭────
 1 │ source code
   ·        ──┬─
   ·          ╰── inner-label
   ╰────

Related
Currently this is possible using related() but that is semantically-inappropriate for some use cases:
#[derive(thiserror::Error, Debug, miette::Diagnostic)]
#[error("inner-error")]
struct InnerError {
    #[label("inner-label")]
    label: (usize, usize),
}

#[derive(thiserror::Error, Debug, miette::Diagnostic)]
#[error("outer-error")]
struct OuterError {
    #[source_code]
    source_code: String,

    #[related]
    inner: Vec<InnerError>,
}

fn main() -> miette::Result<(), miette::Report> {
    Err(OuterError {
        source_code: "source code".to_string(),
        inner: vec![InnerError { label: (7, 4) }],
    })?
}

Error:
  × outer-error

Error:
  × inner-error
   ╭────
 1 │ source code
   ·        ──┬─
   ·          ╰── inner-label
   ╰────

Proposed change
After this PR, the output for the first example should be similar to the last example, except exhibiting cause-nesting:
Error:
  × outer-error
  ╰─▶   × inner-error
         ╭────
       1 │ source code
         ·        ──┬─
         ·          ╰── inner-label
         ╰────

The other solution I had considered was to pull up labels from causes into the parent and merge all of the labels together. I think this would be nice but maybe enabled with a different attribute?


Wrong symlink in best variables

Commit add9bdc99ab6acbf0ebece9c5c792c3fb3f495f4 (fix saving variables) introduced a bug. It creates a symlink with wrong relative address. For example, when I set my output to directory test-out, it creates a link to test-out/data.whatever in that folder. So the script is looking for test-out/test-out/data.whatever instead of test-out/data.whatever.
My preferred solution would be to put the commit into a separate branch (rewinding current master by one commit) and merge #13. That will enable running tests/small.ini on Travis. The new branch can be merged when the bug is fixed. What do you think, @jindrahelcl?

I have run it on this commit and the link is fine. Can you paste the ini file?

It' the ini file in #13. You can replicate this by rebasing #13 (or the package_hierarchy branch from this repo) on add9bdc and running tests_run.sh.

fixed


'make' command not generating connect-streams-${VERSION}.js

it is only generating amazon-connect-${version}.js

With the new NPM build system support this is no more an issue. please feel free to re-open if the issue exists.


Python requirements.txt parsing shows errors in SBOM-Tool

Description
When running the SBOM-tool on a project that is Python based and has requirements that either have square brackets or minimum/maximum version numbers given, receiving the data comes with the following warning:
[WARN] Received 404 Not Found from https://pypi.org/pypi/<package>/json

Since SBOM-tool is based uses component-detection, I wanted to repost the corresponding issue here.
To reproduce
Examples of requirements to reproduce the errors:
beautifulsoup4>=4.9.1
molecule[podman]

Expected behavior
Receiving the data from PyPi and processing it.
Actual Behavior
Got the following result:
[INFO] Getting Python data from https://pypi.org/pypi/beautifulsoup4>=4.9.1/json
[WARN] Received 404 Not Found from https://pypi.org/pypi/beautifulsoup4>=4.9.1/json
[WARN] Dependency Package beautifulsoup4>=4.9.1 not found in Pypi. Skipping package
[INFO] Getting Python data from https://pypi.org/pypi/molecule[podman]/json
[WARN] Received 404 Not Found from https://pypi.org/pypi/molecule[podman]/json
[WARN] Root dependency molecule[podman] not found on pypi. Skipping package.

Suggestions
I am not exactly sure which information you are retrieving from the API, but if it's the latest package version (which in case of the great-than comparator is the default version to be installed), you could just strip away the version number and comparator, that is e.g. query this URL https://pypi.org/pypi/beautifulsoup4/json for example.
In case of having brackets one could check the base package API and then in the JSON response check the additional requirements that it depends on with this extra depencies under .info.requires_dist. Yet this won't work the above example in which it is possible to query for https://pypi.org/pypi/molecule-podman/json

This works properly in the current version of CD. SBOM-Tool is using an outdated version of CD.


CDPD-7598 Add gateway roles to Leader

Summary
Add hbase-GATEWAY-BASE and hdfs-GATEWAY-BASE roles to Leader node for OpDB blueprints.
Testing
Added custom template to mow-dev environment and created an OpDB cluster from it. Logged in to the leader node and executed a couple of HBase commands from the shell.

Changed commit message to retrigger builds.

I will reopen a new PR for rc-2.18 branch.


check is on site channels available

Tpay Magento2 plugin - https://github.com/tpay-com/tpay-magento2-basic/actions/runs/9773858385/artifacts/1662793257

Tpay Magento2 plugin - https://github.com/tpay-com/tpay-magento2-basic/actions/runs/9792424081/artifacts/1667492582

Tpay Magento2 plugin - https://github.com/tpay-com/tpay-magento2-basic/actions/runs/9793565707/artifacts/1667778965

Tpay Magento2 plugin - https://github.com/tpay-com/tpay-magento2-basic/actions/runs/9793675101/artifacts/1667805591

Tpay Magento2 plugin - https://github.com/tpay-com/tpay-magento2-basic/actions/runs/9796764240/artifacts/1668599855


Feature Request: Add ability to track users on a per page basis as opposed to entire app

Currently, the app only tracks a user as it is connected to the server. It would be incredibly useful if I could track the users on a specific page. This would be incredibly useful in a chat app (like my own) where you want to know only the users that are currently sitting on a particular page.

@mizzao has this been implemented, yet? Just to illustrate a point, a user (authenticated or anonymous) can move away from a page/route in three different ways:

The user moves to another page/route, something Iron Router should handle.
The user closes a tab.
The user closes the browser.

From what I've noticed, from experimenting your package, point 2 & 3 are different kinds of events.

No, not implemented yet; however #2 and #3 should be the same unless there are two tabs open (sharing the same authenticated user).
It's difficult for me to implement features that I am not personally using in this package, but I'd welcome pull requests!

Hey, I was looking for a similar feature.  This seems like it could be implemented just with IronRouter.  Update the user.profile.lastRoute in a hook on each route.
Then a user's current route is:  (user.status.online) ? user.profile.lastRoute : false.
Would you need something more than that?

To get this working in FlowRouter I set up this code client side (this requires lodash, but you can use another method on this line if (_.has(FlowRouter.current(), 'context.hash')) {
if (Meteor.isClient) {
  // Update users.status.lastRoute
  // include hash in url if present
  Tracker.autorun(function () {
    if (Meteor.userId()) {
      FlowRouter.watchPathChange();
      var currentPath = FlowRouter.current().path;
      if (_.has(FlowRouter.current(), 'context.hash')) {
        currentPath = currentPath + '#' + FlowRouter.current().context.hash;
      }

      if (currentPath) {
        Meteor.users.update({_id: Meteor.userId() }, { $set: { 'status.lastRoute': currentPath } } );
      }
    }
  });
}

This can be extended further to have it track in another collection, like users_status_history


There is no loading percentage when exporting frames

I think it would be nice if there is some percentage when exporting frames so I can show the progress to the user. Or maybe there are some alternative that I can use to show the percentage to user?
Thanks 😄

Yeah, this would certainly be nice. I'll gladly accept such a thing as PR.
I'm not entirely sure, but I believe on web this wouldn't help since the processing is currently a blocking operation.


[architecture-diagram-dev] Add tests for Architecture Model Generator

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Changed the code base location https://github.com/ballerina-platform/ballerina-dev-tools/pull/156


Use scoped event in onDrop

Fixes #503

@steffentchr what about merging? onDrop doesn't work in Firefox now. I think it is critical bug

Can you validate this pull request? This bug is very annoying...


Change udev rules back to MODE="0664" instead of uaccess.

When you e.g. have a service that flashes your modules it might run as a dedicated user, which is unable to login. In this case uaccess does not work.
BTW, it might be useful to also add GROUP="plugdev" or something similar to the udev rules.
Also, I stripped my udev rules down to some leaner version relying on vendor-id.
e.g.:
SUBSYSTEM=="usb", ATTRS{idVendor}=="1fc9", MODE="0664", GROUP="plugdev"
SUBSYSTEM=="usb", ATTRS{idVendor}=="15a2", MODE="0664", GROUP="plugdev"
SUBSYSTEM=="usb", ATTRS{idVendor}=="0525", MODE="0664", GROUP="plugdev"
SUBSYSTEM=="usb", ATTRS{idVendor}=="3016", MODE="0664", GROUP="plugdev"
SUBSYSTEM=="usb", ATTRS{idVendor}=="066f", MODE="0664", GROUP="plugdev"
SUBSYSTEM=="usb", ATTRS{idVendor}=="18d1", MODE="0664", GROUP="plugdev"
SUBSYSTEM=="usb", ATTRS{idVendor}=="3016", MODE="0664", GROUP="plugdev"
SUBSYSTEM=="usb", ATTRS{idVendor}=="0483", MODE="0664", GROUP="plugdev"

@agx Do you have any concern about this change, which always revert your commit?

Cleaned up the doubles and sorted by idVendor. Checked the group_writability but don't have a non Debian based system for more checks.
`
Check if group plugdev exists
ACTION=="add", SUBSYSTEM=="usb", RUN+="/bin/sh -c 'if getent group plugdev >/dev/null; then GOTO="group_writability"; else GOTO="no_group_writability"; fi'"
Rule for devices with group writability
LABEL="group_writability"
SUBSYSTEM=="usb", ATTRS{idVendor}=="0483", GROUP="plugdev", MODE="0664", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="0525", GROUP="plugdev", MODE="0664", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="066f", GROUP="plugdev", MODE="0664", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="15a2", GROUP="plugdev", MODE="0664", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="18d1", GROUP="plugdev", MODE="0664", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="1fc9", GROUP="plugdev", MODE="0664", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="3016", GROUP="plugdev", MODE="0664", TAG+="uaccess"
Rule for devices without group writability
LABEL="no_group_writability"
SUBSYSTEM=="usb", ATTRS{idVendor}=="0483", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="0525", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="066f", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="15a2", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="18d1", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="1fc9", TAG+="uaccess"
SUBSYSTEM=="usb", ATTRS{idVendor}=="3016", TAG+="uaccess"
`

@oliverwendt @mb-karo I think that's pretty close. I'd just let mfgtools do the group lookup at rule installation time as getent in udev rules can take a very long time if you e.g. have LDAP lookups configured in nsswitch.conf (which likely isn't even functional when the udev rules are created). This would also allow to make the groupname configurable as e.g. command line option.

Well did run the rules as a rule file in /etc/udev/rules.d  having set:
udevadm control --log-priority=debug
journalctl -n 500 -f

and in an other instance
udevadm monitor
And I don't see any real lag in getent
Dec 11 18:24:02 test-pc systemd-udevd[833457]: 1-1:1.0: /etc/udev/rules.d/74-uuu.rules:26 RUN '/bin/sh -c 'if getent group plugdev >/dev/null; then GOTO="group_writability"; else GOTO="no_group_writability"; fi''
Dec 11 18:24:02 test-pc systemd-udevd[833457]: 1-1:1.0: /etc/udev/rules.d/74-uuu.rules:35 GROUP 46
Dec 11 18:24:02 test-pc systemd-udevd[833457]: 1-1:1.0: /etc/udev/rules.d/74-uuu.rules:35 MODE 0664

Yes, I understand that with LDAP there might be lag, but AFAIK getent actually reads either a buffer, or the groups file itself, that should be essentially lag free. So the commands above should give someone with that setup some capability to test and check.

What getent really does depends on your nssswitch.conf. It might be lots of things. The udev manpage says for RUN:

Note that running programs that access the network or mount/unmount filesystems is not allowed inside of udev rules, due to the default sandbox that is enforced on systemd-udevd.service.

and there certainly can be network access with getent.


defaultValue is not respected for nested configuration settings

VSCode Version: 1.38.1-insiders / 1.37.0 (stable)
OS Version: Windows 10 x64 18362.295

Steps to Reproduce:

Clone this
Start debug.
Observe that the default value for helloworld.test_package is the same provided by package.json while helloworld_nested.test_package is undefined.

Does this issue occur when all extensions are disabled?: Yes

@jakopo87 You can only define defaults for top settings and not for nested.

@sandy081 It does work when you edit manually into the settings, and this is what confused me.

However if this is the intended behavior it's fine, but I think it should mentioned in the docs at least.

It is a feature of JSON language server and hence you see it while editing the JSON file.


fix error output

Fixes #3794
Reasons are explained in the issue ticket.

There are some errors with the pipeline, /cc @techalchemy

ugh yeah sorry I've had to sort that out on a bunch of projects, it's a problem with the python deployments on azure
they built all the latest ones but on ubuntu they didn't build them with sqlite headers somehow, so there is a temporary patch script to reinstall the earlier versions...


System.BadImageFormatException ServiceKit.OrmLite.Sqlite, Version=<IP_ADDRESS>

Hello there, any help with this issue ?
{System.BadImageFormatException: Could not load file or assembly 'NServiceKit.OrmLite.Sqlite, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' or one of its dependencies. An attempt was made to load a program with an incorrect format.
File name: 'NServiceKit.OrmLite.Sqlite, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
   at XXXXX
   at XXXX\CXX.cs:line 138

=== Pre-bind state information ===
LOG: DisplayName = NServiceKit.OrmLite.Sqlite, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
 (Fully-specified)
LOG: Initial PrivatePath = NULL
Calling assembly : DTICUIDSRV001, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null.
===
LOG: This bind starts in default load context.
ERR: Failed to complete setup of assembly (hr = 0x8007000b). Probing terminated.
}

Are you building in 32-bit or 64-bit mode?
If you're building in 32 bit mode, make sure IIS is setup properly to allow for 32 bit applications:
http://stackoverflow.com/questions/2023766/an-attempt-was-made-to-load-a-program-with-an-incorrect-format-even-when-the-p

Ok I was using 'AnyCpu' on platform target, now I've changed to x86 but now I have:
Unable to find an entry point named 'sqlite3_key' in DLL 'sqlite3'.

My System.Data.SQLite version:

Try <IP_ADDRESS>, that's the one it was built against.

I've did
Install-Package System.Data.SQLite -Version 1.0.82

But same error...

Odd...  Try copying sqlite to your bin folder from this download?
https://github.com/NServiceKit/NServiceKit.OrmLite/blob/master/lib/sqlite3.dll?raw=true

Sorry for delay, but the error persist


net: skip TestIPv4MulticastListener on linux without CONFIG_IP_MULTICAST

What version of Go are you using (go version)?

go version go1.17.2 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/src/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/src/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.2"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/usr/local/src/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build4211212346=/tmp/go-build -gno-record-gcc-switches"

What did you do?
go test -run TestIPv4MulticastListener net
I'm running this command from within a Linux machine whose kernel was built without CONFIG_IP_MULTICAST.
What did you expect to see?
TestIPv4MulticastListener skipped because IP multicast is not enabled.
In fact this was already proposed by @bradfitz in https://github.com/golang/go/issues/11936#issuecomment-126262150 but never implemented.
What did you see instead?
--- FAIL: TestIPv4MulticastListener (0.00s)
    listen_test.go:570: <IP_ADDRESS> not found in multicast rib
FAIL
FAIL    net     0.005s
FAIL

CC @neild


HTML

HTML
User Story
As a bootcamp student I want the prework notes to be structured on a webpage so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

Completed and posted in Main branch on 1/8/22


Grouping of DiagramItems using a DiagramItem as container

Addes feature: Grouping Diagramitems
Added persistance of grouped Diagramitems
Bugfixed: Using mousewheel to zoom out, now only zoom out for 10%

A GroupingDesignerItem can also contain a GroupingDesignerItem. It is possible to Connect normal DesignerItem with the GroupingDesigneritem, if they have the same parent. So connecting Items which are children from DesignerCanvas and Items which are children von GroupingDesignerItem is not possible. Connecting and dragging within a Group is possible, it is not possible to drag out of the grouping boundries.
Selecting of grouped DesignerItems might seems weirded, but can easily adjust to your needs.

Merged the grouping stuff added by codeproject user tecrob. See this entry over at original codeproject article :
http://www.codeproject.com/Articles/484616/MVVM-Diagram-Designer?msg=5207518#xx5207518xx


wip: game state, traits, boxing

This is incomplete from where I want it to be, but it's now blocking other work. Merging for the moment so I can rebase some other PRs.


How we can pass JWT Token on bookstack for authentication of user login ?

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
Actually i have integrated bookstack in our website through iframe.
so i want that when a user login to my website and click on bookstack module it automatically log in to the bookstack which is integrated in the website through iframe, we dont want to login again on bookstack when we actually logged on website already.
Is there any token or hash is passed on website url to authenticate the user.
kindly please suggest ways to deal
Exact BookStack Version
v23.05.2
Log Content
No response
PHP Version
No response
Hosting Environment
ubuntu 22.04

Is there any token or hash is passed on website url to authenticate the user.

No, there is not such functionality built in, and it's not something I'd look to support.
If you have PHP development skills available, you could use our logical theme system to pick up any URL details and deal with them accordingly.

Since there's been no follow-up I'm going to close this.


ionic build iOS ERROR

I can't build my ionic 2 - angular 2 - typescript mobile aplication because when I try to generate de Xcode project, ionic build ios command returns me some errors on headers:
'Cordova/CDVViewController.h' file not found #import <Cordova/CDVViewController.h>
fatal error: 'Cordova/CDVViewController.h' file not found #import <Cordova/CDVViewController.h>
fatal error: 'Cordova/CDV.h' file not found #import <Cordova/CDV.h>
Environment

Plugin version: 2.2.5
Platform: iOS
OS version: 10.2
Device manufacturer and model: iPhone 6s Plus
Cordova version: 6.4.0
Cordova platform version: 4.3.0

Expected Behavior
Build success
Actual Behavior
3 comands failed and Error: Error code 65 for command

Anybody having this issue?

Hi all,
Yes, I have also run into this problem (with ionic 1). But in my experience, removing and adding the platform again solves it.
The error code 65 also appears when xcode fails to link against libsqlite3.dylib:
https://stackoverflow.com/questions/31420166/libsqlite3-dylib-and-libz-dylib-missing-in-xcode-7-how-do-i-use-parse

upgrade plugin version. Should be fixed in 2.3.5 or 3.x branch


Migrate invocation image push to porter publish

This PR migrates the image push functionality to a new command porter publish (the command doesn't actually publish the bundle itself to OCI yet). Now when you do a porter build the invocation image is still built, but it is not pushed to a registry. The bundle.json is generated with whatever tag is present in the porter.yaml.
To push the image and regenerate the bundle.json, you now do a porter publish.

The push refers to repository [docker.io/jeremyrickard/hashi-mashi]
15efbe06773e: Preparing
c7fa3bae30d9: Preparing
49037d9d1b30: Preparing
c7956a703d1e: Preparing
c581f4ede92d: Preparing
15efbe06773e: Mounted from jeremyrickard/porter-kubernetes
c581f4ede92d: Mounted from jeremyrickard/spring-music-installer
c7fa3bae30d9: Mounted from jeremyrickard/porter-kubernetes
c7956a703d1e: Mounted from jeremyrickard/porter-azure-wordpress
49037d9d1b30: Mounted from jeremyrickard/porter-kubernetes
v1.0: digest: sha256:c90044b7bfdab915d213ceccdce3910f51e5815a4dae72592fa357e2044c9717 size: 1370

Generating CNAB bundle.json...

Generating Bundle File with Invocation Image jeremyrickard/hashi-mashi@sha256:c90044b7bfdab915d213ceccdce3910f51e5815a4dae72592fa357e2044c9717 =======>
Generating parameter definition porter-debug ====>
Generating credential kubeconfig ====>

Closes: #354

Need to update the docs still!