SecureStorageException doesn't exist

In README.md you explain error handling with this class. But it cannot be resolved. The version I'm using is:
'de.adorsys.android:securestoragelibrary:0.0.3'

We are working on fixing the issue.
We'll keep you informed @Ornolfr

Sorry for the inconvenience.
We have fixed the issue and also made some minor changes to library usage.
Please use version 1.0.0
compile 'de.adorsys.android:securestoragelibrary:1.0.0'
One of the changes is that you no longer need to pass the context as a parameter, cause that is all handled internally.
@Ornolfr


History and provenance

How should this be handled?  Obviously, we can just have a list of "log messages" about what has been done to the file, but is there anything more structured or helpful we can do.  Is there any good prior art to steal, perhaps from the library community?

There is already a history section that is defined by the Standard, and there is nothing that prevents a user and/or library from adding additional information to reflect provenance.


Feature request - documentation generator for MSDoc comments

Dear developers,
I feel like ASP Core on Mac is as feature-rich and ready-for-production as it is on Windows, however there is one necessary component missing. Doc generator.
Every major language (and C# for Windows only) has some kind of documentation style and appropriate generator. Java has JDoc, javascript has JSDoc and so on. I know that C# has MSDoc (xml) comments like the following:
/// <summary>
/// Short summary here...
/// </summary>
/// <param name="metric">Metric to update data for.</param>
/// <returns>New Metric object with the data updated.</returns>
Task<Metric> CacheMetric(Metric metric);

But it lacks a tool which would read the comments and generate pretty html file(s) with documentation in, say, MSDN style.
Known workarounds:

I can use SandCastle, but it is old, not maintained anymore, and the worst - Windows only.
I can (and I do) use Doxygen, but this is a "universal" solution which does not understand all features of C# language and does not give outstandingly styled html.

Actual feature request. I want a cross platform open-source tool that consumes MSDoc documented files and produces HTML project that is an MSDN styled web-viewable documentation.
Is there any tool already released? Are there any plans to develop such a tool? What do people use instead?

Please feel free to move it to another repo.
I honestly do not know the best repo for it.
Or, point me to the duplicate.

see https://github.com/dotnet/docfx

Thanks, that works!


Set MUST NOT allow to be number-indexed

I just experimented a (what's the opposite of false positive ?) clean negative false negative (thanks to @fatcerberus )
TypeScript Version: 3.0.0-dev.201xxxxx
TypeScript Version:  3.3.3

NOTE : I had enabled downlevelIteration

Code
const leitters = new Set([ 'Aa', 'Bb', 'Cc' ]);
const leitter: string = leitters[0];

Expected behavior:
Second line MUST error
Actual behavior:
No error is reported...
Playground Link: https://bit.ly/2HcxmJa

--noImplicitAny?

That's interesting, so if you do setObj.propDoesntExist you get an error even without --noImplicitAny but indexing is allowed in that situation.  Seems a bit inconsistent, but I'm assuming this is for backward-compatibility reasons.

Indexing by numbers/strings is allowed but generates an implicit any.

Hi @RyanCavanaugh ,
I thought the typing follow ES spec. So what is such a mapping provide that is useful ? Or the reverse question - What problem would arise if that index:number was not allowed ? I'm not sure to understand the working as intended label.
Thank you !

The issue is that we'd break thousands of existing projects that rely on this behavior.
You can cause the desired error by turning on the noImplicitAny compiler option.

Thank you @RyanCavanaugh .
Not to challenge you, but out of curiosity, would you help me find one such project ?
I'm curious to see what output can be expected from such a usage.
Kind Regards !

I’m going to go out on a limb here and assume that this behavior predates the introduction of index signatures.  Thus, indexing is implicit any since otherwise you wouldn’t have been able to use the indexing syntax at all.

You surely pointed out it was an assumption @fatcerberus , but would you provide some reference to back you assumption ?
Thanks !

The basis of the assumption is that I’m pretty sure index signatures are a newer feature (read: later than 1.0) and if that’s the case then indexing would have had to be implicit-any prior to that to make it possible to index anything at all.  But that means the behavior must now be maintained because there is surely older code that relies on it.

Index signatures have existed approximately forever.
An early complaint about TypeScript was "But I need to go outside the type system all the time", which was much truer then (and a much bigger concern) than it is now. So we allowed obj["s"].blah to always pass with the reasoning that you would 99% of the time prefer to write obj.s.blah, so writing obj["s"].blah was clear enough to indicate intent of doing something weird.
Another fact about JS is that indexed access with a number always coerces the indexing operand to a string, so it's "inconsistent" to say that e.g. obj[1] is illegal if obj["1"] is legal.

Index signatures have existed approximately forever.

Well... I stand corrected. :smile:  Thanks!

OK @fatcerberus @RyanCavanaugh ,
Thank you for some history. It make sense, at least.


Zoom

Description
Fixes #1044
Added the functionality to pinch zoom in upload activity.
Screenshots showing what changed

Sorry for delay !

Works great, however there are some minor issues @tanvidadu

Conflicts
First click opens zoom as expected, however to get rid of zoom screen we need to click that button again. Since FAB icon remains still, it is hard to find how to close zoom screen (I found it happens when clicking same button again). Maybe you can change the icon of FAB on click to make user feel that that button is also way to close.

@neslihanturan I will start working on the suggested changes 👍

@neslihanturan I have made the changes accordingly and resolved the merged conflicts.
I have added screenshots for the same.

@tanvidadu I have tested the buttons, works perfect. One more issue:

When I try to upload an image from my DSLR camera it doesn't display zoom screen since image resolution is too high (I guess) once it gave me this error with crash:

FATAL EXCEPTION: main
                                                                         Process: fr.free.nrw.commons.debug, PID: 5261
                                                                         java.lang.OutOfMemoryError
                                                                             at android.graphics.BitmapFactory.nativeDecodeStream(Native Method)
                                                                             at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:635)
                                                                             at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:611)
                                                                             at android.graphics.BitmapFactory.decodeResourceStream(BitmapFactory.java:444)
                                                                             at android.graphics.drawable.Drawable.createFromResourceStream(Drawable.java:840)
                                                                             at android.graphics.drawable.Drawable.createFromStream(Drawable.java:791)
                                                                             at android.widget.ImageView.resolveUri(ImageView.java:660)
                                                                             at android.widget.ImageView.setImageURI(ImageView.java:399)
                                                                             at com.github.chrisbanes.photoview.PhotoView.setImageURI(PhotoView.java:119)
                                                                             at fr.free.nrw.commons.upload.ShareActivity.zoomImageFromThumb(ShareActivity.java:757)
                                                                             at fr.free.nrw.commons.upload.ShareActivity.access$200(ShareActivity.java:86)
                                                                             at fr.free.nrw.commons.upload.ShareActivity$1.onClick(ShareActivity.java:284)
                                                                             at android.view.View.performClick(View.java:4463)
                                                                             at android.view.View$PerformClick.run(View.java:18770)
                                                                             at android.os.Handler.handleCallback(Handler.java:808)
                                                                             at android.os.Handler.dispatchMessage(Handler.java:103)
                                                                             at android.os.Looper.loop(Looper.java:193)
                                                                             at android.app.ActivityThread.main(ActivityThread.java:5292)
                                                                             at java.lang.reflect.Method.invokeNative(Native Method)
                                                                             at java.lang.reflect.Method.invoke(Method.java:515)
                                                                             at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:824)
                                                                             at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:640)
                                                                             at dalvik.system.NativeStart.main(Native Method)

But it works perfect with photos from phone.

@neslihanturan I have compressed the high resolution images. I have tested the above fix on Samsung j7 max

It crashes:

Use this feature
Go back to contributions activity
Use this feature again

 Process: fr.free.nrw.commons.debug, PID: 4297
                                                                         java.lang.NullPointerException
                                                                             at android.graphics.Bitmap.createBitmap(Bitmap.java:741)
                                                                             at android.graphics.Bitmap.createScaledBitmap(Bitmap.java:602)
                                                                             at fr.free.nrw.commons.upload.ShareActivity.zoomImageFromThumb(ShareActivity.java:774)
                                                                             at fr.free.nrw.commons.upload.ShareActivity.access$200(ShareActivity.java:89)
                                                                             at fr.free.nrw.commons.upload.ShareActivity$1.onClick(ShareActivity.java:287)

I tried the following steps but was unable to reproduce the error.
With help of error log I was able to identify the reason for Null pointer exception. It is while doing compression. I have added a fix for it please let me know whether it's working or not.

Here is a better log:

@neslihanturan , Thanks :)  for the log. I have fixed the error.

I get this crash while testing:
 FATAL EXCEPTION: main
                                                                         Process: fr.free.nrw.commons.debug, PID: 5318
                                                                         java.lang.NoSuchMethodError: java.lang.Long.min
                                                                             at fr.free.nrw.commons.upload.ShareActivity.zoomImageFromThumb(ShareActivity.java:786)
                                                                             at fr.free.nrw.commons.upload.ShareActivity.access$200(ShareActivity.java:93)
                                                                             at fr.free.nrw.commons.upload.ShareActivity$1.onClick(ShareActivity.java:291)
                                                                             at android.view.View.performClick(View.java:4463)
                                                                             at android.view.View$PerformClick.run(View.java:18770)
                                                                             at android.os.Handler.handleCallback(Handler.java:808)
                                                                             at android.os.Handler.dispatchMessage(Handler.java:103)
                                                                             at android.os.Looper.loop(Looper.java:193)
                                                                             at android.app.ActivityThread.main(ActivityThread.java:5292)
                                                                             at java.lang.reflect.Method.invokeNative(Native Method)
                                                                             at java.lang.reflect.Method.invoke(Method.java:515)
                                                                             at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:824)
                                                                             at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:640)

```                                                                   at dalvik.system.NativeStart.main(Native Method)

@neslihanturan i have fixed the issue !

Works great! Do you have any idea why tests fails @tanvidadu ?

It has something to do with this log , but i am unable to debug it :

com.android.ide.common.process.ProcessException: Error while executing process /usr/local/android-sdk/build-tools/26.0.2/aapt with arguments {package -f --no-crunch -I /usr/local/android-sdk/platforms/android-26/android.jar -M /home/travis/build/commons-app/apps-android-commons/app/build/intermediates/manifests/full/beta/release/AndroidManifest.xml -S /home/travis/build/commons-app/apps-android-commons/app/build/intermediates/res/merged/beta/release -m -J /home/travis/build/commons-app/apps-android-commons/app/build/generated/source/r/beta/release -F /home/travis/build/commons-app/apps-android-commons/app/build/intermediates/res/beta/release/resources-betaRelease.ap_ -D /home/travis/build/commons-app/apps-android-commons/app/build/intermediates/multi-dex/beta/release/manifest_keep.txt --custom-package fr.free.nrw.commons -0 apk --output-text-symbols /home/travis/build/commons-app/apps-android-commons/app/build/intermediates/symbols/beta/release --no-version-vectors}

@neslihanturan  is there anything that can be done to solve this error?

I restarted the Travis build, lets see if it works. :)
Also, when was the last time you rebased on master?

4 days ago :)

Hmm. @maskaravivek do you think we can just ignore Travis this time? The failure seems to be technical from what I can see.

I don't think we can ignore the build failure. The :app:processBetaReleaseResources task is failing that points to some resource issue. PFA screenshot of logs pointing to the resource causing issues.

@maskaravivek  @misaochan  thanks for helping in debugging the issue. I changed the location of resources, this should resolve the issue.

How do we rerun the travis ?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d6a4188). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #1300   +/-   ##
========================================
  Coverage          ?   3.18%
========================================
  Files             ?     132
  Lines             ?    7086
  Branches          ?     682
========================================
  Hits              ?     226
  Misses            ?    6845
  Partials          ?      15

Impacted Files
Coverage Δ

.../free/nrw/commons/upload/SingleUploadFragment.java
0% <ø> (ø)

...nrw/commons/upload/MultipleUploadListFragment.java
0% <ø> (ø)

...java/fr/free/nrw/commons/upload/ShareActivity.java
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a4188...685b1ca. Read the comment docs.

Both checks are passing now. Going ahead and merging it. :)


How to use PurgeCSS with extract-css-chunks-webpack-plugin

Hello,
I would like to use PurgeCss in addition to css-chunks-html-webpack-plugin and extract-css-chunks-webpack-plugin.
Following the documentation, I ended up doing sometthing like :
`
  const ExtractCssChunks = require('extract-css-chunks-webpack-plugin');
  const HtmlWebpackPlugin = require('html-webpack-plugin');
  const CssChunkHashPlugin = require('../lib');

  module.exports = {
    plugins: [
      new ExtractCssChunks(),
      new CssChunkHashPlugin({ inject: true }),
      new PurgecssPlugin({
         paths: glob.sync(`${PATHS.style}/*`),
      }),
      new HtmlWebpackPlugin({...entryFileOptions}),
    ]
  };

`
Which obviously doesn't work - I believe it's to be expected as I can't provide a list of static entry points to the purge plugin. As you said earlier, it's always good to have examples  and I would love someone to put me in the right direction for this.
Thanks for your time

Hey, Thanks for creating this issue.
Purgecss should be compatible with extract-css-chunks-webpack-plugin but I have not tested that yet.
The first thing I noticed was that it looks like you are passing only your style files to path with glob.sync(${PATHS.style}/*), you actually don't need to pass the style files into purgecss in webpack, they come from webpack itself.
You should be passing the template files in path, so your html/php/pug/ejs/etc... files.
Please try to change that and see if it works


Two sources of truth for active textures/shaders

It occurred to me last night that we track the active texture and shader in two places:

The opengl layer, for the purpose of preventing needless state changes.
The graphics layer, for the purpose of auto-flushing batched geometry.

It'd probably make things simpler if we could unify these somehow? I've got visions of them getting out of sync and making things horrendous to debug...

Given that GL handles are basically free to clone, we could probably just store a copy of the active texture/shader and == it rather than using an enum as an indirection. If we really wanted to optimize, we could store the GL ID number instead, but I don't know if it's worth the effort...

This is actually a little bit more complex than I gave it credit for - the opengl layer stores what's currently bound, whereas the graphics layer stores what's about to be bound when the batcher flushes.

I still think the code could be clearer, but I don't think this issue in particular is relevant any more.


[SPARK-14988][PYTHON] SparkSession catalog and conf API

What changes were proposed in this pull request?
The catalog and conf APIs were exposed in SparkSession in #12713 and #12669. This patch adds those to the python API.
How was this patch tested?
Python tests.

Test build #57278 has started for PR 12765 at commit a263f74.

Test build #57280 has started for PR 12765 at commit d32ee8c.

Test build #57278 has finished for PR 12765 at commit a263f74.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57278/
Test PASSed.

Merged build finished. Test PASSed.

Test build #57280 has finished for PR 12765 at commit d32ee8c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57280/
Test PASSed.

Test build #57289 has started for PR 12765 at commit 923b92a.

Test build #2916 has started for PR 12765 at commit 923b92a.

Test build #2917 has started for PR 12765 at commit 923b92a.

Test build #2918 has started for PR 12765 at commit 923b92a.

Test build #2917 has finished for PR 12765 at commit 923b92a.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

cc @davies

Test build #2918 has finished for PR 12765 at commit 923b92a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #2916 has finished for PR 12765 at commit 923b92a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #57289 has finished for PR 12765 at commit 923b92a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57289/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #57306 has started for PR 12765 at commit 923b92a.

Test build #57306 has finished for PR 12765 at commit 923b92a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57306/
Test PASSed.

Merged build finished. Test PASSed.

@davies I'm going to merge this first and address your comments in a future patch. Thanks for the review.


[FRONTEND] Implement the ability to sign up

Implement on the front end the ability for the users to sign up
Specs
Should have an icon link in the header which redirect to the signin/signup page

I could try helping you out with that!

Thanks for your help @croustys! Someone is already taking care of it though 👍

Can you please help with the sign in icon and poistion of it

Hey @shreyas098! Thanks for your help! I'm sorry, but someone is already taking care of this issue

No problem . If there is anything else i can help do let me know @aliceandbob-io

Sure! Thanks 👍


add option to put import type statements at the thop

I have the following imports:
import type { ComponentProps } from 'svelte';
import { writable } from 'svelte/store';

import type Modal from './Modal.svelte';

And I'd like some configuration to sort all the import type statements at the top, like this:
import type { ComponentProps } from 'svelte';
import type Modal from './Modal.svelte';

import { writable } from 'svelte/store';

Would also be nice if we could configure type imports to be separated by group.
import type { foo } from 'some-lib'
import type { bar } from 'other-lib'

import type { baz } from '@/baz'

import qux from 'some-lib'

import quux from '@/quux'

We had this in #153 and it will be released in the next major version. We released it in v4.1.0 mistakenly and reverted it later on.
If you still like to try then install v4.1.0 and use importOrder: ["<THIRD_PARTY_TS_TYPES>", "^[./]", "<TS_TYPES>^[./]"],

Possible to re-include types for a 4.x version?
I would like to update prettier to v3
Thanks :)

Would this also work when using the import { type Something } ... syntax?

I join in the wait. I would like to have the type sorting function available using prettier 3.

Any news on this?

Any updates ?


Tokens without USD value

[ ] USD value for tokens that dont exist in the rate API (should be very edge case)
for tokens that dont have USD value, we should use the bancor rate to calculate this.
USD value of the token = 2nd token $Value * (spot rate between 2nd token to 1st token. we use this calculation for price impact)
example = $4191 * (1/572.3) = 1 unit of 1st token = $7.3230823

cannot reproduce


No esm, add tests

Remove needless esm loader, add basic tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b9d8fd2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #4   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         2
  Lines           ?       190
  Branches        ?        39
========================================
  Hits            ?       190
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d8fd2...0e31778. Read the comment docs.


🚀 [Feature] : Add Testimontals Section

Is your feature request related to a problem? Please describe.
Customers often seek reassurance and validation before making a purchasing decision. Without a testimonials section, they may lack insight into the positive experiences of previous customers, potentially leading to hesitation or uncertainty.
Describe the solution you'd like
I propose adding a testimonials section to our platform where satisfied customers can share their experiences and feedback. This section would prominently display quotes, ratings, and possibly even photos or videos from satisfied customers, providing social proof and building trust with potential customers.
Describe alternatives you've considered
An alternative could be integrating customer reviews from third-party platforms, but having an in-house testimonials section allows for more control over the content and presentation. Additionally, it fosters a sense of community within our platform.
Additional context
Adding a testimonials section aligns with our goal of enhancing user trust and engagement. It can be strategically placed on product pages or the homepage to maximize visibility and impact.
If you want speed up process of this issue, please send 🚀 as a reaction.

iOS Reviews
Great!! ⭐⭐⭐⭐⭐
by Julia Pettersson Westin – Apr 10, 2024
Even tho it’s still in a developing process, everything is very good and the app is really helpful!
Version 0.9.1 Sweden

:D  ⭐⭐⭐⭐⭐
by Emerald-Princess – Feb 21, 2024
Good looking, easy to handle and contact happens really quick :D
Version 0.5.15 Germany

An alternative app to other apps language exchange apps  ⭐⭐⭐⭐⭐
by Burak12332221 – Feb 20, 2024
I like the interface and using. It s a very new app so my advise would be to improve the process of joining this community. Maybe an iq test at first to join :)
Version 0.5.15 United States

Супер 😊 ⭐⭐⭐⭐⭐
by Kate Pas – Feb 20, 2024
Хорошее приложение для изучения языков, которое постоянно улучшается, в основном все действительно заинтерисованы в изучении языков, нет мошенников как в других приложениях, спасибо большое за отличное прилиложение для языкового обмена🙌🏼😌✨
Version 0.5.14 Colombia

Useful app ⭐⭐⭐⭐⭐
by nesrincetin – Feb 13, 2024
It's a great app where you can meet new people and practice
Version 0.5.7 Türkiye

The best app ⭐⭐⭐⭐⭐
by oyusnskska – Feb 8, 2024
The best app dor language learning
Version 0.5.3 Türkiye

Super duper ⭐⭐⭐⭐⭐
by Tech Lavır – Jan 20, 2024
An emerging app with a promising future! Exciting features and a user-friendly interface make this application a potential game-changer in the world of language exchange. Keep an eye on it for innovative experiences and growth! I highly recommend it!
Version <IP_ADDRESS> Türkiye

Try and see the difference than others ⭐⭐⭐⭐⭐
by Penmek – Jan 15, 2024
New and better than any other lang exchance app in the market.
Version 0.3 Canada

Android Reviews (some of them)

@jakebogan01 You can pick any of them which fits your work/template ! :)

@xuelink thank you!

@xuelink hey do you have the link to those google reviews?

@jakebogan01 can u please check your email, i ve sent you an invitation of our google play store account

@xuelink Thank you, looks like I need permission to see the reviews and analytics

@jakebogan01 i think you can see now :D

@xuelink Thank you, I made a PR here


Would you please provide a GPU friendly batched parallel execution

Thanks for providing a nice work.  Now, I find that in QNN demo, pythorch forward, batch samples are handled one by one in a for loop,  which is unfriendly for GPU. I look forward to a faster version of parallel execution. Thanks.

Thank you for your comment. If you are using PyTorch backend, you can install functorch, and then use the vmap function for batch execution. Some modification is done on develop branch for fulfilling vamp's requirements and Quantum_transfer_learning_original_circuit.ipynb DressedQuantumNet class is also updated as usage reference.
You need to install functorch as below for PyTorch 1.12.0 cu102 binary
pip install --user<EMAIL_ADDRESS>https://pytorch.org/functorch/stable/install.html
For small batch size and small qubits, maybe CPU is faster than GPU. If the input data of quantum function are all in GPU, then TeD-Q will run on GPU, otherwise it will use CPU.


Merge all plugin jars into single one for new plugin model

IntelliJ platform 2021.2 introduced new plugin model to make support for dynamic unloading easier and more stable.
Now the plugin can declare some modules inside it (slightly modified optional dependency from plugin model 1.0) with own dependencies on other plugins or modules. At the same time, the implementation of new plugin model supposes that all manifests (plugin.xml or module manifests) are located in single jar file to make classloading faster. As a result, it forces plugin writers to assemble all plugin jars into single jar file.
And it's a quite complex task for plugin writers if their plugin project consists of several Gradle modules. You can't just "hack" jar task of the root plugin module to create single jar because the current PrepareSandboxTask implementation collects all jars of plugin project into single directory that's supposed to be archived into plugin artifact and you have to come up with some workaround not to pack classes from submodules twice and at the same time not to miss jar files of external dependencies. As a result, it leads to quite weird implementations like this one in EduTools plugin or this one in Perl plugin. And strictly speaking, my implementation in EduTools plugin works by accident because we declare external dependencies for all Gradle modules including root one (where they are redundant) for some reason. But if we remove these "unnecessary" dependencies from the root module, the plugin artifact won't contain jars of external dependencies.
You may note that the platform doesn't force you to migrate to the new plugin model (at least, for now). But it's not strictly true because:

dynamic unloading should work properly only with the new plugin module
if you have a dependency on another plugin, you may face with issues like https://github.com/intellij-rust/intellij-rust/issues/7448 [^1] at any moment and, as I understand, there are only two solutions:

hack platform not to throw an exception in your specific case. It was done for Rust plugin to fix https://github.com/intellij-rust/intellij-rust/issues/7448 but it's not a good solution for any external plugin
migrate your plugin to new plugin model to provide proper dependencies

So it would be really great to simplify migration to new plugin model for all plugin writers outside of IntelliJ repository and provide proper plugin artifact creation out of the box
[^1]: Situation: you have a dependency on plugin P and you use some class C from it. At one moment, plugin P is migrated to new plugin mode and class C is moved to new module M of plugin P. After this, you will start to get exceptions like com.intellij.diagnostic.PluginException: Class `C` must be not requested from main classloader of `P` plugin [Plugin: %your.plugin.id%] without any change from your side. And the proper solution is to declare a dependency on module M but you can't do it from old plugin model

Grazie Pro would also benefit from both fat jar and v2-style optional dependencies

Hello, I created a small PR that adds option to use other Jar task (custom Gradle Jar or Gradle Shadow plugin) by passing in name of such task.
With this I was able to create plugin fat jar out of 1 main and 5 supporting modules.

Implemented in a5f3bbc27704931a44fc44980ca9c52a140e6029


Save UI settings

Hi,
i made an app with this package and some people ask me to save the theme they use before they close the app. Is someone know how to do ?
Thanks !

Save materialSkinManager.Theme and materialSkinManager.ColorScheme to Properties.Settings.Default
Then load this settings on event Form_Load

winform provides a function to save theme and other setting.
read：
https://learn.microsoft.com/en-us/dotnet/desktop/winforms/advanced/how-to-read-settings-at-run-time-with-csharp?view=netframeworkdesktop-4.8&source=recommendations
write：
https://learn.microsoft.com/en-us/dotnet/desktop/winforms/advanced/how-to-write-user-settings-at-run-time-with-csharp?view=netframeworkdesktop-4.8&source=recommendations


feat(logic/basic): simplification lemmas for transport through trivial type families

These theorems seem a bit specialized. Is there some principled reason that these theorems in particular are needed? Otherwise I would suggest you keep them with their uses. By the way, the first theorem eq.rec.constant follows from eq_rec_heq and eq_of_heq. For the others, you shouldn't be using ulift.rec in the first place; the recommended interface is using up and down only.

Okay.
All of them arise by using cases analysis on ulift or plift
hypotheses, or induction on equality hypotheses. Of course other
relatives of these will arise from doing case analysis on other types, I
just haven't run into anything else that got stuck in the same way.
I use them in the category theory library; they seemed completely out of
place in the first individual files they are needed in, so I thought I'd
gather them together. I'm happy if we close this request, although they'll
be back later. :-)
On Sun, Apr 29, 2018 at 3:38 PM Mario Carneiro<EMAIL_ADDRESS>wrote:

These theorems seem a bit specialized. Is there some principled reason
that these theorems in particular are needed? Otherwise I would suggest you
keep them with their uses. By the way, the first theorem eq.rec.constant
follows from eq_rec_heq and eq_of_heq. For the others, you shouldn't be
using ulift.rec in the first place; the recommended interface is using up
and down only.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/leanprover/mathlib/pull/124#issuecomment-385227433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdLBN0Mfj96X0iSvmE9SKvcjRdGvk_Pks5ttVHQgaJpZM4TrNVv
.


svg: Nested clip-paths are displayed incorrectly

A clip path can have another clip-path. Currently only the first clip path is displayed.
<svg  viewBox="0 0 100 100"  xmlns="http://www.w3.org/2000/svg">

  <clipPath id="myClip2">
     <path id="path2" d="M40,40 L90,40 L90 90 L 40 90 Z" fill="red"/>
  </clipPath>

  <clipPath id="myClip">
     <path id="path" d="M20,20 L70,20 L70 70 L 20 70 Z" fill="red" clip-path="url(#myClip2)"/>
  </clipPath>

  <path
    id="heart"
    d="M10,30 A20,20,0,0,1,50,30 A20,20,0,0,1,90,30 Q90,60,50,90 Q10,60,10,30 Z" clip-path="url(#myClip)" />

</svg>

a temporal regression during dev

Maybe this problem is closer to https://github.com/thorvg/thorvg/issues/2928#issuecomment-2459065122.

Maybe this problem is closer to #2928 (comment).

I checked that https://github.com/thorvg/thorvg/pull/3079 fixed it.


App does not initialize

Description
The latest version of this app (main) does not initialize and just displays

The currently deployed version (1.3.1) is working fine.
Steps to Reproduce

Clone the main branch of this repository
npm install
npm run start
Navigate to the local app in New Relic
Notice the message

Expected Behaviour
The app loads without an issue.
Relevant Logs / Console output
There were no errors in the logs.
Your Environment

NR1 CLI version used: @datanerd/nr1/1.32.0 darwin-x64 node-v10.16.3
Browser name and version: Chrome 89.0.4389.90 (Official Build) (x86_64)
Operating System and version: MacOS Big Sur 11.2.3

Thanks Alex. Replicated here. Seems to be failing locally but the version in the New Relic app catalog works just fine.
Looks like the query for accounts is returning NULL, but the query ran independently against the account returns results fine. Investigating to see why this weirdness might be happening.

@aswanson-nr looks like it may just be a New Relic staff impact. If you remove your profile and regenerate it in your CLI. It began working again for me no problem.

@goldenplec You were completely right! Looks like it was user error! Sorry to take up your time.


Need Help Compiling StartCoin With Static Boost Libraries

Hello,
I am having problems compiling StartCoin. I am building startcoind on one machine with all dependencies installed and I want to run that same binary on another machine without any of those dependencies. The first issue I hit is:
./startcoind: error while loading shared libraries: libboost_system.so.1.54.0: cannot open shared object file: No such file or directory
I know if I installed libboost1.54 on the machine running the binary it would work. However, this server is meant to be clean - NO GCC, NO LIBBOOST, NO LIBDB4.8. Everything has to be built into the binary. Please offer me guidance on how to do this.

Hi Steve,
following these steps is a good place to start. It really depends upon your toolchain and OS but compiling with the -static flag and ensuring the linker includes any dynamic libs/shared objects is the basic premise. You will probably also want to strip the executable when it's compiled the reduce the size.

Thanks for the response @lukem512 After some trial and error I finally got it, given your resources.
make STATIC=1 -f makefile.unix startcoind USE_UPNP=
I hope this helps someone in the future.


client.Replicas always return sorted list

Versions
Sarama Version: 240fd146ce68bcafb034cc5dc977229ffbafa8ea
Kafka Version: <IP_ADDRESS>-2
Go Version: go1.9.1 linux/amd64
Configuration
default
Problem Description
I'm trying to use your library to detect if the leader for certain  partition is the preferred leader.
So I have 3 kafka nodes cluster with multiple topic,  calling e.client.Replicas("test-topic", 0)) will always return a sorted list:
[1 2 3] <nil>

however some of my topic have replicas configured as
Replicas: 3,2,1 Isr: 1,2,3
Replicas: 2,1,3 Isr: 2,1,3
Replicas: 1,3,2 Isr: 2,1,3

Hmm, can you please double check that you are using the version you think you are? The exact issue was fixed already in https://github.com/Shopify/sarama/pull/930.

I cannot reproduce this bug. I've run your script against my cluster and it is printing the replicas in the right order for me.

I can't reproduce, and the code looks correct. Without more information of some sort I'm afraid I won't be able to help you. I would suggest adding some log statements to a local copy of Sarama, or something like that, to debug it further and figure out where the sorting is happening.


[BUG]  update_test_case function is not working when passing obj = types.TestCase

Expected Behavior

should update the test case
Current Behavior

it's not updating the test case
Possible Solution

it should update the test case when passing an obj AND passing a key /value
Steps to Reproduce

test_cases_list = TestCases(creds_path=creds_path, agent_id=agent_id).list_test_cases()

test_case_id = [test_cases_list[0].name][0]

Update the display name of the test case
ex_test_case=test_cases_list[0]
ex_test_case.display_name = "josh is testing"

tc.update_test_case(test_case_id=test_case_id, obj = ex_test_case)

Context (Environment)

Detailed Description

Possible Implementation

@jkshj21 IIRC the update methods in SCRAPI mimic what the base class was doing, which is why these were implemented in a way that required the kwargs to be provided.
However, because SCRAPI is meant to be an "easier" implementation, it does make sense to support this.
I'm discussing with @MRyderOC offline and we'll come up with a solution that will work for all update methods that can be inherited.
Will circle back soon on this.
Thanks!

ok, thank you!


Fix broken documentation in bias and scale.

This PR fixes broken documentation in bias and scale.

LGTM!


Update hierarchy

In AEM, authors can create a free-formed hierarchic structure of folders and email pages under /content/campaign to prepare the content of the various emails.
The nested structure could be composed only of email page components, meaning that the email component would also be used to create nodes that only intend to serve as a folder. That way, if there are inherited properties, they can be set on the parent email component that serves as folder.

[x] Check: Is the hierarchy limited by AEM or ACC?
[x] Check: Does the UI / API / ... currently available in ACC support deeper hierarchy?
[x] Update hierarchy from flat to deep in AEM
[x] Check if we can mirror the same hierarchy in ACC with the sync process
[x] If not possible to have deeper hierarchy, check if there are other ways to improve UX

Deep structures can be build in AEM with the Core Email Page. However, the structure remains flat in ACC. We still need to test if the transfer to ACC works fine for the page structure once that works in general.


Cypress/E2E: Clean up on type with force and use of template literals

Summary
Clean up on type with force and use of template literals
Ticket Link
none
Release Note
NONE

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/218933

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/218977


docs/languages/en/modules/zend.test.phpunit.rst Classnames are outdated

@Maks3w Any news or can this be closed?


Dcarpente/output compressed web

It's possible to build FFMPEG without some codecs, but that makes it impossible for FFmpegInterop to work with sources that use those codecs. This change allows FFmpegInterop to output compressed samples from containers that use Opus codec (like Ogg) while using FFMPEG binaries that were built without the Opus codec. This change should make it easier to add this same functionality for additional audio codecs.
This can be tested by building FFMPEG with --enable-demuxer=ogg flag but without --enable-decoder=opus flag. Example Opus file: http://hpr.dogphilosophy.net/test/opus.opus

@dcarpente,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Adding a privacy-focused analytics to the project

If anybody has strong feelings about analytics, let me know.
I'll leave this open for a little bit, since it's not that important.

@luizstacio @hugobdev @pedronauck
Do any of you know whether this is a good analytics tool?

Won't be adding analytics to this project.


feat: implement circuit v2

Reopen the earlier circuit v2 implementation by @mpetrunic with a few fixes to ensure it is up to date with libp2p.
@mpetrunic looks mostly okay, but could you do a rough pass to make sure I haven't missed anything?
Todo:

[x] Interop testing https://github.com/libp2p/interop/pull/83
[x] Update relayv2 to proto3: https://github.com/libp2p/specs/issues/509

Is there anything blocking the PR review?

Is there anything blocking the PR review?

I think todo's are:

revisit configs
add go interop tests

But I think this shouldn't block reviews^^

I'm curious how this PR relates to AutoNAT (https://github.com/libp2p/js-libp2p/issues/1005).
Isn't AutoNAT generally a prerequisite prior to doing NAT hole punching?

I'm curious how this PR relates to AutoNAT (#1005).
Isn't AutoNAT generally a prerequisite prior to doing NAT hole punching?

@2color Yes AutoNAT is a requirement. You can see our roadmap issue for what's all needed: https://github.com/libp2p/js-libp2p/issues/1461
RelayV2 is required for WebRTC browser-to-browser as well which is why we're doing this right now.

@achingbrain seems like you already took a review pass at this. Let me know if my review would still be helpful

So far so good, only a couple of things to tidy up I think:
Looking through the spec, something missing here is enforcing limits on data transfer and reservation length.  This will need to be implemented & tested before merging.
Also tagging relay peers so we don't close connections to them under load.

So far so good, only a couple of things to tidy up I think:
Looking through the spec, something missing here is enforcing limits on data transfer and reservation length. This will need to be implemented & tested before merging.
Also tagging relay peers so we don't close connections to them under load.

Writing the tests right now.

@achingbrain I added transfer limits and tests for it. For data limits, the Go code discards any data read (silently) after the limit is exceeded, while for the duration limit, it fails with a ErrDeadlineExceeded once the duration is completed. In the js case, the current implementation closes the source/sink silently once either limit is exceeded. Is this the required  behaviour?

For data limits, the Go code discards any data read (silently) after the limit is exceeded, while for the duration limit, it fails with a ErrDeadlineExceeded once the duration is completed. In the js case, the current implementation closes the source/sink silently once either limit is exceeded. Is this the required behaviour?

Having talked with @Jorropo and @mxinden this isn't the correct behaviour - I've opened https://github.com/libp2p/specs/pull/526 to document what should happen - the stream should be reset.


external tests docker images are hard coded to adoptopenjdk

Hi,
We are trying to run the external tests in our own infrastructure. One improvements that I would like to make is make the external tests more configurable.
My plan is similar to the dockerImageTag variable, and I am planing add another 2 variables, dockerImageName.
For IMAGE_NAME, I want to do something like this inside https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/build.xml file:
<if>
	<isset property="env.IMAGE_NAME"/>
	<then>
		<property name="dockerImageName" value="${env.IMAGE_NAME}"/>
	</then>
	<else>
		<property name="dockerImageName" value="adoptopenjdk"/>
	</else>
</if>

Please let me know what you think.
I will test this idea in our infrastructure first.
Thanks!

hi @junyzheng - thanks for looking at this, I am also currently working on a clean-up of these external tests, before we enable testing of the other Docker images that we produce at the project... my very initial branch of this was here: https://github.com/smlambert/openjdk-tests/tree/expandExternal - see in particular the external/build.xml file for how we redirect to the other tags.   Starting this work has now led to a bigger overhaul of the external test repo... where we will get rid of some of the duplication we have and use common Dockerfiles for most of the applications.
It will be great to co-ordinate with you, and get your input!  I will try to push an update of my branch later this week to share where I was thinking of going with it...

Hi @smlambert just checked your branch and it looks awesome! I want to branch out from your branch, and add a patch to make the hard coded adoptopenjdk configurable. I will create a PR against your branch so you can see whether it makes sense or not. Please let me know what you think about this approach.

Go for it, we can talk later in the week, to see how things look.  :)

Related PR: https://github.com/smlambert/openjdk-tests/pull/1

Hi @junyzheng - please see if the approach in https://github.com/AdoptOpenJDK/openjdk-tests/pull/1660 addresses this hardcoding issue you have raised.  (we will merge 1660 shortly and follow on with a 2nd PR to convert the remaining external dirs).

@junyzheng Like @smlambert mentioned #1660 will address this. You should be able to pass in a build arg allowing you to overwrite the FROM image with whatever image you need. What image where you looking to utilize?

@junyzheng can you update this ticket with the results of your test?

sorry, just saw this. I will check this today.

@smlambert hmm, I saw the IMAGE_NAME in the dockerfile, but it seems there is no way to override it. Just wondering is this expected or did I miss something?

Yes @junyzheng, the Dockerfile that is present will no longer be used (and soon will be removed from all the directories).  Instead we now generate the Dockerfiles on the fly, based on DOCKERIMAGE_TAG and using build_image.sh script
As I reread this issue, do I understand you wish not to use the BASE image from AdoptOpenJDK docker hub registry but from some other registry?  As its true, even when we build the test Dockerfiles on the fly, use the AdoptOpenJDK Docker images as the base.

@junyzheng Like @smlambert the Dockerfiles that are present will be removed in favor of dynamically generating the Dockerfiles.
With that being said, both the present and generated Dockerfile support building with a different base image.
In the current images, the top of the Dockerfile might look like this:
ARG SDK=openjdk8
ARG IMAGE_NAME=adoptopenjdk/$SDK
ARG IMAGE_VERSION=nightly

FROM $IMAGE_NAME:$IMAGE_VERSION

When building the Dockerfile, which happens when you run a test, you could pass in the build args of IMAGE_NAME and IMAGE_VERSION. Thus allowing you to pull from whatever base image you want be it OpenJDK or another Java base image.
As for the new generated Dockerfile there are similar build args. Here is what one generated Dockerfile looks like:
ARG SDK=openjdk8
ARG IMAGE_NAME=adoptopenjdk/$SDK
ARG OS=alpine
ARG IMAGE_VERSION=nightly
ARG TAG=$OS-$IMAGE_VERSION

FROM $IMAGE_NAME:$TAG

This time around I tried to make the build args more robust. In the end you can still pass in build args for IMAGE_NAME and TAG, which again will allow you to pull from any base image you need.
@smlambert Currently, using the grinders is there still an option to put in Docker build args? If so this would allow @junyzheng to build and run tests against any base image he needs.
@junyzheng Does provide the flexibility you need?

@smlambert because we have our internal docker registry so need to pull image from our internal one instead of the AdoptOpenJDK.
@james-crowley Thanks! The IMAGE_NAME and TAG options sounds like a good plan, it will solve all the problem and make the configuration very robust.


[Docker] bash: change_volumes_owner.sh: No such file or directory

I was following the CONTRIBUTING.md and running npm run docker:run-once.
Tried twice, it failed twice on npm run docker:init. I just tried running npm run docker:init separately, got bash: change_volumes_owner.sh: No such file or directory
NOTE: I am using docker toolbox on Windows.
 Failed at the<EMAIL_ADDRESS>docker:init script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR!      C:\Users\autom\AppData\Roaming\npm-cache\_logs\2019-12-22T15_08_09_866Z-debug.log

The repository needs to be in a shared directory.  Have a look at the docker guide

I have followed this guide, still doesn't works (Same error). Any other tips?
I even tried sharing in VirtualBox access to another folder, even moving the repo to this new folder it doesn't works.
I tried moving to C:\Users and to C:\Users\autom (Current user)

Any luck here @Ronkiro?

Any luck here @Ronkiro?

Nope, i gave up as i were still to learn it.

Thanks, we have retired the docker setup for the lack of maintenance. We understand the need for isolation by some and recommend using GitPod instead.


ECL results table corrupts CSV

The ecl search result table is in a "csv" format. However it isnt. It is treating commas in the term as delimiters. In other words, if using CSV it should use quotes on the text.
Strange anyway as it creates a .txt file. Needs fixing

Example - Influenza vaccinations, ECL: <<<PHONE_NUMBER>001108


plug potential memory leak in error code path

Function module_add() may leak stack of modules when it fails to initialize newly added module.
Fixes #23835

This pull request is ready to merge

Merged to the master branch. Thank you.


WFLY-14249 Ensure java.time/sql.* ProtoStream marshallers generate valid protobuf messages

https://issues.redhat.com/browse/WFLY-14249
Additionally, the native protostream marshallers introduced in this PR result in smaller payload sizes for typical values, see jira for specifics.
Requires https://github.com/wildfly/wildfly/pull/13902

@rhusar Please review.

@rhusar Please review.

Closing to rebase on WFLY-14359.

Closing to rebase on WFLY-14359.


[bn] Localize for continuous-deployment.md

Signed-off-by: Sajib Adhikary<EMAIL_ADDRESS>Signed-off-by: @sajibAdhi<EMAIL_ADDRESS>Describe your changes
link -> https://glossary.cncf.io/continuous-deployment/
Related issue number or link (ex: resolves #issue-number)
#410
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[ ] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@sajibAdhi  you made a mistake but copying branch from main and thus this PR has been messed up. Need to close this PR.


Bug: Add license section in readme.md

Add license section in readme.md

@Acash512 pls assign me this issue.

@ishitakapoor26 License is there in the bio of project, there is no need for license description in readme


only contributors to submit expenses

now that we are improving the flow through which contributors are added to a collective. I think we should allow only contributors to submit expenses. As this scales, it will become increasingly difficult the manage the approval and doing this removes a layer of complexity.
What was the logic behind allowing anyone to submit an expense?

A few reasons we did this:

We didn't have a login system in place. It's something we need to build for other reasons as well.
It's a heavy enough action that we are unlikely to see random expenses submitted. It's like Pull Requests on Github, anyone can submit it. The organizers can discuss, ignore, or close it if they don't want it.

Are we seeing examples of people submitting errant expenses that they shouldn't be?

We haven't seen that yet. But:

It's an inefficient flow: an expense submitted I see it in the activity feed, contact the organizers to see if it's legit and then approve it. It's fine now because it's small but if if do our job right, it shouldn't be fine much longer.
It's a problem for large organizations like wwcode who don't know their local chapters members and they want to avoid the pain of adding a step in the process of managing financials - which we are trying to remove friction from. They specifically said this was a security issue for them.


merge dll  crash in unity

two dll is ok，megered dll  is ok， can opened with ilspy or reflector，see is  normal， but when  use in  unity，direct crash，hope get some advice=。=

Can you provide crash information (log, dump)? And an example DLL would be nice too. Because without any details it is dead case.

error.log

Crash.zip   mergedll  and dmp

Access violation in crash log and seems fine DLL.

I saw 3 different version of Dotween in references, is it ok?
Do you have all referenced assemblies in you asset folder?
Try to add only this DLL without .pdb/.mdb files.

Unity version 2017.4.1 no crash on start-up. No error in logs either.

1, is  ok，all need
2，all referenced  assemblies in asset，if not，unity just error，not  crash
3，try and also crash
i am in company，so  must  use  the same unity version [version: Unity 5.6.3p3_88d4ddf6344a]

Crash1.zip
can you try this

Still no crashes on Unity 2017.4.1
This is Unity-related problem, not ILRepack.


Scale barplot thicknesses relative to tree size; makes default layout barplot lengths look thicker; fix a small Colorer bug

Part of the work on #276. This should make barplots look more consistent between the rectangular and circular layouts, and in particular make circular layout barplots' defaults look a lot more legible. Barplot lengths, rather than being in arbitrary units, are now scaled by the tree "thickness" (root to farthest tip width in the rectangular layout, 2 * that distance for the circular layout).
Old:

New:

Note 1: currently I have this set so that the default barplot layer length, 100, is equal to 1/10th of the tree "thickness." If folks would prefer a thinner default setting, we can adjust the scaling code as needed.
Note 2: I also noticed and fixed a small problem with the Colorer module, where the "freebie" problems with barplot borders we discussed in #400 re-emerged. Basically, this was because rgbToFloat() was being called on a GL array (with colors in the range [0, 1]), not on an RGB array (with colors in the range [0, 255]) -- so the RGB float colors didn't match. I added and tested some code to do the RGB -> GL conversion. I also bit the bullet and added a test that verifies that the "freebie" checking works (i.e. unnecessary triangles aren't being drawn), and added some extra barplot testing code.

The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv

Thanks @ElDeveloper! Should be addressed now.
I also noticed a small bug where barplot border lengths weren't being scaled in the same way that the other barplot lengths were being scaled -- that should be fixed in 56552f5. (I also changed the default barplot length from 50 to 10, since I think borders being 5% of the tree thickness looked a bit weird -- in practice this looks similar to the previous default setting before this PR.)

Thanks @fedarko!


Add the Prism Syntax Highlighting Plugin WIP

Add the prism syntax highlighting plugin to the AAA, set its config and modify some import statements.
The plugin on GitBook Plugins: https://plugins.gitbook.com/plugin/prism
Solves #96

Cool! I'll build this and check it out when I get home.

Added WIP so that I can squash the commits before we rebase the commits onto master (to keep the signature).

Overall, it looks good. There still seem to be some errors on building certain esoteric languages, but I guess that is to be expected.

Yeah, Prism drops errors for Chip-8, TI-83 Basic, Factor and Whitespace since they aren't on supported languages (yet).


Egress Gateway: Remove deprecated CENP CRD

<!-- Enter the release note text here if needed or remove this section! -->

/test

/test

/test

/test-1.16-4.9

[1.16-4.9 flaked with Unable to download helm chart v1.11 from GitHub]

/test

ci-aks seems to be hitting https://github.com/cilium/cilium/issues/22162.

ci-aks seems to be hitting #22162.

(we enabled it back just to debug it, but it's not actually required at the moment)

[also needed to drop the privileged tests for the old-style configuration without node selector]

/test

/mlh new-flake Cilium-PR-K8s-1.16-kernel-4.9

/mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next

/test-1.16-4.9

/test-1.26-net-next


Better way to inject authentication data after registration

Hello,
I hope community and/or developers can come up with better way to do the following:
       let {email, name, password} = this.getProperties('email', 'name', 'password');
        this.set('errors', null);
        Ember.$.ajax({
          method: 'POST',
          url: "/api/v1/auth/register",
          data: { email, name, password },
        })
       .then(
         (data) => {
           // DIRTY HACK to avoid login procedure:
           //this.get('session').authenticate('authenticator:oauth2', email, password);
           this.get('session.session')
           ._setup('authenticator:oauth2', data, true)
           .then(() => { this.dialog.close() });
         }
       )

Our registration API generates session token and I don't want to pass login/password twice what will result in two sessions on the server.

Why do you want to avoid the login procedure?

second session generation, two requests to the server. are these not enough?

Preventing a second request seems like over-optimization to me to be honest. I'm not sure about the point with preventing a second session. I'd say the registration endpoint should not create a session at all as registration as such shouldn't necessarily be coupled to logging in.
If you absolutely want to do this though you could create a custom authenticator (as an extension of the OAuth 2.0 authenticator) that can either take a username and password or an object with an access token in it. In the former case it would simply delegate to it's parent and in the latter case it would resolve with the object that's being passed right away.


hello my adres

Description:
Describe your proposal.
Justification:
Justification or a use case for your proposal.
Are you willing to submit a PR?

0x6F99E90Dd385c23826b416528e325214671FeBf6

Closing this issue as it seems like spam.


VPC: Default AZs to 3

Right now, the default for the # of AZs is "as many as you can get", which leads to consistent problems in us-east-1 (because it has so many AZs): I can't start a default VPC because I run out of EIPs.
What's worse, code that runs fine in one region fails to start in us-east-1 because of this, which is worse. You think you've tested something, but then it doesn't work.
Since there's diminishing returns of additional AZs after the 3rd, why not default to 3? (But let users raise the number, obviously, if they really want to).
Also, we should probably make it possible to define an offset as well, so that you can have two VPCs spread over all 6 AZs (one a-b-c, the other d-e-f).

@mindstorms6 @PaulMaddox what do you guys think?

I agree with diminishing returns for spreading architectures across more than 3 AZs, but i don’t think your suggestion is the right way of achieving this.
If we split the VPC CIDR into three AZs worth of subnets, what happens later if they want to add more AZs? The IP space will be all allocated, and their options would be super limited and likely result in a very disruptive redeployment of their whole application.
I think it’s better to carve the VPC subnets into all available AZs, but maybe have a method that gets public/private subnets for a limited number of AZs, which can be used to deploying the applications.
The downside is NAT gateways would be deployed to all SubnetType.Private subnets (incurring a cost), and I’m open to suggestion on ways to improve that - I just can’t think of a nice API experience right now.
Maybe a boolean flag on a subnet configuration for “enabled”? That way subnets could be in a non-active state, reserved for future use.

So for brevity I think defaulting to 3 is a good idea. Now the how is interesting.
If you try to say spread the subnets across all AZs and pick every nth one, the logic is much more complicated and the user is going to have to understand more options because no matter what you do this algorithm of subnet allocation is inherently public.
I personally think for advanced additions adding additional vpc associations should be considered. As an enterprise customer we intentionally allocate medium to small blocks for IPAM considerations (aka you are not going to see a /8 /16 in any of our accounts unless it's experimentation). The second part is we (CDK) do not prevent teams from adding subnets to VPCs using the current L2 construct; do we? So as long as you don't allocate all IP space, you can manually carve up your extra space as you see fit. I think it's fair to expect a user that has saturated IP space to be a knowledgeable user and be able to implement this, but that's my opinion with 0 data to support.
So all this leads me to asking what if we kept what is there today, but default the maxAZs to 3 unless you specify more? How bad is our L2 Subnet addition experience? I think this is mostly what @rix0rrr was proposing.

The downside is NAT gateways would be deployed to all SubnetType.Private subnets (incurring a cost), and I’m open to suggestion on ways to improve that - I just can’t think of a nice API experience right now.

@PaulMaddox what do you think of the current natGateways: number, natGatewayPlacement: VpcPlacementStrategy? The issue is if you want to control exactly which subnets use specific Gateways it's not 100% in your control. Again if you have this type of concern, I tend to expect you to be a power user and able to create a proper L2 based on L1s to meet your extremely high performance use case.

Actually don't know if offsetting adds any value; only comes into play if you have 2 vpcs in 1 account, and customers would only care about failure domains, not sharding for capacity.
Although I did get an EKS error that in one AZ there was no more EKS capacity, I would want recourse when that happens

@rix0rrr - is it worth separating this issue?

Probably


Validate step

I have followed all steps, but the validation part is not ok... I can login into a teams client, but not a Skype for business Client. the Co-existance setting in Teams is set to "Teams Only"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05282aa8-ae14-117b-5885-7d851ee66b89
Version Independent ID: 85abe13c-d34c-f42c-e273-a69be8cd991e
Content: Deploy Microsoft Teams Rooms with Microsoft 365 or Office 365 - Microsoft Teams
Content Source: Teams/rooms/with-office-365.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@nicolasVaneberg thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


[MM-50430] Fix Forgot Password link when login with email is enabled

Summary
The wrong variable was used for the login page.
Ticket Link
https://mattermost.atlassian.net/browse/MM-50430
Related Pull Requests
N/A
Screenshots
N/A
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

/update-branch


WinRAR Crack 7.01 Final + Keygen Free Download [Latest]

WinRAR Crack 7.01 Final + Keygen Free Download [Latest]
WinRAR Crack Free Download is a powerful archive manager that provides full support for RAR and ZIP archives and decompresses CAB, ARJ, LZH, TAR, GZ, ACE, UUE, BZ2, JAR, ISO, 7Z, Z files. Its RAR format may only be the second in its compression level – but it is always the fastest in packaging and unzipping files. Although RAR files are not native files for Windows or Mac, many other compression programs still decompress it. Despite this name, WinRAR Crack download 64 bit available on Windows, OSX and Linux.
Download Now

.

Download-Setup 👈
.
.
Full-Setup 👈
.
.
Free Download 👈
.
.


update annual review

Signed-off-by: Yu Zhao 00540916<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please specify parts this PR updates:

[ ] Specification
[ ] Schema
[ ] Examples
[ ] Extensions
[ ] Roadmap
[ ] Use Cases
[ ] Community
[ ] TCK
[ x] Other

What this PR does / why we need it:
update annual review
Special notes for reviewers:
Additional information (if needed):

@yzhao244 thanks!!


Feature - Exception page - Add copy file

Usecase:

an error is thrown
you get the stacktrace presented
you see the files (and their code lines)
I want to open this file in my IDE

Currently, I have to do my best to get the filename, because of disturbing collapsing.
Ideally, I would click on the filename and it would be opened automaticallly by my favorite browser.
If that is not possible (never digged into this), would love to see a button for  'copy filename to clipboard' so I have a optimal processes:

click on button
ctrl-o in IDE

and there I go!

I think it should be possible to form a link IDE could understand. Saw that in Netbens docs years ago.

hmm...
I see something over here https://pla.nette.org/en/how-open-files-in-ide-from-debugger

something similar on this matter is to provide the file corresponding with the error. Look at this pic:

I would find it very useful to get the full path of the for dmn\yii2\components\relations\components\LinkActiveQuery so I can easily look in this file as its namespace does not give me enough info to get to its file fast enough

I think this is implemented and thus can be closed!
http://www.yiiframework.com/doc-2.0/ext-debug-index.html#open-files-in-ide

not for exceptions

2 days ago thought that it will be good to do the same for exceptions :)

Implemented.


Reinstate dialyzer spec checking in travis build

Removed in #185 due to random failures would be great to have again.

Important input from @nobbz

Exit code 137 means that a process is killed because the system went out of memory. There is no timeout happening, but dialyzer is quite hungry for memory, I'm not sure if there are many options to adjust.

Are the timeouts due to the PLT generation step? If so, is it possible to cache the PLT on AWS or something similar?

I'm looking into the PLT generation error this morning. Here are a couple of things I'm trying:

Running with sudo: required so we get to run on a vm with 7.5GB of memory.
Using travis_wait to make sure we don't time out if we don't receive output for 10 minutes while the plt is being generated.

Once the PLT is built and in our cache the builds should be quick. I also did see a prebuilt PLTs repo that could be helpful, but I'm not sure how it will work since we are adding an additional application (inets) to our plt. It will definitely be worth looking into if the above options don't work.


Microsoft.WindowsAzure.Management.Monitoring.Alerts CreateOrUpdateAsync Error

I am trying to create an Azure alert using the AlertsClient
My resourceid looks like the following:
        var resourceId = ResourceIdBuilder.BuildCloudServiceResourceId(
            "<cloud service name>",
            "<deployment name>",
            "<role name>");

My create method is as follows:
private static Task CreateAzureAlert(string resourceId, AlertsClient alertsClient)
{
var rule = new Rule
{
Name = "CPU Alert",
Id = Guid.NewGuid().ToString(),
Description = "If CPU usage is greater than twenty percent then alert",
IsEnabled = true,
Condition = new ThresholdRuleCondition
{
Operator = ConditionOperator.GreaterThan,
Threshold = 10,
WindowSize = TimeSpan.FromMinutes(15), //new TimeSpan(0,0,5,0),
DataSource = new RuleMetricDataSource
{
MetricName = "Percentage CPU",
ResourceId = resourceId,
MetricNamespace = "WindowsAzure.Availability"
}
}
};
        RuleAction action = new RuleEmailAction
        {
            SendToServiceOwners = true
        };

        ((RuleEmailAction) action).CustomEmails.Add("email@address.com");
        rule.Actions.Add(action);
        rule.LastUpdatedTime = DateTime.UtcNow;

        var response = alertsClient.Rules.CreateOrUpdateAsync(new RuleCreateOrUpdateParameters
        {
            Rule = rule
        }, CancellationToken.None);

        return response;
    }

The error message I am getting is:
{"<string xmlns="http://schemas.microsoft.com/2003/10/Serialization/\">{\"Code\":\"InvalidRequest\",\"Message\":\"Could not find any metric definitions."}"}
Please check and let me know if I am doing something wrong. Many thanks

please reopen if this is still an issue.


can i add where in selectable

Laravel Version: #.#.#
PHP Version:
Laravel-admin: #.#.#

Description:
Steps To Reproduce:

Yes
in make method
public function make()     {     $this->model()->where('user_type_id','<>','3'); . . .    }

Selectable works basically as Grid with some layout changes. But you can overwrite them to if you want.
My approach is to do
/** @var Grid */
$grid = $this;

at the beginning of the make method to make it more familiar.


Adding 'Post', 'Poll', 'PollFile', 'Choice' models and tests

changing name 'resumeApp' to 'posts'
Replacing 'nohup' command with 'setsid' command in setup.sh (as Barak recommended)
Adding abstract Post model
Adding Poll model that inherits from 'Post'
Adding model PollFile that stores files that belong to a 'poll'
Adding 'Choice' model that stores choice options of a poll
Adding tests for all the models

The PR divided to several commits so it is easier to review

You need to fix the grammar in two of the notes, other than that looks good to me.

Thanks, fixed it.

We need to review this according to the ERD, the ERD we have is not the updated one.
Please upload the updated ERD.


Fix error on vue app unmount

Removed timeout since it was causing JS error if vue app was unmounted after confirming the dialog
Fixes https://github.com/wobsoriano/vuetify-use-dialog/issues/25

any thoughts on this @wobsoriano?


[Draft] Merge up to September 20th

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[ ] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary

Changelog

Test Plan

Regarding Metro failing to load InitializeCore, this is due to a config error:
diff --git a/packages/react-native/react-native.config.js b/packages/react-native/react-native.config.js
index 1303d8a28f..335271934d 100644
--- a/packages/react-native/react-native.config.js
+++ b/packages/react-native/react-native.config.js
@@ -19,7 +19,7 @@ const {

 // Remove commands so that react-native-macos can coexist with react-native in repos that depend on both.
 const path = require('path');
-const isReactNativeMacOS = path.basename(__dirname) === 'react-native-macos';  // [macOS]
+const isReactNativeMacOS = true;  // [macOS]
 const iosCommands = isReactNativeMacOS ? [] : ios.commands; // [macOS]
 const androidCommands = isReactNativeMacOS ? [] : android.commands;  // [macOS]
 const macosCommands = [require('./local-cli/runMacOS/runMacOS')]; // [macOS]

I'm not sure whether we still need isReactNativeMacOS, but the check is wrong now that the repository has been turned into a monorepo.


Standardize internal table representation

testplan.common.utils.table.TableEntry is maintained internally as a list of lists

Close the PR.

Close the PR.


wazevo: lower memory wait to ssa

Not too sure what I'm doing so sending out lowering of one atomic op to understand the pattern, hopefully it will be enough to do the rest in the later PR.
I'm trying to compare to wasmtime but not sure if I'm doing something wrong. For this wat file
(module
  (import "console" "log" (func $log (param i32)))
  (func
    (i32.const 5)
    (i32.const 0)
    (i64.const 10)
    memory.atomic.wait32
    (call $log)
  )
  (memory 1 1 shared)
  (export "" (func 0))
)

I get
❯ target/debug/clif-util wasm --target aarch64-apple-darwin test.wat -p -t
function u0:1(i64 vmctx) fast {
    gv0 = vmctx
    gv1 = load.i64 notrap aligned readonly gv0
    sig0 = (i32, i64 vmctx) fast
    fn0 = u0:0 sig0

                                block0(v0: i64):
@0038                               v1 = iconst.i32 5
@003a                               v2 = iconst.i32 0
@003c                               v3 = iconst.i64 10
@003e                               v4 = iconst.i32 0xffff_ffff
@0042                               call fn0(v4, v0)  ; v4 = 0xffff_ffff
@0044                               jump block1

                                block1:
@0044                               return
}

I initially used the same wat as my test case but thought some optimization may be happening so tried adding the call $log, but still somehow it is just v4 = iconst.i32 0xffff_ffff. Any idea what I'm doing wrong?

Thanks @mathetake - can you check this is going in a reasonable direction? I think what's left is defining the trampoline for the wait function

Basically you should be able to achieve lowering without adding any new instruction

Thanks for the patience @mathetake I think this is on the right way now

want to add a e2e test case in https://github.com/tetratelabs/wazero/blob/main/internal/engine/wazevo/e2e_test.go#L39 ?

Added a simple e2e for now for the "not equals" case, other ones will be trickier / require notify to be implemented.
And fixed a bug

looking good! will take a look tomorrow

lastly could you fix the conflict

Thanks, resolved conflicts


executeCommand changeSet fails on >=3.10.1

Environment
Liquibase Version: >=3.10.1
Liquibase Integration & Version: ant
Liquibase Extension(s) & Version:
Database Vendor & Version: MariaDB 10.3
Operating System Type & Version: Debian Stretch
Description
A changeSet with only a <executeCommand> statement fails in >=3.10.1, it works under 3.10.0.
Unable to update database. liquibase.exception.MigrationFailedException: Migration failed for change set liquibase.xml::xxxx::xxxx:
     Reason: java.lang.ClassCastException: liquibase.database.jvm.JdbcConnection cannot be cast to com.datical.liquibase.ext.database.jvm.ProJdbcConnection
        at liquibase.changelog.ChangeSet.execute(ChangeSet.java:659)
        at liquibase.changelog.visitor.UpdateVisitor.visit(UpdateVisitor.java:53)
        at liquibase.changelog.ChangeLogIterator.run(ChangeLogIterator.java:97)
        at liquibase.Liquibase.update(Liquibase.java:201)
        at liquibase.Liquibase.update(Liquibase.java:178)
        at liquibase.Liquibase.update(Liquibase.java:328)
        at liquibase.integration.ant.DatabaseUpdateTask.executeWithLiquibaseClassloader(DatabaseUpdateTask.java:34)
        at liquibase.integration.ant.BaseLiquibaseTask.execute(BaseLiquibaseTask.java:88)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
        at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        at org.apache.tools.ant.Task.perform(Task.java:348)
        at org.apache.tools.ant.Target.execute(Target.java:435)
        at org.apache.tools.ant.Target.performTasks(Target.java:456)
        at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
        at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38)
        at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
        at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:441)
        at org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:105)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
        at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        at org.apache.tools.ant.Task.perform(Task.java:348)
        at org.apache.tools.ant.Target.execute(Target.java:435)
        at org.apache.tools.ant.Target.performTasks(Target.java:456)
        at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
        at org.apache.tools.ant.Project.executeTarget(Project.java:1376)
        at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
        at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
        at org.apache.tools.ant.Main.runBuild(Main.java:857)
        at org.apache.tools.ant.Main.startAnt(Main.java:236)
        at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287)
        at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113)
Caused by: java.lang.ClassCastException: liquibase.database.jvm.JdbcConnection cannot be cast to com.datical.liquibase.ext.database.jvm.ProJdbcConnection
        at com.datical.liquibase.ext.SqlPlusRunner.buildConnectionString(Unknown Source)
        at com.datical.liquibase.ext.SqlPlusRunner.createFinalCommandArray(Unknown Source)
        at liquibase.change.core.ExecuteShellCommandChange.generateStatements(ExecuteShellCommandChange.java:142)
        at liquibase.database.AbstractJdbcDatabase.executeStatements(AbstractJdbcDatabase.java:1256)
        at liquibase.changelog.ChangeSet.execute(ChangeSet.java:622)
        ... 36 more

┆Issue is synchronized with this Jira Bug by Unito

Ok this seems to occur in some cases for 3.10.0 too but not 3.9.0. I'm using <antcall> in my build.xml and I can avoid this error by specifying inheritAll="true" in some cases... but not in all :/ So perhaps it's ant related but can't make any sense of it.

Hi @chas-mafli Can you provide your changelog that produces this error?

@molivasdat it just looks like this (some things omitted)
<changeSet author="xxx" context="xxxx" id="xxxxx">
    <executeCommand executable="php">
        <arg value="${basedir}/database/xxxxx.php" />
        <arg value="-e" />
        <arg value="${app.env}" />
    </executeCommand>
</changeSet>

@mattbertolini the offending part looks like this
<updateDatabase
    changeLogFile="${database.changelog}"
    classpathref="class.path"
    contexts="${liquibase.contexts}">
    <changeLogParameters>
        <changeLogParameter name="preinit" value="${liquibase.preinit}"/>
        <changeLogParameter name="app.env" value="${app.env}"/>
        <changeLogParameter name="basedir" value="${basedir}"/>
    </changeLogParameters>
    <database driver="${database.driver}" url="${database.url}"
        user="${app.db.user}" password="${app.db.password}"/>
</updateDatabase>

Now I can't seems to reproduce this inheritAll="true" thing so perhaps I was just confused. I've had much back and forth with this thing so I'm a little puzzled haha. I'm using inheritRefs="true" though just to be clear.
But yeah no I'm not using pro so my thinking it should never try to use ProJdbcConnection?

Perhaps it has something to do with an <antcall> to a target with its own antcalls, i.e. nested antcalls. Because the target that antcalls the update target works fine directly from the ant cli but targets that uses that target with antcall produces this error it seems.

@chas-mafli It may have something to do with <antcall> in combination with the usage of the classpathref attribute. The <antcall> task does not inherit references by default and the classpathref is using a reference so it's probably not getting the desired classpath to the updateDatabase task. You can inherit references in <antcall> by setting the inheritRefs=true attribute as well as the inheritAll=true flag for properties [0].
I would try that and see if anything changes. Report back and we can take a look further.
[0] https://ant.apache.org/manual/Tasks/antcall.html

Hmm. Nested <antcall>s can be a tricky business. For this to work you will need to set inheritAll="true" and inheritRefs="true" on each <antcall> for the Liquibase task to work (but it sounds like you've done that already).
Since you're not using pro, I'm a bit curious how the pro jar is getting onto the classpath? How exactly are you creating the classpath defined with id class.path? Could you output the path by doing something like <echo>${toString:class.path}</echo> in the ant file near the updateDatabase task? I'm guessing that if the pro jar is no longer on the classpath then the exception will go away since there is nothing to cast to. I don't have any pro experience myself so I'm not sure how that class would be loaded. It seems like it would be detected dynamically if it's found on the classpath. Perhaps a liquibase dev could clarify that.
If the liquibase task works directly with the ant cli I'm hesitant to say there is a bug but there may be some areas to improve the ant tasks if we can find out what is causing the exception (and the presence of the pro jar).

I just download the jar here from github and put it on my classpath so there's nothing weird on it really.
I did some more tests and now it seems like on 3.10.0 it fails in this way with nested antcalls but on >=3.10.1 it fails even if the antcalls aren't nested.

Ok so I ran Java 8 before and now I tested on 11 and it fails with unnested and nested calls on 3.10.0 and on >=3.10.1 it works with unnested calls but fails with nested... the other way around that is :/

Thanks for this info! It's helped me learn a bit more. I've downloaded the same jar you did and examined its contents. I found the pro classes contained in the jar. I had no idea they were there so I definitely learned something.
Here's what I've figured out about the error:
Caused by: java.lang.ClassCastException: liquibase.database.jvm.JdbcConnection cannot be cast to com.datical.liquibase.ext.database.jvm.ProJdbcConnection
        at com.datical.liquibase.ext.SqlPlusRunner.buildConnectionString(Unknown Source)
        at com.datical.liquibase.ext.SqlPlusRunner.createFinalCommandArray(Unknown Source)
        at liquibase.change.core.ExecuteShellCommandChange.generateStatements(ExecuteShellCommandChange.java:142)

When I look at the ExecuteShellComamndChange class I can clearly see it's designed to be subclassed and that is exactly what SqlPlusRunner does. Now I don't entirely know why SqlPlusRunner is selected over the ExecuteShellComamndChange class but I think it probably has something to do with Liquibase's priority system for service loading. The ExecuteShellComamndChange class has a default priority but I don't know what SqlPlusRunner's priority is as I don't have the source code for pro. Since the SqlPlusRunner is clearly selected we can assume it's priority is higher.
It's the SqlPlusRunner class that tries to cast the JdbcConnection to a ProJdbcConnection which is definitely not possible right now in the ant tasks as they are not aware of pro classes and don't create them.
One possible way to fix this would be to check to see if the class can be cast before performing the cast. Another possible fix is to not load the pro classes when pro is not requested. Another option is to enhance the Ant tasks to be pro-aware (have some sort of boolean flag that can be toggled). All of these fixes are outside of my abilities as I don't have access to the pro codebase.
And all of this is even more confusing since you say that it sometimes works! That one I'm still baffled by. My only hunch on that is the nested <antcalls> are messing with the classpath order and classloaders so that sometimes the pro classes are loaded later and therefore not found so Liquibase can select the regular ExecuteShellComamndChange class.
@molivasdat Do you have any thoughts on this?

@mattbertolini ah so you could reproduce it yourself at least!
The "sometimes works" was before I saw this antcall pattern and the fact that 3.9.0, 3.10.0 and >=3.10.1 all behaved differently which of course added to the confusion.

@mattbertolini and @chas-mafli I am just as puzzled on the intermittent differences.  I'll check internally with the folks that have access to Pro and see what I can find.  May be next week until I can get back to it.

I'm not sure but I might I'm on to something. I spent some more time investigating last night and I do see a discrepancy on how the Ant tasks create the DatabaseConnection and how other integrations do (like the CLI).
The Ant tasks create the JdbcConnection manually via the DatabaseFactory.findCorrectDatabaseImplementation() method passing an already created JdbcConnection object. In other integrations, the DatabaseFactory.openDatabase() method is called which creates the connection object itself. There is much more sophisticated logic around selecting the proper connection type in this DatabaseFactory (via the ConnectionServiceFactory). This may explain why the Ant tasks are unaware of the pro connection types.
I am going to dig a little more and see if this affects the exception. I will hopefully have more information soon. Regardless of whether this fixes the problem, that is definitely something to change.

Hi @chas-mafli
One of our developers took a look at this and used this as an example and worked for him.
<project name="liquibase-test" default="update" basedir="." xmlns:liquibase="antlib:liquibase.integration.ant">
  <target name="prepare">
    <path id="classpath">
      <pathelement location="lib"/>
      <fileset dir="lib/">
        <include name="*.jar"/>
      </fileset>
    </path>
    <taskdef resource="liquibase/integration/ant/antlib.xml" uri="antlib:liquibase.integration.ant">
      <classpath refid="classpath"/>
    </taskdef>
    <!-- set global properties for this build -->
    <property name="db.url" value="jdbc:oracle:thin:@localhost:1521/BUCKET_01"/>
    <property name="db.user" value="username"/>
    <property name="db.pass" value="password"/>
    <liquibase:database id="my-database" url="${db.url}" user="${db.user}" password="${db.pass}" driver="oracle.jdbc.OracleDriver"/>
  </target>
  <target name="default" depends="prepare" >
    <antcall target="update" inheritrefs="true">
    </antcall>
  </target>
  <target name="update">
    <liquibase:updateDatabase
      changeLogFile="oracle_lbpro_master_changelog.xml"
      classpathref="classpath"
      labels="setup,shell">
      <database driver="oracle.jdbc.OracleDriver" url="${db.url}" user="${db.user}" password ="${db.pass}"/>
    </liquibase:updateDatabase>
  </target>
</project>

Would this work for you?

Following up on my comment from few days ago. I'm thinking the exception was intermittent because of race condition loading data in the DatabaseFactory and ConnectionServiceFactory. I no longer think it has to do with <antcall> issues since I can sometimes cause the issue in my debugger.
I have opened a PR (#1427) to change the Ant tasks to properly leverage the DatabaseFactory like the other integrations do. This should make the connection creation logic a lot more predicable and properly support pro connection types if desired. I'm fairly confident this will solve the issue but at the very least, it will bring the Ant tasks in line with the rest of the codebase.

@molivasdat tried that example and it works fine with 3.9.0 but gets the same cast exception on 3.10.2 like before.
@mattbertolini doesn't seem like a race condition to me seeing as I could reproduce it without fail again with @molivasdat example? Though it sounds like your PR there should fix it I guess. Don't think I have time to test it though (well compile it and all that jazz that is).


Printing a table

Howdy folks 👋
I'm wondering if anyone has had any success in trying to print an ember-light-table. I've tried a few things but because of some of the magic you are doing with height and two different tables (one for head and one for body) it seems impossible 🤔
I would love to have something that I could pass into the rendering of the table to essentially just say "stop all magic and just give me a table", that way I could turn off the magic before printing.
I am able to do this in Javascript because essentially my "printing" is happening in fastboot.
Any thoughts? In the mean time, I have reverted to just building a "normal" table in my template 😂

I should have mentioned that the main issue with the table is that it is getting cut off at exactly one screen height because I have set the height to be 100vh

I think the solution to this problem is two-fold:

#468: generate traditional "single <table>" markup in Fastboot
disable fixed headers for @media print

The latter one is already possible by overwriting our and ember-scrollable's styles. However, it won't work for tables that have occlusion rendering (#435) enabled .
Ideally we would ship some default styles that user can opt in to and would expand scrollable tables to their full height on printers.

I would love to have something that I could pass into the rendering of the table to essentially just say "stop all magic and just give me a table", that way I could turn off the magic before printing.

When #468 lands we could also provide an escape hatch to tables rendered in the browser, however I believe that would be the wrong approach for enabling printing.

I played around with some styles and I think media queries are a viable solution here.

I know there is plenty of work still to do but man am I glad it's not just a simple fix (i.e. i'm not crazy) 😂
That media query stuff that you were doing, was it using a "fixed height" i.e. setting the pixel height?   Also is there something between Brando and Bridget? i.e. are you missing an entry?
One thing that was interesting when I just built a standard table for my needs is that it seems (in chrome at least) the table headers are repeated on each of the pages that are printed

I know there is plenty of work still to do but man am I glad it's not just a simple fix (i.e. i'm not crazy)

Well you already could make your light tables more printer-friendly by tweaking the CSS a bit. :stuck_out_tongue_winking_eye:

That media query stuff that you were doing, was it using a "fixed height" i.e. setting the pixel height?  Also is there something between Brando and Bridget? i.e. are you missing an entry?

It's the example from our demo page. I manually disabled the fixed height (as a media query would do) and tweaked some other layout settings, in order for the table body to expand as tall as its content.
There's no row missing between Brando and Bridgette.
The last row is indeed cut off, but I believe that's just some minor issue with margins and paddings that is not unfixable.
So to sum it up, no there's no row missing. :slightly_smiling_face:

One thing that was interesting when I just built a standard table for my needs is that it seems (in chrome at least) the table headers are repeated on each of the pages that are printed

That is standard behavior when using a single <table>´. Ideally we would also enable this, but methinks that's really only possible when we have a single element...   We *could* possibly simulate a singleby rendering a secondin the mainthat's only visible for@media print`.
I'd like to hide that behind a flag though, since it will incur a performance hit.

I managed to get some pretty nice looking printable tables, all I really did was disable the fixed header in my table, and remove the height declaration from the table (causing it to height auto). I have hundreds/thousands of records in my table and they definitely all appear in the print page
{{#light-table table responsive=true as |t|}}
{{t.head fixed=false}}
I also had to make some specific style changes in my print.scss but those were all changes specific to my website (removing website navbar, borders, setting body { overflow: visible !important; }  - that one caused my table to get cut off as well but is only an issue if you have your body element normally scrollable)

Actually I might have spoken too soon. When I Save To PDF, and set the page to Landscape, some rows are split between pages (half of the row is printed on the page before).
I also noticed that (no matter what print options) at the end of each page an additional horizontal line is drawn, making it look like there is an empty row?? You can see this in the picture I attached above, right at the bottom of the first page.

@Techn1x page-break might be what you're looking for.

My webapp needs to print multi-page tables and I've come across some quirks when printing these large tables (mostly IE/Edge). In case this helps anyone, here's the SCSS I use to make large ELT's printer-friendly
.ember-light-table {
  // Fix #2: After applying fix #1, sometimes this class gets overflow, and it is set to overflow:auto, making a scrollbar appear for various browsers.
  // Either visible/hidden is fine, just not auto
  // overflow: visible !important;
  overflow: hidden !important;

  // Fix #3: After applying fix #1, Edge & IE will render all rows correctly, but IE & Firefox have a large gap after tables, due to flexbox bugs?
  display: block !important;

  .lt-body-wrap {
    // Fix #1: This prevents IE11/Edge issue for large tables where after page break, the rest of the table will not render.
    overflow: visible !important;

    // Fix #3: see above
    display: block !important;

    .lt-inline.lt-head {
      break-after: avoid; // Stop the header from being separated from the body of the table
      break-inside: avoid; // Stop the header from being broken (eg if using subcolumns)

      // Fix #4: On Chrome, if there is enough room at the end of the page for some of the header block, and a page break occurs inside it (despite the above),
      // it can cause the header to be rendered twice in a glitchy way (once at the end of the previous page, and again on the next page)
      // https://github.com/offirgolan/ember-light-table/issues/579
      // Need to set the header block to not be 'table-header-group', which seems to cause this behaviour
      thead.lt-head {
        display: table-footer-group;
      }
    }
  }

  // Don't allow page breaks inside cells
  // NOTE: th's are basically the same as td
  table tr, table tr td, table tr th {
    break-inside: avoid;
  }
}

Used with basic ELT markup like
{{#light-table table
  responsive=false
  as |t|}}
  {{t.head}}
  {{t.body}}
{{/light-table}}


Deploy sdist to PyPI

Resolve #22

We'll likely have to push a patch release for this to land. Should we hold on that until #20 (and #15) is resolved?

If the release process is automated anyway (e.g., kicked off by a GitHub / git release tag), I don't see a problem with not waiting and doing a couple quick releases.

If the release process is automated anyway (e.g., kicked off by a GitHub / git release tag), I don't see a problem with not waiting and doing a couple quick releases.

Correct.  All we have to do is tag and it will be pushed.

Nice! Are you planning to tag a new release?

I saw you just did. Thank you!


fix(protractor): isPresent() should work with out of bounds errors

Follow up from https://github.com/angular/protractor/pull/3056

LGTM once Travis is happy (sauce connect failed to start, I've restarted the job)