Simplified EXO V2 Module note in cmdlet ref topics

Tired of waiting for APEX to fix the problem. Can always reformat later

Docs Build status updates of commit b8fe9c3:
:clock10: Full build: the average full build time is 18 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit b8fe9c3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Add-RecipientPermission.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Add-UnifiedGroupLinks.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Delete-QuarantineMessage.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-HostedOutboundSpamFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-JournalArchiving.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-HostedOutboundSpamFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-OrganizationCustomization.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Export-QuarantineMessage.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AccessToCustomerDataRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdministrativeUnit.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdvancedThreatProtectionDocumentDetail.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdvancedThreatProtectionDocumentReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdvancedThreatProtectionTrafficReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AtpPolicyForO365.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CASMailboxPlan.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CalendarDiagnosticObjects.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-Clutter.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ComplianceTag.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ComplianceTagStorage.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ConnectionByClientTypeDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ConnectionByClientTypeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsAVConferenceTimeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsActiveUserReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsClientDeviceDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsClientDeviceReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsConferenceReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsP2PAVTimeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsP2PSessionReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsPSTNConferenceTimeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsPSTNUsageDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsUserActivitiesReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsUsersBlockedReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DataClassificationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DataEncryptionPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DataRetentionReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DkimSigningConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DlpDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DlpDetectionsReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DlpSensitiveInformationTypeRulePackage.md
:white_check_mark:Succeeded
View (exchange-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c5e54e3:
:clock10: Full build: the average full build time is 18 min(s) 8 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c5e54e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Add-RecipientPermission.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Add-UnifiedGroupLinks.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Delete-QuarantineMessage.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-HostedOutboundSpamFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-JournalArchiving.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Disable-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-HostedOutboundSpamFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-OrganizationCustomization.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Enable-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Export-QuarantineMessage.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AccessToCustomerDataRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdministrativeUnit.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdvancedThreatProtectionDocumentDetail.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdvancedThreatProtectionDocumentReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AdvancedThreatProtectionTrafficReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-AtpPolicyForO365.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CASMailboxPlan.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CalendarDiagnosticObjects.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-Clutter.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ComplianceTag.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ComplianceTagStorage.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ConnectionByClientTypeDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ConnectionByClientTypeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsAVConferenceTimeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsActiveUserReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsClientDeviceDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsClientDeviceReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsConferenceReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsP2PAVTimeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsP2PSessionReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsPSTNConferenceTimeReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsPSTNUsageDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsUserActivitiesReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-CsUsersBlockedReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DataClassificationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DataEncryptionPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DataRetentionReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DkimSigningConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DlpDetailReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DlpDetectionsReport.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DlpSensitiveInformationTypeRulePackage.md
:white_check_mark:Succeeded
View (exchange-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Possible Carousel for Product Cards

On mobile, it might be better to have a horizontal carousel to display the product cards. Once the user hits the end of it, they can hit the next page button, or go to another page that has all the new products. Right now, they scroll so far down the screen.

solved, via non pagination on first 2 sections


Add example to Configurations.md for blank_lines_lower_bound.

Referenced in issue #2312
I'm not sure how to tell if this setting is in stable or not. If it is in stable, I'll need to make a small tweak before this is merged.
I chose a location in the file that kind of makes sense, but if it should be somewhere else, I'll also change that.

Hi @CaptainKraft, fortunately there is already a PR which fixes #2312. I am going to close this PR in favor of #2313, but thank you so much for your contribution!


Add the packaging metadata to build the augur snap

This is a package for the secure installation of apps that works in most Linux distributions.
Landing it upstream will enable builds for adventurous users.

You can find more information about snapcraft here: http://snapcraft.io/
To test it in an Ubuntu 16.04 machine:
$ sudo apt install git snapcraft
$ git clone https://github.com/elopio/augur
$ git checkout snapcraft
$ cd augur
$ snapcraft
$ sudo snap install *.snap --dangerous

Open the browser and go to localhost:8080
If you have any questions or comments, please let me know.

Coverage remained the same at 74.05% when pulling 744155410fd959ac451c9b11ce886b83c00e2652 on elopio:snapcraft into d575574afb930d9ae1ce892773f1d4b45aefbd9c on AugurProject:master.

Nice, thanks @tinybike !
Did you take a look at snapcraft.io ? Now that there's a snap in your project, it would be great if you register it in the store: https://myapps.developer.ubuntu.com/dev/click-apps/register-name/
And after that, we can hook travis to make automatic releases to the edge channel every time there's a change in master, to get feedback from early adopters.

I did skim snapcraft.io.  It looks useful, although of course the devil is in the details.  Am I correct to think of this as a sort of apt-get for dockerized applications, or is that wrong / missing some important nuance?

That is actually a good summary in one sentence ^_^
It's like apt-get, but it is also transactional, it has rollbacks, automatic updates and you can release any time to the official archive, you don't have to follow the distro release cycle, and you don't need a distro maintainer to do it for you. Also your snap is self-contained, so you don't have to follow any rules for packaging. Whatever works for you is ok, because your snap can't affect the system and can't affect other snaps.
It's like docker for applications, but it's more lightweight because it runs directly on top of the operating system, you don't need an additional OS to isolate your app. And you can share any resources you want from the system and other snaps through the secure use of interfaces (the plugs section in this yaml declares the interfaces that your snap will connect to). So a full system of snaps can run in an armhf system like raspberrypi without a lot of overheard.
I would love if you give it a try and let me know your opinions, what you find useful or what you find confusing. We are talking to a few upstreams to gather feedback that will help us set the priorities of our backlog for the next months.
Thank you!


BUG: crash / core dump when calling scipy.stats.beta.ppf with certain parameters (boost-related)

Reproducing Code Example
import scipy.stats
scipy.stats.beta.ppf(0.995, 1.0e11, 1.0e13)

Error message
terminate called after throwing an instance of 'boost::wrapexcept<boost::math::evaluation_error>'
  what():  Error in function boost::math::tgamma<double>(double,double): Series evaluation exceeded 1000000 iterations, giving up now.
Aborted (core dumped)

SciPy/NumPy/Python version information
1.7.1 1.21.2 sys.version_info(major=3, minor=9, micro=6, releaselevel='final', serial=0)

Note that this crash only occurs for scipy v1.7.0+, which is when the boost versions of many stats functions (including for the beta distribution) were first integrated. My suspicion is that scipy's boost error-handling policies just aren't catching this particular exception.

Sounds like an issue in underlying Boost code. @mckib2 are you able to check this easily?
But yes, sounds like we should return a Python error in this case.

With the (large!) caveat that I don't know much about this stuff, the fact that the error message references boost::math::evaluation_error suggests to me that perhaps ('BOOST_MATH_EVALUATION_ERROR_POLICY', 'ignore_error') should be added to the list of DEFINES in setup.py. In fact, there are a bunch of BOOST_MATH_xxx_POLICY values defined in the boost repo; would it make sense to include most/all of them as a defensive measure?
In any event, I really appreciate you all taking a look at this!

Sounds like an issue in underlying Boost code. @mckib2 are you able to check this easily?

Checking it out right now, I agree we should try our best to make this a Python exception at the very least

Draft PR: gh-14618
It turns out you can return the best guess in this scenario, so I wrote a function to handle the evaluation_error by raising a warning and returning whatever value is available.  @mdhaber Is there a better warning type to use instead of RuntimeWarning?

I'm not aware of a more specific one.

IMO the draft PR's approach of raising a RuntimeWarning and returning whatever value is available (whether or not it's legitimate) would be the preferred approach. That way the user could either run with the returned value as-is, or catch it with the warnings library and do whatever special handling is preferable for their use case.
I don't really have the expertise to provide detailed feedback on @mckib2 's draft PR, but to my eyes it looks like it would handle this particular issue in an appropriate way. Have either of you put any thought into whether or not it would make sense to add more of the boost math policies listed here to the list of DEFINES in scipy/stats/_boost/setup.py? There appear to be 2 others (BOOST_MATH_POLE_ERROR_POLICY  and BOOST_MATH_OVERFLOW_ERROR_POLICY ) that default to throw_on_error, which I'm guessing would cause crashes just like BOOST_MATH_EVALUATION_ERROR_POLICY did.
Thanks again for looking into this!

I am not sure if any of the functions we use will ever raise a pole error (some special functions like digamma might), so I'm not sure how to create a test that would raise that error.  There's already a RuntimeWarning being raised for overflow errors encountered like this:
scipy.stats.beta.ppf(.1, 1e10, 1e20)

I've played around a little bit, but again I'm not sure how to go about getting a Boost overflow_error.  If you're able to provide a producer for those errors it is straightforward to raise a RuntimeWarning or error like I've done in the PR, otherwise it might be best to wait until someone encounters these errors so we know what tests to write

Yep, good point re: the need for test cases. I don't have any producers for those error types at the ready, so I'm in agreement that at this point it's probably best to wait until someone encounters them. It's very possible that won't happen until/unless scipy.stats starts pulling in more distributions from boost.


where to download reid.h5? The url is 404

Hi, unfortunately, the weight files are lost (as discussed in #8 ). You will have to re-train the network which isn't too hard.
Cheers


Metrics are being rounded to nearest integer, but should be floats.

Tested on server metrics
Example
Level3
http://mlab-api-dot-mlab-oti.appspot.com/servers/AS3356/metrics?timebin=day_hour
{
  "meta": {
    "server_asn_name": "Level 3 Communications, Inc.",
    "id": "AS3356",
    "server_asn_number": "AS3356"
  },
  "results": [
    {
      "count": 282,
      "upload_speed_mbps_median": 1,
      "hour": "00",
      "rtt_avg": 78.562,
      "retransmit_avg": 0,
      "download_speed_mbps_median": 6,
      "date": "2015-10-01"
    },
    {
      "count": 189,
      "upload_speed_mbps_median": 1,
      "hour": "01",
      "rtt_avg": 84.615,
      "retransmit_avg": 0,
      "download_speed_mbps_median": 7,
      "date": "2015-10-01"
    },
    {
      "count": 112,
      "upload_speed_mbps_median": 1,
      "hour": "02",
      "rtt_avg": 45.449,
      "retransmit_avg": 0,
      "download_speed_mbps_median": 7,
      "date": "2015-10-01"
    },
    {
      "count": 107,
      "upload_speed_mbps_median": 1,
      "hour": "03",
      "rtt_avg": 103.015,
      "retransmit_avg": 0,
      "download_speed_mbps_median": 14,
      "date": "2015-10-01"
    },
...

Ends up producing strange charts like

fixed with a tweak to the marshalling. thanks @pbeshai !


<IP_ADDRESS>.0.0

The version number for the previous tagged release was improperly set (by automation, I think) to be <IP_ADDRESS>.0, but IronSource adapter has an extra value, so it has to be <IP_ADDRESS>.0.0.

The changelog needs it too


Fix check for retracted samples not removed

Was quitting and this check sample_removed_not_retracted()

Just deprecate this check for now since it's not essential.


Bug: Code Coverage Report

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.
$ ng --version
@angular/cli: 1.0.0-rc.2
node: 6.9.5
os: win32 x64
@angular/common: 4.0.0-rc.5
@angular/compiler: 4.0.0-rc.5
@angular/core: 4.0.0-rc.5
@angular/forms: 4.0.0-rc.5
@angular/http: 4.0.0-rc.5
@angular/platform-browser: 4.0.0-rc.5
@angular/platform-browser-dynamic: 4.0.0-rc.5
@angular/router: 4.0.0-rc.5
@angular/cli: 1.0.0-rc.2
@angular/compiler-cli: 4.0.0-rc.5
Repro steps.
I have made a sample project, to reproduce this weird behaviour.
Please take a look at: https://github.com/Loster102/angular-coverage-sample
When I run 'ng test -cc true', there is a successful testrun.
But when I look at the coverage report, the branch coverage is really strange.
It says, that the constructor is not fully covered.

Desired functionality.
I would have expected that even the constructor is fully covered.
Mention any other details that might be useful.
In my real world application, there are some further strange behaviours, exactly like the one above.
I try to reproduce these in the sample project. In this application, I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

There are two related issues both in Istanbul and TypeScript:
https://github.com/gotwarlost/istanbul/issues/690
https://github.com/Microsoft/TypeScript/issues/13455
The latest suggestion from both threads is to run tests with coverage targeting ES6 instead of ES5. Unfortunately from what I can tell, the Angular CLI doesn't use tsconfig.json when running tests, and the suggestions of using --compilerOptions '{\"target\":\"es6\"}' won't work since Angular CLI doesn't recognize that.
At the moment, there's nothing to do, adding /* istanbul ignore next */ comments everywhere around the constructor won't help. We're deadlocked while waiting for Angular, Istanbul, or TypeScript to change something.

If there's something we can do to help, we'd like to.

@hotforfeature you can actually change the "target" to es6 in the src/tsconfig.spec.json with the  version of angular cli that you are using. However, if you are running tests on phantomjs it will fail due to the "const" keyword/ES6/ES2015 not being supported yet. There is a beta version of phantomjs that they have released that you could try which should have support for it, but may have other issues.

tsconfig.spec file has es6 as a target, running on CLI-1.0.0 still get all the missing branches from all the constructors, maybe I'm missing something?

I have the same problem as @sandman21dan.
Changed target from es5 to es6 in tsconfig.spec.json and constructor branches are still not covered.
Any idea ?

Any solutions? It is really frustrating :/

Since it is being 2 months, just want to know the progress.
Is there any ETA for this issue resolution?

Changing target to es6 in the main tsconfig.json doesn't work either

Same problem here.

Anyone got anything on this issue resolution ?

Changing to es6 doesn't work here as well. Is there a feasible solution in the works?

Reproduced this issue by simply adding http: HTTP to the constructor of a newly created project created with angular-cli: https://github.com/rg1220/angular-cli-coverage-issue-5526

I have the same issue :( ... Why is it blocked? Can we expect a fix in the near future?

Can we get a status update on this? This is blocking my ability to check in changes as the branches fails imposed standards...

I'm reading from other issues that it may be testing branches inside of super() calls. Is there any info why /istanbul ignore next/ is not working on constructors? Can we get a reason on the blocked label?

Workaround
As a workaround I found the special comment /* istanbul ignore next */
If you place after your class, the constructor gets ignored.
Example
export class InternalComponent {
    constructor(private authService: any) {
    }
} /* istanbul ignore next */

Generates
define(["require", "exports"], function (require, exports) {
    "use strict";
    Object.defineProperty(exports, "__esModule", { value: true });
    var InternalComponent = (function () {
        function InternalComponent(authService) {
            this.authService = authService;
        }
        return InternalComponent;
    }()); /* istanbul ignore next */
    exports.InternalComponent = InternalComponent;
});

Which ignores this line exports.InternalComponent = InternalComponent; that causes the issue.
To ignore super
super() /* istanbul ignore next */;

If you have generics and/or @Inject in your constructor params, try to break lines.
With those hacks I got 100% coverage.

@brunolm This workaround works if you don't use decorator on attribute in your code.

If I remove the @Effect I have 100% coverage... do you have an idea ?

Heya, just wanted to mention that I added the blocked tag because I spent some time trying to fix it and as far as I can tell this is a limitation of the code coverage tools right now. @hotforfeature's comment (https://github.com/angular/angular-cli/issues/5526#issuecomment-288095948) explains the current situation well, I couldn't find any further developments.
Using an es6 target is not a real solution per se either, overall the CLI doesn't really support outputting es2015 (see https://github.com/angular/angular-cli/issues/2907),

Is there any other update? Has this been raised with the code coverage tools support? (I'm a bit new to this) I'm getting the issues @davinkevin mentioned, which breaks the only known workaround (other than lowering the branch requirement, which I'm being told is unsavory.

@filipesilva does #7610 now resolve this in the sense that we can provide es2015 for code coverage to run and it should work?

@brunolm , it works but /* istanbul ignore next */ what does this hack do exactly?

@webcat12345 /* istanbul ignore next */ ignores the line bellow in the coverage. https://github.com/gotwarlost/istanbul/blob/master/ignoring-code-for-coverage.md
Following my instructions it will place the ignore statement exactly at a part of the generated code that is not being accessed.
It is a really ugly workaround and might not work in all cases.

Thanks @brunolm

Because of above kinds of issue, I was going to apply this hack to everywhere lol. you saved my life.

do note @webcat12345  @brunolm when they add --aot support to  ngtest then we'll be able to target es2015 from the resolved #7610 and it will fix everything for tests.

For some reason, after upgrading to 1.5 RC 8 (not sure about previous RCs though) the problem has gotten worse - now it also excludes imports from test coverage, like so:

As a result, my test coverage decreased from 95% to the dangerous 82% :(

With the release versions (Angular 5.0.0 and CLI 1.5) all coverage now appears perfect! There was a transient remap problem due to something in RC 8 and/or possibly TS>2.4. Is everyone's else experience the same?

@dinvlad that's somewhat surprising to me, because I haven't actually added any fixes in 1.5.0 for this. But maybe the change in compiler pipeline helped somehow, or one of the dependencies that does coverage had fixes in it.
Can you share if added any workarounds or modifications in your project to address the coverage problems?

Now that I think about it, @hansl fixed a problem with sourcemaps in https://github.com/angular/angular-cli/pull/8230. Maybe that was the root cause of this issue in the first place.
Can other people confirm if your codeverage is now correct?

@filipesilva - I can confirm it fixed the issue with constructors. I assume other similar issues were caused by the same thing.
I updated my test repo to Angular 5 and the coverage report is now correct:
https://github.com/rg1220/angular-cli-coverage-issue-5526/tree/feature/update-to-angular-5

@filipesilva I just made sure that all tsconfig files are identical to the auto-generated ones from a new project. No workarounds required.

I'm using 4.4.6 until a library i'm using fixes a deprecated API.  Just chiming in that CLI 1.5.0 and NG 4.4.6 does not correct it.  I think you may have to specifically be on NG5.0

I confirm that angular 5 solves the problem.
I move from:

angular 4.4.6 to 5.0.0
angular/cli 1.4.9 to 1.5.0
nguniversal 1.0.0-beta.3 to 5.0.0-beta.5
angular/flex-layout 2.0.0-beta.9 to 2.0.0-beta.10

and I can reach 100% code coverage on branches now.
Before:

After:

I just don't understand the line src/app, it dropped down to 0%.
Here's my project

I upgraded to Angular 5 in a big project.
Almost everything worked without workarounds, there is just one scenario where it didn't work:

One of the tests for it:
it('calls setLocale', () => {
  spyOn(MomentDateAdapter.prototype, 'setLocale').and.callThrough();

  const adapter = new MomentDateAdapter();

  expect(adapter).toBeDefined();
  expect(MomentDateAdapter.prototype.setLocale).toHaveBeenCalledWith('pt-BR');
});

That's the only thing that didn't work for me.
Great job, Angular 5 is awesome :)

I'm still experiencing the constructor issue when using Jest with Angular 5.0 and jest-angular-preset. Setting tsconfig.spec.json target to es6 does not seem to have any effect.

Also still experiencing this issue event after moving to angular 5. Its even highlighting comments as not being tests :(

@el-davo did you also upgrade to click 1.5.0?

Am completely wrong it seems I had -sm set to false which was completely throwing the coverage off. My bad, Angular 5 FTW!!

@kenisteward Yup, cli is 1.5.0 too.

@filipesilva I can confirm after upgrading to Angular 5 and CLI 1.5.0 I also got full coverage for the constructors when before i was getting issues.

@laxu did you find a solution for that issue with jest? I'm facing the same issue :(

@Brototype Unfortunately no. In the mean time you have to either use the /* istanbul ignore next */ workaround or lower branch coverage to account for the issue.

I'm closing as it seems this is fixed with 1.5.

I resolved it by running the unit test environment in full privileged mode

Hey guys !
So de we know how Angular 5 fixed this issue... ? :-P

Yeah has to do with the annotations now being parsed as typescript
transformations instead. I'll try to find the article but it now doesn't
put the same ternary operators which were found in the code coverage for
constructors and input/outputs
On Tue, Feb 20, 2018, 12:42 PM otroboe<EMAIL_ADDRESS>wrote:

Hey guys !
So de we know how Angular 5 fixed this issue... ? :-P
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/5526#issuecomment-367058155,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMPLtSEh5oxmc3taE5JVdrBecojU8jBsks5tWwQdgaJpZM4Mi9tY
.

@laxu have you fix this when using jest????

For me with Jest 22.3.0, I just added this property in my jest.json config file:
{
  ...
  "mapCoverage": true
}

@otroboe Angular 5 fixed the issue but only when testing with karma + jasmine, with Jest I also experience the same issue. @filipesilva can you tell us exactly what was the fix in Angular 5 ?

I don't believe that jest is covered by the cli. In which case this doesn't
belong here but on stack overflow.
On Sat, Mar 3, 2018, 8:33 PM Ahn<EMAIL_ADDRESS>wrote:

@otroboe https://github.com/otroboe Angular 5 fixed the issue but only
when testing with karma + jasmine, with Jest I also experience the same
issue. @filipesilva https://github.com/filipesilva can you tell us
exactly what was the fix in Angular 5 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/5526#issuecomment-370194403,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMPLtUKPtuq-KCUr64POpqXwqLIUEJjbks5ta0R1gaJpZM4Mi9tY
.

+1

It seems most of the issues are solved nevertheless we are still experiencing same issue like @brunolm mentioned

We are experiencing this in our project with constructors and decorators. Running angular 5.2.8, angular-cli 1.7.3, jasmine 3.1.0 running with karma.

I resolve the problem by targetting es6 in tsconfig.spec.json
{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/spec",
    "baseUrl": "./",
    "module": "commonjs",
    "target": "es6",
    "types": ["jasmine", "node"]
  },
  "files": ["test.ts"],
  "include": ["**/*.spec.ts", "**/*.d.ts"]
}

Just make sure that you have sourcemaps turned on for your tests and coverage will work fine.

@macbem Not the case for me, the experience this problem with and without sm flag.

Thanks for the suggestions @macbem and @rousseaufiliong. I previously tried those suggestions along with the other suggestions in this thread like adding /* istanbul ignore next */ and I tried again today for good measure but still find coverage is low for branches because of constructors and decorators. Hopeful an update solves this for our project

Is a fix on the way?

I experience this problem with having source maps turned off for testing.

@filipesilva with version 1.7.4 the problem continues :(

The problem persists and I can't seem to find a work-around
/* istanbul ignore next */
  /* istanbul ignore next */ constructor( /* istanbul ignore next */
    /* istanbul ignore next */ private /* istanbul ignore next */ appDataService: /* istanbul ignore next */ ApplicationDataService /* istanbul ignore next */, /* istanbul ignore next */
    /* istanbul ignore next */ private /* istanbul ignore next */ appWorkflowService: /* istanbul ignore next */ ApplicationWorkflowService /* istanbul ignore next */, /* istanbul ignore next */
  ) /* istanbul ignore next */ {/* istanbul ignore next */} /* istanbul ignore next */

We're also still seeing the same problem, Angular 5.2.6, Jest 22.4.3 and Jest Angular Preset 5.2.2. For whatever reason, it's not all the time, but there are issues where some of the params in a constructor will be uncovered. It doesn't seem to make a lot of sense, because it's not consistent.

Also seeing this behaviour as described by @mcblum

indeed, after adding  --sourcemaps=false coverage started giving wrong numbers (cli 1.7.4, target es5). When you remove it, coverage is ok.

Same issues with Angular 5.2.11, Jest 23.1.0 and jest-preset-angular 5.2.2.   All the istanbul packages pulled in (inspected via package-lock.json) also appear to be the latest.
        "istanbul-api": "^1.3.1",
        "istanbul-lib-coverage": "^1.2.0",
        "istanbul-lib-instrument": "^1.10.1",
        "istanbul-lib-source-maps": "^1.2.4",

Angular CLI team lies.  I'm running the latest angular/jest and still seeing this problem.  NONE of the above "solutions" work.  I've tried /* istanbul ignore next */, sourcemaps (both on and off) setting the target to es6, even adding the deprecated "mapcoverage" setting.  Nothing works.  Problem still exists without so much as a workaround.  This is not a "closed" bug.

Angular CLI team lies. I'm running the latest angular/jest and still seeing this problem. NONE of the above "solutions" work. I've tried /* istanbul ignore next */, sourcemaps (both on and off) setting the target to es6, even adding the deprecated "mapcoverage" setting. Nothing works. Problem still exists without so much as a workaround. This is not a "closed" bug.

Before calling a team as liars consider for a moment that you might be missing something or maybe you have encountered an edge case unknown to the community. If you provide a minimum reproducible example (created in stackblitz for instance) it would be more helpful to get your problem sorted out.

@Javin007 bro... come on. These are some of the most capable people working on software today, so the chances that they are lying to cover up a bug that, at its core, leads to an incorrect coverage report number are almost 0.
I'm using the latest CLI and Jest and ignore next works just fine. I would guess there is something else wrong with your setup.
Please consider the tone you take when commenting on projects which are free for you to use. No one owes you a fix, we're all in this together, and people are doing their best.

@mcblum @ruimarques
I'm sorry if I come off as a bit irritated, but this is a very easily duplicated bug:
1.) Create new "hello world" project.
2.) Install Jest.
3.) Inject HttpClient into the app.component.ts
4.) Run tests with code coverage.
I JUST did it again to verify.  It literally happens every time.  On multiple versions of angular, and on every environment.  And I've spent the last 48 hours searching for a solution, and have tried every single "fix" found on google to no avail.  And this has been a problem for quite some time.
I'm not even saying it's specifically the Angular team's fault.  It could very likely be a problem with Jest.  However, claiming that "it's fixed" when it's not, and it's so easily duplicated is not helpful.  Especially when I see numerous posts on numerous different sites (and even in this thread) claiming so without doing the very basic test outlined above.  This original post was from March of 2017.  It's now February of 2019, and this thread is a history of people continuing to have the exact same problem without a solution at any time.  So this isn't just some problem that "cropped up again."
And yes, I'm irritated at spending two days of seeing people saying "it's fixed" when it simply isn't, and none of the MANY, MANY proffered solutions (everything from creating an entirely new project, to reinstalling angular) are anything but a waste of time.  This kind of hand-waving away of the problem doesn't get it solved (obviously, since we're now on year two of the same issue).
If you actually have a solution that fixes the problem, then I and the many other people suffering from this problem would very much love to hear it.  If you're not having this issue, then what is it that you're doing differently from the above steps?  We would very much like to know.

@Javin007 since even the steps you list above could result in a different version being installed on my machine than yours, could you please put the exact configuration in a StackBlitz so one of us can grab the code and see what's up? When you say "install jest" there are 1,000 different options, stable vs. alpha version of jest-preset-angular and a bunch of other things that can change, so put your exact configuration in a SB and we can see how you're getting the issue you're getting.
Once again, I'm currently, as I type, working on a large project using Angular CLI + Jest + Istanbul and all of my ignore statements work correctly.

I will drop one cent here:

first of all, the issue with coverage constructor when using jest with Angular CLI isn't in Angular CLI fix because Angular CLI only fixed for karma + Jasmine.
jest-preset-angular 7.0.0-alpha.1 fixed the issue with coverage when using jest. However we are trying to make jest-preset-angular to be compatible with jest 24 at the same time. Being compatible with jest 24 + alpha version work are 2 big breaking changes and require some times to release an official version.

FWIW: Here's a project that has the problem: https://yqnigwvz.github.stackblitz.io

@Javin007 could you try with the following:
"jest": "^23.6.0",
"jest-preset-angular": "7.0.0-alpha.2",

You will need to change your jest config when you update to the alpha of jest-preset-angular. It looks something like this:
"jest": {
    "preset": "jest-preset-angular",
    "setupFiles": [
      "jest-canvas-mock"
    ],
    "setupTestFrameworkScriptFile": "<rootDir>/config/jest/config.ts",
    "transformIgnorePatterns": [
      "<rootDir>/node_modules/(?!@ngrx|@agm)"
    ],
    "transform": {
      "^.+\\.js": "<rootDir>/node_modules/babel-jest",
      "^.+\\.(ts|html)$": "ts-jest"
    },
    "globals": {
      "ts-jest": {
        "tsConfig": "<rootDir>/tsconfig.spec.json",
        "diagnostics": false,
        "stringifyContentPathRegex": "\\.html$",
        "astTransformers": [
          "jest-preset-angular/InlineHtmlStripStylesTransformer.js"
        ]
      },
      "window": true
    },
    "modulePathIgnorePatterns": [
      "<rootDir>/coverage/",
      "<rootDir>/.storybook/",
      "<rootDir>/config/",
      "<rootDir>/dist/",
      "<rootDir>/e2e/",
      "<rootDir>/node_modules/"
    ],
    "collectCoverageFrom": [
      "{apps|libs}/**/src/**/*.ts"
    ],
    "coverageThreshold": {
      "global": {
        "statements": 90,
        "branches": 90,
        "functions": 90,
        "lines": 90
      }
    },
    "testMatch": [
      "**/__tests__/**/*.ts?(x)",
      "**/?(*.)+(spec).ts?(x)"
    ],
    "snapshotSerializers": [
      "jest-preset-angular/AngularSnapshotSerializer.js",
      "jest-preset-angular/HTMLCommentSerializer.js"
    ]
  }

Obviously you'll need to change everything that's different, this is just from my project. Upgrading to the alpha version and sticking with Jest 23 for now should fix it.

Now the app builds fine, and even serves fine, but all tests fail with:
Failed: "Zone is needed for the async() test helper but could not be found. Please make sure that your environment includes zone.js/dist/zone.js"

NVM, got it working.  (Had a single bad configuration.)  It does indeed seem to be working now.  So it would seem it's the fix is indeed in the Jest alpha.  Thanks for your help!


Reasult is balck

Hello, first of all, thank you very much for your outstanding work! Currently, I am encountering an issue where, when I strictly follow the instructions in your README, the resulting video is completely black. Could you please let me know what might be causing this problem? I am looking forward to your reply!

Thank you for your interest in our work. We will test the code again on another Linux machine. Sorry for the inconvenience.

Can you specify which machine are you using in terms of GPU, CUDA version, and linux?


ERROR (Code 1) ! when sending tokens

Not possible to send tokens with the command 01_sendAssets.sh
Example command: sudo ./01_sendAssets.sh addr1 addr2 afc910d7a306d20c12903979d4935ae4307241d03245743548e76783.ASHIB ALL
I get as error message:
...
3 Asset-Type(s) / 3 different PolicyIDs found on the Address!
Assets to send (given input reference, * means selected via bulk sending):                Amount: Bech-Format:
(standard_in) 2: syntax error
(standard_in) 5: syntax error
./01_sendAssets.sh: line 511: [[: 1
-4999999999
1: syntax error in expression (error token is "1")
afc910d7a306d20c12903979d4935ae4307241d03245743548e76783.ASHIB<PHONE_NUMBER>
1
1
Assets remaining after transaction - PolicyID:          Asset-Name:                       Amount: Bech-Format:                                  Ticker:  Meta-Name:
afc910d7a306d20c12903979d4935ae4307241d03245743548e76783.ASHIB<PHONE_NUMBER>                                               ASHIB    ADA Shiba Inu
ba3afde69bb939ae4439c36d220e6b2686c6d3091bbc763ac0a1679c6269745f626f7420307830303035                1
f0ff48bbb7bbe9d59a40f1ce90e9e9d0ff5002ec48f232b49ca0fb9a.mini1pool                    -4999999999
option --tx-out:
unexpected "\n"
expecting hexadecimal digit
expecting a 56 hex-encoded policy ID, but found only 1 hex digits
Usage: cardano-cli transaction build-raw
[ --byron-era
| --shelley-era
| --allegra-era
| --mary-era
| --alonzo-era
]
[--script-valid | --script-invalid]
(--tx-in TX-IN
[--tx-in-script-file FILE
[
( --tx-in-datum-cbor-file CBOR FILE
| --tx-in-datum-file JSON FILE
| --tx-in-datum-value JSON VALUE
)
( --tx-in-redeemer-cbor-file CBOR FILE
| --tx-in-redeemer-file JSON FILE
| --tx-in-redeemer-value JSON VALUE
)
--tx-in-execution-units (INT, INT)]])
[--tx-in-collateral TX-IN]
[--required-signer FILE | --required-signer-hash HASH]
[--tx-out ADDRESS VALUE
[ --tx-out-datum-hash HASH
| --tx-out-datum-hash-cbor-file CBOR FILE
| --tx-out-datum-hash-file JSON FILE
| --tx-out-datum-hash-value JSON VALUE
| --tx-out-datum-embed-cbor-file CBOR FILE
| --tx-out-datum-embed-file JSON FILE
| --tx-out-datum-embed-value JSON VALUE
]]
[--mint VALUE
(--mint-script-file FILE
[
( --mint-redeemer-cbor-file CBOR FILE
| --mint-redeemer-file JSON FILE
| --mint-redeemer-value JSON VALUE
)
--mint-execution-units (INT, INT)])]
[--invalid-before SLOT]
[--invalid-hereafter SLOT]
[--fee LOVELACE]
[--certificate-file CERTIFICATEFILE
[--certificate-script-file FILE
[
( --certificate-redeemer-cbor-file CBOR FILE
| --certificate-redeemer-file JSON FILE
| --certificate-redeemer-value JSON VALUE
)
--certificate-execution-units (INT, INT)]]]
[--withdrawal WITHDRAWAL
[--withdrawal-script-file FILE
[
( --withdrawal-redeemer-cbor-file CBOR FILE
| --withdrawal-redeemer-file JSON FILE
| --withdrawal-redeemer-value JSON VALUE
)
--withdrawal-execution-units (INT, INT)]]]
[--json-metadata-no-schema | --json-metadata-detailed-schema]
[--auxiliary-script-file FILE]
[--metadata-json-file FILE | --metadata-cbor-file FILE]
[--genesis FILE | --protocol-params-file FILE]
[--update-proposal-file FILE]
[--cddl-format | --cli-format]
--out-file FILE
Build a transaction (low-level, inconvenient)
Please note the order of some cmd options is crucial. If used incorrectly may produce undesired tx body. See nested [] notation above for details.
ERROR (Code 1) !

hi, can you please provide more information about your system. what cardano-node/cli version are you using? are you using the latest version of the SPO scripts?

i think i found your address its the one with also the adahandle right? i tried it here and it is working fine, can build the transaction with your example above.

Hi, my OS is Ubuntu and I'm using cli version 1.34.1. How were you able to build the tx? Yes my address is the one with ADA Handle $mini1pool. I'm desperately trying to move my NFT's with no success unfortunatley. Could you please provide any guidance? Thanks

How important is bech32 for 01_sendAssets.sh? Because I receive another error at the beginning. Here the entire log:
sudo ./01_queryAddress.sh mini1_main.payment
Version-Info: cli 1.34.1 / node 1.34.1		Scripts-Mode: online
Checking UTXOs of Address-File mini1_main.payment.addr: addr1qxgthckcrnkg0edew4hpzlnat300pg8j829srj639z320u9k84eg5mq93xp9faer7xsnd3f5c94l3c9l7q6nr06rnjgquhz7jz
Address-Type / Era: payment / shelley
3 UTXOs found on the Address!
Hash#Index: 0abed530237ea5d5b794ca855e4e6e269e16a4843856b779861979aee83ff019#0	ADA: 1.344798 (1344798 lovelaces)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by ./bech32) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by ./bech32)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by ./bech32)                            Asset:   Amount:<PHONE_NUMBER> ASHIB Hash#Index: 29958bd6a3c01498d2d6e794a1d3ab92b1b8ef66c30efdf76f0d6eccb94b683e#1	ADA: 1.586172 (1586172 lovelaces) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by ./bech32)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by ./bech32) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by ./bech32)
Asset:   Amount: 1 {6269745f626f7420307830303035}
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by ./bech32) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by ./bech32)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./bech32)
Asset:   ADA Handle: $mini1pool mini1pool
Hash#Index: 5750e1aa0dd427131ad74d87b20abbaa19945fbd644897c4227b87e6237d0bef#0	ADA: 3.100000 (3100000 lovelaces)
Total ADA on the Address: 6.030970 ADA / 6030970 lovelaces
3 Asset-Type(s) / 3 different PolicyIDs found on the Address!
PolicyID:                                               Asset-Name:       Total-Amount: Bech-Format:                                  Ticker:  Meta-Name:
afc910d7a306d20c12903979d4935ae4307241d03245743548e76783.ASHIB<PHONE_NUMBER>                                               ASHIB    ADA Shiba Inu
ba3afde69bb939ae4439c36d220e6b2686c6d3091bbc763ac0a1679c6269745f626f7420307830303035                1
f0ff48bbb7bbe9d59a40f1ce90e9e9d0ff5002ec48f232b49ca0fb9a.mini1pool                    1
ubuntu@ubuntu:~/stakepoolscripts/bin$ sudo ./01_sendAssets.sh mini1_main.payment julien.nami ba3afde69bb939ae4439c36d220e6b2686c6d3091bbc763ac0a1679c6269745f626f7420307830303035 1
Version-Info: cli 1.34.1 / node 1.34.1		Scripts-Mode: online
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by ./bech32) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by ./bech32)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./bech32)
Sending assets from Address mini1_main.payment.addr to Address julien.nami.addr:
Current Slot-Height: 64572394 (setting TTL[invalid_hereafter] to 64672394)
Source Address mini1_main.payment.addr: addr1qxgthckcrnkg0edew4hpzlnat300pg8j829srj639z320u9k84eg5mq93xp9faer7xsnd3f5c94l3c9l7q6nr06rnjgquhz7jz
Destination Address julien.nami.addr: addr1qygv5fqsfjhfgkx7fhkkegxksx56dsu262vhaxr4mvuukt8uqh7nhjs3pcl98xr2zhmtqk6qkmr4gszxjrs3lnpedqdqyr3jzc
3 UTXOs found on the Source Address!
Hash#Index: 0abed530237ea5d5b794ca855e4e6e269e16a4843856b779861979aee83ff019#0	ADA: 1.344798 (1344798 lovelaces)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by ./bech32) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by ./bech32)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by ./bech32)                            Asset:   Amount:<PHONE_NUMBER> ASHIB Hash#Index: 29958bd6a3c01498d2d6e794a1d3ab92b1b8ef66c30efdf76f0d6eccb94b683e#1	ADA: 1.586172 (1586172 lovelaces) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by ./bech32)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by ./bech32) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by ./bech32)
Asset:   Amount: 1 {6269745f626f7420307830303035}
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by ./bech32) ./bech32: /lib/aarch64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by ./bech32)
./bech32: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./bech32)
Asset:   ADA Handle: $mini1pool mini1pool
Hash#Index: 5750e1aa0dd427131ad74d87b20abbaa19945fbd644897c4227b87e6237d0bef#0	ADA: 3.100000 (3100000 lovelaces)
Total ADA on the Address:  6.030970 ADA / 6030970 lovelaces
3 Asset-Type(s) / 3 different PolicyIDs found on the Address!
Assets to send (given input reference, * means selected via bulk sending):                Amount: Bech-Format:
(standard_in) 2: syntax error
(standard_in) 3: syntax error
ba3afde69bb939ae4439c36d220e6b2686c6d3091bbc763ac0a1679c6269745f626f742030783030                1
The assetAmount on this address or on the selected UTXOs is not enough. A maximum of<PHONE_NUMBER>
1
1 is available!

yes, looks like your bech32 binary is not working like it should. aarch64 architecture is a problem. the bech32 binary in the scripts is for amd64 x86 architecture. it will not work with aarch. but you can try to compile an aarch version yourself of the bech32 binary. https://github.com/input-output-hk/bech32

Problem solved! In fact I had to do the following steps:

Replace the bech32 binary with an arm64 build
Upgrade Ubuntu to version 22.04 (becuase bech32 needs GLIBC version > 2.32)

perfect! 😄


Xnero: Watch charbhujatiles.com

Xnero requests the watch of the watch_keyword charbhujatiles\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

charbhujatiles\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


session: add log configuration

Right now the driver logs important events to stderr, it should be off by default and configurable by the user through sessionConfig.
Maybe using an interface like gocql: https://github.com/gocql/gocql/blob/v1.2.0/logger.go#L9
or https://github.com/scylladb/go-log

I'd prefer some kind of interface where I can plug a custom implementation. We have an internal logging package (based on zap) that always adds some custom fields.
The driver should also log query warnings by default to the configured logger and allow users to explicitly turn the warnings off if needed. That would make warnings more useful. With gocql probably most people ignore them. (but maybe this is for a separate issue?)


OCPBUGS-32336: [IBU] Remove unused fields from CRD spec

/cc @browsell @donpenney @jc-rh

/lgtm

There are two other unused fields in status. We will probably add comprehensive history info in the future instead of simple timestamps, if it ever becomes a requirement.

/cc @rauhersu
Defining a list of reviewers in the initial PR description bypassed automatically adding Raul based on the CSV change

/lgtm

/approve


feat: Relative time format

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request
Having an additional tab where time is shown as relative format would be nice to have.

Describe the Use Case
This format will be more useful than having tabs for months and weeks with decimals in place.
Describe Preferred Solution
Something similar to the attached screenshot (moments pro)
Describe Alternatives

Related Code

Additional Information

Thanks for your proposal! ❤
Since calculating how many months and days between two dates need to know how many days in each month, so the calculate method now cannot do that. This feature will be added to the road map, and will be released when available.


Investigate the use of a JIT-enabled JDK7 for s390x JDK8 bootstrap

Most machines are currnetly using the Red hat supplied hotspot JDK7 as the boot JDK which impacts the build performance as it does not contain a JIT (it uses the zero VM)
We should look at whether we can use a J9 VM (Likely the IBM one) as a boot JDK in order to improve the performance of the Linux/s390x JDK8 builds (Current time: 39 minutes for HotSpot, 54 for OpenJ9)

IBM's JDK7 does not work well for this:
17:26:36  gmake[2]: *** No rule to make target '/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-s390x-hotspot/workspace/build/src/build/linux-s390x-normal-zero-release/corba/dist/lib/classes.jar', needed by '/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-s390x-hotspot/workspace/build/src/build/linux-s390x-normal-zero-release/jdk/classes/_the.CORBA.classes.imported'.  Stop.

I'm going to try with an adoptopenjdk/openj9 8u262 to compare

25 minutes to build OpenJ9/JDK8 with a 8u262/J9 boot JDK (vs 54m)
16 minutes to build HotSpot/JDK8 with an 8u262/J9 boot JDK (vs 39m)


Fix: Avoid Java bug caused by readString for readPreferencesFile

Related to https://github.com/FAForever/downlords-faf-client/issues/2905

Added catch-all-block just in case there are unforeseen issues.
Changed comment into log.error to clarify that is an IOException issue and not only a "probably malformed file"

It worked on all the tests files, which I got from the forum - I converted a random Game.prefs to several commonly used char sets (https://www.wikiwand.com/en/Character_encoding), and it worked for them as well - I think this alternate solution to avoid the read-decoder-Java-bug, is the next best one.
@Sheikah45 From my POV the solution is ready, I tested all successfully I could on my end. If I find some volunteer who have the current bug, I could test the new client with them first, if you think this is not wasted time.


Email messages in a thread has is_deleted=true even if they are not deleted

In a 4 mail thread when I opened the second mail its show me is_deleted=true. Even the mail was not deleted. Its start happening after 3 mail in a thread and after that the is_deleted=true number was increase.

I am able to account for deleted items in a thread with this code:
        const openItem = $(newElement)
          .closest('.h7[role="listitem"]')
        // siblings no height = deleted thread items (not present in total_threads)
        const siblings = openItem
          .parent()
          .children('[role="listitem"]')
          .filter((_, e) => $(e).height())
        let emailPosition = siblings.index(openItem) // search email container, get offset of message in un-deleted thread items
        // get thread item from (undeleted) thread list
        let email = this.openedEmailDetails.threads[this.openedEmailDetails.total_threads[emailPosition]]

It's pretty jankity. I would prefer a better solution that includes a list of messages in a thread that includes deleted messages instead of having to skip over messages with height=0

Old issue is old. Closing.


On case of duplication first image has to win during AddImages

Before this change imageMap[i.Name] was overwritten each time during the iteration, so not the first (as comment suggested) but the last element was selected.

Ok, this comment made me confused


Fix for bug #839

Issue: https://github.com/Microsoft/BotFramework-Emulator/issues/839
Fix: Undid the part of the change that introduced the faulty extra base64 encoding.

Pull Request Test Coverage Report for Build 300

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 49.569%

Totals

Change from base Build 289:
0.0%

Covered Lines:
3401

Relevant Lines:
5801

💛  - Coveralls


Difficulty setting a default value in the phone number input field. Example with a Cameroonian number.

 <PhoneInput                       customStyles={{                         container: { width: 220, height: 53 },                         flagContainer: { width: 80 }                       }}                       onPhoneNumberChange={(value) => handleValueChange(index, value)}                       // defaultValue={onEdit==true && EmergencyContactPhoneNumber[index]!==undefined ? EmergencyContactPhoneNumber[index]: ""}                       defaultValue="+237697645415"                     />
I'm trying to set +237 697645415 as the default phone number, but in the preview, I'm getting +237 69764541 instead. Do you see the difference in the image? Please let me know how to resolve

Hey @Chips-Analytics-Kevin I understood and sorry about this...
I fixed this issue on the next version...so, please, update your lib react-native-international-phone-number to v0.6.8 and enjoy...
🚀 AstrOOnauta 🚀

Great, it is amazing !!
"However, I believe that many features are missing, which you could add to this library to allow users to better customize the display according to their needs. For example, the ability to show a dropdown icon to the right of the country code, as commonly seen in most phone number libraries."

@Chips-Analytics-Kevin I released a new version with your insight about dropdown icon to the right of the country code...thanks!
So, please update your lib to latest v0.7.0
🚀 AstrOOnauta 🚀


Warning: Please update the following actions to use Node.js 16

This is the warning I see every time I my workflow:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: getsentry/paths-filter@v2

@iamtodor You are probably using an old version of this action. This issue was already addressed in the last two releases. Please verify if you are using either v2.11.1 or v2 version tags.

I can confirm that I'm using the v2 tag and I'm also seeing this deprecation notice.

@dorny @maverick1872
sorry for the late reply - I just got back from vacation. What is the proper way to verify the version?
Here is my configuration:
- name: Check for python file changes
  uses: getsentry/paths-filter@v2
  id: filter
  with:
    list-files: 'shell'
    filters: |
      py_scripts_filter:
        - added|modified: '**/*.py'

@iamtodor you are not using action from this repo. You are using a fork which lacks the latest changes fixing the issue.
So instead of this:
uses: getsentry/paths-filter@v2

Use this:
uses: dorny/paths-filter@v2

@dorny thank you for your attention!
omg 🤦

and same applies to https://github.com/dorny/paths-filter/issues/175


have maven build share artifact cache

The stage with the Maven build may be executed more than once so this avoids downloading all the JARs again.
PR Checklist
Please complete this checklist after opening your PR

[x] I have updated documentation as necessary
[x] I have updated helm chart(s) if needed
[x] I have added tests if needed
[x] All new and existing tests are passing
[x] Any breaking changes are clearly flagged and documented
[x] I’ve included a link to any relevant ticket(s)

@scealiontach: You may have opinions here on the cache setup.


What type of update are you requesting?
A new version of an existing package
Current Package Identifier
OliverBetz.ExifTool
Package Version
12.60
Please describe the changes you would like to see
Download Page URL:  https://oliverbetz.de/pages/Artikel/ExifTool-for-Windows

The pull request was started.

It is quite noisy when you comment on a pull request because the notification subscribed after you have been commented.

Close with reason: Resolved in #103345;


"Băbeni", "Ciocmani" , "Cliț" , "Piroșa" , "Poienița" are listed in the drop-down menu

Description:
When user writes "Băbeni", "Ciocmani" , "Cliț" , "Piroșa" , "Poienița" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Băbeni"

Expected results
The location appears in the drop-down menu as "Sat Băbeni, SĂLAJ (Băbeni)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Ciocmani"

Expected results
The location appears in the drop-down menu as "Sat Ciocmani, SĂLAJ (Băbeni)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Cliț"

Expected results
The location appears in the drop-down menu as "Sat Cliț, SĂLAJ (Băbeni)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 1
Write in the search bar "Piroșa"

Expected results
The location appears in the drop-down menu as "Sat Piroșa, SĂLAJ (Băbeni)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Poienița"

Expected results
The location appears in the drop-down menu as "Sat Poienița, SĂLAJ (Băbeni)".


Allow import of module without thermoengine, if MagmaSat methods are not being used.

I think an easy way of doing this is to have a bool statement before thermoengine is imported, which someone can configure in the python module file directly, if they are using it without thermoengine. I don't think this will cause any errors, unless thermoengine is specifically called.
However, I suspect there's a much more clever way of doing this.
The reason I think this is useful is for if people want to incorporate solubility code into other models (I've done this in the past, and is what my code was originally developed for...).
What are your thoughts? No urgency to doing this.

Question: what if we simply put the import in the init method of MagmaSat and ExcelFile?

Question: what if we simply put the import in the init method of MagmaSat and ExcelFile?

That sounds better! The only issue I see with that is in the default_models dictionary- instances of each model are initialised here when the module is imported. I've fixed this by removing magmasat from the default_models dictionary, and checking for the model='magmasat' before the "if type(model) == str:" in Calculate.init(). This will appear in my next push. I'll leave you to move the import thermoengine command as you're much more familiar with the MagmaSat and ExcelFile methods!

Implemented. Note that this implementation might make individual magmasat calculations slower. In future, should see if this can be more selectively imported or if there is a way to speed it up.


chore: fix error in readme for sending as cloudevent

Fix error in Readme for variables for sending cloudevent
Closes issue: https://github.com/cdevents/sdk-go/issues/32
Signed-off-by: Brad McCoy<EMAIL_ADDRESS>

@bradmccoydev I think this was already included in your other PR?

@afrittoli yes sorry was using it as an example for the students sorry closing now.


How to set advanced settings via array?

Hey there,
I'd like to not only initialize the toolkit with my $settingsInfo, but also with the $advancedSettings provided as an array (aka not loading it from a file).
Currently I only provide the normal settings:
require_once 'settings.php';
$auth = new Auth($settingsInfo);

Is there any way to do it?

I tried out
require_once 'settings.php';
require_once 'advanced_settings.php';
$auth = new Auth(array_merge($settingsInfo, $advancedSettings));

with the respective paths and it seems to work. Sorry for bothering :D


chore(datepicker): remove extra suppression service

Somehow we had it twice, wops.

Nevermind, somehow I am blind, yikes.


[BUG] can't install repository-s3 plugin in OpenSearch 1.2.3

I am having the issue to install repository-s3 plugin in OpenSearch 1.2.3 with the following error:
[opensearch@65554c8b2581 ~]$ bin/opensearch-plugin install repository-s3 --batch
-> Installing repository-s3
-> Downloading repository-s3 from opensearch
-> Failed installing repository-s3
-> Rolling back repository-s3
-> Rolled back repository-s3
ERROR: Invalid checksum file at https://artifacts.opensearch.org/releases/plugins/repository-s3/1.2.3/repository-s3-1.2.3.zip.sha512

It affects other plugins as well.


About the license for this model

Thank you for sharing your great code. :smiley_cat:
What is the license for this model? I'd like to cite it to the repository I'm working on if possible, but I want to post the license correctly.
https://github.com/PINTO0309/PINTO_model_zoo
Thank you.

Thank you for sharing your great code. smiley_cat
What is the license for this model? I'd like to cite it to the repository I'm working on if possible, but I want to post the license correctly. https://github.com/PINTO0309/PINTO_model_zoo
Thank you.

Hi, thank you for your interest in this repo. An MIT license is used for the code. The third-party dataset (KITTI) is subject to its own license and may not grant commercial use.

Thank you! :smile:


Remove .exr saver debug print

In a plugin that I'm working on (https://github.com/NeoSpark314/seurat-godot-plugin) I need to save a lot of .exr (cubemap) images. In this case the leftover debug output fills the console with a lot of unneeded information. This PR removes the debug print_line.

Thanks!


Keep GitHub Actions up to date with GitHub's Dependabot

This will automate the creation of pull requests like

pennersr/django-allauth#3615

And avoid the warnings like at the bottom of https://github.com/casey/just/actions/runs/7603050227
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem

Thanks for these PRs! They're awesome. I added a review with some very small nits.

Generated:

#1871


Digits works fine for all device except Samsung, i this error message

Hy orignMaster, I see a small airplane icon in the status bar. Is'nt the device in "airplane mode", preventing it from network access ?

i dont think its the airplane cos this is the third samsung device i tried on. as you can c the wireless is still on.

I don't think this issue is related to the model of the phone. I've encountered this problem across several phones with different numbers and carriers. The guys at Digits set up a support form for this kind of problems: https://docs.google.com/forms/d/1dDMpmgfOuCRvEHlXfnsylF4MIrDgIMm3dSrndGEhrFo/viewform
Hope this helps, If you come across a solution, i'd be interesting in knowing it, since it's causing a lot of problems for me too.

Hi,
Small comment. I realized that Digits start working(you may try with Cannonball app for android) for phone number after successful login with digits at http://cannonballapp.io/
I tried another phone number (without login at http://cannonballapp.io/) and I observe this error again.(but first phone number is working now)

Possibly related to #44.

Closing for now since there isn't much info on this thread. Likely related to #44.


Citation handling with config

The default behaviour where superscript_citations=False :-

When superscript_citations = True :-

Working on adding tests

Codecov Report

Merging #140 into master will decrease coverage by 0.83%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   91.48%   90.65%   -0.84%
==========================================
  Files           2        2
  Lines         235      246      +11
==========================================
+ Hits          215      223       +8
- Misses         20       23       +3

Flag
Coverage Δ

#pytests
90.65% <72.72%> (-0.84%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sphinx_book_theme/__init__.py
90.39% <72.72%> (-1.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3069cbd...d73cf5b. Read the comment docs.

@AakashGfude wanna switch this one up so that we:

don't use config for this
but make the default CSS "non-superscript"
add some docs in an "advanced" or in the "html" section about how to make the refs superscript

?

add some docs in an "advanced" or in the "html" section about how to make the refs superscript

Just wondering how to achieve this point. A normal user will only install everything though pip right, and won't really access the code base of the installed packages.
To me, it feels like the only place he will have access to the stylesheet will be in the html folder of the _build folder, which is temporary as he might have clean builds.

I was imagining we'd refer to https://jupyterbook.org/advanced/sphinx.html#custom-css-or-javascript and tell people what CSS rules they'd need to add...

aah. Thanks @choldgraf , did not know about this feature. Awesome. Still catching up on everything after this long break :sweat_smile:

@AakashGfude is this ready to go? I assume you wanna add the docs for this in jupyter-book

gonna merge this in so we can cut a release but feel free to open a new PR to clean stuff up 👍


bug(Excel) Operation cancelled when receiving all fields

It's not possible to load data into Excel table when all fields are selected. It works if one field us unselected.
To reproduce

open this stream https://speckle.xyz/streams/f2ffe143f3
hit Receive and filter button
try to download "Info"
select "all fields" and hit OK
"Operation cancelled" error notification pops up and receiving fails

unselect one field and try again
data is received successfully

@paloknapo fixed in https://github.com/specklesystems/speckle-excel/pull/51 :)


feat: enable cors, read ACCESS_CONTROL_ALLOW_ORIGIN from env

New env needed in Vercel:
ACCESS_CONTROL_ALLOW_ORIGIN set to https://giessdenkiez.de

Does this have to be a secret in the tests?


Revert "AMBARI-24566: Ambari-server cannot start"

What changes were proposed in this pull request?
Change is not required.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3815/
Test FAILed.
Test FAILured.


Transfer ownership to Blitz.js

@flybayer is interested in taking over this project for use in Blitz.js. He aims to maintain backwards compatibility with the existing API, but bring new features like Maps & Sets.
The thinking currently is to add the following API:
const [string, metadata] = superjson.stringifyWithMetadata({})

// optional 2nd argument for metadata
const data = superjson.parse(string, metadata)

@flybayer, do you mind sharing a bit more about how metadata is used? Currently with superjson all the metadata is encoded into the data itself. Have you run into a situation where that doesn't work?

Thanks @matthewmueller!
For context, here's the discussion in the Blitz repo: https://github.com/blitz-js/blitz/issues/700#issuecomment-646942375
The extra metadata is required to revive Map (serialized as object) and Set (serialized as array). Additionally it's needed for Dates and timestamps. When parsing, it's impossible to know if a timestamp should be converted to a Date or left as string without knowing how it started.
For example, in a Blitz app the types in the frontend are often derived from the types in the database. So if a timestamp is stored as string, the type must be a string when deserialized in the frontend. And likewise if the timestamp is stored as a date in the database.
With this new API, we will send both the serialized json and the metadata to the frontend where it can be correctly deserialized.
Regarding the API
I just realized there's a slight difference here between what superjson currently does and what we need. Currently superjson converts objects to a string and back. But we don't need that, what we need is serializing Javascript to a plain object and then converting plain objects back to Javascript.
So actually we need to add this:
// json, meta are plain objects without Date/Map/Set
const {json, meta} = superjson.serialize(input: any)

// output is Javascript with Date/Map/Set
const output = superjson.deserialize(json, meta)

Not knowing if the result of "2020-06-30T13:17:17.187Z" should be a string or a Date makes a lot of sense. Differentiating these data types wasn't a requirement for us at the time.
I think picking alternative methods is the right way forward. I like serialize/deserialize or encode/decode. The old methods can be de-emphasized and perhaps removed in a later major release.
I've added you to the NPM package and Github. If you'd like to transfer this repository to the blitz-js repo, let me know.

@matthewmueller awesome, thanks! And yes, it'd be great to transfer it to the blitz-js Github org.

Looks like you need to create a repository on blitjz-js first. I've given you admin rights so you can move it yourself.


Events Play and buffering are not reliable on  Firefox 44.0.2 windows7

Though its works on Linux firefox-v44.0.2, The bufferingStart, bufferEnd and playing event are not consistent on win7 Firefox44.0.2. although the minBufferTime is 10sec,  playing is resumes on every 2 secs of buffered data on a network throttled say 120kbps.  During buffering no pacman icon is displayed.
Steps to repoduce

Firefox v44.0.2 on Win7
Load custom manifest "https://a510avoddashs3us-a.akamaihd.net/d/1$AOAGZA014O5RE,D55F4215/videoquality$1080p/ondemand/175a/cda2/f539/45c6-b6e2-7c61ebb90c23/62bdd751-807d-4503-90af-f6a8514758eb_corrected.mpd
" in  http://shaka-player-demo.appspot.com/
Expected:
Wait to buffer data as specified in manifest file(minBufferTime).
Current results:
Player plays on every 2 sec of buffered data before entering into buffer state with no pacman icon..

Console logs :http://pastebin.com/raw/Pmiixrnv

Sounds like a difference in the media stacks on Firefox for Windows and Linux.  According to Mozilla's release calendar, Firefox 45 became the current stable release a few days ago.  Could you please try with Firefox 45?

Thanks for the Firefox 45 info. Events are firing as expected :)


eth_getCode to return the redirect bytecode for HTS tokens

Description:

Expand resolveEntityType function in mirror node to support token types
Change logic in eth_getCode - check for address type, if it's HTS token return redirect bytecode, rest is the same as before
address to tokenId converison by using parseInt(address, 16)
Added acceptance test to cover this use case

Related issue(s):
Fixes #
Notes for reviewer:
Little change in unit test, as we are making some addional requests and we need to mock them.
Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Base: 71.39% // Head: 70.60% // Decreases project coverage by -0.78% :warning:

Coverage data is based on head (13414c9) compared to base (54bb7d4).
Patch coverage: 36.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   71.39%   70.60%   -0.79%
==========================================
  Files          16       16
  Lines        1115     1133      +18
  Branches      192      194       +2
==========================================
+ Hits          796      800       +4
- Misses        267      280      +13
- Partials       52       53       +1

Impacted Files
Coverage Δ

packages/relay/src/lib/constants.ts
100.00% <ø> (ø)

packages/relay/src/lib/eth.ts
83.30% <16.66%> (-0.43%)
:arrow_down:

packages/relay/src/lib/clients/mirrorNodeClient.ts
90.84% <60.00%> (+1.66%)
:arrow_up:

packages/relay/src/lib/clients/sdkClient.ts
6.28% <0.00%> (-0.55%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


how to do out of the box zooming?

i am using a cardview in which there is a photoview like instagram post. i want to do out of the box zooming just like instagram. I know it can be done using PhotoViewAttacher but i am unable to implement it. Can you please provide me a sample code using PhotoViewAttacher.
Thanks in advance

👍 , I'd like to know as well


ARROW-17893: [Python] Test that reading of timedelta is stable (read_feather/to_pandas)

Can you move this test to test_pandas.py? Similarly as the other timestamp_as_object issue, I think the issue here is in the arrow->pandas conversion, and reading a feather file is only a way to get there. But so it should also be possible to test this with just creating a pyarrow.Table and converting to pandas.

There is also an issue when comparing timedelta in the old version of pandas I need to look into:
>       assert result["timedelta_2"].item() == timedelta_2
E       assert<PHONE_NUMBER>0000 == datetime.timedelta(seconds=13223)
E        +  where<PHONE_NUMBER>0000 = <bound method IndexOpsMixin.item of 0   03:40:23\nName: timedelta_2, dtype: timedelta64[ns]>()
E        +    where <bound method IndexOpsMixin.item of 0   03:40:23\nName: timedelta_2, dtype: timedelta64[ns]> = 0   03:40:23\nName: timedelta_2, dtype: timedelta64[ns].item


Empty recent mints

23 minted but even after refresh there are no cards with time
filter is set only to "newest"
they show on my profile normally

ahhh i know what is the issue
when this is not active

it should show non listed + listed
only after having it active it should show listed nfts only

i think filters got wrecked for some reason after massmint


Paste text content on flutter quill from a web page

Is there an existing issue for this?

[X] I have searched the existing issues

The question
Hello,
when i copy a paste and paste it in the quill editor it shows different fonts and images.
I want when i select and copy all content from a web page and paste it in the flutter quill to see only the plain text with the same font and no images. How can i achieve this ?
Thank you for your time!
Stanko

Hi! how are you pasting the content/text from a web page? Are you doing this using the button above the keyboard or by opening the context menu and press paste? because if you used the first way it will always paste as plain text for all apps no matter what you do and that limitation is by Android OS, I'm not sure which OS you are using though

I am having the same issue. Help needed :)


align namespaces with package and assembly names

Part 1: https://github.com/momentohq/client_protos/pull/74

Part 2: https://github.com/momentohq/client-sdk-csharp/pull/108

Part 3: https://github.com/momentohq/client-sdk-csharp/pull/109


Add basic rate limiting to backup

Introduces the --rate-limit flag for the backup subcommand. This sets a
package global indicating the KB/s rate for uploads.
Tested with iftop
References #1216

Codecov Report

Merging #1336 into master will decrease coverage by 5.63%.
The diff coverage is 3.12%.

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   51.98%   46.34%   -5.64%
==========================================
  Files         134      135       +1
  Lines       13116    13146      +30
==========================================
- Hits         6818     6093     -725
- Misses       5467     6276     +809
+ Partials      831      777      -54

Impacted Files
Coverage Δ

internal/backend/http_transport_ratelimit.go
0% <0%> (ø)

internal/backend/http_transport.go
0% <0%> (ø)
:arrow_up:

cmd/restic/cmd_backup.go
27.58% <25%> (-0.04%)
:arrow_down:

internal/backend/b2/b2.go
0% <0%> (-79.93%)
:arrow_down:

internal/backend/azure/azure.go
0% <0%> (-75.35%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-73.9%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-65.6%)
:arrow_down:

internal/backend/swift/config.go
34.37% <0%> (-56.25%)
:arrow_down:

internal/backend/s3/s3.go
58.59% <0%> (-1.28%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c003a...11249dd. Read the comment docs.

At the moment this PR conflicts with #1276, which also changes the way the http.Transport is passed to the backends, so we need to resolve that once #1276 (which is basically ready) is merged.
Then I'd like to talk about:

Integrating this with the sftp and local backends (yes, also for the local backend, in case people use that with other fuse-based file systems like sshfs or cifs)
Getting rid of the global variables in the backend package
I'd like to do the same for download
Finding a better name for the option, --upload-limit? And add a separate option for download

It feels to me that the HTTP Transport, while used for several backends, is the wrong place for the limiter. Maybe it should be a backend config thing, so that each backend takes care of it (and we can still provide a wrapper around http.Transport).
What do you think?

@fd0 - I agree with all of your points. I whipped this up quickly because my B2 backup was killing my internet speed, so it was mainly a proof of concept. I think Golang even explicity states that http.RoundTripper implementations should not mess with the request. :)
Without globals, I think the best way to approach this is to define something like
type Limiter interface {
   LimitReader(r io.Reader) io.Reader
   LimitWriter(r io.Writer) io.Writer
}

which would be initialized by the CLI and passed as parameters to all of the backends. The backend implementations would be responsible for wrapping the readers/writers when appropriate.
I have no strong opinions on the command flag, although I do prefer using "limit" as the prefix (e.g. --limit-upload and --limit-download) for easier copy-pasta. :)

Good idea with the interface, but I think defining that for an io.Reader is sufficient. We'll see that during the implementation. I'd rather like to differentiate between up and downstream, e.g. like this:
type Limiter interface {
    Upstream(io.Reader) io.Reader
    Downstream(io.Reader) io.Reader
}

@rmdashrf (Sorry for side-tracking this issue discussion) Out of curiosity, did you consider using golang.org/x/time/rate, too? If so, what are the drawbacks when compared to the juju package?

@fawick The juju implementation already implements a tested rate limited io.Reader. It seems like the golang.org/x/time/rate package would require more work and more testing.

I see, thank you!

Hm, I've had a look, and it works well for upstream but fails for downstream with the sftp backend. Any ideas?

Thanks!

This is really great work, @rmdashrf!
Even if I don't have immediate need for it, I know the time will come when it'll be indispensable, 'cause it already happened multiple times in the past with rsync, wget, and other apps... IMHO, it's a great feature for a backup program.
Thank you for your contribution!


Enhance the UI of the game.

Right now, the game looks simple enough, there is no indication of who has the current turn or who goes first, the overall look is very simple and the win dialogues are also very simple looking.

Try to make the game look more appealing by adding a coin toss kind of graphic before the first player gets chosen (which is random).
Try to enhance the win dialogue look wise.
Try to add options for different colour pallets for the game.
Try to add a label that shows who has the current turn.

Can I take this?

Can I take this?

Yeah sure. Please look into your previous PR though

Here are some updates on the UI and what I'm eperimenting with. After polishing this, I'll start working on end screens and coin toss.

Here are some updates on the UI and what I'm eperimenting with. After polishing this, I'll start working on end screens and coin toss.

This looks really cool. Keep up the good work man!

danke


WIP: update GdkPixbuf

Shows the generated files if https://github.com/gtk-rs/gir-files/pull/72
is merged

Looks good to me generally

Looks good to me generally

The CI failure looks relevant:
 diff --git b/glib/src/gobject/auto/binding.rs a/glib/src/gobject/auto/binding.rs
index 0236115..afcac6e 100644
--- b/glib/src/gobject/auto/binding.rs
+++ a/glib/src/gobject/auto/binding.rs
@@ -41,7 +41,7 @@ impl Binding {
     #[doc(alias = "g_binding_unbind")]
     pub fn unbind(&self) {
         unsafe {
-            gobject_ffi::g_binding_unbind(self.to_glib_none().0);
+            gobject_ffi::g_binding_unbind(self.to_glib_full());
         }
     }
 }

Looks like https://github.com/gtk-rs/gir-files/pull/66 somehow was reverted?

The CI failure looks relevant:
 diff --git b/glib/src/gobject/auto/binding.rs a/glib/src/gobject/auto/binding.rs
index 0236115..afcac6e 100644
--- b/glib/src/gobject/auto/binding.rs
+++ a/glib/src/gobject/auto/binding.rs
@@ -41,7 +41,7 @@ impl Binding {
     #[doc(alias = "g_binding_unbind")]
     pub fn unbind(&self) {
         unsafe {
-            gobject_ffi::g_binding_unbind(self.to_glib_none().0);
+            gobject_ffi::g_binding_unbind(self.to_glib_full());
         }
     }
 }

Looks like https://github.com/gtk-rs/gir-files/pull/66 somehow was reverted?

I have readded the gobject change in its own commit

I have readded the gobject change in its own commit

I have readded the gobject change in its own commit

How did it get lost though? :)

I have readded the gobject change in its own commit

How did it get lost though? :)

I have readded the gobject change in its own commit

How did it get lost though? :)

No idea... it was lost in a regen commit back in November that I linked in the commit message

I have readded the gobject change in its own commit

How did it get lost though? :)

No idea... it was lost in a regen commit back in November that I linked in the commit message

@GuillaumeGomez You broke it ;)

@GuillaumeGomez You broke it ;)

Someone summoned me?

Someone summoned me?


Update fs2-core to 3.2.11

Updates co.fs2:fs2-core from 3.2.10 to 3.2.11.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2", artifactId = "fs2-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "co.fs2", artifactId = "fs2-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #411.

Superseded by #415.


python310Packages.zconfig: 3.6.1 -> 4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.zconfig is: Structured Configuration Library
meta.homepage for python310Packages.zconfig is: https://pypi.python.org/pypi/ZConfig
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.0 with grep in /nix/store/cxaiflkk5fhvirgmawih2vskq4ciyddn-python3.10-ZConfig-4.0
found 4.0 in filename of file in /nix/store/cxaiflkk5fhvirgmawih2vskq4ciyddn-python3.10-ZConfig-4.0

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.zconfig
python310Packages.zdaemon
python310Packages.zodb
python311Packages.zconfig
python311Packages.zdaemon
python311Packages.zodb
vulnix

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cxaiflkk5fhvirgmawih2vskq4ciyddn-python3.10-ZConfig-4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.zconfig https://github.com/r-ryantm/nixpkgs/archive/a6fb345fbfbaffd34d9b3d2c5bd4ab5618f4705a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a6fb345fbfbaffd34d9b3d2c5bd4ab5618f4705a#python310Packages.zconfig

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cxaiflkk5fhvirgmawih2vskq4ciyddn-python3.10-ZConfig-4.0
ls -la /nix/store/cxaiflkk5fhvirgmawih2vskq4ciyddn-python3.10-ZConfig-4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

7 packages built:

python310Packages.zconfig
python310Packages.zdaemon
python310Packages.zodb
python311Packages.zconfig
python311Packages.zdaemon
python311Packages.zodb
vulnix

Maintainer pings
cc @cillianderoiste for testing.

Result of nixpkgs-review pr 280284 run on x86_64-linux 1

16 packages built:

python310Packages.zconfig
python310Packages.zconfig.dist
python310Packages.zdaemon
python310Packages.zdaemon.dist
python310Packages.zodb
python310Packages.zodb.dist
python311Packages.zconfig
python311Packages.zconfig.dist
python311Packages.zdaemon
python311Packages.zdaemon.dist
python311Packages.zodb
python311Packages.zodb.dist
vulnix
vulnix.dist
vulnix.doc
vulnix.man


Query Products within collectionByHandle

Hi Team
Is there a way to use query within the context of collections. for example: collectionByHandle.

It seems that this query is not yet available.

Have you found any solution ?
@cupelapps

Have you found any solution ?
@cupelapps


Implement new JSON Jinja filters

This PR implements several new Jinja filters:

from_json_str Parses a JSON string into a dict/list/string/int/bool, just does json.loads under the hood. This is useful, and really necessary, when storing complex data structures in the datastore. Since everything in the datastore is a string, in order to use the data it needs to be parsed out. Now we can have an expression like: {{ st2kv.system.my_complex_value | from_json_str }} and be able to use the result like a regular object.
from_yaml_str Parses a YAML string into a dict/list/string/int/bool, just does yaml.safe_load under the hood.
jsonpath_query Similar to Ansible's json_query filter, except this version uses JSONPath where ansible uses JMESPath. This allows complex data queries in a straight forward syntax that would otherwise require complex and hard to read chains of jinja filters.

TODO

[x] Port modifications to st2mistral - DONE https://github.com/StackStorm/st2mistral/pull/33
[x] Add documentation to st2docs - DONE https://github.com/StackStorm/st2docs/pull/617
[x] Migrate from JMESPath to JSONPath (thanks @Kami !)

Thanks.
I have one concern about additional dependency, but besides that I don't see any other blockers.
One thing I still don't like is just copy and pasting code over to Mistral. I know we did this in the past, but I already wasn't a big fan of it back then.
Imo, we should split those filters in a common package (e.g. st2_jinja_filters or similar) and then re-use that in both places.

@Kami I'm looking into JSONPath, honestly didn't see it when i was coding this. It might be a good alternative since it's already in the distribution. Keeping the dependencies low is always a good thing!
Also, i 100% agree that the right thing to do is have an external st2jinjafilters package (or similar). The only problem is that, currently, the filters in st2mistral have a different signature than the ones in st2. This is due to a bug/implementation-detail in Mistral upstream and closely relates to this bug https://github.com/StackStorm/st2mistral/issues/31 reported by @Mierdin .

@Kami i took your advice and ported the code to use JSONPath. Any other comments are appreciated!

Cool. At a glance, I wonder if this would make it so I don't need StackStorm-Exchange/stackstorm-ansible/pull/14 to get complex data passing working.

Awesome stuff here! 🥇
StackStorm is definitely missing more useful Jinja filters.

Thanks - looks good to me.
I'm still not fan of thise copy and paste between st2 and mistral repo so let's try to come up with a solution for that soon (would appreciate if you can open issue for that so we can track it).


Edit SDG14 (WoS)

Edit SDG14

Updated the status message, deleted the full search string URL - this should be replaced at the end

Marine terms

Added mariculture

Target 14.1

Phrase 3, Action approach only: Added Stockholm convention as a pollution agreement

Target 14.2

Phrase 1, Action approach only:  Combined the acronym MPA OR MPAs with marine protected area$ to avoid irrelevant works.
Phrase 1,Topic approach only: Removed MPA OR MPAs.
Phrase 1: Added marine sanctuar* and nature reserve$ as synonyms for protected areas.
Phrase 3: Added rehabilita* and resilien* as terms for management/protection. Changed communit* to ecological communit* in the marine ecosystem terms, as there were a lot of result about coastal human communities.

Target 14.3

Action approach only: Added monitor* as an action term

Target 14.4

Phrase 3: Added rehabilita* as a synonym for restoration

Target 14.5

Combined the acronym MPA OR MPAs with marine protected area$ to avoid irrelevant works.
Added marine sanctuar* and nature reserve$ as synonyms for protected areas

Target 14.6

Updated the interpretation
Phrase 1: Changed subsid* for ("subsidy" OR "subsidies" OR "subsidiz*" OR "subsidis*") to avoid subsided, subsidence etc.
Phrase 2: Updated ODA/mandate terms to include "development assistance" OR "development aid" OR "development intervention$" OR "foreign aid"

Target 14.7

Added "marine resources" OR "biological resources" OR "genetic resources" in the economic benefits terms
Changed marine conservation zone$ to marine conservation in the sustainable use terms

Target 14.a

Phrase 3: Added mariculture together with aquaculture etc.. Fixed a missing OR error which probably impacted results about "marine natural products" and "bioactives" in the previous versions. Simplified by removing a NEAR phrase (sustainable + use) so it became "utili$ation" OR "sustainab* use" OR "using sustainab*" OR "sustainab* usage"

Target 14.c

Phrase 1: Added high seas treaty as an relevant international agreement (adopted 2023); Added "Agreement on the Conservation of Polar Bears" OR "World Heritage Convention" OR "Bern convention" OR "Convention on the Conservation of European Wildlife and Natural Habitats" OR "Bonn convention" OR "Convention on the Conservation of Migratory Species of Wild Animals" OR "Convention for Protection of the Marine Environment of the North-East Atlantic" OR "stockholm convention"
Phrase 2: Added regions, UN and high seas terms as synonyms for "international" - (...OR "high seas" OR "ABNJ" OR "UN" OR "europe*" OR "pacific" OR "asia$" OR "africa$" OR "latin america$" OR "*arctic"). Added convention as a synonym in "agreements". Added "biodiversity" OR "biological diversity" and "nature reserve$" OR "marine sanctuar*" as conservation/sustainable use terms.

Addressed all issues