Migrate gogo -> golang protobuf

Fixes https://github.com/istio/istio/issues/26751
gogo/protobuf was originally introduced into Istio due to its performance benefits over the standard Go implementation. This was important for Mixer runtime performance. In the current state of Istio, Istio CR performance is negligible compared to XDS, which migrated to golang/protobuf a while back.
The gogo project is now unmaintained and no longer updated: https://github.com/gogo/protobuf/issues/691.
The plan is to get this approved, then merge istio/api, and unhold this. This ensures we do not have a delay where api repo merge is blocked.

API PR: TODO
client-go PR: https://github.com/istio/api/pull/2293

Changes required:

Many minor tweaks to change library imports from gogo/protobuf -> golang/protobuf.
Operator: we know longer have IstioOperator (the one defined in this repo that containers the top level K8s object, not the IstioOperatorSpec defined in istio/api as a protobuf, since there is no proto file. This means we replace some calls that expected UnmarshalWithJSONPB to just use plain YAML functions; these types have MarshalJSON functions defined so it behaves the same
Move some tests to compare use cmp or assert.Equal; reflect.DeepEqual cannot be used with golang protobuf types.
Make all references to types use pointers; golang protobuf types cannot be copied
Add nolint in some places where things are (properly) marked Deprecated now
Remove our custom fuzzing tests, used only for round trip testing; we have since replaced these with full OSS-fuzzer. This framework was effectively incompatible with the new protobuf types.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test integ-security_istio

release-notes_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test integ-security_istio

release-notes_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test release-notes_istio

lint_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test integ-security_istio

release-notes_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test release-notes_istio

lint_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test lint_istio

unit-tests_istio
50df28584406dc79af5316876f3f67bad1fd7c28
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

/test all

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

integ-pilot-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

integ-pilot-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-multicluster_istio

integ-security-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

integ-pilot-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-multicluster_istio

integ-security-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

integ-pilot-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-multicluster_istio

integ-security-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-istiodremote_istio

integ-helm_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-helm_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

integ-pilot-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-multicluster_istio

integ-security-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-istiodremote_istio

integ-helm_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-helm_istio

release-notes_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

integ-pilot-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-multicluster_istio

integ-security-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-istiodremote_istio

integ-helm_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-helm_istio

release-notes_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-notes_istio

gencheck_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test unit-tests_istio

release-test_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-test_istio

integ-telemetry_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry_istio

integ-cni_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-cni_istio

lint_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test lint_istio

integ-telemetry-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-mc_istio

integ-distroless_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-distroless_istio

integ-telemetry-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-telemetry-istiodremote_istio

integ-ipv6_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote-mc_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot_istio

integ-operator-controller_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-operator-controller_istio

integ-pilot-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-istiodremote_istio

integ-security_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security_istio

integ-pilot-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-pilot-multicluster_istio

integ-security-multicluster_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-security-istiodremote_istio

integ-helm_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test integ-helm_istio

release-notes_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test release-notes_istio

gencheck_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test gencheck_istio

analyze-tests_istio
b46fc15f5ddc23a9b221e3c8542b365759ae568d
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test lint_istio

gencheck_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test lint_istio

gencheck_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test gencheck_istio

unit-tests_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test lint_istio

unit-tests_istio
3cc7c12b52fe60865e57c6b48b92090f56eb9634
link
true
/test unit-tests_istio

gencheck_istio
bbfea5b759f9ec64ac04f627b4e5dfc6a0b3f088
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
bbfea5b759f9ec64ac04f627b4e5dfc6a0b3f088
link
true
/test gencheck_istio

release-test_istio
bbfea5b759f9ec64ac04f627b4e5dfc6a0b3f088
link
true
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
bbfea5b759f9ec64ac04f627b4e5dfc6a0b3f088
link
true
/test gencheck_istio

release-test_istio
bbfea5b759f9ec64ac04f627b4e5dfc6a0b3f088
link
true
/test release-test_istio

integ-telemetry-mc_istio
bbfea5b759f9ec64ac04f627b4e5dfc6a0b3f088
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

/test all
github outage

/test all

/test all


Allow VideoPost to return the actual video_url

The VideoPost class is missing the definition and return of the field video_url. This adds this field as a valid return for this class.

reverted Blog.java back to the original


Scroll to specific on PARENT page, when button is clicked within iframe?

This script works beautifully and is a huge life saver for our particular needs. We have a situation where the iframe content, which is a quiz, has a NEXT button. When this button is clicked, we'd like to scroll the parent page to the top of the quiz within the iframe. Does this script have anything that would help us get there?

https://github.com/davidjbradshaw/iframe-resizer/blob/master/docs/iframed_page/methods.md#scrolltoxy

Awesome! I was looking for this in the Parent Page API...I see why now that doesn't make sense. THANK YOU!

Last quick question...how does one go about animating this scroll? I saw this from some docs:
http://davidjbradshaw.github.io/iframe-resizer/
"If this callback function returns false, it will stop the library from repositioning the page, so that you can implement your own animated page scrolling instead."
But not entirely sure if these docs are still relevant, nor how I do what is being described here.

You can just call any scrolling library you like

Do you perchance happen to have an example? I'm just trying to animate it with jQuery and ScrollTop, but I am not understanding how you would use that in conjunction with this callback, when also happening onClick with the button within the iframe...


⚠ Fetchers has degraded performance

In 197a069, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 296 ms

Resolved: Fetchers performance has improved in 0eda431.


SuperCardToast with ViewPager

I've a Fragment that holds a ViewPager. This ViewPager has 2 fragments (let's call them, "FragmentA" and "FragmentB" as tabbed views.
Both FragmentA and FragmentB have:

As root on their XML layout.
When FragmentB is on the screen and the user presses something in there to fire a Toast the Toast is displayed, always, on FragmentA (which is not visible to the user) and not in the FragmentB (where the user is).
It should fire the Toasts in the "on screen" fragment.
Is this a bug? I can't find out a solution for this and I can't find anything on google regarding this issue.

dazito,
I'm making this easier in version 2.0 of the library. Thank you very much for the report and code!
John


[ConstraintSystem] NFC: Use stored result type while generating const…

…raints for closures
Instead of passing/storing result type to constraint generator,
let's retrieve it from the constraint system when needed.

/сс @hborla

@swift-ci please smoke test

@swift-ci smoke test

@swift-ci please smoke test Windows platform


Error message rewriting is lost for runtime errors.

We've lost error message rewriting in runtime errors, as part of migrating the rewriting code to the server.  For example, when I lose at https://code.world/#PWCzFEaAgOuBeBUKcEPiVzw, I get:
GAME OVER
CallStack (from HasCallStack):
  error, called at Line 34, Column 12 in main:Main

There used to be rules that would replace "main:Main" with "your program", and also "CallStack (from HasCallStack):".  Now that those are bundled into the compiler, they do not get applied to runtime errors. Oops!
The solution is going to be a little ugly.  Perhaps it's to move error sanitizing into a runtime library, which can be compiled by both GHCJS and GHC?

@pranjaltale16 @iteratee


Add Isaac build

Used when building client library inside Isaac SDK.

These changes should be added to the boost branch as well, do I open a new PR on the boost branch, or what is the correct workflow for adding the same changes to the boost branch?

These changes should be added to the boost branch as well, do I open a new PR on the boost branch, or what is the correct workflow for adding the same changes to the boost branch?

I would apply the same commit to the boost branch, as well. Please remind me, if I forget it.

In general, it feels wrong to include this here. The library part should not have to be aware of any application's environments.
Currently, however, I don't know a better solution for this.

I agree that we need to find a better solution in general for this.
Currently we are playing the the idea of making a simple public subscribe behavior, to move the definition of how to report a log message to the drivers side.

Closing this in favor of #40


Restore .concurrent for block-based enumerateObjects(…) methods in NSArray

These methods are implemented as (relevant NSIndexSet).enumerate(options: options…), so the fix goes in NSIndexSet.

Includes NSArray tests.

@swift-ci please test.


Adding guidelines for button states

Hey @esethna have a look.

Looks good, thanks Asaad. +1

+1


How to convert an array of of objects to a hash?

How would I use the proposed additions to achieve the following grouping?
 const objects = [{ identifier: 17, name: 'Karol' }, { identifier: 19, name: 'Henry' }];
 const objMap = objects.reduce((obj, c) => ({ ...obj, [c.identifier]: c }), {});
 console.log(objMap);

That's slightly different because the resulting object has an array for each identifier, rather than being last-wins.
There is not a straightforward way to use groupBy to do the thing the OP's snippet does. It's just a different operation. (That's OK - not every use case needs to be served by every utility.)

@bakkot thanks for point it out the difference.  I don't want the object values to be any array because the identifier is unique.
Why do you think your approach is better vs using reduce?

This is a bit off topic, but I basically never use reduce except when summing a list or doing something which is basically equivalent to that. reduce is a very general-purpose utility, which means that I find it's generally harder to tell what it's doing.

Oh yeah, that's definitely right; don't know why I put Object.values there.

Oh, sorry, I confused the [c.identifier]: c part of the snippet with being [c.identifier]: [c] thinking it was an array value.

It's better than a reduce because it more clearly conveys that it's a mapping, and a conversion to an object.

It also doesn't reallocate an object every time.

I don't think using reduce is bad in this situation. also, it creates object by 1 loop instead of 2 loops as Object.fromEntry requires 1 more loop

@wootra O(2n) and O(n) are the same complexity. The issue with reduce isn't about performance, it's about clarity of meaning/intent, which is usually the most important thing.

@ljharb I can't agree that this is about meaning/intent. This is about what is "proposed addition" which is usually the most performant and suggested including readability, manageability, and performance.
when we use .map function, objects.map(x => [x.identifier, x]) will create a lot of new objects, and it will be copied once more by Object.fromEntry.
Also, the reduce function is short enough. If I can improve more, I would use the same object like this:
 objects.reduce((obj, c) => (obj[c.identifier]=c, obj), {});


Some Klee spline shapes do not match C2C plotter.

I was making a new dataset using C2C format and noticed that for some contours that use sides made of RZ splines, the shapes output by Klee do not match the c2c_plotter program. The Klee version of the curved edge is very wavy compared to the C2C version. Here is such a shape:
Maybe it is a difference in how the splines are sampled parametrically?
black3.contour:
piece = line(start=(3cm,143cm), end=(4cm,149cm))
piece = rz(units=cm,
  rz=4 149
     17 151
     33 155
     43 155
     46 153
)

piece = line(end=(44cm,146cm))
piece = line(end=(38cm,147cm))
piece = rz(units=cm,
  rz=38 147
     33 147
     26 146
)

piece = line(end=(21cm,144cm))
piece = line(end=(3cm,143cm))

black3.yaml (needed for klee):
dimensions: 2

shapes:
- name: black3
  material: black
  geometry:
    format: c2c
    path: black3.contour

Plotting file using C2C:
/usr/gapps/c2c/latest/bin/c2c_plotter black3.contour

shaping in klee (with sampling):
data_collection_util --min 140 0 --max 170 50 --res 150 200 -p 1
../examples/quest_shaping_driver_ex --mesh-file box_2d.root --shape-file black3.yaml --method 0 -v -o 0 -p omp

Here are some examples of what I mean:

Thanks for reporting this @BradWhitlock -- Assuming the c2c plotter is correct, it looks like there might be a bug in how we're converting the input spline to NURBS or in how we're sampling the NURBS curve.

Fixed in new C2C. Wait for next C2C update, which is imminent.

I followed the above steps using<EMAIL_ADDRESS>and confirmed that the problem is resolved in #1092
Here's a screenshot of the heroic_roses/black3.contour using<EMAIL_ADDRESS>


PHP requirement update

Hi! I think there's a small inconsitency in the docs:
https://github.com/Cyber-Duck/laravel-test/blob/main/docs/01-local-development-setup.md
Mentions that PHP 8.1 is required however it looks like the update to Laravel 10 moved the requirement to 8.2 (despite 10 still supporting 8.1) and giving myriad composer errors. No big deal, i just updated local to 8.2 and contiuned but thought i should point it out. 🙂

Apologies if i've missed some good reason for this!

@broakenmedia Good observation.  We'll get that updated.


Error in Running Wrapper.py(data.npz is missing)

Hi I am interested in your work in opf but when I tried to run the wrapper.py I encountered the following error.

Then I tried to directly run data.py to generate data but it also ended up in an error. Could you please help me to run the code.

Sorry this might be a bit late. Are you still working on this?

I will add instructions on how to run code.

Thank You! that will be helpful :-)

I am closing this since instructions were added 2y ago.


[DS-6323][fix] EventExecuteService run loop without sleep which make cpu high

#6323

add sleep 1000ms

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #6324 (d9a334d) into dev (4625783) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

:exclamation: Current head d9a334d differs from pull request most recent head 630259b. Consider uploading reports for the commit 630259b to get more accurate results

@@             Coverage Diff              @@
##                dev    #6324      +/-   ##
============================================
- Coverage     39.03%   38.98%   -0.05%
+ Complexity     3230     3224       -6
============================================
  Files           637      637
  Lines         25426    25427       +1
  Branches       2767     2767
============================================
- Hits           9924     9913      -11
- Misses        14595    14606      +11
- Partials        907      908       +1

Impacted Files
Coverage Δ

...uler/server/master/runner/EventExecuteService.java
0.00% <0.00%> (ø)

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
39.00% <0.00%> (-5.68%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...inscheduler/common/thread/ThreadPoolExecutors.java
19.23% <0.00%> (-1.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4625783...630259b. Read the comment docs.

good job


Enable MCP by default in helm values and e2e tests (#10222)

(cherry picked from commit 970e0797c24d8995d7b6b0eba12d46c777dbb671)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c56cd02ee11ccf4249119fab09657d81a4751a2d
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Also if I remember correctly - new targets need some magic setup to get the
grid working again.
Better to keep the names - history and less headaches.
On Mon, Dec 3, 2018 at 3:28 PM Jason Young<EMAIL_ADDRESS>wrote:

/test e2e-dashboard
/test istio-unit-tests
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/10256#issuecomment-443910487, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6qZhSPhAXq9PD6Q7SiTwB9za2DOUks5u1bO5gaJpZM4Y_lzm
.

Agreed that we'll need to update testgrid. We already did that in the past when we added MCP test variants. We'll need to do the same for this PR.
@costinm, long term how would you suggest we make this change to avoid renames?
We've changed default behavior in the past. How is this change any different? We'll know the cut-over date for comparison purposes.

As long as you don't forget to update the testgrid - it's probably ok.
Since we had both tests on testgrid - keeping them with the original names
and grids
seemed cleaner, not sure why the renames were needed. We just need to make
the non-mcp not required.
On Mon, Dec 3, 2018 at 3:40 PM Jason Young<EMAIL_ADDRESS>wrote:

Agreed that we'll need to update testgrid. We already did that in the past
when we added MCP test variants. We'll need to do the same for this PR.
@costinm https://github.com/costinm, long term how would you suggest we
make this change to avoid renames?
We've changed default behavior in the past. How is this change any
different? We'll know the cut-over date for comparison purposes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/10256#issuecomment-443913140, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6iL2UtKtzBZq-ALEeNl6xGvjZlaMks5u1baIgaJpZM4Y_lzm
.

Corresponding testgrid update is ready to be merged after this PR (see https://github.com/kubernetes/test-infra/pull/10334)

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj, ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


characterLimiter() is not functional

wordLimiter() from api/helpers/string.php#L122-L142 is not passing the functional test.
Following is the test code to test the function.
public function test_characterLimiter() {
	$str = "This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test";
	$result = characterLimiter($str);
	$expected = 'This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This is a test This…';
	$this->assertEquals($expected,$result);
}

Working, no error found. Problem with the limit while testing.


fix(es/transforms): Fix this in async arrow class properties

swc_ecma_transforms_compat:

async_to_generator: Fix this in async class properties. (https://github.com/vercel/next.js/issues/33283)
Add a test for #3228 (Closes #3228).

I created a new PR because I thought I messed up something, but found that it's correct change for many cases.

Hi @kdy1 ,
It seems that #3228 is not related to async, but to class static, which is not fixed.

@magic-akari Actually it's already fixed so I just added a test to ensure that it's fixed.
The title of PR is a bit misleading...

You can copy-paste the output from https://play.swc.rs/?version=1.2.129&code=H4sIAAAAAAAAA0vOSSwuVgguSSzJTA5JLS5xBvOrebkUgKAYLKxQAhQPKMovULBVUPdIzcnJVyjPL8pJUVS35uXCUOibWpKRnwJUqqGpYGsHMwkEkvPzivNzUvVy8tM1SjIyi%2FVg5mpaQxTV8nLVgkxEc40ewlgNTQDmPQglsAAAAA%3D%3D&config=H4sIAAAAAAAAA0WOSwrDMAxE7zJrb9uF79BDCFcJLv4hOVBjfPfaISU7MfPmoY6POtiOQqIs69KWKn1hwS6SOvGlwkxsRlUOHgaVZOe6CH3MKuSsDLtRUDaIPvmtLZHLsQir3hWlPfzJMUUxv48VdNRW%2BBQ%2BMW7HtfP6usDzgR%2Fs3ILttAAAAA%3D%3D and run it using chrome

@kdy1 I think @magic-akari is right, the static method does not seem to be fixed when using typescript in combination with commonjs.
https://play.swc.rs/?version=1.2.129&code=H4sIAAAAAAAAA0vOSSwuVgguSSzJTA5JLS5xBvOrebkUgKAYLKxQAhQPKMovULBVUPdIzcnJVyjPL8pJUVS35uXCUOibWpKRnwJUqqGpYGsHMwkEkvPzivNzUvVy8tM1SjIyi%2FVg5mpaQxTV8nLVgkxEc40ewlgNTQDmPQglsAAAAA%3D%3D&config=H4sIAAAAAAAAA0WOSwrDMAxE76J1tt3kDj2EcZXg4B8aBWqM7145pGQ3zOdJnQ54WjtVJ2CZCi2r%2B9JK2irDS6hKCynMUjl5mHays1qD8bIolgKmdXMRvFAKOWxtgnxJVRh4Ipf3%2BG8OA6XyOafRr1sGtEkq%2BQCNB3SPA953%2B%2FriB8tcjwO5AAAA

I found that I added a test to the wrong directory. (I made a mistake because I reverted some pass changes.)
Reopening


Fix for Angular 1.4.x

In angular 1.4.x false appears as every other line in the dropdown because of the call to anguar.noop() in the template. Switching to an empty string seems to fix this.
I have also added a click handler to the time input that allows you to click on it again AFTER selecting and option while it is still focused and have the dropdown reappear. Previously it would not and you would either need to click the button or change focus and click back.

Awesome! I will have a look at this in the morning. Thanks for the PR!

We're not using 1.4 yet, but this looks good to me. Thanks for contributing!


Fix error in json parsing

Fix for "uninitialized constant TelegramBot::ApiResponse::ResponseError" + add spec for tests

@eljojo got it. I will remove rspec and investigate more about core issue, but this issue (uninitialized constant ) introduced only with rails as I see (for Schwad this issue not exists). I guess some intersection in naming or how require chain is build

Sure, take it easy.
I've been busy travelling these days, but I'll try to take a look over the weekend.
I don't think rails has something to do with it. My hunch is that ruby 2.5 is messing with things, but @schwad not being able to reproduce is baffling.
It's also fine if we don't fix this unless @vpereira provides a more straightforward way for us to reproduce this error.

@eljojo basically I experienced this error on ruby 2.4 and rails 5.2. This is fix for me as well

@ZhKostev aha thanks for this info! I will run same test but within rails c in a Rails 5.2 app


Update rxdart dep to 0.27.3

Update the rxdart dependency to version 0.27.3 to resolve conflicts with other packages. The ValueStream.valueWrapper was removed in rxdart version 0.27.0 and replaced with valueOrNull (see here).

I removed rxdart to last version camera_camera. Thank you your pr.


velocity-animate not available as documented

if I put the following code from the docs into my app:
require('velocity-animate');
require('velocity-animate/velocity.ui');

I run into errors. I think this is because velocity-animate is installed in the node_models for velocity-react, but isn't available to my main app. I can fix it with the following code, but this seems like a hack:
require('velocity-react/node_modules/velocity-animate');
require('velocity-react/node_modules/velocity-animate/velocity.ui');

actually the code I pasted below is causing issues with react, so I don't currently have a solution :)

Are you using Webpack or some other packager that is aware of npm modules?
You'll need that for this library.
On Wednesday, November 4, 2015, Chris Drackett<EMAIL_ADDRESS>wrote:

actually the code I pasted below is causing issues with react, so I don't
currently have a solution :)
—
Reply to this email directly or view it on GitHub
https://github.com/twitter-fabric/velocity-react/issues/47#issuecomment-153913032
.

yeah, using web pack. I eventually got it to work, but only after removing node_modules and reinstalling. Everyone on my team had to do the same thing. Not sure what was going on, but its fixed now with a fresh install.

Glad to hear it's working. This may have been an issue that could have been solved with npm dedupe as well.


Update Gradle wrapper to 6.2

This is needed to fix some SSL errors which have been observed on
some machines.
The gradlew and gradlew.bat scripts are autogenerated by the gradle tool.

@dgl-ableton Sorry, I should have mentioned that the wrapper scripts are autogenerated by the gradle tool and don't need to be reviewed. I've updated the PR description with this information!

@dgl-ableton The other team members have all reviewed and approved similar PRs (this was part of a flood 🌊).


test: url for invoke test

Changes

:broom: Update logic on invoke e2e test, in order to resolve the service url from the running

These changes allow to run Invoke e2e test against any cluster

/assign @lkingland


add wiw badges to sismo playground

Add two badges to playground:

wiw-crypto-memento
wiw-nft-degen-traders

Use snapshotted address list as group for now, will switch to use WIW data provider after it is ready!

Hey @KevinYum! Awesome PR 😁 I left some minor commentaries (useless comments from tuto and a strange .idea in the .gitignore. Feel free to ping when it is resolved.

Thanks for the comment :)
All fixed.

Per discussion in telegram, we will deprecate this PR and create a smaller group

Hey! Thanks for the changes. You can totally keep this PR and add your new groups to it, no need to deprecate I think :)

Hey! Thanks for the changes. You can totally keep this PR and add your new groups to it, no need to deprecate I think :)

Haha what a coincidence. I've just updated this PR and found your comment here :)
Could you help check it again @yum0e


List of preferred devices

Guessing the correct serial port from the list returned by the OS is not always exact.
A way to improve could be to have a configurable parameter to specify a list of preferred names or partial strings to be found in names.

This is has been improved in v0.4.0.
By default, the Serial script will try to open the old default ports to maximize compatibility with previous versions. Additionally it will try to open the last port listed which is often the one we want to use. And finally, you can a SerialConfig component on an empty GameObject so specify a list of preferred ports.


a change on the BaseTester

https://github.com/fastnlp/fastNLP/blob/63c687d9065783416e82998a908ed4dc243dbb48/fastNLP/core/tester.py#L102
I want print the eval_result on the whole dev_dataset, maybe I need to change this

change it


Translations that start with an _ or - generate a file named <translation>..translation

Godot version
4.1.1 stable
System information
Linux Pop!_OS 22.04 LTS
Issue description
When you create a CSV file to import for translation, if you have a locale that begins with an underscore or a hyphen, it will be semi-ignored, with all columns that have a hyphen or underscore being shoved into one translation file with the name ..translation.
Ideally this would be imported properly, or better yet work like godotengine/godot-proposals#8183.
Steps to reproduce
Create a translation CSV and add a locale column that starts with an _ or a -. Import it, and a translation file with no locale will be imported.
Minimal reproduction project
trtest.zip

Confirmed. I think for this bug fix we can just ignore the empty "lang" tags. As for that proposal, it may still need more discussion before implentation.

Locale code should have specific format, see - https://docs.godotengine.org/en/stable/classes/class_os.html#class-os-method-get-locale


minor: cleanup unused SessionVariable.

Proposed changes
Issue Number: close #xxx
Problem summary
cleanup unused SessionVariable.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Capture image from local camera

How to capture an image from the local camera while streaming.

Try this one https://github.com/gre/react-native-view-shot.
I'm using it to make image from Views and it works perfectly

The component https://github.com/gre/react-native-view-shot. captures the image of the view, therefore using the current dimensions of the view. I need to capture the image of the local camera, with the dimensions I am transmitting

This isn't possible, due to the limitations with the react-native-webrtc library. You might want to file an issue there.


FileDialog filters "*" can't be parsed properly by tscn

Operating system or device - Godot version:
Win7 x64, Godot v2.1rc1
Issue description (what happened, and what was expected):
App crashes if there's FileDialog in the scene. It works/looks more like a stopping scene right after running it.
Steps to reproduce:
Just add FileDialog anywhere to the scene.
Link to minimal example project (optional but very welcome):
^ Up ^

I noticed this as well. Seems to be because in tscn format there's no filter defined. I solved it by adding something like "filters = StringArray( "*" )" to the tscn file.

Indeed, it chokes with when running on:
ERROR: poll: res://Control.tscn:30 - Parse Error: Expected string
   At: scene/resources/scene_format_text.cpp:473.
ERROR: load: Condition ' err!=OK ' is true. returned: RES()
   At: core/io/resource_loader.cpp:142.

It doesn't crash though, it just fails loading the scene.
As mentioned by @hetdegon, the line 30 mentioned in my error message is:
filters = StringArray(  )

Also changing amount of filters in the Inspector allows the scene to be loaded. (You can use clear_filters() after it's loaded)

Can confirm...


Unify and improve RR-Device interface for MS-Band, Ant+ and BT

Overview about all possible error / failure / success messages
Overview of connection process
Overview of release process

Startingpoint Ant+: https://github.com/ant-wireless/ANT-Android-SDKs/blob/master/ANT%2B_Android_SDK/Sample/ANT%2B Plugin Sampler/source/src/com/dsi/ant/antplus/pluginsampler/heartrate/Activity_HeartRateDisplayBase.java


Tooltip views

Add support for new cumulative views that are being rolled out on some videos.

Coverage remained the same at 100.0% when pulling 6a99b5e68841f477aa843b074d00072bc44219d2 on tooltip-views into<PHONE_NUMBER>4c3feb6f3217781e09b5c7f6fddb99 on master.


Test/fix playwright reports GitHub/1076

Description

Test report published from Github and then published to new blob storage in Azure: https://playwrightreporting.z1.web.core.windows.net/run-168-1/index.html (reports incremented by build number and build run number)
Retrying flaky tests on CI at least once when failing
Blog storage used for context<EMAIL_ADDRESS>Secrets added by Jon Kjetil and must be evaluated when migrating to monorepo

Related Issue(s)

#1076

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Godt jobb! :)


Persist parameter sorting as part of AppSettings

yeah makes sense as the ids need to be recalculated. Just pushed a fix for this


Allow to easily customise the example used for benchmarks

Cabal file needs to be updated.

It would be nice if we could configure the Positions (hygienicP, identifierP) too.

It would be nice if we could configure the Positions (hygienicP, identifierP) too.

Good point, will do. Ideally those positions would be automatically created by the benchmark suite

/azp run

/azp run


frontend: Validate amount when token not selected

Fixes #970

Thanks for the suggestion @compojoom.
I had that idea in mind as well while implementing the input validation. Even started implementing it that way, but halway there i figured there is no standard implementation cross browser/device and its really hard to make 100% coverage with it.
If you are interested you can read my comments on PR #918 where i explain why i chose to back off from implementing it and switch to aggressively validating only.
Thanks for the review!


duplicate bookmark will break include

When using copy&paste for texts and lists, it might happens that there are duplicate bookmarks on one page. When including anything from that page, this will produce a fatal error on the page with include template:
production.ERROR: DOMDocument::loadHTML(): ID bkmrk-xxx-%28 already defined in Entity, line: 45 {"userId":x,"email":"xx@xx","exception":"[object] (ErrorException(code: 0): DOMDocument::loadHTML(): ID bkmrk-xxx-%28 already defined in Entity, line: 45 at /var/www/xx/bookstack/app/Entities/Repos/EntityRepo.php:664)
Reproduce
Create a page A with duplicate bookmarks, like

. This page will still work. But if you include something from that page within page B, B will return an error.

Thanks for reporting @ezzra, Can confirm the issue.
I have made an update in c380c10d54b96ae3f2f4c1c4ba7fbf1822f3b945, along with a test to cover, to prevent the page hard-failing and instead still render but without the included content.
I'll keep this open as it'll be good to update the logic on save to de-dupe any ids.

Hi @ezzra,
Can you confirm the editor and/or process you're following to save the content with duplicate ID's?
Just been digging into the content saving logic and found there's already code in place to de-dupe bkmrk ids. Having exact steps/content for replicating this would really help.

It looks like it can happen with nested lists:

eins

zwei

drei

eins

zwei

drei

Thanks for confirming, Could now replicate. I've added logic to de-dupe ID's on all child elements to prevent such occurrences persisting after saving.


Get wider, detail information

Initial improvement proposal.

Get more data
Better tmp dir handling
Removed output flag for now as I'm not sure if having both json and yaml formats is good for troubleshooting

Example output:
$ oc plugin sos -n logging
Data capture complete and archived in /tmp/oc-sos-logging-20180206-210447.tar.xz
$ tar tf /tmp/oc-sos-logging-20180206-210447.tar.xz
logging/
logging/pods-logging-kibana-3-bwlw2_kibana-proxy.previous.log
logging/pods-logging-kibana-3-bwlw2_kibana-proxy.log
logging/pods-logging-kibana-3-bwlw2_kibana.previous.log
logging/pods-logging-kibana-3-bwlw2_kibana.log
logging/pods-logging-fluentd-rwgjv_fluentd-elasticsearch.previous.log
logging/pods-logging-fluentd-rwgjv_fluentd-elasticsearch.log
logging/pods-logging-fluentd-6fbm9_fluentd-elasticsearch.previous.log
logging/pods-logging-fluentd-6fbm9_fluentd-elasticsearch.log
logging/pods-logging-fluentd-4b5n5_fluentd-elasticsearch.previous.log
logging/pods-logging-fluentd-4b5n5_fluentd-elasticsearch.log
logging/pods-logging-fluentd-2fxhc_fluentd-elasticsearch.previous.log
logging/pods-logging-fluentd-2fxhc_fluentd-elasticsearch.log
logging/pods-logging-es-data-master-ye3u4nvd-3-q6md6_elasticsearch.previous.log
logging/pods-logging-es-data-master-ye3u4nvd-3-q6md6_elasticsearch.log
logging/pods-logging-es-data-master-ye3u4nvd-3-q6md6_proxy.previous.log
logging/pods-logging-es-data-master-ye3u4nvd-3-q6md6_proxy.log
logging/oc-get-all.txt
logging/oc-get-all.yaml
logging/oc-get-project.yaml
logging/oc-get-event.txt
logging/oc-status.txt
logging/oc-version.txt

Removed output flag for now as I'm not sure if having both json and yaml formats is good for troubleshooting

There are some stakeholders in this project that would like to see the JSON output. It would helpful for their parsing engine that may be feeding off of the data captured by this script.
Would you mind adding that back in? Submitting a follow-up commit in the same branch/PR would be fine.

Ok adding it back. I prefer yaml for the default output because yaml is more readable format to me. What do you think?

If the parsing tool doesn't understand the yaml format, what is the point we support the output flag with yaml?

I prefer yaml for the default output because yaml is more readable format to me. What do you think?

Yes, I do typically prefer yaml when browsing configuration so would like to keep yaml support.

If the parsing tool doesn't understand the yaml format, what is the point we support the output flag with yaml?

I think the flag should remain for user preference. The other stakeholders in this project will require the json output and others (like you and I) prefer the yaml output.

Thanks, I wish that kind of tools support yaml formats.
I'm adding secret/cm flags. Are you going to merge this one or can I add some more commits for the review at the same time?

I'm adding secret/cm flags. Are you going to merge this one or can I add some more commits for the review at the same time?

You can go ahead and keep committing to this PR. I'll review any new additions in the morning (EST).


Fix Scala warnings in Spark support

@takezoe thanks for the PR. Do note that some of the warnings are deliberate (Spark 1.0 vs 1.4, Scala 2.10 vs 2.11).
Nevertheless I'll try to merge this in and reduce the volume.
P.S. Thanks for signing the CLA.

@costin Fixes in this pull request except for EsRDDWriter don't depend on Scala or Spark version. May I remove fix for EsRDDWriter from this pull request?

Thanks. Merged in master.


Missing error event

Window's error event should come from https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/browser.webidl.xml#L12798, but it is missing with the generated .d.ts file.
https://github.com/Microsoft/TSJS-lib-generator/blob/master/baselines/dom.generated.d.ts#L13045
@zhengbli Can you take a look?
cc @SaschaNaz for your pr.

Ah, now TS.fsx is maintained by @mhegazy as the only committer? Can you take a look instead of him?

This is because the onerror event property has a special handler named ErrorEventHandler instead of normal EventHandler. TS.fsx (incorrectly) checks for EventHandler thus the error event is omitted.

Thanks for letting me know!

It seems touch* events on Window interface are also affected.

Is there a reason why the generated GlobalEventHandlers entries all look like
    ondurationchange: ((this: GlobalEventHandlers, ev: Event) => any) | null;

except for onerror, which is just ErrorEventHandler, without allowing for null?  Is it actually not legal to un-register the error handler by setting window.onerror = null?
If this is incorrect, should I open a separate issue to fix it?

should I open a separate issue to fix it?

@thw0rted Yes, please do.


NSURLSession redirect 301 Location not work

I have a request that returns 301 with header "Location": "another_url_link" but my response block get called without redirection :cry:
request
        .validate()
        .response { request, response, data, error in
   // response contains status code 301 with header containing "Location"
}

I configure @cnoon  https://github.com/Alamofire/Alamofire/pull/317 taskWillPerformHTTPRedirectionWithCompletion but it does not get called.

There was a bug that was fixed in the 3.3.1 that was causing the taskWillPerformHTTPRedirectionWithCompletion closure to not be called @onmyway133. If you update to the latest release, everything should work as expected.
I'm going to close this issue out for now. If this doesn't actually solve your problem, please provide some additional info and I'll be happy to re-open.
Cheers. 🍻

@cnoon Can you try the following URL it didn't work with latest Alamofire.
http://www.hkpro.com/forum/attachment.php?attachmentid=104674


4.0b2 error

/home/captain/.local/lib/python3.7/site-packages/qtpy/__init__.py:211: RuntimeWarning: Selected binding "pyqt5" could not be found, using "pyside2"   'using "{}"'.format(initial_api, API), RuntimeWarning) Traceback (most recent call last):   File "/home/captain/.local/bin/spyder3", line 10, in <module>     sys.exit(main())   File "/home/captain/.local/lib/python3.7/site-packages/spyder/app/start.py", line 190, in main     from spyder.app import mainwindow   File "/home/captain/.local/lib/python3.7/site-packages/spyder/app/mainwindow.py", line 51, in <module>     requirements.check_qt()   File "/home/captain/.local/lib/python3.7/site-packages/spyder/requirements.py", line 42, in check_qt     package_name, required_ver = qt_infos[qtpy.API] KeyError: 'pyside2'
i have both pyside2 and pyqt5 installed...and 4.0b1 worked fine...
Why 4.0b2 came out this error message?

RuntimeWarning: Selected binding "pyqt5" could not be found

This says it all: qtpy couldn't find pyqt5 in your system and switch to pyside2, but Spyder can't work with pyside2.
Please uninstall pyside2 and try again.

after the error...first , i search the package i found no pyside2,
then i install it and still error
then i upgrade pyqt5 to 5.12.2 still error
then i uninstall pyside2 still error
then i reinstall spyder4.0b2 still error...all error is the same... @ccordoba12

Do you have pyqtwebengine installed as well?

@ccordoba12  yes...

Sorry, I'm out of ideas. Last two recommendations:

Remove everything in /home/captain/.local/lib/python3.7/ and use a clean virtualenv instead (if you don't remove the first directory, you can't use a clean virtualenv, I think).
Use Anaconda instead (which is our recommended and supported method of installation).

after remove spyder4.0b2 and pyqt5...i can launch a buggy 4.0b1...
then i install 4.0b2...and it become a buggy spyder... @ccordoba12

it's stuck a thread and eating more and more memory...my cpu is 6cores 12threads...
and in terminal i get one line warning: [W 08:02:04.187 NotebookApp] WebSocket ping timeout after 90000 ms.

If you're using Spyder


(CSM 1.0) CASMHMS-5572: Provide a procedure to recover from mismatched BMC Credentials

Summary and Scope
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
Provide a procedure to recover from mismatched BMC Credentials, when new or replacement hardware is added to the system with the factory default BMC root credentials (or another known password) that is different then the systems current  default BMC root password.
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Backwards compatible
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CASMHMS-5572

Testing
List the environments in which these changes were tested.
Tested on:

Fanta

Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?
I manually created a mismatch between Vault and a BMC on fanta, by manually changing a BMC creds to something different. I think followed this procedure to correct the BMC credentials to match the system's default creds.
Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
Low risk
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

I made a commit to do minor linting, to save Ryan the hassle and hopefully speed up the process. Gonna cherry-pick it to the other two PRs now.


Make client check for local thread server on every read.

Otherwise, a client created before the server in the same thread will not
allow reentrancy.

Hi Luke.
Thank you for continuing efforts.
Can I merge this ?

Yes, this one is ready.
On Wed, May 17, 2017 at 2:27 AM, Garcia Samuel<EMAIL_ADDRESS>wrote:

Hi Luke.
Thank you for continuing efforts.
Can I merge this ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pyacq/pyacq/pull/61#issuecomment-302036691, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA5aJCGpqWZHsP0qCehKhXCIi2F771muks5r6r2fgaJpZM4NS3DL
.


Error 'Response for getList SHOULD be an array and not an object or something else' does not reject promise

I am developing the front-end of a client's application, with no control over the backend beyond my ability to harass their developers.
At present, they have a bug in which under certain circumstances a request that usually returns a list [] is returning an object {}. This is bad and will be fixed, but we would like to catch the error and display a friendly message in the meantime.
Restangular causes an exception to reach the console, but, unfortunately, the promise for the .getList is never rejected:
promise = Restangular.all('endpoint')
    .one('node', $state.params.nodeId)
    .getList()
    .then (channels) ->
       # ...
       $scope.loadingStatus = 'success'
    , (error) ->
       $scope.loadingStatus = 'error'
       $scope.loadError = error

results in
Error: Response for getList SHOULD be an array and not an object or something else

but no rejection and hence no corresponding update to the $scope error properties.
I believe Restangular should be rejecting the promise here. This is not like an assertion error which is useful to show you that you have made a coding error; in this case the error is not under our control and we want our users to get a nice error message.

This is implementation error and so, it's throwing an error to let you know you need to fix your code. In case you are having some extra metadata embedded in your endpoint, please refer to this: https://github.com/mgonto/restangular#my-response-is-actually-wrapped-with-some-metadata-how-do-i-get-the-data-in-that-case

This is NOT an implementation error if you have no control over the
endpoint. If you are using a third party endpoint, you could design
everything just so in development, and then in production, a change to the
endpoint will create an error that you can't catch unless you have
exception handlers at the page level.
This is not an abstract concern, that's precisely the situation that
prompted this issue report. Our users got no report that a request had
failed when the third party endpoint decided to return an object instead of
a list under some conditions.
Basically this means that anyone using the library with a third party
endpoint has to add interceptors just to make sure the user would see an
error in this situation.
If the promise failed it would still let the coder 'fix their code' if they
had control over the endpoint. But at least the situation would not be
totally unrecoverable in production.
Michael
On 21/02/2015 11:37 PM, "Mike Grabowski"<EMAIL_ADDRESS>wrote:

This is implementation error and so, it's throwing an error to let you
know you need to fix your code. In case you are having some extra metadata
embedded in your endpoint, please refer to this:
https://github.com/mgonto/restangular#my-response-is-actually-wrapped-with-some-metadata-how-do-i-get-the-data-in-that-case
—
Reply to this email directly or view it on GitHub
https://github.com/mgonto/restangular/issues/962#issuecomment-75369863.

As getList signature suggest, it expects to receive an array from the endpoint you are using. As you are choosing the methods to use while creating an application - those are typically implementation errors as you configured Restangular wrongly with your application. It's worth noticing that this will raise an exception only if response from the API is successful. Otherwise - promise will be rejected with a runtime error defined by HTTP specification (like 500 Internal Server Error, 422 Unprocessable Entity and so on).
This error is there to let you know that you have set up chain of Restangular wrongly. In case your endpoint returns an object (single entity), refer to one() and get().
In case it returns something different, that's embedded within metadata, like below:
{
   status: "OK",
   data: [Array],
   totalCount: 20
}

refer to response interceptors that are described in the docs.
If the production endpoint is likely to be changed multiple times without any kind of proper versioning, apart from being irritated that those devs have no idea how REST spec looks like, you can do additional checks in your response interceptor like so:
if (_.isArray(response)) {
   return response;
} else {
   // do something weird here
}

As you can see https://github.com/mgonto/restangular#addresponseinterceptor - in the description, the last argument is deferred that you can MANUALLY reject if you feel that's the most appropriate way when response !== array. In that case, successful response manipulation will be omitted and error will not be thrown.

I get the idea and the work around. I'm not suggesting that you remove the
error entirely, just make it reject the promise. You could also use
console.warn to get the message across.
My beef is that a non-compliant server should not be able to force a client
side library to literally break the entire page in production. That's just
bad defensive programming.
Adding interceptors for everything gets you around this issue, but it's
laborious, and requires the programmer to guess in advance which APIs might
break. We just got lucky that our counterparts writing the API made this
error while one us us had a console open.
I totally accept the argument for enforcing the method signature to help
programmers. If Restangular just rejected the promise, and logged to
console saying 'oh no, the server broke the rules!', every developer using
the library would be defended against this edge case, and the method
signature would still be enforced.
Michael
On 22/02/2015 12:55 AM, "Mike Grabowski"<EMAIL_ADDRESS>wrote:

As getList signature suggest, it expects to receive an array from the
endpoint you are using. As you are choosing the methods to use while
creating an application - those are typically implementation errors as you
configured Restangular wrongly with your application. It's worth noticing
that this will raise an exception only if response from the API is
successful. Otherwise - promise will be rejected with a runtime error
defined by HTTP specification (like 500 Internal Server Error, 422
Unprocessable Entity and so on).
This error is there to let you know that you have set up chain of
Restangular wrongly. In case your endpoint returns an object (single
entity), refer to one() and get().
In case it returns something different, that's embedded within metadata,
like below:
{
status: "OK",
data: [Array],
totalCount: 20
}
refer to response interceptors that are described in the docs.
If the production endpoint is likely to be changed multiple times without
any kind of proper versioning, apart from being irritated that those devs
have no idea how REST spec looks like, you can do additional checks in your
response interceptor like so:
if (_.isArray(response)) {
return response;
} else {
// do something weird here
}
As you can see
https://github.com/mgonto/restangular#addresponseinterceptor - in the
description, the last argument is deferred that you can MANUALLY reject
if you feel that's the most appropriate way when response !== array. In
that case, successful response manipulation will be omitted and error will
not be thrown.
—
Reply to this email directly or view it on GitHub
https://github.com/mgonto/restangular/issues/962#issuecomment-75372637.

In response to your last comment, I'm glad you've been lucky enough to
never see this issue :)
I have seen it several times on different integration projects. The usual
case is that a bad dev on the other end returns an error message object
without setting an error status code.
Michael
On 22/02/2015 8:04 AM, "Michael Bertolacci"<EMAIL_ADDRESS>wrote:

I get the idea and the work around. I'm not suggesting that you remove the
error entirely, just make it reject the promise. You could also use
console.warn to get the message across.
My beef is that a non-compliant server should not be able to force a
client side library to literally break the entire page in production.
That's just bad defensive programming.
Adding interceptors for everything gets you around this issue, but it's
laborious, and requires the programmer to guess in advance which APIs might
break. We just got lucky that our counterparts writing the API made this
error while one us us had a console open.
I totally accept the argument for enforcing the method signature to help
programmers. If Restangular just rejected the promise, and logged to
console saying 'oh no, the server broke the rules!', every developer using
the library would be defended against this edge case, and the method
signature would still be enforced.
Michael
On 22/02/2015 12:55 AM, "Mike Grabowski"<EMAIL_ADDRESS>wrote:

As getList signature suggest, it expects to receive an array from the
endpoint you are using. As you are choosing the methods to use while
creating an application - those are typically implementation errors as you
configured Restangular wrongly with your application. It's worth noticing
that this will raise an exception only if response from the API is
successful. Otherwise - promise will be rejected with a runtime error
defined by HTTP specification (like 500 Internal Server Error, 422
Unprocessable Entity and so on).
This error is there to let you know that you have set up chain of
Restangular wrongly. In case your endpoint returns an object (single
entity), refer to one() and get().
In case it returns something different, that's embedded within metadata,
like below:
{
status: "OK",
data: [Array],
totalCount: 20
}
refer to response interceptors that are described in the docs.
If the production endpoint is likely to be changed multiple times without
any kind of proper versioning, apart from being irritated that those devs
have no idea how REST spec looks like, you can do additional checks in your
response interceptor like so:
if (_.isArray(response)) {
return response;
} else {
// do something weird here
}
As you can see
https://github.com/mgonto/restangular#addresponseinterceptor - in the
description, the last argument is deferred that you can MANUALLY reject
if you feel that's the most appropriate way when response !== array. In
that case, successful response manipulation will be omitted and error will
not be thrown.
—
Reply to this email directly or view it on GitHub
https://github.com/mgonto/restangular/issues/962#issuecomment-75372637.

Having thought on it a bit more, I'm going to make two more arguments in favour of this behaviour, and then leave it because I am sure this is getting annoying :)

There is precedent for rejecting the promise: if a browser receives a malformed HTTP response to an XMLHttpRequest, it does not fire an unrecoverable exception, it reports an error to the initiator of the request;

(Slightly silly statistics): if you have not seen the issue in 5 years, but I have seen it twice in 4 years from totally different APIs (in one instance the data returned was { 0: <first>, 1: <second>, ... } because a bad JSON library was used), then the combined odds are roughly that it happens 1 out of every 7500 days. This means the library does not handle a 1/10000 edge case. This suggests that, with enough users of the library, this will become a common edge case in that it will happen to someone at least every couple of days.

Anyway, I'll leave it with you. :)

@mgonto?
I think that those two quotes are the perfect solution :)

Adding interceptors for everything gets you around this issue, but it's
laborious, and requires the programmer to guess in advance which APIs might
break

Then the combined odds are roughly that it happens 1 out of every 7500 days. This means the library does not handle a 1/10000 edge case

I think that as long as this is very rare case to happen - it's worth leaving an extra option for our users to handle that case, as in 10000-1 cases they might expect an error to be thrown :)


TextField:  When tooltip prop is used, it throws error: "Tooltip is not defined"

Fixed by https://github.com/DigitalRiver/react-atlas/pull/451


Prayer Calculator

I think the Prayer skill calculator calculates Lit Gilded Altar and Ectofuntus bonuses correctly. Instead of making the multiplier 3.5x or 4x, it seems to add 350% and 400%, thereby making the multipliers 4.5x and 5x.
I don't know anything about how to fix this, but I hope it isn't too tough to do. Would really appreciate it so I could plan things quicker! Thanks!

#2921


Ability to clear the search list

Extension
https://www.raycast.com/dch09/ableton-live
Description
Would be nice to have an option to clear the search list to get rid of showing unwanted projects
Who will benefit from this feature?
No response
Anything else?
No response

Do you have any example of some other extension which has that very feature? Could be helpful.

Not sure if it's the similar function but here it is - https://www.dropbox.com/t/EqyS4sS3ElTNEoH4
Example extension link - https://www.raycast.com/HelloImSteven/jump

So basically this would temporarily remove result from the list? Or do you need some kind of blacklist so that some projects would not appear in results?

"temporarily remove result from the list" sounds good.

"temporarily remove result from the list" sounds good.

I was planning on releasing an update with blacklisted folders to omit during search, but temporarily removing results was never something I needed. If you need it tho, feel free to contribute.

Unfortunately I’m not a programmer, I’m musician and have no idea how to do it. Anyway thanks a lot for you work!


Question regarding code release timeline

Dear authors,
Thanks for sharing your amazing work and planning to release the codes!
May I gently ask when the codes/models are tentative to release, like within a few weeks or after paper acceptance?
Sincerely thanks!
Best,
Hubert

Thank you for your interest. Our code will be released before the acceptance of the corresponding paper, or possibly sooner.

We appreciate your interest. Our code has been released.


Remove ec2 instance type validator

We are removing it since it is based on botocore metadata.

Closing in favor of https://github.com/aws/aws-parallelcluster/pull/1460


PHOENIX-1674 Snapshot isolation transaction support through Tephra

PR that implements support for transactions using Tephra.
@JamesRTaylor  @elilevine  @jfernandosf  @samarthjain  @mujtabachohan

Created new pull PR
https://github.com/apache/phoenix/pull/127


Develop UI for pulling and visualizing data from multiple stations on the same graph

The current UI enables us to pull data for one station at a time. In order to enable comparison of different weather variables in the weather stations, there is need to come up with a logic on how data can be pulled and processed on the UI.

I believe this is enabled when pulling aggregated data for the table. However the UI seems to be outside of the scope of this project. Closing the issue for now