Update README.md

madhus code chanage
Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

madhus test please review and approve


Remove coordinate populating in the form_pscis and form_fiss_site

populating the easting and northing fields with $x and $y creates a bit of a dangerous situation because we have switched to Albers (3005) and are getting lat and long vs utm_northing/easting...
We don't want people to populate the pscis spreadsheet with the wrong coordinates.
A better option is likely for folks to populate the utms themselves and if they or we want to use the geom to determine the utm we pull it out with R or something else ....

form_pscis done already

just straight up remove them.  form creates spatial object.


Effects HUD isn't in the right position

My mod list (if is an incopatibility problem): https://pastebin.com/Bh7k9873

Ps: the screenshot was made before I remove "Giselbaer's Durability Viewer" mod, even without it the position is wrong

There's pretty much no way that I'd be able to tell what's causing it to happen without downloading all of the mods you have installed and removing them one by one. It's likely due to some other mod either replacing or moving where effects are being rendered, so that mod would likely have to implement this mod's API rather than the other way around. If you do find the problematic mod, let me know and I'll look into it.

Whenever BedrockIfy is installed, I experience this issue.
Thankfully, the mod lets you straight up disable some of its mixins. After some testing, I found that disabling "client.features.screenSafeArea" allows the status effects gui to be moved.


Auto Dark Mode is missing in this list

Why someone put Luna in it when you can have Auto Dark Mode?

@Armin2208 By "Auto Dark Mode" are you referring to an OS feature or a third-party software package?  If the latter, what is the link?

Auto Dark Mode automatically adjusts to the time of day and provides true darkness for best sleeping environment.nlp training

Here is the link: https://github.com/AutoDarkMode/Windows-Auto-Night-Mode


MediaQuery.of(context).size.height returns 0 on startup in release mode

I have a widget which is a member of a stack that's in the body of Scaffold:
MaterialApp(
        title: 'Flutter Demo',
        theme: ThemeData(
          primarySwatch: Colors.blue,
        ),
        home: Scaffold(
            body: Stack(
                children: [MyWidget()],
                alignment: Alignment.bottomCenter)));
  }

When I log MediaQuery.of(context).size.height in MyWidget's build() function, I get the following output in release mode:
12-27 18:43:39.650 12694 12740 I flutter : Context height: 0.0
12-27 18:43:39.854 12694 12740 I flutter : Context height:<PHONE_NUMBER>285714

The behavior is as expected in debug mode (height is never 0.0). I am doing some calculations with this
value that would result in some widgets having infinite height, which causes the application to freeze on startup.

That's because Flutter starts quicker in release mode and the native platform reports the actual resolution with a delay.
Just handle the case that the size is 0/0 at first.

Related problem with TabBar: https://github.com/flutter/flutter/issues/23339#issuecomment-432745227

did you solved this problem?

@gordon-rawe there shouldn't be much to solve.
Just make your code resilient against 0 values so that it doesn't cause an error.
Shortly afterwards your app will be rebuilt again with the proper value.

looks like a crutch

That is not a good thing!

Ran into the same problem. I was debugging for hours until I found out that size was empty. There was no hot-reload in release mode so it made debugging much more difficult.

same problem, I just release my app on store.

I've created a video and quick gist on this issue with a solution.
Video https://www.youtube.com/watch?v=zp26UXInb4s&feature=youtu.be
Gist https://gist.github.com/joseph-montanez/c7316b89c9a458a34c6381840cc6d1de
Basically, you need to switch out to use FutureBuilder and use a stream with a future to watch and capture the value once it's not zero.
Here is an example function to capture to streams value into a future:
  Future<double> whenNotZero(Stream<double> source) async {
    await for (double value in source) {
      print("Width:" + value.toString());
      if (value > 0) {
        print("Width > 0: " + value.toString());
        return value;
      }
    }
    // stream exited without a true value, maybe return an exception.
  }

Then in your widgets you specify the furture builder. In this example I an checking every 50 milliseconds to MediaQuery.of(context).size.width to see if its greater than 0.
            FutureBuilder(
                future: whenNotZero(
                  Stream<double>.periodic(Duration(milliseconds: 50),
                      (x) => MediaQuery.of(context).size.width),
                ),
                builder: (BuildContext context, snapshot) {
                  if (snapshot.hasData) {
                    if (snapshot.data > 0) {
                      return Container(
                                //...
                      );
                    }
                  } else {
                    return Container();
                  }
                }

@zoechi hopefully this will be a better answers as there are multiple reports of this issue.

same problem, I just release my app on store.

same problem, I just release my app on store.

any updates? it is big problem because in build we have different layout, which we select according sizes

Anyone solved the issue?

This is by design for performance reasons, as @zoechi mentions. I'm going to close this issue with the ways to work with this currently listed here.

 _recursiveZeroCheck(_size) {     if (_size > 0) {       return _size;     } else {       _recursiveZeroCheck(_size);     }   }

Had the exact same issue. I have changed the code as follow, then everything worked fine in release mode:
@override
Widget build(BuildContext context) {
InitialData.phoneSize = MediaQuery
.of(context)
.size;
if (InitialData.phoneSize.width == 0 || InitialData.phoneSize.height == 0) {
  return Container(
    child: Center(
      child: Text("Loading..."),
    ),
  );
} else {
  return SafeArea(
    child: Scaffold(
      body: Column(
        children: [
          MenuArea(),
          PlayArea(),
        ],
      ),
    ),
  );
}

}

That's because Flutter starts quicker in release mode and the native platform reports the actual resolution with a delay.
Just handle the case that the size is 0/0 at first.

Thanks, man! Your comment really helped me.

I've encountered this problem yesterday. It never happened on emulator. But then i tested my app on real device and MediaQuery.of(context).size.width returned 0. The UI of course didn't work properly because of this. When i "hot restarted" the app, it returned proper width. I also tried to stop the app and restarted it.., but it didn't happen again. It happens only every now and then. So it's kind of a hidden "bug". I think, this should be resolved somehow or at least some official docs how to handle this issue? I have now implemented the solution provided by @joseph-montanez ,but i am not sure if this is the best possible approach? Isn't there something more "clean"? Is anyone even aware of this problem? I think it should be marked as a bug.

This seems to be more simple refer to https://github.com/OpenFlutter/flutter_screenutil/blob/20ac1de0f2f2b95d43922d1567fa2aa1629c8cee/lib/screenutil_init.dart#L22.
Widget build(BuildContext context) {
    return LayoutBuilder(
      builder: (context, constraints) {
        if (constraints.maxWidth != 0) {
          return MaterialApp(
            home: HomePage()
        }
        return Container();
      },
    );
  }


fix: Fluent Checkbox events get called infinitely in a Fluent Tab

🐛 Bug Report

Having a FluentCheckbox (or a FluentSwitch) inside a FluentStack inside a component which is inside a FluentTab (or possibly a RenderFragment) on the current component cause the ValueChanged event to be called infinitely setting and unsetting the value. This happens when the ValueChanged is set manually.
💻 Repro or Code Sample

CheckboxBug.razor
@using Microsoft.FluentUI.AspNetCore.Components
<FluentStack Orientation="Orientation.Vertical">
    <FluentCheckbox
<EMAIL_ADDRESS>        ValueChanged="(isChecked) => ChangeDummyAsync(Value with {IsChecked = isChecked})">Checkbox</FluentCheckbox>

</FluentStack>

@code {

    [Parameter, EditorRequired]
    public required Dummy Value { get; set; }

    [Parameter]
    public EventCallback<Dummy> ValueChanged { get; set; }

    private Task ChangeDummyAsync(Dummy dummy)
    {
        return ValueChanged.InvokeAsync(dummy);
    }

}

Index.razor
@page "/"

@using BlazorApp2.Pages
@using Microsoft.FluentUI.AspNetCore.Components

<FluentTabs>
    <FluentTab Label="Tab1">
        <CheckBoxBug @bind-Value=@dummy />
    </FluentTab>
</FluentTabs>

@code {
    private Dummy dummy = new Dummy(false);
}

Dummy.cs
namespace BlazorApp2.Pages;

public record Dummy(bool IsChecked);

🤔 Expected Behavior

The bool value should be changed.
😯 Current Behavior

The checkbox checks and unchecks infinitely. ValueChanged is called multiple times.
💁 Possible Solution

🔦 Context

Trying to change multiple bool properties of a record with a specific component.
🌍 Your Environment

OS & Device: Windows on PC
.NET and Fluent UI Blazor library Version 8.0.2 and 4.7.2

It is the Tab component that is causing this. Without it the checkbox can be set/unset fine.
As the Tab relies on the underlying web component script and they are busy working on the next version (see https://github.com/microsoft/fast/issues/6955). I'm not expecting a fix for this anytime soon (if at all).
I suggest you look for a different mechanism of displaying your UI instead of with Tabs

@vnbaaij In the example above if you remove FluentStack from the CheckBoxBug component it functions as expected.

Good find! Really weird as a Stack is nothing more than a div with some styling...

@vnbaaij I think it is the use nested of RenderFragment (the children of the FluentStack) that is messing it up.


Upgrading from 8.1.0 to 8.2.0 throws NPE when building

Using with kotlin 1.0.3 and Dagger 2.5.
When using ButterKnife 8.1.0, I can build and run my project with no problem, but when trying to upgrade to 8.2.0, I get a NullPointerException:

`Caused by: java.lang.NullPointerException`
```
	at butterknife.compiler.ButterKnifeProcessor.scanForRClasses(ButterKnifeProcessor.java:1165)
	at butterknife.compiler.ButterKnifeProcessor.findAndParseTargets(ButterKnifeProcessor.java:176)
	at butterknife.compiler.ButterKnifeProcessor.process(ButterKnifeProcessor.java:153)
	at org.jetbrains.kotlin.annotation.AnnotationProcessorWrapper.process(AnnotationProcessorWrapper.kt:115)
	at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:794)
	at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:705)
	at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91)
	at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035)
	at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176)
	at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170)
	at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856)
	at com.sun.tools.javac.main.Main.compile(Main.java:523)
	... 34 more
```

Module dependencies include:
  provided 'org.glassfish:javax.annotation:10.0-b28'
  kaptAndroidTest "com.google.dagger:dagger-compiler:2.5"
  provided "com.google.dagger:dagger-compiler:2.5"
  kapt "com.google.dagger:dagger-compiler:2.5"

  compile "com.google.dagger:dagger:2.5"

  compile 'com.jakewharton:butterknife:8.2.0'
  kapt 'com.jakewharton:butterknife-compiler:8.2.0'

My initial upgrade path required Dagger 2.2 -> 2.5, but that would only allow me to get up to ButterKnife 8.1.0.
If you need any more details, I'm happy to provide them.

cc @kageiit

@shekibobo does the issue occur if you do not use kotlin as well?

@shekibobo I put up a PR to guard against the issue, but it would be great if you can provide a small sample to repro this issue so we can fix it without losing access to nicer generated code with R references


Ignore HTTP 'Accept' parameter

Ignore the HTTP 'Accept' parameter when serving pages.
Instead, to choose a different format, use a different URL.

We do not want to use the HTTP Accept header to decide what format to send,
because that interferes with using the CDN. Without this setting,
Rails will produce different values (in some cases) depending on the
HTTP "Accept" value, and thus will generate "Vary: Accept" (correctly).
However, since different browsers will have
different Accept header values, this Vary: Accept will mean that
different browsers will not share a CDN cached value.
By setting ignore_accept_user, users must use the URL to request a
non-default format. In compensation, this setting
speeds average response time & reduces server load by better using the CDN.
This commit primarily changes one setting:

Rails.application.config.action_dispatch.ignore_accept_header = true

However, it modifies tests & documentation, as well as
changing some JSON access settings for project statistics.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

@jdossett - even when Fastly got "back to working" there are a remarkable number of repeated values that should have been simply served from the cache (e.g., badge images and JSON data). I believe the reason is that we still pay attention to the "Accept" HTTP header, even though we deprecated that. So this commit fixes that, and hopefully we'll get a lot more cache hits.

Notice that even with CORS I'm tryiing to reduce what's in "Vary" (in many cases we don't even need "Origin" since the data wiill be identical regardless of the origin). What I'm hoping will happen, based on this patch, is that many requests that are currently hitting our server will be mreged into a single cache entry that will be served by the CDN. If that happens, users should see a big average speedup AND our server will have far less work to do. Here's hoping.
Any comments? Look okay?

We've logged for multiple days, and there's never been a JSON request without .json at the end of the path. I've been primarily worried about JSON, and using the "Accept:" header to select JSON just isn't normally done.
So I see no risk to merging this, and a lot of benefits. Let's do it!


Panic when viewing Monitored Apps on Linux

On Linux Mint 21.3, the process panics when I attempt to view the Monitored Apps from the context menu of the tray icon. I'm starting the app from the terminal. Here's the relevant parts of my terminal session while attempting to get some more details to share:
$ ./wakatime-linux-x86_64.AppImage
[WakaTime][DEBUG] Failed to read file: /home/caleb/.config/WakaTime/desktop-wakatime.cfg. Error: Error: ENOENT: no such file or directory, open '/home/caleb/.config/WakaTime/desktop-wakatime.cfg'
[WakaTime][DEBUG] Electron's autoUpdater does not support the 'linux' platform. Ref: https://www.electronjs.org/docs/latest/api/auto-updater#platform-notices
[WakaTime][DEBUG] Starting WakaTime
[WakaTime][DEBUG] Registered as login item
[WakaTime][DEBUG] Fetching code time: /home/caleb/.wakatime/wakatime-cli-linux-amd64 --today,--today-hide-categories,true,--plugin,linux-wakatime/0.5.0
[WakaTime][DEBUG] App changed from nil to Gnome-terminal
[WakaTime][DEBUG] Latest wakatime-cli release: v1.102.1
[WakaTime][DEBUG] App changed from Gnome-terminal to desktop-wakatime
[WakaTime][DEBUG] App changed from desktop-wakatime to Gnome-terminal
[WakaTime][DEBUG] App changed from Gnome-terminal to desktop-wakatime
thread '<unnamed>' panicked at x-win-rs/src/linux/api/common_api.rs:43:65:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
Aborted (core dumped)

$ ./wakatime-linux-x86_64.AppImage
[WakaTime][DEBUG] Electron's autoUpdater does not support the 'linux' platform. Ref: https://www.electronjs.org/docs/latest/api/auto-updater#platform-notices
[WakaTime][DEBUG] Starting WakaTime
[WakaTime][DEBUG] Registered as login item
[WakaTime][DEBUG] Fetching code time: /home/caleb/.wakatime/wakatime-cli-linux-amd64 --today,--today-hide-categories,true,--plugin,linux-wakatime/0.5.0
[WakaTime][DEBUG] App changed from nil to Gnome-terminal
[WakaTime][DEBUG] Skip checking for wakatime-cli updates because recently checked 4 minutes ago
[WakaTime][DEBUG] App changed from Gnome-terminal to desktop-wakatime
thread '<unnamed>' panicked at x-win-rs/src/linux/api/common_api.rs:43:65:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
Aborted (core dumped)

$ export RUST_BACKTRACE=1

$ ./wakatime-linux-x86_64.AppImage
[WakaTime][DEBUG] Electron's autoUpdater does not support the 'linux' platform. Ref: https://www.electronjs.org/docs/latest/api/auto-updater#platform-notices
[WakaTime][DEBUG] Starting WakaTime
[WakaTime][DEBUG] Registered as login item
[WakaTime][DEBUG] Fetching code time: /home/caleb/.wakatime/wakatime-cli-linux-amd64 --today,--today-hide-categories,true,--plugin,linux-wakatime/0.5.0
[WakaTime][DEBUG] App changed from nil to Gnome-terminal
[WakaTime][DEBUG] Skip checking for wakatime-cli updates because recently checked 5 minutes ago
[WakaTime][DEBUG] App changed from Gnome-terminal to desktop-wakatime
thread '<unnamed>' panicked at x-win-rs/src/linux/api/common_api.rs:43:65:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
fatal runtime error: failed to initiate panic, error 5
Aborted (core dumped)

$ export RUST_BACKTRACE=full

$ ./wakatime-linux-x86_64.AppImage
[WakaTime][DEBUG] Electron's autoUpdater does not support the 'linux' platform. Ref: https://www.electronjs.org/docs/latest/api/auto-updater#platform-notices
[WakaTime][DEBUG] Starting WakaTime
[WakaTime][DEBUG] Registered as login item
[WakaTime][DEBUG] Fetching code time: /home/caleb/.wakatime/wakatime-cli-linux-amd64 --today,--today-hide-categories,true,--plugin,linux-wakatime/0.5.0
[WakaTime][DEBUG] App changed from nil to Gnome-terminal
[WakaTime][DEBUG] Skip checking for wakatime-cli updates because recently checked 5 minutes ago
[WakaTime][DEBUG] App changed from Gnome-terminal to desktop-wakatime
thread '<unnamed>' panicked at x-win-rs/src/linux/api/common_api.rs:43:65:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
stack backtrace:
   0:     0x7f963cca8df1 - <unknown>
   1:     0x7f963cc4c7cb - <unknown>
   2:     0x7f963cc7cf42 - <unknown>
   3:     0x7f963ccae1e9 - <unknown>
   4:     0x7f963ccad9d6 - <unknown>
   5:     0x7f963ccaeee1 - <unknown>
   6:     0x7f963ccae552 - <unknown>
   7:     0x7f963ccae4a9 - <unknown>
   8:     0x7f963ccae496 - <unknown>
   9:     0x7f963cc3e282 - <unknown>
  10:     0x7f963cc3e745 - <unknown>
  11:     0x7f963ccea9af - <unknown>
  12:     0x7f963ccdd96a - <unknown>
  13:     0x7f963ccf8326 - <unknown>
  14:     0x5642fdf2e2e8 - <unknown>
fatal runtime error: failed to initiate panic, error 5
Aborted (core dumped)

I have the same error


updating clap version

the error appears by using it in avmg. clippy does not seem to complain - yet

PTAL @feuerste

this prevents an error documented in https://github.com/TeXitoi/structopt/issues/157

@wally-the-cartographer merge

Merge requested by authorized user catevita. Merge queue now has a length of 1.


chore(deps): update dependencies

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (d2b192e) 70.03% compared to head (3773438) 70.38%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   70.03%   70.38%   +0.35%
==========================================
  Files           8        8
  Lines         594      591       -3
==========================================
  Hits          416      416
+ Misses        178      175       -3

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


LSP not performing textDocument/rename from PYLS

OS: macOS 10.12.6 (16G1314)
Language Server: python-language-server (pyls) 0.18.0+5.gd8eb65f
Installation: Latest revision (72fa593b39cb3bdf6a3aa6840a076375a682d268)
Reproduction steps
Have the following code:
def return_one() -> int:
    return 2

print(return_one())

Place the caret on return_one.
Right click.
Select "Rename Symbol".
Rename the symbol to something else.

Expected behavior: The symbol is renamed properly.
Actual behavior: Nothing happens. No status message appears, either.
LSP configuration
https://gist.github.com/slice/a3b873321cb179ca2f6a47b8e436d61d
Messages
LSP:  --> initialized
LSP: pyls client registered for window 3
LSP:  --> textDocument/didOpen
LSP: <--  textDocument/publishDiagnostics
LSP:      {'diagnostics': [], 'uri': 'file:///Users/slice/testing/test.py'}
LSP:  --> textDocument/rename
LSP:      {'documentChanges': [{'edits': [{'newText': 'def ohwow() -> int:\n    return 2\n\n\nprint(ohwow())\n', 'range': {'end': {'character': 0, 'line': 5}, 'start': {'character': 0, 'line': 0}}}], 'textDocument': {'version': 0, 'uri': 'file:///Users/slice/testing/test.py'}}]}

pyls payload
{
  "documentChanges": [
    {
      "edits": [
        {
          "newText": "def renamed() -> int:\n    return 2\n\n\nprint(renamed())\n",
          "range": {
            "end": {
              "character": 0,
              "line": 5
            },
            "start": {
              "character": 0,
              "line": 0
            }
          }
        }
      ],
      "textDocument": {
        "version": 0,
        "uri": "file:///Users/slice/testing/test.py"
      }
    }
  ]
}

LSP doesn't support the versioned documentChanges yet (see https://microsoft.github.io/language-server-protocol/specification#workspaceedit)
This should be added to all edit-related response handling.


Celo native token not compatible with foundry

Component
Forge, Anvil
Have you ensured that all of these are up to date?

[X] Foundry
[x] Foundryup

What version of Foundry are you on?
forge 0.2.0 (df8ab09 2023-03-14T10:00:26.197329Z)
What command(s) is the bug in?
No response
Operating System
macOS (Apple Silicon)
Describe the bug
This test fails I think because the celo token is a precompile. This issue is also present in Viem.
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;

import { Test } from "forge-std/Test.sol";
import { console2 } from "forge-std/console2.sol";
import { ERC20 } from "solmate/tokens/ERC20.sol";

contract CeloTest is Test {
    ERC20 celo = ERC20(0x471EcE3750Da237f93B8E339c536989b8978a438);

    // deal doesn't work in this case so use an address that already has some celo
    address addr = 0x4117f8C086a0ECA19eA21dE0AE7C5087e3C359fb;

    address recipient = makeAddr("");

    function testCeloBalance() external {
        vm.createSelectFork("celo");
        uint256 balance = celo.balanceOf(addr);

        vm.prank(addr);
        celo.transfer(recipient, 1 ether);

        assertEq(balance - 1 ether, celo.balanceOf(addr));
        assertEq(1 ether, celo.balanceOf(recipient));
    }
}

This is known. We currently only support mainnet precompiles which are implemented in Revm, and there's no way to configure this in Foundry. See also https://github.com/foundry-rs/foundry/issues/748.


Usability improvment

Informations
Browser version: Google Chrome 62.0.3202.94
OS: Windows 10
Screen resolution: 1600x900px
How to reproduce the bug?
Hey Alex,
the usability of the wysiwyg-editor needs a little bit of improvment i think.
Most people would use it like a word program:

When you haven't any text before, or a new blank line, i would click e.g on the bold-button and then write bold text, but the button do nothing in this moment. I must select the text to make it bold.
When I have a text selected and make it bold, further typings are even bold, but i could not exit this bold-mode with a click on the bold-button. The button stays active. I must select the next words to "unbold" them

This seems to be the case with every button

I can't do that. It's a big & hard work to do and the Trumbowyg core can't be fixed to support that, sorry :/

Ok i understand Alex,
but i think you should then fix the "bug", that the selected mode stays active, when selection is make to bold. You should only allow to mark text and change them, but when the user writes anything the default mode should be activated.


Update release notes for 1.2 release

Check List

[ ] New functionality includes tests
[ ] All tests pass
[ ] RELEASE_NOTES.md has been updated if required (not required for bugfixes, required for API changes)
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

This one is going to land as well: https://github.com/chef/delivery-cli/issues/12
Do we want to add it to the release notes?

Also is missing the stages for local commands. Ill add them (from previous comment) both if you want.

I view that as more of a bug fix than anything else.

We'll also want to note important gem bumps since that's a big part of ChefDK

Added gem diffs, just need to wait for the final inspec version to be released and pulled in.


Different Group Name for Fake Client

When using the fake kapp-control client for mocking interactions with a cluster, if an actual App runtime object is loaded into the NewSimpleClientset constructor, the app will never be retrieved by the fake client.
This is due to how the ObjectTracker works for the fake client. The ObjectTracker stores runtime objects passed into the NewSimpleClientset constructor as key-value pairs where the key is the GroupVersionResource combination and the value is a list of objects the ObjectTracker is aware of.
Since the fake client uses a group name of kappctrl instead of kappctrl.k14s.io, apps created/used in tests are never located by the fake client.
It would greatly help with testing to be able to use the actual App structs in tests and load them into the fake client to replicate communicating with a cluster.

It seems it was related to how the fake client is generated. One of the directives given to client generator had the incorrect group name: https://github.com/vmware-tanzu/carvel-kapp-controller/blob/53cbfee531155c40268ff8914f62becd15a94836/pkg/apis/kappctrl/v1alpha1/doc.go#L6.

@danielhelfand Could you share a bit more about how this impacts your workflow now (i.e. this would save x amount of time each time we're in this test suite)? We're trying to determine when/if we should prioritize this.

It would basically allow developers working on kapp-controller to test things in a non e2e fashion, which means less dependencies (i.e., a Kubernetes cluster, setting environment vars for tests) are needed and feedback can be received faster since the tests should run quicker. Currently, some of our e2e tests can some times take 2 minutes to run. So it can be challenging getting quick feedback when developing. Whereas writing tests with the fake client can run in seconds.
The downside of this approach is that it can't test deployment features of kapp-controller. This would really be reserved for testing where no deployment needs to take place, so we can more easily test things without going through the whole e2e flow. I think the benefits of better testing patterns that allow for quicker feedback would be very helpful.
This is also a one line change and regenerating the client to use this new group name. Or we can manually edit the group name for the fake client and it should work.

Thank you for the explanation. If this is low-hanging fruit then please feel free to drag it into the backlog where it makes sense.

This has been addressed and can be closed out: https://github.com/vmware-tanzu/carvel-kapp-controller/blob/d94984a77fa907ac5ecc681e9a842b9877766a6b/pkg/apis/kappctrl/v1alpha1/doc.go#L6


update-deps for sample-controller

./hack/update-deps && ./hack/update-codegen

/ok-to-test
/lgtm
/approve

/retest

/close
The changes I needed were applied in another PR

/reopen


adding bdd for activate and deactivate promotions

Hey Anmol, the BDD test build fail. Can you double check please?

Hey Yen
Good Afternoon
I am working on it since morning, had also sent you a message on slack
updating you about the same.
Let me know if I missed out on anything.
Thanks and Regards
Anmol Gahlawat
On Sun, Dec 10, 2023 at 1:27 PM Yen-An Chen @.***>
wrote:

Hey Anmol, the BDD test build fail. Can you double check please?
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CSCI-2DGA-2D2820-2DFA23-2D001_promotions_pull_87-23issuecomment-2D1849043108&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=XBpuqS4cm39ssvk3b7ZDoA&m=ZtC7h11oWn7RdhfDZ2b8SVVF2rEQ2zewGml3qgCFJz_q3D4LwUYKb0BOt5FdMveR&s=Vp3GKC3b3uL5-_gzJOOR8qgKSvN02lhcKBSW6qIvXpk&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_A3KPWBXX6KAJH73E4REIPYTYIX5KDAVCNFSM6AAAAABANQMT72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGA2DGMJQHA&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=XBpuqS4cm39ssvk3b7ZDoA&m=ZtC7h11oWn7RdhfDZ2b8SVVF2rEQ2zewGml3qgCFJz_q3D4LwUYKb0BOt5FdMveR&s=D5mCJIFOyzP_NE0kSX3Ac1dJgBJo3Xcci4rFMD0YXNc&e=
.
You are receiving this because you were assigned.Message ID:
@.***>

old code, creating separate ones by features


RF builder: Reassigning indicator to different result level -- unexpected confirmation prompt

Issue

Open up an RF level that has indicators linked to it.
Change the result level and click "Save and close".
Now attempt to visit the result level to which you just assigned the indicator.

Expected behavior: Since I haven't made any changes to the original result level, it should close and the new one should open.
Observed behavior: I get this warning and am not sure what it means...

I try clicking "OK" and THEN it does what I originally expected it to do... But what exactly was I confirming just now?

@jennyhavah Somewhere along the way, this may have been fixed.  I tried to reproduce but couldn't. Can you take another look?

I can no longer reproduce it either! Woo!


SourceDistPackage.groovy does not handle the Compatible release clause

https://github.com/linkedin/pygradle/blob/dfb28e25e914336a9999e02e0f585ccc03548c61/pivy-importer/src/main/groovy/com/linkedin/python/importer/distribution/SourceDistPackage.groovy#L102
The file uses this segment of code to split the dependency name from it's version.
This does not work when the Compatible release clause is used ~=
The current implementation fails to split the version from the name and ends up failing with the exception org.apache.http.client.HttpResponseException: Not Found
Here are some sample logs from when I found this issue
13:34:32.170 [INFO] [com.linkedin.python.importer.deps.DependencyDownloader] Pulling in fs:2.0.0
...
13:34:32.171 [DEBUG] [org.apache.http.impl.execchain.MainClientExec] Executing request GET /packages/e7/e5/5f2784276ce5f06a0183453e59d3d46b2c5fe4463885f51d88ae28749500/fs-2.0.0.tar.gz HTTP/1.1
...
13:34:32.216 [DEBUG] [com.linkedin.python.importer.distribution.SourceDistPackage] requires: appdirs~=1.4.0
enum34~=1.1.6
pytz
scandir~=1.3
setuptools
six~=1.10.0

13:34:32.216 [DEBUG] [com.linkedin.python.importer.distribution.SourceDistPackage] Split(appdirs~=1.4.0) [appdirs~=1.4.0]
13:34:32.216 [DEBUG] [com.linkedin.python.importer.distribution.SourceDistPackage] Split(appdirs~=1.4.0) [appdirs~=1.4.0]
13:34:32.216 [DEBUG] [com.linkedin.python.importer.distribution.SourceDistPackage] Split(appdirs~=1.4.0) [appdirs~=1.4.0]
13:34:32.216 [DEBUG] [com.linkedin.python.importer.pypi.PypiApiCache] Metadata url: https://pypi.org/pypi/appdirs~=1.4.0/json
...

Thanks for merging that in.


Stuck in Connecting Steam Account

When I inject vac bypass dll to steam without internet and turn on internet and click retry its just stuck saying Connecting Steam Account: (account name)...
What am I doing wrong?

It's Steam bug. Some people say that launching Steam in Big Picture mode fixes this issue.

Now you can use VAC Bypass Loader which does not require disconnecting from the internet.


setValue:forUndefinedKey error But only when running through Xcode.

Hi,
First off I just wanted to say this is a fantastic library. Thank you for your awesome contribution to the community!
I have just updated to 0.1.8... previously hero was working as expected. Now I have an odd crash that only presents itself when navigating to a hero enabled scene and when I'm running the application on a real device connected to Xcode:
[<UIImageView 0x119ad3840> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key heroModifiers.
When the same device is disconnected from Xcode the application runs fine and hero scenes work as expected.
Is it possible I have missed something during the installation of the new version?

That's odd. Try updating to the newest 0..2.0

Now updated, I seem to be having the same problem. Is there anything else you can suggest I look at?

Oh, did you have heroModifiers set in storyboard. That property has been renamed to heroModifierString in storyboard.
Check here and make sure you don't have heroModifiers set to any of the views:

You can do a project wide search for heroModifiers and see if any storyboard contains it.

That sounds very likely to be the problem. I'll only be able to verify tomorrow. Thank you for your help 👍

Working perfectly now. Thanks
I'm really looking forward to seeing what I can do with this!


Account name too long + other stuff

Gonna see what happens if I flip and switch stuff around. Maybe I do just need a shorter name =/
http://image.prntscr.com/image/07259fffd20b4dadb721f9356f77a96b.png
http://image.prntscr.com/image/1fc5e172bd254f978e07de3e70f4aab7.png

Are you just getting this from the ToS accepter? Or the account script itself?

I'm getting the Stoperror: status code 3 recieved from RPC. this is from the Tos Acceptor I imagine? It makes the accounts but i get this after the next step.

Account script itself.

http://image.prntscr.com/image/22797a768fa14d3c9b5b7a31fa146bcd.png

All these screenshots you're showing me are coming from the ToS accepter, which we're using MRokas's PogoPlayer for. This would be better suited on his github https://github.com/MRokas/PogoPlayer. Code 3 from RPC means that the account returned verified when it attempted to verify it.
The 12 characters is it trying to set the trainer name.


Add version detection

Allow the same DLL to be used for both versions 1.13c and 1.13d.

Also, VC++ 2013 is no longer needed to run the mod.


Temporal.Now.timeZoneId() returns undefined on MacOS 14.0 (Sonoma)

As the title suggests I am getting `undefined when running this code
Temporal.Now.timeZoneId() // undefined

Not sure what other information I need to provide however here is the output of npx envinfo --system --binaries --browsers
  System:
    OS: macOS 14.0
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 410.13 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.17.0/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm
    pnpm: 8.6.11 - ~/.nvm/versions/node/v18.17.0/bin/pnpm
  Browsers:
    Chrome: 117.0.5938.149
    Safari: 17.0

To add to that when I try to use Temporal.Now.zonedDateTimeISO() I get the following error
RangeError: Invalid time zone specified: undefined

This is a known bug in Chromium on MacOS 14.0: https://bugs.chromium.org/p/chromium/issues/detail?id=1473422
It's not related to the Temporal polyfill. The underlying API that the polyfill uses is also affected.  Example:
new Intl.DateTimeFormat().resolvedOptions().timeZone

Thank you for the swift reply @justingrant . Is there any sensible workaround this?

I updated my comment above to link to a more appropriate Chromium issue, and added some related links.

Is there any sensible workaround this?

If yours is a server app running in Node, you could I guess try running it in Bun, which uses Safari's JS engine JavaScriptCore which doesn't exhibit this problem.
For client apps, the only workaround seems to be using Firefox or Safari.
But I don't think there's any way to work around this in V8, so any V8-based host (Chrome, Node, etc.) will have the problem.

Here's the root cause issue to track the upstream regression is in the ICU library that V8 uses to handle time zones: https://unicode-org.atlassian.net/browse/ICU-22541

Version 118.0.5993.88 (Official Build) (x86_64) Of Chrome seems to have fixed this issue. However FireFox 118.0.2 (64-bit) seems to be returning ETC/GMT-8 instead of Asia/Kuala_Lumpur.
This is still problematic as the two timezones are not canonically equal.
the following test is failing:
describe("canonicalEquals should work as expected", () => {
  it("should return true for equal zones", () => {
    expect(canonicalEquals("Etc/GMT-8", "Asia/Kuala_Lumpur")).toBe(true); // <-- Fails here
    expect(canonicalEquals("Asia/Calcutta", "Asia/Kolkata")).toBe(true);
    expect(canonicalEquals("Pacific/Truk", "Pacific/Yap")).toBe(true);
    expect(canonicalEquals("Africa/Asmera", "Africa/Asmara")).toBe(true);
  });

  it("should return false for different zones", () => {
    expect(canonicalEquals("Africa/CasaBlanca", "Africa/Algiers")).toBe(false);
  });
});

where canonicalEquals is as follows taken from the proposal-canonical-tz:
import { Temporal } from "@js-temporal/polyfill";

const EPOCH = Temporal.Instant.fromEpochNanoseconds(0n);

export function canonicalEquals(zone1: string, zone2: string) {
  const zdt1 = EPOCH.toZonedDateTimeISO(zone1);
  const zdt2 = EPOCH.toZonedDateTimeISO(zone2);
  return zdt1.equals(zdt2);
}

@justingrant Is that an expected behaviour?

@ptomato @justingrant is it an expected behaviour that ETC/GMT-8 and Asia/Kuala_Lumpur are not canonically equal?

@justingrant would be the expert on that, but it does not sound to me like those should be canonically equal.

Asia/Kuala_Lumpur has only been UTC+8 since 1982, so it can't be canonically equal to a fixed-offset zone.

Asia/Kuala_Lumpur has only been UTC+8 since 1982, so it can't be canonically equal to a fixed-offset zone.

I am not sure I understand what you are trying to say. So ETC/GMT-8 is an offset and not a timezone? and why aren't they canonically equal if we are counting from Epoch ?

This is a complicated topic that we're trying to make less complicated.
Time zones in ECMAScript are based on the IANA Time Zone Database, or "TZDB" for short. A TZDB time zone identifer can either be a "Zone" or a "Link" that resolves to a Zone.
For example, "Asia/Ulan_Bator" is a link that resolves to the Zone "Asia/Ulanbataar", because "Ulan Bator" (the English name of the capital of Mongolia) was renamed to Ulanbataar and TZDB followed suit.
In ECMAScript, time zones are considered equal (meaning Temporal.TimeZone.prototype.equals returns true) when the IDs resolve to the same Zone in TZDB. So "Asia/Saigon" and "Asia/Ho_Chi_Minh" are equal, while "GMT-7"  and "Asia/Ho_Chi_Minh" are not equal because they resolve to a different Zone in TZDB.
What makes this a bit complicated is that TZDB is not a well-specified thing. Depending on the command-line options used to build TZDB, for example, "Europe/Amsterdam" could be a Zone or a Link to "Europe/Berlin", because   "Europe/Amsterdam" and "Europe/Berlin" have had the same UTC offsets for every instant since 1/1/1970 UTC, even though they varied before that.
We're working on standardizing this behavior to more clearly define for ECMAScript when time zones are considered equal or not. See https://github.com/tc39/ecma402/issues/825 for more details.
So to answer your question: "Etc/GMT-8" is not considered equal to "Asia/Kuala_Lumpur", because they are different Zone IDs in TZDB, so they are not equal in ECMAScript.

FireFox 118.0.2 (64-bit) seems to be returning ETC/GMT-8 instead of Asia/Kuala_Lumpur.

I'm not sure what browser engines are doing to work around this change in behavior in MacOS. But in general, browsers should be reporting the same time zone ID. If you're seeing "Asia/Kuala_Lumpur" in Chrome but "Etc/GMT-8" in Firefox, then that seems like a Firefox bug and you should probably report it. FYI @anba.

Firefox is also using ICU, so we had the same time zone bug on Sonoma as Chrome had. We've integrated the ICU patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1856428 for all release branches, so the next Firefox release (October 24, 2023) will work correctly again.

Etc/GMT-8 was returned in Firefox, because we have a fallback code path to handle the case when ICU isn't able to determine the system time zone. Basically when ICU reports back that it can't determine the system time zone, we try to give the user a better time zone than just UTC.

So to answer your question: "Etc/GMT-8" is not considered equal to "Asia/Kuala_Lumpur", because they are different Zone IDs in TZDB, so they are not equal in ECMAScript.

I realize that I didn't really explain why these are different Zone IDs. It's because "Etc/GMT-8" for every possible instant has the offset +08:00. However, "Asia/Kuala_Lumpur", while it currently uses +08:00, might possibly change that offset at some point in the future, based on the decisions made by the Malaysian government. So we (and the IANA Time Zone Database) consider those time zones unequal.

So to answer your question: "Etc/GMT-8" is not considered equal to "Asia/Kuala_Lumpur", because they are different Zone IDs in TZDB, so they are not equal in ECMAScript.

I realize that I didn't really explain why these are different Zone IDs. It's because "Etc/GMT-8" for every possible instant has the offset +08:00. However, "Asia/Kuala_Lumpur", while it currently uses +08:00, might possibly change that offset at some point in the future, based on the decisions made by the Malaysian government. So we (and the IANA Time Zone Database) consider those time zones unequal.

Thanks a lot for the detailed explanation. It makes sense to me when you explain it that way. but when i looked at the implementation of canonicalEquals I was under the impression that it's checking the number of milliseconds or microseconds since epoch. which then leads me to my question why are we using Epoch here?

Firefox is also using ICU, so we had the same time zone bug on Sonoma as Chrome had. We've integrated the ICU patch in bugzilla.mozilla.org/show_bug.cgi?id=1856428 for all release branches, so the next Firefox release (October 24, 2023) will work correctly again.

I can confirm that Firefox 119.0 is working as expected. I will be closing this issue but i would love to have an answer to the question above? basically why are we using Epoch for canonical comparisons?

why are we using Epoch for canonical comparisons?

The canonicalEquals example you linked to comes from https://github.com/tc39/proposal-canonical-tz#6-add-temporaltimezoneprototypeequals, which demonstrated that comparing time zones for equality was possible using the ZonedDateTime.prototype.equals method. A ZonedDateTime instance stores three pieces of data: an Instant (number of nanoseconds since epoch), a time zone, and a calendar. By using the same instant and calendar when creating two ZonedDateTime instances, you can use ZonedDateTime.prototype.equals to determine whether two time zones are equal.
Epoch could have been any other time, the key was that they are equal.
Modern code can use the new Temporal.TimeZone.prototype.equals method instead, for a more ergonomic comparison. Like this:
Temporal.TimeZone.from('Asia/Calcutta').equals('Asia/Kolkata'); // => true
Temporal.TimeZone.from('Asia/Calcutta').equals('Asia/Colombo'); // => false

, because that method tests three things: whether the

Makes sense to me now. Thank you @justingrant


gallery parser

found an elegant way to do for loops inside template literals. This is just example for a runic gallery function, but you could essentially use that for anything that grabs a list of items and spits out layout. LONG arrays can now have arrays in them :)

Don't have to merge this, thought it was neat, wanted to share :)

I love the idea, what I'll do I think is to use the % media rune instead. But I'll merge so I get your method. Thanks :)


fix(slider): displayWith function never called with "null"

Currently the "displayWith" function for a MatSlider is typed
in a way that implies that the function is sometimes called with
null as value. This is never the case because the value property
of the slider always returns a number but is just typed as null-able
because getters and setters cannot have different types.
This fixes the type for the displayWith function as it will never be
called with null.
@jelbourn Not sure what the best target for this PR would be. It's technically a fix but I could also see this as breaking for applications with strictFunctionTypes and Ivy's strict input type checking enabled

@crisbeto Yeah unless I miss something, the getter that returns the value falls back to the minimum value if the value is null. The minimum value is always a number (with fallback of 0).

Caretaker note: if the API change breaks anything in Google, bump this PR to target: major

Presubmits passed, can be merged as patch. Just needs rebase

@andrewseguin Rebased.


February 13th, 2024 - Regulation Innovation SIG Meeting Minutes

Regulation Innovation SIG
Date
February 13th, 2024 - 12pm EST / 5pm GMT
Untracked attendees

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[x] Convene & roll call (5mins)
[x] Display FINOS Antitrust Policy summary slide
[x] Review Meeting Notices (see above)
[ ] Approve past meeting minutes

[x] https://github.com/finos/open-regtech-sig/issues/65

[ ]  ISDA DRR Presentation - David Shone, ISDA

[ ] DRROverview.pdf

[ ]  CDM for the Buy Side - Emmanuel Geinoz, Pictet
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made
Action Items
Join Zoom Meeting
https://zoom.us/j/95819415471?pwd=VmxmeExMcXJFZWs4OGtnTXBiWnVHdz09

Meeting ID: 958 1941 5471
Passcode: 915672
Find your local number: https://zoom.us/u/acoFmoLAFE

tabish ahmed / ISDA

Martin Udy Bank of England

Sandeep Kumar, Synechron/FinLabs

Eteri / FINOS

David Shone/ISDA

Jane / FINOS

Rimma Perelmuter/FINOS

Kannan Rajagopal / Synechron

Ffion / GS

Alessandro Petroni / Independent Advisor


Not all sensitive request and response header and cookie names are properly masked

Reproduce: run tests in MaskingSensitiveDataTests.cs and inspect results. Some things work, others don't. Needs looking into after updating logging logic.

Fixed in https://github.com/basdijkstra/rest-assured-net/commit/5d3b0421b0af12286f7b5342e1c0c71990976e4c.


Add allowdisabledfocus attribute in button components (#379)

because there are some big issues introducing in this PR, I'm closing it.
please apply the appropriate improvements in both the issue and the PR.
@SomayeEbrahimi


ImportError: cannot import name 'currdir' from 'lk_utils.filesniff

from pyportable_installer import full_build
error:ImportError: cannot import name 'currdir' from 'lk_utils.filesniff

The dependency version is not correct, I've tried fixed it.
Before: lk-utils>=2.4.1
After: lk-utils>=2.4.1,<2.5.0
If you installed this package from PyPI, please upgrade it: pip install -U pyportable-installer.
If you cloned the repo, please pull the latest commits and check your lk-utils version (something like below):
pip uninstall lk-utils
pip install "lk-utils>=2.4.1,<2.5.0"


update legacy bcs path

This PR updates the path to the legacy bcs data by pointing to the new "bcs_shared" directory in the GMAO project space on Discover (replacing /discover/nobackup/ltakacs/bcs/).
This is the first step in using (legacy) bcs from the new "bcs_shared" dir.  The next and much more complex step will address using bcs in their revised sub-directory structure.

@gmao-rreichle  To me these look right. These are only ones I found as well.

@gmao-rreichle To me these look right. These are only ones I found as well.

Ok, thanks.  I suggest you go ahead and approve/merge the PR.


Change WPS ConnectionContext.States to a Dict<string, JsonElement>

My major concern with this is choosing JsonElement instead of the newer JsonNode.

Closing in favor of https://github.com/Azure/azure-sdk-for-net/pull/25504

Thank you Ted for proposing the fixes. Closing this as fixed with #25504.


3.0 PEM reading perf cherry picks: PR 17881, 18354 and 17921

This PR cherry picks 3 performance improvements, removing lock contention while reading PEM files, improving ossl_lh_strcasehash and decoder resolution speed:

https://github.com/openssl/openssl/commit/927d0566ded0dff9d6c5abc8a40bb84068446b76 from https://github.com/openssl/openssl/pull/17881
https://github.com/openssl/openssl/commit/a4e21d18d5b7cb4fef66c10f13b1b3b55945439f from https://github.com/openssl/openssl/pull/18354
https://github.com/openssl/openssl/commit/4a1108eb5906cd3cf47a3f70bd58722dbe2023a4 from https://github.com/openssl/openssl/pull/17921

OTC: do we want these changes in 3.0?

What is the performance boost after applying these patches?

This doesnt currently build.

OTC: this should not go into 3.0

What is the policy for getting an exception so that these would land on the 3.0 branch?

OTC votes on issues such as these.
Once you start applying 'exceptions' to stable branches it can become a slippery slope of changes being applied. Some of the performance changes (such as the libctx locking) are quite complex and it becomes hard to argue that this should be an exception.
As there is also a 3.1 release coming (that should be released today), that contains all the fixes, the changes are not likely to be merged back to 3.0. Note that if you need FIPS you can build the OpenSSL 3.0 FIPS provider and use it with OpenSSL 3.1 (which supplies libcrypto, and the providers default, base and legacy). This gives you a validated FIPS 140-2 module as well as all the fixes.

Thanks a lot for the explanation of the process. Now that OpenSSL 3.1 is out, I will not apply for an exception on top of 3.0.x.


⚠ TiendaEnLinea has degraded performance

In 406a861, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 6605 ms

Resolved: TiendaEnLinea performance has improved in 9b929d3.


[KOGITO-7705 Updating grpc documentation

Including properties and describing enum default behaviour

JIRA:
https://issues.redhat.com/browse/KOGITO-7705

Description:

Please make sure that your PR meets the following requirements:

[ ] You have read the contributions doc
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[ ] The nav.adoc file has a link to this guide in the proper category
[ ] The index.adoc file has a card to this guide in the proper category, with a meaningful description

Can you make this snippet multiline?

Can you make this snippet multiline?

Im not a fan of using a PR for a purpose was not created for. Also I believe this should be single line after all

Can you make this snippet multiline?

@ricardozanini Im not a fan of using a PR for a purpose was not created for. Also I believe this should be single line after all (splitting it might cause confusion to users, it is one or multiple lines?)

it's a simple change since you are updating this guide, after all.


Move installation instructions to rst docs

A follow-up on #298: I moved the instructions from @ARK3r to the rst file, which is published on control.ros.org and extended it with instructions for a local manual installation.

@ARK3r Do you have a suggestion how we can fix the view_robot.launch.py to run from the docker image? joint_state_publisher_gui cannot be launched obviously.
we could add to the instructions, that one has to install ROS locally (already necessary for rviz2) use sudo apt-get install ros-humble-joint-state-publisher-gui, and run ros2 run joint_state_publisher_gui joint_state_publisher_gui
But then we need a gui:=false flag for these launch files.

I think doing as you suggested makes sense.
I'll try to add the flag tonight.

@christophfroehlich I started adding the gui arg then I realised we'd need to have both rviz and joint_state_publisher_gui to run if this arg is true.
But if we want to run it in docker, then we can't have either of them run their gui.
So then we'd need to run rviz and joint_state_publisher_gui outside the docker.
Since we don't want the user to colcon build the package (because in the case that they run the build then what's the point of having the docker?), then the user would have to run rviz and joint_state_publisher_gui in two seperate terminals and I think at this point this is just too messy for the user.
Do you think there's a way we could do this cleaner?

Exactly, we'd need both to run outside of the docker. Opening a new terminal is less messy for a beginner than having a docker where half of the examples don't work ;) We could also provide a docker with X11 forwarding, but that's not easy to work on every host platform.
I'd go for a single gui argument (default true), if set to false then neither rviz2 nor jsp_gui should be launched.

Made a pr to your fork: https://github.com/christophfroehlich/ros2_control_demos/pull/3
I'll add some documentation now too.

I still think this is "too much work" for a new commer just to get to view the robot, and maybe we should push "view robot by docker" lower into the documentation, or maybe make a table that has an overview of the repo in one screen size so anyone coming in can see at one glance what are all the things the repo does.

I still think this is "too much work" for a new commer just to get to view the robot, and maybe we should push "view robot by docker" lower into the documentation, or maybe make a table that has an overview of the repo in one screen size so anyone coming in can see at one glance what are all the things the repo does.

I agree that the barriers of entry are higher with using the docker, but let us think of a necessary educational aspect ;) Let us make an easy readable introduction to the docker and a small hint on top of every example-rst, that the following commands are written for a local installation and if used with docker one has to use the prefix docker etc, like
.. note::

   The following commands are written for a local installation. If you use the provided docker container, add the following prefix

   .. code::

   docker run -it --rm --name ros2_control_demos --net host ros2_control_demos

   For more  information on the docker usage see :ref:`ros2_control_demos_install`

is this sufficient for the rst for now?
https://github.com/christophfroehlich/ros2_control_demos/pull/5

@mergifyio backport humble


Training on custom dataset

Hello! First of all - thank you for your work! You have a very interesting project!
I'm trying to use it to train a base network on custom data for our project related to plant diseases detection.
I managed to do it using byol approach. In the end, I have byol-400ep-custom-3u5w2uqi-ep=40.ckpt file. If I understand right - I can use it as a feature extractor.
There is no known number of classes just a huge amount of plant images. So, I want to know is there a way to understand how good the network is in classification. Can I somehow get suggestions on the number of classes and see examples of images related to classes?
Is there a way to use mobilenet_v2 as the backbone?

Hey,
Thanks. You can try clustering with k-means to discover some properties of your data. Or manually label some instances and perform k-NN (then you can use something like our main_knn.py). There's no property of BYOL or our library that would suggest a number of possible clusters in the data.
About the backbone, sure, but you will need to retrain. You will also need to modify the library, adding the backbone that you want to solo/utils/backbones.py and add it as an option here: https://github.com/vturrisi/solo-learn/blob/d5ac12d3954184f79d93dee6f52b67da1408afd2/solo/methods/base.py#L69-L89
Note that backbone-specific parameters need to be passed to the model, modifying the code here: https://github.com/vturrisi/solo-learn/blob/d5ac12d3954184f79d93dee6f52b67da1408afd2/solo/methods/base.py#L285-L292
and in solo/args/utils.py and also parsing everything in the init of the base method class.

Thank you! I will try!


Inference error after fine-tuning the model

Hello, i have followed the distributed_train.py and finished training a florence base ft model. However, I tried to use it for inference. I hit error during model loading stage using the following code, same code used in training.
model = AutoModelForCausalLM.from_pretrained(fine_tuned_path, torch_dtype=torch_dtype, trust_remote_code=True).to("cuda:0")

The error is that following.
  File "/opt/conda/envs/myenv/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3832, in from_pretrained
    model = cls(config, *model_args, **model_kwargs)
  File "/home/ubuntu/.cache/huggingface/modules/transformers_modules/epoch_10/modeling_florence2.py", line 2535, in __init__
    assert config.vision_config.model_type == 'davit', 'only DaViT is supported for now'
AssertionError: only DaViT is supported for now

I looked at the checkpoints that are saved. Its architecture config.json is a different from the original downloaded config.json.
More importantly, I tried to modified the scripts modeling_florence2.py to remove the assertion check. However, it seems the code always try to look at the ./cache dir with /home/ubuntu/.cache/huggingface/modules/transformers_modules/epoch_10/modeling_florence2.py
Do you know what might happen? THX

Figured out. When we use trust_remote=True, we need modfiy the script path in the config.json to point to the local


C++ Coroutines / Async + TLS Session Ticket Callbacks

i'm exploring design strategies to implement datacenter wide single use TLS session resumption tickets (so that if a connection breaks and client get rerouted to a new application server process the connection can be resumed, chiefly to support 0-RTT data).
ticket generation is fine the callbacks can fall-through to a coroutine that asynchronously writes the ticket to the database. but on ticket validation, evaluating whether a ticket has been used on any other server process and thus revoked, this would require an asynchronous database read/delete-if inside the callback.
in theory this should be possible since the state for each connection is isolated/local to a SSL * object, but i figured i'd ask whether this would work before I go down the path of implementing it.
and if this design is a no-go, maybe there's some other API that can be exposed to accomplish this asynchronously?

Marking as inactive, to be closed when 3.4 dev cycle ends, barring further input

would still love feedback on this

@victorstewart ok, sorry, didn't think a two year old issue would still have someone paying attention to it.
to restate your request, If I read you right, you want to:

use the SSL_set_session_ticket_ext_cb to catch ticket extensions, and add their information to a shared database between disparate serving processes on your server
On connection to a given serving process, said process looks up the ticket in the database
If found, use the ticket info to rebuild the session from the old process and resume

I'm speaking a bit naively here, but, In principle, I don't see anything wrong with doing so, but I don't immediately see the api calls needed to rebuiild the session based on ticket info alone.  We have the ability to duplicate sessions that are resumeable, but they are internal and require access to the entire old SSL_SESSION data structure to duplicate the session for resumption, so this seems incumbent on having access to all the old data to accomplish that.
Its an interesting idea though.  Its feels like you would need some serialization method that would let you export the entire SSL_SESSION data and store it in the data base to rebulid the session cache on your distributed systems
Note, I'm migrating this to a discussion, since its not a specific bug.


Config setting should reset shared instance

Codecov Report

Merging #98 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
- Coverage    67.57%   67.52%   -0.05%
===========================================
  Files           51       51
  Lines         4086     4089       +3
===========================================
  Hits          2761     2761
- Misses        1325     1328       +3

Impacted Files
Coverage Δ

bitshares/instance.py
76.47% <0%> (-7.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b25e6d...8000864. Read the comment docs.


Enabling test-retry-gradle-plugin

The test-retry mechanism allows failed test cases to be automatically re-run. It also includes functionality to mark the build as "successful" if the tests pass on re-run, though we’re not focusing on that feature at this time. Our primary goal in enabling this mechanism for Develocity is to classify tests as deterministic or non-deterministic. This classification will provide developers with better insights into failed test cases and help them make more informed decisions.
Additionally, it saves time by automating the re-running of failed test cases, so developers don’t have to manually retry them.
 retry {
        maxRetries = 3
        maxFailures = 20
        failOnPassedAfterRetry = false
      }

I believe the retry-test functionality is already integrated into the Gradle Enterprise plugin, which our project is currently using. Therefore, we don't need to add an explicit plugin to enable this feature.
https://github.com/apache/solr/pull/2467#issuecomment-2122297638

Here is the link to Develocity where currently the retry mechanism is not enabled!
https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root

I'm not sure how this will affect random test execution (whether it's the same main seed the tests are executed with). You'd have to look into that.

Thanks @dweiss for pointing that out. To test that, I added below code to one of the test case.
public void testFailure() {
    if(random().nextBoolean()) {
      assertFalse(true);
    }
  }

retry {
        maxRetries = 20
        maxFailures = 20
        failOnPassedAfterRetry = false
      }

If the same seed wasn't used, or if there was no seed at all, any retry could set nextBoolean to false, causing the test to pass. However, I observed that once the test failed, it kept failing 20 times more and stop there because it couldn't go beyond that limit, as maxFailures was configured. I've also attached the test output where you can see the same seed repeating!
TEST-org.apache.solr.util.TestSolrVersion.txt

Ok, so it restarts with the same master seed. Good to know.

I expected to see the need to include a build plugin. I guess this is now built-in?

Yes this one does confused me in the start, as I removed the plugin declaration and retry was still working. Then I start looking into all the plugin in build.gradle one by one, hoping that it is coming with one of them. Ultimately, I discovered below dependencies in setting.gradle and explore it further to find out that the gradle enterprise does includes the 'test-retry' functionality as well.
plugins {
    id 'com.gradle.enterprise' version '3.15.1'
    id 'com.gradle.common-custom-user-data-gradle-plugin' version '1.12'
}

I asked the same question at the Github and got this answer.

@iamsanjay , as you figured out, the Develocity/Gradle Enterprise plugin bundles the retry plugin. If you are using it, then I'd recommend to remove the explicit dependency on the retry plugin. The extensions configured and their functionality are equivalent

https://github.com/gradle/gradle/blob/6586eb029f216bf8acfbea7bcfcb7cde8518a689/build-logic-commons/gradle-plugin/build.gradle.kts#L29

One test case failed!
ERROR: The following test(s) have failed:
  - org.apache.solr.search.TestStressReorder.testStressReorderVersions (:solr:core)
    Test history: https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.search.TestStressReorder&tests.test=testStressReorderVersions http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.search.TestStressReorder.testStressReorderVersions
    Test output: /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.search.TestStressReorder.txt
    Reproduce with: ./gradlew :solr:core:test --tests "org.apache.solr.search.TestStressReorder.testStressReorderVersions" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=576E4BEF513F4B02 -Ptests.timeoutSuite=600000! -Ptests.file.encoding=ISO-8859-1

It failed once before as well!

I have another question regarding failOnPassedAfterRetry. Right now, it’s set to false, meaning the build passes if failed test cases succeed on retry. However, that’s not what I intended—I actually want the build to fail in such cases. I’m not planning to enable this just yet. So I disabled it.

Few more changes!

Updated API: Changed retry to develocity.testRetry due to deprecation.
Separated Configuration: Moved the retry configuration to a separate file for better organization.

https://ge.apache.org/s/qcptlo6laqo5g#info
The build scan above is associated with branch_9_7, and the retry logic seems to have been introduced shortly after the branch cut-off.

Ah; thanks Sanjay!


fix inconsistent Tenant member name in DeliveryService struct

What does this PR do?
Fixes #(issue_number)
Which TC components are affected by this PR?

[ ] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[x] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] Other _________

What is the best way to verify this PR?
compile traffic_ops_golang, traffic_monitor, traffic_stats.  Run go unit tests in each.
Check all that apply

[ ] This PR includes tests
[ ] This PR includes documentation updates
[ ] This PR includes an update to CHANGELOG.md
[ ] This PR includes all required license headers
[ ] This PR includes a database migration (ensure that migration sequence is correct)
[ ] This PR fixes a serious security flaw. Read more: www.apache.org/security

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2505/
Test PASSed.


Add JavaScript Relay example

Simple JavaScript app that uses Waku Relay.
Could be subject for a new guide (we don't have a pure JS guide at the moment).

bors merge


feat(curriculum): adding hotel feedback form workshop

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Hope you don't mind @jdwilkin4, I went ahead and fixed the conflicts here since I had this checked out 👍


Sign Up Page

@nobledeveloper01 Thank you for contributing. Your PR has been reviewed and it's great!


1.19 Registry sync issue on login when not present on client

This is probably a fabric api issue but I am creating this for tracking purposes

yeah, solution for now is probably just lazy registering the command arguments with the registry only if they're used in a command
long term, I'm planning to move the platform to build against quilt, where colonel has become a fully supported part of the QSL commands api


Nullable PK columns now result in non-nullable PK properties.

Fix for #243. This fix coerces the generated S-side property (and thus the generated C-side property as well) to be non-nullable if the underlying column was nullable but was also marked as part of the primary key. This helps when reverse engineering some Views on Oracle where they can report nullable primary keys.
Notes: I tried coercing just the C-side property, but Model Validation checks S-side properties as well - so it would not have solved the customer's issue.
For tests: Where possible I updated the test so that it would just do the same thing as before; sometimes that required more constrained input data. Note: changing the nullability of columns can change how we calculate the multiplicity of the association ends.  In one case I had to split the existing test into 2 separate tests: PK-to-PK and PK-to-FK associations. Previously only PK-to-PK association was checked - some of the scenarios it checked are no longer possible. So I removed those but added the new PK-to-FK test (I checked that the new test would have gotten the same results before this change).

Checked in with commit 2a8432fb3 (release-6.2.0-beta1).


Added remain Maven API, update test

Azure DevOps java sdk pull request template guide
Thank you for your interest in contributing to this project.
Description
I implemented the remaining maven api. (Excluding download). Test was implemented for all cases, and the entire test function was also written.
PR Checklist

[x] Added help
[x] Added unit test/s
[x] Updated Change log

@shblue21 no luck mate. Worth updating the tests once and then give it a try.

@hkarthik7 First of all, sorry for generating a lot of release pipeline logs.
I modified the test code and created an example document.
Please let me know if you need to edit the test. (Delete sysout, etc.)

And I can't implement DownloadPackage right away. Because

@shblue21 The download functionality has to be tested intensely before applying. We should think a way to introduce this without affecting the core functionality of SDK. After all we've built this for our use and can come up with a way that works for everyone. Since few projects depends on the SDK for Azure DevOps integration I would recommend to add the download package functionality later.
You can write an exact API wrapper for downloadPackage and create a helper method that calls downloadPackage to actually download the contents in a .zip or any format that makes sense.
Description from documentation  -
Fulfills Maven package file download requests by either returning the URL of the requested package file or, in the case of Azure DevOps Server (OnPrem), returning the content as a stream.
I did a quick test from Postman and the response was a stream content.
So, you can create a method downlodPackage that returns file stream. Then create a helper method something like downloadPackageContent and ask the user to choose the file format. It can be a text, json, .md, .zip etc, because it expected that user should be aware of file format they're requesting for. An example logic shown here

Happy to do a squash merge.

Thanks for merging!

@shblue21, I've modified the downloadPackage method in MavenApi. Please take a look and test it, if the implementation is not what you're looking for or you didn't like please feel free to modify it.

@hkarthik7   mate. I'll check right away. thank you very much.

@hkarthik7  It seems to be working fine.

@hkarthik7 I want to implement uploadPackage.
The request url has the following format:
PUT pkgs.dev.azure.com/{account}/{org}/_packaging/{feed}/maven/v1/{artifactid}/{groupid}/{version}/{filename}
But the corresponding url for API_RELATIVE_PATH is _packaging .
Is there any way to implement this by changing API_RELATIVE_PATH ?
public final class RestClientProvider extends BaseRestClient {
    protected static final JsonMapper MAPPER = new JsonMapper();
    private static final String API_RELATIVE_PATH = "_apis";

@shblue21, please implement what makes sense to you. I don’t recommend modifying the existing relative path property as it will change the entire functionality of the library. You can do something like creating a string build to construct the url and call RestClient.send() that demands a request url.


Do not slugify single quotation mark in filenames

What is the purpose of your issue?

[ ] Bug
[ ] Feature Request
[ ] Question
[x] Other

Description
In Windows; <>:"/\|?* characters are forbidden in filenames. This doesn't include single quotation marks ('). So, we should probably add ' to ignored characters when calling slugify for generating filenames.

Closed by #357.


iOS Support and acr1255u

I am trying to use the package but I have some question:
1- Does it support iOS?
2- Is there a way to use it with acr1255u? and is there documentation?
https://www.acs.com.hk/en/products/528/acr1255u-j1-acs-secure-bluetooth®-nfc-reader-software-development-kit/

Hello,
Actually it is just using TCP connection so it may not fit for your needs
Regards,
On Sun, Aug 9, 2020, 6:51 AM Ebram Tawfik<EMAIL_ADDRESS>wrote:

I am trying to use the package but I have some question:
1- Does it support iOS?
2- Is there a way to use it with acr1255u? and is there documentation?
https://www.acs.com.hk/en/products/528/acr1255u-j1-acs-secure-bluetooth®-nfc-reader-software-development-kit/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/amorenew/ACS_NFC_Flutter/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVV6W4KE7HBTCWQEXIEJZLR7YTMTANCNFSM4PY77OIA
.

I'm also interested in connection with ACR 1255u-J1 device with Bluetooth , any update ?

I am trying to use the package but I have some question:
1- Does it support iOS?
2- Is there a way to use it with acr1255u? and is there documentation?
https://www.acs.com.hk/en/products/528/acr1255u-j1-acs-secure-bluetooth®-nfc-reader-software-development-kit/

did you make it work ? regards

@Mobiwoom I don't have the same model but you could use my plugin as a guideline to build based on your own hardware.


Exclude implicit dependencies on HTTP clients?

By default, the software.amazon.awssdk:s3 dependency pulls in both software.amazon.awssdk:apache-client and software.amazon.awssdk:netty-nio-client. Based on an (admittedly quick) browse of the code, it looks like this project uses the CRT client for async, and doesn't particularly care about which client to use for synchronous usage.
Does it make sense to do either of the following?

Add exclusions for software.amazon.awssdk:apache-client and software.amazon.awssdk:netty-nio-client (both of which are simply large at best, and create version contention at worst), and add an import and code for software.amazon.awssdk:url-connection-client (which is tiny, only 32K) for synchronous usage.
Add tests to confirm that software.amazon.awssdk:apache-client and software.amazon.awssdk:netty-nio-client are not needed; add instructions in the docs to inform users that it is safe to exclude software.amazon.awssdk:apache-client and software.amazon.awssdk:netty-nio-client if they desire, and how to do so; and add instructions in the docs to use software.amazon.awssdk:url-connection-client for synchronous requests, and how to do so.

I'm happy to take a swing at either of the above if they make sense.

Apologies for not seeing this sooner. I think it is a reasonable suggestion.

@sigpwned

I'm happy to take a swing at either of the above if they make sense.

I'm wondering if you (or someone else) is still interested in trying this out?


I need a full list of config property options

I'm looking for a full list of the properties that can be used for config.properties or session-property-config.properties.
In fact, I'm currently looking for the guide to session-property-config.properties. The official manual page only made me confused about the naming format (should I replace every dot (.) and dash (-) to underscore (_)? ) with the lack of the list of property options that I can use.
So I first decided to find the full list of properties. I already knew this manual, but it seems it does not contain some properties like query.max-run-time or query.max-execution-time which can be found at the code or the document of the session property config.
So.. where are they? Any information?

@byungnam Probably the best place is to get possible config options for config.properties is to check server.log.
Config options are printed at startup (name, default value, configured value, optional description).
Note that some config options are dependent on other configs (e.g. you can configure Kerberos principal only when you enable Kerberos).
Dependent config options will not be printed in server.log.
For session property config options, take a look at SystemSessionProperties. This lists all engine-provided session properties.
Connectors can provide session properties that are catalog-specific. Do you need them too?
I invite you to join our Slack (https://prestosql.io/community.html)
Slack is a better place to ask this type of questions and often much faster.
See you there!


 :/
Releases
On every tagged release, it should:

Build and tag both amd64 and armv7 images with new versions. Eg. getumbrel/middleware:x64-0.1.0 and getumbrel/middleware:armv7-0.1.0.
Push these to middleware's docker hub repo.
Create a new docker manifest file and annotate the new version tag with both architectures' builds. Eg. getumbrel/middleware:v0.1.0.
Push this docker manifest file to middleware's docker hub repo.
Create another docker manifest file with :latest tag and annotate both architecture builds (requires --amend option). Eg. getumbrel/middleware:latest.
Push this docker manifest file to middleware's docker hub repo.

Merges
For faster development and testing, there should be an always up-to-date image with the master branch's code. So on every merge with the master branch, it should:

Build and tag both amd64 and armv7 images with "master" tag. Eg. getumbrel/middleware:x64-master and getumbrel/middleware:armv7-master.
Push these to middleware's docker hub repo.
Create a docker manifest file and annotate both architectures' builds. Eg. getumbrel/middleware:master (requires --amend option).

For the new middleware v0.0.5 containers, I used docker buildx (an experimental feature, so edit docker's config.json file and set experimental to true) and it just worked really well out of the box!
amd64 Build
docker buildx build -t getumbrel/middleware:x64-0.0.5 --platform linux/amd64 .

armv7 Build
docker buildx build -t getumbrel/middleware:armv7-0.0.5 --platform linux/arm/v7 .

LGTM.
We have to use that setting for manifests anyway..

Yeah, and manifests can themselves be handled by buildx too. This is from their website, but I haven't tried it yet:

Buildx also supports new features that are not yet available for regular docker build like building manifest lists

All done. See PR comments.


ProtonVPN

Hi, is ProtonVPN compatible ? if yes, do i have to replace "nordvpn" by "protonvpn" in the yaml or not necessary ? There is more to do ?

additional question : what is this port 51420 ? what's his function ?

Hello @Fudo7sei
Yes, it is possible to use Proton VPN in this tutorial. I use gluetun which manages a large number of VPN providers. (Link to all available VPNs)
To use Proton VPN, you must indeed change the .yaml file.
Here is an example:
  gluetun:
    image: qmcgaw/gluetun
    ports:
      - 8080:8080
      - 51420:51420
      - 51420:51420/udp
    cap_add:
      - NET_ADMIN
    environment:
      - VPN_SERVICE_PROVIDER=protonvpn
      - OPENVPN_USER=username
      - OPENVPN_PASSWORD=password
      - SERVER_COUNTRIES=Netherlands

You will find all other optional parameters on this link
As for your second question, port 51420 is the port that allows qbitorrents to access the internet to download, but the port is open on gluetun because it first passes through the VPN.

 I'm glad I could help clarify things for you. If you have any more questions or need further assistance, feel free to ask. I hope you will enjoy it!

Hello,
Yes, it is possible to use a Jellyfin that is already installed locally on your machine. To install without Jellyfin, you just need to remove the Jellyfin part from the .yaml file:
jellyfin:
	image:  lscr.io/linuxserver/jellyfin:latest
	container_name:  jellyfin
	environment:
		-  PUID=0
		-  PGID=0
		-  TZ=${TZ}
		-  NVIDIA_VISIBLE_DEVICES=all
	ports:
		-  8096:8096
		-  8920:8920
		-  7359:7359/udp
		-  1900:1900/udp
	volumes:
		- ${COMMON_PATH}:${COMMON_PATH}
		- ${COMMON_PATH}/configs/jellyfin:/config
		- ${COMMON_PATH}/jellyfin/cache:/cache
		- ${COMMON_PATH}/sonarr/tv:/data/tvshows
		- ${COMMON_PATH}/radarr/movies:/data/movies
		- ${COMMON_PATH}/qbittorrent/downloads:/data/media_downloads
	restart:  unless-stopped

However, you will need to make sure to create the necessary folders for movies and TV series, and you will also need to give your Jellyfin access to your movies and/or TV series.
Afterwards, it might be simpler to use the complete solution.

Ok thanks that's what i thought

well, the gluetun container is not starting :/


GitHub Security Alerts

https://github.com/blog/2470-introducing-security-alerts-on-github
Can we make use of this somehow?
@grahamc ? :D

I don't think so.

The dependency graph and security alerts currently support Javascript and Ruby—with Python support coming in 2018.


Peer snapshot documentation

Overview of process, limitation, and sample commands
Change-Id: Icd376dfac116e8ea1463f2bdfc50ca2970a4ed1d
Signed-off-by: joe-alewine<EMAIL_ADDRESS>Type of change

Documentation update

@manish-sethi Are you suggesting that these two bullets should be actually one bullet? Are they contained in the same file?

@manish-sethi Are you suggesting that these two bullets should be actually one bullet? Are they contained in the same file?

No, what I was suggesting was to add an introduction line for the second bullet as you have for the first bullet.

This looks like a great first pass. I think we could merge after Joe's next push.  Then take a step back and consider if we need to add anything else.


chore: bump version 5.2.0

@matthewelwell Nice! Looking forward trying this version :)

@JFCote the new version has been deployed at: https://www.nuget.org/packages/Flagsmith/5.2.0 (although this might not be visible to you yet while it's propagating to the nuget CDN).
I know you mentioned you wanted to contribute more to the Flagsmith project, would you be willing to add some documentation for the caching that you added. We have some docs for the other libraries here that you can follow. The docs are included in the main flagsmith repository here.
Let me know if you think you'll be able to do that, otherwise I will add it to my backlog :)


[BUGFIX] fix dataset names for distilbert

Signed-off-by: Sheng Zha<EMAIL_ADDRESS>Description
fix dataset names for distilbert
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[x] fix dataset name for distilbert

Comments

reported in #1549

cc @dmlc/gluon-nlp-team

It looks like there are some issues in mxnet-1.8.0.post0. CI will work well with mxnet-1.7.0.post2 before, so I will create a quick workaround to fix mxnet version to mxnet-1.7.0.post2.


Migrate to Catch2 version 3.x

Now that we compile Newsboat in C++14 mode (#2692, #2694), we can finally update our testing framework from 2.x to 3.x. The main benefit (as far as I understand) is faster compilation, because the framework is no longer a header-only library.
The framework's repository is at: https://github.com/catchorg/Catch2
This will require some very light changes to our Makefile, and probably won't require any changes to the tests at all, so feel free to try your hand at this even if you've never looked at Newsboat's code.

I would like to work on this if possible!

Sure, have at it! If it turns out too hard, please write down here the problems you ran into, so we have a better picture and can decide how to proceed.


Need to explicitly specify location of python installation for cron job

The GCN cron job script (#432) runs well, although I'm finding that the location of my computer's python installation must be explicitly specified to avoid error messages. By replacing python gcn_cronjob.py with ~/miniforge3/envs/scope-env/bin/python gcn_cronjob.py when setting up the cron job (and removing #!/usr/bin/env python from line 1 of gcn_cronjob.py), I can avoid env: python: No such file or directory errors.
I'm interested in finding a way to make the cron environment more 'aware' of the python command.

@mcoughlin That could be, I'll check it out.


Output breaks when backslashes and quotation marks are contained in the result

Describe the bug
When the result of the execution of a line or a code block contains a bad constellation of \ and ", the there is no output und an error in the sniprun.log appears.
I found the example print("\\\"") in python 3.9. The expected output would be \". In the python terminal it works. Same for R (e.g. cat("\\\"")).
Sniprun don't print anything (I tested classic, virtualtext and terminal). The logoutput for the example shows this:

[00:00:00.156] (7f8e703b3640) INFO   message '\"' cleaned out
[00:00:00.157] (7f8e703b3640) INFO   done displaying virtual text, Err(NeovimError(0, "Vim(lua):E5107: Error loading lua [string ":lua"]:1: ')' expected near '","'"))

What do the bug concerns? Sniprun itself, a particular interpreter?
I tracked the problem down to the cleanup_and_escape function in display.rs
https://github.com/michaelb/sniprun/blob/545aa90da4fba677e4be0524fc718c1d029521de/src/display.rs#L330-L333
The first replace statement adds a second backslash ("\\""), the second removes it ("\"") and the last one escapes all quotes (\"\\"\"). This is than pasted to the lua command for printing, but the resulting command is not sane.
To Reproduce
Steps to reproduce the behavior:

Open an file in a language with sniprun support
add a line with a print statement, that contains "\\\"" for example in python print("\\\"")
run SnipRun
See error at the end of the log (~/.cache/sniprun/sniprun.log)

Expected behavior
Output of \".
Environment:

NVIM v0.6.0
OS: Linux thinkpad 5.15.6-arch2-1
rustc 1.57.0
LuaJIT 2.0.5
ldd (GNU libc) 2.33
Sniprun 1.0.5, (also tested the current master)

Additional context
My first intuition was to switch the first and the second replace statement. Sniprun is then able to print something, but the result is wrong. For the example print("\\\"") results in ".

Thanks for reporting.
It's true I didn't think through this, i'll try to make a proper fix soon

#122  fixes this

I tested it and yes it works. Thank you very much.
But (sorry) code block or prints with \n are not working in the terminal disply any more.
I wrote a terminal variant in this PR #123 and I also put a small fix to this in it. (Just a replace("\n", "\\n") locally in the display_terminal function.) Hope this is ok?

Nice catch also, I've missed that one! (since I my test config is also my work config, I don't always test all the features to check everything)
I should have no reason to refuse #123 , and while it's mixing up a bit the issues/fixes, I think it's alright as-is.


Update log-eip.adoc

Typo in Level Leven -> Level
Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

Can you please tell me which one is the active branch? Then I will make a change on another PR

main, 3.x, 3.20.x, 3.18.x, 3.14.x


Unable to run apt-get update

In a new / fresh AWS ec2 instance (ubuntu) I'm getting this error when trying to install EE.
EasyEngine (ee) installed successfully
EasyEngine (ee) help: http://docs.rtcamp.com/easyengine/
ubuntu@ip-172-31-32-127:~# sudo ee stack install
Adding repository for MySQL, please wait...
Adding repository for NGINX, please wait...
Adding repository for PHP, please wait...
Adding repository for HHVM, please wait...
Updating apt-cache, please wait...
Unable to run apt-get update

@QROkes
Run following command and give us output
sudo apt-get update

I'm getting this error at the end:
.....
.......
 Done
W: GPG error: http://dl.hhvm.com trusty InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5A16E7281BE7A449
W: GPG error: http://mirror.aarnet.edu.au trusty InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY CBCB082A1BB943DB
ubuntu@ip-172-31-46-223:~$

Hello @QROkes ,
We are working on this and similar types on issue, #470, . We will fix this issue soon with new EasyEngine release. Until then fix for you is run following commands:
sudo apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 0x5a16e7281be7a449
sudo apt-get update

Duplicate of #470
All future discuss should be on #470


Escaped pipes are ignored within table cells

Hi :wave: :smile:
I am running into this issue in Storybook, which uses markdown-to-jsx for markdown parsing: https://github.com/storybookjs/storybook/issues/6869
Could not find any issues here regarding this, so reporting it. Would it be possible to fix this? Thanks in advance for any help!

Yeah, open to PRs 👍

Looking deeper into this, I see the same output when parsing a table with escaped pipe characters with react-native-simple-markdown as well. And both seem to be built on top of simple-markdown. Will close this for now, and report there.

Reopened - this library has diverged a lot from simple-markdown so good to fix this separately.

Reopened - this library has diverged a lot from simple-markdown so good to fix this separately.

@probablyup Ok, thanks. I tried to look into the code, but was not able to get the full picture. Would you be able to point me to any logic involved for this specific case, or hints on how you would go about making a fix for this?
Here is the new issue I created, which also mentions my crude test repo I've been playing with to solve this: https://github.com/robaxelsen/markdown-to-jsx-table-pipe-test

I think probably here: https://github.com/probablyup/markdown-to-jsx/blob/master/index.js#L162
Checking and rejecting pipes that have an escape

I think probably here: https://github.com/probablyup/markdown-to-jsx/blob/master/index.js#L162
Checking and rejecting pipes that have an escape

@probablyup Thanks! I did some testing, and seems that line is used to match any line that is part of a table markdown.
This one seems promising though, as it's used throughout the code to split the row into cells, if I am reading the code correctly: https://github.com/probablyup/markdown-to-jsx/blob/5d4470314de8d652435e581851e4e8e2ef78a6c0/index.js#L174
Tried replacing it with regex that should ignore the newline, but having issues. Have any ideas?
Posted a relevant stackoverflow question here, which might help shed some more light on this: https://stackoverflow.com/questions/57306043/splitting-complex-string-with-while-ignoring-escaped-delimeter

In simple-markdown I was able to fix this by actually parsing each row, rather than using String.prototype.split. The patch is here: https://github.com/Khan/simple-markdown/commit/f32a628401745787a2a199a5d3bde1efced4d6d5 , and I might try to see how hard it would be to do the same thing here.


Add support for Symfony 5 and dropped support for Symfony 3

Hi

I think this line should be removed since FilesystemOrphanageStorage constructor have only 4 arguments.

Thank you guys for contributing, reviewing and participating in this PR! 🎉


Docs: Updated Lucid Link support instructions

Description
Lucid link released v3 which change the file structure of getting cloud spaces and has no direct way of doing so now. They still offer the v2.8 which works and is now linked to
Motivation and Context
Less confusion on why it isn't working
Screenshots (if appropriate):

Can you resolve the merge conflict?


OAuth

I've written about what's OAuth and what is it used for.
Demonstrated Sign in with Google using OAuth

@rishitha24 This is some quality content. Thank you for your generous work. :heart:

Next thing that you should do is showcase this PR on microbyte-showcase channel.
Kindly follow the below mentioned format for ur msg @Anjalikamath -
All creators who have their PRs accepted and merged can show off their contribution in the microbyte-showcase channel. This will help the other participants by keeping them updated. Also, kindly refrain from spamming the channel with every minor contribution you may make. Please give a brief compiled overview of your contribution.
Template (Kindly stick to this format):
Title of your project #(repo-topic)
A brief overview of your project (not more than 3-5 lines). GITHUB LINK of byte must be provided. In the end of this briefing use #(languages), #(software), #(skills) tags.
Actively looking for contributors (both learners and creators). Please raise an issue first and then submit your PRs to that issue only (either after or before assigning the issue to you). Also, you can suggest how they can contribute.
Template example:
Concurrency #OS
Brief description. [GITHUB LINK]. #C++ #Python #Shell #Django
Actively looking for contributors. Learners can to this _ and creators can do this __. Please raise an issue first and then submit your PRs to that issue only.
#learnbydoing #microbyte-showcase
Needless to say keep contributing!!

@all-contributors kindly add @rishitha24  for code doc ideas content


Update CoC to reflect current official CoC location.

Changes from referencing CoC in TSC repo to CoC in Admin repo.

I believe this should also close out https://github.com/nodejs/community-committee/issues/34 if merged.

does this need to go through the board or can this be merged?

It can just be merge

merging!


ADC v1.2 Schema Management

Issue to track our schema management.
Changes to keep an ADC release in sync with an AIRR version release.

info.version = 1.2.0
Any AIRR spec objects need to link to a tagged version

repertoire_list
rearrangement_extension
clone_extension
cell_extension
expression_list

adc-api.yaml and adc-api-openapi3.yaml will need to be tagged with v1.2 and link to AIRR v1.4 tags in the above objects in these files.

Resolves Point 5 in #579 - schema change management.

This relies on the AIRR v1.4.0 milestone being completed and tagged with a release.

Since we can only have one milestone attached, we really want this attached to the v1.4 milestone. We need the v1.4 tag so we can create the API spec using that tag.

This is done, ready to tag as ADC v1.2.0 - tag to v1.4.1 spec completed, confirmed in Swagger editor that links to v1.4.1 are working.

This is done - See #643


Zero copy central directory parsing

See https://github.com/mvdnes/zip-rs/pull/91

Continues https://github.com/jhg/zip-rs/pull/7


WIP: More VMS assembler build fixes

VMS build: in descrip.mms.tmpl's src2obj, do .S -> .asm too
We only convert lowercase .s to .asm, that turned out not to be sufficient.

VMS build: don't forget the generation marker when removing files

Merged.
master:
f19d20b60fcdfde802f96afa3796f20d0da25eab VMS build: don't forget the generation marker when removing files
c739e676ebc6e7f66aabee1ac3d2040b3103a890 VMS build: in descrip.mms.tmpl's src2obj, do .S -> .asm too
1.1.1:
156c4d6290fddb2379c13870e19a1a8ef0b0f095 VMS build: don't forget the generation marker when removing files
316fe11b0a0a6a3c7e3ff72129f09f3ef01bab07 VMS build: in descrip.mms.tmpl's src2obj, do .S -> .asm too

Bah, this turned out to be wrong.  Correcting PR coming up


Adding RHEL 9 to system requirements for 3.15

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, @tigeraphil. I'll hold on to this until we can confirm support.

@sujeet-kr Can you confirm we're happy to add support for RHEL 9 in CE 3.15?