Add PCAP recognition

Match first four bytes to detect pcap files

Maybe we should also add support for handling pcapng files?

Hi!
@nazywam, it looks fine
@chivay,
file command on pcapng prints: pcap-ng capture file - version 1.0
So yes, I'll renew this merge request right now, stay tuned)

It seems that you're using an old version of libmagic. In my case the output for pcapng has  the following output: pcapng capture file - is seems that the change was made around 2019.
Please us this value in your patch.
We know that it's suboptimal to rely on values that aren't stable between environments. To alleviate this problem we'd like to stop depending on system-installed version of libmagic database and ship another one with the classifier. You can track this issue here: #26.

We know that it's suboptimal to rely on values that aren't stable between environments. To alleviate this problem we'd like to stop depending on system-installed version of libmagic database and ship another one with the classifier. You can track this issue here: #26.

Fmm, for current case with pcapng there is a solution, i'll make a new commit...

Also probably you should allow karton-yaramatcher to proceed unrecognized files with further changing status as "recognized" if there is any rule that has meta field "extension" and match this file. It will help to recognize some filetypes without changing code of karton-classifier. Or just add yara to karton-classifier and allow user to write rules that will be used as last resolve to detect file type :)

I would like to see this change, it's very useful thing BUT it changes the file processing pipeline, this way it need to be discussed with karton developers.

Thank you. Please look at other issues in karton-core.

Unmerged commits...

Only those with write access to this repository can merge pull requests.

Understood :)

Thanks!


#3696376: Update all Configurations

Closes #3696376
Test Plan
tests performed
Tested (almost) all the configurations and they seem to work fine.
Please, review the changes on Chromatic and ensure all of them make sense

One minor thing: can you export the new icons from createBentoComponents?

Is there a reason why we're explicitly listing all the Icons/Illustrations we want to return from createBentoComponents instead of importing * as icons from "./icons" and re-exporting it?


Add system.sync_partition_metadata procedure to sync Hive table partitions

Fix #174

How about adding smoke test like system.create_empty_partition or product test?
https://github.com/prestosql/presto/blob/095ceaf9ef67ac1f42d2c9c9eb1bfb15ae27f86b/presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java#L976-L992

How about adding smoke test like system.create_empty_partition or product test?
presto/presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
Lines 976 to 992 in 095ceaf
public void testCreateEmptyNonBucketedPartition()
{
String tableName = "test_insert_empty_partitioned_unbucketed_table";
assertUpdate("" +
"CREATE TABLE " + tableName + " (" +
"  dummy_col bigint," +
"  part varchar)" +
"WITH (" +
"  format = 'ORC', " +
"  partitioned_by = ARRAY[ 'part' ] " +
")");
assertQuery(format("SELECT count(*) FROM "%s$partitions"", tableName), "SELECT 0");
 // create an empty partition
 assertUpdate(format("CALL system.create_empty_partition('%s', '%s', ARRAY['part'], ARRAY['%s'])", TPCH_SCHEMA, tableName, "empty"));
 assertQuery(format("SELECT count(*) FROM \"%s$partitions\"", tableName), "SELECT 1");
 assertUpdate("DROP TABLE " + tableName);

I initially had very comprehensive unit tests in TestHiveIntegrationSmokeTest. But then I realize those tests doesn't make sense because the way FileHiveMetastore::getPartitionNames works is that it scans the directory and return all partitions in file system.
product tests might be possible. I need some time to figure out how to add one. Do you know a good example that I can start with?

I think TestHivePartitionsTable.java
 would be helpful. You can execute hive query using onHive().executeQuery("~~~"); if needed.

I think TestHivePartitionsTable.java  would be helpful. You can execute hive query using onHive().executeQuery("~~~"); if needed.

Thanks! I added a product test for msck procedure.

I have seen random failures in the travis-ci test due to ClassNotFound exception:

Socket Factory class not found: java.lang.ClassNotFoundException: Class org.apache.hadoop.net.SocksSocketFactory not found

After long traiging, I seem to find the fix to the issue, as shown in  8976e1e.
Honestly I don't understand the exact reason why this is happening if I have the metastore.commit() outside the try-catch block. I know Hadoop code likes to load classes at random times, but not sure if that's the cause here. My hunch is that for some reason mess up the class loader when going out the block. And when it calls getFilesystem() inside metastore.commit(), Hadoop will complains about ClassNotFound. The sympton I have seen is that after calling the hive procedure, the CALL query and all subsequent queries will fail(I have tested CREATE TABLE, SELECT and they all fail), which indicates permernant damage.
Would love to hear what you guys think about this issue, and what's the right way to fix it.
@dain @electrum @findepi

@luohao thanks for delivering this. This is really a useful feature!

HI all,
CALL system.create_empty_partition works fine on my Presto (node_version 0.227), however
CALL system.sync_partition_metadata raises this error:
FAILED  [CALL - 0 rows, 0.223 secs]  [Code: 29, SQL State: ]  Query failed (#20200930_101605_13561_nycb9): Procedure not registered: system.sync_partition_metadata
Does anyone know about this problem? Thx !

@rherasm The procedure was added in version 304. Please upgrade your Presto cluster.
https://prestosql.io/download.html


Use alembic with sqlalchemy-aurora-data-api

Hey!
Is it possible to use alembic migration with this tool? I have an Aurora serverless cluster with generated secret, but serverless clusters are not public. It would be a huge step to migrate my db using alembic and data api.
Thanks, Tamas

Hey @tomeszmh - I was able to get alembic working, below are the steps I followed.
Currently I manage the revisions/migrations from my local machine. This assumes your machine is configured with the proper aws credentials. My goal is to get this into an automated CI/CD pipeline but haven't had an opportunity to tackle that yet.

Install & initialize alembic

pip install alembic
alembic init alembic

Update alembic.ini and set sqlalchemy.url to the correct connection string (e.g. sqlalchemy.url = postgresql+auroradataapi://:@/DATABASE)
env.py, update run_migrations_online to set connectable with create_engine instead of engine_from_config

def run_migrations_online() -> None:
    ...
    connectable = create_engine(f"postgresql+auroradataapi://:@/DATABASE", echo=True,
                                connect_args=dict(aurora_cluster_arn=os.environ.get("AURORA_CLUSTER_ARN"), secret_arn=os.environ.get("SECRET_ARN")))
    ...

When running revision or upgrade I pass environment variables of the  aurora_cluster_arn and secret_arn

AURORA_CLUSTER_ARN=XXX SECRET_ARN=XXX .env/bin/alembic revision -m "First commit" --autogenerate
AURORA_CLUSTER_ARN=XXX SECRET_ARN=XXX .env/bin/alembic upgrade head


Run functional tests when environment is built at start of day

The SBAT master-dev cluster is rebuilt everyday, after the cluster is built we would like to know that it is functioning correctly.
Run the SBAT functional tests codefresh pipeline after the initialise-cluster pipeline.
Add a notification mechanism to the functional tests pipeline so that a notification is sent if the tests fail.

Hey team! Please add your planning poker estimate with Zenhub @BohoCode @dbadham-fr @mariantiris @frlaura-jianu

The functional test pipeline has a step which will send a slack notification if the functional tests fail and  pipeline variable NOTIFY_SLACK == 'true'. By default, the NOTIFY_SLACK variable is set to false for the pipeline, this is to reduce spam when people are manually running the tests.
The initialise-cluster pipeline will call the functional test pipeline as its final step, with the notifications enabled.


Wrong VID and PID while reading from Arducam OV2640 model

Hi,
I bought an Arducam module OV2640 and trying to interface with a SAM MCU (Atmel).
The connections are proper and able to get the module to respond to write. I am writing 0x01 to the address 0xFF.
Now when I try to read the VID and PID the number is not matching the expected value. I am expecting it to be vid = 0x26 and pid = 0x41 or pid = 0x42.
The value I am getting is  vid = 0x43 and pid = 0x04, always. Verified using Saleae Logic tool.
Somebody who faced a similar issue here says it could be "The issue was that the ArduCAM was not configured correctly" - Could you please help me on this?
regards,
Sundar

@sundarakumarr
Hi,
Your I2C bus exist error,you should check it firstly.


Need option to handle flagsmith init with invalid or bad token

while going through and validating some operational scenarios in our application I've found that I can't pass an invalid token to flagsmith.init and have a way to gracefully recover.

for example:
flagsmith.init({
  api: flagsmith_url,
  environmentID: 'BAD_TOKEN'
  defaultFlags,
  onChange,
})

I would expect this to initialize flagsmith with the contents of defaultFlags and be disconnected from the api server.
Also within this testing I checked having api: 'http://badurl' at which point flagsmith would load defaultFlags and continue.

Hey,
Is it that you'd want an onChange to trigger in this scenario? Having tried the following out the SDK logs out the defaultFlags
flagsmith.init({
    environmentID: "badID",
    defaultFlags: {
        font_size: { value: 10 }
    },
})
console.log(flagsmith.getValue("font_size")) // logs 10

Interesting, let me dig a little deeper,  I've run a test with flagsmith.init({api: "badurl"}) and it did what I expected but with the "badID" everything hung up and wouldn't continue.

Closing as stale


"Malformed UTF-8 characters, possibly incorrectly encoded" with uuid relations

I have some hard times with uuid relations and json representation.
My work model has two foreign keys (user_id and workstation_id) in binary format.
My user model has a hasMany relationship with the work model.
My controller looks like :
public function show($uuid)
{
    $user = User::withUuid($uuid)
        ->with('profile')
        ->with('works')
        ->first();

    if (! $user) {
        abort(404);
    }

    return compact('user');
}

It throw the error mentionned in the title.
But it works well with tinker :
$user = User::withUuid('2094a25a-efde-11e7-8005-f156302fb27e')->with('profile')->with('works')->paginate(10)->first();
[!] Aliasing 'User' to 'App\User' for this Tinker session.
=> App\User {#795
     id: b"\x11çïÞ ”¢Z€\x05ñV0/²~",
     username: "amber.pagac",
     email<EMAIL_ADDRESS>     firstname: "Kip",
     lastname: "Lindgren",
     group: "e",
     profile_id: 1,
     login_count: 0,
     created_at: "2018-01-02 16:58:16",
     updated_at: "2018-01-02 16:58:16",
     deleted_at: null,
     profile: App\Profile {#808
       id: 1,
       name: "neque",
       description: "Aut mollitia quis amet necessitatibus aliquid consequatur. Cum eum a voluptas incidunt iusto magnam quasi. Quia quis maiores sit ut omnis dolor. Quis doloremque aut totam unde hic sed sunt.",
       created_at: "2018-01-02 16:58:16",
       updated_at: "2018-01-02 16:58:16",
       deleted_at: null,
     },
     works: Illuminate\Database\Eloquent\Collection {#807
       all: [
         App\Work {#805
           id: b"\x11çðg‰EC*–…]`¯!\x11w",
           user_id: b"\x11çïÞ ”¢Z€\x05ñV0/²~",
           workstation_id: b"\x11çïÞ l\x15ˆ©'!¨ÅKÁ‹",
           started_at: "2017-12-12 10:24:41",
           ended_at: "2017-12-12 11:05:37",
           grade_id: 2,
         },
         App\Work {#802
           id: b"\x11þgë\DlØ╣ëª¡║:\x7F",
           user_id: b"\x11çïÞ ”¢Z€\x05ñV0/²~",
           workstation_id: b"\x11þ´Ì bsHèØsq─╣óî",
           started_at: "2017-12-13 12:46:31",
           ended_at: "2017-12-17 20:53:32",
           grade_id: 3,
         },
         App\Work {#801
           id: b"\x11çðg‰k³„³³Áâ\x07”˜ˆ",
           user_id: b"\x11çïÞ ”¢Z€\x05ñV0/²~",
           workstation_id: b"""
             \x11çïÞ mTR¢\n
             iF±ïQz
             """,
           started_at: "2017-12-16 03:18:59",
           ended_at: "2017-12-25 22:40:29",
           grade_id: 1,
         },
       ],
     },
   }

If I append the toJson() method on the tinker command line, it throw an error Illuminate\Database\Eloquent\JsonEncodingException with message 'Error encoding model [App\User] with ID [��� ��Z��V0/�~] to JSON: Malformed UTF-8 characters, possibly incorrectly encoded'.
If I append the toArray() method, only the work id is translated to a string.
I guess the problem comes from the json encoding of the user_id and workstation_id in the Work model.
I tried to use the withUuid mentionned in the README, but I don't have a work_id in my users table.
Is there a way to encode the faulty uuid ?
Forget to mention, I work with PHP7.2 and Laravel 5.5

Hi dears,
i found the same error using Passport and uuid for user_id column.
Try yourself with:
Schema::create('oauth_auth_codes', function (Blueprint $table) {
            $table->string('id', 100)->primary();
            $table->uuid('user_id');
            $table->integer('client_id');
            $table->text('scopes')->nullable();
            $table->boolean('revoked');
            $table->dateTime('expires_at')->nullable();
        });

and next generate a token from /oauth/token.

Did you manage to find a solution for this problem?

@andreidmour sorry, no. I have changed package, without binary conversion.

What does your user class look like?
Did you add the $uuids protected field?
Did you append uuid_text and hide uuid from json serialization?

May be a good idea to open your own issue. This one is closed.


ForbiddenComment should allow patterns

Following up on https://github.com/detekt/detekt/issues/959, the resolution of that is not powerful enough / complicates things.
Context
We have the following configuration:
  ForbiddenComment:
    values: ['REVIEW', 'STOPSHIP']

and I got this message flagged by Detekt:
// to express in the preview that it's not a normal TextView.

the only workaround I found is this
  ForbiddenComment:
    values: ['REVIEW', 'STOPSHIP']
    # Allow "preview", "FireView", "DoReView" to occur in comments.
    # So only `// REVIEW explanation` will be flagged.
    # See https://github.com/detekt/detekt/issues/3508
    allowedPatterns: '(?<!^)(review|Review|reView|ReView)'

Expected Behavior of the rule
// REVIEW foo -> flag
// review foo -> flag
// foo review -> allow
// preview -> allow

To do this I want to be able to say ^(?i)REVIEW\b (as in case insensitive, starts with the letters "review" and it's not followed by word characters), instead of the current behavior which is https://regex101.com/r/NioVGu/2/

Even this workaround is broken, because it allows // STOPSHIP breaks preview, which is not good!

I think we need something like
  ForbiddenComment:
    valuePatterns: [ '^(?i)REVIEW\b', '^STOPSHIP\b' ]

Which would be exclusively allowed to be present in the configuration only when values is not present.

I think the config would be more flexible if allows just one regular expression. I like your idea.
@TWiStErRob may I ask if you have resources to submit a PR and help out?

No time at the moment from my side, maybe later (months). If anyone else is willing, feel free to take it.

@schalkms how come you say one regex is more flexible than multiple? Consider a scenario where we have multiple rules, say:

comment shouldn't start with a known todo prefix (todo, fixme, stopship)
but if it contains a Jira ticket number, then it's ok.
comments should be sentences (i.e. shouldn't end with non-punctuation)
comment shouldn't contain known procrastinating terms ("will do later", "another time", etc.)

Each of these could be complex by themselves, and combining each into one monster regex may not be the best idea.

how come you say one regex is more flexible than multiple?

I didn't write that. What I meant is that one regular expression is more flexible than the currently existing configuration option.

Oh, I see! 😅

I'm not sure about deprecation, probably a yes, but needs clear doc on common use cases (regex is hard for some).
If not deprecated probably both values and valuesPatterns shouldn't be allowed together, or clearly defined if it's OR (my vote) or AND relationship. But then the default might be problematic if someone doesn't explicitly override values: [], they can't really use patterns. Based on this, I would go full on for pattern.

This should be deprecated or even removed and described in the breaking changes release notes section.
I don't think it makes any sense to maintain both options. This would create even new problems. Detekt users are usually aware on how to use regex in detekt configs. 😉

I'm not sure about deprecation, probably a yes, but needs clear doc on common use cases (regex is hard for some).


Add bower.json for repo

Let's do this.
http://bower.io/docs/creating-packages/

@brianbaker what do you think about the files to include in the main prop of bower.json?
Docs for main.

Bower has been added to 1.4.1-wip


Upgrade to latest Strimizi and Apicurio Registry Operators

This branch includes the following upgrades:

Strimzi 0.23.0
Apicurio Registry 2.0.1
Quarkus 1.13.7.Final
Avro 1.10.2

This version was tested in Minikube and Red Hat CodeReady Containers.

@manusa This is the Quarkus edition of the same application to produce and consume messages to Kafka. I updated to the latest versions, documentation and so on. Maybe you could review it as you are going to do with the Spring Boot version and contribute with the changes needed to upgrade to JKube 1.3.0.
Thank you so much in advance.

On it
(Relates to: https://github.com/rmarting/kafka-clients-sb-sample/pull/8)


Feature request: with multiple tags in a page, scroll to the clicked one

It seems currently it only opens the related note?

Fixed in v0.1.1!


Component contains grouping information

Spinning off discussion from  https://github.com/NSLS-II/ophyd/pull/539.  Curious what people thought of putting some of the logic that is in _default_read_attrs e.t.c into the Component itself. The result might look like this
class Motor(Device):
      readback = Cpt(EpicsSignalRO, '.RBV', cpt_type='hint')
      setpoint = Cpt(EpicsSignal, '.VAL', cpt_type='read')
      offset = Cpt(EpicsSignal, '.OFF', cpt_type='configuration')

Might want to make cpt_type accept an enum not a string to limit input, but this might save some if we start wanting to add more ways to categorize components. This would mean the Device metaclass could assemble the default attributes itself.  Obviously API is not permanent. Just wanted to write this out before I forgot.

I like this.
Also see 'prompt' and 'promptgroup' in dbd files [1]
[1] https://epics.anl.gov/base/R3-16/1-docs/AppDevGuide/DatabaseDefinition.html#x7-2090006.2

This is great. I think it's probably much easier for user to deal with motor.readback.cpt_type = 'read' that manipulate the elements in lists like motor.read_attrs. Instead of memorizing *_attrs, as well as all the list-mutation methods, they only have to know cpt_type =. It also doubles down on, "Local configuration is better than global configuration." The aggregate lists of which components are in which group can still be generated and displayed, as motor.summary() does.
My initial reaction: I think we should strongly consider slowly deprecating read_attrs and configuration_attrs in favor of this approach.
One wrinkle I'm not sure what to do with: a component that is of type 'hint' is also always in type 'read'. Is there a better way to express that?

I like the suggestion quite a bit. I think cpt_type should determine the default_x_attrs, but thought should be given to “how can I modify that behavior in a subclass in a sensible/easy way?”
Additionally, multiple component types should be specifiable - and I’d recommend using a enum.Flag for that.

Notes on a the video conversation:

NSLS-II intends to try deploying this on Monday and see how it goes.
This backs us out of a couple problems are we are seeing at the beamlines:

The read_attrssettings are scattered far apart from device definitions, leaving scientists/users not sure where to look to change the behavior of a given component.
The hints are not synced carefully with read_attrs, leading to inconsistencies that can break consumers.
Managing large lists of names is cumbersome.

Component passes kind through to its argument, just as the same as it does with timeout or settle_time. In a subclass, you cannot modify the kind of a Component defined by a superclass. But, this is already true of timeout and settle_time. Work-arounds to this limitation all seem messier than either setting it in __init__ or overwriting the class member by re-defining it.
The names read_attrs and configuration_attrs always had a weird asymmetry with read() and read_configuration(). The name read_attrs in particular is not very intutive. We are going with something like kind={OMITTED, NORMAL, CONFIG, or HINTED}. The brevity of these was a priority. Via the magic of IntFlag, something that is HINTED is always also NORMAL (so that it is read). Things can be NORMAL, CONFIG, both, or neither (OMITTED).
Back-compatibility for read_attrs and configuration_attrs is provided through evil "list" objects that supports the list API (modulo ignoring user-specific order and any repeated items) but, under the hood, just reflect and as needed update the .kind attributes of a Device's components. These objects maintain no state on their own. If we need perfect back-compatibility we can add it, but the consensus is that this sufficient for our purposes and the right amount of complexity.
The current system makes it easy to give a short whitelist of read_attrs a.k.a. Components of a NORMAL kind. The new system should support that too. Now it does, via a commit added after the phone call.

One thing that you can do with the current system that you can mix direct child and grand (, grand ...)-child component names in read_attrs and it does the right thing (because getattr(grand_child).read() does what you expect).  This 'generation skipping' is convenient, but can lead to confusingly set up devices where a child is not in it's parents read_attrs and it's read_attrs are badly configured, but via this generation skipping one of it's children is in the parents read_attrs and the top-level device mostly does the right thing (however it is my suspicion that we are not reading all of the configuration we should be).
We can support grand-children via the read_attrs.setter in a (hopefully) non-controversial way be detecting them add then re-cursing :
https://github.com/danielballan/ophyd/blob/179f69ac671b277c0dc1f07c2d9a5994a5b75647/ophyd/device.py#L819-L827
this has the effect of 'correctly' setting up the read_attrs list of the children.  The new system also ensures that sub-devices are in their parents configuration_attrs if they are in the read_attrs.  This is a small API change, but arguably a bug-fix.

The only thing I think this would break is someone being much too clever and using
dev.read_attrs = ['grand.child']
dev.grand.read_attrs = ['some', 'other', 'children']

and expecting dev.read() and dev.grand.read() to have completely dis-joint keys.  I don't really see a use-case for that and the new behavior of forcing dev.grand.read() being a strict sub-set of dev.read() makes a lot more sense.

so far so good, but a maybe bigger hitch is that we can not support arbitrarily mixed-generation read_attrs (that is dev.read_attrs = ['child1', 'child2.a']).  We have 3 choices we can support with the new 'truth lives on the components' scheme (but they all change behavior)

only include direct children.  This mean if the user does dev.read_attrs = ['grand.child'], then the accessed value would be `dev.read_attrs == ['grand']
recuse down to the leaves and only include the end signals.  In this case the length of read_attrs and the length of dev.read() are the same and [getattr(dev, n).name for n in dev.read_attrs] gets you back the read keys.  However this means doing somethnig like dev.read_attrs = ['grand'] would result ind dev.read_attrs == ['grand.child1', 'grand.child2'].  This has the weird side effect that if no child devices have any configuration to offer, then dev.configuration_attrs is empty which is confusing.
include all generations of names, basically combine 1 and 2.

I am between 2 and 3
No matter which of the above we pick, we can (should) make it so that 'child' in dev.read_attrs gives the right answer if we will walk across dev.child as part of dev.read() and make it so that dev.read_attrs = [...] behaves correctly.

Having played with many configurations of nested devices in the new suite of tests, I strongly advocate for (3) being the least confusing option.

Agreed on option (3).


Layer imagery order

I have a bing street map being loaded with openWeather tiles applied for weather:
const ionBing = new Cesium.IonImageryProvider({assetId: 4})
<ImageryLayerCollection>
  <ImageryLayer imageryProvider={ionBing} />
  <ImageryLayer imageryProvider={this.state.openWeatherOptions.temp} />
  <ImageryLayer imageryProvider={this.state.openWeatherOptions.clouds} />
</ImageryLayerCollection>

This sets the bing map over the openWeather tiles but placing it last gives the same result. Sometimes the temp tiles will show over the map but the clouds don't.

Please let me know when you have still an issue .


add 'cow-baited arthropod trap'

Closes #1602.

external-by-hand.owl is a bit of a fossil. All that's left in it is imports from RO, which are stale, as mention in https://github.com/obi-ontology/obi/issues/1597. So I think we should replace with a proper import. But that can wait a little longer.
The rest is good. Thanks!


fix lessers not having a hive

About the PR
when hive core is built it tries to set hive to the construction node (SetHive makes this a no-op, added logging now to find this error in the future)
now it correctly sets the hive so lessers are not rogue

bug of the year 2024 award rmc14 edition


Support maghrib angle

Assalam 3alaykom,
First of all, thanks for this nice package, it works like a charm and the documentation is really nice.
While implementing your package in my app, I noticed the calculation method of Tehran wasn't available, so I tried to implement the CalculationParameters myself, but I realised that the maghribAngle wasn't implemented in this Dart.
Would it be possible to implement it inshaAllah ?
Here's the JS version: https://github.com/batoulapps/adhan-js/blob/master/src/CalculationParameters.js
Many thanks!

InShaAllah, can you try making a pull request on this, create a branch for your feature and commits and then push and then create a pull request? I'm little busy nowadays.

The feature is done, but I don't have the right access, how should I do the PR ?
Thanks!


Adjust zoom keyboard shortcut

Summary

[ ] Simplify zoom shortcuts to:

[ ] Z +
[ ] Z -

[ ] Add Zoom 100% option

[ ] Create function to map 100% zoom
[ ] Register actions
[ ] Add to toolbar (Conceptual)
[ ] Add to toolbar (Conceptual)

Screenshots
T.B.D.

@idmarjr I finished you starting ideia here...
We are ready to go


[opt] reduce memory consuming of de.Variable and support string type Keys and Values.

reduce memory consuming of de.Variable
support string type Keys and Values.
switch the hash function to murmur hash when Key type is int64.

LGTM


Feature(backend+frontend): Connect courses with posts

Changelog:

Feature(backend): Make m2m between posts and courses.
Feature(backend+frontend): Allow admin to add courses to posts.
Feature(backend+frontend): Allow intern to view courses of post.
Feature(frontend): Create breadcrumbs and replace page names with them.

Closes: #18

@d4got10 пинг


Need Hometown Information

Hometown Name, State, and Country

[ ] Home town name

[ ] Country

@crichID can you let me know what more I need for this issue?

Hey @hcanna!

:tada: @hcanna is now a repository collaborator. :balloon:


bug: Mapping vim.cmd functions with arguments will run the function when nvim starts

Did you check docs and existing issues?

[X] I have read all the which-key.nvim docs
[X] I have searched the existing issues of which-key.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.5
Operating system/version
Ubuntu 23.10
Describe the bug
Adding mappings that call vim.cmd.*('...') functions with arguments in parenthesis will cause those functions to be run on nvim startup, when register happens. This doesn't happen if vim.cmd.* doesn't have parenthesis.
I'm new to nvim and lua, so maybe this is expected behaviour? But I didn't see any of this in the README, sorry.
Edit: This also doesn't happen if the command is defined using a string with '<cmd>...'. Thought that'd be more obvious but worth noting.
Steps To Reproduce

Register a mapping for any key to `vim.cmd.echo('"Hello"')
Close and reopen nvim
"Hello" will be printed on the status line on startup.
Delete the previous mapping and create one for vim.cmd.edit
Close and reopen nvim, notice that the command is not automatically run.
Delete the previous mapping and create one for vim.cmd.edit('test_file')
Close and reopen  nvim, notice that nvim automatically goes into edit mode in a new file 'test_file'

Expected Behavior
Mappings to vim.cmd.*('...') functions can be made without them running on startup.

I have a similar issue:
I have the following function:
local function diffOpen()
        local user_input = vim.fn.input("Revision to Open: ")
        return "<cmd>DiffviewOpen<CR>"-- .. user_input .. "<CR>"
    end

    -- Key maps
    require("which-key").register({
        g = {
            name = "Git", -- optional group name
            t = { "<cmd>DiffviewToggleFiles<CR>", "Toggle DiffView Explorer" },
            o = { diffOpen, "Open DiffView"},
        },
    }, { prefix = "<leader>" })

If I pass diffOpen() to which key it executes when registering. Which I understand.
But If I just pass as the function without calling it. It doesn't execute the returned command string.
Is there a lua command that runs strings as nvim commands?

@FedeAbella Can you share how you're registering the mapping with Which-key?
If your issue is similar to mine, I can help.

@FedeAbella if you call the function, it is called when that expression is evaluated, this is expected. You need to pass a function /to be called/, not the result of a function call that has already been done.
No:  vim.keymap.set("n", "<F1>", vim.cmd("echo 'hi'"))
Yes:  vim.keymap.set("n", "<F1>", function() vim.cmd("echo 'hi'") end)


Alpha Skyboxes that can use lighting

Both types of cloud layers have a setting to appear in front of or behind the skybox.  Normal skyboxes need no changes.  Alpha skybox material needs transparency checked in the material editor.

I'll try to get this working and bug free.
Thanks for contribution!


Update README.m

@mstockha, in addition to README.m, could you make the same change to README.md, please? README.m can be read in Matlab, but README.md is the main document that repository viewers see when they go on GitHub's website.
Also, small formatting fix, could you replace "june" with "jun"? For the dates, we usually format it as dd mon yyyy, where "mon" is the three letter abbreviation for the month.
Otherwise, the wording change you made is good and reads well.


Custom order of properties

Allow ordering of properties in the inspector so that partial classes can be customized w.r.t. field/property order

Is there any way to change the order in inheritenced classes.  It would be fine if I could just change parent second instead of parent first.


Environment,,

Which environment are you using for running the codes?

We usually used Google colab. But you can do it on any other platform. Please note that Googlecolab is the most convenient for the novices.

@uarif By the way, which platform do you prefer?


ENH: improve integrate.simpson for even number of points. Closes #5618

This PR improves the accuracy of integrate.simpson when there is an even number of points (odd number of intervals).
Historical behaviour has been to use trapezoidal integration for the last/first intervals and adding it on to the _basic_simpson sum of the other intervals. This is what the even kwd was used for. When even='avg' the mean of last and first approaches was returned.
It was pointed out in #18151 that there is a more accurate way of dealing with this situation, as outlined on wikipedia. This uses a parabolic segment over the last three points to calculate the sum of the last interval, thereby using simpson behaviour for the last interval as well.
This PR:

adds the machinery for performing the improved calculation for the last interval when there is an even number of samples.
this machinery is accessed by adding a 'simpson' option to the even kwd.
Since even='simpson' should offer improved behaviour in most cases (i.e. it continues the quadratic nature of the rest of the summation) this now becomes the default for the even kwd.
Because even='simpson' offers this improved behaviour it shouldn't be necessary to access the {'first', 'last', 'avg'}  options anymore. It's therefore suggested that the even kwd be deprecated and removed in a future version of scipy. After that point the 'simpson' behaviour will be used all the time.
To achieve this deprecation the even kwdis removed from the function signature and replaced by**kwds. Existing code that uses even` will continue to work, but will receive a warning.
If the integration axis only has two points (i.e. impossible to form a parabolic segment with the last three points) then the integration is done trapezoidally.
Tests are added to check simpson integration over multiple axes, for odd and even number of points in the integration axis. These tests were missing and strengthen the test suite.

If there is downstream code using simpson they will:

start getting the DeprecationWarning. This may come as a surprise as the even keyword for simpson has been present for a long time.
get different results if they integrate with an even number of points. The new behaviour is more accurate, but people may complain that their code isn't giving the same numbers any more.

The macOS-meson workflow has started to fail, not due to changes introduced in this PR.

I cannot remember, was there a post on the mailing list about the deprecation aspect?

Have just written an email.

@j-bowhay


Same issue has come again - IOS TestFlight not accepting new testers right now.

Hey Bolopker, the same issue has come again - IOS TestFlight not accepting new testers right now. Can you renew it again?
Originally posted by @Cheesygremlin7 in https://github.com/blopker/superduper/issues/49#issuecomment-2561864630

Oops, thanks for letting me know! I wish they would email me or something before they did this. Oh well.
Pushing a new version now. It should be live within 24 hours.


Remove large option for LB selection--not supported until bare metal …

…edge is supported
Doc bug, should apply to 1.2 only since BM edge support is expected for 1.3, thanks

Thanks, @lparis


Full minified js, without depencencies.

Is it possible to pack this all to one js or .min.js file, to make this full stable, in onw script, and without any dependencies?

Also, is this possible to resize canvas, like resizing this div: https://www.w3schools.com/cssref/tryit.asp?filename=trycss3_resize ???

Did write this myself: https://jsfiddle.net/8wf49bpo/

I used to do this back in early versions, but the overhead of the release process is too much compared to the tiny number of people who want it.
This library is pretty much unmaintained, but if you open a PR I'm likely to accept reasonable changes.


Use ClosedError instead of ClosedException

It's clearly an Error, as it only occurs if you explicitly closed a stream and then still try to operate on it.
(Please fix in the next major to be released.)

@bwoebi In fact this is not true. While it is true for file handles, it is not true for TCP streams.

I thought on TCP streams, we just resolve with null if the stream is externally closed?!

@bwoebi For reading, yes, but not for writing.

@bwoebi Can I close this one? I don't think we need ClosedException and ClosedError.

We do need it. The one you may want to catch, the other most definitely not.

I vote to close this. Writing to a closed peer might totally happen if you have a writing coroutine and close the stream from somewhere else, e.g. the reading coroutine. Having to add an extra flag or catching ClosedError is just horrible.


Restore performance in generate

PR #1358 introduced a nested for loop which caused performance drop observed e.g. in T5 summarization. This change  translates the loop into tensor operations and restores performance.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss I suppose this PR is toxic， models like mllama's eos is a list and they will have eos in prompt while interleaving text and image prompt tokens. @sywangyi

Traceback (most recent call last):
File "/workspace/wangyi/optimum-habana/examples/image-to-text/run_image2text_lora_finetune.py", line 553, in
main()
File "/workspace/wangyi/optimum-habana/examples/image-to-text/run_image2text_lora_finetune.py", line 538, in main
anls = eval(
File "/workspace/wangyi/optimum-habana/examples/image-to-text/run_image2text_lora_finetune.py", line 334, in eval
generated_ids = model.generate(
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 116, in decorate_context
return func(*args, **kwargs)
File "/workspace/wangyi/optimum-habana/optimum/habana/transformers/generation/utils.py", line 1462, in generate
result = self._sample(
File "/workspace/wangyi/optimum-habana/optimum/habana/transformers/generation/utils.py", line 2620, in _sample
eos_positions = (input_ids[:, INITIAL_TOKEN_IDX:] == eos_token_id).int().argmax(dim=1) + INITIAL_TOKEN_IDX
AttributeError: 'bool' object has no attribute 'int'
pytest tests/test_examples.py::MultiCardImageToTextModelingLoRAExampleTester::test_run_image2text_lora_finetune_Llama-3.2-11B-Vision-Instruct_multi_card -v -s

I propose a fix, please see if it will impact the perf @ugolowic


Distinguish between the host target and the default target

Closes https://github.com/rust-lang/docs.rs/issues/699
r? @Mark-Simulacrum

Modulo my comment, and presuming some local testing has been done on the following:

proc macro
some library with a proc macro dep
some library with a build script
some library

r=me

Working on building the following locally:

[ ] proc macro (rstest 0.6.1)
[ ] library with proc macro dependency (grex 1.0.0)
[ ] build script (target_lexicon 0.10.0)
[ ] library (hexponent 0.2.3)

Can you expand on why you think the build script would make a difference?

Good call on asking for the builds! I found that I forgot to update add_esssential_files.

Tested all the types of crates you mentioned and they work.

@jyn514 The build script likely has different handling for us and for Cargo at some level as it's older and perhaps has more quirks -- it also results in slightly different places for some of the artifacts I think (e.g. build dir is populated perhaps?).


LegendreEllipticIntegral.bigE(x, m)

Can you add a link to the Wikipedia definition to LegendreEllipticIntegral.bigE(x, m) and
describe the relaton of your LegendreEllipticIntegral.bigE(x, m)  to the definition in Mathematica?

https://reference.wolfram.com/language/ref/EllipticE.html

Can you implement both "Konventionen" from this table:

https://de.wikipedia.org/wiki/Elliptisches_Integral#Definition_der_vollständigen_elliptischen_Integrale

I can surely add the link. Do you think it is urgent enough to cancel the ongoing vote for releasing
2.0 or can it wait until 2.1?
About the convention, I am reluctant to implement both, as there is really a simple conversion between
the  two (as explained in the class javadoc, m = k²) and since there is a single parameter (either k or m),
we would have to rely on different method names, like bigEk/bigEm and this for all integrals (E, K, K', D, F, Π),
and for all signatures (double, field, complex, field complex), and for both complete and incomplete integrals,
so this would double the combinatorics which is already huge in this class (there are 36 different integrals
in the class currently).
I have tried to follow the most widespread convention, i.e. to use elliptic modulus k for the integrals, parameter m
for the Jacobi functions and nome q for the Jacobi theta functions.

Can you verify if I m doing something wrong for the example from the MMA page: EllipticE[3 + 2.5*I, 2.3 - 1.5*I]
If I use LegendreEllipticIntegral.bigE(x, m.sqrt()) it should evaluate to 3.05969 + I* 11.1650 but gives -0.912102+I*(-9.13895)
BTW is the name bigE suitable? Should it be capitalE?

https://en.wiktionary.org/wiki/capital_letter

Regarding the question which convention (kor m) will be better to implement; if you want to implement the m convention with the current implementation you would have a sqrt() call for your second parameter which will be "squared" inside your bigE method.
If the methods in hipparchus would implement the m convention only the "square" operation for the second parameter would be necessary.

If I use LegendreEllipticIntegral.bigE(x, m.sqrt()) it should evaluate to 3.05969 + I* 11.1650 but gives -0.912102+I*(-9.13895)

I will look at this. There are also different conventions for the first argument in the case of incomplete integrals. In mathematical text, the chosen convention for both arguments is shown by using different separators between the arguments. For example when a comma is used as in E(φ, k), the first argument φ is an angle and the second argument k is the elliptic modulus: this is the trigonometric form of the integral. When a semicolon is used as in E(φ; m) the first argument φ is an angle and the second argument m=k² is the parameter: this is also a trigonometric form of the integral. When a vertical bar is used as in E(x|m) the first argument x=sin(φ) is not an angle anymore and the second argument m=k² is the parameter: this is the Legendre form. When a reverse solidus is used as in E(φ\α) the first argument φ is an angle and the second argument α is the modular angle.
I think Wolfram uses the Legendre form, and we use the trigonometric form. However, even using x.asin() to go back to our convention or changing the convention internally to Legendre form did not give the expected result, so I have to investigate further. I checked the complete integral (i.e. only one parameter), and found the same result as Wolfram Alpha.
I will change the convention from k to m as you suggest, and also change the second parameter to x (as internally we indeed always compute the sine of the first parameter. So in terms of mathematical separators, I will change from trigonometric form E(φ, k) to Legendre form E(x|m).
I canceled the ongoing vote on the forum for 2.0, until this issue is fixed.
Concerning the name bigE instead of capitalE, I think the former is consistent with another classical naming scheme in math, the big-O notation.

From the documentation, it seems Mathematica is using the trigonometric form of the integral with parameter m (hence it computes E(φ; m)).
For real values of the Jacobi amplitude φ between 0 and π/2, we get similar results for the incomplete integrals as them. For the complete integral (φ=π/2), we also get consistent results.
However, our implementation fails for Jacobi amplitude outside of the [0 ; π/2] interval. I have to look at argument reduction.
Here is a plot of out implementation of E(z, 2.3-1.5i). It clearly shows discontinuities at kπ/2.
Do you have access to a reference program that could produce a comparable display?

The issue seems to be fixed by now.
I have pushed a number of changes in the release-2.0 branch. Beware this branch is still in development, the vote for release has not occurred yet.
I still have some problems with incomplete elliptic integral of the third kind Π(φ, α², m) when I compare the to Wolfram alpha results. Two tests fail (so I have put an @ignore annotation temporarily to avoid breaking the continuous integration). The tests compare three different computations of the same integral: one from wolfram alpha, one using the new numerical complex integration feature and one using the Carlson-based implementation. Two cases out of four give consistent results. One case give consistent results between Wolfram alpha and numerical integration and inconsistent with Carlson. One case give consistent results between numerical integration and Carlson and inconsistent with Wolfram alpha. So I don't understand these tests for now.
I am totally exhausted and demoralized by this and am seriously considering either shipping the library as is with a warning about  Π(φ, α², m) being unreliable or even remove this integral from 2.0.

Does it make sense to push this also to 2.0-SNAPSHOT ?
Or what is the policy here?

I have also pushed it on master now, reverting the version id to 2.0-SNAPSHOT so the continuous integration takes it into account.
It should be available on packages.orekit.org.

Does it make sense to compare with ellipticPi

https://github.com/axkr/symja_android_library/blob/e4b2bb1822c67f729f127619a619950bcb125478/symja_android_library/matheclipse-core/src/main/java/org/matheclipse/core/builtin/functions/EllipticIntegralsJS.java#L465

which was ported from this Javascript lib:

https://github.com/paulmasson/math/blob/40fdc802f9891c6b0e0849f9b11cbaf17c9f134e/src/functions/elliptic-integrals.js#L326

Yes, but beware to the order an types of arguments.

Abramowitz and Stegun (A&S) uses Π(n; φ\α)
Carlson 1995 uses Π(φ, k, n) but the n as the opposite sign as the one in A&S
DLMF uses Π(φ, α², k) but the α² from DLFM is equal to the n of A&S and the k from DLMF is equal to sin²(α) in A&S (so it is not the same α)
Wolfram uses π(n; φ, k) in Mathworld but implements EllipticPI(n, φ, m) with m=k² in the Wolfram language
at first, Hipparchus signature was bigPI(φ, α², k), which was chosen for consistency with DLMF. However, since following your suggestion we already switched from k to m=k2 convention, our current notation became inconsistent. I therefore changed it again to bigPI(n, φ, m) so it now matches Wolfram language (i.e. I renamed our α² to n and switched the first two arguments);  this change has just been pushed to master and continuous integration already pushed the compiled snapshot artifacts.

I looked at ellipticPi and it seems to handle the quasi-periodicity differently from what I did in Hipparchus (there is a sign switch every quadrant in my implementation and none in yours). My implementation was made for consistency with F, E and D according to DLMF equation 19.2.10. This equation does not mention Π (only F, E, and D) but it seemed to be just an oversight. On the other hand your implementation seems consistent with Wolfram reference functions (EllipticPI periodicity or (EllipticF periodicity. When I don't put the sign change, I get discontinuities (it was part of solving this issue). I think it is due to one method handling only the [0; π/2] interval and the other one able to handle [-π;π] due to function parity, but am not sure (I am not sure of anything by now).
There are two leads that could explain the problem with incomplete Π in the complex case. Both  are compatible with the fact that for some input values the results are really good (to about 15 significant digits) and for some other they are completely out.
The first lead is the proble described in Carlson[2000] paper, which fixes some issues in the algorithm from his previous paper Carlson[1995].  I am looking at this right now.
The second lead is roots selection hidden in some computation. As an example, when developing the Carlson integrals, I have noticed spurious roots switch in the middle of nowhere. I tracked it down to the DLMF equation 19.21.10, where the last term \sqrt{\frac{xy}{z}} should really be computed as \frac{\sqrt{x}\sqrt{y}}{\sqrt{z}} (i.e compute three roots independently and compute the fraction afterwards. Computing the fraction fist and a single root afterwards leads to the wrong root to be selected in some complex cases, despite none of x, y, and z changes quadrant (but the fraction does). The same problem occurs in equations 19.2.7 and 19.2.8. I have notified DLMF editors about this and one of the mathematical editors from the University of Edinburgh replied me and confirmed this observation was correct and these equations would be corrected in a future version. So perhaps once again there are some root changes for some input values that throw the result far away.
If anybody could help me understand what happens, it would be greatly appreciated.

Making some progress.
The issue seems to lie in Carlson integral R_C, which is used to compute Carlson integral R_J using the algorithm in Carlson[2000] (not the same as Carlson[1995]), and which combined with Carlson integral R_F allows to compute Π(n; φ, k).

More progress.
I found that in Hipparchus current implementation, Π (n = 3.4-1.3i, φ=1.2, m=0.2+0.6i) was correct but Π (n = 3.4-1.3i, φ=1.2+0.75i, m=0.2+0.6i) was very wrong, so I made a simple loop and found a switch point at φ=1.2+0.2505i with result jumping far away. What changed at this point was integral R_C, which is used inside the computation of integral R_J.
R_J is computed using a duplication formula (i.e. an iterative algorithm which converges in just a few iterations) plus an underlying computation of the R_C integral.
In Carlson[1995], the R_C integral is computed at each iteration (this is what is done in elliptic_integrals.js).
In Carlson[2000] an improvement was made and only one R_C integral is computed at the end thus enhancing performances (this is what is cone in Hipparchus).
I first thought that this was the culprit and changed the implementation to compute R_C at each iteration. It did not change the
jump, which occurred with both the slower 1995 algorithm and the faster 2000 algorithm.
Further investigation showed that the change in R_C was due to changes early in the iterations in R_J(x, y, z, p). Regardless of R_C being computed once or several times, the arguments passed to R_C depend on intermediate variables in the iterations.
The switch is caused by intermediate variable dₘ=(√pₘ+√yₘ)(√pₘ+√yₘ)(√pₘ+√zₘ), where for all square roots the one with nonnegative real part must be selected. At the switch point, pₘ is almost real and negative and its imaginary part changes sign, so the square root selection switches from a point along the imaginary axis from negative to positive. The iterations change a lot and the result on both sides of the switch are very different.
Reading again and more accurately the 1995 paper, I noticed an hypothesis I missed:
"Let x, y, z have nonnegative real part and at most one of them be 0, while Rep > 0.
 Alternatively, if p ≠ 0 and Iph pl < π, either let x, y, z be real and nonnegative and
 at most one of them be 0, or else let two of the variables x, y, z be nonzero and
 conjugate complex with phase less in magnitude than π and the third variable be real
 and nonnegative."

So as we have everything complex, the fourth parameter in R_f(x, y, z, p) must have a nonnegative real part!
In the case that causes problem, the p computed to convert Legendre integrals to Carlson integrals is p≈-2.82711+0.99869i.
most Carlson integrals are symmetric, but R_F is not symmetric on its fourth parameter, so we cannot change parameters order at will. I will try to find what can be done tomorrow.

The part related to the integral of the third kind has its own issue number: #152.


STAR-1701: Port BDP part of CNDB-4035: restore sstables if they canno…

…t be dropped and fix lifecycle txn bug

Merging since failures are unrelated.


how to change from postgres to my sql

I need a walkthrough please on how to do that on this specific app because i have never used sequilize or whaterever that is

The project uses Sequelize which is a JS Orm.  You should just be able to change your connection string and dialect and it should work.
https://github.com/norkator/poker-pocket-backend/blob/master/database/sequelize.js#L16

I think I will set this up running again, change license and update documentation regarding changing database. Thanks @bitcoinbrisbane for input.

I think I will set this up running again, change license and update documentation regarding changing database. Thanks @bitcoinbrisbane for input.

Not a problem, let me know if you need any help.


Add image to sample page

Summary
I found some WPF Control pages which have code samples, but no screenshot of what the UI will look like.   Feels like a value add including a pic of the UI as well, so that's what I've done here.
If this is well received, I can continue with some more.
Fixes #Issue_Number (if available)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: 1RedOne sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This definitely does add value, @1RedOne. If you'd like to continue adding images to the WPF control documentation, we'd really appreciate it, as will WPF developers.


introduce the optional package

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

29 of 29 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+16.9%) to 21.341%

Totals

Change from base Build<PHONE_NUMBER>:
16.9%

Covered Lines:
35

Relevant Lines:
164

💛  - Coveralls


ONNX conversion?

Greetings!
I happened to notice you mentioning ONNX conversion in the original basic-pitch repo (https://github.com/spotify/basic-pitch/issues/64#issuecomment-1556216286), I was hoping you could provide some insights on the same, and if possible provide some relevant code.
Was hoping to deploy it fully on the web using ONNXruntime with WebGPU and benchmark the speedup.
References:
https://onnxruntime.ai/docs/tutorials/web/
https://github.com/webonnx/wonnx
Thanks in advance

Hi,
onnx conversion is not a big deal.

The original model can be found in TensorFlow saved_model format here: https://github.com/spotify/basic-pitch/tree/main/basic_pitch/saved_models/icassp_2022/nmp
The tf2onnx tool can convert the model to onnx: https://github.com/onnx/tensorflow-onnx

install via python package manager: pip install -U tf2onnx
run via python: python -m tf2onnx.convert --saved-model tensorflow-model-path --output model.onnx

However, this is only the neural network of the machine learning model.
What is not part of the model itself is

load samples of an audio file
convert the samples of the audio file to the input format for the machine learning model (typically mono channel, specific sample rate, etc.)

These steps are somewhere in the basic-pitch python code.
But I did not have enough time to understand and rewrite this for my own (C#) code. As a result, I took the shortcut of compiling Basic Pitch to an exe and just call this from my code.
But it would be great if you could write code to load audio file and create the correct inputs for the model. Good luck!


Misc change

remove dev, lpt, tooling logic

Coverage decreased (-0.02%) to 50.085% when pulling a093196b90ede8fb5195cb474c267c107bd6949b on nobodyiam:misc-change into 58bd26e300a0bacd5941b7ee4bddb3c55b1edfad on ctripcorp:master.

Codecov Report

Merging #637 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #637      +/-   ##
============================================
+ Coverage     46.54%   46.55%   +0.01%
+ Complexity     1471     1470       -1
============================================
  Files           342      342
  Lines          9381     9374       -7
  Branches        927      924       -3
============================================
- Hits           4366     4364       -2
+ Misses         4682     4680       -2
+ Partials        333      330       -3

Impacted Files
Coverage Δ
Complexity Δ

...va/com/ctrip/framework/apollo/util/ConfigUtil.java
47.11% <ø> (+1.16%)
21 <0> (-1)
:arrow_down:

...ervice/service/ReleaseMessageServiceWithCache.java
85.71% <0%> (ø)
24% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bd26e...a093196. Read the comment docs.

Coverage decreased (-0.03%) to 50.075% when pulling 5a4da4c29e4c5262ceac27969c15d5628d7bfde3 on nobodyiam:misc-change into 58bd26e300a0bacd5941b7ee4bddb3c55b1edfad on ctripcorp:master.


pkg/metrics: pass rest.Config to avoid flag issue in library

Description of the change:

Pass rest.Config to metrics.CreateMetricsService function and remove code from metrics package that uses controller-runtime's config package to get config.
Update relevant docs and scaffolds

Motivation for the change:
controller-runtime's config package declares flags for kubeconfig and master API server, which is causing problems due to double flag declarations in the test framework.

@AlexNPavel @LiliC will this resolve the issue that we discussed offline?


Update user.css

Fix top bar, as it has been merged with main-view/root, in latest UI revamp

@pronoy2108 would you work regarding these reviews by @SunsetTechuila ?
@SunsetTechuila thanks

Absolutely mess now

Absolute mess now

?

@nimsandu Please take a look

dude

why did you just copypaste all the lines to the file end, duplicating all the content?


Close the issue

This is a great bot! Thanks for doing this.  Do you think tag-bot could also close the issue initially opened with @JuliaRegistrator register()?

I'd rather not, I don't really want to make assumptions on how Registrator is being used. If you don't want to deal with hanging issues you can use commit comments instead (example).

I see. Thanks!


Weird symbols when trying to add printer

Describe the bug
If you try to add a printer in CUPS web interface using the administration tab -> add printer you will get only some weird symbols (empty squares, white question-marks in black rhombus, underlines...) in step 2/5 in 'connection' field instead of some existing printer or some useful URI.
To Reproduce
Steps to reproduce the behavior:

Go to CUPS web interface -> administration tab -> add printer -> step 2/5
it does make no difference if there is a printer connected to server or not
see garbage in 'connection'

Expected behavior
If there is a printer connected to the server the field 'connection' should show its URI - not some weird mojibake.
System Information:

ArchLinux 6.10.10-arch1-1 x86_64 GNU/Linux
any Browser
CUPS version 2.4.10

Additional context
Any additional information which are relevant to the issue.

Fixed by https://github.com/OpenPrinting/cups/commit/eb34f2698 and https://github.com/OpenPrinting/cups/commit/21a392d87 .


chore: sync npm version

@iambumblehead when you run npm run release:patch, are the changes pushed to git?

if you have the changes in your master branch un-pushed done merge this but just push yours..and close this PR instead

i found the issue: 13b7d38
Should only build untracked files in prepublish else the push will fail

this is an amazing pipeline


Fix sticky menu click

[STICKY MENU - Issue fix 802]
Highlight an item on click
Issue Description
https://github.com/KleeGroup/focus-components/issues/802

:hamster:


DependsOn items don't have own attribute

From @PozhidayevaDarya in DCC Operations call on 2022-09-21:

DependsOn items that were not represented as their own attributes in the HTAN Schema the examples I found were:
Spike In Mix 1, Spike In Mix 2, Both Spike in Mixes
these can be found under the ERCC attribute DependsOn.

To check if this is an issue.

From my reading of the schematic documentation (possibly only a Sage-internal link), I think that DependsOn items are required to exist as their own attributes... ie if the attribute that has dependencies is used then the Depends on attributes become required.
Will investigate further.

From the scRNA-seq RFC it looks like only Spike In Concentration should be the sole DependsOn value for ERCC

I'm guessing that Spike In Mix 1, Spike In Mix 2, Both Spike in Mixes were left in the data model by error during development.

@milen-sage and @Gibbsdavidl, I think you were DCC signatories for the scRNA-seq L1 RFC... does the above make sense to you.

Further @milen-sage, it might be a nice feature to have warnings for this on JSON-LD generation that there are attributes called that are not in the model.

yes, makes sense.

OK great. I will close this issue and open a new one to remove all but Spike In Concentration as DependsOn values for ERCC

Yes, I'll start an issue around warning if there are missing dependency attributes. @adamjtaylor the addition of Spike In Mix 1, Spike In Mix 2, Both Spike in Mixes was probably an initial request that was later reconsidered...
On our side we need a better standard versioning trail with a searchable change log. Not too hard to implement, but it requires some thought. We'll add that to our backlog as well.


fix(nuxi): hard-reload nuxt when .env changes

🔗 Linked issue
resolves  #15040
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Currently .env variables are not reloaded when they change. This works around that and uses the existing hard-reload functionality to force a fresh cache.
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Suggestion :
Should this supports .env.* instead ? People using something like nuxt dev --dotenv .env.local would need this as well.

Maybe we could respect whatever is passed to --dotenv


 Can you check my PR?

@vicroms @cenit Can you review this PR again?

dis you copy the patch to the CURRENT_BUILDTREES_DIR?

I already remove this port and set it as a feature of libpng on #8622.
Maybe you should wait #8622 merge and fix this issue.

@JackBoosY Thanks for letting me know. I'll wait for it.

/azp run

@JackBoosY I saw that #8622 PR merged. Unfortunately, I can't see the details of your PR (Because I live in IRAN and these days our government decided to block the global internet for us! I just could connect to the internet hardly with too slow connection speed). BTW, if you added the features which exist in my PR, we can close this PR.

@ehsan-mohammadi Thanks for your contribution!


AVR skip instructions do not modify control flow graph

Describe the bug
The control flow implications of AVR skip instructions (cpse, sbic, sbis, etc.) are not indicated in the same manner as other control-flow-altering instructions, e.g. with flow arrows in the listing window and function graph. As an example, see the screen shot below. If Wlo == Whi at 0xe0, the next instruction executed will be at 0xe2. If Wlo!=Whi, the next instruction executed will be at 0xe1. Ideally, the instruction at 0xe1 would be in its own basic block, with a conditional branch indicated by arrows from 0xe0 to 0xe1 and 0xe2.
The various skip instructions are currently implemented with the use of a context variable (see avr8.sinc). If the skip context variable is set, the next instruction results in a  'goto inst_next' rather than a 'build instruction'. It seems that this mechanism is not understood by the tools that build the control flow graph.
Since AVR has variable sized instructions, it would not be trivial to have the various skip instructions modify the program counter directly as the various branch instructions do. We would have to know the size of the next instruction to know how far to advance PC.
The loss of control-flow indicators is somewhere between annoying and problematic for me, depending on how attentive I am being to watch out for skip instructions. I can't think of a straight-forward way to address this. Is there a precedent for handling such instructions in other languages in a way that would result in correct control flow graph construction?
Screenshots

Environment (please complete the following information):

OS: Debian Sid
Java Version: OpenJDK 11.0.6
Ghidra Version: 9.1.1

I should add that the current mechanism works acceptably when the instruction following the skip instruction is something like rjmp. In that case, the SKIP context variable makes rjmp be treated like a conditional branch with some remote target location, and everything works reasonably well. The trouble really arises when the instruction following one of the skip instructions is not a jump of some kind, like the ldi instruction in the example above. In that case, ldi is also treated as a conditional branch if the SKIP context variable is set, but the target is just the next instruction, and none of this is rendered with control flow arrows.

The issue here is that goto inst_next is not considered a jump (there are many cases where this would be undesirable behavior). This can be corrected by adding a CONDITIONAL_JUMP reference to the skip instruction (i.e. cpse) to the code address of the instruction following the skipped instruction.
Depending on the size of the binary, this may be easy enough to do by hand by searching memory for the five skip instruction mnemonics. Otherwise a script would be a better solution.

Try this and let me know if you like the results:
SkipAVR8Fixup.txt

Thanks for the quick reponse and for taking the time to write the script! It does indeed greatly improve the situation.
If I may be allowed one last neurotic quibble, unconditional jump instructions following skip instructions maintain their conditional jump targets after running the script, which unnecessarily clutters the control flow graph. I thought I would try to address this by changing the CONDITIONAL_JUMP references to UNCONDITIONAL_JUMP references for subsequent jump instructions as in the script below. But, alas, there was no change in the control flow graph. I'm guessing at this point this is because of the CBRANCH *[code]..., SKIP pcode ops, which are acting independently of the reference type.
For reference, I've attached a nonsensical AVR binary with various arrangements of skip instructions in the main function at code:0042. If there is a straightforward way to clean up those last jump instructions, I would appreciate hearing about it. If there is not, consider me both sufficiently satisfied by the solution that you gave and very grateful for your help.
SkipAVR8Fixup2.txt
nonsense.zip

I think you're correct about the reason why those CONDITIONAL_JUMP references are not being removed. A better course of action may be that since we already know that the flow graph is handling the skip->jump flow, we could just not add the reference at cpse if we know that the next instruction after a skip instruction is a jump.


Upgrade builder to go 1.13

Fixes https://github.com/abiosoft/caddy-docker/issues/238

bump; can this please be merged urgently? All of my Caddy containers are failing to build, and it's a low-risk merge.


Use a generic type paramater

This would be a very small non-breaking ergonomic improvement: it would be nice if the input types were AsRef<str>, which would let the function transparently accept both String and &str.
If this is interesting to you I'd be happy to PR.

Close due to inactivity. Please reopen if required.


Updated the names of the CI tests and updated refine

Fixes #5808
Changes proposed in this pull request:

Updated the names of the CI e2e tests.
Updated the refine script.

Updated the docs: https://github.com/OpenRefine/openrefine.org/commit/de1dfe51be6e8945f34f2fc747662b7229a32be3

I updated again to change e2e_test to e2e_tests and removed the chrome parameter: https://github.com/OpenRefine/openrefine.org/commit/6c2ceea43dbc2f03921dda68c2cb4279f2fc7d5f


Swift 5.2 update and modification for matching coefficient.

I've recompiled SameFace.framework using Swift 5.2 and modified SFaceCompare to return not only a simple "faces match" but also the matching coefficient in case they do, providing developers with a numeric value of how likely the faces match. Please accept this pull request and update the CocoaPods version, as well.

Big thanks for your contribution. 🙏🏻 I'm working on an update and include your pr in this update.

Any updates on this PR?


CrashReporter: Pressing return when showing QR code in Payment request crashes app

CrashReporter gives exception:
o.m.h.c.e.ExceptionHandler - Uncaught exception ! java.lang.IllegalStateException: LightBoxPopover should never be called twice
! at com.google.common.base.Preconditions.checkState(Preconditions.java:176) ~[guava-16.0.1.jar:na]
! at org.multibit.hd.ui.views.components.Panels.showLightBoxPopover(Panels.java:305) ~[classes/:na]
! at org.multibit.hd.ui.views.wizards.payments.PaymentRequestDetailPanelView$1.actionPerformed(PaymentRequestDetailPanelView.java:283) ~[classes/:na]

Already proving useful...

Pressing return whilst the QR code popover is being shown now closes the popover.
Awaiting review and closing

Also fixed similar bug on the 'Request Bitcoin' screen that I missed previously

Verified working.
Closing.


Adds a proof for s2n_stuffer_peek_check_for_str

Please note that while we are transitioning from travis-ci to AWS CodeBuild, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Resolved issues:
N/A.
Description of changes:

Adds a proof harness for the s2n_stuffer_peek_check_for_str function;
Adds a pre- and post-conditions to the s2n_stuffer_peek_check_for_str function;

Call-outs:
N/A.
Testing:
N/A.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2044 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
+ Coverage   81.05%   81.06%   +0.01%
==========================================
  Files         247      247
  Lines       18385    18385
==========================================
+ Hits        14902    14904       +2
+ Misses       3483     3481       -2


Simplify code using torch.normal

Should be covered by test_dither_GPDF()

requires more work and better understanding of the algo that I have to make the chance, I'll close this for now.

@datumbox What was the issue with your approach?

The tests were failing but it's unclear to me why as I  don't know enough about the specific technique. It's worth looking at the test execution to see the error and tell me what you think


base-image: Remove batch-shipyard

The batch-shipyard project is not unmaintained and the GH repo is archived.
Fixes: #404

Start an environment which looks like what user will see:
$ docker run -it quay.io/surajd/cloudshell:no-batch-shipyard-2024-04-Apr-26-20-43-51 bash
root [ / ]# useradd -m foo
root [ / ]# su foo
foo [ / ]$ cd
foo [ ~ ]$ export PATH=$PATH:$HOME/.local/bin

Installing batch-shipyard:
mkdir -p ~/.local/bin
curl -L -o ~/.local/bin/shipyard https://github.com/Azure/batch-shipyard/releases/download/3.9.1/batch-shipyard-3.9.1-cli-linux-x86_64
chmod +x ~/.local/bin/shipyard
shipyard --version


fix extension loading error in chrome extension

Hi @0x6b , very thank you for developing this extension, I used it a lot in Firefox.
But after I switch to Brave browser (chrome-based), it's a long waited for its chrome version.
So when I see #50 closed, this extension has been ported to chrome, I can't wait to build it by myself.
Follow #95's instruction, I've built it successfully, but I met some error when I loading this extension.
So I try to fix these errors and now it worked perfectly!
This pull request fix these errors, which almost all are path issue,  except the last one, which is permission issue.
In order to dynamically remove hosts permission, we need to create "optional_permissions" key and move "<all_urls>" into that key. see: https://developer.chrome.com/docs/extensions/reference/permissions/#step-2-declare-optional-permissions-in-the-manifest

@allenyllee thank you for your time for the PR. Can you please check the following steps before loading locally-built extension?

Clone the repository
Install dependencies (npm i)
Build core and extensions (npm run build)
Load packages/chromium/dist/manifest.json as unpacked extensions to your browser

I guess you loaded packages/chromium/manifest.json at step 4 thus failed to load .js files due to wrong path. Permission change (64ae6ed) could be valuable but other two commits may not be needed I'm afraid. Sorry for lack of the build instruction for Chromium based browsers. Please get back to me how the steps above work for you. Thanks!

OK, I see...
Previously, I copy the whole packages/chromium/ folder and load it, didn't aware that it just need to copy packages/chromium/dist/ folder.


Addon is not connecting to Amazon

First of all, thanks for you great work on that!
I'm currently setting this up to fulfill the ToDoist issue with Alexa.
For me it looks like the addon can not connect or redirect to amazon (according to Log)
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
/app/node_modules/puppeteer-core/lib/cjs/puppeteer/util/Deferred.js:59
            this.#timeoutError = new Errors_js_1.TimeoutError(opts.message);
                                 ^

TimeoutError: Navigation timeout of 60000 ms exceeded
    at new Deferred (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/util/Deferred.js:59:34)
    at Deferred.create (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/util/Deferred.js:21:16)
    at new LifecycleWatcher (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/LifecycleWatcher.js:69:60)
    at CdpFrame.waitForNavigation (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Frame.js:199:29)
    at CdpFrame.<anonymous> (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/util/decorators.js:98:27)
    at CdpPage.waitForNavigation (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:619:43)
    at /app/scrapeAmazon.js:117:24

Node.js v21.7.3
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

I'm using OTP (not SMS) and German Amazon URL's (btw the Shopping List is accessible for me in the desktop browser)
Amazon_Login<EMAIL_ADDRESS>Amazon_Pass: password
Amazon_Secret: TokenWithoutSpaces
HA_Webhook_URL: >-
  http://IP:8123/api/webhook/import-alexa-shoppinglist-rx_TOKEN
Amazon_Sign_in_URL: >-
  https://www.amazon.de/ap/signin?openid.pape.max_auth_age=3600&openid.return_to=https%3A%2F%2Fwww.amazon.de%2Falexaquantum%2Fsp%2FalexaShoppingList%3Fref_%3Dlist_d_wl_ys_list_1&openid.identity=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.assoc_handle=amzn_alexa_quantum_de&openid.mode=checkid_setup&language=de_DE&openid.claimed_id=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.ns=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0
Amazon_Shopping_List_Page: >-
  https://www.amazon.de/alexaquantum/sp/alexaShoppingList?ref_=list_d_wl_ys_list_1
Delete_After_Download: true

Any hints on solving that?
Also Debug Log level does not give and additional information

Issue found: Blocked URL!
For me it was "unagi-na.amazon.com"
So look at your Web Filtering. Might have some block which are required


Need to check the frequency of tone()

When plays some musical notes, it sounds somewhat weird.
Example: https://kaluma.io/@kaluma/buzzer

I checked all the frequency without buzzer connection. The PWM frequency is right.
C4, Frequency 262Hz

D4 Frequency 294Hz

E4 Frequency 330Hz

F4 Frequency 370Hz

G4 Frequency 392Hz

A4 Frequency 440Hz

B4 Frequency 466Hz

C5 Frequency 523Hz

I think the issue is the buzzer, If the buzzer draw a high current, the pico PWM can't draw the enough current. So the PWM signal is distorted like the below signal and it may cause the issue. So please try it with the active buzzer.

I tried it another buzzer and it make more noisy sound and here's the PWM signal

Works well with buzzer for 3.3V, so buzzers for 3.3V should be used to play a correct melody.


Error in react-native-zeroconf when trying to assembleRelease

I am trying to release my app to the play store and I followed the steps in https://facebook.github.io/react-native/docs/signed-apk-android
when i run ./gradlew assembleRelease I get the following error. I believe its a mismatch in gradle and library versions.
Execution failed for task ':react-native-zeroconf:verifyReleaseResources'.

java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
error: resource android:style/TextAppearance.Material.Widget.Button.Borderless.Colored not found.
error: resource android:style/TextAppearance.Material.Widget.Button.Colored not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values-v26/values-v26.xml:7: error: resource android:attr/colorError not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values-v26/values-v26.xml:11: error: resource android:attr/colorError not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values-v26/values-v26.xml:15: error: style attribute 'android:attr/keyboardNavigationCluster' not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2714: error: resource android:attr/fontStyle not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2715: error: resource android:attr/font not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2716: error: resource android:attr/fontWeight not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2717: error: resource android:attr/fontVariationSettings not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2718: error: resource android:attr/ttcIndex not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2799: error: resource android:attr/startX not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2802: error: resource android:attr/startY not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2805: error: resource android:attr/endX not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2808: error: resource android:attr/endY not found.
/Users/thehellmaker/test/testapp/node_modules/react-native-zeroconf/android/build/intermediates/res/merged/release/values/values.xml:2816: error: resource android:attr/offset not found.
error: failed linking references.

Here is my build.gradle versions
buildscript {
ext {
buildToolsVersion = "28.0.2"
minSdkVersion = 16
compileSdkVersion = 28
targetSdkVersion = 27
supportLibVersion = "28.0.0"
}
}

Most of these disappear when compileSdkVersion is downgraded to 26 from 28

@thehellmaker I cannot reproduce this anymore, but I think we had the same problem before setting the compileSdkVersion and buildToolsVersion for subprojects.
You can try to use the following in your build.gradle:
subprojects {
afterEvaluate {project ->
if (project.hasProperty("android")) {
android {
compileSdkVersion 28
buildToolsVersion "28.0.3"
}
}
}
}

Hello, any news on this?
Cannot assembleRelease, no matter what compileSdkVersion or targetSdkVersion I use...

I also can't build with RN 0.60

Anyone knows a solution for this? I really need this to work, I downgraded RN to 0.57 and SDK to 23 but still no luck, please help

Solution from @westcode worked for me...

I found out that the steps which produces error is after bundling, meaning you will get your app compiled and you have apk even if this error occurs, you can also use ‘’’gradle app:assembleRelease’’’ instead of ‘’’gradle assembleRelease ’’’ to supress error


Update index.md blazor wasm template name

Updated the template name for blazor web assembly project.
Summary of the changes (Less than 80 chars)

Current documentation has the wrong template name (MS updated this in January)
Only changes to the documentation

Closes #bugnumber (in this specific format)

Thanks for your help!


Dataset.to_netcdf() results in unexpected encoding parameters for 'netCDF4' backend

import pandas as pd
import xarray as xr
from datetime import datetime

ds_test2=xr.open_dataset('test_file.nc')

ncudmp to show how file looks like
<test_file>
netcdf test_file {
dimensions:
lon = 720 ;
lev = 1 ;
time = 27147 ;
variables:
float lon(lon) ;
lon:_FillValue = NaNf ;
float lev(lev) ;
lev:_FillValue = NaNf ;
lev:long_name = "hybrid level at layer midpoints" ;
lev:units = "level" ;
lev:standard_name = "hybrid_sigma_pressure" ;
lev:positive = "down" ;
lev:formula = "hyam hybm (mlev=hyam+hybm*aps)" ;
lev:formula_terms = "ap: hyam b: hybm ps: aps" ;
int64 time(time) ;
time:units = "hours since 2000-01-01 00:00:00" ;
time:calendar = "proleptic_gregorian" ;
float V(time, lev, lon) ;
V:_FillValue = NaNf ;
V:units = "m/s" ;
}
</test_file>
std_time = datetime(1970,1,1)
timedata =  pd.to_datetime(ds_test2.time.values).to_pydatetime()
timedata_updated = [(t - std_time).total_seconds() for t in timedata]
ds_test2.time.values= timedata_updated
ds_test2.time.attrs['units'] = 'Seconds since 01-01-1970 00:00:00 UTC'
### saving file
ds_test2.to_netcdf('/scratch3/mali/data/test/test_V250hov_encoding4_v2.nc',
                   encoding={'V':{'_FillValue': -999.0},'time':{'units': "seconds since 1970-01-01 00:00:00"}})```

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-26-04662c00dfc2> in <module>
      6 # saving file to netcdf for one combined hov dataset
      7 ds_test2.to_netcdf('/scratch3/mali/data/test/test_V250hov_encoding4_v2.nc',
----> 8                    encoding={'V':{'_FillValue': -999.0},'time':{'units': "seconds since 1970-01-01 00:00:00"}})

/usr/local/anaconda3/envs/work_env/lib/python3.6/site-packages/xarray/core/dataset.py in to_netcdf(self, path, mode, format, group, engine, encoding, unlimited_dims, compute)
   1220                          engine=engine, encoding=encoding,
   1221                          unlimited_dims=unlimited_dims,
-> 1222                          compute=compute)
   1223
   1224     def to_zarr(self, store=None, mode='w-', synchronizer=None, group=None,

/usr/local/anaconda3/envs/work_env/lib/python3.6/site-packages/xarray/backends/api.py in to_netcdf(dataset, path_or_file, mode, format, group, engine, encoding, unlimited_dims, compute, multifile)
    716         # to be parallelized with dask
    717         dump_to_store(dataset, store, writer, encoding=encoding,
--> 718                       unlimited_dims=unlimited_dims)
    719         if autoclose:
    720             store.close()

/usr/local/anaconda3/envs/work_env/lib/python3.6/site-packages/xarray/backends/api.py in dump_to_store(dataset, store, writer, encoder, encoding, unlimited_dims)
    759
    760     store.store(variables, attrs, check_encoding, writer,
--> 761                 unlimited_dims=unlimited_dims)
    762
    763

/usr/local/anaconda3/envs/work_env/lib/python3.6/site-packages/xarray/backends/common.py in store(self, variables, attributes, check_encoding_set, writer, unlimited_dims)
    264         self.set_dimensions(variables, unlimited_dims=unlimited_dims)
    265         self.set_variables(variables, check_encoding_set, writer,
--> 266                            unlimited_dims=unlimited_dims)
    267
    268     def set_attributes(self, attributes):

/usr/local/anaconda3/envs/work_env/lib/python3.6/site-packages/xarray/backends/common.py in set_variables(self, variables, check_encoding_set, writer, unlimited_dims)
    302             check = vn in check_encoding_set
    303             target, source = self.prepare_variable(
--> 304                 name, v, check, unlimited_dims=unlimited_dims)
    305
    306             writer.add(source, target)

/usr/local/anaconda3/envs/work_env/lib/python3.6/site-packages/xarray/backends/netCDF4_.py in prepare_variable(self, name, variable, check_encoding, unlimited_dims)
    448         encoding = _extract_nc4_variable_encoding(
    449             variable, raise_on_invalid=check_encoding,
--> 450             unlimited_dims=unlimited_dims)
    451         if name in self.ds.variables:
    452             nc4_var = self.ds.variables[name]

/usr/local/anaconda3/envs/work_env/lib/python3.6/site-packages/xarray/backends/netCDF4_.py in _extract_nc4_variable_encoding(variable, raise_on_invalid, lsd_okay, h5py_okay, backend, unlimited_dims)
    223         if invalid:
    224             raise ValueError('unexpected encoding parameters for %r backend: '
--> 225                              ' %r' % (backend, invalid))
    226     else:
    227         for k in list(encoding):

ValueError: unexpected encoding parameters for 'netCDF4' backend:  ['units']

Problem description
I'm trying to change the time attributes becaues in the workflow there are some scripts which are not in python and would like the time to start from a specific year. I've written the code to calculate seconds from a specific standard time. Later on, I realised that I don't need to do that as xarray takes care of that when saving the data when specified with that encoding parameter. Strange thing is the writng the file by above approach is giving me an error however, when I just read in the same file and save it with the same encoding as above and without changing the time values manually, it works fine. Here's what I mean:
ds_test3 = xr.open_dataset('test_file.nc') ## same file as before
## saving directly without doing any calculations like before
ds_test3.to_netcdf('/scratch3/mali/data/test/test_V250hov_encoding4_v2.nc',
                   encoding={'V':{'_FillValue': -999.0},'time':{'units': "seconds since 1970-01-01 00:00:00"}}

## above code works fine

Output of xr.show_versions()

INSTALLED VERSIONS
------------------
commit: None
python: 3.6.6.final.0
python-bits: 64
OS: Linux
OS-release: 4.15.0-45-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8
xarray: 0.11.0
pandas: 0.23.4
numpy: 1.15.2
scipy: 1.1.0
netCDF4: 1.4.2
h5netcdf: None
h5py: 2.8.0
Nio: None
zarr: None
cftime: 1.0.0b1
PseudonetCDF: None
rasterio: None
iris: 2.2.0
bottleneck: 1.2.1
cyordereddict: None
dask: 0.19.2
distributed: 1.23.2
matplotlib: 2.2.2
cartopy: 0.16.0
seaborn: 0.9.0
setuptools: 40.4.3
pip: 10.0.1
conda: None
pytest: 3.8.1
IPython: 7.0.1
sphinx: 1.8.1

I know that I can change the time to a standard calendar without performing the manual calculations I did but I would like to know how are my calculations modifying the dataset such that netcdf4 backend doesn't recognise ['units'] of time anymore?

The source of your trouble is that the time variable on ds_test2 doesn't have datetime64 type, so xarray isn't making use of the units encoding. Xarray is giving an error message rather than silently ignoring units.
There's also definitely an opportunity for better error messages here, but the work around is to either let xarray handle datetime conversion or do it all yourself by not including units in encoding.

@shoyer Ah! thanks. Certainly, a better error message would have helped me in this case. I agree that the easiest way is to just let xarray handle the datetime conversion.


[2 of 2] DCOS-7823: Introduce collapsing string component

The user specifies a number of characters that should not be truncated at the end of the string, or the default of 15 characters is used.

I opted not to use classnames/dedupe here because I thought the performance hit would not be worth it, as I don't expect we'll need to override these classnames. But let me know if you feel otherwise!

Reviewer: @daiyiwhale


Cursor jumps unexpectedly to beginning of TS method after using the outline once to jump to a method

Steps to Reproduce

Have a TypeScript file open (with some code in it)
Use the outline to jump to the beginning of a method
Type something somewhere
Have the cursor jump to the beginning of the previously jumped-to function as soon as you stop pressing keys for .5 seconds

Does this issue occur when all extensions are disabled?
Yes (both in insiders & stable)
Versions
Version: 1.34.0-insider (user setup)
Commit: c1abf7978d59415dcfcf8cfcb15e0ee30c5e45a5
Date: 2019-04-26T13:39:29.623Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.18356

@joaomoreno It seems that the tree send a selection change event after updating children (which happens because markers changed). I will look into a workaround, e.g e.browserEvent being undefined but it seems like a tree issue


Fix for loading images on non-retina devices

no longer passing in nil, but adding a png image extension for the non retina cases

Fix: 1003

This change is

Hi @pittmab, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

    strcat_s(newStr, newStrSize, pathEnd);

I'm a little worried -- this should be stitching together filename, @2x and .extension already.

Refers to: Frameworks/UIKit/UIImage.mm:379 in 2518fe7. [](commit_id = 2518fe7ef69f111cda64e04a6bce904f15d2a255, deletion_comment = False)

@jaredhms is added to the review. #Closed

@davelamb is added to the review. #Closed

:shipit:

    memcpy(newStr, path, pathEnd - path);

not your change but this string manipulation isn't exception safe, makes potentially unsafe assumption about the sizes of some datatypes, doesn't use the secure versions of certain common buffer overrun attack vectors, has a lot of duplicated code that could be factored out with RAII constructs, and doesn't follow WinObjC coding conventions. I'd be over the moon if we took the opportunity to improve the codebase where possible.

Refers to: Frameworks/UIKit/UIImage.mm:376 in 2518fe7. [](commit_id = 2518fe7ef69f111cda64e04a6bce904f15d2a255, deletion_comment = False)

:clock1:

Can't repro issue, closing pull request.


After checkout a new feature that is invoice format can be updated v4.4

[https://getbootstrap.com/docs/4.4/examples/checkout/]

Centralizing in #30627.


Usage for 'padding_mask' in COCOInstanceNewBaselineDatasetMapper?

Thanks to your excellent job!
I don't understand the usage of padding_mask in COCOInstanceNewBaselineDatasetMapper, it seems that it is no longer used in the following training process.
Can you explain this for me please?  Thanks a lot.

The COCOInstanceNewBaselineDatasetMapper will always return an image with the same size (e.g., 1024x1024) with zero padding. padding_mask indicates which pixels are padding, which is not used yet.


getTouchPointCount() doesn't count

Hi here, thank you for creating the binding so that building raylib application in zig has becoming very easy.
However, I have faced an issue about using touch screen:
My zenbook supports multitouch, so I have written a multitouch demo in zig based on this example from the official raylib website which it works with my laptop , but no matter how, none of the fingers are responded on the screen. After I have traced the code, I just found that getTouchPointCount() never counts the number of fingers on the screen.
Here is my code:
const std = @import("std");
const rl = @import("raylib");
const gui = @import("raygui");

pub fn main() !void {
    // Initialization
    //--------------------------------------------------------------------------------------
    const screenWidth = 800;
    const screenHeight = 450;

    const MAX_TOUCH_POINTS = 10;

    rl.initWindow(screenWidth, screenHeight, "raylib-zig [core] example - basic window");
    defer rl.closeWindow(); // Close window and OpenGL context

    var touch_points: [MAX_TOUCH_POINTS]rl.Vector2 = std.mem.zeroes([10]rl.Vector2);

    rl.setTargetFPS(60); // Set our game to run at 60 frames-per-second
    //--------------------------------------------------------------------------------------

    // Main game loop
    while (!rl.windowShouldClose()) { // Detect window close button or ESC key
        // Update
        //----------------------------------------------------------------------------------
        // TODO: Update your variables here
        //----------------------------------------------------------------------------------
        var t_count = rl.getTouchPointCount();
        std.debug.print("Number of Touch Points: {d}\n", .{t_count});

        if (t_count > MAX_TOUCH_POINTS) t_count = MAX_TOUCH_POINTS;

        var i: i32 = 0;
        while (i < t_count) : (i += 1) {
            touch_points[@as(usize, @intCast(i))] = rl.getTouchPosition(i);
        }

        // Draw
        //----------------------------------------------------------------------------------
        rl.beginDrawing();
        defer rl.endDrawing();

        rl.clearBackground(rl.Color.white);

        for (0..@as(usize, @intCast(t_count))) |j| {
            if ((touch_points[j].x > 0) and (touch_points[j].y > 0)) {
                rl.drawCircleV(touch_points[j], 34, rl.Color.orange);
                rl.drawText("Touch", @as(i32, @intFromFloat(touch_points[j].x)) - 10, @as(i32, @intFromFloat(touch_points[j].y)) - 10, 40, rl.Color.black);
            }
        }
        //----------------------------------------------------------------------------------
    }
}

Is there any difference for this binding, compared to the original C version? Anything I have done wrong in the example?

Not entirely sure if GLFW supports multitouch. Also Zenbooks might not bes supported. Can you try out the original raylib example?

Not entirely sure if GLFW supports multitouch. Also Zenbooks might not bes supported. Can you try out the original raylib example?

Yep! In fact, I did tried the original example on the website to confirm that raylib works without any issue before I decided to submit the issue; as you can see, I have included this link from the previous post.

I have captured my screen from the example above, showing that in theory, multitouch should works with zenbook; however, with our current binding, it seems to stuck at zero. Perhaps once I have some time, I will try if the original c library behave the same or differently.


migrated to dart 2.12 with null-safety

In relation to #7

Merge this, pls

@bjartebore i am new to dart and flutter and everything, i am using your fork, and got this when doing enqueueWorkIntent(WorkIntent(....))
Unhandled Exception: type 'Future<dynamic>' is not a subtype of type 'Future<bool>' in type cast
#0      submitTaskRequest
package:flt_worker/…/background_tasks/background_tasks.dart:11

Does it work for you?
It uses the fork as specified in my pubspec.yaml:
  flt_worker:
    git:
      url: git://github.com/bjartebore/flt_worker.git
      ref: null_safety