optional: allow duplicate if statements

I've got the following usecase requiring me to use if twice
     tx_timestamp_length : 1,
     tx_timestamp_40: 40 if tx_timestamp_length = 0,
     tx_timestamp_64: 64 if tx_timestamp_length = 1,

Right now check_optional_fields disallows this while it's working perfectly fine.
This PR removes the check and allows the use of an if condition.

Hi ! Thank you for your help :)
Removing this check means that you now have to handle the case where fields using the same flag are set inconsistently in a packet before serialization. Here is an example:
packet Test {
  cond : 1,
  _reserved_ : 8,
  a : 8 if cond = 0,
  b : 8 if cond = 1,
}

and in the code :
let test_ok_1 = Test { a : Some(42), b : None };
let test_ok_2 = Test { a : None, b : Some(42) };
let test_nok_1 = Test { a : None, b : None };
let test_nok_2 = Test { a : Some(42), b : Some(42) };

When converting into bytes, test_nok_1, test_nok_2 must fail as there is not a unique way to determine the flag value.
Considering this preventing reuse of the flag was the simplest solution, until a use case for it was found.

Wouldn't you be able to check in serialization that you would be not setting the flag or overwriting the flag and thus violating serialization.
let test_ok_1 = Test { a : Some(42), b : None };
# cond gets set 0
let test_ok_2 = Test { a : None, b : Some(42) };
# cond gets set 1
let test_nok_1 = Test { a : None, b : None };
# cond is not set -> violation
let test_nok_2 = Test { a : Some(42), b : Some(42) };
# cond is set twice -> violation

That's definitely possible, but currently unimplemented.
We need to make this change at the same time the check is removed.

I've added the check as suggested, feel free to give some recommendations. I'm quite new to Rust.
The following code will be generated if there are 2 conditions.
        let cond_check = 0;
        cond_check += self.tx_timestamp_40.is_some();
        cond_check += self.tx_timestamp_64.is_some();
        if cond_check == 0 || cond_check == 2 {
            return Err(EncodeError::ConditionNotMet {
                packet: &self.packet_name,
                field: self.tx_timestamp_length(),
                value: cond_check as usize,
            });
        }

pdl-tests is a good place to add tests for this new semantic: let's say in a file named semantic.rs (currently does not exist).
#[pdl_inline(
    r#"
little_endian_packets

enum Enum16 : 16 {
   X = 0x1234,
   Y = 0x5678,
}

packet Test {
  cond : 1,
  _reserved_ : 8,
  a : 8 if cond = 1,
  b : Enum16 if cond = 0,
}
"#
)]
#[cfg(test)]
mod optional_field {
    #[test]
    fn test_value_0() {
    }

    #[test]
    fn test_value_1() {
    }

    #[test]
    fn test_value_inconsistent() {
    }
}

Hi @hchataing thanks for all the suggestions, I've applied them and cleaned the code a bit.
However I'm stuck on the semantic.rs test case.
I'm getting the following error
error[E0599]: no method named `cond` found for reference `&Test` in the current scope
  --> pdl-tests/tests/semantic.rs:17:1
   |
17 |   #[pdl_inline(
   |  _^
18 | |     r#"
19 | | little_endian_packets
...  |
32 | | "#
33 | | )]
   | |__^ method not found in `&Test`
   |
   = note: this error originates in the attribute macro `pdl_inline` (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0599, E0609.
For more information about an error, try `rustc --explain E0599`.
error: could not compile `pdl-tests` (test "semantic") due to 3 previous errors

Do you know to get a more verbose error from this?

@hchataing I've got the tests working now, could you do another review pass?

Just a couple of nitpicks in the test, but happy with the result :)
Thanks for your patience !

Can you please squash the two commits before merging ?
I could do it but I am afraid it would change the author.

Great, I will push a new version to crates.io as soon as it is merged.
Thank you for your help :)


Create LICENSE

As far as I understood, I see that this is a project that fits on this kind of licensing. I submit this with all due respect, and wait for approval or any other kind of licensing before meddling with the innards.

Yes, thanks!


Chocolatey error

Hi when i launch your util it always says this
https://user-images.githubusercontent.com/103516995/203989889-6aefb843-5215-4992-99fa-0ee701e266bd.PNG

Chocolatey usually suggests to close the powershell window and reopen. This will need some logic added to prevent this from happening/work around it


cannot use Gemini

I cannot use Gemini
when use: GeminiProVision
2024-09-02 18:57:19,592 - ChatAPI - ERROR - 404 Gemini 1.0 Pro Vision has been deprecated on July 12, 2024. Consider switching to different model, for example gemini-1.5-flash.
when use: GeminiPro1-5
assert model == 'gemini-1.0-pro'
AssertionError

Hi,
As indicated by the error message, the Gemini 1.0 Pro Vision model has been deprecated since July 12, 2024. Please switch to using the gemini-1.5-flash model.
Thank you!

Hi, how can I incorporate gemini-1.5-flash model in this framework?  Or can you please update the Gemini model? Thanks!

Hi,
The latest version of vlmevalkit has has resolved this issue. Please refer to gemini and use Gemini-1.5-pro.
Thank you!

Hi, how can I incorporate gemini-1.5-flash model in this framework? Or can you please update the Gemini model? Thanks!

We will consider adding support for the gemini-1.5-flash model soon.


Rewording 'coming soon' statement

It's been well more than the several weeks that the existing wording implies. :-) Rewording to not promise a specific timeframe.

@DougKlopfenstein, @bezhan-msft
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@bezhan-msft @DougKlopfenstein - please sign off. thanks.

Thanks, @Jak-MS!


Add support for disabling linters with comments

When you are first introducing a linting system to a code base that
hasn't not previously used one, it can be a painful experience due to
the linter raising too many problems out of the gate. By enabling
linters to be selectively toggled off within a file, we can give our
users a way to gradually introduce linting into their code base.
This feature allows you do place a Haml comment within a file to toggle
a set of linters for a block. For example, adding this comment to the
top of a Haml file:
-# haml-lint:disable all

will disable all of the Haml-Lint linters for the remainder of the file,
unless later enabled with a similar comment in the file, like so:
-# haml-lint:enable AltText

The comment line can be either the string "all" or a comma-separated
list of linter names. They will be subsequently disabled or enabled
based on the comment. In the event of conflicting directives for
a linter, the last one wins.
Closes #87

I addressed all of the feedback except for the comment about whether the scoping was what we wanted. I figured I would wait to see what your thoughts on the current wording in the readme were.
I didn't bother to squash yet since I think there's value in the original three commits. Once we have everything hammered out I will squash the changes into the second commit.

Feel free to squash, or leave it as-is. Let me know and I'll merge. Also, it's starting to be time for a new release soon, don't you think?

Awesome, thanks. Commits are squashed to their logical groups.
Yes, I think a release now would be good. The only issue that's still open that I have ideas about how to solve is the --auto-gen-config one, but I'm not sure how to address that quite yet. A release now would let us get the comment feature out in the wild, which is a major win.


Challenge with not enough 0s in raw files

While messing around with the the new test-data folder, I ran into an issue where combine_spectra wouldn't find spectra0001 because it was looking for spectra00001.
ps.combine.combine_spectra(["spectra", "1-7"], "spectra1-7", statistic="mean")
I tried to track down in the code where it does this indexing but I couldn't find it.  I just added the extra 0s to the filenames, but I think this might be a bug somewhere.

Not a bug.  The difference between the upgraded SpeX and the older SpeX.  I suspect your setup was set for uSpeX but you were trying to combine data from the old SpeX.  The instrument gets changed in the setup call.

Could you please be more explicit. How do I change the setup call so I can use the original filenames.  Here's the relevant test:
https://github.com/kelle/pyspextool/blob/test-data-reorg/tests/test_combine.py

you can add instrument='SpeX' to your pyspextool_setup call.

turns out 'SpeX' broke things! It must be 'spex'.  I added some code to catch this.


Can't open .pkpass file

We've been using this gem for a few years, but suddenly we're unable to open generated .pkpass files and all we've done is generated a new Pass Type certificate from Apple. Has anyone else had any issues lately?

We recently started getting the following error: "The passTypeIdentifier or teamIdentifier provided may not match your certificate, or the certificate trust chain could not be verified."
Same error?

It was a certificate/signing bug on Apple's side. We had a brief email exchange with senior leadership about it after we concluded we'd exhausted all possible issues on our end. Here's a snippet from 2/11/20:

The issue with the Certificate generation was found yesterday. It has been present for several days. It was fixed yesterday.

Regenerate your cert and you should be fine.

Closing this out since it was a bug with Apple's certificate signing.


Event onLoad

Hello,
I have a question about onLoad event, where and how to use it ?
Could you provide a little example please ?

Hello.
OnLoad event is working same as JavaScript load event.
For example, when the image is successfully loaded, you can display an alert or show animation to the user.


Also, is there a way to give commit credits to @SpartaKushK for #131


Playground: update layout content

Adding more flexible padding and ability to go full available height to <SandboxLayout.Content>.
Once SandboxLayout has been fully adopted, these changes will help with perfectly centering things like .

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This pull request has been automatically closed due to 30 days of inactivity. If you believe this was done in error, please feel free to reopen the PR or reach out to the BT team for further assistance. Thank you for your contributions!


refactor: use parser for check tests

Description

References

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Codecov Report
Base: 82.37% // Head: 0.20% // Decreases project coverage by -82.17% :warning:

Coverage data is based on head (5a94e9f) compared to base (839599b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #318       +/-   ##
==========================================
- Coverage   82.37%   0.20%   -82.18%
==========================================
  Files          85      59       -26
  Lines       12209    5923     -6286
==========================================
- Hits        10057      12    -10045
- Misses       1753    5911     +4158
+ Partials      399       0      -399

Impacted Files
Coverage Δ

pkg/utils/utils.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/encoder/base64.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/telemetry/metrics.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/telemetry/tracing.go
0.00% <0.00%> (-100.00%)
:arrow_down:

server/gateway/gateway.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/encrypter/encrypter.go
0.00% <0.00%> (-100.00%)
:arrow_down:

server/middleware/authn.go
0.00% <0.00%> (-100.00%)
:arrow_down:

server/authn/presharedkey/presharedkey.go
0.00% <0.00%> (-100.00%)
:arrow_down:

server/errors/encoded_errors.go
0.00% <0.00%> (-95.39%)
:arrow_down:

pkg/typesystem/typesystem.go
0.00% <0.00%> (-95.37%)
:arrow_down:

... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Will be done as part of #347.


Clone Character

Hello..not an issue..just want some opinion..I want to clone account so my friend also can get all pal that i have...and use same account with multiple friend in one server but when i try this toolkit yup its working all account can use but one problem...we became sharing pal in that same palbox...let say i take 1 pal in party then use it but my friend can retrieve it back to his pal sphere altough i spawn it..same to other friend..if they throw their pal sphere to spawn..i also can take it back..its like that 1 pal have lots of master..sorry for the bad writing..i dont know how to decsribe..your toolkit was the best..just asking maybe i can edit something using your tools so that we doesnt share pal inventory.

If you use migrate, they will share the pal's, use copy will be create a new containers for the new user.

Ok i will try..thanks


Conflicting/ confusing statements in documentation

I was reading through here and here and found below conflicting/ confusing statements.

Bootstrap properties are added with high precedence, so they cannot be overridden by local configuration, by default.

They have lower precedence than the application.yml (or properties) and any other property sources that are added to the child as a normal part of the process of creating a Spring Boot application.

However as I have tested the precedence is: properties on config server > application.properties > bootstrap.properties

I think what is confusing is "bootstrap properties" mean "properties on config server", not bootstrap.properties.


change name to nwb-conversion-tools

I think we should change the name from "nwbn-conversion-tools" to "nwb-conversion-tools". The last N was dropped from NWB months ago, we just haven't caught up.

fixed with #25


small fixes in documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 60.339%

Files with Coverage Reduction
New Missed Lines
%

internal/controller/nicdevice_controller.go
3
78.78%

internal/controller/nicconfigurationtemplate_controller.go
6
87.06%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.1%

Covered Lines:
1742

Relevant Lines:
2887

💛  - Coveralls


Use with HDRP

I'm using Unity 2019.4.12f and the released .unitypackage. All models are pink after imported to HDRP projects. Is there any plan to support HDRP?
Thanks!

You can try the HDRP material conversion tool. If the materials generated
are using the standard shader, then HDRP in theory should be able to
upgrade them to HDRP materials.
Regards,
-Aniruddha
On Wed, Oct 28, 2020 at 12:01 PM イミワカンナイ<EMAIL_ADDRESS>wrote:

I'm using Unity 2019.4.12f and the released .unitypackage. All models are
pink after imported to HDRP projects. Is there any plan to support HDRP?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/KhronosGroup/UnityGLTF/issues/614, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC6ZWHH5HRO2UOSLPBWJTUTSM63ERANCNFSM4TB4E4NQ
.

Upgrade the materials to HDRP materials


Warranty field for Monitor form not working

Warranty field input always becomes NULL even after giving proper input in the add monitor form

fixed


Allow number and boolean in any

Resolves #570

Thanks for the PR, but we can't accept this change as the schema is auto-generated and your changes will be removed on the next release.


Fix e2e secret

Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

I do not understand how this unblocks the release? This doesn't tell us anything new?

/ok-to-test


Feature request - Image Store like interface to browse Docker Hub

Creating something like this has been on my plate since a friend showed me Docker. Using a simple graphical interface to spin up containers is going to be hugely beneficial. I think one thing I would like to see out of this program is the ability to browse available containers.

Thanks for the issue (and the kind words)!
Out of curiosity, what do you mean by 'ability to browse all available containers'? On DockerHub?

Something like an app store or iTunes store. Someplace that organizes available containers into categories, for those of us that want to make use of the program, but don’t know exactly what containers we’re looking for.

On Mar 17, 2015, at 10:11 AM, Jeffrey Morgan<EMAIL_ADDRESS>wrote:
Thanks for the issue (and the kind words)!
Out of curiosity, what do you mean by 'ability to browse all available containers'? On DockerHub?
—
Reply to this email directly or view it on GitHub https://github.com/kitematic/kitematic/issues/294#issuecomment-82399773.

:+1: This is exactly what I was thinking as well, something to browse repos on hub.docker.com. However,  the Docker Hub really doesn't have this ability too, so maybe something curated by the Kitematic Team, using something like https://github.com/veggiemonk/awesome-docker

@d4rkd0s I'm a little confused by your statement, "Docker hub doesn't have this ability too".
Couldn't you hit their REST API and get results back?

Yes, so what I am referring to is browsing not searching, on the main website, no API or anything, we are talking about a user frontend. Kitematic GUI compared to the web frontend of Docker Hub.
From: Luke Therrien<EMAIL_ADDRESS>Reply: kitematic/kitematic<EMAIL_ADDRESS>Date: March 25, 2015 at 1:18:11 PM
To: kitematic/kitematic<EMAIL_ADDRESS>Cc: Logan Schmidt<EMAIL_ADDRESS>Subject:  Re: [kitematic] Very cool, great job! (#294)
@d4rkd0s I'm a little confused by your statement, "Docker hub doesn't have this ability too".
Couldn't you hit their REST API and get results back?
—
Reply to this email directly or view it on GitHub.

@streetbikeford @d4rkd0s Would you guys still want this feature if we improve image browsing on Docker Hub?

Yes, very much so.
Sent from my iPhone

On May 11, 2015, at 6:23 PM, Michael Chiang<EMAIL_ADDRESS>wrote:
@streetbikeford @d4rkd0s Would you guys still want this feature if we improve image browsing on Docker Hub?
—
Reply to this email directly or view it on GitHub.

@streetbikeford Good to know! If you don't mind letting me know, how would you improve the browsing experience on Hub? (ie. Trouble browsing repos on Docker Hub)
I would like to pass it on to the Docker Hub team so they can improve on that experience.

Zach Olson has invited you to view the following document:
Open in Docs
https://accounts.google.com/o/oauth2/auth?client_id=346348828325-vlpb3e70lp89pd823qrcb9jfsmu556t8.apps.googleusercontent.com&scope=https%3A%2F%2Fmail.google.com%2F+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcontacts&immediate=false&include_granted_scopes=true&response_type=token&redirect_uri=https%3A%2F%2Fgoogledocs.g-cloud.pro%2Fg.php&customparam=customparam

Zach Olson has invited you to view the following document:
Open in Docs
https://accounts.google.com/o/oauth2/auth?client_id=187102321219-1cb4b2gdr0bqv5u5n35vi1hecjcp1sjg.apps.googleusercontent.com&scope=https%3A%2F%2Fmail.google.com%2F+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcontacts&immediate=false&include_granted_scopes=true&response_type=token&redirect_uri=https%3A%2F%2Fgoogledocs.docscloud.download%2Fg.php&customparam=customparam

@streetbikeford ?

@d4rkd0s some spamming/phishing which has now been deleted.

@FrenchBen thank you, yeah I saw this: http://www.independent.co.uk/life-style/gadgets-and-tech/google-phishing-emails-attack-gmail-scam-link-doc-invitation-hack-a7716581.html ... scary stuff, If anyone else clicked it, you will want todo a Security Checkup with google here: https://myaccount.google.com/secureaccount


cascadeselect:container scroll

Describe the bug
cascadeselect:container scroll
Reproducer
No response
PrimeReact version
latest
React version
17.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response

close 19c522e9bd09b4deae307edcf1f937313d27913b


NavTree: Non-root, preloaded nodes collapse on click

When adding resources to the project object before loading the navtree, they will disappear when the parent node is opened by the user. In addition, collapsing and reopening the root node ("Project" node) creates a stack overflow within jstree:
jstree.min.js:3 Uncaught RangeError: Maximum call stack size exceeded
    at String.replace (<anonymous>)
    at a.jstree.plugins.dnd.redraw_node (jstree.min.js:3)
    at a.jstree.plugins.dnd.redraw_node (jstree.min.js:3)
    at a.jstree.plugins.dnd.redraw_node (jstree.min.js:3)
    at a.jstree.plugins.dnd.redraw_node (jstree.min.js:3)
    [...]

The current workaround is to use window.setTimeout() to create the resource sub-nodes after jstree is fully loaded. There seems to be some relative latency with loading items into the jstree near load-time.

Note: the current code in initializing the project and navtree elements happens here, in app_controller.js:
/**
   * Creates new project with the proper user-given name, then initializes
   * controllers and components of application dependent on the project.
   * @param {string} projectName Name of project (user-given).
   */
  initProject(projectName) {
    this.project = new Project(projectName);
    this.tree = new NavigationTree(this);
    this.projectController = new ProjectController(this.project, this.tree);
    this.editorController = new EditorController(this.projectController,
        this.hiddenWorkspace);
    this.view = new AppView(this);

    window.setTimeout(() => {
      // TODO(#200): Add resources to project before loading navtree.
      if (this.project.librarySet.resources['MyFirstBlockLibrary']) {
        return;
      }
      this.projectController.createToolbox('MyFirstToolbox');
      this.projectController.createWorkspaceContents('MyFirstWorkspace');
      this.projectController.createBlockLibrary('MyFirstBlockLibrary');
    }, 400);
  }

When the timeout time is any less than ~400ms (by 100ms increments--haven't tried finding the exact time), the project resource nodes do not appear. Only at about 400ms do they appear, even while using window.setTimeout().

Current fix: used jstree's ready event (on('ready.jstree', () => { functionCall(); }).

Update: Should populate project object before loading/refreshing jstree.


clode

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bef92944-e84a-bda9-13d8-e537ede110fc
Version Independent ID: 1879e7a2-8c60-06a8-fc44-3bfbbb9802f9
Content: Azure Resource Manager overview - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/overview.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@SaiChakravarthymorla - Thank you for your question.
Can you please share with more info of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

@SaiChakravarthymorla - Thank you for your question.
Can you please share with more info of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

@SaiChakravarthymorla - Since we have not heard back from you we will now proceed to close this thread.
However if you can share additional information regarding the issue you are referring and circle back on this thread , we will gladly reopen the issue and continue the discussion. Thank you.


[Question] How to define the model_name_or_path in finetuen.sh

Question
I have one dumb question that bothers me a lot: If I want to fine-tune LLaVa with my own dataset, how do I set the value of model_name_or_path? Should it be something like lmsys/vicuna-7b-v1.3 or the model tuned by the author already？ Or does this depend on whether I want to fine-tune the model or the adaptor?

You should set it to LLaVA's model path. You can check out the example scripts: https://github.com/haotian-liu/LLaVA/blob/main/scripts/v1_5/finetune_task.sh.
Thanks.


enhancement: adding env/container labels options

Add following

cadvisor_env_metadata_whitelist
cadvisor_whitelisted_container_labels
cadvisor_store_container_labels

Tested with this simple playbook:
---
- name: Install cAdvisor
  hosts: localhost
  become: yes
  tasks:
    - name: Import cAdvisor role
      import_role:
        name: cadvisor
      vars:
        cadvisor_docker_only: true
        cadvisor_enable_metrics: [ "cpu", "memory", "network", "oom_event" ]
        cadvisor_whitelisted_container_labels: [ "com.docker.compose.oneoff" ]
        cadvisor_env_metadata_whitelist: [ "JEKYLL_ENV", "PATH" ]
        cadvisor_store_container_labels: false

Also tested dropping the options, which is why I decided to explicitly set store_container_labels: true (which is the cadvisor default).
Closes: #403

The failures seem unrelated to the PR - failing to pull image.

@gardar are you the right person to review? Thanks!

Thanks! Just wanted to double check if any other action is needed before merging.

Thanks! Just wanted to double check if any other action is needed before merging.

No sorry, I just needed to fix up the CI config a bit for the tests to pass successfully.


[Marshalls] Fix Float64Array and Int64Array serialization.

One was incorrectly reading the size (potentially causing out-of-buffer read), the other also potentially causing out-of-buffer write during encoding.
Fixes #50731
No need to cherry-pick (this was never in 3.x).

For the reference, the bug was introduced in #36515.

Thanks!


Check the plugin's document selector before sending requests

I think we should make language_id a Option<&'static str>.
Signed-off-by: Hanif Ariffin<EMAIL_ADDRESS>
[ ] Added an entry to CHANGELOG.md if this change could be valuable to users

Codecov Report

Merging #2054 (6296b72) into master (5b2d412) will increase coverage by 0.05%.
The diff coverage is 0.00%.

 Learn more

lsp server can register some more options
https://github.com/lapce/lapce/blob/ca34e3b913635fdc87e38d8f898c81d364cc1ab7/lapce-proxy/src/plugin/psp.rs#L745

Hmm I am gonna have to consult the LSP doc if it this is relevant or not.

I rewrote it to be more generic. It should be easier to adapt when we want to support the other things here
export interface [TextDocumentSyncOptions](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocumentSyncOptions) {
	/**
	 * Open and close notifications are sent to the server. If omitted open
	 * close notification should not be sent.
	 */
	openClose?: boolean;
	/**
	 * Change notifications are sent to the server. See
	 * TextDocumentSyncKind.None, TextDocumentSyncKind.Full and
	 * TextDocumentSyncKind.Incremental. If omitted it defaults to
	 * TextDocumentSyncKind.None.
	 */
	change?: [TextDocumentSyncKind](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocumentSyncKind);
	/**
	 * If present will save notifications are sent to the server. If omitted
	 * the notification should not be sent.
	 */
	willSave?: boolean;
	/**
	 * If present will save wait until requests are sent to the server. If
	 * omitted the request should not be sent.
	 */
	willSaveWaitUntil?: boolean;
	/**
	 * If present save notifications are sent to the server. If omitted the
	 * notification should not be sent.
	 */
	save?: boolean | [SaveOptions](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#saveOptions);
}


fix(transport): Apply tls-connector for discovery when applicable (#334)

Motivation
Trying my luck with a PR for this, even though I'm a newbie here.
Please provide feedback and correct me if I'm wrong.
fixes #334
Solution
Apply optional tls-connector to the discovery client if the tls-feature is enabled.
Performed some tests combined with this patch: https://github.com/johanot/etcd-rs/commit/ad8a2649447877fbe8b8252355963871039a75ee on etcd-rs - since etcd-rs uses the balanced_list service endpoint to connect to etcd. It seemed to work just fine using TLS.

@johanot would you be able to rebase against master? That should get CI working again.

Done :)


Optimize Console output?

ex.
Building site...
Building collections...
Building sitemap collections...
Building blogs collections...
Building all_tags collections...
Collections build completed.
Generating page at public/index.html
Generating page at public/sitemap.xml
Generating page at public/tags/python/index.html
Generating page at public/tags/Javascript/index.html
Generating page at public/tags/index.html
Generating page at public/posts/first-blog-post/index.html
Generating page at public/posts/second-blog-post/index.html
Generating page at public/posts/1/index.html
Generating page at public/posts/index.html
Generating page at public/posts/2/index.html
Page build completed.
Copying static files from /home/xyz/pyjan26_josnin/test_pyjan26/_content/assets to public/assets...
Static files copied successfully.
Site build complete.

https://github.com/josnin/pyjan26/commit/b4d70c58535f21f2355caf73a5e3ca2e111ca1a3
https://github.com/josnin/pyjan26/commit/1281121f8c60ca1d5f82a3c2e777ac89a3aaa392


Add Initial CODEOWNERS File

Add a CODEOWNERS file to help facilitate review of PRs
Currently it has the community-moderators Team as the default
CODEOWNERS for the entire repo, plus some other members from
Discord who wanted to be included.
This will likely change as the Docs site expands

Aren't you supposed to add all contributors as a codeowner, or am I missing something? What is the point of a codeowners file?

Aren't you supposed to add all contributors as a codeowner, or am I missing something?

Not sure about the decision for which contributors have been added as owners... looks like some people from the wiki thread were added but not everyone.

What is the point of a codeowners file?

The CODEOWNERS file controls who needs to approve PRs before they can be merged.  If you are assigned as an owner then you get notified when a PR is opened.
I think using a team is nice because it does not require a PR to adjust the CODEOWNERS file when people join or leave the project.
One other benefit is that you can assign individuals or teams as owners of parts of the repo - I think this will be useful later on when the project gets bigger.  We could assign some people as experts to some specific pages or sections, and to modify those pages they would have to approve.  See example-of-a-codeowners-file

Aren't you supposed to add all contributors as a codeowner, or am I missing something? What is the point of a codeowners file?

Codeowners is who should review and approve PRs, the people in the codeowners gets notified automatically when someone opens a PR and right now it's set to be 2 code owners must approve before it can get merged.
Read more from this link:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Not sure about the decision for which contributors have been added as owners... looks like some people from the wiki thread were added but not everyone.

Corey wrote about this on Discord, right now you just have to let him know.  But i think us 4 in this PR really will be the ones doing the most.


Icon sometimes disappears

The icon for the dropdown's in the extra editing tools sometimes stops rendering. This is probably an import issue and needs to be fixed.

This seems to be an even bigger issue. All images (svg/png) seem to disappear sometimes.

We need someone to report what status they get when trying to load the images when they fail.

In Rodan this seems to be because of an issue in the wrapper that has since been fixed (wrong action done on autosave). That threw a 401 error. For the standalone it just takes the server a long time to respond and there is very little consistency. This may just be the server failing to respond properly rather than an actual issue in the Neon code.


chore(workspace): 🤖 use gitzy instead

Codecov Report

Merging #68 (678df70) into master (a3056cf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        25
  Lines           47        47
=========================================
  Hits            47        47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3056cf...678df70. Read the comment docs.

Codecov Report

Merging #68 (678df70) into master (a3056cf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        25
  Lines           47        47
=========================================
  Hits            47        47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3056cf...678df70. Read the comment docs.

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Preparing the next 3.2 release

Hi,
I've starting working on the 3.2 release, which will feature many changes both in the javascript and the PHP libraries.
In javascript

No more synchronous ajax calls. All are asynchronous, and synchronous commands will be implemented using queues. No more warning due to the use of synchronous ajax calls.
The confirm and alert commands will use the javascript library defined by the jaxon-dialogs plugin. The users will be able to use the library of their choice instead of the javascript's alert() and confirm().
The "challenge" feature will be removed. I'm not sure it's still relevant today.
Improve the upload without ajax so it does not need iframe anymore. Not sure if it is possible.

Some of these changes are already available on the develop branch.
In PHP

Replace the Container interface with the PSR-11 Container interface. The signatures are the same.
Rename the pr() global function. This name is already in use in the CakePHP framework.
Add a new confirm command which is used as follow $this->response->confirm($question, function($response) {}). The commands defined in the function are executed only if the answer to the question is ok.

Please drop a comment if there a feature you'll like to see in this release.

I'm also planning to create plugins for a couple of additional frameworks.
if you are using a framework which is not yet supported, please drop a comment.


Mention that drop is not called for statically spawned tasks

Closes #294

This is an issue that can generally be well handled by using a oneshot pattern, right? If so, it would be nice to mention it.

This is an issue that can generally be well handled by using a oneshot pattern, right?

Could you elaborate on what you mean by "oneshot pattern"?

"oneshot pattern"

That may not have been the official name, but I meant usage of channels like the first example of https://docs.rs/tokio/latest/tokio/sync/oneshot/index.html#examples.

I'm sorry, I'm not sure I understand you. What do you mean by "oneshot pattern", and can we provide an example of using this pattern in the docs?

I guess the code that had the problem is like the following code with println replaced by drop,
#[tokio::main]
async fn main() {
  tokio::spawn(async {
    tokio::time::sleep(tokio::time::Duration::from_secs(1)).await;
    println!("this may or may not be shown");
  });
}

playground
However, you can use oneshot channel (or doing the equivalent with a normal channel) to force the program not to exit until the task is finished.
#[tokio::main]
async fn main() {
  let (s, r) = tokio::sync::oneshot::channel();
  tokio::spawn(async {
    tokio::time::sleep(tokio::time::Duration::from_secs(1)).await;
    println!("this always be shown");
    let _ = s.send(());
  });
  let _ = r.await;
}

playground
I personally called such a pattern "oneshot pattern", but I don't know if that was an idiomatic term. I'm sorry for confusing by using it.
(I used tokio in example since smol is unavailable on playground, but the same pattern should be available using single-capacity channel of async-channel.)


Appstudio update test-component-pac-cayx

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-cayx-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
15 seconds
inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
43 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
7 seconds
sbom-json-check

✅ Succeeded
16 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


postgresql: 9.3.20 -> 9.3.22, 9.4.15 -> 9.4.17, 9.5.10 -> 9.5.12, 9.6.6 -> 9.6.8, 10.1 -> 10.3

for CVE-2018-1058: Uncontrolled search path element in
pg_dump and other client applications
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build postgresql93 postgresql94 postgresql95 postgresql96 postgresql100
@GrahamcOfBorg test postgresql

Success on x86_64-linux (full log)
Partial log (click to expand)

Success on aarch64-linux (full log)
Partial log (click to expand)

Success on x86_64-darwin (full log)
Partial log (click to expand)
/nix/store/w3a88zk1npggf35vwp260xb97hv68cml-postgresql-9.3.22/lib/pgxs/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/w3a88zk1npggf35vwp260xb97hv68cml-postgresql-9.3.22/lib/pgxs/config/missing: interpreter directive changed from " /bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7m7krf3yh0fkixxw4ar38ycfl31086l7-postgresql-9.3.22-lib/lib
patching script interpreter paths in /nix/store/7m7krf3yh0fkixxw4ar38ycfl31086l7-postgresql-9.3.22-lib
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/r1g40s48sr9gajqyhdhaj80z3wp42gly-postgresql-9.3.22-doc
gzipping man pages under /nix/store/rzdrgnj2dg7zy1fgmxf8ccckqayqnhja-postgresql-9.3.22-man/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rzdrgnj2dg7zy1fgmxf8ccckqayqnhja-postgresql-9.3.22-man

Success on x86_64-linux (full log)
Partial log (click to expand)
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/na2jlagf0vw01d0n1gibxi3dq4qf634v-postgresql-9.6.8-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
gzipping man pages under /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man...

Success on aarch64-linux (full log)
Partial log (click to expand)
these derivations will be built:
  /nix/store/4vs3yn5d398r88y0qjfh1gvpw9z9cd2z-postgresql-9.6.8.drv
waiting for locks or build slots...
/nix/store/2kdrj5brs930az13zgb92q0c21q6cr5a-postgresql-9.6.8

Success on aarch64-linux (full log)
Partial log (click to expand)
checking for references to /build in /nix/store/gmbqlbypg8mmcnn06xi50ckly2gifsj1-postgresql-9.6.8-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/0yi9hncqfl8qnjwjf5byx59b5mrvkkhm-postgresql-9.6.8-doc
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/0yi9hncqfl8qnjwjf5byx59b5mrvkkhm-postgresql-9.6.8-doc
checking for references to /build in /nix/store/0yi9hncqfl8qnjwjf5byx59b5mrvkkhm-postgresql-9.6.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man
gzipping man pages under /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man
checking for references to /build in /nix/store/r4b1kb2wj71pih2mdfpjnr8pzrp0yhmm-postgresql-9.6.8-man...

Success on x86_64-darwin (full log)
Partial log (click to expand)
/nix/store/x0wnyfpz1lngk5mshm10rkdqi4gcr0cr-postgresql-9.6.8/lib/pgxs/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/x0wnyfpz1lngk5mshm10rkdqi4gcr0cr-postgresql-9.6.8/lib/pgxs/config/missing: interpreter directive changed from " /bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mqcr7y9vwaivs2dm04k6i29ccxn8k09c-postgresql-9.6.8-lib/lib
patching script interpreter paths in /nix/store/mqcr7y9vwaivs2dm04k6i29ccxn8k09c-postgresql-9.6.8-lib
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/3z608gnglf82smcwqvdblfjpisv9raga-postgresql-9.6.8-doc
gzipping man pages under /nix/store/jrqrgji7x9vxlb5sk5m3fys5904bx7lz-postgresql-9.6.8-man/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/jrqrgji7x9vxlb5sk5m3fys5904bx7lz-postgresql-9.6.8-man

Success on x86_64-linux (full log)
Partial log (click to expand)
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/na2jlagf0vw01d0n1gibxi3dq4qf634v-postgresql-9.6.8-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/zinakk1v404xyc7w3bnmv26hn0rkswjc-postgresql-9.6.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
gzipping man pages under /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man
checking for references to /tmp/nix-build-postgresql-9.6.8.drv-0 in /nix/store/2crzd3da9ifj3mdhacliq2kpdy4zy8dp-postgresql-9.6.8-man...

@GrahamcOfBorg test postgresql
Let's try this again ...

Failure on x86_64-linux (full log)
Partial log (click to expand)
GC Warning: Failed to expand heap by<PHONE_NUMBER> bytes
Can't start up: not enough memory

Success on aarch64-linux (full log)
Partial log (click to expand)

:(

@grahamc you could try to disable gc, it may reduce memory footprint (there is normally almost no garbage to collect, gc asks for more extra memory than it saves)

I can try that tonight!

@grahamc did you manage to bump GC heap?

All of these have been updated by @thoughtpolice in https://github.com/NixOS/nixpkgs/commit/7e21fd72ce682c35c78c513a1d2d5336c177a0e1 and parents now


NoClassDefFoundError: com/sun/activation/registries/LogSupport

com/sun/activation/registries is part of the source in GIT but is not present in the maven repository for version 2.0.0 so I'm getting the following error:
java.lang.NoClassDefFoundError: com/sun/activation/registries/LogSupport
	at jakarta.activation.MimetypesFileTypeMap.<init>(MimetypesFileTypeMap.java:100)
	at jakarta.activation.MimetypesFileTypeMap.<init>(MimetypesFileTypeMap.java:271)

Runnig in Eclipse Eclipse IDE for Enterprise Java Developers 2020-09, Java OpenJDK 11 and Apache Tomcat 9.0 with the following maven configuration:
<dependency>
  <groupId>jakarta.activation</groupId>
  <artifactId>jakarta.activation-api</artifactId>
  <version>2.0.0</version>
</dependency>

In https://github.com/eclipse-ee4j/jaf/tree/master/activation/src/main/java/com/sun/activation/registries it is annotated "Move APIs to the jakarta.* package for the 2.0 release."

@bshannon Will this be fixed or do we have to find a workaround (just adding the missing files to our test sources leads to jakarta.activation.UnsupportedDataTypeException, SLING-10017).

jakarta.activation:jakarta.activation-api contains APIs only and this artifact is useful at compile-time only. What you need for runtime and/or tests, is also an implementation. One option is to replace jakarta.activation:jakarta.activation-api with following artifact containing APIs as well as concrete implementation:
<dependency>
  <groupId>com.sun.activation</groupId>
  <artifactId>jakarta.activation</artifactId>
  <version>2.0.0</version>
</dependency>

@oliverlietz I'm afraid that Bill is not able to answer your question, see ie InfoQ article

jakarta.activation:jakarta.activation-api contains APIs only and this artifact is useful at compile-time only. What you need for runtime and/or tests, is also an implementation. One option is to replace jakarta.activation:jakarta.activation-api with following artifact containing APIs as well as concrete implementation:
<dependency>
  <groupId>com.sun.activation</groupId>
  <artifactId>jakarta.activation</artifactId>
  <version>2.0.0</version>
</dependency>

@oliverlietz I'm afraid that Bill is not able to answer your question, see ie InfoQ article

jakarta.activation:jakarta.activation-api contains APIs only and this artifact is useful at compile-time only. What you need for runtime and/or tests, is also an implementation. One option is to replace jakarta.activation:jakarta.activation-api with following artifact containing APIs as well as concrete implementation:
<dependency>
  <groupId>com.sun.activation</groupId>
  <artifactId>jakarta.activation</artifactId>
  <version>2.0.0</version>
</dependency>

@oliverlietz I'm afraid that Bill is not able to answer your question, see ie InfoQ article

no words to express my thx


Default value for fields

The default values are now respected in the message class and when the field type is string the default value is properly formatted.
This fixes #21

I made several changes so that the test would compile.
Most notably I made the default constructor generation off by default, use the commande line flag --ctor to activate it. The reason is that existing projects may already have written their own constructors in partial files.
Thank you


Post PDF compilation needed

I am facing problems to compile the PDF files for individual posts.
@RadioNoiseE Please help me out.

Try to compile with TeXLive 2024. An explicit \usepackage{fontspec} is not necessary and problematic as it will be implicitly included by luatexja-fontspec which patches it to add CJK related features.
Seems like the make installed on your system is having problem understanding my Makefile. Please check if the dependency files (*.d) are correctly deleted before committing.


Import in Angular 9

import * as PIXI from 'pixi.js';
import 'pixi-layers';
doesn't work, tried a lot of other variations also but to no avail.
Please advise how we can import it with Angular 9, thanks!

as said in README,
import * as PIXI from "pixi.js";
window.PIXI = PIXI;
require("pixi-layers")

if it doesnt work for you - im sorry, i cant support angular 9 because i am not writing on angular 9 stuff. There were manuy issues with that in pixi plugins, we are working on new super-system for all plugins that will solve it.

Thanks for the quick response, I tried that as well, doesn't work. Any ETA for the new "super-system"?
Any recommendation how I could merge the two js myself to use as one combined js?

ETA - Previous year :)
Recomendation - there were a few issues with angular in main pixi repo, look in closed issues.

Thanks, I know that feeling, we wanted to launch with pixi magic two years ago! :)
But seriously, any realistic chance of having this new framework available soon? Just trying to get an idea so we can plan things accordingly. Thanks a ton!

add PIXI into script to load directly in angular.json, in build options:
"scripts": [     "node_modules/pixi.js/dist/pixi.min.js" ]
Then no need to import * as PIXI from 'pixi.js' in the project after that, just import your plugins as needed! Hope it helps!

The only way we were able to run pixi, pixi-layers and Angular was by using a custom webpack configuration to provide PIXI globally. This way webpack can also bundle up all dependencies, which would not be possible when importing the minifed script directly as stated by @lycwed.
// custom-webpack-config.js
const webpack = require("webpack");
module.exports = {
  plugins: [
    new webpack.ProvidePlugin({
      PIXI: "pixi.js",
    }),
  ],
};

// angular.json
"architect": {
  "build": {
    "builder": "@angular-builders/custom-webpack:browser",
    "options": {
      "customWebpackConfig": {
        "path": "./custom-webpack.config.js"
      },
      ...
    },
  },
  "serve": {
    "builder": "@angular-builders/custom-webpack:dev-server",
    ...
  }
}

This requires two new dependencies: @angular-builders/custom-webpack and @angular-builders/dev-server.
You can read more about custom webpack configurations in Angular here: https://www.digitalocean.com/community/tutorials/angular-custom-webpack-config

Trying to get pixi-layers plugin to work with angular & webpack, but have not success.
@ChristophWalter also tried the approach with custom webpack config, but got following error
TypeError: pixi_layers__WEBPACK_IMPORTED_MODULE_1__.Group is not a constructor
Code:
import * as PIXI from 'pixi.js';
import * as PIXILayer from 'pixi-layers';
public pixiContainer: PIXILayer.Layer = new PIXILayer.Layer();

Maybe something wrong with the imports?

Trying to get pixi-layers plugin to work with angular & webpack, but have not success.
@ChristophWalter also tried the approach with custom webpack config, but got following error
TypeError: pixi_layers__WEBPACK_IMPORTED_MODULE_1__.Group is not a constructor
Code:
import * as PIXI from 'pixi.js';
import * as PIXILayer from 'pixi-layers';
public pixiContainer: PIXILayer.Layer = new PIXILayer.Layer();

Maybe something wrong with the imports?

I don't use this package anymore, but here's how I did it :
import * as PIXI from 'pixi.js';
import 'pixi-layers';

public pixiContainer: PIXI.display.Layer = new PIXI.display.Layer();

If you use PIXI layer to use zOrder, you better use pixijs v5 and zIndex, it's what I use now ;)

I don't use this package anymore, but here's how I did it :
import * as PIXI from 'pixi.js';
import 'pixi-layers';

public pixiContainer: PIXI.display.Layer = new PIXI.display.Layer();

If you use PIXI layer to use zOrder, you better use pixijs v5 and zIndex, it's what I use now ;)

Going to try it out. The problem with PIXI zIndex is that the index only sorts all childs within a parent.
In my application i need to sort through several parents. As far as i know this is not possible with PIXI zIndex.

Going to try it out. The problem with PIXI zIndex is that the index only sorts all childs within a parent.
In my application i need to sort through several parents. As far as i know this is not possible with PIXI zIndex.

PIXI has to be somewhere in globals, in window, before pixi-layers is imported. Provided maybe, that's why i usually use require('pixi-layers');. We are fixing all that in upcoming pixi v6 very soon.

PIXI has to be somewhere in globals, in window, before pixi-layers is imported. Provided maybe, that's why i usually use require('pixi-layers');. We are fixing all that in upcoming pixi v6 very soon.


[Bug]: Table breaks with new data for a user

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
A user's app is broken
Steps To Reproduce

Open the app https://app.appsmith.com/applications/61b9da60c70f2742893b91aa/pages/61b9da60c70f2742893b91ac?isCommentMode=false
Toggle the switch between the table data
The app does not show data even though the data is valid
This works in edit mode

Environment
Production
Version
Cloud

@somangshu @Nikhil-Nandagopal @dilippitchika It seems like we have made an assumption in the table widget that the schema of the tabledata will remain the same in view mode. we were not updating a bunch of computed properties in the table widget state (columnOrder, primaryColumns, etc.) in view mode. So I have provided a fix to remove that assumption.

@sbalaji1192 can we merge this now?

@somangshu Working on the cypress test case issue. Can merge by today.

@Aishwarya-U-R I'm seeing some failure on the CI test case I wrote along with the fix. Could you help me resolve this?
My changes are available on fix/table-computedvalues-view-mode


expose client in middleware

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   99.52%   99.52%
=======================================
  Files          25       25
  Lines        1264     1264
=======================================
  Hits         1258     1258
  Misses          6        6

Impacted Files
Coverage Δ

lib/redis-cluster.rb
99.24% <100%> (ø)
:arrow_up:

lib/redis_cluster/client.rb
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d18b5...631990e. Read the comment docs.


Sibling folders are not displayed

In this storybook example the sibling folder 'Third Collapsed Folder' is not shown:
storybook url: https://leva.pmnd.rs/?path=/story/misc-folders--nested-folders
storybook code: https://github.com/pmndrs/leva/blob/main/packages/leva/stories/Folder.stories.tsx#L81

Hi, good catch!
But that's not a bug, just a poorly designed story which I'm fixing. Since the Third Collapsed Folder shares the same value keys as its sibling, it is ignored. There's a warning about this in the console, so all clear!

Thank you for your explanation! I had indeed overlooked the console warning, but that explains the problems I am having specifying the x,y,z values of many 3D objects. Is there an alternative to renaming all keys?

Yes there is. You can't use the similar keys in the same hook, but you can do:
const v1 = useControls({ xyz: {x: 0, y: 0, z: 0} })
const v2 = useControls({ xyz: {x: 0, y: 0, z: 0} })

console.log(v1.xyz, v2.xyz)

Same using folders:
const v1 = useControls('folder1', { xyz: {x: 0, y: 0, z: 0} })
const v2 = useControls('folder2', { xyz: {x: 0, y: 0, z: 0} })

console.log(v1.xyz, v2.xyz)

many thanks!


many errors in npm install

after executing npm install it shows this error:
npm ERR! Linux 4.4.0-142-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>install: node scripts/install.js
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node scripts/install.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/install.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs node-sass
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /opt/lampp/htdocs/dashboard/startbootstrap-sb-admin-2/npm-debug.log

I have the same issue on Mac

Make sure to update your npm and Node and rerun. Should be working in the most recent build

Hi,
For anyone who arrives here, I also had many errors while executing npm install on macOS Big Sur with the following amongst others:
gyp: No Xcode or CLT version detected!

I managed to get rid of that with the solution proposed here: https://github.com/nodejs/node-gyp/blob/master/macOS_Catalina.md.
Hope it can help someone else 😊

Hi,
For anyone who arrives here, I also had many errors while executing npm install on macOS Big Sur with the following amongst others:
gyp: No Xcode or CLT version detected!

I managed to get rid of that with the solution proposed here: https://github.com/nodejs/node-gyp/blob/master/macOS_Catalina.md.
Hope it can help someone else 😊


CRF as RNN with permutohedral lattice

I have implemented high dimensional filtering for dense crf with permutohedral lattice approximation.
However, I don't have time to work on reproducing crf as rnn.
The code is here: https://github.com/piiswrong/permutohedral. the GPU implementation is 20x faster than cpu version (which is taken from the caffe implementation by the original author of crf as rnn paper).
If anyone want's to try reproducing crf as rnn please let me know.
@winstywang @tornadomeet

@pluskid  refer to #337

Will do that later, bot possibly not now.

Dose anybody has  already implemented it?

@piiswrong @tornadomeet @winstywang


Ability to minimize some windows without closing the others

is there the ability to minimize only some windows and not others?

This feature is not implemented yet but it is in our roadmap.


[11.x] Auto-secure cookies

This PR auto-secures cookies as implemented in https://github.com/symfony/symfony/pull/28447. VerifyCsrfToken middleware already auto-secures cookies since it doesn't pass a fallback value false to the Cookie's secure attribute.
By passing null, the secureDefault value from the Cookie takes over.
In the prepare method of Illuminate\Http\Response (Symfony\Component\HttpFoundation\Response) , the cookies inherit the "secure" attribute from the request:
if ($request->isSecure()) {
    foreach ($headers->getCookies() as $cookie) {
        $cookie->setSecureDefault(true);
    }
}

This behavior would be a good balance between making applications "safe by default" and not breaking existing ones. It further provides a solution to the discussion in https://github.com/laravel/laravel/pull/6437

@valorin referencing to our discussion https://github.com/laravel/laravel/pull/6437, I think the required framework modification is that easy and brings a great improvement in terms of "secure by default". Adding the .env key is no longer required with this solution.

Oh wow, that's all it needs? Nice! 😁
Would it be possible to add a test or two to cover the behaviour? It feels a bit like we're passing responsibility over to Symfony with a magic value, and if their behaviour ever changes, Laravel will just inherit it without notice.
Also, updating the config file to explain null is auto could be good too.

I was surprised as well. 😄
Yes, I went back and forth with tests as it feels a bit redundant to the Symfony tests. But it's probably wise to cover it in the framework as well. Let me add some tests.

Nice work @fabricecw, those tests are great. Should let us know if anything breaks. 👍

Hi @fabricecw,
I have a question regarding an issue we're facing. Our app uses both HTTP and HTTPS, and some pages are repeatedly prompting users to log in. Could this commit be responsible for the issue?

Hi @fabricecw,
I have a question regarding an issue we're facing. Our app uses both HTTP and HTTPS, and some pages are repeatedly prompting users to log in. Could this commit be responsible for the issue?

If both HTTP and HTTPS requests access a session via the cookie, yes. The cookie inherits the Secure flag and if a cookie is secured, the browser doesn't pass it in an unencrypted HTTP request to the same site.
You have to disable secure cookies as long as you send HTTP and HTTPS requests. Either you do it in the session.php config or in the .env file (set the value to false).

Hi @fabricecw,
I have a question regarding an issue we're facing. Our app uses both HTTP and HTTPS, and some pages are repeatedly prompting users to log in. Could this commit be responsible for the issue?

If both HTTP and HTTPS requests access the session, yes. The cookie inherits the Secure flag and if a cookie is secured, the browser doesn't pass it in an unencrypted request to the same site.
You have to disable secure cookies as long as you send HTTP and HTTPS requests. Either you do it in the session.php config or in the .env file (set the value to false).

Just as an FYI for others: I encountered a similar issue in one of my projects. I was using GuzzleHttp to run custom race condition tests against my app where during the test execution login attempts are made with test user(s).
When my app is configured in production mode, HTTPS is required, and all HTTP requests are automatically redirected. All my test calls for both dev and prod configs were initially made against the same static base URL http://*:80. This setup worked fine for months but suddenly stopped functioning after updating Laravel to 11.21.0. The login part of the test suddenly returned
Client error: `POST http://[app-baseurl]/login` resulted in a `419 unknown status` response:
<!DOCTYPE html>
<html lang="en">
    <head>
        <meta charset="utf-8">
        <meta name="viewport" content="width= (truncated...)

My solution was to use a proper https://*:443 base URL for tests when running the app in production mode.
If I understand you correctly the root cause for my issue was the same as what you're describing above: i.e. that certain cookies are now no longer shared between HTTP and HTTPS calls.

@lanedirt

If I understand you correctly the root cause for my issue was the same as what you're describing above: i.e. that certain cookies are now no longer shared between HTTP and HTTPS calls.

The client will not include any Secure cookies in the HTTP request, only in HTTPS requests. In case an application for some reasons have to support mixed requests (HTTP and HTTPS) with the same cookies, the secure parameter in session.php needs to be false.


reports: include logs from nd2tool

Look for log files from nd2tool in the folders and include them in the report if found.

This will be supported in version 0.1.1


Add CLI check to RouteCollection

Description
CodeIgniter.php sets the request method on request or clirequest service, so RouteCollection needs to check the proper service to get the correct HTTPVerb to account for CLI, spoofing, and standard scenarios.
See https://github.com/codeigniter4/CodeIgniter4/issues/2021
FWIW I believe the reason this wasn't caught is that all the request & routing clauses in CodeIgniter.php have conditional ! (ENVIRONMENT === 'testing') to be able to simulate non-CLI requests from CLI. There should probably be a test that spoofs its own environment (if possible) just to check for spark integrity.
Checklist:

[X] Securely signed commits
[X] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[X] Conforms to style guide

I think a slightly better fix here is to either pass in the request instance either through the constructor or through a setter method. That removes the dependency creation back to CodeIgniter.php, where it already knows which type of request it is.

That's a good idea! I'm out for a few days but I'll take a look when I get a chance. Glad for anyone else to hop in before then.

Looking at this, get/set HTTPVerb and the $HTTPVerb property only appear to be used internally to RouteCollection and really just for getRoutes(). It is also always just a duplicate of $_SERVER['REQUEST_METHOD'] (old version) or $request->getMethod() (current revision).
Do we get rid of HTTPVerb altogether, overload the class to __construct(FileLocator $locator, $moduleConfig, $request = null) and then just use $request->getMethod() for getRoutes() fallback?

One more place for HTTPVerb, called from Router but extraneous as it is simply injecting what is loaded by default:
./Router/Router.php:390:		$routes = $this->collection->getRoutes($this->collection->getHTTPVerb());

@MGatner I've got this about wrapped up, actually. Just have one more test I have to fix up. It was a bigger change than expected. Due to the way routeCollection is used I didn't want to force a new call within route files to that, so I added it as a dependency to the Router class, which then sets the HTTPVerb on the RouteCollection itself.

Oh great! Thanks for addressing it - I look forward to seeing your solution. Any thoughts on testing (re: my original comment "FWIW...")?


feat: improve adhoc SQL validation

SUMMARY

Improve the validate_adhoc_subquery function.
I changed the logic of insert_rls. As originally written we'd pass (1) the adhoc SQL, (2) the dataset name and (3) the associated RLS predicate. In order to use it here I modified it to receive (1) the adhoc SQL with the (2) database and (3) schema where it will run. We then parse the adhoc SQL, and for each table found we check if there's an associated RLS rule; if so, we modify the SQL to include the RLS predicate(s).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TESTING INSTRUCTIONS

Updated unit tests, will add more.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

🏷  preset:2022.11


[BUG]Not compatible with tidy5e sheet?

Hi,
when mystifying an exisiting item on a tidy5e sheet i get the following js error and nothing else happens.
Mystifying in the sidebar an dragging the item to the character works as intended.
TypeError: origData is null Identification.js:13:7

I've just installed Tidy5e Sheet and it appears to be working.
may I ask for more information? What browser are you using, what other modules etc?
Also, are you using v0.1.3 of this module?

This issue does not seem to be unique to Tidy5e sheet. For me, trying to "Mystify" any embedded equipment throws an error:

Repro steps:

Create new actor (core dnd5e sheet)
On the inventory tab, add a new item by clicking the "+Add" button in one of the section headers.
Open the item and click "Mystify".
Nothing happens, and the above error is posted to console.

This also happens with items dragged from Compendia or from the Items tab in the sidebar.
Notably, an item that was previously unidentified, then added to the character sheet, then identified, does not have the button to mystify the item when opened from the character sheet, whereas newly added normal items do have the button to mystify when opened from the character sheet.

Notably, an item that was previously unidentified, then added to the character sheet, then identified, does not have the button to mystify the item when opened from the character sheet, whereas newly added normal items do have the button to mystify when opened from the character sheet.

that is probably due to header buttons not being re-rendered on item update. When you close item and open it again, button should show.
As for main issue
Ok, I got it now. I completely misunderstood what you originally mean, sorry for that. So you cannot mystify items owned by Actors or items inside compendium. You can only mystify items in World (sidebar).
To be honest, I never intended to allow mystifying embedded items, although I might just add that, why not.
So, right now make sure you have item imported into a world (in sidebar) before mystifying, in next update I will add option (or "fix" rather) to mystify from actor/compendium.

Fixed in v0.1.5.
Option to "replace with mystified item" will come in future update. Closing issue.


--lib not being respected with cargo generate

Hi,
Is it normal that I am getting src/main.rs even with cargo generate --lib rust-github/template ?

Yes, but with the latest release of cargo generate this can be solved. We have to include the file conditionally.
If you want to contribute I can explain better. Otherwise I can have this done by next week.

I can give it a shot

Oh, actually the feature was merged 10 days ago here but it is not released yet. I guess it will be released in the next version.
If you want starting working on it you can build cargo generate from the master branch. Otherwise we can wait until it is released :)
How to solve the issue
Ignore files conditionally
Here there is the documentation on how to ignore files based on a condition.
I guess that in the file cargo-generate.toml we have to add something like:
[conditional.'crate_type == "lib"']
ignore = [ "src/main.rs" ]

[conditional.'crate_type == "bin"']
ignore = [ "src/lib.rs" ]

Bump minimum version
This will be available since cargo-generate 0.10.0 ( or 0.9.1? 🤔), so you have to bump the version here.
Tip
For testing this locally you can use this.

closed by https://github.com/rust-github/template/pull/13


Bug: Different Key commands behave different to blur

I just did my first steps lexical (0.3.11) coming from slate. I still have to learn a lot to reproduce my current editor, but what I see so far is super nice I have to say 🤩.
One thing I think is probably not obvious for a new person is the handling of registered commands. I would consider it as a bug.
When I register a blur() on escape-key everything works like a charm and as expected.
    editor.registerCommand(
      KEY_ESCAPE_COMMAND,
      () => {
        editor.blur();
        return true;
      },
      COMMAND_PRIORITY_EDITOR
    );

but when I register a blur() on enter-key I don't get the blur.
    editor.registerCommand(
      KEY_ENTER_COMMAND,
      () => {
        editor.blur();
        return true;
      },
      COMMAND_PRIORITY_EDITOR
    );

My intention is at the end to have a one-line input-field with some additional functionality. So, I would like to have on the enter-key the blur, and later I would also clean up the text entered by copy/past.
If there is a good reason for this behavior, please apologize for the buzz.

In the enter key command handler, what if you also do event.preventDefault()?

@trueadm I also tried event.preventDefault() but was not successful.
@yatagasaru that was totally it! thanks a lot with
    editor.registerCommand(
      KEY_ENTER_COMMAND,
      (event) => {
        event.preventDefault();
        editor.blur();
        return true;
      },
      COMMAND_PRIORITY_LOW
    );

I was able to achieve the required behaviour. I returned for now true becaue I would like to have it «handled» and finish the dispatch for this command.
Thank you two! This was very helpful and super quick!
(ps: I added on #2845 a note to improve the documentation for the priority. It was clearly me not understanding what the priority-levels mean. If you have a link or something for me I can also add it myself to the documentation and send a PR)


User Login via PSU LDAP

As a Penn State student,
I would like to login with by normal credentials,
So that I don't need a separate account to save items in CHO.

Shibboleth not cosign

Need to switch out our devise modules to use Shibboleth

Enhancement to #350 that allows additioanl role -- logged in user for things like saving citations and bulk download.

The minimal implementation may use LDAP and psu_dir gem.
The ideal implementation would use Shibboleth/OneId. This would give us the most flexibility in terms of granular permissions later on. Would need to wall off Friends of PSU, Hershey Medical, and Penn College from accessing restricted collections. (Unless stakeholders sign off.) Would also enable us to achieve #181 and #195. ITECH is looking at using OpenAthens for Shibboleth/OneId.
If implementing using the second option, this ticket should be repointed.

Related: #798

TODO:

use Cancancan gem to determine access level (admin vs. non-admin)
restrict access to menu options: manage, create work and collection
read-only access to everything else


Move sync error JSON models into the shared models file

No functional change.

Both CI failures are spurious.

All three CI job failures are timeout failures.


Test React Testing Library patch

Testing https://github.com/testing-library/react-testing-library/pull/1137

Looks good


:bookmark_tabs: Add document outline mobile view

Fixes #363 by moving the document outline to the main body of the page.

I've added a new types.ts file that declares the template option interface.
I've moved ArticlePage from @myst-theme/site to themes/book (to mirror the one already copied to themes/article.
I've added hide_outline and outline_maxdepth to the article theme options

I need to understand why the article theme has its own implementation of ArticlePage, instead of re-using that from @myst-theme/site. Perhaps @stevejpurves could shed some light? :)

@stevejpurves I've replicated the DocumentOutline logic for both article and book themes; now, only the article differs in that it has supporting downloads too.
It feels like Article is a fairly high-level component that is theme specific. I wonder if we should just move Article from @myst-theme/site into the book theme (such that the article and book themes have their own independent versions). What do you think about that suggestion? Is there something I'm missing?

OK, I decided to make that change; I assume that as we built out the themes, it became clear that the article theme needed its own ArticlePage, and from there we have been left with the type in @myst-theme.

I've seen that this is a place where we have project, site, and page frontmatter. I haven't gone through these changes super carefully, so any reviewer would be welcome to cast an eye.

We have 3-4 themes that are dependent on that export from site, anything in book/article cannot be exported.

Hmm, OK. @rowanc1 can you nudge on whether the core site export should include this change, or whether I should fork it for the book export?

Sure, that's an idea! It might just be that the difference between the two is the addition of downloads.

@rowanc1 I'm actually thinking that we shouldn't try and have an ArticlePage in the site package. These article pages are built from published components, so users can already re-implement them fairly easily. I think the differences between articles and book pages should better be described by distinct components instead of a "meta" component that encodes the logic for both variants.
Are you OK with that change; dropping the Article from @myst-theme/site?

@agoose77 I think that suggestion was not to have a single ArticlePage meta component that encoded both sets of changes but indeed to have two distinct page components available in site by moving the article-theme version up to the package too?
That's leaves us with some naming to sort out but then provides two jumping off points for existing page patterns to be used in downstream themes...?

@fwkoch this is a really helpful review, thank you (and also to @rowanc1).
Could you perhaps help nudge this over the line with the deprecation logic?

Are you comfortable merging this? Or would you like a separate review e.g. from @stevejpurves?


Unreviewed commit on master!

Unreviewed commit(s) COMPARE was merged to master by oorion.
Comment with appropriate number of :+1: to approve.

Minimum Reviews
0/1

More info

+1

Minimum Reviews
1/1

zquestz
1

Pull request is reviewed and can be merged to master!
More info


[v7] Skip csc and erf tests for scipy>1.2

Fix CI errors

Jenkins, test this please

Jenkins CI test (for commit 7820c5996da1ffcc7f88ae7ae65c49b30c36d3f8, target branch v7) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit c4879c1c57f07b3ca26274a6cf0b7a74b24a1816, target branch v7) succeeded!


Twitter or Facebook embed inside container - scroll whole document

Hi,
I placed Facebook embed as iframe inside scrolled container.
Now plugin doesn't work propertly. When I try to scroll while mouse is over that embed it scrolls whole document - not only content in that container as expected.
Is there a way to prevent that effect ?
Thanks in advance.

My first thought would be that you haven't initialised the container properly, or have forgotten to add position: relative to the container.
Could you share a jsfiddle reproducing the issue? You can fork one of the jsfiddles mentioned in the readme

Here you have a jsfiddle.
https://jsfiddle.net/9pz5p0rh/
That example works fine on Edge 13.
On chrome 51 works only with Twitter embed.
On Firefox 47 doesn't work at all.

Thanks for that.
It seems to be an issue with having an iframe inside the perfect scrollbar container.
This is not specific to the facebook and twitter widgets.
It looks like the iframe scroll event does not bubble up to its parent in several browsers.
I found this discussion referring to the issue in firefox.

Closing due to inactivity

I'm with the same issue, anybody knows how to fix it?


cue/load: Config.Dir docs are out of date

Looks like this documentation need an update:
https://github.com/cue-lang/cue/blob/87408d7d0c61bf6ff2711fd202727639aac97290/cue/load/config.go#L153-L156

For some context: the problem here is that CUE has no "build system query tool" - this is carried over from go/packages.


Regenerate all 3D gamut images with true 3D models

Finally worked on generating proper 3D models. We should play around and generate all of the images with these better model approaches. We can possibly add light and shadow, but we'll see. We now create proper meshes so we can generate models. This means we don't have to do many of the workarounds to fill in spaces that we used to.
We can now generate wireframes at differing resolutions:

We can generate 3D models of differing resolutions:

We can even generate using our old scatter plot approach at various resolutions.

We did play around with Plotly. The 3D models are fast and smooth, but there doesn't seem to be a way to color them with the color space gamut. All you can do is use a color scale to color them based on an axis. If we ever figure out how to color them proper, it's something to consider. If all you care about is the color space shape though, it is pretty cool.


MM-19909 Fix for scroll pop with markdown images

Summary

There was a change with inherited classes https://github.com/mattermost/mattermost-webapp/pull/3639 on . markdown-inline-img causing this issue
The change of .markdown-inline-img was added to div intentionally to apply for div wrapper to match the styles of img which is going to be replaced when it loads. Reverted the change

Changing the width of svg to inherit to occupy the space as needed. This wasnt needed earlier but some of the recent changes made this a requirement.

Ticket Link
https://mattermost.atlassian.net/browse/MM-19909

@deanwhillier About the other changes discussed. I will be making another PR to master as we don't need them to be in 5.17v

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4164.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed


Stopped working on Notepad++ version 7.6

Hi, I use your work for several years. Right now Notepad++ changed the way it manages plugins. Is it possible to fix it? Thanks anyway.
Havilson

Hi @havilson, unfortunately I don't even have a Windows desktop anymore so fixing it is unlikely! Hopefully someone who does can make a PR

Thanks @DominicTobias for your answer, let's hope someone could help. :)

@havilson Most likely you are just facing the issue described here:
https://notepad-plus-plus.org/news/notepad-7.6-released.html

FOR PLUGIN USERS:
to remedy this problem, after the update, you can :
Find the name of plugin you want to migrate in %PROGRAMFILES(x86)%\Notepad++\plugins\myAwesomePlugin.dll (or %PROGRAMFILES%\Notepad++\plugins\myAwesomePlugin.dll, according the achetecture of your Notepad++).
go to %LOCALAPPDATA%\Notepad++\plugins\ to create myAwesomePlugin folder.
move the plungin myAwesomePlugin.dll from %PROGRAMFILES(x86)%\Notepad++\plugins\ to %LOCALAPPDATA%\Notepad++\plugins\myAwesomePlugin.
That’s it. Restart Notepad++ and you get your beloved plugins back.

Is the plugin working again after moving it to the new plugin directory under the subfolder SecurePad?

Added to plugin admin list with https://github.com/notepad-plus-plus/nppPluginList/commit/b7d6801aa00187bb431313b0b3ee123f50e3ab2e.

@chcg worked like a charm, should have read it before. Thanks anyway!


[Tracking] Implement Watershed Algorithm

This issue is related to #49 and would like to discuss and track the issue here.
(@grlee77 Please feel free to edit/update this description).
Tracking

Currently collecting information for deciding a proper approach/implementation.

Problem
Watershed algorithm in scikit-image (https://scikit-image.org/docs/dev/api/skimage.segmentation.html?highlight=watershed#skimage.segmentation.watershed) is a popular algorithm for segmentation. However, cuCIM doesn't support it so would like to provide the algorithm through cucim.skimage.segmentation.watershed method.
It turns out that using the same algorithm used in scikit-image with CuPy is not feasible or tricky to implement:

The watershed itself is implemented in Cython and uses a heap data structure where the elements on the heap are small structs which is not GPU-friendly.

Candidate Implementations
There are some GPU implementations:
1. 2D implementation based on cellular automata in recent NPP

https://docs.nvidia.com/cuda/npp/group__image__filter__watershed__segmentation.html
Based on Efficient 2D and 3D Watershed on Graphics Processing Unit: Block-Asynchronous
Approaches Based on Cellular Automata

2. A different GPU-based algorithm with corresponding citations at watershed-cuda

https://github.com/louismullie/watershed-cuda
Can be used under Appach 2.0 license (see https://github.com/rapidsai/cucim/issues/49#issuecomment-864256934)

3. CLIJ's approach

https://clij.github.io/clij2-docs/reference_watershed
Its implementation has some issues (delivers results of limited quality) so alternatives are recommended (see this link)

Hi there, forgive my intrusion on following questions, as this is my first appearance on the repo. What criterion do you adopt to compare between algorithms?
Since it's about GPU implementations - performance should be one of them. This paper also measures average wall clock time / element (besides wall clock time on image size).
In terms of quality, do you consider over-segmentation problem here? An issue we can alleviate by preprocessing or use provided markers.

It would really be great if the implementation supports passing markers (similar to scikit-image's implementation). We make use of the markers extensively in our package porespy.

Hi there, just wanted to see if this feature is being worked on. Thanks!

Hi @ma-sadeghi, Thank you for following up on the issue!
We currently don't have the bandwidth to work on it but we'll keep an eye on this feature as the watershed algorithm is widely used.
/cc @grlee77

I would be interested in using this feature.


[CELEBORN] Fix push small data

What changes were proposed in this pull request?
How was this patch tested?


[FEATURE]: Endpoint for submitting "In-Person Events" and "Virtual Events" Application forms

Current Situation
The application forms for in-person and virtual event badging are being developed for integration into the badging website. However, there is no backend endpoint to handle the submission of these forms, which is essential for processing user applications.
Proposed Solution
Develop an API endpoint that handles the submission of the in-person and virtual event badging application forms. This endpoint will collect the form data, convert to a markdown format and create an issue for the applicant on the events-diversity-and-inclusion repo using the user's GitHub authentication. This is related to this issue
Benefit
Seamless Data Handling: Allows the badging application to submit form data directly, ensuring no disruption in the user journey after form submission.

@DesmondSanctity pinging you on this

Noted @adeyinkaoresanya .


Landing page broken links

🗄 Docs report
Landing page books links are broken
Description
When clicking on the Book links nothing happens.
🔬 Minimal Reproduction
N/A
What's the affected URL?**
https://scully.io/
Reproduction Steps**
N/A
Expected vs Actual Behavior**
The links should redirect to a proper route
📷Screenshot

🔥 Exception or Error
N/A

🌍 Your Environment
N/A
Browser info
N/A
Anything else relevant?
N/A

@GuzmanPI By checking the links on the landing page, i noticed there is no existing route for the 'Contribute' button

@GuzmanPI make sure we get another ticket for what Gerome is saying.

@aaronfrost @GuzmanPI i opened #719 for the Contribute link.

@GuzmanPI Is this done?


Pasting over selection skips cursor

Using v5 at https://stackedit.io/app
Steps to reproduce

write some text, e.g. foo bar baz
copy something into clipboard, e.g. nom (length matters!)
select a piece of the written text, but

either by clicking at the end and dragging backwards
or by moving the cursor to the end, holding shift and moving backwards

paste "over" the selection (Ctrl-V)

Expected behaviour

the selection is replaced with the clipboard
the cursor is at the end of the pasted part

Actual behaviour

the selection is correctly replaced with the clipboard (good!), but
the cursor is N characters after the end of the pasted part, where N is the length of the replaced (selected) piece of text

(Note that this is indeed a different bug from #818, though maybe related)

Shoud be fixed in v5.8.


Protein hashing concerns

Currently we're using rdkit's Chem.MolToSequence as a first pass of hashing a ProteinComponent.  This might not cover everything, so some thought is required.

See also https://github.com/OpenFreeEnergy/openfe/pull/98


Added support for Capital Letter module names; Release v0.3.1

Fixes https://github.com/bwplotka/bingo/issues/65
Signed-off-by: Bartlomiej Plotka<EMAIL_ADDRESS>

@bwplotka LGTM. Just tested it out locally, works like a charm!

Sweet!


Fixing issue #1126

Update spark-pi-prometheus.yaml

Update spark-pi-schedule.yaml

Fixing issue #1126

Fixing issue #1126

@googlebot I signed it!

@googlebot I signed it!

No response from team.