Doesn't pick a theme

Colors in a build result are always black. Changing a theme doesn't affect the colors.

Environment:

Atom 1.5.4
OS X 10.11.3
build 0.56.0 (the bug exists since this version)

Sure the problem is in term.js that was picked up in https://github.com/noseglid/atom-build/commit/fe7e2c2b04425831706c622b1ebfb7bd2180a7b4. Now I don't see many advantages in this package over tons of packages that somehow use term.js. Before this we had had a lot of control of output.

This is a doozy. The "terminal" defines colors as "red" and "blue", which doesn't really match with a theme since they "set the colors of borders, text etc".
What a theme may want to do is redefine what "red" means, but this also means it may deviate from what the creator of the CLI tool intended.
Now maybe we should have a way to override the colors for themes. This would include changing term.js to add classes to colored output rather than actually setting the style attribute.
Either way, I'm all for adding ways to control the color.
I hope there are other good qualities with this plugin than the control of the colors in the build output :)

I hope there are other good qualities with this plugin than the control of the colors in the build output :)

I'm sure that many people use this package only as a test runner. Features in this package that are useful:

You run a command and if it's green a windows disappears, if not it stays
You have commands per project (rspec {FILE_ACTIVE} for Ruby, ant test for Java, etc.)
The package has potential: you can create error file paths clickable, you can add a test summary block (like in IDEA IDE). Because of this potential we had right colors in an output

For now the package doesn't have the point 3. Points 1 and 2 people can emulate with terminal packages (they have many features but as this package they have the same huge problems with colors).

Now maybe we should have a way to override the colors for themes. This would include changing term.js to add classes to colored output rather than actually setting the style attribute.

Do you really think that it's possible? If it is I'm not sure that it's easy. Spacemacs uses just buffers for command output (not a terminal), vim doesn't use a terminal for this, IDEs sure don't use a terminal for this. But of course they can do it if they wanted. But why should they do it? What are pros for this?

The primary reason are all the controls sequences, which gives the ability to produce a very rich console output. Of course it's possible to add classes to the output of term.js.
These tools were (almost always) built to run in a terminal, that's why I want to run them in a terminal.
As long as the features you deem valuable goes, I value a few others too: specify ways to run tools which rely on multiple environment settings, having a compiler re-compile on change and show the state next to the code I edit, etc. I'm sure other people have other uses/needs.

Thank you for your extended response. Hope the functionality of coloring an output properly will be easy to return.

Thank you for taking the time to report this and voice your concerns. This is how we become better!

Had to downgrade to 0.55.0 again, I see the reasoning behind using a terminal, but a black background with almost not readable grey fonts, no coloring or underlining on my machine makes the whole package not very useful, which is a pity.

@TarrX Could you detail what you mean with almost not readable grey fonts ? A screenshot perhaps?

I've thought more about this, and setting the background on the terminal to whatever the theme defines as background on a panel is quite easy. I'll try and get around to that soon.
However, ANSI colors are defined as being on a black background - but you already seem to be happy with the end result, so a configuration for "forcing black background" or "using theme default" seems to be in order.

Hi,
Just to add my 2 cents. Indeed the last update of the plugin brought a not-so-nice visual difference with the preceeding version I was quite happy with. See the black background with "almost not readable grey fonts" (meaning I can relate to that comment ;-) ) in the attached screenshot.

Hello @aphecetche
Thanks for your input. If you add
.build .output {
  background-color: unset;
}

To your custom stylesheet (Command Palette > Application: Open Your Stylesheet). Is this the visuals you'd expect?

Absolutely. Thanks.

Works. @noseglid, thanks.

I'll add an option to override the theme's color with black. That way one can opt out and have the theme colors instead.

I recently updated to the newest version (not sure which version I was on previously), and the terminal has some really gross fonts now.

Do you think this is a related issue to what @TarrX and @aphecetche were experiencing or something else?

@tesselode It's something different, but what you found was addressed in #340 which is already merged. It can hopefully have a release out alter today

Sorry for the late answer, my visual experience is basically the same @aphecetche and @tesselode has. I am using ArchLinux and OneLight as UI and Syntax Theme.


Create a test environment for Tensorflow object detector

Description
Create a test environment for Tensorflow object detector.
Fixes #1034
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[ ] Test A
[ ] Test B

Test Configuration:

OS
Python version
ART version or commit number
TensorFlow / Keras / PyTorch / MXNet version

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report

Merging #1208 (3103880) into dev_1.7.1 (cb98391) will decrease coverage by 30.92%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           dev_1.7.1    #1208       +/-   ##
==============================================
- Coverage      63.65%   32.72%   -30.93%
==============================================
  Files            229      230        +1
  Lines          21108    21150       +42
  Branches        3947     3950        +3
==============================================
- Hits           13436     6922     -6514
- Misses          6076    13409     +7333
+ Partials        1596      819      -777

Impacted Files
Coverage Δ

art/wrappers/wrapper.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/wrappers/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/wrappers/query_efficient_bb.py
0.00% <0.00%> (-95.84%)
:arrow_down:

...rt/defences/detector/poison/clustering_analyzer.py
8.22% <0.00%> (-86.71%)
:arrow_down:

...ces/detector/evasion/subsetscanning/scanningops.py
11.59% <0.00%> (-85.51%)
:arrow_down:

art/wrappers/expectation.py
0.00% <0.00%> (-74.47%)
:arrow_down:

...ient_descent/projected_gradient_descent_pytorch.py
14.89% <0.00%> (-73.76%)
:arrow_down:

art/metrics/verification_decisions_trees.py
13.68% <0.00%> (-73.16%)
:arrow_down:

art/metrics/privacy/membership_leakage.py
12.72% <0.00%> (-72.73%)
:arrow_down:

...escent/projected_gradient_descent_tensorflow_v2.py
16.29% <0.00%> (-71.12%)
:arrow_down:

... and 121 more


Prevent accidental testing of duplicate LINQ members

This PR addresses #351.
The strategy taken in the initial commit, 8871edb14fd7f5f1148fbde8c81b819c277c8fe8, is to have an Enumerable type act as a proxy for System.Linq.Enumerable and forwards all calls. This allows all LINQ extension methods to be used without importing System.Linq, which is now only done in one place (Enumerable.cs in the test project). It also enables a controlled way to manage conflicts by not having any of the duplicate members defined on the Enumerable proxy. For example, since it doesn't define and wrap TakeLast that was introduced in .NET Core 2.0, we know for that the unit tests for MoreLINQ's TakeLast won't accidentally test the LINQ implementation (which happened in #304).
This is not a fool-proof approach because it requires being careful that no one imports System.Linq in a file with a test fixture. This is something that would have to be caught during PR reviews. A grep should also be quick to conduct and shouldn't reveal any other file than MoreLinq.Test/Enumerable.cs:
$ egrep '^ *using +System\.Linq;' MoreLinq.Test/*.cs

An alternative approach would be to move the System.Linq imports in each unit test file outside the MoreLinq.Test namespace declaration, as was done in 88967853e005a9f20100948a70525bb33b3bc289 for #304. It's a little less involved but requires equal care during reviews.

An alternative approach would be to move the System.Linq imports in each unit test file outside the MoreLinq.Test namespace declaration

I prefer the current approach over this one, because import preference, while being well defined, is a rarely used[1] feature, so its importance is easy to forget/overlook. The current approach is easier to hook into the buildsystem too.
[1] At least by me. YMMV of course.

I would like the test you suggested be integrated into the CI runs

@fsateler Good idea & done. We good to merge & close this?

Too bad a download is needed in order to user grep, but I guess that is not avoidable ATM.

Sorry, I just looked this up. It appears msys is preinstalled . Can't we use that?

Too bad a download is needed in order to user grep, but I guess that is not avoidable ATM.

It's not really needed because I could have using -match from PowerShell but in an initial cut I just wanted to get it working while maintaining parity between the Windows and non-Windows versions. We can improve with time.


Budgets Service and Persistence

Customers can create a budget from a shopping cart. This generates a QR with the budget's reference.

340 lines of code


Fix "Ready" status that is missed if token validation takes more than 1s

Fixed: repeat a status check every 0.5s during 10s max

Looks good, I'll merge.

Your welcome, thanks for your work! :100:
We started our app for iOS first, I will check if there is the same issue with Android next month.


nixos/nixpkgs: Properly validate and merge nixpkgs config

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

allowUnfreePredicate should have a better type:
# configuration.nix
{ lib, ... }: {
  imports = [
    {
      nixpkgs.config.allowUnfreePredicate = pkg: builtins.elem (lib.getName pkg) [
        "zsh-abbr"
      ];
    }
    {
      nixpkgs.config.allowUnfreePredicate = pkg: builtins.elem (lib.getName pkg) [
        "slack"
      ];
    }
  ];
}

$ nix-instantiate --eval nixos --arg configuration ./configuration.nix -A config.nixpkgs.config.allowUnfreePredicate
<LAMBDA>

$ gh pr checkout https://github.com/NixOS/nixpkgs/pull/272686
Switched to branch 'feat/type-nixpkgs-config'

$ nix-instantiate --eval nixos --arg configuration ./configuration.nix -A config.nixpkgs.config.allowUnfreePredicate
error: The option `nixpkgs.config.allowUnfreePredicate' is defined multiple times while it's expected to be unique.

Definition values:
- In `/home/tweagysil/src/nixpkgs/main/configuration.nix': <function>
- In `/home/tweagysil/src/nixpkgs/main/configuration.nix': <function>
Use `lib.mkForce value` or `lib.mkDefault value` to change the priority on any of these definitions.

Haskell would call that Any, which adds "or" monoid semantics to Bool. Just a mergeable bool type.
Let's keep something more recognizable in the name though.
functionTo boolOr?
functionTo boolWithOr?
functionTo disjunction?
functionTo disjunctiveBool?
functionTo anyBool?

https://github.com/NixOS/nixpkgs/pull/272764


Replace nativeCryptoCurrencyPrices and nativeCryptoCurrencyBalances with fetching balance and rate with balanceCoordinator #4063

Closes #4063

The PR removes dependency from  serverDictionary of native crypto balances and native prices, and uses source balance coordinator to fetch data


yarn install nuxt with warnings

Version
v2.10.2
Reproduction link
https://www.google.com
Steps to reproduce
just yarn install
What is expected ?
No warning
What is actually happening?
warning nuxt > @nuxt/webpack > webpack > watchpack > chokidar ><EMAIL_ADDRESS>One of your dependencies needs to upgrade to fsevents v2: 1) Proper nodejs v10+ support 2) No more fetching binaries from AWS, smaller package size

This bug report is available on Nuxt community (#c10010)

Caused by a nested dependency in chokidar. https://github.com/paulmillr/chokidar/commit/7c79e45f83b52084d03940ed882e0279e1c23b5f is already present but no release yet so we have to wait :relaxed:


fix: omitted severity flags in docker image scan action

Update to Step "Generate docker-cis JSON report", removed severity flag as it was causing warnings "unknown severity option: unknown severity: FALSE"
Update to Step "Inspect docker-cis report", removed severity flag as it was causing warnings "unknown severity option: unknown severity: FALSE"
This severity flag is not being used at this point. Trivy uses this flag to restrict the scan to specific severity levels
Because of no explicit severity flag, shared action uses value of global_enforce_build_failure env defined in our scripts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@pankajmouriyakong  pls sign-off the commits  as CLA requirement and follow comment


Upgrade webpack-dev-server to v5

Migration guide: https://github.com/webpack/webpack-dev-server/blob/master/migration-v5.md

Closed in 555191635faee50d0


Request- Deprecation warnings and stability between releases

Hi Team,
This package is awesome, and we use it a lot. It's become our default gradient boosting implementation at work. The training speed in particular is astounding.
I was disappointed to find that the latest release had two changes that broke our existing code: The type of data inputs accepted changed, throwing ValueErrors, and the .best_iteration attribute disappeared, throwing an AttributeError. Unfortunately, I remember something pretty similar from the previous patch release, though I forget exactly what the issue was now.
I'm all for progress! One of the things I like about this package is how rapidly everyone's developing on it. But it's marked as 'Development Status :: 5 - Production/Stable', and that means that code that's written using lightgbm one patch ago (2.0.6) should definitely work with this patch (2.0.7).
Generally, I'd expect Deprecation warnings, or FutureWarnings, or UserWarnings for at least 2 minor versions (2.0.x - > 2.2.x), and ideally one major version, before a release that breaks existing codebases.
I know that it's a bit more work. It possibly means setting up a test environment that runs your tests on multiple releases of your code. It definitely means a couple more if statements to check for things like if the user is trying to access a soon-to-be-removed attribute, and returning to them the new attribute, and a warning.
But that's what you signed up for with 'Development Status :: 5 - Production/Stable'. If you want to be able to release breaking changes, there are other Development Statuses for that, and we'll adjust our code to be more cautious accordingly.
Again, thanks for the great package! It's vastly sped up our iteration speed at work; it's as accurate as anything else out there that we've found; it's got great use in analytics projects too with .feature_importances_. I'm a loyal evangelist.

Thanks for your suggestions. We don't have much experience on this and will be careful in the future.
Btw, what's exactly the two changes you refer to (The type of data inputs accepted changed & the .best_iteration attribute disappeared)? Do you mean in sklearn interface?

Sorry that you had problems with LightGBM's backward compatibility. From my side I confirm that

we will do our best in the future.

As a typical user, I can remind you that you can fix versions of dependences of your software. It's very useful when you have dozens of them. And then you periodically do review of dependences and in case of "all OK" increment the version of the corresponding dependence.

Thanks for the responses, y'all!
@wxchan you nailed it- i'm using the sklearn interface.
as always, with open source software, it's all a bit buyer beware, but i thought i'd mention it so y'all knew how much people were using and depending on your project.
thanks always for the great work. we're very glad to be using it :)


Version of repos set to avoid error when compilating for UWP

Hi @esteve ,
I set the version in ros2_dotnet_uwp.repos because master versions make errors during compilation.
Hope it helps!!

Actually, if you want to follow the instruction in readme.md you also need to add the repos in ament_dotnet_uwp.repos to this file, but it would break the CI. What do you think @esteve ?

Thanks!


Events for indexer

Upgrade Resource
Realm_id: 3
Resource_id: 1
Level: 1
https://goerli.voyager.online/event/184426_5_1
Build Building
Realm_id: 3
Building_id: 16
https://goerli.voyager.online/event/184202_9_2

Resource Upgrades and Buildings are live
https://dev-indexer-gu226.ondigitalocean.app/graphql
query {
  getRealm(realmId:3) {
    name
    resources {
      type
      level
      upgrades
    }
    buildings  {  type }
  }
}


Add helper function to observe multiple signals

In https://github.com/DiamondLightSource/hyperion/issues/1450 we had the usecase where we wanted to monitor multiple signals and raise under one condition or stop monitoring cleanly under another. To aid in this it would be good to have an ophyd-async helper that observed multiple signals and gave you any updates that occured e.g.
async def pin_mounted_or_no_pin_found(self):
      async for signal, value in observe_signals_value(self.error_code, self.goinio_pin_sensor):
          if signal is self.error_code and value == self.NO_PIN_ERROR_CODE:
              # We didn't get a pin
              raise RobotLoadFailed(self.NO_PIN_ERROR_CODE, "Pin was not detected")
          elif signal is self.goinio_pin_sensor and value == PinMounted.PIN_MOUNTED:
              # We did get a pin
              break

Do we also want to rename observe_value -> observe_signal_value to make them more consistent?

Actually, I'm going to roll back on this, and say this ticket is just to add observe_signals_value

We're deciding between two options for when to return the status:
Option A: Return status when the match signal changes to the expected value.
Option B: Return status when the signal changes to the expected value.
Both signals start at 0 and are expected to change to 1. The question is: Should we trigger the status return based on the match signal (A) or the main signal (B)?

You're asking in relation to set_and_wait_for_other_value, right? Not observe_signals_value, which I think this issue is more aimed towards? I didn't think observe_signals_value needed to be given any match values.
If it's about set_and_wait_for_other_value then I think we should return based on A as that's what the name implies and what most of my usecases are. An example use case:

I set ACQUIRE to Do Acquire
I want to know when the hardware is acquiring, for this I need to wait on ACQUIRE_RBV to go to Acquiring
ACQUIRE will probably go to Do Acquire immediately on set (depending on the callback logic on the hardware side I guess) but I'm only sure the hardware is acquiring when the AQUIRE_RBV says so, which could be a while later.


SSL force in locally hosted Spoolman QR code scanner

Hi,
Is there any specific reason why I'm unable to use QR scanner in self hosted, on my own, local server in forced SSL mode? Container don't have access to internet, there's absolutely (in my case) no need for SSL except for extra hassle, but I'm unable to use it.
Is there any switch to add to docker compose to turn off that requirement or something, or I really have to create certs, etc. just to access it locally?

Hi, this is not a limitation of Spoolman, but from the browser itself. Unfortunately, there is nothing that can be done to solve this.

Ok it sounds a bit odd, I'm using tens of for example home assistant stuff that work only locally in docker and these don't require SSL, so saying it's browsers requirement sounds a bit odd, unless there's some specific component that requires it...

Accessing a camera and microphone is limited to HTTPS only. See: https://blog.mozilla.org/webrtc/camera-microphone-require-https-in-firefox-68/


Issue using PFX as a Key in a linux container

Just created a fresh AspNetCore SPA app using the template.
Changed the appsettings.Production to have prod values :
"Key": {
"Type": "File",
"FilePath": "./Keys/oidc_prod.pfx",
"Password": "xxx"
}
Runs perfectly using on Windows, i can confirm the serial number in the wellknown jkts endpoint versus the certificate details.
When i do all of this in a docker container (base image mcr.microsoft.com/dotnet/aspnet:5.0). Then i get this error.
Application startup exception
System.InvalidOperationException: There was an error loading the certificate. Either the password is incorrect or the process does not have permisions to store the key in the Keyset 'EphemeralKeySet'
---> System.Security.Cryptography.CryptographicException: The certificate data cannot be read with the provided password, the password may be incorrect.
---> System.Security.Cryptography.CryptographicException: A certificate referenced a private key which was already referenced, or could not be loaded.
I have verified that the file is present. If i remove the appsettings.Production.json file (to fallback to a developer key) it also works in the container. Doing openssl pkcs12 -info -in oidc_prod.pfx works perfectly (asking me the password).
What can be wrong ?

This seems to be related to Microsoft's IdentityServer integration. Please open an issue on their issuer tracker instead. @javiercn @blowdart
https://github.com/aspnet/aspnetcore/issues

Thanks ! just posted there : https://github.com/dotnet/aspnetcore/issues/28709


Remove unused import

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description:
Minor issue from Daniel's feedback:

from_gdk_packages/com.improbable.gdk.movement/movement.proto: warning: Import from_gdk_packages/com.improbable.gdk.core/common.proto but not used.

Testing:
Codegen produces valid output, no complaints

Copying offline discussion: tried IntDelta but codegen complains


Dockerized d-zone

Hello,
Is there a chance that this project will be dockerized. That way it would be easier to have it behind a reverse nginx proxy and providing it with https that way.

I have no current plans (never used docker) but would be happy to accept a PR! I understand the benefit of using a reverse proxy.

I've created a docker image here: https://hub.docker.com/r/nntin/d-zone
In order to run the docker image you need to provide a discord $TOKEN:
docker run -e TOKEN=$TOKEN -p 3000:3000 nntin/d-zone
I'm creating a pull request after @vegeta897 created a docker branch since I removed some code (http and ws secure) and added some code (autopopulate) to ensure you don't need to touch the config files.
If you are wary about the image you can vet and build the docker image yourself;
https://github.com/NNTin/d-zone/tree/docker

Thank you @NNTin, I will close this for now.
As discussed on Discord, our aim in the near future is to make the main branch compatible with docker (and heroku)


minor fixes to message usage

changed MESSAGE_USAGE for EditTutorialCommand
changed MESSAGE_USAGE for EditReminderCommand

Codecov Report
Base: 52.82% // Head: 52.82% // No change to project coverage :thumbsup:

Coverage data is based on head (94f456c) compared to base (edc2048).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     52.82%   52.82%
  Complexity      708      708
=========================================
  Files           159      159
  Lines          3182     3182
  Branches        388      388
=========================================
  Hits           1681     1681
  Misses         1356     1356
  Partials        145      145

Impacted Files
Coverage Δ

...s/logic/commands/reminder/EditReminderCommand.java
0.00% <ø> (ø)

...s/logic/commands/tutorial/EditTutorialCommand.java
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Transaction] Txn marker channel handle optimize

Motivation
End transaction asynchronously.

https://github.com/streamnative/kop/pull/411 fixes this issue.

Overall LGTM, just leave two comments


Wrong formatting in CONTRIBUTING.md - Git conventions

In the Git conventions section of the CONTRIBUTING.md file, the last item is wrongly formatted cf

It should be:

section:

it is optional
It is an extension of the section used to add a longer description about the changes if relevant

Also, why the name is section and not <body> instead?

done


Layout does not scale correctly sometimes

A few times the "O" key menu has opened and it was cut off in the screen because the windows was only half of the width. This is probably related to a few of the web engine issues related to Wayland but there is probably a way to fix it with a little bit more resilient CSS.

Can't reproduce this issue anymore.


Mock for dependent list is created but not injected into entity

Description
linkedListSpy is created and configured, but not injected into Entity under test
To Reproduce

Install -IU- UnitTestBot plugin  in IntelliJ IDEA
Open spring-petclinic
Generate Unit tests for Owner with PetClinicApplication configuration
Run the tests

Expected behavior
No NPE should be thrown from get-methods of the entity before assertions.
Actual behavior
There are several tests throwing NPE when getting fields of actual Pet.
Screenshots, logs
	@Test
	@DisplayName("getPet: id = zero (mutated from min)")
	public void testGetPetWithCornerCase5() throws ClassNotFoundException, IllegalAccessException, NoSuchFieldException, InvocationTargetException, NoSuchMethodException {
		owner.setLastName("-3");
		Pet petMock = mock(Pet.class);
		(when(petMock.isNew())).thenReturn(true);
		linkedListSpy.add(petMock);
		Pet petMock1 = mock(Pet.class);
		(when(petMock1.isNew())).thenReturn(false);
		(when(petMock1.getId())).thenReturn(0);
		linkedListSpy.add(petMock1);
		Pet petMock2 = mock(Pet.class);
		linkedListSpy.add(petMock2);
		Pet petMock3 = mock(Pet.class);
		linkedListSpy.add(petMock3);
		Pet petMock4 = mock(Pet.class);
		linkedListSpy.add(petMock4);

		Pet actual = owner.getPet(0);

		LocalDate actualBirthDate = actual.getBirthDate();
		assertNull(actualBirthDate);

		PetType actualType = actual.getType();
		assertNull(actualType);

		Set actualVisits = ((Set) getFieldValue(actual, "org.springframework.samples.petclinic.owner.Pet", "visits"));
		assertNull(actualVisits);

		String actualName = actual.getName();
		assertNull(actualName);

		Integer actualId = actual.getId();
		assertNull(actualId);

	}

Environment
IntelliJ IDEA version - Community 2023.2
Project - Maven
JDK - 17
Additional context
When debugging, linkedListSpy is returning expected values.
There is pet returning isNew()=false and getId()=0.
But owner.getPets() returns empty list.

Investigated with @tepa46 and @Vassiliy-Kudryashov - looks like a very strange case
There is no obvious reasons why Spring cannot inject this Spy into the instance under test. It can be manually fixed if we replace ArrayList with ArrayList<Pet>, but we cannot generate such code due to generics support limitations in UnitTestBot.
Tomorrow I'm going to ask other collegues if they see the reasons of autowiring problems here. If we clarify it, it may be possible to use some fallback as we do when there are several lists of one type in project.

It seems to be a bug in Mockito.
Consider the following test
@Test
	@DisplayName("getPet: compId.equals(id) : True -> return pet")
	public void testGetPet_CompIdEquals() throws Exception {
		Pet petMock = mock(Pet.class);
		(when(petMock.isNew())).thenReturn(false);
		(when(petMock.getId())).thenReturn(-255);
		pets.add(petMock);
		pets.add(null);
		pets.add(null);
		Integer id = -255;

		Pet actual = owner.getPet(id);

		assertNull(actual.getBirthDate());
		assertNull(actual.getType());
		Set actualVisits = ((Set) getFieldValue(actual, "org.springframework.samples.petclinic.owner.Pet", "visits"));
		assertNull(actualVisits);
		assertNull(actual.getName());
		assertNull(actual.getId());
	}

This version does not work
        @InjectMocks
	private Owner owner;

	@Spy
	private ArrayList pets;

This version works
        @InjectMocks
	private Owner owner;

	@Spy
	private ArrayList pets = Mockito.spy(new ArrayList());

However, in accordance with @Spy documentation, it must be the same.
Seems to be a generics support problems in @InjectMocks. There are some other known issues about it, like https://github.com/mockito/mockito/issues/1066.

@EgorkaKulikov
Can we generate code like it is in your second example?
With explicit spy creation?

@Spy annotation was constructed as a smart syntax and guidelines recommend it. After that, here we know one seldom bug, I have no idea how many potential problems are hidden in it. It can be investigated, but it will take time.


MM-21364 - Plugin Settings Config Best Practices

Summary
Extended documentation on how to define a plugins configuration settings. I've included as a previous question to the custom setting in Extend/Plugins/Best Practices
Ticket Link
MM-21364

@aaronrothschild gentle ping


[BUG] Recover schedulevmbackup after error backup is deleted

Describe the bug

schedulevmbackup still shows error mesage and is suspended after the error backup (instance) is removed.
To Reproduce
https://github.com/harvester/harvester/issues/6621#issuecomment-2437295313
(5) Disable the backup target to test the status of schedule
(5.1) Create a NFS type schedulebackup
(5.2) Stop the NFS server
(5.3) Wait until the schedule is triggered, then observe:

the above meets the expectation
(5.4) Start the NFS server
(5.5) Manually delete the error backup
harvesterhci.io.virtualmachinebackup is empty now

(5.6) But the schedulebackup still shows below message and is suspended

Expected behavior

The schedulevmbackup is updated when the error backups are gone, and resume asap. allow the scheduled backup to take place again.
Support bundle

Environment

Harvester ISO version: Harvester v1.4.1-rc4
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context

https://github.com/harvester/harvester/issues/6621

@WebberHuang1118 Please investigate the issue


hmac_init cleanup and fix key zeroization issue

Checklist

Side note: a closer look reveals that if md is set, a reset is performed regardless of if that's the same algo as wa previously set or not...  I'm unsure if this was intentional.

Merged, thanks.  @levitte I did notice that and wondered why.  I can open an issue to investigate this further if we want.


Step 8 duplicates 11 (or vice versa)

Hello,
If I read the instruction from top to bottom, the step 8 has a vibe like "and draw the rest of the owl", especially considering that the step 11 gives a lot of details on how to fill the very same web form.
I believe that deleting the step 8 would make the document easier to read without removing any important information.
I'd recommend the reader of this report to double check that the order of the steps is correct and now follow me blindly as I'm being a bit clumsy with that integration :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb39c8bf-2709-c59d-94f8-6db76d21bcfb
Version Independent ID: f7122c2c-ef68-95b6-2273-edbc4bb89464
Content: Tutorial: Azure Active Directory integration with Atlassian Cloud
Content Source: articles/active-directory/saas-apps/atlassian-cloud-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@ajoga
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Issue resolved as suggested, Am closing this item.
#please-close


Print two divs together

Hello
For exmaple, I have following code in HTML

 MY SITE NAME

  Home   About Us

 Welcome to my iste

 Sidebar

 Copyright

`

In PDF, I want to include header, content, and footer only.
I have tried
html2pdf().from(header).toPdf().get('pdf').then(function (pdf) {     pdf.addPage(); }).from(content).toContainer().toCanvas().toPdf().save();
But this code prints both the divs on two different pages. I want to print all the divs together except sidebar. Please share how can i do that

your question is a bit weird.
What I would do is create a new "Div"
and add all the divs you want in it.
In your case it would look something like this;
            container= document.createElement('div');

            //clone is required because otherwise you alter the current page.
            let cloneHeader= document.getElementById("header").cloneNode(true);
            let cloneBody = document.getElementById("header").cloneNode(true);
            //add as much nodes as needed.

           //remove some css browser might set.
            container.style.margin = '0px';
            container.style.padding = '0px';
            container.style.display = "inline";
            container.style.fontFamily = "arial";
            container.style.fontSize = "12px";
            container.style.lineHeight = "1.2";  //important for knowing break lines.

            container.appendChild(cloneHeader);
            container.appendChild(cloneBody);
            //add as much node as needed.

Does this keep the css? No idea, have to look into it, in IE it loses the css but the rest seems to keep it how it is displayed.

Anotherway you could look into it is just removing the "sidebar" element with javascript.
After this just print the page as you would normally? by grabbing the body.

//ex:
removeElementsByClass("sidebar");
// do your print stuff.

function removeElementsByClass(className){
    var elements = document.getElementsByClassName(className);
    while(elements.length > 0){
        elements[0].parentNode.removeChild(elements[0]);
    }
}

Actually wondering seeing above classes why they are not ID's, seeing as they are used only once.

Hello @cablegunmaster, you did an example with node, in my case I'm using just javascript and jquery. So i cloned my elements, but then when i call that with "from("elementCloned") doesn't work, i mean, the pdf is  empty.
Can you give me a hand please? thank you so much.
Here is my js code:
`$("#html2pdf").click("click", function (){
var clone1= $("div[data-classid='DettaglioOrdineBox_org.eclipse.scout.apps.crm.client.crm.ContoClienteForm_InnerFormField_org.eclipse.scout.apps.crm.client.crm.MainClienteForm']").clone(true);
var indirizzoAlternativo = $("div[data-classid='DettOrdineIndirizzoAlternativoField_org.eclipse.scout.apps.crm.client.crm.ContoClienteForm_InnerFormField_org.eclipse.scout.apps.crm.client.crm.MainClienteForm']").clone(true);
var newElement = $(indirizzoAlternativo ).appendTo(clone1);
var opt = {
margin: 1,
filename: 'Dettaglio_Ordini.pdf',
image: {
type: 'jpeg',
quality: 0.98
},
html2canvas: {
scale:2,
letterRendering: true,
imageTimeout: 0,
width: 850,
height: 1200,
scrollX: 0,
scrollY: 0
},
jsPDF: {
unit: 'in',
format: 'a4',
orientation: 'portrait',
putOnlyUsedFonts:true,
floatPrecision:'smart'
}
};
var worker = html2pdf();
worker = html2pdf().set(opt).from($(newElement ).html()).toContainer().then(()=>{
const doc = $('.html2pdf__container');
doc.find('.menubar').remove();
doc.find($("div[data-classid='DettaglioOrdineInfoBox_org.eclipse.scout.apps.crm.client.crm.ContoClienteForm_InnerFormField_org.eclipse.scout.apps.crm.client.crm.MainClienteForm']")).hide();
	}).toPdf().get('pdf').then(function (pdf){
			pdf.addPage();
		}).set(opt).from(elemClass).toContainer().then(()=>{
	          const doc2 = $('.html2pdf__container');
	          doc2.find('.table-header').hide();
	          $('.table-data').css('overflow', 'visible');
	          doc2.find($("div[data-classid='org.eclipse.scout.apps.crm.client.crm.ContoClienteForm$MainBox$DettaglioArticoliBox$DettArticoliField$Table$IdRigaColumn_org.eclipse.scout.apps.crm.client.crm.ContoClienteForm$MainBox$DettaglioArticoliBox$DettArticoliField$Table_DettArticoliField_org.eclipse.scout.apps.crm.client.crm.ContoClienteForm_InnerFormField_org.eclipse.scout.apps.crm.client.crm.MainClienteForm']")).hide();
	          doc2.find('.scrollbar .y-axis').hide();
		}).toCanvas().toPdf().save().catch(function (error) {
	});

});

}
`
PS: the second element it's ok.

Dear Emer, I have added some ideas, debugging points you could look at.
Since I do not have the same screen set of variables as you do.
Hello @cablegunmaster, you did an example with node,

The example above is using pure javascript / jquery, no idea what node you might see?
"from("elementCloned")

Did you check if there is actually any html in the cloned div? by just putting a breakpoint in the browser on that line, and seeing the actuall div class element. or variable output in the console of your browser?
Seeing the long classes and variables, I might think that you did not get any html from the element at all?
Basically saying: "I grabbed the element but never checked the input" and you are saying but I have no output!
Might want to check what input you got using the developer console (F12 on browser) and just check the code in there if you got the result you expected. do elements exist when I grab them using the selectors? (most likely to be faulty input).
a basic check to see if the element exist could be;
$('#test').length > 0
//true it exist, false if it doesn't

The reason i'm cloning my elements is because I do not want to alter the elements I already have on the screen.
org.eclipse.scout.apps.crm.client.crm.ContoClienteForm$MainBox$DettaglioArticoliBox$DettArticoliField$Table$IdRigaColumn_org.eclipse.scout.apps.crm.client.crm.ContoClienteForm$MainBox$DettaglioArticoliBox$DettArticoliField$Table_DettArticoliField_org.eclipse.scout.apps.crm.client.crm.ContoClienteForm_InnerFormField_org.eclipse.scout.apps.crm.client.crm.MainClienteForm'

Just why? Why this monstrosity? This seems like gibberish, if actually needed refactor it in 1 spot and only reference to it but this should definitely be shortened.
Also next time use triple apostrophes to make sure the code is outlined as well.
These are all meant as constructive criticism.

Hi @cablegunmaster, I did everything you said, it's not the first time that i have problems with this. the problem is the old framework that I'm using, and I cannot change it because it is a decision of the customer who has chosen it. so this framework(eclipse-scout) generate a dinamic Dom with this long 'data-id' for every single div. I know that sucks, but i'can't change that, just try to fix what I can.
As you said I'd controlled my input debugging in the dom and I have the data from that dom. Actually I can create the pdf, only some classes are not hidden as I want. Today i solved it by hiding the classes with jquery.
Thak so much for your time and patience.

No problem, good to hear your issue is resolved :)! Issue closed until further inquiries are needed and please open up a new post.


Add new examples to Dla, Dls, Iot, Iotcentral, Rdbms

Add Aladdin crafted examples.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

I force pushed on the same branch as per offline discussion to avoid cluttering closed PR section.

Don't know what's going on the with placeholders in Data Lake "{Data lake analytics account name}" but there are clearly issues still with the generation and examples being generated that aren't useful (e.g: --script {script})


Enforce 'replicas: 1' on glance-api when local storage is used

When local storage is used, running multiple instances of
glance-api causes image data to be scattered across multiple containers
and nodes. Therefore, when nova or the glance CLI wants to download an
image, if the request doesn't hit the instance that has the data (due to
load balancing), no data is returned - generating either an exception or
an another unexpected behavior.

lgtm


Optimize archived and unknown thread handling for /threads

In #58, I tried to reduce the chance of threads being labeled as "unknown thread", however it introduced unacceptable delay due to taking extremely inefficient way to accomplish that.
This pull request will make the bot fetch the thread directly with GuildChannelManager#fetch(), and if it fails, add the ID of it to cachedUnknownThreads to prevent making requests guaranteed to get 403/404 error in the future, instead of old behavior of iterations over all channels and fetch archived public/private threads for each of them.
New event handler for threadListSync is added to remove a thread from cachedUnknownThreads when the bot gains access to it.

lgtm, testing on staging


Add existing sniffs to validate all input, escape all output.

Check for validation/sanitization of all input, escaping of all output.
Fixes #37

The sniff WordPress.XSS.EscapeOutput checks if the i18n functions are escaped which we do not require.
I think we will need to change the notice from ERROR to WARNING on non WordPress core functions and variables. The reason being there may be no need for escaping.
I don't think we should allow the ignore comment //xss ok

@grappler

The sniff WordPress.XSS.EscapeOutput checks if the i18n functions are escaped which we do not require.

The rule in the handbook doesn't explicitly exclude i18n output. So in that case the handbook would need adjusting.
Also - just putting this out there:
Is it justified to exclude i18n output ? I know that GlotPress translations are (very?) often used and  - with the changes in WP 4.6 - will take precedence. As those translations are reviewed, I can see how they could be regarded as save, but themes can still ship their own translations, can't they ?

I think we will need to change the notice from ERROR to WARNING on non WordPress core functions and variables. The reason being there may be no need for escaping.

I don't think we should allow the ignore comment //xss ok

The escaping sniff has two-fold additional functionality to deal with this:

People can provide an comma delimited list of customEscapingFunctions, customAutoEscapedFunctions and customPrintingFunctions via the properties of their phpcs.xml file to whitelist additional functions.
The // xss ok whitelist comment.

Considering the future Theme Check will disregard a custom phpcs.xml file as we don't want rules to be disabled, that leaves authors only one other option - which is the whitelist comment.
As both the sanitation and the escaping is IMHO very important for the application security, lowering the error level to warning feels counter-intuitive.
What about leaving the level at error and allowing the whitelist comments, but also adding an additional sniff for those same whitelist comments which would output a warning saying the variable will need manual inspection ?

Is it justified to exclude i18n output ?

The translation are reviewed on w.org by translation editor who would not approve a translation if there were issues with it. Core does not use the escaped functiosn Ref: https://github.com/WordPress/twentysixteen/pull/240 & https://core.trac.wordpress.org/ticket/30724
My hesitation for allowing the // xss ok whitelist comment is the additional thing to understand and if it will be used as a lazy workaround. Need to get feedback from others on this. The biggest issue that we face is with get_theme_mod().
As to the validation/sanitization sniff

There is a few false positive that I need to report upstream e.g.
wp_verify_nonce( $_POST[ 'settings_nonce' ], basename( __FILE__ )
if ( 'page' === $_POST['post_type'] ) {
https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/191
It requires the data to be run through wp_unslash() before it is sanitized which I don't fully understand.

Otherwise it is good. 😄

The translation are reviewed on w.org by translation editor who would not approve a translation if there were issues with it.

Only for translations made in GlotPress, not for translations shipped with a theme. Or is that no longer allowed at all ?

Core does not use the escaped functiosn

Core does not comply with quite a few of their own coding standard directives - largely because they only allow code to be adjusted to comply with the standard in combination with other changes. So IMHO, that's not really a valid argument.
As for TwentySixteen - I'd call that "leading by setting a bad example".

My hesitation for allowing the // xss ok whitelist comment is the additional thing to understand and if it will be used as a lazy workaround. Need to get feedback from others on this.

Should we change the label for the issue to decision needed in that case ?

The biggest issue that we face is with get_theme_mod().

Can you explain that one to me ?

There is a few false positive that I need to report upstream

Please do, they should be solved upstream.

wp_verify_nonce( $_POST[ 'settings_nonce' ], basename( FILE )

Already reported - see the response in the issue: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/572

It requires the data to be run through wp_unslash() before it is sanitized which I don't fully understand.

Core slashes all input data, so to do a valid comparison, you'd need to unslash the data before doing the compare.
Hope this helps.

Only for translations made in GlotPress, not for translations shipped with a theme. Or is that no longer allowed at all ?

Translations are still allowed as w.org only ships translations when they are at 100%. There may be easier way for theme authors to slip in malicious code if they wanted to. I have added the decision needed tag.

The biggest issue that we face is with get_theme_mod().

I just meant that the sniff is catching places where the settings are not being escaped. It is a common thing the theme authors miss.

I just meant that the sniff is catching places where the settings are not being escaped. It is a common thing the theme authors miss.

So that's a good thing, isn't it ?

So that's a good thing, isn't it ?

Yes, meant it as a good thing.

A decision was reached on the idea of escaping translations and having to add // xss ok to bypass escaping variables.  The team voted down both proposals.
Reference: https://make.wordpress.org/themes/2016/10/04/october-4th-team-meeting-notes/
Anything that wouldn't block submission (warning, info) would probably be acceptable.

I've lowered the error level to warning for both sniffs in accordance with the board's decision.
For the record:
While I respect the decision by the theme review board, this seems a very counter-intuitive direction to take.
Both these sniffs are about security and are now given low priority while this is one of the biggest issues with both themes and plugins for WP.
Very few "false positives" for these sniffs which have been reported to WPCS upstream actually turn out to be false positives. Most of the time, it is developer education which is needed, not an adjustment of the sniff.
I strongly suggest to put it on the agenda for reconsideration in six months or so once the Theme ruleset has shaped up more and more full theme checks have been run.
If you do encounter false positives in the mean time, please do report these upstream.


Custom handlers

Whenever the daemon has been restarted (and the email sent), make it so the user can config other handlers. Such as executing bash scripts, starting other services, etc.

Would it be sufficient if the custom handler output was logged in the godaemon log, and do you need support for the handler to be run setuid//setgid in a sandbox?

I think logging in the godaemon log would be fine, obviously with a prefix that makes it clear it's the handler's output. I don't think the handler needs to run in a sandbox, it will most likely just be a simple bash script/node script.
I think that just killing the custom handler in 20 seconds or so would server my purpose fine. Sync would be nice, but isn't really required at this point.

Got it - I'll open another issue once this one is closed for making asynchronous tasks possible, but add simple synchronous support for the moment. Thanks!


strange errors

I got a very strange error recently. I don't know whether or not it's imagemin's error. But I would be very pleased if you could figure out why this happen.
I ran into this trouble through image-webpack-loader, and I have commit a issue at that project. Here is the link.
Here's my errors:
Module build failed: ModuleBuildError: Module build failed: Error: spawn /Users/Zero/projects/livebet-client-code/node_modules/pngquant-bin/vendor/pngquant EAGAIN
at exports._errnoException (util.js:949:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
at onErrorNT (internal/child_process.js:348:16)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)
at DependenciesBlock.onModuleBuildFailed (/Users/Zero/projects/livebet-client-code/node_modules/webpack-core/lib/NormalModuleMixin.js:315:19)
at nextLoader (/Users/Zero/projects/livebet-client-code/node_modules/webpack-core/lib/NormalModuleMixin.js:270:31)
at /Users/Zero/projects/livebet-client-code/node_modules/webpack-core/lib/NormalModuleMixin.js:292:15
at context.callback (/Users/Zero/projects/livebet-client-code/node_modules/webpack-core/lib/NormalModuleMixin.js:148:14)
at imagemin.buffer.then.catch.err (/Users/Zero/projects/livebet-client-code/node_modules/image-webpack-loader/index.js:42:9)
at process._tickCallback (internal/process/next_tick.js:103:7)
ERROR in<EMAIL_ADDRESS>Module build failed: Error: spawn /Users/Zero/projects/livebet-client-code/node_modules/pngquant-bin/vendor/pngquant EAGAIN
at exports._errnoException (util.js:949:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
at onErrorNT (internal/child_process.js:348:16)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)
@ ./~/css-loader?sourceMap&localIdentName=[path][name]---[local]---[hash:base64:5]!./~/postcss-loader!./feSRC/view/pages/profile/index.scss 6:13630-13675

I'm experiencing similar problems with gulp-imagemin. At first I thought maybe the image format wasn't right. Tried over 10 different images with different formats. All failed.
here's my gulp task definition:
gulp.task('compress-images', function () {
    gulp.src('src/img/*')
        .pipe(imagemin())
        .pipe(gulp.dest('dist/img'))
});

here's the output when I run the task alone. (not quite useful for solving it myself so i turned into you)
events.js:160
      throw er; // Unhandled 'error' event
      ^
Error: spawn /Users/washington/Sites/me/test/node_modules/jpegtran-bin/vendor/jpegtran ENOENT
    at exports._errnoException (util.js:1008:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
    at onErrorNT (internal/child_process.js:348:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Please help me.

I got same error

I got same error , in Linux
Unhandled rejection Error: spawn /home/work-develop/git/starway-js-web/node_modules/gulp-imagemin/node_modules/imagemin-gifsicle/node_modules/gifsicle/vendor/gifsicle ENOENT
    at exports._errnoException (util.js:907:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at nextTickCallbackWith2Args (node.js:442:9)
    at process._tickCallback (node.js:356:17)

ENOENT means that it can't find the binary. jpegtran has most likely failed to install.

@kevva , it seems not because of what you said. When I cut down the number of images being processed, this error disappears! Anyway, I have figured out a way to avoid this problem. link


new roles for node types

have examples or predefined templates?

statesync
archive
sentry

This is done via variable definitions in the inventory file.


pipestat summarize: add portability/zipping

Right now if you create a report, it is not portable to another system,e.g. I create report on Rivanna, I cannot view it on my local machine, share it with others etc.

Can now add portable flag via API or CLI, to get a portable version of the report under folder portable_reports.
Example CLI usage:
pipestat summarize -c /home/drc/pepatac_tutorial/processed/looper_pipestat_config.yaml --portable True

probably just make it a flag, instead of an option (in other worsd, it's atypical to specify --portable True... for flags, you just say --portable and that toggles it on, it defaults to False).

Oh ok. I'll make that change.

I just realized that the zip feature is not quite implemented correctly. It is not preserving the proper paths for the collected resources (images/pdfs).
Right now, the portable report folder is created with no issues and one can zip it themselves using the OS.


Disable video autoplay

People are getting bombarded with auto play videos, it is taking an excessive amount of bank width. Google has blocked this option, can we get this option for duckduckgo?

Thanks for reporting this @msmasters624, we've had a couple folks ask for this; I've bumped the internal task that tracks this request.
I can't promise anything, but I'd like to solve this in the near future by offering a few autoplay options. If this ends up in a release, I'll ping you here to let you know – for now, closing this issue as it's tracked internally.

@msmasters624  there's extension you can use to disable autoplay "Disable HTML5 Autoplay" if that helps :)


CIP-???? | Tag / Redeemer field in TxOut

We propose to allow the attachment of arbitrary, temporary data to transaction outputs within the script context. This data, akin to redeemers in their operational context, is intended to be used exclusively during the execution of Plutus scripts and thus are not recorded by the ledger. This will facilitate a wide variety of smart contract design patterns, one of which can be used as a general solution for double satisfaction without sacrificing script composability.

(proposal rendered from branch)

@colll78 we're not adding this for discussion in today's CIP meeting, where new proposals are normally introduced in Triage, because of the Draft status (as also with #749).  Please feel free to leave it in this state as long as you need... then we will proceed to meeting discussion as well as more rigorous community review (though leaving it here for public comment now is also welcome).

@colll78 we're not adding this for discussion in today's CIP meeting, where new proposals are normally introduced in Triage, because of the Draft status (as also with #749). Please feel free to leave it in this state as long as you need... then we will proceed to meeting discussion as well as more rigorous community review (though leaving it here for public comment now is also welcome).

Whoops, I didn't mean to set this as a draft.

@colll78 Due to last minute status change this has been added to Triage (not time for full technical review; just an introduction) at today's meeting: https://hackmd.io/@cip-editors/80

Input from the IOG Plutus and Ledger teams would be appreciated here 🙏
@michaelpj @lehins

just wanna ask if this affects in any way also hardware wallets? because of the memory constrains, hardwarewallets cannot look at whole utxo sets while performing the signing action.

@colll78 this is lagging in progress a bit and there was a question in the CIP meeting today over some resolutions that weren't recorded.  A couple editors including @Ryun1 (I was just taking some notes) + @michaelpj and @fallen-icarus as I remember made the following points:

This is relevant to a "composability" problem of transaction outputs from one dApp to be applied as inputs to a potentially different dApp.
Within the CIP process there hasn't yet been any other way of dealing with this composability problem other than the one suggested here.
However, people are able to deal with composability issues in other ways that don't require the proposed changes... and therefore this solution might only be applicable to the author's own / preferred implementations.

Assuming the above reservations are valid, both @Ryun1 and I (and maybe others) thought this might then be better off as a CPS dealing with composability (and peripherally the "double satisfaction problem"), and suggesting this tagging approach as one means of dealing with it.

@colll78 this is lagging in progress a bit and there was a question in the CIP meeting today over some resolutions that weren't recorded. A couple editors including @Ryun1 & @Crypto2099 (I was just taking some notes) + @michaelpj and @fallen-icarus as I remember made the following points:

This is relevant to a "composability" problem of transaction outputs from one dApp to be applied as inputs to a potentially different dApp.
Within the CIP process there hasn't yet been any other way of dealing with this composability problem other than the one suggested here.
However, people are able to deal with composability issues in other ways that don't require the proposed changes... and therefore this solution might only be applicable to the author's own / preferred implementations.

Assuming the above reservations are valid, both @Ryun1 and I (and maybe others) thought this might then be better off as a CPS dealing with composability (and peripherally the "double satisfaction problem"), and suggesting this tagging approach as one means of dealing with it.

I would like to clarify that this CIP is not designed specifically as a solution to the double satisfaction problem / dApp composability problem. This is a general improvement to the smart contract platform on Cardano that enables a huge range of use-cases that are currently in-feasible. The core value add is the ability to associate arbitrary data with outputs without permanently writing that data to the UTxO set.  Sure, it can be used to solve double satisfaction without sacrificing dApp composability (a property that is currently unique to this solution to DS); however, more generally it can be used to do things like tag specific outputs with the USD price of the multi-asset value they contain via a signed oracle message which is associated to the output via this output_tag field. It also could be used to index the location of relevant tokens within the output value map to make onchain token lookups ~O(1); currently searching values is a very expensive and common operation, for instance if you need to find the total number of pool_asset_a in a DEX pool utxo, or if you need to check for the presence of a some state_thread_token (pretty much every dApp on Cardano). This is possible because the location of all tokens in the value of all outputs is known during transaction construction (nice property of deterministic transactions on Cardano), so you don't need to ever perform search on-chain (i.e. valueOf) instead we can just index the location of these tokens via this output_tag field. So, when a contract comes across a TxOut with an output_tag = 6 (idx of state token) it could simply verify that the head of the 6th entry of the value map contains the state token (or provide 2 indices if it isn't the first token with that currency symbol in the value).
It also enables things such as dependent transaction chaining which is a pre-requisite for babel fees. To achieve this, you could use this field to store a TxIn of an input that must be included as a resolving input (see validation zones) for this transaction to be considered valid by the CHAIN level rules for this tx to be included in the block. Since this would be available in the witness set, it would be available during chain level validation without bloating the UTxO set.

My reading of @colll78's https://github.com/cardano-foundation/CIPs/pull/735#issuecomment-2173952269 is that this proposal is still interesting to the community.  However, I still have no idea how this would be validated as a candidate.
Since all the prior response was from the Plutus team I'm tagging this as Plutus category even though it looks like it could be applicable to the Ledger.  @zliu41 (@lehins WhatisRT) could you confirm (or change) that category and indicate that this proposal might be admissible?
In the meantime marking this as Unconfirmed since it's been triaged already but not validated as a CIP.  @michele-nuzzi @MicroProofs if you see any advantage to bringing it into the CIP meeting for discussion again please make a comment here & we'll put it on the schedule.


FLOE-548: add Floe news item New Content Added to ID Resources

@jhung @michelled

@michelled thanks for catching those should be good now


feat: Add load_balancers parameter to associate a CLB (Classic Load Balancer) to worker groups ASG

PR o'clock
Description
Add load_balancers  for clb be associated to asg.
Resolves https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1036
Checklist

[ ] CI tests are passing
[ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

Please can you duplicate this change in the ASG in workers_launch_template.tf, thank you.

@hacker65536 Thanks for your contribution.
I was just wondering what is your actual use case. What you're trying to achieve by adding a load balancer to all your worker nodes in a kubernetes cluster. Is the kubernetes model does't fit here (using k8s service or ingress) ?

I'm trying to using clb + envoy to handle grpc app.

Thanks @hacker65536 for your contribution.

Is the kubernetes model does't fit here (using k8s service or ingress) ?

Using K8s service LBs makes it harder to recreate the cluster, because you need to use e.g. Route 53 to switch traffic from the old to the new cluster. So I'd use service LBs and (current) AWS ingresses only for dev clusters that can be deleted without care. So this feature should generally be useful for any production setup. Just my two cents 😃

Is the kubernetes model does't fit here (using k8s service or ingress) ?

Using K8s service LBs makes it harder to recreate the cluster, because you need to use e.g. Route 53 to switch traffic from the old to the new cluster. So I'd use service LBs and (current) AWS ingresses only for dev clusters that can be deleted without care. So this feature should generally be useful for any production setup. Just my two cents 😃

Great. Thanks @mumoshu for the clarification.


bigtable-hbase-beam causes Dataflow job worker to fail

problem statement
with the following maven pom.xml dependency, Cloud Dataflow job worker fails to start.
<dependency>
            <groupId>com.google.cloud.bigtable</groupId>
            <artifactId>bigtable-hbase-beam</artifactId>
            <version>1.5.0</version>
        </dependency>

The workaround is to delete the above section in pom.xml and related Java code. Below is the error in Dataflow's StackDriver logging:

Error syncing pod 414461ba254099a817d81f7d60657139 ("dataflow-debugme-worker-fails-04181156-lbcm-harness-g5rz_default(414461ba254099a817d81f7d60657139)"), skipping: failed to "StartContainer" for "java-streaming" with CrashLoopBackOff: "Back-off 2m40s restarting failed container=java-streaming pod=dataflow-debugme-worker-fails-04181156-lbcm-harness-g5rz_default(414461ba254099a817d81f7d60657139)"

The source is bigtable-beam-dataflow-worker-fail.zip.
To reproduce the bug, modify com/finack/models/Constants.java with the correct pub/sub subscriptions, project ID, BigTable instance:

PROJECT_ID
PUBSUB_SUBSCRIPTION_TO_PIPELINE
BIGTABLE_CLOUD_INSTANCE_ID
CFAMILY # column family for the table
TABLE_ID

Create a BigTable and pub/sub subscription per the fields above. Execute the following to run locally:

mvn   exec:java       -Dexec.mainClass=com.finack.app.FinackPipeline        -Dexec.args="  --project=mwpfin --runner=DirectRunner --mode=debug " # --mode=debug is optional, without it, console output will be less verbose

If local runner executes without error, publish to the topic linked to the subscription and verify messages enter BigTable:

Download the publish.py module.
edit the first 2 lines of publish.py to put the correct project ID and topic.
Every run will create a pub sub message with current timestamp.

Ideally, messages will write to BigTable. Then kill the local runner and execute the following command to run with DataflowRunner. Put a cloud storage path for --stagingLocation=
mvn   exec:java   -Dexec.mainClass=com.finack.app.FinackPipeline        -Dexec.args="--project=mwpfin       --stagingLocation=gs://tmp/staging/       --runner=DataflowRunner       --mode=dataflow "
Observe the error from StackDriver logging:

The job appears to be running but does not write to BigTable. I proved BigTable dependency was the cause because of the following:
Code without that dependency and write to System.out.println method instead of BigTable would not have the Error syncing pod errors.
I have not been able to access the compute engine node or the failed pod to debug further. I can't find documentation that shows how. Maybe that's not possible. Are you able to reproduce?

I think that that started happening with Bean 2.10. We had a fix in our 1.10 release (see here).  It looks like we haven't released that in an official version.  I'll do that shortly

Try adding this to your bigtable-beam-hbase dependency:
            <exclusions>
                <exclusion>
                    <groupId>org.slf4j</groupId>
                    <artifactId>slf4j-log4j12</artifactId>
                </exclusion>
            </exclusions>

That worked for us . That ought to work for you as well even for the 1.5.0 release

Thank you so much, @sduskis ! After putting the following to pom.xml, Cloud dataflow runner inserts to Bigtable.
<dependency>
            <groupId>com.google.cloud.bigtable</groupId>
            <artifactId>bigtable-hbase-beam</artifactId>
            <version>1.5.0</version>
            <exclusions>
                <exclusion>
                    <groupId>org.slf4j</groupId>
                    <artifactId>slf4j-log4j12</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

The problem is there is no logging at all in Stackdriver for the running job which is insanely painful:

I think  SLF4J is what Dataflow uses for general logging to Stackdriver such as worker messages. With the pom.xml change above, logging to console with System.out.println along with SLF4J did not create any log entries. Neither did any Dataflow system log entries. Do you have a workaround to restore logging before the fix is official?

I think that you need to use a newer version of slf4j-log4j12 that's compatible with Beam.  As best as I can tell, Beam is using slf4j 1.7.25.

I suppose you did not read my source zip file that contains in pom.xml
<beam.version>2.11.0</beam.version>
<slf4j.version>1.7.25</slf4j.version>

I believe the cause is slf4j-log4j12 is excluded from the project classpath. Since there is no slf4j-log4j12, Dataflow can't log to Stackdriver.

When Do you plan to release the fix for bigtable-hbase-beam?
Will the fix cause no StackDriver logging?

@hilliao, I'm sorry that didn't work.  I have no idea why you can't log.  Can you please ask the Beam community?  See methods of communicating with them here: https://beam.apache.org/community/contact-us/

I found the fix to enable StackDriver logging:
replace
<dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-jdk14</artifactId>
            <version>${slf4j.version}</version>
            <!-- When loaded at runtime this will wire up slf4j to the JUL backend -->
            <scope>runtime</scope>
        </dependency>

with
<dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-simple</artifactId>
            <version>${slf4j.version}</version>
        </dependency>

On behalf of Maven wave partners (Google cloud north America service of 2018), we Thank @sduskis.


🌐 i18next

Switch from i18n to i18next
Should have better performance, more features, better integration (vscode)
✅ Testing succeeded

:tada: This PR is included in version 2.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feat] : Add loader during registration

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Currently we do not show any action when user clicks on register button which leave user in question whether he/she clicked Register button or not and again clicks Register button which sends multiple requests to the server  which in return throws a error.  So A loader will give a visual indication of some process and to wait to finish it.
Use Case
Will help user during registration.
Benefits
No response
Priority
Medium
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

okay @lade6501 that'd be great

Can i work on this issue??


build: allow the user to specify the llvm tools

This is needed for cross-compiling the toolchain to Windows ARM64 on
Windows x64 using Visual Studio which does not permit the NATIVE
sub-build to work properly.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @Rostepher @gottesmm

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - a6c0e9438ba224175800815258c6fa57b9741413

@swift-ci please test Linux platform


Define project architecture - Alpha Version

Project specification and architecture need to be documented for the initial alpha release

Initial summary was added in https://github.com/open-feature/spec/pull/5

Relates to #65


incorrect arithmetic shift

repro case inspired by https://electronics.stackexchange.com/questions/132773/difference-between-and-in-verilog
Parsing the following snippet
module binary_arithmetic_shift (
    output logic [4:0] b,
    output logic [4:0] c,
    output logic [4:0] d,
    output logic [4:0] e
);

  logic [4:0] a;
  assign a = 5'b10100;
  assign b = a <<< 2;  //b == 5'b10000
  assign c = a >>> 2;  //c == 5'b11101, because sign bit was `1`
  assign d = a << 2;  //d == 5'b10000
  assign e = a >> 2;  //e == 5'b00101

endmodule : binary_arithmetic_shift

via UHDM then reading in Yosys and then writing verilog gives the following result
/* Generated by 0.28+6 */

module binary_arithmetic_shift(b, c, d, e);
  wire [4:0] a;
  output [4:0] b;
  wire [4:0] b;
  output [4:0] c;
  wire [4:0] c;
  output [4:0] d;
  wire [4:0] d;
  output [4:0] e;
  wire [4:0] e;
  assign a = 5'b10100;
  assign b = 5'b10000;
  assign c = 5'b00101;  // <------ Sadness :'(
  assign d = 5'b10000;
  assign e = 5'b00101;
endmodule

FYI @QuantamHD @hzeller

It looks like b is correct did you mean to put that comment on c?

Yes, corrected on the above message to avoid confusion. Thanks!

Are you sure this is a bug? logic is unsigned by default, according to IEEE 1800-2017, 6.11 Integer data types, Table 6-8:

logic - 4-state data type, user-defined vector size, unsigned

The operator is expected to fill bits with zeros in such situation according to IEEE 1800-2017, 11.4.10 Shift operators:

The arithmetic right shift shall fill the vacated bit positions with zeros if the result type is unsigned. It shall
fill the vacated bit positions with the value of the most significant (i.e., sign) bit of the left operand if the
result type is signed.

After changing all logic to logic signed in the snippet I got c = 5'b11101.

The tool produces the correct result. The expectation is incorrect. This issue can be closed.
I converted the design to use parameters so the answer is the same with all commercial simulators else some produce xxxx with the setup below:
module binary_arithmetic_shift (
);

  parameter logic [4:0] a = 5'b10100;

  parameter logic [4:0] b = a <<< 2;  //b == 5'b10000
   parameter logic [4:0] c = a >>> 2;  //c == 5'b11101, because sign bit was `1`
   parameter logic [4:0] d = a << 2;  //d == 5'b10000
  parameter logic [4:0] e = a >> 2;  //e == 5'b00101

  initial $display("%b", c);

endmodule : binary_arithmetic_shift

Produces on all commercial simulators:
00101

Thanks for confirmation, I'm closing the issue.


Drivers: ADC: Introduce gd32 adc driver

Add an initial support for gd32 adc interface.
This driver based on single conversion mode with regular channel.
Test with samples/drivers/adc sample on gd32f350r_eval, gd32f450i_eval and gd32vf103v_eval boards.
work list:

[x] sample time config

When compile the samples/drivers/adc sample on gd32f350r_eval board, I get an  warning: unused variable 'cfg' at adc_gd32.c. gd32f450i_eval and gd32vf103v_eval boards doesn't have this issue.
I guess this issue caused by the ADC interface number. GD32F350 have one ADC interface, but GD32F450 and GD32VF103 have more than one ADC interface. And I use  the DT_INST_FOREACH_STATUS_OKAY macro.
Warning output: warning.txt?

When compile the samples/drivers/adc sample on gd32f350r_eval board, I get an  warning: unused variable 'cfg' at adc_gd32.c. gd32f450i_eval and gd32vf103v_eval boards doesn't have this issue.
I guess this issue caused by the ADC interface number. GD32F350 have one ADC interface, but GD32F450 and GD32VF103 have more than one ADC interface. And I use the DT_INST_FOREACH_STATUS_OKAY macro.
Warning output: warning.txt

Caused by the macro redefinitions. For example, #define ADC_CTL0(_) REG32(ADC + 0x00000004U) doesn't use the _. so, cfg will be treated as unused variable.

@gmarull @nandojve Could you please help to take a look at this? Thanks!

Hi @cameled ,
Is there any update on this?

Hi @cameled ,
Is there any update on this?

Sorry for the long delay, I switch to another task last month. Fortunately, Its almost finish now.
I can restart this work at the end of this week.

@ycsin @nandojve @gmarull I use a runtime solution with adc_gd32_global_irq_handler to fix the irregular interrupt implement. Cloud you please have a look for this?

@nandojve Please help to confirm the new shared irq implement, thanks!


music_speech_epoch_15_esc_89.25.pt: Include spanish speech?

Was this checkpoint (https://huggingface.co/lukewys/laion_clap/blob/main/music_speech_epoch_15_esc_89.25.pt) trained on multilingual speech, or just English speech? Was it trained on Spanish speech specifically? I'm asking because I've speech samples of patients reading out two sentences in Spanish.
The other checkpoint for speech was https://huggingface.co/lukewys/laion_clap/blob/main/music_speech_audioset_epoch_15_esc_89.98.pt

Hi,
I don't think we explicitly trained on Spanish speech. I think the speech
here is just very general speech mostly in English.
Lokesha Pugalenthi @.***>于2024年4月5日 周五下午11:13写道：

Was this checkpoint trained on multilingual speech, or just English
speech? Was it trained on Spanish speech specifically? I'm asking because
I've speech samples of patients reading out two sentences in Spanish.
The other checkpoint for speech was
—
Reply to this email directly, view it on GitHub
https://github.com/LAION-AI/CLAP/issues/146, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGXJZ72JNPI3PPJYXHCQF3TY35R5HAVCNFSM6AAAAABF2CU2VSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDSMBUG43DKOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Understanding the complete project workflow

Hello Team,
@frjo @fourthletter @ei8fdb
Creating this issue to understand the complete project workflow and requirements at one place. This will help me in planing/prioritising work and in collaborating with a new developer that I will work with. Later on we can create a WiKi from these information: which would be helpful for anyone who is new to the projects part of Hypha system.
I'll be describing what we have and what we're planning, according to my understanding.
Please let me know if something is missing or anything that needs to be deprecated.

A project gets created when a submission is approved. There is also an issue to create projects without an application https://github.com/HyphaApp/hypha/issues/2447
On automatic creation of project we also initialise few of the vendor information.
Once a project is created we see the following informations on projects page:

Where there is an option to upload supporting documents. This allows applicant to upload documents of different category:

Do we still need this feature or anything that needs to be modified?
Once a project is created a lead must be assigned.
Then we see the option to setup vendor/contractor: where vendor fill up their banking information and upload tax documents etc.
And an option to add Approval Form which I think is related to the contract creation and management process  This is something which needs to be completed before vendor can generate invoices and start receiving funding. We are targeting this work once the payment process is complete.
Once a contract is uploaded-signed and approved we see the option to add invoices.
Project invoicing process is almost complete at https://github.com/HyphaApp/hypha/pull/2450; That means we can remove the old implementation of Payment Requests, which is work in progress: https://github.com/HyphaApp/hypha/issues/2579.
We would still need to work on the invoicing process more. E.g. How will the flow will be with different level of user PM/Finance-1/Finance-2 and for a project which doesn't have any deliverables.
If a project has deliverable, a way to add them on an invoice is already done: https://github.com/HyphaApp/hypha/pull/2556
Different issues related to invoices that needs to be addressed:
Finance level 1 user needs to approve a fixed-price invoice https://github.com/HyphaApp/hypha/issues/2444
PM can request modifications to fixed-price invoice https://github.com/HyphaApp/hypha/issues/2453
Finance level 1 can request modifications to a fixed-price invoice  https://github.com/HyphaApp/hypha/issues/2454
Finance level 2 can request modifications to a fixed-price invoice https://github.com/HyphaApp/hypha/issues/2457
Finance level 2 user can review and approve a fixed-price invoice https://github.com/HyphaApp/hypha/issues/2445
Other related tasks for projects:
Add a summary field to projects https://github.com/HyphaApp/hypha/issues/2448
Update information displayed in project Activity feed https://github.com/HyphaApp/hypha/issues/2458
Activity and Communication tabs should indicate unread messages and updates https://github.com/HyphaApp/hypha/issues/2479
[Meta] Project Page Notifications https://github.com/HyphaApp/hypha/issues/2477
Add files tab to individual project view for finance user https://github.com/HyphaApp/hypha/issues/2414
Update invoice table on dashboard and add a invoice/all page https://github.com/HyphaApp/hypha/issues/2399
Integration of different third party payment services
Currently we are working on the SageIntAcct integration for open tech fund.
[META] IntAcct API extension  https://github.com/OpenTechFund/apply-app/issues/1
Hypha will only create invoices in IntAcct, what info is needed from IntAcct? https://github.com/HyphaApp/hypha/issues/2578
The integration needs to be done in such a way that it is easy to configure and add support to other payment services for other organization.

Thanks @Erioldoesdesign, that will be useful for onboarding someone to Hypha.
However, this issue is specifically related to projects part of hypha. E.g. All the things that happens to a submission when it is approved...we create a project from that submission.

Okay good to know, this sounds like a hypha instance specific request for workflow walkthrough for projects which I also want to understand and know more about. I requested this walkthrough via email to OTF today and I'll see when it might happen. :)

@sks444 I'm touching base to see if you have time over the next few weeks to write up security documentation for these features? For example, the type of testing you did related to security. Thank you!


Incremented version to 2.1.1.

Coming from https://github.com/opensearch-project/opensearch-build/issues/1818 post release activities.

@gaiksaya the issue here is that the CI is trying to fetch 2.1.1 from online but it doesn't exist yet. This was fixed and merged into main and 2.x but not in time for 2.1. We could just merge this now and this CI will pass for the next 2.1.1 build that AD is in. Do you recommend doing that since we probably shouldn't merge this CI fix for 2.1?

Closing this as 2.2.0 is released and this version won't be released now.
Thanks!


big issue

rust server template when

boost

NEVER

not complete. fix now

NOT COMPLETE MANTUSHKA FIX IMMEDIATELY

I already completed this 90 years after


Update myproject.java-conventions.gradle

I've replaced sourceSets.main.java.outputDir with sourceSets.main.output.classesDirs to include executables written in different languages other then java. Otherwise their executables are not included as source-output-folders

@ahmetgeymen Thanks for the enhancement!


Feedback on the hindi fientuned model

I just tried out the hindi model, the outputs were very inconsistent and illogical. Do you think pretraining it with the new syllables from a custom tokenizer should make it better? are you planning to add that to the pipeline?

Biggest problem with Hindi is we generated the dataset while we only had OPUS and those are terrible for Hindi (and a few others, some of which we did over but not Hindi yet).
I would suggest you try benchmarking and re-translate.

hmmm okaay, but i can wrap my head around how only instruct finetuning will be able to give consistent results? especially for a new language , can you perhaps share your thoughts on that too😅

the Hindi syllables and alphabets generated are fine, but the response to the query is all over the place tbh

Well so far I have mostly been using and testing Roman/Latin languages and those work fine. Japanese was really crap (valid characters and tokens but wrong grammar, nonsensical answers and even weird punctuation everywhere) but that was solved by better translation in the very first step.
Doesn't go by saying that Hindi tokens in llama's tokenizer will be heavily under-represented but extending vocabulary is not at all easy to do unfortunately.
You could however try a vanilla llama instruct (like NousResearch') and see if it can at least understand Hindi well enough (it can for example understand Dutch and German to some extent). That should at least should the tokenizer can make sense of the characters and that gives a solid base for proper finetuning.
There are other base models with far richer vocabulary that you may want to explore but mind you most are huge (like BLOOM, it has a super large vocab) and finetuning them requires modifying a lot of the parameters in our finetune script. You might get luckier with Axolotl in that scenario, where you could still use our translate and thread creation scripts.
Let me know if this helps, maybe I'll do some investigation into Hindi specifically in the near future to tag along and see what we can improve.

thank you for the well written answer, ill stick around and if i find anything ill keep you posted on this

So I checked for Hindi specifically and actually OPUS seems to be amazingly good at it (at least BLEU and CHRF wise). That should mean that the translations are pretty okay (feel free to validate as I do not speak Hindi: https://huggingface.co/datasets/UnderstandLing/oasst1_hi). If that is the case it should be in either the templating, finetuning code or inference code.
The templating we have slightly changed by using the official llama-tokenizer templates now (we mimiced those before but there are slight nuances) so that might be a good first step. Then obviously a new finetune is required and in inference we would need to follow the same templating (this is still on our todo list).

yeah the translations on most part is fine tbh, alright lemme see, thanks!


Seek not working for my stream

Hi, I'm testing this stream at http://shaka-player-demo.appspot.com/ and if I seek to any position, player stops and I get several errors in console: Error: An unknown error has occurred in the CDM.
at Error (native)
at ic.h.Od (http://shaka-player-demo.appspot.com/shaka-player.compiled.js:65:113)
PS: if stream does not work, just ask another one... they are tokenized streams

When I play this content, without seeking, I find that the video stalls at 9 seconds.  When I've seen this behavior in the past, the problem is usually that the license we received did not contain the correct key.
Unless you specify a license server URL in the test app UI, the license server used is http://widevine-proxy.appspot.com/proxy .  My guess is that this is not the correct license server for this content, and that we get 9 seconds of playback because the first 10 seconds of the content are clear.
I can't reproduce the behavior you are describing.  Is there a license server URL I should be using to override the default?

You're right, sorry. I'll test with the right license server.
Mt actual problem is that seeking takes too long, sometimes 10 seconds
(when using the right license server)
On qua, 17 de jun de 2015 at 21:37 Joey Parrish<EMAIL_ADDRESS>wrote:

When I play this content, without seeking, I find that the video stalls at
9 seconds. When I've seen this behavior in the past, the problem is usually
that the license we received did not contain the correct key.
Unless you specify a license server URL in the test app UI, the license
server used is http://widevine-proxy.appspot.com/proxy . My guess is that
this is not the correct license server for this content, and that we get 9
seconds of playback because the first 10 seconds of the content are clear.
I can't reproduce the behavior you are describing. Is there a license
server URL I should be using to override the default?
—
Reply to this email directly or view it on GitHub
https://github.com/google/shaka-player/issues/107#issuecomment-112994553
.


Is there any scripts relatable to training are available?

I've seen few issues where people were trying to train the network, but cant find any training code. Is there anything available? I'm interested in loss function, pipeline for data and depth preparation for loss function, it seems rather complicated from reading the paper.

Hi! together with my colleague we made an attempt to reproduce the training script here: https://github.com/antocad/FocusOnDepth check it out if you are interested!


GoEmotions religion and name masking resources

Hello @ddemszky  @dattias and @eladeban,
I'm trying to apply your model to some text that is not part of the GoEmotions dataset.
To do so I need to mask the input text in the same way you do, that is replacing religions and names with the [RELIGION] and [NAME] tokens.
In the paper I read that the list of religion terms is included with the dataset, but I can't find it, maybe I'm looking in the wrong places?
Also, I'm looking for the BERT-based NER model you used for name tagging, do you have a link to the model by any chance?
Thank you very much!

Same question ! Did you solve it ?

Nope, also asked for the BERT NER model directly to the authors no answer there as well.
I've used my own list of religions to tag the religions and another NER model to tag the names ¯_(ツ)_/¯

Thanks for these questions! For NER, we used the model described in the paper by Tsai et al. (2019). We used an internal version of it, but I found a public-facing Github repository, which seems to include this model, so you might find it useful. We'll get back to you regarding the other masked tokens. Hope this helps!

Thanks for these questions! For NER, we used the model described in the paper by Tsai et al. (2019). We used an internal version of it, but I found a public-facing Github repository, which seems to include this model, so you might find it useful. We'll get back to you regarding the other masked tokens. Hope this helps!

Thank you ^^ I'll check it out and hopefully get back to you.

An update regarding the masked tokens: we won't be able to release that list for now unfortunately, but you can recreate the tokens based on the Reddit comment ids. You can use diff to compare the comments in the dataset to the raw comments and you should be able to recreate those lists!

@ddemszky This is rather a preliminary question: After getting the tags and making all of what you mentioned. Do I add the  and  tokens as using tokenizer.add_tokens(["NEW_TOKEN"]) as discussed in here ( https://github.com/huggingface/transformers/issues/1413 ) , then train the model, or are there any pitfalls before getting to training?
Thank you again for your time and effort ^^


v1.11.0 release

Bump up version to v1.11.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


/rescue has lots of 13 MB files, totaling 850 MB

Describe the bug
/rescue has lots of 13 MB files, totaling 850 MB
To Reproduce

Run Live ISO

FreeBSD% ls -lh /rescue
total 1741939
-r-xr-xr-x  146 root  wheel    13M 19 März 07:03 [
-r-xr-xr-x  146 root  wheel    13M 19 März 07:03 bectl
-r-xr-xr-x  146 root  wheel    13M 19 März 07:03 bsdlabel
-r-xr-xr-x  146 root  wheel    13M 19 März 07:03 bunzip2
...

Expected behavior
Symlinks rather than copies are used for all the 13M files
Version (please complete the following information):

[x] Live ISO
[ ] Installed system to disk
FreeBSD version (System --> About this Computer): FreeBSD 13.0-RC3
helloSystem build (cat /.url): 0E63 for commit: c3247f1

They are hardlinks :)

D'oh. Makes sense!