TypeError: cannot unpack non-iterable NoneType object

On Linux and Pythran 0.10.0:
def triad(a: f32[:], b: f32[:], scalar: f32, c: f32[:]):
    N: i32
    i: i32
    N = size(a)
    for i in range(N): # type: parallel
        c[i] = a[i] + scalar * b[i]

def main():
    a: f32[10000]
    b: f32[10000]
    c: f32[10000]
    scalar: f32
    i: i32
    nsize: i32
    scalar = 10
    nsize = size(a)
    for i in range(nsize): # type: parallel
        a[i] = 5
        b[i] = 5
    triad(a, b, scalar, c)
    print("End Stream Triad")

and:
$ pythran doconcurrentloop_01.py
WARNING:root:No pythran specification, nothing will be exported
Traceback (most recent call last):
  File "/home/certik/miniconda3/envs/pythran/bin/pythran", line 11, in <module>
    sys.exit(run())
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/run.py", line 176, in run
    pythran.compile_pythranfile(args.input_file,
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/toolchain.py", line 473, in compile_pythranfile
    output_file = compile_pythrancode(module_name, fd.read(),
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/toolchain.py", line 394, in compile_pythrancode
    module, error_checker = generate_cxx(module_name, pythrancode, specs, opts,
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/toolchain.py", line 138, in generate_cxx
    pm, ir, docstrings = front_middle_end(module_name, code, optimizations,
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/toolchain.py", line 105, in front_middle_end
    refine(pm, ir, optimizations)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/middlend.py", line 33, in refine
    pm.apply(NormalizeStaticIf, node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 237, in apply
    return a.apply(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 200, in apply
    new_node = self.run(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 188, in run
    n = super(Transformation, self).run(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 96, in run
    return self.visit(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 78, in visit
    return super(ContextManager, self).visit(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/transformations/normalize_static_if.py", line 130, in visit_Module
    self.generic_visit(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/ast.py", line 447, in generic_visit
    value = self.visit(value)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 78, in visit
    return super(ContextManager, self).visit(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/transformations/normalize_static_if.py", line 180, in visit_FunctionDef
    self.cfgs.append(self.gather(CFG, node))
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 101, in gather
    return a.run(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 164, in run
    return super(FunctionAnalysis, self).run(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 122, in run
    super(Analysis, self).run(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 96, in run
    return self.visit(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/passmanager.py", line 78, in visit
    return super(ContextManager, self).visit(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/home/certik/miniconda3/envs/pythran/lib/python3.8/site-packages/pythran/analyses/cfg.py", line 51, in visit_FunctionDef
    currs, _ = self.visit(n)
TypeError: cannot unpack non-iterable NoneType object

If you try to compile this code with the master branch of Pythran, you will get a bunch of nice erros like
triad.py:1:13 error: Unbound identifier f32
----
def triad(a: f32[:], b: f32[:], scalar: f32, c: f32[:]):
             ^~~~ (o_0)
----

But the following will work like a charm:
import numpy as np

def triad(a, b, scalar, c):
    N = len(a)
    for i in range(N): # type: parallel
        c[i] = a[i] + scalar * b[i]

def main():
    a = np.empty(10000, dtype=np.float32)
    b = np.empty(10000, dtype=np.float32)
    c = np.empty(10000, dtype=np.float32)
    scalar = 10
    nsize = len(a)
    for i in range(nsize): # type: parallel
        a[i] = 5
        b[i] = 5
    triad(a, b, scalar, c)
    print("End Stream Triad")

I'm not aware of the f32[1000] syntax nor the size function. Do you have pointers to documentation on those? Thanks!

I'm not aware of the f32[1000] syntax nor the size function. Do you have pointers to documentation on those? Thanks!

That was my own syntax, I just forgot to remove it when trying pythran, but since I got the stacktrace, I reported it. I think this is now fixed in master. Thanks!


I would like to add a command that prints a random joke form the Joke API.

I would like to add a command that prints a random joke form the Joke API.
Originally posted by @muditmahajan21 in https://github.com/KieranRobson/Clarence-Bot/issues/26#issuecomment-1277127402

I would like to work on this

To ahead @muditmahajan21!

Implemented within #39


Route [canvas.home] not defined.

i have just followed the instructions from https://cnvs.readme.io/v3.2/docs/integrating-canvas-in-an-existing-project
i have no idea whats wrong.
when i go to /admin. i am redirected to my main login page (not from canvas login page). i tried /auth/login then i get error
"Session store not set on request. (caused by the {{ old('email') }}). i  have removed it and then i get new error  Route [canvas.home] not defined. from the  "<a href="{!! route('canvas.auth.password.forgot') !!}" "
im using laravel 5.3

Thoughts on this @reliq?

@austintoddj , @azorpax this sounds like there may be another route defined at /admin within the application.
See https://cnvs.readme.io/v3.2/docs/integrating-canvas-in-an-existing-project#section-routing
Ensure that you have no conflicting routes. Use php artisan route:list from the terminal to see what routes are defined.

No conflicting route for /admin. I even changed the admin prefix to /canvas. Still the same behavior,it will redirect me to my main login page.
I also checked the route:list. I can't find the canvas.home

Hmm, I see.
You may try re-defining the canvas.home route at the end of your application's routes/web.php. Similar to:
Route::get('/some-address', 'Canvas\Http\Controllers\Frontend\BlogController@index')->name('canvas.home');

or
You may also try changing the blog path in canvas' config file.
eg.
/*
  |--------------------------------------------------------------------------
  | Canvas Configuration : Blog Prefix
  |--------------------------------------------------------------------------
  |
  | Main prefix for blog.
  |
  */
    'blog_prefix' => 'myblog',

One of these methods should at least remove the canvas.home error.
Let us know if nothing changes.
Cheers :beers:

I added the Route::get('/some-address', 'Canvas\Http\Controllers\Frontend\BlogController@index')->name('canvas.home'); to my main router and then i tried to open /auth/login
and its fine, but when i add back the {{ old('email') }} to the email field. i get this error "Session store not set on request."
i also have this 'admin_prefix' => 'canvas',
when I access the /canvas I am redirected to the main login, not the canvas login (/auth/login).

I have no problem with /blog or /myblog as your suggestion. I can view the page of articles.
what I'm having trouble is accessing the backend (admin side)

i tried to create a new laravel 5.3 project. fresh install.  just to check if its working. i followed the instructions from https://cnvs.readme.io/v3.4/docs/integrating-canvas-in-an-existing-project but i get the same error from my previous project.

up

I'm sorry for the delayed response @azorpax.
We will have to look into this routing issue in further detail. Usually the Session store not set on request. error occurs when one or more of your interacting routes are not defined within the web middleware.
The responses to this question may shed some light: https://stackoverflow.com/questions/34449770/laravel-session-store-not-set-on-request
:beers: cheers!


Tool Details Page

Description
Present the data from a detail page

This is done as well with #16


Bug in transliteration of numbers

input: Spiele jetzt Station ROM 106.5 FM von Tune in
output: spiele jetzt station r -- o -- m eintausendfünfundsechzig f -- m von tune in

Hi - this is somewhat not a clear bug: It translates/transliterates german numbers, which means decimal points like "." are not allowed, i.e. not supported. Try 106,5 for a change. This should work. I think this is more of an enhancement or more robust handling needed to find out about "irregular" or "illegal" numbers (in this way, the dot is just removed and the 106.5 becomes 1065 as it reads).


Update Wikipedia bot to reply to multiple user private chat

Similar approach to the help bot update.

Automated message from Dropbox CLA bot
@neiljp, it looks like you've already signed the Dropbox CLA. Thanks!

Do we want to make this pattern something that the bot library can do?  E.g. self.reply_to(message), or maybe even extract an even nicer self.send_reply() pattern that sets type and to automatically?

I went ahead and merged this; we can do that in a follow-up PR :).

Follow-up PR in #4935.


Investigate using Sox

@wetdog suggested using Sox to generate spectrograms.
What are (dis)advantages over obspy/scipy? If there is no processing we could just drop Python and use bash+Sox I guess (or even some light processing, see link above).
float32 spectrogram:

So turns out that Sox is actually pretty fast

That's great, I think that you can get rid of the colorbar and the axes labels with the flag -r

Yup, that's true, -r will create a raw spectrogram. But @valentina-s  actually requested to add dB scale to the spectrograms generated using Python (#6) so we'll probably keep them. And as @yosoyjay correctly noted if we need raw spectrograms for later processing it's really easy to cut them out from the image.
But for now, we are sticking with Python because it is easier to use different tools operating on the raw data, rather than using Sox + something else on images.


Remove arguments from else and end* block termination commands

I took the liberty to partially implement issue #7.  The attached patch removes all arguments from the else and end* block termination commands.  CMake doesn't complain about any syntax errors with the PR applied.

Thanks for the PR.
To avoid merge conflicts, I suggest we integrate your patch after PR #113 is integrated.

To avoid merge conflicts, I suggest we integrate your patch after PR #113 is integrated.

Sure thing. Just ping me when I should rebase this PR.

Sounds good :+1:
Thanks for the help.

I've updated the patch accordingly.
However I noticed something that seems to be a bug in the py3k code. I will write a line comment there.

Well, Github doesn't let me write my line comment.  I'm talking about cmake/extensions/CMakeLists.txt:377. Shouldn't this be an elseif instead of an else?

@adrianbroher Thanks for review :smile:   Good catch :+1:
Submitting a patch now,

Re: https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/114#issuecomment-202830758
Fixed in https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/commit/ce81ce25db7ab97e3a8dbbe8bc46df265e14e694


Broken Link

https://dev-docs.bevyengine.org/bevy/app/bevy_ecs::schedule::Schedule
gives me a 404
followed the link from this page
https://dev-docs.bevyengine.org/bevy/app/struct.ScheduleRunnerPlugin.html

related to https://github.com/bevyengine/bevy/issues/3654 and https://github.com/rust-lang/rust/issues/81979

@caperaven how to fix this
Can I try?

I think this should be marked as a dup of #3654.
It appears that many (or all?) inter-crate doc links are broken in this same way. It also appears to be a rustdoc bug, so I'm not sure if there is anything we can do about it in Bevy. Rust analyzer confirms that it's a valid doc link, but rustdoc doesn't convert it properly. So it makes it a local link to the current crate, which fails with 404.

Closing as this as a duplicate of #3654, which looks to be resolved now.


Support sending raw transactions

The java sdk should support sending raw transactions i.e. the actual bytes.

Solved in https://github.com/Concordium/concordium-java-sdk/pull/56


added Java code for Next Greater Element

Added second version of NGE (Next Greater Element) Problem

Can u plz merge my pr

@Yuktikashyap I have merged PR
Please check


Services menu in JLab has multiple behaviors

Context
The services menu in JLab behaves differently based on which of the options you choose. Its disorienting for users when conda-store opens within the JLab window, but other options open in a new tab.
A solution would be to visually breakdown the services menu so users have a concept that the behavior is different.
Here is an initial design for this breakdown:

Value and/or benefit
Users have a visual indication that some services are different from others and therefore the result of clicking on them is not disorienting.
Anything else?
No response

"internal"/"External" isn't a good description of what these are.

The menu is currently defined in:
https://github.com/nebari-dev/nebari/blob/d22e5cbb58b8566a0626a2d95e53ad684d40e986/src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/jupyterhub/files/jupyterlab/overrides.json#L47-L108
Some functions are implemented in https://github.com/nebari-dev/jupyterlab-nebari-mode extension. For compatibility when jupyterlab-conda-store extension is disabled or not installed it will open the Environment Management tab externally in new tab.

We can add the divider easily. We can add non-clickable "Internal"/"External" entries. We can:

prepend icons
target individual menu items with CSS to customize it (it is a bit hacky but possible)

The problem will be if an admin disabled https://github.com/conda-incubator/jupyterlab-conda-store and now it does not open in JupyterLab.
I think I would prefer to change the menu items to show [↗] as the label can be set  separately for the scenario  when jupyterlab-conda-store is installed vs when it is not.

I agree internal/external seems arbitrary.  Conda store (Environment Management) is external to Nebari as well.  It just happens to be developed by Quansight as well, but it's a separate open source project the same as Keycloak (User Management) or any of the others.

I think I would prefer to change the menu items to show [↗]

I love this idea!


Add Announcement

Dear Colleagues,
We are pleased to announce the winners of the 2021 International Glycoconjugate Organization Awards
The laureate of the 2021 IGO Award is: Professor Dr. Els Van Damme, Dept. Molecular Biotechnology, Ghent University, Belgium
The laureate of the 2021 IGO Young Glycoscientist Award is: Dr. Elena Chiricozzi, Dept. of Medical Biotechnology and Translational Medicine, University of Milan, Italy
Due to the pandemic Covid-19, the glyco26 programmed for the end of August 2021 in Taipei has been postponed to August 2023.
The two laureates will present their recent research by online seminars programmed for August 31st, 2021. Announcement  on the link to connect with the presentations will be available in August.
The International Glycoconjugate Organization

We also need to remove old announcements.


HW3: what is considered rare?

This isn't a code based question.  In the homework it states:
Extract the AF_EXAC data to determine the rarity of the variant
If the disease is rare:
return an a list of associated diseases
If the disease is not rare:
return an empty list
I am unsure of what cutoff to use for a rare variant.  People in my lab said they were thinking around 1%, or using a minor allele cutoff depending on the size of the dataset. For this we would use frequencies since that is what we get from AF_EXAC.  Maybe I missed this somewhere in the notes, but I couldn't find a cutoff to use for this.

The Notebook is slightly less informative than the Canvas assignment. For the Canvas assignment:
If the variant is rare (value for the AF_EXAC key < 0.0001)


Axis Sync warning is still showing after the Sync

Describe the bug in current situation
The warning banner still shows once you sync with AXIS after Open/CFR state.
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Chance of Occurring (high/medium/low/very low)
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:

Go to Add request
Enter valid AXIS ID and Sync with Axis
Save request
state change to Open
Edit applicant name and save
Warning banner shows and Sync with Axis button enabled
Click on sync with axis and save

Actual/ observed behaviour/ results
The warning banner still shows and the sync with axis button enabled. Nothing shows on click of the button. The banner disappers when you refresh the page.
Expected behaviour
The warning banner should get disappear and the button should be disabled as the changes are already synced
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

Tried a variety of different syncs - the banner goes away and sync is disabled when the sync happens... considering this one closed - nice work! @aparna-aot


Error in margin calculation for XAUUSD

Hi, i have noticed that in the margin tab the calculation for the specific contract is incorrect...
On the specific contract the margin is calculated like this:
(trade size * contract size * price / leverage) * margine rate
On this particulare broker the leverage is 4 and the margin rate is 3 so the calculation is:
(0.07 * 100 * 1900.00 / 4) * 3 = 9975$
But the position sizer give me the value of
(0.07 * 100 * 1900.00 / 4)  * 2.5 = 8312.5$ that is the value calculated with margin rate maintenace 2.5
Is it possible to add a textbox were insert a custom margin rate alongside the custom leverege that is in place now or let the user chose the margin rate initial or maintenace?

Thank you for letting me know. I will consider adding both calculations.

Hello! Could you please let me know which broker is that, so I could test?

Hello, it's a prop firm not a broker...

Yes sure, the prop is the5ers.

Hope you got the demo for testing this fix...

Sorry, they refused to provide a demo account. I couldn't find any other broker that have different but non-zero initial and maintenance margin. Besides, I've been busy with another project.
I will soon prepare a fix for this and will send you a beta, so you could see if it works in your account.

Ok, i'm very sad that they not provide you a demo to improve a strument like this... i'm looking for the beta to test your proposed fix and i will tell you if its work. I know its very hard to fix thing without testing in first person

Hello @maccieddu ! Was this on a netting account or on a hedging one?

In theory the formula would be this:
(Volume in lots * Contract size * Open market price / Leverage) * Margin Rate? for example:
(0.42 * 100 * 1923.00$ / 10) * 3 = 24229.8 <---- (3 is the initial margin) the account is of 25k
with position size calculator that propose me 0.49 lot max the calculation is this:
(0.49 * 100 * 1923.00$ / 10) * 3 = 28268.1 <---- (3 is the initial margin)
i think the problem is the margin rate used in the formula

Maybe this lines of code are where the margin is calculated and they use maintenace_margin_rate instead of initial_margin_rate

Yes, please try this one.
Position Sizer.zip

Attached a wrong file in my previous (deleted message). Please use the one attached here.
Position Sizer.zip

It seems to be going much better now.

However, I continue to notice very small differences, in the other pairs, between the values calculated with the tool provided by the prop and with the values calculated by the position sizer, at this point I believe that each instrument (forex, indices, metals) has its own formula for the calculation of the required margin.

Make sure you are attaching the version that I uploaded in this thread. It should say "ver. 3.062" in the header. The last four screenshots show "3.06".

As for the remaining difference (0.41 vs 0.42), it might be attributed to rounding down vs rounding up. But if you notice a bigger difference, please let me know.

Is the initial margin on SP500 and EURUSD also larger than the maintenance margin?

Thank you! Is your account in USD?

Yes sir.

The Position Sizer uses Free Margin for max position size calculation. Perhaps, you have open trades and the firm's calculator is using balance or equity for its calculation? Could you please check?

I send you screenshot with no trade open, so equity is equal to balance

Perhaps the problem is that every asset have is own margin calculation? https://www.metatrader5.com/en/terminal/help/trading_advanced/margin_forex
If you read in the last screen shot on the row: calculation, one have type forex and one CFD leverage

Do you know your account's stop-out level? It's another factor considered by the Position Sizer when calculating the Max Position Size by Margin.

You are refering to this?
https://www.babypips.com/learn/forex/what-is-a-stop-out-level

Yes, it's different for each broker. The attached script prints your account's stop-out mode and level when you run it. Could you please let me know what it says?
PrintStopOut.zip

And your current free margin is?

The account start size is 25000$ now is 24387.90$

Ah ok now sound good, so the position size is more reliable of firm's indicator if i understand good?

I don't know. The Max Position Size feature in the Position Sizer is designed so that if you take that trade, you will be as close to the stop-out as possible without actually getting stopped out (OK, you'll probably get stopped out anyway due to the spread, but still...).
It looks like their calculator, doesn't consider the stop-out level at all. So, taking a trade size that it offers will likely result in an immediate stop-out regardless the current spread or anything like that.

I think you are right, therefore i continue to use position sizer as only reference to risk.
So you think that now implement the double visualization of maintenace and initial margin is worth, maybe the initial margin only is the best option for the broker that provide two different margin rate?

Fixed in 3.07.


Lift the int instruction

Looks like currently Binary Ninja does not lifts (I guess it is called lifting?) int instruction. It's a bit sad to see undefined in HLIL.

Fixed at https://github.com/Vector35/arch-x86/commit/ce54c270537a36255608cd1f67df64f971558d0e, will be in dev soon.


Issues running

Hi, Thank you for your great work.
When I try to run training code
!accelerate launch --mixed_precision fp16 train_t2i_custom_v2.py --config=configs/custom.py\

I receive the following error:
TypeError: __init__() got an unexpected keyword argument 'debug'

Thanks in advance :)

Can you provide more detailed error information? For example, which file reported an error?

I get the same problem:
/usr/lib/python3/dist-packages/requests/init.py:87: RequestsDependencyWarning: urllib3 (2.1.0) or chardet (4.0.0) doesn't match a supported version!
warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "
Traceback (most recent call last):
File "/u/ipu/.local/bin/accelerate", line 8, in
sys.exit(main())
File "/u/ipu/.local/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 43, in main
args.func(args)
File "/u/ipu/.local/lib/python3.10/site-packages/accelerate/commands/launch.py", line 747, in launch_command
defaults = load_config_from_file(args.config_file)
File "/u/ipu/.local/lib/python3.10/site-packages/accelerate/commands/config/config_args.py", line 64, in load_config_from_file
return config_class.from_yaml_file(yaml_file=config_file)
File "/u/ipu/.local/lib/python3.10/site-packages/accelerate/commands/config/config_args.py", line 117, in from_yaml_file
return cls(**config_dict)
TypeError: ClusterConfig.init() got an unexpected keyword argument 'debug'

I think this is probably a problem with the running environment? You can see the link below to install
Dependencies here


build succeed , but run failed with bug   cannot access  "_export_sfc"

Describe the bug
it is ok at dev server , and build succeed .  but  when run the built  files at browser
error  came .
here is  the error   flow
Uncaught ReferenceError: Cannot access '_export_sfc' before initialization
at KIcon.vue:4:33
and the built code is below
const KIcon=_export_sfc(_sfc_main$w,[["render",_sfc_render$h],["__scopeId","data-v-d325524f"]])
Reproduction
none
Steps to reproduce
npm install
System Info
64 win 11

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@daaku @kamui


dev-cmd/bump: add cask support

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

This PR adds cask support for brew bump. Additionally, some other changes have been made:

The earlier pagination handling for the Repology API was incorrect (used last package index rather than name), that has been fixed and confirmed to work now.
The --limit flag will work only if --formula or --cask have been provided (although this can be changed).
A --no-pull-requests flag has been added to prevent fetching PRs from GitHub.

Other things to handle here or in follow-up PRs:

Distinguishing between formulae and casks with the same name (in the command output).
Fetching all PRs first if required, to prevent GitHub API rate limiting.

Review period will end on 2021-02-17 at 18:57:31 UTC.

Review period ended.


Bulk export with all columns

Hello,
In my table I'm not showing all columns, when I select some rows in the bulk it does not export all column from form but from the table, here is my code:
->bulkActions([
    ...,
    ExportBulkAction::make(),
]);

Sorry, I don't understand your issue.

@pxlrbt In the table I'm showing 4 columns from DB, but in the form I have more then 10, when I make export it does not export all columns just the 4 columns in the table

That's just the default. You can use fromTable() to use the table as a basis. Please read the readme.


chore: fix heritage links

Description:
This PR fixes the issue with the docs rendering. Please see more details in this issue: #6427
One note: I took {% if clause.doc.path %} section from Angular docs to check if the doc has the path - if it has it, then render the <a> tag; otherwise, render only text.
Related issue (if exists):
Closes #6427
Related angular/angular#43956

Ping @niklas-wortmann can you have a look please?


Don't enable matrix by default

Matrix is enabled by default, I'd expect everything to be disabled by default and then I only need to enable the stuff I actually want to run. Right now I have to manually disable matrix.

I originally enabled matrix by default because 1. it doesn't require any configuration, 2. if you don't set that path in your reverse proxy, it won't do anything, anyways.
Now, I too think it would've been better to leave it disabled (given the proliferation of native matrix gateways and other uses of common proxies); but, there's no way to do it while maintaining backwards compatibility, not breaking people's existing configurations.
So I can't do this until 2.0, sorry.


[hi] Add content/hi/docs/setup/best-practices/cluster-large.md

This PR is a part of ongoing hi localization effort here #29353
/language hi

/assign verma-kunal

/assign

@verma-kunal did you see https://github.com/kubernetes/website/pull/29408/files#r690165033 ?

Thanks for the suggestions @sftim ! Made the necessary changes here🙂

/remove-lifecycle stale

Hey @anubha-v-ardhan, just checking in have we reviewed this PR from a linguistic perspective? If not, please let me know if I can help in an initial review.

@verma-kunal Please could you reopen this PR whenever you're comfortable addressing the suggestions provided? I will be closing the PR since there has been no activity on this PR for a long time.
/close


How to select old() input value after postback using @input_maker_create?

Given this:
@input_maker_create('product', ['type' => 'select', 'options' => $productDropDownListItems])

Where $productDropDownListItems outputs an array of options
[
1 => 'Load',
5 => 'Labels'
]

If the user selects labels... how do tell the input_maker_create to make value=5 as the selected value? I haven't found any examples or any docs referencing this specifically.
Thanks in advance!

Hmm, the InputMaker is designed to work with objects, so after the config array you could do something like:
(object) old()
This sets the old array as an object and should contain the key => value of your input

Can you help me on multiple select?
The code below didn't select anything:
 @input_maker_create('tags', [
       'type' => 'relationship',
       'model' => 'App\Models\Tag',
       'custom' => 'multiple name="tags[]"',
       'option' => $article->tags,
       'label' => 'name',
       'value' => 'id'
])

Hey @amirulfirdaus turns out there was a bug. I've made a fix so now it would look like:
 @input_maker_create('tags[]', [
       'type' => 'relationship',
       'model' => 'App\Models\Tag',
       'custom' => 'multiple',
       'label' => 'name',
       'value' => 'id'
])

I'll release the update later today

Yes, that's what I thought. I did $article->tags->pluck('id', 'name'). Turns out it only select the first value. Thanks for fixing this.


Add support for SpConv 1.1

As SpConv 1.1 is compatible to newer Pytorch versions and able to compile on CUDA-Toolkit 10.2, a support for SpConv 1.1 is much desirable.
This pull request contains a workaround for the VoxelGenerator  class. If available VoxelGeneratorV2 (SpConv 1.1) will be used, otherwise VoxelGenerator (SpConv 1.0) is used.
Let me know what you think.

Hi, thank you very much for the PR.
I didn't merge it before because spconv 1.1 costs much GPU memory and I didn't want to support it at that time.
Currently I have tested with spconv 1.2, and it is fine. So I have modified the codes to support both spconv 1.0 and 1.2, just similar to your PR.
You could refer to here https://github.com/open-mmlab/OpenPCDet/commit/35b68c9241dbb483c00869e535175e923788ef63.
Anyway, many thanks for your PR and welcome any other PRs for this codebase.

Hi
@TillBeemelmanns
We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have a WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤


[Workshop Proposal] Brainstorm for the next chapters

About your workshop
Title
Brainstorm for the next chapters.
Workshop type

[X] Debate
[ ] Hands-on
[ ] Poster creation
[ ] Course

Languages

[X] 🇫🇷
[ ] 🇬🇧

Required knowledge level

Network
Cryptography
Blockchain
General Tech

[X] None
[X] None
[X] None
[X] None

[ ] Beginner
[ ] Beginner
[ ] Beginner
[ ] Beginner

[ ] Advanced
[ ] Advanced
[ ] Advanced
[ ] Advanced

[ ] Expert
[ ] Expert
[ ] Expert
[ ] Expert

Prerequisites for participants

Just you, and your smile 😊

Description of your workshop

Let's talk about the next chapters of "Paris P2P".
For example "Lyon P2P" (#10).
In October, I am going to Lyon for a long time and I would like to try to open a new chapter in Lyon.
How to do it, what are the steps.....?
Who is motivated to join me in this amazing chapter?
We can also talk about the national community, its organization, its tools...

About you

Name: Louise or Delay
Discord handle: Delay #6452
Other contact info: @ParisP2P
Other (your projects, etc...): 42 Blockchain

Related with #10
Related with #22
Related with #28

<3

Announced in #36 and here: https://p2p.paris/en/event/monthly-1/

@lpieri is working on a report that will be pushed as a pull request or somewhere in the WIKI


running form.validate() programmatically immediate after form.init() does not validate

It returns true and shows no errors to user.
This is a problem when running forms (records) programmatically in headless mode.

might be related to OC customization actually

yes


client: errors

When I load the client in my browser, I get the following errors:
socket.io.js:12   ReferenceError: Can't find variable: require
client.html:8      ReferenceError: Can't find variable: io
The client code is:
<!doctype html>
<html>
<head>
<title>Node Test</title>
<meta charset="utf-8">
<script src="/~Beth/Node.js/socket.io/lib/socket.io.js"></script>
<script>
var socket = io.connect('http://localhost:8124');
socket.on('news', function (data) {
console.log(data);
socket.emit('my other event', { my: 'data' });
});
</script>
</head>
<body>
</body>
</html>

You are including the script incorrectly, please see: https://github.com/LearnBoost/Socket.IO/wiki/How-do-I-serve-the-client

Thanks, yeah I finally figured out late last night that you have to serve the HTML pages from the node server instead of a standard server. Unfortunately that's not at all clear on the "How to use" page. I tried to use socket.io on the server with Web Socket on the client which didn't work (and is widely reported as not working). So, given I don't want to use node to serve my plain web pages, I think I'll stay away from socket.io.


docs: update Readme

Description
With summit coming up I thought we might update our README, since delta-rs has evolved quite a bit since the README was first written...
Just opening the Draft to get feedback on the general "patterns" i.e. how the tables are formatted, how detailed we want to show the features and mostly the looks of the header.
Also hoping our community experts may have some content they wat to add here 😆.
cc @dennyglee @MrPowers @wjones127 @rtyler @houqp @fvaleye

Looks like some great improvements!


Remove print statement for rules.py

Remove the print statement from rules.py that is dumped on stdout which is not very clean for scripts and other processes using this awesome library. If logging is required please comment on this pull request and i will add it.

Sounds great! I'm surprised this project hasn't succumbed to bitrot by now :) glad it's useful

Thank you Jared, i used a lot of parser and translators and this is by far the most usable one!


Cannot find package "github.com/sspencer/go-ini"

I'm sorry if it is a problem of my env
So, I've tried to build Stout and I got an error
➜  Stout git:(master) go build -o ../stout src/*
src/utils.go:15:2: cannot find package "github.com/sspencer/go-ini" in any of:
	/home/rmamaev/go/src/github.com/slastique/Stout/vendor/github.com/sspencer/go-ini (vendor tree)
	/usr/local/go/src/github.com/sspencer/go-ini (from $GOROOT)
	/home/rmamaev/go/src/github.com/sspencer/go-ini (from $GOPATH)

I don't understand why it tries to find sspencer/go-ini instead of zackbloom/go-ini (I've downloaded it via godep) but Stout built successfuly after go get github.com/sspencer/go-ini

Any update on this?


kminion fails to export metrics when a broker is stopping, starting or restarting

We have observed that kminion fails to report every metrics when a kafka broker is starting, stopping or restarting.
Once the kafka process stop or start is completed, it starts reporting the metrics again as expected.

Hey, are you using the endToEnd reporting? If so, I believe I'm already looking into this (have not yet found a proper solution though, here's the draft PR: https://github.com/redpanda-data/kminion/pull/252).

We are not using end to end reporting. We are just scraping the consumer lag metrics with kafkaAPI scraping.
Even disabling of logDirs is not changing the outcome :(

So far, we haven't seen any suspicious log messages.
This can be reproduced by,

Keep the kafka cluster and kminion running.
Watch for the consumer lag or any metric you want to monitor through prometheus/grafana
Stop the kafka on one broker. This might result in no metrics exposed temporarily(1 or 2 mins, but depends),  then it resumes exposing the metrics.
After a while start the kafka service on the broker. This might result in no metrics exposed temporarily(2 or 3 mins, but depends). then it resumes exposing the metrics)

This can be reproduced by just restarting the kafka process too.
Please note that, you won't see this absence of metrics every time kafka process is stopping/starting/restarting. However, most of the times it does happen.
Sometimes, kafka process stop and start is so quick it won't happen due to the prometheus scraping interval.

Few more details wrt the kminion logs when one of the broker's kafka service was stopped/started. The scraping mode is offsetsTopic with logDirs disabled.
# kminion logs while broker a1 was being stopped @15:19
{"level":"info","ts":"2024-03-12T15:19:38.163Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[0 3 4 7 8 9 11 16 17 20 21 24 25 26 28 29 32 37 38 41 42 43 45 49]}"} {"level":"info","ts":"2024-03-12T15:19:41.787Z","logger":"main.kgo_client","msg":"metadata update triggered","why":"reload offsets from load failure"} {"level":"warn","ts":"2024-03-12T15:19:43.087Z","logger":"main.kgo_client","msg":"unable to open connection to broker","addr":"broker-a1:kafka-port","broker":"1001","err":"dial tcp broker-ip:kafka-port: connect: connection refused"} {"level":"info","ts":"2024-03-12T15:19:43.344Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[46]}"} {"level":"warn","ts":"2024-03-12T15:19:44.020Z","logger":"main.kgo_client","msg":"unable to open connection to broker","addr":"broker-a1:kafka-port","broker":"1001","err":"dial tcp broker-ip:kafka-port: connect: connection refused"} {"level":"info","ts":"2024-03-12T15:19:45.802Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[1 5 13 14]}"} {"level":"info","ts":"2024-03-12T15:19:47.132Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[47 48]}"} {"level":"warn","ts":"2024-03-12T15:19:47.741Z","logger":"main.kgo_client","msg":"unable to open connection to broker","addr":"broker-a1:kafka-port","broker":"1001","err":"dial tcp broker-ip:kafka-port: connect: connection refused"} {"level":"info","ts":"2024-03-12T15:19:47.995Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[2 6 10 12 15 19 23 27 33 34 35 36 39 40 44]}"}
# kminion logs after broker a1 was started @15:23
{"level":"info","ts":"2024-03-12T15:25:10.674Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[17 21 24 26 32 37]}"} {"level":"info","ts":"2024-03-12T15:25:10.675Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[0]}"} {"level":"info","ts":"2024-03-12T15:25:10.779Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[3 8 16 20 25 29 42 43 49]}"} {"level":"info","ts":"2024-03-12T15:25:10.826Z","logger":"main.kgo_client","msg":"immediate metadata update triggered","why":"fetch had inner topic errors: FENCED_LEADER_EPOCH{__consumer_offsets[4 7]}"} {"level":"info","ts":"2024-03-12T15:25:13.746Z","logger":"main.kgo_client","msg":"metadata update triggered","why":"reload offsets from load failure"} {"level":"info","ts":"2024-03-12T15:25:14.271Z","logger":"main.kgo_client","msg":"metadata update triggered","why":"reload offsets from load failure"} {"level":"info","ts":"2024-03-12T15:25:17.210Z","logger":"main.kgo_client","msg":"metadata update triggered","why":"reload offsets from load failure"}

Screenshot of conumer lag metrics being absent when above stop and start was happening.

Further debugging this issue shows that kminion does expose the metrics every time we query it, but while brokers are being stopped it takes more time for kminion to generate the metrics, most likely because of the failing connection to the broker being stopped. The typical 6-7sec response time increases to 15-20sec that's more than the scrape timeout on the Prometheus servers, that's what is causing the missing metrics.
The question is whether it's possible to handle the failing broker connections in a way that it doesn't increase the response time.


Add helper for waiting for a signal inside a future

woab::wake_from is probably mostly useful for waiting for a signal. You connect an handler that sends the result and wake the wake_from call. The problem is that the handler remains connected, and even if it doesn't do anything on future invocations (other than trying to send the result and failing) this is still a leak. This may be fine for dialogs, that quickly get tossed away, but if you want to wait on a signal of a more permanent object this can be a problem.
We need an helper that disconnects the signal after waking up.

The main problem is that in order to disconnect a signal handler, we need both the handler ID and the GLib object. Maybe we can just pass it to the helper:
woab::wake_from_signal(&button, |tx| {
    button.connect_clicked(move |_| {
        let _ = tx.try_send(2);
    })
}).await.unwrap();

I'm half minded to pass it to the closure as argument
woab::wake_from_signal(&button, |button, tx| {
    button.connect_clicked(move |_| {
        let _ = tx.try_send(2);
    })
}).await.unwrap();

But I'm not really sure if that's needed - after all, the closure is not a move one and you don't need a mutable reference to add/remove signals. Passing it to the closure would be useful if you are creating the widget on the spot - but that would usually mean that the widget is also destroyed on the spot, in which case you don't need to worry about disconnecting the signal.

I was also thinking about connecting the signals directly:
woab::wake_from_signal(&button, "clicked").await;

This has the advantage of being so simple. Problem is - it's only simple for the simple case. GTK signals need to deal with inhibitness:
woab::wake_from_signal(&button, "button-press-event", Some(gtk::Inhibit(true))).await;

And what about parameters? I don't want to always return the parameters struct, because that would require copying even when the user just ignores it. I could pass a function that maps it:
let button = woab::wake_from_signal(
    &button,
    "button-press-event",
    Some(gtk::Inhibit(true)),
    |params| {
        let event: gdk::EventButton = params[1].get::<gdk::Event>().unwrap().unwrap().downcast().unwrap();
        event.get_button()
    },
).await;

But what was supposed to be a simple function is starting to get more and more cumbersome...
One option is to use fluent API:
let button = woab::wake_from_signal(&button, "button-press-event")
    .inhibit(gtk::Inhibit(false))
    .map_params(|params| {
        let event: gdk::EventButton = params[1].get::<gdk::Event>().unwrap().unwrap().downcast().unwrap();
        event.get_button()
    })
    .await;

Maybe even make it usable with the woab::params! macro:
let button = woab::wake_from_signal(&button, "button-press-event")
    .inhibit(gtk::Inhibit(false))
    .map_params(|woab::params!(_, event: gdk::Event)| {
        event.downcast::<gdk::EventButton>().unwrap().get_button()
    })
    .await;

And I could have events (once #22 is done) and actions have their own helper functions:
let button = woab::wake_from_signal(&button, "button-press-event")
    .inhibit(gtk::Inhibit(false))
    .map_event(|event: gdk::EventButton| event.get_button())
    .await;

Now - this is starting to look like a good contender! It keeps the base usage dead simple while still allowing more complex usage!
BTW - I'm not sure we need gtk::Inhibit here. inhibit is already the name of the method, so this should be fine too:
let button = woab::wake_from_signal(&button, "button-press-event")
    .inhibit(false)
    .map_event(|event: gdk::EventButton| event.get_button())
    .await;

Actually, it would be better to name that second function wait_for_signal - because the user does not need to handle the waking. So maybe I can just implement both?

To be honest, this whole "wait for signal" thing is out of my use case scope at the moment.

I think run_dialog already covers its main usecase, but I still want to write it because doing the right thing (removing the handler after the wake) is hard to do with wake_from.


exposes aws s3 region

Some more recent AWS regions like eu-central-1 only support Signature Version 4 which is not default authorization mechanism for boto3.
In order to authenticate successfuly with those regions you need to pass region you use to boto3 as AWS_DEFAULT_REGION
Full details here: https://github.com/boto/botocore/issues/424
This PR fetches AWS_DEFAULT_REGION envinronment variable and exposes it to python code.

@michalkalinowski- is exposing it to Django settings enough to get this working?

Possibly a better solution: https://github.com/jschneier/django-storages/issues/28#issuecomment-265876674

Sorry, must have missed the first notification.
Looks like a Good solution. I'll update the PR with those two undocumented options (region and signature).

Closing this PR due to no activity.


Rancher report everything green even canal-node container is down: System Project is needed

Rancher versions:
rancher/server: v2.0.0-beta3
Infrastructure Stack versions:
healthcheck: green
ipsec: green
network-services: green
scheduler: green
kubernetes (if applicable): green
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
DO + RKE
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
3 nodes
Steps to Reproduce:

Deploy following yaml to crash canal-node container (one of three containers the canal pod are running)

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  labels:
    app: canal-crash
  name: canal-crash
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: canal-crash
    spec:
      containers:
      - name: canal-crash
        image: nginx
        ports:
        - containerPort: 80
          name: canal-crash
---
kind: Service
apiVersion: v1
metadata:
  labels:
    app: canal-crash
  name: canal-crash-svc
spec:
  selector:
    app: canal-crash
  ports:
  - name: canal-crash
    port: 80
    targetPort: canal-crash
  type: LoadBalancer

Check kube-system namespace, found canal-node is down

$ kubelet -n kube-system get pod
NAME                                   READY     STATUS             RESTARTS   AGE
canal-6qr4t                            2/3       CrashLoopBackOff   15         1h
canal-dkctf                            2/3       Running            15         1h
canal-rr42s                            2/3       CrashLoopBackOff   14         1h
kube-dns-6f7666d48c-njr65              3/3       Running            0          1h
kube-dns-autoscaler-6bbfff8c44-87wms   1/1       Running            0          1h

Notice Ready is 2/3 instead of 3/3.
Results:
Everything is green for Rancher UI.
Expectation
Rancher UI should report error since key network plugin container is down.

What we are going to do for now, is:

Introduce "system" project
Assign all system namespaces (the list is configurable via settings) to it
UI would display system project, so user can go in and debug if something is wrong, by looking at corresponding network pods/services - very similar to 1.6

In the future, we might introduce one extra layer on top of that like DNS/Networking/etc and display their state in a more friendly way.

https://github.com/projectcalico/libcalico-go/issues/770

Things to test:

On cluster with network provider having network isolation enabled:

traffic from system project's namespace should be allowed to any other namespace
traffic from non-system namespace should be allowed to system namespaces
test against default system project namespaces, like cattle-system, kube-system, alert, logging

We  have to verify the case when namespace was originally a part of non-system project, then got moved to a system project, then got moved back to user project.
Rancher server upgrade use case should be validated as well - try upgrading from 2.0.3 to the branch with the changes
Network provider upgrade with system project in place: flannel->calico->flannel
Cluster upgrade to the newer version with k8s and diff network provider. Like k8s 1.10.1 with flannel -> k8s 1.10.3 with calico

Tested with latest build from master:

Automated test cases for DNS reports success.
Automated test cases for Ingress failed - https://github.com/rancher/rancher/issues/14660

Latest build from master:

Cluster & project level alerts succeeded (to slack notifier)
Pipeline executed without issues
Logging w/ embedded ES & Kibana was successful.

Related issue - https://github.com/rancher/rancher/issues/14769

rancher/rancher:master 8/6
Covered all test cases in test plan.
Validated bugs regarding network policy for hostport/nodeport after moving to/from system project.

After this fix https://github.com/rancher/rancher/issues/14995, sanity checks were done for System projects and the feature is functional.


Searching for update feature does not seem to work

Bug description: When I go into the settings into Updates, there is a button which is grayed out and says "Is searching for update". It never changes to an update found, even if there are newer versions. I have tried this on Ferdi 5.4.0 and Ferdi 5.5.0, both tested today 27 June 2020. Enable Updates and Include beta versions are both enabled.
With version 5.4.0 it should have at least found version 5.5.0, and with version 5.5.0 it should find the 5.6 beta.
Both versions were installed using the Ubuntu .deb file available on the getferdi website. I can also recreate this on my debian workstation which has it installed via the source package (tar.gz).

Steps to reproduce: Go to Settings -> Update (on version 5.5, on version 5.4 just scroll down). Observe the button never changing.

Expected behavior: After a few seconds, the button should change to "Update found, download" or something similar.

Screenshots

Environment:

Operating System: Ubuntu 18.04.4 LTS

Ferdi Version: 5.5.0

Server: Franz

Debug information: https://debug.getferdi.com/94753d3c-9018-4247-96df-fad9848f8a38

Can reproduce. Same thing happens to me. Ubuntu 20.04, installed via .deb.

Duplicate of #329


OPEA/ASR:latest permissions

Normal   Pulling                 8s                      kubelet            Pulling image "opea/asr:latest"
Warning  Failed                  7s                      kubelet            Failed to pull image "opea/asr:latest": Error response from daemon: pull access denied for opea/asr, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
Warning  Failed                  7s                      kubelet            Error: ErrImagePull

This should be resolved when m3 is released by the end July when opea/asr image is published.

can we close it? @endomorphosis

It is not an issue of GenAIInfra. opea/asr image will be published soon. Close it.


Fixing #327 (from https://github.com/SpoonX/aurelia-authentication/is…

…sues/327)

Hello! And thanks for contributing.
I have some requests:

Please change your subject to be a short explanation of what you changed. In the description you can then use something like: fixes #327, so github can automatically link to the issue, and close it on merge.
Please don't do a build / version bump. There's a deploy toolchain that does all of this stuff for us. That makes sure that the PR diff stays readable and minimal, and makes for less merge conflicts.
Please make your commit messages follow our contributing guidelines.

For the rest the fix looks fine to me, thanks again!

Hi. Sorry, I didn't notice the pull request took the build stuff. I did this for us internally as I needed to fix the bug in our application and I needed a release for that...
The intention was only to modify the code, not the build related things...
Anyways, I will create a new pull request according to your request.

@bondib No sorry needed. I'm glad you pointed this out and proposed a fix to begin with. :)


Mark the boot asm as KEEP, for gc-sections

gc-sections is one of the ways GCC can create smaller binaries. This would also be needed for LTO, but I didn't try LTO yet.

Honestly i don't see what it can change when it comes to sega megadrive development ?
I mean the boot section is always located at 0x000000 else it just doesn't work. I don't see how it can reduce binary size here.
Are your changes compatible with older GCC as version 3.4.X ?

On Tue, 17 Nov 2015 12:42:16 -0800
Stephane Dallongeville<EMAIL_ADDRESS>wrote:

Honestly i don't see what it can change when it comes to sega megadrive development ?
I mean the boot section is always located at 0x000000 else it just doesn't work. I don't see how it can reduce binary size here.
Are your changes compatible with older GCC as version 3.4.X ?

If you enable the appropriate options, your program will be smaller,
because GCC/ld can remove unused sections better. Without this patch,
the result is a broken ROM, as the boot section gets removed too.
Many programs get up to 20% smaller with gc-sections, such as the Linux
kernel and busybox.
The patch requires at least binutils 2.18 which was released in 2008.
It does nothing if the GCC and linker options aren't enabled, and so
early GCC will be fine, as long as binutils is new enough.

Ok, i will test that patch on my windows setup with GCC 3.4.6 (which is the default setup in SGDK) and if it work i will apply the merge operation. Thanks for your contribution :)

On Wed, 18 Nov 2015 01:31:39 -0800
Stephane Dallongeville<EMAIL_ADDRESS>wrote:

Ok, i will test that patch on my windows setup with GCC 3.4.6 (which is the default setup in SGDK) and if it work i will apply the merge operation. Thanks for your contribution :)

Can I ask why is the Windows default so old? I use it on Linux via
gendev, and it's on GCC 4.8.

Because older GCC generate better code for old CPU (as 68k family). Newer GCC code generation is very convoluted and that really impacts final performance (i observed up to 40% slower code) and code size is bigger as well.

On Wed, 18 Nov 2015 04:47:36 -0800
Stephane Dallongeville<EMAIL_ADDRESS>wrote:

Because older GCC generate better code for old CPU (as 68k family). Newer GCC code generation is very convoluted and that really impacts final performance (i observed up to 40% slower code) and code size is bigger as well.

Oh, ok. This isn't really relevant to this ticket, but m68k is an
active port with more users than just Genesis - it would be helpful to
test new GCC releases and report such issues when they appear, if your
performance regression was still there in 5.2.0, for one.

Yeah of course but still m68k target is rarely used today and GCC compiler tend to optimize their code generation for newer CPU with very complex architecture resulting in very poor code for older CPU generations. From my (few) tests GCC 5 was even worst than 4.X here :-/
That is a shame as the GCC version i'm using (3.4.6) has some bugs (inline and register keyword does not work)... The best version for m68k is probably GCC 2.8.X as far i remember but too much outdated...

I tried to report that issue (bad code generation for m68k target) but honestly they just don't care.

I think I saw your bug, it went without attention for a couple years, but it's fixed in current GCC.
Also, sorry about the wavtoraw commits, I'll create a separate pull for those.

Do you mean that new GCC does now generate good code for m68k ? Honestly i could bet that is not the case...

If it was this bug, it's fixed, and the fix is present in 5.2:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52773
I can't say whether the codegen is good.

Not exactly the same : https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52897
I don't know how much 52773 is the same or not.
But you can test by yourself, you have here material and comparison of output :
https://gcc.gnu.org/bugzilla/attachment.cgi?id=27110&action=edit
So if you're using the last GCC version you can see how much code generation is improved (or not)

On Wed, 18 Nov 2015 07:08:23 -0800
Stephane Dallongeville<EMAIL_ADDRESS>wrote:

Not exactly the same : https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52897
I don't know how much 52773 is the same or not.
But you can test by yourself, you have here material and comparison of output :
https://gcc.gnu.org/bugzilla/attachment.cgi?id=27110&action=edit
So if you're using the last GCC version you can see how much code generation is improved (or not)

I could, except I don't speak enough ASM to tell what is better or not,
sadly.

Can you eventually send me the ASM output with your GCC on the bmp.c file provided ?
But just checking here, you can see the ASM listing of GCC 4.X is about 3 times longer than the GCC 3.X one, it's already a good indication there is definitely something wrong with the code generation with later compiler. And when it comes to old CPU as 68000, having a good compiler is important.

Here you go:
http://pastebin.ca/3259906
GCC 5.2 at -O3. Going by size alone, it's even better than GCC 3. I did hit a bug in building 5.2 for m68k:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68419

Thanks ! Unfortunately it looks like the optimization bug is not fixed even if some parts look better. If that is possible i would like to see the result with "-O2 -fno-gcse" switchs :)
You said you experienced a bug with GCC 5.2 compilation for m68k, how did you sorted it ?

On Wed, 18 Nov 2015 12:31:45 -0800
Stephane Dallongeville<EMAIL_ADDRESS>wrote:

Thanks ! Unfortunately it looks like the optimization bug is not fixed even if some parts look better. If that is possible i would like to see the result with "-O2 -fno-gcse" switchs :)
You said you experienced a bug with GCC 5.2 compilation for m68k, how did you sorted it ?

Sorry, I don't have the build anymore. I worked around the ICE by using
the first pass xgcc, which was built by my host compiler - the segfault
was when gcc tried to build itself again to test itself. For production
use, better wait until the bug is fixed.

Ok, well at least i merged the pull request :)
It would be nice if they could fix the simple memory to memory transfer optimization operation as this is a huge advantage the 68k offers.


Ignore one_member_abstracts rule

At dart standards is recommended not use abstract classes with just one method, but for some cases I think is more readable and scalable use abstract classes with just one member, like this:
abstract class DeckRepository {
  Future<List<Deck>> getAllDecks();
}

https://dart-lang.github.io/linter/lints/one_member_abstracts.html
This is a point that impact the ci because we are running flutter analyse that check the style rules of project.
So we can do two things:

Disable this rule at dart rules on analysis_options.yaml file like this:

include: package:strict/analysis_options.yaml

linter:
  rules:
    one_member_abstracts: false

Update all places that we use abstract classes with one member like this:

I agree with you, interestingly I've even recently written why I was going to make this lint decision shared to the core lint library, which is where we share all of these common (read personal) lint definitions for all of our projects. I will move this issue for the corresponding library and make the according changes to reflect on all of the libraries.


DBC22-2073 and DBC22-1664 (Advisories on map)

Two issues:

Eslint is reporting these unused variables. Please remove them.

We should probably update the advisories dynamically with the viewport filtering function. We can work on this together if you're unsure how to implement this.


Issue linking to static lib hdf5 with szip support

If i try to build netcdf with a static version of hdf5 that has szip support, I get errors at
CHECK_LIBRARY_EXISTS(${HDF5_C_LIBRARY} H5free_memory "" HDF5_HAS_H5FREE)
CHECK_LIBRARY_EXISTS(${HDF5_C_LIBRARY} H5Pset_libver_bounds "" HDF5_HAS_LIBVER_BOUNDS)
of CMakeLists.txt. Because szip symbols are not found at link time
Not far after that, there is the test of dependency of hdf5 to szip. Couldn't that test be put before the CHECK_LIBRARY_EXISTS, and in the IF(SZIP), adding something like CMAKE_REQUIRED_LIBRARIES += szip, so the tests that build hdf5 also link szip?
It might not be this trivial, as the SZIP tests too does a CHECK_LIBRARY_EXISTS, so this one might fail too.

Thanks for pointing this out; your suggestion is a good one, I'll see if it's that simple (feel free to try to beat me to the punch with a pull request!).  In the meantime, you can use the NC_EXTRA_DEPS option to specify additional libraries to link against; you should be able to pass it sz (or szip, I forget which) and have it link against szip.

To complement the issue, the same thing happens if HDF5 is built with zlib support, so the same kind of modification would need to be added for zlib

Ok, while this error still makes sense on paper and will still be addressed, it is worth noting that I cannot replicate this issue. The cmake system as it stands does not throw an error when building as described in the original report.   I'd like to figure out why; what version of cmake are you using?

Ok, I'm having problems replicating this, and we fall into a chicken-and-the-egg issue; szip should only be checked for if the hdf5 library requires it, and we can't check if the hdf5 library requires it, when using static libraries, without specifying it.  Given that I can't replicate this, I wonder how broad the scope of this issue is.   What is your OS and cmake version?
I'm able to get things to work by specifying -DCMAKE_EXTRA_DEPS="dl sz z m", combined with moving the check for libraries specified by NC_EXTRA_DEPS above checks for hdf5 and such.  This may be the best we can accomplish for now.

I am using cmake 3.2.3 on windows.
I am using custom built szip, hdf5, and am custom-building netcdf. All those three are built as static libraries, so they will be statically linked in the shared GDAL i build afterwards.
Indeed there is a issue with what to test first. SZIP should be tested only if hdf5 needs it, but hdf5 tests can not be built if we don't provide szip and it needs it. SZIP presence can still be tested without the need for HDF5. I would say that if USE_SZIP=ON (and USE_HDF5=ON), then it can be justified to test SZIP presence first without yet searching if we want to link to a HDF5 that needs it. Then if a SZIP is found, adding it to the link list during the duration of HDF5 tests should not hurt; it will just have no effect if HDF5 doesn't need it.
In my personal case, i only need netcdf static library, and this seemed only to generate issues to me when building the tests packaged in netcdf. I disabled their build and i am not disturbed anymore, i just provide needed include paths and libraries on cmake command line (+ a sed in CMakeLists because my szip livbrary is libszip and not sz)
Part of my build script :
  export SZIP_INSTALL=$ENV_SZIP_PATHM

  echo "set( HDF5_C_LIBRARY         \"$ENV_HDF5_PATHM/lib/libhdf5.lib\"    )" >  hdf5-config.cmake
  echo "set( HDF5_LIBRARY         \"$ENV_HDF5_PATHM/lib/libhdf5.lib\"    )" >> hdf5-config.cmake
  echo "set( HDF5_HL LIBRARY      \"$ENV_HDF5_PATHM/lib/libhdf5_hl.lib\" )" >> hdf5-config.cmake
  echo "set( HDF5_INCLUDE_DIR \"$ENV_HDF5_PATHM/include\"            )" >> hdf5-config.cmake
  echo "set( HDF5_VERSION     \"$ENV_HDF5_VERSION\"                  )" >> hdf5-config.cmake
  echo "set( HDF5_ROOT        \"$ENV_HDF5_PATHM\"                    )" >> hdf5-config.cmake

  #export INCLUDE="$ENV_CURL_PATHM/include;$INCLUDE"
  export LIB="$ENV_SZIP_PATHM/lib;$ENV_ZLIB_PATHM/lib;$ENV_CURL_PATHM/lib;$ENV_HDF5_PATHM/lib;$LIB"
  export PATH=$ENV_ZLIB_PATH/bin:$ENV_CURL_PATH/bin:$PATH
  sed -e "s/NAMES sz/NAMES libszip sz/" -i CMakeLists.txt

  cmake -G "NMake Makefiles" --verbose \
   -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF -DBUILD_TESTING=OFF -DBUILD_TESTSETS=OFF -DBUILD_UTILITIES=OFF \
   -DENABLE_TESTS=OFF -DENABLE_DAP_REMOTE_TESTS=OFF -DBUILD_TESTING=OFF -DBUILD_TESTING_STATIC=OFF -DBUILD_TESTING_SHARED=OFF \
   -DCMAKE_INSTALL_PREFIX=$instm \
   -DZLIB_LIBRARY=$ENV_ZLIB_PATHM/lib/zdll.lib -DZLIB_INCLUDE_DIR=$ENV_ZLIB_PATHM/include \
   -DCURL_LIBRARY=$ENV_CURL_PATHM/lib/libcurl_imp.lib -DCURL_INCLUDE_DIR=$ENV_CURL_PATHM/include \
   -DUSE_SZIP=ON \
   -DUSE_HDF5=ON -DHDF5_DIR=. \
   -DENABLE_DAP=ON \
   -DCMAKE_REQUIRED_LIBRARIES="libszip;zdll;libhdf5;libhdf5_hl;libcurl_imp" \
  . || exit 1
  nmake /U VERBOSE=1


Query result type

@joergwa @ThHanke
The query results of the colab notebook are the instances itself. Is it the plan to keep it on that level (which makes sense) or do we need to expand it to the data properties (could be more complex to align for different TLOs)?

Answer: Queries just for instances and not the data properties for now


[alembic] fix FindHDF5.cmake issue for cmake-3.9.0

cmake versioin 3.9 specific

@ousttrue,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Looks good, thanks for the improvement!


Logo

Hello designers,
If anybody cares about giving this project a nice logo, I would love to have one 😇 ❤

@Toflar I came across your repository and I thought I'd make some proposals for your logo.
I made three:

p1 evokes a magnifier with the letter L in it
p2 shows a magnifier on a line of text
p3 is more abstract ; it may evoke an eye or two overlapping shapes

Let me know if one of them works for you!

Hey, we've also been working on giving you some suggestions. Almost forgot to post them. 😅
If you like any of them, or have any customization requests, feel free to let us know. I can also provide you with the raw file if you'd like.
Thanks for your superduper open source work! 💚

Hey you lovely folks, thanks a lot for the submissions - love them! My personal fav is this one:

Other opinions? 😊

My favorite is the draft from @doishub too!
Just for the purpose of alternative proposals, a quick kind of 3Dish variant ...

Closed via https://github.com/loupe-php/loupe/pull/50.
Thanks everybody for the contributions ❤


Build failure

lerna ERR! yarn install --mutex network:42424 --non-interactive stderr:
warning Waiting for the other yarn instance to finish (170)
warning Waiting for the other yarn instance to finish (380)
warning Waiting for the other yarn instance to finish (389)
warning Waiting for the other yarn instance to finish (369)
warning Waiting for the other yarn instance to finish (416)
warning Waiting for the other yarn instance to finish (188)
warning Waiting for the other yarn instance to finish (299)
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "tslint-consistent-codestyle ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>error /root/project/packages/opentelemetry-plugin-grpc/node_modules/grpc: Command failed.
Exit code: 6
Command: node-pre-gyp install --fallback-to-build --library=static_library
Arguments:
Directory: /root/project/packages/opentelemetry-plugin-grpc/node_modules/grpc
Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using<EMAIL_ADDRESS>node-pre-gyp info using<EMAIL_ADDRESS>| linux | x64
node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp info check checked for "/root/project/packages/opentelemetry-plugin-grpc/node_modules/grpc/src/node/extension_binary/node-v64-linux-x64-glibc/grpc_node.node" (not found)
node-pre-gyp http GET https://node-precompiled-binaries.grpc.io/grpc/v1.23.3/node-v64-linux-x64-glibc.tar.gz
node-pre-gyp http 200 https://node-precompiled-binaries.grpc.io/grpc/v1.23.3/node-v64-linux-x64-glibc.tar.gz
node-pre-gyp info install unpacking node-v64-linux-x64-glibc/grpc_node.node
node-pre-gyp ERR! Completion callback never invoked!
node-pre-gyp ERR! System Linux 4.15.0-1043-aws
node-pre-gyp ERR! command "/usr/local/bin/node" "/root/project/packages/opentelemetry-plugin-grpc/node_modules/grpc/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build" "--library=static_library"
node-pre-gyp ERR! cwd /root/project/packages/opentelemetry-plugin-grpc/node_modules/grpc
node-pre-gyp ERR! node -v v10.16.3
node-pre-gyp ERR! node-pre-gyp -v v0.13.0
node-pre-gyp ERR! This is a bug in `node-pre-gyp`.
node-pre-gyp ERR! Try to update node-pre-gyp and file an issue if it does not help:
node-pre-gyp ERR!     <https://github.com/mapbox/node-pre-gyp/issues>

lerna ERR! yarn install --mutex network:42424 --non-interactive exited 6 in '@opentelemetry/plugin-grpc'
lerna WARN complete Waiting for 9 child processes to exit. CTRL-C to exit immediately.
error Command failed with exit code 6.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 6.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Exited with code 6

Probably because of https://github.com/mapbox/node-pre-gyp/issues/477
I fixed it locally by adding node-pre-gyp as a devdep to the grpc package.json

Closed via #322


Display author on proposal details

This depends on including the author on the payload from GET /proposals/:id.

Now sideloaded in the proposal payload as part of the included object:
{
  "data": {
     ...
  },
  "included": [
    %{
      "attributes": %{
        "name": "Author Name"
    },
    "id": "1",
    "type": "participant"
    }
  ]
}

Still WIP. It works, but code needs some touching up.
Data modelling currently looks like this:
type alias Model =
  { ...
  , proposals : Dict String Proposal
  , participants : Dict String Participant
  }

type alias Proposal =
  { id : String
  , author : String
  , attr: ProposalAttr
  }

type alias ProposalAttr =
  { title : String
  , body : String
  }

type alias Participant =
  { id : String
  , attr: ParticipantAttr
  }

type alias ParticipantAttr =
  { name : String
  }

Rebased on current master

Finished, ready for your review.
As discussed, we should start to refactor and modularize the code.
Should go into separate issues/PRs.

This is a little game I know, but - do you think https://github.com/noahzgordon/elm-jsonapi might help  in anyway with the json-api decoding in general?

Went ahead and merged to get going, we can always add elm-jsonapi later

Ah, one thing I forgot to comment - maybe it's unavoidable, but there's something weird about ProposalAttr and ParticipantAttr types. To me at least. Feels like we're describing the json-api format... I'd much rather have a
type alias Proposal =
  { id : String
  , author : String
  , title : String
  , body : String
  }

But that might be old rails habits talking...

I will definitely look into noahzgordon/elm-jsonapi.
As for the types Proposal/ ProposalAttr: This was an attempt to not repeat fieldsets.
I agree that this may not be the most beautiful solution here.
One simple alternative here would be:

Rename ProposalAttr to ProposalInput and use it only for form input result.
Define Proposal as a flat record, as you suggested.

The usage of noahzgordon/elm-jsonapi may also direct us to some specific type design here (not sure).


Ensure Spec should set correct content-type header

This fixes #184

Hi @0urobor0s! The README discusses the EnsureSpec Plug. Would you mind updating this to include mention of your change?

These changes look good. Please update the README per @jherdman's feedback and we can merge 😁

Many thanks, @0urobor0s !


end to end test for apps page in automate functionality

User Story
end to end test.
details tbd.
Definition of Done
E2E test running in CI somewhere to ensure we're always shipping quality stuff!

i can't find the pr(s) related to this issue.
could you please link them @danielsdeleo so we can reference later?

https://github.com/chef/automate/pull/2776
https://github.com/chef/automate/pull/2787
https://github.com/chef/automate/pull/2794


Reactive auto-configuration - Both health indicators VaultHealthIndicator and VaultReactiveHealthIndicator are registered in the application context

Describe the bug
Hi, I'm using Spring Cloud Vault with the Spring WebFlux stack:

Spring Boot 3.0.3
Spring Cloud Vault 4.0.0 - spring-cloud-vault-config 4.0.0

As it is a reactive stack, Vault’s reactive auto-configuration is enabled. What seems to be a bug is that there are now 2 Vault health indicators registered in the application context - the reactive one and non-reactive one. When /actuator/health endpoint is called both health indicators (VaultHealthIndicator and VaultReactiveHealthIndicator) are executed.
Or is it meant to be like that because you can have Spring Cloud Vault on Servlet Stack (Spring MVC) and be using Spring's WebClient from org.springframework:spring-webflux dependency?
Sample
I've created a sample test in which we can see the both indicators are registered:
public class VaultReactiveAutoConfigurationIssueDemonstrationSampleTests {

	private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
			.withConfiguration(AutoConfigurations.of(
					VaultReactiveAutoConfiguration.class,
					VaultAutoConfiguration.class,
					VaultHealthIndicatorAutoConfiguration.class));

	@Test
	void bothReactiveAndNonReactiveHealthIndicatorsAreConfigured() {
		this.contextRunner
				.withPropertyValues("spring.cloud.vault.token=foo")
				.run(context -> {
			assertThat(context).hasBean("vaultHealthIndicator");
			assertThat(context).hasBean("vaultReactiveHealthIndicator");
		});
	}
}

Or you can check it out directly here:
VaultReactiveAutoConfigurationIssueDemonstrationSampleTests
Suggestion
I've checked other Spring Boot auto-configurations and for example here is the auto-configuration for Redis:
RedisHealthContributorAutoConfiguration
RedisReactiveHealthContributorAutoConfiguration
We can see that in RedisHealthContributorAutoConfiguration
@Bean
@ConditionalOnMissingBean(name = { "redisHealthIndicator", "redisHealthContributor" })
public HealthContributor redisHealthContributor(Map<String, RedisConnectionFactory> redisConnectionFactories) {
	return createContributor(redisConnectionFactories);
}

they use the same @ConditionalOnMissingBean name as in RedisReactiveHealthContributorAutoConfiguration:
@Bean
@ConditionalOnMissingBean(name = { "redisHealthIndicator", "redisHealthContributor" })
public ReactiveHealthContributor redisHealthContributor() {
	return createContributor(this.redisConnectionFactories);
}

Which would prevent the creation of the non-reactive health indicator (we would need to change the @Import order here as well VaultHealthIndicatorAutoConfiguration)
What do you think? I would be happy to prepare and submit a pull request.

Imperative endpoints can be exposed via JMX. Endpoints are registered based on the presence of a VaultOperations bean respective the presence of the Flux type on the classpath. We do not differentiate between the availability of WebMVC vs. WebFlux.
This setup is common in Spring Boot itself.

Thanks for the comment.
Yes, so just to confirm, is it OK that both VaultHealthIndicator and VaultReactiveHealthIndicator are registered and contribute to health even though they do basically the same check?
{
  "vault": {
    "status": "UP",
    "details": {
      "version": "1.12.3"
    }
  },
  "vaultReactive": {
    "status": "UP",
    "details": {
      "state": "Vault in standby",
      "version": "1.12.3"
    }
  }
}

As opposed to the example I've provided where in e.g. Redis they configure only one health contributor (redisHealthIndicator) and the reactive one has precedence.

As opposed to the example I've provided where in e.g. Redis they configure only one health contributor (redisHealthIndicator) and the reactive one has precedence.

Thanks for pointing this out. You're right, I totally missed that one indicator's configuration backs off in case of such an relationship between the beans. Feel free to submit a pull request to align the conditions, precedence, and bean names. We should also keep the vaultReactiveHealthIndicator bean name as an alias to avoid breaking references that use the bean by name.

No problem, I've just submitted the pull request and it's ready for review 👍


Seeking Help to Resolve "endpoints_resolution_error" in<EMAIL_ADDRESS>

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
1.18.0
Wrapper Library
Not Applicable
Wrapper Library Version
1.18.0
Public or Confidential Client?
Confidential
Description
Hello forum!
I have been struggling with an error for several days while attempting to resolve authentication endpoints in the<EMAIL_ADDRESS>version. The specific error I'm encountering is "endpoints_resolution_error". I have meticulously checked the details of my application registered in Azure AD, including the client secret, Directory Identifier provided by the app, and the permissions granted to the API.
Despite my efforts, I haven't been able to resolve this issue, and I feel stuck. The code of ms-identity-javascript-nodejs-console works and has been what I have used to constrcut my code .
I am reaching out to this community for help and guidance.  I would greatly appreciate any advice or solutions you can offer.
Best regards,
lplazav
MSAL Configuration
async getToken() {

        console.log('Get Token from Microsoft...');
        console.log('- clientId: ' + this.CLIENT_ID);
        console.log('- authority: ' + this.AAD_ENDPOINT + this.TENANT_ID);
        console.log('- clientSecret : ' + this.CLIENT_SECRET);

        const tokenRequest = {
            scopes: [this.GRAPH_ENDPOINT + '.default'],
        };

        const msalConfig = {
            auth: {
                clientId: this.CLIENT_ID,
                authority: this.AAD_ENDPOINT + this.TENANT_ID,
                clientSecret: this.CLIENT_SECRET,
                knownAuthorities: [`${this.AAD_ENDPOINT}${this.TENANT_ID}`],
            },

            cache: {
                cacheLocation: "sessionStorage",
                storeAuthStateInCookie: false,
                secureCookies: false
            },
            system: {
                loggerOptions: {
                    logLevel: msal.LogLevel.Verbose,
                    loggerCallback: (level, message, containsPii) => {
                        if (containsPii) {
                            return;
                        }
                        switch (level) {
                            case msal.LogLevel.Error:
                                console.error(message);
                                return;
                            case msal.LogLevel.Info:
                                console.info(message);
                                return;
                            case msal.LogLevel.Verbose:
                                console.debug(message);
                                return;
                            case msal.LogLevel.Warning:
                                console.warn(message);
                                return;
                        }
                    },
                    piiLoggingEnabled: true
                },
            },
        };
        console.log(JSON.stringify(msalConfig, null, 2))
        const cca = new msal.ConfidentialClientApplication(msalConfig);
        console.log(JSON.stringify(cca, null, 2))
        return await cca.acquireTokenByClientCredential(tokenRequest).catch((err) => {
            throw err;
        });
    }

Relevant Code Snippets
INFO    11:15:14.662  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT]<EMAIL_ADDRESS>: Info - acquireTokenByClientCredential called
DEBUG   11:15:14.662  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT]<EMAIL_ADDRESS>: Verbose - initializeRequestScopes called
DEBUG   11:15:14.664  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT] : [ae7ddda2-14cf-46a7-8150-84a5b8e19a9c]<EMAIL_ADDRESS>: Verbose - buildOauthClientConfiguration called
DEBUG   11:15:14.664  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT] : [ae7ddda2-14cf-46a7-8150-84a5b8e19a9c]<EMAIL_ADDRESS>: Verbose - building oauth client configuration with the authority: https://login.microsoftonline.com/d1b91829-fc9d-4c6f-88f1-cdc17208686e
DEBUG   11:15:14.664  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT] : [ae7ddda2-14cf-46a7-8150-84a5b8e19a9c]<EMAIL_ADDRESS>: Verbose - createAuthority called
DEBUG   11:15:14.666  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT]<EMAIL_ADDRESS>: Verbose - Attempting to get cloud discovery metadata in the config
DEBUG   11:15:14.667  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT]<EMAIL_ADDRESS>: Verbose - The host is included in knownAuthorities. Creating new cloud discovery metadata from the host.
DEBUG   11:15:14.667  811692cc33fec7bd  [Sat, 15 Jul 2023 11:15:14 GMT]<EMAIL_ADDRESS>: Verbose - Found cloud discovery metadata in the config.
INFO    11:15:19.718  811692cc33fec7bd  {
  "errorCode": "endpoints_resolution_error",
  "errorMessage": "Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://login.microsoftonline.com/d1b91829-fc9d-4c6f-88f1-cdc17208686e/v2.0/.well-known/openid-configuration",
  "subError": "",
  "name": "ClientAuthError",
  "correlationId": "ae7ddda2-14cf-46a7-8150-84a5b8e19a9c"
}

Identity Provider
Azure AD / MSA
Source
External (Customer)

Hi @lplazav - the error indicates that MSAL JS is having trouble accessing the Internet. The library is trying to access:
https://login.microsoftonline.com/d1b91829-fc9d-4c6f-88f1-cdc17208686e/v2.0/.well-known/openid-configuration
to read token_endpoint value from there. Unfortunately the logs do not give more details about the actual failure.
This type of problem happens a lot in environments with proxies. Is this your case?
Let's try the following:

change the network stack to use Axios. You do it like this and the Axios HTTPClient is here

Can you try to use the Axios HttpClient and see if all the calls work as you expect?

I don't have any suggestions other than what you said @bgavrilMS. The logs aren't clear. @lplazav, did you try Bogdan's suggestion and use the Axios HttpClient and see if the network calls work as expected? You can also implement your own network module.

Can we get more data into those logs @Robbie-Microsoft ?


Question: Dynamic "open CurrentModule" preludes for .mli files?

I'm trying to set up a minimal-boilerplate example of a project with mdx-tested .mli files. I'm still learning dune and mdx, but I've gotten pretty close to my goal using one prelude file.
Currently, my utils.mli looks like this, and mdx is happy with it:
(** The Utils module define helper functions commonly used throughout the
    project. *)

val greet : string -> string
(** Returns a greeting message.

    {[
      # Utils.greet "Tom"
      - : string = "Hello Tom!"
    ]}
*)

While this looks just as clean as the Ruby documentation I'm used to (where examples always include the module name), I'd like to be able to just have this (without the module name), which is more consistent with the OCaml documentation I've seen:
# greet "Tom"
- : string = "Hello Tom!"

My current ./lib directory looks like this:
lib/dune
lib/prelude.txt
lib/config.ml
lib/config.mli
lib/utils.ml
lib/utils.mli

; ./lib/dune

(library
 (name romanum)
 (public_name romanum)
 (inline_tests)
 (preprocess
  (pps ppx_inline_test)))

(mdx
 (files *.mli)
 (preludes prelude.txt))

(include_subdirs unqualified)

(* ./lib/prelude.txt *)

#require "romanum";;

open Romanum

I know I can just add open Utils to my existing prelude file, but it wouldn't be practical to open every module in one prelude file, and I'd prefer not to create a separate subdirectory, dune file, and prelude file for every .mli just to achieve conventional-looking documentation.
Is this something I could achieve just using dune stanzas?
I would be nice if there was a way to set the test command flags used by the mdx stanza using variable substitution, but I realize that would require changes to dune itself.
I can't find any way to tell dune, "for each file in *.mli, run the following commands". I know I can write a script which does the looping for me, and invoke it using a run stanza or similar, but from the documentation it sounds like I would lose out on the promote and --auto-promote features if I'm not explicitly using a diff or diff? stanza. 🤔

One hacky way to do this is to add something like this at the top of your mli:
(**/**)
(** {[
         open MyModule
      ]}
*)
(**/**)

The stop comments mean it won't show up in documentation, but will still be run by mdx.


Improved wide glyph support for UIA

Summary of the Pull Request

Added better wide glyph support for UIA. We used to move one cell at a time, so wide glyphs would be read twice.
Converted a few things to use til::point since I'm already here.
fixed telemetry for UIA

PR Checklist

[x] Closes #1354

Detailed Description of the Pull Request / Additional comments
The text buffer has a concept of word boundaries, so it makes sense to have a concept of glyph boundaries too.
_start and _end in UiaTextRange are now til::point
Validation Steps Performed
Verified using Narrator

@miniksa Found a bug where the following won't work:
COORD inclusiveEnd{ _end };

where _end is a til::point.
After discussing with @DHowett-MSFT, the best and only fix for this is to replace these instances with this:
COORD inclusiveEnd = _end;

What was happening in the first notation is the implicit conversion of til::point to bool to SHORT. The constructor for COORD only sees one SHORT so it thinks the value should be the definition for X, and Y should stay as 0. So we end up getting 1, 0.
@DHowett-MSFT suggested we make the bool operator on these new til types explicit. That'll come in in a new PR in a few minutes. More details then.

@miniksa Michael Niksa FTE Found a bug where the following won't work:
COORD inclusiveEnd{ _end };

where _end is a til::point.
After discussing with @DHowett-MSFT Dustin Howett FTE, the best and only fix for this is to replace these instances with this:
COORD inclusiveEnd = _end;

What was happening in the first notation is the implicit conversion of til::point to bool to SHORT. The constructor for COORD only sees one SHORT so it thinks the value should be the definition for X, and Y should stay as 0. So we end up getting 1, 0.
@DHowett-MSFT Dustin Howett FTE suggested we make the bool operator on these new til types explicit. That'll come in in a new PR in a few minutes. More details then.

Glad you asked Dustin. I forgot about explicit.

I'm averse to making these changes during a bug fix.

Unless switching to til::point actually helped fix the bug, right?

Unless switching to til::point actually helped fix the bug, right?

:( not really. Can I at least have the new functions in TextBuffer return til::point instead of COORD?

Yes, they can take and return til::point. The implicit conversions will make that easy and fun.

@msftbot merge this in 7 minutes

Is this the feature that makes that this text "<=" seems like this "≤"? 'Cause it would be very useful to deactivate the feature. I use nano in the Windows Terminal instead of using a normal text editor just to see the original characters in the files and this makes that a little hard. So maybe this could be configurable.

No, that would be the font ligatures that are in the font we chose by default. You can disable them by setting your font to Consolas. We have resolved this for the next version.


Added type annotations to some combiners missing it.

These just correspond to the typing annotations of functions called in extend, so this shouldn't change the type check behavior.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

note there's one little formatting error: https://ci-beam.apache.org/job/beam_PreCommit_PythonFormatter_Commit/7939/console

Can you fix the yapf errors?
19:46:42 py3-yapf-check run-test: commands[1] | time yapf --diff --parallel --recursive apache_beam
19:47:09 --- apache_beam/transforms/combiners.py	(original)
19:47:09 +++ apache_beam/transforms/combiners.py	(reformatted)
19:47:09 @@ -700,6 +700,7 @@
19:47:09          a in zip(self._combiners, accumulator)
19:47:09      ]
19:47:09
19:47:09 +
19:47:09  @with_input_types(T)

Can you fix the yapf errors?
19:46:42 py3-yapf-check run-test: commands[1] | time yapf --diff --parallel --recursive apache_beam
19:47:09 --- apache_beam/transforms/combiners.py	(original)
19:47:09 +++ apache_beam/transforms/combiners.py	(reformatted)
19:47:09 @@ -700,6 +700,7 @@
19:47:09          a in zip(self._combiners, accumulator)
19:47:09      ]
19:47:09
19:47:09 +
19:47:09  @with_input_types(T)

Done.


3.2.6- Help Contact Info-  Student- Accessibility Fixes - Level A -Consistent Help

User Story
**As a student, I need contact information is listed on pages, in the same location so that I know where to find contact information and who to contact if I have an issue.
Context:

These issues were uncovered through accessibility audit via CITZ.
Detailed Spreadsheet for Student s inserted inline and also attached here: 2024_Student Application_Audit.xlsx
If a web page contains specific help mechanisms, and those mechanisms are repeated on multiple web pages within a set of web pages, they occur in the same order relative to other page content, unless aa change is initiated by the user.

The Problem
No contact information available despite validation warning stating "please contact us". Instead, users are asked to "refer to" various resources without context on who or what is available to contact.
Student Pages
Adjust the following Accessibility Criteria for the following  pages

[ ] Start new application
[ ] My applications
[ ] Confirm other appropriate pages

Acceptance Criteria

[ ] Ensure contact information is listed on pages, in the same location, where appropriate.

Confirm solution with Rowan.


at calendar week view get endAt  value

Hi,
Thanks for this wonderful api it works easily and very fine.
Will you please help me out with how will i get endAt event variable value in week view, as of now it shows all 7 days of  week with start and end time and segmented in to minutes.
As per your day view template i want show same in week view, where user can see the Event Start and Event End time plotted area in their colour which i provided in event array.
"calendarConfig.showTimesOnWeekView = true; //Make the week view more like the day view, with the caveat that event end times are ignored."
With reference to this code i did it keeping my value TRUE but on the contrary i want event end time not to be ignore. So please help me resolve this issue, Thanks in advance.

Event end times are ignored because handling overlapping events in the week view columns becomes very difficult, it works for some people that don't use event end dates, but I have no plans to support it.


Integration with data registry (add Country and Date range)

When the user arrives at the flatten tool via the data registry i.e. not via the file upload route, the data registry needs to pass through information to the flatten tool about:

the country name for the dataset e.g. United Kingdom Contracts Finder
the data date range (MM-YYYY)

for the flatten tool to convert the data from JSON to tabular data

@sorenabell The call notes mention "Need to know where fields are received". Can the fields above be passed as additional parameters in the existing API call?

Yes, but this will require some minor updates on our side.

@sabahfromlondon I checked the flow with the following link https://flatten.open-contracting.org//#/upload-file?lang=en_US|es&url=259078f6-c06b-4a2e-8966-e19189e1fb86, it still works correctly. But it is just an example. Maybe someone from Datlab could share the links they are currently using, so we could understand the differences.

@sorenabell I remember us discussing this screen a while ago with you and @olehchepak where I mentioned that when the user arrives from the data registry the upload data screen is not the right one (I can't find the issue now). The original wireframe looks like this:

Are you sure there is not another screen?

It was issue #229.
@sabahfromlondon Let us know what we should do with the titles of the steps since currently we have 5 of them and Select data includes other content, different from this wireframe.

The same design contains "Back to data details" link, but we don't have any Data Registry link at the moment that we could refer users to.

@sorenabell thanks for sharing the screen, looks really nice. I need to discuss a couple of things with James first in our meeting this afternoon, so will come back to you after that

This helps immensely, thank you.

@sabahfromlondon Please test the updated flow: https://www.loom.com/share/95eae847300746149b98009d81436be2.
You can do that by inserting file:///data/storage/exporter_dumps/australia/54/2009.jsonl.gz into the Upload URL field. (The test text in Spanish needs to be translated https://www.transifex.com/open-contracting-partnership-1/spoonbill/translate/#es/web-app-ui/330722124?q=text%3A'Data+you+selected+needs+to+be+converted+into+an', I added test to test whether translation is working properly.)
Currently, it is just a minor fix to show you the UI, the way to determine whether user came from Data registry is discussed here #347

@sorenabell are you sure the video is the correct one?

Yes. As you can see in the video, we have just 4 steps.
You can test the flow that user will see moving from Data Registry to spoonbill by inserting file:///data/storage/exporter_dumps/australia/54/2009.jsonl.gz into the Upload URL field on production.

Ok I can see the 4 steps, but why is the journey from the upload step?

It is just roundabout to test the UI before #347 (the way to determine where the user came from) is ready.

Ok I see. Was very confusing at first, but the 4 steps looks good.

Seems like this is done, so closing.