Unable to use the Writer from a different thread.

I craeate a tokio pipe. in the thread where the pipe is created, I am reading  from the read end till end of file.  In another thread where I pass the writeer as a raw fd, I try to create a new PipeWrite (PipeWrite::from_raw_rd_checked(fd)).  However that call fails because the creation of AsyncFd() seems to be failing since the file descriptor is already registerered?
Is there a way to safely separate the writing and reading across two different threads?

Note that I can't pass the created PipeWriter directly to the other thread (the only shared state is the file descriptor number)

You need to either call <PipeWrite as IntoRawFd>::into_raw_fd, which will deregister the fd from tokio, or you need to dup the fd before recreating the PipeWrite.

Thanks.  The only issue i see is into_raw_fd() does mem::forget().  Is there a way to close the fd after i read everything from the pipe?  Just as a safety to avoid leaking since the methods in PipeFd are not public

Thanks. The only issue i see is into_raw_fd() does mem::forget().

It forget the PipeFd, which closes the fd on drop.

Is there a way to close the fd after i read everything from the pipe?

If you created a PipeRead, then it will contains a PipeFd.

Just as a safety to avoid leaking since the methods in PipeFd are not public

If you are worried about leaking the fd when passing to a different thread, you can use std::os::unix::io::OwnedFd.

@duggaraju
(Sorry for the late response...)
In my environment, it seems to be possible to write across threads with PipeWrite::from_raw_rd_checked.
Here is the code I wrote to try it out.
https://github.com/yskszk63/tokio-pipe/blob/add-example/examples/inter-thread.rs
If there are any misunderstandings, I would appreciate it if you could point them out.


Add support for the list failed organization invitations feature

Resolves #1812

Thank you, @wesleimp !
Merging.


Interactions URL

Based on the error I was getting and another issue in a different repo, if the /interactions is required for the URL in the Ngrok section it should be added to the description and screenshot.
GH Issue w/ Docs Reference: https://github.com/BookStackApp/BookStack/issues/2558#issuecomment-1159711852
Ngrok Section: https://discord.com/developers/docs/tutorials/hosting-on-cloudflare-workers#setting-up-ngrok

Error Message (I tried /interactions)

What the tunnel looks like:

@JacobMGEvans
Hi, I figured it out. We have to check discord's request using verifyKey.
Here's my sample code.
import { InteractionResponseType, verifyKey } from 'discord-interactions';

export interface Env {
  DISCORD_PUBLIC_KEY: string;
}

export default {
  async fetch(
    request: Request,
    env: Env,
    ctx: ExecutionContext
  ): Promise<Response> {
    const rawBody = await request.text();
    const signature = request.headers.get('X-Signature-Ed25519');
    const timestamp = request.headers.get('X-Signature-Timestamp');
    const pubKey = env.DISCORD_PUBLIC_KEY;

    if (signature == null || timestamp == null) {
      return new Response('Sorry, you have supplied an invalid key.', {
        status: 403,
      });
    }

    const isValidRequest = verifyKey(rawBody, signature, timestamp, pubKey);

    if (!isValidRequest) {
      return new Response('Bad request signature', {
        status: 401,
      });
    }

    return new Response(JSON.stringify({
      type: InteractionResponseType.PONG,
    }), {
      headers: {
        'content-type': 'application/json;charset=UTF-8',
      },
    });
  },
};

@JacobMGEvans You may forget DISCORD_PUBLIC_KEY using wrangler CLI?

I had not 😅

@JacobMGEvans

What the tunnel looks like:

Could you change interactions endpoint url https://<NGROK_URL>.ngrok.io/interactions? You should receive 200 request and 401 requests like below.

Error Message (I tried /interactions)
IMAGE
What the tunnel looks like: IMAGE

@nzwsch

Greetings!  The cloudflare specific tutorial posts messages directly to /, which the getting started tutorial you're looking at does in fact post them to /interactions.  They're different code bases, and really you can set up your backend to accept messages on any route.  I just double checked everything in this repo and it's 👍


quasar_components/stock_test.py

QBtn will stay in loading state if the "tIcker" input is not existend in yahoo, as an example when the input is "apple" instead of "AAPL"

examples/quasar_tutorial/quasar_components/stock_test.py

Example has missing error handling for the cases were the data retrieval fails


SQL lab keeps show "rendering", no result appears

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version
0.29.0rc7
Expected results
keep showing "rendering"
Actual results
In the query history tab, it shows 74 rows.
Steps to reproduce

Build image from custom Dockerfile. https://github.com/shizidushu/superset/blob/report-issue/Dockerfile (modified from https://github.com/amancevice/superset)
Create a network for superset. docker network create -d overlay --attachable superset-overlay
Pull the image and deploy it with docker stack deploy -c docker-compose.yml superset

docker-compose.yml

version: '3.7'
services:
  redis:
    image: redis
    ports:
      - "6379"
    networks:
      - superset-overlay
  postgres:
    image: postgres:10
    environment:
      - POSTGRES_USER=superset
      - POSTGRES_PASSWORD=superset
      - POSTGRES_DB=superset
      - PGDATA=/var/lib/postgresql/data/pgdata
    networks:
      - superset-overlay
    volumes:
      - ../persistent-data/superset/postgres:/var/lib/postgresql/data
  superset:
    image: shizidushu/superset:0.29.0rc7
    depends_on:
      - postgres
      - redis
    ports:
      - target: 8088
        published: 8088
        mode: host
    healthcheck:
      test: ["CMD", "curl", "-f", "http://localhost:8088/health"]
      interval: 30s
      timeout: 15000s
      retries: 1
      start_period: 10s
    networks:
      - superset-overlay
    volumes:
      - ./config/superset_config.py:/etc/superset/superset_config.py
  worker:
    image: shizidushu/superset:0.29.0rc7
    depends_on:
      - postgres
      - redis
    volumes:
      - ./config/superset_config.py:/etc/superset/superset_config.py
    networks:
      - superset-overlay
    command: celery worker --app=superset.sql_lab:celery_app --pool=gevent -Ofair

networks:
  superset-overlay:
    driver: overlay
    external: true

superset_config.py

import os

from werkzeug.contrib.cache import RedisCache

# MAPBOX_API_KEY = os.getenv('MAPBOX_API_KEY', '')

CACHE_CONFIG = {
    'CACHE_TYPE': 'redis',
    'CACHE_DEFAULT_TIMEOUT': 300,
    'CACHE_KEY_PREFIX': 'superset_',
    'CACHE_REDIS_HOST': 'redis',
    'CACHE_REDIS_PORT': 6379,
    'CACHE_REDIS_DB': 1,
    'CACHE_REDIS_URL': 'redis://redis:6379/1'}
SQLALCHEMY_DATABASE_URI = \
    'postgresql+psycopg2://superset:superset@postgres:5432/superset'
SQLALCHEMY_TRACK_MODIFICATIONS = True
SECRET_KEY = 'thisISaSECRET_1234'

class CeleryConfig(object):
    BROKER_URL = 'redis://redis:6379/0'
    CELERY_IMPORTS = ('superset.sql_lab', )
    CELERY_RESULT_BACKEND = 'redis://redis:6379/0'
    CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}

CELERY_CONFIG = CeleryConfig
RESULTS_BACKEND = RedisCache(
    host='redis',
    port=6379,
    key_prefix='superset_results'
)

run superset-init in container (docker exec -it d7a1f711b205 superset-init).
go the the web browser and run a query SELECT * FROM ab_permission

Logs

docker logs 0eb22be57abb (superset_superset container)

[2018-12-13 10:36:21 +0000] [1] [INFO] Starting gunicorn 19.8.0
[2018-12-13 10:36:21 +0000] [1] [INFO] Listening at: http://<IP_ADDRESS>:8088 (1)
[2018-12-13 10:36:21 +0000] [1] [INFO] Using worker: sync
[2018-12-13 10:36:21 +0000] [8] [INFO] Booting worker with pid: 8
[2018-12-13 10:36:21 +0000] [9] [INFO] Booting worker with pid: 9
2018-12-13 10:36:38,368:INFO:root:Database.get_sqla_engine(). Masked URL: postgresql+psycopg2://superset:XXXXXXXXXX@postgres:5432/superset
2018-12-13 10:37:07,201:INFO:root:Database.get_sqla_engine(). Masked URL: postgresql+psycopg2://superset:XXXXXXXXXX@postgres:5432/superset
2018-12-13 10:37:11,906:DEBUG:root:[stats_logger] (incr) sql_json
2018-12-13 10:37:11,910:INFO:root:Parsing with sqlparse statement SELECT * FROM ab_permission
2018-12-13 10:37:11,951:INFO:root:Parsing with sqlparse statement SELECT * FROM ab_permission
2018-12-13 10:37:11,964:INFO:root:Triggering query_id: 1
2018-12-13 10:37:11,995:INFO:root:Parsing with sqlparse statement SELECT * FROM ab_permission
2018-12-13 10:37:11,996:INFO:root:Parsing with sqlparse statement SELECT * FROM ab_permission
2018-12-13 10:37:12,003:INFO:root:Set query to 'running'
2018-12-13 10:37:12,009:INFO:root:Database.get_sqla_engine(). Masked URL: postgresql+psycopg2://superset:XXXXXXXXXX@postgres:5432/superset
2018-12-13 10:37:12,019:INFO:root:Running query:
SELECT * FROM ab_permission LIMIT 1000
2018-12-13 10:37:12,019:INFO:root:SELECT * FROM ab_permission LIMIT 1000
2018-12-13 10:37:12,020:INFO:root:Handling cursor
2018-12-13 10:37:12,023:INFO:root:Fetching data: {'changedOn': datetime.datetime(2018, 12, 13, 10, 37, 11, 998982), 'changed_on': '2018-12-13T10:37:11.998982', 'dbId': 1, 'db': 'main', 'endDttm': None, 'errorMessage': None, 'executedSql': 'SELECT * FROM ab_permission LIMIT 1000', 'id': 'Jown1TcLh', 'limit': 1000, 'progress': 0, 'rows': None, 'schema': 'null', 'ctas': False, 'serverId': 1, 'sql': 'SELECT * FROM ab_permission', 'sqlEditorId': 'teid-4ase', 'startDttm': Decimal('1544697431952.956000'), 'state': 'running', 'tab': 'Untitled Query', 'tempTable': '', 'userId': 1, 'user': 'admin user', 'limit_reached': False, 'resultsKey': None, 'trackingUrl': None}
2018-12-13 10:37:12,023:DEBUG:root:[stats_logger] (timing) sqllab.query.time_executing_query | 3.3427734375
2018-12-13 10:37:12,023:DEBUG:root:[stats_logger] (timing) sqllab.query.time_fetching_results | 0.1298828125
2018-12-13 10:37:12,023:INFO:root:Fetching cursor description

docker logs of superset_worker is empty

Edit:
Just try to run the query from another pc's browser and it works. I'm not sure it's an issue or not now.

Possibly related, I started seeing
 with latest master

v0.30 also has this issue. likewise, console doesn't show any errors

Any red in the network tab? Wild guess is around not running superset init which may grant endpoint access to some roles. superset init should be executed once per deploy.

Is this consistent for some users? Users with the same role perhaps?

Is this consistent for some users? Users with the same role perhaps?

@mistercrunch
sqllab bug:

Firefox

chorme  show error

Is this happening only on a async-configured db or both.
Haven't done any digging yet, but it may be one of these elusive PureComponent-related bug where an object is that should be treated as immutable is mutated in redux, and the re-render isn't triggered since it's a PureComponent. Just a guess. But one way to rule this out is to batch-replace s/PureComponent/Component/g in assets/src/SqlLab and see if it's still happening.

I've encountered same issues at 0.29.0rc7 as well.
My browser is Chrome and the user role is admin, so this should be a bug.
Would this be fixed in later version ?
(I install Superset from pypi so 0.29.0rc7 is the latest I could get.)

I have the same issue with 0.20.0rc7. The only way I can make the app work again is by doing the following:

Log out from the app
Clear the site data

We had a list of bug fixes for sql lab fetching results issues: #7628, #7523 and #7575.
can you try release--0.33 ?

Though this is not a true solution, I found how to show result after keeping show 'rendering'.
Idk you also have same effects but try once below:

Create a 'saved query' you want to execute and show results (In 'SQL Editor', fill your query and "Save Query")
Open "Saved Queries" page and open "Pop Tab Link" of the query
Just execute the opened saved query and then keeping show 'rendering'
Open "Saved Queries" page and open "Pop Tab Link" of the query AGAIN
Just execute the newer opened saved query and then keeping show 'rendering'
Click the tab of the query you executed first
SOMEHOW the result of first executed query was shown...


ExchangeOrderResult means different things at different exchanges. Can we standardize this?

Comparing Bittrex and Binance:
Bittrex[Price] means the total amount in the base currency.
Binance[Price] means price per unit (I think)
It's not clear what units the different numbers are supposed to be in. Probably different exchanges return different things. Can we get ExchangeSharp to normalize this stuff?
My suggestion:
Amount/AmountFilled are always in the market currency (e,g. ADA)
AveragePrice is price per unit in base/market. E.g. 0.000342 ETH/ADA
Fee is in the base currency
Price means... the price requested? I have no idea what this is for.
My testing:

Yes this would be good to normalize. I've added similar normalization to
the candles and tickers end points. Some exchanges list the base pair
first, others second.
In my mind, price should be the limit price (most common case). For market
orders it does not apply and can probably be set to the average price. Not
all exchanges provide an average price, so for those exchanges, average
price can be set to price.
The rest of your suggestions look good. Let me know if you need guidance
implementing them.
Jeff Johnson
CEO / CTO, Digital Ruby, LLC
On Tue, Mar 27, 2018 at 10:20 PM, bichuga<EMAIL_ADDRESS>wrote:

Comparing Bittrex and Binance:
Bittrex[Price] means the total amount in the base currency.
Binance[Price] means price per unit (I think)
It's not clear what units the different numbers are supposed to be in.
Probably different exchanges return different things. Can we get
ExchangeSharp to normalize this stuff?
My suggestion:
Amount/AmountFilled are always in the market currency (e,g. ADA)
AveragePrice is price per unit in base/market. E.g. 0.000342 ETH/ADA
Fee is in the base currency
Price means... the price requested? I have no idea what this is for.
My testing:
[image: image]
https://user-images.githubusercontent.com/9372553/38008342-018a5cf8-3203-11e8-9582-5ee635d0136c.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jjxtra/ExchangeSharp/issues/78, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNoGPs8Gn84z_a_ar8gjzV5op5U4Ubgks5tiw9ygaJpZM4S9_rz
.

Pull request looked good, thanks for doing this!

We can do additional pull requests for other exchanges as needed. Binance appears to be the most picky so at least it is taken care of.


Inconsistent behavior when issuing multiple credentials in sequential. Some of the requests/issuances are failing with error "400 Revocation registry metadata not found".

Inconsistent behavior when issuing multiple credentials in sequential. Some of the issuances are failing with error "400 Revocation registry metadata not found".
Agent version: 0.7.2
Wallet-type: askar
Agent API invoking from Controller: /issue-credential/records/{credential_exchange_id}/issue
Note that issue is not consistent and happening only when we use wallet type as askar (when we tested with indy as wallet type then no errors). Let’s say when we issue 10 credentials, sometimes all 10 are getting succeeded and sometimes few requests are failing with above error. The error rate is proportional when we go for bulk runs. Recently, we have upgraded agent to 0.7.2 version and wanted to understand if we are missing anything.
Below are the command line parameters (values are masked for security reasons).
[ "/bin/bash", "-c", " aca-py start -it http <IP_ADDRESS> 10000 -ot http --admin <IP_ADDRESS> 5000 -e http://abcagent:10000 --wallet-type askar --auto-provision --log-level debug --seed <some 32 chars> --genesis-url http://test.bcovrin.vonx.io/genesis --label 'Example label' --admin-insecure-mode --auto-respond-messages --wallet-storage-type postgres_storage --wallet-storage-config '{"url":"abcpostgresserver:5432","wallet_scheme":"DatabasePerWallet"}' --wallet-storage-creds '{"account":"abcuser","password":"abcpassword","admin_account":"abcuser","admin_password":"abcpassword"}' --wallet-name wallet-askar --wallet-key dicept_key --tails-server-base-url http://abctailserver:6543" ]
Let me know if I can provide more info. Any pointers are highly appreciated. Thank you

@andrewwhitehead -- can you please take a look at this one?  Thanks,

I can't see why this error would be raised rather than the Revocation registry definition not found or Revocation registry not found prior to it. Are there any database errors being logged? In any case it might well be impacted by the recent fixes in #1591.

I believe this is resolved with aries-askar 0.2.5.

I can confirm this. I run some tests with AcaPy 0.7.4rc0 and Askar 0.2.5 using the Aries Load Generator. Based on those the issue has been solved.


Use default(variable = "AutoFlag::Auto")

Simple follow up task suggested here https://github.com/thin-edge/thin-edge.io/pull/2398#discussion_r1380463768
Proposed changes

Use default(variable = "AutoFlag::Auto") for c8y.bridge.include.local_cleansession
Remove impl From<&str> for AutoFlag as no more required.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

The test failure looks unrelated, hence approving.

I re-ran the system tests and also logged the flaky test https://github.com/thin-edge/thin-edge.io/issues/2416


Further improve CompositeSimulator

I think the CompositeSimulator has an excellent design. To further improve user-friendliness I suggest the following two changes:
(1) Rename to SequentialSimulator. I think this is a more descriptive name.
(2) Merge CompositeSimulator and CompositeLambdaSimulator into one function (SequentialSimulator), which takes a list(?) of objects, each of which is coercible to a Simulator object. First, we go over the list of objects, transform each of them to a Simulator (if it is not already one), and then execute the code currently implemented in CompositeSimulator. This way, users have a single interface for building sequential simulators, and can use any object which we deem valid to serve as a simulator.

To accommodate this, we will add a dispatch utility for simulators.


Custom template for capture

I would love to be able to customize the text that goes into Logseq when a quick capture happens so that it better suits the way I use Logseq.
To expand on this, I would like to be able to have different templates depending on the website I'm on. Examples:

When I quick-capture a Youtube page I would like to add a #[[Watch]] reference.
When I quick-capture an Amazon page I would like to add a #[[Shopping]] reference.

This is controlled by Logseq actually; templates for quick capture are set up in Logseq.


Contribute Git Step

Please include answers to these questions as part of your pull request
In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).

[X] Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
[ ] No

Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.

[X] My contribution does NOT include PII data
[ ] My contribution includes PII data

Q3: Confirm your contribution does not include any encryption or other export-controlled technology.

[X] My contribution does NOT contain encryption or other export-controlled technology
[ ] My contribution includes encryption or other export-controlled technology

ContributorAgreement.txt

@Criptic, sorry it took some time to get back to you.
Have a few small suggestions, that are hopefully to implement.

Labels of section controls do not adhere to UI Guidelines. More specifically your labels use "capitalize" each word, instead of "sentence capitalization". No need to update any video recordings, but updating the screenshot showing in the readme would be appreciated.
Your readme file contains a sentence with (a link to a page with) containing positioning statement, explaining when you might want to use this custom step instead of using the standard Git integration capabilities available in the SAS Studio UI. Really useful information. (thanks to @SundareshSankaran for creating that page) Could you also include that line in the About box of the step? Think about users that might simply download the complete repo as a zip file, extract all the .step files, and then upload them in one go to a folder in SAS Content, and then look at the step inside SAS Studio.

@snlwih thank you for the feedback I have implemented it accordingly in the update


Update dependencies to integrate voting tokens

still not compiling, a few things need to be fixed, but are mostly related to vit-servicing-station(-lib) and I'm still not sure what they are about.
also, I still haven't figured out what's the correct use of SessionMode, there are a few todo! in place.
catalyst-toolbox is pointing to a branch on my fork also, I need to open a PR in there updating dependencies too.

test failures is connected with known issue in jormungandr, which is being fixed at this moment


Support for cyrillic symbols

Currently I can't generate a pdf file from a document written in a cyrillic language (actually Russian).
Cyrillic symbols are not rendered and I don't get any errors during building.
Only if I write headers in Russian I get the following error:

/var/lib/gems/1.9.1/gems/pdf-core-0.2.5/lib/pdf/core/pdf_object.rb:55: warning: regexp match /.../n against to UTF-8 string

Example:
= Test document
Doc Writer<EMAIL_ADDRESS>:doctype: book
:source-highlighter: coderay
:listing-caption: Listing

Простой http://asciidoc.org[AsciiDoc] документ.

== Введение

Параграф с простым списком:

[square]
* первый элемент
* второй элемент

== Introduction

A paragraph followed by a simple list with square bullets.

[square]
* item 1
* item 2

This is a similar issue to the one reported by @chloerei. See #82. Currently, it's necessary to set the path to your own fonts that have the Cyrillic characters.
As for the regexp warning, that's because Ruby 2.0 or better is required to use Prawn (without warnings). Ruby 1.9 had really screwy UTF-8 support, so we don't recommend using it.

Thanks, Dan, for taking time to respond to this issue.
I will try to find appropriate fonts and upgrade to the Ruby 2.x.

Hi,
I Have a similar problem.
I'm working on a java project that need to convert an asciidoc to pdf and has non-Latin chars. the encoding is UTF-8 but the non Latin char will not render in the pdf like the issue posted before.
How could I force to render non-Latin word. is there any options to do it from java(not command line) or any other solution that should be take in  consider to fix it.
I'm using the following dependencies in my project :
   <dependency>
        <groupId>org.asciidoctor</groupId>
        <artifactId>asciidoctorj</artifactId>
        <version>1.5.2</version>
    </dependency>
    <dependency>
        <groupId>org.jruby</groupId>
        <artifactId>jruby-complete</artifactId>
        <version><IP_ADDRESS></version>
    </dependency>
    <dependency>
        <groupId>org.asciidoctor</groupId>
        <artifactId>asciidoctorj-pdf</artifactId>
        <version>1.5.0-alpha.6</version>
    </dependency>

thanks

Hi,
I Have a similar problem.
I'm working on a java project that need to convert an asciidoc to pdf and has non-Latin chars. the encoding is UTF-8 but the non Latin char will not render in the pdf like the issue posted before.
How could I force to render non-Latin word. is there any options to do it from java(not command line) or any other solution that should be take in  consider to fix it.
I'm using the following dependencies in my project :
   <dependency>
        <groupId>org.asciidoctor</groupId>
        <artifactId>asciidoctorj</artifactId>
        <version>1.5.2</version>
    </dependency>
    <dependency>
        <groupId>org.jruby</groupId>
        <artifactId>jruby-complete</artifactId>
        <version><IP_ADDRESS></version>
    </dependency>
    <dependency>
        <groupId>org.asciidoctor</groupId>
        <artifactId>asciidoctorj-pdf</artifactId>
        <version>1.5.0-alpha.6</version>
    </dependency>

thanks

At the moment, you need to create a custom theme and instruct it to use your own fonts. We have a guide about this here:
http://gist.asciidoctor.org/?github-asciidoctor%2Fasciidoctor-pdf%2F%2Fdocs%2Ftheming-guide.adoc#fonts
The reason these characters aren't supported out of the box is because I wanted to reduce the size of the gem. Fonts tend to be huge files. I trimmed down the fonts we currently bundle by subsetting the font to only include latin characters. The plan is probably to find a font that is small even with wide support (maybe NotoSerif) and ship that. Otherwise, we can just make the documentation good :)

/var/lib/gems/1.9.1/gems/pdf-core-0.2.5/lib/pdf/core/pdf_object.rb:55: warning: regexp match /.../n against to UTF-8 string

This warning is now fix. It was a bug in how I was adding metadata to the PDF.

Sorry for a late reply, but the hint from Dan worked for me. I was able to render a document in Russian
with Ruby 2.2 and Roboto font.

Yeah!! \o/

Hi,
First of all, thank for your quick reply.
As I found, I need to define a new theme in a YAML file and put 4 fonts of a famliy somewhere in the project and use the syntax like
base:
font_family: MyFont
where MyFont is my non-latin font.
Ok,good. But how could I Apply these YAML file and the fonts to my project?
in the url you've posted the applying section is empty and I don't know how to apply it.
One solution is to compile the project and embbedd the needed fonts and YAML instead of yours in the \data\fonts and \data\themes folder of the project and build a new jar for my project.
Is this the only solution or there is a solution to do  through the API? I use the following code snippet to do the convert :
    Asciidoctor doctor=Asciidoctor.Factory.create();
    Options options=OptionsBuilder.options().headerFooter(true).safe(SafeMode.SAFE).inPlace(true).backend("pdf").get() ;
    doctor.convertFile(new File(asciiFile), options);

Is there any solution to pass the YAML and fonts to above API? or I should recompile your project with my YAML and fonts? or there are any other solution?
Thanks

I still need to finish the docs :)
In the meantime, to get you going, you need to specify the path to the fonts folder using the pdf-fontsdir attribute. The value of this attribute can be any path, relative or absolute. A relative path is resolved relative to current working directory...which isn't correct, but that's how it works currently. Thus, specifying an absolute path is the best strategy atm.

One solution is to compile the project and embbedd the needed fonts and YAML instead of yours in the \data\fonts and \data\themes folder of the project and build a new jar for my project.

I don't recommend going down this path. Let's document what needs to be documented and, if necessary, fix Asciidoctor PDF.

Btw, now that I got the gem down to 1.2 MB, I think we can probably just ship a full version of NotoSerif out of the box and avoid this headache. I still think we need a dedicated font for CJK since we likely need a different font for that...but for Cyrillic, we should be able to just use NotoSerif.

Hi again and thanks
based on your solution, I did the follwing steps

Copy my fonts in the d:\myfont folder

renamed my fonts to the name your fonts have (for example : notoserif-regular-latin is my non latin regular font)

changed my code to :
 Asciidoctor doctor=Asciidoctor.Factory.create();
 Options options=OptionsBuilder.options().headerFooter(true).safe(SafeMode.SAFE).inPlace(true).backend("pdf").get() ;
 options.setOption("pdf-fontsdir","d:\\myfont\\");
 doctor.convertFile(new File(asciiFile), options);

but the problem not fixed and still the not latin font not renedered in the pdf, Am I missed something?
Thx

Hi again,
I don't know how to set the path of YAML and use my custom YAML, so I had to change my font name to yours. Is any attributes to set YAML path in a way that I can use my own YAML or better say overriding the default YAML(yours)?
thanks

This will be much easier once I finish documenting it.
Until then, I forgot to mention the other required attributes:

pdf-stylesdir - the path to the directory containing the YAML file
pdf-style - the name of the YAML file (if the value doesn't end in '.yml', then '-theme.yml' will be appended to the name)
pdf-fontsdir - the path to the directory containing the fonts

With those three attributes, Asciidoctor PDF should locate your theme and fonts.

Hi again,
I did the following

copied my fonts to d:\myfonts

copied the default-theme.yml to d:\myfonts and change its content to point to my fonts and renamed it to my-theme.yml

changed my code to
 Asciidoctor doctor=Asciidoctor.Factory.create();
 Options options=OptionsBuilder.options().headerFooter(true).safe(SafeMode.SAFE).inPlace(true).backend("pdf").get() ;
 options.setOption("pdf-stylesdir","d:\\myfont");
 options.setOption("pdf-style","my-theme.yml");
 options.setOption("pdf-fontsdir","d:\\myfont");
 doctor.convertFile(new File(asciiFile), options);

the content of YML is :

font:
catalog:
Nazanin:
normal: Nazanin-Regular.ttf
bold: Nazanin-Bold.ttf
italic: Nazanin-Italic.ttf
bold_italic: Nazanin-BoldItalic.ttf
# NOTE currently, callout numbers don't work with LiberationMono
#LiberationMono:
#  normal: liberationmono-regular-latin.ttf
#  bold: liberationmono-bold-latin.ttf
#  italic: liberationmono-italic-latin.ttf
#  bold_italic: liberationmono-bolditalic-latin.ttf
Mplus1mn:
normal: mplus1mn-regular-ascii-conums.ttf
bold: mplus1mn-bold-ascii.ttf
italic: mplus1mn-italic-ascii.ttf
bold_italic: mplus1mn-bolditalic-ascii.ttf
#Mplus1pMultilingual:
#  normal: mplus1p-regular-multilingual.ttf
#FontAwesome:
#  normal: fontawesome-regular.ttf
FIXME using fallbacks breaks use of custom font styles (fixed in Prawn 1.2.1!)
#fallbacks:
- Mplus1pMultilingual
brand:
primary_color: 428bca
page:
background_color: ffffff
layout: portrait
multiply inches by 72 to get pt values
margin: [0.5 * 72, 0.67 * 72, 0.67 * 72, 0.67 * 72]
size: Letter
base:
font_color: 333333
font_family: Nazanin

But the problem not fixed. the fonts that embedded in the pdf are still notoserif and mplus1mn and the nazanin(my font) not embedded in the final pdf. Am I miss something?
Thx

options.setOption("pdf-stylesdir","d:\\myfont");
options.setOption("pdf-style","my-theme.yml");
options.setOption("pdf-fontsdir","d:\\myfont");

This is incorrect. You need to specify attributes, not options. Here's what it should be:
Attributes attributes = AttributesBuilder.attributes()
  .attribute("pdf-stylesdir", "d:/myfont")
  .attribute("pdf-style", "my")
  .attribute("pdf-fontsdir", "d:/myfont");
options.setAttributes(attributes);

Hi, and thank you.
I did the changes and the non-latin font embedded now in the pdf. But few problem is still on the table:

The non-latin characters render left to right char by char and word by word whereas should be render right to left
2.The characters rendered as separated char whereas should appear as continuous and connected char in the words like situation is in the Arabic language. example: the word سلام which means Hello in English appears م ا ل س which is 4 chars in reverse order and separated chars which is not correct.

Have any ideas to fix?
Thanks

Asciidoctor PDF does not yet support RTL writing. (What does work is by chance because it hasn't been tested at all). This is an important, but separate issue. Could you file a new issue so we can start gathering requirements and sort out what is needed to make this work out of the box (or at least with clear instructions)? Until then, I won't know enough to advise you how to fix it. But I certainly want to be able to.
(There's also an issue with RTL writing in Asciidoctor itself. I'm well aware we'll need to address that at some point in the future).

Hi and thanks for your help.
I opened an issue [here] (https://github.com/asciidoctor/asciidoctor-pdf/issues/175#)
I hope that we have a solution on this issue as soon as possible for you :)
In the meantime If you had any points to to get I going, let me know,please.
Thanks

Resolved original issue with d0ea7b4f21800ae6afe26643cdee0b6210bf19d0.
We'll continue the discussion about RLT language issues in #175. I still have things to learn :)


rtl mode spaceBetween bug

Check that this is really a bug

[X] I confirm

Reproduction link
https://codepen.io/highlight091016/pen/NWzpPow
Bug description
spaceBetween is set to 24 and when the direction of the slide is 'rlt',
24px is applied to the margin-left and margin-right, so the alignment becomes strange from the second slide.
Expected Behavior
.swiper-slide {margin-left: 24px;}
Actual Behavior
.swiper-slide {margin-left: 24px; margin-right: 24px;}
Swiper version
8 (8,4,4)
Platform/Target and Browser Versions
chrome
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Same here, any updates?

Good day. Moreover, there is a problem on the last slide, there is also a margin right. Please remove the margin from the last slide.

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


fix: a11y colour contrast [LESQ-759]

Description
Music year: 1985
Ticket

use a predefined colour (grey60) instead of opacity (50%) for selected filter list item on unit listing thread list

Issue(s)
Fixes #
Insufficient contrast between text and background colour
How to test

Go to https://deploy-preview-2461--oak-web-application.netlify.thenational.academy/teachers/programmes/maths-secondary-ks3/units
You should see the colour of the selected filter item satisfies a11y guidelines

Screenshots
How it used to look (delete if n/a):

How it should now look:

:tada: This PR is included in version 1.448.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Investigate moving classes to Prototypes

The crt repo is in some uneasy netherworld of using bits of ES6, but not others. Some of this is for developer experience, and ergonomics, but mostly it's about not wanting to throw possibly bloated code at devices. Currently, there's no hard rules, other than trying to avoid things like async/await and iterators, such as for..of() loops.
We do use ES6 classes however, and it might be an idea to avoid them also.
For example
function Superclass(superProperty) {
    this.superProperty = superProperty;
}
Superclass.prototype.method = function() {
    console.log("Superclass's method says: " + this.superProperty);
};
function Subclass(superProperty, subProperty) {
    Superclass.call(this, superProperty);
    this.subProperty = subProperty;
}
Subclass.prototype = Object.create(Superclass.prototype);
Subclass.prototype.constructor = Subclass;

Subclass.prototype.method = function() {
    Superclass.prototype.method.call(this); // Optional, do it if you want super's logic done
    console.log("Subclass's method says: " + this.subProperty);
};

var o = new Subclass("foo", "bar");
console.log("superProperty", o.superProperty);
console.log("subProperty", o.subProperty);
console.log("method():");
o.method();

https://github.com/JohnPaulHarold/crt/pull/380


IPv6: implement table and tablex

Implementation and test cases for table and tablex for Ipv6

I see a few things resulting from running staticcheck and go fmt but I can fix those up in a follow-up.


Multiple text translation

I am programming a subtitle addon, is there a way to translate multiple text at the same time ?

You can send multiple requests.

Of course, you can also pass text separated by \n.


upgrade to v1.4

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


No module polylearn.loss_fast

`In [1]: import polylearn
ImportError                               Traceback (most recent call last)
 in ()
----> 1 import polylearn
/Users/manas/projects/polylearn/polylearn/init.py in ()
----> 1 from .factorization_machine import FactorizationMachineRegressor
2 from .factorization_machine import FactorizationMachineClassifier
3 from .polynomial_network import PolynomialNetworkRegressor
4 from .polynomial_network import PolynomialNetworkClassifier
/Users/manas/projects/polylearn/polylearn/factorization_machine.py in ()
22 from lightning.impl.dataset_fast import get_dataset
23
---> 24 from .base import _BasePoly, _PolyClassifierMixin, _PolyRegressorMixin
25 from .kernels import _poly_predict
26 from .cd_direct_fast import _cd_direct_ho
/Users/manas/projects/polylearn/polylearn/base.py in ()
10 from sklearn.externals import six
11
---> 12 from .loss import CLASSIFICATION_LOSSES, REGRESSION_LOSSES
13
14
/Users/manas/projects/polylearn/polylearn/loss.py in ()
2 # License: Simplified BSD
3
----> 4 from .loss_fast import Squared, SquaredHinge, Logistic
5
6
ImportError: No module named 'polylearn.loss_fast'`

Did you run python setup.py build at the project root? Do you have Cython installed?

Actually I realized we're bundling the .cpp files so I don't think Cython is an install dependency. I updated the readme accordingly.

@msh-tf are you still having issues?

Hi @vene, I'm seeing the same issue. I'm attaching the stdout/stderr in a text file so you can see specifics of my install, in case that helps you debug.
stdout_stderr.txt

I think the problem is you're trying to import polylearn from the source directory. This does not work. Try:
mkdir newdir; cd newdir; python -c "import polylearn"
In practice your scripts using polylearn should be in their own packages elsewhere on disk anyway. Let me know if this works.

Thank you @vene ; that resolves my issue!


Fix #2102: Deprecate JSExecutionContext.runNow

Review by @sjrd

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2757/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3552/
Test FAILed.

Updated.

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2759/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3555/
Test FAILed.

Jenkins, test this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2762/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3560/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2763/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3561/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2767/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3565/
Test PASSed.


Add workflows

This adds 2 workflows, one builds all of the projects and uploads the artifacts, the other checks that PR commit messages follow the Conventional Commits style.

Thanks, this looks awesome!
But I'm currently not sure what the intended purpose of the uploaded artifacts is. How would they be used in your opinion?

I've been looking at the workflows of other plugins, and all of the ones I've seen upload artifacts just to make dev builds more accessible I assume.

Ah that makes sense. It the current state the dev builds would be slightly dysfunctional though:
When building vane, the SHA1 sum of the associated resource pack (from the github docs/resourcepacks folder) will be included into the JAR file. So those builds will break if the version is bumped. I'm not sure how severe the failing action would be.
I'm curious though, what plugins did you look at?

Here are a few:

https://github.com/kennytv/Maintenance
https://github.com/plan-player-analytics/Plan
https://github.com/EssentialsX/Essentials

If these builds are subject to breakage, that should probably be noted here too.

Thanks for the pointers :)
It's actually not too big of an issue, because you don't randomly bump the version in PRs, as that would only be done by a maintainer (so currently by me) on a new release. So the builds wouldn't break for anyone but me.
Currently there isn't a lot of accessible documentation about the vane framework, so that would be something to improve in the future, and that's where this should definitely be mentioned.
I'll have a closer look at this PR tomorrow (it's late for me now).

Forgot, here's the message you'll get when you have an invalid commit message: https://github.com/Serial-ATA/vane/pull/2#issuecomment-1229050532


Do the Attacks have to be Successful?  (with Netherlands Example)

For example
https://nltimes.nl/2020/02/02/violent-robbery-bitcoin-trader-included-water-boarding-power-drill
in the Netherlands, they tortured this guy for Bitcoin and other digital assets but they didn't get anything.
Feb 10th, 2018

No, the only real requirement is that violence / a threat of physical violence was used. That incident is already in the repository.


Transmitting card data to card reader on touch

Hey,
Thanks for creating this library it is really useful. I was wondering how should I make card data available when a user wants to transmit card data when he touches a card reader?
The workflow I want to implement:

User touches card to phone, reads card data to phone
User touches phone to card reader, card reader picks up the data

How would I implement something like this?
Thanks

@GEMI +1. It will be very interesting to do that, even on Android phones only. I'm trying to use this library with no luck
https://github.com/appidea/react-native-hce

Did you find any solution? I'm trying to achieve similar thing.

Well that’s what I implemented. With this library I solved this with NDEF messages. If you use PN532 reader then, it could acts like a virtual writeable NFC tag. You can easily write your card data into it.


Maintenance of fundamental_matrix method and its application in ODESystem class

The goal is to use _to_rhs_ode method in fundamental_matrix and its further application within methods of ODESystem class.

Guys @amvdek @mopar4or2no6car,
Could you add any call for this method?


[hacktoberfest] payout airtime project completed

[hacktoberfest] redeem airtime Link to referred issue

Could you remove all the .DS_Store files or add //.DS_Store to your .gitignore file
I see two folders for the Airtime submission. Which one do you want to submit? Could you have all your code in one folder in the submissions folder?
Looking forward to reviewing it @mzoyinda

Thanks for pointing out the errors, i have removed all the .DS_Store files and removed the multiple payout folder.

I have approved it
Some things

How are you managing the API keys? Because the live version says the API key in invalid
The UI on mobile is broken. Could you make it responsive?

@mzoyinda Kindly attend to these changes.

Yeah, i had to remove the API keys for security reasons.
But I think the remaining $6 in my account for testing has been removed totally by the admin,
wanted to send a mail for that though..
So since it is currently empty, I can add the real API Keys, but still, nothing would be paid out ooo
as the account is empty.

I'd also fix the mobile responsiveness

Please do not hardcode the key. Use environment variables or a config file. There a a few ways to do it if you search Google but let me know if o can help clarify
also, consider using the /payout/initiate-chimoney endpoint then after it’s successful, redirect to paymentLink from the response. This ensures that anyone can use your app to send Chimoney and they pay from their own Chimoney wallet, not yours, since initiate-Chimoney creates a transaction without paying for it. Pass phoneNumber, country into the redeemData field as outlined in the redeem/any endpoint
happy to clarify when I’m on my laptop
The api key gives you access to the api to initiate the payment

Oh.. i just tried out your suggestion on the docs and that can work too
But it would be changing the whole project from payout airtime to payout chimoney.
Also, the payment link I got after the request was successful is taking forever to load. (if you can look into that.)
So what happens after the payment link loads.. would like to know the flow.

Hi @mzoyinda, could you try the Payment link again? Fixed

Hi @uchibeke you can check out the updated project for changes


Light stays off - adapter is green

Hello
the adapter is green, has a connection but cannot be controlled.
the light works via the govee APP (WLAN, not BT)
I got error 429 in the log
Greetings

https://github.com/nbuenger/ioBroker.govee/issues/19#issuecomment-1347184171
Ok error 429 is clear
but is that the reason that i can no longer control a lamp


docs: add paragraph on caching in the README

Description

This PR adds a paragraph on caching in the README.
Types of change

This is a documentation change.
Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[x] I ran the tests (including the external tests), and all new and existing tests passed.
[x] My changes don't require a change to the documentation, or if they do, I've added all required information.

My markdown linter also lowercased every link so I guess it's good practice? Anyway, that's not the important part.


Add support for text input forms

General Troubleshooting

[X] I have checked for similar issues on the Issue-tracker.
[X] I have updated to the latest JDA version
[X] I have checked the branches or the maintainers' PRs for upcoming features.

Feature Request
Discord has released the ability to create text imput forms. It would be nice if JDA will implement that.
Example Use-Case
No response

This is already supported since 5.0.0-alpha.11

Isn´t that the implementation of Modals added in Alpha11?


Files and folder locker

Description of the new feature / enhancement
This new feature will allow the user to lock the file or any folder with a password
Scenario when this would be used?
It will be a quite handy tool , if password protection can be applied to the files or folder it will be more secure and user will be more confident about data security if the data get stolen.
Supporting information
No response

Not planned for PowerToys.
Refer to https://github.com/microsoft/PowerToys/issues/21759#issuecomment-1304392992


Add TiDE modules and implement it as an imputation model

What does this PR do?

fixing #393;

Before submitting

[x] This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
[x] Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have written necessary tests and already run them locally.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 65 (0.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 82.842%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pypots/nn/modules/tide/init.py
0
2
0.0%

pypots/nn/modules/tide/layers.py
0
28
0.0%

pypots/nn/modules/tide/autoencoder.py
0
35
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
9101

Relevant Lines:
10986

💛  - Coveralls


Why Element IDs are zeros?

Hi @netsonicyxf, apologies for the late reply.
The IDs in all objects (Sections, Prop2d/3d, Nodes, Elements, Members, etc) works like this:

If the hasn’t been part of an assembled model yet the ID will be zero
After assembling the model the objects (coming out of the model with for instance GetGeometry component) will have been given an ID automatically by GSA
You can set the ID to overwrite existing objects in a model
Objects with ID = 0 will always be appended to the model.


fix docs and test requirements to minor version

and let dependabot handle keeping them up to date
Note that ~= 1.0.2 matches all version >=1.0.2  but < 1.1.0 (e.g. all patch version on the 1.0 branch)
https://pip.pypa.io/en/stable/user_guide/#understanding-your-error-message

It seems like IPython has already dropped support for python 3.6 so if we want to do this we should either first remove our python 3.6 jobs or be less strict with the ipython versions we require

first remove our python 3.6 jobs

voting for this :)


H4C IDR2.2

Given that there are so many moving parts in the analysis, I figured it would be a good idea for the pipeline to go through an informal PR before we re-run the H4C analysis. I am hoping that this PR serves as a useful reference for completing the H4C IDR2.2 memo, and also serves as an additional point of reference for trying to understand how the pipeline works. I have tagged as reviewers people who I tagged in the Slack thread where we started discussing this, just for the sake of putting it on the radar for interested parties—this discussion should also be open to other interested folks in the collaboration.
Here is a list of things that I think are important and should be discussed and generally approved by the group. I do not expect that this is a complete list, so please suggest things to add or remove.

Structure of the analysis pipeline code.

I have initialized a idr2.3 directory with the intent that this is where the final version of the pipeline will live. I simply copied over what looked like the most up-to-date pieces of the pipeline and organized them in an attempt to emulate the structure used in previous iterations (e.g., H1C IDR3).
This is currently split up into four major sections:

rtp broadly contains calibration, flagging, smoothing, and imaging, all performed on a per-night basis. I just copied over files from rtp/v2.
pre_lstbin contains in-painting, "crosstalk" filtering (i.e., the notch filter step), coherent time averaging, and per-night power spectrum estimation. The files were copied over from post_processing/v7_interleave/pre_lstbin. Note that time averaging and per-night power spectrum estimation products are only meant to be used in a diagnostic sense and files produced from this step should not be propagated further down the pipeline. I will update the in-painting parameters to reflect the new spectral window choices based on @Kai-FengChen's work.
lstbin contains two pipelines: one for LST-binning the sum files, and another for LST-binning the diff files. The files were copied over from post_processing/v7_interleave/lstbin.
post_lstbin_frate contains everything downstream of LST-binning: "main-lobe" fringe-rate filtering, coherent time averaging, power spectrum estimation, and "auto errors" (which I assume is estimating thermal noise error bars?). I will be modifying things related to fringe-rate filtering to use the new filter parameters.

Details of the pipeline tasks.

I'm not sure where we ended up with regard to trying to use data that was potentially affected by "jumpy gains", so it's possible that I copied over the wrong set of files.
Do we still want to generate the diagnostic per-night files?
Do we still want to generate per-night images?
Do we still want to generate nightly notebooks?

Environment version control.

I think everyone is on board with tracking the environment through an environment yaml that can be parsed by conda. We just need to agree on the versions of the various packages and save the environment yaml in the relevant pipeline directory.

Division of labor.

Who is responsible for running the various parts of the pipeline?
Are there other parts of the pipeline that need to be updated aside from what I've listed above?
Who is in charge of writing the IDR memo? Are we breaking this up by section?

General tidying up.

There are a lot of files with very long and descriptive names, and some of the files have code which wraps in some editors. I think this is fine when the pipeline is under active development and is still in the experimental phase, but I think we should tidy things up a bit before crystallizing the pipeline.

At the last pspec call, I was assigned with divvying out tasks to do related to this last push, so here's what I would like to propose:

As I understand it, @lisaleemcb and @JianrongTan will primarily be in charge of re-running the pipeline, potentially with help from @Kai-FengChen. Given that, I think it would be a good idea for the two (or three) of you to decide who is going to be responsible for re-running which section. Additionally, I would like to request that you do a high-level review of the code (i.e., just check to make sure that the things we've changed look OK, and check that all the hard-coded paths are sensible) prior to merging this PR.
It's still unclear to me which set of rtp-related files were used for the latest round of analysis. Could some combination of @aewallwi and @jsdillon confirm or deny that I've chosen the correct set of rtp-related files to copy over? If I've chosen the wrong set of files, then can you tell me which files I should have copied over?
@JianrongTan can you look into the error estimation step of the pipeline and update things there if necessary?
@lisaleemcb can you get the environment version control stuff set up and make sure that the environment names in the toml files are correct?
@Kai-FengChen can you update the inpainting-related things?
I will update the "main lobe" fringe-rate filtering things.
@acliu can you make an executive decision about who will manage writing the memo?

I think those are the main items for now, and I hope this is a fair distribution of labor. Please let me know if there are any issues with what I've proposed.

It's still unclear to me which set of rtp-related files were used for the latest round of analysis. Could some combination of @aewallwi and @jsdillon confirm or deny that I've chosen the correct set of rtp-related files to copy over? If I've chosen the wrong set of files, then can you tell me which files I should have copied over?

The key question boils down to whether https://github.com/HERA-Team/hera_pipelines/blob/b1456ec411793d2b97d58dab042438bf028925ed/pipelines/h4c/idr2.3/rtp/h4c_rtp_stage_2_throw_away_flagged_baselines_keep_fluctuating_ants.toml is the right TOML. I think so, but @aewallwi should confirm.

I think that if we want to incorporate the interleaving machinery for postprocessing we should be copying the files from v7 while it looks like we are using v6?

It's still unclear to me which set of rtp-related files were used for the latest round of analysis. Could some combination of @aewallwi and @jsdillon confirm or deny that I've chosen the correct set of rtp-related files to copy over? If I've chosen the wrong set of files, then can you tell me which files I should have copied over?

The key question boils down to whether https://github.com/HERA-Team/hera_pipelines/blob/b1456ec411793d2b97d58dab042438bf028925ed/pipelines/h4c/idr2.3/rtp/h4c_rtp_stage_2_throw_away_flagged_baselines_keep_fluctuating_ants.toml is the right TOML. I think so, but @aewallwi should confirm.

This is the correct toml. There have been a few bug fixes since this PR was introduced (though no updates to the params for frf and spws) so I think we should rebase on main.

Great, thank you for the clarification! Are the bug fixes already on main?


Replaced South by Django's schema editor

Let the fun begin.

Down to 5 failures.

All tests are passing on Django 1.7. I'll try to tackle 1.8 in the next weeks.

Ok all tests should be passing against Django 1.8 at this point.
The remaining issues are the following:

[ ] Use the new Meta api on Django 1.8 to prevent deprecation warnings.
[ ] Stop using SubFieldBase on Django 1.8 to prevent deprecation warnings.
[ ] Attach signals in an app config ready() method instead of all over the place.
[ ] Figure out what to do with the deprecated IPAddressField.
[ ] Write some documentation about the migration process from the previous version.
[ ] Investigate the RessourceWarning about uncollectable objects at the end of CI runs by using gc.set_debug(gc.DEBUG_UNCOLLECTABLE).
[ ] Fix the remaining XXX and FIXME.

The ressource warnings are related GIS objects.

Coverage increased (+1.2%) to 94.121% when pulling a34f1f1e7aefc15ef06ea9292db2c55df89b0c6c on migrations into dc0f086450234b8290bec0bc4bb504330efee343 on master.


⚠ ClamAV has degraded performance

In 9dc2f4c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 724 ms

Resolved: ClamAV performance has improved in 0bcaee6.


Potential data analysing loss

In line 129 in index.js the loop only loops the first element of the object.
This can result in potential data analysing loss.

Fixed with 9f7a078c5c6510920489af491026f4d7d2ced4ac


Support envtests with gardener resources

How to categorize this issue?

/area dev-productivity testing
/kind enhancement
What would you like to be added:
Support for writing integration tests with controller-runtime's envtest package that can use gardener API resources.
A promising approach is to add a wrapper for envtest, that is spinning up and registering g-api in the test environment.
Why is this needed:
envtest is great for writing integration tests that can be executed without any infra against a temporary control plane.
Though, we currently can't use gardener resources, as envtest primarily only supports CRDs but not extension API servers.
Steps

[x] add gardener envtest package ➡ https://github.com/gardener/gardener/pull/3796
[x] adding an example integration test suite for a controller ➡ https://github.com/gardener/gardener/pull/3925, see https://github.com/gardener/gardener/blob/278e9b4e584404e14ec1b0d214987a19f4352eb0/pkg/controllermanager/controller/shoot/shoot_retry_control_test.go#L44 also see https://github.com/gardener/gardener/issues/4655
[x] adding an example integration test suite for a webhook (e.g. GAC audit policy webhook)
[x] ~contributing upstream and get rid of our fork~ not required anymore with https://github.com/kubernetes-sigs/controller-runtime/pull/1449#issuecomment-863049761
[x] disable race detector for envtests (see https://github.com/gardener/gardener/issues/4036) ➡ https://github.com/gardener/gardener/pull/4265
[x] retry starting g-api on failure to further improve stability during resource contention in pipelines ➡ not observed in prow anymore, postponed until observed again

/assign

Minimum required changes for this scenario in upstream envtest package are proposed in https://github.com/kubernetes-sigs/controller-runtime/pull/1449.

@timebertt can you outline the next steps here so that everybody is aware? Is it only about contributing the required changes upstream and getting rid of our fork again, or is there more?

The next steps could include:

[ ] adding an example integration test suite for a controller (e.g. GCM project controller)
[ ] adding an example integration test suite for a webhook (e.g. GAC audit policy webhook, cc @BeckerMax)
[ ] adding a bit of developer documentation on how to use the package, what's the goal of such tests, when to use a test env vs mocks (just a few sentences each)
[ ] contributing upstream and get rid of our fork

However, I'm not working on any of those tasks currently.
/unassign
Others are welcome to contribute to this :)

All tasks are done now!
/close


[Bug] Textbox value getting reset when allowNewOption and onServerSearch enabled

When both properties (allowNewOption and onServerSearch) is enabled,
After typing a search value for which the function bound to onServerSearch doesn't return any results, the option to add new option comes with the + symbol.
On clicking this option, the function bound to onServerSearch gets called again with an empty string param which causes the field to get reset since server returns no result and setServerOptions() gets called with blank data.
Workaround is to put a return in function bound to onServerSearch like this
if(searchValue == "") {return;}
but this causes the dropdown to show an infinite loading symbol when you clear the search text.
Ideally, on selecting newly added option, the search function should not be called in the first place.
If I get time I will try to find a fix and create pull request :)

@SahajJain01 This issue has been fixed in the release v1.0.32

I am facing this same issue, clicking on a search result triggers search with an empty term. This issue should be fixed on 1.0.32.. However, 1.0.32 and 1.0.33 i think it is somehow mis-built. As I understand from merged PR, a new isClearingSearchValue introduced to fix this issue. But in versioned js file, these changes are missing.  Can you check please? @sa-si-dev @caiosm1005

Should I open a new issue for this? @sa-si-dev


Trouble with surfing

Hello,
I've set up my unity scene so I can jump strafe around, but I created a surfing platform, and it doesn't seem to work the same as source engine. When I surf down a block and try to go back up, the player slips and doesn't get momentum to go up the surfplatform.
I did modified the setting a lot, but i also tried it using vanilla settings on a fresh project, yielding similar results.
I'm sorry if this isn't the place to ask for help, but IDK where else to ask.
I think it has something to do with friction, but applying a PhsycisMaterial with 0 friction (to the surf platform) makes it worse.

I'm having this problem too..


77 user bookings on admin profile page

fixes #77 .
tooltips:

user bookings page:

Tooltips can just be "Edit" and "View Bookings" (LESS IS MORE!). I would also swap them round so edit is furthest to the right.
Title on page can just be the email address (instead of Bookings for... as it already says User Bookings above.
I would recommend using a table instead of a <li> list.  It offers consistency with the page alone, but could then allow for sorting by office name or date, e.g.

Office
Date

Bath Road
Wednesday 2nd September

Buckingham Avenue
Thursday 3rd September
Cancel

Bath Road
Friday 4th September
Cancel

Then you could also include the Cancel button in the third column for current/future dates.


Switch to use String.prototype.indexOf instead of String.prototype.includes

To fix #131 by switching to String.prototype.indexOf instead of String.prototype.includes

Thanks!


Added code snippets for common tasks in code generator part of custom step

Please include answers to these questions as part of your pull request
In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).

[X] Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
[ ] No

Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.

[X] My contribution does NOT include PII data
[ ] My contribution includes PII data

Q3: Confirm your contribution does not include any encryption or other export-controlled technology.

[X] My contribution does NOT contain encryption or other export-controlled technology
[ ] My contribution includes encryption or other export-controlled technology

ContributorAgreement-Wilbram.txt

Implemented the cleanup of macros and removal of some empty lines.
Waiting for feedback from the provider of the Python code (which I just copied/pasted and then added credits)


⚠ Bofrost.de has degraded performance

In 5600ca8, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1487 ms

Resolved: Bofrost.de performance has improved in 7cd835b after 7 minutes.


Add support for Custom test configuration

Hi,
I'm trying to create multiple test configurations because async tests require PhantomJS(autoExit =false), but I think that utest doesn't support setting a filter in testOptions, at least I couldn't figure that out. I was playing with this setup :
  lazy val AsyncTest = config("async") extend(Test)

  lazy val js =
    project.in(file("js"))
      .configs(AsyncTest)
      .settings(scalaJSSettings:_*)
      .settings(utestJsSettings:_*)
      .settings(inConfig(AsyncTest)(Defaults.testSettings ++ utestJsSettings) :_*)
      .settings(
        persistLauncher in AsyncTest := false,
        testOptions in AsyncTest := Seq(Tests.Filter(s => s.contains("Async"))),
        postLinkJSEnv in AsyncTest := new PhantomJSEnv(autoExit = false),
       )

But the testOptions never works, either all tests are executed or none is.
Do you have any idea how to make it work, or what might be the problem ?

FWIW here's the link to SBT docs on testOptions: http://www.scala-sbt.org/0.13/docs/Testing.html#Options


Only single quote string is allowed in where clause

What type of bug is this?
Other
What subsystems are affected?
Frontend
What happened?
It seems our WHERE clause follows PostgreSQL dialect that only allow string wraps in singe quote '. While in MySQL, it allows both single quote and double quotes.
The behaviour is inconsistent for INSERT statement, when providing values, double-quote strings are accepted.
We should change WHERE clause to accept double-quote string as well.
What operating system did you use?
any
Relevant log output and stack trace
No response
How can we reproduce the bug?
Run SQL:

SELECT * FROM system_metrics WHERE host = "abc";

I'd like to work on this issue.

I'd like to work on this issue.

Assigned it to you, Thank you.

Thank you for your quick reply!

If we want different behavior, maybe we could switch to MySqlDialect.

I initially considered using MySqlDialect, and then I replaced GenericDialect with MySqlDialect:
https://github.com/GreptimeTeam/greptimedb/blob/6b6617f9cb24439b29b79bbc2bb7dee99a656d40/src/frontend/src/instance.rs#L435-L437
but several tests fail, like so:
    ... skip(26) ...,
~   Error: 3000(PlanQuery), No field named "a". -> +-----------+,
+   | Utf8("a") |,
+   +-----------+,
+   | a         |,
+   +-----------+,
    ... skip(3) ...,
~   Error: 3000(PlanQuery), No field named "A". -> +-----------+,
+   | Utf8("A") |,
+   +-----------+,
+   | A         |,
+   +-----------+,

//..

[
    ... skip(358) ...,
~   Affected Rows: 0 -> Error: 2000(InvalidSyntax), sql parser error: Expected column name or constraint definition, found: "Sort",
    ... skip(12) ...,
~   Affected Rows: 9 -> Error: 4001(TableNotFound), Table not found: greptime.public.DirectReports,
    ... skip(5) ...,
~   +------------+-------------------+------------------------------+---------------+ -> Error: 4001(TableNotFound), Table `greptime.public.DirectReports` not exist,
-   | EmployeeID | Name              | Title                        | EmployeeLevel |,
-   +------------+-------------------+------------------------------+---------------+,
-   | 1          | Ken Sánchez       | Chief Executive Officer      | 1             |,
-   | 273        | >Brian Welcker    | Vice President of Sales      | 2             |,
-   | 16         | >>David Bradley   | Marketing Manager            | 3             |,
-   | 23         | >>>Mary Gibson    | Marketing Specialist         | 4             |,
-   | 274        | >>Stephen Jiang   | North American Sales Manager | 3             |,
-   | 276        | >>>Linda Mitchell | Sales Representative         | 4             |,
-   | 275        | >>>Michael Blythe | Sales Representative         | 4             |,
-   | 285        | >>Syed Abbas      | Pacific Sales Manager        | 3             |,
-   | 286        | >>>Lynn Tsoflias  | Sales Representative         | 4             |,
-   +------------+-------------------+------------------------------+---------------+,
    ... skip(35) ...,
~   Affected Rows: 1 -> Error: 4001(TableNotFound), Table `greptime.public.DirectReports` not exist,

Environment standalone run finished, cost:2709ms
Failed cases:
[
    "/Users/username/Desktop/greptimedb/tests/cases/standalone/common/create/create",
    "/Users/username/Desktop/greptimedb/tests/cases/standalone/common/select/dummy",
    "/Users/username/Desktop/greptimedb/tests/cases/standalone/order/order_variable_size_payload",
]

This issue seems to be more difficult than I thought because we need to make the MySqlDialect operate only within the WHERE clause. Does anyone have any ideas for a implementation?

@sunng87 Do we still consider this a bug?

Because we are going to act as a drop-in MySQL replacement, I still believe we need to be compatible with its dialect. Maybe we can switch to MySqlDialect globally to see what impact is it. We already have strong sqlness test suite and it should be relatively easy to judge.

Thank you for your quick reply, @sunng87.

Maybe we can switch to MySqlDialect globally to see what impact is it.

I guess that we could switch to the MySqlDialect globally by making changes here:
https://github.com/GreptimeTeam/greptimedb/blob/6b6617f9cb24439b29b79bbc2bb7dee99a656d40/src/frontend/src/instance.rs#L435-L437
What is your opinion on this?

Thank you @NiwakaDev, if you want a quick verification, you will need to update this as well:
https://github.com/GreptimeTeam/greptimedb/blob/develop/src/query/src/parser.rs#L54
I agree this is heavier than a "good first issue". We can take over this if you are ok.

@sunng87

I agree this is heavier than a "good first issue". We can take over this if you are ok.
Sure. I'll look for other issues.

We are using different dialects in different protocols, so i think it's not an issue right now.


cortex-tools client results in huge binary

The cortex-tools project includes a client for the cortex-ruler. This, in itself, seems pretty simple. However, including the client into a simple golang app causes that app to go from 12->72Mb, importing Cortex, AWS CLI, and lots of other things.
Is it possible to simplify the client such that it doesn't increase binary size so much?

@owen-d
I think this is caused by importing this package from Loki: https://github.com/grafana/cortex-tools/blob/432ad779ae0f28552ffe7f1f0d6ddd3c32b52210/pkg/rules/parser.go#L10
Would it be possible to isolate the ValidateGroup function into a package that doesn't include so many vendored dependencies or fork the code here?

I don't think this is just the ValidateGroup function, there's also the logql parser for linting of rules that's importing a big portion of loki.

Good catch @jtlisi. When I initially added Loki support, I blanked added the entire project as a dependency. Likely we can slim this down substantially.


Week 5: GCloud Branch of SCC Training Material

Topics: Amend the following sections of the Selection Round Training material, in an appropriately named branch:

Tutorial 1: Section 3 - Launching your first GCloud Instance
Tutorial 3, Section 8 - Spinning up a Second Compute Node Using a Snapshot
Tutorial 4, Section 4 - Automating the Deployment of Your GCloud Instances Using Terraform

Tasks:

Create a feature branch that adds a section with pictures to the tutorial content
Submit a PR

To assist you in editing markdown and preparing your Pull / Merge Requests, you are strongly advised to review:

The first page from Selection Round Content Contribution to the Project, just that you will be creating a fork.
The section just below that, with the links to GitHub Markdown Syntax and Style.


Roll engine 289c6b1a1c27..bf377896ff0f (2 commits)

https://github.com/flutter/engine/compare/289c6b1a1c27...bf377896ff0f
git log 289c6b1a1c27..bf377896ff0f --no-merges --oneline
bf377896f Revert height (flutter/engine#6477)
ec103ad52 Roll src/third_party/skia a41a74ac7994..ef85d19100b1 (11 commits) (flutter/engine#6476)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll


libsodium: 1.0.3 -> 1.0.4

See https://github.com/jedisct1/libsodium/releases/tag/1.0.4
Builds successfully for me, all tests pass, nothing scary in the changelog, as far as I can tell.

The travis failure is unrelated:
building path(s) ‘/nix/store/8n9xkwpdx7kqsicjx42kq26bys8a3gv2-0.5.2.zip’
 57 8703k   57 5029k    0     0   558k      0  0:00:15  0:00:09  0:00:06  607k
trying https://github.com/rescrv/po6/archive/releases/0.5.2.zip
output path ‘/nix/store/8n9xkwpdx7kqsicjx42kq26bys8a3gv2-0.5.2.zip’ should have sha256 hash
‘14g3ichshnc4wd0iq3q3ymgaq84gjsbqcyn6lri7c7djgkhqijjx’, instead has ‘17grzkh6aw1f68qvkhivbb6vwbm6jd41ysbfn88pypf5lczxrxly’


Added support for custom paths

Checkout on https://bin.sohamsen.me for a demo!

Closes #10 and #17.


[core] Create a CLI for create-mui-app

[X] I have followed (at least) the PR section of the contributing guide.

Description
This PR will add the possibility to run npx create-mui-app, where the user can select from different options to get a boilerplate app with the chosen packages:

(I cancelled the dependency installation, it runs successfully)
Currently done
This PR is currently work in progress, but there has been a lot of progress:

Running the command shows an interactive TUI
The selections are used to copy the correct template and configs
The correct dependencies are installed
The package.json file is updated correctly

Todo
Tthere are a few things missing:

[x] add message on what to do next after running the command
[x] render a title of some sort (would need some input on this)
[ ] improve templates

my idea would be to create a Card component (or something similar) for both Joy UI and Material UI in js and tsx and adding this to the templates
[ ] create component

[ ] joy js
[ ] joy ts
[ ] material js
[ ] material ts

[ ] implement component correctly

[ ] Tests would be nice
[ ] READMEs should be updated (in templates, currently missing in the create-mui-app directory)
[ ] other docs?
[ ] add rollup.config.mjs (missed that apparently)

closes #39588

I would need some help with the following:

the existing build scripts are not working with the project. it's probably the best to write a new one?
I'm kind of stuck with the templates. I'm not too deep into all the possible packages that material-ui provides and my idea to mix and match each package with each possible framework is much more complicated than I anticipated

Not sure how I missed this. Really appreciate the effort.
I'd say it would be nice if you could open source this CLI and publish it in your own name because this kind of feature requires a lot of discussions and we are at full capacity for v6. I'd love to try it and share your work!


Added Example Notebook and Working Docker File

Added Example Notebook and Working Docker File to hopefully simplify sharing and use!

Thanks for the cool notebook!


icon in footer

there is no github icon in footer of all pages. I want to fix it. Please assign this issue to me under JWOC.

@kaal-coder Pls assign this issue to me so that I can work on the fix.


Reset recomputations

Addresses #26
Also, fixes up unit tests for extension & a couple housekeeping items.

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #33   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          20     20
=====================================
  Hits           20     20

Impacted Files
Coverage Δ

src/index.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1175df8...4e19d3d. Read the comment docs.

Coverage remained the same at 98.246% when pulling 4e19d3dea70b643cec55dbce950a694f5a56a741 on reset-recomputations into 1175df8465356b94f39af2197019c44355c957f4 on master.

I approve!


Bad performance

Hi,
I already found #279 and I think I have the same issue.
I am using the code from #279 for benchmarking (only checking faster-whisper).
A 2 seconds wav-file needs nearly 3 seconds to process with the "small" model. Using large-v3 takes 12 seconds.
Running a VM with 8 cores (2,4ghz) and 16GB memory, no GPU.
Python 3.12 and faster-whisper 1.0.3
I dont think this performance is expected, right?

A 2-second clip isn't a great test - the model takes time to load. Your measured time may be mostly model load rather than transcription. I would test on at least a 30-second clip.
The OpenAI Whisper models are optimized for GPUs. The original whisper ones are much slower on CPUs - though the difference is reduced with faster-whisper.
Some reference numbers from my testing with the "small" model: 6 min 30 second audio in English
Original OpenAI Whisper: small, beam size 5.
Ryzen 5 5600G desktop CPU: 4m 22s
NVIDIA GTX 1050 Ti Max-Q: 1m31s
Faster-whisper: int8 quantized model, beam size 5, 4 CPU threads for CPU mode:
Ryzen 5 5600G desktop CPU: 0m54s
Ryzen 5 5600U laptop CPU: 1m3s
NVIDIA GTX 1050 Ti Max-Q: 0m28s
For faster-whisper I found that more than 4 CPU threads made little difference. Memory bandwidth matters as single RAM stick increased time by 50% or so.


Does it support other languages apart from English?

Yes, as long as you have pretrained word emeddings for each word token.


Uploaded

Hey, @rchung95 thanks so much for considering a contribution here! 😄
The icon looks amazing, I'll surely replace the app icon with this.

Btw just checked out one of your repo on pokedexVuejs, it looks totally amazing. 👍
Perhaps I've got a something similar repo here https://github.com/anshumanv/evolutions-webapp in which I'm unable to proceed, can you please look into it if you don't mind?
Thanks 😄


New rule: tabpanel should be related to a tab

per the recomendations from the WAI-ARIA guidelines on the role tabpanel
found here: http://www.w3.org/TR/wai-aria/roles#tabpanel
Addresses #228

And we can add this to the Wiki:
AX_ARIA_13

Good:

Tab 1

Tab 2

 Some content in the first tab panel

 Other stuff in the second tab panel

Tab 1

Tab 2

 Some content in the first tab panel

 Other stuff in the second tab panel

Bad:

Tab 1

Tab 2

 Some content in the first tab panel

 Other stuff in the second tab panel

Tab 1

 Some content in the first tab panel

This describes the content of the tabpanel

An element with the tabpanel ARIA roles should be related to an element with the role tab. Either the tabpanel can have an aria-labelledby referencing the tab's id, or the tab can have an aria-controls referencing the tabpanel's id.
You can find more information on the tabpanel role on the WAI-ARIA site.

This will generate mostly false positives for two reasons

it is only a SHOULD requirement, and
the tab panels can be added dynamically by JavaScript and only have to be there when the tab itself is selected

The second concern shouldn't be a problem with this audit. It only checks that the tab panels have a tab which controls them, not whether the tab has a tab panel. So if the tab panel hasn't been added yet, it won't fail the test.
In regards to the first concern, I gave it a warning severity instead of severe for that reason. However, my understanding is that although this is only a SHOULD requirement, it is of great importance for the usability of tabs, and thus worth having an audit for.

Good idea @dylanb. I added the test for that case (and caught a bug in the process).

:+1: once comments addressed and Changelog updated.

Thanks Alice. I made those changes.

@ctaymor Did you update the Changelog too? You may need to pull the latest version.

@alice Sorry, I did update the changelog, but not correctly because I hadn't pulled in the latest version. This should fix it with the latest changelog.

Thanks!


chore(localize): updated translation from Crowdin

:tada: This PR is included in version 2.43.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Self-training a fine-tuned wav2vec2 model?

What is your question?
I did fine-tune a Wav2vec2 model. Now, I would like to do self-training this model to reinforce it with our unlabeled data. Could you give me some guidelines?

wav2vec works generally works by pretraining a model with unlabeled data and then fintuning it for ctc with labeled data, not the other way around.

wav2vec works generally works by pretraining a model with unlabeled data and then fintuning it for ctc with labeled data, not the other way around.

If you see this paper https://arxiv.org/pdf/2010.11430v1.pdf, they did a supplement self-training after the fine-tuning. This is not only help reinforce the model but also improve the performance.

Ah, haven't seen configs for that here, I guess wav2vecu superseeds that approach. Maybe @alexeib could tell you more.


Use --rm option to automatically clean up runner container

Makes sense, great shout.

I created a repo (without the caddy file) with this pull request: https://github.com/Luca-Castelnuovo/mail.ltc.

Added this. Useful idea, thank you!


Error running process:dynamic_prompting.py

Describe the bug
Script does not work properly when generating images.
To Reproduce
Error running process: /storage/stable-diffusion/stable-diffusion-webui/extensions/sd-dynamic-prompts/scripts/dynamic_prompting.py
Traceback (most recent call last):
File "/storage/stable-diffusion/stable-diffusion-webui/modules/scripts.py", line 409, in process
script.process(p, *script_args)
File "/storage/stable-diffusion/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/dynamic_prompting.py", line 417, in process
all_prompts, all_negative_prompts = generate_prompts(
File "/storage/stable-diffusion/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/dynamic_prompting.py", line 73, in generate_prompts
all_prompts = prompt_generator.generate(prompt, num_prompts) or [""]
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/generators/randomprompt.py", line 46, in generate
return list(self._context.sample_prompts((template or ""), num_images))
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/samplers/base.py", line 64, in _get_sequence
yield rotate_and_join(sub_generators, separator=command.separator)
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/utils.py", line 43, in rotate_and_join
return separator.join(rotate_all(generators))
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/utils.py", line 35, in rotate_all
return [next(gen) for gen in generators]
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/utils.py", line 35, in
return [next(gen) for gen in generators]
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/samplers/random.py", line 98, in _get_wildcard
yield from context.sample_prompts(value, 1)
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/samplers/base.py", line 64, in _get_sequence
yield rotate_and_join(sub_generators, separator=command.separator)
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/utils.py", line 43, in rotate_and_join
return separator.join(rotate_all(generators))
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/utils.py", line 35, in rotate_all
return [next(gen) for gen in generators]
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/utils.py", line 35, in
return [next(gen) for gen in generators]
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/samplers/random.py", line 65, in _get_variant
selected_commands = self._get_variant_choices(
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/samplers/random.py", line 28, in _get_variant_choices
return choose_without_replacement(
File "/usr/local/lib/python3.9/dist-packages/dynamicprompts/utils.py", line 89, in choose_without_replacement
chosen = rand.choices(values, weights=weights, k=1)[0]
File "/usr/lib/python3.9/random.py", line 502, in choices
raise ValueError('Total of weights must be greater than zero')
ValueError: Total of weights must be greater than zero
colab, on paperspace.
Additional context
This may be a rudimentary question, but please answer.

What prompt are you using?

Closing 🧹


Fix broken link in permalink page

The .md extension was left on /docs/data-eleventy-supplied.md

Oh, thank you!


Document whether to recommend Apache, MIT or EUPL license

[ ] Compare licenses
[ ] Document in the software dev guidelines
[ ] Document in DMP

Ping @timrobertson100 @qgroom

If I remember correctly the commission review comment was mostly concerned about safeguarding about patenting.
From here :

if developers desire the assurance of patent protection, Apache 2.0 is the better choice. If the goal is for the resultant modified software to be highly accessible by future users without constraints, developers should choose MIT.


Downgrades Scalajs Badge

After our PR to include the 0.6.16 Scalajs Badge:
https://github.com/scala-js/scala-js-website/pull/362
has been rejected, we have to downgrade the supported scalajs version in our sbt configuration.

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   73.45%   73.45%
=======================================
  Files          37       37
  Lines         324      324
=======================================
  Hits          238      238
  Misses         86       86


fyne: 2.5.0 -> 2.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/fyne-io/fyne/releases.
meta.description for fyne is: Cross platform GUI toolkit in Go
meta.homepage for fyne is: https://fyne.io
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.5.1 in filename of file in /nix/store/ixm223gzywgby8k8fjv0w9qqlf1qws73-fyne-2.5.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

fyne

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ixm223gzywgby8k8fjv0w9qqlf1qws73-fyne-2.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A fyne https://github.com/r-ryantm/nixpkgs/archive/0fa527466e0829541b5b2b2496a7f99bc0e6821c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0fa527466e0829541b5b2b2496a7f99bc0e6821c#fyne

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ixm223gzywgby8k8fjv0w9qqlf1qws73-fyne-2.5.1
ls -la /nix/store/ixm223gzywgby8k8fjv0w9qqlf1qws73-fyne-2.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

fyne

Maintainer pings
cc @greg-hellings for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 337342 run on x86_64-linux 1

1 package built:

fyne


Edit form doesn't send request

@fzaninotto
Francois, could you please give an advice with this issue?
I worked with patient info editing. Edit form change information about patient ONLY in Store, but doesn't send request to the server path. Look:
https://drive.google.com/file/d/1fA6Hxn4G3nmfoFz6TurkqCbYTX37oMbI/view?usp=sharing
Requests to server are absent (after click on "Complete").
I understand it is, because process doesn't come to dataProvider (rows 259-261):
https://github.com/PulseTile/PulseTile-RA/blob/scotland/src/core/dataProviders/patientsProvider.js
This is my edit form:
https://github.com/PulseTile/PulseTile-RA/blob/scotland/src/core/pages/PatientsList/PatientEdit.js
This is my template of it:
https://github.com/PulseTile/PulseTile-RA/blob/scotland/src/core/common/ResourseTemplates/EditTemplate.js
Create form is done by the same scheme, but it works correctly - with requests to server path.
I assumed, that the reason in custom Toolbar, but default toolbar gives the same result.
Could you please help to find the reason?

Hi @fzaninotto could you take a look at this for us please?

In your EditToolbar, you clone the props twice, once for teh Toolbar, and once for the custom save button:
const EditToolbar = ({ changeViewType, ...props }) => {
    return (
        <Toolbar {...props} >
            <CancelButton redirectTo={changeViewType} />
            <CustomSaveButton {...props} />
        </Toolbar>
    );
};

Does it work better if you don't pass the props to the custom save button?
const EditToolbar = ({ changeViewType, ...props }) => {
    return (
        <Toolbar {...props} >
            <CancelButton redirectTo={changeViewType} />
-           <CustomSaveButton {...props} />
+           <CustomSaveButton />
        </Toolbar>
    );
};

Thanks, @fzaninotto .
I tried to do this, but result was the same. I removed custom toolbar generally, and get the same problem with default toolbar. Please, look at the video - I share my code and my browser:
https://drive.google.com/file/d/1S_x51bnd1aSfTBjFGkRqdoDQUwxLztLD/view?usp=sharing
When user clicks on "Save" - values are changed only in Store, but no actions in data provider.
I tried to do following in the file:
https://github.com/PulseTile/PulseTile-RA/blob/cf3caaa103a695403a9f9dbdfa9d9712f9065592/src/core/common/ResourseTemplates/ListTemplate.js#L229
render() {
      const { create, edit, resourceUrl, title, children, classes, history } = this.props;
      const EditBlock = edit;
      ....
      return (
          <Grid>
            {
              (!this.isCreatePage())
                            ?
                            <Route
                                path={this.getDetailsUrl()}
-                                render={({ match }) => <DetailsTemplate mode="show" {...this.props} id={match.params.id} />}
+                                render={({ match }) => <EditBlock {...this.props} id={match.params.id} />}
                            />
                            :
                            <Route
                                path={createUrl}
                                render={({ match }) => <CreateBlock {...this.props} id={match.params.id} />}
                            />
                    }
             </Grid>
          );
}

Result is the same, although CreateForm is united by the same way and works correctly:
https://drive.google.com/file/d/1X91e2oK4_3v1Ave9FqT0YEOUfNKO5hVc/view?usp=sharing
Can it will be some problem in Edit-component?

Sorry, the resolution of your 2 videos isn't good enough to be able to read anything.

CreateForm is united by the same way

I don't understand that part

Does it work better if, instead of using the <FormInputs /> component, you use its contents? It's the only difference that I see between your code and classic react-admin.

@fzaninotto
Francois, I updated the video:
https://drive.google.com/file/d/1flycmhcPU11_viJNtj9KWsZva8eUGzQg/view?usp=sharing
I want to show you, that data in store was changed, but request to server side wasn't send. I added console.log to dataProvider:
export default (type, resource, params) => {

    console.log('type', type);
    console.log('resource', resource);
    console.log('params', params);

    if (resource === `patients`) {
        return fakePatientsProvider(type, resource, params);
    }
    return dataProvider(type, resource, params);
};

You can see, that type UPDATE after click on Complete wasn't appeared.

CreateForm is united by the same way

I mean, that I use the same principle to do Create form: Common template with {children} as form.
And it works correctly:

add new data to store;
send request to the server.

https://drive.google.com/file/d/1UpxG_6NWM_EhiO4KA7OUWNlIaXWiBrRo/view?usp=sharing

Can you share what the redux toolbar displays when you submit the form? there should be a CRUD_UPDATE action dispatched. From there on, if your dataProvider doesn't catch it, it can only be because of a custom saga I think.

@fzaninotto
Francois, I share CRUD_UPDATE action:
https://drive.google.com/file/d/14LJ-SRek6_RSyKzWyXOSGg5aAGGjkw5q/view?usp=sharing

it can only be because of a custom saga I think.

Could you please clarify, which custom sagas do you mean?
Here the list of our custom sagas:
https://github.com/PulseTile/PulseTile-RA/tree/feature-data-provider/src/core/sagas
But never of them work with CRUD_UPDATE action.

I think it's because the update is optimistic. The fetch only starts after the notification hides. And I don't see the Notification Snackbar in your screencast. Did you forget to implement it?
cf https://github.com/marmelab/react-admin/issues/3049


feature:modify client api

Signed-off-by: yunfeiyangbuaa<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
in this pr,
I do these things:

make dfget request url int the format api/v1/*
modify config to request
and make client interface be the sub-interface of CommonAPIClient

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1114 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   47.21%   47.21%
=======================================
  Files         116      116
  Lines        7205     7205
=======================================
  Hits         3402     3402
  Misses       3535     3535
  Partials      268      268

Impacted Files
Coverage Δ

client/peer_create.go
0% <0%> (ø)
:arrow_up:

client/peer_list.go
0% <0%> (ø)
:arrow_up:

client/peer_delete.go
0% <0%> (ø)
:arrow_up:

client/peer_info.go
0% <0%> (ø)
:arrow_up:

client/task_create.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d714d98...33dba95. Read the comment docs.

LGTM.

LGTM.


Ensure that pycurl URL is string data type

@ticoann , Seangchan please review and merge. I found that this is required especially when we load something from external source, like JSON, and then pass it to pycurl. In this case url may be passed as unicode which cause a problem. It seems to be that naturally to make conversion here that pycurl code can handle both str and unicode url values.

Thanks Valentin,


Create one simple uncertainty rule

Create rule for lighting condition with the help of fuzzy rules and piecewise logic
Make assumptions if required and create a working rule.
Document the assumptions and reasons for the assumptions.

completed for lighting


Double up-vote/down-vote

It seems to only occur for the comments.  Although users can't perform up-vote or down-vote twice in a row, once they cast a vote for the first time, the second time forward counts as 2 up-vote/down-vote.

should be fixed.