Requests made by client with key=invalid argument

This command
python client_dev.py -O variants-search http://localhost:8000 --variantSetId ZGF0YXNldDE6MWtnLXBoYXNlMQ==

results in a request to
/variants/search?key=invalid

If the key=invalid part is not necessary (which I suspect it is not), we should not make requests with that argument.

This was done as a workaround for an obscure issue with authentication. The reasoning is buried in the discussion for #447 (search for "json document").

Moved https://github.com/ga4gh/ga4gh-client/issues/29


Error on type property

type: x in fields.yaml is throwing an error
"Matches multiple schemas when only one must validate."
Note:
It is not throwing the error inside nestedform, but I think that is because its not working in nestedform?

Fixed in v0.4.1.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Benoitsautierecellenza sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

done


ui: workspaces is broken when using emacsclient

What did you expect to happen?
using emacsclient, the following things:
Pressing SPC TAB TAB should display the workspace names in the minibuffer.
Pressing SPC o m should open mu4e
Pressing SPC TAB n should create a new workspace
Pressing SPC TAB  etc... should actually do stuff
What actually happened?
None of the SPC TAB functions work when in emacsclient.
Though using emacs (non daemon) works just fine.
Steps to reproduce:

enable ui:workspaces
start emacs daemon
connect via emacsclient -c
press SPC TAB TAB or anything related to ui:workspace

System information:

SYSTEM  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /bin/bash
        uname      Linux 5.8.11-1-MANJARO #1 SMP PREEMPT Wed Sep 23 14:35:40 UTC 2020 x86_64
        path       (~/.local/bin /usr/local/bin /usr/bin /bin /usr/local/sbin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /var/lib/snapd/snap/bin ~/tools/flutter/bin ~/.config/emacs/bin/ /usr/lib/emacs/27.1/x86_64-pc-linux-gnu/)
EMACS   dir        ~/.config/emacs/
        version    27.1
        build      Aug 28, 2020
        buildopts  --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-wide-int --with-modules --with-cairo --with-harfbuzz 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
        features   XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP
        traits     (daemon server-running envvar-file)
DOOM    dir        ~/.config/doom/
        version    2.0.9
        build      HEAD -> develop 29b12de8 2020-10-06 02:08:17 -0400
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo hydra indent-guides modeline ophints (popup +defaults) treemacs unicode vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold (format +onsave) multiple-cursors snippets :emacs dired electric undo vc :term vterm :checkers syntax :tools debugger (eval +overlay) lookup lsp (magit +forge) :lang (cc +lsp) (dart +lsp +flutter) emacs-lisp markdown (org +pretty +dragndrop) sh web (yaml +lsp) :email (mu4e +gmail) :config (default +bindings +smartparens))
        packages   ((dart-snippets :recipe (:host github :repo MYDavoodeh/dart-snippets :files (*.el (snippets snippets/*)))) (impatient-mode))
        unpin      (n/a)
        elpa       (n/a)

I suppose  #4025 is related.

As of 8afba81 this issue should be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!

Confirmed that this fixes the issue. Thanks!


Trouble using pts on node server

Hi, today I was working on some server-side TypeScript code that uses Group and Pt.
Unfortunately when I try to run my code, I get a ReferenceError saying window is not defined, which is understandable, since node doesn't have such things
Here's a simple example that throws that exception:
import { Group, Pt } from "pts";

let g = new Group();

Is there any way to use pts' classes on a node server, or am I out of luck?
Thanks!

Hi @stefa168 -- I'm not very familiar with node server, but I'm surprised that 'window' is referenced in the example you've given.
I wonder if something like this would work ...
import { Group, Pt, namespace } from "pts"

namespace( this );
let g = new Group();

Do you have a stack trace of your error message? If you have it, can you share it here? I'll try to find the bug.
Thanks!

Hi, thanks for the reply!
I tried adding your suggestion, however the error remains.
I'm sorry I didn't include a stacktrace; I totally forgot to include it:
ReferenceError: window is not defined
    at Object.<anonymous> (/sandbox/node_modules/pts/dist/index.js:15:4)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Module._compile (/sandbox/node_modules/source-map-support/source-map-support.js:547:25)
    at Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Object.nodeDevHook [as .js] (/sandbox/node_modules/ts-node-dev/lib/hook.js:63:13)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
[ERROR] 18:23:35 ReferenceError: window is not defined

Looks like it's related to this webpack setting:
https://webpack.js.org/configuration/output/#outputglobalobject
I'll experiment with the build and see if I can fix this -- hopefully in the next 1-2 weeks. Thanks for reporting this issue.
Happy Holidays!

Hi @stefa168 - This should be fixed v0.10. Please give it a try. We should be able to add support for node-canvas in future, but for now at least the static functions should work.

Hi @williamngan, I just tried version 0.10.1 with a project of mine and it works without any issue!
Thanks a lot, both for the fix and for pts!

(two years later :)
wondering if this lib does work with node canvas?

(two years later :) wondering if this lib does work with node canvas?

Basic node-canvas support is available. Take a look at:
https://github.com/williamngan/node-pts-canvas


Add rustdoc for core types.

As I read the source code, I'll keep adding rustdoc for public interfaces and comments for internal implementations. No functional changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

LGTM. Thank you  @weidagang

LGTM


[CO-325] API V1 Improvements - Part 2

Description

[x] The creation of mnemonic mustn't throw any runtime exception when provided with words outside of the BIP39 EN dictionnary
[x] The API should provide a way to force-check NTP status when querying node-info
[x] When running the new data-layer, The API should provide an endpoint to retrieve basic statistics on the UTxO distribution of a wallet
[x] The code should rely on cryptonite rather than  ed25519
[x] The documentation should be complete and correct

TODO

Changelog incoming

Linked issue
[CO-325]
Type of change

[x] 🐞 Bug fix (non-breaking change which fixes an issue)
[x] 🛠 New feature (non-breaking change which adds functionality)
[x] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[x] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[x] I have read the style guide document, and my code follows the code style of this project.
[x] If my code deals with exceptions, it follows the guidelines.
[x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

QA Steps

Screenshots (if available)

@edsko
May you review the parts related to the new wallet. I introduced them mostly during rebased, adding commits as necessary.
Rest was already reviewed during development, when creating PR from feature branches to this one but it's still good to have a quick look at it.

Merging without AppVeyor ... as usual.


where has the "Also in" part gone in the results screen?

a feature that is of particular use in the previous version is the "Also In" field in the summary results. It gives a quick and easy guide to see which term is being re-used in multiple ontologies and therefore well integrated into networks.
See the example screenshot for diabetes:

The NCIT term is not integrated with any other ontologies where as DOID term is also used in various other ontologies, and therefore more likely to be the one I look at first to assess whether its definition was exactly what I'm after.
Please can you add that feature into the v4 results list.

@serjoshua we already show this info on the ontology page so it’s in the Ontology object; just needs displaying in the results, should be a quick frontend fix.

Fixed by @serjoshua and deployed ! Let us know if you have any more issues.


test: Generate a "Müsli" with the WebAppGenerator

Try to implement a Müsli with the WebAppGenerator. Find problems and missing features / widgets of our WebAppGenerator this way

The final presentation contains how good we can implement the features of Müsli


Why is import/export still suggested when it doesn't work?

I had installed FreeOTP on a new phone a month ago. Had to do a reset now, exported keys, wanted to import after the reset. It doesn't work. Apparently many others face the same problem. I don't understand why the app still suggests to do a backup when it doesn't work? This is not a minor issue.

I met this problem too now in version 2.0.3 (Android).

I have encountered the same problem. But before this import was working 100%, I tested it before I started using this app. But now I tried to set up a new phone and after entering the password nothing happens, just a blank screen.

This is so weird. I seem to have started using FreeOTP when it was in version 2.0.2. I backed it up from time to time, and old backups created on version 2.0.2 could be restored on both version 2.0.2 and 2.0.3. But new backups created on version 2.0.3 could not be restored on all versions of the application.

So what do we do now? I was unaware of the issue, backed up, reset my phone, now I am unable to import, and have lost all my 2FA access. Is there a workaround?

I spent a whole evening trying to find how to do this but couldn't. I got lucky and had all my 2FA codes on my other phone, so I visited all the sites, generated new codes and switched to Aegis. If you've already lost them, you'll probably have to restore all your accounts.
But I will be happy to be wrong and if you find a way to restore data from this backup, please share it.

I had to restore all my accounts. Then switched to using FreeOTP+.

I was able to recover my accounts when moving to a new phone. The problem seems to be the export in version 2.0.3. I did a downgrade to version 2.0.2, exported my accounts and was able to import the backup with version 2.0.3 on the new device.
What you need:

ADB access on your old phone
The version 2.0.2 apk: https://f-droid.org/repo/org.fedorahosted.freeotp_43.apk

Copy the apk on the phone: adb push org.fedorahosted.freeotp_43.apk /data/local/tmp
On the old phone do a downgrade: adb shell pm install -r -d /data/local/tmp/org.fedorahosted.freeotp_43.apk
Export your accounts on the old phone.
Copy the backup file over to the new phone.
Import backup file on new phone with version 2.0.3

I think it should be possible to build an exporter, which takes a backup file, decrypts it and stores it as .cvs or similar, so that one can import it with another tool. The code for restoring tokens from the backup is at https://github.com/freeotp/freeotp-android/blob/master/mobile/src/main/java/org/fedorahosted/freeotp/TokenPersistence.java#L146

i have downgrade to 2.0.2。but it did not work!

@xinwu-yui What exactly did you try? Mind you, to follow my workaround you have to have a working app with all the TOTPs inside, that you downgrade.

i clone source code and debug。i think The reason for the error is that there was an encryption issue during export


Slack theme :)

I definitely liked the theme very much and would like to thank you for it.
I'm using it on VSCode, iTerm, Dev Tools and also on Slack :)
If someone is interested in using Slack, follow the instructions:

Go to User Menu > Preferences > Sidebar Theme
In the bottom of the window, look for a "customize your theme and share it with others" link
Copy and paste the values below

#2D2D2D,#44475A,#444444,#FFEEA6,#383838,#CCCCCC,#92D192,#F2777A,#2D2D2D,#CCCCCC

🤘

Nice! Mind making a PR to add this to the README so this issue can be closed?

PR: https://github.com/taniarascia/new-moon/pull/56 :)


Azure Site Recovery support for Dedicated Hosts

I can't find any details about ASR support for Dedicated Hosts. As in, if my source virtual machine in Azure is on a Dedicated Host, can it be replicated to a Dedicated Host in the target region?
As this page is a matrix of supported features, Dedicated Hosts should be added with some reference to whether it is supported or not.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 34d0f2df-de85-c6ab-eb01-f8e028b7f108
Version Independent ID: 5acb187c-f280-5c7d-14fc-7f07160cd50b
Content: Support matrix for Azure VM disaster recovery with Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/azure-to-azure-support-matrix.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@jeffwmiles Thanks for the comment. We will check on this and get back to you with an update soon.

@jeffwmiles Today ASR does not offer support for Dedicated Hosts. It is in our backlog.
Feel free ping if you have further questions in this matter or we are good to close this issue.

@jeffwmiles Thanks for raising the PR.
@rayne-wiselman For visibility.
Closing this issue as no action pending on us!


publishednodes.json: When OpcAuthenticationUsername is set but OpcAuthenticationPassword is erroneously not, a misleading error message appears

Describe the bug
When OpcAuthenticationUsername is set for an Endpoint in publishednodes.json but OpcAuthenticationPassword is erroneously not (there was a mistake in the key name on our side), a misleading error message appears:
User/passord token format is not supported
The message originates in class StackModelsEx methods ToUserIdentityToken and ToStackModel.
To Reproduce
Steps to reproduce the behavior:

Add a publishednodes.json with an endpoint pointing to a OpcServer requiring UsernamePasswort auth with a OpcAuthenticationUsername  entry, but no OpcAuthenticationPassword entry (we had a space extra)
Start OPC Publisher

    "EndpointUrl": "opc.tcp://xxxxx:xxxx/xxxxxxx",
    "UseSecurity": true,
    "OpcAuthenticationMode": "UsernamePassword",
    "OpcAuthenticationUsername": "xxxxx",
    "OpcAuthenticationPassword ": "password",

Expected behavior
An error message like "OpcAuthenticationPassword missing".
Additional context
Tested with OPC Publisher version <IP_ADDRESS>449

An empty password is legal in the UserNameIdentityToken structure in OPC UA.  In 2.9.0 we now allow an empty string as user name also as there are servers where the empty string is a valid user (like an API key scheme).


Item list removal configuration feature unable to override elytra in disable_chestplate

This change should retain the exact same functionality, but allows for datapacks to override the elytra in the disable_chestplate item list.
This differs from adding the elytra to disables_back_slot since it allows for the elytra to not disable backpacks, while additionally ensuring that overrides supersede any other modification.

I'm adding a separate list called elytra_items and it disables the Back Slot while any items in the list are equipped (similar to disable_chestplate), but doesn't stop items from being worn in the chestplate. This should make the elytra's more modular.
In a previous update I added the ability to use ! to remove items in a list so soon you'll be able to add !minecraft:elytra in elytra_items from your data pack to entirely remove elytra functionality soon.

Also I see your fork and I'm kinda embarrassed someone else had to go through that code lol

Your mod is actually the first time I have ever modded or even built something with gradle, so your code is much better than anything else I could make lol. This is why I didn't just make an addon that has your mod as a dependency because I am just so inexperienced and have no idea how mixins work. Though I did feel bad for the downloads I am potentially stealing because of this lack of knowledge, so I was hoping to just tell the friends I am making this modpack for to download your mod also.
Anyways with the elytra_items list, is this just the disables_back_slot list but for the elytra? I was a bit confused by that. This PR was actually made based off of me seeing that new ! configuration feature you added, but I saw that adding !minecraft:elytra to disable_chestplate did not work since it was getting added by default through DataResourcesMixin which bypasses that.

elytra_items basically does 4 things,

Allows to be worn in the chestplate & backslot
If it's worn on any armor, trinket, or curios slot then it disables the backslot
Allows flight for the player while the item is equipped
Also doesn't need any code overriding it so !elytra works

I needed a modular system to implement the Winged Backpack we talked about and I figured I'd put in a little extra work incase other mods added elytra items or I wanted to do more with elytras.
And don't worry about stealing downloads bc you were nice on the internet.

I see so that would be a great extension of the system that allows compatibility with other elytra type mods. Thank you for the explanation. I will make this as closed then if this will already be addressed in a future update.
Also just as a side note I replied to the issue thread with something about configuration and was unsure if you were able to see it, so I will paste it here just in case.

I can't be 100% about this since I have never worked with it before, but I believe it (cloth config API) can be for both (client-side and server-side). For example, the library Valyrien Skies uses it for its configurations, and it has different tabs in game (via mod menu) for customizing both its client-side and server-side configurations.


Continuously test against actual vgmdb.net html

Right now the unit tests check against saved snapshots of specific vgmdb.net pages. It should be possible to automatically update those snapshots and run the unit tests against them, to make sure that they still handle the current vgmdb.net html.
Additionally, it should crawl around vgmdb.net and look for any parse errors and crashes automatically.

scripts/check_data.py goes through every info item and verifies that it parses and validates against the schemata.


Set page title and metadata

This ticket follows the work done in #521. Here is what we have:

The app.component.ts listens to route changes. If the change has some SEO data attached, the title and SEO metadata are set. This code should ideally defined somewhere else and if needed, imported in app.component.ts with 1-2 lines.
One page in app-routing.module.ts includes page title and SEO data. This information for a given page should be moved to the page project.
The file user-profile.resolver.ts in the user profile project shows how to use the State Transfer API (#459 ).

The current code only includes static information. One improvement needed is for a given page to merge global app metadata + page static metadata + page dynamic data.
Specifications
Landing on a page should trigger the following actions

[x] Set the title of the page in the browser tab.
[x] The following <meta> tags must be set.

LinkedIn: <meta name="title" property="og:title" content="[Content title here]">
LinkedIn: <meta property="og:type" content="[Content type here]">
LinkedIn: <meta name="image" property="og:image" content="[Image URL here]">
LinkedIn: <meta name="description" property="og:description" content="[Content description here]">
LinkedIn: <meta name="author" content="[Author name here]">
LinkedIn: <meta name="publish_date" property="og:publish_date" content="2019-10-21T00:00:00-0600">
Twitter:       { name: 'twitter:card', content: 'summary_large_image' },
       { name: 'twitter:title', content: data.title },
       { name: 'twitter:description', content: data.description },
       { name: 'twitter:image', content: data.image },
       { name: 'twitter:domain', content: shareLink },
       { name: 'og:type', content: 'website' },
       { name: 'og:url', content: shareLink },
       { name: 'og:title', content: data.title },
       { name: 'og:description', content: data.description },
       { name: 'og:image', content: data.image },

[x] For each page of the registry, define the format and value of each <meta> tags.
[x] Add an example of how to use State Transfer API on at least on page.

Resources

Angular Title service
Angular Meta class
Angular MetaDefinition type
Dynamically Add Title and Meta Tags on Route Change in Angular ⭐
Better sharing on social media platforms with Angular Universal

The slides that will be presented on November 29 to Kevin, Jay, Bruce and Ljubo:

Do Robots Dream of the Challenge Registry?

For each page of the registry, define the format and value of each  tags.

See Challenge Registry Meta Tags (Google Sheet)


Add experimental follow solver

Overview
Follows the specification outlined in #5713. Uses behaviours from #5611 and #5159 to create a new solver that makes an object follow a tracked target like near menus in HoloLens 2. This required some minor bug fixes. This is only an experimental feature as of yet, so we can iron out bugs for a few weeks and then graduate the fully featured solver with docs.

Changes

Fixes: #5713.
Adds the Follow solver.

Follow solver keeps the reference object within certain user defined bounds.
Angular bounds can be specified which keep the object within a rectangular pyramid originating at the camera.

Users can disable these angular bounds and the object will be maintained at a fixed angle from the camera.

Distance bounds can be specified which keep the object within a min and max distance from the camera.
Provides a number of options to specify when and how to orient the reference object.
Added capability to face an additional user defined transform.

Adds inspector for the follow solver to make it easier to configure and understand.
Adds some tests for the follow solver for the basic behaviours of orientation, distance clamping and angular clamping.

This is only an experimental feature as of yet, so we can iron out bugs for a few weeks and then graduate the fully featured solver with docs.

Could you please create a task to track graduating this experimental feature into a full MRTK feature, since this is part of achieving parity with system HoloLens 2 behavior? Or were you planning to not resolve #5713 until the feature is graduated into a full feature?

descriptions are a lot clearer now to me!

/azp run

Could you please create a task to track graduating this experimental feature into a full MRTK feature

@julenka I thought I made a comment about this yesterday but I can't find it if I did. I created an issue (#6994) yesterday to track this. Let me know if there's anything else we can add to this issue.


fix: Revert capacity_reservation_specification default value from {} to null

Description

This fix in order to revert back the capacity_reservation_specification default value from {} to null which was causing issues for plans.
Motivation and Context

Fixing regression introduced in 4.1.3
Breaking Changes

None.
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects

[X] I have executed pre-commit run -a on my pull request

fixes #286.
I ran the complete example locally and I validated the fix.
ready for review.
@bryantbiggs

This issue has been resolved in version 4.1.4 :tada:


Type checking is broken when using oneOf

Describe the bug
The module system's type-checking is broken when using oneOf.
Steps To Reproduce
Save this as flake.nix:
{
  description = "nix-type-repro";
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs?ref=nixos-24.05";
  };
  outputs =
    { self
    , nixpkgs
    }:
    let
      system = "x86_64-linux";
      pkgs = import nixpkgs {
        inherit system;
      };
    in
    {
      packages.${system}.default = pkgs.nixosTest {
        name = "repro-test";
        nodes.machine = {
          imports = [
            ({ lib, config, ... }: {
              config.system.checks = [ pkgs.runCommand "repro" { } "echo ${builtins.toString config.example}" ];
              options.example = lib.mkOption {
                description = "repro issue";
                type = lib.types.oneOf
                  [
                    lib.types.int
                    (lib.types.submodule {
                      bar = lib.mkOption { };
                    })
                  ];
              };
            })
          ];
          example = {
            bar = "hi";
          };
        };
        testScript = ''
          machine.start()
          machine.wait_for_unit("multi-user.target")
        '';
      };
    };
}

Then run nix build.
This shows:
$ nix build
error:
       … while evaluating the attribute 'drvPath'

         at /nix/store/5z81la6av4j0ckp0w1949lxiwjyyykks-source/lib/customisation.nix:365:7:

          364|     in commonAttrs // {
          365|       drvPath = assert condition; drv.drvPath;
             |       ^
          366|       outPath = assert condition; drv.outPath;

       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: The option `nodes.machine.example.bar' does not exist. Definition values:
       - In `makeTest parameters': "hi"

       However there are no options defined in `nodes.machine.example'. Are you sure you've
       declared your options properly? This can happen if you e.g. declared your options in `types.submodule'
       under `config' rather than `options'.

Expected behavior
Succesful evaluation
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.44, NixOS, 24.05 (Uakari), 24.05.20240810.a781ff3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/61502m9h1jl40j7sxbcyjdm6qi1k7x97-source`

Add a :+1: reaction to issues you find important.

This repro is wrong. I will try again with a more accurate repro.

Here is the correct repro:
{
  description = "nix-type-repro";
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs?ref=nixos-24.05";
  };
  outputs =
    { self
    , nixpkgs
    }:
    let
      system = "x86_64-linux";
      pkgs = import nixpkgs {
        inherit system;
      };
    in
    {
      packages.${system}.default = pkgs.nixosTest {
        name = "repro-test";
        nodes.machine = {
          imports = [
            ({ lib, config, ... }: {
              config.system.checks = [ pkgs.runCommand "repro" { } "echo ${builtins.toString config.example}" ];
              options.example = lib.mkOption {
                description = "repro issue";
                type = lib.types.oneOf
                  [
                    (lib.types.submodule {
                      options = {
                        foo = lib.mkOption { };
                      };
                    })
                    (lib.types.submodule {
                      options = {
                        bar = lib.mkOption { };
                      };
                    })
                  ];
              };
            })
          ];
          example = {
            bar = "hi";
          };
        };
        testScript = ''
          machine.start()
          machine.wait_for_unit("multi-user.target")
        '';
      };
    };
}

Note that if we comment out the first element of the list passed to oneOf, we get a correct evaluation instead.

This is an issue with the submodules check function.
As the first check succeeds, the second never gets called.
A "deep checking" check function would probably blow up evaluation time for a barely used edgecase.
Feel free to overwrite the check for each member of the union, to allow for proper type selection.

config.system.checks = [ pkgs.runCommand "repro" { } "echo ${builtins.toString config.example}" ];

This line is broken to begin with. First of all, you need to add parens around your runCommand because otherwise, this is a list of the function and its arguments and that's not your intention here I assume.
Next, config.example's type cannot reliably be toString'd as it can be an attrset for which there is no string representation.
Fix those two issues first and then show us the exact error message again. Please also mark your non-reproducers clearly as such and perhaps hide them inside of a <details> block.

@Atemu The error message is clearly wrong either way:
The option `nodes.machine.example.bar' does not exist.

But it's defined right here:
              options.example = lib.mkOption {
                description = "repro issue";
                type = lib.types.oneOf
                  [
                    (lib.types.submodule {
                      options = {
                        foo = lib.mkOption { };
                      };
                    })
                    (lib.types.submodule {
                      options = {
                        bar = lib.mkOption { };
                      };
                    })
                  ];
              };

If what @NobbZ says is right then this is a WONTFIX
My current workaround is to remove the type with a comment like this:
      # Turned off type-checking until this type-checking bug is fixed:
      # https://github.com/NixOS/nixpkgs/issues/337108
      # type = import ../dnscheck/options.nix { inherit lib; };

I don't have any capacity for fixing this, but I find it important to report the bug either way.


500 server error on pages

It seems there is a bug in django-cms==3.2.3 that if the user saves before the plugin retrieves the data a 500 server error is displayed on that page and the only way to fix it is remove it manually from the db any solution for this ?

Sorry just realised i have mentioned this before any idea of when you can fix it pull, request has been waiting for a while :(


[BUG]

Describe the bug
Please first see #3104 as a refrence. Now consider when a force disconnect happens in code (when running), e.g. connected wifi access point is turned off. in this case SOCKETS_Shutdown fails, but SOCKETS_Close does it works correctly. as mentioned in 3104 here, "This matches the shutdown behavior documented here, and is therefore presumably correct. Close actually cleans up the resource, ...".
System information

Hardware board: esp32

Expected behavior
SecureSocketsTransport_Disconnect should return succeessfully if shutdown fails but close succeeds. in fact it should just check for close return value since shutdown  return value is not important.
Solution
i think:
1- SecureSocketsTransport_Disconnect should return closeStatus
2- if 1 is correct, lines below in the function are useless:
       if( ( shutdownStatus != TRANSPORT_SOCKET_STATUS_SUCCESS ) || ( closeStatus != TRANSPORT_SOCKET_STATUS_SUCCESS ) )         {             shutdownStatus = TRANSPORT_SOCKET_STATUS_INTERNAL_ERROR;         }
3- maybe you want to change line below to something else, so it won't be misleading (as user may think the function has failed, although it hasn't)
           LogError( ( "Failed to close connection: SOCKETS_Shutdown call failed. %d", transportSocketStatus ) );
Some notes
@lundinc2 , since you have provided the fix for 3104, you may want to check this
@dipen-1337lab, @jsstrandberg, you may want to check this too.
Regards

@dipen-1337lab

Namaskar @maa1370,

I think you should not set returnStatus to TRANSPORT_SOCKET_STATUS_INTERNAL_ERROR since you do not revert it back to TRANSPORT_SOCKET_STATUS_SUCCESS if SOCKETS_Shutdown() fails.

Yes. Actually, there's no point in setting the returnStatus when SOCKETS_Shutdown() fails because the SOCKETS_Close() always gets called, unconditionally (with reference to my modified code block shared earlier). The success/ failure of SOCKETS_Close() is what really matters. I shall remove that line of code in my application code. Thank you!

I think a problem can only happen if return value of SecureSocketsTransport_Disconnect is used somewhere in code logic to do something special in case disconnect was not successful, and for these cases the return value should be corrected.

The documentation in the transport_secure_sockets.h reads as below for the TransportSocketStatus enum.
TRANSPORT_SOCKET_STATUS_INTERNAL_ERROR,      /**< A call to a system API resulted in an internal error. */

As per my understanding, the TransportSocketStatus enum is provided as an abstraction/ wrapper to the code developer instead of using the actual system API return values, which is a good programming practise. In our context, the TRANSPORT_SOCKET_STATUS_INTERNAL_ERROR return value corresponds to the failure of Shutdown and/ or Close Socket-related APIs.
As long as Close always follows Shutdown ignoring the success/ failure of the latter, I do not feel the need for any code change. Also, as you have rightly mentioned, the User application ought to handle the appropriate return values to avoid an undesired behaviour/ firmware crash.
With that, I would appreciate if Team AFR can provide their say on this discussion.

About LogError if SOCKETS_Shutdown() fails, i think it is somehow misleading as described in first post, and should be at least changed to LogWarn.

Point taken. Thank you, again. Will correct this in my application code as well.
Thanks | Regards,
Dipen

@dipen-1337lab thanks for response.
sorry, you are right, corrected my previous comment (... revert it back to TRANSPORT_SOCKET_STATUS_SUCCESS if SOCKETS_Close succeeds.)

Thanks. It should be correct after #3468 is merged.
feel free to close the issue when you want.


Fix for #22516 - mobs can no longer cause clumsy mobs to get hurt on tables

About the PR

Added checks to ClimbSystem and BonkSystem to prevent handsless mobs from pushing other mobs onto tables, and to prevent mobs from causing clumsy mobs to bonk off of tables.

Why / Balance

Bug ticket described in #22516 - allows players to cause damage to certain mobs in an inconsistent way.

Technical details

Added checks to ClimbSystem and BonkSystem to prevent handsless mobs from pushing other mobs onto tables, and to prevent mobs from causing clumsy mobs to bonk off of tables; simple component checks and target != user checks.

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A
Changelog

:cl:

fix: Mice and other small creatures can no longer hurt Pun Pun or the Clown by smashing them into tables.

so i cant table the clown anymore?


feat(ssr): add ability to cleanup after request

close #9463

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The point of this "feature" is to be able to do something to the app to mark it as "invalid" so that vue-router has a way to detect and cleanup objects it might have left hanging around in memory. This feature might be able to be used for other reasons, but it is probably truly a fix. Also, a change would need to be approved in vue-router as well for the memory leak there to even go away (see https://github.com/vuejs/vue-router/issues/2606), and that might get fixed by other means, so this might not be worth doing anything with if that doesn't also get approved.
Because we're in control of when the app is created in SSR it didn't seem like there was any other sensible option but to give us control of when to clean it up, though maybe something can be done based on runInNewContext. Also, maybe a more explicit API would be better, e.g. some way to mark the app as "served", $isServer && $isServed.
Note I'm submitting this knowing that there is a good chance that this will be tossed, so feel free to do so if this is not what is wanted.

Is it going to be merged ?

PR made in vue-router illustrating what would need to be done there as well: https://github.com/vuejs/vue-router/pull/2867
Again I am skeptical as to whether or not this is the right approach, but I am skeptical of everything I do so take that for what it's worth.

Note I made another PR made in vue-router illustrating a way to fix the leak without requiring this PR: https://github.com/vuejs/vue-router/pull/2875


util/promlint: consider moving to github.com/prometheus/common

Proposal
I originally added promlint for use in promtool check metrics. It is very useful for that purpose, however, it would also be nice to allow the package to be easily vendored and used in other applications for unit tests and such.
Because this main Prometheus repository is fairly large and also contains a great deal of unrelated code, I propose moving util/promlint to github.com/prometheus/common/promlint or similar. This way, library code lives with a library instead of an entire application, and is much easier to vendor.
At that point, we can vendor in the updated copy of common and switch the import statements used within promtool.

Talked with @SuperQ on IRC and it appears I was wrong about needing to vendor the entire repo. dep at least appears to pick out the package by itself if I dep ensure -add github.com/prometheus/prometheus/util/promlint.
I do still think it'd be reasonable to move this to common, though.

It's only used in one of our repos, so I see no need to move it to common. Common is for stuff shared across our repos.

If github.com/prometheus/common  isn't the proper place, then how about github.com/prometheus/client_golang?
Maybe we can move it to client_golang/prometheus/testutil.
Involve @brancz here.

@brian-brazil @mdlayher Thoughts on moving promlint into http://github.com/prometheus/client_golang like @RainbowMango suggested?
Or maybe even http://github.com/prometheus/promlint ? Moving it out of github.com/prometheus/prometheus would be extremely helpful

As indicated in https://github.com/kubernetes/kubernetes/pull/86477 you'd probably be best using it is a library. As-is the code appropriately located from a Prometheus standpoint, as it is only used in promtool.

We are currently doing a bug scrub.
@beorn is considering to move this to client_golang. @brancz would you be interested in doing that?

To be precise: client_golang/prometheus/testutil could make sense as a location.

In particular, client_golang would not be a good place for a stand-alone linter binary, but promtool can stay where it is and just import client_golang/prometheus/testutil to get the code.

I'm interested in this, can I join or take this?
@RichiH @beorn7 @brancz

Go for it @RainbowMango :)

I'll brace for impact then. (o:

Working on it. Thanks.

@beorn7 Can you assign this issue to me? It can help me find this issue quickly in the future. :)

Sure, done.


Refactored setup of google api clients

Description

Adds out-of-the-box support for google cli authentication auto-discovery (get_application_default)
Reuses more code between gcs and bigquery implementations

Motivation and Context
Works with the current version of the cli tools and api client (google-api-python-client==1.6.1), which was previously not working (http and oauth could not both be provided as was the default/required behavior by the previous code).
##Tests
I ran tasks both for gcs (cloud storage) uploads and big query integration and both work after this patch. I don't see how it would break anything for people who use manual configuration of the authentication process, but it would of course be nice if someone who has a GCS/BigQuery pipeline running tested this out as well :)

Oh, are you back at Spotify now? :)
There's also luigi tests for gcs which I recall are disabled on Travis.

Hi Arash! :-)
Not back at Spotify but back in Luigi land at least part-time as we're setting up some simple log processing at EdQu using BigQuery - so I can motivate spending more some time on luigi again. It's cool to see all the new stuff that's has been contributed.
Ah, I'll have a look and run the gcs tests locally to verify that it still works.

I ran the tests gcs and bigquery tests with success (pre-patch they would not run using the current version of google-api-python-client (1.6.2)).
Noteworthy is that the tests won't run using python3 as there seem to be some issues there unrelated to this patch - guessing that code has never been tested on py3.
Any idea what is causing the travis fail for this PR? It just looks like jibberish to me :-)

Yea the hadoop failures are jibberish. But the flake8 issue you certainly should be able to address. Here's you log, https://travis-ci.org/spotify/luigi/jobs/198885463. There's some docs in CONTRIBUTING.md too nowadays. :)

Ah, should have seen that, thanks! :)

I wonder if many other use the gcp integration actively, considering the code prior to this patch doesn't work with the current google-api-python-client version... (so if they use it they probably use an old version and wouldn't upgrade luigi either ;) )

@freider, I'm pretty sure there's others using it. Even Spotify is contributing to it still and I've seen various parties commenting to PRs, that said, nobody have commented for  a while so I'll just merge this. :)


build on windows

Great work on this!
I was looking for this exact same thing to replace libspotify in my Kodi addon and only need the raw audio pipe. If I may ask, how did you manage to build this on windows ?
Got it working on my mac within a few minutes but windows keeps complaining about mdns and portaudio.

Oh, true, I still manually disable (comment out) mdns in librespot's Cargo.toml. That's why I point to the neighboring folder in spotty's Cargo.toml in that case. I still haven't figured out how I can conditionally enable/disable includes in Cargo.toml.

clone librespot from my repository to a folder next to the spotty clone
checkout the "spotty" branch in that librespot clone
modify Cargo.toml in the spotty clone folder to use that clone rather then directly from GitHub:
[dependencies.librespot]
#git = "https://github.com/michaelherger/librespot.git"
#branch = "change-notification"
path = "../librespot"
default-features = false
run Cargo from the spotty folder

portaudio should have been taken care off by the default-features = false statement in Cargo.toml.

FWIW: I just pushed a change to my librespot repository which automatically deals with the mdns issue on Windows. You should be able to compile without any manual change.

Wow, fantastic. Thanks for your help. Will try later today once finished work.
Do you have any plans of integrating this into a new Spotify app for the LMS server ?
I just recently discovered LMS and must say I really like it.
Looking into the Spotify implementation I discovered that the helper application is also still using lib spotify, which will be abandoned by Spotify this year, so same issue as I'm having with my Kodi application for Spotify.
Very recent, Spotify has updated their webapi with spotify connect possibilities so you'll be able to control connect devices. I discovered that every player of Spotify, even the web player, is now controlled by the connect protocol so that seems to be the new direction they're heading.
That got me thinking to use that same approach for the LMS plugin. The helper application which is responsible for playback streaming to devices and representing them as connect devices to spotify.
I'm actually currently looking in to the Shairport implementation in LMS to see if that same approach can be used to get spotify connect going. In that case the spotify helper broadcasts all LMS players as connect devices and is also available to react to spotify playback requests directly. As I have no experience with perl this is not going very fast but I'm making some progress.

http://forums.slimdevices.com/showthread.php?t=107418 - it doesn't offer the Spotify Connect feature, but only replaces the player backend for LMS. Very much like my previous Spotify Protocol Handler plugin.

Oh wow, you even went that far of creating exactly that :-)
Thanks, I will give it a test shot.
BTW: Just have built the updated source and now it compiles perfectly fine. Playback however isn't working when piping to VLC but that could also be my own stupidity. Will test with your version first.
Out of curiosity:

Do you have any idea if this will work with multiple spotify accounts ? So I can have multiple spotty streams throughout the house ?

What about my idea to also use the connect feature to present each player as a connect device ? A bit the same as how sharper currently works where your squeeze players show up as airplay targets. Os is that perhaps a bridge too far ?

Anyways, thanks a lot for this.

You can have multiple streams by launching multiple copies of spotty. As it's not running as a daemon, but rather a helper to pull a track and pipe it elsewhere, it only lives for the time it takes to get a track. Yes, there's some overhead to this, but it works very well on a Pi3 (< 10% CPU load while playing one stream and transcoding to Flac through LMS)
Connect in LMS comes with a bunch of UX issues. It might work fine if you use one of the playback engines. But in piping mode not so much. I think there's a bug in librespot, too, which causes skipping to the next track as soon as a track has been fully downloaded - which can be within seconds. See https://github.com/plietar/librespot/issues/175.
VLC might need some parameters telling it what bitrate etc. I needed to do the same for mp3/flac transcoding: --channels=2 --sample-rate=44100 --bps=16 --endian=little --sign=signed. Don't know VLC enough to tell you how you would define them for it. But this might give you a start.

this is absolutely fantastic, the skip after a few seconds was exactly what I was experiencing in because I was thinking it would get a buffer from spotify streaming the audio realtime but instead it got the whole track, really didn't think about that!
Thanks for your work on this. I'll see if I can replace my lib spotify implementation in Kodi spotify addon with your spotty one.
Not that I use that plugin a lot myself now that I discovered LMS and squeezelite ;-)
I will give your spotty LMS plugin a try later today.
So basically what you're saying is that I can run multiple instances of the plugin, just give them a different ID. But they will all hijack the same spotify:// protocol.

just to confirm: working perfectly fine now with VLC !

Testing the LMS plugin without any luck. Playback stops immediately. LMS installed on Synology NAS, latest 7.9.0 version. Do I need to switch to dev 7.9.1 for this ?
Please say so if you want me to move these questions to the forums as these aren't related to my original question anymore.

Installed a fresh copy of LMS 7.9.1 and still no dice. Looks like the spotty binary is crashing badly.
I do not see any logging in the server log at all from spotty plugin.
I do however see this message in my system log:
[39959.964415] traps: spotty[14424] trap invalid opcode ip:7f6e5e691e61 sp:7f6e5cdf7880 error:0 in spotty[7f6e5e3d1000+46f000]
I have the feeling this has something to do with the fact I'm running this on a Synology. It is a x86 model however.

OK, swapped the i686 binary with the x86_64 version and now it's playing ;-)
So, looks like the issue is with the x86_64 version of the spotty binary
I'll try to build it from source in a VM to see if I can spot the issue

Could you please continue LMS specifics in that thread I linked? And if you do so, please include information about what LMS reports on Settings/Information about the platform, perl version, and path for helper apps. Thanks!

What did you have to do to get it working with VLC?

Will do, no problem.
For VLC, I used this: spotty.exe with params | vlc.exe - --demux=rawaud --rawaud-channels 2 --rawaud-samplerate 44100

Hi Michael, it appears that librespot is no longer working, can you confirm ?
https://github.com/plietar/librespot/issues/190

A scary development :-(

Yes, indeed. Well it appears that it can be fixed with a simple change but the question is if Spotify is now blocking intentionally

BTW: This is the resolution for the issue with the x64 binary on some intel NAS platforms I told you about on the forums:
https://github.com/marcelveldt/librespot/commit/f792da18a4345a17065e51e9e6a69c7d136d3722
Just use a rust-crypto version with the patch already supplied to build librespot and you're al set.


[Feature Request] onChangeTheme method

Hello, thank you for this useful package.
Is it possible to add an event method that fire when the windows theme is changed:

dark mode activated/turn off
color theme changed

Anyway, thanks again! 👍

I added the setBrightness method, which can toggle between light/dark mode.
https://user-images.githubusercontent.com/3889523/156914825-7c1e7ed3-7bb1-42a5-84fc-45c1a89d1fd5.mp4

Thanks for the super quick response and the nice toggle function (i will use it) 👍
But I meant that when the user goes to windows settings and manually change the system theme mode or theme color,
then the function onChangeTheme will fire up so my app will know that is time to use: await SystemTheme.accentInstance.load();
Sorry if I was not clear enough :sweat:

The flutter engine supports monitoring theme changes, you just need to call setBrightness there.
https://stackoverflow.com/a/62607827

https://user-images.githubusercontent.com/3889523/156916556-bd1fe9b8-0f00-40c8-8a68-a431394d411c.mp4

Supported, will be released in the next version

Thank you! I didn't know that.
Theme Mode change detection, worked only after I added what you quote:

Currently in windows this must be added https://github.com/flutter/flutter/pull/88520/files

Very cool!
The only extra thing that I don't know if it's covered by Flutter for windows,
is the change detection of theme color (not the theme mode),
Do you know anything about that?

Unfortunately, it cannot detect custom themes

I guess it's early days for flutter-windows...
Thanks again for your help (https://github.com/leanflutter/window_manager/commit/6eb721cacf4d7c5b6c700afac6279ff7043644b9) and knowledge share (https://github.com/leanflutter/window_manager/issues/86#issuecomment-1059920641) 👍

By the way, you can use system_theme to get the system accent color.

Already using it, works well 👍


add an extra 'metadata' field for network_tap to be stored in redis

vent/core/network_tap/ncontrol/rest/create.py needs to have an optional parameter in the payload for metadata which will be a JSON object.
the metadata field needs to then be stored as hash in redis where the key is the id parameter of the payload

@cglewis I'd like to help with this. How do I begin? Thanks.

@rosemilk excellent!
So, first I'd take a look at vent/core/network_tap/ncontrol/rest/create.py and look at the other payload params that are coming in to the POST function, such as id and iters (there's like 5).  This issue needs an additional one added named metadata that expects a JSON object.  Since there is already a connection made to Redis in the function, all you need to do is set a new hash using that Redis connection where the key to the hash is id param also coming in to that same function and value is the key/value pairs of the json object of metadata.
For testing, you'll want to have docker available.  Run the redis container:
docker run --name redis -d redis redis-server --appendonly yes

Then build and run the ncontrol container.  Go into the ncontrol directory then do:
docker build -t ncontrol .
docker run -d -p 8080:8080 --link redis:redis ncontrol

Once that's up and running, make a POST request to http://localhost:8080/create with the payload that's expected.
Feel free to reach out with more questions or if you get stuck.

@rosemilk this has become critical path for another project, and didn't see any activity on it from you, so taking care of this one.


Fix depends-on annotation in registry.yaml

Describe the bug
The depends-on annotation on line #23 in solutions/sandbox-gke/artifact-registry/registry.yaml contains an invalid field.
The API version should not be included.
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/sandbox-gke/artifact-registry/registry.yaml#L23
config.kubernetes.io/depends-on: serviceusage.cnrm.cloud.google.com/v1beta1/namespaces/config-control/Service/my-demo-guardrails-controller-services-artifactregistry # kpt-set: serviceusage.cnrm.cloud.google.com/v1beta1/namespaces/${project-namespace}/Service/${project-id}-services-artifactregistry

To Reproduce
Deploy code as is to reproduce the error.
Expected behavior
Successful deployment of the resource.
Additional context
v1beta1 should be removed twice on this line:
config.kubernetes.io/depends-on: serviceusage.cnrm.cloud.google.com/v1beta1/namespaces/config-control/Service/my-demo-guardrails-controller-services-artifactregistry # kpt-set: serviceusage.cnrm.cloud.google.com/v1beta1/namespaces/${project-namespace}/Service/${project-id}-services-artifactregistry

Addressed in PR #332


[Azure.Core] Regenerate models using Alpha Azure.Core package

Get alpha package from Azure.Core
Change references to use new package
Update writer with read only property code
Regenerate serializer/deserializer for all models

@nisha-bhatia :  Is this still needed or can we close this out?


A game object can only be in one layer. The layer needs to be in the range [0...31]

Having issues with your Controller. I've set up a new project and imported the required package, and copied your scripts over from your demo, and this gets spammed in my console.
A game object can only be in one layer. The layer needs to be in the range [0...31]
UnityEngine.GameObject:set_layer(Int32)
SuperCharacterController:PushIgnoredColliders() (at Assets/SuperCharacterController/Core/SuperCharacterController.cs:465)
SuperCharacterController:ProbeGround(Int32) (at Assets/SuperCharacterController/Core/SuperCharacterController.cs:225)
SuperCharacterController:SingleUpdate() (at Assets/SuperCharacterController/Core/SuperCharacterController.cs:194)
SuperCharacterController:Update() (at Assets/SuperCharacterController/Core/SuperCharacterController.cs:158)

The character controller also falls through meshes I've imported or has jittery collision movment with them.
What my player controller looks like.

What the mesh looks like

and this is what happens. (After falling through it)

I'm pretty sure you didn't add the "TempCast"-layer. The SuperCharacterController.cs expects you to have a layer called "TempCast" to be able to ignore colliders.
private const string TemporaryLayer = "TempCast";
I'm not sure why this is hard-coded into the script, but adding it should solve your issue.

Oh I didn't see that. That fixed that issue. Player still falls through the platform after jumping though. Might be my collision though?

Hmm. I've recreated your settings in my project without issue, which means it has to be some project setting, or some irregularity with your mesh. Would you be able to post the project here if it's not too large? Alternatively, a screenshot of the mesh might help. Try adding a box primitive with a mesh collider with the same settings to see if there's a problem. Or, push the pause button before pushing play in Unity (to let everything fully load; this avoids having a large deltaTime spike at the start. For production it's best to use a fixed timestep, however).
@Epicuri0us the reason it's hardcoded is that you cannot modify the layer manager at runtime (or the input manager...for reasons unknown). It would be much nicer to be able to just dynamically create a layer if it was missing, but I haven't yet found a better solution (I think I'll push an update that disables the controller if the layer is missing and prints out a nicer error message).


config: change hostname var name and add links tests

Proposal:

Move delete, files, etc. links to an issue... Otherwise TODOs will get lost in translation.

closes https://github.com/inveniosoftware/cookiecutter-invenio-rdm/issues/111

Coverage decreased (-0.2%) to 94.007% when pulling 721d40edee719d47e038079c85a226a9d78d20d7 on ppanero:hostname into 861985c41d5b5a61b208bfdf1d4bff1982419975 on inveniosoftware:master.


Fix compilation when __ARM_FEATURE_FP16_SCALAR_ARITHMETIC

Signed-off-by: Matthew Bentham<EMAIL_ADDRESS>Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@mbaret

@giuseros is that better?

Hi @MatthewARM , thanks for addressing my comments! It looks perfect now!

CI seems to have crashed/failed for some unrelated reason (ping @tqchen ). Could you try pushing again with some trivial update to retrigger it?

seems was due to timeout, we might need to look into the integration tests being added recently, in particular the ones related to tvmc

What should I do? Wait, for now?

The CI outrage problem have been resolved, sorry @MatthewARM for the inconvenience

Awesome thanks, no worries.

Thanks @MatthewARM, this is now merged.


Tide chart may break soon due to proxy issue

The tide chart uses https://cors-anywhere.herokuapp.com/ to proxy the request.  I implemented it that way, because I was having CORS issues with the NOAA API.
According to https://github.com/Rob--W/cors-anywhere/issues/301, it shouldn't be working.  But it seems ok for now.  I expect their service could go down at any moment.

I spent a long time working on trying to get the NOAA data to work properly, and failed.  After wasting far too much time, I gave up and deployed my own copy of cors anywhere on heroku.  It was actually really easy, and the free tier should be plenty generous.


Build failure on Windows platform

[JW-Modules] Building plugin on platform win...In file included from lib/oscpack/osc/OscOutboundPacketStream.h:43:0,
                 from lib/oscpack/osc/OscOutboundPacketStream.cpp:37:
lib/oscpack/osc/OscException.h:57:25: warning: ‘virtual const char* osc::Exception::what() const’ can be marked override [-Wsuggest-override]
     virtual const char* what() const throw() { return what_; }
                         ^~~~
In file included from lib/oscpack/osc/OscReceivedElements.h:45:0,
                 from lib/oscpack/osc/OscReceivedElements.cpp:37:
lib/oscpack/osc/OscException.h:57:25: warning: ‘virtual const char* osc::Exception::what() const’ can be marked override [-Wsuggest-override]
     virtual const char* what() const throw() { return what_; }
                         ^~~~
lib/oscpack/osc/OscReceivedElements.cpp: In function ‘const char* osc::FindStr4End(const char*, const char*)’:
lib/oscpack/osc/OscReceivedElements.cpp:67:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if( p >= end )
     ^~
lib/oscpack/osc/OscReceivedElements.cpp:70:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  if( p[0] == '\0' )    // special case for SuperCollider integer address pattern
  ^~
In file included from lib/oscpack/osc/OscReceivedElements.h:45:0,
                 from lib/oscpack/osc/OscPrintReceivedElements.h:42,
                 from lib/oscpack/osc/OscPrintReceivedElements.cpp:37:
lib/oscpack/osc/OscException.h:57:25: warning: ‘virtual const char* osc::Exception::what() const’ can be marked override [-Wsuggest-override]
     virtual const char* what() const throw() { return what_; }
                         ^~~~
lib/oscpack/ip/posix/UdpSocket.cpp:43:10: fatal error: netdb.h: No such file or directory
 #include <netdb.h>
          ^~~~~~~~~
compilation terminated.
make: *** [build/lib/oscpack/ip/posix/UdpSocket.cpp.o] Error 1

fixed


ng test not obeying single run flag

Versions
Angular CLI: 6.0.0
Node: 10.0.0
OS: win32 x64
Angular: 6.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.0
@angular-devkit/build-angular     0.6.0
@angular-devkit/build-optimizer   0.6.0
@angular-devkit/core              0.6.0
@angular-devkit/schematics        0.6.0
@angular/cdk                      6.0.1
@angular/material                 6.0.1
@ngtools/webpack                  6.0.0
@schematics/angular               0.6.0
@schematics/update                0.6.0
rxjs                              6.1.0
typescript                        2.7.2
webpack                           4.6.0

Repro steps

Upgrade Angular CLI to V6 (global/local)
Upgrade Angular to V6
Upgrade other dependencies
Ensure karma.conf.js has singleRun: false in it
Run ng t OR run ng t --single-run=false

Observed behavior
If ng t is run, tests will run successfully but browser window will close on finish (despite karma.conf.js having singleRun: false inside it)
If ng t --single-run=false is run, it errors: Unknown option: '--singleRun' Note that running  ng t --no-single-run creates the same error.
Desired behavior
I would like the browser window to remain open, as it always did, pre-upgrade

Same issue here as well, any fix?

Same here, any solutions? It's a bit urgent.

This works:
ng test --watch
Cheers!

Same here

@Tataraovoleti Sure, ng test --watch --code-coverage gives me watch-mode and code-coverage. It's located in './coverage'

Can you please provide me your karma.conf.js configuration

It's the default:
// Karma configuration file, see link for more information
// https://karma-runner.github.io/1.0/config/configuration-file.html

module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
      require('karma-jasmine'),
      require('karma-chrome-launcher'),
      require('karma-jasmine-html-reporter'),
      require('karma-coverage-istanbul-reporter'),
      require('@angular-devkit/build-angular/plugins/karma')
    ],
    client:{
      clearContext: false // leave Jasmine Spec Runner output visible in browser
    },
    coverageIstanbulReporter: {
      dir: require('path').join(__dirname, 'coverage'), reports: [ 'html', 'lcovonly' ],
      fixWebpackSourcePaths: true
    },
    angularCli: {
      environment: 'dev'
    },
    reporters: ['progress', 'kjhtml'],
    port: 9876,
    colors: true,
    logLevel: config.LOG_INFO,
    autoWatch: true,
    browsers: ['Chrome'],
    singleRun: false
  });
};

Hi @JohannesHoppe
Thank you , this configuration is working for me.

I created a new project with Angular CLI 6.0, I have not modified the Karma configuration file.
I confirm that when the test ends google closes
ng test --watch is a workaround, we wait for fix, thks

is ng test --single-run is equivalent to ng test  now in angular6?
I observed same behavior.

I'm experiencing same issue after upgrading. ng test --watch works like ng test did before upgrade. Is this the expected behavior?

@jwa107 This should be corrected in 6.0.1.  The singleRun karma option is only changed if the watch option is explicitly used. The single run command line flag no longer exists in v6.
If issues still presents with the latest version of the CLI, please open a new issue detailing the problem.

--no-watch should also work (more elegant).

I switch ng test --single-run=false to ng test --watch=false and it is works good.

Since we cannot specify overrides, like "ng test --watch=false" if there are "multiple targets", is there another way to keep the browser window(s) open? Is it possible to append the next project's spec text to the browser window, or to log each project's spec text (like it was)?

ng test --watch=false doesn't work with Angular CLI 7.0.1, it still watches and can't be killed unless you spam ctrl + c about 15 times quickly..

Same result in<EMAIL_ADDRESS>and actually it looks like the test runs twice


add k8s 1.31 to support matrix

add k8s 1.31 to the supported version for containerd.
NOTES:

containerd 1.7.20+ is added since it is tested as part of release-branch-jobs here
the corresponding version in 1.6 series is also used for the LTS version

Any reason we should keep the "2.0 (wip)" anywhere in here? Or just update when we release 2.0 soon?

Or just update when we release 2.0 soon

I think we can update it when 2.0 is released


Support for a rotary encoder

I'm curious what it would take to add a rotary encoder to the Plaid?
Some related links:

https://www.reddit.com/r/MechanicalKeyboards/comments/brnl0q/a_companion_for_my_planck/
https://www.reddit.com/r/olkb/comments/9jzbg1/help_with_rotary_encoder_code/

Hi, I wouldn't like to add support rotary encoder on pcb.
But you can use i2c pins.


fix path to media files; let nginx serve them

MEDIA_ROOT = '/media/'  is non-optimal because is it the usual place for linux mounts, so move it to the project folder. The nginx config part is same as for static.

Thanks for the PR. I will look into it ASAP.


Bump to upstream version 2.2.0.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Permission denied when running as non-root

Describe the bug
I'm getting the following error when running the Ambassador image as a non-root user:
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador_diag/diagd.py", line 554, in run
    self.load_config_fs(arg)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador_diag/diagd.py", line 581, in load_config_fs
    self._load_ir(aconf, fetcher, scc.null_reader, snapshot)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador_diag/diagd.py", line 627, in _load_ir
    if not self.validate_envoy_config(config=ads_config):
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador_diag/diagd.py", line 665, in validate_envoy_config
    with open(app.ads_temp_path, "w") as output:
PermissionError: [Errno 13] Permission denied: '/tmp/envoy-test.json'
AMBASSADOR: pinging diagd (8)...
AMBASSADOR: diagd running
AMBASSADOR: waiting
PIDS: 92:ambex 93:diagd

To Reproduce
Since I can't pull the Ambassador image from its official Quay Repository due to security policies on the Kubernetes cluster I want to deploy, I've created first a container locally:
docker run -it -p 8080:80 --name=ambassador quay.io/datawire/ambassador:0.51.2 --demo
After that I've deployed the container into the Docker registry from where my Kubernetes cluster has the permissions to pull images.
Then, I started the pods with the following Deployment:
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: ambassador
spec:
  replicas: 3
  template:
    metadata:
      annotations:
        sidecar.istio.io/inject: "false"
        "consul.hashicorp.com/connect-inject": "false"
      labels:
        service: ambassador
    spec:
      serviceAccountName: ambassador
      imagePullSecrets:
      - name: <my_secret>
      containers:
      - name: ambassador
        image: <my_registry>/ambassador:latest
        resources:
          limits:
            cpu: 1
            memory: 400Mi
          requests:
            cpu: 200m
            memory: 100Mi
        env:
        - name: AMBASSADOR_CONFIG_BASE_DIR
          value: /tmp/ambassador-config
        - name: AMBASSADOR_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        ports:
        - name: http
          containerPort: 80
        - name: https
          containerPort: 443
        - name: admin
          containerPort: 8877
        livenessProbe:
          httpGet:
            path: /ambassador/v0/check_alive
            port: 8877
          initialDelaySeconds: 30
          periodSeconds: 3
        readinessProbe:
          httpGet:
            path: /ambassador/v0/check_ready
            port: 8877
          initialDelaySeconds: 30
          periodSeconds: 3
      restartPolicy: Always
      securityContext:
        runAsUser: 8888

However, the above described error is produced. Is it a bug or am I not configuring the pods in the right way?
Versions (please complete the following information):

Ambassador: [e.g. 0.51.2]
Kubernetes environment [bare metal]

Does the error go away if you run as root?

0.51.2 is pretty old now; can you please check 0.70.1? I think it might do what you need.


Dev shell nix

Fix #4
Adds a nix flake defining a development shell.
To use it on a nix enabled computer, simply run nix-shell (or nix develop if you enabled flakes) and you will have a sane development environment.
This is a draft PR, I'd like people to try it
Let's discuss the implementation !

LGTM !


Use custom label attribute instead of data-vv-as

I'm using vee-validate with Vuetify like this:
            <v-text-field               v-model="something"               label="Some title"               data-vv-as="Some title"               v-validate="'required|max:10'"               :error-messages="errors.collect('something')"               name="something"             />
Label is used as prop for input placeholder/title. I have to duplicate this to data-vv-as to get errors with correct text. With many inputs this is just waste of code and space.
Is there any way to use custom input prop as fallback for data-vv-as ("label" in my case)?
I cannot find it in config, but it could be like this:
Vue.use(VeeValidate, {    titleAttr: 'label' );

I don't think I will be adding an option for that.
I suggest that you use the ValidationProvider component or the withValidation Higher order component with Vuetify. The directive will be deprecated in v3 due to many issues with its design.
The docs are here
and this is a live example for using it with Vuetify, I think you will find it much more pleasant. And You could pass whatever to the name prop for the provider as the label prop. You can even wrap them together in a new component which is documented in the refactoring section.


Feature/26 add project subcommand

Coverage increased (+1.0%) to 47.062% when pulling 84f4549895e9e2c3f78e2eaef4575449837289df on feature/26-add-project-subcommand into 07750c0e37b56f13e84836796e59497874d67b51 on develop.


[unhandledRejection] Nuxt instance is unavailable! whenever updating nuxt.config.ts

Environment

Operating System: Darwin
Node Version:     v20.18.0
Nuxt Version:     3.14.1592
CLI Version:      3.15.0
Nitro Version:    2.10.4
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      default
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
I just created a new Nuxt project, and whenever I update nuxt.config.ts, the error ERROR [unhandledRejection] Nuxt instance is unavailable! appears in my Visual Studio Code terminal.
Describe the bug
ℹ Vite client warmed up in 0ms
ℹ nuxt.config.ts updated. Restarting Nuxt...
ERROR  [unhandledRejection] Nuxt instance is unavailable!
at useNuxt (node_modules/@nuxt/kit/dist/index.mjs:36:11)
at normalizeTemplate (node_modules/@nuxt/kit/dist/index.mjs:2988:18)
at node_modules/nuxt/dist/index.mjs:5439:47
at Array.map ()
at generateApp (node_modules/nuxt/dist/index.mjs:5439:33)
at async _applyPromised (node_modules/perfect-debounce/dist/index.mjs:54:10)
Additional context
No response
Logs

The HMR in the 3.14.1592 version of Nuxt is also very slow.

The HMR in the 3.14.1592 version of Nuxt is also very slow. I had to revert to version 3.14.0.

Thanks for this suggestion :)
I have just reverted to 3.14.0 from 3.15.0 and it has solved this error.
For me, saved changes to tailwind.config.ts or nuxt.config.ts triggered a server restart with an error
ERROR  [unhandledRejection] Nuxt instance is unavailable!

I have the same problem

Unfortunately, I still encounter this error when making changes to nuxt.config.ts. Here's the output:
ℹ nuxt.config.ts updated. Restarting Nuxt...                                                                                05:10:20

 ERROR  [unhandledRejection] Nuxt instance is unavailable!                                                                                05:10:20

  at useNuxt (node_modules/@nuxt/kit/dist/index.mjs:36:11)
  at normalizeTemplate (node_modules/@nuxt/kit/dist/index.mjs:2988:18)
  at node_modules/nuxt/dist/index.mjs:5439:47
  at Array.map (<anonymous>)
  at generateApp (node_modules/nuxt/dist/index.mjs:5439:33)
  at async _applyPromised (node_modules/perfect-debounce/dist/index.mjs:54:10)

 ERROR  [unhandledRejection] Nuxt instance is unavailable!                                                                                05:10:20

  at useNuxt (node_modules/@nuxt/kit/dist/index.mjs:36:11)
  at normalizeTemplate (node_modules/@nuxt/kit/dist/index.mjs:2988:18)
  at node_modules/nuxt/dist/index.mjs:5439:47
  at Array.map (<anonymous>)
  at generateApp (node_modules/nuxt/dist/index.mjs:5439:33)
  at async _applyPromised (node_modules/perfect-debounce/dist/index.mjs:54:10)

ℹ Re-optimizing dependencies because vite config has changed                                                                                05:10:21
✔ Vite client built in 15ms                                                                                05:10:21
✔ Vite server built in 64ms                                                                                05:10:21
✔ Nuxt Nitro server built in 203 ms                                                                                nitro 05:10:21
ℹ Vite client warmed up in 0ms                                                                                05:10:21
ℹ Vite server warmed up in 214ms

I've varied between Nuxt v13.3 and v13.4, and even below that. I've changed the Node.js version using nvm. None of this seems to work on a clean installation.


DnD plugin: fully support custom event objects

While trying to use the drag and drop plugin with ImmutableJS
events I was getting a number of errors which were caused by
my custom accessors getting some close but not quite JS objects
rather than my glorious ImmutableJS Maps /s
Eventually I narrowed it down to the update function in
EventContainerWrapper - which in essence is creating a new
version of the event object in state with modified start & end
times.
Unfortunately it was simply doing this by treating the event as
a regular JS object with start & end attributes.  This is then
consumed by the TimeGridEvent component, which tries to use the
accessors again and then we're in trouble...
The fix involves creating customisable updateEvent function which
follows the same path as the accessors -- not 100% sure it's the
best, but it works for my purposes!
Also it could be that I'm just abusing the small amount of power
I was given with the accessors, but it felt a little odd to run into
an issue after having it work so well elsewhere!

Heya!
This fixes an issue I encountered -- but is also my first pull request on GH -- so if I'm missing anything please let me know.
I actually haven't tested that this works with a regular repo (but had a dream that maybe some of the automation testing would catch anything too buggy?) but it does work with mine.
Thought it'd be fun to save someone the hassle should they run into a similar issue.  Happy to add in any relevant docs / or tests if you can think of 'em.
Cheers & thanks for the maintaining this project.
Al


support for updating an existing subscription

Option to update an existing subscription, as per: http://apidocs.mailchimp.com/api/1.3/listsubscribe.func.php

This project will be maintained at https://github.com/piquadrat/django-mailchimp from now on, if this issue still exists, please report it again at the new location. Thank you


Add ability to recurse a directory tree but limit comparison of content to that in each subfolder only

I have a use case whereby I have thousands of folders in a directory tree, with each folder containing one or more images.  It would be great to be able to run difPy pointed at the root folder of the tree in question and have it systematically process each folder in the tree, processing each folder having regard only to the image files in that folder.

Hi @audiomuze,
Thanks for your input! I'm not sure I fully understand your request correctly. DifPy has the option to search among two different folders by setting directory_A and directory_B. If you set these two to root directories, it will search through all their sub directories for matching images. I hope this helps! Otherwise, If I misunderstood, please feel free to clarify and provide an example so that I can look into your request.
Thank you and all the best,
Elise

Hi @elisemercury
Now I re-read what I'd written I can see it's clear as mud.  To clarify, let's assume there are many hundreds of subfolders in a directory tree /home/x/collection/
collection is the "root" folder and each sub-folder contains a variety of files including the following:

It'd be very useful to be able to run difPy from the collection folder, having it traverse the entire tree and wherever it encounters

in the same folder it compares them and deletes the lower quality file.

Hi @audiomuze,
Thanks for clarifying! This is indeed supported by difPy. As mentioned above, difPy supports recursive search within the given directory and this setting is activated by default (see parameter recursive in the difPy Usage Documentation). Therefore, by using:
search = dif("../home/x/collection/")

difPy will search through collection and return all the duplicates it finds. The search is performed within the union of all files in collection and including all files found among sub folders. In your case, it would find folder.jpg and xfolder.jpg as well, if these two image pais are indeed duplicates.
I hope this clarifies!
All the best,
Elise

Hi @elisemercury,
I'm afraid I'm failing to communicate effectively.  What you've described is what I'd understood from the outset and is a perfectly valid behaviour when wanting to find all duplicates that exist in a population regardless of location within the directory tree.
What I'm suggesting is to add the the ability to recurse the directory tree as is presently the case, but to restrict the duplicate identification to one subfolder at a time i.e. return the duplicates (if any) in each subfolder considered in isolation rather than collection as a whole.
This could be done by for example adding a -i /  -infolder switch option to difPy which then modifies its behaviour as follows:

In the example above I'd like to process the entire directory tree, but when looking for duplicates consider only the contents in each discrete subfolder, not the entire tree.  So for each test the population is the contents of the subfolder being processed, not the tree.
So because difPy is invoked in ./ it processes as follows:

subfolder1 looking for duplicates in subfolder1
subfoldera looking for duplicates in subfoldera
subfolderb looking for duplicates in subfolderb,
subfolder2 looking for duplicates in subfolder2
subfolderx looking for duplicates in subfolderx

At no point does it look across ./ and all its subfolders looking for duplicates.  If on the other hand the -i switch is omitted it defaults to its current behaviour of comparing all contents across the entire directory tree.

Hi again @audiomuze,
Please excuse the confusion! Now I got your point - thanks for clarifying again! :-)
Unfortunately no, difPy does not support that natively. What you could do instead: run difPy within in a for loop on the folders you want to inspect and append the search.result for each process into a new collection - for instance:
new_result = {}
dir_list = [subfolder1, subfoldera, subfolderb, subfolder2, subfolderx]

for dir in dir_list:
    search = dif(dir)
    new_result[dir] = search.result

You will end up with a new collection that will hold the search results for each subfolder:
{ subfolder1 : {'1234' : ...,
                '5678' : ... },
  subfoldera : {'4321' : ...,
                '8765' : ... },
 ... }

Just tested it myself and it works like a charm :-) Hope this helps!
All the best,
Elise

Thanks @elisemercury, I'll code a script, but going down this path means I lose the benefits and ease of using difPy's CLI to get the job done..

Could you not just incorporate this feature into the command line interface, make an option that says -U true, false where -U specifies you want the searched directories to be treated as a union or not. then you can implement the code in the python where it either collects directories specified by -r into a single unified search path, or it lists them into an array and then parses them one by one using a for loop. This would be very helpful because I want to mass search directories on my computer that I know do not contain duplicates between folders but almost certainly contain duplicates within each folder, local to that folder only.

Not having this option basically renders dif useless to any users wanting to trawl an entire hard drive or directory tree but limit matching only to what is in every folder.  I'm not sure I understand the resistance to enhancing dif to cater to both needs.  Anyone with for e.g. a large music collection and various iterations of cover art would find this useful, but are unlikely to want want the entire directory tree being processed, because some albums come in different releases and would leginimately have the same cover art.

Hi @audiomuze,
Thanks for your feedback. I will be looking into this in the near future and see whether this is a feasible feature. Let me come back to you soon.
Thanks and best,
Elise

Hi @elisemercury, have you has a chance to assess feasibility of implementing this capability?

Hi @audiomuze,
Please excuse the delay in coming back to you on this request! This feature will be added in the next difPy version which will be released shortly.
Thank you and best,
Elise

Hi @audiomuze,
I'm happy to let you know thathis feature has been implemented in difPy v4. Check out the in_folder parameter. Thanks for your suggestion!
All the best,
Elise


Turn down xz compression level

Creating tarballs seems to be taking ridiculous amounts of time on the dist bots
(upwards of 10-20 minutes) and we're not that small anyway so let's shave off
some build time by turning down the compression level a bit.

r? @Mark-Simulacrum

@bors r+
I do think we should possibly think about ways to reduce the artifacts we ship so that we don't need to pay this compression cost quite as much, but for now this seems fine.

(no bors here :( )


Level XP RNG has too low a floor

Level XP RNG has too low a floor
The rng amount of xp given for a message is between 0-25, when it should be 15-25. possible reasons.
Notes

Potential Fixes:

Re-roll the rng value if it's less than 15 (the fix)

Error
no error

if the rng number falls below 0 it now gets set to 20, right between the range. easiest fair fix.


Helper pegs to 100% CPU running Repository::GetCommitCount

Today when I opened Atom (same result with both Atom Beta 1.3.0-beta3 and Atom 1.2.1), I end up with an Atom Helper process that goes to 100% CPU after a few seconds and remains there indefinitely. I am on OS X 10.10.5.
Here's a screenshot from profiling the process in Activity Monitor:

I have tried running in safe mode (atom --safe), but that does not seem to change anything.
I have used Atom for many months without this issue, and it only appeared suddenly today. What can I do to help diagnose / fix this? Thanks!

+1
same here with Atom beta 1.3.0-beta6 and latest 1.2.4; though not sure if the culprit is the above function call! also took samples directly after launch, but no clue
love my atom, need it back!! unusable as of today
Sample of Atom Beta Helper.txt
Sample of Atom Helper.txt

may be related to https://github.com/atom/atom/issues/8908

@jryans is there anything notable about the git repository you're trying to open? Is it huge, or nested, or anything like that?

@thedaniel The repo is gecko-dev, the source for Firefox, so it does have a fairly high commit count. There are no submodules, nested repos, or other "exotic" repo structures. Just lots of commits.
In my local repo, I get the following rough commit count:
$ git rev-list HEAD --count
451676

This issue no longer seems to happen for me. I am unsure if a later build of Atom resolved it or if something else changed. Anyway, I'll reopen / refile if it comes back.

This is now happening again for me with Atom 1.4.0-beta3.

@jryans Just to provide more context for this, GetCommitCount is used to calculate how ahead/behind the branch is, relative to the upstream branch. Does that shed any more light on why it's so expensive in that repository?

Right, I noticed this after digging into the source a bit more. I made a custom build where I just commented out the call to GetCommitCount, and the perf problem does go away, so at least I know that's the right area to be checking.
It doesn't seem like GetCommitCount should be slow in this repo, as I am only ever a few commits off of upstream, like you'd expect in the usual case.
@joshaber Do you know how I can attach a debugger to GetCommitCount? I saw that it's run as a task in a separate helper process, so Atom's built-in DevTools don't seem to be able to debug it.

It doesn't seem like GetCommitCount should be slow in this repo, as I am only ever a few commits off of upstream, like you'd expect in the usual case.

Yeah, that's interesting. The implementation calculates the merge base, which I don't think is actually necessary. If you're feeling adventurous, you could try replacing the entire implementation of Repository::getAheadBehindCount with a call to git_graph_ahead_behind which should be more efficient.

@joshaber Do you know how I can attach a debugger to GetCommitCount? I saw that it's run as a task in a separate helper process, so Atom's built-in DevTools don't seem to be able to debug it.

Sadly I don't. @atom/core Anyone know?

We've setup debugging on child processes... though in theory it should be possible. We are working on web worker support which is baked into the dev tools. For now, maybe you could hack it into the foreground temporarily to investigate it?

@joshaber I'm trying to test my changes to the git-utils module, but I can't seem to get a working Atom build. Here's what I did:

Clone git-utils
Make changes to git-utils
In git-utils dir, run npm link
In atom dir, run npm link git-utils
Rebuild atom with script/build --install-dir /Users/jryans/Applications/AtomDebug.app --verbose

This causes Atom to fail on startup with:
Error: Cannot find module '../build/Release/git.node'

What the expected workflow for testing module changes in Atom?

To be clear, I do have a working Atom build without my local changes.

Ah yeah, so git-utils is a bit funny. After apm linking you'll need to apm install in git-utils again.

@jryans Do you still have this issue? It started happening to me today and it seems the Repository::getUpstreamBranch computes the upstream branch wrong when your remote is configured to name the local tracking branch differently from the remote one. E.g., I have this in my config:
[remote "origin"]
        url = hg::https://hg.mozilla.org/mozilla-central
        fetch = +refs/heads/branches/default/tip:refs/remotes/origin/master

This gives my local tracking branch a nice origin/master name instead of origin/branches/default/tip. Follow the getUpstreamBranch algorithm and see where it leads you. In my case, it was a stale reference to some old commit, not the current upstream.

I believe the issue is still correct, though I'll need to check again... At the moment, I use a custom build of Atom where I just ripped out these problem bits since I don't use them at all. Of course, that means I don't get any updates either... :cry:
Scanning my git config, it looks I don't have the same situation as you. I am using the "long" names that match the remote branch. However the Atom code might still be doing something odd here. It's a good thing to look into!

I am no longer using Atom, so I'm not sure of the current status. I guess I'll close this.


Update http4s-circe, http4s-dsl, ... to 0.23.18

Updates

org.http4s:http4s-circe
org.http4s:http4s-dsl
org.http4s:http4s-ember-server

from 0.23.16 to 0.23.17.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Codecov Report
Base: 88.63% // Head: 88.63% // No change to project coverage :thumbsup:

Coverage data is based on head (2a686de) compared to base (36bfcb2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   88.63%   88.63%
=======================================
  Files          93       93
  Lines        3001     3001
  Branches      170      170
=======================================
  Hits         2660     2660
  Misses        341      341

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


When displaying processing parameters, include some type of break information

During Qiita meeting, we saw processing parameters that said "False Diversity Metric" which stemmed from not using some type of break between the key / value pairs in the processing parameters.

Fixed in dev


Using the demo provided doesn't work on window11, please help me

media_kit: ^0.0.7+1
media_kit_video: ^0.0.9
media_kit_native_event_loop: ^1.0.3
media_kit_libs_windows_video: ^1.0.2
media_kit_libs_windows_audio: ^1.0.3
import 'package:flutter/material.dart';
import 'package:media_kit/media_kit.dart';                        /// Provides [Player], [Media], [Playlist] etc.
import 'package:media_kit_video/media_kit_video.dart';            /// Provides [VideoController] & [Video] etc.
void main() {
WidgetsFlutterBinding.ensureInitialized();
MediaKit.ensureInitialized();
runApp(
const MaterialApp(
home: MyScreen(),
),
);
}
class MyScreen extends StatefulWidget {
const MyScreen({Key? key}) : super(key: key);
@override
State createState() => MyScreenState();
}
class MyScreenState extends State {
/// Create a [Player].
final Player player = Player();
/// Store reference to the [VideoController].
VideoController? controller;
@override
void initState() {
super.initState();
Future.microtask(() async {
/// Create a [VideoController] to show video output of the [Player].
/// Play any media source.
await player.add(Media('https://spbtest.oss-ap-southeast-3.aliyuncs.com/temp/video/16216306831720448/u/20230512/29212855827955712/47486196154658816.mp4'));
controller = await VideoController.create(player);
  // player.play();
  //
  setState(() {});
});
player.streams.playlist.listen((e) => print("playlist:$e"));
player.streams.playing.listen((e) => print("playing:$e"));
player.streams.completed.listen((e) => print("completed:$e"));
player.streams.position.listen((e) => print("position:$e"));
player.streams.duration.listen((e) => print("duration:$e"));
player.streams.volume.listen((e) => print("volume:$e"));
player.streams.rate.listen((e) => print("rate:$e"));
player.streams.pitch.listen((e) => print("pitch:$e"));
player.streams.buffering.listen((e) => print("buffering:$e"));

}
@override
void dispose() {
Future.microtask(() async {
/// Release allocated resources back to the system.
await controller?.dispose();
await player.dispose();
});
super.dispose();
}
@override
Widget build(BuildContext context) {
/// Use [Video] widget to display the output.
return Container(
width: 800,
height: 800,
child: Column(
children: [
ElevatedButton(
onPressed: () async {
await player.play();
setState(() {});
},
child: Text("Play")),
Video(
/// Pass the [controller].
width: 600,
height: 600,
controller: controller,
),
],
),
);
}
}

Please format correctly the code you provide with 'Add code' from the toolbar.
What is the error you got if any?
Have you tried the media_kit_test example from that same directory in media_kit github source code project?

I never understood what's "doesn't work", are you even a developer? Is it:

Not compiling
Throwing exception
Crashing on runtime

??? what?
Secondly, run our test application first, there's a direct URL. If that runs, it's your & your code's own fault.


Make tag-release help promote a prerelease to a normal release

skips commits
merge into master
delete upstream branch

Notes from @dcneiner in slack...

For promoting the component project:

Rebase master of that project into your branch
Drop any commits that bumped the version/changelog
Merge into master with --no-ff so you get a merge commit
Tag release that project as normal

For promoting the lightning branch:

Rebase lightning master into your branch
Update package.json to point to the final version of your component
Squash the lightning package.json change commits down to a single commit that says something like "Bumped [project name] to [version] to pull in [change]"
Force push that to the same upstream branch that went through QA
Open your PR to develop for Ops (edited)

This should now be a feature as of v5.1.0


3D TestCube appears white

Hi,
It is caused by a recent change into the github source code.
The 3D TestCube appears white, and FixedMaterial are whiter too.
The change appeared between the 6th and the 10th of january.
Tested with win64 compiled versions.

Also there is something weird with those sides not facing the light source

related to #1255 I guess

No, it seems an issue with some parameter in the cube material being set to a value out of range when it's created, the problem is that the material in the test cube can't be edited, only replaced by a new one.

I've found how to reproduce the issue with a custom material:

create a test cube
add a new fixed material to the cube
change the specular color to white (255,255,255)

... and also how to fix the issue in the default or custom material, the problem is that the specular exponent in an integer value, if it's changed to 40.0, the cube is rendered with a smooth transition from darkness to light

( @rraallvv : what tool do you use to make these animated gif video ???? )

@UsernameIsAReservedWord Here is how with ffmpeg and imagemagic, on a mac both can be installed with homebrew

( @rraallvv : thanks ! )

This issue affects me too. I experience it with godot-git-1.0._stable_544ce2a-1-x86_64.pkg.tar.xz on Arch Linux.

have just fixed it yesterday on github
On Wed, Jan 21, 2015 at 12:35 PM, monkz<EMAIL_ADDRESS>wrote:

This issue affects me too. I experience it with
godot-git-1.0._stable_544ce2a-1-x86_64.pkg.tar.xz on Arch Linux.
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1185#issuecomment-70858610.

This can be closed, it works fine now, thanks @reduz


Does not seem to work for me

Hello, seems to be a very cool project.
But does not work for me at all neither in Ubuntu nor in Windows 11.
I mean the program is launched but wallpaper not changed.
PS : I'm in multiple monitors

It's probably because of non-default monitors position. You can check the current position of each monitor using xrandr on Linux.

I found out this was a bug though. Fixed in latest release