[timeseries] Response Size Limit, Metrics and Series Limit

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (77ea25a).
Report is 1362 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (77ea25a). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (77ea25a)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14501       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Create an event and update workload status when failing to schedule a…

… workload

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #91
Special notes for your reviewer:

Thanks @uroy-personal, we discussed a different approach to this. @ArangoGutierrez will likely followup after https://github.com/kubernetes-sigs/kueue/pull/125 is merged.
The idea is that the event (and status update) will be emitted from the same place; nominate should return more information as discussed in https://github.com/kubernetes-sigs/kueue/pull/125#discussion_r830546251

Thanks @uroy-personal, we discussed a different approach to this. @ArangoGutierrez will likely followup after #125 is merged.
The idea is that the event (and status update) will be emitted from the same place; nominate should return more information as discussed in #125 (comment)

Thank you. Looking forward to the merged code :) .. Have a nice day ..

https://github.com/kubernetes-sigs/kueue/pull/125 is now merged

#125 is now merged

do you want to add the Events as well? uroy-personal perhaps you can look at the PR that @ArangoGutierrez will raise and learn from it how we approach such changes?

#125 is now merged

do you want to add the Events as well? uroy-personal perhaps you can look at the PR that @ArangoGutierrez will raise and learn from it how we approach such changes?

Yes sure. I will follow the PR to be raised by @ArangoGutierrez.. Thank you..


When multiple photos are added to a single FB post, only one image is in Attic

If you create a single facebook post with multiple images attached, Attic will only show one of the photos in your gallery. @aboodman

@kalman
This happens because the photo indexer falls back to publish date to index by if taken date is not known. Then the deduplication in the UI takes effect and deduplicates a batch of photos that were published together.
I think we still want the photo ordering to be as it is right now, we just want the deduplication to only take into account taken date.

Oh this was fixed a long time ago. Whoopsie.


DSPDC-979 Add optional results bucket to processing-project module.

Plan output is:
  # module.monster_infrastructure.module.clinvar.google_storage_bucket.results_storage[0] will be created
  + resource "google_storage_bucket" "results_storage" {
      + bucket_policy_only = (known after apply)
      + force_destroy      = false
      + id                 = (known after apply)
      + location           = "US"
      + name               = "broad-dsp-monster-clingen-dev-ingest-results"
      + project            = (known after apply)
      + self_link          = (known after apply)
      + storage_class      = "STANDARD"
      + url                = (known after apply)
    }

  #<EMAIL_ADDRESS>will be created
  + resource "google_storage_bucket_iam_member" "results_external_readers" {
      + bucket = "broad-dsp-monster-clingen-dev-ingest-results"
      + etag   = (known after apply)
      + id     = (known after apply)
      + member =<EMAIL_ADDRESS>      + role   = "roles/storage.objectViewer"
    }

  # module.monster_infrastructure.module.clinvar.google_storage_bucket_iam_member.results_writer[0] will be created
  + resource "google_storage_bucket_iam_member" "results_writer" {
      + bucket = "broad-dsp-monster-clingen-dev-ingest-results"
      + etag   = (known after apply)
      + id     = (known after apply)
      + member =<EMAIL_ADDRESS>      + role   = "roles/storage.admin"
    }

  #<EMAIL_ADDRESS>will be destroyed
  - resource "google_storage_bucket_iam_member" "staging_iam_reader" {
      - bucket = "broad-dsp-monster-clingen-dev-staging-storage" -> null
      - etag   = "CA0=" -> null
      - id     =<EMAIL_ADDRESS>-> null
      - member =<EMAIL_ADDRESS>-> null
      - role   = "roles/storage.objectViewer" -> null
    }

Plan: 3 to add, 0 to change, 1 to destroy.

Idk if they've been interacting with the bucket at all right now, but if they have been, we ought to let them know that we're changing which bucket they access.

I don't think they've been using it since they pulled the initial set of test outputs over.


HostPath volume type: FileOrCreate creates a directory not a file in RKE provisioned clusters

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Provision a Rancher v2.5.5 instance and a custom cluster
Deploy the following Pod:

apiVersion: v1
kind: Pod
metadata:
  name: host-path-test
  namespace: default
spec:
  containers:
  - image: nginx
    name: nginx
    volumeMounts:
    - mountPath: /foo.txt
      name: hostpath
  volumes:
  - hostPath:
      path: /tmp/foo.txt
      type: FileOrCreate
    name: hostpath

Result:
Exec into the Pod and observe that /foo.txt is a directory, not a file. Same can be confirmed of /tmp/foo.txt on the node running the pod.
Other details that may be helpful:
Behaviour not seen on a k3s or rke2 cluster, so this appears to be related to containerized kubelet. Upstream issue reported in kubernetes/kubernetes at https://github.com/kubernetes/kubernetes/issues/84663
Environment information

Rancher v2.5.5

SURE-2712

Confirmed it's still happening on RKE1 1.24.8 (but not RKE2 1.24.8).

This is STILL an issue 2023 Nov. with RKE1 1.24.8


Allow formatting from stdin with flutter format

The flutter SDK doesn't expose the dartfmt command and users are expected to run flutter format. In the Dart vim plugin we format files by piping them through stdin instead of formatting in place. Can we add an option, maybe by specifying the input file as --, to accept input from stdin and write the formatted result to stdout?
See https://github.com/dart-lang/dart-vim-plugin/issues/80#issuecomment-480427574

Hi. I'm interested in doing this as my first contribution to an open source project.
I have cloned a fork of the flutter repo, where should I go from here?

@tfinlay thanks for your interest. However, since dartfmt is now exposed by Flutter next to the flutter CLI as dart format, I believe this issue may be obsolete. I'll close this, but @natebosch can re-open if I'm mistaken.

Yes, the dart format command looks like it should work. Thanks!


Multiple GPUs

Rasa version: 2.3.0
Python version: 3.8.5
Operating system (windows, osx, ...): Ubuntu 18.04
Issue:

Hi,

We want to train our model on multiple GPUs, so we changed the code and added a few lines to use the distribution strategy. The model was using GPUs in parallel until the training of the DIETClassifier started and the following error occurred:

"ValueError: SyncOnReadVariable does not support `assign_add` in cross-replica context when aggregation is set to `tf.VariableAggregation.SUM`".

We found out that this error was solved in Tensorflow 2.4. However, according to the available Rasa dependencies, it is possible to use the Tensorflow version up to 2.3. Do you have any suggestions on how to use multiple GPUs in another way? Do you already support it?

Error (including full traceback):
ValueError: SyncOnReadVariable does not support `assign_add` in cross-replica context when aggregation is set to `tf.VariableAggregation.SUM`

Command or request that led to error:
rasa train nlu

Thanks for the issue, @joejuzl will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

did u found any solution ?? or is there any approach to use multi Gpu context with rasa.
kindly help with required examples.
Thanks

Hi @grungert,
For more information regarding tuning performance see: https://rasa.com/docs/rasa/tuning-your-model#configuring-tensorflow.
If you need more information please start a thread on the forum: https://forum.rasa.com/
W.r.t to the Rasa tensorflow version, a bug fix in which has not been backported to 2.4 is preventing us from upgrading.
See https://github.com/RasaHQ/rasa/issues/7619 for more details.

UPDATE!
So far, we have tested several combinations of Tensorflow and Rasa versions and concluded that Rasa is still not available for multi-GPU training. More precisely, these versions are tested:

Rasa 2.3.0 and Tensorflow 2.3.1,
Rasa 2.3.0 and Tensorflow 2.4.0,
Rasa 2.4.3 and Tensorflow 2.4.0,
Rasa 2.4.3 and TensorFlow 2.5.0-rc1,
Rasa 2.3.0 and Tensorflow 2.5.0-rc1.

All released Rasa versions are compatible with maximum Tensorflow 2.3.1, while for multi-GPU training Tensorflow 2.4.0, or higher, must be used.

UPDATE!
So far, we have tested several combinations of Tensorflow and Rasa versions and concluded that Rasa is still not available for multi-GPU training. More precisely, these versions are tested:

Rasa 2.3.0 and Tensorflow 2.3.1,
Rasa 2.3.0 and Tensorflow 2.4.0,
Rasa 2.4.3 and Tensorflow 2.4.0,
Rasa 2.4.3 and TensorFlow 2.5.0-rc1,
Rasa 2.3.0 and Tensorflow 2.5.0-rc1.

All released Rasa versions are compatible with maximum Tensorflow 2.3.1, while for multi-GPU training Tensorflow 2.4.0, or higher, must be used.

Great job! So we cannot train diet model on multi gpus ?

Rasa version: 2.3.0
Python version: 3.8.5
Operating system (windows, osx, ...): Ubuntu 18.04
Issue:

Hi,

We want to train our model on multiple GPUs, so we changed the code and added a few lines to use the distribution strategy. The model was using GPUs in parallel until the training of the DIETClassifier started and the following error occurred:

"ValueError: SyncOnReadVariable does not support `assign_add` in cross-replica context when aggregation is set to `tf.VariableAggregation.SUM`".

We found out that this error was solved in Tensorflow 2.4. However, according to the available Rasa dependencies, it is possible to use the Tensorflow version up to 2.3. Do you have any suggestions on how to use multiple GPUs in another way? Do you already support it?

Error (including full traceback):
ValueError: SyncOnReadVariable does not support `assign_add` in cross-replica context when aggregation is set to `tf.VariableAggregation.SUM`

Command or request that led to error:
rasa train nlu

Could you pls share your code on how to use multiple GPUs?

Why was this issue closed, when there is no solution to this problem?


Allow for starting the library externally

I have some processing that I want to do asynchronously before creating the first visit; would be nice to have a start function publicly available.

Great, thanks @wheeyls! This is great. I left one small comment inline.

Looks great, thanks for this nice feature @wheeyls! 💯


Some decent refactoring

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[Slider] Extract slots as standalone components

Do not review yet

Closing, as it was done for experiment only

I'll need to update the buildAPI script again to extract info from the proptypes classes prop, currently it depends on the component.styles which is something we are adding for the components created with withStyles. However I would like first to see whether we agree with this approach, before spending too much time on it.

Playground for testing classes prop - https://codesandbox.io/s/continuousslider-material-demo-forked-40y7u?file=/demo.js

I am merging this one so I can update https://github.com/mui-org/material-ui/pull/23308 I can address any additional comments there.


Investigate performance issue with hapi fhir structures context creation

Let's use this also to establish some performance benchmarks.


minor: SymfonySet - Add nullable_type_declaration_for_default_null_value

Following preference expressed here https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5785 by two maintainers of the projects.

Coverage remained the same at 92.873% when pulling a95984a8f7acb283967b8d29c4f8412886350561 on SpacePossum:master_5785 into f736dc928cd803c93bcaadaef24b738e2a0548e4 on FriendsOfPHP:master.

not sure if I got you on this one, @SpacePossum
To my understanding, the wish of Sf maintainers was to remove ? in such cases, and your PR configure the opposite?
(myself, I would rather enforce having ?, and if declaration gets too long, that could suggest other change in first place)

Indeed, thanks, closing as invalid :+1:


About "yawrate_offset_stop" and "yawrate_offset" results

Sometimes the results can be very different.
This is because the vehicle speed CAN may not be output at extremely low speeds.
You need a guard that doesn't give off results.

Resolved by using some previous data and estimating.


[colmap] build failure

Operating system
Windows 10
Compiler
No response
Steps to reproduce the behavior
vcpkg install colmap[cuda,tests]:x64-windows

Failure logs
C:\Users\nsry123\vcpkg>vcpkg install colmap[cuda,tests]:x64-windows
Computing installation plan...
The following packages will be built and installed:
colmap[core,cuda,tests]:x64-windows -> 2023-03-12#1
Detecting compiler hash for triplet x64-windows...
-- Automatically setting HTTP(S)_PROXY environment variables to "<IP_ADDRESS>:4780".
Restored 0 package(s) from C:\Users\nsry123\AppData\Local\vcpkg\archives in 154 us. Use --debug to see more details.
Installing 1/1 colmap:x64-windows...
Building colmap[core,cuda,tests]:x64-windows...
-- Using cached colmap-colmap-33e26924f950172751f044a89b964129b3728db8.tar.gz.
-- Extracting source C:/Users/nsry123/vcpkg/downloads/colmap-colmap-33e26924f950172751f044a89b964129b3728db8.tar.gz
-- Applying patch fix-dependencies.patch
CMake Error at scripts/cmake/z_vcpkg_apply_patches.cmake:34 (message):
Applying patch failed: Checking patch CMakeLists.txt...
error: while searching for:
find_package(Eigen3 REQUIRED)
find_package(FreeImage REQUIRED)
find_package(FLANN REQUIRED)
find_package(LZ4 REQUIRED)
find_package(Metis REQUIRED)
find_package(Glog REQUIRED)
find_package(SQLite3 REQUIRED)
error: patch failed: CMakeLists.txt:99
error: CMakeLists.txt: patch does not apply
Call Stack (most recent call first):
scripts/cmake/vcpkg_extract_source_archive.cmake:153 (z_vcpkg_apply_patches)
scripts/cmake/vcpkg_extract_source_archive_ex.cmake:8 (vcpkg_extract_source_archive)
scripts/cmake/vcpkg_from_github.cmake:113 (vcpkg_extract_source_archive_ex)
ports/colmap/portfile.cmake:3 (vcpkg_from_github)
scripts/ports.cmake:147 (include)
error: building colmap:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+colmap
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[colmap]+Build+error&body=Copy+issue+body+from+C%3A%2FUsers%2Fnsry123%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md
Additional context
According to the log, it seems that some packages such as Eigen3 that are bracketed in the find_package() are not installed. However, when trying to use vckpg install to install any of them, it says that they are already installed.

@nsry123, thanks for posting this issue, it looks like your error is because the patch is not applied, could you please update your vcpkg with the command git pull and try again?
Applying patch failed: Checking patch CMakeLists.txt...

After updating, the same error still occurs. Thank you very much for your reply.

@nsry123, thanks for posting this issue, it looks like your error is because the patch is not applied, could you please update your vcpkg with the command git pull and try again?
Applying patch failed: Checking patch CMakeLists.txt...

After updating, the same error still occurs. Thank you very much for your reply.

@nsry123, Your error shows that the application of the colmap patch fix-dependencies.patch failed. I can no longer reproduce your error locally. can you clone a vcpkg to try again?

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.


bug: fix git-lfs version in path

v1.1.5 runs into the follow error due to this bug.
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/yatai/envs/latest/lib/python3.10/site-packages/sphinx/events.py", line 97, in emit
    results.append(listener.handler(self.app, *args))
  File "/home/docs/checkouts/readthedocs.org/user_builds/yatai/envs/latest/lib/python3.10/site-packages/sphinx_lfs_content/__init__.py", line 41, in lfs_setup
    subprocess.check_call("git-lfs install".split(), env=env)
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/subprocess.py", line 364, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/subprocess.py", line 345, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/home/docs/.asdf/installs/python/3.10.13/lib/python3.10/subprocess.py", line 1863, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'git-lfs'

Duplicate of #18. Thanks anyway for noticing and fixing!


Always stcks at 16% Xlabs Ksampler

got prompt
Is model already patched? False
X:\ComfyUI\comfy\ldm\modules\attention.py:407: UserWarning: 1Torch was not compiled with flash attention. (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:555.)
out = torch.nn.functional.scaled_dot_product_attention(q, k, v, attn_mask=mask, dropout_p=0.0, is_causal=False)
We are patching diffusion model, be patient please
Patched succesfully!
clip missing: ['text_projection.weight']
Requested to load FluxClipModel_
Loading 1 new model
loaded partially 4936.91484375 4924.23095703125 0
Unloading models for lowram load.
0 models unloaded.
Requested to load Flux
Loading 1 new model
loaded partially 4936.91484375 5222.34375 0
Sampling:   0%|                                                                                | 0/50 [00:00<?, ?it/s]
... stops, sticks here after 16% processed

Win 10, 8Gb VRAM, 64Gb RAM

What was the solution?

To get more VRAM  :)

To get more VRAM :)

I have 24 as for myself


Trailing single-line comments are wrapped to the next line

I had a bit of code where a trailing comment was moved to the next line when there's another statement after the function. This can cause confusion since it requires you to read the comment to know whether it applies to the line before or after and it looks like it would actually cause things like // eslint-disable-line to apply to a different statement.
function foobar() {
	var foo = bar;
	var bar = fooBarBaaz(); // foo all the bars

	var baaz = 'quux';
}

becomes:
function foobar() {
  var foo = bar;
  var bar = fooBarBaaz();
  // foo all the bars
  var baaz = "quux";
}

This does not happen if the comment is on the last line of a function.

Comments are probably where most of the subtle bugs are right now. They're pretty difficult to get right, but this is definitely problematic. I think it'll take a few weeks to sort out these kinds of bugs, but we'll get there.

prettier sure doesn't know what to make of ASCII art that is laid out to the right of the real code, such as this example (input):
//                                           60 chars -->   |
function makeComponent(): int {
  return {                   //                 (__)
    longCall() {             //                 (oo)
      complicatedFunction(   //           /------\/
        importantArgument(), //          / |    ||
        secondaryArgument()  //         *  /\---/\
      );                     //            ~~   ~~
      weirdStyle({ prop: 1 }, 1, 2, 3);
    },
    render() {
      const user = { name: "James" };
      return (

          hello ${name}! JSX issupported

      );
    }
  };
}

but honestly I don't know what you do with devs who insist on that sort of thing; tell them to cut it out I suppose.

@jepler I've seen a few cases where someone had some sort of diagram / flowchart which was  important but I would think a reasonable position would simply be “Make it a full multi-line comment block”.

inline comments in all positions are extremely difficult. The case where there inline comments beside function call arguments is a known issue in recast as well, and it actually reclassifies those comments as leading comments (moves them up before the expression). I think right now we copy that behavior sometimes too.
But yes, there are going to be times where there is only so much we can do, and users need to change how they write a specific style so that it formats better. We can make inline comments better to some degree, but I'm not sure how far we can go.

This one is a rather big issue for me, I tend to use the space to the right for a comment whenever it helps, such as to say what that object property is or what have you

See above PR


Change Icon Style

How to change the type of icon library?
import myTheme from '../themes/myTheme';
<Icon name='arrows' theme={myTheme} />

The content of myTheme.js
export default {
    iconFamily: 'FontAwesome',
}

This still uses the default theme library ionicons

Fixed with this commit


Missing 'certificate' key in finalize response

I'm getting sometimes:
 File "/usr/local/py_venv/pki_op_p38/src/automatoes/automatoes/acme.py", line 446, in await_for_order_fulfillment     order.certificate_uri = _json(response)['certificate'] KeyError: 'certificate'
Response looks like:
{'status': 'valid', 'expires': '2020-05-11T15:16:24Z', 'identifiers': [{'type': 'dns', 'value': 'some.fqdn'}], 'authorizations': ['https://acme-v02.api.letsencrypt.org/acme/authz-v3/123'], 'finalize': 'https://acme-v02.api.letsencrypt.org/acme/finalize/456/3237347682', 'certificate': 'https://acme-v02.api.letsencrypt.org/acme/cert/abc123'}
in this case.
What's going wrong here?

Are you running on python38? I'll add tests to it.

Am 14.05.2020 um 15:59 schrieb Flavio Garcia<EMAIL_ADDRESS>
Are you running on python38? I'll add tests to it.

Yes.

Funny your response has the certificate index:
{
'status': 'valid', 'expires': '2020-05-11T15:16:24Z',
'identifiers': [{'type': 'dns', 'value': 'some.fqdn'}], 'authorizations': ['https://acme-v02.api.letsencrypt.org/acme/authz-v3/123'],
'finalize': 'https://acme-v02.api.letsencrypt.org/acme/finalize/456/3237347682',
'certificate': 'https://acme-v02.api.letsencrypt.org/acme/cert/abc123' // <=== RIGHT HERE
}

Could be an error where response has no certificate? Maybe an error not handled?

Am 18.05.2020 um 17:50 schrieb Flavio Garcia<EMAIL_ADDRESS>Funny your response has the certificate index:
{
'status': 'valid', 'expires': '2020-05-11T15:16:24Z',
'identifiers': [{'type': 'dns', 'value': 'some.fqdn'}], 'authorizations': ['https://acme-v02.api.letsencrypt.org/acme/authz-v3/123'],
'finalize': 'https://acme-v02.api.letsencrypt.org/acme/finalize/456/3237347682',
'certificate': 'https://acme-v02.api.letsencrypt.org/acme/cert/abc123' // <=== RIGHT HERE
}
Yes.
If I run the client again, it always succeeds. But inserting sleep() does not help.
Could be an error where response has no certificate? Maybe an error not handled?

Perhaps in json code. Are you familiar with that module? Any hints, where to catch the KeyError welcome.
There is no KeyError in the response. I have:

    print(_json(response))
    if _json(response)['status'] in ["valid", "ready"] and 'certificate' in _json(response):
        order.certificate_uri = _json(response)['certificate']

and still it raises. )-:
Axel
PGP-Key: CDE74120  ☀  computing @ chaos claudius

Am 18.05.2020 um 21:12 schrieb Axel Rau<EMAIL_ADDRESS>Perhaps in json code. Are you familiar with that module? Any hints, where to catch the KeyError welcome.
I now have:

def _json(response):
try:
return response.json()
except ValueError as e:
raise AcmeError("Invalid JSON response. {}".format(e))
except KeyError as e:
raise AcmeError("Invalid JSON response (KeyError). {}".format(e))

This worked!
I’m not sure, if the error happened only if I issued 2 certs (rsa + ec) using same authorization..
Currently I can’t test further.
Axel
PGP-Key: CDE74120  ☀  computing @ chaos claudius

Are you providing the key or letting automatoes generate?
To be honest I have no tests with generated keys, I'm always generating the key.
I think I'm dropping the ball somewhere.
Could you please provide the steps to reproduce the issue? I can try to bang my head against staging server and add tests for this case.

How do you issue 2 certs (rsa + ec) using same authorization?

Am 29.05.2020 um 21:45 schrieb Flavio Garcia<EMAIL_ADDRESS>How do you issue 2 certs (rsa + ec) using same authorization?

authorization is per FQDN. I do a acme.new_order per algorithm and server may decide to take it as already fulfilled. (-;
I’m currently refactoring my code and can’t send you a debug trace right now.
Axel
PGP-Key: CDE74120  ☀  computing @ chaos claudius

Ha. So you're using the module instead of script. Great! :)
But wait a minute, acme is an instance of AcmeV2 right?
Anyways, here is the workflow(hope it helps):
# Step 1
order = acme_v2.new_order(what_domains, what_type) # where domais is a list and what time is 'dns' or 'http'

# Step 2
challenges = acme_v2.get_order_challenges(order)
for challenge in challenges:
    challenge_response = acme_v2.verify_order_challenge(challenge, 1)
    # here challenge_response['status'] must be 'valid', some homework to do to get them valid...
    # on the tests it is valid by default as we touch them, at the script we loop before and display
    # all challenges

# Step 3 challenges MUST BE DONE otherwise you need a new order
domains = what_domains.split(" ")
csr = create_csr(generate_rsa_key(4096), domains) # You are doing your thing righ ; )
finalize_order_response = acme_v2.finalize_order(order, csr)
# finalize_order_response['status'] must be processing, here you could not get the cert sometimes work...

# Step 4 wait for the order be fulfilled
order_fulfillment_response = acme_v2.await_for_order_fulfillment(order) # by default it iterates 5 times every 2 seconds, use timeout and iterations if you need
# usually we never reach the third iteration and second will depend of timing
# order_fulfillment_response['status'] must be ready
# you can await_for_order_fulfillment several times if you want

# Step 5
if (order.certificate_uri is not None):
   order_certificate_response = (
        acme_v2.download_order_certificate(order))

Feel free to send wish list items to help your workflow.

Am 02.06.2020 um 16:21 schrieb Flavio Garcia<EMAIL_ADDRESS>Ha. So you're using the module instead of script. Great! :)
Yes, like I did with manuale.
But wait a minute, acme is an instance of AcmeV2 right?
Yes.

Anyways, here is the workflow(hope it helps):

This is exactly, what I tried to implement (stolen from your code). (:
Preliminary is here:
https://github.com/mc3/serverPKI/blob/master/serverPKI/issue_LE.py
. . .

Feel free to send wish list items to help your workflow.
Sure.

Axel
PGP-Key: CDE74120  ☀  computing @ chaos claudius

Am 31.05.2020 um 11:49 schrieb Axel Rau<EMAIL_ADDRESS>
Am 29.05.2020 um 21:45 schrieb Flavio Garcia<EMAIL_ADDRESS>How do you issue 2 certs (rsa + ec) using same authorization?

authorization is per FQDN. I do a acme.new_order per algorithm and server may decide to take it as already fulfilled. (-;
I’m currently refactoring my code and can’t send you a debug trace right now.

Here is my debug output:
——
['test1.lrau.net']]
[Creating certificates.]
[Creating certificate for test1.lrau.net and crypto algo rsa_plus_ec]
[Creating rsa 2048 bits key and server cert for test1.lrau.net]
[new_order for test1.lrau.net returned
uri: https://acme-staging-v02.api.letsencrypt.org/acme/order/12683432/100267619
type: dns
certificate_uri: None
contents: {'status': 'pending', 'expires': '2020-06-16T17:01:11Z', 'identifiers': [{'type': 'dns', 'value': 'test1.lrau.net'}, {'type': 'dns', 'value': 'test2.lrau.net'}], 'authorizations': ['https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/63742513', 'https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/63742514'], 'finalize': 'https://acme-staging-v02.api.letsencrypt.org/acme/finalize/12683432/100267619'}]
[Calling zone_and_FQDN_from_altnames()]
[/usr/local/etc/namedb/master/signed/lrau.net]
[/usr/local/etc/namedb/master/signed/lrau.net]
[/usr/local/etc/namedb/master/signed/lrau.net]
[zones: {'lrau.net': ['test1.lrau.net']}]
[Calling zone_and_FQDN_from_altnames()]
[/usr/local/etc/namedb/master/signed/lrau.net]
[/usr/local/etc/namedb/master/signed/lrau.net]
[/usr/local/etc/namedb/master/signed/lrau.net]
[zones: {'lrau.net': ['test1.lrau.net', 'test2.lrau.net']}]
[DNS update of RR: _acme-challenge.test1.lrau.net.  60 TXT  "YMZJbDtSNkZkzA1nqHSKOYfbV6LazRJG4x9lJ5UzwpM"]
[DNS update of RR: _acme-challenge.test2.lrau.net.  60 TXT  "EBuNU-ZxL1nz0GrILjs3-JPKCi6jhSZiBohCSEX4CW4"]
[DNS update delete/add returned response: id 7044
opcode UPDATE
rcode NOERROR
flags QR
;ZONE
lrau.net. IN SOA
;PREREQ
;UPDATE
;ADDITIONAL]
[2020-06-09T17:01:16.116663 completed DNS setup on hidden primary for all pending FQDNs]
[Waiting 60 seconds for dns propagation]
[2020-06-09T17:02:16.141448 starting verification of test1.lrau.net]
[2020-06-09T17:02:23.778981 acme.verify_order_challenge returned "valid"]
[test1.lrau.net: OK! Authorization lasts until 2020-06-16T17:01:11Z.]
[2020-06-09T17:02:23.781183 starting verification of test2.lrau.net]
[2020-06-09T17:02:31.573314 acme.verify_order_challenge returned "valid"]
[test2.lrau.net: OK! Authorization lasts until 2020-06-16T17:01:11Z.]
[DNS update delete/add returned response: id 37084
opcode UPDATE
rcode NOERROR
flags QR
;ZONE
lrau.net. IN SOA
;PREREQ
;UPDATE
;ADDITIONAL]
[FQDNs authorized. Let's Encrypt!]
[Requesting certificate issuance from LE...]
[test1.lrau.net/rsa:  Checking order status.]
Traceback (most recent call last):
File "/usr/local/py_venv/pki_dev_p38/src/serverPKI/serverPKI/issue_LE.py", line 215, in _issue_cert_for_one_algo
fulfillment = acme.await_for_order_fulfillment(order)
File "/usr/local/py_venv/pki_dev_p38/lib/python3.8/site-packages/automatoes/acme.py", line 446, in await_for_order_fulfillment
order.certificate_uri = _json(response)['certificate']
KeyError: 'certificate‘

A few seconds later it runs through:

['test1.lrau.net']]
[Creating certificates.]
[Creating certificate for test1.lrau.net and crypto algo rsa_plus_ec]
[Creating rsa 2048 bits key and server cert for test1.lrau.net]
[new_order for test1.lrau.net returned
uri: https://acme-staging-v02.api.letsencrypt.org/acme/order/12683432/100267619
type: dns
certificate_uri: None
contents: {'status': 'ready', 'expires': '2020-06-16T17:01:11Z', 'identifiers': [{'type': 'dns', 'value': 'test1.lrau.net'}, {'type': 'dns', 'value': 'test2.lrau.net'}], 'authorizations': ['https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/63742513', 'https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/63742514'], 'finalize': 'https://acme-staging-v02.api.letsencrypt.org/acme/finalize/12683432/100267619'}]
[Requesting certificate issuance from LE...]
[test1.lrau.net/rsa:  Order finalized. Certificate is being issued.]
[test1.lrau.net/rsa:  Checking order status.]
[Creating ec key and server cert for test1.lrau.net]
[new_order for test1.lrau.net returned
uri: https://acme-staging-v02.api.letsencrypt.org/acme/order/12683432/100270931
type: dns
certificate_uri: None
contents: {'status': 'ready', 'expires': '2020-06-16T17:12:22Z', 'identifiers': [{'type': 'dns', 'value': 'test1.lrau.net'}, {'type': 'dns', 'value': 'test2.lrau.net'}], 'authorizations': ['https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/63742513', 'https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/63742514'], 'finalize': 'https://acme-staging-v02.api.letsencrypt.org/acme/finalize/12683432/100270931'}]
[Requesting certificate issuance from LE...]
[test1.lrau.net/ec:  Order finalized. Certificate is being issued.]
[test1.lrau.net/ec:  Checking order status.]
[CertInstance._save(): cm.row_id=21, state=issued, ocsp_ms=True, not_before=2020-06-09 16:12:18, not_after=2020-09-07 16:12:18, ca_cert_ci.row_i=46]
[CertInstance._save(): Returned row_id=122]
[CertKeyStore.init: cm.name=test1.lrau.net, algo=rsa, row_id=None]
[CertKeyStore._save(): cm.name=test1.lrau.net, row_id=None, ci.row_id=122, algo=rsa, hash=096237AC4558E015D7EB5490B2DDB2B03204F7448A324F57EAD4449022BF8359]
[Certificate issued for test1.lrau.net . Valid until 2020-09-07T16:12:18]
[Hash is: 096237AC4558E015D7EB5490B2DDB2B03204F7448A324F57EAD4449022BF8359, algo is rsa]
[CertKeyStore.init: cm.name=test1.lrau.net, algo=ec, row_id=None]
[CertKeyStore._save(): cm.name=test1.lrau.net, row_id=None, ci.row_id=122, algo=ec, hash=448E3BEAA79000A93C231A79EC68DD2E89A0A0E28BE4AB58676C506A3171EBE6]
[Certificate issued for test1.lrau.net . Valid until 2020-09-07T16:12:26]
[Hash is: 448E3BEAA79000A93C231A79EC68DD2E89A0A0E28BE4AB58676C506A3171EBE6, algo is ec]
[CertInstance._save(): cm.row_id=21, state=issued, ocsp_ms=True, not_before=2020-06-09 16:12:18, not_after=2020-09-07 16:12:18, ca_cert_ci.row_i=46]
[CertInstance._save(): Returned row_id=122]

As this program is usually run by cron once a hour, I think the whole thin is not really an issue.
Please let me know, if I can provide more trace data.
Axel
PGP-Key: CDE74120  ☀  computing @ chaos claudius

The key error now happens, if my scheduler tries to create more than 1 (single algo) cert in one run.
I obtain different AcmeV2 instances for each cert

in step 1   before acme.new_order(domains, 'dns')
in step 3   before acme.finalize_order(order, csr)  (2 is done for each cert algo in a loop)

Otherwise it did not work.
Does this has implications with nonce?
Waht do you think?
Axel

Am 02.06.2020 um 16:21 schrieb Flavio Garcia<EMAIL_ADDRESS>Ha. So you're using the module instead of script. Great! :)
But wait a minute, acme is an instance of AcmeV2 right?
Anyways, here is the workflow(hope it helps):
Step 1
order = acme_v2.new_order(what_domains, what_type) # where domais is a list and what time is 'dns' or 'http'
Step 2
challenges = acme_v2.get_order_challenges(order)
for challenge in challenges:
challenge_response = acme_v2.verify_order_challenge(challenge, 1)
# here challenge_response['status'] must be 'valid', some homework to do to get them valid...
# on the tests it is valid by default as we touch them, at the script we loop before and display
# all challenges
Step 3 challenges MUST BE DONE otherwise you need a new order
domains = what_domains.split(" ")
csr = create_csr(generate_rsa_key(4096), domains) # You are doing your thing righ ; )
finalize_order_response = acme_v2.finalize_order(order, csr)
finalize_order_response['status'] must be processing, here you could not get the cert sometimes work...
Step 4 wait for the order be fulfilled
order_fulfillment_response = acme_v2.await_for_order_fulfillment(order) # by default it iterates 5 times every 2 seconds, use timeout and iterations if you need
usually we never reach the third iteration and second will depend of timing
order_fulfillment_response['status'] must be ready
you can await_for_order_fulfillment several times if you want
Step 5
if (order.certificate_uri is not None):
order_certificate_response = (
acme_v2.download_order_certificate(order))
Feel free to send wish list items to help your workflow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/candango/automatoes/issues/42#issuecomment-637574861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACTBFFEPX7CU3O3XT7JRBTRUUDHBANCNFSM4MY6B3SA.

PGP-Key: CDE74120  ☀  computing @ chaos claudius

My calls have nonce handled inside, nonce errors will trigger exceptions.
Let me check your debugging.

I have now started using the LE productive server and, o wonder, "Missing 'certificate' key in finalize response“ disappeared.
Instead, I now get spurious "Order not valid after fulfillment.“
I just did a bunch of 17 orders::
6 required an authorization, of which 3 run into this error.
11 certs have been issued without problems.
Axel
PS: Here is an example of such a failure (www.lechner-rau.de http://www.lechner-rau.de/ with altname lechner-rau.de http://lechner-rau.de/):

[Requesting issue from LE for www.lechner-rau.de]
[Creating certificate for www.lechner-rau.de and crypto algo rsa]
[Creating rsa 2048 bits key and server cert for www.lechner-rau.de]
[new_order for www.lechner-rau.de returned
uri: https://acme-v02.api.letsencrypt.org/acme/order/1588389/3766929895
type: dns
certificate_uri: None
contents: {'status': 'pending', 'expires': '2020-06-21T16:30:14Z', 'identifiers': [{'type': 'dns', 'value': 'lechner-rau.de'}, {'type': 'dns', 'value': 'www.lechner-rau.de'}], 'authorizations': ['https://acme-v02.api.letsencrypt.org/acme/authz-v3/5236507809', 'https://acme-v02.api.letsencrypt.org/acme/authz-v3/5236507810'], 'finalize': 'https://acme-v02.api.letsencrypt.org/acme/finalize/1588389/3766929895'}]
[Calling zone_and_FQDN_from_altnames()]
[/usr/local/etc/namedb/master/signed/lechner-rau.de]
[/usr/local/etc/namedb/master/signed/lechner-rau.de]
[/usr/local/etc/namedb/master/signed/lechner-rau.de]
[zones: {'lechner-rau.de': ['lechner-rau.de']}]
[Calling zone_and_FQDN_from_altnames()]
[/usr/local/etc/namedb/master/signed/lechner-rau.de]
[/usr/local/etc/namedb/master/signed/lechner-rau.de]
[/usr/local/etc/namedb/master/signed/lechner-rau.de]
[zones: {'lechner-rau.de': ['www.lechner-rau.de', 'lechner-rau.de']}]
[DNS update of RR: _acme-challenge.www.lechner-rau.de.  60 TXT  "IC3Tk4tkr8qk98p-1jafFCQd9yAYnHmpOnHNjpJb_R0"]
[DNS update of RR: _acme-challenge.lechner-rau.de.  60 TXT  "FQ_au0SEdiAUU8eU439mbSgf7OMOT9VkgBzX4C_HDCE"]
[DNS update delete/add returned response: id 54305
opcode UPDATE
rcode NOERROR
flags QR
;ZONE
lechner-rau.de. IN SOA
;PREREQ
;UPDATE
;ADDITIONAL]
[2020-06-14T16:30:18.737268 completed DNS setup on hidden primary for all pending FQDNs]
[Waiting 60 seconds for dns propagation]
[2020-06-14T16:31:18.744370 starting verification of lechner-rau.de]
[2020-06-14T16:31:26.320978 acme.verify_order_challenge returned "valid"]
[lechner-rau.de: OK! Authorization lasts until 2020-06-21T16:30:14Z.]
[2020-06-14T16:31:26.323212 starting verification of www.lechner-rau.de]
[2020-06-14T16:31:33.837714 acme.verify_order_challenge returned "valid"]
[www.lechner-rau.de: OK! Authorization lasts until 2020-06-21T16:30:14Z.]
[DNS update delete/add returned response: id 37856
opcode UPDATE
rcode NOERROR
flags QR
;ZONE
lechner-rau.de. IN SOA
;PREREQ
;UPDATE
;ADDITIONAL]
[FQDNs authorized. Let's Encrypt!]
[Requesting certificate issuance from LE...]
[www.lechner-rau.de/rsa:  Checking order status.]
{'status': 'ready', 'expires': '2020-06-21T16:30:14Z', 'identifiers': [{'type': 'dns', 'value': 'lechner-rau.de'}, {'type': 'dns', 'value': 'www.lechner-rau.de'}], 'authorizations': ['https://acme-v02.api.letsencrypt.org/acme/authz-v3/5236507809', 'https://acme-v02.api.letsencrypt.org/acme/authz-v3/5236507810'], 'finalize': 'https://acme-v02.api.letsencrypt.org/acme/finalize/1588389/3766929895'}
?www.lechner-rau.de/rsa:  Order not valid after fulfillment. Giving up

PGP-Key: CDE74120  ☀  computing @ chaos claudius

"Order not valid after fulfillment.“, means some dns challenge wasn't correct and you finalized the order before that happened.
You must loop through all challenges.
From your code on https://github.com/mc3/serverPKI/blob/master/serverPKI/issue_LE.py#L359-L388:
    sli('Waiting 60 seconds for dns propagation')  # <====== I think this is not that much time for DNS to propagate. I always continue the manuale autorize after my dns provider is done and wait a little bit. This is a good case for our automation procedure. Maybe we should have a function to confirm this dns change on our side without cche
    time.sleep(60)
    for challenge in pending_challenges:
        sld("{}: waiting for verification...".format(challenge.domain))

        # wait maximum 2 minutes
        sld('{} starting verification of {}'.
            format(datetime.datetime.utcnow().isoformat(), challenge.domain))
        response = acme.verify_order_challenge( challenge,
                                                timeout=10,
                                                retry_limit=12)   #  <=== Here we screw up if a challenge isn't valid I think we need feedback for your code so you can start over
        sld('{} acme.verify_order_challenge returned "{}"'.
            format(datetime.datetime.utcnow().isoformat(), response['status']))
        if response['status'] == "valid":
            sld("{}: OK! Authorization lasts until {}.".format(
                challenge.domain, challenge.expires))
            authorized_until = challenge.expires
        elif response['status'] == 'invalid':
            sle("{}: Challenge failed, because: {} ({})".format(
                challenge.domain,
                response['error']['detail'],
                response['error']['type'])
            )
            # we need either all challenges or none: repeat with next cron cacle
            return None
        else:
            sln("{}: Challenge returned status {}".format(
                                    challenge.domain,
                                    response['status']))
            # we need either all challenges or none: repeat with next cron cacle
            return None

If the acme.verify_order_challenge have any challenge invalid we should start from the beggining.
I think you're missing two verifications before the verify:
1 - From Authorize I check pending order or invalid right here:
https://github.com/candango/automatoes/blob/develop/automatoes/authorize.py#L133-L152
2 - From Authorize I check for failed and pending:
https://github.com/candango/automatoes/blob/develop/automatoes/authorize.py#L180-L201
On the issue command I still check again so I don't finalize a pending order:
https://github.com/candango/automatoes/blob/develop/automatoes/issue.py#L86-L102
Right now I cannot reissue an order file that is still valid or expired. I'll fix that on #39.

@mc3 do you checked my comments? Are you still experiencing the same issues?

Yes, I checked your comment and I could not find any code issues with serverPKI nor with automatoes.
The effect disappeared while moving from the stating to the production environment. Now the issue can't be reproduced with the stating environment too.
I guess it was a bug in boulder and LE has fixed it meanwhile (Hopefully for ever) (-;

The issue happened now reproducible and I investigated further:
line 476 in acme:
if _json(response)['status'] in ["valid", "ready"]:
is definitely wrong, as only "valid" signals the downloadable cert (see page 47 in RFC 8555
Putting the same code into finalize_order speeds up things even more.
With the 2 patches in my pull request, my software runs perfectly now!
Hopefully this is compatible with acme consumers in automatoes so I can close my fork.
Resolution of a bug without fix is no resolution. (-;


Increasing functionality of File Transfer

Sorting by size, alphabetically, date, type
Better ui (resizing width and etc)
Create folder
Delete files or folders
Show progress of transferring (complex)

change columns width in directory files list. If file name is long, there is a need to increase width of column to see full name. Also selected file full name might be showed in some status bar, for user convenience.

We need to add automatic refresh after file uploading, because now if file already uploaded to server, it doesn't appear in list, user needs to refresh the window.

Completed


For pre-commits, should ruff run before or after black?

The documentation doesn't specify if ruff should run before or after black for best results.

Before! I can add a note.

(We test in CI that running Ruff, then Black, then Ruff again is a stable operation.)

Out of curiosity, why does the order matter? I run black before I run ruff because black might fix some things that a linter would otherwise complain about, so it keeps actual errors to a minimum.

Ruff's autofixes aren't guaranteed to output Black-compatible code. They often do, but it's not guaranteed. So running Black, then Ruff, then Black could result in changes on each invocation (whereas running Ruff, then Black should always be stable).
As a silly example, imagine we're converting a lambda to a function definition. When we do that, we don't take line lengths into account, and we certainly don't take all of Black's possible line length wrapping behaviors into account. So if you had a lambda with a ton of arguments, we might yield a function definition on one very long line, which Black would then wrap.

Ah, so it only needs to run first when autofix is enabled. That makes more sense.

Correct!


FIX: Incorrect version in metadata.txt file

Metadata file shows version 0.0.1 while current version is 0.0.3

Issue fixed via direct commit to main


Update Romanian translations

Add missing strings

Awesome! This will be added in the next version :) Thank you!


MINOR: Improve log4j on stream thread and stream process

Cherry pick from https://github.com/apache/kafka/pull/2685

@ijuma or @ewencp or @gwenshap could you have a look? Thanks.

kafka.server.SaslSslReplicaFetchTest.testReplicaFetcherThread failed, not related to PR

Merged to 0.10.2, please close the PR.


Review Magazine/Event roles in Sanity

Editors should be the only one with access to Magazines.

Types "eventTag", "event", "magazine" and "magazineTag" were added to the missing content resourcers in the project:

We should probably have this as a standard acceptance criteria whenever we make a new document type - I had not thought of this before 🤔


Can the google home speak first on a button press?

Really more of a question than an issue. Is there a way to have the google home respond first with a button press or a tirgger on a raspberry pi?
For example, instead of pressing a button then asking "what's the weather", you button and it starts the conversation with something like "Hey, what can I help you with?"
I'm currently looking through the documentation, but if anyone has some links or thoughts, that would be great.
Thanks!

A feature of the SDK is that your embedded Google Assistant can wake up on any trigger that you want. However, it is not able to wake up a Google Home, and the Google Home does not have any button to wake it up.

Sorry. I think maybe I wasn't clear? I have an embedded google assistant ON a raspberry pi, and I know you can rig a button to wake it up, what I want to know is if you can wake it up and have the google assistant respond first rather than waking it up and then having to prompt it with a question to get a response.

Hm. that might work. I need a way to trigger the start of a custom flow / program without a user voice prompt. I guess I could run an audio clip to prompt the user to start the program but I really wish this functionality just existed in the SDK, autonomously starting its a behaviour I get asked about implementing a lot. Anyways, thanks!


python3Packages.sendgrid: 6.9.3 -> 6.9.4

Motivation for this change
https://github.com/sendgrid/sendgrid-python/releases/tag/6.9.4
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 154852 run on x86_64-linux 1

2 packages built:

python310Packages.sendgrid
python39Packages.sendgrid


[docs] Rename jsx-runtime in window object

[x] I have followed (at least) the PR section of the contributing guide.

@alexfauquette Please help to merge it when you are available, thanks.

That's a breaking change. Even if it's docs, I'm not in favor of adding a breaking change for the only purpose of renaming stuff

@alexfauquette I know your concern. This function is created by me. We haven't mentioned this in docs site. So I think it is low impact to rename. I rename it because I use Vite to build the js chunk, I specify the name as jsx, but finally it uses jsxRuntime. So I want to change it and make it easier for developers to integrate.
Now my solution is to modify the file after finishing the build.

@alexfauquette @siriwatknp Can you take a look? Thanks.

Don't need to rename it, can control in our build script.


Made config import relative, fixes #418

Fix for issue #418. Just posted as PR for complete tests.

Coverage decreased (-0.4%) to 57.549% when pulling c74cc8bbd6389b2b96ca05600f7131ca7e2b71c9 on KennethNielsen:discovery-import-bug-iss418 into 6bb475a79f82cc83e8564d9639f468b9d0dda2ed on SoCo:master.


Don't show the edit button when viewing others's profiles

Finished with Push: "Added M1/ Correcting for deployment on Google Cloud, Idents to 4 spaces"


"import x" and "from x import y" code completion is not working on the editor and the console

From ccordoba12 on 2010-09-04T12:58:19Z
I really like this Ipython's feature, because it lets me quickly explore a new module or those big modules I know nothing about.
Unfortunately it's not working on the embedded ipython console nor on the editor. I have to use this feature in a console, then paste the results on spyder for now.
This is my major complaint about spyder. I've found it really really useful for my work and I like it a lot. Thanks for taking the time to develop it.
Carlos
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=328

From pierre.raybaut on 2010-09-12T10:14:09Z
Summary: v2.0: "import x" and "from x import y" code completion (editor + console)
Labels: -Type-Defect Type-Enhancement

From pierre.raybaut on 2010-09-12T10:15:41Z
issue #257 has been merged into this issue.

From pierre.raybaut on 2010-09-12T10:15:07Z
issue #275 has been merged into this issue.

From pierre.raybaut on 2010-10-17T13:15:07Z
Labels: -Priority-Medium Priority-High

From ccordoba12 on 2011-04-22T17:57:44Z
I have a working code that will solve this issue for the console. I hope I could add it to the Editor too, but I don't know how well it can work with rope.
I'll try to publish a branch as soon as a I can.
Cheers,
Carlos
Summary: "import x" and "from x import y" code completion is not working on the editor and the console
Status: Accepted
Owner: ccordoba12
Labels: Milestone-Release2.1

From ccordoba12 on 2011-04-27T08:52:42Z
I've added module completion to the console (both ipython and python). Please check my branch called ccordoba12-module-completion, test it and tell what you think. I've tried to cover all corner cases (especially in statements of the form "from x import y") but you never know :). All in all I think it's working quite well and it'll be a great addition for 2.1!
There is one important drawback though: this feature can work really slowly on old computers. IPython guys solved this issue by creating a simple database of all installed modules so that it hasn't to be recomputed every single time. I guess we'll have to replicate this functionality, just in case.
I still have to add this feature to the editor. Pierre, where can I start to look at to develop this? Can I use rope for this?

From ccordoba12 on 2011-05-09T15:33:00Z
Pierre, I think I've finished my work. I've added the solution I mentioned in my last comment and also an entry in the Tools menu to update the modules list, in case the user consider it necessary (for example, if he/she installs modules not present the first time they were saved)
Could you please review my branch and if you're ok with it, merge it?

From ccordoba12 on 2011-06-01T09:58:03Z
I've rebased my branch to work with the latest tips of 2.1dev and 2.2dev. This means I resolved all merge conflicts and added a simple fix because of config/baseconfig recent split, that maybe are preventing this to go into the main repos.
My new branches are: https://code.google.com/r/ccordoba12-module-completion-v22/ https://code.google.com/r/ccordoba12-module-completion-v21/ Besides, I've tested every branch on Windows and I can confirm they're working as expected. Well, I couldn't test in the ipython console on 2.2 because it doesn't start. Instead, I'm getting this traceback:
Traceback (most recent call last):
File "C:\Documents and Settings\carlos\Mis documentos\Spyder test\module-completion-v22\spyderlib\widgets\externalshell\startup.py", line 184, in <module>
'debugfile': debugfile})
File "C:\Python26\lib\site-packages\IPython\Shell.py", line 1259, in start
return shell(user_ns = user_ns)
File "C:\Python26\lib\site-packages\IPython\Shell.py", line 1146, in init
shell_class=MatplotlibMTShell)
File "C:\Python26\lib\site-packages\IPython\Shell.py", line 1045, in init
on_kill=[QtGui.qApp.exit])
File "C:\Python26\lib\site-packages\IPython\ipmaker.py", line 100, in make_IPython
embedded=embedded,**kw)
File "C:\Python26\lib\site-packages\IPython\Shell.py", line 636, in init
user_ns,user_global_ns,b2 = self._matplotlib_config(name,user_ns,user_global_ns)
File "C:\Python26\lib\site-packages\IPython\Shell.py", line 556, in matplotlib_config
import matplotlib.pylab as pylab
File "C:\Python26\lib\site-packages\matplotlib\pylab.py", line 263, in <module>
from matplotlib.pyplot import *
File "C:\Python26\lib\site-packages\matplotlib\pyplot.py", line 95, in <module>
new_figure_manager, draw_if_interactive, show = pylab_setup()
File "C:\Python26\lib\site-packages\matplotlib\backends_init.py", line 25, in pylab_setup
globals(),locals(),[backend_name])
File "C:\Python26\lib\site-packages\matplotlib\backends\backend_qt4agg.py", line 12, in <module>
from backend_qt4 import QtCore, QtGui, FigureManagerQT, FigureCanvasQT,
File "C:\Python26\lib\site-packages\matplotlib\backends\backend_qt4.py", line 18, in <module>
import matplotlib.backends.qt4_editor.figureoptions as figureoptions
File "C:\Python26\lib\site-packages\matplotlib\backends\qt4_editor\figureoptions.py", line 11, in <module>
import matplotlib.backends.qt4_editor.formlayout as formlayout
File "C:\Python26\lib\site-packages\matplotlib\backends\qt4_editor\formlayout.py", line 59, in <module>
from PyQt4.QtCore import (Qt, SIGNAL, SLOT, QSize, QString,
ImportError: cannot import name QString

From ccordoba12 on 2011-05-01T20:26:20Z
I've now added it to the editor. It's working better than what I expected. For example, it's working on multi-line line statements such as this one:
from PyQt4.QtGui import (QAction, QAbstractTextDocumentLayout,
qAlpha, QColor)
Besides, I've been investigating the slowness issue: it's only noticeable (again, only on old computers) when you're trying to get the list of all modules in your PYTHONPATH for the first time in your session. It could be annoying though, because the widget could take 2 or 3 seconds to appear.
I have a solution for this based on the work of the Ipython guys. I hope to publish it on the next days.

From pierre.raybaut on 2011-06-04T13:05:53Z
This traceback means that Matplotlib is trying to import QString which does not exist because v2.2dev is using PyQt API #2 -- and spyderlib has been imported in IPython's process (probably because the Matplotlib patch is enabled -- try to disable it, and it should work).
As for your code, I have to check it out... still haven't got the time yet. But will do very soon!

From<EMAIL_ADDRESS>on 2011-06-08T02:27:42Z
Ran into the same problem as described by Carlos. A long trace ending with:
ImportError: cannot import name QString
I can confirm that disabling the Matplotlib patch (tools > preferences > console > external modules) solves that problem.

From pierre.raybaut on 2011-06-25T05:45:55Z
BTW all your issues with PyQt4 API (QString related errors) should be fixed as Spyder v2.1 (default repository) is now compatible with both API 1 and 2 (and even with PySide, partly on Windows, almost completely on Linux).

From ccordoba12 on 2011-06-27T17:27:29Z
Thanks, I'm really glad you like it! I checked the new 2.1 on Windows and the QString problem disappeared. Great work to you too!
I'm reopening this issue because I would like to discuss one thing a bit further. I don't know if you noticed, but I included two libraries from the Ipython project to speed up these kind of completions on old computers (in utils/external). I was having second thoughts on this because it's known that linux distros don't like this kind of behavior, i.e. to use bundled libraries of other projects.
What do you think about it? Should we leave them or better add a warning telling the user to install ipython to speed things up?
Status: Started

From pierre.raybaut on 2011-06-25T06:23:17Z
Carlos, I've just merged your clone to the main repository!
I have tested the feature very quickly but it seems to work nicely.
Great work, Carlos!
Status: Fixed

From ccordoba12 on 2011-10-07T13:42:59Z
I think we should leave those modules, especially now that you're trying to distribute Spyder as a self contained package.
Labels: Cat-CodeCompletion

From pierre.raybaut on 2011-07-04T13:25:49Z
Yes, I'm aware of these external modules.
And you are right regarding most Linux distributions policy. For Debian for instance, I was asked to be very careful about this: that's why I didn't include pyflakes or rope inside Spyder's source package.
Pros:

It would be cleaner to remove those modules for Linux package maintainers.
It would also mean less code to maintain.

Cons:
3. As pyflakes or rope tend to be very stable and move very slowly, it is quite confortable to build a library on top of them. On the contrary, I wouldn't do so with IPython since compatibility is regularly broken between releases.
4. Moreover, the IPython package import process is not as clean as it should be (after all it's not meant to be a library).

From pierre.raybaut on 2011-10-11T10:34:31Z
Ok, let's close this issue then.
Status: Done


Chapter number styling

It would be handy if chapter numbering could be customized to use, e.g., the upperroman numbering style.

If you need this capability, you can either extend the converter or override the sectnum method of the Section class. This is not a feature we are considering right now for Asciidoctor and its converters.
If you need help with how to customize Asciidoctor or Asciidoctor PDF, please ask in the project chat at https://chat.asciidoctor.org.


How to use echo server in source code?

Hi,
Reference figure as follows.
Is there use "cmake ./" and than "make insstall" can be install echo server to raspberry pi?
If it does, how to remove it after test?
Thank you

.

Hi,
I try "cmake" & "make" build this test project, it generates an executable "sio_test". There is just show "All tests passed" after execute, not the test echo server!?
How to buile/use a echo server in example?
Thank you.

Hi, this is not an example. This is the code to generate the test cases. To see an example please go to the examples folder: https://github.com/socketio/socket.io-client-cpp/tree/master/examples/

Hi,
There was client source code in example, I want try this client function so I need a test server.
I see echo server in test folder, thus that is test server can be test client, I think.
Build example client code is ok, how to test it?
Thank you.

For the test server you need to use the javascript library socketio/socket.io and create a server there. This library is client only and cannot be used as a server


Datatype destructor declaration

In GitLab by @tpaluszk on Mar 30, 2018, 11:16
In current version it's not obvious by looking only at Datatype definition if it's destructor is virtual or not, adding override keyword would fix this problem.

closed via merge request !116


Build improperly re-packages NuGet files

The build cracks the Nuget pacakges, signs them, then repackages.
When it does this, it used a "/" instead of a "".
Replace the complicated powershell script with:
ZipFile.CreateFromDirectory(folder, nupkg);

The impact of this is that our signed NuGet packages likley don't work properly on Linux, as they're not correctly packaged.

Maybe this is related to #981

@tomlm resolved this. Root cause is an issue in the powershell script that creates the zip file for the Nuget. It uses the incorrect "/," and didn't work on Linux based systems.


Improve the Ui of the buy me coffee as well Happy Client Works

Try to improve the  UI and make  it responsive

@Vikash-8090-Yadav please assign this issue to me

Start working on this @Bhavika-14

@Bhavika-14 if this issue is solved then please close this Issue as completed !!

@Vikash-8090-Yadav
If @Bhavika-14 isn't presently able to work on this issue, please assign it to me.

#10

@Bhavika-14 if this issue is solved then please close this Issue as completed !!

Yes, it is completed.  #10


OAuth2 ClientCredentials Flow Support

Problem statement
In the current implementations we are not able to use ClientCredentials flow. AFAIK, I could not see an implementation for this flow.
If it is not supported, can we contribute and implement it? It is highly required by our clients to use our application's swagger page.

is there any info on this? I'm also curious


Can't submit Application service after created a new tier

:question: General Issue
The Question
Can't submit Application service after created a new tier.
I have created a new tier.
But when I submit Application service with default tier or new tier.
It shown a Error : Errors in form: Service main Configurations compute Tiers [tier1]
I just follow the guide after create a tier: https://github.com/awslabs/aws-saas-boost/blob/main/docs/getting-started.md#step-5---configure-tiers-and-application-settings
Maybe it is a bug?
Environment

AWS SaaS Boost Version: {"tag":"v2.2.3","commit":"213eccb","describe":"v2.2.3-1"}

Other information

Under tier settings have you selected the compute choices for each tier (even if the green check mark is decorating the input widget)?

Under tier settings have you selected the compute choices for each tier (even if the green check mark is decorating the input widget)?

Yes, I have posted a GIF FYI (about 2min30s ), it looks like a UI Bug.


Timeline: post link problem with hash symbol

Please re-open this.
Now a similar bug occured: I could not add the following link because of the #:
https://pluralistic.net/2021/04/02/innovation-unlocks-markets/#digital-arm-breakers
-> https://pluralistic.net/2021/04/02/innovation-unlocks-markets/#
Can you fix this, too?
Originally posted by @achimwagenknecht in https://github.com/unaio/una/issues/2936#issuecomment-812840773

Thank you!


Uniswap demo

What was wrong?
We need some contracts for the Uniswap demo.
How was it fixed?
Copied the Solidity implementation and translated the contracts to Fe.
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

Codecov Report

Merging #179 (f10427a) into master (8b00838) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   77.93%   77.96%   +0.03%
==========================================
  Files          45       45
  Lines        3300     3300
==========================================
+ Hits         2572     2573       +1
+ Misses        728      727       -1

Impacted Files
Coverage Δ

compiler/src/abi/elements.rs
74.64% <0.00%> (+1.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b00838...f10427a. Read the comment docs.

Codecov Report

Merging #179 (f10427a) into master (8b00838) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   77.93%   77.96%   +0.03%
==========================================
  Files          45       45
  Lines        3300     3300
==========================================
+ Hits         2572     2573       +1
+ Misses        728      727       -1

Impacted Files
Coverage Δ

compiler/src/abi/elements.rs
74.64% <0.00%> (+1.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b00838...f10427a. Read the comment docs.

Still a few small things I want to clean up and features that need to be documented, but I thought it would be nice to get some feedback before the weekend.

Still a few small things I want to clean up and features that need to be documented, but I thought it would be nice to get some feedback before the weekend.

@cburgdorf , core functionality seems to work. There are a few more things that we should try to get done before April, tho. These things are documented in TODO comments that link to issues.


custom tick font size

add arguments to Ticks() to set font family and size

just assign to settings.ticks.font


refactor(config): make config a global instance

Allows us to easily access moe's config on a case-by-casis, and removes the need to annoyingly pass it to each plugin via hooks.

Codecov Report

Merging #31 (c8216a5) into master (6a4d960) will decrease coverage by 5.33%.
The diff coverage is 74.28%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   98.39%   93.05%   -5.34%
==========================================
  Files          22       22
  Lines         994      994
==========================================
- Hits          978      925      -53
- Misses         16       69      +53

Flag
Coverage Δ

integration
?

unit
93.05% <74.28%> (+0.60%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


getInstanceId return null

hello,
I have used, this plugin : https://github.com/fechanique/cordova-plugin-fcm, and it works correctly.
But your plugin provides support for a more important part of Firebase system.
So I Try to migrate to your solution.
However, I cannot get the Firebase Token, function return "null", and I can't see any  error in DDMS.
Do you see where  can be the problem ?

OK , when there is no connection or when sender id is invalid, plugin return null.
I think the plugin should throw an error in this case.
do you agree ?

the firebase sdk does not throw an error so I don't agree that the plugin should change the behavior and do that on its own.


docs: add some downstream apps in user doc

Description
This PR add 4 downstream apps of OpenDigger in the user docs.
Resolved issues
No.
Before submitting the PR, please take the following into consideration

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
[x] Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
[x] The description should clearly illustrate what problems it solves.
[x] Ensure that the commit messages follow our guidelines.
[x] Resolve merge conflicts (if any).
[x] Make sure that the current branch is upto date with the main branch.

/preview


package not available to download getting 404 error

Tried to download the package using https://s3.eu-west-2.amazonaws.com/nexus-cli/1.0.0-beta/linux/nexus-cli
Getting 404 forbidden error, is till package available in the path

same issue

11 days and no answer. It should be untrusted software.

It is even 403 Forbidden to me

可以用迅雷下载


CodeGenerator should set TextualField property for foreign ID fields

This property is not set automatically, so to find TextualField for an ID field, we do a linear search. It is not very effective and might give wrong results.
We should set it automatically on row code generation.

It sets TextualField attribute now.


Key error 1

Thanks for your great work!But I met a error when training.
When I train my custom data,it shows as below.
I dont know why it happened.

Seems like a error when loading colmap data.

Seems like a error when loading colmap data. Would you mind sharing your images dir and sparse dir?
my sparse is pre-calculated
my data is as followng:

here is my sparse

this is sparse/0

Yeap. Could you share a screenshot of the content in sparse/cameras.txt

The colmap version I'm using initializes the first CAMERA_ID as 1 instead of 0. One solution could be replace the key '1' with '0' in colmap.py to avoid this error

Thank you!I will try it!

Thank you!It reall works for me.

Sorry to bother you so many times,I want to know  if this program affect the operation of filter_colmap.py?

The colmap version I'm using initializes the first CAMERA_ID as 1 instead of 0. One solution could be replace the key '1' with '0' in colmap.py to avoid this error

filter_colmap.py relies on colmap for its functionality. Since we don't implement a separate loader in filter_colmap.py, the version of colmap shouldn't have any influence on this program.


Feature: Feedback - Offboarding experience with pizza clean or pizza offboard

Suggested solution
Some early feedback we've gotten has been around the "offboarding experience" as it relates to GitHub resources and generating codeowners files.
Scenario: let's say an engineering team on GitHub maintains the following sauced config file:
attribution:
  open-sauced/engineering:
    -<EMAIL_ADDRESS>    -<EMAIL_ADDRESS>
Where commits authored by john and brandon get attributed to the @open-sauced/engineering GitHub team in the CODEOWNERS file.
Let's say that someone leaves the company and the file gets updated to:
attribution:
  open-sauced/engineering:
    -<EMAIL_ADDRESS>
Now, those (and future) commits authored by john won't appear as part of the @open-sauced/engineering team attribution in the CODEOWNERS.
But, there still may be issues assigned to john on GitHub or other resources (like the GitHub team) that john needs to get offboarded from. A subsequent pizza clean<EMAIL_ADDRESS>or pizza offboard ... command could be used to remove that user from those resources on GitHub.

We'd also want to think through this experience with users who are not operating on GitHub since the pizza generate codeowners command attempts to be as agnostic as possible.

Initial thoughts:

Base command pizza offboard <usernames/emails>: removes the associated User(s) via name/email from .sauced.yaml attribution file; regenerate the CODEOWNERS after offboarding in the same command
GitHub/Org Platforms can be turned into a follow up issue as we find solutions for a mostly agnostic offboarding throughout an organization.

I'd like to try my hand creating the base command both automatic and interactive mode, where in both can have multiple users defined to remove on config and CODEOWNERS file! 🙋♀


More control over boot script injection

If you've built for variants or deal with certain broken browsers, you want to control how (or which) script is injected into the template boot/index.html.
Currently there's no way to i.e. load the script via boot.js?42 to trick a broken caching mechanism. Or even load a variant boot-webkit.js instead. Where the variant type is detected via JS on load time.

@johnspackman Does this still hold true? If yes, @cajus, is it still a relevant problem for you or one that can be addressed later?

This is solved in that the source/boot/index.html can be used to provide a custom index.html; that .html file could (for example) inject it's own <script> tag to load boot.js, and so can add boot.js?1234 or perform any other kind of dynamic changes.


Uncaught TypeError: Cannot read property 'itemForUri' of undefined

[Enter steps to reproduce below:]

...
...


Add support for PTX Wireless Switch

"Mesh Wireless Switch", "PTX-AK1-QMIMC", "090615.remote.akswr1"
"Mesh Double Wireless Switch", "PTX-AK2-QMIMB", "090615.remote.akswr2"
"Mesh Triple Wireless Switch", "PTX-AK3-QMIMB", "090615.remote.akswr3"

resolved #1358

Thanks!

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v4.0.6


README: Fix typo

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@87b37e3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage          ?   23.88%
=========================================
  Files             ?       10
  Lines             ?     2181
  Branches          ?        0
=========================================
  Hits              ?      521
  Misses            ?     1660
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b37e3...8021c49. Read the comment docs.


”Ibănești”, ”Blidireasa”, ”Brădețelu”, ”Dulcea”, ”Ibănești-Pădure” are listed in the drop-down menu

Description:
When user writes ”Ibănești”, ”Blidireasa”, ”Brădețelu”, ”Dulcea”, ”Ibănești-Pădure” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Ibănești"

Expected results
The location appears in the drop-down menu as "Sat Ibănești, MUREȘ (Ibănești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Dulcea"

Expected results
The location appears in the drop-down menu as "Sat Dulcea, MUREȘ (Ibănești)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Ibănești-Pădure"

Expected results
The location appears in the drop-down menu as "Sat Ibănești-Pădure, MUREȘ (Ibănești)".


Domain Sockets

Description
Configuring domain sockets to use Lind's user space pipes
joint PR from work by @justyoyo123 @TristanB22 @yizhuoliang @RusherRG and @rennergade
Fixes # (issue)
This changes domain sockets to use a set of lind pipe internally in user space as well as refactors networking calls to clearly demonstrate each type of socket
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Added tests in ipc_tests
Additional tests on lind_project branch
Working postgres/LAMP/pgbench
Checklist:

[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

Fantastic work! The modifications not only make the project compatible with the latest version of Rust but also enhance its adaptability to a broader range of tools. But it generates 8 warning with rustc 1.75.0-nightly:
Example warnings:
warning: call to `.clone()` on a reference in this situation does nothing
  --> src/interface/comm.rs:74:57
   |
74 |                 let pathslice = pathiter.next().unwrap().clone();
   |                                                         ^^^^^^^^ help: remove this redundant call
   |
   = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed
   = note: `#[warn(noop_method_call)]` on by default


cancelling request

Is it possible to cancel a request once sent (say, the db is really big, and I forget to add a limit).
ctrl+C does not seem to work for me (I use OSX). Thanks in advance.

OSX, you should be able to use the built-in job control functions.

Sorry, the problem lied somewhere in the ssh connection, not doing anything with csvkit. Now ctrl+C works as expected. Thanks for developing the tool I really like it.


Improving gaming since 2000's ;)

I want all the achievements!

Show your victories to the world!

A L R E A D Y     D O N E .
....

A L R E A D Y     D O N E .
....


Unable to resolve the template type TFlatMapKey in call to method

Larastan Version: 2.6.4
--level used: 9

Description
I don't quite know how to set the type of TFlatMapKey and TFlatMapValue, this question makes me very confused.

The type of the roles attribute is already declared.

How should I avoid this error?

the flat map key and flat map value are the results of the closure, not whats passed in, so whatever the result of ->get() is, is not accurately typed enough
the @phpstan-ignore-next-line will probably be hiding your real issue

Can this be closed?


Caching sha2

What problem does this PR solve?
For improved compatibility with MySQL 8.0 TiDB needs to support the caching_sha2 authentication method.
This implements the validation of passwords for this authentication format.
Related:

https://github.com/pingcap/tidb/issues/9411
https://github.com/pingcap/parser/pull/1227 (this PR contains a commit for that PR)

What is changed and how it works?

Split out mysql_native_password related code from auth/auth.go
Added caching_sha2 code.

Check List
Tests

Unit test

Side effects

Increased code complexity

/LGTM

I think we should clone this PR and continue with #1236 which includes the work from this PR

/LGTM

I'd rather merge this on first, 400 lines changes is already quite large.
Generally, a single PR more than 300 lines makes a hard time for the reviewer...
You can rebase master and update https://github.com/pingcap/parser/pull/1236 then?

/merge


Update index.md

add location of teams powershell module install

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/docs-conceptual/index.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Introducing force multipliers to liberation

In combat there are force multipliers; APCs, Tanks, Gunboats, Gunships, etc'.
My suggestion is adding the force multipliers to all units inside said vehicle and blending it in the calculation for sector capturing.
For example:
10 infantry
vs
2 tanks manned by 4 men, 4 APCs containing  infantry + 8 crew members, 1 gunship with 2 crew members and 10 infantry men
lets say tanks are a force multiplier of 10, APCs are a force multipliers of 5 and a gunships are a force multiplier of 15
2(tanks) * 10 = 20
20 + 4(APCs) * 5 = 40
40 + 1(gunships) * 15 = 55
55 + 10(infantry outside vehicles) = 65
65 total force from the capturing team and
10 total force from the defending team
(65/(10 + 65)) * 100 = 86% force advantage for attackers
note that infantry inside vehicles that aren't able to fight are not considered a force, until they get out of the vehicle they won't be a part of the calculation
this is only an example and the number of the force multiplier can change or even be a parameter in the mission

The template you see after selecting an issue type isn’t a training for ctrl+a and del by the way.
We’ll keep this in the suggestions category and have a closer look as soon as we’re start implementing the enemy in 0.97.
Also have a look at #329.


fix: migration to rename actions was wrong

Description
Migration was ignoring actions that didn't end with _number which meant it created duplicate action names.
Note: the fixed migration has already been applied on prod.
Risk

Deploy Plan

🙏🏻


Release v0.4.0

It's time to do another release, we should test and document upgrade steps for all platforms and components etc.
This should be closed by a PR like (#740) including the changelog and upgrade instruction.

Closed by #910


Android

Does this support android and ios ?

No it doesn't it's just for windows, Mac and Linux and one more thing it's a standalone dart library and should not be used with flutter


Tracked files showing as untracked in SCM

Issue Type: Bug
In the file explorer there are three files that are tracked by SCM (git) but show as untracked, with a U next to them. They are not in my .gitignore file and show in the git log.
for example:
git check-ignore .editorconfig
outputs nothing
however the file is both Green and has a 'U'
VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:34:57.037Z)
OS version: Darwin x64 19.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4000)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
16.00GB (1.20GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (34)

Extension
Author (truncated)
Version

Bookmarks
ale
11.0.0

better-toml
bun
0.3.2

macos-modern-theme
dav
1.6.6

xml
Dot
2.5.0

EditorConfig
Edi
0.14.4

vscode-great-icons
emm
2.1.47

json-tools
eri
1.0.2

markdown-table-formatter
fcr
2.0.3

elixir-ls
Jak
0.2.25

plantuml
jeb
2.13.6

docthis
joe
0.7.1

Kotlin
mat
1.7.1

vscode-elixir
mjm
1.1.0

vscode-docker
ms-
1.0.0

atom-keybindings
ms-
3.0.6

Go
ms-
0.13.1

vscode-graphql
Pri
0.2.14

java
red
0.58.0

vscode-xml
red
0.10.1

rust
rus
0.7.0

scala
sca
0.3.9

metals
sca
1.8.0

crates
ser
0.4.9

markdown-preview-enhanced
shd
0.5.2

vscode-open-in-github
sys
1.13.0

vscode-mermaid-editor
tom
0.4.4

vscodeintellicode
Vis
1.2.6

vscode-java-debug
vsc
0.25.1

vscode-java-dependency
vsc
0.9.0

vscode-java-pack
vsc
0.8.1

vscode-java-test
vsc
0.22.2

vscode-maven
vsc
0.21.0

vscode-icons
vsc
10.0.0

debug
web
0.24.0

What does git status -u return?

$ git status -u
On branch dev
nothing to commit, working tree clean

Restarting VS Code fixes the issue.

Does it fix it forever? Can you still reproduce?

So far so good. I am unable to reproduce.

On Apr 3, 2020, at 1:56 AM, João Moreno<EMAIL_ADDRESS>wrote:

Does it fix it forever? Can you still reproduce?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Build on Ascent

@Rombur @NickRF
modules: gcc/6.4.0 cuda/9.2.148 boost/1.66.0 cmake/3.12.2 netlib-lapack/3.8.0
You will need to define the following two env variables:

TRILINOS_DIR pointing to the Trilinos source directory with DataTransferKit symlinked/cloned into it
You may directly use BENCHMARK_ROOT=/gpfs/wolf/gen113/proj-shared/qdi/opt/benchmark unless you really want to build it yourself.

bsub -P GEN113 -nnodes 1 -W 20 -Is /bin/bash


Fix entrypoint hanging when launcher crashes

These changes allow the entrypoint to terminate if the Northstar launcher crashes, allowing proper auto-restart functionality with docker-compose. Since sendTerminate(true) is deferred to the end of n.Run(), extra calls within Run() are not required. Also, initialising Xrdb now removes old lock files, which in my case were preventing the docker container from restarting successfully.

Turns out this change brings other issues to light, at the moment I am looking at why the watchdog is not receiving updates for the window title and therefore stopping the server:
Error: Failed to run server: watchdog did not receive a title update in time

I have increased the watchdog timeout from 5 seconds to 1 minute, which is enough time for the launcher to update its title after loading a new map. Also, the PTY no longer outputs double newlines caused by converting "\r\n" to "\n\n".


MTL-1769 - Refactor create switchmetadata

Summary and Scope

Fixes MTL-1769

Issue Type

Bugfix Pull Request

Prerequisites

[x] I have included documentation in my PR (or it is not required)
[x] I tested this on internal system (x) (if yes, please include results or a description of the test)

Risks and Mitigations
Feature not in production yet.

This also closes MTL-1751

This also closes MTL-1751

Not yet. There are some places that are using the old package yet. I'm planning to work on these items in the next days.


[FEATURE]  ui show exact time, not only "xx days ago"

Is your feature request related to a problem? Please describe.
From-now relative time is not enough when multi snapshot/backups need a match.
For example some app need 3 backup volumes at same time: db-disk, cache-disk, config-disk
Describe the solution you'd like
show time in exact format,  "xxxx-xx-xx hh:mm:ss"

show it when mouse hover "xx days ago" text
offer an option to disable from-now time, or another custom column
show in Volume/backup detail page

Describe alternatives you've considered
Additional context
for current version, the exact time can only be seen in ui:

Volume - Snapshots and Backups, when mouse hover icons

Just to confirm. You are referring to the time in this UI page, right?

We can show the exact date/time as a tooltip.

Do we want to support a setting item to allow the user to choose the format of the time display. For example type 1 xx ago type 2 xxxx.xxx.xxx. @yasker

@smallteeths Don't need to. I think a tooltip would be enough.

Validating with latest longhorn mater-head images(longhorn-ui: 6cbf796)
With the new design, now moving mouse cursor over the human-readable time it will show full datetime as tooltips:

Validation - Passed (master images 2021-08-06)
Any columns with the X time ago will had the datetime tooltips:


chore: bdd-spring-1590202036 to 0.0.1

chore: Promote bdd-spring-1590202036 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Specify a correct unit description

The systemd unit has an incorrect specification. The intent of the description is as per systemd documentation (https://www.freedesktop.org/software/systemd/man/systemd.unit.html):
Description=¶

    A human readable name for the unit. This is used by systemd (and other UIs) as the label for the unit, so this string should identify the unit rather than describe it, despite the name. "Apache2 Web
            Server" is a good example. Bad examples are "high-performance light-weight
            HTTP server" (too generic) or "Apache2" (too specific and meaningless for people who do not know Apache). systemd will use this string as a noun in status messages ("Starting
            description...", "Started
            description.", "Reached target
            description.", "Failed to start
            description."), so it should be capitalized, and should not be a full sentence or a phrase with a continous verb. Bad examples include "exiting the container" or "updating the database once per
            day.".```

This is what you see in the log right now
Jul 04 16:59:42 Verleihnix systemd[1]: Starting Sets the offset to 3 °C, so the new trip point is 97 °C...
Jul 04 16:59:42 Verleihnix systemd[1]: Started Sets the offset to 3 °C, so the new trip point is 97 °C.

Agreed.


Simplified RetryPolicy with one predicate for retry and abort

This commit had following modify items:

combine retryableXXXXXs and abortableXXXXXs into retryablePredicates, abortablePredicates
Allow duplicate calling on retryXXXXX or abortXXXXX like

RetryPolicy retryPolicy = new RetryPolicy()
  .retryOn(ConnectException.class)
  .retryOn(SocketException.class);

Please let me know if any and feel free to discard the pull request if it's not a good design or if it would introduce some side effect that may cause some trouble.
BTW, I think the project is an awesome project with useful functionality and good coding style and design.
And I would like to keep contribute on it!
Thanks.

Thanks for this! I'm in the middle of some other changes, but will have a look soon.

Very nice contribution. Thank you!

Closes #10 .


[WIP] Sway workspaces: Configure output from which workspaces are shown

This change allows configuring a sway workspaces module that only shows workspaces from one specific output, even if it's not the current output.
Use Case
My use case is that I have 3 monitors but only one bar on one of the monitors. That bar shows all workspaces, but to have it organized better, I wanted to visually differentiate 3 workspace groups so that it is easily identifiable what workspace is on what output. I have 3 workspace modules configured something like this:
    "sway/workspaces#out1": {
        "for-output": "DP-2"
    },
    "sway/workspaces#out2": {
        "for-output": "HDMI-A-1"
    },
    "sway/workspaces#out3": {
        "for-output": "DP-1"
    },

This style gives each group a different underline color:
#workspaces.out1 button {
    box-shadow: inset 0 -3px #dc0024;
}

#workspaces.out2 button {
    box-shadow: inset 0 -3px #00b41e;
}

#workspaces.out3 button {
    box-shadow: inset 0 -3px #dcdc00;
}

Screenshot

Further comments
If there is a desire to include this feature, then there probably is a bit more to be done before it can be merged:

Documentation
Possibly the same in other workspace modules, not just sway (where would that apply?)

Finally, I'm not that experienced with C++, so if you take issue with anything I've written, don't hesitate to say so.

Sorry for this long delay 😓
Nice addition!
If you have time to add it to the man and Github wiki, aswell as checking if it's relevant to add this feature to other workspaces modules.


changed gain_scale float -> list (idx/joint)

Implemented gain scale changes for each joint through the config.

@Jdvakil  - - can we get this rebased on main and PR send to dev branch.
Make sure that the tests above are passing.


Issue with k8s.io/docs/getting-started-guides/fedora/fedora_manual_config/

This is a...

[ ] Feature Request
[ x] Bug Report

Problem:
The documentation is out to dated, with Kubernetes 1.10 is mandatory configure the kubelete service with the option --config and define a config file that is not clear how it should be in order to add a new node to the cluster.
Proposed Solution:
Add an example in the documentation of the new config file format
Page to Update:
https://kubernetes.io/...

/assign

@danielchg Is this something that you've been able to do successfully yourself? If so, could you share your working config?


snapshot release possible ?

is it possible to have 3.1.0-SNAPSHOT release ?
Basically my app works with akka ~2.6 and installing baker-3.0.3 isn't compatible.
Thanks !

Hi madmantalking,
Several newer version have since been released, so I imagine this issue is no longer relevant.
If it is, please comment or make a new issue.