Replace string literals with symbols or frozen strings

Context
Ruby strings take up new spots of memory every time they are used. Generally it's not a problem but the memory adds up at scale. Symbols and frozen strings will always occupy the same spot in memory, which reduces the memory load and increases performance.
This Change

Convert some of the strings to symbols. I did this in places that it made sense for them to be symbols anyway (e.g. the strings that were getting to_sym-ed)
Freeze the strings that will not be changing and are used multiple times per call
Convert the array of arrays to hashes and use named arguments for the key and value when iterating over the hashes.

@jnunemaker @aroben @vmg can you take a look at this and let me know what you think/if I'm missing something? 🙏 💖

fyi @pengwynn who is probably curious about this work

It's a good start @janester! I'm afraid that saving these allocations won't do much with the amount of gsub and string duplication there's currently in the code. I think the next step would be to switch over to bang methods and incremental string composition, like @aroben did for our fork of statsd. :)

Thank you for the improvement @janester !
LGTM, will be part of the next release (~ in the next 2 weeks).

Thanks for the review @vmg! 💖

I think the next step would be to switch over to bang methods and incremental string composition, like @aroben did for our fork of statsd. :)

👍 I'll make a new PR with those changes 😊
--

LGTM, will be part of the next release (~ in the next 2 weeks).

Thanks @degemer! 👍 🎉


[tutorial] Add ord tutorial

Description of the tutorial
... Python built-in function ord()
Do you want to be assigned to work on this?
(mark [x])

[x] YES
[ ] NO

Optional: Any additional info you want to add
...

Please assign me this issue

You're assigned now @Prakhar9450 :)

Any update on this issue @Prakhar9450 ?

Still open for anyone to write a tutorial!


Add a reindex_like (or reorder_like)

Topologies may be equivalent, but with a different ordering. A method to reorder data to another equivalent topology would be useful in this regard.
Also in support of #152.

Ideally this can be done with just a number, in that case it's essentially just an isel operation -- and this would already work.
However, given two (2D) topologies, it is also possible to derive the original ordering and derive an index for the second topology.


In 0.2.14 $state.go not work if we have bool and object in params.

Hi Plunker with issue.
It not throw any error just not working. In 0.2.13 this worked well

duplicate of #1915


puller(ticdc): should split all update kv entries in puller when sink module is in safe mode

Previous Problem
In https://github.com/pingcap/tiflow/pull/10919, we addresses the issue of downstream data inconsistencies caused by the potentially incorrect order of UPDATE events received by TiCDC.
Take the following SQL statements as an example:
CREATE TABLE t (a INT PRIMARY KEY, b INT);
INSERT INTO t VALUES (1, 1);
INSERT INTO t VALUES (2, 2);

BEGIN;
UPDATE t SET a = 3 WHERE a = 2;
UPDATE t SET a = 2 WHERE a = 1;
COMMIT;

In this example, the two UPDATE statements within the transaction have a sequential dependency on execution. The primary key a is changed from 2 to 3, and then the primary key a is changed from 1 to 2. After this transaction is executed, the records in the upstream database are (2, 1) and (3, 2).
However, the order of UPDATE events received by TiCDC might differ from the actual execution order of the upstream transaction. For example:
UPDATE t SET a = 2 WHERE a = 1;
UPDATE t SET a = 3 WHERE a = 2;

Previously, TiCDC just splits these UPDATE events into DELETE and INSERT events before sending them to downstream. After the split, the actual execution order of these events in the downstream is as follows:
BEGIN;
DELETE FROM t WHERE a = 1;
REPLACE INTO t VALUES (2, 1);
DELETE FROM t WHERE a = 2;
REPLACE INTO t VALUES (3, 2);
COMMIT;

After the downstream executes the transaction, the records in the database are (3, 2), which are different from the records in the upstream database ((2, 1) and (3, 2)), indicating a data inconsistency issue.
To fix this problem, we need a mechanism to reorder the DELETE and INSERT events after the split.
For example, if we can guarantee all DELETE events are executing before the INSERT events in the same transaction. The data inconsistency problem can be avoided.
 BEGIN;
 DELETE FROM t WHERE a = 1;
 DELETE FROM t WHERE a = 2;
 REPLACE INTO t VALUES (2, 1);
 REPLACE INTO t VALUES (3, 2);
 COMMIT;

After the downstream executes the transaction, the records in the downstream database are the same as those in the upstream database, which are (2, 1) and (3, 2), ensuring data consistency.
Previous Solution
But the goal to reorder the DELETE and INSERT events after the split is not easy to accomplish.
The whole process of TiCDC processing a row of data and sending it to the MySQL compatible downstream is as follows:

TiCDC obtains KV data from TiKV and stores it in the local hard disk and sorts it according to the transaction CommitTS and event type (DELETE > UPDATE > INSERT);
The Sink module pulls KV data from the local hard disk in units of transactions and decodes the KV data into Event data (including the column name, type, data, etc. of each column) according to the Table Schema;
The Sink module translates the Event data into SQL and sends it to the downstream;

Splitting the UPDATE event in the sink module can ensure that only the events that update the primary key or the unique non-null unique key are split. But in sink module the event data has been fully loaded into the memory, so it is impossible to load all its data into the memory for splitting and then sorting in large transaction scenario;
If the UPDATE event is split before TiCDC writes the KV data to the local disk, it is hard to know whether the event updates the primary key or the unique non-null unique key, so we can only choose to split all UPDATE events. However, splitting all UPDATE events will lead to performance degradation in some scenarios (sysbench oltp_update_non_index performance degradation of about 41%).
Therefore, we adopted a compromise solution in https://github.com/pingcap/tiflow/pull/10919: When a new table sink start to write data to downstream, we fetch the current timestamp from pd as replicateTS, and we just split all update KV entries which commitTS is smaller than the replicateTS.
After the fix, when using the MySQL sink, TiCDC does not split the UPDATE event in most cases. Consequently, there might be primary key or unique key conflicts during changefeed runtime, causing the changefeed to restart automatically. After the restart, TiCDC will split the conflicting UPDATE events into DELETE and INSERT events before writing them to the local disk. This ensures that all events within the same transaction are correctly ordered, with all DELETE events preceding INSERT events, thus correctly completing data replication.
Current Issue
In previous solution, we rely on restarting changefeed automatically to fix data conflicting error and prevent data inconsistency problem caused by incorrect order of UPDATE events in the same transaction received by TiCDC.
Although after restart, puller can split the conflict UPDATE events and continue to run correctly, and from test we can see that the restart has no noticeable impact on latency, some users may be unhappy with this behavior if their workload has many conflict data which cause changefeed restart occasionally. So we need a workaround to avoid restart if need.
TiCDC has a config known as safe-mode and is default as false currently.
If safe-mode is true,

All INSERT events are translated to REPLACE sql;
All UPDATE events are split into DELETE and INSERT events in sink module(This behavior removed in https://github.com/pingcap/tiflow/pull/10919 as described in the previous Problem part);

Because in safe-mode, performance degradation is already expected(REPLACE is much slower than INSERT), so we suggest a solution to split all UPDATE KV entries before write them to disk when safe-mode is true. Users can enable safe-mode to prevent changefeed from restarting due to data conflicts while also prevent data inconsistency problem to happen.

/type regression


[Widget] Validate necessary information

it would be good if every widget validates its properties and prints an error message, if the user forget to set a required property (example url for api calls)

I think we should the error state to true. This will show the error icon.

development happens in branch

@chrishelgert Which library do you prefer?

@danielbayerlein i am unsure if we need really a library to check if the props are filled or not

@chrishelgert Depends whether you want to check whether they are filled or valid.

@danielbayerlein this are the most popular ones on npm:
https://www.npmjs.com/package/validator
https://www.npmjs.com/package/joi
maybe i try one of this


 E.g. the message of a commit hook. Often the error message scrolls away and I have to find it again
Maybe have different modes, such as a verbose mode and a standard mode that only shows errors?

Won't really fix. Most people want to know exactly what git is doing under the hood.


GPII-3324: some export things I messed up (gpii-infra)

Related to https://github.com/gpii-ops/exekube/pull/21.

I forgot to plumb a variable.

Add support for force_destroy (true in dev, false elsewhere).

LGTM

lgtm

LGTM


♻ refactor(theme): Refactor the token theme

💻 变更类型 | Change Type

[ ] ✨ feat
[x] 🐛 fix
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

+1


Updated the developer link to point to the new hub page.

Replacing with PR on the private repo: https://github.com/MicrosoftDocs/microsoft-365-docs-pr/pull/14806


Inline utilities only used in <relative-time>

In an effort to simplify and reduce the amount of code in this repo we've inlined and simplified code in utils.ts that is only used in one place for <relative-time>.

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.


Edits to Nlayer cylinder documentation

Made some general edits, added in piece on tuple rho values, added examples with multiple rho, tested all tests (they worked except the multiple rho for flux which is an issue we are aware of).

Codecov Report

Merging #23 (ef183b7) into main (46de883) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   48.71%   48.71%
=======================================
  Files          16       16
  Lines        1170     1170
=======================================
  Hits          570      570
  Misses        600      600

Impacted Files
Coverage Δ

...dels/Diffusion Approximation/DAcylinder_layered.jl
99.50% <ø> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Could you please replace the twitter icon with the new X  icon

Foremost ... thank you for the great tool
Could you please replace the twitter icon with the new X Icon.
Some of my customers want to have it replaced, and I use fontello fonts on many web projects.
Love and peace ...  rubbeldecatc

Would be nice if the X icon is availible

That still not changed :(


Add code coverage reporting to Travis CI

(Creating dedicated issue for tracking this work. Comment originally posted in https://github.com/EngoEngine/engo/issues/117#issuecomment-213408780)
The Travis config may be extended to report the lint status of the project. For an example project using this approach, refer to the following goclean.sh script and travis config:

goclean.sh (which is a fork of https://gist.github.com/h12w/0f22736320abe6be71ce).
.travis.yml

The goclean.sh script reports issues from gofmt, goimports, golint, go vet, go test -race and go cover.  Test coverage is optionally reported to https://coveralls.io/.
Note, the secure environment variable is an encrypted version of the COVERALLS_TOKEN environment variable. For a howto, see https://github.com/decomp/decompilation/issues/4#issuecomment-62314749.

Harrison Shoebridge @paked 21:09
@otraore Is this [coveralls] done: EngoEngine/engo#295
I've seen coveralls around the place, so I assume so?
Ousmane Traore @otraore 21:09
It is done BUT
there’s an issue on coveralls side and our badge
as for reporting it’s done in the PR and the page as well
But this is a bug others are experiencing as well.
So you can close the issue.


make irods browser to handle trailing slash and white space properly

Thanks very much, @hyi !

@rayi113 This PR has been merged and beta has been updated. Now an input path with trailing slash and/or white spaces will work as well. Check it out on beta and let me know if you notice any issues regarding this. Thanks!

@hyi Yes, I tried both public and home directories, with and without trailing slash, with leading and trailing white spaces, and that with and without trailing slashes - all combinations worked great, thanks!


performance problem: various table operations

Describe the bug
Some Table operations take multiple hours to complete on large tables, although they should be much faster. When using pandas loc functionality, these operations complete in a few seconds.
These operations include:

[ ] filter_rows
[ ] group_rows_by
[ ] add_rows(Table)
[ ] sort_rows (probably, untested)
[ ] transform_column (probably, untested)

The common problem of these operations are, that the first step is boxing the rows to a pandas Series and wrapping them in a Row object (which both leads to a huge overhead).
Most of the time, the single row objects are only needed to be passed to the lambda function that is provided to these operations.
Possible resolutions:

don't guarantee that a Row is passed to the lambda functions (for filter_rows, group_rows_by, sort_rows, transform_column). Instead only pass a general type that is indexable with Strings (column names), like Mapping[str, Any] to access the values. Maybe also pass the schema, as the other needed operations on a Row object can be handled with a schema.
add_rows could handle adding a whole table as a special case, so they are not split into Rows first, avoiding the problem without changing the interface

To Reproduce

Load a huge dataset with Table.from_csv_file
Run any of the previously mentioned operations
Observe that nothing happens and after a few hours the pipeline still runs

Expected behavior
Faster execution of the listed operations
Screenshots (optional)
No response
Additional Context (optional)
No response

Concrete solution for Table.add_rows (insert at the top of the method):
        if isinstance(rows, Table):
            if rows.number_of_rows == 0:
                return self
            if self.number_of_columns == 0:
                return rows
            different_column_names = set()
            different_column_names.update(set(self.column_names) - set(rows.column_names))
            if len(different_column_names) > 0:
                raise UnknownColumnNameError(
                    sorted(
                        different_column_names,
                        key={val: ix for ix, val in enumerate(self.column_names)}.__getitem__,
                    ),
                )

            new_df = pd.concat([self._data, rows._data]).infer_objects()
            new_df.columns = self.column_names
            schema = Schema.merge_multiple_schemas([self.schema, rows.schema])
            result = Table._from_pandas_dataframe(new_df, schema)

            return result

Fixed in #734 and #738.


Transparent colors

I wanted to set some transparent colors for taffybar through its taffybar.rc. But I don't find any documentation on the correct format for specifying transparencent colors, nor can I find any examples for gtkrc's in /usr/share/themes which uses transparency. I do however see gtk css files with transparency set.
Is it not possible? Could you use a css file to configure taffybar?

What kind of transparency are you looking for?  To see the bar through a widget?  Or do you want to see the desktop through the bar?  I believe CSS themes were introduced in gtk3, while taffybar is still using gtk2.
It might be time for a gtk3 transition, now that gtk3 is more common.

I actually just "ported" taffybar and gtk-traymanager to gtk3 but am still working out the various bugs that arose, but it's running under gtk3 now (you can go look at the changes I made if you want, I'm sure it could use a lot more work).

@nisstyre56 interesting - how many changes are required?  I wouldn't be opposed to switching over, or possibly supporting both.
I've also had some issues pop up with using gtkrc files to color the bar, and I imagine the css approach can't be worse.

@travitch not that many, the changes to the C code are quite straightforward and mostly involve changing stuff that uses the -> syntax to accessors, some headers that are no longer required, and a compatibility fix for constants. See: https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html
The Haskell code is also mostly straightforward, but a lot of functions were removed involving drawing, and I'm not sure if I got it right, and also not quite sure how to handle switching to the css format yet. Also it's crashing seemingly at random while trying to use openDisplay (at some point it will just start failing by returning a NULL pointer), but I think that may be because of multiple monitors, still investigating.

@travitch Initiallly, I was thinking about setting the background color of the panel transparent, rendering the desktop background visible.
@nisstyre56 Cool! I am looking at your code now.

@tusj That would require both the ARGB support from gtk3 and running a separate composite manager, I believe.  I am interested in supporting or switching to gtk3, so this might become possible.

@travitch I have been using some terminals with a transparent background, without running a composite manager, but then the transparency happens between the terminal and the desktop paper, and not on any windows in a layer between the terminal and the desktop. So I believe it would work without a composite manager, but I don't know the internals.

Those terminals are implementing fake transparency manually - they capture the root window pixmap and use it as their background (with suitable filtering).  That is why they can't show windows between the terminal and the desktop.

+1

What is the status of this now?

@nisstyre56 How close is your port to gtk3.
Have you done anything other than https://github.com/nisstyre56/taffybar/commit/b621cc20805c3d724a934373394565e03f6b029c?

@nisstyre56 Do you want someone to take over ?

@PierreR  @IvanMalison  hey, as I recall, I ended up running into a lot of issues porting to gtk3. Considering that the Gtk project is undergoing a lot of changes, maybe it's worth taking a look at rewriting parts of this to support newer versions of Gtk?

@nisstyre56 Yeah that sounds like a good idea, I have some time to take a shot at it right now


history: null-terminate restored history line

Fixes bug where scrolling past a longer line (foobar) before restoring a short line (baz) results in a combined command (bazbar) if the user ends the line without editing it.

Nice work, thank you! But before merging i have to checkout it and think a bit )
Unfortunately i have no time right now, but in 2-3 days i will have.

Replaced by #26.


ch1prempire -> hjaltland stops at j:piria

Might be because of a minecart there, yergo wasn't sure.

Managed to reach j:pend using /dest oasis j:piria j:pend. I think it is safe to assume it yergo was stopped by another minecart.
Note: I've added 2 powered rails to j:pend after it turns towards j:piria as the minecart could barely reach the existing powered rails.

Sounds good. Thanks for taking a look.


Adds helpers for editing text

Adds few helpers around editing text in text editor fields.

These look great, thank you!


feat(ngUpgrade): Auto detect ngUpgrade apps and make the ng12Hybrid f…

…lag unnecessary for most users
Closes https://github.com/angular/protractor/issues/3836

@juliemr All comments addressed!

LGTM


Issue 159 discrete si

Closes #159
Pending #158

Have we changed the serial interval source? why did we do that (I might have forgotten)

Not really, I noticed that Epinow and the australian paper were just using the Nishiura data so that seemed the original source.


Unnecessary log

Hi @jonbarker68,
In the camfit gaintable implementation in Clarity, the function is logging the noiselevel every single time the gain tables are generated. I think this is an unnecessary log information and a bit noisy.
Or, there is a reason for it and we can't remove it?
https://github.com/claritychallenge/clarity/blob/c20c317a27adee88679cdc7125b8d765af65ffbd/clarity/enhancer/gha/gainrule_camfit.py#L482-L484

Sure it can be removed. I expect it was there originally for debugging purposes. Could perhaps change the level to debug?


Updated README, config, and APIs

This change is

@kaizencodes @robwise  @Conturbo  please review.

Hey! big question for @alexfedoseev  @robwise  @Judahmeek regarding hot reloading and webpacker_lite.
Should webpacker_lite be putting in the value of the hot reloading server host:port as part of the rails helper, or depending on the configuration of that from the manifest.json and requiring the setting of the publicPath in both the webpack output and manifest plugin setup.
My gut tells me that it’s better to keep the webpack manifest simpler so it’s really the mapping of output names to possibly fingerprinted filenames.


Requesting making Window.samples public

I have a use case where I want to access the window samples and do the multiplication myself. Currently, the samples in Window struct is private.

You can get it as slice:
https://github.com/klangner/dsp.rs/blob/3f28224b666d1d6a2a4418795e05ed3a27287549/src/window.rs#L24

@klangner, thanks it should work then but I am not seeing in the latest published version dsp = "0.10.1". Have the changes been published to crates.io repo? Sorry if I am not seeing something.

Yes, you are right. It was only in master not in published version.
I have just published a new version 0.10.2 with all changes, so the function as_slice is visible now.

I will close it since I think it is resolved.
Feel free to reopen if there is still problem


Testing facilities generated out of the box

Hi,
I hope new versions of Langium generator will offer the ability to generate testing facilities out of the box, as part of the DSL project.
It was a bit the case with Xtext, with an ***/test package and a parseHelper ready to use https://eclipse.dev/Xtext/documentation/103_domainmodelnextsteps.html#tutorial-unit-tests
As part of my experience with setting such testing facilities (see https://dev.to/diverse_research/testing-your-dsls-in-langium-gp9), I encountered two issues:

lack of understanding of the testing API... there will be a tutorial: https://github.com/eclipse-langium/langium-website/issues/203 and it's super nice!
an integrated and ready-to-use solution with package.json containing a test command, a configuration file of vite, and the boilerplate almost described here https://dev.to/lotes/comment/2aiog or in the post

Not only DSL developers will enjoy a testing facility out of the box and ready-to-use, but it will enforce best practices, and not forcing developers to dig into the API/documentation.
I am seeing it as a "feature" of the langium generator, and perhaps a flag or a configuration option somewhere should be introduced to generate or not testing facilities.
Kudos for the great work!
Mathieu

Contributed with #1298.


401

Looks like its just getting 401's back

@ValkyrieUK @nneal I believe I fixed this issue by setting a few headers, see here: https://github.com/toddwschneider/snapcat/commit/a0e4abaa24de58d934264ebed277ec91ccb147b4

Thanks Todd, that makes sense. I considered spoofing headers but it wasn't necessary at the time. Want to submit that as a PR?
(Please add those headers to the request_media method too, prob best to throw the header hash into a method of its own too)

@nneal no problem, see here: https://github.com/nneal/snapcat/pull/27

Closing this, please let me know if the error still pops up. Thanks @toddwschneider for fixing!

Fantastic cheers


File type suffix

Append the suffix at the end of the name:
pipe => |
socket => =

9906930a26c526fb1fe7a5d052b5262a01b12408


docker restart policy "always" not working when pumba kill the container randomly

Below is my docker compose file, I added restart policy as always for every service. My expected behavior is that when the chaos engineer kill one of the containers, it would automatically restart. However, it now just exit and never restart. The compose file comes from docker official example voting app, you can try to reproduce it :https://github.com/dockersamples/example-voting-app
Maybe this related to https://github.com/alexei-led/pumba/issues/11, but I have tried both signal KILL and TERM and none of them worked.
The log of pumba looks correct:
./pumba --interval=1m --random -l info kill --signal=SIGTERM "re2:^example-voting-app_vote"
INFO[0000] killing container                             dryrun=false id=5fe93ff11e5a6fbb9dc584848159341bc1fb710c747599fa03276f234a3faa19 name=/example-voting-app_vote_1
```signal=SIGTERM

and the container log:

vote_1    | WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
vote_1    |  * Running on all addresses (<IP_ADDRESS>)
vote_1    |  * Running on http://<IP_ADDRESS>:80
vote_1    |  * Running on http://<IP_ADDRESS>:80
vote_1    | Press CTRL+C to quit
vote_1    |  * Restarting with stat
worker_1  | Connected to db
worker_1  | Connecting to redis
worker_1  | Found redis at <IP_ADDRESS>
result_1  | [nodemon] 2.0.22
result_1  | [nodemon] to restart at any time, enter `rs`
result_1  | [nodemon] watching path(s): *.*
result_1  | [nodemon] watching extensions: js,mjs,json
result_1  | [nodemon] starting `node server.js`
vote_1    |  * Debugger is active!
vote_1    |  * Debugger PIN: 861-258-488
result_1  | Sun, 02 Jul 2023 00:48:49 GMT body-parser deprecated bodyParser: use individual json/urlencoded middlewares at server.js:73:9
result_1  | Sun, 02 Jul 2023 00:48:49 GMT body-parser deprecated undefined extended: provide extended option at ../node_modules/body-parser/index.js:104:29
result_1  | App running on port 80
result_1  | Connected to db
example-voting-app_vote_1 exited with code 0

And my compose file
# version is now using "compose spec"
# v2 and v3 are now combined!
# docker-compose v1.27+ required

services:
  vote:
    build: ./vote
    # use python rather than gunicorn for local dev
    command: python app.py
    depends_on:
      redis:
        condition: service_healthy
    healthcheck:
      test: ["CMD", "curl", "-f", "http://localhost"]
      interval: 15s
      timeout: 5s
      retries: 3
      start_period: 10s
    volumes:
     - ./vote:/app
    ports:
      - "5000:80"
    networks:
      - front-tier
      - back-tier
    restart: "always"

  result:
    build: ./result
    # use nodemon rather than node for local dev
    entrypoint: nodemon server.js
    depends_on:
      db:
        condition: service_healthy
    volumes:
      - ./result:/app
    ports:
      - "5001:80"
      - "5858:5858"
    networks:
      - front-tier
      - back-tier
    restart: "always"

  worker:
    build:
      context: ./worker
    depends_on:
      redis:
        condition: service_healthy
      db:
        condition: service_healthy
    networks:
      - back-tier
    restart: "always"

  redis:
    image: redis:alpine
    volumes:
      - "./healthchecks:/healthchecks"
    healthcheck:
      test: /healthchecks/redis.sh
      interval: "5s"
    networks:
      - back-tier
    restart: "always"

  db:
    image: postgres:15-alpine
    environment:
      POSTGRES_USER: "postgres"
      POSTGRES_PASSWORD: "postgres"
    volumes:
      - "db-data:/var/lib/postgresql/data"
      - "./healthchecks:/healthchecks"
    healthcheck:
      test: /healthchecks/postgres.sh
      interval: "5s"
    networks:
      - back-tier
    restart: "always"

  # this service runs once to seed the database with votes
  # it won't run unless you specify the "seed" profile
  # docker compose --profile seed up -d
  seed:
    build: ./seed-data
    profiles: ["seed"]
    depends_on:
      vote:
        condition: service_healthy
    networks:
      - front-tier
    restart: "no"

volumes:
  db-data:

networks:
  front-tier:
  back-tier:

The same thing. There is no point in using pumba at all...


Fix Copying Sent Money Report Action text copies a wrong text

Details

Fixed Issues

coming from https://github.com/Expensify/App/pull/27142
$ https://github.com/Expensify/App/issues/27114
$ https://github.com/Expensify/App/issues/26531
$ https://github.com/Expensify/App/issues/27858
Tests

Open a tab where user A is signed in
Request money from user B
Open a tab where user B is signed in
Open the chat with user A > Click on 'IOU preview component'
Click on 'Pay elsewhere' button
Hover over the new paid elsewhere message
Click on 'copy to clipboard' icon
Past the copied text
Verify that pasted text should reflect what was copied from the message

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as tests above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/77965000/fc105737-1ce4-485a-85fc-2baed7ec0957

Mobile Web - Chrome

https://github.com/Expensify/App/assets/77965000/cb0a035e-d52e-4d08-b909-83bf41e81b98

Mobile Web - Safari

https://github.com/Expensify/App/assets/77965000/df16ba59-57a4-47b8-955d-2f9d1c2eef46

Desktop

https://github.com/Expensify/App/assets/77965000/7850199a-6c5d-4506-9352-12e88cbbc3b0

iOS

https://github.com/Expensify/App/assets/77965000/e8135b60-5884-49d4-ace7-a0c370a60f60

Android

@rayane-djouah seems when payment issued from workspace - copy message is not reflecting

Request money
choose any workspace
Pay elsewhere
Get last message in chat
Copy comment and paste

@rayane-djouah crash on lates main with your changes

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@rayane-djouah looks better but now - getting this

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/3069065/e5e29e67-c185-4c70-8fdc-79e210d3f10f

Mobile Web - Chrome
https://github.com/Expensify/App/assets/3069065/ca2a2542-ae8c-44de-b17a-056ab5a0fd98

Mobile Web - Safari
https://github.com/Expensify/App/assets/3069065/a24eff41-ff0a-4c68-8f38-8ad5ad6c7b7a

Desktop
https://github.com/Expensify/App/assets/3069065/efa159e0-5a7a-46d8-9909-c4eb7307e11c

iOS
https://github.com/Expensify/App/assets/3069065/bb7daf97-07f6-4e50-bfb8-bef7e30d7dd6

Android

I am waiting on the Android build, it's taking some time.

@mountiny @joelbettner I've completed the checklisted.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Issue with collapse component on resizing

I get this error every time I resize my browser. It's an error from the collapse component.

Compilation error:
Uncaught TypeError: Cannot read property 'scrollHeight' of undefined
    at VueComponent.changeHeight (vuesax.common.js?fb9a:11118)
changeHeight @ vuesax.common.js?fb9a:11118

Is there any solution for this? I'm also having similar error

Same.. @west1609 did u find any solution?

Hello,
I found a work around, which is to edit the vuesax.common.js and add these lines from line 10911.
beforeDestroy() {     window.removeEventListener('resize', this.changeHeight);   },
Another solution is to add it to every file in which you use a vs-collapse and call window.removeEventListener('resize', this.changeHeight). Obviously you have to replace this by the instance of vs-collapse-item.
<vs-collapse>
   <vs-collapse-item ref="vsCollapseItem">
    Your code
 </vs-collapse-item>
</vs-collapse>

  export default {

beforeDestroy() {
if (this.$refs.vsCollapseItem) {
    for (let collapseItem of this.$refs.vsCollapseItem){
    window.removeEventListener('resize', collapseItem);
   }
   }
  },
}

Hi, Can someone walk me through how to solve this error, I have been struggling with it.
Thank you in advance

Hi, Can someone walk me through how to solve this error, I have been struggling with it.
Thank you in advance


Add faq document with a curated list of questions

This patch introduces a new faq doc with a list of frequently asked questions about Glance and the design choices.

+2


feat: added regionality support in fscloud

Description
Added regionality support in FScloud profile.
Types of changes in this PR
Changes that affect the core Terraform module or submodules

[ ] Bug fix
[x] New feature
[ ] Dependency update

Changes that don't affect the core Terraform module or submodules

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other

Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.
Your notes help the merger write the commit message for the PR that is published in the release notes for the module.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
Merge by using "Squash and merge".

/run pipeline

/run pipeline

/run pipeline

Could you just confirm how this was tested as well. Thanks.

Could you just confirm how this was tested as well. Thanks.

Looping through all the services, it seems there are only 4 services which do not support regionality.

iam-groups
compliance
user-management
directlink

Attached log file for reference.
TF_apply_08.08.2023-00.50.10.log

/run pipeline

Thanks @Ak-sky - did you actually test the result in a cloud account. eg: testing that access is granted for a given region only and not for the other. For instance, this could be tested with schematics or code engine.

Thanks @Ak-sky - did you actually test the result in a cloud account. eg: testing that access is granted for a given region only and not for the other. For instance, this could be tested with schematics or code engine.

/run pipeline

/run pipeline

/run pipeline

Testing is in progress using Container Kubernetes as service reference in a zone at a specific region and KMS as target service.

Tested with region set as us-south.

Tested with region set as null.

/run pipeline

/run pipeline

Pipeline failed with provider issue, rerunnning.

/run pipeline

/run pipeline


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 619

Questions ?
Please refer to the Backport tool documentation


[STYLE CHANGE] : Make the navbar sticky and attractive to enhance the website quality.

Description:
[Provide a clear and concise description of the style change you are requesting.]
Reason for Change:
[Explain the reasons behind the requested style change, such as usability, branding, or user experience.]
Current Styling:
[Describe the current styling that needs to be changed.]
Proposed Styling:
[Describe the desired styling or changes you would like to see.]
Screenshots or Design Mockups (optional):
[If available, include relevant screenshots or design mockups illustrating the requested style changes.]
Additional Information (optional):
[Provide any additional information that may help in understanding or implementing the style change. This can include any specific requirements or constraints.]

Priority Level (optional):

[ ] Low
[ ] Medium
[ ] High

Timeline (optional):
[Specify any preferred or required timeline for implementing the style change.]
Possible Implementation Approach (optional):
[If you have any suggestions or ideas on how the style change could be implemented, feel free to provide them here.]

plz assign me this issue .


Problem deploying on Heroku

I made web application with flask witch use the api.In my local machine work fine when I deploy to heroku I recive this error message:
2020-12-27T12:07:08.823479+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.6/site-packages/instagrapi/mixins/private.py", line 207, in _send_private_request
2020-12-27T12:07:08.823479+00:00 app[web.1]:     raise LoginRequired(response=e.response, **last_json)
2020-12-27T12:07:08.823663+00:00 app[web.1]: instagrapi.exceptions.LoginRequired: login_required

What will be the problem.It can be something from the api or I have problem with app thanks

Probably you are not logged in and Instagram informs you about it


SW-5885 Removed application result screens

#3065  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite


HADOOP-16557. [pb-upgrade] Upgrade protobuf.version to 3.7.1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
1160
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
65
Maven dependency ordering for branch

+1
mvninstall
1031
trunk passed

+1
compile
973
trunk passed

+1
checkstyle
150
trunk passed

+1
mvnsite
350
trunk passed

+1
shadedclient
1236
branch has no errors when building and testing our client artifacts.

+1
javadoc
322
trunk passed

0
spotbugs
34
Used deprecated FindBugs config; considering switching to SpotBugs.

0
findbugs
33
branch/hadoop-project no findbugs output file (findbugsXml.xml)

0
findbugs
34
branch/hadoop-client-modules/hadoop-client-runtime no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

0
mvndep
29
Maven dependency ordering for patch

+1
mvninstall
334
the patch passed

+1
compile
955
the patch passed

-1
javac
955
root generated 396 new + 1466 unchanged - 0 fixed = 1862 total (was 1466)

-0
checkstyle
142
root: The patch generated 2 new + 35 unchanged - 1 fixed = 37 total (was 36)

+1
mvnsite
350
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

-1
shadedclient
61
patch has errors when building and testing our client artifacts.

+1
javadoc
358
the patch passed

0
findbugs
31
hadoop-project has no data from findbugs

0
findbugs
35
hadoop-client-modules/hadoop-client-runtime has no data from findbugs

_ Other Tests _

+1
unit
34
hadoop-project in the patch passed.

-1
unit
5158
hadoop-hdfs in the patch failed.

-1
unit
1454
hadoop-hdfs-rbf in the patch failed.

+1
unit
75
hadoop-yarn-api in the patch passed.

+1
unit
254
hadoop-yarn-common in the patch passed.

+1
unit
51
hadoop-fs2img in the patch passed.

+1
unit
42
hadoop-client-runtime in the patch passed.

+1
asflicense
63
The patch does not generate ASF License warnings.

15745

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR

hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.server.datanode.TestLargeBlockReport

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup

hadoop.hdfs.server.federation.security.TestRouterHttpDelegationToken

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1432

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux e8114dd0f88d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 39e82ac

Default Java
1.8.0_222

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/5/artifact/out/diff-compile-javac-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/5/artifact/out/diff-checkstyle-root.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/5/testReport/

Max. process+thread count
4113 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-tools/hadoop-fs2img hadoop-client-modules/hadoop-client-runtime U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

-1	javac	955	root generated 396 new + 1466 unchanged - 0 fixed = 1862 total (was 1466)

All new Javac errors are due to either Generated proto classes are proto dependency itself.
Deprecations in src files are handled (in next commit). Javac warnings inside generated classes can be ignored or (can  be excluded directy from count? )

Shaded client errors are due to not-using "-Ptest-patch" in the mvn command  used to verify the shaded client errors.
Used locally and found no errors.

mvn --batch-mode -Ptest-patch -Pparallel-tests -P!shelltest -Pnative -Drequire.fuse -Drequire.openssl -Drequire.snappy -Drequire.valgrind -Drequire.test.libhadoop -Pyarn-ui clean test -fae
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.example.ITUseMiniCluster
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.563 s - in org.apache.hadoop.example.ITUseMiniCluster
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]

Test "TestLargeBlockReport.testBlockReportExceedsLengthLimit" is related. CodedInputStream's default limit is hardcoded to 2GB from 64MB in 2.5.0. So now excecption thrown before start reading the RPC request itself.
All other tests are unrelated to this changes.
Verified locally, fails in both trunk as well.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
117
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
77
Maven dependency ordering for branch

+1
mvninstall
1334
trunk passed

+1
compile
1284
trunk passed

+1
checkstyle
166
trunk passed

+1
mvnsite
444
trunk passed

+1
shadedclient
1400
branch has no errors when building and testing our client artifacts.

+1
javadoc
376
trunk passed

0
spotbugs
27
Used deprecated FindBugs config; considering switching to SpotBugs.

0
findbugs
27
branch/hadoop-project no findbugs output file (findbugsXml.xml)

0
findbugs
27
branch/hadoop-client-modules/hadoop-client-runtime no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

0
mvndep
24
Maven dependency ordering for patch

+1
mvninstall
448
the patch passed

+1
compile
1011
the patch passed

-1
javac
1011
root generated 370 new + 1466 unchanged - 0 fixed = 1836 total (was 1466)

-0
checkstyle
159
root: The patch generated 1 new + 425 unchanged - 1 fixed = 426 total (was 426)

+1
mvnsite
440
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
4
The patch has no ill-formed XML file.

-1
shadedclient
50
patch has errors when building and testing our client artifacts.

+1
javadoc
432
the patch passed

0
findbugs
25
hadoop-project has no data from findbugs

0
findbugs
26
hadoop-client-modules/hadoop-client-runtime has no data from findbugs

_ Other Tests _

+1
unit
25
hadoop-project in the patch passed.

+1
unit
589
hadoop-common in the patch passed.

+1
unit
131
hadoop-hdfs-client in the patch passed.

-1
unit
5943
hadoop-hdfs in the patch failed.

-1
unit
1450
hadoop-hdfs-rbf in the patch failed.

+1
unit
63
hadoop-yarn-api in the patch passed.

+1
unit
240
hadoop-yarn-common in the patch passed.

+1
unit
41
hadoop-fs2img in the patch passed.

+1
unit
31
hadoop-client-runtime in the patch passed.

+1
asflicense
54
The patch does not generate ASF License warnings.

17768

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.TestDFSZKFailoverController

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.federation.security.TestRouterHttpDelegationToken

hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup

hadoop.hdfs.server.federation.router.TestRouterFaultTolerant

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1432

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux<PHONE_NUMBER>a0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 1e13fe6

Default Java
1.8.0_222

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/6/artifact/out/diff-compile-javac-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/6/artifact/out/diff-checkstyle-root.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/6/testReport/

Max. process+thread count
3104 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-tools/hadoop-fs2img hadoop-client-modules/hadoop-client-runtime U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1432/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/rebuild

Thanx @vinayakumarb for the work here. I guess you need to update in the Building.txt too the new protobuf version.
Other than that LGTM
Thanks @ayushtkn. updated BUILDING.txt instructions.

Ok. Thanks for answers. Sounds like we need to check against dropping compatibility. Should be a quick test I'd say.

Did the quick test, connecting Hadoop-3.2.0 client to Hadoop-3.3.0-SNAPSHOT server with upgraded protobuf. Client was able to communicate successfully to server.
So there is no problem found related to compatibility.

Thanks @adamantal  @saintstack @ayushtkn  for reviews.

Good. Thanks.

@vinayakumarb - is there a jira etc to track the shadedclient failure and fix? (The missing -Ptest-patch causes protoc-3.7 to not be found which causes the failures?)
Doesn't look like the yetus scripts live in the Hadoop code base.
Also, Thank you for making this change. The protobuf upgrade has been pending for a while.

I doubled-checked the HDFS fsimage format compatibility. Today's trunk build was able read a 16GB image written by a 2.8.5 namenode without any problem.


numpy.core._exceptions.MemoryError: Unable to allocate array with shape (24012, 10716) and data type float32

I am testing Scaden using the demo data. But when I run the training step, I got a error like this "Training on: ['data8k', 'donorA', 'donorC']
Training M256 Model ...
2019-11-04 17:59:27.410629: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2019-11-04 17:59:27.410714: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2019-11-04 17:59:27.410746: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2019-11-04 17:59:27.410766: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2019-11-04 17:59:27.410791: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
Traceback (most recent call last):
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/bin/scaden", line 125, in
cli()
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/bin/scaden", line 63, in train
num_steps=steps)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/scaden/scaden_main.py", line 64, in training
cdn256.train(input_path=data_path, train_datasets=train_datasets)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/scaden/model/scaden.py", line 252, in train
self.build_model(input_path=input_path, train_datasets=train_datasets, mode="train")
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/scaden/model/scaden.py", line 213, in build_model
self.load_h5ad_file(input_path=input_path, batch_size=self.batch_size, datasets=train_datasets)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/scaden/model/scaden.py", line 158, in load_h5ad_file
raw_input = raw_input[raw_input.obs['ds'] != ds].copy()
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/anndata/core/anndata.py", line 1230, in getitem
return self._getitem_view(index)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/anndata/core/anndata.py", line 1234, in _getitem_view
return AnnData(self, oidx=oidx, vidx=vidx, asview=True)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/anndata/core/anndata.py", line 561, in init
self._init_as_view(X, oidx, vidx)
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/anndata/core/anndata.py", line 628, in _init_as_view
self._init_X_as_view()
File "/hpc/dhl_ec/kcui/tools/anaconda3/envs/myenv/lib/python3.6/site-packages/anndata/core/anndata.py", line 641, in _init_X_as_view
X = self._adata_ref._X[self._oidx, self._vidx]
numpy.core._exceptions.MemoryError: Unable to allocate array with shape (24012, 10716) and data type float32
"
I google the error and I am sure I have enough memory and I am using the cpu tensorflow. And I am not root ,I cannot revise like this "echo 1 > /proc/sys/vm/overcommit_memory". The problem is MemoryError really?  The version of scaden is 0.9.0. If there is someone could help me? Thanks in advance.

How much memory can you use?
In my RAM profiling, scaden was using up to 8GB of RAM during training. After some code review, we lowered the RAM usage in the training step, and now the RAM peak of the demo is at 3.2 GB (that happens on the preprocessing step). This RAM improvement is on the git repository (and not yet published to conda-forge as far as I know).
You may want to try the git master version. Here is a quick guide on how to build it based on the travis instructions:
# clone the repository, this will create the scaden directory:
git clone https://github.com/KevinMenden/scaden
# Enter the scaden directory:
cd scaden
# You may want to run this in a new conda environment instead
# Install conda-build and python-3.6
conda install -q -c defaults -c conda-forge python=3.6 conda-build conda-verify
# Build scaden
conda build --override-channels -c defaults -c conda-forge -c r -c bioconda --python 3.6 ./conda.recipe
# Install scaden in a new conda environment:
conda create \
      -n install-environment \
      --override-channels -c defaults -c conda-forge -c r -c local -c bioconda \
      python=3.6 \
      scaden
# Verify scaden is working:
conda activate install-environment
scaden --help

We will work on making it easier to install the development version of scaden. Meanwhile, this should work for you

Hi，
thank you for your help！I could use more than 16Gb memory. Can I install the master version in personal Macbook fellowing your guide ？ Thanks again！
Best regards，
Kai
Sent from my iPhone

On Nov 5, 2019, at 2:30 PM, Sergio Oller<EMAIL_ADDRESS>wrote:
How much memory can you use?
In my RAM profiling, scaden was using up to 8GB of RAM during training. After some code review, we lowered the RAM usage in the training step, and now the RAM peak of the demo is at 3.2 GB (that happens on the preprocessing step). This RAM improvement is on the git repository (and not yet published to conda-forge as far as I know).
You may want to try the git master version. Here is a quick guide on how to build it based on the travis instructions:
clone the repository, this will create the scaden directory:
git clone https://github.com/KevinMenden/scaden
Enter the scaden directory:
cd scaden
You may want to run this in a new conda environment instead
Install conda-build and python-3.6
conda install -q -c defaults -c conda-forge python=3.6 conda-build conda-verify
Build scaden
conda build --override-channels -c defaults -c conda-forge -c r -c bioconda --python 3.6 ./conda.recipe
Install scaden in a new conda environment:
conda create
-n install-environment
--override-channels -c defaults -c conda-forge -c r -c local -c bioconda
python=3.6
scaden
Verify scaden is working:
conda activate install-environment
scaden --help
We will work on making it easier to install the development version of scaden. Meanwhile, this should work for you
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I don't use Mac so I can't say. You can try though.

Hi,
I reinstalled scaden today and rerun the demo. I still got the error
"MemoryError: Unable to allocate array with shape (24000, 10716) and data
type float32"  in training step.  I am using HPC( x86_64 GNU/Linux) as a
non-root account and I could use more than 16G mem. In some online
suggestions, it is because I want to build a [24000, 10716] ]matrix and
system thinks it is too big then got the error.
They give the following solution:
$ cat /proc/sys/vm/overcommit_memory
0
$ sudo passwd root
$su root
$ echo 1 > /proc/sys/vm/overcommit_memory
So maybe I need a root account or to run in a PC with 16G mem?
Best regards,
Kai
On Tue, Nov 5, 2019 at 5:23 PM Sergio Oller<EMAIL_ADDRESS>wrote:

I don't use Mac so I can't say. You can try though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KevinMenden/scaden/issues/19?email_source=notifications&email_token=AMSN33LMS4ZUGH3OQER76QDQSGMYNA5CNFSM4JIWTT22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDDJM3A#issuecomment-549885548,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMSN33JLNICJ4HNEHH75K5DQSGMYNANCNFSM4JIWTT2Q
.

Closing this issue because this is rather a system problem and can't be solved with Scaden.


adding address santizer run to CI

Fixes #1655

OK, there are a couple of confusing things going on here.
Firstly, when I run with address santizer on my machine, everything works. This is weird, because normally I would expect a busy and actively coded package like netCDF to accumulate some memory errors, unless memory checking is enabled in the CI, which it is currently not.
But that did not happen. @DennisHeimbigner or @WardF have you starting checking the build with address santizer routinely? If so: bravo! If not, then @DennisHeimbigner is doing some Mozart-style perfect programming on Zarr.
But then when I run with address sanitizer on the CI build, all the zarr tests fail.
@DennisHeimbigner do the Zarr tests succeed with address sanitizer for you? (Add -fsanitize=address -fno-omit-frame-pointer to your CFLAGS to find out).

As a rule, before submitting a PR, I run with memory checks enabled to catch
memory leaks. We do not (yet) as as I know have -fsantize on in our github actions.


test_coverage_on broken on Bazel@HEAD

Sample breakage: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1914#d05d4df0-f845-4703-bc08-dc636ee1137a
Sample error:
12,13c12,14
12,13c12,14
< BA:5,2
< BRF:1
---
> BRDA:5,0,0,0
> BRDA:5,0,1,1
> BRF:2
16c17
< DA:5,4
---
> DA:5,1
18c19
< DA:7,4
---
> DA:7,1
34,35c35,36
< DA:5,12
< DA:8,4
---
> DA:5,1
> DA:8,1
52c53
< DA:9,4
---
> DA:9,1
66c67
< DA:5,3
---
> DA:5,1
84,85c85,86
< DA:5,9
< DA:7,4
---
> DA:5,1
> DA:7,1
101,103c102,104
< DA:5,6
< DA:9,8
< DA:41,4
---
> DA:5,1
> DA:9,1
> DA:41,1
 Test "test_coverage_on" failed  (2 sec)
Traceback (most recent call last):
  File "bazelci.py", line 3371, in <module>
    sys.exit(main())
  File "bazelci.py", line 3351, in main
    bazel_version=task_config.get("bazel") or configs.get("bazel"),
  File "bazelci.py", line 1067, in execute_commands
    execute_shell_commands(task_config.get("shell_commands", None))
  File "bazelci.py", line 1463, in execute_shell_commands
    execute_command([shell_command], shell=True)
  File "bazelci.py", line 2055, in execute_command
    args, shell=shell, check=fail_if_nonzero, env=os.environ, cwd=cwd
  File "/usr/lib/python3.6/subprocess.py", line 438, in run

@comius this shows that coverage output changes between Bazel versions. Is there a known practice how to handle such difference in tests?

So those tests were added 16 days ago, here 6f2df55aacbd89b9ce33f8f447696900f07bac96.
As far as I remember the change in coverage happened mid 2020, I'll try to bisect it.

@comius this shows that coverage output changes between Bazel versions. Is there a known practice how to handle such difference in tests?

Hm, the appears the test results depend on bazel version and that there's no way around it?

So those tests were added 16 days ago, here 6f2df55.

These tests existed before, they just were moved here from Travis configuration (where they would only pass on 3.5.0).

As far as I remember the change in coverage happened mid 2020, I'll try to bisect it.

I think it's expected that coverage is different between versions: Bazel comes with bugfixes or new Jacoco versions improve Scala coverage support.

It appears the test results depend on bazel version and that there's no way around it?

For now I've extracted coverage tests to be running only on 3.5.0, and hopefully "hacks" like #1205 will provide useful feedback when new Bazel version is released.

This appears to be fixed, next failing test reported here https://github.com/bazelbuild/rules_scala/issues/1224.


Duplicates and repeats

Hi,
I found an issue where if you correlate two or more alerts and send the same two alerts multiple times Alerta does not see them as repeats. Once I then send only one alert of the two or more correlated alerts, repeat is true and duplicates are made. I'm not sure where in the code to start looking for the cause.
Regards,
Mike

Can you give me examples of what you mean? Ideally example alerta send commands that I can run in order to reproduce the behaviour. Thanks.

Looks good to me...
$ alerta send -S Svc -E Development -r r1 -e event1 -C event2 -C event3 -s warning -t 1
f651cf7c-6cf2-4a53-83d7-dc6b0f3430f9 (unknown -> warning)
$ alerta send -S Svc -E Development -r r1 -e event1 -C event2 -C event3 -s warning -t 2
f651cf7c-6cf2-4a53-83d7-dc6b0f3430f9 (1 duplicates)
$ alerta send -S Svc -E Development -r r1 -e event2 -C event1 -C event3 -s warning -t 3
f651cf7c-6cf2-4a53-83d7-dc6b0f3430f9 (warning -> warning)
$ alerta send -S Svc -E Development -r r1 -e event2 -C event1 -C event3 -s warning -t 4
f651cf7c-6cf2-4a53-83d7-dc6b0f3430f9 (1 duplicates)

If this isn't what you are seeing or you can provide a list of alerta send commands that reproduce your problem please add them below and reopen this issue.


How about "simple" localization

So, Microsoft's recommended localization process for WPF is to modify your build process, build a custom tool, run several commands from that newly built tool, and honestly, I stopped reading after that because this entire process is incomprehensible. Perhaps this documentation could include a link to some of the older methods, like the project Resource files and/or the "for dummies" version of localization? Not everyone who's localizing their app has this level of knowledge. There are small-time programmers, hobbyists, and people who are in a time-crunch who want simple localization. This level of complexity is just unacceptable.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72e544a8-3979-26ea-39fb-316eafa71cdb
Version Independent ID: 5b84e3b3-e09f-be5d-8936-ed1ceb81203c
Content: How to: Localize an Application
Content Source: docs/framework/wpf/advanced/how-to-localize-an-application.md
Product: dotnet-framework
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Hi @RobinHood70, this is a duplicate of #3623. Thanks for your feedback and know this is on the list.


⚠ Bofrost.lu has degraded performance

In ef81586, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2348 ms

Resolved: Bofrost.lu performance has improved in 78e5a5c after 27 minutes.


Landing Page updates for Studio

Hi @carlosgauci,
We need some updates in the website landing page
1 - Add a new section about Studio
This section will have an H2 title, video, 3 bullet points and two buttons (button colors/text/link should be dynamic) and come right after the "Features" section. Both buttons should have the hover animation like most buttons on the website

We may change the CTA section into this format, so make sure that we can duplicate the content
  CTA:
    - title: Build even faster with Studio (free)
      link: (video or image link)
      bullet points:
         - text 1
         - text 2
         - text 3
      buttons:
          - buttonText: Learn more
             buttonColor: dark blue
             url: https://landing.deepset.ai/deepset-studio
          - buttonText: Start building
             buttonColor: green
             url: https://landing.deepset.ai/deepset-studio

2 - Add an extra button to Hero
I have made some changes in the code (#382 branch studio-lauch-prep ) to dynamically set the button color/text/link but these colored buttons should be next to each other when the screen is large enough 👇

On smaller screens:

@bilgeyucel pushed changes to https://github.com/deepset-ai/haystack-home/pull/382


Annoying behaviour of Title field

When editing the Title field, then collapsing or expanding another field and going back to the Title field, it collapses. so you have to expand it again to edit it. I guess this is because the Title field can't really expand and therefore the editing field and the expanding/collapsing hitbox overlap, leading to this behaviour.
Would appreciate a fix, really like the builder!

Can you show this issue?


Question about inline completion provider

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.78.0+
OS Version: Darwin x64 21.6.0

Hello , I've found a problem when using inline completion provider from version 1.78.0.
Before this version, each time I accept an entire suggestion(not by word or by line), it will then generate the next suggestion automatically without making any other change.
But from version 1.78.0, each time I accept a suggestion entirely(not by line or by word), it will then stop here and not call a new request util I make some  change to the document.
When I read the updates April 2023 of vscode, I saw that Inline Completion has been rewritten, so I want to know if this change is planned or if it is just a bug.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.78.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.78.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Old version don't have this issue, but new versions from 1.78.0 has.

I cannot reproduce

I cannot reproduce

hello, you can reproduce it when developping an extension following the next steps:

after npm install -g yo generator-codeto install packages, use yo code to init an extension
replace the code in extension with the following:

import * as vscode from 'vscode';
export function activate(context: vscode.ExtensionContext) {

    const provider:vscode.InlineCompletionItemProvider = {
        provideInlineCompletionItems(document,position,context,token){
            let arr:vscode.InlineCompletionItem[]=[];
            const item:vscode.InlineCompletionItem = {
                insertText:'test'
            }
            arr.push(item);
            return arr;
        }
    }

	context.subscriptions.push(vscode.languages.registerInlineCompletionItemProvider({pattern:'**'},provider));
}
export function deactivate() {}

change the activationEvents in package.json to "*" and then test extension
you will find that it will not give new suggestion automatically after each acception util you do some other change to the document
before the version 1.78.0, it will automatically generate next suggestion after each acception of a suggestion, but now it seems this doesn't work for versions 1.78.0+.

Please set a range! Also, please try to reproduce it in the monaco editor.

Please set a range! Also, please try to reproduce it in the monaco editor.

I don't think this is the solution, because range isn't a parameter required, but  I've change the code to:
// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
import * as vscode from 'vscode';

// This method is called when your extension is activated
// Your extension is activated the very first time the command is executed
export function activate(context: vscode.ExtensionContext) {

    const provider:vscode.InlineCompletionItemProvider = {
        provideInlineCompletionItems(document,position,context,token){
            let arr:vscode.InlineCompletionItem[]=[];
            const item:vscode.InlineCompletionItem = {
                insertText:'test',
                range:new vscode.Range(position,position.translate(0,4))
            }
            arr.push(item);
            return arr;
        }
    }

	context.subscriptions.push(vscode.languages.registerInlineCompletionItemProvider({pattern:'**'},provider));
}

// This method is called when your extension is deactivated
export function deactivate() {}

This will work as the gif, it will not automatically give the next suggestion after accepting the previous suggestion util I add a new space to the document

The range should be fixed. Can add console logging and verify that your provider is not called?

The range should be fixed. Can add console logging and verify that your provider is not called?

I've add console logging, and it shows that after accepting the previous suggestion, it will not call the next util I add a new space to the document.

Cannot reproduce:

Please try with this launch config:
{
	"version": "0.2.0",
	"configurations": [{
			"name": "Run Extension",
			"type": "extensionHost",
			"request": "launch",
			"runtimeExecutable": "${execPath}",
			"args": [
				"--user-data-dir=vscode-test",
				"--extensionDevelopmentPath=${workspaceFolder}",
				"--disable-extensions",
				"--profile-temp",
			],
			"outFiles": [
				"${workspaceFolder}/out/**/*.js"
			],
			"preLaunchTask": "npm: watch"
		}
	]
}

Cannot reproduce:

Please try with this launch config:
{
	"version": "0.2.0",
	"configurations": [{
			"name": "Run Extension",
			"type": "extensionHost",
			"request": "launch",
			"runtimeExecutable": "${execPath}",
			"args": [
				"--user-data-dir=vscode-test",
				"--extensionDevelopmentPath=${workspaceFolder}",
				"--disable-extensions",
				"--profile-temp",
			],
			"outFiles": [
				"${workspaceFolder}/out/**/*.js"
			],
			"preLaunchTask": "npm: watch"
		}
	]
}

I've retry the code in insiders and found it can work, but then when I add a command to the inlinecompletionitem, it will stop after accepting the suggestion. The code is as following:
// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
import * as vscode from 'vscode';

// This method is called when your extension is activated
// Your extension is activated the very first time the command is executed
export function activate(context: vscode.ExtensionContext) {

    const provider:vscode.InlineCompletionItemProvider = {
        provideInlineCompletionItems(document,position,context,token){
            console.log('new event!')
            let arr:vscode.InlineCompletionItem[]=[];
            const item:vscode.InlineCompletionItem = {
                insertText:'test',
                range:new vscode.Range(position,position.translate(0,4))
            }
            item.command={
                command: "example-bug.verifyInsertion",
                title: "Verify Insertion",
                arguments: []
            }
            arr.push(item);
            return arr;
        }
    }
	context.subscriptions.push(vscode.languages.registerInlineCompletionItemProvider({pattern:'**'},provider));
    context.subscriptions.push(vscode.commands.registerCommand('example-bug.verifyInsertion',()=>{
        console.log('add command test')
    }))
}

// This method is called when your extension is deactivated
export function deactivate() {}

Because my extension will use this method to add an extra command to inlinecompletionitem so I wonder if this is a bug or it is as planned, I have tried that the version 1.77, this will work, but version 1.78+, it doesn't.

Cannot reproduce:

    [

        ![Code_-_Insiders_8AaBoBGmaL](https://user-images.githubusercontent.com/2931520/242289048-a83ab5ac-d6e3-4cff-a92c-31dd47557e3a.gif)
      ](https://user-images.githubusercontent.com/2931520/242289048-a83ab5ac-d6e3-4cff-a92c-31dd47557e3a.gif)

      [

      ](https://user-images.githubusercontent.com/2931520/242289048-a83ab5ac-d6e3-4cff-a92c-31dd47557e3a.gif)

Please try with this launch config:
{
	"version": "0.2.0",
	"configurations": [{
			"name": "Run Extension",
			"type": "extensionHost",
			"request": "launch",
			"runtimeExecutable": "${execPath}",
			"args": [
				"--user-data-dir=vscode-test",
				"--extensionDevelopmentPath=${workspaceFolder}",
				"--disable-extensions",
				"--profile-temp",
			],
			"outFiles": [
				"${workspaceFolder}/out/**/*.js"
			],
			"preLaunchTask": "npm: watch"
		}
	]
}

I've retry the code in insiders and found it can work, but then when I add a command to the inlinecompletionitem, it will stop after accepting the suggestion. The code is as following:
// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
import * as vscode from 'vscode';

// This method is called when your extension is activated
// Your extension is activated the very first time the command is executed
export function activate(context: vscode.ExtensionContext) {

    const provider:vscode.InlineCompletionItemProvider = {
        provideInlineCompletionItems(document,position,context,token){
            console.log('new event!')
            let arr:vscode.InlineCompletionItem[]=[];
            const item:vscode.InlineCompletionItem = {
                insertText:'test',
                range:new vscode.Range(position,position.translate(0,4))
            }
            item.command={
                command: "example-bug.verifyInsertion",
                title: "Verify Insertion",
                arguments: []
            }
            arr.push(item);
            return arr;
        }
    }
	context.subscriptions.push(vscode.languages.registerInlineCompletionItemProvider({pattern:'**'},provider));
    context.subscriptions.push(vscode.commands.registerCommand('example-bug.verifyInsertion',()=>{
        console.log('add command test')
    }))
}

// This method is called when your extension is deactivated
export function deactivate() {}

Because my extension will use this method to add an extra command to inlinecompletionitem so I wonder if this is a bug or it is as planned, I have tried that the version 1.77, this will work, but version 1.78+, it doesn't.

In my tests, if I add a command to the item, both insiders and stable version from 1.78.0+ won't work, if I don't add an extra command, in insiders, the provider can be called after accepting the previous suggestion.


Fix race condition when getting BGP routes in BGPController

@Atish-iaf Please handle the backporting to release-2.2


Confluence version update to 7.6.1

Confluence version update to 7.6.1

@pavanp21 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


supplementaries mod crash

Error while creating worlds when used with Supplementaries mod

Update Spartan Shields to the latest version.
The issue with that mod has already been fixed. This mod loads fine with Supplementaries.
Closing issue.

thanks
ObliviousSpartan @.***>, 24 Haz 2024 Pzt, 19:45
tarihinde şunu yazdı:

Update Spartan Shields to the latest version.
The issue with that mod has already been fixed. This mod loads fine with
Supplementaries.
Closing issue.
—
Reply to this email directly, view it on GitHub
https://github.com/ObliviousSpartan/SpartanWeaponry/issues/46#issuecomment-2186994407,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY4M5PA6XEJB32URGLKQME3ZJBELLAVCNFSM6AAAAABJWWZVYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBWHE4TINBQG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Ability to prioritize function parameters and showing them on entering (

Is it possible to:

Have an option to prioritize function parameters.
Show function parameters when user enters (.
For example when entering serializers.SerializerMethodField( (python, rest framework) would be great to show method_field as first completion suggestion and when entering serializers.SerializerMethodField(me would be great to have method_field as first suggestion (currently for me it's map then max, etc, method_field is 6th)

Have an option to prioritize function parameters.

I guess you want custom sorting of the python completion items.
A completion source can use its own sort algorithm with the sort option set to 0 (it's currently undocumented behavior).

Show function parameters when user enters (.
For example when entering serializers.SerializerMethodField( (python, rest framework) would be great to show method_field as first completion suggestion and when entering serializers.SerializerMethodField(me would be great to have method_field as first suggestion (currently for me it's map then max, etc, method_field is 6th)

ncm's python completion is based on jedi library. According to the documentation, it doesn't have this feature.
However, it seems possible  to implement it, as the completion results returned by jedi has information about the type. To be specific, it's Completion.BaseDefinition.type
http://jedi.readthedocs.io/en/latest/_modules/jedi/api/classes.html#Completion.
It is not really attractive to me so I have no plan to support it.

OK, maybe I can make a PR if it attracts myself 😄