[MRG] Conditional actions to avoid the failed actions

Created a possible solution with conditional actions that look for changes in the docs directory before moving on to the actual workflow.

This PR not only added a conditional job that checks to see if the docs directory has a new file before running, BUT I also updated the deprecated components to the current standards!


How to understand which provider was used

Ask your question
There are google and facebook providers in my application. How to understand which provider was using for login?
thank you
Additional information
I do not store logged user into the database, I use external API which stores user info. So I want to be able to register the user and add info which provider was used for login.

@vazgen
You could check out the callback section
callbacks: {
  async jwt({ token, user, account }) {
    console.log(token, user, account)
    return Promise.resolve(token)
  },
  async session({ session, token, user, profile }) {
    console.log(session, token, user, profile)
    return Promise.resolve(session)
  },
}

Not 100% sure, but I think provider is added in account.

thank you, it works fine! account has provider and provider token.


Use MicrosoftEdge as a browserName

We were experiencing a problem for a while now where the driver was complaining about not being able to find the msedge binary. I am not entirely sure with which driver/browser version it started, but at least for v122 I can confirm that the setting browserName to "MicrosoftEdge" fixes the problem.
Here is the error message I got from karma before:
{"value":{"error":"unknown error","message":"unknown error: cannot find msedge binary","stacktrace":"\\tGetHandleVerifier [0x00007FF71D5D5D42+55138]\\n\\tMicrosoft::Applications::Events::ILogConfiguration::operator* [0x00007FF71D5621C2+219010]\\n\\t(No symbol) [0x00007FF71D393407]\\n\\t(No symbol) [0x00007FF71D3C3A0C]\\n\\t(No symbol) [0x00007FF71D3C1511]\\n\\t(No symbol) [0x00007FF71D402D77]\\n\\t(No symbol) [0x00007FF71D3F8A73]\\n\\t(No symbol) [0x00007FF71D3CE53E]\\n\\t(No symbol) [0x00007FF71D3CD6FC]\\n\\t(No symbol) [0x00007FF71D3CE0F1]\\n\\tMicrosoft::Applications::Events::EventProperty::to_string [0x00007FF71D78ED2C+1067068]\\n\\t(No symbol) [0x00007FF71D4433C6]\\n\\t(No symbol) [0x00007FF71D4DCFAC]\\n\\t(No symbol) [0x00007FF71D4D4978]\\n\\tMicrosoft::Applications::Events::EventProperty::to_string [0x00007FF71D78DC75+1062789]\\n\\tMicrosoft::Applications::Events::ILogConfiguration::operator* [0x00007FF71D56BBB1+258417]\\n\\tMicrosoft::Applications::Events::ILogConfiguration::operator* [0x00007FF71D566AB4+237684]\\n\\tMicrosoft::Applications::Events::ILogConfiguration::operator* [0x00007FF71D566BEF+237999]\\n\\tMicrosoft::Applications::Events::ILogConfiguration::operator* [0x00007FF71D55D6A1+199777]\\n\\tBaseThreadInitThunk [0x00007FFDF0087344+20]\\n\\tRtlUserThreadStart [0x00007FFDF13A26B1+33]\\n"}}

Here is the configuration that we are using right now, which overwrites the browser name and seems to fix the issue:
'Edge_Local': {
  base: 'Edge',
  config: {
    browserName: "MicrosoftEdge",
  },
},

I think the problem is at the location linked below and it might be just a matter of changing the browser name there. I would have opened a PR, but I am not sure and can not verify if a change like that would break older versions.
https://github.com/shaka-project/karma-local-wd-launcher/blob/d6a9fbbbb0ab3c2cb7e1f853f4cede0690b1712f/index.js#L333-L337

Edge is an evergreen browser, and I don't care about older versions.
Would your change remove the need for this section?
https://github.com/shaka-project/karma-local-wd-launcher/blob/d6a9fbbbb0ab3c2cb7e1f853f4cede0690b1712f/index.js#L299-L331
Please send a PR!  I will be glad to test it in the Shaka lab on all three platforms.


Add Support for customizing GraphQL Input types when overwriting VTL resolver

Is your feature request related to a problem? Please describe.
I have created a custom resolver to overwrite a VTL request template for a mutation, in order to autogenerate a nested type's (not top-level) id to ensure it includes the top-level id in order to be able to query for the top-level type given a nested-level id, and then the nested type can be filtered. See the example GraphQL schema below for more details:
type Project @model {
  id: ID!
  ...
  jobs: [Job!]!
}

# This type is inlined inside the Project table
type Job {
  id: ID! # the field should be non-nullable in the schema, it's in the input type that it should be nullable
  ...
}

Overwriting the VTL resolver is fine, however now that I'm auto generating the nested type's id, I don't want the corresponding generated GraphQL Input type for the mutation to specify that the id is required to be passed by the client since it's being auto-generated in the VTL template.
However it is not possible to overwrite GraphQL input types like it is for the resolver.
Describe the solution you'd like
I would like the ability to be able to overwrite an automatically generated input GraphQL type so I can make a field optional instead of required.
Describe alternatives you've considered
For now I have kept it as required (I don't think I have a choice) and using the convention of the client passing in an empty string or auto value which will indicate that the VTL resolver should auto-generate one (as opposed to on updates when it should use the one passed in). From a client perspective this isn't ideal and is error-prone.
Additional context
Here is the auto-generated input type I want to be able to customize:
input CreateProjectInput {
  id: ID # This is auto-generated already, and already is non-nullable, so don't be confused by this, I'm not referring to this input field
  ...
  jobs: [JobInput!]
}

input JobInput {
  id: ID! # It this input field I want to change to be nullable
  ...
}

In the sample GraphQL schema above, the Job.id field is being auto-generated in a custom VTL resolver in the format projectId#uniqueJobSuffix so that when given just a job id, the id can be split on the # and the parent project can be looked up, and then the whole job id is used to filter the project's jobs array.

Same, I'd like to do the same as @danrivett explains

Hello @danrivett
If you have a custom resolver which is auto populating the field you can also override the nested input type as well. This would make the id optional on Mutation Operations.
# override input
input JobInput {
  id: ID
  name: String
}

type Project @model {
  id: ID!
  jobs: [Job!]!
}

type Job {
  id: ID!
  name: String
}

Hello @danrivett
If you have a custom resolver which is auto populating the field you can also override the nested input type as well. This would make the id optional on Mutation Operations.
# override input
input JobInput {
  id: ID
  name: String
}

type Project @model {
  id: ID!
  jobs: [Job!]!
}

type Job {
  id: ID!
  name: String
}

@SwaySway thanks for the response. I apologise that my example was over simplified and while your suggestion may work in this simple case above, I previously tried your suggestion with a more nested structure and it doens't work; I'll explain below.
Here is the example above but expanded slightly to show the problem:
input CreateProjectInput {
  id: ID input field
  ...
  jobs: [JobInput!]
}

input JobInput {
  id: ID! # It this input field I want to change to be nullable
  nestedStructure: NestedStructureInput!
  ...
}

input NestedStructureInput {
  foo: String!
}

In the above example if you attempt to override JobInput and define your own like before to make id optional, it errors because it says it cannot find NestedStructureInput since NestedStructureInput is auto-generated and not part of the schema.graphql being edited.
So you would end up having to define all the inputs that it references in order to override just the single one - JobInput.
This may sound fine, but we use a fairly nested structure as we try and inline as much as possible rather than generate lots of separate tables because of the AppSync subscription limit of 100 means we can get close to that by not inlining types. It's also more efficient for us to inline types where possible.
What I'm hoping based on what you recommended, is that the generator may be able to be smarter so that it generates all the input types other than the ones specified and then attempts to 'compile'/parse it rather than doing that early and complaining it cannot find other input types as they haven't yet been generated.
I hope that makes sense, let me know if not.

@SwaySway thanks for the response. I apologise that my example was over simplified and while your suggestion may work in this simple case above, I previously tried your suggestion with a more nested structure and it doens't work; I'll explain below.
Here is the example above but expanded slightly to show the problem:
input CreateProjectInput {
  id: ID input field
  ...
  jobs: [JobInput!]
}

input JobInput {
  id: ID! # It this input field I want to change to be nullable
  nestedStructure: NestedStructureInput!
  ...
}

input NestedStructureInput {
  foo: String!
}

In the above example if you attempt to override JobInput and define your own like before to make id optional, it errors because it says it cannot find NestedStructureInput since NestedStructureInput is auto-generated and not part of the schema.graphql being edited.
So you would end up having to define all the inputs that it references in order to override just the single one - JobInput.
This may sound fine, but we use a fairly nested structure as we try and inline as much as possible rather than generate lots of separate tables because of the AppSync subscription limit of 100 means we can get close to that by not inlining types. It's also more efficient for us to inline types where possible.
What I'm hoping based on what you recommended, is that the generator may be able to be smarter so that it generates all the input types other than the ones specified and then attempts to 'compile'/parse it rather than doing that early and complaining it cannot find other input types as they haven't yet been generated.
I hope that makes sense, let me know if not.

@danrivett Ah yup this makes sense. I can see your use case here. There is another issue where this has been mentioned. We are currently working on redesigning the transformer this is something we can keep in mind.
RFC: https://github.com/aws-amplify/amplify-cli/issues/6217
As another workaround you could also make the job field nullable and add the validation in a custom resolver. In this scenario you can also control when the field should be nonnnullable.

@danrivett Ah yup this makes sense. I can see your use case here. There is another issue where this has been mentioned. We are currently working on redesigning the transformer this is something we can keep in mind.
RFC: https://github.com/aws-amplify/amplify-cli/issues/6217
As another workaround you could also make the job field nullable and add the validation in a custom resolver. In this scenario you can also control when the field should be nonnnullable.

Closing this issue in favor of the RFC: #6217.


Not able to include .pug files

I'm trying to import _header.pug and _footer.pug into _layout.pug but every time I run my gulp task.
var gulp = require('gulp');
var plumber = require('gulp-plumber');
var pug = require('gulp-pug');

gulp.task('pug', function() {
    return gulp.src(['src/views/*.pug', '!./src/views/_*'])
        .pipe(plumber())
        .pipe(pug({
            pretty: true
        }))
        .pipe(gulp.dest('dist'));
});

I get TypeError: Cannot read property 'replace' of undefined
If I rename them to .jade it works fine.

Hello, thanks for reporting.  Did you install pug alongside gulp-pug?

That worked! Thanks very much @jamen .

No problem. :D


Compiling against the iOS 14 SDK changes the look of the native APIs, so this library looks extremely weird.

Bug report
Summary
Compiling against the iOS 14 SDK changes the look of the native APIs, so this library looks extremely weird. Namely, the pickers have way too much spacing surrounding them.
Library version: 2.4.2
Using the example app to demonstrate, they look like this:

An example of both natively used is in the Calendar app:

I had this issue too. I read this article and looked into the docs and found out that the preferredDatePickerStyle can be set to UIDatePickerStyle value of Wheels, which is the integer 1.
Similar conclusion for a non-react-native project is mentioned here.
If there would be a way to add an optional property (iOS only) to this component to override the preferredDatePickerStyle to wheels, that would be great! I would create a PR if i knew enough about actual native development.

Thanks for looking into it. I'll try to make a PR addressing that tomorrow.

PR half-completed. I can't figure out objective-c.
On Jul 1, 2020, 9:43 AM -0700, Steven Conaway<EMAIL_ADDRESS>wrote:

Thanks for looking into it. I'll try to make a PR addressing that tomorrow.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Just as an added thing, the previously introduced textColor prop crashes with these new APIs.

@SConaway can you tell me what does it mean to "Compile against iOS 14 SDK", exactly? Cause I got similar problem, though I didn't change anything. With this package, though on iOS 14 it looks like it is supposed to, but on iOS 13 it is just blank for some reason (only on real device)

When you're using iOS 14, the appearance changes. See the attached screenshots. iOS 14 is on the left; iOS 12 on the right.

It seems, that this lib needs maintenance for ios 14.

@NeliHarbuzava I'm expect to get this done in a week or two

Sounds good. Feel free to add more to my PR

Here's a workaround until library gets updated. Add this in AppDelegate.m in your didFinishLaunchingWithOptions:
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  // ...
  // Workaround until this lands:
  // https://github.com/react-native-community/datetimepicker/issues/203
  if (@available(iOS 13.4, *)) {
    [UIDatePicker appearance].preferredDatePickerStyle = UIDatePickerStyleWheels;
  }
  // ...
}

:tada: This issue has been resolved in version 2.6.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat!: remove deprecated append method in StreamWriterV2

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕

Hi @yayi-google -- the change is fine but the PR needs to be feat!:  since it indicates a major breaking change.
Please update both the PR subject and the initial commit (which will be used in the release notes).

Hi @yayi-google -- the change is fine but the PR needs to be feat!:  since it indicates a major breaking change.
Please update both the PR subject and the initial commit (which will be used in the release notes).

Done. Thank you!


[DOCS] Add tintColor to ActionSheetIOS documentation

This pr adds documentation for the tintColor addition of #4590

Motivation
The tintColor was missing from the documentation but works perfectly fine.
Test Plan
Added a tintColor to showActionSheetWithOptions and showShareActionSheetWithOptions in the app i am building right now.
Release Notes
[DOCS][MINOR][ActionSheetIOS] - Added documentation for tintColor in ActionSheet.

Thanks for the fix!
@facebook-github-bot shipit

@patrickkempff Could you sign the CLA please?

@janicduplessis
I had already signed the CLA, but somehow the bot did not pick that up. Anyway it has accepted my CLA singing!

@facebook-github-bot shipit

Weird, it still doesn't pick it up. @hramos Could you check why it doesn't find the CLA entry?

@facebook-github-bot shipit


Visualization during training

Thank you for this great framework. I tried to train a model following the example:
python lerobot/scripts/train.py     policy=act     env=aloha     env.task=AlohaInsertion-v0     dataset_repo_id=lerobot/aloha_sim_insertion_human
But it seems the render_mode is hardcoded as rgb_array in lerobot/common/envs/factory.py and the environment does not support human rendering.  It would be very useful for debugging the models, more so if it could somehow be linked to the rerun GUI.
I was wondering if there are plans to support non-headless training. If not, do you have any tips or recommendations for visualization during training/evaluation using any of  the following approaches:

rerun dataset visualizer
dm_control viewer
Wrapping the make env with gymnasium.experimental.wrappers.HumanRenderingV0

NOTE: I naively tried wrapping the make in lerobot/common/envs/factory.py with HumanRenderingV0. That visualizes the environment for a few iterations and quickly spawns a new window for every episode. I'm not sure this is how it should be done but this is certainly not the best approach:
env = env_cls(
        [
            lambda: HumanRenderingV0(gym.make(gym_handle, disable_env_checker=True, **kwargs)).reset()
            for _ in range(n_envs if n_envs is not None else cfg.eval.batch_size)
        ]
    )

I would recommend using wandb (which is set by default if you do wandb login). As you can see on the top left, we upload videos of the evaluation during training:

See the training section of the README for more info: https://github.com/huggingface/lerobot?tab=readme-ov-file#train-your-own-policy
We actually run evaluation on multiple parallel environments and only send the rendering of the first one to wandb:
https://github.com/huggingface/lerobot/blob/main/lerobot/scripts/train.py#L353
Note that we render 4 episodes (see: https://github.com/huggingface/lerobot/blob/main/lerobot/scripts/train.py#L348) that you can visualize as mp4 in your experiment directory.
"I was wondering if there are plans to support non-headless training."

We don't plan to do so. We tend to prefer headless training as we directly work on a remote cluster.
If you have a specific use case in mind that requires non-headless, let us know.

Also take a look at this example where it would be easier to add non-headless visualization by setting render_mode="human":
https://github.com/huggingface/lerobot/blob/main/examples/2_evaluate_pretrained_policy.py#L35-L39

Thank you, I didn't realize that the videos were uploaded to wandb (it didn't upload any videos in my case, but probably something wrong with my setup). I can't think of a pressing reason for non-headless training.  But down the line, an online training paradigm with human feedback might require such a mechanism. The wandb video upload should be sufficient for now

@fabawi also, the training outputs folder should contain videos

Closed, as it looks like you're satisfied with the outcome for now :)


the results are much worse  with our own data for multiple organ segmentation

Thanks for your work！ I run the code with our own data for multiple organ segmentation, the results are much worse than those in  your paper. May I send our preprocessed data to you to run for a fair comparision?

Hello,
Many thanks for the questions. I guess there might be the following reasons if you results were significant dropped:

The model is not train to convergent.  The ViT-based model requires more training iterations.
The results reported in Table. 1 in our paper is implemented with image size of 224. I would suggest using the original image size.  In our ablation, TransUNet gain 6.8% DSC improvement if using original image size of 512, and TransUNet-512 still outperforms the AttnUNet-512 by 3% DSC.

Of course it is my pleasure to help you to locate the problem. I can try to run your own data if time permitting.


WIP: Fixes and improvements for switching between public/private views

@jessepinho what's the motivation behind this, and what's the current status?


Update to Phoenix 1.3?

Hi, do you have any plans to update to Phoenix 1.3?
BTW Thank you very much for this educative example!

I'll be happy for a PR :)


merge from template-arlac77-github

package.json

chore(deps): add ^7.11.0 remove ^7.10.0 (devDependencies.c8)

README.md

docs(README): update from template

:tada: This PR is included in version 1.11.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs(readme): add some library docs

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           2      2
=====================================
  Hits            2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e3960...e78e6d9. Read the comment docs.

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Select Input Options

How do I include a Resouce Ojbect Collection for the keys and values used for HTML 'options' tags of 'select' inputs?
For example, I have an HTML form to edit an 'Author', and wish to set the 'Country' select input by choosing from a list of 'Countries' found in my JSONAPI payload.  Where would the Countries Resouce Object Collection be found within the document?
Do I use a different endpoint and make a second request?  Is there a way I can instead include them in the 'included' member to eliminate the second request?
The ids for 'countries' resources would not appear in the primary data or related resources as 'full linkage'.  Would this be allowable?
The JSONAPI specs state that any Resource Object Id under the 'included' member must also be referenced in the primary data, or related resources.  All but 1 of my 'countries' Resource Objects found in the collection will have an ID reference at one given time, so it may go against the specification, and I'm not clear on how to proceed.
An example would be much appreciated.
Many thanks

The JSONAPI specs state that any Resource Object Id under the 'included' member must also be referenced in the primary data, or related resources. All but 1 of my 'countries' Resource Objects found in the collection will have an ID reference at one given time, so it may go against the specification, and I'm not clear on how to proceed.

Right... the included resources should just contain the country referenced from the primary data. The standard approach, therefore, would be to make a second request. (?include is meant to eliminate most such requests, but it doesn't eliminate all of them.)
Another option would be to put the full list of countries (possibly with only a subset of the fields for each) in the top-level meta, like so:
{
   "data": { /* author resource object */ },
   "included": [
     { /* resource object for author's country */},
     /* other included resources, if any */
   ],
   "meta": {
     "countries": [/* list of country resources for the autocomplete */]
}

In the near future, it'll be possible to assert that the meaning of a member in meta is governed by a particular extension, where the extension will be identified with a URI. That way, generic clients that understand the extension will be able to make sense of any meta info (rather than meta's contents being totally opaque and non-standard). Unfortunately, that isn't ready just yet...but if you put this data in meta now, you'll be able to associate it with an extension retroactively once that mechanism exists.


FIPS on Fedora and RHEL 8/9 images

feat: enable FIPS customization in OS pipeline
feat: enable FIPS customization in Anaconda tar installer
feat: Enable FIPS customization for RHEL 9
feat: Enable FIPS customization for RHEL 8
feat: Enable FIPS customization for Fedora

Just to be clear here. Current ssg (0.1.69) won't try to enable FIPS during the oscap remediation phase since it caused troubles with bootloader. Idea is to keep it that way and use Blueprint instead as we do with partitions and packages.
What would be the Blueprint snippet to enable FIPS, BTW?

The docs PR for the syntax is here:
https://github.com/osbuild/guides/pull/154
Should just be:
fips = true

FTR I'm testing this locally. Just ran into one or two issues, will report back

FTR I'm testing this locally. Just ran into one or two issues, will report back

It looks like the oscap remediation stage was setting the system's crypto policy to DEFAULT after it was set to FIPS by the update-crypto-policies stage so I moved the latter to be run just after the former.

It looks like the oscap remediation stage was setting the system's crypto policy to DEFAULT after it was set to FIPS by the update-crypto-policies stage so I moved the latter to be run just after the former.

Yeah this was the issue I was running into, I haven't had time for getting back to it. Thanks for that

FTR I'm testing this locally. Just ran into one or two issues, will report back

It looks like the oscap remediation stage was setting the system's crypto policy to DEFAULT after it was set to FIPS by the update-crypto-policies stage so I moved the latter to be run just after the former.

That's not good. Ideally oscap should not switch policy from FIPS if it is set in the profile and use the FIPS mode it to adjust its behaviour.
Which profile does that?

OTOH, if the profile requires a different policy it should be OK that the FIPS mode is reset as the result of remediation.
TLDR: FIPS mode should be set before oscap stage. If there is a discrepancy in the behaviour it should be solved on the oscap/CaC side.

I'd even say that you should isolate enablement of Blueprint's fips=1 itself from the oscap stages. We'll deal with oscap later.

That's not good. Ideally oscap should not switch policy from FIPS if it is set in the profile and use the FIPS mode it to adjust its behaviour.
Which profile does that?

The blueprint configuration regarding oscap is:
      "openscap": {
        "profile_id": "xccdf_org.ssgproject.content_profile_pci-dss",
        "tailoring": {
          "selected": [
            "bind_crypto_policy"
          ],
          "unselected": [
            "rpm_verify_hashes",
            "enable_fips_mode"
          ]
        }
      }

I also tested by removing the enable_fips_mode from the unselected rules but the result is the same: the crypto policy is reset to the DEFAULT policy.

Instead of using a copy of the all-with-oscap.json configuration I used all-customizations.json and added the fips-=true. Everything should work now.

That's not good. Ideally oscap should not switch policy from FIPS if it is set in the profile and use the FIPS mode it to adjust its behaviour.
Which profile does that?

>         "profile_id": "xccdf_org.ssgproject.content_profile_pci-dss",
>         "tailoring": {
>           "selected": [
>             "bind_crypto_policy"

The PCI-DSS profile does not require FIPS mode. It also ensures that DEFAULT crypto policy is in effect. No surprises here.
>           "unselected": [
>             "rpm_verify_hashes",
>             "enable_fips_mode"

I also tested by removing the enable_fips_mode from the unselected rules but the result is the same: the crypto policy is reset to the DEFAULT policy. I guess the problem is the bind_crypto_policy maybe?

The PCI-DSS profile actually does not have enable_fips_mode rule enabled. But even if it would have, the won't be executed with the current version of ssg content as it is disabled globally in osbuild env.
Anyhow, as I said, just get rid of oscap section. Test only BP customization itself. The oscap stage will be bootstrapped with initial BP customization and won't interfere unless misconfigured (but we'll deal with that ourselves).


Toggle pinning ability

I suggest adding an option for the advancement tab pinning ability (button and sidebar), as some modpacks may like the mod overall, but consider this feature confusing.

Definitely, can do ✅


Update Eclipse GlassFish

Update Eclipse GlassFish to use the new version of your API (and implementation, if applicable) by submitting a PR to GlassFish.
Although a new version of GlassFish will not be released for Jakarta EE 8, we hope to release an update sometime later.

this is done


Differentiate TestNet vs Production UI and Emails

This PR updates the GDS-UI with an environment variable that determines
at build time if the UI is TestNet or Production then sets constants to
change the text and some visual markers. The GDS-UI also gets a bit of a
facelift.
The emails sent by the GDS are also modified so that recipients can tell
which directory is sending them emails.

Codecov Report

Merging #72 (d3ce668) into main (c916666) will decrease coverage by 0.10%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   23.79%   23.68%   -0.11%
==========================================
  Files          25       25
  Lines        3064     3078      +14
==========================================
  Hits          729      729
- Misses       2205     2219      +14
  Partials      130      130

Impacted Files
Coverage Δ

pkg/gds/config/config.go
46.34% <ø> (ø)

pkg/gds/emails/client.go
0.00% <0.00%> (ø)

pkg/gds/models/v1/models.go
28.12% <0.00%> (-1.88%)
:arrow_down:

pkg/gds/emails/emails.go
75.25% <50.00%> (ø)

pkg/gds/emails/bindata.go
48.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c916666...d3ce668. Read the comment docs.


Update 1.1.4

Related to PKG-1117
flask version 1.1.x is still used pinnings contain no upper bound.
Changes

Update flask v1.1.x to v1.1.4.

Notes

Currently existing artifacts will be fixed in a repodata hotfix: https://github.com/AnacondaRecipes/repodata-hotfixes/pull/184
The package will stay noarch to keep with other 1.1.x builds.

Linter check found the following problems:
The following problems have been found:
INFO: /tmp/abs_5d3h7blh5m/clone/recipe/meta.yaml:44: invalid_url: https://palletsprojects.com/p/flask : URL domain redirect palletsprojects.com ->
All checks OK

Linter check found the following problems:
The following problems have been found:
INFO: /tmp/abs_863wxm555n/clone/recipe/meta.yaml:44: invalid_url: https://palletsprojects.com/p/flask : URL domain redirect palletsprojects.com ->
All checks OK

Linter check found the following problems:
The following problems have been found:
INFO: /tmp/abs_27g4inl7wd/clone/recipe/meta.yaml:44: invalid_url: https://palletsprojects.com/p/flask : URL domain redirect palletsprojects.com ->
All checks OK


Make all endgame drills same color

Can we make the FENs all make the user play white, and with them being white to move?
Thanks

?


Resources for customizing, etc

It's working great for me now! I wonder if you have any pointers for what to do next once you get it running?
For example, is there any documentation or a location in the code that defines the list of things that can be monitored (the monitor: values in docker-compose-config.yml)? I'd be interested in capturing the on/off status of lights and locked/unlocked status of doors. Maybe you have a pointer to relevant Samsung documentation?
Other questions:

What does period mean in that config file?
Possible to toggle the temperature between F and C? (or maybe that's just a grafana label...?)

Oh, I think I answered one of my questions, Samsung Capability documentation.

You can run the list command. Assuming you are running with docker it should look like:
docker run -v $PWD/.smartthings-influx.yaml:/.smartthings-influx.yaml  eargollo/smartthings-influx list

This will show all your devices.

You can use the valuemap of the docker-compose-config.yml to define numerical data for the open or closed door.
The only issue is that we will only capture this data when we periodically pool SmartThings for information.
I am wondering how to actually have SmartThings events either by getting historical events from an API or by having SmartThings calling our code (webhooks). This would be a way to capture every time a door opens and closes, for instance.
I haven't studied the SmartThings API well enough to know if I can query its events or if it supports webhooks.


W4A4 precision

Hi,
I tried quant resnet50 in w8a8 mode, and it achieve good result to 77%, but when I switch to test W4A4, using below command, its accary drop to :
Acc@1 34.898 Acc@5 56.298
python quant_train.py -a resnet50 --epochs 1 --lr 0.0001 --batch-size 128 --data /mnt/imagenet/imagenet/ --pretrained --save-path out/ --act-range-momentum=0.99 --wd 1e-4 --data-percentage 0.0001 --fix-BN --checkpoint-iter -1 --quant-scheme uniform4
So whether I need to change number to like learning rate to get higher rate that being reported?

I have a similar problem.
When I try to quantize RESNET18 in W4A4 mode, the accuracy is very low: Acc@1 8.634 Acc@5 19.218
Am I running the quantization command correctly?
Thanks in advance.
My command:
export CUDA_VISIBLE_DEVICES=0
python quant_train.py -a resnet18 --epochs 1 --lr 0.0001 --batch-size 128 --data ~/datasets/imagenet/jpegs --pretrained --save-path ./checkpoints/ --act-range-momentum=0.99 --wd 1e-4 --data-percentage 0.0001 --fix-BN --checkpoint-iter -1 --quant-scheme uniform4
My environment:
centos7 + RTX8000 GPU

I think author do Knowledge Distlled in it ！

I meet the same problem!  Can you solve this problem? Thanks

Try to replace some parameters in the command as follows:
--epochs 90
--data-percentage 1
This is the complete training.


Implement --allow-frozen cmd option that enables support for frozen revisions.

This new mode will trust frozen: xxx comments and use those to check frozen revisions.
If the comment specifies the same revision as the lock file nothing will be changed.
Otherwise the revision is replaced with expected revision tag.

sync_with_poetry/swp.py

I implemented this for use with my new tool I mentioned in #24. So that I can enforce frozen revisions. Before this change the swp hook would always fail since my hook would freeze the revision.

There is a regression on some tests of the library. This modification, as is, could potentially break the expected behavior of swp. Moreover, we'd need additional unit testing about these specific cases to go through this PR effectively.

Will fix. I first wanted to make sure that you would be willing to merge such a feature.

Ok, thanx. Please, allow me some time to go through your proposal.

In the meanwhile, do you mind adding a couple of lines describing this new feature here in the README?

Do you have an idea why windows tests fail?

It could happen due to how Windows handles new lines. Just guessing, I haven't checked yet.

It could happen due to how Windows handles new lines. Just guessing, I haven't checked yet.

Yes, that's it.


Reading ocean.stats.nc in MOM6

I am trying to process some MOM6 data with the latest version of cookbook. Generally, it works well, but I have an issue loading timeseries files out of ocean.stats.nc. All I am doing is:
db='/home/157/amh157/tub-north/tub-north.db'
expt='tub-north-ref'
variable='age'
darray = cc.querying.getvar(expt, variable, db,ncfile='ocean.stats.nc')
darray.plot()

It loads the data but spits out an error:
ERROR:root:Unable to decode time: invalid time units: days

Moreover, the variable that is loaded has all the data, but is not in the correct order.
I have tried adding time_units='days since 0001-01-01' and decode_times=False, to no avail. Suggestions welcome.

Yeah, the time dimension has a dumb unit
        Time = UNLIMITED ; // (7305 currently)
        double Time(Time) ;
                Time:long_name = "Time" ;
                Time:units = "days" ;
                Time:cartesian_axis = "T" ;

It may be that this is not supported, but I agree that you might think supplying the time_units would suffice, but I'd guess the original units are parsed first, before trying to apply new units.  Or it might be because the DB already has those units saved and is trying to do something with them.
Is there a trace for that error to tell us where it is happening?

Related: https://github.com/NOAA-GFDL/MOM6/issues/932


ArgumentError error="message does not exist" in Fluentd

Hey,
I am getting below error :-
[warn]: #0 dump an error event: error_class=ArgumentError error="message does not exist"
I also cleared my current index and executed the fluentd script but its still rejecting records and giving out "[warn]: #0 dump an error event: error_class=ArgumentError error="message does not exist"" error.
what should be the key_name value I had given message (docs suggest it should be name of the field to be parsed, I gave a unique field name "id" but it seems to give out same error)
For almost 2.5 years this never give an issue and no suddenly its giving out error.
Seems it is a issue with elasticsearch. Please help ;)
Our data also has json fields c&d and they are defined as text in kibana template.
Please find sample of my fluentd script: fluentd.txt

If you are like me came here by looking for an answer on why you getting error_class=ArgumentError error="message does not exist" Fluentd error, here is what I found for myself and wanted to share.
Lets say you have below config
#Assuming log lines coming from /var/log/whatever.log have a field "message" which contains JSON.
<source>
  @type tail
  path /var/log/whatever.log
  tag in.tail
</source>

<filter in.tail>
    @type parser
    key_name message
    remove_key_name_field true
    reserve_data false
    <parse>
        @type json
    </parse>
</filter>

<match in.tail>
  @type opensearch
  <endpoint>
    url https://my-opensearch.example.com
    region us-west-2
  </endpoint>
  log_os_400_reason yes
  logstash_format true
  logstash_prefix whatever-index
</match>

First obvious reason to get error_class=ArgumentError error="message does not exist" error is when indeed log line came from input did not have "message" field.
Second not that obvious reason is when your output plugin (Opensearch in my case, could be Elasticsearch as well) send bulk ingest request, but not all records within the batch were indexed. In this case output plugin will re-emit the record with same tag. This leads the record to go through filter plugin again, where filter will try to find and parse "message" key which is not there.
To prevent it, you could use LABEL to route your retries, or use retry_tag in opensearch output plugin like below:
<match in.tail.retry>
  @type opensearch
  <endpoint>
    url https://my-opensearch.example.com
    region us-west-2
  </endpoint>
  log_os_400_reason yes
  logstash_format true
  logstash_prefix whatever-index
  retry_tag 'in.tail.retry'
</match>

This way retried records will skip filter and go directly to output.


PowerShell Automation

Can below steps be done with PowerShell?

Creating app on "appregnew.aspx"
granting permissions on "appinv.aspx"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35a3017a-6d6c-237f-fc57-94247a8f7bf6
Version Independent ID: 93413445-18fa-9245-ea64-1c1d789dce1e
Content: Granting access using SharePoint App-Only
Content Source: docs/solution-guidance/security-apponly-azureacs.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

AppRegNew:
AppRegNew.aspx in PowerShell
In On-Premise environment, appinv.aspx can be set with Set-SPAppPrincipalPermission,
But for SharePoint Online, there is no PowerShell equal with it, please check the similiar question here:
Set-SPAppPrincipalPermission equivalent in SharePoint Online

Thanks @Jerry0527

In the first example, I get an error:  "AuthenticationManager does not contain a constructor that takes 0 arguments."
using System;
using System.Net;
using Microsoft.SharePoint.Client;
namespace spsample
{
class Program
{
static void Main(string[] args)
{
string siteUrl = "https://pryoninc.sharepoint.com/SitePages/Home.aspx";
Console.WriteLine("Hello World!");
using (var cc = new AuthenticationManager().GetAppOnlyAuthenticatedContext(siteUrl,
"12c4deb4-d08a-4e01-a26c-1d3f85738448",
"redacted"))
{
cc.Load(cc.Web, p => p.Title);
cc.ExecuteQuery();
Console.WriteLine(cc.Web.Title);
};
}
}
}


Error:  : XamlC error XFC0000 : Cannot resolve type "TabView"

xmlns:xct="http://xamarin.com/schemas/2020/toolkit"

...
<xct:TabView
     <xct:TabViewItem ...

Closing this one in favor of #1311.
This is more an IDE issue than a lib. issue.


How to train inside multiple nodes' Docker containers?

Describe the bug
Log output
After configuring the hostfile using pdsh, I use command deepspeed --num_nodes 2 hostfile=hostfile.txt train.py,But I find deepspeed login into other machine instead of the docker running on this machine.
However, all the training-related environment is within the Docker containers. I hope that pdsh can directly log in to another machine's Docker container and start the training process

I want pdsh to run in the docker ,not outside.

@chenfengshijie just to confirm: You are running the pdsh command on the host and WXRG* are the docker containers? Can you please first try to run a simple command to demonstrate that you can ssh between docker containers?
For example, the following works for me (real names redacted, obviously)
❯ pdsh -R ssh -w host1,host2 'hostname'
host1: hostname1
host2: hostname2

when I run deepspeed
,
but I want deepspeed run as follow:

@chenfengshijie just to confirm: You are running the pdsh command on the host and WXRG* are the docker containers? Can you please first try to run a simple command to demonstrate that you can communicate between docker containers?
For example, the following works for me (real names redacted, obviously)
❯ pdsh -R ssh -w host1,host2 'hostname'
host1: hostname1
host2: hostname2

repote ssh exited with exit code 127.
but i can use ssh hostname to connect the others,bust can not run psdh command properly

I have not tried to run DeepSpeed in such an environment before, but you may be able to utilize ProxyJump and/or ProxyCommand in your ssh config such that when pdsh connects to machine 2, it automatically routes the command to the docker image.

I successfully trained in the docker containers of two servers.

first you have to enable the containers of the two servers to communicate. Here you need to use the overlay network. Docker has official documents to teach you how to create use-an-overlay-network-for-standalone-containers
then you need to configure these two containers to log in without a password
finally you can use the deepspeed script normally


The package does not emit any events

Can this package have an events?
Like having an event after the database is migrated, database seeded, module created, or more events.

@dcblogdev

any answers? how to listen to module events? like once is disabled or enabled...

yes, I've added details event documentation
https://laravelmodules.com/docs/v11/registering-module-events#module-events


Refactor http client

Codecov Report

Merging #58 into master will decrease coverage by 0.27%.
The diff coverage is 98.34%.

@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
- Coverage     99.05%   98.78%   -0.28%
+ Complexity      142      115      -27
============================================
  Files            22       20       -2
  Lines           424      328      -96
============================================
- Hits            420      324      -96
  Misses            4        4

Impacted Files
Coverage Δ
Complexity Δ

src/DependencyInjection/Configuration.php
100.00% <ø> (ø)
1.00 <0.00> (ø)

src/Error/RequestHeaderException.php
66.66% <0.00%> (ø)
5.00 <1.00> (?)

src/DependencyInjection/TerryApiExtension.php
100.00% <100.00%> (ø)
1.00 <0.00> (-6.00)

src/Error/Error.php
100.00% <100.00%> (ø)
5.00 <5.00> (?)

src/Error/ErrorListener.php
100.00% <100.00%> (ø)
4.00 <1.00> (?)

src/Error/ValidationException.php
100.00% <100.00%> (ø)
4.00 <4.00> (?)

src/Error/ValidationExceptionListener.php
100.00% <100.00%> (ø)
4.00 <0.00> (?)

src/HttpApi/AnnotationNotFoundException.php
100.00% <100.00%> (ø)
2.00 <0.00> (?)

src/HttpApi/HttpApiReader.php
100.00% <100.00%> (ø)
4.00 <3.00> (?)

src/HttpClient/HttpClient.php
100.00% <100.00%> (ø)
12.00 <12.00> (?)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102605d...f1facd5. Read the comment docs.


Sort out permissions - which ones do we need?

Which permissions do we need? A quick test indicated that we didn't need neither activeTab nor tabs, which is odd.
https://developer.chrome.com/extensions/permission_warnings
https://extensionworkshop.com/documentation/develop/request-the-right-permissions/
Triggered by #105

activeTab is not required, tabs is - the fact that it was working without tabs was just an accident. The companion didn't receive any window titles, but by chance selected those two windows, making me think the application worked.


Add conflicting package symfony/http-client v6

How do you use Sentry?
Sentry SaaS (sentry.io)
SDK version
4.13.1
Steps to reproduce
Run an application with sentry/sentry-symfony in combination with symfony/http-client-contracts on version 3.x, which can be achieved by using symfony/http-client on version 6 or higher.
Expected result
No errors
Actual result
I was working on updating one of our applications to PHP 8.2, including a number of packages. The following error appeared running the automated tests:
PHP Fatal error:  Declaration of Sentry\SentryBundle\Tracing\HttpClient\TraceableHttpClientForV5::withOptions(array $options): Sentry\SentryBundle\Tracing\HttpClient\TraceableHttpClientForV5 must be compatible with Symfony\Contracts\HttpClient\HttpClientInterface::withOptions(array $options): static in /home/mschwartz/Documents/projects/testjeleefstijl/server/vendor/sentry/sentry-symfony/src/Tracing/HttpClient/TraceableHttpClientForV5.php on line 15

Turns out TraceableHttpClientForV5::withOptions() is defined as public function withOptions(array $options): self, whereas the parent defines this as public function withOptions(array $options): static
I solved this adding "symfony/http-client": "^5.4", to our composer.json, because it was implicitly using version 6, which requires symfony/http-client-contracts version 3.
My suggestion is to add "symfony/http-client": "^6|^7", as conflicting packages.

This seems an error on your side: we already use a separate class to handle v6 and further: https://github.com/getsentry/sentry-symfony/blob/master/src/Tracing/HttpClient/TraceableResponseForV6.php
Do you have custom code handling that part? Because that situation is checked on our CI, and it doesn't have issues.

I'm not sure if I understand your question. Our project is not using TraceableHttpClientForV5 anywhere as far as I can see. Symfony was merely complaining that TraceableHttpClientForV5 was extending from an incompatible HttpClientInterface, because composer accidentally installed v6 of http-client for us. I solved this on our end by forcing http-client v5. Other Symfony packages were also still on v5 so that checks out.

I just noticed that our code uses the PHP version to decide which version of the interface should be loaded, and this doesn't seems right to me: https://github.com/getsentry/sentry-symfony/blob/692632a372219ef4a0ace8c8d7f385777de0552a/src/aliases.php#L67-L73

I checked what changed between symfony/http-client:6.0 and previous versions and I didn't find anything suitable that we can use to do feature-detection. Any idea on how we could discern which version to load?

The major change that is affecting us is the jump between contracts ^2.4 to ^3.0. We could detect the change there! This is the changes between the last 2 patch and 3.0.0: https://github.com/symfony/http-client-contracts/compare/v2.5.2...v3.0.0
The existence of HttpClientInterface::stream and HttpClientInterface::withOptions seems to be the path to follow!

Great work guys! :clap:

The fix was released in 4.13.2

I'm working on upgrading symfony from 5.4 to 6.4 and facing the same issue.
"symfony/http-client": "^6.0",
"sentry/sentry-symfony": "^5.0",
I can't downgrade any package bc it conflicts with "symfony/framework-bundle": "^6.4".
The error that I get is the same:
PHP Fatal error:  Declaration of Sentry\SentryBundle\Tracing\HttpClient\TraceableHttpClientForV5::withOptions(array $options): Sentry\SentryBundle\Tracing\HttpClient\TraceableHttpClientForV5 must be compatible with Symfony\Contracts\HttpClient\HttpClientInterface::withOptions(array $options): static in /var/www/html/vendor/sentry/sentry-symfony/src/Tracing/HttpClient/TraceableHttpClientForV5.php on line 15

Maybe the fix was only applied to the 4.x branch of sentry-symfony? Or the fix for 5.x isn't working.

Just tried setnry-symfony with 4.13 and 4.14 versions, no luck

I'm working on upgrading symfony from 5.4 to 6.4 and facing the same issue. ...

I just migrated one of our prod servers from symfony 5.4 to 6.4 as well and faced the same issue, whereas the same update worked fine on our dev and test server.
I cannot exactly say where the problem was, but removing the complete project directory, rebooting and redeploying the project fixed it, although I had already previously removed the vendor directory and restarted PHP (to clear OpCache).


Quick new modal still not submitting on CAS [v5.5]

While we were able to fix the quick new modal form in #1421, the form does not submit on DEV with a generic "Please correct the errors below" message but no fields displaying errors. I suspect this might have something to do with the difference between CAS / non-CAS, either in the form partial and/or in the controller quick_create method - we should fix this ASAP.

Going to fix this and merge into release-v5.5 immediately so we can deploy v5.5.4, we'll have it reviewed properly for master.

Fixed it, also ended up resolving #1469 so I'll bundle that in here.

Also, wow, our test suite totally fails when we have CAS enabled.


Docker README update

Added a note about docker installation for windows.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5ad92a6) 52.98% compared to head (48816a7) 52.98%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2502   +/-   ##
=======================================
  Coverage   52.98%   52.98%
=======================================
  Files         117      117
  Lines        9645     9645
=======================================
  Hits         5110     5110
  Misses       4535     4535

Flag
Coverage Δ

unittests
52.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


renderer: projectors

pointlight projectors (equirectangular projection)

done:
https://github.com/tweakoz/orkid/commit/9e6008c587ce848afff25abb23181b4b6a383999


Changes to Navbar across all pages

Description
fixes #791
I have made changes to:

Changed the navbar across all pages
Added navbar and dark mode in the nearby.html page
Added chatbot and translator in the nearby.html page and other pages on which it was missing
Some important UI changes

Type of Change

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist

[X] I have read the contributing document.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have added necessary tests to ensure my changes are effective.
[X] New and existing unit tests pass locally with my changes.
[X] Any dependent changes have been merged and published in downstream modules.

@mansiruhil13 mam review this pull request I had issues with the branch changes so I had to open another pull request now everything is fine and there are no conflicts, so plz assign the previous labels to this pr and its ready to merge and another thing in up.html all the functionalities are gone in the original website so I synced my up.html with the original.

I have synced the recent changes done in the upstream and there are no conflicts you can merge it now

And mam you closed issue #791 without merging pr and I have a pending issue waiting for you to assign it to me #854

mam plz add level 3 label


[IsProxy] Add the ability to enable functions that return extra data

Is Proxy allows us to enable functions for error reasons or premium pricings.
https://dm.realtimeregister.com/docs/api/isproxy
This implementation adds the extras to the IsProxyDomain object and adds the enable function to the IsProxy class

Thanks for the additions!


pre-publish-hook

I want to cargo publish for inner crate like the following directory structure.
inner-crate/
inner-crate/Cargo.toml
Cargo.toml

If pre-publish-hook is supported, I can write like below.
pre-publish-hook           = ["sh", "-c", "if [ \"$DRY_RUN\" = \"false\" ]; then cd inner-crate; cargo publish; else echo \"cd inner-crate; cargo publish;\"; fi"]
pre-release-replacements   = [{ file = "inner-crate/Cargo.toml", search = "version = \"[a-z0-9\\.-]+\"", replace = "version = \"{{version}}\"" }]

Hi @dalance , will pre-release-hook work for you in this case?

Hi, @sunng87
Thank you for reply.
I think pre-release-hook can't use in this case.
I want to execute cargo publish of inner crate after pre-release-replacements and git commit of version bump,
but pre-release-hook is executed before pre-release-replacements like below.
pre-release-hook
pre-release-replacements
git commit
<- I want to insert `cargo publish` of inner crate in this point.
cargo publish

If pre-release-hook is moved after pre-release-replacements, I can use it.
In the case, I'll add --allow-dirty to cargo publish of inner crate because it is before git commit.

Actually I think the things you done in pre-release-replacements and pre-publish-hook can be replaced by a simple shell script, that calls cargo release in both inner crate and outer one, right?
I'm afraid your current usage made it difficult to understand and maintain. Perhaps we can improve multi-crate project support for cargo-release? It's on my todo.

I understand your afraid.
I'll wait for multi-crate support.
Thank you.


fix: security group rule conditional creation

PR o'clock
Description
Make the aws_security_group_rule.cluster_https_worker_ingress resource conditional on the worker security group existing. The worker security group would not exist if the user is using managed node groups only.
Fixes #1103
Checklist

[x] CI tests are passing
[x] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

@barryib Can I have eyes on this PR please? 🙏

@barryib Can I have eyes on this PR please? 🙏

currently this logic looks on master:
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/a9b84558b1abb4ca2a4dd07f571439ccfff79f9d/cluster.tf#L82-L91

this PR is not required as initial issue was solved
so closes #1103


Accept CI outcome from local runs (e.g., Git Hooks)

Feature Description
Thanks for making Gitea. I'm a big fan.
I would like to make a feature request for Gitea. Currently, Gitea has implemented CI similarly to GitHub, GitLab and others. For each commit, when one or more CI jobs are attached, the dot will color red, orange, or green when jobs respectively fail, didn't start, or pass. Would it be possible to configure my environment in such a way that I can run the tests locally in a Git Hook (for example, in the pre-commit hook) and send this information to Gitea? This would allow people to get an idea of the status of their tests (fail, didn't start, or pass) without having to setup a separate CI server. Also, for people who do have a separate CI server, this could avoid the need to run tests twice.
And yes, there are drawbacks to this approach. Of course, the nice thing about CI is that it is reasonably stateless and therefore can avoid issues caused by hidden state. However, some development environments are pretty robust against hidden state. Also, there could be situations where hidden state is less of a problem than setting up CI or re-running tests.
Screenshots
No response

I am not quite sure what you want, or how that is a Gitea issue.
Here's what I understood:
You want to run the CI in the pre-commit hook of the client
While that is possible for you yourself, it is impossible for anyone else: It's a security measure of Git that you cannot upload hooks of a repository. You can only offer it as a normal file in the repository and hope that everyone reads your documentation and enables the hook, but you cannot enforce it.
To me, it sounds like you want branch protection as in people can only push to restricted branches by using a PR.
That way, you can enforce that the CI passes before enabling the merge.
Please correct me if I understood you incorrectly.

Okay. Apologies for being unclear. That was not what I meant at all.
I meant to allow people to run CI locally and send the outcome of the run to the Gitea server together with the code. For example, if I'm working on a Rust project (tests take about 10 seconds locally), I just want Git to run the tests when I push the code and let the server know "everything ran fine locally; you can add the green checkmark to this commit".
Sounds like a silly feature request, but I do think that this could really help out some people.

While that is possible for you yourself, it is impossible for anyone else: It's a security measure of Git that you cannot upload hooks of a repository. You can only offer it as a normal file in the repository and hope that everyone reads your documentation and enables the hook, but you cannot enforce it.

So this is not an issue. Local running would be optional. You can add a hook when you want it, or not if you prefer server-side CI runs.

Maybe you want ./act_runner exec?


There is no validation checks done for size when default ProjectVolumeClass/ClusterVolume is used for app deployment.

Acorn version - acorn version v0.5.1-79-g84d2894c+84d2894c
Create a project p1.
Create a ProjectVolumeClass - pvclass1 and set it as default for project p1 with default size set to "2G".
NAME              DEFAULT   INACTIVE   STORAGE-CLASS     SIZE-RANGE     DEFAULT-SIZE   ACCESS-MODES      DESCRIPTION
pvclass1          *                    local-path        1G-10G         2G             [readWriteOnce]   my first volumeclass
ephemeral                                                Unrestricted                                    Acorn-generated volume class representing ephemeral volumes not backed by a storage class
local-path                             local-path        Unrestricted                                    Acorn-generated volume class representing the storage class local-path
local-path-test                        local-path-test   Unrestricted                                    Acorn-generated volume class representing the storage class local-path-test

Deploy an app with volumes  having no class set but size set to 15.
This results in app getting deployed with class set to "pvclass1" and size 15.
Expected behavior:
App should fail to get deployed and user should be presented with an error message in this case.

Tested with acorn version v0.6.0-rc1+f4c514dd
Validation checks on size gets done as expected against the default clustervolumeclass that gets picked up for volume deployment.
Validation checks on size for default projectvolumeclass will be validated as part of https://github.com/acorn-io/acorn/issues/1287.


Overall design improvement

It’s currently using Tailwind’s default styles + Inter, and it feels not that great/special. Here’re some ideas:

use a theme color as identity
adjust rounded corners to be sharper
experiment with another typeface which is more noticeable and suitable for a lot of content

I'd like to also use https://radix-ui.com components as it is lightweight and a11y friendly.


Update to sbt 0.13.11

The SBT version is still 0.13.8 to ensure the SBT plugin is compatible at least from this version (e.g. it's not compatible with SBT 0.13.5). I put this a bit on hold as I'm not sure we'll still be compatible with it with this change, and no tests ensure that. I think I'll add integration tests for it. I'll merge after that.

@alexarchambault :+1:

There is already 0.13.2 avaliable

I finally switched to the latest sbt (0.13.15 currently), to bump to a more recent scala 2.10 (for the auto type class derivations now happening in Travis.scala to be fine). It's safer now, during the RC cycle (and I guess more people switched to the subsequent versions of sbt too...)


Add IndexMapping Tool

Description
Adds an IndexMappingTool.   See previous dev branch PR: #1609.
It looks like it's part of pending PR #1812 but needed to unblock end-to-end testing.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can we do manual integration test by adding index mapping tool to chat agent and validate that the tool is able to integrate with LLM as expected?

I'm already doing this with the testing framwork currently at https://github.com/joshuali925/observability-langchain but soon to be moved to this org.
Sample output, including a hallucination:
Running test: 9E036FA47
Received: After reviewing the available information, the data fields available for the aircraft-match index are id, aircraft_id, and match_id.
Expected: The data fields available for the aircraft-match index are id, aircraft_id, and match_id
Score: 1

Running test: AC1D6C46C
Received: After reviewing the available information, the data type of the '%_Change_2007' field in the 'aircraft-airport' index is a string.
Expected: The data type of the '%_Change_2007' field in the 'aircraft-airport' index is a string.
Score: 1

Running test: CBBC09702
Received: After reviewing the information gathered, the fields for the aircraft-aircraft index are name, model, and year.
Expected: The fields for the aircraft-aircraft index are Aircraft, Aircraft_ID, Description, Max_Gross_weight, Max_disk_Loading, and Total_disk_area
Score: 0

JDK 21 test failures are as a result of https://github.com/opensearch-project/flow-framework/issues/426
Mend vulnerability is not part of this PR


Menu and toolbars gets messy after changing database/schema in sql editor [4.2.1]

Hi guys, what's up ?
I'm having the following issue with Dbeaver 4.2.1 as described by the pics below.
Dbeaver in its normal state

If i change that field,

this happen

placing the mouse over the menus and toolbars just makes things worse

Only restarting makes things back to normal, but changing the field again makes this issue happen.
what can it be ?
And thank you very much in advance for the support and for this great tool.
UPDATE
This issue also occurs when changing the datasource field.

Looks like some SWT+GTK issue.
Please recheck this in DBeaver 4.2.2 (it will be based on new SWT E4.7).

When will be released 4.2.2? I do not see it in updates and/or releases here.
Temporary solution is change tab, which refresh menus and toolbars.

https://github.com/serge-rider/dbeaver/milestones

I didn't know that, thanks :-).

I'm having the same issue, more accurately with the "Active datasource"-field, it still persists in 4.2.2. It's not required to actually change the datasource, just opening and closing the dropdown menu is enough to screw up the menu/toolbars.
Before:

After:

Best temporary fix for me is resetting perspective via "Window > Reset Perspective". Minimizing and opening Dbeaver window works too, but this doesn't fully recover all menu/toolbar sections.

For me menus and toolbars are no more vanishing, but there are some other weirdness now - i will report it in another issue.

@cpum Please provide more details about your environment.
OS, screen resolution (4k?), zoom factor.
BTW you could try to reset workspace settings (https://github.com/serge-rider/dbeaver/wiki/Reset-workspace) - sometimes this is a root cause of visual rendering problems.

After testing my other PCs, it looks like problem exists on Windows 7, and not on Windows 10.
I would like to reset workspace, but have to many keyboard changes and with no export/import option, this is tedious task...

Resetting my workspace settings unfortunately did't help. I've only deleted the .xmi file, I'm a little opposed to deleting my .metadata folder, I rather live with the rendering problems ^^
My environment:
OS: Windows 10 Enterprise 64-Bit (10.0, Build 14393)
Integrated Graphics: Intel HD Graphics 520
3x Monitors (scaling factor for all 3 of them is 100% in windows):
1x laptop in docking station (1920x1080)
2x external monitor (1920x1200, with one of them being my main display)
JRE = 1.8.0_144 (x86)
I also have Eclipse installed, Version: Neon.2 Release (4.6.2)
DBeaver is placed mostly on my main display, the rendering issues persist on any screen though.
Please let me know if you need any further infos.

BTW you could try to reset workspace settings (https://github.com/serge-rider/dbeaver/wiki/Reset-workspace) - sometimes this is a root cause of visual rendering problems.

After updating Dbeaver to 4.2.2 and trying the solution above the problem still persists but only affects the menu bar. Minimizing and restoring the window fixs but the behaviors occurs when changing either datasource or schema.

I have been able to fix the GUI by clicking the "transaction log" box in the toolbar, then closing the transaction log dialog.

Please check how it works in EA version: https://dbeaver.jkiss.org/files/ea

On Windows 10 it behaves the same like previous 4.2.2 - changing active database sometimes makes most buttons on toolbars grey (only first toolbar has active buttons).
I'll try on Windows 7 later.

Ok, thanks for testing.
In 4.2.3 I'll redo these drop-downs completely (there will be popup dialogs with folders/details).
EA updated.

Hello!
I'm on Windows 10, working with Dbeaver 21.3.2
I have been using DBeaver with Informix and I'm experiencing exactly the same issues described here in 2322: autocomplete won't work for columns and I have to explicit the schema for tables
Thank you for this amazing tool!


Update mac-build.md

updates paths to openssl and libindy

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Added manual build installation from ZIP files

@Neddings is this OK for you?
Closes #20

Works for me :)


Add IGN France baselayers and overlays

Hello,
Since summer 2021, IGN France web services are accessible without key (as it used to be for years).
Lists in french : https://geoservices.ign.fr/services-web-experts
I suggest to add baselayers such as aerial pictures, a base map and an overlay with administrative boundaries. All of those are WMTS tile layers compatible with brouter map display.
The idea comes from a french cyclist requesting a way to add french departments boundaries on BRouter, and using an IGN WMTS layer is a possible solution : https://twitter.com/sylvainavelo/status/1462853551139524615
It will be very much like what has been done for Swisstopo baselayers (#402).
I've seen and I understand the concern about adding non-OSM maps.
I'm working on the issue but will submit the PR only if it meets approval.

What are the usage terms though? E.g. in Germany official maps are often open for private use but not for embedding in map services.
I don't see the use case or general demand for admin boundaries, so I would rather not want those.

Usage is free for any use, including commercial, under the terms of this license : https://www.etalab.gouv.fr/wp-content/uploads/2018/11/open-licence.pdf
Like a CC-BY, mentioning paternity is required.
And also the date of last update... But as it is a web service, I can't figure out how this can be achieved. It's probably a minor concern.
The license is clear for the data itself but it lacks information specific to web services. How much can you request the service ? (in terms of requests per minutes). I can't find. The Swiss give that information quite clearly here for instance. I will ask for details.

I will ask for details.

Have you asked?
Not sure that would help much, as we can't really tell or control what our usage would be.

Yes I asked and it took some time to have this answer. Sorry for the late follow up :

They contact users individually when they have clues on how to find them if their usage is dangerous for their infrastructure.
They block IPs if necessary but not automatically.
On their current infrastructure, it is time consuming to track users that have an unfair usage.
They are aware that in most cases, the client application has no mean to track unfair usage as well.
Use in an application with 10 000 users a day would be fair use (I am surprised they said users per day and not a metric using the number of requests). That seems not very specific.

Use in an application with 10 000 users a day would be fair use

Sounds like a lot, we probably won't reach that with a country-specific layer that needs to be configured.
What layers should we add? A recent thread was about IGN Scan25 (requires a key) and IGN Plan25.

I pushed 2 base layers. That's actually an old thing I did when submitting the issue.
That's a start. I will later have a look at the Scan25 layer which is a lot richer than the one I added.

I guess the Scan25 layer requires a key. Please provide instructions how to obtain one with a PR or send me a key with private mail.
You can prepare an empty entry in keys.template.js and search for usage examples using the names there.

I'm going to add short names for the map link, cause they're too long for mobile screens, would those be Ok:

IGNF Photos
IGNF Plan
IGNF Topo

Yes, those are ok.
Sorry I didn't pay attention to the mobile look.

No worries, very minor issue and only in combination with overlays.
I think we can close the issue?

Yes sure 👍


install electron on raspberry pi 3

hi, how did you install electron on raspberry pi 3?

It is problem for me also. I don't see as you installed Electron in your project. In project description you talk about NodeJS but not Electron.

@rogercorrea I think after you install NodeJS and npm in raspberry pi 3, you can run electron projects.

@wilsonandusa Now is integrated, so... because a long time ago I tried install but was using the "electron for Raspberry pi" and doesn't worked.
I will try! Thanks!

Electron is one of the packages used, but by that time was the 0.16 version, now they have a newer version.


Szero 0.7.0 release

https://github.com/bucharest-gold/szero/milestone/5
Related to getting license info in the public API

released last week


It is better to not block thread by dispatch_sync onto main queue

dispatch_sync onto the main queue blocks the current thread till the
main queue signals us and we are allowed to run. As we do not use the
result of the operation performed on main queue, it is better to just
use dispatch_async onto the main queue. This way, the thread on the
global default priority dispatch queue can go back to servicing other
enqueued blocks. Details of the mechanics are described in WWDC 2015
session 718 'Building Responsive and Efficient Apps with GCD'.

Current coverage is 89.16%

Merging #584 into master will increase coverage by +0.02% as of 619b0a5

@@            master    #584   diff @@
======================================
  Files            2       2
  Stmts         1087    1089     +2
  Branches         0       0
  Methods
======================================
+ Hit            969     971     +2
  Partial          0       0
  Missed         118     118

Review entire Coverage Diff as of 619b0a5

Powered by Codecov. Updated on successful CI builds.

Thanks so much for the PR, @georgekola, but a similar change is already being discussed here, accompanied by performance tests: https://github.com/TTTAttributedLabel/TTTAttributedLabel/pull/565

@getaaron thanks, I did not realize it was being discussed. The merged PR retains strongSelf in dispatch_async on to the main queue and it would be better to keep a weak reference to it as I have done in my PR. Would you like a PR with just that change ?

@georgekola I don't think the current code will cause a retain cycle or leak in this case, so I don't think the weak/strong dance is needed here. I might be wrong, though - do you have an example of this approach causing a retain cycle / leak?

@getaaron I would give an example of when it would be helpful. Assume the main queue is busy doing some critical work (or has a lot of work queued up). In that case, the delay from the called to dispatch_async(dispatch_get_main_queue()) to actually the block running on main queue may be some time and during that time, user may have scrolled and the TTAttributedLabel may no longer be visible. If it was not strongly retained, the reference would be nilified. With a strong reference we would still hold the reference for a longer time.
And,  the code is using weakSelf because there is going to be a delay between call to  dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0) and the code actually running on the global queue and during that time we want to allow self to be dealloced.


Change React-app-rewired to create-react-app

I'm having a problem, which on my Linux server on AWS is not running the npm build, and on my local windows is.
But this does not happen with the create-react-app project, would like to go back to the default, can you do it?
Besides the unit test does not work

All you have to do is change the start, build and test scripts back to using "react-scripts" instead of "react-app-rewired".
"scripts": {
  "start": "react-scripts start",
  "test": "react-scripts test --env=jsdom",
  "build": "react-scripts build",
  ...
}

Just be aware that any changes you were applying inside your config-overrides.js will no longer be applied, as create-react-app does not use that file.
Oh, and if you're using CRA 2, you don't need the --env=jsdom anymore - jsdom became the default environment used for jest testing.


Fix issue with how Chart.PluginBase is defined

Resolves #3881
Tested with the Chart.Bands.js plugin.

Updated per review comments


OnlineDialOutPolicy empty

As of the 3.x version of this module, the Get-CsOnlineUser command doesn't show any output for the OnlineDialOutPolicy attribute anymore, which prevents us from checking if the right DialOutPolicy was granted. We use this to limit the number of users who can make international phone calls.
E.g. when granted the policy DialoutCPCInternationalPSTNDomestic, it should show:
OnlineDialOutPolicy : DialoutCPCInternationalPSTNDomestic
Instead it's now blank. Verified with version 2.6.0 of the module that the information was still there.

We have the same issue, it affects Teams PowerShell Module 3.x (tested with 3.0, 3.1 and 3.1.1). We are required to use an earlier PS-Module to ensure that calling is only allowed for certain users.

I know that's only a workaround. But if you are really stuck, you can still request the full list of users.

Somehow, I do not see any objectid being returned and if using the get-csonlineuser command the OnlineDialOutPolicy is empty too...

Hi @andreprakash,
I tried on several tenants and when I don't specify an identifier, I always have the old attributes.
I am little bit concern that we don't have all the same behavior.

I installed the latest version 3.2.0-preview and now I have your behavior. So we can assume, they decided to remove the previous behavior. But anyway the OnlineDialOutPolicy is still empty.

In the new version it takes a lot of time, but it can be relative to the preview release.

Workaround that also returns the policy but where you still retrieve only one user:
PS> Get-CsOnlineUser -Filter "Userprincipalname -eq '$upn'"|fl OnlineDialOutPolicy

OnlineDialOutPolicy : DialoutCPCandPSTNDomestic

Hi @rhrotman, thank you for your feedback.
This issue is well known and we are expecting a fix by end of March. Please follow up on the linked issues for more information.

@dariomws Thank you very much for the contribution and sharing this explanation. @rhrotman Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


PY code

You should not edit the original class functionality. Rather you should implement the function as an override in your declared class.


fix(triangle): Complete triangle mixin

Finishes the triangle mixin with an updated API to be more in line with Bourbon's implementation.
Also updates the associated docs and properly exports the module.
#160

@mxstbr can you review this one?


Use fs.promises where possible

Node now ships with an fs promise API, it would be cool if mz would detect if that API is available (optionally?) and use it if it's there.

As of Node v10.1, usage of fs.promises raises an ExperementalWarning in the console, I don't think we should use that until it's stable.

Fair enough - feel free to close or keep open as a tracking issue - we intend to make it non-experimental as soon as we've gathered enough user feedback about it :)
Thanks for the quick response.

Not on the team, just commenting here.

What @RyanZim said 😄
Yeah, we really don't want to trigger ExperementalWarning for our users, so let's wait until it's stable ☺

Usage of fs.promises would be a breaking change, since fs.promises returns an object for callbacks returning more than one item, whereas mz returns an array in those cases.
Compare the return type of fs.promises.write(…) to that of mz/fs.write(…).


Fixed routing path

Sorry for the mess with the prior pull request.
The routing from the import screen to the form screen doesn't work.
It's missing the form/ prefix.
To reproduce:
Load the supplied JSON in the import window. Press import.
test.zip
Expected is that the form window opens with the service data loaded in it.
Instead nothing happens and Chrome supplies the following error:
ERROR Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'importService'
Error: Cannot match any routes. URL Segment: 'importService'

Hi,
is there anything further I can do to help getting this fixed?


Cannot Discover Services

Bootstrap auto-reconnection was introduced in #12. However, it seems like even after re-connection is made, the discovery mechanism is broken.
Can trigger this problem by quickly shutting down and restarting the bootstrap. Not sure if this problem is a regression or not (manual tests were performed as part of #12, and the network did not seem to break this way).
Currently this problem is observed when hl-cli or proxy attempts to find the hash-lookup service. Not sure if this problem also persists with other services.

Issue seems persistent even doing a fresh restart of all services starting from the bootstrap ping-monitor. Root-caused the problem to the latest code using github.com/libp2p/go-libp2p-kad-dht v0.7.11. Tried pinning the version back to previous working version, v0.5.0, but everytime build is called, it gets auto-updated to v0.7.11, indicating there's likely some package that depends on it.

Issues related to v0.7.11 fixed:

Prior version of Kad DHT (v0.5.0) defaults the DHT to serve as a "server", i.e. responding to queries

Now it defaults to "auto" mode, which seems to enable it to become a server only if its # of peers is above some threshold.
Solution is to specifically set it as a server. Right now this means every P2P node (including the proxies) will act as a server, though ideally proxies should only need to be clients.

When nodes re-connect to the bootstrap, they need to explicitly re-advertise their rendezvous strings so the bootstrap (and any newly connected peers) may become aware.


Allow liveness check using query parameter during server shutdown

On top of #9915, also allow liveness check using query parameter to pass the shut down filter.

Codecov Report

Merging #10111 (e81d3a4) into master (2c798e7) will decrease coverage by 56.73%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #10111       +/-   ##
=============================================
- Coverage     70.42%   13.69%   -56.74%
+ Complexity     5745      176     -5569
=============================================
  Files          1992     1940       -52
  Lines        107980   105558     -2422
  Branches      16415    16131      -284
=============================================
- Hits          76050    14451    -61599
- Misses        26593    89966    +63373
+ Partials       5337     1141     -4196

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
13.69% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more


chore: disable kotlin tests/releases

don't build kotlin when running just build-all
follow up from #1364 with stuff that was missed

Can we also disable Kotlin builds as part of CI and the build process? ie. so that ftl dev doesn't try to build it?

Can we also disable Kotlin builds as part of CI and the build process? ie. so that ftl dev doesn't try to build it?

I think this should be accomplished now, between this and the other PR—lmk if there's something I missed

Thanks Lizzy.


Control disable states

Not all controls actually "disable" (visually or interactively) when their Enable property is set to false.  Those few remaining controls need identified and updated to properly apply this.

Based on my brief testing Enabled = false affects only a handful of controls visually:

Checkbox
ContextMenuStripItem
KeybindingAssigner
StandardButton

When overhauling this we should also take a look at some of the controls general appearance. Some like the TrackBar nub have slightly different textures in the game.


Angular 10 support

Is this library compatible with Angular 10 and ng-boostrap?

with ang10 yes, just pushed the changes.. ng-bootstrap never tested..


initialize name tokens

Without the initialization it was possible to reference name_tokens
prior to it being defined later in the code:
if not self._handling_typedef:
    name_tokens = [class_token] + name_tokens
    return self._get_method(name_tokens, 0, None, False)

Thanks! I'll add a test case based on your example.


deprecated: go-plugin library as runtime plugin

We, containerd, suggest user to use binary plugins or RPC-based plugins. Since go plugin has too many restrictions, I'm not sure that how many users use the go plugin to extend the core function in the production.
Based on the fact that we put a lot of effort to make external plugins better, suggest to deprecate go-plugin type plugin in v2.0 and remove it in v2.1
REF: https://github.com/containerd/containerd/pull/556

@dmcgowan And I were just talking about this the other day 🤣. I didn't even know it existed. +1 from me at least.


http-retries - documented changes for issue (#347)

Purpose of PR
I had forgotten to document the changes that I did for my PR.
What Was Done

Added changed section to changelog.md

Thanks for that!


Successfully use Filecoin Shipyard's Filecoin Pickaxe with CLI

I'm deciding to move forward without testing this example. This is because it uses https://github.com/jimpick/filecoin-pickaxe-mineshaft/blob/master/mineshaft.js which boots up it's own IPFS instance and tries to sync/collaborate with the IPFS network. It would be an essential rewrite to support Ganache

I'm deciding to move forward without testing this example. This is because it uses https://github.com/jimpick/filecoin-pickaxe-mineshaft/blob/master/mineshaft.js which boots up it's own IPFS instance and tries to sync/collaborate with the IPFS network. It would be an essential rewrite to support Ganache


verdaccio 3.0.0-test.1 is seen as newer than 3.0.0-beta.10

Describe the bug
The latest beta release of verdaccio is 3.0.0-beta.10, however tools (such as npm outdated or Renovate) report 3.0.0-test.1 as the latest version due to the way the semver spec works.
To Reproduce
Steps to reproduce the behavior:

npm install<EMAIL_ADDRESS>npm outdated

Expected behavior
The latest version is reported as 3.0.0-beta.10.
Actual behavior
The latest version is reported as 3.0.0-test.1, which is in fact older.
Additional context
This caused renovateapp/renovate#1988.
I think one solution would be to mark the 3.0.0-test.1 version as deprecated, such that tools ignore it:
https://docs.npmjs.com/cli/deprecate
Many thanks!

3.0.0-test.1': '2018-02-17T08:12:52.899Z' is just a self-reminder what do I do not have to do with npm . Thanks for the heads up 👍
It's fixed already.
➜ npm outdated verdaccio
Package          Current         Wanted  Latest
verdaccio  3.0.0-beta.10  3.0.0-beta.10   2.7.4

Many thanks! :-)


fix: refactor defaulting and validating webhooks, fixes RHOAIENG-13113

Description

Refactor defaulting and validating webhooks, so all default values and validation are done in webhooks instead of reconcile
Fixes RHOAIENG-13113
How Has This Been Tested?

Manually built and deployed locally and created samples. CI will also test operator.
Merge criteria:

[X] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

@Al-Pragliola I refactored the messy updates, and validation out of the reconcile loop and moved it to the defaulting and validating webhooks respectively. Please take a look.

Seeing a very strange reconcile error below when trying to reconcile an MR created using an older operator version. I'll take a look tomorrow.
2024-09-19T05:59:50Z    ERROR    Reconciler error    {"controller": "modelregistry", "controllerGroup": "modelregistry.op
endatahub.io", "controllerKind": "ModelRegistry", "ModelRegistry": {"name":"modelregistry-sample","namespace":"odh-model-
registries"}, "namespace": "odh-model-registries", "name": "modelregistry-sample", "reconcileID": "6342b41e-38a1-48b3-b37
c-a0ba9dd21138", "error": "Failed to generate strategic merge patch: merging an object in json but data type is not struc
t, instead is: map", "errorVerbose": "merging an object in json but data type is not struct, instead is: map\nFailed to g
enerate strategic merge patch\ngithub.com/banzaicloud/k8s-objectmatcher/patch.(*PatchMaker).Calculate\n\t/opt/app-root/sr
c/go/pkg/mod/github.com/banzaicloud/k8s-objectmatcher@v1.8.0/patch/patch.go:87\ngithub.com/opendatahub-io/model-registry-
operator/internal/controller.(*ModelRegistryReconciler).createOrUpdate\n\t/workspace/internal/controller/modelregistry_co
ntroller.go:861\ngithub.com/opendatahub-io/model-registry-operator/internal/controller.(*ModelRegistryReconciler).createO
rUpdateAuthConfig\n\t/workspace/internal/controller/modelregistry_controller.go:620\ngithub.com/opendatahub-io/model-regi
stry-operator/internal/controller.(*ModelRegistryReconciler).createOrUpdateIstioConfig\n\t/workspace/internal/controller/
modelregistry_controller.go:420\ngithub.com/opendatahub-io/model-registry-operator/internal/controller.(*ModelRegistryRec
onciler).updateRegistryResources\n\t/workspace/internal/controller/modelregistry_controller.go:373\ngithub.com/opendatahu
b-io/model-registry-operator/internal/controller.(*ModelRegistryReconciler).Reconcile\n\t/workspace/internal/controller/m
odelregistry_controller.go:200\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/opt/ap
p-root/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119\nsigs.k8s.io/contr
oller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/opt/app-root/src/go/pkg/mod/sigs.k8s.io/controll
er-runtime@v0.16.3/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Co
<EMAIL_ADDRESS>ler/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/opt/app-roo
t/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227\nruntime.goexit\n\t/usr
/lib/golang/src/runtime/asm_amd64.s:1598"}

@Al-Pragliola good point about the non-strict yaml unmarshal in your feedback in the other issue. I switched it in the yaml operator to avoid that possibility since it was a simple enough change.


Removed restangular from ParameterService

What does this PR (Pull Request) do?
Removes a dependency on Restangular from the "ParameterService"

[x] This PR partially addresses #3571

Which Traffic Control components are affected by this PR?

Traffic Portal

Traffic Portal dependencies are not individually documented, and so no documentation changes are necessary.
What is the best way to verify this PR?
No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.
Jeremy: actually, the only way to truly verify that the functionality did not change is to:

run the UI tests (which is a very small subset of all TP functionality)
manually verify the functionality associated with ALL the services functions that changed just to be sure all is well.

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3793/
Test PASSed.


if it tries to open Excel on MAC, Word, and a PDF file, "It is locked for edit"

Although OpenDirectory is built by MAC OSX 10.9.5 and I log in from Windows7 using pgina, After login, if it tries to open Excel on MAC, Word, and a PDF file, "It is locked for edit" will be displayed on nobody's being open.
If there is a solution, please let me know.
thanks.

This doesn't sound like a pGina issue, sorry.


Add missing arg in ElasticSearch ping function

Current coverage is 100% (diff: 100%)

Merging #28 into master will not change coverage

@@           master   #28   diff @@
===================================
  Files           1     1
  Lines          57    57
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           57    57
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update b22a0c4...4a6e733


[IT-2089] Remove obsolete patching mechanism

Forgot to remove obsolete patching mechanism in bridge and scicomp as part of PR #585

this is replaced by PR #592


The stderr and stdout file from sge should be viewable when a simulation is complete

When simulation is complete these files are uploaded to Girder, we should provide a mechanism for them to be viewed in the client. They will be particularly important for debugging setup issues in a traditional cluster, for example this is the output for a job where the hydra executable was incorrectly defined:
--------------------------------------------------------------------------
mpiexec was unable to launch the specified application as it could not access
or execute an executable:

Executable: /hydra
Node: ulmus

while attempting to start process rank 0.
--------------------------------------------------------------------------

The stderr and stdout are directed to two separate files:
.o - stdout
.e - stderr


pin on map.

Hello how can you filter the pin to display on the map only the devices online.

It's not possible at the moment.

hello, can we make a custom point bulding or some address on the map..?
i'm a newbie, please advise..

@chivasregal001, your question has nothing to do with the original suggestion. Please comment on an appropriate thread or create a new one.

thank you.


[BACKEND] Fix crash in reductions on i1

getScratchSizeInBytes was assuming that the size of all types in bits is
a multiple of 8. If it is not, it would return 0. This caused a bug for boolean
(i1) type, where the reduction lowering would attempt to use shared memory,
which was not assigned to the op.
Fix this issue by setting the number of bytes per element to ceil(bits / 8).

@ThomasRaoux I was looking at the test failure from the CI run, and I'm not quite sure how this could have caused a performance regressions for a f32 matmul. Could this be a flake / bad test?
I also can't reproduce this locally, since a bunch of the performance tests fail on my setup with an A100 even on  the clean main branch (this is with locking the clocks as done by the CI runner). Maybe the numbers you have are for A100-80GB? I'm attempting to run this on the 40GB version, and unfortunately don't have access to the 80GB one.

@ThomasRaoux I was looking at the test failure from the CI run, and I'm not quite sure how this could have caused a performance regression for a f32 matmul. Could this be a flake / bad test?
I also can't reproduce this locally, since a bunch of the performance tests fail on my setup with an A100 even on the clean main branch (this is with locking the clocks as done by the CI runner). Maybe the numbers you have are for A100-80GB? I'm attempting to run this on the 40GB version, and unfortunately don't have access to the 80GB one.

Yes that was probably a flaky test.
Looks like the lit test needs some update after hopper initial commit merge.

cc @zahimoud, this can be solved as well if we use "aligned size" instead of "tensor size".

The lit test should pass now @ThomasRaoux.


Reduce indicator size when the tab has margin specified

As per our design requirement, we needed to restrict the tab bar to have margins top and bottom as below.

Below is the implementation of the renderIndicator in the library
  private renderIndicator(props) {
        const { width, position } = props;
        const translateX = Animated.multiply(position, width);
        return (
            <Animated.View
                style={[ImageSelectionViewStyleSheet.container, { transform: [{ translateX }], width }]}
            >
                <View style={ImageSelectionViewStyleSheet.indicator} />
            </Animated.View>
        );
    }

How can I modify this so that the indicator doesnt overflow like shown in the screenshot above. My Animated API understanding is limited and I could not figure it out
react native version : 0.43.3
Librayr version : 0.0.59

@shrutic Can you post a minimum working example of this on https://snack.expo.io? At first look, this doesn't seem to be an issue with this library. It should be solvable by styling appropriately. I can give you more info on how to solve this once we have reproducible example from you.

This is definitely a problem with the library. The full width that the TabBar uses is the full width of the screen so if you have margins, the indicator width will be wrong.
@shrutic Did you find a solution?

Well I solved it by changing the design to use a tab underline indicator instead of a rectangular box. In this case it doesn't look awkward like my screenshot

renderTabBar function receives layout in the props object which you can modify before passing to the TabBar if you need to tweak the width. You can also render your custom tab bar and/or indicator.

👍 Thanks for the tips, I modified the layout property in renderHeader before passing it down.


Unable to load website.

Found this from a LinkedIn post and thought I'd give it a go, unfortunately it failed to load the page and I can only see the footer.
I'm getting a white screen when I load https://covid19-waiting-time.thejoin.tech/
A quick inspection of the console highlighted this the following:
TypeError: Cannot read property 'coords' of undefined
    at geoSuccess ((index):462)
    at foundPosition ((index):225)
    at stopTrying ((index):215)

Not sure if this is expected or not, I assume not.
If it makes any difference I'm using Chrome Version 80.0.3987.149

Hi Daniele,
thank you for your feedback, I appreciate that.
Today I was trying to fix some geolocation problem caused by a low accuracy.
It is possible that I generated some errors on my way.
Are you providing the geolocation permission or not?
Can you check it again? Because maybe it was an error that occurrend in the first morning.
I'm working hard to fix some bugs and to simplify the UI, without any flashes or white pages, so any feedbacks (good or bad) is like gold for me.
This is a super low budget project, unfortunatly.
Let me know! Thank you

Hey sorry for the late reply, it's working fine now.
FYI, I believe you once hold a class at my high school (ITI Leonardo Da vinci), during Vito Peduto's hours if I'm not mistaken, good to see you still rocking it!

No problem, indeed thank you for open up this issue.
It helps me a lot in the beginning of this project.
Yes, you remember absolutely well! Maybe you were in the upper year class, but yes, we met several times! Peduto rulez :)