Volume control for media player

Is your feature request related to a problem? Please describe.
Currently it is possible to mute and unmute videos embedded in posts, but it is not possible to adjust the playback volume.
Describe the solution you'd like
Add a pop-out volume fader as is frequently found on other video player interfaces on the web.
Describe alternatives you've considered
Writing a GreaseMonkey script to add a volume control, but obviously this doesn't work on the native apps.

Every video has been blasting me so thanks for opening this.
I would add that it ought to save your selection and apply to ever video thereafter, too. So if I set it at 70% volume for one video, the next video I play is also at 70% volume

Something I added on my ticket about this: Please use some sort of logarithmic conversion for the volume slider → video volume, since audio perception isn't linear!
Dr. Lex has a great blog post explaining why this is needed, and provides a simple, cheap-ish formula to convert between the two:
video.volume = Math.pow(slider.value /* in the range [0, 1] */, 4);

Until this gets pushed into production.. I made an extension, free and no data collection of course.
https://chromewebstore.google.com/detail/bluesky-better-video-and/adfccfhgcdigpnopaibalgimjioiddcg

@informatdcs it's already in production. You might be running into the bug where it won't show up if your device has touch screen support. There's an open PR for it here https://github.com/bluesky-social/social-app/pull/5919

Sure it does! Oh my god... I just read the feature request and since I've been using it like that since the start.. I didnt bother to check with anyone else or other browser, well... I made an extension 🤣 I will be adding comments on all the store pages saying that it is an issue in some browsers and a solution is WIP.
Thank you @brw

I also created a userscript for it in the meantime that overrides navigator.maxTouchPoints to be 0 fwiw https://greasyfork.org/en/scripts/518378-spoof-bluesky-mobile-detection

Just updated Edge chromium and it seems fixed!
El dom, 24 nov 2024 a las 20:26, Bas van den Wollenberg (<
@.***>) escribió:

I also created a userscript for it in the meantime that overrides
navigator.maxTouchPoints to be 0 fwiw
https://greasyfork.org/en/scripts/518378-spoof-bluesky-mobile-detection
—
Reply to this email directly, view it on GitHub
https://github.com/bluesky-social/social-app/issues/5285#issuecomment-2496185032,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGS7MFPADJ4ORZQUFJV7TL2CIR53AVCNFSM6AAAAABOCEALLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGE4DKMBTGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Did navigator.maxTouchPoints report 256 for you before? Someone else mentioned they had that and it's supposedly a bug in Windows/Edge. Perhaps that just got fixed then https://github.com/bluesky-social/social-app/issues/5856#issuecomment-2495542110

For me it reported just 2, but right now it reports 0, I'm on a desktop so
it should report 0 since I'm not using any touch sensitive controls.
El lun, 25 nov 2024 a las 0:02, Bas van den Wollenberg (<
@.***>) escribió:

Did navigator.maxTouchPoints report 256 for you before? Someone else
mentioned they had that and it's supposedly a bug in Windows/Edge. Perhaps
that just got fixed then #5856 (comment)
https://github.com/bluesky-social/social-app/issues/5856#issuecomment-2495542110
—
Reply to this email directly, view it on GitHub
https://github.com/bluesky-social/social-app/issues/5285#issuecomment-2496306422,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGS7MGIB3C52EKQCB2X7PT2CJLIRAVCNFSM6AAAAABOCEALLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGMYDMNBSGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update permissions display on organisations show page

Context
Update permissions display on organisations show page so it's consistent with the prototype: https://manage-applications-beta.herokuapp.com/organisations/show
Note: the black box should be blue
Changes proposed in this pull request

courses as a ratifying provider

Before
After

courses as a training provider

Before
After

Guidance to review

create variations of ProviderRelationshipPermissions
visit /organisations/:id

Question: what should I use in app/components/provider_relationship_permissions_list.html.erb?

[:training_provider, :ratifying_provider].each with send
separate them like on lines 22-27 of this file

Link to Trello card
Things to check

[ ] This code doesn't rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

Looking good — you could go one more turn of the crank, I think! https://github.com/DFE-Digital/apply-for-teacher-training/commit/c8ab64d525095f55eb92dbf3a1f7c764c37ebb23


Translation extractor

See the addition in the README for details.

This is super awesome! <3 <3 <3
Do you happen to know whether TranslationExtractor is capable of parsing placeholders (like This is a message with a %foo% placeholder where %foo% is the placeholder), so we could extend this lib to also validate that all placeholders are passed/given?

It is possible to extract that, but I am not sure about the placeholders. I don't think that we can match too much there.


Convert mthreading to use concurrent.futures

to provide support for futures and async processing
This came about when I wanted to be able to process jobs as they were completed, but the only supported operations for the thread pool was to submit new jobs, and to wait for all the jobs to complete. This left the main thread blocked unnecessarily.

Thanks so much for this change @c0d3d, will take some time to review 👍 💯

Is there any update on this merge request? I would love to use this functionality!

@hugocool I never got around to making the requested changes or benchmarks, so now progress.


[BugFix] Fix ORC late materialization bug when contains complex type column

ORC ASAN failed / StringVectorBatch oom / wrong answer about nullability may occur when a column contains complex type, and complex type column is treated as lazy load column.
But our implementation still has some drawbacks.

We can't support struct subfield lazy load, only support for root node now. (But for now, we don't support lazy materialization for subfields)
Must do filterOnFields(data, size, true_size, active_load_orc_positions, false) before filterOnFields(data, size, true_size, lazy_load_orc_positions, true), otherwise we will set wrong notNulls vector. This means that the wrong order of calls will cause bugs. (You must make sure to filter the active column first, then do filter the lazy column)

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

Must do filterOnFields(data, size, true_size, active_load_orc_positions, false) before filterOnFields(data, size, true_size, lazy_load_orc_positions, true), otherwise we will set wrong notNulls vector. This means that the wrong order of calls will cause bugs. (You must make sure to filter the active column first, then do filter the lazy column)

Could we add a flag to check if (true) is called before (false)?  If not, we can throw exception to find problem ASAP.

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

Must do filterOnFields(data, size, true_size, active_load_orc_positions, false) before filterOnFields(data, size, true_size, lazy_load_orc_positions, true), otherwise we will set wrong notNulls vector. This means that the wrong order of calls will cause bugs. (You must make sure to filter the active column first, then do filter the lazy column)

Could we add a flag to check if (true) is called before (false)? If not, we can throw exception to find problem ASAP.

added

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergify backport branch-3.1 branch-3.0 branch-2.5


Support for non-Docker environments

Let's track adding support for operating systems and environments that don't have Docker. There are various options being discussed (containerd, podman) and this issue can be used to track the overall progress.
Once completed, this will enable:

Any operating system that doesn't have Docker
Building installers without a docker plugin (even for OS with docker support)
CentOS 8
RHEL 8

Kubelet requires a container runtime daemon listening on a unix socket. Containerd and CRI-O both have that, but podman does not, although it's possible the new HTTP API coming in podman 2.0 will work.
The other issue is loading images from an airgap bundle. With podman the docker CLI commands in the kURL install scripts work if you also install the podman-docker package, but for containerd the scripts will need to use ctr image import.

It is possible to get docker running on CentOS 8 with a couple of manual steps.

@areed Thanks for the extra info.
It sounds like the best non-docker solution available today (before Podman 2) is to support the containerd CRI? CentOS 8 support would come, but that’s slightly different from this issue, which is to support non-Docker environments for the installer.

Yes, containerd would be simpler than cri-o because containerd has the ctr CLI for loading images but for cri-o we'd need to install skopeo separately and push all images to the local registry.

Closing as we now have containerd support


[SPARK-36666][SQL] Fix regression in AQEShuffleReadExec

Fix regression in AQEShuffleReadExec when used in conjunction with Spark plugins with custom partitioning.
Signed-off-by: Andy Grove<EMAIL_ADDRESS>
What changes were proposed in this pull request?

Return UnknownPartitioning rather than throw an exception in AQEShuffleReadExec.
Why are the changes needed?

The RAPIDS Accelerator for Apache Spark replaces AQEShuffleReadExec with a custom operator that runs on the GPU. Due to changes in SPARK-36315, Spark now throws an exception if the shuffle exchange does not have recognized partitioning, and this happens before the postStageOptimizer rules so there is no opportunity to replace this operator now.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

I am still in the process of testing this change. I will update the PR in the next few days with status.

Can one of the admins verify this patch?

cc @cloud-fan , @viirya @maryannxue , @ulysses-you

Also, cc @gengliangwang

mind fixing PR title to summarize which regression it is?

ok to test

Test build #143010 has started for PR 33910 at commit 6cd7cc1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47512/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47512/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47512/

Test build #143010 has finished for PR 33910 at commit 6cd7cc1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143010/

Test build #143050 has started for PR 33910 at commit a5eb19b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47553/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47553/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47553/

Test build #143050 has finished for PR 33910 at commit a5eb19b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143050/


our story page

Our story:

model : contents, img, color, order
view
html

![lliourstory](https://cloud.githubusercontent.com/assets/10239547/12971834/ae205a6e-d0e2-11e5-89e4-3332f18449a8.png)
![lliourstory2](https://cloud.githubusercontent.com/assets/10239547/12971835/ae2155ea-d0e2-11e5-9f20-f550cbd55ebe.png)

We need to fix the css/html with design. maybe 5/7 pull/push. (note to self)

need to : delete or change page title and how it's added


Use providedLabel in TimeSpan for MAP 3.1

Use providedLabel with preference, falling back on prefLabel if needed.

👍


add support for oracle-oci builder

see oracle-oci
added to packer v1.1.0

I am working on this. :+1:


Consider using budo for local browserify development

Instead of the watch script, it'd be nice to use budo for local development. It starts a local dev server and supports an option to live reload the page whenever the browserify bundle changes.

I'd prefer to stick to the watch script as it stands. I run my own local apache which exposes all of my projects via localhost/~smus/Projects/. Bundling a webserver seems to prescriptive to me.


Show a better page when a directory is empty

Right now if a directory is empty the user only sees the header and breadcrumbs. We need an empty state like "There are no files here. 👩🏼💻👨🏿💻 Create some!"

@mpacer noticed this while working on /api/s3-contents


Firefox?

Hi
Do you have a rough timeline for the FF support? I saw that it is in the roadmap. As far as I can tell there are no FF extensions that helps with locally tunning LLMs

I'm working on it. It needs to do a few migrations in order for the extension to work on both Chrome and Firefox. Hopefully, the Firefox version will be released this weekend or next week

Amazing thanks for the hard work

Hey, guys, Page Assist now officially supports Firefox.
You can download the extension from the Firefox add-on store: https://addons.mozilla.org/en-US/firefox/addon/page-assist/
Please let me know if you face any issues.

Thanks, that is great. Is it possible to put the assistant window on the right instead of the left by default?


Full module descriptor support for all builtin themes

Module descriptors are essential for modules to co-operate with a theme's content and to be loaded correctly. The builtin themes are extremely lacking in support for this and, so far, only just about do enough to work with builtin themes.
This is holding back progress torwards standardisation, and is a very bad for our progress towards better module APIs. Builtin DSJAS themes need full module descriptor support.
Checklist

[x] Default theme
[x] Default minimal
[x] Felicity bank

Tested this as much as I can, so I'm happy to merge and get ready to release this in beta.


Still active?

I want to know if the creator is still active, thank you

@kingleuther yes I am. Do you need something?

@mikield  i will be using your library, in case I get into any trouble, can I ask for your guidance and/or help?

Yes, of course. I will support it and fix any issues as fast as i can.
ср, 6 июн. 2018 г., 11:03 Leuther Mojica<EMAIL_ADDRESS>
@mikield https://github.com/mikield i will be using your library, in
case I get into any trouble, can I ask for your guidance and/or help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mikield/adonis-user-policy/issues/2#issuecomment-394998351,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD4oyNz7kPel4xzSjgvqwD7GGFQrC2pwks5t55rwgaJpZM4UaBqZ
.

@mikield thanks! I will let you know if I encounter an error


HDFS-3570. Balancer shouldn't rely on "DFS Space Used %" as that ignores non-DFS used space

Description of PR
Balancer shouldn't rely on "DFS Space Used %" as that ignores non-DFS used space
Report from a user here: https://groups.google.com/a/cloudera.org/d/msg/cdh-user/pIhNyDVxdVY/b7ENZmEvBjIJ (Not available now) , post archived at http://pastebin.com/eVFkk0A0
This user had a specific DN that had a large non-DFS usage among dfs.data.dirs, and very little DFS usage (which is computed against total possible capacity).
Balancer apparently only looks at the usage, and ignores to consider that non-DFS usage may also be high on a DN/cluster. Hence, it thinks that if a DFS Usage report from DN is 8% only, its got a lot of free space to write more blocks, when that isn't true as shown by the case of this user. It went on scheduling writes to the DN to balance it out, but the DN simply can't accept any more blocks as a result of its disks' state.
It would be better if we computed the actual utilization based on (100-(actual remaining space))/(capacity), as opposed to the current (dfs used)/(capacity). Thoughts?
This isn't very critical, however, cause it is very rare to see DN space being used for non DN data, but it does expose a valid bug.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  8s

trunk passed

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 44s

trunk passed

+1 :green_heart:
shadedclient
25m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 33s

the patch passed

+1 :green_heart:
shadedclient
25m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
353m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

471m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5044/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5044

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux f6778e909231 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e0e1a60554aa05ff878fc9685e6cb4b3ec01f618

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5044/1/testReport/

Max. process+thread count
2252 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5044/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 15s

trunk passed

+1 :green_heart:
compile
1m 44s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 40s

trunk passed

+1 :green_heart:
shadedclient
23m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 25s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 16s

the patch passed

+1 :green_heart:
shadedclient
22m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
243m 56s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

357m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5044/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5044

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 35a3ff40da0a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 43e802df586a2e1d8e8a429d64b9163b20d927f9

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5044/2/testReport/

Max. process+thread count
3023 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5044/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka @ZanderXu - Please help in reviewing . Thanks.

@aajisaka @ZanderXu,  Please help in reviewing this PR in your free time. Thanks.

@ashutoshcipher Noted, I will review it this weekends.

Thank you so much.

Thanks @ZanderXu, I will work on writing UT.

It seems to be a bit tricky for writing UT for this. Any suggestions on how to take this PR forward or on UT.
@slfan1989 - Any suggestions from your side.
Thanks

@ZanderXu @slfan1989 any suggestions ?


Corrected some incorrect phpdoc and default values

Merged in https://github.com/bugsnag/bugsnag-php/commit/4733952f32716a8c533dcc5eae3ffabe00340a98


Crate name

The crate name shmem is already taken by https://github.com/meh/rust-shmem (which is what your documentation link in the README points to!), are the two crates related?

They are not (weird, I was sure I had answered that), and we've finally gotten around to renaming the crate and publishing it on crates.io!


[Request] De-Compressed Meshes

Have been any improvements on Mesh decompression? Thanks!

@andburn wrote the Mesh-to-OBJ exporter. Is there something specific missing from it?

Well, at export.py:141 there's a "TO-DO" comment. If mesh_compression flag is present, the meshes are not processed.
I've tested with some compressed mesh bundles and are not exported.

PRs welcome then :)

Ha, ha. I've been digging for info about the mesh compression method but I've found nothing worthy.
The only clue I found is prehistoric https://forum.unity3d.com/threads/mesh-compression-what-does-it-actually-do.33073/


Replace Number.MAX_SAFE_INTEGER with integer.MAX_VALUE

It has been found that some of the clients of ALS do not support large integer values from the server responses and therefore they are unable to produce desired results in their extensions. One such scenario is in the case of diagnostics report sent by the server.
The PR fixes the issue by replacing Number.MAX_SAFE_INTEGER [ value:<PHONE_NUMBER>740991 (2^53 − 1) ] with integer.MAX_VALUE [ value:<PHONE_NUMBER> (2^31 - 1) ].

Please add changelog fragments and tests as applicable. Thank you!

Appropriate changes in the tests have been made in the PR.

Out of curiosity, why not using -1 instead? It would be much easier to read than very long numbers.

@ssbarnea, the idea here is to have a red squiggly line across the error line entirely.
Passing -1 to the character part in the range object does won't give the desired result. I have explained this here: https://github.com/ansible/ansible-language-server/pull/246#issuecomment-1064822691

@priyamsahoo  its working well in neovim, thank you 👍
you can see at the bottom of neovim your new number value from column being passed in.
https://user-images.githubusercontent.com/36175703/157906473-6956a591-3cea-4be7-add6-685118f6867d.mp4


Responsive Spacing

Being a mobile first framework, I feel that users would get a lot of utility from having spacing functions that are responsive. For example, margin can become 0 whenever the screen falls below a certain width. Otherwise, certain components look awkward without being responsive.

As I understand it, this already exists: https://getbootstrap.com/docs/4.1/utilities/spacing/#notation

The classes are named using the format {property}{sides}-{size} for xs and {property}{sides}-{breakpoint}-{size} for sm, md, lg, and xl.

For example: mx-0 mx-md-2 mx-lg-3.

Thank you so much for this! This somehow missed my notice. These are super helpful.


Introduce single JavaObjectSerializationCodec

Documenting the limitations of configuration cache support for Java Object Serialization.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@bot-gradle test this

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


Fix cross-attention control VRAM usage and index bug

This PR addresses excessive VRAM usage with .swap and also fixes a silly bug

@lstein Good to go for 2.1 ... Magical fix from @damian0815  ... swap no longer takes any extra VRAM. Great results too.


Add create webview event and fix fire event in model view

@MattIrv It is specific to editor component, and I only add that event to editor

@AbbiePetcht Makes sense, I misunderstood what you were trying to do. Thanks!


Static files really suck.

The way that hendrix exposes static files, by default, is great.  It puts an additional child on the Root object, causing the static directory to be served as a directory.
The way that it collects static files, however, is awful.  There's already an app for this - it's called Django. Let's leverage the staticfiles functionality in django instead of the guesswork that currently occurs.

No longer true.  :-)


login.microsoftonline.com refused to connect in spfx solution

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
SharePoint REST API
Developer environment
Windows
What browser(s) / client(s) have you tested

[X] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[X] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

Node version: 10.18.0

Package.json: {
  "name": "xxxxxxxxxxxxx",
  "version": "0.0.1",
  "private": true,
  "main": "lib/index.js",
  "engines": {
    "node": ">=0.10.0"
  },
  "scripts": {
    "build": "gulp bundle",
    "clean": "gulp clean",
    "test": "gulp test"
  },
  "dependencies": {
    "@fluentui/react": "^8.9.0",
    "@microsoft/sp-core-library": "1.11.0",
    "@microsoft/sp-lodash-subset": "1.11.0",
    "@microsoft/sp-office-ui-fabric-core": "1.11.0",
    "@microsoft/sp-property-pane": "1.11.0",
    "@microsoft/sp-webpart-base": "1.11.0",
    "@uifabric/file-type-icons": "^7.6.30",
    "office-ui-fabric-react": "6.214.0",
    "react": "16.8.5",
    "react-dom": "16.8.5"
  },
  "devDependencies": {
    "@types/react": "16.8.8",
    "@types/react-dom": "16.8.3",
    "@microsoft/sp-build-web": "1.11.0",
    "@microsoft/sp-tslint-rules": "1.11.0",
    "@microsoft/sp-module-interfaces": "1.11.0",
    "@microsoft/sp-webpart-workbench": "1.11.0",
<EMAIL_ADDRESS>"0.3.5",
    "gulp": "~3.9.1",
    "@types/chai": "3.4.34",
    "@types/mocha": "2.2.38",
    "ajv": "~5.2.2",
    "@types/webpack-env": "1.13.1",
    "@types/es6-promise": "0.0.33"
  }
}

Package-solution.json
{
  "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/package-solution.schema.json",
  "solution": {
    "name": "solution",
    "id": "00e8d953-213e-4a44-a99e-72102f881b2d",
    "version": "<IP_ADDRESS>",
    "includeClientSideAssets": true,
    "skipFeatureDeployment": true,
    "isDomainIsolated": true,
    "developer": {
      "name": "",
      "websiteUrl": "",
      "privacyUrl": "",
      "termsOfUseUrl": "",
      "mpnId": ""
    }
  },
  "paths": {
    "zippedPackage": "solution/solution.sppkg"
  }
}

Describe the bug / error
I developed 3 weparts using spfx and react, but when i did de deploy some users had the next error with de webparts:

Initially i thought in permission error, but the users with the problem can access to the webpart with his office 365 account from the computer of a user without problems.
Next i tried with cookies polices and put them to "Allow all cookies", both Google Chrome and edge, but nothing.
Finally with the account of user without problems i logged in the computer of a user with problems and effectively the user had the same error.
I have not idea what can be the error or who policy in the computer can restrict login.microsoftonline.com in sharepoint framework solution because the other content of the tenant can be access without problems. The total of the users with this problem is like 30% of ~1000. The webparts was tested in Internet Explorer, Microsoft Edge ,Google Chrome, FireFox, and the results was the same in both cases.
Steps to reproduce

Develop sharepoint framework and react webparts
use the command npx gulp bundle --ship
use the command npx gulp package-solution --ship
Deploy the .sppkg file in sharpooint online site as sharepoint application

I concur, there is something odd here.
The browser console errors suggest that iFrames are the issue. Personally, I followed the MS tutorials to create a web part, it works brilliantly on the local workbench, but I get the same error when I've deployed the sppkg out to my site.

Any news on this, it say the issue still says it needs triage?

No, no answers yet

Hello.
Can someone help with this? This is not just an Edge error as they try to explain in this issue #7136. Can this be an issue related to the domain? As @Marcos-Coca  said, this just happens with certain users.

Sorry for the delay in responding.  Can you fill in any additional information here?  Is this an isolated part?  Are you running the page in a browser, or embedded in a teams channel / tab?  Do you have a multi-geo tenant or vanity domains?

For me this is an isolated webpart on a web page developed by myself,on a Team Sharepoint site. Ours is a single tenant, no vanity address, viewed through various web browsers.

Oh and the webpart was developed by following Microsoft's walk through pages:
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/set-up-your-development-environment#install-yeoman-and-gulp
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/get-started/build-a-hello-world-web-part
I don't remember reading anything about the webparts rendering in iFrames and the webpart works beautifully in the workbench.

Sorry for the delay in responding. Can you fill in any additional information here? Is this an isolated part? Are you running the page in a browser, or embedded in a teams channel / tab? Do you have a multi-geo tenant or vanity domains?

Is this an isolated part? : I'm not sure but, i followed the guide for hello world webpart and in my package-solution.json has the property solution:{..."isDomainIsolated": true} and in the .yo-rc.json has the property "@microsoft/generator-sharepoint":{... "isDomainIsolated": true}.

Are you running the page in a browser, or embedded in a teams channel / tab? : i ran the parts in browser, is hosted in sharepoint online team site.

Do you have a multi-geo tenant or vanity domains?: Not have multi-geo tenant but we did a domain change and for the time being have two domains.

Hey @Marcos-Coca - can you try one thing?  What happens if you load the main page with ?sw=bypass as a query string?

@patmill I tried with my account and nothing happened, do you need me to do the test with user who has the problem?

If you could try it with the person facing the issue that would be great.  If you saw the error, and it did nothing - that's sufficient.

Bizarrely, without changing anything in code or in my test browsers the offending webpart now fully works! The sw querystring didn't seem to make a difference.
I'd love to know what has changed behind the scenes with SharePoint online!

@patmill nothing happened

Trying to figure out the state of things.  is this specific scenario working now for everyone?

@patmill  no, the error still happens.
Something new that I observed is, some users has the problems when use ie11 but when changes to chrome or other browser works fine, others users does not work with either.

Hi there @Marcos-Coca - trying to dig in a bit more.    If so, could you paste the requests (and please remove things like secrets, nonces, etc.)


[hotfix/release]4.0.0 beta 32.0.7 Tls support

Motivación y Contexto

4.0.0 beta 32.0.7 Tls support
Descripción

Cómo probarlo

Screenshots

Tipo de cambio (para el release manager)

[ ] Breaking change (Fix o feature que cambia una funcionalidad existente o rompe firmas)

[ ] Mi cambio afecta a los integradores internos

Compartir conocimiento

Codecov Report

Merging #1102 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1102      +/-   ##
===========================================
+ Coverage    29.23%   29.29%   +0.05%
===========================================
  Files          326      325       -1
  Lines        14689    14666      -23
  Branches      1337     1336       -1
===========================================
+ Hits          4295     4296       +1
+ Misses        9882     9863      -19
+ Partials       512      507       -5

Impacted Files
Coverage Δ

...c/main/java/com/mercadopago/core/CustomServer.java
0% <ø> (ø)
:arrow_up:

...main/java/com/mercadopago/core/MerchantServer.java
0% <ø> (ø)
:arrow_up:

...dk/src/main/java/com/mercadopago/util/ApiUtil.java
11.11% <0%> (-3.34%)
:arrow_down:

...c/main/java/com/mercadopago/CardVaultActivity.java
63.5% <0%> (+0.35%)
:arrow_up:

...k/src/main/java/com/mercadopago/ErrorActivity.java
63.07% <0%> (+4.61%)
:arrow_up:

...a/com/mercadopago/exceptions/MercadoPagoError.java
90% <0%> (+5%)
:arrow_up:

...m/mercadopago/providers/CardVaultProviderImpl.java
50% <0%> (+5.55%)
:arrow_up:

.../main/java/com/mercadopago/mvp/TaggedCallback.java
100% <0%> (+28.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d5867...8f2ebfa. Read the comment docs.


Typo in docs

https://github.com/vocodedev/vocode-python/blob/116de1d147b5df81ad6253316eaba63cd763caef/docs/configuring-number.mdx#L73C3-L73C10
voiceId should be speaker for Typescript:
const rimeVoice = {
  type: "voice_rime",
  voiceId: "RIME_SPEAKER",
};
const number = await vocode.voices.createVoice(rimeVoice);

Fixed in #446


[python] Remove special type handling in QueryCondition parser required for Python 3.7

https://github.com/single-cell-data/TileDB-SOMA/blob/main/apis/python/src/tiledbsoma/_query_condition.py#L374-L379
The Python AST module had a significant refactoring between 3.7 and 3.8 which in our code required special handling like in the example above. In 3.7, ast.Num, ast.Str, and ast.Bytes nodes needed to be handled separately. As of 3.8, that was deprecated and are now handled as ast.Constant or ast.NameConstant.

Related to #2181


Python 2.7 end of support

The Python language governing body – Python Software Foundation (PSF) – will end support for Python 2.7 on January 1, 2020. Amazon is encouraging users to upgrade to Python 3 as a result of this.
Can this sample be upgraded to use Python 3 soon please?

Hi Saifeer,
Actually I think the documentation is out of date, but the code is actually working with python 3.6 runtime.
I felt the same way at first, but when I selected python 2.7 as the runtime, I was getting a few weird error messages. I changed it to python 3.7 and all those error messages went away!
Give it a try, and let us know how it went!
Cheers,
Sergio

Hi guys,
The blog post that refers to this project was updated: https://aws.amazon.com/blogs/security/how-to-automatically-update-your-security-groups-for-amazon-cloudfront-and-aws-waf-by-using-aws-lambda/

Note from December 3, 2019: The features and services described in this post have changed since the post was published and the procedures described might be out of date and no longer accurate. If we update this post or create a replacement, we’ll add a notification about it here.

The current code (latest commit in the master branch) is already using Python 3.


Add suport for external solium configuration

Similar to solhint https://github.com/juanfranblanco/vscode-solidity/blob/master/src/linter/solhint.ts#L75-L90 it will be great to load the solium configuration from a file.

I will have a look and try my best.

Awesome thanks :)


Incorrect handling of base quality

Problem Description
While Factory Planner correctly accounts for the quality modifier being off by a factor of 10 on modules, it does not appear to account for it with machine base effects. This usually isn't an issue due to vanilla having no machines with base quality modifiers, but Maraxsis adds the hydro plant which does have one.
Reproduction

Install Maraxsis
Setup a production line in Factory planner for a product that can be made in the Hydro Plant
Observe that the reported quality chance is 500% instead of 50%

Quality Assurance (my mod) can add base quality to all crafting machine prototypes and mining drills.
+1 (even though I'm only using factory planner so I can fix an issue with one of my mod's users)


Run negative unit test compilation in different process

Codecov Report

Merging #18195 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18195   +/-   ##
=======================================
  Coverage   15.08%   15.08%
=======================================
  Files          48       48
  Lines        1246     1246
  Branches      192      192
=======================================
  Hits          188      188
  Misses       1044     1044
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d51fe...941f1c4. Read the comment docs.


Add other direct standard fields

I cleaned up some other stuff while I was at it. Is this a bit too much? If you want, just running it and seeing that it works may be enough. See docs on how to get github code into your playground.
No proxies (x, i, j, etc.), not object or object_checkboxes. Close #3, close #4, close #5, , close #6, close #7, close #8, close #9, close #10, close #11, close #12, close #13, close #14, close #15, close #16, close #65.
I think 'checkbox (other)' and 'checkboxes (none of the above)' can be tested together, as the latter is just an extended version of the former and shouldn't affect tests of the former.
Can possibly be followed by first round of tests.

That is a beautiful image!


Mute Button

Hi - I currently have my LMS playing internet radio pretty much all day while working from home.
Would it be possible to add an optional mute button somewhere?  Would be very handy when taking a call to cut the sound rather than kill the stream.
I get I could just drag to zero, press stop, turn off the amp, etc., but when the phone/PC rings a quick mute would be perfect.

Long press the volume button.

Thanks!  Tried double-clicking it, but not long clicking.
(would prefer the option of a dedicated button though, since when I need to mute it's relatively urgent)


[Request]: Show NSSharingServicePicker asynchronously on main thread

Plugin
share_plus
Use case
We're using the share_plus plugin to share one or multiple files after it has been downloaded. After the download of the files we still need to update the UI. But since the NSSharingServicePicker is presented synchronously on the main thread the UI hangs.
Proposal
Show the NSSharingServicePickerasynchronously on the main thread, so that the UI can continue to update.
let picker = NSSharingServicePicker(items: items)
DispatchQueue.main.async {
    picker.show(relativeTo: origin, of: view, preferredEdge: NSRectEdge.maxY)
}

@leonx98 is this request for iOS or for MacOS? You did not specify.

Thanks! Thats fixed with the linked PR


#111 : Reorganize Readme

Currently, the link to the contributing file is not there.

Thanks a lot for review @srish !! I have made all the changes that you suggested.
Should I decrease the size of MediaWiki logo more or is it fine?


Don't send emails for deleted messages

Currently if you @-mention or PM someone offline and then delete the message, they'll still get an email. I'm guessing the right way to handle this is to do a check for if a message is deleted in send_email_job of deliver_email.py, but haven't read the code path carefully.

Good point, it was missed message. Not sure if this also happens with digest emails, but that seems less important if there are lots of things in the digest.

I agree with the issue, but don't see a direct way in solving it. When a message is missed it is been converted to html/text email format and sent to Mandrill's mail_client messages to be send at a given time :
send_time = (timezone.now() + delay).__format__("%Y-%m-%d %H:%M:%S")
results = mail_client.messages.send(message=message, async=False, ip_pool="Main Pool", send_at=send_time)

So, what I think we can do is implement a side thread that waits till the sent_time and then send the mail, after checking if the message is deleted or not. (Just a logic not being programmatic)
Or we can send a delete mail later :P

@zulipbot claim

@dattatreya303 just make sure to claim this task before, so nobody accidentally works on it before you do.


Infer Types for Generic Type Parameters That Are Not Specified

Suggestion
Infer types for generic type parameters that are not specified.
🔍 Search Terms
Search Inputs:

infer, type, for, record
[x] I have read the FAQs for feature requests.

Search Time: 21:01.23 (21 minutes)
Potentially related issues (in order of interest):

#29791 (I found this comment particularly interesting).
#10571

Though related, I couldn't tell if these issues were exactly the same since the scope here is more narrow.
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

The third one threw me off a little. But since the suggestion bases itself on existing TS features, I think this should be safe.
⭐ Suggestion
This is a suggestion to infer types for generic type parameters that are not specified. As an example for clarity, you can play with the code below on the typescript playground:
function genericFunction<V = unknown, K extends string = string>(arg: Record<K,V>) {
    return arg;
}

const input = { a: 1, b: 2 };

// Property names ARE inferred
genericFunction(input);

// Property names NOT inferred
genericFunction<number>(input);

In the above example, you'll noticed that when no type parameters are provided, TypeScript is able to correctly infer the types on its own. This thankfully includes the property names of the passed object.
However, when any type parameters are provided, TS assumes the default values for all of the remaining type parameters. This actually causes information to be lost, even though the situation hasn't changed. That is, in both situations, the user never explicitly specified the type of the keys, K.
Instead of assuming the default values for the remaining parameters whenever any types are specified, TS should continue to infer types for the remaining type parameters. The current functionality makes me assume there's some algorithm that tries to infer the types when no type parameters are specified, and it's able to infer object keys. I'd imagine that same algorithm can simply be taken and used to "move down the list of type parameters", so to speak. So it would look for any remaining unspecified types and infer them instead of applying the default values.
📃 Motivating Example
Improved Type Inference for Generics
Previously, when working with optional generic type parameters, TypeScript would assume the default values for any types that the user failed to specify. The issue only occurred if the user specified some of the type parameters. This caused information to be lost (particularly for objects) if the user wanted to specify only a subset of the available types.
Now, TypeScript correctly infers the types for type parameters that are not explicitly provided by the user. The default value is only used if one cannot be determined.
const object = { a: 1, b: 2 };

function foo<Value = unknown, Key extends string = string>(input: Record<Key,Value>): Record<Key, Value> {
  // ...
}

// Object correctly typed as Record<"a" | "b", number> instead of Record<string, number>
const output = foo<number>(object);

💻 Use Cases
Currently, packages like React JSS rely on TS to improve the user experience. In the case of React JSS, a user supplies an object of key-value pairs, where the values represent CSS styles for components. Users have to keep track of the keys because they're used to identify the different styles. See the React JSS playground for a clear example.
As you'll see in the playground, the class names can be inferred for an improved experience. However, after receiving a request for improved prop-type recognition (cssinjs/jss#1273), the library needs to include generic types. Once generics are introduced, users will get type inference for React prop types but will then lose automated inference for object keys, recreating the issue of poor intellisense.
The only workaround for this issue is to supply a list of strings ("A" | "B" | "C") as a type parameter for the class names. But this can get long with a larger number of style declarations, and it's redundant.

Duplicate of #26349. Partial type inference is on the roadmap under the "Future" section.

Man. All that searching and still couldn't find that thing. Thanks @MartinJohns!

Wait @MartinJohns are you sure about that? This situation is a bit different. The ReactJSS library exports functions that the user can use. The (proposed) type parameters are <Props, Theme, and ClassNames>, and they all have defaults. The PR you mentioned involves something the user would still have to do.
Ideally, the user could do something like createUseStyles<PropTypes>(styles) and leave it at that. But, if the user only wanted to supply props, then they'd need to do createUseStyles<PropTypes, _, _>(styles). They'd have to "reach over" Theme, which is a bit strange to me.
Writing this out now, I guess an alternative is for the library to rearrange props to something like <ClassNames, Props, Theme>. However, this means that every time the user calls createUseStyles, they will be forced to add an additional _ whenever they want to simply use props. The PR you mentioned doesn't necessarily resolve this issue.
Thoughts? I'd also like to hear the thoughts of some others briefly. It could be that this is just the trade-off libraries need to take: First, default parameters would need to be defined last. Next, any potential "implicit default params" would need to be put before all the other default params.

How would you differentiate between inferred type arguments and default type arguments? The idea the TypeScript team plays with is the _ sigil.

Ah. So you're saying other devs may want all the defaults to appear when at least one type is supplied? And that in that case differentiating between defaults and implieds would be impossible?


Switch from USVString to Blob for body content.

Fixes #29, I think.

Well that's a very subtle bug. Thanks for finding and fixing this 👍 !
Appreciate all of the upstream contributions y'all have made.


feat (ui): source language flags

I've been thinking about it while making this already. But the Traditional Chinese used as Taiwan is for the app's language, not really website (source) language. However, I don't know if that also apply to website language as well? Do websites which have traditional language also like that?


github-discovery processor to support collecting catalog-info.yaml from default branches

It would be nice If we can configure the github-discovery processor to collect from the default branch rather than an explicitly configured branch. If there are branches being migrated from master -> main it is suggested to set the discovery processor with the master branch.
There are challenges using the discovery processor like this in the following scenario:

The main branch is set as the default branch
The master branch exists but contains an old version without a catalog-info.yaml file

In this scenario backstage will receive a 404 from GitHub and fail to collect the catalog item/s.
Feature Suggestion
I like to suggest that the processer first discover the default branch via the api and then collect the catalog item. I think that this makes the processor more robust.
Possible Implementation
I have a proposed patch. Ill push it and link it here.
Context
At present it is complicated to configure the catalog processor in a way to easily discover catalog items from github. This is because many projects are currently in the process of migrating from master -> main. With GitHub defaulting from master->main and the inconsistent behavior of this it becomes difficult to achieve.

Here is a suggested solution for this suggestion https://github.com/backstage/backstage/pull/6930


chore: update README.md

In relation to https://github.com/kubernetes/org/issues/5054 this adds an archival notice to the README.

/assign @mcluseau

/approve

/lgtm


Binaries contained in nuget(SharpIPPNext) are not generated using a strong name

We opened this issue here because in SharpIppNext fork issues are not enabled.
Binaries contained in your NuGet(SharpIPPNext) are not generated using a strong name, when we use your asset as third party we receive the advise from Cybersecure auditory.
Use strong-naming have some benefits explained by Microsoft official documentation
https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming
The benefits of strong naming on .NET Framework are:

The assembly can be referenced and used by other strong-named assemblies.
The assembly can be stored in the Global Assembly Cache (GAC).
The assembly can be loaded side by side with other versions of the assembly. Side-by-side assembly loading is commonly required by applications with plug-in architectures.

Thanks in advance.

@alonsoto I updated my fork to generate a standard and strong-named version.
Search for SharpIppNext.StrongName version 1.0.11.
I verified it with command sn -v SharpIpp.dll and it was valid.
I enabled issues on my fork.
Close the issue if everything will work.

Hi @danielklecha  we checked with tool an this is the result.

We are little be puzzled.
Thanks in advance.

@alonsoto I configured GitHub Action to generate two packages. SharpIppNext and SharpIppNext.StrongName. You should use this second package.


chore: fixes an issue with the e2e tests

🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #4082

For us to review and ship your PR efficiently, please perform the following steps:

[x] Open a bug/issue before writing your code 🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved.
[x] Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
[x] Update or add tests (if any source code was changed or added) 🧪
[x] Update or add documentation (if features were changed or added) 📝
[x] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

now exiting with the appropriate exit code

Shouldn't the test fail when there are unmet peer dependencies too? https://github.com/netlify/cli/runs/4866793722?check_suite_focus=true#step:6:376

It does not block the user (as it does not crash the install) Therefore the test should not fail.
Only if something is blocking the user it should fail the test. It's basically a safeguard so that we know if we would break something for a user :)


[Event Request] Bypass Currency and Unit Cost tests on codeunit 1001 "Job Post-Line"

Dear BaseApp team,
Please consider the following changes.
Two new events on codeunit 1001 "Job Post-Line"
OnBeforeCurrencyCheck
Need to disable the cross testing of currency code between Sales Header and JobPlanningLine, because our users need to be able to make one invoice with just one currency, but taking quantities from multiple Jobs having multiple currencies.
OnBeforeValidateRelationship
Similarly we need to be able to bypass the “Unit Cost (LCY)” check in function ValidateRelationship. Preferably we would like to be able to replace the ValidateRelationship function with a custom version. So one more added event OnBeforeValidateRelationship with handled pattern would be very appreciated.
See both event suggestions below:

Thanks in advance

@Carnesor , there is existing event OnBeforeValidateRelationship, it will be updated with IsHandled parameter.

That is even better, thanks.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Include mojo in component build

This is needed for https://github.com/electron/electron/pull/5413 to build in Debug mode, thanks to @deepak1556 who actually did this PR, I'm just the guy applying the patchfile :)

After chrome50
<(DEPTH)/third_party/mojo/mojo_public.gyp => <(DEPTH)/mojo/mojo_public.gyp

I think we should wait for the upgrade, also the static libraries need to be shipped and linked in brightray.

I think we should wait for the upgrade

Agree, I'll retarget this to chrome50

Don't need it!


Replace spack installation with git clone

There is no reason that spack installation to be a class, git clone should be enough for this purpose


Create Fake Data from Live Data

We need to take a batch of live data and de-identify it and turn it into "quasi-fake" data. We need to change any PII, but leave things like test results, etc in place.

PR generated. Please review: https://github.com/CDCgov/prime-data-hub/pull/404

PR generated. Please review: https://github.com/CDCgov/prime-data-hub/pull/404


Unable to resume the run when the process restarts itself with os.execv()

Description
If wandb is active (wandb.init() was called), any call to os.execv() crashes the process.
If wandb.finish() is called before os.execv() the process resets successfully, although subsequent resume=True is ignored, instead, wandb starts a new run with the same name.
How to reproduce
Use this script to reproduce. This exact version crashes on os.execv(). If wandb.run.finish() line is uncommented, wandb starts a new run on each reset.
import os
import sys
import time

def main():
    import wandb
    wandb_project = '[YOUR_PROJECT]'
    wandb_user = '[YOUR_USERNAME]'
    resume = sys.argv[-1] == '--resume'

    wandb.init(
        project=wandb_project, entity=wandb_user, sync_tensorboard=True,
        name='restart_self_test_456',
        group='restart_self_test', job_type="sandbox", tags=['restart_self_test'],
        resume=resume,
    )

    print('starting!')
    time.sleep(2)
    print(f'restarting! {sys.executable}, {sys.argv}')

    # print('Finishing Wandb...')
    # wandb.run.finish()

    os.execv(sys.executable, ['python3'] + sys.argv + ['--resume'])
    print('Restarted (we should never see this')

if __name__ == '__main__':
    sys.exit(main())

Environment

OS: [Ubuntu 18]
Python Version: [eg. 3.7]

@vanpelt I can confirm, when I replace wandb.run.finish() with wandb.run.finish(exit_code=1) I get the exact same behavior. A new run is being created for each call to wandb.init().
Thank you for the UNIQUE_ID suggestion, I will try that!
The code that uses execv() belongs to the system for decentralized Population Based Training.
Whenever training processes discover that they've fallen behind in the training session, they copy their weights and hyperpameters from a better-performing learner and restart themselves (with execv).


QAI Sections Editor UI tweaks

Fixes #10
Before:

After:

@jdbranham Column width adjusted.

Thanks Manoj - this PR fixes #9
#10 is the data entry screens - which will use a slightly different format. Let me know if you have any questions about it!


TypeScript error about React.KeyboardEvent is not assignable to parameter of type 'KeyboardEvent'

Description:
Got the following TypeScript error when handling the react onKeyDown

Argument of type 'KeyboardEvent' is not assignable to parameter of type 'KeyboardEvent'.
Type 'KeyboardEvent' is missing the following properties from type 'KeyboardEvent': isComposing, initKeyboardEvent, DOM_KEY_LOCATION_LEFT, DOM_KEY_LOCATION_NUMPAD, and 14 more.

Example code:
import React from "react";
import keydownKey from "keydown-key";

const handleKeyDown = (keyDownEvent: React.KeyboardEvent) => {
  const { key: theNormalizedKey } = keydownKey(keyDownEvent);

  console.log("theNormalizedKey", theNormalizedKey);
};

const App = () => {
  return <input onKeyDown={handleKeyDown} />;
};

export default App;

To resolve this type issue we could either

Add React.KeyboardEvent into the accept type of the parameter of keydownKey().

function keyDownEventPropsNormalizer(
  keyDownEvent: KeyboardEvent | React.KeyboardEvent
): NormalizedKeyDownKey {

Keep As-Is, but add an example into the readme.md about how to handle React.KeyboardEvent

const { key: theNormalizedKey } = keydownKey(reactKeyboardEvent.nativeEvent);

Pros of solution 1:

More intuition to use. The user could simply pass the React.KeyboardEvent from React's keyboardEventHandler into keydownKey().

Cons of solution 1:

Need extra dependency @types/react into the build while the native KeyboardEvent also fulfills the functional need. And we do can get the native KeyboardEvent from React.KeyboardEvent as solution 2.


FIX. Problem with the transformation in response format table with me…

…asures

Changes Unknown when pulling 9f345729ea315cc78d85e83183a790a2c89da798 on zenika-dev-javi into ** on zenika-dev**.

Changes Unknown when pulling 6c0eac1dfd32272326d5d01b718c141ae22fb402 on zenika-dev-javi into ** on zenika-dev**.

Changes Unknown when pulling 6c7a5703ef512a443b918827dd9c6ff327cd77eb on zenika-dev-javi into ** on zenika-dev**.


[SPARK-36215][SHUFFLE] Add logging for slow fetches to diagnose external shuffle service issues

What changes were proposed in this pull request?
Add logging to ShuffleBlockFetcherIterator to log "slow" fetches, where slow is defined by two confs: spark.reducer.shuffleFetchSlowLogThreshold.time and spark.reducer.shuffleFetchSlowLogThreshold.bytesPerSec

Why are the changes needed?
Currently we can see from the metrics that a task or stage has slow fetches, and the logs indicate all of the shuffle servers those tasks were fetching from, but often this is a big set (dozens or even hundreds) and narrowing down which one caused issues can be very difficult. This change makes it easier to understand which fetch is "slow".

Does this PR introduce any user-facing change?

Adds two configs spark.reducer.shuffleFetchSlowLogThreshold.time and spark.reducer.shuffleFetchSlowLogThreshold.bytesPerSec
How was this patch tested?

Added unit test

cc: @xkrogen Who initially worked on this change at LinkedIn
Also @Ngone51 @mridulm @otterc @dongjoon-hyun who have recently worked on or reviewed patches to this file

Can one of the admins verify this patch?

Just wondering if we should log this for the push-merged meta request as well? Code here

@otterc Added logging for this too. Thanks for the suggestion.
@xkrogen In the current state of the PR, logging will only happen if the last request to be completed was successful. Should we instead add logging to both onSuccess and onFailure?

In the current state of the PR, logging will only happen if the last request to be completed was successful. Should we instead add logging to both onSuccess and onFailure?

If we have a failure we'll already get the error log that the fetch failed, but I suppose it could be useful to also be aware if it was performing slowly before the failure (maybe it's related to the failure), so it seems worth it to check in onFailure as well. Good idea!

Looks good to me. Thanks @shardulm94 for working on this.

And I think a more straightforward way to do this probably would be to log slow fetches which are slower than most fetches. For example, we could log the 5%th percentile slow fetches among all fetches. The downside is that we have to store more intermediate states.

This is a great idea actually. We can use Dropwizard's Histogram with a uniform reservoir to keep histogram information with constant storage space.

I am not completely sure how showing the 5%ile would work.

We will need a reasonable number of shuffles on an executor before we can even calculate 5%ile. We cannot deduce that a fetch was slow when the fetch happened (at least for the first N shuffles), but only at a later stage. (This is assuming you are also on the same page about calculating the 5%ile on every executor and not across all executors)
We can get quite a few false positives, even if all fetches had reasonable and fast fetch times, we would still have a 5%ile but that shouldn't be of concern to the users since the fetch was fast in absolute terms.

We can get quite a few false positives
I think false positives are okay -- if everything went quickly, you probably won't go digging for these logs. Even if things were fast overall, it could be useful to see which were the slowest.

We will need a reasonable number of shuffles on an executor before we can even calculate 5%ile. We cannot deduce that a fetch was slow when the fetch happened (at least for the first N shuffles), but only at a later stage.

I agree it's an issue that if the slow fetch happened at the beginning, we wouldn't have enough info to determine if it's slow. I see a few options we can consider here:

Keep a history of all fetches in memory for the first N fetches (N = 100 or 1000?). Once N is satisfied, create a histogram out of them, and log the slowest 5%. After that, for new fetches, just directly add to the histogram and check the percentile to determine if logging is needed.
Maintain the slowest N fetches (N = 10 or 100?), instead of trying to calculate a percentile. When all fetches are complete, just log all N slowest. This is simpler and avoids some issues with the above approach, e.g. if fetches are getting slower over time, the percentile-approach above will end up logging all of the fetches. Putting some absolute limit on the number might be better -- you're probably not going to manually investigating more than a dozen instances of slowness anyway.

And I think a more straightforward way to do this probably would be to log slow fetches which are slower than most fetches. For example, we could log the 5%th percentile slow fetches among all fetches. The downside is that we have to store more intermediate states.

This is a great idea actually. We can use Dropwizard's Histogram with a uniform reservoir to keep histogram information with constant storage space.

I have a different opinion here.

The number of requests that are in-flight are bounded by parameters like maxBytesInFlight and maxReqsInFlight. The number of blocks to fetch in each network request is bounded by these params as well. So, even for applications with larger shuffle, we do impose a limit on the amount of shuffle data being fetched at a time with these limits. For a fetch to be slow (bytes fetched per sec being lower than threshold), it is more likely a server issue which depends on how much time the shuffle server took to respond to a request. So, I don't think the threshold for marking it slow may vary from application to application in a similar cluster.

The slow fetches are not necessarily because of this particular application. It could be because of a shuffle server which is overloaded with requests from the other apps running in the same cluster. So, again the threshold for categorizing a fetch being slow is mostly dependent on this and the default should be something the cluster admins can determine for a cluster.

Usually,  the user doesn't change configs like maxBytesInFlight and maxBytesInFlight, so they shouldn't have to change the configs related to this as well.

Storing the data for fetches just adds more state to the iterator even though we can bound it. Just adding more code around this seems overkill. For a user, this log is helpful to identify why one run of an application took longer than a previous run. If most of the runs of the same application have the same time, they will not even bother with it.

@Ngone51 do you have any thoughts on what @otterc shared above?
I agree at least to the point that it adds extra complexity which may be unnecessary. Auto-configuration is great, but it will also be much harder to get it right, and this is mainly targeted at administrators/power-users who should be able to set up these configs on their own.

Reopening the PR based on request.

I removed Stale tag manually to prevent re-closing without the grace period.

Thanks @dongjoon-hyun ! Forgot to remove the tag :-)

Can we resolve the conflicts on this and update to master ? Thx

@mridulm I have rebased to master and also addressed comments.


fail harder when lowering sorbet_i_getRuby{Class,Constant}

Motivation
The current setup for lowering sorbet_i_getRuby{Class,Constant} emits LLVM undef instructions when encountering a shape of IR that we don't understand how to lower.  This decision results in hard-to-debug failures, as @neilparikh has experienced, and is just a bad idea from a compiler reliability perspective: we shouldn't be emitting LLVM undef (which LLVM can do whatever it likes with) if we don't understand the IR we're receiving.
Instead, we should crash and crash loudly, because getting badly-shaped IR is a bug of some kind.  This PR implements that behavior.
It is a little bit messy, because we can't use the usual failCompilation bits that the rest of the compiler uses.  Ideally the comments in the source code will help explain why we can't and shed light on why this approach was chosen.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_JyL1MdsUNkAEGs
→ https://go/builds/bui_JyL2AXpoU28bVX


Dev: Remove tsx from lint-staged

Change-type: patch
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>

@balena-ci I self certify!


Issue? / not issue? esp32 LEFT direction

Im using Arduino IDE esp core 2.0.2, this is the first library for my rotary encoder what working well, but..not fully. If im insert the button example parts into my code, click!, restart and right working well, but the left reaction slow, i need make 1-2 turns till will be visible on Serial monitor and sometimes jumping displaying to RIGHT direction.
The example working standalone well. What can generate this problem if not issue?, i have tryed on more pins.
thank you

Hey, without the encoder I cannot really reproduce your problem.
Maybe try out a different click setting. Cheaper encoder do use a different setting .That might be the problem.


uart: logging: Add configurable log level to UART drivers

This change adds compile-time selection of log level for
the UART drivers.
Signed-off-by: Pete Dietl<EMAIL_ADDRESS>

@erwango once of the actions was cancelled for some reason. Can you make it run again?

@erwango once of the actions was cancelled for some reason. Can you make it run again?

Github now infroms that all checks are passed, so I'm assuming this is fine.

@erwango can I get a re-approve?
@mbolivar-nordic I think I fixed the issue.

@erwango @henrikbrixandersen @dcpleung Can I get approvals again?

Can you merge then @henrikbrixandersen ? :)

Can you merge then @henrikbrixandersen ? :)

Sorry, no merge rights.


how to use node modules?

I'm pretty now to the ecosystem of all the tools. I'm trying to integrate our crm into gmail with chrome addon. I'm having hard time to get it right.
first thing is when I cloned your repo and tried to load in browser as per instructions in the repo, i get following

Secondly, how can I use browser compatible node_modules like inboxsdk in this project. Do I need configure Vite or something in the manifest to refer the path of this node module?

Ok, instead of doing npm run dev, I decided to build it first and the load in browser. On windows, npm run build:chrome did not work as is. I had to change it to - set NODE_ENV=production run-s build:js build:background:chrome build:web build:manifest:chrome.  Basically, I prepended set to the existing command. My default VS Code shell is powershell 7.3.1
But still it would not generate index.global.js for some reason. So I ran all the commands one-by-one. After that it generated all those files. Now, when I load the dist folder in the extensions, I don't see the index page ui on blank tab.

Hi!
The add-on needs to build differently for Firefox and Chrome/Brave.

On windows, npm run build:chrome did not work as is. I had to change it to - set NODE_ENV=production run-s build:js build:background:chrome build:web build:manifest:chrome. Basically, I prepended set to the existing command. My default VS Code shell is PowerShell 7.3.1
But still it would not generate index.global.js for some reason. So I ran all the commands one-by-one. After that it generated all those files.

This could be an issue between us using different platforms. It would be good to look at other cross-platform repos and see how they set environment variables. Would you happen to have an example?

Now, when I load the dist folder in the extensions, I don't see the index page ui on blank tab.

The manifest files are specifically set to activate the plugin only on:
https://github.com/akoskm/vite-react-tailwindcss-browser-extension-simple/blob/a95d8e8545be47d3f80f87839bc2d95141276bd5/public/manifestv3.json#L12-L14
So just try to open https://blank.org/ in a new tab, and the add-on should appear.

Please reopen this if you have more questions. I'm happy to debug the issues you're having with this repo.


Update MD file on new branch 2017-23-07_03-12-19

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Integrate services for messages/comments section in Target Details page

Integrate services for messages/comments section in Target Details page:

Add comment
Edit comment
Delete comment
Order comments (if needed)

Insert

Delete


SCPH-7003: Can't find USB or Host

Hi, when use FreeDVDBoot and launch biosdrain from a USB drive (mass) from uLE the biosdrain utility loads up but then fails with the message:
USB not found, and HOST is not available, not continuing

I've tried the v2 release marked as "latest" and v1 and I get the same results.
PS2 Slim Info:
Console: SCPH-7003
Browser: 1.4.0
CD Player: 2.00
PlayStation Driver: 1.11
DVD Player: 3.10E
The console seems in decent shape and plays games ok

Thanks for the report.
What brand USB device are you using? Can you reproduce the issue with another USB device?
When I have time, I may implement a longer wait time for the USB driver (or a retry method).
Unfortunately I can't really tell when a USB device is available so the standard is to just wait for a few seconds.

The USB device is:
ID 0781:5567 SanDisk Corp. Cruzer Blade
I'm afraid I haven't got another spare USB to test, sorry. I did get the same outcome when trying to dump the BIOS on a (Phat) SCPH-39003 with the only difference being that I used FreeMcBoot to launch ULE. So it points to my USB drive being the likely culprit
I have since managed to get a BIOS dump (using the same USB drive) but it only worked when I copied the elf file off of the USB, onto a memory card and then executed it from the memory card. This method worked on both the (Slim ) SCPH-7003 and (Phat) SCPH-39003

The same thing is happening to me. I'm running FreeDVDBoot and can see "biosdrain.elf" in "mass:".  "biosdrain.elf" runs, but I'm seeing the same message as zephyrj.
I don't have a memory card connected and am using the USB drive from https://www.bestbuy.com/site/pny-32gb-attache-4-usb-2-0-flash-drive-2-pack/6382188.p?skuId=6382188.
I'll try to find a memory card to see if zephyrj's workaround also works for me.

I had the same situation as me, but I was able to fix it by using a different USB memory.
When I used a 4GB USB memory from an unknown manufacturer, "USB not found" was displayed and the execution of "biosdrain" was interrupted, but when I used an 8GB USB memory from a famous Japanese manufacturer, it was successful.
Finally, since I'm Japanese, I use Google Translate.  Sorry if it's hard to convey.

I had the same situation as me, but I was able to fix it by using a different USB memory.
When I used a 4GB USB memory from an unknown manufacturer, "USB not found" was displayed and the execution of "biosdrain" was interrupted, but when I used an 8GB USB memory from a famous Japanese manufacturer, it was successful.
Finally, since I'm Japanese, I use Google Translate.  Sorry if it's hard to convey.

Hello, I recently changed the FAT driver in PR #21 which is waiting to be tested and then be merged. I recommend creating a 1GB FAT32 partition and leaving the rest unformatted. Ensure that it is configured to be MBR and not GPT. If all else fails, I recommend trying a different USB. Which we see from @Maru0214's experience can be the root cause.


Colour Swatch - Upload an image file

Hi,
I'm having an issue uploading image files for swatch colours when using the plugin. Uploading the file doesn't seem to work / save.
Disabling the plugin allows me to upload the file, although I now have synch issues as it's looking for it at cdn.mysite.com/attribute/swatch
I've had the problem on Magento 2.1.7 - 9.
Thanks
Andrew

Hi,
I have same issue in magento 2.1.3. Any solution????

Same happens with product place holder images also. Even if the module is enabled, Magento won't take these files from S3 links. Instead, it searches for files on disk.

As a workaround to get swatch image files to show;
php bin/magento s3:storage:disable
php bin/magento indexer:reindex
php bin/magento cache:flush
Copy generated swatch images from live server.
Manually upload images directly to S3.
Then set back;
php bin/magento s3:storage:enable

Hey guys,
I've had a look. It looks like a bug in core Magento 2. I'll see what I can do from my side.

Hey guys,
I've pushed up a new version of my extension that should let you load colour swatches now. Enjoy!
Regards,
Thai


File manager is non responsive after opening a folder and slow startup

Issue Type: Performance Issue
After opening a folder every click on every button takes some seconds to take action. this happened after upgrading to vesion 1.37.
The VSCode startup is also slowed
VS Code version: Code 1.37.0 (036a6b1d3ac84e5ca96a17a44e63a87971f8fcc8, 2019-08-08T01:22:37.660Z)
OS version: Darwin x64 18.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (7.17GB free)

Process Argv

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
   20	   131	 55480	code main
    1	    66	 55585	   gpu-process
    0	   197	 55587	   window (Extension: vscode-icons)
    0	    82	 55711	     extensionHost
    0	   180	 58754	       /usr/local/Cellar/dart/2.4.1/libexec/bin/dart /usr/local/Cellar/dart/2.4.1/libexec/bin/snapshots/analysis_server.dart.snapshot --client-id=Dart-Code.dart-code --client-version=3.3.0
    0	    98	 55604	   shared-process
    0	     0	 60427	     /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    1	   377	 58860	   window (undefined)
    1	    82	 60219	   window (Issue Reporter)

Workspace Info
;

Extensions (10)

Extension
Author (truncated)
Version

dart-code
Dar
3.3.0

flutter
Dar
3.3.0

vscode-pydev
fab
0.1.5

code-runner
for
0.9.13

swift
Kas
0.0.3

vscode-gist
ken
3.0.3

Kotlin
mat
1.7.0

python
ms-
2019.8.30787

open-in-browser
tec
2.0.0

pygame-snippets
tus
0.0.1

I noticed that every non native mac app running slower

/needsMoreInfo please see https://github.com/Microsoft/vscode/wiki/Performance-Issues for guidance on what to collect.


[CXF-8347] URI processing/caching/extending changes

Includes:

URITemplate cache
Extension to allow extenders to wrap runnables from HTTPConduit
Numeric handling in URIs
URITemplate processes parameters
Add checking for form post when content-type includes charsets, etc.

These are part of the changes made in the Open Liberty "fork" of CXF.

Rebased from master - was hoping that the force-push would kick off an integration build, but it doesn't seem to have...

Sorry @andymc12, I haven't had time to review this PR yet (not forgotten), will do that shortly. The integration builds are not triggering right now since the CI server has changed the name (builds.apache.org -> ci-builds.apache.org), I don't have permissions to modify the repository settings to change webhook endpoints, @dkulp / @coheigea do you have admin rights, guys?

@reta - no worries - it's a fairly big change, so I wasn't expecting instant turnaround.  :)  Please let me know if you have any questions on these changes.  Thanks!

@reta I think so - what do I need to change?

@reta I think so - what do I need to change?

thanks @coheigea , there are instructions on wiki: https://cwiki.apache.org/confluence/display/INFRA/Kicking+off+a+Jenkins+build+with+a+GitHub+PR  (please feel free to ping me in private if you need any help). It seems like builds.apache.org now redirects to ci-builds.apache.org, we probably just need to make sure that webhooks work.

@reta For which CXF build on ci-builds should I make those changes in?

@reta For which CXF build on ci-builds should I make those changes in?

https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, this is out standard one, we could extend it to others later one

@coheigea sorry, just realized we had a dedicated build previously just for PRs, I could clone https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, and name it like https://ci-builds.apache.org/job/CXF/job/CXF-JDK8-PR/, would be good for you?

Yes please do, I've actually made the change already to "Check "Enable Git validated merge support" and "Build pull requests to the repository" in your build config". Not sure if the other changes are required?

@coheigea  done, https://ci-builds.apache.org/job/CXF/job/CXF-JDK8-PR/


feat: nonfungible traits

Fixes: #45

@enthusiastmartin Do we want to also implement Mutate trait? Right now we are using default implementation.

i believe so.
the default impl returns an Unsupported error.
i think it should call do_mint ?!


Downloads under metered connection

Issue Type: Feature Request
Hello! Many Windows Apps honor metered connection and ask if they can download stuff in the background - VSCode went all in and just started downloading stuff it was missing. At the time it was fine for me as I'm on nearly unlimited metered plan, but for others it might be not so pleasant experience.
VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:37.030Z)
OS version: Windows_NT x64 10.0.18362

Maybe the title can be "Downloads under metered connection" @AlexJPawlak

Duplicate of #60741

Here's the issue created for the first time https://github.com/microsoft/vscode/issues/8540 and it was marked as out of scope.
@egamma @AlexJPawlak

OK - so #8540 was out of scope for that iteration, I get it. 3 years passed. The topic was picked up #60741 without being delivered without explanation. I would like to understand a bit more your reasoning behind it, as I'd not like to waste either your or mine time and still provide comments or feedback. Or is it misleading and you don't want new ideas?
#62615 said PR are welcome but otherwise this is out of scope. What is in scope and where can I read more on that? So my suggestions are more relevant for future.
@egamma  @mittalyashu

I understand how it felt when we post a feature request and it turns out to be out of scope.
It has also happened with me a few times, once I have posted a feature request for duplicating file and folder even though that feature should be part of every text editor but the reply from VS Code team was that this functionality can be extended by an extension and later they marked the issue as out of scope.

I'd not like to waste either your or mine time and still provide comments or feedback. Or is it misleading and you don't want new ideas?

The idea is very good, even the Atom uses the similar concept of metered connection as it shows the list of plugins which can be updated.

#62615 said PR are welcome but otherwise this is out of scope. What is in scope and where can I read more on that? So my suggestions are more relevant for the future.

A few months back VS Code started grooming the issues just to decrease the number of open issues that is one of the most few of the best issues were closed too.


AsyncWaitConnectionReady deadline exceeded on macOS (cmake-vcpkg)

https://source.cloud.google.com/results/invocations/0f1bdb28-13d0-474c-a54a-06e17da99e13/targets
[ RUN      ] CompletionQueueTest.SuccessfulWaitingForConnection
../../google/cloud/internal/async_connection_ready_test.cc:80: Failure
Value of: cli_cq .AsyncWaitConnectionReady(channel, std::chrono::system_clock::now() + std::chrono::seconds(1)) .get()
Expected: code is equal to OK and message is anything
  Actual: DEADLINE_EXCEEDED: Connection couldn't connect before requested deadline (of type google::cloud::v1_41_0::Status), with a code that isn't equal to OK, but a message that is anything
E0509 13:53:38.896633000<PHONE_NUMBER> completion_queue_cc.cc:135]        CompletionQueue shutdown being shutdown before its server.
[  FAILED  ] CompletionQueueTest.SuccessfulWaitingForConnection (1005 ms)

https://source.cloud.google.com/results/invocations/058437f2-5b07-4166-aa07-401174f19cc0
[ RUN      ] CompletionQueueTest.SuccessfulWaitingForConnection
../../google/cloud/internal/async_connection_ready_test.cc:80: Failure
Value of: cli_cq .AsyncWaitConnectionReady(channel, std::chrono::system_clock::now() + std::chrono::seconds(1)) .get()
Expected: code is equal to OK and message is anything
Actual: DEADLINE_EXCEEDED: Connection couldn't connect before requested deadline (of type google::cloud::v1_42_0::Status), with a code that isn't equal to OK, but a message that is anything
E0606 16:23:34.594974000<PHONE_NUMBER> completion_queue_cc.cc:135]        CompletionQueue shutdown being shutdown before its server.
[  FAILED  ] CompletionQueueTest.SuccessfulWaitingForConnection (1008 ms)

No repeats in 90d, closing.


[v3][svg][TeX] The spacing of the characters gets messed up for \boldsymbol

When I write \langle \boldsymbol { U I } \rangle  the spacing of the characters gets messed up:

 + \boldsymbol{AI}

Thanks, I can confirm the behavior, and will check into it.

The issue appears to be only if the math is entered in TeX form.  The corresponding MathML renders properly.

This turns out to be an issue with the internal MathML generated by the \boldsymbol macro.  I have created a pull request that resolves the problem.


Feature/export wizard

Initial work on an export wizard. Some pieces will need to be refactored if we extend this pattern to other data models.

Nice to clearly see where you are in the multi-step process. I also like the indicator showing the number of rows to be exported.


Update the readme to contain a bit more info

[ ] The Godot version needs to be included (and short info that it hasn’t been ported yet due to missing demand).
[ ] A link for more info to the wiki main page mentioning that implementation and other docs can be found there.
[ ] Better explanations/one liners for the existing links.
[ ] Direct link to the “adding to a godot project” page.
[ ] Short explanation that the latest version resides on the development branch.

I’ve been sharing the loader around in the godot discord and multiple people couldn’t find info that we did have
if you have any more, add them here
some things should just go into the wiki, keep that in mind

Add compatibility list so Windows, MacOS, Linux, Android, iOS


[Build] Update dockerfile to use compatible version of Bundler

Bundler 2.0 introduced requirements that are incompatible with the version of Ruby shipped with Logstash 5.6. This commit installs a pre 2.0 version of Bundler.

Thanks @danhermann!


Issues and Pull Requests listed in the admin UI should have a link to the Trello card as well as a link to the GitHub issue/pull request

Closed in #17


[Windows] Fix thrift proxy tests

Signed-off-by: Sotiris Nanopoulos<EMAIL_ADDRESS>Commit Message:
Fixes Thrift-Proxy Tests on Windows. Since Python does not support AF_UNIX sockets at all, I changed the tests to communicate over the loopback address.
Risk Level: N/A (test only)
Testing: N/A (test only)
Docs Changes: N/A
Release Notes: N/A

cc @envoyproxy/windows-dev
Please give a one or two CI runs to verify everything works on CI as it works on my local dev box. Will ping again when it is ready for review.

I think the general approach of this PR is fine, if you can work out the test failures.

@zuercher I was working on some more important things related to the alpha release of Windows and this one fell through the cracks. I will make sure the CI passes and ping you for a review.

/wait

@zuercher it took me some time but now this is ready for review :)


urlib3.HTTPResponse.stream would confuse gzip content originally not encoded utf8

Hi, i was using requests for get gziped web page which originally encoded in gbk.
as requests would try their best decoding gziped pages but as originally not by utf-8 would make the result weried and hard to debug :(

@yupbank Sorry, I didn't fully understand this message. Can you post some code that demonstrates the problem?

basically
i figured the correct way:
zlib.decompress(requests.get('http://zhongyanghuachengzs.fang.com/', stream=True).raw.read(), zlib.MAX_WBITS|32).decode('gbk'))
as the page is encoded in gbk and  gziped.
also due to the fact that requests would auto decompress gzip, this would give weird results.
requests.get('http://zhongyanghuachengzs.fang.com/')

I don't believe this is a urllib3 bug: nothing unexpected is happening here.
As you've correctly spotted, requests is transparently decompressing the gzip. This is working perfectly, nothing unexpected is happening. However, I suspect you're then using response.text, which is trying to decode the response body. Because there's no header explaining what encoding was used, requests falls back on the spec which claims that text/html should be served in ISO-8859-1. This is wrong for this page, and so it breaks the rendering.
All you need to do is:
requests.get('http://zhongyanghuachengzs.fang.com/').content.decode('gbk')

That'll work perfectly. =)

thanks a lot, i should follow the document carefully :)


[Feature] Add favicon

Description
I think we can add the website's favicon by just adding this code in the JSOn files

"image":"https://website-name/favicon-link"

Suppose we want to add https://materialui.co/ favicon link. You can watch the video on how we can easily add.
https://user-images.githubusercontent.com/88102392/221398243-1b6cdb8a-a627-4940-b325-9e38f90307a8.mp4
in this way, we can add the link.
Screenshots
We can add the icon in this area.

Additional Information
No response

Hi, okay
but what if the site doesn't have favicons?

can i work on it? @rupali-codes

can i work on it? @rupali-codes

Yeah of course

is there any source for different icons?

yes. every website has there own favicon.
we need to store it in JSON and then fetch it.

yeah ok i will start doing this.

I made the requested changes. but i am unable to find Cubic Bezier favicon and Animate On Scroll has no favicon.

I made the requested changes. but i am unable to find Cubic Bezier favicon and Animate On Scroll has no favicon.

Yes I noticed then need to add a default image or manually paste the website favicon by creating

I made the requested changes. and should i do the same to all the categories. can you help me finding default image for animate on scroll.

and should i do the same to all the categories.

what should be the default image @rupali-codes

what should be the default image @rupali-codes

LinksHub icon

@stupiddint I guess the icon should be left aligned, at starting of the title

@rupali-codes how is this? I made the requested changes.

looks good to me. one suggestion please increase the size of these icons.

I increased space from 0.25rem to 0.75rem ,and I also made changes to popup card. please review it!

Looks Good 🎉

Thank you! i am making a pr then.


Can't login using v5.734 and GMail(IMAP or POP3) on a fresh install

I have installed K-9 Mail v5.734 from F-Droid and was near 2h trying to login. Previous I tried use v5.600 but since it showed a message about not been compiled for my Android version and I was not been able to connect I upgraded to the last version.
Since a long time I know I need a App Password which I have generated before try, but the the K9 after I fill the user / pass and press to continue, it instantly refuse. I tried use Manual Config to see if some configuration was wrong, tried POP3 and still it was refusing. Have searched on web but didn't find anything related.
Well then I tried to uninstall and install the version 5.733, and voilà, it worked!
Just out of conscience I upgraded to 5.734 to see if it would still work, and yes, it did.
To Reproduce
Steps to reproduce the behavior:

Go to F-Droid and install K9 Mail v5.734
Create a new App Password on your G.Account
Open the installed K9 Mail
Fill your G.Account username and the created app password.
Continue and see the error "unable to connect"

Expected behavior
To K9 Mail to be able to connect using G.Account on a fresh install using v5.734
Environment (please complete the following information):

K-9 Mail version: 5.734
Android version: 11
LineageOS version: 18.1
Device: OnePlus 5 (cheeseburger)
Account type: IMAP

Logs
If needed I will reset my the app and create a log.

What error did you get and did you enable Less Secure mode?

Please use the forum for support requests.
This thread might be relevant: https://forum.k9mail.app/t/gmail-setup-could-not-finish/650


Pass constants.NETLIFY_API_TOKEN

Instead of using ps, the API token can be retrieved from constants.NETLIFY_API_TOKEN.

Done by #22.


Helm: make livenessProbe customizable by adding initialDelaySeconds and periodSeconds

With #28 , livenessProbe checks for MeiliSearch API /health route in order to check container liveness.
livenessProbe could/should be customizable by the user, by adding two items that should ve present in the values.yaml:

initialDelaySeconds: Defines the delay that should happen before the first health check
periodSeconds: Defines the interval in which the container health should be checked

I think this can be closed now @eskombro :)

Closing then! Really nice PR @HelmutLety!


Survey in Jetpack Compose

Hi, I am currently migrating an app to Jetpack Compose, is there any version which can be used directly with compose?
Thanks a lot.

Since this Repository is just about Flutter, can you please reopen that Question in the Android Repository?
https://github.com/QuickBirdEng/SurveyKit