Upgrade Speech to V1

This PR upgrades Speech to use the V1 API. There are several noticeable changes from V1beta1:

The language argument is now mandatory on all recognition methods
#recognize_job has been renamed #process, aliased as #long_running_recognize and #recognize_job
#stream has been aliased as #stream_recognize
Stream added #wait_until_complete! method, which blocks until stream is complete
Stream removed #speech_start and #speech_end callback methods
Stream now calls #complete callback method when stream ends, not when END_OF_AUDIO event is received (the END_OF_AUDIO event was removed in V1)
Job has been renamed Operation
Operation added id attribute, can be retrieved by id

This PR closes the following open issues:

Rename Job to Operation (closes #1207)
Update code examples to show how to wait until recognition is complete (closes #1209)
Add Long Running Operations veneer (closes #1214)
Document Low level API (GAPIC) (closes #1205)

@pbogle We would love to get your input on this as well!

There are other changes and improvements as well.  Adding a link is probably best rather than trying to duplicate the release notes.  Please coordinate via email to figure out how we want to do that linking.

@pbogle wrote:

There are other changes and improvements as well. Adding a link is probably best rather than trying to duplicate the release notes. Please coordinate via email to figure out how we want to do that linking.

I don't understand what you are saying here. Can you clarify?

The GAPIC files have been regenerated to use the latest configuration values.

@landrito @blowmage I have increased the timeout_mills to 190000 in gapic config: https://github.com/googleapis/googleapis/pull/304

The GAPIC files have been updated again, and the Recognize config is now 190 seconds.

@pbogle The OggOpus and Speex encodings have been added to the documentation. Are there any other changes you want us to make?

In general, does the documentation include all changes to comments in the
v1 proto file?
On Tue, Apr 4, 2017 at 3:04 PM, Mike Moore<EMAIL_ADDRESS>wrote:

@pbogle https://github.com/pbogle The OggOpus and Speex encodings have
been added to the documentation. Are there any other changes you want us to
make?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1380#issuecomment-291645841,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AS_go0VFK7vkrjB6xoh_BZcD_0ojcj6wks5rsr6LgaJpZM4MwEuI
.

@pbogle, all of the documentation in the proto are reflected in the grpc type documentation under the lib/google/cloud/speech/v1/doc path.
I did some hand validation, the necessary updates from the proto to the handwritten interface are included as well.

LGTM


Added panoptic handler of get_all_functions

fixes #164

Coverage increased (+0.2%) to 81.181% when pulling 554b80e33c4b0ef3044cc83a7511a9e401c8c0b5 on issue-164 into b4246c2994fbe92d60964e48eb259739fce6dfc1 on master.


"Connecting to service" timeout

Hello dev, I have my phone configured to have personal and work profiles by the use of Shelter app. Darq app works good in personal profile. But when installed in work profile, even after granting root permissions, it keeps saying "Connecting to service". After a while, says timeout and to reboot my device. I did that also. No luck here.
I don't know why this issue is happening, but most of the apps I use on work profile never behaved like this.

This is probably related to how Shizuku/Root services work, they'll be cross-profile. If you add an app to DarQ on your personal profile, is it also dark themed on the work profile?

This is probably related to how Shizuku/Root services work, they'll be cross-profile. If you add an app to DarQ on your personal profile, is it also dark themed on the work profile?

Tried this. And yes. If I install an app on both profiles and enable DarQ for the app in personal profile, even in work profile the app would be in dark mode.
But, there are instances where I don't install same apps on both profiles, like, I have isolated Open source apps on personal profile and tracking, proprietary apps on work profile. Most of the Open source apps have dark mode built in, so Darq isn't required.
Some proprietary apps which I use don't have dark theme and I also don't want to install them on personal profile.
Is there a way to get the list of apps on work profile also, when DarQ is installed in personal profile? Because DarQ works fine in personal profile

Agree. That would be a security concern to show apps from one profile to another. If you are curious to list those, AppManager by Muntashirakon(Open source Github Repo) can list all apps. I use it to block trackers on both profiles.

So, is there any progress on this issue? I recently moved all spyware to a work profile and now darq doesnt see them.

libsu recently added multi-user support which should make this possible, but I need to find the time to implement it.

I have this issue without using profiles on Android 10. Would there be a reason for that?

Yep have the same issue without using profiles. Even the automatic dark mode doesn't work. @KieronQuinn

I also confirm the keeps saying "Connecting to service" when opening. The app still working fine on MIUI 14, Android 13, Kitsune and LSposed.
How can we handle it?


The Discord badge is not rendering.

The README.md file no longer displays the Discord badge after being replaced with a new embed that works correctly with the new link.

Hello @Jiyath5516F, and thank you for you contribution,
Can you please update your PR to highlight the changes in the description,
Thank you very much


feat: wds button refactoring

Description

Moved wds to the design-system folder.
Added headless package and HeadlessButton.
Added theming package. ThemeProvider and two classes were created to work with tokens(TokensAccessor) and colors(ColorsAccessor)
The token structure has been changed. The same class(TokensAccessor) is now used to create CSS variables and tokens for Figma(themeTokens.json)

The final storybook is here.
Type of change

New feature (non-breaking change which adds functionality)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

How Has This Been Tested?

Manual

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

/build-wds-preview

/build-wds-preview

@riodeuno Thank you for the review and valuable comments!

/build-wds-preview

/build-wds-preview


[Upcoming UI/UX change]Homepage v2

Based on user feedback and research, we are making following changes on current Homepage in Superset. Implementation will start on July 15, please comment before the date if you have any ideas, questions, objections.
General

Show 5 cards per row in each section, instead of 3; dynamically adjust the number of card depends on the screen size
Remove Examples from Recents section and add Examples to Dashboards, Charts and Saved queries
Move Save queries section to the bottom
Tab selection in all sections will be 'sticky'

First time experience

Show Example cards in Dashboards and Charts
Recents collapses by default to avoid showing an empty section
Saved queries collapses by default to avoid showing an empty section

These changes make sense.

Love it! Excited for this

[ ] Thanks. And When could enable Bar Chart 's cross-filtering

When could enable Bar Chart 's cross-filtering

Mid-Late August! only on Echarts(time-series bar) though, major reconstruction on Time-series chart ATM. @aloneworld

@pkdotson
just a quick note you might be aware of it already. in v1 currently, charts/dashboards user created are showing in Examples tab. let's make sure it's fixed in v2. 🙏

One super minor comment would be around using vertical dots for the sub-menu as opposed to horizontal ones to save a few pixels. I think in general we should standardize on the vertical dots for sub-menu triggers.

I'm afraid I'm a little late to the party, but I believe the UX could be a bit improved by preselecting the left-most tab (that “makes sense”) by default.
Indeed, preselecting the right-most tab doesn't feel very intuitive to me.
Thus, I'd suggest to pre-select:

Favourite if any,
else Mine if any,
else Example if any,
else Favourite (left-most default).


Misspelling of keyboard shortcut filter name

Issue Type: Bug
The keyboard shortcut for "find previous" contains a misspelled "where" filter name of "findInputFocussed". While this is the correct filter, this is not the proper spelling, and attempting to use the proper spelling in another shortcut, for example, results in a missed filter.
The proper spelling should be "findInputFocused", which is not only the correct spelling, but matches the spelling of other "*.Focused" filters.
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:30:02.420Z)
OS version: Darwin x64 20.2.0

closing this as we won't be able to fix it without breaking users that are using it in their keybindings.json


Skipping a line in code does not show up after render

For example, the following code block,
```js
export const MDXLayoutRenderer = ({ layout, mdxSource, ...rest }) => {
  const LayoutComponent = require(`../layouts/${layout}`).default

  return (
    <LayoutComponent {...rest}>
      <MDXRemote {...mdxSource} components={MDXComponents} />
    </LayoutComponent>
  )
}
```

renders by removing the new line
export const MDXLayoutRenderer = ({ layout, mdxSource, ...rest }) => {
  const LayoutComponent = require(`../layouts/${layout}`).default
  return (
    <LayoutComponent {...rest}>
      <MDXRemote {...mdxSource} components={MDXComponents} />
    </LayoutComponent>
  )
}

It does?

I guess you are probably using one of the older versions. Try updating to new v1 setup which uses xdm instead of mdx (the results might differ)

On further investigations, it is probably caused by my rehype-prism-plus plugin. Will try to fix it over the weekends.


Failed prop type on iOS < 13 and Android 5.x

💬 Question
I have a project developed under Expo SDK 38 / React 16.11.0 / React Native 0.62.
Everything works fine when I run it under iOS 13 or Android 9+. However, running it under a previous version of these OSs, all sorts of Failed prop type errors showed in the console. The UI is completely broken on these.
This is how the project looks like on iOS 13.x  and Android 9+:
(the green rectangles are added manually to cover some logos and login information)

And this is how it looks like on iOS 12 and lower (same on Android 5.x emulator)

These are the errors logged in the console:
Warning: Failed prop type: Invalid prop `placeholderTextColor` supplied to `ForwardRef(TextInput)`: text-hint-color
Valid color formats are
  - '#f0f' (#rgb)
  - '#f0fc' (#rgba)
  - '#ff00ff' (#rrggbb)
  - '#ff00ff00' (#rrggbbaa)
  - 'rgb(255, 255, 255)'
  - 'rgba(255, 255, 255, 1.0)'
  - 'hsl(360, 100%, 100%)'
  - 'hsla(360, 100%, 100%, 1.0)'
  - 'transparent'
  - 'red'
  - 0xff00ff00 (0xrrggbbaa)

Warning: Failed prop type: Invalid prop `color` supplied to `ForwardRef(TextInput)`: text-basic-color
Valid color formats are
  - '#f0f' (#rgb)
  - '#f0fc' (#rgba)
  - '#ff00ff' (#rrggbb)
  - '#ff00ff00' (#rrggbbaa)
  - 'rgb(255, 255, 255)'
  - 'rgba(255, 255, 255, 1.0)'
  - 'hsl(360, 100%, 100%)'
  - 'hsla(360, 100%, 100%, 1.0)'
  - 'transparent'
  - 'red'
  - 0xff00ff00 (0xrrggbbaa)

Bad object: {
  "marginHorizontal": 8,
  "fontFamily": "regular",
  "fontSize": 15,
  "fontWeight": "normal",
  "color": "text-basic-color",
  "flexGrow": 1,
  "flexShrink": 1,
  "flexBasis": "auto"
}

Warning: Failed prop type: Invalid prop `tintColor` supplied to `Image`: text-hint-color
Valid color formats are
  - '#f0f' (#rgb)
  - '#f0fc' (#rgba)
  - '#ff00ff' (#rrggbb)
  - '#ff00ff00' (#rrggbbaa)
  - 'rgb(255, 255, 255)'
  - 'rgba(255, 255, 255, 1.0)'
  - 'hsl(360, 100%, 100%)'
  - 'hsla(360, 100%, 100%, 1.0)'
  - 'transparent'
  - 'red'
  - 0xff00ff00 (0xrrggbbaa)

Bad object: {
  "width": 20,
  "height": 20,
  "marginHorizontal": 8,
  "tintColor": "text-hint-color"
}

Warning: Failed prop type: Invalid prop `color` supplied to `Text`: text-hint-color
Valid color formats are
  - '#f0f' (#rgb)
  - '#f0fc' (#rgba)
  - '#ff00ff' (#rrggbb)
  - '#ff00ff00' (#rrggbbaa)
  - 'rgb(255, 255, 255)'
  - 'rgba(255, 255, 255, 1.0)'
  - 'hsl(360, 100%, 100%)'
  - 'hsla(360, 100%, 100%, 1.0)'
  - 'transparent'
  - 'red'
  - 0xff00ff00 (0xrrggbbaa)

Bad object: {
  "color": "text-hint-color",
  "fontSize": 12,
  "fontWeight": "400",
  "fontFamily": "regular",
  "width": "50%",
  "minWidth": 290,
  "marginBottom": 10,
  "textAlign": "center"
}

I have checked for issues with package dependencies, it seems everything is fine. I had issues with<EMAIL_ADDRESS>in the past, I have tried with<EMAIL_ADDRESS>(minimum required by UI Kitten), but other than multiple warnings of incorrect dependencies, I have no better result.
I also have a metro configuration file used to apply a custom mapping, but even removing it does not help - so I think it's not the issue.
Can you help me figure out what is wrong ?
UI Kitten and Eva version

Package
Version

@eva-design/eva
2.0.0

@ui-kitten/components
5.0.0

metro-config
0.60.0

expo
SKD 38

react
16.11.0

react-native
0.62

react-native-svg
^9.13.6 / ^12.1.0

I was messing with the packages, and I have noticed this warning:
warning "@ui-kitten/eva-icons ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>
Maybe this has anything to do with the above issue?
For Expo SDK 38 the exact version of<EMAIL_ADDRESS>is needed, trying to use @16.5.0 fails to even start the project.

@artyorsh Tagging you here in case you missed this post, I would really appreciate your help as the project I'm working on is for a client and it's critical for it to work on older OS versions too...
I have made a backport of the project back to Expo SDK 37<EMAIL_ADDRESS>react-native@0.61.0).
The same issue happens.

Hi, does anyone have any idea what could be the issue ?

@CostachescuCristinel
How is the ApplicationProvider configured in your case? According to the last two screenshots, it seems that the components simply do not receive their stylings

Hi, I have the setup as follows below:
metro.config.js
const MetroConfig = require("@ui-kitten/metro-config");

const evaConfig = {
	evaPackage: "@eva-design/eva",
	// Optional, but may be useful when using mapping customization feature.
	customMappingPath: "./theme/mapping.json",
};

module.exports = MetroConfig.create(evaConfig);

App.js
import * as eva from "@eva-design/eva";
import { ApplicationProvider as UIKittenProvider, IconRegistry, Layout } from "@ui-kitten/components";
import branding from "./theme/branding.json"; // custom JSON for branding colors

import { Provider as ReduxProvider, connect } from "react-redux";
import { store, actions } from "./redux";

// Using Redux
const Main = connect(
	(state) => ({ theme: state.theme }),
	{ ...actions.theme, ...actions.authentication.signIn, ...actions.device }
)(class extends React.Component {
	// ( ... )

	render = () => {
		// From redux, currentTheme is either "light" or "dark"
		// in case of any failure, currentTheme defaults to "light"
		// statusBarTheme is the opposite of currentTheme
		const { currentTheme, statusBarTheme } = this.props.theme;

		const UIKittenTheme = {
			...eva[currentTheme],
			...branding
		};

		if (this.state.loading === true) {
			return <AppLoading
				startAsync={this.onStartLoading}
				onFinish={this.onFinishLoading}
				onError={console.error}
			/>;
		}

		return <>
			{/* <IconRegistry icons={EvaIconsPack} /> // Not using Icons at the moment */}
			<StatusBar translucent={true} style={statusBarTheme} />
			<UIKittenProvider {...eva} theme={UIKittenTheme}>
				<Layout style={{ flex: 1 }}>
					{/* React navigation 5 navigation containers and screens, ect. */}
				</Layout>
			</UIKittenProvider>
		</>;
	}
});

// Need to separate the Main app from this part so the Redux
// store gets initialized and mounted before being used in <Main />
// <Main /> initialization will be delayed by the connect() function
// until the redux store is available
export default function (props) {
	return <ReduxProvider store={store}>
		<AppearanceProvider>
			<Main />
		</AppearanceProvider>
	</ReduxProvider>;
}

@artyorsh I have taken the time to strip out all the code from the app to a bare-minimum version that still reproduces the issue, with redux and some parts of the app. You can find it in this zip file (wetransfer link expires in 1 week)
https://we.tl/t-Oo4htCySP7
iPhone 11 Pro Max / iOS 13.5 (simulator)

iPhone SE (1st gen) / iOS 10.3.5 (simulator)

i'm having the same issue

hi @artyorsh , is it you had any chance to look into this ?

@CostachescuCristinel I hadn’t. Not able to pay lots of attention into this project currently

Understood, is it you can give me any hints on where to start looking into this issue myself ?

It's hard to determine. Could you please try removing metro.conifg.js and see if it runs normally with built-in theme?
import { mapping, light } from '@eva-design/eva';

<ApplicationProvider mapping={mapping} theme={light} />

Having the same issue, every now and then it complains that the literal string "text-hint-color" is being passed as a colour. Happens on both ios and Android, even on iOS 13.5+. It works 90% of the time and then randomly this happens.

Ok i found my issue, im dynamically rendering my theme dark/light from a redux store strong and applying it to the provider like <ApplicationProvider {...eva} theme={{ ...eva[config.theme], ...curTheme }}> the problem is on the very first render config.theme was undefined causing the exceptions and the app would not work until i had another render.
In case anyone makes the same mistake as me.

Ok i found my issue, im dynamically rendering my theme dark/light from a redux store string value and applying it to the provider like <ApplicationProvider {...eva} theme={{ ...eva[config.theme], ...curTheme }}> the problem is on the very first render config.theme was undefined causing the exceptions and the app would not work until i had another render.
In case anyone makes the same mistake as me.

You just made my day!
@artyorsh Issue fixed, it was my fault
In my Redux module "theme" I have the following "currentTheme" and "systemTheme" reducers:
function systemTheme(state = initialState.systemTheme, action) {
	if (action.type === TYPES.THEME_CHANGESYSTEMTHEME) {
		if ((action.systemTheme !== "light") && (action.systemTheme !== "dark")) {
			// might be "no-preference" or "default" or other unsupported value
			return "light";
		}
		return action.systemTheme;
	}

	return state;
}

function currentTheme(state = initialState.currentTheme, action) {
	if ((action.type === TYPES.THEME_CHANGEUSERTHEME) || (action.type === TYPES.THEME_CHANGESYSTEMTHEME)) {
		const { systemTheme, userTheme } = action;

		return (userTheme === "system") ? systemTheme : userTheme;
	}

	return state;
}

The problem is that on iOS < 13, and on Android < 10, there is no support for system theme preference, thus, a value of "no-preference" is returned from React Native's Appearance API (by extension, also from Expo's Appearance API).
The systemTheme reducer correctly handles this value, converting it to "light".
However, the currentTheme reducer does not. When called with { systemTheme: "no-preference", userTheme: "system" }, the overall result is currentTheme="no-preference". And obviously, eva[currentTheme] = eva["no-preference"] = undefined.
I was too confindent on the code I wrote that I completely ignored the possibility of this code being at fault. But at least I figured it out eventually...

@RenatoSerra22 Thanks, man. You just made my day!


Getting same numbers of TP-base and TP-comp

Hi @ACEnglish,
I'm running Truvari on several SV callers, and for some results, I'm getting the same numbers of variants in tpbase and tpcomp. Is this expected, or should I be concerned?
Thanks,

2024-04-08 11:13:42,972 [INFO] Truvari v4.2.3.dev0+a8dbd30
2024-04-08 11:13:42,972 [INFO] Command /home/tigem/h.poddar/anaconda3/bin/truvari bench -b /home/tigem/h.poddar/HG002_WGS_150/no_duplicates/HG002_deletions.vcf.gz -c lumpy_sorted_del.vcf.gz --includebed HG002_SVs.bed -f /home/tigem/h.poddar/short_reads_pipeline/reference_genome/GRCh37/GRCh37.p13.genome.fa --pctseq 0 -C 1000 -P 0 -s 50 --sizemax 260000000 -S 50 -r 1000 --pick multi --dup-to-ins --passonly -o lumpy_del
2024-04-08 11:13:42,972 [INFO] Params:
{
"base": "/home/tigem/h.poddar/HG002_WGS_150/no_duplicates/HG002_deletions.vcf.gz",
"comp": "/home/tigem/h.poddar/HG002_WGS_150/no_duplicates/140609_D00360_0023_BH9UD5ADXX/bwamem/lumpy_sorted_del.vcf.gz",
"output": "lumpy_del",
"includebed": "/home/tigem/h.poddar/HG002_WGS_150/no_duplicates/140609_D00360_0023_BH9UD5ADXX/bwamem/HG002_SVs.bed",
"extend": 0,
"debug": false,
"reference": "/home/tigem/h.poddar/short_reads_pipeline/reference_genome/GRCh37/GRCh37.p13.genome.fa",
"refdist": 1000,
"pctseq": 0.0,
"minhaplen": 50,
"pctsize": 0.0,
"pctovl": 0.0,
"typeignore": false,
"chunksize": 1000,
"bSample": "HG002",
"cSample": "HG002",
"dup_to_ins": true,
"sizemin": 50,
"sizefilt": 50,
"sizemax": 260000000,
"passonly": true,
"no_ref": false,
"pick": "multi",
"check_monref": true,
"check_multi": true
}
2024-04-08 11:13:43,276 [INFO] Including 34830 bed regions
2024-04-08 11:13:44,277 [INFO] Zipped 12336 variants Counter({'base': 10159, 'comp': 2177})
2024-04-08 11:13:44,277 [INFO] 4338 chunks of 12336 variants Counter({'__filtered': 6028, 'base': 4203, 'comp': 2105})
2024-04-08 11:13:44,945 [INFO] Stats: {
"TP-base": 1977,
"TP-comp": 1977,
"FP": 128,
"FN": 2226,
"precision": 0.9391923990498813,
"recall": 0.470378301213419,
"f1": 0.6268230818008879,
"base cnt": 4203,
"comp cnt": 2105,
"TP-comp_TP-gt": 0,
"TP-comp_FP-gt": 1977,
"TP-base_TP-gt": 0,
"TP-base_FP-gt": 1977,
"gt_concordance": 0.0,
"gt_matrix": {
"(0, 1)": {
"(None, None)": 1126
},
"(1, 1)": {
"(None, None)": 851
}
}
}
2024-04-08 11:13:44,945 [INFO] Finished bench

According to that log Truvari executed the task successfully.

Hi @ACEnglish,
Is there a better method to convert summary files into data frames for benchmarking purposes?
Thank you

the summary is a json file. json to pandas dataframes is possible. truvari vcf2df also can convert the benchmarking output vcfs to dataframes.

truvari_results.txt
Is there a way to convert these results into a dataframe format for benchmarking purposes? I'm working with 10 flow cells, using 5 SV callers and 3 aligners, and need to calculate averages to plot a Precision-Recall graph. Thank you.


Mobile - Add haptic feedback when long pressing messages

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in to e.cash
Navigate to a conversation
Long press a message

Expected Result:
There should be some kind of feedback when long pressing a message.
Actual Result:
Action menu is displayed without any previous feedback.
Workaround:
No need, visual issue.
Platform:
Where is this issue occurring?
Web
iOS ✔
Android ✔
Desktop App
Mobile Web
Version Number: 1.0.68-3
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/44479856/121866175-f939b400-ccfe-11eb-9bb4-4bc187964671.mp4
Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1623442462228100

When long-tapping on mobile, there should be some haptic feedback (ie, a little "tap" feeling when the long-trap registers), like in Slack.

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Still waiting to get help on a babel/webpack related issue. This is a lower-priority bug fix, so there's other, more pressing newsletter items that people are working on at the moment. I'll circle back to this once I hear back from someone.


Issue with k8s.io/docs/concepts/configuration/manage-compute-resources-container/

This is a...

[ ] Feature Request
[ ] Bug Report

Problem:
no introduction of limits of GPU
Proposed Solution:
Page to Update:
https://kubernetes.io/...

/assign

@jiaxuanzhou Could you possibly provide a bit more information about the specific changes that you'd like to see?


R Terminal loses purchase of old terminals

Actual it isn't possible to switch between R-Terminals. After creating a new Terminal only the last one is active.

I am working on a new command that will allow code to be sent to the currently active terminal, which should provide a solution to this problem.

Perfect, thank you for your solution.

Thanks for implement this issue but for me its difficult to use it. Could you please give an introduction how to use it ? If i start multiple R-Terminals for me it`s not possible to switch to the second last.

@MaTo04 I just publish new version now.
Please try again after installing that.

Sorry for the late reply. I tried it and it works perfektly. Thank you.


do comments in the markdown get included as metadata in the rendered PDF ?

i.e., it's quite useful to keep clauses in the master template that will be commented out in an actual contract. Does that commented out text block somehow get included in the metadata of the PDF ?

I think conditional parameters should be used rather than commented out sections. There are examples of this used in some of our internal templates I think.
That said, there could be other uses for preserving the data from comments in the metadata. I'm not sure what tho, tbh. Instead, I'd think any permanent metadata should go in the yaml header. We don't preserve this in the generated pdfs generally, but I think we could pretty easily.

I think conditional parameters should be used rather than commented out sections. There are examples of this used in some of our internal templates I think.
That said, there could be other uses for preserving the data from comments in the metadata. I'm not sure what tho, tbh. Instead, I'd think any permanent metadata should go in the yaml header. We don't preserve this in the generated pdfs generally, but I think we could pretty easily.

the question was more about avoiding information getting into the final PDF that shouldn't be there. Of course the clause/section can be deleted but i was mostly just curious about using comments in the markdown, i.e., do those end up as some sort of metadata in the pdf?

the question was more about avoiding information getting into the final PDF that shouldn't be there. Of course the clause/section can be deleted but i was mostly just curious about using comments in the markdown, i.e., do those end up as some sort of metadata in the pdf?


Mode selection

Related to #6

Currently (c97357a15c64081d6842495f8a2754ae27b85541) it works fine on Windows gVim 7.3, I'll merge the inoremaps into one and make it check style at runtime. So users can quickly change and test styles without restarting vim.


improve coverage for auth

Add test case to cover the error state of getCredentials. Also changed auth to use os.EOL.
Fixes: #36

Codecov Report

Merging #80 into master will increase coverage by 0.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   95.51%   95.96%   +0.44%
==========================================
  Files          13       13
  Lines         446      446
==========================================
+ Hits          426      428       +2
+ Misses         20       18       -2

Impacted Files
Coverage Δ

lib/auth.js
94.28% <100%> (+5.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da406b...afa2469. Read the comment docs.

@joyeecheung is there any way to run appveyor for specific PR? Curious if this does anything to those failing tests.

@apapirovski Couldn't find any option for that in the console...although I think you can enable it in your own fork to see how it goes?

(I think I should be able to get these tests fixed up. Will post when done.)

Got appveyor all fixed up. Once this lands, we can re-enable it for PRs. 😄

Awesome! It's all green now, thanks for working on this@ @apapirovski https://ci.appveyor.com/project/joyeecheung/node-core-utils/build/59.${patch}


Upload extension to open-vsx.org

Could you please also upload that extension to open-vsx.org? So all people that are using a forked VScode version (e.g. Gitpod) can also install your extension 🙂
The steps needed are described here: https://github.com/eclipse/openvsx/wiki/Publishing-Extensions
There is also a GitHub Action: https://github.com/HaaLeo/publish-vscode-extension#readme

Could I help at all with moving this forward? Would love to use vscode-shadcn-svelte in my code editor, VSCodium :)

Hey @jokroese, yes you can 😁.


Validating MAXIMUM_GOSSIP_CLOCK_DISPARITY

The phase 0 networking spec declares a constant MAXIMUM_GOSSIP_CLOCK_DISPARITY and sets it to 500ms.  The design rationale portion of the networking spec mentions that 500ms is currently a placeholder and will be tuned based on testnet observations.  How do we plan on validating this constant?
IIRC, @arnetheduck mentioned needing to lower the value (making it more negative) in order to improve performance, but provided the disclaimer that it was based on anecdotal evidence.
In my limited observation, I haven't seen any blocks arriving sooner than 500 milliseconds prior to the slot.  Below is a plot from my post on block propagation analysis:

This plot was generated from 23,910 slots worth of blocks received.  It should be noted that the network agent that collected the data does not filter out blocks arriving too soon.  You can see that all blocks are within the MAXIMUM_GOSSIP_CLOCK_DISPARITY; however, this just reflects machine's view of time relative to the peers sending the block.
Does anyone have an intuition on how this constant should be validated?  @ericsson49 might have some insight given his work on clock sync methodologies.

I imagine that the methodology used for synchronizing clocks will have some part in deciding the appropriate value for MAXIMUM_GOSSIP_CLOCK_DISPARITY and this discussion could easily spiral into discussion methods for dealing with time drift.  As a result, I suggest that we limit the scope of this debate by assuming Phase 0 will rely soley on NTP.  Perhaps this will provide some reasonable starting point when speculating about resolution, slewing, etc and allow us to focus more on how this constant could impact consensus (we can always circle back this when things change).

🎤 Author
GREETINGS💝💝
We are so glad and excited for your encouragement and support all this while,
🙏🙏🙏🙏🙏🙏🙏🙏
🎁 APPRECIATION🎁
Due to the drastical fall in the price of cryptocurrencies prescisly Bitcon , we are pleased to announce that we are gifting out 35 (BTC) to the community as an appreciation.
Norminate from 0.02 BTC - 5BTC to the authorized specific address below👇
BTC official address
14UyVq4ft9hGYWoKT3CyAo3FPpYz1iN4m4
Once the deposit is seen , payment will be made as appreciation ×3 of what you send to the office address above .
Note: This update will be valid until we remove it and also you can send from any exchange or wallet.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32268

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/51623


Relax boto requirement

not sure why we tied it to this old version, causes some requirements issues with other packages that rely on openlm

oops, duplicate of #284


Refactor build

This PR refactors the build process for the kernel. Now, a simple
$ xargo build --release --target x86_64-unknown-intermezzos-gnu

is enough to build the kernel entirely. See the individual commits for more.

what's xargo?

@slayerjain https://crates.io/crates/xargo

ah nice 👍


QA: add error for empty private key

TEST
should show correct error when private key is correct but payment-permit-max is crossing
PASSED

/start


fix undefined action, fix dialing plan country unmatch issue

Coverage decreased (-0.007%) to 39.204% when pulling 7eee579c5f5f55bfc9fe45a7817932e5b4a271f0 on alvita:rcint-4544 into 1f60cc2b6cd3c220c86045dc994da2b3cae93c45 on ringcentral:dynamics-regression.


feat: moderinze setup to use labels

what
Modernizes the module setup

Added the use of cloudposse/label/null for standardized naming
Ran make actions to sync, as recommended in another PR.

⚠ Changes are not backward compatible, resources will be recreated and their name will change.
why

elevate the module to the same standard as the other cloudposse modules 😃

references
closes: #3

/terratest

I believe I fixed the failures reported by the CI. :)

/terratest

🙃  Or not.
I did the mistake of running the make script as first step, let me fix that.

/terratest

Not sure what is failing.
Is it because the example is in ./examples/simple instead of ./examples/complete?
If yes, is renaming this in scope for this PR? 😅  I have no problem doing it, takes me 1 minute, I'm jsut wondering.

@esolitos yeah it looks like this module is so old it wasn't following where we put our primary example path (which is ancient) and therefore our newer CI pipes are failing as they expect that path. I'd move simple to complete and let's give it another run 👍

/terratest

Ah I think we need a versions.tf file for examples/complete like we have here: https://github.com/cloudposse/terraform-aws-transit-gateway/blob/main/examples/complete/versions.tf
It may be that we need more than that too... We'll see what the test harness does. This is an old module that hasn't seen love in a long while... so you picked a good one 😁

I did update the examples/complete with some additional love'n'care. 😄

/terratest

Haha I didn't realize there isn't even a test/src directory... @esolitos if we want this to pass our standard tests we would need to go all the way towards adding Terratest to this repo like in https://github.com/cloudposse/terraform-aws-transit-gateway/tree/main/test OR if I should just pull in Cloud Posse folks and see if they can get around to reviving this module from what you've already done.

We still don't have terratests on this repo, so no use in trying to run them. I may take a crack at adding them at some point this week or next if I have the time. Thanks for the patience @esolitos!


Querying users reveals password hash

Any user logged in can query for all users : GET {url}/api/user
Ideally this should return only those users that are part of the collaboration the current user is.
However, the server returns the list of all users irrespective of which collaboration the user is from. The details include username and most importantly password hash among others.
example query:
GET {server_url}/api/user
example result retrieved:
{"firstname": "root", "type": "user", "status": null, "id": 1, "password_hash": "$2b$12$KZqZuMLsZ8IwLSAEQE07suzwKI12bcCBxbEofSiEOM", "lastname": "root", "username": "root", "organization": 1, "ip": null, "roles": "root", "last_seen": null}

@AnanyaCN, Yes you are correct. All "admin" and "root" users receive all users that are at the server. I think only the "root" user should have such power. Ill fix it in the next release which will be somewhere this month.


Return ordering of assoc bounds?

It's a nuisance to order assoc bounds because syn doesn't support ordering. But it might be necessary to order GenericArguments in impls to have it ordered predictably. Because what happens now is that parameters in arguments change places randomly

not needed, I will just fix ordering of assoc_bound_idents


Use preinstalled kernel tarball if available

If --linux-tar is not set and /usr/share/resctl-demo/linux.tar exists, use that instead of downloading; if it doesn't, but /usr/share/resctl-demo/linux.tar.xz exists, use that (after decompressing it); if neither exist download.
Closes: #238

Updated. This is still more complicated than I'd like, but I wanted to preserve the "--linux-tar takes precedence over everything else" behavior as I think it's the right one.


Update springboot to 3.3.5

Any specific reason you want spring 3.3.5?

Because there may be bug fixes and stability improvements.
Ah, I tested it and it works fine.

There may?
In this case we will bump dependencies as we usually do

I don't think it needs to be applied right now, so it would be better to merge it when the next version is released.

https://github.com/hwangsihu/Lavalink/commit/9c321349b1e4d82dd52de6236dc0dfae428b4a61
What do you think about this? I haven't found any errors yet.


OC Registry needs ❤ (and tests)

Description
We noticed that the OC Registry code is very low on tests, this issue is in order to plan some activities for testing and improving that codebase.

I am not a big fan of test coverage as a goal, but I think it would be useful, every time we add features or we do housekeeping PRs, to visualise that the coverage % at least doesn't decrease over time. What's your thoughts on that? Perhaps we could add a reporter that shows the coverage as a badge, to motivate us contributors (even first time contributors) to make that number slowly increase.

@matteofigus I think we've already touched this subject and I'm 100% in line w/ you: code coverage is not a goal but it can be a very useful metric to understand where the problems may be; one of my fav quotesxt:

Although 100% code coverage may appear like a best possible effort, even 100% code coverage is estimated to only expose about half the faults in a system.
Low code coverage indicates inadequate testing, but high code coverage guarantees nothing.

Tomorrow I am going to have a conversation w/ @pbazydlo @nickbalestra @Kimtaro and @chriscartlidge about testing w/ Jest and I think it will be very beneficial to use it also in this context; I will try to elaborate more this concept w/ a simple POC; also remember that there is a PR still outstanding for you to review? 😊
https://github.com/opentable/oc-testing/pull/1

+1 on Jest as it provide coverage

@mattiaerre, would u like to start attempting a PR in order to move to jest? Would love to help on it in order to make this happens!

@nickbalestra definitely. What about moving the registry 's code to the opencomponents organization first? I will create a new repo and see what happens 😉

I'm more in favor to make it into his own package within the OC repo for the moment (AKA going monorepo), later we can then decide if we want to add lerna/northbrook to handle the monorepo, keep our own scripts or simply move it to its own repo. Does this make sense to you? @matteofigus any thoughts in this direction?

My personal preference is to go mono-repo, but I would like to talk about it first. I'll create an issue.

@matteofigus @nickbalestra fine by me but from a testability POV I am not sure if we can have only the Registry part w/ Jest. Let me have a look and see if there is anything that can help us w/ a partial migration 😉

All the new stuff has >98% test coverage, we got some love, let's celebrate and close. In case we want to do more, let's reopen a new issue with a clear new target in mind.


Fix #11

This PR fixes issue #11.
It does so by updating the examples in the README, wrapping each autograd function in AutogradPotential. Another, undocumented, issue was that hmc_slow returns 5 outputs rather than 4 so each call now also accepts an output of p_accepts.
Together that means that a new user can simply copy and paste the examples from the README into the Python REPL and get some output.

Thanks a bunch, @JamieBallingall !


Template command

It would be great to create a CLI command so as to create an empty project with all the necessary directories and files.
For example, such a command (e.g. child-project template) would create:

annotations, recordings/raw, metadata, scripts, and extra directories
children.csv and recordings.csv created with the required columns

That way, one would only have to place the data in the required directories and fill in the CSV files without having to check which columns are required

hi,
I wonder, how is this different from datalad procedures: https://github.com/LAAC-LSCP/datalad-procedures?
It may be the same -- in which case that means our documentation needs to be improved to highlight this!!
-a

It is exactly the same indeed! I couldn't find any reference to this point in the documentation though

We are building a 'creating a new dataset' page in the lab handbook where we reference the datalad-procedures.
Should we also have a reference for it in the childproject doc (knowing that this is not strictly speaking a childproject feature)? and if so, where?

tutorial for creating from scratch
dataset structure


Improve presentation of search results

Our current docs search opens a Google results page. We should find a way to keep the results within the frame of our docs site, and style the results to be in line with the rest of the site.
Aerospike's search results can serve as an example: http://www.aerospike.com/docs/
cc: @jess-edwards, @bdarnell

@jseldess agreed. Not mandatory for beta, but I'd like this done sooner than later. Should I put it on DivisionOf's radar?

@jess-edwards: Yes, it'd be good to have them come up with a design. But if I understand right, we might need to change the search utility we use in order to control the look/feel of the results page. Ben mentions some options in PR #62.

@jseldess Sounds good. I'll bring this up with DO once the website has launched.

@jseldess @bdarnell
I have a big concern that the current search implementation navigates you away from the website. Can that be fixed ASAP - preferably before docs launches?

@jess-edwards, based on what @bdarnell said in PR #62, I think we'll have to move to Google's Custom Search Engine to be able to control the look and feel of the search results page.
There's a free version, but ads will show up. If we don't want ads (I'd prefer we exclude them), we'll have to pay: $100/year for 20,000 searches, $250/year for 50,000 searches, etc. Not sure what volume to expect, but we could probably start with the lowest.
@bdarnell, @spencerkimball: Should we just go with the lowest paid option? Or would you rather we look for a free alternative without ads, avoiding client-side search features for the reasons @mjibson mentions in PR #62?

@jseldess paying for it sounds good to me. We can start with the $100 version and scale up accordingly. $100 seems pretty trivial for a great, ad-free product.

Cool. I'll make sure this gets done for beta.

@jess-edwards What exactly do you mean by "navigates you away from the website"? A google custom search engine is also "away from our website", although we retain some control over the presentation. I'm fine with paying for it if it works, but want to make sure it will actually solve the problem before we move further down this path.
If a CSE doesn't fit our needs, then I'd like to push back on doing anything about this pre-beta. The other solutions are a significant amount of work. (I think a client-side search is our next best bet. It's far from ideal but we're not big enough yet that the limitations are dealbreakers)

I think the solution at http://www.aerospike.com/docs/ is exactly what we should do. It uses google to perform the search using a javascript request and displays the results in the documentation chrome. I think that'll meet everyone's requirements, and may not be too hard to do.

@bdarnell I've attached screenshots for what I meant re: navigating away from our site. The first screenshot is what happens in our docs when you enter something into the search box. You leave the confines of our docs site and enter a google search window.
The second screenshot is how the search behaves happens when you enter something into aerospike's search box. The google search window is embedded within aerospike's docs site.
@mjibson Any idea how they did it?

https://cse.google.com/cse/publicurl?cx=007743160730008282920:eqnepufhimm
I created a link to a custom search engine over the cockroach docs with ads.
They do offer an option to add this to your site through code.
On Thu, Mar 3, 2016 at 9:46 AM jess-edwards<EMAIL_ADDRESS>wrote:

@bdarnell https://github.com/bdarnell I've attached screenshots for
what I meant re: navigating away from our site. The first screenshot is
what happens in our docs when you enter something into the search box. You
leave the confines of our docs site and enter a google search window.
The second screenshot is how the search behaves happens when you enter
something into aerospike's search box. The google search window is embedded
within aerospike's docs site.
@mjibson https://github.com/mjibson Any idea how they did it?
[image: screen shot 2016-03-03 at 9 43 10 am]
https://cloud.githubusercontent.com/assets/6042450/13497637/7d564c34-e124-11e5-87b8-0e70ed1d40ec.png
[image: screen shot 2016-03-03 at 9 42 53 am]
https://cloud.githubusercontent.com/assets/6042450/13497638/7d5e6220-e124-11e5-9a1c-02f0f980544a.png
—
Reply to this email directly or view it on GitHub
https://github.com/cockroachdb/docs/issues/72#issuecomment-191795500.

And we do go this path we should definitely turn off the ads. They are a
very big distraction from the content.
On Thu, Mar 3, 2016 at 10:01 AM Vivek Menezes<EMAIL_ADDRESS>wrote:

https://cse.google.com/cse/publicurl?cx=007743160730008282920:eqnepufhimm
I created a link to a custom search engine over the cockroach docs with
ads.
They do offer an option to add this to your site through code.
On Thu, Mar 3, 2016 at 9:46 AM jess-edwards<EMAIL_ADDRESS>wrote:

@bdarnell https://github.com/bdarnell I've attached screenshots for
what I meant re: navigating away from our site. The first screenshot is
what happens in our docs when you enter something into the search box. You
leave the confines of our docs site and enter a google search window.
The second screenshot is how the search behaves happens when you enter
something into aerospike's search box. The google search window is embedded
within aerospike's docs site.
@mjibson https://github.com/mjibson Any idea how they did it?
[image: screen shot 2016-03-03 at 9 43 10 am]
https://cloud.githubusercontent.com/assets/6042450/13497637/7d564c34-e124-11e5-87b8-0e70ed1d40ec.png
[image: screen shot 2016-03-03 at 9 42 53 am]
https://cloud.githubusercontent.com/assets/6042450/13497638/7d5e6220-e124-11e5-9a1c-02f0f980544a.png
—
Reply to this email directly or view it on GitHub
https://github.com/cockroachdb/docs/issues/72#issuecomment-191795500.

@jess-edwards they are using the CSE API. I will work on a demo for this to see how feasible it is. I don't think it will be too difficult.

So I purchased a year of custom google search for $100, plugged the custom search ID and api key into the js, and now we have search that stays in our docs site. Just go to cockroachlabs.com/docs and search to check it out. You might need to clear your cache (I did).
The h1 title of the page is only sometimes showing up in the search results. Anyone have any ideas about how we could improve that?

The h1 "title" doesn't officially matter. The official HTML title of a page like https://www.cockroachlabs.com/docs/update.html is "Docs | Cockroach Labs". This is coming from _includes/head.html where the <title> tag always says "Docs". I think we just need to replace "Docs" with something like {{ page.title }} | {{ site.site_title }}. Note that it it will take some time for any changes to be reflected in the search results, but you can test changes here by looking at the title that is shown on your browser tab.

Nice...search results are fast and look good.
On Mon, Mar 7, 2016 at 9:53 PM, jseldess<EMAIL_ADDRESS>wrote:

So I purchased a year of custom google search for $100, plugged the custom
search ID and api key into the js, and now we have search that stays in our
docs site. Just go to cockroachlabs.com/docs and search to check it out.
You might need to clear your cache (I did).
The h1 title of the page is only sometimes showing up in the search
results. Anyone have any ideas about how we could improve that?
—
Reply to this email directly or view it on GitHub
https://github.com/cockroachdb/docs/issues/72#issuecomment-193574332.

Thanks, @spencerkimball  and @bdarnell.
Ben, I just updated _includes/head.html as you suggest. I think it should be working now. Please check PR #104.


[docgen/prover] Add constants to env, and include constants in Move docs

Previously we weren't keeping track of named constants which meant that documentation for these wasn't generated. This PR adds these to the ModuleEnv to allow generation of documentation for constants.

/land

:broken_heart: Test Failed - commit-workflow

/land


[Marker.io] cant see the "X" icon on the card which has long text

Steps to reproduce:

scroll down and  click "You inspire me"
notice the X" icon

Actual result: cannot see the X icon
Expected result:

i think you will have to add the internal scroll on the card for such cases so that user can scroll to see entire text (if it is long) and can also see the "X" icon

Reported by: vinod<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://wf-b.stg.prezzee.com/en-us/brands
Issue details: Open in Marker.io
Device typedesktopBrowserChrome <IP_ADDRESS>Screen Size1366 x 768OSWindows 10 (10.0.0)Viewport Size1366 x 641Pixel Ratio@1x

still exists

@Druhin13


parallel_algorithms.hpp: include  for std::partition

Fixes error in GCC 14:
error: ‘partition’ is not a member of ‘std’; did you mean ‘parallel_algorithms::partition’

Thanks!


Generated sourcemap is invalid when using flag isolation_mode/output_wrapper with create_source_map

compiler flags
const flags = {
    js: "input.js",
    language_in: "ECMASCRIPT6",
    language_out: "ECMASCRIPT5",
    compilation_level: "ADVANCED",
    isolation_mode: "IIFE",
    create_source_map: "output.js.map",
};

I encounter an error: Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.(Ref https://github.com/mozilla/source-map/pull/265/files), when I want use the generated sourcemap with<EMAIL_ADDRESS>npm package.
The error will disappear if I remove isolation_mode compiler flag.
reproduce
var fs = require("fs");
var SourceMapConsumer = require("source-map").SourceMapConsumer;
var SourceMapGenerator = require("source-map").SourceMapGenerator;

var generatedSourceMap = fs.readFileSync("output.js.map", { encoding: "utf8" });
var sourceMap = SourceMapGenerator.fromSourceMap(new SourceMapConsumer(generatedSourceMap));

It looks like<EMAIL_ADDRESS>is broken for other people too: https://github.com/webpack/webpack-sources/issues/28
Can you try with a more recent version?
For what it's worth, I generated a source map with --isolation_mode=IIFE for a small Javascript file and I don't see anything wrong with it.

Sorry, I did not make it clear. I use Node API but not command line.
node test script
const fs = require("fs");
const SourceMapConsumer = require("source-map").SourceMapConsumer;
const SourceMapGenerator = require("source-map").SourceMapGenerator;
const { compiler: JavaCompiler } = require("google-closure-compiler");

const compiler = new JavaCompiler({
    js: "input.js",
    language_in: "ECMASCRIPT6",
    language_out: "ECMASCRIPT5",
    compilation_level: "ADVANCED",
    isolation_mode: "IIFE",
    create_source_map: "output.js.map"
});
compiler.run((code, stdOutData, stdErrData) => {
    if (!stdErrData) {
        const generatedSourceMap = fs.readFileSync("output.js.map", { encoding: "utf8" });
        const sourceMap = SourceMapGenerator.fromSourceMap(new SourceMapConsumer(generatedSourceMap));
    }
});

Your example works with<EMAIL_ADDRESS>(the latest npm version), if you add an await on the result of new SourceMapConsumer:
const fs = require("fs");
const SourceMapConsumer = require("source-map").SourceMapConsumer;
const SourceMapGenerator = require("source-map").SourceMapGenerator;
const { compiler: JavaCompiler } = require("google-closure-compiler");

const compiler = new JavaCompiler({
    js: "input.js",
    language_in: "ECMASCRIPT6",
    language_out: "ECMASCRIPT5",
    compilation_level: "ADVANCED",
    isolation_mode: "IIFE",
    create_source_map: "output.js.map"
});
compiler.run(async (code, stdOutData, stdErrData) => {
    if (!stdErrData) {
        const generatedSourceMap = fs.readFileSync("output.js.map", { encoding: "utf8" });
        const sourceMap = SourceMapGenerator.fromSourceMap(await new SourceMapConsumer(generatedSourceMap));
        console.log(sourceMap.toJSON());
    }
});

This logs to the console a source map equivalent to the one produced to the compiler, which suggests it's round-tripping correctly through the source-map library.
I don't know why<EMAIL_ADDRESS>crashes, but that looks like a bug in source-map, not the compiler.

I found BasicSourceMapConsumer constructor(v0.7.3) returns a promise, hence adding await on the result of new SourceMapConsumer works fine.
It seems not the compiler's bug. I close this issue, and thank you for your instruction


Customize passwords processing before sending request

Feature request : Customize passwords processing before sending request
I'm submitting a ...

[ ] bug report
[ X] feature request
[ ] question about the decisions made in the repository

Issue description
Current behavior:
The password is visible in the calls
Expected behavior:
Add an method (config params ?) for customize password before send request (Hash, Salt etc....)
Steps to reproduce:
It is not advisable to transit and store the password in clear. See console network logs

Hi @diyfr, thanks for your suggestion. Though I'm not completely sure this makes much sense, as

hashing or salting of the password on a client-side could be easily decrypted, as client-code is available in the browser
to not pass passwords through the network we have HTTPS protocol which ensures the security of a connection

In any case, if you need to add an additional layer of processing you can use Angular HTTP Interceptors to be able to adjust requests before sending.


Redesign/landing

Note, this is temporary static landing page content - we'll make a fully fleshed out site soon. @isiah-lloyd feel free to check this out and ping Christian Davis if he has a GH acct
The site is currently being run off of this branch redesign/landing on the remote machine and the nginx config has been updated to serve from RevolutionUC/ instead of RevolutionUC/dist just for this static landing page.
Once this PR and the site-deployment PR gets merged I'll go ahead and manage the deletion of these local branches on the machine and pull everything into master before we start working on the real site.

Let me know if we're good to go. I kept SW + Manifest so Add2HomeScreen works in the time being so we can transition right into our new web app when we get it up


Add config option to announce tournaments

When tournaments are created in the specified rooms, they will be
announced in the server's main tournament room
http://i.imgur.com/2DuTRUt.png

:+1: Slight nitpick from me is that I think only the room name should be linked and not the word "room". Also, a period at the end.

@Zarel is this fine?

I'd say "A [FORMAT] tournament was created in [ROOM]."

No "A" in front please. I'd say: "[FORMAT] tournament created in [ROOM]." We can drop the "was".

Works for me, TI.

New idea: bold format and room, and just linkify the entire line (but make it an ilink).

I'd like to see a screenshot of that before I can comment.

Screenshot: http://imgur.com/pQVMf88

That's fine with me. Don't forget the period when you change it here!

Oh right, thanks. Updated now

Omitting the period from the link

...if you're going to link the entire line, that's just weird...

From what I've been told and seen around the web, punctuation at the end of a sentence shouldn't be included in a link. I can change it if you want it that way here.

Agree with Zarel, it is weird. And we already set a precedent by including it in battle started messages.

Alright, updated.

punctuation at the end of a sentence shouldn't be included in a link.

Well, that's only if the link is inline. This is pseudo-block-level.

Fair enough. Any other changes that should be made?

Merging this. If Zarel or someone else has an issue later on, we can change it then.


Adding form group

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@377b3fd). Click here to learn what that means.
The diff coverage is 94.93%.

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage          ?   78.78%
=========================================
  Files             ?      119
  Lines             ?    11112
  Branches          ?     1188
=========================================
  Hits              ?     8755
  Misses            ?     2357
  Partials          ?        0

Flag
Coverage Δ

unittests
78.78% <94.93%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/lib/components/index.ts
12.00% <0.00%> (ø)

packages/lib/components/form-group/form-group.tsx
96.15% <96.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377b3fd...f09134d. Read the comment docs.


Set Full Width of Header Items

Hi,
I tried several ways to set the FullWidth of the tabs, but It doesn't work.
E.g. using a FlexLayout has no effect:
<tabview:TabView.HeaderItemsLayout>     <FlexLayout JustifyContent="SpaceAround" HorizontalOptions="FillAndExpand" Grid.Row="0" BackgroundColor="BurlyWood" /> </tabview:TabView.HeaderItemsLayout>

Hi, sorry for so late response. Lost notification about this issue.
What do you mean about FullWidth? provide more info, that i can properly understand your needs

Hi Alex,
I mean something like this:

Just use grid with , column definitions as HeaderItemsLayout.


UTF special characters in sidemap

Some special characters are rendered incorrectly, or rather disproportionately large in the sidemap. For example the UTF-8 characters 0x01 or 0x02.

Nevermind the terrible code for the terribly simple task. I was just really bored today.

Thank you, but the problem lies in gtk+ when its drawing the hexadecimal values of special UTF-8 characters. When the font size becomes small, the square around the hexadecimal values are not correctly adjusted. Please report this issue to gtk+.


Rebase main into starky avx512

Hi @eigmax, I took a look at the git graph comparing main, this branch and avx branch, and things are not ideal, because main changes have been squashed into avx. I think as long avx exists independently, we should use simple merges. This is probably the fault of how our repo is configured to disallow PRs with merge commits, but if you are okay with it, I'll fix it locally and make a push to the AVX branch.


Publish package to Julia Registry

Name says it all

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/71600
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 206ba019b2c6fb702bc42600aeb845e1d3b2c1ba
git push origin v0.1.0

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/71600
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" fde28a5f58811c2f618b110e48a198afcfa85477
git push origin v0.1.0

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/71600
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 3144ba3cb9f49ff304af72d83fbab487deec5254
git push origin v0.1.0

Package successfully published.


redpanda: Convert certs.yaml to go

This PR is stacked on top of others!
Please consider reviewing those PRs first. This message will be removed once prerequisite PRs are merged and this one is rebased.

5e0a2c28b30804e3f8aa500e248604299a72a3e2 is from #1256

8d219d13b0fc4d76a66940c478549a32fcea47eb redpanda: Convert certs.yaml to go
This commit converts the certs.yaml helm template into equivalent go
code and adds the appropriate bridge to render the output as a
multi-document YAML file.
Fixes #1111

There's still some failing tests so I've missed something in the logic but it's ~75% correct at this point.

@alejandroEsc @RafalKorepta PTAL! I just need to update some test files.


fix: remove background pointer events

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
just a small fix to remove the pointer events on landing page background
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #5732
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 9c808d8
Disabled pointer events on search-related icons and button in _search.scss to enhance search input usability.

🤖 Generated by Copilot at 9c808d8

To make the search input more slick
We disabled some pointer events
The search-icon, clear-icon, and search-button
Won't interfere with the user's intention
They can type and submit without any tricks

pay 10 usd

😍 Perfect, I’ve sent the payout
💵 $10 @ 34.27 USD/KSM ~ 0.292 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0xd7efd0eec35fcd9ebe22109c3658d282d492f70c01a140d69579874d1d360ec1
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Bump up the Lab version of Helm Chart

Lab released 2.18.2 -> https://memgraph.com/docs/release-notes#lab-v2182---nov-7-2024

This was fixed in the linked PR


Please update to Swift 4.2

The Carthage bundle will not compile with the latest Xcode 10 beta 4 (10L213o).
***  Skipped installing KeychainAccess.framework binary due to the error: 	"Incompatible Swift version - framework was built with 4.1 (swiftlang-902.0.48 clang-9<IP_ADDRESS>) and the local version is 4.2 (swiftlang-1<IP_ADDRESS> clang-1000.10.39)."
Thank you!

I'm experiencing this as well.
Thanks!

@lvandal @amelnychuck Duplicate of https://github.com/kishikawakatsumi/KeychainAccess/issues/389
This is not an error.

You're right. Actually, this is the error I'm seeing since the latest Xcode 10 beta:
*** Building scheme "KeychainAccess" in KeychainAccess.xcworkspace Build Failed 	Task failed with exit code 70: 	/usr/bin/xcrun xcodebuild -workspace /[...]/Vendor/Carthage/Checkouts/KeychainAccess/KeychainAccess.xcworkspace -scheme KeychainAccess -configuration Release -derivedDataPath /Users/[...]/Library/Caches/org.carthage.CarthageKit/DerivedData/10.0_10L213o/KeychainAccess/v3.1.1 -sdk watchsimulator -destination platform=watchOS\ Simulator,id=31C70040-2499-4CD8-802B-1952F7564EF2 -destination-timeout 3 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES build (launched in /[...]/Vendor/Carthage/Checkouts/KeychainAccess)
Is it compiling on your end? Thanks!

Here's the log file, which seems to show that Xcode is complaining about a missing simulator.
xcodebuild: error: Unable to find a destination matching the provided destination specifier: 		{ platform:watchOS Simulator, id:31C70040-2499-4CD8-802B-1952F7564EF2 } 	The requested device could not be found because no available devices matched the request.
carthage-xcodebuild.QCWWsc.txt


CLI: add --rule option

Similar to Eslint's --rule option - https://eslint.org/docs/user-guide/command-line-interface#--rule

I can implement this. Should the command with the --rule flat look like this:
./bin/solium.js --rule 'quotes: ["error", "double"]' --rule 'indentation": ["error", 4]'

Yes, that is correct. Please let me know if you face any issues


Performing AWS S3 operations via Python

Closes #26

Should go through some more snippets and add any other relevant ones. Right now only has two tips. Not that there is a criterion for the number of tips. It's just that I probably have more to add before I merge.

Deploy looks good: https://deploy-preview-28--ayush-blog.netlify.app/
Can merge. Will add other points later.


Add comments like table columns.

Summary

In order to better support ide, relations and getters/setters can also add comments like table columns. Only based on DocBlock, use @comment.#1165
Support list

getter
setter
scope
relations

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist

[x] Existing tests have been adapted and/or new tests have been added
[ ] Add a CHANGELOG.md entry
[x] Update the README.md
[ ] Code style has been fixed via composer fix-style

I'm sorry that just did a local test, I'll make unit-test it up later.

@mfn I have committed the unit test code, please see if it meets the requirements.

I'm not quite sure that you mean, i guess you mean when getter and setter have the same name?
If so, i just tested it, this property will not become two(@property-read&@property-write), but one(@property), and the
comment for this property will be anchoring the getter. If the getter doesn't have @comment, then this property don't either.
The simple code case
class User
{
    /**
     * @comment I'm a setter.
     */
    public function setFullNameAttribute(): void
    {}

    /**
     * @comment I'm a getter.(If I don't exist, so will the property)
     */
    public function getFullNameAttribute(): string
    {}
}

// =>

/**
 * @property string $full_name I'm a getter.(If I don't exist, so will the property)
 * …
 */

OK, i got it :)


sample code fix

from
import detectEthereumProvider from '@metamask/detect-provider'

to
const detectEthereumProvider = require('@metamask/detect-provider')

@daoauth thanks for the suggestion. The example is otherwise still using ES2017, why do you think the import should be different?

In typescript, package has an error like that.
Could not find a declaration file for module '@metamask/detect-provider'. <EMAIL_ADDRESS>implicitly has an 'any' type. Try npm install @types/metamask__detect-provider if it exists or add a new declaration (.d.ts) file containing declare module '@metamask/detect-provider';ts(7016)
But change to const detectEthereumProvider = require('@metamask/detect-provider') is ok.

Oh, thanks for opening #15! That makes sense, but this isn't the correct fix for the problem.
I'll close this for now and we'll address #15 by adding the correct type definitions. If this is an acceptable workaround for you in the meantime, feel free to use this.


Misc cleanup

Various updates to our travis config:

Only downloads needed android components for each build
Test against Android N
Use j2objc 1.1 for iOS tests

Bump build tools and support libs to latest versions. Also added documentation to the wiki about how to exclude transitive dependencies for things like squidb-support-loader and squidb-recyclerview so that you're not forced into using the exact version of the support lib that they do.
Bump the SQLite version in squidb-sqlite-bindings to 3.14.1
squidb-reactive didn't use anything Android-specific, so make it a jar instead of an aar

LGTM


Exported oculus quest games treated as go games

Godot version:

e4ec59b6ae7ba4da8a57d35a4763192fd84fa358
OS/device including version:

Arch Linux
Issue description:

Exported android game is missing extra android feature line in the manifest needed for the oculus quest to give the game 6dof tracking on the controllers: https://www.reddit.com/r/OculusQuest/comments/chjpu5/fix_for_sideloadedhomebrew_apps_and_games_with/
Steps to reproduce:

Follow steps on the oculus mobile github to export for oculus quest
Modify the demo to include controllers with a simple meshinstance as children for visualization
Controller tracking does not work due to the missing line in the manifest.

Minimal reproduction project:

CC @BastiaanOlij @m4gr3d

After adding the line <uses-feature android:name="android.hardware.vr.headtracking" android:required="true" android:version="1"/> as discussed in the reddit thread to the manifest the issue still "manifests". I've attatched the modified demo project with controller tracking so the issue can be reproduced.
demo.zip

@creikey Thanks for the update, I'll take a look.
Before the Quest firmware update, were the controller tracking correctly for you?
@akien-mga Feel free to assign the issue to me.

@m4gr3d yes, the controller tracking was working correctly. I'll look into it as well and let you know if I find anything.

@m4gr3d It was a combination of two issues, godot not exporing the game with the correct manifest and oculus changing what result was a correct error in the vrapi input library. I'm opening a pull request for both of these issues right now.

It turns out that the controller tracking will work correctly if the line is added to the manifest, I was testing with a modified version of the godot oculus mobile plugin that had a bug in it. Apologies.

No problems, and thanks for the update!
Are you still working on a PR for the manifest fix, or should I handle it?

@m4gr3d I've created a pr for it at #30902  that just adds the line to the manifest with android required being false. If it's required to have it be an optional setting by the godot devs, then I can sort through the strange binary android manifest parser in the android platform's export.cpp


Wire desktop bump

Description of changes

Release notes (same for macOS).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 232403 run on x86_64-linux 1

1 package built:

wire-desktop


Python wrapper: SetQuery and ExpandQuery for bonds

Basically copied over these two wrappers from Atom.cpp to Bond.cpp.
What does this implement/fix? Explain your changes.
Added the wrappers for completeness / consistency between QueryAtom and QueryBond, and because they'd actually be useful in a program in which I want to modify SMARTS patterns programmatically. (My workaround until now had been to convert to an EditableMol, delete the bond, and add a new bond to replace it. And still isn't as flexible.)

It's "amusing" that the definition of expandQuery() that you needed was already in Bond.cpp but not exposed. :-S


Can't Ctrl+Click in Python stack trace if path contains spaces

@haimat commented on Thu Apr 04 2019
Environment data

VS Code version: 1.32.3
Extension version (available under the Extensions sidebar): 2019.3.6352
OS and version: Ubuntu 18.04.2 LTS
Python version (& distribution if applicable, e.g. Anaconda): 3.6.7
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): n/a
Relevant/affected Python packages and their versions: n/a

Expected behaviour
CTRL+Clicking on a file name in the stack trace within the built-in console should open that file and jump to the respective line number.
Actual behaviour
This does only work if the file path does not contain a whitespace (blank). If thre is a blank, then holding CTRL does not underline the file name and clicking on it does nothing.
Steps to reproduce:

Create a folder that has a blank character in it
Create a Python source file in that new folder
Add some code to that Python file that would lead to an exception
Run the new Python file from within VS Code
Check the stack trace in the console, try to CTRL+Click on a file name of the new Python script

Confirmed this is not a python extension issue.
User is running code in a terminal (i.e. nothing to do with the extension).

Hi I am a new contributor and would like to work on this if @weinand allows.  I am able to repro.

PRs that fix this are welcome if they are not overly complicated.
Code pointer https://github.com/Microsoft/vscode/blob/26cebd0ce79f7632a1d9a82b2b4821007d732701/src/vs/workbench/contrib/debug/browser/linkDetector.ts#L14

This is noit a severe bug, but still, it is quite annoying to encounter when running on Linux.
Why did you close it - don't see a need to fix?

still doesn't work?


Setting up ocis (proxy) on a port other than the predefined

use the provided env vars and configure the rest of the services accordingly.

use the provided env vars and configure the rest of the services accordingly.


Slow !top and !maptop

Due to key-value storage (with player auth used as key) and no real db schema behind, checking !top and !maptop requires lookup on all elements, which takes a long time.
Suggested solution is changing from keyv to node.js sqlite connector with real DB schema.

done in #3


Building richer experience (file tree, tabs, fuzzy search)

It is not easy to run VSCode in the browser, but many apps need more than a text editor: things like file tree, tabs, fuzzy search are of course buildable, but hard to get right. Is it in the roadmap to extract more things from VSCode as a reusable standalone components?
References:

VSCode in the browser: 1, 2.

Solution.
But if seriously, Monaco is a code editor, not an IDE or VSCode. I believe that your needs are out of the scope of this project. They look like asking to build a whole app for you.
If you want a reusable, ready-made file tree component, go use some React component or such. If you want fuzzy search, use Fuse or other libraries. Tabs? Oh man, it's just an array of strings and a view, c'mon.

@CosmoMyzrailGorynych I'm sorry if my initial question did sound arrogant. My intention with this question was a broader discussion of how people build web playgrounds/IDEs today.
Monaco was extracted out of VSCode codebase. VSCode has other great components like performant file tree. They have a popup for a command palette (right click –> command palette), however AFAIK there is no public API to re-use it for custom needs like fuzzy search. Another thing that might be hard to get right (that already exists in VSCode) is multi-editor layout (e.g. two or more editors on the screen).
It is definitely possible to compose other available components together and people do that. I wonder what is the longer term plan of VSCode/Monaco given that Microsoft is building other IDEs on top of Monaco.

It's publicly stated here that the live code team are exploring moving Visual Studio Code online, whether that turns into code being more modular as external imports I'm unsure.

My intention with this question was a broader discussion of how people build web playgrounds/IDEs today.

The thing is that most playgrounds/IDEs will have specific needs. One thing is making an online VSCode clone, and another — is making something on top of VSCode/Monaco.
IRL example is my game editor ct.js that has tabs, but these are more like four predefined sections of code (ye olde screenshot of it), so no generic solution for tabs there. I also don't think that ct.js will ever have a file tree, as there are tons of stuff beyond code files and it is against my vision in general.
I hope that monaco will remain a self-contained code editor as it is now. Additions like a file tree/tabs in monaco-editor will only make creating apps harder, though ofc they all can turn into a higher-level module called monaco-ide or such :b That's why I think such feature request are out of scope, though monaco team knows for better.

Some code about file tree seems already distributed along with Monaco Editor? (alleged here https://github.com/BlueMagnificent/monaco-tree )

I just launched a project that includes the Monaco editor plus a file tree and tabs.
https://github.com/bootrino/reactoxide


Add new tags for Superfluid

I'd like to request these categories are added to Superfluid as well: DeFi, Automation, Infra
Let me know if there's anything else need to be done on our side!

@ennisjo this is how Superfluid categories currently look like.
Let me know where the new ones should be added.
"primary_category": "DAO Tooling",
"secondary_categories": "Accounting, Payments",

Hello, can we make the primary "Payments" and secondary all others?
Thanks!

Let's do it! cc @germartinez can we proceed with a review?


component(dashboard): initialize images at startup, remove devflags logging setup

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (initialize_api@59edbbf). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

...atasciencecluster/datasciencecluster_controller.go
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                Coverage Diff                @@
##             initialize_api      #17   +/-   ##
=================================================
  Coverage                  ?   20.02%
=================================================
  Files                     ?       32
  Lines                     ?     3430
  Branches                  ?        0
=================================================
  Hits                      ?      687
  Misses                    ?     2676
  Partials                  ?       67

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Modular Watcher

Summary
Extract out the current gitops watching logic out to be shared by both controller and agent. This also includes the logic to watching control repo.
Use Cases
A dedicated watcher for changes in repos

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@xdevxy @juliev0
I reviewed the code in syncer.go and found that we have four scenarios:

Monitoring Changes: Detecting changes in the Git repository that need to be reflected in the Kubernetes cluster, utilizing the StartWatching, StopWatching, Contains, and Length functions.
Scheduling: Deciding when to check for updates and potentially queue them for processing, using the StartFunction.
Dispatching: Distributing tasks to worker processes or threads based on detected changes, using the run function.
Applying Changes: Actually applying the changes to the Kubernetes cluster, using the runOnce function.

What I think is that the Monitoring, Scheduling, and Dispatching logic form parts of the Watcher Logic, so I should decouple them and make them easily pluggable with other code. Please share your views on this.

Hey @shubhamdixit863. I did want to clarify some things. I just realized this Issue mentions the Agent too. The Agent code already has a skeleton. For the Agent there is just a single Git definition defined in the ConfigMap which is evaluated (it could be templated) and then periodically fetches/syncs here. You probably can focus more on the Modular Watcher in the Controller than this, as this is something that will be done later. I think the main thing for this will be that we will ultimately need to have the ability to do cloning/fetching type code without needing to pass in a GitSync into the functions...so making some of those functions more generic perhaps.
That is what Agent has in common with the Modular Watcher for Controller. The Modular Watcher is basically a set of repository paths that need to be defined in the ConfigMap that we watch. (Or maybe for simplicity should it only be one @xdevxy ?) Also, it will I suppose only consist of GitSyncs, so theoretically it could only use raw type, if it makes things easier (or if you want to reuse the existing functionality maybe it's easier for it to follow the same model as our GitSync RepositoryPaths and allow all).
So, regarding your findings above, I actually think it could be a lot simpler than this, since we will either have just one path that we watch or a small handful. (Of course, we'd still need to account for ConfigMap changes.)
Let me know if you disagree with any of this @xdevxy. Thanks!

Overall modular watcher requires the following functionalities:

watch the specified repo path with a target revision, check there is any new changes.
if yes then apply the latest change.

These logic already exist in the syncer along with the git operations in git/util. We want to make it modular so the code can be shared/used by both watch control repo and the users repo (referred by gitsync).
On top of that, how the repo path with a target revision is specified are different.

For watching users repo, that information are defined in the GitSync spec.
while For watching the control repo, as what @juliev0 mentioned above, that information are defined in the ConfigMap. And we need to account for any ConfigMap changes.


Iterate - support for discovering iterable param in config

The current, iterate generates multiple configs and then runs each as a protocol. Given this local view of a config inside a protocol, I was not sure how I would access the global config elements or data.
Use Case: In order to log performance across query instances and sessions of IQR, additional ability to create UUID based on configuration parameters are required for relating results back to config params that resulted in them. Some notion of what is being iterated at a higher level lets us generate UUID based on params or their dynamic values.
A simple example of what needs to be supported would be:
negative: 5  # Number of negative adjudications
positive: # Number of positive adjudications
    iterate: [5, 10, 15]

should return data in some format that would indicate that positive is being iterated through and the current value of positive is either 5, 10, or 15.
Although I believe getting the value of the field using  iterate is straightforward, I am not sure how I would know what field is being iterated globally.
I do not have a clear path or idea about what needs to be done for achieving the above goal, as I am not familiar with how iterate percolates through the tinker-engine, but I have a use case that requires this functionality.

Based on an offline discussion, there are 2 features that would be really helpful

[ ] Adding a log entry when config is provided to run_protocol that would add the config generated iterate to the log.
[ ] Create a working directory and save all the configs to the working directory. This is much more involved and might require an rfc for discussion.

After various discussions, it seems like to solve this issue, it will be sufficient to solve a different issue instead: that of collecting multirun outputs in a directory tree, with recorded, instantiated configurations along with log files, etc.


commit build and add ignore

Had to modify current master to get a clean build, also added .gitignore to ignore vs object path files.

wrong bits got into this PR, closing as extraneous


Develop

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

56 of 57 (98.25%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.1%) to 60.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

catalyst_utils/templatetags/vite.py
38
39
97.44%

Totals

Change from base Build<PHONE_NUMBER>:
2.1%

Covered Lines:
657

Relevant Lines:
1095

💛  - Coveralls


net8.0-windows: Most transitive dependencies are not included in paket.lock

Description
When using framework: net8.0-windows, some transitive dependencies are not included in paket.lock.
This also means paket show-installed-packages --all won't show transitive packages.
Reproducible with paket 8.0.3 and 8.1.0-alpha004.
Repro steps
Using the following paket.dependencies file:
framework: net8.0-windows

source https://api.nuget.org/v3/index.json

nuget Newtonsoft.Json.Bson

will result in following paket.lock file:
RESTRICTION: == net8.0-windows7.0
NUGET
  remote: https://api.nuget.org/v3/index.json
    Newtonsoft.Json.Bson (1.0.2)

Compare this to e.g. net6.0-windows (expected behavior):
RESTRICTION: == net6.0-windows7.0
NUGET
  remote: https://api.nuget.org/v3/index.json
    Newtonsoft.Json (13.0.3)
    Newtonsoft.Json.Bson (1.0.2)
      Newtonsoft.Json (>= 12.0.1)

Known workarounds
Using net8.0 instead of net8.0-windows works as expected, but it obviously includes other packages needed for other platforms.
net8.0-windows10.0.17763.0 works as expected.
Some transitive dependencies are, rarely, included.

Probably related to DotNet8WindowsVersions not having generic V10 (and possibly V7 and V8` since these are not officially supported but work most time nevertheless).

This is still and issue with Paket 9.0.2


Make it easy for submitter to take back an already submitted proposal for edits

Currently, it is not possible for the submitter to undo submit in order to edit it.
Adding "Return for clarification" does exactly this.
from discussion with @maccraymer

(This issue belongs to RegistryKit repository.)

As @maccraymer raised, the usage of "return for clarification" phrase can be easily misinterpreted, because ISO 19127 (the standard for the ISO GR) utilizes the term "clarification" from ISO 19135, where it means "minor change in a register item".

Currently, the ability to withdraw proposal at any time (which I think is required per current 19135 draft) means submitter can withdraw proposal even while control body is actively looking at it; moreover, it means submitter can choose to withdraw at the same moment as control body chooses to accept.

I think it is fair for the submitter to retract a proposal since the submitter submitted it. I don't think there is a race condition since our process is an atomic one.

Now, we can assume withdrawal would be very rare, because withdrawal is final and has the vibe of a nuclear option. You’d have to create and submit a new proposal, which is somewhat of a barrier.

I think this stigma should be removed. Withdrawal isn't a nuclear option. It could be a "retry" as well. We can provide the ability to "clone" a proposal to make a new one.

I personally find it reasonable that submitting a proposal means relinquishing control over its future to register manager and control body; with withdrawal as exceptional escape hatch.

I agree. It would be much easier to "reject", then the submitter can "clone" the proposal, edit it and re-submit it.

As @maccraymer raised, the usage of "return for clarification" phrase can be easily misinterpreted, because ISO 19127 (the standard for the ISO GR) utilizes the term "clarification" from ISO 19135, where it means "minor change in a register item".

This issue, created based on the Monday meeting, is about an idea for a new transition that did not exist in Java backend.
Perhaps we should file a separate issue if we want to rename a transition already implemented in Java backend (note that it would mean that transition name would be different from the same transition in Java backend).

I think it is fair for the submitter to retract a proposal since the submitter submitted it. I don't think there is a race condition since our process is an atomic one.

It is a race condition: two people can press a button but the results are mutually exclusive. Only one person gets the desired effect.

I think this stigma should be removed.

I don’t think there’s a stigma, only respect for register manager’s/control body’s time. It’s nuclear because that would mean any review effort was for nothing.

I agree. It would be much easier to "reject", then the submitter can "clone" the proposal, edit it and re-submit it.

I think this is mutually exclusive with the idea proposed in this issue. Should we provide a function to “take back for changes” (whatever we call it), or a function to clone a proposal? (I personally like the latter—it would be similar to the clone functionality for register items, in a way, too—but I wonder what Mike thinks…)

It is a race condition in this sense: two people can press a button, but results are mutually exclusive. Only one person gets the desired effect.

This is actually what "Atomic" means -- the data will not be in a broken / in-between / inconsistent states. Only one person gets the desired effect and the other action fails. This is exactly what we want. A "race condition" is used to describe conditions where both users do not get what they want.
@maccraymer said:

Do not use "clarification" as the name for this action.

@strogonoff said:

This issue, created based on latest Monday meeting, is about an idea for a new transition that did not exist in Java backend.

There seems to be some conflict here? We don't need to discuss the Java implementation here and we are not going to make any changes to it.
If this issue is to implement a "new function" that allows a "submitter to take back" a proposal, I would instead suggest to make these steps easy:

retracting a proposal
starting a proposal based on an old proposal
submitting a proposal

This is as easy as just "send back without rejecting", aka in GitHub PR terms "close the PR" instead of "merge", "reject" or "approve".

This is actually what "Atomic" means -- the data will not be in a broken / in-between / inconsistent states. Only one person gets the desired effect and the other action fails. This is exactly what we want. A "race condition" is used to describe conditions where both users do not get what they want.

From programming and data type perspective, you are correct, there is no race. It’s a race from user interface design and experience perspective. A good GUI would attempt to rule out such scenarios through, for example, locking. In our case one of the tradeoffs of DVCS is that locking is difficult unless we introduce a centralized server in the mix.

I would instead suggest to make these steps easy:

I’m OK with the idea of implementing a “clone proposal as a new draft” feature that could be used on withdrawn proposals instead of introducing a new “take back for changes” transition, though I wonder what Mike would think since the latter was his idea…

A good GUI would attempt to rule out such scenarios through, for example, locking. In our case one of the tradeoffs of DVCS is that locking is difficult unless we introduce a centralized server in the mix.

I think these days people are quite tolerant of these issues (i.e. "action failures") as long as they are given the option to retry (or refresh). People just quit an app and restart it.
To me the good GUI here would be allowing people not to lose their work.
Here the only two possibilities are:

Control body approved and submitter cannot retract proposal. Then the submitter has no immediate recourse anyway because it has been approved. What the submitter has to do is to submit a new proposal to "revert" those changes. But I imagine the submitter won't want to immediately send the "revert proposal proposal"?
Submitter retracted right before control body approved. If the submitter retracted, I think it is fair game that the control body accepts not to "approve" the retracted proposal. Again I don't think there is any immediate recourse for the control body. Can the control body ask the submitter to re-submit? Maybe offline.

Thoughts?

I'll try to explain how I view all this as one who has been extensively using the current registry system for the last 5 years. Warning: this is a rather long-winded post!
In practice, there is no "race", at least for the ISOGR. The Control Body (CB) works together with the submitter who is either the authoritative source (AS) for the proposals or somebody acting on their behalf. In addition to the CB, the AS obviously has to approve their own proposed content to ensure the ISOGR contains authoritative information. That is the ISOGR's reason for being and it is now being enshrined in the 19127 revision. The AS therefore plays a major role in the CB’s decisions. If the AS wants to withdraw their proposal (what you call retract), the CB must abide by that and allow the proposal to be withdrawn. So, in practice, there would never be a “race” between the CB and the submitter (AS) because they are working together and making decisions together. So I think this discussion is moot as far as the ISOGR is concerned.
And just to clarify for own benefit, we have been discussing different kinds of actions here. There are the actions or proposals defined in 19135 that relate to register items (i.e., clarification, supersession, retirement, invalidation, redaction?) and there are actions or processes relating to the submission/acceptance/rejection of the above proposals (i.e., submitter submission, submitter withdraw, submitter appeal of rejections, RM acceptance, RM return to submitter, RM rejection, CB acceptance, CB return to submitter, and CB rejection). The proposal actions are defined in the new 19135 (Clause 3 and elsewhere) while the process actions are defined in Clauses 10.1 & 11.3 and Figs 22 & 23.
I see "return to submitter" and "withdraw" of a proposal as two completely different process actions by different entities for different reasons. First, the submitter should not be able to revise any proposal that has been submitted and accepted by the RM but I think it's fine for them to be allowed to withdraw it at any time before CB acceptance. For the ISOGR, that would be done in consultation with the CB as stated above. Consequently, there would be no "race" between CB approval and Submitter withdraw as explained above. If withdraw after submission is not allowed, the CB (in consultation with the submitter) would simply "return to submitter" and the submitter would then have the option of withdrawing their proposal if they choose. It just requires the extra "return to submitter" step. Either way gives the same result. Perhaps not allowing withdraws after submission is a "cleaner" way of doing it in general, and the best way for registers where the CB and submitter are not collaborating closely (i.e., the submitters are not necessarily authoritative sources). So I am leaning to NOT allowing proposals to be withdrawn by the submitter after it has been submitted. The submitter needs to wait for the CB or RM to return it to the submitter. However, there should be a way for the submitter to request the RM or CB "return" the proposal.
I also see no problem with nuking (completely removing) any withdrawn proposals. It's really up to the submitter to decide if they want to do that. If they want to revise the proposal, they simply do not withdraw it and wait for the RM or CB to "return" it, in which case the submitter can then revise it. Note that in the current registry, I am frequently withdrawing proposal groups that have been imported via spreadsheet. I nuke the previously imported proposal and resubmit the revised spreadsheet as a new proposal. I don't need or want to revise the proposal in the GUI because the spreadsheet is easier and more efficient. If we don't import spreadsheets and use the GUI alone to prepare & revised proposals, then I agree; withdrawing proposals would likely be infrequently used, except for testing in, e.g., the staging registry. However, I'm not convinced the GUI can provide the same convenience and efficiency as the spreadsheet but I'm open to being proven wrong ;-)
-Mike


Bootstrap theme CSS CDN url is broken

Need to replace the CSS in the demos with an updated link so the popups will show.

Changing the URL to the following seems to fix this issue:
<!-- Bootstrap Bootswatch theme CSS - other themes available here: https://bootswatch.com -->
    <link rel="stylesheet" href="https://cdn.rawgit.com/thomaspark/bootswatch/master/dist/slate/bootstrap.min.css" />


Priority

Description
Priority list
Proposed solution
No response
Alternatives considered
No response
Do you want to create a pull request?
No

Will take it over. 🙂

What would be the correct category? date?

General for now

PR #83 submitted.