Add missing layout widgets

There are a number of basic layout widgets in flutter that we don't have.

[ ] LimitedBox: A widget that checks if incoming constraints are infinite, and constraints them.
[ ] FittedBox: A widget that fits a child within itself, in a number of ways (fill, fit, fillHeight, etc).
[ ] FractionallySizedBox: use a fraction of available space
[ ] AspectRatio: maintain an aspect ratio (this should report if it is passed tight constraints)
[ ] OverflowBox: allow a child to overflow
[ ] ConstrainedBox: impose arbitrary(?) constraints on child? I think this should probably be represented as Fn(BoxConstraints) -> BoxConstraints or something.

In any case: none of these are super-duper-urgent, but I think we would like to have all of them eventually.

[] Rotate: allows rotation of its child.

just a question, but how is drawing outside the window border being handled? would the OverflowBox clip the content on the edge of the window? or would it signal the window to grow somehow. If the later is chosen, will other widgets resize too? will the background be painted on the part of the window that wasn't there before.
If the OverflowBox would grow the window without resizing or painting the background on the new area, it might be nice to use it for dropdowns, since they might not fit withing the window.

Outside of the window or outside of the widget?
I do not expect us to support drawing outside of the window; for cases like drop-down menus, we will be creating new modal windows for the menu.


[Bug]: Authentication Fail loop - iPad Pro 2

Describe the bug
Following explicit guideline in README and this previous post - https://github.com/denolehov/obsidian-git/issues/305#issuecomment-1242979455
There seems to be an issue with authenticating via the command pallete/plugin settings. No matter what, creds are bad for the clone. In my troubleshooting I also created a brand new repo instead of using one that I have setup for my desktop sync, similar to the stresstest repo mentioned in README, but WAY smaller in size.
Relevant errors (if available)
No response
Steps to reproduce
Obsidian Git Version: 2.17.4
Obsidian for ipad OS Version: 1.4.3 (95)
Follow setup guides linked above and readme file. Start the clone command from command pallete, and progress through popups. 1. URL
2. root area
3. does not contain .obsidian
Auth failure pops up after initializing, and then new pop ups arrive asking for your creds. Enter them in, still failure. Stuck in this loop until you close the initialization and "aborted" pops up.
Expected Behavior
No response
Addition context
No response
Operating system
iOS
Installation Method
None
Plugin version
2.17.4

Did you create a personal access token with the correct rights and used that as a password?

hey @Vinzent03,
same exact problem here unfortunately.
I have generated a personal access token with the necessary rights and used it as a password. I have tried both with a fine grained token as well as a classic token.
I have tried with both existing vaults and fresh vaults multiple times.
If there's any more info I can provide please let me know.
Thank you
Obsidian Version
1.4.6 (105)
Plugin version
2.20.3
Device
iPhone Xs
Operating system
iOS 16.5

I figured it out... I was cloning into the wrong folder... I was using vault root, making a new folder and cloning into that did work fine. Not sure why an auth error comes up in that case but anyway, it's working 😋

Got same issue, it only worked with classic token for me

@jalberto Please ensure you are setting it up correctly, because I honestly doubt there is a issue specifically to fine grained access token, because the handling on the client should be the same as with classic tokens. https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token

I do not understand what's the issue either. I created 3 different fine-grained tokens from minimal requirements to all access, and none worked for me, then the classic one with the minimum permissions worked at first try.
The only difference is the expiration day, as in fine-grained is set to a specific date.
There is a small contradiction in the instructions compared to the issue where it was implemented, related to the username, as in the issue says to use __token__ as username, I tried both anyway, same result.
Thanks for your plugin, it is great


Plurals aren't working in my Next.js v10 project

I am trying to use plurals and they don't work at all.
I've tried to use useTranslate or Trans and they don't work basically with the _0, _one, _two, etc.
In my common .json file somewhere I have setup this:
{
 "postFile": {
 "comment_0": "{{count}} comentarios",
  "comment_one": "{{count}} comentario",
  "comment_two": "{{count}} comentarios",
  "comment_other": "{{count}} comentarios",
  }
}

Then in my code, i have this translate instruction:
<a>{t('common:postItem.comment', { count: comments })}</a>

This basically don't render properly my, all i see is:
common:postItem.comment

I've tried to use useTranslation and Trans methods and both fails. What I am doing wrong with plurals?

@meerita ok, looks an issue related to nested objects + plural form. Moving the comment at the first level works for you?
{
 "comment_0": "{{count}} comentarios",
 "comment_one": "{{count}} comentario",
 "comment_two": "{{count}} comentarios",
 "comment_other": "{{count}} comentarios",
}

@meerita ok, looks an issue related to nested objects + plural form. Moving the comment at the first level works for you?
{
 "comment_0": "{{count}} comentarios",
 "comment_one": "{{count}} comentario",
 "comment_two": "{{count}} comentarios",
 "comment_other": "{{count}} comentarios",
}

In Spanish there is only one plural form (_other)... The other plural forms are not applicable in Spanish:
_zero
_one (singular)
_two (dual)
_few (paucal)
_many (also used for fractions if they have a separate class)

The numbers _0, _12 is for the exact match! not for the plural form.

In Spanish there is only one plural form (_other)... The other plural forms are not applicable in Spanish:
_zero
_one (singular)
_two (dual)
_few (paucal)
_many (also used for fractions if they have a separate class)

The numbers _0, _12 is for the exact match! not for the plural form.

How I interpret the plurals cases:
_zero // 0 comentarios
_one (singular) // 1 comentario
_two (dual) // 2 comentarios
_few (paucal) // unos pocos comentarios

So for my code, I only need 3 cases:
{
"comment_0": "{{count}} comentarios",
"comment_one": "{{count}} comentario",
"comment_other": "{{count}} comentarios",
}

How I interpret the plurals cases:
_zero // 0 comentarios
_one (singular) // 1 comentario
_two (dual) // 2 comentarios
_few (paucal) // unos pocos comentarios

So for my code, I only need 3 cases:
{
"comment_0": "{{count}} comentarios",
"comment_one": "{{count}} comentario",
"comment_other": "{{count}} comentarios",
}

@meerita We are following the CLDR Specification, and you want this:
_0 // 0 comentarios
_1  // 1 comentario
_2  // 2 comentarios
_other // unos pocos comentarios
The only plural form here is _other (because Spanish only have 1 plural form), the other are exact matches.

@meerita We are following the CLDR Specification, and you want this:
_0 // 0 comentarios
_1  // 1 comentario
_2  // 2 comentarios
_other // unos pocos comentarios
The only plural form here is _other (because Spanish only have 1 plural form), the other are exact matches.

Oh, great it worked!

Oh, great it worked!

Nice !👍  😊  I'll close the issue then! Feel free to report more issues if you have more troubles / dubts

Nice !👍  😊  I'll close the issue then! Feel free to report more issues if you have more troubles / dubts


Testing slowdown

Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Testing.20slowdown/near/417549488
Testing mathlib is currently significantly slower than before; it now takes about 4 minutes rather than 1.5 at most before #9828 was merged.

testing mathlib is back down under 1 minute in CI, so I'm closing.


[BUG] admiralty-header-menu-item admiraltychange event not working

The admiralty-header-menu-item admiraltychange event is not being triggered at all.
<admiralty-header alt="UK Hydrographic Office"
                  [ngClass]="(isAuthenticated | async) ? '' : 'header'"
                  [title]="header.title"
                  [logoImgUrl]="header.logoImgUrl"
                  [logoLinkUrl]="header.logoLinkUrl"
                  [logoAltText]="header.logoAltText"
                  [headerTitle]="header.title">
  <ng-container *ngFor="let item of headerItems">
    <admiralty-header-menu-item [hidden]="!(isAuthenticated | async)"
                                [menuTitle]="item.title"
                                (admiraltychange)="navigate(item.routerLink)"
                                [slot]="'items'"></admiralty-header-menu-item>
  </ng-container>
  <admiralty-header-profile [isSignedIn]="(isAuthenticated | async)"
                            (signOutClicked)="this.logout()"
                            [signedInText]="(fullname | async)"
                            [hidden]="!(isAuthenticated | async)"
                            aria-label="Sign in"
                            class="profile"
                            slot="profile"></admiralty-header-profile>

Try the code snippet with admiraltyChange rather than admiraltychange

We suspect that the event is actually called menuItemClick rather than admiraltyChange

Closing as no change required


serverTimestamp is undefined after upgrading from v10 to v11

[READ] Step 1: Are you in the right place?

For issues related to the code in this repository file a Github issue.
If the issue pertains to Cloud Firestore, read the instructions in the "Firestore issue"
template.
For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Operating System version: MacOS 12.4
Firebase SDK version: 11
Firebase Product: admin and functions (auth, database, storage, etc)
Node.js version: ^16
NPM version: ^8

[REQUIRED] Step 3: Describe the problem
Upgrading from v10 to v11 breaks admin.firestore.FieldValue.serverTimestamp(); functionality.
Steps to reproduce:
Run any set, add, update on collection, and include a timestamp on cloud function.
Downgrading back to v10 works.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
TypeError: Cannot read properties of undefined (reading 'serverTimestamp')
Relevant Code:
`collection('any').add({createdAt: admin.firestore.FieldValue.serverTimestamp()})`

I apologize if this was mentioned somewhere else or if there are migration steps in the changelog.

I get the same, all of admin.firestore.FieldValue is undefinded.

Importing like this seems to work: import { FieldValue } from 'firebase-admin/firestore';

Yes @lahirumaramba, this does seem to fix the issue.
Thank you!
Closing issue.

admin.firestore.FieldValue should not be called. There seems to be a discrepancy between default-namespace.js and default-namespace.d.ts.

I am having the same issue. Importing like this import { FieldValue } from 'firebase-admin/firestore'; works but it looks like a workaround instead of a solution.

A similar issue is discussed here https://github.com/firebase/firebase-admin-node/discussions/1959


HOTFIX: use atomic boolean for inject errors in streams eos integration test

Originally we assume the task will be created exactly three times (twice upon starting up, once for each thread, and then one more time when rebalancing upon the thread failure). However there is a likelihood that upon starting up more than one rebalance will be triggered, and hence the tasks will be initialized more than 3 times, i.e. there will be more than three hashcodes of the Transformer object, causing the errorInjected to never be taken and exception never thrown.
The current fix is to use an atomic boolean instead and let threads compete on compare-and-set to make sure exactly one thread will throw exception, and will only throw once.
Without this patch I can reproduce the issue on my local machine with a single core ever 3-5 times; with this patch I have been running successfully for 10+ runs.
Ping @mjsax @ijuma for reviews.

Also found another issue with the integration test as it is depending on the processed message count to indicate when to commit, but with the multiple-rebalance case some messages may have already been processed before the second rebalance to assign one partition to one thread. Changed to use the value itself to indicate commit, as values are guaranteed to be ordered.
The local runs pass for more than 30+ now.

I'll wait for the jenkins builds before merging.

OK, tests passed. Let's give this another go. Merging to trunk and 0.11.0.


How to define a start position in example_python.py

I'm beginning to run  CNNs on the frames and include it in example_python.py
How can I define a start position in Town01.
I can't find a way to make it start from location 112,110,38, for example.

Hi @Denis2054.
We currently do not support this feature right now (until next release).
You have a list of predefined spawn points. If you want to add a new one, you must add it from the Unreal Editor.

Hi,
OK. Thanks for your answer. No problem.
Best regards,
Denis
On Mon, Jul 16, 2018, 12:11 PM Marc Garcia Puig<EMAIL_ADDRESS>wrote:

Hi @Denis2054 https://github.com/Denis2054.
We currently do not support this feature right now (until next release).
You have a list of predefined spawn points. If you want to add a new one,
you must add it from the Unreal Editor.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/carla-simulator/carla/issues/587#issuecomment-405202416,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdYkVmDAX8a97z_6gbkyPsciFeGJ4spxks5uHGbFgaJpZM4VQxM0
.

--
Denis Rothman
https://www.packtpub.com/big-data-and-business-intelligence/artificial-intelligence-example
Artificial Intelligence expert, Author, Speaker
https://www.packtpub.com/big-data-and-business-intelligence/artificial-intelligence-example
Linkedin https://www.linkedin.com/in/denis-rothman-0b034043
Amazon Author Page https://www.amazon.com/Denis-Rothman/e/B07DFRCJG8
Packt https://www.packtpub.com/books/info/authors/denis-rothman
Publishing Author Page
https://www.packtpub.com/books/info/authors/denis-rothman

Regards :)


TechnicSolder Modpack showing as offline

im get the error where the Modpack is shown offline, and it shows

and also the API Link shows 401 error http://api.technicpack.net/modpack/wg-atlas

Hi,
What is the link of your Solder ? My modpack is in my Solder and TechnicPack return the same result,  so it's not probably a bug of TechnicPack API.

heres my Solder API link http://solder.windmillgaming.net/api

Have you at least one public build ? If you go to
http://solder.windmillgaming.net/api/modpack/wg-atlas you can see
recommended and latest build but empty list of builds. Try to set one build
to public and published.

its all public and published, even on the TechnicSolder it shows no builds

oh lol, didnt know you have to click Publish, it now shows, let me test :D

ok its Fixed :D

@xH3LLRAIZ3Rx Which page is the 'Publish' button on? I have this problem.

@Pyroglyph
You have to navigate to the modpack page, usually this is /modpack/view/MODPACKNUMBERHERE

You have to individually publish each build.

I have published both builds (1.1 and 1 are identical, 1.1 was just to see if creating a new build would help. It didn't.) and it still shows as offline.

@xH3LLRAIZ3Rx  It seems like your launcher isn't able to reach your modpack api correctly. Is your API returning a response similar to what was mentioned earlier in the conversation chain?

My /api/modpack/modpackname is in the exact same format as the one on the previously mentioned WindmillGaming api thing as it is right now (http://solder.windmillgaming.net/api/modpack/wg-atlas) <-- that one isn't mine because my server is bugging out right now but it was working fine 5 mins ago when I was testing it.

@EntranceJew Well it seems my modpack works now. Time heals all I suppose. However, it struggles to download one mod which I'm really confused about (I can download it fine from the direct link it supplies me in the error message so I don't see what the problem is). I've removed it from the pack so now I have to wait another half an hour or something so for Technic to update it's packs.

If I had to guess, either the mod was packed incorrectly or the file is too big to download before timing out through the technic client. I'd take it up with the peeps in the technic irc. I'm glad things are working out! :+1:

@EntranceJew Oh, and it was going so well. I removed the mod from the pack and it manages to finish downloading the rest of the mods. Installing takes unusually long but when it reaches 100% the Play button does not appear. It is still the Install button. Clicking it just downloads and installs the mods again. Could it be that Forge might not be installed? I don't ever remeber configuring a Forge version.

@EntranceJew Out of pure luck I think I found the problem. I went to .techinc/modpacks/solar-survival and what do I find? Every single mod extracted into .technic/modpacks/solar-survival assets, classes and all. I fail to see how this is even useful and why Technic made Solder this way. I'm going to re-read some docs and hopefully try and fix this mess.

Well, the mods are supposed to be extracted there, from the zips in a way that matches how you would install them on a client -- pay careful attention to the part that says the forge universal launcher must be installed as a mod in the modpack under a special directory otherwise you won't actually be able to launch the game.

@EntranceJew I'm trying to write a batch script to convert all my incorrect mods to the solder format (foreach zip, rename it to jar, make a mods folder for it and put it inside, then make a zip with its name and put the mods folder in that zip, then delete the original mods folder with the jar to save space) but it's really difficult.

if you want, there is an auto zipper bat file that works with 7 zip that might help you out if you want it: https://gist.github.com/Drethic/5ac899e7c45545067832

You may be a little too late because I wrote my own batch script to do it for me XD


Add option to select zsh in 'exec command shell'

Expected behavior
Ability to select Zsh from select box.
Actual behavior
Zsh isn't present.
Information about the Issue
N/A
Steps to reproduce the behavior

Click select box for shells.
Feel disappointment.

@ssx Could you provide me with a couple container image examples that have zsh?

Hi @FrenchBen!
That's a very good question.
It would have been most useful when using 'Docker CLI' feature, I'll have a look and see if there any containers, I can build one if not.

@ssx the point of this question is that providing you with a zsh option to use within a container, when no image have zsh baked in is a bit pointless.

That's quite a valid point!


Incompatibility with JS-Controller 3.3.8

Since updating to JS-Controller 3.3.8 (3.3.9 got the same effect) I got massive log entries for the wrong object type at the water box point. I already deleted the instances and adapter completely, but no changes at all.

Version? Should be fixed in latest..

Version? Should be fixed in latest..

3.1.7

please delete and reinstall


function ds_tree_build_node_value missing from current build

Variable <unknown_object>.ds_tree_build_node_value(100037, -2147483648) not set before reading it.
at gml_Script_timer_create (line 49) - 	var _timerNode = ds_tree_build_node_value(				 "TIME_START", _timeStart,
############################################################################################
gml_Script_timer_create (line 49)
gml_Object_oProj__Create_0 (line 3) - projectile_timer_lifespan = timer_create(3, time_start.s, false);
gml_Object_oProj_Rocket_MLRS_Create_0 (line 1)
gml_Object_oCursor_Step_0 (line 247)

also missing function is_even

also missing function normalize

Some heckin uwu beans told me it was problematic to normalize values so i left the function out. Closed as wontfix

Necessary functions are all either removed or (when necessary) included as utilities now

fixed as of 0.2.5. closed as WILLFIX


fluentd pod hogging memory after spike in traffic

I deployed and app that output logs in a rapid pace (10s of message per second) and the fluentd pod memory consumption increased. Makes sense, but after I killed the app that was spamming logs, the memory consumption stays high. Seems like some messages just stay in memory.
I have also encountered this in the logs:
2016-12-14T14:03:29.277996730Z 2016-12-14 14:03:29 +0000 [warn]: emit transaction failed: error_class=NoMethodError error="undefined method `[]' for nil:NilClass" tag="kubernetes.var.log.containers.folksy-vacation-web-3441316637-w3jqs_folksy-vacation_POD-6998fb92734c2116c49ecff689f6314b7581c6931caf24717e90c0c8fc3da505.log"
2016-12-14T14:03:29.278460840Z   2016-12-14 14:03:29 +0000 [warn]: suppressed same stacktrace

So the undefined method []' for nil:NilClass` error from fluentd is a well-known unidentified upstream bug: https://github.com/fluent/fluentd/issues/1248
As for the memory consumption increase, given that fluentd and nsq needs to process all messages I'd imagine that'd stay under high memory consumption until the messages have been processed. Is there some form of enhancement you'd like to see from that?

The memory consumption did not go down one bit even after a day after the spike.
I think that when the undefined method error occurs, the object is not removed from memory but that is just a guess.
Would it be possible to predict a memory limit for the fluentd pod? Perhaps set a sane default in the chart?

they are commented out by default for clusters that want to run the monitoring stack with unlimited resources, but it is there.

Got it.
Pretty sure this is a bug in fluentd but I do not feel like debugging Ruby code that might have a bug under high load 😄
Thanks for the suggestions!


Mod Conflict

Forge Version: Forge-<IP_ADDRESS>39
Only Mods Installed
Custom Main Menu: CustomMainMenu-MC1.12.2-2.0.8
Resource Loader: ResourceLoader-MC1.12.1-1.5.3
Chance Cubes: ChanceCubes-1.12.2-<IP_ADDRESS>
If Chance Cubes is on Version ChanceCubes-1.12.2-<IP_ADDRESS> everything works fine on the 227 version the textures are replaced with Minecrafts unknown texture.
Not sure if issue is with them or you thought id report here.

Can confirm this is an issue, having the same problem

chance cubes has a known bug causing resource packs not to work, use previous version 224
https://github.com/Turkey2349/ChanceCubes/issues/137

This is an issue on my end (Chance Cubes), but it would help to have a chat about your mod and how it loads in resources so that I can make a proper fix that doesn't conflict with this mod.

This issue seems to have been resolved. Let me know if any further conflicts occur.


management-gateway

Hi Team,
Any reference documentation or README on management gateway?

What are you looking for? An ApiGateway, or a way to exchange data between Frank!Instances?

The Frank!Gateway is a separate project, this 'gateway' is for applications to communicate with each other.


Add annotations to combine ApisixPluginConfig with k8s ingress resource

Type of change:

[ ] Bugfix
[x] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

feat: #799
Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you added corresponding test cases?
[x] Have you modified the corresponding document?
[x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1139 (f5535ee) into master (4d172a0) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   30.38%   30.23%   -0.16%
==========================================
  Files          81       81
  Lines        9409     9388      -21
==========================================
- Hits         2859     2838      -21
  Misses       6235     6235
  Partials      315      315

Impacted Files
Coverage Δ

pkg/kube/translation/ingress.go
66.66% <100.00%> (-2.00%)
:arrow_down:

pkg/config/config.go
66.34% <0.00%> (ø)

pkg/apisix/upstream.go
39.73% <0.00%> (ø)

pkg/apisix/pluginconfig.go
37.33% <0.00%> (ø)

pkg/ingress/apisix_route.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d172a0...f5535ee. Read the comment docs.

Official website document Direct access to this address is abnormal

https://apisix.apache.org/docs/apisix/plugins/echo/

apisix.apache.org redirected you too many times.

re-run lint-checker-ci job.
The official website may be temporarily unavailable


Integrity attribute on link-tag is empty

As can be seen on the demo site the integrity attribute of the link tag (of the style sheet) remains empty.

I think this is not an issue.

It works fine without the integrity value, but it would be better if it was set (otherwise the attribute itself could be left off). I'll look into it later this week.

This issue has been fixed


python311Packages.ffcv: fix tests

Description of changes
Fixes python3Packages.ffcv tests by changing the directory in precheck.
ffcv was removed from python312Packages because it does not successfully build due to a dependency on distutils. Looks like they have a version 1.1.0 branch in the works that removes that but it has not been released yet.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/packaging-a-python-library-with-c-distutils-extension/17732/5

Result of nixpkgs-review pr 322042 run on x86_64-linux 1

2 packages built:

python311Packages.ffcv
python311Packages.ffcv.dist

@samuela @SomeoneSerge Thanks for the reviews and feedback. I have made changes or responded to your comments if the changes were not possible. I've left some of the comments unresolved so you can see what I did and make sure it is satisfactory.

Result of nixpkgs-review pr 322042 run on x86_64-linux 1

2 packages built:

python311Packages.ffcv
python311Packages.ffcv.dist

@samuela @SomeoneSerge all comments addressed

Ah, I guess it's the commit names that ofborg looks at, not PR name; @djacu could you please update the commit message as per https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions?

@SomeoneSerge TIL. I thought it was the PR title as well.
I didn't see explicit guidance in that doc but it links to other documents about how the commit message should look. Like this one -> https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions
I think I changed it to something that will trigger ofborg.
Also, we should be able to trigger it manually but I agree that getting the commit message consistent with the contributing guide would be best. https://github.com/NixOS/ofborg?tab=readme-ov-file#build

For python packages it ofborg does want the minor version of the package set specified too (python311Packages.ffcv), which I only recently discovered. But this is now good enough for merging
@ofborg build python3Packages.ffcv

Hmm the guide is not clear what to do in cases other than init or version bumps. Is the init example a very specific example of a more generic capability? For example, the guide says for initial commits to write the commit message as <package>: init at <version>, but is a more generic message like <package>: <action> at <version> possible? So writing python3Packages.ffcv: bugfixes at 1.0.0 or python3Packages.ffcv: fix tests at 1.0.0 are valid?

Result of nixpkgs-review pr 322042 run on x86_64-linux 1

2 packages built:

python311Packages.ffcv
python311Packages.ffcv.dist

Looks like the aarch64-darwin build on master has the same issue.
https://hydra.nixos.org/build/264481981
And x86-darwin has it's own issues.
https://hydra.nixos.org/build/264482265
I'm wondering how/why the darwin builds run the tests when the linux builds don't.
https://hydra.nixos.org/build/263558079/log
https://hydra.nixos.org/build/264482315/log


Generic UDP action option

Added a generic UDP option to action list. Based on the existing TCP action and the TSL UDP action.

Hi @videojedi,
thanks for your work. Unfortunately, the master branch is quite outdated as we did an (almost) complete rewrite in TypeScript in #204. We'll merge this soon.
Then, your PR will have huge merge conflicts or if we merge it beforehand, all your changes will be overwritten.
This means that once #204 is merged, please create a new PR. If you don't know TypeScript, I can help with that.
Sorry for this, but with the TypeScript rewrite it will be way easier to contribute and mainly troubleshoot issues because now each source, action or whatever it will be is now contained in its own class.

Closing this, since I added UDP support in #242 (adding @videojedi as co-author).


Is HKPK a good support data suggestion?

I met this project when I reach HTTP2
Then I tried with HKPK, a security technology in browsers to increase SSL certificate reliability. You have more information here
I am wondering if this kind of technologies are out of the scope of this project or HKPK is a good item to add. I am not sure if I could add with good sources all the compatibility list. From here I get

HPKP is supported by Mozilla Firefox since version 35, Google Chrome since version 46, and Opera since version 33 (as it is based on Chromium 46). Internet Explorer, Edge and Safari at the time of writing, do not support public key pinning. For Edge, the feature is under consideration.

and from here I can get also information.
I would like to know if HKPK is a good support data suggestion or not. Would it?

Isnt this feature called HPKP and thus already covered by http://caniuse.com/#feat=publickeypinning?

Yes, it is the same.
Thanks @Schweinepriester


Update Frequency

Hi,
very interesting data. thank you!
do you have a schedule planned for updates?

Hello Everyone,
Yes, some clarity whether it's a live data set would be highly appreciated. Was definitely a good start bank in the day. Should we continue hoping for an update?
K


feat(io-engine): printing configuration on io-engine startup

Signed-off-by: Dmitry Savitskiy<EMAIL_ADDRESS>

Will there be another PR to print command line arguments?

bors merge


Can we add it as module to an existing project?

Can we add this as module in normal Nuxt project that has already setup content?

It is made to be used with the extends feature actually.
But you can configure the content key in your nuxt.config, no need to add @nuxt/content to the modules key since this theme add it.
Do you have an example of what you want to achieve?

For example in Vitesse starter for Nuxt 3
https://stackblitz.com/github/antfu/vitesse-nuxt3

It is possible, but the risk here with vitesse-nuxt3 is that it uses another UI library (UnoCSS) where this template leverages TailwindCSS

@boussadjra
It's really troublesome, but I like UnoCss very much, so I made one according to this repository
https://github.com/elonehoo/content-unocss

Beautiful @elonehoo !
One thing, I updated content-wind to use .demo/ to have content/, public/ and app.config.ts inside.
I suggest doing the same 😊
https://github.com/Atinux/content-wind/tree/main/.demo


Adds screenshot tutorial

Using Camera FinalDrawCallBack mechanism
Now can take screenshot using glReadPixel, freeing the need for
preserveDrawingBuffer performance impacts
And do other operation (texture copy or oth) on each camera final draw

Depends on https://github.com/sketchfab/workflow-helpers/pull/2


Free Go certification course

I would like to add a Go course with certification.

Pull request #240 has been submitted for this issue. Please accept the PR under the Hacktoberfest2022 label.

@avinash201199 the PR #240 has been updated


(PUP-6551) Pin json_pure to ~> 1.8

Hiera has an unbound dependency on json_pure. json_pure 2.0.2+
explicitly requires Ruby >= 2.0, though support was dropped for
Ruby 1.9 in json_pure 2.0.0 (though mistakently the Gemfile was
not updated).
Pin json_pure to a 1.8 series release everywhere.
Without this commit, bundler will pick json_pure 2.0.2 and then
fail to bundle install on Ruby 1.x.

Thanks @Iristyle; this is what I was thinking.
But, do you know what's up with the appveyor fail?

Looks unrelated based on not creating a user?

I rekicked the appveyor build -
Lots of these messages:
An error occurred in an after hook
  Puppet::Util::Windows::Error: Failed to convert string SID: S-1-5-:  The security ID str
  occurred at C:/projects/puppet/lib/puppet/util/windows/sid.rb:106:in `block (2 levels) in string_to_sid_ptr'
F

This requires #5153 to be merged first, to gem pin win32-* gems that are causing us problems (covered in PUP-6445).

CLA signed by all contributors.


add rds_apply_immediately variable

Adds rds_apply_immediately to allow the upgrade from single to multi-AZ RDS databases to occur during a deployment, rather than waiting for a maintenance window. We currently don't configure maintenance windows in the TF stack, so the previous behaviour may catch users by surprise.

Confirmed working in an internal deployment, the application continued to function as normal during the multi-AZ upgrade.


Setting NODE_ENV to test has unintended side effects

In 3a38ddf64289a19c3a176c8c0a4e89c03314a85e, code was added to default the NODE_ENV variable to test if one is not set (see the CHANGELOG entry). The rationale given was twofold: to be able to specify the Jest preset in Babel config based on the env, and to follow a convention used in Relay.
The former is no longer specified in this way, and the latter is now specified explicitly by Relay so there's no dependency on Jest setting the default.
This came up in #1654 where Babel config for development was not read because Jest would change the environment away from the default — the workaround was to more clearly document this behavior in 968ca388e34f0e3c5ee0b824b4b4696a0d6d0473 and b1e7af2f425853e590b0f8352978f529103cc68a.
I believe that library code like Jest changing NODE_ENV (or indeed, any shared environment variables) is an anti-pattern and leads to unexpected behavior, like the Babel issue raised above. Essentially, it's modifying a global variable — see this great explanation on why doing so is considered harmful. If any other libraries are being used that check the value of NODE_ENV, their behavior could change simply by adding Jest — a strong violation of module-based encapsulation.
At this point, there seems to be no requirement that it be defaulted in this manner, given that other NODE_ENV values can be explicitly set and Jest is expected to continue working properly.
If an environment-type value needs to be explicitly set, and to be set to test if nothing else is provided, that should be set in a value local to Jest and not global to the environment — see, for example, this simple env variable in express-js.
I'm happy to create a PR to remove the modifying-NODE_ENV behavior, but I wanted to check that there isn't something intentional or required about this behavior first or if there are strong opinions from the maintainers that they want to keep it this way.

Hi folks, any thoughts on this?

+1, user shouldn't be forced to pick ENV for tests

This is a breaking change but I'm not opposed to it.

Maybe there could be flag introduced, like: --no-env so we don't break the compatibility.
Right now you could do:
NODE_ENV= jest

but it doesn't look right to the person that don't know about this issue

Also if we decide to make this change, we should introduce some new env variable that will indicate file is  running in Jest. Something like NODE_JEST=1.

So is there a way currently to stop Jest from setting the NODE_ENV environment variable?

From react index.js:
if (process.env.NODE_ENV === 'production') {
  module.exports = require('./cjs/react.production.min.js');
} else {
  module.exports = require('./cjs/react.development.js');
}

This means that the jest enc variable will prevent react from loading in a minified version. This might actually add a performance penalty during testing.

You're free to set it to whatever you want. Jest only sets it to test if it's not set to something already

Jest only sets it to test if it's not set to something already
This is true if it is set as an OS variable. If you are setting it in .env file it is still being overwritten by jest.

You're free to set it to whatever you want. Jest only sets it to test if it's not set to something already

Does setting it to be a different value affect Jest in some way? If not, why does Jest do this at all?

Answering my own question, from a quick scan of the code, this looks like the only reference to it, outside of a mention in the configuration docs:
https://github.com/facebook/jest/blob/b7cb5221bb06b6fe63c1a5e725ddbc1aaa82d306/packages/jest-haste-map/src/index.ts#L372

It makes e.g. process.env.NODE_ENV === 'production' checks be false, and babel config to pick up env: { test: { config } }. Idk about .env files - we check process.env - if it's not there it's not set for the node process, which is what we check

You're free to set it to whatever you want. Jest only sets it to test if it's not set to something already

Having NODE_ENV not set is IMO semantically different from not caring if it's set to test! Yes, setting values explicitly might be a good idea, but I don't think that out of all things it should be your testing framework to (forcefully) teach you that lesson.

Workaround:
node -r ts-node/register -r ./src/__tests__/setup.ts ./node_modules/jest/bin/jest.js --config \"./jest.config.js\" --testMatch \"<rootDir>/src/**/__tests__/*.integration.spec.ts\" --silent --verbose

Instead of using jest CLI, use Node and inject your own script which defaults process.env.NODE_ENV to what you want.
You could even do jest-only environment stuff here since you could discern the result of NODE_ENV.
process.env.NODE_ENV = process.env.NODE_ENV ?? 'dev';

// set by jest
if (process.env.NODE_ENV === 'test') {
  require('@rbi-ctg/mocks/logger');
}

Somewhat related to this.
I spent quite a while trying to track down errors like this on a couple of projects:
/Users/ggp/dev/git/new-app/jest.setup.js:5
    import "@testing-library/jest-dom/extend-expect";
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

It turned out that this was caused by having NODE_ENV=development set globally.  Unsetting it or setting it to test caused things to work as expected.  I might expect NODE_ENV to effect how things are compiled, optimization changes etc. for instance, but I honestly never expected that it might change if things could be compiled.

Somewhat related to this.
I spent quite a while trying to track down errors like this on a couple of projects:
/Users/ggp/dev/git/new-app/jest.setup.js:5
    import "@testing-library/jest-dom/extend-expect";
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

It turned out that this was caused by having NODE_ENV=development set globally. Unsetting it or setting it to test caused things to work as expected. I might expect NODE_ENV to effect how things are compiled, optimization changes etc. for instance, but I honestly never expected that it might change if things could be compiled.
edit to add: this was with Jest 25.4.0 and 26.1.0

Had the same issue today. NODE_ENV=development is my default setting for development, to (de-) activate some optimizations. Im my opinion it feels weird if Jest just stops working in that case :/

You're free to set it to whatever you want. Jest only sets it to test if it's not set to something already

Usually developers don't have NODE_ENV set anywhere in the system, because it's better to have that handled by dotenv within the project in question. The trick with this is that dotenv doesn't overwrite values for anything that's already set, so it leads you to NODE_ENV = test all the time. In my case I have this Jiu Jitsu using cross-env all the time in order to set NODE_ENV before Jest...so it would be really nice to not set it to anything or have a setting to bypass it.

For those using dotenv and wanting to have .env override variables which were set before (like jest's NODE_ENV=test):
dotenv.config({
  // We set override to true to make .env override variables already set (like NODE_ENV which jest sets it to test if it's not already defined)
  override: true,
});

Stumbled on this today trying to figure out how to make tests for the first time and honestly, though the feature is not without its merits, I feel like it causes more issues than intended.
If not removing the feature or adding an option to opt out of NODE_ENV being set to "test" by default, at least a more descriptive entry on the "Environment Variables" documentation stating that the "if its not set already" part doesn't apply to dotenv would be nice.

Text me<PHONE_NUMBER>
On Fri, May 13, 2022, 10:54 PM Andres Aldape @.***>
wrote:

Stumbled on this today trying to figure out how to make tests for the
first time and honestly, though the feature is not without its merits, I
feel like it causes more issues than intended.
If not removing the feature or adding an option to opt out of NODE_ENV
being set to "test" by default, at least a more descriptive entry on the
"Environment Variables" documentation stating that the "if its not set
already" part doesn't apply to dotenv would be nice.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/jest/issues/3370#issuecomment-1126630776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXSL3Z5MJIXMLMX65G3LPLLVJ4PVZANCNFSM4DJBNXCA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Immutable list for Sanctuary

Hi all,
I've been working on a fast immutable list for JavaScript with a functional API. The library is designed to be used together with other functional libraries and replace the usage of arrays. Currently, the
library includes a wrapper that makes the it work seamlessly with Ramda. I would like to do something similar for Sanctuary. I've opened this issue to hear if there's any interest in that and get feedback on how best to do it.
The two primary reasons for using List together with Sanctuary would be:

Safety. JavaScript arrays are inherently mutable. When using arrays in functional code the only thing that prevents us from mutating them is our own self-discipline. In my experience, this is sometimes not good enough and can be a source of bugs, especially on teams. Immutable data structures, on the other hand, guarantees that mutations don't happen.

Performance. Immutable data structures can give better performance. For instance, S.init on arrays take O(n) time, L.init on List takes constant time. S.concat on arrays takes O(n + m) time but L.concat on List takes O(log(n)) time. Furthermore, List has been carefully optimized such that the constants are also low.

To make List work smoothly with Sanctuary I think the following could be done in a Sanctuary specific export:

Export all List function wrapped with sanctuary-def. This would give Sanctuary currying and run-time type checking.
All List functions that can return undefined (at, head, etc.) should instead return a Sanctuary Maybe.
Maybe provide Sanctuary aliases. For instance, List has includes which is elem in Sanctuary.

I'd love to hear what you all think about the idea and if there's any interest in this? Is there anything that could be done in addition to the above?

Creating something like this has been on my personal TODO list for a long time.  I'm glad that someone has actually done it.  It looks very nice, @paldepind!

@CrossEye Thank's a lot Scott. It's great to hear that you feel that way. Let me know how your experience is if/when you get a chance to try the library.

This is very exciting, Simon!

Export all List function wrapped with sanctuary-def. This would give Sanctuary currying and run-time type checking.

:thumbsup:

All List functions that can return undefined (at, head, etc.) should instead return a Sanctuary Maybe.

:thumbsup:

Maybe provide Sanctuary aliases. For instance, List has includes which is elem in Sanctuary.

S.elem operates on any Foldable, so the Sanctuary wrapper need not even expose a List-specific elem function.
One thing that would be interesting to consider is whether S.head and friends could be generalized to operate on List values as well as Array values. I believe you have given this matter some thought, Simon. Have you defined an interface which list-like structures can implement?

@davidchambers

This is very exciting, Simon!

😄

One thing that would be interesting to consider is whether S.head and friends could be generalized to operate on List values as well as Array values. I believe you have given this matter some thought, Simon. Have you defined an interface which list-like structures can implement?

One can implement head on any Foldable. But one probably doesn't want to do that as it will run in O(n) time even on data structures that support head in constant time.
Foldable has a bit of a dilemma. In theory, you can derive a lot of useful things from just foldr: elem, head, nth, length, find, indexOf, and much more. But in practice these functions will perform very poorly when derived from foldr\ foldl. For instance elem should stop iterating as soon as a match is found. But, S.elem wont do that so on average it will be twice as slow as it should be. For me personally that is a deal-breaker.
Haskell has a decent solution to the dilemma. Their Foldable type class includes a lot of derivable methods. Thanks to Haskell's support for default method implementations implementors of Foldable can optionally override these with performant versions for their data structure. Thus Haskell's Foldable can be used for additional things without being prohibitively expensive. This stands in contrast to the Foldable in Fantasy Land and Purescript (PureScript doesn't support default methods implementations so they can't use the Haskell solution) which is essentially only good for reduce/foldr/foldl.
Haskell's solution could be mimicked in JavaScript by defining a Foldable with a bunch of methods and then offering a mixin function that installs default method implementations. The problem is that how many methods to include in such a Foldable becomes arbitrary (there are methods that could've been included in Haskell's Foldable but which are not). A second downside is that it makes the Foldable definition a lot bulkier. I suspect that due to these issues proposing such a thing for Fantasy Land would be controversial. https://github.com/fantasyland/fantasy-land/pull/224 would have made it possible to define elem and more on Fantasy Land Filterables with acceptable performance. But the PR didn't gather much interest so I'm guessing that Fantasy Land users are fine with Filterable giving them only reduce. And maybe it's best that way.
By taking the same approach as what I've done for Ramda using List and Sanctuary together would mean that people would be able to do
import * as S from "sanctuary";
import * as L from "list/sanctuary";

And then rely on the fact that for every S.foo that operates on arrays there is a matching L.foo that operates on immutable lists. This has the advantages:

The API is immediately familiar
Moving code between lists and arrays is easy
It is explicit in the code if it is operating on immutable lists or plain arrays

IMO this is quite nice but the downside is, of course, that it isn't actualy polymorphism so one can't write code that works for both lists and arrays at the same time.

Your proposal sounds good to me, Simon.
How would you like to proceed? Would you like the project to live in the @funkia account, the @sanctuary-js account, or some other account? I don't mind. If it's to live in the @sanctuary-js account I would like it to be written in ES5 in accordance with the conventions adopted for other Sanctuary projects. ;)

Good question. I think there are a few options:

The code lives inside the current npm package and git repository
It gets a seperate npm package but still lives in the main list git repository
It gets its own npm package and git repository

Number 1 is what I've currently done for Ramda. There is a file for Ramda that users can import by doing require("list/ramda"). The benefit is that there only is a single npm package to manage. But there are some downsides as well so maybe that is not the best way to do it?
I'm thinking number 2 may be the best option. Having it in a single repository makes it easy to keep things in synchrony. For instance I have a test in place that ensures that the curried Ramda file has all the functions that the main file has. This ensures that I don't add a new function and forget to add it in the Ramda file.
What do you think?

It makes sense to me for the Sanctuary wrapper to be handled in the same way as the Ramda wrapper. The peer dependency ({"ramda": "*"}) concerns me. Shouldn't this be more specific to make it clear which particular version of the Ramda API the wrapper mirrors? Functions are occasionally renamed, as you know.

I'm thinking number 2 may be the best option.

I agree. Would you do the same for the Ramda wrapper, or do you see significant differences between the two wrappers which warrant different treatment?

The peer dependency ({"ramda": "*"}) concerns me. Shouldn't this be more specific to make it clear which particular version of the Ramda API the wrapper mirrors? Functions are occasionally renamed, as you know.

You're right, * isn't optimal. But, only equals and curry are used from Ramda and they're fairly stable I think. Would it be better to specify >=0.15.0? 0.15.0 is the version in which equals was added. That range doesn't have to change whenever a new Ramda version is released but on the other hand it assumes that equals and curry won't change.

Would you do the same for the Ramda wrapper, or do you see significant differences between the two wrappers which warrant different treatment?

I agree with you that it makes sense to do the same thing for both Ramda and Sanctuary.
I've looked at a tool call Lerna which looks like it would make it possible to manage option number 2 with very little overhead. The core list, the Ramda wrapper and the Sanctuary rapper would each live in a directory in the same repo. Lerna would make it easy to run tests for them all at once and to publish new package versions in sync.

I would like it to be written in ES5 in accordance with the conventions adopted for other Sanctuary projects. ;)

That is fine for me 😄 Are the conventions documented or should I just look at the existing code?

I was thinking of the peer dependency from the perspective of one of your users. You claim that the API of your wrapper matches that of Ramda, but you must qualify this claim. If R.contains becomes R.includes, for example, your API will need to change accordingly. If someone then uses the latest version of your library with an older version or Ramda, there will be a mismatch between L.includes and R.contains. You could provide an alias to handle this particular case, but making the wrapper mirror every version of Ramda at once seems fraught with difficulty. ;)

The core list, the Ramda wrapper and the Sanctuary rapper would each live in a directory in the same repo.

:thumbsup:

Are the conventions documented or should I just look at the existing code?

@sanctuary-js projects all use sanctuary-style, but since this project will live in the @funkia account it should follow Funkia conventions rather than Sanctuary conventions. :)

Would it be better to specify >=0.15.0?

I usually use >=minimum_feature_complete_version <next_major_version. So in your case >=0.15.0 <0.26.0. This gives you the chance to evaluate whether any breaking changes introduced in a major version release impact your library, before expanding the range to the next major version and publishing a patch.

@davidchambers You're right that there need to be some sort of documentation about which version of List goes with which version of Ramda. But I'm not sure if the peerDependency property is the right place to do it? I think of the peer dependency as saying "I need this version of this library in order to work". But in order to just work the List Ramda wrapper only needs curry and equals.
@Avaq Good suggestion! That's definitely better than my idea 😄

Thanks a lot for the feedback in this thread 😄  I'll probably start working on this in a week or so. I'll let you know when I've got something to share.

I've realized that I'd like to offer a curried variant of List that doesn't depend on Ramda for people who want currying but doesn't want the dependency on Ramda. I've then decided that it's not worth it to maintain two near-identical curried variants. Ramda users can easily use the dependency-free one.
Therefore the Ramda integration no longer has to be a separate package and then using Lerna doesn't seem like it's worth the additional complexity. I was, therefore, thinking that a separate sanctuary-list repository in @sanctuary-js  would be the best option. The approach also has the benefit that people can make contributions to list without having to know implement the sanctuary-list part as well (for instance if they implement a function that function should be included wrapped in a def in sanctuary-list).

Sounds good to me, Simon. I have created sanctuary-list and granted you write access. Please create a branch named paldepind/everything or similar and do your work there. Once you're ready to share your work you can open a pull request. I look forward to seeing it. :)

Is this still happening?
@paldepind

I have needed List a in various test suites, and have defined it in several places. I will add documentation, then make the code available on GitHub and npm. At a later point it should be possible to replace my straightforward implementation with @paldepind's efficient one. :)


NIFI-14041 - Improve MockPropertyValue and EL evaluation validation

Summary
NIFI-14041 - Improve MockPropertyValue and EL evaluation validation
While building a processor, I noticed that the test framework would throw an error if I'm in the below situation:

Processor with input forbidden
Property with EL support with Environment scope
Evaluation of the EL with .evaluateAttributeExpressions(Map<String,String>)

This should not throw an error. This PR is to fix this case as well as covering the overall EL evaluation in the test framework with proper unit testing.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Thanks for reviewing @exceptionfactory - pushed a commit to address your comments


fix removal of inner_polygons from outer_polygons

This is a fix for issue #1098. As described by @orrsim, the difference in the inner loop was referring back to the original outer_polygon rather than the result of any previous difference outer_polygon_diff.
With this fix,
ox.features_from_point(     (60.4436,10.2364),     tags = {'natural' : 'water'},     dist = 100 )
returns Fjorda with the islands removed.
@orrsim, thanks for pointing this out and also for identifying the bug.

Thank you @AtelierLibre!
Closes #1098


Moved Balloon cat out from the dcpets & fixed customItemData

Description:
fixed small things with Balloon cat code
Changes:

Removed tradeable: true & 1tradeable_on_ge: truefrom Balloon cat due to it is ment to be untradeable & hasisSuperUntradeable: true`
moved Balloon cat out of discontinued section in pets.ts above dyed

Other checks:

[ ] I have tested all my changes thoroughly.

Dont move it please. It ruins the diff, and the file is already wildly unorganized and not really meant to be anymore.

Dont move it please. It ruins the diff, and the file is already wildly unorganized and not really meant to be anymore.

gotcha
I will not touch it. I was confused why it was down there but you have a reason


new dashboards

the new dashboards are in separate folder
there is a main dashboard that gives access to the rest of the dashboards
some polishing based on personal user
fixed in the volume dashboard the filtering by account
node-b is not there anymore

Merging in Davide's dashboards


Switch yarn to npm

Resolved in https://github.com/joonasy/rebirth/commit/873d9e95d6a64f852059b5eeb4b40258b1929fe0


[SPARK-36044][SQL] Suport TimestampNTZ in functions unix_timestamp/to_unix_timestamp

What changes were proposed in this pull request?
The functions unix_timestamp/to_unix_timestamp should be able to accept input of TimestampNTZType.
Why are the changes needed?
The functions unix_timestamp/to_unix_timestamp should be able to accept input of TimestampNTZType.
Does this PR introduce any user-facing change?
'Yes'.
How was this patch tested?
New tests.

Test build #140842 has started for PR 33278 at commit a2b5b4f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45353/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45353/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45353/

Test build #140842 has finished for PR 33278 at commit a2b5b4f.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140842/

retest this please

Test build #140886 has started for PR 33278 at commit a2b5b4f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45397/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45397/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45397/

Test build #140886 has finished for PR 33278 at commit a2b5b4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140886/

Test build #140890 has started for PR 33278 at commit 1761df9.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45401/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45401/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45401/

Test build #140890 has finished for PR 33278 at commit 1761df9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@MaxGekk Thank you for review.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140890/


Backport of 2256

Backport of #2256

jenkins test luminous-ansible2.4-purge_bluestore_osds_container

Just checking, did this fast-forward merge without a merge commit?

Yes, we remove the merge commit thing from github. Now we rebase and merge instead of creating a merge commit. This makes the history more readable and less 'polluted' by these merge commits.


Update schema.json for atom query specific properties

Background
Some of the SMARTS features should be described in schema.json
Solution
Add following properties into schema.json:

Aromaticity
Degree
Implicit H count
Ring membership
Ring size
Connectivity
Ring connectivity
Chirality
Atomic mass

implicitHCount already in schema.


cannot mount bcachefs from lvm raid0 device

Describe the bug
I have an LVM setup, and I've been trying out bcachefs by using it as scratch space (since it's stuff I don't mind losing) on an LVM RAID0 volume with 4 stripes. Since #304761 updated bcachefs-tools to 1.7.0 I can't mount this, but switching back to a previous generation with bcachefs-tools 1.4.1 or using bcachefs-tools 1.3.3 from nixos-23.11 lets me mount it just fine. Using a linear volume instead also works fine.
Steps To Reproduce
Steps to reproduce the behavior:

Create an LV with -t raid0 --stripes 2
Create a bcachefs filesystem on the new LV
Try to mount the new filesystem

Running bcachefs mount with -v results in:
INFO - bcachefs::commands::cmd_mount: mounting with params: device: /dev/dm-38:/dev/dm-40, target: /mnt, options:
DEBUG - bcachefs::commands::cmd_mount: parsing mount options:
INFO - bcachefs::commands::cmd_mount: mounting bcachefs filesystem, /mnt
INFO - bcachefs::commands::cmd_mount: mounting filesystem
ERROR - bcachefs::commands::cmd_mount: Fatal error: Device or resource busy

Expected behavior
Should mount correctly. Output from bcachefs-tools 1.3.3:
INFO - bcachefs_rust::cmd_mount: mounting with params: device: /dev/vg/test, target: /mnt, options:
DEBUG - bcachefs_rust::cmd_mount: parsing mount options:
INFO - bcachefs_rust::cmd_mount: mounting bcachefs filesystem, /mnt
INFO - bcachefs_rust::cmd_mount: mounting filesystem
INFO - bcachefs_rust::cmd_mount: Successfully mounted

Additional context
I don't know enough about Linux FS implementations, but suspect it might be an instance of https://github.com/koverstreet/bcachefs-tools/issues/260
Notify maintainers

@davidak @JohnRTitor @Madouura
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.9.1, NixOS, 24.05 (Uakari), 24.05.20240519.6c0b7a9`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.90.0-beta.1-lixpre20240506-b6799ab`
 - channels(jez): `""`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/store/r8nhgnkxacbnf4kv8kdi8b6ks3k9b16i-source`

Add a :+1: reaction to issues you find important.

Is it an encrypted setup?

Well, the patch doesn't make a difference, but that's ok because just building it from master at kentoverstreet/bcachefs-tools works fine. If I was a betting man I'd guess the issue is fixed by one of the udev-related commits from 7 May. It also gets rid of all the annoying warnings about not finding bcachefs superblocks as it walks the device tree.

Yes, that's correct. Using the following overlay to my nixpkgs causes everything to work as expected:
final: prev: { bcachefs-tools = inputs.bcachefs-tools.packages.${prev.system}.bcachefs; }


GitHub Actions setup-java v2

@sullis Apologies, this notification got lost in the email vortex. Would you mind elaorating a bit on what this change improves?


Add expanding_* functions

In #487 we added rolling operations.  It would be nice to add their cumulative counterparts.  This is likely to be similar in nature to rolling operations.
I came across this need while trying to make a simple demo with random data.

With cumulative methods in #636 in, the immediate need for this may be delayed. I have a first pass at this (done before #636 came in, should definitely be reworked to share methods with #636) up on my fork here. If anyone ever has a need for these this work can be restarted.

No one but myself seems to be asking for this.  Closing as low-priority.

is it still possible to add this functionality?


Settings page visibility

Fixes #552
Setting page now render setting options based on user permissions. I have removed the save button from settings so now setting will auto save as soon as they get changed.
File upload already show an error so no changes in that. File upload don't require perms but the error describe in #552 used to happen when it fail to send state event but now it wont happen as well.

I don't think we should remove the Save button as it'll reload the room for people in it every time you change something. It's also not possible to change the scene and script in one go and a script paired with the wrong scene might break. Everything else looks good, but I'd roll that change back.

Ah shoot, sorry I still didn't look into this close enough. I think we should hide the "Settings" menu item from these dropdown menus when you can't edit them.

Great, thanks for fixing this!


Rendered projects to page, completed issues

Alright, I added Erica as a collaborator so she can provide more helpful comments
I adjusted the size of the background image in my art editor so that it doesn't overlap my icon photo, but I can adjust it more if necessary.
Reorganized my file structure into three directories, scripts, styles and imgDir
Added credits to my readMe file
Made a lot of adjustments to my consctuctor and added a file for my array of project Objects. I would really like to eliminate that whole file, I don't like having to type out each object like that, I'd rather have another contructor and just make instances of it to make this.
Used handlebars to render my projects to the page
Next step for me is to make a bunch of CSS changes to the way the projects look on the page as well as making it more obvious that the images are links
I think that's everything. All the changes I've made since the last pull request I started this morning at 8:30, so it took about 2 and half hours total
Had a lot of issues with name consistency, like img instead of image etc, going to try and eliminate those issues for the future

Hm. Just noticed that my hamburger doesn't work unless I stick all that logic from projectView.js into projects.js. I'll fix that later.


Fix reading trace_read_requests tenant config option from config file.

The new "trace_read_requests" option was missing from the parse_toml_tenant_conf function that reads the config file. Because of that, the option was ignored, which caused the test_read_trace.py test to fail. It used to work before commit 9a6c0be823, because the TenantConfigOpt struct was constructed directly in tenant_create_handler, but now it is saved and read back from disk even for a newly created tenant.

Our config file handling could use a big refactor: when you add a new option you currently have to remember to add it to a dozen different places. It's no wonder if some of them are missed. But this is just a narrow fix.

@SomeoneToIgnore fixed this in commit 09393279c657ee1a02ca89b4a3ef570160cf05ac yesterday. What's left in this PR is now just one more place where the new GUC was missed.


Add more Rule

Hi Team,
Thank you for updating few rules in SASjs Lint. Could  you please add more rule for best practices of SAS Code ?

Closing this as it is not related to a bug or specific feature request - see discussion here instead:  https://github.com/sasjs/lint/discussions/183


Document WabiSabi based protocol

This document describes a concrete but general protocol which uses
WabiSabi credentials to collaboratively create transactions.
The specifics of ransaction structure are out of scope.
The SVG files are generated with plantuml -tsvg, and should arguably
not be in the repository, but github will not render plantuml source
files directly.
See also #64
Co-authored-by: nopara73<EMAIL_ADDRESS>

For easier review, here's a link to the file which provides some context for the diagrams

TODO items (I think in another pull request)

[ ] bans and ban expirey
[ ] sybil resistance and UX rationale for confirmed inputs only
[ ] status response
[ ] network fees
[ ] coordinator fees


Minecraft 1.17 doesn't start

Minecraft 1.17 doesn't start because java 16 is required, please change the openjdk version in the flatpak.

Thanks for the heads up! :)
I just released a new version with an updated JRE, please give it a go. :)

Everything works, I'm happy to have been of help.


When doing a PutAsync, use InsertOrMerge instead of InsertOrReplace

This would preserve existing values from a previous change, if possible.

This sounds good in principle, but seems risky: you might very well end up with a mix of data that isn't really valid in the domain.


Android: can't add new note

What happened?
When list gets longer than the height of the screen - adding a new item is not possible anymore.
What did you expect to happen?
Have a + sign to add new note as on desktop.
How can we reproduce it (as minimally and precisely as possible)?
Have an android phone and create enough notes to cover the whole height of the screen.
Anything else we need to know?
No response
Plugin version
1.17.1
Obsidian version
1.5.8
OS
Other

Obsidian bottom toolbar may have occupied more spaces than expected. Will draft a fix. Both android and iOS suffers from this.

I experience this as well on pixel phone with 3 button toolbar.
On desktop, I don't like having to scroll down to add an item. My opinion: the + button should be at the top adjacent to filters and sort.
File creation is a first class citizen and should not be relegated to a hidden location.

I experience this as well on pixel phone with 3 button toolbar.
On desktop, I don't like having to scroll down to add an item.
File creation is a first class citizen in Obsidian. I advise moving the button to a new location to reflect that. Or maybe have a setting that allows users to select where to place the button. Or have it in 2 places. All viable options.
@Acylation maybe placing it adjacent to filters and sort would work?


feat(analytics): add analytics for local operations

Jira: APIOPS-86

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1b8317a) 33.58% compared to head (3b4af4c) 33.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   33.58%   33.55%   -0.04%
==========================================
  Files         101      101
  Lines       12430    12442      +12
==========================================
  Hits         4175     4175
- Misses       7848     7860      +12
  Partials      407      407

Files
Coverage Δ

cmd/file_addplugins.go
0.00% <0.00%> (ø)

cmd/file_addtags.go
0.00% <0.00%> (ø)

cmd/file_listtags.go
0.00% <0.00%> (ø)

cmd/file_merge.go
0.00% <0.00%> (ø)

cmd/file_openapi2kong.go
0.00% <0.00%> (ø)

cmd/file_patch.go
0.00% <0.00%> (ø)

cmd/file_removetags.go
0.00% <0.00%> (ø)

cmd/file_render.go
0.00% <0.00%> (ø)

cmd/common.go
3.94% <0.00%> (-0.03%)
:arrow_down:

cmd/file_convert.go
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@Kong/team-deck - Would appreciate your review on this. It seems safe enough to me and we could always revert if there are problems.


Iterative setup for podman pods infra

podman promises to be better Docker, and provides pods  on top of ordinary containers, similar to kubernetes. Let's see if it can handle the standard case of test driven/iterative infrastructure development.
In  https://github.com/release-monitoring/anitya Dockerfile is greatly outdated. Missing dependencies, absent services, different commands that run for Dockerfile, for Development Ansible and for production.
Let's try to see how podman improves that. And first, let's setup DevOps workbench.

Terminal pane to write container build code
Terminal pane that watches container build code, rebuilds container and restarts it (could be two panes - one for building, one for starting)
Terminal pane that waits for container to startup, then for services to start, then testes them and report result

This is setup for TDD for infrastructure. The third panel is our test, which is connected to the second panel - if container failed to start or failed in the middle, the test panel should detect that and report as well.
Them we can just leave all three panels independently and work on the code.

This setup we need to create container for https://github.com/release-monitoring/anitya and try to reuse  Ansible scripts that will be shared with production.

Get Anitya running
Expose DB connection for inspection
Run shemaspy/schemaspy container


ghost clicks

I have noticed that when i click on a "button" that takes me to another screen, if there is a button on that secondary screen in the same general location where i tapped, i get a second tap/click on the button on that second page.
I have seen this reported before and some workarounds posted but none of the workarounds seem to help for me.

I had the same issue.  What worked for me is to put code in the transition event.
buttons.bind('pageAnimationStart', function (e, info) { disable buttons here});
buttons.bind('pageAnimationEnd', function (e, info) {
if (info.direction == 'in') {
enable buttons here
}
});
It would be nice if the framework somehow did this internally but this works for now.

Has anyone got a better fix for this issue? Getting it on iOS devices.

This is a dupe of #253


Architecture restructuring with zeus now centralised

zeus is now one bash script
zeus has now one more sub command and option

Run the following to test

cd ~/Desktop
git clone https://github.com/alayek/zeus.git
Remain in ~/Desktop
chmod 755 ~/Desktop/zeus/zeus
~/Desktop/zeus/zeus create -python newproject
Enjoy the magic

So the commandline syntax is:
zeus create -python newproject
where zeus is the main command which is invoking the bash script
create is the sub command to create a new project directory with vm
-python is the option for Python stack

LGTM :+1:

You missed copying the tests directory.

No errors here.

@alayek do we have to copy the test directory? It is only for collaborators and testers but not for endusers right? I want to keep it for the user as simple as possible without any distractions.

Ideally, we should have a test mode and production mode. In test mode, we do copy the test directory, but in production mode, the end users won't need to do that.

LGTM :+1:
Let's :shipit: :package:
We will fix the issues after merge.

Yes I will add a test option flag to Zeus!


Gemini fails after function calling

After executing Function Calling in Gemini, an error occurs after some time indicating that the context is invalid. Upon investigation, it seems that the issue arises because the number of turns held in context reaches its limit. As a result, older messages are truncated, and the Function Calling message is no longer included before the corresponding Function Response message.
This leads to a mismatch in the context, causing the request to fail.

Fixed in v0.8.3👍


Add Resource requests and limits of Pods created by NewPodBuilder API.

Resource request at Pod scope is required to enable e2e framework to create
Pods with a specific set of VFs while creating a list of secondary networks
on a Pod using SRIOV.
Resource requests and limits can be used for other type of resource allocation
specific to a Pod as well (CPU, Memory etc.,)
Signed-off-by: Arunkumar Velayutham<EMAIL_ADDRESS>

/skip-all

@arunvelayutham you have some CI formatting errors that prevent me from merging (you should be able to fix them with make golangci-fix)

Sorry, I missed to do make golangci-fix earlier though I did make fmt. taken care now and pushed the changes.

/skip-all

@antoninbas Please approve this again. I did a rebase to take care of DCO error.

@arunvelayutham done, but I need to wait for the Github CI to complete again

/skip-all

/skip-all

@arunvelayutham apparently the DCO signoff is still wrong

Commit sha: ed243fb, Author: root, Committer: root; Expected "root<EMAIL_ADDRESS>but got "Arunkumar Velayutham<EMAIL_ADDRESS>
The commit was authored in the name of "root", perhaps because the git env was not set up properly when committing. You may update the author info via git commit --amend --author="Arunkumar Velayutham<EMAIL_ADDRESS>

Commit sha: ed243fb, Author: root, Committer: root; Expected "root<EMAIL_ADDRESS>but got "Arunkumar Velayutham<EMAIL_ADDRESS>
The commit was authored in the name of "root", perhaps because the git env was not set up properly when committing. You may update the author info via git commit --amend --author="Arunkumar Velayutham<EMAIL_ADDRESS>
just noticed that and updated. thank you @tnqn

@arunvelayutham apparently the DCO signoff is still wrong

Taken care now. please check in a short while @antoninbas

/skip-all

/skip-all


Move controllers and views to addon and put facades in app

Attempt to fix #58.
So far, successfully.

Will include this in a pre 0.1 version it contains breaking changes. Thanks a lot!

OK. I also moved the main component to addon and exported it.

Ok I need to merge-rebase your PR @LexLythius. Will try to do that now.


How do the sub routes works?

Hi,
I'm trying to apply this example to a real world, but it doesn't seem to work. What should happen when I write http://www.mysite.com/user/110? What I expect is:

load component home
load component user (inside a default <slot></slot> in home)
load component user-profile (inside a default <slot></slot> in user)

const routes = [
  {
    path: "/",
    component: "home",
    routes: [
      {
        path: "user",
        component: "user-view",
        routes: [
          {
            path: ":userId",
            component: "user-profile",
            routes: [
              {
                path: "edit",
                component: "user-profile-edit"
              }
            ]
          }
        ]
      }
    ]
  }
];

But what happens is that only the user-profile component is loaded, so i can't understand how the nested routes works.

Documentation about the sub routes explains that they are mostly to avoid repetition https://router.matsu.fi/recipes/sub-routes
What you are trying to achieve is documented in the slots -section https://router.matsu.fi/recipes/slots

Thank you,
I finally have a working example, but I have some questions:
Is it possible to create more nested slots (or only one level)?
When I switch from one view to another, the whole tree is reloaded (the parent component too), it's right?
I created this sandbox for reference: https://codesandbox.io/s/admiring-colden-v7ct2?file=/src/index.js

Yeah Simplr Router is sort of a "Dumb" router in a sense that it doesn't really limit the developer, and required the developer to work out the kinks. Making a clear rule that something is re-loaded and something isn't would be something out of scope for a simple router.
As for the nested slots. When the slots idea was introduced as requested in https://github.com/Simplr/simplr-router/issues/18 , I didn't come to think about wanting to have nested slots there.
If that is a feature that you see would add value, I could look into adding it in the following week. Is that something that would benefit you?

hey @hanc2006  :) Pinging you again to check how you're progressing, and if this feature is urgent for your project?
I've been quite busy lately but I'm sure I could squeeze this one out within a week

Hey @Matsuuu, sorry for the delay, but I was busy the last week. Don't worry, I finally choose another way, one simple router that react on push state change. Thanks for your interest :+1:


Add a "Shift Stats" TOML configuration that adds a new element to the Stat list that changes stat values (case for Masks).

In GitLab by @mclemente on Dec 11, 2023, 15:18

In GitLab by @Asacolips on Feb 11, 2024, 19:03
mentioned in commit 14bb53734ecd1b6ee3d3640e91b39099cd7c0681

In GitLab by @Asacolips on Jan 24, 2024, 16:38
mentioned in commit 1fde4feff4ec11414e515f096f2f2a8d248f8eb2

In GitLab by @mclemente on Dec 11, 2023, 15:18
added #91 as parent issue


June 2020 Endgame

6/29 Code freeze for the endgame
7/3 Endgame done
7/8 Expected release date (this may change)

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame.

Monday

[x] Run OSS tool endgame champion
[x] Code freeze at 7pm PT
[x] Ensure we have a green build on all platforms at 7pm PT
[x] Create test plan items following the template here by 9pm PT
[x] Add verification-needed label to features needed testing and are not tested by TPIs.
[x] Update your availability for testing here - https://vscode-tools.azurewebsites.net/
[x] Create Test plan item for smoke testing (template) endgame champion
[x] Review the extensionKind list in product.json both for stable and insiders, see this tracking issue @egamma

Tuesday

[x] Test plan items assigned (using https://vscode-tools.azurewebsites.net/)

Run the tool multiple times to balance load if test items come in later and assignments are already made
Assigned to you

[x] 🔖All closed feature-requests either have a verification-needed or on-testplan label
[x] Test build starts at 7am CET
[x] Test plan ready by 8am CET
[x] 🔖Testing
[x] 🔖Verification needed

Wednesday

[x] 🔖Testing
[x] Remind team members to assign issues that they intend to fix to the current milestone
[x] Fixing (self-assigned, milestone assigned)
[x] 🔖Verification needed
[x] Prepare for Smoke test: Make sure all smoke test issues are labelled smoke-test and fixed endgame champion

Thursday

[x] Fixing (self-assigned, milestone assigned, NO discussion during standup)

Move issues to the next month that can be deferred

[x] 🔖Verification needed
[x] 🔖Verification
[x] Prepare for Smoke test: Make sure all smoke test issues are labelled smoke-test and fixed endgame champion

Friday

[x] Pause scheduled insider builds endgame champion
Satellite modules/npm packages ready, version updated, smoke tested

[x] vscode @bpasero
[x] yo generator @aeschli
[x] vsce @joaomoreno
[x] node debug @weinand
[x] node debug2 @roblourens
[x] js-debug @connor4312
[x] node debugadapter node @weinand
[x] custom data for html/css @aeschli

[x] All issues 🔖verified
[x] Fixing (scrutiny sets in - major bugs only - to be discussed in stand-up meeting, labeled as candidate)
Smoketest (⚠ MUST run with --stable-build argument ⚠ )

[x] Windows - @dbaeumer
[x] macOS - @sandy081
[x] Linux - @bpasero
[x] Web (Chromium) - @dbaeumer

[x] All release notes updated

release notes are collected in a file named v<Major>_<Minor>.md in this repo directory
[x] @aeschli
[x] @alexdima
[x] @alexr00
[x] @bpasero
[x] @chrmarti
[x] @connor4312
[x] @dbaeumer
[x] @deepak1556
[x] @eamodio
[ ] @egamma
[x] @isidorn
[x] @JacksonKearl
[x] @joaomoreno
[x] @jrieken
[x] @kieferrm
[x] @lszomoru
[x] @mjbvz
[x] @rebornix
[x] @rmacfarlane
[x] @roblourens
[x] @sandy081
[x] @sbatten
[x] @tyriar
[x] @weinand

[x] Acknowledge pull requests in release notes. We acknowledge PRs from outside the team. Use the thankyou tool to generate the initial contents of the section. owner

[x] vscode endgame champion
[x] vscode-node-debug @weinand
[x] vscode-node-debug2 @roblourens
[x] vscode-debugadapter-node @weinand
[x] vscode-js-debug @connor4312
[x] vscode-languageserver-node @dbaeumer
[x] language-server-protocol @dbaeumer
[x] vscode-textmate @alexdima
[x] vscode-loader @alexdima
[x] vscode-generator-code @aeschli
[x] vscode-vsce @joaomoreno
[x] vscode-docs @gregvanl
[x] vscode-css-languageservice @aeschli
[x] vscode-json-languageservice @aeschli
[x] vscode-html-languageservice @aeschli
[x] jsonc-parser @aeschli
[x] vscode-eslint @dbaeumer
[x] vscode-jshint @rmacfarlane
[x] vscode-recipes @chrisdias
[x] localization @weeteckt
[x] vscode-github-issues-prs @chrmarti
[x] inno-updater @joaomoreno

[x] Review pull requests acknowledgements with NOT MERGED - PLS REVIEW. endgame champion
[x] Acknowledge issue trackers from the community @chrmarti
[x] Add notable fixes to the release notes all
When done fixing/verifying and there are changes since last build at the end of day PT

[x] Trigger new insider build and publish it manually endgame champion

[x] Branch code to `release/<x.y> endgame champion
[x] Bump up the version in package.json - endgame champion
[x] Announce master is open for business endgame champion

Friday/Monday

[x] Polish release notes redmond
[x] Fixing (only critical bugs - no string changes)

Monday - Wednesday

[x] 🔖milestone issues
[x] 🔖candidate issues
[x] Polish release notes redmond
[x] Cherry-pick hand-picked and reviewed changes to release/<x.y> endgame champion
[x] Build Insider from release/<x.y> endgame champion
[x] Manually release Insider endgame champion
[x] Build stable for all platforms as new candidate issues come in endgame champion
[ ] Documentation updated

[x] @aeschli
[x] @alexdima
[x] @alexr00
[x] @bpasero
[x] @chrmarti
[x] @connor4312
[x] @dbaeumer
[x] @deepak1556
[x] @eamodio
[ ] @egamma
[x] @isidorn
[x] @JacksonKearl
[x] @joaomoreno
[x] @jrieken
[x] @kieferrm
[x] @lszomoru
[x] @mjbvz
[x] @rebornix
[x] @rmacfarlane
[x] @roblourens
[x] @sandy081
[x] @sbatten
[x] @tyriar
[x] @weinand

[x] Run scripts/test-documentation.sh|bat and add file or fix issues if there are new colors that are not documented.

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame. endgame champion

Wednesday/Thursday - Expected release day (this may change)

[x] Build stable for all platforms endgame champion
[x] Sanity check of installable bits

[x] Windows 32 bit @roblourens

[x] signed installer 32-bit
[x] signed user installer 32-bit
[x] zip 32-bit

[x] Windows 64 bit owner

[x] signed installer 64-bit
[x] signed user installer 64-bit
[x] zip 64-bit

[x] Windows ARM64 @deepak1556

[x] signed installer ARM64
[x] signed user installer ARM64
[x] zip ARM64

[x] macOS - @roblourens
[x] Linux

[x] deb package 64-bit @RMacfarlane
[x] rpm package 64-bit @RMacfarlane
[x] archives @RMacfarlane
[x] snap (sudo snap install --classic --dangerous <file>.snap) @JacksonKearl

[x] Server (instructions) owner

[x] Linux @connor4312
[x] macOS @kieferrm
[x] Windows @RMacfarlane

[x] Publish website @ornellaalt
[x] Publish Localization language pack @weeteckt
[x] Publish to stable endgame champion
[x] Create an official release endgame champion

[x] Create a tag: git tag <x.y.z>
[x] Push the tag: git push origin <x.y.z>
[x] Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Example

[x] Publish @types/vscode endgame champion
[x] Enable scheduled insider builds endgame champion
[x] Twitter announcement @chrisdias

Several links from this issue use the wrong milestone in their filters. Ones I found:

First Tuesday, item 2.
First Wednesday, item 4.
First Friday, item 2.
Monday - Wednesday, item 1.

@gjsjohnmurray fixed -- thanks!

@eamodio @dbaeumer Broken link in issue description (and prolly in issue template):
Run OSS tool endgame champion


Does not work on Brackets version 1.10

Just updated and noticed there are a few errors in the Brackets core. Extension API changes? :/

Fixed. Just weird indexeddb behaviour.


The "panel" is not documented.

Or I haven't been able to find it in the documentation. It is a good feature and should be included in the docs.

I just added a small documentation. Check Issue #192. I hope it helps

Great, I think that's enough to let everyone know about this option.

I will get back to you as soon as possible...
https://awayfind.com/fordarnold
--
Opt out of future auto-replies: http://orchant.awayfind.com/oo?h=d96521f2&e=0d116acd


[GWS] fix several issues

Coverage increased (+0.09%) to 80.351% when pulling 76aacd3d5f4500f40a02fb0d69fad680a15955f3 on sunny4381:fixes/several-issues into 2e04dc14bbf73d03ffef37e465a532a6a8a7d658 on shirasagi:dev/gws.


Add support for System.Numerics.Complex[]

Why do you use your own Complex class for complex numbers, now C# has a built-in class and it looks like it can do the same thing as yours?

Hi @AlexandrSpirin, this is a good question! I think the reason I implemented my own complex number class is so it could be minimal and simple, and easily ported to other languages. Compare the complexity of these two classes:

https://github.com/swharden/FftSharp/blob/main/src/FftSharp/Complex.cs

https://github.com/microsoft/referencesource/blob/master/System.Numerics/System/Numerics/Complex.cs

I recognize that people who already have data in System.Numerics.Complex[] would expect a FFT library to be able to work with that standard data type. We could add support for this in a non-breaking way by overloading these two functions with essentially identical code:
https://github.com/swharden/FftSharp/blob/8015e0dc504edd01c02ae6b9c9d334dc33d9bda5/src/FftSharp/Transform.cs#L20-L66
If you want to create a PR I would be happy to review it! Bonus points for demonstrating the new usage in the readme and in a new test. If you decide not to that's okay, I'll leave this issue open and implement this next time I work in this code base.
Thanks again for pointing this out!
Scott

Following-up, I'm moving these methods into their own static class with a simpler API that resembles Math.NET
// Apply FFT in place
System.Numerics.Complex[] samples = { /* */ };
FftSharp.FFT.Forward(samples);

// Get FFT from real data array
double[] samples = { /* */ };
System.Numerics.Complex[] fft = FftSharp.FFT.Forward(samples);


First call to "readCurrentState fails with getState function failed: connect ECONNREFUSED

Greetings .. For the past year your security system has been working great with BlueIris.
About two months ago I started having issues with the first call to ReadCurrentState. Its intermittent but typically happens when I first fire up Homekit on a client. I typically receive a "No response" on the client, however if I just refresh it works fine until the next time I open Homekit. The error I receive from the plugin debug log is "getState function failed: connect ECONNREFUSED". What's odd about this situation is that for some reason I'm getting a TCP  SYN/RST due to an incorrect checksum.
107 TCP: 8080 → 39034 [RST, ACK] Seq=1 Ack=1 Win=0 [TCP CHECKSUM INCORRECT] Len=0
I've swapped homebridge platforms (RPI 3B+ to RPI 4 to Win10) as well as completely rebuilt the Blueiris server with no change in symptoms which would imply this error is buried somewhere in node.js since the issue is specific to one call.
If you have any ideas on how to isolate this or debug node.js I'm open to suggestions.

Hello, your issue is really strange and I wish I could be of any assistance. The problem you are describing is very low level and pretty much out of my control / expertise. My system is using the 'request' npm package for HTTP calls, which, I presume, is then using some sort of nodejs functions for handling its TCP connections. And I assume nodeJS is using the operating system's TCP stack for this, and as far as I now that is responsible for low level things like TCP handshakes.
To be honest I wouldn't be surprised if this problem was affecting other software running on your box as well, not just nodejs. Anyways, I really can't help you there. I've been working with network stuff since '97 but I have never ever witnessed such a low-level TCP error.
Just an idea, is it possible that you have some sort of network device sitting between your Blueiris server and your homebridge that might manipulate packets around and may be responsible? Something you did not try replacing yet? Maybe a router or a smart switch doing NAT?

Thanks for your response .. It was definitely an odd problem but seems to have been resolved by turning off network offloading on the server and reducing the load of the homebridge ffmpeg plugin.
It turns out ffmpeg does not support the ability to send the basic authentication header in the first http request. This means it has to receive a 401 first, then on the second attempt it sends the header. This is definitely not best practice for basic authentication but it is unfortunately not that uncommon. The odd part was as the number of ffmpeg calls increased it started to affect the servers ability to handle all http logins resulting in occasional tcp resets.
Neither solution makes any sense but rule 25 says “never argue with success”.
Glenn Christiansen
<EMAIL_ADDRESS>
On Mar 31, 2020, at 6:34 AM, Marcell Tóth<EMAIL_ADDRESS>wrote:
Hello, your issue is really strange and I wish I could be of any assistance. The problem you are describing is very low level and pretty much out of my control / expertise. My system is using the 'request' npm package for HTTP calls, which, I presume, is then using some sort of nodejs functions for handling its TCP connections. And I assume nodeJS is using the operating system's TCP stack for this, and as far as I now that is responsible for low level things like TCP handshakes.
To be honest I wouldn't be surprised if this problem was affecting other software running on your box as well, not just nodejs. Anyways, I really can't help you there. I've been working with network stuff since '97 but I have never ever witnessed such a low-level TCP error.
Just an idea, is it possible that you have some sort of network device sitting between your Blueiris server and your homebridge that might manipulate packets around and may be responsible? Something you did not try replacing yet? Maybe a router or a smart switch doing NAT?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/codetwice/homebridge-http-securitysystem/issues/30#issuecomment-606572254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQ47XZTBP2TZLVKQF4YNM3RKHINNANCNFSM4LWGT4IQ.


Compile time legacy 2 secs vs next 7 secs

Since we spoke about this on Slack, I'd document the issue and benchmark here. Benchmark was run on DisplayingABitmap demo from openfl-samples
On windows compare
Measure-Command {lime build neko --times -Dmacro-times -Dlegacy}
Measure-Command {lime build neko --times -Dmacro-times}
On mac/unix compare
time lime build neko --times -Dmacro-times -Dlegacy
time lime build neko --times -Dmacro-times
Results :
Macro times : legacy 0.9 secs vs next 3.5 secs
Execution times : legacy 2.2 secs vs next 7.5 secs
Note :
One feedback was to set a HXCPP_COMPILE_CACHE directory in .hxcpp_config.xml but the results are time-wise still the same. Another thing that vastly improves the difference is using the completion server, which however seems to be broken atm.
Screenshot of results :

Further discussion here: https://github.com/openfl/openfl/issues/1395


Add support for Polkadot

Reference
Crypto

https://wiki.polkadot.network/en/latest/polkadot/learn/cryptography/
https://research.web3.foundation/en/latest/polkadot/keys/

Address

https://github.com/paritytech/substrate/wiki/External-Address-Format-(SS58)
https://substrate.dev/docs/en/ecosystem/subkey

Tx / Encoding

https://substrate.dev/docs/en/overview/extrinsics
https://github.com/polkadot-js/api/blob/master/docs/substrate/extrinsics.md
https://substrate.dev/docs/en/overview/low-level-data-format

RPC

https://github.com/polkadot-js/api/blob/master/docs/substrate/rpc.md

Fixed by https://github.com/trustwallet/wallet-core/pull/791


fix(deps): update module github.com/ibm-cloud/power-go-client to v1.2.2

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM-Cloud/power-go-client
require
patch
v1.2.1 -> v1.2.2

Release Notes

IBM-Cloud/power-go-client
v1.2.2
Compare Source
What's Changed

Update swagger client and models to Service-Broker to v1.109.0  by @rmoralesjr in https://github.com/IBM-Cloud/power-go-client/pull/190

Full Changelog: https://github.com/IBM-Cloud/power-go-client/compare/v1.2.1...v1.2.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.2.19 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


hello

Thank you for the PR. Please take Hacktoberfest as opportunity to level up your coding skills.