Test reproing 404s (and 503s) during routerule apply

Test for issue #1038, errors during routingrule application
Test for issue #1038, errors during routingrule application

@ldemailly: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

got errors with:
bazel build //tests/e2e/tests/simple:go_default_test

./bazel-bin/tests/e2e/tests/simple/go_default_test -alsologtostderr -test.v -v 2  --skip_cleanup --namespace=e2e-2 -istioctl ~/tmp/istio-0.2.7/bin/istioctl --auth_enable

# during istio install:
customresourcedefinition "routerules.config.istio.io" created
# but then later:
 the server could not find the requested resource (post routerules.config.istio.io)
, err: exit status 1
# and pilot in crash loop with
W1006 01:30:58.604835       1 client.go:194] name conflict: ListKindConflict
I1006 01:30:58.604867       1 client.go:198] missing status condition for "routerules.config.istio.io"

@ldemailly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2e36039d5d8ed1ee32fd1377c232701776b2261d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This fails, finding 404s and 503s, the 404s need fixing probably using this and the 503s probably some other check for "no match" ?

@ldemailly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

somehow on prow it only got 503s and no 404, probably need to make changes more than once to trigger it reliably, on my personal cluster it happens more often
/retest

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

to repro/see:
git checkout issue_1038_aka_404s
bazel build //tests/e2e/tests/simple:go_default_test
# first time:
./bazel-bin/tests/e2e/tests/simple/go_default_test -alsologtostderr -test.v -v 2  --skip_cleanup --namespace=e2e -istioctl  ~/tmp/istio-0.2.7/bin/istioctl --auth_enable --test.run  Test404sDuringChanges # will create the e2e namespace and install istio init, may get unrelated failue
# Subsequent:
./bazel-bin/tests/e2e/tests/simple/go_default_test -alsologtostderr -test.v -v 2  --skip_cleanup --skip_setup --namespace=e2e -istioctl  ~/tmp/istio-0.2.7/bin/istioctl --auth_enable --test.run  Test404sDuringChanges
# output:
14:23:24 W http.go:540> Parsed non ok code 404 (HTTP/1.1 404)
14:23:24 W http.go:540> Parsed non ok code 404 (HTTP/1.1 404)
14:23:24 W http.go:540> Parsed non ok code 404 (HTTP/1.1 404)
14:23:24 W http.go:540> Parsed non ok code 404 (HTTP/1.1 404)
14:23:24 W http.go:540> Parsed non ok code 404 (HTTP/1.1 404)
[...]
	simple1_test.go:191: Not all 146 requests were successful (map[200:136 404:10])

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
b4533853dbbb0ed1d52897572bfde3489fda6a94
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

to test:
# first install
./bazel-bin/tests/e2e/tests/simple/go_default_test -alsologtostderr -test.v -v 2  --skip_cleanup  --namespace=e2e-isaiah -istioctl  ~/tmp/istio-0.2.7/bin/istioctl --auth_enable --test.run  Test404sDuringChanges --pilot_hub=$PILOT_HUB --pilot_tag=$PILOT_TAG
# then add --skip_setup
./bazel-bin/tests/e2e/tests/simple/go_default_test -alsologtostderr -test.v -v 2  --skip_setup --skip_cleanup  --namespace=e2e-isaiah -istioctl  ~/tmp/istio-0.2.7/bin/istioctl --auth_enable --test.run  Test404sDuringChanges --pilot_hub=$PILOT_HUB --pilot_tag=$PILOT_TAG

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
1319fdebfa7d715b0ba0ff38f22945068c3eda40
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
ecf887bf3a5fe15142fad53c3f613fae360f9964
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

the 404s still repro locally for me but somehow they didn't in the last run since picking up new deps; they did before though, retrying:
/retest

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

showed up in https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1041/e2e-suite-rbac-auth/1114/

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
de24915bf4df6bf58016a82442a935ac216aba00
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-cluster_wide-auth

prow/istio-presubmit.sh
2079d7b42251de4aa775a2815a9b09b8ee019719
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-cluster_wide-auth

prow/istio-presubmit.sh
349f04724692f2df148918b78501440d483ac52a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
3eef0181b664d0715d21d2e11c6e911a4de14528
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-auth.sh
1b3b795d094df9839ba10e6409efbe27e00b8738
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
e789493f6ab237db74f94620c8c9c3f6d462d53e
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
1b3b795d094df9839ba10e6409efbe27e00b8738
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
1b3b795d094df9839ba10e6409efbe27e00b8738
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
1b3b795d094df9839ba10e6409efbe27e00b8738
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
1b3b795d094df9839ba10e6409efbe27e00b8738
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
1b3b795d094df9839ba10e6409efbe27e00b8738
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
1b3b795d094df9839ba10e6409efbe27e00b8738
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yes both fail (you can check the prow logs and see both 404s and 503s, also you can run the test individually though with new mono repo I'm not sure the instructions I put still work)

/approve
/lgtm

yes it was mostly for you to have something you can test pilot/envoy fixes against - hopefully we can indeed merge it when it starts passing

I'm not sure what "[ci skip]" is supposed to mean but we shouldn't drive anything from the subject of a PR (maybe have a label? but then it shouldn't be settable by anyone)
And in this case this PR definitely should go through all CI and should fail until we have a fix on all of them

@ldemailly I agree we should not use PR titles for this purpose.
It is some circle CI thing.
e2e tests now run on Master only, not on presubmits.
This means the test run only after PR is merged.
You will need to kick off e2e on this PR manually.
@sebastienvas will this work? The expectation is that this test is run against the current Master.

we need to seriously get better at discussing changes before we make them
it's not a good idea to stop running the few e2e tests we do have!

/test e2e-suite-rbac-auth

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yutongz https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1041/e2e-suite-rbac-auth/1734
e2e build fails because bazel is too old !

/retest

Can we have a simpler version of this test without routing rules, that only checks for 503 during normal flow?

503s without changes are a different and harder to reproduce issue. i have it reproduced in the perf setup (#3295) but you can start from this one and add another test without rule change (add, not remove/change) ?
but i suggest you just try a fix with those tests as they are
(the second one is too strict btw as mentioned above)

can you please rebase?

just did (I wonder where the github button went, in theory anyone can rebase)

Test404sDuringChanges didn't fail on circle, it may need to be rerun a few times to fail
Test503sWithPartialRules did fail as it's very strict
it got 503s for the duration of the test but maybe the health check / checking for non existent version is not a feature that works yet so I would focus on Test404sDuringChanges (which I can rename to Test503sDuringChanges)

second run on circleci failed in the 'right' test but for the wrong reason:
=== RUN   Test404sDuringChanges
2018-02-14T05:20:31.870466Z	info	I httprunner.go:72> Starting http test for http://<IP_ADDRESS>:31864/fortio/debug with 8 threads at 8.0 qps
2018-02-14T05:20:31.873405Z	info	W http.go:667> Parsed non ok code 404 (HTTP/1.1 404)
--- FAIL: Test404sDuringChanges (0.00s)
	simple1_test.go:188: Generating traffic via fortio failed: error 404 for http://<IP_ADDRESS>:31864/fortio/debug: "HTTP/1.1 404 Not Found\r\ndate: Wed, 14 Feb 2018 05:20:31 GMT\r\nserver: envoy\r\ncontent-length: 0\r\nx-envoy-upstream-service-time: 0\r\n\r\n"

and later
* cannot delete route-rule/istio-system/rule-3: routerules.config.istio.io "rule-3" not found

so it looks like the rule didn't apply at all somehow
@rkpagadala do you know why none of the prow test seem to have run e2e_simple ? (it did not too long ago)

/retest

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
e19a20fa0f050a210d5e36447fa485790d4924af
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

https://circleci.com/gh/istio/istio/32508
has the right expected failure:
=== RUN   Test404sDuringChanges
2018-02-15T02:07:20.586620Z	info	I httprunner.go:72> Starting http test for http://<IP_ADDRESS>:32135/fortio/debug with 8 threads at 8.0 qps
Starting at 8 qps with 8 thread(s) [gomax 2] for 20s : 20 calls each (total 160)
2018-02-15T02:07:29.587076Z	info	Changing rules mid run to v1/v2
2018-02-15T02:07:29.587220Z	info	Running command /go/out/linux_amd64/release/istioctl -n istio-system create -f /go/src/istio.io/istio/tests/e2e/tests/simple/routingrule1.yaml
2018-02-15T02:07:29.684271Z	info	Command output:
 Created config route-rule/istio-system/rule-1 at revision 989
, err: <nil>
2018-02-15T02:07:30.097539Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:30.097854Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:30.098099Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:30.098374Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:30.101881Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:30.102393Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:30.102641Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:30.102728Z	info	W http.go:667> Parsed non ok code 503 (HTTP/1.1 503)
2018-02-15T02:07:33.684424Z	info	Changing rules mid run to a/b
2018-02-15T02:07:33.684479Z	info	Running command /go/out/linux_amd64/release/istioctl -n istio-system create -f /go/src/istio.io/istio/tests/e2e/tests/simple/routingrule2.yaml
2018-02-15T02:07:33.758427Z	info	Command output:
 Created config route-rule/istio-system/rule-2 at revision 995
, err: <nil>
2018-02-15T02:07:37.758628Z	info	Running command kubectl delete -n istio-system -f /go/src/istio.io/istio/tests/e2e/tests/simple/routingrule1.yaml
2018-02-15T02:07:37.905227Z	info	Command output:
 routerule "rule-1" deleted
, err: <nil>
2018-02-15T02:07:37.905267Z	info	Running command kubectl delete -n istio-system -f /go/src/istio.io/istio/tests/e2e/tests/simple/routingrule2.yaml
2018-02-15T02:07:38.065967Z	info	Command output:
 routerule "rule-2" deleted
, err: <nil>
2018-02-15T02:07:40.628022Z	info	I periodic.go:523> T005 ended after 20.009854534s : 20 calls. qps=0.9995075159600358
2018-02-15T02:07:40.628073Z	info	I periodic.go:523> T002 ended after 20.009925762s : 20 calls. qps=0.999503958079702
2018-02-15T02:07:40.628090Z	info	I periodic.go:523> T007 ended after 20.009945345s : 20 calls. qps=0.9995029799018175
2018-02-15T02:07:40.628105Z	info	I periodic.go:523> T000 ended after 20.009960399s : 20 calls. qps=0.9995022279504112
2018-02-15T02:07:40.628120Z	info	I periodic.go:523> T001 ended after 20.009975567s : 20 calls. qps=0.9995014703058183
2018-02-15T02:07:40.628135Z	info	I periodic.go:523> T004 ended after 20.009991287s : 20 calls. qps=0.9995006850899286
2018-02-15T02:07:40.628700Z	info	I periodic.go:523> T006 ended after 20.010545198s : 20 calls. qps=0.9994730179564996
2018-02-15T02:07:40.629487Z	info	I periodic.go:523> T003 ended after 20.011316214s : 20 calls. qps=0.999434509260711
Ended after 20.01139686s : 160 calls. qps=7.9954
Sleep times : count 152 avg 1.0374356 +/- 0.00512 min 1.017450595 max 1.046385411 sum 157.690218
Aggregated Function Time : count 160 avg 0.014670283 +/- 0.005075 min 0.006034764 max 0.034980807 sum 2.34724534
# range, mid point, percentile, count
>= 0.00603476 <= 0.007 , 0.00651738 , 3.12, 5
> 0.007 <= 0.008 , 0.0075 , 5.00, 3
> 0.008 <= 0.009 , 0.0085 , 6.25, 2
> 0.009 <= 0.01 , 0.0095 , 13.12, 11
> 0.01 <= 0.011 , 0.0105 , 20.62, 12
> 0.011 <= 0.012 , 0.0115 , 30.00, 15
> 0.012 <= 0.014 , 0.013 , 48.12, 29
> 0.014 <= 0.016 , 0.015 , 70.00, 35
> 0.016 <= 0.018 , 0.017 , 85.62, 25
> 0.018 <= 0.02 , 0.019 , 89.38, 6
> 0.02 <= 0.025 , 0.0225 , 95.62, 10
> 0.025 <= 0.03 , 0.0275 , 96.88, 2
> 0.03 <= 0.0349808 , 0.0324904 , 100.00, 5
# target 90% 0.0205
Code 200 : 152 (95.0 %)
Code 503 : 8 (5.0 %)
Response Header Sizes : count 160 avg 161.26875 +/- 37.12 min 0 max 174 sum 25803
Response Body/Total Sizes : count 160 avg 1540.6188 +/- 1076 min 107 max 2849 sum 246499
--- FAIL: Test404sDuringChanges (20.04s)
	simple1_test.go:193: Not all 160 requests were successful (map[200:152 503:8])

same in https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1041/e2e-suite-rbac-auth/808/
I0215 02:16:57.137] --- FAIL: Test404sDuringChanges (21.90s)
I0215 02:16:57.137] 	simple1_test.go:193: Not all 160 requests were successful (map[503:16 200:144])

Happy to explain this log / what happens if anyone has a question
I filled #3509 for the prow skipping this test issue

/test e2e-suite-rbac-auth

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

well bad news: #3482 doesn't help:
--- FAIL: Test503sDuringChanges (20.30s)
	simple1_test.go:193: Not all 160 requests were successful (map[200:120 503:40])

/test e2e-suite-rbac-auth

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
89b35962932a6a92f3c56654bb2d7c265bade7bd
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
89b35962932a6a92f3c56654bb2d7c265bade7bd
link
/test e2e-simple

prow/istio-unit-tests.sh
469520cf63178b564c62fd90fed97dd7040ebab3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
89b35962932a6a92f3c56654bb2d7c265bade7bd
link
/test e2e-simple

prow/istio-unit-tests.sh
469520cf63178b564c62fd90fed97dd7040ebab3
link
/test istio-unit-tests

prow/istio-presubmit.sh
469520cf63178b564c62fd90fed97dd7040ebab3
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly thanks for adding this. I took the tests and used them in #4419 with alpha3 rules, please feel free to close this.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [ZackButcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-bookInfoTests.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
18be058723f395efc5ca64f0676d4affc46191c3
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
5e89d5926b0e4ea2c4c6deeb3cba3535e5ab4222
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andraxylia let me get those in shape, then maybe merge them with "t.Skip()" and you can pick them up

maybe you can make a new test with alpha3 rules but I think it's important to resolve the 503s with alpha1

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
5e89d5926b0e4ea2c4c6deeb3cba3535e5ab4222
link
/test e2e-simple

prow/istio-pilot-e2e.sh
2bb70c2edab383f161eeccca76dc4dd776904bde
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/istio-pilot-e2e.sh
2bb70c2edab383f161eeccca76dc4dd776904bde
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
2bb70c2edab383f161eeccca76dc4dd776904bde
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

We will drop alpha1 is 0.8, so I will not even try.

we are not dropping alpha1 in 0.8; 0.8 is the last version with alpha1 and alpha1 is the only stable one

btw it's pretty good right now / better - at least on circle; it only got 8 errors during rule deletion, vs a lot more errors in 0.2
/test e2e-simple

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/istio-pilot-e2e.sh
2bb70c2edab383f161eeccca76dc4dd776904bde
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
2bb70c2edab383f161eeccca76dc4dd776904bde
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/istio-pilot-e2e.sh
2bb70c2edab383f161eeccca76dc4dd776904bde
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
f117e24dd7cef1a2cd4fa72bb04a518141e8e9a8
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
ccf4e1bcd191e80dd8853345e64509aaae8a2f23
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
ccf4e1bcd191e80dd8853345e64509aaae8a2f23
link
/test e2e-simple

prow/istio-presubmit.sh
adf1c890e7f796c0187634d8a48df4001cd40fbb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
d384a4d641a960d50a6b4df5b11fc7bbadc4eb4f
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-bookInfoTests.sh
47744c388236f990925328fe5bd9316f79fc2420
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
47744c388236f990925328fe5bd9316f79fc2420
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
47744c388236f990925328fe5bd9316f79fc2420
link
/test e2e-simple

prow/istio-presubmit.sh
bf6b38461685f2f73fe95e6c761b7d109d2fa382
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-bookInfoTests.sh
47744c388236f990925328fe5bd9316f79fc2420
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
47744c388236f990925328fe5bd9316f79fc2420
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-bookInfoTests.sh
47744c388236f990925328fe5bd9316f79fc2420
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
47744c388236f990925328fe5bd9316f79fc2420
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-simpleTests.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
01efc648d2262c5974dbe989a82ce8128ad9e04f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-bookInfoTests-v1alpha3.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
01efc648d2262c5974dbe989a82ce8128ad9e04f
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
01efc648d2262c5974dbe989a82ce8128ad9e04f
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/istio-pilot-e2e.sh
149eaa32cf626918d48cd536139e116e1d793276
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
01efc648d2262c5974dbe989a82ce8128ad9e04f
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
01efc648d2262c5974dbe989a82ce8128ad9e04f
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
01efc648d2262c5974dbe989a82ce8128ad9e04f
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/istio-pilot-e2e.sh
01efc648d2262c5974dbe989a82ce8128ad9e04f
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
30608cd090df05fa1898d75650cdf476f361ab44
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
0c5f5d933f658f35282cc3f774a44238f6f2a591
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
bda16938a1263439204ffdca8021546c66f4d257
link
/test e2e-suite-rbac-auth

prow/e2e-bookInfoTests-v1alpha3.sh
30608cd090df05fa1898d75650cdf476f361ab44
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
30608cd090df05fa1898d75650cdf476f361ab44
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

All required tests passed


when hovering over a datapoint, not enough decimals are shown

When you set the number of decimals on the y-axis (eg to 3), the number of decimals in the informationcard is still 1.

The number is rounded to 1 decimal.
The data shown in this example is water usage in cubic liters
1382770 liters, or 1382.77 cubic liters
I think the informationcard should also show 1382.770 instead of 1382.8 liters
like this

There is a float_precision setting in each serie which will do what you want.

Thank you very much !
It does the job.


Generate SBOM on filesystem instead of label metadata

To implement Paketo RFC0038, this buildpack will need to move from storing SBOM information in layer metadata to storing it in files that the CNB lifecycle can manipulate during the build. The RFC outlines what these files are and what they should contain.
See also https://github.com/paketo-buildpacks/python/issues/399.

@paketo-buildpacks/python-maintainers can you assign this to me please?

Update: we will wait for first-class support in pack (and hence occam) before implementing this. We will support both the metadata/label format and the filesystem format via packit/v2.
Marking this as blocked until occam testing framework is available.

This is now unblocked as the requisite features are available in packit.
See the nodejs buildpack integration tests for an example on how to test this.


Switch supported debug primitives with config flags

If I don't need any text, there should be no dependency on RustyXML, for example.

This was fixed with #40.


Tracking: Lomiri Desktop Environment

Project description
Lomiri is a continuation of Canonical's Unity8 desktop environment. It's based on:

Qt5 (Qt6 support is being considered)
Mir (currently Mir 1.x & Mir-protocol, Mir 2.x & Wayland is being worked on)
Ayatana Indicators (continuation of Canonical's Application Indicators)

Corresponding RFP: #99090

I have a working version of Lomiri in a branch, with too many commits & inits to nicely upstream. I've started upstreaming individual packages, but progress has been slow and likely not very transparent. I would like to use this issue to track the progress of individually upstreaming all the components needed to make enabling Lomiri as easy as i.e. XFCE.
Overview of needed packages
Graph date: 2023-10-21 morning (not necessarily correct/complete)

[x] accounts-qml-module: #260897
[ ] address-book-app
[ ] address-book-service
[ ] ayatana-indicator-application
[ ] ayatana-indicator-bluetooth
[x] ayatana-indicator-datetime: #277825
[x] ayatana-indicator-display: #305516
[ ] ayatana-indicator-keyboard: #304614
[x] ayatana-indicator-messages: #243476
[ ] ayatana-indicator-notifications
[x] ayatana-indicator-power: #305092
[ ] ayatana-indicator-printers
[x] ayatana-indicator-session: #283543
[x] ayatana-indicator-sound: #305127
[x] biometryd: #261018
[ ] buteo-syncfw
[ ] buteo-syncfw-qml
[x] cmake-extras: #236282
[x] content-hub: #262406
[x] dbus-cpp: #260941
[x] dbus-test-runner: #236282
[x] deviceinfo: #241265
[ ] dialer-app
[ ] dsme
[x] geonames: #241259
[x] gmenuharness: #236282
[x] hfd-service: #261020
[x] history-service: #261031
[ ] indicator-location
[x] libayatana-common:

#243307
#262118

[ ] libcal
[ ] libdsme
[ ] libiphb
[ ] libmce-qt
[ ] libngf
[x] libqtdbusmock: #236282
[x] libqtdbustest: #236282
[x] libusermetrics: #241335
[ ] location-service
[x] lomiri: #292872
[x] lomiri-action-api: #261014
[x] lomiri-api: #236282
[x] lomiri-app-launch: #245803
[ ] lomiri-calculator-app
[ ] lomiri-calendar-app
[ ] lomiri-camera-app
[ ] lomiri-clock-app
[x] lomiri-download-manager: #245900
[x] lomiri-filemanager-app: #316240
[ ] lomiri-gallery-app
[x] lomiri-indicator-network: #262895
[ ] lomiri-keyboard
[ ] lomiri-music-app
[x] lomiri-notifications: #261036
[ ] lomiri-online-accounts
[x] lomiri-schemas: #245904
[x] lomiri-session: #292872
[x] lomiri-settings-components: #259238
[x] lomiri-sounds: #260947
[x] lomiri-system-settings: #278374
[ ] lomiri-system-settings-online-accounts
[x] lomiri-system-settings-security-privacy: #278374
[x] lomiri-terminal-app: #247112
[x] lomiri-thumbnailer: #259740
[x] lomiri-ui-extras: #247101
[x] lomiri-ui-toolkit: #241717
[x] lomiri-url-dispatcher: #259377
[x] lomiri-wallpapers: #279454
[ ] mce
[ ] mce-dev
[ ] mediaplayer-app
[x] mediascanner2: #261933
[ ] messaging-app
[x] morph-browser: #262433
[x] net-cpp: #260869
[x] persistent-cache-cpp: #259393
[x] qdjango: #237543
[x] qmenumodel: #245911
[x] qqc2-suru-style: #260892
[x] qtmir: #259804
[x] qtpim: #214164
[x] qtsystems: #214179
[x] qzxing: #260886
[ ] repowerd
[ ] sync-monitor
[x] telephony-service: #264844
[x] trust-store: #261919
[x] u1db-qt: #260967
[ ] usb_moded
[x] xsct: #260873

Not in the graph, but additionally required changes:

[x] librda: #262174
[x] qmltermwidget

#245778
#275475

[ ] lomiri-polkit-agent?
[x] rlottie needs to expose its CMake module: #280135
[x] rlottie-qml: #285781
[x] lomiri-push-qml: #285876
[x] quickflux: #285553
[ ] teleports

Some of these may not be necessary and only fulfill optional functionalities (I doubt the parts of the SailfishOS stack - mce, buteo-syncfw etc - are really required), I'll have to review the affected reverse dependencies when I upstream them to Nixpkgs.
Follow-up issues/notes

lomiri-ui-toolkit, and packages that depend on it via QML, look up locale files from a single, fixed path. Due to how its localisation framework works, QML modules at all levels of a QML dependency tree will use the same locale path. Currently this is patched to /run/current-system/sw/share/locale as a short-term solution. Long-term, it would be better to either

Patch lomiri-ui-toolkit's locale-finding logic to consider XDG_DATA_DIRS and make a setup hook for Lomiri applications that search for & add QML module's prefixes to this variable. This is exactly what KDE does, and the corresponding functionality can more or less be ported from ki18n
Manually check all QML modules that depend on this functionality and make sure to patch in an infrequently-used API call to bindtextdomain, explicitly passing the full prefix for the corresponding package, so none of this functionality relies on the hardcoded path in lomiri-ui-toolkit

libayatana-common, with Lomiri features enabled, will pull in ~800MB of graphical dependencies from lomiri-url-dispatcher's GUI test tool. We should play around with i.e. a lomiri.lomiri-url-dispatcher.lib output to reduce the closure size for potential future non-Lomiri users.
We should check in all packages if any scripts with a /bin/sh slipped through, and patch those. We do have /bin/sh, but we shouldn't rely on it.
services.xserver.displayManager.lightdm.greeters.lomiri.enable likely doesn't work without services.desktopManager.lomiri.enable, might need some duplicated settings
keyboard layout is stuck on US QWERTY because the layout is queried & set via a Ubuntu-only interface to AccountsService AFAICT. We'll need to patch around this.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/unity-desktop-environment/25312/6

I fail to install lomiri due to telephony-service which fails to build due to unit tests

https://github.com/NixOS/nixpkgs/pull/315117 or its 24.05 backport may not have propagated to whatever nixpkgs version you're using yet.

Finally landed to unstable... Am I the only one unable to resize windows and firefox crashing entire session?

Resizing works for me, you need to hover barely outside of the window borders and drag (the cursor doesn't change for me, not sure what this is down to).
Firefox is at least known to not work correctly. I think the crashing might be an issue only we are having, but I believe on Debian it also doesn't work (it brings up an empty window on bookworm, not sure about trixie/sid). I think this is an issue in qtmir, I might need to re-sync our package and check if there's been any improvement on that front. The bundled Morph Browser should work, not sure about others. Suboptimal, I know…

Hm. Firefox works just fine in Ubuntu 22.04 Lomiri testing edition for me (googled some article on Ubuntu Unity website, it has the iso, can provide a link).
Regarding the cursor: last time I saw a similar issue (not on Lomiri though), it was the lack of $XDG_DATA_DIRS/icons/default symlink to a cursor theme.

Can try switching to https://gitlab.com/ubports/development/core/qtmir/-/tree/personal/sunweaver/debian-upstream branch, which seems to be what ubuntu 24.04 is using.


(short issue description)

Describe the bug
We run jsii-pacmak as part of our buildspec so we can publish constructs to PyPi, Maven, etc. The latest release of jsii/superchain:1-buster-slim-node16 now fails with an error in jsii-pacmak:
@aws-solutions-constructs/core: [jsii-pacmak] [WARN] Failed building python
@aws-solutions-constructs/core: [jsii-pacmak] [WARN] python failed
@aws-solutions-constructs/core: Error: Command (python3 -m venv --system-site-packages /tmp/npm-packJMJs8d/.env-dM7gfi) failed with status 1:
@aws-solutions-constructs/core: #STDERR>
@aws-solutions-constructs/core: #STDOUT> The virtual environment was not created successfully because ensurepip is not
@aws-solutions-constructs/core: #STDOUT> available.  On Debian/Ubuntu systems, you need to install the python3-venv
@aws-solutions-constructs/core: #STDOUT> package using the following command.
@aws-solutions-constructs/core: #STDOUT>
@aws-solutions-constructs/core: #STDOUT>     apt-get install python3-venv
@aws-solutions-constructs/core: #STDOUT>
@aws-solutions-constructs/core: #STDOUT> You may need to use sudo with that command.  After installing the python3-venv
@aws-solutions-constructs/core: #STDOUT> package, recreate your virtual environment.
@aws-solutions-constructs/core: #STDOUT>
@aws-solutions-constructs/core: #STDOUT> Failing command: ['/tmp/npm-packJMJs8d/.env-dM7gfi/bin/python3', '-Im', 'ensurepip', '--upgrade', '--default-pip']

The odd thing is that jsii-pacmak runs correctly when run on the same inage on a Mac notebook (Monterery 12.6.6).
Any suggestions on how to pursue this?
Expected Behavior
jsii-packmak completes successfully on both CodeBuild instance and locally
Current Behavior
@aws-solutions-constructs/core: [jsii-pacmak] [WARN] Failed building python
@aws-solutions-constructs/core: [jsii-pacmak] [WARN] python failed
@aws-solutions-constructs/core: Error: Command (python3 -m venv --system-site-packages /tmp/npm-packJMJs8d/.env-dM7gfi) failed with status 1:
@aws-solutions-constructs/core: #STDERR>
@aws-solutions-constructs/core: #STDOUT> The virtual environment was not created successfully because ensurepip is not
@aws-solutions-constructs/core: #STDOUT> available.  On Debian/Ubuntu systems, you need to install the python3-venv
@aws-solutions-constructs/core: #STDOUT> package using the following command.
@aws-solutions-constructs/core: #STDOUT>
@aws-solutions-constructs/core: #STDOUT>     apt-get install python3-venv
@aws-solutions-constructs/core: #STDOUT>
@aws-solutions-constructs/core: #STDOUT> You may need to use sudo with that command.  After installing the python3-venv
@aws-solutions-constructs/core: #STDOUT> package, recreate your virtual environment.
@aws-solutions-constructs/core: #STDOUT>
@aws-solutions-constructs/core: #STDOUT> Failing command: ['/tmp/npm-packJMJs8d/.env-dM7gfi/bin/python3', '-Im', 'ensurepip', '--upgrade', '--default-pip']

Reproduction Steps
jsii-pacmak  in project where jsii has already completed successfully
Possible Solution
No response
Additional Information/Context
Relevant buildspec setup commands:
      "commands": [
        "echo \"*************************************************\\n**********      BUILD FOR CDK V2     ************\\n*************************************************\"",
        "yarn --version || npm -g install yarn",
        "yarn install --frozen-lockfile",
        "sudo apt-get update -y",
        "sudo apt-get install -y ruby-full",
        "sudo apt-get install -y gem gcc",
        "echo \"Installing cfn_nag utility - `pwd`\"",
        "gem install cfn-nag",
        "cfn_nag -v",
        "echo \"cfn_nag utility installation complete `date`\""
      ]
    },
    "pre_build": {
      "commands": [
        "echo \"*************************************************\\n**********      BUILD FOR CDK V2     ************\\n*************************************************\"",
        "echo \"Installing content scanning utility - `pwd`\"",
        "sudo apt-get install -y wget",
        "aws s3 cp s3://viperlight-scanner/latest/.viperlightrc .viperlightrc",
        "aws s3 cp s3://viperlight-scanner/latest/viperlight.zip .",
        "unzip -q viperlight.zip -d ../viperlight",
        "rm -r ./viperlight.zip",
        "echo \"Content scanning utility installation complete `date`\"",
        "echo \"Starting content scanning `date` in `pwd`\"",
        "../viperlight/bin/viperlight scan --exclude-module python-pipoutdated --exclude-module python-bandit",
        "echo \"Completed content scanning `date`\""
      ]

SDK version used
2.82.0
Environment details (OS name and version, etc.)
jsii/superchain:1-buster-slim-node16

Additional info - locally I am running the M1 image, I believe that CodeBuild is running an x86 docker image.

This was addressed in a subsequent image release.


Switch to python builtin hash function generates too few partitions for tuple keys

Python 2.x: In 0.5.3 disco used md5 on a stringified version of the key mod the number of partitions to generate partition assignments by default. In 0.5.4 this switched to using the python hash() call. Calling this on tuples yields very few results when taken mod a low number like 100 - we're seeing in the range of 2-16 or so, yielding far few actual partitions than requested. Using strings works fine.
Seems like if keys need to be strings this should be enforced/documented, or a different hash function used?

https://github.com/discoproject/disco/issues/614


support multireader?

Does it support the recognition of multiple QR codes in a picture?

Yes，it does!


Config Request: Blacklist of items

I'm looking for an option to prevent certain items from being able to be a part of the ship.  I have certain blocks which aren't supposed to be moveable, but can be made into a part of a ship.
Thanks!

This is already in the MovingWorld config.


[CARBONDATA-2417] [SDK Writer] SDK writer goes to infinite wait when consumer thread goes dead

Problem:
SDK Writer going into infinte loop in case of multi-threaded scenario
Analysis:
In multi-threaded scenarios where multiple instances of writer thread are trying to add a row to the RowBatch, addition to given batch size cannot be ensured as addition process is not synchronized and it can lead to ArrayIndexOutOfBound Exception or data loss/mismatch issues.
If multiple writer threads are adding the data to RowBatch and immediately after launching all the threads closeWriter is called, in that case we don't know when all the data is finished writing by all the threads but we are returning immediately from close writer after setting the close flag to true. This does not ensure complete processing of data.
Solution:
Make the row addition logic synchronized and modify the code in closeWriter to ensure data completeness.

[ ] Any interfaces changed?
No

[ ] Any backward compatibility impacted?
No

[ ] Document update required?
No

[ ] Testing done
Manually verified

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4605/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5764/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4825/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5789/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4634/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4842/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5805/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4650/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4857/


ModuleNotFoundError:    No module named 'src'

Running forganiser immediately outputs the above after being installed via pip.
However, was able to manually run it by cloning repo & cd src & entering python init.py into the CLI.

Fixed it, sorry for the delay, I was busy with my exams!


Specifying many MUCs to auto-join on app load

Other webchat XMPP clients (Converse.js, Candy) offer configuration options to specify which MUCs to auto-join when the client webapp is loaded.
How to do that with Kaiwa? And how to specify more than one room?
I imagine it would ideally happen somewhere here:
https://github.com/ForNeVeR/Kaiwa/blob/a86d4080994d49e5e6195188e7fda230ba66d437/src/resources/js/login.js#L33-L46
… but it doesn’t.
Halp! :pray:

(Kind of related to #232).

Kaiwa read bookmarks and join rooms which marked with "autojoin" flag on server

I see. Do you test it with Ejabberd, tho? It doesn’t seem to save the joined MUCs to bookmarks (and it doesn’t request MAM?)?

@michalrus well, joining the bookmarks and saving the rooms to the bookmarks are two distinct features. Please file a separate issue if the bookmarks aren't saved for you.
Also, I've no idea why it should or shouldn't request MAM, please file an issue also.


Removes alias_method_chain

Removes alias_method_chain to make compatible with Rails 5.1.2

Thanks @RandieM - I wish I had the power to merge this

Any word on this? Seems like a simple enough fix.

👍 Would like to see this merged

@curtis Hey Curtis, I know this project hasn't been maintained in a while, but it would be awesome to see this PR merged.


Set Matrix Zeros Problem in C++

Solved in the Set Matrix Zeros Problem in-place in C++
The matrix can easily be taken as an input and resulting output is clearly displayed.
Added test cases as comments that includes edge cases and their respective output.

#47 Merged


Precision regarding 'html_block' and EscapeHtml

I noticed that extra don't work with the EscapeHtml example in the release notes and made a remark about this.
I'm not sure if the extra should be fixed because of this or if it's an inherent decision from the way things are supposed to work with this set of extensions.
Also added some missing indentation.

Hmm, so the "extra" extension adds support for markdown=1 to parse Markdown text inside raw HTML blocks. But the EspaceHTML extension disables raw HTML parsing. Of course the two are mutely exclusive. Not sure why that needs to be pointed out.

I'm not that interested in the internals of the extra extension set, but it's very commonly enabled. Not sure of the stats, but wouldn't it sound reasonable to say that 50% of users can't use the EscapeHTML approach?
Also, MarkdownInHtmlProcessor is enabled through the extra extension which is a bit blurry to me.. is it like a dependency of all the other extra extensions?

(renamed extras=extra)

Btw I can see Coveralls is freezing up as I've seen so many other times.. I ended up replacing it with CodeCov.io in most of my repositories after having had so many problems with Coveralls... basically gave up on it.

The "extra" extension is just a shortcut which enables all of the various extensions necessary to implement the features which most closely match PHP Markdown Extra. It exists mainly for historical reasons which are no longer relevant.
The one exception is that "extra"  also adds the MarkdownInHtmlProcessor which does not exist in a separate extension of its own. Basically it implements an incomplete (and undocumented) clone of PHP's Markdown Inside HTML Blocks feature. It is not connected to any other extensions in any specific way. The intention was to break it out into its own extension when it was improved to a point where it made sense to advertise and document it (when it came out of beta). But that never happened and today I believe it is not the best solution for supporting Markdown inside raw HTML. As we never documented it, few users have made use of it and I doubt it will survive the move to version 3.0. For that matter, I doubt the "extra" extension will survive to version 3.0.
So, yes, "MarkdownInHtml" and "EscapeHtml" are mutually exclusive. You can't have both. But given that the former is completely undocumented (and not officially supported), I'm okay with that and don't want to start documenting it now. Therefore, I don't want to document the conflict either. For that reason, I am closing this PR. If you want to create a new one for the indentation fix, you are welcome to. Otherwise I'll do that myself later.
If you want "extra" and "EscapeHTML" just enable the various extensions under "extra" individually along with the "EscapeHTML" extension and things should work fine. In fact, the Markdown inside raw HTML will still get parsed as the parser has no knowledge of HTML tags in that case.

You'll go an awfully long way to reject a simple precision for the documentation, I'll give you that. Thanks for the explanation. Of course it makes sense, and I never contested your explanation... I just wanted to share it with other users and documentation readers.


Maximize Window with Custom Menu

VSCode Version: 1.26.0-insider( 4fa62b2 , Date: 2018-08-03T12:32:46.237Z)
OS Version: Windows 10

-- Sorry for the English, I used Google Translator --
When maximizing the VSCode the same shows a white band at the top. See the gif.

Does this issue occur when all extensions are disabled?: Yes

#52265
Sorry about that!! 😊


chore: use new JS packages in integration tests

Description

Problem*

Resolves
Summary*
This PR updates the integration tests to use the new JS packages in order to simplify the code.
Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

I've bundled in a change which adds the integration tests to our standard workflow on PRs.


Test multiple java versions

Test multiple Java versions and distributions as part of CI

Thanks, @myedibleenso!


⚠ ClamAV has degraded performance

In d4e578b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 7924d8f.


A suggestion

It would be nice if you said enter file path including file name in description because it causes confusion for user in which format you have to enter file name, I tried entering file name then separated by comma, comes the file path which failed, then added file name after path separated by comma.
What worked was adding file name in the file path. Thanks for extension. Appreciate the work

Thank you for your suggestion, and sorry for giving confusion.
I improved README at https://github.com/hoddy3190/sync-extensions/pull/2/commits/f6c0aad8cf862e8371d3084e2004f3bb86059be2 .


Change add-cluster to single column layout

more unified look&feel (preferences & cluster settings are already single column)
close button (X)
longer description/help text moved to docs

Probably needs some padding fine-tuning between the lines. I will push changes in this branch.

Probably needs some padding fine-tuning between the lines. I will push changes in this branch.

I already did some style cleanup, it should be a bit better.

Here is complete look

@aleksfront thanks!


✨ Add @percy/cypress migration

What is this?
This adds a migration for @percy/cypress. This SDK does not have import changes, but does have a major change removing the need for task registration. A new transform was added to handle this task removal for users.
I'm not sure if you can define tasks using ES modules in Cypress, but I added logic and tests for it just in case.
- import <local> from '@percy/cypress/task'
- const <local> = require('@percy/cypress/task')

- on('task', <local>)
- on('task', require('@percy/cypress/task'))

do we care if someone is coming from @percy/cypress 1.x (no task)?

They can answer No to the transform prompt to skip it, or if they run it anyway it won't change the file (since the tasks don't exist).


Update SwiftLint to 0.57.0

Updates SwiftLint to 0.57.0

Hi! Thanks for the PR! The change looks good – I just wanted to double-check the md5 signature but I got a different value. Which file did you use to get the hash? (I haven't updated it myself in a while either 😅)

@michaeleustace You're quite right! The docs are incorrect, but the implementation clearly shows the md5 sum from the zip file:
https://github.com/ashfurrow/danger-ruby-swiftlint/blob/16dbb9f23ff2688bc4b1ab185793f87a3121b4af/ext/swiftlint/downloadSwiftlint.sh#L36-L44
I'll update the docs and tag you.

This change has been released in 0.37.0 👍


i18n(es): Translated payload.cms

What kind of changes does this PR include?

Translated content

Description

What does this PR change? Give us a brief description.
Translated payload.cms to spanish.

Gracias por la revisión @Waxer59 😁


Running reports on apex_collections

As Fernando  suggested, he runs his reports on data stored in apex_collections ... and this is not accessible by a different database session.
Again, multiple approaches are possible here, needs some exploration.

That could actually be feasible. When we implement a token based security mechanism, then we could actually "attach" to the running APEX session from the backend.
We would need a table that stores a generated token together with an apex session id. The token could only be used once and would be "used" by the integration by expiring or deleting the row in the table.


Whitelist design

As follow-up to #8 some rough suggestions about the whitelist design:
Either add a note above the whitelist that existing whitelist entries can be edited and the save button has to be pressed afterwards or add an own save button in the actions column if something has changed in an entry.
Also, I would prefer that the empty line is hidden by default and only visible after pressing an “Add new” button or shorter only “New”. This could put in the actions column, too, or above the whitelist, but certainly then the button name has to be longer (“New whitelist entry” or similar?).

Thanks for taking the time to give some feedback.
I'll see what i can do to make the whitelist more intutive to use.
Might take me a bit of time, since i am a little busy in the comming weeks.
Nonetheless, i'll try to get to it on a weekend or something.

I opted to rather not completely redesign the whitelist with something like tabulator ... so i just made some minor changes and added a note.


Release Google.Cloud.Firestore version 2.1.0

Changes in this release:

Commit 48cef0e: Allow nested arrays to be constructed client-side, relying on server-side validation
Commit b1e6e8b: Perform some more client-side validation for WhereIn queries to avoid an unfortunate type safety mistake
Commit 2517e6e: Convert strings into references for DocumentId queries. Fixes issue 4981

Note that although this release doesn't involve any API surface changes, the features here (particularly converting strings into references for DocumentId queries) feel significant enough to warrant a minor version instead of a patch release. (They are effectively features rather than bug fixes.)

Created release for Google.Cloud.Firestore-2.1.0


Clean up old maintainer notes

Most of the material in maintainer-notes was

covered by the workflow docs
or covered by the contribution process
or out of date. (#927)

Also: de-emphasized the rust and proof init docs, but linked them from the appropriate sections of development-environment.

Why de-emphasize these sections of the docs? The proofs intro in particular seems important, and it now has an external link from the invites so I'd be careful that the URL doesn't change.

Let me move the init sections back where they were for URL stability. For someone trying to get started, I worry that this page can be intimidating. I guess I'd like a path where there's enough information about Rust so they can build the software, without getting in mired in other details.

(The new mini-toctrees I think are an improvement because they offer more information at the point where there might be questions just about Rust or about proof writing.)

Not urgent, but would like to get this merged before adding a note on the cargo build for R:

#1918


Feature/add hsts header

What
Add Strict-Transport-Security header to all responses
How to review

Run make test
curl -v 1>/dev/null should not include Strict-Transport-Security: max-age=31536000
Run build/dp-frontend-router
curl -v 1>/dev/null should include Strict-Transport-Security: max-age=31536000

Who can review
Anyone except @ian-kent

It looks like the build failure has been inherited from cmd-develop.


ci: add isort

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.50%. Comparing base (6ac57a9) to head (fcbca75).

:exclamation:  There is a different number of reports uploaded between BASE (6ac57a9) and HEAD (fcbca75). Click for more details.
HEAD has 5 uploads less than BASE

Flag
BASE (6ac57a9)
HEAD (fcbca75)

6
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   96.48%   88.50%   -7.99%
==========================================
  Files          30        8      -22
  Lines        3276      983    -2293
==========================================
- Hits         3161      870    -2291
+ Misses         89       87       -2
  Partials       26       26

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add metadata subcommand to cargo

This is a follow up of #1225, #1434 and #2091
cc @dan-t @lunaryorn @winger @alexcrichton
Currently we have an external sub command by @winger. The fork compatible with the recent version of cargo is here.  It is very experimental, but already can be used to extract valuable metadata (a proof by gif). It depends on the dev version of cargo and is not available on crates.io, but you can cargo install --git https://github.com/intellij-rust/cargo-metadata it.
I would really like to include this sub command to cargo:

It's not very convenient to ask a user to install some tool when she just tries to open a project in an IDE.
Installing metadata can be a hassle: it depends on the cargo itself, so it takes ages to compile and can fail if you don't have necessary OpenSSL headers.
A "standard" metadata command would help tools interoperability.

So I ask the following questions:

What data and in what format should metadata provide? @dan-t, @lunaryorn could you experiment with it and give feedback?
What steps are to be taken to merge this thing to cargo?

• What data and in what format should metadata provide? @dan-t, @lunaryorn
could you experiment with it and give feedback?

As long as I'm getting the source path of all dependencies, including
local path dependencies and local overrides, I'm fine for my use case.

In terms of format, I think it should probably default to the Cargo standard of TOML but also be configurable to other formats like JSON or perhaps just some textual encoding. I wouldn't be too worried about that, however.
In terms of what data this should provide, I think that basically exposing the standard structures of Package and such are probably sufficient (e.g. exporting a subset of their fields), and then we may want to provide various stages for example metadata of the current package before resolution and then metadata after resolution (to include dependencies).
https://github.com/rust-lang/cargo/pull/1434 seemed pretty promising to me but it unfortunately stalled :(

I will try update #1434 then

@alexcrichton am I correct that read-manifest and metadata should be two separate commands? They seem pretty similar in scope. May be we should use a single command with different flags?

Yeah I think it's fine to start a new metadata command from scratch. I'd be fine deprecating read-manifest as well eventually in favor of just one command if it comes to that as well.

@alexcrichton any progress on this? It really impedes us introducing fully-fledged Cargo's projects support in https://github.com/intellij-rust/intellij-rust.

Indeed! @matklad is doing some awesome work over in #2196 to add this command.

(any suggestions about what sort of output you'd like to see would also be quite welcome!)


can't add pictures to the article, I tried almost everything

Dear production team, thank you very much for your development,
I set up my blog in just a few hours, but I now have a big problem: I can't add images to posts, and I've tried almost everything.
At first I tried to write the absolute path to the file to add the image, but the load failed. Later, I downloaded the plug-in hexo-asset-image and put the image in the folder of the same name, but it still failed to load. I also tried to add a network connection, but it still failed. I think I added the way should be right, but why no pictures.
!

Sorry for the late reply. If you are a beginner, I recommend using absolute URLs starting with http to insert images. This way, as long as you can ensure that the image link can be opened through a browser, it can also be loaded in your blog post.


Fix trailing slash in the github.com/go-bindata/go-bindata/v3/go-bindata module tool

Description of the change:
Update the tools.go and remove the trailing slash in the
github.com/go-bindata/go-bindata/v3/go-bindata module.
When attempting to run make vendor from the root repository, the
following error is produced:
$ make vendor
go mod tidy
warning: ignoring symlink /home/tflannag/go/src/github.com/operator-framework/operator-lifecycle-manager/deploy/ocp/manifests/latest
warning: ignoring symlink /home/tflannag/go/src/github.com/operator-framework/operator-lifecycle-manager/deploy/upstream/manifests/latest
github.com/operator-framework/operator-lifecycle-manager imports
	github.com/go-bindata/go-bindata/v3/go-bindata/: malformed import path "github.com/go-bindata/go-bindata/v3/go-bindata/": trailing slash
make: *** [Makefile:176: vendor] Error 1

After after removing the trailing slash, updating the vendor tree was
successful:
$ git diff tools.go
diff --git a/tools.go b/tools.go
index 387556b9..949acdc9 100644
--- a/tools.go
+++ b/tools.go
@@ -3,7 +3,7 @@
 package tools

 import (
-       _ "github.com/go-bindata/go-bindata/v3/go-bindata/"
+       _ "github.com/go-bindata/go-bindata/v3/go-bindata"
        _ "github.com/golang/mock/mockgen"
        _ "github.com/googleapis/gnostic"
        _ "github.com/maxbrunsfeld/counterfeiter/v6"

$ make vendor
go mod tidy
warning: ignoring symlink /home/tflannag/go/src/github.com/operator-framework/operator-lifecycle-manager/deploy/ocp/manifests/latest
warning: ignoring symlink /home/tflannag/go/src/github.com/operator-framework/operator-lifecycle-manager/deploy/upstream/manifests/latest
go mod vendor
warning: ignoring symlink /home/tflannag/go/src/github.com/operator-framework/operator-lifecycle-manager/deploy/ocp/manifests/latest
warning: ignoring symlink /home/tflannag/go/src/github.com/operator-framework/operator-lifecycle-manager/deploy/upstream/manifests/latest

Motivation for the change:
Unable to successfully update the root modules when running any go mod * command.
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /docs
[ ] Commit messages sensible and descriptive

/retest

/approve
sometime soon we should bump to 1.16 and remove bindata

No need to respin extra clusters for this kind of change.
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-aws-olm


Chore/store formatter in project

Regarding sonar check: due to the reformatting, a lot of stuff counts as "changed", but I didn't actually change anything on a functional level ;)


chore(main): release pixels 0.3.2

:robot: I have created a release beep boop
0.3.2 (2024-04-16)
Bug Fixes

pixels: export modalSizeOptions in Modal (85112e5)
pixels: export tooltipPlacementOptions in Popover (5589aef)
pixels: fix indes of Tooltip (725ff9f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/fuf-stack/uniform/releases/tag/pixels-v0.3.2 :sunflower:


us-ia

not sure how useful, but there is data here.
https://iowagisdata.org/

Seems to contain address data from some counties, but terms explicitly prohibit dissemination when obtained from this site.  Since Iowa seems to be fairly well represented, I'm closing this.


[SMALLFIX]Add javadoc for the functions in DefaultAlluxioMaster.java

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14229/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14269/
Test PASSed.

Merged build finished. Test PASSed.


Limit the number of inflight datacollector requests

I meant to comment but not approve yet.

@srenatus do you know which ones specifically? I can take a look

components/ingest-service/test/ the stuff tested here, /events/chef/run etc

i cant find any reference to those in the docs. double checking with the data collection peoples


Check status page styling is wrong

Looks like the graph styling is wrong. The legend colors are also wrong.

@russorat is this still a thing?

fixed


ERROR "No provider for TooltipController"

Describe the bug
When the app load a page where a tooltip directive is used, the following error happens:
Error: Uncaught (in promise): Error: StaticInjectorError(AppModule)[Tooltip -> TooltipController]: StaticInjectorError(Platform: core)[Tooltip -> TooltipController]: NullInjectorError: No provider for TooltipController!

I suspect I'm doing something wrong but I cannot identify what it is. Having a look at the example project didn't help me to sort out this.
Thanks for help!
To Reproduce

install the directive (I'm using v3 because of Ionic v3)
npm i ionic-tooltips@3 --save
add module to app.module.ts

import { TooltipsModule } from 'ionic-tooltips';
...
  imports: [
   ...
    IonicModule.forRoot(MyApp),
    TooltipsModule,
    ...

add a tooltip directive on any html element of the page:

...
<img tooltip='sample text' [event]='hover'/>
...

Expected behavior
When the app is run and the page is displayed, the text "sample text" is displayed if I move the mouse cursor on the image
Desktop (please complete the following information):

OS: macOS 10.12.4
Browser Safari
Version 12.0,.3
Angular Version: 5.2.11

UPDATE
If I add TooltipController to the list of providers in app.module.ts, the error goes away:
import { TooltipsModule, TooltipController } from 'ionic-tooltips';
...
  imports: [
   ...
    IonicModule.forRoot(MyApp),
    TooltipsModule,
    ...
  ],
  providers: [
   ...
    TooltipController,
   ...
  ]

Why is this not present in the example project?

You need to import it in your app.module.ts as TooltipsModule.forRoot()

thanks @ihadeed for this, if it is the fix indeed it should be applied to the example project too, right?


Endpoint allocation can get stuck some times

This code in ApplicationExecutor.CreateServicesAsync should have a timeout to either fail or at least log a message that it is still waiting on address allocation for some services, and list those services.
https://github.com/dotnet/aspire/blob/93a1efbc4d8798903828eb5da7ffb50b873dc513/src/Aspire.Hosting/Dcp/ApplicationExecutor.cs#L826-L845
This was hit in running Aspire.EndToEnd.Tests where 1/20 runs fails where it gets stuck waiting for a service to get allocated.

In the above run it is stuck waiting for `redis`, till the test infrastructure times out after 5 minutes.
Full log. And corresponding dcp logs are here in logs/dcp-diag-logs, and the corresponding build.
Note that this is not specific to redis.
cc @karolz-ms @eerhardt

CC @dbreshears @danegsta
In a way similar to what @mitchdenny has done, we should probably retry this watch a few times before timing out. Alternative (or last-ditch effort, we could do both) could be to explicitly query the remaining resources and see if they have the address information we are looking for.