Application takes a long time to close now

Testing #150753
When I just launch and then quit VSCode, I see the black dot on the dock for quite some time. I have launched from CLI:

Yeah, running with --verbose:
[main 2022-05-31T11:23:19.172Z] Extension host with pid 80858 did not exit within 6000ms.

This is a side effect of how we gracefully shutdown the utility process, previously the extension host was responsible for shutting itself down and we block the main process exit based on it https://github.com/microsoft/vscode/blob/45818d7c31c73dafc08e9ef3dbbdba502f8c1879/src/vs/platform/extensions/electron-main/extensionHostStarter.ts#L60
Utility process lifetimes are controlled by the main process, (i-e) on graceful shutdown of the application the main process will first try to quit the main message loop and the applications have a chance to block this exit based on will-quit, before-quit event listeners and we use that today to provide chance to shutdown our services https://github.com/microsoft/vscode/blob/45818d7c31c73dafc08e9ef3dbbdba502f8c1879/src/vs/platform/lifecycle/electron-main/lifecycleMainService.ts#L243-L302 and once message loop is good to exit, the main process will cleanup C++ handles to the JS objects https://github.com/electron/electron/blob/16db5a112e3cde7d9ee8ea817f52bf2b9af7568f/shell/browser/electron_browser_main_parts.cc#L510-L530 and only during this phase I also shutdown the running utility processes gracefully which will emit the exit event, after that the node environments, child process and threads in the main process will get shutdown one after other eventually exiting the main process itself.
So what we are currently seeing is a chicken and egg problem, where the main message loop exit is blocked for 6s by the extension host exit, but the extension host exit is blocked on exit event from the main message loop.
Solution:
The runtime can only cleanup the utility process once the main message loop is ready to exit, if the exit is blocked on the application end it is not possible to know when to gracefully shutdown the process from the runtime side. Thoughts ?

@deepak1556 The extension host processes should exit by themselves when the MessageChannel is closed. My intuition here is that the exit event might not be firing on the UtilityProcess instance, but I need to debug it to confirm.

Ah yeah, I currently don't emit the exit event when MessageChannel gets disconnected however the process does exit.


First public release of promise type scl_docker_compose

Thank you for submitting a PR! Maybe @olehermanse can review this?

@basvandervlies Thank you for submitting this. Is there a reason to put scl in the name here? Does it rely on the SCL or is it otherwise very custom to something you are doing? If not, I'd suggest dropping this part in both the module name and promise type name.

@nickanderson did it worked for you?  If not then we have o fix the issues before merging! At our site it works as expected bu we are running:

debian 11
docker compose version v2.15.1

There are plenty of docker compose files, maybe a simple hello world would be nice that is public available, eg:

https://github.com/docker/awesome-compose/tree/master/flask-redis

Thanks I read it and still had the impression that it did not worked as expected ;-)

How many approvals must I have before it is merged or is it still tested?

You got the approvals but no one merged it until now.


[stable/newrelic-infrastructure] Update ClusterRole/DaemonSet

ping @rk295
What this PR does / why we need it:
Update ClusteRole/DaemonSet for the newrelic-infrastructure chart to match the one from the public NewRelic documentation:
https://download.newrelic.com/infrastructure_agent/integrations/kubernetes/newrelic-infrastructure-k8s-1.0.0-beta2.4.yaml
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Without the nodes/metrics k8s API permission, I was getting the following error from the newrelic pod even with v1.0.0-beta1.0:
Non-recoverable error group: error querying Kubelet. error requesting cadvisor metrics endpoint. error calling prometheus exposed metrics endpoint. Got status code: 403
It works beautifully now:
❯ kubectl logs newrelic-infrastructure-cx2kf
time="2018-07-09T23:17:26Z" level=info msg="Using Display Name: ip-10-0-4-115.ec2.internal"
time="2018-07-09T23:17:26Z" level=info msg="New Relic Infrastructure Agent version 1.0.912 Creating Service (372.016µs)"
time="2018-07-09T23:17:26Z" level=info msg="Agent service manager started successfully. (402.889µs)" service=newrelic-infra
time="2018-07-09T23:17:26Z" level=info msg="New Relic Infrastructure Agent version 1.0.912 Initializing (555.85µs)"
time="2018-07-09T23:17:27Z" level=info msg="New Relic Infrastructure Agent version 1.0.912 Running (597.134914ms)"

@costimuraru LGTM, its good to bring it line with the official resource definition.  I wonder if we should wrap the CADVISOR_PORT env var (I notice you left it out) in a conditional to support versions <1.7.6? A helper function could determine if we are running on a specific version. See here for an example of such a function.
Also it be good to optionally let the chart user provide the KUBE_STATE_METRICS_URL incase they do not wish for the agent to auto discover?

Thanks @rk295 for great feedback!
I've added the conditional CADVISOR_PORT env var.
It's also now possible to setup the desired KUBE_STATE_METRICS_URL

Super trivial comment above on the values.yaml otherwise fine.  I don't have merge privs, so we'll have to wait for one of the admins to come along.
BTW, have you signed the CLA?

Hey @rk295, yes I've signed the CLA. I can't seem to be able to see the comment on values.yaml.

On the kubeStateMetricUrl bit I just said:

Maybe explain it has to be in the format http://thing....

Good point!
Added the comment now :D

I believe the work here is done now.
@unguiculus would be able to us with the PR merge?

Pods starting with the latest NewRelic agent:

Data is reaching the NewRelic infrastructure page (https://infrastructure.newrelic.com)

Thanks @unguiculus
I've also updated the README (https://github.com/costimuraru/charts/blob/patch-1/stable/newrelic-infrastructure/README.md)

/ok-to-test

/lgtm


[Bug] Removing a workspace by name accidentally removes the workspace at the current directory

Removing a workspace by executing :WorkspacesRemove WS_NAME, sometimes removes the workspace with the path to the current working directory.
The bug seems to be at line 293 in remove_workspace_or_directory
https://github.com/natecraddock/workspaces.nvim/blob/a6fb4995333f927cc6f707890800fa7f7c476043/lua/workspaces/init.lua#L291-L314

path is set to current working directory even if name is not nil
find returns a workspace whose path matches the current working directory
The wrong workspace gets removed

Proposed fix:
Change line 293 to
local path = (not name and cwd()) or nil

Nice catch! Thanks for looking into this, and for providing a fix. I tested it locally and it works great. I just pushed a commit to resolve this!


NFL db update on Anaconda help

Hi all. I'm not sure if this is an issue, or if I just messed something up. I have successfully gotten the nflbd-update to run in the past with just a python 2.7 install, but I have since moved everything over to an Anaconda install (for a variety of reasons).
Now, I can't get the update script to run, however I can run an execute other scripts, such as the example ones in the install guide. When I try to run the update-nfldb script, this is the error I get:
(Python 2.7) C:\Users\afhar\Anaconda3\Scripts>python nfldb-update
Traceback (most recent call last):
File "nfldb-update", line 5, in
import nfldb.update
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\site-packages\nfldb\update.py", line 15, in
import nflgame
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\site-packages\nflgame_init_.py", line 97, in
import nflgame.game  # noqa
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\site-packages\nflgame\game.py", line 12, in
import nflgame.sched
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\site-packages\nflgame\sched.py", line 47, in
games, last_updated = _create_schedule()
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\site-packages\nflgame\sched.py", line 40, in _create_schedule
year, week = nflgame.live.current_year_and_week()
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\site-packages\nflgame\live.py", line 115, in current_year_and_week
_update_week_number()
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\site-packages\nflgame\live.py", line 358, in _update_week_number
dom = xml.parse(urllib2.urlopen(_CUR_SCHEDULE, timeout=5))
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\xml\dom\minidom.py", line 1918, in parse
return expatbuilder.parse(file)
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\xml\dom\expatbuilder.py", line 928, in parse
result = builder.parseFile(file)
File "C:\Users\afhar\Anaconda3\envs\Python 2.7\lib\xml\dom\expatbuilder.py", line 207, in parseFile
parser.Parse(buffer,0)
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 12, column 38
Can someone help shed some light as to what I need to do to move past this?

I'm having this same exact issue. Were you able to solve this? I did see someone mention switching out the url in live.py. That did seem to help a bit, but still seeing plenty of results like this.


[zh] sync /concepts/policy/_index.md

Sync with en #41351:
content/zh-cn/docs/concepts/policy/_index.md

See preview please.

/approve


DBZ-2543 Document Oracle OpenLogReplicator adapter

https://issues.redhat.com/browse/DBZ-2543
Documentation for PR #4719

Thanks @roldanbob, I've applied this initial set of edits locally. Let me know when you have the next round of edits for me.


Nc readme cleanup

@nehaagrawal, @manoj-rath  Please review the Readmes and provide your feedback. On completion of review, I will extract topics into wiki and refactor common aspects.

Closing this PR and abandoning it in favor of new PR to dev branch


[FLINK-5108] Remove ClientShutdownHook during job execution

This patch simply removed ClientShutdownHook  related code. The changes may cause org.apache.flink.yarn.YarnClusterClient#pollingRunner be brutely stoped by processing exit, but it seems ok because the polling runner thread is a daemon thread.

Thanks for the PR! This removes the shutdown hook after the cluster has been deployed. The original intend was to remove it only after job submission. Probably it makes sense to remove it all-together. I have to think about it.
Perhaps @rmetzger could comment on this as well.

What speaks against not having a shutdown hook at all?

I think the original intend of the Client shutdown hook was to make sure that clusters which are spawned and didn't receive jobs are cleaned up again. However, that behavior can be quite tricky because a job might actually have been submitted externally. So +1 for removing it altogether.

I will go ahead and merge this PR since there have been no further comments.

+1 for that approach

There is one problem we overlooked. In detached mode we ensure cluster shutdown through a message sent by the client during job submission to tell the JobManager that this is going to be the last job it has to execute. In interactive execution mode, the user jar can contain multiple jobs; this is mostly useful for interactive batch jobs. Since we just execute the main method of the user jar, we don't know how many jobs are submitted and when to shutdown the cluster. That's why we chose to delegate the shutdown to the client for interactive jobs. Thus, I'm hesitant to remove the shutdown hook because it ensures that the cluster shuts down during interactive job executions. It prevents clusters from lingering around when the client shuts down.
A couple of solution for this problem:

The JobManager watches the client and shuts down a) if it looses connection to the client and the job it executes has completed or b) the client tells the JobManager to shut down.

The JobManager drives the execution which is now part of the client

We don't allow multiple jobs to execute. Then we always have a clear shutdown point. This is perhaps the easiest and most elegant solution. Most users only execute a single job at a time anyways. We can still allow interactive job executions if the user chooses to. Perhaps we can make this more explicit in the API to give a hint to the client.

I'm afraid we will have to close this PR until we realize one of the above solutions (or another one).

That is ok to close this issue.
Max<EMAIL_ADDRESS>02:31写道：

There is one problem we overlooked. In detached mode we ensure cluster
shutdown through a message sent by the client during job submission to tell
the JobManager that this is going to be the last job it has to execute. In
interactive execution mode, the user jar can contain multiple jobs; this is
mostly useful for interactive batch jobs. Since we just execute the main
method of the user jar, we don't know how many jobs are submitted and when
to shutdown the cluster. That's why we chose to delegate the shutdown to
the client for interactive jobs. Thus, I'm hesitant to remove the shutdown
hook because it ensures that the cluster shuts down during interactive job
executions. It prevents clusters from lingering around when the client
shuts down.
A couple of solution for this problem:

The JobManager watches the client and shuts down a) if it looses
connection to the client and the job it executes has completed or b) the
client tells the JobManager to shut down.
2.
The JobManager drives the execution which is now part of the client
3.
We don't allow multiple jobs to execute. Then we always have a clear
shutdown point. This is perhaps the easiest and most elegant solution. Most
users only execute a single job at a time anyways. We can still allow
interactive job executions if the user chooses to. Perhaps we can make this
more explicit in the API to give a hint to the client.
I'm afraid we will have to close this PR until we realize one of the above
solutions (or another one).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/flink/pull/2928#issuecomment-266821189, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOaHWUdCSBcw2gbqsaa5Vmodgp7rHNwks5rHuR2gaJpZM4LDU92
.

Thanks for your understanding :) Could you please close this PR?


Fix UI

Summary of the Pull Request
What is this about:
Missing/wrong UI elements.
What is included in the PR:
A tiny bugfix.
How does someone test / validate:
Complie the code and open the window.
Quality Checklist

[x] Linked issue: #18748 #18752 #18753
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

Wait, are we still using Segoe MDL2 instead of Segoe Fluent in FancyZones Editor?

Wait, are we still using Segoe MDL2 instead of Segoe Fluent in FancyZones Editor?

Fluent isn't installed (by default) on Win.10 - I think we should use SystemIconFont everywhere. Waiting on input from Niels.

Emm
Then how could we merge it?
Sorry, but this is my first time to create a pull request to contribute to a repository.


express.static ignore files containing dots in names

I have the very basic express server which serves static files from the public folder:
app.use(express.static(path.join(__dirname, '../public')))
app.use('/api/v1', routes(router))

app.listen(PORT, () => {
  console.log(`Server is up and running on port ${PORT}...`)
})

index.html file in that public folder has the following content:

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <meta http-equiv="X-UA-Compatible" content="ie=edge">
  <title>The Royal Game of Ur</title>
  <link rel="stylesheet" href="/src.e31bb0bc.css">

And that leads to the following errors in console:
Refused to apply style from 'http://localhost:3000/src.e31bb0bc.css/' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.
GET http://localhost:3000/src.e31bb0bc.js/ 404 (Not Found)

However when I rename src.e31bb0bc.js and src.e31bb0bc.css files to srce31bb0bc.js srce31bb0bc.css accordingly and change paths in index.html to match new names, files are served as expected.

Sorry guys, that's fault of cache in chrome.


Gracefully shutdown prometheus exporter

Release Note

Gracefully shutdown the Prometheus metrics exporter when the server shuts down. This only applies if the Prometheus metrics exporter is enabled (it's off by default). This fixes a low probability issue that some metrics may be lost during shutdown.

FWIW, this doesn't completely eliminate the possibility of metrics loss, but it reduces it. We're still triggering the shutdown in a goroutine, which doesn't block shutdown.

FWIW, this doesn't completely eliminate the possibility of metrics loss, but it reduces it. We're still triggering the shutdown in a goroutine, which doesn't block shutdown.

I lied - I moved it inline so this will catch all cases.


test case name's length limitation-DBT

Affected module
Does it impact the UI, backend or Ingestion Framework?
Ingestion(it may impact the UI and backend)
Describe the bug
A clear and concise description of what the bug is.
we're using OM 1.2.3 to parse DBT manifest/run_result/catalog.json,
our test case's name is very long, like 'assert_stg_fact_pnl__regular_channel_storage_fee_regular_storage_fee__equal__channel_storagee_fee_all_storage_fee_daily_where_fee_type_is_regular', and there is 145 charaters.
To Reproduce
create a singular test case in DBT, naming it more than 128 characters.
then create an ingestion to get it, and you'll encounter the error
Expected behavior
OM can handle the long name test cases
Version:

OS: Ubuntu 18.04.6 LTS
Python version:
OpenMetadata version: 1.2.3
OpenMetadata Ingestion package version: 1.2.3

Additional context
the log is here
[2024-01-03T05:43:05.244+0000] {metadata.py:912} ERROR - Failed to capture tests results for node: assert_stg_fact_pnl__fcst_channel_storage_fee_product_id_and_channel_id__not_in__regular_channel_storage_fee Entity already exists
[2024-01-03T05:43:05.245+0000] {topology_runner.py:94} DEBUG - Processing stage: type_=<class 'metadata.generated.schema.api.tests.createTestDefinition.CreateTestDefinitionRequest'> processor='create_dbt_tests_definition' context=None nullable=False must_return=False cache_all=False clear_cache=False overwrite=True consumer=None cache_entities=False use_cache=False
[2024-01-03T05:43:05.245+0000] {metadata.py:753} DEBUG - Processing DBT Tests Definition for node: assert_stg_fact_pnl__regular_channel_storage_fee_regular_storage_fee__equal__channel_storagee_fee_all_storage_fee_daily_where_fee_type_is_regular
[2024-01-03T05:43:05.262+0000] {status.py:65} WARNING - Failed to parse the node to capture tests 1 validation error for CreateTestDefinitionRequest
name -> __root__
  ensure this value has at most 128 characters (type=value_error.any_str.max_length; limit_value=128)

@TeddyCr we can increase the limitation to 256 characters
@chirag-madlani we should look at if the UI works with longer names

@ShaileshParmar11 Please help here if needed, Thanks

After increasing the limit to 256 the test names are getting ingested correctly.
Attaching some screenshots of long name test cases. Image 1 and 2 looks good IMO, in 3rd image name goes out of screen
cc: @ShaileshParmar11 @pmbrull


Make taxonomy table view

Overall goal is to show the categories from the taxonomy, whatever other detail there is

Use the table component that exists and is being used on the projects page
The API endpoint already exists
Add a route with React Router
Make a new "page" (take a look at the projects page)

@giosce have done some work on this in https://github.com/codeforamerica/civic-tech-taxonomy/tree/master/tools/editor-ui
It is likely possible to fetch and display data in a similar way but using something more TS/React compatible (perhaps there is a convenient snyk/npmtrends comparison of different trees compatible with react).
A suggestion would be to have a new page called "Taxonomy" preliminarily displaying,

Display a tree of already categorized topics
Display (a list?) of uncategorized topics
Maybe display a list of all topics?

I'm suggesting that we include the Taxonomy Issues and Priority Areas in two additional filtering dropdowns.
This API returns the Issues with associated tags (topics) https://api.taxonomy.sandbox.k8s.brigade.cloud/taxonomy?category=issues
Similarly there will soon be https://api.taxonomy.sandbox.k8s.brigade.cloud/taxonomy?category=priority-areas
We are still discussing if it is better to do the mapping in the A) back-end (crawler) or B) front-end.
In either case, use this API to populate the dropdown
A) The dropdown behind the scene sends the topics associated to the Issue to the filterbytopics function
B) we build a filterbyissue function which will filter on the issue part of the project object (as it comes from back-end)

As of today, added the 2 dropdown as mentioned above (Taxonomy Issues and Priority Action Areas).
A couple of small issues:

Button "Clear" would be nice if it clears these 2 new dropdowns too
If refreshing the page the "Issues" selection is not remembered (I see that also it isn't in address bar as query param)

@mmazanec22 can you let us know what do you intend with this issue?


Windows 10x64 Templates Fail to Boot with Windows 1709 on High Sierra

Both the VirtualBox and VMWare sections will fail to load the downloaded ISO (they hang at the blue Windows logo.)   To make this work, I had to specify specific hypervisor options for each hypervisor:
For VMWare I had to specify:
"version": "12",
For VirtualBox:
"vboxmanage": [
...
[
"modifyvm",
"{{.Name}}",
"--paravirtprovider",
"kvm"
]
]
I don't have a Parallels Hypervisor to test.
The default options for either didn't work for Windows 10 1709.

Please, i testing...

I'm testing this right now. It seems that the windows 10 installers have some other issue as well that I might as well track down too. Fortunately if it's simply a hw_version issue for the vmware-iso builder, then we can simply bump the default value to 12.

Did PR #247 affect this at all for you? (It's been merged already, so you just need to retry)

Due to the lack of response on this issue, I've tagged it as stale and thus it will be closed in a month. If you feel this is in error, let me know and I'll untag.

Closing this issue as it has gone stale due to a lack of interaction that has extended to almost a year. If you feel this is in error, please let me know and I will re-open.


fix: npmlog block publish VS Code Extension

Codecov Report

Merging #77 into master will decrease coverage by 0.07%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   78.88%   78.81%   -0.08%
==========================================
  Files          26       25       -1
  Lines         966      958       -8
  Branches      198      197       -1
==========================================
- Hits          762      755       -7
+ Misses        200      199       -1
  Partials        4        4

Impacted Files
Coverage Δ

packages/generate-project/src/index.ts
89.65% <50.00%> (+2.98%)
:arrow_up:

packages/ice-npm-utils/src/index.ts
87.96% <50.00%> (-0.18%)
:arrow_down:

packages/generate-project/src/fommatProject.ts
83.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929396a...712d31f. Read the comment docs.


UltraSinger / Python is broken

I really dont know, what the Problem is - but there is some :)

Download the newest Verson of Ultrasinger. Overwrite the old Files. UltraSinger dont work (not starting).
Well, this might be a good opportunity, to start fresh. So i delete UltraSinger, delete also Python3.
DL Python 3.10.0 (on the Python Site, there are also 3.10.9 and 3.10.10 and so on). Installed it.
Start the UltraSinger GPU-Install-Script.
 No Luck. I tried also the Installation via Terminal. Again - no Luck.
And UltraSinger.py doesnt work either:
  File "PATH\src\UltraSinger.py", line 7, in <module>
    import Levenshtein
ModuleNotFoundError: No module named 'Levenshtein'

When i install the missing module via pip, another module is missing. And so on and so on...
the whole Application is broken and i dont know why :/

Had the same problem. Installing C++ Dev Kid helped: https://learn.microsoft.com/en-us/cpp/build/vscpp-step-0-installation?view=msvc-170

I delete everything from UltraSinger, the GIT and other Utils / Tools whatever.
Installed GIT, added to the PATH (running on Windows).
Then Installed the Visucal 2022 (Free Edition).
Installed the C++ Dev Enviroment
DL UltraSinger, start the CUDA GPU bat File.
This worked so far.
Then started a Conversation from a Music File ... and it worked!

I would like to know which py packages these two things need. Visual 2022 (Free Edition) and C++ Dev Enviroment. I have recently adjusted the requirements.txt for pip-compile. Maybe there is an unnecessary package in there now.

Sorry, cant understand how i contribute to this Question... i take the steps, suggesting from Mr. Bockwurst (the best Nickname in ages btw ^-^).
"Had the same problem. Installing C++ Dev Kid helped: https://learn.microsoft.com/en-us/cpp/build/vscpp-step-0-installation?view=msvc-170"
Then it runs. its possible, to collect some "log" Files or something, they show what is installed / downloaded? Cause i cant say, what Ultrasinger was dl 😭

Ok seems matplotlib version 3.9.1 causes the issue.
According to the release notes 3.9.2, the MSVC issue should be fixed.
https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.9.2.html
@Aydonger, @HerrBockwurst can you try and confirm this?
I just updated the requirements.txt

For me i just "changed matplotlib==3.9.1."to "matplotlib==3.9.1.post1" in the requirements.txt :
....
marshmallow==3.21.3
# via dataclasses-json
matplotlib==3.9.1.post1
# via
#   -r requirements.in
#   crepe
#   music21
#   pyannote-metrics
....

Was fixed here:
https://github.com/rakuri255/UltraSinger/commit/b057f2a78dfde6dc8e48a5f7d9eb10a096f628af


plugins_registry vs plugins path

Not sure it's relevant, I just came across and it popped into my eyes...
https://github.com/gluster/gcs/blob/177c50b9f8f53c984e20cada8d4fde7c1cc6f2a0/deploy/templates/gcs-manifests/gcs-fs-csi.yml.j2#L224
I understand https://github.com/kubernetes/kubernetes/pull/70494 as it was only meant for the registration, not for the plugin socket itseff, see:
https://github.com/kubernetes-csi/csi-driver-host-path/blob/c44a77d8a4342e687839ad2d1d8c1aeda7416b27/deploy/hostpath/csi-hostpath-plugin.yaml#L62-L74

/cc @Madhu-1


update web_base.py to have verify option

We propose an enhancement to the web-based loader initialize method by introducing a "verify" option. This enhancement addresses the issue of SSL verification errors encountered on certain web pages. By providing users with the option to set the verify parameter to False, we offer greater flexibility and control.

Who can review?
@eyurtsev

And by adding verify option: you can finally pass in headers such as
headers = {'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36'}
to bypass the SSL verification.


Improve process instrumentation for Java 9

Problem description
This is an improvement on elastic/apm-agent-java#903 (external process execution instrumentation).
Starting from Java 9, there is a new API available for process execution ProcessHandle, which is not covered by #903.
As a result, any usage of this API will not result in spans be created.
Proposed solution
Instrument Process.toHandle() to wrap returned ProcessHandle instance.
Wrapped ProcessHandle should end current process span on those methods

ProcessHandle.destroy()
ProcessHandle.destroyForcibly()
ProcessHandle.onExit() > returns a CompletableFuture which should be wrapped and terminate span

This would also allow to use ProcessHandle.Info and capture program arguments, PID or other attributes.
Alternatively, we could also use CompletableFuture.thenApply(...) to chain a task that will terminate the process span.

As part of #1613 adding support for Java 9 API here would probably allow to detect proper termination of process, hence being able to set the span outcome properly.

As part of #1613 adding support for Java 9 API here would probably allow to detect proper termination of process, hence being able to set the span outcome properly.


See #150

@alexrintt  I was absolutely confused on this issue. This fix is worked perfectly. Thanks a lot brother


lowercasing property types

In the Vue docs, property types are Constructors and thus, all uppercased. From what I can tell, the prop parsing code seems to forcibly lowercase all prop type names; is there any reason for this?

@robcresswell, yes, the main idea its to return similar an ouput like react-docgen
Regards

Fair enough. I kind of think it is a shame to try and match React with a Vue documentation library, at the expense of not matching Vue's own documentation? But it is your library so it is your decision 👍


Header not populating correctly.

The header for the tabcontrols are getting populated with the namespace of the class.
I am passing in a public header string from my view model as well as the viewmodel itself as the object.
The view of the viewmodel it is attached to populates correctly in each tab, but the header is getting messed up.
TabModels.Add(new TabContent(mainWorkQueueViewModel.Header, mainWorkQueueViewModel));
The header when launched is getting displayed with ViewModel.Common.TabContent.
Not sure what is going wrong. In the observable collection the header is not null. It is being populated with "work queue".

I got the same problem, and when I include the dll in the dragablz master sample code instead of the nuget one, the problem solved.

I have the same problem with Caliburn Micro Screens,
<dragablz:TabablzControl x:Name="Items">
	<dragablz:TabablzControl.ItemTemplate>
		<DataTemplate>
			<TabItem Header="{Binding DisplayName}" />
		</DataTemplate>
	</dragablz:TabablzControl.ItemTemplate>
</dragablz:TabablzControl>

My ShellViewModel is a Conductor<IScreen>.Collection.OneActive and I add new Tabs with
var vm = new TabViewModel {DisplayName = "TabName"};
ActivateItem(vm);

to the Items Collection.
TabablzControl ignores the DataTemplate and always shows ViewModel.ToString()
Workaround in TabViewModel:
public override string ToString(){ return DisplayName;}

Me too, I got the same problem and I tried with different dragablz versions, from <IP_ADDRESS> to <IP_ADDRESS> and the last one solve my problem. 😄

I have the same problem with Caliburn Micro Screens,
<dragablz:TabablzControl x:Name="Items">
	<dragablz:TabablzControl.ItemTemplate>
		<DataTemplate>
			<TabItem Header="{Binding DisplayName}" />
		</DataTemplate>
	</dragablz:TabablzControl.ItemTemplate>
</dragablz:TabablzControl>

My ShellViewModel is a Conductor<IScreen>.Collection.OneActive and I add new Tabs with
var vm = new TabViewModel {DisplayName = "TabName"};
ActivateItem(vm);

to the Items Collection.
TabablzControl ignores the DataTemplate and always shows ViewModel.ToString()
Workaround in TabViewModel:
public override string ToString(){ return DisplayName;}
EDIT:
use HeaderMemberPath
<dragablz:TabablzControl x:Name="Items" HeaderMemberPath="DisplayName" />

Thank you thank you thank you!!!


React Native local components imports with @/ seems to fail

Description
Trying to setup an Expo managed workflow project here to use CodePush the cli fails if I use local imports like this  import EditScreenInfo from '@/components/EditScreenInfo'; If I import my local RN components with good old ./ it works. IE, if I change all lines like this  import EditScreenInfo from '../../components/EditScreenInfo'; it works.
Repro Steps

Checkout repo
run npm install
run appcenter codepush release-react -a mgscreativa/ios-expo-code-push-plugin-managed-workflow --deployment-name "Development" --entry-file App.tsx --use-hermes --target-binary-version "1.0.0"

Expected behavior
Bundle created
Details

Is there a particular beacon/command that you are having trouble with?

e.g. appcenter tokens list

Which version of the App Center CLI are you using?

2.14.4

Which OS version did you experience the issue on?

Ubuntu 22.04.1 LTS

What command line/shell are you using?

bash

What version of Node.js and NPM/Yarn are you using?

e.g. node v16.13.1

Additionally, you can provide verbose logs of a CLI command

Running "react-native bundle" command:

node node_modules/.bin/react-native bundle --assets-dest /tmp/code-push202378-13714-1aqtsrk.ef28/CodePush --bundle-output /tmp/code-push202378-13714-1aqtsrk.ef28/CodePush/main.jsbundle --dev false --entry-file App.tsx --platform ios
warn From React Native 0.72, your metro.config.js file should extend'@react-native/metro-config'. Please see the React Native 0.72 changelog, or copy the template at:
https://github.com/facebook/react-native/blob/main/packages/react-native/template/metro.config.js
warn Falling back to internal defaults.
Welcome to Metro v0.76.7
Fast - Scalable - Integrated

error Unable to resolve module @/components/EditScreenInfo from /media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/app/(tabs)/two.tsx: @/components/EditScreenInfo could not be found within the project or in these directories:
node_modules
1 | import { StyleSheet } from 'react-native';
2 |

    3 | import EditScreenInfo from '@/components/EditScreenInfo';
    | ^
    4 | import { Text, View } from '@/components/Themed';
    5 |
    6 | export default function TabTwoScreen() {.
    Error: Unable to resolve module @/components/EditScreenInfo from /media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/app/(tabs)/two.tsx: @/components/EditScreenInfo could not be found within the project or in these directories:
    node_modules
    1 | import { StyleSheet } from 'react-native';
    2 |
    3 | import EditScreenInfo from '@/components/EditScreenInfo';
    | ^
    4 | import { Text, View } from '@/components/Themed';
    5 |
    6 | export default function TabTwoScreen() {
    at ModuleResolver.resolveDependency (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:139:15)
    at DependencyGraph.resolveDependency (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/node-haste/DependencyGraph.js:277:43)
    at Object.resolve (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/lib/transformHelpers.js:169:21)
    at Graph._resolveDependencies (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/DeltaBundler/Graph.js:473:35)
    at Graph._processModule (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/DeltaBundler/Graph.js:261:38)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Graph._addDependency (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/DeltaBundler/Graph.js:372:20)
    at async Promise.all (index 2)
    at async Graph._processModule (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/DeltaBundler/Graph.js:322:5)
    at async Graph._addDependency (/media/martinb/SSD1TB/dev/Proyectos-Full-Stack/react-native-code-push-expo-plugin-managed-workflow/node_modules/metro/src/DeltaBundler/Graph.js:372:20)
    info Run CLI with --verbose flag for more details.
    Error: Failed to release a CodePush update.

Hi @mgscreativa, and thank you for reaching out to us. I've manage to reproduce the error you encountered in your project. Upon investigation, I found that the issue stems from the AppCenter CLI usage of the React Native package during the bundle assembly. Specifically, this error can be replicated by executing the command react-native bundle --platform ios --entry-file App.tsx.
It's important to note that this error is not related to the AppCenter CLI, but rather to the React Native package. As such, I will be closing this issue for now, but if you have any questions, feel free to reopen this issue.


osm namespace add should fail when adding osm-system NS

No! But you know what - we should make sure this errors out really loudly so it does not happen by accident!
Originally posted by @draychev in https://github.com/open-service-mesh/osm/pull/1193#discussion_r459853647

I would like to give this a shot.
I'm assuming we can add a condition in https://github.com/openservicemesh/osm/blob/main/cmd/cli/namespace_add.go#L63-L75 that does the namespace name(osm-system in this case) check.

@Sheshagiri you can get deployments from the namespace and see if there is an osm-controller there. See https://github.com/openservicemesh/osm/blob/main/cmd/cli/install.go#L205

If I understand correctly, this check should not just handle osm-system, but any namespace where osm-controller can be installed. Please take this into consideration, since the namespace where OSM is installed to is configurable.


Current BibTeX hides handle

The current BibTeX export has the handle of the entry in the \url field, which many a \bibliographystyle ignores. This means that, unless the author of a paper is willing to modify the BibTeX by hand, the handle information will not be present in the PDF of the paper. This is bad, as then readers cannot (easily) find the resource, the main ID of the resource is lost, and the authors get less citation and visibility than they could. Furthermore, the name of the resource can be incorrectly capitalised.
The exemplify, I made https://www.overleaf.com/16505840rmymbqmbfyzf where you can check the difference between the exported and "cooked" entry. Note that I have removed double backslashes (cf.  #853) by hand from the exported entry.

The issue is that we cannot influence the style an end user will use for formatting the bibliography. There are styles @misc and urls work with; we should mention those to the user. Also there's @LanguageResource with LREC style; so we might add that.

What we could do, is add some recommendation, like a help message somewhere close to the bibtex citation text. For instance we could say, that URL field works, if you use natbib, for instance with plainnat style in Latex.

add some recommendation, like a help message somewhere close to the bibtex citation text ... and say that URL field works, if you use natbib

The problem here is that people aren't free to choose their BibTeX style, as that is perscribed by the venue.
What I do in my records is add to the BibTeX entry the field note = {\url{http://hdl.handle.net/11356/1329}}. This seems to work just fine with all styles, except that the main .tex file has to use the url package, but that is good practice anyway.
The problem here is that you already use the note for the repository name. I would say that you should use the publisher field for that, or, rather, put the "real" publisher in the publisher field, and just ignore the name of the repository (somewhat bad for our egos, but maybe we can cope:).
So, instead of:
@misc{11356/1329,
 title = {The {CLASSLA}-{StanfordNLP} model for named entity recognition of standard Bulgarian 1.0},
 author = {Ljube{\v s}i{\'c}, Nikola and Osenova, Petya and Simov, Kiril},
 url = {http://hdl.handle.net/11356/1329},
 note = {Slovenian language resource repository {CLARIN}.{SI}},
 copyright = {Creative Commons - Attribution-{ShareAlike} 4.0 International ({CC} {BY}-{SA} 4.0)},
 year = {2020} }

I would suggest:
@misc{11356/1329,
 title = {{The CLASSLA-StanfordNLP model for named entity recognition of standard Bulgarian 1.0}},
 author = {Ljube{\v s}i{\'c}, Nikola and Osenova, Petya and Simov, Kiril},
 publisher = {Jo{\v z}ef Stefan Institute},
 url = {http://hdl.handle.net/11356/1329},
 note = {\url{http://hdl.handle.net/11356/1329}},
 copyright = {{Creative Commons - Attribution-ShareAlike 4.0 International (CC BY-SA 4.0)}},
 year = {2020} }

Note also that I suggest the title is {{...}} rather than having individual words bracketed. In your approach, "CLASSLA-StanfordNLP" will be capitalised correctly, but "Bulgarian" won't.

Tomaz, it seems we are too busy, but if you have tested this and it really works with all the common styles like ACL, APA, etc., it seems like a very useful fix.
Could you guys in Ljubljana try to implement this change and make a pull request? It should not be too hard. I promise we'll look at it then and merge it, hopefuly quickly.

The only hope here would then be @cyplas, but it could we bee that here is still to busy too?


Add a README

How will I possibly know what this project is, why it's cool, how to use it, or how to build it? Please add a README.

I saw you added a README. Please add a better readme.


Styling inside an event fails on deployment

Check that this is really a bug

[X] I confirm

Reproduction link
na
Bug description
I am building a custom calendar which shows a custom event component, which works fine when deployed locally. But when deployed on a server the css styling of the event component is overlapping with each other.
The custom event shows different button based on certain value.
Custom Event Component

const EventComponent = (props) =>
 {
    let readTime = props.event && props.event.secondsRead;
    let txt = "";
    if (readTime == 0) {
        txt = "";
    } else if (readTime < 60) {
        txt = readTime + " Seconds";
    } else if (readTime >= 60 && readTime < 3600) {
        txt = parseInt(readTime / 60) + " Minutes";
    } else {
        txt = parseFloat(readTime / 3600).toFixed(1) + " Hours";
    }
  return (
        <>

                {txt}

            {

                    {(readTime && (readTime / 60) >= 15)
                        ? <CheckCircleIcon fontSize="large" style={{ color: green[500] }} />
                        : (readTime / 60) > 0
                            ? <CheckCircleIcon fontSize="large" style={{ color: yellow[500] }} />
                            : <CancelIcon fontSize="large" color="error" />
                    }
}
        </>
    )
}

Calendar Component
<Calendar

                                localizer={localizer}
                                startAccessor="start"
                                endAccessor="end"
                                style={{ height: 600 }}
                                view='month'
                                views={['month']}
                                events={events}
                                components={{
                                    eventWrapper: EventComponent,
                                    toolbar: CustomToolbar
                                }}
                            />

Screenshot of the bug.

Although when deployed over the server, if I clear my cache it works properly,
Expected Behavior
No response
Actual Behavior
No response
react-big-calendar version
^1.5.0
React version
^16.8.6
Platform/Target and Browser Versions
Windows
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

It's not clear to me what the problem is. How should it look like? Are you sure the problem is in react-big-calendar and not in your deployment? How do you compile the project for deployment?


Potentially Too Strict Judgement on Calculated Result

It seems that the code is using atol=1e-8, rtol=1e-5 to judge whether two results are close enough.
I personally find it too strict sometimes. For example, in problem 35.1, the following code is judged as correct:

def ground_state_wavelength(L, mr):
    '''Given the width of a infinite square well, provide the corresponding wavelength of the ground state eigen-state energy.
    Input:
    L (float): Width of the infinite square well (nm).
    mr (float): relative effective electron mass.
    Output:
    lmbd (float): Wavelength of the ground state energy (nm).
    '''
    # Constants
    h = 6.626e-34  # Planck constant in J*s
    c = 3e8  # Speed of light in m/s
    m_e = 9.109e-31  # Free electron mass in kg

    # Convert L from nanometers to meters
    L_m = L * 1e-9

    # Calculate the effective mass
    m = mr * m_e

    # Calculate the ground state energy E_1
    E_1 = (h**2) / (8 * m * L_m**2)

    # Calculate the corresponding wavelength λ
    lmbd = h * c / E_1

    # Convert the wavelength from meters to nanometers
    lmbd_nm = lmbd * 1e9

    return lmbd_nm

However, the following code is considered to be wrong:

def ground_state_wavelength(L, mr):
    '''Given the width of a infinite square well, provide the corresponding wavelength of the ground state eigen-state energy.
    Input:
    L (float): Width of the infinite square well (nm).
    mr (float): relative effective electron mass.
    Output:
    lmbd (float): Wavelength of the ground state energy (nm).
    '''
    # Constants
    h = 6.62607015e-34  # Planck constant in J*s
    c = 2.99792458e8  # Speed of light in m/s
    m_e = 9.10938356e-31  # Free electron mass in kg

    # Convert L from nanometers to meters
    L_m = L * 1e-9

    # Calculate the effective mass
    m = mr * m_e

    # Calculate the ground state energy E_1
    E_1 = (h**2) / (8 * m * L_m**2)

    # Calculate the wavelength λ
    lmbd = h * c / E_1

    # Convert the wavelength from meters to nanometers
    lmbd_nm = lmbd * 1e9

    return lmbd_nm

These two codes appear to have the same functionality. It seems unfair to give them a different judgement.
Maybe it would be better to change the threshold to 1e-5 or 1e-4.

Thank you for the feedback! We have taken this into consideration. That is the reason why we have defined all of the scientific constants in the problem. For example, as you can see in question 35.1, we stated "Given the free electron mass is 9.109e-31kg, speed of light is 3e8m/s and the Planck constant is 6.626e-34J*s.". When we are doing error analysis for LM generation on SciCode, we conclude this kind of error as "not following instructions".

Thank you for the clarification! Using predefined scientific constants indeed helps ensure consistency in the problem solutions.


Should we honor or ignore cluster.spec.infrastructureReady?

In CAPA for v1alpha1, we added code that prevented any Machine instances (ec2 instances) from being created if the cluster infrastructure (VPC, security groups, etc.) wasn't ready yet.
Now that generating bootstrap data is isolated from provisioning Machine infrastructure, I'm wondering if it would be ok to remove the logic in this repo that prevents generating bootstrap data if cluster.status.infrastructureReady is false. The infrastructure providers should already be gating Machine infrastructure provisioning based on cluster.status.infrastructureReady. WDYT?

@chuckha @fabriziopandini

@ncdc I'm not entirely sure, since in the case of AWS, the load balancer is created as part of the infrastructure and would be needed for generating the bootstrap data.

@detiber true (and @fabriziopandini mentioned it too in #82)... but we could have this repo require cluster.status.apiEndpoints to be valid before continuing (or have the user fill it in manually in the kubeadm config).

@ncdc The potential problem would be is that we would just know that the endpoints are set and not that the shared infrastructure is actually ready to be consumed at that point. I think having an explicit InfrastructureReady field allows the cluster infrastructure provider to have a clear marker to signal to the bootstrapper/machine controller that it is ok to proceed is better than implicitly looking for endpoints.
There are also cases today where the API endpoints are not set by the cluster infrastructure and are instead set by the first Machine that is bootstrapped, which would present issues if we are using it to gate machine bootstrapping.

cluster.spec.infrastructureRef is optional, so we may need to tell users who leave that unset to patch the status to set infrastructureReady to true.

yuck, should we provide an optional noop cluster infrastructure provider that would just set infrastructureReady=true for those use cases?

If we add the spec.defaultInfrastructureProvider field you suggested, that could work, although it would end up creating 1 NoopCluster for each Cluster, which seems unnecessary.
For now, I say we honor and require cluster.status.infrastructureReady based on the arguments made above, and we can deal with optional infraRef elsewhere. WDYT?

sgtm

/close


deepGet fix:add case and fix Bug

original program:
deepGet({a:false}, ['a']); // require return false but return null

Besides,null is so different to undefined, not exist property require to return undefined instead of null.
null stands for exist but has nothing, the value is empty.
undefined stands for undeclared in the object as not exist in it.

Never return undefined for a programmatically empty value, always return null.
The snippet indeed has an issue, we should probably check for emptiness more explicitly instead of implicit checks, which break false.
I still stands on my own opinion!
Please add to 2020 TODO, and talk to other contributors please.

Never return undefined for a programmatically empty value, always return null.
The snippet indeed has an issue, we should probably check for emptiness more explicitly instead of implicit checks, which break false.

I still stands on my own opinion!
Please add it to 2020 TODO, and talk to other contributor please.


Empty statement of facts

for sexual assault case, if the basis is a past conviction, it's possible to have a blank statement of facts
Petition for Personal Protection Order Non-Domestic Sexual Assault - CC 395 (42).pdf

Note, this should not be an issue for the other two PPO types because they will always have at least one "incident" in the statement of facts.


Review Tab Panel

My tab panel pretty much made it to the repo without any actual reviews. I’d appreciate if either of you would give it a look to make sure I’m not doing random crap.

Big Stuff:
The element isn't currently using ARIA correctly. See the Roles, States, and Properties section of the ARIA Authoring Practices Guide. Also, make sure to do a pass with something like VoiceOver to see if it's announcing things properly. Usually VoiceOver will announce the role which can be an indicator if things are working as expected.

The <dash-tab-panel> should self apply role=tablist. It may be better to rename this outter element to <dash-tabs> or <dash-tablist> to match its ARIA role.
Element and demo use aria-role= but it should be role=
Currently you say aria-controls="tab1" but it could be better expressed as aria-controls="panel1" since a tabis really thought of as controlling atabpanel`.
Each element with role tabpanel should have an aria-labelledby referring to its associated tab element.

Compare the difference in VoiceOver output (shown in black box at the bottom) when correct ARIA is used
Before:

After:

Smaller Stuff:

https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L7 You don't need aria-hidden if something is display: none because display: none removes it from the a11y tree. Also you might reword this to say something like "inactive panels are hidden with display none" since the next section talks about selection. Otherwise it may not be clear that the two concepts are related.
This opening section initially confused me https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L14-L21. I wasn't sure which element was going to be a tab or a panel or a tabpanel. I had to look at the demo to figure it out.
I would remove this comment https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L30-L31. It's not really for accessibility, it's just for general usability that the element must handle the keyboard and mouse.
You don't need to bind to this https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L32-L33. this will always refer to the TabPanel instance because of how you've added the listener. Also you may want to add those listeners in connectedCallback so you can remove them in disconnectedCallback.
https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L44-L45 should be role=
Style nit: https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L47 I usually do if (!tabs.length). @notwaldorf do you prefer one approach to the other?
https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L62 Maybe rename e to element? or something more descriptive
https://github.com/GoogleChrome/dash-elements/blob/master/elements/dash-tab-panel/dash-tab-panel.js#L73-L74 should be role=

Personal Opinion Stuff:
I'd be curious to see if it's possible to build the entire structure out of custom elements, something like:
<dash-tabs>
  <dash-tab></dash-tab>
  <dash-tabpanel></dash-tabpanel>
</dash-tabs>

You could do some (possibly weird 😄 ) things for PE like give the tab a role=heading explicitly in markup, but then that gets swapped out with role=tab when the element upgrades. The more I think about this the more I kinda like this idea. It seems to dovetail well into the PE use case because it's saying "if JS doesn't load, this thing's role is something more basic, but if js does load, it's new role is more advanced". Most importantly it gives the user a signal that the thing is now keyboard interactive.


manual open not working

The
$('.menu').slicknav('open');
is not working in 1.0.4
but works in 1.0.0.

@ribeiroi, I just tested on the latest code and it is working for me. Can you please link to a jsfiddle, codepen or similar that exhibits this issue?


Pull Request Review

I created a pull request. Fix MySql migration data types. #7
Maybe you like to review it. I could not add reviewers.

We've merged your PR request, thank you for contributing to the repository!


some absolute elements dont declare left attribute, in some context the layout will crash

Could you provide a JSFiddle showing the problem? (starting from this one if you want http://jsfiddle.net/pq7yr6d6/)

http://jsfiddle.net/hbff1om5/1/ i distract some of my src to reproduce the case

Fixed by b405f126b425f


Notes on a building FFmpeg and a PyAV wheel for win32

Today I did a full build of FFmpeg and PyAV on Windows 10, 32-bit.  Here are some notes on my experience.  My goal wasn't to fix the build, but to just get through it.  Hopefully this will be of some help.
System Setup

Set up my system with python 2.7.11 from Python.org.  Added "C:\Python27;C:\Python27\Scripts" to PATH

pip install wheel Cython

Installed MinGw, and set up mys environment. Added "C:\MinGW\bin;C:\MinGW\msys\1.0\bin" to PATH

Installed Git for windows,  Added "C:\Program Files\Git\bin" to PATH

To prepare for ffmpeg build, there were some pre-requisites: pkg-config.exe, liglib-2.0-0.dll, and intl.dll.  I followed the instructions here: http://www.gaia-gis.it/spatialite-3.0.0-BETA/mingw_how_to.html#pkg-config

First of all, you must download pkg-config.exe from GTK+ for Windows.
Then you can simply unzip this downloaded zip-file, and then copy the pkg-config.exe executable into /MinGW/bin
That's not enough: this executable depends on the GLib DLL.
So you must download GLib DLL too, always from GTK+ for Windows.
Once again, you have to unzip this downloaded zip-file, and then copy liglib-2.0-0.dll into /MinGW/bin
You have not yet finished: pkg-config still has an unresolved DLL dependency.
But this time simply performing a trivial copy will suffit. So you must now open an MSYS shell:
cd C:/MinGW/bin
cp libintl-8.dll intl.dll
And this time that's really all: now you have pkg-config properly installed and ready to work.

Also needed yasm for ffmpeg build.  I got it here: http://www.tortall.net/projects/yasm/releases/yasm-1.3.0-win32.exe  I renamed it to yasm.exe, and copied it to C:/MinGW/bin

Building FFmpeg 2.8.6

I first tried v3.0, but it failed to build, so I went to the previous: ffmepg-2.8.6 Download here: https://ffmpeg.org/download.html#releases.  Unpack and open a shell in the source root.
Build it:

./configure --enable-shared
make
DESTDIR=./build make install

Building PyAV package

Set the pkg-config env var:

set PKG_CONFIG_PATH=C:\path\to\ffmpeg-source\build\usr\local\lib\pkgconfig

Note: if you're doing the build in an msys shell: export PKG_CONFIG_PATH="C:\path\to\ffmpeg-source\build\usr\local\lib\pkgconfig"

I ended up having to fiddle with the setup.py file, since the pkg-config setting didn't seem to take

Edit No. 1 .in setup.py Edit extension_extra dict  to point to paths where ffmpeg is installed
'include_dirs': ['include', 'C:\\path\\to\\ffmpeg-source\\build\\usr\local\\include'],
'library_dirs': ['C:\\path\\to\\ffmpeg-source\\build\\usr\\local\\lib'],

Edit No. 2 Comment out a few other lines in setup.py:
# 'avformat_open_input': ('function', True),
# 'AVStream__index': ('member', True),

Copy the dlls from C:\path\to\ffmpeg-source\build\usr\local\bin to av folder
Copy the C:\Mingw\bin\libgcc_s_dw2-1.dll  to av folder
Copy C:\Mingw\bin\pthreadGC2.dll  to av folder (renamed to libwinpthread-1.dll)  (not sure if this is right?)
Copy C:\Mingw\bin\libiconv-2.dll  to av folder
There was a line in the makefile mv *.pyd av that I had to pre-pend with a '-' to keep it from generating an error.
Do the build:

make build-mingw32
make wheel

I found that the DLLs in the av folder didn't get put into the wheel file, so I added them, manually, by adding ".zip" to the end of the .whl file, and opening it in windows explorer, and dropping in the missing DLLs in to the av folder. Rename file to end in .whl
Whew!
link to the wheel file is here: https://drive.google.com/open?id=0BwcYeKKuUtN2RWg5NHc4RUZOd0E

As of PyAV 8.0.0, binary wheels are provided which will greatly simplify installation and should solve your issue.


User Role Mappings seem randomly identified

Description:
We're provisioning users through the API. We keep changing parts of our deployment, and as such, re-deploy to get a fresh slate. We've seen some odd behaviour where the role ID seems to be randomly assigned, we've seen the following:

Define the user common values
OLD       - 1 = Read Only # 2 = Upload Only # 3 = User        # 4 = Admin
NEW       - 1 = Admin     # 2 = Read Only   # 3 = Upload Only # 4 = User
NEW NEW   - 1 = User      # 2 = Admin       # 3 = Read Only   # 4 = Upload Only
NEW NEW NEW - 1 = Admin      # 2 = Read Only # 3 = Upload Only   # 4 = User

This can also be seen in the UI with developer options, when changing the mapping of a user.
Component(s) Affected:

[X] UI
[X] API
[ ] Neo4j
[ ] PostgreSQL
[ ] Data Collector (SharpHound, AzureHound)
[ ] Other (tooling, documentation, etc.)

Steps to Reproduce:

Deploy BHE
Enable developer tools
Create user
Review network traffic for the Payload of the /api/v2/bloodhound-users/
See the request payload, specifically the "roles" identifier [1], [2], [3], [4]
See error at this point

You may have to do multiple deployments to reproduce, we've noticed this change 4 times over the course of a week, however it doesn't seem to occur every deployment.
Expected Behavior:
I'd expect identifiers to be hard-coded and therefore mappable so that automated provisioning tasks can apply a specific role to a user.
Actual Behavior:
The mapping ID seems to randomly change, causing provisioning scripts to have unexpected outcomes (like applying a user with a role id which was Read-Only, Administrator rights).
Screenshots/Code Snippets/Sample Files:
N/A
Environment Information:
Latest in main branch.
Additional Information:
Any additional context or information that might be helpful in understanding and diagnosing the issue.
Potential Solution (Optional):
We've found a current workaround of hitting /api/v2/roles and finding the 'Read-Only' reference, however I still feel like this is a bug/oversight and should be resolved:
def get_ro_role_id(session_token):

    roles_json = make_request('GET', '/api/v2/roles', session_token)
    roles = roles_json.json()['data']['roles']

    ro_role_id = [role['id'] for role in roles if role.get('name') == 'Read-Only']

    return ro_role_id[0]

If you have any ideas about what might be causing the issue or how it could be fixed, you can share them here.
Related Issues:
If you've found related issues in the project's issue tracker, mention them here.
Contributor Checklist:

[X] I have searched the issue tracker to ensure this bug hasn't been reported before or is not already being addressed.
[X] I have provided clear steps to reproduce the issue.
[X] I have included relevant environment information details.
[X] I have attached necessary supporting documents.
[X] I have checked that any JSON files I am attempting to upload to BloodHound are valid.

Using the python code provided, we've observed the following:
14:49:18.355 INFO    | Bloodhound-Provision | [+] Successfully gained session token for bloodhound
14:49:18.355 INFO    | Bloodhound-Provision | [+] Configured SAML Provider with ID: 1
14:49:18.355 INFO    | Bloodhound-Provision | [+] Read-Only ID: 1

16:31:32.203 INFO    | Bloodhound-Provision | [+] Successfully gained session token for bloodhound
16:31:32.203 INFO    | Bloodhound-Provision | [+] Configured SAML Provider with ID: 1
16:31:32.203 INFO    | Bloodhound-Provision | [+] Read-Only ID: 4

Converted this to an enhancement since things are working as engineering expects and as documented, but there's potentially room to discuss enhancements

We appreciate the desire for this functionality but are unlikely to take it on from within our team.

Additional engineering note:
The API contract for these endpoints is defined with arbitrary integer ids. These aren't meant to be stable ids and are mostly used for backend housekeeping. They should be queried and mapped by an API client before adding the ids to other requests. If you run into other pain points after using the above solution, please feel free to open another ticket to discuss that pain and we can see what other options might be available.


Ensure Prefix matching requires trailing slash

Problem: When using a prefix path match, a path such as /foobar would match for the prefix /foo, which should not happen. Prefixes need a "/" delimiter between path segments.
Solution: In order to allow just the prefix without a trailing slash, as well as more path segments using a slash delimiter, we now create two location blocks. One uses exact matching for the configured prefix path, and the other uses prefix matching with a trailing slash.
Testing: Conformance test now passes
Closes #796

[x] I have read the CONTRIBUTING doc
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that all unit tests pass after adding my changes
[ ] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Now that all conformance tests pass, I can remove continue-on-error if we want. That way we can actually get visibility into the tests from the PR page.


Nice to have an option to have non source directories

Currently, you set root directory as a source directory. Nice to get a way to make only some directory source.

Closing this one, as there's a workaround.


Colors is not working for me

hi
i am using Vscode Version: 1.51.1 on macos 10.14.6
the logger doesn't give me the same colors as mentioned in the pub.dev
i don't know why
upload image to website
any help with this issue

You may want to take a look at #2

i followed some users suggestion with no improvement

The vscode terminal does not support ANSI escape sequences. So I don't expect colors to work on the terminal there.
The only thing I would expect to see it some of these weird escape codes which I don't see in your screenshot. Do you see them?


fix: error around latest partition in BigQuery

Hit this bug while using BigQ. Seems like there's more work to be done on the backend, but I just wanted to fix the SQL Lab crash here.

Codecov Report

Merging #11274 into master will increase coverage by 2.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11274      +/-   ##
==========================================
+ Coverage   60.70%   62.71%   +2.01%
==========================================
  Files         393      441      +48
  Lines       24820    14722   -10098
  Branches        0     3612    +3612
==========================================
- Hits        15066     9233    -5833
+ Misses       9754     5308    -4446
- Partials        0      181     +181

Flag
Coverage Δ

#javascript
62.71% <100.00%> (?)

#python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...et-frontend/src/SqlLab/components/TableElement.jsx
81.60% <100.00%> (ø)

...rations/versions/7dbf98566af7_slice_description.py

superset/migrations/versions/c9495751e314_.py

...migrations/versions/ad4d656d92bc_add_avg_metric.py

superset/extensions.py

...8ee127d0d1d_reconvert_legacy_filters_into_adhoc.py

...dding_unique_constraint_on_dashboard_slices_tbl.py

superset/cli.py

superset/translations/utils.py

superset/utils/feature_flag_manager.py

... and 825 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c649ac...3e31cc4. Read the comment docs.

addressed the comments, mergin'!


geocoding crashes when OpenStreetMaps http://nominatim.openstreetmap.org/ is down

Earlier today, http://nominatim.openstreetmap.org/ was down and my app kept crashing. Is there a way to not crash when http://nominatim.openstreetmap.org/ is down?
Uncaught TypeError: Cannot read property 'country' of undefined

You can wrap your call in try{}-catch ...

Of course, sorry about that! Don't know why I didn't caught that.


Make all defined processes work on the new client.

[x] Build
[x] TestFlight
[x] Screenshots

Done.


⚠ Samsung has degraded performance

In 7a0d2ee, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1915 ms

Resolved: Samsung performance has improved in 094a88e.


[CL]: round up or down priceToTick

Background
We recently hardcoded the exponentAtPriceOne parameter as -6 and expect pools to generally use a tick spacing of 100. After doing this, we realized that priceToTick needs to take into consideration tick spacing in order to return a tick that is initializable for the pool. With this being said, their may be time when the tick returned should be round up or down to ensure the resulting value is in favor of the protocol to prevent harmful bugs.
Suggested Design
One option is to add a boolean of roundUp to PriceToTick. Then, determine in all locations this is called if it should be rounding up or down to ensure the number does not return more funds to the user than expected.
Acceptance Criteria
TBD

Realized that https://github.com/osmosis-labs/osmosis/pull/4998 doesn't fully address this issue, will look into this more here


(#481) Fix missing free for fingerprint array in trunk_compact_bundle()

This commit fixes a missing free for memory allocated to the fingerprint array. The problem was seen to occur in highly concurrent inserts stress workload developed as part of concurrent POC-development and is difficult to reproduce in standalone Splinter.
In trunk_compact_bundle(), for a specific code-flow when we found no newly split siblings to replace with a new branch, we release the memory allocated for the trunk_compact_bundle_req{} struct, and exit processing. But the memory allocated (elsewhere, previously) for the fingerprint array hanging off this req struct remains unfreed.
This fix was identified through trace diagnostics and code walk through. And has been independently verified to fix this memory leak in the stress workloads that were used to generate this error.

@rtjohnso - Am assigning this PR to you, as discussed earlier. You helped me triage this fix last week.
I have run few variations of build/release-msan/bin/driver_test splinter_test for --perf option but it is not triggering this code path. I suspect we need some specific data load to trigger the condition if (num_replacements == 0) under which the missing free() occurs.
I have verified that this fix in my dev-branch where the large concurrent inserts work load is running, so am comfortable with this change (even w/o its own stand-alone repro test case).


Add initial Safari wrapper

Related to #14
This PR currently doesn't include any custom code, it's just the direct result of:
xcrun safari-web-extension-converter distribution/ --project-location safari --app-name 'Refined GitHub' --bundle-identifier 'com.sindresorhus.refinedGitHub'

Next:

[x] Find solution the lack of negative lookbehinds support 🤦♂

I saw that @lautis’ wrapper forces compatible versions of those modules for Safari:
https://github.com/lautis/refined-github-safari/commit/8eebe28037ea18d63ab4d129c25dbcc380df00ba#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L10
We can just undo https://github.com/sindresorhus/refined-github/pull/3316

[x] Cleanup options CSS

[x] Fix options’s filter and fit-textarea

[ ] Find out why permission hosts aren't automatically allowed

You need to gitignore:
xcuserdata
project.xcworkspace

You need to gitignore:

That's what I was hoping to find out with this PR 🎉

Also, initial Safari compatibility achieved 🎉

Safari compatibility achieved:

Firefox vs Safari vs Chrome

How to test

Install XCode 12 and Safari 14

You probably need to enable Allow Unsigned Extensions in Safari’s Develop menu.

Run:
npm run build
npm run pack:safari
npm run start:safari

I also had to click Edit websites under Safari Preferences -> Extensions -> Refined GitHub and manually allow GitHub.com.

Questions

About the number 4 above: Is this because it's unsigned? Does it happen for you as well? How can we avoid this?

Next
I think this PR won't need substantial more work, but the next steps will be:

[ ] @sindresorhus sign the extension (?)
[ ] Set up Fastlane

Regarding point 4: I think there's no way around it. permissions is essentially ignored and always acts as optional_permissions, the user has to enable the extension. More information from ~10:00 to ~15:00 in the video: https://developer.apple.com/videos/play/wwdc2020/10665/
Enterprise support in Safari appears easier, but requires changes:

Safari offers a UI to enable the extension on any domain, so webext-domain-permission-toggle needs to be dropped
webext-dynamic-content-scripts doesn't seem to work, but I think this can be replaced by <all_urls> under content_scripts. This is perfect, but it requires a custom manifest.json for Safari
The domain selector currently appears for everyone, so it needs to be hidden in Safari. The cause appears to be https://github.com/fregante/webext-additional-permissions/issues/1

You already use the nolookbehind variants, so that's fixed :+1:
Another patch I have for Safari is the following CSS:
.rgh-parse-backticks {
  display: inline-block;
}

This fixes line-wrapping of code blocks in issues list.

Another patch I have for Safari is the following CSS:

Thanks for making me notice that. It looks like a Safari bug. inline-block will prevent wrapping though, but it looks like moving the sr-only elements outside rgh-parse-backticks fixes it:
https://github.com/sindresorhus/refined-github/blob/a38244e63e108b141745a80f0264ebd1ff6740b0/source/github-helpers/parse-backticks.tsx#L11-L15


[BEAM-13193] Support StandardProtocols.Enum.CONTROL_REQUEST_ELEMENTS_…

…EMBEDDING in Java SDK harness.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

R: @lukecwik

Run Java PreCommit


Create SECURITY.md

$t,$p:{$vOry25$mountmi$sK_AI}for accurate procedures inhonesttruthfindings&givingsin information searchwholeness


MySQL utf8mb4 encoding error

When trying to insert an entity (user, heartbeats, ...) containing Unicode emojis, the following error is thrown.
[ERROR] failed to batch-insert heartbeats – Error 3988: Conversion from collation utf8mb4_0900_ai_ci into latin1_swedish_ci impossible for parameter

There are two reasons for this:

Depending on how and with what MySQL version you created your database, the tables' character set might not be utf8, but something like latin1 or so
The database connection uses utf8 character set, but not utf8mb. Accordingly, 4-byte characters (like 💩) can't be sent to the database

If your database tables do not use the right encoding, run the following script.
ALTER DATABASE CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;

SET FOREIGN_KEY_CHECKS=0;

ALTER TABLE users CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;
ALTER TABLE users CONVERT TO CHARACTER SET utf8mb4;

ALTER TABLE aliases CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;
ALTER TABLE aliases CONVERT TO CHARACTER SET utf8mb4;

ALTER TABLE heartbeats CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;
ALTER TABLE heartbeats CONVERT TO CHARACTER SET utf8mb4;

ALTER TABLE key_string_values CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;
ALTER TABLE key_string_values CONVERT TO CHARACTER SET utf8mb4;

ALTER TABLE language_mappings CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;
ALTER TABLE language_mappings CONVERT TO CHARACTER SET utf8mb4;

ALTER TABLE summaries CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;
ALTER TABLE summaries CONVERT TO CHARACTER SET utf8mb4;

ALTER TABLE summary_items CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci;
ALTER TABLE summary_items CONVERT TO CHARACTER SET utf8mb4;

SET FOREIGN_KEY_CHECKS=1;


Hyperiond hangs on start if compiled with ENABLE_V4L2 on RP2

[x] I confirm that this is an issue rather than a question.

Bug report
Steps to reproduce
Start hyperiond without any config on Raspberry Pi 2.
What is expected?
Normal startup.
What is actually happening?
Startup does not finish, the webserver is not starting. Instead, one CPU core goes to 100% load and hyperiond starts allocating memory, till the system gets unresponsive after about one minute. Hyperiond starts normally, if compiled with ENABLE_V4L2 = Off.
hyperiond-debug.txt
System

Hyperion Server:

Build:       master (GitHub-4d429a27/08de6b78-1590779969)
Build time:  Jun  7 2020 16:43:50
Git Remote:  https://github.com/hyperion-project/hyperion.ng.git
Version:     2.0.0-alpha.6
UI Lang:     auto (BrowserLang: de)
UI Access:   expert
Avail Capt:  dispmanx,framebuffer,qt

Hyperion Server OS:

Distribution: Raspbian GNU/Linux 10 (buster)
Arch:         arm
Kernel:       linux (5.4.44-v7+ (WS: 32))
Browser:      Mozilla/5.0 (X11; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0

The System info is copied from a build with ENABLE_V4L2 = Off. I am running Rasbian Buster without xserver. There is an Arduino connected via USB, which is meant to be used by the adalight driver. Since the webserver is not starting, I have not configured anything. I got identical results for the armv7 deb package from the Hyperion 2.0.0-alpha.6 release and commit 08de6b7.

Fixed in PR #820

Thanks a lot!

Fixed in PR #820

Today I tested this commit, it fixes the issue for me.


Version 0.3.0 does not work with Meteor 1.1.6

I am using version 0.2.9 and Meteor 1.1.6.
I tried to update to  0.3.0 but I get:
=> Errors prevented startup:

 While selecting package versions:
 error: unknown package: isobuild:isopack-2
 Required by: yogiben:autoform-file 0.3.0

+1


Wallet responsiveness is sluggish

If a wallet contains many addresses (eg >50) with each address containing lots of inputs (eg >50) and staking is enabled, the UI responsiveness of the wallet is very sluggish and difficult to operate.
When you disable staking,
or
When you spend all the inputs (consumed by staking for example)
The UI responsiveness returns to normal

As reported on BitcoinUnlimited there are some optimisations that can be made to improve performance<EMAIL_ADDRESS>


Update refactor

Description
Attempt to refactor and better structure the update.py file and its classes.
Made Update() an Abstract Base Class, with the abstractmethod _update.
Each concrete implementation has to at least implement this method.
Added an additional implementation besides NaiveMCUpdate, which uses the new transfer idea proposed in PR #55 and #56.
Tried to structure the two new ideas:

new transfer idea -> new class
additional consideration of equivalent atom (#55) and possibly adapting the orientation of the molecules -> new keywords for each class.

Todos
Notable points that this PR has either accomplished or will accomplish.

[x] Make Update ABC
[x] new class for new proton transfer method
[x] additional keyword for equivalent atoms...
[x] ...and implementation
[x] additional keyword for reorientation ...
[x] ..and implementaiton
[ ] testing

Things to consider

[ ] Think about quering state.getPositions ideally only once
[ ] Think about the structure of the new transfer class
[ ] Find a useful name for this class (any ideas @godenymarta?)

Status

[ ] Ready to go

Codecov Report

Merging #57 (457d161) into main (0a52d86) will decrease coverage by 5.57%.
The diff coverage is 28.93%.

Additional details and impacted files


Bump the frontend toolkit to 4.6.0

Update the frontend toolkit to 4.6.0

use the new breadcrumbs partial from the front end toolkit
use the same markup as the govuk breadcrumb component
update the classname used by the breadcrumbs
add the ARIA role="breadcrumbs"

:+1: Good to merge when green


Fuel types

#1096
Created the front-end and mock up some data for the Fuel Types
Changelog:

Added the table for the fuel types
Created sample data

 Credit Calculation | View Fuel Types |2|


Problems with fics with / in title

I used this on a file with a list of URLs; it threw a "FileNotFoundError [Errno 2] No such file or directory" whenever it reached one which had a / in the fic name, because it kept the / in the name which meant adding a subdirectory to the file path (I'm running Linux).  Running it directly on the URL itself didn't help.
It probably should be coded to ignore all forward slashes in the file names when saving…
Also, I observed that it would hit a point where it would not get a proper response from AO3, and would merrily skip fic after fic after fic with "Fanfiction not found".  When I aborted, removed all the successful links from the list, and restarted it, it usually would successfully grab the same fics it had just said weren't there.  It would probably be helpful if there were something built in to handle the vagaries of AO3 responses, so that one did not have to monitor the downloading so closely to avoid missing them.

I used this on a file with a list of URLs; it threw a "FileNotFoundError [Errno 2] No such file or directory" whenever it reached one which had a / in the fic name, because it kept the / in the name which meant adding a subdirectory to the file path (I'm running Linux)

I tested this just now. It seems to work fine. Can you give me an example of the command that you used which gave you the error.

When I aborted, removed all the successful links from the list, and restarted it, it usually would successfully grab the same fics it had just said weren't there.

When you restart, it should be skipping fics which has already been downloaded. Isn't it doing that? It should work unless u rename the files manually.

The command I used:
ao3_cli -i stranger_things.txt -o ./StrangerThings/ -f PDF
I had a subdirectory called StrangerThings underneath the one I was in that held all the fanfics to download to.  It worked beautifully except for those fics with / in the name.
I also tried
aoe_cli -u "https://archiveofourown.org/works/35885605" -f PDF
That was the first one I ran across that had that issue.  It also failed with the same error.

When you restart, it should be skipping fics which has already been downloaded. Isn't it doing that? It should work unless u rename the files manually.

What I mean is, the first time it went to download it, it said "Processing URL", and then underneath that, "Fanfiction not found".  Thing was, the fanfic did exist at that link.  It would just say "Fanfiction not found" over and over and over for a whole bunch of fics in a row.  So those fics were NOT in the download folder already.  When I restarted it, those fics successfully downloaded.  (Usually.  Sometimes I've had to wait a while before trying again because it would have the same error a bunch of times in a row.  It's taken a whole lot more monitoring than I expected because of this.)
I've also noticed that sometimes when that error (the "Fanfiction not found") hits, the fic just before getting that message does not download properly, and will end up as a 12 byte pdf file, which I have to remove and re-download.  Fortunately it's easy to spot those by size and due to the thumbnail not rendering.  (But again, have to pay a lot of attention to that, because it will think it downloaded successfully when it did not.)

I suspect the issue with the "Fanfiction not found" is due to AO3 giving the "Retry later" message.  Does your script have the maximum request frequency required built-in so that this message is triggered less often?  I believe it's about once per five seconds…

The command I used:
ao3_cli -i stranger_things.txt -o ./StrangerThings/ -f PDF

Ok, I have fixed it by replacing all occurrences of / with a space.
You can test if its working as intended by installing the dev version by-
pip install git+https://github.com/arzkar/ao3-cli@main
Let me know if there are any other errors.

I suspect the issue with the "Fanfiction not found" is due to AO3 giving the "Retry later" message. Does your script have the maximum request frequency required built-in so that this message is triggered less often? I believe it's about once per five seconds…

Possibly. Can you share the fic url in which you are getting this error. I will try to find a fix.

Thanks, will use that one.

Possibly. Can you share the fic url in which you are getting this error. I will try to find a fix.

This isn't a situation where a specific URL triggers it at all.  It gets triggered after downloading anywhere from 30-50 fics in a row, after which every URL for a good long while will give "Fanfiction not found".  Eventually it'll escape that and get back to working (whenever my IP gets out of AO3 jail) but until then, it doesn't matter which URL I try; they'll all fail.  (If I attempt to browse to one in my browser at that moment, it'll give me the "Retry later" message, too.)
Another AO3-related script had this about it:
"Try to keep your ao3 browsing to a minimum while the script is running. It won't break anything, but it may cause you to hit ao3's limit on how many hits to the site you are allowed within a certain time frame. This limit is per user, or per IP if you are not logged in. If this happens, the script will pause for 5 minutes to let the limit reset, and you may see a "Retry later" message when you try to open an ao3 page during that time. Don't be alarmed by this, just wait it out."
You can find more information on this error in the issue for this script here:  https://github.com/radiolarian/AO3Scraper/issues/24
They note it's a 429 error.  You'll notice the previous script (whence I copied the info from) said it was designed to pause for five minutes to wait out the error - is that something that could be included in your script?
This script works great for one or two files here and there, but for a large list of them (I'm attempting to grab 20,000+ fics for a friend, the ids of which I grabbed using that AO3Scraper above), it's going to run into AO3's limits on usage over and over.

"Try to keep your ao3 browsing to a minimum while the script is running. It won't break anything, but it may cause you to hit ao3's limit on how many hits to the site you are allowed within a certain time frame. This limit is per user, or per IP if you are not logged in. If this happens, the script will pause for 5 minutes to let the limit reset, and you may see a "Retry later" message when you try to open an ao3 page during that time. Don't be alarmed by this, just wait it out."

I see. I will try to implement something like this when I get some free time. I usually use to download 10-15 fics in one go so I havent encountered this kind of error. Shouldn't be hard to implement. I will leave this issue open so that I can update on a possible fix to this.

Closing this issue as OG issue has been fixed.
I created a new once to keep track of this feature request. Havent been able to get enough free time to look into this yet unfortunately. Too busy with IRL stuff.


Adds Keyboard Shortcut Disabling

Adds an option to the settings page to disable the keyboard commands.
This enhancement was requested here #966

Hi, @clptrsn! 👋Thanks for taking the time implementing this, but since Chrome has its own way to manage extensions' shortcuts I don't think we need this option as of now, specially because it would confuse Firefox users.

Oh, and in case you're interested, the way of doing it in chrome is by going to chrome://extensions/shortcuts. Cheers!


UseAsyncOptions::enable_auto() can lead to none of the options set

Hey!
I wanted to try out use_async with UseAsyncOptions::enable_auto. So I wrote code like:
    let db = use_async_with_options(
        [...],
        UseAsyncOptions::enable_auto(),
    );
    if db.loading {
        html! {
            <h1>{ "Loading…" }</h1>
        }
    } else if let Some(err) = &db.error {
        panic!("Unexpected error loading database:\n{err}");
    } else {
        let db: &Rc<basic_api::db::Db> = db.data.as_ref().unwrap();
        [...]
    }

As, intuitively, given the async is triggered ASAP, then at least one of the three options must be true.
However, it looks like there is a one-frame delay, and db.loading is set to false at the first run, along with error and data both being set to None.
I'm pretty new to yew_hooks, but… why is db.loading not set to true from the beginning if running with enable_auto? Is that a missing-feature oversight, a bug, or just something that's out of scope?

The initial state is loading=false, data=None, error=None, this is by design for now.

I see, so a PR to change the initial state to be loading = true, data = None, error = None if auto-mount is enabled would be rejected.? (Possibly that'd have needed to go through replacing loading with a function if the false is required for internal purposes)
Well, thank you for yew-hooks anyway! :)
(BTW, I'm also not entirely sure I understand why there's both data and error types, so for the next major version bump I'd also suggest considering just having loading and data fields where if the user wants to return a Result, they'd just have data: Result to match on — or even better, having the returned data be an enum of exactly all the possible states for the future)


Tests needing retry

These asserts need a retry in case of failure:
In test_radiation,.py
- [ ] https://github.com/xsuite/xtrack/blob/26dd0d087d6fbb2bc1757df6d7b906ad7045df81/tests/test_radiation.py#L173
- [ ] https://github.com/xsuite/xtrack/blob/26dd0d087d6fbb2bc1757df6d7b906ad7045df81/tests/test_radiation.py#L178
- [ ] https://github.com/xsuite/xtrack/blob/26dd0d087d6fbb2bc1757df6d7b906ad7045df81/tests/test_radiation.py#L201
- [ ] https://github.com/xsuite/xtrack/blob/26dd0d087d6fbb2bc1757df6d7b906ad7045df81/tests/test_radiation.py#L206
- [ ] https://github.com/xsuite/xtrack/blob/26dd0d087d6fbb2bc1757df6d7b906ad7045df81/tests/test_radiation.py#L211

Done (v0.22.0)


Client evaluation when inline SQL contains a line break after SELECT that doesn't match platform

We have this query that is forcing client-side evaluation, but this only happens if:

Using a global filter on the entity type
Using FromSql with inline SQL
The inline SQL is a verbatim string that contains a line break between the SELECT statement and the first column (or *). Line breaks anywhere else are fine.
The .cs file containing the inline SQL has line break not matching the platform (CRLF on Linux or LF on Windows)

The weirdest part is this seem to happen at compilation time. If we do a build on the linux machine with the Windows line ending, and run it on a Windows machine, it will throw an exception.
Exception message: System.InvalidOperationException: Error generated for warning 'Microsoft.EntityFrameworkCore.Query.QueryClientEvaluationWarning: The LINQ expression 'where [e].IsEnabled' could not be translated and will be evaluated locally.'. This exception can be suppressed or logged by passing event ID 'RelationalEventId.QueryClientEvaluationWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.
Stack trace:
   at Microsoft.EntityFrameworkCore.Diagnostics.EventDefinition`1.Log[TLoggerCategory](IDiagnosticsLogger`1 logger, WarningBehavior warningBehavior, TParam arg, Exception exception)
   at Microsoft.EntityFrameworkCore.Internal.RelationalLoggerExtensions.QueryClientEvaluationWarning(IDiagnosticsLogger`1 diagnostics, QueryModel queryModel, Object queryModelElement)
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryModelVisitor.VisitWhereClause(WhereClause whereClause, QueryModel queryModel, Int32 index)
   at Remotion.Linq.QueryModelVisitorBase.VisitBodyClauses(ObservableCollection`1 bodyClauses, QueryModel queryModel)
   at Remotion.Linq.QueryModelVisitorBase.VisitQueryModel(QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor.VisitQueryModel(QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.RelationalQueryModelVisitor.VisitQueryModel(QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.EntityQueryModelVisitor.CreateAsyncQueryExecutor[TResult](QueryModel queryModel)
   at Microsoft.EntityFrameworkCore.Query.Internal.CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func`1 compiler)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.ExecuteAsync[TResult](Expression query)
   at Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1.System.Collections.Generic.IAsyncEnumerable<TResult>.GetEnumerator()
   at System.Linq.AsyncEnumerable.Aggregate_[TSource,TAccumulate,TResult](IAsyncEnumerable`1 source, TAccumulate seed, Func`3 accumulator, Func`2 resultSelector, CancellationToken cancellationToken) in D:\a\1\s\Ix.NET\Source\System.Interactive.Async\Aggregate.cs:line 118
   at LinuxEFIssue.Program.TestMe() in C:\Code\LinuxEFIssue\LinuxEFIssue\LinuxEFIssue\Program.cs:line 44
   at LinuxEFIssue.Program.Main() in C:\Code\LinuxEFIssue\LinuxEFIssue\LinuxEFIssue\Program.cs:line 17

Steps to reproduce
Entire code has been attached to this ticket. Program.cs has been ran through dos2unix so this example will break on Windows (use unix2dos Program.cs if you want it to break on Linux)
LinuxEFIssue.zip
The key parts are:
The Sql constant MUST have a line break between SELECT and [Id]
            const string Sql = @"SELECT
[Id], [IsEnabled] FROM [Entities]";

There must be a query filter on Entity:
entity.HasQueryFilter(e => e.IsEnabled);

Also enabled throw on client evaluation to make the issue pop a bit more.
Further technical details
EF Core version: 2.2.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer (Also happens using Npgsql.EntityFrameworkCore.PostgreSQL)
Operating system: Windows 10 Pro
IDE: Visual Studio 2017 15.9.5

Wow I was just confronted with the problem as I was inexplicably getting an error (client evaluation was failing) on my Linux testing environments that I couldn't reproduce on my local Windows machine... I definitely could have searched for a very long time for a proper solution (which is removing one line break...) if not for this issue.


 tag doesn't encompass first line.

Informations
Browser version: Chrome Windows 60.0.3112.101 x64:
OS: Windows 10 Pro x64
Screen resolution: 1920x1080
How to reproduce the bug?
Just type a text, only the next lines are encompassed by a  tag.
Displaying source resolve the issue...
Expected behavior
The first line should be encompassed in  tag as well.

Duplicate #516


MaterialX 1.36 additions

New nodes for MaterialX 1.36:

transformpoint, transformvector, transformnormal
rgbtohsv, hsvtorgb

Also adds to our contributed shader headers:

vector4 version of transform (by space name or by matrix)
color4 version of transformc (converts the color portion, leaves alpha alone)

Amended PR with additional changes:

Add new MX 1.36 node "rotate", mark old "rotate2d" as deprecated.

Add new MX 1.36 node "hsvadjust", mark old "hueshift" as deprecated.

stdosl.h: add a new variant of rotate() that takes just an axis and rotates around the origin using that axis (the other, previously existing, version or rotate() takes two arbitrary points and rotates about the line connecting them).

Amended again:  add new MX 1.36 "extract" and "separate" nodes.


[Question] bge0 RX/TX in (nearly) realtime possible?

Hi,
i just want to use these two sensors:
sensor.truenas_system_bge0_rx
sensor.truenas_system_bge0_tx

So i disabled everything else in Home Assistant and created a Helper and a Template sensor to calculate it from KiB in MBit/s.
template:
  sensor:
    - name: Server_Netzwerk_Speed
      icon: mdi:currency-usd
      state: >-
        {{ (states('sensor.truenas_kib') | int * 0.00102459) | round(2) }} MBit/s

So far everything is working well. But the update times are way high for my project. Is there any way to improve this? Could i change something in your intergration?

Not really, this is pull integration so having realtime data is nearly impossible.
Also, you wont need that template after next update.