Normalization of DNS record names

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the library and it is still present.

cloudflare-go version
0.20.0
Go environment
go env
GO111MODULE=""

GOARCH="amd64"

GOBIN=""

GOCACHE="/home/***/.cache/go-build"

GOENV="/home/***/.config/go/env"

GOEXE=""

GOFLAGS=""

GOHOSTARCH="amd64"

GOHOSTOS="linux"

GOINSECURE=""

GOMODCACHE="/home/***/go/pkg/mod"

GONOPROXY=""

GONOSUMDB=""

GOOS="linux"

GOPATH="/home/***/go"

GOPRIVATE=""

GOPROXY="https://proxy.golang.org,direct"

GOROOT="/usr/lib/go"

GOSUMDB="sum.golang.org"

GOTMPDIR=""

GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"

GOVCS=""

GOVERSION="go1.16.6"

GCCGO="gccgo"

AR="ar"

CC="gcc"

CXX="g++"

CGO_ENABLED="1"

GOMOD="/dev/null"

CGO_CFLAGS="-g -O2"

CGO_CPPFLAGS=""

CGO_CXXFLAGS="-g -O2"

CGO_FFLAGS="-g -O2"

CGO_LDFLAGS="-g -O2"

PKG_CONFIG="pkg-config"

GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build***=/tmp/go-build -gno-record-gcc-switches"

Expected output
Showing the DNS record that was just added, because the same internationalized domain name was used.
Actual output
No record:
[]cloudflare.DNSRecord(nil)

Code demonstrating the issue
func main() {
	const UNICODE_DOMAIN = "😺.meow.org"

	handle, _ := cloudflare.NewWithAPIToken(CF_API_TOKEN)

	handle.CreateDNSRecord(context.Background(), ZONE_ID,
		cloudflare.DNSRecord{
			Name:    UNICODE_DOMAIN,
			Type:    "A",
			Content: "<IP_ADDRESS>",
		})

	rs, _ := handle.DNSRecords(context.Background(), ZONE_ID,
		cloudflare.DNSRecord{
			Name: UNICODE_DOMAIN,
		})

	fmt.Printf("%v", rs)
}

Steps to reproduce

Choose any IDN.
Add a DNS record with that name using CreateDNSRecord.
List DNS records using DNSRecords with the name parameter set to the same name.

Discussions + References
According to my experiments, Cloudflare API expects ASCII forms (e.g., xn--138h.org) for DNS record names. However, it seems to expect Unicode forms (e.g., 😺.org) for zone names (see #347). I am very confused by this inconsistency, and could not find related information in the API documentation. Where is this documented? In any case, we can probably put in some code to provide a more intuitive interface as in #348, but I wish to get some confirmation before creating a PR.
To do the Punycode encoding by ourselves, there are many different options due to the complexity introduced by the incompatible IDNA2003 and IDNA2008. I believe we should use the UTS 46 nontransitional processing ("C2" as defined in https://unicode.org/reports/tr46/#Conformance) which would be different from any predefined profiles in the Go package x/net/idna. Here's my assessment of those "built-in" profiles in that package:

idna.ToASCII and idna.Punycode.ToASCII are not doing any mapping or checking, so ÖBB would be different from öbb, which might be different from the library users' expectations.
idna.Lookup.ToASCII will map ß to ss, which is different from what the Cloudflare server is doing.
idna.Display.ToASCII is actually fine, but it is more like a coincidence---the name Display could be misleading.
idna.Registration.ToASCII does not map ÖBB to öbb, either.

PS: In golang/go#47510, I proposed to add a predefined profile for the nontransitional processing mentioned here.

The API for searching zones by name supports either (ascii or unicode) however it returns unicode as you've mentioned. I've done some digging in the past at cloudflare/Cloudflare-WordPress#412 if you're interested in more details.

The API for searching zones by name supports either (ASCII or UNICODE) however it returns unicode as you've mentioned. I've done some digging in the past at cloudflare/Cloudflare-WordPress#412 if you're interested in more details.

Got it. So, all the zone search actually works without conversion now, because we have outsourced all comparison to the Cloudflare servers (which was not the case when #347 was reported). In sum, there are two protections that make zones work as expected: (1) we do the conversion and (2) we let the server to do the filtering. We are very safe with zones now.
Then I think it is more like a bug of the Cloudflare server that DNS record search (using the name parameter) does not work for both ASCII and Unicode forms. I wonder how I can make some noise about it. Another weird thing is that the server did not following UTS 46 to preprocess ÖBB to öbb either. At this point I really think the server is at fault, though we (or I) can make the library code extremely robust before the server is fixed.
A minor point I want to bring up for your patch to cloudflare/Cloudflare-WordPress#412: you were using the transitional processing, which would map ß to ss, where Cloudflare follows a different standard which keeps them separate. Unfortunately, I am not familiar with PHP to (just) turn off that transitional processing. (There is IDNA_NONTRANSITIONAL_TO_ASCII but I don't know if that also enables or disables something else compared to IDNA_DEFAULT). On the other hand, I have studied the current Go idna package thoroughly and know the exact options I need (see golang/go#47510).

@jacobbednarz I made some noise in cloudflare/cloudflare-docs#1991. I am planning to make a PR to normalize all domain-related inputs within dns.go to their ASCII forms before talking to the server. Let me know if something else should be done and I will follow suit.

I’d recommend opening a support ticket which will result in an internal
ticket to investigate. The docs repository is for the documentation at
developers.cloudflare.com and not the API itself.

As for the proposed DNS changes, I'll have a think about it (on vacation next week) and let you know.

As for the proposed DNS changes, I'll have a think about it (on vacation next week) and let you know.

I just made a PR implementing the proposed workaround. Feel free to discard it if you prefer a different solution.


Remove force_zygote from optimize_krotov

The force_zygote option is redundant: if you want to pass custom arguments to make_chi, just run the optimization with chi=make_chi(...; kwargs...)

Codecov Report

Merging #18 (6ef5e69) into master (bf51331) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   90.03%   90.00%   -0.04%
==========================================
  Files           5        5
  Lines         261      260       -1
==========================================
- Hits          235      234       -1
  Misses         26       26

Impacted Files
Coverage Δ

src/optimize.jl
91.66% <100.00%> (-0.06%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


completion not work

Information
VIM version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Oct 29 2018 06:55:58)
macOS version
Included patches: 1-500
Compiled by Homebrew
Operating System: macOS Mojave 10.14.1
Here
$ vim test.cpp
class Test {
public:
int test(int i);
};
int main() {
Test *t = new Test();
t->
}
Autocomplete isn't working at all
:ALEInfo
Current Filetype: cpp
Available Linters: ['ccls', 'clang', 'clangcheck', 'clangd', 'clangtidy', 'clazy', 'cppcheck', 'cpplint', 'cquery', 'flawfinder', 'gcc']
Linter Aliases:
'gcc' -> ['g++']
Enabled Linters: ['clang', 'clangd']
Suggested Fixers:
'clang-format' - Fix C/C++ files with clang-format.
'remove_trailing_lines' - Remove all blank lines at the end of a file.
'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
'uncrustify' - Fix C, C++, C#, ObjectiveC, ObjectiveC++, D, Java, Pawn, and VALA files with uncrustify.
Linter Variables:
let g:ale_cpp_clang_executable = 'clang++'
let g:ale_cpp_clang_options = '-std=c++14 -Wall'
let g:ale_cpp_clangd_executable = 'clangd'
let g:ale_cpp_clangd_options = ''
Global Variables:
let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = 100
let g:ale_completion_enabled = 1
let g:ale_completion_max_suggestions = 50
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_insert_leave = 0
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_linter_aliases = {}
let g:ale_linters = {'c': ['clang', 'clangd'], 'cpp': ['clang', 'clangd'], 'python': ['pylint', 'pyls'], 'dart': ['language_server']}
let g:ale_linters_explicit = 0
let g:ale_list_vertical = 0
let g:ale_list_window_size = 10
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = v:null
let g:ale_open_list = 0
let g:ale_pattern_options = v:null
let g:ale_pattern_options_enabled = v:null
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0

Look for a compile_commands.json file in your project. I think the clangd linter might not look for it in a build directory at the moment, so try moving it outside of your build directory instead.

thanks


Restricted IP-/EA-ADC and efficiency improvements to unrestricted IP-/EA-ADC

This PR contributes changes to the ADC module that supports calculation of IP/EA of closed- and open-shell molecules. The new features are:

Spin-restricted ADC (RADC) for closed-shell molecules
The efficiency of the UADC code has been significantly improved by taking advantage of BLAS operations for expensive tensor contractions and reduction in the overall memory usage
Preconditioner for Davidson’s iterative algorithm has been modified to ensure better convergence
Modifications to the ADC code interface to allow for a direct calculation of excitation energies and properties
New example files (pyscf/examples/adc) and unit tests

Have you compared lib.einsum using tblis, rather than np.einsum(optimize=True)?

Have you compared lib.einsum using tblis, rather than np.einsum(optimize=True)?

We tried replacing np.einsum with lib.einsum. For most of the contractions, it did not improve efficiency and sometimes increased timings by ~ 10 %. Most of the expensive contractions were implemented using np.dot by forming intermediates, without the use of einsum. There are few contractions where @Samragni-93 ended up using lib.einsum.

But was lib.einsum also compiled to use tblis? We have generally seen
significant speedups when tblis is used, particularly w.r.t.
multithreading, if I recall correctly.
On Sun, Apr 5, 2020 at 8:35 PM Alexander Sokolov<EMAIL_ADDRESS>wrote:

Have you compared lib.einsum using tblis, rather than
np.einsum(optimize=True)?
We tried replacing np.einsum with lib.einsum. For most of the
contractions, it did not improve efficiency and sometimes increased timings
by ~ 10 %. Most of the expensive contractions were implemented using np.dot
by forming intermediates, without the use of einsum. There are few
contractions where @Samragni-93 https://github.com/Samragni-93 ended up
using lib.einsum.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/pull/579#issuecomment-609548094, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN5NRB6KDEPKH6SNSZF3YTRLFEZPANCNFSM4MBHAC5Q
.

But was lib.einsum also compiled to use tblis? We have generally seen significant speedups when tblis is used, particularly w.r.t. multithreading, if I recall correctly.
…

Not sure. We'll check that and let you know.

But was lib.einsum also compiled to use tblis? We have generally seen significant speedups when tblis is used, particularly w.r.t. multithreading, if I recall correctly.
…

Not sure. We'll check that and let you know.

We replaced np.einsum with lib.einsum and tested pyscf compiled with tblis. Indeed, we see up to 15-20% speedup. Thanks for the suggestion. This is addressed in a9ef3721c2d2252a599723fc206d727dc89ba414 .

We are ready to merge this. Any objections?

Go ahead and merge
On Mon, Apr 20, 2020 at 6:21 PM Alexander Sokolov<EMAIL_ADDRESS>wrote:

We are ready to merge this. Any objections?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/pull/579#issuecomment-616893927, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN5NRHJNTNIBWTLZZOCKJ3RNTYJBANCNFSM4MBHAC5Q
.


"create_credentials_file" option

https://github.com/google-github-actions/auth/blob/51342a1a91dfd798639e5ce9c0c4fde05bb24f6a/src/main.ts#L171
I'm a bit confused by this warning:
The "create_credentials_file" option is true, but the current GitHub workspace is empty. Did you forget to use "actions/checkout" before this step? If you do not intend to share authentication with future steps in this job, set "create_credentials_file" to false.

is a bit confusing.  In my case I do need the credentials file for get-gke-credentials, but have no need to checkout the code.
example:
name: Rollout

env:
  IMAGE: us-docker.pkg.dev/${{ vars.GCP_PROJECT }}/main/${{ inputs.image }}
  TAG: ${{ github.ref_type == 'tag' && github.ref_name || github.sha }}

on:
  workflow_call:
    inputs:
      image:
        description: Name of image to use
        required: true
        type: string
      resource:
        description: Name of the cloud resource
        required: true
        type: string
      type:
        description: Kubernetes resource type
        default: deployment
        type: string
      target:
        description: Dockerfile target
        type: string

jobs:
  rollout:
    name: Rollout ${{ inputs.image }} to ${{ inputs.resource }}
    environment: ${{ github.ref_type == 'tag' && 'production' || github.ref_name }}
    runs-on: ubuntu-latest
    steps:
      - name: GCP auth
        uses: google-github-actions/auth@v2
        with:
          credentials_json: ${{ secrets.GCP }}

      - name: GKE auth
        uses: google-github-actions/get-gke-credentials@v2
        with:
          cluster_name: main
          location: us-central1

      - name: Rollout
        run: kubectl set image ${{ inputs.type }} ${{ inputs.resource }}
          main=${{ env.IMAGE }}:${{ env.TAG }}
          ${{ inputs.target == 'run-subscriber' && 'dead-letter-subscriber=$IMAGE:$TAG' || '' }}

      - name: Check Rollout Status
        if: ${{ inputs.type == 'deployment' }}
        run: kubectl rollout status deployment ${{ inputs.resource }}

"Checkout" also creates the shared working directory which is shared with later steps. You can also touch $GITHUB_WORKSPACE in a bash script.

@sethvargo right but I don't need the shared working directly, however I do need the file.  To be clear the script I shared is working just fine, but with that warning message


Precondition failed when passing If-Match

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
2.8.1
Current Behavior
When I have custom plugin and function response() is defined (even empty) then traffic works ok, except passing header If-match which stops whole flow (to be precise response part which is overriden by out-of-nowhere code 412):
http localhost:8000/my-route
HTTP/1.1 200 OK

http localhost:8000/my-route "If-Match: 22"
HTTP/1.1 412 Precondition Failed

Expected Behavior
Pass request to upstream, get response from there.
For now code 412 is overriding response from upstream.
Steps To Reproduce
1. create custom plugin
2. define response() function - leave it empty
3. do test with header If-Match
4. change response() to body_filter()
5. do tests from 3.

Anything else?
I created test environment: git clone https://github.com/salvadoriume/kong-workshops.git
where it is very easy to reproduce "Steps to reproduce"

What is more under the hood:
my-kong               | 2022/06/27 10:36:38 [alert] 1#0: worker process 1109 exited on signal 11 (core dumped)

If anyone want more details or I can also arrange demo to show it (but I think docker-compose I prepared is enough). Anybody?

Hello @salvadoriume, I don't think Kong does anything special with If-Match headers.
Does the problem still happen if you use header_filter instead of response in the plugin?

Using header_filter seems to work. Is it possible to verify my steps to reproduce? In long term I wanted to switch to response function, but there is some issues. If my testing is wrong, please correct me. But out of nowhere kong response with 412, maybe it respect that header?

Looks like this happens when the Response phase does body buffering by executing ngx.print(). I could replicate the behavior with the following:
function _M:access(config)
 local table = {}
 kong.log("Status before: ", ngx.status)
 ngx.print(table)
 kong.log("Status after: ", ngx.status)
 ngx.exit(200)
end

Which logs:
Status before: 0
Status after: 412

and returns: 412 Precondition Failed
Apparently Nginx handles the if-match header when ngx.print() is executed (or ngx.send_headers(), or ngx.say()), it will generate an nginx output filter error in case of a mismatch of the Etag (and return status 412).
The following should work to avoid this behavior, i.e. from the custom plugin, clear if-match from the request headers in the response phase:
function _M:response(config)
    ngx.req.clear_header("if-match")
    <your code here>
end

That was my suspicion that I couldn`t prove as I am not operating on such low level.
Thank you very much @samugi
@kikito apparently it does :)

Thanks a lot, @samugi ! I'm closing this issue then.

We understand that executing ngx.print() causes the If-Match to be evaluated by nginx.
But why does it causes the worker to exit on signal 11 ?
This issue still exists and causing a lot of our workers to fail. IMO, this should be re-opened and triaged in depth.

Same behaviour is observed when kong.service.request.enable_buffering() was used in access phase and response body was read in log phase. It ended up doing the If-Match precondition validation check and the worker exited on signal 11.
This is a serious issue as it opens Kong up for DOS attacks.
If one figures out a url which has response buffering turned on, sending a request with If-Match header would lead to nginx worker being killed.


Migrate to the new ES client

The one we are using now got obsolete recently:
https://www.npmjs.com/package/elasticsearch
So we should change to:
https://www.elastic.co/blog/new-elasticsearch-javascript-client-released

Closed by 67145e31ad7fc476df192768f95dc6145b017934


Various code cleanups & fix trying to despawn FIKA players

Cleans up the code a various bit replacing various if/else's with switch statements, also removes unnecessary if statements for sandbox_high


Add sqlcommenter lib to SQL-instrumentation

Sqlcommenter is an open source library that enables ORMs to augment SQL statements before execution, with comments containing information about the code that caused its execution. This helps in easily correlating slow queries with source code and giving insights into backend database performance. In short, it provides observability into the state of client-side applications and their impact on database performance. Application developers need to do very little application code change to enable Sqlcommenter for their applications using ORMs. Observability information from Sqlcommenter can be used by application developers directly using slow query logs, or it can be integrated into other products or tools, such as Cloud SQL Insights, to provide application-centric monitoring.
See:
https://cloud.google.com/blog/topics/developers-practitioners/introducing-sqlcommenter-open-source-orm-auto-instrumentation-library
and
https://github.com/google/sqlcommenter

Hi @mc-chaos
that framework looks quite interessting. Adding additional information to the SQL statements in order to identify the actual code which is responsible for it would be nice.
We'll check whether it is possible to intergrate this into the agent. Maybe this can be provided as an agent plugin..


Integration tests

We should test that any updates to govuk-react do not break tests on an external application, e.g. https://github.com/penx/govuk-react-example.
This could be done by:

checking out the example project on the CI
npm linking to a built version of govuk-react
running any unit tests the example project has

redundant now that example application is included as a package


Cyrillic?

Hello,
how to print Cyrillic? I am receiving strange symbols when printing.
Greetings

Looking at the Brother ESC/P docs, these are the options for the international character set
n3=00h: U.S.A. (*Manufacturer’s default)
n3=01h: France
n3=02h: Germany
n3=03h: U.K.
n3=04h: Denmark I
n3=05h: Sweden
n3=06h: Italy
n3=07h: Spain I
n3=08h: Japan
n3=09h: Norway
n3=0Ah: Denmark II
n3=0Bh: Spain II
n3=0Ch: Latin America
n3=0Dh: South Korea
n3=40h: Legal


Retrieving data-store

Hi, is there a feature that allows you retrieve data set into the store from another js file? Or can you only read data set into the store from the same file.

The store data is saved in a json file so as long as both js files use the same json file, then they can both read the data.
If file one sets the data, then file two will need to use the store.load() method to reload the file into memory. data-store does not handle managing multiple file access to the json file.


syft: 1.3.0 -> 1.4.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/syft/versions.
meta.description for syft is: CLI tool and library for generating a Software Bill of Materials from container images and filesystems
meta.homepage for syft is: https://github.com/anchore/syft
meta.changelog for syft is: https://github.com/anchore/syft/releases/tag/v1.4.1
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.4.1 with grep in /nix/store/hi638ick5gp182nxgsp1qm2cmg8papd5-syft-1.4.1
found 1.4.1 in filename of file in /nix/store/hi638ick5gp182nxgsp1qm2cmg8papd5-syft-1.4.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

syft

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hi638ick5gp182nxgsp1qm2cmg8papd5-syft-1.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A syft https://github.com/r-ryantm/nixpkgs/archive/9468df063891f43b1b746d5cd91f5d469d24b5a0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9468df063891f43b1b746d5cd91f5d469d24b5a0#syft

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hi638ick5gp182nxgsp1qm2cmg8papd5-syft-1.4.1
ls -la /nix/store/hi638ick5gp182nxgsp1qm2cmg8papd5-syft-1.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

syft

Maintainer pings
cc @developer-guy @06kellyjac @kashw2 for testing.

@NixOS/nixpkgs-merge-bot merge

@NixOS/nixpkgs-merge-bot merge


[BUG] Quickadd can't recognize template files with file extensions other than '.md'

Describe the bug
QuickAdd can't recognize template files with file extensions other than .md, I am not sure whether it's a bug or just by design.
To Reproduce
Steps to reproduce the behavior:

Disable core plugin Templates;
Install Templater plugin;
Install QuickAdd plugin;
Create a template file named t_general.eta;
Create a QuickAdd template choice named Create note, set its template path to the path of the template file t_general.eta;
Create a note with the template choice Create note.

Expected behavior
QuickAdd could create notes successfully.
By the way, the Templater plugin could recognize the template file t_general.eta, you could click the templater button on the sidebar to create notes with the very template file flawlessly.
Screenshots

Desktop (please complete the following information):

OS: Windows 11;
Obsidian: 0.13.19;
Quickadd: 0.4.17;
Templater: 1.9.11.

Additional context

The Templater plugin can recognize the template file t_general.eta and create notes with it successfully ;
Change the template file name to "t_general.md", then QuickAdd works.

Hi, is there an expected date to fix this bug?


Add hector adapter

The motivation
Adds hector the set of models that can be used by OpenSCM-Runner
The proposed solution
Add openscm_runner.adapaters.Hector. @kdorheim, @claudiatebaldi, and @noahprime will lead implementation.
This issue will act as the overarching issue for tracking this implementation. We can split out further issues as needed.

Copying first set of discussions from email

Should the SCM executable be compiled and ready to run without dependencies? Hector has a dependency on a C++ library and we are trying to figure out the best way to handle that.

It's completely up to you. We basically have 2 patterns in OpenSCM:

specify as pypi dependency, everything just works: that's what FaIR and ciceroscmpy do (they're pure python)- tell the user where to get the dependencies (pre-compiled or not), how to tell openscm-runner where to find them, how to set runtime environment etc. then run: that's what MAGICC does
CICREO-SCM just put the binary in the openscm-runner package, but we don't want to do that anymore (see https://github.com/openscm/openscm-runner/issues/49)

On a somewhat related note, we’ve been struggling to get the Cicero running. Do you know if there is an extra dependency on our end that we would need to install?

CICEROSCMPY should just work. CICEROSCM requires the binary, but that's included in the package. The binary only works on linux systems. If you're on linux and it's still not working, probably best to make an issue and tag maritsandstad (she is generally very responsive).

Do modeling groups submit their own parameters for the 5/95th percentiles? Or does OpenSCM runner calculate them based on an ensemble of runs?

Neither really. OpenSCM-Runner just does the running (take a bunch of different model configs, run the model, return the results from each run). Then users can process them however they want. We tend to use process_over from scmdata but you could use whatever (https://scmdata.readthedocs.io/en/latest/notebooks/summary-statistics.html#process-over).

The examples in the lab notebooks look like scenario emissions start in 2015, what is being used for the historical portion of the run?

Good question.
So, the ideal pattern is: user specifies emissions for the entire run, the model only runs over the period for which the emissions are provided.
However, the real-world pattern (i.e. supporting IPCC emissions databases is): user specifies emissions for the future only, the model then has to add its own historical emissions onto these in order to create a full timeseries it can run with. At the moment, each model has its own module for grabbing historical emissions (e.g. for FaIR, it is happening in here: https://github.com/openscm/openscm-runner/blob/261bd177b86a708b0080eed245b6511ebb0051bb/src/openscm_runner/adapters/fair_adapter/_scmdf_to_emissions.py#L199). In theory, this means they could all be using different historical emissions. In practice, we did check this before AR6 but it's obviously something we want to improve at some point. I don't think the solution is particularly hard, so if you want to tackle that problem please feel free.

What units does OpenSCM runner expect the emission units in? Are they the same units as the RCMIP emission files?

Any: the idea is that the adapters deal with conversion from emissions' input units (whatever they may be) into the emissions required by the model. We generally use ScmRun's unit conversion for this (https://scmdata.readthedocs.io/en/latest/notebooks/scmrun.html#unit-conversion) but you are free to use whatever unit conversion set up you want before the data gets passed to Hector.

Cheers, great to see plans for OpenSCM extension!
I had tried a (long) while ago (unsuccessfully) to get Pyhector running in OpenSCM-Runner (https://github.com/openscm/openscm-runner/pull/24#issuecomment-704991391).
As for Pyhector, there is still some work needed to update Pyhector with Hector 3 (https://github.com/openclimatedata/pyhector/pull/63).
Using Pyhector might have faster runs than dealing with writing emissions files and calling a compiled executable.
It has been mainly developed and tested on Linux (and Mac) but Windows compilation and usage has also been reported (just not been streamlined yet).

Just to answer the ciceroscm part. I did add a Windows executable at some point, but whether that still works, I don't know. I'm not particularly interested in updating that though...

Re pyhector - @znicholls & @rgieseke that is a good point about pyhector unfortunately I don't think we have the resources to contribute to the pyhector to V3 update and integrate it here. we will probably follow MAGICC's set or something, I plan on talking to our open source software mastermind Chris Vernon next week.

FWIW, the Pyhector v3 update is almost done. A few minor things to clean up and check, then I'll make a new release.

@rgieseke that is awesome!

Hello, opening this conversation back up as we have an adapter for Hector that's working by calling a built version of Hector akin to the cicero solution. I understand packaging binaries isn't the solution we're looking for, but I'm lacking experience here on what to do.

tell the user where to get the dependencies (pre-compiled or not), how to tell openscm-runner where to find them, how to set runtime environment etc. then run: that's what MAGICC does

^ Is this the path I should be exploring? Users could download and build Hector independently and somehow direct openscm-runner to find that build?
Here's the fork I've been working off of and how the Hector executable gets called:
https://github.com/noahprime/openscm-runner/blob/c36933ad9baf6b9ef14e63530387951c2c8de015/src/openscm_runner/adapters/hector_adapter/hector_wrapper.py#L93-L97

Is this the path I should be exploring? Users could download and build Hector independently and somehow direct openscm-runner to find that build?

This is what I would do (put pre-built binaries somewhere and point users to them).

Is this the path I should be exploring? Users could download and build Hector independently and somehow direct openscm-runner to find that build?

This is what I would do (put pre-built binaries somewhere and point users to them).


Now make new line without a tab?

I click on o transfers to a new line with a tab, how to configure to transfer but without the tab?

:set expandtab. Please note, this is a bug tracker for vim, not for user questions. Use vi.stackexchange.com or use vim_use mailinglist.


Fix JsonSerializerParameterCode property for System.Text.Json

@RicoSuter ready for review

Lgtm. Thanks very much.
How well are we with the STJ feature? Is a lot missing?


Create scandanavian-coffee-cake.md

If you're submitting a recipe, remember to:

Add it to the index
Follow all submission guidelines

(feel free to remove this text from your PR once you've reviewed the checklist)

Write the recipe in markdown, like all others, or it will show up as two large text blobs.


Inconsistency between selection mode and 'snippetsPreventQuickSuggestions'

Does this issue occur when all extensions are disabled?: Yes
I encountered the following issue since the January update: when in snippet, after typing some characters and the suggestion widget pops up, pressing TAB will not select the first suggestion available, instead the editor will ignore the suggestions and move the cursor to the next snippet placeholder. After some research I found some workaround (e.g. https://github.com/microsoft/vscode/issues/173412 and https://github.com/microsoft/vscode/issues/173387) to set editor.suggest.snippetsPreventQuickSuggestions to false.
But this does not perfectly meet my need and confuses me, since after four selection modes are introduced in the Jan. update, editor.suggest.snippetsPreventQuickSuggestions, as its name suggests, should only prevent selecting quick suggestions, but not those produced by trigger character. The ideal process for me is that when editor.suggest.snippetsPreventQuickSuggestions is true, typing non-trigger chars does not cause the editor to automatically focus on the first suggestion, and pressing TAB causes the cursor to jump to the next snippet placeholder. While typing trigger chars causes the editor to automatically focus on the first suggestion, and pressing TAB causes the editor to select the first suggestion.
After reading the code (https://github.com/microsoft/vscode/blob/main/src/vs/editor/contrib/suggest/browser/suggestController.ts#L248), it seems editor.suggest.snippetsPreventQuickSuggestions is not working as its name suggests. I am wondering if you plan to eliminate the inconsistency in the future. Thank you very much.

VS Code Version: 1.76.1 (https://github.com/microsoft/vscode/commit/5e805b79fcb6ba4c2d23712967df89a089da575b)
OS Version: Windows_NT x64 10.0.19044

closing as /duplicate of https://github.com/microsoft/vscode/issues/173387

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Samples error during build

Many of the typescript samples error during build. The project typescript files appear to output correctly, but the error will cause issues with most build pipelines.
Is there a way around these errors? Is there an issue with the vss-web-extension-sdk?
Steps to reproduce
git clone https://github.com/Microsoft/vsts-extension-samples
cd vsts-extension-samples/build-inspector
npm install
npm run build

Error output
><EMAIL_ADDRESS>build C:\Temp\vsts-extension-samples\build-inspector
> tsc -p .

node_modules/@types/react/index.d.ts(165,11): error TS2559: Type 'Component<P, S>' has no properties in common with type 'ComponentLifecycle<P, S>'.
node_modules/vss-web-extension-sdk/typings/vss.d.ts(3463,14): error TS2559: Type 'TemplateViewModel' has no properties in common with type 'EnhancementOptions'.
node_modules/vss-web-extension-sdk/typings/vss.d.ts(9965,14): error TS2415: Class 'ComboDateBehavior' incorrectly extends base class 'BaseComboBehavior'.
  Types of property 'getValue' are incompatible.
    Type '() => Date' is not assignable to type '<TValue>() => TValue'.
      Type 'Date' is not assignable to type 'TValue'.
node_modules/vss-web-extension-sdk/typings/vss.d.ts(10050,14): error TS2415: Class 'ComboMultiValueBehavior' incorrectly extends base class 'ComboListBehavior'.
  Types of property 'getValue' are incompatible.
    Type '() => string[]' is not assignable to type '<TValue>() => TValue'.
      Type 'string[]' is not assignable to type 'TValue'.
node_modules/vss-web-extension-sdk/typings/vss.d.ts(10224,14): error TS2417: Class static side 'typeof DialogO' incorrectly extends base class static side 'typeof AjaxPanelO'.
  Types of property 'create' are incompatible.
    Type '<T extends Dialog>(dialogType: new (options: any) => T, options?: any) => T' is not assignable to type '<TControl extends Control<any>, TOptions>(controlType: new (options: TOptions) => TContr
ol, conta...'.
      Types of parameters 'dialogType' and 'controlType' are incompatible.
        Type 'new (options: TOptions) => TControl' is not assignable to type 'new (options: any) => Dialog'.
          Type 'TControl' is not assignable to type 'Dialog'.
            Type 'Control<any>' is not assignable to type 'Dialog'.
              Property '_specifiedMaxWidth' is missing in type 'Control<any>'.
src/inspector/associatedItems.ts(40,149): error TS2345: Argument of type '(build: Build) => Promise<any[]>' is not assignable to parameter of type '(value: Build) => void | [Build, Change[], WorkItem[]]
'.
  Type 'Promise<any[]>' is not assignable to type 'void | [Build, Change[], WorkItem[]]'.
    Type 'Promise<any[]>' is not assignable to type '[Build, Change[], WorkItem[]]'.
      Property '0' is missing in type 'Promise<any[]>'.

I'm having a similar experience with the calendar-public-events extension.

I am having the same issues, and it isn't resolved with setting Typescript to 2.3.0.


[Bug] Getting A RenderFlex overflowed by X pixels on the bottom

Getting bottom overlow issue in toast, any updates planned for this?
elegant_notification: ^2.2.2

@iamnabink can you share the code you've implemented to show the notification


Display incorrect port warning since it is a common mistake

Several users were incorrectly using the HttpGatewayEndpoint port of 19080 and customer support asked us to add a message so that users can hopefully fix this faster.

Approved with Suggestion.


Error: render error in "mariadb/templates/secrets.yaml": template: mariadb/templates/secrets.yaml:13:60

Is this a request for help?: yes
Is this a BUG REPORT or FEATURE REQUEST?: Bug report
Version of Helm and Kubernetes:
Helm
Client: &version.Version{SemVer:"v2.5.0", GitCommit:"012cb0ac1a1b2f888144ef5a67b8dab6c2d45be6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.5.0", GitCommit:"012cb0ac1a1b2f888144ef5a67b8dab6c2d45be6", GitTreeState:"clean"}

Kubernetes
Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.6", GitCommit:"7fa1c1756d8bc963f1a389f4a6937dc71f08ada2", GitTreeState:"clean", BuildDate:"2017-06-16T18:34:20Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.4", GitCommit:"d6f433224538d4f9ca2f7ae19b252e6fcb66a3ae", GitTreeState:"dirty", BuildDate:"2017-06-22T04:31:09Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
Bitnami MariaDB
What happened:
helm install --name mariadb \
	--set mariadbRootPassword=secretpassword,mariadbUser=user,mariadbPassword=secretpassword,mariadbDatabase=database \
	stable/mariadb

Error: render error in "mariadb/templates/secrets.yaml": template: mariadb/templates/secrets.yaml:13:60: executing "mariadb/templates/secrets.yaml" at <b64enc>: wrong type for value; expected string; got []interface {}

What you expected to happen:
Secret string to auto convert to b64enc according to the pipeline
How to reproduce it:
Just run command above with untouched mariadb 0.6.3 chart

It was my own fault, dismiss.


Fix-unable to navigate back after leaving chat threads

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/35810
PROPOSAL: https://github.com/Expensify/App/issues/35810#issuecomment-1936386620
Tests

Join a thread by commenting in it
Leave the thread and get taken back to the DM or channel
Hit the back button (or three-finger swipe, cmd + [)
Verify that you are navigated to the thread you left

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/38649957/0c3e03f7-011a-44e8-ab3e-f84a055f1696

Android: mWeb Chrome

https://github.com/Expensify/App/assets/38649957/e80f1a99-d4bd-46c4-acbb-f261088ef51e

iOS: Native

https://github.com/Expensify/App/assets/38649957/0cadb23f-036a-4778-8c59-5b42aedd2417

iOS: mWeb Safari

https://github.com/Expensify/App/assets/38649957/3100457b-44d0-42f5-9f64-11482b21d518

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/38649957/5b3f5a8c-ed8d-4adf-bc26-7d502a00bfd5

MacOS: Desktop

https://github.com/Expensify/App/assets/38649957/f8c5af7a-d389-4c91-a182-99e325554917

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/4160319/c38b139b-2701-494b-a634-63715a2e5e9e

Android: mWeb Chrome
https://github.com/Expensify/App/assets/4160319/3339609e-7ba3-453e-8d24-46cf246955eb

iOS: Native
https://github.com/Expensify/App/assets/4160319/6a7373f8-0c55-4a8e-8528-8bbcc59a1e2c

iOS: mWeb Safari
https://github.com/Expensify/App/assets/4160319/25ef381e-5bf5-46ee-b3b0-cdcb7e689e5c

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/4160319/046a05ff-9d9b-468e-b7cc-6961c03611f6

MacOS: Desktop
https://github.com/Expensify/App/assets/4160319/35f797a6-aae1-49ec-99f1-0924d3773e03

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.46-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This caused a regression in https://github.com/Expensify/App/issues/37612 where the join thread button could not be clicked if navigating back to the thread using the back button. This happened because we don't call OpenReport again when navigating back (like we do if we tap x replies to reopen the thread). More details here.


Questions about Critic model

I am curious whether you only used llama2 13b to create data when generating your generation model's training data, or if you also used llama2 7b to generate generation model's training data.

Hi, If I'm correct, the authors used GPT-4 model to get the training data, check paper for more specific details.

I know the dataset used for training the critic model in GPT-4, but I want to know about the dataset used for the generation model.


Update DW UI tests to accommodate changes introduced in 2.11 and instability tests

Updated DW UI tests to accommodate changes introduced in 2.11 and timeout for  instability tests

Tests are passed in CI rhods-ci-pr-test/3106


The data portal must support the intention to create a collection when the publisher is not signed in

There was an implicit assumption if a publisher clicked on Create Collection and was not signed in, then the portal would support their intention to create a collection by:

Prompting them to sign in or sign up
Then upon success, redirecting them to the Create Collections dialog to achieve their original goal

Instead, the current implementation prompts the publisher to sign in or sign up and then afterwards returns the publisher to the portal home page where they must click  Create Collection again.
Harley has now added an explicit flow demonstrating the desired behavior.
Implementation details:

We will need BE update to support RedirectURL  -- probably don't need a separate ticket, since @bmccandless mentioned it was a < 1 point change
FE will need to pass redirect URL to include new URL param ?ccModal=true, so when Auth0 redirects the user back to DP, our app can parse the param and trigger the modal programmatically

@brianraymor I added tech details and pointed a 3! Thank you!

Reassigning to Seve for the frontend portion.


publicUrl method is uri-encoding slashes inside the name

When the name of a file contains / the publicUrl method returns url which contains some / and some %2F inconsistently
Environment details

OS: Ubuntu 20.04.3 LTS
Node.js version: v16.14.1
npm version: 8.5.0
@google-cloud/storage version: 5.19.1

Steps to reproduce

call bucket.file('resources/2022/04/229bcc42b7ab45f4a0c467fe4d8af277.res').publicUrl() with a name containing slashes
the publicUrl method returns url which contains some / and some %2F inconsistently=> https://storage.googleapis.com/a-bucket-name/resources%2F2022%2F04%2F229bcc42b7ab45f4a0c467fe4d8af277.res

Thanks for all your support!

Hi @miguepintor , this is happening on purpose. Only the file name is being encoded. https://github.com/googleapis/nodejs-storage/blob/5f78907a75883cec3fe67204281fb1f9f5a1a03a/src/file.ts#L3309-L3330
The rules surrounding bucket names allow us to safely assume that they will never need to be encoded. Is this causing issues for you in some way?


Padracing sample is now non-functional and contains errors

The new Padracing sample now contains errors caused by missing code.  The backing gist seems to have been changed is missing a base class ContactCallback as well as some other methods.
https://dartpad.dev/index.html?id=ecabed4a17a3aad8bee7c6327e472fc8
Or just go to dartpad.dev and select the Padracing sample (which is the link above)

Hey @spydon, I'm guessing Flame 1.2.0 broke your game. Any chance of guidance on how to fix it?

Oh, right. Here is the updated version:
https://gist.github.com/spydon/3e52ca7b51ba15f989ad880b8b3314a2

Ruh-roh, that doesn't compile on DartPad for some reason. See https://dartpad.dev/?id=3e52ca7b51ba15f989ad880b8b3314a2's log:
Error compiling to JavaScript:
TimeoutException after 0:01:00.000000: Future not completed

I can't replicate locally. Ugh.

Are you sure you don't have an old cached version? Because that is the same gist id as I've used previously.

Yeah it seems to be working for me: https://dartpad.dev/?id=3e52ca7b51ba15f989ad880b8b3314a2

It is working for me also now.

This should be possible to close


Fix shadow member warnings in randen_hwaes.cc

The warning is due to the name of the Vector128 ctor parameter. Using v instead, which I see used elsewhere (e.g. line 290)

Closing because the internal CL has been approved.


Hard App Crash and Preferences Wiped on "Enable Mouse Pointer Crosshairs"

Microsoft PowerToys version
0.55.0 (Preview)
Running as admin

[X] Yes

Area(s) with issue?
Settings
Steps to reproduce

open "powertoys (preview)" from start menu.
choose to run it as administrator or not, it crashes both ways for me
click on the "Mouse Utilities" category, then scroll down to "Mouse Pointer Crosshairs"
click on the switch for "Enable Mouse Pointer Crosshairs"

✔ Expected Behavior
The feature is activated.
❌ Actual Behavior
The control panel crashes and running utilities like "FancyZones" stop working.
Upon restarting the program, user settings in the "settings" screen are returned to default values.  For example, most toys are turned on, when the user previously turned many of them off.
Other Software
Windows 10
Edition	Windows 10 Pro
Version	21H2
Installed on	6/12/2020
OS build	19044.1503
Experience	Windows Feature Experience Pack 120.2212.4170.0

/reportbug

PowerToysReport_2022-01-31-23-51-13.zip

I have the same issue, and here is my zipfile.
PowerToysReport_2022-02-01-19-18-28.zip
e

I have the same issue
Running as admin

[ ] No
PowerToysReport_2022-02-01-12-02-04.zip

@samuel-mr , looking at your logs, Mouse pointer crosshair seems to be working well for you. Could you please describe better what you're experiencing?

Sure!. The app closes completely, but only when I activate "Mouse Pointer Crosshairs". Upon restarting the program I open "Mouse Highlighter" and see that the option is already activated and working. But, if I deactivate the option and activate it again the app crashes again when the option is activated.
My Event Viewer (this was generated when I turned on the 'Enable Mouse Highlighter' option) :
Faulting application name: PowerToys.exe, version: <IP_ADDRESS>, time stamp: 0x61f43b28
Faulting module name: PowerToys.MousePointerCrosshairs.dll, version: <IP_ADDRESS>, time stamp: 0x61f43bec
Exception code: 0xc0000005
Fault offset: 0x000000000000e8f1
Faulting process ID: 0x5b64
Faulting application start time: 0x01d8178d175dda31
Faulting application path: C:\Program Files\PowerToys\PowerToys.exe
Faulting module path: C:\Program Files\PowerToys\modules\MouseUtils\PowerToys.MousePointerCrosshairs.dll
Report ID: f42dd0c7-7ac2-4f29-840d-83b1a878b1e6
Faulting package full name:
Faulting package-relative application ID:

Thank you. 0xc0000005 is a memory access violation.
Curious to know what might be causing this. Need to take a look at that code quality here ;)

a question just for curiosity, is it possible to program "Mouse utilities" with Rust instead of C++?

@samuel-mr ,
Curious to know, does this also happen when disabling/enabling Mouse Highlighter?
I'm asking since the code is pretty similar.

a question just for curiosity, is it possible to program "Mouse utilities" with Rust instead of C++?

Good question. If you're able to emulate the C++ interface declared by a PowerToy in Rust, it should be possible.

@jaimecbernardo nop, Mouse Highlighter works ok when disabling / enabling.

For testing fixing this issue, would you mind installing a (non-signed) debug build to test if it fixes it?
https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-crosshairs-crash-fix
First uninstall your current installation of PowerToys, then install this fix build and test it.
@slate0
@Superenigmatix
@samuel-mr
Main reason is that it's very hard for me to replicate the bug, so some validation from machines which replicate constantly is helpful here.
Thanks, in advance.

Ok that debug build works fine. Turned it on, off, changed settings whilst it was on and off with no issues.

just as an fyi - my exception code in the windows app event log was the same as samuel-mr's.

Today:

I have turned on the PC
Open PowerToys Settings (v0.55.0)
Click to enable Crosshairs

✔ Expected Behavior
Crosshairs enabled and App crashes (because I have the same version as yesterday, I still haven't unistalled it)
❌ Actual Behavior
It does not crashes
I have seen this pull request to hours ago. The fix was applied automatically on my pc?

Today:

I have turned on the PC
Open PowerToys Settings (v0.55.0)
Click to enable Crosshairs

✔ Expected Behavior Crosshairs enabled and App crashes (because I have the same version as yesterday, I still haven't unistalled it)
❌ Actual Behavior It does not crashes
I have seen this pull request  2 hours ago. The fix was applied automatically on my pc?

It'll have to be released. We plan to include this in a hotfix release.

My experience: Happened literally one time, after I manually un-installed 0.53 and then installed 0.55. Only on my desktop.
On my Surface I just updated PowerToys straigt away. No issue here.

0.55.1 should have the fix for this.  We just released it today. https://aka.ms/installpowertoys

For testing fixing this issue, would you mind installing a (non-signed) debug build to test if it fixes it? https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-crosshairs-crash-fix
First uninstall your current installation of PowerToys, then install this fix build and test it. @slate0 @Superenigmatix @samuel-mr
Main reason is that it's very hard for me to replicate the bug, so some validation from machines which replicate constantly is helpful here. Thanks, in advance.

Thanks a lot for helping me test this out.
You can now uninstall the debug build and install the latest 0.55.1 release which contains the fix for this issue.


saving structure in v7 format with compression

Saving a structure in v7 format with compression creates a corrupted file.
After some investigation, the problem seems to be present since matio 1.5.12.
File generated with matio 1.5.9 (not corrupted):
structS-matio-1.5.9.zip
File generated with matio 1.5.27 (corrupted):
structS-matio-1.5.27.zip
The structure saved contains two fields type and age with values "logiciel" and 30.

Thanks for reporting. That's rather unexpected given the age of v1.5.12. Can you share the code how you created the MAT files? Did you run git bisect to find the bad commit?

I did not use git bisect, I rebuilt matio on different tags to find the last working version.
The Scilab code used to generate files:
structS = struct("type", "logiciel", "age", 30);
savematfile("structS-matio-1.5.9.mat", "structS", "-v7")

Files generated using matio 1.5.9 can be read back in 1.5.9 or 1.5.27 but files generated using 1.5.27 cannot be read in 1.5.9 nor 1.5.27, that is why I incriminated the save.
Without compression, I can save and load files without trouble.
I hope this helps.

Thanks for the details! Do you mind to run git bisect to find the bad commit as in your other issu?. I do hope that it will be easier for you than guessing by me because of the many changes between 1.5.9 and 1.5.12. Thank you!

I am afraid I cannot reproduce without the driving Scilab code. The following vanilla Matio test code produces a 100% binary identical MAT file to your valid structS-matio-1.5.9.mat - tested with current abe00b806aaab19938805f4b66b3d62a28d1cf4a on Win with MSVC.
mat_t *mat;
char output_name[256];
int version[3];

Mat_GetLibraryVersion(version, version + 1, version + 2);
snprintf(output_name, 256, "structS-matio-%d.%d.%d.mat", version[0], version[1], version[2]);

mat = Mat_CreateVer(output_name, "MATLAB 5.0 MAT-file, Platform: x86_64-pc-windows, Created by: libmatio v1.5.9 on Thu Jun 13 16:06:30 2024\x0A", MAT_FT_MAT5);
if (mat) {
  const wchar_t *str = L"logiciel";
  const double age[1] = { 30.0 };
  const size_t num_fields = 2;
  const char *fieldnames[2] = { "type", "age" };
  size_t dims[2];
  matvar_t *matvar, *struct_matvar;

  dims[0] = 1; dims[1] = 1;
  struct_matvar = Mat_VarCreateStruct("structS", 2, dims, fieldnames, num_fields);
  dims[0] = 1; dims[1] = 8;
  matvar = Mat_VarCreate(fieldnames[0], MAT_C_CHAR, MAT_T_UINT16, 2, dims, (void *)str, 0);
  Mat_VarSetStructFieldByName(struct_matvar, fieldnames[0], 0, matvar);
  dims[0] = 1; dims[1] = 1;
  matvar = Mat_VarCreate(fieldnames[1], MAT_C_DOUBLE, MAT_T_DOUBLE, 2, dims, (void *)age, 0);
  Mat_VarSetStructFieldByName(struct_matvar, fieldnames[1], 0, matvar);
  Mat_VarWrite(mat, struct_matvar, MAT_COMPRESSION_ZLIB);
  Mat_VarFree(struct_matvar);
  Mat_Close(mat);
}

Thanks for having a look.
In your code, I do not see any format version.
Can you try using v5 or v7 format? things go well in the v7.3 format.
What format are you using in your test?

Here is a code, based on yours, that reproduces what we are doing in Scilab.
The problem occurred when I changed the string logiciel from wchar_t* to char* and MAT_T_UINT8 to MAT_T_UINT16.
    mat_t *mat;
    char output_name[256];
    int version[3];

    Mat_GetLibraryVersion(version, version + 1, version + 2);
    snprintf(output_name, 256, "structS-matio-%d.%d.%d.mat", version[0], version[1], version[2]);

    mat = Mat_CreateVer(output_name, "MATLAB 5.0 MAT-file, Platform: x86_64-pc-windows, Created by: libmatio v1.5.9 on Thu Jun 13 16:06:30 2024\x0A", MAT_FT_MAT5);
    if (mat) {
        const char* str = "logiciel";
        const double age[1] = { 30.0 };
        const size_t num_fields = 2;
        const char *fieldnames[2] = { "type", "age" };
        size_t dims[2];
        matvar_t *matvar, *struct_matvar;
        matvar_t* structEntries[3] = {NULL, NULL, NULL};

        dims[0] = 1; dims[1] = 8;
        structEntries[0] = Mat_VarCreate(fieldnames[0], MAT_C_CHAR, MAT_T_UINT8, 2, dims, (void *)str, 0);
        dims[0] = 1; dims[1] = 1;
        structEntries[1] = Mat_VarCreate(fieldnames[1], MAT_C_DOUBLE, MAT_T_DOUBLE, 2, dims, (void *)age, 0);
        dims[0] = 1; dims[1] = 1;
        struct_matvar = Mat_VarCreate("structS", MAT_C_STRUCT, MAT_T_STRUCT, 2, dims, structEntries, 0);

        Mat_VarWrite(mat, struct_matvar, MAT_COMPRESSION_ZLIB);
        Mat_VarFree(struct_matvar);
        Mat_Close(mat);
    }

Thanks for the test. 6321cda851e4153be6da08e5d0f0d4f92ef20db4 (on mat5.c) seems to be the suspicious commit. Need to investigate in more detail.

@SciCed Please confirm that 8407b4ef9610eb19ae2d3792d12f5b8ea0663100 fixes the issue.

@tbeu  The fix is working well, thanks!


AssocList is missing keys(), vals()

The two functions, returning an Iter, would be useful.

PR open to solve this: https://github.com/dfinity/motoko-base/pull/646


Straw-man implementation of text drop-downs

Update DropDownDiv to include the logic for positioning by block.
Update field_dropdown to use DropDownDiv instead of WidgetDiv.
Update CSS so goog-menus are styled in DropDownDivs as well as WidgetDivs (mostly a copy-paste job).

Previews:

Everything seems reasonable and screenshots look good.


Fix dcos-enterprise-cli licenses

Once we create artifact URLs with checksums we can then revisit this.

This PR can be merged after https://github.com/mesosphere/dcos-enterprise/pull/4796 is merged (and is backported to 1.12)


chore(clp-package):Use a common scheme for JSON and IR metadata.

Description
This PR is a continuation of work in #596
The PR introduces two updates to the stream metadata so that both IR and JSON metadata share the same scheme:

remove file_split_id from IR metadata, since it is not used by the WebUI.
replace orig_file_id and archive_id with "stream_id".

With the changes above, we are able to simplify the webui code in the same PR.
Validation performed
Manually tested both CLP and CLP-S log viewing.
Manually verified that extracted stream metadata in the mongodb matches expectation

Summary by CodeRabbit
Release Notes

New Features

Enhanced metadata handling for extracted streams with updated identifiers.
Added a new stream_id property to the response of extraction jobs.

Bug Fixes

Improved error handling for connection failures in result caching.

Documentation

Updated type definitions and return types for API calls related to stream extraction.

These changes improve the overall functionality and reliability of the application, ensuring better alignment with the updated data structure.

LGTM.

I think for the title you may just need a space after the ":" character.


Improve documentation of import functionality

Description
It would be great to have an "Import" function within the resources, like it is within azurerm functions to import existing infrastructure like environments using Environment ID or DLP.
Example from azurerm_application_gateway
Resource

Resource Name: terraform import powerplatform_environment.example
API documentation:
Estimated complexity/effort:
Related resources/data sources:

Potential Terraform Configuration
# Sample Terraform config that describes how the new resource might look.

terraform import powerplatform_environment.example
terraform import powerplatform_data_loss_prevention_policy.example

Definition of Done

[ ] Data Transfer Objects (dtos)
[ ] Data Client functions
[ ] Resource Implementation
[ ] Resource Added to Provider
[ ] Unit Tests for Happy Path
[ ] Unit Tests for error path
[ ] Acceptance Tests
[ ] Example in the /examples folder
[ ] Schema Documentation in code
[ ] Updated auto-generated provider docs with make docs

Contributions
Do you plan to raise a PR to address this issue? NO
See the contributing guide for more information about what's expected for contributions.

Hi @MarvinBangert,
I hope you are doing well.
If I am not wrong - I will let the maintainers correct me if it is the case - you can already achieve this 😊
It is something I included in a GitHub workflow and you can see the behavior with a previous run.
Have a great weekend.
Regards,
Raphael

Hi @rpothin,
thanks for your quick reply! I will check this out, didn't found anything in the Terraform docs, so I thought it's not implemented yet.
Have a great start into the week!
BR
Marvin

Repurposing this to be a documentation task since this functionality should be already available on the resources.


Bumps dependencies for 2.0 release [WIP]

Consolidates https://github.com/purescript/purescript-transformers/pull/75 and https://github.com/purescript/purescript-transformers/pull/74 as well as updating dependencies.
Marked as [WIP] because it's currently referencing https://github.com/purescript/purescript-distributive/pull/6 as a dependency in the bower.json, and requires an update to purescript-arrays to avoid bower conflicts.

Thanks for working on this, and for the rank-2 change!


JSONDecodeError: Expecting value: line 1 column 1 (char 0)

https://sentry.io/thermondo/stanley/issues/566094881/
JSONDecodeError: Expecting value: line 1 column 1 (char 0)
(13 additional frame(s) were not displayed)
...
  File "stanley/app.py", line 17, in request_feedback_command
    request_feedback()

JSONDecodeError: Expecting value: line 1 column 1 (char 0)

@SebastianKapunkt would you, please, be so kind to check this one? :)


[Vimeo] Downloading Channel/Album - Unable to extract list title

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.02.26. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2018.02.26

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

Attempted to download a channel/album and recieved this error. Tried both 2018.02.22 and 2018.02.26
Command:
youtube-dl "https://vimeo.com/album/4786409" -v

Output:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://vimeo.com/album/4786409', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.02.26
[debug] Python version 3.6.3 (CPython) - Darwin-17.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.4.2, ffprobe 3.4.2
[debug] Proxy map: {}
[vimeo:album] 4786409: Downloading page 1
ERROR: Unable to extract list title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 785, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 440, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vimeo.py", line 855, in _real_extract
    return self._extract_videos(album_id, 'https://vimeo.com/album/%s' % album_id)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vimeo.py", line 791, in _extract_videos
    list_title = next(title_and_entries)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vimeo.py", line 768, in _title_and_entries
    yield self._extract_list_title(webpage)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vimeo.py", line 730, in _extract_list_title
    return self._TITLE or self._html_search_regex(self._TITLE_RE, webpage, 'list title')
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 805, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 796, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract list title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

I'm working on it.

youtube-dl.exe --verbose "https://vimeo.com/album/5024368"

debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://vimeo.com/album/5024368']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2018.03.10
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.16299
[debug] exe versions: ffmpeg 2.8.4
[debug] Proxy map: {}
[vimeo:album] 5024368: Downloading page 1
ERROR: Unable to extract list title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\YoutubeDL.py", line 785, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\extractor\common.py", line 440, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\extractor\vimeo.py", line 864, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\extractor\vimeo.py", line 800, in _extract_videos
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\extractor\vimeo.py", line 777, in _title_and_entries
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\extractor\vimeo.py", line 739, in _extract_list_title
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\extractor\common.py", line 805, in _html_search_regex
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpzznjsz2q\build\youtube_dl\extractor\common.py", line 796, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract list title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

It doesn't fix extraction of password protected albums!

That's not what I tried to achieve. Step by step.

It doesn't fix extraction of password protected albums!

I just ran into this issue trying to download a password protected album.
Thanks for all of the efforts so far. Please let us know once it has been fixed.
I am running [debug] youtube-dl version 2018.04.16

Any updates on this? I am getting the same error.

Same.

Any update? I have the same question.

FYI I am experiencing this problem also with albums that are NOT password-protected

Same error for me.  Python version is 2.7.12.

Still a problem under 2019.02.18


Allow custom challenge order

Currently the challenges appear in alphabetical order, it would be better if we customize the order by prioritizing the easier challenges to the top. For example, the basic challenges could use this order:
# The basic syntax
- parameter
- return
- variable
- any
- kwargs
# Composite data types
- list
- dict
- tuple
# Other
- typealias
- union
- optional
- final

This would make the experience better as people go through the challenges from top to bottom.

Agree this can be improved, but not at the cost of extra complexity. It seems that to change the order, we would always need to store it somewhere else, which is a no-go to me.

Agree this can be improved, but not at the cost of extra complexity. It seems that to change the order, we would always need to store it somewhere else, which is a no-go to me.

Yes, the order has to be stored somewhere, at least we might need to use flask's project `Config' object. One approach might be this:

Introduce a project config variable: challenge_order: List[challenge name].
When getting challenges, use the above list as an index.
If the challenge is missing from the index, put it to the bottom and use alphabetical order.
This means that if challenge_order is empty, the system would work normally as well.

Thanks for proposing the solution. Though it may change in the future, at this point, I don't think this is something worth adding.

OK. I would love to contribute if you change your mind in the future. 😁


data missing for mssql

using microsoft sql as the database, the error "data missing" will appear
this is because of the milliseconds that the database contains. however upon retrieval, the model doesn't seems to be able to retrieve the milliseconds and yet, Carbon will attempt to assume that there's milliseconds involved and thus the conversion fails.

@finalight can you please provide more details? Can't you alter the storage column type to the default Eloquent dat-time format?

Closing this, let's continue on the other issue: https://github.com/laravel/cashier/issues/315


The draw tool is offset from the line being drawn

The draw tool cursor is about 4cm away from the line being drawn.

Hello, @TeacherBiz.
Do you using a system scale of 150%?

Hello, @TeacherBiz.
Do you using a system scale of 150%?

If you mean my display settings (Start->Settings->System) then 125%.

If you mean my display settings (Start->Settings->System) then 125%.

I can confirm - this is bug, issue 48282 in our private issue tracker.

I can confirm - this is bug, issue 48282 in our private issue tracker.

Can confirm the same issues here. I do not have my system scaled.
Another team member did not seem to have the issue. I'm not sure what the difference is.

I do not have my system scaled.

I'm not sure, but problems may be not only in system scale but in browser scale
But anyway our dev team currently was unable to resolve this issue, so maybe after they able to your problem will fixed also


[DG] test 2 align images

Codecov Report

Merging #610 (e7457c6) into master (0a6e2af) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #610   +/-   ##
=========================================
  Coverage     61.70%   61.70%
  Complexity      630      630
=========================================
  Files           104      104
  Lines          2256     2256
  Branches        263      263
=========================================
  Hits           1392     1392
  Misses          744      744
  Partials        120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6e2af...e7457c6. Read the comment docs.


Merge develop branch to v2 branch

Codecov Report

Merging #2394 (bdff69f) into v2 (ad419a3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v2    #2394      +/-   ##
==========================================
- Coverage   97.61%   97.58%   -0.03%
==========================================
  Files          56       56
  Lines       10656    10651       -5
==========================================
- Hits        10402    10394       -8
- Misses        254      257       +3

Impacted Files
Coverage Δ

botocore/httpsession.py
92.55% <0.00%> (-0.47%)
:arrow_down:

botocore/utils.py
96.80% <0.00%> (-0.17%)
:arrow_down:

botocore/response.py
92.53% <0.00%> (-0.11%)
:arrow_down:

botocore/waiter.py
98.28% <0.00%> (-0.01%)
:arrow_down:

botocore/paginate.py
97.83% <0.00%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad419a3...bdff69f. Read the comment docs.


WSLg applications should use windows current keyboard layout.

Add fa keyboard on windows.
Switch to Persian keyboard.
Type something on WSLg window.

Expected behavior
WSLg respect to windows keyboard layout.
By typing using Persian keyboard layout (for example "سلام"), WSLg must shows "سلام".
Actual behavior
It seems WSLg only supports english keyboard layout.
By typing using Persian keyboard layout (for example "سلام"), WSLg  shows "sghl"

@hadimostafapour , thanks for reporting the issue. Would you please take a look my comments at https://github.com/microsoft/wslg/issues/173#issuecomment-849894177, and check the weston.log from /mnt/wslg, to see what keyboard layout is being reported from Windows, and converted to Xkb, thanks!

Set to English Layout
[19:14:13.178] Client: LanguageImeInfo: ProfileType: 2 (TF_PROFILETYPE_KEYBOARDLAYOUT)
[19:14:13.178] Client: LanguageImeInfo: LanguageID: 0x409
[19:14:13.178] Client: LanguageImeInfo: LanguageProfileCLSID: GUID_NULL
[19:14:13.178] Client: LanguageImeInfo: ProfileGUID: GUID_NULL
[19:14:13.178] Client: LanguageImeInfo: KeyboardLayout: 0x409
[19:14:13.178] convert_rdp_keyboard_to_xkb_rule_names: matching layout=us variant=(null)

Set to Persian Standard Layout
[19:14:39.693] Client: LanguageImeInfo: ProfileType: 2 (TF_PROFILETYPE_KEYBOARDLAYOUT)
[19:14:39.693] Client: LanguageImeInfo: LanguageID: 0x429
[19:14:39.693] Client: LanguageImeInfo: LanguageProfileCLSID: GUID_NULL
[19:14:39.693] Client: LanguageImeInfo: ProfileGUID: GUID_NULL
[19:14:39.693] Client: LanguageImeInfo: KeyboardLayout: 0x50429

There is no convert_rdp_keyboard_to_xkb_rule_names happens when switch to persian.

@hadimostafapour , thanks you for information, would you please double check if below link shows your keyboard layout ?
http://kbdlayout.info/kbdfar
http://kbdlayout.info/kbdfar/shiftstates

Thanks!

@hideyukn88 Yes it does.

@hadimostafapour , thanks for confirming it. currently WSLg does not have RDP keyboard layout to Xkb mapping for that layout, this is why it isn't working. We will add it, thanks!

I have the same problem when I transfer layout to Chinese layout
my error log:
Set to English Layout
[03:35:58.126] Client: LanguageImeInfo: ProfileType: 2 (TF_PROFILETYPE_KEYBOARDLAYOUT)
[03:35:58.126] Client: LanguageImeInfo: LanguageID: 0x409
[03:35:58.126] Client: LanguageImeInfo: LanguageProfileCLSID: GUID_NULL
[03:35:58.126] Client: LanguageImeInfo: ProfileGUID: GUID_NULL
[03:35:58.126] Client: LanguageImeInfo: KeyboardLayout: 0x409
[03:35:58.126] convert_rdp_keyboard_to_xkb_rule_names: matching layout=us variant=(null)

Set to Chinese Layout
[03:35:59.949] Client: LanguageImeInfo: ProfileType: 1 (TF_PROFILETYPE_INPUTPROCESSOR)
[03:35:59.949] Client: LanguageImeInfo: LanguageID: 0x404
[03:35:59.949] Client: LanguageImeInfo: LanguageProfileCLSID: Unknown GUID
[03:35:59.949] Client: LanguageImeInfo: ProfileGUID: GUID_PROFILE_NEWPHONETIC
[03:35:59.949] Client: LanguageImeInfo: KeyboardLayout: 0x0

My keyboard layout link: http://kbdlayout.info/kbdus

@shdennlin, thanks for reporting the issue. currently switching to IME layout causes no layout change. Technically, this is not really keyboard layout change, but enabling IME, thus reporting "ProfileType" in the log is different from Persian case (1 which is keyboard layout change vs 2 which is input processor sate change). Also currently we do not support Windows IME to input to Linux application (tracked by https://github.com/microsoft/wslg/issues/9). In mean time, you still should be able to use Linux IME to input Chinese character, please try out. Thanks for trying out WSLg!

I have the same problem between GB and US keyboard layouts (I have en-US-layout hardware but use en-GB layout for preference in Windows) Linux apps (GWSL & X) used to respect this and then yesterday started consistently using US layout. Windows native apps continue to correctly use GB layout. Changing the Windows keyboard layout does not affect GWSL & X apps.

@pseudomonas, would you please share /mnt/wslg/weston.log with us? thanks!

would you please share /mnt/wslg/weston.log with us? thanks!
Doesn't exist; I'm using GWSL not WSLG.

would you please share /mnt/wslg/weston.log with us? thanks!

Doesn't exist; I'm using GWSL not WSLG.  And now I see that this is a WSLG-specific repository, not a WSL-general one. Oops.

@pseudomonas, no problem. I hope you can try out WSLg sometime. Btw, WSL (without g) doesn't control keyboard layout, thus it's most likely issues in GWSL. Thanks!

And I'm closing this issue as Persian/Dari keyboard is now supported in WSLg.

I tried the latest version of WSLG but Persian keyboard not working properly yet!
Weston log when switching to Persian
[19:12:17.028] Client: LanguageImeInfo: ProfileType: 2 (TF_PROFILETYPE_KEYBOARDLAYOUT)
[19:12:17.029] Client: LanguageImeInfo: LanguageID: 0x429
[19:12:17.029] Client: LanguageImeInfo: LanguageProfileCLSID: GUID_NULL
[19:12:17.029] Client: LanguageImeInfo: ProfileGUID: GUID_NULL
[19:12:17.029] Client: LanguageImeInfo: KeyboardLayout: 0x50429

It works properly If I run setxkbmap -model pes -layout ir.

@hideyukn88 how can i update wslg from microsoft repository?

@hideyukn88 how can i update wslg from microsoft repository?

@gustavotaques, you can install the latest version from  https://www.microsoft.com/store/productId/9P9TQF7MRM4R, and if you already installed from Store, then it should update itself automatically, thanks!

@hideyukn88 it works! thanks!


Joining rooms: client-side error signal not being fired

When joining a room, and having a error in the server-side (onJoin method), the client is crashing as well.

Fixed in https://github.com/gamestdio/colyseus/releases/tag/0.4.7


ANGULAR: File Save does not have 'compress' function like MTPROD

Might be needed for large datasets no?

Functionality wasn't there converted to angular and added.  Ready for testing


Merge edit image actions

https://trello.com/c/WnNQNYtB/617-combine-edit-crop-and-edit-metadata-into-edit-image
Please see the commits for further details...

All looks good to me apart from the small change we just discussed! :)

@1pretz1 ...which is now fixed :-)


Populating protocol parameters in segment completion

Updated code to populate the parameters buildTime, waitTime, and memoryUsed.
Added protocol parameter segment size.
Changed server to send memoryUsed only if offheap is set (otherwise the number is not accurate)

Codecov Report

Merging #2757 into master will increase coverage by 0.02%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master    #2757      +/-   ##
==========================================
+ Coverage   68.49%   68.52%   +0.02%
==========================================
  Files         876      876
  Lines       42292    42319      +27
  Branches     5748     5754       +6
==========================================
+ Hits        28969    28997      +28
+ Misses      11453    11450       -3
- Partials     1870     1872       +2

Impacted Files
Coverage Δ

...ot/common/protocols/SegmentCompletionProtocol.java
93.14% <100%> (+0.24%)
:arrow_up:

...er/api/resources/LLCSegmentCompletionHandlers.java
62.22% <100%> (+1.75%)
:arrow_up:

...manager/realtime/LLRealtimeSegmentDataManager.java
74.06% <80.95%> (-0.02%)
:arrow_down:

...a/manager/realtime/RealtimeSegmentDataManager.java
50% <0%> (-25%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
80% <0%> (-13.34%)
:arrow_down:

...n/pinot/core/io/writer/impl/MmapMemoryManager.java
80% <0%> (-6.16%)
:arrow_down:

...impl/dictionary/FloatOffHeapMutableDictionary.java
83.63% <0%> (-3.64%)
:arrow_down:

...ot/core/query/pruner/ColumnValueSegmentPruner.java
84.74% <0%> (-3.39%)
:arrow_down:

...inot/core/operator/docidsets/AndBlockDocIdSet.java
55.86% <0%> (-2.07%)
:arrow_down:

.../broker/routing/HelixExternalViewBasedRouting.java
90.33% <0%> (-1.67%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e72193...0771254. Read the comment docs.


inventory tweaks sorts hotbar when grids are open

Issue description: inventory tweaks sorts hotbar when grids are open
What happens: pressing the sort hotkey while you have a grid GUI open will sort your hotbar, this only happens when the grid GUI is open, it will ignore your hotbar in all other cases.
What you expected to happen: either sorting your inventory and not the hotbar or no sorting at all.
Steps to reproduce:

Open grid GUI
press sort hotkey
profit...?

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: 2705
Refined Storage: 1.6.2 build 256

Does this issue occur on a server? [yes/no]
yes
If a (crash)log is relevant for this issue, link it here:
n/a

Might be (most likely?) a InvTweaks issue. I just add the @InventoryContainer(showOptions = false) annotation to the container (tell them this too when reporting to them).
If this turns out to be a RS issue, I'll reopen.


Unable to schedule jobs

I've read through the other issues mentioning this same problem but I can't seem to get what's happening here. So basically I'm trying to schedule my jobs with the yaml file in my configs, and so I have a job that looks like this in there:
map_reduce_specimen:
  every: 30s
  class: MapReduceSpecimenWorker
  queue: map_reduce_specimen
  args:
  description: "This job..."

The class is actually a module in the directory workers/map_reduce_specimen_worker.rb, but it's my understanding that shouldn't be a problem having it be a module.
Secondly, here is my setup task:
namespace :resque do
  task :setup do
    require 'resque'
    require 'resque_scheduler'
    require 'resque/scheduler'

    Resque.redis = 'localhost:6379'
    Resque.schedule = YAML.load_file('config/resque_schedule.yml')

    # require 'jobs'

    Resque::Scheduler.dynamic = true
  end
end

but still no luck, when I run the setup task rake resque:scheduler, I get:
2011-10-12 23:59:36 Reloading Schedule
2011-10-12 23:59:36 Loading Schedule
2011-10-12 23:59:36 Schedule empty! Set Resque.schedule
2011-10-12 23:59:36 Schedules Loaded

I really don't know where to go from here, or if it's something I'm doing wrong or missing, any help at all would be really appreciated!

I think the part that is a little confusing is including/requiring your jobs in the rake task, I'd gladly help expand the documentation to better explain this, but I think I don't understand myself.
Why not just include the whole environment in the rake task? Would that solve this?

A lot of people don't want to load the entire env to keep their workers light so I don't include the entire env by default.
Can you try putting the Resque::Scheduler.dynamic = true before the Resque.schedule = YAML.load_file('config/resque_schedule.yml')?
(I realize the documentation has it second)
Do you actually need a dynamic schedule (ie: one that will change while the app is running)?

This fixed it.

Ok.  That means I need to update the docs.


fix unchecked casts

I noticed there were some unchecked cast warnings during compilation so I made some changes that:

remove the warnings.
add some hard checks.
tidy up the surrounding code.

@bnazare your patch was very good. I am thinking to give you commit access to project.

@bnazare your patch was very good. I am thinking to give you commit access to project.

hi @dufoli, I'm glad you found the code to be of such great quality and I would welcome your proposal if not for a little issue. You see, my job tends to make some sudden and unexpected turns which means I will at some point in the medium-term suddenly stop working with this stuff for some months. For that reason, I think it may be better if we keep the current model of "episodic" (for lack of a better word :-) ) collaboration.
Do expect a few more PRs in the near future, though ;).

hi @dufoli, I'm glad you found the code to be of such great quality and I would welcome your proposal if not for a little issue. You see, my job tends to make some sudden and unexpected turns which means I will at some point in the medium-term suddenly stop working with this stuff for some months. For that reason, I think it may be better if we keep the current model of "episodic" (for lack of a better word :-) ) collaboration.
Do expect a few more PRs in the near future, though ;).

Ok. Commit access do not make contributions mandatory. Look to @Dufgui. He has start the project and we talk about it but he do not contribute a lot. And if you need review, you can create a pull request but not accept it... Anyway, it was just a proposal. Thanks for all your work.

Ok. Commit access do not make contributions mandatory. Look to @Dufgui. He has start the project and we talk about it but he do not contribute a lot. And if you need review, you can create a pull request but not accept it... Anyway, it was just a proposal. Thanks for all your work.


[CARBONDATA-2213][DataMap] Fixed wrong version for module datamap-example

The version of Module ‘carbondata-datamap-example’ should be 1.4.0-snapshot instead of 1.3.0-snapshot, otherwise compilation will failed.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
NO

[ ] Any backward compatibility impacted?
NO

[ ] Document update required?
NO

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@ravipesala Can you merge this PR? Otherwise compilation will fail.

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3719/

LTGM

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2718/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3963/

merged into datamap branch


Make AttestationServer URL Configurable

Currently the URL for the AttestationServer used by Auditor is hardcoded. https://github.com/GrapheneOS/AttestationServer/issues/140
This is a feature request to make the URL configurable, allowing on to run one's own AttestationServer & use it with the Auditor app that ships with GrapheneOS.

This is a duplicate of #60