Update DG

In this PR:

Add a short Use Case summary, don't exactly know how to include it at the start of the DG as it will look quite out of place, so for now the summary is before the Use Cases
Add some use cases for the other features added in v1.3
Add some whitespace between sections for better readability (Use case and Implementation Details section)
For Gui for adding, editing section, split into steps for easier readability
Update value proposition

Some of the reordering of alternatives and changing of pros and cons to a list format is already handled in here.

Codecov Report

Merging #111 (1f0e2ac) into master (c584681) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #111   +/-   ##
=========================================
  Coverage     66.11%   66.11%
  Complexity      584      584
=========================================
  Files            92       92
  Lines          2072     2072
  Branches        253      253
=========================================
  Hits           1370     1370
  Misses          616      616
  Partials         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c584681...1f0e2ac. Read the comment docs.

Other than some minor grammar issues, LGTM

Other than some minor grammar issues, LGTM

Agreed on the grammar issues, will make the changes. Thanks for pointing those out!

Yep, other than the things already mentioned, LGTM.


[WIP] Add RGBPP Examples

Main Changes

Add examples that are used to demonstrate the use of RGBPP SDK, but they cannot work yet
Update appendPaymasterCellAndSignCkbTx witness parser to match CKB RawTransaction
Upgrade Axios to fix security alert

Reviewers
@Flouse @ahonn @ShookLyngs

replaced by https://github.com/ckb-cell/rgbpp-sdk/pull/43


⚠ TorrentLeech has degraded performance

In 8e1782b, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 10569 ms

Resolved: TorrentLeech performance has improved in 8cd0941 after 8 minutes.


For reaction view, make left nav stack the sections rather than trying to put on a single line

In the reaction view, the display of the navbar on the left changes when the window is resized; might be nicer to have a static vertical stack of nav items?

https://github.com/open-reaction-database/ord-interface/blob/cbfe8426531d78686e53eec051d2a09bb6962915/app/src/views/reaction-view/MainReactionView.vue#L203

I will check if this is fixed and close if appropriate.


change parameter name for deleting a member

Closes #117

Codecov Report

Merging #118 (4675289) into main (b4f90d3) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   97.26%   97.26%
=======================================
  Files          35       35
  Lines        1315     1315
=======================================
  Hits         1279     1279
  Misses         24       24
  Partials       12       12

Files Changed
Coverage Δ

esaapi/member/types/parameter.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


shimv2 errors when using a helper script to set KATA_CONF_FILE

Description of problem
When using the following script to call as a helper to call shimv2, I cannot start a pod.
fidencio@dahmer ~/src/fedora/kata-runtime $ cat containerd-shim-kataqemu-v2
#!/bin/bash

KATA_CONF_FILE=/usr/share/kata-containers/defaults/configuration.toml /usr/bin/containerd-shim-kata-v2 $@

Note: This is totally related to https://github.com/kata-containers/runtime/issues/2610.
Expected result
shimv2 would work in the same way as if the configuration file was in one of the canonical locations and /usr/bin/containerd-shim-kata-v2 was called directly.
Actual result
Failed to create pod sandbox: rpc error: code = Unknown desc = io.containerd.kata.v2: file file+net socket: setnonblock: bad file descriptor : exit status 1

It's important to note that if I create /etc/kata-containers and move the very same configuration.toml that I'm pointing to when using the script, everything will just work as expected.
It may be an issue in CRI-O as well, but for now I'm opening this one here and will point it to CRI-O folks as well.

This appears to have been solved by https://github.com/kata-containers/runtime/pull/1173.

@fidencio does the patch above solve the problem?

No the patch does not solve the issue. This issue was open on Apr 2020, using upstream (at that time) runtime. The patch mentioned above is way older than the issue, and was already merged when this one was opened.

@fidencio - shouldn't your script exec containerd-shim-kata-v2 to avoid the extra process (for bash)?


Extending config

First of all, great work on the plugin!
Would it be possible to extend the config - file with settings for the UselessAttributes and UselessKeywords filters? We're running projects where 2 letter keywords are necessary and we prefer to not skip the attribute slug.
Perhaps something like:
return [
    ...
    'uselessKeywords' => [
        'maxLength' => 1,
    ],
    'uselessAttributes' => [
        'extension',
        'kind',
    ],
];

If these settings are not present you could use the default settings that are currently used. Would like to hear your ideas on this!

Glad you find it useful. I thought of a config like this already.
I know, the current filters are fairly opinionated.
PRs are welcome.


[Bug] rmi protocol doesnot work for threads ，iothreads  etc..

Pre-check

[X] I am sure that all the content I provide is in English.

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache Dubbo Component
Java SDK (apache/dubbo)
Dubbo Version
dubbo 2.6.2
Steps to reproduce this issue
write a dubbo service with rmi protocol, set iothreads, threads etc. attributes,
What you expected to happen
protocol attribute dispather,threadpool,threads doesnot work for rmi
Anything else
No response
Are you willing to submit a pull request to fix on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Dubbo 2.6.x is EOL now. Please check in the latest version.
BTW, rmi is now moved to dubbo-spi-extensions


Unnecessary use of "self"

First, thank you for creating this. It's a handy tool for people coming from GM.
Anyways, I noticed that in the code examples, the self keyword is used a lot, when there's no need for it. For example: self.queue_free() where it could just be queue_free().

That is true! It is mostly because of people like me coming from a python background as well. Some PTSD of writing self. on everything. I'll see what the code guidelines are for GDScript and update accordingly! Thanks for your comment :)

You can find them here: https://docs.godotengine.org/en/3.1/getting_started/scripting/gdscript/gdscript_styleguide.html


[GHSA-qrh7-x6fp-c2mp] The XML libraries for Python 3.4, 3.3, 3.2, 3.1, 2.7, and...

Updates

Affected products
References
Summary

Comments
add 3 patches for django:
https://github.com/django/django/commit/d19a27066b2247102e65412aa66917aff0091112	v1.4
https://github.com/django/django/commit/1c60d07ba23e0350351c278ad28d0bd5aa410b40	v1.5
https://github.com/django/django/commit/c6d69c12ea7ee9ad35abc7dbf95e00d624d0df5d    v1.6a

Hi @MarkLee131, can I ask you to fill out the patched versions for django as well?

similar to https://github.com/github/advisory-database/pull/4428, i cannot identify the patched versions of these patches since they seem to be on branches of format like 1.4.x, 1.5.x

Similar to #4428 those commits have tags too 😉

updated.

Many thanks 👍 . I'm dropping the 1.6a as that is likely one dot six alpha included in the 1.6 release, but otherwise looks good.


Update logos

Uploads the balanced logos because they were inbalanced.
Fixes request-yo-racks/web#114

Types of changes

Balanced logo

Description

The previous logos were inbalanaced.
Uploaded the new balanced logo.

@2echoi The same logos already exist in the images/logos directory. Only the big ones in the images directory are unbalanced.

It turns out that only the images/ryr_logo.png file is unbalanced. You should just have to update that file then.


closure-size: Mass-replace 'pkg}/lib'-style references to correct outputs

A work of a bunch of hacky shell scripts.... hopefully that didn't change something weird that I didn't notice.

@dezgeg, holding my breath, as I wait for this branch to be merged : -)

@vcunat

what prevents this from being merged?

I haven't had time to read it yet, and I don't merge (myself) before doing that :-)

It seems all good. Thanks!


proposal: Address operator for basic and bool literals

Currently in Go, the address operator (&) can only be applied to an addressable element (i.e. a variable, pointer indirection, slice indexing, addressable struct fields, and composite literals).  However, if you are using  numeric, string, or bool literals, the address operator is not supported.  This usually forces some awkward workarounds that either use intermediate variables, or  boxed values (basic literals wrapped in composite types), or helper functions that return pointers for their passed values.
Proposal
As mentioned earlier, the address operator can be applied to composite literals to automatically return the address of their respective values as illustrated below:
type myT struct{a string}
a := &myT{"A"}
x := &struct{a string; b int}{"A", 12}
y := &[]string{"A","B"}
z := &[1]int{2}

This proposal calls for extending this mechanism so that the address operator could also support numeric, string, and boolean literal operands. To minimize impact on the language, the proposal calls for the reuse of the same lexical format used for composite literals, mainly:
"&" basic_types | bool "{" BasicLit | BoolConstant"}"

The following shows examples of how the address operator would be applied to basic and boolean literal values to automatically return their respective addresses:
t := struct {
    f1 *int
    f2 *string
    f3 *float64
    f4 [2]*int64
    f5 *bool
}{
    f1: &int{12},
    f2: &string{"Hi!"},
    f3: &float64{3.14},
    f4: [2]*int64{&int64{44}, &int64{12}},
    f5: &bool{true},
}

By contrast, one of the ways to do the same thing today requires an intermediate set of variable assignments as shown below:
f1 := 12
f2 := "Hi!"
f3 := float64(3.14)
var a, b int64 = 44, 12
f5 := false

t := struct {
    f1 *int
    f2 *string
    f3 *float64
    f4 [2]*int64
    f5 *bool
}{
    f1: &f1,
    f2: &f2,
    f3: &f3,
    f4: [2]*int64{&a, &b},
    f5: &f5,
}

Another workaround uses a sort of type boxing that declares additional types that can wrap basic values inside corresponding struct values:
type Int struct{Value int}
type String struct {Value string}
type Float64 struct{Value float64}
type Int64 struct{Value int64}
type Bool struct{Value bool}
...
t := struct {
    f1 *Int
    f2 *String
    f3 *Float64
    f4 [2]*Int64
    f5 *Bool
}{
    f1: &Int{12},
    f2: &String{"Hi!"},
    f3: &Float64{3.14},
    f4: [2]*Int64{&Int64{44}, &Int64{12}},
    f5: &Bool{true},
}

Some codebase uses yet another workaround that define a set of additional helper functions to provide the convenience of returning the addresses of their passed values as shown:
func Int(v int) *int {return &v}
func String (v string) *string {return &v}
func Float64(v float64) *float64 {return &v}
func Int64(v int64) *int64 {return &v}
func Bool(v bool) *bool {return &v}

t := struct {
    f1 *int
    f2 *string
    f3 *float64
    f4 [2]*int64
    f5 *bool
}{
    f1: Int(12),
    f2: String("Hi!"),
    f3: Float64(3.14),
    f4: [2]*int64{Int64(44), Int64(12)},
    f5: &Bool(true),
}

Dup of #9097?

Closing as dup of #9097.


Fix recipe

@atedstone note that the version in the setup.py file is still 1.25.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Fix/compile twice foundry

Description
This PR:
-> Removes the build target in the makefile
-> Adds the --via-ir flag directly to forge script where necessary
-> Removes node scripts-js/generateTsAbis.js from deploy-verify and adds it in verify-and-generate-abis
Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[x] This is not a duplicate of any existing pull request

Related Issues
_Closes #1019

@technophile-04
Verify worked for me!
https://github.com/user-attachments/assets/702aed03-5cae-4068-a9e9-93e28b2deaf7


eTags on https://browser-update.org/update.min.js

We noticed eTag is being served on the file
https://browser-update.org/update.min.js
can you please remove this?

Hi,
I can do this. Can you explain why?

Can you give me more information on this? And why should they be removed?

Because folks are likely to block https://browser-update.org/ via the big tracker blocklists iff they suspect it's being used for cross-site tracking!

What does this to do with etags? Sorry, I don't know to much about this.

Ok. I read about it. It can be used to do tracking without cookies and has been misused by some websites in the past.
Now I removed it.

@josselex You got lucky.…  You reposted & fixed before I could get in my snide remark! 😉
Thanks! :bow:


Close span when dispatch completes

Per adapter span does not show in trace if span is not closed. Before this PR:
 After:

Not sure how it could work before.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bianpengyuan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
Assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
caff5612f272335adaf789b6a318d4064816e8f0
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
caff5612f272335adaf789b6a318d4064816e8f0
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bianpengyuan, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

Woohoo! Thanks for fixing this issue. It is great to see the dispatches again.


Correcting numbers for editors

What has changed
Changing the codes for “Editor, online” and “Editor, publishing” to the right ones

This repo is being archived and site taken down so closing this PR.


Fix focus issue

Target problem:
Whenever there is an input and a draggable list and the user types something, the focus is lost from the input field because the enableUserSelectHack is removing some styles
Solution description:
This flag is now set as false. This is a temp fix until the proper pass down solution can be implemented including the feasibility to set enableUserSelectHack to false when using this.

Created a cleaner fix


Improve the existing UI tests

Make ./scripts/setup-multiroot-sandbox invocation consistent with backendImpl's tests (so that it’s called from the test itself and not via shell script beforehand)
Possibly reuse the cached IntelliJ zips between binary compatibility check (currently in ~/.cache/intellij-verifier/) & UI tests (in /tmp/ideprobe/cache/, details TBD) so that they're not downloaded twice
Exclude com.virtuslab.gitmachete.frontend.actions.ideprobe.OpenTabAction from production builds of the plugin if easily doable (or maybe not?)

From my comment https://github.com/VirtusLab/git-machete-intellij-plugin/pull/265#issuecomment-628900389:

omitting projects windows (the one where you chose the project :xd:) could speed up the tests
the same about tip popup within IDE

<!-- TODO (#274): consider excluding this action from the production builds of the plugin -->

from plugin.xml
Adding (Open) Machete Tab as an action to the toolbar is an option.
Probably under VCS > Git.

s/to the toolbar/to the main menu?

s/to the toolbar/to the main menu?

yup, sorry


ARROW-769: [GLib] Support building without installed Arrow C++

It doesn't require "make install"-ed Arrow C++ to build Arrow GLib.
But it requires "make"-ed Arrow C++.
This is useful to build packages.

Somehow AppVeyor hasn't run, ignoring as this is code that is not executed in Windows builds yet.


Youtube API v2 expired!

Will you upgrade to the new v3 API?

+1 @sseffa ?

want to upgrade but got no time for it

Any forecast about it?

1-2 months

Thank you mate!

Thank you for update! But youtube video still not found... for example video id: 6hmKTaXvMuA
https://www.youtube.com/watch?v=6hmKTaXvMuA

You should take an api  key from google developer site and allow your own IP adress

I have api key, but can`t find IP address setup

No luck - Video not found.

before running here https://developers.google.com/youtube/v3/docs/channels/list, then try my package


More flexible mapping of Provider (Nautobot) to Provider (circuit-maintenance-parser)

Environment

Nautobot version:
nautobot-circuit-maintenance version:

Proposed Functionality
Mapping Nautobot Providers to circuit-maintenance-provider Provider classes based on the Nautobot Provider slug is inflexible as it relies on enforcing that the Nautobot Provider slug be exactly equal to the circuit-maintenance-provider Provider class __name__. In practice this may not always be the case, and it's not always going to be feasible to change the existing slug in Nautobot to resolve this.

Use Case
I have a Nautobot deployment with circuits defined for provider CenturyLink (former name of the provider now called Lumen). Without changing the slug of this provider, or creating a new Lumen provider and remapping all of the circuits to this new provider, I have no way to make emails from Lumen be handled by the Lumen parser provider because the plugin is looking for a parser called centurylink.

Maybe another optional custom field on Provider?

Addressed in #51


add importlib option for pytest

According to https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html, it is better to have importlib in pyproject.toml, and it prevent the case that pytest would still use local path for module import instead the installed one.

Please add a comment and push again to trigger the test (hf was down)

I think this solution still not good enough, I met another pytest related issue from https://github.com/vllm-project/vllm/pull/4165/files#diff-51cd4e8ce0ff6ac651f9e602890ea4cc18f1a90efbb089c3b6be35042027699eR84-R135, this test try use ray to launch a remote process and execute async engine, even with "--import-mode=importlib", ray seems still tend to use local file if execute pytest within project.
So I tend to make this as draft now, maybe we could convert rename current "vllm" folder into "src", so that even execute within project, would not have any side effect? However it seems need some large modifications...


Async publishing always delivers messages

If a delivery_interval or delivery_threshold is desired on an async producer, the desired automatically delivery behavior is not achieved because deliver_messages is always called. See: https://github.com/klarna/phobos/blob/b28f6bdeb96ca3f84ffb35437e21efb257712541/lib/phobos/producer.rb
def produce_messages(producer, messages)
  messages.each do |message|
    producer.produce(message[:payload], topic: message[:topic],
                                        key: message[:key],
                                        partition_key: message[:key]
    )
  end
  producer.deliver_messages
end

You are right, we can check if the producer has any of the keys configured and conditionally call deliver_messages.
Thanks

Released in 1.4.2.


element tag misspelled

greeting-box misspelled

Signed it
From: googlebot<EMAIL_ADDRESS>Sent: Tuesday, April 28, 2015 9:16 AM
To: angular/angular.js
Cc: Eric Czajkowski
Subject: Re: [angular.js] element tag misspelled (#11747)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
[:memo:]Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the company's name.

—
Reply to this email directly or view it on GitHubhttps://github.com/angular/angular.js/pull/11747#issuecomment-97056173.


chore: workspace dependencies

motivation: A few of the dependencies in multiple crates were using different versions. Recently, the dependency inheritance was added to cargo. so this would be a good way of managing dependencies and update them faster as we move on.

This is great!


Invalid Name Generation

It seems like Serverless Artillery generated a function name that was not valid.
{ ServerlessError: The stack service name "serverless-artillery-WJ_MDv3ew-dev" is not valid. A service name should only contain alphanumeric (case sensitive) and hyphens. It should start with an alphabetic character and shouldn't exceed 128 characters.
    at AwsDeploy.createStack (/usr/local/lib/node_modules/serverless/lib/plugins/aws/deploy/lib/createStack.js:57:13)
    at AwsDeploy.tryCatcher (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromiseCtx (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:606:10)
    at _drainQueueStep (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:142:12)
    at _drainQueue (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:131:9)
    at Async._drainQueues (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:147:5)
    at Immediate.Async.drainQueues (/usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5) name: 'ServerlessError', statusCode: undefined }

    Deploy complete.

Fix for this has been released. Closing.


I want to add Read me for genetic algorithm

I have good knowledge about the genetic algorithm and want to apply my knowledge into practice by adding readme for the same.
@geekquad Sir please assign me this issue

Hey @Ashishsingh619, I guess it is already there.
Please check and reopen if it is not there.


Error 403

Hi,
I have just started receiving error 403... (https://github.com/alvarobartt/investpy/issues/613). Can someone confirm that is a general issue or just something on my end?
Thank you,

Hi, @joao-pm-santos96 this has already been fixed, and released, it's available at https://github.com/alvarobartt/investiny/releases/tag/v0.7.2, should be installable in some minutes with pip install investiny==0.7.2 :hugs:

FYI after some testing, it seems that tvc4 is working again! 🎉

@joao-pm-santos96 I'm having the same issue, getting 403 error. I have 0.7.2 installed.

Yes @martinemilander indeed it was just working for some requests, then I received the HTTP 403 error again... Sorry for the confusing information!


Add longer timeout for dotnet-watch test

@muratg Test only change.
Also, realized the retry doesn't work for this test because the DOTNET_WATCH_ITERATION count can increase twice if it retries.
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/1696

This is the flaky test fix I was trying to find that I don't think made it into 2.2: https://github.com/aspnet/DotNetTools/commit/a24b4ee4598b425d9e8b2f041be508c32eb41cf5

So it's not related

If it fixes it, :shipit:

/AzurePipelines run

Am I the only one hitting build timeouts in our 2.2 builds? @natemcmaster @Eilon Should we increase the AzDo timeouts or is there a better solution?

Based on a cursory inspection of the log, I think we may be running into known issues which deadlock EFCore tests on AzDO. Increasing the timeout would not help.
I would be in favor of skipping EFCore tests completely when building it as a submodule of AspNetCore. The EFCore repo already run tests on all pull requests to 2.x servicing branches.
@ajcvickers @Eilon  would that be okay with you?

If that logic is correct, I'm fine with it.

/AzurePipelines run AspNetCore-ci

@natemcmaster FYI I moved the msbuild check and it finally worked.

🎉 thanks for figuring this one out.


undefined local variable or method `rom' for #TasksController:0x007fc6b0684bc8

This works fine:
class TasksController < ApplicationController
  def index
    render json: rom.read(:tasks).all
  end
end

This blows up:
class TasksController < ActionController::Base
  def index
    render json: rom.read(:tasks).all
  end
end

This is because the ControllerExtension is included in ApplicationController and not ActionController::Base.
Some documentation where this rom method is coming from and how you can get one in your own controller base class would be nice.

Btw, the way to make it work is to include ROM::Rails::ControllerExtension in your controller like this:
class TasksController < ActionController::Base
  include ROM::Rails::ControllerExtension
  def index
    render json: rom.read(:tasks).all
  end
end

Thanks for spotting this. It probably explains why you need to reload spring in the second step of rails tutorial. I will fix/improve it.

Fixed via this commit


rawgps: add oemdre support

Testing on RAV4

@adeebshihadeh is this CI failure real? it still feels flaky


Upgrade jjwt version

Hi. I like to contribute to this project. If there is anything I can contribute to, I would be glad to help.


Trivia plugin: optimize, question statistics...

Participants are now stored in a map to stop having to use Users.get()
or the user's alts and previous names when they join, get kicked,
answer, or on scoring; /trivia qs with no argument returns the
distribution of questions over categories; modifying the question
database is logged; /trivia help is less verbose; and the code is much
more legible.

But this makes it so the user can't get garbage collected when they disconnect!
We generally prefer storing userids.

 I wanted to use users over userids so users could change their name and still be considered a participant, since users keep complaining about that. Having to get the user object of each participant every 45 seconds on scoring so correct responders would have the right username listed in the response didn't make much sense to me either.

They would.
Users should not be able to change their name in the middle of games. I'm thinking about making user accounts a lot less transferrable than previously.

What about when users sign up under the wrong username, but can't change to the one they use for trivia laddering?

I guess we'll support registering alts.

This now uses userids again. Users can't change their names in the middle of games anymore.


remove external/build_all.sh script

Hi!
I do not understand purpose of  https://github.com/adoptium/aqa-tests/blob/master/external/build_all.sh. I addition, it seems it is unused,  because - per https://github.com/adoptium/aqa-tests/pull/5553#issuecomment-2346692535 -  it was broken since  6.February.2024, and nobody noticed.
of course I may be absolutely missing some point, and despite several quiestions on several places, I never got an reply. Looking forward for explanation!

Hello, any progress here?

Any update please?

You seem to have an inconsistent perspective on removing versus keeping files that are not used.  You want to remove this one (which was at one point in the past used by someone for local testing), but you argue to keep this other one https://github.com/adoptium/aqa-tests/pull/5553#discussion_r1824272724.  I will also note that your tendency to disagree/argue and push back on review requests causes reviewers to not want to review your PRs since you will not make the changes they ask for.
I prefer that we first look at fixing the functionality of build_all.sh, rather than removing the script, and also prefer that every PR is related to an issue that describes the problem along with any discussion regarding potential options for resolving it.

Have you read the linked comment in initial description? The file is broken for an year.
I had clearly written that I will remove it if you insists, but   I had kindly asked to reconsider, because the file is quite useful. I'm always doing what reviewer asks for, but not blindly. If I see an reason in that, I try to highlight that. You may see that pattern in all my PRs.
I know you want issue for evrey PR, so I'm doing my best to make it. This is an issue.

Also You had promised (sorry, no written evidence) that  you will ask other users. "any update" means,  if you were able to keep your word, and did what you promised.
I think it is quite common that contributor and reviewer do not agree, and then discussion follows.  Of course reviewer have final word, and can always say that it is not discussable . In live projects, where is more active reviewers, it is also quite common that there is more opinions, unluckily, this diversity is missing here.

yes, I looked back at how the file was used previously, thus my answer above "in the past used by someone for local testing" and see the value of being able to generate all files at once (especially if we consider changing how we run these tests in the future by building and caching images and pulling them for testing).

So you really wish to keep broken file, for the unlikely case, that in some future, it may be used again?    The file is quite trivial, and in case it will be really for some usage, then it will be quite easy to write it again, and reflect the state of the moment when it is reincarnated.

Thanx for the https://github.com/adoptium/aqa-tests/issues/5763! That is very nice info which gives me a bit more info to build on top of. From that point of view I'm definitely ok to close this one. Please do if you wish.  I will close on few days time-out if nothing changes.

Changing the title of this issue, so the outcome can be fix the script instead of remove, as needed (based on 5763 enquiry)

Note that it will be "fixed" by https://github.com/adoptium/aqa-tests/pull/5553 's  https://github.com/adoptium/aqa-tests/pull/5553/commits/26cd87f7eda6f9521dfa59150dbdfafb4cc225e3


Create CI/CD workflows

This is a good stopping point for this task. I'll create follow up issues for really getting it "productionalized".


Update the design with the new Switch circuit

The schematic capture
Layout and routing

The Ethernet switch of LR1.0 has changed to a new Micrel Gigabit Ethernet Switch KSZ9477S in LR2.0.
The new design files will be handled in branch LR2_0.


637 cache key vault values

Summary
Fix issue #637
Issue Type

Bug fixing

Starter Names
Additional Information

@saragluna Build passed. Please merge it. 🙏


Add containerd integration tests

Enable integration test for runc-shim to make sure we're compliant with go version.
Fixes: https://github.com/containerd/rust-extensions/issues/6
Signed-off-by: Maksym Pavlenko<EMAIL_ADDRESS>

Looks like there are a few missing bits in runc-shim to pass the integration test.
@Burning1020 mind help with filling gaps?

No prob. The containerd integration test has been coverd by my own shim actually for months, so I can help the rest part.
Note that it worked with containerd v1.4 on Linux platform in my own :).

Note that it worked with containerd v1.4 on Linux platform in my own :).

Yup, my plan was to test it against all containerd versions we currently support - 1.4, 1.5 and 1.6. I decided to start with the latest release, but can add other versions to the job matrix.

OK. I'm going to start this part today.

2022-02-27T22:25:35.6500265Z === CONT  TestTaskForceDelete
2022-02-27T22:25:35.7425869Z     container_test.go:1029: Others("Other: unknown error after kill: error occured in runc: no child processes (os error 10)"): unknown
2022-02-27T22:25:35.7452843Z --- FAIL: TestTaskForceDelete (0.09s)
2022-02-27T22:25:35.7454162Z === CONT  TestContainerNoBinaryExists
2022-02-27T22:25:35.8378210Z --- PASS: TestContainerNoBinaryExists (0.09s)
2022-02-27T22:25:35.8379037Z === CONT  TestContainerExecNoBinaryExists
2022-02-27T22:25:35.9827588Z     container_test.go:833: Others("Other: unknown error after kill: error occured in runc: no child processes (os error 10)"): unknown
2022-02-27T22:25:36.0136411Z --- FAIL: TestContainerExecNoBinaryExists (0.18s)
2022-02-27T22:25:36.0137005Z === CONT  TestKillContainerDeletedByRunc
2022-02-27T22:25:36.2249644Z     container_test.go:716: expected error "not found" but received "Others(\"Other: unknown error after kill: runc command failed: status=exit status: 1, stdout=\\\"\\\", stderr=\\\"\\\"\"): unknown"
2022-02-27T22:25:36.2522571Z --- FAIL: TestKillContainerDeletedByRunc (0.24s)
2022-02-27T22:25:36.2523236Z === CONT  TestContainerKill
2022-02-27T22:25:36.3482210Z     container_test.go:633: Others("Other: unknown error after kill: error occured in runc: no child processes (os error 10)"): unknown
2022-02-27T22:25:36.3761426Z --- FAIL: TestContainerKill (0.12s)
2022-02-27T22:25:36.3762355Z === CONT  TestDeleteRunningContainer
2022-02-27T22:25:36.5116565Z --- PASS: TestDeleteRunningContainer (0.14s)
2022-02-27T22:25:36.5117277Z === CONT  TestContainerPids
2022-02-27T22:25:36.6035486Z     container_test.go:456: /containerd.task.v2.Task/Pids is not supported: not found
2022-02-27T22:25:36.6056575Z --- FAIL: TestContainerPids (0.09s)
2022-02-27T22:25:36.6057181Z === CONT  TestContainerCloseIO
2022-02-27T22:25:36.6986838Z     container_test.go:530: /containerd.task.v2.Task/CloseIO is not supported: not found
2022-02-27T22:25:36.7291884Z --- FAIL: TestContainerCloseIO (0.12s)

WIP

A couple of tests are still failing:
2022-03-05T23:03:44.7279004Z === RUN   TestContainerKillInitPidHost
2022-03-05T23:03:44.8170326Z     container_linux_test.go:1532: Others("Other: failed start: Error occured in runc: No child processes (os error 10)"): unknown
2022-03-05T23:03:44.8199879Z --- FAIL: TestContainerKillInitPidHost (0.09s)

...

2022-03-05T23:03:44.9747686Z --- FAIL: TestContainerKillInitKillsChildWhenNotHostPid (0.15s)

...

2022-03-05T23:04:53.6683807Z --- FAIL: TestWaitStoppedProcess (0.18s)
2022-03-05T23:04:53.6693250Z === CONT  TestWaitStoppedTask
2022-03-05T23:04:53.8002508Z --- PASS: TestWaitStoppedTask (0.13s)
2022-03-05T23:04:53.8003405Z === CONT  TestContainerNoBinaryExists
2022-03-05T23:04:53.9086217Z --- PASS: TestContainerNoBinaryExists (0.11s)
2022-03-05T23:04:53.9086969Z === CONT  TestKillContainerDeletedByRunc
2022-03-05T23:04:54.1347116Z     container_test.go:716: expected error "not found" but received "Others(\"Other: unknown error after kill: error occured in runc: no child processes (os error 10)\"): unknown"
2022-03-05T23:04:54.1679353Z --- FAIL: TestKillContainerDeletedByRunc (0.26s)
2022-03-05T23:04:54.1680175Z === CONT  TestContainerExecNoBinaryExists
2022-03-05T23:04:54.3222053Z     container_test.go:833: Others("Other: unknown error after kill: error occured in runc: no child processes (os error 10)"): unknown
2022-03-05T23:04:54.3580136Z --- FAIL: TestContainerExecNoBinaryExists (0.19s)

Thanks @Burning1020 @abel-von @jiangliu


Vendoring swarmkit @b74ec2b

Brings in a fix for a panic around the ingress network area. Details at docker/swarmkit/pull/2072
Swarm allocator to respect IPAM driver contract for network gateway. Details at docker/libnetwork#1702
Other swarmkit fixes/features/enhancements (please fill in)

LGTM if green

00:18:27 FAIL: check_test.go:353: DockerSwarmSuite.TearDownTest
00:18:27
00:18:27 check_test.go:358:
00:18:27     d.Stop(c)
00:18:27 daemon/daemon.go:392:
00:18:27     t.Fatalf("Error while stopping the daemon %s : %v", d.id, err)
00:18:27 ... Error: Error while stopping the daemon d89163aa99910 : exit status 2
00:18:27
00:18:27
00:18:27 ----------------------------------------------------------------------
00:18:27 PANIC: docker_cli_swarm_test.go:418: DockerSwarmSuite.TestSwarmIngressNetwork
00:18:27
00:18:27 [d89163aa99910] waiting for daemon to start
00:18:27 [d89163aa99910] daemon started
00:18:27
00:18:27 [d89163aa99910] exiting daemon
00:18:27 ... Panic: Fixture has panicked (see related PANIC)
00:18:27

@aaronlehmann
It is a known one and tracked by #32173
Let me spin it again.

Is the failure understood yet? It to have only started recently. I'm concerned we introduced a regression.

arf if TearDownTest happened again, this mean it was not the only cause for it…
LGTM 🐸


Window Unmovable After Double-Clicking to Maximize on macOS

Tested versions
Godot Version: 4.2
Platform: macOS 12.7.1 (21G920)

System information
Godot Version: 4.2     Platform: macOS 12.7.1 (21G920)

Issue description
After double-clicking on the Godot window to fill the screen (but not entering full-screen mode), the window becomes unresponsive to movements. It seems like there is a loss of window focus or the inability to drag the window around the screen.
Steps to reproduce
Open Godot 4.2 on macOS 12.7.1.
Double-click on the Godot window to maximize it without entering full-screen mode.
Attempt to move the window around the screen by dragging its title bar.
Expected Behavior:
The window should be draggable and movable around the screen after double-clicking to fill the screen.
Actual Behavior:
After double-clicking to fill the screen, the Godot window becomes unresponsive to movements, and it is not possible to drag it around.
Minimal reproduction project (MRP)
not required project
https://github.com/godotengine/godot/assets/94618871/26296222-1df4-4c21-8b41-e543bf443820

Sounds like:

https://github.com/godotengine/godot/issues/78758


Can not connect to Ryuk at localhost:49156 on Windows, Docker Desktop 3.1.0, Engine 20.10.2

I just updated to Docker Desktop 3.1.0 and now I'm seeing this exception when I try to start tests:
[testcontainers-ryuk] WARN org.testcontainers.utility.ResourceReaper - Can not connect to Ryuk at localhost:49156
java.net.ConnectException: Connection refused: connect
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:503)
	at java.base/sun.nio.ch.Net.connect(Net.java:492)
	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:588)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:333)
	at java.base/java.net.Socket.connect(Socket.java:648)
	at java.base/java.net.Socket.connect(Socket.java:597)
	at java.base/java.net.Socket.<init>(Socket.java:520)
	at java.base/java.net.Socket.<init>(Socket.java:294)
	at org.testcontainers.utility.ResourceReaper.lambda$null$1(ResourceReaper.java:160)
	at org.rnorth.ducttape.ratelimits.RateLimiter.doWhenReady(RateLimiter.java:27)
	at org.testcontainers.utility.ResourceReaper.lambda$start$2(ResourceReaper.java:158)
	at java.base/java.lang.Thread.run(Thread.java:832)

I tried setting environment variable TESTCONTAINERS_RYUK_DISABLED=true, but this had no effect.
I also tried Docker Settings -> General -> "Expose daemon on tcp://localhost:2375" without TLS, but this did not help either.

@mrsalt please share full logs

@mrsalt please share full logs

@bsideup Where do I find the logs?  Is there a troubleshooting guide?
Also, I just updated to 3.1.0, 3.0.4 was working.

@bsideup Where do I find the logs?  Is there a troubleshooting guide?
Also, I just updated to 3.1.0, 3.0.4 was working.

@mrsalt see https://www.testcontainers.org/supported_docker_environment/logging_config/

@mrsalt see https://www.testcontainers.org/supported_docker_environment/logging_config/

@bsideup , sorry, I've been trying to get more detailed logs but I don't know how to get logback working.
Here's what I've tried:

Add logback dependency in my project's pom.xml:

		<dependency>
			<groupId>ch.qos.logback</groupId>
			<artifactId>logback-classic</artifactId>
			<version>1.2.3</version>
			<scope>test</scope>
		</dependency>

Copy the XML snippet you shared at https://www.testcontainers.org/supported_docker_environment/logging_config/ into logback-test.xml, save this file into my project's src/test/resources
While debugging my test, getClass().getClassLoader().getResource("logback-test.xml") returns a URL, but getClass().getClassLoader().getResource("/logback-test.xml") returns NULL.
I also tried -Dlogback.configurationFile, but this didn't make a difference either.

Because the format of the log output isn't changing, it appears logback is not receiving the logging and providing extra details from org.testcontainers.  See attached
test-output.txt
(I've replaced a few paths with  where details are private/not important)
I noticed that my classpath also includes log4j...  I'll try to get that removed (since I'm not that good at log4j configuration) and just get logback in my classpath.

@bsideup , sorry, I've been trying to get more detailed logs but I don't know how to get logback working.
Here's what I've tried:

Add logback dependency in my project's pom.xml:

		<dependency>
			<groupId>ch.qos.logback</groupId>
			<artifactId>logback-classic</artifactId>
			<version>1.2.3</version>
			<scope>test</scope>
		</dependency>

Copy the XML snippet you shared at https://www.testcontainers.org/supported_docker_environment/logging_config/ into logback-test.xml, save this file into my project's src/test/resources
While debugging my test, getClass().getClassLoader().getResource("logback-test.xml") returns a URL, but getClass().getClassLoader().getResource("/logback-test.xml") returns NULL.
I also tried -Dlogback.configurationFile, but this didn't make a difference either.

Because the format of the log output isn't changing, it appears logback is not receiving the logging and providing extra details from org.testcontainers.  See attached
test-output.txt
(I've replaced a few paths with  where details are private/not important)
I noticed that my classpath also includes log4j...  I'll try to get that removed (since I'm not that good at log4j configuration) and just get logback in my classpath.

@mrsalt thanks for sharing the logs! log4j would also be fine, logback was given as a (preferred) example.
Is it really all the logs you get? Usually, when Ryuk fails to start, Testcontainers would print its logs for debugging - that's the part I was looking for, actually :)
Alternatively, you could docker ps -a and then docker logs $RYUK_ID

@mrsalt thanks for sharing the logs! log4j would also be fine, logback was given as a (preferred) example.
Is it really all the logs you get? Usually, when Ryuk fails to start, Testcontainers would print its logs for debugging - that's the part I was looking for, actually :)
Alternatively, you could docker ps -a and then docker logs $RYUK_ID

RYUK is starting up fine --
$ docker logs df3f9f6642b9
2021/01/14 18:28:33 Pinging Docker...
2021/01/14 18:28:33 Docker daemon is available!
2021/01/14 18:28:33 Starting on port 8080...
2021/01/14 18:28:33 Started!

It's just the connection to it that's failing...

RYUK is starting up fine --
$ docker logs df3f9f6642b9
2021/01/14 18:28:33 Pinging Docker...
2021/01/14 18:28:33 Docker daemon is available!
2021/01/14 18:28:33 Starting on port 8080...
2021/01/14 18:28:33 Started!

It's just the connection to it that's failing...

@bsideup , thanks for your help and I am sorry to waste your time.  I downgraded to Docker 3.0.4 -- and the problem persisted.  So I restarted Windows.  Voila!  Problem solved.  I've also updated to Docker 3.1.0 again, and the problem is not occurring.  So there is no issue with the Docker 3.1.0 update.  Just Windows being flaky.  (Or who knows really...  There are a lot of pieces in the stack here).

@bsideup , thanks for your help and I am sorry to waste your time.  I downgraded to Docker 3.0.4 -- and the problem persisted.  So I restarted Windows.  Voila!  Problem solved.  I've also updated to Docker 3.1.0 again, and the problem is not occurring.  So there is no issue with the Docker 3.1.0 update.  Just Windows being flaky.  (Or who knows really...  There are a lot of pieces in the stack here).

@mrsalt thanks for sharing! 👍
We have seen similar reports of this flaky behaviour of Docker for Windows, where a simple restart helped, which makes me think that it will eventually be fixed in Docker for Windows as this is not something we can change on our side :)

@mrsalt thanks for sharing! 👍
We have seen similar reports of this flaky behaviour of Docker for Windows, where a simple restart helped, which makes me think that it will eventually be fixed in Docker for Windows as this is not something we can change on our side :)

I just faced the exact same error message on my windows 10 system.
running netsh interface ipv4 show excludedportrange protocol=tcp, I found out, that the port mentioned, was within a excluded port range on my machine. The following range was listed amongst others... 49152 . . . 49251

I faced the very same problem many times now. It is super annoying if you have to restart windows for this to go away. It would be better if testcontainers could somehow try to prevent taking a restricted port on windows (see @javageek79 's comment above).

@KaiStapel I agree that it is annoying :) The port assignment is delegated to Docker (Testcontainers itself doesn't pick any ports), so I would recommend reporting this bug to Docker, as there is not much we can do, unfortunately.

@bsideup There already is: https://github.com/docker/for-win/issues/3171


HADOOP-15136. Correct typos in filesystem.md

https://issues.apache.org/jira/browse/HADOOP-15136

Merged.
David, if you are getting into rename semantics know that nobody is confident enough about it to be certain about what happens in cases, we know HDFS gets it "wrong" in some. If you have spare time a review of #743 would be wonderful.

Also: you got a login on the apache JIRA so I can assign/credit the issue there to you

If you have spare time a review of #743 would be wonderful.

Not sure if/how much I'll be able to help, but sure! I'll take a peek.

Also: you got a login on the apache JIRA so I can assign/credit the issue there to you

Yes, I'm also tucked on JIRA 😊

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 20s
trunk passed

+1 :green_heart:
mvnsite
1m 16s
trunk passed

+1 :green_heart:
shadedclient
48m 22s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
mvnsite
1m 10s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 34s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

69m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2314/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2314

Optional Tests
dupname asflicense mvnsite markdownlint

uname
Linux 81b973723627 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2377df38ad2

Max. process+thread count
337 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2314/1/console

versions
git=2.17.1 maven=3.6.0

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


NTR: [sneeze reflex]

Please provide as much information as you can:

Suggested term label: sneeze reflex

Definition (free text) A respiratory reflex process in which a chemical irritant or allergen stimulates nasal sensory neurons, giving rise to the sneeze reflex.

Reference, in format PMID:####### PMID:34133943

Gene product name and ID to be annotated to this term mouse Nmb (Q9CR53) & Nmbr (O54799)

Parent term(s) GO:0060004 (reflex)

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

Any other information

Adopting a more general definition may be better?

A more general definition is fine by me. Would something like the following work: "A respiratory reflex process in which nasal sensory neurons are stimulated, giving rise to the sneeze reflex"?

@magrane This is what I propose. Would it work?
"A reflex process that expels air forcibly from the mouth and nose in an explosive, spasmodic involuntary action resulting chiefly from irritation of the nasal mucous membrane." [https://www.thefreedictionary.com/sneeze, PMID:34133943]

Sounds good to me. Thanks!


Warning: Possible queue duplication with multiple processes

@jenssegers I previously implemented queues for a project using an older version of this library and looking at the MongoQueue.php in the master branch I noticed that it may suffer from the same issue as I did.
Running the queue as a daemon with multiple processes will cause a race condition where more then 1 process can select the same job before another has marked it as reserved. This in turn will produce randomly duplicated jobs.
The fix is to to get the next job and mark it as reserved using Mongo's findAndReplace to lock the document.
I created a "getNextAvailableJobAndReserve" method and updated the "pop" method to use it.
For reference here is what my MongobdQueue class method looks like, Take note of the modified pop and how it uses the getNextAvailableJobAndReserve method.
Hope this can be of some help.
<?php

namespace App\Mongodb\Queue;

use Carbon\Carbon;
use Illuminate\Queue\DatabaseQueue;
use DB;

class MongodbQueue extends DatabaseQueue
{
    /**
     * Pop the next job off of the queue.
     *
     * @param  string $queue
     *
     * @return \Illuminate\Contracts\Queue\Job|null
     */
    public function pop($queue = null)
    {
        $queue = $this->getQueue($queue);

        if (!is_null($this->expire))
        {
            $this->releaseJobsThatHaveBeenReservedTooLong($queue);
        }

        if ($job = $this->getNextAvailableJobAndReserve($queue))
        {
            return new MongodbJob(
                $this->container, $this, $job, $queue
            );
        }
    }

    /**
     * Release the jobs that have been reserved for too long.
     *
     * @param  string $queue
     *
     * @return void
     */
    protected function releaseJobsThatHaveBeenReservedTooLong($queue)
    {
        $expired  = Carbon::now()->subSeconds($this->expire)->getTimestamp();
        $reserved = $this->database->collection($this->table)
                                   ->where('queue', $this->getQueue($queue))
                                   ->where('reserved', 1)
                                   ->where('reserved_at', '<=', $expired)->get();

        foreach ($reserved as $job)
        {
            $attempts = $job['attempts'] + 1;
            $this->releaseJob($job['_id'], $attempts);
        }
    }

    /**
     * Get the next available job for the queue and mark it as reserved.
     *
     * @param  string|null $queue
     *
     * @return \StdClass|null
     */
    protected function getNextAvailableJobAndReserve($queue)
    {
        $job = DB::getCollection($this->table)->findAndModify(
            [
                'queue'        => $this->getQueue($queue),
                'reserved'     => 0,
                'available_at' => ['$lte' => $this->getTime()],

            ],
            [
                '$set' => [
                    'reserved'    => 1,
                    'reserved_at' => $this->getTime(),
                ],
            ],
            null,
            [
                'new' => true,
            ]
        );

        return $job ? (object)$job : null;
    }

    /**
     * Release the given job ID from reservation.
     *
     * @param  string $id
     *
     * @return void
     */
    protected function releaseJob($id, $attempts)
    {
        $this->database->table($this->table)->where('_id', $id)->update([
            'reserved'    => 0,
            'reserved_at' => null,
            'attempts'    => $attempts,
        ]);
    }

    /**
     * Delete a reserved job from the queue.
     *
     * @param  string $queue
     * @param  string $id
     *
     * @return void
     */
    public function deleteReserved($queue, $id)
    {
        $this->database->table($this->table)->where('_id', $id)->delete();
    }
}

is this version 2* or 3* ?

The class I supplied above would be suitable for version 2.
I have not looked at this library in a while but it looks like it's changed a bit since I used it.
For version 3 you would need to write the "findAndModify" query using the updated syntax like seen in this comment https://github.com/jenssegers/laravel-mongodb/issues/734#issuecomment-182938779

could this be a possible solution for #738 ?
i cant find a solution... id be glad if someone could point me to the right direction ^^

@Bodom78 Would you mind doing a PR for v2 and possible v3?

@leakingminds Not too sure about the #738 error as I never came across it. Perhaps because I was using an older build of the library.
@jenssegers Sure, I'll do my best when time allows as I'm keep to look over the changes of the library since I used it last.

I did a PR https://github.com/jenssegers/laravel-mongodb/pull/769 to solve this in master branch.
Now, it works fine to me. I hope help someone else.
=D

@giolvani Thanks for the PR, much appreciated.

#786


Add OCSP stapling support.

This PR adds capability to forward OCSP staple from kubernetes secret to Envoy.
PR covers Stage 1 of following design: https://docs.google.com/document/d/15wwYyVyOluubL2KIM89b2X8NFwyhMVxq2_I1MESrZdI/edit?pli=1
Where:

Stage 1 - implement OCSP staple forwarding to Envoy proxy
Stage 2 - implement control mechanism allowing to choose Envoy stapling mode via secret annotations

Brief
OSCP staple is DER encoded response provided by OSCP server as a reply to OSCP request.
Such response is stapled to TLS Certificate and provided to client on https handshake.
This PR implements forwarding of the OCSP staple to Envoy proxy.
OSCP staple is expected to be found inside kubernetes secret under field named tls.staple.
Pre-fetching OSCP response and storing it in kubernetes secret is left out intentionally, allowing usage of any third-party components: stand-alone operator or cert-manager.
Existence of tls.staple key is optional in a sense that it's absence is not changing current Istio behavior.
However when tls.staple entry is present in the secret it is forwarded to Envoy proxy as inline bytes.
Choosing Envoy OSCP stapling policy is outside of this PR scope as well.
One of possible implementations for setting Envoy stapling policy is secret annotation mentioned in desigend document above.
Another option is to configure Enovy stapling policy via EnvoyFilter object.
Related to issue #17763

/ok-to-test

@lukbuc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
dbc0f7e5ac5445f3e2addca8ab48a4c533accefb
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lukbuc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
dbc0f7e5ac5445f3e2addca8ab48a4c533accefb
link
true
/test unit-tests-arm64

unit-tests_istio
dbc0f7e5ac5445f3e2addca8ab48a4c533accefb
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn I'll mention it Today. There is cert-manager meeting running in parallel to Today's Istio meeting.
This is feature request I posted on cert-manager's github:
https://github.com/cert-manager/cert-manager/issues/5785


Few requests

This is by far one of the coolest toolbars ive ever seen for android howevor their are a few things id like to see in the near future since i have begun to use this library.
Home icon as clickable action
Ability add overflow menu beside action item
Home icon as a icon spinner menu for switching different fragments?
Add a menu similar to this toolbar concept http://codepen.io/OfficialAntarctica/pen/QdbZjy
Again, stupendous work!

I added the overflow menu and a back button ;)


provideLocalStorageDataClass: Separate localstorage by tenantId

This way - in a multi tenancy setup - the data from one tenant does not show up in another tenant.
Please note, that all existing localstorage data will no longer be readable.

REVIEW (c2128b3)


review task 05

Please review task 05, in this test (modifiedBoard.cy.js) is modified the title of boar of "Test 01" for "Test 02".

Please review commit "Fix to PR mu_05"

please review the changes in the commit "[Merge branch 'main' into mu_05]"

Please review the last commit.
Thanks.

Please review,  commit "fix to task mu_05, fix to typos and others"
Thanks

Thanks, it seemed to be fine in vscode but I saw that it is marked in red when the code indentation is wrong. I hope to merge this time.


Bind each module_function to static method

@FnControlOption can you talk about your thinking here? Is this just to differentiate between methods that use this and those that don't?

OK, I figured out what this is all about... It wasn't obvious to me why these needed to change, but looking in IRB tells the subtle story:
→ bin/natalie
nat> method(:abort)
#<Method: Kernel#abort(*)>
nat> Kernel.method(:abort)
#<Method: Kernel#abort(*)>
nat>

→ irb
irb(main):001:0> method(:abort)
=> #<Method: Object(Kernel)#abort(*)>
irb(main):002:0> Kernel.method(:abort)
=> #<Method: Kernel.abort(*)>
irb(main):003:0>

_Note: Kernel.abort(*) vs Kernel#abort(*). Kinda wild.

I'm sorry this will need to be rebased or have master merged in... :grimacing:

Note: Kernel.abort(*) vs Kernel#abort(*). Kinda wild.

Sorry, I should have explained that instead of opening this PR with another empty description 😅


The boot.loader.grub.zfsSupport property is ignored

When I updated my nixpkgs repo to the latest version of the 15.09 channel, I saw that zfs-user was being build even though I do not use ZFS. I checked all-packages.nix and grub.nix and found the defaults no longer match the assumptions made in grub.nix.
Currently all-packages.nix contains the following:
grub2 = grub2_full;

grub2_full = callPackage ../tools/misc/grub/2.0x.nix { };

grub2_efi = grub2_full.override {
  efiSupport = true;
};

grub2_light = grub2_full.override {
  zfsSupport = false;
};

While grub.nix still has the following:
realGrub = if cfg.version == 1 then pkgs.grub
  else if cfg.zfsSupport then pkgs.grub2.override { zfsSupport = true; }
  else if cfg.enableTrustedBoot then pkgs.trustedGrub
         else pkgs.grub2;

Since pkgs.grub2 is defined as grub2_full, which has zfsSupport ? true, there currently is no difference between pkgs.grub2.override { zfsSupport = true; } and pkgs.grub2. I do not see the need for grub_full, grub_efi and grub_light. Would it not be better to keep things configurable the way they are using options such as boot.loader.grub.zfsSupport?

They are defined this way to ensure zfs support is included when running
grub with zfs but not necessarily building with it at the top level(even
though in this instance we are building with it).
On Mon, Dec 7, 2015, 10:29 AM msteen<EMAIL_ADDRESS>wrote:

When I updated my nixpkgs repo to the latest version of the 15.09 channel,
I saw that zfs-user was being build even though I do not use ZFS. I checked
all-packages.nix and grub.nix and found the defaults no longer match the
assumptions made in grub.nix.
Currently all-packages.nix contains the following:
grub2 = grub2_full;
grub2_full = callPackage ../tools/misc/grub/2.0x.nix { };
grub2_efi = grub2_full.override {
efiSupport = true;
};
grub2_light = grub2_full.override {
zfsSupport = false;
};
While grub.nix still has the following:
realGrub = if cfg.version == 1 then pkgs.grub
else if cfg.zfsSupport then pkgs.grub2.override { zfsSupport = true; }
else if cfg.enableTrustedBoot then pkgs.trustedGrub
else pkgs.grub2;
Since pkgs.grub2 is defined as grub2_full, which has zfsSupport ? true,
there currently is no difference between pkgs.grub2.override { zfsSupport
= true; } and pkgs.grub2. I do not see the need for grub_full, grub_efi
and grub_light. Would it not be better to keep things configurable the
way they are using options such as boot.loader.grub.zfsSupport?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/11533.

You need grub2_efi if you want to support efi systems and have hydra build
the binary for you. Unfortunately the way to the grub build works,
grub2_efi is mutually exclusive from grub2_full in that it only has efi
binaries while grub2_full has bios compatible binaries.
On Mon, Dec 7, 2015, 10:42 AM William Kennington<EMAIL_ADDRESS>wrote:

They are defined this way to ensure zfs support is included when running
grub with zfs but not necessarily building with it at the top level(even
though in this instance we are building with it).
On Mon, Dec 7, 2015, 10:29 AM msteen<EMAIL_ADDRESS>wrote:

When I updated my nixpkgs repo to the latest version of the 15.09
channel, I saw that zfs-user was being build even though I do not use ZFS.
I checked all-packages.nix and grub.nix and found the defaults no longer
match the assumptions made in grub.nix.
Currently all-packages.nix contains the following:
grub2 = grub2_full;
grub2_full = callPackage ../tools/misc/grub/2.0x.nix { };
grub2_efi = grub2_full.override {
efiSupport = true;
};
grub2_light = grub2_full.override {
zfsSupport = false;
};
While grub.nix still has the following:
realGrub = if cfg.version == 1 then pkgs.grub
else if cfg.zfsSupport then pkgs.grub2.override { zfsSupport = true; }
else if cfg.enableTrustedBoot then pkgs.trustedGrub
else pkgs.grub2;
Since pkgs.grub2 is defined as grub2_full, which has zfsSupport ? true,
there currently is no difference between pkgs.grub2.override {
zfsSupport = true; } and pkgs.grub2. I do not see the need for grub_full,
grub_efi and grub_light. Would it not be better to keep things
configurable the way they are using options such as
boot.loader.grub.zfsSupport?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/11533.

The reason to have those different packages is to have the binaries build for you by Hydra, that answers my question why there are three versions of grub in all-packages.nix, but it does not address the issue. Or I must be misunderstanding something about your first comment. And why not grub2 (with zfsSupport ? false) and grub2_zfs, instead of grub_full and grub_light? Should grub.nix not be changed e.g. like this:
realGrub = if cfg.version == 1 then pkgs.grub
  else if cfg.zfsSupport then pkgs.grub2_full
  else if cfg.enableTrustedBoot then pkgs.trustedGrub
         else pkgs.grub2_light;

That doesn't really make a difference as this function is used not only for
grub2_full but also applies to grub2_efi to make sure the efi binaries also
support zfs. This is much cleaner than having a derivation for every single
permutation listed in the NixOS module.
On Mon, Dec 7, 2015, 10:58 AM msteen<EMAIL_ADDRESS>wrote:

The reason to have those different packages is to have the binaries build
for you by Hydra, that answers my question why there are three versions of
grub in all-packages.nix, but it does not address the issue. Or I must be
misunderstanding something about your first comment. And why not grub2
(with zfsSupport ? false) and grub2_zfs, instead of grub_full and
grub_light? Should grub.nix not be changed e.g. like this:
realGrub = if cfg.version == 1 then pkgs.grub
else if cfg.zfsSupport then pkgs.grub2_full
else if cfg.enableTrustedBoot then pkgs.trustedGrub
else pkgs.grub2_light;
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/11533#issuecomment-162624203.

I understand that you would not want to have a version for each permutation, but there are 3 versions, of which only two are available through the NixOS module options. Or how can I configure my NixOS such that pkgs.grub2_light is being used?

Or to put it another way, what is the use of boot.loader.grub.zfsSupport if it is being ignored anyway? Since I am currently getting ZFS support, while I have no need for it.

(triage) still an issue?


upgrade celery

Issue 112
Yeah I know we can bypass this error by setting kombu to 4.1.0, however the community has already fixed it in version >= 4.1.1. So I think it's time to update our requirements.txt and run some tests on it (found working well without any changes in my environment)

Disable annoying InsecureRequestWarning


How to remove(delete / replace) a contract ?

Hi,
Does anyone know which command to execute in order to delete previously published(uploaded) contract ?
Kind Regards,
Paul.

To replace code you can just use the same cleos command you used to upload code. To delete code - upload wast and abi files which does nothing? To free RAM your contract uses, the only way I'm aware of is to do it from contract itself (add an action in your contract which deletes all the rows in all of the tables). Maybe someone else can suggest a better way of doing these things?

With eosjs, the following code should do the trick:
eos.setcode(account_name, 0, 0, new Uint8Array());

Setting the code to an empty byte array also changes code hash to 0. It's a much better solution than replacing it with a contract that does nothing, as such a contract still takes up RAM space and thus EOS.

@xJonathanLEI What would happen to any tables that were already in use for that contract? Would they be orphaned yet still cost RAM? Should you first empty the tables out?

Update: according to @michaeljyeates on Telegram, you should first empty any tables out before setting the wasm code to an empty array.


Error messages

I get the following errors
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/climatisationWithoutExternalPower: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/climatizationAtUnlock: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/windowHeatingEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/zoneFrontLeftEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/zoneFrontRightEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/zoneRearLeftEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/zoneRearRightEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: id /vehicles/XXXXXX/controls/charging cannot be set. You need to provide it in the correct format select one of [start, stop]
INFO:weconnect-mqtt:Error setting value: id /vehicles/XXXXXX/controls/climatization cannot be set. You need to provide it in the correct format select one of [start, stop]
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/climatisationWithoutExternalPower: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/climatizationAtUnlock: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/windowHeatingEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/zoneFrontLeftEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/zoneFrontRightEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXXstatus/climatisationSettings/zoneRearLeftEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: /vehicles/XXXXXX/status/climatisationSettings/zoneRearRightEnabled: new value must be of type <class 'bool'> but is of type <class 'str'>
INFO:weconnect-mqtt:Error setting value: id /vehicles/XXXXXX/controls/charging cannot be set. You need to provide it in the correct format select one of [start, stop]
INFO:weconnect-mqtt:Error setting value: id /vehicles/XXXXXX/controls/climatization cannot be set. You need to provide it in the correct format select one of [start, stop]
Most data is received in MQTT server.

I'll have a look. My first idea is that the client receives the old messages it had previously published itself when subscribing. My idea was that this won't happen if I publish an empty message with retain flag. I have to check the standard there. For now I'll see if I can just ignore empty messages.
So I guess all you can see is correct, but I have to get rid of the ugly error messages.

@maxverstappen can you check if Version 0.6.2 fixes your problem? Thanks!

10 points. Works like a charm.

Nice!


http://localhost:8080/feature/ Page NOT FOUND

Bug Report
Which version of the demo you are using? (please provide either a specific
git clone https://github.com/open-telemetry/opentelemetry-demo.git
Symptom
When this URL is executed --http://localhost:8080/feature/ .. Getting PAGE NOT FOUND.. Rest all the URLs are working
OpenTelemetry Demo is running.
Go to http://localhost:8080 for the demo UI.
Go to http://localhost:8080/jaeger/ui for the Jaeger UI.
Go to http://localhost:8080/grafana/ for the Grafana UI.
Go to http://localhost:8080/loadgen/ for the Load Generator UI.
Go to http://localhost:8080/feature/ for the Feature Flag UI.
What is the expected behavior?
The feature flag PAGE
What is the actual behavior?
PAGE NOT FOUND
Reproduce

git clone https://github.com/open-telemetry/opentelemetry-demo.git
make start
try to hit the URL after the installation is done

We will close this issue if:

The steps you provided are complex.
If we can not reproduce the behavior you're reporting.

Additional Context
Add any other context about the problem here.

Hello @av-nextleap,
The feature endpoint was removed from the demo on this PR: #1388
Seems that we've missed 2 lines where the endpoint was mentioned.
I've opened the PR #1461 to remove the reference to the endpoint.

if that is removed then from where we can access the functionality

@av-nextleap that's now explained here: https://opentelemetry.io/docs/demo/feature-flags/


remove extensions

@cheungpat, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rickmak to be a potential reviewer


News source breaks into newline when there is no space

&nbsp tag can be used to prevent news source link from breaking into a new line which makes it more readable and better looking.

I'd be glad to do the change and open a pull request in case if the repo is open for contributions. Let me know.

That would be great, please feel free to open a PR!

Fixed a slightly different way in 2.4.0 so I'm closing this issue. Thanks for the info!


Billing RP Swagger changes for Indirect commerce channel

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

LGTM. ready to merge?

/azp run automation - sdk

LGTM. ready to merge?

I pushed an update where the changes to "AgreementProperties" definition are reverted. I will drive those changes in separate PR as there are some more changes required for Agreements.
Please take a look and rest is ready to be merged.


[Tizen] Enable WiFi management from example app

Problem
Tizen examples are based on Linux code. Tizen and Linux are using wpa_supplicant for WiFi management. In Linux example code, WiFi feature is controlled by CHIP_DEVICE_CONFIG_ENABLE_WPA feature flag, however, Tizen configuration does not. In order to properly support WiFi management Tizen needs to use CHIP_DEVICE_CONFIG_ENABLE_WPA as well and needs to implement missing functions.
Changes

Implement WiFi started check function
Fix incorrect feature flag for enabling WiFi in Tizen example
Simplify WiFiManager::IsActivated() usage (reuse it in other functions)
Apply clang-tidy modernize-redundant-void-arg on modified files
Activate/deactivate WiFi without async wrapper
Add missing "network.set" privilege required for WiFi management

Testing
CI will check potential build failures. Tizen WiFi functionality was tested with Tizen lighting-all:
app_launcher -k org.tizen.matter.example.lighting
...
I/CHIP    ( 1935): SVR: Manual pairing code: [34970112332]
I/CHIP    ( 1935): SVR: Server initializing...
...

app_launcher -k org.tizen.matter.example.lighting wifi true
...
I/CHIP    ( 1888): SVR: Manual pairing code: [34970112332]
I/CHIP    ( 1888): DL: WiFi is already activated              <- WiFi check in EnsureWiFiIsStarted() call done by ChipLinuxAppInit()
I/CHIP    ( 1888): SVR: Server initializing...
...

I've tested these changes with the Lightapp on Tizen and chip-tool on Linux. Everything worked as expected.


Karma-coverage not generating coverage reports for large projects.

Hi there,
I am posting an issue here in the core repo because I have not received feedback from any maintainers on karma-coverage since posting this issue earlier this year.
Because of this deprecation warning, teams such as ours with relatively large test suites are nervous that we'll eventually lose coverage reports once karma-coverage-instanbul-reporter is no longer supported.

Please advise on how to proceed and if this issue can be elevated to the core team's triaging.

Hey @cklogs, this is a tough situation to be stuck in. Unfortunately this seems like mostly a karma-coverage issue, so we hope they are able to give some direction on how to fix your particular problem which would be the ideal solution here.
We are planning to support just karma-coverage in the CLI and want to stick with official solutions as best we can. We don't want to continue supporting two test coverage solutions long term and our hope is that karma-coverage will be able to provide the necessary user support.
In the mean time, there's nothing actionable on this from the Angular side, so I'm closing this issue.


[CHANGE ME] Re-generated to pick up changes from googleapis.

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/a0fa0bb5-ad7e-435c-ac39-17051adf64ae/targets

[ ] To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 346434847
Source-Link: https://github.com/googleapis/googleapis/commit/e4d01555afeb93d2f3b467056ea884b092567d1b
PiperOrigin-RevId: 346372957
Source-Link: https://github.com/googleapis/googleapis/commit/857f70daef9f4c38f042fb3dfb7b8423ae18fd19
PiperOrigin-RevId: 346126713
Source-Link: https://github.com/googleapis/googleapis/commit/b8b2f8c288cec1f673bf10aa5008819c1576bf2e
PiperOrigin-RevId: 345476969
Source-Link: https://github.com/googleapis/googleapis/commit/7be2c821dd88109038c55c89f7dd48f092eeab9d
PiperOrigin-RevId: 345067549
Source-Link: https://github.com/googleapis/googleapis/commit/8cfc6c874574b649b4524a4ef6a0651533325a84
PiperOrigin-RevId: 345049577
Source-Link: https://github.com/googleapis/googleapis/commit/ca7389d35c91ba8aae893fbafd68127d1ff535d2
PiperOrigin-RevId: 344134135
Source-Link: https://github.com/googleapis/googleapis/commit/b11a87f3b54be3a5e42c15020ee1e0781f86da90
PiperOrigin-RevId: 342188199
Source-Link: https://github.com/googleapis/googleapis/commit/836f0eaf5f21f300f63ac635e5ef263d183e0cdd

To reviewer: sorry I'm not very familiar with our release process on this type of PR, but would you mind providing a rough estimate of when commit c7ffbf4 will be merged into our client library? Thank you!


Unexpected behaviour using StateInit outside of contract context

contract B {
    owner: Address;
    init(addr: Address){
        self.owner = addr;
    }
}

fun get_init(addr: Address): StateInit {
    return initOf B(addr);
}

contract A {
    receive("aa") {
        let c: StateInit = get_init(myAddress()); // fails
        // let c: StateInit = initOf B(myAddress()); // succeeds
    }
}

Build succeeds but execution fails with exit code 135: Code of a contract was not found
Moreover, the following also compiles
fun get_init(): StateInit {
    return initOf B(myAddress());
}

but clearly the context of the calling contract is not preserved when calling myAddress() from an external function.

@0kenx I can't reproduce the problem here. Copied the code, send aa message to the contract A and no errors occured. Can you share the test source code too please?

@Gusarich Let's then add the example posted by @0kenx to the test suite to resolve this issue

@Gusarich Looks like I missed it was that code :) Thanks.
@0kenx Closing this, feel free to re-open if the issue is not resolved


Fix tls statemachine during tls v1.2 renegotiation

thanks, this looks much better :)

Looks good to me.

Are there any security risks by handling/accepting renegotiations?

https://github.com/google/boringssl/blob/master/PORTING.md#tls-renegotiation
https://github.com/curl/curl/issues/3258

Or is this unrelated?

Maybe we could make it configurable for specific HTTP URL paths to allow TLS 1.2 renegotiation in a hopefully simple and readable way.


Source request: NetlifyCMS plugin

Hi,
I'd like to add a support to integrate netlifycms as a source for gridsome, but i'm facing some problem,
Following netlifycms doc : Add to your site
How can i inject with plugin a new page (from router) with required basic html and on other page add the Netlify Identity Widget ?
So we need to populate a new folder eg: 'admin/' with

index.html
config.yml

Example of GatsbyJS : Gatsbyjs plugin netlifycms

Have you considered asking this question in the Gridsome discord community?

That's correct according to the Netlify CMS Docs: https://www.netlifycms.org/docs/add-to-your-site/#app-file-structure

Steps:

The build process and develop process need to create an admin folder, populate 2 files (index.html and config.yml) depending of the plugin's config

add the Netlify Identity Widget on all page

Close as plugin exists
https://github.com/gethypervisual/gridsome-plugin-netlify-cms


Consifer adding wait or drain or similiar method for Stream

I constantly facing with problem that I need convert stream into future, but only when stream will be drained. Here is the signatue
fn drain(self) -> impl Future<Item = (), Error = Stream::Error>;

For me the function would be useful if it required that Self::Error == (), so one can be sure that the stream runs to completion and is not interrupted on error.

.for_each( |_| ready(()) ) does work. However it doesn't convey meaning very well for someone reading the code. I also don't know how it's for performance, but it does seem a workaround at best.
I really find into_future to be what I expected to do this. I wonder what into_future currently adds over next. Does anyone use it. That being said, maybe drain is a good name. I'm not sure what the best way of implementing it would be. I suspect the foreach construct isn't the best way of doing it.

I think this is easy enough to write in-place now that async/await is stable.

I'm not sure how to utilize async/await here, but I use
stream.forward(futures::sink::drain())

It's not very concise, but I think it conveys intention pretty well. Hope that will be of help for those who come here through google like I did quite a few times.

stream.forward(futures::sink::drain())

While this woks it also requires to have a .map(Ok) in front of in some cases, due to Drain wanting an Error of Infallible.
Would be really nice to have an actual drain method.
In my use case I have different errors, that can cause a web endpoint to fail. Before returning, I need to drain the stream, so I have the .map(Ok).forward(futures::sink::drain()) a lot there. Could use .for_each(|_| ready(())) as well, but a dedicated drain() method on the StreamExt trait would be really helpful.


Fix test include_overrides_gitignore.

This test was added in #4180 and was disabled in #4218.  I don't think it is really feasible to get filetime into the test. The test was also using some questionable behavior of modifying contents of src from a build.rs script.  I rewrote the test to directly test the original change of having package.include override .gitignore.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit bb614d4305c44606031a6b57dcdf7bbf386d7922 has been approved by alexcrichton

:hourglass: Testing commit bb614d4305c44606031a6b57dcdf7bbf386d7922 with merge ef0223f12597b5e0d9d2feed1b92c41306b1fc05...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing ef0223f12597b5e0d9d2feed1b92c41306b1fc05 to master...


Updating Framework Version

You did it @sandeepmantha!
Thank you for signing the Anthem Opensource Software CLA.


Order by most recent registration first (created_at DESC) by default

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

This seems to be a sane default setting. The probability is high that we want to deal with the most recent users first. Having an application with >10000 users this default settings would be nice.

Thanks!


Connect WA-PHD to WA UAT (test)

Connect both staging and prod to WA UAT
This PR contains the settings for connecting staging and prod to WA UAT
Changes

Prod YML
Staging YML

Checklist
Testing

[x] Tested locally?
[x] Ran quickTest all?
[x] Ran ./prime test against local Docker ReportStream container?
[ ] Downloaded a file from http://localhost:7071/api/download?
[ ] Added tests?

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes
List GitHub issues this PR fixes

#414

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Should those new receivers be added to the organizations-prod.yml and organizations-test.yml files?


Fix style

[x] I've made sure the Changelog.md will remain up-to-date after this PR is merged.

PTAL @cndoit18


Relieve the problem of RedisService occupying too much storage space

RedisService currently occupies 80+MB of storage space, but it is only used to enable the redis-service.exe service. Try using Dotnet8's AOP compilation to reduce its usage.
In addition, I have replaced the ACTION_TOKEN in CI with GITHUB_TOKEN. In current usage, using GITHUB_TOKEN is more convenient and secure than manually configuring ACTION_TOKEN, as each action run automatically generates a temporary GITHUB_TOKEN.

RedisService currently occupies 80+MB of storage space, but it is only used to enable the redis-service.exe service. Try using Dotnet8's Aot compilation to reduce its usage.
In addition, I have replaced the ACTION_TOKEN in CI with GITHUB_TOKEN. In current usage, using GITHUB_TOKEN is more convenient and secure than manually configuring ACTION_TOKEN, as each action run automatically generates a temporary GITHUB_TOKEN.


Do not setup API authenticator when using concrete URL

Avoids the need to setup API key or vespa auth login when you simply want to
interact directly with a deployment.
@jonmv

Thanks! So we can remove this line then?
https://github.com/vespa-engine/documentation/blob/master/.github/workflows/feed.yml#L52
    export VESPA_CLI_API_KEY=

Yes.


Upgrade to Version 12 (Take 2)

@Scuilion thanks!! 😃

Thanks for the time. Upgrading this was helpful to better understanding infinispan.


Can Mosquitto connect to MQTT over Websocket for Azure IoT?

Hi,
I had implemented one solution based on the sample where I used Port 8883. All works perfect.
But now I am facing issue over firewall since 8883 is blocked there. Thus need to use MQTT over Websocket.
Thus was looking for solution using mosquitto itself. Is there any way, can anyone point me to that?
I found documents and sample on websocket, but all of them are localhost broker. It can be great if I can get some sample or points by which I can make communicate Azure IoT using 443 port.

Hi @sirsendu,
IoT Hub support Websocket over port 443. Simply connect to port 443 using the mosquitto library.
https://learn.microsoft.com/en-us/azure/iot-hub/iot-hub-devguide-protocols
FYI: Mosquitto_pub does not support Websockets.


[python/ci] Unbreak Python 3.8 CI

This started happening today. Example PRs: #2322 , #2305
Example run: https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8438883696/job/23112155507?pr=2322#step:9:279
from importlib_metadata import distribution
ModuleNotFoundError: No module named 'importlib_metadata

Note: TileDB-SOMA has no direct dependency on this package importlib_metadata. (We do use importlib.metadata here: https://github.com/single-cell-data/TileDB-SOMA/blob/main/apis/python/src/tiledbsoma/_general_utilities.py#L33-L51)
This is a Python 3.8 build.
I am googling around and finding https://github.com/python-poetry/poetry/issues/1487 which is not current, but, I am digging

Appears to have been caused by https://github.com/scikit-build/cmake-python-distributions/issues/472#issuecomment-2020852519


chore: Improve WalletModal UI

What changed? Why?

Before
After

**Notes to reviewers**
How has it been tested?

Looks much better