Move Java docs into this repo

I agree that having code samples in this repository doesn't make a ton of sense, but my understanding that the rationale from maintainers to keep docs + samples in the main repo was to ensure they were updated alongside the SDK releases. If that isn't a concern any more, and they're going to be divorced from it anyway, then I'd strongly urge for all documentation to be migrated directly into this repository, with a separate code sample repository being maintained.
Our eventual goal would be to migrate all docs to the website at the end of the day (aside from things that don't make sense, like auto-generated API docs or things that require language-specific tooling; javadoc, et. al.) so that we can enable versioning of the documentation and promote the website as a "one stop shop" for OTel docs.

Originally posted by @austinlparker in https://github.com/open-telemetry/opentelemetry.io/issues/978#issuecomment-995156648

[x] Move doc files into this repo - #1002
[x] Delete website_docs folder from https://github.com/open-telemetry/opentelemetry-java https://github.com/open-telemetry/opentelemetry-java/pull/4019
[x] Delete website_docs folder from https://github.com/open-telemetry/opentelemetry-java-docs - https://github.com/open-telemetry/opentelemetry-java-docs/pull/9

cc @jkwatson @anuraaga

If we move some docs into here, and some docs into the common java docs repo, and we have some docs in the individual repos, then we'll have 3 places that have to be updated. I think that is too much for maintainers to worry about.

@jkwatson - You are right that having docs spread out is a headache for maintainers. Now multiply that by 11 languages and you'll get a better appreciation of the maintenance challenge for this repo.
As a language SIG you have the liberty to organize your source code as you see fit, which includes moving example code into a separate repo (which, if I understand correctly, is one of the objectives behind the creation of your new repo).
The Comms team's mandate includes ensuring that docs/website maintenance remains manageable for the entire community -- all 11 languages. We're doing our best to accommodate language SIGs, but we set limits so that we can keep our sanity. These limits are as follows:

Our main objective is to repatriate all "non-API docs" (#833, also see note 1 below) into this repo. Most of the docs are here, but some still need to be moved.
We make an exception for language SIGs that prefer to colocate main-repo code and docs. This is the only exception.

If you've decided that the Java docs don't need to be colocated with the main-repo code, then those docs come back here. Given this broader perspective, I'm hopeful that you'll understand our reasoning.

@chalin Were these decisions made after consulting maintainers, or completely ad-hoc without consultation? OTel maintainers are generally over-committed already, so before you make decisions that will impact us, it's probably a good idea to talk to us about it.

I believe that having 2 java repositories consolidate their documentation into 1 docs repository makes the docs team's job easier, doesn't it? Now you only have 1 place to sync with, rather than the 2 you would otherwise have.

I totally get being over-committed already.
I do believe that @austinlparker brought up the subject at a maintainers meeting. For our decision, see https://github.com/open-telemetry/opentelemetry.io/issues/661#issuecomment-918336385:

Per discussion during the last comms meeting, we'll be moving forward with the following -

If maintainers wish to keep the canonical copy of their docs in their SIG repo, those docs will be pulled into opentelemetry.io via submodule.
Otherwise, their docs will be migrated back to the opentelemetry.io repository.

This ensures that there is only ever one copy of the documentation.
We strongly recommend that maintainers choose to host the canonical copy of their documentation on opentelemetry.io repository in order to benefit from upcoming features such as internationalization and versioning.

As for your comment:

I believe that having 2 java repositories consolidate their documentation into 1 docs repository makes the docs team's job easier, doesn't it? Now you only have 1 place to sync with, rather than the 2 you would otherwise have.

Oh, so you're consolidating all the Java docs under the new repo?
Btw, even if the Java docs are not in this repo, Java maintainers need to be mindful of not breaking the docs build. Having the docs elsewhere makes that much more difficult to ensure.
Ok, I'll see if @austinlparker is available to discuss this next week. Maybe you'd be available too?

Btw, even if the Java docs are not in this repo, Java maintainers need to be mindful of not breaking the docs build. Having the docs elsewhere makes that much more difficult to ensure.

Would it be possible that regardless of where Javadocs end up that there could be a doc test in the Java side?

If we move some docs into here, and some docs into the common java docs repo, and we have some docs in the individual repos, then we'll have 3 places that have to be updated. I think that is too much for maintainers to worry about.

I want to point out that what we've tried to do since the beginning was have all docs in a single place, but some maintainers (including Java) demurred because they believed having docs 'close' to the SIG repo would improve doc quality. And yes, it's been brought up several time at maintainer meetings.
I get that maintainers are over-subscribed, but as the project expands then it becomes less and less maintainable for every SIG to make their own individual decision about where to put documentation and makes it significantly harder on docs contributors who, often, work across languages.
More bluntly, why should the convenience of the Java maintainers be prioritized over the convenience of general contributors, or the onboarding experience for new project users?

In the interests of getting the required updates done before the holidays, we'll go ahead and submit PR's to fix the links on the submodule side and pull it into the website.

My perspective - as someone who's been starting to add docs for each language, and plans on doing that for quite a while - is that hopping around between different repos is much more challenging.
For example:

Policy requires multiple maintainer approvals, which means turnaround tends to be longer because folks are busy maintaining the SDK itself - go, python repos so far
PRs that have been approved by maintainers but are blocked until the unrelated build issue is resolved - go, ruby repos so far
Differing approaches to IA and what to emphasize limiting what can be contributed - ruby repo so far

So far the Java docs repo has been pleasant to contribute to, since it's simple and folks are quick to approve and merge if the content is good. I've appreciated how responsive folks are. But in the general case, it's already caused some stutters in the process with 3 language repos and it's likely to cause more.
I can work with either approach, but would prefer a docs repo to be the source of truth, at least for concepts that are stable in the SDK.

Other advantages for having the docs here:

You can submit a PR and know if you've broken the build, and if so, fix the problem.
PRs automatically get a deployed preview. That's (very) challenging to get when docs are pulled in from another submodule.

If you're modifying docs in a submodule, it's easy to break the build, for example: https://github.com/open-telemetry/opentelemetry-java-docs/pull/7. Now that's a pain, because the person who updates the submodule, will probably not be the person who make the doc changes, and so, for non-trivial cases, it can require tracking down the original author and having them submit changes. As @cartermp points out, that decouples the cost & effort of making doc changes.

Thanks for sharing your perspective @cartermp!

FWIW, I think the java maintainers, at least myself, don't put enough time into docs to have a huge say in the matter :P We needed to have a repo with shared docs because of how related SDK and instrumentation functionality is and came up with the opentelemetry-java-docs repo, but in reality I think it's OK for that to only focus on code samples. I don't see a problem from a maintenance perspective from having the website docs managed here, especially if someone can help contribute tooling that creates a PR to this repo automatically during our release process updating version numbers, like this one
https://github.com/open-telemetry/opentelemetry-java/pull/3934/files#diff-85b479b7a0513e35b12d73774cea2cf9cefedc41900ad8b55949cb7d3faa9ffe

Thanks for the honest feedback @anuraaga!

I don't see a problem from a maintenance perspective from having the website docs managed here, especially if someone can help contribute tooling that creates a PR to this repo automatically during our release process updating version numbers

I'll gladly help streamline that process.

Agree with @anuraaga. It's important that we have a place to put working code that incorporates opentelemetry-java-instrumentation, the opentelemetry-java, and opentelemetry-contrib. Having good code examples on topics that are cross cutting is important to adoption.
The docs will end up referencing these code samples, and ideally they would be located in the same place. I don't think the docs repo is a good place for the code samples to live, since there's decent amount of build tooling that comes with that, and having N languages worth of build tooling live in the docs repo (assuming other languages will face similar challenges) seems challenging.
Keeping the docs separate with relevant links to the code samples seems like a fine compromise.

Keeping the docs separate with relevant links to the code samples seems like a fine compromise.

I worry about chicken/egg situations where changes to the code samples will break documentation links until the documentation can be updated. How can these two be coordinated if they are kept in separate repositories?

Only internal links are checked as part of CI (because external link checking isn't fully configured yet -- though you can check external links manually) so, there's no risk of breaking the docs build if code changes are committed first, which is what I've seen happen most often.

Only internal links are checked as part of CI (because external link checking isn't fully configured yet -- though you can check external links manually) so, there's no risk of breaking the docs build if code changes are committed first, which is what I've seen happen most often.

I'm not worried about breaking the docs build but the currently in-place docs, since changes to a far-flung repository will create broken links with no one having any idea that it's occurred until a user complains about it.

@chalin If it's possible for the docs build to generate a list of referenced external URLs, I think we could add a link checking job to the code samples repo when making changes to it. Does that sound possible?

@chalin If it's possible for the docs build to generate a list of referenced external URLs, I think we could add a link checking job to the code samples repo when making changes to it. Does that sound possible?

Yes! I've been working on such a solution (part-time) since the spring. I'll give it more priority in 22Q1.

All done. Thanks to all for your participation in the discussion.


Cannot run this project in MacOS with Nix

Reproduces

clone this repository
run command nix develop -c $SHELL
run command dune build
Error

server-reason-react  main via 🐫 v5.1.1+dev0-2023-09-14  ❄  impure
❯ dune build
File "_none_", line 1:
Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Location, and its interface was not compiled with -opaque
File "_none_", line 1:
Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Stdppx, and its interface was not compiled with -opaque
File "_none_", line 1:
Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Compmisc, and its interface was not compiled with -opaque

File "_none_", line 1:
Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Location, and its interface was not compiled with -opaque
File "_none_", line 1:
Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Alcotest_engine__Test, and its interface was not compiled with -opaque

File "_none_", line 1:
Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Alcotest_engine__Core, and its interface was not compiled with -opaque

File "_none_", line 1:
Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Alcotest_engine__Config, and its interface was not compiled with -opaque

Thank you

You can modify the dune file to exclude the cmx warning  (-warn-error +A-d-58 -alert ++browser_only)))). @davesnx Maybe that can be the default. Not sure if having this warning be promoted to an error is useful.

I don't maintain the nix flake, and I'm unsure how to help here @r17x.
In the opam setup, running dune build works fine, you can take a look here: https://github.com/ml-in-barcelona/server-reason-react/actions/runs/6765284900/job/18384737801#step:8:2

But why does even happen? @joprice

I spoke to @anmonteiro about this and he said it's due to these repos using (implicit_transitive_deps false). Both Ppxlib and Alcotest set these. I'm not sure if we can modify the nix rules to add the propagated dependencies or if this is something that just has to be treated as an ignorable warning.

Right, if you want to build this locally with nix you might need to fix ppxlib and alcotest, or disable the warning.
There's no code change related with server-reason-react, so I will close this


⚠ Adacta-fintech.com has degraded performance

In d630c4d, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 200
Response time: 1318 ms

Resolved: Adacta-fintech.com performance has improved in 35a21f7 after 8 minutes.


define milestones & define what needs to be done for 0.9.14 version

we need to get to 0.9.14 & 1.0 version asap, define what is required for 0.9.14 & 1.0 in line with requirements
put rest on 1.0.1 and 1.1 for future

this is the one we need for ITO


Throw a descriptive error if the first argument supplied to a hook was not a function

Summary
This PR closes #6903 By adding validation for the first argument of the following hooks:

beforeEach
beforeAll
afterEach
afterAll

If the first argument was not a function Jest will throw a descriptive error:

Additional notes

I've upgraded flow-typed's Jest definition file to v23, because v21 didn't have support for jest.each.

Test plan
Verified that passing a string as first argument will throw an error, on both jasmine and circus runners.

Codecov Report

Merging #6917 into master will decrease coverage by <.01%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #6917      +/-   ##
==========================================
- Coverage   66.98%   66.97%   -0.01%
==========================================
  Files         250      250
  Lines       10365    10375      +10
  Branches        4        3       -1
==========================================
+ Hits         6943     6949       +6
- Misses       3421     3425       +4
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-jasmine2/src/jasmine/Env.js
0% <0%> (ø)
:arrow_up:

packages/jest-circus/src/index.js
66.66% <100%> (+8.97%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e72341...9d83f64. Read the comment docs.

Aww, the typing info is wrong :(

Thanks @SimenB 👍


A tensorflow version of DirectAU

Hi, a very attractive work, have you tried changing  DirectAU to tensorflow version?
I tried this but it takes a long time [almost 5min per epoch].

Haven't yet. The main bottleneck is the calculation of the uniformity loss. A large batch size will make the training process slow. So make sure the batch size is not very large. Generally 256~1024 is fine.
Besides, I'm not sure whether tensorflow has a similar function as torch.pdist. Directly using loops to calculate uniformity is also inefficient.

Thank you,  I have adjusted a fast version


No option to set lsp_signature auto-trigger off

Hi, I want lsp_signature to only fire on demand, using a toggle key. This was working before one of the recent updates, but no longer works. Lsp_signature always triggers when i am inside a function parenthesis. The signature box hides text behind it and that becomes a problem for me, so i have to manually turn if off with the toggle key. Before, I could toggle it on and off whenever needed. Can you please check?
My config is below:
cfg = {
  debug = false, -- set to true to enable debug logging
  log_path = vim.fn.stdpath("cache") .. "/lsp_signature.log", -- log dir when debug is on
  -- default is  ~/.cache/nvim/lsp_signature.log
  verbose = false, -- show debug line number

  bind = true, -- This is mandatory, otherwise border config won't get registered.
               -- If you want to hook lspsaga or other signature handler, pls set to false
  doc_lines = 10, -- will show two lines of comment/doc(if there are more than two lines in doc, will be truncated);
                 -- set to 0 if you DO NOT want any API comments be shown
                 -- This setting only take effect in insert mode, it does not affect signature help in normal
                 -- mode, 10 by default

  floating_window = true, -- show hint in a floating window, set to false for virtual text only mode

  floating_window_above_cur_line = true, -- try to place the floating above the current line when possible Note:
  -- will set to true when fully tested, set to false will use whichever side has more space
  -- this setting will be helpful if you do not want the PUM and floating win overlap

  floating_window_off_x = 1, -- adjust float windows x position.
  floating_window_off_y = 1, -- adjust float windows y position.

  fix_pos = false,  -- set to true, the floating window will not auto-close until finish all parameters
  hint_enable = false, -- virtual hint enable
  hint_prefix = "🐼 ",  -- Panda for parameter
  hint_scheme = "String",
  hi_parameter = "LspSignatureActiveParameter", -- how your parameter will be highlight
  max_height = 12, -- max height of signature floating_window, if content is more than max_height, you can scroll down
                   -- to view the hiding contents
  max_width = 80, -- max_width of signature floating_window, line will be wrapped if exceed max_width
  handler_opts = {
    border = "rounded"   -- double, rounded, single, shadow, none
  },

  always_trigger = false, -- sometime show signature on new line or in middle of parameter can be confusing, set it to false for #58

  auto_close_after = nil, -- autoclose signature float win after x sec, disabled if nil.
  extra_trigger_chars = {","}, -- Array of extra characters that will trigger signature completion, e.g., {"(", ","}
  zindex = 200, -- by default it will be on top of all floating windows, set to <= 50 send it to bottom

  padding = '', -- character to pad on left and right of signature can be ' ', or '|'  etc

  transparency = nil, -- disabled by default, allow floating win transparent value 1~100
  shadow_blend = 36, -- if you using shadow as border use this set the opacity
  shadow_guibg = 'Black', -- if you using shadow as border use this set the color e.g. 'Green' or '#121315'
  timer_interval = 200, -- default timer check interval set to lower value if you want to reduce latency
  toggle_key = '<M-;>',
  select_signature_key='<M-n>' ,
}

require "lsp_signature".setup(cfg,bufnr) --ignore:type
require'lsp_signature'.on_attach(cfg, bufnr)
require("lsp_signature").status_line(max_width)

Many thanks for the fantastic plugin

What language and LSP you using when you saw the issue?

Python and pyrigh

t

There might be something broken. I pushed a fix.

I tried pyright and it works fine for me.

Yes it works if i disable nvim-cmp plugin and go manual. Just need to find a way to make it work with nvim-cmp active

nop, I am using nvim-cmp myself, and did not see the issue you experienced. did you update the plugin to latest?

Yes. Latest plugin versions. Currently, I just get slightly unpredictable behaviour. it does not autoshow half of the time, other times signature pops up if i jump inside a function parentheses.
Below is my neovim version.
:version
NVIM v0.8.0-dev-739-ge59bc078d
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-
prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-c
ommon -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/ub/programs/neovim/build/cmake.
config -I/home/ub/programs/neovim/src -I/home/ub/programs/neovim/.deps/usr/include -I/usr/include -I/home/ub/programs/neovim/build/src/nvim/auto -I/home/ub/programs/neovim/build/include
Compiled by root@zen

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/share/nvim"

Run :checkhealth for more info

Could you try this minimum vimrc
https://github.com/ray-x/nvim/blob/master/min/init_pack.lua
And check if the issue can be reproduce?

I'm having the same issue, is there a simple way to disable this plugin for python files?

It works fine for me. My lsp-signature.lua file is the much abbreviated:
cfg = {
  debug = true,
  verbose = true,
  floating_window = false,
  hint_enable = false,
  handler_opts = {
    border = "single",
  },

  bind = true, -- This is mandatory, otherwise border config won't get registered.
    toggle_key = '<M-;>',
  select_signature_key='<M-n>' ,
}

require "lsp_signature".setup(cfg) --ignore:type

See if this helps

这对我来说可以。我的 lsp-signature.lua 文件被简化了很多：
cfg = {
  debug = true,
  verbose = true,
  floating_window = false,
  hint_enable = false,
  handler_opts = {
    border = "single",
  },

  bind = true, -- This is mandatory, otherwise border config won't get registered.
    toggle_key = '<M-;>',
  select_signature_key='<M-n>' ,
}

require "lsp_signature".setup(cfg) --ignore:type

看看这是否有帮助

I

这对我来说可以。我的lsp-signature.lua文件被简化了很多：
cfg = {
  debug = true,
  verbose = true,
  floating_window = false,
  hint_enable = false,
  handler_opts = {
    border = "single",
  },

  bind = true, -- This is mandatory, otherwise border config won't get registered.
    toggle_key = '<M-;>',
  select_signature_key='<M-n>' ,
}

require "lsp_signature".setup(cfg) --ignore:type

看这是否有帮助

Hello, may I ask you what is the M in the shortcut key ''?

Meta key, Can be <Alt> or <Cmd> depending on your keyboard.

Meta key, Can be <Alt> or <Cmd> depending on your keyboard.
Thanks so much


To be able to send GPX/CSV/GeoJSON files

And display them as layers

GPX and CSV are supported now. An issue is open for the GeoJSON format.


Internet Explorer support

Description
While the app uses modern web technologies, we want to try to support older versions of Internet Explorer to a point.
If we can support IE9, we will add appropriate polyfills unless the overall gap is too great. We certainly want to support IE10 and IE11 fully.
Tasks

[ ] Confirm status of IE9 support, and possible areas we can polyfill to improve support
[x] Confirm IE10 support
[x] Confirm IE11 support

The project does not support ie9. Problems:

ie9 doesn't support isomorphic-fetch + es6-promise.polyfill
ie9 does not support CORS so we should download all resources and files via proxy.
goodTables library doesn't work under ie9

I have created new download procedure (using backend) so ie10-11 work fine.

I'm happy with IE10 and IE11 support. After looking at our whole stack and our goals with the project, IE9 is just lacking too many features to make it a viable support target.


Refactor JS length checks

In boolean context, a check against '> 0' is unnecessary because all non-zero numbers coerce to true and the numbers in use here can not go negative.

I think it's just a stylistic thing. I think the go linter enforces such checks but I personally never do them in JS for the sake of less code.


API Ref navbar update

Now the navbar items are too long and are not visible.

I'm trying to cut the top-level part of the namespace in items.

@efriis Please, check if it works or not.

@efriis Please, check if it works or not for you.

@efriis Please, check if it works or not for you.

Will start a test deploy when readthedocs recognizes my new branch!

I think it will show here: https://api.python.langchain.com/en/erick-api-ref-navbar-update/langchain_api_reference.html
Will take an hour or so before showing up

I think it will show here: https://api.python.langchain.com/en/erick-api-ref-navbar-update/langchain_api_reference.html
Will take an hour or so before showing up
@efriis It is a link to the latest docs. Master does not have this PR change. Did I miss something?

@efriis any new comments?

@leo-gan did you look at the preview? I don't think this worked https://api.python.langchain.com/en/erick-api-ref-navbar-update/langchain_api_reference.html

@leo-gan did you look at the preview? I don't think this worked https://api.python.langchain.com/en/erick-api-ref-navbar-update/langchain_api_reference.html

@efriis  Ohh... I didn't mention the .../erick-... part. I thought it is just a link to the existing docs. Sorry. Yeah, it doesn't work.

@efriis I'm trying another option. Can you generate API again, please?

@efriis I've tried another option. Can you generate the API Refs again and check if it works or not, please?

Rebuilding. Should be up in ~1hr unless it fails

Build failed I think for unrelated reasons

@efriis Can you try to build it again, please?

@efriis Can you try to build it again, please? Thanks!

Going to close this for now. We don't have a great way of testing this with the new build flow at this time, and I'll reopen this PR when that's addressed to give it a go!


Upgrade from 1.0.0 to 1.1.0 crashes with Delete button in shoelace menu

Here's my setup:

button_to w/ confirmation
in shoelace menu item

<sl-menu aria-labelledby="menu-button" aria-orientation="vertical" class="dropdown__items-container" role="menu" tabindex="-1">
  <sl-menu-item class="dropdown__item" role="menuitem" aria-disabled="false" tabindex="0">
      <form class="button_to" method="post" action="/media_planner/media_plans/mp_r7XdkBqzDTFAJzO7kLWZ">
           <input type="hidden" name="_method" value="delete" autocomplete="off">
           <button class="hidden-container" data-turbo-method="delete" data-turbo-frame="_top" data-turbo-confirm="true" data-confirm-title="Confirm Delete" data-confirm-message="Are you sure you want to delete the media plan Media Plan 1? This action cannot be undone." data-confirm-accept="<button class="btn-delete">Delete</button>" data-testid="media-plan-delete-button" type="submit">

Delete

          </button>
      </form>
   </sl-menu-item>
</sl-menu>

Under 1.0.0, this works and correctly displays the confirmation.
Under 1.1.0, clicking the Delete button generates a JS error:
ConfirmationController.js:107 Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
    at #slotContent (ConfirmationController.js:107:20)
    at #fillSlots (ConfirmationController.js:95:32)
    at #showConfirm (ConfirmationController.js:67:10)
    at ConfirmationController.perform (ConfirmationController.js:46:10)
    at HTMLDocument.<anonymous> (index.js:13:66)
    at dispatch2 (utils.js:3:10)
    at _FormSubmission.confirm2 (index.js:5:32)
    at _FormSubmission.start (turbo.es2017-esm.js:736:49)
    at Navigator.submitForm (turbo.es2017-esm.js:2346:29)
    at Session.formSubmitted (turbo.es2017-esm.js:3076:24)

The currentTarget is document (as expected, since the event handler registered rms init sets it so); the activeElement is the drop down menu itself (not the menu item).

The #clickTarget method was switched to use currentTarget.activeElement due to the fact that using a link_to was returning the document as the target whereas button_to returns the button itself.
The current implementation:
#clickTarget({currentTarget}) {
  // Turbo listens for link clicks on the document.
  if (currentTarget === document) {
    // in this case, activeElement is the link that was clicked
    return currentTarget.activeElement.closest(`[data-turbo-confirm]`)
  } else {
    return currentTarget.closest(`[data-turbo-confirm]`)
  }
}

As you mentioned, currentTarget is always going to be document and won't go down the second path.
While incorrect, this should still work with button_to since it should gain focus and become the activeElement. Custom elements break this though.
This issue is outlined here https://dev.to/open-wc/mind-the-document-activeelement-2o9a
Since custom elements have their own DOM (shadow DOM), the focus does not reach inside the custom element which is why the dropdown in your case is getting the focus.
We have a fix coming shortly that will address this issue.


Refactoring override ToString method in HttpResponse class

Changed the method "ToString()" to set cookies separately

This is already fixed during the last lecture.


Add builder method on Client to toggle localhost support

LGTM, any chance we could merge this in and I can rebase on top?


Status codes in maps

This is the PR regarding to the previous discussion about the status code in the fail_map and success_map (https://github.com/lycheeverse/lychee/discussions/1013).
cargo run -- www.example.com --format json -v now prints a success_map, containing a status object with a text and a code field.
The code field is not included, when the status doesn't contain a code.
...,
 "success_map": {
    "http://www.example.com/": [
      {
        "url": "https://www.iana.org/domains/example",
        "status": {
          "text": "OK (200 OK)",
          "code": 200
        }
      }
    ]
  },
...

Code looks good to me. Guess you just have to run cargo fmt once more.

Thanks for your contribution @vilben. 😃


Feature : ondemandSlidesToLoad props added to control slides loading on Lazyload (ondemand)

Feature, Now users can control how many slides they want to load on lazy-load ondemand functionality.
default value : 0.

@akiran please accept my request! we need this change.


Add a Code of Conduct?

Hi all. Many projects now-a-days have a Code of Conduct. It's good to write that down before anything happens, when a project, like this, is young. There isn't one written down yet. So I suggest one be added? What do yous (the admins) think?
I suggest the diversity-talk OSM mailing list CoC.

Hello @rory ,
It's indeed a good idea to add a Code of Conduct !
Thanks for the suggested CoC, I'll forward it to the person coordinating the project!


Storage: Fix coverage issue

Not sure if this is "desired", but it does make the coverage to be 100%.

@chemelnucfin This is not needed. nox -s cover combines coverage from the nox -s unit runs for ALL versions, so it will hit both branches.

But when you test just a single version, you will wonder what you are missing.

That's not the point?

But it does require extra time to confirm that it wasn't what you did that lowered the coverage, right?

@chemelnucfin I don't follow. Run nox -s unit cover?

Is there something wrong with the test though?  It does fix the coverage issue.

Is there something wrong with the test though?

It's the tail wagging the dog. We (our code) shouldn't work around our tools / language versions, they should work around us.

It does fix the coverage issue.

There is no coverage issue to fix.


No warning message shows when adding tags with the same key in the upload dialog

Storage Explorer Version: 1.16.0-dev
Build: 20201029.1
Branch: rel/1.16.0
Platform/OS: Windows 10/ Linux Ubuntu 16.04/ MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one storage account -> Blob Containers.
Select one blob container (make sure the 'Supports Tags' is True) -> Click 'Upload -> Upload Files'.
Add two tags with the same key -> Check the result.

Expect Experience:
Show a warning message saying that keys must be unique.
Actual Experience:
No warning message shows.

More Info:
The screenshot of the 'Edit Tags' dialog.

I have merged the PR for validating duplicate keys.

Verified on build rel/1.16.0 20201103.2. Fixed.


Does not allow npm version commits

I'd like at least a flag to allow npm version commits:

npm ERR! INVALID COMMIT MSG: does not match "(): " ! was: 0.6.15

I need to give you an apology. For some reason, I want watching this repository so I want getting notifications about issues and pull requests. I am so incredibly sorry. Please forgive me. I really feel awful. I hope my unresponsiveness doesn't hinder you contributing more in the future.
As for your specific pull request, I'll give it a closer look soon.

Waiting on @jcollado to respond to my comment on his PR. Thanks for your patience :-)

Thanks, Kent!  Greenkeeper.io has informed me that this breaks my build so let me look into this.

Thanks!


Pie chart renders incorrectly if SQL Query has aggregate, group by and order by

When building out a pie chart based on the following SQL query:
select
        count(*) as cnt
    ,   city
from
        `/marklogiclocal/patients`
where
        state = "NY"
group by
        city
order by
        count(*) desc
limit
        10

the pie chart is displayed incorrectly. It has just a single city with a sum of all the cities as it's value as shown below. It is expected to have the top 10 cities by number of records based off city.

We can see that the query works and returns data as expected if we put a Preview Table card after the query:

Here is the query string parameters that are being passed in to the chart:
q=SELECT%20city%20AS%20category%2C%20SUM(cnt)%20AS%20measure%2C%20null%20AS%20donut%2C%20null%20AS%20parallel%20FROM%20%60%2Fmarklogiclocal%2Fpatients%20workspaces%2FUntitled%20Workspace%201.slam%2F.tmp%2Fout741f6a36-03d6-42c0-9ad7-c2d9be12e1dc%60%20GROUP%20BY%20city%20ORDER%20BY%20city%20ASC

Looking at the output of this, there are 1000 rows, and they are all the same, showing a category of NEW YORK and a measure of 44 which is the sum of the counts for the 10 rows.
This works in Old Mongo connector, but does not work in MarkLogic or Spark. When the original query is run in Couchbase we get an error stating Failed to plan query.: unimplemented EquiJoin: Not currently mapped to N1QL's key join which is a known issue (Quasar issue #2117 https://github.com/quasar-analytics/quasar/issues/2117)

@cryogenian  and @rabbitonweb  - please take a look. Dropping it in Spark, since we encountered the issue, when testing against the Spark connector (although as stated here, it appears to happen with other connectors such as Marklogic). Unclear if this should be a slamdata issue and whether the chart setup/show somehow corrupts the intent and generates incorrect sql or whether the problem is elsewhere. Bottom line is that given "results" as in the above example (10 rows with just counts) - we want to just reflect that in the pie-chart, but we seem to end up with non-intuitive pie-charts instead, that seem far from the desired WYSIWIG experience.

Front-end doesn't know what connector is used -- I think it's connector issue, because it works with old mongo

@alissapajer , @sellout , @drostron , @rabbitonweb -> This issue relates to # 1806 in Slamdata. Front-end folks however seem to think this is a deeper backend issue........ in that it works against old-Mongo but not against any of the new connectors (Spark, Mark-logic, CB etc.) -> we tested it a few times against Spark, which is why the issue is homed as such.
Although @cryogenian - one thing i don't understand is what is stopping us from saying the preview table is what we want charted....so forget about generating a new query via chart-setup (just take the :results that drive preview and chart it)- so unsure if there is not a front-end usability issue in here as well.

@zeeiyerWork The preview table just runs the query as is. The chart setup generates queries on top of that with aggregations and groupings. Charting pushes all data processing to the backend, it doesn't chart a data source directly.

@natefaubion -> Yes that's what I am questioning. I understand that all chart related processing happens on the backend today. But am wondering if there is a use case, where there should me a mode, when no back-end invocation is needed. i.e. When all the work has already been done by the backend (as in the case being discussed here, where the query already produced results in a "chartable" form - i.e. attribute"/count" or measure/dimension) and I just want to chart the results.
So why is the implementation forcing me to re-run a query ..... What if this were a super-expensive query - why should I have to run it twice just to move from tabular to graph presentation styles?

@zeeiyerWork The preview table does not consume the entire data set, it will paginate.

Expensive queries should be mitigated by caching.

@dugdun what do the Preview Table results look like for old mongo and spark/marklogic? Are there any differences in the result of the query if you don't try to make a chart and just view the data as a table?

Also, I think what @zeeiyerWork was commenting on was the fact that, if I understand correctly, in order to create a pie chart from a table, an additional grouping must occur. In other words, given the table results that @dugdun posted above, is is not possible to create a chart that has pie slices sized according to the cnt field. And so the frontend is necescsarily performing some additional grouping on top of the query results. Is that correct?

@alissapajer Technically, you aren't creating a pie chart from a table. A table just forwards the resource (it "taps" it, and runs a limited query based on the resource). The chart setup then creates the additional groupings and aggregations based on the settings, which the following chart card will run. These are completely different queries, and while they are forked from the same resource, it's not possible for them to share anything unless we were to pull in the entire data set and just do everything in the frontend.
If the table card followed the chart card, then we could cache the resource in the frontend as part of evaluation (this would be a useful, fairly simple addition to the eval machinery), but it's definitely not commutative.

@natefaubion ok cool, so here's a follow-up question. If the user wants to display a pie chart, are the pie chart groupings/aggregations computed by the frontend, using the initial query results that quasar provides? Or is quasar used again when the user wants to display a chart (e.g. the frontend creates some new sql that it sends to the backend for evaluation)? Or is quasar only used for the initial sql query evaluation, and chart evaluation (groupings, etc) happens solely in the frontend?

@alissapajer The frontend issues a query in chart setup to sample the data for structure (to be replaced by SSTs). It generates a query with all the aggregations and groupings, which is then executed when the user consumes it via a "Show Chart" card or a subsequent table card. No grouping or aggregating happens in the frontend anymore. The table card is not required for this workflow. If the goal is to just display a chart, then ideally (with SSTs) only one query will be issued by the frontend, which happens when the chart is displayed. But if you show the table of a data source as well, it must issue that query right then, and this query is different from the query issued for charting.

@natefaubion awesome, thanks! So, is it possible to get a hold of the query that the frontend issues to the backed when it displays the chart? I think that's what's needed to debug this issue, since the chart is what is incorrect.

@alissapajer if it helps, I ran this against with SlamData 4.2.1 against MongoDB, Couchbase and MarkLogic.  Here are the queries that execute during a Show Chart.  Actually, I believe the Show Chart card simply references the view, which in turn executes the query mapped to it? (I added newline characters for easier reading on github)
MongoDB:
SELECT city AS category, SUM(cnt) AS measure, null AS donut, null AS parallel
FROM `/mongodb/Untitled Workspace.slam/.tmp/out79d8e4d0-6435-47bb-9d91-3b79ad8655ba`
GROUP BY city ORDER BY city ASC

Couchbase:
SELECT city AS category, SUM(cnt) AS measure, null AS donut, null AS parallel
FROM `/couchbase/patients-bucket/Untitled Workspace.slam/.tmp/outbd19a19c-ff78-4510-9bfd-5a9fda3dda00`
GROUP BY city ORDER BY city ASC

MarkLogic:
SELECT city AS category, SUM(cnt) AS measure, null AS donut, null AS parallel
FROM `/marklogic/Untitled Workspace.slam/.tmp/outbfb3de5f-9e3c-4b43-a2ad-96bd2a31abe5`
GROUP BY city ORDER BY city ASC

Looks like the queries are essentially the same.  MongoDB provides correct pie chart, MarkLogic provides incorrect pie chart with a single piece, and Couchbase returns the error Failed to plan query.: unimplemented EquiJoin: Not currently mapped to N1QL's key join

Old mongo was providing "correct" pie chart but it was incorrect behavior. Data is already grouped by the query and then "pie chart" functionality groups it one more time. So from the perspective of SQL both marklogic and spark give you the correct results (even if this is not what user wanted). Why? Because they ran aggregation (sum) on already aggregated data, so it is sum of all sums really.
How can we get correct pie charts then? When the only way you  can do it is to create query "select 1 as count, city from patients and then run "pie chart" on the data that is being returned which will do the group by and aggregations for you.
Downsides:

this is counter intuitive - i would prefer to give you data in tabular form and ask you to create charts from it, not to do some sort of your own magic. but this is how charts work, thus there is not much we can do about it
you can not really limit the results you would like to see (for example show me only cities that have more then 10 patients).

But regardless of that all, this is not really a bug (nor it is a feature) and it never was. This is basically how charts work in frontend. The reason that old mongo gave you the 🤞 "right" results, was the fact that it wrongly interpreted the query - results should be as they are for both spark and marklogic.
Because all of the above, I'm closing this issue. If you don't agree @here please feel free to reopen :)

Actually - a bug. Reopening.

So I still believe that running aggregation twice is not needed (it kills performance) and we should maybe rethink how pie charts are created (for me personally this is super counter intuitive) BUT nevertheless that query SHOULD work.
It used to give us wrong results but with right schema, now what we get is totally crazy :)
@alissapajer looked at QScript and said the problem is there. This bug actually blocks a lot of demo workspaces (for all connectors) so the sooner it is fix the better.

Pie Chart essentially runs this query
select city, sum(cnt) as c from (select city, count(*) as cnt from `/local/patients.data` where state = "NY" group by city order by count(*) desc limit 10) as meh group by city

and gives us right now this
city            | c[0]          |
-----------------|---------------|
  unexpected: NA | BROOKLYN      |
  unexpected: NA | BROWNVILLE    |
  unexpected: NA | MOUNT VERNON  |
  unexpected: NA | ROCHESTER     |
  unexpected: NA | SOUTHAMPTON   |
  unexpected: NA | BRONX         |
  unexpected: NA | SCOTTSVILLE   |
  unexpected: NA | NEW YORK      |
  unexpected: NA | ALBANY        |
  unexpected: NA | BUFFALO       |

We should not ignore result order in the above query since we are ordering the final results.

This version of the query works as expected against mongo 3.4, quasar v25.0.12
select city, cnt as c from (select city, count(*) as cnt from patients where state = "NY" group by city order by count(*) desc limit 10) as meh group by city order by c desc

The notable difference is that in the outer select we select cnt as c instead of sum(cnt) as c.

@zeeiyerWork asked me recently about this issue. Just to clarify: this is QScript issue, @alissapajer was assigned to this task, I think she already knows were the problem is (if I correctly recall the conversation we had)

This will be fixed with QSU. We will try running this query again once the initial version of QSU is implemented.

It looks like this query works just fine. I ran the original query from @dugdun on cities, and it gave:
 city           | cnt |
----------------|-----|
 NEW YORK       |  40 |
 BROOKLYN       |  37 |
 BRONX          |  25 |
 ROCHESTER      |  19 |
 BUFFALO        |  18 |
 STATEN ISLAND  |  12 |
 SYRACUSE       |  10 |
 ALBANY         |   7 |
 JAMAICA        |   6 |
 FLUSHING       |   6 |

Which seems to be correct because it has multiple results, and @rabbitonweb's integration test passes. Is this not working?


ROCm / HIP PATHs related ginkgo installation problems on Ubuntu 22.04

I am trying to install ginkgo on Ubuntu 22.04. I have an up-to-date default installation of AMD ROCm 6.1.1 which works fine. The ginkgo installation process using cmake as described on the webpage, doesn't find AMD ROCm nor HIP or any of the required cmake files so I provided the paths:
export HIP_PATH=/opt/rocm
export hipblas_DIR=/opt/rocm/lib/cmake/hipblas
export CMAKE_PREFIX_PATH=/opt/rocm/lib/cmake/hip
export AMDDeviceLibs_DIR=/opt/rocm-6.1.1/lib/cmake/AMDDeviceLibs/
export amd_comgr_DIR=/opt/rocm-6.1.1/lib/cmake/amd_comgr/
The following one triggers an error: »hsa-runtime64_DIR=/opt/rocm-6.1.1/lib/cmake/hsa-runtime64/«: Ist kein gültiger Bezeichner
export hsa-runtime64_DIR=/opt/rocm-6.1.1/lib/cmake/hsa-runtime64/
I used the following cmake command:  cmake -G "Unix Makefiles" -DGINKGO_BUILD_HIP=ON -DCMAKE_HIP_ARCHITECTURES="gfx1031" .. && cmake --build .
I assume the install package is not up-to-date regarding ROCm / HIP install paths?!

First, unfortunately your build will likely fail, since we don't support gfx10xx (yet), see #1429.
Second, these environment variables should no longer be necessary since #1334, as long as amdclang++ or hipcc can be found. Which commit are you looking at? Also what CMake version are you using?

The cmake version is cmake version 3.22.1
How can I specify the hipcc location during the installation process?

I think the easiest solution should be pointing HIPCXX at amdclang++, if it's not already in the PATH. Though it might also help just to try out a newer version of CMake, since HIP 6.1.1 came out quite some time after CMake 3.22.1, and there might be some changes to the CMake setup that are not reflected properly.

I am going in a circle, now  HIPCXX is pointing to amdclang++ but the cmake flies are still not detected:

-- The HIP compiler identification is Clang 17.0.0
-- Detecting HIP compiler ABI info
-- Detecting HIP compiler ABI info - done
-- Check for working HIP compiler: /opt/rocm-6.1.1/llvm/bin/clang++ - skipped
-- Detecting HIP compile features
-- Detecting HIP compile features - done
CMake Error at cmake/hip.cmake:120 (find_package):
  By not providing "Findhipblas.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "hipblas", but
  CMake did not find one.

  Could not find a package configuration file provided by "hipblas" with any
  of the following names:

    hipblasConfig.cmake
    hipblas-config.cmake

  Add the installation prefix of "hipblas" to CMAKE_PREFIX_PATH or set
  "hipblas_DIR" to a directory containing one of the above files.  If
  "hipblas" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  CMakeLists.txt:78 (include)

-- Configuring incomplete, errors occurred!
See also "/home/klaus/Programme/ginkgo/build/CMakeFiles/CMakeOutput.log".
See also "/home/klaus/Programme/ginkgo/build/CMakeFiles/CMakeError.log".

Can you try setting -DCMAKE_PREFIX_path=/opt/rocm-6.1.1 as outlined in https://rocm.docs.amd.com/en/latest/conceptual/cmake-packages.html? By choosing to install ROCm in a non-standard location like /usr in their packages, AMD made it slightly harder for things to be found by default. Module systems on HPC clusters usually take care of that for you.

The following triggered the compilation on Ubuntu 22.04 with ROCm 6.1.1:
cmake -G "Unix Makefiles" -D GINKGO_BUILD_HIP=ON -D CMAKE_HIP_ARCHITECTURES="gfx1031" -D CMAKE_PREFIX_PATH=/opt/rocm-6.1.1 .. && cmake --build .
Now I need to look into the architecture specific warp size related compilation error that's discussed in the other thread.

Dealing with warp size 32 requires some refactoring on our side (since we assume the warp size is known on the host at compile time, this assumption is violated in a mixed gfx10xx/gfx9xx build), so it is unlikely that you will be able to fix it easily. In the short run, we can only support server-grade GPUs with warp size 64.

I don't run a mixed build, only -D CMAKE_HIP_ARCHITECTURES="gfx1031", the purpose it to test https://github.com/hpsim/OGL

IIRC the ROCm clang compiler always claims the warp size is 64 from the host side regardless of the device architecture, so that will not make a difference.

I've been planning on setting up a CI system with a consumer GPU for a while now, I guess this is a good time to get started ;)

That's a very good idea, I have been looking into GPU compute for CFD for years but have not been able to confirm even one of the many speedup claims so I am not going to invest in server grade hardware before I have managed to setup an effective implementation of some kind.


Dangerous command in create-new-package.bash "rm -r git"

Hello,
This software seems to make the development of ROS2 easier, so I am trying it out.
The below block asks for user information on git.
https://github.com/StoglRobotics/ros_team_workspace/blob/cd83934e21e2d2a7b4f07dd52a186adb83083066/scripts/create-new-package.bash#L54-L73
However, depending on the answer, the .git directory will be deleted.
This may not be a problem in most cases, but it is better to confirm if you are trying to delete an important file.

Hi @DaisukeUra thanks for the interest. You are right, I am checking this wrong! I should check if there is a git folder in the parent folder...
Thanks for this!


How to append a title element to the SVG ReactComponent

What I wanted
Given a phone.svg file (which has a title element as one of its children), I want to render it with a custom title based on a prop. Currently, passing a title prop to the ReactComponent (import { ReactComponent } from 'phone.svg') doesn't update the content of the title element inside rendered svg.
What I tried
As described in svgr docs, we can use a titleProp option in our webpack config to append a title element to the rendered svg element. But in our webpack.config.js file, we are only passing +ref option to the @svgr/webpack loader which doesn't append the title element.
So, just for testing purpose, I changed to webpack.config.js to include the titleProp option in the loader as follows
{
  svg: {
-    ReactComponent: '@svgr/webpack?-svgo,+ref![path]',
+    ReactComponent: '@svgr/webpack?-svgo,+titleProp,+ref![path]',
  },
}

After this, if I pass a title prop to the Svg component, it was appending a title element to the svg element, which is what I wanted.
import { ReactComponent as Phone } from "./svgs/phone.svg"

function CallTo ({ name, phoneNumber }) {
  return <Phone title={`Call to ${name} on ${phoneNumber}`} />
}
.
.
<CallTo name="React" phoneNumber="123123" />

<svg ...>
<title>Call to React on 123123</title>
.
</svg>

This is great as now I can pass any context based title for an Icon which will make it more accessible than just a static default title for the icon. I can make a PR to update the configuration for webpack.
Where is the problem then
The problem with updating the webpack configuration is that If I don't pass a title to the SVG component, it will render an empty title even if the svg file has a title element (e.g. Phone), which is not a desired default functionality.
What is the solution
I don't know, yet. May be, @svgr/babel-plugin-svg-dynamic-title need to be updated first to handle the case where the title props in null (i.e. it should not update the default title when the title prop is null). And after that, we can make a change to the webpack configuration file. But I don't know where to start.
What I am doing currently
I am using aria-label attribute to make the Svg React Component.  And I have also removed the title element from my svg files. Removal of title is required because hovering-over to the svg reveals the title element's content (Phone) which stays the same for all the instances of this icon on a page and svg element doesn't accept a title prop.

Hi @sudkumar, thanks for raising this.
I think we can accept a PR that solves this. Can you put this together and assign it to me? Thanks!

Hi @mrmckeb . Thank you for having a look into it.
I dig into it and found that the issue is with the svgr itself. I am waiting for a PR (https://github.com/smooth-code/svgr/pull/311) to get merged. This PR solves the issue that we will not affect any existing code base using SVG ReactComponent when we updated our webpack.config.js file.
{
  svg: {
-    ReactComponent: '@svgr/webpack?-svgo,+ref![path]',
+    ReactComponent: '@svgr/webpack?-svgo,+titleProp,+ref![path]',
  },
}

If I make this change here before that PR (https://github.com/smooth-code/svgr/pull/311) merges, we may have an issue that the title element will get removed as this is the current behaviour of SVGR with titleProp set to true.
I will open the PR as soon as the other PR gets merged.
Please suggest how I should proceed.

Awesome, thank you! I'll close this off for now, but if you do raise a PR, assign to me and link to this ticket. Thanks!


Template application: pgvector

Contact Details
<EMAIL_ADDRESS>Template URL
https://railway.app/template/uYYYQy
What does this template deploy?
This template deploys a Postgres instance with pgvector extension enabled.
Demo project
https://railway.app/project/ff99ab66-c60f-4301-b787-ab9c0b7c3969

The @see in the demo project, great idea, but also put it in an example directory, for easy future references.

Little tip, instead of having the user define their own password, use the secret() template variable function

@imsumoregn

The @see in the demo project, great idea, but also put it in an example directory, for easy future references.

Yb, but could you also walk me through steps to setup nginx in our next US? I know it should be simple, but I'm new to the game and it's not a pile of water, it's a whole sea I'm looking at.
@brody192

Little tip, instead of having the user define their own password, use the secret() template variable function

Ah, I should've read the docs more carefully. Thank you for the tip.

Sure, put it in the agenda, please. Nginx is quite something - it is dead simple on its own, but the hard part is how, where, and why you would use it.

But the next session is not until a while, do you feel like implement this reverse proxy thing with Caddy for the time being? The other mate in this thread (Hey Brody! You are everywhere) has submitted a few templates that also used Caddy, if the workshop last month didn't help you.

I'm sure this goes against what the team thinks, but they shouldn't have asked for database templates until Railway supports TCP proxying, because unless you use some type of tunnel with this template, it's unusable from anywhere other than the private network

@brody192 It really is! I don't understand a word from what you've said, but I've been trying to expose the db using your reverse proxy Caddyfile, and it didn't work.
cc: @imsumoregn.

Yes, ngrok or the good old localtunnel would work. I'm with Brody on the unnecessity of implementing this, but if you just want to have fun, it shouldn't be a problem.
Also, don't turn all your notification off, please. At least not Slack.

I saw your message, really sorry. I'm already trying ngrok and will open another issue for the true standalone version when finish.

Closing because Railway has released TCP proxy and already built a pgvector template as an example. Great news, btw.


onTrClick

README fix

React "peerDep ..." commit is totally optional.

Great work! You're the man.

@tannerlinsley thx, great component!

@DimitryDushkin Thanks!
Curiously, are you using React-Table for Yandex?

BTW just cut a new release for you 👍

@tannerlinsley no exactly for big Yandex (search), but for projects within its department — Yandex Data Factory — b2b machine-learning solutions spinoff.
Thank you for release. =)


Tar Pits Biome

Based on the La Brea Tar pits, a Mediterranean or Warm-Semi-Arid biome.

black water

Added by @DeathShadez


Allow updating python3 > 3.11.0

Details
Hello Maintainers - I am hoping to mitigate CVE-2023-24329 present in python3 versions prior to 3.11.4.  The python3.vm.nuspec file prevents the updates > 3.11.0.
Info at NVD:  https://nvd.nist.gov/vuln/detail/CVE-2023-24329
and at MITRE: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-24329
PS C:\temp> choco upgrade python3 --version=3.11.9
Chocolatey v2.3.0
Upgrading the following packages:
python3
By upgrading, you accept licenses for the packages.

You have python3 v3.10.11 installed. Version 3.11.9 is available based on your source(s).
[NuGet] One or more unresolved package dependency constraints detected in the Chocolatey lib folder. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'python3.vm <IP_ADDRESS>31019 constraint: python3 (>= 3.10.0 && < 3.11.0)'
Re-attempting package dependency resolution using additional available package information...
[NuGet] One or more unresolved package dependency constraints detected in the Chocolatey lib folder. All dependency constraints must be resolved to add or update packages. If these packages are being updated this message may be ignored, if not the following error(s) may be blocking the current package operation: 'python3.vm <IP_ADDRESS>31019 constraint: python3 (>= 3.10.0 && < 3.11.0)'
Unable to resolve dependency 'python3': Unable to resolve dependencies. 'python3 3.11.9' is not compatible with 'python3.vm <IP_ADDRESS>31019 constraint: python3 (>= 3.10.0 && < 3.11.0)'.

Chocolatey upgraded 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - python3 - Unable to resolve dependency 'python3': Unable to resolve dependencies. 'python3 3.11.9' is not compatible with 'python3.vm <IP_ADDRESS>31019 constraint: python3 (>= 3.10.0 && < 3.11.0)'.
PS C:\temp>

Note our packages should only be installed in a virtual machine. In the case of FLARE-VM, I prefer not to install security patches as it ensures that malware exploiting them work, which normally makes the analysis easier.
Note also that in order to update to Python 3.11 we need to ensure all Python libraries and tools we install currently work in Python 3.11 as well.


Add support for Authorization Matrix property on jobs

Thanks for fixing Sticker CI here as well!

I've pushed v1.9.0 to PyPI with this change.


Game crashes upon clicking on multiplayer menu

Describe the bug
When I click on the multiplayer menu, I see a "Saving world" screen and the game crashes. Logs provided below. Every mod I've added to FO can be seen in the log file.
Modpack version
5.1.0-beta3
Launcher
Prism Launcher
Other things

[X] I updated FO to a newer version (mention, what version to what version)
[X] I added/removed some mods or resource packs (mention, which ones)

Additional context
Logs: https://mclo.gs/5BCPjAL

Remove Essential mod.


Custom Validation Rules runs even when the field is empty

Laravel Version: 6.10.1
PHP Version: 7.3.10
Database Driver & Version:

Description:
Custom validation rules runs even when the field is empty.
Validator::make(['foo'=>null], ['foo'=>new \App\Rules\IfEmptyShouldNotRunRule])->validate();
and the rule was running while the documents have emphasized that:

By default, when an attribute being validated is not present or contains an empty string, normal validation rules, including custom extensions, are not run.

This bug is because you always change any empty field to null and for checking empty field in Illuminate\Validation\Validator class, you check whether the field is a string type(while null is not a string)
`protected function presentOrRuleIsImplicit($rule, $attribute, $value)
{
if (is_string($value) && trim($value) === '') {
return $this->isImplicit($rule);
}
    return $this->validatePresent($attribute, $value) ||
           $this->isImplicit($rule);
}`

when an attribute being validated is not present or contains an empty string

The attribute is present and it's not an empty string (it's null).

By default, Larval converts all blank fields on the form to null...
Suppose an empty field is received from a web form, so it is converted to null:
Validator::make($request->all(), ['foo'=>new \App\Rules\IfEmptyShouldNotRunRule])->validate();

For a custom rule to run even when an attribute is empty, the rule must be implicit. An "implicit" rule only implies that the attribute is required. Whether it actually invalidates a missing or empty attribute is up to you.
https://laravel.com/docs/11.x/validation#implicit-rulestom


SignedCms.ComputeSignature() not prompting for certificate (doc says otherwise)

MSDN doc mentions that SignedCms.ComputeSignature() does prompt for certificate. This is not true, non of the .NET framework versions do - you will get an exception in such case.
Note that this only applies to parameterless constructor but applies to all .NET versions including Core.
There are more than one mentions on the doc page that this happens. Remarks section seems like it applies to all of the overloads but that's not the case for the parameterless constructor.
cc: @bartonjs

I assume that we would want to document the specific exception, so we should write it down here.

For full framework the exception is InvalidOperationException for corefx (arguably a bug) is PlatformNotSupportedException (See: https://github.com/dotnet/corefx/issues/32171).

@krwq and @bartonjs, what is the status of this issue in view of dotnet/corefx#32226? In what version of .NET Core does the behavior of ComputeSignature change from throwing PlatformNotSupportedException to throwing InvalidOperationException if  CmsSigner.SignerIdentifierType does not equal SignerIdentifierType.NoSignature? Both behaviors should be documented.

The documentation should note that the silent parameter is ignored on .NET Core, shouldn't it?

I believe (by code inspection) that the silent parameter has no effect on either .NET Core or .NET Framework.  Though .NET Framework certainly keeps it around a lot longer before ignoring it.
The zero-argument overload succeeds* if SubjectIdentifierType.NoSignature was specified via a constructor overload, and otherwise throws InvalidOperationException.
* Well, it succeeds on the first call.  Maybe.  It'll throw a CryptographicException if any ComputeSignature overload has already been successfully called, or Decode was successfully called.


Circular dependency?

Not sure this is the right place to report, but:
I'm trying to update ppx_core to 0.9.0 in pkgsrc, and find the following dependency cycle:
ppx_core requires ocaml-compiler-libs.common, part of core;
core requires core_kernel;
core_kernel requires ppx_base;
ppx_base requires ppx_compare;
ppx_compare requires ppx_metaquot;
ppx_metaquot requires ppx_core (at least according to its opam file).
Is there something I should disable somewhere or is there another way of bootstrapping this?

ocaml-compiler-libs is not part of core

Do you mean it uses the compiler-libs package that comes with ocaml? (If you don't use opam, that gets installed as compiler-libs.common; Googling for ocaml-compiler-libs.common mostly returns ocaml-core, which would explain the confusion...)

ocaml-compiler-libs is simply a repackaging of compiler-libs, putting all the modules under a toplevel name. It's just to so that we can clearly identify what comes from the compiler-libs and what come from other libraries in our code. The compiler libraries expose all their modules at toplevel, which is a huge pain.

Yup, I've found the package now. Weird that it doesn't show up on Google. Anyway, thanks for your help!


Add note about Django testing incompatibility

fixes #

Checklist:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[ ] Run pytest and tox, no tests failed.

Thanks, however this doesn't make things any clearer for me. It has no explanation or links for the statement it makes. This seems very specific to how Django integrates with Jinja, not with how Django templates and Jinja templates are similar or different.

Is the issue that I don't provide specific enough details, or that you don't think this should be mentioned at all in the jinja docs?  This is a section on how to convert your django project from django templates to jinja templates.  The issue I'm describing is something that's going to trip people up when doing the conversion.

If you're using Jinja in Django, that's not converting from Django templates to Jinja, that's using Jinja in Django. I don't think this needs to be mentioned here.


[Bug]: Crash on Pressing F3

Describe the Bug
A game crash that happens when you press the button F3 on your keyboard.
Steps to Reproduce

Mod List:
Note: The number in parentheses is the mod version (as in Version 1.0, 2.0), and NOT the Minecraft version (as in 1.18.2, 1.19).
- 3D Skin Layers (1.4.7)
- Advanced Compass (1.2.7)
- AppleSkin (2.4.0)
- Architectury API (5.6.21)
- BetterF3 (1.3.0)
- BetterMountHUD (1.1.4)
- BetterTaskbar (1.4)
- C2ME (0.2.0)
- Carpet (1.4.79)
- Clear Skies (2.0.93)
- Client Side Noteblocks (2.2)
- Cloth Config (7.0.69)
- Clumps (9.0.0)
- Continuity (2.0.0)
- Controlling (10.0)
- Cull Leaves (2.3.4)
- DetailArmorBar (2.6.2)
- DynamicFPS (2.1.0)
- Effective (1.2.2)
- EntityCulling (1.5.2)
- FabricAPI (0.55.3)
- Ferritecore (5.0.0)
- Figura (0.0.8)
- Illuminations (1.10.5)
- Indium (1.0.4)
- InventoryHUD+ (3.4.5)
- Krypton (0.2.0)
- LazyDFU (0.1.3)
- ModMenu (4.0.0)
- Pistorder (1.5.0)
- Plasmovoice (1.2.14)
- Rainbowify (2.0.0)
- Reeses Sodium Options (1.4.3)
- Resclone
- RoughlyEnoughItems (9.0.472)
- RoughlyEnoughProfessions (1.0.1)
- RoughlySearchable (2.5.0)
- Shield Indicator (1.0.1
- Show Me Your Skin (1.2.1)
- Sodium Extra (0.4.5)
- Sodium (0.4.2)
- Sodium Shadowy Path Blocks (2.0.0)
- Starlight (1.1.0)
- Suggestion Tweaker (1.2.1)
- TieFix (1.11.0)
- Tooltip Tweaks (1.1.0)
- UI Input Undo (1.2.0)
- Visuality (0.5.0)
- WPIT (1.4.0)

Load up the launcher.
Go into any singleplayer world (have not tested on Multiplayer) and press F3.
Expected Behavior
When the F3 button is pressed, the F3 menu would open, with all of my previous saved assets and setting configurations saved to it.
Screenshots
n/A
Modloader Type
Fabric
Modloader Version
Version 0.55.3 (Minecraft Version 1.19)
Mod Version
Version 1.3.0
Log Output
---- Minecraft Crash Report ----
// Don't do that.

Time: 6/9/22, 2:09 PM
Description: Unexpected error

java.lang.NoSuchFieldError: field_1910
	at net.minecraft.class_329.handler$cdk000$injectedRender(class_329.java:8549)
	at net.minecraft.class_329.method_1736(class_329.java:475)
	at net.minecraft.class_329.method_1753(class_329.java:230)
	at net.minecraft.class_757.method_3192(class_757.java:862)
	at net.minecraft.class_310.method_1523(class_310.java:1143)
	at net.minecraft.class_310.method_1514(class_310.java:734)
	at net.minecraft.client.main.Main.main(Main.java:237)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at net.minecraft.class_329.handler$cdk000$injectedRender(class_329.java:8549)
	at net.minecraft.class_329.method_1736(class_329.java:475)
	at net.minecraft.class_329.method_1753(class_329.java:230)

-- Affected level --
Details:
	All players: 1 total; [class_746['SirInfinity'/66, l='ClientLevel', x=424.47, y=116.22, z=1529.94]]
	Chunk stats: 1024, 598
	Level dimension: minecraft:overworld
	Level spawn location: World: (-112,62,-48), Section: (at 0,14,0 in -7,3,-3; chunk contains blocks -112,-64,-48 to -97,319,-33), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
	Level time: 6220 game time, 6220 day time
	Server brand: fabric
	Server type: Integrated singleplayer server
Stacktrace:
	at net.minecraft.class_638.method_8538(class_638.java:453)
	at net.minecraft.class_310.method_1587(class_310.java:2288)
	at net.minecraft.class_310.method_1514(class_310.java:758)
	at net.minecraft.client.main.Main.main(Main.java:237)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Last reload --
Details:
	Reload number: 1
	Reload reason: initial
	Finished: Yes
	Packs: Default, Fabric Mods, continuity/default, continuity/glass_pane_culling_fix, cullleaves/smartleaves, Default-Dark-Mode-1.19-0.5-000000-(v1.3.2).zip, Essential (fabric_1.19).jar

-- System Details --
Details:
	Minecraft Version: 1.19
	Minecraft Version ID: 1.19
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 17.0.3, Microsoft
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
	Memory: 422433640 bytes (402 MiB) /<PHONE_NUMBER> bytes (2048 MiB) up to<PHONE_NUMBER> bytes (2048 MiB)
	CPUs: 6
	Processor Vendor: GenuineIntel
	Processor Name: Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
	Identifier: Intel64 Family 6 Model 158 Stepping 10
	Microarchitecture: unknown
	Frequency (GHz): 2.81
	Number of physical packages: 1
	Number of physical CPUs: 6
	Number of logical CPUs: 6
	Graphics card #0 name: Radeon RX 580 Series
	Graphics card #0 vendor: Advanced Micro Devices, Inc. (0x1002)
	Graphics card #0 VRAM (MB): 4095.00
	Graphics card #0 deviceId: 0x67df
	Graphics card #0 versionInfo: DriverVersion=27.20.1034.6
	Memory slot #0 capacity (MB): 8192.00
	Memory slot #0 clockSpeed (GHz): 2.40
	Memory slot #0 type: DDR4
	Virtual memory max (MB): 19394.54
	Virtual memory used (MB): 14384.00
	Swap memory total (MB): 11264.00
	Swap memory used (MB): 618.86
	JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
	Fabric Mods:
		advancedcompass: Advanced Compass 1.2.7
		appleskin: AppleSkin 2.4.0+mc1.19
		architectury: Architectury 5.6.21
		betterf3: BetterF3 1.3.0
		bettermounthud: Better Mount HUD 1.1.4
		bettertaskbar: Better Taskbar 1.4
		c2me: Concurrent Chunk Management Engine 0.2.0+alpha.8.0
			c2me-base: Concurrent Chunk Management Engine (Base) 0.2.0+alpha.8.0
			c2me-client-uncapvd: Concurrent Chunk Management Engine (Client/Uncap View Distance) 0.2.0+alpha.8.0
			c2me-fixes-chunkio-threading-issues: Concurrent Chunk Management Engine (Fixes/Chunk IO/Threading Issues) 0.2.0+alpha.8.0
			c2me-fixes-general-threading-issues: Concurrent Chunk Management Engine (Fixes/General/Threading Issues) 0.2.0+alpha.8.0
			c2me-fixes-worldgen-threading-issues: Concurrent Chunk Management Engine (Fixes/WorldGen/Threading Issues) 0.2.0+alpha.8.0
			c2me-fixes-worldgen-vanilla-bugs: Concurrent Chunk Management Engine (Fixes/WorldGen/Vanilla Bugs) 0.2.0+alpha.8.0
			c2me-notickvd: Concurrent Chunk Management Engine (No Tick View Distance) 0.2.0+alpha.8.0
			c2me-opts-allocs: Concurrent Chunk Management Engine (Optimizations/Memory Allocations) 0.2.0+alpha.8.0
			c2me-opts-chunk-access: Concurrent Chunk Management Engine (Optimizations/Chunk Access) 0.2.0+alpha.8.0
			c2me-opts-chunkio: Concurrent Chunk Management Engine (Optimizations/Chunk IO) 0.2.0+alpha.8.0
			c2me-opts-math: Concurrent Chunk Management Engine (Optimizations/Math) 0.2.0+alpha.8.0
			c2me-opts-scheduling: Concurrent Chunk Management Engine (Optimizations/Scheduling) 0.2.0+alpha.8.0
			c2me-opts-worldgen-general: Concurrent Chunk Management Engine (Optimizations/General WorldGen) 0.2.0+alpha.8.0
			c2me-opts-worldgen-vanilla: Concurrent Chunk Management Engine (Optimizations/Vanilla WorldGen) 0.2.0+alpha.8.0
			c2me-rewrites-chunkio: Concurrent Chunk Management Engine (Rewrites/Chunk IO) 0.2.0+alpha.8.0
			c2me-server-utils: Concurrent Chunk Management Engine (Server Utils) 0.2.0+alpha.8.0
			c2me-threading-chunkio: Concurrent Chunk Management Engine (Threading/WorldGen) 0.2.0+alpha.8.0
			c2me-threading-lighting: Concurrent Chunk Management Engine (Threading/Lighting) 0.2.0+alpha.8.0
			c2me-threading-scheduling: Concurrent Chunk Management Engine (Threading/Scheduling) 0.2.0+alpha.8.0
			c2me-threading-worldgen: Concurrent Chunk Management Engine (Threading/WorldGen) 0.2.0+alpha.8.0
			com_electronwill_night-config_core: core 3.6.5
			com_electronwill_night-config_toml: toml 3.6.5
			com_ibm_async_asyncutil: asyncutil 0.1.0
			org_threadly_threadly: threadly 7.0
		carpet: Carpet Mod 1.4.79
		clear-skies: Clear Skies 2.0.93
		clientsidenoteblocks: ClientSideNoteblocks 2.2
		continuity: Continuity 2.0.0+1.19
		cullleaves: Cull Leaves 2.3.4
			midnightlib: MidnightLib 0.5.2
		detailab: Detail Armor Bar 2.6.2+1.19-fabric
		dynamicfps: Dynamic FPS 2.1.0
			com_moandjiezana_toml_toml4j: toml4j 0.7.2
		effective: Effective 1.2.2
		entityculling: EntityCulling-Fabric 1.5.2-mc1.19
			com_logisticscraft_occlusionculling: occlusionculling 0.0.6-SNAPSHOT
		essential: Essential 3018+feature-fabric-1.19
		essential-container: essential-container 1.0.0
			essential-loader: essential-loader 1.0.0
		fabric: Fabric API 0.55.3+1.19
			fabric-api-base: Fabric API Base 0.4.9+e62f51a3a9
			fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.6+9ff28f40a9
			fabric-biome-api-v1: Fabric Biome API (v1) 9.0.12+e62f51a3a9
			fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.18+9ff28f40a9
			fabric-command-api-v1: Fabric Command API (v1) 1.2.5+f71b366fa9
			fabric-command-api-v2: Fabric Command API (v2) 2.1.1+cda9839ba9
			fabric-commands-v0: Fabric Commands (v0) 0.2.22+df3654b3a9
			fabric-containers-v0: Fabric Containers (v0) 0.1.27+df3654b3a9
			fabric-content-registries-v0: Fabric Content Registries (v0) 3.0.16+9ff28f40a9
			fabric-convention-tags-v1: Fabric Convention Tags 1.0.8+37622d24a9
			fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.3+bd0a0d4aa9
			fabric-data-generation-api-v1: Fabric Data Generation API (v1) 5.0.1+2a5b9210a9
			fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.27+72da3b3da9
			fabric-entity-events-v1: Fabric Entity Events (v1) 1.4.16+9ff28f40a9
			fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.26+9ff28f40a9
			fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.24+df3654b3a9
			fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.19+18990361a9
			fabric-item-api-v1: Fabric Item API (v1) 1.5.4+767db26ea9
			fabric-item-groups-v0: Fabric Item Groups (v0) 0.3.23+9ff28f40a9
			fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.18+9ff28f40a9
			fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.16+df3654b3a9
			fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.0.9+21a5acaaa9
			fabric-loot-api-v2: Fabric Loot API (v2) 1.0.1+9e7660c6a9
			fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.1.1+9e7660c6a9
			fabric-message-api-v1: Fabric Message API (v1) 1.0.1+513f4a59a9
			fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.7+9ff28f40a9
			fabric-models-v0: Fabric Models (v0) 0.3.15+9ff28f40a9
			fabric-networking-api-v1: Fabric Networking API (v1) 1.0.27+7fe97409a9
			fabric-networking-v0: Fabric Networking (v0) 0.3.14+df3654b3a9
			fabric-object-builder-api-v1: Fabric Object Builder API (v1) 4.0.5+9ff28f40a9
			fabric-particles-v1: Fabric Particles (v1) 1.0.8+dc39553aa9
			fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.9.16+92cf9a3ea9
			fabric-renderer-api-v1: Fabric Renderer API (v1) 1.0.8+9ff28f40a9
			fabric-renderer-indigo: Fabric Renderer - Indigo 0.6.6+9ff28f40a9
			fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.18+df3654b3a9
			fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.12+9ff28f40a9
			fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.0.5+9ff28f40a9
			fabric-rendering-v0: Fabric Rendering (v0) 1.1.20+df3654b3a9
			fabric-rendering-v1: Fabric Rendering (v1) 1.10.14+9ff28f40a9
			fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.0.9+e62f51a3a9
			fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.5.3+9e7660c6a9
			fabric-screen-api-v1: Fabric Screen API (v1) 1.0.23+9ff28f40a9
			fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.2.6+9ff28f40a9
			fabric-textures-v0: Fabric Textures (v0) 1.0.18+9ff28f40a9
			fabric-transfer-api-v1: Fabric Transfer API (v1) 2.0.8+e62f51a3a9
			fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 1.1.1+9e7660c6a9
		fabricloader: Fabric Loader 0.14.7
		ferritecore: FerriteCore 4.2.1
		figura: Figura 0.0.8+1.19
			com_neovisionaries_nv-websocket-client: nv-websocket-client 2.14
			org_luaj_luaj-jse: luaj-jse 3.0.1
		illuminations: Illuminations 1.10.5
		indium: Indium 1.0.4+mc1.19
		inventoryhud: Inventory HUD + 3.4.2
		java: OpenJDK 64-Bit Server VM 17
		krypton: Krypton 0.2.0
			com_velocitypowered_velocity-native: velocity-native 3.1.2-SNAPSHOT
		lazydfu: LazyDFU 0.1.3
		minecraft: Minecraft 1.19
		modmenu: Mod Menu 4.0.0
		mousewheelie: Mouse Wheelie 1.8.9+mc1.19-pre1
			amecsapi: Amecs API 1.3.6+mc22w17a
			coat: Coat 1.0.0-beta.17+mc22w17a
			tweed4_annotated: tweed4_annotated 1.3.1+mc22w17a
			tweed4_base: tweed4_base 1.6.0+mc22w17a
			tweed4_data: tweed4_data 1.2.1+mc22w17a
			tweed4_data_hjson: tweed4_data_hjson 1.1.1+mc22w17a
			tweed4_tailor_coat: tweed4_tailor_coat 1.1.3+mc22w17a
			tweed4_tailor_screen: tweed4_tailor_screen 1.1.1+mc22w17a
		pistorder: Pistorder 1.5.0
		plasmo_voice: Plasmo Voice 1.2.14
		rainbowify: Rainbowify 2.0.0-alpha.1
		reeses-sodium-options: Reese's Sodium Options 1.4.3+mc1.19-build.43
		resclone: Resclone 1.9.0
			libjf-base: LibJF Base 2.9.1
		roughlyenoughitems: Roughly Enough Items 9.0.472
		roughlysearchable: Roughly Searchable 2.5.0+1.19
		shield_indicator: Shield Indicator 1.0.1
		showmeyourskin: Show Me Your Skin! 1.2.1+1.19
		skinlayers: 3d Skin Layers 1.4.7-mc1.19
		sodium: Sodium 0.4.2+build.16
			org_joml_joml: joml 1.10.4
		sodium-extra: Sodium Extra 0.4.5+mc1.19-build.43
			caffeineconfig: CaffeineConfig 1.0.0+1.17
		sspb: Sodium Shadowy Path Blocks 2.0.0
		starlight: Starlight 1.1.0+fabric.eb9df34
		suggestion_tweaker: Suggestion Tweaker 1.19-1.2.1
		tiefix: TieFix 1.11.0
		tooltiptweaks: Tooltip Tweaks 1.1.0
			cloth-config: Cloth Config v6 7.0.69
				cloth-basic-math: cloth-basic-math 0.6.1
		uiinputundo: UI Input Undo 1.2.0
		visuality: Visuality 0.5.0
		wpit: WPIT 1.4.0
	Launched Version: fabric-loader-0.14.7-1.19
	Backend library: LWJGL version 3.3.1 SNAPSHOT
	Backend API: Radeon RX 580 Series GL version 3.2.13596 Core Profile Forward-Compatible Context <IP_ADDRESS> 27.20.1034.6, ATI Technologies Inc.
	Window size: 2560x1017
	GL Caps: Using framebuffer using OpenGL 3.2
	GL debug messages:
	Using VBOs: Yes
	Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
	Type: Integrated Server (map_client.txt)
	Graphics mode: fancy
	Resource Packs: vanilla, Fabric Mods, continuity/default, continuity/glass_pane_culling_fix, cullleaves/smartleaves, file/Default-Dark-Mode-1.19-0.5-000000-(v1.3.2).zip
	Current Language: English (US)
	CPU: 6x Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
	Server Running: true
	Player Count: 1 / 8; [class_3222['SirInfinity'/66, l='ServerLevel[New World]', x=424.47, y=116.22, z=1529.94]]
	Data Packs: vanilla, Fabric Mods
	World Generation: Stable

Additional Context
No response

Does this happen when you just use BetterF3 and not all the rest of the mods? If it doesn't, can you try to take out some of your mods to help narrow down which mod it is. The stacktrace says there is no reducedDebugInfo field, so anything that might mess with that.

ah, i just checked and you were right. i just uninstalled betterf3 and it still crashed.
the weird part was before this (earlier today), at some point the mod was working fine. i could open and close the f3 menu with ease. so it must've been a mod i put in sometime between the time it worked and now. the only couple of mods that i can think of in that time period are continuity, controlling, reeses sodium options and inventorygui+. do you know any of my mods that may be incompatible with betterf3?
also im not really sure about the reducedDebugInfo part, not many of my mods stand out as messing with that part

I would just remove one mod at a time until you are able to figure out which one it is and I can see if there's a fix with that mod specifically then.

ok so here is the thing

whoops accidentally closed the issue

In that case, there's not much I personally can do unless I can get more information. If the client crashes with BetterF3 uninstalled then it must be another mod and using trial and error to find which one is the best way to go about it.


Potential improvement in function m_partition_S_XYZ()

The current function m_partition_S_XYZ() fills all details of a subset. However, a number of the subsets are eventually empty. It's an opportunity to improvement performance by not filling details of an empty subset.

Doesn't sounds like a good idea anymore; it's pretty cheap to fill in all the details, and the suggested approach would involve branches!


Add LearnPeriodic

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

LearnPeriodic: A website to check your Periodic Table knowledge and learn it interactively.
Link to Website

LearnPeriodic: https://akshit-senpai.github.io/LearnPeriodic/

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

recheck

I am sorry i added the file to the wrong folder will correct it...


Jellyfin parser

Hi guys and @LePresidente (Emby parser dev),
How hard is it to create a Jellyfin parser?
The logs are in a file format like this: log_20230212.log with the relevant auth data like this:
invalid user:
[2023-02-12 12:16:05.728 +01:00] [ERR] [79] Jellyfin.Server.Implementations.Users.UserManager: Error authenticating with provider "Default"
MediaBrowser.Controller.Authentication.AuthenticationException: Specified user does not exist.
   at Jellyfin.Server.Implementations.Users.DefaultAuthenticationProvider.Authenticate(String username, String password, User resolvedUser)
   at Jellyfin.Server.Implementations.Users.UserManager.AuthenticateWithProvider(IAuthenticationProvider provider, String username, String password, User resolvedUser)
[2023-02-12 12:16:05.729 +01:00] [INF] [79] Jellyfin.Server.Implementations.Users.UserManager: Authentication request for "tim" has been denied (IP: "<IP_ADDRESS>").
[2023-02-12 12:16:05.730 +01:00] [ERR] [79] Jellyfin.Server.Middleware.ExceptionMiddleware: Error processing request: "Invalid username or password entered". URL "POST" "/Users/authenticatebyname".

User ok, but invalid password:
[2023-02-12 12:17:17.673 +01:00] [ERR] [66] Jellyfin.Server.Implementations.Users.UserManager: Error authenticating with provider "Default"
MediaBrowser.Controller.Authentication.AuthenticationException: Invalid username or password
   at Jellyfin.Server.Implementations.Users.DefaultAuthenticationProvider.Authenticate(String username, String password, User resolvedUser)
   at Jellyfin.Server.Implementations.Users.UserManager.AuthenticateWithProvider(IAuthenticationProvider provider, String username, String password, User resolvedUser)
[2023-02-12 12:17:17.684 +01:00] [INF] [66] Jellyfin.Server.Implementations.Users.UserManager: Authentication request for "jeroen" has been denied (IP: "<IP_ADDRESS>").
[2023-02-12 12:17:17.685 +01:00] [ERR] [66] Jellyfin.Server.Middleware.ExceptionMiddleware: Error processing request: "Invalid username or password entered". URL "POST" "/Users/authenticatebyname".

Is it possible to create a acquis file with a log file that changes his name every day? Are datetime variables even possible?
On my installation there are 3 log files, so today they are like this:
log_20230210.log
log_20230211.log
log_20230212.log
So maybe we can add log_*.log to the acquis file?

I am trying to create a grok pattern, but failed. Loz is helping me out on Discord. So far, iv come up with this pattern:
pattern: '\[%{TIMESTAMP_ISO8601:timestamp}\].*Authentication request for "%{DATA:user}" has been denied \(IP: "%{IP:source_ip}"\)\.$'
And
pattern_syntax:
  TIMESTAMP_WORKAROUND: '%{YEAR}-%{MONTHNUM}-%{MONTHDAY}[T ]%{HOUR}:%{MINUTE}:%{SECOND}\.%{INT:milliseconds}[T ]%{ISO8601_TIMEZONE}'
nodes:
  - grok:
      pattern: '\[%{TIMESTAMP_WORKAROUND:timestamp}\].*Authentication request for "%{DATA:username}" has been denied \(IP: "%{IP:source_ip}"\)'

I am open for helping hands since its the first time in creating such a pattern.


[critical] UNIXServer delete important file if it cannot bind to it

While writing the test for #3763 I realized there is another critical bug :
require "socket"

def check_file(prefix, file)
  if File.exists? file
    puts "#{prefix} File exists"
  else
    puts "#{prefix} No file"
  end
end

path = "/tmp/important_file"

# create an important file
File.write path, "important content"

check_file "Touch/", path

# try to bind
begin
  UNIXServer.new path
rescue err
  puts "Error raised !"
  puts
  check_file "Server/", path
  puts "Error was: #{err.message}"
end

Output for master, Crystal 0.20.3 :
Using compiled compiler at .build/crystal
Touch/ File exists
Error raised !

Server/ No file
Error was: bind: Address already in use

It is caused by the close in UNIXServer#new L32
Which will delete the file if you cannot bind to it

Yes, I think this is a bug. The file should only be deleted on close if it's successfully bound.
I also tried it in Ruby (rescue => err instead of rescue err) and it doesn't delete the file.

Yes. I'll fix that.

@Bew78LesellB thanks for detecting this issue!


fix issue 1894: the etcdDownloadURLBase is missing for azure china cloud

What this PR does / why we need it:
Need to explicitly set all KubernetesSpecConfig fields default value in AzureChinaCloudSpec.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1894
Special notes for your reviewer:
Release note:

Thanks @pengzhisun !


[1.16] Cactus Gathering

Industrial Foregoing Version: industrial-foregoing-1.16.4-3.2.7-7d95990
Titanium Version: titanium-1.16.4-3.2.4
Crashlog (If Any): None
The Plant Gatherer appears to function on cacti like it does on trees. A harvester I was setting up to harvest cacti also harvested a lot of wood logs outside of its operating range, and the entire cactus plant. I'd imagine the intended function of the gatherer on cacti would be identical to how it currently functions with sugar cane, leaving the bottom block and collecting the grown parts, however it appears to use tree gathering functionality.

Some mod might be adding the log tag to the cactus. It works fine in dev.

Some mod might be adding the log tag to the cactus. It works fine in dev.


Added notifications, simplified time options

Thanks for the PR, but I don't think I will accept any changes. pomodoro is a simple utility that fulfills my needs (the most important of which is the need to screw around with code).
In terms of notifications, I prefer to be explicit with pomodoro && growlnotify. In terms of command line interface, I prefer the ease of not having to write -d. Just my personal preferences. Let your fork follow yours.


Content Update - Synapse Link

[Enter feedback here]
Hello @davidiseminger and @maggiesMSFT
Can you please update this content and replace SQL DW with Azure Synapse Analytics and also Azure Synapse Link?
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c34c249-033f-4156-0abc-8d16cbe355a0
Version Independent ID: 20dc29c2-9cb7-2322-e80b-3f801bc34cfe
Content: Power BI data sources - Power BI
Content Source: powerbi-docs/connect-data/power-bi-data-sources.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Hi @Rodrigossz , thanks for your comment. I have forwarded it along to David. He'll take a look at this soon.

Hello @davidiseminger and @paulinbar
It would be great if you could drill down to Synapse runtime level: Instead of Azure Synapse Analytics, be specific to SQL Pool, SQL serverless Pool, Spark Pool, etc.
Tks

Completed - thanks!


Throttle Configuration in Transmit routeHandlerModifier Results in Error

Package version
1.0.2
Describe the bug
I am facing an issue when using the Transmit package along with the Limiter in AdonisJS 6. Below is a detailed description of the problem and the relevant code:
In the config/transmit.ts file, I am trying to add throttle using the routeHandlerModifier() method as per the documentation:
// config/transmit.ts
import { defineConfig } from '@adonisjs/transmit'
import { throttle } from '#start/limiter'

export default defineConfig({
  pingInterval: false,
  transport: null,
  routeHandlerModifier(route) {
    route.use(throttle)
  },
})

However, on the line route.use(throttle), I am encountering the following error:
TypeError: Cannot read properties of undefined (reading 'define')

   at <anonymous> start\limiter.ts:3
   1|  import limiter from '@adonisjs/limiter/services/main'
   2|
 > 3|  export const throttle = limiter.define('global', () => {
   4|    return limiter.allowRequests(10).every('1 minute')
   5|  })
   6|

Below is the code from the start/limiter.ts file:
// start/limiter.ts
import limiter from '@adonisjs/limiter/services/main'

export const throttle = limiter.define('global', () => {
  return limiter.allowRequests(10).every('1 minute')
})

The throttle works perfectly fine on routes defined in start/routes.ts, but when trying to use it in config/transmit.ts, the above error is thrown.
Could you please help me understand what is causing this issue? Is there any modification needed in the code or configuration to resolve this error?
Thank you in advance for your help!
Reproduction repo
No response

Import limiter inside the callback, not at the top of the file.

@RomainLanz How about removing the route configuration from the config file and instead provide a programmatic API for the same? Something like.
transmit.configureRoute((route) => {
})

This way this code could live in start/transmit.ts file

Yeah, that would be a nice addition

Hey @joaosilva0345! 👋🏻
Import limiter inside the callback, not at the top of the file.

Hi
Thank you for the solution! I followed your suggestion to import the limiter inside the callback, and it worked perfectly.
I really thought I had already tested this approach, but I was mistaken. I went through several different attempts at solutions, and the correct one was right in front of me.
Thank you again for your help!


Learning next.js Chapter 12  updating invoice bug

Verify canary release

[X] I verified that the issue exists in the latest Next.js canary release

Provide environment information
next info

Which example does this report relate to?
Learn next.js chapter 12
What browser are you using? (if relevant)
chrome
How are you deploying your application? (if relevant)
next learning
Describe the Bug
export async function updateInvoice(id: string, formData: FormData) {
const { customerId, amount, status } = UpdateInvoice.parse({
customerId: formData.get('customerId'),
amount: formData.get('amount'),
status: formData.get('status'),
});
Above code should be:
export async function updateInvoice(id: string, formData: FormData) {
const { customerId, amount, status } = UpdateInvoice.parse({
id: formData.get('id'),
customerId: formData.get('customerId'),
amount: formData.get('amount'),
status: formData.get('status'),
});
Expected Behavior
not error prone.
To Reproduce
export async function updateInvoice(id: string, formData: FormData) {
const { customerId, amount, status } = UpdateInvoice.parse({
id: formData.get('id'),
customerId: formData.get('customerId'),
amount: formData.get('amount'),
status: formData.get('status'),
});

Alternative solution would be replacing:
const UpdateInvoice = InvoiceSchema.omit({ date: true}
with:
const UpdateInvoice = InvoiceSchema.omit({ date: true, id: true });
but yeah error persists and user will get 404 error.

Duplicated #367

Thank you for reporting this @BattulgaBilguun, and @radoslaw-niedbala for the answer 🙏🏼 . The code snippets were incorrect, we've updated them, and should be landing soon.


Add missing secrets tests

List of tests:

Update Secret
Get Secret
Get Secret Specific Version
Delete Secret (Non Existing)
Get Deleted Secret (Non Existing)
Recover Deleted Secret (Non Existing)
Backup Secret
Backup Secret (Non Existing)
Restore Secret (Malformed Backup Bytes)
List Secret Versions (Non Existing)

FYI @Azure/adp-keyvault


Global Badges show up as 100% complete but not yet achieved in client display

In client-display -> My Badges and the My Progress -> My Badges view, Global Badges that have only Project Level requirements show up as 100% complete if the user has A level > 0 in the required Projects for the badge, but does not have the required level for all Projects. There may be other cases.
Steps to reproduce:

Create a Global Badge
Add Project Level requirements for two different projects (and no Skill requirements)
Create a user who has a level > 0 in both required projects but < then the required level in at least ONE of the required projects

PR #871

:+1:


chore: don't pack example/ and test/ folders and other dev files

currently this package includes many files that aren't needed at runtime. This PR npmignores them

Test Plan
run npm pack. You should see only these files packed
npm notice === Tarball Contents ===
npm notice 592B   .github/FUNDING.yml
npm notice 6.6kB  CHANGELOG.md
npm notice 1.1kB  LICENSE
npm notice 4.1kB  README.md
npm notice 2.1kB  index.js
npm notice 38.8kB json-stable-stringify-1.0.2.tgz
npm notice 2.0kB  package.json

@ljharb thanks for the quick response! Could u elaborate on why that's necessary? I imagine this can bloat node_modules quite a bit for other projects (maybe not json-stable-stringify/jsonify specifically). Can't the consumers who want to check tests clone the github repo and check out the tag (and compare files to npm contents if they really need to)?

I don't particularly care about bloated node_modules; disk space is infinite and free.
Cloning the repo requires an internet connection, and, since repos are mutable (like this package's original repo), not guaranteed to exist at all.

haha understood. What brought me here was actually a different reason. We audit all lines of code that make it to build machines, so this made audit pretty painful. Your module your choice of course

That seems like a really impractical policy, given that tons of code will exist in node_modules that doesn't end up in production, and is thus irrelevant.


Attempting to use CAT in testground fails

When running testground tests that use the v2 mempool, we fail to reach consensus after a few blocks. Its unclear why this occurs atm, but we need to fix this before we can get data on the improvement CAT offers along with feeling confident to try it more broadly on testnets.

the exact same test but configured for v1 works as intented. I'm not sure if its a testground thing or not tho

can close with https://github.com/celestiaorg/celestia-app/pull/3014

Out of curiosity, what was wrong with CAT pool? How does https://github.com/celestiaorg/celestia-app/pull/3014 fix?

I don't think anything is wrong afaict atm, it was just an issue somewhere in testground